From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358751.588086 (Exim 4.92) (envelope-from ) id 1o74Em-0002bI-I3; Fri, 01 Jul 2022 00:10:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358751.588086; Fri, 01 Jul 2022 00:10:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Em-0002bB-E0; Fri, 01 Jul 2022 00:10:20 +0000 Received: by outflank-mailman (input) for mailman id 358751; Fri, 01 Jul 2022 00:10:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Ek-0002b5-PZ for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:19 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e8215e7-f8d2-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 02:10:16 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 69BD05C00A3; Thu, 30 Jun 2022 20:10:14 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:10:14 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:13 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e8215e7-f8d2-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1656634214; x= 1656720614; bh=fRJBB2CnMIUg5NV6nJ1IufinDZDpHUNh3Z3kruSktl4=; b=G SQUgBB/OofT0S7UUpxWUxZTSC9Y1LQBQIjBq/gm4fp0nw5xHNDQreTg9VowkMAxt EhEKitapukHcXfzENJLEFZ9NsPlsW/IoHEu+/qskPkOU7C8L3bMDHT0Rd3Wae2Dr RbL5Y9I7i0AyZ62aBC7DURbzF0an8WR4yyjfIG14qPRDBRqQd7S/FlpBziqjCYYp nTkT0EdssNY65h6w5LtV1CdfHpv+bYgUaRvpkEaGPhrGjaj4x/zE7WEX1xm62ID1 rlOuV1V8FxOpFwsamvYPjLqbS5rA9twX3ydYfw6shQGHLvZkQyf2XFhSwbpMekOq 17vmlUyt88STvsd/MQXMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1656634214; x=1656720614; bh=fRJBB2CnMIUg5NV6nJ1IufinDZDpHUNh3Z3 kruSktl4=; b=jHcx3cb+99Pmwul9hx4GDn0f3r/luzIRSDzAfyPV4gFBbaL3qAy CNyPqGXZJ399fxvhdtsEBwQeTe5nc8rhBRDkZeOQnvvesBLMirp6uXjZ5w0dXltT fVx7NnMU9fhINvDJcujo6yPDLiLXw7dD3Zj+WBRW+ImrpezSH2Fa3C6RToUUY729 BjGSu5hhLAZ+SA+x+GbXjagGs+cdcDrZ9c1JkEhTCBL4e/2lJFOUSh0SydSQV0fk s0w+gNAsOKplUrqpxUKfXOFbDAUMQqeDwyBK9EyEHDRapkfImIdkInmSPi2eEPl+ AMhV0avXyy+FrEdCATj7waDhlVkvFKL2Pqg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion Subject: Hopefully correct backports for gntdev deadlock Date: Thu, 30 Jun 2022 20:09:47 -0400 Message-Id: <20220701000951.5072-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This backports "xen/gntdev: Avoid blocking in unmap_grant_pages()" to the various stable trees, hopefully correctly. From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358752.588096 (Exim 4.92) (envelope-from ) id 1o74Ez-0002td-PV; Fri, 01 Jul 2022 00:10:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358752.588096; Fri, 01 Jul 2022 00:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Ez-0002tV-Mg; Fri, 01 Jul 2022 00:10:33 +0000 Received: by outflank-mailman (input) for mailman id 358752; Fri, 01 Jul 2022 00:10:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Ey-0002sL-4o for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:32 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 34b26133-f8d2-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 02:10:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1FFAB5C00A1; Thu, 30 Jun 2022 20:10:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:10:25 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:24 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34b26133-f8d2-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1656634225; x=1656720625; bh=yTEJkSST24NIw95BPpFimdplwrBSrciaEJm hkgljwhI=; b=WBmyv3IVbKkBZPFtLeFiPonrjsF1s1W26Th7pq0CsBKJE4bt1l0 zHKyeEu/GOGKKoNz3lvAdQd/WJNdJ29rDeEOoilO2cBMPNpgqm3GdDcgP6LNOo5p C36qm7kCNxkRC46URc+VoU529osjgnTnn+1UXgMNffyktDYx/+Yff40eG6VvQ7Jy W2jWwQ3IUwZyTYX6L64RnQMNev8+D+CxXlKKtI42ZOCLLiaOp1QXCjtWrMDU2HhP +S6pebEozFX8mgpO7KshVBO3Rwj38mWkRONDlTyj9ElDc02u/3UVmcZans299szL NxZlCT/3TqdgXVxpA1o/9WZKoQ80UzNmXpA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656634225; x=1656720625; bh=yTEJkSST24NIw 95BPpFimdplwrBSrciaEJmhkgljwhI=; b=AzMpsogVRHtvtSEvHIMa52uw7NBY0 LaUsCmksCdbwjyLhVYiTav1hXBlE8B/Km4+excZBbZk9dRdTErf1GgNU0FQhmQze BdvfrvEU4q0YRNVWPK4K6/JvGvNCPcwie8Qgt98BWX/sIgcdQ+TrPdTgoaty2w7E r0aI/feTbW0FGuik2R1Y/Waaq72Z6lgJOrRKq7mRENtD4lfdeTleJq/IT+dlGrZ/ rMYsfiWrWTeaqFnIAHobb+xDVcwe8fcsOOMbN4vnnrF0Qtc8vAcOdo8eilA8Ahpi mhNdzsvkNGitPnZrLB6nhsM3I2Q3OhUVBrTvjZtu39oEPhGhN5y/nkEUg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion , Demi Marie Obenour Subject: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Thu, 30 Jun 2022 20:09:48 -0400 Message-Id: <20220701000951.5072-2-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. It is also necessary to guard against reentrancy in gntdev_map_put(), and to handle the case where userspace tries to map a mapping whose contents have not all been freed yet. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisiblethingslab.com Signed-off-by: Juergen Gross --- drivers/xen/gntdev-common.h | 7 ++ drivers/xen/gntdev.c | 140 +++++++++++++++++++++++++----------- 2 files changed, 106 insertions(+), 41 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 20d7d059dadb..40ef379c28ab 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -16,6 +16,7 @@ #include #include #include +#include struct gntdev_dmabuf_priv; @@ -56,6 +57,7 @@ struct gntdev_grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; @@ -73,6 +75,11 @@ struct gntdev_grant_map { /* Needed to avoid allocation in gnttab_dma_free_pages(). */ xen_pfn_t *frames; #endif + + /* Number of live grants */ + atomic_t live_grants; + /* Needed to avoid allocation in __unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 54778aadf618..f415c056ff8a 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include @@ -60,10 +61,11 @@ module_param(limit, uint, 0644); MODULE_PARM_DESC(limit, "Maximum number of grants that may be mapped by one mapping request"); +/* True in PV mode, false otherwise */ static int use_ptemod; -static int unmap_grant_pages(struct gntdev_grant_map *map, - int offset, int pages); +static void unmap_grant_pages(struct gntdev_grant_map *map, + int offset, int pages); static struct miscdevice gntdev_miscdev; @@ -120,6 +122,7 @@ static void gntdev_free_map(struct gntdev_grant_map *map) kvfree(map->unmap_ops); kvfree(map->kmap_ops); kvfree(map->kunmap_ops); + kvfree(map->being_removed); kfree(map); } @@ -140,12 +143,15 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, add->kunmap_ops = kvcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kvcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kvcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || NULL == add->kmap_ops || NULL == add->kunmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC @@ -240,9 +246,36 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) if (!refcount_dec_and_test(&map->users)) return; - if (map->pages && !use_ptemod) + if (map->pages && !use_ptemod) { + /* + * Increment the reference count. This ensures that the + * subsequent call to unmap_grant_pages() will not wind up + * re-entering itself. It *can* wind up calling + * gntdev_put_map() recursively, but such calls will be with a + * reference count greater than 1, so they will return before + * this code is reached. The recursion depth is thus limited to + * 1. Do NOT use refcount_inc() here, as it will detect that + * the reference count is zero and WARN(). + */ + refcount_set(&map->users, 1); + + /* + * Unmap the grants. This may or may not be asynchronous, so it + * is possible that the reference count is 1 on return, but it + * could also be greater than 1. + */ unmap_grant_pages(map, 0, map->count); + /* Check if the memory now needs to be freed */ + if (!refcount_dec_and_test(&map->users)) + return; + + /* + * All pages have been returned to the hypervisor, so free the + * map. + */ + } + if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); evtchn_put(map->notify.event); @@ -288,6 +321,7 @@ static int set_grant_ptes_as_special(pte_t *pte, unsigned long addr, void *data) int gntdev_map_grant_pages(struct gntdev_grant_map *map) { + size_t alloced = 0; int i, err = 0; if (!use_ptemod) { @@ -336,87 +370,109 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) map->pages, map->count); for (i = 0; i < map->count; i++) { - if (map->map_ops[i].status == GNTST_okay) + if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - else if (!err) + if (!use_ptemod) + alloced++; + } else if (!err) err = -EINVAL; if (map->flags & GNTMAP_device_map) map->unmap_ops[i].dev_bus_addr = map->map_ops[i].dev_bus_addr; if (use_ptemod) { - if (map->kmap_ops[i].status == GNTST_okay) + if (map->kmap_ops[i].status == GNTST_okay) { + if (map->map_ops[i].status == GNTST_okay) + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; - else if (!err) + } else if (!err) err = -EINVAL; } } + atomic_add(alloced, &map->live_grants); return err; } -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; + unsigned int i; + struct gntdev_grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); + pr_debug("unmap handle=%d st=%d\n", + map->unmap_ops[offset+i].handle, + map->unmap_ops[offset+i].status); + map->unmap_ops[offset+i].handle = -1; + } + /* + * Decrease the live-grant counter. This must happen after the loop to + * prevent premature reuse of the grants by gnttab_mmap(). + */ + atomic_sub(data->count, &map->live_grants); + + /* Release reference taken by __unmap_grant_pages */ + gntdev_put_map(NULL, map); +} + +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) +{ if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); + if (pgno >= offset && pgno < offset + pages) { /* No need for kmap, pages are in lowmem */ uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; } } - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + refcount_inc(&map->users); /* to keep map alive during async call below */ - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; - - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; - pr_debug("unmap handle=%d st=%d\n", - map->unmap_ops[offset+i].handle, - map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; - } - return err; + gnttab_unmap_refs_async(&map->unmap_data); } -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) { - int range, err = 0; + int range; + + if (atomic_read(&map->live_grants) == 0) + return; /* Nothing to do */ pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + if (range) + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -468,7 +524,6 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn, struct gntdev_grant_map *map = container_of(mn, struct gntdev_grant_map, notifier); unsigned long mstart, mend; - int err; if (!mmu_notifier_range_blockable(range)) return false; @@ -489,10 +544,9 @@ static bool gntdev_invalidate(struct mmu_interval_notifier *mn, map->index, map->count, map->vma->vm_start, map->vma->vm_end, range->start, range->end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); return true; } @@ -980,6 +1034,10 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto unlock_out; if (use_ptemod && map->vma) goto unlock_out; + if (atomic_read(&map->live_grants)) { + err = -EAGAIN; + goto unlock_out; + } refcount_inc(&map->users); vma->vm_ops = &gntdev_vmops; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358753.588103 (Exim 4.92) (envelope-from ) id 1o74F0-0002xJ-5M; Fri, 01 Jul 2022 00:10:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358753.588103; Fri, 01 Jul 2022 00:10:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Ez-0002wy-W4; Fri, 01 Jul 2022 00:10:34 +0000 Received: by outflank-mailman (input) for mailman id 358753; Fri, 01 Jul 2022 00:10:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Ey-0002sL-Oz for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:32 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37743170-f8d2-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 02:10:30 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B8B6E5C00A4; Thu, 30 Jun 2022 20:10:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:10:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37743170-f8d2-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1656634229; x=1656720629; bh=rGkQptGCLsRn301ihqWzQ7mM8qUMGEhaJXH F+f9Z/zA=; b=lUFSC7og4g9/VxdbnqBW06hXo+hrcjI/Fgo7oW5hyhjp/hgAWTg Jk3PeLfmDF9z9Q1TLFENsmNoAcEgtNDNdEL2yVd92sqiOSBo1RVbyVdWvlVacz+a EHsgIvnTUe1hYBb4uRRXZrnVQIfs6gcoiA0rcPlNCqqWKSf0zTDwIokjvjJeuWfc 1nmi6uPsRIPNn9GMtLAsxAEHkQJy0aQ79Pvm+xh/cnG8EFflKkKDCol7Q+C0Jt0J lEoZ9BwooE1BJczSeJ7tsibgZ+dTPlBrzIF1s6yf7ek3CmBPE5dk5KJ0xA+0bO+V MUpW5Mp30/ETSn7/wh7e0EsssHK2FCznJkA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656634229; x=1656720629; bh=rGkQptGCLsRn3 01ihqWzQ7mM8qUMGEhaJXHF+f9Z/zA=; b=Od+u5NofmQ6I48maOiEqcWL5MisBx sOZO/r+bFeh8mA7kjaS9RkGdOoT4kJXJSwE7EZ9i7ZnLhA4uINtMpdsIU1xd12TG /n2L4w2/wn1bRE8UPWQgEvQwB9TgxR9Kk0Y4Qg1MkKVj6wmSC0MMc8rChOudK6lU gnRuDNxmCgxYP/c5a4g5trBqcsg3PjT6/MXoPNvo+1C19bn8VnY0zkhWrpe3BWMg dcL9kW8D2ThUDVjGU5Ihf15yv6xAdop1UF6K0ND8KkqIXFlJ6GqwHZeDmi15YJhp unlwplkMgxXlkHBhLeG/gBbQ6wd007r0eS0VwwcZ4TTZMh9drUxsClZ+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion , Demi Marie Obenour Subject: [PATCH 5.4] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Thu, 30 Jun 2022 20:09:49 -0400 Message-Id: <20220701000951.5072-3-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. It is also necessary to guard against reentrancy in gntdev_map_put(), and to handle the case where userspace tries to map a mapping whose contents have not all been freed yet. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisiblethingslab.com Signed-off-by: Juergen Gross --- drivers/xen/gntdev-common.h | 8 ++ drivers/xen/gntdev.c | 147 +++++++++++++++++++++++++----------- 2 files changed, 110 insertions(+), 45 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 2f8b949c3eeb..fab6f5a54d5b 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -15,6 +15,8 @@ #include #include #include +#include +#include struct gntdev_dmabuf_priv; @@ -61,6 +63,7 @@ struct gntdev_grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; @@ -78,6 +81,11 @@ struct gntdev_grant_map { /* Needed to avoid allocation in gnttab_dma_free_pages(). */ xen_pfn_t *frames; #endif + + /* Number of live grants */ + atomic_t live_grants; + /* Needed to avoid allocation in __unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index e953ea34b3e4..f46479347765 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -35,6 +35,7 @@ #include #include #include +#include #include #include @@ -62,11 +63,12 @@ MODULE_PARM_DESC(limit, "Maximum number of grants that may be mapped by " static atomic_t pages_mapped = ATOMIC_INIT(0); +/* True in PV mode, false otherwise */ static int use_ptemod; #define populate_freeable_maps use_ptemod -static int unmap_grant_pages(struct gntdev_grant_map *map, - int offset, int pages); +static void unmap_grant_pages(struct gntdev_grant_map *map, + int offset, int pages); static struct miscdevice gntdev_miscdev; @@ -123,6 +125,7 @@ static void gntdev_free_map(struct gntdev_grant_map *map) kfree(map->unmap_ops); kfree(map->kmap_ops); kfree(map->kunmap_ops); + kfree(map->being_removed); kfree(map); } @@ -142,12 +145,15 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, add->kmap_ops = kcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL); add->kunmap_ops = kcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || NULL == add->kmap_ops || NULL == add->kunmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC @@ -243,6 +249,35 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) return; atomic_sub(map->count, &pages_mapped); + if (map->pages && !use_ptemod) { + /* + * Increment the reference count. This ensures that the + * subsequent call to unmap_grant_pages() will not wind up + * re-entering itself. It *can* wind up calling + * gntdev_put_map() recursively, but such calls will be with a + * reference count greater than 1, so they will return before + * this code is reached. The recursion depth is thus limited to + * 1. Do NOT use refcount_inc() here, as it will detect that + * the reference count is zero and WARN(). + */ + refcount_set(&map->users, 1); + + /* + * Unmap the grants. This may or may not be asynchronous, so it + * is possible that the reference count is 1 on return, but it + * could also be greater than 1. + */ + unmap_grant_pages(map, 0, map->count); + + /* Check if the memory now needs to be freed */ + if (!refcount_dec_and_test(&map->users)) + return; + + /* + * All pages have been returned to the hypervisor, so free the + * map. + */ + } if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); @@ -298,6 +333,7 @@ static int set_grant_ptes_as_special(pte_t *pte, unsigned long addr, void *data) int gntdev_map_grant_pages(struct gntdev_grant_map *map) { + size_t alloced = 0; int i, err = 0; if (!use_ptemod) { @@ -346,87 +382,109 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) map->pages, map->count); for (i = 0; i < map->count; i++) { - if (map->map_ops[i].status == GNTST_okay) + if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - else if (!err) + if (!use_ptemod) + alloced++; + } else if (!err) err = -EINVAL; if (map->flags & GNTMAP_device_map) map->unmap_ops[i].dev_bus_addr = map->map_ops[i].dev_bus_addr; if (use_ptemod) { - if (map->kmap_ops[i].status == GNTST_okay) + if (map->kmap_ops[i].status == GNTST_okay) { + if (map->map_ops[i].status == GNTST_okay) + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; - else if (!err) + } else if (!err) err = -EINVAL; } } + atomic_add(alloced, &map->live_grants); return err; } -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; + unsigned int i; + struct gntdev_grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); + pr_debug("unmap handle=%d st=%d\n", + map->unmap_ops[offset+i].handle, + map->unmap_ops[offset+i].status); + map->unmap_ops[offset+i].handle = -1; + } + /* + * Decrease the live-grant counter. This must happen after the loop to + * prevent premature reuse of the grants by gnttab_mmap(). + */ + atomic_sub(data->count, &map->live_grants); + + /* Release reference taken by __unmap_grant_pages */ + gntdev_put_map(NULL, map); +} + +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) +{ if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); + if (pgno >= offset && pgno < offset + pages) { /* No need for kmap, pages are in lowmem */ uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; } } - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + refcount_inc(&map->users); /* to keep map alive during async call below */ - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; - - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; - pr_debug("unmap handle=%d st=%d\n", - map->unmap_ops[offset+i].handle, - map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; - } - return err; + gnttab_unmap_refs_async(&map->unmap_data); } -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) { - int range, err = 0; + int range; + + if (atomic_read(&map->live_grants) == 0) + return; /* Nothing to do */ pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + if (range) + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -496,7 +554,6 @@ static int unmap_if_in_range(struct gntdev_grant_map *map, bool blockable) { unsigned long mstart, mend; - int err; if (!in_range(map, start, end)) return 0; @@ -510,10 +567,9 @@ static int unmap_if_in_range(struct gntdev_grant_map *map, map->index, map->count, map->vma->vm_start, map->vma->vm_end, start, end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); return 0; } @@ -554,7 +610,6 @@ static void mn_release(struct mmu_notifier *mn, { struct gntdev_priv *priv = container_of(mn, struct gntdev_priv, mn); struct gntdev_grant_map *map; - int err; mutex_lock(&priv->lock); list_for_each_entry(map, &priv->maps, next) { @@ -563,8 +618,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } list_for_each_entry(map, &priv->freeable_maps, next) { if (!map->vma) @@ -572,8 +626,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } mutex_unlock(&priv->lock); } @@ -1102,6 +1155,10 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto unlock_out; } + if (atomic_read(&map->live_grants)) { + err = -EAGAIN; + goto unlock_out; + } refcount_inc(&map->users); vma->vm_ops = &gntdev_vmops; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358755.588119 (Exim 4.92) (envelope-from ) id 1o74F2-0003RM-GQ; Fri, 01 Jul 2022 00:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358755.588119; Fri, 01 Jul 2022 00:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F2-0003R7-Bi; Fri, 01 Jul 2022 00:10:36 +0000 Received: by outflank-mailman (input) for mailman id 358755; Fri, 01 Jul 2022 00:10:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F1-0002b5-0u for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:35 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3943ad1a-f8d2-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 02:10:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BA7315C00FE; Thu, 30 Jun 2022 20:10:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 30 Jun 2022 20:10:32 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3943ad1a-f8d2-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1656634232; x=1656720632; bh=T8FZAiMVrSk0IGEy6kRyukwRyt/paMIRFC2 EEKHMMZo=; b=Q0EICh4RzjkVoaINIUtwpLX/Tr0/A8gY/SVO8cvqIeardWk4v9O WmkEbPA24sPswHzI6Acd4s5v/7GGNIOM0kvKFYHE5ckAXBfwkxgE7EW571sZjbde 153LTxiOldfamGY2hRv5DaHAgqORBYKZJDwRxb1V/Vn/W58flvn5JUQCq6Eo9GJO 0+IrkEq7JGB/Tspz6WMGSIJ/bSTMPzjW0+iqKcaShC9+uR9X5FJeLvhjyzEdi6Ww PLH2fo9f/EBugioQcCSQwMPSKEyKiQca78ekxk4tuJteSj2NMX5RIYIVjbsPFzYB VJzDdzK2IwaQbxzBH1YjoRMfFa1qd9OiS7g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656634232; x=1656720632; bh=T8FZAiMVrSk0I GEy6kRyukwRyt/paMIRFC2EEKHMMZo=; b=ZYFJxIUEPJVKM590HyY3ZT81G97ex ZfMYNoaJbHxt7GCdO5iTzDZxS/pMYJSWFZJflqGmGK0cDCCgq+ameV1ntsMNiJvr 1LEUR7D9H5XC+sgwpHKEQegAosh6hs0EOovJJkL+DdDxIE/38NM8rIF3/pde3Feu 7iSpXu7UX73aQbe6lYIArn1dM/tosF9/83eiDQOK50irBhP3yC2t8H5mjTrw/5gJ Rmayopzgf7IUHW9jDUzEfmXAn+sOZv81VoTLg6tKrg7DmHKmEyx5xZM+SYSb8SnO djroPlLuJLb5O9pc2SAjZS3Gx3F3+vZlMAtOoRst2jtvYxLyFgi5k+ldQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion , Demi Marie Obenour Subject: [PATCH 4.19] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Thu, 30 Jun 2022 20:09:50 -0400 Message-Id: <20220701000951.5072-4-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. It is also necessary to guard against reentrancy in gntdev_map_put(), and to handle the case where userspace tries to map a mapping whose contents have not all been freed yet. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisiblethingslab.com Signed-off-by: Juergen Gross --- drivers/xen/gntdev-common.h | 8 ++ drivers/xen/gntdev.c | 146 +++++++++++++++++++++++++----------- 2 files changed, 109 insertions(+), 45 deletions(-) diff --git a/drivers/xen/gntdev-common.h b/drivers/xen/gntdev-common.h index 2f8b949c3eeb..fab6f5a54d5b 100644 --- a/drivers/xen/gntdev-common.h +++ b/drivers/xen/gntdev-common.h @@ -15,6 +15,8 @@ #include #include #include +#include +#include struct gntdev_dmabuf_priv; @@ -61,6 +63,7 @@ struct gntdev_grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; @@ -78,6 +81,11 @@ struct gntdev_grant_map { /* Needed to avoid allocation in gnttab_dma_free_pages(). */ xen_pfn_t *frames; #endif + + /* Number of live grants */ + atomic_t live_grants; + /* Needed to avoid allocation in __unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index e519063e421e..492084814f55 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -64,11 +64,12 @@ MODULE_PARM_DESC(limit, "Maximum number of grants that may be mapped by " static atomic_t pages_mapped = ATOMIC_INIT(0); +/* True in PV mode, false otherwise */ static int use_ptemod; #define populate_freeable_maps use_ptemod -static int unmap_grant_pages(struct gntdev_grant_map *map, - int offset, int pages); +static void unmap_grant_pages(struct gntdev_grant_map *map, + int offset, int pages); static struct miscdevice gntdev_miscdev; @@ -125,6 +126,7 @@ static void gntdev_free_map(struct gntdev_grant_map *map) kfree(map->unmap_ops); kfree(map->kmap_ops); kfree(map->kunmap_ops); + kfree(map->being_removed); kfree(map); } @@ -144,12 +146,15 @@ struct gntdev_grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count, add->kmap_ops = kcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL); add->kunmap_ops = kcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || NULL == add->kmap_ops || NULL == add->kunmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; #ifdef CONFIG_XEN_GRANT_DMA_ALLOC @@ -245,6 +250,35 @@ void gntdev_put_map(struct gntdev_priv *priv, struct gntdev_grant_map *map) return; atomic_sub(map->count, &pages_mapped); + if (map->pages && !use_ptemod) { + /* + * Increment the reference count. This ensures that the + * subsequent call to unmap_grant_pages() will not wind up + * re-entering itself. It *can* wind up calling + * gntdev_put_map() recursively, but such calls will be with a + * reference count greater than 1, so they will return before + * this code is reached. The recursion depth is thus limited to + * 1. Do NOT use refcount_inc() here, as it will detect that + * the reference count is zero and WARN(). + */ + refcount_set(&map->users, 1); + + /* + * Unmap the grants. This may or may not be asynchronous, so it + * is possible that the reference count is 1 on return, but it + * could also be greater than 1. + */ + unmap_grant_pages(map, 0, map->count); + + /* Check if the memory now needs to be freed */ + if (!refcount_dec_and_test(&map->users)) + return; + + /* + * All pages have been returned to the hypervisor, so free the + * map. + */ + } if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); @@ -302,6 +336,7 @@ static int set_grant_ptes_as_special(pte_t *pte, pgtable_t token, int gntdev_map_grant_pages(struct gntdev_grant_map *map) { + size_t alloced = 0; int i, err = 0; if (!use_ptemod) { @@ -350,87 +385,109 @@ int gntdev_map_grant_pages(struct gntdev_grant_map *map) map->pages, map->count); for (i = 0; i < map->count; i++) { - if (map->map_ops[i].status == GNTST_okay) + if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - else if (!err) + if (!use_ptemod) + alloced++; + } else if (!err) err = -EINVAL; if (map->flags & GNTMAP_device_map) map->unmap_ops[i].dev_bus_addr = map->map_ops[i].dev_bus_addr; if (use_ptemod) { - if (map->kmap_ops[i].status == GNTST_okay) + if (map->kmap_ops[i].status == GNTST_okay) { + if (map->map_ops[i].status == GNTST_okay) + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; - else if (!err) + } else if (!err) err = -EINVAL; } } + atomic_add(alloced, &map->live_grants); return err; } -static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; + unsigned int i; + struct gntdev_grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); + pr_debug("unmap handle=%d st=%d\n", + map->unmap_ops[offset+i].handle, + map->unmap_ops[offset+i].status); + map->unmap_ops[offset+i].handle = -1; + } + /* + * Decrease the live-grant counter. This must happen after the loop to + * prevent premature reuse of the grants by gnttab_mmap(). + */ + atomic_sub(data->count, &map->live_grants); + + /* Release reference taken by __unmap_grant_pages */ + gntdev_put_map(NULL, map); +} + +static void __unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) +{ if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); + if (pgno >= offset && pgno < offset + pages) { /* No need for kmap, pages are in lowmem */ uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; } } - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + refcount_inc(&map->users); /* to keep map alive during async call below */ - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; - - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; - pr_debug("unmap handle=%d st=%d\n", - map->unmap_ops[offset+i].handle, - map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; - } - return err; + gnttab_unmap_refs_async(&map->unmap_data); } -static int unmap_grant_pages(struct gntdev_grant_map *map, int offset, - int pages) +static void unmap_grant_pages(struct gntdev_grant_map *map, int offset, + int pages) { - int range, err = 0; + int range; + + if (atomic_read(&map->live_grants) == 0) + return; /* Nothing to do */ pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + if (range) + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -500,7 +557,6 @@ static int unmap_if_in_range(struct gntdev_grant_map *map, bool blockable) { unsigned long mstart, mend; - int err; if (!in_range(map, start, end)) return 0; @@ -514,10 +570,9 @@ static int unmap_if_in_range(struct gntdev_grant_map *map, map->index, map->count, map->vma->vm_start, map->vma->vm_end, start, end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); return 0; } @@ -558,7 +613,6 @@ static void mn_release(struct mmu_notifier *mn, { struct gntdev_priv *priv = container_of(mn, struct gntdev_priv, mn); struct gntdev_grant_map *map; - int err; mutex_lock(&priv->lock); list_for_each_entry(map, &priv->maps, next) { @@ -567,8 +621,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } list_for_each_entry(map, &priv->freeable_maps, next) { if (!map->vma) @@ -576,8 +629,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } mutex_unlock(&priv->lock); } @@ -1113,6 +1165,10 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto unlock_out; } + if (atomic_read(&map->live_grants)) { + err = -EAGAIN; + goto unlock_out; + } refcount_inc(&map->users); vma->vm_ops = &gntdev_vmops; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358756.588130 (Exim 4.92) (envelope-from ) id 1o74F4-0003l5-SC; Fri, 01 Jul 2022 00:10:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358756.588130; Fri, 01 Jul 2022 00:10:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F4-0003ks-OR; Fri, 01 Jul 2022 00:10:38 +0000 Received: by outflank-mailman (input) for mailman id 358756; Fri, 01 Jul 2022 00:10:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F3-0002b5-OG for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:37 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3ae834f3-f8d2-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 02:10:36 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 7CF085C00A1; Thu, 30 Jun 2022 20:10:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:10:35 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:34 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ae834f3-f8d2-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1656634235; x=1656720635; bh=KIm28SATNWEZsmrF/Es/LztAEAZJJOIcoRV exMvwpmA=; b=qDVRVvJj261IwCbUx05Ur9NyJhhtYzRuzmt02lgjFeAATy1RrqN 3Zgi86Y3o0+daM5fKAEZdJRCx/NUhnoHpIhnNopvRmhzq87PT831UJTVXiw6GOj5 dI9ErNNfhjPpWwfCOdXajxRLCuLiv3frMdL6Yg0ypIRbKA2OJNcAbsjfaoqMF7QJ 2K9zhEGMy1L0TrxlnX6dPaURbKEQhxGBzK25ZgrrzFzZIYOtQzV87Lrg8lmBn2hL BmNR7P/i1NYwu7GWrzCkGSEM+ffodqR2FiWi80+Vj42VK/MiUSCNGIhySaf5NPkb iR1igXm/RTarKbhcyTHvyRYYzSU3A+i0ayw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656634235; x=1656720635; bh=KIm28SATNWEZs mrF/Es/LztAEAZJJOIcoRVexMvwpmA=; b=W4ZdNjkmP3HrPY6GWcQG0wQ5daRbS K57CBRHxi7JDfFgEDiEdBHcjBHw+gnml0x12BqPV6nDwmtT+omqEJoEAncSE863K HZ6cL8g0Wo6rJBGgRdMZI8Hl9nYoFUH4nPHqYU8KNQyYBk+2ILvrkbB+ow9Ymsi7 +NKwo+wWxMjODg32VVvR1PDjSoEQXDCGCb4kS/DijKOpqjPqz1SyOmC307Knf0+Z /6m1v3V7k+3ujhMvp9xcRkdimuhF4PSpM/L9K2Zi1gsdhL5imTdSEEGU3rdXv21G pzG+SWFG9XmCvah6de9aVE+YtH3Ajw4c9MHnDfpyur9LUx/jMZ+TPtYPg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgepvdenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion , Demi Marie Obenour Subject: [PATCH 4.14] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Thu, 30 Jun 2022 20:09:51 -0400 Message-Id: <20220701000951.5072-5-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. It is also necessary to guard against reentrancy in gntdev_map_put(), and to handle the case where userspace tries to map a mapping whose contents have not all been freed yet. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisiblethingslab.com Signed-off-by: Juergen Gross --- drivers/xen/gntdev.c | 145 ++++++++++++++++++++++++++++++------------- 1 file changed, 103 insertions(+), 42 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 7b4ac5505f53..2827015604fb 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -59,6 +59,7 @@ MODULE_PARM_DESC(limit, "Maximum number of grants that may be mapped by " static atomic_t pages_mapped = ATOMIC_INIT(0); +/* True in PV mode, false otherwise */ static int use_ptemod; #define populate_freeable_maps use_ptemod @@ -94,11 +95,16 @@ struct grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; + /* Number of live grants */ + atomic_t live_grants; + /* Needed to avoid allocation in unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; -static int unmap_grant_pages(struct grant_map *map, int offset, int pages); +static void unmap_grant_pages(struct grant_map *map, int offset, int pages); /* ------------------------------------------------------------------ */ @@ -129,6 +135,7 @@ static void gntdev_free_map(struct grant_map *map) kfree(map->unmap_ops); kfree(map->kmap_ops); kfree(map->kunmap_ops); + kfree(map->being_removed); kfree(map); } @@ -147,12 +154,15 @@ static struct grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count) add->kmap_ops = kcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL); add->kunmap_ops = kcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || NULL == add->kmap_ops || NULL == add->kunmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; if (gnttab_alloc_pages(count, add->pages)) @@ -217,6 +227,35 @@ static void gntdev_put_map(struct gntdev_priv *priv, struct grant_map *map) return; atomic_sub(map->count, &pages_mapped); + if (map->pages && !use_ptemod) { + /* + * Increment the reference count. This ensures that the + * subsequent call to unmap_grant_pages() will not wind up + * re-entering itself. It *can* wind up calling + * gntdev_put_map() recursively, but such calls will be with a + * reference count greater than 1, so they will return before + * this code is reached. The recursion depth is thus limited to + * 1. Do NOT use refcount_inc() here, as it will detect that + * the reference count is zero and WARN(). + */ + refcount_set(&map->users, 1); + + /* + * Unmap the grants. This may or may not be asynchronous, so it + * is possible that the reference count is 1 on return, but it + * could also be greater than 1. + */ + unmap_grant_pages(map, 0, map->count); + + /* Check if the memory now needs to be freed */ + if (!refcount_dec_and_test(&map->users)) + return; + + /* + * All pages have been returned to the hypervisor, so free the + * map. + */ + } if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); @@ -274,6 +313,7 @@ static int set_grant_ptes_as_special(pte_t *pte, pgtable_t token, static int map_grant_pages(struct grant_map *map) { + size_t alloced = 0; int i, err = 0; if (!use_ptemod) { @@ -322,85 +362,107 @@ static int map_grant_pages(struct grant_map *map) map->pages, map->count); for (i = 0; i < map->count; i++) { - if (map->map_ops[i].status == GNTST_okay) + if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - else if (!err) + if (!use_ptemod) + alloced++; + } else if (!err) err = -EINVAL; if (map->flags & GNTMAP_device_map) map->unmap_ops[i].dev_bus_addr = map->map_ops[i].dev_bus_addr; if (use_ptemod) { - if (map->kmap_ops[i].status == GNTST_okay) + if (map->kmap_ops[i].status == GNTST_okay) { + if (map->map_ops[i].status == GNTST_okay) + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; - else if (!err) + } else if (!err) err = -EINVAL; } } + atomic_add(alloced, &map->live_grants); return err; } -static int __unmap_grant_pages(struct grant_map *map, int offset, int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; + unsigned int i; + struct grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; + + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); + pr_debug("unmap handle=%d st=%d\n", + map->unmap_ops[offset+i].handle, + map->unmap_ops[offset+i].status); + map->unmap_ops[offset+i].handle = -1; + } + /* + * Decrease the live-grant counter. This must happen after the loop to + * prevent premature reuse of the grants by gnttab_mmap(). + */ + atomic_sub(data->count, &map->live_grants); + /* Release reference taken by unmap_grant_pages */ + gntdev_put_map(NULL, map); +} + +static void __unmap_grant_pages(struct grant_map *map, int offset, int pages) +{ if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); + if (pgno >= offset && pgno < offset + pages) { /* No need for kmap, pages are in lowmem */ uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; } } - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + refcount_inc(&map->users); /* to keep map alive during async call below */ - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; - - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; - pr_debug("unmap handle=%d st=%d\n", - map->unmap_ops[offset+i].handle, - map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; - } - return err; + gnttab_unmap_refs_async(&map->unmap_data); } -static int unmap_grant_pages(struct grant_map *map, int offset, int pages) +static void unmap_grant_pages(struct grant_map *map, int offset, int pages) { - int range, err = 0; + int range; + + if (atomic_read(&map->live_grants) == 0) + return; /* Nothing to do */ pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + if (range) + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -456,7 +518,6 @@ static void unmap_if_in_range(struct grant_map *map, unsigned long start, unsigned long end) { unsigned long mstart, mend; - int err; if (!map->vma) return; @@ -470,10 +531,9 @@ static void unmap_if_in_range(struct grant_map *map, map->index, map->count, map->vma->vm_start, map->vma->vm_end, start, end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); } static void mn_invl_range_start(struct mmu_notifier *mn, @@ -498,7 +558,6 @@ static void mn_release(struct mmu_notifier *mn, { struct gntdev_priv *priv = container_of(mn, struct gntdev_priv, mn); struct grant_map *map; - int err; mutex_lock(&priv->lock); list_for_each_entry(map, &priv->maps, next) { @@ -507,8 +566,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } list_for_each_entry(map, &priv->freeable_maps, next) { if (!map->vma) @@ -516,8 +574,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } mutex_unlock(&priv->lock); } @@ -1006,6 +1063,10 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto unlock_out; } + if (atomic_read(&map->live_grants)) { + err = -EAGAIN; + goto unlock_out; + } refcount_inc(&map->users); vma->vm_ops = &gntdev_vmops; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:10:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:10:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358757.588141 (Exim 4.92) (envelope-from ) id 1o74F6-00043Q-C6; Fri, 01 Jul 2022 00:10:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358757.588141; Fri, 01 Jul 2022 00:10:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F6-000439-7I; Fri, 01 Jul 2022 00:10:40 +0000 Received: by outflank-mailman (input) for mailman id 358757; Fri, 01 Jul 2022 00:10:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74F5-0002sL-2b for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:10:39 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3bd7a9f4-f8d2-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 02:10:37 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1D79F5C00A3; Thu, 30 Jun 2022 20:10:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 30 Jun 2022 20:10:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 30 Jun 2022 20:10:36 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3bd7a9f4-f8d2-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1656634237; x=1656720637; bh=AcPiDhK5nel/vhcRclDX1Mn+txP3+gVjgis EUopMhHg=; b=ulXLGRu/mXjh1nxmMaAmmGBvZAue2v7vc/iKM9FN0tuiXQ2SB0Z JadwXE9ECaT2NYCoECRUhiDWhCEEjfcf/i+0Nh5vMsq5OA6zsZfnxddnxWAs2D/G 0od3he6xAFfjidvXBKDsY85oEKMAu5OSXfAPILEswULz4h0wMjO6ieUwwEAmLR1T fInJwp0tw5XfxkANMNtKQqTFf9U+Ijs0ZEvU9SpiP2mmHc4xKYxCHUMIWR70SPxN 59Zby0z7ahNb9bha6twa80khcZ7xeaD8qk6eLiv5PQteNpFiAG4PKJVHLdr6cREn nDll92nQCc7W+Q0zgFUhk48ucf0mYHx+KWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656634237; x=1656720637; bh=AcPiDhK5nel/v hcRclDX1Mn+txP3+gVjgisEUopMhHg=; b=kR8ZAdJtF19exT8rQGjcbLHPpZ2Pz wzLGcVZBXNN3K2ZaSmovQC/rcVbKN1kkUj5pT2kM00Q1pmlVZWFPZo8ntExbYUTv co4Y/U3xsNf8i9gfEf46p9d/w38XRJzmqNeWAWXMiLU+/vCYKSuVG2RL9pBGI5uk 3nqFxzkSo+F4FVxy8GhV477UubM/wM5CCmQMQd9Jlfqj8lcjc7oD3UoaVXyRxwKb AQwpA7O+u7evE3BkTFJLhaHmphY+YxK20UWLr7iU44zX6GOSASDFv9OUysW2T7ku ht8zbUAsqJr16A1cSrZDTvOQ0Zj7cGGahzBexaVtvUHVLkkoSpAANTTAw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptedtgeduleekleevjeehhfdvkefh veeuvdevtdduhffhvdeltdegtdfgkeduudegnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgepfeenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion , Demi Marie Obenour Subject: [PATCH 4.9] xen/gntdev: Avoid blocking in unmap_grant_pages() Date: Thu, 30 Jun 2022 20:09:52 -0400 Message-Id: <20220701000951.5072-6-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit unmap_grant_pages() currently waits for the pages to no longer be used. In https://github.com/QubesOS/qubes-issues/issues/7481, this lead to a deadlock against i915: i915 was waiting for gntdev's MMU notifier to finish, while gntdev was waiting for i915 to free its pages. I also believe this is responsible for various deadlocks I have experienced in the past. Avoid these problems by making unmap_grant_pages async. This requires making it return void, as any errors will not be available when the function returns. Fortunately, the only use of the return value is a WARN_ON(), which can be replaced by a WARN_ON when the error is detected. Additionally, a failed call will not prevent further calls from being made, but this is harmless. Because unmap_grant_pages is now async, the grant handle will be sent to INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the same handle. Instead, a separate bool array is allocated for this purpose. This wastes memory, but stuffing this information in padding bytes is too fragile. Furthermore, it is necessary to grab a reference to the map before making the asynchronous call, and release the reference when the call returns. It is also necessary to guard against reentrancy in gntdev_map_put(), and to handle the case where userspace tries to map a mapping whose contents have not all been freed yet. Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case they are still in use") Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisiblethingslab.com Signed-off-by: Juergen Gross --- drivers/xen/gntdev.c | 144 ++++++++++++++++++++++++++++++------------- 1 file changed, 102 insertions(+), 42 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 69d59102ff1b..2c3248e71e9c 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -57,6 +57,7 @@ MODULE_PARM_DESC(limit, "Maximum number of grants that may be mapped by " static atomic_t pages_mapped = ATOMIC_INIT(0); +/* True in PV mode, false otherwise */ static int use_ptemod; #define populate_freeable_maps use_ptemod @@ -92,11 +93,16 @@ struct grant_map { struct gnttab_unmap_grant_ref *unmap_ops; struct gnttab_map_grant_ref *kmap_ops; struct gnttab_unmap_grant_ref *kunmap_ops; + bool *being_removed; struct page **pages; unsigned long pages_vm_start; + /* Number of live grants */ + atomic_t live_grants; + /* Needed to avoid allocation in unmap_grant_pages */ + struct gntab_unmap_queue_data unmap_data; }; -static int unmap_grant_pages(struct grant_map *map, int offset, int pages); +static void unmap_grant_pages(struct grant_map *map, int offset, int pages); /* ------------------------------------------------------------------ */ @@ -127,6 +133,7 @@ static void gntdev_free_map(struct grant_map *map) kfree(map->unmap_ops); kfree(map->kmap_ops); kfree(map->kunmap_ops); + kfree(map->being_removed); kfree(map); } @@ -145,12 +152,15 @@ static struct grant_map *gntdev_alloc_map(struct gntdev_priv *priv, int count) add->kmap_ops = kcalloc(count, sizeof(add->kmap_ops[0]), GFP_KERNEL); add->kunmap_ops = kcalloc(count, sizeof(add->kunmap_ops[0]), GFP_KERNEL); add->pages = kcalloc(count, sizeof(add->pages[0]), GFP_KERNEL); + add->being_removed = + kcalloc(count, sizeof(add->being_removed[0]), GFP_KERNEL); if (NULL == add->grants || NULL == add->map_ops || NULL == add->unmap_ops || NULL == add->kmap_ops || NULL == add->kunmap_ops || - NULL == add->pages) + NULL == add->pages || + NULL == add->being_removed) goto err; if (gnttab_alloc_pages(count, add->pages)) @@ -215,6 +225,34 @@ static void gntdev_put_map(struct gntdev_priv *priv, struct grant_map *map) return; atomic_sub(map->count, &pages_mapped); + if (map->pages && !use_ptemod) { + /* + * Increment the reference count. This ensures that the + * subsequent call to unmap_grant_pages() will not wind up + * re-entering itself. It *can* wind up calling + * gntdev_put_map() recursively, but such calls will be with a + * reference count greater than 1, so they will return before + * this code is reached. The recursion depth is thus limited to + * 1. + */ + atomic_set(&map->users, 1); + + /* + * Unmap the grants. This may or may not be asynchronous, so it + * is possible that the reference count is 1 on return, but it + * could also be greater than 1. + */ + unmap_grant_pages(map, 0, map->count); + + /* Check if the memory now needs to be freed */ + if (!atomic_dec_and_test(&map->users)) + return; + + /* + * All pages have been returned to the hypervisor, so free the + * map. + */ + } if (map->notify.flags & UNMAP_NOTIFY_SEND_EVENT) { notify_remote_via_evtchn(map->notify.event); @@ -272,6 +310,7 @@ static int set_grant_ptes_as_special(pte_t *pte, pgtable_t token, static int map_grant_pages(struct grant_map *map) { + size_t alloced = 0; int i, err = 0; if (!use_ptemod) { @@ -320,85 +359,107 @@ static int map_grant_pages(struct grant_map *map) map->pages, map->count); for (i = 0; i < map->count; i++) { - if (map->map_ops[i].status == GNTST_okay) + if (map->map_ops[i].status == GNTST_okay) { map->unmap_ops[i].handle = map->map_ops[i].handle; - else if (!err) + if (!use_ptemod) + alloced++; + } else if (!err) err = -EINVAL; if (map->flags & GNTMAP_device_map) map->unmap_ops[i].dev_bus_addr = map->map_ops[i].dev_bus_addr; if (use_ptemod) { - if (map->kmap_ops[i].status == GNTST_okay) + if (map->kmap_ops[i].status == GNTST_okay) { + if (map->map_ops[i].status == GNTST_okay) + alloced++; map->kunmap_ops[i].handle = map->kmap_ops[i].handle; - else if (!err) + } else if (!err) err = -EINVAL; } } + atomic_add(alloced, &map->live_grants); return err; } -static int __unmap_grant_pages(struct grant_map *map, int offset, int pages) +static void __unmap_grant_pages_done(int result, + struct gntab_unmap_queue_data *data) { - int i, err = 0; - struct gntab_unmap_queue_data unmap_data; + unsigned int i; + struct grant_map *map = data->data; + unsigned int offset = data->unmap_ops - map->unmap_ops; + + for (i = 0; i < data->count; i++) { + WARN_ON(map->unmap_ops[offset+i].status); + pr_debug("unmap handle=%d st=%d\n", + map->unmap_ops[offset+i].handle, + map->unmap_ops[offset+i].status); + map->unmap_ops[offset+i].handle = -1; + } + /* + * Decrease the live-grant counter. This must happen after the loop to + * prevent premature reuse of the grants by gnttab_mmap(). + */ + atomic_sub(data->count, &map->live_grants); + /* Release reference taken by unmap_grant_pages */ + gntdev_put_map(NULL, map); +} + +static void __unmap_grant_pages(struct grant_map *map, int offset, int pages) +{ if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) { int pgno = (map->notify.addr >> PAGE_SHIFT); + if (pgno >= offset && pgno < offset + pages) { /* No need for kmap, pages are in lowmem */ uint8_t *tmp = pfn_to_kaddr(page_to_pfn(map->pages[pgno])); + tmp[map->notify.addr & (PAGE_SIZE-1)] = 0; map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE; } } - unmap_data.unmap_ops = map->unmap_ops + offset; - unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; - unmap_data.pages = map->pages + offset; - unmap_data.count = pages; + map->unmap_data.unmap_ops = map->unmap_ops + offset; + map->unmap_data.kunmap_ops = use_ptemod ? map->kunmap_ops + offset : NULL; + map->unmap_data.pages = map->pages + offset; + map->unmap_data.count = pages; + map->unmap_data.done = __unmap_grant_pages_done; + map->unmap_data.data = map; + atomic_inc(&map->users); /* to keep map alive during async call below */ - err = gnttab_unmap_refs_sync(&unmap_data); - if (err) - return err; - - for (i = 0; i < pages; i++) { - if (map->unmap_ops[offset+i].status) - err = -EINVAL; - pr_debug("unmap handle=%d st=%d\n", - map->unmap_ops[offset+i].handle, - map->unmap_ops[offset+i].status); - map->unmap_ops[offset+i].handle = -1; - } - return err; + gnttab_unmap_refs_async(&map->unmap_data); } -static int unmap_grant_pages(struct grant_map *map, int offset, int pages) +static void unmap_grant_pages(struct grant_map *map, int offset, int pages) { - int range, err = 0; + int range; + + if (atomic_read(&map->live_grants) == 0) + return; /* Nothing to do */ pr_debug("unmap %d+%d [%d+%d]\n", map->index, map->count, offset, pages); /* It is possible the requested range will have a "hole" where we * already unmapped some of the grants. Only unmap valid ranges. */ - while (pages && !err) { - while (pages && map->unmap_ops[offset].handle == -1) { + while (pages) { + while (pages && map->being_removed[offset]) { offset++; pages--; } range = 0; while (range < pages) { - if (map->unmap_ops[offset+range].handle == -1) + if (map->being_removed[offset + range]) break; + map->being_removed[offset + range] = true; range++; } - err = __unmap_grant_pages(map, offset, range); + if (range) + __unmap_grant_pages(map, offset, range); offset += range; pages -= range; } - - return err; } /* ------------------------------------------------------------------ */ @@ -454,7 +515,6 @@ static void unmap_if_in_range(struct grant_map *map, unsigned long start, unsigned long end) { unsigned long mstart, mend; - int err; if (!map->vma) return; @@ -468,10 +528,9 @@ static void unmap_if_in_range(struct grant_map *map, map->index, map->count, map->vma->vm_start, map->vma->vm_end, start, end, mstart, mend); - err = unmap_grant_pages(map, + unmap_grant_pages(map, (mstart - map->vma->vm_start) >> PAGE_SHIFT, (mend - mstart) >> PAGE_SHIFT); - WARN_ON(err); } static void mn_invl_range_start(struct mmu_notifier *mn, @@ -503,7 +562,6 @@ static void mn_release(struct mmu_notifier *mn, { struct gntdev_priv *priv = container_of(mn, struct gntdev_priv, mn); struct grant_map *map; - int err; mutex_lock(&priv->lock); list_for_each_entry(map, &priv->maps, next) { @@ -512,8 +570,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } list_for_each_entry(map, &priv->freeable_maps, next) { if (!map->vma) @@ -521,8 +578,7 @@ static void mn_release(struct mmu_notifier *mn, pr_debug("map %d+%d (%lx %lx)\n", map->index, map->count, map->vma->vm_start, map->vma->vm_end); - err = unmap_grant_pages(map, /* offset */ 0, map->count); - WARN_ON(err); + unmap_grant_pages(map, /* offset */ 0, map->count); } mutex_unlock(&priv->lock); } @@ -1012,6 +1068,10 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma) goto unlock_out; } + if (atomic_read(&map->live_grants)) { + err = -EAGAIN; + goto unlock_out; + } atomic_inc(&map->users); vma->vm_ops = &gntdev_vmops; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:13:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:13:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358778.588151 (Exim 4.92) (envelope-from ) id 1o74Hn-00068m-SA; Fri, 01 Jul 2022 00:13:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358778.588151; Fri, 01 Jul 2022 00:13:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Hn-00068f-PL; Fri, 01 Jul 2022 00:13:27 +0000 Received: by outflank-mailman (input) for mailman id 358778; Fri, 01 Jul 2022 00:13:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74Hm-00068M-Dw for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 00:13:26 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9e869347-f8d2-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 02:13:24 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1656634399124369.22079018393185; Thu, 30 Jun 2022 17:13:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e869347-f8d2-11ec-bdce-3d151da133c5 ARC-Seal: i=1; a=rsa-sha256; t=1656634401; cv=none; d=zohomail.com; s=zohoarc; b=MzZCeTW6aM8Tz9mFcnzfFpK+mkYS24Ys4j2pE+YfELkUkbWNcsBSZr1H5lLdEMQv9cyAezfPwxb7KRB29eCvt/dZc6Unnj7xE1lgFbh9ICSf3qYILjXVLdrfLbw2sg0I/WaujW/aSbuu2TcCnC24quQiJWORlD9sTpVl5Q6HsE0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1656634401; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=feV83fab+6AFl6hEvNKgoWcd6V6qGB2HOCVoWX3SF2I=; b=dJzGA3dy2/bFrxUYt+Xk7aFjC6d0oymuHJn38DWZ4Y6IAB4/V3qpKfByBdvYzwbijNc+kw0oUAlo2rdvjT4FR6tpdwL40PAhKkh8LnilcWcv7KGeSLcgrKXDIKAUcbdGzAAaDIvJr7ZSmaRh+uGMeLpQx9wvbl+7GOBES7OqQtw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1656634401; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=feV83fab+6AFl6hEvNKgoWcd6V6qGB2HOCVoWX3SF2I=; b=cEthfyk5F3AgxE1HrvMQgOn+TkGCZeDi/wH7juflCuLTl0u+0zSsYlY32rciGPdv QpsF7bs2L5KU2DGRaX+bGkFkWvHFuBInXbkLNIA3yIYU9mP2+zSiHIq7pJGY6iWlfuF vFV29JQw5azuut82HvXJE6bANVkx6E2mM31fH33Q= Message-ID: <2f227767-93f3-8895-1e9e-127e4d2ac65b@apertussolutions.com> Date: Thu, 30 Jun 2022 20:11:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v9 0/3] Adds starting the idle domain privileged Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, dgdegra@tycho.nsa.gov, jbeulich@suse.com, julien@xen.org, george.dunlap@citrix.com, andrew.cooper3@citrix.com, dfaggioli@suse.com References: <20220630022110.31555-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 6/30/22 18:35, Stefano Stabellini wrote: > On Wed, 29 Jun 2022, Daniel P. Smith wrote: >> This series makes it so that the idle domain is started privileged under the >> default policy, which the SILO policy inherits, and under the flask policy. It >> then introduces a new one-way XSM hook, xsm_transition_running, that is hooked >> by an XSM policy to transition the idle domain to its running privilege level. >> >> Patch 3 is an important one, as first it addresses the issue raised under an >> RFC late last year by Jason Andryuk regarding the awkward entanglement of >> flask_domain_alloc_security() and flask_domain_create(). Second, it helps >> articulate why it is that the hypervisor should go through the access control >> checks, even when it is doing the action itself. The issue at hand is not that >> the hypervisor could be influenced to go around these check. The issue is these >> checks provides a configurable way to express the execution flow that the >> hypervisor should enforce. Specifically with this change, it is now possible >> for an owner of a dom0less or hyperlaunch system to express a policy where the >> hypervisor will enforce that no dom0 will be constructed, regardless of what >> boot construction details were provided to it. Likewise, an owner that does not >> want to see dom0less or hyperlaunch to be used can enforce that the hypervisor >> will only construct a dom0 domain. This can all be accomplished without the >> need to rebuild the hypervisor with these features enabled or disabled. > > > It looks like this patch series is fully acked except: > - in theory we need an ack from Daniel for flask > - there is a very small change to sched that would need an ack from > George/Dario > > > I think we should commit the series in a couple of days unless someone > spots an issue with it. Let me know if you have any concerns with this. > > The minimal request to improve the in-code comment by Jan could be done > on commit. I already have those changes ready to go. I was holding off with the hope that Jason might find some time to read the last patch. I can try pinging him directly tomorrow to see if he is even in town, as this is a big holiday weekend here in the states. > Note that committing this series would also have the benefit of > unblocking the ARM gitlab-ci pipeline. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 01 00:40:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 00:40:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358801.588163 (Exim 4.92) (envelope-from ) id 1o74i4-0001YS-04; Fri, 01 Jul 2022 00:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358801.588163; Fri, 01 Jul 2022 00:40:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74i3-0001YL-Sz; Fri, 01 Jul 2022 00:40:35 +0000 Received: by outflank-mailman (input) for mailman id 358801; Fri, 01 Jul 2022 00:40:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74i3-0001YB-Bz; Fri, 01 Jul 2022 00:40:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74i3-00010y-9V; Fri, 01 Jul 2022 00:40:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o74i2-0000Ci-RX; Fri, 01 Jul 2022 00:40:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o74i2-00066h-R6; Fri, 01 Jul 2022 00:40:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lri39shIRWHCfwqEGaA9/VWIKg6HQMAqZ54PaOaRD90=; b=5Ync2AwAVPN337XAGGtkOMwiyT 1PcoboePaCxBbhkHMp25vvArwoXD2tlQwszxMVJc2slxu3IndcDKRlqrn5BEnDBSB8uB8lChnlX7h xX1JUMT4Aa50jFPMeige77xu7S6W/nFDOjbSE1jeQa46kM5xeORWSPaFK7+uiDAy8jQA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171430: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ee11f092b515bf3c926eaad053d12d3f2b6e593e X-Osstest-Versions-That: xen=60d1adfa18793f4ddb70c8e901562d8d3e9be3dc From: osstest service owner Date: Fri, 01 Jul 2022 00:40:34 +0000 flight 171430 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171430/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ee11f092b515bf3c926eaad053d12d3f2b6e593e baseline version: xen 60d1adfa18793f4ddb70c8e901562d8d3e9be3dc Last test of basis 171428 2022-06-30 18:01:44 Z 0 days Testing same since 171430 2022-06-30 21:01:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dmytro Semenets Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 60d1adfa18..ee11f092b5 ee11f092b515bf3c926eaad053d12d3f2b6e593e -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 01 02:19:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 02:19:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358812.588174 (Exim 4.92) (envelope-from ) id 1o76Fs-0001bK-6w; Fri, 01 Jul 2022 02:19:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358812.588174; Fri, 01 Jul 2022 02:19:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76Fs-0001bD-35; Fri, 01 Jul 2022 02:19:36 +0000 Received: by outflank-mailman (input) for mailman id 358812; Fri, 01 Jul 2022 02:19:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76Fq-0001b7-Ph for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 02:19:35 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3daa6d55-f8e4-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 04:19:31 +0200 (CEST) Received: from AS9PR06CA0533.eurprd06.prod.outlook.com (2603:10a6:20b:49d::22) by AM8PR08MB6436.eurprd08.prod.outlook.com (2603:10a6:20b:365::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.15; Fri, 1 Jul 2022 02:19:29 +0000 Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49d:cafe::74) by AS9PR06CA0533.outlook.office365.com (2603:10a6:20b:49d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 02:19:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 02:19:28 +0000 Received: ("Tessian outbound 879f4da7a6e9:v121"); Fri, 01 Jul 2022 02:19:28 +0000 Received: from c54de96ddbd2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D401D96E-BA98-408E-BE28-5393416AA6E8.1; Fri, 01 Jul 2022 02:19:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c54de96ddbd2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 02:19:21 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM6PR08MB4738.eurprd08.prod.outlook.com (2603:10a6:20b:cf::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 02:19:19 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.014; Fri, 1 Jul 2022 02:19:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3daa6d55-f8e4-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JeOU6DH+phyr2NRTxpm3CCvkVB4G9UmUGVsb/7pazRP4u+CarzbeRiJTkoGEYjnpZSO4eFpaNsXYAEtPAK7AjvlmTU/aJuyzTQidoK9ptkGWVRxIJhcCaZlyKo98rlWBbdl6NjVPRYyLLrAlpHa55lQMFrFIrs27P3TmrEPrhDqSlzXnOgKKAng4UtT2IT9TiwWjz+ELBWUTigHaoi8Lv/ajQSqwyCEZ2mhTw8zPFt5xVpgevj13gRubnqFwJl2IiWREdSlx4TCVVoUM4XIALY/lcJcPIc/B7V7t/Wj0+Gtx1WrjNdT2ZvXxOCdJJDZks/sD030VzpWAqdgxRxQzrQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8leDshB0WObPEc5klG/W1tDeKdRnxiYzvuy7rcoviw=; b=iNpnYkwYzxM8me46qbPaW36X6nfhcQauM+JZ5QikQfm0lmoENtS5YGZhguCvSkDWWAvr6b5Of2mUafQJKrkopyyP1bfcnjPTok4k6+hh+oO6aayKY5EJpMzkNpqts/87HIQnz1zoMqbFnT3BXOKC0EgrCByW4chQx4VUJ6hs5bTwsmCXfHfoSJ3d5xJScGWhY4HqW3zyHhpGNvEhvEEAE/sabDnSWQPRzWVR63KLhsDe2seivYWtqiYPxEca0sHp2NdF0P/MKxtv1PX+15dkf9+UKd+GtZe9+GLcAAks+AUzTJYDH0O7z1bsiwlawwRD8cf1lB/jyDXL0VnQiHf98Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8leDshB0WObPEc5klG/W1tDeKdRnxiYzvuy7rcoviw=; b=kiQXnbSkeQR0e/BiVOJVG2IDsO1RQwSzvyQZCoIqZTxvIjXXX/xugigxWgrI/WGCFg4oWUZqxzaAsESTfrFj05Aha282SZ/x4H78akn6TOpMy2ggZuOkBe7LlviVx4F7haDUDA/n42A+vk7zEQ5NgoL6Dbj3z1tGKx0O3tVEIdQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gRANAfrtm1Xb5RMwtj4M0wTxEsA+Nt7KOwNG+0ivI8MdgKkDkZhsdcU42rYKeR92gNNledDXcf6oWKbCxq7v7luVBXFdMiTemtKm1XDE0XqSnye1/uoCnxDvdZ3nCC1fMlctiQ4vPzMM0vRMvSlEOKFLnfoQQVh4s/Cai94AMOPGxHbly/KTuPGoRZCZvXP9SRaYTXq45ztAgsQ29HbddbNaq6pzyxsYPp03ElBfHauUXrNwIsXswibOW++YgI+ztpM5po5yNtI5MsEoTSROHYIZKp1A9SnBhZDnwtwq+F/2BEAq1vIn6bDdQF1q+LLOWm6GNK4GV3KgyfCD+WEnvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8leDshB0WObPEc5klG/W1tDeKdRnxiYzvuy7rcoviw=; b=cRXzWtP+2GsSuqAMe+7OZn0dWdxy1BujhOovKisroR7n+r3F8bZJcTO9gtJEMyNcDltQxwK2kb3iTr5Amo8pqmTYVDuEP3KDOQemgiYoMQIADmMNNf+3QD9LKSlGZdztvBSu9lCU1RoFqd9W/mRv+4K89q3YN8tmSiWSUfHdIdRhsvO1sBaVOioUhvJviq3IRE4mlx87J3kCSwF5BjVGWUf00pYCGYxbdoUg6QRydsfDCCUQCr+3zZYajapBAaeDyFoIX6iGuTFbCDduotpB+7gxXfEvoBnV64nypbB8WnlNcabeXum4R8UD7rIqIh0KMk1OCoPRLqG5N4vCzsCWxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8leDshB0WObPEc5klG/W1tDeKdRnxiYzvuy7rcoviw=; b=kiQXnbSkeQR0e/BiVOJVG2IDsO1RQwSzvyQZCoIqZTxvIjXXX/xugigxWgrI/WGCFg4oWUZqxzaAsESTfrFj05Aha282SZ/x4H78akn6TOpMy2ggZuOkBe7LlviVx4F7haDUDA/n42A+vk7zEQ5NgoL6Dbj3z1tGKx0O3tVEIdQ= From: Henry Wang To: Julien Grall , "xen-devel@lists.xenproject.org" CC: "jbeulich@suse.com" , Julien Grall , Juergen Gross Subject: RE: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Thread-Topic: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Thread-Index: AQHYjLCT8ll1pspHXU2Irp2zQF5YmK1ox2KQ Date: Fri, 1 Jul 2022 02:19:19 +0000 Message-ID: References: <20220630183655.44391-1-julien@xen.org> In-Reply-To: <20220630183655.44391-1-julien@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A6D25A2AA60E3A488C1CECD1C8361DA0.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6dfd1694-7e58-48f2-ea07-08da5b08205d x-ms-traffictypediagnostic: AM6PR08MB4738:EE_|AM5EUR03FT054:EE_|AM8PR08MB6436:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nfzgfnXJVY6C3lCtUD90H2plS3+ZZuXb9YU7yF2y0Td2DY8obWW2kmRx0ouCSxbYTjB3/zMpIfizxdrPUdjOntCL9o88W0CsQ3lCoC9SV3n7+2EdmnfcNukcDAfZGAf1MgPc0lCLroEwMbGQUT9OZKChc4gS7j5HLhpheEJdUohG6guecRODOM6dKJIB61WlvmIX8BHg+0ZuapBeOAibEvmqVfTwm+oU2JiYaCanCyF/OS6c5QF/K4Zq2Haf2e0FlVcKFRNVk7+cG/ULCGGwOuI6HHQ5zL1zQgP251eIUsYmimocy16HT6bSaAAFpfvz5kyRsQrVmAJ/RmhfHxgZix8HPtyRXc5AOtxvhqQWtIlFY/XzauDTqLLfVoT7JaXbStR1P+VZ0Z3zL9BrdCPh5GxEhobBMXhjP0cn+6+sdBN3/Aweqv5L6tuSN+SWZyZaGWTuPzRPz2ODRi78gP4+b5Civ4FFKs7u1ZH87oc1t1QgfwW/8K08gC4dET7IJHNYw1jLPkGEnmWykjRg+aX7xxXua0oL9OReS6t/4NobBJHclqydsF0t5fBT+Bd1vuaW7Mshwp1XLWEg7Apb1rFAB1xZLD2xogErXhQzXjS50n2uvYkHOv+mRnCTyuaxkkUNDNPBrccODngjE4IAJrH8vBygvFP2SMfKfWzFGKzkGUueVou8OCP0oHA+g3vxZTUDTPWsjKu7ertam/9422xOKIxucKjlrlNsxbG4p7qX8mXUNmmqJnxNe3mBxDu+DlTrHnwtvcqxcJ5sBVUW9AumCtVjUWPw6Ha7ZTmZz5PKHaOpFnM/xY1cPrwQYjcaIi6L X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(366004)(346002)(39860400002)(41300700001)(5660300002)(2906002)(83380400001)(7696005)(71200400001)(55016003)(66446008)(122000001)(186003)(33656002)(52536014)(66476007)(66946007)(64756008)(478600001)(66556008)(110136005)(4326008)(76116006)(8676002)(26005)(316002)(38100700002)(9686003)(86362001)(38070700005)(6506007)(54906003)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4738 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 05362098-15cc-4d60-80f8-08da5b081aae X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 98I7wQ3oxToDk7W+KXApDanIr4JwMW3t1tAPMtkA+0IS0JOeiXR3Ld3K70NakEVwX0PgM2ZO/4MubOmXW6Zt9skdRPQO15c57qgO1bLtTsQAR7UfeXq1WwX+cePJ6pAaACBBUutr6EKtXZ7hsolGaRsAA/ULiQD+UCCWxtHJTSWZRFQjw970a7a5kukWWUMJ9kswE5gEhiC1hWfvhyyMA7pIJt08szf3QyXU5BE6wLbM5AIlvIZUIrdN0N+/oupBvoW35vl4sRJMLvkbisDGVF34UBTXEYobnKOvmaKRqxQs02oyetNXCqtsHDFO9OSeP093xsrVY9nJwle5BRFyDevcH+BdHB+6ieFWezD2f0cQKSsT5SgJ/mbv3giWCm68owCCQImEcQFKz+X4ocAGJODDo4K80cj4cUaIyGZCdJJ2ccpBxrRhgtjpnGzDGqgk9p6UeM0df42F1Zk8/jIZOZe+0afV0p61F3hPA9q1KgPCS2qPVdrNgAEQDIwMHKCaLrkm5xWr2p9MnQW1VaVds2yt0WgM1dDNafNlu3oLiN5L8SAFe/Mw7IW7Lpqr3C3FiBzTQRdYgERLxnyylZMj8ikIom6pu20heT2HL5b2T8ni/f92Ou/xBwa0v1rCKHT6RDQeQ4GOWyJ6KmEsXkaTVNH9MhAxq5g+I/LEUpP6tC3OMI90CbpyhzGE62JB5YgAlGJ2JVf0yiVHzhmOWiRr2VlALSrZSsgcrS77lcimgj3ooD9GsUwFXAHea5a7yxlQvHBMH4bxQGKGY9gMTa7UcgtN8QT1RbalSlaqhbxk9i9uC3gGZ9Hozs/lzN0YHs8n X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(39860400002)(40470700004)(46966006)(36840700001)(54906003)(82310400005)(52536014)(55016003)(82740400003)(356005)(36860700001)(2906002)(40460700003)(83380400001)(81166007)(86362001)(186003)(41300700001)(5660300002)(47076005)(8936002)(336012)(7696005)(8676002)(70206006)(478600001)(107886003)(6506007)(9686003)(40480700001)(316002)(110136005)(4326008)(26005)(33656002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 02:19:28.6613 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6dfd1694-7e58-48f2-ea07-08da5b08205d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6436 Hi Julien, > -----Original Message----- > Subject: [PATCH v3] public/io: xs_wire: Document that new errors should b= e > added at the end >=20 > From: Julien Grall >=20 > Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_error= s. >=20 > To be conservative, mandate that new errors should be added at the end > of the array. >=20 > Signed-off-by: Julien Grall While the change is looking good, just FYI there is an "ERROR" section in /xen/docs/misc/xenstore.txt that points to the io/xs_wire.h. You may want to add something there (that depends on your own taste :)) ) With or without above additional documentation: Reviewed-by: Henry Wang Kind regards, Henry >=20 > ---- >=20 > Changes in v3: > - Mandate that new errors should be added at the end. >=20 > Changes in v2: > - New patch > --- > xen/include/public/io/xs_wire.h | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/xen/include/public/io/xs_wire.h > b/xen/include/public/io/xs_wire.h > index c1ec7c73e3b1..a4d954cb05aa 100644 > --- a/xen/include/public/io/xs_wire.h > +++ b/xen/include/public/io/xs_wire.h > @@ -76,6 +76,7 @@ static struct xsd_errors xsd_errors[] > __attribute__((unused)) > #endif > =3D { > + /* /!\ New errors should be added at the end of the array. */ > XSD_ERROR(EINVAL), > XSD_ERROR(EACCES), > XSD_ERROR(EEXIST), > -- > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 03:02:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 03:02:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358820.588185 (Exim 4.92) (envelope-from ) id 1o76vg-0007Ll-Lf; Fri, 01 Jul 2022 03:02:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358820.588185; Fri, 01 Jul 2022 03:02:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76vg-0007Le-HB; Fri, 01 Jul 2022 03:02:48 +0000 Received: by outflank-mailman (input) for mailman id 358820; Fri, 01 Jul 2022 03:02:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76ve-0007LU-Tm; Fri, 01 Jul 2022 03:02:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76ve-0006Uy-QS; Fri, 01 Jul 2022 03:02:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o76ve-0005b6-8U; Fri, 01 Jul 2022 03:02:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o76ve-0007I3-7y; Fri, 01 Jul 2022 03:02:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zlKXeiJAnfyU5eY9E2vsW1L6ODNLc167gBmMhZ8+dhg=; b=BvIOutwLPn7jrYr3UiKcPWTbbM LWkPyXHW4IINUa6fuKrqk48ilqOC6VwAsualN+7S2BZq2r6VYu0Ue3+OI7T1cXtCgBj9/ZPB5cgCM 73h19vg7LknY3m6GX8mXLsxYQtGewpMaXk27DojIce+Pv8G1mGCcNKIxjAlGTMoyiBNc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171427: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9ef3ad40a81ff6b8b65ed870588b230f38812f2a X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Fri, 01 Jul 2022 03:02:46 +0000 flight 171427 linux-5.4 real [real] flight 171434 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171427/ http://logs.test-lab.xenproject.org/osstest/logs/171434/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171352 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail in 171416 pass in 171427 test-armhf-armhf-xl-multivcpu 14 guest-start fail in 171416 pass in 171427 test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 171416 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171352 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-armhf-armhf-xl-credit2 14 guest-start fail in 171416 like 171352 test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 171416 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 171416 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9ef3ad40a81ff6b8b65ed870588b230f38812f2a baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 5 days Testing same since 171400 2022-06-29 07:11:34 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Antoine Tenart Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Nguyen Ulf Hansson Vincent Whitchurch Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1766 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 03:12:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 03:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358829.588196 (Exim 4.92) (envelope-from ) id 1o774a-0000Zb-IS; Fri, 01 Jul 2022 03:12:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358829.588196; Fri, 01 Jul 2022 03:12:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o774a-0000ZU-FL; Fri, 01 Jul 2022 03:12:00 +0000 Received: by outflank-mailman (input) for mailman id 358829; Fri, 01 Jul 2022 03:11:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o774Y-0000ZO-GN for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 03:11:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9075eee1-f8eb-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 05:11:57 +0200 (CEST) Received: from FR0P281CA0131.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::16) by VI1PR08MB3965.eurprd08.prod.outlook.com (2603:10a6:803:dd::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 03:11:52 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:97:cafe::99) by FR0P281CA0131.outlook.office365.com (2603:10a6:d10:97::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.6 via Frontend Transport; Fri, 1 Jul 2022 03:11:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 03:11:51 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Fri, 01 Jul 2022 03:11:51 +0000 Received: from 3aec3b52da63.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 45A2B899-C5EF-4F2F-9AF7-93D4D5077E82.1; Fri, 01 Jul 2022 03:11:40 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3aec3b52da63.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 03:11:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB4225.eurprd08.prod.outlook.com (2603:10a6:208:137::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 03:11:37 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%7]) with mapi id 15.20.5395.014; Fri, 1 Jul 2022 03:11:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9075eee1-f8eb-11ec-bdce-3d151da133c5 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gprzJoxpl/0L21qcw/g6rVL3JFy7VkPtm+umOVAXybXe4xxmhqyyMB8a/xjfL0gCbDLFJJ8R0Ah/WJdd4dPVHSCspi8T1f2j1g7P9s9BGVHvECihCYSovUJXzK3gC3FE1JfxnyEfXiVvxVNTA2V59e3z/eFLZANcoApP7XT3DLkCL86SzGZaMqdyHR0ZKKqUaKnlPybHlVWpT1UnEPZAkkPhJDC0Vg1c2Bk/tIbBRcqigb/K0H5w/hDvvzKfirnTRH4Jd3Be5H3q8A6x+vrSNWDxxtBw+tynPoyhJZf8vQ2uPSIDxima+2A5qQUBpPNkifDldoL2uvtTidpFd4oBvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N50VCiCKkdRqMSpkK9h4MxE+fkysBHt0vZZk7ZihQHM=; b=cuJW+kWkqMseaQtsIcQviapbc1MGqM6maXPmA0Eho7Q1UD/P5Xvg1OG/LPa00swJhV+1V+gRmWoz4I0TnQR+0sR/sBomMdAsYkIWXx4Nv/w4IRvceJnjXCZuldbmV4PFOBu99sf8ks5+MnSFwimTFnQOQF4M8zIPqhEB6O6CiF6jyyOmOoFwHqIdH45+JLPKHQhDbZoOSHVuuyJ+LaMtQwYjZHFo/vtBh5Og3nDeWfDWrzfgUa6vTQNwBMI2finQQTIwHF7OSOEtiTmRv2tvT1m4A2hQpMJsxujvCiLVe9W4icAiBWCILz5VUyEaqG/0ra2HYyIZin12WZOC8V/YQA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N50VCiCKkdRqMSpkK9h4MxE+fkysBHt0vZZk7ZihQHM=; b=MzXUnp/7wNtJKy7u0cYHu1Cd6rNDSk4cbBZ3K5V8t512pO+bWAIEjgI0u54pjgGGZY5SN7o2cUQZtg7Sgz7nqiI+cnls1rFnI3dRm4OFekF+B2MuatmQ156QF4GhCeEmLd/5pJFwhgbqJsz6Eb+uHs142cYDtTfOIZQ8V/Q6Kc4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W/8G3HRYA/0Z+vT+W6m+flgIWsksjzJLipxmwVH1OKStYa3RnGSlEamwqjAdXJz5p5xLgVM4oekAFiv6BrlE7ad1t5F7lao7VUASiXgzMJ7vMlcoHCYhfaQIzszXEOa8+vxBVRjUz/d/umGdqK9VJvkujEqX5n/9SK3NhSwqLuycENaBl/R+HGpcytXU1TB8mbqX5glvESN3mvFIAH4UnObNaZlcswZOay8sRvwDBsrtH3zt49Fr8lVT87t5qDAAoOGlsKWNeCfHPD8fTp16urZoiS+foehuzBJhio83CMluhRewdfh70nSyWM81fHvNGRdiOErprY/xeFgNEgIP2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N50VCiCKkdRqMSpkK9h4MxE+fkysBHt0vZZk7ZihQHM=; b=XI7vxmRUQA5ft1OaWRTsnBR1Yi57rVvPwwEDx/7qqlRPKVU8buZkQlgPuoCwSqiWbmGqXMCnckeuZ675xFkk7GEXiw81cizJ3mhOKohVCnofPR0gy1OWY7xqFSpx8ZYZmMVsau4Usn2KSCOmqrCGZweVLr/L5YLhLR0KPKjh+UQABeO56YN+gzQMM0BXcDeqMUOLahotSBiWdxPLmljWUzj91a4NrfVMkIa7+BmIrTOt88k/EClrbcbznEjXn5RRl7z4r5jiUJ7CUkXOwV5zNv/bRGOgn0Y3pdLz5p4kqRckGVWMObKMbzHMbjUzmrHVxWDcP22XTMykssD5risKbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N50VCiCKkdRqMSpkK9h4MxE+fkysBHt0vZZk7ZihQHM=; b=MzXUnp/7wNtJKy7u0cYHu1Cd6rNDSk4cbBZ3K5V8t512pO+bWAIEjgI0u54pjgGGZY5SN7o2cUQZtg7Sgz7nqiI+cnls1rFnI3dRm4OFekF+B2MuatmQ156QF4GhCeEmLd/5pJFwhgbqJsz6Eb+uHs142cYDtTfOIZQ8V/Q6Kc4= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Julien Grall Subject: RE: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Topic: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Index: AQHYfI531SRNO5A+8Ei3iOFoJrK02K1dB3iAgAE0OjCAABXrgIAAECwAgAAEoICAAARlgIAAAO0AgAmAA0CAABcRAIAA6+aA Date: Fri, 1 Jul 2022 03:11:36 +0000 Message-ID: References: <20220610055316.2197571-1-wei.chen@arm.com> <20220610055316.2197571-2-wei.chen@arm.com> <05dadcda-505d-d46a-776a-bb29b8915815@suse.com> <8e44e765-c47f-4480-ee44-704ea13a170d@xen.org> <6e91d7d0-78d2-2eec-3b14-9aea00b2a028@suse.com> <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> In-Reply-To: <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1C2A7C846B54B940B7236AC34B498C38.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 599c4d48-e753-491a-7324-08da5b0f71ec x-ms-traffictypediagnostic: AM0PR08MB4225:EE_|VE1EUR03FT016:EE_|VI1PR08MB3965:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vFZX4Rw9tzS6zyF0j6STewzLLpyguAZqlM/DOxN9HQ/RLOstK6LgBUn3sSeiKKVBwKrftRCVApE1lmsgTdtDhj+czaQG+2Ct2xL28AohYAeQ6sDu6oBDtkquz3TpXtAjU1HUq3GBKMhhLlsgjFY/I8ogsi7RLT7UwWMHyb9vwLtG9qbfUyhrXoYIK0WhBrcDf9vrtI7SATkB9yi8ft4sb4FB58gtZR72OvzXF9eywtl2ZFusy+ysQFVaZlaWXso9h7YFcnep4sxi1pQPQxDJz6xhKtoICKu/1suhdctMP0+eyOrpvLfqToEt6A1vzi3onXY49sfzqYxqWLBQs3fGuTv6MrHDJNr/x9F8NlOa4LpLRDRbl5x2ANFXTioqpSEgnKjMH2XezW5eDSGJlo++BygBPa4JEgTBFfPh7Zsu62f3ZanthBtKDNdFigLj6c9mlRk0m1vPId3JprCHcz4lSnj/2b+WlOYXbofFxLEDKVoyyWjX/7yjdJ5PmeYh/H4gYB8e17zEI+/rdWc0M45H9PTNfEbUsxXpiGqJ9qesXpvBFq6fpySo1S9wy/yHz/saiqJpwg6Fkc8JMCTLZ4PoMqsEchAqZRDhR2XPBugxt7/QnH75amOPfiiz8rPR4pTINZT28M+Q+fs6ifg3M6mnlxT5kyWXj6F6hcV1HfqRyQ8v+if7T8WxVFg1XZqGxYqZ8c9joBV0AsUDYvxrZryaiLewLBxQ7OTQSQrQLClhuKnU64nL+6d/hlVJCny51hS5zXoymgUHpnxWPJz97pyXgt5qKQXsp7k5g0zqBiYJcxAKQ+fG5x9fJzOLmQSdyLv4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(366004)(38100700002)(86362001)(83380400001)(186003)(76116006)(66556008)(8676002)(122000001)(316002)(66446008)(55016003)(4326008)(64756008)(66946007)(66476007)(6916009)(71200400001)(54906003)(5660300002)(478600001)(53546011)(38070700005)(26005)(9686003)(2906002)(8936002)(6506007)(7696005)(33656002)(52536014)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4225 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 650c18c8-70b8-4ed7-027e-08da5b0f6876 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BuNcSPw7aQY1FAul8WjDMdj5A2UrORw22//cDctNaNiFkbkMXh1/WQREGTqsi1S12BgzeHsDLEWQu8Sx0LmAxubvIwduIYC412w+ZjILxfZe4hzKmkLvdOTJVlyF6tbgAUHAxA9+oeTU6VzqrGqfjq9Bi02IwREjtXNjxufuO/b41xgOhoNRrdgW1AuyV16rbp6NlICt+VcXoXIsIxg7e+dCQlWpSiKNoSA6LYYSwpBj2LJj5cSLpkq1rTv7Bp52qO35JE7Q3yl5F5Md6z6y29uWPI3Zjs6CaOjsjthJg1bicXlr0Fm+sA2JcoVuPMWX2ihDd2PkBdJcE3MZC2pxgSN4hHmyNQsoMhRPlS//U46Gh3YUGdlVmPSMdcjMB6BmHoW44xhk8yOQvYNKOb4369nhBys1jzui6Y1DRUoONFk9Ez9Fnr4NlcGZVuKD8PPhUEIDW4cnKPdLXOl4OcR3kHiG2EVlvbhlGcBn3lBla5Nw6K1wKR3zBItSZorCEQ8vbeCh+BOx0Dm+2rjOrjwVdjD+H+20wIiH+spG6TquejxjjsRA3ayj+EpNRXIjGdyPOOwDfwoLEOa3JDtAYTocKSCY1lcMCrQ6Cd/AjAfRrz8YkVlxwVYeeAuSfV0vVOvRtRv59IX6VxGvxfbAm8X/FJkMEqriQ1hHNcPOMHwAMij1zlQ5OfkTYn/8WsPzUIbhmoZym5nITmyJEXfIhvKhmX67fJ/9/I2gixA+x+ORhpspZT6ygQmgg9M3gKhm6xg9vQGx7Xd/7SK20NpTgGmYEIsoXX07TAh6inzmzs0tLjok1nC93MvKXyCGT9F/4KI4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(40470700004)(46966006)(36840700001)(81166007)(54906003)(47076005)(316002)(356005)(82740400003)(52536014)(4326008)(86362001)(40460700003)(5660300002)(33656002)(70586007)(70206006)(2906002)(8936002)(8676002)(186003)(82310400005)(6862004)(55016003)(41300700001)(336012)(40480700001)(53546011)(26005)(7696005)(478600001)(9686003)(6506007)(36860700001)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 03:11:51.8898 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 599c4d48-e753-491a-7324-08da5b0f71ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3965 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDbmnIgzMOaXpSAyMDozNg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEJlcnRyYW5kDQo+ IE1hcnF1aXMgPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+Ow0KPiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNv bT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBKaWFtZWkgWGllDQo+IDxKaWFtZWkuWGllQGFybS5j b20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IEp1bGllbiBHcmFsbA0KPiA8anVs aWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjYgMS84XSB4ZW46IHJldXNlIHg4 NiBFRkkgc3R1YiBmdW5jdGlvbnMgZm9yIEFybQ0KPiANCj4gT24gMzAuMDYuMjAyMiAxMzoyNSwg V2VpIENoZW4gd3JvdGU6DQo+ID4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4gPj4gU2VudDogMjAyMuW5tDbmnIgyNOaXpSAxODowOQ0KPiA+Pg0KPiA+PiBPbiAyNC4w Ni4yMDIyIDEyOjA1LCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPj4+IE9uIDI0LjA2LjIwMjIgMTE6 NDksIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gPj4+Pj4+Pj4+IC0tLSBhL3hlbi9hcmNoL2FybS9l ZmkvTWFrZWZpbGUNCj4gPj4+Pj4+Pj4+ICsrKyBiL3hlbi9hcmNoL2FybS9lZmkvTWFrZWZpbGUN Cj4gPj4+Pj4+Pj4+IEBAIC0xLDQgKzEsMTIgQEANCj4gPj4+Pj4+Pj4+ICAgIGluY2x1ZGUgJChz cmN0cmVlKS9jb21tb24vZWZpL2VmaS1jb21tb24ubWsNCj4gPj4+Pj4+Pj4+DQo+ID4+Pj4+Pj4+ PiAraWZlcSAoJChDT05GSUdfQVJNX0VGSSkseSkNCj4gPj4+Pj4+Pj4+ICAgIG9iai15ICs9ICQo RUZJT0JKLXkpDQo+ID4+Pj4+Pj4+PiAgICBvYmotJChDT05GSUdfQUNQSSkgKz0gIGVmaS1kb20w LmluaXQubw0KPiA+Pj4+Pj4+Pj4gK2Vsc2UNCj4gPj4+Pj4+Pj4+ICsjIEFkZCBzdHViLm8gdG8g RUZJT0JKLXkgdG8gcmUtdXNlIHRoZSBjbGVhbi1maWxlcyBpbg0KPiA+Pj4+Pj4+Pj4gKyMgZWZp LWNvbW1vbi5tay4gT3RoZXJ3aXNlIHRoZSBsaW5rIG9mIHN0dWIuYyBpbiBhcm0vZWZpDQo+ID4+ Pj4+Pj4+PiArIyB3aWxsIG5vdCBiZSBjbGVhbmVkIGluICJtYWtlIGNsZWFuIi4NCj4gPj4+Pj4+ Pj4+ICtFRklPQkoteSArPSBzdHViLm8NCj4gPj4+Pj4+Pj4+ICtvYmoteSArPSBzdHViLm8NCj4g Pj4+Pj4+Pj4+ICtlbmRpZg0KPiA+Pj4+Pj4+Pg0KPiA+Pj4+Pj4+PiBUaGlzIGhhcyBjYXVzZWQN Cj4gPj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4gbGQ6IHdhcm5pbmc6IGFyY2gvYXJtL2VmaS9idWlsdF9p bi5vIHVzZXMgMi1ieXRlIHdjaGFyX3QgeWV0IHRoZQ0KPiA+PiBvdXRwdXQgaXMNCj4gPj4+Pj4+ Pj4gdG8gdXNlIDQtYnl0ZSB3Y2hhcl90OyB1c2Ugb2Ygd2NoYXJfdCB2YWx1ZXMgYWNyb3NzIG9i amVjdHMgbWF5DQo+ID4+IGZhaWwNCj4gPj4+Pj4+Pj4NCj4gPj4+Pj4+Pj4gZm9yIHRoZSAzMi1i aXQgQXJtIGJ1aWxkIHRoYXQgSSBrZWVwIGRvaW5nIGV2ZXJ5IG9uY2UgaW4gYSB3aGlsZSwNCj4g Pj4gd2l0aA0KPiA+Pj4+Pj4+PiAoaWYgaXQgbWF0dGVycykgR05VIGxkIDIuMzguIEkgZ3Vlc3Mg eW91IHdpbGwgd2FudCB0byBjb25zaWRlcg0KPiA+PiBidWlsZGluZw0KPiA+Pj4+Pj4+PiBhbGwg b2YgWGVuIHdpdGggLWZzaG9ydC13Y2hhciwgb3IgdG8gYXZvaWQgYnVpbGRpbmcgc3R1Yi5jIHdp dGgNCj4gPj4gdGhhdA0KPiA+Pj4+Pj4+PiBvcHRpb24uDQo+ID4+Pj4+Pj4+DQo+ID4+Pj4+Pj4N Cj4gPj4+Pj4+PiBUaGFua3MgZm9yIHBvaW50aW5nIHRoaXMgb3V0LiBJIHdpbGwgdHJ5IHRvIHVz ZSAtZnNob3J0LXdjaGFyIGZvcg0KPiA+PiBBcm0zMiwNCj4gPj4+Pj4+PiBpZiBBcm0gbWFpbnRh aW5lcnMgYWdyZWUuDQo+ID4+Pj4+Pg0KPiA+Pj4+Pj4gTG9va2luZyBhdCB0aGUgY29kZSB3ZSBk b24ndCBzZWVtIHRvIGJ1aWxkIFhlbiBhcm02NCB3aXRoIC1mc2hvcnQtDQo+ID4+IHdjaGFyDQo+ ID4+Pj4+PiAoYXNpZGUgdGhlIEVGSSBmaWxlcykuIFNvIGl0IGlzIG5vdCBlbnRpcmVseSBjbGVh ciB3aHkgd2Ugd291bGQNCj4gd2FudA0KPiA+PiB0bw0KPiA+Pj4+Pj4gdXNlIC1mc2hvcnQtd2No YXIgZm9yIGFybTMyLg0KPiA+Pj4+Pg0KPiA+Pj4+PiBXZSBkb24ndCB1c2Ugd2NoYXJfdCBvdXRz aWRlIG9mIEVGSSBjb2RlIGFmYWljdC4gSGVuY2UgdG8gYWxsIG90aGVyDQo+ID4+IGNvZGUNCj4g Pj4+Pj4gaXQgc2hvdWxkIGJlIGJlbmlnbiB3aGV0aGVyIC1mc2hvcnQtd2NoYXIgaXMgaW4gdXNl LiBTbyB0aGUNCj4gc3VnZ2VzdGlvbg0KPiA+Pj4+PiB0byB1c2UgdGhlIGZsYWcgdW5pbGF0ZXJh bGx5IG9uIEFybTMyIGlzIHJlYWxseSBqdXN0IHRvIHNpbGVuY2UgdGhlDQo+IGxkDQo+ID4+Pj4+ IHdhcm5pbmc7DQo+ID4+Pj4NCj4gPj4+PiBPay4gVGhpcyBpcyBvZGQuIFdoeSB3b3VsZCBsZCB3 YXJuIG9uIGFybTMyIGJ1dCBub3Qgb3RoZXIgYXJjaD8NCj4gPj4+DQo+ID4+PiBBcm0zMiBlbWJl ZHMgQUJJIGluZm9ybWF0aW9uIGluIGEgbm90ZSBzZWN0aW9uIGluIGVhY2ggb2JqZWN0IGZpbGUu DQo+ID4+DQo+ID4+IE9yIGEgbm90ZS1saWtlIG9uZSAoanVzdCB0byBhdm9pZCBwb3NzaWJsZSBj b25mdXNpb24pOyBJIHRoaW5rIGl0J3MNCj4gPj4gIi5BUk0uYXR0cmlidXRlcyIuDQo+ID4+DQo+ ID4+IEphbg0KPiA+Pg0KPiA+Pj4gVGhlIG1pc21hdGNoIG9mIHRoZSB3Y2hhcl90IHBhcnQgb2Yg dGhpcyBpbmZvcm1hdGlvbiBpcyB3aGF0IGNhdXNlcw0KPiA+Pj4gbGQgdG8gZW1pdCB0aGUgd2Fy bmluZy4NCj4gPj4+DQo+ID4+Pj4+IG9mZiB0aGUgdG9wIG9mIG15IGhlYWQgSSBjYW4ndCBzZWUg YW55dGhpbmcgd3Jvbmcgd2l0aCB1c2luZw0KPiA+Pj4+PiB0aGUgb3B0aW9uIGFsc28gZm9yIEFy bTY0IG9yIGV2ZW4gZ2xvYmFsbHkuIFlldCBvdG9oIHdlIHR5cGljYWxseQ0KPiB0cnkNCj4gPj4g dG8NCj4gPj4+Pj4gbm90IG1ha2UgY2hhbmdlcyBmb3IgZW52aXJvbm1lbnRzIHdoZXJlIHRoZXkg YXJlbid0IHJlYWxseSBuZWVkZWQuDQo+ID4+Pj4NCj4gPj4+PiBJIGFncmVlLiBJZiB3ZSBuZWVk IGEgd29ya2Fyb3VuZCwgdGhlbiBteSBwcmVmZXJlbmNlIHdvdWxkIGJlIHRvIG5vdA0KPiA+Pj4+ IGJ1aWxkIHN0dWIuYyB3aXRoIC1mc2hvcnQtd2NoYXIuDQo+ID4+Pg0KPiA+Pj4gVGhpcyB3b3Vs ZCBuZWVkIHRvIGJlIGFuIEFybS1zcGVjaWFsIHRoZW4sIGFzIG9uIHg4NiBpdCBuZWVkcyB0byBi ZQ0KPiA+PiBidWlsdA0KPiA+Pj4gdGhpcyB3YXkuDQo+ID4NCj4gPiBJIGhhdmUgdGFrZW4gYSBs b29rIGludG8gdGhpcyB3YXJuaW5nOg0KPiA+IFRoaXMgaXMgYmVjYXVzZSB0aGUgIi1mc2hvcnQt d2NoYXIiIGZsYWcgY2F1c2VzIEdDQyB0byBnZW5lcmF0ZQ0KPiA+IGNvZGUgdGhhdCBpcyBub3Qg YmluYXJ5IGNvbXBhdGlibGUgd2l0aCBjb2RlIGdlbmVyYXRlZCB3aXRob3V0DQo+ID4gdGhhdCBm bGFnLiBXaHkgdGhpcyB3YXJuaW5nIGhhc24ndCBiZWVuIHRyaWdnZXJlZCBpbiBBcm02NCBpcw0K PiA+IGJlY2F1c2Ugd2UgZG9uJ3QgdXNlIGFueSB3Y2hhciBpbiBBcm02NCBjb2Rlcy4NCj4gDQo+ IEkgZG9uJ3QgdGhpbmsgdGhhdCdzIHF1aXRlIHJpZ2h0IC0geW91IGFjdHVhbGx5IHNheSBiZWxv dyB0aGF0IHdlDQo+IGRvIHVzZSBpdCB0aGVyZSB3aGVuIGludGVyYWN0aW5nIHdpdGggVUVGSS4g VGhlcmUncyBubyB3YXJuaW5nDQo+IHRoZXJlIHNvbGVseSBiZWNhdXNlIHRoZSBpbmZvcm1hdGlv biBpc24ndCBlbWJlZGRlZCBpbiB0aGUgb2JqZWN0DQo+IGZpbGVzIHRoZXJlLCBmcm9tIGFsbCBJ IGNhbiB0ZWxsLg0KPiANCg0KTWF5YmUgSSBzaG91bGQgZGVzY3JpYmUgaXQgdGhpcyB3YXk6IEFy bTY0IGRvZXMgbm90IHVzZSB3Y2hhciB0eXBlDQpkaXJlY3RseSBpbiBhbnkgY29kZSBmb3IgcGFy YW1ldGVycywgdmFyaWFibGVzIGFuZCByZXR1cm4gdmFsdWVzLg0KU28gQXJtNjQgb2JqZWN0IGZp bGVzIGFyZSBleGFjdGx5IHRoZSBzYW1lIHdpdGggIi1mc2hvcnQtd2NoYXIiIGFuZA0Kd2l0aG91 dCAiLWZzaG9ydC13Y2hhciIuDQoNCkFsdGhvdWdoIFhlbidzIEVGSSBjb2RlIGludGVyYWN0cyB3 aXRoIFVFRkkgZmlybXdhcmUsIHNpbWlsYXIgdG8gUlBDDQpmdW5jdGlvbiBjYWxscywgdGhlc2Ug Y29kZSBhbHNvIGRvIG5vdCBleHBsaWNpdGx5IHVzZSB3Y2hhci4gQnV0IGl0DQppcyByZWFzb25h YmxlIHRvIGtlZXAgLWZzaG9ydC13Y2hhciBmb3IgWGVuJ3MgRUZJIGNvZGUsIGJ1dCBhcyBsb25n DQphcyB3ZSB1c2Ugd2NoYXIgaW4gRUZJIGNvZGUgaW4gdGhlIGZ1dHVyZSwgd2Ugd2lsbCBkZWZp bml0ZWx5IGVuY291bnRlcg0KdGhpcyB3YXJuaW5nIGxpa2UgQXJtMzIuDQoNCj4gPiBXZSBhcmUg YWxzbyBub3QNCj4gPiB1c2luZyB3Y2hhciBpbiBBcm0zMiBjb2RlcywgYnV0IEFybTMyIHdpbGwg ZW1iZWQgQUJJIGluZm9ybWF0aW9uDQo+ID4gaW4gIi5BUk0uYXR0cmlidXRlcyIgc2VjdGlvbi4g VGhpcyBzZWN0aW9uIHN0b3JlcyBzb21lIG9iamVjdA0KPiA+IGZpbGUgYXR0cmlidXRlcywgbGlr ZSBBQkkgdmVyc2lvbiwgQ1BVIGFyY2ggYW5kIGV0Yy4gQW5kIHdjaGFyDQo+ID4gc2l6ZSBpcyBk ZXNjcmliZWQgaW4gdGhpcyBzZWN0aW9uIGJ5ICJUYWdfQUJJX1BDU193Y2hhcl90IiB0b28uDQo+ ID4gVGFnX0FCSV9QQ1Nfd2NoYXJfdCBpcyAyIGZvciBvYmplY3QgZmlsZXMgd2l0aCAiLWZzaG9y dC13Y2hhciIsDQo+ID4gYnV0IGZvciBvYmplY3QgZmlsZXMgd2l0aG91dCAiLWZzaG9ydC13Y2hh ciIgaXMgNC4gQXJtMzIgR0NDDQo+ID4gbGQgd2lsbCBjaGVjayB0aGlzIHRhZywgYW5kIHRocm93 IGFib3ZlIHdhcm5pbmcgd2hlbiBpdCBmaW5kcw0KPiA+IHRoZSBvYmplY3QgZmlsZXMgaGF2ZSBk aWZmZXJlbnQgVGFnX0FCSV9QQ1Nfd2NoYXJfdCB2YWx1ZXMuDQo+ID4NCj4gPiBBcyBnbnUtZWZp LTMuMCB1c2UgdGhlIEdDQyBvcHRpb24gIi1mc2hvcnQtd2NoYXIiIHRvIGZvcmNlIHdjaGFyDQo+ ID4gdG8gdXNlIHNob3J0IGludGVnZXJzICgyIGJ5dGVzKSBpbnN0ZWFkIG9mIGludGVnZXJzICg0 IGJ5dGVzKS4NCj4gPiBXZSBjYW4ndCByZW1vdmUgdGhpcyBvcHRpb24gZnJvbSB4ODYgYW5kIEFy bTY0LCBiZWNhdXNlIHRoZXkgbmVlZA0KPiA+IHRvIGludGVyYWN0IHdpdGggRUZJIGZpcm13YXJl LiBTbyBJIGhhdmUgdG8gb3B0aW9uczoNCj4gPiAxLiBSZW1vdmUgIi1mc2hvcnQtd2NoYXIiIGZy b20gZWZpLWNvbW1vbi5tayBhbmQgYWRkIGl0IGJhY2sgYnkNCj4gPiAgICB4ODYgYW5kIGFybTY0 J3MgRUZJIE1ha2VmaWxlDQo+ID4gMi4gQWRkICItbm8td2NoYXItc2l6ZS13YXJuaW5nIiB0byBB cm0zMidzIGxpbmtlciBmbGFncw0KPiA+DQo+ID4gSSBwZXJzb25hbGx5IHByZWZlciBvcHRpb24j MSwgYmVjYXVzZSBBcm0zMiBkb2Vzbid0IG5lZWQgdG8gaW50ZXJhY3QNCj4gPiB3aXRoIEVGSSBm aXJtd2FyZSwgYWxsIGl0IHJlcXVpcmVzIGFyZSBzb21lIHN0dWIgZnVuY3Rpb25zLiBBbmQNCj4g PiAiLW5vLXdjaGFyLXNpemUtd2FybmluZyIgbWF5IGhpZGUgc29tZSB3YXJuaW5ncyB3ZSBzaG91 bGQgYXdhcmUgaW4NCj4gPiBmdXR1cmUuDQo+IA0KPiBJIGRvbid0IG1pbmQgIzEsIGJ1dCBJIHRo aW5rIHlvdXIgc3Vic2VxdWVudGx5IHByb3Bvc2VkICMzIHdvdWxkIGJlDQo+IHRoZSBmaXJzdCB0 aGluZyB0byB0cnkuIFRoZXJlIG1heSBiZSBjYXZlYXRzLCBzbyBpZiB0aGF0IGRvZXNuJ3Qgd29y aw0KPiBvdXQgSSdkIHN1Z2dlc3QgZmFsbGluZyBiYWNrIHRvICMxLiBBbGJlaXQgaWRlYWxseSB0 aGUgZmxhZyBzZXR0aW5nDQo+IHdvdWxkbid0IGJlIG1vdmVkIGJhY2sgKGl0IF9pc18gYSBjb21t b24gRUZJIHRoaW5nLCBhZnRlciBhbGwpLCBidXQNCj4gcmF0aGVyIEFybTMyIGFycmFuZ2luZyBm b3IgaXRzIGFkZGl0aW9uIHRvIGJlIHN1cHByZXNzZWQuDQo+IA0KDQpJIGFtIE9LIHdpdGggb3B0 aW9uIzMgdG8gc2V0ICItZnNob3J0LXdjaGFyIiBhcyBhIGdsb2JhbCBDRkxBR1MuIFRoaXMNCmZs YWcgd2lsbCBhZmZlY3Qgd2NoYXIgcGVyZm9ybWFuY2UgKG5vbi00Ynl0ZXMtYWxpZ25tZW50KSwg YnV0IFhlbg0KZG9lc24ndCB1c2Ugd2NoYXIgb3V0IG9mIEVGSS4gU28gc2V0dGluZyBpdCBhcyBh IGdsb2JhbCBmbGFnIHNob3VsZA0KYmUgaGFybWxlc3MuIEl0IGNhbiBhbHNvIGF2b2lkIHNpbWls YXIgd2FybmluZ3MgZnJvbSBhcHBlYXJpbmcgYWdhaW4uDQoNCkNoZWVycywNCldlaSBDaGVuDQoN Cj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:13:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:13:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358836.588206 (Exim 4.92) (envelope-from ) id 1o78xU-0006Bv-HQ; Fri, 01 Jul 2022 05:12:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358836.588206; Fri, 01 Jul 2022 05:12:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o78xU-0006Bo-Ek; Fri, 01 Jul 2022 05:12:48 +0000 Received: by outflank-mailman (input) for mailman id 358836; Fri, 01 Jul 2022 05:12:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o78xS-0006Bi-Vm for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:12:47 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 710b5d00-f8fc-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 07:12:45 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1CBA71F9B6; Fri, 1 Jul 2022 05:12:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E06C4139E9; Fri, 1 Jul 2022 05:12:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Dq5WNUyCvmJ7fgAAMHmgww (envelope-from ); Fri, 01 Jul 2022 05:12:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 710b5d00-f8fc-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656652365; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OAEh6bPMfjd7sLPj2eMiKgaZZ4+I9y9e581rRyYe51g=; b=HbB3AOIMibkXhJDUZxB5XnkrpYOIOaPDNBwM1Ov6cTQOW9dyWBYyiv0WMckPzpMbOpe1vj uzKsScnP76wJ1g3uv/s8LvDj3p4WWzz9eqzGK0goi8iSERnNeQ44js5jNGIuBI8oM61R8q cD5P7oZlhPPHlGwU/GzsXd011XhHAjE= Message-ID: <8f7224dd-72a7-d690-54da-98790d4a6153@suse.com> Date: Fri, 1 Jul 2022 07:12:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Content-Language: en-US To: Henry Wang , Julien Grall , "xen-devel@lists.xenproject.org" Cc: "jbeulich@suse.com" , Julien Grall References: <20220630183655.44391-1-julien@xen.org> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------506yOU8mgELDYMTGMVthC7Yd" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------506yOU8mgELDYMTGMVthC7Yd Content-Type: multipart/mixed; boundary="------------C9E0Lsh400j6596UmHskFmkp"; protected-headers="v1" From: Juergen Gross To: Henry Wang , Julien Grall , "xen-devel@lists.xenproject.org" Cc: "jbeulich@suse.com" , Julien Grall Message-ID: <8f7224dd-72a7-d690-54da-98790d4a6153@suse.com> Subject: Re: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end References: <20220630183655.44391-1-julien@xen.org> In-Reply-To: --------------C9E0Lsh400j6596UmHskFmkp Content-Type: multipart/mixed; boundary="------------3zbkpAQ3Vkvxc0alUooTta0t" --------------3zbkpAQ3Vkvxc0alUooTta0t Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjIgMDQ6MTksIEhlbnJ5IFdhbmcgd3JvdGU6DQo+IEhpIEp1bGllbiwNCj4g DQo+PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4gU3ViamVjdDogW1BBVENIIHYz XSBwdWJsaWMvaW86IHhzX3dpcmU6IERvY3VtZW50IHRoYXQgbmV3IGVycm9ycyBzaG91bGQg YmUNCj4+IGFkZGVkIGF0IHRoZSBlbmQNCj4+DQo+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGpn cmFsbEBhbWF6b24uY29tPg0KPj4NCj4+IFNvbWUgdG9vbHMgKGUuZy4geGVuc3RvcmVkKSBh bHdheXMgZXhwZWN0IEVJTlZBTCB0byBiZSBmaXJzdCBpbiB4c2RfZXJyb3JzLg0KPj4NCj4+ IFRvIGJlIGNvbnNlcnZhdGl2ZSwgbWFuZGF0ZSB0aGF0IG5ldyBlcnJvcnMgc2hvdWxkIGJl IGFkZGVkIGF0IHRoZSBlbmQNCj4+IG9mIHRoZSBhcnJheS4NCj4+DQo+PiBTaWduZWQtb2Zm LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiANCj4gV2hpbGUgdGhl IGNoYW5nZSBpcyBsb29raW5nIGdvb2QsIGp1c3QgRllJIHRoZXJlIGlzIGFuICJFUlJPUiIg c2VjdGlvbiBpbg0KPiAveGVuL2RvY3MvbWlzYy94ZW5zdG9yZS50eHQgdGhhdCBwb2ludHMg dG8gdGhlIGlvL3hzX3dpcmUuaC4gWW91IG1heQ0KPiB3YW50IHRvIGFkZCBzb21ldGhpbmcg dGhlcmUgKHRoYXQgZGVwZW5kcyBvbiB5b3VyIG93biB0YXN0ZSA6KSkgKQ0KDQpUaGlzIGRv Y3VtZW50YXRpb24gaXMgbWVhbnQgZm9yIHVzZXJzIG9mIFhlbnN0b3JlLCBub3QgZm9yIGhv dyB0byBtb2RpZnkNCml0LiBJIHRoaW5rIHRoZSBjb21tZW50IGlzIGFsbCB3aGF0IHNob3Vs ZCBiZSBhZGRlZC4NCg0KDQpKdWVyZ2VuDQo= --------------3zbkpAQ3Vkvxc0alUooTta0t Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------3zbkpAQ3Vkvxc0alUooTta0t-- --------------C9E0Lsh400j6596UmHskFmkp-- --------------506yOU8mgELDYMTGMVthC7Yd Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmK+gkwFAwAAAAAACgkQsN6d1ii/Ey8y rAf/ZBmKWK4BHf+W4+ZCxIPAvV5JczlWSmGxzg7eLP03/ZxxLMTMPgsP2R73ErMLFDLFe71JNoRE 6KUIBkICdggIz9/8cNE3Ib3lZ1sVyAsc05iobX8DVbQl6S4mEi6NWGyy5YWJ8MTsCOwusRi25LUN TOWXsWzyYAXz5qbX8SBGUmZNfRRJ/WQSD4L1FRAS7fE4NpDiobwatVkIBRy8ja2AA+SCDm7inWlI htppR2W52fh3kLLkTt3nrYC9Vrp7ZYPkq1dhkbT1BW7Y9i4spE3TcTvKCHc/IWfiHiEF0QVVjHcF +JpV69MIjUIcimORVJzMgnKzRNQbuJZ+kUnmqybCyA== =ivXW -----END PGP SIGNATURE----- --------------506yOU8mgELDYMTGMVthC7Yd-- From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:13:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:13:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358839.588218 (Exim 4.92) (envelope-from ) id 1o78yH-0006he-SL; Fri, 01 Jul 2022 05:13:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358839.588218; Fri, 01 Jul 2022 05:13:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o78yH-0006hX-Oi; Fri, 01 Jul 2022 05:13:37 +0000 Received: by outflank-mailman (input) for mailman id 358839; Fri, 01 Jul 2022 05:13:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o78yG-0006g9-C7 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:13:36 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8e3129ec-f8fc-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 07:13:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 349C81F9B6; Fri, 1 Jul 2022 05:13:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0199D139E9; Fri, 1 Jul 2022 05:13:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id fTkfOn2CvmKufgAAMHmgww (envelope-from ); Fri, 01 Jul 2022 05:13:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e3129ec-f8fc-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656652414; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c4tgpwUfFuaroKJMxuhzxSG5SGxV/r5LwiMxraJ28yk=; b=IFjs59x+7Fc/PebFdupeIftX3bgKlL60ZHecy6sETUQbjbYO3Y29U7bU/l39qM52tmSUc/ 1Q+KYe8bXQzANKTU4FUlBjFrtKff68GBWVP36JgFewFx0fmWMyO/yr742FYA5iStEVzypj 8fgqyq3kGn9iu/opWfypvmGZED7GyC0= Message-ID: Date: Fri, 1 Jul 2022 07:13:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, Julien Grall References: <20220630183655.44391-1-julien@xen.org> From: Juergen Gross In-Reply-To: <20220630183655.44391-1-julien@xen.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ywmOAaGtReiFWWf6CTU1H2Tz" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ywmOAaGtReiFWWf6CTU1H2Tz Content-Type: multipart/mixed; boundary="------------LM5A4AMuEmQIKy3vjnX0rXJK"; protected-headers="v1" From: Juergen Gross To: Julien Grall , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, Julien Grall Message-ID: Subject: Re: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end References: <20220630183655.44391-1-julien@xen.org> In-Reply-To: <20220630183655.44391-1-julien@xen.org> --------------LM5A4AMuEmQIKy3vjnX0rXJK Content-Type: multipart/mixed; boundary="------------0LT7VvJH7HKHRyqc1HmsVMyJ" --------------0LT7VvJH7HKHRyqc1HmsVMyJ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDYuMjIgMjA6MzYsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNvbT4NCj4gDQo+IFNvbWUgdG9vbHMgKGUuZy4geGVu c3RvcmVkKSBhbHdheXMgZXhwZWN0IEVJTlZBTCB0byBiZSBmaXJzdCBpbiB4c2RfZXJyb3Jz Lg0KPiANCj4gVG8gYmUgY29uc2VydmF0aXZlLCBtYW5kYXRlIHRoYXQgbmV3IGVycm9ycyBz aG91bGQgYmUgYWRkZWQgYXQgdGhlIGVuZA0KPiBvZiB0aGUgYXJyYXkuDQo+IA0KPiBTaWdu ZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KDQpSZXZpZXdl ZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------0LT7VvJH7HKHRyqc1HmsVMyJ Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------0LT7VvJH7HKHRyqc1HmsVMyJ-- --------------LM5A4AMuEmQIKy3vjnX0rXJK-- --------------ywmOAaGtReiFWWf6CTU1H2Tz Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmK+gn0FAwAAAAAACgkQsN6d1ii/Ey+p kgf/bxd2qJEMyKWbl/72+vZfZtH7sJUuwI34Yph9hcm3MTu+3trkNonwUOoAroaeGs1UVobghhfc cgBnym1Usdb9Nz1Py1/gza0IaFBCdRM3TK/V7kaswZpoeFXAr2InX2wbe2+E5/rZyl9mSkipbuvf DluUB47N1ny3K9030nUa+hZdzu9EqKy8pgBvjhY5zI1sdP0S723j+WUHt3pTuIbKCeNgvj2/makt U6AeFiqAG5JofP4HgDB7fDsBUoI2dzrG5hL8OxnoPXghPXzbom19TXxxWNnJQeYDPLILtxp7lGD2 DjJ2G3/B7I22IQLGr8rXnOY7g1wHrr2LIcGttvDhEg== =m5sR -----END PGP SIGNATURE----- --------------ywmOAaGtReiFWWf6CTU1H2Tz-- From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:15:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:15:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358846.588229 (Exim 4.92) (envelope-from ) id 1o790K-0007KR-8d; Fri, 01 Jul 2022 05:15:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358846.588229; Fri, 01 Jul 2022 05:15:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o790K-0007KK-4z; Fri, 01 Jul 2022 05:15:44 +0000 Received: by outflank-mailman (input) for mailman id 358846; Fri, 01 Jul 2022 05:15:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o790I-0007KE-Pd for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:15:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d946f83f-f8fc-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 07:15:40 +0200 (CEST) Received: from AS8PR04CA0152.eurprd04.prod.outlook.com (2603:10a6:20b:331::7) by DU0PR08MB8140.eurprd08.prod.outlook.com (2603:10a6:10:3ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 05:15:38 +0000 Received: from AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::40) by AS8PR04CA0152.outlook.office365.com (2603:10a6:20b:331::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17 via Frontend Transport; Fri, 1 Jul 2022 05:15:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT059.mail.protection.outlook.com (10.152.17.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 05:15:37 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Fri, 01 Jul 2022 05:15:37 +0000 Received: from a1f9e7746467.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6A08FEA4-66AC-4CA5-8265-064C75896A82.1; Fri, 01 Jul 2022 05:15:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a1f9e7746467.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 05:15:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB3471.eurprd08.prod.outlook.com (2603:10a6:803:7d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 1 Jul 2022 05:15:29 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.014; Fri, 1 Jul 2022 05:15:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d946f83f-f8fc-11ec-bdce-3d151da133c5 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h/LMnun09YY7f83eiTxVCgUPKCeG+hloqAakOWV2lbvEwtkzBJoh8vocxGgCw4T+eI45DD5A4nvoxUHPAhYRekm5+60JzlNKpciKG1PEDUaJrQar92k+163YljKJYffNJBtdyWe1r7cDzN1zJ9kkWzbcyL7fknNg6CGpK4DfxAM31fcTroB78GmJSaQ9RqHA1vBuA4G10E48ol9f7skHHbeBEHICfitCWaIJSjrla9+QhV2Stb5Pw8mQF9YP1BOKdA8R4xEdX65U72ztJ5XZdSYiIDjriJWVagdgu6qBgINAoWn1OcsMapA3oFd7EWeAMK1QEa03AjebpwNShNtRVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=gU82rU0BJ0+WcNWex7si6ndIYv1MbkJQW7rloDSQvDLwwp1zSfQcLsLUih2W4tX7+lKRUHCHCEB0HjXFAbCAtUyF8ZBQbhAO+QUr0p+aWBztjIAZCLsd/O41sYmzEuWHG7rQIfrk0wZ1L7ICIMWqo6KSoktyvxXCnoKDHKccKspQVK0YBtU1tvZOSVMEWLxFScTzODu5//VwvHjmX4r8I70v5rE3EW8Ac6bjakpIDfdERWzGdcf0NiMT3lYXZqgFhAnFERCN5g6ZE6r+MJ9m53ZmqM+GCUHeox5qhi1WCzS2+0b51/kd2BgNcJBiLIIqoGHTDPu9wCLBfXI2w5ROWQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=Dit00Mvw/NC59snY63DdsUaZeEfOoY8A2MrRcZl9CEh0aNrENnzFgtdssAaWUmkHxdm1G/FzUIvLzrghaD7uzklgGcOwoU7uGGgN05jLeQFRgaVKrBJ9kUqiy9fQv6le/24jpW9BtDdYEaY3yOH1IUeeHh+JSpncpB9NGB6k5OE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BN5jo6z5u6jGejB/WPplZ5lWEFgQjuXnWSZQtio0bZ6ikXBrDUW9kCVNDoyP/Onygnn0eWwtz3NxRPgxEsu4g2k8EisgiXYtDeDXboAZfshWCbA09cgn1oOhcMw3HzCLzOecTMlgqAAruEwD/v5f0wXmzzea9a5YVmP6Wsu9UUzuntal5tnBJXb/pp3qveWC53m8z+CqJGvsmDul4uu3woHVDKjnfhjJ7eGSSFK8yguRlRIVpB7ZqS6m+H/usqqupcOfu7eJn81Uc+5Gvx2JAZGZTKTj5aB0WwboYaAcl3O5T4Gl812eKRqMBalrITKyl/1MjKhdKR9OF/1siN9DoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=nOIBFdunQOO0TX5f8h/4wn8reHZKQ1CyZ/7b2p0dWLgzlEC/zRiP2AxVTKTltKOsxXTKDJN9JN70yNRwni2BenzB057+nSejaZJS8FRul991M9Y6La1dg/wT/u8IMfCDhoLF20fFpRET7ZvXmyP80iwP6Wajt0hrO5DATyIz0X1nxcZIwNvcXiIB9eEAOIK9FoIS02Qmj/VSNH7WhX4V9UWycQT5d21XRhQEHPBHNDJG2EGYeTO7bbjzZD1swP40Avkg7hhDmGQCNBFfEXcWOfzwKQwm6fbxU0uKxq+zepY5CYKU4MxB26nwU1NuJ/rzb3gyD7srGpC97CYjmajvRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GVwCWXc1+TSNoacnkpf/IEWCE7xaUXwTOiE4rGFpa9E=; b=Dit00Mvw/NC59snY63DdsUaZeEfOoY8A2MrRcZl9CEh0aNrENnzFgtdssAaWUmkHxdm1G/FzUIvLzrghaD7uzklgGcOwoU7uGGgN05jLeQFRgaVKrBJ9kUqiy9fQv6le/24jpW9BtDdYEaY3yOH1IUeeHh+JSpncpB9NGB6k5OE= From: Henry Wang To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: "jbeulich@suse.com" , Julien Grall , Julien Grall Subject: RE: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Thread-Topic: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end Thread-Index: AQHYjLCT8ll1pspHXU2Irp2zQF5YmK1ox2KQgAAxoACAAABVAA== Date: Fri, 1 Jul 2022 05:15:29 +0000 Message-ID: References: <20220630183655.44391-1-julien@xen.org> <8f7224dd-72a7-d690-54da-98790d4a6153@suse.com> In-Reply-To: <8f7224dd-72a7-d690-54da-98790d4a6153@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A04DDEC2AEBDFF4488FD05D12120483A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e3b75036-abe5-459b-56c0-08da5b20bc26 x-ms-traffictypediagnostic: VI1PR08MB3471:EE_|AM5EUR03FT059:EE_|DU0PR08MB8140:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +UIq3IR2gEndJacCUXG5dOI8VP9EuYssKfO40Q286/iSJAtLaxvUFyhPx7ZbOCq5KcnztNmqjteOvUPTC4iB9iy6SEh2lJkRO3V/Ci6tM63CNVis9JwoOvwvWmfVK51TgGPlzAoTwZZg6vmgAAz6Zo825THtmJM2KEXlwSiU4qoILQdwlDkhJjKkjr4U4AE/s0uBPxVpJacKm0BDFDEffltuHNlgIgoiLfYXNveE4ALRi7HbkffOb8VkDiujloCu9UZ9kVoJmx5F1H0YAJECC8CUzjSglqkbTWrxkcLQYWiSnjn6KAfn5IFzXQI07BDQ8BJgbCEUzdTQaaodcrkhOIBR6fyAnDNjwA9HZK3quy7y4hEzBP2+HV+IVWZlev8RvffOdhRWWMFMMsyjs5aamJGriE4SsMxJGQIjCzIaGmNsHyrsGB4jVBxXFsFlXROia42M9vbsbKW9qTL5UXDbN3HU65JlkbMqyMLoCVVgadE/0CRgRGA/vLWnnftJGGxCOF0fkZMS9ejj1UbFRnpMB5lY5jyH6tiz6xRLpO3ih3zpYZMnIO0QydzY1JptXDSOetn4U9wukhlp8LVymfcYdvZj8DtTh1BJpBN3kwnV3a9R+oMzivXJiRdn0jct0l7Tl8BWgUOH+g4OUIuKtW11bh9EzDuQmc8ZNcyR1f2OIoTGageH+AbAsf33olq5KnGeRgoThp/lUa0NKFlfzqtRYaXNgDImpF5+jGEvOIOQx8lvSxhWUS8Q++r3xrz+VX8+t5C+bqU+IAfMvOWAErQu98UtwU08s53LPpvDNf0gIx3kFiii5ChbrFsFlOWImljz X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(122000001)(9686003)(66446008)(7696005)(26005)(4744005)(2906002)(53546011)(33656002)(41300700001)(38070700005)(71200400001)(54906003)(110136005)(86362001)(83380400001)(478600001)(6506007)(76116006)(66556008)(4326008)(66476007)(52536014)(5660300002)(38100700002)(55016003)(64756008)(8676002)(66946007)(316002)(186003)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3471 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5c22b1f4-bbd2-4c26-3fed-08da5b20b70a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cd0AdqztRiQIqRMvPClO9ctbj3ahhyVKLg69mCN8q9wczaBUXTR4fLEUln4YLkOdz4ZC6Bjc9XVa4xv+WcMK8NNEFc2/BruD7ci98aW50Mbk9ZOXKaHdEd4+6vvjWETeipspQLNAPAPEFyrEKNLkH83xnonTv6B4ZQpUH5+c9/JA+U7hU+gZRE8j2eF0d/VGx9s2P2B9lfyc6g69rl3d64g3AK2yXLqexO6/u3k0XjI5hfN7p8HXCwW+VfrScHZXhR5vFdxVuILDtvtcyI0QjAyo1Y2FAOGYUaB1pKdy9p0zWgnChGjDcBH7Zb+YQ8aAt6lHwRJgKIl0pffr54rGRlNa42DrPknmcMMFFq2emDGwPjoYf+FvxWjzN5DHia3fGYEHDA+Vw4pyw32wYbW4TqEsrCvGJhG8veTa1GjBpct2/t3enFh5FU8a/W61O08V64/MdvO8uVC35aTiRkgUAGvfM4XdDGU69ktY+J2+qdjvx41RW00nfIrC1koKPgyutk7VCktohq55FeE6lyOtf8ISt4rNBbkFXxIL0YNTMah7DENuRRYqVtPNkRJncPHZAtLjZfTB2XhTXObtI7iaZijQRIKh2xQpz14pB1UsUEiKjFfz6TeHbS2SjTdJIuDnx4fZbcZLxBCRPtDj5OyHwDa/3R7qbbEFXViaYaRechCFAusuZsVmR1WRIerJkR6sUGU2jqF2wuUNj8Dhy8fYs2RBwbOKXnysWvUyNj49+sWxGMGb8micMDLhLmsUviZK7lIVaneDDoqHp0ZypnhA/bD92Xpslzyx7fn0weGX4CcMIvMDHDE1aqHLo24laZT+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(55016003)(4326008)(52536014)(83380400001)(5660300002)(86362001)(8936002)(70206006)(33656002)(40480700001)(40460700003)(316002)(2906002)(4744005)(110136005)(9686003)(336012)(81166007)(478600001)(356005)(6506007)(70586007)(8676002)(186003)(7696005)(53546011)(82740400003)(41300700001)(47076005)(36860700001)(26005)(82310400005)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 05:15:37.9431 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e3b75036-abe5-459b-56c0-08da5b20bc26 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8140 SGkgSnVlcmdlbiwNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBPbiAwMS4wNy4y MiAwNDoxOSwgSGVucnkgV2FuZyB3cm90ZToNCj4gPiBIaSBKdWxpZW4sDQo+ID4NCj4gPj4gLS0t LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gU3ViamVjdDogW1BBVENIIHYzXSBwdWJsaWMv aW86IHhzX3dpcmU6IERvY3VtZW50IHRoYXQgbmV3IGVycm9ycyBzaG91bGQNCj4gYmUNCj4gPj4g YWRkZWQgYXQgdGhlIGVuZA0KPiA+Pg0KPiA+PiBGcm9tOiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPg0KPiA+Pg0KPiA+PiBTb21lIHRvb2xzIChlLmcuIHhlbnN0b3JlZCkgYWx3YXlz IGV4cGVjdCBFSU5WQUwgdG8gYmUgZmlyc3QgaW4geHNkX2Vycm9ycy4NCj4gPj4NCj4gPj4gVG8g YmUgY29uc2VydmF0aXZlLCBtYW5kYXRlIHRoYXQgbmV3IGVycm9ycyBzaG91bGQgYmUgYWRkZWQg YXQgdGhlIGVuZA0KPiA+PiBvZiB0aGUgYXJyYXkuDQo+ID4+DQo+ID4+IFNpZ25lZC1vZmYtYnk6 IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQo+ID4NCj4gPiBXaGlsZSB0aGUgY2hh bmdlIGlzIGxvb2tpbmcgZ29vZCwganVzdCBGWUkgdGhlcmUgaXMgYW4gIkVSUk9SIiBzZWN0aW9u IGluDQo+ID4gL3hlbi9kb2NzL21pc2MveGVuc3RvcmUudHh0IHRoYXQgcG9pbnRzIHRvIHRoZSBp by94c193aXJlLmguIFlvdSBtYXkNCj4gPiB3YW50IHRvIGFkZCBzb21ldGhpbmcgdGhlcmUgKHRo YXQgZGVwZW5kcyBvbiB5b3VyIG93biB0YXN0ZSA6KSkgKQ0KPiANCj4gVGhpcyBkb2N1bWVudGF0 aW9uIGlzIG1lYW50IGZvciB1c2VycyBvZiBYZW5zdG9yZSwgbm90IGZvciBob3cgdG8gbW9kaWZ5 DQo+IGl0LiBJIHRoaW5rIHRoZSBjb21tZW50IGlzIGFsbCB3aGF0IHNob3VsZCBiZSBhZGRlZC4N Cg0KT2sgc3VyZSwgdGhhbmtzIGZvciB0aGUgaW5mb3JtYXRpb24uIFRoZW4gSSB0aGluayB0aGlz IHBhdGNoIGlzIHBlcmZlY3QuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IA0KPiBK dWVyZ2VuDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:54:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:54:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358855.588239 (Exim 4.92) (envelope-from ) id 1o79ba-0003rW-8v; Fri, 01 Jul 2022 05:54:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358855.588239; Fri, 01 Jul 2022 05:54:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79ba-0003rP-67; Fri, 01 Jul 2022 05:54:14 +0000 Received: by outflank-mailman (input) for mailman id 358855; Fri, 01 Jul 2022 05:54:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79bZ-0003rF-Cu; Fri, 01 Jul 2022 05:54:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79bZ-0001Wf-B1; Fri, 01 Jul 2022 05:54:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79bY-00070j-Sz; Fri, 01 Jul 2022 05:54:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o79bY-0001ZM-SN; Fri, 01 Jul 2022 05:54:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=S5vMcOVvX+BpZIcx56aBbpsBH7pd3x9qpcxDov7+DaQ=; b=HDwTRQpx+ycKr4hQPYIrbZUMi3 FGbzuqTCoorkzPJnOL9BKRk5C5wAZXA0+B3BPzQRm6B+hIX9qOd2/zFABaib86sepTpmKlbn/L9O6 I42e4pRITBz+ScdggO271dj6YiWP3KQh/pLuSm4s+QTUlwQw9lqJEBNXI92QvX8bVGY4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171429: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=1a0e93df1e107dc766fdf86ae88076efd9f376e6 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Fri, 01 Jul 2022 05:54:12 +0000 flight 171429 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171429/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 1a0e93df1e107dc766fdf86ae88076efd9f376e6 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 12 days Failing since 171280 2022-06-19 15:12:25 Z 11 days 32 attempts Testing same since 171429 2022-06-30 18:42:35 Z 0 days 1 attempts ------------------------------------------------------------ 384 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 13652 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:54:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358858.588250 (Exim 4.92) (envelope-from ) id 1o79bj-00049N-Hw; Fri, 01 Jul 2022 05:54:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358858.588250; Fri, 01 Jul 2022 05:54:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79bj-00049E-FD; Fri, 01 Jul 2022 05:54:23 +0000 Received: by outflank-mailman (input) for mailman id 358858; Fri, 01 Jul 2022 05:54:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79bi-00048J-1t for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:54:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3f9a34b7-f902-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 07:54:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5725.eurprd04.prod.outlook.com (2603:10a6:803:e3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 05:54:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 05:54:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f9a34b7-f902-11ec-bdce-3d151da133c5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YP3f1xUTt2i2sMc+TiMazckP4VF2lY1og5KieUD3tZaOkJJHiCS6qcqUHm8GXKV543mldYC3C549dJrHTKc6dXZ8wG85ljoer72Qgo635qW4LGdNZvFcTkq6PuTh1nHVrX6PbqzNzTJAhvzIJJ8dR32+Lsvd0TnsUt0j5myschnrt1DBmIS2PsRB8DkHSROILZsgmej2F1FC6uTbNzdL6ekDV3QJ2LniIzb/hC2yaLM9770tavtmQDcWlHJNLqXqdK9OzWfna765iDNZGRKeF8/vadT/5ceTiOPIYQFm57gEp185B4tT8lcxHEE4flJ5NbEx8eOXOQ6VA3bqcmpCWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yqlDZZ6b28GoaYLA1f89ZHTaarUOMAkMgn8aeWLHv/k=; b=f4KQAEJhuFduidNCSQUTGiLlR1eTzFPKTay3eSMozJPU15ohtXxGs/7QFBToMcBdsGl3FxfQ3mnuTlq/jD/SKIzbIfZRWY5YcejszoaN/UlhIkZnoqO/iNONihY4kjqFck0Q8Png/MsO6Gr+IYL4QlUqW5N6cU2SVBO5LyfuDjFl5IHyCJKfrN3egVVGQJH9xubCIgjltbiT9JNunlG8ygTuIbK2xiMtP3uttd5UG8I3yPW3GqjYD3a/5JZCQ25Zr+qjWnqeEypVk2D5w8MnSSvjuz7EJsMPR/YuEK5d4YN0lchP3j3nKZ8DQlHFqdWYDJCBuwN01282vgAX9GbPGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqlDZZ6b28GoaYLA1f89ZHTaarUOMAkMgn8aeWLHv/k=; b=kzWliUXdZzkXh+tJE15zaOErGfqzC1+AAtULzALGnfFf7H0cni+X9+kOtxfqKLJcSNNev7Pxy6+kpynVZMNvZaXzSx5cH2AY6wlfdTt5zLODKs7Clk7MXu6yY3BNNqj9AlOi/6ufmN7LiiK36Bg8PLJLgveF5faOjO+o+RVuahbaSkhc+r6amaEQvDqDA2NoIvPpZ0vhB2b6ToJDTXH2540k5F8wWjfCiULXvYDCOT+noDOh39iERpeG0Ien3fVNPVJdwsHnBg71YdPNbUsoOs1lZJ3Hx2RB8PC35DBa/mug6GN8dUfJo6AQnlfMiGu9be4XGKwL1WVO/rUEqXgbIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <13142c32-f67f-751d-4783-87e8afa1117a@suse.com> Date: Fri, 1 Jul 2022 07:54:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US To: Wei Chen Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Julien Grall References: <20220610055316.2197571-1-wei.chen@arm.com> <20220610055316.2197571-2-wei.chen@arm.com> <05dadcda-505d-d46a-776a-bb29b8915815@suse.com> <8e44e765-c47f-4480-ee44-704ea13a170d@xen.org> <6e91d7d0-78d2-2eec-3b14-9aea00b2a028@suse.com> <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0072.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::49) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 340e8986-f828-4c43-e9ec-08da5b262295 X-MS-TrafficTypeDiagnostic: VI1PR04MB5725:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jdooPxgYJmX7PhRrr4SofOvcBti381J+70wWYejyJ5fisBa7UWz6bj8i9usxALRioD2CNimqRtf+dJinJSofMUnWkp1WvkOm6vf2Z/mmbNDQfQv2Z9H8jAFwSf9MfZqMvTXfH9fqny9O4Ng5SXZP+h3qBOt9HTlnO+4pjqOI75yxzLM4hJTDLw9zlIyB9/r5sVbaRzm5y5IynS0nWznPTihV9We7z8mUMpfuzyoHJtmdUVnY0XCiTaOVZNE3vkkrxyH4j+tmz86n0WIYy8WZbh5/bVKLhQSP8tw7t/zCesp2udcWNZv75DScLcYrZ8xvl5BJq+KJf2lO/Hy3YAj/P7CZLNRO8882TLkV8D0tJGqCOstTvqXAd+wC8d1fe+ts+eED3XsddMPpfKm3vYQtJj/RL6CMQVegNYLHrLMjCg9f7FC8XSpILpjEMuS8p6JniRnvQ5/MRz+E+MrMzzk9eLCaLYCtzug5dvnmGYDzT7Zi6X3p0Dc8WedXjtVAY3Xttf1GYWOn/wEEHYyp29r2mtBGtPOUFFLTp1FjH1cAx2+pWfOh0lmpM87wdC6siTabFcxpjYI1OtgWoCGPELpfBoSiIKjYcTGyVMWeD2ZCgkftX5LxSi6fq+FlKHJRZ8jFDkugm2luTr6e4p2DaiGrtZql46q3QeZXgZ6GLP/FE7LGMHcYSE9BdmFwL0Ufq9dQi+6NkRecpm6ZJr65kC1+45T+jbe5kYXB7nvqjkrpYZrgywNUy/A78WASpUjVGKfMpXPkBHwmyw4xff2cAj+6AykQNDTjbf9nHvPrgKSgAJrNBlJIl3PbhIBO8E+JkrSdFBWsX2WgoUVmxkCRWXDLBXaC7A++c791fEsilM6FwRg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(346002)(39860400002)(396003)(136003)(31696002)(86362001)(6506007)(38100700002)(316002)(66946007)(4326008)(8676002)(66556008)(66476007)(54906003)(2906002)(6862004)(8936002)(5660300002)(26005)(7416002)(186003)(2616005)(83380400001)(478600001)(6512007)(6486002)(53546011)(31686004)(41300700001)(6666004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajNybzlsWGFFc1k2MVdoWm0xQm5ld2VCTDl2YUZwc29pdVNyK0NEOTJKdDRx?= =?utf-8?B?S0QxQ0dvNGVSVXV2cm9oN2NEcjJxMCtSRHBWbW81UWlIWDM2YXVDQ3dzZkJx?= =?utf-8?B?dWp3bmhlajdjaXBvS21zbE82UjBacVp0YVdxdEw4UG1rL3F0WGJiUkFsa2lF?= =?utf-8?B?cmlFeG1DeHZyaWg1eWlRcHliaU5RTERwT29ZVkp6WG9aMVBxQ0VnZzJUWkh6?= =?utf-8?B?Q3gyeDRMRElFbGVlYlFIM1lzdmFDZWNWRG1sR3krZjdLZDhPYS9MMHYybm9Q?= =?utf-8?B?YmZpL0R0REt5ZFNhaThFMERHcnBzQldWQTE2TGhZR3l2YkVMa20rdWpyZXo5?= =?utf-8?B?NkdvQWtyZU1tSXFsN3oyVllVTXY0SlR5bUZuUE5KRndIYlhZa01Vcm1razFm?= =?utf-8?B?aTBVL1B3aHlpTXRwcUdEeUlFYVl5M2Q3VVVCdzJDV0ZsWUk1Rmx3b1hpVGxV?= =?utf-8?B?MlhmYkxxcXgvR0hYVFRURGZ3MnplVjJxQndUdVZzczlnYWxQNTdJdnRwSngv?= =?utf-8?B?MDlWOXZBMmRoVEZTY2dmYmt0WlFmYTdDc05zVzR6S2o1ZFowdVM3WVlYeml0?= =?utf-8?B?NHBjeHl0SGJ0cGJ5N083TlFjM1V3Q1c1YjZ2V1kvNCtsak9EVlVOWm8rM0Fu?= =?utf-8?B?NmxPZmJGb21kWnRleE40RW1uSnlOK0g4WGhMMHFhUTFFa3JkVGl1aDh3bGQ1?= =?utf-8?B?RVk4bW9mZnRFNjBwZHZjRkJTdDFwMG05cE5FMlFTdDZubkRNdUNsYXFnbnFM?= =?utf-8?B?UlV3bm5SdGg4bVo0UzlJNUZnMXIxVytLQWpiWnh0WVdBOHBVOVNtOUJhYVlJ?= =?utf-8?B?MlNsZWQrS3JpVUpRZ1AxckozSkVmR1NENmdGSWhwb0JvUHpBb0FjWlcvZGdJ?= =?utf-8?B?VTZzcjZROGltVDFib2Z0aFk4a0JRSlB3RjYyQnZXMi84R1l3N1YwTVVrUFlX?= =?utf-8?B?ejJ5LzRpNHhYeEd0K3ZxYWUvRDFsMWpCdmZaRHVuUWg2UW5LMmNPMVVSQ0xW?= =?utf-8?B?akpUWXR5WEQ0WTJqb21lanlQZ3JDeDJXR0NlNTJxN1VMa1ViU1dWTExFaFhq?= =?utf-8?B?dm1RYzY2cERHalNmT3FHVWNSNkh3eTdaZ25nTXY3dkdOYjFBckV6MTdtbkdx?= =?utf-8?B?aVg5ZmxNN3RwR1pmV2xYU3Q1dTlLL2RzVDZoZXNBL2o2Z1l4RytFc21IUS9i?= =?utf-8?B?QktWbTYyL05WbnNGa1I0NERPSlVuSlpOMENPeGwxMW00L05pTHVRcWtGVkRX?= =?utf-8?B?UE83QWpadTBFR2ZXMGkvM0RkSWd5RXJ5SEpZaEw4QjB6TFpNSUFidDgzcFFC?= =?utf-8?B?NDh3MzRSVXByYkRyMHNjVTljZmJPN3FXZEZkUkJ5VWVoUWQrQXBPNzI1Umhl?= =?utf-8?B?K3VPTTBvMEpjaExBd0Y5TjB6UXNNV25peHVLOWpmZHQwcm1vYjdzRUVZaVlV?= =?utf-8?B?T3g5ZFNSZlNHUkFWN1gvN0kzNkhqakgyUWNWUFl5OTA4bE9nS0NvS3lCWmhx?= =?utf-8?B?SDVRbEZLMU9mWHRXbElDUjZKWlBVdGR5SVJzT29KdnZ6RFRYV0V5R3N1UUcv?= =?utf-8?B?LzJPNEk4NENvWmhyYS9SNXpONkdud2pVNVkvZjVnUWV4ZUNpbHJNSVZ6UUo3?= =?utf-8?B?WEF2RGVJN2pKa3NXalk2Ymx1eWRjdGNVdFJqM29ZUFh0UkxRUFRvaWdpRXp6?= =?utf-8?B?UkMwTjl5Smx2WE9VLzdSNlR6WkNKOE5GQitZUmVTQ1BsZ0dTazNVUnZkVkY2?= =?utf-8?B?VVArN082WDB5S0pFUHovVmdsRTFmNTM0K2J2aGhNUzh3dElGTG9RWU5WaytK?= =?utf-8?B?VElQWmtWTVB1WkxFUTgxL1VQM3lHRHc5NkxmdTJVR3d6My9nS0NUUWMxeHFJ?= =?utf-8?B?OHE2SDJVSHcvbEhqaXgxQlZrN2FYRlhJL0lwM0RTSHZwWHVIUmJ3eHVneGdX?= =?utf-8?B?WW0rdjZwYmpsaU03N2NNOXVibFhIK0lyd255WVFWcktheUhvSG1NNGxXTW44?= =?utf-8?B?UE5XVW55TWhRdmFMS3IvU0NtQVpqVCtxZ1Z4SkY0emRoTzYzbm9YSlltOEkv?= =?utf-8?B?eGtFaVFNOUxGYUxmUDZ2Nmg2blFCUVNIVUF0VjdIUTVVemM3YWpRWTg1aGx6?= =?utf-8?Q?zMCWHROjQBInAdaiFN/EUWCZE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 340e8986-f828-4c43-e9ec-08da5b262295 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 05:54:17.5981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ibC1M6hTpC12MMVc0D/03nIlxXYKaGgUoMIl/tg2Q/xqg2gsNe1za0/A6DfrUmS82cQZBd2zyW/2bnecXCtC9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5725 On 01.07.2022 05:11, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年6月30日 20:36 >> To: Wei Chen >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> ; Andrew Cooper ; >> Roger Pau Monné ; Wei Liu ; Jiamei Xie >> ; xen-devel@lists.xenproject.org; Julien Grall >> >> Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm >> >> On 30.06.2022 13:25, Wei Chen wrote: >>>> From: Jan Beulich >>>> Sent: 2022年6月24日 18:09 >>>> >>>> On 24.06.2022 12:05, Jan Beulich wrote: >>>>> On 24.06.2022 11:49, Julien Grall wrote: >>>>>>>>>>> --- a/xen/arch/arm/efi/Makefile >>>>>>>>>>> +++ b/xen/arch/arm/efi/Makefile >>>>>>>>>>> @@ -1,4 +1,12 @@ >>>>>>>>>>> include $(srctree)/common/efi/efi-common.mk >>>>>>>>>>> >>>>>>>>>>> +ifeq ($(CONFIG_ARM_EFI),y) >>>>>>>>>>> obj-y += $(EFIOBJ-y) >>>>>>>>>>> obj-$(CONFIG_ACPI) += efi-dom0.init.o >>>>>>>>>>> +else >>>>>>>>>>> +# Add stub.o to EFIOBJ-y to re-use the clean-files in >>>>>>>>>>> +# efi-common.mk. Otherwise the link of stub.c in arm/efi >>>>>>>>>>> +# will not be cleaned in "make clean". >>>>>>>>>>> +EFIOBJ-y += stub.o >>>>>>>>>>> +obj-y += stub.o >>>>>>>>>>> +endif >>>>>>>>>> >>>>>>>>>> This has caused >>>>>>>>>> >>>>>>>>>> ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the >>>> output is >>>>>>>>>> to use 4-byte wchar_t; use of wchar_t values across objects may >>>> fail >>>>>>>>>> >>>>>>>>>> for the 32-bit Arm build that I keep doing every once in a while, >>>> with >>>>>>>>>> (if it matters) GNU ld 2.38. I guess you will want to consider >>>> building >>>>>>>>>> all of Xen with -fshort-wchar, or to avoid building stub.c with >>>> that >>>>>>>>>> option. >>>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks for pointing this out. I will try to use -fshort-wchar for >>>> Arm32, >>>>>>>>> if Arm maintainers agree. >>>>>>>> >>>>>>>> Looking at the code we don't seem to build Xen arm64 with -fshort- >>>> wchar >>>>>>>> (aside the EFI files). So it is not entirely clear why we would >> want >>>> to >>>>>>>> use -fshort-wchar for arm32. >>>>>>> >>>>>>> We don't use wchar_t outside of EFI code afaict. Hence to all other >>>> code >>>>>>> it should be benign whether -fshort-wchar is in use. So the >> suggestion >>>>>>> to use the flag unilaterally on Arm32 is really just to silence the >> ld >>>>>>> warning; >>>>>> >>>>>> Ok. This is odd. Why would ld warn on arm32 but not other arch? >>>>> >>>>> Arm32 embeds ABI information in a note section in each object file. >>>> >>>> Or a note-like one (just to avoid possible confusion); I think it's >>>> ".ARM.attributes". >>>> >>>> Jan >>>> >>>>> The mismatch of the wchar_t part of this information is what causes >>>>> ld to emit the warning. >>>>> >>>>>>> off the top of my head I can't see anything wrong with using >>>>>>> the option also for Arm64 or even globally. Yet otoh we typically >> try >>>> to >>>>>>> not make changes for environments where they aren't really needed. >>>>>> >>>>>> I agree. If we need a workaround, then my preference would be to not >>>>>> build stub.c with -fshort-wchar. >>>>> >>>>> This would need to be an Arm-special then, as on x86 it needs to be >>>> built >>>>> this way. >>> >>> I have taken a look into this warning: >>> This is because the "-fshort-wchar" flag causes GCC to generate >>> code that is not binary compatible with code generated without >>> that flag. Why this warning hasn't been triggered in Arm64 is >>> because we don't use any wchar in Arm64 codes. >> >> I don't think that's quite right - you actually say below that we >> do use it there when interacting with UEFI. There's no warning >> there solely because the information isn't embedded in the object >> files there, from all I can tell. >> > > Maybe I should describe it this way: Arm64 does not use wchar type > directly in any code for parameters, variables and return values. > So Arm64 object files are exactly the same with "-fshort-wchar" and > without "-fshort-wchar". > > Although Xen's EFI code interacts with UEFI firmware, similar to RPC > function calls, these code also do not explicitly use wchar. How does it not? There are ample string literals as well as enough uses of CHAR16 (the UEFI "abstraction" of wchar_t). Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:56:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358868.588261 (Exim 4.92) (envelope-from ) id 1o79do-00054v-5u; Fri, 01 Jul 2022 05:56:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358868.588261; Fri, 01 Jul 2022 05:56:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79do-00054o-3F; Fri, 01 Jul 2022 05:56:32 +0000 Received: by outflank-mailman (input) for mailman id 358868; Fri, 01 Jul 2022 05:56:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79dm-00054g-Qd for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:56:30 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d2ce774-f902-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 07:56:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 468EC21C26; Fri, 1 Jul 2022 05:56:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1A2CF13A20; Fri, 1 Jul 2022 05:56:29 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UtDxBI2MvmJEDAAAMHmgww (envelope-from ); Fri, 01 Jul 2022 05:56:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d2ce774-f902-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656654989; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qGY+fb4jHEgpNQOrTyUGd4p4le7j0ClKGpEy809VyLI=; b=UrcglVgtxl9CKCufg5DLg0hHRQxzUJ7hTOf3jc4y0lT1wFLyNK+B8yOY3e7KeByaqnlxVq DuatSpsjkyd5j3vlb31799JeH3A50ZozKZqd/dpEwnooMY6pCmKPxWS7Ko1F3Sn0089tZB mvTioCvFFarcP3Xg8ylYRKwCPFJh+oA= Message-ID: <1c3bfe41-b86d-660c-6ccf-17777d1a5801@suse.com> Date: Fri, 1 Jul 2022 07:56:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages() Content-Language: en-US To: Demi Marie Obenour , Greg KH , stable@vger.kernel.org, Xen developer discussion References: <20220627181006.1954-1-demi@invisiblethingslab.com> <5136812e-e296-4acb-cafd-f189c4013ed3@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------e8U5GsjWGwcFuQTgLqHD4612" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------e8U5GsjWGwcFuQTgLqHD4612 Content-Type: multipart/mixed; boundary="------------aQbktJ2tEprMjgd7033LRGfL"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Greg KH , stable@vger.kernel.org, Xen developer discussion Message-ID: <1c3bfe41-b86d-660c-6ccf-17777d1a5801@suse.com> Subject: Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages() References: <20220627181006.1954-1-demi@invisiblethingslab.com> <5136812e-e296-4acb-cafd-f189c4013ed3@suse.com> In-Reply-To: --------------aQbktJ2tEprMjgd7033LRGfL Content-Type: multipart/mixed; boundary="------------kcDGp3wXm6PeKrV2bwHWB0nV" --------------kcDGp3wXm6PeKrV2bwHWB0nV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMzAuMDYuMjIgMTg6NTQsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gT24gVGh1 LCBKdW4gMzAsIDIwMjIgYXQgMDM6MTY6NDFQTSArMDIwMCwgSnVlcmdlbiBHcm9zcyB3cm90 ZToNCj4+IE9uIDMwLjA2LjIyIDEzOjM0LCBHcmVnIEtIIHdyb3RlOg0KPj4+IE9uIE1vbiwg SnVuIDI3LCAyMDIyIGF0IDAyOjEwOjAyUE0gLTA0MDAsIERlbWkgTWFyaWUgT2Jlbm91ciB3 cm90ZToNCj4+Pj4gY29tbWl0IGRiZTk3Y2ZmN2RkOWYwZjc1YzUyNGFmZGQ1NWFkNDZiZTNk MTUyOTUgdXBzdHJlYW0NCj4+Pj4NCj4+Pj4gdW5tYXBfZ3JhbnRfcGFnZXMoKSBjdXJyZW50 bHkgd2FpdHMgZm9yIHRoZSBwYWdlcyB0byBubyBsb25nZXIgYmUgdXNlZC4NCj4+Pj4gSW4g aHR0cHM6Ly9naXRodWIuY29tL1F1YmVzT1MvcXViZXMtaXNzdWVzL2lzc3Vlcy83NDgxLCB0 aGlzIGxlYWQgdG8gYQ0KPj4+PiBkZWFkbG9jayBhZ2FpbnN0IGk5MTU6IGk5MTUgd2FzIHdh aXRpbmcgZm9yIGdudGRldidzIE1NVSBub3RpZmllciB0bw0KPj4+PiBmaW5pc2gsIHdoaWxl IGdudGRldiB3YXMgd2FpdGluZyBmb3IgaTkxNSB0byBmcmVlIGl0cyBwYWdlcy4gIEkgYWxz bw0KPj4+PiBiZWxpZXZlIHRoaXMgaXMgcmVzcG9uc2libGUgZm9yIHZhcmlvdXMgZGVhZGxv Y2tzIEkgaGF2ZSBleHBlcmllbmNlZCBpbg0KPj4+PiB0aGUgcGFzdC4NCj4+Pj4NCj4+Pj4g QXZvaWQgdGhlc2UgcHJvYmxlbXMgYnkgbWFraW5nIHVubWFwX2dyYW50X3BhZ2VzIGFzeW5j LiAgVGhpcyByZXF1aXJlcw0KPj4+PiBtYWtpbmcgaXQgcmV0dXJuIHZvaWQsIGFzIGFueSBl cnJvcnMgd2lsbCBub3QgYmUgYXZhaWxhYmxlIHdoZW4gdGhlDQo+Pj4+IGZ1bmN0aW9uIHJl dHVybnMuICBGb3J0dW5hdGVseSwgdGhlIG9ubHkgdXNlIG9mIHRoZSByZXR1cm4gdmFsdWUg aXMgYQ0KPj4+PiBXQVJOX09OKCksIHdoaWNoIGNhbiBiZSByZXBsYWNlZCBieSBhIFdBUk5f T04gd2hlbiB0aGUgZXJyb3IgaXMNCj4+Pj4gZGV0ZWN0ZWQuICBBZGRpdGlvbmFsbHksIGEg ZmFpbGVkIGNhbGwgd2lsbCBub3QgcHJldmVudCBmdXJ0aGVyIGNhbGxzDQo+Pj4+IGZyb20g YmVpbmcgbWFkZSwgYnV0IHRoaXMgaXMgaGFybWxlc3MuDQo+Pj4+DQo+Pj4+IEJlY2F1c2Ug dW5tYXBfZ3JhbnRfcGFnZXMgaXMgbm93IGFzeW5jLCB0aGUgZ3JhbnQgaGFuZGxlIHdpbGwg YmUgc2VudCB0bw0KPj4+PiBJTlZBTElEX0dSQU5UX0hBTkRMRSB0b28gbGF0ZSB0byBwcmV2 ZW50IG11bHRpcGxlIHVubWFwcyBvZiB0aGUgc2FtZQ0KPj4+PiBoYW5kbGUuICBJbnN0ZWFk LCBhIHNlcGFyYXRlIGJvb2wgYXJyYXkgaXMgYWxsb2NhdGVkIGZvciB0aGlzIHB1cnBvc2Uu DQo+Pj4+IFRoaXMgd2FzdGVzIG1lbW9yeSwgYnV0IHN0dWZmaW5nIHRoaXMgaW5mb3JtYXRp b24gaW4gcGFkZGluZyBieXRlcyBpcw0KPj4+PiB0b28gZnJhZ2lsZS4gIEZ1cnRoZXJtb3Jl LCBpdCBpcyBuZWNlc3NhcnkgdG8gZ3JhYiBhIHJlZmVyZW5jZSB0byB0aGUNCj4+Pj4gbWFw IGJlZm9yZSBtYWtpbmcgdGhlIGFzeW5jaHJvbm91cyBjYWxsLCBhbmQgcmVsZWFzZSB0aGUg cmVmZXJlbmNlIHdoZW4NCj4+Pj4gdGhlIGNhbGwgcmV0dXJucy4NCj4+Pj4NCj4+Pj4gSXQg aXMgYWxzbyBuZWNlc3NhcnkgdG8gZ3VhcmQgYWdhaW5zdCByZWVudHJhbmN5IGluIGdudGRl dl9tYXBfcHV0KCksDQo+Pj4+IGFuZCB0byBoYW5kbGUgdGhlIGNhc2Ugd2hlcmUgdXNlcnNw YWNlIHRyaWVzIHRvIG1hcCBhIG1hcHBpbmcgd2hvc2UNCj4+Pj4gY29udGVudHMgaGF2ZSBu b3QgYWxsIGJlZW4gZnJlZWQgeWV0Lg0KPj4+Pg0KPj4+PiBGaXhlczogNzQ1MjgyMjU2Yzc1 ICgieGVuL2dudGRldjogc2FmZWx5IHVubWFwIGdyYW50cyBpbiBjYXNlIHRoZXkgYXJlIHN0 aWxsIGluIHVzZSIpDQo+Pj4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+Pj4+IFNp Z25lZC1vZmYtYnk6IERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3Ns YWIuY29tPg0KPj4+PiBSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPg0KPj4+PiBMaW5rOiBodHRwczovL2xvcmUua2VybmVsLm9yZy9yLzIwMjIwNjIyMDIy NzI2LjI1MzgtMS1kZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20NCj4+Pj4gU2lnbmVkLW9m Zi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+PiAtLS0NCj4+Pj4g ICAgZHJpdmVycy94ZW4vZ250ZGV2LWNvbW1vbi5oIHwgICA3ICsrDQo+Pj4+ICAgIGRyaXZl cnMveGVuL2dudGRldi5jICAgICAgICB8IDE0MiArKysrKysrKysrKysrKysrKysrKysrKysr LS0tLS0tLS0tLS0NCj4+Pj4gICAgMiBmaWxlcyBjaGFuZ2VkLCAxMDYgaW5zZXJ0aW9ucygr KSwgNDMgZGVsZXRpb25zKC0pDQo+Pj4NCj4+PiBBbGwgbm93IHF1ZXVlZCB1cCwgdGhhbmtz Lg0KPj4NCj4+IFNvcnJ5LCBidXQgSSB0aGluayBhdCBsZWFzdCB0aGUgdmVyc2lvbiBmb3Ig NS4xMCBpcyBmaXNoeSwgYXMgaXQgcmVtb3Zlcw0KPj4gdGhlIHRlc3RzIGZvciBzdWNjZXNz ZnVsIGFsbG9jYXRpb25zIG9mIGFkZC0+bWFwX29wcyBhbmQgYWRkLT51bm1hcF9vcHMuDQo+ IA0KPiBUaGF0IGlzIGRlZmluaXRlbHkgYSBidWc7IEkgd2lsbCBzZW5kIGFub3RoZXIgdmVy c2lvbiAod2l0aG91dCB5b3VyDQo+IFJldmlld2VkLWJ5KS4NCj4gDQo+PiBJIG5lZWQgdG8g ZG8gYSB0aG9yb3VnaCByZXZpZXcgb2YgdGhlIHBhdGNoZXMgKHRoZSAiUmV2aWV3ZWQtYnk6 IiB0YWcgaW4NCj4+IHRoZSBwYXRjaGVzIGlzIHRoZSBvbmUgZm9yIHRoZSB1cHN0cmVhbSBw YXRjaCkuDQo+IA0KPiBZZWFoLCB0aGF0IHdhcyBteSBmYXVsdCwgc29ycnkuDQo+IA0KPj4g R3JlZywgY2FuIHlvdSBwbGVhc2Ugd2FpdCBmb3IgbXkgZXhwbGljaXQgIm9rYXkiIGZvciB0 aGUgYmFja3BvcnRzPw0KPiANCj4gQ29uZmlybWluZyB0aGF0IHRoZXNlIHBhdGNoZXMgZG8g bmVlZCByZXZpZXcgYmVmb3JlIHRoZXkgY2FuIGJlIGFwcGxpZWQuDQo+IEp1ZXJnZW4sIHdv dWxkIHlvdSBtaW5kIG1ha2luZyBzdXJlIHRoYXQgdGhlIHVwc3RyZWFtIHBhdGNoIHdhcyBh bHNvDQo+IGNvcnJlY3QgZm9yIDUuMTUgYW5kIDUuMTg/ICBJdCBhcHBsaWVkIGNsZWFubHks IGJ1dCB0aGF0IGlzIG5vIGd1YXJhbnRlZQ0KPiBvZiBjb3JyZWN0bmVzcy4NCg0KVGhvc2Ug dHdvIGFyZSBmaW5lLg0KDQoNCkp1ZXJnZW4NCg== --------------kcDGp3wXm6PeKrV2bwHWB0nV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------kcDGp3wXm6PeKrV2bwHWB0nV-- --------------aQbktJ2tEprMjgd7033LRGfL-- --------------e8U5GsjWGwcFuQTgLqHD4612 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmK+jIwFAwAAAAAACgkQsN6d1ii/Ey/y 9AgAmLODtE5pc6JWFdsb5L9GPw2SUn5SZlRNTZqIFQRK5NYgAQaCwyIJ0gZANW4D2MYj/YE30Q7M u/U6f6PqJIZdxe8UevPpI5tsZOJ1EkQINEI1VMpt7d0nSSdkBM6+7nOKFfphs5+sy/tAOh6HBYHn eIWzq5M/2bXdc4I4HTDOLsUgoj8gG61m3kiS1w1fW8mOQKtE8A4oL5inIbFECLweSO8KNO516tWz 1VjywIm+qMEPHUz9LXAptdDX8tWGe0j3XX+yNfkpBUl0moKyXoAuF3i3lK0ymzsfllLgmEtDG7hL jFUUICYmQjf9cBaPryER3Nx84xR+YpqED8WzYlTl1Q== =YfaH -----END PGP SIGNATURE----- --------------e8U5GsjWGwcFuQTgLqHD4612-- From xen-devel-bounces@lists.xenproject.org Fri Jul 01 05:57:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 05:57:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358873.588273 (Exim 4.92) (envelope-from ) id 1o79eM-0005c4-G4; Fri, 01 Jul 2022 05:57:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358873.588273; Fri, 01 Jul 2022 05:57:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79eM-0005bx-DI; Fri, 01 Jul 2022 05:57:06 +0000 Received: by outflank-mailman (input) for mailman id 358873; Fri, 01 Jul 2022 05:57:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79eK-00054g-Pm for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 05:57:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60079.outbound.protection.outlook.com [40.107.6.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a15425f9-f902-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 07:57:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5725.eurprd04.prod.outlook.com (2603:10a6:803:e3::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 05:57:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 05:57:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a15425f9-f902-11ec-bdce-3d151da133c5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UT70/g+7z5qoQZvu+iWZn2LAHQeUh8X6Vz2tMQpSwQx97oH/UN0R9b/gR0OpM2dtLUjh4MfgXpiWBhgI7QEwyJk85jTxGSBNP12Hi5xDfnZcXEOy2NcDE8UY6rLXafqhHnqLpL4ZANt6mfyKcsn28lgtxAo4V+PRCBS9KeZ9BHilYdOuQTcYSRxbprH9/MZOqW+nhKWzCIk5K6j2Hf5blkNmf/VU263sOTMsQC7P75dYLfzLsGVWMycodUI2zmHMG4HKoZDoK/Y8nPK6jCCiRLN5SZ0UwGDFkghM+lyH70ILBRiZD+1LPDePCCKLs11zn4LyeBmtKoZ6CXOsDkI5mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o0vK/qRqt325EZ3GylagHyiXxlo7b/3gIWQjsC/HXt8=; b=aIzLCPt8pfnu55wgpLVkDBh1WkbGclW4+ftLuL44Zxo9b9TS3w+tzdtiaqW8TIo09iZQUYBtGPJxE7JfQsCO9dV7TRC191Hzo9Z5euICx98PNMYFF58wy2SLlqJaPxRFh4O++NX8XK3ONXyKwkLGJQyGVrXQJKcx/AtGDpHB7ufIsP9LULkNl4J0LIWZTZb86AjiskS7nNr11+FgprpnWXDXXCky6+EfIj8sz8i5BaYE+CdyLF9QHS6PGqK6jXJkdYAVjwg8rjjJHJ17bsJqbp1vjhHSdhgr3lryCgCqYBpyZ7G7xlC/EVf1bzOKWh2myaslFPjj/eiXhXUE44rUpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o0vK/qRqt325EZ3GylagHyiXxlo7b/3gIWQjsC/HXt8=; b=3vu9o1TCUrBwtrSELGRG6hS0HIZikFCbqZytcJg1jGkPFOlFZ8YcCFGPgsjPdzsh217MSf6p3G9Ic6weOkbwm2Ct7LxpLIV6c6z2FseO2fm7jVcMZjbxzWhMPFCSl4lFxtfgFqdJv68K4ecgdQvEq9k/klrsmmVUkTguuNX7ZkJVX8Rr6gToKfSwBSQGN3I52AmYkPeq5aSdqCj3T9O1z4F5HShKOJmmZviAn0jqOXA5cXmdrUPowOjQ+nvd0MOEawygB9rKn7GkeitVMZihe0zb0+/DY5iqTRYbAKGoCeyYgaAl7PX5lgfFYcWZ59/Y6+XtlUxRzqXU0Fqu1wErog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6558cefb-8541-0411-871c-939d6a4e223c@suse.com> Date: Fri, 1 Jul 2022 07:57:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US From: Jan Beulich To: Wei Chen Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Julien Grall References: <20220610055316.2197571-1-wei.chen@arm.com> <20220610055316.2197571-2-wei.chen@arm.com> <05dadcda-505d-d46a-776a-bb29b8915815@suse.com> <8e44e765-c47f-4480-ee44-704ea13a170d@xen.org> <6e91d7d0-78d2-2eec-3b14-9aea00b2a028@suse.com> <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> In-Reply-To: <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60c4aa78-f9a6-458f-5b47-08da5b2684c2 X-MS-TrafficTypeDiagnostic: VI1PR04MB5725:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hcSf2eOajcDbU8XARu0Z+0pWTvnGXaPCe9i1N+5DinMkBdTQHpV3tykU4yZqcm8AINNNsXTY7XUjIx41rexyIXyUPXf4EDrrj7El9rYof2LYpYOn7R5ljIuoaCBKs4trVnuAbaZO2jYU0X1WqDNeRRiKjHKf0LindiD+BDgOyrBluDSzsfiJwShGphBKgMQtijeghLlqIOP68Qm0J1LP1e4Ft+NN434qvtFOrv+gf/8aPaJuscq3xiqWL33p+nlfQICOT/eKebcEg6yeRdIusA59dhqSe0a4aZENhElUFt39oSXRMQqahdMsYbL4x1V/P20DUM08TGWqvOp7ghLbU3AaafjFq+kOHClovvzLVpb3ekyPppMpOcRNaBpjQJlIt6m2Dlki0Rqjdh8gsuP+V030YsOoRnOpFx9K7G/5seIrWw4Uv50XDYlNRvJCrVeKVNt3bqfhABzaCdiiwBYoiHMdEuy66FWhhKlG6erb3o7MMHQMommcgTwxE3eH2li1H2zCh2ajlTJQ0P1VSXLCQaIfUzmWntUtSNsKK9KQP0X25Zqm4xKFMUsSYHlZRKQ5mxP53hELG0+c+Cria4BDyB0bQ6ycPN7bSCqSyRC/lDpETuN6PCZ0hKRft0eWmyoEXQNoq3zACarbfH7JRiKyzpoi/LaweiOSd0jb4eJbwHdqwD4vCa2ZIWCAiY+B6RSpoViscS4bTPwiR79j/q81w48jE3RWM8aGTJKMudaiMAjWAwAh1qFoyYskb9mlHlBQp6NNxVatGH7YtpmuMrd/iX+hHcyKNzm6r5RlEFkilVscucueeQdeBSAgqs1xrAigN14XjjfwcDtycneRb1KT1NqwXfJdxKbxROrErpUUPxc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(346002)(39860400002)(396003)(136003)(31696002)(86362001)(6506007)(38100700002)(316002)(66946007)(4326008)(8676002)(66556008)(66476007)(54906003)(2906002)(6862004)(8936002)(5660300002)(26005)(7416002)(186003)(2616005)(83380400001)(478600001)(6512007)(6486002)(53546011)(31686004)(41300700001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T09Hb0FhYTc4VzNaOGhYUEx6azlVYXNST000YWZTc295K2ppUGpoSjFsVW14?= =?utf-8?B?NUFJdTczMktaMDE5Q3hBeTBZWkd3WW41Y2tkU0x2Zmh5VHB5ekpJZVN6Y0U3?= =?utf-8?B?Q3BQdjVxRVhkL1JDejRLKzZZdlQ0ZGlEVWEwQXVUbVNUdEgzZEVCalltQlI4?= =?utf-8?B?b3BWUm5YQXYvWUQ4KzRRSTlyb3FJaDB6YjlBNDZQU1NuRHBxZGVHZXZ1d3Bj?= =?utf-8?B?aXhVWU9iMGw2U3o4NGU5enVJQ1lITis4cE9FWDhDVU5qSzNUR1R1NHdpMkJH?= =?utf-8?B?RlVjamdmUkZTTjV2ZFFoZU9wVEhoY1ZJRXRoUDlWSlpIRHhtcUlTZ0dPSS8y?= =?utf-8?B?bzREUE9YZWsxTGp1Mm1lUTIzc29yc0pSZTlOYjJvRmt3S1JyMEhyL3pyYy9L?= =?utf-8?B?d056cCtHYThGMmNSVXdnUVFhaythcGYrc2g3NExveEUwckR4eTdUNXZFaEJt?= =?utf-8?B?TTZPTlcvM1FLUXArQWxSLy9nbHBlamVxOG1FSTJkcEJrNVhPV2t4UkE1Z1Fi?= =?utf-8?B?bkR5WFNBTElmN3RRK1BDNERVQ1hveXI3alc3M1Vja3hQS2krMm56NTdWNnBh?= =?utf-8?B?d3JxaXNYY1kzbms3djQrSDZwRmEyREpiV2Jsc01mRzF3cnBSTEpnK1JIYzFx?= =?utf-8?B?ZnFlSks3b1V2bjhCS0NGK0hLN0VDN2tiYjhCbW94T0IrVnBYTzdmTmZDL0hW?= =?utf-8?B?NkxFL2NHYnhVRWE0UG45VkxtY2lQeFVSNU1uZk4wT29BY21OVTZFRVpiU0pn?= =?utf-8?B?OWdsOHY2cFM3ZmJpTVhZSjI1bnFLTEQ2N2R5ZFZXRzdmQjlTMldEc3h3MktR?= =?utf-8?B?ejNIWEpnTHRCOXlLOXQ4K0drbEFzVy83ZGRRMDNGSUdWRytKQk5aN2NCTjNw?= =?utf-8?B?OWVwMnlQcytLdUZqcDBSR00rZ2pVNzZRT1Z4RHE5Zk90UGgyQlhNSEp5R1FJ?= =?utf-8?B?dUF3cnhzUEhaWWZxaEFCMW4zUllzVGQ5K1VpN0VlWWlCWHBFZHZVaTYxcFZL?= =?utf-8?B?TEw4REVJbW9TU3pBMTViVnEzVGtCbndXQi9HMHl4enhRcytDKzF0cW9IQ3NI?= =?utf-8?B?U0ZpTkdZVHZRYmxjZHFBaU9MOUdqbnBodXk4NVM5Wml0T3ZGQ3F3QXYrb0hI?= =?utf-8?B?c0YrMG5vMWMwakFlRTVtTWpJTzBIR2dMRmZmb2YyeXp6bVY3QkVnYi9MYjhH?= =?utf-8?B?dGNrRm1aMDg1a1IwbktRbmkyQXo0b0ZqT0Q1SEVVQWZYcjUreFpXZ3hRUmVE?= =?utf-8?B?SzdDL0o4NW14N05DeWRGVUNDeEthb0NKeENGZjFNQTNaUTF1S0YxQVpMTWVO?= =?utf-8?B?SkRHZmJHRURzMkxFditVZ3FKQ1VJK3pLc21JOUZuUGFWQ1VLRmFwdFdpcmdv?= =?utf-8?B?cVRkNEg5MVNMb0JQeWM5TmV0VXlUY0gzUSt4NE1sM1NFUzZOMEphalEyLzAz?= =?utf-8?B?enByWS83bnE2VjdXWEdLdXVObXA3a0VPMVlIS1V6VElWM3RhMFpIZjdpTVox?= =?utf-8?B?akdrODdINHVIbWd0cVhuZjFOOXE4aVcvNXRJaCtGc1hJdnJCb2drVTNXSzV2?= =?utf-8?B?amVOMHRHTzM1bG1xWVE5S1ZYTExvTGUwOWk5QTQzYXRGbG1nVzdXRjlnb0dj?= =?utf-8?B?R2hqZlUwMzNYb3ZqcEhST1k1TmxHSnVodGhybUNRWFkxczdHR3EwK1JFc3Zr?= =?utf-8?B?cUg5UGZwU3RpT0dwa3B0a1dCbENFbUlBNXFQd2t0cnh2cUd6VmZRYVR5bmc0?= =?utf-8?B?VzBJKzhrVmtWYlEvRlJnQlJiWkdvZ2U0RE9BaFo1cHFRZS9aZFQrLzQvS2NW?= =?utf-8?B?NFZOQ0w5a3FUZFg0MmVIcTdoMGJjaHlhNmx4Z1I5dUhxL2d1ZzZvZXhZbGJJ?= =?utf-8?B?V3VPSE9rSXRkWWtORVhSUHhud1JPVzB2blRERkxlTFJnRit2Z25oL053ejJT?= =?utf-8?B?dlAyVXd1MERpRWpBL1M4K1VWWFBreElaSTM3ZnNjNVVuTkpPTzEvTVVWdFFP?= =?utf-8?B?b3poNDVDaWZmWUhYcnhaQytmUDRQbis2clRSd1hMeWJNUHVFeVVUWlA0clRC?= =?utf-8?B?aWsrMkdpc25CQzdHd00rMnRjVnh3OVlQMWRHTmFMb0dJV0ZXNzhTNTRNd3J4?= =?utf-8?Q?WqTmYJOCgnrCJS91vUIkGsgjG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60c4aa78-f9a6-458f-5b47-08da5b2684c2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 05:57:02.1811 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D9uYYN/AZ1g9+o2OuAsHtbi6oEGb9Dln0nXj1/FOhGZ3pdw3zdlt7pHuBDzICBwhTXHY8PRwCdtairtT0YoSEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5725 On 30.06.2022 14:36, Jan Beulich wrote: > On 30.06.2022 13:25, Wei Chen wrote: >>> From: Jan Beulich >>> Sent: 2022年6月24日 18:09 >>> >>> On 24.06.2022 12:05, Jan Beulich wrote: >>>> On 24.06.2022 11:49, Julien Grall wrote: >>>>>>>>>> --- a/xen/arch/arm/efi/Makefile >>>>>>>>>> +++ b/xen/arch/arm/efi/Makefile >>>>>>>>>> @@ -1,4 +1,12 @@ >>>>>>>>>> include $(srctree)/common/efi/efi-common.mk >>>>>>>>>> >>>>>>>>>> +ifeq ($(CONFIG_ARM_EFI),y) >>>>>>>>>> obj-y += $(EFIOBJ-y) >>>>>>>>>> obj-$(CONFIG_ACPI) += efi-dom0.init.o >>>>>>>>>> +else >>>>>>>>>> +# Add stub.o to EFIOBJ-y to re-use the clean-files in >>>>>>>>>> +# efi-common.mk. Otherwise the link of stub.c in arm/efi >>>>>>>>>> +# will not be cleaned in "make clean". >>>>>>>>>> +EFIOBJ-y += stub.o >>>>>>>>>> +obj-y += stub.o >>>>>>>>>> +endif >>>>>>>>> >>>>>>>>> This has caused >>>>>>>>> >>>>>>>>> ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the >>> output is >>>>>>>>> to use 4-byte wchar_t; use of wchar_t values across objects may >>> fail >>>>>>>>> >>>>>>>>> for the 32-bit Arm build that I keep doing every once in a while, >>> with >>>>>>>>> (if it matters) GNU ld 2.38. I guess you will want to consider >>> building >>>>>>>>> all of Xen with -fshort-wchar, or to avoid building stub.c with >>> that >>>>>>>>> option. >>>>>>>>> >>>>>>>> >>>>>>>> Thanks for pointing this out. I will try to use -fshort-wchar for >>> Arm32, >>>>>>>> if Arm maintainers agree. >>>>>>> >>>>>>> Looking at the code we don't seem to build Xen arm64 with -fshort- >>> wchar >>>>>>> (aside the EFI files). So it is not entirely clear why we would want >>> to >>>>>>> use -fshort-wchar for arm32. >>>>>> >>>>>> We don't use wchar_t outside of EFI code afaict. Hence to all other >>> code >>>>>> it should be benign whether -fshort-wchar is in use. So the suggestion >>>>>> to use the flag unilaterally on Arm32 is really just to silence the ld >>>>>> warning; >>>>> >>>>> Ok. This is odd. Why would ld warn on arm32 but not other arch? >>>> >>>> Arm32 embeds ABI information in a note section in each object file. >>> >>> Or a note-like one (just to avoid possible confusion); I think it's >>> ".ARM.attributes". >>> >>> Jan >>> >>>> The mismatch of the wchar_t part of this information is what causes >>>> ld to emit the warning. >>>> >>>>>> off the top of my head I can't see anything wrong with using >>>>>> the option also for Arm64 or even globally. Yet otoh we typically try >>> to >>>>>> not make changes for environments where they aren't really needed. >>>>> >>>>> I agree. If we need a workaround, then my preference would be to not >>>>> build stub.c with -fshort-wchar. >>>> >>>> This would need to be an Arm-special then, as on x86 it needs to be >>> built >>>> this way. >> >> I have taken a look into this warning: >> This is because the "-fshort-wchar" flag causes GCC to generate >> code that is not binary compatible with code generated without >> that flag. Why this warning hasn't been triggered in Arm64 is >> because we don't use any wchar in Arm64 codes. > > I don't think that's quite right - you actually say below that we > do use it there when interacting with UEFI. There's no warning > there solely because the information isn't embedded in the object > files there, from all I can tell. > >> We are also not >> using wchar in Arm32 codes, but Arm32 will embed ABI information >> in ".ARM.attributes" section. This section stores some object >> file attributes, like ABI version, CPU arch and etc. And wchar >> size is described in this section by "Tag_ABI_PCS_wchar_t" too. >> Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", >> but for object files without "-fshort-wchar" is 4. Arm32 GCC >> ld will check this tag, and throw above warning when it finds >> the object files have different Tag_ABI_PCS_wchar_t values. >> >> As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar >> to use short integers (2 bytes) instead of integers (4 bytes). >> We can't remove this option from x86 and Arm64, because they need >> to interact with EFI firmware. So I have to options: >> 1. Remove "-fshort-wchar" from efi-common.mk and add it back by >> x86 and arm64's EFI Makefile >> 2. Add "-no-wchar-size-warning" to Arm32's linker flags >> >> I personally prefer option#1, because Arm32 doesn't need to interact >> with EFI firmware, all it requires are some stub functions. And >> "-no-wchar-size-warning" may hide some warnings we should aware in >> future. > > I don't mind #1, but I think your subsequently proposed #3 would be > the first thing to try. There may be caveats, so if that doesn't work > out I'd suggest falling back to #1. Albeit ideally the flag setting > wouldn't be moved back (it _is_ a common EFI thing, after all), but > rather Arm32 arranging for its addition to be suppressed. Or make Arm32 use -fno-short-wchar (looking at gcc code this should be possible) to override (undo) the earlier option (possibly isolated to just stub.c). I'd prefer that over #3, really. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 01 06:02:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 06:02:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358882.588284 (Exim 4.92) (envelope-from ) id 1o79je-0007MD-3h; Fri, 01 Jul 2022 06:02:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358882.588284; Fri, 01 Jul 2022 06:02:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79je-0007M6-0L; Fri, 01 Jul 2022 06:02:34 +0000 Received: by outflank-mailman (input) for mailman id 358882; Fri, 01 Jul 2022 06:02:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79jc-0007M0-JW for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 06:02:32 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 641faf2b-f903-11ec-bdce-3d151da133c5; Fri, 01 Jul 2022 08:02:30 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D0C335C0144; Fri, 1 Jul 2022 02:02:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 01 Jul 2022 02:02:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 02:02:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 641faf2b-f903-11ec-bdce-3d151da133c5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656655349; x= 1656741749; bh=wYH+5idjnaYEDi0fQMCML0U5b5ym8CcDG6Nq6PKCwGg=; b=a ub/cYtRrhu/KE9H92XuMWeCHUn3gq5JAgpWIqwV0SlcV8lqluiEdt+0X7ElruGr+ EQlPkHv6YYtZ3Z4nUHTOzbRJqZtA/xPLoZ98diRlH0BASm7CjAmocmCClwFxRd4R /ZxVq5g2BRAgiAa4O21tMi5OowrtddnwSKmqnkhq/WTH1nQagFvAslZwNL7MdW+b DenjsLYpjWVxo7Q2JPB1abV+R5WsUIrQfQTffe0NQmLFHpr/iQxGLxkpihPSDWP3 p+2oYR7PFtYgwjKnEPoIFMjXYj15Ozkej0JkKNF3DJkMBv1bKPrA9/l+VRXcj33i PMliC6DYaCEpz/nEM+j4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656655349; x=1656741749; bh=wYH+5idjnaYEDi0fQMCML0U5b5ym 8CcDG6Nq6PKCwGg=; b=voxQ6KijTNSqKElS77lVhi2EzhwTGMm5wUQB/aebD0cb S0LYqPdhN6fW8C/AhJsvaF4n6iP8tReMtCF4s3pVFF0oRW2U2WTcV0fmmajrgKhL MW/qIM0okoQ24NP2/TsbWb3va9LSiCjmwsPHEa6Xzmel9AjZvCbJGH7dbY4JXAj2 OW75b/CPAlQUJ1tPrgPz7SqR7FpjA1idKlrcYlF0K1RTgrq75NFWCuETf9C7Q/6D 0vysx//asA57G8xbdwbm4ebPji49T3uwwGoj1eGyJTZzSueNkMZenJ//JnlOlbjB CoP1eOp2e65QVCY7JcKfqi6VaqqByTBd7BKLXv7i8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehvddguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdeigeehudegjeelteehveehveef ieehiefhfefgtdduhfdtjedtkeevffefteffnecuffhomhgrihhnpehgihhthhhusgdrtg homhdpkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtg homh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Fri, 1 Jul 2022 02:02:26 -0400 From: Demi Marie Obenour To: Juergen Gross , Greg KH , stable@vger.kernel.org, Xen developer discussion Subject: Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages() Message-ID: Mail-Followup-To: Demi Marie Obenour , Juergen Gross , Greg KH , stable@vger.kernel.org, Xen developer discussion References: <20220627181006.1954-1-demi@invisiblethingslab.com> <5136812e-e296-4acb-cafd-f189c4013ed3@suse.com> <1c3bfe41-b86d-660c-6ccf-17777d1a5801@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Niq2cF0LcwVvL5C2" Content-Disposition: inline In-Reply-To: <1c3bfe41-b86d-660c-6ccf-17777d1a5801@suse.com> --Niq2cF0LcwVvL5C2 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 1 Jul 2022 02:02:26 -0400 From: Demi Marie Obenour To: Juergen Gross , Greg KH , stable@vger.kernel.org, Xen developer discussion Subject: Re: [PATCH 5.10] xen/gntdev: Avoid blocking in unmap_grant_pages() On Fri, Jul 01, 2022 at 07:56:28AM +0200, Juergen Gross wrote: > On 30.06.22 18:54, Demi Marie Obenour wrote: > > On Thu, Jun 30, 2022 at 03:16:41PM +0200, Juergen Gross wrote: > > > On 30.06.22 13:34, Greg KH wrote: > > > > On Mon, Jun 27, 2022 at 02:10:02PM -0400, Demi Marie Obenour wrote: > > > > > commit dbe97cff7dd9f0f75c524afdd55ad46be3d15295 upstream > > > > >=20 > > > > > unmap_grant_pages() currently waits for the pages to no longer be= used. > > > > > In https://github.com/QubesOS/qubes-issues/issues/7481, this lead= to a > > > > > deadlock against i915: i915 was waiting for gntdev's MMU notifier= to > > > > > finish, while gntdev was waiting for i915 to free its pages. I a= lso > > > > > believe this is responsible for various deadlocks I have experien= ced in > > > > > the past. > > > > >=20 > > > > > Avoid these problems by making unmap_grant_pages async. This req= uires > > > > > making it return void, as any errors will not be available when t= he > > > > > function returns. Fortunately, the only use of the return value = is a > > > > > WARN_ON(), which can be replaced by a WARN_ON when the error is > > > > > detected. Additionally, a failed call will not prevent further c= alls > > > > > from being made, but this is harmless. > > > > >=20 > > > > > Because unmap_grant_pages is now async, the grant handle will be = sent to > > > > > INVALID_GRANT_HANDLE too late to prevent multiple unmaps of the s= ame > > > > > handle. Instead, a separate bool array is allocated for this pur= pose. > > > > > This wastes memory, but stuffing this information in padding byte= s is > > > > > too fragile. Furthermore, it is necessary to grab a reference to= the > > > > > map before making the asynchronous call, and release the referenc= e when > > > > > the call returns. > > > > >=20 > > > > > It is also necessary to guard against reentrancy in gntdev_map_pu= t(), > > > > > and to handle the case where userspace tries to map a mapping who= se > > > > > contents have not all been freed yet. > > > > >=20 > > > > > Fixes: 745282256c75 ("xen/gntdev: safely unmap grants in case the= y are still in use") > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Demi Marie Obenour > > > > > Reviewed-by: Juergen Gross > > > > > Link: https://lore.kernel.org/r/20220622022726.2538-1-demi@invisi= blethingslab.com > > > > > Signed-off-by: Juergen Gross > > > > > --- > > > > > drivers/xen/gntdev-common.h | 7 ++ > > > > > drivers/xen/gntdev.c | 142 +++++++++++++++++++++++++---= -------- > > > > > 2 files changed, 106 insertions(+), 43 deletions(-) > > > >=20 > > > > All now queued up, thanks. > > >=20 > > > Sorry, but I think at least the version for 5.10 is fishy, as it remo= ves > > > the tests for successful allocations of add->map_ops and add->unmap_o= ps. > >=20 > > That is definitely a bug; I will send another version (without your > > Reviewed-by). > >=20 > > > I need to do a thorough review of the patches (the "Reviewed-by:" tag= in > > > the patches is the one for the upstream patch). > >=20 > > Yeah, that was my fault, sorry. > >=20 > > > Greg, can you please wait for my explicit "okay" for the backports? > >=20 > > Confirming that these patches do need review before they can be applied. > > Juergen, would you mind making sure that the upstream patch was also > > correct for 5.15 and 5.18? It applied cleanly, but that is no guarantee > > of correctness. >=20 > Those two are fine. Thanks! I re-sent the 5.10 patch; hopefully the others are good. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --Niq2cF0LcwVvL5C2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmK+jfMACgkQsoi1X/+c IsHbZg/+P9onGYM5Pr4XcVDzf96AxARCkyw3tShzc4Vu1UyfnwV7uvhQF6+3VJMF IXOBJK3ebOsMgh0/eVvoXLKhn68n5K47xIIJPrtdglOCAYolvrG0G5yMvi2wQOWg 1xt1ryu4GXR6z2Cwpt8St3vYgFq9hycztQ2vWXRwKDAdrOWac+BCrEwZQC9pRnRl fDYmSzXMXkOlQUrlZ4njowv0ZbcMybRI9IQZ6dDhcWfSycaHj9kh8grybuPMZnmt Q+BRpHbvi9gbpJFcDmsk8EsqHj4lUdLDjY/yve5ndIxVev3QLp2JwIL+tB2oXqgl YXkhEqHNHwwuHo/H5RTfT1ds7KzutJjE0vMR6eket824fLrIVXuIw09aighpY1Vg GFoB9B1RckmYmo1ZzmtWJusrkPBcbRkeWzydZYfXum71D3uxa1lkhxSUH+BzjiCp B6y5BkBad8ruRh7qZHgt17kto99oodQgCP2WHUFjupoe0nc8roJJ2dNAWz8UIZOd BW3vUFSf4tY5gY06vWlw7Ux8g8fWwInLlwF370LVDUMmIzNsLJAYk0RDTbMPdpNy KZj0hsI7S0A/YuSMd/0CCo2TZg/KRI0UM38Z4UPtCl2KcDdxSZSRdTqDQs0isRSe ZcmSlwQOIGs3i2tfS4vjpOV1B8zn6hjbdYcoMRv3MIFUyxBYvqI= =VEPi -----END PGP SIGNATURE----- --Niq2cF0LcwVvL5C2-- From xen-devel-bounces@lists.xenproject.org Fri Jul 01 06:10:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 06:10:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358891.588295 (Exim 4.92) (envelope-from ) id 1o79rc-0000c5-42; Fri, 01 Jul 2022 06:10:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358891.588295; Fri, 01 Jul 2022 06:10:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79rc-0000by-03; Fri, 01 Jul 2022 06:10:48 +0000 Received: by outflank-mailman (input) for mailman id 358891; Fri, 01 Jul 2022 06:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o79ra-0000bs-Rn for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 06:10:46 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b2d494e-f904-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 08:10:45 +0200 (CEST) Received: from DB6PR07CA0175.eurprd07.prod.outlook.com (2603:10a6:6:43::29) by VI1PR0801MB1853.eurprd08.prod.outlook.com (2603:10a6:800:5a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.17; Fri, 1 Jul 2022 06:10:27 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::8f) by DB6PR07CA0175.outlook.office365.com (2603:10a6:6:43::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.8 via Frontend Transport; Fri, 1 Jul 2022 06:10:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 06:10:27 +0000 Received: ("Tessian outbound ef501234d194:v121"); Fri, 01 Jul 2022 06:10:27 +0000 Received: from f132fe31f93a.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 684EE8A4-EC2D-4B3E-83CA-979C14EEE28B.1; Fri, 01 Jul 2022 06:10:17 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f132fe31f93a.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 06:10:17 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB3349.eurprd08.prod.outlook.com (2603:10a6:209:4a::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 1 Jul 2022 06:10:14 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%7]) with mapi id 15.20.5395.014; Fri, 1 Jul 2022 06:10:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b2d494e-f904-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TK7O2mobrj+ieHVxT/M7fb3k+6uAFzqqPDdK6sfsdmH4RClpZWC8qBRxt3ZDr14iGV5x1WVWU3JhMcHQf0QTqIz824hmzRAoCn+wWjvfswHtoy2RUvbH+dBKb/kmbU7Fl7lUjRpWq+oeOWsaJLqsov1civ0URJfXb72Z0Juz/MjkNbfET8N2uLfM7gIs5JH+Kqdv+VgQNqA0azCTeRVMl5F934hodIgqqvWNuiUyITBuahfptQjN84msip6LdhSCnx6wZ8Q2SjjgR4i76VbxvofXuKU4ZgDMX5zJz+c7Uh9eaY0iAj271rq5J16p1Roxr5fRxrbEUm7Shl4d+FvoLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e5nRAd7+++XQ0MMPf4+/0cM+3o9eeyLo7pDIFjAhY6A=; b=HRmFOi3cCMMBYZltu2D3NsRUSFgKlTSLoLbYwHyF6X56GQ1VXMHd0zyBuJYYztkw7wCi+XIwI5yUEc4T5x39zKhSPijjFwvfdJVwiajrhXmjl4rhEE9jC/zVUliVXJQPltPlUl4jg6JiHM8V8CAB3LpgydnGJfE7EP3q/lanGsuzg50AFF0EVdYuUnMmWZRr5E/uFi5kTAv0Wi4gYroE7ANXLVj1e/O3glD4mtgoqJA/lPfIONv5cDM9Y+flVDITcBEvP/HWSBHkvgi61mqyQGgAaGxvly5+LUCBs4N1NPE7Wvrt/ctH/Orwa7QqbEIqWDAQKSmukbTQjzNBvWH0CA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5nRAd7+++XQ0MMPf4+/0cM+3o9eeyLo7pDIFjAhY6A=; b=hh8jHLVx3RsQDNSxXvpY4GlDSZhbBc7ioL25kG0f2y2v3lPo/JGjYK1WSKZDjJoUeZu7y6qddL6gUN2SiYs+TgoP8g8UGPpImwbJ0Prg1qv+ksEotZtuRM9teL2r0Dy8On75BUs40qbF4PurWcxw1ESDviyg3eFtjBFJ6MSukHk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bwfj4c6s8VtM6FE4pHb70lLsSQhMcLz/olgbW+utqtMFbyZ1qLHXlwEZU2YIcEkbqbcPEuffdYqiRtluKmGqdExqW4WlKZhg+irb7XJBJOUp3wP3ok4nd7dzXgJb1lZexhC2kjH7QrFbBekz/C2bqeM9ZBR6Jw5OM0oqsIO0Pre/kqnFUTqYtQvfIm0YllTmVORoNiKHUIsKRpqLMbqRkmEnb60vRXEN6KmPKJsi1hS8URSI9biazgEc4xubWRxCrYzT8w74pGUYX7egrOaOJdnulWaKeKr7xt4r27eIGzjhy9ZE7Rq3uqkjoz0LIcWpWvAfvL1D0LNhV8bg0o5+4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e5nRAd7+++XQ0MMPf4+/0cM+3o9eeyLo7pDIFjAhY6A=; b=j4BKZ/vMQ55dlgx6/wa9dkhdx7g/Cv/jGyhumfuTfzyrHb0minwb8hX2Tvh64Ug7qGCJQ7l4swNgJSpAY8j8Gg02bo38eENMxew+Uq7nMqQ7rHTZPl9ujieV32Ekuj+Maq6hg/GfNTaiIOWkVmXevoF5vRcL3W2bNxf8xipwX1g/clL7udY9cd4PSRckSffOqD+UJ5SV3parCXUOBkZTlwY6EIadHez8Us3VVVG0HL//NjoZKCGfvAvl0/DzJ07+BBXVNMVZO97qj7gk+xIMPMdQoY9jFuTIOZ9Omh3+mcc86xwYG/1ARh1PBLM661DOGd/gmPs6iUdY5sIDWH9x5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e5nRAd7+++XQ0MMPf4+/0cM+3o9eeyLo7pDIFjAhY6A=; b=hh8jHLVx3RsQDNSxXvpY4GlDSZhbBc7ioL25kG0f2y2v3lPo/JGjYK1WSKZDjJoUeZu7y6qddL6gUN2SiYs+TgoP8g8UGPpImwbJ0Prg1qv+ksEotZtuRM9teL2r0Dy8On75BUs40qbF4PurWcxw1ESDviyg3eFtjBFJ6MSukHk= From: Wei Chen To: Jan Beulich CC: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Julien Grall Subject: RE: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Topic: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Thread-Index: AQHYfI531SRNO5A+8Ei3iOFoJrK02K1dB3iAgAE0OjCAABXrgIAAECwAgAAEoICAAARlgIAAAO0AgAmAA0CAABcRAIAA6+aAgAA2KgCAAALn8A== Date: Fri, 1 Jul 2022 06:10:14 +0000 Message-ID: References: <20220610055316.2197571-1-wei.chen@arm.com> <20220610055316.2197571-2-wei.chen@arm.com> <05dadcda-505d-d46a-776a-bb29b8915815@suse.com> <8e44e765-c47f-4480-ee44-704ea13a170d@xen.org> <6e91d7d0-78d2-2eec-3b14-9aea00b2a028@suse.com> <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> <13142c32-f67f-751d-4783-87e8afa1117a@suse.com> In-Reply-To: <13142c32-f67f-751d-4783-87e8afa1117a@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 50E2AD9797221E42934FECF8D7C9DD4C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9a92542d-bc68-4b67-8217-08da5b2864d6 x-ms-traffictypediagnostic: AM6PR08MB3349:EE_|DBAEUR03FT019:EE_|VI1PR0801MB1853:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: w75vq520h7vN6lDBTlTO++kWHwMaFznb9sFLUql4IpE+e4V2RfGs/lx2LTViSAcBgnp9wP074H6vwQ/cWDaf/3/mwPno/aN7Os9/27WXKo0VvWoyAw6FA+khIAwBsJsB68G/wsQOuJs21fopm4chilYj76N1GqaCpqmkeJd3LLv2rFcrOGgnldcaJgGP3rnIBX1KyMgrCIdkdidF9I804+mMPu6xrK7YJ/UYjwpTuf5xulCiuVwoLrY0TjsJa6qgs3o93Hy+L+KNwOuorAPwC/9pRkwbI9NoxhaLtxfk5nD8jzC/9LOftCVdQzl1ntlRaifqn3cTrG7KUTpwRWV2tcBaXAbyTJ9+cqj6mYhhRD1Ufp67gyAZE2Pj5s+4pnGQ28X91PFCQvlMUXei3Q/ALqjZgPzQ4sQqlw3HfCxOi2MoQFOmtxrTX42/iVYDAxJUp1XSgzvuqXFAUumr08mT1erZk55fM5ZD0m03iNtX1fKZJcfzJ6g4Fc7mbghdJEOwto8t3cw5seOq/UdPs/Amq6dApbu2+bMskLACCfqTsUH607aAgKEXl6e90aBUeb+vft7m1nzWupgcAwlaWttQA2W62c681SmF85jodpZzUANPsgFKLM2HZAjLffG2FQ1VK0M/HzsoYP9l0mTzL3EErZoWgLheqs+LiE3edHZ6rrXga+9NyOYovCwr0Hk9xs2ZfxE862VJt3kM/eAm9TyfFVsmwl6ABmnS257WRToFdX6ppgzQ8I+VrWgCB+ZPctEUeEM4SbSZc5lLqkV9XR0sIUWs1H1pqcV8UfW1Aiv+xuc03MQwnqIOKeDCyeo28Pee X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(8676002)(71200400001)(4326008)(26005)(9686003)(66946007)(64756008)(66476007)(33656002)(53546011)(41300700001)(86362001)(6506007)(66556008)(66446008)(478600001)(122000001)(55016003)(38070700005)(7696005)(38100700002)(83380400001)(186003)(316002)(5660300002)(6916009)(54906003)(8936002)(52536014)(2906002)(76116006);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3349 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e7a39b0e-52d6-4f88-802c-08da5b285d2c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GxbPVN1emK13EB4UgCgomyUP+Qm9bmAGhqBzOUFOSxqAPN1ATdqzJATr5bHNtdfNPz2tZZGOWwmbitn+v4T3l7fVS6898CmrbisHRZomfWgGha/eSgwxrcsjlZI14wsBUzNxrBMRZQhYtxLLmc11U/SJnzVqRmoJblh2jmppwtRCQpp0/7O6vD5lTSb8QRytpH/DFoxJp2abnRuiqyDaXS58+vcyMsCqPoMgyylTAmXjRf2p4J8vdEtQ7PvP7+JB/CvoNnBppBKKgDbOIKs6kO3TrxHmBS4gamwnQYNxuh+oVo7lIsYVifoYTJ56noqG4gT56OEqxBvmq++tLzXa5J/CKrTBKeT914o50d66Yq933s86VQWfYOYxGE0Vg0pODWHuICzKC3TDEPS0m6qdkOtFVUaREQHLeuc7qTzc1z8t9sY7meCJQ4BYwLTUe2U31+U2XtRX+Gv5naIZ9q8QrWc1U67rGJUUXz08BpzlrlYVJCAQOAA554jzL99GJ0G2Mb6cvOCFgOIQAW8OCJ/oDoKPFwip6u4i9Es6Z+nyf2HGjeFFCKX45kfleD28PeCZE6EjHpIJDZo3FpJ5/9jI5MXFRRxiM/efz+5ArDBMU/m/5ea+7nggLsxpRP31Q9BkI6C6zsQKrm97iuuuSaHE5P8jYLU1nPsZS5ChLy1RaYRSwAOOQzhi9IOIRzMy34JL+apXhY9oJpZb3bwaX0KrfPsSId1gIF+/eFsEPFnbT0SxSHhl+HLVdOPKplkDr9G773xjuJofz3M5fuHIOPfDRXPft6+ZY0bCL2pOuhrhd9ljHrgTUkvde9yqyaYxQdwm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(39860400002)(40470700004)(36840700001)(46966006)(83380400001)(40460700003)(55016003)(186003)(5660300002)(81166007)(478600001)(40480700001)(86362001)(47076005)(2906002)(41300700001)(336012)(33656002)(6862004)(8936002)(356005)(70206006)(53546011)(82740400003)(52536014)(70586007)(54906003)(82310400005)(36860700001)(7696005)(9686003)(26005)(4326008)(6506007)(316002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 06:10:27.4945 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9a92542d-bc68-4b67-8217-08da5b2864d6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1853 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgx5pelIDEzOjU0DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IG5kIDxuZEBhcm0uY29tPjsg U3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQNCj4g TWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsNCj4g PFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT47DQo+IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29t PjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEppYW1laSBYaWUNCj4gPEppYW1laS5YaWVAYXJtLmNv bT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgSnVsaWVuIEdyYWxsDQo+IDxqdWxp ZW5AeGVuLm9yZz4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAxLzhdIHhlbjogcmV1c2UgeDg2 IEVGSSBzdHViIGZ1bmN0aW9ucyBmb3IgQXJtDQo+IA0KPiA+Pj4+PiB0aGlzIHdheS4NCj4gPj4+ DQo+ID4+PiBJIGhhdmUgdGFrZW4gYSBsb29rIGludG8gdGhpcyB3YXJuaW5nOg0KPiA+Pj4gVGhp cyBpcyBiZWNhdXNlIHRoZSAiLWZzaG9ydC13Y2hhciIgZmxhZyBjYXVzZXMgR0NDIHRvIGdlbmVy YXRlDQo+ID4+PiBjb2RlIHRoYXQgaXMgbm90IGJpbmFyeSBjb21wYXRpYmxlIHdpdGggY29kZSBn ZW5lcmF0ZWQgd2l0aG91dA0KPiA+Pj4gdGhhdCBmbGFnLiBXaHkgdGhpcyB3YXJuaW5nIGhhc24n dCBiZWVuIHRyaWdnZXJlZCBpbiBBcm02NCBpcw0KPiA+Pj4gYmVjYXVzZSB3ZSBkb24ndCB1c2Ug YW55IHdjaGFyIGluIEFybTY0IGNvZGVzLg0KPiA+Pg0KPiA+PiBJIGRvbid0IHRoaW5rIHRoYXQn cyBxdWl0ZSByaWdodCAtIHlvdSBhY3R1YWxseSBzYXkgYmVsb3cgdGhhdCB3ZQ0KPiA+PiBkbyB1 c2UgaXQgdGhlcmUgd2hlbiBpbnRlcmFjdGluZyB3aXRoIFVFRkkuIFRoZXJlJ3Mgbm8gd2Fybmlu Zw0KPiA+PiB0aGVyZSBzb2xlbHkgYmVjYXVzZSB0aGUgaW5mb3JtYXRpb24gaXNuJ3QgZW1iZWRk ZWQgaW4gdGhlIG9iamVjdA0KPiA+PiBmaWxlcyB0aGVyZSwgZnJvbSBhbGwgSSBjYW4gdGVsbC4N Cj4gPj4NCj4gPg0KPiA+IE1heWJlIEkgc2hvdWxkIGRlc2NyaWJlIGl0IHRoaXMgd2F5OiBBcm02 NCBkb2VzIG5vdCB1c2Ugd2NoYXIgdHlwZQ0KPiA+IGRpcmVjdGx5IGluIGFueSBjb2RlIGZvciBw YXJhbWV0ZXJzLCB2YXJpYWJsZXMgYW5kIHJldHVybiB2YWx1ZXMuDQo+ID4gU28gQXJtNjQgb2Jq ZWN0IGZpbGVzIGFyZSBleGFjdGx5IHRoZSBzYW1lIHdpdGggIi1mc2hvcnQtd2NoYXIiIGFuZA0K PiA+IHdpdGhvdXQgIi1mc2hvcnQtd2NoYXIiLg0KPiA+DQo+ID4gQWx0aG91Z2ggWGVuJ3MgRUZJ IGNvZGUgaW50ZXJhY3RzIHdpdGggVUVGSSBmaXJtd2FyZSwgc2ltaWxhciB0byBSUEMNCj4gPiBm dW5jdGlvbiBjYWxscywgdGhlc2UgY29kZSBhbHNvIGRvIG5vdCBleHBsaWNpdGx5IHVzZSB3Y2hh ci4NCj4gDQo+IEhvdyBkb2VzIGl0IG5vdD8gVGhlcmUgYXJlIGFtcGxlIHN0cmluZyBsaXRlcmFs cyBhcyB3ZWxsIGFzIGVub3VnaA0KPiB1c2VzIG9mIENIQVIxNiAodGhlIFVFRkkgImFic3RyYWN0 aW9uIiBvZiB3Y2hhcl90KS4NCj4gDQoNCkJ1dCBJIGRvbid0IHRoaW5rIENIQVIxNiB3aWxsIGJl IGFmZmVjdGVkIGJ5IC1mc2hvcnQtd2NoYXIsIGJlY2F1c2Ugd2UNCmhhdmUgc3BlY2lmaWVkIENI QVIxNiBhcyB1bnNpZ25lZCBzaG9ydCB0eXBlIGluIHR5cGVkZWYuDQoNCkknbGwgdHJ5IHRoZSAt Zm5vLXNob3J0LXdjaGFyIG1ldGhvZCBmcm9tIHlvdXIgc3Vic2VxdWVudCBtYWlsLCBpZiBpdA0K d29ya3MsIHRoYXQgd291bGQgYmUgdGhlIGxlYXN0IGltcGFjdGZ1bCB3YXkuDQoNCkNoZWVycywN CldlaSBDaGVuDQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:07:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:07:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358928.588312 (Exim 4.92) (envelope-from ) id 1o7DYS-0001gq-P4; Fri, 01 Jul 2022 10:07:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358928.588312; Fri, 01 Jul 2022 10:07:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DYS-0001gj-Lj; Fri, 01 Jul 2022 10:07:16 +0000 Received: by outflank-mailman (input) for mailman id 358928; Fri, 01 Jul 2022 10:07:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DYR-0001gd-1e for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 10:07:15 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10044.outbound.protection.outlook.com [40.107.1.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 92e65fa4-f925-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 12:07:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3033.eurprd04.prod.outlook.com (2603:10a6:7:1d::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 1 Jul 2022 10:07:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 10:07:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 92e65fa4-f925-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g+NTs4GQfia4NC7fvGHrAysuI8mLIy6a+pYS8V05LlRLlwqFFy30NSJMDsDMWsw7zpTTemqsplYNDBlKI1fB3o9iKG9hKGMqD4ydyKkXSjYezyxb+1BATQwA23p8AZHIUcMSrcd80LomUlPZtGF0dGQ/R1sq42OZd1fRBuxQsQeDVHekIq/gmr1ZWM4ganPji+8RNywBbi9u2vZ4XyPODkFgqPOFjlot+Nslrt2n2NCTsg4mjYOU6VCeAMEH6/mJQxy9p7K5T7V1dOrHVFHwYQiVy1PxOrSSI4Z8P0qNHcRAG6DZqrVna5+zTKTxOFRXrO9Tw+G7KcdUpGQWOrKnOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QE/ZsfTp4HR94aaoC2vqzmvLdkoUqNUorD1fOt6N8tA=; b=ln1onDQl/HbqjWVSEL/nsWVVmfC2Uj7sEbmVRaxioDcFaD2HIaeHl/gz5h/Al5oVbxcbBl/PxgUjHmOu0IQ+h24DpLzU+MhbWFZoQfnK8KgPWa9RKIfJOhzEtQFtTMJvQtg0SqzAyZvxQzmEpcPYTy2RwjX2FXx6cNohmugWQ+3xy52n76eCPVu3/F87dT0MNwk92gtrF6RBW8xsO+qbO7TKK4JRTdY59b3JkLkecy21dzbkdxxKw/Xacj7cgPjL3DoFPZYZpMS9svJUkEhV7nd505MLq4Pd4IOWqS9Mi0NX4jVRdaECu6zTPdpDRP9z3qqJqvOPKSFYV9UaH9NkBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QE/ZsfTp4HR94aaoC2vqzmvLdkoUqNUorD1fOt6N8tA=; b=mJThu+8TivbSnq23rfbti86QEVBMz+SGq+2WSBFcPFxyhbvMAYBFfGMC9hhUqB6LEFOoaH07jp6FewKHi2D9v+XIkA3mLUQKTUdjxt8FR1v3j5BMlahF3Dxo0Fv3dtkZ96sxDec9yEHafLB8S4rHakpnj1nKGMt7p29IKgnciyiQcGc2ZOBSjfd4+KfKLbPkbAz5jFsI3ZRuA18Xc2q8SWDeLN3GGTIwGfzi86jmhe8CymQdHaANR6Wi+yOf+3dX7Bs/sy3KCvGHFYj6qnabJoGKVYcZjSflNQDglLvehAxhAwba+PeqeGitxcaPcgLRy6Z/L0+Yoyj2a5OVBytFsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7a6515c1-840a-65d7-645d-8a67e0f3c109@suse.com> Date: Fri, 1 Jul 2022 12:07:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm Content-Language: en-US To: Wei Chen Cc: nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" , Julien Grall References: <20220610055316.2197571-1-wei.chen@arm.com> <20220610055316.2197571-2-wei.chen@arm.com> <05dadcda-505d-d46a-776a-bb29b8915815@suse.com> <8e44e765-c47f-4480-ee44-704ea13a170d@xen.org> <6e91d7d0-78d2-2eec-3b14-9aea00b2a028@suse.com> <1d488f5d-bfd3-a816-dab1-515f49a57f67@suse.com> <13142c32-f67f-751d-4783-87e8afa1117a@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR0502CA0050.eurprd05.prod.outlook.com (2603:10a6:20b:56::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28324b48-c577-47fe-3914-08da5b4974cb X-MS-TrafficTypeDiagnostic: HE1PR04MB3033:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iscbRJM4D5q283y2rrpoLp4kLR9AL+EmQ1wwDShLxGlnRFuel0iNSobqMANv9jT3t6HeeRCrYkxbVWqtXYUpGTyhqbBmxuXhvYkfYZMKaMZ9BcAUFpRwMjTT9nkTEN2sBZO9r3yFYGaiqHuFjBjCWnj3bYIaWaGpEmuZBESAYQikv7Rh8EfEl4v2u2mzcJcQfIhOEk9ZepcZ2Ma7TbODVwSwYCgkoDOyQ3F/NxS60cDpBJ3OuJdzhAYu+HlgvnBLp+y0f+ZuprcM+XhdYXN9SHFJrt8XTeDleejCXKltCCd5Mx9kPQT4WPtHxVcAPdRttBw/zH1S4QADDcUjP2AX8dXuKbpFiJ+uK7co1AXwHeSOXvkjNnFnP4xJdxzOnAwKDhmsE8s3sjZ4t4nZZQlAPdsq8JIfN79OIQjvEW9wVGoGsY8+LhT3VKKhZlywKWSIOTx/e2O3JJ0Xw0QApwhOtJlH98x47B3tnsxYqpdOADvpmIFAhi2/taS7aHOpYGQaz/gbmbUsuqtZuLpYSOcPdEYqDEcBuX+eWLArcgWpvbx1404sRYZR0MrpeyM8D5duTAlxe5CDIlf7eGwoRuRFEIWhTMS12Mv4XzPlEHy5a527/zPJadaKelH/b6nDBJbqbboja5U7lbKI43Oy4NChOBBnBq83wdXgmnAL4aEyWPQm3vebLZu3kEW9Zk16eeVcct45D1JI9yLO9nMhph8ix70weBJqZ9fAApd3HA74Bq79viObwhret/ph+fTJ73WcnJuBOn2yYtCycI5wokjTevknVkYGux6jXtgVat5FhaQdvMjlQZVMlE6BNNp2lnjsw0VsYBHMtr9xgQTbWpgQEwY/EcdYzSeNnGidvrf3AN8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(376002)(346002)(396003)(366004)(53546011)(38100700002)(6506007)(31696002)(41300700001)(66946007)(4326008)(5660300002)(8936002)(6862004)(66556008)(66476007)(8676002)(6486002)(86362001)(478600001)(7416002)(26005)(186003)(6512007)(36756003)(316002)(31686004)(2616005)(83380400001)(54906003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWNsVllLWG1aMy94M0RsYk5hdjFpaTVHaHUzTk8xZHZXYW5QazdKWGt6M0w0?= =?utf-8?B?NjVQeTJMUkRnU0RNVlcvQVdYQVYwc3dML1NIQWNNMGRrTG1RNHdFclkzTDlT?= =?utf-8?B?LzdQQ3dwUU5TTzF0K3duZTdwdkNYRW8xbXN3dGVXRVc5UFRqVXZ4WENEaHJ1?= =?utf-8?B?ajVaTEE1bE5NQzJ6M1JyOWpaOWlmSVZ0L0E2QmsycHNOY2RSaTdablhqZ2tz?= =?utf-8?B?OGtBU0ZsTUlSL0ZoUis0TFlZSHRMWndOdGlJeWVoR0hoT3VtdHExUDdmWHpC?= =?utf-8?B?b0l3WXF2U2V2WnNSM3BacXdKd3RjeG1iRjUzZGdyR3dxdkl2ODVCeGNkWnZk?= =?utf-8?B?azhJd1pvL0RkWVhvVmlzZW14TUp0S1ErOWEvNUd0ayt6Qnl6MDNQbTQ1ZE40?= =?utf-8?B?eiszc2ZHYzRXMmdQUk9NZStuZzlpUjRpT2xkT1lWL3VjTmo5MzdmWEtxNmlI?= =?utf-8?B?ZUk0eDJoZWN3cHlMaUJINW10Z05ac252RnV4VXVSU3cxMWZub3ZQTndjV2ZN?= =?utf-8?B?cjA0WVhpK2JnWjBTeW5OMzNmRlg5MGtDbWlOQ0xDVTdNaVpidDNvN2JzSWZ3?= =?utf-8?B?KzZqVTEySEJtV2lQNzBTU1VHVjBRQVpsUVhHT1liRUthRVNJSDErSHRNcjVT?= =?utf-8?B?U2IyQU9zV2NaMUtMTElOemNoOENpT0s5MFNmZ0lZM0lJZ0Qxd2loMC9BVWsy?= =?utf-8?B?cTVDUHJQMzF2ZFF4RXlYaGplSWtaZ3ZTcEVjSVdrUG5GSVBzTzlMN2dsaVUz?= =?utf-8?B?c0NtSU43ckhxODdDTGJyd0RXQStYa3lMd2tnYXRlL25kbDQyYjRNdTYvNGpu?= =?utf-8?B?ZWVDVG5jNGxXMmpEVFFwN3FjM2poVzgzQXRqM1JpNlhMUGY2QWg1Zzk1aW8x?= =?utf-8?B?VmNwaXUvZXJXZzlQaWRKdjU4N3Z1KzBCU0RzbUhtMkg0bUQrZVB1VG8rV1Rk?= =?utf-8?B?RlhKZXBicml0UWhjc2Zhc2dzenE2WEZVd0dTS0NKNU14dytaT1d1ZldVWDlw?= =?utf-8?B?WENMNWxncDZFbEJHVFh1ZFBuL0RscUYvUHlqWWhoV2NUL1Y5NmhGY1JHeWhq?= =?utf-8?B?dmhmY3FYVjYzM1hTalo1T0ttVlN1WGtlTW5kdHRhOWRoWDdqWnRGemhzMFVK?= =?utf-8?B?MmxWUVFkdnEwM0xqSTRzWUpKdmpnUmlybzNEMWRhWUprd0h2ZlpodUlRb0xL?= =?utf-8?B?bGFjSURJdzk0VUYwUkF0OWZHeEluckZBYzF3V0pndFNYRmloTUFucDkzVU5Q?= =?utf-8?B?cHoza1VUakRDdUVpeGFYbkZWTXlhdzQ2a1QxK09LM2NNeERVdnZZLzhGbFlY?= =?utf-8?B?bTlrSkJjZ2p6UmJUSVlLNzRCYWUxVUlCVld0aDMyNGFOWjUvMmgvSmZaVjRM?= =?utf-8?B?SDJjRmlRVnR0M0ROcU8vbHVMOHZ5Q2xYbFVkdHJsOUFXWDZrME5WeERaRVdn?= =?utf-8?B?dDNsZVdWdlRhODYrYUE1aVhTeFdJbW5OWWh1aldHMjl2Qkt4cUFySTNldVI5?= =?utf-8?B?VVpyNHY2UFlPbWhodU1HV1VTcW5oUlkyS1hZSXVkQ2w0QkU0YVdWcDJNNFRl?= =?utf-8?B?alVheGh0ZVVHRExBRXZZVkEzVzU4dVpIbUU5bHpVR1drcysvLzAxY0dpaGFt?= =?utf-8?B?Zy93RHJxQU1jTWF6WmlFdkhsdG54OEdHeHhOVlQzblVHd0t6ZXN6YXhWc1Nh?= =?utf-8?B?bnllM0dyMUc2TDZZb21hWU0wWVZlRkt5YUF3dVpwaUc2eVp4bUJTTmNIbEor?= =?utf-8?B?dnFDYjhsN1BPcW1CSEkzTUsxUFJ0czZrM0NTM2d6V2FDb3kxY3RYaEdPSk5K?= =?utf-8?B?VjJrK1Azbmkwak9FeDdUWmlEaWM3N3R5TlIycVp0OHdnTjd4d3RvSnZHUmxy?= =?utf-8?B?M3gySEpaWEE1ZkFpTFo2Q3ZZaTJUREZ1QkRIN3greTBiemlmRjc5UnNzSnBu?= =?utf-8?B?eHNoS0tGZ1gvUmp3WFRtV01TaG9BUXF6cGU4b1kzYWwzNTZDYlVwR2o0WDRy?= =?utf-8?B?b2t2RVdFUGdYTElnQmxrZzRqMEc1RUUzbVVLZ0Z6eSt3WDFvT0UvWGRybEFX?= =?utf-8?B?NVNOWVU0bmdhTDZ0Um8xRTdieUtiSFdCUTg5cVFIQ2ozZ2pHaFhuUnVPWE1t?= =?utf-8?Q?txFR4i8gbyLFzDv2fvX+fdjJd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28324b48-c577-47fe-3914-08da5b4974cb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 10:07:07.8280 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: e/kSnxHz0ki2OG37ZnPdqxMGtdDc9GvngLlp9Pphs4Q3cvsxHEhLhA0/iOrNk6+vt8oDCYteultQikArxCt9zw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3033 On 01.07.2022 08:10, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月1日 13:54 >> To: Wei Chen >> Cc: nd ; Stefano Stabellini ; Bertrand >> Marquis ; Volodymyr Babchuk >> ; Andrew Cooper ; >> Roger Pau Monné ; Wei Liu ; Jiamei Xie >> ; xen-devel@lists.xenproject.org; Julien Grall >> >> Subject: Re: [PATCH v6 1/8] xen: reuse x86 EFI stub functions for Arm >> >>>>>>> this way. >>>>> >>>>> I have taken a look into this warning: >>>>> This is because the "-fshort-wchar" flag causes GCC to generate >>>>> code that is not binary compatible with code generated without >>>>> that flag. Why this warning hasn't been triggered in Arm64 is >>>>> because we don't use any wchar in Arm64 codes. >>>> >>>> I don't think that's quite right - you actually say below that we >>>> do use it there when interacting with UEFI. There's no warning >>>> there solely because the information isn't embedded in the object >>>> files there, from all I can tell. >>>> >>> >>> Maybe I should describe it this way: Arm64 does not use wchar type >>> directly in any code for parameters, variables and return values. >>> So Arm64 object files are exactly the same with "-fshort-wchar" and >>> without "-fshort-wchar". >>> >>> Although Xen's EFI code interacts with UEFI firmware, similar to RPC >>> function calls, these code also do not explicitly use wchar. >> >> How does it not? There are ample string literals as well as enough >> uses of CHAR16 (the UEFI "abstraction" of wchar_t). >> > > But I don't think CHAR16 will be affected by -fshort-wchar, because we > have specified CHAR16 as unsigned short type in typedef. Oh, I didn't recall that anomaly. Yes, then only string literals are affected. Albeit I'd hope gnu-efi would at some point switch to using wchar_t as the underlying type, as long as the compiler provides it. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:15:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:15:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358939.588323 (Exim 4.92) (envelope-from ) id 1o7Dfy-0003IQ-IN; Fri, 01 Jul 2022 10:15:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358939.588323; Fri, 01 Jul 2022 10:15:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Dfy-0003IJ-F1; Fri, 01 Jul 2022 10:15:02 +0000 Received: by outflank-mailman (input) for mailman id 358939; Fri, 01 Jul 2022 10:15:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Dfx-0003ID-20 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 10:15:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9125990-f926-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 12:14:59 +0200 (CEST) Received: from AM5PR1001CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::18) by VI1PR08MB4606.eurprd08.prod.outlook.com (2603:10a6:803:bb::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 10:14:55 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::a0) by AM5PR1001CA0005.outlook.office365.com (2603:10a6:206:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Fri, 1 Jul 2022 10:14:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 10:14:53 +0000 Received: ("Tessian outbound ef501234d194:v121"); Fri, 01 Jul 2022 10:14:53 +0000 Received: from 5825e618c354.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D91858F5-5228-4052-9F2A-4143C23E20A4.1; Fri, 01 Jul 2022 10:14:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5825e618c354.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 10:14:45 +0000 Received: from DB7PR02CA0036.eurprd02.prod.outlook.com (2603:10a6:10:52::49) by DBBPR08MB6105.eurprd08.prod.outlook.com (2603:10a6:10:20d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 10:14:43 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::d2) by DB7PR02CA0036.outlook.office365.com (2603:10a6:10:52::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17 via Frontend Transport; Fri, 1 Jul 2022 10:14:43 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 10:14:43 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 1 Jul 2022 10:14:42 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 1 Jul 2022 10:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9125990-f926-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fvaZplDSBpAe/+7E+4LM6pvhRNspqv1PpzU62zWKpxNdX2lldWFdjz+ZHn+Y148lGcaS/StZy0y2ZHAFK1w3jtYu7HHNd3LFlsHRtLnxHquRIratPOvW6SjD4k91Rlyo907+ij+GDEkmMOTwnsc9Y0Hqix6VqsKw0gTLztSre32W+CPAhWsti7smk90aRr/1ZZvzNM3kJs481M6kzkICx0UXPUgj9c7W8n9eFDK491oo+dYkCfUe0LWyRBu6Bsyf1zWi6NDRNXO/BrE7duRSDkvv71hGZrI7hZ1vwax0uWG2JATZi/bEkP9b6VGzCaejaxy2PNssGvTAqQ6DG9vAPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/EstXQWI7fTYjG6nR8Rf+nSkrpHj94TPD1Hr+B0j0g=; b=fZdIUL10JQKShnuoIJa8FgBUIts2QTTazLzo7ciTDjpk1CzXRxlOncIhnEkFdnl4BIjJj4TCL0zVSZD5O48X7VChMtsOhoiVv7XSg/6NG5jJiWRCQqroqxB5q5p80hGV1P9jVcIw6kVns0tbSrrpeFvtKgqay7cqZoW41hz0qvASS2lexCou4hTyHsyYIc6atXkK/+UgpMUvvn8U9vVdgTA5LUzD6jkA6QIkrY5YAAzTyjW5HRF6NAtKLe8bQdXpSeP6ORUgipT2LbmXLWRl9HApMFsx8NNvFWdxi5VVoYNHeHFeG3XmqMk2scgpoO2NQ8bIyDB3SzKSNjEwvCbQXw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/EstXQWI7fTYjG6nR8Rf+nSkrpHj94TPD1Hr+B0j0g=; b=PSYiYjue/6yr6YLbmpPxhBsQyJP4WPYGyRqYu3vEciakMuq6VVbgDqgQkrc+Y0mFE+95GqOOXKdXoPgjRhKDqR/fgbtn0vCqWitb7EoSotxAfVp4/h3gvuJGEuY8sKXkKgO5p5jG6WQQwqiHffAkLD6+heMp2obFqBWvem3aaJo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 74455e79c36ca19f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EiJ+i7DzfttsBCmA55OA5+bti8T43l2iAdByXTPjzESdaew+xjSb8RbHTR6teiNOWHYKqGlKg7ZgOLCOKvDtUSdHC1P41gIU61iPFEvjB68t0SWHqVQRUoZtwFNtJQTNCzppXZcFHzy454koZGWE+eTxr4CV8gozeURfZOfPziE6Mm9nbVhFGdiyZwQL4qo7BI7RA26Wwz162XNEGVjnwetIhyBN79dv5IDPvGHHxuF2JXuiKBIj2MgIN+2GxQhdtddUvFqBYxtkWFBdY9Eiv1ULmGA6jMIyiXP5BZKmAdVAVr/xr8TJhVrQieVgulhP6OTOauRtTcGReI/0SJwXDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/EstXQWI7fTYjG6nR8Rf+nSkrpHj94TPD1Hr+B0j0g=; b=PYj/JuUiTId8p01LEAGBjtzcQvrtrXRH4gXfuQBccT9KtPilJBvPGLbTDs2W4vuFzuUtE0yeg9mli7d1WfpBtmw/Zl8alFCrLq4+LQ1jIbsnNO1h+JdZGuCP0PYzEhtb6f8LVbuQfmg9xlBRyT+3khUUvPvDiYo/hZshyWsxJWmHUsSxHTvFnS33QY3lITxvqr3jGpommu56I8lMxyZK2LgoAdRoPuZb4Z0N5z5vbF8Iytn6CjWFV0EqBlaM5ZZHwa+ARLDknskQ6GC+AXPOIoUve2KpfrokqaNV8OQfkM2A4LbVqq7qpzy70fWBk9Qh/xT1a1HhQFK7IoDNpwgcRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/EstXQWI7fTYjG6nR8Rf+nSkrpHj94TPD1Hr+B0j0g=; b=PSYiYjue/6yr6YLbmpPxhBsQyJP4WPYGyRqYu3vEciakMuq6VVbgDqgQkrc+Y0mFE+95GqOOXKdXoPgjRhKDqR/fgbtn0vCqWitb7EoSotxAfVp4/h3gvuJGEuY8sKXkKgO5p5jG6WQQwqiHffAkLD6+heMp2obFqBWvem3aaJo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building Date: Fri, 1 Jul 2022 18:13:58 +0800 Message-ID: <20220701101358.954527-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 2b3eb207-686c-4a72-4de6-08da5b4a8a7a X-MS-TrafficTypeDiagnostic: DBBPR08MB6105:EE_|AM5EUR03FT055:EE_|VI1PR08MB4606:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IxhfBXowXFiHh85CUUR/wu4uXKCrqasI8kMOwgE8FoK0QLHteVyVbrZae8rH2u0azRxNtUSM0xp9EREBJkviMlsIMwy3z9Do+GjnmeflT4yJ3PdUIJ3CL8QnT/1K2eOMuVESGG8X4SMn+gPmz2NeCEPNXxT2XNyOT6KxkzHFf7Qm2e5i+gEHHQTu58Pr9Bl5Ffv4la6HV8Mv6P8LeCvr61Rh7XDDoRYW1T+y3SK50rUqmvriyu85QtUjaUO1p3khFnkhZAZhGUAIQghhPjTgEqGaCGBO/wTWStCts4FA7pqlxlHVMM61yUfB9kfGMuYPTpCUAiva2Z5Dt6rHaDUNuGK0xqNNvHsn4PpUwKrzwapNdU5GYdaLUQcZrlhsWpzKrFmHQj+IhRdsGfGubs+vcOC5BIvwQl84e2EbAx2rZD/UQLpu/rDuaTu0PBprwcFHEdh2xY/6XK5QGM3i7anJx7WEQzIu3/kbCjvpy82dH8O9zY6GqhoFSriktbFTfD7YqkF52x1vbqDQZ1sE/tzYlD2/nkcMZujsTNaJKdrC0elNMJMvfF4ml0Dc9jq75dJcHKK8jrQYJZzwVXP3AtOQKloZsOLvvyX+33W/ndukj4xQlQ1fUGN/Hq3N3tgH5hSI2li1eiAonxe0m67mHkeKUTbr4fJuDS3hdxUkOX6YSZxKmvJgPLyo9iPkHFn/W/MiGsHHscR9pqjAu0W/xI8RToUxPr1wQUWXoWTPt1voi3VgNVjUhD6LoROtkdjB8++VFk8638X02P8IlJNi7+qKD0kPXWUI2mhFaW9rHDN7hrqz+jT5iXyETaIXQabGEjLbc7ayGFoNFSICeZPWLFWv6mk/dwoEIDx2GCdSszgpcds= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(40470700004)(46966006)(36840700001)(54906003)(6916009)(1076003)(26005)(426003)(336012)(47076005)(41300700001)(70586007)(7696005)(2616005)(186003)(82310400005)(44832011)(36860700001)(316002)(82740400003)(356005)(83380400001)(81166007)(40480700001)(478600001)(86362001)(8676002)(40460700003)(36756003)(6666004)(4326008)(5660300002)(70206006)(8936002)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6105 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7dc6eeba-a208-4db1-bd8e-08da5b4a8486 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u8GBPzuW/tfQktXjpgUejg1MhvsrEgdanpw7HyCxg0KTbi4SE9U07XLW9U8KjYqZgGBS8SZZ4HyPGdU4zc1WqJLyrDAjHItFweo2Xx5s0Jp8Y3xKv+Dw/l90mEPoWNaleecrOXjv0vv/tAZVHKiiSVZysQNEEcJ4/0yfkAw7m0vq0sT04drjVuGwwbT5vrtbZ/1zJrydGtoqOfaDA/uUU18hK6mfmcPcGtSFZ56BKfn+RntPtmw8zUxx2S10X3/C5FtcLyezyFBGhZmYaTF17dQeUqPlbSi3YZucWRwuzGWY7Xxk8UN0oMF2zpgSwKvp6tUIi0ISFJ/qbFxqC3lwXl3OCai/iJsToHckMQMqhP4PfzyBsqe/nb+YYZtI/RFhYBM97DdL/6PY7dC7YkEOWjY5ZZG42PpnGx9dAu0rrWi0NAuBXMLOxS7vlCG5lF2SM0xA14e1JywufT8WMW+35cr5+NBbTzXhZ/2xyXNGHmHz8809FF1TKPbOSoGuDoAPN2u83jdjOwQ+5ukHqcepAu2kT5nv7jdOYmqcZ6CnttbnRIbSZVOXXPpXYfb+FCHpFbBRkJBp9lOzEGk11MkJONIZqEYfxgMdnn0qGf+gBAnrPrbWdrND+3j+c8fjT921uOQnXJ2Tf9G+PdzUWD1Kinu9/FDFpQJr7//s4VeDBjcIBjWYz2TAtGhhn5+jNCFvIFKr8PST6PKznD+uovDGJ8nswu0oxWUndJjRiPYJdmhAQp+h/R834w0LDQbRO4SXl6h583llaSgEReruCbgdvS7IS/hdhZTE3zu6VdjFXekk6B6Jw8qP0Dd+thHW+h1S X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(39860400002)(136003)(36840700001)(40470700004)(46966006)(70206006)(107886003)(70586007)(4326008)(1076003)(86362001)(2616005)(8676002)(41300700001)(7696005)(478600001)(8936002)(2906002)(6666004)(40480700001)(36756003)(54906003)(81166007)(26005)(5660300002)(6916009)(40460700003)(36860700001)(316002)(82740400003)(47076005)(426003)(186003)(44832011)(83380400001)(82310400005)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 10:14:53.4700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b3eb207-686c-4a72-4de6-08da5b4a8a7a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4606 Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar to use short integers (2 bytes) instead of integers (4 bytes). So keep "-fshort-wchar" for Xen EFI code is reasonable. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm32 to remove above warning. Reported-and-Suggested-by: Jan Beulich Signed-off-by: Wei Chen --- xen/arch/arm/efi/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index dffe72e589..b06fb96c1f 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -1,5 +1,9 @@ include $(srctree)/common/efi/efi-common.mk +ifeq ($(CONFIG_ARM_32),y) +CFLAGS-y += -fno-short-wchar +endif + ifeq ($(CONFIG_ARM_EFI),y) obj-y += $(EFIOBJ-y) obj-$(CONFIG_ACPI) += efi-dom0.init.o -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:24:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:24:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358950.588334 (Exim 4.92) (envelope-from ) id 1o7DpM-000515-NW; Fri, 01 Jul 2022 10:24:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358950.588334; Fri, 01 Jul 2022 10:24:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DpM-00050y-Jj; Fri, 01 Jul 2022 10:24:44 +0000 Received: by outflank-mailman (input) for mailman id 358950; Fri, 01 Jul 2022 10:24:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DpL-00050s-0H for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 10:24:43 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140082.outbound.protection.outlook.com [40.107.14.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 049fb5f9-f928-11ec-bdcf-3d151da133c5; Fri, 01 Jul 2022 12:24:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7711.eurprd04.prod.outlook.com (2603:10a6:102:e1::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 10:24:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 10:24:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 049fb5f9-f928-11ec-bdcf-3d151da133c5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MZnMBlIzesx1hzLQWYl/1hpmu9nG+Hzdwjy/XBKZrBbx3FHUlEtmhzvyFTXEY2lJwWh8iWJ9nAFhfIY7Sk1+sE36+GuVMHysR+rya9VK166apWjgp2PIpELXDy0kKuVuF2dzVPws0m2ljKqpcj2JN7PAGQU/QUW+W6h68mLTJPplgLoZxPugmrd0a9ct16jW7Ronga1DhVp+d9Vbf0BRr1ZMskYDP2g2kV2+XCWu5qfTL+HCVUEVgtY0rOwCdLShv2rWV5iLikyJ98Wq812Mqr+9sI3FLR+xQiptR8Eme4s2vjY0vbMKFcl2GO+ziqMxluJkha660Lh/BnV3eILrgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UYINq0ya/FtyAiI/ePiZ/8DJ7K/z5jslKI4ztS0uuoc=; b=Jqgx+NAV8QvRVGoVdFEVAI+f2BfPife8wimA6rlk71qCoUXvaHFPJMCrNlyvlMQ1JvIU48WDnR7KeDM8K0BKWLiu0GaCK0BdvDGGzA1fBLQ0elbdBgaMo5DZJB79HuaoJtAAoeb1khvJoqSbGthxC1Ow+e2oeXTAhzAUuKITJZtynRyG5S/YtzuOQvJp03Cr+0+1HVaEAEPR4cmmzNIekGmAYZKTsgpEWQrFxYWKmqFwGTvbO8WegErQT+0a8qo5ZL7cgZ/iw48NjZQmvS0BbMnJE3rQrmbSLmRGTbseHcMnpJP55AZM3j9zsZLdAq5kgwTHsh14/FdvIPqWdaPl4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UYINq0ya/FtyAiI/ePiZ/8DJ7K/z5jslKI4ztS0uuoc=; b=1hoEC3i45WgbfrAG4g5yddHaewWVLg1Amz+ny8ddcR6bW4/UvLLWrpJP/yXc8Fp7ur01/MxrfEVWnnMbgEG3KEomztwEy1IlZR+6nFXF5eNiWSKURdE8YLtWT7+4MD5NxOPFrzKxeXa+5GTD/l3ZegV9jQh71xu6TFpH4sFJneLSNZddSZA7UV2ZD7mvn37qTJHrPSwpMZwRD7Cqbzyoo9MmV4mt6+oWYFCs9cmk3f5SOCQlLKfc+q0xjQKZaJ40cS7esWBPaO43euqekkdpQ1uMNX5IVt9TvfNVgfJH3nni6AsHhvnSypGJvs6yyDOMGfd2QDd4Uoc3u/JDkI3I9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <563b5d12-6eca-cfff-129f-7bffb01cd25c@suse.com> Date: Fri, 1 Jul 2022 12:24:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v9 0/3] Adds starting the idle domain privileged Content-Language: en-US To: Stefano Stabellini Cc: xen-devel@lists.xenproject.org, scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, dgdegra@tycho.nsa.gov, julien@xen.org, george.dunlap@citrix.com, andrew.cooper3@citrix.com, dfaggioli@suse.com, "Daniel P. Smith" References: <20220630022110.31555-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0204.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 15949aaa-25bc-429b-a4dc-08da5b4be762 X-MS-TrafficTypeDiagnostic: PA4PR04MB7711:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jb74eNHKhNx+W08lCvn9ZIVzQeX/a/RyO8OZBoUSMVIKO6DnRuVunV33kcDlbU01IGdq67PcsvWQea+AUAsOoglTM8nNYBFK+wqne94uWJ4s9w4zw+KMM5wXc0hKOwuwXBmUHLvZzm7iP2yK6dMlbPKoDvrsJjcV6tjmXGOGTahmOam4Af+7eKZkVJKV8I32Ru0ZgGH4lbIo1lSfZFLgwLPh6KLcyrRaZTT5/20DoMTP+tc0/H8UC2wjKEgg9PGk5GGq4MbpSkbXjvznLa8+LVOpWetI87Vn5PjSVI5JVRe0ast5BykVt0SUkMifll8FuybY3tyCZGppSm4b1MEMtpuO/NiDrGRhxObW9ULKFnAdQY9cXAaTA0M+yAfPKpHg8iXU8mBqL6OWcX0WByvRxq33mrGz7whPl8ty/Dnn5gLCUkIs2WvPv/u0zULk4pvZno8+nN6p82RuNk8YqIszEn+JjsxwEnW11aJkSeBN/QB5t6xdGqMUsJQSXmcba2s7ITdgQ6gl1PVytznrilRBzuCZTeNIixOeLpYOjaevVzpDrCNIBfNSoLEyvxlSk2nXlwQkM9cRR+/dvED0bJKzS1piYyxbkqToO5U1MYwijtxu5+/WEC/+uEbIHz4pP0IQI70LSQhdXDBgmJ6RgiKGAtMBQoQy3k3oKBkULxJa1PE22Glf8ly9FneZMud0BpcfUWXGRqYCzW1CVaESwTDeH98tsTnnkMqINTR8P6ZR+9Fv88b9MVIsVPTrlhj1XCrbAVOC2xtyAiyJX988YfRmGzC5QFc4yFMmJT/E/EZsPHg6TmRml8Zb4qapF6xQNoN7cYqsfil0kwg/MeDSyBVQ8a5XxSuOLy6KQ7Tq0cU5UCE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(396003)(39860400002)(376002)(346002)(26005)(6512007)(53546011)(2616005)(2906002)(5660300002)(7416002)(478600001)(41300700001)(8936002)(6506007)(31696002)(186003)(86362001)(38100700002)(83380400001)(36756003)(6916009)(8676002)(316002)(31686004)(66556008)(4326008)(66946007)(66476007)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aDNscDNYT2JBTmRocUNUNHRiK0NqWjZRQlBPd1ArVDBPMU42TS8ySFRMcUZu?= =?utf-8?B?K0V3dTNXMlJvdUNGR09HbmFpZTFsQUZ2bmlYTmlVZHYwUTVRTWJNT3ZTMmJ1?= =?utf-8?B?Qld5Vmh6Sm11bmhYVEdWR0x2M25xRzI4ckRMcmhIenBWbGIwNTJnSCt1VTFR?= =?utf-8?B?LzlZVG1jVnh6VTlTNDE1S2pNUWlCZ2ZCVXNEWGUzS3dLOTRJQ0ZlTUdrdks3?= =?utf-8?B?Q28wdjI0OTFhaHFSbjA1YkdiVXdScVFRNkhjVmV3Z0ZWekpUWEVGQjV5R1ov?= =?utf-8?B?dFh2cm9BbFR3NFE5Y1NlNEJVRWxNckdOR1hLUDhETmxDcWhhMnNCSUFvREJ4?= =?utf-8?B?VnA1Y25KZ3doZ1hQQjl4dllWM3UwN0pLODBvMzZVNHJSRk5RVkdURHhVNk8w?= =?utf-8?B?K2RHa1NzbHd5OFVCekhraHd3SmtpMTFEaHdzYXN0NmxhMFRjZnNtc1N5c0xy?= =?utf-8?B?WDA2Qkh4RWdEWVlYeFI0WGlsZUxjalFRbjZzM1dJQnRuVnpjc1N3QWhrRmxH?= =?utf-8?B?ZGFxOXd3K202L0FCQ2liVEVqUFVJM2FuV3htS0c5OHBteUs4NngxMXZWcklM?= =?utf-8?B?K0tsa2xTTFRRTVVQQVJCTExrZkFESVNFVXlFWnBrWEVPU3p3eGFRU1hSYzdi?= =?utf-8?B?RjlpSWtGYTd4ZGYya0N0VGxsVEVUMndpN01mK1AxNnpYYXNHWEtYKzVkNmZy?= =?utf-8?B?M3JVVWg4bDRmOGRNaWNjblFQWWhqTW1LcGV2c1FWZDFWODNvSHVHdzRJVjl3?= =?utf-8?B?YnFDUXhBbXczVWdUWkFqb2V2OG1GUDY2ajVpZWdDd2loT0tYai82cVl4RjJm?= =?utf-8?B?Mk1kNHQ3OXBGbFNidFhaRWRzMlJXR1FON2VqVzBOWHBabXJobnlEWTRGYmhp?= =?utf-8?B?ZjRMRGxRZ0VpRUpXQnhsdERLUGFEWURZT3NBeHh0c3BKSkh2RXRyeWp3SnI3?= =?utf-8?B?Y2RUeUhQdXEvSHZqbzdjVFAzVjhGUXN3S094R0hUdFlNc2R6TGZDTUNpaWlX?= =?utf-8?B?djBTZkU3NXowYmVUYnErOWJ1a2NCdXQ0T092NXkrODZDdHh3REZhalFpUWdP?= =?utf-8?B?YlhjSDRUUXdGMmhEVHFsc040ajhNWEY0RFEvcFV6MGg2TEwwSEZNbTBiU2hy?= =?utf-8?B?UktJZTdXMkhmODJyWnJmUmNwU1hUa2xVeVhrVXpIaEpJNXgwQUZRNXA0UkV0?= =?utf-8?B?M2h2Z0ZjSVZzL1huM1lHbXhJVU9DYkxaTkdvNkk3djV4UjJnZDRxMTNVNGxX?= =?utf-8?B?ZHZSUThRS3pkRnhEeUdiNkJHYTJqeW82QUluVHRTaS9JQnpXRXRFQWhoVFZs?= =?utf-8?B?TkRVRWhpcUYxTDY5NnAwZGJlSEFjOXArQ1FtZi9XUEN5aUt2SC9Id0lpMFlm?= =?utf-8?B?VUlkRzY0N3lrSnBzNXJ0TDlpYmtycjBkUXp3aHlVclZPWlNZbW1EcGE4YzBB?= =?utf-8?B?SHRnUGJ1ZVpxSWhuRjBEdjdOMXFzeGNkM1RoMWVnVnVsNXd1TTRYMzgyN0Np?= =?utf-8?B?MGdmeUUya24zNERLVzRvRlpGVlNPWW1FTjFKUDUwZ0gzNWwvdnMwWmVVZmtj?= =?utf-8?B?VnkrTThKWHRidjhnWG1yQ2dReXhob0JYRXNsUnBTODV1N0tzbHIrZWJQSElZ?= =?utf-8?B?NmtyS2M4R3FwNWdnL0pmQStIVTZKVkR3SXBmMkFBK3paU2pMRGFkRGNNVzlt?= =?utf-8?B?UDJ2KzdydWJ0SzZ4TjhUdm5wajhCTGYvR0RXaGxGVGdnR0FVbjM5Zm1MUjds?= =?utf-8?B?N2ovdzMwdjBSOUhWOENUVkUydGtPeEM0Y01ocmRONGNEN1pQYXlIQWVFSXRr?= =?utf-8?B?RGhCTHZ0R2VtcGE5MXBnYlU2OE1SVzBFYm9FaEhFOUswQWR1S1lUd090bDhy?= =?utf-8?B?YzdlUHU4NmJUQS9Sa3NBOG01QldOZmMwYklxU3QyMEZqYm9qUG04N09PTnUz?= =?utf-8?B?NmpabUpmZEtpQndEaFUvT2l5WGZIdHpOVmZUZ2pzU3NVOEVPOENQMFpSK2lJ?= =?utf-8?B?L3hXSzhaM3JaS3VwbytNdUE2bGhFdG5lY09wVGt0V3BzTzRmMFZwWFRTcWVl?= =?utf-8?B?ekUrcjVKcWo4ZVRXamgxbCtCNnV6NnNnWWpLSzQvR05xZWxpVURpcFhYenk4?= =?utf-8?Q?L/DCBcikUogpAVYZorh8s6g98?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 15949aaa-25bc-429b-a4dc-08da5b4be762 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 10:24:39.0429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yckj80V+3gumYHDnRZ3AOvhsjOBEfk1RDMKT5hUFFYH1PdbXL6NbvB4nPVJZ697DBaW7SMnogkkJaRDPeez6Yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7711 On 01.07.2022 00:35, Stefano Stabellini wrote: > On Wed, 29 Jun 2022, Daniel P. Smith wrote: >> This series makes it so that the idle domain is started privileged under the >> default policy, which the SILO policy inherits, and under the flask policy. It >> then introduces a new one-way XSM hook, xsm_transition_running, that is hooked >> by an XSM policy to transition the idle domain to its running privilege level. >> >> Patch 3 is an important one, as first it addresses the issue raised under an >> RFC late last year by Jason Andryuk regarding the awkward entanglement of >> flask_domain_alloc_security() and flask_domain_create(). Second, it helps >> articulate why it is that the hypervisor should go through the access control >> checks, even when it is doing the action itself. The issue at hand is not that >> the hypervisor could be influenced to go around these check. The issue is these >> checks provides a configurable way to express the execution flow that the >> hypervisor should enforce. Specifically with this change, it is now possible >> for an owner of a dom0less or hyperlaunch system to express a policy where the >> hypervisor will enforce that no dom0 will be constructed, regardless of what >> boot construction details were provided to it. Likewise, an owner that does not >> want to see dom0less or hyperlaunch to be used can enforce that the hypervisor >> will only construct a dom0 domain. This can all be accomplished without the >> need to rebuild the hypervisor with these features enabled or disabled. > > > It looks like this patch series is fully acked except: > - in theory we need an ack from Daniel for flask > - there is a very small change to sched that would need an ack from > George/Dario I don't think I've seen any R-b for the last patch. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:26:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:26:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358955.588345 (Exim 4.92) (envelope-from ) id 1o7DrX-0005c8-2I; Fri, 01 Jul 2022 10:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358955.588345; Fri, 01 Jul 2022 10:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DrW-0005c1-Vd; Fri, 01 Jul 2022 10:26:58 +0000 Received: by outflank-mailman (input) for mailman id 358955; Fri, 01 Jul 2022 10:26:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DrV-0005bp-T4; Fri, 01 Jul 2022 10:26:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DrV-0006nI-Pn; Fri, 01 Jul 2022 10:26:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DrV-0002M1-H3; Fri, 01 Jul 2022 10:26:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7DrV-0002sW-Gb; Fri, 01 Jul 2022 10:26:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/Kr35cH//9rGkIDwU05WaOgfdEcpZAIg237nR0OtChE=; b=j6856gf7XWWxBHeCYA30MIQoV9 8+fdalV7aNNA7S+FD5KjpjUCNurlxhAo+6OEy1ikU0+nqYdO4x5e01IYQ01db2JX8nFeHKlqd9zhK Vz6PVHOZ4wQ1mGam0LZj3S9Yb6OtJxkbIfqv9oc9EoWaeOZIlwFrS25TvGiTuWw4Hjh8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171438: tolerable FAIL - PUSHED X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug X-Osstest-Versions-This: ovmf=f966093f5bb88e6fccac8e0b9eeca6c73aef0c35 X-Osstest-Versions-That: ovmf=8d0564deafc90df8531b086a483707cfcfac2b54 From: osstest service owner Date: Fri, 01 Jul 2022 10:26:57 +0000 flight 171438 ovmf real [real] flight 171439 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171438/ http://logs.test-lab.xenproject.org/osstest/logs/171439/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 171439-retest version targeted for testing: ovmf f966093f5bb88e6fccac8e0b9eeca6c73aef0c35 baseline version: ovmf 8d0564deafc90df8531b086a483707cfcfac2b54 Last test of basis 171422 2022-06-30 08:41:47 Z 1 days Testing same since 171438 2022-07-01 07:10:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann Min Xu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8d0564deaf..f966093f5b f966093f5bb88e6fccac8e0b9eeca6c73aef0c35 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:35:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:35:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358966.588356 (Exim 4.92) (envelope-from ) id 1o7DzF-0007FL-UR; Fri, 01 Jul 2022 10:34:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358966.588356; Fri, 01 Jul 2022 10:34:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DzF-0007FE-PL; Fri, 01 Jul 2022 10:34:57 +0000 Received: by outflank-mailman (input) for mailman id 358966; Fri, 01 Jul 2022 10:34:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7DzE-0007F8-Cg for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 10:34:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72518ea8-f929-11ec-bdcf-3d151da133c5; Fri, 01 Jul 2022 12:34:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9217.eurprd04.prod.outlook.com (2603:10a6:102:232::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 10:34:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.015; Fri, 1 Jul 2022 10:34:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72518ea8-f929-11ec-bdcf-3d151da133c5 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RwJBNj3l6BqRYI4RpplM1X6sVSKthrgTB7pofZpUGVPlDNZf/9fe4wjHsl2wYFI3UJa0IPhH3HhGmXGnezWDojNfuvdqCAwKVtkUdv+VBq38l7ptOWCtXferC2fMdTgXKhB42MCM8NaAedhGIzrs30t8YQvlN2+YmmTNySBixVpice+jtXGgyliKVdu7bgBZ2bidkZxgYKfhBkG/FAperf3zkVjXOi6ZsTCDzY8xes0dTT9xRfYeoFG3Go0Cgxdm0MZ0tfMpMpfPIFf5m1qgRMd6Pp65ngGCpfCGrByp/cSksmXOuPiyM/GlK/m1BvD5/MWjGh2kq++hn3td4wCSvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lmEmzqhS1/vZSZBov0UtRzrUd+zx6FE5U9oiwEXy6K8=; b=jSzjBlizHlNet6quWWhhQiAsexgABkDRQDkGalxbElXK4QxW+XBJhB2Dcu3BjJvMCfDtaiw9qG08XHg94mSbgLsRKwQsV+REXgi3z+2cdh7KoBee+T/9xX9Fs8YsBNJx8IuHW7uL2bZvQZWs2rg6ySONhI0sESGCwkLriUn2OmuQrDOSokquD0SPY0FNCb7DQFuXXRirBcNsotv5itREgUeYuhtJbousR/AIyr4KMyu+5KmRh4uB9eItvB42PnrK8sNj403MNMA7WtrSV+K3+jX3JdN+o9/a/rrigXx/e/KirtDQqvF79Chr1rDzFkPzX0JtocrL4USleXylT0vhxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmEmzqhS1/vZSZBov0UtRzrUd+zx6FE5U9oiwEXy6K8=; b=tlEafBXkqMorBRyIM1UlldEBgOU3fGNFgcp/KhA+XCqvUYwubEv1FBmw2TiO03iLo9E81vDp9yZs9udLkOCBZM9wqVcgYKHplL3XUIgknRNFWvBjLKF4SrjA7LkHBDGl0pPYFXr7hyPbP7LZAhGfDGYSV38dE1uS22TGWiA1PwmL8Iya/qdDlfDcAC2b1OPPwJqLfnjb/inpi4HLUNGnF9NTtC4g+wGolmrtV/VXS5ru79ZJEfbImwvB0C4NGp5I6O2NGE5coLiCHwe9cER8jSRUgGpLJV9CW22g1A5J39IyEeTPt0g0Qm3SzgfwpwMvBo23tSRY7I2rsv7sUKEjDg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <061c06ae-e45a-b18c-9c86-3387dac60820@suse.com> Date: Fri, 1 Jul 2022 12:34:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building Content-Language: en-US To: Wei Chen Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220701101358.954527-1-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220701101358.954527-1-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8c3a0a28-8dcf-4924-bf47-08da5b4d54f3 X-MS-TrafficTypeDiagnostic: PAXPR04MB9217:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mGb17NP/k9cgkJX/XEAmdNSv0f4kJHH5MvZGQRgmhniFtQ2Fwvv1vUgangz1erLs5Bjk/M2AgJoxpQuNvu4RlT6ebR/4dzX8BwnYj8SRgvbRknUADaNAHZpqvZJaw6LisY62Fyc1b7WWlRUIwp0PXRZR01M0l1VcMYOinnyNd0ogQ4STy7OnvDfn5mCXEpkbpN7DDnxa3tD/xOPTswnLssi7mgyESBGFlVbBPg7XirawZUush1asjmXfEs2IUbjqv6ucLvslOVsmVmhEnXBqOn2KI7zesiw94RxDZbc0nt1cxg4/Ppp0Lfs31xoiTAYcc891LJgXRe43P6Rit/9MvbJf2V0SBJXvJj+oFF/v+UYlc5PvxKMuEexKsJJJkhXI2HP5lMKcG7EXtdZzwL7U1qbpORoCjcgDsSI6MeoaF/LlOWLfMKYeYHNxWb36IbA5u88fomjsPEgOY3VVO+M04wBk3bZGOiCPyTGv4LKxkVrWf2IruzGNloYM2yAVxSpkn+4aFsjOkvt5ovZD/1oVQAacSrRzi5I9XEoSY8RW/B3uqnT3Uk5WdChZMtg3dJHMwqevZBpwpRWw8rvrM+0hHNMjNl04HHqMKqXtNwlFS2Z2F5ZyePY3i0JdgSOb1XVNW3FGRSa3pcJmBW4CYqIs6MQ/2XJSZnT5IY8nepgzCEoGdDXfK5sU5tG2YLJ/wUnjW2Xu2LT0i1xeK4SmNNxe7IA20BrJRjAykxfLxrKUZ5cZnQpzWLQydIsFXvIZiJegBYFZIyUCfk8R+fzwg8hmmcuTxUTNNlhXIYv7wM03bCC6ck13pyWwcz2D8FJB8/FTNukGoop7N8VuWH8fMDnb3kXnogTaBAUiAlu5wl7NT3U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(376002)(396003)(136003)(8676002)(53546011)(54906003)(66556008)(26005)(4326008)(66476007)(8936002)(316002)(186003)(6512007)(66946007)(38100700002)(6916009)(5660300002)(31696002)(83380400001)(36756003)(6506007)(41300700001)(6486002)(2906002)(478600001)(31686004)(2616005)(6666004)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3pmVGFEWU5rQTZsQllhTTNpMDU4VUpOMlhJTG1vczgzbXNkNUFFSnI4aUlu?= =?utf-8?B?Z1RVcnkyM0NoNGZXRk9YdVdYYlo0UmdySXRJSFp2WVVwU3BaZmtDUUVDWHA5?= =?utf-8?B?cTQ1RFNlQ3ViQ1l4UEcrQVZLeEhQVUFtVVdXeFVZYis1K2kvZG1pZjhLRUs1?= =?utf-8?B?VWIyNUd1SnlqWjhlQndXdE9pQXJVSlpFejVDTXh6ZFhQVXpnVUYvdjlwelpC?= =?utf-8?B?cmdBRWJOcThYdDlCN3NpbHlBcTJZcU5VN0M0NTR5MVNyMWpMeTZkYVJyaHJk?= =?utf-8?B?MC9EdVAxNUtpV2NEQ0RWdUZFYkxpUnJXZ0E3dENmWUhnVERNcUtSQnBKUXhG?= =?utf-8?B?YTYrcEZ2ZGtGU2lMN1ZNaHpkWTJqRXp4QXg1Uk9JOEtQbUVXSVQwSHpUc0lL?= =?utf-8?B?TTMzR2M1TE9jTmZyUEVIN3ZGd2VCazU4ZXcveCtMbUJuNDZjbjZOem5XN0Fj?= =?utf-8?B?WTFHNFM0SkYwdnJ4OXNGK2xlTktmajV3cGJ6SDVvQWR4MWg1SFpDeW9FREkx?= =?utf-8?B?RklSQjNqT0hLaFZyZWdkWDVRSEduRUpHUmduRncrZ1BvZ3ZBMjRwVlR5MkRV?= =?utf-8?B?QkNmTFlmYVBYUHdmWm1DUmdZa21jemtvamFJS3l6OWFxcXU0VVZ1cnBBU3Vt?= =?utf-8?B?YWgvUENPUnl5VGwxemM3UkZ0L2VCWTBVWjdFY2VqclFpRFZsamlXRWNJbENu?= =?utf-8?B?Ri84V3JiTEVkZFdOUzhWZmVyVStQd3A3REQ3QzlhVUVRYkZWZEFjb2ZBRlVh?= =?utf-8?B?d0NzRzcyTUtTcWo5TSs3WFMzeTBCUU94b215dVFQQkszS3pZUnVpYVo4ZDZP?= =?utf-8?B?T3l2alBNbGdyd0lvSDRlMjA1Tm9vR3NtanJibmtuT2Z5VmpteU4xU1UxTGtC?= =?utf-8?B?SWhhaHF0b2dzc0hROC9rVTdUMkpEZlBCdUpHeTMxMjBnaW4yVTdQaE0vQzhY?= =?utf-8?B?OGhMUkd1ZmVGZk1BNENNVFlaUkxoaGFjTjVrcEFpK2RJb0FxNjQ3ZmJTT2Q3?= =?utf-8?B?dmdiUTVjZU1wN3h6NzIxazhwTFl5TVhxL3FBdFJ3Q3JYeXk3MmNoSFFxRmEy?= =?utf-8?B?ZlAveWg5cWR0TnIzQVU5dWY0ellQMTZ2V3A1TWlmVHNBRWpXZkpTY3QvcXkz?= =?utf-8?B?dFlDV1FFb1F0WHdlRVdxMHJCVi9IT3BISnVTNHRhek9pUnB2OW9HUGFyQ0pV?= =?utf-8?B?MEZiVENWbUpxOXdUbFJ1eFhIekxhUjEyRXFNVGhaUXZEaUh2dlBGY2VJV1NW?= =?utf-8?B?dHVjNzJQUzNvZVEzVHMvRUQ0OGpNNHM4Q1hVcmdRMnN3T3cyb2JSc0pHdGRl?= =?utf-8?B?R1dDd3AzVnphcFhka25KbTlCWXV6YjVZRFovMFFYc3h4RHg5dlVYN1dYaS9X?= =?utf-8?B?NHpjSkt3eGpnZVUwYmx0K0xCSXVIdnVDRXpLRjRGbU5zVGx0RS9uVDZ0TkpN?= =?utf-8?B?Ui80U0Q0MVIxMEh1WGhBeElrRGYwS2YvTmZOZVp0R2dXWXdPZHhvWnhTQnJ5?= =?utf-8?B?TUNzdVltRkVHYVg1UHZLTGRpcnk4eTFnems1QVVtTWZIeFM3QW40YjN0K3hC?= =?utf-8?B?MEJ1Um5uR3hNYU4vRUF3YksrZnhuUzNpQ0tVOXN3RnZHcm9TekJ0NTBHc050?= =?utf-8?B?eFdXNWZhY0JqQmhhMXU5dUs1aUdid0k4Q00wbHNIQ1JaTEp1aWluM2Q0ZmRk?= =?utf-8?B?dUFDZGZzYkloRXU0RFVSSWp5Qk9Zbm5zaFM0L29aWmdOWHhYM0RTeS9ON2RY?= =?utf-8?B?cnExVm8wRU9BcS9udlNQZTZEYkoyTndNME9qZnZZZGxCRkFhNnVjWHE3ZDJS?= =?utf-8?B?K3lVaFVxL3ZTaFk1SDRja3JGL1NLaE5meHJLL1AxQWF1eVVXb2NMdFhwOVA0?= =?utf-8?B?OXZLcXQvM0xsY3pGU3p2NmJTSWd2dk9nSFc2Y3lTWGtRcHFrZGN0bUt0a3Q5?= =?utf-8?B?OUNHendsTzI3bDMxZldQZDJPTGtRWWlKalp6MEt1MVREaGdJM1BHMnNoVFND?= =?utf-8?B?V0xHREdGVE1STzAwY0VUUHJ4MWJCRk4xSGFoeUIwdHhERFI1MDhuQlVITFAy?= =?utf-8?B?QzF6TUVlTUZ0OUJCSDgzMlRZeTRtNURWU1RIQnU2V3Y3OFRpK1BWL3orZmY2?= =?utf-8?Q?VntEJ86tLCcwuX4iIkg/UJV+9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c3a0a28-8dcf-4924-bf47-08da5b4d54f3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 10:34:52.3622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Y5pA3arw2CEmwdGwwf1/o5W6r9eq/SQs8aIXKf8+5EKQLKNvEnKW6hbgCEnKRjw0Ez8w7T3ETLjmbytXdw9mJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9217 On 01.07.2022 12:13, Wei Chen wrote: > Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 > is using stub.c of EFI common code for EFI stub functions. But > "-fshort-wchar" CFLAG will cause a warning when build stub.c > for Arm32: > "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses > 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of > wchar_t values across objects may fail" > > This is because the "-fshort-wchar" flag causes GCC to generate > code that is not binary compatible with code generated without > that flag. Why this warning hasn't been triggered in Arm64 is > because Arm64 does not use wchar type directly in any code for > parameters, variables and return values. And in EFI code, wchar > has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). > CHAR16 has been specified as unsigned short type in typedef, the > "-fshort-wchar" flag will not affect CHAR16. So Arm64 object > files are exactly the same with "-fshort-wchar" and without > "-fshort-wchar". > > We are also not using wchar in Arm32 codes, but Arm32 will embed > ABI information in ".ARM.attributes" section. This section stores > some object file attributes, like ABI version, CPU arch and etc. > And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" > too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", > but for object files without "-fshort-wchar" is 4. Arm32 GCC > ld will check this tag, and throw above warning when it finds > the object files have different Tag_ABI_PCS_wchar_t values. > > As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar > to use short integers (2 bytes) instead of integers (4 bytes). > So keep "-fshort-wchar" for Xen EFI code is reasonable. So in > this patch, we add "-fno-short-wchar" to override "-fshort-wchar" > for Arm32 to remove above warning. > > Reported-and-Suggested-by: Jan Beulich Interesting new tag (but why not). > Signed-off-by: Wei Chen > --- > xen/arch/arm/efi/Makefile | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile > index dffe72e589..b06fb96c1f 100644 > --- a/xen/arch/arm/efi/Makefile > +++ b/xen/arch/arm/efi/Makefile > @@ -1,5 +1,9 @@ > include $(srctree)/common/efi/efi-common.mk > > +ifeq ($(CONFIG_ARM_32),y) > +CFLAGS-y += -fno-short-wchar > +endif Simply CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar ? But, as suggested, perhaps further $(obj)/stub.o: CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar to make sure we'd notice any other uses / issues here. After all it is - at least in theory - possible that Arm32 would also gain EFI support, and then it would be a problem if the other ("real") files were compiled that way (albeit I think the issue would be easily noticeable, as I don't think things would build that way). Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 01 10:56:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 10:56:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.358976.588369 (Exim 4.92) (envelope-from ) id 1o7EJo-0001Y4-JH; Fri, 01 Jul 2022 10:56:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 358976.588369; Fri, 01 Jul 2022 10:56:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7EJo-0001Xr-Ff; Fri, 01 Jul 2022 10:56:12 +0000 Received: by outflank-mailman (input) for mailman id 358976; Fri, 01 Jul 2022 10:56:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7EJn-0001XM-NK; Fri, 01 Jul 2022 10:56:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7EJn-0007Hk-Ke; Fri, 01 Jul 2022 10:56:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7EJn-00037t-De; Fri, 01 Jul 2022 10:56:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7EJn-00029u-DD; Fri, 01 Jul 2022 10:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HK8Mo//GFyd/V8M3Q2cTM0ZsnNmarw+M8crwX2S9wUU=; b=AUoR5RRW9SN6FAgAnYicf3zRAb ShnPsRiomqX46VczUFdlgZ2MVUlX3icDzPT0sSfSUMFFrxyOxfLqSk08FixAtKuSJXDwE1bgnvP+k gaVVP6G+YngMxOuxSZDJ6sLw6vMxoHaut9ssND5mN3Hx1qh7qQv4pPf+3YCyJFvDFkd8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171431: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:regression xen-unstable:test-amd64-amd64-qemuu-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=60d1adfa18793f4ddb70c8e901562d8d3e9be3dc X-Osstest-Versions-That: xen=93aa071f66b78a2abbf134aeb96b02f066e6091d From: osstest service owner Date: Fri, 01 Jul 2022 10:56:11 +0000 flight 171431 xen-unstable real [real] flight 171440 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171431/ http://logs.test-lab.xenproject.org/osstest/logs/171440/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail REGR. vs. 171415 Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 171440-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171415 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171415 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171415 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171415 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171415 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171415 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171415 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 60d1adfa18793f4ddb70c8e901562d8d3e9be3dc baseline version: xen 93aa071f66b78a2abbf134aeb96b02f066e6091d Last test of basis 171415 2022-06-30 01:51:58 Z 1 days Testing same since 171431 2022-06-30 21:06:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Roger Pau Monne Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 60d1adfa18793f4ddb70c8e901562d8d3e9be3dc Author: Roger Pau Monne Date: Thu Jun 30 18:34:49 2022 +0200 x86/ept: fix shattering of special pages The current logic in epte_get_entry_emt() will split any page marked as special with order greater than zero, without checking whether the super page is all special. Fix this by only splitting the page only if it's not all marked as special, in order to prevent unneeded super page shuttering. The unconditional special super page shattering has caused a performance regression on some XenServer GPU pass through workloads. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Kevin Tian commit fef244b179c06fcdfa581f7d57fa6e578c49ff50 Author: Andrew Cooper Date: Wed Mar 16 13:07:40 2022 +0000 x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint STIBP and PSFD are slightly weird bits, because they're both implied by other bits in MSR_SPEC_CTRL. Add fine grain controls for them, and take the implications into account when setting IBRS/SSBD. Rearrange the IBPB text/variables/logic to keep all the MSR_SPEC_CTRL bits together, for consistency. However, AMD have a hardware hint CPUID bit recommending that STIBP be set unilaterally. This is advertised on Zen3, so follow the recommendation. Furthermore, in such cases, set STIBP behind the guest's back for now. This has negligible overhead for the guest, but saves a WRMSR on vmentry. This is the only default change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Reviewed-by: Roger Pau Monné commit ffc7694e0c99eea158c32aa164b7d1e1bb1dc46b Author: Andrew Cooper Date: Mon Jun 27 11:54:27 2022 +0100 x86/spec-ctrl: Only adjust MSR_SPEC_CTRL for idle with legacy IBRS Back at the time of the original Spectre-v2 fixes, it was recommended to clear MSR_SPEC_CTRL when going idle. This is because of the side effects on the sibling thread caused by the microcode IBRS and STIBP implementations which were retrofitted to existing CPUs. However, there are no relevant cross-thread impacts for the hardware IBRS/STIBP implementations, so this logic should not be used on Intel CPUs supporting eIBRS, or any AMD CPUs; doing so only adds unnecessary latency to the idle path. Furthermore, there's no point playing with MSR_SPEC_CTRL in the idle paths if SMT is disabled for other reasons. Fixes: 8d03080d2a33 ("x86/spec-ctrl: Cease using thunk=lfence on AMD") Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 12:58:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 12:58:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359002.588381 (Exim 4.92) (envelope-from ) id 1o7GE0-0006zg-CN; Fri, 01 Jul 2022 12:58:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359002.588381; Fri, 01 Jul 2022 12:58:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GE0-0006zZ-9L; Fri, 01 Jul 2022 12:58:20 +0000 Received: by outflank-mailman (input) for mailman id 359002; Fri, 01 Jul 2022 12:58:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GDy-0006zO-CM for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 12:58:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GDt-0001Gy-IE; Fri, 01 Jul 2022 12:58:13 +0000 Received: from [54.239.6.185] (helo=[192.168.1.77]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o7GDt-0008U5-CD; Fri, 01 Jul 2022 12:58:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=HhdLZJG16irC4WgExTydf2rtiy0BJFQOFZN7hC2/dGM=; b=WUCcBJ87fq355zymLanZhCCexT O2SsMJBaFW93fS7QZQCn2fQXPaO28T8Yi1pGx1L893bYRHLRXE5c9ZnBQpWFCAd7/2PWQHeEPMXD6 DCjK7RH4xk0HSkEBoAJWMLkT6QLpvyyQ6cr5MoaPyeAf5s1b5mZ12QFifSIxAAQVhaJo=; Message-ID: <6e4a4da7-23e9-a976-2fdc-a96244c536fd@xen.org> Date: Fri, 1 Jul 2022 13:58:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building To: Jan Beulich , Wei Chen Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220701101358.954527-1-wei.chen@arm.com> <061c06ae-e45a-b18c-9c86-3387dac60820@suse.com> From: Julien Grall In-Reply-To: <061c06ae-e45a-b18c-9c86-3387dac60820@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/07/2022 11:34, Jan Beulich wrote: >> Signed-off-by: Wei Chen >> --- >> xen/arch/arm/efi/Makefile | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile >> index dffe72e589..b06fb96c1f 100644 >> --- a/xen/arch/arm/efi/Makefile >> +++ b/xen/arch/arm/efi/Makefile >> @@ -1,5 +1,9 @@ >> include $(srctree)/common/efi/efi-common.mk >> >> +ifeq ($(CONFIG_ARM_32),y) >> +CFLAGS-y += -fno-short-wchar >> +endif > > Simply > > CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar > > ? But, as suggested, perhaps further > > $(obj)/stub.o: CFLAGS-$(CONFIG_ARM_32) += -fno-short-wchar > > to make sure we'd notice any other uses / issues here. After all it > is - at least in theory - possible that Arm32 would also gain EFI > support, and then it would be a problem if the other ("real") files > were compiled that way (albeit I think the issue would be easily > noticeable, as I don't think things would build that way). Instead of CONFIG_ARM_32, I would use CONFIG_ARM_EFI. So this would also work if we want to disable EFI on arm64 or enable on arm32. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 01 13:17:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 13:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359009.588392 (Exim 4.92) (envelope-from ) id 1o7GWV-0001HA-WB; Fri, 01 Jul 2022 13:17:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359009.588392; Fri, 01 Jul 2022 13:17:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWV-0001H3-SV; Fri, 01 Jul 2022 13:17:27 +0000 Received: by outflank-mailman (input) for mailman id 359009; Fri, 01 Jul 2022 13:17:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWU-0001Gx-St for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 13:17:26 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 24b3f1f0-f940-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 15:17:25 +0200 (CEST) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2022 09:17:21 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5693.namprd03.prod.outlook.com (2603:10b6:a03:2de::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:17:19 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 13:17:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 24b3f1f0-f940-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656681444; h=from:to:cc:subject:date:message-id: content-transfer-encoding:mime-version; bh=3MRwqc9f6PLUD0ZVNY8tFkHVgCFux7eCRx6yjR38Llg=; b=cV16PtboaS1FjEEBTjDgaxFdoaWBEXYQtfL/v+0EDmxpNfkH5/Amp6WM j07DzS0ny2vgY/aY86NEtvXCny1NbafU87NBgaPhbtGHpbt3eVcf+KnWG ux2dW2w1JzWLkkz4jMnpZzOkYKl5NQsG5nONSfR+CGbSJ3hiMzvTzv7Pg w=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 74884640 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:D1I6Hqyfn5nZopDV/Qx6t+f1xyrEfRIJ4+MujC+fZmUNrF6WrkUEz zdMX2rXPP+CZGPzfIhzOd7l8k0Cv5PWz9FlQQNqrCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX1JZS5LwbZj2NY32YHhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NpljJL3EgwlO7/w28tBawtHKTAmHpJm0eqSSZS/mZT7I0zuVVLJmq8rJmdmeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeHuOTuoAwMDQY36iiGd7EY MUUc3x3ZQnoaBxTIFYHTpk5mY9Eg1GgL20I9AzJ/cLb5UD87TAr7rnsKOD+e4eUG+4Eolq2u WX/qjGR7hYycYb3JSC+2mKhgKrDkD32XKoWFaak7bh6jVuL3GsRBRYKE1yhrpGRiFO4HdRWK EUW+y8nhak06EGvCNL6WnWQo3OavxhaR9tZFcU77h2Azuzf5APxLmoOQyNFadcmnNQrXjFs3 ViM9/v2ARR/vbvTTmiSnp+WsDezNC49PWIEIygeQmMt+ML/qYs+ihbOSNdLE6OviNDxXzbqz Fi3QDMWgrwSiYsB0fW99FWe2Ta0/MGWEUgy+xndWX+j4kVhfom5aoe06F/dq/FdMIKeSVrHt 38B8ySD0N0z4Vi2vHTlaI0w8HuBvp5p7BW0bYZTIqQc IronPort-HdrOrdr: A9a23:OtYQZ6BXNQIJ/1nlHehKsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ++xoX5PwOU80lKQFmLX5WI3PYOCIghrNEGgP1+vfKl7balDDH5BmpM BdmsFFYbWfbGSS5fyKmjVQeOxQpeVvnprY5ts3mBxWPHpXguxbnnBE4kHxKDwGeCB2Qb4CUL aM7MtOoDStPVwRc8SAH3EAG8zOvcfCmp7KaQMPQ0dP0njGsRqYrJrBVzSI1BYXVD1ChZ8k7G j+igT8ooGuqeuyxBPw33Laq75WhNzi4N1eA9HksLliFhzcziKTIKhxUbyLuz445Mmp9VYRid HJ5ywtOsxigkmhDF2dkF/I4U3NwTwu43jtxRuzmn34u/H0Qzo8Fo5omZ9ZWgGx0TtsgPhMlI Zwm06JvZteCh3N2A7n4cLTah1snk2o5VI/jO8oiWBFW4d2Us4akWUmxjIbLH48JlO11Gh+e9 MeTf00pcwmOm9yVkqp8lWGm7eXLzQO9hTveDlwhiXa6UkUoJlD9Tpm+CUupAZ9yHsDceg72w 29CNUPqFhvdL5iUUsvPpZ0feKHTkrwfDnrDEW+ZXzaKYBvAQO8l3ew2sR82N2X X-IronPort-AV: E=Sophos;i="5.92,237,1650945600"; d="scan'208";a="74884640" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dDUQV+Nm9dM4cqK2/dShIzowJ0cRgA55HSFDLtX5USiWSkBbv/iK3n0/3wY4ZhxNnc7bWMgapTglPj01Buw3iPf3Sa3cNh7sYYXptfJW0fZrDpISycR8nfzMUpNc9KJ9cesrBxW1mPRQeeIETp+jxPpC5FAc9yiqvOK4T2R4lEalaDho2sYkerWNwi08DOVnjrjTK3HHwRKkdn5x5mysNn1dyX7lL23kTQAiHQYAisrrajCUlKjYIwsC7GZxEP88ydH8+UMEESbyg99ttDuHy8BEMcdSMFnPmLqRjD2iysD82YVzAmcuZtx1KSJhVM2qIHfAA9MkuQ618Oy9nNFF8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Gdie4pdVl4a0URPS9oFagfEaDHLSYbfEO8FCT2qL4I=; b=KEG4yDLiza319VkCP164rJ2CIyyJMNdkKjgW5CrrtqNdS5jeri4bLXey8FYOANg9RSK8garIOaC6BFVSlePmYjc3vc36sBfdNuDy5GFx3FIBkt9n23UTvKEG0qE7DKhMwsfGvKd0xZ7r94wMVotTXHVFQykHk1lM92CklRZ0tL7D2OxXhHXgshYckL2PaydO7P2Lb6Y4ezMIISWjemJ7cuJ11ExSuK8kSNlCTavcSuZOo0jrTs6LeLWDteYJVP5YVVnucpsqbxUbketRvneuhze8hDBAn0BL1dYHK8fxWG0cYdDtKOeJFoyxRAq2FT/qe3CDOxb2en5zniwofcTp6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Gdie4pdVl4a0URPS9oFagfEaDHLSYbfEO8FCT2qL4I=; b=LO1Cckc1ME7VhB0Lrp6xmdj9e/ke3cytlaTPb00RcdwUtRVS52uPLMuSqpk45TqPoa/apXruh+OgDyXeTNkA86IHPE7ZJu/Y4Fsl6PYxr8sZ3liKxQsVvspNt/F7bXJs+wF9uRtGtAVftEESSetlAzmN+JNdvunPAvj94cTze5Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v3 0/3] x86/vmx: implement Bus Lock and VM Notify Date: Fri, 1 Jul 2022 15:16:45 +0200 Message-Id: <20220701131648.34292-1-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0207.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::27) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 466b1680-3aaf-4911-5257-08da5b640691 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5693:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jOUtGnWXZv70rm+ITBg5pFrGYrMG7kfH5Bj8djaav6jg85+iYkxIpPWj3OoaqtMuG0IUPYG8NxTCdz8z5UGJ4nWovDroclfYZhOslogFv1/cZpeczGRh1q5u65ZVAEO4A6MxtuLAV/M1EU2XbUE5shoIP1YHR1OBxmG4+hz5ie1ccmBpMoD6Pa1k7gZmkwZ/KYZt+++ASa3x8Wp0bJaIndzkpwv6gFStjxyhBoetT2D+qbVhvPa83CSyuS3V0Bq1pxG1yQY5RqEf+T11lJ527FkJkK61sFr8HqxxRKBA/AAfiYM55idf8LSn1I2ieU0uN2BSK6+JRuICR9fUsccln3TJK0JT8qHL4n1Ky27fdq4yj5rE+U/Zju1WFGPRE9UUkjLVy9bdhLcqSMv6f0aSTffp2yXfgJcyhVw/B9w039voZGzpQAeh410+XrmdPn1PVU6vlXZ3qjtshbDJs15hxLnfLoFH0hAudDp/d0NqzpnBv0jLbrFZGiqkghMnvg9Ur6chEZpUWMsK5YXgxJCq/3dM/c9m5ndLjVz5DFCLUvRc242M3HOuzse3/tLM3lftxHpVzbBT+4RdhADO7mae0khM+j/5xm2XLfsXxzr26YS+5cCyicBp0TeE4L312XSsThyo631wYf61TEMiD5pcROnjBHOlUH58VUgQHDZJGkRY5RtU4mQ0Z2PH63yfq/2GE7kxRckE9bhn7gCMuexO+fw0w5blFMHj3Lw6w3IOc9x3roXvROjix52TQWBXuMQL X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(38100700002)(66476007)(316002)(82960400001)(54906003)(6916009)(8676002)(66946007)(4326008)(66556008)(2906002)(478600001)(6512007)(186003)(41300700001)(6486002)(1076003)(6666004)(26005)(36756003)(86362001)(8936002)(83380400001)(4744005)(2616005)(6506007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWhOVEhEM3NFaWtEekdGcGNIa3kzc3lWQlRHajVmTU45Ri9IVHpQd3h3V0RB?= =?utf-8?B?OU5NMk1rN2IvTDE4Yyt3YVNoSTZWR2hQRVUxdjJhS2FZUlN2UkUwb29OK0xu?= =?utf-8?B?WWxxNXY0aGR2OXBZdUU4UWJCQk4xUHduV1czd2Fwb0xhMUhoM1kxaHppNkJT?= =?utf-8?B?aTlrNjJOSlVnZW0rL2w5eUdvam5aUFFaVXRoQ1ZuR3d0MGYvVmlhTDNmMEF2?= =?utf-8?B?TFZqKzgxZHYrMWFxL1gzNzVDQkJ0aFE5SndZZjBJZ1hGcUxqbXVjWHB6R1g4?= =?utf-8?B?aEd2NlZ1bkVqaklUMU8ybVlPbzRlQ3krb1VRVGdubDFXOUFWZDUzelFCQ0Nl?= =?utf-8?B?ZGdqZW9zdndkZnN6Qlk2dFZUMG5CQ0Q3MXBqbm1FZkZwUlpabjBJZDhXb1Jn?= =?utf-8?B?UzY3WURtcjJ4bXNLWkJvV0kyQUlnbHA5T2E4STZrS3BVUVVxTGtGQzZ6TGIr?= =?utf-8?B?UHVRd0ZDRDNkRGloZ2lsaXlvZW5pb0pqaEFQa2tBVHFhbFNubU1jRkR5OUZ6?= =?utf-8?B?K3FET0pCU0MzSnhXL3lsYUVodU9ERGFwYnpNY293VjVpc1VHUHNFTFhZdkR2?= =?utf-8?B?Q0hRYWlnS1cvNmwrbjdyRVBIV2VEdGdNTUxzakIzb2ZlWVFzQ3lUa2c2VUx1?= =?utf-8?B?VzN4SUl6OXo2eFFqN3g3NjI4R3gzRTBTQ1Q4MmptbDQ5K3UzdjFpbHhYSEp1?= =?utf-8?B?ZHMxdHFtOW1hakRXUDl4ck9Qa3d2bkNvcFdhbHM5cGZtenpWUVVIdk85SXRy?= =?utf-8?B?bVVLZGlGWDNXL1FVY1JMUzZybDJHaTdiS0ZvWUlyY3hiVXdrRVNONFNGNlIx?= =?utf-8?B?MUZ2d0pBb3MvWFd5ZnkxM0lJRnQyVThPeWp5TE1tckNaMTM4WkxpeEFZeSsy?= =?utf-8?B?bFFDNk5BMm0wclQvNmVyUEZaTGV2WUo4ZWwxaWRHMHVUa29GUGo0TU5IalJQ?= =?utf-8?B?MTVEZHVKQUtOMmJYZ29SeWJFSDhMWTkram9NQXFUOXVsT1BlMzlwb2NBNVB0?= =?utf-8?B?dWtsWmhHa3ZDK0JIQTltbHBsR2Z2RTJscHdDU3Y3c0tEMm9oRnUvK3htK1l5?= =?utf-8?B?YnU1ZGkrM0htSUx2NFk0cVJ5RkdlZGYvRDVnSVFHRlpsQ2Y0L2daVlQyNHRw?= =?utf-8?B?aDZzbnk2NFBLMnpLZW4yT3BWc0UxZVhYVmVycjNDcUc3RTVyNk8wNnBtUEUv?= =?utf-8?B?am4zeFVOdlhZOE96dGNMT3NKQkVqS1VsUXFlcmRTc1BqWUNYc2JBbTNzMEQv?= =?utf-8?B?YUszaWhQM2NaQ0xycDdLbXY2S1BGRUtWT3B2OTFyb3dqQlUzald6VC9heW5w?= =?utf-8?B?TzFXRjh6QXo5MEZnVkwrMllRK29CMmVHdXBoOWZET2RNMUNHUk92ZWZxM2sy?= =?utf-8?B?R3dvNmZhR3JKbmsra291Mmd5VVVGWXhtOXQ0dU4yUXBnQkZtMjBlUnpRcENv?= =?utf-8?B?c0Z4UEVmSG9LWmhwYjdwcUFYc2tST2Ixck1DZXV1NWJmM2x6cmVaTkpoRktU?= =?utf-8?B?YzZ2V00wN2NSejhtZlJPNFN1QkRiUjhnK0ROME5ZbEpPOWFrZ3pVcGZKWmFV?= =?utf-8?B?SDNMVC9xZkROWnJLWDJRZDU4TkJjTzFLVGpKbEtoNzNPbXpvSUtYNUVUVkYr?= =?utf-8?B?OC9Xd2VvYXU5RHRsNFBETzJlV1F6ZUp3NWUyblBnODBGVXg3KzJtTGxRd2Vl?= =?utf-8?B?dXJjQTBmM0o5ZXhvbWZtaml0RFg3bG5MRmN2bEpMNmM0UUp1eUpjb1cyWmkx?= =?utf-8?B?N3o3WnVwN2lQQ012NDM3K2lrYi9nUDRaSjd3bUV5cjZ5R0p5aWY3MWdVWnp1?= =?utf-8?B?L2R0SFg4aUdUSkFwSEtKcCtVYWc0citPWGNIbFpnckxBK043WWNmeWdSVlR1?= =?utf-8?B?Ly9hN3d3OHB1aTNmd0lMR0c4cWxYNkQrUHRRZzMzTjVGL1JTR2Rvd0s2VXF3?= =?utf-8?B?bU5mYllPeitvdExsczhFZUl2TVNHcWhzT3FTUmZidVpzRnpEZWxFTTZRc1pT?= =?utf-8?B?N08yUVhVWVNYS2RmbGEvZnFjUlR0ckd6Q1lxdTNyTkhvZFdMKzF2U2sxRUJl?= =?utf-8?B?RGhFeXdhMjVndllYVzd1M3VpeHIwTzA1Z2ZrdERQTVhNNk5JNFpRNG14TVAr?= =?utf-8?Q?TLadfYbJC+ParAzd9rESuafHL?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 466b1680-3aaf-4911-5257-08da5b640691 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:17:19.2484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pGZWLEjYW5m5WjTFEiKDpyj8MVn0osHRyftNN3TlpzRJ+DqvacRe3v6R29a6XygvtrqP8IJ8IVZcNQVKXDTySA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5693 Hello, Following series implements support for bus lock and notify VM exit. Patches are not really dependent, but I've developed them together by virtue of both features being in Intel Instructions Set Extensions PR Chapter 9. Thanks, Roger. Roger Pau Monne (3): x86/vmx: implement VMExit based guest Bus Lock detection x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI x86/vmx: implement Notify VM Exit docs/misc/xen-command-line.pandoc | 11 ++++ xen/arch/x86/hvm/vmx/vmcs.c | 21 ++++++- xen/arch/x86/hvm/vmx/vmx.c | 74 ++++++++++++++++++++++--- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 7 +++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 11 ++++ xen/arch/x86/include/asm/perfc_defn.h | 5 +- 6 files changed, 118 insertions(+), 11 deletions(-) -- 2.37.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 13:17:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 13:17:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359010.588403 (Exim 4.92) (envelope-from ) id 1o7GWi-0001Zc-8q; Fri, 01 Jul 2022 13:17:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359010.588403; Fri, 01 Jul 2022 13:17:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWi-0001ZV-5q; Fri, 01 Jul 2022 13:17:40 +0000 Received: by outflank-mailman (input) for mailman id 359010; Fri, 01 Jul 2022 13:17:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWg-0001Gx-VU for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 13:17:39 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c05b488-f940-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 15:17:37 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2022 09:17:25 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5693.namprd03.prod.outlook.com (2603:10b6:a03:2de::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:17:23 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 13:17:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c05b488-f940-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656681457; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=1CEJiaivUyqrXZRdB2bbG35oJ0UdQJFYd4ZZZCv6hM8=; b=SYWE5niCsbsbC/rNvoa9FFkqIEGUHldoCva/S8SWC9UQCkos+XcLe6qN 37PQAtocwhiujjQBXNO8meK+TI+pmrgkzqldNFt+dVfGC59sJ1K4hISGF dcZtKrvuNOCs8TY92jN6ab9sCjlqGzEMaSmVz+11gcWCm/bO+zxKW/rGt E=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 77459718 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:urJXZKgWLbLjr62xh01/iSjZX161ehEKZh0ujC45NGQN5FlHY01je htvW2rTOPiMMDOjeo1wPozgoEsF7cCDzocwGQNsqiszQ38b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M58wIFqtQw24LhXFvU4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YTo5FaLJxPhCaTwbKzlkHrFLx4bfcWfq5KR/z2WeG5ft69NHKRhseKc+qqNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIIehWlg7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9w3J+Ptouji7IApZ7b3HHcTqeeyxZOJVnleXv 13ioXblDURPXDCY4X/fmp62vcffkCW+VI8MGbmQ8v9xnEbV1mEVEAcRV1awvb++kEHWc9BCL QoS8yknr6k3/WSqSMXwW1uzp3vslh0RRdtWVfE74Qely6zI7gLfDW8BJhZDYtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoOS1sD6ty6+oUr1EuRHpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:u8gZdqHxTnVcU9ZnpLqFepHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6faVslkssb8b6LK90c67MAnhHP9OkPIs1NKZMDUO11HYSL2KgbGD/9SkIVyGygc/79 YeT0EBMqyWMbESt6+TjmiF+pQbsaG6GciT9JvjJhxWPGRXgs9bnmRE4lHxKDwKeOAKP+txKH LajfA31AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGA9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9Mofy9AwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmgvf4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQi/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKpLzPKN MeTf002cwmMW9zNxvizypSKZ2XLzkO9y69MwY/Upf/6UkVoJh7p3FosfD30E1wsa7VcKM0lt gsAp4Y6o2mcfVmHZ6VfN1xJ/dfKla9Ni4kY1jiV2jPJeUgB0/njaLRzfEc2NyKEaZ4vqfa3q 6xGm9liQ== X-IronPort-AV: E=Sophos;i="5.92,237,1650945600"; d="scan'208";a="77459718" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fo/QXDFi4GWnJVaRWfqdHPnXMUNAfG6RTdr0lSkV04bXHk+pGPPlO3d+/oObzOpukiUVlX093O+pitVgSNLvyinVilP5ci4GGiJxGREEcU5n5MHPbHhMAC3szbeS5tcxSahuKBaGple7krhSyCPjOuQg8Ft9LQLKTCRhTySVbLs+A2aB2jZR7jv3RdtzYiWExK/Y1KHgwFh6YfYuHlBM/HZPNiGDkCeWO63pwVLZrK65LekTUBG4G7YlKqEFg8lX9y4omcAlrykeTJIbfZSdXQ6LcCQbAnXp/rCiLbNPKAsI7SKy7MVsmdqTroFsaOzUgtsYN8gqdB4Cl9QmNsjj1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uziEhWz0IVen09NpiCSfuedX9CMVUDdY/Qb7fXmqvOY=; b=Pu7/KF+n2UCjVXUMU18o47yctZhmUe00b1tbXT8FC5Q7wNfikCOuNBKxvwMTEfquEYWWt+Uygz4vVldrZ6DArr8lAaUWtbu5P2JUmhY9ppo1U6kvzlULJ1AuOQYTPYTv4jK7k+IoZ/MMGRQBRvFLHA6YjWOeMXqX5UXMskDagV95BEONakJjsDNUgWRKXMsiwRtSMQmzbmFkpMuR4TV+E3IfA+G5yf520Z2ICSA0nkZSLLpfMx5PNMaBK3aETjlBm3LoctGWFODHzly85H32CHOav8dvb+DtpG1FKSgnvCskLMtWlMw96gI6h+8Ufb2prDV3/Le3XKW3nH68MKLeoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uziEhWz0IVen09NpiCSfuedX9CMVUDdY/Qb7fXmqvOY=; b=RKdJQmGPRzroloUkWG3M/YtCOCDMQRTmuIUBnTE47t+4nAzQgVcQVuwBG5lvx1k0o03iJvt7ylhP0U4ftBImoAPZ+z4i+3uJVdFtS5pjQ95GemlUxselTCPfLpwI+iY5GgUhif4BbxqwNieXxsNFnSmfVksQT/HkiTFk8AY4Xnc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Date: Fri, 1 Jul 2022 15:16:46 +0200 Message-Id: <20220701131648.34292-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220701131648.34292-1-roger.pau@citrix.com> References: <20220701131648.34292-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0094.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f6f9143-42c0-4d7f-9f94-08da5b6408ec X-MS-TrafficTypeDiagnostic: SJ0PR03MB5693:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZBVauaUFwthmuKZRyO2A5PgS0Nh11H27SMxYuehvLpcYJBCPELCPHFTU96rLOi7n5pWmL9YxjSCP1C4KbyL7UxYzIsk60fdgG728wPoNvzgZM2q82ShsW0DeQTuKKxAMRu6yN49p3hrPnCgt13hwBJcFztT1pn4ut+F0P5REuSMe15xPHs7YHMIYeN5Dolsa+Ym50qqiqNp3GfLKZ69vHgX2An6pL1OaMN69YLGu2ToVn6eEtPDa7Avbf6XzR5XOalNcCjtqB6fJfhQZYuwCsHKxWGcI0P6W0SaRBwvWxR7cth5WwQ4/vEYEixgsaz3GzJ0BejYxb20Z+NAoxOolcmA0DVzRAm/DdG35ieWDZZvaTGlvQ+IqrHacYONyxsp0C1v0y6gu9O62eCN+kHI5oclKCKlxl9UBMWIjgOYnnX5PwrvPPXVBaePH/POA2ANiNR7PYgOldD8V4zBvWduMXkg4prYjzl9zpTzTaEQXDULni0iMnmghYO6/Te/yoiVqVUDw0fvjX5Q0o8y5tmeqcM8D3UlfaU9acoxgfLbYWs2c+p8pb48js3ie+b8/T8j4lReEW1qykJYQcfUmgiqt12KIWyBOA0NRsNn0sFZgu4TygNA7W53+wy5d7hak9BAdAzamABTugebPfV39tRGW/xmi/HR5tOGgcNgdsHewUsABr1vAVFFSVb9xjwqGwnfgnYoaKuExGi6m5jsZj8co2MMSsrY6DJ5JPCy5mi43astZtBfFmdZ86Iip4cR1Xz3+9t/Z3n1tnVgEYGRsystzGQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(38100700002)(66476007)(316002)(82960400001)(54906003)(6916009)(8676002)(66946007)(4326008)(66556008)(2906002)(478600001)(6512007)(186003)(41300700001)(6486002)(1076003)(6666004)(26005)(36756003)(86362001)(8936002)(83380400001)(2616005)(6506007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NzRvRHEwdkdtNEVRMGk0TktrU0ErV0p2S1RJTUg1d2lic0R5WDlsa3ZRYUQz?= =?utf-8?B?N0ZOVi90eWRkME1YZFdSWnNzSHlpa1BSdk03ZWxTR2p2UkY3MytQaStQb0dH?= =?utf-8?B?M3VlN2dMRFVrY2NZZ0lJeE0ybVc0MEIyRFQ1K1dZZUxST3hUWHFVRFF6dmt6?= =?utf-8?B?SnRacjltK3Q1elFlZDhSV2llV1BKUE1FTmFmbmMyV1IxT1RlU0hNcVNBU2Fn?= =?utf-8?B?cmZtTy80Y2QzQitRemZiMEdLM1RoQkJ6WEJLd1IvRXFwMU13VlExUGQya3ZP?= =?utf-8?B?aGxJWUMvdHZ4aXp5dEV6N29kQmVyLzhLTGdEM1B3elJidnZJUUtiS1drRW9V?= =?utf-8?B?UE5JRWMrNWg0cXl4cXNWbTRSZjZZN1Bvd1hDam05Ymg3bDBwdHFpSlROS2ZC?= =?utf-8?B?bzNkbHJha0RRWVExWTBudkpxb095K0gzOWI5Uk8vTEJIYzVJaWxNd0JKaFZv?= =?utf-8?B?eTdjZXpYVjE5T1NGQlBlTjZCZE81UDJtTmFhN1BkZFVMNmswdlp1N2g5aXBs?= =?utf-8?B?bmNudGhnaklyb212c0NNV0J2b0syTnNHdG1sK3dKd2x0WlR2eUw0WXVKMDNr?= =?utf-8?B?WmJXd0FoTTZEZVRHaWpBVlVDTjlMR2pYL1lET29nZkhwK29meFpEL2Y5OUE3?= =?utf-8?B?YzlFUjJzTW0vWE1admFoYUZJMDhOOFU3NHpKdzJqSWt1WU1VSk1xN1FLSHhE?= =?utf-8?B?RGpTZG92dk12YkVaZW43cnVQbXZ6WHAzRjA0Njk2cFpoUUU3WmpJS1doTTFE?= =?utf-8?B?SDE3ekVOd2dNK1I4aERpalY5bm84a1hSUDFkeVpzM2FBWXluUE15bkhLYkpU?= =?utf-8?B?RVQ3UFcrSHBZU3M4ZGFkS3BMRW1Dcjd1TGI4ZktIT0MxOGs3WG1nd21kdHU4?= =?utf-8?B?SUVreXMrQksrOG5DdFcxRllDbHVSRGNVTVBmSUw4QXErUllBejJ2ZEZ3c0x2?= =?utf-8?B?TVdLMHVCaktXRC9QUTlPTjFudlMySlRlWDdvM3l3TjYyK1BJaW15ZVZidHhM?= =?utf-8?B?NUk1WTMxU2VkRTVTYm12RUdZNDNzVW9TdGlqYk0zTUdiUlhGYzBuNVNMVnlB?= =?utf-8?B?b3lyaVRLY250czRja0ZxbjhHSlBSNGNJQS81WHllSXlmM0JFN0VLZDZwMDRq?= =?utf-8?B?eGg0ekxSN3g1VUNuZDhWRkJncVp3R28zNnZSQ2JiN2dhTU5JRGdoSjZuWXc0?= =?utf-8?B?WHpzcWtXb08xSHJnOWE5b2ZmRDJsejJCYktMZnVYS0ppQVBSazFmUUU3SjRh?= =?utf-8?B?ejhyOWRFbFY5bGUyR0hBSitob3lmMmxQTjVZeXFPRmtKUFU4Q0U1WnhOZG92?= =?utf-8?B?THlMQ2t5ZHZXMWsyVEt3eFFkbXgyWUNhZnVvVmNKQ0lEekE5dTUvb1laUVNw?= =?utf-8?B?NGI1amk1OHZZZU5NOW9UWFFPR2swdkpHVTNmcUl1dDdZOThlL1ZyMlU5blZC?= =?utf-8?B?eU9IeXQ5N2dXTzZHTWtVUGdNUC81UVdBREt1b2lKUVRMVHVKRGg5aWczVGtt?= =?utf-8?B?elYzU3JDTlE3WFdCOXBFRFROZGs1b0JYK3N3aml3TURRZzBUU25EQU1vWTJI?= =?utf-8?B?eGQvMnlGMklKb3FSc0dwQVhLendycDYzUW5JdjU4bGhzZm8xVVV1ZFhSNGVz?= =?utf-8?B?NksrWTFXNEpwU05FSlNGeGZEZzN0K3lTQ21jVU52Ym1pNnAxVFRjYnRndDA5?= =?utf-8?B?RHFVZStTa2xiY0J2eTE2eXkrbFl0a1JKOFMwdnF0cDVnTHNudVJ1RVNPKzdD?= =?utf-8?B?TkFqTnRWMzVNRS9oVW9IR0phb1hFRWJzL2pLQ2kwSCs5dkRULy9KSzk0Q0Uw?= =?utf-8?B?bDBpMGY1dFlCeWxxL1d3QVo2MXhtL2NCYjZrUjk1a1pIa1pINXVKdlkrLy9k?= =?utf-8?B?VmVXc240WVgvUnJ5UFlJaUpKaVhEMGNZNlM0YUwrL3JpZERWQXBnTUFRc3Bq?= =?utf-8?B?eklhaHAvYzBuL2R5MjU4V1dCVmpleDNVTWN4SlR5YXd3MCs0czRlMjBFK1Yz?= =?utf-8?B?RG82TmkrYWI1L0hWa1lLT1VaNzg2RTdpYXdaUld4cHBwOU05QlFVaGt5THIv?= =?utf-8?B?eDdnZ3hibmtEbDh0dWhvcUFBdzNTTW9zSDcvdlc1YUFBN2RWck5MVFZMSDFa?= =?utf-8?B?dDdsTWJtMXE0MGhvV1pVZU1zbnBVQjBLWlJnRmFiQUh5cDZPMzROQjVGaktS?= =?utf-8?B?Q1E9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f6f9143-42c0-4d7f-9f94-08da5b6408ec X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:17:23.2178 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JZZAUZth4xT0SnvsnTp5k3+H+xpBrCNIyFy76SpYozpiQOefHAg6OFRv/qy6ym6qBbNXM6W1OTbhw3nfp0RmAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5693 Add support for enabling guest Bus Lock Detection on Intel systems. Such detection works by triggering a vmexit, which ought to be enough of a pause to prevent a guest from abusing of the Bus Lock. Add an extra Xen perf counter to track the number of Bus Locks detected. This is done because Bus Locks can also be reported by setting the bit 26 in the exit reason field, so also account for those. Note EXIT_REASON_BUS_LOCK VMExits will always have bit 26 set in exit_reason, and hence the performance counter doesn't need to be increased for EXIT_REASON_BUS_LOCK handling. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich Reviewed-by: Andrew Cooper --- Changes since v2: - Subject/commit log adjustments. - Simply logic given bit 26 will always be set. Changes since v1: - Adjust commit message. --- xen/arch/x86/hvm/vmx/vmcs.c | 4 +++- xen/arch/x86/hvm/vmx/vmx.c | 14 ++++++++++++++ xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 3 +++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 2 ++ xen/arch/x86/include/asm/perfc_defn.h | 4 +++- 5 files changed, 25 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 56fed2db03..d388e6729c 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -209,6 +209,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_virt_exceptions, "Virtualisation Exceptions"); P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); + P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); #undef P if ( !printed ) @@ -318,7 +319,8 @@ static int vmx_init_vmcs_config(bool bsp) SECONDARY_EXEC_ENABLE_VM_FUNCTIONS | SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS | SECONDARY_EXEC_XSAVES | - SECONDARY_EXEC_TSC_SCALING); + SECONDARY_EXEC_TSC_SCALING | + SECONDARY_EXEC_BUS_LOCK_DETECTION); if ( _vmx_misc_cap & VMX_MISC_VMWRITE_ALL ) opt |= SECONDARY_EXEC_ENABLE_VMCS_SHADOWING; if ( opt_vpid_enabled ) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index f08a00dcbb..853f3a9111 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -4065,6 +4065,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) return vmx_failed_vmentry(exit_reason, regs); + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) + { + perfc_incr(buslock); + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; + } if ( v->arch.hvm.vmx.vmx_realmode ) { @@ -4561,6 +4566,15 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) vmx_handle_descriptor_access(exit_reason); break; + case EXIT_REASON_BUS_LOCK: + /* + * Nothing to do: just taking a vmexit should be enough of a pause to + * prevent a VM from crippling the host with bus locks. Note + * EXIT_REASON_BUS_LOCK will always have bit 26 set in exit_reason, and + * hence the perf counter is already increased. + */ + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 9119aa8536..5d3edc1642 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -266,6 +266,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_ENABLE_VIRT_EXCEPTIONS 0x00040000 #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 +#define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -345,6 +346,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_XSAVES) #define cpu_has_vmx_tsc_scaling \ (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) +#define cpu_has_vmx_bus_lock_detection \ + (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) #define VMCS_RID_TYPE_MASK 0x80000000 diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 8eedf59155..03995701a1 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -159,6 +159,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) * Exit Reasons */ #define VMX_EXIT_REASONS_FAILED_VMENTRY 0x80000000 +#define VMX_EXIT_REASONS_BUS_LOCK (1u << 26) #define EXIT_REASON_EXCEPTION_NMI 0 #define EXIT_REASON_EXTERNAL_INTERRUPT 1 @@ -219,6 +220,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_PML_FULL 62 #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 +#define EXIT_REASON_BUS_LOCK 74 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index b07063b7d8..d6eb661940 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 65 +#define VMX_PERF_EXIT_REASON_SIZE 75 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -125,4 +125,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") +PERFCOUNTER(buslock, "Bus Locks Detected") + /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.37.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 13:17:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 13:17:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359011.588414 (Exim 4.92) (envelope-from ) id 1o7GWk-0001r8-Oj; Fri, 01 Jul 2022 13:17:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359011.588414; Fri, 01 Jul 2022 13:17:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWk-0001r0-Kh; Fri, 01 Jul 2022 13:17:42 +0000 Received: by outflank-mailman (input) for mailman id 359011; Fri, 01 Jul 2022 13:17:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWi-0001Gx-Ab for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 13:17:40 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e244dfb-f940-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 15:17:39 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2022 09:17:29 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5693.namprd03.prod.outlook.com (2603:10b6:a03:2de::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:17:28 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 13:17:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e244dfb-f940-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656681459; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=8A6mMpiAtEs95ebuuIuu3RfOnwZwU0MXepuodOMBbbQ=; b=e+ULIG6lvZaGwERNvUKInyDrz0Wn3dV8WpP+9EidCOsdcuPuoq0ZNpdp viNAfPukG3j2BhhV7cfr4y71zXsKxV86s8cdLOQBSOdFanpY0aa6es0lc kO0X0axb7Ye7KvD/IakPurvST6bnyFeaR9jnwUA1UnxuYGWkHXix/vdOl I=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 77459733 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gBjWUqM1GsVv/pjvrR2/lsFynXyQoLVcMsEvi/4bfWQNrUpxhDUAz mBJDz+AM/jeNDPxedhwbty+pkJTusXcxtY2Ggto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFUMpBsJ00o5wbZm2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zz 8xCnpKZEQwTZKzvvrwvDgJyNn8gMvgTkFPHCSDXXc276WTjKiGp6dM+SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaHP+iCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/32SWiImID8zp5o4IF51Tt4T5o1ITdG+jsIsO7fpRuv3aH8 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo+S/zEi3WNtdK kkd0isosaU2skesS7HVXBCmoXjCoh8VXfJRFfE37EeGza+8ywSTC3UATzVBQMc7r8JwTjsvv neWm/v5CDopt6eaIU9x7Z+RpDK2fCITfWkLYHZeSRNfuoa55oYukhjIU9BvVravicH4Ei3xx DbMqzUig7IUjogA0KDTEU37vg9Ab6PhFmYdjjg7lEr+hu+lTOZJv7CV1GU= IronPort-HdrOrdr: A9a23:fLfXIqrc3R4zDwMcR4h15OIaV5u5L9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssREb9uxo9pPwI080kqQFm7X5XI3SJzUO3VHFEGgM1/qH/9SNIU3DH6tmpN 5dmstFeaLN5CZB/KHHCWCDer5PoeVvsprY/ds2p00dMT2CAJsQijuRZDzrcXGfE2J9dOcE/d enl4N6T33KQwVlUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZozU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDm1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9UfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWz2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp gjMCjl3ocWTbqmVQGYgoE2q+bcHUjbXy32D3Tqg/blnQS/xxtCvgklLM92pAZ0yHtycegA2w 3+CNUYqFh/dL5pUUtDPpZwfSLOMB2qffvtChPkHb21LtBwB1v977jK3Z4S2MaGPLQ18bpaou WybLofjx95R37T X-IronPort-AV: E=Sophos;i="5.92,237,1650945600"; d="scan'208";a="77459733" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NSRklMghoq9XNjdSoQhX2hfgUq/lsn/ps0vXfh+8298O18fCdElosb0kDaEln354JAZ/QKZH8R7jXSyrueGNh3t+werTQY27Nej3i5eiirP5MkM2CtuNZbLwzSQi0ejxGSMs10O7rl7Yr0dgN1Y8U3m6fyXo92+oijCHwGeL1h81a2006Lovk67FIMyyJopgfgRg0jP8S4bVJ7Ejxi+GArDM6fxbk1rU0CK7JtY3Ie+XOOrJf+jRjSsT4GpVfpSDh0hI5b3a/ySoQQ2X5v3XisT/YhqM6AptAL9GsmbD72UmdEwv/cb9PyRY9OmX6X1Da2jpIg/E2D27VryWpSFHPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rn5TihX5txPM3x8yme1vJvTud7aZG2W6LAevjhvIeRU=; b=K1kEbnZh46kM8EYn+s+VUNZYORr5D54G9vnHf6K0UgVzjvhpWyQWlpH2eQuHDlmGMJAOHycckNHKzohizxS65Dp5Sepv7IaX27zIgmUH+jUu/jNLs+4w7e20azwNG5pGxgn/b99sy1OqFYauFlWhAfyBh2EPuu640cc/c1STSAtO7cHlfYGoLOauVUF36gIW1+7xSwQ/sH7KhzBSXtpEDGYgXddgRczmLeWcWV+FrLP0Uk7d4fQ1K/+pWQLIpxkqob/qUacAApg0jbUageL2R8+rPCsdK6iKNomOseZ9eMdb2hdyGyGkI94IuLGfMZ2PooqautLDHM7dAhr38YFaQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rn5TihX5txPM3x8yme1vJvTud7aZG2W6LAevjhvIeRU=; b=LOPbLXpVjDYUx2W2bX8z18PnCqrUfY2lmyKWa0+5d5fc+9gKM2Tuoe50Rej5HXWufeHCHY3zIZyb1pXNN8XZp0DIgSeLob1DviuVKS9Dwj24lJYFQMwbHIpMG4VKQCD8HF5FFZod078P62B517Xw/atLBTI2llZtxDxM6Te9PdU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , Wei Liu Subject: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI Date: Fri, 1 Jul 2022 15:16:47 +0200 Message-Id: <20220701131648.34292-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220701131648.34292-1-roger.pau@citrix.com> References: <20220701131648.34292-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0549.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:319::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01d7383e-26f5-4033-feec-08da5b640bba X-MS-TrafficTypeDiagnostic: SJ0PR03MB5693:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WREmhcfegOPbmLOyDUhQyQFBNdf7lofqAdzrad4OM89LT5+ZnErxbfg3jk8RLYSte6tuX8XxXS0I/WoUx3zpVY3OaUuGuWtKtycXlPZETaZenEKTibu8bELfDN9XteQLgEpVD/7TYAnIl6OmpJx1gN0De2p9zzaSzWq2A4mdNkupydNnNK7rCLuWmapZkpZB202VHe8HnWoQoDJxFyXur3xzm9rv5olvphuva5LBRZKg4Twz3j9nDSXUa80mBSYpRwod4+A+AprLi8LM6ngMtBGGQRVxeKJ/LKjkFmmqUvj6uk64J+pOQ39MPqlicUVS8voIRhjXpRg3XruqIKQARDLQfBmXFCbKJULhN6w5ngh3OJmbQQoMiaxZKJKv4NfFWD1wIPPTbPlGAA5q6U97BiVV7/FFqOpH7LVO8rS2gamoCCQ9j3Gg4qrU00NMIvb539erIVlqt/3YWDHdWY3SYhUwnFD9/238Me0FgIeHjaHrcLco5p+fy7wTRb6dQM8RmNGqPZujckiuvMbLvUgTP1SOmQC/XpeZemeYciYDm9znAW1KFp0q2wi6xY0bscdNm6zuUcPM+DphIjGjJRq33TvpmgKT711j8r2vOhqlEMBTvnisRUB3gUJWphQ9UVOCg45AEf/LcC4TEKfMVBMqx2JgHMqFDK/68biNqK1DNVr0kY0rL5eRGwAoAMh6ueCSSarG06YyiG7UFpBVza8BB7FPhRq7w4U26ayl80zysSupiBBg4eJL0xG0YcOI4LKj/MbC+b8EIhYaG/XiM7H3eQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(38100700002)(66476007)(316002)(82960400001)(54906003)(6916009)(8676002)(66946007)(4326008)(66556008)(2906002)(478600001)(6512007)(186003)(41300700001)(6486002)(1076003)(6666004)(26005)(36756003)(86362001)(8936002)(83380400001)(2616005)(6506007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWI0QjZRczVBTXp3b3RjWmE1RWJzbitaSWp6bVAycWpyQVBSVVdKcGxPdVov?= =?utf-8?B?bTd1eWwwUUpob3JaMkNHSVcxdzFCcSt4bzZNMzBobmFDblFPUkdlWXYveEZi?= =?utf-8?B?N01XTmtZZ0FwdC82SytvTnlTZjBFaXhING9SMmdCcjJtUnNFbDNhRUxTdGJ5?= =?utf-8?B?L1FjRGJXWmtvQ0p1aTg0dkZIZktjdzNnV1RvWWh2TlorKzBjVUpZUFpDenY2?= =?utf-8?B?S1UzOTFMc3hkMWFSWkxuVmdCZlVKeFkwZ3NKSjdPQjBZbGtzUTJ6SldVYXlY?= =?utf-8?B?blVJNU5KZmFFSGVROGRmRVFqYlI3c2dFMDZKTGNxdkJYZ0t3dlBkaU82ZVQx?= =?utf-8?B?akQyV0VjQXBhd3B5QWdnTUw3S0Nab3FEdnJkWTlhV1pidHpEMHFEVXdaUGZ4?= =?utf-8?B?RE9RdHpJa2dXRkVxNndnY1Rhak9Hbk9Ob0FZL2RWTTBPVHM5cVZPNTRrdnp2?= =?utf-8?B?K2pGMUFWUnhYcm9tb1FBYjhpcFZzRlhDQngyWnhrK1VSZWZkcFlFSEgxN3pF?= =?utf-8?B?WW9rajNRNC9jN3JCSlptR0dMQWE5TmpMQUdJZ1RnZVNVSENlaVpvT3MramRz?= =?utf-8?B?OGd4TGl2SkJaak1ZNm5rZFRVL2k0QVRvS25lSFRvTi9JYU9XUWtCdmM5N2dG?= =?utf-8?B?TzlhOGJCV2JiSHVrelpWZVNSNjlTNzVQWUJvZm0yNlNEc3J5YjBENEV1SVlH?= =?utf-8?B?cnpIazZUN01Da2UxNHlXUnl3STRYQUxvLzdYbElaRWsvblo5U2FCZXowWW5p?= =?utf-8?B?a2F0anp6Vjl5V3hHV3FsdEdURlQrcDl0eTl5c2VJb0tDSG1EaTZrR3l4cHkw?= =?utf-8?B?cElGdEQraTdqbHdrdjY1UWMrcmxCRTREd1ZQUzd3Y0o5S0dWMmQyMDNrZ2ts?= =?utf-8?B?ZmZoc3RySnpCQi9QdDZkUVJ2eEY2UFlkUFJJbkkvWVZhT3YwRGgybTN6K2lT?= =?utf-8?B?b3YybW5pZzdhZmNCaVlwOE1HS1NvdGhnUVU1WWl1OEpMc05EeVloWExGdFN2?= =?utf-8?B?ZkU2bGI4VmRzZk96NFNlN1B1K3pXcXVhTWZIN0Ewa1BEdy91QkRxZHBrSVFh?= =?utf-8?B?ajR2TXJtMUsvQXB6Y1R3VDVKVk1TQS94djZaYWFiQmtEN2N2ajh4eTYzalVX?= =?utf-8?B?UXBmWXRNR0N0b3dJMG1RWnkzS1N6RDM2M1U3UmFMd29tY2gyNnBKN1VzOTdQ?= =?utf-8?B?YTRQR3htRVd4QTJxSmJMQi9ZT1U3NGFUUDMzVVBwdE5KNjlva2JXMXRuRk4r?= =?utf-8?B?VDdaTlVCcTdJNHdzVjBjZGRuWUlFRjJiY3UxOU1rMmw2eE51Qm5ocmZ0NVh1?= =?utf-8?B?R0V2YlIrbFJYMXBjd0RPTnBDdHEyTFVqNURNc1ExanpQSEVXbUtYTXQ4MW4w?= =?utf-8?B?R1VaYnA2NEQ3Q0NIOEZvdG52OHZGbHY5NzU5ZVpYeVd3dnZ6MTJvdnhPdEds?= =?utf-8?B?Z1Y1d1Bobll6ekRkSFJXcnF4MEt5dDhLNFNFZUsyZFd6bWhaTHRxR2pHMW56?= =?utf-8?B?NlFoM0t6bFRBMXhoZUJaT3RjcVRYbDJOQTg3N1pscmRwWkIvUkZQVzQ2OXNk?= =?utf-8?B?aGpycnFDTG15VUNKd3dpWElRSUJ5aU1tOE9TWUZ5dENuQ0t1RDJSZHBvbHBN?= =?utf-8?B?UHdxR1h4bG81WWhteTJremFGbVV0bVJTZmJmN1JGY1hDTGszSlBqSVJ6Wjla?= =?utf-8?B?WUNZQXFadC8yNXhsaWF3Y05TanhTT2cwTEs4ZjFrbGwwb2VmK2UvMHpJSFIz?= =?utf-8?B?ZXZ3Tzlzclk3QlhSUUlydU80NjB1c3FTNldqYUthdVdaMFhkZ1RhM2RGV01j?= =?utf-8?B?YW13Vmc3R01XRjg4WDZkRU51T1h2RTRzKzc4ODdCb0owV1ZEUE1qZGp1RFZD?= =?utf-8?B?b29QcU5PMUlUS3dqOUU2UERCazlZWWcrM0FWRlFrNGcwQy9RV3RYcmlTeHNP?= =?utf-8?B?V2tQQk1oNk5OUHZqNHk2UWtYZnNnQWpGU0pTc0d6UjZ6cFczd3hBYUtrc0Vz?= =?utf-8?B?dmdEaDdrZkpLWVZ0cmZhUFU5dC9qc0pKU2dQdHB2S0NXLy85SDFOOHh0ZTF6?= =?utf-8?B?WnBwU0RId0tsZmFXVUhsVHpUbkZvaGRxKzhVUXhGQXo4Mi9CeEJ3VGlTeHpC?= =?utf-8?B?bmJiMkw3YjVERU84Y0YvdkMyNUlyKzNzbFYxR0trZUlUU2pCZ0Rxd2dtMUsr?= =?utf-8?B?YVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01d7383e-26f5-4033-feec-08da5b640bba X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:17:27.9102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t4RpMVSrWOsPRxZiwrBa3RXqECwOxU0rNiXUQV50nEqK7lYnFhqodEVBXMY10xXid8xt+IAm/9NVXbM0QoLK8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5693 Introduce a small helper to OR VMX_INTR_SHADOW_NMI in GUEST_INTERRUPTIBILITY_INFO in order to help dealing with the NMI unblocked by IRET case. Replace the existing usage in handling EXIT_REASON_EXCEPTION_NMI and also add such handling to EPT violations and page-modification log-full events. Reported-by: Andrew Cooper Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich --- Changes since v1: - New in this version. --- xen/arch/x86/hvm/vmx/vmx.c | 28 +++++++++++++++++++------- xen/arch/x86/include/asm/hvm/vmx/vmx.h | 3 +++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 853f3a9111..d69c02b00a 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3935,6 +3935,15 @@ static int vmx_handle_apic_write(void) return vlapic_apicv_write(current, exit_qualification & 0xfff); } +static void undo_nmis_unblocked_by_iret(void) +{ + unsigned long guest_info; + + __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); + __vmwrite(GUEST_INTERRUPTIBILITY_INFO, + guest_info | VMX_INTR_SHADOW_NMI); +} + void vmx_vmexit_handler(struct cpu_user_regs *regs) { unsigned long exit_qualification, exit_reason, idtv_info, intr_info = 0; @@ -4134,13 +4143,7 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) if ( unlikely(intr_info & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && !(idtv_info & INTR_INFO_VALID_MASK) && (vector != TRAP_double_fault) ) - { - unsigned long guest_info; - - __vmread(GUEST_INTERRUPTIBILITY_INFO, &guest_info); - __vmwrite(GUEST_INTERRUPTIBILITY_INFO, - guest_info | VMX_INTR_SHADOW_NMI); - } + undo_nmis_unblocked_by_iret(); perfc_incra(cause_vector, vector); @@ -4506,6 +4509,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) __vmread(GUEST_PHYSICAL_ADDRESS, &gpa); __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && + !(idtv_info & INTR_INFO_VALID_MASK) ) + undo_nmis_unblocked_by_iret(); + ept_handle_violation(exit_qualification, gpa); break; } @@ -4550,6 +4558,12 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) break; case EXIT_REASON_PML_FULL: + __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) && + !(idtv_info & INTR_INFO_VALID_MASK) ) + undo_nmis_unblocked_by_iret(); + vmx_vcpu_flush_pml_buffer(v); break; diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index 03995701a1..bc0caad6fb 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -225,6 +225,9 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) /* * Interruption-information format + * + * Note INTR_INFO_NMI_UNBLOCKED_BY_IRET is also used with Exit Qualification + * field under some circumstances. */ #define INTR_INFO_VECTOR_MASK 0xff /* 7:0 */ #define INTR_INFO_INTR_TYPE_MASK 0x700 /* 10:8 */ -- 2.37.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 13:17:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 13:17:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359012.588419 (Exim 4.92) (envelope-from ) id 1o7GWl-0001vH-3V; Fri, 01 Jul 2022 13:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359012.588419; Fri, 01 Jul 2022 13:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWk-0001to-Va; Fri, 01 Jul 2022 13:17:42 +0000 Received: by outflank-mailman (input) for mailman id 359012; Fri, 01 Jul 2022 13:17:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GWj-0001Gx-Pd for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 13:17:42 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ee0522d-f940-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 15:17:40 +0200 (CEST) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2022 09:17:34 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB5693.namprd03.prod.outlook.com (2603:10b6:a03:2de::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:17:32 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 13:17:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ee0522d-f940-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656681460; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=0omOUGZG0MPXdSjwuGFLu8AUGMlZjA/7LbWh/A0gnYs=; b=OBsnOxy2BZwCQRF1QNOlvP6drVTgjF1GcDN/hREOaRWrLXSYgsKGytXg f+3dxDCENKipAMbTy9SI556Ej4iEf09Ib4ytRskzFXJ8E2dxHODbz97tz 0FJId7+k3iN8mwCjw6w2l8BZNIsZFXAgt0pqxNwLe33P8HyoYhrixsC6n Q=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 77459749 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eioNzaMsIKVO8RzvrR1nlsFynXyQoLVcMsEvi/4bfWQNrUp0gmcHm GAeXWzXbPjZMTb2f9pzaNjk9koBvMTXzNYySwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFUMpBsJ00o5wbZm2tcw27BVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z9 vEXuKO6eQwVGYrpwe4sdid8KGJ+IvgTkFPHCSDXXc276WTjKiGp6dM+SUY8MMsf5/p9BnxI+ boAMjcRYxufhuWwhrWmVu1rgcdlJ87uVG8dkig4kXeFUrB7HNaaHPqiCdxwhV/cguhUGvnTf YwBYCdHZxXceRxffFwQDfrSmc/32SWiImIE+Tp5o4Iy41n8xTxX/YT0c+rRSueWQdVErmWx8 zeuE2PRR0ty2Mak4SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M FEP92wlqq1a3E62StjwWTWorXjCuQQTM/JLCPEz4gyJzqvS4i6aC3ICQzoHb8Yp3OcpQRQ62 1nPmMnmbRRtrbvTT3ue/7WVqDqaOC4JIGtEbigBJSMG7sfipscvjxvJZtdlDKOxyNbyHFnNL yuiqSE/g/AZi54N3qDip1Tf2Wvz+d7OUxI/4RjRUiS99ARlaYW5Zouur1/G8fJHK4XfRV6E1 JQZp/WjACk1JcnlvESwrC8lRdlFO97t3OXgvGNS IronPort-HdrOrdr: A9a23:EvGlgqzjy0qrT6tycEF2KrPxvuskLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9wYh4dcB67Scu9qBTnhORICOgqTMyftWzd1FdAQ7sSibcKrweBJ8S6zJ8l6U 4CSdkANDSPNykcsS+S2mDRfbcdKZu8gdiVbI/lvgtQpGpRGsRdBmlCe2Wm+hocfng6OXN1Lu vU2iIBzADQCkg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iosKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6N2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCulqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv60vouqhNDqWs3N 60Q5iApIs+MPP+UpgNdNvpOfHHbFAlYSi8R156cm6XYp0vCjbql6PdxokTyaWDRKEopaFC6q gpFmko/1IPRw== X-IronPort-AV: E=Sophos;i="5.92,237,1650945600"; d="scan'208";a="77459749" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ReuKeZRBt7O51zsw0jC4DY6aYrdLzVVyOFeZcUe0aVcCpP+92In5t/rJJ8MHkdwwq4gHYyTCg1/ENAFoLDq4rf3eqbY6xcYoLkZyN2DzgEQkqBQ7tt8EAPMZcACRg/ynAq+ubW98r7AoyTqsBnSNuoP04gonvTkfOMVqxVyUb+K9XhCQ1BCxV2gRgH9RVj8Y7yuF4J39QSkJaYUDhVKiZb15RcLYGwaFXnZLYQiUnS+MHIpUELFGbW+MAfmCpGzAyswJji167uV/SYKlHqTuIAJAQdQhNlOfpfpBs4E7sXhUGiTPNRldjyUMyO4s7vGmaWT3CxADrPgIYcZEnzTCtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CW6nJ57YZtfgzGmlQ9Sx8B8maYRi3jIQc6etWHDX3v8=; b=Efuhz+vHf/TpmtG5wNfgSzjAZbM8eDqnkCB4B2sFXEO0ENtr/upFTN+lQc70jh1oUqGMTaWYAzLQQzEI07d3kY/DHPL+bVx+rcmgA0Kdz9qnKEGXSRxCw8mDj/iJAn3jA+Ak0wBI7Qif6/bwoGMorulZZc+y4+K5eRcx87lE+Ac2XTdS1uAf4CtK7l/gdgrbybsVRIPIgAyMmFAa9sEv9AI2mn7IHYBARRPNmwmZk7mYvoS6UpAyd6a595NtEsqd9wWJDSgZWjUenudhYsG8sdfTaeKjUue+hxwoXkE07UxkiW57XYLpzrPzDg8hB874gW4A4gYA7NKdUw528cVXYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CW6nJ57YZtfgzGmlQ9Sx8B8maYRi3jIQc6etWHDX3v8=; b=nmc2bpWvaYHT1kc3k7SJjBkIrNxdOJhZaVtZ1PBr1MDy1STVa94SPt10Q6ZZw9d3CamOyeqjMmgGzhpf4nVsS0V2rypaMtr04U7y9YTeZ0JDwNOOFgc6FisL+s9SFRL7jhTUtwvdA7U12OB1rKWX6dwzZBzp0P2ckPL6elmfCDg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; From: Roger Pau Monne To: xen-devel@lists.xenproject.org Cc: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Jun Nakajima , Kevin Tian Subject: [PATCH v3 3/3] x86/vmx: implement Notify VM Exit Date: Fri, 1 Jul 2022 15:16:48 +0200 Message-Id: <20220701131648.34292-4-roger.pau@citrix.com> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220701131648.34292-1-roger.pau@citrix.com> References: <20220701131648.34292-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0101.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bc::10) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a35f3e4-1e7c-4350-ecf6-08da5b640e83 X-MS-TrafficTypeDiagnostic: SJ0PR03MB5693:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RWt29pNxJ9ZULGWZkskAAV/0k7Q+RsllYmmuFOhsietYK0vhhzActlB82iwEBbCj8YZ3f/InLJuJ7/qv5rYNCrNyQch0N7gMnTvHAPGFf26g2GsRTMWALwhRxs6YZfWtiisv0QSoeBkWqkODUG5QXw6gY0rC46W1M4y8rvP0Y8uP9/yZiPRaPTl+i5ldKfHK1yhEskTvGRaSRL+++nZA3tLt3M4s2KzDHDnR33uDkm85D8+RFC3Yn7Ic98Ski6p6RAbyIuZNCxOH5a6Qi3iQ1ODQdBFN16tWj5Acmo160hk+ibsGEeGz0rl+zDkkK0ZukCoxD5Gec6iuqw4gbQs3konQrYabFnNw7Mp5mdIf4CVfIEDVM9jwxK8Cm4RlgZlyIVwWgLbxE9YEnxFW9znGAlA7uGh9srJNijTMa6ZiLSe33LGRR6C9uOMTnXyG5d6dkyT6nerP15nrLYIWk3MVafUmRoctb6cUZwH/7hc4/1U3AVLCo5FO78CRjlTyLXl3ROsCz0/Ner5tkhu0/ecTmj0xiVn+rXfrciF7rbDOLgxKiNgyNGlXBBT7FTK9QmJlbz8J89qFDyNzzoKpLD0fGn4/iCtx4MKpFygioXR3PhN3Ch99xte8I3GvFYCXMDdt3hnLqyky2Yx6zVabHL9ZDAqI2EU3yX8/7wvalcr6rmAcjjrWsvhgKcxnW+s5UxmEgWF4zfLcsPu5L989A8BK3jtf4sickkGDh1dYb20f3Jn28iV5bK+hTPYejdxKiJ7DKFhrmkFu1KP7T/6PCEKSfubY4dvoDiY7DSj5eZl1KOo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(38100700002)(66476007)(316002)(82960400001)(54906003)(6916009)(8676002)(66946007)(4326008)(66556008)(2906002)(478600001)(6512007)(186003)(41300700001)(6486002)(1076003)(6666004)(26005)(966005)(36756003)(86362001)(8936002)(83380400001)(2616005)(6506007)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YThYcDY3VUxML3NCTHhIMXlPK1NMc3hETHlCQ2Q2bVRUT2ltQ3piZm5xUEs4?= =?utf-8?B?RGlEaHQzQTJYMmduUldERnZJU3lXVjFlNTJOaE1QUXlKMWRMbnllYW0zZDcw?= =?utf-8?B?UGtBdk5LMWZVVHlDVi9iREtyTndLbHptR0FRT3BlM3RCMVVPSGxQTndCeWg4?= =?utf-8?B?bXhYUWlnNlRGeHEya3hpYXlZRUJmREVIS01WVi9CWmNzeEVaQTJMdzVRblZ2?= =?utf-8?B?QUpwV3dkREtDdWh3L0hRUkJueE5DOEtiVGNmNjRjeEsrN21XbFlGZGduZ0cx?= =?utf-8?B?OUk4TnpyWEhiRjdPYXVMTVZlRzZtUVlld09tT0ozUG9MTHU0TEliemxVVGow?= =?utf-8?B?R1NKekx4L3FPVkhzMjdSMkpkbEdwVktUMmp0YXFHdTlNa0tmOWltYW1waTRu?= =?utf-8?B?eXhaR1pxMlB2QTRkTitaZ1p2a0VXU25MSmVGZlg2U3VZL0xpQWRJQ3hwV0Yx?= =?utf-8?B?UGxJWmZCeGVkYlhwNkRYdmh6VDBrazhXTldXajdpUHlxS1ZJL0k2eHFRU2RQ?= =?utf-8?B?akZ0ZUlmQXhtVVppVU1KbG5vcnZFUk9xd0pPSGw3aEY1cHoyUUIzeTBwNjV0?= =?utf-8?B?ZnhKaFlmKy90MUE1Ukx6TnlIa0JCNDUweDA3eDdLSlNZcW91amFGcDNHUzdC?= =?utf-8?B?SGhWbk1rYThub0JmUjB6djFsaHppVURhQlpMRmtPZ1lOeXhYTzVYaGxWczRP?= =?utf-8?B?aWhGYW50cTM0RllRRW51TE03NUZNWXVWQTFkKzZ2ci9xcnBRK3VmY1liV1pC?= =?utf-8?B?WUFVbjgwTkhPTjN6eUhCUnV5UHZmRVU3T1hlTHF1OUVWbm8vd2VYVVdpVnd2?= =?utf-8?B?QkF4cmp1TDRQMStMNEJGZXpkNDhXZS9wR1hjd2xteThxdzZNSElkRFNxSjQr?= =?utf-8?B?UkZMZGsxOUk2OEZPR00vS1dxZWJ4Y1d2TGV2NmxkcXZpUHhNbWhJS0h0NmFs?= =?utf-8?B?dUp4VUtQYU1QZ2s1K2tZbXNxcWlWZjZYZWlOTVkrRVJoMUhHVmlWOEhOMklB?= =?utf-8?B?dU0wM3ZMMTNNbEpMRVBGNVRidTdSZlJDaVhsQVdEM1ZoZVdhTnNUTEJneWEz?= =?utf-8?B?ektjN1UzQ1NnUjZ5WjJ4cm5IcmhRdVpsTTcxMXJZcGJINFkrZkx3WEdZK1RH?= =?utf-8?B?azNTY2pjeE5KQU5kbnI5QjBvYXZ2QVIySndqSDhSZnBPRmVRQ3loQkNPanMz?= =?utf-8?B?YzlzNWg0UTZ5SldKKzhvcUYxR0gwV01JR2lGRmk2bnYydktmVWNBeFJqZGw0?= =?utf-8?B?MUNFWWc2ckNObkJncFkzY0kreE85NCtTL0RUQ1RRWTNFb1hlS3UyaGhNME5J?= =?utf-8?B?d21SaThzTFNEL0Q1bGpadmpMeVZzc1Y2TjdMZE80cXhkZXVkejJpcHNoTHFL?= =?utf-8?B?bUNlQ2cwYmtYdmFGSVRxK0VzOUhlUGNiZUozenlqQUpWR1RBZEpjbUIxU1M1?= =?utf-8?B?bmtCam1qOXZuc3ZNaFdiSGRVYUxBVHZBc1l6SGJTb0RhajlIYm1DN0ljYUta?= =?utf-8?B?S1k2YnlsK3Ntb20ybjJxMFdDWjZjSHA1bHNoTWdMMTRwZURLa3dLcTBHNTBp?= =?utf-8?B?bnU2QThpVUdydEhEZ0psdll3dWFPYnJTZ2x4QjdNdFdWV0pLekdZZkNZK21F?= =?utf-8?B?YjZaMFhIV1hDVFMzaWwrWS9XNVlWeEtQVlFZakMwZXduNHVleHg3blc3K2pj?= =?utf-8?B?Z1Q2SkNoWVM1VWxrWllJTjVEdzR0ZGdzTlFwd000OE1VWGhXT3ZJVTR0QWpw?= =?utf-8?B?bE56ejgvWVhJSkRoQ241N2dHaVliT2JFc3JMdWo2MDN2Rm94WXFXbFZQRjVs?= =?utf-8?B?c01FT0JqWkgrL2Z0K29NR1p1WUJuc01uTTQ3Um5mMW1ZRloxa2pLNlgwdWNZ?= =?utf-8?B?MVpZYlNtQVl4b0xyWGoweTdDVFJUYWRXamVVZk1QeGlUM0JoeWVMLzZub3VQ?= =?utf-8?B?V256Ymp3ZkoxcmNCc3FOaHpmMmtKK2ZBZWNLdi9Jc3F6R2dyWEFXcDF4R1VU?= =?utf-8?B?ZHZaWkJjMUphR3Z4WURreTlVVllGbjNyLzd5Q05xc3N0dGhoOVQzNXQyOVU1?= =?utf-8?B?RUZGWFVhN1dZb2t0VXEvWGlGMGMxV0N1Mno1Z09VU01TeWVUM2tBNVpNcjBM?= =?utf-8?B?L2UwdFBQakZSb2RKVXNUN1NRZy9OZTRqYXZabHBpczNIYWtVRHdQMS81ejk0?= =?utf-8?B?YVE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2a35f3e4-1e7c-4350-ecf6-08da5b640e83 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:17:32.6449 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FU+6KrV1rwQlJOb5Hglg6UCBvWrXcCUL4oE+nHAfdI/n8ED3UYOIjt6gBz4FSgJ3zXERu81zN6meCRVL8EDbMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5693 Under certain conditions guests can get the CPU stuck in an unbounded loop without the possibility of an interrupt window to occur on instruction boundary. This was the case with the scenarios described in XSA-156. Make use of the Notify VM Exit mechanism, that will trigger a VM Exit if no interrupt window occurs for a specified amount of time. Note that using the Notify VM Exit avoids having to trap #AC and #DB exceptions, as Xen is guaranteed to get a VM Exit even if the guest puts the CPU in a loop without an interrupt window, as such disable the intercepts if the feature is available and enabled. Setting the notify VM exit window to 0 is safe because there's a threshold added by the hardware in order to have a sane window value. Suggested-by: Andrew Cooper Signed-off-by: Roger Pau Monné --- Changes since v2: - Move up the logic to set the exception bitmap in construct_vmcs(). - Change perfcounter description. Changes since v1: - Properly update debug state when using notify VM exit. - Reword commit message. --- Intel is working on getting the ISE updated to note that 0 is always a safe value to use because the hardware will add an internal threshold to assert so: https://lore.kernel.org/xen-devel/3c64db19-00fe-05bf-ac4d-6ef4201b6aa0@intel.com/ --- docs/misc/xen-command-line.pandoc | 11 +++++++++ xen/arch/x86/hvm/vmx/vmcs.c | 17 +++++++++++++ xen/arch/x86/hvm/vmx/vmx.c | 32 +++++++++++++++++++++++-- xen/arch/x86/include/asm/hvm/vmx/vmcs.h | 4 ++++ xen/arch/x86/include/asm/hvm/vmx/vmx.h | 6 +++++ xen/arch/x86/include/asm/perfc_defn.h | 3 ++- 6 files changed, 70 insertions(+), 3 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index da18172e50..272be0e79f 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2566,6 +2566,17 @@ guest will notify Xen that it has failed to acquire a spinlock. , and must be integers. The values will be encoded in guest CPUID 0x40000002 if viridian enlightenments are enabled. +### vm-notify-window (Intel) +> `= ` + +> Default: `0` + +Specify the value of the VM Notify window used to detect locked VMs. Set to -1 +to disable the feature. Value is in units of crystal clock cycles. + +Note the hardware might add a threshold to the provided value in order to make +it safe, and hence using 0 is fine. + ### vpid (Intel) > `= ` diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index d388e6729c..4985d25b85 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -67,6 +67,9 @@ integer_param("ple_gap", ple_gap); static unsigned int __read_mostly ple_window = 4096; integer_param("ple_window", ple_window); +static unsigned int __ro_after_init vm_notify_window; +integer_param("vm-notify-window", vm_notify_window); + static bool __read_mostly opt_ept_pml = true; static s8 __read_mostly opt_ept_ad = -1; int8_t __read_mostly opt_ept_exec_sp = -1; @@ -210,6 +213,7 @@ static void __init vmx_display_features(void) P(cpu_has_vmx_pml, "Page Modification Logging"); P(cpu_has_vmx_tsc_scaling, "TSC Scaling"); P(cpu_has_vmx_bus_lock_detection, "Bus Lock Detection"); + P(cpu_has_vmx_notify_vm_exiting, "Notify VM Exit"); #undef P if ( !printed ) @@ -329,6 +333,8 @@ static int vmx_init_vmcs_config(bool bsp) opt |= SECONDARY_EXEC_UNRESTRICTED_GUEST; if ( opt_ept_pml ) opt |= SECONDARY_EXEC_ENABLE_PML; + if ( vm_notify_window != ~0u ) + opt |= SECONDARY_EXEC_NOTIFY_VM_EXITING; /* * "APIC Register Virtualization" and "Virtual Interrupt Delivery" @@ -1290,6 +1296,17 @@ static int construct_vmcs(struct vcpu *v) v->arch.hvm.vmx.exception_bitmap = HVM_TRAP_MASK | (paging_mode_hap(d) ? 0 : (1U << TRAP_page_fault)) | (v->arch.fully_eager_fpu ? 0 : (1U << TRAP_no_device)); + if ( cpu_has_vmx_notify_vm_exiting ) + { + __vmwrite(NOTIFY_WINDOW, vm_notify_window); + /* + * Disable #AC and #DB interception: by using VM Notify Xen is + * guaranteed to get a VM exit even if the guest manages to lock the + * CPU. + */ + v->arch.hvm.vmx.exception_bitmap &= ~((1U << TRAP_debug) | + (1U << TRAP_alignment_check)); + } vmx_update_exception_bitmap(v); v->arch.hvm.guest_cr[0] = X86_CR0_PE | X86_CR0_ET; diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index d69c02b00a..b372cde33e 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -1419,10 +1419,19 @@ static void cf_check vmx_update_host_cr3(struct vcpu *v) void vmx_update_debug_state(struct vcpu *v) { + unsigned int mask = 1u << TRAP_int3; + + if ( !cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) + /* + * Only allow toggling TRAP_debug if notify VM exit is enabled, as + * unconditionally setting TRAP_debug is part of the XSA-156 fix. + */ + mask |= 1u << TRAP_debug; + if ( v->arch.hvm.debug_state_latch ) - v->arch.hvm.vmx.exception_bitmap |= 1U << TRAP_int3; + v->arch.hvm.vmx.exception_bitmap |= mask; else - v->arch.hvm.vmx.exception_bitmap &= ~(1U << TRAP_int3); + v->arch.hvm.vmx.exception_bitmap &= ~mask; vmx_vmcs_enter(v); vmx_update_exception_bitmap(v); @@ -4150,6 +4159,9 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) switch ( vector ) { case TRAP_debug: + if ( cpu_has_monitor_trap_flag && cpu_has_vmx_notify_vm_exiting ) + goto exit_and_crash; + /* * Updates DR6 where debugger can peek (See 3B 23.2.1, * Table 23-1, "Exit Qualification for Debug Exceptions"). @@ -4589,6 +4601,22 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) */ break; + case EXIT_REASON_NOTIFY: + __vmread(EXIT_QUALIFICATION, &exit_qualification); + + if ( exit_qualification & NOTIFY_VM_CONTEXT_INVALID ) + { + perfc_incr(vmnotify_crash); + gprintk(XENLOG_ERR, "invalid VM context after notify vmexit\n"); + domain_crash(v->domain); + break; + } + + if ( unlikely(exit_qualification & INTR_INFO_NMI_UNBLOCKED_BY_IRET) ) + undo_nmis_unblocked_by_iret(); + + break; + case EXIT_REASON_VMX_PREEMPTION_TIMER_EXPIRED: case EXIT_REASON_INVPCID: /* fall through */ diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h index 5d3edc1642..0961eabf3f 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmcs.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmcs.h @@ -267,6 +267,7 @@ extern u32 vmx_vmentry_control; #define SECONDARY_EXEC_XSAVES 0x00100000 #define SECONDARY_EXEC_TSC_SCALING 0x02000000 #define SECONDARY_EXEC_BUS_LOCK_DETECTION 0x40000000 +#define SECONDARY_EXEC_NOTIFY_VM_EXITING 0x80000000 extern u32 vmx_secondary_exec_control; #define VMX_EPT_EXEC_ONLY_SUPPORTED 0x00000001 @@ -348,6 +349,8 @@ extern u64 vmx_ept_vpid_cap; (vmx_secondary_exec_control & SECONDARY_EXEC_TSC_SCALING) #define cpu_has_vmx_bus_lock_detection \ (vmx_secondary_exec_control & SECONDARY_EXEC_BUS_LOCK_DETECTION) +#define cpu_has_vmx_notify_vm_exiting \ + (vmx_secondary_exec_control & SECONDARY_EXEC_NOTIFY_VM_EXITING) #define VMCS_RID_TYPE_MASK 0x80000000 @@ -455,6 +458,7 @@ enum vmcs_field { SECONDARY_VM_EXEC_CONTROL = 0x0000401e, PLE_GAP = 0x00004020, PLE_WINDOW = 0x00004022, + NOTIFY_WINDOW = 0x00004024, VM_INSTRUCTION_ERROR = 0x00004400, VM_EXIT_REASON = 0x00004402, VM_EXIT_INTR_INFO = 0x00004404, diff --git a/xen/arch/x86/include/asm/hvm/vmx/vmx.h b/xen/arch/x86/include/asm/hvm/vmx/vmx.h index bc0caad6fb..e429de8541 100644 --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h @@ -221,6 +221,7 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define EXIT_REASON_XSAVES 63 #define EXIT_REASON_XRSTORS 64 #define EXIT_REASON_BUS_LOCK 74 +#define EXIT_REASON_NOTIFY 75 /* Remember to also update VMX_PERF_EXIT_REASON_SIZE! */ /* @@ -236,6 +237,11 @@ static inline void pi_clear_sn(struct pi_desc *pi_desc) #define INTR_INFO_VALID_MASK 0x80000000 /* 31 */ #define INTR_INFO_RESVD_BITS_MASK 0x7ffff000 +/* + * Exit Qualifications for NOTIFY VM EXIT + */ +#define NOTIFY_VM_CONTEXT_INVALID 1u + /* * Exit Qualifications for MOV for Control Register Access */ diff --git a/xen/arch/x86/include/asm/perfc_defn.h b/xen/arch/x86/include/asm/perfc_defn.h index d6eb661940..a710fba8a8 100644 --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -6,7 +6,7 @@ PERFCOUNTER_ARRAY(exceptions, "exceptions", 32) #ifdef CONFIG_HVM -#define VMX_PERF_EXIT_REASON_SIZE 75 +#define VMX_PERF_EXIT_REASON_SIZE 76 #define VMEXIT_NPF_PERFC 143 #define SVM_PERF_EXIT_REASON_SIZE (VMEXIT_NPF_PERFC + 1) PERFCOUNTER_ARRAY(vmexits, "vmexits", @@ -126,5 +126,6 @@ PERFCOUNTER(realmode_exits, "vmexits from realmode") PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") PERFCOUNTER(buslock, "Bus Locks Detected") +PERFCOUNTER(vmnotify_crash, "domain crashes by Notify VM Exit") /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ -- 2.37.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 13:26:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 13:26:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359044.588436 (Exim 4.92) (envelope-from ) id 1o7GfL-0004lM-9U; Fri, 01 Jul 2022 13:26:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359044.588436; Fri, 01 Jul 2022 13:26:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GfL-0004lF-4x; Fri, 01 Jul 2022 13:26:35 +0000 Received: by outflank-mailman (input) for mailman id 359044; Fri, 01 Jul 2022 13:26:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7GfJ-0004l9-V6 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 13:26:34 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00069.outbound.protection.outlook.com [40.107.0.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6bcf034f-f941-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 15:26:32 +0200 (CEST) Received: from DB6P192CA0016.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::26) by AM7PR08MB5416.eurprd08.prod.outlook.com (2603:10a6:20b:10e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 13:26:30 +0000 Received: from DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::27) by DB6P192CA0016.outlook.office365.com (2603:10a6:4:b8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 13:26:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT008.mail.protection.outlook.com (100.127.142.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Fri, 1 Jul 2022 13:26:30 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Fri, 01 Jul 2022 13:26:30 +0000 Received: from 6a83de522ebb.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C87525E-E9E4-4009-8968-9FA61688A849.1; Fri, 01 Jul 2022 13:26:18 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6a83de522ebb.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 01 Jul 2022 13:26:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS8PR08MB8158.eurprd08.prod.outlook.com (2603:10a6:20b:54f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Fri, 1 Jul 2022 13:26:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5373.017; Fri, 1 Jul 2022 13:26:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6bcf034f-f941-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Vf/zpFKEw+N/1ikkPDYxKoSkKpapxlAVVCJzNW/ke47zhn2vaig0eaiBzR2i6mh1BLMlupjol7aWuRbWnLFuBqxPKGhk25eodsp9u8CKOxppmUFN/y065HSMFFyfxLQye1xYfdbNfDDwff1EX4ZNyz7ABmJBXqCXmJeNFMI4t6xeWrU0iMtPukCCew9W3K8s5BH1siuBuvNCm09RnYvWwfRT99YxRWUJPeWmvc87KUWQLVmt5BzTVGYVOhK97jWX7TS9tS183PKRwPB4tgu4T36KDFi9nnhEtYq1tx4RLKAWn6cWTwFsWcacV45l4rBTsuTHK4Nlj410Zb1ZoXX15g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XD1r2363ZMcUMyaSlz47vbHfCLXF3PDOIa2qfMikFa0=; b=mD+vUiz2aolIICRyLy6/TSRFjVXmKOrsh7G07Tw9+5S0XyFDf4bkRu/1/w4f7v5HuT6KjZml/dhSN113WLhJw5Ix85zDRczqtHxILprFeTNE4ptDE1LM3xpQuBh48ftT8pVLwDVUTKcsq83+ISbH7c3EFeDm9/1oHD6f7KdJlsMWiiaI5p230a6D/L17rD7EwqjDcyvRphcOWci4vjXczmTdSdEWe+jMbger0bI12fjP4OiIT39/wPy9A1eaZuxnGOrDfETP93UO3NEtvrBf1eFBff0cvMFW7zKXjuFfzyAGwiYiWAZfuq/JUN+FO0rPoDURlizhSULGfLMCKFbpTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XD1r2363ZMcUMyaSlz47vbHfCLXF3PDOIa2qfMikFa0=; b=sWyOgZth/qjQfTPClQkRcxPt4kzO3wcXmdQKvqvmECiWI31RhpTDSv38VzF2UnwtwMh/q0+GmZYddiRez2yWhnWj3pj984hpdrvLRze6T4wu/2Q4MOH+uBxzT7Iw4KqwlTjyFnfexWvmVoy76WHUvfm3EAv9V38LyXYmsd6vT4k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c2ad9bf90fc1ecb7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ECjL+wO3/NYj80q7wKOWrFniNVXBKUbW8tzADRiI0t5DV/lFXdrgGeQtrYqbL9y3i/D8ER4FTMUbgVZlvdUv3gvk6rfATywIc3dxIhpvLtCfYw/BV1xBYacoOkR/oqNlRHEgQb0Um8CFGAoXyUZoMlWYVfLWn53iEy6V3X3r7XcX6DvyhKu0V7nOoKIwD7/+u8DQIfkwAVjbZC7zyE1SjCmSzk0/F2M84N66VXKwaVzLNg69OEe7t5eJ4F19OcAZ3fcQpgnyLFT4rrbeaqvpHOly9rorvRPwNjhKigi1aTSwUYnkxakhkbHsnq3mpomQ+Sw8qUCY6KIzt6mB8+ThQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XD1r2363ZMcUMyaSlz47vbHfCLXF3PDOIa2qfMikFa0=; b=LNL1hFkg5JVFtQg76Lx0k8x6YHhVw4u9V0xdi5PFkar+Tqt6xQpL2wvXP8rQP+mt82MbbZjgvKbigfgpGZttOEF/EuGJ1+VARZ7zaY+tm1nLF0jJWEt1YP8E+PyDTabFYlPcZ6+V/7+DGx89/ePjHZT4JtvMIY8yXA4rSGG64+SvQYIffVwujgByVVBjknwyzdl20KoaPsLfkEAW28NEJ9Pnmskw1X8NTCcJFiDtD/FyL7Y7zfg5paN+1Ldv7IYstvbBtaQWoNqXxKLypjqCKYisNe6Fmi5AwUQpnzcHsFKaxqKZod79sr3KFrAJ80eqJBH9PWD2rNTJLNocaADrSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XD1r2363ZMcUMyaSlz47vbHfCLXF3PDOIa2qfMikFa0=; b=sWyOgZth/qjQfTPClQkRcxPt4kzO3wcXmdQKvqvmECiWI31RhpTDSv38VzF2UnwtwMh/q0+GmZYddiRez2yWhnWj3pj984hpdrvLRze6T4wu/2Q4MOH+uBxzT7Iw4KqwlTjyFnfexWvmVoy76WHUvfm3EAv9V38LyXYmsd6vT4k= From: Bertrand Marquis To: Stefano Stabellini CC: Luca Fancellu , Anthony PERARD , Xen-devel , Wei Liu , Elena Ufimtseva , Tim Deegan , Daniel De Graaf , "Daniel P. Smith" , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Juergen Gross , Christian Lindig , David Scott Subject: Re: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else Thread-Topic: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else Thread-Index: AQHYh+S8oo1uKED1kUSSvOK+OMp/V61mHT4AgACMngCAAO3MAIAA4jeAgAESnoA= Date: Fri, 1 Jul 2022 13:26:16 +0000 Message-ID: <8D4E96D0-A591-440D-BD1B-E52D7F2283E5@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-26-anthony.perard@citrix.com> <6CA16D2D-8AD6-415A-A98D-00B27F91C4DA@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7d32bca1-a9e1-4105-0a1e-08da5b654ef6 x-ms-traffictypediagnostic: AS8PR08MB8158:EE_|DBAEUR03FT008:EE_|AM7PR08MB5416:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x9UpPwfxqnM2nnWoXDPAWpaaghKuReb8T/4/srMNPuk43lz+aqugsJmKrXruHQQ4J+AC18Km9Jc6MOKNgoCqAxiVX9YSZ0GYdRDlVGtSHwmCtanNk1z69oKc+26PtmIV/ihS/4jMnRiG+sU4am6SU8SdWLGHRDrFxNhdPeGg/T6LsIk9efw2DIruXmqKQ8IGV85v1S8pJ165vOU8O1dlBYAo92P4AN5FHNd7H2yeBS08Wdk2iYscTQFJLjdHsnmAW4vjRXPU1ND9Z1d0kl4k/k2C0EviY/X4YV4GOV7WNVrpRZv+nawzwDzqH4a1vSRkzoq785j87892N2UDWg7SqxCTSscDjbiqKCg9XG0Dld0pYk9t+EZKalnMhlUrTQSYV8HPnGQ/8QDp9MBLFqsKP/eiE93L55GEX5Ry08wBjXUEWXjm3uwbumNbUa6JpNquHc0EnTOfOAcTXuqZACRkQ6NOieshO/FrMUraki3a3D/aC/zuDzp5roe7GrBjbgM7Jo+I7A+vqoZ5WUw7AJvPrieXoDTfwU9nuXynPrBVYWvtLu7zjh4uVLQj+npq+EYqBIV6cfvMsgEynT2ioG7qI/+O6g/0+8jowBIe5THkNO8jK5coa2BQ+2NnKJHwWSOauhr1DK8SH6QJdMdHAMu+DFaf2uqKILv3+WvXOYTi295QZLdzpWi3zxYixG3o1TUWng0aJF4cOFZw3Xt6hSaMOG7YGDT9vDiBHO6gRc0b8R12I5A196E3jBzJSyaSPmOmfV6LSAcOJ4DD+fT92h4twra+qozFTkSfS6vE6fXt/0NJ8cIRL0PGrRnERyFMvqQH8ZMCjjvnRnFMHDscVHTQtvVH+yx1JtdD9mhdX96VjUk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(186003)(66446008)(64756008)(38070700005)(86362001)(71200400001)(478600001)(5660300002)(66946007)(66476007)(33656002)(38100700002)(122000001)(4326008)(66556008)(2616005)(8676002)(8936002)(76116006)(6486002)(91956017)(53546011)(7416002)(6916009)(26005)(41300700001)(6506007)(6512007)(36756003)(83380400001)(54906003)(316002)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <681AE8BA6551D4479F117C2D3D679335@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8158 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c492bd83-feeb-4b58-26b0-08da5b6546bf X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3dSCA3W/Yfyn64MesWSI//qAx5HKbEN9jiloFATsnOEl/vi1HmUKoB4rhJJNG9WpVPCInYvmsItMgJauLhCT537E3nSAnRdImi0UtQ23ARFJZ4Jts6DWzYH5cJFYXv+S+rR7fTzdljknAMdc3fqWKNX3jHaGQAZI8rZvPXBTT05sUnZbj+IyG/d23tqaABTo5UXC/S2WSzSyo+SFQ+1p79HcpOhvHMKevNbwWR6FGBXbt2uP76E4Y/CFuSbZG9xiH0xsTtYiTPyXjeNsI71CKM6pQp8nJLdTswBiYUiO0n+/pbXvv02ymh5UC6rza2H1b15Oel2NQvGOT72Ecv7MaosuhI+dk3calyYwCNum2ZMVoeS1/ZlbhsGxHkdr9j430d7zohioTqfs+eSIZLGfW3v/iNhtK5ywBUs1keKVmx0VphUXzWPxwzkq467Y1xNi0FGSml2vBRSTUCV3JdxndewXZL2dVQdfq95XHmuyuLVICP4ymafkuxUFCC21dEnGRGOvdDd3nT5iNqWM62wuoF4zqTNcBu1VEgQXApnacvB43X5Oyf5vm9Wz4rYs4UJDhWx7g6rr95b+B3IThjuxTirzTB3HCXL8RS5d7rfegudORyTkNsNjXvdcjXjaV7g6+SDBD2rvtOvSkLEalrz9c6uwMQs6oyv1Asw/2ukSgdFgYUgXa+1lPB6RR7ET970Qfx7int4GNBcl/VLRF4dVRPq9dvgTRCvz7gXRKiqhj6Wnlpzo1D77Qn6AIk//sgqu/zk9SqVBOSgl+cbQL3E3FdzqccHYvKLte7urRllkcZcEYGDMMEzcOdoSNoyjpZrU X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(40470700004)(54906003)(36756003)(478600001)(70586007)(6862004)(70206006)(316002)(356005)(8676002)(82740400003)(40460700003)(33656002)(41300700001)(83380400001)(81166007)(336012)(82310400005)(36860700001)(47076005)(2616005)(107886003)(53546011)(6506007)(40480700001)(26005)(6512007)(186003)(86362001)(5660300002)(6486002)(2906002)(8936002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 13:26:30.0762 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7d32bca1-a9e1-4105-0a1e-08da5b654ef6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5416 SGkgU3RlZmFubywNCg0KPiBPbiAzMCBKdW4gMjAyMiwgYXQgMjI6MDMsIFN0ZWZhbm8gU3RhYmVs bGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4gd3JvdGU6DQo+IA0KPiBPbiBUaHUsIDMwIEp1 biAyMDIyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+IE9uIDI5IEp1biAyMDIyLCBhdCAx ODoyMiwgU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPiB3cm90ZToN Cj4+PiANCj4+PiBPbiBXZWQsIDI5IEp1biAyMDIyLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+ PiArIENDOiBTdGVmYW5vIFN0YWJlbGxpbmkNCj4+Pj4gDQo+Pj4+PiBPbiAyNCBKdW4gMjAyMiwg YXQgMTc6MDQsIEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPiB3cm90 ZToNCj4+Pj4+IA0KPj4+Pj4gUGF0Y2ggInRvb2xzOiBBZGQgLVdlcnJvciBieSBkZWZhdWx0IHRv IGFsbCB0b29scy8iIGhhdmUgYWRkZWQNCj4+Pj4+ICItV2Vycm9yIiB0byBDRkxBR1MgaW4gdG9v bHMvUnVsZXMubWssIHJlbW92ZSBpdCBmcm9tIGV2ZXJ5IG90aGVyDQo+Pj4+PiBtYWtlZmlsZXMg YXMgaXQgaXMgbm93IGR1cGxpY2F0ZWQuDQo+Pj4+PiANCj4+Pj4+IFNpZ25lZC1vZmYtYnk6IEFu dGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPj4+PiANCj4+Pj4gSGkg QW50aG9ueSwNCj4+Pj4gDQo+Pj4+IEkgd2lsbCB0cnkgdG8gcmV2aWV3IHRoZSBzZXJpZSB3aGVu IEkgbWFuYWdlIHRvIGhhdmUgc29tZSB0aW1lLCBpbiB0aGUgbWVhbiB0aW1lIEkgY2FuIHNheSB0 aGUgd2hvbGUNCj4+Pj4gc2VyaWUgYnVpbGRzIGZpbmUgaW4gbXkgWW9jdG8gc2V0dXAgb24gYXJt NjQgYW5kIHg4Nl82NCwgSeKAmXZlIHRyaWVkIGFsc28gdGhlIHRvb2wgc3RhY2sgdG8NCj4+Pj4g Y3JlYXRlL2Rlc3Ryb3kvY29uc29sZSBndWVzdHMgYW5kIG5vIHByb2JsZW0gc28gZmFyLg0KPj4+ PiANCj4+Pj4gVGhlIG9ubHkgcHJvYmxlbSBJIGhhdmUgaXMgYnVpbGRpbmcgZm9yIGFybTMyIGJl Y2F1c2UsIEkgdGhpbmssIHRoaXMgcGF0Y2ggZG9lcyBhIGdyZWF0IGpvYiBhbmQgaXQNCj4+Pj4g ZGlzY292ZXJzIGEgcHJvYmxlbSBoZXJlOg0KPj4+IA0KPj4+IFRoYXQgcmVtaW5kcyBtZSB0aGF0 IHdlIG9ubHkgaGF2ZSBhcm0zMiBYZW4gaHlwZXJ2aXNvciBidWlsZHMgaW4NCj4+PiBnaXRsYWIt Y2ksIHdlIGRvbid0IGhhdmUgYW55IGFybTMyIFhlbiB0b29scyBidWlsZHMuIEknbGwgYWRkIGl0 IHRvIG15DQo+Pj4gVE9ETyBidXQgaWYgc29tZW9uZSAobm90IG5lY2Vzc2FyaWx5IEx1Y2EpIGhh cyBzb21lIHNwYXJlIHRpbWUgaXQgY291bGQNCj4+PiBiZSBhIG5pY2UgcHJvamVjdC4gSXQgY291 bGQgYmUgZG9uZSB3aXRoIFlvY3RvIGJ5IGFkZGluZyBhIFlvY3RvIGJ1aWxkDQo+Pj4gY29udGFp bmVyIHRvIGF1dG9tYXRpb24vYnVpbGQvLg0KPj4gDQo+PiBXZSBoYXZlIG5vdyBhIHdheSB0byBi dWlsZCBhbmQgcnVuIHhlbiBmb3IgYXJtMzIgb24gcWVtdSB1c2luZyBZb2N0by4NCj4+IFdlIGFy ZSB1c2luZyB0aGlzIGludGVybmFsbHkgYW5kIGFsc28gd2lsbCB0ZXN0IFhlbiB3aXRoIGd1ZXN0 cyBvbiBhcm0zMiB1c2luZyB0aGlzIHNvb24uDQo+PiANCj4+IEkgYW0gdXBzdHJlYW1pbmcgdG8g bWV0YS12aXJ0dWFsaXNhdGlvbiBhbGwgdGhlIGZpeGVzIG5lZWRlZCBmb3IgdGhhdCBzbyBpdCBz aG91bGQgYmUgZmFpcmx5IHN0cmFpZ2h0IGZvcndhcmQgZG8gcmVwcm9kdWNlIHRoaXMgaW4gWW9j dG8gYnVpbGQgaW4gYSBjb250YWluZXIuDQo+PiANCj4+IFBsZWFzZSB0ZWxsIG1lIHdoYXQgeW91 IG5lZWQgYW5kIEkgd2lsbCB0cnkgdG8gcHJvdmlkZSB5b3UgYSBzZXQgb2Ygc2NyaXB0cyBvciBp bnN0cnVjdGlvbnMgZG8gcmVwcm9kdWNlIHRoYXQgb24gZ2l0bGFiLg0KPiANCj4gVGhhdCB3b3Vs ZCBiZSBncmVhdCENCj4gDQo+IFdlIG5lZWQgdHdvIHRoaW5nczoNCj4gDQo+IC0gYSBZb2N0byBi dWlsZCBjb250YWluZXINCj4gLSBhIGJ1aWxkIHNjcmlwdA0KPiANCj4gDQo+IFRoZSBidWlsZCBj b250YWluZXIgd291bGQgYmUgc29tZXRoaW5nIGxpa2U6DQo+IGF1dG9tYXRpb24vYnVpbGQvZGVi aWFuL3Vuc3RhYmxlLWFybTY0djguZG9ja2VyZmlsZS4gSXQgaXMgYSBEb2NrZXJmaWxlDQo+IHRv IGNyZWF0ZSBhIGNvbnRhaW5lciB3aXRoIFlvY3RvIGFuZCBhbGwgcmVxdWlyZWQgZGVwZW5kZW5j aWVzLiBJdCBjb3VsZA0KPiBiZSBiYXNlZCBvbiBEZWJpYW4gYXJtNjQuIFRoZSBidWlsZCBjb250 YWluZXIgaXMgb25seSBidWlsdCBvbmNlIGFuZA0KPiBwdXNoZWQgdG8gdGhlIGdpdGxhYiByZWdp c3RyeSwgYnV0IGl0IGlzIGV4ZWN1dGVkIGV2ZXJ5IHRpbWUgYSBnaXRsYWINCj4gcGlwZWxpbmUg aXMgc3RhcnRlZC4NCj4gDQo+IFdlIHByb2JhYmx5IHdhbnQgdGhlIG1ldGEgbGF5ZXJzIHRvIGJl IHB1bGxlZCBhcyBwYXJ0IG9mIHRoZSBidWlsZA0KPiBjb250YWluZXIgYnVpbGQgKGdpdCBjbG9u ZSBmcm9tIHRoZSBEb2NrZXJmaWxlKSBiZWNhdXNlIG90aGVyd2lzZSB3ZQ0KPiB3b3VsZCBlbmQg dXAgZ2l0IGNsb2luaW5nIHRoZW0gZXZlcnkgdGltZSB3ZSBydW4gYSBnaXRsYWItY2kgcGlwZWxp bmUsDQo+IHNsb3dpbmcgZXZlcnl0aGluZyBkb3duLg0KPiANCj4gDQo+IFRoZSBidWlsZCBzY3Jp cHQgaXMgdGhlIHNjcmlwdCBleGVjdXRlZCBpbiB0aGUgYnVpbGQgY29udGFpbmVyIGZvciBldmVy eQ0KPiBwaXBlbGluZS4NCj4gDQo+IEltYWdpbmUgeW91IGhhdmUgYSBjb250YWluZXIgInlvY3Rv LWFybTMyIiwgYmFzaWNhbGx5IHdlIHdhbnQgdG8gZG86DQo+IA0KPiAjIGRvY2tlciBydW4geW9j dG8tYXJtMzIgYnVpbGQuc2NyaXB0DQo+IA0KPiB3aGVyZSBidWlsZC5zY3JpcHQgaXMgdGhlIHNj cmlwdCB0aGF0IGFjdHVhbGx5IHRyaWdnZXJzIHRoZSBYZW4gYnVpbGQNCj4gYW5kIHByb2R1Y2Vz IHRoZSBiaW5hcnkgb3V0cHV0Lg0KPiANCj4gVGhlIGN1cnJlbnQgYnVpbGQgc2NyaXB0IGlzIGF1 dG9tYXRpb24vc2NyaXB0cy9idWlsZDsgaXQgaXMgdXNlZCBmb3IgYWxsDQo+IGJ1aWxkIGNvbnRh aW5lcnMgKGFsbCBvZiB0aGVtLCBmcm9tIERlYmlhbiB0byBGZWRvcmEgYW5kIEFscGluZSkgYnV0 IGl0DQo+IGlzIHByb2JhYmx5IG5vdCBzdWl0YWJsZSB0byBiZSB1c2VkIGZvciBZb2N0by4gIEl0 IHNpbXBseSBjYWxscw0KPiAuL2NvbmZpZ3VyZTsgbWFrZTsgbWFrZSBpbnN0YWxsLiBJdCBpcyBt b3JlIGZvciBub3JtYWwgZGlzdHJvcy4NCj4gDQo+IEkgaW1hZ2luZSB0aGF0IHRoZSBidWlsZCBz Y3JpcHQgZm9yIFlvY3RvIHdvdWxkIGNhbGwgYml0YmFrZS4NCj4gDQo+IA0KPiBXaXRoIHRoZSBi dWlsZCBjb250YWluZXIgRG9ja2VyZmlsZSBhbmQgdGhlIGJ1aWxkIHNjcmlwdCBpdCBiZWNvbWVz DQo+IHZlcnkgc2ltcGxlIHRvIGFkZCBZb2N0byBhcm0zMiB0byBnaXRsYWItY2kuDQo+IA0KPiBJ IHJlYWxpemUgdGhhdCB0aGUgYWN0dWFsIGJ1aWxkIGNvdWxkIGJlIGRvbmUgb24gYm90aCBhcm02 NCBvciB4ODYuDQo+IEN1cnJlbnRseSB0aGUgYXJtMzIgaHlwZXJ2aXNvci1vbmx5IGNyb3NzLWJ1 aWxkIGlzIGRvbmUgb24geDg2LiBTZWUNCj4gYXV0b21hdGlvbi9idWlsZC9kZWJpYW4vdW5zdGFi bGUtYXJtMzItZ2NjLmRvY2tlcmZpbGUuIEVpdGhlciB3YXkgaXMgT0suDQoNCkkgd2lsbCB3b3Jr IG9uIHRoYXQgYW5kIEkgdGhpbmsgd2UgY2FuIHRha2UgdGhpcyBkaXNjdXNzaW9uIG9mZmxpbmUg YXMgdGhlcmUgYXJlIHNvbWUgZWxlbWVudHMgbWlzc2luZyByaWdodCBub3cgKGxpa2Ugd2hlcmUg aXMgdGhlIHhlbiB0cmVlIHRvIHRlc3QpLg0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 01 14:46:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 14:46:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359073.588447 (Exim 4.92) (envelope-from ) id 1o7Htz-0005NR-Uh; Fri, 01 Jul 2022 14:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359073.588447; Fri, 01 Jul 2022 14:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Htz-0005NK-Rf; Fri, 01 Jul 2022 14:45:47 +0000 Received: by outflank-mailman (input) for mailman id 359073; Fri, 01 Jul 2022 14:45:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Htx-0005NA-St; Fri, 01 Jul 2022 14:45:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Htx-0003Sy-Mw; Fri, 01 Jul 2022 14:45:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Htx-0007Dh-5T; Fri, 01 Jul 2022 14:45:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7Htx-0007th-4z; Fri, 01 Jul 2022 14:45:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P6dup2mqhRH8/OSf+ITwI6b6yJfeEeOZ0OHeiqsgfI4=; b=RW8G8jur788obOJqi683HXG7iI Mm2so90JyeB0mbNAUPL2evjAd2h9jpkSdu4Cl86s0g7ceS+j8fd88aLa8ueQLDYKHKzveJxUfJptX COUOIM6KZlHZ/Cf7iKsgBYQ9gi772LlQ3bTcyLwpylB+nw627+iRosnqpPs5SP7sW9ac=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171433: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d495e432c04a6394126c35cf96517749708b410f X-Osstest-Versions-That: qemuu=621745c4f349ac09b72706c46febee983abca916 From: osstest service owner Date: Fri, 01 Jul 2022 14:45:45 +0000 flight 171433 qemu-mainline real [real] flight 171443 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171433/ http://logs.test-lab.xenproject.org/osstest/logs/171443/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 171443-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171424 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171424 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171424 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171424 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171424 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171424 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171424 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171424 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: qemuu d495e432c04a6394126c35cf96517749708b410f baseline version: qemuu 621745c4f349ac09b72706c46febee983abca916 Last test of basis 171424 2022-06-30 12:22:38 Z 1 days Testing same since 171433 2022-07-01 01:40:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Le Goater Graeme Gregory Iris Chen Iris Chen Jae Hyun Yoo Joel Stanley Klaus Jensen Maheswara Kurapati Peter Delevoryas Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 621745c4f3..d495e432c0 d495e432c04a6394126c35cf96517749708b410f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jul 01 15:03:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 15:03:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359088.588461 (Exim 4.92) (envelope-from ) id 1o7IAg-0008DS-Jt; Fri, 01 Jul 2022 15:03:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359088.588461; Fri, 01 Jul 2022 15:03:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7IAg-0008DL-GT; Fri, 01 Jul 2022 15:03:02 +0000 Received: by outflank-mailman (input) for mailman id 359088; Fri, 01 Jul 2022 15:03:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7IAf-0008DB-FR; Fri, 01 Jul 2022 15:03:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7IAf-0003nt-9j; Fri, 01 Jul 2022 15:03:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7IAe-00083r-P0; Fri, 01 Jul 2022 15:03:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7IAe-00078M-Oa; Fri, 01 Jul 2022 15:03:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hWc4YFAgup57C8rVkfJz15s+4O9ug6iFQxXcQNGap4I=; b=RFrpRLJrDn0ZkVL7RHCcj1hhAP 31wFLd8MIDaDT7CrIPUwJfbPhDn6P0w2byMRK7Mjxlqv2CvR4St106YvXb3+8ZKkqudK88BxOpaN2 Bxf3Uh4vYqzI1d5E84j8eGMhmFvB8jCmslk5RYqK1q70rrpyqHFTpHcs3pBJKRIOgKW4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171436: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=0ba3870406b6d257ecb78749d98131f99f835cd2 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 01 Jul 2022 15:03:00 +0000 flight 171436 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171436/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 0ba3870406b6d257ecb78749d98131f99f835cd2 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 721 days Failing since 151818 2020-07-11 04:18:52 Z 720 days 702 attempts Testing same since 171436 2022-07-01 04:18:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 114397 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 15:39:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 15:39:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359100.588472 (Exim 4.92) (envelope-from ) id 1o7Ik8-0003m0-Ba; Fri, 01 Jul 2022 15:39:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359100.588472; Fri, 01 Jul 2022 15:39:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Ik8-0003lt-8j; Fri, 01 Jul 2022 15:39:40 +0000 Received: by outflank-mailman (input) for mailman id 359100; Fri, 01 Jul 2022 15:39:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Ik6-0003ll-RV for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 15:39:39 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 01c9ca2e-f954-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 17:39:36 +0200 (CEST) Received: from mail-dm6nam12lp2169.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Jul 2022 11:39:18 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BL1PR03MB6166.namprd03.prod.outlook.com (2603:10b6:208:31e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 1 Jul 2022 15:39:16 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.017; Fri, 1 Jul 2022 15:39:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01c9ca2e-f954-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656689976; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=LYanBdlKAw+vqB6zChSTOgMWRjYS3VF/IYRLV4L9NOk=; b=VqOtK8q+2CXV/6Ya6JNevriJq38rbHxpsB7rhHsbTj3egovzGQqXqnpd cr1ooL9DF3lvejhjPWssxJFtOwuqyS+estBH+pM1BSEfJres1rhm9eTWT G00MCADCAb05ivDtYfL9JXz/00SEUfFAXdST/dhG7SRgwOIXXVvfqs21S 0=; X-IronPort-RemoteIP: 104.47.59.169 X-IronPort-MID: 74733924 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8Kvk7q5EPyGodWrEbFe/pQxRtE/GchMFZxGqfqrLsTDasY5as4F+v mscCG+BPa2IZ2X8Ldt+Po6z/EhVuZ+Ay9Y1Gws9/CxmHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YfhWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSzcit2H5SUvNgDCTd0VAZdH7JI/Lb+dC3XXcy7lyUqclPK6tA3VgQaGNNd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfibo4YGjV/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IE9wnO9PBri4TV5CdI8bTjCuX/QIzJGdhSn2HE4 VCfpHusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/Y5lifD21dFDpZMoV45YkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLSfDdYgHdcd0o/ w23kQ== IronPort-HdrOrdr: A9a23:gBihR684YR/ZLQ1omwduk+E9db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe 2hz/sCgwDlVWUcb8y9CHVAd+/fp+fTnJajRRIdHRYo5CSHkDvtsdfBYlGl9yZbdwkK7aYp8G DDnQC8zqK/s8ujwhuZ82PI9ZxZlPbo19MGLs2Rjco+LCnql2+TFfJccozHmApwjPCk6V4snt WJixA8P/5r43eURW2xqQuF4XiT7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twri+knqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYd099RrBmc8a+d RVfY/hDK48SyLaU5mZhBgl/DWUZAV+Iv/cKXJy+vB80FBt7QNEJgUjtY8id0w7hewAoql/lp v525tT5cBzp+8tHNdA7bQ6ML+KI12IZy7wG0SvBnmiPJ07Ghv22u7KCfMOlamXRKA= X-IronPort-AV: E=Sophos;i="5.92,237,1650945600"; d="scan'208";a="74733924" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NA+sqryvnzdNisLx1AOlCRqWe2hhceNuDHhqEbxOtNw2pOrDUvfq62KRPd20TNdmue1MahHjiF/j7MMMWS16exMLYrW98FN9QScaIaLEvtqNiIIq/Nt28nzgpfxvy4kCJBYS3VfkBuI6XWYywONrnao2OMtj9E/oYOl8NGoFYCM6gTJ7+WQIiUJHwiEcpPlH2hrZOTxYxAxAZ1poTJPeed0QATyL+X2gZZzSXwo6QStgZVFnNAIFKImAafEpL+UoeuGbeKwqSg6y8W4T5T9MHKXZQo3ypkyMRuwj/gWfHTnphkX1DlVIYyxcpsyLtOwuVMDD+dVLR6ykHSgDjZcY/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UC3wSuavPn/K9iai5dYfJ1QmehkvlhTiGC4MguvcBEw=; b=eJGpjxIvTEWhMfvyUlU7B7PejWr5AGAxvU0DRdGhI8lBhboY00zYEl3WeoqvgEiMk4gbcOTLebjZNBjzlVCwuV/yZu/ZrjpA+GGR+DVzK7JJ2MuXGx8E2DkD+jaS3IO0ezohLiFRx1vZGYyZcDeO49NEsYGnUBIUoTR22+7gmkDKE9jOgMrjOZBgjTofu8GCSMPfR0txW35dqWJQCLFF19T7WnQRhLmj4T/AOQCUkA94W6W5N12Eku0psur56/AubntnWZ2KsyDaBzUTRn7faWjT70gukhqPI+RAYcGOFQKsp+I4jaYwy80XNUFQPmwt7C7PWNqauN5J441gW2h2RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UC3wSuavPn/K9iai5dYfJ1QmehkvlhTiGC4MguvcBEw=; b=eBBHRdnF1FPlhbfHTkd5qp2hRMkTS/8u3xO6H2gQQr6ZAkw7ukjtl2ETX1HmBafoxKoMtWKCpUsMQ1pVoWhEcYRzVbxwvbqrxC4KAJDpvdQBNzA/pfLf+g7NnbfZv9MQdIY9TMq2qm4+xqrJv4UsjmIzZk5cSfPTTOqbL5IlRK0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Fri, 1 Jul 2022 17:39:11 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-3-roger.pau@citrix.com> <4a193fd4-deb3-12c3-2faf-eed33e7b52af@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4a193fd4-deb3-12c3-2faf-eed33e7b52af@suse.com> X-ClientProxiedBy: LO4P123CA0623.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::18) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2496bf6a-4bd2-4904-9230-08da5b77db10 X-MS-TrafficTypeDiagnostic: BL1PR03MB6166:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3mdvlhyKObGiFZkWlSTd8HLxbD3CxgPBkEY+1ci1IVNwMZCSzwlbQjqxson0p9hmk+nvClEedixtOVzsdthUyPHyzrdKOo+3LRr4vAMDA+Nfue7wrb6cMvkpblvu7vmyoeZTVShkjUuGeXdr9t6sMGHt1a2HJIe4W1But8YfNqyDMOFR0yhsCBeoayKmc/5yUyW/8ucnYV9KquFDGmuxpQkcY8+avTDKXUPtTkfY5v4E4NyzdyK3yii1g3WvX/h9wvHhg/gCIZ2wrw6mezFVB+evW2B345hbJ7MQKXXkFXexbEIVDrhfjcu8IqheIyjYkN56W0vf0/ym96EhGsDBwRuXT6CQrqdgItNhl6B8dkpCBd9Vz1t1vHcAyoolIgSU361Ry37fQ6DGarwiqHgSuiYZ1L0bMZHqsEx8bbIv2S/u5E1+D3MmMJNiF+3IJX+KFDz46lzqjDau8Jviszz6YUB8KBns5tqX9oB/gNWA1bL9Je6BVgrNJbst7IMEVNwkkqZEDictSSU7aTGH9t+4C9rxkQucBbt9xTq3gz6a93FAHu3aCClsDEjYcidbEy7igGpigOF7cIiKNr8xOm+VBZL83vVy0bEJaWQZRD5rwdYoOhzq8KzyKb+tENx2lSuXH0RiE3EvMztoyF+fnk6K6HwKoO9dIJ8qi8xOS0UXvB3t9/YbLa61WdXdDZwe9kSHP8O6frNAyNInfQtu4qlQemE0D3M9NwOFkbnp7brqMMHA8xhIka9ZnIdgpvpNmpKx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(39860400002)(376002)(396003)(66556008)(5660300002)(6512007)(66476007)(6506007)(66946007)(316002)(4326008)(6916009)(41300700001)(86362001)(6666004)(8676002)(54906003)(2906002)(85182001)(8936002)(26005)(9686003)(53546011)(478600001)(38100700002)(82960400001)(186003)(6486002)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXhoQThvMzM2K3BMZGp6MFRwQWNHUjhVd3hzSDRVaDFMcTJSNHc1d01JeWdq?= =?utf-8?B?VFZIeEVic0k1UE94bE1LQlJRVmZ1WlJCc2RxWm9JVFZMaHE3MWp3V3E3Y1VY?= =?utf-8?B?MnQyZXhSMHR0dGhuc0dVQjdWN3RBTjhJV2xNSFhmVXFNM1U2Q21nVlF5U0dq?= =?utf-8?B?TlFiaTZzbkhIUFNrdnJ1YjQyMHp5bWZ2WXJ2R0FrdDNROVFLbTQ5cFB0OXdM?= =?utf-8?B?U1dNVFBQTHphL2hKUE5XaHlZLzZhOU5wK3FsK0o3cjkzM1hSdEYyeFNaZW5w?= =?utf-8?B?clJmNTNVeENXcDZla08xQk5XNVFjNmgxVjFzQllFOUZ0MzNTSENCamJ0WURs?= =?utf-8?B?VkVRUmFwWG5ZYVFxSVNhWUZiTU1CTDg2Q1V1WUUzZ3htNUJHRDdvSjQwM0li?= =?utf-8?B?UTBLblZ5cHVrN0FmNG9Lc1l2Qm1HK2pueXZvWGpUZHF6RnVmT2ZuOUl5emZ2?= =?utf-8?B?UThIZHZ3YUlGUXRWNStuNGU0WlpNa0YrbXA5WDRGUzZBZ0ZUdHNxVVhSNFlj?= =?utf-8?B?UjBxd1F3VktLUlViYm1HYjRkbVV5cnVMa1NnY0tmYlNHWTREc3QrakZTY2tX?= =?utf-8?B?YzRNNnlQRkFFK2NOSUFKcjVqT01jNEdZdlFDM2NLYzBtNGNNbTdDeXBiNEFK?= =?utf-8?B?ckhkWHlSem54dERrUlBkemljemVGYjNjL2c3eEF3Z3hrUTdrWU9GRWpXbTIv?= =?utf-8?B?Zk9PL3BacjVUZGZCZTRydnZFUkJ2bStJSXdDaGZvcjVWTGVkMmY0amZuZTdN?= =?utf-8?B?dFo3UUpseHkvK3RSbXlhTk8xM2pSVmJMdTFPeTdyaVpwWGJCdnZlRGdaSlVN?= =?utf-8?B?MjlOaE9NSm02S0JaOUNuM3JVSGxsejZ0RnppSWZmNHBLWUJZS2QyNGxrYThH?= =?utf-8?B?S3ZGWXR5YnNLT0NGK0FlN0grMWNaRlc4cmU4eXVOTXpOZk83L0d2WFM2ZkxV?= =?utf-8?B?NGFhNGFhMHpBNCt0R3Z4WFh3TjZyamhMQTgwQ3pPN2VMYkRBWkExQVZ2OG01?= =?utf-8?B?b284NzFhbXcwVWRVMEUyYm5EUHliQ2VoTWFGbDJVNTltSUdNTVgyZXNlN0pT?= =?utf-8?B?UmcvQ3JZUGc4aTBpL2I4M2NEZ0ZjY0I3VXN3M2pWV21mT2wzNjUyQVlsV3dM?= =?utf-8?B?SnhIdFd0aG9WQnJNY1pDVFl0UjFYUjhjNzA2eWtzWXhHVkJ5RHBTYU9FOVBM?= =?utf-8?B?WEJmNDQ5Z0paNldUcFdtZ29sd01GUFdidTV3V2VUVVkrMGRUVG9jemx4UHp2?= =?utf-8?B?OEZONU53RzQzZjloK2hpdmVCTE1kOEZRalgyUytoZkd1Vlp2SGtBSGhUWnYw?= =?utf-8?B?L3FNU3ZTTXdJUXVETHlpMmZPbTZ5dlE4d3BPYm5XTHN3L2dYYmFYMHRwNDl5?= =?utf-8?B?alVVbjhWeS9odWVaSGpTcXdZc2pBajFJNFJIeWppTnAwK2gxY3RzSDVudWJz?= =?utf-8?B?a3Nremx0ZnZFQUZReXVuMXk5S1QzNVN6VnhtdURJdktsL2xZUU9iYkNpOXBR?= =?utf-8?B?TEd0dzZLOEVwQzdNcnQyRm83K3l4bzMyNVlqMXkxeGJaWFpLcEkxK1NOQ1dJ?= =?utf-8?B?ZU1nUTZsUkZWMHMxSUV6T29IY1dDUTQrdEtmRElnaFpxVmMrMzVKeXZZMVNL?= =?utf-8?B?VEkwUUdzeTNnamNRQmg0ek80QlBhNjdoa2FDT2N6NkNVdDdPTUhTUGh3Y3R5?= =?utf-8?B?d1JDWStYclhnTEtMVVI2NVd4WmpGamd1V0JGd0tBcFd5UDlRWkI5TGJ3aStw?= =?utf-8?B?am8xcjFvNEsvWE5CaGdhT1hWMWtSbysrWUwydWNzVkdVMnVXVlFNUXBRUk5G?= =?utf-8?B?TnBZd3JoKzM3VnRsbCtMeEIzZ0lBOEpaQVA1WlZKZlpnNFMzRzA1ejBSazdp?= =?utf-8?B?UTRMMmw1MjYwdGFVajZwd2g3S3BvTnpjbTBHQkNYM2dZUldyUHhMei9Wb2tH?= =?utf-8?B?cCsvZHJUSVZwZ05ZdzB3NkNXWDRVMi9iUTByRUVUYWptTFV1WW10cCtUcFBp?= =?utf-8?B?QWVtRmdoZ3U0WHVxVmZVR3Y2WXM3eWluWXIvZEQrcVJ4cnZyRHNtZGwyeFNK?= =?utf-8?B?bU5rcmpxYWo1OEEySldGVlpQQlhKOFNHd1VtaEZRM3h5Y241amRBdU9JU0R4?= =?utf-8?Q?JAkqvZQuhBOFtMeJ8mOXz56PL?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2496bf6a-4bd2-4904-9230-08da5b77db10 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 15:39:16.2597 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1mV2UZ3dsNdL9GcmiyzNc+pQ0vD7F07QxBSefcMrqa2QMcXkHNE06EkQHjRZj7k4jfsWl6tCzM++qyyQwetlMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6166 On Mon, May 30, 2022 at 05:31:18PM +0200, Jan Beulich wrote: > On 20.05.2022 15:37, Roger Pau Monne wrote: > > --- a/xen/arch/x86/include/asm/msr-index.h > > +++ b/xen/arch/x86/include/asm/msr-index.h > > @@ -139,6 +139,24 @@ > > #define PASID_PASID_MASK 0x000fffff > > #define PASID_VALID (_AC(1, ULL) << 31) > > > > +#define MSR_ARCH_LBR_CTL 0x000014ce > > +#define ARCH_LBR_CTL_LBREN (_AC(1, ULL) << 0) > > +#define ARCH_LBR_CTL_OS (_AC(1, ULL) << 1) > > Bits 2 and 3 also have meaning (USR and CALL_STACK) according to > ISE version 44. If it was intentional that you omitted those > (perhaps you intended to add only the bits you actually use right > away), it would have been nice if you said so in the description. Yes, I've only added the bits used. I could add all if that's better. > > --- a/xen/arch/x86/traps.c > > +++ b/xen/arch/x86/traps.c > > @@ -1963,6 +1963,29 @@ void do_device_not_available(struct cpu_user_regs *regs) > > #endif > > } > > > > +static bool enable_lbr(void) > > +{ > > + uint64_t debugctl; > > + > > + wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > > + rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl); > > + if ( !(debugctl & IA32_DEBUGCTLMSR_LBR) ) > > + { > > + /* > > + * CPUs with no model-specific LBRs always return DEBUGCTLMSR.LBR > > + * == 0, attempt to set arch LBR if available. > > + */ > > + if ( !boot_cpu_has(X86_FEATURE_ARCH_LBR) ) > > + return false; > > + > > + /* Note that LASTINT{FROMIP,TOIP} matches LER_{FROM_IP,TO_IP} */ > > + wrmsrl(MSR_ARCH_LBR_CTL, ARCH_LBR_CTL_LBREN | ARCH_LBR_CTL_OS | > > + ARCH_LBR_CTL_RECORD_ALL); > > + } > > + > > + return true; > > +} > > Would it make sense to try architectural LBRs first? I didn't want to change behavior for existing platforms that have both architectural and model specific LBRs. > > @@ -1997,7 +2020,7 @@ void do_debug(struct cpu_user_regs *regs) > > > > /* #DB automatically disabled LBR. Reinstate it if debugging Xen. */ > > if ( cpu_has_xen_lbr ) > > - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > > + enable_lbr(); > > > > if ( !guest_mode(regs) ) > > { > > @@ -2179,8 +2202,8 @@ void percpu_traps_init(void) > > if ( !ler_msr && (ler_msr = calc_ler_msr()) ) > > setup_force_cpu_cap(X86_FEATURE_XEN_LBR); > > > > - if ( cpu_has_xen_lbr ) > > - wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > > + if ( cpu_has_xen_lbr && !enable_lbr() ) > > + printk(XENLOG_ERR "CPU#%u: failed to enable LBR\n", smp_processor_id()); > > } > > Isn't enable_lbr() failing a strong indication that we shouldn't have > set XEN_LBR just before this? So I've now added extra checks in calc_ler_msr() so that it only returns != 0 when there's LBR support (either model specific or architectural). > IOW doesn't this want re-arranging such > that the feature bit and maybe also ler_msr (albeit some care would > be required there; in fact I think this is broken for the case of > running on non-{Intel,AMD,Hygon} CPUs [or unrecognized models] but > opt_ler being true) remain unset in that case? opt_ler will be set to false if calc_ler_msr() return 0, which is the case for non-{Intel,AMD,Hygon} or unrecognized models. > As there's no good place to ask the VMX-related question, it needs to > go here: Aiui with this patch in place VMX guests will be run with > Xen's choice of LBR_CTL. That's different from DebugCtl, which - being > part of the VMCS - would be loaded by the CPU. Such a difference, if > intended, would imo again want pointing out in the description. LBR_CTL will only be set by Xen when the CPU only supports architectural LBRs (no model specific LBR support at all), and in that case LBR support won't be exposed to guests, as the ARCH_LBR CPUID is not exposed, neither are guests allowed access to ARCH_LBR_CTL. Note that in such scenario also setting DebugCtl.LBR has not effect, as there's no model specific LBR support, and the hardware will just ignore the bit. Also none of the LBR MSRs are exposed to guests either. I can try to clarify all the above in the commit message. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Fri Jul 01 16:48:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 16:48:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359108.588485 (Exim 4.92) (envelope-from ) id 1o7Joq-0003ok-I1; Fri, 01 Jul 2022 16:48:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359108.588485; Fri, 01 Jul 2022 16:48:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Joq-0003od-F4; Fri, 01 Jul 2022 16:48:36 +0000 Received: by outflank-mailman (input) for mailman id 359108; Fri, 01 Jul 2022 16:48:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Joo-0003oT-Tk; Fri, 01 Jul 2022 16:48:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Joo-0006It-Om; Fri, 01 Jul 2022 16:48:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Joo-0002cu-7U; Fri, 01 Jul 2022 16:48:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7Joo-0002mq-70; Fri, 01 Jul 2022 16:48:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ceiOGrDideTm1IqRfWz5UsTnE6YQ08mEvwVOq6/7Yjg=; b=e8edcwbk42Y/TSd2FkbVxDZqoI r6b76OtIcMcqphF1y22eZcszDk4XI2R6b06UVaSAWwAC27VBti9qwr5LeIxZQD6JnwompDrPd0SUT z7E1tSCRuEVd+AHABKnh4uZiIH5EWlC9/ovZl7lp5YISnMv03sOXP1RTv9lMcpMSLWrw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171435: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9ef3ad40a81ff6b8b65ed870588b230f38812f2a X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Fri, 01 Jul 2022 16:48:34 +0000 flight 171435 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171435/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171352 Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 13 guest-start fail in 171427 pass in 171435 test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail pass in 171427 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171352 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9ef3ad40a81ff6b8b65ed870588b230f38812f2a baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 6 days Testing same since 171400 2022-06-29 07:11:34 Z 2 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Antoine Tenart Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Nguyen Ulf Hansson Vincent Whitchurch Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1766 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 17:21:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 17:21:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359117.588497 (Exim 4.92) (envelope-from ) id 1o7KK8-0008Iw-1F; Fri, 01 Jul 2022 17:20:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359117.588497; Fri, 01 Jul 2022 17:20:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KK7-0008Ip-Ui; Fri, 01 Jul 2022 17:20:55 +0000 Received: by outflank-mailman (input) for mailman id 359117; Fri, 01 Jul 2022 17:20:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KK6-0008If-JY; Fri, 01 Jul 2022 17:20:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KK6-0006vn-IW; Fri, 01 Jul 2022 17:20:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KK5-0003Wm-WF; Fri, 01 Jul 2022 17:20:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7KK5-0004BV-Vn; Fri, 01 Jul 2022 17:20:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zldCPXbchw6ZYBNXFJEA/CBBBop/dUXEm5O171Xtpww=; b=P06S/GRKTMIK/RIGb7RmW+OAUW 31vL015XMxvGed1VYUn2F3Sj6KwkkkNaiQz57tcj1EQAndxX4iIU/zWffK28ZtjaprKGXmVllDxRu qr2XDbKOgn0HRXNU0ST1cKL1nQKuyaKKM5AXhdmiFtmLif8sfX/0rnXiJnmJBZ4FbDYA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171444: all pass - PUSHED X-Osstest-Versions-This: ovmf=70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1 X-Osstest-Versions-That: ovmf=f966093f5bb88e6fccac8e0b9eeca6c73aef0c35 From: osstest service owner Date: Fri, 01 Jul 2022 17:20:53 +0000 flight 171444 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171444/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1 baseline version: ovmf f966093f5bb88e6fccac8e0b9eeca6c73aef0c35 Last test of basis 171438 2022-07-01 07:10:43 Z 0 days Testing same since 171444 2022-07-01 15:13:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Miki Shindo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f966093f5b..70586d4e3a 70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 01 17:28:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 17:28:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359125.588508 (Exim 4.92) (envelope-from ) id 1o7KR9-0000Zj-PY; Fri, 01 Jul 2022 17:28:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359125.588508; Fri, 01 Jul 2022 17:28:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KR9-0000Zc-Mw; Fri, 01 Jul 2022 17:28:11 +0000 Received: by outflank-mailman (input) for mailman id 359125; Fri, 01 Jul 2022 17:28:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KR7-0000Z7-TF for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 17:28:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KR7-00073d-Nc; Fri, 01 Jul 2022 17:28:09 +0000 Received: from [54.239.6.185] (helo=[192.168.1.77]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o7KR7-0003JO-H4; Fri, 01 Jul 2022 17:28:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uzTkoonCDqOGrBx9AdVGkIcB8sppbSPLpaECqmPDBWU=; b=Kv4TF/7bluXxM3jBA8h8d8HRnz 19/2CiNc9+VWVDMTtIrOuvfwnBWtXFzod491BWfECmQNAb9Nl/AyR4grLB21OzDeZ/A+eREFk74gX L3NYaYc0CZgSUWegvsHVH/i8lWGPseyRe2OOOcUhp3zQDJs6sWHQtOqtuCVNQxGnUOC8=; Message-ID: <6780396b-5a61-258c-4b5d-533b0c9a7faf@xen.org> Date: Fri, 1 Jul 2022 18:28:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] public/io: xs_wire: Document that new errors should be added at the end To: Juergen Gross , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, Julien Grall References: <20220630183655.44391-1-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, On 01/07/2022 06:13, Juergen Gross wrote: > On 30.06.22 20:36, Julien Grall wrote: >> From: Julien Grall >> >> Some tools (e.g. xenstored) always expect EINVAL to be first in >> xsd_errors. >> >> To be conservative, mandate that new errors should be added at the end >> of the array. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Juergen Gross Thanks! I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 01 17:47:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 17:47:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359135.588523 (Exim 4.92) (envelope-from ) id 1o7Kjc-0003sz-G4; Fri, 01 Jul 2022 17:47:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359135.588523; Fri, 01 Jul 2022 17:47:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Kjc-0003ss-D6; Fri, 01 Jul 2022 17:47:16 +0000 Received: by outflank-mailman (input) for mailman id 359135; Fri, 01 Jul 2022 17:47:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Kjb-0003sm-Hv for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 17:47:15 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6f8e02f-f965-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 19:47:14 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1C68B82CC2; Fri, 1 Jul 2022 17:47:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE668C3411E; Fri, 1 Jul 2022 17:47:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6f8e02f-f965-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656697631; bh=c4xuMH+x6ZYKJwDPdhc3j6mD3DO07ViUgQwMc69fZE0=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=V46WjESQya0riVrpgZ+8PAEMQhoYjkRJXjxKVKuJKMqzVfcRdD9fOK4uHYi3MIOB8 /Gx5TFEA1wJ7GdyiUScrO4ZYoMwS6JI1CBfFukdFJmKRCO5QEpnua4HRjA3PNR40dZ CtTEDVRTYl+IvOfr1SSrLcBoBE7xFi3ptKXRAcCKfMsllYdnO55u8osS2FtczcMPED cF49M8NCs32uTVKcII/4GSaN2fTQowPcGKiFiq5hba0mZavLsDNlPxvFtg3OolrWdg 2pNSPtm47AD03GXatcIO1pNrl2VUjH8EpEvcbUThxibH7Of0fpfJj9us68eXvxnoH1 7ePgd8MUBmOfw== Date: Fri, 1 Jul 2022 10:47:09 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Stefano Stabellini , Luca Fancellu , Anthony PERARD , Xen-devel , Wei Liu , Elena Ufimtseva , Tim Deegan , Daniel De Graaf , "Daniel P. Smith" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Juergen Gross , Christian Lindig , David Scott Subject: Re: [XEN PATCH v3 25/25] tools: Remove -Werror everywhere else In-Reply-To: <8D4E96D0-A591-440D-BD1B-E52D7F2283E5@arm.com> Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-26-anthony.perard@citrix.com> <6CA16D2D-8AD6-415A-A98D-00B27F91C4DA@arm.com> <8D4E96D0-A591-440D-BD1B-E52D7F2283E5@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1354556042-1656697631=:4389" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1354556042-1656697631=:4389 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 1 Jul 2022, Bertrand Marquis wrote: > > On 30 Jun 2022, at 22:03, Stefano Stabellini wrote: > > > > On Thu, 30 Jun 2022, Bertrand Marquis wrote: > >>> On 29 Jun 2022, at 18:22, Stefano Stabellini wrote: > >>> > >>> On Wed, 29 Jun 2022, Luca Fancellu wrote: > >>>> + CC: Stefano Stabellini > >>>> > >>>>> On 24 Jun 2022, at 17:04, Anthony PERARD wrote: > >>>>> > >>>>> Patch "tools: Add -Werror by default to all tools/" have added > >>>>> "-Werror" to CFLAGS in tools/Rules.mk, remove it from every other > >>>>> makefiles as it is now duplicated. > >>>>> > >>>>> Signed-off-by: Anthony PERARD > >>>> > >>>> Hi Anthony, > >>>> > >>>> I will try to review the serie when I manage to have some time, in the mean time I can say the whole > >>>> serie builds fine in my Yocto setup on arm64 and x86_64, I’ve tried also the tool stack to > >>>> create/destroy/console guests and no problem so far. > >>>> > >>>> The only problem I have is building for arm32 because, I think, this patch does a great job and it > >>>> discovers a problem here: > >>> > >>> That reminds me that we only have arm32 Xen hypervisor builds in > >>> gitlab-ci, we don't have any arm32 Xen tools builds. I'll add it to my > >>> TODO but if someone (not necessarily Luca) has some spare time it could > >>> be a nice project. It could be done with Yocto by adding a Yocto build > >>> container to automation/build/. > >> > >> We have now a way to build and run xen for arm32 on qemu using Yocto. > >> We are using this internally and also will test Xen with guests on arm32 using this soon. > >> > >> I am upstreaming to meta-virtualisation all the fixes needed for that so it should be fairly straight forward do reproduce this in Yocto build in a container. > >> > >> Please tell me what you need and I will try to provide you a set of scripts or instructions do reproduce that on gitlab. > > > > That would be great! > > > > We need two things: > > > > - a Yocto build container > > - a build script > > > > > > The build container would be something like: > > automation/build/debian/unstable-arm64v8.dockerfile. It is a Dockerfile > > to create a container with Yocto and all required dependencies. It could > > be based on Debian arm64. The build container is only built once and > > pushed to the gitlab registry, but it is executed every time a gitlab > > pipeline is started. > > > > We probably want the meta layers to be pulled as part of the build > > container build (git clone from the Dockerfile) because otherwise we > > would end up git cloining them every time we run a gitlab-ci pipeline, > > slowing everything down. > > > > > > The build script is the script executed in the build container for every > > pipeline. > > > > Imagine you have a container "yocto-arm32", basically we want to do: > > > > # docker run yocto-arm32 build.script > > > > where build.script is the script that actually triggers the Xen build > > and produces the binary output. > > > > The current build script is automation/scripts/build; it is used for all > > build containers (all of them, from Debian to Fedora and Alpine) but it > > is probably not suitable to be used for Yocto. It simply calls > > ./configure; make; make install. It is more for normal distros. > > > > I imagine that the build script for Yocto would call bitbake. > > > > > > With the build container Dockerfile and the build script it becomes > > very simple to add Yocto arm32 to gitlab-ci. > > > > I realize that the actual build could be done on both arm64 or x86. > > Currently the arm32 hypervisor-only cross-build is done on x86. See > > automation/build/debian/unstable-arm32-gcc.dockerfile. Either way is OK. > > I will work on that and I think we can take this discussion offline as there are some elements missing right now (like where is the xen tree to test). No problem, I am happy to help offline as well. The Xen tree is given to you automatically by gitlab-ci (because it is the repository with the .gitlab* yaml files.) The build container starts execution with the Xen repository to test ready inside. --8323329-1354556042-1656697631=:4389-- From xen-devel-bounces@lists.xenproject.org Fri Jul 01 17:56:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 17:56:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359141.588534 (Exim 4.92) (envelope-from ) id 1o7KsY-0005UR-BW; Fri, 01 Jul 2022 17:56:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359141.588534; Fri, 01 Jul 2022 17:56:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KsY-0005UK-8P; Fri, 01 Jul 2022 17:56:30 +0000 Received: by outflank-mailman (input) for mailman id 359141; Fri, 01 Jul 2022 17:56:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KsX-0005UE-9L for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 17:56:29 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 214b9ac6-f967-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 19:56:28 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01E07B83106; Fri, 1 Jul 2022 17:56:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1306DC3411E; Fri, 1 Jul 2022 17:56:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 214b9ac6-f967-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656698184; bh=k3LbadIxoy6dSLMPD16RNV5MKRaAaeGfE3h3yg4vuwc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=AfjrXuSnLImyebYo6hiATn32awUJ8DECqzFKGqI/iG7lKKlrqxvB7cK5SJRqBMyfx 7sHc0wMPOypzHoVxWnsYortcyvMNzEAPy/OL7JRJ/G3mFquRdjKK9xLIvF5WfqyL6o unO7mjIzlkCzjkp6++nCPP7OchG3EIzdKpMD1nSJ9Y8WgrixhIKoZdTrZxUS5b6/Ij ZapklDZTs3Y9YTsv0jkv9KTba6gw1Efc3yT9ym06EgJCoXoQvmvQWAQC69P6pn7Rvy YCVtLgbasQZq+lbS2FmctZ8j5jgywj2pUZv6OnyPi8vxPSNbx7j5fnY1BDijaA4TVH 1cQZxAiNUBdAg== Date: Fri, 1 Jul 2022 10:56:22 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , xen-devel@lists.xenproject.org, scott.davis@starlab.io, jandryuk@gmail.com, christopher.clark@starlab.io, dgdegra@tycho.nsa.gov, julien@xen.org, george.dunlap@citrix.com, andrew.cooper3@citrix.com, dfaggioli@suse.com, "Daniel P. Smith" Subject: Re: [PATCH v9 0/3] Adds starting the idle domain privileged In-Reply-To: <563b5d12-6eca-cfff-129f-7bffb01cd25c@suse.com> Message-ID: References: <20220630022110.31555-1-dpsmith@apertussolutions.com> <563b5d12-6eca-cfff-129f-7bffb01cd25c@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 1 Jul 2022, Jan Beulich wrote: > On 01.07.2022 00:35, Stefano Stabellini wrote: > > On Wed, 29 Jun 2022, Daniel P. Smith wrote: > >> This series makes it so that the idle domain is started privileged under the > >> default policy, which the SILO policy inherits, and under the flask policy. It > >> then introduces a new one-way XSM hook, xsm_transition_running, that is hooked > >> by an XSM policy to transition the idle domain to its running privilege level. > >> > >> Patch 3 is an important one, as first it addresses the issue raised under an > >> RFC late last year by Jason Andryuk regarding the awkward entanglement of > >> flask_domain_alloc_security() and flask_domain_create(). Second, it helps > >> articulate why it is that the hypervisor should go through the access control > >> checks, even when it is doing the action itself. The issue at hand is not that > >> the hypervisor could be influenced to go around these check. The issue is these > >> checks provides a configurable way to express the execution flow that the > >> hypervisor should enforce. Specifically with this change, it is now possible > >> for an owner of a dom0less or hyperlaunch system to express a policy where the > >> hypervisor will enforce that no dom0 will be constructed, regardless of what > >> boot construction details were provided to it. Likewise, an owner that does not > >> want to see dom0less or hyperlaunch to be used can enforce that the hypervisor > >> will only construct a dom0 domain. This can all be accomplished without the > >> need to rebuild the hypervisor with these features enabled or disabled. > > > > > > It looks like this patch series is fully acked except: > > - in theory we need an ack from Daniel for flask > > - there is a very small change to sched that would need an ack from > > George/Dario > > I don't think I've seen any R-b for the last patch. Good point. I hope you'll be happy to give your Reviewed-by or Acked-by to the next version with the minor comments fixed. From xen-devel-bounces@lists.xenproject.org Fri Jul 01 18:03:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 18:03:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359148.588545 (Exim 4.92) (envelope-from ) id 1o7KzQ-00078T-2k; Fri, 01 Jul 2022 18:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359148.588545; Fri, 01 Jul 2022 18:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KzP-00078M-W8; Fri, 01 Jul 2022 18:03:35 +0000 Received: by outflank-mailman (input) for mailman id 359148; Fri, 01 Jul 2022 18:03:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KzP-00078G-2Y for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 18:03:35 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7KzO-0007p4-7X; Fri, 01 Jul 2022 18:03:34 +0000 Received: from [54.239.6.185] (helo=[192.168.1.77]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o7KzN-00058z-Vq; Fri, 01 Jul 2022 18:03:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RpV8wMIAYzPpXIawzmS3N2Q7UO34QnAsdyNeSFRM0Xk=; b=PmImcQJ0nBsnPZWoMYObyqBksA vgBgZw9hPNe2zxJ2Lh2y3spemf/wN5h5DSzygbfY/LrzdxdIhkZile6l0ws68d5VeW/pKGkGd5hSo dz3Sn/FHYp1itFXFwFLz2kVqnZUU0+LtiEzj+CFKyhHI5peHL2nh1UUXruXuOSuN86V8=; Message-ID: <95e7d58d-e147-fcde-c4cf-da56b6c66faa@xen.org> Date: Fri, 1 Jul 2022 19:03:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] xen/heap: pass order to free_heap_pages() in heap init To: Bertrand Marquis Cc: xen-devel , Hongyan Xia , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20220609083039.76667-1-julien@xen.org> <20220609083039.76667-3-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/06/2022 15:40, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 9 Jun 2022, at 09:30, Julien Grall wrote: >> >> From: Hongyan Xia >> >> The idea is to split the range into multiple aligned power-of-2 regions >> which only needs to call free_heap_pages() once each. We check the least >> significant set bit of the start address and use its bit index as the >> order of this increment. This makes sure that each increment is both >> power-of-2 and properly aligned, which can be safely passed to >> free_heap_pages(). Of course, the order also needs to be sanity checked >> against the upper bound and MAX_ORDER. >> >> Testing on a nested environment on c5.metal with various amount >> of RAM. Time for end_boot_allocator() to complete: >> Before After >> - 90GB: 1426 ms 166 ms >> - 8GB: 124 ms 12 ms >> - 4GB: 60 ms 6 ms > > > On a arm64 Neoverse N1 system with 32GB of Ram I have: > - 1180 ms before > - 63 ms after > > and my internal tests are passing on arm64. Thanks for the testing! The number are a lot better than I was actually expecting on arm64. > > Great optimisation :-) You will have to thanks Hongyan. He came up with the idea :). > > (I will do a full review of code the in a second step). I am planning to send a new version in the next few days. So you may want to wait before reviewing the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 01 19:43:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 19:43:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359160.588556 (Exim 4.92) (envelope-from ) id 1o7MXc-0001KR-B7; Fri, 01 Jul 2022 19:43:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359160.588556; Fri, 01 Jul 2022 19:43:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MXc-0001KK-7c; Fri, 01 Jul 2022 19:43:00 +0000 Received: by outflank-mailman (input) for mailman id 359160; Fri, 01 Jul 2022 19:42:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MXa-0001Jl-LY; Fri, 01 Jul 2022 19:42:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MXa-0001Ek-HX; Fri, 01 Jul 2022 19:42:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MXa-0002h7-29; Fri, 01 Jul 2022 19:42:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7MXa-0001Jg-1g; Fri, 01 Jul 2022 19:42:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bN0xuJvE9jT+Amxk0BLB/qnKJcs+qic4JSPzq0r9WVw=; b=WqXHKGY4VIWrJ6cKfNyTtQJyH9 nXSUF0yFWeuHQZQcAUkwwT3AMku6uMJLSH36O6SCckZDzB9gGSSspfLFsi7ULYH//IEmjug0RH91R 5xN+0dm57WNg+i1NiTfGEO4rOnwTXGT1z9Ff/dkzSUPObDbHolnT0fHK1ftBSN/vcBbc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171437: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=a175eca0f3d747599f1fdfac04cc9195b71ec996 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Fri, 01 Jul 2022 19:42:58 +0000 flight 171437 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171437/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux a175eca0f3d747599f1fdfac04cc9195b71ec996 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 12 days Failing since 171280 2022-06-19 15:12:25 Z 12 days 33 attempts Testing same since 171437 2022-07-01 05:57:05 Z 0 days 1 attempts ------------------------------------------------------------ 425 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 15943 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359181.588615 (Exim 4.92) (envelope-from ) id 1o7N6I-0006Hr-Ko; Fri, 01 Jul 2022 20:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359181.588615; Fri, 01 Jul 2022 20:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6I-0006En-28; Fri, 01 Jul 2022 20:18:50 +0000 Received: by outflank-mailman (input) for mailman id 359181; Fri, 01 Jul 2022 20:01:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mps-00047i-Gu for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:52 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a57d8278-f978-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 22:01:51 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id C3753580314; Fri, 1 Jul 2022 16:01:50 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 01 Jul 2022 16:01:50 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:47 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a57d8278-f978-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705710; x=1656712910; bh=GP TgF7ArqFMLRWCMzAXk/iblC7hZOhNlz+8yGyXcVmI=; b=QpxRZ/QqCKAaTufwyd lUjoM1KJpo2vAxdEuEjb/waTg16dZR9eragrRhhtwxuPLt0ECneX3zy6CNzBBx5c Ygb4PPzfUzDV5VvtfKPQBAj8iCK8i+A3N0IvHHfLXEkCFny82EoJbTgg4N7U1bwk TgxvTxE3rNtOE/fFih1K1eJ8kHseL1OspFJFfo5CJ04JSj1DGPwQ6FHwv0IhNoq4 EGKiBH64+38GGFPCSypyrkvUHdkYQuk9s/BixzzRoak4pO7Ob+kyqg83h69D4GAa h3rUBxATwnOMT09jx3nmAk3wW/b1biR06qzg7OZv2+rzhWJ7Rr/DFMBhHTnlVHau I+8A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705710; x=1656712910; bh=GPTgF7ArqFMLR WCMzAXk/iblC7hZOhNlz+8yGyXcVmI=; b=bZV6JNZNCNgrHjWghrR9O98nWKlYN DX/X53ob25+i0NwhRNBQiBLDVz6UVV3he1PXha4QFwp5yMwGnxpB7lu/UEE8Xi3o OpXqvhbTbTBs7KDOhb4KUllG3Pk9Aa1vRSyBe3BCvgnGtLlZf/oqGEk+Jnl3BG85 OJ3xW7PAvFO/MhjF/+sAERp5XAdEzU4Ff5xnJ4prZbZoQYpU1kHRmjt2+C7DkY3Y SuzrsxXUNapv8zup6IGTgy0/s8A+vKX+TshcO/FgHArWEelqqro6tFdd578sYzkL 51oiHdOk0YWBV5old0Q464FJ20N+qIDsdwwqcQx1JwG+SPenzYypJolkw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 6/8] genirq: Add and use an irq_data_update_affinity helper Date: Fri, 1 Jul 2022 15:00:54 -0500 Message-Id: <20220701200056.46555-7-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Some architectures and irqchip drivers modify the cpumask returned by irq_data_get_affinity_mask, usually by copying in to it. This is problematic for uniprocessor configurations, where the affinity mask should be constant, as it is known at compile time. Add and use a setter for the affinity mask, following the pattern of irq_data_update_effective_affinity. This allows the getter function to return a const cpumask pointer. Signed-off-by: Samuel Holland --- Changes in v3: - New patch to introduce irq_data_update_affinity arch/alpha/kernel/irq.c | 2 +- arch/ia64/kernel/iosapic.c | 2 +- arch/ia64/kernel/irq.c | 4 ++-- arch/ia64/kernel/msi_ia64.c | 4 ++-- arch/parisc/kernel/irq.c | 2 +- drivers/irqchip/irq-bcm6345-l1.c | 4 ++-- drivers/parisc/iosapic.c | 2 +- drivers/sh/intc/chip.c | 2 +- drivers/xen/events/events_base.c | 7 ++++--- include/linux/irq.h | 6 ++++++ 10 files changed, 21 insertions(+), 14 deletions(-) diff --git a/arch/alpha/kernel/irq.c b/arch/alpha/kernel/irq.c index f6d2946edbd2..15f2effd6baf 100644 --- a/arch/alpha/kernel/irq.c +++ b/arch/alpha/kernel/irq.c @@ -60,7 +60,7 @@ int irq_select_affinity(unsigned int irq) cpu = (cpu < (NR_CPUS-1) ? cpu + 1 : 0); last_cpu = cpu; - cpumask_copy(irq_data_get_affinity_mask(data), cpumask_of(cpu)); + irq_data_update_affinity(data, cpumask_of(cpu)); chip->irq_set_affinity(data, cpumask_of(cpu), false); return 0; } diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c index 35adcf89035a..99300850abc1 100644 --- a/arch/ia64/kernel/iosapic.c +++ b/arch/ia64/kernel/iosapic.c @@ -834,7 +834,7 @@ iosapic_unregister_intr (unsigned int gsi) if (iosapic_intr_info[irq].count == 0) { #ifdef CONFIG_SMP /* Clear affinity */ - cpumask_setall(irq_get_affinity_mask(irq)); + irq_data_update_affinity(irq_get_irq_data(irq), cpu_all_mask); #endif /* Clear the interrupt information */ iosapic_intr_info[irq].dest = 0; diff --git a/arch/ia64/kernel/irq.c b/arch/ia64/kernel/irq.c index ecef17c7c35b..275b9ea58c64 100644 --- a/arch/ia64/kernel/irq.c +++ b/arch/ia64/kernel/irq.c @@ -57,8 +57,8 @@ static char irq_redir [NR_IRQS]; // = { [0 ... NR_IRQS-1] = 1 }; void set_irq_affinity_info (unsigned int irq, int hwid, int redir) { if (irq < NR_IRQS) { - cpumask_copy(irq_get_affinity_mask(irq), - cpumask_of(cpu_logical_id(hwid))); + irq_data_update_affinity(irq_get_irq_data(irq), + cpumask_of(cpu_logical_id(hwid))); irq_redir[irq] = (char) (redir & 0xff); } } diff --git a/arch/ia64/kernel/msi_ia64.c b/arch/ia64/kernel/msi_ia64.c index df5c28f252e3..025e5133c860 100644 --- a/arch/ia64/kernel/msi_ia64.c +++ b/arch/ia64/kernel/msi_ia64.c @@ -37,7 +37,7 @@ static int ia64_set_msi_irq_affinity(struct irq_data *idata, msg.data = data; pci_write_msi_msg(irq, &msg); - cpumask_copy(irq_data_get_affinity_mask(idata), cpumask_of(cpu)); + irq_data_update_affinity(idata, cpumask_of(cpu)); return 0; } @@ -132,7 +132,7 @@ static int dmar_msi_set_affinity(struct irq_data *data, msg.address_lo |= MSI_ADDR_DEST_ID_CPU(cpu_physical_id(cpu)); dmar_msi_write(irq, &msg); - cpumask_copy(irq_data_get_affinity_mask(data), mask); + irq_data_update_affinity(data, mask); return 0; } diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c index 0fe2d79fb123..5ebb1771b4ab 100644 --- a/arch/parisc/kernel/irq.c +++ b/arch/parisc/kernel/irq.c @@ -315,7 +315,7 @@ unsigned long txn_affinity_addr(unsigned int irq, int cpu) { #ifdef CONFIG_SMP struct irq_data *d = irq_get_irq_data(irq); - cpumask_copy(irq_data_get_affinity_mask(d), cpumask_of(cpu)); + irq_data_update_affinity(d, cpumask_of(cpu)); #endif return per_cpu(cpu_data, cpu).txn_addr; diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c index 142a7431745f..6899e37810a8 100644 --- a/drivers/irqchip/irq-bcm6345-l1.c +++ b/drivers/irqchip/irq-bcm6345-l1.c @@ -216,11 +216,11 @@ static int bcm6345_l1_set_affinity(struct irq_data *d, enabled = intc->cpus[old_cpu]->enable_cache[word] & mask; if (enabled) __bcm6345_l1_mask(d); - cpumask_copy(irq_data_get_affinity_mask(d), dest); + irq_data_update_affinity(d, dest); if (enabled) __bcm6345_l1_unmask(d); } else { - cpumask_copy(irq_data_get_affinity_mask(d), dest); + irq_data_update_affinity(d, dest); } raw_spin_unlock_irqrestore(&intc->lock, flags); diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c index 8a3b0c3a1e92..3a8c98615634 100644 --- a/drivers/parisc/iosapic.c +++ b/drivers/parisc/iosapic.c @@ -677,7 +677,7 @@ static int iosapic_set_affinity_irq(struct irq_data *d, if (dest_cpu < 0) return -1; - cpumask_copy(irq_data_get_affinity_mask(d), cpumask_of(dest_cpu)); + irq_data_update_affinity(d, cpumask_of(dest_cpu)); vi->txn_addr = txn_affinity_addr(d->irq, dest_cpu); spin_lock_irqsave(&iosapic_lock, flags); diff --git a/drivers/sh/intc/chip.c b/drivers/sh/intc/chip.c index 358df7510186..828d81e02b37 100644 --- a/drivers/sh/intc/chip.c +++ b/drivers/sh/intc/chip.c @@ -72,7 +72,7 @@ static int intc_set_affinity(struct irq_data *data, if (!cpumask_intersects(cpumask, cpu_online_mask)) return -1; - cpumask_copy(irq_data_get_affinity_mask(data), cpumask); + irq_data_update_affinity(data, cpumask); return IRQ_SET_MASK_OK_NOCOPY; } diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 46d9295d9a6e..5e8321f43cbd 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -528,9 +528,10 @@ static void bind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int cpu, BUG_ON(irq == -1); if (IS_ENABLED(CONFIG_SMP) && force_affinity) { - cpumask_copy(irq_get_affinity_mask(irq), cpumask_of(cpu)); - cpumask_copy(irq_get_effective_affinity_mask(irq), - cpumask_of(cpu)); + struct irq_data *data = irq_get_irq_data(irq); + + irq_data_update_affinity(data, cpumask_of(cpu)); + irq_data_update_effective_affinity(data, cpumask_of(cpu)); } xen_evtchn_port_bind_to_cpu(evtchn, cpu, info->cpu); diff --git a/include/linux/irq.h b/include/linux/irq.h index 69ee4e2f36ce..adcfebceb777 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -884,6 +884,12 @@ static inline struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) return d->common->affinity; } +static inline void irq_data_update_affinity(struct irq_data *d, + const struct cpumask *m) +{ + cpumask_copy(d->common->affinity, m); +} + static inline struct cpumask *irq_get_affinity_mask(int irq) { struct irq_data *d = irq_get_irq_data(irq); -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359179.588603 (Exim 4.92) (envelope-from ) id 1o7N6H-00065X-Ri; Fri, 01 Jul 2022 20:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359179.588603; Fri, 01 Jul 2022 20:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6H-00061B-IN; Fri, 01 Jul 2022 20:18:49 +0000 Received: by outflank-mailman (input) for mailman id 359179; Fri, 01 Jul 2022 20:01:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mpo-000470-Md for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:48 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a33720c3-f978-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 22:01:47 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id F1DE55802F6; Fri, 1 Jul 2022 16:01:46 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Jul 2022 16:01:46 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:41 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a33720c3-f978-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705706; x=1656712906; bh=SS qXvxPvOnT181Alnoj0HfgL9fqTJVzreJxmfCVyBec=; b=hcAoBpvIf8eiMsWnHm b6RJp+0UU2OILuy21U79vOjusxjAcQG94kzCl/SLOhhz8J4ASW+y84iY/hEL50ms +t+80HjBAylZNEJe73yGhHSZF1RSQ8RBU9Nk62QyCXZpUC4CexurEGTlBgY/Xqfo fnfCIqYMFwRBTgEwEckqi0Kl9E6cHZVfUrF5kxIWdFViA5bUJ11OHLJ7T0XapXw2 hQWKkSyPabF2oJi63qd5eTn9Zl4sQmG20eYW/wqRNYdW/SrAsFhGxn4LKFrrzqDC C0MqxbtLaYxpKOf9o9kKWlf6yKvCjeXy1x18+k24AKggcDhNdzIH/iJu5OZQ3wo4 ssMA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705706; x=1656712906; bh=SSqXvxPvOnT18 1Alnoj0HfgL9fqTJVzreJxmfCVyBec=; b=HeWsMOcvIEpk7+MFtWHCXsiI6BlFC 2TQ2SkcGU6TjX/RAuIxgMoxDlrLAJRLOQUP5M4Vjn/Sk2LIfFF6zmyCdELkbAfiW sNvfuqkLM1Vey2QklfYRRWjhcegVctGnxhxUwegYbB0z6YgklYBKnTe07fR9Aokx OJk4Rl2PfNKRw931jKDBYNYjhcdhJJxhHzUaHJY1VFb0uXTx2Qq9+O7Z8+sDYq3K dW+YTOeJLeT+EWHVFce25KHIXMDeukkeCTF05NMBW9QbVqWeENDneUsjCVRvIwS4 +pREO1Ryo1aq2EmzH+e4VaMl82vWzrZw+kMmsklRZow8dIJvLbZg3JAtQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 5/8] genirq: Refactor accessors to use irq_data_get_affinity_mask Date: Fri, 1 Jul 2022 15:00:53 -0500 Message-Id: <20220701200056.46555-6-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit A couple of functions directly reference the affinity mask. Route them through irq_data_get_affinity_mask so they will pick up any refactoring done there. Signed-off-by: Samuel Holland --- (no changes since v1) include/linux/irq.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/include/linux/irq.h b/include/linux/irq.h index 505308253d23..69ee4e2f36ce 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -879,16 +879,16 @@ static inline int irq_data_get_node(struct irq_data *d) return irq_common_data_get_node(d->common); } -static inline struct cpumask *irq_get_affinity_mask(int irq) +static inline struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) { - struct irq_data *d = irq_get_irq_data(irq); - - return d ? d->common->affinity : NULL; + return d->common->affinity; } -static inline struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) +static inline struct cpumask *irq_get_affinity_mask(int irq) { - return d->common->affinity; + struct irq_data *d = irq_get_irq_data(irq); + + return d ? irq_data_get_affinity_mask(d) : NULL; } #ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK @@ -910,7 +910,7 @@ static inline void irq_data_update_effective_affinity(struct irq_data *d, static inline struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d) { - return d->common->affinity; + return irq_data_get_affinity_mask(d); } #endif -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359183.588622 (Exim 4.92) (envelope-from ) id 1o7N6J-0006VT-2V; Fri, 01 Jul 2022 20:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359183.588622; Fri, 01 Jul 2022 20:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6I-0006S1-Pn; Fri, 01 Jul 2022 20:18:50 +0000 Received: by outflank-mailman (input) for mailman id 359183; Fri, 01 Jul 2022 20:01:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mpw-00047i-GE for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:56 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7b40081-f978-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 22:01:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 7D327580349; Fri, 1 Jul 2022 16:01:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Jul 2022 16:01:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7b40081-f978-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705714; x=1656712914; bh=eX ge2IdClR+d/3BSSaE+9pvQi9MnqCUCBzZI2A/q3+Y=; b=lImLZgXi07b4AZOlUz ewCsOrGtD6ZG0b0Mwa2BHgRwjFJmUlv0aH5fIk/DFa7yX2gI/3SZ/0xuOkd8jDjZ BbNp1qO7x0eSKZBj1sd1hXOLG/sNI5FsZUaZakMr6rsWHtRYiFSFc8hCCdBSWD+4 6O2YrMjeZ/AoZIkX9FYOQ4vEtHx1y7a1tweDcek1Ml4Gv4ckD/1v2cjeAemIIIjI oqu6hoU7YENo5WoZZrUdWM/Go6RBzeGWW8DbMfuUywji9JyCz8RN59j3Sx45lf/G fS2D7jR5wRlvMjddPMgm/uvDWZR7y/pOpjeXGCJ1ZxDL+ZZFkXsELAFJBSY9i4w8 BCpg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705714; x=1656712914; bh=eXge2IdClR+d/ 3BSSaE+9pvQi9MnqCUCBzZI2A/q3+Y=; b=swj9eb2D+mogmU8eUS1kfG8FTODks 1/zWKUjEPxZEmSvMtrBYsfF5C22QcJB4FQjn/CXr6CYKXO6MFMWUlGpNz27m2Bm3 0klqwEwuEi9mGsvk4WVshdGyJ/bVCk2NnK/JfaZMjFjdeDgGl50Q+/8Cw//Lop94 y3fvLWqnMEX83eS4l/KXUJ59M8/Qrzl7mcIo1Ivji8q2SGQYZ+wyLDsbeXvZdrFQ 2lcXegwwX6ewyuzWNdmlIJy+3BkKGlnQfYjCZDdpas0JVugj0w6PexiSaI1UznbT mwqF+H/9QSHFuUj7i7Lx+Ftx5w/bzNBrifQVKKFiIyb9S26Ed5xCveTmQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 7/8] genirq: Return a const cpumask from irq_data_get_affinity_mask Date: Fri, 1 Jul 2022 15:00:55 -0500 Message-Id: <20220701200056.46555-8-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Now that the irq_data_update_affinity helper exists, enforce its use by returning a a const cpumask from irq_data_get_affinity_mask. Since the previous commit already updated places that needed to call irq_data_update_affinity, this commit updates the remaining code that either did not modify the cpumask or immediately passed the modified mask to irq_set_affinity. Signed-off-by: Samuel Holland --- Changes in v3: - New patch to make the returned cpumasks const arch/mips/cavium-octeon/octeon-irq.c | 4 ++-- arch/sh/kernel/irq.c | 7 ++++--- arch/x86/hyperv/irqdomain.c | 2 +- arch/xtensa/kernel/irq.c | 7 ++++--- drivers/iommu/hyperv-iommu.c | 2 +- drivers/pci/controller/pci-hyperv.c | 10 +++++----- include/linux/irq.h | 12 +++++++----- kernel/irq/chip.c | 8 +++++--- kernel/irq/debugfs.c | 2 +- kernel/irq/ipi.c | 16 +++++++++------- 10 files changed, 39 insertions(+), 31 deletions(-) diff --git a/arch/mips/cavium-octeon/octeon-irq.c b/arch/mips/cavium-octeon/octeon-irq.c index 6cdcbf4de763..9cb9ed44bcaf 100644 --- a/arch/mips/cavium-octeon/octeon-irq.c +++ b/arch/mips/cavium-octeon/octeon-irq.c @@ -263,7 +263,7 @@ static int next_cpu_for_irq(struct irq_data *data) #ifdef CONFIG_SMP int cpu; - struct cpumask *mask = irq_data_get_affinity_mask(data); + const struct cpumask *mask = irq_data_get_affinity_mask(data); int weight = cpumask_weight(mask); struct octeon_ciu_chip_data *cd = irq_data_get_irq_chip_data(data); @@ -758,7 +758,7 @@ static void octeon_irq_cpu_offline_ciu(struct irq_data *data) { int cpu = smp_processor_id(); cpumask_t new_affinity; - struct cpumask *mask = irq_data_get_affinity_mask(data); + const struct cpumask *mask = irq_data_get_affinity_mask(data); if (!cpumask_test_cpu(cpu, mask)) return; diff --git a/arch/sh/kernel/irq.c b/arch/sh/kernel/irq.c index ef0f0827cf57..56269c2c3414 100644 --- a/arch/sh/kernel/irq.c +++ b/arch/sh/kernel/irq.c @@ -230,16 +230,17 @@ void migrate_irqs(void) struct irq_data *data = irq_get_irq_data(irq); if (irq_data_get_node(data) == cpu) { - struct cpumask *mask = irq_data_get_affinity_mask(data); + const struct cpumask *mask = irq_data_get_affinity_mask(data); unsigned int newcpu = cpumask_any_and(mask, cpu_online_mask); if (newcpu >= nr_cpu_ids) { pr_info_ratelimited("IRQ%u no longer affine to CPU%u\n", irq, cpu); - cpumask_setall(mask); + irq_set_affinity(irq, cpu_all_mask); + } else { + irq_set_affinity(irq, mask); } - irq_set_affinity(irq, mask); } } } diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c index 7e0f6bedc248..42c70d28ef27 100644 --- a/arch/x86/hyperv/irqdomain.c +++ b/arch/x86/hyperv/irqdomain.c @@ -192,7 +192,7 @@ static void hv_irq_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) struct pci_dev *dev; struct hv_interrupt_entry out_entry, *stored_entry; struct irq_cfg *cfg = irqd_cfg(data); - cpumask_t *affinity; + const cpumask_t *affinity; int cpu; u64 status; diff --git a/arch/xtensa/kernel/irq.c b/arch/xtensa/kernel/irq.c index 529fe9245821..42f106004400 100644 --- a/arch/xtensa/kernel/irq.c +++ b/arch/xtensa/kernel/irq.c @@ -169,7 +169,7 @@ void migrate_irqs(void) for_each_active_irq(i) { struct irq_data *data = irq_get_irq_data(i); - struct cpumask *mask; + const struct cpumask *mask; unsigned int newcpu; if (irqd_is_per_cpu(data)) @@ -185,9 +185,10 @@ void migrate_irqs(void) pr_info_ratelimited("IRQ%u no longer affine to CPU%u\n", i, cpu); - cpumask_setall(mask); + irq_set_affinity(i, cpu_all_mask); + } else { + irq_set_affinity(i, mask); } - irq_set_affinity(i, mask); } } #endif /* CONFIG_HOTPLUG_CPU */ diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c index e285a220c913..51bd66a45a11 100644 --- a/drivers/iommu/hyperv-iommu.c +++ b/drivers/iommu/hyperv-iommu.c @@ -194,7 +194,7 @@ hyperv_root_ir_compose_msi_msg(struct irq_data *irq_data, struct msi_msg *msg) u32 vector; struct irq_cfg *cfg; int ioapic_id; - struct cpumask *affinity; + const struct cpumask *affinity; int cpu; struct hv_interrupt_entry entry; struct hyperv_root_ir_data *data = irq_data->chip_data; diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index db814f7b93ba..aebada45569b 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -642,7 +642,7 @@ static void hv_arch_irq_unmask(struct irq_data *data) struct hv_retarget_device_interrupt *params; struct tran_int_desc *int_desc; struct hv_pcibus_device *hbus; - struct cpumask *dest; + const struct cpumask *dest; cpumask_var_t tmp; struct pci_bus *pbus; struct pci_dev *pdev; @@ -1613,7 +1613,7 @@ static void hv_pci_compose_compl(void *context, struct pci_response *resp, } static u32 hv_compose_msi_req_v1( - struct pci_create_interrupt *int_pkt, struct cpumask *affinity, + struct pci_create_interrupt *int_pkt, const struct cpumask *affinity, u32 slot, u8 vector, u8 vector_count) { int_pkt->message_type.type = PCI_CREATE_INTERRUPT_MESSAGE; @@ -1641,7 +1641,7 @@ static int hv_compose_msi_req_get_cpu(struct cpumask *affinity) } static u32 hv_compose_msi_req_v2( - struct pci_create_interrupt2 *int_pkt, struct cpumask *affinity, + struct pci_create_interrupt2 *int_pkt, const struct cpumask *affinity, u32 slot, u8 vector, u8 vector_count) { int cpu; @@ -1660,7 +1660,7 @@ static u32 hv_compose_msi_req_v2( } static u32 hv_compose_msi_req_v3( - struct pci_create_interrupt3 *int_pkt, struct cpumask *affinity, + struct pci_create_interrupt3 *int_pkt, const struct cpumask *affinity, u32 slot, u32 vector, u8 vector_count) { int cpu; @@ -1697,7 +1697,7 @@ static void hv_compose_msi_msg(struct irq_data *data, struct msi_msg *msg) struct hv_pci_dev *hpdev; struct pci_bus *pbus; struct pci_dev *pdev; - struct cpumask *dest; + const struct cpumask *dest; struct compose_comp_ctxt comp; struct tran_int_desc *int_desc; struct msi_desc *msi_desc; diff --git a/include/linux/irq.h b/include/linux/irq.h index adcfebceb777..02073f7a156e 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -879,7 +879,8 @@ static inline int irq_data_get_node(struct irq_data *d) return irq_common_data_get_node(d->common); } -static inline struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) +static inline +const struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) { return d->common->affinity; } @@ -890,7 +891,7 @@ static inline void irq_data_update_affinity(struct irq_data *d, cpumask_copy(d->common->affinity, m); } -static inline struct cpumask *irq_get_affinity_mask(int irq) +static inline const struct cpumask *irq_get_affinity_mask(int irq) { struct irq_data *d = irq_get_irq_data(irq); @@ -899,7 +900,7 @@ static inline struct cpumask *irq_get_affinity_mask(int irq) #ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK static inline -struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d) +const struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d) { return d->common->effective_affinity; } @@ -914,13 +915,14 @@ static inline void irq_data_update_effective_affinity(struct irq_data *d, { } static inline -struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d) +const struct cpumask *irq_data_get_effective_affinity_mask(struct irq_data *d) { return irq_data_get_affinity_mask(d); } #endif -static inline struct cpumask *irq_get_effective_affinity_mask(unsigned int irq) +static inline +const struct cpumask *irq_get_effective_affinity_mask(unsigned int irq) { struct irq_data *d = irq_get_irq_data(irq); diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c index 886789dcee43..9c7ad2266317 100644 --- a/kernel/irq/chip.c +++ b/kernel/irq/chip.c @@ -188,7 +188,8 @@ enum { #ifdef CONFIG_SMP static int -__irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force) +__irq_startup_managed(struct irq_desc *desc, const struct cpumask *aff, + bool force) { struct irq_data *d = irq_desc_get_irq_data(desc); @@ -224,7 +225,8 @@ __irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force) } #else static __always_inline int -__irq_startup_managed(struct irq_desc *desc, struct cpumask *aff, bool force) +__irq_startup_managed(struct irq_desc *desc, const struct cpumask *aff, + bool force) { return IRQ_STARTUP_NORMAL; } @@ -252,7 +254,7 @@ static int __irq_startup(struct irq_desc *desc) int irq_startup(struct irq_desc *desc, bool resend, bool force) { struct irq_data *d = irq_desc_get_irq_data(desc); - struct cpumask *aff = irq_data_get_affinity_mask(d); + const struct cpumask *aff = irq_data_get_affinity_mask(d); int ret = 0; desc->depth = 0; diff --git a/kernel/irq/debugfs.c b/kernel/irq/debugfs.c index bc8e40cf2b65..bbcaac64038e 100644 --- a/kernel/irq/debugfs.c +++ b/kernel/irq/debugfs.c @@ -30,7 +30,7 @@ static void irq_debug_show_bits(struct seq_file *m, int ind, unsigned int state, static void irq_debug_show_masks(struct seq_file *m, struct irq_desc *desc) { struct irq_data *data = irq_desc_get_irq_data(desc); - struct cpumask *msk; + const struct cpumask *msk; msk = irq_data_get_affinity_mask(data); seq_printf(m, "affinity: %*pbl\n", cpumask_pr_args(msk)); diff --git a/kernel/irq/ipi.c b/kernel/irq/ipi.c index 08ce7da3b57c..bbd945bacef0 100644 --- a/kernel/irq/ipi.c +++ b/kernel/irq/ipi.c @@ -115,11 +115,11 @@ int irq_reserve_ipi(struct irq_domain *domain, int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest) { struct irq_data *data = irq_get_irq_data(irq); - struct cpumask *ipimask = data ? irq_data_get_affinity_mask(data) : NULL; + const struct cpumask *ipimask; struct irq_domain *domain; unsigned int nr_irqs; - if (!irq || !data || !ipimask) + if (!irq || !data) return -EINVAL; domain = data->domain; @@ -131,7 +131,8 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest) return -EINVAL; } - if (WARN_ON(!cpumask_subset(dest, ipimask))) + ipimask = irq_data_get_affinity_mask(data); + if (!ipimask || WARN_ON(!cpumask_subset(dest, ipimask))) /* * Must be destroying a subset of CPUs to which this IPI * was set up to target @@ -162,12 +163,13 @@ int irq_destroy_ipi(unsigned int irq, const struct cpumask *dest) irq_hw_number_t ipi_get_hwirq(unsigned int irq, unsigned int cpu) { struct irq_data *data = irq_get_irq_data(irq); - struct cpumask *ipimask = data ? irq_data_get_affinity_mask(data) : NULL; + const struct cpumask *ipimask; - if (!data || !ipimask || cpu >= nr_cpu_ids) + if (!data || cpu >= nr_cpu_ids) return INVALID_HWIRQ; - if (!cpumask_test_cpu(cpu, ipimask)) + ipimask = irq_data_get_affinity_mask(data); + if (!ipimask || !cpumask_test_cpu(cpu, ipimask)) return INVALID_HWIRQ; /* @@ -186,7 +188,7 @@ EXPORT_SYMBOL_GPL(ipi_get_hwirq); static int ipi_send_verify(struct irq_chip *chip, struct irq_data *data, const struct cpumask *dest, unsigned int cpu) { - struct cpumask *ipimask = irq_data_get_affinity_mask(data); + const struct cpumask *ipimask = irq_data_get_affinity_mask(data); if (!chip || !ipimask) return -EINVAL; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359175.588585 (Exim 4.92) (envelope-from ) id 1o7N6G-0005kd-Sf; Fri, 01 Jul 2022 20:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359175.588585; Fri, 01 Jul 2022 20:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6G-0005j7-NK; Fri, 01 Jul 2022 20:18:48 +0000 Received: by outflank-mailman (input) for mailman id 359175; Fri, 01 Jul 2022 20:01:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mpe-000470-1N for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:38 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9cd5a3ab-f978-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 22:01:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 4055A5802F0; Fri, 1 Jul 2022 16:01:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Jul 2022 16:01:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:30 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cd5a3ab-f978-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705696; x=1656712896; bh=D0 9F9v2OsTHtUMBckCisA3fh+Z9dxIk2ZgixoBozn6s=; b=ewPaKoSkHX2BJXiLrX 5+oSIjybcWAklW5wxV0V+2224R1S5aSbhX/ZumtO+pevNUEajJ4W+xkdb1xobtmO 5XYTY4EQgS3vI31X9KpJqpcSStss2CBfMnsdLsoEi24/QiILGCKcwtKmT3IHTl3M Mv1Py5jjNaGrcKT545FKqrpJreT45hH04ngq4b9+jLCXhOz/SJLgVou/odMMcxHf jE7L5Oa7EAAx5jIAr6O1i4neJfVW0AS/PUT6wWsmA07a/DS+FN2RC5D0zeLTTFHO gxpbBrSPW1wLPGNr1k53E8cUdIxhDr0COGRwcsfZT5hqn7efH9ktohj1e3H0gw2y IDKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705696; x=1656712896; bh=D09F9v2OsTHtU MBckCisA3fh+Z9dxIk2ZgixoBozn6s=; b=TBQ5zmWoRj8elXqnGUzA7FTSfUjgW 8okx2QN7XCl3ky8WadN5LKY6hzwdOfA9BJ0eXRmer/tFEiAUvbmU6wyJhpcSQZgj Rmt76VA2NSnO3ovcCIK5WjyW5TFWl9HMcuavVAdkHsJTygI2nPusqodgPFJV4ZxT L/edAsj355kbI6l/RzXXpdx9yUIvX2RXPv6ueqmRU44epIbZ+yjNJpk1CA53x/K2 6amlSq383hivdloACmsNrkmMJ+PWpdATylN2kVPVACnX4rT6i/tvFuKDeoqp86hr Enu7oREUdbzL42YZLwjDCYWMY8dHPJjpHxLTP4IgdrwaIjKWoEmRjseFA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 3/8] genirq: GENERIC_IRQ_EFFECTIVE_AFF_MASK depends on SMP Date: Fri, 1 Jul 2022 15:00:51 -0500 Message-Id: <20220701200056.46555-4-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit An IRQ's effective affinity can only be different from its configured affinity if there are multiple CPUs. Make it clear that this option is only meaningful when SMP is enabled. Most of the relevant code in irqdesc.c is already hidden behind CONFIG_SMP anyway. Signed-off-by: Samuel Holland --- (no changes since v1) arch/arm/mach-hisi/Kconfig | 2 +- drivers/irqchip/Kconfig | 14 +++++++------- kernel/irq/Kconfig | 1 + 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/arch/arm/mach-hisi/Kconfig b/arch/arm/mach-hisi/Kconfig index 75cccbd3f05f..7b3440687176 100644 --- a/arch/arm/mach-hisi/Kconfig +++ b/arch/arm/mach-hisi/Kconfig @@ -40,7 +40,7 @@ config ARCH_HIP04 select HAVE_ARM_ARCH_TIMER select MCPM if SMP select MCPM_QUAD_CLUSTER if SMP - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP help Support for Hisilicon HiP04 SoC family diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 5dd98a81efc8..462adac905a6 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -8,7 +8,7 @@ config IRQCHIP config ARM_GIC bool select IRQ_DOMAIN_HIERARCHY - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config ARM_GIC_PM bool @@ -34,7 +34,7 @@ config ARM_GIC_V3 bool select IRQ_DOMAIN_HIERARCHY select PARTITION_PERCPU - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config ARM_GIC_V3_ITS bool @@ -76,7 +76,7 @@ config ARMADA_370_XP_IRQ bool select GENERIC_IRQ_CHIP select PCI_MSI if PCI - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config ALPINE_MSI bool @@ -112,7 +112,7 @@ config BCM6345_L1_IRQ bool select GENERIC_IRQ_CHIP select IRQ_DOMAIN - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config BCM7038_L1_IRQ tristate "Broadcom STB 7038-style L1/L2 interrupt controller driver" @@ -120,7 +120,7 @@ config BCM7038_L1_IRQ default ARCH_BRCMSTB || BMIPS_GENERIC select GENERIC_IRQ_CHIP select IRQ_DOMAIN - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config BCM7120_L2_IRQ tristate "Broadcom STB 7120-style L2 interrupt controller driver" @@ -179,7 +179,7 @@ config IRQ_MIPS_CPU select GENERIC_IRQ_CHIP select GENERIC_IRQ_IPI if SMP && SYS_SUPPORTS_MULTITHREADING select IRQ_DOMAIN - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config CLPS711X_IRQCHIP bool @@ -294,7 +294,7 @@ config VERSATILE_FPGA_IRQ_NR config XTENSA_MX bool select IRQ_DOMAIN - select GENERIC_IRQ_EFFECTIVE_AFF_MASK + select GENERIC_IRQ_EFFECTIVE_AFF_MASK if SMP config XILINX_INTC bool "Xilinx Interrupt Controller IP" diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index fc760d064a65..db3d174c53d4 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -24,6 +24,7 @@ config GENERIC_IRQ_SHOW_LEVEL # Supports effective affinity mask config GENERIC_IRQ_EFFECTIVE_AFF_MASK + depends on SMP bool # Support for delayed migration from interrupt context -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359169.588567 (Exim 4.92) (envelope-from ) id 1o7N6F-0005TU-SK; Fri, 01 Jul 2022 20:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359169.588567; Fri, 01 Jul 2022 20:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6F-0005TN-Ot; Fri, 01 Jul 2022 20:18:47 +0000 Received: by outflank-mailman (input) for mailman id 359169; Fri, 01 Jul 2022 20:01:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MpJ-000470-V1 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:18 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d8d8aa0-f978-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 22:01:13 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 28AC058020B; Fri, 1 Jul 2022 16:01:10 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 01 Jul 2022 16:01:10 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:00:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d8d8aa0-f978-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=1656705670; x=1656712870; bh=h3WN3AcddFJuwhQ39XPEdgr5t ejPWmRF9a5JWUKLi6w=; b=mK5frjjpRETCdaizhOvpq/mQo5UlOZqfHCt356wLu +SqVP3qKJ9LvP7YyRWEopUxCgCJ/Co0nb1GRIXbVwdtlJ5JrYoRlSvc+27WDag9+ 3jqJC6Nc5lLjDB1EbFnpv2S6VMiJgoGG3ESQyrzvFx4wbwb1+hfvfkj14nzE1iZ9 iHVs2Uh7tOwAj5coKNt98E1KuIr4Dy7ZidSi8Si+tRxxbGIc8g9/Wkp/PXxkdKWp GwXvkDhS2Mkt7Y8U+OzIUgUEfaENyM7PjR+7UVXgmM8J+652ddmFvBKyk157w8wr Skl8C3hKCbHheCLVFZJbuy7hz1/cffoSdxxCfnrh8YV+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1656705670; x=1656712870; bh=h3WN3AcddFJuwhQ39XPEdgr5tejPWmRF9a5 JWUKLi6w=; b=hcCVwh1PvSeKLtV/WWesjzpJEJOw4znKr5Z/2vhxnZuKQA9kLw4 /4+bCBG81guTmscsfsRlkY2MRf/An6IfLb4PqUB9cFC2NzaudqFlvP/yY19K+3XC pDHCoLiIcwUV2Xv5FAIqCmEYAOVR+oCL2f261uukUnOGmb9sZJ1Wjru1FpMPNx9q O20C8qlSGZIk/uqxcd6LnT2yDuqwiTmpUUWND72se1ELzfF/mrU6icJu6Gm0jlH3 iWOFR5OoOCZxlEPQplc7c7ud1SjE6qek/nk6mnJ70FNjkvapXHjyVwlAV5qpv1MZ 45+fzYTFXAvc9YboPqeOQ31my0wQpPDiZ5Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpeekheffteehtdetfffgfeetteejvdefleeuvedufffguedtjedvheel vddvfffhveenucffohhmrghinhepkhgvrhhnvghlrdhorhhgnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshgrmhhuvghlsehshhholhhlrghn ugdrohhrgh X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 0/8] genirq: Provide real IRQ affinity masks in non-SMP configs Date: Fri, 1 Jul 2022 15:00:48 -0500 Message-Id: <20220701200056.46555-1-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series solves some inconsistency with how IRQ affinity masks are handled between SMP and non-SMP configurations. In non-SMP configs, an IRQ's true affinity is always cpumask_of(0), so irq_{,data_}get_affinity_mask now return that, instead of returning an uninitialized per-IRQ cpumask. This change makes iterating over the affinity mask do the right thing in both SMP and non-SMP configurations. To accomplish that: - patches 1-3 disable some library code that was broken anyway on !SMP - patches 4-7 refactor the code so that irq_{,data_}get_affinity_mask can return a const cpumask, since that is what cpumask_of provides - patch 8 drops the per-IRQ cpumask and replaces it with cpumask_of(0) This series was split from the v2 series here, which uses the new behavior in the RISC-V PLIC irqchip driver: https://lore.kernel.org/lkml/20220616064028.57933-1-samuel@sholland.org/ Changes in v3: - New patch to fix build errors in uniprocessor MIPS configs - New patch to drop irq_init_effective_affinity - New patch to introduce irq_data_update_affinity - New patch to make the returned cpumasks const - Use cpumask_of(0) instead of cpu_possible_mask Changes in v2: - New patch to prevent GENERIC_IRQ_IPI from being selected on !SMP Samuel Holland (8): irqchip/mips-gic: Only register IPI domain when SMP is enabled genirq: GENERIC_IRQ_IPI depends on SMP genirq: GENERIC_IRQ_EFFECTIVE_AFF_MASK depends on SMP genirq: Drop redundant irq_init_effective_affinity genirq: Refactor accessors to use irq_data_get_affinity_mask genirq: Add and use an irq_data_update_affinity helper genirq: Return a const cpumask from irq_data_get_affinity_mask genirq: Provide an IRQ affinity mask in non-SMP configs arch/alpha/kernel/irq.c | 2 +- arch/arm/mach-hisi/Kconfig | 2 +- arch/ia64/kernel/iosapic.c | 2 +- arch/ia64/kernel/irq.c | 4 +- arch/ia64/kernel/msi_ia64.c | 4 +- arch/mips/cavium-octeon/octeon-irq.c | 4 +- arch/parisc/kernel/irq.c | 2 +- arch/sh/kernel/irq.c | 7 +-- arch/x86/hyperv/irqdomain.c | 2 +- arch/xtensa/kernel/irq.c | 7 +-- drivers/iommu/hyperv-iommu.c | 2 +- drivers/irqchip/Kconfig | 19 +++---- drivers/irqchip/irq-bcm6345-l1.c | 4 +- drivers/irqchip/irq-mips-gic.c | 80 +++++++++++++++++++--------- drivers/parisc/iosapic.c | 2 +- drivers/pci/controller/pci-hyperv.c | 10 ++-- drivers/sh/intc/chip.c | 2 +- drivers/xen/events/events_base.c | 7 +-- include/linux/irq.h | 34 ++++++++---- kernel/irq/Kconfig | 2 + kernel/irq/chip.c | 8 +-- kernel/irq/debugfs.c | 2 +- kernel/irq/ipi.c | 16 +++--- kernel/irq/manage.c | 10 +--- 24 files changed, 140 insertions(+), 94 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359185.588635 (Exim 4.92) (envelope-from ) id 1o7N6K-0006km-4E; Fri, 01 Jul 2022 20:18:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359185.588635; Fri, 01 Jul 2022 20:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6J-0006i0-Fm; Fri, 01 Jul 2022 20:18:51 +0000 Received: by outflank-mailman (input) for mailman id 359185; Fri, 01 Jul 2022 20:01:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mpy-00047i-Q4 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:58 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a961d304-f978-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 22:01:58 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id 50D84580357; Fri, 1 Jul 2022 16:01:57 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Jul 2022 16:01:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:54 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a961d304-f978-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705717; x=1656712917; bh=mr ZZqztLVKSIkpl2ZtG9SZsAXGvA9Vl+x5zOkvs3Bjg=; b=ifFqAwFeM2wxyJCvKE TcogHoKvz8Ikgyvbheen4lB6TK8my3nTFtPtZqZwV2EJoW1d675CVWiRCQYrtpCV gjmX3xfutUzOU3hClg0Njj4ieVpzITbRxgXZVuosglRi9Ve/QUV4hEboq9Cl6D5q 5ZUDm0FkkQme2ysoms3ELh8Ej8sCf/bY7d3513Rv+xbTCp2MmH04t4WPs+p30/R/ NUoTk/RQLxrRh5NqM1X0miI8sZ9j0rcT8Y1gbcNzWv3fehEjbKWta0Zm2a34hcFz IRiPSucdZsSIbDrwFJcccZcbWOSp8i+md8XOrmXWaR/5piNMD50Sh8euiQzn0koH sIGA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705717; x=1656712917; bh=mrZZqztLVKSIk pl2ZtG9SZsAXGvA9Vl+x5zOkvs3Bjg=; b=P1MvxlIOuM7l0z+qS8yeYED1ddgJs ZCs2QYRhK40y97qVVKx50uDXKGc7mEB0wEwGcSiJsX1JtDdjkQWUx99X65YS4sz+ VfSaSS6Ie4KKuWHsotLfT5em9QY23iuX70+vsHcDY2KRtIP+aVtenEK44OuBMsai UBAjIHn3DU+BwynQs3RgoaYjQarWyRcQP7W5Gh2Uup25KvchrpUJqNUtKa3U+bgZ BTQhJ+xzfCrqL5QAda74Vyo+egxNHDbWs7GXn2vOV7ssh9klKGGfy1CHr9gnsXME J2Ch54d15PxAoSgBunXMCXpz/ijn5crnwUN/1XIG9K1lsPwNHpUnb99dA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpeegnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 8/8] genirq: Provide an IRQ affinity mask in non-SMP configs Date: Fri, 1 Jul 2022 15:00:56 -0500 Message-Id: <20220701200056.46555-9-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit IRQ affinity masks are not allocated in uniprocessor configurations. This requires special case non-SMP code in drivers for irqchips which have per-CPU enable or mask registers. Since IRQ affinity is always the same in a uniprocessor configuration, we can provide a correct affinity mask without allocating one per IRQ. By returning a real cpumask from irq_data_get_affinity_mask even when SMP is disabled, irqchip drivers which iterate over that mask will automatically do the right thing. Signed-off-by: Samuel Holland --- Changes in v3: - Use cpumask_of(0) instead of cpu_possible_mask include/linux/irq.h | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/include/linux/irq.h b/include/linux/irq.h index 02073f7a156e..996e22744edd 100644 --- a/include/linux/irq.h +++ b/include/linux/irq.h @@ -151,7 +151,9 @@ struct irq_common_data { #endif void *handler_data; struct msi_desc *msi_desc; +#ifdef CONFIG_SMP cpumask_var_t affinity; +#endif #ifdef CONFIG_GENERIC_IRQ_EFFECTIVE_AFF_MASK cpumask_var_t effective_affinity; #endif @@ -882,13 +884,19 @@ static inline int irq_data_get_node(struct irq_data *d) static inline const struct cpumask *irq_data_get_affinity_mask(struct irq_data *d) { +#ifdef CONFIG_SMP return d->common->affinity; +#else + return cpumask_of(0); +#endif } static inline void irq_data_update_affinity(struct irq_data *d, const struct cpumask *m) { +#ifdef CONFIG_SMP cpumask_copy(d->common->affinity, m); +#endif } static inline const struct cpumask *irq_get_affinity_mask(int irq) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359173.588576 (Exim 4.92) (envelope-from ) id 1o7N6G-0005cr-Cx; Fri, 01 Jul 2022 20:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359173.588576; Fri, 01 Jul 2022 20:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6G-0005be-9O; Fri, 01 Jul 2022 20:18:48 +0000 Received: by outflank-mailman (input) for mailman id 359173; Fri, 01 Jul 2022 20:01:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MpX-000470-F1 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:31 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9903102a-f978-11ec-bd2d-47488cf2e6aa; Fri, 01 Jul 2022 22:01:30 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id D5ADC580285; Fri, 1 Jul 2022 16:01:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 01 Jul 2022 16:01:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9903102a-f978-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705689; x=1656712889; bh=f2 gTOnVVlawVp6N5bLg8smmhsDaH+rFeOulG3ok0Jrc=; b=S00usAZDc/YM64VNCn FjrEnQNeYOIV4LNXFxrNe+DvmbJ1spyaNknAlkMKCOYdB8xZAB6BY9sx7dI8cRwD aNrKuvCkIxj/PKyZRFpy+snzjxdT/wGYVUKvGizh4ybfVco0jpNkt9KuqI3lODmv VgMOfXezM/xbArBQvHUjLN61LUq2x7L0hMa6QJigRe0ReXc8M/xo9kR71pvG5fav zb0DMcwbxYzRwjHctt2+SKmtMgzgd0yTB8uENd3D0VqTECGgquIpAjLlEagHYC3j iGuAmAltKJ2/jWPPQ1vs09gP9bynvMqw+WFPrd9CKAWkKbcNwG53wW45gJRugpgB 7etg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705689; x=1656712889; bh=f2gTOnVVlawVp 6N5bLg8smmhsDaH+rFeOulG3ok0Jrc=; b=p8dJ+iBG+yyKxcHv8Ird4QI+8K5e2 deriiVPbLfaAp7jH0aTFXbKRlCyn1EkHQyKB2khg8+haSRMztqOCdPVXCF1Z0WCH XMZ2dC520GBYyCM3t4JRbY69RiaW08lpNIFhNE6+kx66gd+4fAfUbrwSyPs6mbPc nB4SQ4rjMwxLFceJ639l6X5Gnfabx0+YkFVX26GUHctAf/ClGo5S4UwBUh4m9yPh 5lA0hUcpMSQycZcnZaO6J6XLkQxj0nrANK1+St4Vqj9eYNEZlQb3hS2C/cwKEL+5 BILChd6I7vOuP7X0g3FgLvTGrvQkLzGX2qG9+nUpNgkqLUj+CVjSJhhdQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, kernel test robot Subject: [PATCH v3 2/8] genirq: GENERIC_IRQ_IPI depends on SMP Date: Fri, 1 Jul 2022 15:00:50 -0500 Message-Id: <20220701200056.46555-3-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The generic IPI code depends on the IRQ affinity mask being allocated and initialized. This will not be the case if SMP is disabled. Fix up the remaining driver that selected GENERIC_IRQ_IPI in a non-SMP config. Reported-by: kernel test robot Signed-off-by: Samuel Holland --- (no changes since v2) Changes in v2: - New patch to prevent GENERIC_IRQ_IPI from being selected on !SMP drivers/irqchip/Kconfig | 2 +- kernel/irq/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index d26a4ff7c99f..5dd98a81efc8 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -177,7 +177,7 @@ config MADERA_IRQ config IRQ_MIPS_CPU bool select GENERIC_IRQ_CHIP - select GENERIC_IRQ_IPI if SYS_SUPPORTS_MULTITHREADING + select GENERIC_IRQ_IPI if SMP && SYS_SUPPORTS_MULTITHREADING select IRQ_DOMAIN select GENERIC_IRQ_EFFECTIVE_AFF_MASK diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index 10929eda9825..fc760d064a65 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -82,6 +82,7 @@ config IRQ_FASTEOI_HIERARCHY_HANDLERS # Generic IRQ IPI support config GENERIC_IRQ_IPI bool + depends on SMP select IRQ_DOMAIN_HIERARCHY # Generic MSI interrupt support -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359177.588592 (Exim 4.92) (envelope-from ) id 1o7N6H-0005xn-BX; Fri, 01 Jul 2022 20:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359177.588592; Fri, 01 Jul 2022 20:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6H-0005u7-4d; Fri, 01 Jul 2022 20:18:49 +0000 Received: by outflank-mailman (input) for mailman id 359177; Fri, 01 Jul 2022 20:01:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Mpj-00047i-2s for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:43 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ffb7752-f978-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 22:01:42 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 88D6C5802F4; Fri, 1 Jul 2022 16:01:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 01 Jul 2022 16:01:41 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:36 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ffb7752-f978-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705701; x=1656712901; bh=0L WuRMkphck+oUsETtbUMciB/g6XpbS+D68bi898KtM=; b=AqGoMTSNUno8lOmyDh KCwBkoAA7CbRzCpTwUdrVZNLF/wgidvQ7dsm+84o2fZ7gQevOX9qgVYV5nm/9kgO AMuQd8xE3VTWjlAJ7GrdD9VG7BV18Jcp9kKqlP10nOfIKsoMI+rW7kzM0NAfbTyC NWr74D8Q3JSoeOaEx9LsHr33xds/373ohmcrmDKPwF8OjXUOpnM+aWDRtp6nuvq9 kg59XMZJPKD6+LWdXV+szMDXjt+Bh7ouD13imUf0Q05dynZ6LTdGmF8mVgEGl3Bl ONZn3X292lorO+Z+uaZEodDFOzhGvINgJHQDr8YSLNCPUjVe/p4PN6U1+nlRcr03 GbWw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705701; x=1656712901; bh=0LWuRMkphck+o UsETtbUMciB/g6XpbS+D68bi898KtM=; b=oa1e9Su6i+EtxBIhYMfUYN1BBIh7+ NtLc3K9bSFNOEpdIhhM9orp+f/WF+uOfv1NI8kwLKLdemiOeS5HWJECGkfsHhJiH /wrY8WMMNhZUZUQf87Y6I2nlwQL4IKXSCH2sx7h4StxNsLo412pY5+cK8XhqNURa IF4psEvV+ZGo699etAF0/P+4jL5LalpbzQlttWsppbNEXfxA/dOghfaTOCAwlKrK KEvs69E1t/EoreKt1IwBdd8N4B9H428Bsjz94BHuby3lv0Gnlfekvlya7hY+n98C YWKS5+DGo6Bue2FdLbpuwQxoB2okv4DaH6kIF8BDFGbnyGUVJ78Jz+rvQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH v3 4/8] genirq: Drop redundant irq_init_effective_affinity Date: Fri, 1 Jul 2022 15:00:52 -0500 Message-Id: <20220701200056.46555-5-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit It does exactly the same thing as irq_data_update_effective_affinity. Signed-off-by: Samuel Holland --- Changes in v3: - New patch to drop irq_init_effective_affinity kernel/irq/manage.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index 8c396319d5ac..40fe7806cc8c 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -205,16 +205,8 @@ static void irq_validate_effective_affinity(struct irq_data *data) pr_warn_once("irq_chip %s did not update eff. affinity mask of irq %u\n", chip->name, data->irq); } - -static inline void irq_init_effective_affinity(struct irq_data *data, - const struct cpumask *mask) -{ - cpumask_copy(irq_data_get_effective_affinity_mask(data), mask); -} #else static inline void irq_validate_effective_affinity(struct irq_data *data) { } -static inline void irq_init_effective_affinity(struct irq_data *data, - const struct cpumask *mask) { } #endif int irq_do_set_affinity(struct irq_data *data, const struct cpumask *mask, @@ -347,7 +339,7 @@ static bool irq_set_affinity_deactivated(struct irq_data *data, return false; cpumask_copy(desc->irq_common_data.affinity, mask); - irq_init_effective_affinity(data, mask); + irq_data_update_effective_affinity(data, mask); irqd_set(data, IRQD_AFFINITY_SET); return true; } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 20:18:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 20:18:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359171.588571 (Exim 4.92) (envelope-from ) id 1o7N6G-0005Wg-4x; Fri, 01 Jul 2022 20:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359171.588571; Fri, 01 Jul 2022 20:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7N6G-0005Va-0C; Fri, 01 Jul 2022 20:18:48 +0000 Received: by outflank-mailman (input) for mailman id 359171; Fri, 01 Jul 2022 20:01:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7MpS-00047i-P2 for xen-devel@lists.xenproject.org; Fri, 01 Jul 2022 20:01:26 +0000 Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94c20f17-f978-11ec-bf74-3be3494bec92; Fri, 01 Jul 2022 22:01:24 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id B24605802E7; Fri, 1 Jul 2022 16:01:22 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Fri, 01 Jul 2022 16:01:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 1 Jul 2022 16:01:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c20f17-f978-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1656705682; x=1656712882; bh=1g Yq3VbEkPVty/pd1tEYQnVO1uU7x5LYLlMSe3zbDrE=; b=bdIu56u5NUcFW5hvaK 2/laTWzN8GTHoYTAZXrQlwuGxUO/51vWxcPMTA2kgfltyNMsvcq9NazmXFT1M9hf Yy7nInyHLoEyitpTjDbv3GYoUVgLpWSo40ttAnfTRma7mvNYsPbG1mejs2Qgcb3t LbFItmmgx0ui1jMDv36Wq3t0B7zszJ1O7HYnTX+/01o0+2PoRscDY1WPAVAiDqzA lL8KiMkDxHJI+62Lumh+214ubp82KV2hgQ6WmN9StyO1UxZc5Jrl4uDo5CIcMf+v w3d+EflqLt3LJ6h3D97ccfd/v3Oe7fE6Pop4QYptsoopZcfNSmaoapHf/0dyMeat KJjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1656705682; x=1656712882; bh=1gYq3VbEkPVty /pd1tEYQnVO1uU7x5LYLlMSe3zbDrE=; b=IIGVa/3L4rIIDkpm5x9kJF4p4zPgE bekRQi2xgDfEmYrxPVdTUgxGIsZGgD0mmbIIymHEeJR6lUkDl7AgH4weEwbRvI39 z+3v4BNWVNKOg4Y3UKxsTxHjzdvdNIGGn03gzsHuwPtkq11popiSb4aRYBnIvyaL L3pj53Cf9IJhHuC3KtMRhkQ9lEVDTzotxVI7nK9L+t1iY2zY5ZlKJF5XkZlzy1kW qRxbxA7qUT5pUcyoRZWtPspZfkyMkSc2u3lh/Z1BI0SuCIzlQIrm1Ogt1M9ktsDh yae+YwhKLB+1GibJY4Yhz0XeYPpHVyQA4KoXzDl26EyU2QNQe5gKGx26w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehfedgudeggecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeeh gfdufeeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail From: Samuel Holland To: Marc Zyngier , Thomas Gleixner Cc: Samuel Holland , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, kernel test robot Subject: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled Date: Fri, 1 Jul 2022 15:00:49 -0500 Message-Id: <20220701200056.46555-2-samuel@sholland.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220701200056.46555-1-samuel@sholland.org> References: <20220701200056.46555-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The MIPS GIC irqchip driver may be selected in a uniprocessor configuration, but it unconditionally registers an IPI domain. Limit the part of the driver dealing with IPIs to only be compiled when GENERIC_IRQ_IPI is enabled, which corresponds to an SMP configuration. Reported-by: kernel test robot Signed-off-by: Samuel Holland --- Changes in v3: - New patch to fix build errors in uniprocessor MIPS configs drivers/irqchip/Kconfig | 3 +- drivers/irqchip/irq-mips-gic.c | 80 +++++++++++++++++++++++----------- 2 files changed, 56 insertions(+), 27 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index 1f23a6be7d88..d26a4ff7c99f 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -322,7 +322,8 @@ config KEYSTONE_IRQ config MIPS_GIC bool - select GENERIC_IRQ_IPI + select GENERIC_IRQ_IPI if SMP + select IRQ_DOMAIN_HIERARCHY select MIPS_CM config INGENIC_IRQ diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c index ff89b36267dd..8a9efb6ae587 100644 --- a/drivers/irqchip/irq-mips-gic.c +++ b/drivers/irqchip/irq-mips-gic.c @@ -52,13 +52,15 @@ static DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks); static DEFINE_SPINLOCK(gic_lock); static struct irq_domain *gic_irq_domain; -static struct irq_domain *gic_ipi_domain; static int gic_shared_intrs; static unsigned int gic_cpu_pin; static unsigned int timer_cpu_pin; static struct irq_chip gic_level_irq_controller, gic_edge_irq_controller; + +#ifdef CONFIG_GENERIC_IRQ_IPI static DECLARE_BITMAP(ipi_resrv, GIC_MAX_INTRS); static DECLARE_BITMAP(ipi_available, GIC_MAX_INTRS); +#endif /* CONFIG_GENERIC_IRQ_IPI */ static struct gic_all_vpes_chip_data { u32 map; @@ -472,9 +474,11 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, u32 map; if (hwirq >= GIC_SHARED_HWIRQ_BASE) { +#ifdef CONFIG_GENERIC_IRQ_IPI /* verify that shared irqs don't conflict with an IPI irq */ if (test_bit(GIC_HWIRQ_TO_SHARED(hwirq), ipi_resrv)) return -EBUSY; +#endif /* CONFIG_GENERIC_IRQ_IPI */ err = irq_domain_set_hwirq_and_chip(d, virq, hwirq, &gic_level_irq_controller, @@ -567,6 +571,8 @@ static const struct irq_domain_ops gic_irq_domain_ops = { .map = gic_irq_domain_map, }; +#ifdef CONFIG_GENERIC_IRQ_IPI + static int gic_ipi_domain_xlate(struct irq_domain *d, struct device_node *ctrlr, const u32 *intspec, unsigned int intsize, irq_hw_number_t *out_hwirq, @@ -670,6 +676,48 @@ static const struct irq_domain_ops gic_ipi_domain_ops = { .match = gic_ipi_domain_match, }; +static int gic_register_ipi_domain(struct device_node *node) +{ + struct irq_domain *gic_ipi_domain; + unsigned int v[2], num_ipis; + + gic_ipi_domain = irq_domain_add_hierarchy(gic_irq_domain, + IRQ_DOMAIN_FLAG_IPI_PER_CPU, + GIC_NUM_LOCAL_INTRS + gic_shared_intrs, + node, &gic_ipi_domain_ops, NULL); + if (!gic_ipi_domain) { + pr_err("Failed to add IPI domain"); + return -ENXIO; + } + + irq_domain_update_bus_token(gic_ipi_domain, DOMAIN_BUS_IPI); + + if (node && + !of_property_read_u32_array(node, "mti,reserved-ipi-vectors", v, 2)) { + bitmap_set(ipi_resrv, v[0], v[1]); + } else { + /* + * Reserve 2 interrupts per possible CPU/VP for use as IPIs, + * meeting the requirements of arch/mips SMP. + */ + num_ipis = 2 * num_possible_cpus(); + bitmap_set(ipi_resrv, gic_shared_intrs - num_ipis, num_ipis); + } + + bitmap_copy(ipi_available, ipi_resrv, GIC_MAX_INTRS); + + return 0; +} + +#else /* !CONFIG_GENERIC_IRQ_IPI */ + +static inline int gic_register_ipi_domain(struct device_node *node) +{ + return 0; +} + +#endif /* !CONFIG_GENERIC_IRQ_IPI */ + static int gic_cpu_startup(unsigned int cpu) { /* Enable or disable EIC */ @@ -688,11 +736,12 @@ static int gic_cpu_startup(unsigned int cpu) static int __init gic_of_init(struct device_node *node, struct device_node *parent) { - unsigned int cpu_vec, i, gicconfig, v[2], num_ipis; + unsigned int cpu_vec, i, gicconfig; unsigned long reserved; phys_addr_t gic_base; struct resource res; size_t gic_len; + int ret; /* Find the first available CPU vector. */ i = 0; @@ -780,30 +829,9 @@ static int __init gic_of_init(struct device_node *node, return -ENXIO; } - gic_ipi_domain = irq_domain_add_hierarchy(gic_irq_domain, - IRQ_DOMAIN_FLAG_IPI_PER_CPU, - GIC_NUM_LOCAL_INTRS + gic_shared_intrs, - node, &gic_ipi_domain_ops, NULL); - if (!gic_ipi_domain) { - pr_err("Failed to add IPI domain"); - return -ENXIO; - } - - irq_domain_update_bus_token(gic_ipi_domain, DOMAIN_BUS_IPI); - - if (node && - !of_property_read_u32_array(node, "mti,reserved-ipi-vectors", v, 2)) { - bitmap_set(ipi_resrv, v[0], v[1]); - } else { - /* - * Reserve 2 interrupts per possible CPU/VP for use as IPIs, - * meeting the requirements of arch/mips SMP. - */ - num_ipis = 2 * num_possible_cpus(); - bitmap_set(ipi_resrv, gic_shared_intrs - num_ipis, num_ipis); - } - - bitmap_copy(ipi_available, ipi_resrv, GIC_MAX_INTRS); + ret = gic_register_ipi_domain(node); + if (ret) + return ret; board_bind_eic_interrupt = &gic_bind_eic_interrupt; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 01 21:29:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 21:29:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359244.588666 (Exim 4.92) (envelope-from ) id 1o7OCG-0001Kv-Tx; Fri, 01 Jul 2022 21:29:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359244.588666; Fri, 01 Jul 2022 21:29:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7OCG-0001Ko-QF; Fri, 01 Jul 2022 21:29:04 +0000 Received: by outflank-mailman (input) for mailman id 359244; Fri, 01 Jul 2022 21:29:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7OCF-0001Ke-2L; Fri, 01 Jul 2022 21:29:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7OCE-0003DU-WB; Fri, 01 Jul 2022 21:29:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7OCE-0007ij-JL; Fri, 01 Jul 2022 21:29:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7OCE-0008I3-Iu; Fri, 01 Jul 2022 21:29:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OKvqkIdXnqzpLGOhkfto0PCQKOvRlZ5dexiIWPVhA70=; b=gk0s5QiZMVF+hBY6/X1w8QgFRl 8KaFhvORcCz/d5gLx9VlTVw86HEwmYgKiZMU14m28t+g8k2ba02fsZWrgri7FYBnUTf19d2nkvmg1 lDDo+mzVnMLZhZ8fzC9oLG6lSxUeCEABebbXLAKnxddQFkhUJgz23w3szvoA8pDVyFls=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171446: all pass - PUSHED X-Osstest-Versions-This: ovmf=e1eef3a8b01a25e75abf63d15bdc90157a74cba9 X-Osstest-Versions-That: ovmf=70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1 From: osstest service owner Date: Fri, 01 Jul 2022 21:29:02 +0000 flight 171446 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171446/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e1eef3a8b01a25e75abf63d15bdc90157a74cba9 baseline version: ovmf 70586d4e3af67dcc4fa2cd49524b7e5b71e0c7e1 Last test of basis 171444 2022-07-01 15:13:05 Z 0 days Testing same since 171446 2022-07-01 17:40:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Heng Luo Robbie King jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 70586d4e3a..e1eef3a8b0 e1eef3a8b01a25e75abf63d15bdc90157a74cba9 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 01 21:57:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 01 Jul 2022 21:57:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359253.588677 (Exim 4.92) (envelope-from ) id 1o7Odo-0004wu-Ap; Fri, 01 Jul 2022 21:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359253.588677; Fri, 01 Jul 2022 21:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Odo-0004wn-7a; Fri, 01 Jul 2022 21:57:32 +0000 Received: by outflank-mailman (input) for mailman id 359253; Fri, 01 Jul 2022 21:57:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Odn-0004wd-5o; Fri, 01 Jul 2022 21:57:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Odn-0003gc-3a; Fri, 01 Jul 2022 21:57:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7Odm-00006l-Ml; Fri, 01 Jul 2022 21:57:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7Odm-0002RX-MJ; Fri, 01 Jul 2022 21:57:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=E2pa4jOmHK1hYQwTRZrG1zz3veIOcXgAQo0+iKpDuGg=; b=nEsM5X9Y09r0KYYhVkPNrhBOTC 63PeIxDNpxvNH+wkelMIxz07cthL6PqnS/p4rTDlsg0G8e9uqc7RhP9Ws7KJU9wepaXhK8zTvDq4h nMt0Pc7Hb8KBmMldkTO7pTvvNsceU67LbnQ1R/HeWHD2xgGY5A1AHQnndf218VdbdRDU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171447: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 X-Osstest-Versions-That: xen=ee11f092b515bf3c926eaad053d12d3f2b6e593e From: osstest service owner Date: Fri, 01 Jul 2022 21:57:30 +0000 flight 171447 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171447/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 baseline version: xen ee11f092b515bf3c926eaad053d12d3f2b6e593e Last test of basis 171430 2022-06-30 21:01:45 Z 1 days Testing same since 171447 2022-07-01 18:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ee11f092b5..bf2f989531 bf2f989531ad3851685a1847cbc1e28901ed80a2 -> smoke From xen-devel-bounces@lists.xenproject.org Sat Jul 02 03:50:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 03:50:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359266.588688 (Exim 4.92) (envelope-from ) id 1o7U8t-0001oD-HV; Sat, 02 Jul 2022 03:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359266.588688; Sat, 02 Jul 2022 03:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7U8t-0001nn-A7; Sat, 02 Jul 2022 03:49:59 +0000 Received: by outflank-mailman (input) for mailman id 359266; Sat, 02 Jul 2022 03:49:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7U8s-0001nd-JN; Sat, 02 Jul 2022 03:49:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7U8s-0002Io-9z; Sat, 02 Jul 2022 03:49:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7U8r-0000ej-Mz; Sat, 02 Jul 2022 03:49:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7U8r-0002K2-MA; Sat, 02 Jul 2022 03:49:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/kwawnETjjX47/U372O+fsK++upr2p20zcU1AfFz95c=; b=fL0vX5jnOIlTCW0XdDEBRjxT5R 4gv1ORbt1j3bTqbNKC5joZxcRHbmEeEGqmoZYhuXdNXwRq9Ti0Q0EnAM2JlXx+aPE/nefZkbbL0rq 55OAzlfK2V7jjX3ZrvGruTa8jR8eKC02FSoN9wSEqvZnMQkuMASeQOZtWH1aNmw9bDOQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171442: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-coresched-amd64-xl:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ee11f092b515bf3c926eaad053d12d3f2b6e593e X-Osstest-Versions-That: xen=93aa071f66b78a2abbf134aeb96b02f066e6091d From: osstest service owner Date: Sat, 02 Jul 2022 03:49:57 +0000 flight 171442 xen-unstable real [real] flight 171449 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171442/ http://logs.test-lab.xenproject.org/osstest/logs/171449/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-coresched-amd64-xl 20 guest-localmigrate/x10 fail pass in 171449-retest test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 171449-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 171449 like 171415 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 171449 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171415 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171415 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171415 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171415 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171415 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171415 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171415 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen ee11f092b515bf3c926eaad053d12d3f2b6e593e baseline version: xen 93aa071f66b78a2abbf134aeb96b02f066e6091d Last test of basis 171415 2022-06-30 01:51:58 Z 2 days Failing since 171431 2022-06-30 21:06:55 Z 1 days 2 attempts Testing same since 171442 2022-07-01 10:59:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Dmytro Semenets Julien Grall Roger Pau Monne Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 93aa071f66..ee11f092b5 ee11f092b515bf3c926eaad053d12d3f2b6e593e -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 02 06:38:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 06:38:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359286.588719 (Exim 4.92) (envelope-from ) id 1o7WlC-0003yX-QC; Sat, 02 Jul 2022 06:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359286.588719; Sat, 02 Jul 2022 06:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7WlC-0003yQ-MQ; Sat, 02 Jul 2022 06:37:42 +0000 Received: by outflank-mailman (input) for mailman id 359286; Sat, 02 Jul 2022 06:37:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7WlC-0003yG-1K; Sat, 02 Jul 2022 06:37:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7WlB-0005kA-TI; Sat, 02 Jul 2022 06:37:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7WlB-00076O-J7; Sat, 02 Jul 2022 06:37:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7WlB-00083c-Ig; Sat, 02 Jul 2022 06:37:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nFIE5H8tzhDDRoNobpKGeSKsUrBY8u/JK+7nuC5oIdE=; b=r22IJoB9mVdfmA8riA7Yvj1fY6 P1/IG8Tlpl/eaba5e8B6Stftn1ryXwfFi3JuhSiXAVTg4GpQVW8OR3asWMSzn/zib7pbkTahoKx2j X13K//gRGLHxMSQZFOFbPJ0LiNXntiw5K4TEiZetxUDvxbPIKs8V98lpdj2PnDkF2rKU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171451: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf:xen-build:fail:regression libvirt:build-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=17f8e36e224e200833b68c99308787f3c5d71d23 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 02 Jul 2022 06:37:41 +0000 flight 171451 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171451/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf 6 xen-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 17f8e36e224e200833b68c99308787f3c5d71d23 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 722 days Failing since 151818 2020-07-11 04:18:52 Z 721 days 703 attempts Testing same since 171451 2022-07-02 04:18:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf fail build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt blocked build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115093 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 07:17:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 07:17:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359298.588733 (Exim 4.92) (envelope-from ) id 1o7XNW-0000Q4-0y; Sat, 02 Jul 2022 07:17:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359298.588733; Sat, 02 Jul 2022 07:17:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XNV-0000Px-UG; Sat, 02 Jul 2022 07:17:17 +0000 Received: by outflank-mailman (input) for mailman id 359298; Sat, 02 Jul 2022 07:17:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XNU-0000Pn-RL; Sat, 02 Jul 2022 07:17:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XNU-0006TQ-Oq; Sat, 02 Jul 2022 07:17:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XNU-0001d6-AZ; Sat, 02 Jul 2022 07:17:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7XNU-000372-A4; Sat, 02 Jul 2022 07:17:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DJtvDpRidYpeqXG/LlISQSOJTbzraE8ryEo0LVTIVWI=; b=G2dDaScOguH1widwSM/886iv2m Gct7KIZXzmOJACqfNoPdLvUynPbGONScxK+TPXVyeo0mi/n63dcC7fmtfU0kZN6NJpxbNdGw3IPpq dwXYrdUwNzXJbg8blKZ3ta8HVplwwIgXgu6AX3ik6kxGimlAaDyRIhr7ByfMHle0Qo4Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171448: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-armhf-armhf-xl-multivcpu:host-ping-check-xen:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b336ad598a3bbeddfdb71d86349b9d4024bddefe X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 02 Jul 2022 07:17:16 +0000 flight 171448 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171448/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-armhf-armhf-xl-multivcpu 10 host-ping-check-xen fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux b336ad598a3bbeddfdb71d86349b9d4024bddefe baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 13 days Failing since 171280 2022-06-19 15:12:25 Z 12 days 34 attempts Testing same since 171448 2022-07-01 20:12:53 Z 0 days 1 attempts ------------------------------------------------------------ 449 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 16810 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 07:23:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 07:23:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359307.588746 (Exim 4.92) (envelope-from ) id 1o7XTi-00020B-Or; Sat, 02 Jul 2022 07:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359307.588746; Sat, 02 Jul 2022 07:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XTi-000204-M6; Sat, 02 Jul 2022 07:23:42 +0000 Received: by outflank-mailman (input) for mailman id 359307; Sat, 02 Jul 2022 07:23:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XTh-0001zu-In; Sat, 02 Jul 2022 07:23:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XTh-0006ZW-Df; Sat, 02 Jul 2022 07:23:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7XTg-00021l-WC; Sat, 02 Jul 2022 07:23:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7XTg-0006Rl-Vj; Sat, 02 Jul 2022 07:23:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ldVq4pUVtnHpzG/UifPAdXYDfz/bnv/BgpTtqaaeXiE=; b=zuTzQ5bRV7xp31lyegezd0cNx9 J75UAmg3FRqyzMprm2LgsrKiDBy7UdxJCafLB9yVoy7L9HxNvWNTl09fKiAy/qNdsAx6C8BG6LIXc cEzInkNjCcAt1erlQCJW3uGaArv7BNvyHFqHg0Yfu+D6vs3xJi0aZMxdCl0G0IsSogxk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171445: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9ef3ad40a81ff6b8b65ed870588b230f38812f2a X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Sat, 02 Jul 2022 07:23:40 +0000 flight 171445 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171445/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171352 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 17 guest-start/debian.repeat fail in 171435 pass in 171445 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171435 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 171435 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171352 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171352 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9ef3ad40a81ff6b8b65ed870588b230f38812f2a baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 6 days Testing same since 171400 2022-06-29 07:11:34 Z 3 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Antoine Tenart Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Nguyen Ulf Hansson Vincent Whitchurch Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1766 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 10:30:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 10:30:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359323.588758 (Exim 4.92) (envelope-from ) id 1o7aNj-0005Xi-DY; Sat, 02 Jul 2022 10:29:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359323.588758; Sat, 02 Jul 2022 10:29:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7aNj-0005Xb-A4; Sat, 02 Jul 2022 10:29:43 +0000 Received: by outflank-mailman (input) for mailman id 359323; Sat, 02 Jul 2022 10:29:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7aNi-0005XR-CS; Sat, 02 Jul 2022 10:29:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7aNi-0001um-4z; Sat, 02 Jul 2022 10:29:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7aNh-0002ZY-Hk; Sat, 02 Jul 2022 10:29:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7aNh-0001q3-Gt; Sat, 02 Jul 2022 10:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7OsfNDEa7UP7VyKmUg8Igj4dOYYPdf5yTtUo8VALEQE=; b=cBcr0rwfwnqmV5cvWOChetDhHQ gtRVaPiUL/Vb3CM8ly2ci1y8DI/Y9TV0bAT9O8cm+aaY189TB4V+Ai30pcID7JHDVJfIFwlbeMNc2 0oo3wr2YiIgIay9DZ5C4+2RFSiX3K0Uwssacsop1LnSrIhh56a7K57ID+W8bZMwBrF9w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171450: regressions - FAIL X-Osstest-Failures: xen-unstable:build-armhf:xen-build:fail:regression xen-unstable:build-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-examine:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 X-Osstest-Versions-That: xen=ee11f092b515bf3c926eaad053d12d3f2b6e593e From: osstest service owner Date: Sat, 02 Jul 2022 10:29:41 +0000 flight 171450 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171450/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-armhf 6 xen-build fail REGR. vs. 171442 Tests which did not succeed, but are not blocking: build-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-examine 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-xl 1 build-check(1) blocked n/a test-armhf-armhf-xl-arndale 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit1 1 build-check(1) blocked n/a test-armhf-armhf-xl-credit2 1 build-check(1) blocked n/a test-armhf-armhf-xl-cubietruck 1 build-check(1) blocked n/a test-armhf-armhf-xl-multivcpu 1 build-check(1) blocked n/a test-armhf-armhf-xl-rtds 1 build-check(1) blocked n/a test-armhf-armhf-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171442 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171442 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171442 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171442 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass version targeted for testing: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 baseline version: xen ee11f092b515bf3c926eaad053d12d3f2b6e593e Last test of basis 171442 2022-07-01 10:59:59 Z 0 days Testing same since 171450 2022-07-02 03:53:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf fail build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt blocked build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl blocked test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale blocked test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 blocked test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 blocked test-armhf-armhf-xl-cubietruck blocked test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine blocked test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu blocked test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 blocked test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds blocked test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd blocked test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit bf2f989531ad3851685a1847cbc1e28901ed80a2 Author: Julien Grall Date: Fri Jul 1 18:27:05 2022 +0100 public/io: xs_wire: Document that new errors should be added at the end Some tools (e.g. xenstored) always expect EINVAL to be first in xsd_errors. To be conservative, mandate that new errors should be added at the end of the array. Signed-off-by: Julien Grall Reviewed-by: Henry Wang Reviewed-by: Juergen Gross (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 12:44:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 12:44:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359337.588771 (Exim 4.92) (envelope-from ) id 1o7cTT-0003n2-8T; Sat, 02 Jul 2022 12:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359337.588771; Sat, 02 Jul 2022 12:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7cTT-0003mv-5q; Sat, 02 Jul 2022 12:43:47 +0000 Received: by outflank-mailman (input) for mailman id 359337; Sat, 02 Jul 2022 12:43:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7cTR-0003mi-Va; Sat, 02 Jul 2022 12:43:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7cTR-0004HP-SC; Sat, 02 Jul 2022 12:43:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7cTR-0003Pl-EJ; Sat, 02 Jul 2022 12:43:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7cTR-00038y-Do; Sat, 02 Jul 2022 12:43:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gdEaZM2CVnUw0s+acn6KjnfpN+9iH7JXscVyGVOjjG8=; b=FhO+MVNZz+hryaGyfoX32u4K/t EKj7FV0kwB87X9r+DBW0NUUGu5h9uaBR6ojHKxopNUE+gRaQhAIRFXd0zrZRBBzrp9WQOLnTLR2QU vC25UuOLE3oX41AwLwZyyK48WWu2Ed7pB/nRHP09NmJbr1lgNImPDJnzUD8TCpQ5YnVs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171453: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=089866061428ec9bf67221247c936792078c41a4 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 02 Jul 2022 12:43:45 +0000 flight 171453 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171453/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 089866061428ec9bf67221247c936792078c41a4 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 13 days Failing since 171280 2022-06-19 15:12:25 Z 12 days 35 attempts Testing same since 171453 2022-07-02 07:26:42 Z 0 days 1 attempts ------------------------------------------------------------ 458 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17242 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 16:09:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 16:09:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359374.588789 (Exim 4.92) (envelope-from ) id 1o7fft-0000oQ-Pp; Sat, 02 Jul 2022 16:08:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359374.588789; Sat, 02 Jul 2022 16:08:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7fft-0000oJ-M3; Sat, 02 Jul 2022 16:08:49 +0000 Received: by outflank-mailman (input) for mailman id 359374; Sat, 02 Jul 2022 16:08:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7ffs-0000o9-NQ; Sat, 02 Jul 2022 16:08:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7ffs-0008Oq-Gt; Sat, 02 Jul 2022 16:08:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7ffs-00060u-3v; Sat, 02 Jul 2022 16:08:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7ffs-0006zt-3R; Sat, 02 Jul 2022 16:08:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eS7h0/z6FgAKum1mcaIzIkFrjlBW7B5hERbkaVupN6k=; b=gASPwp9gmWOUaNS02+ejhCsOaZ 9nY2sdJ5CJvqqhvhZGz3HdagbUoi4QMxauWpAh6UzApPuw9u6WTDWZkenvfqmcfH7ssOqc04JoVFH VojmqHM7uomTfsZH9391HNN5YYzE0ZUD7z25xNJBLY8xwd2a65UtlTgabr7XmH8KtaDo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171454: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9ef3ad40a81ff6b8b65ed870588b230f38812f2a X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Sat, 02 Jul 2022 16:08:48 +0000 flight 171454 linux-5.4 real [real] flight 171459 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171454/ http://logs.test-lab.xenproject.org/osstest/logs/171459/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 171445 REGR. vs. 171352 Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 171445 pass in 171454 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail in 171445 pass in 171454 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 171445 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171445 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171352 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171445 like 171352 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 171445 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 171445 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171352 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9ef3ad40a81ff6b8b65ed870588b230f38812f2a baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 7 days Testing same since 171400 2022-06-29 07:11:34 Z 3 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Antoine Tenart Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Nguyen Ulf Hansson Vincent Whitchurch Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1766 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 02 16:46:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 16:46:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359384.588800 (Exim 4.92) (envelope-from ) id 1o7gFx-0005OO-Oi; Sat, 02 Jul 2022 16:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359384.588800; Sat, 02 Jul 2022 16:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7gFx-0005OH-LB; Sat, 02 Jul 2022 16:46:05 +0000 Received: by outflank-mailman (input) for mailman id 359384; Sat, 02 Jul 2022 16:46:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7gFw-0005OB-6t for xen-devel@lists.xenproject.org; Sat, 02 Jul 2022 16:46:04 +0000 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [2a00:1450:4864:20::32f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 742e18fd-fa26-11ec-bd2d-47488cf2e6aa; Sat, 02 Jul 2022 18:46:02 +0200 (CEST) Received: by mail-wm1-x32f.google.com with SMTP id g39-20020a05600c4ca700b003a03ac7d540so5422207wmp.3 for ; Sat, 02 Jul 2022 09:46:01 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id r13-20020adfe68d000000b0021018642ff8sm27361345wrm.76.2022.07.02.09.45.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 02 Jul 2022 09:45:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 742e18fd-fa26-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=meb/BRY4yeRhFjn0PwBz4K63lWMtc3ivi4vwL+W878s=; b=qVoRRq71Gv97X0/guuVC59ykQUuIwJkmbE4uWo49bnAFPHorwSS+6ZuiEKTs++u8pv 5AWZ6pQepEBREKRipdF+pGu9MHXK11kHP2s8YmoeQDaRCAYkBTptQ7Hi2DzkQjjFL6hJ dAlpm1VZ/AxtZnLN2jnB4NwViItV5yW7CB9wzSKo2hPMhbel+7ADvgj5X2B+6bzqQ1bx 0mWdGIrVaZtMc3BI3XXkVGpSpL7P8JVh4FRhtouK6Oc51qVsrssw37A4RZeRVX91VDRD slFLgIlOexg/OKwx6HL//mGGLsYN4Xo5+tFMOy2rZZn0vpA0p46rlIYTAtgEorpDN/Qq OU9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=meb/BRY4yeRhFjn0PwBz4K63lWMtc3ivi4vwL+W878s=; b=cWZ0zkz4VZZMKtOM3yNtRvHclZJhk8AZAwpleJvWzjucIL1VEyjyrZfMMC5cIwU3IP nHzw1tnYssLxhhYKYt8INCqDOr5sIVy5qfYVRMIOQv/0um0tqdNLrQmcCdte4/8EIrpM AhG1mKtiMz9iAUxunDO8men/nPzopv4dMsb7XWiCpVBbUfZZ8TgOfSBEPIuBEUJ5tx4U zYf0JhS3mkbk5p44Ilb/kubKywRYFQKAdXgKaHaG6CdA6N9ZtclvcsqWqgnm0JuqTMeB Q/v1f0YW94EBAJz+8d8H4U9ZZb2VzThhULXTScOehCSZVwHPBncAKP7bkbBnlOlctpPQ AfSQ== X-Gm-Message-State: AJIora94eIyoGqUsIxoek0m7OhSzOMaR4lQTZlMmYF9bQLHRVLFthifD tlymKOs5GlEBbHUb1iQXnuI= X-Google-Smtp-Source: AGRyM1vqhnWyk5QClPDYeE1wEwMKHjZLYMEDz3GbGgJ/RjqSZUfh8ByTlcxm7quOajWW6BYBYCsWrQ== X-Received: by 2002:a05:600c:1c9d:b0:3a0:4e04:9475 with SMTP id k29-20020a05600c1c9d00b003a04e049475mr23815799wms.87.1656780360051; Sat, 02 Jul 2022 09:46:00 -0700 (PDT) Message-ID: <468ea656-a03c-8591-f5f8-4d0d329ae187@gmail.com> Date: Sat, 2 Jul 2022 19:45:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: smmu-v3: Fix MISRA C 2012 Rule 1.3 violations Content-Language: en-US To: Julien Grall , Bertrand Marquis Cc: xen-devel , Rahul Singh , Stefano Stabellini , Volodymyr Babchuk References: <20220628150851.8627-1-burzalodowa@gmail.com> <1b28f8b2-2153-61f6-515f-b2ed880f84b6@gmail.com> <1e53136a-0675-6a0f-e06c-6ffb390d9399@xen.org> From: Xenia Ragiadakou In-Reply-To: <1e53136a-0675-6a0f-e06c-6ffb390d9399@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/29/22 18:02, Julien Grall wrote: > On 29/06/2022 15:10, Bertrand Marquis wrote: >> Hi, > > Hi Bertrand, > >> In fact the patch was committed before we started this discussion as >> Rahul R-b was enough. > > It was probably merged a bit too fast. When there are multiple > maintainers responsible for the code, I tend to prefer to wait a bit > just in case there are extra comments. > >> But I would still be interested to have other maintainers view on this. > > Rahul and you are the official maintainers for that code. I think > Stefano and I are only CCed because we maintain the Arm code > (get_maintainers.pl doesn't automatically remove maintainers from upper > directory). > >> >>> On 29 Jun 2022, at 10:03, Bertrand Marquis >>> wrote: >>> >>> Hi Xenia, >>> >>>> On 29 Jun 2022, at 09:55, xenia wrote: >>>> >>>> Hi Bertrand, >>>> >>>> On 6/29/22 10:24, Bertrand Marquis wrote: >>>>> Hi Xenia, >>>>> >>>>>> On 28 Jun 2022, at 16:08, Xenia Ragiadakou >>>>>> wrote: >>>>>> >>>>>> The expression 1 << 31 produces undefined behaviour because the >>>>>> type of integer >>>>>> constant 1 is (signed) int and the result of shifting 1 by 31 bits >>>>>> is not >>>>>> representable in the (signed) int type. >>>>>> Change the type of 1 to unsigned int by adding the U suffix. >>>>>> >>>>>> Signed-off-by: Xenia Ragiadakou >>>>>> --- >>>>>> Q_OVERFLOW_FLAG has already been fixed in upstream kernel code. >>>>>> For GBPA_UPDATE I will submit a patch. >>>>>> >>>>>> xen/drivers/passthrough/arm/smmu-v3.c | 4 ++-- >>>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>>> >>>>>> diff --git a/xen/drivers/passthrough/arm/smmu-v3.c >>>>>> b/xen/drivers/passthrough/arm/smmu-v3.c >>>>>> index 1e857f915a..f2562acc38 100644 >>>>>> --- a/xen/drivers/passthrough/arm/smmu-v3.c >>>>>> +++ b/xen/drivers/passthrough/arm/smmu-v3.c >>>>>> @@ -338,7 +338,7 @@ static int >>>>>> platform_get_irq_byname_optional(struct device *dev, >>>>>> #define CR2_E2H                (1 << 0) >>>>>> >>>>>> #define ARM_SMMU_GBPA            0x44 >>>>>> -#define GBPA_UPDATE            (1 << 31) >>>>>> +#define GBPA_UPDATE            (1U << 31) >>>>>> #define GBPA_ABORT            (1 << 20) >>>>>> >>>>>> #define ARM_SMMU_IRQ_CTRL        0x50 >>>>>> @@ -410,7 +410,7 @@ static int >>>>>> platform_get_irq_byname_optional(struct device *dev, >>>>>> >>>>>> #define Q_IDX(llq, p)            ((p) & ((1 << (llq)->max_n_shift) >>>>>> - 1)) >>>>>> #define Q_WRP(llq, p)            ((p) & (1 << (llq)->max_n_shift)) >>>>> Could also make sense to fix those 2 to be coherent. >>>> According to the spec, the maximum value that max_n_shift can take >>>> is 19. >>>> Hence, 1 << (llq)->max_n_shift cannot produce undefined behavior. >>> >>> I agree with that but my preference would be to not rely on deep >>> analysis on the code for those kind of cases and use 1U whenever >>> possible. >>> >>> What other maintainers think on this ? > > In general, I prefer if we use 1U (or 1UL/1ULL) so it is clearer that > the code is correct and consistent (I always find odd when we use 1U << > 31 but 1 << 20). > > In this case, even if you use 1U, it is not really clear whether > max_n_shift can be greater than 31. That said, I would not suggest to > use ULL unless this is strictly necessary. > >>> >>>> >>>> Personally, I have no problem to submit another patch that adds U/UL >>>> suffixes to all shifted integer constants in the file :) but ... >>>> It seems that this driver has been ported from linux and this file >>>> still uses linux coding style, probably because deviations will >>>> reduce its maintainability. >>>> Adding a U suffix to those two might be considered an unjustified >>>> deviation. > > This can be solved by sending patch to Linux as well. This will also > help Linux to reduce the number MISRA violations (I guess SMMUv3 will be > part of the safety certification scope). Linux relies on -fno-strict-overflow (implementation-defined behavior). Nevertheless, a patch changing all of them to BIT() has some chances to get accepted. > >>> >>> At this stage the SMMU code is starting to deviate a lot from Linux >>> so it will not be possible to update it easily to sync with latest >>> linux code. >>> And the decision should be are we fixing it or should we fully skip >>> this file saying that it is coming from linux and should not be fixed. >>> We started to have a discussion during the FuSa meeting on this but >>> we need to come up with a conclusion per file. >>> >>> On this one I would say keeping it with linux code style and near >>> from the linux one is not needed. > > I will address both point separately. > > In general, we don't want to mix coding style within a file. As the file > started with the Linux one, then we should keep it like that. Otherwise, > you will end up with a mix and it will be difficult for the contributor > to know how to write new code. That said, I would not necessarily > consider using "1 << ..." as part of the code style we want to keep. > > This brings to the second part (i.e. keeping the code near Linux). Linux > has a much larger user/developper base than us. Therefore there are more > chance for them to find bugs and fix them. By diverging, then we could > end up to add new bugs and also increase the maintainance. > > I have tried both way with the SMMUv{1,2} driver. The first attempt was > to fully adapt the code to Xen (coding style...). But this made > difficult to keep track of bugs. A few months we removed it completely > and then tried to keep as close as to Linux. Since then Linux reworked > the IOMMU subsystem, so port needs to be adapted. It is more difficult > but likely less than if we had our own port. > > So overall, I think it was beneficials for our version of the SMMU{v1, > v2} drivers to be close to Linux. I haven't looked very close to the > SMMUv3 to state whether we should stay close or not. > >>> Rahul, Julien, Stefano: what do you think here ? > > Rahul and you are the maintainers. I can share my preference/experience, > but I think this is your call on how you want to maintain the driver. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Sat Jul 02 17:43:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 17:43:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359394.588819 (Exim 4.92) (envelope-from ) id 1o7h9W-0003ob-Dl; Sat, 02 Jul 2022 17:43:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359394.588819; Sat, 02 Jul 2022 17:43:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7h9W-0003oI-A2; Sat, 02 Jul 2022 17:43:30 +0000 Received: by outflank-mailman (input) for mailman id 359394; Sat, 02 Jul 2022 17:43:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7h9V-0003kj-2i for xen-devel@lists.xen.org; Sat, 02 Jul 2022 17:43:29 +0000 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 784b64da-fa2e-11ec-bf74-3be3494bec92; Sat, 02 Jul 2022 19:43:26 +0200 (CEST) Received: by mail-ed1-f47.google.com with SMTP id c65so6553874edf.4; Sat, 02 Jul 2022 10:43:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 784b64da-fa2e-11ec-bf74-3be3494bec92 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ghVSNn/o9ecQXueAzNk7+M3SImaH89IEsRIg90uY4yQ=; b=VJxCd01RtmVoOf2toBZuCLHZSoqlUxo1LmIMxf1Dh67bHYmOfjp+pQ5PllEk4A036E YrKI5bekkpsUDs4PnQdxLvmQZWCnu3L2akznSANoypCSUnJDHmS66fEOddKRFs+kvz3a Sb0UpAD0jBETQTAMFEnOvPSsNYXliRAR5b+E9CaBdtWRCeuPwBnb16+RzvefeboDnC/y 4SXa+qmxE7LhAbm3WJXYZJGCo7W4/F5RgI9uoQ2BPx6MqTMq7cC7R/tfPF2nTYP8ESpw +3tyHOvjBZciVdKGikMvHWn5Dbmt7dBgr7z2k+C35RQkpdh7ZeVX+NGE7KPtCiRdfIC3 KJ+Q== X-Gm-Message-State: AJIora+Esw+KiDVGo88vm0nkgzIn1ffQgSYCPfE+2hMywuo3o9HYpmpr gdJAHpgx7xmHd8aIc86O/7/03MnhO5ckCyM8dKrobU/50hY= X-Google-Smtp-Source: AGRyM1vrFXKV2CA5Lspi16sj0Ggb2nQiNMC0QQSm0aC7fW0N/I/B7Cs3p9jwEHEVRzbKDOnPXKNOj1Rjd4EWSD3TojM= X-Received: by 2002:a05:6402:84f:b0:437:6293:d264 with SMTP id b15-20020a056402084f00b004376293d264mr26217908edz.317.1656783802751; Sat, 02 Jul 2022 10:43:22 -0700 (PDT) MIME-Version: 1.0 From: "G.R." Date: Sun, 3 Jul 2022 01:43:11 +0800 Message-ID: Subject: PCI pass-through problem for SN570 NVME SSD To: xen-users , xen-devel Content-Type: text/plain; charset="UTF-8" Hi everybody, I run into problems passing through a SN570 NVME SSD to a HVM guest. So far I have no idea if the problem is with this specific SSD or with the CPU + motherboard combination or the SW stack. Looking for some suggestions on troubleshooting. List of build info: CPU+motherboard: E-2146G + Gigabyte C246N-WU2 XEN version: 4.14.3 Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) The SN570 SSD sits here in the PCI tree: +-1d.0-[05]----00.0 Sandisk Corp Device 501a Syndromes observed: With ASPM enabled, pciback has problem seizing the device. Jul 2 00:36:54 gaia kernel: [ 1.648270] pciback 0000:05:00.0: xen_pciback: seizing device ... Jul 2 00:36:54 gaia kernel: [ 1.768646] pcieport 0000:00:1d.0: AER: enabled with IRQ 150 Jul 2 00:36:54 gaia kernel: [ 1.768716] pcieport 0000:00:1d.0: DPC: enabled with IRQ 150 Jul 2 00:36:54 gaia kernel: [ 1.768717] pcieport 0000:00:1d.0: DPC: error containment capabilities: Int Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log 4, DL_ActiveErr+ ... Jul 2 00:36:54 gaia kernel: [ 1.770039] xen: registering gsi 16 triggering 0 polarity 1 Jul 2 00:36:54 gaia kernel: [ 1.770041] Already setup the GSI :16 Jul 2 00:36:54 gaia kernel: [ 1.770314] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f11 source:0x0000 Jul 2 00:36:54 gaia kernel: [ 1.770315] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected Jul 2 00:36:54 gaia kernel: [ 1.770320] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver ID) Jul 2 00:36:54 gaia kernel: [ 1.770371] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=00200000/00010000 Jul 2 00:36:54 gaia kernel: [ 1.770413] pcieport 0000:00:1d.0: [21] ACSViol (First) Jul 2 00:36:54 gaia kernel: [ 1.770466] pciback 0000:05:00.0: xen_pciback: device is not found/assigned Jul 2 00:36:54 gaia kernel: [ 1.920195] pciback 0000:05:00.0: xen_pciback: device is not found/assigned Jul 2 00:36:54 gaia kernel: [ 1.920260] pcieport 0000:00:1d.0: AER: device recovery successful Jul 2 00:36:54 gaia kernel: [ 1.920263] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f01 source:0x0000 Jul 2 00:36:54 gaia kernel: [ 1.920264] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected Jul 2 00:36:54 gaia kernel: [ 1.920267] pciback 0000:05:00.0: xen_pciback: device is not found/assigned Jul 2 00:36:54 gaia kernel: [ 1.938406] xen: registering gsi 16 triggering 0 polarity 1 Jul 2 00:36:54 gaia kernel: [ 1.938408] Already setup the GSI :16 Jul 2 00:36:54 gaia kernel: [ 1.938666] xen_pciback: backend is vpci ... Jul 2 00:43:48 gaia kernel: [ 420.231955] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f01 source:0x0000 Jul 2 00:43:48 gaia kernel: [ 420.231961] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected Jul 2 00:43:48 gaia kernel: [ 420.231993] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) Jul 2 00:43:48 gaia kernel: [ 420.235775] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=00100000/00010000 Jul 2 00:43:48 gaia kernel: [ 420.235779] pcieport 0000:00:1d.0: [20] UnsupReq (First) Jul 2 00:43:48 gaia kernel: [ 420.235783] pcieport 0000:00:1d.0: AER: TLP Header: 34000000 05000010 00000000 88458845 Jul 2 00:43:48 gaia kernel: [ 420.235819] pci 0000:05:00.0: AER: can't recover (no error_detected callback) Jul 2 00:43:48 gaia kernel: [ 420.384349] pcieport 0000:00:1d.0: AER: device recovery successful ... // The following might relate to an attempt to assign the device to guest, not very sure... Jul 2 00:46:06 gaia kernel: [ 559.147333] pciback 0000:05:00.0: xen_pciback: seizing device Jul 2 00:46:06 gaia kernel: [ 559.147435] pciback 0000:05:00.0: enabling device (0000 -> 0002) Jul 2 00:46:06 gaia kernel: [ 559.147508] xen: registering gsi 16 triggering 0 polarity 1 Jul 2 00:46:06 gaia kernel: [ 559.147511] Already setup the GSI :16 Jul 2 00:46:06 gaia kernel: [ 559.147558] pciback 0000:05:00.0: xen_pciback: MSI-X preparation failed (-6) With pcie_aspm=off, the error log related to pciback goes away. But I suspect there are still some problems hidden -- since I don't see any AER enabled messages so errors may be hidden. I have the xen_pciback built directly into the kernel and assigned the SSD to it in the kernel command-line. However, the result from pci-assignable-xxx commands are not very consistent: root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 root@gaia:~# xl pci-assignable-remove 05:00.0 libxl: error: libxl_pci.c:853:libxl__device_pci_assignable_remove: failed to de-quarantine 0000:05:00.0 <===== Here!!! root@gaia:~# xl pci-assignable-add 05:00.0 libxl: warning: libxl_pci.c:794:libxl__device_pci_assignable_add: 0000:05:00.0 already assigned to pciback <==== Here!!! root@gaia:~# xl pci-assignable-remove 05:00.0 root@gaia:~# xl pci-assignable-list 0000:00:17.0 root@gaia:~# xl pci-assignable-add 05:00.0 libxl: warning: libxl_pci.c:814:libxl__device_pci_assignable_add: 0000:05:00.0 not bound to a driver, will not be rebound. root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 After the 'xl pci-assignable-list' appears to be self-consistent, creating VM with the SSD assigned still leads to a guest crash: >From qemu log: [00:06.0] xen_pt_region_update: Error: create new mem mapping failed! (err: 1) qemu-system-i386: terminating on signal 1 from pid 1192 (xl) >From the 'xl dmesg' output: (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted (XEN) domain_crash called from p2m.c:1301 (XEN) Domain 1 reported crashed by domain 0 on cpu#4: (XEN) memory_map:fail: dom1 gfn=f3078 mfn=a2504 nr=1 ret:-1 Which of the three syndromes are more fundamental? 1. The DPC / AER error log 2. The inconsistency in 'xl pci-assignable-list' state tracking 3. The GFN mapping failure on guest setup Any suggestions for the next step? Thanks, G.R. From xen-devel-bounces@lists.xenproject.org Sat Jul 02 20:02:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 20:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359441.588847 (Exim 4.92) (envelope-from ) id 1o7jKD-0003FO-CR; Sat, 02 Jul 2022 20:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359441.588847; Sat, 02 Jul 2022 20:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7jKD-0003FH-9h; Sat, 02 Jul 2022 20:02:41 +0000 Received: by outflank-mailman (input) for mailman id 359441; Sat, 02 Jul 2022 20:02:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7jKB-0003F7-Eu; Sat, 02 Jul 2022 20:02:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7jKB-00046y-CS; Sat, 02 Jul 2022 20:02:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7jKA-0001dA-VE; Sat, 02 Jul 2022 20:02:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7jKA-0008C6-Up; Sat, 02 Jul 2022 20:02:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SRP/NhfDYlQWapEHCM8TS4anRGobvhIV/HEqGxvZ1Lg=; b=pG6WGuCTS9xCTjL+ZSWEWPeGVK W2QDP4wpjU0NPv0jp42GMmZfc+GDi32ksjgwO1zGDVDI5k/gj/k/S2kfII+HAtfvK4PqbNYC7imRn ZERp6AYaJMt20P468otdG5M30fBXIG1zIiKsdEeaha1Fql/mdsO7wLlV6Pr3WR/v8iPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171455: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 X-Osstest-Versions-That: xen=ee11f092b515bf3c926eaad053d12d3f2b6e593e From: osstest service owner Date: Sat, 02 Jul 2022 20:02:38 +0000 flight 171455 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171455/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171442 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171442 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171442 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171442 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171442 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171442 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171442 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171442 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 baseline version: xen ee11f092b515bf3c926eaad053d12d3f2b6e593e Last test of basis 171442 2022-07-01 10:59:59 Z 1 days Testing same since 171450 2022-07-02 03:53:21 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ee11f092b5..bf2f989531 bf2f989531ad3851685a1847cbc1e28901ed80a2 -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 02 22:46:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 02 Jul 2022 22:46:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359461.588858 (Exim 4.92) (envelope-from ) id 1o7ls0-0003de-2O; Sat, 02 Jul 2022 22:45:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359461.588858; Sat, 02 Jul 2022 22:45:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7lrz-0003dX-Vh; Sat, 02 Jul 2022 22:45:43 +0000 Received: by outflank-mailman (input) for mailman id 359461; Sat, 02 Jul 2022 22:45:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7lrx-0003dN-R3; Sat, 02 Jul 2022 22:45:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7lrx-0006rQ-Nu; Sat, 02 Jul 2022 22:45:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7lrx-0006ug-7M; Sat, 02 Jul 2022 22:45:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7lrx-0003qa-6u; Sat, 02 Jul 2022 22:45:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Hwyuq3c3v1cGXd/nDdUNG8qJ85pxgsTBdSHwLvb8mN0=; b=7IEe5q0OKNAxWZDl4/fvVRFdDF N6As4jhYrrA2ZghFfYAV+nUejwBlF5l8vJ85v7jHUeTH7VHn4CmpsG2PO/vz6Ij12caSblcTxyU/8 dqvC/PhEDFAHUVYEoNG2BxbebAKSrwf8QGOwwT3iR0He1Br9zgYd/BS0FqP5c1lYj6Zo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171457: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=089866061428ec9bf67221247c936792078c41a4 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 02 Jul 2022 22:45:41 +0000 flight 171457 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171457/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 089866061428ec9bf67221247c936792078c41a4 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 13 days Failing since 171280 2022-06-19 15:12:25 Z 13 days 36 attempts Testing same since 171453 2022-07-02 07:26:42 Z 0 days 2 attempts ------------------------------------------------------------ 458 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17242 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 03 03:23:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 03:23:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359480.588869 (Exim 4.92) (envelope-from ) id 1o7qCg-00077f-Pj; Sun, 03 Jul 2022 03:23:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359480.588869; Sun, 03 Jul 2022 03:23:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7qCg-00077F-JK; Sun, 03 Jul 2022 03:23:22 +0000 Received: by outflank-mailman (input) for mailman id 359480; Sun, 03 Jul 2022 03:23:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7qCe-000775-O4; Sun, 03 Jul 2022 03:23:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7qCe-00026k-Jw; Sun, 03 Jul 2022 03:23:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7qCe-0007IT-47; Sun, 03 Jul 2022 03:23:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7qCe-0002g2-3Q; Sun, 03 Jul 2022 03:23:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=l0dhjq80KnJcS21Lf6gLcJKBH5CT7uiNG3CDf2d8rGU=; b=Dsq47uhwr4VpCpW7YScRA8jJ2Q 0Ga5yU/cM49gQIAZ52AXmplMzxFF4QN2yFOng2BPCB/wsWOfPkWGf/7tgX5Ih4JwWdr7pTpElAKHJ +Z7QQ3WSKqjMki5oojLtYrz3Vj/4caA+d4IVsveFS5lC0Jhlqx7vmghd5RtqftC9Odcg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171460: regressions - FAIL X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:regression linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:regression linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=871cbc208bf0aded1946cd1e3eebec75799d31e8 X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Sun, 03 Jul 2022 03:23:20 +0000 flight 171460 linux-5.4 real [real] flight 171464 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171460/ http://logs.test-lab.xenproject.org/osstest/logs/171464/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail REGR. vs. 171352 test-armhf-armhf-xl-credit1 14 guest-start fail REGR. vs. 171352 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-xl-credit2 14 guest-start fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 871cbc208bf0aded1946cd1e3eebec75799d31e8 baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 7 days Failing since 171400 2022-06-29 07:11:34 Z 3 days 8 attempts Testing same since 171460 2022-07-02 16:43:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Andrew Morton Antoine Tenart Ard Biesheuvel Ard Biesheuvel Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Christoph Hellwig Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann Daniel Vetter David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller Herbert Xu huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jessica Yu Jian Cai Jian Cai Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Linux Kernel Functional Testing Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nick Desaulniers Nicolas Pitre Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Russell King Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stefan Agner Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Lindgren Tony Nguyen Ulf Hansson Vincent Whitchurch Vladimir Oltean Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2191 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 03 08:47:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 08:47:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359514.588895 (Exim 4.92) (envelope-from ) id 1o7vFc-0008Aw-63; Sun, 03 Jul 2022 08:46:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359514.588895; Sun, 03 Jul 2022 08:46:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7vFc-0008Ap-2F; Sun, 03 Jul 2022 08:46:44 +0000 Received: by outflank-mailman (input) for mailman id 359514; Sun, 03 Jul 2022 08:46:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7vFa-0008Af-KD; Sun, 03 Jul 2022 08:46:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7vFa-0000CX-He; Sun, 03 Jul 2022 08:46:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7vFZ-0002xA-Kr; Sun, 03 Jul 2022 08:46:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7vFZ-0005DR-KT; Sun, 03 Jul 2022 08:46:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vbeu2s2R/OC5uJ1D6AWmvVoJzU+svlc66VVQNn06Z1U=; b=n7ehxS7vvstX7BwX0gsEiekfG2 oYbPFRkPvX0CRGQlO2yKWzJHr9rdFuxToBcUT3s63tMBd6xilXvmamw39YdmyV6f6JN0hJeMn3htb Fkk7vFHFYdEFwNGWyy5nlCkkAWbkDsjRdVNP77He1ffTkSsUgj1ycYilZ4UtTztozHag=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171461: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-armhf-armhf-xl-arndale:host-ping-check-xen:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69cb6c6556ad89620547318439d6be8bb1629a5a X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 03 Jul 2022 08:46:41 +0000 flight 171461 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171461/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-armhf-armhf-xl-arndale 10 host-ping-check-xen fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 69cb6c6556ad89620547318439d6be8bb1629a5a baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 14 days Failing since 171280 2022-06-19 15:12:25 Z 13 days 37 attempts Testing same since 171461 2022-07-02 23:12:32 Z 0 days 1 attempts ------------------------------------------------------------ 467 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale fail test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17882 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 03 11:30:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 11:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359554.588909 (Exim 4.92) (envelope-from ) id 1o7xnh-0000pV-UV; Sun, 03 Jul 2022 11:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359554.588909; Sun, 03 Jul 2022 11:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7xnh-0000pO-Q4; Sun, 03 Jul 2022 11:30:05 +0000 Received: by outflank-mailman (input) for mailman id 359554; Sun, 03 Jul 2022 11:30:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7xnh-0000lf-7O; Sun, 03 Jul 2022 11:30:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7xnh-00030x-4d; Sun, 03 Jul 2022 11:30:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7xng-0002f3-Lf; Sun, 03 Jul 2022 11:30:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7xng-0000wt-LH; Sun, 03 Jul 2022 11:30:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JmCMxKnH/2RLh0sblbYYmJNheidWPPbjzO/CaDXKmvI=; b=yba2K7TNpnbeJVTJvWCGXhrg+K fFdwF198zhrA3C019bCg5jxj4DcjTsRxYUh9+UiHtX5hqpYSTzhXnPlA3VDSYwnIOslL7ybvoMqPa ykxYDEIRuZOwOHrbj2V0MzA+ZC0VeIX+m2L56WD3m6xqh/CMKNLuDOKPFCCwf+yby3kA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171462: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-freebsd10-amd64:xen-install:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=ba45b82518bd5d9cad509765411e7f82a73aed53 X-Osstest-Versions-That: qemuu=d495e432c04a6394126c35cf96517749708b410f From: osstest service owner Date: Sun, 03 Jul 2022 11:30:04 +0000 flight 171462 qemu-mainline real [real] flight 171471 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171462/ http://logs.test-lab.xenproject.org/osstest/logs/171471/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-amd64 7 xen-install fail pass in 171471-retest test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 171471-retest test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 171471-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171471 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171471 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171433 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171433 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171433 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171433 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171433 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171433 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171433 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171433 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: qemuu ba45b82518bd5d9cad509765411e7f82a73aed53 baseline version: qemuu d495e432c04a6394126c35cf96517749708b410f Last test of basis 171433 2022-07-01 01:40:53 Z 2 days Testing same since 171462 2022-07-03 01:07:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jung-uk Kim Michal Meloun Richard Henderson Stacey Son Warner Losh jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d495e432c0..ba45b82518 ba45b82518bd5d9cad509765411e7f82a73aed53 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jul 03 12:17:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 12:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359571.588920 (Exim 4.92) (envelope-from ) id 1o7yXZ-0005oW-Ti; Sun, 03 Jul 2022 12:17:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359571.588920; Sun, 03 Jul 2022 12:17:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7yXZ-0005oP-Qh; Sun, 03 Jul 2022 12:17:29 +0000 Received: by outflank-mailman (input) for mailman id 359571; Sun, 03 Jul 2022 12:17:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7yXY-0005oJ-Dg for xen-devel@lists.xenproject.org; Sun, 03 Jul 2022 12:17:28 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 174d422f-faca-11ec-bd2d-47488cf2e6aa; Sun, 03 Jul 2022 14:17:24 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EAAF45C0068; Sun, 3 Jul 2022 08:17:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 03 Jul 2022 08:17:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 3 Jul 2022 08:17:20 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 174d422f-faca-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656850641; x= 1656937041; bh=HUTvfd/IwhhmZ4XeTUjMNu80Hhlx1Y0n9Fzk9Cb4i3c=; b=n 72JUAfX5Be6kBFRN7WZWf4G5SqonT2Efh9Wlkg5vhvAJm9mr3SU8LSOiQD4zJz+m VDz+QimMp6zzg3K8prvHKuFkG5pSlAuJXWcPfoIzuD8QYM6VIf1K1srPgzGZRIoF Oh+fwY9VqfIsRxCgRYiV5W8LCgEw3TCwy7gxz8W8Xh5hzQWs33XeJW6oEe5qF+N6 YEaM4exZ6lzm4xyTwgTDN0k7SawlAbzul2urAVUns43mSLPummq3iFk6rXb13gsM qTUFUECuCPW32oG/5XED97q1BYn25/pv6qwQKPI0uUvSvXYRq8H20a4iWZQeodY6 kqOOG4vW9MS/fMDE3TmCA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656850641; x=1656937041; bh=HUTvfd/IwhhmZ4XeTUjMNu80Hhlx 1Y0n9Fzk9Cb4i3c=; b=LiefMM+bkjdK2MRzqc5BAtXfOw+UJqhxwdEJs/hNlfdZ 3ZNLx0KyPiwb5QUcTHkk9FmYD+IE60tTL1UzItWSieHiGKcyVY+7icg1Cwja8GG1 dCf1UGIxogDXObyTyP8DWPIM15KhTApFhgpip587PgN8xhuJjXNFFjDQTinapN5X R1Ezei45UNKjbhQuBx8zRc0wcl/ky0gY6uY3wD02sCG5bdkBEyK1sJ004jZY/F00 4DEMGpRIHHFIKCrxsvlbQoWyudij98qtCwFnlUtHDmpK7j6H8C/vqDel79eiC5MO QPK6AUY7frUnDq6GivC9/y01Hykb1bxmQqxzKnY8zg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehjedghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sun, 3 Jul 2022 14:17:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <87c73737fe8ec6d9fe31c844b72b6c979b90c25d.1654612169.git-series.marmarek@invisiblethingslab.com> <9c7c11f5-be1e-f0ef-0659-48026675ec1a@suse.com> <8322303f-021a-b520-d2ad-cf8310573df5@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jM+4HfAWoFk3MHCN" Content-Disposition: inline In-Reply-To: <8322303f-021a-b520-d2ad-cf8310573df5@suse.com> --jM+4HfAWoFk3MHCN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 3 Jul 2022 14:17:17 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: > On 22.06.2022 17:47, Marek Marczykowski-G=C3=B3recki wrote: > > On Wed, Jun 15, 2022 at 04:25:54PM +0200, Jan Beulich wrote: > >> On 07.06.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: > >>> + memset(xue, 0, sizeof(*xue)); > >>> + > >>> + xue->dbc_ctx =3D &ctx; > >>> + xue->dbc_erst =3D &erst; > >>> + xue->dbc_ering.trb =3D evt_trb; > >>> + xue->dbc_oring.trb =3D out_trb; > >>> + xue->dbc_iring.trb =3D in_trb; > >>> + xue->dbc_owork.buf =3D wrk_buf; > >>> + xue->dbc_str =3D str_buf; > >> > >> Especially the page-sized entities want allocating dynamically here, as > >> they won't be needed without the command line option requesting the use > >> of this driver. > >=20 > > Are you okay with changing this only in patch 9, where I restructure th= ose > > buffers anyway? >=20 > I'm afraid I'll need to make it to patch 9 to answer this question. If > suitable dealt with later, I don't see a fundamental problem, as long > as it's clear then that I will request that this patch be committed in > a batch with that later one, not in isolation. This turns out to be rather problematic. xue_uart_init() is called really early (as it should, to get console as early as possible). It's before even boot allocator is functioning, so I can't use alloc_boot_pages(= ). Are there any other options for memory allocations at this point? We are talking about 58 pages. It isn't much, but isn't exactly nothing either. Maybe there is way to keep the memory allocated statically as it is now, but return it to the allocator is xue is _not_ enabled? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --jM+4HfAWoFk3MHCN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLBiM0ACgkQ24/THMrX 1ywdOgf7BcjwoRFajS0dGFPkO0TLRtHXYEvWXvqu7hTxAdCiMcBGdceP1NKAymEX 1uUotWyNAUo84Y01r1iS88IISkAUb/Ndiz80coT1fwUUccfMoRGLrbW0mzc371dk B9MoatjhrDmkidaa8pkNbeWVOt7qc4q2iK8aFwnmyCf2vKL4bKR92JttwRVvfVsF CASK3+rtwG7hERWu0GyEThBMWKs+uMibZ8VqnZ+zzV342n5MIwm7JBrs0FM9y8J0 WD4J/m1o5F4xQtt80PEK8dVggrALD/pnR1u9Pq4IlzaswL/0lXmbEq/3rxuPSQ1P 8INy1V7sU35q3OtWGjlOV5GF9+0oKw== =gblL -----END PGP SIGNATURE----- --jM+4HfAWoFk3MHCN-- From xen-devel-bounces@lists.xenproject.org Sun Jul 03 13:35:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 13:35:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359581.588931 (Exim 4.92) (envelope-from ) id 1o7zkm-0005zG-Hx; Sun, 03 Jul 2022 13:35:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359581.588931; Sun, 03 Jul 2022 13:35:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7zkm-0005z9-D8; Sun, 03 Jul 2022 13:35:12 +0000 Received: by outflank-mailman (input) for mailman id 359581; Sun, 03 Jul 2022 13:35:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7zkk-0005yz-S3; Sun, 03 Jul 2022 13:35:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7zkk-00058l-MR; Sun, 03 Jul 2022 13:35:10 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o7zkk-0007tV-54; Sun, 03 Jul 2022 13:35:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o7zkk-00019y-4Z; Sun, 03 Jul 2022 13:35:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IaYZ5/JxoCzR6Q7JIin+xXos16yTSjBEDvnq7A1tCLY=; b=VGEMtcgx/eQtTXml/etUNeZHs9 ihRFhKBAuAAAAapqjs2C/Y0Eks4E2ubcLJf2RP6nZiP3LsyqJ85G9V1JzBNKvUShevq1BH6c6qGoM kvJLlfgsGCfSeO/GWZW3/SSqRnJyE1h51uRxVSGbI37oAojAOKPCSV/ovhsE+PLE9yTQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171467: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=17f8e36e224e200833b68c99308787f3c5d71d23 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 03 Jul 2022 13:35:10 +0000 flight 171467 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171467/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 17f8e36e224e200833b68c99308787f3c5d71d23 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 723 days Failing since 151818 2020-07-11 04:18:52 Z 722 days 704 attempts Testing same since 171451 2022-07-02 04:18:58 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115093 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 03 14:32:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 14:32:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359627.588960 (Exim 4.92) (envelope-from ) id 1o80eI-0005IQ-5k; Sun, 03 Jul 2022 14:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359627.588960; Sun, 03 Jul 2022 14:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o80eI-0005IJ-23; Sun, 03 Jul 2022 14:32:34 +0000 Received: by outflank-mailman (input) for mailman id 359627; Sun, 03 Jul 2022 14:32:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o80eG-0005I9-Oz; Sun, 03 Jul 2022 14:32:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o80eG-0006Bl-Kp; Sun, 03 Jul 2022 14:32:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o80eG-000263-6m; Sun, 03 Jul 2022 14:32:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o80eG-0004Ye-6E; Sun, 03 Jul 2022 14:32:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Upv0A5wFYnO8nsPKT3kAuhEhHWr9TXxZyqD28HKpi80=; b=6oc19K8ggBYS8hAMkdtudKV3fM t0iBwVJ6X1gdI+OT7gtjjpeaExc6K3Te6dXVVLCeB0X0R7hj1s7IQlUD+iCejrUymroyP24523ciX NEYcg3GACaAJfMyXv4lKSGqwqLjlkBkYWs1HgqFOnAg6NnxoH0ooY4ws6qeQCpxea7D0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171463: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 X-Osstest-Versions-That: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 From: osstest service owner Date: Sun, 03 Jul 2022 14:32:32 +0000 flight 171463 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171463/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 7 xen-install fail pass in 171455 test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail pass in 171455 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171455 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171455 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171455 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171455 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171455 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171455 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171455 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171455 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171455 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171455 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171455 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171455 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 baseline version: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 Last test of basis 171463 2022-07-03 01:54:15 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 03 14:58:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 14:58:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359637.588971 (Exim 4.92) (envelope-from ) id 1o812o-00082R-D7; Sun, 03 Jul 2022 14:57:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359637.588971; Sun, 03 Jul 2022 14:57:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o812o-00082K-90; Sun, 03 Jul 2022 14:57:54 +0000 Received: by outflank-mailman (input) for mailman id 359637; Sun, 03 Jul 2022 14:57:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o812m-00082E-Uk for xen-devel@lists.xenproject.org; Sun, 03 Jul 2022 14:57:53 +0000 Received: from na01-obe.outbound.protection.outlook.com (mail-cusazon11020014.outbound.protection.outlook.com [52.101.61.14]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 813a1574-fae0-11ec-bf74-3be3494bec92; Sun, 03 Jul 2022 16:57:50 +0200 (CEST) Received: from PH0PR21MB3025.namprd21.prod.outlook.com (2603:10b6:510:d2::21) by PH7PR21MB3332.namprd21.prod.outlook.com (2603:10b6:510:1d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.11; Sun, 3 Jul 2022 14:57:04 +0000 Received: from PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::7838:dcbf:513b:d992]) by PH0PR21MB3025.namprd21.prod.outlook.com ([fe80::7838:dcbf:513b:d992%5]) with mapi id 15.20.5438.000; Sun, 3 Jul 2022 14:57:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 813a1574-fae0-11ec-bf74-3be3494bec92 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ILu4N21AWyMjR7PUTuKb/69Zhi7Nrobc9g5Z5lXttRMIKBEaI5mw2aeGimUcI3e9DrtOmK8u/3K4tlRWsY1FftaElL2bTqWlUlyxPhe13Ht8zkSKRd/2LQSDl9tWXbw2ss2cl1mXdS8hvztOM78n+4+xEhHpgeg4dqd94FC99zOXuxEi8fxfKEfNnFc2e5StUpWgGKh8CotncAXujdSMU9aO2FyDQ71sGGDPqKysGZc2UhppPhNy4pnkBbRJGj3p7fF9ifRKVxoclj4QD+5HaqTbJTQXTLYUbPjGZ//V4lWI4EbzdbRVsa9Ym4dWw2i398CyKvarfkuUJ0Xhf/KFgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4AlJlw0qEEXG80oeq+rYci/Isl6qoUqErSccHnJ4QUQ=; b=OWm/kLho0KuM8GLyImqeyurBxPc3Ej/qyq8CShJdTts5Z5F9bpJuCZ+Vi0W7K+M9eBywxDsaZ3DcPXZqMw4d6eh6uIJFqS5l9AEWqk8wp8JonqoWHZ6hWK50K5oX20/x+lwWLTs9VpgMqDCL8nYjQ0CV3D5Ixe1ElFMlkZQWHe2DiNY8PXBuOy4RYh9OE8w53PcHEhC4WmuRwBG5k7qDPyujI/V1afHAW54lNeKDKGsGoOaraKN46CRsCG/REZLGGV8nU12cmmVr/lteeg0OQ2FL8yorZ1Hcg7Er51MsHftGCuWAxrQrLjjnR2HynjZl+bvhm7xUmB6sU5rJstq+qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4AlJlw0qEEXG80oeq+rYci/Isl6qoUqErSccHnJ4QUQ=; b=Q3eLR7KUH1cqP+8BndpDUJD8+YbAoe7GZgyqiYLX4LkbpjC5W15HBSqJUVAtIAcHQ1YZvZK+GpbwQFgHfIhzDW2GBL7+Y2sCPgAhXCsJd9j5JN6uo18e7J0Oi/UVxXytR8zplxcMWZBDot2BmxCT719fE/wx8lTIjc1RqKMrOoQ= From: "Michael Kelley (LINUX)" To: Samuel Holland , Marc Zyngier , Thomas Gleixner CC: Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , KY Srinivasan , Kees Cook , =?iso-8859-2?Q?Krzysztof_Wilczy=F1ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , "iommu@lists.linux-foundation.org" , "iommu@lists.linux.dev" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hyperv@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "x86@kernel.org" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 7/8] genirq: Return a const cpumask from irq_data_get_affinity_mask Thread-Topic: [PATCH v3 7/8] genirq: Return a const cpumask from irq_data_get_affinity_mask Thread-Index: AQHYjYbXczmReTSuP0mFTu45zRpEE61svhUw Date: Sun, 3 Jul 2022 14:57:03 +0000 Message-ID: References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-8-samuel@sholland.org> In-Reply-To: <20220701200056.46555-8-samuel@sholland.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=22e47685-adf1-4a03-af55-361981d831ee;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2022-07-03T14:52:51Z;MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microsoft.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2c72871-6097-4439-7f44-08da5d044a4a x-ms-traffictypediagnostic: PH7PR21MB3332:EE_ x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QfnXwy1BAffW42CbR5lol/MBEIUFGBCn83YL26jm74qddj3LQArwGyzdKKGXlem+JVLU7hxsJiP4oPkoakgetu57U6/rJoN3gc2rjduvoI7fZaANz+pUAr8NwdqV/FFlab6qSIAWvY3MoW1f7FhC875NUTuJdEVNeLt561swgr9t3hvGuSqM1XSu2ljJwN8QM+ecBiMqGcjzVrfi9XLAFhZpm4Ghy+lTDiNxvafLU/HHpuClzVtjSP3rdwxpF2jJFAZDuV1fdokdFQ0/p5qnm1GF+QkioI6FtCh7IBxU6K+/M1JI7yvcsJFCznPealtzkJSAOZ34DSi4VQm8dfv3Zu0UFnRoTwkbt6xj7kAhVetbe+F4xqtQReIKKjDzkoKynoUnO4p1ZjM+TF+vgYIxRF7AF3y6cNy5yqnROfc829xbcHfRk9dg/NoIJXPyV+l6k1PDQc55VasKrFpfM+mzkgWndgTnRsc15nHf7NOmO+7DJixBnr65VFrG2BtrvJkGI3nNRFVcCOV5PVI21QdHB4Eh7CsJOscYqfhJAqSxqQjmG9hGGs6z7FcuBkMizmsorXZIekzEANFwak2EiWKN+HjU6Wyy0UURa+5/G7LqTxKVGVq7d5bWaU0jOUNBBazXY6NNsyTw5rRQJhUciCfRQRVjueykmzfWa2qmBt5PC4cqTZqt+l0gspBD6jLKoWvKMR+gvxL0DQCQGyK+RuR9tIytjEyeQd9hD2BGh/EPZ8ChpEI5Qtt8aR2ve7zLm7uQcyUKQf5ltguYuOSadJHqe2G7AmvdaoZa6otMXoK92cGi2vbr0eUcIau1zro0mds4KcDoleG2q7wsYkjbqoCDsxtGmzDDFikkokwjG2VVa5w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR21MB3025.namprd21.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(451199009)(55016003)(186003)(38070700005)(110136005)(122000001)(38100700002)(66476007)(4326008)(71200400001)(10290500003)(64756008)(316002)(66556008)(8676002)(66446008)(83380400001)(76116006)(66946007)(54906003)(8936002)(6506007)(7696005)(9686003)(7416002)(7406005)(86362001)(7366002)(478600001)(52536014)(26005)(82950400001)(82960400001)(33656002)(5660300002)(8990500004)(41300700001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-2?Q?HZYBz/SjFmopeaqiYNMtJ1+/z3RxpPOZzEYh79i0iQlgJt+Zki4vs7oJYr?= =?iso-8859-2?Q?dbG5Ca3LzVHC2SirMtYb0/Ebd1JzET0+EieJiUVJD7SndbwVHjZqNl/rm4?= =?iso-8859-2?Q?vYrMjlENkrSrsYhY0qWYgYbej5GMU9VYPLbN1Df9Xk6a1U30q9o7jvhpnK?= =?iso-8859-2?Q?J1l1ab38YVyMmeMARaYANpi/Fv3BM6B1pMzW9DdvMIPUEpswnMJaJ8+qK8?= =?iso-8859-2?Q?q9IcU4kGiE6ptTwAwlGxutPUmrfcM9YZCfc/ZMYYgJxlUzLW+Sg+9fmUlr?= =?iso-8859-2?Q?7cypNyAwo+wcxAj5jozctefH4SQaRkovHNL5D/Knlpm6hHJt/wy7csjkNC?= =?iso-8859-2?Q?Gio49moRX1WFCr0ZBHt0oP37Rndtvx6iGxbQfowru/bWRjGLyJ4NY6QGf/?= =?iso-8859-2?Q?pJsVtzwV0H6/luRPCiM5AaDCouM0JMWXpJIbgGHbN7JHY+7/ywiCwYM0Hb?= =?iso-8859-2?Q?aUry6tP0DeHy8QLn/Rj5Bil64JRehA+HOGAzZCXzt0NVlKnMH/muWfRIKK?= =?iso-8859-2?Q?I8zjEhyqmiwG0dM2e7Iss579BJ3wDXSmay8x3g+JVGUiCuDho2lhRSXIMf?= =?iso-8859-2?Q?FPmcDnVbIEHfdRLBiyOh5vIXCdvhYX6dhkWRKOAnQ7Ul2rBs3aKSjge5KC?= =?iso-8859-2?Q?QnPkdFyNivjNDCidPN9TLzXfgXeHn8qW/A3PXKhhztpqkefKA2yMie6cbn?= =?iso-8859-2?Q?oOYpuphXn88LrzXsVWS5/obx4JiAMCgHlNY9fCO/zBEMoZzjp4axzDe8+B?= =?iso-8859-2?Q?k0evSalMdZczMyqfThv+3LRdOSbK6iv27AFBHwaWh8Cw7ygOvv9niGYanf?= =?iso-8859-2?Q?AihQtLgHuaU8LPqshA9vN5xOeyek3Zbsvsqgu/Rqe8LUMT8wfozJdk2bZn?= =?iso-8859-2?Q?UnlD24PZfwvYDaK3SgiF1ao+5Hg+kmky7H7f01Jz+HEydQ4Z8NLRwJBTTi?= =?iso-8859-2?Q?LGtfD20GuorLBVmJbb/OELlrPydkNdob9hXzF2vNWFlrspxs8Agx9vUEj+?= =?iso-8859-2?Q?OUXLh+ad/J/JRfWhQAY0qK/VYAzdeNXpOGDHtg5mMS4WkA3aOhBiC5MzdS?= =?iso-8859-2?Q?fs6mPYziNNlH8zUE2OOX8TU5HH+3C7R563DJu3HG0hbaBYFWfXFitKrggp?= =?iso-8859-2?Q?0Phj/YuVBlu6/d7sNxBbIBCBXDOXNbVaQ/awoaN6Zwqgh+QN0DMt9aBvjF?= =?iso-8859-2?Q?6x0TpF8lwcrIcALXmmmC+2UY7nkwQPZgJkLgoNmj2GVK1Xl5/1DdMN4VjV?= =?iso-8859-2?Q?MO8mDEzT10y4n0TdOddH7RNwN3d4gdFy3FHu5Jq33+n6A4PPBMBHGgfmYC?= =?iso-8859-2?Q?S6SvzwFnpl0ZcM9ZcNiQgctAaYy+ichUFOfP0xNcZO2BhfzaXy4gEFtRQ0?= =?iso-8859-2?Q?C4JxC81DuMokFTQ6f5cFyEmmkEEA64E2r5KmsAN9wk5RfS38qU0mrIWGXU?= =?iso-8859-2?Q?saLCvVav06o0h5GABES6Z8zTb78QhyYNbra3LVMx56m+QZg/0WrP58OgiC?= =?iso-8859-2?Q?Pxvyz7GUvpa+RlxCZ/qZqcKMaMp1GTRu0dBkJrA763qKZecaPM7bpgO8rK?= =?iso-8859-2?Q?csgzswK6lIZd8QIqwzVdDTNUmNr8W0tKLuNlrlwcFdwGWcyDlWJKRcSDxw?= =?iso-8859-2?Q?JIyChbflD2RtsK96wMvVOeNu1mE8ADK5osIi3fXtP9rWGn/UWlNDX5jQ?= =?iso-8859-2?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR21MB3025.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2c72871-6097-4439-7f44-08da5d044a4a X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2022 14:57:03.3687 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /jduyyxp+FyBqGP61xV+NrlSuuiTVYzUzx0e8U7mIGorcY6P2rVwbT9XSTGJBLII/Hcetd8xw+uKyTgleBzrfgvdDZMKQ/jMEYynBm8WdCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR21MB3332 From: Samuel Holland Sent: Friday, July 1, 2022 1:01 = PM >=20 > Now that the irq_data_update_affinity helper exists, enforce its use > by returning a a const cpumask from irq_data_get_affinity_mask. Nit: duplicate word "a" >=20 > Since the previous commit already updated places that needed to call > irq_data_update_affinity, this commit updates the remaining code that > either did not modify the cpumask or immediately passed the modified > mask to irq_set_affinity. >=20 > Signed-off-by: Samuel Holland > --- >=20 > Changes in v3: > - New patch to make the returned cpumasks const >=20 > arch/mips/cavium-octeon/octeon-irq.c | 4 ++-- > arch/sh/kernel/irq.c | 7 ++++--- > arch/x86/hyperv/irqdomain.c | 2 +- > arch/xtensa/kernel/irq.c | 7 ++++--- > drivers/iommu/hyperv-iommu.c | 2 +- > drivers/pci/controller/pci-hyperv.c | 10 +++++----- > include/linux/irq.h | 12 +++++++----- > kernel/irq/chip.c | 8 +++++--- > kernel/irq/debugfs.c | 2 +- > kernel/irq/ipi.c | 16 +++++++++------- > 10 files changed, 39 insertions(+), 31 deletions(-) >=20 [snip] > diff --git a/arch/x86/hyperv/irqdomain.c b/arch/x86/hyperv/irqdomain.c > index 7e0f6bedc248..42c70d28ef27 100644 > --- a/arch/x86/hyperv/irqdomain.c > +++ b/arch/x86/hyperv/irqdomain.c > @@ -192,7 +192,7 @@ static void hv_irq_compose_msi_msg(struct irq_data *d= ata, > struct msi_msg *msg) > struct pci_dev *dev; > struct hv_interrupt_entry out_entry, *stored_entry; > struct irq_cfg *cfg =3D irqd_cfg(data); > - cpumask_t *affinity; > + const cpumask_t *affinity; > int cpu; > u64 status; >=20 [snip] > diff --git a/drivers/iommu/hyperv-iommu.c b/drivers/iommu/hyperv-iommu.c > index e285a220c913..51bd66a45a11 100644 > --- a/drivers/iommu/hyperv-iommu.c > +++ b/drivers/iommu/hyperv-iommu.c > @@ -194,7 +194,7 @@ hyperv_root_ir_compose_msi_msg(struct irq_data *irq_d= ata, > struct msi_msg *msg) > u32 vector; > struct irq_cfg *cfg; > int ioapic_id; > - struct cpumask *affinity; > + const struct cpumask *affinity; > int cpu; > struct hv_interrupt_entry entry; > struct hyperv_root_ir_data *data =3D irq_data->chip_data; > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller= /pci-hyperv.c > index db814f7b93ba..aebada45569b 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -642,7 +642,7 @@ static void hv_arch_irq_unmask(struct irq_data *data) > struct hv_retarget_device_interrupt *params; > struct tran_int_desc *int_desc; > struct hv_pcibus_device *hbus; > - struct cpumask *dest; > + const struct cpumask *dest; > cpumask_var_t tmp; > struct pci_bus *pbus; > struct pci_dev *pdev; > @@ -1613,7 +1613,7 @@ static void hv_pci_compose_compl(void *context, str= uct > pci_response *resp, > } >=20 > static u32 hv_compose_msi_req_v1( > - struct pci_create_interrupt *int_pkt, struct cpumask *affinity, > + struct pci_create_interrupt *int_pkt, const struct cpumask *affinity, > u32 slot, u8 vector, u8 vector_count) > { > int_pkt->message_type.type =3D PCI_CREATE_INTERRUPT_MESSAGE; > @@ -1641,7 +1641,7 @@ static int hv_compose_msi_req_get_cpu(struct cpumas= k > *affinity) > } >=20 > static u32 hv_compose_msi_req_v2( > - struct pci_create_interrupt2 *int_pkt, struct cpumask *affinity, > + struct pci_create_interrupt2 *int_pkt, const struct cpumask *affinity, > u32 slot, u8 vector, u8 vector_count) > { > int cpu; > @@ -1660,7 +1660,7 @@ static u32 hv_compose_msi_req_v2( > } >=20 > static u32 hv_compose_msi_req_v3( > - struct pci_create_interrupt3 *int_pkt, struct cpumask *affinity, > + struct pci_create_interrupt3 *int_pkt, const struct cpumask *affinity, > u32 slot, u32 vector, u8 vector_count) > { > int cpu; > @@ -1697,7 +1697,7 @@ static void hv_compose_msi_msg(struct irq_data *dat= a, > struct msi_msg *msg) > struct hv_pci_dev *hpdev; > struct pci_bus *pbus; > struct pci_dev *pdev; > - struct cpumask *dest; > + const struct cpumask *dest; > struct compose_comp_ctxt comp; > struct tran_int_desc *int_desc; > struct msi_desc *msi_desc; For these files with Hyper-V related changes: arch/x86/hyperv/irqdomain.c drivers/iommu/hyperv-iommu.c drivers/pci/controller/pci-hyperv.c Reviewed-by: Michael Kelley From xen-devel-bounces@lists.xenproject.org Sun Jul 03 15:05:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 15:05:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359644.588982 (Exim 4.92) (envelope-from ) id 1o81AK-0001BY-4Y; Sun, 03 Jul 2022 15:05:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359644.588982; Sun, 03 Jul 2022 15:05:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o81AK-0001BR-1q; Sun, 03 Jul 2022 15:05:40 +0000 Received: by outflank-mailman (input) for mailman id 359644; Sun, 03 Jul 2022 15:05:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o81AI-0001BL-8z for xen-devel@lists.xenproject.org; Sun, 03 Jul 2022 15:05:38 +0000 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [2607:f8b0:4864:20::b2b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 979cc0d5-fae1-11ec-bd2d-47488cf2e6aa; Sun, 03 Jul 2022 17:05:37 +0200 (CEST) Received: by mail-yb1-xb2b.google.com with SMTP id e69so6005843ybh.2 for ; Sun, 03 Jul 2022 08:05:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 979cc0d5-fae1-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4QgHhJo99e7BP4qELBN4r2lriKbWdLtk6/DKUxmzOGg=; b=Vh7pwmFrp/ki5XJ76jyI5hNuUV1PKQWxt+H19V/GLJ3etny3Ed4qf9e0QV9OMyCnks +V7tZtdw1VniQ6BdZSdBWajNOZDP/9WVdUA9+J37kLhzlbC4xMvQ7twWstXyRhygrgEk OySwdBIMfbZujBrURcg8GdeODfqyyz4SIitS0W7F6ysxNT0VLPBddMx3/a/GvGvQdxvo iMowCy/4ZchQtcTLw19pWaXjlYPd52toUo7sie8xXqMfjy5oNYUEW0ViDYOw6PUrk0C5 G34+Zs4D16S3OjNGlDvG+54xupVbs4o/Tt1NVLksn8dVuCTj0pxBkrj4yh/fdGcgDAoR 8k/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4QgHhJo99e7BP4qELBN4r2lriKbWdLtk6/DKUxmzOGg=; b=E5JfP7G7BO+JvOsByQQ20Hx9SIwTwVSPwca/nJgkiJx/NtZa0i15q7dg970tWH//Kh e+N6QQ8ggznkr66R62UxAWkolvVgI2vblbq0GWBF/mAJaajMwTXk2BIq9cf9YhoULdiN HDvcrBLmzxg02fUZ0j8r0ZVG6eGgbCHvoEz0+WjmCrTrYPTTX98TBuZGv/3O8v5GHaK4 ml5EqVo+kAwUvwkBrgAsL3V33CumKoswIvTL9jp8Ny9Qf2ZtRjwBrAcpG40LvBMDgP4k SNiIS2g+Wt1dXLRrO1owpZml0GUB8/cQ1XwyqT/0ttHNkAidGXuzGfZj3NpF4JHGYkjo oQNw== X-Gm-Message-State: AJIora/si3e1cfnX27i7s2lsIRuAxM/7Rf3n35aBKMB9mirRVD4LOS8G q6ZTnDcl+YjcPmdpgJROHxBtN/Q3jx9mqt3xBBQ= X-Google-Smtp-Source: AGRyM1uAuVW9IWphg5kSjbYsSYjb/TM871XbOL+Xts9oBKQbm/sejVIg7QWw6bS/e6Nkvrm3x1W/9pxqPUjTrwcE74M= X-Received: by 2002:a25:858e:0:b0:66e:4898:63e2 with SMTP id x14-20020a25858e000000b0066e489863e2mr673140ybk.296.1656860735358; Sun, 03 Jul 2022 08:05:35 -0700 (PDT) MIME-Version: 1.0 References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-8-samuel@sholland.org> In-Reply-To: <20220701200056.46555-8-samuel@sholland.org> From: Andy Shevchenko Date: Sun, 3 Jul 2022 17:04:58 +0200 Message-ID: Subject: Re: [PATCH v3 7/8] genirq: Return a const cpumask from irq_data_get_affinity_mask To: Samuel Holland Cc: Marc Zyngier , Thomas Gleixner , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , "list@263.net:IOMMU DRIVERS" , iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm Mailing List , Linux on Hyper-V List , linux-ia64@vger.kernel.org, Linux Kernel Mailing List , "open list:BROADCOM NVRAM DRIVER" , linux-parisc@vger.kernel.org, linux-pci , Linux-SH , linux-xtensa@linux-xtensa.org, "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" On Fri, Jul 1, 2022 at 10:01 PM Samuel Holland wrote: > > Now that the irq_data_update_affinity helper exists, enforce its use > by returning a a const cpumask from irq_data_get_affinity_mask. > > Since the previous commit already updated places that needed to call > irq_data_update_affinity, this commit updates the remaining code that > either did not modify the cpumask or immediately passed the modified > mask to irq_set_affinity. When we refer to functions, we use parentheses, e.g. func(). -- With Best Regards, Andy Shevchenko From xen-devel-bounces@lists.xenproject.org Sun Jul 03 15:22:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 15:22:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359652.588993 (Exim 4.92) (envelope-from ) id 1o81QI-0003kT-Ha; Sun, 03 Jul 2022 15:22:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359652.588993; Sun, 03 Jul 2022 15:22:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o81QI-0003kM-Ea; Sun, 03 Jul 2022 15:22:10 +0000 Received: by outflank-mailman (input) for mailman id 359652; Sun, 03 Jul 2022 15:22:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o81QI-0003kG-2j for xen-devel@lists.xenproject.org; Sun, 03 Jul 2022 15:22:10 +0000 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [2a00:1450:4864:20::22a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7447a31-fae3-11ec-bf74-3be3494bec92; Sun, 03 Jul 2022 17:22:08 +0200 (CEST) Received: by mail-lj1-x22a.google.com with SMTP id v9so8177545ljk.10 for ; Sun, 03 Jul 2022 08:22:08 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s10-20020a056512202a00b0047255d21132sm4758576lfs.97.2022.07.03.08.22.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 03 Jul 2022 08:22:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7447a31-fae3-11ec-bf74-3be3494bec92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=7h/oDkelqUvQhnXMEHsIGaLApBCL4bVp/zpTNjHKaa0=; b=Ajde41bE2wU0CLXRYXxA4RUv0bp0nc6vv24Jkv3jO+pNmgV5SruaUwkgdZh2uTckb2 LjwBe+5chzPdn9GsqinhSMRPDH/BkAH/rWbDiCgv3b73DzTdIIwCuu7rSSyi6XgKQgam QzYkv4hEeMuDSoYQBiHL7V7XX8PuwVWoX68+MhlsNYB1tpAW+qusPDMIKzVjewkktdka B8RzQXojCPXGgXsFV0Py1qu3xQ+dQ+Ph5W2hTs/NfGpTe8YoyNytz8Jxlg3eba2Qpapr 0dHtsjY/VCs3nDTxh/rSpBzNfE0J7lWIPD0uFnZAO2fN8qfYU1kzNyc0DtqVW3j5bPa6 jQig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=7h/oDkelqUvQhnXMEHsIGaLApBCL4bVp/zpTNjHKaa0=; b=4SeZJ/rxH8ozJZjJ59YI7i89aEm120P4Ezz17hXi/nTz+niBCb1qiKehYYtMTwQxcG j7jXNJ7d9a11Lv7MR1XG7G+W/hmG6/SLEBtFT2N33Wif4rprtrDovvPK/k64xO8kgbkx xS+z2CNy8LM/z29N162U9Y05jwMDup+24IQhtJoxje9QIrKOXj2MgdYvo9UPEs4sll/R +9UgYkyN7bkIMnwSEynMgWB4cOJzMIEsf4tqsp9KbRRw9xW7DG1YCCPhYFxosDh+AeeK xU5Co2ixTNw++UXS6MZt3A97MztjblD22A9JB9OVuRP/JZDkFd5gg9WRN129AlSPKMQB JBvA== X-Gm-Message-State: AJIora/DxJriEkbqsXHR68J2U4YVBUgYcgbj8PArXpkzuknyrG0sz4zc j+AN5ObWfT5wFCZu3+hovOMEO5ebEPE= X-Google-Smtp-Source: AGRyM1trX48ruuzycgoteqtLbzXdO1QJTxFK4a9qaPKv/Ind+sZ8MDYf+3trOk+5IJ6FZryqObKQIg== X-Received: by 2002:a2e:9941:0:b0:25b:c885:3143 with SMTP id r1-20020a2e9941000000b0025bc8853143mr14475290ljj.477.1656861727485; Sun, 03 Jul 2022 08:22:07 -0700 (PDT) Subject: Re: [PATCH v3 6/8] genirq: Add and use an irq_data_update_affinity helper To: Samuel Holland Cc: Marc Zyngier , Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-7-samuel@sholland.org> From: Oleksandr Message-ID: Date: Sun, 3 Jul 2022 18:22:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20220701200056.46555-7-samuel@sholland.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US On 01.07.22 23:00, Samuel Holland wrote: Hello Samuel > Some architectures and irqchip drivers modify the cpumask returned by > irq_data_get_affinity_mask, usually by copying in to it. This is > problematic for uniprocessor configurations, where the affinity mask > should be constant, as it is known at compile time. > > Add and use a setter for the affinity mask, following the pattern of > irq_data_update_effective_affinity. This allows the getter function to > return a const cpumask pointer. > > Signed-off-by: Samuel Holland > --- > > Changes in v3: > - New patch to introduce irq_data_update_affinity > > arch/alpha/kernel/irq.c | 2 +- > arch/ia64/kernel/iosapic.c | 2 +- > arch/ia64/kernel/irq.c | 4 ++-- > arch/ia64/kernel/msi_ia64.c | 4 ++-- > arch/parisc/kernel/irq.c | 2 +- > drivers/irqchip/irq-bcm6345-l1.c | 4 ++-- > drivers/parisc/iosapic.c | 2 +- > drivers/sh/intc/chip.c | 2 +- > drivers/xen/events/events_base.c | 7 ++++--- > include/linux/irq.h | 6 ++++++ > 10 files changed, 21 insertions(+), 14 deletions(-) > > diff --git a/arch/alpha/kernel/irq.c b/arch/alpha/kernel/irq.c > index f6d2946edbd2..15f2effd6baf 100644 > --- a/arch/alpha/kernel/irq.c > +++ b/arch/alpha/kernel/irq.c > @@ -60,7 +60,7 @@ int irq_select_affinity(unsigned int irq) > cpu = (cpu < (NR_CPUS-1) ? cpu + 1 : 0); > last_cpu = cpu; > > - cpumask_copy(irq_data_get_affinity_mask(data), cpumask_of(cpu)); > + irq_data_update_affinity(data, cpumask_of(cpu)); > chip->irq_set_affinity(data, cpumask_of(cpu), false); > return 0; > } > diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c > index 35adcf89035a..99300850abc1 100644 > --- a/arch/ia64/kernel/iosapic.c > +++ b/arch/ia64/kernel/iosapic.c > @@ -834,7 +834,7 @@ iosapic_unregister_intr (unsigned int gsi) > if (iosapic_intr_info[irq].count == 0) { > #ifdef CONFIG_SMP > /* Clear affinity */ > - cpumask_setall(irq_get_affinity_mask(irq)); > + irq_data_update_affinity(irq_get_irq_data(irq), cpu_all_mask); > #endif > /* Clear the interrupt information */ > iosapic_intr_info[irq].dest = 0; > diff --git a/arch/ia64/kernel/irq.c b/arch/ia64/kernel/irq.c > index ecef17c7c35b..275b9ea58c64 100644 > --- a/arch/ia64/kernel/irq.c > +++ b/arch/ia64/kernel/irq.c > @@ -57,8 +57,8 @@ static char irq_redir [NR_IRQS]; // = { [0 ... NR_IRQS-1] = 1 }; > void set_irq_affinity_info (unsigned int irq, int hwid, int redir) > { > if (irq < NR_IRQS) { > - cpumask_copy(irq_get_affinity_mask(irq), > - cpumask_of(cpu_logical_id(hwid))); > + irq_data_update_affinity(irq_get_irq_data(irq), > + cpumask_of(cpu_logical_id(hwid))); > irq_redir[irq] = (char) (redir & 0xff); > } > } > diff --git a/arch/ia64/kernel/msi_ia64.c b/arch/ia64/kernel/msi_ia64.c > index df5c28f252e3..025e5133c860 100644 > --- a/arch/ia64/kernel/msi_ia64.c > +++ b/arch/ia64/kernel/msi_ia64.c > @@ -37,7 +37,7 @@ static int ia64_set_msi_irq_affinity(struct irq_data *idata, > msg.data = data; > > pci_write_msi_msg(irq, &msg); > - cpumask_copy(irq_data_get_affinity_mask(idata), cpumask_of(cpu)); > + irq_data_update_affinity(idata, cpumask_of(cpu)); > > return 0; > } > @@ -132,7 +132,7 @@ static int dmar_msi_set_affinity(struct irq_data *data, > msg.address_lo |= MSI_ADDR_DEST_ID_CPU(cpu_physical_id(cpu)); > > dmar_msi_write(irq, &msg); > - cpumask_copy(irq_data_get_affinity_mask(data), mask); > + irq_data_update_affinity(data, mask); > > return 0; > } > diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c > index 0fe2d79fb123..5ebb1771b4ab 100644 > --- a/arch/parisc/kernel/irq.c > +++ b/arch/parisc/kernel/irq.c > @@ -315,7 +315,7 @@ unsigned long txn_affinity_addr(unsigned int irq, int cpu) > { > #ifdef CONFIG_SMP > struct irq_data *d = irq_get_irq_data(irq); > - cpumask_copy(irq_data_get_affinity_mask(d), cpumask_of(cpu)); > + irq_data_update_affinity(d, cpumask_of(cpu)); > #endif > > return per_cpu(cpu_data, cpu).txn_addr; > diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c > index 142a7431745f..6899e37810a8 100644 > --- a/drivers/irqchip/irq-bcm6345-l1.c > +++ b/drivers/irqchip/irq-bcm6345-l1.c > @@ -216,11 +216,11 @@ static int bcm6345_l1_set_affinity(struct irq_data *d, > enabled = intc->cpus[old_cpu]->enable_cache[word] & mask; > if (enabled) > __bcm6345_l1_mask(d); > - cpumask_copy(irq_data_get_affinity_mask(d), dest); > + irq_data_update_affinity(d, dest); > if (enabled) > __bcm6345_l1_unmask(d); > } else { > - cpumask_copy(irq_data_get_affinity_mask(d), dest); > + irq_data_update_affinity(d, dest); > } > raw_spin_unlock_irqrestore(&intc->lock, flags); > > diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c > index 8a3b0c3a1e92..3a8c98615634 100644 > --- a/drivers/parisc/iosapic.c > +++ b/drivers/parisc/iosapic.c > @@ -677,7 +677,7 @@ static int iosapic_set_affinity_irq(struct irq_data *d, > if (dest_cpu < 0) > return -1; > > - cpumask_copy(irq_data_get_affinity_mask(d), cpumask_of(dest_cpu)); > + irq_data_update_affinity(d, cpumask_of(dest_cpu)); > vi->txn_addr = txn_affinity_addr(d->irq, dest_cpu); > > spin_lock_irqsave(&iosapic_lock, flags); > diff --git a/drivers/sh/intc/chip.c b/drivers/sh/intc/chip.c > index 358df7510186..828d81e02b37 100644 > --- a/drivers/sh/intc/chip.c > +++ b/drivers/sh/intc/chip.c > @@ -72,7 +72,7 @@ static int intc_set_affinity(struct irq_data *data, > if (!cpumask_intersects(cpumask, cpu_online_mask)) > return -1; > > - cpumask_copy(irq_data_get_affinity_mask(data), cpumask); > + irq_data_update_affinity(data, cpumask); > > return IRQ_SET_MASK_OK_NOCOPY; > } > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index 46d9295d9a6e..5e8321f43cbd 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -528,9 +528,10 @@ static void bind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int cpu, > BUG_ON(irq == -1); > > if (IS_ENABLED(CONFIG_SMP) && force_affinity) { > - cpumask_copy(irq_get_affinity_mask(irq), cpumask_of(cpu)); > - cpumask_copy(irq_get_effective_affinity_mask(irq), > - cpumask_of(cpu)); > + struct irq_data *data = irq_get_irq_data(irq); > + > + irq_data_update_affinity(data, cpumask_of(cpu)); > + irq_data_update_effective_affinity(data, cpumask_of(cpu)); > } Nit: commit description says about reusing irq_data_update_affinity() only, but here we also reuse irq_data_update_effective_affinity(), so I would mention that in the description. Reviewed-by: Oleksandr Tyshchenko # Xen bits [snip] -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Sun Jul 03 16:57:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 16:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359665.589004 (Exim 4.92) (envelope-from ) id 1o82uT-0005kH-PQ; Sun, 03 Jul 2022 16:57:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359665.589004; Sun, 03 Jul 2022 16:57:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o82uT-0005kA-LG; Sun, 03 Jul 2022 16:57:25 +0000 Received: by outflank-mailman (input) for mailman id 359665; Sun, 03 Jul 2022 16:57:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o82uS-0005k0-CQ; Sun, 03 Jul 2022 16:57:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o82uS-0000iv-8D; Sun, 03 Jul 2022 16:57:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o82uR-0007Z5-NB; Sun, 03 Jul 2022 16:57:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o82uR-0000L7-Mf; Sun, 03 Jul 2022 16:57:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2F1nUJVT1BYy2diFtalXujrC4XxeaxFOWMNc4f8qr4o=; b=j9UidhrmxJCUZtSsGC85K9RD6B Kj9PSqNP0w3oxep4quMT2nA70iM9/GKespdUemmkOCETLKk/bskaIP9qbOY7hQtvzzFjMiqyR8dQT QtBUEKJQJQJLeYVT0cWbRcn4cQN5HsGYEy7jwaSNEaaV2ffysx0Qdqnhwy/UCyDwC07Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171465: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-examine:xen-install:fail:heisenbug linux-5.4:test-amd64-amd64-xl-credit1:guest-localmigrate:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=871cbc208bf0aded1946cd1e3eebec75799d31e8 X-Osstest-Versions-That: linux=23db944f754e99abf814a79a2273b0191d35e4ff From: osstest service owner Date: Sun, 03 Jul 2022 16:57:23 +0000 flight 171465 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171465/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail in 171460 pass in 171465 test-armhf-armhf-xl-credit1 14 guest-start fail in 171460 pass in 171465 test-amd64-i386-examine 6 xen-install fail pass in 171460 test-amd64-amd64-xl-credit1 18 guest-localmigrate fail pass in 171460 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171460 test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 171460 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171352 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail blocked in 171352 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171460 like 171352 test-armhf-armhf-xl-credit2 14 guest-start fail in 171460 like 171352 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171460 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171460 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171352 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171352 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171352 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171352 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171352 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171352 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 871cbc208bf0aded1946cd1e3eebec75799d31e8 baseline version: linux 23db944f754e99abf814a79a2273b0191d35e4ff Last test of basis 171352 2022-06-25 11:13:17 Z 8 days Failing since 171400 2022-06-29 07:11:34 Z 4 days 9 attempts Testing same since 171460 2022-07-02 16:43:26 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Aidan MacDonald Alexander Gordeev Anatolii Gerasymenko Andrew Donnellan Andrew Morton Antoine Tenart Ard Biesheuvel Ard Biesheuvel Arnd Bergmann Ballon Shi Bartosz Golaszewski Baruch Siach Carlo Lobrano Chevron Li Chevron Li Christoph Hellwig Claudiu Manoil Curtis Taylor Damien Le Moal Dan Carpenter Daniel Borkmann Daniel Vetter David Howells David S. Miller Dmitry Rokosov Edward Wu Eelco Chaudron Eric Dumazet Florian Fainelli Genjian Zhang Gerd Hoffmann Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Haibo Chen Hans de Goede Helge Deller Herbert Xu huhai Hulk Robot Jakub Kicinski Jason A. Donenfeld Jason Wang Jay Vosburgh Jesper Dangaard Brouer Jessica Yu Jian Cai Jian Cai Jiri Slaby Johan Hovold Jon Hunter Jon Maxwell Jonathan Cameron Jonathan Toppins Juergen Gross Julien Grall Kai-Heng Feng Kailang Yang Krzysztof Halasa Krzysztof Kozlowski Liang He Linus Torvalds Linux Kernel Functional Testing Lucas Stach Macpaul Lin Marc Dionne Mark Brown Masahiro Yamada Mathias Nyman Max Filippov Miaoqian Lin Michael Ellerman Mike Snitzer Mikulas Patocka Miquel Raynal Naveen N. Rao Nick Desaulniers Nicolas Pitre Nikos Tsironis Olivier Moysan Paolo Abeni Peilin Ye Rob Clark Ron Economos Rosemarie O'Riorden Russell King Sami Tolvanen Sascha Hauer Sasha Levin Sebastian Andrzej Siewior Shawn Guo Shuah Khan Stefan Agner Stephan Gerhold Stephen Hemminger Sudip Mukherjee Sumanth Korikkar Sumit Dubey2 Takashi Iwai Thomas Bogendoerfer Thomas Richter Tim Crawford Tony Lindgren Tony Nguyen Ulf Hansson Vincent Whitchurch Vladimir Oltean Xu Yang Yonglin Tan Zheyu Ma Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 23db944f754e..871cbc208bf0 871cbc208bf0aded1946cd1e3eebec75799d31e8 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sun Jul 03 18:16:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 18:16:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359682.589014 (Exim 4.92) (envelope-from ) id 1o848l-00068B-IP; Sun, 03 Jul 2022 18:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359682.589014; Sun, 03 Jul 2022 18:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o848l-000684-FF; Sun, 03 Jul 2022 18:16:15 +0000 Received: by outflank-mailman (input) for mailman id 359682; Sun, 03 Jul 2022 18:16:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o848k-00067u-5I; Sun, 03 Jul 2022 18:16:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o848k-0002GF-2I; Sun, 03 Jul 2022 18:16:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o848j-00019Y-JV; Sun, 03 Jul 2022 18:16:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o848j-0004EY-J1; Sun, 03 Jul 2022 18:16:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YNsr0AIYVtuojj4mg0PdElwBTVQ8JICGqk4R4kKH88Q=; b=w/2azfeoKVoCJ8evc+xvIkHDhu 8wpOmWQ+EDlFFho9KYkEKARH7ttBCqgLji/wEN0C7xZ6O9Gu8UAhnl7PULR6CJclPP9EK1+46il7b QpXv/7X9798gDJhv8BR7HOKrBASO2rRlLS3ArhufTWWS323ADxHXSisqNftcjlDd0p2I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171470: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=69cb6c6556ad89620547318439d6be8bb1629a5a X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 03 Jul 2022 18:16:13 +0000 flight 171470 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171470/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 69cb6c6556ad89620547318439d6be8bb1629a5a baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 14 days Failing since 171280 2022-06-19 15:12:25 Z 14 days 38 attempts Testing same since 171461 2022-07-02 23:12:32 Z 0 days 2 attempts ------------------------------------------------------------ 467 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 17882 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 03 22:36:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 03 Jul 2022 22:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359699.589026 (Exim 4.92) (envelope-from ) id 1o88C5-0007ft-8Z; Sun, 03 Jul 2022 22:35:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359699.589026; Sun, 03 Jul 2022 22:35:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o88C5-0007fm-5s; Sun, 03 Jul 2022 22:35:57 +0000 Received: by outflank-mailman (input) for mailman id 359699; Sun, 03 Jul 2022 22:35:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o88C3-0007fa-Eb; Sun, 03 Jul 2022 22:35:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o88C3-0006yu-BN; Sun, 03 Jul 2022 22:35:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o88C2-0007i9-Oa; Sun, 03 Jul 2022 22:35:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o88C2-0006F5-Nx; Sun, 03 Jul 2022 22:35:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wre7klksu5ns0g8OAKaTwWOERLfdFH+Vzm9Y+YHqYoI=; b=cK2V9LQSkmmLSOWW6arxCT9gdF 19VKJMDJYqztJ0F9sP7mfIb57zRrE5F69IIQ1756ptgV5F7XnxEaxITo7jDsM3wo8CYiC734CuQ6C OLRF5TZ/CR8vhuFn7ALPhiH/NADelDOIp5ytvkYE7AuAAXsKK3PG+2i5Cv9XuK6Ojniw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171472: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e8e86b484eac70cd86e15fa10a2f0038a536cbba X-Osstest-Versions-That: qemuu=ba45b82518bd5d9cad509765411e7f82a73aed53 From: osstest service owner Date: Sun, 03 Jul 2022 22:35:54 +0000 flight 171472 qemu-mainline real [real] flight 171474 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171472/ http://logs.test-lab.xenproject.org/osstest/logs/171474/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 171462 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171462 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171462 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171462 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass version targeted for testing: qemuu e8e86b484eac70cd86e15fa10a2f0038a536cbba baseline version: qemuu ba45b82518bd5d9cad509765411e7f82a73aed53 Last test of basis 171462 2022-07-03 01:07:33 Z 0 days Testing same since 171472 2022-07-03 11:33:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anup Patel Atish Patra Atish Patra Bin Meng Nicolas Pitre Richard Henderson Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 446 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 02:49:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 02:49:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359721.589043 (Exim 4.92) (envelope-from ) id 1o8C9F-0007Xu-UG; Mon, 04 Jul 2022 02:49:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359721.589043; Mon, 04 Jul 2022 02:49:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8C9F-0007Xm-O5; Mon, 04 Jul 2022 02:49:17 +0000 Received: by outflank-mailman (input) for mailman id 359721; Mon, 04 Jul 2022 02:49:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8C9F-0007Xc-D9; Mon, 04 Jul 2022 02:49:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8C9F-0002NQ-9k; Mon, 04 Jul 2022 02:49:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8C9E-0001eI-Np; Mon, 04 Jul 2022 02:49:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8C9E-0000R9-Ll; Mon, 04 Jul 2022 02:49:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/nDsrYGQK2zt0E6GC3RvgIzytifm+8Crn3O4zbYlL4w=; b=DoJJjoBHYj2eT/hJoP8GZ0NQiO kKywW9FhO91l5q+rRSr10CxlKAx420FH5Q3tTUIr3WcM88aV+GRhxwhpKsTVn9mekiiOw/agZShK1 5lEotaVp+V6heP8S9GVRbPvdFO6tJQySviKVVcIZzYSpLAyTdkT/STQw0xsJYO1QO5RE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171473: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=20855e4cb361adeabce3665f5174b09b4a6ebfe6 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Mon, 04 Jul 2022 02:49:16 +0000 flight 171473 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171473/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 20855e4cb361adeabce3665f5174b09b4a6ebfe6 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 14 days Failing since 171280 2022-06-19 15:12:25 Z 14 days 39 attempts Testing same since 171473 2022-07-03 18:42:41 Z 0 days 1 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 18411 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 04:35:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 04:35:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359732.589053 (Exim 4.92) (envelope-from ) id 1o8DnJ-0002g4-Od; Mon, 04 Jul 2022 04:34:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359732.589053; Mon, 04 Jul 2022 04:34:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8DnJ-0002fx-Lt; Mon, 04 Jul 2022 04:34:45 +0000 Received: by outflank-mailman (input) for mailman id 359732; Mon, 04 Jul 2022 04:34:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8DnI-0002fr-HO for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 04:34:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f364dcd-fb52-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 06:34:42 +0200 (CEST) Received: from DB6PR07CA0119.eurprd07.prod.outlook.com (2603:10a6:6:2c::33) by AM9PR08MB7242.eurprd08.prod.outlook.com (2603:10a6:20b:431::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 04:34:39 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2c:cafe::22) by DB6PR07CA0119.outlook.office365.com (2603:10a6:6:2c::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.8 via Frontend Transport; Mon, 4 Jul 2022 04:34:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 04:34:38 +0000 Received: ("Tessian outbound 879f4da7a6e9:v121"); Mon, 04 Jul 2022 04:34:38 +0000 Received: from 61a8d9e72b4d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 814884F4-546A-469A-A58F-3BEBBA6C1230.1; Mon, 04 Jul 2022 04:34:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 61a8d9e72b4d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 04:34:32 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PR3PR08MB5770.eurprd08.prod.outlook.com (2603:10a6:102:87::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 04:34:31 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 04:34:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f364dcd-fb52-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k9zHoBNQcio84mWleki7Ff/S9CrRV96fB8CefvvtFrcbvl7/fumiSfDNg9S7dJ0c9vSrLZp7pUAV8riUYUasxozDUclcetDfr1KezNHk+e/u7POLJlKBtqhmf1DlH+w1W8Ayyj4N1jlnG00lcBmXc7tp582Eg6gFeE+HotVOKJRML0eUwmZV7k7RHEmzS2xB/u0k5s/u5zUupgT2YMCKsQs59ooVrMxyzzSmLdxGjCf5JJba4MLzmQ+S/W6xaOBxuSy+mYbUNdHW+txQLJ2zps6sGqqsuGEvkdx3H3u1wtWvToAJvRPgt+1dvO6L2N4gtXRe+LQ0Asr/dFtscgqrTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=H7TP0VNwYFzgDdgARNofnNqQt7RDUnDqmSMm6g5ZN/R00Z0+WEr3eJHwKZ7VLO6DvqmUQ6H0Nsp8zSCW72TmFSl2mTDnW29ZR170vSXc1DBCA64VXOuvXonAHOfMl+8co6nLmLOdAcAPFJHwQNhKNg51OVTD7EUzfuJP8TURRHGMFLI2BBVNYmmRF5yqrIKa5Y3i/tB4TcMU3jgS5wrlQ6MEi2arZwfiThykXOAnZ/XSAJPamtRtEfizkaACcCsgxTcVizKO5+N4Uf+y0b/DnGFjYn23ZdyU2p7BcNub+C9AmTFoamRo3CeUBgsaoUgSg9IF8vLGzoMlKkeF0Y6hdg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=2l57i/gdo0jci+PD0t2ZfCvp3ojor14y4XCq5GMou76jABtkGyW319vRr1Llsx+7/Fyo4Ykqe+Eh/frp3QHOLA4xzwAB2LyNj1YdtVxP8cW+B300Zli/zMgklL0lxzzyfJt++N6DOry5rS5J9SlghmkmJuul9tDw+zK7vjErmyE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=azwJGVLI9LPaZFSCMVDgUVVvMSx2w2XsrPj7GzZdCRwyLbGM5X7Fbb62qIjs4CQ8GE7hslEkMDxvzZO9yfHqecdESBNn8quVREskg7KKxHHqipnFpcF6E1X9TrOEWw0YwMlzJbfyz7GGcDT/byRzC8kJ7fcKe8IM6zP5zG4m5DOPWec1jmOCAQHI4kIFw/UPYKYa2JqdEA0ZfiIlEiGxOJ5KmTy2ywpLWhykecWMOhujWBcCiV1VIb4Mz1H0KWmaCPBinHw4iy0gcIRQn0wG49Qwz0xJNTY3xoRB8GzYzar2J8oWPqQNOOOvIxOamXFFwPK11UPqKGJTg35qxXW1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=cykm1/u9Ykipo4OKrJipNd7PKPZzJvXv4012AYy4+gVeKTFOKnZjo9urKj8rtULT5INZz2a3Eb9bbZTy1pK4lbv4OSIoW/tC+GOL6Mi7ZKHsZF+y0BrmIRwDe+1pvN4h/p4wGD6vr4siJF1tL0gNWFHXS/+v5WZdPuczGDsVICbJz5jT/XFvXfJHC7+TbM16U+4RuQlCTcBd9Rt4W+LzzDGcIe5ZHjPwHy5tn9grbD/HNTPPpqiKa+DPyHLMUcJn+8LG9ploa3GGTsZGxv/W5Z2tz6DeZ7uAv3yInBnl0DDiUJ81KfKhxIynh1QnbbBFHSzsuV3BWJL9KAe3QClSlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h5SAIXMR8oTPy/o32JQNbPM2q6ExtaEbHcFkRFG207o=; b=2l57i/gdo0jci+PD0t2ZfCvp3ojor14y4XCq5GMou76jABtkGyW319vRr1Llsx+7/Fyo4Ykqe+Eh/frp3QHOLA4xzwAB2LyNj1YdtVxP8cW+B300Zli/zMgklL0lxzzyfJt++N6DOry5rS5J9SlghmkmJuul9tDw+zK7vjErmyE= From: Wei Chen To: Julien Grall , Jan Beulich CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building Thread-Topic: [PATCH] Xen: fix EFI stub wchar_t size warning of arm32 building Thread-Index: AQHYjTNsIdi3A5iEXkONabS+bAWlKK1pUfqAgAAoDoCABCcJQA== Date: Mon, 4 Jul 2022 04:34:31 +0000 Message-ID: References: <20220701101358.954527-1-wei.chen@arm.com> <061c06ae-e45a-b18c-9c86-3387dac60820@suse.com> <6e4a4da7-23e9-a976-2fdc-a96244c536fd@xen.org> In-Reply-To: <6e4a4da7-23e9-a976-2fdc-a96244c536fd@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 72FBC9E2AF0C1D47AE047507FCFA5FAC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a804158b-68c6-4842-5716-08da5d76817d x-ms-traffictypediagnostic: PR3PR08MB5770:EE_|DBAEUR03FT026:EE_|AM9PR08MB7242:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: rrRFwHXFdQ6zEY7zUdTdJTJ/n3ocFHM0bXx8e6eNC14YndIX4ctWzW5GoWSC3RKmX53hWFbJ6FAWpbSlGRMapqfbtoc6N0xIXQESYVtkzCb6DZntIwH7aybibjcDUZ+Sv2dQ5/Hs0swkncz3hFTh8G5W6GBUBB1ihZX9OJXAWizrLQcGGYQYLID2vQV3HlyYS3PqZZqLfl93Ux5bNg7hDkT9j+uTkBXf3qtqMd2n+W1729TjdgpvnMsD2+Uis0KnOLnl2HTp6L/XHUMfbrHuOjF3fCL17n7+Z6t5m32Iy9PrsSJIocXlpQrOab1kLesSDIofCWhirwFzbTgn2SlrtR5XQ3uv6rLUOyWqMBeIajZRAHNs+nJoTZ2zqOc7L+xjvMd8BG84f7AoGOhGhO8SwcFnmt88tNmFtcZ6xIhpJYfXjCdOnw1e10DJOxJfWOdmgtTCmHkwbFEOjQmc76dhhZgx0ftRJSdhaZWO9AH/uS0nXGl1JR+IzL88p0z+poMKvWffbCk2ERNSWuv8xw7dyqEqs9xOzd4hV5OVtn5OQJu36RTYU9UVqjEcCXpTg39FU0rFFme4qHJCEqE9EkKKWWKxcKOi6enPlzqQ4Wsz2+G7SNoDMyfxc6DUD4ZQp8tAEz2EjUgKoYE2p2tJHBalp++ildFK/klBuJDpMfyv5TAiD0nmutRTcaERQN7MthNU2OG/8eZCzt9OHsK/SffL0bOz+0vkVHsT3/CySNzyE0y39BsMlPl0950SBTOeinjkEbgHsvoTbnmV3Y36Dlt/1oPeTGgF7Z/89NXUcFiBpZxaHBkFq6DUzT0KsZIc0+fa X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(366004)(136003)(376002)(186003)(38070700005)(38100700002)(55016003)(71200400001)(64756008)(4326008)(66476007)(66446008)(316002)(66946007)(76116006)(8676002)(66556008)(110136005)(83380400001)(54906003)(7696005)(9686003)(53546011)(33656002)(6506007)(5660300002)(478600001)(8936002)(52536014)(122000001)(86362001)(26005)(2906002)(41300700001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5770 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 75650954-c153-4436-119a-08da5d767d37 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qZnoeN2A32McO57MTgn7DdfrRBxvyyfiiLtshxvFVeJZYy2rIEdxhCUIvw+i7h/NQVRrD8BMIehA/VCBPNoqFAqzhLlT++kA2VU7H1e641Cn0tLeQmLXl7ASwdINP9nBCLp4EoJcDPJH4/b23VbcuLcIVZstZNKLPpRHGcf2N4EcPMd208d+PuECY+sHuIGfO2vnK+0qkWtaV3Os1m60CsCP3qmNrefaR+X9c6HDkq1kQIRNyDR1mIqxQV9OigT3SqBjYE5y8UQIuKqRv/IIH3C4TvlE6PeuUG85dFTmEGxvONSCjgI+0gpViyCP7Mq3/nekyAFINHu+5+wyrc8kb77Rca5j1hmHwIv0PkytHP0ZmhHwMp+MbyCaI4QFsjJar6rlzRdyyGEuzntbtHn4vFIsCRAxSUuhQaGTZwooO8UTvVI/XjHQ4DHY5Cy3jgbRsMiDw1MjRFN5fHD4aK0RxfYJsc0wbj8JVIdK7OuQuAiJPAmNMvSMmli3++9u4o7q1hPkudrzGCXhtDo/KAnVniH+Qr23QgwkyP+bFDmuCi1iQuUMp12QzeBCTdcQAm1eQ/iSG2oiaNUOWx4kzvWaLrK+ZdIL6lZWrfm7Ci9WWLnSeungm1laf8oPjy64Fj2vlCNGq+VOx/b11iS3BtvucsHYW+GezQz8MFJNjyAtY8WaD0KxyVCMLN0JhgTiIWJy2WPtj1EVQ5YwWdMW0s5WtCo0EQdmswRHs6783Hsu5LmsSpYs0DWftV68nXOiOwpOcDoS99sCx/uBMgk/+pIKA4RvUZqVBTMxgW1fY2w1JipgutFOhiuXjvDWKvdw1RA0V6hi863JT7PU7HV+s2RxzQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(346002)(376002)(36840700001)(46966006)(4326008)(8676002)(110136005)(54906003)(70586007)(70206006)(82740400003)(356005)(36860700001)(81166007)(82310400005)(316002)(5660300002)(478600001)(186003)(86362001)(8936002)(52536014)(41300700001)(55016003)(40480700001)(26005)(9686003)(53546011)(336012)(7696005)(33656002)(6506007)(47076005)(2906002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 04:34:38.6345 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a804158b-68c6-4842-5716-08da5d76817d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7242 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6IDIwMjLlubQ35pyIMeaXpSAyMDo1OA0K PiBUbzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgV2VpIENoZW4gPFdlaS5DaGVu QGFybS5jb20+DQo+IENjOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xv ZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+Ow0KPiB4ZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gWGVuOiBmaXggRUZJ IHN0dWIgd2NoYXJfdCBzaXplIHdhcm5pbmcgb2YgYXJtMzINCj4gYnVpbGRpbmcNCj4gDQo+IA0K PiANCj4gT24gMDEvMDcvMjAyMiAxMTozNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4+IFNpZ25l ZC1vZmYtYnk6IFdlaSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+PiAtLS0NCj4gPj4gICB4 ZW4vYXJjaC9hcm0vZWZpL01ha2VmaWxlIHwgNCArKysrDQo+ID4+ICAgMSBmaWxlIGNoYW5nZWQs IDQgaW5zZXJ0aW9ucygrKQ0KPiA+Pg0KPiA+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2Vm aS9NYWtlZmlsZSBiL3hlbi9hcmNoL2FybS9lZmkvTWFrZWZpbGUNCj4gPj4gaW5kZXggZGZmZTcy ZTU4OS4uYjA2ZmI5NmMxZiAxMDA2NDQNCj4gPj4gLS0tIGEveGVuL2FyY2gvYXJtL2VmaS9NYWtl ZmlsZQ0KPiA+PiArKysgYi94ZW4vYXJjaC9hcm0vZWZpL01ha2VmaWxlDQo+ID4+IEBAIC0xLDUg KzEsOSBAQA0KPiA+PiAgIGluY2x1ZGUgJChzcmN0cmVlKS9jb21tb24vZWZpL2VmaS1jb21tb24u bWsNCj4gPj4NCj4gPj4gK2lmZXEgKCQoQ09ORklHX0FSTV8zMikseSkNCj4gPj4gK0NGTEFHUy15 ICs9IC1mbm8tc2hvcnQtd2NoYXINCj4gPj4gK2VuZGlmDQo+ID4NCj4gPiBTaW1wbHkNCj4gPg0K PiA+IENGTEFHUy0kKENPTkZJR19BUk1fMzIpICs9IC1mbm8tc2hvcnQtd2NoYXINCj4gPg0KPiA+ ID8gQnV0LCBhcyBzdWdnZXN0ZWQsIHBlcmhhcHMgZnVydGhlcg0KPiA+DQo+ID4gJChvYmopL3N0 dWIubzogQ0ZMQUdTLSQoQ09ORklHX0FSTV8zMikgKz0gLWZuby1zaG9ydC13Y2hhcg0KPiA+DQo+ ID4gdG8gbWFrZSBzdXJlIHdlJ2Qgbm90aWNlIGFueSBvdGhlciB1c2VzIC8gaXNzdWVzIGhlcmUu IEFmdGVyIGFsbCBpdA0KPiA+IGlzIC0gYXQgbGVhc3QgaW4gdGhlb3J5IC0gcG9zc2libGUgdGhh dCBBcm0zMiB3b3VsZCBhbHNvIGdhaW4gRUZJDQo+ID4gc3VwcG9ydCwgYW5kIHRoZW4gaXQgd291 bGQgYmUgYSBwcm9ibGVtIGlmIHRoZSBvdGhlciAoInJlYWwiKSBmaWxlcw0KPiA+IHdlcmUgY29t cGlsZWQgdGhhdCB3YXkgKGFsYmVpdCBJIHRoaW5rIHRoZSBpc3N1ZSB3b3VsZCBiZSBlYXNpbHkN Cj4gPiBub3RpY2VhYmxlLCBhcyBJIGRvbid0IHRoaW5rIHRoaW5ncyB3b3VsZCBidWlsZCB0aGF0 IHdheSkuDQo+IA0KPiBJbnN0ZWFkIG9mIENPTkZJR19BUk1fMzIsIEkgd291bGQgdXNlIENPTkZJ R19BUk1fRUZJLiBTbyB0aGlzIHdvdWxkIGFsc28NCj4gd29yayBpZiB3ZSB3YW50IHRvIGRpc2Fi bGUgRUZJIG9uIGFybTY0IG9yIGVuYWJsZSBvbiBhcm0zMi4NCj4gDQoNCldlIGhhdmUgYWxyZWFk eSB1c2VkIENPTkZJR19BUk1fRUZJIHRvIGRpc3Rpbmd1aXNoIEVGSSBvYmplY3RzIGFuZA0Kc3R1 YiBvYmplY3RzIGZvciBBcm0sIHNvIG1heWJlIHdlIGp1c3QgbmVlZCB0byBhZGQNCiIkKG9iaikv c3R1Yi5vOiBDRkxBR1MteSArPSAtZm5vLXNob3J0LXdjaGFyIiB0bzoNCg0KaWZlcSAoJChDT05G SUdfQVJNX0VGSSkseSkNCi4uDQplbHNlDQouLi4NCiQob2JqKS9zdHViLm86IENGTEFHUy15ICs9 IC1mbm8tc2hvcnQtd2NoYXINCm9iai15ICs9IHN0dWIubw0KZW5kaWYNCg0KVGhhbmtzLA0KV2Vp IENoZW4NCg0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 04 06:05:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 06:05:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359741.589064 (Exim 4.92) (envelope-from ) id 1o8FCr-0005op-6y; Mon, 04 Jul 2022 06:05:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359741.589064; Mon, 04 Jul 2022 06:05:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8FCr-0005oi-4I; Mon, 04 Jul 2022 06:05:13 +0000 Received: by outflank-mailman (input) for mailman id 359741; Mon, 04 Jul 2022 06:05:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8FCp-0005oc-CC for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 06:05:11 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50043.outbound.protection.outlook.com [40.107.5.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41c95537-fb5f-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 08:05:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB2910.eurprd04.prod.outlook.com (2603:10a6:800:b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 06:05:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 06:05:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41c95537-fb5f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gUlCiR32fQw8dv+bdv8bVF5w9d+1grJNZWHut28eApfOO/1+eCojPQmoIH1nWQReL2ahhqPFXkv2yBq7Ob26tkmqTIcq/JCAcNyj0qiOp/RzI/as/qV5418//VJAGyiXFU41FxSnj3I3Zn6hWwSqSqhQ1aJGsV3Owo5a+N8tMDIdIpkMeMscTwl/FXKZTn64iH24GwnGLYqGnSqXZtMKEpYViusmVvF2gn7r6pCCXcujn5XMAfzVodm5hHpokdUT6SaeAdzb1pt6G7Iw0t1dSzzR2CDYfMwJCfMEZuWts/pIjyLJFlio2koBhNhLDqJwbbFgPQ9loGaTOSd6TC98Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V+4b50n6O1Uybgj13S/964ltpSyYgtDOEKfEbuOghrY=; b=KWRw4QBPmaaeNgbvoqWos4R5BGBL4Lyoo41UsBUR2dSscYd1qYT5r+CpOWbnxvzU6pdDnnjaPJQ2AQOfYjMIz3Z23C+VODybKjzYI/uhJw6XraCgsCHNWrUi/EEV+f9mQZx6pW7dY0efudrPS+hEW0v5cion2SCKWzXE3KdoWB6gG8hvve2vGBos6N6xQQuAl6t12jX+d7f4/xGqxPzuO2YjqV8GGd2swc6OtYfeFRvAUhd/tZxXK8+eKX6ZmPivjSMzi+l7nl6nNyoqBhqy+iMiCIyemI9O5ZzPDMtRQ5B5LZM+i6ygqWyPYKNvs4S3WCRnhCjRgCrYm04o8+j0Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V+4b50n6O1Uybgj13S/964ltpSyYgtDOEKfEbuOghrY=; b=PzBe0yl5ZJHyZLphrrnfy0ORwwaeu7UpFJHoKK28CZYZs1c+XEC+R1EEAb+Mw+78mIvYyWk3sLAU0NQ89kHRTD6XzwhgJoyfHQMz8b2RNmqszKjZhUFqftSN1Pwe+mH1+kh+YAlwRhatg8ffWFqt9zbk5hpOfVlKevmjfdzWRI0VhEnj1jgxUO1T27GADX5tjrCB7d2e6MhlUqBUWmsDeuMHLK/IjzgoF7YM2dq5HbqbxS4jPth3n/OI50XGdYyL721q7u7nv8dYEaA2Mvd8Y8KFJm5lzQjHU9DnvrK1lOhAIABQsF1xz47VC/K2An4b9PYykhpn4AWtbS7L8gPzHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 4 Jul 2022 08:05:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Connor Davis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org References: <87c73737fe8ec6d9fe31c844b72b6c979b90c25d.1654612169.git-series.marmarek@invisiblethingslab.com> <9c7c11f5-be1e-f0ef-0659-48026675ec1a@suse.com> <8322303f-021a-b520-d2ad-cf8310573df5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0016.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf09292c-26b7-401d-b817-08da5d8324c5 X-MS-TrafficTypeDiagnostic: VI1PR0402MB2910:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kxh5popoyXqYLuoH293PIZdsOCall+YPKoLIDdZl4h8xbWxxVsZT2mw7nNdj4/GC8Tc7XAPUB4qevywxAXYpRGP6p8hee446mnmZy2263LTuJ88MT6FppX0HVufdq2znQp2lWIvAARQMz2/qo8Yjz0hP8CKfB3E9EWOPwBtBaKQ+o/BAhdQ62kWKHrgGoGgNXElxiKDbNIwY1/OwX8rBDY8d3GgPoFSATQPZJfHM5WDj5hwpUuJ5CUKK56vBxHCqgZmY7I/V+Xg2DPf8EYwAHo4rmEkKvTFZ+X0jjV40V9SbVAWlb0h37zS6MNKChjODXVSaGGl0iYsWqFRNKxYDdZXfYVFPrqzHwOy8r73L8W+nZMcNZhTlqniW6oqs/JeaUnWN9gCETb8TGsQL9WTlrevB5qoDl0dOa2vB5s08Hj1RdKf+ACVBNYK2JXzVqk25K/QYe5H8Vsibn8gAPwwtR9lbIpWMu3wAhzGisaWv3s/UbUau5reHiHh4spmdLnnb4Yh3peNewmcXgLjZN3ujLoqnqH6ZKKY1148eDbw0jpkbZttSUFO+oqZUZaKVNNQrKJ+6n4A7jTHRtpQgMCcpai7k7hJw1a1B6kswwoBNK8cI0LDkelWXRpOqrR/lAHHppEu7/KKSA7jrKW2emydHNmIH/0isjjlQJK4Oxbu/ue1aG/3YSsKt0f9DJAqkdxxt4sh6qu8XKXGK6uR9r1+mmFmKpbrtIoQGUUXhUghCt45eRSpe/cKLr2r13WQtQGakx1nV5DB577sVYbAM5ONMOsa+ViOEyuTQJh8aDpfeBUlNOerq6RkEAH8gYGYadfPTDrY2Be35iHzgzcjKoPYX36oRvR+ORSL1wmxiC+hPb+M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(136003)(366004)(39850400004)(26005)(7416002)(53546011)(5660300002)(316002)(6916009)(54906003)(6512007)(41300700001)(86362001)(31696002)(6506007)(8936002)(478600001)(6486002)(66946007)(4326008)(8676002)(66476007)(66556008)(66574015)(186003)(83380400001)(36756003)(38100700002)(2906002)(31686004)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjhkVm50UnJxeGdscS9RY09kZ2JrMXdIMW4xeTR4T2pBdVFRUHZuS1JxUGVS?= =?utf-8?B?ODZjZ3laSFUwclFiU2lSdjBVd2xyRWYzTW1GRit0RU5oQzVUTkhkRjA0eG1t?= =?utf-8?B?azI5TFAwSzUrSWdWYU9Edk9sOVBVeDJSRCtvMWd0SWozWVBoWGRCeDBxZ3FS?= =?utf-8?B?NUpJeHBDaTdxWGtwelZvNUVGTCtGb2xKUC9scm5nWHFIMnBPU1BiU1NLZFdx?= =?utf-8?B?anV1Z2JlZjhDME81dkpWK0x0THVzaXdRaTdvK0dqOFpjYXBDck1vRS9OU2Jj?= =?utf-8?B?ZDBhTjM4SEE4SUQ3YzdXTUs3UEN6MnB6eVBaVlRvS2RrZEtCNkJEaHk3Slpa?= =?utf-8?B?TzJQakFmbGxwR084Z0NhemRsS0VwM2hZMTZqSTRWLzVBOTFRbVZ1SHJTTVJX?= =?utf-8?B?elhia0pxcHFmK0xUQ3AxMUQ0Nmt4NURyL2ZxaGc2YmxCb3VHMVVoUnd1bVhy?= =?utf-8?B?MDRWSDZxZEY2REN1cENueDgwY1pJc0FranpEbHRTOSs4OTVzV1ZNTXlodlR0?= =?utf-8?B?NEN2TEVlUXdqSDdvSWNmQi9vTU85T0p1TitLNEIzb0thdkJqOTc1QkVGWUtk?= =?utf-8?B?NXN0N21temY4Vzd4b1RLbkxpaXhEc0JTaFRPdFh1MnRZK0VoajZuaFYySzF4?= =?utf-8?B?eDQxNUVRQ2s2cC9MS0JTZ2JoRFBITnhCZ0lyQndBWGRlbDlYSS8remlyK0NV?= =?utf-8?B?a05KSklUTS8xZk1lZit2MDlxMldEK25kNllDU3R0RVROUkxmaXRKRTh2YnY0?= =?utf-8?B?Y0hBQ1pwSkprNjIrdjFGeHpMWDAvcHlJREhZcFFJWm1IOGtzSVRIMG5EcG4z?= =?utf-8?B?ZmRqajVUMTN5eFAwem1SVWIzNHFPOXgzYzRqcUpFNDJvRzhiWHFGM0NBczNK?= =?utf-8?B?ZFVueTQ1enh5YWc2YmpiMjVJQm1XUUtuQU14VUthR3BOVFoyR1Bua3BtYjVZ?= =?utf-8?B?YXlqcWpYc2VpUGw1VGtrTTY1RmhEK3BnTlRBT053MDFhQ3hKYWxQUm9tOTlL?= =?utf-8?B?eFNtVWRiMCtFN1NzVkJUS1dvTG1MTUVnbXNPZXZxcnVJeWZIdEQzbm00VDZP?= =?utf-8?B?bmdJeDBEWk5EWFJ1SE9QMndGT0FZTHhMdytZa1VreVBBS2E2cU9lOHJESHh5?= =?utf-8?B?alpoR2luc2pNWGlCU1d1am5VL0JhdWVyWkpZZzF3OEd5SnI3TFlsODZvSVhG?= =?utf-8?B?MDNLNk9Rb25ENXhtdU81a3FJbDF5R1pZWjJXNS96QzdHSHJxRHB2bERLaFFo?= =?utf-8?B?L2RSR1lWTlNKTlp1YS80MFFlSEN1OUlIOG95MmcyQTZmbERoWGpNYjZYSzNj?= =?utf-8?B?YXJzZDkxclpyZzh1U2Z3RE1oMkhrelV6WDFmYXE5dmlXdk1JQXNzeVMzQzlO?= =?utf-8?B?QjNjTVpJVHZkWG9jREdjMWNNclZFc0hKa3JaZDlzUlVzZzluUGVuU2h6OGR5?= =?utf-8?B?bk5HN0hJODQ5eVJxTGlFU2EvYlVzOHVFb1MvUTNCMFQ5Mk1NMkEvK0tGYUVJ?= =?utf-8?B?SDNaMFErQiswNldXUTgxVm91WTg1OXJ6MVlUNGZvMEt6clp0UG1vRUw0ZzI3?= =?utf-8?B?dmtpWlZsekF0eXozQkNRcGsyd1dnTDU1cEN3TmFIcVlXMDlqbEVKTnIxWG5z?= =?utf-8?B?UW02VGtWMkNlRlYvSmlJbzM5OVFqN2h2VzFuNHd4dlpkaktVTll0ODhGQml6?= =?utf-8?B?a3ZjNUk0QU9UT2pFL01KTS9PTTdjNGcrVE84RC9lL0FIVmRub3hZNGNVd3ds?= =?utf-8?B?RFQzeVdoT1lzVnQxVS9rbWJaWDZjYmRKS3F1WkRuSVorS2hYTmpJVVZsT1hi?= =?utf-8?B?bjU1bDUvZDNIZWk1SjF4bEJmVXkweXZ6VVdWT1hoOFVzTHRuVlVBTjY2bHo0?= =?utf-8?B?M2tyZm45MERlV0M5VHk4YkN4MGNteGx3MG9OcjB3NFcvZUVTNXgycHhCTU5n?= =?utf-8?B?VTZNOVkxZldBTm44NVZBTXliL2p2bEJQZzVmSGRWMGhUU28yeDRJdEU3Y3Jk?= =?utf-8?B?eG5oSnpKcWxPK2JaZGZaZXBKZS9aVWRLYW4rZi95UEsxa0RmK3ZxMGEwMmda?= =?utf-8?B?SGVNUUNET01jRkpwa0FIMGg2ZXR1VWpTbm8rOUN2SmRoWFd3ekNUL05BQXNO?= =?utf-8?Q?kYupDKY8HlVl/JCQxiI+gNW5e?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf09292c-26b7-401d-b817-08da5d8324c5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 06:05:06.6789 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: z42Caw+32cmhJ1VbcYjZVxeewEnQyiHNDoRt3BH+OK8kmJ3ONxMk30lYH8/UPhnqVONmlJ51FYanaQ3fSgvgQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2910 On 03.07.2022 14:17, Marek Marczykowski-Górecki wrote: > On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: >> On 22.06.2022 17:47, Marek Marczykowski-Górecki wrote: >>> On Wed, Jun 15, 2022 at 04:25:54PM +0200, Jan Beulich wrote: >>>> On 07.06.2022 16:30, Marek Marczykowski-Górecki wrote: >>>>> + memset(xue, 0, sizeof(*xue)); >>>>> + >>>>> + xue->dbc_ctx = &ctx; >>>>> + xue->dbc_erst = &erst; >>>>> + xue->dbc_ering.trb = evt_trb; >>>>> + xue->dbc_oring.trb = out_trb; >>>>> + xue->dbc_iring.trb = in_trb; >>>>> + xue->dbc_owork.buf = wrk_buf; >>>>> + xue->dbc_str = str_buf; >>>> >>>> Especially the page-sized entities want allocating dynamically here, as >>>> they won't be needed without the command line option requesting the use >>>> of this driver. >>> >>> Are you okay with changing this only in patch 9, where I restructure those >>> buffers anyway? >> >> I'm afraid I'll need to make it to patch 9 to answer this question. If >> suitable dealt with later, I don't see a fundamental problem, as long >> as it's clear then that I will request that this patch be committed in >> a batch with that later one, not in isolation. > > This turns out to be rather problematic. xue_uart_init() is called > really early (as it should, to get console as early as possible). It's > before even boot allocator is functioning, so I can't use alloc_boot_pages(). > Are there any other options for memory allocations at this point? No "neat" ones. Stealing directly from E820 could be an option, but would of course be heavily x86-centric. > We are talking about 58 pages. It isn't much, but isn't exactly nothing > either. Maybe there is way to keep the memory allocated statically as it > is now, but return it to the allocator is xue is _not_ enabled? Well, yes, treating them like .init.data would seem to be the least bad alternative then, at least for now. Down the road we may want to generalize what's needed here, as there are other full-page or larger memory areas which are used only under certain conditions. We may e.g. want to introduce an approach similar to Linux'es .brk section (recently renamed to .brk..bss iirc). If a non-generalized approach ends up looking too ugly, I'd be okay with keeping things as they're now, just with a respective justification added to the patch description. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 06:15:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 06:15:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359748.589076 (Exim 4.92) (envelope-from ) id 1o8FMe-0007PS-4Z; Mon, 04 Jul 2022 06:15:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359748.589076; Mon, 04 Jul 2022 06:15:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8FMe-0007PL-1z; Mon, 04 Jul 2022 06:15:20 +0000 Received: by outflank-mailman (input) for mailman id 359748; Mon, 04 Jul 2022 06:15:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8FMd-0007PF-Fj for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 06:15:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80083.outbound.protection.outlook.com [40.107.8.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac7adf2f-fb60-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 08:15:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6694.eurprd04.prod.outlook.com (2603:10a6:20b:ff::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 06:15:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 06:15:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac7adf2f-fb60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQsTCmDeWck8lD+b0rtFdXfpGNMKZiY3cN915l/BF91PBSnWMuQ4W634Yvkb8G8SHT5iIpevOgbhxEEqn5akrpMKTxVNxhBRBfJd7DB6GUjc0QUSj+TdHT8uk9jVr6t88sg0SXO8jAWY5+HBEqF29TgkxWn8NqJXHVL4/lzzZYkTp2AWzaz9DVxeRvlrJc2+ZOy2K8NVfl470hsid7Hwg7zhKMWzYj+KLd3zaJdQMoYSyyUoNcvK3+TnI0CnDoPfovFdI2gnkrH4Yc0D1gsdTUE1HcLjD3wlG4euVzFdIm6qqTunK/IqTMkpEHskeCAhwQN+TgW79SoPKWKJ7qUIyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PK4br+Nr/bcZxNQjDktySlxVYRv6TZPLiwPmkS+4WZg=; b=bGvgxjR4x+ocK+SEYXxRXkTSQmAp0+ZWu1wzYfWY9BReBuGtEOVDKDO2AgeI+uNjZk69IhbEaN4KbXewBLqLBTu14njQKGC0BlQ+8dTondSTfYvZHlrxny7fPmub299rcW8X0vJVRDMsToAmEWrI8OEN3VVczLZo8hatKwu1hWHdC54IbYKQPGI8R1rWyntY2KUwZCGfldawk97Ps5HdbOjNsKegaIFWIesBkcbpvPHP23shv7Z4PjERFEwJ/C7IWHmxj6cxTa4p6EXWxAtXOgVkrnHNHOWQlMyrU6d2OfMzNO0g782z8HF37nnPUxwgsRXsVIqoPgGfNyb//Ra/gw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PK4br+Nr/bcZxNQjDktySlxVYRv6TZPLiwPmkS+4WZg=; b=5p/7JlerZPjXHMAaKbqmfAO2O21IVHXXsitcESuji90NmIxJxni4XvTGI7Od/MV4/UXg+XA0B5bjkI58NslwfoNO9Ms/XjLJCT5CtM87XpwZcwtNq8jKwvmHMay4MtIotMmfWyChHsooAwnqaIalbYTZkx856zs+mLDT8Qy7JB7ayL2cByd5O9zzoz1So1Ark0C19SaUW4CcWbloIYCTaMvdWRBUFKsoZWneA0qS1dF7EBSzdJ4nrYyAIX1ZGirxpJuiRHNcJP0J5Mkzz3y9J1olBCku/X6UocCuceSxeunBJAjg+1WvdTG9OTBvOvFQYCQofm3WluZ+yBf8VdE7sg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9db996bc-cdeb-37ce-9e98-ca199d42a494@suse.com> Date: Mon, 4 Jul 2022 08:15:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-3-roger.pau@citrix.com> <4a193fd4-deb3-12c3-2faf-eed33e7b52af@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0080.eurprd04.prod.outlook.com (2603:10a6:20b:313::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ceff67a-dde2-4fb4-97d9-08da5d848fb6 X-MS-TrafficTypeDiagnostic: AM6PR04MB6694:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0EniuIiOJfJBxOCzLDym4Z+IRn+vtOF2d+onzJQfo2ZTejNcVlZcdSyVS4QpPUDd2zOE/KPCHePoBcEPevvc46sZ7w8za/8HRAsYrJgE8OfciQ2VuOQeO6vYTvDlJkTbTRfGkQC3smyWGuasvDmolfDR+4wKF90+3s01JGlb+77j/GDFJH+ZHDLgQqUWzyqPbbP7UV8J0O7ygPqlbYPpt74NsXYpXGgybsOGJ4xGkPDIwnpjBoAYSN+lBaOam+uJVbKLEM5v4fsEWghf27WBpSoBzXPvA3b2CCSqvwkSTwWVqnBm2kug/7+L/yutsDYrYcRKAYyKWqN10zAJiVVa/Tst3vxy58g8SroSsxrQCO9J220m94H21k+7wZkcj7Hz7DedrqTwr2dyKLWoebqCnIFENTG8cVamDItfCuNQv6su2T5ewq3SigOoCEkD/tPqsDPTeQvb3pwVeLGN7nXJTHTBsdvfGvwRhJqS1g1PFHIR95DFx/zPWUhgXCZSTI2x/33om2r0qrDcaDSkoYc3/GRjyDiUO8R+Qs/mVqDetTGVW12+IcVIVYJQ+SXxpa3F5PwenwxrB1YwdRr6XvHuVe2VregxTEvGfTlLRx4RXr4knV7c6y1HGyKndukahiVehxHKrqvwb0qtWB1NGiq9+A5It4ZIVGvYClAiaw/0+2FKCBc2KUyv2XfepMUzf7t3l8oxXBm/seHqXEbGPGB7dheBqTiiDUWosniweLfcqw/ThzkprhrvLDyt7iT6O7bJs6v8LbQW+2lyob4J7LPEZq3WBMIiXOI5ERirxYosnioCBGA05J0acL4SvEBnfWtY2Ac+PMqSBo/2471U8BUFXlQnQ3WzcHqjHG0QqwnwoNI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(366004)(136003)(396003)(39860400002)(6506007)(53546011)(8936002)(5660300002)(6486002)(478600001)(2906002)(83380400001)(316002)(186003)(86362001)(36756003)(31686004)(2616005)(54906003)(41300700001)(6916009)(38100700002)(26005)(6512007)(31696002)(66476007)(66556008)(66946007)(8676002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjBTZzZZbW0rRS9HbDgvMGkvMjBqcVdQTUQzUzdKcXRmdG1ScSt5WW9DUmxD?= =?utf-8?B?OUpsU3NHQnRhZzJnMEZSWFphODg2MzY5VDdmaUdTRlNLTVNveXlKelFscnIr?= =?utf-8?B?NStndnpnS1hUZUhaeWZ0LzhrekRpbjhVTFlrRExRRThsbXhydzk3Q1o3WmE3?= =?utf-8?B?eWFJUDFUWDhqZ1lKVTQ5TVVzNHpBUGxieGYzR1JsL1M1WEVEOEN0a1didzYy?= =?utf-8?B?UEdMdFhabDg4clRBVVZxczIzSHBnQ0VSRys4MWg0REw4d3NjcGF5U3FFVmFz?= =?utf-8?B?R3Vqc3hTOW9MaDhYRnpVT1RxQmdvaGhJb0pyMkZ1TmNnbnNXK1ZoYUtwOGEy?= =?utf-8?B?TEJuNnN5cWtrbXJ4UWxPZEhmT201aXZ3MzFJRkJJUlZHNjM3eXNEbW03dXov?= =?utf-8?B?MFRzR21uR01zbGFFY0FpOUNlY1ZtYjNoaVdQSWlGZ0ZJSFROZWVING9jVXhC?= =?utf-8?B?SUN4bVRMUWdWNktVSGlPUzZENHRsWmZ1UjN3OUhESmVKNS8ydUFFblljdHl6?= =?utf-8?B?bDdNV0w1UEczY2ZXMFhnUDFMYzFRS1luZlEzOWxwcWNvL1FkZjFVbjVoS2lv?= =?utf-8?B?TUU4dVVyQ2t3SHNPQzY4MDYrNTVKRkQwbGxiQ2xIQUJUdEk0RzdKRUNRemcr?= =?utf-8?B?VzZudmJ0ZlpFamM0QlYvSVpGZHhrZ1UyTjRreDl1bVdBZlJhdXRNb2IyTHps?= =?utf-8?B?TnJpMEM0aGhxYzhQYTV5VEJBOVV5K0h5T3gwd2VPZmN0Uk1lYUNFTjRYdHE0?= =?utf-8?B?eGFOM0dIT1pKcTdHb3FhNkFJL2Y5Q1dmSFlWblRPaUxpeU83c2VndHNIbXpj?= =?utf-8?B?dVRkR0dJRlRlWEJCZkxRckRmRm5VOW9aTHlDMWU3WEo5SW1qdnl4NWtNM1R5?= =?utf-8?B?Z1hZUEU0U3M5RGdNek91am9RZjcyWjQ0anh1R3lVYTdsRDVscEJGc3NtRFM0?= =?utf-8?B?M0M0OFcxRTM1V011ZUs1Yzd1NDVweE5qb0FTak1ra1VLOHQxaFM3UjNxaUYy?= =?utf-8?B?NGsyZElkaGZsUzZ6UjFaWE9HLzYvamVxZll0Nlg5Ni9NbkRoeUZyWkdLV1hO?= =?utf-8?B?WWtVN3JtbkhuMXhjYTEzMlZJSHFmYVpRZ2w0UEIwNmV3UjdWMnRSYkx0dG1s?= =?utf-8?B?TU8yZFdmeXc4OFE4eEpMR1Fsa2d4WlhCYzdrRlhWdlVWMmp4aCtHckhrREV5?= =?utf-8?B?QWN2OWpBQVRPbUU4UU9ORERtVkNkbTg4QTQyb1g5WWhPU3REN0NhRC9hYjh2?= =?utf-8?B?alpra3RDZVlNUGlzeW4wYXl0M012bmZtc3RmL2l2dlBCYyt2Ulc0Y0tXb1BV?= =?utf-8?B?QmFYOUI2WUhYY1ZQTDRpQ1NYUWJPeWZZS1RPOXZSaHQycTVMUkc2TkYzMWZn?= =?utf-8?B?ekkvVVRFY2VIb2xPM2NEeFh0ZUl2eUVkdmEveXcrWjNRU3pYSUhkelBTT2s0?= =?utf-8?B?akxRRWx4VjZ3bmpobzZRUDJHalJlcjNCUFBWa2MvUHJaRG5CNUVjb3Z3L3BU?= =?utf-8?B?UExLSjRtVlQwRW51NEdNMTFDcHNINHViYWdwdnAvenM1YVhJZnRyYlpSOVh0?= =?utf-8?B?WDBFN0lRSkwyc2hYamMzTG5MUmRGUE5BcW83RTJsbEwxVUc2TW92eVViRlF1?= =?utf-8?B?a1JxdWd2dVM5TWJ0YXJVdyt2TW1GWEV4c3pvdzVWaUxZRi9rLytIdWN4eTRm?= =?utf-8?B?dkhDbUJXQkF6SCtmL1MwdFBFUlZSdUlFWjFuRW1IeVY4Q1RPSEFLWmE2L2hZ?= =?utf-8?B?cjlNNm9BRW05ZG1iVFR3akdDY3Z3Y1Z1VlRqenVta0M2M3o1T2NLaHN3TUdF?= =?utf-8?B?VHdxdWNTZC80aDFmcXlLK01RY3hVdkNpSy9nWmZYQnA5bDQ1L1NEU00zb2R6?= =?utf-8?B?Y3BrdnN2MlFPOStmMXRpZ0R1RFJabUtVbFB3eENQRUIyK09uaGJnK0RBOEtr?= =?utf-8?B?dUlSYU91RnJMOXdZU1RUM2xmWTdGcW9TMjN4Q2pPbDhHRTR4R1ZGcXNrRXIx?= =?utf-8?B?WlRyajRmYk1iUjJEVUtpS2RpWHJxQnhJS0YrK0VmR1VGYVE4Y2JjUUd1R01z?= =?utf-8?B?cFVudEdKNWhXZFVSUlJKdFl2ckgrazB2Nk8rRWtjRlgvRUd6aFQrMlFLWDhw?= =?utf-8?Q?ZZQqOcjm3kC895M5JWbGuRtqG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ceff67a-dde2-4fb4-97d9-08da5d848fb6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 06:15:15.5927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: au4Xj6v4JZlqrNSWgiXFMdo97c56hFj+ombiW0vqj+k6P1X8am0oA5Y2cn6vF45L2YilnPkr78cjupCDoBErpw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6694 On 01.07.2022 17:39, Roger Pau Monné wrote: > On Mon, May 30, 2022 at 05:31:18PM +0200, Jan Beulich wrote: >> On 20.05.2022 15:37, Roger Pau Monne wrote: >>> --- a/xen/arch/x86/include/asm/msr-index.h >>> +++ b/xen/arch/x86/include/asm/msr-index.h >>> @@ -139,6 +139,24 @@ >>> #define PASID_PASID_MASK 0x000fffff >>> #define PASID_VALID (_AC(1, ULL) << 31) >>> >>> +#define MSR_ARCH_LBR_CTL 0x000014ce >>> +#define ARCH_LBR_CTL_LBREN (_AC(1, ULL) << 0) >>> +#define ARCH_LBR_CTL_OS (_AC(1, ULL) << 1) >> >> Bits 2 and 3 also have meaning (USR and CALL_STACK) according to >> ISE version 44. If it was intentional that you omitted those >> (perhaps you intended to add only the bits you actually use right >> away), it would have been nice if you said so in the description. > > Yes, I've only added the bits used. I could add all if that's better. Personally I'd slightly prefer if you added all. But if you don't, which is also okay, please make this explicit in the description. >>> --- a/xen/arch/x86/traps.c >>> +++ b/xen/arch/x86/traps.c >>> @@ -1963,6 +1963,29 @@ void do_device_not_available(struct cpu_user_regs *regs) >>> #endif >>> } >>> >>> +static bool enable_lbr(void) >>> +{ >>> + uint64_t debugctl; >>> + >>> + wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); >>> + rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl); >>> + if ( !(debugctl & IA32_DEBUGCTLMSR_LBR) ) >>> + { >>> + /* >>> + * CPUs with no model-specific LBRs always return DEBUGCTLMSR.LBR >>> + * == 0, attempt to set arch LBR if available. >>> + */ >>> + if ( !boot_cpu_has(X86_FEATURE_ARCH_LBR) ) >>> + return false; >>> + >>> + /* Note that LASTINT{FROMIP,TOIP} matches LER_{FROM_IP,TO_IP} */ >>> + wrmsrl(MSR_ARCH_LBR_CTL, ARCH_LBR_CTL_LBREN | ARCH_LBR_CTL_OS | >>> + ARCH_LBR_CTL_RECORD_ALL); >>> + } >>> + >>> + return true; >>> +} >> >> Would it make sense to try architectural LBRs first? > > I didn't want to change behavior for existing platforms that have > both architectural and model specific LBRs. Are there such platforms? While it may not be said explicitly, so far I took it that the LBR format indicator being 0x3f was connected to arch LBR being available. >> As there's no good place to ask the VMX-related question, it needs to >> go here: Aiui with this patch in place VMX guests will be run with >> Xen's choice of LBR_CTL. That's different from DebugCtl, which - being >> part of the VMCS - would be loaded by the CPU. Such a difference, if >> intended, would imo again want pointing out in the description. > > LBR_CTL will only be set by Xen when the CPU only supports > architectural LBRs (no model specific LBR support at all), and in that > case LBR support won't be exposed to guests, as the ARCH_LBR CPUID is > not exposed, neither are guests allowed access to ARCH_LBR_CTL. > > Note that in such scenario also setting DebugCtl.LBR has not effect, as > there's no model specific LBR support, and the hardware will just > ignore the bit. Also none of the LBR MSRs are exposed to guests > either. My question wasn't about guest support, but about us (perhaps mistakenly) running guest code with the Xen setting in place. It cannot be excluded that running with LBR enabled has a performance impact, after all. > I can try to clarify all the above in the commit message. Thanks. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 06:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 06:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359804.589092 (Exim 4.92) (envelope-from ) id 1o8Fid-0001qX-Lc; Mon, 04 Jul 2022 06:38:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359804.589092; Mon, 04 Jul 2022 06:38:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Fid-0001pz-Hx; Mon, 04 Jul 2022 06:38:03 +0000 Received: by outflank-mailman (input) for mailman id 359804; Mon, 04 Jul 2022 06:38:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Fic-0001kK-5g for xen-devel@lists.xen.org; Mon, 04 Jul 2022 06:38:02 +0000 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d739d5c3-fb63-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 08:37:59 +0200 (CEST) Received: by mail-ej1-f51.google.com with SMTP id g26so14961212ejb.5; Sun, 03 Jul 2022 23:37:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d739d5c3-fb63-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=iYZl4R3hj1/kOzoGUfDETMzA8xu2/bZIMDei7qwJjkA=; b=UtHrOCyud2do3FdvTIx/m8xhl6us4BHWfJ5gv4uiUF9gf2UnEAp44TNb05LTaA+uMe JjS2oqCyYP0O7/nNkQB/+M26Udrk+CV8aRcAXeN8xHdXV2FsKbH39paIBnl/W2HKm2vj 8/pVR9hr8gHSHUS+m0ams8cM59+v74hWr2umKfht8lhALDzuPxrKmCReU9iV6lWT+vGE 0uZxmk9BXqliGCu31sdm+LKgU7mLMj+WhpfzzqvCtpWGbodMhmqbdHjIZIQt1pK7dIRw 0r6smnAb+EAIfq0YhdfSef2CgQrx7QMgCET9p0AvRHzic9L+xoxW8B8PdixZyJpKJ8Kb mNfA== X-Gm-Message-State: AJIora/Q8qAc+6+bFSzUYo2XMcnQoHo+PIOWalnysajjjUr5Ny24rqW5 OilxmsHD45wlCbDu1AaI/olgbJ7WlO6r2toEE7jYLBouYGo= X-Google-Smtp-Source: AGRyM1sZKxuXarhXANsTp/C/R6AM2h2yyxr1HOpIeX3JXp3zCGGd7zsmpZX0oJl0g4QV7CUYC+wJr4OoHsCK3dQM4co= X-Received: by 2002:a17:906:9b8a:b0:722:e50e:2a6d with SMTP id dd10-20020a1709069b8a00b00722e50e2a6dmr27840297ejc.724.1656916676647; Sun, 03 Jul 2022 23:37:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 14:37:44 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: xen-users , xen-devel Content-Type: multipart/mixed; boundary="000000000000ef66cb05e2f4f988" --000000000000ef66cb05e2f4f988 Content-Type: text/plain; charset="UTF-8" Update some findings with extra triage effort... Detailed log could be found in the attachments. 1. Confirm stock Debian 11.2 kernel (5.10) shares the same syndrome.. 2. With loglvl=all, it reveals why the mapping failure happens, looks like it comes from some duplicated mapping.. (XEN) memory_map:add: dom1 gfn=f3074 mfn=a2610 nr=2 (XEN) memory_map:add: dom1 gfn=f3077 mfn=a2615 nr=1 (XEN) memory_map:add: dom1 gfn=f3078 mfn=a2616 nr=1 <===========Here (XEN) ioport_map:add: dom1 gport=c140 mport=4060 nr=20 (XEN) ioport_map:add: dom1 gport=c170 mport=4090 nr=8 (XEN) ioport_map:add: dom1 gport=c178 mport=4080 nr=4 (XEN) memory_map:add: dom1 gfn=f3070 mfn=a2500 nr=2 (XEN) memory_map:add: dom1 gfn=f3073 mfn=a2503 nr=1 (XEN) memory_map:add: dom1 gfn=f3078 mfn=a2504 nr=1 <===========Here (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted (XEN) domain_crash called from p2m.c:1301 (XEN) Domain 1 reported crashed by domain 0 on cpu#2: (XEN) memory_map:fail: dom1 gfn=f3078 mfn=a2504 nr=1 ret:-1 (XEN) memory_map:remove: dom1 gfn=f3078 mfn=a2504 nr=1 3. Recompiled kernel with DEBUG enabled for xen_pciback driver and play with xl pci-assignable-XXX with it 3.1 It's confirmed that the DPC / AER error log happens only when xen_pciback attempts to seize && release the device 3.1.1 It only happens on each of the first add / remove operations. 3.2 There is still a 'MSI-X preparation failed' message later-on, but otherwise it appears to be successful to add / remove the device after the 1st attempt. 3.3 Not necessarily related, but the DPC / AER log looks similar to this report [1] [1]: https://patchwork.kernel.org/project/linux-pci/patch/20220127025418.1989642-1-kai.heng.feng@canonical.com/#24713767 PS: Attempting to fix the line-wrapping issue below... Have no idea what happened about the formatting.... On Sun, Jul 3, 2022 at 1:43 AM G.R. wrote: > > Hi everybody, > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > So far I have no idea if the problem is with this specific SSD or with > the CPU + motherboard combination or the SW stack. > Looking for some suggestions on troubleshooting. > > List of build info: > CPU+motherboard: E-2146G + Gigabyte C246N-WU2 > XEN version: 4.14.3 > Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) > The SN570 SSD sits here in the PCI tree: > +-1d.0-[05]----00.0 Sandisk Corp Device 501a > > Syndromes observed: > With ASPM enabled, pciback has problem seizing the device. > > Jul 2 00:36:54 gaia kernel: [ 1.648270] pciback 0000:05:00.0: xen_pciback: seizing device > ... > Jul 2 00:36:54 gaia kernel: [ 1.768646] pcieport 0000:00:1d.0: AER: enabled with IRQ 150 > Jul 2 00:36:54 gaia kernel: [ 1.768716] pcieport 0000:00:1d.0: DPC: enabled with IRQ 150 > Jul 2 00:36:54 gaia kernel: [ 1.768717] pcieport 0000:00:1d.0: DPC: error containment capabilities: Int Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log 4, DL_ActiveErr+ > ... > Jul 2 00:36:54 gaia kernel: [ 1.770039] xen: registering gsi 16 triggering 0 polarity 1 > Jul 2 00:36:54 gaia kernel: [ 1.770041] Already setup the GSI :16 > Jul 2 00:36:54 gaia kernel: [ 1.770314] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f11 source:0x0000 > Jul 2 00:36:54 gaia kernel: [ 1.770315] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected > Jul 2 00:36:54 gaia kernel: [ 1.770320] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver ID) > Jul 2 00:36:54 gaia kernel: [ 1.770371] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=00200000/00010000 > Jul 2 00:36:54 gaia kernel: [ 1.770413] pcieport 0000:00:1d.0: [21] ACSViol (First) > Jul 2 00:36:54 gaia kernel: [ 1.770466] pciback 0000:05:00.0: xen_pciback: device is not found/assigned > Jul 2 00:36:54 gaia kernel: [ 1.920195] pciback 0000:05:00.0: xen_pciback: device is not found/assigned > Jul 2 00:36:54 gaia kernel: [ 1.920260] pcieport 0000:00:1d.0: AER: device recovery successful > Jul 2 00:36:54 gaia kernel: [ 1.920263] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f01 source:0x0000 > Jul 2 00:36:54 gaia kernel: [ 1.920264] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected > Jul 2 00:36:54 gaia kernel: [ 1.920267] pciback 0000:05:00.0: xen_pciback: device is not found/assigned > Jul 2 00:36:54 gaia kernel: [ 1.938406] xen: registering gsi 16 triggering 0 polarity 1 > Jul 2 00:36:54 gaia kernel: [ 1.938408] Already setup the GSI :16 > Jul 2 00:36:54 gaia kernel: [ 1.938666] xen_pciback: backend is vpci > ... > Jul 2 00:43:48 gaia kernel: [ 420.231955] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f01 source:0x0000 > Jul 2 00:43:48 gaia kernel: [ 420.231961] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected > Jul 2 00:43:48 gaia kernel: [ 420.231993] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Requester ID) > Jul 2 00:43:48 gaia kernel: [ 420.235775] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=00100000/00010000 > Jul 2 00:43:48 gaia kernel: [ 420.235779] pcieport 0000:00:1d.0: [20] UnsupReq (First) > Jul 2 00:43:48 gaia kernel: [ 420.235783] pcieport 0000:00:1d.0: AER: TLP Header: 34000000 05000010 00000000 88458845 > Jul 2 00:43:48 gaia kernel: [ 420.235819] pci 0000:05:00.0: AER: can't recover (no error_detected callback) > Jul 2 00:43:48 gaia kernel: [ 420.384349] pcieport 0000:00:1d.0: AER: device recovery successful > ... // The following might relate to an attempt to assign the device to guest, not very sure... > Jul 2 00:46:06 gaia kernel: [ 559.147333] pciback 0000:05:00.0: xen_pciback: seizing device > Jul 2 00:46:06 gaia kernel: [ 559.147435] pciback 0000:05:00.0: enabling device (0000 -> 0002) > Jul 2 00:46:06 gaia kernel: [ 559.147508] xen: registering gsi 16 triggering 0 polarity 1 > Jul 2 00:46:06 gaia kernel: [ 559.147511] Already setup the GSI :16 > Jul 2 00:46:06 gaia kernel: [ 559.147558] pciback 0000:05:00.0: xen_pciback: MSI-X preparation failed (-6) > > > With pcie_aspm=off, the error log related to pciback goes away. > But I suspect there are still some problems hidden -- since I don't > see any AER enabled messages so errors may be hidden. > I have the xen_pciback built directly into the kernel and assigned the > SSD to it in the kernel command-line. > However, the result from pci-assignable-xxx commands are not very consistent: > > root@gaia:~# xl pci-assignable-list > 0000:00:17.0 > 0000:05:00.0 > root@gaia:~# xl pci-assignable-remove 05:00.0 > libxl: error: libxl_pci.c:853:libxl__device_pci_assignable_remove: failed to de-quarantine 0000:05:00.0 <===== Here!!! > root@gaia:~# xl pci-assignable-add 05:00.0 > libxl: warning: libxl_pci.c:794:libxl__device_pci_assignable_add: 0000:05:00.0 already assigned to pciback <==== Here!!! > root@gaia:~# xl pci-assignable-remove 05:00.0 > root@gaia:~# xl pci-assignable-list 0000:00:17.0 > root@gaia:~# xl pci-assignable-add 05:00.0 > libxl: warning: libxl_pci.c:814:libxl__device_pci_assignable_add: 0000:05:00.0 not bound to a driver, will not be rebound. > root@gaia:~# xl pci-assignable-list > 0000:00:17.0 > 0000:05:00.0 > > > After the 'xl pci-assignable-list' appears to be self-consistent, creating VM with the SSD assigned still leads to a guest crash: > From qemu log: > [00:06.0] xen_pt_region_update: Error: create new mem mapping failed! (err: 1) > qemu-system-i386: terminating on signal 1 from pid 1192 (xl) > > From the 'xl dmesg' output: > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > (XEN) domain_crash called from p2m.c:1301 > (XEN) Domain 1 reported crashed by domain 0 on cpu#4: > (XEN) memory_map:fail: dom1 gfn=f3078 mfn=a2504 nr=1 ret:-1 > > > Which of the three syndromes are more fundamental? > 1. The DPC / AER error log > 2. The inconsistency in 'xl pci-assignable-list' state tracking > 3. The GFN mapping failure on guest setup > > Any suggestions for the next step? > > > Thanks, > G.R. --000000000000ef66cb05e2f4f988 Content-Type: text/x-log; charset="US-ASCII"; name="xldmesg_sn570_pt_fail.log" Content-Disposition: attachment; filename="xldmesg_sn570_pt_fail.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56d1wq61 KFhFTikgSFZNIGQxdjAgc2F2ZTogQ1BVCihYRU4pIEhWTSBkMXYxIHNhdmU6IENQVQooWEVOKSBI Vk0gZDEgc2F2ZTogUElDCihYRU4pIEhWTSBkMSBzYXZlOiBJT0FQSUMKKFhFTikgSFZNIGQxdjAg c2F2ZTogTEFQSUMKKFhFTikgSFZNIGQxdjEgc2F2ZTogTEFQSUMKKFhFTikgSFZNIGQxdjAgc2F2 ZTogTEFQSUNfUkVHUwooWEVOKSBIVk0gZDF2MSBzYXZlOiBMQVBJQ19SRUdTCihYRU4pIEhWTSBk MSBzYXZlOiBQQ0lfSVJRCihYRU4pIEhWTSBkMSBzYXZlOiBJU0FfSVJRCihYRU4pIEhWTSBkMSBz YXZlOiBQQ0lfTElOSwooWEVOKSBIVk0gZDEgc2F2ZTogUElUCihYRU4pIEhWTSBkMSBzYXZlOiBS VEMKKFhFTikgSFZNIGQxIHNhdmU6IEhQRVQKKFhFTikgSFZNIGQxIHNhdmU6IFBNVElNRVIKKFhF TikgSFZNIGQxdjAgc2F2ZTogTVRSUgooWEVOKSBIVk0gZDF2MSBzYXZlOiBNVFJSCihYRU4pIEhW TSBkMSBzYXZlOiBWSVJJRElBTl9ET01BSU4KKFhFTikgSFZNIGQxdjAgc2F2ZTogQ1BVX1hTQVZF CihYRU4pIEhWTSBkMXYxIHNhdmU6IENQVV9YU0FWRQooWEVOKSBIVk0gZDF2MCBzYXZlOiBWSVJJ RElBTl9WQ1BVCihYRU4pIEhWTSBkMXYxIHNhdmU6IFZJUklESUFOX1ZDUFUKKFhFTikgSFZNIGQx djAgc2F2ZTogVk1DRV9WQ1BVCihYRU4pIEhWTSBkMXYxIHNhdmU6IFZNQ0VfVkNQVQooWEVOKSBI Vk0gZDF2MCBzYXZlOiBUU0NfQURKVVNUCihYRU4pIEhWTSBkMXYxIHNhdmU6IFRTQ19BREpVU1QK KFhFTikgSFZNIGQxdjAgc2F2ZTogQ1BVX01TUgooWEVOKSBIVk0gZDF2MSBzYXZlOiBDUFVfTVNS CihYRU4pIEhWTTEgcmVzdG9yZTogQ1BVIDAKKGQxKSBIVk0gTG9hZGVyCihkMSkgRGV0ZWN0ZWQg WGVuIHY0LjE0LjMKKGQxKSBYZW5idXMgcmluZ3MgQDB4ZmVmZmMwMDAsIGV2ZW50IGNoYW5uZWwg MQooZDEpIFN5c3RlbSByZXF1ZXN0ZWQgU2VhQklPUwooZDEpIENQVSBzcGVlZCBpcyAzNTA1IE1I egooZDEpIFJlbG9jYXRpbmcgZ3Vlc3QgbWVtb3J5IGZvciBsb3dtZW0gTU1JTyBzcGFjZSBkaXNh YmxlZAooZDEpIFBDSS1JU0EgbGluayAwIHJvdXRlZCB0byBJUlE1CihkMSkgUENJLUlTQSBsaW5r IDEgcm91dGVkIHRvIElSUTEwCihkMSkgUENJLUlTQSBsaW5rIDIgcm91dGVkIHRvIElSUTExCihk MSkgUENJLUlTQSBsaW5rIDMgcm91dGVkIHRvIElSUTUKKGQxKSBwY2kgZGV2IDAxOjMgSU5UQS0+ SVJRMTAKKGQxKSBwY2kgZGV2IDAyOjAgSU5UQS0+SVJRMTEKKGQxKSBwY2kgZGV2IDA0OjAgSU5U QS0+SVJRNQooZDEpIHBjaSBkZXYgMDU6MCBJTlRBLT5JUlExMAooZDEpIHBjaSBkZXYgMDY6MCBJ TlRBLT5JUlExMQooZDEpIFJBTSBpbiBoaWdoIG1lbW9yeTsgc2V0dGluZyBoaWdoX21lbSByZXNv dXJjZSBiYXNlIHRvIDQwZjgwMDAwMAooZDEpIHBjaSBkZXYgMDM6MCBiYXIgMTAgc2l6ZSAwMDIw MDAwMDA6IDBmMDAwMDAwOAooZDEpIHBjaSBkZXYgMDI6MCBiYXIgMTQgc2l6ZSAwMDEwMDAwMDA6 IDBmMjAwMDAwOAooZDEpIHBjaSBkZXYgMDQ6MCBiYXIgMzAgc2l6ZSAwMDAwNDAwMDA6IDBmMzAw MDAwMAooZDEpIHBjaSBkZXYgMDQ6MCBiYXIgMTAgc2l6ZSAwMDAwMjAwMDA6IDBmMzA0MDAwMAoo ZDEpIHBjaSBkZXYgMDM6MCBiYXIgMzAgc2l6ZSAwMDAwMTAwMDA6IDBmMzA2MDAwMAooZDEpIHBj aSBkZXYgMDY6MCBiYXIgMTAgc2l6ZSAwMDAwMDQwMDA6IDBmMzA3MDAwNAooZDEpIHBjaSBkZXYg MDU6MCBiYXIgMTAgc2l6ZSAwMDAwMDIwMDA6IDBmMzA3NDAwMAooZDEpIHBjaSBkZXYgMDM6MCBi YXIgMTQgc2l6ZSAwMDAwMDEwMDA6IDBmMzA3NjAwMAooZDEpIHBjaSBkZXYgMDU6MCBiYXIgMjQg c2l6ZSAwMDAwMDA4MDA6IDBmMzA3NzAwMAooZDEpIHBjaSBkZXYgMDI6MCBiYXIgMTAgc2l6ZSAw MDAwMDAxMDA6IDAwMDAwYzAwMQooZDEpIHBjaSBkZXYgMDU6MCBiYXIgMTQgc2l6ZSAwMDAwMDAx MDA6IDBmMzA3NzgwMAooZDEpIHBjaSBkZXYgMDY6MCBiYXIgMjAgc2l6ZSAwMDAwMDAxMDA6IDBm MzA3NzkwNAooZDEpIHBjaSBkZXYgMDQ6MCBiYXIgMTQgc2l6ZSAwMDAwMDAwNDA6IDAwMDAwYzEw MQooZDEpIHBjaSBkZXYgMDU6MCBiYXIgMjAgc2l6ZSAwMDAwMDAwMjA6IDAwMDAwYzE0MQooZDEp IHBjaSBkZXYgMDE6MSBiYXIgMjAgc2l6ZSAwMDAwMDAwMTA6IDAwMDAwYzE2MQooZDEpIHBjaSBk ZXYgMDU6MCBiYXIgMTggc2l6ZSAwMDAwMDAwMDg6IDAwMDAwYzE3MQooZDEpIHBjaSBkZXYgMDU6 MCBiYXIgMWMgc2l6ZSAwMDAwMDAwMDQ6IDAwMDAwYzE3OQooWEVOKSBtZW1vcnlfbWFwOmFkZDog ZG9tMSBnZm49ZjMwNzQgbWZuPWEyNjEwIG5yPTIKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTEg Z2ZuPWYzMDc3IG1mbj1hMjYxNSBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1m MzA3OCBtZm49YTI2MTYgbnI9MQooWEVOKSBpb3BvcnRfbWFwOmFkZDogZG9tMSBncG9ydD1jMTQw IG1wb3J0PTQwNjAgbnI9MjAKKFhFTikgaW9wb3J0X21hcDphZGQ6IGRvbTEgZ3BvcnQ9YzE3MCBt cG9ydD00MDkwIG5yPTgKKFhFTikgaW9wb3J0X21hcDphZGQ6IGRvbTEgZ3BvcnQ9YzE3OCBtcG9y dD00MDgwIG5yPTQKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTEgZ2ZuPWYzMDcwIG1mbj1hMjUw MCBucj0yCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9 MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tMSBnZm49ZjMwNzggbWZuPWEyNTA0IG5yPTEKKFhF TikgZDE6IEdGTiAweGYzMDc4ICgweGEyNjE2LDAsNSw3KSAtPiAoMHhhMjUwNCwwLDUsNykgbm90 IHBlcm1pdHRlZAooWEVOKSBkb21haW5fY3Jhc2ggY2FsbGVkIGZyb20gcDJtLmM6MTMwMQooWEVO KSBEb21haW4gMSByZXBvcnRlZCBjcmFzaGVkIGJ5IGRvbWFpbiAwIG9uIGNwdSMyOgooWEVOKSBt ZW1vcnlfbWFwOmZhaWw6IGRvbTEgZ2ZuPWYzMDc4IG1mbj1hMjUwNCBucj0xIHJldDotMQooWEVO KSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tMSBnZm49ZjMwNzggbWZuPWEyNTA0IG5yPTEKCg== --000000000000ef66cb05e2f4f988 Content-Type: text/x-log; charset="US-ASCII"; name="pciback_dbg_xl-pci_assignable_XXX.log" Content-Disposition: attachment; filename="pciback_dbg_xl-pci_assignable_XXX.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56d1wpl0 cm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLWFkZCAwNTowMC4wCmxpYnhsOiB3YXJuaW5n OiBsaWJ4bF9wY2kuYzo4MTQ6bGlieGxfX2RldmljZV9wY2lfYXNzaWduYWJsZV9hZGQ6IDAwMDA6 MDU6MDAuMCBub3QgYm91bmQgdG8gYSBkcml2ZXIsIHdpbGwgbm90IGJlIHJlYm91bmQuCgpbICAz MjMuNDQ4MTE1XSB4ZW5fcGNpYmFjazogd2FudHMgdG8gc2VpemUgMDAwMDowNTowMC4wClsgIDMy My40NDgxMzZdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcHJvYmluZy4uLgpb ICAzMjMuNDQ4MTM3XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHNlaXppbmcg ZGV2aWNlClsgIDMyMy40NDgxNjJdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazog cGNpc3R1Yl9kZXZpY2VfYWxsb2MKWyAgMzIzLjQ0ODE2Ml0gcGNpYmFjayAwMDAwOjA1OjAwLjA6 IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcuLi4KWyAgMzIzLjQ0ODE2M10gcGNpYmFjayAwMDAw OjA1OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcgY29uZmlnClsgIDMyMy40NDgzNDRd IHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZW5hYmxpbmcgZGV2aWNlClsgIDMy My40NDg0MjVdIHhlbjogcmVnaXN0ZXJpbmcgZ3NpIDE2IHRyaWdnZXJpbmcgMCBwb2xhcml0eSAx ClsgIDMyMy40NDg0MjhdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTYKWyAgMzIzLjQ0ODQ5N10g cGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBzYXZlIHN0YXRlIG9mIGRldmljZQpb ICAzMjMuNDQ4NjQyXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlc2V0dGlu ZyAoRkxSLCBEMywgZXRjKSB0aGUgZGV2aWNlClsgIDMyMy40NDg3MDddIHBjaWVwb3J0IDAwMDA6 MDA6MWQuMDogRFBDOiBjb250YWlubWVudCBldmVudCwgc3RhdHVzOjB4MWYxMSBzb3VyY2U6MHgw MDAwClsgIDMyMy40NDg3MzBdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDogRFBDOiB1bm1hc2tlZCB1 bmNvcnJlY3RhYmxlIGVycm9yIGRldGVjdGVkClsgIDMyMy40NDg3NjBdIHBjaWVwb3J0IDAwMDA6 MDA6MWQuMDogUENJZSBCdXMgRXJyb3I6IHNldmVyaXR5PVVuY29ycmVjdGVkIChOb24tRmF0YWwp LCB0eXBlPVRyYW5zYWN0aW9uIExheWVyLCAoUmVjZWl2ZXIgSUQpClsgIDMyMy40NDg3ODZdIHBj aWVwb3J0IDAwMDA6MDA6MWQuMDogICBkZXZpY2UgWzgwODY6YTMzMF0gZXJyb3Igc3RhdHVzL21h c2s9MDAyMDAwMDAvMDAwMTAwMDAKWyAgMzIzLjQ0ODgxM10gcGNpZXBvcnQgMDAwMDowMDoxZC4w OiAgICBbMjFdIEFDU1Zpb2wgICAgICAgICAgICAgICAgKEZpcnN0KQpbICAzMjQuNjkwOTc5XSBw Y2liYWNrIDAwMDA6MDU6MDAuMDogbm90IHJlYWR5IDEwMjNtcyBhZnRlciBGTFI7IHdhaXRpbmcK WyAgMzI1LjczMDcwNl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IG5vdCByZWFkeSAyMDQ3bXMgYWZ0 ZXIgRkxSOyB3YWl0aW5nClsgIDMyNy45OTc2MzhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiBub3Qg cmVhZHkgNDA5NW1zIGFmdGVyIEZMUjsgd2FpdGluZwpbICAzMzIuMjY0MjUxXSBwY2liYWNrIDAw MDA6MDU6MDAuMDogbm90IHJlYWR5IDgxOTFtcyBhZnRlciBGTFI7IHdhaXRpbmcKWyAgMzQwLjU4 NDMyMF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IG5vdCByZWFkeSAxNjM4M21zIGFmdGVyIEZMUjsg d2FpdGluZwpbICAzNTcuMDEwODk2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogbm90IHJlYWR5IDMy NzY3bXMgYWZ0ZXIgRkxSOyB3YWl0aW5nClsgIDM5MS4xNDM5NTFdIHBjaWJhY2sgMDAwMDowNTow MC4wOiBub3QgcmVhZHkgNjU1MzVtcyBhZnRlciBGTFI7IGdpdmluZyB1cApbICAzOTIuMjQ5MjUy XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlc2V0IGRldmljZQpbICAzOTIu MjQ5MzkyXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHhlbl9wY2lia19lcnJv cl9kZXRlY3RlZChidXM6NSxkZXZmbjowKQpbICAzOTIuMjQ5MzkzXSBwY2liYWNrIDAwMDA6MDU6 MDAuMDogeGVuX3BjaWJhY2s6IGRldmljZSBpcyBub3QgZm91bmQvYXNzaWduZWQKWyAgMzkyLjM5 NzA3NF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiB4ZW5fcGNpYmtfZXJyb3Jf cmVzdW1lKGJ1czo1LGRldmZuOjApClsgIDM5Mi4zOTcwODBdIHBjaWJhY2sgMDAwMDowNTowMC4w OiB4ZW5fcGNpYmFjazogZGV2aWNlIGlzIG5vdCBmb3VuZC9hc3NpZ25lZApbICAzOTIuMzk3Mjg0 XSBwY2llcG9ydCAwMDAwOjAwOjFkLjA6IEFFUjogZGV2aWNlIHJlY292ZXJ5IHN1Y2Nlc3NmdWwK CmxpYnhsOiBlcnJvcjogbGlieGxfcGNpLmM6ODM1OmxpYnhsX19kZXZpY2VfcGNpX2Fzc2lnbmFi bGVfYWRkOiBmYWlsZWQgdG8gcXVhcmFudGluZSAwMDAwOjA1OjAwLjAKCnJvb3RAZ2FpYTp+IyB4 bCBwY2ktYXNzaWduYWJsZS1yZW1vdmUgMDU6MDAuMApsaWJ4bDogZXJyb3I6IGxpYnhsX3BjaS5j Ojg1MzpsaWJ4bF9fZGV2aWNlX3BjaV9hc3NpZ25hYmxlX3JlbW92ZTogZmFpbGVkIHRvIGRlLXF1 YXJhbnRpbmUgMDAwMDowNTowMC4wCnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1hZGQg MDU6MDAuMApsaWJ4bDogd2FybmluZzogbGlieGxfcGNpLmM6Nzk0OmxpYnhsX19kZXZpY2VfcGNp X2Fzc2lnbmFibGVfYWRkOiAwMDAwOjA1OjAwLjAgYWxyZWFkeSBhc3NpZ25lZCB0byBwY2liYWNr CnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1yZW1vdmUgMDU6MDAuMApbICA2MDMuOTI4 MDM5XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlbW92aW5nClsgIDYwMy45 MjgwNDFdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZm91bmQgZGV2aWNlIHRv IHJlbW92ZSAKWyAgNjAzLjkyODA0Ml0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBwY2lzdHViX2RldmljZV9yZWxlYXNlClsgIDYwNC4wMzMzNzJdIHBjaWVwb3J0IDAwMDA6MDA6 MWQuMDogRFBDOiBjb250YWlubWVudCBldmVudCwgc3RhdHVzOjB4MWYxMSBzb3VyY2U6MHgwMDAw ClsgIDYwNC4wMzM1MTJdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDogRFBDOiB1bm1hc2tlZCB1bmNv cnJlY3RhYmxlIGVycm9yIGRldGVjdGVkClsgIDYwNC4wMzM2MzFdIHBjaWVwb3J0IDAwMDA6MDA6 MWQuMDogUENJZSBCdXMgRXJyb3I6IHNldmVyaXR5PVVuY29ycmVjdGVkIChOb24tRmF0YWwpLCB0 eXBlPVRyYW5zYWN0aW9uIExheWVyLCAoUmVxdWVzdGVyIElEKQpbICA2MDQuMDMzNzU4XSBwY2ll cG9ydCAwMDAwOjAwOjFkLjA6ICAgZGV2aWNlIFs4MDg2OmEzMzBdIGVycm9yIHN0YXR1cy9tYXNr PTAwMTAwMDAwLzAwMDEwMDAwClsgIDYwNC4wMzM4NTZdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDog ICAgWzIwXSBVbnN1cFJlcSAgICAgICAgICAgICAgIChGaXJzdCkKWyAgNjA0LjAzMzkzOV0gcGNp ZXBvcnQgMDAwMDowMDoxZC4wOiBBRVI6ICAgVExQIEhlYWRlcjogMzQwMDAwMDAgMDUwMDAwMTAg MDAwMDAwMDAgODg0NTg4NDUKWyAgNjA0LjAzNDA1OV0gcGNpIDAwMDA6MDU6MDAuMDogQUVSOiBj YW4ndCByZWNvdmVyIChubyBlcnJvcl9kZXRlY3RlZCBjYWxsYmFjaykKWyAgNjA0LjAzNDQyMV0g eGVuX3BjaWJhY2s6IHJlbW92ZWQgMDAwMDowNTowMC4wIGZyb20gc2VpemUgbGlzdApbICA2MDQu MTgyNTk3XSBwY2llcG9ydCAwMDAwOjAwOjFkLjA6IEFFUjogZGV2aWNlIHJlY292ZXJ5IHN1Y2Nl c3NmdWwKCnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1hZGQgMDU6MDAuMApsaWJ4bDog d2FybmluZzogbGlieGxfcGNpLmM6ODE0OmxpYnhsX19kZXZpY2VfcGNpX2Fzc2lnbmFibGVfYWRk OiAwMDAwOjA1OjAwLjAgbm90IGJvdW5kIHRvIGEgZHJpdmVyLCB3aWxsIG5vdCBiZSByZWJvdW5k LgpbICA2NjcuNTgyMDUxXSB4ZW5fcGNpYmFjazogd2FudHMgdG8gc2VpemUgMDAwMDowNTowMC4w ClsgIDY2Ny41ODIxMzBdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcHJvYmlu Zy4uLgpbICA2NjcuNTgyMTM0XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHNl aXppbmcgZGV2aWNlClsgIDY2Ny41ODIyMjhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNp YmFjazogcGNpc3R1Yl9kZXZpY2VfYWxsb2MKWyAgNjY3LjU4MjIzMV0gcGNpYmFjayAwMDAwOjA1 OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcuLi4KWyAgNjY3LjU4MjIzNV0gcGNpYmFj ayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcgY29uZmlnClsgIDY2Ny41 ODI1NDhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZW5hYmxpbmcgZGV2aWNl ClsgIDY2Ny41ODI1OTldIHBjaWJhY2sgMDAwMDowNTowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAw MDAgLT4gMDAwMikKWyAgNjY3LjU4MjkxMl0geGVuOiByZWdpc3RlcmluZyBnc2kgMTYgdHJpZ2dl cmluZyAwIHBvbGFyaXR5IDEKWyAgNjY3LjU4MjkyM10gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDox NgpbICA2NjcuNTgzMDYxXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IE1TSS1Y IHByZXBhcmF0aW9uIGZhaWxlZCAoLTYpClsgIDY2Ny41ODMxNDhdIHBjaWJhY2sgMDAwMDowNTow MC4wOiB4ZW5fcGNpYmFjazogc2F2ZSBzdGF0ZSBvZiBkZXZpY2UKWyAgNjY3LjU4MzU2OV0gcGNp YmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiByZXNldHRpbmcgKEZMUiwgRDMsIGV0Yykg dGhlIGRldmljZQpbICA2NjcuNjg5NjU2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJh Y2s6IHJlc2V0IGRldmljZQoKcm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLXJlbW92ZSAw NTowMC4wClsgIDcyMC45NTc5ODhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazog cmVtb3ZpbmcKWyAgNzIwLjk1Nzk5Nl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBmb3VuZCBkZXZpY2UgdG8gcmVtb3ZlIApbICA3MjAuOTU3OTk5XSBwY2liYWNrIDAwMDA6MDU6 MDAuMDogeGVuX3BjaWJhY2s6IHBjaXN0dWJfZGV2aWNlX3JlbGVhc2UKWyAgNzIxLjA2NTIyMl0g cGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBNU0ktWCByZWxlYXNlIGZhaWxlZCAo LTE2KQpbICA3MjEuMDY1NjY3XSB4ZW5fcGNpYmFjazogcmVtb3ZlZCAwMDAwOjA1OjAwLjAgZnJv bSBzZWl6ZSBsaXN0Cgpyb290QGdhaWE6fiMgeGwgcGNpLWFzc2lnbmFibGUtYWRkIDA1OjAwLjAK bGlieGw6IHdhcm5pbmc6IGxpYnhsX3BjaS5jOjgxNDpsaWJ4bF9fZGV2aWNlX3BjaV9hc3NpZ25h YmxlX2FkZDogMDAwMDowNTowMC4wIG5vdCBib3VuZCB0byBhIGRyaXZlciwgd2lsbCBub3QgYmUg cmVib3VuZC4KClsgIDc2My44ODg2MzFdIHhlbl9wY2liYWNrOiB3YW50cyB0byBzZWl6ZSAwMDAw OjA1OjAwLjAKWyAgNzYzLjg4ODY5MF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBwcm9iaW5nLi4uClsgIDc2My44ODg2OTFdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNp YmFjazogc2VpemluZyBkZXZpY2UKWyAgNzYzLjg4ODcxNl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6 IHhlbl9wY2liYWNrOiBwY2lzdHViX2RldmljZV9hbGxvYwpbICA3NjMuODg4NzE3XSBwY2liYWNr IDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IGluaXRpYWxpemluZy4uLgpbICA3NjMuODg4NzE3 XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IGluaXRpYWxpemluZyBjb25maWcK WyAgNzYzLjg4ODgwNF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBlbmFibGlu ZyBkZXZpY2UKWyAgNzYzLjg4ODg4NV0geGVuOiByZWdpc3RlcmluZyBnc2kgMTYgdHJpZ2dlcmlu ZyAwIHBvbGFyaXR5IDEKWyAgNzYzLjg4ODg4OV0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpb ICA3NjMuODg4OTQ5XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IE1TSS1YIHBy ZXBhcmF0aW9uIGZhaWxlZCAoLTYpClsgIDc2My44ODg5NzddIHBjaWJhY2sgMDAwMDowNTowMC4w OiB4ZW5fcGNpYmFjazogc2F2ZSBzdGF0ZSBvZiBkZXZpY2UKWyAgNzYzLjg4OTEyNl0gcGNpYmFj ayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiByZXNldHRpbmcgKEZMUiwgRDMsIGV0YykgdGhl IGRldmljZQpbICA3NjMuOTk0MjA2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6 IHJlc2V0IGRldmljZQoKcm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLXJlbW92ZSAwNTow MC4wClsgIDgxOS40OTEwMDBdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcmVt b3ZpbmcKWyAgODE5LjQ5MTAwMl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBm b3VuZCBkZXZpY2UgdG8gcmVtb3ZlIApbICA4MTkuNDkxMDAzXSBwY2liYWNrIDAwMDA6MDU6MDAu MDogeGVuX3BjaWJhY2s6IHBjaXN0dWJfZGV2aWNlX3JlbGVhc2UKWyAgODE5LjU5NjExM10gcGNp YmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBNU0ktWCByZWxlYXNlIGZhaWxlZCAoLTE2 KQpbICA4MTkuNTk2NDY2XSB4ZW5fcGNpYmFjazogcmVtb3ZlZCAwMDAwOjA1OjAwLjAgZnJvbSBz ZWl6ZSBsaXN0Cgo= --000000000000ef66cb05e2f4f988-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 07:21:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 07:21:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359865.589116 (Exim 4.92) (envelope-from ) id 1o8GNy-0008Ly-3c; Mon, 04 Jul 2022 07:20:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359865.589116; Mon, 04 Jul 2022 07:20:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GNy-0008Lr-0k; Mon, 04 Jul 2022 07:20:46 +0000 Received: by outflank-mailman (input) for mailman id 359865; Mon, 04 Jul 2022 07:20:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GNw-0008Ll-QU for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 07:20:45 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00080.outbound.protection.outlook.com [40.107.0.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfedac6b-fb69-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 09:20:42 +0200 (CEST) Received: from DB6PR0201CA0006.eurprd02.prod.outlook.com (2603:10a6:4:3f::16) by VI1PR08MB3246.eurprd08.prod.outlook.com (2603:10a6:803:4b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 07:20:39 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::c2) by DB6PR0201CA0006.outlook.office365.com (2603:10a6:4:3f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Mon, 4 Jul 2022 07:20:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 07:20:38 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Mon, 04 Jul 2022 07:20:38 +0000 Received: from a547f1302c5b.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 894C64A3-D7CD-4181-B131-2F7E374EC1AF.1; Mon, 04 Jul 2022 07:20:28 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a547f1302c5b.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 07:20:28 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM6PR08MB3430.eurprd08.prod.outlook.com (2603:10a6:20b:43::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Mon, 4 Jul 2022 07:20:25 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%6]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 07:20:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfedac6b-fb69-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EZqQVAp9pvDTva3kyDU0xWKJ3ZutlgJv11lisuMtFptt0mklNXjM+aar/0TJobmYnY93E3RlHoykyR52XvyNoZASuH30f6X27q5ZHSBDi0YaBQish4ietkddM1a3nW2r6ZOUDtqautKkdso8So2HHbgKa/0zIJPFwUJiiF0icjJ8ho36MxyigkjBr+30ImOM1/ZdO2sZOmJJ/DmKgaUgV3GdircI19yef28s1Fp0EMM88kZdVEFPoRnLYoIfmsuX5EfZ263lUkh9c4pfQHaCOxmGnb5LFjgdb9wFoNLW1pO6+H2mM31GfZoVqySvzUlrgOT1Dr7LCu56CPTSxm+VfA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hTKVQx3g0DNIMIBckUhZBcEWumL0Uzie8AvhI3YjEE4=; b=hDg3yqwLMH2MAn5g3B3SUXeW/BQXb1V+Tt6UcorwLgUafUASYr9f2RR5lGthqf+pd45VlRXVA2T9mFXH6tbpX+lt6d/JrWSIC6BkQJXqQ9PPh96piDP/0N2SRYzNFi62WFBnn8uBwNJBNWwsrdt6GKyTdPszuy5AxfGWaQd7fOnhOFTHVl204bU8V29Ifc+1fqCShqdTtDAE/QnWKzR/8d5mA/5yUKhm6ip0V/hEgXwPcpjrlBjxkQNGAwPQvto5tu7QSnQUtoo0rkWUpwznan1TFpB+hq1+0PngJfleJdHXjYb5DThlFLy7kigFvYuRIkzdEO+j8hFuXYVQceS/sw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hTKVQx3g0DNIMIBckUhZBcEWumL0Uzie8AvhI3YjEE4=; b=LOx1Zc+uWqkSJvjJZFK+m38LYuzBr8jXq/8IgJsFRbgZf+8U+hmxCYseGDIVogWY3rkvxlUPTUau/xF1s33ONeE/xgPpQoBFfGQ3/jfwOl/bx0nnsjLUK+zfNVex0tNYm6n2zyQGmPKbwKAK9J7HmnBH+wkyGZru35dm070gQDs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZT/haiCQ+VGNCp/oi03Zj/1KqM/2ZJwR1hE6i0rIw23q51WUevZgQthHRo62oc2qfZ5iEThyjcOPdcpKDFDw+SAuiL/rKfsphiuVGvCl9CFlw2MFRI1ZxNMZgIRwp76knx3iogEpBLD0nyCRZ4yEoK4jROtcGy9O2MczfI3ehfNIJbw95ehczlzgE12eioe8LLCJSKRDJIrhu1sv/zqc4/vtpHkvM+sac19Kefk2Bnr0zBp3U3jPPWwr4UBPnCsCFVUBfo+wzAjkpTWjloFwKM10GZhNK5DeOijcuhMxVAfhgIkUpC8SDzelcZE+3LQf760bQ4p5cLLTZF0y1lh/rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hTKVQx3g0DNIMIBckUhZBcEWumL0Uzie8AvhI3YjEE4=; b=WNphd5Knq2JC8uVEQVdySgRx0TMZUWRpyY0MipgWu+Dp7dfu/lKE9UjrfeX9kYCPR/tBhWQP7FphRIx1a+SdFMO6pJ9QGaENfftaSI48yYihUV58Qhi5ByiqmPSCP1cSOxZMWr7qp6gaqlc2ZMo54zFBQtglLYGqKGV8DbmppePIjTBb+PWUMu05TCt7Ycro/l9ZInjKUtuflRbDg8gLrAQXTHsYZAnDGA6wS2GeNnrtWjiuv/Ldhsvyr2ex+aYcdZiX40br+n68EShAqOv0GgcH1CU/pzr9OvDy/6X2GUmW2xjXk+jkS9DVvfN5kIAAx23+1F13rc3SnnT74b8zKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hTKVQx3g0DNIMIBckUhZBcEWumL0Uzie8AvhI3YjEE4=; b=LOx1Zc+uWqkSJvjJZFK+m38LYuzBr8jXq/8IgJsFRbgZf+8U+hmxCYseGDIVogWY3rkvxlUPTUau/xF1s33ONeE/xgPpQoBFfGQ3/jfwOl/bx0nnsjLUK+zfNVex0tNYm6n2zyQGmPKbwKAK9J7HmnBH+wkyGZru35dm070gQDs= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: RE: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io Thread-Topic: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io Thread-Index: AQHYhGQ84mRcoOoQ8UiRh2nj8rBdHq1e5e0AgAcJLcCAAE/NgIAHooTQ Date: Mon, 4 Jul 2022 07:20:24 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-3-Penny.Zheng@arm.com> <3b7b32cb-df48-e458-e8a9-f17e86f39c9a@xen.org> <5a49381c-c69d-88dc-1bba-783241dbfe23@xen.org> In-Reply-To: <5a49381c-c69d-88dc-1bba-783241dbfe23@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 10F1047C52BACB409A050E37111768D2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fc6879df-8abd-43de-094a-08da5d8db1e2 x-ms-traffictypediagnostic: AM6PR08MB3430:EE_|DBAEUR03FT005:EE_|VI1PR08MB3246:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7HYuJp09FnI5yJxMJKUFwrpOWEiF4eZYG7paPFEVO30lnMNnDoUZ5zc496su0GU2Y5t+pxq5MaQuhozqv4jtSwO0lXWAaxHODFjjrhQ8yMgxCgqrYshvhWrtWMlXvd27hsYzYz/g/qTxOi5z4u0Pg3hp4pxaaACICRbE6E+KUBCZ1/FGS9GSXyp7WuL9Pa6Psr7QgU5lE80P0dT2KjLDayjjOBUFVLoC7w28Y0L6QFX5x6iebDnur+aG5IIIzRdtbAM7JrGdOctF9s+mLlCwg84xO8nGoi2XnaIbcRF0PXp6hfJH3F/yTPJWiU2PJy/WV21L1Vxp4UxHLbcTaIkOKz0F8Eo/G62S8fhhEzy6j76A7klOWSgVKm9F3HX4f0aZJ2JCDYWcBxhgcUW2PoNXq9hy94kfPHSHZMY/ORHz9XLruc2Fk6+Vyk9PIEfLt1WF3Oa8txwRE2ACsTz24TLAvak+Qpv0SCCpeJkp82e7BPyT7FBVDhXMNOxmLtsHxVFkbmeuYa8JjdopVuouO53hcJ2lZZrbWmArWSokRyPCSb9obaNEb9VRv2ucNMXp7iPiM31LOkd8Brn9zkd8QuKJE18RZPXu4ENkb04kUJ4Ko1gwU6zwDAwuEMjEqIHygOry6JPfAVBbyUtxKuXW02v0eJcOkRXifxFJR4mEehKlHBF82Mc39b+k154B8pL03mJBVvMWwF0J/NgBv7zXycjWsLA6lXwiivauQVwx+DgGDdsxFj9RZP1rAbJYNUKoQT088UF6zbANhkGOCWL8hW2SJvdViilgyWTIkb7yuY9P0cdAXtiruyUTK8BwaiqW4OnV X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(39860400002)(376002)(136003)(8936002)(52536014)(5660300002)(26005)(478600001)(9686003)(55016003)(53546011)(186003)(86362001)(41300700001)(2906002)(6506007)(7696005)(33656002)(83380400001)(316002)(76116006)(66946007)(66556008)(66476007)(66446008)(8676002)(64756008)(4326008)(38100700002)(71200400001)(110136005)(38070700005)(54906003)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3430 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ecef96e4-943e-4bc7-ab29-08da5d8da9e1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KyfTI+W8puGqS/l3tTe+fbhdkL5j3CfPYWLkvr91qfW2xbXyDoLq5FkUjANC+qgbCdDTMnJ8xD0T2vi7kDcphsVQYzWXp14+fn185l/K6rEmzYvXGae401j2JYWrhDraRNjRl18sQ3qZb0RltvbfK6O+mqdhCcOjHAXLEpV47Thg/DAJz12oP1LdpLgQDqV9ni08B4ZYaTuxMHdYtqQNvzxT3gaQT+4X4B6e9SiJtHeurj4FlIfqYk+LVw1jhgIUzaeYHjkwPBJ2hzqj5+ZCo3TLlyGUg8ElZ8ei1WFl5OTFpvSdQPEElM8KG3iUM21Kw5l+VPzudZvCVrpDMbzciZSYR1A10K/t/n/YkxytR+id3ImIU7YDwgsh+fGd24I0fKlhKD7aGxSmQZ5zeIgq32NequOpFWIOlXNu5AIH7GK1tBBYuKo9r0XWTdQt/+O7avEVM4qta7iuNIZXyB+ZbQodjNehA4ZFRv+8IN3thf+Qjcdo0CSnVDJSrBic2SvWW5x9qJ7VKdBJGv7MNXtEtOyxMTgk/jiFaAFoYcEQdkMmRIjJsPITMtHiRznLQkDHo3jj2AeOurOmVzwKB/y7HxdMbmJPqpDJbixQO8tpd6Q+8sR180334Kc1pEpYZY6g69Gv9/LK337gjmVq5h6bDr4i9+5E57iHs+OQszliKplGqqZEjIazDWndWncJVFg5BO1+yukE3mrsIRPfmbS6cZQTCkwFubhDC8IqdElEF5PjUG9PMB1+JPexlK1VAyDBPIJ92l5iUOZjga2aFPDrK+JzKcpCdrjlEmnUFOmx7IY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39850400004)(136003)(346002)(376002)(396003)(46966006)(36840700001)(30864003)(52536014)(9686003)(7696005)(5660300002)(53546011)(8936002)(6506007)(26005)(86362001)(54906003)(8676002)(4326008)(70586007)(110136005)(70206006)(316002)(41300700001)(81166007)(356005)(478600001)(82740400003)(36860700001)(47076005)(336012)(82310400005)(186003)(55016003)(40480700001)(2906002)(33656002)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 07:20:38.2342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc6879df-8abd-43de-094a-08da5d8db1e2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3246 PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGp1bGll bkB4ZW4ub3JnPg0KPiBTZW50OiBXZWRuZXNkYXksIEp1bmUgMjksIDIwMjIgNjozNSBQTQ0KPiBU bzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVu cHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBT dGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJhbmQgTWFycXVpcyA8 QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4gVm9sb2R5bXlyIEJhYmNodWsgPFZvbG9keW15 cl9CYWJjaHVrQGVwYW0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47DQo+IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+DQo+IFN1 YmplY3Q6IFJlOiBbUEFUQ0ggdjUgMi84XSB4ZW4vYXJtOiBhbGxvY2F0ZSBzdGF0aWMgc2hhcmVk IG1lbW9yeSB0byB0aGUNCj4gZGVmYXVsdCBvd25lciBkb21faW8NCj4gDQo+IA0KPiANCj4gT24g MjkvMDYvMjAyMiAwODoxMywgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0K PiBIaSBQZW5ueSwNCj4gDQoNCkhpIEp1bGllbg0KPiA+DQo+ID4+IC0tLS0tT3JpZ2luYWwgTWVz c2FnZS0tLS0tDQo+ID4+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+ID4+ IFNlbnQ6IFNhdHVyZGF5LCBKdW5lIDI1LCAyMDIyIDI6MjIgQU0NCj4gPj4gVG86IFBlbm55IFpo ZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPjsgeGVuLQ0KPiBkZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZw0KPiA+PiBDYzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJl bGxpbmkNCj4gPj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzDQo+ ID4+IDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlteXIgQmFiY2h1aw0KPiA+PiA8 Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+ID4+IDxhbmRyZXcu Y29vcGVyM0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcA0KPiA+PiA8Z2VvcmdlLmR1bmxhcEBj aXRyaXguY29tPjsgSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgV2VpIExpdQ0KPiA+ PiA8d2xAeGVuLm9yZz4NCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NSAyLzhdIHhlbi9hcm06 IGFsbG9jYXRlIHN0YXRpYyBzaGFyZWQgbWVtb3J5IHRvDQo+ID4+IHRoZSBkZWZhdWx0IG93bmVy IGRvbV9pbw0KPiA+Pg0KPiA+PiBIaSBQZW5ueSwNCj4gPj4NCj4gPj4gT24gMjAvMDYvMjAyMiAw NjoxMSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiBGcm9tOiBQZW5ueSBaaGVuZyA8cGVubnku emhlbmdAYXJtLmNvbT4NCj4gPj4+DQo+ID4+PiBUaGlzIGNvbW1pdCBpbnRyb2R1Y2VzIHByb2Nl c3Nfc2htIHRvIGNvcGUgd2l0aCBzdGF0aWMgc2hhcmVkIG1lbW9yeQ0KPiA+Pj4gaW4gZG9tYWlu IGNvbnN0cnVjdGlvbi4NCj4gPj4+DQo+ID4+PiBET01JRF9JTyB3aWxsIGJlIHRoZSBkZWZhdWx0 IG93bmVyIG9mIG1lbW9yeSBwcmUtc2hhcmVkIGFtb25nDQo+ID4+IG11bHRpcGxlDQo+ID4+PiBk b21haW5zIGF0IGJvb3QgdGltZSwgd2hlbiBubyBleHBsaWNpdCBvd25lciBpcyBzcGVjaWZpZWQu DQo+ID4+DQo+ID4+IFRoZSBkb2N1bWVudCBpbiBwYXRjaCAjMSBzdWdnZXN0IHRoZSBwYWdlIHdp bGwgYmUgc2hhcmVkIHdpdGgNCj4gZG9tX3NoYXJlZC4NCj4gPj4gQnV0IGhlcmUgeW91IHNheSAi RE9NSURfSU8iLg0KPiA+Pg0KPiA+PiBXaGljaCBvbmUgaXMgY29ycmVjdD8NCj4gPj4NCj4gPg0K PiA+IEnigJlsbCBmaXggdGhlIGRvY3VtZW50YXRpb24sIERPTV9JTyBpcyB0aGUgbGFzdCBjYWxs Lg0KPiA+DQo+ID4+Pg0KPiA+Pj4gVGhpcyBjb21taXQgb25seSBjb25zaWRlcnMgYWxsb2NhdGlu ZyBzdGF0aWMgc2hhcmVkIG1lbW9yeSB0byBkb21faW8NCj4gPj4+IHdoZW4gb3duZXIgZG9tYWlu IGlzIG5vdCBleHBsaWNpdGx5IGRlZmluZWQgaW4gZGV2aWNlIHRyZWUsIGFsbCB0aGUNCj4gPj4+ IGxlZnQsIGluY2x1ZGluZyB0aGUgImJvcnJvd2VyIiBjb2RlIHBhdGgsIHRoZSAiZXhwbGljaXQg b3duZXIiIGNvZGUNCj4gPj4+IHBhdGgsIHNoYWxsIGJlIGludHJvZHVjZWQgbGF0ZXIgaW4gdGhl IGZvbGxvd2luZyBwYXRjaGVzLg0KPiA+Pj4NCj4gPj4+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpo ZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiA+Pj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3Rh YmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz4NCj4gPj4+IC0tLQ0KPiA+Pj4gdjUgY2hh bmdlOg0KPiA+Pj4gLSByZWZpbmUgaW4tY29kZSBjb21tZW50DQo+ID4+PiAtLS0NCj4gPj4+IHY0 IGNoYW5nZToNCj4gPj4+IC0gbm8gY2hhbmdlcw0KPiA+Pj4gLS0tDQo+ID4+PiB2MyBjaGFuZ2U6 DQo+ID4+PiAtIHJlZmluZSBpbi1jb2RlIGNvbW1lbnQNCj4gPj4+IC0tLQ0KPiA+Pj4gdjIgY2hh bmdlOg0KPiA+Pj4gLSBpbnN0ZWFkIG9mIGludHJvZHVjaW5nIGEgbmV3IHN5c3RlbSBkb21haW4s IHJldXNlIHRoZSBleGlzdGluZw0KPiA+Pj4gZG9tX2lvDQo+ID4+PiAtIG1ha2UgZG9tX2lvIGEg bm9uLWF1dG8tdHJhbnNsYXRlZCBkb21haW4sIHRoZW4gbm8gbmVlZCB0byBjcmVhdGUNCj4gPj4+ IFAyTSBmb3IgaXQNCj4gPj4+IC0gY2hhbmdlIGRvbV9pbyBkZWZpbml0aW9uIGFuZCBtYWtlIGl0 IHdpZGVyIHRvIHN1cHBvcnQgc3RhdGljIHNobQ0KPiA+Pj4gaGVyZSB0b28NCj4gPj4+IC0gaW50 cm9kdWNlIGlzX3NobV9hbGxvY2F0ZWRfdG9fZG9taW8gdG8gY2hlY2sgd2hldGhlciBzdGF0aWMg c2htIGlzDQo+ID4+PiBhbGxvY2F0ZWQgeWV0LCBpbnN0ZWFkIG9mIHVzaW5nIHNobV9tYXNrIGJp dG1hcA0KPiA+Pj4gLSBhZGQgaW4tY29kZSBjb21tZW50DQo+ID4+PiAtLS0NCj4gPj4+ICAgIHhl bi9hcmNoL2FybS9kb21haW5fYnVpbGQuYyB8IDEzMg0KPiA+PiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKy0NCj4gPj4+ICAgIHhlbi9jb21tb24vZG9tYWluLmMgICAgICAgICB8 ICAgMyArDQo+ID4+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDEzNCBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pDQo+ID4+Pg0KPiA+Pj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9kb21haW5f YnVpbGQuYw0KPiA+Pj4gYi94ZW4vYXJjaC9hcm0vZG9tYWluX2J1aWxkLmMgaW5kZXggN2RkZDE2 YzI2ZC4uOTFhNWFjZTg1MSAxMDA2NDQNCj4gPj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW5f YnVpbGQuYw0KPiA+Pj4gKysrIGIveGVuL2FyY2gvYXJtL2RvbWFpbl9idWlsZC5jDQo+ID4+PiBA QCAtNTI3LDYgKzUyNywxMCBAQCBzdGF0aWMgYm9vbCBfX2luaXQNCj4gPj4gYXBwZW5kX3N0YXRp Y19tZW1vcnlfdG9fYmFuayhzdHJ1Y3QgZG9tYWluICpkLA0KPiA+Pj4gICAgICAgIHJldHVybiB0 cnVlOw0KPiA+Pj4gICAgfQ0KPiA+Pj4NCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIElmIGNlbGwgaXMg TlVMTCwgcGJhc2UgYW5kIHBzaXplIHNob3VsZCBob2xkIHZhbGlkIHZhbHVlcy4NCj4gPj4+ICsg KiBPdGhlcndpc2UsIGNlbGwgd2lsbCBiZSBwb3B1bGF0ZWQgdG9nZXRoZXIgd2l0aCBwYmFzZSBh bmQgcHNpemUuDQo+ID4+PiArICovDQo+ID4+PiAgICBzdGF0aWMgbWZuX3QgX19pbml0IGFjcXVp cmVfc3RhdGljX21lbW9yeV9iYW5rKHN0cnVjdCBkb21haW4gKmQsDQo+ID4+PiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IF9fYmUzMiAqKmNl bGwsDQo+ID4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHUzMiBhZGRyX2NlbGxzLA0KPiA+Pj4gdTMyIHNpemVfY2VsbHMsIEBAIC01MzUsNyArNTM5 LDggQEAgc3RhdGljIG1mbl90IF9faW5pdA0KPiA+PiBhY3F1aXJlX3N0YXRpY19tZW1vcnlfYmFu ayhzdHJ1Y3QgZG9tYWluICpkLA0KPiA+Pj4gICAgICAgIG1mbl90IHNtZm47DQo+ID4+PiAgICAg ICAgaW50IHJlczsNCj4gPj4+DQo+ID4+PiAtICAgIGRldmljZV90cmVlX2dldF9yZWcoY2VsbCwg YWRkcl9jZWxscywgc2l6ZV9jZWxscywgcGJhc2UsIHBzaXplKTsNCj4gPj4+ICsgICAgaWYgKCBj ZWxsICkNCj4gPj4+ICsgICAgICAgIGRldmljZV90cmVlX2dldF9yZWcoY2VsbCwgYWRkcl9jZWxs cywgc2l6ZV9jZWxscywgcGJhc2UsDQo+ID4+PiArIHBzaXplKTsNCj4gPj4NCj4gPj4gSSB0aGlu ayB0aGlzIGlzIGEgYml0IG9mIGEgaGFjay4gVG8gbWUgaXQgc291bmRzIGxpa2UgdGhpcyBzaG91 bGQgYmUNCj4gPj4gbW92ZWQgb3V0IHRvIGEgc2VwYXJhdGUgaGVscGVyLiBUaGlzIHdpbGwgYWxz byBtYWtlIHRoZSBpbnRlcmZhY2Ugb2YNCj4gPj4gYWNxdWlyZV9zaGFyZWRfbWVtb3J5X2Jhbmso KSBsZXNzIHF1ZXN0aW9uYWJsZSAoc2VlIGJlbG93KS4NCj4gPj4NCj4gPg0KPiA+IE9rLCAgSSds bCB0cnkgdG8gbm90IHJldXNlIGFjcXVpcmVfc3RhdGljX21lbW9yeV9iYW5rIGluDQo+ID4gYWNx dWlyZV9zaGFyZWRfbWVtb3J5X2JhbmsuDQo+IA0KPiBJIGFtIE9LIHdpdGggdGhhdCBzbyBsb25n IGl0IGRvZXNuJ3QgaW52b2x2ZSB0b28gbXVjaCBkdXBsaWNhdGlvbi4NCj4gDQo+ID4+PiAgICAg ICAgQVNTRVJUKElTX0FMSUdORUQoKnBiYXNlLCBQQUdFX1NJWkUpICYmIElTX0FMSUdORUQoKnBz aXplLA0KPiA+Pj4gUEFHRV9TSVpFKSk7DQo+ID4+DQo+ID4+IEluIHRoZSBjb250ZXh0IG9mIHlv dXIgc2VyaWVzLCB3aG8gaXMgY2hlY2tpbmcgdGhhdCBib3RoIHBzaXplIGFuZA0KPiA+PiBwYmFz ZSBhcmUgc3VpdGFibHkgYWxpZ25lZD8NCj4gPj4NCj4gPg0KPiA+IEFjdHVhbGx5LCB0aGUgd2hv bGUgcGFyc2luZyBwcm9jZXNzIGlzIHJlZHVuZGFudCBmb3IgdGhlIHN0YXRpYyBzaGFyZWQNCj4g bWVtb3J5Lg0KPiA+IEkndmUgYWxyZWFkeSBwYXJzZWQgaXQgYW5kIGNoZWNrZWQgaXQgYmVmb3Jl IGluIHByb2Nlc3Nfc2htLg0KPiANCj4gSSBsb29rZWQgYXQgcHJvY2Vzc19zaG0oKSBhbmQgY291 bGRuJ3QgZmluZCBhbnkgY29kZSB0aGF0IHdvdWxkIGNoZWNrIHBiYXNlDQo+IGFuZCBwc2l6ZSBh cmUgc3VpdGFibGUgYWxpZ25lZCAoQVNTRVJUKCkgZG9lc24ndCBjb3VudCkuDQo+IA0KPiA+DQo+ ID4+PiArICAgIHJldHVybiB0cnVlOw0KPiA+Pj4gK30NCj4gPj4+ICsNCj4gPj4+ICtzdGF0aWMg bWZuX3QgX19pbml0IGFjcXVpcmVfc2hhcmVkX21lbW9yeV9iYW5rKHN0cnVjdCBkb21haW4gKmQs DQo+ID4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1 MzIgYWRkcl9jZWxscywgdTMyIHNpemVfY2VsbHMsDQo+ID4+PiArICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90ICpwYmFzZSwNCj4gPj4+ICtwYWRk cl90ICpwc2l6ZSkNCj4gPj4NCj4gPj4gVGhlcmUgaXMgc29tZXRoaW5nIHRoYXQgZG9lc24ndCBh ZGQtdXAgaW4gdGhpcyBpbnRlcmZhY2UuIFRoZSB1c2Ugb2YNCj4gPj4gcG9pbnRlciBpbXBsaWVz IHRoYXQgcGJhc2UgYW5kIHBzaXplIG1heSBiZSBtb2RpZmllZCBieSB0aGUgZnVuY3Rpb24uIFNv Li4uDQo+ID4+DQo+ID4NCj4gPiBKdXN0IGxpa2UgeW91IHBvaW50cyBvdXQgYmVmb3JlLCBpdCdz IGEgYml0IGhhY2t5IHRvIHVzZQ0KPiA+IGFjcXVpcmVfc3RhdGljX21lbW9yeV9iYW5rLCBhbmQg dGhlIHBvaW50ZXIgdXNlZCBoZXJlIGlzIGFsc28gZHVlIHRvDQo+ID4gaXQuIEludGVybmFsIHBh cnNpbmcgcHJvY2VzcyBvZiBhY3F1aXJlX3N0YXRpY19tZW1vcnlfYmFuayBuZWVkcyBwb2ludGVy DQo+IHRvIGRlbGl2ZXIgdGhlIHJlc3VsdC4NCj4gPg0KPiA+IEnigJlsbCByZXdyaXRlIGFjcXVp cmVfc2hhcmVkX21lbW9yeSwgYW5kIGl0IHdpbGwgYmUgbGlrZToNCj4gPiAiDQo+ID4gc3RhdGlj IG1mbl90IF9faW5pdCBhY3F1aXJlX3NoYXJlZF9tZW1vcnlfYmFuayhzdHJ1Y3QgZG9tYWluICpk LA0KPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHBh ZGRyX3QgcGJhc2UsIHBhZGRyX3QNCj4gPiBwc2l6ZSkgew0KPiA+ICAgICAgbWZuX3Qgc21mbjsN Cj4gPiAgICAgIHVuc2lnbmVkIGxvbmcgbnJfcGZuczsNCj4gPiAgICAgIGludCByZXM7DQo+ID4N Cj4gPiAgICAgIC8qDQo+ID4gICAgICAgKiBQYWdlcyBvZiBzdGF0aWNhbGx5IHNoYXJlZCBtZW1v cnkgc2hhbGwgYmUgaW5jbHVkZWQNCj4gPiAgICAgICAqIGluIGRvbWFpbl90b3RfcGFnZXMoKS4N Cj4gPiAgICAgICAqLw0KPiA+ICAgICAgbnJfcGZucyA9IFBGTl9ET1dOKHBzaXplKTsNCj4gPiAg ICAgIGlmICggZC0+bWF4X3BhZ2UgKyBucl9wZm5zID4gVUlOVF9NQVggKQ0KPiANCj4gT24gQXJt MzIsIHRoaXMgY2hlY2sgd291bGQgYWx3YXlzIGJlIHRydWUgYSAzMi1iaXQgdW5zaWduZWQgdmFs dWUgaXMgYWx3YXlzDQo+IGJlbG93IFVJTlRfTUFYLiBPbiBhcm02NCwgeW91IG1pZ2h0IGdldCBh d2F5IGJlY2F1c2UgbnJfcGZucyBpcw0KPiB1bnNpZ25lZCBsb25nIChzbyBJIHRoaW5rIHRoZSB0 eXBlIHByb21vdGlvbiB3b3JrcykuIEJ1dCB0aGlzIGlzIGZyYWdpbGUuDQo+IA0KPiBJIHdvdWxk IHN1Z2dlc3QgdG8gdXNlIHRoZSBmb2xsb3dpbmcgY2hlY2s6DQo+IA0KPiAoVUlOVF9NQVggLSBk LT5tYXhfcGFnZSkgPCBucl9wZm5zDQo+IA0KPiA+ICAgICAgew0KPiA+ICAgICAgICAgIHByaW50 ayhYRU5MT0dfRVJSICIlcGQ6IE92ZXItYWxsb2NhdGlvbiBmb3IgZC0+bWF4X3BhZ2VzOiAlbHUu XG4iLA0KPiA+ICAgICAgICAgICAgICAgICBkLCBwc2l6ZSk7DQo+ID4gICAgICAgICAgcmV0dXJu IElOVkFMSURfTUZOOw0KPiA+ICAgICAgfQ0KPiA+ICAgICAgZC0+bWF4X3BhZ2VzICs9IG5yX3Bm bnM7DQo+ID4NCj4gPiAgICAgIHNtZm4gPSBtYWRkcl90b19tZm4ocGJhc2UpOw0KPiA+ICAgICAg cmVzID0gYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoZCwgc21mbiwgbnJfcGZucywgMCk7DQo+ID4g ICAgICBpZiAoIHJlcyApDQo+ID4gICAgICB7DQo+ID4gICAgICAgICAgcHJpbnRrKFhFTkxPR19F UlINCj4gPiAgICAgICAgICAgICAgICAgIiVwZDogZmFpbGVkIHRvIGFjcXVpcmUgc3RhdGljIG1l bW9yeTogJWQuXG4iLCBkLCByZXMpOw0KPiA+ICAgICAgICAgIHJldHVybiBJTlZBTElEX01GTjsN Cj4gPiAgICAgIH0NCj4gPg0KPiA+ICAgICAgcmV0dXJuIHNtZm4NCj4gPiB9DQo+ID4gIg0KPiA+ DQo+ID4+PiArew0KPiA+Pj4gKyAgICAvKg0KPiA+Pj4gKyAgICAgKiBQYWdlcyBvZiBzdGF0aWNh bGx5IHNoYXJlZCBtZW1vcnkgc2hhbGwgYmUgaW5jbHVkZWQNCj4gPj4+ICsgICAgICogaW4gZG9t YWluX3RvdF9wYWdlcygpLg0KPiA+Pj4gKyAgICAgKi8NCj4gPj4+ICsgICAgZC0+bWF4X3BhZ2Vz ICs9IFBGTl9ET1dOKCpwc2l6ZSk7DQo+ID4+DQo+ID4+IC4uLiBpdCBzb3VuZHMgYSBiaXQgc3Ry YW5nZSB0byB1c2UgcHNpemUgaGVyZS4gSWYgcHNpemUsIGNhbid0IGJlDQo+ID4+IG1vZGlmaWVk IHRoYW4gaXQgc2hvdWxkIHByb2JhYmx5IG5vdCBiZSBhIHBvaW50ZXIuDQo+ID4+DQo+ID4+IEFs c28sIHdoZXJlIGRvIHlvdSBjaGVjayB0aGF0IGQtPm1heF9wYWdlcyB3aWxsIG5vdCBvdmVyZmxv dz8NCj4gPj4NCj4gPg0KPiA+IEknbGwgY2hlY2sgdGhlIG92ZXJmbG93IGFzIGZvbGxvd3M6DQo+ IA0KPiBTZWUgYWJvdmUgYWJvdXQgdGhlIGNoZWNrLg0KPiANCj4gPiAiDQo+ID4gICAgICBucl9w Zm5zID0gUEZOX0RPV04ocHNpemUpOw0KPiA+ICAgICAgaWYgKCBkLT5tYXhfcGFnZSArIG5yX3Bm bnMgPiBVSU5UX01BWCApDQo+ID4gICAgICB7DQo+ID4gICAgICAgICAgcHJpbnRrKFhFTkxPR19F UlIgIiVwZDogT3Zlci1hbGxvY2F0aW9uIGZvciBkLT5tYXhfcGFnZXM6ICVsdS5cbiIsDQo+ID4g ICAgICAgICAgICAgICAgIGQsIHBzaXplKTsNCj4gPiAgICAgICAgICByZXR1cm4gSU5WQUxJRF9N Rk47DQo+ID4gICAgICB9DQo+ID4gICAgICBkLT5tYXhfcGFnZXMgKz0gbnJfcGZuczsNCj4gPiAi DQo+ID4NCj4gPj4+ICsNCj4gPj4+ICsgICAgcmV0dXJuIGFjcXVpcmVfc3RhdGljX21lbW9yeV9i YW5rKGQsIE5VTEwsIGFkZHJfY2VsbHMsIHNpemVfY2VsbHMsDQo+ID4+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBwYmFzZSwgcHNpemUpOw0KPiA+Pj4gKw0KPiA+Pj4g K30NCj4gPj4+ICsNCj4gPj4+ICsvKg0KPiA+Pj4gKyAqIEZ1bmMgYWxsb2NhdGVfc2hhcmVkX21l bW9yeSBpcyBzdXBwb3NlZCB0byBiZSBvbmx5IGNhbGxlZA0KPiA+Pg0KPiA+PiBJIGFtIGEgYml0 IGNvbmNlcm5lZCB3aXRoIHRoZSB3b3JkICJzdXBwb3NlZCIuIEFyZSB5b3UgaW1wbHlpbmcgdGhh dA0KPiA+PiBpdCBtYXkgYmUgY2FsbGVkIGJ5IHNvbWVvbmUgdGhhdCBpcyBub3QgdGhlIG93bmVy PyBJZiBub3QsIHRoZW4gaXQNCj4gPj4gc2hvdWxkIGJlICJzaG91bGQiLg0KPiA+Pg0KPiA+PiBB bHNvIE5JVDogU3BlbGwgb3V0IGNvbXBsZXRlbHkgImZ1bmMiLiBJLmUgIlRoZSBmdW5jdGlvbiIu DQo+ID4+DQo+ID4+PiArICogZnJvbSB0aGUgb3duZXIuDQo+ID4+DQo+ID4+IEkgcmVhZCBmcm9t IGFzICJjdXJyZW50IHNob3VsZCBiZSB0aGUgb3duZXIiLiBCdXQgSSBndWVzcyB0aGlzIGlzIG5v dA0KPiA+PiB3aGF0IHlvdSBtZWFuIGhlcmUuIEluc3RlYWQgaXQgbG9va3MgbGlrZSB5b3UgbWVh biAiZCIgaXMgdGhlIG93bmVyLg0KPiA+PiBTbyBJIHdvdWxkIHdyaXRlICJkIHNob3VsZCBiZSB0 aGUgb3duZXIgb2YgdGhlIHNoYXJlZCBhcmVhIi4NCj4gPj4NCj4gPj4gSXQgd291bGQgYmUgZ29v ZCB0byBoYXZlIGEgY2hlY2svQVNTRVJUIGNvbmZpcm0gdGhpcyAoYXNzdW1pbmcgdGhpcw0KPiA+ PiBpcyBlYXN5IHRvIHdyaXRlKS4NCj4gPj4NCj4gPg0KPiA+IFRoZSBjaGVjayBpcyBhbHJlYWR5 IGluIHRoZSBjYWxsaW5nIHBhdGgsIEkgZ3Vlc3MuLi4NCj4gDQo+IENhbiB5b3UgcGxlYXNlIGNv bmZpcm0gaXQ/DQo+IA0KDQpJIG1lYW4gdGhhdCBhbGxvY2F0ZV9zaGFyZWRfbWVtb3J5IGlzIG9u bHkgY2FsbGVkIHVuZGVyIHRoZSBmb2xsb3dpbmcgY29uZGl0aW9uLCBhbmQNCml0IGNvbmZpcm1z IGl0IGlzIHRoZSByaWdodCBvd25lci4NCiINCiAgICAgICAgaWYgKCAob3duZXJfZG9tX2lvICYm ICFpc19zaG1fYWxsb2NhdGVkX3RvX2RvbWlvKHBiYXNlKSkgfHwNCiAgICAgICAgICAgICAoIW93 bmVyX2RvbV9pbyAmJiBzdHJjbXAocm9sZV9zdHIsICJvd25lciIpID09IDApICkNCiAgICAgICAg ew0KICAgICAgICAgICAgLyogQWxsb2NhdGUgc3RhdGljYWxseSBzaGFyZWQgcGFnZXMgdG8gdGhl IG93bmVyIGRvbWFpbi4gKi8NCiAgICAgICAgICAgIHJldCA9IGFsbG9jYXRlX3NoYXJlZF9tZW1v cnkob3duZXJfZG9tX2lvID8gZG9tX2lvIDogZCwNCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYWRkcl9jZWxscywgc2l6ZV9jZWxscywNCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgcGJhc2UsIHBzaXplLCBnYmFzZSk7DQoiDQoNClRCSCwg YXBhcnQgZnJvbSB0aGF0LCBJIGRvbid0IGtub3cgaG93IHRvIGNoZWNrIGlmIHRoZSBpbnB1dCBk IGlzIHRoZSByaWdodCBvd25lciwgb3IgYW0gSQ0KbWlzdW5kZXJzdGFuZGluZyBzb21lIHlvdXIg c3VnZ2VzdGlvbiBoZXJlPw0KIA0KPiBbLi4uXQ0KPiANCj4gPj4+ICsgICAgICAgIHByb3AgPSBk dF9maW5kX3Byb3BlcnR5KHNobV9ub2RlLCAieGVuLHNoYXJlZC1tZW0iLCBOVUxMKTsNCj4gPj4+ ICsgICAgICAgIGlmICggIXByb3AgKQ0KPiA+Pj4gKyAgICAgICAgew0KPiA+Pj4gKyAgICAgICAg ICAgIHByaW50aygiU2hhcmVkIG1lbW9yeSBub2RlIGRvZXMgbm90IHByb3ZpZGUNCj4gPj4+ICsg XCJ4ZW4sc2hhcmVkLQ0KPiA+PiBtZW1cIiBwcm9wZXJ0eS5cbiIpOw0KPiA+Pj4gKyAgICAgICAg ICAgIHJldHVybiAtRU5PRU5UOw0KPiA+Pj4gKyAgICAgICAgfQ0KPiA+Pj4gKyAgICAgICAgY2Vs bHMgPSAoY29uc3QgX19iZTMyICopcHJvcC0+dmFsdWU7DQo+ID4+PiArICAgICAgICAvKiB4ZW4s c2hhcmVkLW1lbSA9IDxwYmFzZSwgcHNpemUsIGdiYXNlPjsgKi8NCj4gPj4+ICsgICAgICAgIGRl dmljZV90cmVlX2dldF9yZWcoJmNlbGxzLCBhZGRyX2NlbGxzLCBzaXplX2NlbGxzLCAmcGJhc2Us ICZwc2l6ZSk7DQo+ID4+PiArICAgICAgICBBU1NFUlQoSVNfQUxJR05FRChwYmFzZSwgUEFHRV9T SVpFKSAmJiBJU19BTElHTkVEKHBzaXplLA0KPiA+Pj4gKyBQQUdFX1NJWkUpKTsNCj4gPj4NCj4g Pj4gU2VlIGFib3ZlIGFib3V0IHdoYXQgQVNTRVJUKClzIGFyZSBmb3IuDQo+ID4+DQo+ID4NCj4g PiBEbyB5b3UgdGhpbmsgYWRkcmVzcyB3YXMgc3VpdGFibHkgY2hlY2tlZCBoZXJlLCBpcyBpdCBl bm91Z2g/DQo+IA0KPiBBcyBJIHdyb3RlIGJlZm9yZSwgQVNTRVJUKCkgc2hvdWxkIG5vdCBiZSB1 c2VkIHRvIGNoZWNrIHVzZXIgaW5wdXRzLg0KPiBUaGV5IG5lZWQgdG8gaGFwcGVuIGluIGJvdGgg ZGVidWcgYW5kIHByb2R1Y3Rpb24gYnVpbGQuDQo+IA0KPiA+IElmIGl0IGlzIGVub3VnaCwgSSds bCBtb2RpZnkgYWJvdmUgQVNTRVJUKCkgdG8gbWZuX3ZhbGlkKCkNCj4gDQo+IEl0IGlzIG5vdCBj bGVhciB3aGF0IEFTU0VSVCgpIHlvdSBhcmUgcmVmZXJyaW5nIHRvLg0KPiANCg0KRm9yIHdoZXRo ZXIgcGFnZSBpcyBhbGlnbmVkLCBJIHdpbGwgYWRkIHRoZSBiZWxvdyBjaGVjazoNCiINCiAgICAg ICAgaWYgKCAhSVNfQUxJR05FRChwYmFzZSwgUEFHRV9TSVpFKSB8fCAhSVNfQUxJR05FRChwc2l6 ZSwgUEFHRV9TSVpFKSB8fA0KICAgICAgICAgICAgICFJU19BTElHTkVEKGdiYXNlLCBQQUdFX1NJ WkUpICkNCiAgICAgICAgew0KICAgICAgICAgICAgcHJpbnRrKCIlcGQ6IHBoeXNpY2FsIGFkZHJl c3MgJWx1LCBzaXplICVsdSBvciBndWVzdCBhZGRyZXNzICVsdSBpcyBub3Qgc3VpdGFibHkgYWxp Z25lZC5cbiIsDQogICAgICAgICAgICAgICAgICAgZCwgcGJhc2UsIHBzaXplLCBnYmFzZSk7DQog ICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCiAgICAgICAgfQ0KIg0KRm9yIHdoZXRoZXIgdGhl IHdob2xlIGFkZHJlc3MgcmFuZ2UgaXMgdmFsaWQsIEkgd2lsbCBhZGQgdGhlIGJlbG93IGNoZWNr Og0KIg0KICAgICAgICBmb3IgKCBpID0gMDsgaSA8IFBGTl9ET1dOKHBzaXplKTsgaSsrICkNCiAg ICAgICAgICAgIGlmICggIW1mbl92YWxpZChtZm5fYWRkKG1hZGRyX3RvX21mbihwYmFzZSksIGkp KSApDQogICAgICAgICAgICB7DQogICAgICAgICAgICAgICAgcHJpbnRrKCIlcGQ6IGludmFsaWQg cGh5c2ljYWwgYWRkcmVzcyAlIlBSSV9wYWRkciIgb3Igc2l6ZSAlIlBSSV9wYWRkciJcbiIsDQog ICAgICAgICAgICAgICAgICAgICAgIGQsIHBiYXNlLCBwc2l6ZSk7DQogICAgICAgICAgICAgICAg cmV0dXJuIC1FSU5WQUw7DQogICAgICAgICAgICB9DQoiDQo+IENoZWVycywNCj4gDQo+IC0tDQo+ IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Mon Jul 04 07:22:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 07:22:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359871.589127 (Exim 4.92) (envelope-from ) id 1o8GPx-0000aN-Lu; Mon, 04 Jul 2022 07:22:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359871.589127; Mon, 04 Jul 2022 07:22:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GPx-0000aG-IN; Mon, 04 Jul 2022 07:22:49 +0000 Received: by outflank-mailman (input) for mailman id 359871; Mon, 04 Jul 2022 07:22:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GPv-0000a7-Kb for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 07:22:47 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19c7d9e2-fb6a-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 09:22:46 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id mf9so15228619ejb.0 for ; Mon, 04 Jul 2022 00:22:46 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id fx24-20020a170906b75800b006fec63e564bsm13683384ejb.30.2022.07.04.00.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Jul 2022 00:22:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19c7d9e2-fb6a-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W7YDdS7cjUx0VeNQiCyXscCuJSurWL9ZQnO4IEhpQWM=; b=c0V7/j4xE13urslFTKrUYRpl8SvXaK1EbAWXNgPfKKCdn1m3CqrIRNku+IP1yNgx7B Cnvcy8VyFNVIs1OwXLmMhouxonJzAIqi4f8p4xILinf3cAC/T6hPcwhYWZ8i21IkGtLK /9gSbhJPEF5eDQgkW/4qNt+AvEGsNxXxlcjByq+qZKlHmft6OoCwWd6sfushcGFs2esH LxKsPOpqQAIp1W8bNa2yeg8+zJcKfj3m/+/ASlSzz3WnfUXu5S0pagvsrYMydJ25LHyB +6/YPrB3cjidR1x2dYI0PlrIpz+eQBUs8IyPTn9yQQneMimVCSJygKMOISIkiXKoU8pm D82Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=W7YDdS7cjUx0VeNQiCyXscCuJSurWL9ZQnO4IEhpQWM=; b=dQXDDW5M2ZwOcgBX3mcdiF7lfYk7tIHV8y7kJf0W4ahc93/pKJJClNaX+j6OVDtEpE CtdA4yaanOCXjZhlxQPp58nJILG4Y7zo9do8B79Os40yzkE07QpDvCCJrM2FaCG+tPc3 Slntw39Gbhl/nj9hnLbyc4FVIggh1Ah54O1FNVmeJ1L/HwyfK5FJU6AH2vugZNhX5WJ+ 0sKxxYP455CPKjr/UOyd9TzrnSqxX6vdBo7fxB/vE+OFEUBoNNL9/g2yracORAK9iRbp EbXxz6L3K03jAcDDrgvCqE/AHFlWkyhAdJww0b/IgX0fcOTLXplPC1RuFo5LEmCtWd5l DSjA== X-Gm-Message-State: AJIora9OyI4UxuSVmHYs2fviTwPnC1RyavtHSdccYEjXvXS/GcJ0iL4S WIdt3vQ0iLThHkwgkVXDadcnRkfWZxg= X-Google-Smtp-Source: AGRyM1u+xmxnIHVyHN3+BKTKgxlcsrJOr6Br6d0UvVKoxZZWhnT7b4ReL796HzG/D26Hgdi1HwvfJw== X-Received: by 2002:a17:906:5a69:b0:72a:666d:822d with SMTP id my41-20020a1709065a6900b0072a666d822dmr21068761ejc.290.1656919365460; Mon, 04 Jul 2022 00:22:45 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Xenia Ragiadakou , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Date: Mon, 4 Jul 2022 10:22:32 +0300 Message-Id: <20220704072232.117517-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The functions show_registers() and show_stack() are referenced only in traps.c. Change their linkage from external to internal by adding the storage-class specifier static to their definitions and by removing show_registers() from asm/processor.h header file. Also, this patch resolves a MISRA C 2012 Rule 8.4 violation warning about the function show_stack(). Signed-off-by: Xenia Ragiadakou --- I am not 100% sure about this patch. I think show_stack() should be declared the same way as show_registers(). So either both of them will be declared with external linkage or both of them will be declared with internal linkage. I decided to declare both of them static because they are referenced only in traps.c but I could have, also, add the declaration of show_stack() in asm/processor.h header instead. Rule 8.7 is advisory. xen/arch/arm/include/asm/processor.h | 1 - xen/arch/arm/traps.c | 4 ++-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 4188ec6bfb..75c680ae9a 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -558,7 +558,6 @@ extern register_t __cpu_logical_map[]; void panic_PAR(uint64_t par); void show_execution_state(const struct cpu_user_regs *regs); -void show_registers(const struct cpu_user_regs *regs); //#define dump_execution_state() run_in_exception_handler(show_execution_state) #define dump_execution_state() WARN() diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c index 785f2121d1..9398ceeed5 100644 --- a/xen/arch/arm/traps.c +++ b/xen/arch/arm/traps.c @@ -931,7 +931,7 @@ static void _show_registers(const struct cpu_user_regs *regs, printk("\n"); } -void show_registers(const struct cpu_user_regs *regs) +static void show_registers(const struct cpu_user_regs *regs) { struct reg_ctxt ctxt; ctxt.sctlr_el1 = READ_SYSREG(SCTLR_EL1); @@ -1146,7 +1146,7 @@ static void show_trace(const struct cpu_user_regs *regs) printk("\n"); } -void show_stack(const struct cpu_user_regs *regs) +static void show_stack(const struct cpu_user_regs *regs) { register_t *stack = STACK_BEFORE_EXCEPTION(regs), addr; int i; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 07:41:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 07:41:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359879.589138 (Exim 4.92) (envelope-from ) id 1o8Gi6-00034t-7j; Mon, 04 Jul 2022 07:41:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359879.589138; Mon, 04 Jul 2022 07:41:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Gi6-00034m-4X; Mon, 04 Jul 2022 07:41:34 +0000 Received: by outflank-mailman (input) for mailman id 359879; Mon, 04 Jul 2022 07:41:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Gi4-00034g-UU for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 07:41:33 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30076.outbound.protection.outlook.com [40.107.3.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b88ccaa1-fb6c-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 09:41:31 +0200 (CEST) Received: from AS9P250CA0018.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::21) by PAXPR08MB6988.eurprd08.prod.outlook.com (2603:10a6:102:200::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 07:41:29 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::d6) by AS9P250CA0018.outlook.office365.com (2603:10a6:20b:532::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Mon, 4 Jul 2022 07:41:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 07:41:28 +0000 Received: ("Tessian outbound 514db98d9a19:v121"); Mon, 04 Jul 2022 07:41:28 +0000 Received: from 898169eada01.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24DBA0AC-BC38-4424-9F8B-81F2FC773353.1; Mon, 04 Jul 2022 07:41:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 898169eada01.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 07:41:22 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by GV2PR08MB8099.eurprd08.prod.outlook.com (2603:10a6:150:7d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Mon, 4 Jul 2022 07:41:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Mon, 4 Jul 2022 07:41:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b88ccaa1-fb6c-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HlCJhP5afByl/2EQVFqQ+/tdEB62vei1sR9iP5kCvyUlPgBnCmvBY/WBcyJgpaqnIM2h1VmoUOhtTKbvXXsOw+xLOtIn5YoEvybbzrbj7paVVrK6Y7Jq3QbmJdfqnOadelvCdKxtzhfNY8WnOkYMWXFS5pFyUsdg5JsR4szIvcK7VF/3h8kElpVKI+ShOHqy7lob2+NcQBY3nptFsCOEA1h3EhDKxSLCk4VkXAmtI2SqkYH2/paEi84eA0XY2gTcAb8smJE9WMWxwOilIRWpLeX7EyYECvFKgVv4p1IJDzft4/cdM5l/SZZxyG5unjQRYGbo03THY/X/cFPBJaCfLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7UPOhzPV33OghZIqesvi+kHzrRT/L2wAe/j2XuIUoak=; b=Dc9P4xjyQiyLWbV1XskyKTHYuovpyc3YdysMMO1pqRwYnVH6Y8YWAqEL8seujq9Iji9KXAA+EvEkXwL0yH6YC/e+7gRzcKB2GNM4quk4eqON6T3Um0dJUPrzzsaZGMnFG+OJn8CcaRYudhpMe5OLAOqYPggJE2+huDB9755jCJtsb5Dv7MsTMsvquwZWpwyLMXzZACTSHRTpNKSZ6fBI8z644J4rJBU2IShpEggXNBxTSqmzKC4wnqzsNKai1dOcARda0WxGTJjKWTDIk2Xqt67BvsTTRwmvoCZ8LWh0+vpNa8bC1Wm8jVF8W0B3y34IYo1D6X5aD2LUgwBrETTbmw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UPOhzPV33OghZIqesvi+kHzrRT/L2wAe/j2XuIUoak=; b=rrcMAqoNq6Buvt8erY8Yj0IwVTZ6O179+bnvSMbQDXBJi2z1ltim/nqUCDiqAnqgxq9oZncil1Kd4QjgwTooSr9Nu+c1g+b1jhMFfvaU7tr9grw3nwhLSpGEfmXtrW0IxRNRrNAIKwN9rWHeAsRORAUu7YsO1QzNhJcboYY09Aw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 85a90d0a167cd021 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FUM4T7afCwwKOohvnvwbJ0WbM0EAWpclP7tkfNY1UqsErOiFwpml0MTTnUrMvfDIw4TgmBdugEvpVEQRi+FFv9AZA36EyaUv9l7wInYZWVT4oJWZtiYAHHnkaKuorEOKIQtxQkqZn1TOgtcOo/QBJRpf2Ebu60hsRXuGcV4zRf7D6iqRfhaOqfaHgbO924Rdgty3hhi8581IfJ+z9jSwJ2mP8tXWFpm8ghCAJ36p65vSMd8gDrju36KCtSncApugA8E+ZmE0XTp26eebmxWvkJCAJcJxLTS6YVS36bG8gofqZz7QQTiYGiIYxbpoi79Q2TN7epXqacBLAqWzCltiSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7UPOhzPV33OghZIqesvi+kHzrRT/L2wAe/j2XuIUoak=; b=IcVrKMhfBOgC6vjDwnx7xiAQNqPj8F2165gMujuLtpckLR28CcDUPS+g2SdohrnBq9KubF7BrNTu4HWT9TTuiIyjQcpCGT3DOinvaq4JMZhZ8+bXNkIzNCDBXMQnjOUypPZLuR2iLYa53exCuOGt1oXN21B0Elnw421acFivI68pZ7zgajoyVhrDZUHfs+rWZsAXArnlLaMZDuKtIF76RD5I5DHWNawvlI35+W4g6K7j0xUT2dN6fgxHBv9dg1kO1cKENZicLtDlE3MehyjgroGSjcprme5gfKWm2TBJo99DNGOiSI6uAR+3px+8rDend9YTqwT+5HLbg23T3LlK+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UPOhzPV33OghZIqesvi+kHzrRT/L2wAe/j2XuIUoak=; b=rrcMAqoNq6Buvt8erY8Yj0IwVTZ6O179+bnvSMbQDXBJi2z1ltim/nqUCDiqAnqgxq9oZncil1Kd4QjgwTooSr9Nu+c1g+b1jhMFfvaU7tr9grw3nwhLSpGEfmXtrW0IxRNRrNAIKwN9rWHeAsRORAUu7YsO1QzNhJcboYY09Aw= From: Bertrand Marquis To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYj3bjMrWoDl4sYkqZXzEqwsl1S61t0/kA Date: Mon, 4 Jul 2022 07:41:20 +0000 Message-ID: References: <20220704072232.117517-1-burzalodowa@gmail.com> In-Reply-To: <20220704072232.117517-1-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6349b243-6b6f-4cdf-609b-08da5d909b15 x-ms-traffictypediagnostic: GV2PR08MB8099:EE_|AM5EUR03FT030:EE_|PAXPR08MB6988:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Fcy/CVRPkSNMTuzrZfwxcj+0OqWfnnb8QKoU4g6lHBHV1x3q0EJfjA7hmvCaiQBORVwzRYnrRhMAIhqk69c+BI6BU7yr2NngfE/pwmdGh/YDCjO8u71cQU/3g/AbcRqRihW9de64cKAOrBNti+HV//aYtoZEoAQGyqAA6gSwnCGkJJSLAXH4gBZAEcNachVi/ii7JpxktSLt8boS60ch1J5hxq71mLVXdexsBHfOxQMN7kwYHPowhSCNnrvL5qmkhuagCYO24e3zVzUYyAVv1YiJ/v9b87fWzTuQl5LqddxXHKxV1aMz+LlHUPr1qhgGDm+ejwriJ6DQ0VX2rpzsKJv2ZMWH7Pvm0gc2T/uxXqyIPj79Mp5oku/S3n9mWYfoFMqMmhvlKfBAMPNbe5E7XoySZnFX1VxxeePNhHunDn1/x/T2AJ7w30gP//A0ZRaTK1GeTgAEoZkS/xIxbxWOCuOmR+PnhkRWMetzLMPcptCkjZCRQQSLA1lxw+CjfBRXXiG3VpZfNUkh+ETO/s4xG7uip8bBJvLu69QQ6kgf5+5k4zKwXPa5Zsy0K7LgPCkbsJoZnVKk9yOXgAtbA7UEhNMeKDuutrW5WGXCXd4WU6BUMJizYgBpG7BjOV9sm7H9UHzj/ght2jtGyqW2QvN3la+8oS2tql6c5kQeAVun3qrOYrYp4f6ORQd4XECYeIGiu3mHv+KbeMxlD/2h+X7EIDsPujLWaie+L4mtAVFgHZH252bv+PuOasFzzLd04NHpM0UmXullNT46mW2h6iMt76GdoJpfcxZEALdak8gUz9EKSmU8DULyqe8JK2UiMEbkAXIxSQS0T+zqW/Y4zixXfooDi/btHEG6wRsOvfkUvxA= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(136003)(39860400002)(376002)(346002)(86362001)(83380400001)(38070700005)(122000001)(38100700002)(8936002)(54906003)(36756003)(71200400001)(6916009)(33656002)(66556008)(8676002)(4326008)(66446008)(64756008)(66476007)(66946007)(76116006)(6486002)(91956017)(316002)(26005)(2906002)(2616005)(186003)(6512007)(5660300002)(6506007)(478600001)(53546011)(41300700001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8099 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2756db60-aa7c-463c-0787-08da5d909654 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QY3jETHQ1XGPCX7daW9PUISiS+rkLe75G3TSpCJoHVSM1zqaSxrR8B7KRdkQ33Ta4mK98TbqYeNWNpskLUl/Qly20LLWN3K6XsJ11XZh5EXPkz0MCT6nwLgfTExfBHS2vL+EUK09P2oh6xHuB/d67PPTmDXkSMZC8mTYyTlUomBLmIjD+PIMuh9wX3BSOAmcJpiZ+tPJZ487HmM9a5h8RJzlcrJN5DdmWZ0FrerPvatShznXM7VlBd8pmE9JpEwigrG+hQnL0I9/v9/sv5qxW3tWhRxxFknu13J5k+cGb4U0LUOQKYRxm2p9apu/BQfgUYeOpKDS6Mzkd5CyeE0ByCgKPmskYfz5SF6bbVIkNMqcsy8mYFJ5KvG7j/vWEUTwPazImQIFReoUlHKz2TpYxDD3ULAZnWy42Nu5Y+E9zLFFB18IZfnOPRSwfbhr6rNvjS16qs8ZaqnHQ5W+dVB+bitW2yGZ7d9OFgj0hnWveTa9si1omBMYoM28Bs2CDtNFGA23b3Ui7FXQ1U4J9PaJJzf7MhGZ19/KUTob/t83QDNv0NG2JXGHQSKnai4JMYFdf3LwSTjlLW5gmPWc6ei7JmLAclQ66nFHGsB8xy9SyDM0RnbliAqyh1H1Wsf4eJsTAJgejO2TGxtt4lXpcGub9bOK/RC8sIlTm1yBeKsvjO3a45SkY6sKkEkjuCg+/2FVG7luJQkuBMMvCs+hpsMFU4eM8C48x5+Lur0TqywOp+Xr4kOTWjGqU5zDzPYYWlFF6wCmztUfE6cgqpoDXj+Ec48JlIxhMCt1uBvPWa2+q9vX0qtdY+h/l714/WPJ6dgS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(6486002)(86362001)(478600001)(26005)(4326008)(6512007)(53546011)(6506007)(316002)(70586007)(70206006)(40460700003)(8676002)(54906003)(82310400005)(41300700001)(36860700001)(82740400003)(81166007)(356005)(2616005)(186003)(107886003)(336012)(47076005)(83380400001)(5660300002)(40480700001)(6862004)(33656002)(2906002)(8936002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 07:41:28.4264 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6349b243-6b6f-4cdf-609b-08da5d909b15 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6988 Hi Xenia, > On 4 Jul 2022, at 08:22, Xenia Ragiadakou wrote: >=20 > The functions show_registers() and show_stack() are referenced only in tr= aps.c. > Change their linkage from external to internal by adding the storage-clas= s > specifier static to their definitions and by removing show_registers() fr= om > asm/processor.h header file. >=20 > Also, this patch resolves a MISRA C 2012 Rule 8.4 violation warning about= the > function show_stack(). >=20 > Signed-off-by: Xenia Ragiadakou > --- > I am not 100% sure about this patch. > I think show_stack() should be declared the same way as show_registers(). > So either both of them will be declared with external linkage or both of = them > will be declared with internal linkage. I think that those 2 should be declared with external linkage with a commen= t explaining why they are. For me those are useful when developing or debuggi= ng and I sometime call those to force dumping the status. So I would vote to keep the external linkage. > I decided to declare both of them static because they are referenced only= in > traps.c but I could have, also, add the declaration of show_stack() in > asm/processor.h header instead. Rule 8.7 is advisory. As said I would vote for external linkage here but would be nice to have ot= her developers view on this. Cheers Bertrand >=20 > xen/arch/arm/include/asm/processor.h | 1 - > xen/arch/arm/traps.c | 4 ++-- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/= asm/processor.h > index 4188ec6bfb..75c680ae9a 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -558,7 +558,6 @@ extern register_t __cpu_logical_map[]; > void panic_PAR(uint64_t par); >=20 > void show_execution_state(const struct cpu_user_regs *regs); > -void show_registers(const struct cpu_user_regs *regs); > //#define dump_execution_state() run_in_exception_handler(show_execution_= state) > #define dump_execution_state() WARN() >=20 > diff --git a/xen/arch/arm/traps.c b/xen/arch/arm/traps.c > index 785f2121d1..9398ceeed5 100644 > --- a/xen/arch/arm/traps.c > +++ b/xen/arch/arm/traps.c > @@ -931,7 +931,7 @@ static void _show_registers(const struct cpu_user_reg= s *regs, > printk("\n"); > } >=20 > -void show_registers(const struct cpu_user_regs *regs) > +static void show_registers(const struct cpu_user_regs *regs) > { > struct reg_ctxt ctxt; > ctxt.sctlr_el1 =3D READ_SYSREG(SCTLR_EL1); > @@ -1146,7 +1146,7 @@ static void show_trace(const struct cpu_user_regs *= regs) > printk("\n"); > } >=20 > -void show_stack(const struct cpu_user_regs *regs) > +static void show_stack(const struct cpu_user_regs *regs) > { > register_t *stack =3D STACK_BEFORE_EXCEPTION(regs), addr; > int i; > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 07:45:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 07:45:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359884.589149 (Exim 4.92) (envelope-from ) id 1o8Glp-0003gU-Oc; Mon, 04 Jul 2022 07:45:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359884.589149; Mon, 04 Jul 2022 07:45:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Glp-0003gN-Kt; Mon, 04 Jul 2022 07:45:25 +0000 Received: by outflank-mailman (input) for mailman id 359884; Mon, 04 Jul 2022 07:45:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Glo-0003gF-D8 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 07:45:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70070.outbound.protection.outlook.com [40.107.7.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 429261a6-fb6d-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 09:45:23 +0200 (CEST) Received: from AM5PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:206:1::27) by HE1PR0802MB2604.eurprd08.prod.outlook.com (2603:10a6:3:db::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 07:45:20 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::b1) by AM5PR04CA0014.outlook.office365.com (2603:10a6:206:1::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Mon, 4 Jul 2022 07:45:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 07:45:20 +0000 Received: ("Tessian outbound 4748bc5c2894:v121"); Mon, 04 Jul 2022 07:45:19 +0000 Received: from bed862a63e97.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C0D5A5CF-12F0-4745-A68E-7DC998581703.1; Mon, 04 Jul 2022 07:45:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bed862a63e97.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 07:45:13 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR08MB3406.eurprd08.prod.outlook.com (2603:10a6:803:7b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Mon, 4 Jul 2022 07:45:09 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%6]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 07:45:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 429261a6-fb6d-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oAtUZJmPuUmcyDNoySdhgn+d5aI1mMR0TdjH7cH4tVztTScfKIcSwXWTbSjR18QkMnaL8xhte1ZST0mLECdJ3etZq213QXbHGCugituJnmZQLEWE+WN8tqwmvJ3tbLu00uQjKAe1E9MsrjlIqZfAbf/z+ofP+DhZ2Qc9HUYA4LxSurXNn/CRvqJ7HqLO1ufD0TacwgGmyM5/GZ0f0HvHuims2Hcy5s20WiwR4BAnBzbDeNq9/W7nWOhsQ/c7uqZ5q+VgTyYdw2NLmX+KA4dR3JRX7B1rw5nhOzJYh4WvZ6LEEtE+26E/szmYwctYPhL/WMFjSLHBvajmiEa4sh6U3Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8FmYl87tvZLpRtZjpyus40w4spZQF0EdNwJFRPaW4w=; b=n/oj062YGCDBrKKYvfbAAwky7UvWmT9zpHraUwg28Q/JqGAzItCUylgejR3Ok68IE9vhKTUsbuHq767LWyijUnu14MZ99CoQhfTjK355jnMr/cO2D86i/7bGtDnZvvPqslSi6dKy0xsnJBJy4XLGHjVIl4M3nzcDwt1HKHJ7M57ooK9VJRiNfa3XFvOOtO837QGYVBlKgFiMIHHX9QIndxKL69NJzytBJpn0rDtZLBqqaVGtj3Tng01inZZ9SgjraxMQBztqiP/Hw9XQH3/Uugo7wYf+TS9pAmRpc+5ZYT+ofTtnGQUtIoA051pvHwVyWE33paPHtuHvMBRcK+Zi5A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8FmYl87tvZLpRtZjpyus40w4spZQF0EdNwJFRPaW4w=; b=fiMQdHL5BFoCYtMCccldad7f6rp4nCtWYY9ZcKaX9Bk/PHsFou8S0JOGy6wj2A8pX0fgs6L2YV3sTowKExJxEZRJ7XYiefMoY+bcfgeyNbXa+Kb2Lpz4pBgn9QWZd93XyXPaAb78cG0bmgoh/UoCfbzkrqoFk2HwlAeq/C6spgU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E/M2UoL1jnVsMfAC7HJy7FWey2EYMzk33YSvB+l9oV8oBmV539Pl/a4JG/yFLsmY+IQYCH83wWKq+5BAfjbY85j1c63hCaiduyE7u2C8Z91z1lPUZA48OlsaqSz7mwstT91OD/pDjDtI6URBhTMcQWS4M77XH9kqbzlkKSd2ih4zc+AXsrzvZJtiHoi0lHZBk+hFdIqi98c6NWrt4N2kSrlUVYWEPVdSwzlZJZKP5/jNrXyc89c/bWXH8evkghujDS8xkg7zSVhI26cjBfT7vVTlGf62iuaeQTcdjGdbebr3fYhKazjbd///tup8bDxhyZwfl2E088tRIn8eKNnZ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X8FmYl87tvZLpRtZjpyus40w4spZQF0EdNwJFRPaW4w=; b=NToPHy6BLtAM5en2DDlUZuRf+e6HNBpJ/tmwgv8P8A3Niqkw+/Z3zW2w17JPqAO0pTsfIB7bwl8Hhsbl/5KJ339z6KhDBpMOPsrG6D0laebStRkyA9dewHFBiJyH9VWK7HiN0y5d0nze18XVAbnToWhJ/ByFV4KYWnLUAsq2zBEAkQrwHjzPjvzy5EBgyR4ntCpEX47/gZnkCfEQHC6ERo9LAm1Bua5KKE1/a6Odts36gMdolB0NGcGorB03FbcJAj83zHGB9eWUeZsf+Qs8xok+yWy8DNaZx2QCppTY35KOkyM4MxLocEdndkLVkQ8D0wvsKKxFkYdU3Dd5lCJTEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X8FmYl87tvZLpRtZjpyus40w4spZQF0EdNwJFRPaW4w=; b=fiMQdHL5BFoCYtMCccldad7f6rp4nCtWYY9ZcKaX9Bk/PHsFou8S0JOGy6wj2A8pX0fgs6L2YV3sTowKExJxEZRJ7XYiefMoY+bcfgeyNbXa+Kb2Lpz4pBgn9QWZd93XyXPaAb78cG0bmgoh/UoCfbzkrqoFk2HwlAeq/C6spgU= From: Penny Zheng To: Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYhGRGiM2+sN9ON0uL+hMDdx46E61e+NuAgAApAYCADsZBcA== Date: Mon, 4 Jul 2022 07:45:08 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 27CB1241F8AC344DBBE19E8F30897D51.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d25eb81f-3042-42b4-55e8-08da5d912523 x-ms-traffictypediagnostic: VI1PR08MB3406:EE_|AM5EUR03FT040:EE_|HE1PR0802MB2604:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GhkD9VZ/iV+70Dne9dQ249Z+4vTWy/orXDb5cotE61v8BnWWiYr9uRcYjP5I28c9DgrGB+HXEF8Mb0YqJ0YzZwNTmJFaLtFF3EqrcLolyKOscDdvy+b85f4BiAJloe9kavAREDTWiKK8NCHdrkftpfuXMdxKlOYtbmQY8maLBkyKRP5v8uljvIWg28Yxwf3tCwJjOaU/ujoPiYLM7DcFzjbpriRoHyq/Fcu8J+IJOPenhePiwwuDs4GhxAyoVwQscDi/a6Q6Kt67yYb7fEob6u2ZZIu3lC+i5wWYd+zjE3oyqCW1FIY/n3w3EE3rxeadBli94Ip3gJmGBNjXCXTc4NHzntoY21tn3Vb6TTaKzGxt5vwT62Ks+vf8LPZYcjT73o+OY/W2RPxVszF1aP4B+iGvqsJzgLBr/l9Xuwm+GWO8WPlfsriGvAX7894bGrbyZD4oLimZVSLq5whHzY8xeFwHs7TOFKhgdaYJMg3YhqRb4Zdj7cwPVrefU+ya+npjFsrcbgKncn6W2Ep6b0a6AzOoC6fIi3B0i3AV+e5lNMVy6OLU7vMfy6O5oNvO4BxK6gyBJt1oaeTEMzZc0AjQRyouapro7uu6Hg5yXdMn25DyqFGSyCs5B7lGW+al5JSLD4qMIfuhBPwfFJ18DqRV/WADs46qGGpT9O8Bsz8x3kUW+PFbFsV+qWMZfWA56b5IvvO0t7WZQYvCUdbRoQu8Td9rrSnXIecdrb5dQeVOKZfTWxc/lRS6ocoUjyLlD7y7QgNt0hCUR6gGzC4xq0QdloIpBopxhMsL26EkcxEeKPMc+vcGtozSBWfc6palV532 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(366004)(39850400004)(41300700001)(83380400001)(52536014)(7696005)(86362001)(6506007)(8936002)(186003)(5660300002)(2906002)(76116006)(66556008)(122000001)(55016003)(38070700005)(478600001)(33656002)(38100700002)(64756008)(66946007)(4326008)(8676002)(66446008)(66476007)(316002)(9686003)(26005)(53546011)(71200400001)(54906003)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3406 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d5bd4969-adf9-41fa-90c3-08da5d911e34 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1S7FVK7KxU77b0hTyV4h84SEdPIJ3VrXrCy8RIWtaVYlaERCv/+00HhGP48aPwg6crATVqtbItjOEKYSuXmqT1taYADi1/Nym5NBdJhIqFeo2G7z6Z/RJr5wC79p6V2XiLwDkGwfN92GOL6V5+pFeo/xTqKUZwAL1FgGz6zYzMuv6z45Rt2uTgYnvqmy8XAA3j3kDEhBh94qZ1DKVQdQ6V17x0SIX25iE9Mr37MHIn5tuo2BO0aYyoWvhPq6yJHg1TbScp7uyqzgBBx0YiG071e2Zj8/AW1A8kcpqEuWvw5W596YMOL67+k2SxLgPDcnEMephf+wFz/t7z+yHEHoJ4vNHeF1omXYDCLDm7k83EH6N9puCk78cGL99YX4o6Ua80BkO+iqUkDn3kPmWKS606KWsgKikrtFW0LkAWCCRk1TPsr59Uftshr7BrRFkUVRXwcMMXPGoKDwfjXyxqt7xUnTgMnLm2gsLfrqUXJ2QceMPRWvrJLuDL975RiCCHlGkewy92AdMj1N5FWT18H5Prhcep4Z443O0/EjBUvcdQbGT5cygnBD4f+3xVPJUCOXmMzh3q6ODJfaCXVapzAwpo4dPsO2rngliqU2DkxzAoWbYeCBeN6trCyIDdxp+vosrR3aVs/Bl/QKLSt+NUA/8C1gBRhG6Q7IdGGcJppvLQxLOe7118QrDSrxrIDLTxSIlAm/o44WgCL2b3O0uPooLh7XRwnakLdA8PTzYPOoFBerkvOQJkims80OVsJ/9ivI9Vuy6/Uh9TtRaK3lVGrqtuXH2G0zzLS573/ZUbZ12DK+f+f0xbDNehdn6izkb/fZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(36840700001)(46966006)(40470700004)(54906003)(81166007)(110136005)(2906002)(316002)(6506007)(8936002)(52536014)(82740400003)(8676002)(4326008)(356005)(7696005)(5660300002)(70206006)(9686003)(26005)(83380400001)(53546011)(70586007)(107886003)(186003)(40460700003)(336012)(47076005)(478600001)(41300700001)(36860700001)(86362001)(33656002)(55016003)(40480700001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 07:45:20.0122 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d25eb81f-3042-42b4-55e8-08da5d912523 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2604 Hi Stefano and Julien > -----Original Message----- > From: Stefano Stabellini > Sent: Saturday, June 25, 2022 5:57 AM > To: Julien Grall > Cc: Penny Zheng ; xen-devel@lists.xenproject.org; > Wei Chen ; Stefano Stabellini > ; Bertrand Marquis ; > Volodymyr Babchuk > Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest > device tree >=20 > On Fri, 24 Jun 2022, Julien Grall wrote: > > On 20/06/2022 06:11, Penny Zheng wrote: > > > We expose the shared memory to the domU using the "xen,shared- > memory-v1" > > > reserved-memory binding. See > > > Documentation/devicetree/bindings/reserved-memory/xen,shared- > memory. > > > txt in Linux for the corresponding device tree binding. > > > > > > To save the cost of re-parsing shared memory device tree > > > configuration when creating shared memory nodes in guest device > > > tree, this commit adds new field "shm_mem" to store shm-info per > > > domain. > > > > > > For each shared memory region, a range is exposed under the > > > /reserved-memory node as a child node. Each range sub-node is named > > > xen-shmem@
and has the following properties: > > > - compatible: > > > compatible =3D "xen,shared-memory-v1" > > > - reg: > > > the base guest physical address and size of the shared > > > memory region > > > - xen,id: > > > a string that identifies the shared memory region. > > > > > > Signed-off-by: Penny Zheng > > > Reviewed-by: Stefano Stabellini > > > --- > > > v5 change: > > > - no change > > > --- > > > v4 change: > > > - no change > > > --- > > > v3 change: > > > - move field "shm_mem" to kernel_info > > > --- > > > v2 change: > > > - using xzalloc > > > - shm_id should be uint8_t > > > - make reg a local variable > > > - add #address-cells and #size-cells properties > > > - fix alignment > > > --- > > > xen/arch/arm/domain_build.c | 143 > +++++++++++++++++++++++++++++- > > > xen/arch/arm/include/asm/kernel.h | 1 + > > > xen/arch/arm/include/asm/setup.h | 1 + > > > 3 files changed, 143 insertions(+), 2 deletions(-) > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > b/xen/arch/arm/domain_build.c index 1584e6c2ce..4d62440a0e 100644 > > > --- a/xen/arch/arm/domain_build.c > > > +++ b/xen/arch/arm/domain_build.c > > > @@ -900,7 +900,22 @@ static int __init allocate_shared_memory(struct > > > domain *d, > > > return ret; > > > } > > > -static int __init process_shm(struct domain *d, > > > +static int __init append_shm_bank_to_domain(struct kernel_info *kinf= o, > > > + paddr_t start, paddr_t s= ize, > > > + u32 shm_id) { > > > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > > > + return -ENOMEM; > > > + > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start =3D start; > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size =3D size; > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id =3D shm_id; > > > + kinfo->shm_mem.nr_banks++; > > > + > > > + return 0; > > > +} > > > + > > > +static int __init process_shm(struct domain *d, struct kernel_info > > > +*kinfo, > > > const struct dt_device_node *node) > > > { > > > struct dt_device_node *shm_node; @@ -971,6 +986,14 @@ static > > > int __init process_shm(struct domain *d, > > > if ( ret ) > > > return ret; > > > } > > > + > > > + /* > > > + * Record static shared memory region info for later setting > > > + * up shm-node in guest device tree. > > > + */ > > > + ret =3D append_shm_bank_to_domain(kinfo, gbase, psize, shm_i= d); > > > + if ( ret ) > > > + return ret; > > > } > > > return 0; > > > @@ -1301,6 +1324,117 @@ static int __init make_memory_node(const > > > struct domain *d, > > > return res; > > > } > > > +#ifdef CONFIG_STATIC_SHM > > > +static int __init make_shm_memory_node(const struct domain *d, > > > + void *fdt, > > > + int addrcells, int sizecells, > > > + struct meminfo *mem) > > > > NIT: AFAICT mem is not changed, so it should be const. > > > > > +{ > > > + unsigned long i =3D 0; > > > > NIT: This should be "unsigned int" to match the type of nr_banks. > > > > > + int res =3D 0; > > > + > > > + if ( mem->nr_banks =3D=3D 0 ) > > > + return -ENOENT; > > > + > > > + /* > > > + * For each shared memory region, a range is exposed under > > > + * the /reserved-memory node as a child node. Each range sub-nod= e > is > > > + * named xen-shmem@
. > > > + */ > > > + dt_dprintk("Create xen-shmem node\n"); > > > + > > > + for ( ; i < mem->nr_banks; i++ ) > > > + { > > > + uint64_t start =3D mem->bank[i].start; > > > + uint64_t size =3D mem->bank[i].size; > > > + uint8_t shm_id =3D mem->bank[i].shm_id; > > > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > > > + char buf[27]; > > > + const char compat[] =3D "xen,shared-memory-v1"; > > > + __be32 reg[4]; > > > + __be32 *cells; > > > + unsigned int len =3D (addrcells + sizecells) * > > > + sizeof(__be32); > > > + > > > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, > > > mem->bank[i].start); > > > + res =3D fdt_begin_node(fdt, buf); > > > + if ( res ) > > > + return res; > > > + > > > + res =3D fdt_property(fdt, "compatible", compat, sizeof(compa= t)); > > > + if ( res ) > > > + return res; > > > + > > > + cells =3D reg; > > > + dt_child_set_range(&cells, addrcells, sizecells, start, > > > + size); > > > + > > > + res =3D fdt_property(fdt, "reg", reg, len); > > > + if ( res ) > > > + return res; > > > + > > > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n= ", > > > + i, start, start + size); > > > + > > > + res =3D fdt_property_cell(fdt, "xen,id", shm_id); > > > > Looking at the Linux binding, "xen,id" is meant to be a string. But > > here you are writing it as an integer. >=20 > Good catch! >=20 >=20 > > Given that the Linux binding is already merged, I think the Xen > > binding should be changed. >=20 > We would be compliant with both bindings (xen and linux) just by writing > shm_id as string here, but if it is not too difficult we might as well ha= rmonize > the two bindings and also define xen,shm-id as a string. >=20 > On the Xen side, I would suggest to put a clear size limit so that the st= ring is > easier to handle. I've already made the xen,shm-id parsed as a string too, seeing the below c= ode: " prop_id =3D fdt_get_property(fdt, node, "xen,shm-id", NULL); if ( !prop_id ) return -ENOENT; shm_id =3D simple_strtoul(prop_id->data, NULL, 10); if ( shm_id >=3D NR_MEM_BANKS ) { printk("fdt: invalid `xen,shm-id` %lu for static shared memory node= .\n", shm_id); return -EINVAL; } " The size limit is smaller than 256, just as stated in doc: " - xen,shm-id A string that represents the unique identifier of the shared memory region. The maximum identifier shall be "xen,shm-id =3D 255". " Hope this fits what both of you suggested~~~ From xen-devel-bounces@lists.xenproject.org Mon Jul 04 07:58:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 07:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359893.589159 (Exim 4.92) (envelope-from ) id 1o8Gya-0005RN-24; Mon, 04 Jul 2022 07:58:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359893.589159; Mon, 04 Jul 2022 07:58:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GyZ-0005RG-VT; Mon, 04 Jul 2022 07:58:35 +0000 Received: by outflank-mailman (input) for mailman id 359893; Mon, 04 Jul 2022 07:58:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8GyY-0005RA-9T for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 07:58:34 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2048.outbound.protection.outlook.com [40.107.22.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1944b73f-fb6f-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 09:58:32 +0200 (CEST) Received: from AM5PR0602CA0005.eurprd06.prod.outlook.com (2603:10a6:203:a3::15) by DB9PR08MB6508.eurprd08.prod.outlook.com (2603:10a6:10:262::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 07:58:30 +0000 Received: from AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:a3:cafe::7) by AM5PR0602CA0005.outlook.office365.com (2603:10a6:203:a3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18 via Frontend Transport; Mon, 4 Jul 2022 07:58:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT052.mail.protection.outlook.com (10.152.17.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 07:58:29 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Mon, 04 Jul 2022 07:58:29 +0000 Received: from b2907b2dd29a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id EF69B989-4334-44BA-BEAB-64631DFF0454.1; Mon, 04 Jul 2022 07:58:22 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b2907b2dd29a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 07:58:22 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4167.eurprd08.prod.outlook.com (2603:10a6:20b:ad::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Mon, 4 Jul 2022 07:58:19 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 07:58:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1944b73f-fb6f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LIa7S44yQK5Ap2umPmNN1hZiCCmEZvE7YOfyeSggrNwjRYbLz9GzLCWrSlBC6IBL3r3No8/cl5YTMoryhYEbbBTSEeZBGqGT6gQZOWDCeie2Tk9KiSe5u9uT3nzfMciEEEXtCVU8LFy1/KUGuxV6LK0TksXEpp78e3jdN1907t0J/SWj9H5qJrrsMxhRQ1LBPMVyyx6ZCD+4rjvfodf8F2HcIjfSYEtIsGE4IgwDAaeypiRn2F/on18sSubRoB0yUBtTGKRKXcF/vB4xXDrEjXzupN1wcFVxQBuoSUxZ7EGw8SNWclNT4Diag0aKQSDbSFHZW0PlLVrZLqT7xhenog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8iN7FG7QqIPSNaC7tk21q2PP6kF+jvvb+UHhnPZMsc=; b=IcrPlGxtnShEIfkFOfVfQOzucX0ePTSkywvazD+Ox83CwWb8tPB6uJrsUaZZc1DwCQUC2rNmY7doYD+FfzDx8aAn05h9Ata8lBu6ZJ/BL4OE7uoW71sZflLBERi7mRa79CDvwvDm1xWCelMrX9RHZ5CkfCk6J7ngswIU0AnyaHSUnxeru8TBddccPG4o53okym8vJFs1wKdCIftu/vIZecrY8ws15K/pTmmxvD0t7dj9plOYHlMswSioKS9izNxc3jrxcCZ+uxDsbhdGyRH7Rw18Gwjh+d1QyBSeQ+tB7gmts97xg3v6bhBnpjMeFIUmjusCK3TB7Eo5UdMtuTVkWA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y8iN7FG7QqIPSNaC7tk21q2PP6kF+jvvb+UHhnPZMsc=; b=fqrWFMsEIpQEYkKtwHmRQyRMp78fesMgZnBUjykX9A9D+MRlV1tt3M+7qOC4i/t3EMo7g9YN972E0iaRWFD/Sg85lwG2SMvLWC65f6l47aPQECboovtnWqJToSBaky/pI9oQbFbgj5IgO0zka1IYi2Yt5BH1U2gD4oMFFT2TdZw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d4ab59a1a25fc732 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XNiT8BDuaxJeqngfI6qdkPr58XXsZW03b15rtmFLnoIJWB6ffzJ6ndJefr4/6JXd+UumzeRdeKOg7lwsepEyi4dboRjMiQr0MXDpB3MP5wuTP8Xr06Ac7LmiynksLboKZfSk7uMA4EXubSLsNmvepypI38LHZK8Buz7fyjxVNoj8Y89GBcl2otDv9abxttOlSlwXgQS+fe1RBG3gBmeTNxCq5GZvY69RUC/2fERz22oQpyOPP94LN9eIH5HMgeCjKzxDwKv6Yx/lSZlT2x3yHuVKQ53An2X/1BFnj2PwabA1QLbCibM2Ipdy5C+WwA0ir4RUMPi2kIhIROfwS/CN6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y8iN7FG7QqIPSNaC7tk21q2PP6kF+jvvb+UHhnPZMsc=; b=BBarIyztV+nyZkO7Y8gtV9ZjSCnwSiBTBSRTi/FsZJdCzCB2c14NbpA1hGiUg+ZxTO5XA6xfGH1otQMdfpAEu+PaxifEAK/PZ1zgoZnKDUAS8/dwUVfnFvX0zx9pYJVMWUCr3YWJPdFmY2wGLoES7EQNWqRTspWXdIgn7zXDV4Zsv7UnhKBc9dDkZpTcvGTYUWjALT9TiIuyCctABsrgPEQCkq3XBuV32hZxS8N7ksJxpg+x8pc1XmoukUmdMKTJ9OIhss8MhDCp83k5KQ225x9WvbczV6R1xVkvpSZE3aoiUsaEWCVl3sBT5h8FmjzkOLRfLee1175H74dymvF7vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y8iN7FG7QqIPSNaC7tk21q2PP6kF+jvvb+UHhnPZMsc=; b=fqrWFMsEIpQEYkKtwHmRQyRMp78fesMgZnBUjykX9A9D+MRlV1tt3M+7qOC4i/t3EMo7g9YN972E0iaRWFD/Sg85lwG2SMvLWC65f6l47aPQECboovtnWqJToSBaky/pI9oQbFbgj5IgO0zka1IYi2Yt5BH1U2gD4oMFFT2TdZw= From: Luca Fancellu To: Bertrand Marquis CC: Xenia Ragiadakou , Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYj3bsMO2Y3PSLZ0WCUDTYt37uBq1t0/kAgAAEvQA= Date: Mon, 4 Jul 2022 07:58:19 +0000 Message-ID: References: <20220704072232.117517-1-burzalodowa@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d01d3064-f51b-4249-336b-08da5d92fb8f x-ms-traffictypediagnostic: AM6PR08MB4167:EE_|AM5EUR03FT052:EE_|DB9PR08MB6508:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PaGOY+A0P5fh5poKW8XHHntc9EjEzhYYbmHyeCLg/Kx5if62GCp7QvNrqQPw0whjydwmjBRD6C/w3MVnO/ls6X5OWh3PT991f18pPvryCOXtILy9r/CRakqv1rgCn2x0JqzCvwl3w71Ai7lYLXAFU42ltSJAuypKx0aZlx+kw8cs0mIDDOEwWj5AMik578xxB17wsix3Aaazw3ksrOj3s7YF6U7XsyETAUf9OIx/vCphvvpy1YHwir01z+L6tDiBFza0poY4S7p69jw2cHWegiAGuR7cBTK28kRBsfyynVSnHYaE6NPcJhxiqPl9CIw9y4sooJnw0bqeyEPnmk2epxEJFMH5agte2ECf+6mcFr7pMwfNesqyIzAmbmE83nIRKInzledciIzWPLZOVZWZ439fE9EeKA+0cnJayJYo33FkgUdg/cthEV/6zdkrf074Wh3gT6ylZVczTKKaUxr95+gA8fNco3q2LlKp1Gx9A2+F24GVLjWs9kecRWQ34/MMHAy5mByp1aSeh+/bg9awY6Bh9R0ZOjrbwC8pIiyS4INPDD713wDsr1tlwAbNQ1N4nub+/KMeuhYzmlWpsvbXqn2KiZwqbpwpSqRbE00v5jInHCxntJ6xwxXK6epKEQvFnOgijdLQOhwnlmfrH0C1/WGCiKe+9dB9aV44gdb2JonIPYOFk2g01W1Qv4y9exhwTpo9efzriUS56/7ZIzQnx3iV9NpPAvxot284Y9tPpkNP4xiP8EAiGVd8Ly9P58N8t2974SmiN3SrxErxt7+Vnqd0zO+RcprCn6I6EbCmpBhl/YE/vKhwQLM8jePfbi+EwuIn0UVkcU8lefK443aIROehN2nulgFToRbkmwbHHBQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(39860400002)(136003)(366004)(186003)(38100700002)(2616005)(36756003)(33656002)(2906002)(76116006)(26005)(86362001)(71200400001)(66556008)(66446008)(66476007)(8676002)(4326008)(64756008)(6862004)(91956017)(66946007)(6512007)(5660300002)(8936002)(6506007)(122000001)(6486002)(54906003)(478600001)(316002)(37006003)(6636002)(41300700001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <1088578C35947D4D9A0DD1802F1A6A1B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4167 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ccf844b3-0a01-4717-f2ba-08da5d92f5d4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 21ZHPMRr4efaVzsnKRKjrj6j6aDrEQH6zODAvV3w/JehKqs7k1aKK0AGrdAy7F3MBerUe+zpM+O3vwYmqp6YGOdOtOaFntw69ArhodCykUEQ8jPuztzGVqrcKEDiAkuG08H7rx3KxtGux8Yc+F5EGQ2JAoyA38kOSb3J7M/vT/iiy5n/wJHKnJDb1NvyMUY6YMmMiWpeb+3mFbCPLFuFcwHnMHrYpjfq4V54NtjGBgQKa08ilf/kj+4H29rosXntHvcnCHnBjoa11/QbA8CROUWPT7Bkh49kPbIRlsfOJOj0+0gzCy7PB/SS7NBEAAGwNJhVaZeRbadqsLwsw3TM9TFElaAt5aizmv6GuFikFZTwSZ8mQomdjshZjx4Ha09yxEOLTwjDUMYj2RWZzgeo7KzDbAz8pDq++e4+/CJXcumEnpdiro5PHJCnr/Yrtx76Wrx/T2aGv9RY/h8k/UIQHCwA+rERbs09J/KD6hKlJkkUQXEbRPo6mi8HVSFd0LztPunVysdj+BKDzSjmDzV9Rmu1nfuPOM1G0K+GXKdd/3Z+sZ0JgthS9Ns2OMNyFA35KnD4DgsEU1Kc9dJ9I96Db3ri5jVVcSIn74w9c9B4izTw9LwoGy+cbfJdvtVabHJ0Q3EasnUv+M2I2TjDN6B80gzhqzuH9WyTeJ0bJi/nXVytSsZ0l9PPPIglhIQSbCCegKcQ4xLn71HP6/WAzENVPzPpCT9/x1GtLcBlEBGCa1zNIf4nEuPh6EKRzy9P+SxoPlaa3MQR93mu+jVM500/yRvdLh8kdZAuGbKb+04rORT1gmVM7TfM0zqdi3wBOJQc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(39860400002)(346002)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(336012)(47076005)(36860700001)(107886003)(186003)(82310400005)(2616005)(36756003)(2906002)(33656002)(54906003)(6862004)(26005)(86362001)(70206006)(8676002)(4326008)(70586007)(6512007)(5660300002)(8936002)(6506007)(356005)(6486002)(82740400003)(316002)(478600001)(37006003)(6636002)(41300700001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 07:58:29.2952 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d01d3064-f51b-4249-336b-08da5d92fb8f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6508 DQo+PiBJIGFtIG5vdCAxMDAlIHN1cmUgYWJvdXQgdGhpcyBwYXRjaC4NCj4+IEkgdGhpbmsgc2hv d19zdGFjaygpIHNob3VsZCBiZSBkZWNsYXJlZCB0aGUgc2FtZSB3YXkgYXMgc2hvd19yZWdpc3Rl cnMoKS4NCj4+IFNvIGVpdGhlciBib3RoIG9mIHRoZW0gd2lsbCBiZSBkZWNsYXJlZCB3aXRoIGV4 dGVybmFsIGxpbmthZ2Ugb3IgYm90aCBvZiB0aGVtDQo+PiB3aWxsIGJlIGRlY2xhcmVkIHdpdGgg aW50ZXJuYWwgbGlua2FnZS4NCj4gDQo+IEkgdGhpbmsgdGhhdCB0aG9zZSAyIHNob3VsZCBiZSBk ZWNsYXJlZCB3aXRoIGV4dGVybmFsIGxpbmthZ2Ugd2l0aCBhIGNvbW1lbnQNCj4gZXhwbGFpbmlu ZyB3aHkgdGhleSBhcmUuIEZvciBtZSB0aG9zZSBhcmUgdXNlZnVsIHdoZW4gZGV2ZWxvcGluZyBv ciBkZWJ1Z2dpbmcNCj4gYW5kIEkgc29tZXRpbWUgY2FsbCB0aG9zZSB0byBmb3JjZSBkdW1waW5n IHRoZSBzdGF0dXMuDQo+IFNvIEkgd291bGQgdm90ZSB0byBrZWVwIHRoZSBleHRlcm5hbCBsaW5r YWdlLg0KPiANCj4+IEkgZGVjaWRlZCB0byBkZWNsYXJlIGJvdGggb2YgdGhlbSBzdGF0aWMgYmVj YXVzZSB0aGV5IGFyZSByZWZlcmVuY2VkIG9ubHkgaW4NCj4+IHRyYXBzLmMgYnV0IEkgY291bGQg aGF2ZSwgYWxzbywgYWRkIHRoZSBkZWNsYXJhdGlvbiBvZiBzaG93X3N0YWNrKCkgaW4NCj4+IGFz bS9wcm9jZXNzb3IuaCBoZWFkZXIgaW5zdGVhZC4gUnVsZSA4LjcgaXMgYWR2aXNvcnkuDQo+IA0K PiBBcyBzYWlkIEkgd291bGQgdm90ZSBmb3IgZXh0ZXJuYWwgbGlua2FnZSBoZXJlIGJ1dCB3b3Vs ZCBiZSBuaWNlIHRvIGhhdmUgb3RoZXINCj4gZGV2ZWxvcGVycyB2aWV3IG9uIHRoaXMuDQo+IA0K DQpJbiBhZGRpdGlvbiB0byB0aGlzLCBpZiB3ZSBkb27igJl0IHdhbnQgdG8gcHJvdmlkZSBhIGp1 c3RpZmljYXRpb24gZm9yIHRob3NlLCBzaW5jZSB0aGV5IHNlZW1zIHRvIG1lDQpjb2RlIHJlbGF0 ZWQgdG8gZGVidWdnaW5nIHRoZXkgY2FuIGJlIHJlbW92ZWQgZnJvbSDigJxwcm9kdWN0aW9u4oCd IGNvZGUgaW4gc29tZSB3YXkuDQoNCj4gQ2hlZXJzDQo+IEJlcnRyYW5kDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:06:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:06:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359902.589171 (Exim 4.92) (envelope-from ) id 1o8H60-0007PR-3e; Mon, 04 Jul 2022 08:06:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359902.589171; Mon, 04 Jul 2022 08:06:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H60-0007PK-0b; Mon, 04 Jul 2022 08:06:16 +0000 Received: by outflank-mailman (input) for mailman id 359902; Mon, 04 Jul 2022 08:06:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H5z-0007PE-7c for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:06:15 +0000 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [2a00:1450:4864:20::532]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c5701a3-fb70-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 10:06:14 +0200 (CEST) Received: by mail-ed1-x532.google.com with SMTP id e40so10681863eda.2 for ; Mon, 04 Jul 2022 01:06:14 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id el3-20020a056402360300b0043585bb803fsm19840182edb.25.2022.07.04.01.06.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 01:06:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c5701a3-fb70-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=W9HfTjn15UAvBfHrZ5oBi9kQQHqbkPOKt0RssB9FyEg=; b=emALJNTv4bWX2oGsiofVsRRFB8Jtt1xVzqkFjU/eX7rLFG8wbnXkMkYDao1HnwFbI5 hNM0NY3ZWmapLG0nhq8vR9SRI8MN+Zb1pjQUKh12Bnpo11GUktb1bD4vXZouaf9/5gy7 kJMOlJAfe8q26w3CQ7pstB9y57Sepii0HXOzGa/k6Zg/F/NarqhOv/jHqdM/5yQWgAY8 d+50IB1x91ZzF8Y8LdOjTqWgm7SeWXXDxuOo/1Qu3wS0R/XP3D2iO4aembxF9Tv2OJ0T HwKUDNnXJrhBSDSZgb4pNGbryG57IYYaXwJdT/wDXMvMiqAGlO+J4ok8LlO3osxcfGDc EPSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=W9HfTjn15UAvBfHrZ5oBi9kQQHqbkPOKt0RssB9FyEg=; b=XLaf+XQE7b4cU+ck4tgbHH3r6qpZ0JInGnCjsTCOHXRBHARctiJIF5yOArstDH4pOb qE74u5z6U/V5yKP8bZzRnoMWKVt9ue/qB2t4SHD7zF4DWOfgYdht2ITrzgmFXTTbXZrz f/mXfnRVKLNLK3HdqrbOJPI8D8XjEJqUh7rSUYuY8sjXH6+oo+fJumdYi5/svw96sSqD Tn/9lugk6e95A7XHNpthDrt+wdYH9d2+pkECfUySviZkzwXmFXcIwoponusmUxEP1xc3 dgcUt8QeeIbpmZL7I9v1AI39iqfYGau0q/MROWDAclHshqyv6GpmO9M6Vh3RFQjpiO2I GTRQ== X-Gm-Message-State: AJIora+Ymm/ym/JY73s5HABoatQpjdHxaLKaQQLoL31qaPOwnQzxlEz+ j8XkdcTfyIQ2+b26NkaJsm8= X-Google-Smtp-Source: AGRyM1sLD+m81KLD2Pm07f1LUE15x951diP0E3vpI7V7hlK5woNu2iCDx6MUkRygO3vBZJBLXl0DoQ== X-Received: by 2002:a05:6402:2687:b0:43a:6025:1658 with SMTP id w7-20020a056402268700b0043a60251658mr3706140edd.271.1656921973727; Mon, 04 Jul 2022 01:06:13 -0700 (PDT) Message-ID: Date: Mon, 4 Jul 2022 11:06:11 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Luca Fancellu , Bertrand Marquis Cc: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk References: <20220704072232.117517-1-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/4/22 10:58, Luca Fancellu wrote: > >>> I am not 100% sure about this patch. >>> I think show_stack() should be declared the same way as show_registers(). >>> So either both of them will be declared with external linkage or both of them >>> will be declared with internal linkage. >> >> I think that those 2 should be declared with external linkage with a comment >> explaining why they are. For me those are useful when developing or debugging >> and I sometime call those to force dumping the status. >> So I would vote to keep the external linkage. >> >>> I decided to declare both of them static because they are referenced only in >>> traps.c but I could have, also, add the declaration of show_stack() in >>> asm/processor.h header instead. Rule 8.7 is advisory. >> >> As said I would vote for external linkage here but would be nice to have other >> developers view on this. >> > > In addition to this, if we don’t want to provide a justification for those, since they seems to me > code related to debugging they can be removed from “production” code in some way. Rule 8.7 is advisory, so I think that formal justification of deviations is not necessary. > >> Cheers >> Bertrand > -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:08:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:08:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359908.589182 (Exim 4.92) (envelope-from ) id 1o8H8Z-00086t-HE; Mon, 04 Jul 2022 08:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359908.589182; Mon, 04 Jul 2022 08:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H8Z-00086m-EI; Mon, 04 Jul 2022 08:08:55 +0000 Received: by outflank-mailman (input) for mailman id 359908; Mon, 04 Jul 2022 08:08:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H8Y-00086c-PS; Mon, 04 Jul 2022 08:08:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H8Y-0002a3-MW; Mon, 04 Jul 2022 08:08:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8H8Y-0000dq-2Z; Mon, 04 Jul 2022 08:08:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8H8Y-0003A7-24; Mon, 04 Jul 2022 08:08:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YFif0rFqrExem0MsGvA5BMEdSr0jOYHPcDbyS2XceHM=; b=jVn3OVCms+tyKMMfaDX2vpRt4a 6uTfuhwu+jd0BOXaOZhQsXFYOQTg/rB83Nr2M4WjPNXGiPsVamoM3/h4o5ng7obGuXSh1KrfNUSJM 6+HvkAOP3CZD5lSXyOQye519ZTZZtlE6ofoLqEMhqA3q9NbNPeraJC92hfor0m5VPneQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171475: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e8e86b484eac70cd86e15fa10a2f0038a536cbba X-Osstest-Versions-That: qemuu=ba45b82518bd5d9cad509765411e7f82a73aed53 From: osstest service owner Date: Mon, 04 Jul 2022 08:08:54 +0000 flight 171475 qemu-mainline real [real] flight 171480 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171475/ http://logs.test-lab.xenproject.org/osstest/logs/171480/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 22 guest-start.2 fail REGR. vs. 171462 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 171472 pass in 171475 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 171472 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171462 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171462 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171462 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu e8e86b484eac70cd86e15fa10a2f0038a536cbba baseline version: qemuu ba45b82518bd5d9cad509765411e7f82a73aed53 Last test of basis 171462 2022-07-03 01:07:33 Z 1 days Testing same since 171472 2022-07-03 11:33:24 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anup Patel Atish Patra Atish Patra Bin Meng Nicolas Pitre Richard Henderson Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 446 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:24:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359921.589196 (Exim 4.92) (envelope-from ) id 1o8HNC-00029s-5H; Mon, 04 Jul 2022 08:24:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359921.589196; Mon, 04 Jul 2022 08:24:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HNC-00029l-0q; Mon, 04 Jul 2022 08:24:02 +0000 Received: by outflank-mailman (input) for mailman id 359921; Mon, 04 Jul 2022 08:24:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HN9-00029f-QE for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:24:00 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a28e6b7e-fb72-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 10:23:56 +0200 (CEST) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 04:23:37 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB5813.namprd03.prod.outlook.com (2603:10b6:510:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 08:23:35 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 08:23:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a28e6b7e-fb72-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656923036; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=8IF8fqekkbkFiiRDiFhmHjgxhiflV4BmZVZmQy7k55w=; b=ewv310XnaSmUPxp31w4FqyU3mx6P0mL6habAKfwAf3ardCumRYKhHTqQ we93hGdcbNhVnrgALuCme2mFpw0GFovKk93kUBOuKfOUJefg7RcdLIWb7 /R3KPysQ0sNCk7wlwdRE0RZAT87TZKkJCPZOPwYtL5KCzwPxsDjeepTUG Q=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 75044534 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:wQvZh67k6zA28OAaJsoSbQxRtEzGchMFZxGqfqrLsTDasY5as4F+v mFNDGiBMq2ONGf3KIp0at61oUIG7ZHUmN43TQtt+SA9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YfhWFvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurS+EFkJZq+Lo9gcVgAIDD1cZr0Bu7rIdC3XXcy7lyUqclPK6tA3VAQTAtdd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfiXo4YAhF/chegXdRraT 9AeZjd1KgzJfjVEO0sNCYJ4l+Ct7pX6W2IF8A7J+PFri4TV5CBMwJvuNMX1RvitZspWnmzGq kf83HusV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRol6zXZdTJ lIZ/gIqrLMu7wq7Q9/lRRq6rXWY+BkGVLJt//YS7QiMzu/R/FyfD21dFjpZMoV+7IkxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLT8ZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:xHvVpKMLqi5Be8BcT1r155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj5fZq6z+8P3WBxB8baYOCCggeVxe5ZjbcKrweQeBEWs9Qtr5 uIEJIOd+EYb2IK6voSiTPQe7hA/DDEytHPuQ639QYQcegAUdAF0+4WMHf4LqUgLzM2eKbRWa DskPZvln6FQzA6f867Dn4KU6zqoMDKrovvZVojCwQ84AeDoDu04PqieiLolis2Yndq+/MP4G LFmwv26uGKtOy68AbV0yv2445NkNXs59NfDIini9QTKB/rlgG0Db4REoGqjXQQmqWC+VwqmN 7Dr1MJONly0WrYeiWPrR7ky2DboUMTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp+6Z/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wUR4S0LpXXt WGMfuspcq/KTihHjDkVyhUsZaRt00Ib1i7qhNogL3X79BU9EoJvXfwivZv3Evoz6hNOqWs19 60TJiAq4s+PvP+TZgNcNvpEvHHfVDlcFbrDF+4B2jBOeUuB0/twqSHk4ndotvaM6A18A== X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="75044534" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VNMOQApej7dkOtkDrh5bHMlLFxsGgDkCa22Sa3meiJ1OBVLX+FG4i/ch7LcgGFKh3uCxaMYx1g2uvoqCTqvr45KJEG7qw7pHRj4HsAFxWCEYifY0A4kAKKoilBSVxG3Igzm3kSnVuaQN0S+AjIJcEyEVQwy62oGk8pcgd5F5CEujxewAjvY0bNcj0bQ16iPbhZ81rLQLMNVQtTDzVlImfproxNU2Z8m5Qw38lTdt1GonB9w3dsh0vLhzeaKYQk0X8gIYhAX/tzJkwjhAd36TOCnVp+ZrUH7emcZ4L7EqXB+X98F9hkjtWceG05yGrKfoNuVmRsDVmsaBjdYi3UDV1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GR6PunM16LDtcYjrwHaa2RbE3HRjrEamFKKGsQk/vKY=; b=GPRm7hziKb7UTYo2KXfFbUl+L1z7+J1kALU8LyUrjpQp+hQxTxG9y8qU2HD+dl8AzFDa9cdmMoLTExBZLiNJUew/uLzObI5OUwYHmYXxCj6eEMMvnUX5qsUgHnvZJGolN2sGZ94bo+FOTbR44dB5ytp2JECtYdTXIClF1znQlM3NM9vQcdvOKHmyBTxlMWWZkY/4nc4scN2mbjToM3CNuWS6nVm1Wji6rBjb4Lel7lzppD0Hw2BNhc19exbfX72b9wD5KNCRRRPEe4jzTe2ls6xo3PWQ4KbZrimN7fHfIO0KgFCX8RA5YC8tX5iu0pdidCIprBNvvnLn+N3y6GB+TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GR6PunM16LDtcYjrwHaa2RbE3HRjrEamFKKGsQk/vKY=; b=ukkDRlPp01eWpoDv1X0tBhl8TvsEP+F5/I2Wsys+xIcQItaj+4gwhxmNELwfZSnFu4VclI4txahGOQ5AEJLN6fby06nIQhn+CiWuogSEV/Nb/st1HGFhJWxI7M1ABGIQ71lz7wxwr0Z7INvdn5J2LzwRBB3bU1EFpKuzVGzQufU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 10:23:34 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH 2/5] x86/lbr: enable hypervisor LER with arch LBR Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> <20220520133746.66142-3-roger.pau@citrix.com> <4a193fd4-deb3-12c3-2faf-eed33e7b52af@suse.com> <9db996bc-cdeb-37ce-9e98-ca199d42a494@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9db996bc-cdeb-37ce-9e98-ca199d42a494@suse.com> X-ClientProxiedBy: LO2P265CA0166.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::34) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 660467d2-7828-44bf-0083-08da5d967cd5 X-MS-TrafficTypeDiagnostic: PH0PR03MB5813:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3LR4ZefSOKNuCP/IUYjO5CV0GfortFaBbEmh3Vv8fZ8nvWz+kE2YN2fpEaWynzEjiCGEqLx6lUmete5ZsLxmqFl3DP82LsTZTEVTUNvHKwAIEEYWvL3UTqJIFMTxoI12VKYvsOoryJyHC/PcmbpdTxRZQJ3RyWSSkOhO7FILq8Fnw2iqtAaU0z3GFqbS3QfkY8MtE8oLG/G8t90cqB79AX8R67TYTbUZsM3eCEkJktcn6GNtE+s0pJRG0hSH+mpkYfi4AXqn3gyW8mgJKz5uxu9o5EzvQyxpQzQYhxxqiKKqxR+1m/UYfYK6axrvPmKcnJ9Qov4uAS6f7VCHBQ0pNQNDkLSBBC7eGXnOmOizMa0d3CUxmxs3XZH+jRIngaLQapcfYb/IJ4ASiwSaLFRWjJV7ng2xTSGyeQq2NNz7QAh8GPeXyjRSnpmradgTgV7f0sqeK8q0pj5hcklnJZsrjJh92s4rfdwaK211YroLRjveeAGE9Slc4NE1iF/xKYkffGLudlGWXiAeGVEQvc7yjTnSWiGwYj/W4ym9cItdcMs55lFuVnnKl4OzbQU866uevYxldaa7azWVsfVbmDmXBaoSz3fY3RNKp/xp7SEE4bF0q8aTZyxW3oP8NJUF2ZxRoWnY0bpL5wZUnGOAYOv1jkNQkZI8pp4GLjz1V19FduJAXxN2kOUTVdnav/zvXWJab4NWihOSe1U61qT6u2znED0qqlXU4S5Nul2s+I8UPZMHHj28luXqmWxswSOSKiBURxJjEfABecqbgc9qjh/EnQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(376002)(366004)(396003)(4326008)(316002)(53546011)(8676002)(8936002)(5660300002)(66476007)(66556008)(38100700002)(6916009)(66946007)(82960400001)(41300700001)(86362001)(6486002)(478600001)(6506007)(54906003)(6512007)(9686003)(2906002)(26005)(85182001)(83380400001)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2ZVRFd3U0NZbThoK1pXTENXZzFVTlN1QWVBcmpBa0ZSZ1prZ2dBbUlWbkN2?= =?utf-8?B?VEVBYjlsaVplUjRxWmNlVEFoZVFrZGs0UjhBc2NVcXA4U3UvRUdtdGI4bmt6?= =?utf-8?B?VVBvYmh0STZSa05seEJIQ1BOVXlNUkFpc2Z4bWt0NGt5WUxwV0NEU3BKZTlL?= =?utf-8?B?bkpjKzUxWThKUFNEMk5wNjJrank3aXF6VDFZbTEranBIQVRUeURHYTliMkgz?= =?utf-8?B?OWFyUlNwVmMxam9XWURxYzRoNkRQcmVhTXRrQmxFaDVtUUZvNzFVUU1CL3B4?= =?utf-8?B?V3NmNFRSVVJkb1VkTzcyVGRZU3ozMUJOaVN3TmVqa2p6NFBubkdUV1lZT3dI?= =?utf-8?B?ZWZlUDJsdVFKaU44KzlnbG53b1E5VXd2Mjg3RUNOZVU5aDJXWHRPSTJEUlMw?= =?utf-8?B?dDZQUkdxL1hVb1dUYnQzQkVhNnEwM0lXV0FvVGxzbDlsSnY3eENRdmlsM0FV?= =?utf-8?B?VEU3RzVFaWpTMmlXRW91VlRpQWQwak9ITE1ISmk2bGhZQ2M3d2hIdk1kK0hH?= =?utf-8?B?WWk1TGo4eU1mOTRlR3JMaURUNGZuZ2c0VUFZQWtHa1JtVTZSWUpwTUdqLzdW?= =?utf-8?B?eTRGWS9GTGNoN1IyTS8xSXZXa0dwZHZ6dlU1VjNyUXlNcklMR0xNRXNxakhM?= =?utf-8?B?ZkgvMUpBK05hN1Y4cVNtSUJQVnFZZ3pQbWdvcW43cWUwL3BnMlpQcFlEYWFk?= =?utf-8?B?UCtNZ3V4QVBPZytRN0JUeXdUU0xsTElHRnFBczEvallzbWtyemRRMGFzRzl5?= =?utf-8?B?bitSdFhKYUh2NUZTRkhJVm51QnA2b2tZZ2JrR1BZQnV1S00zZHlaNVdPWU5t?= =?utf-8?B?cTVaN3RlNDQ2ZVM5OE5GWGhxK0JQbFlmc0lWTEVKYnJjdm1Ybml1OUdrS2x3?= =?utf-8?B?SkJCVmFOU245M1doMEUvWG5uVzJ1d2t2NDZqV3EybWtRZU14M2EwdCs2UFRX?= =?utf-8?B?VnJhQStteG1wbzN6N1NyNHAyWHprRGFNZnJVcm92UGNTMGRpUzlROFJHNUJz?= =?utf-8?B?aSs2OVFJSHhSRDI2d0ZaY0Y0TnBPckp5RXp6QWJMQVNoZktPZGtrem5Wb2sy?= =?utf-8?B?bTcwNE0yZlFNaUtUZTJuZExiQThrRWdqbnEyM0Ntb0hHTEw5aTIvWXJObGV0?= =?utf-8?B?bThxSVpweHlsUVZMR3haUnRjL0p4YW5xUVoyUmMwUkxISWQwNzdtV0s1K0lB?= =?utf-8?B?UXVlWmRxcjYvMU43dDFZZjA5VnJTd2hpY0laaGV0T3RXR1ZpNmlydHJLQ3lY?= =?utf-8?B?ZlFQcndhYTRoRE42NWxTcXBselJ6Q3pCRGh0NGZJQVZVTUFoMFFPeThMTEVx?= =?utf-8?B?N2w1U3d6amxjMTVqUU5sQXlXZXlUVnYwSjhIK3IvMWt0M3ZWRUlNSS9jSjA3?= =?utf-8?B?WWxtNndwVWtnR0hxdW5yN1BJVEx2eTFLbk90QXlIandnbHpRWG9TeFQvZUNB?= =?utf-8?B?T052WkJ5czc0SWhGQ1JVRnMzSGMzSlc5bHYrTERWZEIvdDV6ZGc5bDl4L2Nr?= =?utf-8?B?b29MdDNYeklHOHc4R3RtMENFcWJtdk8vK0NxM2xONEtCQTA3V1VLRjAwcVpQ?= =?utf-8?B?RnRVTVFqM0V1R2lYeGMxei9KWTVZOTJxYVZveFJNc0RJcmQvYkVLdTJ5MkxB?= =?utf-8?B?cWlvU21kdVpuRlBDbUpWekJpR2greHBZSWVQdlFOeUN3eU5EOEFvNk04OTVB?= =?utf-8?B?eDJPTjNmMWZxR2hkYUFPUXNCczM2Q2R5a2ROK3MxVlR1NmZQZS9PbFdJc2lv?= =?utf-8?B?dStQeG5GME5vTzNKUzZnRVV2c3RtaGlxMGVGU3k2bHFRa0pncGdCSy9xRjdh?= =?utf-8?B?Z0YzRVNXbGc0NS9qRkNRMG4wU3IvZndhYTRFaW85NjFSSDdTSDVENUtPY01i?= =?utf-8?B?VTIvU1czN0lzT3EzUHZsRkFuMVlOWjd2cnBrV2pQWU1nV1d0WlBvcFMzRERM?= =?utf-8?B?QUVITWhGbUFCaEtvdlBrTkNsUklEYy9Cbk5yUVVNaU5TVWNqMGpSSFM2R3hr?= =?utf-8?B?WUFSTDVya1hrYSt2NnFFRWdmRkg4VkZ1ZlBiN0VJL3lqV2Jlemw1UUNnWU9Y?= =?utf-8?B?SmNTWGR2RUNFRE11eFhZNkRWcG1LUmNJUysxV04rYWZiZG8vdUVRQkFYZXZa?= =?utf-8?Q?C5yHSO2f53gqt+IzeAtyyCTTc?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 660467d2-7828-44bf-0083-08da5d967cd5 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 08:23:34.9044 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eW5n4foToQsiCzzKmKKlSSmP3psdkiDCqXnRn5zlNi6NhEs4/wXs9nkSwlaaconOuR9BwyKcg/rr5FfpHich0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5813 On Mon, Jul 04, 2022 at 08:15:15AM +0200, Jan Beulich wrote: > On 01.07.2022 17:39, Roger Pau Monné wrote: > > On Mon, May 30, 2022 at 05:31:18PM +0200, Jan Beulich wrote: > >> On 20.05.2022 15:37, Roger Pau Monne wrote: > >>> --- a/xen/arch/x86/include/asm/msr-index.h > >>> +++ b/xen/arch/x86/include/asm/msr-index.h > >>> @@ -139,6 +139,24 @@ > >>> #define PASID_PASID_MASK 0x000fffff > >>> #define PASID_VALID (_AC(1, ULL) << 31) > >>> > >>> +#define MSR_ARCH_LBR_CTL 0x000014ce > >>> +#define ARCH_LBR_CTL_LBREN (_AC(1, ULL) << 0) > >>> +#define ARCH_LBR_CTL_OS (_AC(1, ULL) << 1) > >> > >> Bits 2 and 3 also have meaning (USR and CALL_STACK) according to > >> ISE version 44. If it was intentional that you omitted those > >> (perhaps you intended to add only the bits you actually use right > >> away), it would have been nice if you said so in the description. > > > > Yes, I've only added the bits used. I could add all if that's better. > > Personally I'd slightly prefer if you added all. But if you don't, which > is also okay, please make this explicit in the description. > > >>> --- a/xen/arch/x86/traps.c > >>> +++ b/xen/arch/x86/traps.c > >>> @@ -1963,6 +1963,29 @@ void do_device_not_available(struct cpu_user_regs *regs) > >>> #endif > >>> } > >>> > >>> +static bool enable_lbr(void) > >>> +{ > >>> + uint64_t debugctl; > >>> + > >>> + wrmsrl(MSR_IA32_DEBUGCTLMSR, IA32_DEBUGCTLMSR_LBR); > >>> + rdmsrl(MSR_IA32_DEBUGCTLMSR, debugctl); > >>> + if ( !(debugctl & IA32_DEBUGCTLMSR_LBR) ) > >>> + { > >>> + /* > >>> + * CPUs with no model-specific LBRs always return DEBUGCTLMSR.LBR > >>> + * == 0, attempt to set arch LBR if available. > >>> + */ > >>> + if ( !boot_cpu_has(X86_FEATURE_ARCH_LBR) ) > >>> + return false; > >>> + > >>> + /* Note that LASTINT{FROMIP,TOIP} matches LER_{FROM_IP,TO_IP} */ > >>> + wrmsrl(MSR_ARCH_LBR_CTL, ARCH_LBR_CTL_LBREN | ARCH_LBR_CTL_OS | > >>> + ARCH_LBR_CTL_RECORD_ALL); > >>> + } > >>> + > >>> + return true; > >>> +} > >> > >> Would it make sense to try architectural LBRs first? > > > > I didn't want to change behavior for existing platforms that have > > both architectural and model specific LBRs. > > Are there such platforms? While it may not be said explicitly, so far > I took it that the LBR format indicator being 0x3f was connected to > arch LBR being available. IIRC Ice Lake has both model-specific and architectural LBRs. While format being 0x3f could indicate the likely presence of arch LBRs, the CPUID bit need to be checked. > >> As there's no good place to ask the VMX-related question, it needs to > >> go here: Aiui with this patch in place VMX guests will be run with > >> Xen's choice of LBR_CTL. That's different from DebugCtl, which - being > >> part of the VMCS - would be loaded by the CPU. Such a difference, if > >> intended, would imo again want pointing out in the description. > > > > LBR_CTL will only be set by Xen when the CPU only supports > > architectural LBRs (no model specific LBR support at all), and in that > > case LBR support won't be exposed to guests, as the ARCH_LBR CPUID is > > not exposed, neither are guests allowed access to ARCH_LBR_CTL. > > > > Note that in such scenario also setting DebugCtl.LBR has not effect, as > > there's no model specific LBR support, and the hardware will just > > ignore the bit. Also none of the LBR MSRs are exposed to guests > > either. > > My question wasn't about guest support, but about us (perhaps mistakenly) > running guest code with the Xen setting in place. It cannot be excluded > that running with LBR enabled has a performance impact, after all. It's possible. 'ler' option already states that it should be used for debugging purposes only, so I think it's fine if this results in slower guest performance, as it's not a general purpose option after all. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:26:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:26:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359926.589207 (Exim 4.92) (envelope-from ) id 1o8HP5-0002iV-I2; Mon, 04 Jul 2022 08:25:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359926.589207; Mon, 04 Jul 2022 08:25:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HP5-0002iO-FL; Mon, 04 Jul 2022 08:25:59 +0000 Received: by outflank-mailman (input) for mailman id 359926; Mon, 04 Jul 2022 08:25:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HP3-0002iG-Ir for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:25:57 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec3adf2d-fb72-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 10:25:55 +0200 (CEST) Received: from AS9PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:20b:46c::20) by VI1PR0802MB2413.eurprd08.prod.outlook.com (2603:10a6:800:b9::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 08:25:52 +0000 Received: from VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::f3) by AS9PR07CA0002.outlook.office365.com (2603:10a6:20b:46c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.13 via Frontend Transport; Mon, 4 Jul 2022 08:25:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT045.mail.protection.outlook.com (10.152.19.51) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 08:25:51 +0000 Received: ("Tessian outbound 879f4da7a6e9:v121"); Mon, 04 Jul 2022 08:25:51 +0000 Received: from b251d42e738d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5FBC16E6-3FCE-44AD-80A7-8A1D8375F6D7.1; Mon, 04 Jul 2022 08:25:44 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b251d42e738d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 08:25:44 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB5876.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 08:25:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 08:25:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec3adf2d-fb72-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NH2gG/T/sWSwR6mQBi74JpD+9iq+p1EDoeOfDkHmKQ7EK51HxdouTJUL9Mb9r2RSkqaV1lwADmblGY40TehORECoCqfaxaFkPFQBNmjrs+zm8oXe7R9upJRIBy1MJN6MMphL/iLANruJlxGiQpdJ/cMyy0qscYj68E1w0ndGr9cu9WgfJ7QAq/bORnc81lvUpb7rcCZZ9S2vHwpraAs3KERc4/Obc3bXMMqwISCuVYb8Bdafe3UAu/8ZCMniuBe47wLRJBZ17pOsgAZ+6EWh0AjsIKAqYGaZkuJ2A5W+eJekQ/tFmpWqjoRbog9cFmK0EIC4G0Qn5lPsRgdLN4Lovw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSGkZuZWUzelbyoh0bkhI+vSmzyC5A19iqWkuxoyJuk=; b=h2sqnjlWntJc8+DtG0BxXK7DSzbB1Y+pfntGa8PDqhHkjsi5FwX1oTmkqI4Jdm7q+0gUtTRmOm5SeAz9C/EV0T71s/mf+qX3GxWe2MOBqPjnlST28ZCNoUXmN02NQvyJiBU/T8kWkoot+zT5XSYN1/cntroPGKRcZH7Ys92xRZUiEgeucP41bmuaCYaRzMSFMy5XsJdBeohqDSZEImWUbGuMQZS+TA4RXZ2M3+pZ6vK3o6ubr0fBlJfiHuP7tDp4x90gGCvTEv0Ro5T+NSlnaprV9rUusLLUaKyTNOdtsW2Yl3SWiECMKLNwiZyrCsouaaovr8z+mIEOL77BTTzpcg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSGkZuZWUzelbyoh0bkhI+vSmzyC5A19iqWkuxoyJuk=; b=Hj52l2urtMk/zghoBceWe3DF/LLUc727y1FWgJqDYMbbxqHCpuhVeBXRMuBa58xr2YUWX+Mf1F/9haqrQKysL6mPbrVLqHkS8j9yOJZhb2YKH2Xl+eOkVEpHgmbN46M2QzDoXZ/N8AIzNBTgohQWpmoVtEiz8oN/vdOIa2eSs4U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9037251a07c3b247 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TcX9oOWRJItCeEEBp7q81h8UniWEE1rKuy2Q43coGTLLMq8dF+zQQKPFJi5WT3RfTwpvN5RdRtZLCeRwf9xX9M9STeZT1QFnUJRKa/U62dSpNSCb3IBofQVc6m77WNlEJ8RteAh40iaNB89/9gfCS4eUCooYck4EtqUJcqcSAU+94eYvvVh7iRgYaQZ6uJNJExYLcb+jZv8mG2t+1wHfD/nTMhLQHZ4ecpVedOOTy1ZckuaIgyKdbeabXbT15VKCOi0st+2Jr1havbiPiHNzjBp0NMEEkVkoVmReMXnnbJswvYPAoG85qLfzAJnN0I3RR2lIkMGLKHV+Uhu89yy1mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dSGkZuZWUzelbyoh0bkhI+vSmzyC5A19iqWkuxoyJuk=; b=R8/BFvVCHHA2de4+HDRCEavCS7zeMpM03SifJR2N55cdKudrT1Av7YdUJhbRN2HJJ/0JwISvZGAucn4zzuHTpRjrtalVgYiF3I9NsiWZgAqH7GuYL6zu0wheChDMvEso6KVClx3HQPx8b1MGERxCZNJS4p3ef64nbt/MK2iirh+11tMJ6ctKl5pRWiuSL6fR7IrQO1/Vw4WJshIhp49oGYdxVrnS2YzVoewvEn9HQU9Su74kuGERNFmlM/oSGiMmUORQgVQcN6bROCZa2Qc2aVbmB/EAY6Bs8YASaqkmHlplFl57hvivgsoriAQjasBrBhoFPqk2RCDiHGTxBo+7fQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dSGkZuZWUzelbyoh0bkhI+vSmzyC5A19iqWkuxoyJuk=; b=Hj52l2urtMk/zghoBceWe3DF/LLUc727y1FWgJqDYMbbxqHCpuhVeBXRMuBa58xr2YUWX+Mf1F/9haqrQKysL6mPbrVLqHkS8j9yOJZhb2YKH2Xl+eOkVEpHgmbN46M2QzDoXZ/N8AIzNBTgohQWpmoVtEiz8oN/vdOIa2eSs4U= From: Luca Fancellu To: Xenia Ragiadakou CC: Bertrand Marquis , Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYj3bsMO2Y3PSLZ0WCUDTYt37uBq1t0/kAgAAEvQCAAAI0gIAABXOA Date: Mon, 4 Jul 2022 08:25:43 +0000 Message-ID: References: <20220704072232.117517-1-burzalodowa@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: abc9f04e-b461-48c5-45e0-08da5d96ce77 x-ms-traffictypediagnostic: AM9PR08MB5876:EE_|VE1EUR03FT045:EE_|VI1PR0802MB2413:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bL15ToF/SxR+nNRYIRU1qK7j8PkgUOwMsTb7ckEA+8r+2II6Tc5/AYH0F7R3Xfw2fJnmkILGfhJp2GCoEQRoaNuTiVZFy2I+G4uqpfh+CZacqFfPF+GgIQRziOXq6/pRdxeIcdrXypmCHoq4lZfy0fu5pivagimU3T0HJnLuG1Zg2wCVA7OgdLIeZHK7y3FecJ4RTqjRp7kujfpEE68zuCh77RZdkerliaJPCMiFmEe+Vkf1tMHhRG27hpxql8cKDZJxd26vh/znsc1Wfk9hHoEE1Fd3BQcjn0aQrOOkMCy+M3ru762mlpn4Bq1PCjXm8Jgu1hUa3GGaF6sjRWpP/rbx96Svik0v5wxaIFqdgIN4MhvcB1TIbUmK5kL8I+39qfUxppm7CwEJ27TzijdKrWZkbg6c/pqDn7sjIhak6fB/V1ruNNi4cZCOd8GfcNkoDdaAva8RJ+BY4gWSbvKvenzNqRybpWhJPyeDrAILCW6at2SZt3L7ej+elZXcYjnIPNLklqxMCg3TOAI6lgUTIKDuCfl8SZw4Q1YloGJaj7MNAnG7X8JwX82+yOuPhEQeIShL7x8TpPQH5zSgleF72CExJaEPk+0VdWEo2EH1yu+UFjCaMnVW/0rvDhPxQe5W7VJWdA7UVuMa/pf12417Dq7JXrxuF7t0w9tCw/vWOZzJFKEYQOvPeA9suWrVQyc7m2FZRAsr1Z2BXIGUtDwrrGjJllq24Jg+hvXzz8Gqms8S1uHBMdSv3uVW6m1G5WQBQegThNiNq14iXZLy0G07/IhWqzUGb0FTGKeTjbMNUr3fGHrGfpxcUgieY0CkolojwPEgDENZGzSEb08+maSWmVdcv+oKRlBaYCBtZd5es3c= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(346002)(366004)(396003)(33656002)(86362001)(122000001)(6486002)(38070700005)(38100700002)(5660300002)(8936002)(478600001)(41300700001)(2906002)(316002)(54906003)(6916009)(71200400001)(64756008)(8676002)(4326008)(66446008)(91956017)(66946007)(76116006)(66476007)(66556008)(186003)(6506007)(53546011)(26005)(6512007)(2616005)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <599D54F8406C344288E7D8EF1861A0F2@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5876 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e7b84482-b017-4a36-500d-08da5d96c95b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QqA2lmK4mj9O79QvjXKCkKesOygkc0LeuYYV7dj+TGoRwS4i2eLgPMHQkBRlR9tHIOLMLWvyFb52TSDqvekUeT4+NmsYc2giI3gEw43cg0uijKl7GOID3eYThhM8hHhXJC1sTr0UST3ZEY3k6X0aQPKxVrtPmWl7Jb0yjohz3vhHJD2SnNnoerqPBfFNGemiVDTVlqE131BVx6pVcvKtQKZnRr7apTChye6ILa8hHA13GRMRa39Qc9pg7HUmi+BDKGKF+03ZcMxFOlK4Yv+eiwOk1kT5hSuSKg8DLyQvErFyGVlfaohDIx054mWHYb6zE/WUujFrXlH5ABRWweCovqoYXlFkvH3gMQP3BqDPIxLCx93CzoGkG10mc2YIdZNRbIckR6W4dFwIfZ/IXGMJW2+Qhw17mcs3OUawrLo+fp/qky6JodXvsyRa0ALLo0GWBwNaygVTRiVTkwUA7W0TLSUp2uR+TsLmkUUtM4ALLVhooxZH6H8BsSxifMAaEBdjlba43b/MdNE/5gmkwBY0fzxGXwgQwzZYp+FzQT6mmRPpBMgBm30w5eRhfK95Rt0w9EhsSm8xkjZsOLH1aYa1Jb9TsGT6DkU3T35PI9xSx8hLMd2yUEYil3LJA2hcKqMfcJMm4d7mXpanyMdRkvc35TxsQ6pfCawwWKSsrh6QcwTvxagJlWMf5kxcQ0LAWB02jCCDaiR9ycglCVsmwrNY0pHiYC/6KYqiyadXfpbbzuNPKlKaZKq11WVwQ/dgQQYQnns1PDg0zs8JwDsILggeV3Yi6WEC5+NHJBVuI/7a38Q= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39850400004)(136003)(346002)(396003)(36840700001)(46966006)(8936002)(5660300002)(6512007)(2616005)(6862004)(86362001)(107886003)(356005)(6506007)(478600001)(33656002)(53546011)(2906002)(41300700001)(82310400005)(26005)(40480700001)(81166007)(83380400001)(186003)(47076005)(336012)(36860700001)(54906003)(36756003)(70586007)(70206006)(316002)(4326008)(8676002)(6486002)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 08:25:51.5644 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abc9f04e-b461-48c5-45e0-08da5d96ce77 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2413 DQoNCj4gT24gNCBKdWwgMjAyMiwgYXQgMDk6MDYsIFhlbmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9k b3dhQGdtYWlsLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+IE9uIDcvNC8yMiAxMDo1OCwgTHVj YSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4gSSBhbSBub3QgMTAwJSBzdXJlIGFib3V0IHRoaXMgcGF0 Y2guDQo+Pj4+IEkgdGhpbmsgc2hvd19zdGFjaygpIHNob3VsZCBiZSBkZWNsYXJlZCB0aGUgc2Ft ZSB3YXkgYXMgc2hvd19yZWdpc3RlcnMoKS4NCj4+Pj4gU28gZWl0aGVyIGJvdGggb2YgdGhlbSB3 aWxsIGJlIGRlY2xhcmVkIHdpdGggZXh0ZXJuYWwgbGlua2FnZSBvciBib3RoIG9mIHRoZW0NCj4+ Pj4gd2lsbCBiZSBkZWNsYXJlZCB3aXRoIGludGVybmFsIGxpbmthZ2UuDQo+Pj4gDQo+Pj4gSSB0 aGluayB0aGF0IHRob3NlIDIgc2hvdWxkIGJlIGRlY2xhcmVkIHdpdGggZXh0ZXJuYWwgbGlua2Fn ZSB3aXRoIGEgY29tbWVudA0KPj4+IGV4cGxhaW5pbmcgd2h5IHRoZXkgYXJlLiBGb3IgbWUgdGhv c2UgYXJlIHVzZWZ1bCB3aGVuIGRldmVsb3Bpbmcgb3IgZGVidWdnaW5nDQo+Pj4gYW5kIEkgc29t ZXRpbWUgY2FsbCB0aG9zZSB0byBmb3JjZSBkdW1waW5nIHRoZSBzdGF0dXMuDQo+Pj4gU28gSSB3 b3VsZCB2b3RlIHRvIGtlZXAgdGhlIGV4dGVybmFsIGxpbmthZ2UuDQo+Pj4gDQo+Pj4+IEkgZGVj aWRlZCB0byBkZWNsYXJlIGJvdGggb2YgdGhlbSBzdGF0aWMgYmVjYXVzZSB0aGV5IGFyZSByZWZl cmVuY2VkIG9ubHkgaW4NCj4+Pj4gdHJhcHMuYyBidXQgSSBjb3VsZCBoYXZlLCBhbHNvLCBhZGQg dGhlIGRlY2xhcmF0aW9uIG9mIHNob3dfc3RhY2soKSBpbg0KPj4+PiBhc20vcHJvY2Vzc29yLmgg aGVhZGVyIGluc3RlYWQuIFJ1bGUgOC43IGlzIGFkdmlzb3J5Lg0KPj4+IA0KPj4+IEFzIHNhaWQg SSB3b3VsZCB2b3RlIGZvciBleHRlcm5hbCBsaW5rYWdlIGhlcmUgYnV0IHdvdWxkIGJlIG5pY2Ug dG8gaGF2ZSBvdGhlcg0KPj4+IGRldmVsb3BlcnMgdmlldyBvbiB0aGlzLg0KPj4+IA0KPj4gSW4g YWRkaXRpb24gdG8gdGhpcywgaWYgd2UgZG9u4oCZdCB3YW50IHRvIHByb3ZpZGUgYSBqdXN0aWZp Y2F0aW9uIGZvciB0aG9zZSwgc2luY2UgdGhleSBzZWVtcyB0byBtZQ0KPj4gY29kZSByZWxhdGVk IHRvIGRlYnVnZ2luZyB0aGV5IGNhbiBiZSByZW1vdmVkIGZyb20g4oCccHJvZHVjdGlvbuKAnSBj b2RlIGluIHNvbWUgd2F5Lg0KPiANCj4gUnVsZSA4LjcgaXMgYWR2aXNvcnksIHNvIEkgdGhpbmsg dGhhdCBmb3JtYWwganVzdGlmaWNhdGlvbiBvZiBkZXZpYXRpb25zIGlzIG5vdCBuZWNlc3Nhcnku DQoNClllcyB0aGF0IGlzIHRydWUsIGluIHRoYXQgY2FzZSB3ZSB3b3VsZCBvbmx5IG5lZWQgdG8g ZG9jdW1lbnQgaXQgd2l0aG91dCBhIGZvcm1hbCBqdXN0aWZpY2F0aW9uLCBob3dldmVyDQppZiB0 aGUgY29kZWJhc2UgZG9lc27igJl0IGluY2x1ZGUgdGhlbSAoYmVjYXVzZSBub3QgaW4gcHJvZHVj dGlvbiBjb2RlKSBJIGd1ZXNzIHRoZSBwcm9ibGVtIGRvZXNu4oCZdCBleGlzdC4NCg0KPiANCj4+ PiBDaGVlcnMNCj4+PiBCZXJ0cmFuZA0KPiANCj4gLS0gDQo+IFhlbmlhDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:28:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:28:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359936.589218 (Exim 4.92) (envelope-from ) id 1o8HRj-0003W4-2V; Mon, 04 Jul 2022 08:28:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359936.589218; Mon, 04 Jul 2022 08:28:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HRi-0003Vx-Vv; Mon, 04 Jul 2022 08:28:42 +0000 Received: by outflank-mailman (input) for mailman id 359936; Mon, 04 Jul 2022 08:28:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HRh-0003Vr-Rk for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:28:41 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60070.outbound.protection.outlook.com [40.107.6.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ef05855-fb73-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 10:28:40 +0200 (CEST) Received: from AS9PR0301CA0044.eurprd03.prod.outlook.com (2603:10a6:20b:469::16) by DB7PR08MB3897.eurprd08.prod.outlook.com (2603:10a6:10:7e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 08:28:38 +0000 Received: from AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::e2) by AS9PR0301CA0044.outlook.office365.com (2603:10a6:20b:469::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.21 via Frontend Transport; Mon, 4 Jul 2022 08:28:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT011.mail.protection.outlook.com (10.152.16.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 08:28:37 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Mon, 04 Jul 2022 08:28:37 +0000 Received: from b9eea51a1eb9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8ECF8AD7-6BB1-4A03-8D8D-AB60572A230C.1; Mon, 04 Jul 2022 08:28:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9eea51a1eb9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 08:28:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB3057.eurprd08.prod.outlook.com (2603:10a6:208:57::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 08:28:29 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Mon, 4 Jul 2022 08:28:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ef05855-fb73-11ec-a8e4-439420d8e422 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YJv07i5zWz9mai3VVLKimttv+pt00s9MFXJVjZlrbfQnQZZyVrLDBdPiwdsVH5/jThWEuBmrtsTGn5UcjCjCwokAkX5/dYsV1rWuOYm6vsyjXkX6/+0rSlhPhuIc9ZdFF8lyODQKFxvgKdLMyxq6eKXQkgxzV6EfuzFVesVuYOtqyPQoOPC4M3Hyrc4IXAx/Dsz7oPQJzrqeNH190fHpJM/ofQOp3N3W2u+ABNgj6MZiWjn6m0gqHz5xBHoLv4n3GctX9vHZn//HfqXN/K/4hpZAxcw3DRHGxeVGreLW2fQWRtXXo5WFDyJ7TImj+4pns6KStNKG+4u4A6AiS6BXyw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=29IMshbie5ViWXGGr5MDzRHkggHdrqM96r8mXJe8s4Y=; b=EN3UfxjqnmosTPXeew2JXzOkuYfJ9jka50tS8DkhlQg6kruO8rpymCtK8G3S0Kyq17QpiHS3gpVAdMFAIuSlzs1R+DuOvRB0Hj8iKhh26EhEiDOHH4b3HRWlyU2Eq6EcDos8JQJN4BRZCNUBK0SZ4QHo7jErtTrhLlbpNsz1tBvgeIAbDkfgJMTn2afHiH6msSwkGzvgojsWxMDdAMyhCGRnSyqz5cVhnlmSsTYc3m2ju0XaxKlLWAn9V9UroRxGUjvNfrBGXV0LnE5MmqNFAZHcsR7v1k6qKQ+2axw3pLMMn53XMdCVGU+zEFw9r4ha+O+2Q9UhNQNLrynQOe4ghA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29IMshbie5ViWXGGr5MDzRHkggHdrqM96r8mXJe8s4Y=; b=au9uVpNbgKw7wQINWYY+IW4c4UNCf6x5GHKs3CfPwERWJ5xla3YVFydEL3Fb5dwu5UPOQAxBnA8HNJmcwZ1I98cefPNJ86E/vdG0Rs7t9XDvpRlBy6/HAspuCKJ4nXrUpzV2cndu103v+nf9tLn7KicrMSZ52UfidH9krmNXSdw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: da9a8b7041059061 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqZlVRqf4cKhqjoKfD75FIftrZKTe5Ev9deB+O5LwKa+EujAgYxuaS+S0UsWngsQvmWW65WmoCRB6HMAyjtgRnbT+UewdFoxre+USUEWDe4TO/pkUWxz0dthoAexZC9Lskp/Jl4M6pStadKolWF9f5IMylrVbgbzz/aRW1AkQiGo6TNG0l2LAQ7GIKhLv7kY5Kwb5FdJmevHIqhvyAtJVTsfVBZqDcOkXX9BzDF0+Qim8aLVlpLtfQzavyh5rDzC/PDMbohYVoiQrOLu5B2+HudHgrlTRb3LBxEQnbBpgMU4uDOIFQA0Vdri+ue+/W7s+MiZNnAn66hPiFHiknblYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=29IMshbie5ViWXGGr5MDzRHkggHdrqM96r8mXJe8s4Y=; b=Fw5hM0kDowBUVPlifWi1y1iVdNV04nIQORBoeq+nNDy8R4VQjEpgGmofid8J7StooQz4L/J9F3NSjpYcuehkQCDnmKZz7dRN6pQhXb8Opi0SRuLkPEqSKNI0D1wzsYduGmnCe0qugTXwI8SAcsX/F5yc6jh+idNCFHCz4Y2jj/4nfDsWf9aKgFKYKrBQ8dTK2FawLZsDQlIK7R/FYPdIy3DjpJy7mRLwZNIsh2gfeHye42rn5RBSRNadxo3k4xepB09IHpTVdnySsH4UCYLhTAJYQc19lBpp6eWZAl+otZaCUqrsrdZfJSvYN4I9SITSLA+vhRA6e7uI+BemsVDLwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=29IMshbie5ViWXGGr5MDzRHkggHdrqM96r8mXJe8s4Y=; b=au9uVpNbgKw7wQINWYY+IW4c4UNCf6x5GHKs3CfPwERWJ5xla3YVFydEL3Fb5dwu5UPOQAxBnA8HNJmcwZ1I98cefPNJ86E/vdG0Rs7t9XDvpRlBy6/HAspuCKJ4nXrUpzV2cndu103v+nf9tLn7KicrMSZ52UfidH9krmNXSdw= From: Bertrand Marquis To: Luca Fancellu CC: Xenia Ragiadakou , Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYj3bjMrWoDl4sYkqZXzEqwsl1S61t0/kAgAAEv4CAAAIygIAABXWAgAAAwwA= Date: Mon, 4 Jul 2022 08:28:27 +0000 Message-ID: References: <20220704072232.117517-1-burzalodowa@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88cc88d4-4652-4356-81e8-08da5d973191 x-ms-traffictypediagnostic: AM0PR08MB3057:EE_|AM5EUR03FT011:EE_|DB7PR08MB3897:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PWjvgpItsCNUL22PCWaLb7bdNFD3LQlR+7GvuObtkNDKBQ20etp7NpYL1TvOqAUUFiRg/bMmIY3Bzh3rXmZq/4nkidf+Quc7jaoYtFPYQB/EsL9MpN1irMs8+0vHs8baG69GavunH+8o06fcAa0qDFkjaaKLgvyQkHRAvrF2B0X/fGZrFYbTzdgQZZRnprNQx/X9Tij2sh/cqQnkpAVp/wCNICw7tyzNFT2Kg7LyAeAaN2hXZGKS3NXviFTqMWPuB/bsAchDP4AFfCaznpkLqF3W0S5KrSvuxUzkFo+rIbqUwU2PxT3gZDzxU/+iBxXPFr5GSelEa0rGIowN9x9ZZpZHzBVoaqEGdrG5MaN2yRAXgL3t6yBRuSVMUpy2lq9jh/w+KpZezQWv2X+7q/Ko8Q556VDhWZ6P7umXNXxCKh7I6vyG9rHL/25uVo7g2jVVOMxYRcmhg1htLQwJgikSUJ0tuPcfQ+jbO0QyTu2ZUuY9DPD+iuEbl3ptaxuq2RFf5qx2AzA6t8I6GCw7Aj0YF2ZtQ+Ar+iCu84udktjE6bggn0AdDGjOg7bZrhobapw5Wbbf2EJtiprrdYQUe2B3lXJBXJ1Uh4cnZUbD5momsb4w5869HS57xt+HenOhKhWqr3jmvaypMxZdulC9C5/MKOT9wb1FDu6ysWIL2ORSQXmC1WTkxMZGXWBN56hcFLGKBpEZGuBpvXCcbGA69nhAPoan1vjH6GmHnVx0b9qQotz1MLgdx+rEpSyk/9uy9m0MkTsBAk9kzrmYlgxgUEcFoYRn/EdH/ioeIe0f28r2i11LjSZXuTUhKzaJN7cNe3XhLBCt4SqKC2EikMCmYvLmz08cKwboUO5SJr0IXVfhWFE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(6636002)(37006003)(86362001)(38100700002)(91956017)(316002)(6486002)(66446008)(76116006)(66556008)(66946007)(64756008)(36756003)(54906003)(4326008)(8676002)(66476007)(5660300002)(2906002)(186003)(53546011)(33656002)(41300700001)(122000001)(38070700005)(8936002)(6862004)(2616005)(478600001)(26005)(6512007)(6506007)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <2ECECEF8BD3A0147849BE8E617FB2082@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3057 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cfa538f3-f88d-469c-4c62-08da5d972b23 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ro/MyDqW5hEeN0dImuqiDPOXKy3CkjGVmpwvROYOo6prLteFn+awLjx9M8agdI/Q+t81UVi0nPy8TUTSLYjPJMdaioXed2G9LeoDWvdboA2S9JamFBVv/uMV1f0p7qMKorOOhhRkuHhMLX5KM31ZblDQsVH3fIr/dKP07bIEJjdkOFY19f6yD7SMdIJ9Jjdl9EBj70v4WXsBY1wsuGOuCmnMX9MptSdpMreAMfBFKB1q2Yff3Zr7mtmQfFckXViTrwIdXPQak6y8HjnAgEawMIRzaQ8ZueJcGyRW5UYd389CVlK3/Oy+qRSGne6/QmMaGhtfI3MhwpmY54ZKx+MqBSfWID0KyBuCsNO1yWEcZkLEzBQkgsEc2mNR34Fy1pZW+5W1gYFWvJWynJ3bu6mm97NVOwKpem88bHLyUDb+BRDcFny73Ah4xp1cW8xMTMAcj6agezkK+lDNV00YKBd2J14/IVoBESsLMp9u/sSce0QNziD45tMjyFpGu3s3h+mQ85S7IjGo6/AizQ06nuBPyWXZIcTnvzr1XDNn6dVM1Q8ELPeFdQ3/8w7W5ZeNdsYX82fGHaqy635d8fGufEL/8YnV/UIgSB3SO6AcUIjhoN39KKfZt2dKE/CbC0WebBmCfe7D2m8oPxIzSP7OEAnBqyHrwiojeBHCVOofW8mYW1alP3VpMeLy6jsrC8yCFrxYVm1X+b/umN0n48ryGVix6kSUK3jXoGhjgKDSnAwhsvHSIIHCPRsFP/T/7JE7auDHj8ledAqo3+aYPjgLC6I1kbSCxHGq1lTsRS32PmF4k64= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39850400004)(396003)(346002)(376002)(136003)(46966006)(36840700001)(70206006)(86362001)(6486002)(478600001)(6512007)(53546011)(70586007)(316002)(26005)(8676002)(6636002)(41300700001)(6506007)(4326008)(82310400005)(37006003)(54906003)(36860700001)(82740400003)(81166007)(2616005)(356005)(336012)(107886003)(83380400001)(47076005)(40480700001)(2906002)(36756003)(186003)(8936002)(5660300002)(33656002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 08:28:37.8629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88cc88d4-4652-4356-81e8-08da5d973191 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3897 DQoNCj4gT24gNCBKdWwgMjAyMiwgYXQgMDk6MjUsIEx1Y2EgRmFuY2VsbHUgPEx1Y2EuRmFuY2Vs bHVAYXJtLmNvbT4gd3JvdGU6DQo+IA0KPiANCj4gDQo+PiBPbiA0IEp1bCAyMDIyLCBhdCAwOTow NiwgWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPiB3cm90ZToNCj4+IA0K Pj4gDQo+PiANCj4+IE9uIDcvNC8yMiAxMDo1OCwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+Pj4+ IEkgYW0gbm90IDEwMCUgc3VyZSBhYm91dCB0aGlzIHBhdGNoLg0KPj4+Pj4gSSB0aGluayBzaG93 X3N0YWNrKCkgc2hvdWxkIGJlIGRlY2xhcmVkIHRoZSBzYW1lIHdheSBhcyBzaG93X3JlZ2lzdGVy cygpLg0KPj4+Pj4gU28gZWl0aGVyIGJvdGggb2YgdGhlbSB3aWxsIGJlIGRlY2xhcmVkIHdpdGgg ZXh0ZXJuYWwgbGlua2FnZSBvciBib3RoIG9mIHRoZW0NCj4+Pj4+IHdpbGwgYmUgZGVjbGFyZWQg d2l0aCBpbnRlcm5hbCBsaW5rYWdlLg0KPj4+PiANCj4+Pj4gSSB0aGluayB0aGF0IHRob3NlIDIg c2hvdWxkIGJlIGRlY2xhcmVkIHdpdGggZXh0ZXJuYWwgbGlua2FnZSB3aXRoIGEgY29tbWVudA0K Pj4+PiBleHBsYWluaW5nIHdoeSB0aGV5IGFyZS4gRm9yIG1lIHRob3NlIGFyZSB1c2VmdWwgd2hl biBkZXZlbG9waW5nIG9yIGRlYnVnZ2luZw0KPj4+PiBhbmQgSSBzb21ldGltZSBjYWxsIHRob3Nl IHRvIGZvcmNlIGR1bXBpbmcgdGhlIHN0YXR1cy4NCj4+Pj4gU28gSSB3b3VsZCB2b3RlIHRvIGtl ZXAgdGhlIGV4dGVybmFsIGxpbmthZ2UuDQo+Pj4+IA0KPj4+Pj4gSSBkZWNpZGVkIHRvIGRlY2xh cmUgYm90aCBvZiB0aGVtIHN0YXRpYyBiZWNhdXNlIHRoZXkgYXJlIHJlZmVyZW5jZWQgb25seSBp bg0KPj4+Pj4gdHJhcHMuYyBidXQgSSBjb3VsZCBoYXZlLCBhbHNvLCBhZGQgdGhlIGRlY2xhcmF0 aW9uIG9mIHNob3dfc3RhY2soKSBpbg0KPj4+Pj4gYXNtL3Byb2Nlc3Nvci5oIGhlYWRlciBpbnN0 ZWFkLiBSdWxlIDguNyBpcyBhZHZpc29yeS4NCj4+Pj4gDQo+Pj4+IEFzIHNhaWQgSSB3b3VsZCB2 b3RlIGZvciBleHRlcm5hbCBsaW5rYWdlIGhlcmUgYnV0IHdvdWxkIGJlIG5pY2UgdG8gaGF2ZSBv dGhlcg0KPj4+PiBkZXZlbG9wZXJzIHZpZXcgb24gdGhpcy4NCj4+Pj4gDQo+Pj4gSW4gYWRkaXRp b24gdG8gdGhpcywgaWYgd2UgZG9u4oCZdCB3YW50IHRvIHByb3ZpZGUgYSBqdXN0aWZpY2F0aW9u IGZvciB0aG9zZSwgc2luY2UgdGhleSBzZWVtcyB0byBtZQ0KPj4+IGNvZGUgcmVsYXRlZCB0byBk ZWJ1Z2dpbmcgdGhleSBjYW4gYmUgcmVtb3ZlZCBmcm9tIOKAnHByb2R1Y3Rpb27igJ0gY29kZSBp biBzb21lIHdheS4NCj4+IA0KPj4gUnVsZSA4LjcgaXMgYWR2aXNvcnksIHNvIEkgdGhpbmsgdGhh dCBmb3JtYWwganVzdGlmaWNhdGlvbiBvZiBkZXZpYXRpb25zIGlzIG5vdCBuZWNlc3NhcnkuDQo+ IA0KPiBZZXMgdGhhdCBpcyB0cnVlLCBpbiB0aGF0IGNhc2Ugd2Ugd291bGQgb25seSBuZWVkIHRv IGRvY3VtZW50IGl0IHdpdGhvdXQgYSBmb3JtYWwganVzdGlmaWNhdGlvbiwgaG93ZXZlcg0KPiBp ZiB0aGUgY29kZWJhc2UgZG9lc27igJl0IGluY2x1ZGUgdGhlbSAoYmVjYXVzZSBub3QgaW4gcHJv ZHVjdGlvbiBjb2RlKSBJIGd1ZXNzIHRoZSBwcm9ibGVtIGRvZXNu4oCZdCBleGlzdC4NCg0KSGF2 aW5nIHRoZSBwcm9kdWN0aW9uIGNvZGUgdXNpbmcgc3RhdGljIGFuZCB0aGUgbm9uIHByb2R1Y3Rp b24gdXNpbmcgZXh0ZXJuYWwgbGlua2FnZSB3b3VsZCBiZSBraW5kIG9mIHdlaXJkIGhlcmUuDQpJ IHRoaW5rIGhhdmluZyB0aGVtIGFsd2F5cyB3aXRoIGV4dGVybmFsIGxpbmthZ2Ugd2l0aCBhIGp1 c3RpZmljYXRpb24gaXMgdGhlIGNsZWFuZXN0IHdheS4NCg0KQ2hlZXJzDQpCZXJ0cmFuZA0KDQo+ IA0KPj4gDQo+Pj4+IENoZWVycw0KPj4+PiBCZXJ0cmFuZA0KPj4gDQo+PiAtLQ0KPj4gWGVuaWEN Cg0K From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:30:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:30:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359942.589229 (Exim 4.92) (envelope-from ) id 1o8HTd-0004r7-FN; Mon, 04 Jul 2022 08:30:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359942.589229; Mon, 04 Jul 2022 08:30:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HTd-0004r0-BC; Mon, 04 Jul 2022 08:30:41 +0000 Received: by outflank-mailman (input) for mailman id 359942; Mon, 04 Jul 2022 08:30:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HTc-0004qu-Eg for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:30:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HTb-0002zF-PU; Mon, 04 Jul 2022 08:30:39 +0000 Received: from [54.239.6.187] (helo=[192.168.26.128]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8HTb-0004Qu-JO; Mon, 04 Jul 2022 08:30:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CJdok87IbF3UoHfVOHW6zoB2DBgxp5gVl2tBECzIXv4=; b=UegokG2pM8hhWL84dvnwtDCD1x id21tmX+UwtcumNTcUdwPUS5lzKCgzaWjDNcPtMknUGXOX18nhbxywg1XIsk+GRmR4enLy6Y+n/XV 4F4d7YIt8lNaMnmkRxhVEtsHcTzB5bRpgZ+Y7tiuQ1FSG7wNJMIZorrciDm9J1Hqr6sw=; Message-ID: <8970b2a7-d754-7db3-7f43-f2d30c626dc4@xen.org> Date: Mon, 4 Jul 2022 09:30:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation To: Bertrand Marquis , Luca Fancellu Cc: Xenia Ragiadakou , Xen-devel , Stefano Stabellini , Volodymyr Babchuk References: <20220704072232.117517-1-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 04/07/2022 09:28, Bertrand Marquis wrote: >> On 4 Jul 2022, at 09:25, Luca Fancellu wrote: >> >> >> >>> On 4 Jul 2022, at 09:06, Xenia Ragiadakou wrote: >>> >>> >>> >>> On 7/4/22 10:58, Luca Fancellu wrote: >>>>>> I am not 100% sure about this patch. >>>>>> I think show_stack() should be declared the same way as show_registers(). >>>>>> So either both of them will be declared with external linkage or both of them >>>>>> will be declared with internal linkage. >>>>> >>>>> I think that those 2 should be declared with external linkage with a comment >>>>> explaining why they are. For me those are useful when developing or debugging >>>>> and I sometime call those to force dumping the status. >>>>> So I would vote to keep the external linkage. >>>>> >>>>>> I decided to declare both of them static because they are referenced only in >>>>>> traps.c but I could have, also, add the declaration of show_stack() in >>>>>> asm/processor.h header instead. Rule 8.7 is advisory. >>>>> >>>>> As said I would vote for external linkage here but would be nice to have other >>>>> developers view on this. >>>>> >>>> In addition to this, if we don’t want to provide a justification for those, since they seems to me >>>> code related to debugging they can be removed from “production” code in some way. >>> >>> Rule 8.7 is advisory, so I think that formal justification of deviations is not necessary. >> >> Yes that is true, in that case we would only need to document it without a formal justification, however >> if the codebase doesn’t include them (because not in production code) I guess the problem doesn’t exist. > > Having the production code using static and the non production using external linkage would be kind of weird here. > I think having them always with external linkage with a justification is the cleanest way. +1 this is what I was going to answer :). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:37:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:37:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359950.589243 (Exim 4.92) (envelope-from ) id 1o8HaB-0005Z3-6b; Mon, 04 Jul 2022 08:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359950.589243; Mon, 04 Jul 2022 08:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HaB-0005Yw-3u; Mon, 04 Jul 2022 08:37:27 +0000 Received: by outflank-mailman (input) for mailman id 359950; Mon, 04 Jul 2022 08:37:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Ha9-0005Wx-Jt for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:37:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8489e7d9-fb74-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 10:37:20 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 591AB22C84; Mon, 4 Jul 2022 08:37:22 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 284AA1342C; Mon, 4 Jul 2022 08:37:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KjpBCMKmwmLtRAAAMHmgww (envelope-from ); Mon, 04 Jul 2022 08:37:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8489e7d9-fb74-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656923842; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rZAzMpqQkhA3cqGdeTJ3GZ9UFeSdXq4Iv6GcisL74gc=; b=UGgI+n7dFUSmU02N7DjTaF0Ks/cB6kH0h74VLLsepLb5O2PRWImAOZgFs7rvzsh+9TQBLL 5FqDAIyrD2CzMjzIyLn2lDrR5Uo4mXbD8Db/sAIwzyUSNx5J1i7ORWypc24p0Uk33vLXdK jSc/Sf1Gp/physg8GR4QiaPEq/S7lMM= Message-ID: <10e6cfe8-2aaf-2340-a52e-bce0c3373706@suse.com> Date: Mon, 4 Jul 2022 10:37:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 0/8] mini-os: some cleanup patches Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220620073820.9336-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220620073820.9336-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WM0Gqs1fKkUqTFm9W6Z1R5jA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WM0Gqs1fKkUqTFm9W6Z1R5jA Content-Type: multipart/mixed; boundary="------------PePEE1Mhmp0wzxca8CDA7lbO"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: <10e6cfe8-2aaf-2340-a52e-bce0c3373706@suse.com> Subject: Re: [PATCH 0/8] mini-os: some cleanup patches References: <20220620073820.9336-1-jgross@suse.com> In-Reply-To: <20220620073820.9336-1-jgross@suse.com> --------------PePEE1Mhmp0wzxca8CDA7lbO Content-Type: multipart/mixed; boundary="------------786vqAUT4rEB3IipjWt0idez" --------------786vqAUT4rEB3IipjWt0idez Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjAuMDYuMjIgMDk6MzgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IERvIHNvbWUgY2xl YW51cHMuDQo+IA0KPiBObyBmdW5jdGlvbmFsIGNoYW5nZSBpbnRlbmRlZCwgYXBhcnQgZnJv bSB3aGl0ZXNwYWNlIGNoYW5nZXMgb25seQ0KPiBtaW5vciBtb2RpZmljYXRpb25zIG1ha2lu ZyBjb2RlIGVhc2llciB0byByZWFkLg0KPiANCj4gSnVlcmdlbiBHcm9zcyAoOCk6DQo+ICAg IG1pbmktb3M6IGRyb3AgeGVuYnVzIGRpcmVjdG9yeQ0KPiAgICBtaW5pLW9zOiBhcHBseSBj b2Rpbmcgc3R5bGUgdG8geGVuYnVzLmMNCj4gICAgbWluaS1vczogZWxpbWluYXRlIGNvbnNv bGUvY29uc29sZS5oDQo+ICAgIG1pbmktb3M6IHJlbmFtZSBjb25zb2xlL3hlbmJ1cy5jIHRv IGNvbnNmcm9udC5jDQo+ICAgIG1pbmktb3M6IGFwcGx5IGNvZGluZyBzdHlsZSB0byBjb25z ZnJvbnQuYw0KPiAgICBtaW5pLW9zOiBlbGltaW5hdGUgY29uc29sZSBkaXJlY3RvcnkNCj4g ICAgbWluaS1vczogYXBwbHkgY29kaW5nIHN0eWxlIHRvIGNvbnNvbGUuYw0KPiAgICBtaW5p LW9zOiBhZGQgbWluaS1vcy1kZWJ1Z1suZ3pdIHRvIC5naXRpZ25vcmUNCj4gDQo+ICAgLmdp dGlnbm9yZSAgICAgICAgICAgICAgICAgICAgICB8ICAgMiArDQo+ICAgTWFrZWZpbGUgICAg ICAgICAgICAgICAgICAgICAgICB8ICAgOSArLQ0KPiAgIGNvbnNvbGUveGVuYnVzLmMgPT4g Y29uc2Zyb250LmMgfCAgOTkgKysrKy0tLQ0KPiAgIGNvbnNvbGUuYyAgICAgICAgICAgICAg ICAgICAgICAgfCA0MTUgKysrKysrKysrKysrKysrKysrKysrKysrKysNCj4gICBjb25zb2xl L2NvbnNvbGUuYyAgICAgICAgICAgICAgIHwgMTc3IC0tLS0tLS0tLS0tDQo+ICAgY29uc29s ZS9jb25zb2xlLmggICAgICAgICAgICAgICB8ICAgMiAtDQo+ICAgY29uc29sZS94ZW5jb25z X3JpbmcuYyAgICAgICAgICB8IDIzOCAtLS0tLS0tLS0tLS0tLS0NCj4gICBpbmNsdWRlL2Nv bnNvbGUuaCAgICAgICAgICAgICAgIHwgICAxICsNCj4gICB4ZW5idXMveGVuYnVzLmMgPT4g eGVuYnVzLmMgICAgIHwgNTEwICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tDQo+ ICAgOSBmaWxlcyBjaGFuZ2VkLCA3NzggaW5zZXJ0aW9ucygrKSwgNjc1IGRlbGV0aW9ucygt KQ0KPiAgIHJlbmFtZSBjb25zb2xlL3hlbmJ1cy5jID0+IGNvbnNmcm9udC5jICg3OCUpDQo+ ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGNvbnNvbGUuYw0KPiAgIGRlbGV0ZSBtb2RlIDEwMDY0 NCBjb25zb2xlL2NvbnNvbGUuYw0KPiAgIGRlbGV0ZSBtb2RlIDEwMDY0NCBjb25zb2xlL2Nv bnNvbGUuaA0KPiAgIGRlbGV0ZSBtb2RlIDEwMDY0NCBjb25zb2xlL3hlbmNvbnNfcmluZy5j DQo+ICAgcmVuYW1lIHhlbmJ1cy94ZW5idXMuYyA9PiB4ZW5idXMuYyAoNzElKQ0KPiANCg0K Q291bGQgc29tZW9uZSBwbGVhc2UgY29tbWl0IHRoaXMgc2VyaWVzPyBTYW11ZWwgZ2F2ZSBo aXMgUi1iIG5lYXJseSAyIHdlZWtzDQphZ28uDQoNCg0KSnVlcmdlbg0K --------------786vqAUT4rEB3IipjWt0idez Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------786vqAUT4rEB3IipjWt0idez-- --------------PePEE1Mhmp0wzxca8CDA7lbO-- --------------WM0Gqs1fKkUqTFm9W6Z1R5jA Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLCpsEFAwAAAAAACgkQsN6d1ii/Ey8s PQgAjUcrtcsGOPCBwb7gXLyaSUATq9pkDsVdRHO/UfFP+18fAepXFXsYoYBBN1LGOXirhidcinrn aO4+uH6T4XcpOIuToqkn81+WPfPKol8xwpDmRshJiYArDN3yN0mdQHgaGNGWIGamYlPtEQq/d4vz pKaPer01Uo33Xg5GoE39VgYDoxkit9RSQiAaVllnZp9neOS+yrWOvwHiVh33xtYoc8xFHxz1fetX 0twUMJrdiujGbEJTVJ8zoGUX4FICZ1m+FU8FIEz7yiENvXl9fQu2bTKldL+PvwCBuJJOd3xY4xDL oQMvALTPA2i7nPTu9Fsj30R+ZzpsvTaxv3bdnG99FQ== =mu2C -----END PGP SIGNATURE----- --------------WM0Gqs1fKkUqTFm9W6Z1R5jA-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:38:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:38:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359960.589259 (Exim 4.92) (envelope-from ) id 1o8HbI-0006Ks-NE; Mon, 04 Jul 2022 08:38:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359960.589259; Mon, 04 Jul 2022 08:38:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HbI-0006Kl-KN; Mon, 04 Jul 2022 08:38:36 +0000 Received: by outflank-mailman (input) for mailman id 359960; Mon, 04 Jul 2022 08:38:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HbH-0006Ia-Rw for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:38:35 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afa0763d-fb74-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 10:38:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2D69D22C8C; Mon, 4 Jul 2022 08:38:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EB0A71342C; Mon, 4 Jul 2022 08:38:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EvWQNwenwmJdRQAAMHmgww (envelope-from ); Mon, 04 Jul 2022 08:38:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afa0763d-fb74-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656923912; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=g59baueviiuVxbnrE4vMTCgyQzKbt3DIfj+P6+Br8yQ=; b=OnlUFgCigruRaPtoJyIelwUh3gs8XrhY4Ggrx32qE7k2utUdBuueY1H7u4NBXxw23ShEZM OA2b27LS72AkOe8lS5zLKP4ObgZb4kYAB38z+MaRhK3YRYmjXdHZV6SWel+hPcnTDd8I9C TVhHnBYQB9A9sgL17uF/AOnduRweCbQ= Message-ID: <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> Date: Mon, 4 Jul 2022 10:38:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH Content-Language: en-US To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220621072314.16382-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220621072314.16382-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------jZ47KsstpPBBJ5dPHTVPZItc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------jZ47KsstpPBBJ5dPHTVPZItc Content-Type: multipart/mixed; boundary="------------RtEMhtC7U0oUWFG1YItA0vTj"; protected-headers="v1" From: Juergen Gross To: minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH References: <20220621072314.16382-1-jgross@suse.com> In-Reply-To: <20220621072314.16382-1-jgross@suse.com> --------------RtEMhtC7U0oUWFG1YItA0vTj Content-Type: multipart/mixed; boundary="------------sBNXBlmh9DtZYMunS1MqSTep" --------------sBNXBlmh9DtZYMunS1MqSTep Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjEuMDYuMjIgMDk6MjMsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IERvIHNvbWUgbWVt b3J5IG1hcCByZWxhdGVkIGNoYW5nZXMvZml4ZXMgZm9yIFBWSCBtb2RlOg0KPiANCj4gLSBQ cmVmZXIgdGhlIG1lbW9yeSBtYXAgZGVsaXZlcmVkIHZpYSBzdGFydC1pbmZvIG92ZXIgdGhl IG9uZSBvYnRhaW5lZA0KPiAgICBmcm9tIHRoZSBoeXBlcnZpc29yLiBUaGlzIGlzIGEgcHJl cmVxdWlzaXRlIGZvciBYZW5zdG9yZS1zdHViZG9tDQo+ICAgIGxpdmUtdXBkYXRlIHdpdGgg cmlzaW5nIHRoZSBtZW1vcnkgbGltaXQuDQo+IA0KPiAtIEZpeCBhIGJ1ZyByZWxhdGVkIHRv IGJhbGxvb25pbmcgaW4gUFZIIG1vZGU6IFBWSCBYZW5zdG9yZS1zdHViZG9tDQo+ICAgIGNh bid0IHJlYWQgaXRzIHRhcmdldCBtZW1vcnkgc2l6ZSBmcm9tIFhlbnN0b3JlLCBhcyB0aGlz IGludHJvZHVjZXMNCj4gICAgYSBjaGlja2VuLWFuZC1lZ2cgcHJvYmxlbS4gVGhlIG1lbW9y eSBzaXplIHJlYWQgZnJvbSB0aGUgaHlwZXJ2aXNvcg0KPiAgICBPVE9IIGluY2x1ZGVzIGFk ZGl0aW9uYWwgInNwZWNpYWwiIHBhZ2VzIG1hcmtlZCBhcyByZXNlcnZlZCBpbiB0aGUNCj4g ICAgbWVtb3J5IG1hcC4gVGhvc2UgcGFnZXMgbmVlZCB0byBiZSBzdWJ0cmFjdGVkIGZyb20g dGhlIHJlYWQgc2l6ZS4NCj4gDQo+IC0gRml4IGEgYnVnIGluIGJhbGxvb25pbmcgY29kZSBp biBQVkggbW9kZSB3aGVuIHVzaW5nIG1lbW9yeSBiZXlvbmQNCj4gICAgYSBSQU0gaG9sZSBp biB0aGUgbWVtb3J5IG1hcA0KPiANCj4gQ2hhbmdlcyBpbiBWMzoNCj4gLSBtaW5vciBjb21t ZW50IGZvciBwYXRjaCAzIGFkZHJlc3NlZA0KPiANCj4gQ2hhbmdlcyBpbiBWMjoNCj4gLSBh ZGRlZCBwYXRjaCA0DQo+IC0gYWRkcmVzc2VkIGNvbW1lbnQgcmVnYXJkaW5nIHBhdGNoIDMN Cj4gDQo+IEp1ZXJnZW4gR3Jvc3MgKDQpOg0KPiAgICBtaW5pLW9zOiB0YWtlIG5ld2VzdCB2 ZXJzaW9uIG9mIGFyY2gteDg2L2h2bS9zdGFydF9pbmZvLmgNCj4gICAgbWluaS1vczogcHJl ZmVyIG1lbW9yeSBtYXAgdmlhIHN0YXJ0X2luZm8gZm9yIFBWSA0KPiAgICBtaW5pLW9zOiBm aXggbnVtYmVyIG9mIHBhZ2VzIGZvciBQVkgNCj4gICAgbWluaS1vczogZml4IGJ1ZyBpbiBi YWxsb29uaW5nIG9uIFBWSA0KPiANCj4gICBhcmNoL3g4Ni9tbS5jICAgICAgICAgICAgICAg ICAgICAgICAgIHwgMjMgKysrKy0tLS0NCj4gICBiYWxsb29uLmMgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTggKystLS0tDQo+ICAgZTgyMC5jICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8IDgzICsrKysrKysrKysrKysrKysrKysrKysrKy0tLQ0KPiAgIGlu Y2x1ZGUvZTgyMC5oICAgICAgICAgICAgICAgICAgICAgICAgfCAgNiArKw0KPiAgIGluY2x1 ZGUveDg2L2FyY2hfbW0uaCAgICAgICAgICAgICAgICAgfCAgMiArDQo+ICAgaW5jbHVkZS94 ZW4vYXJjaC14ODYvaHZtL3N0YXJ0X2luZm8uaCB8IDYzICsrKysrKysrKysrKysrKysrKyst DQo+ICAgNiBmaWxlcyBjaGFuZ2VkLCAxNjMgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25z KC0pDQo+IA0KDQpDb3VsZCBzb21lb25lIHBsZWFzZSBjb21taXQgdGhpcyBzZXJpZXM/IFNh bXVlbCBnYXZlIGhpcyBSLWIgbmVhcmx5IDIgd2Vla3MNCmFnby4NCg0KDQpKdWVyZ2VuDQo= --------------sBNXBlmh9DtZYMunS1MqSTep Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------sBNXBlmh9DtZYMunS1MqSTep-- --------------RtEMhtC7U0oUWFG1YItA0vTj-- --------------jZ47KsstpPBBJ5dPHTVPZItc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLCpwcFAwAAAAAACgkQsN6d1ii/Ey96 Dgf9EmO7gCzs0ZHnQcTkbSahVT22QI2ubWJFdUgFZB6UaHV7wibN2MDi2pxdEVROwmKv6FmtnAfC UWETqaBeNgln+85maH6LVjWkVSGWRliUjSwP6cvUfYk3pEGaaXvb7goKSAc3JFMOsAzvGbNO7V1Q UgtbIN/iRebw++7lJbsY7X0aWv9Co4+2g0cdKtq/J1RHmZ5VbOeEEpl4jr9YqhjjPQJfNcvjn59e FgEbK3ogP4ax/3CsJw858/ryIn4b5jy/HJGIlUPKxo+GB9tWbztip9IUre66xa7RYcob6Z4ZZEQT R697Go43fB79BsfejRWNNIIovRjeIKwiPUKGOKcJjw== =Tq1f -----END PGP SIGNATURE----- --------------jZ47KsstpPBBJ5dPHTVPZItc-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:39:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:39:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359968.589274 (Exim 4.92) (envelope-from ) id 1o8HcP-0006zr-3j; Mon, 04 Jul 2022 08:39:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359968.589274; Mon, 04 Jul 2022 08:39:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HcP-0006zk-0g; Mon, 04 Jul 2022 08:39:45 +0000 Received: by outflank-mailman (input) for mailman id 359968; Mon, 04 Jul 2022 08:39:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HcN-0006xN-Bz; Mon, 04 Jul 2022 08:39:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HcJ-000397-8n; Mon, 04 Jul 2022 08:39:39 +0000 Received: from [54.239.6.187] (helo=[192.168.26.128]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8HcJ-0004xd-2G; Mon, 04 Jul 2022 08:39:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0ai07RFTIsDpeNOCYG7G85s9+3LdXsUGfO+KbNqiteU=; b=cgWxPzwf81W9csWAM+AUNeebaz NzoTOWq0GW88BnuzNpOQGpVnq/ExLIicpwgeHdO+rz3GI4IQLkmsVK8OWC+kd4Ybd+F/Metpq7nHb +UudVhuKRNoXyW1//h4pour/znMzuYGAMQIL3YYWPsFPT40fVuxq7fBrinY+ThWwz6Ko=; Message-ID: <7ce54a47-9795-310f-c5cb-55f1b6fcdd93@xen.org> Date: Mon, 4 Jul 2022 09:39:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/8] mini-os: some cleanup patches To: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220620073820.9336-1-jgross@suse.com> <10e6cfe8-2aaf-2340-a52e-bce0c3373706@suse.com> From: Julien Grall In-Reply-To: <10e6cfe8-2aaf-2340-a52e-bce0c3373706@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 04/07/2022 09:37, Juergen Gross wrote: > On 20.06.22 09:38, Juergen Gross wrote: >> Do some cleanups. >> >> No functional change intended, apart from whitespace changes only >> minor modifications making code easier to read. >> >> Juergen Gross (8): >>    mini-os: drop xenbus directory >>    mini-os: apply coding style to xenbus.c >>    mini-os: eliminate console/console.h >>    mini-os: rename console/xenbus.c to consfront.c >>    mini-os: apply coding style to consfront.c >>    mini-os: eliminate console directory >>    mini-os: apply coding style to console.c >>    mini-os: add mini-os-debug[.gz] to .gitignore >> >>   .gitignore                      |   2 + >>   Makefile                        |   9 +- >>   console/xenbus.c => consfront.c |  99 ++++--- >>   console.c                       | 415 ++++++++++++++++++++++++++ >>   console/console.c               | 177 ----------- >>   console/console.h               |   2 - >>   console/xencons_ring.c          | 238 --------------- >>   include/console.h               |   1 + >>   xenbus/xenbus.c => xenbus.c     | 510 +++++++++++++++++++------------- >>   9 files changed, 778 insertions(+), 675 deletions(-) >>   rename console/xenbus.c => consfront.c (78%) >>   create mode 100644 console.c >>   delete mode 100644 console/console.c >>   delete mode 100644 console/console.h >>   delete mode 100644 console/xencons_ring.c >>   rename xenbus/xenbus.c => xenbus.c (71%) >> > > Could someone please commit this series? Samuel gave his R-b nearly 2 weeks > ago. I will commit this series and the other you pointed out. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:54:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:54:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359980.589288 (Exim 4.92) (envelope-from ) id 1o8HqI-000120-Dj; Mon, 04 Jul 2022 08:54:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359980.589288; Mon, 04 Jul 2022 08:54:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HqI-00011q-9K; Mon, 04 Jul 2022 08:54:06 +0000 Received: by outflank-mailman (input) for mailman id 359980; Mon, 04 Jul 2022 08:54:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HqG-00011P-Jf; Mon, 04 Jul 2022 08:54:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HqC-0003Od-2k; Mon, 04 Jul 2022 08:54:00 +0000 Received: from [54.239.6.187] (helo=[192.168.26.128]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8HqB-0005WQ-SH; Mon, 04 Jul 2022 08:54:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:From:Subject:MIME-Version:Date:Message-ID; bh=eSHskeKFGbG1KZzjx+6Gf+BDAnyv6QWb9O0BzKpkEIo=; b=0c/xYyUl7ExTc3WmaIkA1LS4+X ncCv7HT7Y8+deV9yvuEAcV3F3msqnT8ctjHL0OFAUqeY4T+6ImLLUJY263PJ0QNyJ/U2WK5JXbsZc o82ON7svMxQQOL5k/TrHiuIjfs0/dtzRcjf2xEaF4J+hWEgijAyw1soTmKS2KgS9RznE=; Message-ID: <93d24653-472c-c54f-3f69-e8f9ddd6e6a8@xen.org> Date: Mon, 4 Jul 2022 09:53:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/8] mini-os: some cleanup patches From: Julien Grall To: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220620073820.9336-1-jgross@suse.com> <10e6cfe8-2aaf-2340-a52e-bce0c3373706@suse.com> <7ce54a47-9795-310f-c5cb-55f1b6fcdd93@xen.org> In-Reply-To: <7ce54a47-9795-310f-c5cb-55f1b6fcdd93@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 04/07/2022 09:39, Julien Grall wrote: > Hi Juergen, > > On 04/07/2022 09:37, Juergen Gross wrote: >> On 20.06.22 09:38, Juergen Gross wrote: >>> Do some cleanups. >>> >>> No functional change intended, apart from whitespace changes only >>> minor modifications making code easier to read. >>> >>> Juergen Gross (8): >>>    mini-os: drop xenbus directory >>>    mini-os: apply coding style to xenbus.c >>>    mini-os: eliminate console/console.h >>>    mini-os: rename console/xenbus.c to consfront.c >>>    mini-os: apply coding style to consfront.c >>>    mini-os: eliminate console directory >>>    mini-os: apply coding style to console.c >>>    mini-os: add mini-os-debug[.gz] to .gitignore >>> >>>   .gitignore                      |   2 + >>>   Makefile                        |   9 +- >>>   console/xenbus.c => consfront.c |  99 ++++--- >>>   console.c                       | 415 ++++++++++++++++++++++++++ >>>   console/console.c               | 177 ----------- >>>   console/console.h               |   2 - >>>   console/xencons_ring.c          | 238 --------------- >>>   include/console.h               |   1 + >>>   xenbus/xenbus.c => xenbus.c     | 510 +++++++++++++++++++------------- >>>   9 files changed, 778 insertions(+), 675 deletions(-) >>>   rename console/xenbus.c => consfront.c (78%) >>>   create mode 100644 console.c >>>   delete mode 100644 console/console.c >>>   delete mode 100644 console/console.h >>>   delete mode 100644 console/xencons_ring.c >>>   rename xenbus/xenbus.c => xenbus.c (71%) >>> >> >> Could someone please commit this series? Samuel gave his R-b nearly 2 >> weeks >> ago. > > I will commit this series and the other you pointed out. Done. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:54:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359981.589300 (Exim 4.92) (envelope-from ) id 1o8HqZ-0001RW-LM; Mon, 04 Jul 2022 08:54:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359981.589300; Mon, 04 Jul 2022 08:54:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HqZ-0001RP-HD; Mon, 04 Jul 2022 08:54:23 +0000 Received: by outflank-mailman (input) for mailman id 359981; Mon, 04 Jul 2022 08:54:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HqX-0001PS-Lg for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 08:54:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2051.outbound.protection.outlook.com [40.107.22.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e481961a-fb76-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 10:54:20 +0200 (CEST) Received: from FR0P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::19) by VI1PR08MB4590.eurprd08.prod.outlook.com (2603:10a6:803:c3::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 08:54:18 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::a6) by FR0P281CA0037.outlook.office365.com (2603:10a6:d10:48::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.13 via Frontend Transport; Mon, 4 Jul 2022 08:54:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 08:54:17 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Mon, 04 Jul 2022 08:54:16 +0000 Received: from adca620d8b7f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 29CD4477-65E4-457E-A283-AE302BF87B47.1; Mon, 04 Jul 2022 08:54:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id adca620d8b7f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 08:54:06 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DU2PR08MB7238.eurprd08.prod.outlook.com (2603:10a6:10:2d1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 08:54:04 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 08:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e481961a-fb76-11ec-a8e4-439420d8e422 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=R5EuJMPXHSDJg+dakPHU+VVHA+wrmuxsF+z4FAEWhnJCL8XrYVHt4FkFpUeeZxaoX06TkKkSSDzWago5U4mD6rekOJzqoBJiwVadIF3WYhvNyVD1glrULMBgx/ql9SgpMfFnSBjCK7p36a+asGGfS7y4bESkvYvKmBwAn36HuZ+qrEtAyGuQr4HkGQIC1zf8K2cMeSKHcL8s1HquJu0kH+ZD0kWpVAMyKci0LqLMRGtcJy+G4OTwaIeV7qpt1t9FbL5oVB65rXQ6aRx5kZf0HSRyeJKEzDAJBLxH/Y948nZe9vRDRb2h6nwi+lZI1ryBrETrjw+qAFXGyMnUm66XKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ffi6JJLQ5BF3CUzzlUVg3HLCClMSucEA7cdEB5BKdZc=; b=j/vWycgmyU4iVYqEhvoj4JPpVwCKk5QbcWvO9WicL3xiNAgukwDGcLgi+cQIm4scHbQd0jig45s4Y7Sas05xtWziqRU56rjjmr0LW98q/zTL5kVZYOm4yHUOyYbMQaVz8jL4GBv2lN7FwRw6LQntJ8hXYreXTntJATuAuYRnG02Ix9TBDNVLBIRUg0Sm/yfjoXMCBEXqR04txJ4Xepd7k4vTfcCbsh62QLbMiE6fik8ESZKCpmazItAK4+4PU7po56Z3WwS6G7Cz3EeO+rlubdks76BnJbUwoHDaM+ipPCD6joovsdgN8BvgmDB/85f9vGzUXNh96ifSYhQk+0cVuw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ffi6JJLQ5BF3CUzzlUVg3HLCClMSucEA7cdEB5BKdZc=; b=C9fKUuTMAhMlhvbg8ttC37nRZXYB+93qFJZWzbHmP/sq/UGhCGyUhIIUksz+mkMOHKfDlN68Br0zrbh+GvdWvDde9fTAbqpxM6sRmaM5mn8OGviFNCfCyvV5+Ag3JqYoBGJak6GC9fF0Gr7UJjESo7YwL/PB5JEaHjqSm77VA/w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2c076e7992baf2f6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g63tzO12k0PAJyJGS/YFlgHnN/1wQRs53dWphSu6xPXJ6ymEEwioCReDrjknRgA/Mlm/88wn4ZJKZVKF2xDNi3wTjIQ9r80kRrh/d+HLOhJuPoPr5FQgQG6M8AnMUxrzNkWIKecri0bsBOjyuz1ubu07br29FghUsqaSPf/0geFuD0aD3ZObrHNaZxzBJzg5m+0rmuPK/FsMauavEZQfEfQazloNSFJGcyM3esMKOmfS0lPa/LCRE3FWRWPAcvItBgvfVr8//wO0RY3R8RRUdR2XvjUynwqvdagEg2B7WNUNGlaoyPAXuoYgGGEgwxZlTqzKK47OMbavS0kJ54zniw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ffi6JJLQ5BF3CUzzlUVg3HLCClMSucEA7cdEB5BKdZc=; b=aefJk4T0AZgjNW4T39ul9yxBGR27w9LifWsjErwzKgHrYdwIML1uMManQsEXNDe7tgNjwliK4hckEq8DQ4Nv/aszvHH6mW01UI48lGu9E4+5oIInjQr8yt1+fQtRf10ZxU5WLVBduN7Rz6g0a7CDSwAAbLCkCUbZ7Zbg90ZP+3xoLSigMOEYn2Kj6gb5StglxYXvYW6NDswR7R1O6QAP7WXrXOkgjg4Nv/pmyx++pqsaf55bb7AeR3byvJdPXk3Z/Zx6ZRg5cfkskGLwvttRxTsgj7usyE1UgQUzSKXRzOiT/orJKRIa2ubYutumcKUYRNojwQCPRbLc2PXS75kUBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ffi6JJLQ5BF3CUzzlUVg3HLCClMSucEA7cdEB5BKdZc=; b=C9fKUuTMAhMlhvbg8ttC37nRZXYB+93qFJZWzbHmP/sq/UGhCGyUhIIUksz+mkMOHKfDlN68Br0zrbh+GvdWvDde9fTAbqpxM6sRmaM5mn8OGviFNCfCyvV5+Ag3JqYoBGJak6GC9fF0Gr7UJjESo7YwL/PB5JEaHjqSm77VA/w= From: Luca Fancellu To: Julien Grall CC: Bertrand Marquis , Xenia Ragiadakou , Xen-devel , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYj3bsMO2Y3PSLZ0WCUDTYt37uBq1t0/kAgAAEvQCAAAI0gIAABXOAgAAAxoCAAACbgIAABosA Date: Mon, 4 Jul 2022 08:54:04 +0000 Message-ID: <7C0683EE-4D8C-490E-997F-D54514312022@arm.com> References: <20220704072232.117517-1-burzalodowa@gmail.com> <8970b2a7-d754-7db3-7f43-f2d30c626dc4@xen.org> In-Reply-To: <8970b2a7-d754-7db3-7f43-f2d30c626dc4@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d13c9609-a3aa-4d9f-fb7a-08da5d9ac72a x-ms-traffictypediagnostic: DU2PR08MB7238:EE_|VE1EUR03FT013:EE_|VI1PR08MB4590:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7/LlCF9Pnc44MNj8MgvX2Wu12YCrcehnSX+9hX0xDMThGyXxtq8OqMzXD+pjCeRL9CH0Ou+Hi5RMJiYAc2zm4reEpMCgRtxX0S/H6D2ITfd82J/wD1VbKBN6slw9wqir3gJtoQXb3yUw7fvNP1A+fDUluYfAybr2tK0vKoEIJemlVcw5IRLe9fP6e1LrAziUnZVcQUDX83p7dJzYEJ/VRWV44gm6MeKQ4JP11GSRXeZk4uUCD0ZyDAmkOnlZAcSYzSDjG35pOJpQOcRGAZgIvhKEGXCHPmzUuE5aaP/+JLTSeZinXE/f0angeOiS+4nHe6pRGEN+aNg2dYB4vw/4vGyqockQnO5oz5vFTZ0aXTBH29/7OVPTYePoXVYvyX0qIBMKwWSh86n/hvet7AoFj3tG/D/9zQCx9YCpHZdm/U6cbGH2MOj3U1Dw1+vW3XOJDNAscKLL+HibfnCP0eQWK+DOTsrg+h9DEuj20S0hARUANnJ7PrTML9hTmh1+L9tWP11OzjxmW1z98Ygalbfb4JkO99VD5M2p+5lKp/SMYdNbipte9NCeOxhVSWB4OMQ/az2DeU4YcHQ5OweSTc65/dRUwU9oLA3VH5XXkan/3h7fmKdE5JQdWh8QbLUgQwI+T2WWChYvpVP6Cm82ZExC8rNrRFZm9kqJ2oQsIUHvnO4c3EthZHS0xCw7hvm5NijKEUtRWBBxMWja8fN0By7CCMIUrNvmUiULidn7ga7BmJfNMnOCSQfgHu5aSyxuihZi+8DNiaCtw1nlqKAm7k1IWopHqLeOpM2PuwL1viv9hF/vwjR2Ibazh8pL/wWX+YCK6MrIY2jXwsHcJXQKIvw1ji4VnjtA3vZgILUeOCCPcrk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(136003)(346002)(376002)(396003)(91956017)(66476007)(66446008)(4326008)(64756008)(66556008)(8676002)(66946007)(76116006)(36756003)(122000001)(316002)(38100700002)(71200400001)(38070700005)(6916009)(54906003)(26005)(6512007)(41300700001)(8936002)(6486002)(186003)(5660300002)(33656002)(6506007)(2616005)(2906002)(86362001)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7238 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 013b2010-0d07-4ae2-3d79-08da5d9abf41 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X9x33bNMN9BnH80vOH6XTEd4jLo+zBv6Gs/LKysRWBWp1mxqVB2Juwz262NELItBuVkSHTYYCPU1757J79pYPpMrXVCh3Ya1j8dZAGAKAvPSBFoyPCrAvPKv93uPaCePq7ELkKd+4bqj0Bo0OpTIR5ElONs2asoy03K2G7LDpc6zQhgtWRg56wwzx7ha2M2HdE7k+fKOVc8oAEdJWH4cCKsQOxuyx5q9qplzl+7TkCFerR7V00/ycXVgaCurDrPIY8Hoe43PZWwQAPocTojqDF4RH6Pd6WHOMV73PfkS7Cqifu3ceI0//coRwYFLD8ikzNUHOV7Lpep3cHHETzlwBryx1XWp5wrm0zNwfhGL0PIQvBmHalwEZZ7aPnILh6sRlmGdpZ+aZYkts8wMxvlN6PtLCq33iDWmZTC33guQGQFbiPzZKzByEyW7Iui1BFCNYhboNnxUCqcjEhZoM5AeszfVLt0DuMUKTiOHZEB9YK7eoMWOszzD6/M/TQ1Ks6Rwi47TEaW1RvzzNKXKMfZ1U+BDfKFe0Fa4jm9m+B5Y+j8SNS7BWTFqq1AxGXU1CGZDgMZYbuDguZ5naUvPZlLFKfmMCH34uPXTxT/61NB3iB2tYYpYqRs9rLEgaAJJbW7iETzy78mqImzdd1p8perEwwMV6O1Gl0hPU6I1TKeHIV0tEr8ZOwLDlqmjzsWN0xQ05dSGgSgPqRDvxjzbx54P7FcF3xxqv551eqoabSEveLKImQUTstgndNS4oQSGWEGTUsBK672JWjwmJFfVRflfYJvVTpebA7kPGiEgpnBoioM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(39850400004)(46966006)(36840700001)(47076005)(336012)(5660300002)(478600001)(6486002)(26005)(6862004)(8936002)(36860700001)(2616005)(6512007)(41300700001)(2906002)(86362001)(6506007)(82310400005)(107886003)(70586007)(186003)(316002)(356005)(54906003)(8676002)(70206006)(4326008)(82740400003)(36756003)(40480700001)(81166007)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 08:54:17.3082 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d13c9609-a3aa-4d9f-fb7a-08da5d9ac72a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4590 Pj4+Pj4+IA0KPj4+Pj4+IEFzIHNhaWQgSSB3b3VsZCB2b3RlIGZvciBleHRlcm5hbCBsaW5rYWdl IGhlcmUgYnV0IHdvdWxkIGJlIG5pY2UgdG8gaGF2ZSBvdGhlcg0KPj4+Pj4+IGRldmVsb3BlcnMg dmlldyBvbiB0aGlzLg0KPj4+Pj4+IA0KPj4+Pj4gSW4gYWRkaXRpb24gdG8gdGhpcywgaWYgd2Ug ZG9u4oCZdCB3YW50IHRvIHByb3ZpZGUgYSBqdXN0aWZpY2F0aW9uIGZvciB0aG9zZSwgc2luY2Ug dGhleSBzZWVtcyB0byBtZQ0KPj4+Pj4gY29kZSByZWxhdGVkIHRvIGRlYnVnZ2luZyB0aGV5IGNh biBiZSByZW1vdmVkIGZyb20g4oCccHJvZHVjdGlvbuKAnSBjb2RlIGluIHNvbWUgd2F5Lg0KPj4+ PiANCj4+Pj4gUnVsZSA4LjcgaXMgYWR2aXNvcnksIHNvIEkgdGhpbmsgdGhhdCBmb3JtYWwganVz dGlmaWNhdGlvbiBvZiBkZXZpYXRpb25zIGlzIG5vdCBuZWNlc3NhcnkuDQo+Pj4gDQo+Pj4gWWVz IHRoYXQgaXMgdHJ1ZSwgaW4gdGhhdCBjYXNlIHdlIHdvdWxkIG9ubHkgbmVlZCB0byBkb2N1bWVu dCBpdCB3aXRob3V0IGEgZm9ybWFsIGp1c3RpZmljYXRpb24sIGhvd2V2ZXINCj4+PiBpZiB0aGUg Y29kZWJhc2UgZG9lc27igJl0IGluY2x1ZGUgdGhlbSAoYmVjYXVzZSBub3QgaW4gcHJvZHVjdGlv biBjb2RlKSBJIGd1ZXNzIHRoZSBwcm9ibGVtIGRvZXNu4oCZdCBleGlzdC4NCj4+IEhhdmluZyB0 aGUgcHJvZHVjdGlvbiBjb2RlIHVzaW5nIHN0YXRpYyBhbmQgdGhlIG5vbiBwcm9kdWN0aW9uIHVz aW5nIGV4dGVybmFsIGxpbmthZ2Ugd291bGQgYmUga2luZCBvZiB3ZWlyZCBoZXJlLg0KPj4gSSB0 aGluayBoYXZpbmcgdGhlbSBhbHdheXMgd2l0aCBleHRlcm5hbCBsaW5rYWdlIHdpdGggYSBqdXN0 aWZpY2F0aW9uIGlzIHRoZSBjbGVhbmVzdCB3YXkuDQo+IA0KPiArMSB0aGlzIGlzIHdoYXQgSSB3 YXMgZ29pbmcgdG8gYW5zd2VyIDopLg0KPiANCg0KWWVzIHByb2JhYmx5IEkgZGlkbuKAmXQgZXhw bGFpbmVkIHZlcnkgd2VsbCwgSeKAmW0gaW4gZmF2b3VyIGZvciBleHRlcm5hbCBsaW5rYWdlLCBo ZW5jZSB3ZSBhcmUgZ29pbmcgdG8gaGF2ZSBhbiBhZHZpc29yeSB0bw0KZG9jdW1lbnQuDQoNCkkg d2FzIGp1c3QgdGhpbmtpbmcgaWYgd2UgbmVlZCB0byBkb2N1bWVudCB0aGF0ICppZiogdGhlIGNv ZGViYXNlIGRvZXNu4oCZdCBpbmNsdWRlIHRoZW0sIHdoaWNoIGlzIGEgY29tbWVudCBub3QgcmVs YXRlZA0KdG8gdGhpcyBwYXRjaCBzbyBhcG9sb2dpZXMgZm9yIHRoZSBub2lzZSBvbiB0aGF0LiAN Cg0KPiBDaGVlcnMsDQo+IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 04 08:55:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 08:55:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.359996.589326 (Exim 4.92) (envelope-from ) id 1o8Hrd-0002O2-EV; Mon, 04 Jul 2022 08:55:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 359996.589326; Mon, 04 Jul 2022 08:55:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Hrd-0002No-Al; Mon, 04 Jul 2022 08:55:29 +0000 Received: by outflank-mailman (input) for mailman id 359996; Mon, 04 Jul 2022 08:55:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Hrc-0002NF-Dh; Mon, 04 Jul 2022 08:55:28 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8HrY-0003Qe-Qo; Mon, 04 Jul 2022 08:55:24 +0000 Received: from [54.239.6.187] (helo=[192.168.26.128]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8HrY-0005ib-L4; Mon, 04 Jul 2022 08:55:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=zCd95P6ISsvOgWH8h20ho5lgpI/RNUaXzZAOU1iexfI=; b=erk+odNh4WRN1H+VNwHz2/iIMu ffrmUuXU41E3yPqH+VRZiHJ5qVHDjz3dPEQ6bgLeTSeRS6d7RLRIOT5YWeRPj8SJ30VgNKWkkTu7O HA3FFxTHyf3561ibLl89LxlFT/KdPLWrA9Tu3ujrb+Y+hfsYiz3mpi21pkDKVy7yZW9g=; Message-ID: Date: Mon, 4 Jul 2022 09:55:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH To: Juergen Gross , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220621072314.16382-1-jgross@suse.com> <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> From: Julien Grall In-Reply-To: <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Juergen, On 04/07/2022 09:38, Juergen Gross wrote: > On 21.06.22 09:23, Juergen Gross wrote: >> Do some memory map related changes/fixes for PVH mode: >> >> - Prefer the memory map delivered via start-info over the one obtained >>    from the hypervisor. This is a prerequisite for Xenstore-stubdom >>    live-update with rising the memory limit. >> >> - Fix a bug related to ballooning in PVH mode: PVH Xenstore-stubdom >>    can't read its target memory size from Xenstore, as this introduces >>    a chicken-and-egg problem. The memory size read from the hypervisor >>    OTOH includes additional "special" pages marked as reserved in the >>    memory map. Those pages need to be subtracted from the read size. >> >> - Fix a bug in ballooning code in PVH mode when using memory beyond >>    a RAM hole in the memory map >> >> Changes in V3: >> - minor comment for patch 3 addressed >> >> Changes in V2: >> - added patch 4 >> - addressed comment regarding patch 3 >> >> Juergen Gross (4): >>    mini-os: take newest version of arch-x86/hvm/start_info.h >>    mini-os: prefer memory map via start_info for PVH >>    mini-os: fix number of pages for PVH >>    mini-os: fix bug in ballooning on PVH >> >>   arch/x86/mm.c                         | 23 ++++---- >>   balloon.c                             | 18 ++---- >>   e820.c                                | 83 ++++++++++++++++++++++++--- >>   include/e820.h                        |  6 ++ >>   include/x86/arch_mm.h                 |  2 + >>   include/xen/arch-x86/hvm/start_info.h | 63 +++++++++++++++++++- >>   6 files changed, 163 insertions(+), 32 deletions(-) >> > > Could someone please commit this series? Done. > Samuel gave his R-b nearly 2 weeks > ago. xen-devel is quite high volume and I don't read all the e-mails. If you need someone to commit then please CC committers@ and this will land in my inbox. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:12:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:12:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360027.589374 (Exim 4.92) (envelope-from ) id 1o8I8G-0005VB-Db; Mon, 04 Jul 2022 09:12:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360027.589374; Mon, 04 Jul 2022 09:12:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8I8G-0005V4-A1; Mon, 04 Jul 2022 09:12:40 +0000 Received: by outflank-mailman (input) for mailman id 360027; Mon, 04 Jul 2022 09:12:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8I8E-0005Ud-B0 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:12:38 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7263228a-fb79-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:12:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5E8E22115; Mon, 4 Jul 2022 09:12:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 942B213451; Mon, 4 Jul 2022 09:12:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WYO9IgSvwmLwUwAAMHmgww (envelope-from ); Mon, 04 Jul 2022 09:12:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7263228a-fb79-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656925956; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LXOT3yR+5Wp7bs9dYLPLh10uymGAXlQbTvddjWlsmJU=; b=Hmqdwnu6FYfmKuDpURSCgce8u/92LmC1athQx8S7s/eHopVD/0GR/u1WMHhv6f2TvubO9J POHZ93xLwYCdEaGjO91v38XfTylh3SL9tDkHu87wBOwxq0xkOF20mzzCb9eDlpcz98YLgt pa1IGRM2f4YvU2bsg7TLcte/oBb+hkU= Message-ID: Date: Mon, 4 Jul 2022 11:12:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH Content-Language: en-US To: Julien Grall , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org References: <20220621072314.16382-1-jgross@suse.com> <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ICnBgoyAkQKi2xtoV4mGQ40s" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ICnBgoyAkQKi2xtoV4mGQ40s Content-Type: multipart/mixed; boundary="------------Ifqr1xpTe8i4teiHijuDhmlk"; protected-headers="v1" From: Juergen Gross To: Julien Grall , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" Cc: samuel.thibault@ens-lyon.org, wl@xen.org Message-ID: Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH References: <20220621072314.16382-1-jgross@suse.com> <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> In-Reply-To: --------------Ifqr1xpTe8i4teiHijuDhmlk Content-Type: multipart/mixed; boundary="------------r0KinztdotDSxGuhzfw8MqP4" --------------r0KinztdotDSxGuhzfw8MqP4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDcuMjIgMTA6NTUsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gSGkgSnVlcmdlbiwN Cj4gDQo+IE9uIDA0LzA3LzIwMjIgMDk6MzgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+PiBP biAyMS4wNi4yMiAwOToyMywgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+PiBEbyBzb21lIG1l bW9yeSBtYXAgcmVsYXRlZCBjaGFuZ2VzL2ZpeGVzIGZvciBQVkggbW9kZToNCj4+Pg0KPj4+ IC0gUHJlZmVyIHRoZSBtZW1vcnkgbWFwIGRlbGl2ZXJlZCB2aWEgc3RhcnQtaW5mbyBvdmVy IHRoZSBvbmUgb2J0YWluZWQNCj4+PiDCoMKgIGZyb20gdGhlIGh5cGVydmlzb3IuIFRoaXMg aXMgYSBwcmVyZXF1aXNpdGUgZm9yIFhlbnN0b3JlLXN0dWJkb20NCj4+PiDCoMKgIGxpdmUt dXBkYXRlIHdpdGggcmlzaW5nIHRoZSBtZW1vcnkgbGltaXQuDQo+Pj4NCj4+PiAtIEZpeCBh IGJ1ZyByZWxhdGVkIHRvIGJhbGxvb25pbmcgaW4gUFZIIG1vZGU6IFBWSCBYZW5zdG9yZS1z dHViZG9tDQo+Pj4gwqDCoCBjYW4ndCByZWFkIGl0cyB0YXJnZXQgbWVtb3J5IHNpemUgZnJv bSBYZW5zdG9yZSwgYXMgdGhpcyBpbnRyb2R1Y2VzDQo+Pj4gwqDCoCBhIGNoaWNrZW4tYW5k LWVnZyBwcm9ibGVtLiBUaGUgbWVtb3J5IHNpemUgcmVhZCBmcm9tIHRoZSBoeXBlcnZpc29y DQo+Pj4gwqDCoCBPVE9IIGluY2x1ZGVzIGFkZGl0aW9uYWwgInNwZWNpYWwiIHBhZ2VzIG1h cmtlZCBhcyByZXNlcnZlZCBpbiB0aGUNCj4+PiDCoMKgIG1lbW9yeSBtYXAuIFRob3NlIHBh Z2VzIG5lZWQgdG8gYmUgc3VidHJhY3RlZCBmcm9tIHRoZSByZWFkIHNpemUuDQo+Pj4NCj4+ PiAtIEZpeCBhIGJ1ZyBpbiBiYWxsb29uaW5nIGNvZGUgaW4gUFZIIG1vZGUgd2hlbiB1c2lu ZyBtZW1vcnkgYmV5b25kDQo+Pj4gwqDCoCBhIFJBTSBob2xlIGluIHRoZSBtZW1vcnkgbWFw DQo+Pj4NCj4+PiBDaGFuZ2VzIGluIFYzOg0KPj4+IC0gbWlub3IgY29tbWVudCBmb3IgcGF0 Y2ggMyBhZGRyZXNzZWQNCj4+Pg0KPj4+IENoYW5nZXMgaW4gVjI6DQo+Pj4gLSBhZGRlZCBw YXRjaCA0DQo+Pj4gLSBhZGRyZXNzZWQgY29tbWVudCByZWdhcmRpbmcgcGF0Y2ggMw0KPj4+ DQo+Pj4gSnVlcmdlbiBHcm9zcyAoNCk6DQo+Pj4gwqDCoCBtaW5pLW9zOiB0YWtlIG5ld2Vz dCB2ZXJzaW9uIG9mIGFyY2gteDg2L2h2bS9zdGFydF9pbmZvLmgNCj4+PiDCoMKgIG1pbmkt b3M6IHByZWZlciBtZW1vcnkgbWFwIHZpYSBzdGFydF9pbmZvIGZvciBQVkgNCj4+PiDCoMKg IG1pbmktb3M6IGZpeCBudW1iZXIgb2YgcGFnZXMgZm9yIFBWSA0KPj4+IMKgwqAgbWluaS1v czogZml4IGJ1ZyBpbiBiYWxsb29uaW5nIG9uIFBWSA0KPj4+DQo+Pj4gwqAgYXJjaC94ODYv bW0uY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB8 IDIzICsrKystLS0tDQo+Pj4gwqAgYmFsbG9vbi5jwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgfCAxOCArKy0tLS0NCj4+PiDCoCBl ODIwLmPCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB8IDgzICsrKysrKysrKysrKysrKysrKysrKysrKy0tLQ0KPj4+IMKg IGluY2x1ZGUvZTgyMC5owqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB8wqAgNiArKw0KPj4+IMKgIGluY2x1ZGUveDg2L2FyY2hfbW0uaMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHzCoCAyICsNCj4+PiDCoCBpbmNsdWRlL3hlbi9h cmNoLXg4Ni9odm0vc3RhcnRfaW5mby5oIHwgNjMgKysrKysrKysrKysrKysrKysrKy0NCj4+ PiDCoCA2IGZpbGVzIGNoYW5nZWQsIDE2MyBpbnNlcnRpb25zKCspLCAzMiBkZWxldGlvbnMo LSkNCj4+Pg0KPj4NCj4+IENvdWxkIHNvbWVvbmUgcGxlYXNlIGNvbW1pdCB0aGlzIHNlcmll cz8gDQo+IA0KPiBEb25lLg0KPiANCj4+IFNhbXVlbCBnYXZlIGhpcyBSLWIgbmVhcmx5IDIg d2Vla3MNCj4+IGFnby4NCj4gDQo+IHhlbi1kZXZlbCBpcyBxdWl0ZSBoaWdoIHZvbHVtZSBh bmQgSSBkb24ndCByZWFkIGFsbCB0aGUgZS1tYWlscy4gSWYgeW91IG5lZWQgDQo+IHNvbWVv bmUgdG8gY29tbWl0IHRoZW4gcGxlYXNlIENDIGNvbW1pdHRlcnNAIGFuZCB0aGlzIHdpbGwg bGFuZCBpbiBteSBpbmJveC4NCg0KVGhpcyBpcyB0aGUgcmVhc29uIHdoeSBXZWkgd2FudGVk IHRvIGJlIENDLWVkIGZvciBNaW5pLU9TIHBhdGNoZXMgaW4gdGhlDQpwYXN0LiBIZSBkb2Vz bid0IHNlZW0gdG8gYmUgaW50ZXJlc3RlZCBhbnkgbW9yZSwgdW5mb3J0dW5hdGVseS4uLg0K DQoNCkp1ZXJnZW4NCg0K --------------r0KinztdotDSxGuhzfw8MqP4 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------r0KinztdotDSxGuhzfw8MqP4-- --------------Ifqr1xpTe8i4teiHijuDhmlk-- --------------ICnBgoyAkQKi2xtoV4mGQ40s Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLCrwQFAwAAAAAACgkQsN6d1ii/Ey9s aQf+OcidFRagq8IT5ad0Zr9HaoKTtXxFDrnj9hgsUxXX1Q1gpRg1l/15oCwp3/8OgZazO/Hl2RP4 8I23yZs3Ft16v7Br19O5mOMTzyQYLwfSiAAAdpaRCaJw08sp/4/fpuYrSujGh+aLH1p1gmD37TKW km7E8IPycYEdKk6jHnGCjoa/+0l4YBcPkw0oZiG1pGRwYZi3eQPp41+VT8f3+5XHZCgjqkvGrbX2 EzGvIekjBdWZ9cQz+hV7V96I/IogZoaeSRUk8zkBssPNMZLkJ8ugnSvWRErb56qskzzgIcvWZCcs AyNbuiw75xZxgc8RTrZymyXP6M+c0uVtQipBYjsu3A== =lf0w -----END PGP SIGNATURE----- --------------ICnBgoyAkQKi2xtoV4mGQ40s-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360037.589392 (Exim 4.92) (envelope-from ) id 1o8IEI-0006JS-4J; Mon, 04 Jul 2022 09:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360037.589392; Mon, 04 Jul 2022 09:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IEI-0006JL-1Z; Mon, 04 Jul 2022 09:18:54 +0000 Received: by outflank-mailman (input) for mailman id 360037; Mon, 04 Jul 2022 09:18:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IEG-0006JF-N4 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:18:52 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 51a5974c-fb7a-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:18:51 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id r18so10869090edb.9 for ; Mon, 04 Jul 2022 02:18:51 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id k14-20020aa7c04e000000b00431962fe5d4sm20568737edo.77.2022.07.04.02.18.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 02:18:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51a5974c-fb7a-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=XvzplkcfBHntAkieXQE7nElZFawH9G9iX+6lNWNqK9g=; b=BAJ3QaQedBKus2e1VJ0SMC3a1daLIbx5hKDdWEFBiuK2h83LDoN3n6dwTVfYv1H6ke hRCsjUQSacUP4utxGuOasYgkV86panhXpoBx9KFf86cf7SSvHim2O58XHoRj48DRwBWn fP8FeiL5TlSSkAHciww3+/fSpnlB3ORJyFHsNuHeKnUMv7p0DG6BIJPVpTfk37LwVfZu k7PREi+1lSfZZhLt/v5PxqmeQZg08v6PuSqrDTpMHuZBLmrx3+AN4igeLGbK/QIr/ZQY WKy8Udy8xuDXAK+GzQ19+LFs3RH0fNzXYy8nY1L04YrecusxXNtUNbTcvbAYqzIdoOT1 le6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=XvzplkcfBHntAkieXQE7nElZFawH9G9iX+6lNWNqK9g=; b=Qg2mXDmHbWtLzDTNNvLPdXP1oiX6EK0N9DmbTFGlnuY1RsmB3t9yUwI8peGSKPNDoC eFTAsrJydC4VoBr9++W4h4IpbXaQGvK6cXNId24S/e4LUB7RugswdvIdFFDOnM4NGL9r Yhi4fJg5rFOf6B8na8fySwve1PQejNWM88TtJAI7v2dY8vfxUh3tifelvg11Kvj/gR5s dO66sUAca0R8I1/VpORia2fM77iVxN+Z03SFzqPLsgwSk60Aqpu3hAoxub+xPtyGtJHP Z/q8OCXO06uB7Vvv43Hg6EhFZQWRrIremlHfQyy+RUp0NxIgeXlQYcP8y0Mw0VjWEX81 G44g== X-Gm-Message-State: AJIora8FSgkcvDMWLbZoGxi4tCgko60KQ8pXWlZGhP6ZLdFrfdfIp71a WqeP9acldi7npVKVjPpqDgA= X-Google-Smtp-Source: AGRyM1uUxFBIj19KLIMvVlufXMuwUk7QbK8/J8AAMhRzajRiT/RWyOaLiIfRaLH/Yqw+P82qm+BgWw== X-Received: by 2002:a05:6402:1459:b0:437:9282:2076 with SMTP id d25-20020a056402145900b0043792822076mr36844486edx.6.1656926331263; Mon, 04 Jul 2022 02:18:51 -0700 (PDT) Message-ID: <6933ed4d-3e30-c11c-845e-8aaffc618cc8@gmail.com> Date: Mon, 4 Jul 2022 12:18:49 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] xen/arm: traps: fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Luca Fancellu , Julien Grall Cc: Bertrand Marquis , Xen-devel , Stefano Stabellini , Volodymyr Babchuk References: <20220704072232.117517-1-burzalodowa@gmail.com> <8970b2a7-d754-7db3-7f43-f2d30c626dc4@xen.org> <7C0683EE-4D8C-490E-997F-D54514312022@arm.com> From: Xenia Ragiadakou In-Reply-To: <7C0683EE-4D8C-490E-997F-D54514312022@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/4/22 11:54, Luca Fancellu wrote: >>>>>>> >>>>>>> As said I would vote for external linkage here but would be nice to have other >>>>>>> developers view on this. >>>>>>> >>>>>> In addition to this, if we don’t want to provide a justification for those, since they seems to me >>>>>> code related to debugging they can be removed from “production” code in some way. >>>>> >>>>> Rule 8.7 is advisory, so I think that formal justification of deviations is not necessary. >>>> >>>> Yes that is true, in that case we would only need to document it without a formal justification, however >>>> if the codebase doesn’t include them (because not in production code) I guess the problem doesn’t exist. >>> Having the production code using static and the non production using external linkage would be kind of weird here. >>> I think having them always with external linkage with a justification is the cleanest way. >> >> +1 this is what I was going to answer :). >> > > Yes probably I didn’t explained very well, I’m in favour for external linkage, hence we are going to have an advisory to > document. > > I was just thinking if we need to document that *if* the codebase doesn’t include them, which is a comment not related > to this patch so apologies for the noise on that. > >> Cheers, >> >> -- >> Julien Grall > I would like to mention that show_execution_state() is also available for dumping the state but probably you need them for more fine grained debugging. I will wait until tomorrow in case there is further input on this and I will send another patch, if necessary. -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:20:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:20:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360043.589407 (Exim 4.92) (envelope-from ) id 1o8IFZ-0007ev-GR; Mon, 04 Jul 2022 09:20:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360043.589407; Mon, 04 Jul 2022 09:20:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IFZ-0007eo-Dc; Mon, 04 Jul 2022 09:20:13 +0000 Received: by outflank-mailman (input) for mailman id 360043; Mon, 04 Jul 2022 09:20:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IFY-0007cn-5S for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:20:12 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8074b097-fb7a-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:20:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2584.eurprd04.prod.outlook.com (2603:10a6:4:38::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 09:20:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 09:20:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8074b097-fb7a-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VS/lHqEn3OKzIm/Vxlu2HDuBUo65e10ZokgIB0xVmf5Gf9tnq6xtBPjdUwIupt+mX31kdzh2bfEJQsnBgjSUdKT1sRVSH/E/oCBm0A8V6dGCvdR6K1gizGs5Tx8GHJDuzHulZtRzCRFHxRpoqRocW1L7Wxeczxe3EcQ1pm2KcoWGaWIg8Xc4xekVD6qjY+0Uss5A0N7MfhqZab/FjNBtxs+sh+0aHDDS2h4kX0BKK1OufeeXcP+3ab1j0CKPUTbqYjLusd8BMfqSffBm0ADHAg6A+IqgNtSggq1tEbc0kzLS02fEwM8NLeJQ1mesYW9ugqPBEzT9rdQ8Dayla86MsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A9QOVyzSK01MEMswLZkjhy8t1AvWi5qFWrfhNL0sxew=; b=k8Lf6Q3eN69icf2RB+Q7CF62b9KnyV35kH8FsqSEHQsvuWa6JXovOFg2uoH7/9iMoixun6CTQ/nTPs6g9muHwWKvOiRy/2IOfp+vwUleXAksPwNljS+Jgd0ndFHuSQqrdyacUKj7XYuuSJEPWTIKQLS044xr0JwaFxJHVtp7FzxUFijAMX0DWXIWM3IdOwznUy9+zdedERfin6VIHnBtZ82x4/pYw2D2eLJksVkPNwS2/f/x8tXwFWeYbHgtHaIJ1scPDxRLXO+wZqDmpYWFaudRvZkhFvr0Ex7C7c0liE6JkCEkC+0hkkZtz+RTz6iC7aWXzXHnphAabChB8yPV6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A9QOVyzSK01MEMswLZkjhy8t1AvWi5qFWrfhNL0sxew=; b=g4tzIbTt/5fZsiovrGPRwQOkx/fXWRLQm+HuB7zz1tVTG5i0apama73koR3ZS405JFA4tjtlx8ocHGEseIgNNw2GYj4bAMLCa9rXhTryMF76cOnA37f7Wux8P+Bc1oqWOwtO7K09o0hh2wnc3gxyA9J079wKOl3cjYArLviI7YaKFvobt3V+xrj4EWKADq8LVgdM9YpAamfHVLUd/YYK62beuQpEf5/9rA/vJGv3Oj/Aj2JP51N7frvWKhClCGJ5YYrY6+FJqG7MQxoeJuWFkzX4Rez8HBlaCyUPZCU7VbGZ8KsgjlAuDPdr2V9tqGHHMuMYTogGpNLMk11/L2VIBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <72ddf6bb-be0a-ac54-075f-6f9196cd9e47@suse.com> Date: Mon, 4 Jul 2022 11:20:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 0/4] mini-os: some memory map updates for PVH Content-Language: en-US To: Juergen Gross , wl@xen.org Cc: samuel.thibault@ens-lyon.org, Julien Grall , minios-devel@lists.xenproject.org, xen-devel@lists.xenproject.org, "committers@xenproject.org" References: <20220621072314.16382-1-jgross@suse.com> <3349c933-ed0d-3177-b494-ef4a6654d12d@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR01CA0007.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2fa9573-77c2-4058-2158-08da5d9e633c X-MS-TrafficTypeDiagnostic: DB6PR0401MB2584:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: faG7/4m6Cbe1uRZlybqlMLZ5vZOKIB5RAacGC8yBgx8fDUitzqS+scjZvS/RkyLF4F4MRVK8B4zgOZVISYvtUoMGzAlCAq77h+PwIruYlCC/b7hvnX5SiTUqUNN6Hpr60GKK6rgfWkC4efaDtj7/tLikJjtMktdG6FBiPmNldBz7WI9ysFv5XT6UEcMTmRiQ1keWR//dDFX4RnVlYwwzSrbBem02OYW+2Rmd9i2cfPRNq2VrUM0fw52OIepDtSld1F4sNycYFPWLUXka4OmKXXJ1l6Dr4e5YlNtyRktVYwyS4jXfjgQDne+bZmuC5M0yZ3wPz1rTX3QSejj4+tUy7Rs2iQbSSgtRoCS6xtOl3Mz7O/X9z0Tip7RNyVbyPHyJnzeDKMty4BV12XNbvvNxHdupyuI6RB4L15ySHFYaOjBYf92DfS8Uw9hh7UPyBDc+GHV1JEcpVVY/5la3oV+QfnTOelvz37oOMvv5xHdXKG49mxbdtUdioI+ANTzdqbrDgKoJZEGyTfNE27RwxvMhzJM+hNfkqK/kYpvlCNgfgcnPmpYUonmzpfhwRuWXxTqalUWMe++N788wOMDHESlV/wnv8UheBTnZl+JDS3GK3aBuY452UriT99qfv5OrXpm1RB7x3GFEdosx6T4mFM7PgLvgNincGVXbNj9S+xfvpQxym/JiisdBPxr0qS7jh9EtUqHA7Pqu9zMJeB4TqRJ66/wd2tkPoeesKh9li62ULk5wj2yvfAccNYRT/serIC1e5DeTKIJtu5I8IBFNvEejAltfv60ibtWDprzZLeiiylOXFPcsNT8u7yCZtpef0j+I7IwriYapzBeD5eu/i99z6tdgHnZ1kPsa6be4253dvqM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(346002)(376002)(39850400004)(2616005)(54906003)(41300700001)(186003)(316002)(86362001)(36756003)(31686004)(4326008)(8676002)(38100700002)(66946007)(26005)(66556008)(31696002)(6512007)(66476007)(6506007)(15650500001)(53546011)(478600001)(83380400001)(6486002)(2906002)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eHU5S2w2eU5HM0lrbGgranhxTlhubytoMHVCU2wxZ0ZsbHAyZmNkU0pXSnhL?= =?utf-8?B?SXpwUVRaWHhUSTdpNFJweENnM1lBSi9TUlFwcGthTHNEVWZQY2gydGxwUVd5?= =?utf-8?B?eGZKV2RuWUN6cjQwM044OEd0cThvMFBQVFZzVmIxMUh1cmlHTHQ3c004RkF1?= =?utf-8?B?ZEY1akcxS2k2ZEc3eXA3dVo3MG0xVDNhNzdjVkxCTklNazdQcWhkY0NwL1pJ?= =?utf-8?B?OWNUU2dINUZ0VWFFOG1WLzFhd1NXek56OHhUK3kzRlVSVk84YVZ0ZzcwWVl1?= =?utf-8?B?S043c1pDOGN6OUkrV3JOVHFhNm0vV1JoQldocUp3ZmY3RE5JNytBVHVHRjJj?= =?utf-8?B?OGRBODQybmlod1F6THRJeVJTN2dSYWRPbjVtb0daUEtQRHJuWW05RzlEblNw?= =?utf-8?B?M0dDd3ltNjk0UUNqSEsrMktZREJLZVd2enRYdC9kcFpsMlNTUThPQ1BMTmt2?= =?utf-8?B?UEYvWlNmNmp5OGJIdnczeVVwUHNNb0hSY3Bscm42Nit6NVM2RkV3bGFtSlRD?= =?utf-8?B?OGZNK3RGeGF1d2FDZkZrWDlhbS9QQXBQdmZpQk04VVJwVG5PeEJFQXQzQ2hF?= =?utf-8?B?bU5yQkZwR25WM3ZqQy9aMGtRWVFvazRKcjJnaHQzTytydzZYdEdlU3IxWXhx?= =?utf-8?B?REU5cTZpQ2dERUlsNWlBVFhrRDhWc2hrS1p5WUxhS3g5cDFOMHllTXljSnNZ?= =?utf-8?B?cTZMcW1RVkJ4TTF1c04yUGFRMmhSWkVKRVJzelNwTnUrekpDTDlVTmtEb3Jh?= =?utf-8?B?NCtQQUVlY05BV08zWG9KZUhOOG5wcUZnM0s2ZDA2Z21WWmZrVk41a0s3YUNC?= =?utf-8?B?VFNyN3NKQy9VRDJuT3ZPNWFKdUUyREJGMWpiT2FrMWVJeDJUS0VNMEtoZWl4?= =?utf-8?B?UkhXV1pyUitaQmlyQmNtNDhaTW51RExxbGt6WHBVWEc3WW1zR3k4eHlBN2Vn?= =?utf-8?B?MFliWFRxUWdRSG5LVVYxY2lVZVpSSjBvZVYrYllJUkI0UXc5cU1XQWxOclgw?= =?utf-8?B?WVN2VmwxWG80NlBaTm9aVWVXWE9pZ2lic0lCTXRwV3ZsejVQNU1ZNmdPWEVL?= =?utf-8?B?Y2JGeEErWHY0MnBGTFMyWGcwcHhlREtLMStkbENFK0R0blRvYXVieXRqVGlF?= =?utf-8?B?a1AyWnRLT01qVVlyamdodlpWS1FlRUFjRVByQytubS9DOFVDd0puc2pqRUpS?= =?utf-8?B?aDBxU3VnczVjWUlkcWJLekN4VDFQMVFJcjFaOU9oZmtYcG1JT2xmQXduTmND?= =?utf-8?B?SlZObit1VVpGSlM3L0lDa1pNUGh2N0NDZys5eTNJZkNIcmZQVzU4dUlSQU14?= =?utf-8?B?ckQ0NnlQcjA5Y0dTZC9qSE96RnlVTzZlVmNoNGV3RzZ0bTVncUZLcDkwdi9J?= =?utf-8?B?eno3OWsyWm9CcGI4TFl3UTZWcVVzOGJCYmEzcXh2VmY4WEU2L0IyV0k0R3Z1?= =?utf-8?B?ZjA3S3k4czQ0SDBRLzkzWWtvV1h4U0t5MEFkYndvOElJd2pFMXBqeXFLZFpW?= =?utf-8?B?ZzhDQUllUVlJVUwvYm9oRGp5TDFqSXFDSFhTM1RwbG1FUFFMUkRJTmlTcEJX?= =?utf-8?B?VzlhbjFuRUNtL2VNMFZyWElIRXBPZTVNU3RlM1YybmhVTmRSVlowTUtxdUVp?= =?utf-8?B?UlZmMUdFQldORDhsdTFsU3dHaTFuNTRsaFQ4QmJvVk5rQXJ2aDFJWFJqeWFJ?= =?utf-8?B?N0t3T0xDS0V4NnFTalB1SGo2dnVVd1dKYnlSZkVwRGJDTDgvT2JvSS85VnRM?= =?utf-8?B?c29CQ3dVSnY3RXkvZWJpZ0xhRjRkRGRxNWVyY3V1VjBKRHZYSENtQ1NDT2Y1?= =?utf-8?B?OGZUNTRDd0J4ZE84S29mVnc0Q0gzZUFvamtMckZ5UFUzaUxaaTc2SHhuOXpD?= =?utf-8?B?TzFWUmdCbSt5ZTVIRFRJUENHVHRnWHJlSzhhUnQrRzUwV25veS9QUUhXd3Iw?= =?utf-8?B?Mk4wS0M2NmF4Ny9JV3NyK0dadnB3VVBKN2tLUVlEcGFRNG5vZzhwUVBUUjIv?= =?utf-8?B?RmV6T2ZoRmdpdmcweG5lVmZURDlucUhjdnhJL2JhbUNPN1I5M2lIWEFnTjFU?= =?utf-8?B?cEF0cnNoWldiWExwOSt0cWh1YTBTdnNaU3pyZVB5cWZObHZieDJaODhiSzln?= =?utf-8?Q?gunV7fblTcPLr/NflhByWl1+a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2fa9573-77c2-4058-2158-08da5d9e633c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 09:20:07.9009 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4+3e0lfXZH2wKMd8SQhfKsyfWhTfu1jG0H7aP3GS0NBmU0LiIuBmWRfkq4y1SuyKDkuCQ0npOM+Pf8ZFD3QqBw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2584 On 04.07.2022 11:12, Juergen Gross wrote: > On 04.07.22 10:55, Julien Grall wrote: >> Hi Juergen, >> >> On 04/07/2022 09:38, Juergen Gross wrote: >>> On 21.06.22 09:23, Juergen Gross wrote: >>>> Do some memory map related changes/fixes for PVH mode: >>>> >>>> - Prefer the memory map delivered via start-info over the one obtained >>>>    from the hypervisor. This is a prerequisite for Xenstore-stubdom >>>>    live-update with rising the memory limit. >>>> >>>> - Fix a bug related to ballooning in PVH mode: PVH Xenstore-stubdom >>>>    can't read its target memory size from Xenstore, as this introduces >>>>    a chicken-and-egg problem. The memory size read from the hypervisor >>>>    OTOH includes additional "special" pages marked as reserved in the >>>>    memory map. Those pages need to be subtracted from the read size. >>>> >>>> - Fix a bug in ballooning code in PVH mode when using memory beyond >>>>    a RAM hole in the memory map >>>> >>>> Changes in V3: >>>> - minor comment for patch 3 addressed >>>> >>>> Changes in V2: >>>> - added patch 4 >>>> - addressed comment regarding patch 3 >>>> >>>> Juergen Gross (4): >>>>    mini-os: take newest version of arch-x86/hvm/start_info.h >>>>    mini-os: prefer memory map via start_info for PVH >>>>    mini-os: fix number of pages for PVH >>>>    mini-os: fix bug in ballooning on PVH >>>> >>>>   arch/x86/mm.c                         | 23 ++++---- >>>>   balloon.c                             | 18 ++---- >>>>   e820.c                                | 83 ++++++++++++++++++++++++--- >>>>   include/e820.h                        |  6 ++ >>>>   include/x86/arch_mm.h                 |  2 + >>>>   include/xen/arch-x86/hvm/start_info.h | 63 +++++++++++++++++++- >>>>   6 files changed, 163 insertions(+), 32 deletions(-) >>>> >>> >>> Could someone please commit this series? >> >> Done. >> >>> Samuel gave his R-b nearly 2 weeks >>> ago. >> >> xen-devel is quite high volume and I don't read all the e-mails. If you need >> someone to commit then please CC committers@ and this will land in my inbox. > > This is the reason why Wei wanted to be CC-ed for Mini-OS patches in the > past. He doesn't seem to be interested any more, unfortunately... And really, with no other indication so far, I've been skipping mini-os patches on the assumption that Wei would be looking after them. Wei, if you can't do so anymore, could you please explicitly indicate so? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:27:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:27:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360054.589420 (Exim 4.92) (envelope-from ) id 1o8IMM-0008Sl-C7; Mon, 04 Jul 2022 09:27:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360054.589420; Mon, 04 Jul 2022 09:27:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IMM-0008Se-9B; Mon, 04 Jul 2022 09:27:14 +0000 Received: by outflank-mailman (input) for mailman id 360054; Mon, 04 Jul 2022 09:27:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IMK-0008SY-Il for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:27:12 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79cf3bfc-fb7b-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 11:27:10 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 318B05C00DA; Mon, 4 Jul 2022 05:27:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 04 Jul 2022 05:27:08 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 4 Jul 2022 05:27:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79cf3bfc-fb7b-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656926828; x= 1657013228; bh=8jziQ/tSPba6u+MoT33u1zyVPomidh2U8mKhlRas2Zc=; b=L bNBY18Q/SaO6FJXjwOFC5xgj7H407Mt6ccwAHvyMSpAgyPvvzkl87bd4KncNLp7V MCpJ/IAMNCPYO3vXJFC+NPqonDS6jzgfLi2AqO6Td6B9nx0YPAEag/85wyGd7Xqd XlYJR5KndLYKQGiaoZUFxD0yhiFVBCEHGVntlvWSCx0oRxUKvEmj1q/9KhbxxlnR GRGzlXu+x4gll7Nk7LVIycLLRjlm5csOmxzO8TwXLvoYMR5pkmkD/XyroJx2m9TG PxmSAHH9OiSa1JScAyGedWhH3zHPFfERk3c7JDdknea7BIueC+9IPGfDAycElnPE 7eDNDy1QM4P1YhsaBBEqA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1656926828; x=1657013228; bh=8jziQ/tSPba6u+MoT33u1zyVPomi dh2U8mKhlRas2Zc=; b=Zd4pOkm6LKPrn5gvlR/uJg/SutDxmRQkB/fQEIILh+Iz rviPeplCtPC6QR2nSshOJVJAVxBPG7NvhCA6QGJD490nRDEICfb4WUAr/nz3wdcP B/XLXYOVQPST72oRCroeHSjWzUeO2nMF1uJiLQzplZVlSf+nUmUlTFVGXCpTAXAo jNzQ+mT3y7nucEAnmZ3nV90xCLtfwoA6GS1Ajo19mZyA4msByswB9UiSYk+5rlaa HP84yX7pXhDxntbwYPJuf+++lN2d4MXxqZ3j8l4NJDL3xuuhgG0/Hdm3esKyuHuL /V2iNKvksPE1xAAqw6h3yaq9UGFea0P57XmDd93Ubg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudehledgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 4 Jul 2022 11:27:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <87c73737fe8ec6d9fe31c844b72b6c979b90c25d.1654612169.git-series.marmarek@invisiblethingslab.com> <9c7c11f5-be1e-f0ef-0659-48026675ec1a@suse.com> <8322303f-021a-b520-d2ad-cf8310573df5@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="TC37I/yvhfaH08r1" Content-Disposition: inline In-Reply-To: --TC37I/yvhfaH08r1 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 4 Jul 2022 11:27:03 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , Roger Pau =?utf-8?B?TW9ubsOp?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger On Mon, Jul 04, 2022 at 08:05:06AM +0200, Jan Beulich wrote: > On 03.07.2022 14:17, Marek Marczykowski-G=C3=B3recki wrote: > > On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: > >> On 22.06.2022 17:47, Marek Marczykowski-G=C3=B3recki wrote: > >>> On Wed, Jun 15, 2022 at 04:25:54PM +0200, Jan Beulich wrote: > >>>> On 07.06.2022 16:30, Marek Marczykowski-G=C3=B3recki wrote: > >>>>> + memset(xue, 0, sizeof(*xue)); > >>>>> + > >>>>> + xue->dbc_ctx =3D &ctx; > >>>>> + xue->dbc_erst =3D &erst; > >>>>> + xue->dbc_ering.trb =3D evt_trb; > >>>>> + xue->dbc_oring.trb =3D out_trb; > >>>>> + xue->dbc_iring.trb =3D in_trb; > >>>>> + xue->dbc_owork.buf =3D wrk_buf; > >>>>> + xue->dbc_str =3D str_buf; > >>>> > >>>> Especially the page-sized entities want allocating dynamically here,= as > >>>> they won't be needed without the command line option requesting the = use > >>>> of this driver. > >>> > >>> Are you okay with changing this only in patch 9, where I restructure = those > >>> buffers anyway? > >> > >> I'm afraid I'll need to make it to patch 9 to answer this question. If > >> suitable dealt with later, I don't see a fundamental problem, as long > >> as it's clear then that I will request that this patch be committed in > >> a batch with that later one, not in isolation. > >=20 > > This turns out to be rather problematic. xue_uart_init() is called > > really early (as it should, to get console as early as possible). It's > > before even boot allocator is functioning, so I can't use alloc_boot_pa= ges(). > > Are there any other options for memory allocations at this point? >=20 > No "neat" ones. Stealing directly from E820 could be an option, but > would of course be heavily x86-centric. >=20 > > We are talking about 58 pages. It isn't much, but isn't exactly nothing > > either. Maybe there is way to keep the memory allocated statically as it > > is now, but return it to the allocator is xue is _not_ enabled? >=20 > Well, yes, treating them like .init.data would seem to be the least bad > alternative then, at least for now. Down the road we may want to generali= ze > what's needed here, as there are other full-page or larger memory areas > which are used only under certain conditions. We may e.g. want to introdu= ce > an approach similar to Linux'es .brk section (recently renamed to .brk..b= ss > iirc). If a non-generalized approach ends up looking too ugly, I'd be okay > with keeping things as they're now, just with a respective justification > added to the patch description. Looking at it, I see another issue - Xen uses superpages, so I'd either need to: - reserve the whole superpage to be able to release it later (waste 6 pages if xue is used), or - shatter superpage when releasing unused xue buffers First one is probably less bad. But maybe, instead of doing all this, add xue to the menuconfig (make the prompt visible) with appropriate note about wasting 58 pages when built-in but not enabled. What do you think? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --TC37I/yvhfaH08r1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLCsmgACgkQ24/THMrX 1ywO9wf/XwqCQZHJnMrAxb/ZZXYr9wN7eCTgwKcoEUGXs0+kFRaSL28aNfVO+B2D uhcTxKprnB5phKA6KE8QP1QgCb6uQ0u5VHyH7AGHsm2Yvu14FYlc6luHOD8sc+l/ 5ax1sqerkiymsH8U5nuFsxMlV31voLczgYRkw+c9LdycHn3xC5t8y3mxfp9o4DDH mi+gVab2v6IUxCFIikggmUhxNLUuVrGdcXieyXF6Z1nxFS4ztM6h2Y75oAL4di89 cCY7wIqRKVWbWVitcKfYmD+FqsU9dhHUNz9C5633SZSc5etIOcoLo1VGujWE5Ji4 iuG680+cEEWTgLu/JNAGdNPpJQiCGw== =bnny -----END PGP SIGNATURE----- --TC37I/yvhfaH08r1-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:27:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:27:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360058.589432 (Exim 4.92) (envelope-from ) id 1o8IMp-0000X0-Kv; Mon, 04 Jul 2022 09:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360058.589432; Mon, 04 Jul 2022 09:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IMp-0000Wt-Gw; Mon, 04 Jul 2022 09:27:43 +0000 Received: by outflank-mailman (input) for mailman id 360058; Mon, 04 Jul 2022 09:27:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IMo-0000L3-1S for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:27:42 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70053.outbound.protection.outlook.com [40.107.7.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d399a8e-fb7b-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:27:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8768.eurprd04.prod.outlook.com (2603:10a6:102:20f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 09:27:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 09:27:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d399a8e-fb7b-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iNndCGeNFx5kF5PUiPnPw/z818UOQOc0yXeF0AyLBn49uaLylPLAUd96mra9jcsE/5P+7ciWVah/HYDfS6iq1jzla4TvbS7bHkldx34zIZ02AVRW5I2rSCZjIMP4IRTJJifZJFdePbiUGfexhxFLuX82+leohnUhXsvXbmkbhQac9fD0yTU68NrZGNWXt0AVZ0QUQUsbj5MBWe8Iwkp+p5m6VTeFr/vGT48L1tjzJ2FURgeD0qbLyFu8xyku6AsbPtWnYf9kdnkm7jHWhbD4vlTYd+sjslMFVJQp33mlHl9INbjtcNnS5zfagJyMVlN5ATL38aM2Q+n4qAxYuvzupA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uq+DUjNhHvZkSs3tU1NX+6HqejUfqZzVsyviXHcgIeo=; b=X+LQXenpeSgqc3Euhz91hJ7owRDHQZlj9XVDRA8qrAm+LLZxOZwOmmP6FlXbM/y5jKtJPP/rGnCG6F13zlYqApYWC2cZjOKf+OthYyl1qors+Zots4kDmzcXY4GB5abzf2f66kygYZdSghmuXNR01i2L8AnDUdOiLn7SAwnGLGj4e2tCnmhLJdyS7FA8LdfJk3QbpJAk5k6VcE4FSDREotJgZYCw11m7XsrgoqcPmLJN+5lpO7zW1abpGqvglO4DC1WJ1upwVFoBHbLl705gvWPHm4YGSUWlRCyMp+wkpZ5ZmOPYetmQAnpbixw0YX2nM/ACW2R+L86CrO5YHBHuBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uq+DUjNhHvZkSs3tU1NX+6HqejUfqZzVsyviXHcgIeo=; b=m/LMlTSytt/UlFvYXqWc/7qgPhLEAdLbqIgT95ftv5OIqRpZROcRdo3/m2rCHHu/9qTZP1AcSitqxcM6jJx9+z2ayIuHGtPZ9fUASdlyU8wRKvljQOlkbujr6b9J9dDWQxFBqYut2/VrrwN3Gy6moSzbkkLDKmG2CMFBuoIEml8yKRt9qpSVdV6y5yJ5HG+lks2dVURKc3ZAgEI9/mj2hmDKztvKFB98CUc9TxzgsnPLBHm4bXvByv9DxACqQCy7C8zK426VpV9UVEEAYewBXFl2onfCyg/m04/uvjxiUhwZi+2LLDHPfBjmK1ub6erUV6Uosgaj0WKiKQSiYKrDAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <325bbf52-3b56-4062-88b5-a04dc21404bc@suse.com> Date: Mon, 4 Jul 2022 11:27:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Content-Language: en-US To: Roger Pau Monne Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220701131648.34292-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0060.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ee17069-d25d-4443-57bc-08da5d9f701e X-MS-TrafficTypeDiagnostic: PAXPR04MB8768:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uu43rw2rM9gbtg2lNfkmH/nf+gX7nvptSE6LSB2z6n4WtQfnIQJDaoRu6aMFrBkZOD/RHkMddJIGCB8iiVFrInLPUdhyAXY+wd+bOVIfnh5c/DLwkXTCaCPxTXP/ZaKsP2uSpRF0r3X6xDePgi5KE2mjgTva/iCcQM6On+4jGxGGa8UVDjI89l3bNIFDoSNEyCvmYKC8HIItgiA9TmsgqkGjbYX7odaUpE7XbE/Hz7tIsRLm/H2hA4UFKpvqpFdbx8uB58+FOyenO+dNw8BrljHIz+fCeqoTbVOYQhank7tDCuEsTS3+XKcrcAuRYTtsJtDDV/vyvYz32g0/Pz7hef9vyv/D+yv45fzDub68yg5bGBuoZAzLKaKo57nnFddsrm3ai94BO+ZE3D6TPU30qqty3waIve7Bdkfoh89Ty2g24j9P/udyWDu8i2TBt5Ez2GqNMXNQOeyDo3kOOFwZlUFFd3/RTPVpbdRIPRmPDdDKbKpoAY+VneNCN1P2+l5vVk4i/jt3NmP2qTbMivbdu8GHV6ZDgAbRlyvB0ulcOagzjr1o4aGl2PrO194OAJ4+PMeBhnpFDbSkIktbVyrXtldSSpGslZtoLDbabTfCs1o0keMcFp616DtejzV8pUZrbnu+f3N9ZxTop0vswFt5EMOCJDVeuPbS5rUew4R54HsTB6F19IBvqDaQPnZ5YjWIhS79OqSEkTmdzfJb/JZvG35OqboZImSVDxNDxDpXCHE+v1mwK9gptJEd6WBb+dO03L78pYT/F/N/HMhEH7cKicofn9SiR8t/x+Bcl9qPP9ehvIEsgMSXgL9yws3aS6NYYcJUx43BzSORPP/5tboGEVM/DFb5c1z7+0AdSroLEtU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(396003)(136003)(366004)(316002)(8676002)(4326008)(66946007)(6916009)(66476007)(478600001)(6506007)(54906003)(66556008)(41300700001)(6486002)(8936002)(31686004)(2906002)(4744005)(5660300002)(38100700002)(36756003)(31696002)(86362001)(2616005)(186003)(53546011)(83380400001)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmR6U1Nnc1owU0lMbnVZQldoSGRDRDVSa0I2NFcwbWNNVGlnNmJ6aGVTbFBQ?= =?utf-8?B?OGMxR05GcDVmaHFkOXR6MzlqcDZjQ01OSkI4NzBLNTVHa1B3emJtM1IwdWxx?= =?utf-8?B?VU41T3RTMXpLWW5ZZXV2UzBqQU5VWXpVdjZtTGtJZVB2MDUzbmNiRzROQ1RX?= =?utf-8?B?NkhiY05VTHhJaFRUNmhLZ0FIdXNZN0F2QWphb09DV0g3cE1HVWFiYmRKYTJy?= =?utf-8?B?d1FGLzUvNzRheERtc0xOYXJ5czNHL2xtUHJVVXcxTW9XS3l3Mkt0SVZIcndi?= =?utf-8?B?TjVDK3hFS2ozS2hoYUkwUEFBd0k5ZjliTnhvR240ZFhxWDBDSVpZTHJ5NUdq?= =?utf-8?B?R2tHMDN3SmdkeHFtU2RQUTF3N05XcEFPZ3NPL3Q1WFJZVU4rbGpLYkpuc3Bz?= =?utf-8?B?amJNVVEyN1FYTmtSR2svaUZMRXBQOWFHR3VKYmZyRFhJWnlCODdzTDI0VXVt?= =?utf-8?B?ZXQ4dDFrS1RFbVBMY05VdXNicXZtSlpFb1FJNjVRSWp5NDdPZmoySzkxaW5m?= =?utf-8?B?cHd5RU5DNms0YUVGZjZHVFUxNkdiVUVHRzhkbGVDbm9BZFJHNm10bER1b1c4?= =?utf-8?B?YnJjbG45K1U0L2drY3RhYVBYTTd3RFhlYVFxN0tsWTFZYitJMDViWVpTNHR3?= =?utf-8?B?RHZlcThvakNRemliL1lTallaQnRIT2RJNkZpa1ZuVXBUa0gwUjVxaWU5NlhH?= =?utf-8?B?TGxsYnZBc2lTc0F2S01oeUIvWTBUemZNOGNVSXBZUWVWS3ZKeW5BRXI5eEFx?= =?utf-8?B?WnpGcjV1cTJnN1FiNUJCTWgyY2daVzV6RjVrR0tMd3lyR2VBc3d3OHFwSW4r?= =?utf-8?B?OWg1MnFmTXRuSk5sOXpmNnFqQ2FXb2EzVmhOcDdCWm9xYkx0UGM0YlBlbUhS?= =?utf-8?B?b1RjN09vWkhRUnFVWjJITnZkTW9oNkRHbWdiNVBOWitOL0tNWFZyU1p1Q0sv?= =?utf-8?B?bDQxenZaYnlabk5kbmtERFFmWktNYUpVbDJJc1hhYmhEb1dMYzQvalZ1OWJl?= =?utf-8?B?RGdMSEpGakk2Ykl2NHBrSEt4ZjJnSi9ndVczN25vLzRxZWJRc2VwQU5TbHhL?= =?utf-8?B?ZjZLdkpYRG1HNk8wSXNIajFJdVIvRU9HalJxZHFBOEVja3NWa2pmR0Z6WHZ6?= =?utf-8?B?SnI2dS9uODJ5VXA3Z0dDRCsvMmpzcXQ0K0xBeFk5ODE4RVdXM1BsL2ZLeDdZ?= =?utf-8?B?NDNLZjB0bjM5ZmdMcnZlMGNqUFc2djZVMDJSTTVHaWxVRFlYYkhQY3diWGRh?= =?utf-8?B?a2ZVamVxdnUzeWovTXNjTmpzWWg3ZHZlQU5hWFZ2VWhHR1Bpc3VGKzd0R1ow?= =?utf-8?B?Nm9naWNYQURCYXQwb2NTTGc0dGpIQkdwejVtNmZBNUVOUDBNZlZidkNHTmlC?= =?utf-8?B?MlVBWVFHWk1mRjFqdDhlRWNKMTQvNkZsdTVlcnZPckVzRFdmbE9XQ3UrYkM3?= =?utf-8?B?MGlWVitkcGpta2pKUGcraEJSU1R4cDJqTjRTZllySzB5clVJRk9BK0hzVGhU?= =?utf-8?B?czFuek1WU1ZzOG9pbFFzcUpRa3ZjNjNvZXhaK3dXSUFsVFJmR2hHbXMwMVRV?= =?utf-8?B?bzlqek44aHdtNzFjSjYyRjBJZHZUVDUyUTFtMlpFOXZJWHhvMFo2bHE0cUpY?= =?utf-8?B?VHlPWWpMWjFmeStoNHB4U3Eza0NjOEViWHlZbkV4L3Z0RFRSRFNKcTZZcXlk?= =?utf-8?B?NVVZd2IxbEQ2QTQweUt3U1Q1ajUxb2VWUi9jdUVvY3pCSStIeHRVMERoaHF5?= =?utf-8?B?a1NaNzkyaGRpcGtzeVJQbWcxNWhtV1RjS2MwdlVUaGdlb3JTNEJoL1diajlH?= =?utf-8?B?NjNYQ2hOZTZyU01xZ2pldHVxZGlvKzFsZ0VoMkpmMUZ0d0ZYRGdzRDltM29h?= =?utf-8?B?RWlLbFpYUmpET0Z6TEtaT1VSeWN0bFFGVE0zZmRxNjFqMzN1TzVyS2FBZ3Nt?= =?utf-8?B?UVZEVGRsYlBPYTNsME5RSE5meGVIaWhjTGUzbkZhNGtpNE5TTnNPcnFSMHAr?= =?utf-8?B?dlYxRkZSNmYyR2xIS2lnM24zZU1QVFZHcXI5dnljOEJkWE1aTjBybEVxRGhH?= =?utf-8?B?TnF3S2dyRXNweGxWSGZkY0FVV2I3VlF6eHBieTkrM1RONzVxczRyVG1Kb2lI?= =?utf-8?Q?JQOSqSNlZN9w/ovWluMxukx88?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ee17069-d25d-4443-57bc-08da5d9f701e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 09:27:38.9972 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MXtS9zdj5EuHMQDwhn39FbezJ5TaX8vyBnlNpKvr/qqXkExaFz/WgBmNNxX/cEAJmDsE1OHHl/jhUWryiBdXRA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8768 On 01.07.2022 15:16, Roger Pau Monne wrote: > --- a/xen/arch/x86/hvm/vmx/vmx.c > +++ b/xen/arch/x86/hvm/vmx/vmx.c > @@ -4065,6 +4065,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) > return vmx_failed_vmentry(exit_reason, regs); > + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) > + { > + perfc_incr(buslock); > + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; > + } To cover for the flag bit, don't you also need to mask it off in nvmx_idtv_handling()? Or (didn't go into detail with checking whether there aren't any counter indications) pass the exit reason there from vmx_vmexit_handler(), instead of re-reading it from the VMCS? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:32:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:32:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360068.589443 (Exim 4.92) (envelope-from ) id 1o8IR3-00026y-7t; Mon, 04 Jul 2022 09:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360068.589443; Mon, 04 Jul 2022 09:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IR3-00026r-2p; Mon, 04 Jul 2022 09:32:05 +0000 Received: by outflank-mailman (input) for mailman id 360068; Mon, 04 Jul 2022 09:32:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IR1-00026h-O0; Mon, 04 Jul 2022 09:32:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IR1-00049O-IZ; Mon, 04 Jul 2022 09:32:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IR1-0004nF-7S; Mon, 04 Jul 2022 09:32:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8IR1-0004bQ-6s; Mon, 04 Jul 2022 09:32:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=F3as8ixxxDayzkGVmdUIJxBaaA/EYktioFHy8IYM9mw=; b=dzj/XLs/3weHS2EtpfXAXu0XRf H0z1pld2UTDdYCSjju93LI7a+GtU+QqwHt2xgNPjvWMhHOYye6QMEt9mE1khtoHeWOtYpQPlPKE55 e2LVuJKyfyzJIZ0IoNT7CaD4RTAlEshYF8HV9Jb89MFZxLPEkDWXhXyjHTXj0C22UYSY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171479: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3b33548dd336d5afdf6fc224125ddb4425090f7a X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 04 Jul 2022 09:32:03 +0000 flight 171479 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171479/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3b33548dd336d5afdf6fc224125ddb4425090f7a baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 724 days Failing since 151818 2020-07-11 04:18:52 Z 723 days 705 attempts Testing same since 171479 2022-07-04 04:21:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115107 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:36:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:36:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360078.589454 (Exim 4.92) (envelope-from ) id 1o8IV2-0002nw-Tq; Mon, 04 Jul 2022 09:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360078.589454; Mon, 04 Jul 2022 09:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IV2-0002np-Qq; Mon, 04 Jul 2022 09:36:12 +0000 Received: by outflank-mailman (input) for mailman id 360078; Mon, 04 Jul 2022 09:36:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IV1-0002mF-E4 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 09:36:11 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2055.outbound.protection.outlook.com [40.107.22.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bcb95ee5-fb7c-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:36:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5429.eurprd04.prod.outlook.com (2603:10a6:20b:99::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 09:36:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 09:36:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcb95ee5-fb7c-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n5uh3582hsd6UgvryAW0EODJoZ4f64+YiFTEan0951kcvh7JKAxlJY3S8HxNULLVzpbm5w8AtPPx+Y4rPbOqi4XbIdOZjDc/EYUsEcO3LufBdp2UnzTbkU1Aa5odpDtXqQ5uTXw6uLLMhT5p8knQhXuhsjaCjQ1J04nNxLN76Qi3vGgwoCcIEcvm/hxuLbF84D9hkyYF0mBCWL9wQO/FWKjY8HpHaUYnzXU7CTUFZ9Y5BFZEUJPZG0z64+N7FHcXBD4YV96197807xlAb4UZLKOVAaUhXPRkCIQBC3MtaiICcFBwnRibQijjW00znLuBsMGR63TsCoOxZjY+YuezMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q6xKKvrTzkKsrHUsM0iN5okDsgdVIju65ZhH96dTARc=; b=czAOAoE3XX6gRVsunHpa0U36uY8qh0vcjEVBfBt/3XKjyB+lXXjjPuV2G7XAFnePLqr1cGUVpPy6tzCFe2EGJ7YOtfdFieFC4UD611veDYDahx1G2Z5eAI8DDRzpd0w46vTjYm/OsnJOA2yhPxUdSu9DvJaLlIAejH22AfAEJupgF3apC0s+IM0dArCIPEqyJl+dGStijNZjxaMcjhmd67P4GmzTJoE4RjF7A8PjabpaZBEO4eCKTR+BxN3bFThZ9HZNhvyOiQSM1DCJ9SPO977nvDENCAdWcciBXTiM9M4mOj5Gz8VTRqrNtYAUbi3DfPcym4TXxygRQdiiH3B1qQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q6xKKvrTzkKsrHUsM0iN5okDsgdVIju65ZhH96dTARc=; b=OTiUPavXpbxKCMN5rvUMjEsL47BhLyhKDMJOuysrmYLYbytUjq768WrM49PPNl3ppZkxAJDOyVWW1MoCk1W+pU7xsoEBNL7mwn+EYg7U9RBrv9pcDGPT03veOX1+COA+oBCldN6pNy5s3KSG15oRyIRgqASnw9MTdQRhstsoSD6uLImbzUoHhATxXmPY8s26/Ot3j3eSvFG8sTBqxQtyGGTvtt7Xir3+o8t9ddFTCehSVDUvU2cHRD1J8sILP/JZJRiX3kw1WlQmGOQig4Cu3xGLhcGqUXI0RLOAd1FtJLhBPNiFYez4X4TxqiuU18IHiIuSKg4MfKEtXFmkTRK3Fw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 4 Jul 2022 11:36:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/10] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Connor Davis , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Connor Davis , xen-devel@lists.xenproject.org References: <87c73737fe8ec6d9fe31c844b72b6c979b90c25d.1654612169.git-series.marmarek@invisiblethingslab.com> <9c7c11f5-be1e-f0ef-0659-48026675ec1a@suse.com> <8322303f-021a-b520-d2ad-cf8310573df5@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa6655ce-19e8-4456-e601-08da5da09d36 X-MS-TrafficTypeDiagnostic: AM6PR04MB5429:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fz3rabsYcddCgt/xt7AngJUcXxlT7SpMNh4Zcrnvcy+/kQ0p14+wg4hGUSmH6gkOHnzOMwVsDzCSaVvenz+JfdXXpuVVt2D9Y4OYlpjSGFy2gos/L7WEZyxnHZGW5RGwxHiptMlkqJa/3ICnlE1+lqqVWgmk25qcONhLoOr1zSefVcHvJtEd4xsseP5/URlYSV6WhPJ6oHTMyVaHhJF4eEFTnwkGeq9sv3PXuwffLE4Bn4G0SChLRbN50+2L9oLVKYvmgdWcQqgkNuQR3PaDjKGwmBFJzQgbtgtLo47U7R9y5OkQMsjBM6zs/LpGZucIFsfGTpVaPl0pdScWA3ao3KM14n7qOM8UMQS2/FtG89O/qawdzY8vZnhz2BWqv9ZhzOpRK0TRr8QXOZ7CQz2PkUyIQr4WeIp9r36Jb67ljQsMUvmnc8pbNTo8S6gLIu44Wpz7WvP5vvKBbcTOySAjleZb/QUwoKSbA3LwF5TKfEqprVwziaZ+Q0RnaYU6mcDxW9Sq6gxMMua3hyww3QFP64UL8/XDZlaypvtlvi6OJhPPpRRg3IVSJWmzVOCWUlUAHEcDA7d59v6PUoObgR/TJBHcjowZiWBEbk+pBUNN0q+gP9lrEHub8JgIwCVnXb2i4T5EC4pHHEIDIaBC69I7YLD5oN5zj6bWWmd2GTe9fkWU8sEZphE4R+LB9nlnJUfZu4JPfrH6zvSUzbUYBhJiYleu2DU8KBFKu0b5gRE8966cHFrKYQXGNEhITYZB2te0uCpOzUbNoL/558oFV6wPNUwniA/9OZTls4wbH9VolMM5dTa9HVI/P+zrSaGqyUUqIppj+ETOMQN1kmmjJ4YIzL0xSCP48xx5fD8H9dPP3xA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(39860400002)(376002)(346002)(38100700002)(66556008)(66476007)(8676002)(4326008)(54906003)(66946007)(86362001)(316002)(31696002)(6916009)(36756003)(5660300002)(6512007)(31686004)(2616005)(6486002)(41300700001)(2906002)(478600001)(8936002)(6506007)(53546011)(26005)(66574015)(7416002)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmtwNHJVdXpGdFZyQ2d5Z1ZnZTlzdENHRzdleE5ZZmpjcXVieDBoeGhUZWt1?= =?utf-8?B?SGNzczVhRjJKYmNDOFNhc1BvNGdqd3p2aHRlTGZ6dE9YcU5qMUpIaWtZUnUz?= =?utf-8?B?TTQzVitOSFQveFQ2bGdoYzgrc0xIRHBvRlEwaXRIcHJKQlcyQzFYdTVPMlhF?= =?utf-8?B?MEE0OTFSYUFVek1UQUtxOEZqeGlsWDFYUTRjbjBMVm1DZGhFM2xVM2R1TURp?= =?utf-8?B?RnprNVZCMGUyRDE1ZGs3ZEhQVGhGWHhxVTBuVW5mZFZBY2dIeVduZ0VZNm50?= =?utf-8?B?MVVzQWpkNSs2bGZyQnJZOURYMWdSQVJMWW1iTTlraUk3bEhpWmVmOGJITDBR?= =?utf-8?B?eGcydkNqWEVEMlIvUy84Vnc4NEozMTNJOTkzbDVtUDdIeFhSTmZiUExFYTlZ?= =?utf-8?B?QXQ2cUozQlVwM0M5MDdmUUxiK240ajVlZm9pRThqQk5jNExQM2NtbUk5YWJ4?= =?utf-8?B?U2NmMDd5UlVodTNGazZSY3EwOWtDeG1zTjd0bWhvT1ZWYkNEU0szY2ZkR0Uw?= =?utf-8?B?OFVWMzhtUVkreHpQODQ1N1ZIbDBITVh3b3ZZT280YzgyckE4bmFyTnNsRzRZ?= =?utf-8?B?WGJ3dVZjQS94YmZsMlpYTzR2SGJZb08zRUxoa3BiL21oR0lzVFBlWTBhTHN3?= =?utf-8?B?L1BGcTE1ZU8xY2pDcURObjFmeHF6U00vSEg0VksrTGl4NjJsQW4vNnpXdU5X?= =?utf-8?B?SWgwWlgzRVZsTWpqS1hEL1BSNGZ6TzJkVWk5RTJyUnNuNlNIYm1RWWYrdm9W?= =?utf-8?B?cUFqaEZhbXJOTThLb29OUU4zWDhiREg4Z2NGWTVzT2R2VUIvNGpvY1AxWXZt?= =?utf-8?B?WjVKbm9hS2d0Z2tEVVFiNHBzNEp2N1VFUWd0REdqNzMxSGtJSTNTVDJ1dXB5?= =?utf-8?B?QmlyZC9DNHNhRmxlL3BXY2R2SnY0OXBneEY3NVloYmxjN3RxQlFIMnpyWW1w?= =?utf-8?B?WDdPOWpNeDRycy9lUlR6eFloTjUrQ2JFbyt2MEFGRFppRGVrOVFPT1oycGl3?= =?utf-8?B?aG5jdEJkTDA1d0xtb0VKbi9sSTU3MVRFMXppdkNBVW1vdHN4Sk5IaFBRUndU?= =?utf-8?B?ay84QmQrejJ6Qm9POEtINXJyQXg2YmlKUG5SVUNqYlJkR3gzYitQbXJUVzJ5?= =?utf-8?B?Zkw2NXplYzBQelI3MnFuZHMwQUUzSEN1SWs5QTNLL0tWeHh5N25melQzbFlZ?= =?utf-8?B?YVVMcGNSaDNJenRCRS9UTjhWVGFUdGt6a3U1Q29XOFdDWDJyUnBjZFVvaDdH?= =?utf-8?B?MFIzWkxQRTBWTFcyTklzUHJYZGgybU5VZHRhSWl4U2ZWYUljSHc0Vm5UandH?= =?utf-8?B?OGJZanR4YUQrcS9EZEJ6OVpNZmdpSVNJWVVSQzM3UHIrM2Ryb3lob2JkeHBr?= =?utf-8?B?UlVkU2x2ZUtZUWpQV0FRRzI3SFBiYlAwcEw3NUhIOG1rcm8rZDZVUmZtY1Av?= =?utf-8?B?UUQ5Tlc3M1dqaTFzbUNyQVd6YmFDUlNjcnBBQTJoSGU3QUQvRmUwK3g3cnNM?= =?utf-8?B?S1ZlODMraFA0MVpMU0lCSVNhL1BUaW5WM3lreklyK1A2Vkt1cXl1bUJvYW4v?= =?utf-8?B?UytNZ1RxQUR3OFhrWFpJTno0YXJsdFA0RUZzRlVibkkwSUkrajZ0MmtIVWtp?= =?utf-8?B?aHBobTdxLzdTTEFwUXNhRWFNQmlrVVU5c0tDTUs5eGlPT2NSdkl5M0RyL0do?= =?utf-8?B?R1NFWVRFK3p6RC9oMzZoUlNaV1BVVEd0eVUrWEhUZzJ1VDlpRUFiVE1ad1p4?= =?utf-8?B?RUY5VXE5Y2RjbStpUkxlK295RDZsbUtRclhxa2ZRY0QySTNEdVF5ek8wYUVP?= =?utf-8?B?Q2ozbXd6aTNCUlBSb2cxOTg0VjNxQ1pDK2xPTWhxc1orblpNTHVZOFdaN0hm?= =?utf-8?B?NjczTGpYUDh1cTVVN1ZoMkNYaXVWUTdRc3JHcUowMUMzWlNFRGgvY29TS3U5?= =?utf-8?B?RmdoeWVmR2FNbnFNM2lnbWwvM0dlUlo4clNTbnVIR05rS05qWWtWM0JhUEkv?= =?utf-8?B?UU5vNXJCQXArQkdwcVAzTDA1WU51SFZCUkM3cDY4b05rWjdGUDhseG0rb0tW?= =?utf-8?B?eDIyRko1ZXUrTVFPYUttbmVhdDE0NjUxOGUwbDhNNFlob3FkMC8yZ0tEbXc5?= =?utf-8?Q?82LPkKQT5vq0SbH8o7mm/Vb1U?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa6655ce-19e8-4456-e601-08da5da09d36 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 09:36:04.1523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vuoipukn2SSfAFjFZ79DYKu5cSfDkrqJBN8iVnaLTdL/+dBmb5D5Lcy2tabGNBjw3mLivIxCq+vvfWlMUhGiCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5429 On 04.07.2022 11:27, Marek Marczykowski-Górecki wrote: > On Mon, Jul 04, 2022 at 08:05:06AM +0200, Jan Beulich wrote: >> On 03.07.2022 14:17, Marek Marczykowski-Górecki wrote: >>> On Thu, Jun 23, 2022 at 11:29:31AM +0200, Jan Beulich wrote: >>>> On 22.06.2022 17:47, Marek Marczykowski-Górecki wrote: >>>>> On Wed, Jun 15, 2022 at 04:25:54PM +0200, Jan Beulich wrote: >>>>>> On 07.06.2022 16:30, Marek Marczykowski-Górecki wrote: >>>>>>> + memset(xue, 0, sizeof(*xue)); >>>>>>> + >>>>>>> + xue->dbc_ctx = &ctx; >>>>>>> + xue->dbc_erst = &erst; >>>>>>> + xue->dbc_ering.trb = evt_trb; >>>>>>> + xue->dbc_oring.trb = out_trb; >>>>>>> + xue->dbc_iring.trb = in_trb; >>>>>>> + xue->dbc_owork.buf = wrk_buf; >>>>>>> + xue->dbc_str = str_buf; >>>>>> >>>>>> Especially the page-sized entities want allocating dynamically here, as >>>>>> they won't be needed without the command line option requesting the use >>>>>> of this driver. >>>>> >>>>> Are you okay with changing this only in patch 9, where I restructure those >>>>> buffers anyway? >>>> >>>> I'm afraid I'll need to make it to patch 9 to answer this question. If >>>> suitable dealt with later, I don't see a fundamental problem, as long >>>> as it's clear then that I will request that this patch be committed in >>>> a batch with that later one, not in isolation. >>> >>> This turns out to be rather problematic. xue_uart_init() is called >>> really early (as it should, to get console as early as possible). It's >>> before even boot allocator is functioning, so I can't use alloc_boot_pages(). >>> Are there any other options for memory allocations at this point? >> >> No "neat" ones. Stealing directly from E820 could be an option, but >> would of course be heavily x86-centric. >> >>> We are talking about 58 pages. It isn't much, but isn't exactly nothing >>> either. Maybe there is way to keep the memory allocated statically as it >>> is now, but return it to the allocator is xue is _not_ enabled? >> >> Well, yes, treating them like .init.data would seem to be the least bad >> alternative then, at least for now. Down the road we may want to generalize >> what's needed here, as there are other full-page or larger memory areas >> which are used only under certain conditions. We may e.g. want to introduce >> an approach similar to Linux'es .brk section (recently renamed to .brk..bss >> iirc). If a non-generalized approach ends up looking too ugly, I'd be okay >> with keeping things as they're now, just with a respective justification >> added to the patch description. > > Looking at it, I see another issue - Xen uses superpages, so I'd either > need to: > - reserve the whole superpage to be able to release it later (waste 6 > pages if xue is used), or > - shatter superpage when releasing unused xue buffers That's part of the reason for my desire to generalize this. > First one is probably less bad. But maybe, instead of doing all this, > add xue to the menuconfig (make the prompt visible) with appropriate > note about wasting 58 pages when built-in but not enabled. What do you > think? I don't mind it being done this way for now. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 09:51:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 09:51:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360085.589483 (Exim 4.92) (envelope-from ) id 1o8IjV-0005es-N6; Mon, 04 Jul 2022 09:51:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360085.589483; Mon, 04 Jul 2022 09:51:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IjV-0005el-KC; Mon, 04 Jul 2022 09:51:09 +0000 Received: by outflank-mailman (input) for mailman id 360085; Mon, 04 Jul 2022 09:51:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IjT-0005EP-Qo for xen-devel@lists.xen.org; Mon, 04 Jul 2022 09:51:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ceb75969-fb7e-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 11:51:02 +0200 (CEST) Received: from mail-bn8nam12lp2168.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 05:50:58 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by SJ0PR03MB6421.namprd03.prod.outlook.com (2603:10b6:a03:398::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Mon, 4 Jul 2022 09:50:55 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 09:50:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ceb75969-fb7e-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656928263; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=wi6kw4uQTOZiKIGsDr8MfBIXbEdkA8GY+W10rc9D2Go=; b=dHw6qahfIvfB6mjDtw/eJKfD4nANxiAC4Q7f4mbHUKwfe/K7x25C8qnB NqMZjofTlpKVzUXbfzmDBuT6nz3IKf+ZmdmKutD3fv1KF2FH0PxG2u9pG gmBTcEAhrULfCzR+9Gwt0r0SKlKQsDiVXhDoUGhHSAncbZNE8djSX6JWe Q=; X-IronPort-RemoteIP: 104.47.55.168 X-IronPort-MID: 75449540 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KPg83anxD6rGQxJsv0URmHPo5gyCJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJOXGqHaP2Dajf8Kohyb4qx9k8PuZGHxtQyQQI9/ihgQyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EgLd9IR2NYy24DmW1jV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYYDoMJqfxwP4kUBBHLxFuI4Za2Y3HLi3q2SCT5xWun3rE5dxLVRtzF6tIv+F9DCdJ6 OASLy0LYlabneWqzbmnS+5qwMM+MM3sO4BZsXZlpd3bJa9+HdafHOOXuJkBgmdYasNmRJ4yY +IDbjVidlLYagBnMVYLEpMu2uyvgxETdhUH9Q7J9PdruwA/yiRj1LHjFtf/OeakQO5OnB+4/ 3qe/mHmV0Ry2Nu3jGDtHmiXruHOhy7+VZ4fE6eQ6+VnmkbV3WsOEhYbW1yhrvT/jEOiM/pPJ kpR5zEjt7Ma8E2wUsK7TxC+5nmesXY0S9dWVuE39gyJ4q7V+BqCQHgJSHhGctNOiSMtbTkj1 1vMldW5AzVq6eeRUSjEqOfSqi6uMy8IK2NEfTUDUQYO/9jkpsc0kw7LSdFgVqWyi7UZBA3N/ txDlwBm7517sCLB//zTEYzv6950mqX0cw== IronPort-HdrOrdr: A9a23:daF2KKjS9hIcU94n5ZwghU0EyHBQXz913DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03I+eruBEBPewK4yXdQ2/hoAV7CZniehILMFu1fBOTZowEIdxeOldK1kJ 0QCJSWa+eAcWSS7/yKhzVQeuxIqLfnzEnrv5a5854Ed3AWV0gK1XYcNu/0KDwVeOEQbqBJbq Z0q/A30AaISDAyVICWF3MFV+/Mq5nik4/nWwcPA1oC5BOVhT2lxbbmG1zAty1uGg9n8PMHyy zoggb57qKsv7WSzQLd7Xba69BzlMH6wtVOKcSQgow+KynqiCyveIN9MofyygwdkaWK0hIHgd PMqxAvM4Ba7G7QRHi8pV/X1wzpwF8Vmg3f4G7dpUGmjd3yRTo8BcYEr5leaAHl500pu8w5+L 5X3kqC3qAnQC/orWDY3ZzlRhtqnk27rT4JiugIlUFSVoMYdft4sZEfxkVIC50NdRiKorzPKN MeQ/002cwmP29zNxvizyhSKZ2XLz8O9y69MwQ/Upf/6UkXoJh7p3Fot/D30E1wt67VcKM0md gsAp4Y642mcfVmHJ6VJN1xNPdfWVa9NS7kASa1HWnNMp0hFjbkl6PXiY9FlN1CPqZ4hKcPpA == X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="75449540" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BfqIFtq7S2KwGaoq7n4aFRze2/px+oLxpG+K0Q2o95GL5nDLsyjooG2n3Qcafejrn7fr1aqwVH0y5sAGQs2o5/nhYxSLDmZt1koEZ9UMgcMgMMO618YhIPjEkk34pGmVri45NinQ/sHRsTp/C6KtfIpqKkLLSXjI2LKej/YhOR11mm6EIgrkVXhSyfvwrqPfcIA9ed9B7jBBj+Zr9x4WBt5TqTaJ4Q3J0P2zelFi2J9URkEaN1Cpv/prks5+m5gZ8QLfVPS+w+xDGm5xuV4EJNqnzfSNZrwrLxO2WV/sKMIT2LmO8cjtFUs/1B25RA+Kqec+0XXzfu/9JhKAaejTKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rDluYUKcxAsQlmWWPBTm509lxxjiYLo8Seh9dxgoQU=; b=LDeV+mO9HcVINLVDvUKGoJz5Z3lpzWDo7v4Y8Xvv2wALcNlep4DX97FfxByHzKAdiijrwXd+lxgYWUMVgfE83ZqUvquX4Vr48PDgBeO/0WWO2a6a7c0G+Jzwr933Ky9fN13VgNspl3gf8j/n+AWFDMM4htkIl7Vk7qfHaeD6pYBdqL196XT5ayiVYUzpEwRDmZCX3d0f+gnqsoShWy8CDLlsyAwr9Fu3js+5QEQJGjPcVoLCCw/Zbr+n9DAuX5HNaUcaCr3nBE5vUTO6OSYWlVHYvd3h7FLUS/jex48Z00Cmd8RvajqT0v2z0bZp8TT98LwbTxSMkI6JlcWyULdi/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rDluYUKcxAsQlmWWPBTm509lxxjiYLo8Seh9dxgoQU=; b=YyZu7bs8rtBUVWkYxr+nuQsaQUEa6Xc9UR68FSr0jjqgqwIzB2q88ebLu3X4V4mHYOG8Pdf8vDhkzY5iusJ960Vv+KDR5JV3UY0Qmhs835eOX9B/JAv3mCQ1HXjGDJGlpHM80vjS8TkFvfv/O7CHT1LyI3+A9Czak++CBN2oZqA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 11:50:53 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "G.R." Cc: xen-users , xen-devel Subject: Re: PCI pass-through problem for SN570 NVME SSD Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-ClientProxiedBy: LNXP265CA0023.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5e::35) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4041e4d2-508e-4505-a6fb-08da5da2b044 X-MS-TrafficTypeDiagnostic: SJ0PR03MB6421:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D8Q6P7rkg5X4vLzAd2MrQqjqEnf+y1+ZM9la0cTrloBar+cWV3W7/9pDMwoUCiVRSMkxZ5xq9xP1WrH/w3Xbvmre1hAtP1sIgfWksbsAIJAcTW5CY+fFjogoJIHdxB/jSNMUrcDqbEBg8QPS3UI90b6Dh/rtaIVraZkID5A652EkiXGoSUFtq7K/jVLkvZ/hzFaXai+3nRwDHkhxpXJTgdA1/0JK7+RujjVJGKhoAEs4aLYsd+9pg+LtgImCFlPGUCIG7g80/EQpFdFbujvzaMEnKyFCkaMQD9Eef+l5sau6wH+brkojArUd4ZiX6ZHP0n6o7KouGeOIiN7mM7PN8EY6S4gsqJbd2xcHlnw563slvz8Iw55Ss8B16Cc7bff2BygFqsI5/qm0JBbDNBsxv21QW2J1ndnlZWrENMxMzAdlU6IAgJw1w6O+KIfeC+xa4LSr1fGBek1fzAuTqLe4fhKNJABStIsa07745Eif1GrEzspwhGnVH5hRLfDzd4mvQzvFW3NE+WtJ5KAmP47mc9/O+owMQAmvIDC5YYWfdfl0dN5FZIHSUw+I7JcopEYLNKL3c93QMa0bF7shQJpqOyjtp+EuS0SqwyQO4mZD8FWCxuyqdCIPIUZ2RukkbHrqdVwRkTOyXZodLOO1prjxMW9geNpZJhODZNnfsctP8gUHhtwpmINdgpL1G0RzDNBsmckfZy0GSbpypmAjgFIHN5CwHd9f3c4YuEd8EDt/1WnZWUyOC112t/wDgfrECtRqwJsbL/9yhLNn/pBIFnmZ28Zs6Ei6sXQRiXh6YE/FdpvBDaa2c8jk0a72//7jTU5tgTRqG8xVGnTnpUAQi2nj0XSwWAGcr+/iULkY9ZY4R6c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(478600001)(9686003)(6512007)(8936002)(86362001)(26005)(2906002)(6486002)(41300700001)(5660300002)(38100700002)(6506007)(83380400001)(4326008)(54906003)(66556008)(66476007)(6916009)(316002)(8676002)(85182001)(66946007)(186003)(82960400001)(21314003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVJHYyswWk43OGFyNkE4N0kwTjNOb1U3d0dTdjZZdWF6TDFTelFJSjU3SmFh?= =?utf-8?B?S3BybmM0d1V3dE5VdVpIT0JKaUN6OGF6SG1YVk1pN2xONjhzelhjNTl0Mkdi?= =?utf-8?B?WXJLNnJ1d1VpdUxFdnFEK1JPSkEzVW14WlJIZ1Q5NjRwM0ZhRE1NVklRMWYy?= =?utf-8?B?UFo3NU9EdTM5bU9oOUE1eGpPREg5UnRoY2kvRDJoUUdkamJGRDNORjZXVitN?= =?utf-8?B?ZXY0NTk5Y0hGM2ZIaHp6NE5Fb29KeDhCcmRGaEJnb2Z4QmVNNkI2MWFIdFlV?= =?utf-8?B?dW1ha3g4TkZWMUV0dnN5UzdLMGR5aXVncmo4YkZMYUZMUXdjMlNVOHJLbGxj?= =?utf-8?B?UDdJYlVtZklxek41bnhoRHhaVllnclNjbU12V09MaU9TM3dObFdOS3Z4NkZK?= =?utf-8?B?eXh3Zk5jN0dpTkZGeGdsOE1QZDl0NnZHZmZWcTNJbFlBV0lqbExtcnJKZjJ5?= =?utf-8?B?bFRLTjhiZnlLVGdjVHJUc1VEVzVyOTFwQ0djazUxNENScStLb0hTOG9Jd3VQ?= =?utf-8?B?aXFwY1NwUkVyK0YvNUJjczA2elZVWHcwTnBxbjczeDAxZkFkcy82SExLeitI?= =?utf-8?B?SmJ3V0NxK29HazROTVBXLytCNFVzVTBtbHBHSEpxbGUrcXNjajZDVXZjYk9a?= =?utf-8?B?VlkrUXJyQUpIc24rcGEyMUxwSGo4eE5mWnVOY096bDMvTzdIZGIzb1dTaFpF?= =?utf-8?B?eFBOanlJRTlwOHVwLzlBd1B5ZGp1aHFFN2N2eFh1a0FpVk9GdmNNTktMZ2Uz?= =?utf-8?B?QUkwcUJwNnh6MmRFVllqNkwwcHo4SUdTTmE2TmY5NzVkRkNTK3R0bWlGOTdM?= =?utf-8?B?b0VUYkpza3BJdThzUmNIU3VBUDR4T1JnMXpQMCtIa0JYUVVmUFNWNlJoUXZ5?= =?utf-8?B?Q2xYaDByVnY4SlNQdk9MV1RSeEhPRlYzd1g3QjVwUVYvZ3JqMmJ1NGI4MjNn?= =?utf-8?B?MmltNVRsckF3cGdmYjdONjZFaVNZemUrRlI5NmNyWi8xNnNHVG9MZVpUTzhM?= =?utf-8?B?TVcvSFQvRHMreURJTUtpbUY3cmoxRWNiVEdwTXZsQ2cvT250WldPRG9tMUhI?= =?utf-8?B?S3NoK3h0UWVEM1kzbmtoZ2NCa3hHN2dZRmpUdEk5aGY4M21LdmFqUXFlaFcr?= =?utf-8?B?MzRqdkJWb0VrcjJCdDh5YmM1clZLUTV0eHAyYXBqWk0wRjRnMUl5U2pnZjhR?= =?utf-8?B?Z2M2Nm56RXBZQ3U5OEp4MUkycWV4MkpmSVhXWUVOYWh1N0NZSWZJMURTdmlK?= =?utf-8?B?VVNUUk1jdC9jd3E0RldFQlhwK25qQlRpYmcvVXZSYzlDaWtFbUt3Mm1Oc3Yw?= =?utf-8?B?REdJUEYrKzZpczBLdzJTWXZ1Q0lXd2hndHpDWnZZdWdyK1gwQmtrVHVQU2d6?= =?utf-8?B?WEp6dzN6UDgwVmM0aE9sSkxqNkl3K3ByUzcvOERoeDhjeWx5WERoWDN1dlov?= =?utf-8?B?bmdGcXViUVRJa3ZOYjhBZmlyTzFxMTZNVm41aHh6ejZmb25OdWN6YTV4c0RE?= =?utf-8?B?ZkdnOWJOem5YYklrWHB4U2IvdUN4ODZGNGpjekdza0VneWJLNlhXbUNGeC9w?= =?utf-8?B?K28vQStHMENrN3U4SkVxVTFtbXdNNEVJdms0ZTVMS1IzSmIzanBScXJFQUJU?= =?utf-8?B?VnNtMWlYMU10S2tJL085c2xmTEgvS1lWcEZBWktqU2MvRXo0TGdCY0Y2eElp?= =?utf-8?B?bUdaTWVEMVZaL3J6Ui8xMGRjK3NpNHozNjBxdWUvVjJtdUZFVUpCL082NnpK?= =?utf-8?B?cGtnbG8zVFRyNHUzVnV6UEdyYUtUclJwaVd1Ui83ZE0xTVJaRGlMN3dzMGlP?= =?utf-8?B?bEw1a1BHK2dkdW9ycnBIK2hwQ2tPMUo5VTBWcUU5bGNSNXcrUHAvd1dRR3Jl?= =?utf-8?B?cytvRlJidmpyNGZ5SnFDRW8xZGxnSnJiYmpybjgxdWcxdzBVYXNtWFlXeFdX?= =?utf-8?B?WDFoRjhaWVRBZm1MNSs2Q200RGdMalpBYmhDZElsNlRDNllkZVo3TE8zdjNM?= =?utf-8?B?eFlkTmVudWYxVlkvY0M1UzBkdkRiaVJacG5Rb3l3dytFeUE3RWlMeU5ETnFY?= =?utf-8?B?dUtLc2w0V1M1cUNjTVFQRlZVNXR6TmxoWkhMNVAwbjdzQ1dUdittZXF0REQ1?= =?utf-8?Q?k7/Et4k2us5GLEn4iI7GeH4hS?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4041e4d2-508e-4505-a6fb-08da5da2b044 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 09:50:55.0814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IEbNg3aSLf+cQ1YlHiwxlwzo2HlikTsaQ2QNboWV7x08A8kUTbaq6ofxkLbDdsnc7OcgT6F3SHqz+MDNjCgVwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6421 On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > Hi everybody, > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > So far I have no idea if the problem is with this specific SSD or with > the CPU + motherboard combination or the SW stack. > Looking for some suggestions on troubleshooting. > > List of build info: > CPU+motherboard: E-2146G + Gigabyte C246N-WU2 > XEN version: 4.14.3 Are you using a debug build of Xen? (if not it would be helpful to do so). > Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) > The SN570 SSD sits here in the PCI tree: > +-1d.0-[05]----00.0 Sandisk Corp Device 501a Could be helpful to post the output with -vvv so we can see the capabilities of the device. > Syndromes observed: > With ASPM enabled, pciback has problem seizing the device. > > Jul 2 00:36:54 gaia kernel: [ 1.648270] pciback 0000:05:00.0: > xen_pciback: seizing device > ... > Jul 2 00:36:54 gaia kernel: [ 1.768646] pcieport 0000:00:1d.0: > AER: enabled with IRQ 150 > Jul 2 00:36:54 gaia kernel: [ 1.768716] pcieport 0000:00:1d.0: > DPC: enabled with IRQ 150 > Jul 2 00:36:54 gaia kernel: [ 1.768717] pcieport 0000:00:1d.0: > DPC: error containment capabilities: Int Msg #0, RPExt+ PoisonedTLP+ > SwTrigger+ RP PIO Log 4, DL_ActiveErr+ Is there a device reset involved here? It's possible the device doesn't reset properly and hence the Uncorrectable Error Status Register ends up with inconsistent bits set. > ... > Jul 2 00:36:54 gaia kernel: [ 1.770039] xen: registering gsi 16 > triggering 0 polarity 1 > Jul 2 00:36:54 gaia kernel: [ 1.770041] Already setup the GSI :16 > Jul 2 00:36:54 gaia kernel: [ 1.770314] pcieport 0000:00:1d.0: > DPC: containment event, status:0x1f11 source:0x0000 > Jul 2 00:36:54 gaia kernel: [ 1.770315] pcieport 0000:00:1d.0: > DPC: unmasked uncorrectable error detected > Jul 2 00:36:54 gaia kernel: [ 1.770320] pcieport 0000:00:1d.0: > PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction > Layer, (Receiver ID) > Jul 2 00:36:54 gaia kernel: [ 1.770371] pcieport 0000:00:1d.0: > device [8086:a330] error status/mask=00200000/00010000 > Jul 2 00:36:54 gaia kernel: [ 1.770413] pcieport 0000:00:1d.0: > [21] ACSViol (First) > Jul 2 00:36:54 gaia kernel: [ 1.770466] pciback 0000:05:00.0: > xen_pciback: device is not found/assigned > Jul 2 00:36:54 gaia kernel: [ 1.920195] pciback 0000:05:00.0: > xen_pciback: device is not found/assigned > Jul 2 00:36:54 gaia kernel: [ 1.920260] pcieport 0000:00:1d.0: > AER: device recovery successful > Jul 2 00:36:54 gaia kernel: [ 1.920263] pcieport 0000:00:1d.0: > DPC: containment event, status:0x1f01 source:0x0000 > Jul 2 00:36:54 gaia kernel: [ 1.920264] pcieport 0000:00:1d.0: > DPC: unmasked uncorrectable error detected > Jul 2 00:36:54 gaia kernel: [ 1.920267] pciback 0000:05:00.0: > xen_pciback: device is not found/assigned That's from a different device (05:00.0). > Jul 2 00:36:54 gaia kernel: [ 1.938406] xen: registering gsi 16 > triggering 0 polarity 1 > Jul 2 00:36:54 gaia kernel: [ 1.938408] Already setup the GSI :16 > Jul 2 00:36:54 gaia kernel: [ 1.938666] xen_pciback: backend is vpci > ... > Jul 2 00:43:48 gaia kernel: [ 420.231955] pcieport 0000:00:1d.0: > DPC: containment event, status:0x1f01 source:0x0000 > Jul 2 00:43:48 gaia kernel: [ 420.231961] pcieport 0000:00:1d.0: > DPC: unmasked uncorrectable error detected > Jul 2 00:43:48 gaia kernel: [ 420.231993] pcieport 0000:00:1d.0: > PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction > Layer, (Requester ID) > Jul 2 00:43:48 gaia kernel: [ 420.235775] pcieport 0000:00:1d.0: > device [8086:a330] error status/mask=00100000/00010000 > Jul 2 00:43:48 gaia kernel: [ 420.235779] pcieport 0000:00:1d.0: > [20] UnsupReq (First) > Jul 2 00:43:48 gaia kernel: [ 420.235783] pcieport 0000:00:1d.0: > AER: TLP Header: 34000000 05000010 00000000 88458845 > Jul 2 00:43:48 gaia kernel: [ 420.235819] pci 0000:05:00.0: AER: > can't recover (no error_detected callback) > Jul 2 00:43:48 gaia kernel: [ 420.384349] pcieport 0000:00:1d.0: > AER: device recovery successful > ... // The following might relate to an attempt to assign the device > to guest, not very sure... > Jul 2 00:46:06 gaia kernel: [ 559.147333] pciback 0000:05:00.0: > xen_pciback: seizing device > Jul 2 00:46:06 gaia kernel: [ 559.147435] pciback 0000:05:00.0: > enabling device (0000 -> 0002) > Jul 2 00:46:06 gaia kernel: [ 559.147508] xen: registering gsi 16 > triggering 0 polarity 1 > Jul 2 00:46:06 gaia kernel: [ 559.147511] Already setup the GSI :16 > Jul 2 00:46:06 gaia kernel: [ 559.147558] pciback 0000:05:00.0: > xen_pciback: MSI-X preparation failed (-6) > > > With pcie_aspm=off, the error log related to pciback goes away. > But I suspect there are still some problems hidden -- since I don't > see any AER enabled messages so errors may be hidden. > I have the xen_pciback built directly into the kernel and assigned the > SSD to it in the kernel command-line. > However, the result from pci-assignable-xxx commands are not very consistent: > > root@gaia:~# xl pci-assignable-list > 0000:00:17.0 > 0000:05:00.0 > root@gaia:~# xl pci-assignable-remove 05:00.0 > libxl: error: libxl_pci.c:853:libxl__device_pci_assignable_remove: > failed to de-quarantine 0000:05:00.0 <===== Here!!! > root@gaia:~# xl pci-assignable-add 05:00.0 > libxl: warning: libxl_pci.c:794:libxl__device_pci_assignable_add: > 0000:05:00.0 already assigned to pciback <==== Here!!! > root@gaia:~# xl pci-assignable-remove 05:00.0 > root@gaia:~# xl pci-assignable-list > 0000:00:17.0 > root@gaia:~# xl pci-assignable-add 05:00.0 > libxl: warning: libxl_pci.c:814:libxl__device_pci_assignable_add: > 0000:05:00.0 not bound to a driver, will not be rebound. > root@gaia:~# xl pci-assignable-list > 0000:00:17.0 > 0000:05:00.0 I'm confused, the log above is mostly from a device at 0000:00:1d.0, while here you only have 0000:00:17.0 and 0000:05:00.0. I assume 0000:00:1d.0 never gets to appear on the output of `xl pci-assignable-list`? Also you seem to be trying to assign 0000:05:00.0 which is not the same device that's giving the errors above. From the text above I've assumed 0000:00:1d.0 was the NVME that you wanted to assign to a guest. Could you attempt the same with only the single device that's causing issues as assignable? (having other devices just makes the output confusing). > > After the 'xl pci-assignable-list' appears to be self-consistent, > creating VM with the SSD assigned still leads to a guest crash: > From qemu log: > [00:06.0] xen_pt_region_update: Error: create new mem mapping failed! (err: 1) > qemu-system-i386: terminating on signal 1 from pid 1192 (xl) > > From the 'xl dmesg' output: > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted Seems like QEMU is attempting to remap a p2m_mmio_direct region. Can you paste the full output of `xl dmesg`? (as that will contain the memory map). Would also be helpful if you could get the RMRR regions from that box. Booting with `iommu=verbose` on the Xen command line should print those. > (XEN) domain_crash called from p2m.c:1301 > (XEN) Domain 1 reported crashed by domain 0 on cpu#4: > (XEN) memory_map:fail: dom1 gfn=f3078 mfn=a2504 nr=1 ret:-1 > > > Which of the three syndromes are more fundamental? > 1. The DPC / AER error log > 2. The inconsistency in 'xl pci-assignable-list' state tracking > 3. The GFN mapping failure on guest setup > > Any suggestions for the next step? I'm slightly confused by the fact that the DPC / AER errors seem to be from a device that's different from what you attempt to passthrough? (0000:00:1d.0 vs 0000:05:00.0) Might be helpful to start by only attempting to passthrough the device you are having issues with, and leaving any other device out. Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 10:07:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 10:07:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360126.589493 (Exim 4.92) (envelope-from ) id 1o8IzK-00084N-94; Mon, 04 Jul 2022 10:07:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360126.589493; Mon, 04 Jul 2022 10:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IzK-00084G-62; Mon, 04 Jul 2022 10:07:30 +0000 Received: by outflank-mailman (input) for mailman id 360126; Mon, 04 Jul 2022 10:07:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8IzI-00084A-Eg for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 10:07:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1946af4a-fb81-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 12:07:25 +0200 (CEST) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 06:07:20 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CH0PR03MB5987.namprd03.prod.outlook.com (2603:10b6:610:e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 10:07:19 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 10:07:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1946af4a-fb81-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656929245; h=date:from:to:cc:subject:message-id:references: in-reply-to:mime-version; bh=rJ/JhJWFXZCOroLn+n3FdEA+T6RlqhtkAgrakPFEtEY=; b=Kf5Bp/1olrcvQYO754fKuD0HbdqxNTYSdOTdsN6hQ6Qp2PUwflYYsgKe o/hROC39izwQLQSqSd2XnuMXmkvfWXpUeBrjN7h+p2b8xnqwHFIhtDtzB x8KuPJrSiL8PRhXqp7DkWF8RQbOZtoBv7sk37YzqBAlVxPjfuz5bjLxzV k=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 74346089 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:d0r7kKgll72qgDQG4v8fb8KQX161ehEKZh0ujC45NGQN5FlHY01je htvDWnXO/3fY2ehe492aIix8kxQu8WBztJhT1Bv+C03QS4b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M58wIFqtQw24LhXFvW4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YRlxO4rWn8khaSl/Fx5RDKpi37TIGFHq5KR/z2WeG5ft69NHKRhveKE9pKNwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIAehWhv7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9w7O+fRvszm7IApZ+uLkM+H8V9uwWsAWgB+xq V7f72LbK0RPXDCY4X/fmp62vcfNly7mXIMZFJWj6+VnxlaUwwQ7CgAQE12yovC7i0u3c9NZN 0EQvCEpqMAa90G1T9+7QxyxplaFuAIRX5xbFOhSwB6J4rrZ5UCeHGdsZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluP1TM9KGYDYWoISFUD6ty6+YUr1EuQEZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPuRENXCzAS58Ebuk IronPort-HdrOrdr: A9a23:VHXgBq9z2jAjC3cRpShuk+FEdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdgLNhRItKOTOLhILGFuFfBOfZsl7d8mjFh5VgPM RbAtRD4b/LfD9HZK/BiWHXcurIguP3lpxA7d2uskuFJjsaD52IgT0JaDpyRSZNNXN77NcCZe yhDo0tnUvRRV0nKuCAQlUVVenKoNPG0LrgfB49HhYirC2Dlymh5rLWGwWRmk52aUIG/Z4StU z+1yDp7KSqtP+2jjfaym/o9pxT3P/s0MFKCsCggtUcbh/slgGrToJ8XKDqhkF9nMifrHIR1P XcqRYpOMp+r1vXY2GOuBPonzLt1T4/gkWSvGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KNoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vFrLA BXNrCT2B9qSyLaU5iA1VMfgOBEH05DVCtue3Jy9fB8iFNt7TNEJ0hx/r1sop5PzuN+d3B+3Z W7Dk1ZrsAwciYoV9MNOA4ge7rCNoWfe2O6DEuiZXLaKYogB1Xh77bK3ZRd3pDYRHVP9up4pK j8 X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="74346089" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TycFsGFoe/nTc8KuMZyDkXjig+t9QQulxO9PkJM0XvGTolDWnBguPlKaNraqwl0ogDVRGV1y0+2Oc6ogLh64OM9+7NcGippoFUFVcH/NkArEDcup3pmgUEnObRBXQWQIL8YtLn893vjmscjSHGE5jltVW3WhwrkXHqUrccdjpD7YZtwFLs/GtYcNZ9B/c166+37lUEudqrjhn2azStdpZMpD5SRRKp02EEuzIYJZgN/yp4CxIBWaKPOLo0dgualC2CyVNBZvfjRHGGwzObQ2Sb8JqacoUrgWEGUobKW9B2iYJ1jtRwFqY4nSwr8IcX7NyDrIXWOVf4GYp0K7JEhL5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r/eoU4HS7oUI5jbCrKJ6hYEphK9oyK1oMtredb0lIVU=; b=MP9Ka3aAoLekPKy+XkbT/nNUMSr/dqLGavHHzUZEPJ5DPvDDMeXO7xq8oHygaFHCRoRSlhhPaowDbzQeLm0pQEmqwQMybq5LhMBF9Jq8g4611iNYOg3zZge39aFvgiWTBUg49GLTzh3uvl8wjBamTKv6MBQidLHgnhbXdMJJRhPGYODzFlRAODFB6Bf49pVzfmmnja5S+xIrLbFnkRZ1FV0dnBnNgK8Z2uTlUq2IH4M/x+ASa+Qc6FEToSnuxWTGxXhryLGmKgJIafoo1x1lUlhEqGvyk9yPx1CBU7ApnmJ2cdERi9HZK860utYE8P0m+eoiwDU/UPTix6SDVbiVwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r/eoU4HS7oUI5jbCrKJ6hYEphK9oyK1oMtredb0lIVU=; b=kC2zWGR3gf/P1etpUk8xjrIkJbNa2SaP53534TIH0+Mk4bHbDGVrSpLz5Tk5aHxOw5UVSzzvj9LVfAzEwY7pkJZthZycRcGG+NnxP8+3nhg9clvZ/G44lMqPcL1DVP39EUxQXruCRgDoaopsLKGWtCXUESvJbi0Ymz+7AdTMXek= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 12:07:17 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Jan Beulich Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Message-ID: References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-2-roger.pau@citrix.com> <325bbf52-3b56-4062-88b5-a04dc21404bc@suse.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <325bbf52-3b56-4062-88b5-a04dc21404bc@suse.com> X-ClientProxiedBy: LO4P123CA0403.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::12) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: faae81be-7b2b-4ccc-d7c8-08da5da4fa47 X-MS-TrafficTypeDiagnostic: CH0PR03MB5987:EE_ X-LD-Processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O9lBpsHn4nZLcWIK6bJJZsTSvxxQHuTtbNO9PjXKvAmwb0o0o+HZMhhjNt68iuvd8vVPGwBmrU79dvu8TAcMK7Mm7nrTLqEZc/s0cdVghIT61mpRwcq/BRBaFS9aNX7YVBIbQm9Gc1yAe+sS8yjPj47j9FMsMKPj0KrlzxWDaZo4cxtNbavhTDuTquz0M61voJpXeRiBkgWRQZluRVcGSkvnH9yQNIoNQ7AsDDWAAC9ngGkZAsmstPApmsez9ie1MssD+4BdYZ1KdXflkAbbK+TzoOUae1YqXixqCYtfDCeZbdPa0MzcZQHCj4mnZ0F+w2HRYQ9XedDKd9vWCOe9T6jzbggZAB3lWaPjuDh40ePrlSb+CDv5KJjLiSK+ANXnWQxWtOzM51tBX+8GoLD1fIJBAwAlhYNawyQ20SSP0ma0kYFE/E4jM0+veGjn0O2l9A68a7ElA4sQTl2oFVUDT1U+Mb2DpkFe4XsiEhW0QizyDsi6FM8IzRluAKmMp1FVwe7Q7QUCw1nwo2RM4l4rtHxCKPnSxown6puDLSoL7/qiOwN06WrnOPXMbe/R7y6ZjQY3X+oJ+0vCQgD97xPJxHcaHc/5EROA4JWHW/1IjMwBer04M8tKuxO0tOw1kFbiVvGRtQwSg+AB9gFXe3hjHpe1lQwK+IcVjSqflgsEuypAGsIkOHYv3E6IrOarVj+Ef0x5WWF62Wr6Ps62wp5IK0/W6at6dQOUsG44RUt+vao70TrtA7P7ViyJJkFc+DTDOk6QuDn73p5lkdhgftpuqw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(5660300002)(9686003)(6512007)(8936002)(478600001)(6506007)(86362001)(82960400001)(53546011)(41300700001)(2906002)(38100700002)(26005)(85182001)(83380400001)(186003)(54906003)(6916009)(4326008)(316002)(66946007)(8676002)(66476007)(66556008)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1F6SG5WRjZyWEZ1RFkzeDBZdDNCY1hIWjV2VHNnWkhrWW9Hd0hpdC91QzJz?= =?utf-8?B?T0ErcW9QSXBHaXVMNUZ0VG5tUmJrQ1RVY1BrOXpOVTlqNHE3VDZFWDV2cWlj?= =?utf-8?B?bEFNcWQ5VUR4WXFHZTArbFJwa1d6eHJYdW5PdFBhTWFhWXJYTndlVnpUZW9Y?= =?utf-8?B?YkRKUUZudkNUZ09VMElDcC92SFVFR1dIWGNFVkNOTmJJNlNBYUFUMjgxTW5t?= =?utf-8?B?NlVmbUN4Q2R4V2owYmJTMzNPNFAzNWVYNDZFQ1Jnd29HUFFQYUkydDVTSVFH?= =?utf-8?B?L0R2bjZSdjB3dFUxMWhGN0F1WFJsWmFJQkthWHYvOE9jbWJhQW1IekZUaDg3?= =?utf-8?B?V2pPM3NZUjY2aHdldUdMNUVNeldGbG1LeGVZWDk1QTNCMyt1SUtucktmRHRK?= =?utf-8?B?UlY2NytyUGhpdExlYXp0MVo2ejhGRkdEWDhIVmxoRkhoUDZ3bk0yVTVyRnYr?= =?utf-8?B?TUkrMDNvK2N3clFCanpEZ1RPN3BpMnhNUW5GVm4rdG80aHRubU1XV0ttRnlt?= =?utf-8?B?M2daU0ZWMDFUdVFYNUEwZFVQRmxvaTliWWNiYkM3djJYQ2VKMjFlYlAwakRW?= =?utf-8?B?azlLTE5Tb2lITERDTlZwZnRGWTQ5WVZIL01Jc3k1UnpPMC8wK1RLOHNZK1F3?= =?utf-8?B?TmFKc3o4Q3pjREJPK0plbkdvSUtSVjJHTXpZM1R0aHJUOUo1SnRLNHBYSklB?= =?utf-8?B?dHp2NE5lRys2U3MrREY4TGRSaHkzNG5USGVJY3lmOXl2OWh2d0cwc0g3SnJT?= =?utf-8?B?TEpHR1R5T1ViNHFqTk1USVJLeFFOOGlBWVp2MEV0aWlkaytDMGZLMHBuQjBS?= =?utf-8?B?cjNiZHZkNmZQUFA3WjQ5Nlc4VGVqdElVYVdueDR2d1F4ZXVobFVQQm9JL2JZ?= =?utf-8?B?cjQxWklNdEl5LzkwZ0ZmMHBNdHZORmY5a1g0MnhqRTFqQmtUdmlUSXdiUHZa?= =?utf-8?B?cEJIRUhDSDJ2N04ySE5IN3VaZjkzaXlxODhuWFhjVjVVckt4MzIzcno2Vms5?= =?utf-8?B?OUNSeFFrd084T0N2OURpakRDVnl2SVVTdDJaVE43YW0vMVVuaGZLdjVveWlp?= =?utf-8?B?eDB0YmVWelJDYlVjNlc4ME5lRnQ1Y0oweHpPVThNVys1aFAvZFR0a2x5QVBh?= =?utf-8?B?NmJJTGhOZEFjSTZkNWFqN3RPZDJTZHdKQXpYQkdQTXgvVUdHbEhjYXYwMnVP?= =?utf-8?B?a0tJbkN2STJsYkNhandzQzNVZHVOK1dFUWNXWXlUR2R6ZTAxNlVTZll6VVZU?= =?utf-8?B?WDB1Q1Q0ZzdpeHFUSTVtR1dEY09EYjhwRm83ZTBBTXJhRXJKRGVBdEN5Y0Va?= =?utf-8?B?ZXVyemJZSFZ6bjY4MG8yenU1U1VWdTZHRFc0bHVsZTNsM0dHL24xOG1zYTJ4?= =?utf-8?B?NUpiajZsVFJJM0xzb3hRMnpvSEg0NktHVXVZV28wL3VMZzlLL2RleW5tUEZN?= =?utf-8?B?ZzNya3pjNGpiOGxmYTM5aW5mQWpRamgrRTRWUlcyS1JUM2I2YTJsMTRUbkZ4?= =?utf-8?B?NFl6VjRFdTlBM2lNN1R6Sy9qQjE2UnB3Nm5JUkZBaXRkZEQweEM3RVZPTExR?= =?utf-8?B?OG9MZnI5bTJ6Zld5UHVYOWkyZ20wcVlUcWpIaEFNeWRuLzBEQjl5aXc0cHQw?= =?utf-8?B?MDRLUEVYMjI0SUwzeDYyUlJBMnpnVEFFVFZudjFuWTBjZGY5OFRmRkRSeEV0?= =?utf-8?B?c1g0VDBFUTE1Q0tDRnpTeWNkclVnNFpwWUFFMGpXemJQdVJ3UzdQbXZhTVpp?= =?utf-8?B?anVrc2EwYzFuSGdrN1ZyaHJxa082NGdqM2RZSTlIL01iREVBbHpUdVc2RzdK?= =?utf-8?B?Sk9pYzloMjBqeVJRTWJOTkFYL0o2dlFYYVVTS2ZXNFcvT2JDYmtDTTRYeE1Z?= =?utf-8?B?WVR4TkxrRjBiaEZRL0pPcTFSUjdqR2ZxQ01pcjhHYXhLblJGRWE4aSttTHd0?= =?utf-8?B?THkwbVEvTmpHQjFwZ1UwU29aYTJQdW05dmVlMnlSV21HRHRXREdWRUhUdXlR?= =?utf-8?B?aStQY2lacVBDVnVaNDRDQmpaZjBMUHc2RzRCMmNMVnZkREhoTjBaS2lxWlIr?= =?utf-8?B?TVUvN1ByS3dHZ25YQ01LZUNOY1lMK0N4VWlFUlhpRldBM0FRRm0yZHZmY2lB?= =?utf-8?Q?1Hz4yHIYTpNg6DL7w0DJHYt+n?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: faae81be-7b2b-4ccc-d7c8-08da5da4fa47 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 10:07:18.3565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KVBt0jaHwXzlg4nnbdepo4Xhew1yem1bXkeeTe/cfvDfzat//HW1pKKU8vderf1HXRyXIoaaQxVj2hga0ZhGFw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5987 On Mon, Jul 04, 2022 at 11:27:37AM +0200, Jan Beulich wrote: > On 01.07.2022 15:16, Roger Pau Monne wrote: > > --- a/xen/arch/x86/hvm/vmx/vmx.c > > +++ b/xen/arch/x86/hvm/vmx/vmx.c > > @@ -4065,6 +4065,11 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs) > > > > if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) > > return vmx_failed_vmentry(exit_reason, regs); > > + if ( unlikely(exit_reason & VMX_EXIT_REASONS_BUS_LOCK) ) > > + { > > + perfc_incr(buslock); > > + exit_reason &= ~VMX_EXIT_REASONS_BUS_LOCK; > > + } > > To cover for the flag bit, don't you also need to mask it off in > nvmx_idtv_handling()? Or (didn't go into detail with checking whether > there aren't any counter indications) pass the exit reason there from > vmx_vmexit_handler(), instead of re-reading it from the VMCS? This seem to be an existing issue with nvmx_idtv_handling(), as it should use just the low 16bits to check against the VM Exit reason codes. I can send a pre-patch to fix it, could pass exit reason from vmx_vmexit_handler(), but I would still need to cast to uint16_t for comparing against exit reason codes, as there's a jump into the 'out' label before VMX_EXIT_REASONS_BUS_LOCK is masked out. I think there's a similar issue with nvmx_n2_vmexit_handler() that doesn't cast the value to uint16_t and is called before VMX_EXIT_REASONS_BUS_LOCK is removed from exit reason. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 10:32:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 10:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360132.589504 (Exim 4.92) (envelope-from ) id 1o8JMy-00036a-8C; Mon, 04 Jul 2022 10:31:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360132.589504; Mon, 04 Jul 2022 10:31:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8JMy-00036T-5X; Mon, 04 Jul 2022 10:31:56 +0000 Received: by outflank-mailman (input) for mailman id 360132; Mon, 04 Jul 2022 10:31:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8JMw-00036N-Vl for xen-devel@lists.xen.org; Mon, 04 Jul 2022 10:31:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 853dde32-fb84-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 12:31:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5443.eurprd04.prod.outlook.com (2603:10a6:208:119::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 10:31:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 10:31:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 853dde32-fb84-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K1VrwaYgygqOngXtShkQVb+0wJVCMKbw+u3IK4WnHTiH934Q8gOhw1LUKuKhqUATV5nfB4nQ7vqONXvjXP9yLrZRZqimvOg2vIshp+DI5FmEFvd0qMu3DaGv9r5ZUMl0IYmwwTPGU6aynwtYbTcMR7761L/gVGKJcwmv+yBGGx75ndQJ5iIg76+SmwD5AXG7ZFgWYF9AnF1a3BeYxyorpqQ+p0xhSGmS5Kzeo0hJdX1t3WO6c6DM5iEp0xLZ0biSanrlaNUp1T8KKnHzL48e+LkaTFEQky5UZ8tmRF2zFfoD3qPKAxBl+1K7kXZNHANX9ixdqAVP8sFQFQQdgYL7EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JvYimHc7miBXWxY1r0oSigWxnHtEf6m2Gcy0rQtxueQ=; b=VsgRoszTq/SOS9ImYCl8m52alhqZEZ5SO07ZvOXVfIEN1FVE1tDLHUT0Zb6B5kBx7EBL3BruXW9CPLShzdm4cSF270M7CIXbqGKR0BTR5G4iktbHz2EkWWDaMigkbmyfAqveop4ExAheN4ic2Yt/qyBABDIDjDFUKTCiO/G1T2koDNkg8EXaAx69L4gW4KsqYQQ5HYKjECS6CxAbAaYi6c6sLPje7FK/KG48ADVbqOskt9xT62w/9m0BZ41adG+gEsfdVowndBO4v0u4ZKpnqqpCcP2ojPOIoDdnhkRWfisB9vHVTdeeYq6KwUQ5yX9tf/dyh86Z/Ys7b7/cbdpjyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JvYimHc7miBXWxY1r0oSigWxnHtEf6m2Gcy0rQtxueQ=; b=I8QiIKxuzTrC0LnT413REq1vURAMAtxTcP5LmEg3Td4PPL8/jhQNwZlxxnMOFFt2C7IEqzeB3sVDSwmCcntC+aFsGS78ebmYIkrLJXoohmQuVXC0YM+1k1VVbcQUQdYNlrJJgJUcEB8SZj3lmLvMHkLk8FQ3SHmpGL0d0xlWQ+BE9AUHQnkSHmjaMP/++JXrLGdsnlMl1SOXRkEgnA+LoRtImF1o4gFLGqBJWpS4DwpsEFiqHvcWMx+o55mKS5VJcs0wFyPH1mee0cT1zct8Ai9GUbr0FrxnKez8R9CqN3m5J2EW2fQ6X/Bl8lWRbqFoJ1hTfZOBqqFu5lFjuYyzZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <04bffc27-9a08-b0de-5e77-93d26d2a3e8f@suse.com> Date: Mon, 4 Jul 2022 12:31:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." References: Cc: xen-devel From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0047.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a7afbf29-bf87-4b96-2a4b-08da5da8683b X-MS-TrafficTypeDiagnostic: AM0PR04MB5443:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bcbaV0E4frQQCpTF2t6+ZwdQrmEHPmiQHHh2bS18I4ZXKg4pm1nymqJ5Wz0AcJW5Xf20JigRTm2tNiGGga2t+7eDATnpMY1fhXfNYF6RXkvoFneXMQAzHBLqhNEXZamN0YVHCxPc5MY/vSgw8sHFjCL4hpGNJfy845tI4nT/Gu309i0xae2DU8rGReGq7DBhEvkBLmtRz/YrUp3Dq98ZxlPUao82bLKexYIQiJ+w6boLol5cgpiH4+S4TlVvmwFjWoCfxAh3OC9xoIZnnoRsmKDP4a/bj6gQEOzeGjMjS8+PtLu6VVczIdMkt2btnSTkLEJL/XkVN/epJy/mF2tzmlU5KTC5a208h5DkwEZavOmEBK6lvo2O7zfCezJ7jTucmvaDlPU+aLuJ9nKOQVo+FpzALRgTG4ObBU2+qp3LDsJIXOKmZfqT9SzImvq7zx9D0Yj0EzQ751KNO2UIeANEI13sPJczVWsinCUIt3UnwmddyoC9oukpXJtSVCiL7nnaTRGvhltCewMKIJ2YqidFrWREAHaBEF48FiczOE0M7C/yAt5Qw53e2Fzbi5Ik48lj3cx3qRlLjucty1INh25VCt0fACDM8Tsk3ntNYiqsaIq5CXAY9bIR05EEBzbYhASzuSUdxlhH8fYbOr7iPhJVaXUORuTqg9GHLfRm7IwqFnioDBCZH35wrI7/Up6ePMoiQ64pCCZ5OfKVy+mMpU9vTpGjnf3sMjG08RuKqX1/swDmL3RGSMWJkHbhiI/oE/O/IDM5/1G09uh3CqBCz/zPrXobc/ESlrwRRFSU/fEbV0JiH+cUARfr0KQnRhs+cmy3j3Qv1pDxCvSeg/d8nlY4W5q+HvrpEtFzLWVatdLF7QWT1usem+6aFi0yPrLlEXlrHPXjqdqtZtUHZCgC35MDVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(136003)(396003)(39860400002)(66476007)(316002)(66946007)(4326008)(8676002)(66556008)(6916009)(478600001)(6506007)(966005)(8936002)(6486002)(31686004)(5660300002)(2906002)(53546011)(38100700002)(36756003)(86362001)(31696002)(6512007)(83380400001)(186003)(26005)(2616005)(41300700001)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVp0Njg5S2toNDFpcFpDUjVVUXpjc0gwWk9jV1F5TzkybC9WNXZqUHJiN2ha?= =?utf-8?B?SDhJT05Ld0tORURGdjlsOE1YQnQ3bGFzRHhHc2tTbUt4YTVmRUt3RXp6NHB0?= =?utf-8?B?TjBKeC9VdEc1QlFlbmZ6UkJ1TFppbFlLd0V6WFdjRDhseVBjT1lTMTc3V0kv?= =?utf-8?B?THVsWDA5VnhxeFBRUWNZV3FVbGlPR1ZmbW9UM0pvSEV4cGx6M2ZaQTFtZDZn?= =?utf-8?B?K0s3SG5BcDl0WjQvKzRLa1ZyYkt2WURnRFEvUG1GOExXakIwWVlMZkcwWk1Z?= =?utf-8?B?c25aTVJpSFR3MDRWNDMvZ1BqMTg4RmZDSVFQRmtIcGdwb2NYOHNqYlQrVDVT?= =?utf-8?B?ZWkyNU1raDBJMkR0R2p3M3RKQzV0UEJlSG1lNTNFK0hUOFU3dTRVOVFQcUdV?= =?utf-8?B?bCtBaEkzb0Rxa3l6QndUTVBPckRSdWtxSVZRL1dhMEZGQ1I0WVdOU3cvcGp4?= =?utf-8?B?c3VBSXA4VFNXcjYvT1dVN3hJVlI1cENudWlTalhiUWt6a3JBWlV3TzRmNldZ?= =?utf-8?B?WFlQRFIrZERVeWVoamd4WUZocWdrWXBKLytNd2Q3WHNnNmxwU1hvc3J6U01Y?= =?utf-8?B?cFYyaDlMb1R1bXRoTFF3RWI5ZmRhUTJnb2ZIMlp3aExodDJVNlM0cFlvR0xj?= =?utf-8?B?bGhsdisva2Y4ak90VHkrMmlXazVFQmtMU0VROUpNSlFveTMwb0I3VlI3RDdq?= =?utf-8?B?bzFBZ2VoVWpOaHZRM1ArNmxKVFplNkpwcTBYVnJ4bXo1YkdCeDlKekY1TVlv?= =?utf-8?B?Ym1oNDR3ZFFFL21QU1FnVHJGakNXTDRkeVNiNVNNL2tOVGtuQTFVQ056R25D?= =?utf-8?B?a2ZvY2ZzT1RmU0xlb1FVTkFmbzZqRzB3STZVdFRORXZrOXFzeGVWZjhqa2d1?= =?utf-8?B?T09ZNGlMb2cvTVpTYVlRQTRFQThwczIzbzYvSHNhWnp6S1lOUGFMdTVKWUdB?= =?utf-8?B?aTV1NUtHWk0waDNPVzZsSnhtbWoySERKV1VIRlIxakU4UG44RFhPMzNHSGxz?= =?utf-8?B?SFMvNUV5cy9IY3NHZFp1RUFsQmFVRnBGRHFSeU0xaXVKSEswRFBRc1dqZHRO?= =?utf-8?B?Y3hudGZHMG52b3JjTS9MditlcEt6Q29kbU5Mamg1UnVMZFBsQmNSUXh1OWZw?= =?utf-8?B?Zm1DQzNtVVJHU0VzNHJMOW4wdXU2elhZbDJlTFZ1eEZFcWRwdnhCend3bG5X?= =?utf-8?B?SDVROVlWc0UzSUc4Zkk0VEZRU1JLUk1ETzN2OUlKakorVDFvZ29CUExqR0Y0?= =?utf-8?B?L2N3VGlhVHN3MnJNeU9GcGl3cyt0aUozaTd4YVNzUTY0L3R1VFFib1hTVldF?= =?utf-8?B?UWdNMldNellkNUd1NisvUVZKUkFiaUlyS3BiUWdTTmFyOGdmdzdVeHhQWFJm?= =?utf-8?B?TmJ1dldzbFJVRGpPYndvLzNqK05RRERMTFlwUElYa2VuZ3FMeit0TnlXTmJj?= =?utf-8?B?NWcrV3ZKUFI4ejVMYjNWUmJ2dE51cnQyTzZ6VS9PVGc3N1NpejlOWURKOTNx?= =?utf-8?B?ZGtma3FrVjVVK2txRFlBVnRYRUwrd2xZYUVBMWQyNnlCT0psZVV3QmZleFFv?= =?utf-8?B?Ums4TUE0S2dJd1QyWjBhZDNEQnJLOW1nUVMrdGZiemZtYTZpbUpIZUxJNm1V?= =?utf-8?B?YTgxQUdWVDhKeTFhQ3lsd2VEc2YwcHBtakc5Z1ZDM3BSZDN5a1ZnMXpicE42?= =?utf-8?B?SFBPNkIzdmF1czFuejROaW9uaEtkckkzY1ZNdmw2UDhnMTZiZmhTbHBmME4y?= =?utf-8?B?aFVvcXB5ZVg5U2hBSkNEU2NMWHRnL3doVElFdXByYVQ0Y0QrNkNsRFRRc1lw?= =?utf-8?B?bGR3Qjg3RStvSTdvUG9EV1N4S28wL1pMQ3pvZ1NOWitRdDB4RGwzVWVUY0pv?= =?utf-8?B?QXVyZWlPOFFwQm1lYWdMSHM5c014T2YwZENGc0FFOWtrVFBwaDVuMzN2a0l0?= =?utf-8?B?ajZPelgvQ1dHaldERnljeHQ4aXlGdThxb1l1Z01rQzIyNFN4OW1kL0pIYnRm?= =?utf-8?B?MlpuckhleXk0bmx4NU4vT3R1NnZRR3FiT2N1bU1mMGZEdVNJYmMyR205K25Y?= =?utf-8?B?d3h6VGxsaDJUblV3aTRZNFdqRU0vbDE4UllaWEV1QzZmeVpEOXVIQjNmV3Vo?= =?utf-8?Q?MPRkONhgWkHvWIXSQnhyWrWNl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7afbf29-bf87-4b96-2a4b-08da5da8683b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 10:31:51.2505 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JLkpZ9QHqr9KFei8VZ2zUTY9eZrCqd6FmUJP9bj/RL5Pzcs86RVZL2Un/9jTJ6zm3i6VnZdFrmCdV+ilj1eOzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5443 (Note: please don't cross-post; removing xen-users@.) On 04.07.2022 08:37, G.R. wrote: > Update some findings with extra triage effort... > Detailed log could be found in the attachments. > 1. Confirm stock Debian 11.2 kernel (5.10) shares the same syndrome.. > 2. With loglvl=all, it reveals why the mapping failure happens, looks > like it comes from some duplicated mapping.. > (XEN) memory_map:add: dom1 gfn=f3074 mfn=a2610 nr=2 > (XEN) memory_map:add: dom1 gfn=f3077 mfn=a2615 nr=1 > (XEN) memory_map:add: dom1 gfn=f3078 mfn=a2616 nr=1 <===========Here > (XEN) ioport_map:add: dom1 gport=c140 mport=4060 nr=20 > (XEN) ioport_map:add: dom1 gport=c170 mport=4090 nr=8 > (XEN) ioport_map:add: dom1 gport=c178 mport=4080 nr=4 > (XEN) memory_map:add: dom1 gfn=f3070 mfn=a2500 nr=2 > (XEN) memory_map:add: dom1 gfn=f3073 mfn=a2503 nr=1 > (XEN) memory_map:add: dom1 gfn=f3078 mfn=a2504 nr=1 <===========Here > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > (XEN) domain_crash called from p2m.c:1301 > (XEN) Domain 1 reported crashed by domain 0 on cpu#2: > (XEN) memory_map:fail: dom1 gfn=f3078 mfn=a2504 nr=1 ret:-1 > (XEN) memory_map:remove: dom1 gfn=f3078 mfn=a2504 nr=1 Neither here nor in your initial mail I've spotted information on the BARs the device has. The above makes me wonder whether it has two BARs each covering less than 4k and both sharing a page. Or wait - the hvmloader output actually has some useful data: (d1) pci dev 05:0 bar 24 size 000000800: 0f3077000 ... (d1) pci dev 05:0 bar 14 size 000000100: 0f3077800 The sharing is apparently introduced in hvmloader, but might not have been deemed a problem because it's generally advisable (for security reasons) or even necessary (for functionality) for BARs of devices to be passed through to all live in distinct (4k) pages. However - while hvmloader has no knowledge of host addresses occupied by the BARs (so it has no indication to place them in separate pages), it should still not put any two BARs in the same (guest) page. Even then, as the P2M mapping occurs at 4k granularity, it would further need to know the host's offset-into- page value to correctly calculate the guest address. IOW this will in addition require the host to put all BARs at the beginning of 4k pages (which may well be the case already for you). (d1) pci dev 06:0 bar 20 size 000000100: 0f3077904 would cause the same issue (afaict), unless the host BAR shared a page with the earlier BAR of 05:0. > 3. Recompiled kernel with DEBUG enabled for xen_pciback driver and > play with xl pci-assignable-XXX with it > 3.1 It's confirmed that the DPC / AER error log happens only when > xen_pciback attempts to seize && release the device > 3.1.1 It only happens on each of the first add / remove operations. > 3.2 There is still a 'MSI-X preparation failed' message later-on, but > otherwise it appears to be successful to add / remove the device after > the 1st attempt. > 3.3 Not necessarily related, but the DPC / AER log looks similar to > this report [1] The only thing I can say here is that quite likely pciback needs work to become up-to-date again with advanced feature handling elsewhere in the kernel. Jan > [1]: https://patchwork.kernel.org/project/linux-pci/patch/20220127025418.1989642-1-kai.heng.feng@canonical.com/#24713767 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 10:34:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 10:34:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360137.589516 (Exim 4.92) (envelope-from ) id 1o8JPg-0003gH-M7; Mon, 04 Jul 2022 10:34:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360137.589516; Mon, 04 Jul 2022 10:34:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8JPg-0003gA-JJ; Mon, 04 Jul 2022 10:34:44 +0000 Received: by outflank-mailman (input) for mailman id 360137; Mon, 04 Jul 2022 10:34:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8JPf-0003g2-Ca for xen-devel@lists.xen.org; Mon, 04 Jul 2022 10:34:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9f08f56-fb84-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 12:34:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5443.eurprd04.prod.outlook.com (2603:10a6:208:119::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 10:34:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 10:34:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9f08f56-fb84-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvwBLxBGFGheFdX8vrn6aUCXNhg42hjQx9Bm4XqOlxWrGC8KfbHtSvuDbjWlnoMlMUENMKXq8xVW+FQk0HJLxwpa7IMSipSrP9K/M7QR/RB8Kwg1lQx7jQI/BIU+Aj5+rLjZCFH4T57eP2wcci0KbedlQTUVBzQUK/AaH8vfpBEdWJVaLtWSc/oynr8+hXWzl2jiAxQrGTqGuI7dC35yPJ/5PUA7JLgAulLahdmmdsKFnkUwq/Aho14DmMPA+P7U49/xXWOGPKH9VTe8qoYArlx5fSBCIcfur97tAcTVNdct+DgqrzrlpHL36MInzNTaZYbHHLMr/a9v1q6fOOkOjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vmB8PHIf/cQhH8I0LGZmoGJNqgooPT4bDLvyfiXXoB4=; b=BLvQq5m+O/q/ABPntS0x/msnpjjranBMN/MxLwFgYOt8SnnONiApFPaEApogSBh1qs+3VloE7ojKJ3cv8uQ8AXQJSKSm+xCUdlUWT6OJvY+Wnf4XES3qhx062WkxXTkrIRFJh0xEAd3im9E/tDmiu8k2D5jXWiL2+ehZrJy9da5atstTb/5Z/ew6wmemdTVySQdx3jpx5iVnLNSW+mKNmutd6q0arFJuFzdYUaZf1492dLmEGkJ5cqHrGUOt0l8IZbpClAnfnhg2W9JJloSAHXBcYdnAY3rFyl4zAUKG8gvc2TPBSo5+ent1cEGqVaZ4B9e9JaeV3w+ZDK7DRXBwXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vmB8PHIf/cQhH8I0LGZmoGJNqgooPT4bDLvyfiXXoB4=; b=yPCTXVjnVlJjZnxr93ZBSkNM5LUrtnZBY2uqyUz6Ckf+C3kh2z1cIala9RMuVfn36DBQFxwTc05sq79sXhC8REPLnsqAYFkpJoDV9RVN3/epQDcrEz29+H2yNExOmIncwslPteFdDuq2eVP7i6oy2h3X1ouqBVtffFv7HGPujv87xTD+8btXfxZxfcu93ajvna5a3ywU1pR7LBfMWYiUsr6tKszfhrInuf8gJtHZnbkmf1HfulO9MmriAJjvMkwnezS2Kpo3IZyK/Xc9z/4hcI2fF8HJD8hqjxbidnDtG/R6EQpmJqfL2g9sU/gIXLptm9xYCqsqvKxER+cmsmr7og== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 4 Jul 2022 12:34:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel , "G.R." References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P250CA0005.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe6981c0-bf3e-42eb-18e7-08da5da8cd6c X-MS-TrafficTypeDiagnostic: AM0PR04MB5443:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EXpGeksL91FCriRSo6MKoD2+KndYXy04cr4s6dcGY1V/d6wYrbn7i4nc0yCRk4LxfBMaQ86EDWyCYnVnnulKlLPgDGJwvxmIkD6hlkVTeCQ59Umckna317osVbrgbFUPG0Tu2Ax2g9UYztcm/p4nq6a+lZzlc/3U7itPs+mxoUM3v13VDMmhTs3TUqHy51fO3DKe5yZD1MdM0cPVu0NaDfV5OlXMv8/LhApq/YfjUKzhGphtxRSZfLjbVkOF2A7s/uCmUwnF4hA/euoqlShcXe5YZJktgSc3CDOK9Q0I0TVADgCHN/QbXY4wEUq3Rl2gXLgSZGvtZ4iXQi+mGEHHUW1Tn1KciQtaeiZIbaWeBksniVEqBFIvo/Tt15rEAOyojF2Z/k0hz6WSrKzxzZbSAMO4jpVajV11T7Xt77fi9kGdSUhN042uG4dnWNbNXZmIJmWmrH2mqkYahISRinlpkGYzjyNADKW7hpPvB5rAtk/+in8w/fREEMXjCDoo9j51KXafVJG3PKnN0YSjl9YLxT4niDtmrtRTyYkN3ybo3QFBLPTj+qhFP2HaW0fg8g1lLj1MG5Yjxw13BmyJXwnrcdiqdPw8U5SV39jfU26t7CHDl7+606sWhJYmjOS1+GepVUnyz0Yclif/E3pMgQbOadL/4EQHyNnucH2D71t0079A4XM1rKd3QHQeAV2fdgmChIFRoN2l4w5yC/0Zbljyv8xfGzYqADtklFoSotRZwvrxbl/0Oc1s4rYmvFehPhjh1w3EQMqgy74UdylUt8NkiCpPOugcmVI3TnGLHYaitxZQVOvo4OSD74cAQioBNiSQV6y3BwAXLfc56dfeUJlfKO0RIQVZwdcBoDKD3VP0p4Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(376002)(346002)(366004)(36756003)(86362001)(31696002)(53546011)(38100700002)(186003)(2616005)(41300700001)(26005)(6512007)(8936002)(6486002)(8676002)(66476007)(316002)(66946007)(4326008)(478600001)(6506007)(66556008)(6916009)(31686004)(4744005)(5660300002)(2906002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2hIZTRwaDJyRGhGZ1dYeU5XRk04MkI3Uk8zV2h4cW1jRGpnbnNTRFlsSVh3?= =?utf-8?B?K0JEYnhyNitFVUdwQnRUeGJtNUlnTFJSenl1eFNtYXk4MmVjMm5VVzk5UDlF?= =?utf-8?B?ZGpYeXNjZFEwSk9JWnJENDNwcjh0Mkd0ZzNid3RHcWJPeDdzRmc4aDhCdHov?= =?utf-8?B?aEZ6TUhBeHJRdFdsRnZwbjN2bGZGU2hWYjljVUV6VnFTRlMvUTJNTExuemRG?= =?utf-8?B?RG0vZHRnNi9MUEZNR3VGWXNEMXJlblpLSHQyOXNISW11amd6VEU1Tm5CUXQz?= =?utf-8?B?dzI1cW9oVkt6bVJxUExoRE5mTVRFQ2ZkNlFrekRuMGVnTlhEUENPM2JZOTZh?= =?utf-8?B?SWYvRGlOZmNsR3R6c0VMOWF2MlpLb25HbUxDNVlCLzBMRzQxUjR5dmpMWWcy?= =?utf-8?B?QUJrTVpsdjltSmhXNnJrdEJKWFhnWnMxMUlMNmVIM0VvTGdHSlJDVXMxNS9L?= =?utf-8?B?dnFvMkJwM0Z4Q2x6R05UemhrSzV1TG5OVC9ock1pKzFubEdaNlo3VGJJMEJ4?= =?utf-8?B?SVVVbjR5WjZaOVVPY3pBVC95MDJNeGEyQjhWSmRHMEU4MlMvSWpJOUxNV01D?= =?utf-8?B?eWp5aEpRQUFLbE9KbG1rUUxycFVJelVxTk9vZ1dMT2s5QUNLdCs0bVZGTkNU?= =?utf-8?B?cm4yY1ZzNUFVU056bnhIYWdBODk3ZkxaaTRGY0RIMFovaGY5ck4yZWQzWlB3?= =?utf-8?B?NjQzenJLQkZnT3NLb1NtWmlRNHJCOUlDZkZRTUQweUd2bnUwTGZmb0NQZnNQ?= =?utf-8?B?ejFBdWxGUElQK0d0UGh3OWNOSXkzRGtIYXZRN0pYQUhEMzhzbGxscUo1NDV3?= =?utf-8?B?UG5KUHBNTU5VV0oyWmN6MFVVRXR1dEh1QUhUcUs0dkJCTUpEM0pOa1E5RDEv?= =?utf-8?B?L1FBaE1wN3Y4QW56cnVCM1ZLRTVwQ2dmbG9mWXJEdGVWNnB5bFFzSmNscFFs?= =?utf-8?B?clYxazE2ZWp0WmpTa3JjemxKWjlvc3RqTG5Ia1hhWFpGS3RrNVlpK0swRzhv?= =?utf-8?B?UWxDdlVneHRnTmNYSXVwNWZJcEh0WlZVVWU0M1FUSDkvZUNua2FFNWo1dUpP?= =?utf-8?B?UE4waE1OS1JoYW92bE45a1JBV0VUVCtvdWdXZ2o4RnIwU0liaXVJL1EyUnVU?= =?utf-8?B?Q0hwRVFqMmFBemc0aGxhWnNsUW5HallFYjBMOTJvZXJyaVlHSlhOLzNQSkIz?= =?utf-8?B?RDVVQTIxSDhHL2VsdU1wWnJXd0VzenFiU003UXlZUGhJZkVDQTFEbmcxNkpj?= =?utf-8?B?Mlo1aU9WNHNXejdMNGhWdUVXTTBNUElKeXBDUDFxMkZobngvck5oOGtvY3ZO?= =?utf-8?B?YVZ2YXpjU0ZLYjRoMitsUUlsemtVMENieVo5TFB5RnhFTnlYQ2g0bnBOY1NP?= =?utf-8?B?K2dQMHRSRUEzMEdBeFpYc0JTSFdkMGFSOFdtNGZVUmpERFlzbDZKSE9Oa1l6?= =?utf-8?B?SThLcXNzTk1seVExL0FOSC9odXgwcEwwN1F1bzBRdjg0bVdTTGc0LytKN3Nu?= =?utf-8?B?WVl0SnNJV2NhelU4WmorWGxIalpUNFhqYU41b0wxN3liZng2WXplMTRzN3Z1?= =?utf-8?B?ZmgwQW1aTDRzNGxERzRacUdjeC9hQTRVZ1FTeVlwVE9JdWhCaWtnS0F2ZzVn?= =?utf-8?B?ZmhaRW5DNEt4UEF1SndHK2ppQS9PZWJSdm01RVBBZlhWaEVZVHdaY21NZnpy?= =?utf-8?B?ZmFhbzBNdDIwNGJzVmUzLzVPY1BndmNQVXhpdjdoQ2VLQVF6WDQwMENjL2gx?= =?utf-8?B?RU1JU1pIWFc1cmxUVVpaVE9LNGtZWkcvTW8wcHFna1lRQ2draTQrZ2trUmtE?= =?utf-8?B?R05xaGhDN2JZNE1Oc1Y1anlsa054MUVKRGV0NWJsSy9abklnRGp0YWR3OGVl?= =?utf-8?B?WEdyWVJrN3gwVmlvOHhZSzY1S1U3dEphbGRlcHFJeGdpSzRnckptUXBMN0lk?= =?utf-8?B?b0J1blltZmZJTWlUcytlNE5rNVFUWkozb3hHczJnWFNIWjFIYy9ZZlp6dmlt?= =?utf-8?B?SHcvZmFCY0RTTHRBQVRtaFh5UXhDb3lXaTYyaHc2MStJMFVEWW1oS3Y0aVJY?= =?utf-8?B?QWE1WDZ1UVd1V3dRNU8xS3lFeVc3cXkyZWZteVRjaURKNW9SZXJ4UFY3ZUt5?= =?utf-8?Q?srfTLGba7+KzLYm/aitf08rjv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe6981c0-bf3e-42eb-18e7-08da5da8cd6c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 10:34:41.0055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +8BWFcyvhMbpdbuilAZZQFQd9WS+D72kWSZKViETSyojmzZz1EDLWrbU0sQIsMZcEIoyGBnR/kiQ4baxtFqgNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5443 On 04.07.2022 11:50, Roger Pau Monné wrote: > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: >> Hi everybody, >> >> I run into problems passing through a SN570 NVME SSD to a HVM guest. >> So far I have no idea if the problem is with this specific SSD or with >> the CPU + motherboard combination or the SW stack. >> Looking for some suggestions on troubleshooting. >> >> List of build info: >> CPU+motherboard: E-2146G + Gigabyte C246N-WU2 >> XEN version: 4.14.3 > > Are you using a debug build of Xen? (if not it would be helpful to do > so). > >> Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) >> The SN570 SSD sits here in the PCI tree: >> +-1d.0-[05]----00.0 Sandisk Corp Device 501a As per this I understand that ... > I'm slightly confused by the fact that the DPC / AER errors seem to be > from a device that's different from what you attempt to passthrough? > (0000:00:1d.0 vs 0000:05:00.0) ... 00:1d.0 is the upstream bridge for 05:00.0. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 11:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 11:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360148.589533 (Exim 4.92) (envelope-from ) id 1o8K2z-0008Gz-4l; Mon, 04 Jul 2022 11:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360148.589533; Mon, 04 Jul 2022 11:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8K2z-0008Gs-0v; Mon, 04 Jul 2022 11:15:21 +0000 Received: by outflank-mailman (input) for mailman id 360148; Mon, 04 Jul 2022 11:15:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8K2y-0008Gi-5w; Mon, 04 Jul 2022 11:15:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8K2y-0005yG-3M; Mon, 04 Jul 2022 11:15:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8K2x-0000lf-IL; Mon, 04 Jul 2022 11:15:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8K2x-0001j2-Hr; Mon, 04 Jul 2022 11:15:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ty0m3l/smVUMpzG0kveKUR0Lv7EnO0yZEduTd9LyZBI=; b=vL2KJB+9LKxGD9uhhZCIUjwuLL iUWh/0sbdorI7b8IKJ4L25lQBa9ilznL2k4Rs8jXdMqE3Delddu1rub+t03CaIovNQTEujXk//c2P nHxJpuzbfLMWJHuIEYspA6FGLg/Looj/KIkndTSfbtXyLwDyYFtde/24G95M7ttnk2kQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171477: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemut-debianhvm-i386-xsm:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-i386-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug xen-unstable:test-amd64-i386-xl-xsm:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 X-Osstest-Versions-That: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 From: osstest service owner Date: Mon, 04 Jul 2022 11:15:19 +0000 flight 171477 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171477/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemut-debianhvm-i386-xsm 18 guest-localmigrate/x10 fail in 171463 pass in 171477 test-amd64-i386-xl-qemuu-debianhvm-i386-xsm 7 xen-install fail pass in 171463 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 20 guest-start/debianhvm.repeat fail pass in 171463 Tests which did not succeed, but are not blocking: test-amd64-i386-xl-xsm 7 xen-install fail like 171463 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171463 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171463 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171463 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171463 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171463 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171463 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171463 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171463 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171463 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171463 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171463 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171463 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 baseline version: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 Last test of basis 171477 2022-07-04 01:53:25 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 11:35:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 11:35:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360157.589544 (Exim 4.92) (envelope-from ) id 1o8KM5-0002NT-P0; Mon, 04 Jul 2022 11:35:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360157.589544; Mon, 04 Jul 2022 11:35:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8KM5-0002NM-Lk; Mon, 04 Jul 2022 11:35:05 +0000 Received: by outflank-mailman (input) for mailman id 360157; Mon, 04 Jul 2022 11:35:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8KM3-0002NB-Qm for xen-devel@lists.xen.org; Mon, 04 Jul 2022 11:35:04 +0000 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 566d8cc3-fb8d-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 13:35:00 +0200 (CEST) Received: by mail-ej1-f48.google.com with SMTP id ay16so16233307ejb.6; Mon, 04 Jul 2022 04:35:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 566d8cc3-fb8d-11ec-a8e4-439420d8e422 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjd3I9rZHZZg5lsMi25u+DncsmWC47+0qhCb9Fdk8v8=; b=lcq0l0QBVlOGzRsjK0m9mJO/r52iYPpufVac/3jD7d+XAdo+Jlk2UMLAGfHv8b44k9 0EHEegl8Ed34yF06E7XVVgD520iDJ0dWLdmWAvcn5r9sy2o6NBGTYryvnKiaVMruK+Ca 46CaXTLol7+QAdB+fOV3/uPkcWeqZOPGXZctY/xvR8kR3wBT0XycnBntNdxJ4bDoRgKO 5ibEHh9OEJ3v1ROrozAPRddQ6+Ow4IXcia5y9SmSdvTmFBTta/aHVDwHmD6/3LdJmvSM 6V8Nvm84g3SdJHXWErNpOFcBkMXdV1OJGEqpF1rugNQKwLGlIljIryueLaiCmRRkLQsY gmrw== X-Gm-Message-State: AJIora/9f5DStDs8fPqzpS6/V0qkhJEdBjr6WYVhmX3fQC3cVm7XLeFB zJHMqiTXNE1TZLYvgxcYzxkYjipoCaYeKlpm7SFzeD28MNI= X-Google-Smtp-Source: AGRyM1vOgUDboDJ13AF9GpgNqtaod12KBxSU3NWcHxRC/KTZfRrlZxxz39/fuARA4HiwojWHt3fIxHZoFG1cRC7Qzlg= X-Received: by 2002:a17:906:d550:b0:726:2b34:2fd6 with SMTP id cr16-20020a170906d55000b007262b342fd6mr27769480ejc.311.1656934499682; Mon, 04 Jul 2022 04:34:59 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 19:34:47 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-users , xen-devel Content-Type: multipart/mixed; boundary="000000000000452a6c05e2f920cb" --000000000000452a6c05e2f920cb Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monn=C3=A9 = wrote: > > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > > Hi everybody, > > > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > > So far I have no idea if the problem is with this specific SSD or with > > the CPU + motherboard combination or the SW stack. > > Looking for some suggestions on troubleshooting. > > > > List of build info: > > CPU+motherboard: E-2146G + Gigabyte C246N-WU2 > > XEN version: 4.14.3 > > Are you using a debug build of Xen? (if not it would be helpful to do > so). It's a release version at this moment. I can switch to a debug version later when I get my hands free. BTW, I got a DEBUG build of the xen_pciback driver to see how it plays with 'xl pci-assignable-xxx' commands. You can find this in my 2nd email in the chain. > > > Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) > > The SN570 SSD sits here in the PCI tree: > > +-1d.0-[05]----00.0 Sandisk Corp Device 501a > > Could be helpful to post the output with -vvv so we can see the > capabilities of the device. Sure, please find the -vvv output from the attachment. This one is just to indicate the connection in the PCI tree. I.e. 05:00.0 is attached under 00:1d.0. > > > Syndromes observed: > > With ASPM enabled, pciback has problem seizing the device. > > > > Jul 2 00:36:54 gaia kernel: [ 1.648270] pciback 0000:05:00.0: > > xen_pciback: seizing device > > ... > > Jul 2 00:36:54 gaia kernel: [ 1.768646] pcieport 0000:00:1d.0: > > AER: enabled with IRQ 150 > > Jul 2 00:36:54 gaia kernel: [ 1.768716] pcieport 0000:00:1d.0: > > DPC: enabled with IRQ 150 > > Jul 2 00:36:54 gaia kernel: [ 1.768717] pcieport 0000:00:1d.0: > > DPC: error containment capabilities: Int Msg #0, RPExt+ PoisonedTLP+ > > SwTrigger+ RP PIO Log 4, DL_ActiveErr+ > > Is there a device reset involved here? It's possible the device > doesn't reset properly and hence the Uncorrectable Error Status > Register ends up with inconsistent bits set. xen_pciback appears to force a FLR whenever it attempts to seize a capable device. As shown in pciback_dbg_xl-pci_assignable_XXX.log attached in my 2nd mail. [ 323.448115] xen_pciback: wants to seize 0000:05:00.0 [ 323.448136] pciback 0000:05:00.0: xen_pciback: probing... [ 323.448137] pciback 0000:05:00.0: xen_pciback: seizing device [ 323.448162] pciback 0000:05:00.0: xen_pciback: pcistub_device_alloc [ 323.448162] pciback 0000:05:00.0: xen_pciback: initializing... [ 323.448163] pciback 0000:05:00.0: xen_pciback: initializing config [ 323.448344] pciback 0000:05:00.0: xen_pciback: enabling device [ 323.448425] xen: registering gsi 16 triggering 0 polarity 1 [ 323.448428] Already setup the GSI :16 [ 323.448497] pciback 0000:05:00.0: xen_pciback: save state of device [ 323.448642] pciback 0000:05:00.0: xen_pciback: resetting (FLR, D3, etc) the device [ 323.448707] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f11 source:0x0000 [ 323.448730] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error det= ected [ 323.448760] pcieport 0000:00:1d.0: PCIe Bus Error: severity=3DUncorrected (Non-Fatal), type=3DTransaction Layer, (Receiver ID) [ 323.448786] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=3D00200000/00010000 [ 323.448813] pcieport 0000:00:1d.0: [21] ACSViol (First= ) [ 324.690979] pciback 0000:05:00.0: not ready 1023ms after FLR; waiting <=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D HERE [ 325.730706] pciback 0000:05:00.0: not ready 2047ms after FLR; waiting [ 327.997638] pciback 0000:05:00.0: not ready 4095ms after FLR; waiting [ 332.264251] pciback 0000:05:00.0: not ready 8191ms after FLR; waiting [ 340.584320] pciback 0000:05:00.0: not ready 16383ms after FLR; waiting [ 357.010896] pciback 0000:05:00.0: not ready 32767ms after FLR; waiting [ 391.143951] pciback 0000:05:00.0: not ready 65535ms after FLR; giving up [ 392.249252] pciback 0000:05:00.0: xen_pciback: reset device [ 392.249392] pciback 0000:05:00.0: xen_pciback: xen_pcibk_error_detected(bus:5,devfn:0) [ 392.249393] pciback 0000:05:00.0: xen_pciback: device is not found/assig= ned [ 392.397074] pciback 0000:05:00.0: xen_pciback: xen_pcibk_error_resume(bus:5,devfn:0) [ 392.397080] pciback 0000:05:00.0: xen_pciback: device is not found/assig= ned [ 392.397284] pcieport 0000:00:1d.0: AER: device recovery successful Note, I only see this in FLR action the 1st attempt. And my SATA controller which doesn't support FLR appears to pass through just fine... > > > ... > > Jul 2 00:36:54 gaia kernel: [ 1.770039] xen: registering gsi 16 > > triggering 0 polarity 1 > > Jul 2 00:36:54 gaia kernel: [ 1.770041] Already setup the GSI :16 > > Jul 2 00:36:54 gaia kernel: [ 1.770314] pcieport 0000:00:1d.0: > > DPC: containment event, status:0x1f11 source:0x0000 > > Jul 2 00:36:54 gaia kernel: [ 1.770315] pcieport 0000:00:1d.0: > > DPC: unmasked uncorrectable error detected > > Jul 2 00:36:54 gaia kernel: [ 1.770320] pcieport 0000:00:1d.0: > > PCIe Bus Error: severity=3DUncorrected (Non-Fatal), type=3DTransaction > > Layer, (Receiver ID) > > Jul 2 00:36:54 gaia kernel: [ 1.770371] pcieport 0000:00:1d.0: > > device [8086:a330] error status/mask=3D00200000/00010000 > > Jul 2 00:36:54 gaia kernel: [ 1.770413] pcieport 0000:00:1d.0: > > [21] ACSViol (First) > > Jul 2 00:36:54 gaia kernel: [ 1.770466] pciback 0000:05:00.0: > > xen_pciback: device is not found/assigned > > Jul 2 00:36:54 gaia kernel: [ 1.920195] pciback 0000:05:00.0: > > xen_pciback: device is not found/assigned > > Jul 2 00:36:54 gaia kernel: [ 1.920260] pcieport 0000:00:1d.0: > > AER: device recovery successful > > Jul 2 00:36:54 gaia kernel: [ 1.920263] pcieport 0000:00:1d.0: > > DPC: containment event, status:0x1f01 source:0x0000 > > Jul 2 00:36:54 gaia kernel: [ 1.920264] pcieport 0000:00:1d.0: > > DPC: unmasked uncorrectable error detected > > Jul 2 00:36:54 gaia kernel: [ 1.920267] pciback 0000:05:00.0: > > xen_pciback: device is not found/assigned > > That's from a different device (05:00.0). 00:1d.0 is the bridge port that 05:00.0 attaches to. > > > > After the 'xl pci-assignable-list' appears to be self-consistent, > > creating VM with the SSD assigned still leads to a guest crash: > > From qemu log: > > [00:06.0] xen_pt_region_update: Error: create new mem mapping failed! (= err: 1) > > qemu-system-i386: terminating on signal 1 from pid 1192 (xl) > > > > From the 'xl dmesg' output: > > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > > Seems like QEMU is attempting to remap a p2m_mmio_direct region. > > Can you paste the full output of `xl dmesg`? (as that will contain the > memory map). Attached. > > Would also be helpful if you could get the RMRR regions from that > box. Booting with `iommu=3Dverbose` on the Xen command line should print > those. Coming in my next reply... --000000000000452a6c05e2f920cb Content-Type: text/x-log; charset="US-ASCII"; name="lspcivvv_cutdown.log" Content-Disposition: attachment; filename="lspcivvv_cutdown.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56nx92m0 MDA6MWQuMCBQQ0kgYnJpZGdlOiBJbnRlbCBDb3Jwb3JhdGlvbiBDYW5ub24gTGFrZSBQQ0ggUENJ IEV4cHJlc3MgUm9vdCBQb3J0ICM5IChyZXYgZjApIChwcm9nLWlmIDAwIFtOb3JtYWwgZGVjb2Rl XSkKCUNvbnRyb2w6IEkvTysgTWVtKyBCdXNNYXN0ZXIrIFNwZWNDeWNsZS0gTWVtV0lOVi0gVkdB U25vb3AtIFBhckVyci0gU3RlcHBpbmctIFNFUlItIEZhc3RCMkItIERpc0lOVHgrCglTdGF0dXM6 IENhcCsgNjZNSHotIFVERi0gRmFzdEIyQi0gUGFyRXJyLSBERVZTRUw9ZmFzdCA+VEFib3J0LSA8 VEFib3J0LSA8TUFib3J0LSA+U0VSUi0gPFBFUlItIElOVHgtCglMYXRlbmN5OiAwLCBDYWNoZSBM aW5lIFNpemU6IDY0IGJ5dGVzCglJbnRlcnJ1cHQ6IHBpbiBBIHJvdXRlZCB0byBJUlEgMTI2CglJ T01NVSBncm91cDogMTAKCUJ1czogcHJpbWFyeT0wMCwgc2Vjb25kYXJ5PTA1LCBzdWJvcmRpbmF0 ZT0wNSwgc2VjLWxhdGVuY3k9MAoJSS9PIGJlaGluZCBicmlkZ2U6IDAwMDBmMDAwLTAwMDAwZmZm IFtkaXNhYmxlZF0KCU1lbW9yeSBiZWhpbmQgYnJpZGdlOiBhMjYwMDAwMC1hMjZmZmZmZiBbc2l6 ZT0xTV0KCVByZWZldGNoYWJsZSBtZW1vcnkgYmVoaW5kIGJyaWRnZTogMDAwMDAwMDBmZmYwMDAw MC0wMDAwMDAwMDAwMGZmZmZmIFtkaXNhYmxlZF0KCVNlY29uZGFyeSBzdGF0dXM6IDY2TUh6LSBG YXN0QjJCLSBQYXJFcnItIERFVlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQtIDxNQWJvcnQrIDxT RVJSLSA8UEVSUi0KCUJyaWRnZUN0bDogUGFyaXR5LSBTRVJSKyBOb0lTQS0gVkdBLSBWR0ExNisg TUFib3J0LSA+UmVzZXQtIEZhc3RCMkItCgkJUHJpRGlzY1Rtci0gU2VjRGlzY1Rtci0gRGlzY1Rt clN0YXQtIERpc2NUbXJTRVJSRW4tCglDYXBhYmlsaXRpZXM6IFs0MF0gRXhwcmVzcyAodjIpIFJv b3QgUG9ydCAoU2xvdCspLCBNU0kgMDAKCQlEZXZDYXA6CU1heFBheWxvYWQgMjU2IGJ5dGVzLCBQ aGFudEZ1bmMgMAoJCQlFeHRUYWctIFJCRSsKCQlEZXZDdGw6CUNvcnJFcnIrIE5vbkZhdGFsRXJy KyBGYXRhbEVycisgVW5zdXBSZXErCgkJCVJseGRPcmQtIEV4dFRhZy0gUGhhbnRGdW5jLSBBdXhQ d3ItIE5vU25vb3AtCgkJCU1heFBheWxvYWQgMjU2IGJ5dGVzLCBNYXhSZWFkUmVxIDEyOCBieXRl cwoJCURldlN0YToJQ29yckVyci0gTm9uRmF0YWxFcnItIEZhdGFsRXJyLSBVbnN1cFJlcS0gQXV4 UHdyKyBUcmFuc1BlbmQtCgkJTG5rQ2FwOglQb3J0ICM5LCBTcGVlZCA4R1QvcywgV2lkdGggeDQs IEFTUE0gTDBzIEwxLCBFeGl0IExhdGVuY3kgTDBzIDwxdXMsIEwxIDwxNnVzCgkJCUNsb2NrUE0t IFN1cnByaXNlLSBMTEFjdFJlcCsgQndOb3QrIEFTUE1PcHRDb21wKwoJCUxua0N0bDoJQVNQTSBM MSBFbmFibGVkOyBSQ0IgNjQgYnl0ZXMsIERpc2FibGVkLSBDb21tQ2xrKwoJCQlFeHRTeW5jaC0g Q2xvY2tQTS0gQXV0V2lkRGlzLSBCV0ludC0gQXV0QldJbnQtCgkJTG5rU3RhOglTcGVlZCA4R1Qv cyAob2spLCBXaWR0aCB4NCAob2spCgkJCVRyRXJyLSBUcmFpbi0gU2xvdENsaysgRExBY3RpdmUr IEJXTWdtdCsgQUJXTWdtdC0KCQlTbHRDYXA6CUF0dG5CdG4tIFB3ckN0cmwtIE1STC0gQXR0bklu ZC0gUHdySW5kLSBIb3RQbHVnLSBTdXJwcmlzZS0KCQkJU2xvdCAjMTIsIFBvd2VyTGltaXQgMjUu MDAwVzsgSW50ZXJsb2NrLSBOb0NvbXBsKwoJCVNsdEN0bDoJRW5hYmxlOiBBdHRuQnRuLSBQd3JG bHQtIE1STC0gUHJlc0RldC0gQ21kQ3BsdC0gSFBJcnEtIExpbmtDaGctCgkJCUNvbnRyb2w6IEF0 dG5JbmQgVW5rbm93biwgUHdySW5kIFVua25vd24sIFBvd2VyLSBJbnRlcmxvY2stCgkJU2x0U3Rh OglTdGF0dXM6IEF0dG5CdG4tIFBvd2VyRmx0LSBNUkwtIENtZENwbHQtIFByZXNEZXQrIEludGVy bG9jay0KCQkJQ2hhbmdlZDogTVJMLSBQcmVzRGV0LSBMaW5rU3RhdGUrCgkJUm9vdENhcDogQ1JT VmlzaWJsZS0KCQlSb290Q3RsOiBFcnJDb3JyZWN0YWJsZS0gRXJyTm9uLUZhdGFsLSBFcnJGYXRh bC0gUE1FSW50RW5hLSBDUlNWaXNpYmxlLQoJCVJvb3RTdGE6IFBNRSBSZXFJRCAwMDAwLCBQTUVT dGF0dXMtIFBNRVBlbmRpbmctCgkJRGV2Q2FwMjogQ29tcGxldGlvbiBUaW1lb3V0OiBSYW5nZSBB QkMsIFRpbWVvdXREaXMrIE5ST1ByUHJQLSBMVFIrCgkJCSAxMEJpdFRhZ0NvbXAtIDEwQml0VGFn UmVxLSBPQkZGIE5vdCBTdXBwb3J0ZWQsIEV4dEZtdC0gRUVUTFBQcmVmaXgtCgkJCSBFbWVyZ2Vu Y3lQb3dlclJlZHVjdGlvbiBOb3QgU3VwcG9ydGVkLCBFbWVyZ2VuY3lQb3dlclJlZHVjdGlvbklu aXQtCgkJCSBGUlMtIExOIFN5c3RlbSBDTFMgTm90IFN1cHBvcnRlZCwgVFBIQ29tcC0gRXh0VFBI Q29tcC0gQVJJRndkKwoJCQkgQXRvbWljT3BzQ2FwOiBSb3V0aW5nLSAzMmJpdC0gNjRiaXQtIDEy OGJpdENBUy0KCQlEZXZDdGwyOiBDb21wbGV0aW9uIFRpbWVvdXQ6IDUwdXMgdG8gNTBtcywgVGlt ZW91dERpcy0gTFRSKyBPQkZGIERpc2FibGVkLCBBUklGd2QtCgkJCSBBdG9taWNPcHNDdGw6IFJl cUVuLSBFZ3Jlc3NCbGNrLQoJCUxua0NhcDI6IFN1cHBvcnRlZCBMaW5rIFNwZWVkczogMi41LThH VC9zLCBDcm9zc2xpbmstIFJldGltZXItIDJSZXRpbWVycy0gRFJTLQoJCUxua0N0bDI6IFRhcmdl dCBMaW5rIFNwZWVkOiA4R1QvcywgRW50ZXJDb21wbGlhbmNlLSBTcGVlZERpcy0KCQkJIFRyYW5z bWl0IE1hcmdpbjogTm9ybWFsIE9wZXJhdGluZyBSYW5nZSwgRW50ZXJNb2RpZmllZENvbXBsaWFu Y2UtIENvbXBsaWFuY2VTT1MtCgkJCSBDb21wbGlhbmNlIERlLWVtcGhhc2lzOiAtNmRCCgkJTG5r U3RhMjogQ3VycmVudCBEZS1lbXBoYXNpcyBMZXZlbDogLTMuNWRCLCBFcXVhbGl6YXRpb25Db21w bGV0ZSsgRXF1YWxpemF0aW9uUGhhc2UxKwoJCQkgRXF1YWxpemF0aW9uUGhhc2UyKyBFcXVhbGl6 YXRpb25QaGFzZTMrIExpbmtFcXVhbGl6YXRpb25SZXF1ZXN0LQoJCQkgUmV0aW1lci0gMlJldGlt ZXJzLSBDcm9zc2xpbmtSZXM6IHVuc3VwcG9ydGVkCglDYXBhYmlsaXRpZXM6IFs4MF0gTVNJOiBF bmFibGUrIENvdW50PTEvMSBNYXNrYWJsZS0gNjRiaXQtCgkJQWRkcmVzczogZmVlMDAyYjggIERh dGE6IDAwMDAKCUNhcGFiaWxpdGllczogWzkwXSBTdWJzeXN0ZW06IEdpZ2FieXRlIFRlY2hub2xv Z3kgQ28uLCBMdGQgQ2Fubm9uIExha2UgUENIIFBDSSBFeHByZXNzIFJvb3QgUG9ydAoJQ2FwYWJp bGl0aWVzOiBbYTBdIFBvd2VyIE1hbmFnZW1lbnQgdmVyc2lvbiAzCgkJRmxhZ3M6IFBNRUNsay0g RFNJLSBEMS0gRDItIEF1eEN1cnJlbnQ9MG1BIFBNRShEMCssRDEtLEQyLSxEM2hvdCssRDNjb2xk KykKCQlTdGF0dXM6IEQwIE5vU29mdFJzdC0gUE1FLUVuYWJsZS0gRFNlbD0wIERTY2FsZT0wIFBN RS0KCUNhcGFiaWxpdGllczogWzEwMCB2MV0gQWR2YW5jZWQgRXJyb3IgUmVwb3J0aW5nCgkJVUVT dGE6CURMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0gVW54Q21wbHQtIFJ4 T0YtIE1hbGZUTFAtIEVDUkMtIFVuc3VwUmVxLSBBQ1NWaW9sLQoJCVVFTXNrOglETFAtIFNERVMt IFRMUC0gRkNQLSBDbXBsdFRPLSBDbXBsdEFicnQtIFVueENtcGx0KyBSeE9GLSBNYWxmVExQLSBF Q1JDLSBVbnN1cFJlcS0gQUNTVmlvbC0KCQlVRVN2cnQ6CURMUCsgU0RFUy0gVExQLSBGQ1AtIENt cGx0VE8tIENtcGx0QWJydC0gVW54Q21wbHQtIFJ4T0YrIE1hbGZUTFArIEVDUkMtIFVuc3VwUmVx LSBBQ1NWaW9sLQoJCUNFU3RhOglSeEVyci0gQmFkVExQLSBCYWRETExQLSBSb2xsb3Zlci0gVGlt ZW91dC0gQWR2Tm9uRmF0YWxFcnItCgkJQ0VNc2s6CVJ4RXJyLSBCYWRUTFAtIEJhZERMTFAtIFJv bGxvdmVyLSBUaW1lb3V0LSBBZHZOb25GYXRhbEVycisKCQlBRVJDYXA6CUZpcnN0IEVycm9yIFBv aW50ZXI6IDAwLCBFQ1JDR2VuQ2FwLSBFQ1JDR2VuRW4tIEVDUkNDaGtDYXAtIEVDUkNDaGtFbi0K CQkJTXVsdEhkclJlY0NhcC0gTXVsdEhkclJlY0VuLSBUTFBQZnhQcmVzLSBIZHJMb2dDYXAtCgkJ SGVhZGVyTG9nOiAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAoJCVJvb3RDbWQ6 IENFUnB0RW4rIE5GRVJwdEVuKyBGRVJwdEVuKwoJCVJvb3RTdGE6IENFUmN2ZC0gTXVsdENFUmN2 ZC0gVUVSY3ZkLSBNdWx0VUVSY3ZkLQoJCQkgRmlyc3RGYXRhbC0gTm9uRmF0YWxNc2ctIEZhdGFs TXNnLSBJbnRNc2cgMAoJCUVycm9yU3JjOiBFUlJfQ09SOiAwMDAwIEVSUl9GQVRBTC9OT05GQVRB TDogMDAwMAoJQ2FwYWJpbGl0aWVzOiBbMTQwIHYxXSBBY2Nlc3MgQ29udHJvbCBTZXJ2aWNlcwoJ CUFDU0NhcDoJU3JjVmFsaWQrIFRyYW5zQmxrKyBSZXFSZWRpcisgQ21wbHRSZWRpcisgVXBzdHJl YW1Gd2QtIEVncmVzc0N0cmwtIERpcmVjdFRyYW5zLQoJCUFDU0N0bDoJU3JjVmFsaWQrIFRyYW5z QmxrLSBSZXFSZWRpcisgQ21wbHRSZWRpcisgVXBzdHJlYW1Gd2QtIEVncmVzc0N0cmwtIERpcmVj dFRyYW5zLQoJQ2FwYWJpbGl0aWVzOiBbMTUwIHYxXSBQcmVjaXNpb24gVGltZSBNZWFzdXJlbWVu dAoJCVBUTUNhcDogUmVxdWVzdGVyOi0gUmVzcG9uZGVyOisgUm9vdDorCgkJUFRNQ2xvY2tHcmFu dWxhcml0eTogNG5zCgkJUFRNQ29udHJvbDogRW5hYmxlZDorIFJvb3RTZWxlY3RlZDorCgkJUFRN RWZmZWN0aXZlR3JhbnVsYXJpdHk6IFVua25vd24KCUNhcGFiaWxpdGllczogWzIwMCB2MV0gTDEg UE0gU3Vic3RhdGVzCgkJTDFTdWJDYXA6IFBDSS1QTV9MMS4yKyBQQ0ktUE1fTDEuMSsgQVNQTV9M MS4yKyBBU1BNX0wxLjErIEwxX1BNX1N1YnN0YXRlcysKCQkJICBQb3J0Q29tbW9uTW9kZVJlc3Rv cmVUaW1lPTQwdXMgUG9ydFRQb3dlck9uVGltZT00NHVzCgkJTDFTdWJDdGwxOiBQQ0ktUE1fTDEu MisgUENJLVBNX0wxLjEtIEFTUE1fTDEuMisgQVNQTV9MMS4xLQoJCQkgICBUX0NvbW1vbk1vZGU9 NDB1cyBMVFIxLjJfVGhyZXNob2xkPTY1NTM2bnMKCQlMMVN1YkN0bDI6IFRfUHdyT249NDR1cwoJ Q2FwYWJpbGl0aWVzOiBbMjIwIHYxXSBTZWNvbmRhcnkgUENJIEV4cHJlc3MKCQlMbmtDdGwzOiBM bmtFcXVJbnRycnVwdEVuLSBQZXJmb3JtRXF1LQoJCUxhbmVFcnJTdGF0OiAwCglDYXBhYmlsaXRp ZXM6IFsyNTAgdjFdIERvd25zdHJlYW0gUG9ydCBDb250YWlubWVudAoJCURwY0NhcDoJSU5UIE1z ZyAjMCwgUlBFeHQrIFBvaXNvbmVkVExQKyBTd1RyaWdnZXIrIFJQIFBJTyBMb2cgNCwgRExfQWN0 aXZlRXJyKwoJCURwY0N0bDoJVHJpZ2dlcjoxIENtcGwtIElOVCsgRXJyQ29yLSBQb2lzb25lZFRM UC0gU3dUcmlnZ2VyLSBETF9BY3RpdmVFcnItCgkJRHBjU3RhOglUcmlnZ2VyLSBSZWFzb246MDAg SU5ULSBSUEJ1c3ktIFRyaWdnZXJFeHQ6MDAgUlAgUElPIEVyclB0cjoxZgoJCVNvdXJjZToJMDAw MAoJS2VybmVsIGRyaXZlciBpbiB1c2U6IHBjaWVwb3J0CgowNTowMC4wIE5vbi1Wb2xhdGlsZSBt ZW1vcnkgY29udHJvbGxlcjogU2FuZGlzayBDb3JwIERldmljZSA1MDFhIChwcm9nLWlmIDAyIFtO Vk0gRXhwcmVzc10pCglTdWJzeXN0ZW06IFNhbmRpc2sgQ29ycCBEZXZpY2UgNTAxYQoJQ29udHJv bDogSS9PKyBNZW0rIEJ1c01hc3RlcisgU3BlY0N5Y2xlLSBNZW1XSU5WLSBWR0FTbm9vcC0gUGFy RXJyLSBTdGVwcGluZy0gU0VSUi0gRmFzdEIyQi0gRGlzSU5UeCsKCVN0YXR1czogQ2FwKyA2Nk1I ei0gVURGLSBGYXN0QjJCLSBQYXJFcnItIERFVlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQtIDxN QWJvcnQtID5TRVJSLSA8UEVSUi0gSU5UeC0KCUxhdGVuY3k6IDAsIENhY2hlIExpbmUgU2l6ZTog NjQgYnl0ZXMKCUludGVycnVwdDogcGluIEEgcm91dGVkIHRvIElSUSAxNgoJTlVNQSBub2RlOiAw CglJT01NVSBncm91cDogMTMKCVJlZ2lvbiAwOiBNZW1vcnkgYXQgYTI2MDAwMDAgKDY0LWJpdCwg bm9uLXByZWZldGNoYWJsZSkgW3NpemU9MTZLXQoJUmVnaW9uIDQ6IE1lbW9yeSBhdCBhMjYwNDAw MCAoNjQtYml0LCBub24tcHJlZmV0Y2hhYmxlKSBbc2l6ZT0yNTZdCglDYXBhYmlsaXRpZXM6IFs4 MF0gUG93ZXIgTWFuYWdlbWVudCB2ZXJzaW9uIDMKCQlGbGFnczogUE1FQ2xrLSBEU0ktIEQxLSBE Mi0gQXV4Q3VycmVudD0wbUEgUE1FKEQwLSxEMS0sRDItLEQzaG90LSxEM2NvbGQtKQoJCVN0YXR1 czogRDAgTm9Tb2Z0UnN0KyBQTUUtRW5hYmxlLSBEU2VsPTAgRFNjYWxlPTAgUE1FLQoJQ2FwYWJp bGl0aWVzOiBbOTBdIE1TSTogRW5hYmxlLSBDb3VudD0xLzMyIE1hc2thYmxlLSA2NGJpdCsKCQlB ZGRyZXNzOiAwMDAwMDAwMDAwMDAwMDAwICBEYXRhOiAwMDAwCglDYXBhYmlsaXRpZXM6IFtiMF0g TVNJLVg6IEVuYWJsZSsgQ291bnQ9MTcgTWFza2VkLQoJCVZlY3RvciB0YWJsZTogQkFSPTAgb2Zm c2V0PTAwMDAyMDAwCgkJUEJBOiBCQVI9NCBvZmZzZXQ9MDAwMDAwMDAKCUNhcGFiaWxpdGllczog W2MwXSBFeHByZXNzICh2MikgRW5kcG9pbnQsIE1TSSAwMAoJCURldkNhcDoJTWF4UGF5bG9hZCA1 MTIgYnl0ZXMsIFBoYW50RnVuYyAwLCBMYXRlbmN5IEwwcyA8MXVzLCBMMSB1bmxpbWl0ZWQKCQkJ RXh0VGFnLSBBdHRuQnRuLSBBdHRuSW5kLSBQd3JJbmQtIFJCRSsgRkxSZXNldCsgU2xvdFBvd2Vy TGltaXQgMC4wMDBXCgkJRGV2Q3RsOglDb3JyRXJyKyBOb25GYXRhbEVycisgRmF0YWxFcnIrIFVu c3VwUmVxKwoJCQlSbHhkT3JkKyBFeHRUYWctIFBoYW50RnVuYy0gQXV4UHdyLSBOb1Nub29wKyBG TFJlc2V0LQoJCQlNYXhQYXlsb2FkIDI1NiBieXRlcywgTWF4UmVhZFJlcSA1MTIgYnl0ZXMKCQlE ZXZTdGE6CUNvcnJFcnItIE5vbkZhdGFsRXJyLSBGYXRhbEVyci0gVW5zdXBSZXEtIEF1eFB3ci0g VHJhbnNQZW5kLQoJCUxua0NhcDoJUG9ydCAjMCwgU3BlZWQgOEdUL3MsIFdpZHRoIHg0LCBBU1BN IEwxLCBFeGl0IExhdGVuY3kgTDEgPDh1cwoJCQlDbG9ja1BNKyBTdXJwcmlzZS0gTExBY3RSZXAt IEJ3Tm90LSBBU1BNT3B0Q29tcCsKCQlMbmtDdGw6CUFTUE0gTDEgRW5hYmxlZDsgUkNCIDY0IGJ5 dGVzLCBEaXNhYmxlZC0gQ29tbUNsaysKCQkJRXh0U3luY2gtIENsb2NrUE0rIEF1dFdpZERpcy0g QldJbnQtIEF1dEJXSW50LQoJCUxua1N0YToJU3BlZWQgOEdUL3MgKG9rKSwgV2lkdGggeDQgKG9r KQoJCQlUckVyci0gVHJhaW4tIFNsb3RDbGsrIERMQWN0aXZlLSBCV01nbXQtIEFCV01nbXQtCgkJ RGV2Q2FwMjogQ29tcGxldGlvbiBUaW1lb3V0OiBSYW5nZSBCLCBUaW1lb3V0RGlzKyBOUk9QclBy UC0gTFRSKwoJCQkgMTBCaXRUYWdDb21wLSAxMEJpdFRhZ1JlcS0gT0JGRiBOb3QgU3VwcG9ydGVk LCBFeHRGbXQrIEVFVExQUHJlZml4LQoJCQkgRW1lcmdlbmN5UG93ZXJSZWR1Y3Rpb24gTm90IFN1 cHBvcnRlZCwgRW1lcmdlbmN5UG93ZXJSZWR1Y3Rpb25Jbml0LQoJCQkgRlJTLSBUUEhDb21wLSBF eHRUUEhDb21wLQoJCQkgQXRvbWljT3BzQ2FwOiAzMmJpdC0gNjRiaXQtIDEyOGJpdENBUy0KCQlE ZXZDdGwyOiBDb21wbGV0aW9uIFRpbWVvdXQ6IDUwdXMgdG8gNTBtcywgVGltZW91dERpcy0gTFRS KyBPQkZGIERpc2FibGVkLAoJCQkgQXRvbWljT3BzQ3RsOiBSZXFFbi0KCQlMbmtDYXAyOiBTdXBw b3J0ZWQgTGluayBTcGVlZHM6IDIuNS04R1QvcywgQ3Jvc3NsaW5rLSBSZXRpbWVyLSAyUmV0aW1l cnMtIERSUy0KCQlMbmtDdGwyOiBUYXJnZXQgTGluayBTcGVlZDogOEdUL3MsIEVudGVyQ29tcGxp YW5jZS0gU3BlZWREaXMtCgkJCSBUcmFuc21pdCBNYXJnaW46IE5vcm1hbCBPcGVyYXRpbmcgUmFu Z2UsIEVudGVyTW9kaWZpZWRDb21wbGlhbmNlLSBDb21wbGlhbmNlU09TLQoJCQkgQ29tcGxpYW5j ZSBEZS1lbXBoYXNpczogLTZkQgoJCUxua1N0YTI6IEN1cnJlbnQgRGUtZW1waGFzaXMgTGV2ZWw6 IC02ZEIsIEVxdWFsaXphdGlvbkNvbXBsZXRlKyBFcXVhbGl6YXRpb25QaGFzZTErCgkJCSBFcXVh bGl6YXRpb25QaGFzZTIrIEVxdWFsaXphdGlvblBoYXNlMysgTGlua0VxdWFsaXphdGlvblJlcXVl c3QtCgkJCSBSZXRpbWVyLSAyUmV0aW1lcnMtIENyb3NzbGlua1JlczogdW5zdXBwb3J0ZWQKCUNh cGFiaWxpdGllczogWzEwMCB2Ml0gQWR2YW5jZWQgRXJyb3IgUmVwb3J0aW5nCgkJVUVTdGE6CURM UC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0gVW54Q21wbHQtIFJ4T0YtIE1h bGZUTFAtIEVDUkMtIFVuc3VwUmVxLSBBQ1NWaW9sLQoJCVVFTXNrOglETFAtIFNERVMtIFRMUC0g RkNQLSBDbXBsdFRPLSBDbXBsdEFicnQtIFVueENtcGx0LSBSeE9GLSBNYWxmVExQLSBFQ1JDLSBV bnN1cFJlcS0gQUNTVmlvbC0KCQlVRVN2cnQ6CURMUCsgU0RFUysgVExQLSBGQ1ArIENtcGx0VE8t IENtcGx0QWJydC0gVW54Q21wbHQtIFJ4T0YrIE1hbGZUTFArIEVDUkMtIFVuc3VwUmVxLSBBQ1NW aW9sLQoJCUNFU3RhOglSeEVyci0gQmFkVExQLSBCYWRETExQLSBSb2xsb3Zlci0gVGltZW91dC0g QWR2Tm9uRmF0YWxFcnItCgkJQ0VNc2s6CVJ4RXJyLSBCYWRUTFAtIEJhZERMTFAtIFJvbGxvdmVy LSBUaW1lb3V0LSBBZHZOb25GYXRhbEVycisKCQlBRVJDYXA6CUZpcnN0IEVycm9yIFBvaW50ZXI6 IDAwLCBFQ1JDR2VuQ2FwKyBFQ1JDR2VuRW4tIEVDUkNDaGtDYXArIEVDUkNDaGtFbi0KCQkJTXVs dEhkclJlY0NhcC0gTXVsdEhkclJlY0VuLSBUTFBQZnhQcmVzLSBIZHJMb2dDYXAtCgkJSGVhZGVy TG9nOiAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAoJQ2FwYWJpbGl0aWVzOiBb MTUwIHYxXSBEZXZpY2UgU2VyaWFsIE51bWJlciAwMC0wMC0wMC0wMC0wMC0wMC0wMC0wMAoJQ2Fw YWJpbGl0aWVzOiBbMWI4IHYxXSBMYXRlbmN5IFRvbGVyYW5jZSBSZXBvcnRpbmcKCQlNYXggc25v b3AgbGF0ZW5jeTogMzE0NTcyOG5zCgkJTWF4IG5vIHNub29wIGxhdGVuY3k6IDMxNDU3MjhucwoJ Q2FwYWJpbGl0aWVzOiBbMzAwIHYxXSBTZWNvbmRhcnkgUENJIEV4cHJlc3MKCQlMbmtDdGwzOiBM bmtFcXVJbnRycnVwdEVuLSBQZXJmb3JtRXF1LQoJCUxhbmVFcnJTdGF0OiAwCglDYXBhYmlsaXRp ZXM6IFs5MDAgdjFdIEwxIFBNIFN1YnN0YXRlcwoJCUwxU3ViQ2FwOiBQQ0ktUE1fTDEuMisgUENJ LVBNX0wxLjEtIEFTUE1fTDEuMisgQVNQTV9MMS4xLSBMMV9QTV9TdWJzdGF0ZXMrCgkJCSAgUG9y dENvbW1vbk1vZGVSZXN0b3JlVGltZT0zMnVzIFBvcnRUUG93ZXJPblRpbWU9MTB1cwoJCUwxU3Vi Q3RsMTogUENJLVBNX0wxLjIrIFBDSS1QTV9MMS4xLSBBU1BNX0wxLjIrIEFTUE1fTDEuMS0KCQkJ ICAgVF9Db21tb25Nb2RlPTB1cyBMVFIxLjJfVGhyZXNob2xkPTY1NTM2bnMKCQlMMVN1YkN0bDI6 IFRfUHdyT249NDR1cwoJS2VybmVsIGRyaXZlciBpbiB1c2U6IG52bWUKCUtlcm5lbCBtb2R1bGVz OiBudm1lCgo= --000000000000452a6c05e2f920cb Content-Type: text/x-log; charset="US-ASCII"; name="xldmesg_full.log" Content-Disposition: attachment; filename="xldmesg_full.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56nzk561 IFhlbiA0LjE0LjMKKFhFTikgWGVuIHZlcnNpb24gNC4xNC4zIChmaXJlbWV0ZW9yQCkgKGdjYyAo RGViaWFuIDExLjIuMC0xMykgMTEuMi4wKSBkZWJ1Zz1uICBGcmkgSmFuICA3IDIxOjI4OjUyIEhL VCAyMDIyCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6IFNhdCBKYW4gMTQgMTU6NDE6MzIgMjAxNyAr MDgwMCBnaXQ6ZmY3OTJhODkzYS1kaXJ0eQooWEVOKSBidWlsZC1pZDogYzQzZmNjNjlmYjVmYzli Y2QyOTJiMzFiYTYxOGE3ZDIzMzVlYzY5YQooWEVOKSBCb290bG9hZGVyOiBHUlVCIDIuMDQtMjAK KFhFTikgQ29tbWFuZCBsaW5lOiBwbGFjZWhvbGRlciBkb20wX21lbT0yRyxtYXg6M0csbWluOjFH IGRvbTBfbWF4X3ZjcHVzPTQgbG9nbHZsPWFsbCBndWVzdF9sb2dsdmw9YWxsCihYRU4pIFhlbiBp bWFnZSBsb2FkIGJhc2UgYWRkcmVzczogMHg4N2EwMDAwMAooWEVOKSBWaWRlbyBpbmZvcm1hdGlv bjoKKFhFTikgIFZHQSBpcyB0ZXh0IG1vZGUgODB4MjUsIGZvbnQgOHgxNgooWEVOKSAgVkJFL0RE QyBtZXRob2RzOiBWMjsgRURJRCB0cmFuc2ZlciB0aW1lOiAxIHNlY29uZHMKKFhFTikgRGlzYyBp bmZvcm1hdGlvbjoKKFhFTikgIEZvdW5kIDUgTUJSIHNpZ25hdHVyZXMKKFhFTikgIEZvdW5kIDUg RUREIGluZm9ybWF0aW9uIHN0cnVjdHVyZXMKKFhFTikgQ1BVIFZlbmRvcjogSW50ZWwsIEZhbWls eSA2ICgweDYpLCBNb2RlbCAxNTggKDB4OWUpLCBTdGVwcGluZyAxMCAocmF3IDAwMDkwNmVhKQoo WEVOKSBYZW4tZTgyMCBSQU0gbWFwOgooWEVOKSAgWzAwMDAwMDAwMDAwMDAwMDAsIDAwMDAwMDAw MDAwOWQzZmZdICh1c2FibGUpCihYRU4pICBbMDAwMDAwMDAwMDA5ZDQwMCwgMDAwMDAwMDAwMDA5 ZmZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAwMDAwZTAwMDAsIDAwMDAwMDAwMDAwZmZm ZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDAwMTAwMDAwLCAwMDAwMDAwMDgzNWJmZmZm XSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODM1YzAwMDAsIDAwMDAwMDAwODM1YzBmZmZdIChB Q1BJIE5WUykKKFhFTikgIFswMDAwMDAwMDgzNWMxMDAwLCAwMDAwMDAwMDgzNWMxZmZmXSAocmVz ZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDA4MzVjMjAwMCwgMDAwMDAwMDA4OGMwYmZmZl0gKHVzYWJs ZSkKKFhFTikgIFswMDAwMDAwMDg4YzBjMDAwLCAwMDAwMDAwMDg5MDdkZmZmXSAocmVzZXJ2ZWQp CihYRU4pICBbMDAwMDAwMDA4OTA3ZTAwMCwgMDAwMDAwMDA4OTFmNGZmZl0gKHVzYWJsZSkKKFhF TikgIFswMDAwMDAwMDg5MWY1MDAwLCAwMDAwMDAwMDg5NWRjZmZmXSAoQUNQSSBOVlMpCihYRU4p ICBbMDAwMDAwMDA4OTVkZDAwMCwgMDAwMDAwMDA4OWVmZWZmZl0gKHJlc2VydmVkKQooWEVOKSAg WzAwMDAwMDAwODllZmYwMDAsIDAwMDAwMDAwODllZmZmZmZdICh1c2FibGUpCihYRU4pICBbMDAw MDAwMDA4OWYwMDAwMCwgMDAwMDAwMDA4ZjdmZmZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAw MDAwZTAwMDAwMDAsIDAwMDAwMDAwZWZmZmZmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAw MGZlMDAwMDAwLCAwMDAwMDAwMGZlMDEwZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDBm ZWMwMDAwMCwgMDAwMDAwMDBmZWMwMGZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAwZmVl MDAwMDAsIDAwMDAwMDAwZmVlMDBmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMGZmMDAw MDAwLCAwMDAwMDAwMGZmZmZmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDEwMDAwMDAw MCwgMDAwMDAwMDg2ZTdmZmZmZl0gKHVzYWJsZSkKKFhFTikgQUNQSTogUlNEUCAwMDBGMDVCMCwg MDAyNCAocjIgQUxBU0tBKQooWEVOKSBBQ1BJOiBYU0RUIDg5NTEyMEE4LCAwMEQ0IChyMSBBTEFT S0EgICAgQSBNIEkgIDEwNzIwMDkgQU1JICAgICAxMDAxMykKKFhFTikgQUNQSTogRkFDUCA4OTU1 MDlDMCwgMDExNCAocjYgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAgMTAwMTMpCihY RU4pIEFDUEk6IERTRFQgODk1MTIyMTgsIDNFN0E2IChyMiBBTEFTS0EgICAgQSBNIEkgIDEwNzIw MDkgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTogRkFDUyA4OTVEQzA4MCwgMDA0MAooWEVOKSBB Q1BJOiBBUElDIDg5NTUwQUQ4LCAwMEY0IChyNCBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1J ICAgICAxMDAxMykKKFhFTikgQUNQSTogRlBEVCA4OTU1MEJEMCwgMDA0NCAocjEgQUxBU0tBICAg IEEgTSBJICAxMDcyMDA5IEFNSSAgICAgMTAwMTMpCihYRU4pIEFDUEk6IEZJRFQgODk1NTBDMTgs IDAwOUMgKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBB Q1BJOiBNQ0ZHIDg5NTUwQ0I4LCAwMDNDIChyMSBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgTVNG VCAgICAgICA5NykKKFhFTikgQUNQSTogU1NEVCA4OTU1MENGOCwgMDIwNCAocjEgQUxBU0tBICAg IEEgTSBJICAgICAxMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NTBGMDAs IDE3RDUgKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMzAwMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBB Q1BJOiBTU0RUIDg5NTUyNkQ4LCA5MzNEIChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDEgSU5U TCAyMDE2MDUyNykKKFhFTikgQUNQSTogU1NEVCA4OTU1QkExOCwgMzFDNyAocjIgQUxBU0tBICAg IEEgTSBJICAgICAzMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NUVCRTAs IDIzNTggKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBB Q1BJOiBIUEVUIDg5NTYwRjM4LCAwMDM4IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAg ICAgMTAwMDAxMykKKFhFTikgQUNQSTogU1NEVCA4OTU2MEY3MCwgMUJFMSAocjIgQUxBU0tBICAg IEEgTSBJICAgICAxMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NjJCNTgs IDBGOUUgKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBB Q1BJOiBTU0RUIDg5NTYzQUY4LCAyRDFCIChyMiBBTEFTS0EgICAgQSBNIEkgICAgICAgIDAgSU5U TCAyMDE2MDUyNykKKFhFTikgQUNQSTogVUVGSSA4OTU2NjgxOCwgMDA0MiAocjEgQUxBU0tBICAg IEEgTSBJICAgICAgICAyICAgICAgIDEwMDAwMTMpCihYRU4pIEFDUEk6IExQSVQgODk1NjY4NjAs IDAwNUMgKHIxIEFMQVNLQSAgICBBIE0gSSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBB Q1BJOiBTU0RUIDg5NTY2OEMwLCAyN0RFIChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDEwMDAgSU5U TCAyMDE2MDUyNykKKFhFTikgQUNQSTogU1NEVCA4OTU2OTBBMCwgMEZGRSAocjIgQUxBU0tBICAg IEEgTSBJICAgICAgICAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IERCR1AgODk1NkEwQTAs IDAwMzQgKHIxIEFMQVNLQSAgICBBIE0gSSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBB Q1BJOiBEQkcyIDg5NTZBMEQ4LCAwMDU0IChyMCBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAg ICAgMTAwMDAxMykKKFhFTikgQUNQSTogRE1BUiA4OTU2QTEzMCwgMDBBOCAocjEgQUxBU0tBICAg IEEgTSBJICAgICAgICAyICAgICAgIDEwMDAwMTMpCihYRU4pIEFDUEk6IFdTTVQgODk1NkExRDgs IDAwMjggKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBT eXN0ZW0gUkFNOiAzMjYyOU1CICgzMzQxMjIyMGtCKQooWEVOKSBObyBOVU1BIGNvbmZpZ3VyYXRp b24gZm91bmQKKFhFTikgRmFraW5nIGEgbm9kZSBhdCAwMDAwMDAwMDAwMDAwMDAwLTAwMDAwMDA4 NmU4MDAwMDAKKFhFTikgRG9tYWluIGhlYXAgaW5pdGlhbGlzZWQKKFhFTikgZm91bmQgU01QIE1Q LXRhYmxlIGF0IDAwMGZjZTEwCihYRU4pIFNNQklPUyAzLjEgcHJlc2VudC4KKFhFTikgVXNpbmcg QVBJQyBkcml2ZXIgZGVmYXVsdAooWEVOKSBBQ1BJOiBQTS1UaW1lciBJTyBQb3J0OiAweDE4MDgg KDI0IGJpdHMpCihYRU4pIEFDUEk6IHY1IFNMRUVQIElORk86IGNvbnRyb2xbMToxODA0XSwgc3Rh dHVzWzE6MTgwMF0KKFhFTikgQUNQSTogSW52YWxpZCBzbGVlcCBjb250cm9sL3N0YXR1cyByZWdp c3RlciBkYXRhOiAwOjB4ODoweDMgMDoweDg6MHgzCihYRU4pIEFDUEk6IFNMRUVQIElORk86IHBt MXhfY250WzE6MTgwNCwxOjBdLCBwbTF4X2V2dFsxOjE4MDAsMTowXQooWEVOKSBBQ1BJOiAzMi82 NFggRkFDUyBhZGRyZXNzIG1pc21hdGNoIGluIEZBRFQgLSA4OTVkYzA4MC8wMDAwMDAwMDAwMDAw MDAwLCB1c2luZyAzMgooWEVOKSBBQ1BJOiAgICAgICAgICAgICB3YWtldXBfdmVjWzg5NWRjMDhj XSwgdmVjX3NpemVbMjBdCihYRU4pIEFDUEk6IExvY2FsIEFQSUMgYWRkcmVzcyAweGZlZTAwMDAw CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDFdIGxhcGljX2lkWzB4MDBdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDJdIGxhcGljX2lkWzB4MDJdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDNdIGxhcGljX2lkWzB4MDRdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDRdIGxhcGljX2lkWzB4MDZdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDVdIGxhcGljX2lkWzB4MDhdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDZdIGxhcGljX2lkWzB4MGFdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDddIGxhcGljX2lkWzB4MDFdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDhdIGxhcGljX2lkWzB4MDNdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MDldIGxhcGljX2lkWzB4MDVdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MGFdIGxhcGljX2lkWzB4MDddIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MGJdIGxhcGljX2lkWzB4MDldIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDIChhY3BpX2lkWzB4MGNdIGxhcGljX2lkWzB4MGJdIGVuYWJsZWQp CihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDAxXSBoaWdoIGVkZ2UgbGludFsweDFd KQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwMl0gaGlnaCBlZGdlIGxpbnRbMHgx XSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDNdIGhpZ2ggZWRnZSBsaW50WzB4 MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA0XSBoaWdoIGVkZ2UgbGludFsw eDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwNV0gaGlnaCBlZGdlIGxpbnRb MHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDZdIGhpZ2ggZWRnZSBsaW50 WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA3XSBoaWdoIGVkZ2UgbGlu dFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwOF0gaGlnaCBlZGdlIGxp bnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDldIGhpZ2ggZWRnZSBs aW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDBhXSBoaWdoIGVkZ2Ug bGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwYl0gaGlnaCBlZGdl IGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MGNdIGhpZ2ggZWRn ZSBsaW50WzB4MV0pCihYRU4pIE92ZXJyaWRpbmcgQVBJQyBkcml2ZXIgd2l0aCBiaWdzbXAKKFhF TikgQUNQSTogSU9BUElDIChpZFsweDAyXSBhZGRyZXNzWzB4ZmVjMDAwMDBdIGdzaV9iYXNlWzBd KQooWEVOKSBJT0FQSUNbMF06IGFwaWNfaWQgMiwgdmVyc2lvbiAzMiwgYWRkcmVzcyAweGZlYzAw MDAwLCBHU0kgMC0xMTkKKFhFTikgQUNQSTogSU5UX1NSQ19PVlIgKGJ1cyAwIGJ1c19pcnEgMCBn bG9iYWxfaXJxIDIgZGZsIGRmbCkKKFhFTikgQUNQSTogSU5UX1NSQ19PVlIgKGJ1cyAwIGJ1c19p cnEgOSBnbG9iYWxfaXJxIDkgaGlnaCBsZXZlbCkKKFhFTikgQUNQSTogSVJRMCB1c2VkIGJ5IG92 ZXJyaWRlLgooWEVOKSBBQ1BJOiBJUlEyIHVzZWQgYnkgb3ZlcnJpZGUuCihYRU4pIEFDUEk6IElS UTkgdXNlZCBieSBvdmVycmlkZS4KKFhFTikgRW5hYmxpbmcgQVBJQyBtb2RlOiAgUGh5cy4gIFVz aW5nIDEgSS9PIEFQSUNzCihYRU4pIEFDUEk6IEhQRVQgaWQ6IDB4ODA4NmEyMDEgYmFzZTogMHhm ZWQwMDAwMAooWEVOKSBQQ0k6IE1DRkcgY29uZmlndXJhdGlvbiAwOiBiYXNlIGUwMDAwMDAwIHNl Z21lbnQgMDAwMCBidXNlcyAwMCAtIGZmCihYRU4pIFBDSTogTUNGRyBhcmVhIGF0IGUwMDAwMDAw IHJlc2VydmVkIGluIEU4MjAKKFhFTikgUENJOiBVc2luZyBNQ0ZHIGZvciBzZWdtZW50IDAwMDAg YnVzIDAwLWZmCihYRU4pIFVzaW5nIEFDUEkgKE1BRFQpIGZvciBTTVAgY29uZmlndXJhdGlvbiBp bmZvcm1hdGlvbgooWEVOKSBTTVA6IEFsbG93aW5nIDEyIENQVXMgKDAgaG90cGx1ZyBDUFVzKQoo WEVOKSBJUlEgbGltaXRzOiAxMjAgR1NJLCAyMzc2IE1TSS9NU0ktWAooWEVOKSBTd2l0Y2hlZCB0 byBBUElDIGRyaXZlciB4MmFwaWNfY2x1c3RlcgooWEVOKSBDUFUwOiBUU0M6IHJhdGlvOiAyOTIg LyAyCihYRU4pIENQVTA6IGJ1czogMTAwIE1IeiBiYXNlOiAzNTAwIE1IeiBtYXg6IDQ1MDAgTUh6 CihYRU4pIENQVTA6IDgwMCAuLi4gMzUwMCBNSHoKKFhFTikgeHN0YXRlOiBzaXplOiAweDQ0MCBh bmQgc3RhdGVzOiAweDFmCihYRU4pIENQVTA6IEludGVsIG1hY2hpbmUgY2hlY2sgcmVwb3J0aW5n IGVuYWJsZWQKKFhFTikgU3BlY3VsYXRpdmUgbWl0aWdhdGlvbiBmYWNpbGl0aWVzOgooWEVOKSAg IEhhcmR3YXJlIGZlYXR1cmVzOiBJQlJTL0lCUEIgU1RJQlAgTDFEX0ZMVVNIIFNTQkQgTURfQ0xF QVIKKFhFTikgICBDb21waWxlZC1pbiBzdXBwb3J0OiBJTkRJUkVDVF9USFVOSyBTSEFET1dfUEFH SU5HCihYRU4pICAgWGVuIHNldHRpbmdzOiBCVEktVGh1bmsgSk1QLCBTUEVDX0NUUkw6IElCUlMr IFNTQkQtLCBPdGhlcjogSUJQQiBMMURfRkxVU0ggVkVSVyBCUkFOQ0hfSEFSREVOCihYRU4pICAg TDFURjogYmVsaWV2ZWQgdnVsbmVyYWJsZSwgbWF4cGh5c2FkZHIgTDFEIDQ2LCBDUFVJRCAzOSwg U2FmZSBhZGRyZXNzIDgwMDAwMDAwMDAKKFhFTikgICBTdXBwb3J0IGZvciBIVk0gVk1zOiBNU1Jf U1BFQ19DVFJMIFJTQiBFQUdFUl9GUFUgTURfQ0xFQVIKKFhFTikgICBTdXBwb3J0IGZvciBQViBW TXM6IE1TUl9TUEVDX0NUUkwgUlNCIEVBR0VSX0ZQVSBNRF9DTEVBUgooWEVOKSAgIFhQVEkgKDY0 LWJpdCBQViBvbmx5KTogRG9tMCBlbmFibGVkLCBEb21VIGVuYWJsZWQgKHdpdGggUENJRCkKKFhF TikgICBQViBMMVRGIHNoYWRvd2luZzogRG9tMCBkaXNhYmxlZCwgRG9tVSBlbmFibGVkCihYRU4p IFVzaW5nIHNjaGVkdWxlcjogU01QIENyZWRpdCBTY2hlZHVsZXIgcmV2MiAoY3JlZGl0MikKKFhF TikgSW5pdGlhbGl6aW5nIENyZWRpdDIgc2NoZWR1bGVyCihYRU4pICBsb2FkX3ByZWNpc2lvbl9z aGlmdDogMTgKKFhFTikgIGxvYWRfd2luZG93X3NoaWZ0OiAzMAooWEVOKSAgdW5kZXJsb2FkX2Jh bGFuY2VfdG9sZXJhbmNlOiAwCihYRU4pICBvdmVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogLTMK KFhFTikgIHJ1bnF1ZXVlcyBhcnJhbmdlbWVudDogc29ja2V0CihYRU4pICBjYXAgZW5mb3JjZW1l bnQgZ3JhbnVsYXJpdHk6IDEwbXMKKFhFTikgbG9hZCB0cmFja2luZyB3aW5kb3cgbGVuZ3RoIDEw NzM3NDE4MjQgbnMKKFhFTikgUGxhdGZvcm0gdGltZXIgaXMgMjQuMDAwTUh6IEhQRVQKKFhFTikg RGV0ZWN0ZWQgMzUwNC43NjcgTUh6IHByb2Nlc3Nvci4KKFhFTikgYWx0IHRhYmxlIGZmZmY4MmQw NDA0MzkyOTAgLT4gZmZmZjgyZDA0MDQ0NDIzOAooWEVOKSBJbnRlbCBWVC1kIGlvbW11IDAgc3Vw cG9ydGVkIHBhZ2Ugc2l6ZXM6IDRrQiwgMk1CLCAxR0IKKFhFTikgSW50ZWwgVlQtZCBpb21tdSAx IHN1cHBvcnRlZCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdCCihYRU4pIEludGVsIFZULWQgU25v b3AgQ29udHJvbCBub3QgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBEb20wIERNQSBQYXNzdGhy b3VnaCBub3QgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBRdWV1ZWQgSW52YWxpZGF0aW9uIGVu YWJsZWQuCihYRU4pIEludGVsIFZULWQgSW50ZXJydXB0IFJlbWFwcGluZyBlbmFibGVkLgooWEVO KSBJbnRlbCBWVC1kIFBvc3RlZCBJbnRlcnJ1cHQgbm90IGVuYWJsZWQuCihYRU4pIEludGVsIFZU LWQgU2hhcmVkIEVQVCB0YWJsZXMgZW5hYmxlZC4KKFhFTikgSS9PIHZpcnR1YWxpc2F0aW9uIGVu YWJsZWQKKFhFTikgIC0gRG9tMCBtb2RlOiBSZWxheGVkCihYRU4pIEludGVycnVwdCByZW1hcHBp bmcgZW5hYmxlZAooWEVOKSBucl9zb2NrZXRzOiAxCihYRU4pIEVuYWJsZWQgZGlyZWN0ZWQgRU9J IHdpdGggaW9hcGljX2Fja19vbGQgb24hCihYRU4pIEVOQUJMSU5HIElPLUFQSUMgSVJRcwooWEVO KSAgLT4gVXNpbmcgb2xkIEFDSyBtZXRob2QKKFhFTikgLi5USU1FUjogdmVjdG9yPTB4RjAgYXBp YzE9MCBwaW4xPTIgYXBpYzI9LTEgcGluMj0tMQooWEVOKSBUU0MgZGVhZGxpbmUgdGltZXIgZW5h YmxlZAooWEVOKSBBbGxvY2F0ZWQgY29uc29sZSByaW5nIG9mIDEyOCBLaUIuCihYRU4pIG13YWl0 LWlkbGU6IE1XQUlUIHN1YnN0YXRlczogMHgxMTE0MjEyMAooWEVOKSBtd2FpdC1pZGxlOiB2MC40 LjEgbW9kZWwgMHg5ZQooWEVOKSBtd2FpdC1pZGxlOiBsYXBpY190aW1lcl9yZWxpYWJsZV9zdGF0 ZXMgMHhmZmZmZmZmZgooWEVOKSBWTVg6IFN1cHBvcnRlZCBhZHZhbmNlZCBmZWF0dXJlczoKKFhF TikgIC0gQVBJQyBNTUlPIGFjY2VzcyB2aXJ0dWFsaXNhdGlvbgooWEVOKSAgLSBBUElDIFRQUiBz aGFkb3cKKFhFTikgIC0gRXh0ZW5kZWQgUGFnZSBUYWJsZXMgKEVQVCkKKFhFTikgIC0gVmlydHVh bC1Qcm9jZXNzb3IgSWRlbnRpZmllcnMgKFZQSUQpCihYRU4pICAtIFZpcnR1YWwgTk1JCihYRU4p ICAtIE1TUiBkaXJlY3QtYWNjZXNzIGJpdG1hcAooWEVOKSAgLSBVbnJlc3RyaWN0ZWQgR3Vlc3QK KFhFTikgIC0gVk1DUyBzaGFkb3dpbmcKKFhFTikgIC0gVk0gRnVuY3Rpb25zCihYRU4pICAtIFZp cnR1YWxpc2F0aW9uIEV4Y2VwdGlvbnMKKFhFTikgIC0gUGFnZSBNb2RpZmljYXRpb24gTG9nZ2lu ZwooWEVOKSBIVk06IEFTSURzIGVuYWJsZWQuCihYRU4pIFZNWDogRGlzYWJsaW5nIGV4ZWN1dGFi bGUgRVBUIHN1cGVycGFnZXMgZHVlIHRvIENWRS0yMDE4LTEyMjA3CihYRU4pIEhWTTogVk1YIGVu YWJsZWQKKFhFTikgSFZNOiBIYXJkd2FyZSBBc3Npc3RlZCBQYWdpbmcgKEhBUCkgZGV0ZWN0ZWQK KFhFTikgSFZNOiBIQVAgcGFnZSBzaXplczogNGtCLCAyTUIsIDFHQgooWEVOKSBhbHQgdGFibGUg ZmZmZjgyZDA0MDQzOTI5MCAtPiBmZmZmODJkMDQwNDQ0MjM4CihYRU4pIEJyb3VnaHQgdXAgMTIg Q1BVcwooWEVOKSBTY2hlZHVsaW5nIGdyYW51bGFyaXR5OiBjcHUsIDEgQ1BVIHBlciBzY2hlZC1y ZXNvdXJjZQooWEVOKSBBZGRpbmcgY3B1IDAgdG8gcnVucXVldWUgMAooWEVOKSAgRmlyc3QgY3B1 IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nCihYRU4pIEFkZGluZyBjcHUgMSB0byBydW5xdWV1ZSAw CihYRU4pIEFkZGluZyBjcHUgMiB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgMyB0byBy dW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgNCB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBj cHUgNSB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgNiB0byBydW5xdWV1ZSAwCihYRU4p IEFkZGluZyBjcHUgNyB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgOCB0byBydW5xdWV1 ZSAwCihYRU4pIEFkZGluZyBjcHUgOSB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgMTAg dG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDExIHRvIHJ1bnF1ZXVlIDAKKFhFTikgbWNo ZWNrX3BvbGw6IE1hY2hpbmUgY2hlY2sgcG9sbGluZyB0aW1lciBzdGFydGVkLgooWEVOKSBOWCAo RXhlY3V0ZSBEaXNhYmxlKSBwcm90ZWN0aW9uIGFjdGl2ZQooWEVOKSBEb20wIGhhcyBtYXhpbXVt IDk1MiBQSVJRcwooWEVOKSAqKiogQnVpbGRpbmcgYSBQViBEb20wICoqKgooWEVOKSAgWGVuICBr ZXJuZWw6IDY0LWJpdCwgbHNiLCBjb21wYXQzMgooWEVOKSAgRG9tMCBrZXJuZWw6IDY0LWJpdCwg UEFFLCBsc2IsIHBhZGRyIDB4MTAwMDAwMCAtPiAweDJlMmMwMDAKKFhFTikgUEhZU0lDQUwgTUVN T1JZIEFSUkFOR0VNRU5UOgooWEVOKSAgRG9tMCBhbGxvYy46ICAgMDAwMDAwMDg1MDAwMDAwMC0+ MDAwMDAwMDg1NDAwMDAwMCAoNTA0MzE0IHBhZ2VzIHRvIGJlIGFsbG9jYXRlZCkKKFhFTikgIElu aXQuIHJhbWRpc2s6IDAwMDAwMDA4NmQ5ZmEwMDAtPjAwMDAwMDA4NmU3ZmYzZjYKKFhFTikgVklS VFVBTCBNRU1PUlkgQVJSQU5HRU1FTlQ6CihYRU4pICBMb2FkZWQga2VybmVsOiBmZmZmZmZmZjgx MDAwMDAwLT5mZmZmZmZmZjgyZTJjMDAwCihYRU4pICBJbml0LiByYW1kaXNrOiAwMDAwMDAwMDAw MDAwMDAwLT4wMDAwMDAwMDAwMDAwMDAwCihYRU4pICBQaHlzLU1hY2ggbWFwOiAwMDAwMDA4MDAw MDAwMDAwLT4wMDAwMDA4MDAwNDAwMDAwCihYRU4pICBTdGFydCBpbmZvOiAgICBmZmZmZmZmZjgy ZTJjMDAwLT5mZmZmZmZmZjgyZTJjNGI4CihYRU4pICBYZW5zdG9yZSByaW5nOiAwMDAwMDAwMDAw MDAwMDAwLT4wMDAwMDAwMDAwMDAwMDAwCihYRU4pICBDb25zb2xlIHJpbmc6ICAwMDAwMDAwMDAw MDAwMDAwLT4wMDAwMDAwMDAwMDAwMDAwCihYRU4pICBQYWdlIHRhYmxlczogICBmZmZmZmZmZjgy ZTJkMDAwLT5mZmZmZmZmZjgyZTQ4MDAwCihYRU4pICBCb290IHN0YWNrOiAgICBmZmZmZmZmZjgy ZTQ4MDAwLT5mZmZmZmZmZjgyZTQ5MDAwCihYRU4pICBUT1RBTDogICAgICAgICBmZmZmZmZmZjgw MDAwMDAwLT5mZmZmZmZmZjgzMDAwMDAwCihYRU4pICBFTlRSWSBBRERSRVNTOiBmZmZmZmZmZjgy YWI2MTYwCihYRU4pIERvbTAgaGFzIG1heGltdW0gNCBWQ1BVcwooWEVOKSBJbml0aWFsIGxvdyBt ZW1vcnkgdmlycSB0aHJlc2hvbGQgc2V0IGF0IDB4NDAwMCBwYWdlcy4KKFhFTikgU2NydWJiaW5n IEZyZWUgUkFNIGluIGJhY2tncm91bmQKKFhFTikgU3RkLiBMb2dsZXZlbDogQWxsCihYRU4pIEd1 ZXN0IExvZ2xldmVsOiBBbGwKKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqCihYRU4pIEJvb3RlZCBvbiBMMVRGLXZ1bG5lcmFibGUgaGFyZHdh cmUgd2l0aCBTTVQvSHlwZXJ0aHJlYWRpbmcKKFhFTikgZW5hYmxlZC4gIFBsZWFzZSBhc3Nlc3Mg eW91ciBjb25maWd1cmF0aW9uIGFuZCBjaG9vc2UgYW4KKFhFTikgZXhwbGljaXQgJ3NtdD08Ym9v bD4nIHNldHRpbmcuICBTZWUgWFNBLTI3My4KKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqCihYRU4pIEJvb3RlZCBvbiBNTFBEUy9NRkJEUy12 dWxuZXJhYmxlIGhhcmR3YXJlIHdpdGggU01UL0h5cGVydGhyZWFkaW5nCihYRU4pIGVuYWJsZWQu ICBNaXRpZ2F0aW9ucyB3aWxsIG5vdCBiZSBmdWxseSBlZmZlY3RpdmUuICBQbGVhc2UKKFhFTikg Y2hvb3NlIGFuIGV4cGxpY2l0IHNtdD08Ym9vbD4gc2V0dGluZy4gIFNlZSBYU0EtMjk3LgooWEVO KSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioKKFhF TikgMy4uLiAyLi4uIDEuLi4gCihYRU4pIFhlbiBpcyByZWxpbnF1aXNoaW5nIFZHQSBjb25zb2xl LgooWEVOKSAqKiogU2VyaWFsIGlucHV0IHRvIERPTTAgKHR5cGUgJ0NUUkwtYScgdGhyZWUgdGlt ZXMgdG8gc3dpdGNoIGlucHV0KQooWEVOKSBGcmVlZCA1NTJrQiBpbml0IG1lbW9yeQooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjAwOjAwLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDow MS4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MDIuMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjAwOjEyLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxNC4wCihYRU4pIFBD SSBhZGQgZGV2aWNlIDAwMDA6MDA6MTQuMgooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjE2 LjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxNi4zCihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6MDA6MTcuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFiLjAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDowMDoxYy4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWMu NQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFkLjAKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDowMDoxZi4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWYuNAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjAwOjFmLjUKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMTowMC4w CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDQ6MDAuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjA1OjAwLjAK --000000000000452a6c05e2f920cb-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 11:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 11:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360210.589582 (Exim 4.92) (envelope-from ) id 1o8KVJ-00059L-RA; Mon, 04 Jul 2022 11:44:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360210.589582; Mon, 04 Jul 2022 11:44:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8KVJ-00057p-KM; Mon, 04 Jul 2022 11:44:37 +0000 Received: by outflank-mailman (input) for mailman id 360210; Mon, 04 Jul 2022 11:44:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8KVI-00053F-As for xen-devel@lists.xen.org; Mon, 04 Jul 2022 11:44:36 +0000 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ac852d9b-fb8e-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 13:44:34 +0200 (CEST) Received: by mail-ed1-f47.google.com with SMTP id c13so11329020eds.10; Mon, 04 Jul 2022 04:44:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac852d9b-fb8e-11ec-a8e4-439420d8e422 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ThvNtKlW8SZIMdBeirFQyjMZaIVhsCAIxY/TvbyvEWE=; b=fLNFYPn8qRxdXMa759OQib4CbbJPYS/yUc7KtpnIZFypE6a5YB3QHEvAd+dJEvJlxY 9G2pQc8Aqfk41gblaY0uTElA6aFDTeRshc+Ft89S+igse8vDBqTFX7ySHaDo7p2Y7++R yV2CWIA74pnXW/Jiv03Fgh0u5N1Lco1oDicFxubNJTHX4a5B5YUl3eE2F1U2BJsL9x8X CkxzSHKxUrLHCdhFKwypnngXTrvGN09SDYF6B1rqITCaIFh7XT2L9mhhjLD85oKI+4AU lz6JpQOw0JblxzsTxk+XpaNGWDQayGwDyckgNKNhv/9bPCxNckF4tu/ZB2vtTb65loDT L8YQ== X-Gm-Message-State: AJIora+qB0f5M3sfRmqrCovaqTo2+xOjF518GdRfqr+QUoSLzy8Ui6B4 tgRSRg8BevlFqWbDZRJvtMB4gjKMwTi3Wg+/PRzrwwy6 X-Google-Smtp-Source: AGRyM1u0cUtYozEp5O6kQjxVEw+2Mblhm87KCBlrtNUB74ftIpzS38n53xGFaDBuBZG77f0IRRtGblU2rYOqOfO0wo4= X-Received: by 2002:a05:6402:4306:b0:435:a1c9:4272 with SMTP id m6-20020a056402430600b00435a1c94272mr38811106edc.205.1656935073745; Mon, 04 Jul 2022 04:44:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 19:44:21 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-users , xen-devel Content-Type: multipart/mixed; boundary="0000000000007ca26305e2f942ca" --0000000000007ca26305e2f942ca Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 7:34 PM G.R. wrot= e: > > On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monn=C3=A9 wrote: > > > > Would also be helpful if you could get the RMRR regions from that > > box. Booting with `iommu=3Dverbose` on the Xen command line should prin= t > > those. > Coming in my next reply... See attached. --0000000000007ca26305e2f942ca Content-Type: text/x-log; charset="US-ASCII"; name="xldmesg_full_rmrr.log" Content-Disposition: attachment; filename="xldmesg_full_rmrr.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56ocm990 IFhlbiA0LjE0LjMKKFhFTikgWGVuIHZlcnNpb24gNC4xNC4zIChmaXJlbWV0ZW9yQCkgKGdjYyAo RGViaWFuIDExLjIuMC0xMykgMTEuMi4wKSBkZWJ1Zz1uICBGcmkgSmFuICA3IDIxOjI4OjUyIEhL VCAyMDIyCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6IFNhdCBKYW4gMTQgMTU6NDE6MzIgMjAxNyAr MDgwMCBnaXQ6ZmY3OTJhODkzYS1kaXJ0eQooWEVOKSBidWlsZC1pZDogYzQzZmNjNjlmYjVmYzli Y2QyOTJiMzFiYTYxOGE3ZDIzMzVlYzY5YQooWEVOKSBCb290bG9hZGVyOiBHUlVCIDIuMDQtMjAK KFhFTikgQ29tbWFuZCBsaW5lOiBwbGFjZWhvbGRlciBkb20wX21lbT0yRyxtYXg6M0csbWluOjFH IGRvbTBfbWF4X3ZjcHVzPTQgbG9nbHZsPWFsbCBndWVzdF9sb2dsdmw9YWxsIGlvbW11PXZlcmJv c2UKKFhFTikgWGVuIGltYWdlIGxvYWQgYmFzZSBhZGRyZXNzOiAweDg3YTAwMDAwCihYRU4pIFZp ZGVvIGluZm9ybWF0aW9uOgooWEVOKSAgVkdBIGlzIHRleHQgbW9kZSA4MHgyNSwgZm9udCA4eDE2 CihYRU4pICBWQkUvRERDIG1ldGhvZHM6IFYyOyBFRElEIHRyYW5zZmVyIHRpbWU6IDEgc2Vjb25k cwooWEVOKSBEaXNjIGluZm9ybWF0aW9uOgooWEVOKSAgRm91bmQgNSBNQlIgc2lnbmF0dXJlcwoo WEVOKSAgRm91bmQgNSBFREQgaW5mb3JtYXRpb24gc3RydWN0dXJlcwooWEVOKSBDUFUgVmVuZG9y OiBJbnRlbCwgRmFtaWx5IDYgKDB4NiksIE1vZGVsIDE1OCAoMHg5ZSksIFN0ZXBwaW5nIDEwIChy YXcgMDAwOTA2ZWEpCihYRU4pIFhlbi1lODIwIFJBTSBtYXA6CihYRU4pICBbMDAwMDAwMDAwMDAw MDAwMCwgMDAwMDAwMDAwMDA5ZDNmZl0gKHVzYWJsZSkKKFhFTikgIFswMDAwMDAwMDAwMDlkNDAw LCAwMDAwMDAwMDAwMDlmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDAwMDBlMDAwMCwg MDAwMDAwMDAwMDBmZmZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAwMDAxMDAwMDAsIDAw MDAwMDAwODM1YmZmZmZdICh1c2FibGUpCihYRU4pICBbMDAwMDAwMDA4MzVjMDAwMCwgMDAwMDAw MDA4MzVjMGZmZl0gKEFDUEkgTlZTKQooWEVOKSAgWzAwMDAwMDAwODM1YzEwMDAsIDAwMDAwMDAw ODM1YzFmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDgzNWMyMDAwLCAwMDAwMDAwMDg4 YzBiZmZmXSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODhjMGMwMDAsIDAwMDAwMDAwODkwN2Rm ZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDg5MDdlMDAwLCAwMDAwMDAwMDg5MWY0ZmZm XSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODkxZjUwMDAsIDAwMDAwMDAwODk1ZGNmZmZdIChB Q1BJIE5WUykKKFhFTikgIFswMDAwMDAwMDg5NWRkMDAwLCAwMDAwMDAwMDg5ZWZlZmZmXSAocmVz ZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDA4OWVmZjAwMCwgMDAwMDAwMDA4OWVmZmZmZl0gKHVzYWJs ZSkKKFhFTikgIFswMDAwMDAwMDg5ZjAwMDAwLCAwMDAwMDAwMDhmN2ZmZmZmXSAocmVzZXJ2ZWQp CihYRU4pICBbMDAwMDAwMDBlMDAwMDAwMCwgMDAwMDAwMDBlZmZmZmZmZl0gKHJlc2VydmVkKQoo WEVOKSAgWzAwMDAwMDAwZmUwMDAwMDAsIDAwMDAwMDAwZmUwMTBmZmZdIChyZXNlcnZlZCkKKFhF TikgIFswMDAwMDAwMGZlYzAwMDAwLCAwMDAwMDAwMGZlYzAwZmZmXSAocmVzZXJ2ZWQpCihYRU4p ICBbMDAwMDAwMDBmZWUwMDAwMCwgMDAwMDAwMDBmZWUwMGZmZl0gKHJlc2VydmVkKQooWEVOKSAg WzAwMDAwMDAwZmYwMDAwMDAsIDAwMDAwMDAwZmZmZmZmZmZdIChyZXNlcnZlZCkKKFhFTikgIFsw MDAwMDAwMTAwMDAwMDAwLCAwMDAwMDAwODZlN2ZmZmZmXSAodXNhYmxlKQooWEVOKSBBQ1BJOiBS U0RQIDAwMEYwNUIwLCAwMDI0IChyMiBBTEFTS0EpCihYRU4pIEFDUEk6IFhTRFQgODk1MTIwQTgs IDAwRDQgKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBB Q1BJOiBGQUNQIDg5NTUwOUMwLCAwMTE0IChyNiBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1J ICAgICAxMDAxMykKKFhFTikgQUNQSTogRFNEVCA4OTUxMjIxOCwgM0U3QTYgKHIyIEFMQVNLQSAg ICBBIE0gSSAgMTA3MjAwOSBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBGQUNTIDg5NURDMDgw LCAwMDQwCihYRU4pIEFDUEk6IEFQSUMgODk1NTBBRDgsIDAwRjQgKHI0IEFMQVNLQSAgICBBIE0g SSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBBQ1BJOiBGUERUIDg5NTUwQkQwLCAwMDQ0 IChyMSBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1JICAgICAxMDAxMykKKFhFTikgQUNQSTog RklEVCA4OTU1MEMxOCwgMDA5QyAocjEgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAg MTAwMTMpCihYRU4pIEFDUEk6IE1DRkcgODk1NTBDQjgsIDAwM0MgKHIxIEFMQVNLQSAgICBBIE0g SSAgMTA3MjAwOSBNU0ZUICAgICAgIDk3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTUwQ0Y4LCAwMjA0 IChyMSBBTEFTS0EgICAgQSBNIEkgICAgIDEwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU1MEYwMCwgMTdENSAocjIgQUxBU0tBICAgIEEgTSBJICAgICAzMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NTI2RDgsIDkzM0QgKHIxIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMSBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTVCQTE4LCAzMUM3 IChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDMwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU1RUJFMCwgMjM1OCAocjIgQUxBU0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IEhQRVQgODk1NjBGMzgsIDAwMzggKHIxIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBBQ1BJOiBTU0RUIDg5NTYwRjcwLCAxQkUx IChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDEwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU2MkI1OCwgMEY5RSAocjIgQUxBU0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NjNBRjgsIDJEMUIgKHIyIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBVRUZJIDg5NTY2ODE4LCAwMDQy IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTog TFBJVCA4OTU2Njg2MCwgMDA1QyAocjEgQUxBU0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEw MDAwMTMpCihYRU4pIEFDUEk6IFNTRFQgODk1NjY4QzAsIDI3REUgKHIyIEFMQVNLQSAgICBBIE0g SSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTY5MEEwLCAwRkZF IChyMiBBTEFTS0EgICAgQSBNIEkgICAgICAgIDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog REJHUCA4OTU2QTBBMCwgMDAzNCAocjEgQUxBU0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEw MDAwMTMpCihYRU4pIEFDUEk6IERCRzIgODk1NkEwRDgsIDAwNTQgKHIwIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBBQ1BJOiBETUFSIDg5NTZBMTMwLCAwMEE4 IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTog V1NNVCA4OTU2QTFEOCwgMDAyOCAocjEgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAg MTAwMTMpCihYRU4pIFN5c3RlbSBSQU06IDMyNjI5TUIgKDMzNDEyMjIwa0IpCihYRU4pIE5vIE5V TUEgY29uZmlndXJhdGlvbiBmb3VuZAooWEVOKSBGYWtpbmcgYSBub2RlIGF0IDAwMDAwMDAwMDAw MDAwMDAtMDAwMDAwMDg2ZTgwMDAwMAooWEVOKSBEb21haW4gaGVhcCBpbml0aWFsaXNlZAooWEVO KSBmb3VuZCBTTVAgTVAtdGFibGUgYXQgMDAwZmNlMTAKKFhFTikgU01CSU9TIDMuMSBwcmVzZW50 LgooWEVOKSBVc2luZyBBUElDIGRyaXZlciBkZWZhdWx0CihYRU4pIEFDUEk6IFBNLVRpbWVyIElP IFBvcnQ6IDB4MTgwOCAoMjQgYml0cykKKFhFTikgQUNQSTogdjUgU0xFRVAgSU5GTzogY29udHJv bFsxOjE4MDRdLCBzdGF0dXNbMToxODAwXQooWEVOKSBBQ1BJOiBJbnZhbGlkIHNsZWVwIGNvbnRy b2wvc3RhdHVzIHJlZ2lzdGVyIGRhdGE6IDA6MHg4OjB4MyAwOjB4ODoweDMKKFhFTikgQUNQSTog U0xFRVAgSU5GTzogcG0xeF9jbnRbMToxODA0LDE6MF0sIHBtMXhfZXZ0WzE6MTgwMCwxOjBdCihY RU4pIEFDUEk6IDMyLzY0WCBGQUNTIGFkZHJlc3MgbWlzbWF0Y2ggaW4gRkFEVCAtIDg5NWRjMDgw LzAwMDAwMDAwMDAwMDAwMDAsIHVzaW5nIDMyCihYRU4pIEFDUEk6ICAgICAgICAgICAgIHdha2V1 cF92ZWNbODk1ZGMwOGNdLCB2ZWNfc2l6ZVsyMF0KKFhFTikgQUNQSTogTG9jYWwgQVBJQyBhZGRy ZXNzIDB4ZmVlMDAwMDAKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwMV0gbGFwaWNfaWRb MHgwMF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwMl0gbGFwaWNfaWRb MHgwMl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwM10gbGFwaWNfaWRb MHgwNF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNF0gbGFwaWNfaWRb MHgwNl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNV0gbGFwaWNfaWRb MHgwOF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNl0gbGFwaWNfaWRb MHgwYV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwN10gbGFwaWNfaWRb MHgwMV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwOF0gbGFwaWNfaWRb MHgwM10gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwOV0gbGFwaWNfaWRb MHgwNV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwYV0gbGFwaWNfaWRb MHgwN10gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwYl0gbGFwaWNfaWRb MHgwOV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwY10gbGFwaWNfaWRb MHgwYl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDFdIGhpZ2gg ZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDAyXSBoaWdo IGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwM10gaGln aCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDRdIGhp Z2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA1XSBo aWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwNl0g aGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDdd IGhpZ2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA4 XSBoaWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgw OV0gaGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4 MGFdIGhpZ2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsw eDBiXSBoaWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRb MHgwY10gaGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgT3ZlcnJpZGluZyBBUElDIGRyaXZlciB3 aXRoIGJpZ3NtcAooWEVOKSBBQ1BJOiBJT0FQSUMgKGlkWzB4MDJdIGFkZHJlc3NbMHhmZWMwMDAw MF0gZ3NpX2Jhc2VbMF0pCihYRU4pIElPQVBJQ1swXTogYXBpY19pZCAyLCB2ZXJzaW9uIDMyLCBh ZGRyZXNzIDB4ZmVjMDAwMDAsIEdTSSAwLTExOQooWEVOKSBBQ1BJOiBJTlRfU1JDX09WUiAoYnVz IDAgYnVzX2lycSAwIGdsb2JhbF9pcnEgMiBkZmwgZGZsKQooWEVOKSBBQ1BJOiBJTlRfU1JDX09W UiAoYnVzIDAgYnVzX2lycSA5IGdsb2JhbF9pcnEgOSBoaWdoIGxldmVsKQooWEVOKSBBQ1BJOiBJ UlEwIHVzZWQgYnkgb3ZlcnJpZGUuCihYRU4pIEFDUEk6IElSUTIgdXNlZCBieSBvdmVycmlkZS4K KFhFTikgQUNQSTogSVJROSB1c2VkIGJ5IG92ZXJyaWRlLgooWEVOKSBFbmFibGluZyBBUElDIG1v ZGU6ICBQaHlzLiAgVXNpbmcgMSBJL08gQVBJQ3MKKFhFTikgQUNQSTogSFBFVCBpZDogMHg4MDg2 YTIwMSBiYXNlOiAweGZlZDAwMDAwCihYRU4pIFBDSTogTUNGRyBjb25maWd1cmF0aW9uIDA6IGJh c2UgZTAwMDAwMDAgc2VnbWVudCAwMDAwIGJ1c2VzIDAwIC0gZmYKKFhFTikgUENJOiBNQ0ZHIGFy ZWEgYXQgZTAwMDAwMDAgcmVzZXJ2ZWQgaW4gRTgyMAooWEVOKSBQQ0k6IFVzaW5nIE1DRkcgZm9y IHNlZ21lbnQgMDAwMCBidXMgMDAtZmYKKFhFTikgW1ZULURdSG9zdCBhZGRyZXNzIHdpZHRoIDM5 CihYRU4pIFtWVC1EXWZvdW5kIEFDUElfRE1BUl9EUkhEOgooWEVOKSBbVlQtRF0gIGRtYXJ1LT5h ZGRyZXNzID0gZmVkOTAwMDAKKFhFTikgW1ZULURdZHJoZC0+YWRkcmVzcyA9IGZlZDkwMDAwIGlv bW11LT5yZWcgPSBmZmZmODJjMDAwMjFkMDAwCihYRU4pIFtWVC1EXWNhcCA9IDFjMDAwMGM0MDY2 MDQ2MiBlY2FwID0gMTllMmZmMDUwNWUKKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjAwOjAy LjAKKFhFTikgW1ZULURdZm91bmQgQUNQSV9ETUFSX0RSSEQ6CihYRU4pIFtWVC1EXSAgZG1hcnUt PmFkZHJlc3MgPSBmZWQ5MTAwMAooWEVOKSBbVlQtRF1kcmhkLT5hZGRyZXNzID0gZmVkOTEwMDAg aW9tbXUtPnJlZyA9IGZmZmY4MmMwMDAyMWYwMDAKKFhFTikgW1ZULURdY2FwID0gZDIwMDhjNDA2 NjA0NjIgZWNhcCA9IGYwNTBkYQooWEVOKSBbVlQtRF0gSU9BUElDOiAwMDAwOjAwOjFlLjcKKFhF TikgW1ZULURdIE1TSSBIUEVUOiAwMDAwOjAwOjFlLjYKKFhFTikgW1ZULURdICBmbGFnczogSU5D TFVERV9BTEwKKFhFTikgW1ZULURdZm91bmQgQUNQSV9ETUFSX1JNUlI6CihYRU4pIFtWVC1EXSBl bmRwb2ludDogMDAwMDowMDoxNC4wCihYRU4pIFtWVC1EXWZvdW5kIEFDUElfRE1BUl9STVJSOgoo WEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDA6MDIuMAooWEVOKSBVc2luZyBBQ1BJIChNQURU KSBmb3IgU01QIGNvbmZpZ3VyYXRpb24gaW5mb3JtYXRpb24KKFhFTikgU01QOiBBbGxvd2luZyAx MiBDUFVzICgwIGhvdHBsdWcgQ1BVcykKKFhFTikgSVJRIGxpbWl0czogMTIwIEdTSSwgMjM3NiBN U0kvTVNJLVgKKFhFTikgU3dpdGNoZWQgdG8gQVBJQyBkcml2ZXIgeDJhcGljX2NsdXN0ZXIKKFhF TikgQ1BVMDogVFNDOiByYXRpbzogMjkyIC8gMgooWEVOKSBDUFUwOiBidXM6IDEwMCBNSHogYmFz ZTogMzUwMCBNSHogbWF4OiA0NTAwIE1IegooWEVOKSBDUFUwOiA4MDAgLi4uIDM1MDAgTUh6CihY RU4pIHhzdGF0ZTogc2l6ZTogMHg0NDAgYW5kIHN0YXRlczogMHgxZgooWEVOKSBDUFUwOiBJbnRl bCBtYWNoaW5lIGNoZWNrIHJlcG9ydGluZyBlbmFibGVkCihYRU4pIFNwZWN1bGF0aXZlIG1pdGln YXRpb24gZmFjaWxpdGllczoKKFhFTikgICBIYXJkd2FyZSBmZWF0dXJlczogSUJSUy9JQlBCIFNU SUJQIEwxRF9GTFVTSCBTU0JEIE1EX0NMRUFSCihYRU4pICAgQ29tcGlsZWQtaW4gc3VwcG9ydDog SU5ESVJFQ1RfVEhVTksgU0hBRE9XX1BBR0lORwooWEVOKSAgIFhlbiBzZXR0aW5nczogQlRJLVRo dW5rIEpNUCwgU1BFQ19DVFJMOiBJQlJTKyBTU0JELSwgT3RoZXI6IElCUEIgTDFEX0ZMVVNIIFZF UlcgQlJBTkNIX0hBUkRFTgooWEVOKSAgIEwxVEY6IGJlbGlldmVkIHZ1bG5lcmFibGUsIG1heHBo eXNhZGRyIEwxRCA0NiwgQ1BVSUQgMzksIFNhZmUgYWRkcmVzcyA4MDAwMDAwMDAwCihYRU4pICAg U3VwcG9ydCBmb3IgSFZNIFZNczogTVNSX1NQRUNfQ1RSTCBSU0IgRUFHRVJfRlBVIE1EX0NMRUFS CihYRU4pICAgU3VwcG9ydCBmb3IgUFYgVk1zOiBNU1JfU1BFQ19DVFJMIFJTQiBFQUdFUl9GUFUg TURfQ0xFQVIKKFhFTikgICBYUFRJICg2NC1iaXQgUFYgb25seSk6IERvbTAgZW5hYmxlZCwgRG9t VSBlbmFibGVkICh3aXRoIFBDSUQpCihYRU4pICAgUFYgTDFURiBzaGFkb3dpbmc6IERvbTAgZGlz YWJsZWQsIERvbVUgZW5hYmxlZAooWEVOKSBVc2luZyBzY2hlZHVsZXI6IFNNUCBDcmVkaXQgU2No ZWR1bGVyIHJldjIgKGNyZWRpdDIpCihYRU4pIEluaXRpYWxpemluZyBDcmVkaXQyIHNjaGVkdWxl cgooWEVOKSAgbG9hZF9wcmVjaXNpb25fc2hpZnQ6IDE4CihYRU4pICBsb2FkX3dpbmRvd19zaGlm dDogMzAKKFhFTikgIHVuZGVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogMAooWEVOKSAgb3Zlcmxv YWRfYmFsYW5jZV90b2xlcmFuY2U6IC0zCihYRU4pICBydW5xdWV1ZXMgYXJyYW5nZW1lbnQ6IHNv Y2tldAooWEVOKSAgY2FwIGVuZm9yY2VtZW50IGdyYW51bGFyaXR5OiAxMG1zCihYRU4pIGxvYWQg dHJhY2tpbmcgd2luZG93IGxlbmd0aCAxMDczNzQxODI0IG5zCihYRU4pIFBsYXRmb3JtIHRpbWVy IGlzIDI0LjAwME1IeiBIUEVUCihYRU4pIERldGVjdGVkIDM1MDQuNTIwIE1IeiBwcm9jZXNzb3Iu CihYRU4pIGFsdCB0YWJsZSBmZmZmODJkMDQwNDM5MjkwIC0+IGZmZmY4MmQwNDA0NDQyMzgKKFhF TikgSW50ZWwgVlQtZCBpb21tdSAwIHN1cHBvcnRlZCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdC CihYRU4pIEludGVsIFZULWQgaW9tbXUgMSBzdXBwb3J0ZWQgcGFnZSBzaXplczogNGtCLCAyTUIs IDFHQgooWEVOKSBJbnRlbCBWVC1kIFNub29wIENvbnRyb2wgbm90IGVuYWJsZWQuCihYRU4pIElu dGVsIFZULWQgRG9tMCBETUEgUGFzc3Rocm91Z2ggbm90IGVuYWJsZWQuCihYRU4pIEludGVsIFZU LWQgUXVldWVkIEludmFsaWRhdGlvbiBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1kIEludGVycnVw dCBSZW1hcHBpbmcgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBQb3N0ZWQgSW50ZXJydXB0IG5v dCBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1kIFNoYXJlZCBFUFQgdGFibGVzIGVuYWJsZWQuCihY RU4pIEkvTyB2aXJ0dWFsaXNhdGlvbiBlbmFibGVkCihYRU4pICAtIERvbTAgbW9kZTogUmVsYXhl ZAooWEVOKSBJbnRlcnJ1cHQgcmVtYXBwaW5nIGVuYWJsZWQKKFhFTikgbnJfc29ja2V0czogMQoo WEVOKSBFbmFibGVkIGRpcmVjdGVkIEVPSSB3aXRoIGlvYXBpY19hY2tfb2xkIG9uIQooWEVOKSBF TkFCTElORyBJTy1BUElDIElSUXMKKFhFTikgIC0+IFVzaW5nIG9sZCBBQ0sgbWV0aG9kCihYRU4p IC4uVElNRVI6IHZlY3Rvcj0weEYwIGFwaWMxPTAgcGluMT0yIGFwaWMyPS0xIHBpbjI9LTEKKFhF TikgVFNDIGRlYWRsaW5lIHRpbWVyIGVuYWJsZWQKKFhFTikgQWxsb2NhdGVkIGNvbnNvbGUgcmlu ZyBvZiAxMjggS2lCLgooWEVOKSBtd2FpdC1pZGxlOiBNV0FJVCBzdWJzdGF0ZXM6IDB4MTExNDIx MjAKKFhFTikgbXdhaXQtaWRsZTogdjAuNC4xIG1vZGVsIDB4OWUKKFhFTikgbXdhaXQtaWRsZTog bGFwaWNfdGltZXJfcmVsaWFibGVfc3RhdGVzIDB4ZmZmZmZmZmYKKFhFTikgVk1YOiBTdXBwb3J0 ZWQgYWR2YW5jZWQgZmVhdHVyZXM6CihYRU4pICAtIEFQSUMgTU1JTyBhY2Nlc3MgdmlydHVhbGlz YXRpb24KKFhFTikgIC0gQVBJQyBUUFIgc2hhZG93CihYRU4pICAtIEV4dGVuZGVkIFBhZ2UgVGFi bGVzIChFUFQpCihYRU4pICAtIFZpcnR1YWwtUHJvY2Vzc29yIElkZW50aWZpZXJzIChWUElEKQoo WEVOKSAgLSBWaXJ0dWFsIE5NSQooWEVOKSAgLSBNU1IgZGlyZWN0LWFjY2VzcyBiaXRtYXAKKFhF TikgIC0gVW5yZXN0cmljdGVkIEd1ZXN0CihYRU4pICAtIFZNQ1Mgc2hhZG93aW5nCihYRU4pICAt IFZNIEZ1bmN0aW9ucwooWEVOKSAgLSBWaXJ0dWFsaXNhdGlvbiBFeGNlcHRpb25zCihYRU4pICAt IFBhZ2UgTW9kaWZpY2F0aW9uIExvZ2dpbmcKKFhFTikgSFZNOiBBU0lEcyBlbmFibGVkLgooWEVO KSBWTVg6IERpc2FibGluZyBleGVjdXRhYmxlIEVQVCBzdXBlcnBhZ2VzIGR1ZSB0byBDVkUtMjAx OC0xMjIwNwooWEVOKSBIVk06IFZNWCBlbmFibGVkCihYRU4pIEhWTTogSGFyZHdhcmUgQXNzaXN0 ZWQgUGFnaW5nIChIQVApIGRldGVjdGVkCihYRU4pIEhWTTogSEFQIHBhZ2Ugc2l6ZXM6IDRrQiwg Mk1CLCAxR0IKKFhFTikgYWx0IHRhYmxlIGZmZmY4MmQwNDA0MzkyOTAgLT4gZmZmZjgyZDA0MDQ0 NDIzOAooWEVOKSBCcm91Z2h0IHVwIDEyIENQVXMKKFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0 eTogY3B1LCAxIENQVSBwZXIgc2NoZWQtcmVzb3VyY2UKKFhFTikgQWRkaW5nIGNwdSAwIHRvIHJ1 bnF1ZXVlIDAKKFhFTikgIEZpcnN0IGNwdSBvbiBydW5xdWV1ZSwgYWN0aXZhdGluZwooWEVOKSBB ZGRpbmcgY3B1IDEgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDIgdG8gcnVucXVldWUg MAooWEVOKSBBZGRpbmcgY3B1IDMgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDQgdG8g cnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDUgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcg Y3B1IDYgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDcgdG8gcnVucXVldWUgMAooWEVO KSBBZGRpbmcgY3B1IDggdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDkgdG8gcnVucXVl dWUgMAooWEVOKSBBZGRpbmcgY3B1IDEwIHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSAx MSB0byBydW5xdWV1ZSAwCihYRU4pIG1jaGVja19wb2xsOiBNYWNoaW5lIGNoZWNrIHBvbGxpbmcg dGltZXIgc3RhcnRlZC4KKFhFTikgTlggKEV4ZWN1dGUgRGlzYWJsZSkgcHJvdGVjdGlvbiBhY3Rp dmUKKFhFTikgRG9tMCBoYXMgbWF4aW11bSA5NTIgUElSUXMKKFhFTikgKioqIEJ1aWxkaW5nIGEg UFYgRG9tMCAqKioKKFhFTikgIFhlbiAga2VybmVsOiA2NC1iaXQsIGxzYiwgY29tcGF0MzIKKFhF TikgIERvbTAga2VybmVsOiA2NC1iaXQsIFBBRSwgbHNiLCBwYWRkciAweDEwMDAwMDAgLT4gMHgy ZTJjMDAwCihYRU4pIFBIWVNJQ0FMIE1FTU9SWSBBUlJBTkdFTUVOVDoKKFhFTikgIERvbTAgYWxs b2MuOiAgIDAwMDAwMDA4NTAwMDAwMDAtPjAwMDAwMDA4NTQwMDAwMDAgKDUwNDMxNCBwYWdlcyB0 byBiZSBhbGxvY2F0ZWQpCihYRU4pICBJbml0LiByYW1kaXNrOiAwMDAwMDAwODZkOWZhMDAwLT4w MDAwMDAwODZlN2ZmM2Y2CihYRU4pIFZJUlRVQUwgTUVNT1JZIEFSUkFOR0VNRU5UOgooWEVOKSAg TG9hZGVkIGtlcm5lbDogZmZmZmZmZmY4MTAwMDAwMC0+ZmZmZmZmZmY4MmUyYzAwMAooWEVOKSAg SW5pdC4gcmFtZGlzazogMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg UGh5cy1NYWNoIG1hcDogMDAwMDAwODAwMDAwMDAwMC0+MDAwMDAwODAwMDQwMDAwMAooWEVOKSAg U3RhcnQgaW5mbzogICAgZmZmZmZmZmY4MmUyYzAwMC0+ZmZmZmZmZmY4MmUyYzRiOAooWEVOKSAg WGVuc3RvcmUgcmluZzogMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg Q29uc29sZSByaW5nOiAgMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg UGFnZSB0YWJsZXM6ICAgZmZmZmZmZmY4MmUyZDAwMC0+ZmZmZmZmZmY4MmU0ODAwMAooWEVOKSAg Qm9vdCBzdGFjazogICAgZmZmZmZmZmY4MmU0ODAwMC0+ZmZmZmZmZmY4MmU0OTAwMAooWEVOKSAg VE9UQUw6ICAgICAgICAgZmZmZmZmZmY4MDAwMDAwMC0+ZmZmZmZmZmY4MzAwMDAwMAooWEVOKSAg RU5UUlkgQUREUkVTUzogZmZmZmZmZmY4MmFiNjE2MAooWEVOKSBEb20wIGhhcyBtYXhpbXVtIDQg VkNQVXMKKFhFTikgW1ZULURdaW9tbXVfZW5hYmxlX3RyYW5zbGF0aW9uOiBpb21tdS0+cmVnID0g ZmZmZjgyYzAwMDIxZDAwMAooWEVOKSBbVlQtRF1pb21tdV9lbmFibGVfdHJhbnNsYXRpb246IGlv bW11LT5yZWcgPSBmZmZmODJjMDAwMjFmMDAwCihYRU4pIEluaXRpYWwgbG93IG1lbW9yeSB2aXJx IHRocmVzaG9sZCBzZXQgYXQgMHg0MDAwIHBhZ2VzLgooWEVOKSBTY3J1YmJpbmcgRnJlZSBSQU0g aW4gYmFja2dyb3VuZAooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwKKFhFTikgR3Vlc3QgTG9nbGV2 ZWw6IEFsbAooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioKKFhFTikgQm9vdGVkIG9uIEwxVEYtdnVsbmVyYWJsZSBoYXJkd2FyZSB3aXRoIFNN VC9IeXBlcnRocmVhZGluZwooWEVOKSBlbmFibGVkLiAgUGxlYXNlIGFzc2VzcyB5b3VyIGNvbmZp Z3VyYXRpb24gYW5kIGNob29zZSBhbgooWEVOKSBleHBsaWNpdCAnc210PTxib29sPicgc2V0dGlu Zy4gIFNlZSBYU0EtMjczLgooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioKKFhFTikgQm9vdGVkIG9uIE1MUERTL01GQkRTLXZ1bG5lcmFibGUg aGFyZHdhcmUgd2l0aCBTTVQvSHlwZXJ0aHJlYWRpbmcKKFhFTikgZW5hYmxlZC4gIE1pdGlnYXRp b25zIHdpbGwgbm90IGJlIGZ1bGx5IGVmZmVjdGl2ZS4gIFBsZWFzZQooWEVOKSBjaG9vc2UgYW4g ZXhwbGljaXQgc210PTxib29sPiBzZXR0aW5nLiAgU2VlIFhTQS0yOTcuCihYRU4pICoqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgooWEVOKSAzLi4uIDIu Li4gMS4uLiAKKFhFTikgWGVuIGlzIHJlbGlucXVpc2hpbmcgVkdBIGNvbnNvbGUuCihYRU4pICoq KiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAnQ1RSTC1hJyB0aHJlZSB0aW1lcyB0byBzd2l0 Y2ggaW5wdXQpCihYRU4pIEZyZWVkIDU1MmtCIGluaXQgbWVtb3J5CihYRU4pIFBDSSBhZGQgZGV2 aWNlIDAwMDA6MDA6MDAuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAxLjAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDowMDowMi4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6 MTIuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjE0LjAKKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDowMDoxNC4yCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTYuMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjAwOjE2LjMKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDox Ny4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWIuMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjAwOjFjLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxYy41CihYRU4pIFBD SSBhZGQgZGV2aWNlIDAwMDA6MDA6MWQuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFm LjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxZi40CihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6MDA6MWYuNQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAxOjAwLjAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDowNDowMC4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDU6MDAu MAo= --0000000000007ca26305e2f942ca-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 11:58:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 11:58:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360258.589602 (Exim 4.92) (envelope-from ) id 1o8Kj5-0007m0-0M; Mon, 04 Jul 2022 11:58:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360258.589602; Mon, 04 Jul 2022 11:58:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Kj4-0007lt-TW; Mon, 04 Jul 2022 11:58:50 +0000 Received: by outflank-mailman (input) for mailman id 360258; Mon, 04 Jul 2022 11:58:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Kj3-0007ln-Nf for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 11:58:49 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a962794c-fb90-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 13:58:48 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1o8Kiw-0000tH-DU; Mon, 04 Jul 2022 13:58:42 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a962794c-fb90-11ec-a8e4-439420d8e422 Message-ID: <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> Date: Mon, 4 Jul 2022 13:58:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra Cc: lkml , "xen-devel@lists.xenproject.org" , Thorsten Leemhuis References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> From: Thorsten Leemhuis In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1656935928;6fc7cd1e; X-HE-SMSGID: 1o8Kiw-0000tH-DU On 25.05.22 10:55, Jan Beulich wrote: > On 28.04.2022 16:50, Jan Beulich wrote: >> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >> with pat_enabled()") pat_enabled() returning false (because of PAT >> initialization being suppressed in the absence of MTRRs being announced >> to be available) has become a problem: The i915 driver now fails to >> initialize when running PV on Xen (i915_gem_object_pin_map() is where I >> located the induced failure), and its error handling is flaky enough to >> (at least sometimes) result in a hung system. >> >> Yet even beyond that problem the keying of the use of WC mappings to >> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular >> graphics frame buffer accesses would have been quite a bit less >> performant than possible. >> >> Arrange for the function to return true in such environments, without >> undermining the rest of PAT MSR management logic considering PAT to be >> disabled: Specifically, no writes to the PAT MSR should occur. >> >> For the new boolean to live in .init.data, init_cache_modes() also needs >> moving to .init.text (where it could/should have lived already before). >> >> Signed-off-by: Jan Beulich > > The Linux kernel regression tracker is pestering me because things are > taking so long (effectively quoting him), and alternative proposals > made so far look to have more severe downsides. Has any progress been made with this patch? It afaics is meant to fix this regression, which ideally should have been fixed weeks ago (btw: adding a "Link:" tag pointing to it would be good): https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ According to Juergen it's still needed: https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ Or was a different solution found to fix that regression? Ciao, Thorsten From xen-devel-bounces@lists.xenproject.org Mon Jul 04 12:18:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 12:18:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360275.589612 (Exim 4.92) (envelope-from ) id 1o8L1k-00027P-Vk; Mon, 04 Jul 2022 12:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360275.589612; Mon, 04 Jul 2022 12:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8L1k-00027I-Sg; Mon, 04 Jul 2022 12:18:08 +0000 Received: by outflank-mailman (input) for mailman id 360275; Mon, 04 Jul 2022 12:18:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8L1j-00027C-GS for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 12:18:07 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59ded932-fb93-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 14:18:04 +0200 (CEST) Received: from mail-bn8nam12lp2175.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 08:17:55 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by SJ0PR03MB6873.namprd03.prod.outlook.com (2603:10b6:a03:438::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 12:17:53 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 12:17:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59ded932-fb93-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656937084; h=from:to:subject:date:message-id:mime-version; bh=2OHgIT5EOr7joMDp6S247G2c9MIE15EEPjjCabZTDv4=; b=gsWijfXs4aQ4LLK4rX4wUpoPmzhxBjM6DaMh202Kgezgv8pEyodH8hTF lHaiET5/C3nTqGF40dbXJZjtDmaD9KIWge4jomAvUJ+xwe6omidMo+aYW gAGVkESUoq4Gv2nOVB0evKsTw+wjr++VL0VFv3g7r6eRjKU+0gu7VklB3 M=; X-IronPort-RemoteIP: 104.47.55.175 X-IronPort-MID: 75028812 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:w8jU1qyh9jkyNYEousp6t+cnwyrEfRIJ4+MujC+fZmQN5Y8a5oE1v iFGDjfXfrrIN3ykOIpG3L7G9kgCuMTQndFrTAE9qClmQSMV9JWcCYXDfxmsYirKf5OcRhI+5 J9PO4mYcJ9oHiaN90mgOOCw9HIjjPrVSLaiAYYoVswJqSpMEU/N3jo/y75RbvdUvOWE7yOxV fLa+sfUaQb9im5/azket/+N+Ug35KSqs2sTsAQ0NP0W5wCPy3VNAJwhfqzgdHGQrqu4vwKZq 0Qv6Jnjows1Kj90UovNfo7TKxFMGviIVeS3oiI+t5KK23CunQRvlPdhXBYgQR0P0W/RwIgqk I8lWaGYEm/FAIWdwIzxbDEAe81OFfUuFGjveCXXXWS7liUqQlO0qxlcJBhe0b4wo46bNVpm5 /0AQA3hWzjY7w6ALBBXfcE37igrBJGD0IryIRiMxxmBZRotacirr6kneba0ddr/7yxDNa+2W iYXVdZgRBqRQjlOa0dNNI4zjt+xllPVKxt5+V3A8MLb40CLpOBw+J7EFYOPP/asFYBSlEveo X/a9WPkBB1cLMaY1TeO7nOrgKnIgD//X4URUra/85aGgnXKnjBVVEJQCAb9+Kbk4qK9c4s3x 0g81Scpt6c/smC2SN30RzWzoWKevw5aUN1VewE/wF7QkvCEs1/DboQCZhhwcfAFv90LfmQjy xyFwdDECjUz6KLAHBpx8Z/R91teIxM9PWIEICMJUwYBy93iu50oyALCSM55F6y4hcGzHiv/q xiLqjQzg/ADgMgj1qOn8FSBiDWpzrDFRwg06wGRXWO94xlRY5SsbIilr1Pc6J5oJ4aDT0Kdu 2AEltLY86YFCZiXlwSCRewMGPei4PPtGCXRm0VmAoMJ+DGk+nrldodViBl9KVloNIAcdDbze 0jVkQRL+JpaOnCta7RqZ56wDctsxq/lffznWerTdcFmeYVqeUmM+yQGTVacwnr3mU4wuag6M IWcd4CnCnNyIaFmxzq/Q6Eay60mwgg332aVTpf+pzyl1rqYInyUYbYDLFaKKOs+6cusugLf8 tAZLcKMxxVWT+TWazPSt4UUKDgiBGInCJXBjt1Yf++OPCJrAGgkTfTWxNsJXoV5g+JujurO9 XynckZCzRz0gnivAT6WZ29qcq+pfZd7oX8xJyUqMX6k3GIlbJyw670cbN08erxP3PJkyfl4X vwUYfKKC/5ESinE0zkFZJy7p4tnHDyJiAyAeQm4ajEkdJ9jbwDO4NnpZBTo7ioVSCGwsKMWu Ka83wnWRZ4CQQVKD8vMbv+riVSrshA1mv92XkbOCslefgPr6ocCAzD4i/YsZcJKLRjFySqX0 y6ZBB4Zoa/GpIpd2MPIjKadsoavFcNxG0NbGy/Q6rPeHSXC5W+i3Y9oWf6FZyzAT3jz/Li+Z OJT1Lf3N/hvtF1DqYZ7Hp5gxLgy4NaprLhfpixtGXTXR1WtBKlpLnSP0Y9IrKIl7qFQowK6V UuS5tBfEbqMMcLhVlUWIWINZP6C3PdShT7V4e8dMET+5SlnurGAVC16JR6GzjBaM71xPZINz uIoucpQ4Au64jIgNdyMn2ZZ7GSII3kJVY0os5gbBMngjQ9D4lpHYJrNAzX6yJSRas5QOw8hJ Tr8rK3Ghqpdy1CEd3M2H3XXwcJDjIgDo1ZE1jcqLk+J3NiDmf4z0BxX/hw4Sw1UylNM1OcbE mVnOERvY6SB+zpzhcFYd3CtHwBHFFuS/UmZ42EAlHDdCXKpUGPNBGQnPKCG+0Vx22hGcz5X9 bebkz+9eTnvdcD1mCA1XCZNqvr4UMZ+8SXYmduqAtzDGZQmCRLihqKtfmMOpwHQCMU9nlDcp eJq8eBzboX2LScV5aY8DuGy0rAdSwuNImBYdu1w56MCHWzaezaa1CCHLga6fcYlD/DH/FekC 80oI+pLSwilki2Jq1gzHqULP6NrkNYm4dMDfvXgImtum7GSqBJkoJXM/y7/mWptQtIGucoiL 5z5fjeLAGuWw3BT3XLOxOFcO22ke58Hfgr49Luw/OgDUZkEtYlEY1oy372csmWSLAJh/g+R+ gLED5I61MRnwIVo2oHqQqNKAlzuLcupDbvVtgeur95JcNXDd9/UsB8YoUXmOAIQOqYNX9Nwl vKGt9ufMF75gYvamlvxw/Gpf5SlL+3pNAaLGqob9EVnoBY= IronPort-HdrOrdr: A9a23:I6VptaDtH+uqforlHegvsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+VAssQIb6Km90ci7MDrhHPtOjbX5Uo3SODUO1FHIEGgA1/qr/9SDIVyYygc178 4JHMZD4bbLfDtHZLPBkWyF+qEbsbu6Gc6T5dv2/jNId0VHeqtg5wB2BkKwCUttXjRLApI/Cd 61+tdHjyDIQwVcUu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmj2AsEWT8n+8ZuzY GFqX202kyQiYD09vbu7R6T032Qoqqg9jJ3Pr3CtiHSEESutu/nXvUiZ1TIhkFMnAjm0idQrD CLmWZqAy070QKtQkil5RTqwAXuyzAo9jvrzkKZm2LqpYjjSCs9ENcpv/MsTvNIg3BQxu2U/Z g7rV5xjaAneC/ojWD4/ZzFRhtqnk27rT4rlvMSlWVWVc8bZKVKpYIS8UtJGNNYdRiKnrwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23xdnWx/zUEf2MsD901wg64VWt1B/a DJI65onLZBQosfar98Hv4IRY+tBmnEUXv3QRGvyJTcZdE60l722uHKCe8OlZ2XkbQzveUPsY WEVk9EvmgvfE+rAdGS3fRwg2HwfFk= X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="asc'?scan'208";a="75028812" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=c4brYjPmNSIjUAa1aRh/VzBIrGJbiS8pXGx5HvWWP8UQRnSbdXGnno8igEw6TWawW5rAg4IajJ6+PCrHo5AcSFYRJpC2HCm7LfLNBl7K1VzJxO9NFjiIGM7lKhVUA6cD6ffRDMfowPrtKrjv7Ay8Brvt7JgOb7mD+Mllo6PwFApiJhG8OsX1oM+ChozKaIgJkRsqEe2DUbauqsRqTzxqLucYArH1lDXSEc3Wbm74+pFz5Y6RqJ7IyyrTZXpfczoeqQdNRLOmQV5ky6xxmdTEsfsvNaOPLIDzwMysCdKQUp58NbYjhI6SYW0fwuQsQGLpW1EDLfLRIWE5wHLahN9dWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kGgNf3cEJI4umY9hOvdxmPiYwQu4XkC4TlcL10+VVic=; b=SI7ZJJI3+406JHPU6kMO4AGqCH7xY5Q1kQY10noD5h6mFQkGBvUc/NibHWF9gSID/jXDuHGfcwQO/uX/EnF3kw14kGKiV8109vVVWvIwKkSpIRYf42Os3u15tSXfOyIZNT3gwR8eDyOVnkLraP+djM8MT0vhB6j4XqAslr3mf6VXr38wZ3Bm0WpCM8cOLDjlGSUU3/BZfFxU4gqwUlms8L6Vh3Dcazq3Qr8TwxcEyJ8HQA0F46CiYClFttWRXZCfv3Rb9irfN+S8Q7bTS1K1VUPQ2wOwqLxGnB87KrVDZzBORvY0IStiFDKzK8gfXkkfzB6tDoLBWG1RUMgfR2oSpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kGgNf3cEJI4umY9hOvdxmPiYwQu4XkC4TlcL10+VVic=; b=M9L0AspkP1nYY2+k7uJl2RYfbbWlfuVNUEwVEtFz2GTXh7nhQJugENDzhRt1QFgU7HYK2iY6Ng0g/uQwPrvzqvxQlWlMCNMlHzyxGlpGa+pczYjR26NdfDiG42n56ZrZtqMzcUcbukUGAbTW31uLBpOtLJtXv/ldF/GvugiQ1Kk= From: George Dunlap To: xen-devel , Tamas K Lengyel , "intel-xen@intel.com" , "daniel.kiper@oracle.com" , Roger Pau Monne , Sergey Dyasli , Christopher Clark , Rich Persaud , Kevin Pearson , Juergen Gross , =?utf-8?B?UGF1bCBEdXJyYW50wqA=?= , "Ji, John" , "edgar.iglesias@xilinx.com" , "robin.randhawa@arm.com" , Artem Mygaiev , Matt Spencer , Stewart Hildebrand , Volodymyr Babchuk , Jeff Kubascik , Stefano Stabellini , Julien Grall , Rian Quinn , "Daniel P. Smith" , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLRG91ZyBHb2xkc3RlaW4=?= , George Dunlap , David Woodhouse , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQW1pdCBTaGFo?= , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLVmFyYWQgR2F1dGFt?= , Brian Woods , Robert Townley , Bobby Eshleman , =?utf-8?B?4oCL4oCL4oCL4oCL4oCL4oCL4oCLQ29yZXkgTWlueWFyZA==?= , Olivier Lambert , Andrew Cooper , Ash Wilding , Rahul Singh , =?utf-8?B?UGlvdHIgS3LDs2w=?= , Brendan Kerrigan , "Thierry Laurion (Insurgo)" , Oleksandr Andrushchenko , Oleksandr Tyshchenko , Deepthi , Scott Davis , Ben Boyd , Anthony Perard , Michal Orzel , Zhiming Shen Subject: [ANNOUNCE] Call for agenda items for 7 July Community Call @ 1500 UTC Thread-Topic: [ANNOUNCE] Call for agenda items for 7 July Community Call @ 1500 UTC Thread-Index: AQHYj6AVCd6Yowuo2kqP8Y/E7lhxgQ== Date: Mon, 4 Jul 2022 12:17:52 +0000 Message-ID: <8ACFF8C7-9912-49ED-9FA4-EB46AC5928BF@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e831f9e6-e8c7-4996-ec99-08da5db7382f x-ms-traffictypediagnostic: SJ0PR03MB6873:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: =?us-ascii?Q?eAhlfZr/Qk8D+Iz2RA0VhS2URvzPHelw+xXxndZ0ZFvPj4JDeS8Ub6s0lhWE?= =?us-ascii?Q?q0EDL2bWwyJbzphhh+hkDFS1uUiPaqD9eL3YDmr79p35Br8+WYLLZ6hbt+Qi?= =?us-ascii?Q?ONhMSUXAzAekt8TwApEt3OwT5UDUrKnBt6QxbT0iAN0rIEFVmVajITU6QsU/?= =?us-ascii?Q?EFOGUPJ766RVvZh5wSS15LxGGivxUI43fspI4ANGeLHvphQkzYVAv56x1OPA?= =?us-ascii?Q?uUbUZullqgVoS36MhSpKVbvKjVvjMROgDkZxI0M6bPbaGAxi+VMY37J8CxNu?= =?us-ascii?Q?RQna+4Sx7i2ZUeokIMuP+YT9QdUOUKcp3CyVT/y201WniBZh1SbaNzBsi3Yz?= =?us-ascii?Q?t6oC1tZ8Tem60HoISFhBVqjkBJGGyNJXgsD9mkZGbXt//2ZRiK0ZhxfeYO23?= =?us-ascii?Q?jaxqTHWC3Zf9wHcXbpnBkPT77ROJw6KvXijos0Dskf6bUQZHGQGMbdNmCf/K?= =?us-ascii?Q?1cysA9BCWivk9W16vCQzdl3hC61KmLNrz7kLYYdMPe1ciKTh7YVXgMR5dECa?= =?us-ascii?Q?Vofh+jEcPW9yYgt5JdcTPVnza36+bm1Wz9rhdBK+F2k1Mjhl8J0lEDi3Myof?= =?us-ascii?Q?SDXOeKZqneQGUoVTKQwGUCKbhmzgVjlMfpELtM7Z0F97aAPMQS60KGZLDEch?= =?us-ascii?Q?echY5n1OKMccFoJxfAUXO6UInDHi9qeh0xiz4ftBuyE2Hfr9f3DURfx7sf7e?= =?us-ascii?Q?sQ9LjIvV4oTp3m4KqnB9+JZVwHCY3Oe/DPzX1Dck/bQrIlEa51Q+HlktK7W9?= =?us-ascii?Q?8VnapJoTNEYgGGYLfEW9fQCigKu6ABNePrx4kEWd8mmAgzPJboM+klNBJhtH?= =?us-ascii?Q?aHAj52f13W47y0TOu/SWCPoLN5XE16DrbwKHZs2wIcW+v6W3qS7GORT3LSXH?= =?us-ascii?Q?c/rJ2wGLT4y1SPJTj1LFNWS3NO9gWhAPty/WQzrDjaQviHjIWb9TQROF5nzh?= =?us-ascii?Q?xNkBUxUw0MQqEOW7qJ7s9w=3D=3D?= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(346002)(136003)(396003)(376002)(83380400001)(921005)(2616005)(33656002)(38100700002)(82960400001)(5660300002)(7406005)(36756003)(7416002)(2906002)(186003)(8936002)(86362001)(64756008)(26005)(66446008)(316002)(76116006)(966005)(6512007)(6486002)(478600001)(66946007)(38070700005)(122000001)(91956017)(41300700001)(8676002)(66556008)(6506007)(66476007)(99936003)(110136005)(71200400001)(221023002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NVR2TmhJY1RYa2JEUCtEbis3WjFIOWFveTRMTmZEenhaRGhkTTE3R1NqWHNZ?= =?utf-8?B?OWtqV0ZNc2NRT3Nud3REWkhiR1FpUFZVekFjWG96MUZGWmc1MVVkeXlpeDdB?= =?utf-8?B?dmtYQXU1YjhibXh1LzAzanBaaW5Da25aQU04SlNhQ1JkVTkxUFlZK1dNWThu?= =?utf-8?B?ODhXMllKOG1jTkRJRUF5QmVKMjFkSmM2VHdlSHJJaEhWZlV1VVVQQndVbGk4?= =?utf-8?B?T1dZait3Q1FYY1JhaVBFY0dRcUtJYTFjbFpRWnRmcTFrZHh5Wi9kZ3JlZGw4?= =?utf-8?B?WnFYTG9ydGlPcENreHkzUVh5QjRUR0ttbzh6QXZId3lHN25Gc3lvQi84V2cz?= =?utf-8?B?VXRwWlptL0N1ZlRRWVV5WEZYUTl6YThwL0NNMnJlZ0RJcC9oaGZVSk5yWTIy?= =?utf-8?B?enduRFF3TGswREFna0x0UU5IYm9TbVVWa3VEbXVvbDVPL3NScWE4UFZVMnRo?= =?utf-8?B?dGdPem9pZ2hmM3ZvUC9MTDNDWk1ibjlwbWVNQVhHSzBjbFN5TUg4Q09QUlVL?= =?utf-8?B?Nis3dXVYT2UwR1VVNmUwWm5rVEp1K0lOazd2ckpZV0U3ZituMG5pYkJBSmlX?= =?utf-8?B?Y0dVZmlqcnVWbDJzSEM1ZnhnNGVJTmV2R3JHNWxmRGJaQWMrS3dObDZUYVR4?= =?utf-8?B?STNWZEIvSUwxWXJIUlpBakdNZXF5QVhuaVJKOXplcTg3Tjg4QWhUSFJjTkxy?= =?utf-8?B?VENnQWg5VHdYWHYxcS95dnNkY3pCcFpGNkwrTHhuSjRTOEdmWW5NaUVWZW1v?= =?utf-8?B?aG9KYXlQaitVSEZJNWt0bFFjcXdrYkVXbXVQb2g0YmhIU0w2cUQ2OWV5ejdy?= =?utf-8?B?Y2YwRTUvbkNibVAxbmV3cWJjUWtWbHRYaGxTbjIyWVl3QWZNU0k5empuTkVa?= =?utf-8?B?M0V4QlEwbE1zUy9zenppUkhaOEx2N2dyR2hWdDB3dDJucTJyQ2JJbWxDcjVV?= =?utf-8?B?N1VSbDRCcDZHR1N2Mjh0dWxhNG9qYzZESGJMaE5LeTI1eWZDV1ZrTzVIS0hz?= =?utf-8?B?b0dKM296cGRnVlMzRXQ5MzQrMVhaeUZQYk5nRzVmQUh6ald1MENONDEvUnF4?= =?utf-8?B?cTgyZXU4dWhXbS9FUTdReXpReEM5MGRtdDVYMFY5MklSMHNrQjVuYUlPNUcx?= =?utf-8?B?KzJJZjVhd3h5V3dyZlh5b3ZNb0RnOFFiZS9tbTVNeVgvT0wwUWc3ek1VbTRH?= =?utf-8?B?QTh6d01zNSthbHViUU96MlJSWkZpZUd3NzlCNFR2MkNtSHZkRFhyaUtiREJT?= =?utf-8?B?bDBWYkV1Zk1HYkV5eG5mcFJ0N2lzaXZjMFdzR1pTblVtY1YvaXRMODlNRlJJ?= =?utf-8?B?L3BJTGpuMXQ4WjNTVmlWVEhyTUJaS05IcXYweHNveloxOGFRWTVjb2ZtTzNN?= =?utf-8?B?N1hhNER6RjRYaU5hZGtYNW82d29hdTU5R1g5ZFNWemJXM01hQjI5b2x4K2Ix?= =?utf-8?B?RHpQLy80L0h4Zjd5MGRYKzFMRk5qUVVqS1JyeXhQdzR4bXk5em5RK213Qm5t?= =?utf-8?B?L2gweExueHk5SGVjOHdDMWVESjVQSXJEUjRtT2wrR3ZhYTdjS3JGNVFLcVph?= =?utf-8?B?c3hwNGt2dTlwWk1kMk9WaTdhZFZXNEJWenlzdHNZc2NoWlF5Q2x0YitaQzh3?= =?utf-8?B?a3lqNlVXcTUvRHdKYWJkOUpMK0VwYXYvQW1oT2JKcjdRUk1hdndSNUFiSG51?= =?utf-8?B?QVppTjFPM0JmN2xHSHNFV1ZmMTBMRFFaNk5ScEExVVIrUWY2eWlPOGJvb2lP?= =?utf-8?B?ZHAwNWE5M1pLSWdBNW1pVkVSRFNDdWZpOUs0SHZzYURmTHJiVTlTL25Mc2g1?= =?utf-8?B?L3lwSEwybCswRlMxQ2M4dnhYUXFNbENtYUlUb3pYWDVtSkE2R2RiSE9UYjZh?= =?utf-8?B?VWM1LzdkRTBTN2ttemlSamxtQ205d01saEpUUjZRTEUzK1pSdFZGR3RhQ2Zk?= =?utf-8?B?QmtHYkhXQlY0MU9IaVV4ODRubERQQTNvV1RsWVNRTWdUS2o3cCs1ZkgvZkZt?= =?utf-8?B?RklmWkdOS0F1SFl2SlR4VUFKSFdGRDVaSDIybzBzK1dITmFHYUJibktkMnR2?= =?utf-8?B?a25Ja1M4NkhwMzZ2ZDR4MGpRZENLeHlsbm8yYytZVGhtNTNOSEU2ZUo2Mmpp?= =?utf-8?B?djIxaCtjc0N4M1B5a2pzYnZwdldzc0p1RllPK0lxOGw5Q2h4ZWI2UXpXZnI2?= =?utf-8?B?T3c9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_A1119F59-C042-4E4E-9367-5AD57D2B975E"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e831f9e6-e8c7-4996-ec99-08da5db7382f X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 12:17:52.9253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5faQchYrynocZpYYeT6iPHevWKo0l++eq21FRmNDoxMv8TBBARDpAs2V3R7H5afiuSqXDBEuW2RiUut0JRhR/I22BNVqMJVlRYbvkGq+Gf0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6873 --Apple-Mail=_A1119F59-C042-4E4E-9367-5AD57D2B975E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi all, The proposed agenda is in = https://cryptpad.fr/pad/#/2/pad/edit/HjXEnZCVP3C2Lk16USDiJegJ/ and you = can edit to add items. Alternatively, you can reply to this mail = directly. Agenda items appreciated a few days before the call: please put your = name besides items if you edit the document. Note the following administrative conventions for the call: * Unless, agreed in the pervious meeting otherwise, the call is on the = 1st Thursday of each month at 1600 British Time (either GMT or BST) * I usually send out a meeting reminder a few days before with a = provisional agenda * To allow time to switch between meetings, we'll plan on starting the = agenda at 16:05 sharp. Aim to join by 16:03 if possible to allocate = time to sort out technical difficulties &c * If you want to be CC'ed please add or remove yourself from the = sign-up-sheet at = https://cryptpad.fr/pad/#/2/pad/edit/D9vGzihPxxAOe6RFPz0sRCf+/ Best Regards George =3D=3D Dial-in Information =3D=3D ## Meeting time 15:00 - 16:00 UTC Further International meeting times: = https://www.timeanddate.com/worldclock/meetingdetails.html?year=3D2022&mon= th=3D07&day=3D7&hour=3D15&min=3D0&sec=3D0&p1=3D1234&p2=3D37&p3=3D224&p4=3D= 179 ## Dial in details Web: https://meet.jit.si/XenProjectCommunityCall Dial-in info and pin can be found here: https://meet.jit.si/static/dialInInfo.html?room=3DXenProjectCommunityCall --Apple-Mail=_A1119F59-C042-4E4E-9367-5AD57D2B975E Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLC2m8ACgkQshXHp8eE G+1k4gf+NcsV7OEod4ocbprh9bk11+0uDWJTo+zKIbCWgPdVySaan5JrWeq4EgOY BV/f2HTdt+f5zdPS4EG7mw8OJSvy3jUm4leJb7f3GN3RVU1nmQtuBAXwyF82KZuh 5OgRSmrUNiqiMGSCw0hxM0SF2ZDhqI2jSqZJmh3fW802KwOMJBFEhN2dLo3pNWI1 tlrGJv/QSihscPgHgMPCJdlSfNCX86zmmeQ8RlEjO0xOgsQs3/pgc5KiYHbYm38V 3Zu3RvTz2BK4Jk9QSN3MwlHYHJp/eHLerNj0HlL1GoTr2imjCX2mbuBhPZBUaPyO 31pYJc9mXhuWVixr46xoztep/jHn+Q== =cr7R -----END PGP SIGNATURE----- --Apple-Mail=_A1119F59-C042-4E4E-9367-5AD57D2B975E-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 12:27:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 12:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360282.589624 (Exim 4.92) (envelope-from ) id 1o8LAQ-0003ff-Qc; Mon, 04 Jul 2022 12:27:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360282.589624; Mon, 04 Jul 2022 12:27:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LAQ-0003fY-Mp; Mon, 04 Jul 2022 12:27:06 +0000 Received: by outflank-mailman (input) for mailman id 360282; Mon, 04 Jul 2022 12:27:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LAO-0003fS-N7 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 12:27:04 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20063.outbound.protection.outlook.com [40.107.2.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9bd57274-fb94-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 14:27:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6587.eurprd04.prod.outlook.com (2603:10a6:10:102::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 12:27:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 12:27:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bd57274-fb94-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jL1xD+RgkzZ3N5+eq+xJew5Y35dDxHHs0BMZXYRQnETQMBIZhJvxwrlgDYisroRauafd1kzbNUUlANPGmG4ohOPJOUmAazWtOwmnc6Qziory3zOe2fAAICIjubN85rLKoPDUvXe9UipmzeT3IP2HL6HN1zOKLMmKGBRm0K202L1Mb9cMWCz9xr23OJ1jvRqrzW9LifRYlNL5GhV6YRP0L2tkaySCo3tJiXawAF9qZRoZ1Of0Q0DWxA1IM2oBeEj36N9JmFzfnHHPI4XRMtZXbPwNZwm3fZmiGQvBAJfjy8pr4ew3K7YWodiYXAZEEVEDJQ/EB4g74dz6smceSaXLBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kid1033QQrIthfLb7SVwuwoG4BCUlo5GogjFjDjme+4=; b=QBWdECX+akZ4JNLrWeGHunsUkWHJGG7hbnXCRFuIhL44M3VtiLEWg7hPGd2ramT174Q2nzHvgHa0RW1/KkD3rYx7x9pxu4LVbOWJfeVuKdHPGjTi0cAuD9YhvADNYanCS3xEnpPRPPARytyVimbxksq5y12B6ss1L4OCtVCbVnk4sCAUEviTcIM3PCIIu6MpZrJL7BuuMmtECmoFqrNYCEBUGRoQ90QXUgHtFnXlf+0dGr4FfDxdpCUFLWijSMmktMBmAJtwV54Mp8b0c70XAz6MJJqyMrqcQabda3L2HImL97LJd+G/MK5lYgQ0AV/oRJw4a79z0GvSjtSWNuEoKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kid1033QQrIthfLb7SVwuwoG4BCUlo5GogjFjDjme+4=; b=oVqO3VhEQMRnZzoJNQ1v6dIK96o2GjWkCKRx5jneWLaTKYovLVfmxO/UHI6WCO/6m6DVqwGIRmY//B9DzS444t10aEmmPi7WNVF28w9j8lHrn5ZAfbelkRNqXkywv+VLvtk0r1J6JliwSaFVNSILnG9vYaqBGqTaCJ/AfPD0rJeFdR0LxQkWR2znXDkuIIbGNLsCsPpCCQuox1HSc3gVC2rHVkmYkjV0QgUDXZKG0sdSw4LwoB4lj/qq/6LTGItBg7+O7DTgpX05qsY23nFMxE/uKOwHKnwOAsg7CDa4mbG68/Tq0zdx3aDojrBMDLmXlLAYBojglc7I9+8iZbm1/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> Date: Mon, 4 Jul 2022 14:26:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Thorsten Leemhuis Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> From: Jan Beulich In-Reply-To: <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0108.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::49) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aa361a88-6d63-4155-58e0-08da5db87e5c X-MS-TrafficTypeDiagnostic: DB8PR04MB6587:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K7+jQA4Kqs7FHuygTeG5wXoS1wo64rzJkLwn9zetbVAEbo/VWOXc4HwTgXUc1bjV53rXsUBU6qAqBDPGbPWI8Rt1nUV/MB/VSbROaqlAuXSjBt2n33S+Psq/FvI8fmsaSix7w7BXs0+3Xm+EPLkZfIoUYQtW5vjH4Wc69N//nMBiF83gZH6fKewawjrwEXvel+u9te8XQVAuH9LWzQ0ViH4tHySvPwZMnqlYBruN3rMC3vjAyErwcFRhLHlvCxvRhTPTSuFIW/dyaG1Nm4TxDcDfCx/33fNWdFYz02faEDs/MkuIX5axvrT9oivVpw02kN075qLlA6wfD8Ycu8Zaaf+E8zC9lOHRUkJj2bbGdvoS1sSLFOnbcHULZWT6owoHQJ+4iIXhyf4V6LHbS8QFr7NA6E5xZZDeyDarVIKO4Ji5ZJiE/zpJmAV6b6dCHzUiCPKuQExq+xDOyOPKzOxn9bSuNx726QTl8vLfsYQ1rJFsYegJEScCDWT64lzPRqNhd2jpwZJsWPac7DvAQkjxW+3UhliG6yYq9UlvFCEieLAj2bzwPCkNNVVaKCitj2GfD+63WO6blAqEhWmDUGYpZ5tkWhc9sN3r/WAUIifHOEbCDLA/Z/2gBGqK8H2c+63jRB9CqeDXVp/nwx9Rn87Vz5YhEXm/QL3oIcyXyN6uP3HNT2jiE7gEEAu6EmjEKWRPamgRcls99dC9dKVDSdl0QyKTTN/9362Jep3jzVMFHyS6kaZ1vIKFhHTjZ2C9b7HDfMzIcUtlOpubGCQRvjrK0sua/uXGgeFBLdLHkCD5N8wJVwFDZylwgee6Gvf/peyFM1RxbfKVr9Pp/VmLGQZgiIS3lETVnMcknCdRChl6wKEEvrc7tDTEI4z4AFAaBUu+jqYOX6QCMHJmkAjo9hP6LlOGbWqikYOta8mIEgQsd8A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(346002)(396003)(39860400002)(376002)(83380400001)(478600001)(2906002)(6486002)(31696002)(38100700002)(86362001)(966005)(6506007)(2616005)(6512007)(41300700001)(53546011)(66946007)(26005)(316002)(36756003)(8676002)(5660300002)(8936002)(6916009)(31686004)(66476007)(54906003)(4326008)(66556008)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bFEyTjRJNVBKTDZZamo2RTE4QTBrZnRxcmw3M2dWenJuZ016d25JZzBQa0Yz?= =?utf-8?B?M2c0dXBiQndYUVphWlB1bk5PQ2UwN09zTGQrbG9RWVJPMnRFTWNUUTUweVpo?= =?utf-8?B?azgxSjNsQldBRWFtL3pXenhBei94Z1N3YzZoaklHcVRtNkhMZEYxUXlvZE5I?= =?utf-8?B?TDc4VE5VOUd0V0tNZjRxSTVWZStyRWU5d2JzTlhyZjU5blducTJKRmVrQk53?= =?utf-8?B?cjNyUTJBRzBDWXUzSmlGOU5rMVE3SVRPdU1pcHIzUXRYdE1mQWJxVUdybGl0?= =?utf-8?B?NTVaYUx6OGQySUdjODNXV2FReXJuelRoWlQvYnlWK3lVRDZxalVMZHBXZy9N?= =?utf-8?B?anZTMGNYd3dBNDBxSjBrRHBPVVJObk5IeHN2V0I2bkFsUUdqc0xUMTNrYXU2?= =?utf-8?B?Q1ZIdkdHRVNlZlg0NCtkTzB5WFoyclRjSjROSjhHZ1ExT3JHbFVPSXBRQk9s?= =?utf-8?B?amR6U2VpUGhlSERnK3hpNkVNWm9saGVxN0RCWXFCa1h5ZnZRalIybTJ6OWR0?= =?utf-8?B?eS84UXhwYktibTh0L3FmL3RxeWtSOEV0S0ZJUk82SGg2OUw3ZVZ4Q3R5SkVm?= =?utf-8?B?eWpwN2F2OXBZVFk1U1ZYZ1ppUFFDWmJmOG9lOHNNby9CWFM1YWpQMzRKSlVP?= =?utf-8?B?Tll5VUt1bjJzL1NWcWNDZlVnU2pIeU5hL0QvTWMzMytvRWlNUzdWVjlMdU1X?= =?utf-8?B?aWpFVW40UmZGMDVnbm5OS0VraTJ5THZCRkpoQmw5MlVHVExyRENLNXlYeDl2?= =?utf-8?B?NEJUd3JrV2JXRHFlMDE2cHZEd2NDdWxIUmJrWE5IS09qUHdUSEJxNmVWdVFz?= =?utf-8?B?dG10R0s3aXdvUXpQSDBlUElBQ09pV3VWN25MaWxQVEhJQUY1OWNLNjJjUFdE?= =?utf-8?B?cExqUjBRY2NFak1qcnY0TEFTSlVFaDk5eXVCcXowOVlHSXVBNS9xM2RZVEJi?= =?utf-8?B?K0hNWFluWVRhU1VabDd2VXQvOWx6UmR4cjZzdUpVb2VXU2FRTHdQYVI1SWt6?= =?utf-8?B?d0VDdHNQUjhPb1kxL2lJVXI2QkgvM3pxSDl2MzMxWXFzQ29aRExHTjVab2Vi?= =?utf-8?B?MmFIM0JtdlVuZHVVY2F4ZFFMbmdKSHZTMmhOK2F2aHFYT0lDeDhoMjB5K2wv?= =?utf-8?B?VEJzK0xIZmYwd2hZY1JvTktya3dyekZqRU96cFVENEtQOHFwMEdUSmFGL0Jr?= =?utf-8?B?SFFXWkdPNmhqbnBsK2o5djJSR2g2Rk91d3cyK3R2SlJZQ1JvOHlRdktoY0ZX?= =?utf-8?B?WG83bHZqWEdWbTdBSlBtcVFnNnI5b3k3R2FiZXpPSmlxSEdsc2VNMW5FQ3dL?= =?utf-8?B?RENxUEdTSUppcEp4T3l2cEl5YTZURlBQc1VxK3hDai9JTGFpWkdNUXdmcVFH?= =?utf-8?B?TGUzUllHbWNQOTl3Skl3Y0FKa05raUhhQ25pM2pUWkxEN092RTlpRGlHcWZT?= =?utf-8?B?cDVub2cyNkdSQXB3OVJURU9wZnRKYTJ2RzhxRlUrNWJyVUhKMEdzVFA1SVl6?= =?utf-8?B?NHRxazNDSlZxTGhSTFQvcG9YZkdPRFY0KzBsUzhWeVRnRDc2ZGM4T2lRREZ2?= =?utf-8?B?bnVwUW5yN09Ya1FmMWtUdWFQWENwZlBnYTNScFA5eWJqUFBJN3dTS0llQTRY?= =?utf-8?B?OXZiU3BET0l5dDMwRXJUam1wYVJvMTRjWGU3WXZ3bzZzT0prRHQvREo5RFp6?= =?utf-8?B?SytJQjlvc0Q3bXlmTmhQSGFiZUcvMWNKOTVPd2tuVDB1c0MzRllnd2tBU3N6?= =?utf-8?B?bEIzd0VQb2dJOUFlNDcyNi9Rci9yd1Z1OW5Ua29Rc2hvNStOMmZXL1U1QXA0?= =?utf-8?B?ZFAyMnhtNTcwc1k0ZC9FYlhoWTJPTURwQ083ZHhCbUlIbFlhYlg5d0VZWWtQ?= =?utf-8?B?K014eUs4WHRJUFpJWmhQSEFxVGwrQXZBRjZ5Qi9UbjFqZjhJSlBxeEdIVnV2?= =?utf-8?B?TXJ4WmdRZWtaNm96akE0Tm9OK09SV2FPRlhJdVlKYjcwamRWdkU4V3RZdW1m?= =?utf-8?B?UmJGZmZRTVNzQm9ER1FHY2RSMGxETSt0RkgwRWZlVzFvRjhGSDdpZWlxd3Aw?= =?utf-8?B?Um8rUWpYS0hBcm5Pc0lndW9PdXRzc3dQQ3k3enJUc0tockNlYURqRS9UTEFl?= =?utf-8?Q?juQ7EtSFTefjb+Ko2KhIcfoN0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aa361a88-6d63-4155-58e0-08da5db87e5c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 12:27:00.3724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: haOWeRXVee4Efk5OtpaTgf7Qj4vIzhEe45l7hOVWZnbgl9jpoNWrBMcHJ9+MotlMwL0yRLqDR7SZyPAmCajwwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6587 On 04.07.2022 13:58, Thorsten Leemhuis wrote: > On 25.05.22 10:55, Jan Beulich wrote: >> On 28.04.2022 16:50, Jan Beulich wrote: >>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >>> with pat_enabled()") pat_enabled() returning false (because of PAT >>> initialization being suppressed in the absence of MTRRs being announced >>> to be available) has become a problem: The i915 driver now fails to >>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I >>> located the induced failure), and its error handling is flaky enough to >>> (at least sometimes) result in a hung system. >>> >>> Yet even beyond that problem the keying of the use of WC mappings to >>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular >>> graphics frame buffer accesses would have been quite a bit less >>> performant than possible. >>> >>> Arrange for the function to return true in such environments, without >>> undermining the rest of PAT MSR management logic considering PAT to be >>> disabled: Specifically, no writes to the PAT MSR should occur. >>> >>> For the new boolean to live in .init.data, init_cache_modes() also needs >>> moving to .init.text (where it could/should have lived already before). >>> >>> Signed-off-by: Jan Beulich >> >> The Linux kernel regression tracker is pestering me because things are >> taking so long (effectively quoting him), and alternative proposals >> made so far look to have more severe downsides. > > Has any progress been made with this patch? It afaics is meant to fix > this regression, which ideally should have been fixed weeks ago (btw: > adding a "Link:" tag pointing to it would be good): > https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > According to Juergen it's still needed: > https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > Or was a different solution found to fix that regression? No progress and no alternatives I'm aware of. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 12:28:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 12:28:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360293.589644 (Exim 4.92) (envelope-from ) id 1o8LC6-0004Qt-Im; Mon, 04 Jul 2022 12:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360293.589644; Mon, 04 Jul 2022 12:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LC6-0004PZ-B7; Mon, 04 Jul 2022 12:28:50 +0000 Received: by outflank-mailman (input) for mailman id 360293; Mon, 04 Jul 2022 12:28:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LC5-0004M3-4r for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 12:28:49 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50068.outbound.protection.outlook.com [40.107.5.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d91dc2cd-fb94-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 14:28:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4584.eurprd04.prod.outlook.com (2603:10a6:20b:1e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 12:28:43 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 12:28:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d91dc2cd-fb94-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nh1Q1Z8w1K1Ut7LQEIVzHCfAcU3HtJYeYnAkr/Fpd7nwIL2Ejzbo66FibI031d4JCkV8Qw1SMLiEJtsjdaV4TV2qAZNx886JwAuK6so6yjWemR0gRGKA+DQawjXYnTdH02Vjqa1oYL/9MGHc1OnElsbFqOFTZSLjDGht6Vb+EaxldLnDPGai+arrR+7RSV+6RSXOR7/AM5+05daly04UFboQXcxGF1/TLKEBzLO92LOwweSvWi8vDLlj6sTWzFTXhYfiqex8PscTaD3kNMYxWmg90iAl+lGLiwEzgJ3v+z0aCGem2fq+uIWnPDcDsXPxP5cTyp6LHanyManr+HS9pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+LMQryx6+Vqw5VBJ427jcXgxoq/JE/VqVcEIiUlQt9w=; b=eENYFcfRUdj0g2aXHxG5Nz+yDpfpKSRgLF7DSTDBQJkkZenELPw/mdDazmIbgQx2La2ZQvTbFuKYUyoOpHEh1ENVYfcA+ABZ/ZZytEJdVMr82X/1ZZs6+aJqWlChEB1Ft4Uiz2PxhylkXh39I99/v+zUtkrErnFUTDDS/gmtNy4IF83cTcUWyhABXDWg687Sl2uiIbDWPshjhOo3w7X85tE4jd1K3PYIjxlM9NMVIkRszXajEafSE6xsn/kpsSNVVc0cJM4LigJGeKPVoI5+VpM7w90dPkBc19cjNv2ce8PDj9MfSSwahlJAlxwz5ZTt77AfML5fwkFkKHe/pK5kQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+LMQryx6+Vqw5VBJ427jcXgxoq/JE/VqVcEIiUlQt9w=; b=ri+aY4IVNzWO9fzqUliW0h9N06O6kdhkdId3UKfeNrD4a17KoqHcw+D9Qi7HMtbg1FHZNwCg9XsRaDB0nKlEI8DwdqzN8r+rIWEqoCzb6nY5gio3OwDHcGOoLXhLVh68uerVVzgBBj+pQex1gvgMWFDp9UILZGFAJNEGqWGOBc7doDz3xRfsF+Vrqra6b5c83IVdu0+0EXJZ1kItlUHc2Qa5ndYK8yy4qpU/thv9JtwPTVhruwImxR42DlERUf9nQrP5Bi7QwiR9iLPC4tEYgvoVlQuybS4P2ne5ol9FrCHPOz24oDve73r5icXQqv7lmCZzwtZLypJT48Kt56qtcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1e18d0bd-cc82-9fb9-f106-ca06a152d2cb@suse.com> Date: Mon, 4 Jul 2022 14:28:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: Xen 4.15.3 released To: xen-announce@lists.xenproject.org Cc: "xen-devel@lists.xenproject.org" Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0136.eurprd06.prod.outlook.com (2603:10a6:20b:467::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9bc45de-c20e-441c-b7be-08da5db8bbf6 X-MS-TrafficTypeDiagnostic: AM6PR04MB4584:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I1rAbtXAxvM8j6YaFbbUVmKU1u7vKjhMre9J9djhoHA0+byU6H0VIiOlRoe/DASX8ilklxpDZrg1X/qwVuxNvBYWCWBL/RTOBbgij4v3wcNN6kACDK89qrfGUIeQeIHG4Nscm0vCnIRAN+Sab0TX0Lsud9XKLfm5Nmuocg1jsdaFq5QZs8BFWg6Ri9ahXUrdm5JPUQ2iDmDhSv2VOUsA9NLrVYNRdmPitXR0DCcTXfk2BdOu2VNZl+8d6U0mztiCynbY0y3TuBtw8ZPafSO0Ur6lKcneFJZh8DAxulxDB2nsfECvTZ/vAZMe8YmzsV1gqM/xJnAxsx2Gpzt9H7vePT/3Sbx9fhtPejFthWcGBTwmuucxLX0FyUSQ9GsTm1w1A1z4BfdGqPe2iLodnyV0L67JOa2dAC4gp49UpuwVa2wXa45A1eJ8ukD7bCwbTC4QI3aYcjJFrj/L9cCb+PT4OI2o+cTHGHwos6MqJ16947pcgQh03FHIstZ30L5Ef9t1Wf6djeLOARB8xKgPTljda0fSkj6uvBagqwHdwXUZj/XUP/1Q6nOApZjg7nBrFaSrZ6ZEp0Om1ccMgbrzpsFa2FNKmrsL0ibWDn6T83i1ebWkGnUL8yKOgv2nAN3Cmnr9UuP3Zn+xwdF616wmlY3URO7N9ZzqHJBaBpW9FO0YwGEpYfSUt0KHPAxwZtZwHcoWI+5mLRiMOc/tjFZPtmCieIbu5YW6uxzqpG2Cd9pN2Imp6EF8kgF3yTTMnIL9rTbwjQmclX1rGNgu9ptqIYkd5sQVpyCGTbpylnolKvtEsq9XqnqqMaSvmfazKLVpT00RRhXLiQFt5ZmxTMdlxWMdIfJ7vI+fEjxFXESFUx2El7vk7kK7DHQK0KMkE6iOAVzI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(346002)(39860400002)(396003)(376002)(38100700002)(7116003)(66556008)(66476007)(8676002)(4326008)(66946007)(450100002)(316002)(86362001)(31696002)(6916009)(5660300002)(31686004)(2616005)(966005)(6486002)(41300700001)(2906002)(478600001)(8936002)(36756003)(4744005)(6506007)(186003)(83380400001)(6512007)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkpWMUFIa0lXRGI3bDhQanpoVjhvVGhWcWRPNWhDTGV6em1sZ2VVN3lsMExC?= =?utf-8?B?ZVBTMHB1UWJ6eHB5WEEwdXZSNUhNT2pNNHZ5djhFMlRTSXZWVlV5L2Z5Y3M3?= =?utf-8?B?QzRwLzRWQ0pMU2hrRCtrQVhPK0RXbUUzWER3L2svcytwZEZZcmVBU3hLdEtl?= =?utf-8?B?cVdXcmIvWHdFNGU3VUpnWk9QYnd5UDNnUEJQSkwzbUh1N1hwZEI2ajVhUlFj?= =?utf-8?B?aGdBaUpXZVhaSlVvYmZQMmxMVTAwWHlBbzdwN3N1R28rT29mSzFiTHkyWGdh?= =?utf-8?B?TlA0RkdHOWhaREhmUzB4UVBNa1RMZm9ucUtKRWUrR1ZkM1BnZDY2MXpuR3hp?= =?utf-8?B?VmliYWZ1di9aZEpqVTBTcmU0RC9iNHpCZXA3cGQwQml5WmxRNFRmOHBBTVFv?= =?utf-8?B?WGNOcTJzNWdrWUlDWC9nM1dndGtxc24xMmM3aCtlUmFRcHJUVVI2bDF5ZkRq?= =?utf-8?B?ZnFIeHY4V2ZHc3k1RXc4c3FxN21jd3hEeFZGL3JHdjdQTXdURk5tNExVZTh6?= =?utf-8?B?SnhyYXRkMHpPQWEyeW8xY3Z5ZE9JTUhGaE1waHROMWRjRHUyT3lMUEVyR3I0?= =?utf-8?B?TGJQeXFHb3V5aTNyVWd0NXZVdElYSVN1bGVxQWx6ZGpsblpFVUd0aEpZSFdS?= =?utf-8?B?QWpESHFoWmFxZmJaaTZNNldjTkdsVVJFSG50amZSRFlFb0VkUDFpbllEUVJD?= =?utf-8?B?bG5haHc1V1lHSFNncEtEMjlNWTZRTFZsVkxzb2VFRFEwZSt3aXlJN0c3OGNY?= =?utf-8?B?VUFCaTJIMExxZHpBNlc3M09MU05RR1VOUTNyUlV0UEdxYmVReVBMMEtSQ0hv?= =?utf-8?B?bzhCZWFaQ0FPdFhMNThHTFRrTnZ5bGFYalMvcldpV2xhOTM2RmZYYm5uTGhG?= =?utf-8?B?cU1KVmcySlZCS1hpWHVOU2ZTOThPaXVUL1hqcnlFUjcyQ1dqVFVycml0VUFs?= =?utf-8?B?V3dKbmhnZnpQam4yY2s2bUMrOE1mK0JPRUxSd3NaazQ3K3EycGxpcW1HNlJE?= =?utf-8?B?SWlGd3VJVm1nL3EyUm51YnJZbVN5RXJaRWdLeHUySlBodkxWSEJwdUZKNnpK?= =?utf-8?B?b3RVYUlHS24raGEzNlBLMVkrVURLVFRqRG5Qa1RFVi83MWFQLzUxRVRzZmIw?= =?utf-8?B?ZE55WWZwVXRjUDkzUTFuZ2s3LzRYMzYzUFpPME5YTW9UdGtnT3AvRHRxOGUy?= =?utf-8?B?RFBtNTBiMjdxeTJjSnE5ZzlnelJnL1Y1SXpiYVlCc1ZXU3FncEN3N3hJUEpj?= =?utf-8?B?VkQ5eUdZWmM3bEQ1NTJwMUV2cjIwU3Y2NDl0MVVGaHFYTVR1YnhIclBTRUxS?= =?utf-8?B?VUIvSHdrNll3ZFo2cEJKbU5qRDdMTjlPRlpuMldOZUp4b1E3ZUNwMmMwZ3pN?= =?utf-8?B?WjQyYzVuVzhMYTFxUTVCaThrZWdlbkJQdElIKzdRVFVYdndrNllhdFd0SnVx?= =?utf-8?B?cVlsZ052OHdJMlZndkpaMkNoN0RlbWJDWExPY2tXWlA5NmtieUh1S0pEa1No?= =?utf-8?B?VmdBUlFBS25jeHlHK3c2NSsvM3I4UW9jNGtzWVcyOGtLb296NGw1QXJQRmE0?= =?utf-8?B?ZXcvcGo3SkZiZ1VwOU52bHJscHRaWUVYMzJoRE5MWFJyYmVhUGhJTlRxN25U?= =?utf-8?B?YU1aa1dqenRicldkOU13SXlua0ZKMVBhaWc5RERPZHRYNmdtZk16YXVldEpy?= =?utf-8?B?TkVxZGI0UmMxY3cwekxRcEcwNGE3MEtDUVRydnpLZmc5ZEovMTV3OFhHSEor?= =?utf-8?B?MUtHM2pTQlNQZExXREV1S3lEYlVkM1NldFpCV01HNkZZbDhENDFUd3JPMFho?= =?utf-8?B?bXNrK0NyY0xIQ08yM2Fxd0FqN01CVXkwNXNsWG0vemxQVnNQL3M2MWlJOHVt?= =?utf-8?B?ZUNhay9tYU5ZY2lqLzNOWGZ6clZIVXdiVTBCVFRkejFoVTJ4dVJiVzVwRTRH?= =?utf-8?B?WHFyNzJKU1NtRXNlMCs1c3ZrcS9RT2grMndtY0svMFhCYWhBM2FncnM0UTdh?= =?utf-8?B?bVFtbndNSnN5M1VMWWZXdnpoQjJUYmovcXQ4d0ZpTUtBc1RTVWV0aTY4cVJs?= =?utf-8?B?TXpqTm1FTmsrOUJYNlpmeXBQakVUYjlob0RwejBKNVdicnVrd3JnYWxDYytD?= =?utf-8?Q?jntfKzre5w0T8v14CkvZqObDT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9bc45de-c20e-441c-b7be-08da5db8bbf6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 12:28:43.6939 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nqNRbUJA7jsHG2Ne5z2vC0TwavXyGHuyymjok82Odb6GfpZV2jFCZjHMR3cWvMNyCB2LZzvBnApJoEQGTTLVnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4584 All, we're pleased to announce the release of Xen 4.15.3. This is available immediately from its git repository http://xenbits.xen.org/gitweb/?p=xen.git;a=shortlog;h=refs/heads/stable-4.15 (tag RELEASE-4.15.3) or from the XenProject download page https://xenproject.org/downloads/xen-project-archives/xen-project-4-15-series/xen-project-4-15-3/ (where a list of changes can also be found). We recommend all users of the 4.15 stable series to update to this latest point release. Regards, Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 12:36:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 12:36:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360329.589666 (Exim 4.92) (envelope-from ) id 1o8LJE-0006jA-FF; Mon, 04 Jul 2022 12:36:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360329.589666; Mon, 04 Jul 2022 12:36:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LJE-0006j3-9a; Mon, 04 Jul 2022 12:36:12 +0000 Received: by outflank-mailman (input) for mailman id 360329; Mon, 04 Jul 2022 12:36:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LJC-0006i6-Ed for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 12:36:10 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e1919adf-fb95-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 14:36:09 +0200 (CEST) Received: from DB9PR05CA0023.eurprd05.prod.outlook.com (2603:10a6:10:1da::28) by VI1PR08MB3598.eurprd08.prod.outlook.com (2603:10a6:803:7a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 12:35:51 +0000 Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::f7) by DB9PR05CA0023.outlook.office365.com (2603:10a6:10:1da::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Mon, 4 Jul 2022 12:35:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 12:35:50 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Mon, 04 Jul 2022 12:35:50 +0000 Received: from 4283c43f9d00.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FBDCAB56-753C-44AE-A565-CEAC7C60291D.1; Mon, 04 Jul 2022 12:35:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4283c43f9d00.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 12:35:44 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB3058.eurprd08.prod.outlook.com (2603:10a6:208:5a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 12:35:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Mon, 4 Jul 2022 12:35:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1919adf-fb95-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=C8Kh2iuDrVE+esE6djcoOBUElGQdYRBDWajcLOqOLJmU3zOevMi/t5dBY2pBGtXhpjRI5xEjfRSV022duWGVFu0DD1zOif+zAnUxKovr2Exz6cbbv23BNfMH23+6y3fuG08tLOxO1oxln5CSKrLc+9yP5QraKYJ7TkkfYKU2VuUDOxeENexYfa1pNpxsdc7xCYBH1xoBMPhHAcgzIYsY2UK7uJvlT0ciQrdCrehREND4INJOfOCqqEiqz0gIZWChBj9Rcx2osPjc6cqGFghBNGMTPxYVX2JZCA4VIhJMUlDOQ5dMUMkkF5am1ElWwyHLRB43BP3VMnfHW83fMnFErA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=MqSDkpd2FKE1KekZZ70q1wqa6tjAouOVpRPG+QAHZgywq5R5bxr02+E+xaBhrbFH4Ft9wA12RjojjNbtuAsToX2MZmEGi30NL86/BVuH0bQKfAMg8LuzuUEa1raSsO2A2nNvfb2+FwKGOVlhAvcG+mVCwO1/GkXcbZz2/679XT72NnFDVVcJOSQq0hU3WF0xKRE6cVZFUwQGKqKqa4Vn1j7/hIFSM3kJMbr6xLJHImEtocoCJcF2wDGZOYkhPMwxRpOVK6jI3A9mJ51uyGLQkmxYsW/PIpOFWjhSVTVAx4nu+FMOvg+AhbJkjhwLRG88f4uORlMBKpABpXyK3uUFPA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=LUdPj4Q/IFINACb7vahOdXBXYZ/GBOe3qLt+pGtJIWwggc6DIUbjTxIULUHbVQ1p3tXF59DCWMWoJiYgrjJrakAf2f4Iu9hQaXxWEZ0jPTn/phHRVfVTez1FDJ/aicVm01jJP+UuxT9m0XZ+EYun4AZBGU7T718UJq6Zd8OU0O0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5788fe92432cdada X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SiCcCnGv+y8rLAshEi0QkRwsiyASaINd9TXTgj39ulCcwyA8YvaPsffObkebwnT1Nrh9MVxse8WYDEMgKMbL3WqEsaCLjEOVvg8Yx/gm2+HKZOXG1fNoSDt0dwh66m5ezwn9ECw+zheCsXPLn/8aITwnjwllDL1ZWv4dVftxmPVsr2ovCA5f3BJi3VNz/yEkJ3JnaXPVK/Y26vuHNOH/lGvYKjoT1BC6jRCs9bzV9uSvX6z5O3j/FDLBigLMwn83HCGF9KFqL9KWd/ASU3MzevnWw/iv99To86vZbsNSPYbL5PCIXasjd0Kfex8/FICrdrZo+Ddj5UERtg9X7mqDFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=KyCnERSVSno58Smqr97lUPunjmujmzfOvBaCKBJHiDttuyN/8EwFU7VxdJZp2EgNPtTYoItWxt9RZSBBDEqYqBKTjFfd8U6pKibF6Prz1ZTyZmZ6l+G+yGmbJonNE5VtSoRdnxDZx3gmdUiLhuixjwekvJdwXeDO/ztAtOvM1TkXuFUd4Q6/NHPAJSIVz8ne2ch6MVUZPtnXH/hF92VEF7nIJnNPFPkYkcJKFxWnCe3n7QHi5HMa76breYWRtVLVlpP6wPzJSMDLlMWfbBN/aMTKNMuUiU/UAsIBAg1CSyBEhBshL89yXQLlAbEEaK5AgPEYbdACtUEA2f1GDRy80A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WwVmXhjQUYqEw3iucK0gBCn2de2fsddfDRRY3Msm62Q=; b=LUdPj4Q/IFINACb7vahOdXBXYZ/GBOe3qLt+pGtJIWwggc6DIUbjTxIULUHbVQ1p3tXF59DCWMWoJiYgrjJrakAf2f4Iu9hQaXxWEZ0jPTn/phHRVfVTez1FDJ/aicVm01jJP+UuxT9m0XZ+EYun4AZBGU7T718UJq6Zd8OU0O0= From: Bertrand Marquis To: Julien Grall CC: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings() Thread-Topic: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings() Thread-Index: AQHYh6p2Vro/QJFr+UKIGJC/olafua1uNcwA Date: Mon, 4 Jul 2022 12:35:39 +0000 Message-ID: <5CD19BFD-62C6-4409-A5A9-675D8F5FF795@arm.com> References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-5-julien@xen.org> In-Reply-To: <20220624091146.35716-5-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 37c11192-e252-445e-9d2b-08da5db9baa8 x-ms-traffictypediagnostic: AM0PR08MB3058:EE_|DBAEUR03FT042:EE_|VI1PR08MB3598:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: H1j1s5Xzdr8rmB36Ftvf4MxE8JZr7OpzdHNtIXn3eHYfLkii/u5aAWWsKmTXDCpB+MPGaI8ZfowCKB4YpJJo/zEZVZjJyCRQt8T84jPaanSDT0PRnYOi9b8nZhIqlMRuMFZ2wxBQmZpk1VjXm9Edm6aCtsioLFC/bQfc7q+D1BakyNmI98NfuDduVkKYY/Qf/9jOjYPqmqMzaTRQ5CuW1fg5kKcGSJP7Is2UnyUPndU6ClNH/nhAlTNTDxTb7g0PvBOm8uLdozehnDmO67jUoW6NGDIxP8j0fgxyvcGBTzPAzu5Diq6Xrxo7a+mwbYSNMaziBvj9wzjS8vVXN05E/7oxiJOd7Nr8dIb1RhUSOeo4XEa0Y/2OkDzuZVW094FJjH3n2/GTUecu87uAoi0nX5n/YS84qn+pNgAdrVSpyJNaZEWTue73cXe0Jw9WNHCY9UoqSqQw8DCjXkilq6htu9YUacb0QzQo7f4n524Re1BJkEc7Sc43h+PbvJsl1Hmx9TGoiJz03JOOHUiIVgNEbYegvm9M5oVeBMzIvV4w64K1i2Q6i6MzkxvUePkA4lJnW17ZZbUB5dBYuQYMc8nVep8i9UtPmxY5ePKlf6L6wY3bPOiWKHUStl3RfYnlBYb5VLD2oJa7rHD18ZEASSeF7usa3gHNAUxrqabHis86txuGG/ik7xysJN/hiy6Bi7kA1Wv1DW+JfUQ9th3JJLR9Ax3D1PaX+FV+SiGrJENY7r76c5fSanuUlHeR7OX8sR/zM8JghJTXg9s41P/rqFpBbEUq4xvsX9jtv2r9QvA59VjmtAckbotJs7Y8SbTiTw4HgcVbRIDAi1ro6Kj0qcF5w9P6uUdMg2Nkc2624hompJo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(83380400001)(6506007)(53546011)(71200400001)(33656002)(5660300002)(8936002)(2906002)(478600001)(6486002)(316002)(66556008)(122000001)(38070700005)(6916009)(66476007)(186003)(86362001)(36756003)(66946007)(2616005)(54906003)(41300700001)(38100700002)(26005)(6512007)(66446008)(76116006)(64756008)(91956017)(8676002)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7BCA4A5614FA504F914CA8AE518B1862@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3058 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8f0246e0-442b-4889-5e3f-08da5db9b3c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IFjBuVfdMYufpmkpor7k4yO0HRj+kcbNCCCENGg8H+4lUBbqzVV+TDIeF4jkzuB1cNyHSl2My7WePk9Qrt86rcUssIy/ZkJ8tBlLARA2LXChstLLMWeLl8U7mGAi9puXkFMC3qsCMAQZ6uCXdaeirHzwTE+RV6FV9dTuxJBasUZsJYOA4IaqPITzu7V0Mt47613MpwX6hq/sTwYB/Pava3NBTO36xUIVosQygfnYv6WuftPPt6friRJ+evxP2QLnCroWC5G8swTg57AB1aVxqmsQsog8Yc42TVzZwy91M93Rw35omPsec0dFfM3/f74zo16GODX9H5bwmDpDTragr0qLwViKKb6bmWABCRTqqrybGC+5X3V7Vu8zXXMR3jYTjiQ2jpLzRzjBWg//vxfK5Nj4r72HrS+5PquiUtjoz3Y7xce9fdJcv0VBfaf11/8WgMMtrq63QI93VmLjCgMyOGhLBbWdlNh/7Tc9XUQ4Q7nJHB+4iQ5g4e1QkRXs4vHWLh9UhDaeVAS9CqycCTFt5YLN6dLI6+2KrE2L3siB6fhkGaz1JPZCA68o9wj9BES+4g2v53hvaMXJ+lab1NAXVEQm5/mq5P5P5RgM3RSOHDYiAeiffiWPrCrJ90y9P4AnljBGGn+LBq3mnmU7DfMrUhRKaLNkDZUzTTqDDh7UbY+di8ZDyhYkvDqv0aUxd3YNqtc0UirsX0VEO2ZvEDKGkH8cPbnh2lD4bknPvwzBFCRaWKejUUATfUfroMy8PS29HTRpB5R8a+yOPG6PxkL6nXxmPrhzxMr/jmcd2UZnOSpaJLQ8zRW/r/wo4I+2YkWl X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(346002)(376002)(40470700004)(46966006)(36840700001)(82310400005)(336012)(47076005)(107886003)(186003)(40460700003)(81166007)(356005)(40480700001)(82740400003)(83380400001)(36860700001)(41300700001)(70206006)(6862004)(86362001)(70586007)(316002)(54906003)(6512007)(6486002)(478600001)(53546011)(26005)(2616005)(2906002)(4326008)(8676002)(33656002)(8936002)(5660300002)(6506007)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 12:35:50.8135 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 37c11192-e252-445e-9d2b-08da5db9baa8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3598 Hi Julien, > On 24 Jun 2022, at 10:11, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Both destroy_xen_mappings() and modify_xen_mappings() will take in > parameter a range [start, end[. Both end should be page aligned. >=20 > Add extra ASSERT() to ensure start and end are page aligned. Take the > opportunity to rename 'v' to 's' to be consistent with the other helper. >=20 > Signed-off-by: Julien Grall With the prototype updated in mm.h as suggested by Michal: Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/mm.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) >=20 > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 0607c65f95cd..20733afebce4 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1371,14 +1371,18 @@ int populate_pt_range(unsigned long virt, unsigne= d long nr_mfns) > return xen_pt_update(virt, INVALID_MFN, nr_mfns, _PAGE_POPULATE); > } >=20 > -int destroy_xen_mappings(unsigned long v, unsigned long e) > +int destroy_xen_mappings(unsigned long s, unsigned long e) > { > - ASSERT(v <=3D e); > - return xen_pt_update(v, INVALID_MFN, (e - v) >> PAGE_SHIFT, 0); > + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > + ASSERT(s <=3D e); > + return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, 0); > } >=20 > int modify_xen_mappings(unsigned long s, unsigned long e, unsigned int fl= ags) > { > + ASSERT(IS_ALIGNED(s, PAGE_SIZE)); > + ASSERT(IS_ALIGNED(e, PAGE_SIZE)); > ASSERT(s <=3D e); > return xen_pt_update(s, INVALID_MFN, (e - s) >> PAGE_SHIFT, flags); > } > --=20 > 2.32.0 >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 12:53:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 12:53:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360348.589677 (Exim 4.92) (envelope-from ) id 1o8LaJ-0000rm-TT; Mon, 04 Jul 2022 12:53:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360348.589677; Mon, 04 Jul 2022 12:53:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LaJ-0000rf-Pn; Mon, 04 Jul 2022 12:53:51 +0000 Received: by outflank-mailman (input) for mailman id 360348; Mon, 04 Jul 2022 12:53:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LaH-0000r0-Tw for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 12:53:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 504e6d81-fb98-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 14:53:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9486.eurprd04.prod.outlook.com (2603:10a6:102:27d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 12:53:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 12:53:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 504e6d81-fb98-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ac2XqLyGVhBpRcAva759Eolczr0tsuUonk7HyjiDBCBnKFug4DMEnaFiZKkAfsegIJKtvybaMBy9evr5z0bZtKmMGPJzEFINLesuwaJwKACJTKvzPRuH2E32jqgMCf+KCO5Uvd/a4Sq3J9hGLxw1651wJxiEYNoAU1feIA+FgKVGTC8uNvToeFIm+aK6J4DLWKAng5OxgP6oXE67x1ScljO5zfyB0WvIJ63Wwm5Ta1h9oixn358L1V+QOeMaN+1t3rzvxEeNPz8IDR6ja9i6U6gqbkboO0d8Qct6p6Ffru5cXhcCgroZyI3oLpK482vEBQT6lZiA37uYcb+4pkcHNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G8Y8mDwtxmAxBw6f4NNMJLRFjn71RGDhvL1Mi6KMwb4=; b=S5oNoCPk9362sHvagn8fsVf8uCqbU+Est/bEt9/N404V5k1+YfUOOrFv3cLSlvtNyF7ZzGhQuO2zvLP6xgeMbLc1abcSmd74S6reFROh4qQKIDRJ1aGG8pAeeAlAjvbp81IKWkM+tkS7D1y1T4vWlHX/3VwUvQxh2pMW2na/CqPmGX6cv/jL+Na+4HeMR7B6D0veG7R9O2f4ABENPYzHHBj2INrklvzN2dbO5gC2a7hj89n83gg5QPR9T1fu8EdJqAqlFDTNnUPTjTus982XlxdCKjfmUKIn1u0yL4W3s4DmzCfcOmlCrXHf1BYbzEoLXa5MifjrdVoLVW5IwkBQtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G8Y8mDwtxmAxBw6f4NNMJLRFjn71RGDhvL1Mi6KMwb4=; b=4jtWKVbo9PSROm4plXQO4/R6m1d9esDxHbFCykLSlbjRNpy8+tQxCdMfBPxbkUMqChZ3e3Yrw7lrc168a5bjd4ZCcVW0Gxat1BNQiHniKIovBguPJ4ytDSLvOSyC0xfzGbaXEwwBp23FIB8KnsXc+hvTabIHIiow195H8yGWMo/z4FGjBxie2qN4jw5h9HXq8x2mrdxeZ1035zApQaL7lBzK2cU7Zuszp1KEzM8llATyNL51kzBKoiXwZmxuoHa5GRKup+0IsE7XVBfJ9/DN2FJzLG9JmLIRfuzLubGF9imHr+Rcj+6fPHHvmF28/qXeTa0FEI1p8rZ6+syIt1onoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 4 Jul 2022 14:53:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Juergen Gross From: Jan Beulich Subject: [PATCH] public: constify xsd_errors[] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0048.eurprd05.prod.outlook.com (2603:10a6:20b:489::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f43820d-6387-4514-21fd-08da5dbc3ba7 X-MS-TrafficTypeDiagnostic: PA4PR04MB9486:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iyNGqB05oQNqSNBJcKcOIgOTygYBv4Q+MK5oXzL0f8WlcXoFHsF0OQXXl/EEp7LReazgaD9BUAl5p7BOrNa+jOXfnsXTIu2I0wgqvmZBFaBrhg2WE0Aoas95UWi3NMCFkbnZPqQjRMTjcpgTzFdLbFfi2R4H6C5STHgopPjjwpo6QfwwJIABlMDS019Tgn/bdvI0lHoE+GplpTLbdNg+cfQKdzJ/v829xDlainxR87avnEY8cBEp9rOucQZ6JpDnEH38wDe/qsSBNEThSyutsDDaDW3GmjRS2yUCECCjglxB0fwDYpV9VItf2a/NZuZxIBbYEfrMs8BAyIjf4YWm49Pn5t2YCXjlfiE24jcm7CBOGgTrXy48nAm4jxwPcqzBPB0b/LQHE98fNJYofrRqOyNQ9jy0KKUxJHpmyqcxhHIkFParLHCrOyhXdLBtrgOqb5BNQiP2H0U5fhKGfzWs71JlDT1m4g3V/vX58bUXE4s57Dc4soOqXIDHKJ3T5g+CFoKAwNfJPmXjIQAYDHrRPbvLVHGP83jRjl1ngI8y62kMeB+3YlBg23jIIejOhlRkjWo92bhZSzCl1jK1M7vvp7XGHqTERC8MLMI1WkgYnxdJTdzOkAed29MLKnyK0emkMH/wnxHGyWbdTJL1/qKtljnUh5GGMyI9wztH93i68GjV6S/3YTIaCjRYGeSJDaVNw/FDTa754uQSGAVkukwIv3EdOljdb54uD2DpvtNZPNW2ezK6txNYEGxBgrMSqBbZoAXVukjk2lm94okKhQrudHvgnd+MX0WB1YQgREZ2ofnQNcrR0KE/xf6M/dtAom/HR/kQGT7i4OvsWqNQW88z/T8/vRTxiIH0lCp8O4taJo8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(396003)(366004)(376002)(346002)(6512007)(4744005)(6506007)(5660300002)(8936002)(26005)(86362001)(8676002)(66476007)(66556008)(66946007)(4326008)(6916009)(41300700001)(316002)(6486002)(478600001)(31696002)(107886003)(186003)(36756003)(2616005)(38100700002)(2906002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmhyUnF1aUU5eUpiNUZaeVdKUmdkcU5zMTB1NzhTQ0VHQU0xWlJzN1N1YW9V?= =?utf-8?B?NlFaRjJyS0RDVUVrRCtYT2RFZzIzek8rR1NBSVlmSFREVytUanNpRUt5cTIw?= =?utf-8?B?d3NIby93TDlpNDBqdXdYd0dYK3VGUCtJL3N6U2kvNkkxU3JQN0Y0M0wzakhj?= =?utf-8?B?T0E1WW9qeWxkTkVyZ3R3M0w5VHUxQWZqNVpFYzU0LzhyTTMvbng1aHhWUHI1?= =?utf-8?B?NWIrTS9pY3ZyME16ZHhod1BRTCt1RTBQRllDc3pJV20zYVBXT2E5ellmaHIr?= =?utf-8?B?WVBWaElZaERlOUk4d1V3ODFDMWcrWGh5R0RBWDRXdzNWRUMyWDZHSHRLWmNK?= =?utf-8?B?QkkzdmNUNmxRUVF0aXlmKzV1Zm50RldKR29QODNpdE5qbEFPazlyVE1Rdkxz?= =?utf-8?B?ZDZuTTJaUFpzdkcvNVMzNHBNdGlOYjZnQlB6QXZCb2RyQ0w3b1dEWTRPNTJD?= =?utf-8?B?aTB0c3hlUXArSE9lb0x1VUE1cGZkQVFodXNlWkJsQUJ4MVpPWjdYRjRsaHVx?= =?utf-8?B?WmduN1NjYXZEL1ZEdWtIUmhHVmVpdFppOUNVZzl1TXlrWGtwWEVhQVJhdjRK?= =?utf-8?B?WDBOWlJNRlRyQlpzRjFVN3BtcFJVOWZES2p1cXdnMkFwTUgreEQ0QmtjR3Z0?= =?utf-8?B?Sm92bERiTDZ6NklNY3RGdzAvVkl6c0J0KzY5TDRzZ2hEVVJ4VHpxRUJXMG5C?= =?utf-8?B?OGtRd202WldzcXVETTd5UUhvZzh0eUZzRDViYkNQTkwrWnVWYk9scmZ1bE93?= =?utf-8?B?L0tYNVl3bGp2Y0xjNHQ0ckQyVjlwMEw5TDVPOG1rL1dodjJjOEZVcnA5VGVl?= =?utf-8?B?MVJiWENYeGRaNlFQK3g2cHZzR212bDZBNndYSGgycXdnL09odlBnWUZORzhD?= =?utf-8?B?M2h1TkhsSEhmUTRZb2dKYUo2c3IwNmZoeFhreHowMmdzSDMva3BUTWlPRGRN?= =?utf-8?B?azNJUGFzaHRWdjJaaWIveXZEejkxUzNEbGhzSkpBdVFRMThCZDdNR2U5N05o?= =?utf-8?B?QXFZWERSaVljeSs5cC9vTGpYQU9qaksxNTBiVnQxSldaS2FBODZrZHU5cDZS?= =?utf-8?B?VHE2UG1QUG9lMEZrd2htUDNSS3J3QVZQY3RqWHprcGlRY3FVU0RRSE9lbjJF?= =?utf-8?B?WXFSN29ZdFpwMkQyNHc1eGZJS2ZMOHRpWklNMzVCdXF1VlJxK2ZPemsvb2lB?= =?utf-8?B?bGE0WXZtd0tPTjRpR0ZjOGFIdURwbkxpTHhOTVNnK3dtTmtUNWVvTStUcnFR?= =?utf-8?B?dWE5MjdieGFGbFBJanMyZ0E2dHJIVS91Ly9oQm53YXBZZk9wVy81dDNPL0Na?= =?utf-8?B?YVA2Vi9iOXlMSE41SUF4RS9tRGUrUkFvWFp1SDdJdmxOd09CdW93RFdlbktj?= =?utf-8?B?RTJnbzJkUEk0T2dNNkZBS2M5emV2VkxQM05ldmhTVXE2OUZkQ1JSdW5LM0Z2?= =?utf-8?B?ZnhYMk9mSzJLUG5ZQ1k4V3RjUEp0cW5IVTBZK0NmTDJKYnlwZjBJRTYzZWx0?= =?utf-8?B?L1phQkZzbXhWTStuNStPbVcxWjhrZ3B4czA3dmhHamdsTFgzWm5GTkNSdi94?= =?utf-8?B?Z29HUHAzMXNZR1RhblJ5UEZXb015bkpMNUYyc3hZUWFBRzZBcm8zSmRHRFo4?= =?utf-8?B?ZG5VeUJyTUtMTGlqK2VhK01NNjMrQjlITUN3V2p6eWF2U0lJQ3BNWTk1OWhJ?= =?utf-8?B?UlMwTWFLcTZqR1ZhLzZUVVcwL2ZlWXlVZ1BJdk52M1g5MmQ0dEJJZ3ZHVjNG?= =?utf-8?B?NDJsNTZ3TCs5K2tzVmQvTU5IUnVHcStJZFo4L2MxOSs5em51UnlodHkwcXNQ?= =?utf-8?B?NTN5c2hJUDBVY2tiT2ZpdExDazBMS1NHRWYxTUQ3U2JRb3U2NktoeGQrVTlC?= =?utf-8?B?aVlzMTNaeXpKazJGOEI4NGYzR2FTSkRIbTRKOGxCZ2tVSE9mV1piSno2ai9V?= =?utf-8?B?cFZtdGtIbHVBRDJUcERDZTJEd0tabHJaZGVmTHVzN0h2UEFNMGE2eDBqTThQ?= =?utf-8?B?a0pETmJhOGJGT3U4cHpQd1ZWeGVjR0NRZU5LdGpaKzNZNFU2c2FqSnRVODVy?= =?utf-8?B?b0w5U21tNytHckxQdGc5dlp5U1dzeDBkeUc5N3hGY2NuZFZ1L2tHUzlJa1Jq?= =?utf-8?Q?VeFxQ9ehCzuCuOqgWWER8dPGl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f43820d-6387-4514-21fd-08da5dbc3ba7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 12:53:46.3483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vC05NUSIa1kA9HECdkupx/p6lMgemGWvAeQjFGTatEyzEUm8uT7aVuXeOs3OkZdt4AiG3A7QvhYHULsSnvV1cQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9486 While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich --- Especially since the table definition lives in a header, the adding of "const" might render redundant the adding of the "unused" attribute. But I'm not sufficiently certain that all supported gcc versions as well as compilers claiming gcc compatibility behave consistently in this regard, so I'm leaving the attribute in place. --- a/xen/include/public/io/xs_wire.h +++ b/xen/include/public/io/xs_wire.h @@ -71,7 +71,7 @@ struct xsd_errors #ifdef EINVAL #define XSD_ERROR(x) { x, #x } /* LINTED: static unused */ -static struct xsd_errors xsd_errors[] +static const struct xsd_errors xsd_errors[] #if defined(__GNUC__) __attribute__((unused)) #endif From xen-devel-bounces@lists.xenproject.org Mon Jul 04 13:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 13:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360360.589708 (Exim 4.92) (envelope-from ) id 1o8LiC-0002dg-VO; Mon, 04 Jul 2022 13:02:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360360.589708; Mon, 04 Jul 2022 13:02:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LiC-0002dZ-Rj; Mon, 04 Jul 2022 13:02:00 +0000 Received: by outflank-mailman (input) for mailman id 360360; Mon, 04 Jul 2022 13:01:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8LiB-0002dT-8g for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 13:01:59 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c84126b-fb99-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 15:01:58 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id ACDF122491; Mon, 4 Jul 2022 13:01:57 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9165D1342C; Mon, 4 Jul 2022 13:01:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id JuHUIcXkwmKROgAAMHmgww (envelope-from ); Mon, 04 Jul 2022 13:01:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c84126b-fb99-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656939717; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mjKQ3Fzzm5gdxu+ZlAp3LUdWeBYMuqW9HGwmIW891wc=; b=cvAwy3EvHhPsGU9w7Qu0O67QMADX8LEMeAkMV5bTtXO/vzwQAb7/tLyW/H5dWCvdbe7RtR GwW9W5s2A8oo6jNEK2GpKWN5I3SuWHuN5bnOLedy+rt5vxMFmSqBDBKRvgagwTQOtwQqzz KHeZDUlDOzTPbWsV593/uASoIt8ac0s= Message-ID: <09dc3bef-c156-856d-1d52-bb934cfcaa95@suse.com> Date: Mon, 4 Jul 2022 15:01:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] public: constify xsd_errors[] Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RjYxG4S0mdtTrlA9zfmOGzGE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RjYxG4S0mdtTrlA9zfmOGzGE Content-Type: multipart/mixed; boundary="------------51LH5NoifiF0eyPFmWJLMuNl"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , "xen-devel@lists.xenproject.org" Message-ID: <09dc3bef-c156-856d-1d52-bb934cfcaa95@suse.com> Subject: Re: [PATCH] public: constify xsd_errors[] References: In-Reply-To: --------------51LH5NoifiF0eyPFmWJLMuNl Content-Type: multipart/mixed; boundary="------------AdLTY8L1Z2oNcqTUOV4rDuOs" --------------AdLTY8L1Z2oNcqTUOV4rDuOs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDQuMDcuMjIgMTQ6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBXaGlsZSBpbiBwcmlu Y2lwbGUgdGhpcyBjb3VsZCBicmVhayBleGlzdGluZyB1c2VycywgSSB0aGluayBzdWNoIHVz ZXJzDQo+IGRlc2VydmUgdG8gYmUgcHV0IGluIHRyb3VibGUuIEFmdGVyIGFsbCB0aGUgdGFi bGUgc2hvdWxkIGhhdmUgYmVlbiBjb25zdA0KPiBmcm9tIHRoZSB2ZXJ5IGJlZ2lubmluZy4N Cj4gDQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4N Cg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCg0KDQpK dWVyZ2VuDQo= --------------AdLTY8L1Z2oNcqTUOV4rDuOs Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AdLTY8L1Z2oNcqTUOV4rDuOs-- --------------51LH5NoifiF0eyPFmWJLMuNl-- --------------RjYxG4S0mdtTrlA9zfmOGzGE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLC5MUFAwAAAAAACgkQsN6d1ii/Ey8+ zwf/ZGvC36dzbIZbhvZqQOmyEv3PnMtkb27/Vf3QUufSC3yO8IH/3Egl8bHURfT0/nR98cSyrx9Q P3/kxxhTSpABUso/cTn9SLpP6Q8cPBLXNwXN0cL84mwwFq1jdRjUO7v03YnzpauQNWGXjgCHB59Q L8aNIAIdJbBglVf8stQ8AfWK3MTVSGpwLqLjnbORmuJ8+3sVXBkWojBlzTDrnfMv7HwDTBrwr/2B J/Y2KEx5zZpuZ9qMBP1X0lZOM55r5/6cro3oo5COtaQsjs790O5bj8YbvICtIrvhTMfW0X0PASFa xHQc1qJ+8KcNzwc7M0qESqx2ol2H9KycbfIb/IwVcQ== =YR1/ -----END PGP SIGNATURE----- --------------RjYxG4S0mdtTrlA9zfmOGzGE-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 13:09:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 13:09:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360366.589718 (Exim 4.92) (envelope-from ) id 1o8Lpk-0003Sa-TV; Mon, 04 Jul 2022 13:09:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360366.589718; Mon, 04 Jul 2022 13:09:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Lpk-0003ST-Qa; Mon, 04 Jul 2022 13:09:48 +0000 Received: by outflank-mailman (input) for mailman id 360366; Mon, 04 Jul 2022 13:09:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Lpj-0003SN-Dt for xen-devel@lists.xen.org; Mon, 04 Jul 2022 13:09:47 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 891c407e-fb9a-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 15:09:30 +0200 (CEST) Received: from mail-dm6nam10lp2102.outbound.protection.outlook.com (HELO NAM10-DM6-obe.outbound.protection.outlook.com) ([104.47.58.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 09:09:42 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM4PR03MB6933.namprd03.prod.outlook.com (2603:10b6:8:45::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Mon, 4 Jul 2022 13:09:40 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 13:09:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 891c407e-fb9a-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656940185; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=I970Hla0hSh0E2q2eJmtVXp1MOX68i9tdiwcKyQtzSo=; b=Js/LwoRCNvhqy8MpUb5Wzy78iUBm28MydB+aS36tkmSQnBMvjzai6hd6 PXnzWgQFXO9coQdZ+kdwe1N4uZFZ3J45ZuUzAz/d5Hx/zJuIszwv6YpDF AenQtpF0tluanU5dAwhn2QkxhUu3+NeCovKaJ/lBSWjSB67rsjrP0S9VZ w=; X-IronPort-RemoteIP: 104.47.58.102 X-IronPort-MID: 75462015 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2nXymKo5vShPAPqIlLw15kOPykBeBmJwZBIvgKrLsJaIsI4StFCzt garIBmHMvaMMWHxc9AiYY7loE9XscfTzoNkSVRv+StmFXhE9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrRRbrJA24DjWVvS4 Yiq+aUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBHajHhO85WVpkOHt6O6pa35/MO2iYiJnGp6HGWyOEL/RGKmgTZNVd1sMpRGZE+ LofNSwHaQ2Fi6Su2rWnR+Jwh8Mlas72IIcYvXImxjbcZRokacmbH+OWupkFjHFp3pom8fX2P qL1bRJ1axvNeVtXM0o/A5Mihua4wHL4dlW0rXrK+PZpuTCKkWSd1pDBO+DMS/iYTv50pX2kh 3rf5WjgACAFYYn3JT2ttyjEavX0tS36Qo8XGaG18eRCnUae3HdVExoLT1C2r/6jhUP4Xd9DQ 2QE9yxroaUs+UiDStjmQwb+sHOC+BkGVLJt//YS7QiMzu/Y5lifD21dFjpZMoV+7okxWCAg0 UKPk5XxHztzvbaJSHWbsLCJsTe1PitTJmgHDcMZcTY4DxDYiNlbpnryohxLScZZUvWd9enM/ g23 IronPort-HdrOrdr: A9a23:tF1WoK0niToOLs9wurRwIgqjBSlyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtjkfZr5z+8M3WB3B8bYYOCGghrQEGgG1+ffKlLbexEWmtQttp uINpIOcuEYbmIK8voSgjPIdOrIqePvmM7IuQ6d9QYKcegDUdAd0+4TMHf+LqQZfnglOXJvf6 Dsm/av6gDQD0g/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/iYsKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF6d2H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCqlqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0BjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXd WGNPusqsq+TGnqLkww5gJUsZyRtzUIb127q3E5y4OoO2M8pgE786MarPZv7EvouqhNCaWs3N 60Q5iApIs+MPP+UpgNdNvpYfHHflAlEii8R166EBDAKJwtHU7rhtre3IgVjdvaC6DgiqFC06 j8bA== X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="75462015" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJZGgzNnmrulkXhCu/2ijFaKTyyBS0HxObnkdDLSiPtR03fMMaMyUKw3P57RuJy1O0VVdq9WORRLItk/1HIb7jOR1sO9aovqr4Ruf7aHgP8xUPS/MMhwy8G94oWB10cvp/Il8Go2wzA4ndfdntiI3HA9WqnhXDgT2S/HzE/fEQ5gzp+ClY8N+9/sMony4xWQFXFod++pbzTMndDR9suSl3Nnz8Fdztbj7wzMcEVq0w2NZfjvveaG5TilIgYdCFuJta5Cq00x2lc0nOBCOyRhf5RxmXXY96XX6SzhJnwFV8hVSVJ3XtQQEEtS5ePOqrLL98SWJAeruypbWH2+/4HpXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0ynZzdQN8+GSTjnahH/t9Lmr/67CYkpge7ymDD0ixA=; b=gCs4rsjVGwjLi9S/sCSDRmSDczv8naL0vXFJSEVbh+o/OFlauWvTFs+h1+z/xq7j99stdyY0dzKvHnnTKSQh+eDwty5sv6CTq/xdFSNANu3gczbvMdVvs5Erno8v+TYlF4+Vi4IbkP/YfcTV3IXmkLrSolzfP7XnK5C4dAjtRIpU/a22gdKo9m31uhRnc5g7HM5R20AOLcyak3UZlNyu6l/Cd+lGgAcMs3OM6a5kVloSP/dvyIyhhSlKRasC/31CY26tMQ+I2aFrAZE2HQ2EAdzlPLeiq7g3MapbMtCyxKqkpW6aArOt9egCvmKylc78fJ3OOFn4LqiJ83DtClb8Ew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0ynZzdQN8+GSTjnahH/t9Lmr/67CYkpge7ymDD0ixA=; b=Rn7gEESHuC3Xarmcop8SV6MX+Qo4UluJPFTrip7pZCZ5PhxvXRiCFmFM58+jmT2E8DNPDIAITW78y4XihqXuC2FeI9gVk5b875n+1OxiWoQ+dKna9pFrxTC8G1FE5CFL9O8aHo87wyH+Qu+LMxop1IwRQ1rnVBsY7uo2PkwCZfs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 15:09:40 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "G.R." Cc: xen-devel Subject: Re: PCI pass-through problem for SN570 NVME SSD Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0122.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::19) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1218ce0-1bc1-4672-7ea0-08da5dbe7425 X-MS-TrafficTypeDiagnostic: DM4PR03MB6933:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uDAXYt3vYsmTLxApRD0s06EkvNfskNHaaQYFN5MVpnQBFpf4tuw91vSsASMoRdC6rSTGgK370hPDwHIpNP1bcG+Aw/kCPqOfFSc1d2/zvqNL10xxwMsbWa98+up7xpsutMKQTsz42SbNLUZD0MRjzpdQaTzbxBdU+thRRqiZs3WGwn90TRBDCwvwNm9xGzd2ZdANjS86lMBZSz3X7KSMTp3gr464Bit+AtzGerBNOoy9Nc9Q3L8llavRE6ZbQI27+2GIZznvIJQkU+axcGEzc0xdjb4XXWrF8iE1a7mqbuUoHgXpvwhbeQJw+PwGqUXc5o9i2avTjz+4Elei5+R0ScigkOx9gE/5NfqvreeW1s1wOP3j9f6Zl0kP89WNgJTweECAfsg8Tam9MfPjs0RCtWUq9bjOBubw1NA3JjJPtq5BfZC0hvgu0iqdmaovbAbgooa91qERikMjKTy3/rQwBdYyatCNgroxjUKKKDpvr7t7Te/shOZ45V79VboJMvaLQ0vZYqa7Qcp72pm4wm5iuBk6arVwzV5OBa28Ozz4gP+kszpnT/lq62BPpPogZctxeg+QkCj2NlWoPU7bFY6qhGu8gQpJZEyYGAXPEgrfXpNNwFGECsqLc1HJ3pNrnC4MROp3iJm7ZTQHSmw0dY+6fVuvuxstOTp0D1Ui4rdIID+mZy6UDd3cZT3GmXdbAmBWcIGqimweKmTSYOR0btX+XFVujZD/3suXT8qP+xngLvYMFpD7bRbNeVl7exLl2hk8JNPS8RydLu3qS1ptgrJaoagosBkb1SXYgN0gxAxrAbXvJgdb7hxaSeT5xGkwvYbY X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(346002)(366004)(376002)(38100700002)(6486002)(2906002)(478600001)(41300700001)(30864003)(5660300002)(8936002)(186003)(86362001)(83380400001)(6506007)(6512007)(9686003)(6916009)(26005)(316002)(66946007)(82960400001)(66476007)(66556008)(4326008)(8676002)(19627235002)(53546011)(85182001)(21314003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1Vua0JBd2dNMDFWN2hncnFnaWJRUnVJeWhpNUNRTWNMb0VuZHc3OWhXbld6?= =?utf-8?B?TzhVZGJGMlljVk5sYTJrWm8rRGF5NHZTaUh0ZUZJdXVaZlpua1R6dEx2WVhL?= =?utf-8?B?clBpYzVoYUhnb2lud3JmMzBUZnZTSWwyL1FnV1pDK004SXVJTExySngyczE4?= =?utf-8?B?eEVMelVmS21lVU95MEFJMnNCTHM0UnBHeU8yNDlMQy9UK0tja25lNjdVTDJR?= =?utf-8?B?REFFL1E2UWxBZ0JlTnRQZXBnVEVUWFlWVkZCY1FlYlZtM1R1a0U4ODE3WnVi?= =?utf-8?B?VHhMejZ2eDBTNUZqOTJnV0RDM2JpbVNrWEFYdDNxcG9yZHdBWFN3WjFXMnRw?= =?utf-8?B?a3B2QU04cjBQdGZZNmJsUnJoa0lyZW1iNXFJdHQrQnVhMGQwS1VuK1NOQXFY?= =?utf-8?B?SWZxUTNuZEJHeml0Q1NWU0s4UkVPQmp2WTF6VWhDaDdOMDhwNnkySFovcVVO?= =?utf-8?B?NUtQN1FpWC94VzkyUTY5Mll5cmtJYk1JU3RNYnA3L0QxWCtLaGs0WkpJVVlH?= =?utf-8?B?VXM4dk0wU2hSNE53a2ROY0RxTTZ2S1pYZGpKYytEVEduTHEvYXprcG9rVndy?= =?utf-8?B?SWQxK3EyRWlOYnd5OVdCd2RqQWxwTzVpOFByTEhJOGl2cGtjRnNsVWs4VC9W?= =?utf-8?B?cXlrREgwaTRLYVlDVklaT2J0U3F6SlQ1UWx6MGhxdXdXaUpzVWN3VWhJZDd3?= =?utf-8?B?eEZ3dVYwS0FwSXJjbEhwZU5rbnd0RTVsc01sTVJnNWtrcVdPQVc2S0tPdkxC?= =?utf-8?B?T3VEWkxZZDlYYVF3dmZSczI5ODBSTXhwN01FdXBXSDViTHkzQk1YNm0xeFd0?= =?utf-8?B?cis4eGx1TUdnVnljMWlNeEhIS3FNbFVDSUpGZHh3Vy9rZnhxblIvUVExWS9n?= =?utf-8?B?dzJzTUNJTFV2NEZFaXdoWE9ESEZFbXUyR1VSbnpBK2lLdnYwSU5uM251Zkkz?= =?utf-8?B?MHpzTGJndGJhMmdYbmFlaDZ5TTdEclR1R3VCV0ZWZ3RmRE1wTENIOVZ4ZDlK?= =?utf-8?B?VlhRbzdmaEwzS3UvR0xmYWtMQnhmOWJrNG1uSVNaTElQK09uTFk4NFhQT2ts?= =?utf-8?B?enVCOFRUUDJxNGtWQklWNE0vb0RrbGo1dUFSTnYvOUlobmUwMmhWU0s4OGJn?= =?utf-8?B?U0piS1ZNUVVMYXhodHluenh5czA3RDJLZ2hOYjJvMVF0d1lCWUlqdjlTdWhY?= =?utf-8?B?Mk1OOG5MRXRiYXFqaEtrSXljY0RKdmMxMmNmV0NBRkZuNFczaUpVQURpZWhq?= =?utf-8?B?OHd5L2NYSjVVVlNudzhyV01JYnN1T1V0SHVReUN4TGQ3eVBpd2dHRWw0ZnNo?= =?utf-8?B?QW1JNTMyZjQ0NDFoV2JoTVJJY1lkTnZoZTVXbXdTZFB1U01rcHNsRk83SUtD?= =?utf-8?B?bExNcmxPaGxFZU1vaWV0UUhUeGNhUlRkbnZZTjBoeTIrcTNpMkMxT0FyRGht?= =?utf-8?B?OCtuanBTQmpTeEpmNDBtVWF5aFJrR29FbDJ3aHdNTHNEeUNxTTdydUhKOUZy?= =?utf-8?B?YVI0d1lFNHNHdVFydzlCeTI1eVRKS1ZsRE5TdmRFR3dYZEFKNlhlQlZGOEpp?= =?utf-8?B?OVJmWEhkU2ZzOFVGdWRHaElhMS9tM0Fsd3B0dkdCWFhMMWhXQ2FsaXpoN2c1?= =?utf-8?B?Z2pUYlJlSFdTMmU2UE1keVBteER3bGkvT3lwVXVtVHpSWWVkYUF6U09ZdlhB?= =?utf-8?B?OFV4bUQwR3JGZTU2UmxFbXBQdEJKbWFvdTlId1NlRGN1Rnh4WGdHcHY4SVdu?= =?utf-8?B?QTR1TXV0SjRSTzdRSDVXb2xPSVpXQ1RraUxYTE94WGlGK25obXlmQTVuUDZ0?= =?utf-8?B?ZUVaMC9KUEtSR09ubC9iV2NzOEt3QkdGMGpucVpFQTI0aHBneGhpWCtxcXM0?= =?utf-8?B?N0RiVjgxWjdOay8zeG1Lakx4ME9nam14R09rVWlnNUpMaHRFMkM1clFXaytN?= =?utf-8?B?b2djMUJKWTlYZ0VXK053d3NYNTFScFN5YU41ZmlhMlVFclFRVFFxS1pIQ2F1?= =?utf-8?B?TDBxS1hEamFFZ0tubW0wRzJ5M2tSQ05ud3l1c3lyTklzaEw0UHgvSjR3eGtL?= =?utf-8?B?eWM2dFV4WVdieG5WTXNyNm0wSnNqOXNYaHNFc1VNdnB2REprK1o4RTZPaXlE?= =?utf-8?B?eVBsUDMvYVVqQlJVb0V5V292Q0VncXVuUW5aS0ZkMmJ5S2VOWUJvWjR1ejhN?= =?utf-8?B?eFE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1218ce0-1bc1-4672-7ea0-08da5dbe7425 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 13:09:40.2629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FxTEHaJR3k/hiqSSdOji0gHXTfwvb6d3kQy0WOqjdpmEoh9uo7kkpediSn4Sk1BCEmXl+fqxVk4Rx+hHsta/Dw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6933 On Mon, Jul 04, 2022 at 07:34:47PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 5:53 PM Roger Pau Monné wrote: > > > > On Sun, Jul 03, 2022 at 01:43:11AM +0800, G.R. wrote: > > > Hi everybody, > > > > > > I run into problems passing through a SN570 NVME SSD to a HVM guest. > > > So far I have no idea if the problem is with this specific SSD or with > > > the CPU + motherboard combination or the SW stack. > > > Looking for some suggestions on troubleshooting. > > > > > > List of build info: > > > CPU+motherboard: E-2146G + Gigabyte C246N-WU2 > > > XEN version: 4.14.3 > > > > Are you using a debug build of Xen? (if not it would be helpful to do > > so). > It's a release version at this moment. I can switch to a debug version > later when I get my hands free. > BTW, I got a DEBUG build of the xen_pciback driver to see how it plays > with 'xl pci-assignable-xxx' commands. > You can find this in my 2nd email in the chain. > > > > > > Dom0: Linux Kernel 5.10 (built from Debian 11.2 kernel source package) > > > The SN570 SSD sits here in the PCI tree: > > > +-1d.0-[05]----00.0 Sandisk Corp Device 501a > > > > Could be helpful to post the output with -vvv so we can see the > > capabilities of the device. > Sure, please find the -vvv output from the attachment. > This one is just to indicate the connection in the PCI tree. > I.e. 05:00.0 is attached under 00:1d.0. > > > > > > Syndromes observed: > > > With ASPM enabled, pciback has problem seizing the device. > > > > > > Jul 2 00:36:54 gaia kernel: [ 1.648270] pciback 0000:05:00.0: > > > xen_pciback: seizing device > > > ... > > > Jul 2 00:36:54 gaia kernel: [ 1.768646] pcieport 0000:00:1d.0: > > > AER: enabled with IRQ 150 > > > Jul 2 00:36:54 gaia kernel: [ 1.768716] pcieport 0000:00:1d.0: > > > DPC: enabled with IRQ 150 > > > Jul 2 00:36:54 gaia kernel: [ 1.768717] pcieport 0000:00:1d.0: > > > DPC: error containment capabilities: Int Msg #0, RPExt+ PoisonedTLP+ > > > SwTrigger+ RP PIO Log 4, DL_ActiveErr+ > > > > Is there a device reset involved here? It's possible the device > > doesn't reset properly and hence the Uncorrectable Error Status > > Register ends up with inconsistent bits set. > > xen_pciback appears to force a FLR whenever it attempts to seize a > capable device. > As shown in pciback_dbg_xl-pci_assignable_XXX.log attached in my 2nd mail. > [ 323.448115] xen_pciback: wants to seize 0000:05:00.0 > [ 323.448136] pciback 0000:05:00.0: xen_pciback: probing... > [ 323.448137] pciback 0000:05:00.0: xen_pciback: seizing device > [ 323.448162] pciback 0000:05:00.0: xen_pciback: pcistub_device_alloc > [ 323.448162] pciback 0000:05:00.0: xen_pciback: initializing... > [ 323.448163] pciback 0000:05:00.0: xen_pciback: initializing config > [ 323.448344] pciback 0000:05:00.0: xen_pciback: enabling device > [ 323.448425] xen: registering gsi 16 triggering 0 polarity 1 > [ 323.448428] Already setup the GSI :16 > [ 323.448497] pciback 0000:05:00.0: xen_pciback: save state of device > [ 323.448642] pciback 0000:05:00.0: xen_pciback: resetting (FLR, D3, > etc) the device > [ 323.448707] pcieport 0000:00:1d.0: DPC: containment event, > status:0x1f11 source:0x0000 > [ 323.448730] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected > [ 323.448760] pcieport 0000:00:1d.0: PCIe Bus Error: > severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver > ID) > [ 323.448786] pcieport 0000:00:1d.0: device [8086:a330] error > status/mask=00200000/00010000 > [ 323.448813] pcieport 0000:00:1d.0: [21] ACSViol (First) > [ 324.690979] pciback 0000:05:00.0: not ready 1023ms after FLR; > waiting <============ HERE > [ 325.730706] pciback 0000:05:00.0: not ready 2047ms after FLR; waiting > [ 327.997638] pciback 0000:05:00.0: not ready 4095ms after FLR; waiting > [ 332.264251] pciback 0000:05:00.0: not ready 8191ms after FLR; waiting > [ 340.584320] pciback 0000:05:00.0: not ready 16383ms after FLR; > waiting > [ 357.010896] pciback 0000:05:00.0: not ready 32767ms after FLR; waiting > [ 391.143951] pciback 0000:05:00.0: not ready 65535ms after FLR; giving up > [ 392.249252] pciback 0000:05:00.0: xen_pciback: reset device > [ 392.249392] pciback 0000:05:00.0: xen_pciback: > xen_pcibk_error_detected(bus:5,devfn:0) > [ 392.249393] pciback 0000:05:00.0: xen_pciback: device is not found/assigned > [ 392.397074] pciback 0000:05:00.0: xen_pciback: > xen_pcibk_error_resume(bus:5,devfn:0) > [ 392.397080] pciback 0000:05:00.0: xen_pciback: device is not found/assigned > [ 392.397284] pcieport 0000:00:1d.0: AER: device recovery successful > Note, I only see this in FLR action the 1st attempt. > And my SATA controller which doesn't support FLR appears to pass > through just fine... > > > > > > ... > > > Jul 2 00:36:54 gaia kernel: [ 1.770039] xen: registering gsi 16 > > > triggering 0 polarity 1 > > > Jul 2 00:36:54 gaia kernel: [ 1.770041] Already setup the GSI :16 > > > Jul 2 00:36:54 gaia kernel: [ 1.770314] pcieport 0000:00:1d.0: > > > DPC: containment event, status:0x1f11 source:0x0000 > > > Jul 2 00:36:54 gaia kernel: [ 1.770315] pcieport 0000:00:1d.0: > > > DPC: unmasked uncorrectable error detected > > > Jul 2 00:36:54 gaia kernel: [ 1.770320] pcieport 0000:00:1d.0: > > > PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction > > > Layer, (Receiver ID) > > > Jul 2 00:36:54 gaia kernel: [ 1.770371] pcieport 0000:00:1d.0: > > > device [8086:a330] error status/mask=00200000/00010000 > > > Jul 2 00:36:54 gaia kernel: [ 1.770413] pcieport 0000:00:1d.0: > > > [21] ACSViol (First) > > > Jul 2 00:36:54 gaia kernel: [ 1.770466] pciback 0000:05:00.0: > > > xen_pciback: device is not found/assigned > > > Jul 2 00:36:54 gaia kernel: [ 1.920195] pciback 0000:05:00.0: > > > xen_pciback: device is not found/assigned > > > Jul 2 00:36:54 gaia kernel: [ 1.920260] pcieport 0000:00:1d.0: > > > AER: device recovery successful > > > Jul 2 00:36:54 gaia kernel: [ 1.920263] pcieport 0000:00:1d.0: > > > DPC: containment event, status:0x1f01 source:0x0000 > > > Jul 2 00:36:54 gaia kernel: [ 1.920264] pcieport 0000:00:1d.0: > > > DPC: unmasked uncorrectable error detected > > > Jul 2 00:36:54 gaia kernel: [ 1.920267] pciback 0000:05:00.0: > > > xen_pciback: device is not found/assigned > > > > That's from a different device (05:00.0). > 00:1d.0 is the bridge port that 05:00.0 attaches to. > > > > > > > > After the 'xl pci-assignable-list' appears to be self-consistent, > > > creating VM with the SSD assigned still leads to a guest crash: > > > From qemu log: > > > [00:06.0] xen_pt_region_update: Error: create new mem mapping failed! (err: 1) > > > qemu-system-i386: terminating on signal 1 from pid 1192 (xl) > > > > > > From the 'xl dmesg' output: > > > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > > > > Seems like QEMU is attempting to remap a p2m_mmio_direct region. > > > > Can you paste the full output of `xl dmesg`? (as that will contain the > > memory map). > Attached. > > > > > Would also be helpful if you could get the RMRR regions from that > > box. Booting with `iommu=verbose` on the Xen command line should print > > those. > Coming in my next reply... > 00:1d.0 PCI bridge: Intel Corporation Cannon Lake PCH PCI Express Root Port #9 (rev f0) (prog-if 00 [Normal decode]) > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Latency: 0, Cache Line Size: 64 bytes > Interrupt: pin A routed to IRQ 126 > IOMMU group: 10 > Bus: primary=00, secondary=05, subordinate=05, sec-latency=0 > I/O behind bridge: 0000f000-00000fff [disabled] > Memory behind bridge: a2600000-a26fffff [size=1M] > Prefetchable memory behind bridge: 00000000fff00000-00000000000fffff [disabled] > Secondary status: 66MHz- FastB2B- ParErr- DEVSEL=fast >TAbort- BridgeCtl: Parity- SERR+ NoISA- VGA- VGA16+ MAbort- >Reset- FastB2B- > PriDiscTmr- SecDiscTmr- DiscTmrStat- DiscTmrSERREn- > Capabilities: [40] Express (v2) Root Port (Slot+), MSI 00 > DevCap: MaxPayload 256 bytes, PhantFunc 0 > ExtTag- RBE+ > DevCtl: CorrErr+ NonFatalErr+ FatalErr+ UnsupReq+ > RlxdOrd- ExtTag- PhantFunc- AuxPwr- NoSnoop- > MaxPayload 256 bytes, MaxReadReq 128 bytes > DevSta: CorrErr- NonFatalErr- FatalErr- UnsupReq- AuxPwr+ TransPend- > LnkCap: Port #9, Speed 8GT/s, Width x4, ASPM L0s L1, Exit Latency L0s <1us, L1 <16us > ClockPM- Surprise- LLActRep+ BwNot+ ASPMOptComp+ > LnkCtl: ASPM L1 Enabled; RCB 64 bytes, Disabled- CommClk+ > ExtSynch- ClockPM- AutWidDis- BWInt- AutBWInt- > LnkSta: Speed 8GT/s (ok), Width x4 (ok) > TrErr- Train- SlotClk+ DLActive+ BWMgmt+ ABWMgmt- > SltCap: AttnBtn- PwrCtrl- MRL- AttnInd- PwrInd- HotPlug- Surprise- > Slot #12, PowerLimit 25.000W; Interlock- NoCompl+ > SltCtl: Enable: AttnBtn- PwrFlt- MRL- PresDet- CmdCplt- HPIrq- LinkChg- > Control: AttnInd Unknown, PwrInd Unknown, Power- Interlock- > SltSta: Status: AttnBtn- PowerFlt- MRL- CmdCplt- PresDet+ Interlock- > Changed: MRL- PresDet- LinkState+ > RootCap: CRSVisible- > RootCtl: ErrCorrectable- ErrNon-Fatal- ErrFatal- PMEIntEna- CRSVisible- > RootSta: PME ReqID 0000, PMEStatus- PMEPending- > DevCap2: Completion Timeout: Range ABC, TimeoutDis+ NROPrPrP- LTR+ > 10BitTagComp- 10BitTagReq- OBFF Not Supported, ExtFmt- EETLPPrefix- > EmergencyPowerReduction Not Supported, EmergencyPowerReductionInit- > FRS- LN System CLS Not Supported, TPHComp- ExtTPHComp- ARIFwd+ > AtomicOpsCap: Routing- 32bit- 64bit- 128bitCAS- > DevCtl2: Completion Timeout: 50us to 50ms, TimeoutDis- LTR+ OBFF Disabled, ARIFwd- > AtomicOpsCtl: ReqEn- EgressBlck- > LnkCap2: Supported Link Speeds: 2.5-8GT/s, Crosslink- Retimer- 2Retimers- DRS- > LnkCtl2: Target Link Speed: 8GT/s, EnterCompliance- SpeedDis- > Transmit Margin: Normal Operating Range, EnterModifiedCompliance- ComplianceSOS- > Compliance De-emphasis: -6dB > LnkSta2: Current De-emphasis Level: -3.5dB, EqualizationComplete+ EqualizationPhase1+ > EqualizationPhase2+ EqualizationPhase3+ LinkEqualizationRequest- > Retimer- 2Retimers- CrosslinkRes: unsupported > Capabilities: [80] MSI: Enable+ Count=1/1 Maskable- 64bit- > Address: fee002b8 Data: 0000 > Capabilities: [90] Subsystem: Gigabyte Technology Co., Ltd Cannon Lake PCH PCI Express Root Port > Capabilities: [a0] Power Management version 3 > Flags: PMEClk- DSI- D1- D2- AuxCurrent=0mA PME(D0+,D1-,D2-,D3hot+,D3cold+) > Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- > Capabilities: [100 v1] Advanced Error Reporting > UESta: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF- MalfTLP- ECRC- UnsupReq- ACSViol- > UEMsk: DLP- SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt+ RxOF- MalfTLP- ECRC- UnsupReq- ACSViol- > UESvrt: DLP+ SDES- TLP- FCP- CmpltTO- CmpltAbrt- UnxCmplt- RxOF+ MalfTLP+ ECRC- UnsupReq- ACSViol- > CESta: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr- > CEMsk: RxErr- BadTLP- BadDLLP- Rollover- Timeout- AdvNonFatalErr+ > AERCap: First Error Pointer: 00, ECRCGenCap- ECRCGenEn- ECRCChkCap- ECRCChkEn- > MultHdrRecCap- MultHdrRecEn- TLPPfxPres- HdrLogCap- > HeaderLog: 00000000 00000000 00000000 00000000 > RootCmd: CERptEn+ NFERptEn+ FERptEn+ > RootSta: CERcvd- MultCERcvd- UERcvd- MultUERcvd- > FirstFatal- NonFatalMsg- FatalMsg- IntMsg 0 > ErrorSrc: ERR_COR: 0000 ERR_FATAL/NONFATAL: 0000 > Capabilities: [140 v1] Access Control Services > ACSCap: SrcValid+ TransBlk+ ReqRedir+ CmpltRedir+ UpstreamFwd- EgressCtrl- DirectTrans- > ACSCtl: SrcValid+ TransBlk- ReqRedir+ CmpltRedir+ UpstreamFwd- EgressCtrl- DirectTrans- > Capabilities: [150 v1] Precision Time Measurement > PTMCap: Requester:- Responder:+ Root:+ > PTMClockGranularity: 4ns > PTMControl: Enabled:+ RootSelected:+ > PTMEffectiveGranularity: Unknown > Capabilities: [200 v1] L1 PM Substates > L1SubCap: PCI-PM_L1.2+ PCI-PM_L1.1+ ASPM_L1.2+ ASPM_L1.1+ L1_PM_Substates+ > PortCommonModeRestoreTime=40us PortTPowerOnTime=44us > L1SubCtl1: PCI-PM_L1.2+ PCI-PM_L1.1- ASPM_L1.2+ ASPM_L1.1- > T_CommonMode=40us LTR1.2_Threshold=65536ns > L1SubCtl2: T_PwrOn=44us > Capabilities: [220 v1] Secondary PCI Express > LnkCtl3: LnkEquIntrruptEn- PerformEqu- > LaneErrStat: 0 > Capabilities: [250 v1] Downstream Port Containment > DpcCap: INT Msg #0, RPExt+ PoisonedTLP+ SwTrigger+ RP PIO Log 4, DL_ActiveErr+ > DpcCtl: Trigger:1 Cmpl- INT+ ErrCor- PoisonedTLP- SwTrigger- DL_ActiveErr- > DpcSta: Trigger- Reason:00 INT- RPBusy- TriggerExt:00 RP PIO ErrPtr:1f > Source: 0000 > Kernel driver in use: pcieport > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if 02 [NVM Express]) > Subsystem: Sandisk Corp Device 501a > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- Latency: 0, Cache Line Size: 64 bytes > Interrupt: pin A routed to IRQ 16 > NUMA node: 0 > IOMMU group: 13 > Region 0: Memory at a2600000 (64-bit, non-prefetchable) [size=16K] > Region 4: Memory at a2604000 (64-bit, non-prefetchable) [size=256] I think I'm slightly confused, the overlapping happens at: (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted So it's MFNs 0xa2616 and 0xa2504, yet none of those are in the BAR ranges of this device. Can you paste the lspci -vvv output for any other device you are also passing through to this guest? Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 13:46:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 13:46:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360375.589729 (Exim 4.92) (envelope-from ) id 1o8MP2-0007rw-N9; Mon, 04 Jul 2022 13:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360375.589729; Mon, 04 Jul 2022 13:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8MP2-0007rp-KO; Mon, 04 Jul 2022 13:46:16 +0000 Received: by outflank-mailman (input) for mailman id 360375; Mon, 04 Jul 2022 13:46:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8MP2-0007rj-19 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 13:46:16 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ab93f71e-fb9f-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 15:46:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7F6172281F; Mon, 4 Jul 2022 13:46:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 57ED713451; Mon, 4 Jul 2022 13:46:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XmAyFCXvwmIWTQAAMHmgww (envelope-from ); Mon, 04 Jul 2022 13:46:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ab93f71e-fb9f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1656942373; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fl5l9I6WsRK1qr9A0067bXv2MqCT0sQnOAP1WCC7YQ0=; b=CeFmmjJrcRvNLyQ20qNxBV5Ya95RuxvQgB4xlGne+267lztMwhsd1oD84orTYyDXzQKv5T LYUsV2cYO21/UO2GOOZ1mSMnXvw8xPpdSznqaxhXm1Awlsg6PThDTG8iq3I/pMmE0BD4vl 9gMF7cKyU29yfnnMER8V3EMnEPMB2lM= Message-ID: Date: Mon, 4 Jul 2022 15:46:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Hopefully correct backports for gntdev deadlock Content-Language: en-US To: Demi Marie Obenour , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion References: <20220701000951.5072-1-demi@invisiblethingslab.com> From: Juergen Gross In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------Vz0g3DiMkO808ZAmkMQiZxLV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------Vz0g3DiMkO808ZAmkMQiZxLV Content-Type: multipart/mixed; boundary="------------qk6Lgr0KLo4043DZUgcEpPXD"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Greg KH Cc: stable@vger.kernel.org, Xen developer discussion Message-ID: Subject: Re: Hopefully correct backports for gntdev deadlock References: <20220701000951.5072-1-demi@invisiblethingslab.com> In-Reply-To: <20220701000951.5072-1-demi@invisiblethingslab.com> --------------qk6Lgr0KLo4043DZUgcEpPXD Content-Type: multipart/mixed; boundary="------------ai1fu7we68Z0vxqNj0p0FHiB" --------------ai1fu7we68Z0vxqNj0p0FHiB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDEuMDcuMjIgMDI6MDksIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gVGhpcyBi YWNrcG9ydHMgInhlbi9nbnRkZXY6IEF2b2lkIGJsb2NraW5nIGluIHVubWFwX2dyYW50X3Bh Z2VzKCkiIHRvDQo+IHRoZSB2YXJpb3VzIHN0YWJsZSB0cmVlcywgaG9wZWZ1bGx5IGNvcnJl Y3RseS4NCj4gDQoNCkkgaGF2ZSByZXZpZXdlZCBhbGwgYmFja3BvcnRzIGFuZCB0aGV5IHNl ZW0gY29ycmVjdCB0byBtZS4NCg0KR3JlZywgSSdtIGZpbmUgd2l0aCB5b3UgYWRkaW5nIHRo ZSBiYWNrcG9ydHMgdG8gdGhlIHJlbGF0ZWQgc3RhYmxlDQpicmFuY2hlcy4NCg0KDQpUaGFu a3MsDQoNCkp1ZXJnZW4NCg== --------------ai1fu7we68Z0vxqNj0p0FHiB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ai1fu7we68Z0vxqNj0p0FHiB-- --------------qk6Lgr0KLo4043DZUgcEpPXD-- --------------Vz0g3DiMkO808ZAmkMQiZxLV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLC7yQFAwAAAAAACgkQsN6d1ii/Ey8w xQf+Mr+KRji1iAWtaDWYXPbukyBn2Us2gThiJaGBJxNG8D2vvIm8uHpXYLiqPTvVdr6nIW8ESn73 ejnklfxRBVRo/6yscN9CShjfS8rUECHFhvBK2CXIDREHA8S0Z9co30yVCD2KlzUOJ7rlerEta/qx KOGQiZKv9v2m3sp5q9ZN2u8wGlwqfEWukrxDj0ydqr1TddLLwZka+gHSkAMDZXIxH387soepXka5 SGrdjcQ4wZkBJhDNPvL5SV1L0EpVLKpEpmSS5rJ9NOVhzToKXB/K7y/YPuwwiRP8kEmlzQ8dYMaG f1J+7S9zbAOrwmn7mwoIKXZ9uEPP2xFU4CPu7o9GoA== =f8Sz -----END PGP SIGNATURE----- --------------Vz0g3DiMkO808ZAmkMQiZxLV-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 14:00:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 14:00:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360384.589740 (Exim 4.92) (envelope-from ) id 1o8McY-0001y8-2m; Mon, 04 Jul 2022 14:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360384.589740; Mon, 04 Jul 2022 14:00:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8McX-0001y1-VQ; Mon, 04 Jul 2022 14:00:13 +0000 Received: by outflank-mailman (input) for mailman id 360384; Mon, 04 Jul 2022 14:00:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8McW-0001xr-Fi; Mon, 04 Jul 2022 14:00:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8McW-0000RT-9F; Mon, 04 Jul 2022 14:00:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8McV-00067R-RN; Mon, 04 Jul 2022 14:00:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8McV-0006eX-Qy; Mon, 04 Jul 2022 14:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CEgRlE3GCs99hIfsbCZk308ObvNMu7k1LSNIR+B3StE=; b=g1I3QseaRRBc0/HOR1J7Fm6F8s RNgLjwCDxb7HB+5al5ByrMBH3rH/OC/jcPGKF/TRazlQQOJxpr2l2qJI5cWD7o2iNt8N/NO1TQgQf acK0aA7xZF+Q39qJoZWtEWBgflQS2DQKq8n4LfQWLxLRuLeW5fgSWngwQVunP8AunzA8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171478: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88084a3df1672e131ddc1b4e39eeacfd39864acf X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Mon, 04 Jul 2022 14:00:11 +0000 flight 171478 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171478/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 88084a3df1672e131ddc1b4e39eeacfd39864acf baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 15 days Failing since 171280 2022-06-19 15:12:25 Z 14 days 40 attempts Testing same since 171478 2022-07-04 02:52:16 Z 0 days 1 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 18547 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 14:52:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 14:52:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360403.589758 (Exim 4.92) (envelope-from ) id 1o8NQn-0007ZW-3f; Mon, 04 Jul 2022 14:52:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360403.589758; Mon, 04 Jul 2022 14:52:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8NQm-0007ZP-Vk; Mon, 04 Jul 2022 14:52:08 +0000 Received: by outflank-mailman (input) for mailman id 360403; Mon, 04 Jul 2022 14:52:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8NQl-0007ZH-Oz for xen-devel@lists.xen.org; Mon, 04 Jul 2022 14:52:07 +0000 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dee1778c-fba8-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 16:52:05 +0200 (CEST) Received: by mail-ej1-f45.google.com with SMTP id h23so17104444ejj.12 for ; Mon, 04 Jul 2022 07:52:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee1778c-fba8-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3pIAl9Nd16M7yzwRS1EMjSmKFcFduFAoWG7kH5ZmdQw=; b=7aR0l7SY2Creb6TKQm9K+eGyDH72YfcAUPs1pCghG0yX44Fl0e0EmJMVja6ut9MhxT 8HDSs8GlRG21ZzrzkYZ2H68eLcArKUyRPLPIWu4Z05tVJujE1GzpPfvQDzfblD65oqnX w02HdYfefnFN55Kw221hJ5MSf31g2czLgCNO17E5r7fr5Xt5r9Aw2+3z4GyTF86PnOFE WILayVBoCdjIag5rZfQRJL+Z4zq1Cen4FY8mKpE8gAUmFdQeH4mmHizL0FHJ6L6Bjrur dPuzX7DrZCx+kdohzS61vFExNBe7yx0/pV75ysxKrXkF7t/5zo+erHd3XcrgWlz5l8MM 5gHA== X-Gm-Message-State: AJIora+/zNcZ5PjpVWLQIsrcWQTSg36DT89u1SgUZGtxBAY0rAaoNBrX hRArwQ8DvLOYPMeQ/WIhcj4Z5VJOuuA0M3NXFfA= X-Google-Smtp-Source: AGRyM1uxt+LWuG0PN2I3Yu392m1bm8wb4gIOXBGJpTlEKrp/Gy1Dx5hABKOsfDLgcSWq6vSv6cjzByyngHbwna3Rr3U= X-Received: by 2002:a17:907:1c08:b0:72a:8a2d:db4a with SMTP id nc8-20020a1709071c0800b0072a8a2ddb4amr18186423ejc.89.1656946325147; Mon, 04 Jul 2022 07:52:05 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 22:51:53 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel Content-Type: multipart/mixed; boundary="0000000000001f998405e2fbe1dd" --0000000000001f998405e2fbe1dd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monn=C3=A9 = wrote: > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-= if 02 [NVM Express]) > > Subsystem: Sandisk Corp Device 501a > > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParEr= r- Stepping- SERR- FastB2B- DisINTx+ > > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbort- = SERR- > Latency: 0, Cache Line Size: 64 bytes > > Interrupt: pin A routed to IRQ 16 > > NUMA node: 0 > > IOMMU group: 13 > > Region 0: Memory at a2600000 (64-bit, non-prefetchable) [size=3D1= 6K] > > Region 4: Memory at a2604000 (64-bit, non-prefetchable) [size=3D2= 56] > > I think I'm slightly confused, the overlapping happens at: > > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > > So it's MFNs 0xa2616 and 0xa2504, yet none of those are in the BAR > ranges of this device. > > Can you paste the lspci -vvv output for any other device you are also > passing through to this guest? > I just realized that the address may change in different environments. In previous email chains, I used a cached dump from a Linux environment running outside the hypervisor. Sorry for the confusion. Refreshing with a XEN dom0 dump. The other device I used is a SATA controller. I think I can get what you are looking for now. Both a2616 and a2504 are found! 00:17.0 SATA controller: Intel Corporation Cannon Lake PCH SATA AHCI Controller (rev 10) (prog-if 01 [AHCI 1.0]) DeviceName: Onboard - SATA Subsystem: Gigabyte Technology Co., Ltd Cannon Lake PCH SATA AHCI Controller Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=3Dmedium >TAbort- SERR- TAbort- SERR- Thanks, Roger. --0000000000001f998405e2fbe1dd Content-Type: text/plain; charset="US-ASCII"; name="lspcivvv_cutdown_refreshed.txt" Content-Disposition: attachment; filename="lspcivvv_cutdown_refreshed.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56uy6wy0 MDA6MTcuMCBTQVRBIGNvbnRyb2xsZXI6IEludGVsIENvcnBvcmF0aW9uIENhbm5vbiBMYWtlIFBD SCBTQVRBIEFIQ0kgQ29udHJvbGxlciAocmV2IDEwKSAocHJvZy1pZiAwMSBbQUhDSSAxLjBdKQoJ RGV2aWNlTmFtZTogT25ib2FyZCAtIFNBVEEKCVN1YnN5c3RlbTogR2lnYWJ5dGUgVGVjaG5vbG9n eSBDby4sIEx0ZCBDYW5ub24gTGFrZSBQQ0ggU0FUQSBBSENJIENvbnRyb2xsZXIKCUNvbnRyb2w6 IEkvTysgTWVtKyBCdXNNYXN0ZXItIFNwZWNDeWNsZS0gTWVtV0lOVi0gVkdBU25vb3AtIFBhckVy ci0gU3RlcHBpbmctIFNFUlItIEZhc3RCMkItIERpc0lOVHgtCglTdGF0dXM6IENhcCsgNjZNSHor IFVERi0gRmFzdEIyQisgUGFyRXJyLSBERVZTRUw9bWVkaXVtID5UQWJvcnQtIDxUQWJvcnQtIDxN QWJvcnQtID5TRVJSLSA8UEVSUi0gSU5UeC0KCUludGVycnVwdDogcGluIEEgcm91dGVkIHRvIElS USAxNgoJUmVnaW9uIDA6IE1lbW9yeSBhdCBhMjYxMDAwMCAoMzItYml0LCBub24tcHJlZmV0Y2hh YmxlKSBbc2l6ZT04S10KCVJlZ2lvbiAxOiBNZW1vcnkgYXQgYTI2MTYwMDAgKDMyLWJpdCwgbm9u LXByZWZldGNoYWJsZSkgW3NpemU9MjU2XQoJUmVnaW9uIDI6IEkvTyBwb3J0cyBhdCA0MDkwIFtz aXplPThdCglSZWdpb24gMzogSS9PIHBvcnRzIGF0IDQwODAgW3NpemU9NF0KCVJlZ2lvbiA0OiBJ L08gcG9ydHMgYXQgNDA2MCBbc2l6ZT0zMl0KCVJlZ2lvbiA1OiBNZW1vcnkgYXQgYTI2MTUwMDAg KDMyLWJpdCwgbm9uLXByZWZldGNoYWJsZSkgW3NpemU9MktdCglDYXBhYmlsaXRpZXM6IFs4MF0g TVNJOiBFbmFibGUtIENvdW50PTEvMSBNYXNrYWJsZS0gNjRiaXQtCgkJQWRkcmVzczogMDAwMDAw MDAgIERhdGE6IDAwMDAKCUNhcGFiaWxpdGllczogWzcwXSBQb3dlciBNYW5hZ2VtZW50IHZlcnNp b24gMwoJCUZsYWdzOiBQTUVDbGstIERTSS0gRDEtIEQyLSBBdXhDdXJyZW50PTBtQSBQTUUoRDAt LEQxLSxEMi0sRDNob3QrLEQzY29sZC0pCgkJU3RhdHVzOiBEMCBOb1NvZnRSc3QrIFBNRS1FbmFi bGUtIERTZWw9MCBEU2NhbGU9MCBQTUUtCglDYXBhYmlsaXRpZXM6IFthOF0gU0FUQSBIQkEgdjEu MCBCQVI0IE9mZnNldD0wMDAwMDAwNAoJS2VybmVsIGRyaXZlciBpbiB1c2U6IHBjaWJhY2sKCUtl cm5lbCBtb2R1bGVzOiBhaGNpCgowMDoxZC4wIFBDSSBicmlkZ2U6IEludGVsIENvcnBvcmF0aW9u IENhbm5vbiBMYWtlIFBDSCBQQ0kgRXhwcmVzcyBSb290IFBvcnQgIzkgKHJldiBmMCkgKHByb2ct aWYgMDAgW05vcm1hbCBkZWNvZGVdKQoJQ29udHJvbDogSS9PKyBNZW0rIEJ1c01hc3RlcisgU3Bl Y0N5Y2xlLSBNZW1XSU5WLSBWR0FTbm9vcC0gUGFyRXJyLSBTdGVwcGluZy0gU0VSUi0gRmFzdEIy Qi0gRGlzSU5UeCsKCVN0YXR1czogQ2FwKyA2Nk1Iei0gVURGLSBGYXN0QjJCLSBQYXJFcnItIERF VlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQtIDxNQWJvcnQtID5TRVJSLSA8UEVSUi0gSU5UeC0K CUxhdGVuY3k6IDAsIENhY2hlIExpbmUgU2l6ZTogNjQgYnl0ZXMKCUludGVycnVwdDogcGluIEEg cm91dGVkIHRvIElSUSAxNTAKCUJ1czogcHJpbWFyeT0wMCwgc2Vjb25kYXJ5PTA1LCBzdWJvcmRp bmF0ZT0wNSwgc2VjLWxhdGVuY3k9MAoJSS9PIGJlaGluZCBicmlkZ2U6IDAwMDBmMDAwLTAwMDAw ZmZmIFtkaXNhYmxlZF0KCU1lbW9yeSBiZWhpbmQgYnJpZGdlOiBhMjUwMDAwMC1hMjVmZmZmZiBb c2l6ZT0xTV0KCVByZWZldGNoYWJsZSBtZW1vcnkgYmVoaW5kIGJyaWRnZTogMDAwMDAwMDBmZmYw MDAwMC0wMDAwMDAwMDAwMGZmZmZmIFtkaXNhYmxlZF0KCVNlY29uZGFyeSBzdGF0dXM6IDY2TUh6 LSBGYXN0QjJCLSBQYXJFcnItIERFVlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQtIDxNQWJvcnQr IDxTRVJSLSA8UEVSUi0KCUJyaWRnZUN0bDogUGFyaXR5LSBTRVJSKyBOb0lTQS0gVkdBLSBWR0Ex NisgTUFib3J0LSA+UmVzZXQtIEZhc3RCMkItCgkJUHJpRGlzY1Rtci0gU2VjRGlzY1Rtci0gRGlz Y1RtclN0YXQtIERpc2NUbXJTRVJSRW4tCglDYXBhYmlsaXRpZXM6IFs0MF0gRXhwcmVzcyAodjIp IFJvb3QgUG9ydCAoU2xvdCspLCBNU0kgMDAKCQlEZXZDYXA6CU1heFBheWxvYWQgMjU2IGJ5dGVz LCBQaGFudEZ1bmMgMAoJCQlFeHRUYWctIFJCRSsKCQlEZXZDdGw6CUNvcnJFcnIrIE5vbkZhdGFs RXJyKyBGYXRhbEVycisgVW5zdXBSZXErCgkJCVJseGRPcmQtIEV4dFRhZy0gUGhhbnRGdW5jLSBB dXhQd3ItIE5vU25vb3AtCgkJCU1heFBheWxvYWQgMjU2IGJ5dGVzLCBNYXhSZWFkUmVxIDEyOCBi eXRlcwoJCURldlN0YToJQ29yckVyci0gTm9uRmF0YWxFcnItIEZhdGFsRXJyLSBVbnN1cFJlcS0g QXV4UHdyKyBUcmFuc1BlbmQtCgkJTG5rQ2FwOglQb3J0ICM5LCBTcGVlZCA4R1QvcywgV2lkdGgg eDQsIEFTUE0gTDBzIEwxLCBFeGl0IExhdGVuY3kgTDBzIDwxdXMsIEwxIDwxNnVzCgkJCUNsb2Nr UE0tIFN1cnByaXNlLSBMTEFjdFJlcCsgQndOb3QrIEFTUE1PcHRDb21wKwoJCUxua0N0bDoJQVNQ TSBMMSBFbmFibGVkOyBSQ0IgNjQgYnl0ZXMsIERpc2FibGVkLSBDb21tQ2xrKwoJCQlFeHRTeW5j aC0gQ2xvY2tQTS0gQXV0V2lkRGlzLSBCV0ludC0gQXV0QldJbnQtCgkJTG5rU3RhOglTcGVlZCA4 R1QvcyAob2spLCBXaWR0aCB4NCAob2spCgkJCVRyRXJyLSBUcmFpbi0gU2xvdENsaysgRExBY3Rp dmUrIEJXTWdtdCsgQUJXTWdtdC0KCQlTbHRDYXA6CUF0dG5CdG4tIFB3ckN0cmwtIE1STC0gQXR0 bkluZC0gUHdySW5kLSBIb3RQbHVnLSBTdXJwcmlzZS0KCQkJU2xvdCAjMTIsIFBvd2VyTGltaXQg MjUuMDAwVzsgSW50ZXJsb2NrLSBOb0NvbXBsKwoJCVNsdEN0bDoJRW5hYmxlOiBBdHRuQnRuLSBQ d3JGbHQtIE1STC0gUHJlc0RldC0gQ21kQ3BsdC0gSFBJcnEtIExpbmtDaGctCgkJCUNvbnRyb2w6 IEF0dG5JbmQgVW5rbm93biwgUHdySW5kIFVua25vd24sIFBvd2VyLSBJbnRlcmxvY2stCgkJU2x0 U3RhOglTdGF0dXM6IEF0dG5CdG4tIFBvd2VyRmx0LSBNUkwtIENtZENwbHQtIFByZXNEZXQrIElu dGVybG9jay0KCQkJQ2hhbmdlZDogTVJMLSBQcmVzRGV0LSBMaW5rU3RhdGUrCgkJUm9vdENhcDog Q1JTVmlzaWJsZS0KCQlSb290Q3RsOiBFcnJDb3JyZWN0YWJsZS0gRXJyTm9uLUZhdGFsLSBFcnJG YXRhbC0gUE1FSW50RW5hLSBDUlNWaXNpYmxlLQoJCVJvb3RTdGE6IFBNRSBSZXFJRCAwMDAwLCBQ TUVTdGF0dXMtIFBNRVBlbmRpbmctCgkJRGV2Q2FwMjogQ29tcGxldGlvbiBUaW1lb3V0OiBSYW5n ZSBBQkMsIFRpbWVvdXREaXMrIE5ST1ByUHJQLSBMVFIrCgkJCSAxMEJpdFRhZ0NvbXAtIDEwQml0 VGFnUmVxLSBPQkZGIE5vdCBTdXBwb3J0ZWQsIEV4dEZtdC0gRUVUTFBQcmVmaXgtCgkJCSBFbWVy Z2VuY3lQb3dlclJlZHVjdGlvbiBOb3QgU3VwcG9ydGVkLCBFbWVyZ2VuY3lQb3dlclJlZHVjdGlv bkluaXQtCgkJCSBGUlMtIExOIFN5c3RlbSBDTFMgTm90IFN1cHBvcnRlZCwgVFBIQ29tcC0gRXh0 VFBIQ29tcC0gQVJJRndkKwoJCQkgQXRvbWljT3BzQ2FwOiBSb3V0aW5nLSAzMmJpdC0gNjRiaXQt IDEyOGJpdENBUy0KCQlEZXZDdGwyOiBDb21wbGV0aW9uIFRpbWVvdXQ6IDUwdXMgdG8gNTBtcywg VGltZW91dERpcy0gTFRSKyBPQkZGIERpc2FibGVkLCBBUklGd2QtCgkJCSBBdG9taWNPcHNDdGw6 IFJlcUVuLSBFZ3Jlc3NCbGNrLQoJCUxua0NhcDI6IFN1cHBvcnRlZCBMaW5rIFNwZWVkczogMi41 LThHVC9zLCBDcm9zc2xpbmstIFJldGltZXItIDJSZXRpbWVycy0gRFJTLQoJCUxua0N0bDI6IFRh cmdldCBMaW5rIFNwZWVkOiA4R1QvcywgRW50ZXJDb21wbGlhbmNlLSBTcGVlZERpcy0KCQkJIFRy YW5zbWl0IE1hcmdpbjogTm9ybWFsIE9wZXJhdGluZyBSYW5nZSwgRW50ZXJNb2RpZmllZENvbXBs aWFuY2UtIENvbXBsaWFuY2VTT1MtCgkJCSBDb21wbGlhbmNlIERlLWVtcGhhc2lzOiAtNmRCCgkJ TG5rU3RhMjogQ3VycmVudCBEZS1lbXBoYXNpcyBMZXZlbDogLTMuNWRCLCBFcXVhbGl6YXRpb25D b21wbGV0ZSsgRXF1YWxpemF0aW9uUGhhc2UxKwoJCQkgRXF1YWxpemF0aW9uUGhhc2UyKyBFcXVh bGl6YXRpb25QaGFzZTMrIExpbmtFcXVhbGl6YXRpb25SZXF1ZXN0LQoJCQkgUmV0aW1lci0gMlJl dGltZXJzLSBDcm9zc2xpbmtSZXM6IHVuc3VwcG9ydGVkCglDYXBhYmlsaXRpZXM6IFs4MF0gTVNJ OiBFbmFibGUrIENvdW50PTEvMSBNYXNrYWJsZS0gNjRiaXQtCgkJQWRkcmVzczogZmVlMDBmOTgg IERhdGE6IDAwMDAKCUNhcGFiaWxpdGllczogWzkwXSBTdWJzeXN0ZW06IEdpZ2FieXRlIFRlY2hu b2xvZ3kgQ28uLCBMdGQgQ2Fubm9uIExha2UgUENIIFBDSSBFeHByZXNzIFJvb3QgUG9ydAoJQ2Fw YWJpbGl0aWVzOiBbYTBdIFBvd2VyIE1hbmFnZW1lbnQgdmVyc2lvbiAzCgkJRmxhZ3M6IFBNRUNs ay0gRFNJLSBEMS0gRDItIEF1eEN1cnJlbnQ9MG1BIFBNRShEMCssRDEtLEQyLSxEM2hvdCssRDNj b2xkKykKCQlTdGF0dXM6IEQwIE5vU29mdFJzdC0gUE1FLUVuYWJsZS0gRFNlbD0wIERTY2FsZT0w IFBNRS0KCUNhcGFiaWxpdGllczogWzEwMCB2MV0gQWR2YW5jZWQgRXJyb3IgUmVwb3J0aW5nCgkJ VUVTdGE6CURMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0gVW54Q21wbHQt IFJ4T0YtIE1hbGZUTFAtIEVDUkMtIFVuc3VwUmVxLSBBQ1NWaW9sLQoJCVVFTXNrOglETFAtIFNE RVMtIFRMUC0gRkNQLSBDbXBsdFRPLSBDbXBsdEFicnQtIFVueENtcGx0KyBSeE9GLSBNYWxmVExQ LSBFQ1JDLSBVbnN1cFJlcS0gQUNTVmlvbC0KCQlVRVN2cnQ6CURMUCsgU0RFUy0gVExQLSBGQ1At IENtcGx0VE8tIENtcGx0QWJydC0gVW54Q21wbHQtIFJ4T0YrIE1hbGZUTFArIEVDUkMtIFVuc3Vw UmVxLSBBQ1NWaW9sLQoJCUNFU3RhOglSeEVyci0gQmFkVExQLSBCYWRETExQLSBSb2xsb3Zlci0g VGltZW91dC0gQWR2Tm9uRmF0YWxFcnItCgkJQ0VNc2s6CVJ4RXJyLSBCYWRUTFAtIEJhZERMTFAt IFJvbGxvdmVyLSBUaW1lb3V0LSBBZHZOb25GYXRhbEVycisKCQlBRVJDYXA6CUZpcnN0IEVycm9y IFBvaW50ZXI6IDAwLCBFQ1JDR2VuQ2FwLSBFQ1JDR2VuRW4tIEVDUkNDaGtDYXAtIEVDUkNDaGtF bi0KCQkJTXVsdEhkclJlY0NhcC0gTXVsdEhkclJlY0VuLSBUTFBQZnhQcmVzLSBIZHJMb2dDYXAt CgkJSGVhZGVyTG9nOiAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMCAwMDAwMDAwMAoJCVJvb3RD bWQ6IENFUnB0RW4rIE5GRVJwdEVuKyBGRVJwdEVuKwoJCVJvb3RTdGE6IENFUmN2ZC0gTXVsdENF UmN2ZC0gVUVSY3ZkLSBNdWx0VUVSY3ZkLQoJCQkgRmlyc3RGYXRhbC0gTm9uRmF0YWxNc2ctIEZh dGFsTXNnLSBJbnRNc2cgMAoJCUVycm9yU3JjOiBFUlJfQ09SOiAwMDAwIEVSUl9GQVRBTC9OT05G QVRBTDogMDAwMAoJQ2FwYWJpbGl0aWVzOiBbMTQwIHYxXSBBY2Nlc3MgQ29udHJvbCBTZXJ2aWNl cwoJCUFDU0NhcDoJU3JjVmFsaWQrIFRyYW5zQmxrKyBSZXFSZWRpcisgQ21wbHRSZWRpcisgVXBz dHJlYW1Gd2QtIEVncmVzc0N0cmwtIERpcmVjdFRyYW5zLQoJCUFDU0N0bDoJU3JjVmFsaWQrIFRy YW5zQmxrLSBSZXFSZWRpcisgQ21wbHRSZWRpcisgVXBzdHJlYW1Gd2QtIEVncmVzc0N0cmwtIERp cmVjdFRyYW5zLQoJQ2FwYWJpbGl0aWVzOiBbMTUwIHYxXSBQcmVjaXNpb24gVGltZSBNZWFzdXJl bWVudAoJCVBUTUNhcDogUmVxdWVzdGVyOi0gUmVzcG9uZGVyOisgUm9vdDorCgkJUFRNQ2xvY2tH cmFudWxhcml0eTogNG5zCgkJUFRNQ29udHJvbDogRW5hYmxlZDorIFJvb3RTZWxlY3RlZDorCgkJ UFRNRWZmZWN0aXZlR3JhbnVsYXJpdHk6IFVua25vd24KCUNhcGFiaWxpdGllczogWzIwMCB2MV0g TDEgUE0gU3Vic3RhdGVzCgkJTDFTdWJDYXA6IFBDSS1QTV9MMS4yKyBQQ0ktUE1fTDEuMSsgQVNQ TV9MMS4yKyBBU1BNX0wxLjErIEwxX1BNX1N1YnN0YXRlcysKCQkJICBQb3J0Q29tbW9uTW9kZVJl c3RvcmVUaW1lPTQwdXMgUG9ydFRQb3dlck9uVGltZT00NHVzCgkJTDFTdWJDdGwxOiBQQ0ktUE1f TDEuMisgUENJLVBNX0wxLjEtIEFTUE1fTDEuMisgQVNQTV9MMS4xLQoJCQkgICBUX0NvbW1vbk1v ZGU9NDB1cyBMVFIxLjJfVGhyZXNob2xkPTY1NTM2bnMKCQlMMVN1YkN0bDI6IFRfUHdyT249NDR1 cwoJQ2FwYWJpbGl0aWVzOiBbMjIwIHYxXSBTZWNvbmRhcnkgUENJIEV4cHJlc3MKCQlMbmtDdGwz OiBMbmtFcXVJbnRycnVwdEVuLSBQZXJmb3JtRXF1LQoJCUxhbmVFcnJTdGF0OiAwCglDYXBhYmls aXRpZXM6IFsyNTAgdjFdIERvd25zdHJlYW0gUG9ydCBDb250YWlubWVudAoJCURwY0NhcDoJSU5U IE1zZyAjMCwgUlBFeHQrIFBvaXNvbmVkVExQKyBTd1RyaWdnZXIrIFJQIFBJTyBMb2cgNCwgRExf QWN0aXZlRXJyKwoJCURwY0N0bDoJVHJpZ2dlcjoxIENtcGwtIElOVCsgRXJyQ29yLSBQb2lzb25l ZFRMUC0gU3dUcmlnZ2VyLSBETF9BY3RpdmVFcnItCgkJRHBjU3RhOglUcmlnZ2VyLSBSZWFzb246 MDAgSU5ULSBSUEJ1c3ktIFRyaWdnZXJFeHQ6MDAgUlAgUElPIEVyclB0cjoxZgoJCVNvdXJjZToJ MDAwMAoJS2VybmVsIGRyaXZlciBpbiB1c2U6IHBjaWVwb3J0CgowNTowMC4wIE5vbi1Wb2xhdGls ZSBtZW1vcnkgY29udHJvbGxlcjogU2FuZGlzayBDb3JwIERldmljZSA1MDFhIChwcm9nLWlmIDAy IFtOVk0gRXhwcmVzc10pCglTdWJzeXN0ZW06IFNhbmRpc2sgQ29ycCBEZXZpY2UgNTAxYQoJQ29u dHJvbDogSS9PKyBNZW0rIEJ1c01hc3RlcisgU3BlY0N5Y2xlLSBNZW1XSU5WLSBWR0FTbm9vcC0g UGFyRXJyLSBTdGVwcGluZy0gU0VSUi0gRmFzdEIyQi0gRGlzSU5UeC0KCVN0YXR1czogQ2FwKyA2 Nk1Iei0gVURGLSBGYXN0QjJCLSBQYXJFcnItIERFVlNFTD1mYXN0ID5UQWJvcnQtIDxUQWJvcnQt IDxNQWJvcnQtID5TRVJSLSA8UEVSUi0gSU5UeC0KCUxhdGVuY3k6IDAsIENhY2hlIExpbmUgU2l6 ZTogNjQgYnl0ZXMKCUludGVycnVwdDogcGluIEEgcm91dGVkIHRvIElSUSAxMQoJUmVnaW9uIDA6 IE1lbW9yeSBhdCBhMjUwMDAwMCAoNjQtYml0LCBub24tcHJlZmV0Y2hhYmxlKSBbc2l6ZT0xNktd CglSZWdpb24gNDogTWVtb3J5IGF0IGEyNTA0MDAwICg2NC1iaXQsIG5vbi1wcmVmZXRjaGFibGUp IFtzaXplPTI1Nl0KCUNhcGFiaWxpdGllczogWzgwXSBQb3dlciBNYW5hZ2VtZW50IHZlcnNpb24g MwoJCUZsYWdzOiBQTUVDbGstIERTSS0gRDEtIEQyLSBBdXhDdXJyZW50PTBtQSBQTUUoRDAtLEQx LSxEMi0sRDNob3QtLEQzY29sZC0pCgkJU3RhdHVzOiBEMCBOb1NvZnRSc3QrIFBNRS1FbmFibGUt IERTZWw9MCBEU2NhbGU9MCBQTUUtCglDYXBhYmlsaXRpZXM6IFs5MF0gTVNJOiBFbmFibGUtIENv dW50PTEvMzIgTWFza2FibGUtIDY0Yml0KwoJCUFkZHJlc3M6IDAwMDAwMDAwMDAwMDAwMDAgIERh dGE6IDAwMDAKCUNhcGFiaWxpdGllczogW2IwXSBNU0ktWDogRW5hYmxlLSBDb3VudD0xNyBNYXNr ZWQtCgkJVmVjdG9yIHRhYmxlOiBCQVI9MCBvZmZzZXQ9MDAwMDIwMDAKCQlQQkE6IEJBUj00IG9m ZnNldD0wMDAwMDAwMAoJQ2FwYWJpbGl0aWVzOiBbYzBdIEV4cHJlc3MgKHYyKSBFbmRwb2ludCwg TVNJIDAwCgkJRGV2Q2FwOglNYXhQYXlsb2FkIDUxMiBieXRlcywgUGhhbnRGdW5jIDAsIExhdGVu Y3kgTDBzIDwxdXMsIEwxIHVubGltaXRlZAoJCQlFeHRUYWctIEF0dG5CdG4tIEF0dG5JbmQtIFB3 ckluZC0gUkJFKyBGTFJlc2V0KyBTbG90UG93ZXJMaW1pdCAwLjAwMFcKCQlEZXZDdGw6CUNvcnJF cnItIE5vbkZhdGFsRXJyLSBGYXRhbEVyci0gVW5zdXBSZXEtCgkJCVJseGRPcmQrIEV4dFRhZy0g UGhhbnRGdW5jLSBBdXhQd3ItIE5vU25vb3ArIEZMUmVzZXQtCgkJCU1heFBheWxvYWQgMjU2IGJ5 dGVzLCBNYXhSZWFkUmVxIDUxMiBieXRlcwoJCURldlN0YToJQ29yckVyci0gTm9uRmF0YWxFcnIt IEZhdGFsRXJyLSBVbnN1cFJlcS0gQXV4UHdyLSBUcmFuc1BlbmQtCgkJTG5rQ2FwOglQb3J0ICMw LCBTcGVlZCA4R1QvcywgV2lkdGggeDQsIEFTUE0gTDEsIEV4aXQgTGF0ZW5jeSBMMSA8OHVzCgkJ CUNsb2NrUE0rIFN1cnByaXNlLSBMTEFjdFJlcC0gQndOb3QtIEFTUE1PcHRDb21wKwoJCUxua0N0 bDoJQVNQTSBMMSBFbmFibGVkOyBSQ0IgNjQgYnl0ZXMsIERpc2FibGVkLSBDb21tQ2xrKwoJCQlF eHRTeW5jaC0gQ2xvY2tQTSsgQXV0V2lkRGlzLSBCV0ludC0gQXV0QldJbnQtCgkJTG5rU3RhOglT cGVlZCA4R1QvcyAob2spLCBXaWR0aCB4NCAob2spCgkJCVRyRXJyLSBUcmFpbi0gU2xvdENsaysg RExBY3RpdmUtIEJXTWdtdC0gQUJXTWdtdC0KCQlEZXZDYXAyOiBDb21wbGV0aW9uIFRpbWVvdXQ6 IFJhbmdlIEIsIFRpbWVvdXREaXMrIE5ST1ByUHJQLSBMVFIrCgkJCSAxMEJpdFRhZ0NvbXAtIDEw Qml0VGFnUmVxLSBPQkZGIE5vdCBTdXBwb3J0ZWQsIEV4dEZtdCsgRUVUTFBQcmVmaXgtCgkJCSBF bWVyZ2VuY3lQb3dlclJlZHVjdGlvbiBOb3QgU3VwcG9ydGVkLCBFbWVyZ2VuY3lQb3dlclJlZHVj dGlvbkluaXQtCgkJCSBGUlMtIFRQSENvbXAtIEV4dFRQSENvbXAtCgkJCSBBdG9taWNPcHNDYXA6 IDMyYml0LSA2NGJpdC0gMTI4Yml0Q0FTLQoJCURldkN0bDI6IENvbXBsZXRpb24gVGltZW91dDog NTB1cyB0byA1MG1zLCBUaW1lb3V0RGlzLSBMVFIrIE9CRkYgRGlzYWJsZWQsCgkJCSBBdG9taWNP cHNDdGw6IFJlcUVuLQoJCUxua0NhcDI6IFN1cHBvcnRlZCBMaW5rIFNwZWVkczogMi41LThHVC9z LCBDcm9zc2xpbmstIFJldGltZXItIDJSZXRpbWVycy0gRFJTLQoJCUxua0N0bDI6IFRhcmdldCBM aW5rIFNwZWVkOiA4R1QvcywgRW50ZXJDb21wbGlhbmNlLSBTcGVlZERpcy0KCQkJIFRyYW5zbWl0 IE1hcmdpbjogTm9ybWFsIE9wZXJhdGluZyBSYW5nZSwgRW50ZXJNb2RpZmllZENvbXBsaWFuY2Ut IENvbXBsaWFuY2VTT1MtCgkJCSBDb21wbGlhbmNlIERlLWVtcGhhc2lzOiAtNmRCCgkJTG5rU3Rh MjogQ3VycmVudCBEZS1lbXBoYXNpcyBMZXZlbDogLTZkQiwgRXF1YWxpemF0aW9uQ29tcGxldGUr IEVxdWFsaXphdGlvblBoYXNlMSsKCQkJIEVxdWFsaXphdGlvblBoYXNlMisgRXF1YWxpemF0aW9u UGhhc2UzKyBMaW5rRXF1YWxpemF0aW9uUmVxdWVzdC0KCQkJIFJldGltZXItIDJSZXRpbWVycy0g Q3Jvc3NsaW5rUmVzOiB1bnN1cHBvcnRlZAoJQ2FwYWJpbGl0aWVzOiBbMTAwIHYyXSBBZHZhbmNl ZCBFcnJvciBSZXBvcnRpbmcKCQlVRVN0YToJRExQLSBTREVTLSBUTFAtIEZDUC0gQ21wbHRUTy0g Q21wbHRBYnJ0LSBVbnhDbXBsdC0gUnhPRi0gTWFsZlRMUC0gRUNSQy0gVW5zdXBSZXEtIEFDU1Zp b2wtCgkJVUVNc2s6CURMUC0gU0RFUy0gVExQLSBGQ1AtIENtcGx0VE8tIENtcGx0QWJydC0gVW54 Q21wbHQtIFJ4T0YtIE1hbGZUTFAtIEVDUkMtIFVuc3VwUmVxLSBBQ1NWaW9sLQoJCVVFU3ZydDoJ RExQKyBTREVTKyBUTFAtIEZDUCsgQ21wbHRUTy0gQ21wbHRBYnJ0LSBVbnhDbXBsdC0gUnhPRisg TWFsZlRMUCsgRUNSQy0gVW5zdXBSZXEtIEFDU1Zpb2wtCgkJQ0VTdGE6CVJ4RXJyLSBCYWRUTFAt IEJhZERMTFAtIFJvbGxvdmVyLSBUaW1lb3V0LSBBZHZOb25GYXRhbEVyci0KCQlDRU1zazoJUnhF cnItIEJhZFRMUC0gQmFkRExMUC0gUm9sbG92ZXItIFRpbWVvdXQtIEFkdk5vbkZhdGFsRXJyKwoJ CUFFUkNhcDoJRmlyc3QgRXJyb3IgUG9pbnRlcjogMDAsIEVDUkNHZW5DYXArIEVDUkNHZW5Fbi0g RUNSQ0Noa0NhcCsgRUNSQ0Noa0VuLQoJCQlNdWx0SGRyUmVjQ2FwLSBNdWx0SGRyUmVjRW4tIFRM UFBmeFByZXMtIEhkckxvZ0NhcC0KCQlIZWFkZXJMb2c6IDAwMDAwMDAwIDAwMDAwMDAwIDAwMDAw MDAwIDAwMDAwMDAwCglDYXBhYmlsaXRpZXM6IFsxNTAgdjFdIERldmljZSBTZXJpYWwgTnVtYmVy IDAwLTAwLTAwLTAwLTAwLTAwLTAwLTAwCglDYXBhYmlsaXRpZXM6IFsxYjggdjFdIExhdGVuY3kg VG9sZXJhbmNlIFJlcG9ydGluZwoJCU1heCBzbm9vcCBsYXRlbmN5OiAzMTQ1NzI4bnMKCQlNYXgg bm8gc25vb3AgbGF0ZW5jeTogMzE0NTcyOG5zCglDYXBhYmlsaXRpZXM6IFszMDAgdjFdIFNlY29u ZGFyeSBQQ0kgRXhwcmVzcwoJCUxua0N0bDM6IExua0VxdUludHJydXB0RW4tIFBlcmZvcm1FcXUt CgkJTGFuZUVyclN0YXQ6IDAKCUNhcGFiaWxpdGllczogWzkwMCB2MV0gTDEgUE0gU3Vic3RhdGVz CgkJTDFTdWJDYXA6IFBDSS1QTV9MMS4yKyBQQ0ktUE1fTDEuMS0gQVNQTV9MMS4yKyBBU1BNX0wx LjEtIEwxX1BNX1N1YnN0YXRlcysKCQkJICBQb3J0Q29tbW9uTW9kZVJlc3RvcmVUaW1lPTMydXMg UG9ydFRQb3dlck9uVGltZT0xMHVzCgkJTDFTdWJDdGwxOiBQQ0ktUE1fTDEuMisgUENJLVBNX0wx LjEtIEFTUE1fTDEuMisgQVNQTV9MMS4xLQoJCQkgICBUX0NvbW1vbk1vZGU9MHVzIExUUjEuMl9U aHJlc2hvbGQ9NjU1MzZucwoJCUwxU3ViQ3RsMjogVF9Qd3JPbj00NHVzCglLZXJuZWwgbW9kdWxl czogbnZtZQoK --0000000000001f998405e2fbe1dd-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 14:52:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 14:52:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360408.589768 (Exim 4.92) (envelope-from ) id 1o8NRK-00088E-GJ; Mon, 04 Jul 2022 14:52:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360408.589768; Mon, 04 Jul 2022 14:52:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8NRK-000887-De; Mon, 04 Jul 2022 14:52:42 +0000 Received: by outflank-mailman (input) for mailman id 360408; Mon, 04 Jul 2022 14:52:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8NRK-00083E-35 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 14:52:42 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e9d413ef-fba8-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 16:52:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D307C616C3; Mon, 4 Jul 2022 14:52:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1E2FC341C7; Mon, 4 Jul 2022 14:52:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9d413ef-fba8-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1656946357; bh=LIYr9+dvUPXHdqT57p+QLfFXRhEoMDsFddMZtxJOwQw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TEj+veg8Ns/HOQMd5827fiNjKDfi9hkTTGO+KliDeinMA9axI/rLwZgxqAwFDBIwX GE655zV5svDtt4tKZuyOkfFmOQNUp2JhGId6qJIusWuDmzyBZDQ2RQf6cvvM4h0+L8 t02R5wSQ+YrYkgTLPyprkSqU2eN8UCHCfqNKs6Z0= Date: Mon, 4 Jul 2022 16:52:34 +0200 From: Greg KH To: Juergen Gross Cc: Demi Marie Obenour , stable@vger.kernel.org, Xen developer discussion Subject: Re: Hopefully correct backports for gntdev deadlock Message-ID: References: <20220701000951.5072-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Jul 04, 2022 at 03:46:12PM +0200, Juergen Gross wrote: > On 01.07.22 02:09, Demi Marie Obenour wrote: > > This backports "xen/gntdev: Avoid blocking in unmap_grant_pages()" to > > the various stable trees, hopefully correctly. > > > > I have reviewed all backports and they seem correct to me. > > Greg, I'm fine with you adding the backports to the related stable > branches. Thanks, now queued up. greg k-h From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:16:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:16:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360419.589786 (Exim 4.92) (envelope-from ) id 1o8Nnr-0002Sg-HO; Mon, 04 Jul 2022 15:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360419.589786; Mon, 04 Jul 2022 15:15:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Nnr-0002SZ-Cu; Mon, 04 Jul 2022 15:15:59 +0000 Received: by outflank-mailman (input) for mailman id 360419; Mon, 04 Jul 2022 15:15:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Nnp-0002ST-TE for xen-devel@lists.xen.org; Mon, 04 Jul 2022 15:15:57 +0000 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2aec5cba-fbac-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 17:15:41 +0200 (CEST) Received: by mail-ed1-f45.google.com with SMTP id x10so4750072edd.13 for ; Mon, 04 Jul 2022 08:15:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aec5cba-fbac-11ec-a8e4-439420d8e422 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=U+JMua8CrPRyBa4VG0dbBPRYKopxilI5XUWCwNAeMlU=; b=3GNESfX+jM6CeAqkl6NvvDdfP86ZR6Im1Wr0vbogYEo6nhsoaVFoKZa7RBL9FP7i+P t12Rw7ebS0oRwf2bxFxFYUBWM3lREljlcHXYdHf6s3BJ4HTo9Sh0acbOQmWfr8+r1pAn JMymRUc+/Whk5MpetjZrgEqoZAc4x7dCODhd/jBrc2pinLCkO5zygJza+GhDyJSs4eNv zB/SS7a9miC4dc6kSe1Xnxx4WthdMaN5jcNUwd/3MYKxq1vvIjD7LNlRx5XHRMdr4ySH ty7qHttbFtKN6LiSrVRrc2GfU88xFwcEmrbp1PXZOWRuo07unt6yreOXWyHs9aaKn+P+ fJOA== X-Gm-Message-State: AJIora8AIKeXI4DCWWCpOkLFPO4atmJG2eYsr+wbWQXEeizLwXKT7Xan q5PHJlRlONqf87elgDGXlTUBHU8KYeA5KHdQMXUuL9Ed18Y= X-Google-Smtp-Source: AGRyM1uqrraQ7e1NoXMfW4C0ya3iRHiOxA2A+loSHb2tXVFXc0NJcgs7qNtWsLlDldv2gN3DKR9ZUidsXhqjJuylU2E= X-Received: by 2002:a05:6402:42cb:b0:43a:5df2:bb5d with SMTP id i11-20020a05640242cb00b0043a5df2bb5dmr6717831edc.36.1656947755696; Mon, 04 Jul 2022 08:15:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 23:15:44 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 10:51 PM G.R. wro= te: > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monn=C3=A9 wrote: > > > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (pro= g-if 02 [NVM Express]) > > > Subsystem: Sandisk Corp Device 501a > > > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- Par= Err- Stepping- SERR- FastB2B- DisINTx+ > > > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=3Dfast >TAbort= - SERR- > > Latency: 0, Cache Line Size: 64 bytes > > > Interrupt: pin A routed to IRQ 16 > > > NUMA node: 0 > > > IOMMU group: 13 > > > Region 0: Memory at a2600000 (64-bit, non-prefetchable) [size= =3D16K] > > > Region 4: Memory at a2604000 (64-bit, non-prefetchable) [size= =3D256] > > > > I think I'm slightly confused, the overlapping happens at: > > > > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > > > > So it's MFNs 0xa2616 and 0xa2504, yet none of those are in the BAR > > ranges of this device. > > > > Can you paste the lspci -vvv output for any other device you are also > > passing through to this guest? > > As reminded by this request, I tried to assign this nvme device to another FreeBSD12 domU. This time it does not fail at the VM setup stage, but the device is still not usable at the domU. The nvmecontrol command is not able to talk to the device at all: nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 The QEMU log says the following: 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00) [00:05.0] If the device doesn't work, try enabling permissive mode [00:05.0] (unsafe) and if it helps report the problem to xen-devel [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entr= y 0) xl dmesg says the following: (XEN) d[IO]: assign (0000:05:00.0) failed (-16) (XEN) HVM d5v0 save: CPU (XEN) HVM d5v1 save: CPU (XEN) HVM d5v2 save: CPU (XEN) HVM d5v3 save: CPU (XEN) HVM d5 save: PIC (XEN) HVM d5 save: IOAPIC (XEN) HVM d5v0 save: LAPIC (XEN) HVM d5v1 save: LAPIC (XEN) HVM d5v2 save: LAPIC (XEN) HVM d5v3 save: LAPIC (XEN) HVM d5v0 save: LAPIC_REGS (XEN) HVM d5v1 save: LAPIC_REGS (XEN) HVM d5v2 save: LAPIC_REGS (XEN) HVM d5v3 save: LAPIC_REGS (XEN) HVM d5 save: PCI_IRQ (XEN) HVM d5 save: ISA_IRQ (XEN) HVM d5 save: PCI_LINK (XEN) HVM d5 save: PIT (XEN) HVM d5 save: RTC (XEN) HVM d5 save: HPET (XEN) HVM d5 save: PMTIMER (XEN) HVM d5v0 save: MTRR (XEN) HVM d5v1 save: MTRR (XEN) HVM d5v2 save: MTRR (XEN) HVM d5v3 save: MTRR (XEN) HVM d5 save: VIRIDIAN_DOMAIN (XEN) HVM d5v0 save: CPU_XSAVE (XEN) HVM d5v1 save: CPU_XSAVE (XEN) HVM d5v2 save: CPU_XSAVE (XEN) HVM d5v3 save: CPU_XSAVE (XEN) HVM d5v0 save: VIRIDIAN_VCPU (XEN) HVM d5v1 save: VIRIDIAN_VCPU (XEN) HVM d5v2 save: VIRIDIAN_VCPU (XEN) HVM d5v3 save: VIRIDIAN_VCPU (XEN) HVM d5v0 save: VMCE_VCPU (XEN) HVM d5v1 save: VMCE_VCPU (XEN) HVM d5v2 save: VMCE_VCPU (XEN) HVM d5v3 save: VMCE_VCPU (XEN) HVM d5v0 save: TSC_ADJUST (XEN) HVM d5v1 save: TSC_ADJUST (XEN) HVM d5v2 save: TSC_ADJUST (XEN) HVM d5v3 save: TSC_ADJUST (XEN) HVM d5v0 save: CPU_MSR (XEN) HVM d5v1 save: CPU_MSR (XEN) HVM d5v2 save: CPU_MSR (XEN) HVM d5v3 save: CPU_MSR (XEN) HVM5 restore: CPU 0 (XEN) d5: bind: m_gsi=3D16 g_gsi=3D36 dev=3D00.00.5 intx=3D0 (d5) HVM Loader (d5) Detected Xen v4.14.3 (d5) Xenbus rings @0xfeffc000, event channel 1 (d5) System requested SeaBIOS (d5) CPU speed is 3505 MHz (d5) Relocating guest memory for lowmem MMIO space disabled (d5) PCI-ISA link 0 routed to IRQ5 (d5) PCI-ISA link 1 routed to IRQ10 (d5) PCI-ISA link 2 routed to IRQ11 (d5) PCI-ISA link 3 routed to IRQ5 (d5) pci dev 01:3 INTA->IRQ10 (d5) pci dev 02:0 INTA->IRQ11 (d5) pci dev 04:0 INTA->IRQ5 (d5) pci dev 05:0 INTA->IRQ10 (d5) No RAM in high memory; setting high_mem resource base to 100000000 (d5) pci dev 03:0 bar 10 size 002000000: 0f0000008 (d5) pci dev 02:0 bar 14 size 001000000: 0f2000008 (d5) pci dev 04:0 bar 30 size 000040000: 0f3000000 (d5) pci dev 04:0 bar 10 size 000020000: 0f3040000 (d5) pci dev 03:0 bar 30 size 000010000: 0f3060000 (d5) pci dev 05:0 bar 10 size 000004000: 0f3070004 (d5) pci dev 03:0 bar 14 size 000001000: 0f3074000 (d5) pci dev 02:0 bar 10 size 000000100: 00000c001 (d5) pci dev 05:0 bar 20 size 000000100: 0f3075004 (d5) pci dev 04:0 bar 14 size 000000040: 00000c101 (d5) pci dev 01:1 bar 20 size 000000010: 00000c141 (XEN) memory_map:add: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:add: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (d5) Multiprocessor initialisation: (d5) - CPU0 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. (d5) - CPU1 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. (d5) - CPU2 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. (d5) - CPU3 ... 39-bit phys ... fixed MTRRs ... var MTRRs [1/8] ... done. (d5) Writing SMBIOS tables ... (d5) Loading SeaBIOS ... (d5) Creating MP tables ... (d5) Loading ACPI ... (d5) vm86 TSS at fc100300 (d5) BIOS map: (d5) 10000-100e3: Scratch space (d5) c0000-fffff: Main BIOS (d5) E820 table: (d5) [00]: 00000000:00000000 - 00000000:000a0000: RAM (d5) HOLE: 00000000:000a0000 - 00000000:000c0000 (d5) [01]: 00000000:000c0000 - 00000000:00100000: RESERVED (d5) [02]: 00000000:00100000 - 00000000:7f800000: RAM (d5) HOLE: 00000000:7f800000 - 00000000:fc000000 (d5) [03]: 00000000:fc000000 - 00000000:fc00b000: NVS (d5) [04]: 00000000:fc00b000 - 00000001:00000000: RESERVED (d5) Invoking SeaBIOS ... (d5) SeaBIOS (version rel-1.13.0-1-gd542924-Xen) (d5) BUILD: gcc: (Debian 11.2.0-13) 11.2.0 binutils: (GNU Binutils for Debian) 2.37 (d5) (d5) Found Xen hypervisor signature at 40000000 (XEN) memory_map:remove: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:remove: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:add: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:remove: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:add: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:remove: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:add: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:remove: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:remove: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3070 mfn=3Da2500 nr=3D2 (XEN) memory_map:add: dom5 gfn=3Df3073 mfn=3Da2503 nr=3D1 (XEN) memory_map:add: dom5 gfn=3Df3075 mfn=3Da2504 nr=3D1 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:32:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360426.589797 (Exim 4.92) (envelope-from ) id 1o8O3o-0004yf-Uh; Mon, 04 Jul 2022 15:32:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360426.589797; Mon, 04 Jul 2022 15:32:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O3o-0004yY-QG; Mon, 04 Jul 2022 15:32:28 +0000 Received: by outflank-mailman (input) for mailman id 360426; Mon, 04 Jul 2022 15:32:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O3n-0004yS-94 for xen-devel@lists.xenproject.org; Mon, 04 Jul 2022 15:32:27 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 812a9c96-fbae-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 17:32:25 +0200 (CEST) Received: from AM7PR03CA0006.eurprd03.prod.outlook.com (2603:10a6:20b:130::16) by AM9PR08MB7273.eurprd08.prod.outlook.com (2603:10a6:20b:434::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 15:32:23 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::8b) by AM7PR03CA0006.outlook.office365.com (2603:10a6:20b:130::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Mon, 4 Jul 2022 15:32:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Mon, 4 Jul 2022 15:32:22 +0000 Received: ("Tessian outbound 4748bc5c2894:v121"); Mon, 04 Jul 2022 15:32:22 +0000 Received: from 939c21efd9c7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 759CFC7A-C2B2-4285-9EF1-AA5119A3223F.1; Mon, 04 Jul 2022 15:32:12 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 939c21efd9c7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 04 Jul 2022 15:32:12 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PR3PR08MB5643.eurprd08.prod.outlook.com (2603:10a6:102:84::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 15:32:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Mon, 4 Jul 2022 15:32:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 812a9c96-fbae-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XtNjUZxnEX3FRJNYZdyoZukY/y4vUoYGsKGMiav0Q/ISCvyO2/NXkFoMmuwyH5tFfv6mm6kC/rRCt24u4ivPO9lJ6VUtdidcYxEzvpd+K8QS8J0V85jf+svCbPGxipUMiYlPYlN6Q+oBkV4kZAJkrNUW+udP8L87Sc8G8qhS534VU9N5Ecjg1LzPejIdeEgWMOUEMi4RrGSHVayw0Ir0+gbRnw7P8unqghQvqtM/n8/hT6UJTRFl9T5p9SvZaMmZ0nfC2RCq9RwSNCop0IbAvypruD1bCdotoE4R6pYHx1nilR3CN/Yl3uwb0xydcn3PTdi894lb03sxmz3Q4H+/Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6wIlNqk0sRucQ1IocjiLeLyZ6yR1ecS/X+7m7HfrW8=; b=CcE38tGKYeSbers1kRvkare34tpb9aAaMg/k7lYN3Z9DAI6w1ddKgF/uWfh8siuA6chaZZnyaLUBY9sapjovZrmemFRFLlMR5zVF4PfizecCta2PHI8VP6TfezFGwS1E9lKxwK+wep5hwsH/Ms2N0o/lXP6zhNlqT33h1f4Uig2ulOIAGFSbNU3NEh26w0uPBzJG7k+28leVG0gVT7c+nU3uFRlgW/lTB31ebO7vgXBF2L/2odQZQcsyn3u/QPu6xbHlbL5rUJYosgmS0LjzEQaT4V9fVIjLnCR+CYoItXnqcyAyQMZ/YZPpbTLEA+5ph1GKshA2FPuM46yzW3rh9Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b6wIlNqk0sRucQ1IocjiLeLyZ6yR1ecS/X+7m7HfrW8=; b=D62sJj3fjKTy053eptOG+4eahW2izN/xHyU/Nsdr2/cxsirbqVccgLUJcxW23bYI+ZTwjpen3jOnM0rEjfeROT4RjLAOcLE6grwloZb+RGrjGDWeXe/pfOsl9CwFZ9Nx4yvGm9WEDPogwrsbC5j5+hoK2zofiA+ZUcH+AkE2fxc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f5ebd7ef240e01c3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JK5MXp7SbcIyJZJB2YLMxuwmTFB3vlgQB7Id/FK+It8AQznaUrVizn1ewDA+NCr9lEv/CA/IHjgk8ORulqdrJG+5xJh2hxTZjdgwlPg7Cu2cwUR6F7dZMtA8Et58J27rmXkWh5U/KKg5FX+zLN4ddD50qH75zsOVOGviiJhf24r0r1oGkOpTjMyUL9Q8IA2hyF15rmiJ9q5NwWMMv82y4d2NNTDPdpD2ZOnNNZ2rD1MtKMLF7bwzblidUt9/cRlrA0vybAke1GPjgnFFjPgsTzrdAFSa683hOEIi7cMKGL+o3n9dm2nFIs9QKiWSjeVTnJ4F6h9c9tz8PK8hXv9+gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6wIlNqk0sRucQ1IocjiLeLyZ6yR1ecS/X+7m7HfrW8=; b=UbAGwzIg46gwH9SwZ3Uo2WG0oDkZ95NPJNaNeOSNYouzF5Jj5hG0FcDt2XK2kOSI03LiAIPqihDofkd8wevzURrruNnXuBhR/vOdWNq/IOxEFh3zllPlwFJr+m6V8ehxvY+QZ6MCIUomBnZ7YbhzMgr/H4XXPsEsaqJzHx6iDyMevUBSp2s2VoGnRcj+I4pgQZJHAm0a9kK0CAIXOWyx1SLmJSLXA6C7hKzN6moBmxnkXttBoy9xYsGJqzRSVuhoDKqQdXBjYgD0SgLk6cjQLcNmnbpdWHB6BPZ3OknD5bvvL6keIXyWov8Hdsw+DCgkzpsmTV26LxeHcTXQzEQS0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b6wIlNqk0sRucQ1IocjiLeLyZ6yR1ecS/X+7m7HfrW8=; b=D62sJj3fjKTy053eptOG+4eahW2izN/xHyU/Nsdr2/cxsirbqVccgLUJcxW23bYI+ZTwjpen3jOnM0rEjfeROT4RjLAOcLE6grwloZb+RGrjGDWeXe/pfOsl9CwFZ9Nx4yvGm9WEDPogwrsbC5j5+hoK2zofiA+ZUcH+AkE2fxc= From: Bertrand Marquis To: Luca Fancellu CC: Xen-devel , Wei Chen , Wei Liu , Anthony PERARD Subject: Re: [PATCH] tools/helpers: fix snprintf argument in init-dom0less.c Thread-Topic: [PATCH] tools/helpers: fix snprintf argument in init-dom0less.c Thread-Index: AQHYi7a+fNYcHW6FA0KjaTcd3mPyJK1uXwKA Date: Mon, 4 Jul 2022 15:32:08 +0000 Message-ID: <4DB9F3AE-0BCC-45BA-9934-0304FBF84E82@arm.com> References: <20220629124938.26498-1-luca.fancellu@arm.com> In-Reply-To: <20220629124938.26498-1-luca.fancellu@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0334637d-ce75-43d3-bcd5-08da5dd263f7 x-ms-traffictypediagnostic: PR3PR08MB5643:EE_|AM5EUR03FT060:EE_|AM9PR08MB7273:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: s1EV+8GiNDH29PxdoVaf1Sr1WJoLmxNMar61SaXK3hCmRsxeIIvw51H4zrz3xsYn5mHFQZ4OJznPTGYN1w8xnsN0w8zPJg2YtCvNnM0GSZG3uwqa/1ZXtGQYiy0pSfJj/+XicyP7CcsSFIPliaEq1B2ULlLPDlsbE7poZbV8xV7hLPcCgOCuXbAburCIhDtJPAw/ljcqkb0taWbl3NI//TEsdSPUY/2VJB5kGKqBBn/PdaxZ692Iciv4iqp1Xod58clm4aGWBY2b56mOQKC7HKiRfmFXVmlAx2gC7Q2dKGRjMFPJ+kUQfvIL13z7W4Cu9Yf6UUTj/oahTYoQ5TUD8l1DwgEff95UANgCdKWi4iPd8EGrREznJg2n5o78iNRwGroe+UHo2+bQn+47Vh+l855htcWy2hUULPz5nzJLDS2XymLvuT6wb1w0aiwbfHjV56c5dFcp633nccD4pdbDIDFNTMrVesDYhlLkpYR8FhMP8Y/Xd0tTLKrq/lLAbYhoKLUCI/8RYZ693eyxl3oaDovWyjTxQfDvxHnX6GmdB1R75bIbYYVi3lQALqDo1NCKm5kK4zNG0IBFMT9JNNGIiRCNqL90m3kfXCY5XoNe8Y8+RCwo9T9cAIMSjDAoJDJSDdrTzwVNTSjKHBRvL/5CYMnumAJ3Cw3oBhq20K3ypzVMVMU3Ls30ATJvHLzZBCGUIKJEgJJyPGYuOexCjX6x5VwBzz8TzQtSqkNbahPPGTNzWNM4/iNY81g6CDq+uhMX5P80b3sSTGJxM758pAVm6CaQbfFHxLu/j9w1aTt+/NcJ+A0jF0b+gOvDRcLAeki6wJFpI85d7PInhk5cDA5CMaExGc+Nid+j+8Nc371J9uk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(396003)(346002)(376002)(54906003)(6636002)(37006003)(316002)(38100700002)(8936002)(66556008)(6862004)(2906002)(64756008)(6506007)(8676002)(5660300002)(66946007)(38070700005)(53546011)(76116006)(4326008)(26005)(6512007)(83380400001)(66446008)(66476007)(91956017)(122000001)(33656002)(36756003)(86362001)(6486002)(478600001)(71200400001)(41300700001)(186003)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <68B7B7D08C9547498E0ABB2E101B3D4B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5643 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: da95a06c-51b3-4eba-a991-08da5dd25b5f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a/FwSjaTI+YywV35kMUpci4rL4SHRvWDXbWlxJ2RnDjlRfWBtp1f1SDCBMB2H2K6kDn+m1kKglx/pteZVaPrx1VmSR1ySkrSZq8FVuP7yAL4q6XH37wfyxijvIeY9v+P/nL8UrXO4ldqmCRDVj+4aqwwOXRTMqAws46G1zPu4wrzIPM7pAgmta+1M+DMFqj29s6a/w/213NriMe2yHg8i7iSrXA1CIBossDDT7mn09hm1XwXaYnsDSzfiPPww1UOHjCYPT4Z8IPPF3L79wQotKBAppLjWq365AXL46GrxrBBRtyxrP6IPW0ECHURdq0Nvig017MWbvQvRN2sVD/ilEdMsbojzTloLOl0EJFxiecPNtvLDS5RixsmZ0Tr2Ra1XTK99K7EWSnDHt3AQv0eQuIgaGGV/U50mjKP7JXMY9gvjgiHiLS4mdLQTgKcaQPXr23hr/lBZzCcIw6MVFA/tyQM5bJxFzRvrtSQV/Yqhp17ibuvqFGDnBQB1iH7c2x7PuC2SCmsEqSeyoGFYVRUcUVPOgk916TpHRmvThLUoXOF28R8JBfSadYg0IspMRMY2wOizhBEDdthxq+jNY1jTCvuzZfaFDRMJCSno8CDymVO0PJpHkNT1ODHXdXLNR8B9y5i1P7YBSAEOGTJeT2M4cr3q0yuz+byVFt8BUxoCL6C5HzmjXQJNPxPKWtW2bmtkmlkK2OD53MLABTKcIkR7dgzSP9DCJ1hWRjSAOTUymVgaasDhGZjr6kIUc+3/wEvXH3GJZ8WdjqDFDtD0b459YssfnWCzf/OGjCTfN3hO+M4EsNkCE4A59m7CE6dKpEX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(396003)(376002)(46966006)(36840700001)(40470700004)(83380400001)(82740400003)(36860700001)(336012)(2906002)(6486002)(356005)(40460700003)(186003)(478600001)(33656002)(47076005)(40480700001)(36756003)(82310400005)(4326008)(6512007)(316002)(70586007)(70206006)(86362001)(2616005)(107886003)(6862004)(6636002)(8936002)(54906003)(5660300002)(37006003)(53546011)(26005)(8676002)(6506007)(41300700001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 15:32:22.7447 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0334637d-ce75-43d3-bcd5-08da5dd263f7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7273 Hi Luca, > On 29 Jun 2022, at 13:49, Luca Fancellu wrote: >=20 > Fix snprintf argument in init-dom0less.c because two instances of > the function are using libxl_dominfo struct members that are uint64_t > types, so change "%lu" to "%"PRIu64 to handle it properly when > building on arm32 and arm64. >=20 > Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > tools/helpers/init-dom0less.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/tools/helpers/init-dom0less.c b/tools/helpers/init-dom0less.= c > index 4c90dd6a0c8f..fee93459c4b9 100644 > --- a/tools/helpers/init-dom0less.c > +++ b/tools/helpers/init-dom0less.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -138,10 +139,10 @@ static int create_xenstore(struct xs_handle *xsh, > "vm/" LIBXL_UUID_FMT, LIBXL_UUID_BYTES(uuid)); > if (rc < 0 || rc >=3D STR_MAX_LENGTH) > return rc; > - rc =3D snprintf(max_memkb_str, STR_MAX_LENGTH, "%lu", info->max_memk= b); > + rc =3D snprintf(max_memkb_str, STR_MAX_LENGTH, "%"PRIu64, info->max_= memkb); > if (rc < 0 || rc >=3D STR_MAX_LENGTH) > return rc; > - rc =3D snprintf(target_memkb_str, STR_MAX_LENGTH, "%lu", info->curre= nt_memkb); > + rc =3D snprintf(target_memkb_str, STR_MAX_LENGTH, "%"PRIu64, info->c= urrent_memkb); > if (rc < 0 || rc >=3D STR_MAX_LENGTH) > return rc; > rc =3D snprintf(ring_ref_str, STR_MAX_LENGTH, "%lld", > --=20 > 2.17.1 >=20 From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:33:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:33:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360430.589808 (Exim 4.92) (envelope-from ) id 1o8O4j-0005VH-7P; Mon, 04 Jul 2022 15:33:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360430.589808; Mon, 04 Jul 2022 15:33:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O4j-0005VA-4M; Mon, 04 Jul 2022 15:33:25 +0000 Received: by outflank-mailman (input) for mailman id 360430; Mon, 04 Jul 2022 15:33:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O4h-0005QB-3x for xen-devel@lists.xen.org; Mon, 04 Jul 2022 15:33:23 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a1217b34-fbae-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 17:33:21 +0200 (CEST) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 11:33:17 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by DM6PR03MB5034.namprd03.prod.outlook.com (2603:10b6:5:1ec::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Mon, 4 Jul 2022 15:33:15 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 15:33:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1217b34-fbae-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656948801; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=W7BoBpzlfSZDDM3iqyBmBNOfB6bvi8qQKSnXaoYBiWk=; b=bPqghFv1MocFtDe9whtk3X0B5fLzQ3HG7gjQagnfuz+pLfrgOmuwVKTJ ppcVcVpPM+vLHKxlh1pW6TYZAgYiF1w+3QHaXNuSo+0HT/iiwR0DlWS2M 0ExjiwZMrkzRvcu/iNVGiwC905QZNwHDwAknXsGujhF3qjdpWLruIkGO4 Q=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 75040371 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:uPjTSqJ8gvT4ojQYFE+RuZQlxSXFcZb7ZxGr2PjKsXjdYENSgWMEz mUaD2/QaK7fMzenKd1/b9u39UlQ75GHzt5hTgJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dYz2YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 I1/5bmzeCAyBOrVoMcZDToJGRNmNIQTrdcrIVDn2SCS52vvViK1ht5JVQQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHM6FGvqQjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SSnL2UD9wv9Sawf/3rDxi923YPXLJnlKoPQS90Mp1yVq TeTl4j+KlRAXDCF8hKL82ihg+LTkCThcJ8JGaejsOVtnUeYy2IUEhIbE122vZGRmkO4Ht5SN UEQ0i4vtrQpslymSJ/6RRLQnZKflhsVWt4VGOpj7giIk/PQ+1zAWTJCSSNdYts7ssNwXSYty lKCg9LuA3poraGRTnWesLyTqFteJBQoEIPLXgdcJSNt3jUpiNpbYs7nJjq7LJOIsw== IronPort-HdrOrdr: A9a23:+wjyg6D6PBQI/w7lHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOuh5Dt T/Q9pVfY51P78rhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="75040371" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WjgDWuyEENMHqIiCJ2IJsS47Qq3xNLBcGaYgGLNmSKJ+OG79Z3YaYSkwAXZ/jARbwVuE6T1gb/gN0FZ4X+qxL4bUIZs0nOjINFW5StSVVDkrxgRSpyNNrshBlNCwL53dgaop9vZcvEY0QAQBr0dvbHXUc1/9LCVlU5N+cynYSBXvRT6zAULPo3PBdsYOfQ12F3OUTXRrVO/oPuDIfVYbg5H1r5PRHNwq6Kvkl3T72xj+XulKFv0vunVm+aB6t5ZIGehiCi27n70E3xwAiThByH17Fb94G2LY4Ymdq2l5kAizG5XYOT76ErybO3DpWA96b3dGq24yTdlWYqG7AfU3iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bWpUYK+xbI4BrR4Ykhb4sS2WAiMcJyVblXe8eD8qp6U=; b=Jyl7WjSMI9VOP50oegxrO4ClIzs5xoETn103HvCS2WpWdL0lzVsyS+MyLFvVus2Ezd7t7NUUmvVhfzuBvBYOi5UGpj/KpTqw9JivupJhQfC4zStwK7Jp8ID/nm4o+n4CY82RaiNQHAfBhbAboWfhqhBCgJOAdfZTy898wxbTCbVDJD4gZIskYo4wn4w6GJ8sMJBHRaAILxK0ScwaVnpHjPn4y3uZbPZI52dkx7LBLTfGmKhGiypsFZh1VzX1L4eOzX/vRrodGKSfB8f+HYnbbbFzgxcI/sc4gCFKDMSxg1nVmMwgzb5+MYhHvky/o+Oe4dpHhqag4LseASsrzApPGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bWpUYK+xbI4BrR4Ykhb4sS2WAiMcJyVblXe8eD8qp6U=; b=ZVzBpg8rkyPDUThVaFmOJ3o3gmk7NEuKs4JHfw6d0VV8daVYUKgKVV8TZg+n4hyR4eRCj/IvNQ0D/I7UQUr3nfRX3K3ddsXriclBlKqtG7FS9nTFzeAuh1v4Esta3v1wJG7rTF8uViqxqiEUYBGxjQhZdH/RGq0OtrzGsYYihb8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 17:33:15 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "G.R." Cc: xen-devel Subject: Re: PCI pass-through problem for SN570 NVME SSD Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0636.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::14) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3b3ad1f-02bf-40ac-a0df-08da5dd2832c X-MS-TrafficTypeDiagnostic: DM6PR03MB5034:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sZmQ2FaaqJEliDn6ytk6QNrdPSt5h5/cl47Z7hjyxAX2aj29T4gEdGtqBBlhznvDENeehFR7L7vVCM1+DIHx8z7bnnpcEIP5lcIDgxxCD8fDI9gFEl8B16nUpzogWh2lTtoitDQi78KruYuiCRXAcivFR6ykn/B3n0focczUvm+bUNsE8fHy8hJgkvWyjYkDNozNxLBK4OMDCJXIjKsBOUI6KzrxDG5MWsM5wNaGRp3A8qKRK3ePvNEwZxsgE3vGGFyUg0DAYLJSuErjqdmpZHXcItFF7CY5Tek2hzxnHDgdFJSd2u8GZCc5VZ6hG8xZzaSdA20EyfX/AFGfoaoRGPxGj/slcPHUek1XCaqJBiOlkrZ4VeaGSslNiBvXbFCb4rgBtbq8nZHq0cHOH3+TPlK2THLiKkykKemsj3AI1wwLSkYRRxQhX/PKosDcHMGz7Fpvn74OsazTLHbPLP1UUe0ly63vXa64V5gSWcx8kFEoEEFbxoj9/yb1zuEc0keecubODa0cFe2WaIco4V3CMVnZSgxhAfVYm/2brNFkZUll/J3jpIT+oeddW2OgcsUysKUmswZHqRFWxwlls8ML0DTfQZ5coTJ7EfewB5Aj251d9UDE3oi6U6b0Swiv9o9OX8tnn3+Ce3yipJYLchDt2VtIHVwpNUNuTlw27gwDoEECtQ773ERiFxSPNI1L3f3KAks5D9ediIfJAitg0Xkjma42Rw11XWWkg9FlSEGTg16q98SKRRAYJ30883vdsVlsbzuw3BD32EfI165v+7UhZlItXo5q0jJESOCH5c47zBE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(366004)(346002)(39860400002)(136003)(6506007)(6916009)(85182001)(316002)(82960400001)(53546011)(86362001)(38100700002)(5660300002)(41300700001)(8676002)(8936002)(6486002)(966005)(478600001)(66946007)(6512007)(66476007)(26005)(66556008)(2906002)(4326008)(9686003)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG9WblBkU045TE1PelpmRmY2RFIxc0h0dkZGSzMvUFlDQzJ0Ti9EZ3F1VWZ5?= =?utf-8?B?WWFKS2VYU0t3TEhHalY4KzJTcGRCeUNMK1plWmMyYTlGTWFHNFJxcmVtWEtz?= =?utf-8?B?YjE2bFcyMzFIQUJuMjlKRVFqUGNmRTY5eS9GUGZwRGhYZlBrZDJ3TmlHOVlF?= =?utf-8?B?cE51WTlVVllFSzdpREFXL3hLaCs1QXZweEF3TnBRd21CSWJxb2lzYklmb3BX?= =?utf-8?B?Q25sdWhXK2FKWWs2WUFKNWdFNVQzN1J1REdkMzBYSk85dVdMQ2txV0ZEQXUy?= =?utf-8?B?OFpyMTJZWnV1anNOdnAzVExyUzhRUGdUaHp1eVNBMGxKWDJhaCtWeTFjSEhT?= =?utf-8?B?M0FKRWpyNHJmOTVPaGhuNDJZUlFqemcrZnZDMHBESW4reVMzYzk5Ri9CTmpK?= =?utf-8?B?V0o0L2gySmNmVzV4L0tETENpbFVDejR2azROb2NubkJ2b0tjdVRTdHYreUgv?= =?utf-8?B?S0kweXJNTHg4ME1udThpSlcxdm5EQzFUOTA3Z0c0T1FFS29yNXdwVjJobGZm?= =?utf-8?B?NUl5a09JKzVoKzJUcUhFMHdONDNuRTk4b1dmRk40aTVLRXZleWFCaVhyRjRr?= =?utf-8?B?Rm5TL2xZZ0l4RFZkaFlLZkRTL3FjYzBQYjZhNjM2UUhCUHkwdC9XR3BZcndZ?= =?utf-8?B?UURZRkg4OWRTTWNZNlh6amNVbGtNVnVVYnRlTG5Uc3RRU3FWVU9FREZpcmlp?= =?utf-8?B?STV2V2NUNW9xZlFIcHZrRTBNeUNtdzBVUHNGdUI1TXNXZWpEaW5KdEcvMXAr?= =?utf-8?B?d21DWWtBRS82ZDJRd2RadHpDUkhIdFBObmRDd0czV3dZVmZYWHE1RVJ4YWI5?= =?utf-8?B?SW1aeFRJbTluUGE4NHpWWHRFWHd0ZTBLOVA1M2pEbm9oR1V0UVcxTWRxcCtE?= =?utf-8?B?S1ljN29JWHIyOXVWM2l5U0ZyenhOS3h3TndLQS9lRk9JQzdtNk8zVUpDZ1NC?= =?utf-8?B?dUpmL2l6VVJKdWlQQzF2aEpoQXB3RVFEVnMxcVRtYVNjOTExVnRBazdGWWFT?= =?utf-8?B?OEhqWTljTDR3VHh5OXR6MmV6ZVk0cHlKQkpLTjM0bk9hUzNRQzgybEcvSTZP?= =?utf-8?B?bHV2OW80cDNzN1JCRnNic1pTTmw1ODg0VmxNaThTeWRyVk1pbi9rQ0RQRjlJ?= =?utf-8?B?U00zcnpIYmx2WnkwamNqQS9sVmZkMC9MNGlqQ1I0andpV1pmbUFiSUNXMTgv?= =?utf-8?B?c0FYc0xVdjJ4QXZDQkltREl5WDRRUHdVV3FCZVhwcVpEL0pKOVp1UEVBMVpN?= =?utf-8?B?MWZyZ09wanRRY3A2NDZnV1d1Q0g3TVQ4SUs0OG0zaEVZNldDNWlnelZRQUdq?= =?utf-8?B?Q2xBOUNDekZPOUNPWnhPbEt3OTlpYTJEOWRKNEFxd1VxeGkvdWpsbCs2TnJU?= =?utf-8?B?YVpqK1JtV0tMSGY1azZFU1NuUWVYSVk1azYweU1wSWx4UHpnZnJSelFEM0tK?= =?utf-8?B?U3l6czBmVmZVTUNCUlNpT2FHU29NUktWMUZucnNmNTJ3SkNnRFdoU2pJZG5y?= =?utf-8?B?RTJRTFdFcEhoTHdmR1lRN29ySXJsMDdZKy9OcHBhbWxXaFBSTGYyMkI3TGRQ?= =?utf-8?B?blhOczZyR0FPWk03WjhUSnJ4dVFQMkx2QVZRVjF6Z0V2bnc1OGVwMndzem8r?= =?utf-8?B?V3V5d2d4bldsaU9laGlWY21xaUUvQitPaFJxWldNU0NaZ01qUFBuZTRlOW92?= =?utf-8?B?MVBodmUrNDdRVmczYUlzMXQyRHpoV0RDVDVjN2gvOXI4bEVXVmE4SzhzZ3da?= =?utf-8?B?M3lJOVpIaXk3ODVqd2lsN2IySTBnaWdlR1hIM3lOSXFYTkhKN2l1SDZRVjln?= =?utf-8?B?enFiSmVtTnN0Sll5aGFBeElvNEFkVGN0YWNtcUVGNzYvNkJYRUJNaHYzTFk0?= =?utf-8?B?ektyWGxFbVlzU0hzVVRSR2U1eis3R292QTFtbVllNmxjbFNZdUh5Z0Q5bEZY?= =?utf-8?B?ckdMYU5XbDN0L3JpUnJnRlJKckRKMG5YbEtsWTNkZ2kwWXVld2kxL3dWSndL?= =?utf-8?B?bEkrb3JLM3BlYytDa0NUVnlzR1VBRkFjQ1F3S2tabVh1clpuOUdEZk1ZNFAz?= =?utf-8?B?OGRKYlZ5NDdHemI1MitVODdMRi9lNi9qN0FkdFlxN3FjelRGRElaamxCMEYw?= =?utf-8?B?bFZ0Sm9yMFZvVGdQVHRwVXE2ZTdFRkM3anVaQ05aQ2lFSzJlcFd2NDM1dmIx?= =?utf-8?B?YXc9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3b3ad1f-02bf-40ac-a0df-08da5dd2832c X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 15:33:15.3632 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b/Sr15oqoJpB7LoTzX8VOPRlbkmc7A8Q7MAlMqkf5sTYa2zPxXdHktL1e556KLBd45ANdLpTDH8hLd1HsKFaRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5034 On Mon, Jul 04, 2022 at 10:51:53PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > > > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if 02 [NVM Express]) > > > Subsystem: Sandisk Corp Device 501a > > > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ > > > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- > > Latency: 0, Cache Line Size: 64 bytes > > > Interrupt: pin A routed to IRQ 16 > > > NUMA node: 0 > > > IOMMU group: 13 > > > Region 0: Memory at a2600000 (64-bit, non-prefetchable) [size=16K] > > > Region 4: Memory at a2604000 (64-bit, non-prefetchable) [size=256] > > > > I think I'm slightly confused, the overlapping happens at: > > > > (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted > > > > So it's MFNs 0xa2616 and 0xa2504, yet none of those are in the BAR > > ranges of this device. > > > > Can you paste the lspci -vvv output for any other device you are also > > passing through to this guest? > > > > I just realized that the address may change in different environments. > In previous email chains, I used a cached dump from a Linux > environment running outside the hypervisor. > Sorry for the confusion. Refreshing with a XEN dom0 dump. > > The other device I used is a SATA controller. I think I can get what > you are looking for now. > Both a2616 and a2504 are found! > > 00:17.0 SATA controller: Intel Corporation Cannon Lake PCH SATA AHCI > Controller (rev 10) (prog-if 01 [AHCI 1.0]) > DeviceName: Onboard - SATA > Subsystem: Gigabyte Technology Co., Ltd Cannon Lake PCH SATA > AHCI Controller > Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- > ParErr- Stepping- SERR- FastB2B- DisINTx- > Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium > >TAbort- SERR- Interrupt: pin A routed to IRQ 16 > Region 0: Memory at a2610000 (32-bit, non-prefetchable) [size=8K] > Region 1: Memory at a2616000 (32-bit, non-prefetchable) [size=256] > Region 2: I/O ports at 4090 [size=8] > Region 3: I/O ports at 4080 [size=4] > Region 4: I/O ports at 4060 [size=32] > > 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a > (prog-if 02 [NVM Express]) > Subsystem: Sandisk Corp Device 501a > Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- > ParErr- Stepping- SERR- FastB2B- DisINTx- > Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- > SERR- Latency: 0, Cache Line Size: 64 bytes > Interrupt: pin A routed to IRQ 11 > Region 0: Memory at a2500000 (64-bit, non-prefetchable) [size=16K] > Region 4: Memory at a2504000 (64-bit, non-prefetchable) [size=256] Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR from 00:17.0 into the same page, which is not that good behavior. It might be sensible to attempt to share the page if both BARs belong to the same device, but not if they belong to different devices. I think the following patch: https://lore.kernel.org/xen-devel/20200117110811.43321-1-roger.pau@citrix.com/ Might help with this. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:37:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:37:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360439.589818 (Exim 4.92) (envelope-from ) id 1o8O8e-0006FM-TA; Mon, 04 Jul 2022 15:37:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360439.589818; Mon, 04 Jul 2022 15:37:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O8e-0006FF-QP; Mon, 04 Jul 2022 15:37:28 +0000 Received: by outflank-mailman (input) for mailman id 360439; Mon, 04 Jul 2022 15:37:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8O8d-0006F9-9L for xen-devel@lists.xen.org; Mon, 04 Jul 2022 15:37:27 +0000 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34753ffc-fbaf-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 17:37:26 +0200 (CEST) Received: by mail-ed1-f41.google.com with SMTP id z19so12138196edb.11 for ; Mon, 04 Jul 2022 08:37:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34753ffc-fbaf-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=V821VNgVDeNTuc3xWlXE8cl0xteh2r5o2laVaFusuTQ=; b=c3avP+iEZ6hOt1INuILUJL21rtop0/Mv/C0zKhFmQ1MDHBNJvN+Uc0dQRMrO7CftEu WAMuJLr4OiNWJ9osO65a3+TeT7dosohxi6PZKyLuUpngf8Y3ZnOPjq41OtJY2esVIQnm aHzgRJteUSDIL3jISRXq28/jUbyBUgFCS+vij3x5NdDNpOH6tqLRxAcLUceuC+zBtLn0 eyI9aw3wKFm5eXonKBLB1C8bXzmX9wpRYTlRBRWENYRjs05SWCLuOojJN5SrunGHRalZ wGNfFQdvnZ+vkmCcvb8tuUu6hsDon3/RW/HP8p+Oh2rX7U4fidPqHJWU5ZVXvsrWGUwQ RkFg== X-Gm-Message-State: AJIora9Y7bTe2FMNnG5IO3gb4JgFj1rzZF59I2X3Hdi0jjo/Uh1aHp/n MZz4WTeQQEd1ffuQCr1Byj/1+d/2iEL6Rzu6QVAH0RiVSbY= X-Google-Smtp-Source: AGRyM1uPNTHIGoeKcCWGStKa+L4bKU4mwP4aehiW2j0VHKI7LwjNMyn7bYUpU5aP4zCKJdVBm/Dlt914CSh5yHDYDoc= X-Received: by 2002:a05:6402:84f:b0:437:6293:d264 with SMTP id b15-20020a056402084f00b004376293d264mr38978936edz.317.1656949045647; Mon, 04 Jul 2022 08:37:25 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 23:37:13 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 11:15 PM G.R. wro= te: > > On Mon, Jul 4, 2022 at 10:51 PM G.R. w= rote: > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monn=C3=A9 wrote: > > > Can you paste the lspci -vvv output for any other device you are also > > > passing through to this guest? > > > > > As reminded by this request, I tried to assign this nvme device to > another FreeBSD12 domU. Just to clarify, this time this NVME SSD is the only device I passed to thi= s VM. > This time it does not fail at the VM setup stage, but the device is > still not usable at the domU. > The nvmecontrol command is not able to talk to the device at all: > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > > The QEMU log says the following: > 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00) > [00:05.0] If the device doesn't work, try enabling permissive mode > [00:05.0] (unsafe) and if it helps report the problem to xen-devel > [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, en= try 0) I retried with the following: pci=3D['05:00.0,permissive=3D1,msitranslate=3D1'] Those extra options suppressed some error logging, but still didn't make the device usable to the domU. The nvmecontrol command still get ABORTED result from the kernel... The only thing remained in the QEMU file is this one: [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entr= y 0) The xl dmesg appears to be identical except this line is gone: (XEN) d[IO]: assign (0000:05:00.0) failed (-16) And in both case I see the following, which suggests that the MSI-X failure is worked-around. (XEN) d5: bind: m_gsi=3D16 g_gsi=3D36 dev=3D00.00.5 intx=3D0 What's the current situation now? From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:44:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360446.589830 (Exim 4.92) (envelope-from ) id 1o8OFQ-0007lZ-KR; Mon, 04 Jul 2022 15:44:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360446.589830; Mon, 04 Jul 2022 15:44:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OFQ-0007lS-Gz; Mon, 04 Jul 2022 15:44:28 +0000 Received: by outflank-mailman (input) for mailman id 360446; Mon, 04 Jul 2022 15:44:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OFP-0007lM-Nr for xen-devel@lists.xen.org; Mon, 04 Jul 2022 15:44:27 +0000 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2f3ace72-fbb0-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 17:44:26 +0200 (CEST) Received: by mail-ed1-f44.google.com with SMTP id c13so12166350eds.10 for ; Mon, 04 Jul 2022 08:44:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f3ace72-fbb0-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=JguyIQ9zQuw/qEKx9SRnZWuwO5GxzheQHwCkLi4bfew=; b=iNFPQks0C3KXzIF+A1QSItD5LWtyZ8AWyZ0I6Bly/2bbI44iTMeFHq++1s0ElZ9EPR /PJ7cj/X9gUHR+uNEhIo00zlwE8NhGHQfWG18GirSvDKt+gJEy3q9Gj+04hAgCjDzmy0 ynP65E40bi6hqH/3Ko7ffhhY8RVUIeK6KpP5XR5UM3uadybB3i0JH6442w/CBcsldxlE 6QmYpkicZ4t+RcjnqVHa8RyG3iMWGJBJJo5JU5KT+KpKGV1zPY+JJkzv1PfM3+y1Ykz/ G7sxz7CcrJAavT5MgXolREdFPCoNvZ7TRPAqp5jGgxLMwncDssYZcDV+1INne3qm/KpM 5jKQ== X-Gm-Message-State: AJIora8Zfxk7E4ZAQhLQO3TJ7tYAsyavxz41CEOV3FlJwcI3TyCeWN10 WOKnUAHtNHWVVoO1buwgbpMmHy1awxlC12pl7Pc= X-Google-Smtp-Source: AGRyM1uE/zUUBHPhMjCCEVC/n+tYgyp89SIZiZYQ2PkYvg0ogJ1QN7WcoFSJuCIhGY58jn9BfOdMEOjZ4qzHehq4XgU= X-Received: by 2002:a05:6402:1509:b0:435:6e97:2e51 with SMTP id f9-20020a056402150900b004356e972e51mr40120473edw.354.1656949466446; Mon, 04 Jul 2022 08:44:26 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Mon, 4 Jul 2022 23:44:14 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monn=C3=A9 = wrote: > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > from 00:17.0 into the same page, which is not that good behavior. It > might be sensible to attempt to share the page if both BARs belong to > the same device, but not if they belong to different devices. > > I think the following patch: > > https://lore.kernel.org/xen-devel/20200117110811.43321-1-roger.pau@citrix= .com/ > > Might help with this. > > Thanks, Roger. I suppose this patch has been released in a newer XEN version that I can pick up if I decide to upgrade? Which version would it be? On the other hand, according to the other experiment I did, this may not be the only issue related to this device. Still not sure if the device or the SW stack is faulty this time... Thanks, G.R. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 15:57:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 15:57:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360453.589841 (Exim 4.92) (envelope-from ) id 1o8ORp-0000xb-OE; Mon, 04 Jul 2022 15:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360453.589841; Mon, 04 Jul 2022 15:57:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ORp-0000xU-Kv; Mon, 04 Jul 2022 15:57:17 +0000 Received: by outflank-mailman (input) for mailman id 360453; Mon, 04 Jul 2022 15:57:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ORn-0000xN-GP for xen-devel@lists.xen.org; Mon, 04 Jul 2022 15:57:15 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f79c607f-fbb1-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 17:57:13 +0200 (CEST) Received: from mail-co1nam11lp2175.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 11:57:11 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by CO3PR03MB6710.namprd03.prod.outlook.com (2603:10b6:303:179::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 15:57:09 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 15:57:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f79c607f-fbb1-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656950233; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=eB9sPg5jx9kKiyduEEmDUQI2ehgwJh1tzA53kLtKjm0=; b=ZDoYnbvvCgjSTrfJfu5SbtS81ruxuh3+EFrKxnk9UbpH6mzh2ERAkOVY vAl+2Xp3nyNjuNhH9XLbA3Fi+3nWs56IGECPvCKRKWqdnzlOehQHfXxXB lVZtxnJ+Co34cpO0nsytDaJE9xhzH6mErdOiTUxD0lgdzMdgVJ/xrb9Qk 4=; X-IronPort-RemoteIP: 104.47.56.175 X-IronPort-MID: 75041376 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:0KYwuahQ+1K0n9OVURebI6SrX161ZBEKZh0ujC45NGQN5FlHY01je htvC22GMvjbY2L1KdokYI/gpxtTvJaAnYI1Twc+rSthHygb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M58wIFqtQw24LhXFvW4 YmaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YVcpIKfWwts9akYGNQ16NKkc5IDnJEHq5KR/z2WeG5ft69NHKRhveKY/o6NwC2wI8 uEEIjcQaBzFn/ix3L+wVuhrgIIkMdXvO4Qc/HpnyFk1D95/GcyFH/qMuIEehWht7ixNNa+2i 84xcz1gYQ6GexRSElwWFIg/jKGjgXyXnzhw9w/N+fNsvDa7IApZ957kKtfPX+62TsBxvme0p Ufl4z2pDURPXDCY4X/fmp62vcfBnDn2XY8OGbqi3uNxjUeIgHcUFQcdWFW8u/a0zEizR7p3K UUS9jA/sKsa+0miT927VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufQG8eQVZ8hMcOscY3QXkh0 QaPltawXDh36uTKFDSa66ueqi60NW4NN2geaCQYTAwDpd7+vIU0iRGJRdFmeEKosuDI9fjL6 2jihEADa38716bnC43TEYj7vg+R IronPort-HdrOrdr: A9a23:8a1qY6A/FdXRS4TlHeg3sceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPH/P5wr5lktQ/OxoHJPwOU80kqQFmrX5XI3SJTUO3VHFEGgM1+vfKlHbak7DH6tmpN 1dmstFeaLN5DpB/KHHCWCDer5PoeVvsprY49s2p00dMT2CAJsQizuRZDzrcHGfE2J9dOcE/d enl7x6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDIxI88gGBgR6h9ba/SnGjr18jegIK5Y1n3X nOkgT/6Knmm/anyiXE32uWy5hNgtPuxvZKGcTJoMkILTfHjBquee1aKvS/lQFwhNvqxEchkd HKrRtlF8Nv60nJdmXwmhfp0xmI6kda11bSjXujxVfzq83wQzw3T+Bbg5hCTxff4008+Plhza NixQuixtZqJCKFuB64y8nDVhlsmEbxi2Eli/Qvg3tWVpZbQKNNrLYY4FheHP47bW/HAbgcYa dT5fznlbdrmQvwVQGYgoAv+q3nYp0LJGbIfqBY0fblkAS/nxhCvjklLYIk7zU9HakGOuh5Dt T/Q9pVfY51P78rhIJGdZM8qJiMexvwaCOJFl6uCnLaM4xCE07xivfMkcYIDaeRCdc18Kc= X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="75041376" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=emeZZBQ3lI5QBTEnU/ajzByQl0gytwF1Bam9l4s6JfaheVQh1f42SFpjFTawH5gxMT3jRR99GEdVX7g2fqugJ0SXgmVKAg0J+LCujpBVEim6WAfCSpbdeRqj6RyhWdmQ6yyZl3kHLRXWlgvFDjKE+SmvzVkGJr/x5NofEx06Wr5tToNeSE6b3vmIr9P2SXlTzl1fTz/nCNva80PPClAoXsodLQTuGUyjATlYLIjj6wdypQxgMe20VYUj6h3I08nkc+tQY3Le93sfro2wpATAbhWK3RDZx8QfE9ZIgwxZg8cR0idUXjCuWED5IQRNmcop+EIv1guZStW45f5XYu4V9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sOpJvHeh1bw6kiABroF6PUWv7si+wNayZxlM6TRx4dU=; b=FgWhbldppl9qltyV9z2EtjTcSixjNeeupnmh6QWtHkbNRQD5vpRGentzC/JOwkDgcI0nOK+CXtqm1KXMGRj0nT5XeWNacW1TwL/s9bGHoFDwcxwvdGyyGv7vCid4dZZUVtut73UT9YXFz5/y0UkVmJU/FSflqEvvXsXV5AZISJn8oXu0Q3e8A3Bn8v3KKPWJQeDskEL88cN+gUhwsmfDZrCTr3gOQOyVynHcPyBYkXBAPY1ZFOcavFp7CD3mqEW490MoOt0TECf3iMxuCNnJgpzwrAtccXae82X5BPjheZY0ygprLkobAsyPKgoAPwO8w/vdDc/ii7LktanCGc57mA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sOpJvHeh1bw6kiABroF6PUWv7si+wNayZxlM6TRx4dU=; b=AH9qr03CoI8ltG3xZ5krjAKQOrEiP2XZpRuUFZwX7o78iEOTQXCEuZOObU46tKHJ7JQ3hwxFMuBXdX4NcPZfXYx/yEjabFOr6nEDy0B27+S2POHcpTG6CCh8I6i5k+4xBHn6cK8K+SqhJQfLjUscaf4pBIVVi2B94Gp1yAequo4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 17:57:09 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "G.R." , jandryuk@gmail.com Cc: xen-devel Subject: Re: PCI pass-through problem for SN570 NVME SSD Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LNXP265CA0037.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::25) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05c54e0c-d5a6-46e0-9942-08da5dd5d9f3 X-MS-TrafficTypeDiagnostic: CO3PR03MB6710:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QnnXiac3Z6d3pd4pmpsOUL+Jmr++wLP/LrVkFz3CmqqmYWdjfFknHyNc7AMCfcHxBuPxJLASEzHrSYlWoBt/PE8V6Q1tbIWr4G118CBE2H0VhEU89MJDzXwLPiz9FxOi52vMAbgHBjK0z7AkT3MNuSn50BA89ae0aVY0EM7nCS6l5TvhPdlsA4iRklAoxiJKrtSudSQ6YzHCZJe3g9yjxWELXu2ktNzw/NgTkaNzCSNHf9UeDkpJxxCra9A0XDDcZt/HCMM5PD1hbOb1/vrk+SknTxnjK2vsDL61IBlXva30Nbm8h/NitHsoaht0/H5G00ZTXy0gnEQ+Kboi4Y1jhHFfa3jO5UT9P65b9+J1Zq7K3ebnJsACrvGN9C3qViHYI4+20HdkNnESDm80xPuZPRy49eWZWcuP/oOqkBw0J+Hv0EGA1orRZPqiDUDMqPDEy84R+kvUEyXvBw6859JBclRHeL7OMDFO/eRCXAJIqtAHzZzCo5CNAFNrVW9tdEWxYbj+CN9OS8gC1GZDpTC3bpakJU1PuZsNS+B7YXXQgkuu6uJ00ce/7ablrFYs7m03UnGed+P1ASciQAGlwjuo+fE2a5lZO17yI2quoojaUVgf2NqisVD0IV1gwZiuNPpD8ugxrzx/6nTUN/v8da2o0oKGTybFw8jxAJIxwwrdtrujVaYMAyAdOwKeeApFetbxwhg92fRUds67TfNXFiuC/7Dj+GxEbJfUcJK5Ua7HsI6D3/GSmQeI6Dc6me/ZkLCJItf/QWQjbr8nDXHWw1tx/q1jdOAVd1TXRUxupnAGgUg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(39860400002)(136003)(396003)(376002)(6506007)(41300700001)(6512007)(26005)(9686003)(186003)(53546011)(316002)(83380400001)(38100700002)(82960400001)(2906002)(966005)(6486002)(5660300002)(66556008)(4326008)(66946007)(8936002)(8676002)(66476007)(85182001)(86362001)(478600001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1h1elprU01lb3Z5bmJEVE5pcTF4SnkzUnlNRTNvakRNR1YvbHhnTk1obWZz?= =?utf-8?B?eUhkenhXaUR1OU5Xdk5BdWJpTVN5MzJNUHIzY25Xd3k3NmdqbldLdHJxaVYz?= =?utf-8?B?Qm9RbXZYVXR4UWNvZlJnK0NGTjdncDllN0ttdG9mUE5Ea3E4ZXlCZ2xuVjRC?= =?utf-8?B?b0RBanlDbFovWUVRQ2tRZXQ1U2lSL3dia2dBNVkvYytYa2U2NzNTUkIwbW5q?= =?utf-8?B?emJ5NThlMEszOWFLbWo2T0U4ZGFRTC9OM1p5d29kbnR4NkVpKzlyV2hjNDNC?= =?utf-8?B?VUROcURwQ1BMNGU1TENDbGhORXhDUmw4cXd3cGhTalcvOEpiRUR3VXh2ZFVK?= =?utf-8?B?QlVUR1o4a1J2NEFqU2NrWlJNSXUwZGpkeU4rQnJqTm5uaHRiclZwS3B4UHlC?= =?utf-8?B?RW9MazNKUk0vQ1l3SlBHQ3dKQ1JwTVNLMGRSNHQ4bm9KV2ZCSFN6b2RlNHMw?= =?utf-8?B?RXVjUlRoSmVpQklNUHlEY0ZZWUlJZWU3MllEYmtoS1dMNlJDUC9RN3lPQkVB?= =?utf-8?B?VWdmdGloRDZwQmZTZTNCUDB1aDdwYmwwMWN5YTlPUVlyaE1teEpVVFNiaVNF?= =?utf-8?B?S2NBUHo5amVzMENOR3hRTG1lSENoKzVKeS80V1NIOGdrKzEvTGhGdDZzUjNk?= =?utf-8?B?TEI5dHdSY2ptQ3E3UFRDa1QyUjBpTGxhSUlIMTl2ZlNabzZoLy9NbUt2WFJT?= =?utf-8?B?SDgrNVN0b2doR0V0Q1VYcTBxdUxKQ0lPMmZxY3NoOU0wV004Ui9qdDVyS1Bt?= =?utf-8?B?dFRpWVVEbHZIUGE5MUEybEVpUWlIY3RXTG1lLy9Ra3RoUnNLNUNHdHN5UFhu?= =?utf-8?B?ZU5QQjcwMUhWMFBKcWZnY2NNSkI2NXNPbENkTGptbGhsUnkwSWJSNDQ4YnhB?= =?utf-8?B?aVU3SHU5RVY0MTUvcm5rdEI1dWFxOXAyeS9NWGYzMllHY0E3Qm16WS9OQXM2?= =?utf-8?B?aWFXcTc1aXc1MHZUTE44ZENMVFJOOHNENC9HYjVIay9WbWlIeWc2TjBhVTdo?= =?utf-8?B?MHhQa1JqYWYrMnVERGVzZ3ZVKzdONUlvT1NvV2RxOHFCTUM2TEo5V2JmNjZ2?= =?utf-8?B?d1dUVXJrRE8zVnhjS3FZdlliSXRHd0ZDOGtTVjJ4R3Y0ZzBhSldnbUZDMWRV?= =?utf-8?B?eGhnMWxvY0ozcTNybWpMUVJqNExKWXltSUxZd1lqTE5ZT1BtZjNhUitndURk?= =?utf-8?B?UjJEcURQTExmOGVlT0xISms5NlFldHJWKy96bXZUNEVpWUNkeWV6alZYRGlS?= =?utf-8?B?TlBLYkVUZVNuV0VlRnRMS0MxNzNPRXhTTitlU3Z6QmIwNm9heXRwVS85aUdN?= =?utf-8?B?N0Y1ZGpOeVFRWWw1R3lUU3M4TFlCVG5GK0UxWHIyajYraGhFOHlXN0dReFhz?= =?utf-8?B?V1Y5MEJSdUd3cndXZVZuSmZMK1cvZVNXMnFib1MzOXc4MktoZVd6K05BaWhz?= =?utf-8?B?Tk9hNHNjeHpBRFJSZFhCM2tGRE95OUdsbkNaSjVYVzdaYjNzZVFEVjlEb2x0?= =?utf-8?B?YUxKYzY2QUliSmdCZDRvLzUxeERBM211NUEvRGF3WERGYmFQVmRFc0VCVzY3?= =?utf-8?B?UGMzOTVFSEkxcVpsRG1YTnZrZ1Z5ZnNWUjFRbHpNOUpoOEhUaU5nY2txRnJM?= =?utf-8?B?OGJocmhhYUNjYzdYcm1INEl3YW40OGF4NEF2WDFMTWdDRUlubkJnSUEzd1cy?= =?utf-8?B?NTI4R1JTVXcrTUprYmlLWldEM2RrNXA0MjNyZ3VZS2I3dGxQcEpCU09GMjBC?= =?utf-8?B?UmgraHBmekMrVWptY1d1TzFCVTA1eFd0M05TK1B1MWtRa3owK05yRDEyZWRp?= =?utf-8?B?Zmt3VURWcUhWK1ZYNlZkYWl6YnIxM0NDRDlQUHNTTHU1a3ZOMzRHdHRIZEky?= =?utf-8?B?aUs5WFZkNHFsckZlYjV0Rm5TbWJqM3pYek01VVBjN1gyMlBMZHVSdDNWR2F1?= =?utf-8?B?d25oQlBFYlVQakJXWEpmYVdVY3JIS0pGUDhrNExybEltRmZQUklkY1Q4dkd6?= =?utf-8?B?M1BQZlNmalp0ckpkYm5FQXJUbCtJaWViQlBFN0hnQkxzcHVsOC9Zd2VRbzNz?= =?utf-8?B?RXdTT0YxOGhiRjZ2RWIrWGVFZE1rS2trZ0IwSXUrTWcyMGNCZG9YQ01vUHZS?= =?utf-8?B?VS9ybjlwWDJaZXNYVWVjMDJHR0FtbFY2MmFsb2pPMFFDa1VXZnd3bXErQVdi?= =?utf-8?B?b2c9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05c54e0c-d5a6-46e0-9942-08da5dd5d9f3 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 15:57:09.4414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1bNP4Kl7rf18KdwZoPwmvgdf77MWP5PYDIwwQIzlHXK+wBw5QY8gxabsSg1X8kGEeuYWtza5effsxzs64zrLug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6710 On Mon, Jul 04, 2022 at 11:44:14PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monné wrote: > > > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > > from 00:17.0 into the same page, which is not that good behavior. It > > might be sensible to attempt to share the page if both BARs belong to > > the same device, but not if they belong to different devices. > > > > I think the following patch: > > > > https://lore.kernel.org/xen-devel/20200117110811.43321-1-roger.pau@citrix.com/ > > > > Might help with this. > > > > Thanks, Roger. > I suppose this patch has been released in a newer XEN version that I > can pick up if I decide to upgrade? > Which version would it be? > > On the other hand, according to the other experiment I did, this may > not be the only issue related to this device. > Still not sure if the device or the SW stack is faulty this time... I don't think this patch has been applied to any release, adding Jason who I think was also interested in the fix and might provide more info. Thanks, Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 16:06:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 16:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360459.589852 (Exim 4.92) (envelope-from ) id 1o8OaE-00032S-JO; Mon, 04 Jul 2022 16:05:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360459.589852; Mon, 04 Jul 2022 16:05:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OaE-00032L-Ga; Mon, 04 Jul 2022 16:05:58 +0000 Received: by outflank-mailman (input) for mailman id 360459; Mon, 04 Jul 2022 16:05:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OaD-00032F-0l for xen-devel@lists.xen.org; Mon, 04 Jul 2022 16:05:57 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150054.outbound.protection.outlook.com [40.107.15.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f52f557-fbb3-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 18:05:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4938.eurprd04.prod.outlook.com (2603:10a6:10:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 16:05:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 16:05:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f52f557-fbb3-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PNKOepDS7ON4SPkWN2DLttn0mAaQL1HpIH7Y+VYc4mLjmscmX4qym6QAqUN8XAbZ2CV5p/jtmIDsu9tydjOjcZtOMnaIGznrT5qKJrlRMybZ3mxFanIEOxsAT1fVPr2vUFDzYQtG2YPLmqo8Ae6hWq5jaxaOD3OsDqi5XhHjsbvAVI4qsKL8slnOZYcWt0Yg0RnfED+VGn1ltfJvxd4mFDM8wgYSqK10GWXV0AcjVHn+UYNDWJ1wFz0dXQH4Sbf7TAMRA6qU6LWy++amjrWcc0ZTS/NkhwTp7Jaeur3W9xHNmvMmxhmFWK5rssHsxnbOA2ww7j46msszSbnArZL09Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m47xhOm/aDXB9ZZsWzK6a2O0sUtKynKll9WL+JTuz/I=; b=j3dP8IVp69JeWnQn7kYBX7owww7Va+NyUmQtME5hlRcYH/QemznXjeoDVmbNaVL0ZrwC7Cn2qWfFhkSHyi+Hp/8C06WKJySxeKxillxa9oEEC+EpbdyMa4RuBcuJkXFxn/l0LqJbCP/gKBEIMzYuiVv4R0wAYxpVw526ou9cQAIy9rCZeRtJlyvlnzWDcxBrsDO47QbNAPOwzCxdyma31JHpe3RM/hZ5DOIQRbfGrMz0UDICTHMP7XGp5kcGjZpb/kJCHCM6m6p0CXwHCwl8sf1vH8nJQtVD6H/PxpnBFZDUk5+eAFQIN+eElEp8+tijxYr7D6Z5oSaiw7tVSWbw1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m47xhOm/aDXB9ZZsWzK6a2O0sUtKynKll9WL+JTuz/I=; b=KGRZHStIJIaSvsG9e3I5PXrEyfi0G/J/ttkvSsWPBFCf0dEnMZzjIdjzkk2SUzHvZhfd1u1yHT6Oqw5VL7+rpIepxVLQf0IUhdX7UzdLhoLdXKUomQUpU6BD3/7Na9j3IauNDhMXrc9jHBfspffCHpSkFmG0Z/Eq6g+omcge4qCJe6D1xkdye25j3pKR5vXKLvb9TAPDjzR5k+stiQtQ20YkixD3AlvGcz/NNDoVief61DJGZNDdQaAV6rO9r3BSFT2UFf/XBkKduPB0LSxHaFj4e+2MrtQM+Jjs0ucXSL1hr1QC57ATMq7IcblGAWifw6zi774ffRPa38tS+opx0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4c3e3ea2-81e8-34f7-1ebb-e4bd260367be@suse.com> Date: Mon, 4 Jul 2022 18:05:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel , "G.R." References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P195CA0023.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::36) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b49c9dff-c714-4348-3072-08da5dd7128d X-MS-TrafficTypeDiagnostic: DB7PR04MB4938:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TmYPU6T1rEORqdiCLLS+zrNTdIKsjlr42x+ErtU0pSDAujoPzIpyQzx7tjHJsz/ZTMxCrSQdtLrbk9Iv8RqRcJ8rZrx0IBd8+h9PQPB3H4cPmA0KSN6jZeNB2fyX1u5e1hHi4ffHqF8NOaHAE6VBqGK5p9AI1jqN1ayImxvuSaW930TPWtfcVewcxLoxDaxhbiam8VUkR7rn3wN7JfbgiRNx5eQ6Tb2m4mlGBQIzMLghIX18KkC319qHTII5cGYIKhUQA5ZJ5Zg2Cw8Xu3hGwvV+y8bRBdsW/jP5M2fozxmmen4B+UYA+/63/fazZNOaeiWD5YOviokPHORqVPaTCbaVR/7Jw4Knpg5plLbKVMh4shqdHWWXljqMUzXD2fVEK6UMBmwnkugfTo6BnlrhcEwrbcJTV2uyZ+BekR5mUWR4yQcnDyknTJIIH9oTAE+uJWkWSc0hdjvvjJIChXQPU0GQ//Vh52ZNFCt/6xI/G3597dDicj+gF35v+5ISL2EOvWxgZ5sC8W6oYxDR4EzyTHF3dYDeuYKv6xcpNuNWkQDARRY0dUUzNDZT1LAX0x8DRoM0vULFswiFnhs3dRAqwmWSWt+3J+v5CCbrobyRWN86HrcOrzrCDzx449XO01tmhLH6LxC+0VkiA8Gs3SmWN0VrfkGsP6xLGeTWf5yNhtkw6rhL4LI7Zk5bA6vPFYj034GPO1t0U5po61YNCjQqOWNkolVVpZkqgN7dhfFrqvuzaS+qciQE43tqAMy+b5ulSYER2qRzRY3MWeHr31IZkp/8hVjYe4E71h5YrbEOCh9HsFWAMHRJoTfdjLPHvQ+0eB6wmEXbVGi4onRnVnL+z/2BRZ/g0tKkoHC/pNBH/t2UtStWwoHbgumRG7Ux95UG X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(346002)(136003)(376002)(39860400002)(8936002)(4326008)(6916009)(316002)(86362001)(66556008)(66946007)(38100700002)(8676002)(66476007)(54906003)(2616005)(31696002)(26005)(6512007)(6506007)(53546011)(41300700001)(6486002)(478600001)(5660300002)(2906002)(83380400001)(966005)(31686004)(36756003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1VKM1BqakJ2WUNxWUZTTG83VXFDTG1mSndtaGlNSVZsdWU2eDhZZmJCSDBH?= =?utf-8?B?dnVuaDJ3V09Rd3BzdmRNMmVDeFBxbmt3NEUvbDdFSGRzUFJ1c0tKTUtZU1dB?= =?utf-8?B?bmpiTXVFOFFjMmowNnFZSVg0b0IzazA3Q0E1dHJXRFgvQ29mN1h1S1BkVU5O?= =?utf-8?B?M29iaGYwTzB4YVVlZVZCUnBEb3pXc2ZHOU84bHZIMzcxTDRVY0xDUGhlWlBT?= =?utf-8?B?eXQ5RnlNZzgwOEo2VmQwR0htQWdzWERkTk44SDJtQ0JuSng4RERmYTJJU1JZ?= =?utf-8?B?cjhodVM4UnJjVDJZN1c1NE9GdXlyVmxiUFl2N0J2SEE5OFRSaVhOWWFBUVY3?= =?utf-8?B?VFdlOE9RWmw4cUZtcXhtdEgyN1ZEZmw3cFNZdHEvUHV6eU9DeFFiZ3VOUFQv?= =?utf-8?B?SmQxNktsZDNsb3gvS3U4YVhuU1ZHUmtydzlndE4wWkprNU40b3c5bnRBTi84?= =?utf-8?B?Y3VsRi84bnJ4ZnM4bko2M2hhNDJ4YnVjNTJ5VHpTVnFkVzh1ODZWN1E5bU1Y?= =?utf-8?B?dkJuY01KNXlpd2lsamgvb3cwUjF4MmNHVU5DN0xydDduOTBOeVBLbGZucHVJ?= =?utf-8?B?cnEvTzkxKzlsbFA3VFhQajhybnpSZ3IwQzlEK2ppdnpJZG5xaSs2MDA4eWlp?= =?utf-8?B?S0M3cFdMZzhrcmJkLzZsd3k0dTVZSmpXaEtxT3RrWWxGSExOeCtBbk1sNVNR?= =?utf-8?B?Y0d2aE1QcUpCaG8yKy9lTXZKb1l3VE50VWh5M1ZtL0R2U0Mxalh0YWVGMFFV?= =?utf-8?B?Um1JVVhZRFBwTlUrbVJ5TitJaHJ2eEhHQ2JzNUgyeDdveS8wMXVhVUwyRW1j?= =?utf-8?B?QTJQbFp2L2tnZkFveFN0ZUs4enY3UzZFcFFJMEVFVlF6ZWg0TnJHVU56c0JH?= =?utf-8?B?VnpJaENYM2JCSXZZaVkyY0wwZDFFZWU3b2JEZUkxZDJTb0hEdldwSUprOFNa?= =?utf-8?B?VVZvR2h3SGFKdFBhakdGVUZta2RaYy9vQTNweDdOWUdYT0lCR1c3SFZCZStO?= =?utf-8?B?VzBOdXBjcDRySml5dkVkdkU2a0ppSXJLbXQ0UWUrVCszR2xpUE40UlQ4TTB3?= =?utf-8?B?NjM2UFZlWmJaVGJzc1J4aGt5aHBvNm9uMXBoQnAyLzFCanJobTBvbU5BTTht?= =?utf-8?B?RkJzVy9oUVA4NWI4bGp6NlJ3bHN0MDN0T1Z4NWZaVVFLZ0kvU0tMd3IrNjZk?= =?utf-8?B?bTQ4YmF0MmV6VkVUOFBHV2htWHpXYmVyNWVXWlkwcFR5aldPMEhnRzRNQlRv?= =?utf-8?B?cWdrQnJxZ0xFOTk5dGpWTHNqRll6aDdHSk5ZR3g3cVhRMEYrN2c3T09kUzRT?= =?utf-8?B?bFN0QzNSWHFtNE9SZEl2emg2NHVjWEppdUpQLytHRGpJOCtFZWdROFVtRkNj?= =?utf-8?B?T0Q3dWtOZ2RmKzRlTGRwSDQrSHJENElHLzJia3NUcnBtTWhOcm1aeDJlcWZa?= =?utf-8?B?eHQ3ZisxUkFjRUF5bENoQTlWTG9pZ3M4TnhlQ3BFNGl6VHA0TmtGMldRRkZ4?= =?utf-8?B?YkdKdzhlb0tSalBKcExTUFQ1dzAwMTFJSnRtTkFESlZNSUovRG9KZWRRRTIr?= =?utf-8?B?NkhsWmdqT0FsNk1Id2c2cHNwaGhacUV4VlNKT3hLaVFhMk10bkpRTS9UZGVx?= =?utf-8?B?ZGZEVEZDREE4K05RUldhMHlady9BUVM3eXJCVDROU25BYmxqbUVCWkhzVzdP?= =?utf-8?B?RlJRSDRZc1FkS0NNcDRwOHZBVlI4WVY2T3E4dThJT3dGdmk5ajUwd3NZUGdj?= =?utf-8?B?SGtPUU1OZFJwbjlKK2hBbXhtMVhYVUxjMkY1dkhGbGNhb2Z3SnNVSTBGaVh4?= =?utf-8?B?dUxoS3ZGc3Brd0FuTzFtUWtPZHZqUmwvelpTZXdGUU9hUTZQUDUzdzgvaVlD?= =?utf-8?B?azJUVjIyYkNCY0c1akpKaitRR1Q3U2RFMFYwVEcvTUZHMWlQcjExN0wvdWpi?= =?utf-8?B?bE1BN2M5NTNmK3Q1ZHhnNjhNM2wwN3ZwbXZQd2NiempjdFRJK01PUXBaZ1NO?= =?utf-8?B?eUhZa3Q4WURWa1JEK05VVzJodDcvTmdtQ0NPVnMzQUlaTysreWZPWVk0SjUy?= =?utf-8?B?VGYxODdUd3pzSEkybEZhVGhuckYwMWFNNjcvTDd2MTRHTmdTVFg4MTFTNHJi?= =?utf-8?Q?ppijyr7Ypfc+nnyYPUuAQ+fky?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b49c9dff-c714-4348-3072-08da5dd7128d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 16:05:53.8191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v9U1Rh/KL9YwQQPZhXrJW6su+ZxO8jrv9PHnXdv4Wgcw/VIRHDaFOJ5yIOnb8/4kkC42/BKuw1hWSj0FgzLEQQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4938 On 04.07.2022 17:33, Roger Pau Monné wrote: > On Mon, Jul 04, 2022 at 10:51:53PM +0800, G.R. wrote: >> On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: >>>> >>>> 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a (prog-if 02 [NVM Express]) >>>> Subsystem: Sandisk Corp Device 501a >>>> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx+ >>>> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- SERR- >>> Latency: 0, Cache Line Size: 64 bytes >>>> Interrupt: pin A routed to IRQ 16 >>>> NUMA node: 0 >>>> IOMMU group: 13 >>>> Region 0: Memory at a2600000 (64-bit, non-prefetchable) [size=16K] >>>> Region 4: Memory at a2604000 (64-bit, non-prefetchable) [size=256] >>> >>> I think I'm slightly confused, the overlapping happens at: >>> >>> (XEN) d1: GFN 0xf3078 (0xa2616,0,5,7) -> (0xa2504,0,5,7) not permitted >>> >>> So it's MFNs 0xa2616 and 0xa2504, yet none of those are in the BAR >>> ranges of this device. >>> >>> Can you paste the lspci -vvv output for any other device you are also >>> passing through to this guest? >>> >> >> I just realized that the address may change in different environments. >> In previous email chains, I used a cached dump from a Linux >> environment running outside the hypervisor. >> Sorry for the confusion. Refreshing with a XEN dom0 dump. >> >> The other device I used is a SATA controller. I think I can get what >> you are looking for now. >> Both a2616 and a2504 are found! >> >> 00:17.0 SATA controller: Intel Corporation Cannon Lake PCH SATA AHCI >> Controller (rev 10) (prog-if 01 [AHCI 1.0]) >> DeviceName: Onboard - SATA >> Subsystem: Gigabyte Technology Co., Ltd Cannon Lake PCH SATA >> AHCI Controller >> Control: I/O+ Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop- >> ParErr- Stepping- SERR- FastB2B- DisINTx- >> Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=medium >>> TAbort- SERR- > Interrupt: pin A routed to IRQ 16 >> Region 0: Memory at a2610000 (32-bit, non-prefetchable) [size=8K] >> Region 1: Memory at a2616000 (32-bit, non-prefetchable) [size=256] >> Region 2: I/O ports at 4090 [size=8] >> Region 3: I/O ports at 4080 [size=4] >> Region 4: I/O ports at 4060 [size=32] >> >> 05:00.0 Non-Volatile memory controller: Sandisk Corp Device 501a >> (prog-if 02 [NVM Express]) >> Subsystem: Sandisk Corp Device 501a >> Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- >> ParErr- Stepping- SERR- FastB2B- DisINTx- >> Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=fast >TAbort- >> SERR- > Latency: 0, Cache Line Size: 64 bytes >> Interrupt: pin A routed to IRQ 11 >> Region 0: Memory at a2500000 (64-bit, non-prefetchable) [size=16K] >> Region 4: Memory at a2504000 (64-bit, non-prefetchable) [size=256] > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > from 00:17.0 into the same page, which is not that good behavior. It > might be sensible to attempt to share the page if both BARs belong to > the same device, but not if they belong to different devices. > > I think the following patch: > > https://lore.kernel.org/xen-devel/20200117110811.43321-1-roger.pau@citrix.com/ Hmm, yes, we definitely want to revive that one. Having gone through the discussion again, I think what is needed is suitable checking in tool stack and Xen for proper alignment. Unless of course non-page- aligned BARs could be adjusted "on the fly" by some interaction with the kernel (perhaps at pci-assignable-add time), in which case it would only be Xen where a (final) check would want adding. Of course if we can't adjust things "on the fly", then clear direction needs to be provided to users as to what they need to do in order to be able to assign a given device to a guest. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 16:06:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 16:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360460.589863 (Exim 4.92) (envelope-from ) id 1o8OaI-0003J2-0e; Mon, 04 Jul 2022 16:06:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360460.589863; Mon, 04 Jul 2022 16:06:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OaH-0003Ir-TM; Mon, 04 Jul 2022 16:06:01 +0000 Received: by outflank-mailman (input) for mailman id 360460; Mon, 04 Jul 2022 16:06:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OaH-0003ID-6G for xen-devel@lists.xen.org; Mon, 04 Jul 2022 16:06:01 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30e1a0cf-fbb3-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 18:05:59 +0200 (CEST) Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 04 Jul 2022 12:05:47 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by PH0PR03MB6622.namprd03.prod.outlook.com (2603:10b6:510:b5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Mon, 4 Jul 2022 16:05:44 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 16:05:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30e1a0cf-fbb3-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1656950759; h=date:from:to:cc:subject:message-id:references: content-transfer-encoding:in-reply-to:mime-version; bh=VkvD4ekt5WTe+vRTVgw37/uNhAd4nFgU9t1H4Aa2QZU=; b=ckqk1cLnvyauiWD5pKc1Y4cU1b79izXNOVQlsu2XKfQteD4RJZn40Yo7 Tu4UCnk56hovInpzoqnGn1+vWnxjcR/wScXis1ORH0oPzQKaHSAi/6CUM yEauKOvhnqpxMWRNMo+m+wyJvmiWkvO39V5OdyiVhgT9oyWzZydBGKiDh E=; X-IronPort-RemoteIP: 104.47.51.47 X-IronPort-MID: 74365605 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:M3dGOK1nxaSdZD+akPbD5alwkn2cJEfYwER7XKvMYLTBsI5bpz1Rn DQdXDiHbv6LMTHwKYwlaISz9BhSvZKAzoAySlRlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1Ek/NtTo5w7Rj2tEw2oDja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1VqbKragF3DJeTp8dNTABYFj91G7JZreqvzXiX6aR/zmXgWl60mbBEKhhzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B82aBfmVjTNb9G5YasRmB/HRa tBfcTNyRB/BfwdOKhEcD5dWcOKA2SWkLWAG8A/9Sawf42b8yAp/7bLWH/X8X/urVMtLlHnGj zeTl4j+KlRAXDCF8hKL82ihg+LTkCThcJ8JGaejsOVtnUeYy2IUEhIbE122vZGRmkO4Ht5SN UEQ0i4vtrQpslymSJ/6RRLQiHyOswMYWtFQO/Yn8wzLwa3Rizt1HUABRz9FLdYg7ck/QGR10 kfTx4+2QztyrLeSVHSRsK+Oqi+/MjQUKmlEYjIYSQwC4J/op4RbYg/zc+uP2ZWd1rXdcQwcC RjTxMTir93/VfI26pg= IronPort-HdrOrdr: A9a23:CqVvrquAxM6lRvc0p3KwBLr17skC7YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJhBo7+90We7MBbhHLpOkPEs1NCZLXLbUQqTXfhfBO7ZrwEIdBefygcw79 YCT0E6MqyLMbEYt7eE3ODbKadG/DDvysnB64bjJjVWPGdXgslbnntE422gYylLrWd9dPgE/M 323Ls7m9PsQwVgUu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyRel8qTzHRS01goXF2on+8ZrzU H11yjCoomzufCyzRHRk0fV8pRtgdPkjv9OHtaFhMQ5IijlziyoeINicbufuy1dmpDn1H8a1P 335zswNcV67H3cOkmzvBvWwgHllA0j7nfzoGXo9EfLkIjcfnYXGsBBjYVWfl/y8Ew7puxx16 pNwiawq4dXJQmoplWw2/H4EzVR0makq3srluAey1ZFV5EFVbNXpYsDuGtIDZY7Gj7g4oxPKp giMCjl3ocZTbqmVQGZgoE2q+bcHkjbXy32CHTqg/blnAS/xxtCvgglLM92pAZzyHtycegH2w 3+CNUYqFh/dL5pUUtDPpZwfSKWMB24ffueChPkHX3XUIc6Blnql7nbpJ0I2cDCQu168HJ1ou WLbG9l X-IronPort-AV: E=Sophos;i="5.92,243,1650945600"; d="scan'208";a="74365605" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WFUjRUF7NGzRiCg/hS5KW+ihiEEOjiOHWT9E3GnpFTXmE4WiKbXt0vbL5A3+Uq8MKw5cgx9lE7zFKQuR4AuLgFE74VEP0glKui0zIyd8ypYrywLmeDu8+GdcD6dtYU/3A1wTum/ozpJoe2kPke7Zce7yvXIb9qjrtL6ESMnNL08PhCky3GCMCP2ZXvxbYhGzOjmD3oe8wIbJTQ/1r5/gshkZEOQijBouSCxAUaFCWs5y6UQN+BsYo6oViQYuSMtssjYGBAA/VK8fhwQHQa45TLYrMjUKUYAnO3VMqR4E925jZpo5yyq6HBUL0qqa/540k2PG9H698+69C+rojwZ+og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5c3a6rVImi5dqRSIfLU7WycXTqelQQ5pk1VTTDgZsQk=; b=YJovUrifQzkS/vXWhOEPLe/jYKldDb+xEiQbjI4IRoz0wFQzjxn9Zrq7q68FpqztFqXv8zyhud4dTMkVxjftnNP1SfCA1ETUcafTt0X12Ees9WK5G8e1EvSgAokbxVPvM9OEDLpPoNHKUunF98yb+9mI/qw5kGnqfTNkGp14baun/vpCTXDa2c5uuNj7mXG4HLSNMAM4xEYAqyvstmWjt9M3VK6NvwPJzBk46ufOQwU8602GGr9q1IhVOZ6Jo/U6s7V1j3rt4GK4GjjQJ4V/onDe0f0AAkxSoi++m7+VLx8/Q+F88UvKHo3F8zvJ2glVHQO/isvYpymFljDcQSuvYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5c3a6rVImi5dqRSIfLU7WycXTqelQQ5pk1VTTDgZsQk=; b=TKlJmJ380ToS3y/WC33/JBufanZCOhFGdwrnOC4zZ0/z2+M9FJm7TPrDj5e4FNRXjmT9z65fx1O4wbLQ8R4qdwVN1CKx11J4TO4lt7o0z3KmigBPtNzv5hrWRjUOST90e/uXePZ1BFGdM3WOVbg+jxh5jgMlD4NsZO1qgIjPv7A= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 4 Jul 2022 18:05:43 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: "G.R." Cc: xen-devel , Jan Beulich Subject: Re: PCI pass-through problem for SN570 NVME SSD Message-ID: References: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0161.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:188::22) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1c091df-e32a-4add-3715-08da5dd70d1b X-MS-TrafficTypeDiagnostic: PH0PR03MB6622:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vu8/TE8PnzKPqSi1PDHsKDQVgc+d87LOtORSUmx1NU8KihtUEccBZYkj9LuuFAfAYuOVie3iqvyXx1JUWLu989XuHs6Nf3/+zygj16TVF1K8v2ncL9Ke2bU68MkL54TkWaO1gNpHkBdvl3t8ADiBZmMz2M+2J7vdsma3UM+3fOfap3A1Ss5d7nwo0w53n19tDA+4Xh6WoSoihRVNR6gJn6aB74gxWGF8MrRA58HxAW86GP+TWSmAQlIptMJfLmGo+mUlccdp7F4K891P3ixbalJLOJwnqoEU1QV9KLT+y6MuaEBI8QJuZaDTeQLu043++DO4QHkoXAJtVposhKk23IAIm/QmCKClP+UNsNYQSWQ98CuXDu3MDSNuPGxRnMhymDc19BOYAs4Mcupzt3hr2H3LU/rbVaAuIbok74srZVDwYlq5GjRANrd7l1h5zEkfJSB1wYntslcNZmiqdSqDTj5NUJoJqn/96dd0eUvDauraGJlkwrfNLwgGirk2sLb7KN7NdmmLDjmEpPo3S67g5XPJj8L6F9Suzqggi5uzq6XGiyGFPEVAMzaE/YVRWQzwYWKsQaGehyzBj8igkJUtVUC1PNQyBhDmXKreJFf3nugKmFz752nuUhEQ3JKdEvarBvm3pYmNXzUskIHylnq4WxgXjMBMSIPQDC4CpkFVlPBgNNlmkCOqjF+eskCPaVyO0ptYQzMKfBN0xCTOFUgyYDHaI660T98go9o+NJygN41vNcJk9P688fW2OCv2U4Bi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(376002)(39860400002)(366004)(316002)(41300700001)(82960400001)(53546011)(66476007)(54906003)(8676002)(38100700002)(66946007)(4326008)(6506007)(6916009)(85182001)(66556008)(83380400001)(5660300002)(86362001)(478600001)(2906002)(6486002)(8936002)(186003)(6512007)(9686003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWpENjVlNXEybnZiRWJLdzRzbWJ5cCtxMmZzZ1hsbitPRUttQU5HY0UxSjkv?= =?utf-8?B?YTRIUTM2NjFxWDJqdVBlNEJjNzhNRnJQTHdNUE5aVmc0RWZ2Q1k4ZUloUy83?= =?utf-8?B?dmdVSHpDWkRNUHpXOERoZU1LNnpqc0RoT2MzUWNJdHJqZVZzQ3hsdEN2Rmh6?= =?utf-8?B?YTQ5RUMxV21lbHEvYWpsN0N6amlhRjY0b3NDOTNEdHN2TUpxSnlpRkkxRzVv?= =?utf-8?B?amJJdWNtejh3Tm1KYzM2NkU5Z2dHdHBWd0dldnM4Q3pDOG40ejNPMUR6Q0Q5?= =?utf-8?B?ZFdnSGZCQklRT0ZWNCtLaFpZNUpuWHo3YTR3aHlWOHQ0TzMzNmNjZGp4dkg1?= =?utf-8?B?bTZoYnhJVjIwVEptQ0h4S3FzQ2N2bnZQbDZwc1dPaERITlJpME5ZeGg1R3oz?= =?utf-8?B?ZUNHVVpNUzRUcnZRa2s2UXhqNUhRT2VvOEdrYnM4SkdJRE9sVnVZRjErbUpu?= =?utf-8?B?Q2ZyY2N5SEJSc1NuNkkvYXJRWS9GcTR1SFZ2ZkVHUjVJZ3ZLK21MTGFtNFNz?= =?utf-8?B?RDFJNkdYclMxS3NxVnFtVGJRbEsrcEtDRVJlZm8xWGd2QkRINmpKdGVHejBO?= =?utf-8?B?eEh0SjY3ZWNIb1VUOE9XeE5qQTZyVVVVc0EwWEU4Z1RCVXpPVUtrbVFSUEdm?= =?utf-8?B?SGF6RVYvaU1DT0lvUnRsaElrdE9wS3lOMSs5TmF3TjFpRnFRb2tJZzRiRXdI?= =?utf-8?B?ZzF0bk9DaWg0cEF6czFpRGF1eVNiTE4ybzVEVXFGMmxJbElaQlZyUmQvMHhH?= =?utf-8?B?d3RkVTJvbnhQeURXYWZxK2RYSVR6K0ViNllPekZxZzJBZkpHdnlRNzlUNTNS?= =?utf-8?B?ejJUZUhvU05ld0JJYVJqbCtpemlsRU0vQ3ZXeHRFTUVDUEIzYnhRSU4zMVVs?= =?utf-8?B?Q3FEUGtqd3NscUlzWHRISC9rSjRVRm8yV1JQb0RwSU1LR1lncnhRalpkbVRC?= =?utf-8?B?ckdGWWRpNUQxdmhzK1ROOWUyTGcyejFMYzVQSVRHNjk3N2NGLzVmamhhWVRB?= =?utf-8?B?RHhEVDJTZG1TUGNGWTNSNytwZmNvUnVITDVWenZVMmpraWNmNkRyeVJEMGxN?= =?utf-8?B?LzlVejYrTXZrUndwTHVKeGVMYlBHdGpkVDdhQmxZbXVBaXpMZFNWSVBBWUVm?= =?utf-8?B?eithNnF5RlRaUXk2RzFsamg0R1FFTUYxOUhhbHZEa20rcXZVUjN2WXYxTVo0?= =?utf-8?B?VUQ2MzdEMUJzbXpHU2lXejhjeXNGNjROdy9TbXl6U0J4UzBXYWxSWXBmNWps?= =?utf-8?B?VzRVT0FxZXRLa1c4a29qNU1CRk5QREpKSnBlQVVBTUhBN2tFYytZMWhTSGtp?= =?utf-8?B?V0g4MWhCbVFCL3loa2JXbitCZDF6SmoyY2ZSbkQ3KzRIajd0Y282MUlMSVFX?= =?utf-8?B?ZUY1TXpLeENZa21nYytMR1JsRHo2NDJmMHdHZVpZUkt1Z1M1aWVSMFhxeWFN?= =?utf-8?B?UVNUU001K1ZOWk55MWlmUnNYL004bTVldjdidFpnOVptdUU0YmNtK3pBUDAy?= =?utf-8?B?NERWRy9wcmxjMG5TZDhnN0Fma2FhNjlsQ3NXWUY4UWVJcHhQcmJzM2prRGlq?= =?utf-8?B?MnZiZFhEWjZsTUVGK1NhdG9vQTFTMEhvcFFuVyszRHhJR2Z0UDEvc3ZtWUVq?= =?utf-8?B?VGljWTRNOGdFWDhHaDBjaWZnUHZ2RTRIOFd3N1hmazY3b0NHelEzS1JPa0pI?= =?utf-8?B?Y0YrU1EwZ2pVVTVxUXU0MWVQMnJkVzJqVE1FS0FkK3o0aElwcjZiZDZhMUN0?= =?utf-8?B?Q2psNk5JZUxIYStQcFFqb09SUDcrNEdSMVI4RTA4ekRKZFl4YVA3aXhHVEkz?= =?utf-8?B?M3lSLzh0NU90cUtiS3RyTUNDdUlPTWMrSlphSHpJKzRkZldKUFJyZ3crb0RZ?= =?utf-8?B?TkhZZFZTdDlMQTk2NktNUUU2ckhBUVFxS1Q4dGpsdnJsUzlnMFNaeE9nWWwr?= =?utf-8?B?K2NlRkg1REdwZ3lHNnlZWVBDMU9nUVJOUTJGTG5ZMWNNR0t1OXdQMy91L0Jx?= =?utf-8?B?em1DOVhDRzBpK21MQXpuNlAxRE1HaUgzSkhGY0FBL0VOSUoyR1JlWnkyaVdH?= =?utf-8?B?VGVEN0ZtMm01U0pnYU1uT08wWjlsa3F4V2NNc1VpdFJwbzkzQzdsZGFld05Y?= =?utf-8?B?Y00zdHQvY3FTS2ltcFppT2dNL0xNK0E5YnlaVVd2RXRiZFU0cHk3Yy9oMWpy?= =?utf-8?B?SFE9PQ==?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1c091df-e32a-4add-3715-08da5dd70d1b X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 16:05:44.7616 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: r9AqIgJoAoZ1jPfrQa4DKY+7WoESui8lhyecu99MHOYHojpj43t7SxzVm8lgNYLrKz6j5SLq/zhNjSf0yjkAVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6622 On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: > On Mon, Jul 4, 2022 at 11:15 PM G.R. wrote: > > > > On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: > > > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: > > > > Can you paste the lspci -vvv output for any other device you are also > > > > passing through to this guest? > > > > > > > > As reminded by this request, I tried to assign this nvme device to > > another FreeBSD12 domU. > Just to clarify, this time this NVME SSD is the only device I passed to this VM. > > > This time it does not fail at the VM setup stage, but the device is > > still not usable at the domU. > > The nvmecontrol command is not able to talk to the device at all: > > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 > > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 > > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > > > > The QEMU log says the following: > > 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00) > > [00:05.0] If the device doesn't work, try enabling permissive mode > > [00:05.0] (unsafe) and if it helps report the problem to xen-devel > > [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) > > I retried with the following: > pci=['05:00.0,permissive=1,msitranslate=1'] > Those extra options suppressed some error logging, but still didn't > make the device usable to the domU. > The nvmecontrol command still get ABORTED result from the kernel... > > The only thing remained in the QEMU file is this one: > [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) Hm it seems like Xen doesn't find the position of the MSI-X table correctly, given there's only one error path from msi.c returning -ENODATA (61). Are there errors from pciback when this happens? I would expect the call to pci_prepare_msix() from pciback to fail and thus also report some error? I think it's likely I will have to provide an additional debug patch to Xen, maybe Jan has an idea of what could be going on. Roger. From xen-devel-bounces@lists.xenproject.org Mon Jul 04 16:07:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 16:07:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360470.589874 (Exim 4.92) (envelope-from ) id 1o8Oba-0004EK-F1; Mon, 04 Jul 2022 16:07:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360470.589874; Mon, 04 Jul 2022 16:07:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Oba-0004ED-C2; Mon, 04 Jul 2022 16:07:22 +0000 Received: by outflank-mailman (input) for mailman id 360470; Mon, 04 Jul 2022 16:07:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ObY-0003ID-Pz for xen-devel@lists.xen.org; Mon, 04 Jul 2022 16:07:20 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150047.outbound.protection.outlook.com [40.107.15.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 61992529-fbb3-11ec-bd2d-47488cf2e6aa; Mon, 04 Jul 2022 18:07:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4938.eurprd04.prod.outlook.com (2603:10a6:10:1f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Mon, 4 Jul 2022 16:07:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.020; Mon, 4 Jul 2022 16:07:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61992529-fbb3-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mPWRok2sCGGycIAlABkByXbAYPk5RWkhijdDt/a+OFPxfbqkOf3xfO6BqyKfgNbuntRU731FoWYVRncJVXq6LSLkt9t+C873sZTk/kqXPO8JPu1VkgFZF2YYSbVEeyHMz2peWIyKxefnIrx3AKcJGg8zSzJnY2oz4CIESZxV1wvU0Ipyk++OWtEnQ2JYZgH6Hsr8cZoMXeLwXt6QyGn5FehaindcSEUnrR5JgtHciqqew16cfbdYBHgDen86UVmthtAgWhnjmmgKahgJ3e7KwwLAzcodnFdMraTS61exgt+7i719HThfrOyO2BBHIu4YQ+PsqUxwKDtYq91vhlkkLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yrLnmREYn27xx1jqBfZXAI2eo/abf2oVC83FWsdzA7w=; b=dNms2NHWLchCinJh1H7iVUsivXu57OGbz2aUyNnMVGR31BKe+w3KB+zeqLXYXMJ3h+z25qRMVLzBmoCTPlB79Ysi8fwiJvGNL1WsuIVWyuW7pquX7NzTaIGvyJ6uxKKZcZLH7HUSAYWoLMou2LqmS93KAxO6WP6tP1/fdgJKUINB9r8YiM/ThWjXNGPL/xHaRDf/ylw0RheE9EhGQtwbZhRrGJJiHKk6pIx5uiRTJ0jEFSYKllCPjFQ7EY8Tlt56/GOugvBSedyk/uqz8eDdeoN1mDaoolYkiqpuZ//zZkmaWt7wU91UhjsH1C+b9XpE0TcY7kOeUvweAxB4+P1ZhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrLnmREYn27xx1jqBfZXAI2eo/abf2oVC83FWsdzA7w=; b=3lR7FepSH6oV2JZU65Y0mC1AknvzP28cIsMlD9wz4ZmvBXgtEs7Ek94TuJH28UKzVE56JgK0Mj+PQzkH2HmeQWPKrL3E4pw8lcq+bGTUjry+fKL7ISLu3I6y8Sjtp+Nt9Wi8kK2Id4tsNMuv7R1MxNdmQOWp3uiXgQR0B4Cfs9yg8bAq+qU8e4BSxr2XYWfZY/PLysTCJPL0sjj+O9gy4AHggqKCeOTjhXXFdPyZqr8WJBwqltvfKxTqsnLciS3q3wZxKqR6mbYkAzwpPl3pO/b8xFti3suvO3/Cp8eZ7mj/RVXERqM5+AzkygfeKTLusucsrARwg3shVIUzusDIRg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7f58eb84-f969-dec2-dde4-18351761c216@suse.com> Date: Mon, 4 Jul 2022 18:07:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: xen-devel , "G.R." References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b50884ef-1a18-485e-e5ab-08da5dd744c3 X-MS-TrafficTypeDiagnostic: DB7PR04MB4938:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FnRB/H0CuImOPMCz1ShLYxNiHs//qhzUsbIGtiGABxh005RgAxqC5XFhPYoxnctDPmqLa4W1OCaMw/v2YkSNE3eCCUujcw9v3el8HwPHMtEVmUFXGI+e06XlQjDr+gmQR0Ai5BTkmcXjdSjuqW2fKgks5AkQgMqFSDTiAiij8OxfdK2WW6PEljlIYumhR+9RSWdI1R4/R2xibsyJp7EgfxskZ15odbeJy6WrZ/vlJYyR6ik37t/kMPszzGaQzf3h7dijzOndCCS9IzjNz8VJHF1lCjZoGg/OhrX+YiblC1orDrxXK5izz+q43zSd8QR8Hv3QNUIbOpy3q/CZElAk0JraDo4bJ+MWcPV9jsUJMgiSYYfMo6PkN2OmcFHfFRUCE7KCaUJYo8EQM3WeYLVcQLM4xatYQlcE07LG0+UeW8al2SvRcyb3GRMcX/kvqUkAsLlf44B9Z1y5wM9FtaIKg7r8vUw9KsEh1mplB9w4G3KN0oWOs2xBq0z7RrjkLCKIwi176nXIG16Oq00bVTkLj7s04tyJzV+WT+u5vinQnFAwZd2PDQRRzk25z7PBZB4tfcHfkfaGheQbfXZm00vl8YPY3uzdkTJwlt+pGUCegUVYP+Kv+wQyhU3AG2dIRT3nYwReAwxbr8owZwgDvX+d01dEmghiBBYrtfgN1gQh8kI+4msgMNfP5FilWONyMinRldY6CyGumZDy2BSn8ip75xShuWO3P88jxnpw/ZtDHt6EFSxOTrxcYLO1SsswS36pWW8W19H3Ox1oTJSdKmIL1ETRBo6oD5NXsAZYXv+uUskLIxpUuloLaVYf8h4vAaUBrx7nIIeHHiRMFIGvR4I9OLtHYMh7gQF/Z+bwB2Tegs4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(346002)(136003)(376002)(39860400002)(8936002)(4326008)(6916009)(316002)(86362001)(66556008)(66946007)(38100700002)(8676002)(66476007)(54906003)(2616005)(31696002)(26005)(6512007)(6506007)(53546011)(41300700001)(6486002)(478600001)(5660300002)(2906002)(83380400001)(31686004)(36756003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q2hPQVF6bU1Xc2JKQkI5dVR5NXBQSzRiT2QvOGRJWnJocEk1cyt0UFdNRXdC?= =?utf-8?B?V3dFQkFDMGx6U3FqMlRDcS9lTHlSM2tjdWtaekcxODBzU1QwWCs5Q0dNSzls?= =?utf-8?B?bWlGa0xLam85ek94K3dUTlJYcWx2bllTMHlZYXVKYmZ5amlTeitIS2djejV1?= =?utf-8?B?MFdDRkQ2SitsQ0N6YUh0UUpDZmRhSURTajl1bjkrS1I4bkI4NFJuUWY4bkR6?= =?utf-8?B?UDJxZ2tocWRDM0E0cjE3TnVueS9ud2ZmZUZhL3NYOGdEbWVtVWZwQUZoMEpT?= =?utf-8?B?d25kbWpXTVVkOWVBSUlMQXROYnZoRytIY0FxQ1lkemRTcnNQb0VIUXVwUmQy?= =?utf-8?B?TTF2TDJ6b01VTnFWc2dPT04wNGtIVm5BRzBlUWwwVEhXdjlmaHo4ZitORVFF?= =?utf-8?B?WEo4Ly9nUlc0THpoNDRObGNvT3QzYkF2QzZrZVBueTlmbHdEazE5V0drT3dJ?= =?utf-8?B?M1dmV3JNYWxjUE1sNFUveis2dUszMDhKQUNIY2pvb2JSNGdVNzlsVXpETzhB?= =?utf-8?B?ZUlIbDdGdzlwazIzSlc5TXIzcjdOazczalJocnkrSFpXTFZveW8weHlDMm8r?= =?utf-8?B?aEJ3a2psZ3I2bUo5YkRzV3pCYWpYNGcwZm9JcFkyV3JyQnBUc1FOeW10QVpj?= =?utf-8?B?bTRRQU5ZelFqMi9WOUhlVUgvZTN0d09tWFFRbnkrVjdNT01uYnNPUkdZNkkr?= =?utf-8?B?YkFTaUR4bnBNa3dnRGg2Wmt6LzBQMnZTUnVvc3FsKzRXY2ZZUVk3cWVXRXZU?= =?utf-8?B?eDAxTlFVNDVNUXVqUzdtZS9INC9hOGZvNFk5bjVINVEwc3oxcnYzZkFyUWZp?= =?utf-8?B?QkhBcHdBdnl6azJmSHUrR3V6YjBESGNYNHZ1akVlMXFxS0ZOY1FuSWU0RWpR?= =?utf-8?B?QzYzbHZOdlljODdMNXR1Rlprazh3bGZiUjJIdnAzUExxNzJOWG5STENIa0Fm?= =?utf-8?B?aERVYVZRdnBzQWVTcWVEc0k0M1pHYlpibEd2SlN0cHlFRkcrL2UzM1JRMzJK?= =?utf-8?B?UmFnYXJoWDEyOGRvTmhTdzdlYWhJbThSOHJLaVBja3NlUkdPcmhEK0J1b3JQ?= =?utf-8?B?cktBeEk2QVRSQzh4S2lWWWhFYUI0Vlh0RlRvU2k0RDRCYm1nMCsxc1Y3UW83?= =?utf-8?B?OGg3amRUK01aMC8xKzhtZmZVNyt5R2hkd1h3RlVCZmRMUXM5QzFxVldXWDht?= =?utf-8?B?aE10Wjc4Mnc0OTZyZUd0UGtRdDRnNVhrbUp1dFZ5Rk5kdjEyRFlHdHhETnpo?= =?utf-8?B?QWJBdW12bXNsL1VUY2g0elJGYTJCYmFRaXQ2R2phQnc5azZxeDJGN0FGR0dM?= =?utf-8?B?b3NDa1I3T2RPNEd0OVh3ZUVNVkZ4cFNLazhsRTd5dVlMWTRwTlhMVkdUZWVy?= =?utf-8?B?elNvNU1qSDZoNHNGenl6RnJpM0NaenJ0dklCc0pKRW5xZTNEL0VpV0FRS1ZE?= =?utf-8?B?a2JIUEorU2VOOTA0L0hQaGxuM2E0aVd5cldrVThpVE9XOEN2NW5WcEdaZUZn?= =?utf-8?B?ZmZpdWw4d3JISllEOS9aZ3VhdHo3UlJUZ3NFVG56WVVaZWtpKzJwS3Y4UktQ?= =?utf-8?B?MGwvSW9EZkpoMzQ1M2tmK1JVM3dXOHFyTjlEeHlKZy9rK29uZUJMUy9GTmd1?= =?utf-8?B?b25vcmVLTE94aXR1VitkZ1ZmdEFaMFlRQkpWeUtETE03NllNOUM2eVc3T056?= =?utf-8?B?SG1JMU5Od1B5VFB0Wm0venpHbmJ3NklFQmtucXMySGZhL2tsakFQVGZsS2t6?= =?utf-8?B?cDhrR1JzNGFHM0Y4VHF5TFJFWDBmSG9TdzVhMnRtQU9uaytDODU5SG5xMjlh?= =?utf-8?B?UVpIOGxyVlJnREx5bS9JbXNPVTFPa1lPQ1ZRMlgwNlFhRGozNlRZdWVGZE9R?= =?utf-8?B?LzQvMmlwYmQ2Vy9pUTN2RGo1NU56eEVjV3RiQkhVdEI1VThHKzdiMlZXd0Ex?= =?utf-8?B?MDlWbUZIZGNEWnpyQ1FZRE1KL3llczBabjg3NWlGVVVZeFVrTEwyaUJuWEh2?= =?utf-8?B?RFg4YWZPTXcxK0pGVk5maU9pMWFyUVg1bVNXT1pCQXVyVmVER3paTzFEeStZ?= =?utf-8?B?b2dDRUhHcGloS014R2dUdEl2dUg0YUZFTnF5T0Y3Vm5wSFBwUHVqN1B1UGtN?= =?utf-8?Q?QRQqNf5hJpqVQO0t/9XERAvz6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b50884ef-1a18-485e-e5ab-08da5dd744c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2022 16:07:18.0949 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TfezfpLUnrRAddoaLDZt+d1aUI/c/7lVvY7r/bxeWJvQzg5ERnVoD+6tDwqSYgVuXjxOF/LFVu7ApVc/HfjVTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4938 On 04.07.2022 18:05, Roger Pau Monné wrote: > On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: >> On Mon, Jul 4, 2022 at 11:15 PM G.R. wrote: >>> >>> On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: >>>> >>>> On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: >>>>> Can you paste the lspci -vvv output for any other device you are also >>>>> passing through to this guest? >>>>> >>> >>> As reminded by this request, I tried to assign this nvme device to >>> another FreeBSD12 domU. >> Just to clarify, this time this NVME SSD is the only device I passed to this VM. >> >>> This time it does not fail at the VM setup stage, but the device is >>> still not usable at the domU. >>> The nvmecontrol command is not able to talk to the device at all: >>> nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 >>> nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 >>> nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 >>> nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 >>> >>> The QEMU log says the following: >>> 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00) >>> [00:05.0] If the device doesn't work, try enabling permissive mode >>> [00:05.0] (unsafe) and if it helps report the problem to xen-devel >>> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) >> >> I retried with the following: >> pci=['05:00.0,permissive=1,msitranslate=1'] >> Those extra options suppressed some error logging, but still didn't >> make the device usable to the domU. >> The nvmecontrol command still get ABORTED result from the kernel... >> >> The only thing remained in the QEMU file is this one: >> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) > > Hm it seems like Xen doesn't find the position of the MSI-X table > correctly, given there's only one error path from msi.c returning > -ENODATA (61). > > Are there errors from pciback when this happens? I would expect the > call to pci_prepare_msix() from pciback to fail and thus also report > some error? > > I think it's likely I will have to provide an additional debug patch > to Xen, maybe Jan has an idea of what could be going on. No, sorry, not without - as you say - further debugging output added. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 04 16:13:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 16:13:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360478.589885 (Exim 4.92) (envelope-from ) id 1o8OhJ-0005nd-3h; Mon, 04 Jul 2022 16:13:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360478.589885; Mon, 04 Jul 2022 16:13:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OhJ-0005nW-0c; Mon, 04 Jul 2022 16:13:17 +0000 Received: by outflank-mailman (input) for mailman id 360478; Mon, 04 Jul 2022 16:13:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OhH-0005nM-RA; Mon, 04 Jul 2022 16:13:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OhH-0003KI-Ng; Mon, 04 Jul 2022 16:13:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OhF-000160-Mh; Mon, 04 Jul 2022 16:13:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8OhF-0002Pm-MF; Mon, 04 Jul 2022 16:13:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RA0eydPoYRqC7PrtfkQNCuNp7fhqAUSyPV1qnDhMwmA=; b=TkAADf2xxmpGct32CIN6yOykmJ ab5bd5Mg1C0aj86UXdSY4KcHXDJrq89ASctBNcgsC/asCYEhtd1fqoUCeapExJt7wVVBGPP3li6RE fS3W/FhKjycBZIRdvBb+XqEnbNNNq+4ZKe2oX3IXs8MhxBM53mvsavybmdl0H0Uy5sOY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171486: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 X-Osstest-Versions-That: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 From: osstest service owner Date: Mon, 04 Jul 2022 16:13:13 +0000 flight 171486 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171486/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 baseline version: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 Last test of basis 171447 2022-07-01 18:00:25 Z 2 days Testing same since 171486 2022-07-04 13:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Daniel P. Smith Julien Grall Julien Grall # arm Luca Fancellu Michal Orzel Rahul Singh Roger Pau Monné Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bf2f989531..4df2e99d73 4df2e99d731402da48afb19dc970ccab5a0814d6 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 04 16:31:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 16:31:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360488.589898 (Exim 4.92) (envelope-from ) id 1o8OzH-0008R4-O1; Mon, 04 Jul 2022 16:31:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360488.589898; Mon, 04 Jul 2022 16:31:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OzH-0008Qx-LB; Mon, 04 Jul 2022 16:31:51 +0000 Received: by outflank-mailman (input) for mailman id 360488; Mon, 04 Jul 2022 16:31:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8OzG-0008Qr-MJ for xen-devel@lists.xen.org; Mon, 04 Jul 2022 16:31:50 +0000 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd6aa565-fbb6-11ec-a8e4-439420d8e422; Mon, 04 Jul 2022 18:31:49 +0200 (CEST) Received: by mail-ed1-f49.google.com with SMTP id r6so921976edd.7 for ; Mon, 04 Jul 2022 09:31:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd6aa565-fbb6-11ec-a8e4-439420d8e422 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8gcOlr7F5gkANMo3hwqi1J4omoYV5m36IRd0Gb6D9GE=; b=byOJenu/3v8kHR06qMaLzXe4emoFfRIk8Jp9abpL0AxbER/o3+V05K/HE8j48avcFT ekIUa3qD2P+LMv9VNazkifHWElWVG9fKz6JqIY6NUpK34r5/XMDeeScnszuyPJdJckAY b5uSHlD7jmryA5812QTGdKk5mR0WWoJu/Z75JzJ/BRTMKp537JSpQK87s2joVlStZQyf QEFOjiQhw/9qYmqpq0aWebSG23Ol3ixdMeBPMiqcjLFUD38/RTE5sqWpbvsMmzeNMwZe XArcxYdqC9kzXv+4L98TQCiUFLmuj4q8c+vEgF8VG71YHMv7swjXcei/Z3xZKpY40nRH cerA== X-Gm-Message-State: AJIora8ZeBAIk9p7j7xSdd2yUsq5Sd3xVc97Ap5TYwD0KdrvvSMyIvyT d/YlktDOQUmpQ7tnsnAQxv8/2nOpjtKChkPfwRI= X-Google-Smtp-Source: AGRyM1u06T0mHrqRNeznQffYrSvE2RibYUWxW/u25v3845hnOLfDpAaiJHlJpC/VmN05vBh2G+sSleqeAyt1SYr+qNA= X-Received: by 2002:a05:6402:2552:b0:435:9e1c:ca49 with SMTP id l18-20020a056402255200b004359e1cca49mr40164489edb.126.1656952308786; Mon, 04 Jul 2022 09:31:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Tue, 5 Jul 2022 00:31:36 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: xen-devel , Jan Beulich Content-Type: multipart/mixed; boundary="000000000000c67d0a05e2fd45a3" --000000000000c67d0a05e2fd45a3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monn=C3=A9 = wrote: > > On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: > > On Mon, Jul 4, 2022 at 11:15 PM G.R. = wrote: > > > > > > On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: > > > > > > > > On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monn=C3=A9 wrote: > > > > > Can you paste the lspci -vvv output for any other device you are = also > > > > > passing through to this guest? > > > > > > > > > > > As reminded by this request, I tried to assign this nvme device to > > > another FreeBSD12 domU. > > Just to clarify, this time this NVME SSD is the only device I passed to= this VM. > > > > > This time it does not fail at the VM setup stage, but the device is > > > still not usable at the domU. > > > The nvmecontrol command is not able to talk to the device at all: > > > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:0000000= 0 > > > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > > > nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:0000000= 0 > > > nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 > > > > > > The QEMU log says the following: > > > 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00= ) > > > [00:05.0] If the device doesn't work, try enabling permissive mode > > > [00:05.0] (unsafe) and if it helps report the problem to xen-devel > > > [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30= , entry 0) > > > > I retried with the following: > > pci=3D['05:00.0,permissive=3D1,msitranslate=3D1'] > > Those extra options suppressed some error logging, but still didn't > > make the device usable to the domU. > > The nvmecontrol command still get ABORTED result from the kernel... > > > > The only thing remained in the QEMU file is this one: > > [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, = entry 0) > > Hm it seems like Xen doesn't find the position of the MSI-X table > correctly, given there's only one error path from msi.c returning > -ENODATA (61). > > Are there errors from pciback when this happens? I would expect the > call to pci_prepare_msix() from pciback to fail and thus also report > some error? > > I think it's likely I will have to provide an additional debug patch > to Xen, maybe Jan has an idea of what could be going on. > pciback reports the same MSI-x related error. But even with DEBUG enabled, I didn't see more context reported. Please find details from the attachment. > Roger. --000000000000c67d0a05e2fd45a3 Content-Type: text/x-log; charset="US-ASCII"; name="pciback_dbg_xl-pci_assignable_XXX.log" Content-Disposition: attachment; filename="pciback_dbg_xl-pci_assignable_XXX.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l56yk3cu0 cm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLWFkZCAwNTowMC4wCmxpYnhsOiB3YXJuaW5n OiBsaWJ4bF9wY2kuYzo4MTQ6bGlieGxfX2RldmljZV9wY2lfYXNzaWduYWJsZV9hZGQ6IDAwMDA6 MDU6MDAuMCBub3QgYm91bmQgdG8gYSBkcml2ZXIsIHdpbGwgbm90IGJlIHJlYm91bmQuCgpbICAz MjMuNDQ4MTE1XSB4ZW5fcGNpYmFjazogd2FudHMgdG8gc2VpemUgMDAwMDowNTowMC4wClsgIDMy My40NDgxMzZdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcHJvYmluZy4uLgpb ICAzMjMuNDQ4MTM3XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHNlaXppbmcg ZGV2aWNlClsgIDMyMy40NDgxNjJdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazog cGNpc3R1Yl9kZXZpY2VfYWxsb2MKWyAgMzIzLjQ0ODE2Ml0gcGNpYmFjayAwMDAwOjA1OjAwLjA6 IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcuLi4KWyAgMzIzLjQ0ODE2M10gcGNpYmFjayAwMDAw OjA1OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcgY29uZmlnClsgIDMyMy40NDgzNDRd IHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZW5hYmxpbmcgZGV2aWNlClsgIDMy My40NDg0MjVdIHhlbjogcmVnaXN0ZXJpbmcgZ3NpIDE2IHRyaWdnZXJpbmcgMCBwb2xhcml0eSAx ClsgIDMyMy40NDg0MjhdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTYKWyAgMzIzLjQ0ODQ5N10g cGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBzYXZlIHN0YXRlIG9mIGRldmljZQpb ICAzMjMuNDQ4NjQyXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlc2V0dGlu ZyAoRkxSLCBEMywgZXRjKSB0aGUgZGV2aWNlClsgIDMyMy40NDg3MDddIHBjaWVwb3J0IDAwMDA6 MDA6MWQuMDogRFBDOiBjb250YWlubWVudCBldmVudCwgc3RhdHVzOjB4MWYxMSBzb3VyY2U6MHgw MDAwClsgIDMyMy40NDg3MzBdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDogRFBDOiB1bm1hc2tlZCB1 bmNvcnJlY3RhYmxlIGVycm9yIGRldGVjdGVkClsgIDMyMy40NDg3NjBdIHBjaWVwb3J0IDAwMDA6 MDA6MWQuMDogUENJZSBCdXMgRXJyb3I6IHNldmVyaXR5PVVuY29ycmVjdGVkIChOb24tRmF0YWwp LCB0eXBlPVRyYW5zYWN0aW9uIExheWVyLCAoUmVjZWl2ZXIgSUQpClsgIDMyMy40NDg3ODZdIHBj aWVwb3J0IDAwMDA6MDA6MWQuMDogICBkZXZpY2UgWzgwODY6YTMzMF0gZXJyb3Igc3RhdHVzL21h c2s9MDAyMDAwMDAvMDAwMTAwMDAKWyAgMzIzLjQ0ODgxM10gcGNpZXBvcnQgMDAwMDowMDoxZC4w OiAgICBbMjFdIEFDU1Zpb2wgICAgICAgICAgICAgICAgKEZpcnN0KQpbICAzMjQuNjkwOTc5XSBw Y2liYWNrIDAwMDA6MDU6MDAuMDogbm90IHJlYWR5IDEwMjNtcyBhZnRlciBGTFI7IHdhaXRpbmcK WyAgMzI1LjczMDcwNl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IG5vdCByZWFkeSAyMDQ3bXMgYWZ0 ZXIgRkxSOyB3YWl0aW5nClsgIDMyNy45OTc2MzhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiBub3Qg cmVhZHkgNDA5NW1zIGFmdGVyIEZMUjsgd2FpdGluZwpbICAzMzIuMjY0MjUxXSBwY2liYWNrIDAw MDA6MDU6MDAuMDogbm90IHJlYWR5IDgxOTFtcyBhZnRlciBGTFI7IHdhaXRpbmcKWyAgMzQwLjU4 NDMyMF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IG5vdCByZWFkeSAxNjM4M21zIGFmdGVyIEZMUjsg d2FpdGluZwpbICAzNTcuMDEwODk2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogbm90IHJlYWR5IDMy NzY3bXMgYWZ0ZXIgRkxSOyB3YWl0aW5nClsgIDM5MS4xNDM5NTFdIHBjaWJhY2sgMDAwMDowNTow MC4wOiBub3QgcmVhZHkgNjU1MzVtcyBhZnRlciBGTFI7IGdpdmluZyB1cApbICAzOTIuMjQ5MjUy XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlc2V0IGRldmljZQpbICAzOTIu MjQ5MzkyXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHhlbl9wY2lia19lcnJv cl9kZXRlY3RlZChidXM6NSxkZXZmbjowKQpbICAzOTIuMjQ5MzkzXSBwY2liYWNrIDAwMDA6MDU6 MDAuMDogeGVuX3BjaWJhY2s6IGRldmljZSBpcyBub3QgZm91bmQvYXNzaWduZWQKWyAgMzkyLjM5 NzA3NF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiB4ZW5fcGNpYmtfZXJyb3Jf cmVzdW1lKGJ1czo1LGRldmZuOjApClsgIDM5Mi4zOTcwODBdIHBjaWJhY2sgMDAwMDowNTowMC4w OiB4ZW5fcGNpYmFjazogZGV2aWNlIGlzIG5vdCBmb3VuZC9hc3NpZ25lZApbICAzOTIuMzk3Mjg0 XSBwY2llcG9ydCAwMDAwOjAwOjFkLjA6IEFFUjogZGV2aWNlIHJlY292ZXJ5IHN1Y2Nlc3NmdWwK CmxpYnhsOiBlcnJvcjogbGlieGxfcGNpLmM6ODM1OmxpYnhsX19kZXZpY2VfcGNpX2Fzc2lnbmFi bGVfYWRkOiBmYWlsZWQgdG8gcXVhcmFudGluZSAwMDAwOjA1OjAwLjAKCnJvb3RAZ2FpYTp+IyB4 bCBwY2ktYXNzaWduYWJsZS1yZW1vdmUgMDU6MDAuMApsaWJ4bDogZXJyb3I6IGxpYnhsX3BjaS5j Ojg1MzpsaWJ4bF9fZGV2aWNlX3BjaV9hc3NpZ25hYmxlX3JlbW92ZTogZmFpbGVkIHRvIGRlLXF1 YXJhbnRpbmUgMDAwMDowNTowMC4wCnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1hZGQg MDU6MDAuMApsaWJ4bDogd2FybmluZzogbGlieGxfcGNpLmM6Nzk0OmxpYnhsX19kZXZpY2VfcGNp X2Fzc2lnbmFibGVfYWRkOiAwMDAwOjA1OjAwLjAgYWxyZWFkeSBhc3NpZ25lZCB0byBwY2liYWNr CnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1yZW1vdmUgMDU6MDAuMApbICA2MDMuOTI4 MDM5XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHJlbW92aW5nClsgIDYwMy45 MjgwNDFdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZm91bmQgZGV2aWNlIHRv IHJlbW92ZSAKWyAgNjAzLjkyODA0Ml0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBwY2lzdHViX2RldmljZV9yZWxlYXNlClsgIDYwNC4wMzMzNzJdIHBjaWVwb3J0IDAwMDA6MDA6 MWQuMDogRFBDOiBjb250YWlubWVudCBldmVudCwgc3RhdHVzOjB4MWYxMSBzb3VyY2U6MHgwMDAw ClsgIDYwNC4wMzM1MTJdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDogRFBDOiB1bm1hc2tlZCB1bmNv cnJlY3RhYmxlIGVycm9yIGRldGVjdGVkClsgIDYwNC4wMzM2MzFdIHBjaWVwb3J0IDAwMDA6MDA6 MWQuMDogUENJZSBCdXMgRXJyb3I6IHNldmVyaXR5PVVuY29ycmVjdGVkIChOb24tRmF0YWwpLCB0 eXBlPVRyYW5zYWN0aW9uIExheWVyLCAoUmVxdWVzdGVyIElEKQpbICA2MDQuMDMzNzU4XSBwY2ll cG9ydCAwMDAwOjAwOjFkLjA6ICAgZGV2aWNlIFs4MDg2OmEzMzBdIGVycm9yIHN0YXR1cy9tYXNr PTAwMTAwMDAwLzAwMDEwMDAwClsgIDYwNC4wMzM4NTZdIHBjaWVwb3J0IDAwMDA6MDA6MWQuMDog ICAgWzIwXSBVbnN1cFJlcSAgICAgICAgICAgICAgIChGaXJzdCkKWyAgNjA0LjAzMzkzOV0gcGNp ZXBvcnQgMDAwMDowMDoxZC4wOiBBRVI6ICAgVExQIEhlYWRlcjogMzQwMDAwMDAgMDUwMDAwMTAg MDAwMDAwMDAgODg0NTg4NDUKWyAgNjA0LjAzNDA1OV0gcGNpIDAwMDA6MDU6MDAuMDogQUVSOiBj YW4ndCByZWNvdmVyIChubyBlcnJvcl9kZXRlY3RlZCBjYWxsYmFjaykKWyAgNjA0LjAzNDQyMV0g eGVuX3BjaWJhY2s6IHJlbW92ZWQgMDAwMDowNTowMC4wIGZyb20gc2VpemUgbGlzdApbICA2MDQu MTgyNTk3XSBwY2llcG9ydCAwMDAwOjAwOjFkLjA6IEFFUjogZGV2aWNlIHJlY292ZXJ5IHN1Y2Nl c3NmdWwKCnJvb3RAZ2FpYTp+IyB4bCBwY2ktYXNzaWduYWJsZS1hZGQgMDU6MDAuMApsaWJ4bDog d2FybmluZzogbGlieGxfcGNpLmM6ODE0OmxpYnhsX19kZXZpY2VfcGNpX2Fzc2lnbmFibGVfYWRk OiAwMDAwOjA1OjAwLjAgbm90IGJvdW5kIHRvIGEgZHJpdmVyLCB3aWxsIG5vdCBiZSByZWJvdW5k LgpbICA2NjcuNTgyMDUxXSB4ZW5fcGNpYmFjazogd2FudHMgdG8gc2VpemUgMDAwMDowNTowMC4w ClsgIDY2Ny41ODIxMzBdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcHJvYmlu Zy4uLgpbICA2NjcuNTgyMTM0XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHNl aXppbmcgZGV2aWNlClsgIDY2Ny41ODIyMjhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNp YmFjazogcGNpc3R1Yl9kZXZpY2VfYWxsb2MKWyAgNjY3LjU4MjIzMV0gcGNpYmFjayAwMDAwOjA1 OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcuLi4KWyAgNjY3LjU4MjIzNV0gcGNpYmFj ayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBpbml0aWFsaXppbmcgY29uZmlnClsgIDY2Ny41 ODI1NDhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogZW5hYmxpbmcgZGV2aWNl ClsgIDY2Ny41ODI1OTldIHBjaWJhY2sgMDAwMDowNTowMC4wOiBlbmFibGluZyBkZXZpY2UgKDAw MDAgLT4gMDAwMikKWyAgNjY3LjU4MjkxMl0geGVuOiByZWdpc3RlcmluZyBnc2kgMTYgdHJpZ2dl cmluZyAwIHBvbGFyaXR5IDEKWyAgNjY3LjU4MjkyM10gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDox NgpbICA2NjcuNTgzMDYxXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IE1TSS1Y IHByZXBhcmF0aW9uIGZhaWxlZCAoLTYpClsgIDY2Ny41ODMxNDhdIHBjaWJhY2sgMDAwMDowNTow MC4wOiB4ZW5fcGNpYmFjazogc2F2ZSBzdGF0ZSBvZiBkZXZpY2UKWyAgNjY3LjU4MzU2OV0gcGNp YmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiByZXNldHRpbmcgKEZMUiwgRDMsIGV0Yykg dGhlIGRldmljZQpbICA2NjcuNjg5NjU2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJh Y2s6IHJlc2V0IGRldmljZQoKcm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLXJlbW92ZSAw NTowMC4wClsgIDcyMC45NTc5ODhdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazog cmVtb3ZpbmcKWyAgNzIwLjk1Nzk5Nl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBmb3VuZCBkZXZpY2UgdG8gcmVtb3ZlIApbICA3MjAuOTU3OTk5XSBwY2liYWNrIDAwMDA6MDU6 MDAuMDogeGVuX3BjaWJhY2s6IHBjaXN0dWJfZGV2aWNlX3JlbGVhc2UKWyAgNzIxLjA2NTIyMl0g cGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBNU0ktWCByZWxlYXNlIGZhaWxlZCAo LTE2KQpbICA3MjEuMDY1NjY3XSB4ZW5fcGNpYmFjazogcmVtb3ZlZCAwMDAwOjA1OjAwLjAgZnJv bSBzZWl6ZSBsaXN0Cgpyb290QGdhaWE6fiMgeGwgcGNpLWFzc2lnbmFibGUtYWRkIDA1OjAwLjAK bGlieGw6IHdhcm5pbmc6IGxpYnhsX3BjaS5jOjgxNDpsaWJ4bF9fZGV2aWNlX3BjaV9hc3NpZ25h YmxlX2FkZDogMDAwMDowNTowMC4wIG5vdCBib3VuZCB0byBhIGRyaXZlciwgd2lsbCBub3QgYmUg cmVib3VuZC4KClsgIDc2My44ODg2MzFdIHhlbl9wY2liYWNrOiB3YW50cyB0byBzZWl6ZSAwMDAw OjA1OjAwLjAKWyAgNzYzLjg4ODY5MF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNr OiBwcm9iaW5nLi4uClsgIDc2My44ODg2OTFdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNp YmFjazogc2VpemluZyBkZXZpY2UKWyAgNzYzLjg4ODcxNl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6 IHhlbl9wY2liYWNrOiBwY2lzdHViX2RldmljZV9hbGxvYwpbICA3NjMuODg4NzE3XSBwY2liYWNr IDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IGluaXRpYWxpemluZy4uLgpbICA3NjMuODg4NzE3 XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IGluaXRpYWxpemluZyBjb25maWcK WyAgNzYzLjg4ODgwNF0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBlbmFibGlu ZyBkZXZpY2UKWyAgNzYzLjg4ODg4NV0geGVuOiByZWdpc3RlcmluZyBnc2kgMTYgdHJpZ2dlcmlu ZyAwIHBvbGFyaXR5IDEKWyAgNzYzLjg4ODg4OV0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpb ICA3NjMuODg4OTQ5XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IE1TSS1YIHBy ZXBhcmF0aW9uIGZhaWxlZCAoLTYpClsgIDc2My44ODg5NzddIHBjaWJhY2sgMDAwMDowNTowMC4w OiB4ZW5fcGNpYmFjazogc2F2ZSBzdGF0ZSBvZiBkZXZpY2UKWyAgNzYzLjg4OTEyNl0gcGNpYmFj ayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiByZXNldHRpbmcgKEZMUiwgRDMsIGV0YykgdGhl IGRldmljZQpbICA3NjMuOTk0MjA2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6 IHJlc2V0IGRldmljZQoKcm9vdEBnYWlhOn4jIHhsIHBjaS1hc3NpZ25hYmxlLXJlbW92ZSAwNTow MC4wClsgIDgxOS40OTEwMDBdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcmVt b3ZpbmcKWyAgODE5LjQ5MTAwMl0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBm b3VuZCBkZXZpY2UgdG8gcmVtb3ZlIApbICA4MTkuNDkxMDAzXSBwY2liYWNrIDAwMDA6MDU6MDAu MDogeGVuX3BjaWJhY2s6IHBjaXN0dWJfZGV2aWNlX3JlbGVhc2UKWyAgODE5LjU5NjExM10gcGNp YmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBNU0ktWCByZWxlYXNlIGZhaWxlZCAoLTE2 KQpbICA4MTkuNTk2NDY2XSB4ZW5fcGNpYmFjazogcmVtb3ZlZCAwMDAwOjA1OjAwLjAgZnJvbSBz ZWl6ZSBsaXN0Cgo= --000000000000c67d0a05e2fd45a3-- From xen-devel-bounces@lists.xenproject.org Mon Jul 04 18:06:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 18:06:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360500.589913 (Exim 4.92) (envelope-from ) id 1o8QSn-0001Q4-Gd; Mon, 04 Jul 2022 18:06:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360500.589913; Mon, 04 Jul 2022 18:06:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8QSn-0001Px-DS; Mon, 04 Jul 2022 18:06:25 +0000 Received: by outflank-mailman (input) for mailman id 360500; Mon, 04 Jul 2022 18:06:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8QSm-0001Pn-5I; Mon, 04 Jul 2022 18:06:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8QSm-0005Jv-2i; Mon, 04 Jul 2022 18:06:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8QSl-0004Av-Lm; Mon, 04 Jul 2022 18:06:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8QSl-0002GA-LE; Mon, 04 Jul 2022 18:06:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w5rEZ5v4UOcrwpLrPtgDounfisQjhtKRUo9stNZ9cxc=; b=WsBnm9bmlWUcZmGUvVpT6j/jqv KoELysjnP+CW3eOaxDHjG245RZzW7NYNHKzkeh+V3ZJceHVfL6SYO6oox18Vkl4z+roCn6QpfQFFG czYwz4mL4Lx8ehx0iiuP2kPvskfykei9tndlXxT0gZ/L5lPVfiCuth/PNUTsSuzrd2ug=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171482: regressions - FAIL X-Osstest-Failures: qemu-mainline:build-arm64-xsm:xen-build:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-raw:guest-saverestore:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=e8e86b484eac70cd86e15fa10a2f0038a536cbba X-Osstest-Versions-That: qemuu=ba45b82518bd5d9cad509765411e7f82a73aed53 From: osstest service owner Date: Mon, 04 Jul 2022 18:06:23 +0000 flight 171482 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171482/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-xsm 6 xen-build fail REGR. vs. 171462 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail in 171472 pass in 171482 test-amd64-amd64-xl-qcow2 22 guest-start.2 fail in 171475 pass in 171482 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 171472 test-amd64-i386-libvirt-raw 16 guest-saverestore fail pass in 171475 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 171475 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 171475 never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 171475 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 171475 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171462 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171462 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171462 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu e8e86b484eac70cd86e15fa10a2f0038a536cbba baseline version: qemuu ba45b82518bd5d9cad509765411e7f82a73aed53 Last test of basis 171462 2022-07-03 01:07:33 Z 1 days Testing same since 171472 2022-07-03 11:33:24 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Anup Patel Atish Patra Atish Patra Bin Meng Nicolas Pitre Richard Henderson Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm fail build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 446 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 04 21:18:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 04 Jul 2022 21:18:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360523.589939 (Exim 4.92) (envelope-from ) id 1o8TSK-0004Z0-Cp; Mon, 04 Jul 2022 21:18:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360523.589939; Mon, 04 Jul 2022 21:18:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8TSK-0004Yt-A1; Mon, 04 Jul 2022 21:18:08 +0000 Received: by outflank-mailman (input) for mailman id 360523; Mon, 04 Jul 2022 21:18:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8TSI-0004Yj-FJ; Mon, 04 Jul 2022 21:18:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8TSI-0000Un-C0; Mon, 04 Jul 2022 21:18:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8TSH-0008An-SZ; Mon, 04 Jul 2022 21:18:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8TSH-0001HS-SD; Mon, 04 Jul 2022 21:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K/jmN+5AZoUiu7Ym33r/NQ0oA7IMrqQJWF6S1UyGByI=; b=zvI+yCV8PlK/FYM2X1tx9WlPvS qAxMc9d6QDVrwAvnahbfIFdSrtxtEEv7yCxda6L967mI2t+OY13Aot1igSgIr9ql/yCPCU/z0XJG8 1coKt9DuIzRgCnqnW7JAKnMNidMO/fAX49T2MlKB8P9Zpv16T+EhI4WajHOfhTdt0U3c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171488: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=88084a3df1672e131ddc1b4e39eeacfd39864acf X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Mon, 04 Jul 2022 21:18:05 +0000 flight 171488 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171488/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 88084a3df1672e131ddc1b4e39eeacfd39864acf baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 15 days Failing since 171280 2022-06-19 15:12:25 Z 15 days 41 attempts Testing same since 171478 2022-07-04 02:52:16 Z 0 days 2 attempts ------------------------------------------------------------ 469 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 18547 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 00:42:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 00:42:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360543.589950 (Exim 4.92) (envelope-from ) id 1o8Wdg-0001BC-19; Tue, 05 Jul 2022 00:42:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360543.589950; Tue, 05 Jul 2022 00:42:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Wdf-0001B5-TK; Tue, 05 Jul 2022 00:42:03 +0000 Received: by outflank-mailman (input) for mailman id 360543; Tue, 05 Jul 2022 00:42:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Wde-0001Av-Fl; Tue, 05 Jul 2022 00:42:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Wde-00050b-Am; Tue, 05 Jul 2022 00:42:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Wdd-00012x-Lm; Tue, 05 Jul 2022 00:42:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8Wdd-0005Kr-Kv; Tue, 05 Jul 2022 00:42:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1Xj7XFaYkrJ9Mjd+U7THGRFsdDi1eSDo69zvF09MHOA=; b=WLgAc2rdObcb0np0mZ5orS7LUf 2pR961hBwwzNXIxVpEtVbQrDuRsQ28hrQ8P1572kmSSX4pNLTfwCQVnmijA53ZwyLxpmPvoLQzBia xiCub13Veo0C8vORgVby1CV/kkDqQDgvODe/euNYCMm62R9jGGiBU8HOEZcXh37s5cOY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171491: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 X-Osstest-Versions-That: xen=bf2f989531ad3851685a1847cbc1e28901ed80a2 From: osstest service owner Date: Tue, 05 Jul 2022 00:42:01 +0000 flight 171491 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171491/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171477 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171477 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171477 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171477 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171477 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171477 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171477 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171477 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171477 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171477 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171477 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171477 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 baseline version: xen bf2f989531ad3851685a1847cbc1e28901ed80a2 Last test of basis 171477 2022-07-04 01:53:25 Z 0 days Testing same since 171491 2022-07-04 16:39:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Bertrand Marquis Daniel P. Smith Julien Grall Julien Grall # arm Luca Fancellu Michal Orzel Rahul Singh Roger Pau Monné Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git bf2f989531..4df2e99d73 4df2e99d731402da48afb19dc970ccab5a0814d6 -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 05 03:10:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 03:10:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360560.589981 (Exim 4.92) (envelope-from ) id 1o8YxT-0002DE-70; Tue, 05 Jul 2022 03:10:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360560.589981; Tue, 05 Jul 2022 03:10:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8YxT-0002D6-1C; Tue, 05 Jul 2022 03:10:39 +0000 Received: by outflank-mailman (input) for mailman id 360560; Tue, 05 Jul 2022 03:10:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8YxR-0002Cw-Tm; Tue, 05 Jul 2022 03:10:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8YxR-0001C8-R7; Tue, 05 Jul 2022 03:10:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8YxR-0004iw-Fm; Tue, 05 Jul 2022 03:10:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8YxR-0002sq-FI; Tue, 05 Jul 2022 03:10:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jTskerH/h47HkITFrCkzeaOOlJy8Naf2/9UHXtmY/wo=; b=2NVzlvUXSxcdO32RC7hnBWFg1c S1pwP5xnDe+cAUDCXUY5OnY0LO6qz1jqquKjyWRdi0t2FNwCmkWB5EHBI02TE3psQ5V1chYxGUI5g pTqzEMdphRHuM4Xkp8ZoSb0pbHMOTVQ98KmNf5M6y9pG4pEd+cEgYCCkwxjHOk5jFgQI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171493: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=1437479e5ee1a49ccd84cad9e7b010fb2ee9d805 X-Osstest-Versions-That: qemuu=ba45b82518bd5d9cad509765411e7f82a73aed53 From: osstest service owner Date: Tue, 05 Jul 2022 03:10:37 +0000 flight 171493 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171493/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171462 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171462 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171462 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171462 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171462 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171462 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 1437479e5ee1a49ccd84cad9e7b010fb2ee9d805 baseline version: qemuu ba45b82518bd5d9cad509765411e7f82a73aed53 Last test of basis 171462 2022-07-03 01:07:33 Z 2 days Failing since 171472 2022-07-03 11:33:24 Z 1 days 4 attempts Testing same since 171493 2022-07-04 18:37:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Alistair Francis Anup Patel Atish Patra Atish Patra Bin Meng Gerd Hoffmann Hongren (Zenithal) Zheng Jianxian Wen Lu Gao Mao Bibo MkfsSion Nicolas Pitre Richard Henderson Simon Sapin Song Gao Víctor Colombo Wen, Jianxian Xiaojuan Yang YuanYang Meng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git ba45b82518..1437479e5e 1437479e5ee1a49ccd84cad9e7b010fb2ee9d805 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Jul 05 03:55:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 03:55:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360569.589992 (Exim 4.92) (envelope-from ) id 1o8Zet-0006ke-Lm; Tue, 05 Jul 2022 03:55:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360569.589992; Tue, 05 Jul 2022 03:55:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Zet-0006kX-HU; Tue, 05 Jul 2022 03:55:31 +0000 Received: by outflank-mailman (input) for mailman id 360569; Tue, 05 Jul 2022 03:55:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8Zer-0006kR-V8 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 03:55:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80071.outbound.protection.outlook.com [40.107.8.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4dcd3c70-fc16-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 05:55:27 +0200 (CEST) Received: from FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) by AM9PR08MB5908.eurprd08.prod.outlook.com (2603:10a6:20b:283::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Tue, 5 Jul 2022 03:55:15 +0000 Received: from VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:49:cafe::91) by FR0P281CA0059.outlook.office365.com (2603:10a6:d10:49::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.14 via Frontend Transport; Tue, 5 Jul 2022 03:55:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT004.mail.protection.outlook.com (10.152.18.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 03:55:14 +0000 Received: ("Tessian outbound 9336577968ca:v121"); Tue, 05 Jul 2022 03:55:14 +0000 Received: from fadf4f114b18.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 09C9B92A-8659-4A7D-9506-86A1EB6A933D.1; Tue, 05 Jul 2022 03:55:07 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fadf4f114b18.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 03:55:07 +0000 Received: from AS8PR04CA0100.eurprd04.prod.outlook.com (2603:10a6:20b:31e::15) by GV2PR08MB7955.eurprd08.prod.outlook.com (2603:10a6:150:7f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Tue, 5 Jul 2022 03:55:05 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::89) by AS8PR04CA0100.outlook.office365.com (2603:10a6:20b:31e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 03:55:05 +0000 Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 03:55:04 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Tue, 5 Jul 2022 03:55:02 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Tue, 5 Jul 2022 03:55:01 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 5 Jul 2022 03:54:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4dcd3c70-fc16-11ec-a8e4-439420d8e422 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UsWcEnwZP5ccP64KsoSl3RX6y93hYFoXNprOLo2B0VNyAoKiql6acXB4aMOBSBUQa15ptGdnjw7v/nF0UoQu3ZntvT8BBxBPRVWe26g74fLbrQ7iqv6gBvcxCs5chdLcqvLfsDh1luXe9hrPvF9Af0sKfvY+xOBSSoIjAPXgqQmrBt0yv6ReDJQQ2a2kHFs6WCOXwWX5IyPD1F96Vm9pAkFSshEJ5NKQYRRJlcP0Ov6cv+bgZR8ddE6ymGhMPJMXz1hGlbug6AWLO6zvvkAHYC/XagdagQf3HebZytyjx/8hVahas/SaAekoASRSWpKdmnkXI0aB1ZzyyYH7Yjjzsg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VCNgL82vvpvMhUKH+UpBlIWZvx2UQsTDzMawIRgWGXE=; b=ZiDxvrrz5aUCUAhNiCiATlaHeRNiH9virJ/FDF3e2hu43IbvAf5YSBl2A2Mf05RMJSSJTCbLsD6noskGfuThY7yu2BIw0nsHq+dHjKvSE7BDRLFjGo3NJ9SNKx7vBSNTHZjgCOzbKA5dhuqpcwPaeeAexqk2AQwoC7LI6oWHxpymCP9UWIn+SWfCww2U0MkCSy1SZk17Uf1sEwm26s+x5ozP+5UP/1Ffs302qgY4ZGg6QLZVxMiZ6kPLQ/rBLLuiiGwRy8QXUADFwioERfdGrCVX8sw9Dkj2PPeSO2yoNv1hxjev4m6hVhpR8fGCamP/OTeLjwRBt30pytfFQ2Zb+g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VCNgL82vvpvMhUKH+UpBlIWZvx2UQsTDzMawIRgWGXE=; b=tEs+b6m1coqJ3ci3XnmwrizFUcLkAP2GS820mzjXexGukS/ww6wBiypouXXV/3Wbz/nZUj6Bm/NtLwL9k4e/5XS2Eh+swgT4g1IpxbKcOMRGHIL7Wj8ZhzYgYWXybqpHpmi0h7BHPf4Cu//rHgA/DQ2MJWXj9qNCNaR+iK2q7/Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1199e168e6bcea46 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lcmSBiTvoWAIVFcP03wJBY2Gkpf3TpOgsDcwzSQuXK9kA/4KBX5w5TJcgqv0bNpcPbk9qnwaw9EuDAshG3CBIiU3T5kdjUNpcJpDBHldqEzyNAr77teGnM3rq/cjMoEDWzYU0XIEJ/PPSr6GixDXoikYJpQbkYSnNfwjJByoPn9UXfJntfOHJdAYlAksYE1ILKE7CV2XngisfuMQemBT3m1bNdKg+qZLWAm0+jyV/isCJu+OtPYE1vGcYsov55eSHpTAGy1zPgwHstCqdBBtYstt1mIlfUodXWUKVsPpu7qGVepe6U4OrBV3FqMcP6T3JOqrJwmYQyfMdX79R3/ycg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VCNgL82vvpvMhUKH+UpBlIWZvx2UQsTDzMawIRgWGXE=; b=TpsMadVopi1qyMIraZ1S1U+6gJh3ru1ezeB+XpKkEIvUIgdHWrkBvd4apiRig6NjiECkU3ME6iuyM7Rfuh6VVh541uMYooMrpGDRGOL+Z9/Dtb87BeFr+254oDO0H+qZMXRGTWnHT8aV1J0/L/JG8e7rnJhs/4l/ZX8XCw6OTOyNzIpbyxFMTpIRQhcJyo97mzgqJ5w1huDhVemHqi9DtcPptjS/6Q2mY76eFRQyMTyZogfc28fYdpH641hNtWuk9gc+96yq5f9WAdNzt/8tFry/jtJxP7IYkKIWA+DUjuSNkgxK5h8BzWsZcqC0QH4pLF5DgMOOShGBKhz5nwR8pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VCNgL82vvpvMhUKH+UpBlIWZvx2UQsTDzMawIRgWGXE=; b=tEs+b6m1coqJ3ci3XnmwrizFUcLkAP2GS820mzjXexGukS/ww6wBiypouXXV/3Wbz/nZUj6Bm/NtLwL9k4e/5XS2Eh+swgT4g1IpxbKcOMRGHIL7Wj8ZhzYgYWXybqpHpmi0h7BHPf4Cu//rHgA/DQ2MJWXj9qNCNaR+iK2q7/Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building Date: Tue, 5 Jul 2022 11:54:05 +0800 Message-ID: <20220705035405.1283032-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 94c7a73e-c2aa-45c9-e28b-08da5e3a2b06 X-MS-TrafficTypeDiagnostic: GV2PR08MB7955:EE_|VE1EUR03FT004:EE_|AM9PR08MB5908:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CImdu/B4mcBL74VnspvYbFLXIZ36gA+286T2+Nfz/YkL1Ys5ax2z8sJPyNPz5yp0QAHOX/1pjjIjqp5umhFXpnfIzGGUtkcJuazurosnpvoRFc/0zGWWsGyaoBt+cgZdSd/1VXs2fiIOYKHVi+eRVGesPDU1SK3eaHzigBbjFAmnQVQKGL9AiRg3E4R5II7wYj5w5Pl3LJdm9f+Yl3I1gpuSBFqiJ+9q5kJvu2SywO87HVRd6g8pS4dUJfQQiW/CQPHpe1EkMU5lun1T72s8huyM8nlW4yO+1ZqjQXrPPZXzv0w9794KX0KR407cQOO+YffaHKv8MLT3HYCTbGBgSqcEBly6cTzFqJD0IeysHC2sxNHVd8ed35G521gsUKvkk2vinS2Gw3/fWiWMbtBPv1JZBShJ1xj/HxyWj3alZT09tqLLwLQVanc3EtEQqW6k7SVM+3ENRihhVVlXa4oo1nbBkr71YkMi/STQlKFg2u+2GJPzXZEQSG8/ReQXxZACVvptjAxEvu8vt618Pwf5JL6UEEZkYyk+VBOdJJ38tQiTYraXMgh3QCFgFBBoZ0YnFtbQC/5y3Rwe3Ll4cW7uj+M3LWf69QPbfZUDMhlg1nWqioIoaL1eJsD+Ron/iONYfT3S5WvENpGoHasC/7DKgVAoPhdX8XUxHhyB64BoVZ7nrCo7U+a8AVTN6WefZr2Uujz627ZXD7/uaPSOgtJdfLsFvy3BYfzZYvuL1cNk/8JHNC8g7ei1fWqccct+DYTlg2v1PaHkakrVef8njdkARXWK0MBXDl/R9tN+Iyf2UEHm6IUXnY+IFYwaDJxf3iGVBmDXvMKmXr2XumJ6adJJmvzFFKaesPgxTdUFD3VdoPI= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(40470700004)(36840700001)(46966006)(36860700001)(5660300002)(70206006)(4326008)(8676002)(54906003)(40460700003)(70586007)(82310400005)(316002)(86362001)(6916009)(82740400003)(81166007)(26005)(1076003)(2906002)(2616005)(36756003)(41300700001)(6666004)(356005)(478600001)(8936002)(186003)(44832011)(426003)(47076005)(83380400001)(336012)(40480700001)(7696005)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB7955 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 511b4197-87ae-44be-9deb-08da5e3a24f6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oRgwbgkJVBNTjdkdZCncOX012e1ijWOlk47u9c9vdRqFg4wmAOzgqsFhB4aFGejMUkS5lpLwQkrR3kLM+gYDVvJLfNrA0QJhPq7UhORJJM2u1jl/bpBkl3kWOvPJNLFFjdHCOd7GOcrLHRt8MxtIQwfCOsJuAQ7FqnsinsYnkxm95vlFi2ivypCD4+WjfkbK4Xm+RWoJM4GSmffNQBbWVMXS5QfBpoZrd1mU+ic3vJqqq2DvVA3pXFFqzR45UXREcy8/QX15uSbdaFZ3pWDNZAMqoeHepPa7zwqDJA96/AuAoOu5prqEZ78r9PuwYPMXDu5yLEKg+elpC2NyFGpy73xQZo2Ttg95ufpRkqkHfH6hdQ7073VMgtcFcqwnQpqqb9dOhzAYmHeh0R616gDPTZ1skQmV5ftjZ51dW1qsCIa4hwGg35YBq47J/ODejYyuirDuQq+AFLqyF5Z7A83lB07hAiY8vrIEpgPVQVvJ6mmk7K+PaYcc0KmAc/KaRTN+mkfxxQ15ypq1EfJ+7jew4o8pEnyFXbfxM+oCHk75Y4MWPCtwHNNl2GoCumueDqmbuIFoeIjXUgUnYAfM6rRE7mK2QbsZGOcKO1D3UvHL01aeq9Af9i4hJjKeOyA8aWj6jqBKK86V7gM7nHzE29/6Vu+2aMj23IO1cPQJEMH9ylEo2oRZiCJFzhB9eJn0QOAgzuoQV2sdFFCcHvT8J4BbWg4upTAC6rrfcRwGIbtembkO94UNrR4/HxlUilR4Qvt5/3h+B8CLIx6eZiwf31m2upFagm4GxlxZ3KqJGya8Mb4r7lndsIyH11dnk++bc9l1 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966006)(40470700004)(36840700001)(70586007)(316002)(70206006)(54906003)(8676002)(4326008)(36860700001)(81166007)(82310400005)(83380400001)(40460700003)(6916009)(82740400003)(36756003)(426003)(5660300002)(47076005)(40480700001)(8936002)(478600001)(336012)(41300700001)(44832011)(7696005)(2906002)(86362001)(6666004)(1076003)(107886003)(186003)(26005)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 03:55:14.8238 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 94c7a73e-c2aa-45c9-e28b-08da5e3a2b06 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5908 Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar to use short integers (2 bytes) instead of integers (4 bytes). So keep "-fshort-wchar" for Xen EFI code is reasonable. In this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architecutres without EFI enabled to remove above warning. Reported-and-Suggested-by: Jan Beulich Signed-off-by: Wei Chen --- v1 -> v2: 1. Use CONFIG_ARM_EFI to replace CONFIG_ARM_32 to gate "-fno-short-whar". --- xen/arch/arm/efi/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index dffe72e589..bd954a3b2d 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -9,4 +9,7 @@ else # will not be cleaned in "make clean". EFIOBJ-y += stub.o obj-y += stub.o + +$(obj)/stub.o: CFLAGS-y += -fno-short-wchar + endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 05:40:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 05:40:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360621.590020 (Exim 4.92) (envelope-from ) id 1o8bHw-00024V-Se; Tue, 05 Jul 2022 05:39:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360621.590020; Tue, 05 Jul 2022 05:39:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8bHw-00024O-Pq; Tue, 05 Jul 2022 05:39:56 +0000 Received: by outflank-mailman (input) for mailman id 360621; Tue, 05 Jul 2022 05:39:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8bHu-00024E-Ug; Tue, 05 Jul 2022 05:39:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8bHu-0004HW-Sl; Tue, 05 Jul 2022 05:39:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8bHu-0004xR-Hv; Tue, 05 Jul 2022 05:39:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8bHu-00021P-HL; Tue, 05 Jul 2022 05:39:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TH+Y3eCAcj0d55IKrBdnbCpSpY9j6hsjLN8BKc5cF3c=; b=Xi6XhXHoICT40QXIHJHVQZC60S fX2U9xXw66ePS4JJKK7JrUqzmfpIQ8iEWcfrTiyyI6jIWQynQE9ej1VId3hoMDt7Fd+dumILb2uM2 X/e1jyBCOsFbtDJGQZ8XZmXrS6atK8nLcoiyeWkyD/83THEHOwxz2kXKx8XOdlTBUzFc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171495: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c1084b6c5620a743f86947caca66d90f24060f56 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Tue, 05 Jul 2022 05:39:54 +0000 flight 171495 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171495/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux c1084b6c5620a743f86947caca66d90f24060f56 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 16 days Failing since 171280 2022-06-19 15:12:25 Z 15 days 42 attempts Testing same since 171495 2022-07-04 21:41:37 Z 0 days 1 attempts ------------------------------------------------------------ 485 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 19517 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 06:35:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 06:35:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360635.590032 (Exim 4.92) (envelope-from ) id 1o8c9d-0008W5-Vm; Tue, 05 Jul 2022 06:35:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360635.590032; Tue, 05 Jul 2022 06:35:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8c9d-0008Vy-Sz; Tue, 05 Jul 2022 06:35:25 +0000 Received: by outflank-mailman (input) for mailman id 360635; Tue, 05 Jul 2022 06:35:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8c9c-0008Vs-Ja for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 06:35:24 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80053.outbound.protection.outlook.com [40.107.8.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a4e973ca-fc2c-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 08:35:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9383.eurprd04.prod.outlook.com (2603:10a6:20b:4d9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 06:35:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 06:35:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4e973ca-fc2c-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AnYv2f30HsSQvGl2YrCXOo9QGy7ObimnrLAZsJg6s+IbFATTuwf+P5BQTG2i7UJoq0sM5PhTV2hEY3xFnZ9tORByuhDBEqtTWeST+k7/1tyEI47k6O61u2OssU1i5+4RW3uFZx/Ory7vSa+Y5FLEweCyRKXHAdxaGXF1BoWpNh5liioamqIJ/WFF4XZW2/AhK9ZPHyzG+AjVy0VtWU3ows5x5NmgDaRqIar5ey2wJUj8VjsLBTLELpbKFK8pEr0w4zMwjLEmC+LXL6VhWQqkZVD2Zwv1SGO3ewLrdQMoodvUTFNejyVTLOAMVTnc3MwAVoOzoLHT2gr0lD7cl3DXrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1sp8abS3+tsf7nUJ/VYSeltBUMjhNqWJSycmerGV1wc=; b=EGBVv8Q3P6lVM+apHxQemUsjjD1DHC3s4w6u59hfdX4pyeCaL40QKY1SdxUqrSJuzveii6IlQQm6QLpf+nMvKIXjbgWnbjr26cw3Ptegi2czAuuUqSNUsw4y+kQx/Q9vrS8lWxmq2wEw+lSF0x7rovHtAFRxGJNRQk+m+hqtkZX8iS5Gg1OI+3dDB3AJZebmQCNqeX1WduvYflfc2zwTJyEctbsCRp70Qzfn2bV8JDSVflgKM3XHoefLna7PRINny+5RxRX3BcDBny7N26ZKzoDcULwbq66GmzkKkW2etds78c5+lblWyrKLo+b3wZqGdYv9Yg3PlXOBo32biCgRWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1sp8abS3+tsf7nUJ/VYSeltBUMjhNqWJSycmerGV1wc=; b=EPmyLHVUWVSmowN+5C9VJjCMqaszCWto3CUBWwPaQcaAeFGE/J6cdtRIWZDbt44NpoVuqWLhvTFBkIAKrLrByR9aEyo8rg8sn/ZafY9iQmR/hIgue1Joo8gzLlAxLwv4ZJjetvG4GY5fvs+CIThrFjNNuL28K5638bUhb4ouOxUqA/mFoFbXQQvUUMfzTmwD5QSsn8TkqBMDYDj9Z3s9FtuLkJ3i34weTIlFuHkiouK+f+EHGNY734aYn1Orqycf8tfcKHyCO4YxTkYqj1Qvt1uAuUGsOGGULLzIZUO1NEdbmoEVV+v1pnofK/vh4W8rjcTTNpPd1OG9PafT8YZVYw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7843fd16-d2bd-1280-3513-11bc590aa55f@suse.com> Date: Tue, 5 Jul 2022 08:35:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building Content-Language: en-US To: Wei Chen Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705035405.1283032-1-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220705035405.1283032-1-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM7PR03CA0025.eurprd03.prod.outlook.com (2603:10a6:20b:130::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f8b6286-1074-4d20-39e8-08da5e50887e X-MS-TrafficTypeDiagnostic: AS1PR04MB9383:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5SzbEusUXyLlwlSlkAGVPOtRLGaxUvUqG29qUR0gQolXk4y9SBlWyLt/vXTRwjZRRgKsoPeigTGMwPPanY6CTrh/MVy9o2REufp1hvz/IW7rLRYKD6zwMY3jIWBQtCsAGsuDySAmntAMsF11LSdPG6LmE8hWaY64tF2FSbDcR+QFNRJRqbrBrHnImzaIwtAeeBrb6TUPphM3FAnuaGHK56EYQRg3ROBMqNlfMVBU0Jotq9CY/T2KzwPcu5wnNScXGFZ14NM8IybaEI91qUif+0mTfh/VEoP6SxzntaeYcfxzcRsPm5OJsBYy0KvxGsXUOzfIVHoWxnt8cytt7a0u2ogChNi+19OD++D8pOVSqx4vd7mU+ltrj7g8QrajitiWwws5+2EwJYiOTI9T0IHY1GIAJHWDypiQwzwrrvAM2uib8EI1Gc44T5+9K7RSkFU0JYWRj4hb2+FwU5Cs0l52bCtC1LyWPyHY1rtkVaqclJADW6kg0FSTlPvFx/HC1kT2hzXNjsy5xwXTKAr6pvunZuxTkMQRANrMvreWmIM2MlM+GjuxzbkOlQj2v1+6twOVJGK/MX7dUXSZN1mzLqvDXhNFF9CuK8uAeBEFd15UScd/1Tbg1pHwxtwpYHcwbOTUtaSMieaLtsLSCghgVk3WSSNWjdq2Au/G7qS5npkiYSSQELb0c713SIgotqaBXKZZ52N8HG63dCvkPs1dq85gD0E7OwAe81xymkTbc87e+LUsDORTzRA29SyX6MW+Hfh/7bjvQHf9gs6VdCUMmFP4kSDJGBzMDzYYPKri1YXokV4myCb+n9PuTV3jaGe6qEolb2yId/4QM2CuIX12p6t999tnpqcQp3r6HK8jgz/rLXI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(346002)(39860400002)(376002)(136003)(8936002)(6486002)(5660300002)(478600001)(186003)(6506007)(26005)(86362001)(2616005)(53546011)(6512007)(2906002)(31696002)(41300700001)(38100700002)(6916009)(66556008)(4326008)(8676002)(66476007)(66946007)(316002)(36756003)(54906003)(31686004)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z29pYnVLMjcydmkwMllMSzNJM3p0WlBIaCszeCtia2djei9TQUZ6L1ZCVzE3?= =?utf-8?B?eVRsQ3hMcURlREJrNlU1WWswcm9mdG5KMHlLcTB4VkZaMklSREp6eWtkYVll?= =?utf-8?B?QzF0VlRNUjNrbXhWUHVLYnc0VzR0TWZUVEtQT2ZoM0FxMFVoZVlUcUhjZS9V?= =?utf-8?B?ZklwMTdaUVJMc2hQQ0x2Z0UrVDgrZzlYdDFXVWVOTklZNVR5dDRMTWZ3QkJB?= =?utf-8?B?YVlNUE10ZXdVZzNWdk5kSlJ2U2FlU1ZnUnQrTVUvRmtlWTZiNFl3NVB2bTNN?= =?utf-8?B?OXhmTkp1TUcrVjRNdUdnek9tZzY2U0c4Q0hGenJWTkNvbVp4UG9ZMVVPQjRE?= =?utf-8?B?b2RJcUlnU01wZk9CRnlqNnJYams2Znd0Tk5rUmovU3JLYnJQSXV0UERvMjNv?= =?utf-8?B?YmdDMklwMW5RcEV4OFpOMzcvM2Mya0hlOW9aOFo1WWJwQ0c5TEJjeFN3bkRp?= =?utf-8?B?dkQ4YmxlRWlDd2I5SWExWmNjZFBXcFo1aDFWUHVMRGs1bktIejNrVmRhSGxk?= =?utf-8?B?a0pRN3I4YzBETUhpZjhYMEEwNCtHbnV0Vm4wNW55ZzVFNXYxQkI2aUV1aTE3?= =?utf-8?B?ekg3ckpHRzBXVi9uejBZUGNCOHlzMmp6V2kvdEFPVHRTTXMzaFp2RkQ1MTlt?= =?utf-8?B?UExXQnNFMTQ3ajM3K3NmSU1UeFBvN3RYMW9hMG9OZTNXSXZzMDJyViswYnZQ?= =?utf-8?B?blNmN0MzYXFlQWdVWW1GcUJrVmJRd2JQOUNHbUg0ZTA3WDJmakpXZEQxUW1n?= =?utf-8?B?akVUS2FWdC9yYzVaRmttcEZFMkQ5YXZkMUdPWWg5WlFrOG1qOWlLKzNsVlJy?= =?utf-8?B?Y0M2ak9PY1lPSW9EeGhGMjZUdzRvUUdhRzFCQVFCbEJCTVIrZDRCQ01ZbmE4?= =?utf-8?B?YmdwOE9YbjdZTWVPMmx2VkoxSjYzQlJxOWNtMWZnRy9VV3B4NHRlY2hhbUVI?= =?utf-8?B?bDZya1JTQmVHaXpGTWJTdnl4RWZTOGowTnRqTUE5em9sanViOWFJNytWYldG?= =?utf-8?B?UThuOG14LzQ0RXA1cTgrNW5xSXBqT0J6azZWZ2lmL3hvek5rd0NZRk5reUxj?= =?utf-8?B?M2FYUjBCQkZIQXpubW1GZnBBdURjb20rQXNYbkhCZXF6YlBuQzFhV2E1RmJE?= =?utf-8?B?UUtMT2t5cm1RcXJKQ1FNTEhNTkJ2LzBOdTVzVXM0Qnd4b0hCSGVwN0FIbm84?= =?utf-8?B?aDlZaXNUVHZCaitWVDJuZFVtaTRrTFFseGVoY2oyYVg1K1V2b3FtVWJaYVRq?= =?utf-8?B?TDZycXhuckMvOFBveUIzRko0clJaQVgxMkZQYXgrbGNyZ3RsWGNzWkl5MWdE?= =?utf-8?B?ZU1jVnMwR3ZFN2cyMnJPNUxBem5pWWRnUDlzeVVvYUljTHYyeDltVG9uVUVD?= =?utf-8?B?QXZZWnB4QXA0aWdGUGVHUUNHdHpiMzBYa3NnTm5mV1NZTC9IL1Y1bmR1YlY4?= =?utf-8?B?d1BhYS8wWmVicCtEMDFLQ01yd3BmMjY2bitqOFl4eG1vT2Jlb25MREE4ZGp5?= =?utf-8?B?ZXRzOVNKRms2TzNhL1dtcW1ZNGx4YnNORWs4WlRCRUlHOWE0b2MzTmNReTN6?= =?utf-8?B?WGgzMlEwcmx3YXREWjdHbkNkSmRHZE9ZRVdRc1ZTb2JKYlBzblRNemxucTZS?= =?utf-8?B?UmtSaDVlekdUZ2srOHoxaG5QQ2tsRXZMb2p1ZHE2UmhEWUNQTmRNUnMzbXBm?= =?utf-8?B?Y2FDZWpNaEFrWlMwWWVxQUVodSt3VHZiRWJPamZwbmlXbGZteFdLTUtldlM2?= =?utf-8?B?ZlE4NnhHaUxwTTB4YkNNNVB0T3NvRDkwTDJrN2lnNUllVkV4RTZ5bVp0NkpD?= =?utf-8?B?WWNWRC83SjdOL2d6Vm5EREl1bHRKdnFGOXFGTGRBNVQ5dFVtVFVJaUNZNDJU?= =?utf-8?B?eDV0WnlwSjEwOFlaaVNRTEVCQWJWZ0J0ZHMveDZVNTIvS0pOOEdWU3BwQldC?= =?utf-8?B?WnVIc3lTSnRFbC9ZUWJpeTB2eVkvRWpNK2VVNStGOUdPdU1BRVM2NiswR3My?= =?utf-8?B?aTIvcWtpdXJqYkRkZ0ZuOGI2TnEwMTRnTlJHN3JUV29lQ2pLeHpFd2lDcDhH?= =?utf-8?B?Qm1qb1B0T2VrZlYramthVmRORVdES1Q2NGhwNUJNZmZ3M0RsZDVCK0E3TkhK?= =?utf-8?Q?LQ9y3pnOnr7bnJv70EiI9v50Z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f8b6286-1074-4d20-39e8-08da5e50887e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 06:35:20.8121 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HwQ5Eov9rZi5p/eK69xiHoSQ0ukZMMMDb35GpS/8lzqVfXZeXh1EFByRrzbTwv1nt6Ki2NHdc67Lniq20m56Wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9383 On 05.07.2022 05:54, Wei Chen wrote: > Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 > is using stub.c of EFI common code for EFI stub functions. But > "-fshort-wchar" CFLAG will cause a warning when build stub.c > for Arm32: > "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses > 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of > wchar_t values across objects may fail" > > This is because the "-fshort-wchar" flag causes GCC to generate > code that is not binary compatible with code generated without > that flag. Why this warning hasn't been triggered in Arm64 is > because Arm64 does not use wchar type directly in any code for > parameters, variables and return values. And in EFI code, wchar > has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). > CHAR16 has been specified as unsigned short type in typedef, the > "-fshort-wchar" flag will not affect CHAR16. So Arm64 object > files are exactly the same with "-fshort-wchar" and without > "-fshort-wchar". > > We are also not using wchar in Arm32 codes, but Arm32 will embed > ABI information in ".ARM.attributes" section. This section stores > some object file attributes, like ABI version, CPU arch and etc. > And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" > too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", > but for object files without "-fshort-wchar" is 4. Arm32 GCC > ld will check this tag, and throw above warning when it finds > the object files have different Tag_ABI_PCS_wchar_t values. > > As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar > to use short integers (2 bytes) instead of integers (4 bytes). > So keep "-fshort-wchar" for Xen EFI code is reasonable. In this > patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm > architecutres without EFI enabled to remove above warning. > > Reported-and-Suggested-by: Jan Beulich > Signed-off-by: Wei Chen Tested-by: Jan Beulich As to the description: Why the reference to gnu-efi? I don't think it matters how they build their code? All that's important is what we do, I suppose. As to the title: I think the prefix would better be Arm32: (or alike). Hence how about "Arm32: avoid EFI stub wchar_t size linker warning"? Preferably with respective adjustments also: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 07:19:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 07:19:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360642.590042 (Exim 4.92) (envelope-from ) id 1o8cpp-0004qm-CZ; Tue, 05 Jul 2022 07:19:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360642.590042; Tue, 05 Jul 2022 07:19:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8cpp-0004qf-9k; Tue, 05 Jul 2022 07:19:01 +0000 Received: by outflank-mailman (input) for mailman id 360642; Tue, 05 Jul 2022 07:19:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8cpn-0004qZ-OM for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 07:18:59 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80051.outbound.protection.outlook.com [40.107.8.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc420168-fc32-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 09:18:58 +0200 (CEST) Received: from DU2PR04CA0004.eurprd04.prod.outlook.com (2603:10a6:10:3b::9) by DB7PR08MB4217.eurprd08.prod.outlook.com (2603:10a6:10:7d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 07:18:45 +0000 Received: from DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::18) by DU2PR04CA0004.outlook.office365.com (2603:10a6:10:3b::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 07:18:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT003.mail.protection.outlook.com (100.127.142.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 07:18:44 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Tue, 05 Jul 2022 07:18:44 +0000 Received: from ea97584f9880.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5B411B9C-3752-4B29-987D-79A1D208D4C6.1; Tue, 05 Jul 2022 07:18:38 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea97584f9880.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 07:18:38 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM8PR08MB6545.eurprd08.prod.outlook.com (2603:10a6:20b:368::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 07:18:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5395.020; Tue, 5 Jul 2022 07:18:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc420168-fc32-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kTnMV5b2JsZOEm9eZmoHRlV5Vgeq9z+JHYBtZt1thAfjfpoMa4fEhaDYPMCSPx0c1uEXWPnlJwJVcGTWrcY53PETmcGZakcdrE3sCJhD+zEPWy4TAh3fBx3YFMo5X6nKnHFipqnYxuTGULqJ7BvTisP0mw3YUk5NDe/zLVLtmfFqPjgUCgbdiK3uOne+66asC+cYEtRcs1XGXOxwrAdbg8E7HA9gXXXA3Svnjz0a2RmRL4dfwOvw/tco9ckmsM8nuZxxbhleWAuzWXBitJhUro+2aoiPd6wKYnd7xKb6DrHHLNpZ4/Y5ERcaYj62pbt72Zs60j90pidkivz9cMWC+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDJjFgXjCNgRov+ifqVo6lfv2W5RzAhom/91pHD68s0=; b=JQ1HrUOr6pTIHbH+m9+s/grKWRlF2IQRV6XN57oVLzENsvSUISVlGvUlO1fg9RMetv5iHMT037WRKoKLUcipWqzppZOH+gV5GE8Y2xx5hJTd17EgLPtPEA6K6usNUpYyQRcMEgo0yFjOPYmwSpt/l/FJUR0zpf3AgxOEZM6oeGkxPkYtQ0D5jLoLK6/mMbAy5JZDPwwjAnmgkbCF+YyrzNn01koBZ9S/AVveZglllCvbJysQQSUfmVzSrbS5bMDYmGL9tYg6H7EzG3ZREpamagptdU29glFZYNdsvgPdPR91xHiRMdBU3BKfwSzA0M6E29jTaFKLVIWH8Ulhjn2woQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDJjFgXjCNgRov+ifqVo6lfv2W5RzAhom/91pHD68s0=; b=qYBXhzXTGRj+4Ypjul0dLuf6f4gmXdx7WNU3/uPmS+vVhBYu8b91LKIw2c2NDfs2/RknUW3sOfcumUkiRPbdDw1dP7IaMQQMv5Vn0m6gotrAXCFlCQBPUS6T94zH/NGcUeDojLcx+/SdGIa4THe20TDsEGK/wfkNr5FgA7JMksA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVq1xS05cybnPTq3KJpTsoVN5GdCO1/cJd3tL5se2ho9uf8wSnVoMM4R0NwMkvw0zVWoiI9ZudWr4J5HqXfSG9RmjoAp7NTZ6qdA0g7JuW7OEpCJ1ztsRzGb4NC7U7VjRyjc+dvLX4PC3HYU03cZpxYW8Szr4rc4Ji8FHbh/U/oATgWM4FuqnKGwyC7rZNjeIyugdVWyW7GqBaK4/r1jRlwcdxZBpGBfexlt4ARK/mLrO03rPFBa48NV/3re6tP48J3zs7h8aTDC2VmaHkWATvCCntHC4xPEqVQipIa+cilNMQMNuUWLYh64Uf3mqul2P/oA/ZHxKXH3HCXMpl0Rzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gDJjFgXjCNgRov+ifqVo6lfv2W5RzAhom/91pHD68s0=; b=kVbkc89uPqL8KebGwEWRVq5K9RC1uKJNS6l4mF7JZYTaF7Zh20oJ90SfkLROsOqarjDIzHOMptS+QrPjm5HFV0DtTMjSwyHNIBEjhjaz28QWTWIICbnwZGGjWeQxAJkvhznkgYmGKJb3PZlOa6dF/nQRpxuErkuKuJr8KOvH20YMTcavvDGu10KIhf/lA9z3xvkpLc8U8EF+VEZNrQ8yy+8TG5it84cGEIpFEl02mUhp30XhetAem5mTgqnlcGWLnd6waIrbJMtQjfgAgbFD1qRMYGKlszv68JPB9WNJ4ARedBQfdHSxhwD4vjXW0BbKrqrsgJbqFgsS5RkWAqMVBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gDJjFgXjCNgRov+ifqVo6lfv2W5RzAhom/91pHD68s0=; b=qYBXhzXTGRj+4Ypjul0dLuf6f4gmXdx7WNU3/uPmS+vVhBYu8b91LKIw2c2NDfs2/RknUW3sOfcumUkiRPbdDw1dP7IaMQQMv5Vn0m6gotrAXCFlCQBPUS6T94zH/NGcUeDojLcx+/SdGIa4THe20TDsEGK/wfkNr5FgA7JMksA= From: Wei Chen To: Jan Beulich CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building Thread-Topic: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building Thread-Index: AQHYkCMHHHxAMHaD1EyapMXpjUKTca1vUoSAgAAJcVA= Date: Tue, 5 Jul 2022 07:18:35 +0000 Message-ID: References: <20220705035405.1283032-1-wei.chen@arm.com> <7843fd16-d2bd-1280-3513-11bc590aa55f@suse.com> In-Reply-To: <7843fd16-d2bd-1280-3513-11bc590aa55f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 691215BBF66DDD4E9D8273501F8E2606.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d068e84a-1190-47aa-10c4-08da5e5698b4 x-ms-traffictypediagnostic: AM8PR08MB6545:EE_|DBAEUR03FT003:EE_|DB7PR08MB4217:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: M8GHacCelMtp2fB51X1POvFM7x6QJeypw2s8sIY/zpFnGQdsFT57DZOZexDdbnyHHR++8cUtMHjAay/MW3BAn9JEK2fHisyFkikJI/hndW3jCW7DtCQryeyr8jwGAgNxC3Z9cpBFETLq1eStjfgnCtDhgeNfBB2VHPkciXtzuent6K4BN3dPhffju9tgf6EvXqDuAIulnDmIkHb1SycuCDuJBwyWC66Y+tuUA8jWTyVQfOvccOACK7tCt5McyLxf0U1Uf+86EWkjNGrZ+Cg6HK3MSh4s8uf3k5AV7GgjUu9tEgEbvoEMh+U7MlqHXX7V7zSGecY9Lah3JxGGdJVoTC547NKoecdwzbmuFoLtbnEjJbW66kK487ihrgcswZSrkwOJ5dPaZ70Sjhr5HAgZsJUvn1QVArSu68W6Qh/WTfudsxC8a+uC5+E74ibCFqyLqXondSaYT7eeAlLPyJoC9cWSniS4MURQkzU8/q1i9TCgBrPadA3FsRTwhf9VgYEShMEr7EpQG8SZGoV9xLiHBZbYu8k6AqEVsjeNigrDTBkBU4YswMEq02FvSFQvRqTTiL/Z9ScjPF4hGiAtVKtJbG7XxGMObk/tEEIc10P5eRM4mvVe6h52gDPwL8aofOAXn/yJbmGNfUCiiZC6HiwOmcR1xFNlYwl+N4AxLBWBa8gK+wwQ9JECmgIbgk3n7hMhK38LqSMEywdVKoQFfdomkeE9/mxyTsWPyHqZfGfLQYC2EkuYoRbGyJk2Qd5+YxL9D1AWq1YfPgHd/azwPMBMuK75jj9/VsZXMvVf34NcBT8/du9EonNuouuNKmKTz8mZ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(366004)(346002)(396003)(83380400001)(5660300002)(52536014)(71200400001)(76116006)(66946007)(4326008)(8936002)(33656002)(53546011)(6506007)(7696005)(26005)(8676002)(9686003)(41300700001)(478600001)(55016003)(54906003)(316002)(6916009)(38070700005)(64756008)(38100700002)(66556008)(186003)(66446008)(66476007)(122000001)(86362001)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6545 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d877682d-1906-47ee-fc25-08da5e56936e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i3m85EsQtZktoBllG5WClQzV6zc4BUS1FvYoIRuP8HGl4wz/sexU1MJkbk0EFtnG26FEVbw0kG/9ajYyFJHNqYfoP0eO9O/6dYFGWFh1FyF+5FvmJocF/LgA4L9tAgUD0NuWIVpIv6vCBjnABLiQZYo8kiMV87LQH9Mt34n1ZJzr5Eity15u8C3ViJdNrzvV3iMrj8cM46XmgbTZYfxJ8j9LaLGZZ1Mb1J89INi0BUvh0nO89R41BWxAkzSjFSlxc87ZmlA6DpeXawCsG3TI3mWlmrwZXE0pZ4kvTFwL88l9BsiXLxYyDvvmhT40KgSYEhaNyYoX48VK5Nz4p9rrPSRQhjkJmVLj0GgNHA1Ftgl25zxWiet7w5hVkjzFOP9AFZZqw2l6JkxqpSBCBBRrC7YchVskDJv+mWoWY9n6PDc5sSg9j5nkzyRx0ZvoTBVOzZuxq1q057DxAR0eK4OQ//o2WGfdGWllotlUU9O/RK8WEQqUJKu8wLczmy02JzFv+qXfuC0SeW23FQws7Fv0N5d1USorSnMlL74HTlMfLJdNIxWHuzcOo4KtGyClH0KkiO8x1uIUrJaXCUgSwdBdOfQDJBMsywm4vIAo0/du6HwxeoizzyWsGy7MYr1khk7UMVEt4rjxWDNtbmgWJWZzN4yw0Xbj92K1bQB67yQYs8M6/5ObNmB1hl0iRE+lQlyJD0H99C9pnDGWesP6ewbqgloiV8EqJkIVHIyu+/pqeMN/34gI1RSSJrfNSH0NHSCQFYq7Efn6xg3XvMRc0nKwqFb4pHbHTcVssn9c6RQ1+zybUuu2lZmTvOMDiJVfHbNb X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(36840700001)(40470700004)(46966006)(478600001)(47076005)(82740400003)(356005)(81166007)(7696005)(6862004)(6506007)(83380400001)(9686003)(186003)(5660300002)(26005)(53546011)(336012)(8936002)(41300700001)(4326008)(36860700001)(2906002)(316002)(82310400005)(52536014)(55016003)(86362001)(70206006)(40480700001)(54906003)(70586007)(8676002)(33656002)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 07:18:44.8482 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d068e84a-1190-47aa-10c4-08da5e5698b4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB4217 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIg15pelIDE0OjM1DQo+ IFRvOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gQ2M6IFN0ZWZhbm8gU3RhYmVsbGlu aSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1bGllbiBHcmFsbA0KPiA8anVsaWVuQHhlbi5v cmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFybS5jb20+OyBWb2xvZHlt eXINCj4gQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+OyB4ZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2Ml0gWGVuOiBmaXggRUZJ IHN0dWIgd2NoYXJfdCBzaXplIHdhcm5pbmcgb2YgYXJtMzINCj4gYnVpbGRpbmcNCj4gDQo+IE9u IDA1LjA3LjIwMjIgMDU6NTQsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IFhlbiB1c2VzICItZnNob3J0 LXdjaGFyIiBpbiBDRkxBR1MgZm9yIEVGSSBjb21tb24gY29kZS4gQXJtMzINCj4gPiBpcyB1c2lu ZyBzdHViLmMgb2YgRUZJIGNvbW1vbiBjb2RlIGZvciBFRkkgc3R1YiBmdW5jdGlvbnMuIEJ1dA0K PiA+ICItZnNob3J0LXdjaGFyIiBDRkxBRyB3aWxsIGNhdXNlIGEgd2FybmluZyB3aGVuIGJ1aWxk IHN0dWIuYw0KPiA+IGZvciBBcm0zMjoNCj4gPiAiYXJtLWxpbnV4LWdudWVhYmloZi1sZDogd2Fy bmluZzogYXJjaC9hcm0vZWZpL2J1aWx0X2luLm8gdXNlcw0KPiA+IDItYnl0ZSB3Y2hhcl90IHll dCB0aGUgb3V0cHV0IGlzIHRvIHVzZSA0LWJ5dGUgd2NoYXJfdDsgdXNlIG9mDQo+ID4gd2NoYXJf dCB2YWx1ZXMgYWNyb3NzIG9iamVjdHMgbWF5IGZhaWwiDQo+ID4NCj4gPiBUaGlzIGlzIGJlY2F1 c2UgdGhlICItZnNob3J0LXdjaGFyIiBmbGFnIGNhdXNlcyBHQ0MgdG8gZ2VuZXJhdGUNCj4gPiBj b2RlIHRoYXQgaXMgbm90IGJpbmFyeSBjb21wYXRpYmxlIHdpdGggY29kZSBnZW5lcmF0ZWQgd2l0 aG91dA0KPiA+IHRoYXQgZmxhZy4gV2h5IHRoaXMgd2FybmluZyBoYXNuJ3QgYmVlbiB0cmlnZ2Vy ZWQgaW4gQXJtNjQgaXMNCj4gPiBiZWNhdXNlIEFybTY0IGRvZXMgbm90IHVzZSB3Y2hhciB0eXBl IGRpcmVjdGx5IGluIGFueSBjb2RlIGZvcg0KPiA+IHBhcmFtZXRlcnMsIHZhcmlhYmxlcyBhbmQg cmV0dXJuIHZhbHVlcy4gQW5kIGluIEVGSSBjb2RlLCB3Y2hhcg0KPiA+IGhhcyBiZWVuIHJlcGxh Y2VkIGJ5IENIQVIxNiAodGhlIFVFRkkgImFic3RyYWN0aW9uIiBvZiB3Y2hhcl90KS4NCj4gPiBD SEFSMTYgaGFzIGJlZW4gc3BlY2lmaWVkIGFzIHVuc2lnbmVkIHNob3J0IHR5cGUgaW4gdHlwZWRl ZiwgdGhlDQo+ID4gIi1mc2hvcnQtd2NoYXIiIGZsYWcgd2lsbCBub3QgYWZmZWN0IENIQVIxNi4g U28gQXJtNjQgb2JqZWN0DQo+ID4gZmlsZXMgYXJlIGV4YWN0bHkgdGhlIHNhbWUgd2l0aCAiLWZz aG9ydC13Y2hhciIgYW5kIHdpdGhvdXQNCj4gPiAiLWZzaG9ydC13Y2hhciIuDQo+ID4NCj4gPiBX ZSBhcmUgYWxzbyBub3QgdXNpbmcgd2NoYXIgaW4gQXJtMzIgY29kZXMsIGJ1dCBBcm0zMiB3aWxs IGVtYmVkDQo+ID4gQUJJIGluZm9ybWF0aW9uIGluICIuQVJNLmF0dHJpYnV0ZXMiIHNlY3Rpb24u IFRoaXMgc2VjdGlvbiBzdG9yZXMNCj4gPiBzb21lIG9iamVjdCBmaWxlIGF0dHJpYnV0ZXMsIGxp a2UgQUJJIHZlcnNpb24sIENQVSBhcmNoIGFuZCBldGMuDQo+ID4gQW5kIHdjaGFyIHNpemUgaXMg ZGVzY3JpYmVkIGluIHRoaXMgc2VjdGlvbiBieSAiVGFnX0FCSV9QQ1Nfd2NoYXJfdCINCj4gPiB0 b28uIFRhZ19BQklfUENTX3djaGFyX3QgaXMgMiBmb3Igb2JqZWN0IGZpbGVzIHdpdGggIi1mc2hv cnQtd2NoYXIiLA0KPiA+IGJ1dCBmb3Igb2JqZWN0IGZpbGVzIHdpdGhvdXQgIi1mc2hvcnQtd2No YXIiIGlzIDQuIEFybTMyIEdDQw0KPiA+IGxkIHdpbGwgY2hlY2sgdGhpcyB0YWcsIGFuZCB0aHJv dyBhYm92ZSB3YXJuaW5nIHdoZW4gaXQgZmluZHMNCj4gPiB0aGUgb2JqZWN0IGZpbGVzIGhhdmUg ZGlmZmVyZW50IFRhZ19BQklfUENTX3djaGFyX3QgdmFsdWVzLg0KPiA+DQo+ID4gQXMgZ251LWVm aS0zLjAgdXNlIHRoZSBHQ0Mgb3B0aW9uICItZnNob3J0LXdjaGFyIiB0byBmb3JjZSB3Y2hhcg0K PiA+IHRvIHVzZSBzaG9ydCBpbnRlZ2VycyAoMiBieXRlcykgaW5zdGVhZCBvZiBpbnRlZ2VycyAo NCBieXRlcykuDQo+ID4gU28ga2VlcCAiLWZzaG9ydC13Y2hhciIgZm9yIFhlbiBFRkkgY29kZSBp cyByZWFzb25hYmxlLiBJbiB0aGlzDQo+ID4gcGF0Y2gsIHdlIGFkZCAiLWZuby1zaG9ydC13Y2hh ciIgdG8gb3ZlcnJpZGUgIi1mc2hvcnQtd2NoYXIiIGZvciBBcm0NCj4gPiBhcmNoaXRlY3V0cmVz IHdpdGhvdXQgRUZJIGVuYWJsZWQgdG8gcmVtb3ZlIGFib3ZlIHdhcm5pbmcuDQo+ID4NCj4gPiBS ZXBvcnRlZC1hbmQtU3VnZ2VzdGVkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ DQo+ID4gU2lnbmVkLW9mZi1ieTogV2VpIENoZW4gPHdlaS5jaGVuQGFybS5jb20+DQo+IA0KPiBU ZXN0ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQoNClRoYW5rcyBm b3IgdGVzdGluZyENCg0KPiBBcyB0byB0aGUgZGVzY3JpcHRpb246IFdoeSB0aGUgcmVmZXJlbmNl IHRvIGdudS1lZmk/IEkgZG9uJ3QgdGhpbmsNCj4gaXQgbWF0dGVycyBob3cgdGhleSBidWlsZCB0 aGVpciBjb2RlPyBBbGwgdGhhdCdzIGltcG9ydGFudCBpcyB3aGF0DQo+IHdlIGRvLCBJIHN1cHBv c2UuDQo+IA0KDQpIb3cgYWJvdXQ6DQoiWGVuIG5lZWQgdG8ga2VlcCAiLWZzaG9ydC13Y2hhciIg aW4gRUZJIGNvZGUgdG8gZm9yY2Ugd2NoYXIgdG8gdXNlDQpzaG9ydCBpbnRlZ2VycyAoMiBieXRl cykgaW5zdGVhZCBvZiBpbnRlZ2VycyAoNCBieXRlcyksIGJ1dCB0aGlzIGlzDQp1bm5lY2Vzc2Fy eSBmb3IgY29kZSBvdXQgb2YgRUZJLiBTbyBpbiB0aGlzIHBhdGNoLCB3ZSBhZGQNCiItZm5vLXNo b3J0LXdjaGFyIiB0byBvdmVycmlkZSAiLWZzaG9ydC13Y2hhciIgZm9yIEFybSBhcmNoaXRlY3R1 cmVzDQp3aXRob3V0IEVGSSBlbmFibGVkIHRvIHJlbW92ZSBhYm92ZSB3YXJuaW5nLiINCg0KDQo+ IEFzIHRvIHRoZSB0aXRsZTogSSB0aGluayB0aGUgcHJlZml4IHdvdWxkIGJldHRlciBiZSBBcm0z MjogKG9yDQo+IGFsaWtlKS4gSGVuY2UgaG93IGFib3V0ICJBcm0zMjogYXZvaWQgRUZJIHN0dWIg d2NoYXJfdCBzaXplIGxpbmtlcg0KPiB3YXJuaW5nIj8NCj4gDQoNCkkgd291bGQgc2VuZCBhIG5l dyB2ZXJzaW9uIHRvIGFkanVzdCB0aGUgdGl0bGUgYW5kIGFib3ZlIGRlc2NyaXB0aW9uLg0KDQpU aGFua3MsDQpXZWkgQ2hlbg0KDQoNCj4gUHJlZmVyYWJseSB3aXRoIHJlc3BlY3RpdmUgYWRqdXN0 bWVudHMgYWxzbzoNCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 05 07:29:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 07:29:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360648.590054 (Exim 4.92) (envelope-from ) id 1o8d03-0006PO-EK; Tue, 05 Jul 2022 07:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360648.590054; Tue, 05 Jul 2022 07:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8d03-0006PH-9p; Tue, 05 Jul 2022 07:29:35 +0000 Received: by outflank-mailman (input) for mailman id 360648; Tue, 05 Jul 2022 07:29:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8d01-0006PA-MY for xen-devel@lists.xen.org; Tue, 05 Jul 2022 07:29:33 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130051.outbound.protection.outlook.com [40.107.13.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 356fa8a0-fc34-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 09:29:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5246.eurprd04.prod.outlook.com (2603:10a6:803:54::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 07:29:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 07:29:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 356fa8a0-fc34-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=leEMcL0XT1ZPgK6S3XI4yiPoY5JyhG5k9nz3KFPkHVSrfgDbeGrfiEs0i5gr9PuK+dGgFGPQPVB8dSE1Q8eQ2SbfPAOaiWhztLU/aWiE2G952u+AU4vYbUi+vgyOMjXFLegDTpjVll3ef4O6K2p5AaxxwG4DHQOuZDbR94h97tYZPSILx903SHLe9Cs+eJoC1/iyLJK5zE1M56WIzr1qcAi483AnBFzKm7zXeIPWMbIrfu9BKfSwFEtmjNU/bUal8mf65/+Nf1ie0xgAk4wiKF01n5tvqFeG89ct4F4HxyaUZTEsyHKMYJzwv4bc7hnNLdM6hwViqrslmTpEypB2Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tNIMALRHMc7bizFWTZt8Vg53ubMkfnRJd1oc1rp5DME=; b=MDJxKP1qIhEx0w0h2hyZtH/Q+lxWQI/7E9zjYgrYNuz+wHhEffYDxOGGjX4ccmynUskqtW9TspGWhXa9FWkS3vIosrhqOcaaZSLhrMeO6BdKy4gPVea7ED19Px+7cG+CpTi3/DVq6MFcT8VxZ48Of6dG6uPXSmXK41UVsnQcEEDxylYpFmErSINCFVlw9O8G+W46M+YytvN8LUd/cBAQY7e0tiFIUyqERPWrFnqyxMpkL2GKayZwN7jNNlNyhhOoxgOo5Snwz9qZLshaju99BUnDJY8rGfh6KCRNxjEBnU9LrUv77bM2VX2rjk8eCHv1/+jj0SXUItuyrGHlLnKqRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tNIMALRHMc7bizFWTZt8Vg53ubMkfnRJd1oc1rp5DME=; b=PKibV6XCCQ1DdUJp252J7MF6g1W12HbgBhee3JZ0lS4nxkSU2V0uiRcLkjaFENfwdL67cldN8caqJQ7dt2hn+u/EhxAvPxtxZWuiFcShoMAnfktbwnumbhO3UL8wc3r4gkSVOTlQOCywVrvQzz6RidSrbAwiR2FMxQT1n2rdEEO8OTSvtGkDZQqqmUunHcmbhTeOy1Z5RPIsnfIHkBpwKmP69/26GACR0nwjBkgw9PlEM4huPt4mylS45OUApnj6EtImltSCJLWk5um4aXmHY2ohfFYMEL5w/HwliSnKBK7jhb04M5SHjZJUdOgHc9XTo+zfhR4G5iObeP7ur3FHSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 09:29:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0730.eurprd06.prod.outlook.com (2603:10a6:20b:487::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2bad96f-211c-4b1d-4b0e-08da5e581830 X-MS-TrafficTypeDiagnostic: VI1PR04MB5246:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eOUZINcLGm8cBq1xvBXN1tuELtIbYG7sAorzq/kcRUd/vQZCLWS7nFhUjwlJzKT7RyhwaOe+E/fGsGg0HIhovWuQL5WFJlUMNgTUbmT6pFLY6XPJPAyHUM3q0UR0qEgwuEaOT+X0wJxAPGotlxPqv2KxkHrqA4sqk4Rtx/qjhp9hD+wefsbf7jnXql+7sbh7MQxnO3iVR9JnBCfnHs8SkD37AKALvbl8VZ6BzKZHQ29DP0HgWxbiP3g4Mkrv5/uRXb1UROCaGevcglmLgQJ0GN1ALP13yTOz9jYbqiTmRRH5H5wRZffNowISdczmvfp/DYBRa/IM+WJ5kjrXtCTldjPrV0bWPIbdscoIMISx6wmcgWdFwksuaxPX2OQBNH7+auL7yQKYwrbIdCNegUOXPJRSB/J+Q/F9EBIxw0tw1EJOUdIZxtbNa2rKwCCPCs7lFpGaTcd8E/czVbvSyNHGDAniJueTWk2JgcLCbdwZMWKWpvw6TNxsql98UpPD0i9Lvm3hntyb/K0t8coNNq1MfRWIl13gi41w4K6YwOyT9ccA5/2SKDthM+Ml6RlVwvsVk9AjrdX484qz/TXLQuSHIqAzrukP32t5JSs8hW8nbBzSwrC9d4S/GKlHjF+Xg7P/H5jJ+rmbpUkQ18Zog1XTDADZ1uSKEkcLmI9gCdXG820fsGWLdO+k7VaHboWTHdvu89SDu9i4fu4yrTraXi+zL/gpV8Z3MKU/oiGkQtx2z6hdOtlY1BcHUaA5DJmTcXnBok2CMHFWCbAFcOAmM7iFwFZm7jR4/KqhNkJGWZnwEfIqOqmnwgbz33t2AyqrQDnli1EnnJfLcjgEcCu3Py7xiA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(136003)(376002)(366004)(186003)(66476007)(6486002)(83380400001)(4326008)(6916009)(8676002)(66556008)(66946007)(54906003)(2616005)(6512007)(31686004)(36756003)(26005)(53546011)(6506007)(38100700002)(86362001)(31696002)(2906002)(41300700001)(5660300002)(316002)(8936002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bkplWTlaMXdob1J4ZEhNUVRxRUl6RUlGRGEyNUtrT2p2Q1ZHNVp4YXc1emty?= =?utf-8?B?WFh0L3R2U1d1TGFWcDhXMk9oNCtJaXBqZ1JtejRQeEh3VFF2VzlTVGFvMmhW?= =?utf-8?B?dkV5bnR0TTRHb2YwaHB5RVFHTU5LQVlLMGs2YmVOaDJ4WkZwbzlRTm5NL1I1?= =?utf-8?B?R0o2NUpuTUZDSjhIVVlFRlgzeUp5Yy8ySStnUlV5YmoyM1NERW9hT1Q4cUNS?= =?utf-8?B?bDVqVmFvUFdZQ011Q2kvcnNSTGJyV3BLbnBmQ1NpVGVnU1ZLMlNJcHNkRjhQ?= =?utf-8?B?ZjRTMFEwQTJOdjM0bTFuemYrdW1sTHZNcmc0Mm90OUJXNW1lRGRtUXZnU2N6?= =?utf-8?B?b1BEY202Z3docHJ2b3E4R1pnL3J5OXZWM3d0ZEFrOTZqT29OUUlDRVhicmtn?= =?utf-8?B?ZXMxc0dSdnQ4bExScDVVckQ4TmZPWVRBQVRrRUVSZG9HS28vUitIekw3NW9k?= =?utf-8?B?SkpVMnAwdmdxLzFUU2ZGdEVYVU9kMHJJQU44dkV4SE5ucUlYcUcxV09zUDRN?= =?utf-8?B?U2xLdTB6Y0ZVQUZqdW1iZWlZN3Zwb0ZMaFZ6Q1FySUJLTWlGVGs5alJBNmpv?= =?utf-8?B?SnFwN01HYTRQNWs0Szk0RGVXVGV4VGJ3SmRiM1BIalZORVN0V25XU1NUemFJ?= =?utf-8?B?RGFjZXBLUkFTZWxobktUUEVDUXBYS3NVZ01Fb2IzazFXN3M1N3ZHRVJIWnBW?= =?utf-8?B?NFFqVi9ETm0yZGxSQ2pDV3c5di9lNS8vZ1lOaFAzMFA2MHdKNUFqYjF6L3F1?= =?utf-8?B?aTRTTzlabDRoTjZQWHZoTFFqdzc3T0xJVkJZbDNMOVQ3Mzg0TDVrR1V5eGhV?= =?utf-8?B?THhKanh0UlB3U3ZUK1pRblp5dUk4dU9NL2piM0FzN0xlNE9QaFoxSlVkSTB3?= =?utf-8?B?bjVCbVJtNTJEREFIKy9UUXJqNjdYa0pjV1hiWUgzYVhLd0JCdzlzaFBkMGho?= =?utf-8?B?NUdYWENNYnBQRFYwc1RBeVBscE8xSlJCcExjL3ptbjJVSWhxWUh0Z1RnMlBz?= =?utf-8?B?b1lsck8xMHN3TlVleHBrOWhNRS9RTUtNQXBub1JXL0p6SHVXYi9mUG5IVytt?= =?utf-8?B?c1UyL2JMYng5YzNzcGdQaXlScHRyTDJ5ZW51azRMZTE5ZDdZdTBra3N4Qkl5?= =?utf-8?B?WUFweUZzNVZWNW9IallBMHovVEp2VGlrZUxWZEpsNmtPbStqenBhNkdtemtB?= =?utf-8?B?ZmxnM015QlphZHhJb3FOOXBINUQyb1dPbGxGMUtUWHVJMzg0aXhwMVlVZXZP?= =?utf-8?B?N09HMWlwNk5Zbnl3QVdhVkE2dnlma09iK0grbTdHZ1hoWFB0cGJXalM0U3l4?= =?utf-8?B?MzZ3UEFaNlVReXVZYWtpUkgzU3VINDZNS3drcHkvZnRhVEZ1aXJyRFJmRDFh?= =?utf-8?B?U204TVc3V0RTSFpjdzVqa0lGSXBPYzRFVFRPVWtxU05rL3B0ZDFnVGxtMy9p?= =?utf-8?B?ejM4WVh3cCt3aEVRUTdEVnhxajllSjJYZ3c3VUM3clUrM0VjNkp3R1puaVdL?= =?utf-8?B?WXJvaHNmZERqQmdBNHBvcFd4Q0RiK1I4RXAyd1ZxUkdidjMyaXJjWGtHYnhq?= =?utf-8?B?Rmt2Wm4zUGZUbkNRalcwUFFtZExJeXZ2aWZSUmlhV0hRcWZUcDZxT2NVYWNy?= =?utf-8?B?SVkrdHBBT3N1VXRmQW85d2ZIazNudWl5S1NrTGZKOFk3RVFWQlNya3BnU0lV?= =?utf-8?B?ZHFFM3B3OWZjblg2WWNqSFFyZ2tMUzBPVXp5UUJEbkpVQ0JieVlkZ3FVMklD?= =?utf-8?B?clFrWE95ay9VRjBsU0RvTkJEbDd3YU5OWGdRc29qR1duekJSU29aVDNwMjd1?= =?utf-8?B?YXBLYk1hOTMwRDgzdlQvSzlMODBydXhFVVhDb3JHd1pwc0FrVDFnTllDODlo?= =?utf-8?B?dStuY2tQZlhlZkUrSHNCLzh3ZElMQ0tMb1lsUUNoVURxaHRhQUtoWVdjN1A5?= =?utf-8?B?NjlZS1hGY0oxQ0tYUmRuSHZsVnp5UzQ3RlNLTkpWejJnNDhnRE9Bc2VOek9L?= =?utf-8?B?Z2t2MW5yZlJNWEFBdjU1V1ZrMk5IZ0Rma0pMMDFsVmdUL3g1Y2lnUmZkRGJF?= =?utf-8?B?d0s1YlhVYnZTNGlFaVVrVEsrUlhMUTl2RksxVVdUNXVadFBpNTNNSUt0MlRz?= =?utf-8?Q?lE7rjB59tDfyEZhDXSU0Ks07V?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2bad96f-211c-4b1d-4b0e-08da5e581830 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 07:29:28.4484 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cHXXicpXU9IUpOV7uCVUrQYK4rghompT+GM9VzZ3x6+2ZnxeFR6iBThdeFiRfJnRZtf2obJc8r6QU0WiGarAPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5246 On 04.07.2022 18:31, G.R. wrote: > On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné wrote: >> >> On Mon, Jul 04, 2022 at 11:37:13PM +0800, G.R. wrote: >>> On Mon, Jul 4, 2022 at 11:15 PM G.R. wrote: >>>> >>>> On Mon, Jul 4, 2022 at 10:51 PM G.R. wrote: >>>>> >>>>> On Mon, Jul 4, 2022 at 9:09 PM Roger Pau Monné wrote: >>>>>> Can you paste the lspci -vvv output for any other device you are also >>>>>> passing through to this guest? >>>>>> >>>> >>>> As reminded by this request, I tried to assign this nvme device to >>>> another FreeBSD12 domU. >>> Just to clarify, this time this NVME SSD is the only device I passed to this VM. >>> >>>> This time it does not fail at the VM setup stage, but the device is >>>> still not usable at the domU. >>>> The nvmecontrol command is not able to talk to the device at all: >>>> nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 >>>> nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 >>>> nvme0: IDENTIFY (06) sqid:0 cid:0 nsid:0 cdw10:00000001 cdw11:00000000 >>>> nvme0: ABORTED - BY REQUEST (00/07) sqid:0 cid:0 cdw0:0 >>>> >>>> The QEMU log says the following: >>>> 00:05.0] Write-back to unknown field 0x09 (partially) inhibited (0x00) >>>> [00:05.0] If the device doesn't work, try enabling permissive mode >>>> [00:05.0] (unsafe) and if it helps report the problem to xen-devel >>>> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) >>> >>> I retried with the following: >>> pci=['05:00.0,permissive=1,msitranslate=1'] >>> Those extra options suppressed some error logging, but still didn't >>> make the device usable to the domU. >>> The nvmecontrol command still get ABORTED result from the kernel... >>> >>> The only thing remained in the QEMU file is this one: >>> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) >> >> Hm it seems like Xen doesn't find the position of the MSI-X table >> correctly, given there's only one error path from msi.c returning >> -ENODATA (61). >> >> Are there errors from pciback when this happens? I would expect the >> call to pci_prepare_msix() from pciback to fail and thus also report >> some error? >> >> I think it's likely I will have to provide an additional debug patch >> to Xen, maybe Jan has an idea of what could be going on. >> > pciback reports the same MSI-x related error. > But even with DEBUG enabled, I didn't see more context reported. > Please find details from the attachment. And nothing pertinent in "xl dmesg"? Looking back through the thread I couldn't spot a complete hypervisor log (i.e. from boot to assignment attempt). An issue with MSI-X table determination, as Roger suspects, would typically be associated with a prominent warning emitted to the log. But there are also further possible sources of -ENXIO, which would go silently. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 07:32:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 07:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360654.590064 (Exim 4.92) (envelope-from ) id 1o8d3K-0008C1-0j; Tue, 05 Jul 2022 07:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360654.590064; Tue, 05 Jul 2022 07:32:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8d3J-0008Bu-U0; Tue, 05 Jul 2022 07:32:57 +0000 Received: by outflank-mailman (input) for mailman id 360654; Tue, 05 Jul 2022 07:32:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8d3I-0008Bm-Ti for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 07:32:56 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70087.outbound.protection.outlook.com [40.107.7.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af8e7f63-fc34-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 09:32:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5246.eurprd04.prod.outlook.com (2603:10a6:803:54::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 07:32:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 07:32:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af8e7f63-fc34-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXfwPpP6AH9YNWmXt86IDfdaw0ykG9fJOyvaVxMIjuFRwRQq2BnCNOzsRWEEF/4sSNQC51aE7GN67iS6HnYqZkIbzH4O0gkSPL/0nIiSOHtbS5DL+WasH7DtofC5HuQzq6dgopMhdTsTOFTUsV1ciDxY6xFjJzSceKr5xl0i7AtdnLjWTbKFAgVAOZOy2bdShbD9IE8XXZn+mjmmCrBSs+xc/C03mUGQERX1Q6OLqEFa3ZZvYpKMUIZNM63/WF4vNDXCmVePPo2+RnYLcJkSHWw98w8XdPio7Toj20x/WKtC25bXPmPWUzXlJqwoUtacgLjAMEFOrEy6Qs9eUQ8EyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OluX7aEOrjo8Q8v0QVnoNB3RdsHYRnvbmTSYSEY2ex8=; b=W8o2c0FW7UIR9yK3PB5ttqw4TlABy4GTjgrMk+i9NUnktGO7fjKYQdx9nlnYGUcGfJd4mPfZno7u3k2/2s3niG4wYgtgLW5TFQ6Nhjcqm5kTJ/oveFIPKFCcbMDWJASyaMymGnPJqjo1JamZ/mtpa3uhi18CvX+ZmXmlp7Zb/DaE4eKJoNmlzqVT3dP5PPbsR1qaWOiGiNFip4kDE2z8yiwG9N0HVHItRyBW0c2FGbgks96qwgFxQgd64ZU0kneWxm3snBfE2LVm8rSKCb3QNL/BhIt+ZyqzlAP40IPjoKCidmSOPRFEjMLmk6nJYwK8C5tyzI47am67bgmjguympw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OluX7aEOrjo8Q8v0QVnoNB3RdsHYRnvbmTSYSEY2ex8=; b=GPDzwwDOu8RovXReBZqz5/5vltkOo0hvr5k8bbS0aeJdDlUsQqp+mXSSRQ4c8VfT2ulnrtLZkhzm6tQ2fjTV2stjezjU+MGoQPiB1GAnEcQYKrpILlTFWYBhl/YUqwjM8dKSmlxMv7+rmZhPF69QwxPN9qaq2JoULSsOBMRE6nx0ErYKgOqSSzAKkPG5rbZtsbrrdUWWicZW9lOtK+7SU1TSYyczcxuhzw/xCyyO+vOLxy21m0pjkBxuZ2RtouIVdqMuGV6AZPoUTdxXMXE5UkvhznVVsx0HBvYDPsajhjHZcVzOkLCkFo/ZLDx37mQCR7I9ZK5/peRku24H/LnIMA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <480ec801-d5b2-37bf-9e84-456770b591b3@suse.com> Date: Tue, 5 Jul 2022 09:32:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building Content-Language: en-US To: Wei Chen Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220705035405.1283032-1-wei.chen@arm.com> <7843fd16-d2bd-1280-3513-11bc590aa55f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR2P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e50ad12d-b1fc-44d9-a565-08da5e5892a8 X-MS-TrafficTypeDiagnostic: VI1PR04MB5246:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5I9ZEnR4NioqR/kCwgymM44D70KacO0e/OAwFKTdrpZ4bOUJYwSXWDBo1RWtW8Vgh/UHnqCNjwXcuOXNSyim+0FNodgf7MGCYUeIC9PPWkCbD9DMwY5DYAwv0oko4tcr0xd+N6KkszBUDRCep4VYPktxWOzo9pgq5ku54/gi2rIlFM96qZWgDXAKUtPoPnLHrUbAUiMhpmnKRI5inigCIQd0FRMMI+B4TO8iCm4E8R7T99iN1VJsMy/breHm6KKl1p43mbzaZmZxJyU9wXhKeXLPKt1rryVKiuRBqKiGHfApOeNMe5MRZQpez28hkE2pvwf3Zge1k5bc7B5fN6ECZm62ME5NMX4hzNJVYpzQjg4X17imsrCJwKDTUO8g3W+pZ3N6fEUmvNeprFqgw/cbHjhK1sIag5toQf8up9eJvAu1Sd+9UpsCB2rN3XiKLEJWZT0bqbhBfAWvMdaPbfRIgKKlUzveLmHSsPfWAsupdhK/jtUDWjdt+o2Z+M42riQBRrLLs9evAcyG+rqNoc2mHXq6goohxS45kKUDvaCUJRom1IXIJ0ppPDBhJq19jTk4FJ08X6XPGz+M8p//h9oF7Q1V7GrMgC8SVwe+Oyv3VQ4hxxP0aALu2KP4N/wShyWF9ow0WkQWdIkLq46AgX02QGuEJTnwENFWLWNmmJ+GIlw6v4fvBqqBGzOQQcrqfv/cReoidSLZ/tUaUzX4emwlZhz4mCzQsSq9Y8SVERYLEDvMbhPLdZe235joT4o2+bOMQUy4kw2E2tT6OtSOP3MGSz5FO+/O0osONzsqPHkJ/HjJc5PDhmuJvFDWg8v4KiDwHjyw2lMiBma45ueUs9KOnZYzXZqXycDgJUWtQEtKtGs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(136003)(376002)(366004)(186003)(66476007)(6486002)(83380400001)(4326008)(8676002)(66556008)(66946007)(54906003)(2616005)(6512007)(31686004)(36756003)(26005)(53546011)(6506007)(38100700002)(86362001)(31696002)(2906002)(41300700001)(5660300002)(316002)(8936002)(6862004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTREbGdTaU84amdNV3dyMlY1cEI4bmVxUWJvNWsyQzdJVkZhb2JRTHB3Yzdy?= =?utf-8?B?eHVpODdTWEFBZE5pZHJHK0RsYzR5bVpod3FaVXl5UVRXb1V3SGpTaVV1RWxk?= =?utf-8?B?UkdQL2RIUUk5ZU5BOWZTUlp1YUd0M0RKbmJ3dTN6TGVkZjlBL0pjK1FTbkNT?= =?utf-8?B?ZE4zRWpUQUlJUzdaSFFrZlhPUVYwWjRIY00wZldLWmhRQ2FKbVM2ZGYrT1JC?= =?utf-8?B?d0hiMjFaRXUzT2svZDJpaFFONXhoM3JZby9KTUhYTUNkV2hhSnRFTld0aERy?= =?utf-8?B?cHZUbUV0U1F5Q2xmRmV2NnljTkFCWWRBdUIzRDZJOTlxc2FOV0M4NThoRWFQ?= =?utf-8?B?Yy8vZENtU3ZzRkh6NSs3UEV6T0FTeHFJa3pCelI1NzdBTVR4eXJoT09XK1Q3?= =?utf-8?B?d3BEb1Y4TmZvN2l1Mm1GSUY5a1dxNlVpMTBLdGpSZzZhdkwvVEpYM1pMTzJG?= =?utf-8?B?c3NRRHRuR0tySWY4cVQ3Wi81VTRqSXp2Zzl0RUdnZi9WKyt0TUVQNDZuRGxa?= =?utf-8?B?SnB5b2hoRmgxYXpFdEFUOTZUaXl3YmdPZCtJbDlmaENQTytHNDBDQ01lblZn?= =?utf-8?B?YnFDK1BlaUFZMzFJOXdHUlJiTER3QjY4K1lIb29ZUno4NE5TMXBGRTU0MG54?= =?utf-8?B?eUdjMGF1REpoTGQ1MFpESGluQUE2WjNPd0hUYURyMFFVc1QxcnBxTE55SUxh?= =?utf-8?B?STVnS3Z6TmdlSGRmY3NBeFRKR3dPOUJLV1NOandEdGROQzBueW5KUkVUeWhq?= =?utf-8?B?VTV1aFk5Z1ZJcXdDdmdzeFlpcFlwRHE4cmR6SlZGc2hLMTV1TjdOZ3MzNmVV?= =?utf-8?B?RzFkOFlDRFBBYWFPVFAvQXNJNUEvb3RTUjhRMkJQOVN5RFNhMGw4MDFHVDRM?= =?utf-8?B?b3I1ZUo4bFFmT1EydS9qWS9sQXlEODVoS1hkV0Y3ODcwNUtiWjlId2ltd0JD?= =?utf-8?B?Y2hTNm0yRlNTaGZacFMwWTlWSFpWc0Izb0RRY2JXY3JReXhicEdKaUNBdGM0?= =?utf-8?B?Vm1IZmh2bGlVWHZyU0JPL2JhTDZHeURlZEN3cDlmelhmWTJqVmZZUzlXQS93?= =?utf-8?B?Y2xRRFRZRGFYLzBia2JLQm5Ka0U5bENrakFya3FmNENCWFh5VWpwcmxUTisv?= =?utf-8?B?czZBcnBDYmdNajk2TXR5U01veDVkWHlCQ0RnR2xnUFFWT3ZDZ1ROTjU5anVa?= =?utf-8?B?U3JOVC9qVjcyUElTMzFPZnBKSHR6djhaSWdpM1Y0NWxoWnpLeFRYQWdLVmUx?= =?utf-8?B?WnFTWVZ4WklURnhhSEhLbnJMY01kVU16eEttY0UvZUxHL2hoczZoV3UweThX?= =?utf-8?B?SGhySTEydUloQzA5WnducnppalJaMTF4WDZWcENtRWdWMndBYm1LNmZBWTM2?= =?utf-8?B?eWZabUFRdTVOSlZvRzVTVitxQ0VRaTZ1aW1QR0xDSjBNMjd3NDY4Y2Z2YUNs?= =?utf-8?B?ZWN3d0U3eWxaajlDMGlUL2NUeVVDcmNYSUNyaHAzbVRvakY0QXJseEpJZ1dv?= =?utf-8?B?Q204SDhGNU43U3ZEQXJrZUJEMGtFUlNodit1dlIyM01laG9RZVlRdGpBZGVa?= =?utf-8?B?M3FGNHQ0VnA4ZGpraEFlMUlSZCtCV3NuTmFhTXpQdnpLa2ZXbnVOTGhRWnpF?= =?utf-8?B?WVFLcU9FamUvNUh0S2IxQ2lNbFpTMkxIMjZJeE1jM3VPWlc4QmhoZFU4OTZL?= =?utf-8?B?Ly8vYkNhMTBPVW9FOHdISkVVUzUxVURSZ2xOTCtjWjZBZS83MW5aTmNwVVds?= =?utf-8?B?Ykk3cDB5bGVCR0g1ckFaZWdWbTcvMGRlQWpZY2txdmlSL3I0dy83TWRkdUFN?= =?utf-8?B?dmh0NVk4bDhYMjVma0sxREY3UlVhQ0pIemV3dStpZGVTWXFWNWNLTEtCY3k1?= =?utf-8?B?aWFFbFJaTGRQNy9sZkZGaGRoNFpyVFZ4K2s2a2dhWE5neU9WWGM4Nm5YckV1?= =?utf-8?B?NUI1VWRPaVYvZmtkNDh5N0VUMXZOajk5bHNmbnozRUdtVFFzR3NGVFF5elpp?= =?utf-8?B?SlRxWHkzZ01jL1JxRnAxK3QwcDRsSjgyNEF0dnRQTXN6NzZBODlpQlF2OGZL?= =?utf-8?B?VjB6d2FLa0phcENldmNWNTJESWMxbEp2UXFnNGRRSjRyMWwwSjlLUEtFQkVB?= =?utf-8?Q?6cOyAJlKpMdmiz77O7M0T2alo?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e50ad12d-b1fc-44d9-a565-08da5e5892a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 07:32:53.9036 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y9oLQOueq1TYKD03QnIOkA0beIZhyCwMFmtrLToAEXxgKakGuwQn9MRoZnyw/u4o0BBHxSqWHd8TxFqeD4z+VQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5246 On 05.07.2022 09:18, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月5日 14:35 >> To: Wei Chen >> Cc: Stefano Stabellini ; Julien Grall >> ; Bertrand Marquis ; Volodymyr >> Babchuk ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 >> building >> >> On 05.07.2022 05:54, Wei Chen wrote: >>> Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 >>> is using stub.c of EFI common code for EFI stub functions. But >>> "-fshort-wchar" CFLAG will cause a warning when build stub.c >>> for Arm32: >>> "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses >>> 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of >>> wchar_t values across objects may fail" >>> >>> This is because the "-fshort-wchar" flag causes GCC to generate >>> code that is not binary compatible with code generated without >>> that flag. Why this warning hasn't been triggered in Arm64 is >>> because Arm64 does not use wchar type directly in any code for >>> parameters, variables and return values. And in EFI code, wchar >>> has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). >>> CHAR16 has been specified as unsigned short type in typedef, the >>> "-fshort-wchar" flag will not affect CHAR16. So Arm64 object >>> files are exactly the same with "-fshort-wchar" and without >>> "-fshort-wchar". >>> >>> We are also not using wchar in Arm32 codes, but Arm32 will embed >>> ABI information in ".ARM.attributes" section. This section stores >>> some object file attributes, like ABI version, CPU arch and etc. >>> And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" >>> too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", >>> but for object files without "-fshort-wchar" is 4. Arm32 GCC >>> ld will check this tag, and throw above warning when it finds >>> the object files have different Tag_ABI_PCS_wchar_t values. >>> >>> As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar >>> to use short integers (2 bytes) instead of integers (4 bytes). >>> So keep "-fshort-wchar" for Xen EFI code is reasonable. In this >>> patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm >>> architecutres without EFI enabled to remove above warning. >>> >>> Reported-and-Suggested-by: Jan Beulich >>> Signed-off-by: Wei Chen >> >> Tested-by: Jan Beulich >> > > Thanks for testing! > >> As to the description: Why the reference to gnu-efi? I don't think >> it matters how they build their code? All that's important is what >> we do, I suppose. >> > > How about: > "Xen need to keep "-fshort-wchar" in EFI code to force wchar to use > short integers (2 bytes) instead of integers (4 bytes), but this is > unnecessary for code out of EFI. So in this patch, we add > "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures > without EFI enabled to remove above warning." Reads better to me, thanks. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 08:03:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 08:03:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360664.590076 (Exim 4.92) (envelope-from ) id 1o8dWD-0003ru-Ka; Tue, 05 Jul 2022 08:02:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360664.590076; Tue, 05 Jul 2022 08:02:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dWD-0003rn-HD; Tue, 05 Jul 2022 08:02:49 +0000 Received: by outflank-mailman (input) for mailman id 360664; Tue, 05 Jul 2022 08:02:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dWC-0003rh-7t for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 08:02:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dWB-0007Ua-40; Tue, 05 Jul 2022 08:02:47 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.0.187]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8dWA-0008Tl-Up; Tue, 05 Jul 2022 08:02:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xNuzSen0qi/55KIWt9lgEbU1IbUI3o2yeUpsQRbzYqs=; b=vb2SmmWrFzSFnk+eL5QyVXCOZp VyrRf4UXEOIASY90ytyIm0AL8J+Ri+R60+KGHhBXt0fYR3yLEWhs51NsFwDUTYr19bNKamTyEa2Mz 30k2GeofvyCxiZ2BS2AbrPRB12zI3dGhwl4luZmT3oj1W3mhMjau7d+4QLA8LsRX9E4U=; Message-ID: <620f2259-25eb-bdac-b894-ca1a661a8d3a@xen.org> Date: Tue, 5 Jul 2022 09:02:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Xen: fix EFI stub wchar_t size warning of arm32 building To: Wei Chen , xen-devel@lists.xenproject.org Cc: jbeulich@suse.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705035405.1283032-1-wei.chen@arm.com> From: Julien Grall In-Reply-To: <20220705035405.1283032-1-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Wei, On 05/07/2022 04:54, Wei Chen wrote: > Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 > is using stub.c of EFI common code for EFI stub functions. But > "-fshort-wchar" CFLAG will cause a warning when build stub.c > for Arm32: > "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses > 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of > wchar_t values across objects may fail" > > This is because the "-fshort-wchar" flag causes GCC to generate > code that is not binary compatible with code generated without > that flag. Why this warning hasn't been triggered in Arm64 is > because Arm64 does not use wchar type directly in any code for > parameters, variables and return values. And in EFI code, wchar > has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). > CHAR16 has been specified as unsigned short type in typedef, the > "-fshort-wchar" flag will not affect CHAR16. So Arm64 object > files are exactly the same with "-fshort-wchar" and without > "-fshort-wchar". > > We are also not using wchar in Arm32 codes, but Arm32 will embed > ABI information in ".ARM.attributes" section. This section stores > some object file attributes, like ABI version, CPU arch and etc. > And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" > too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", > but for object files without "-fshort-wchar" is 4. Arm32 GCC > ld will check this tag, and throw above warning when it finds > the object files have different Tag_ABI_PCS_wchar_t values. > > As gnu-efi-3.0 use the GCC option "-fshort-wchar" to force wchar > to use short integers (2 bytes) instead of integers (4 bytes). > So keep "-fshort-wchar" for Xen EFI code is reasonable. In this > patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm > architecutres without EFI enabled to remove above warning. > > Reported-and-Suggested-by: Jan Beulich > Signed-off-by: Wei Chen Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 08:09:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 08:09:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360670.590087 (Exim 4.92) (envelope-from ) id 1o8dcd-0004XO-AQ; Tue, 05 Jul 2022 08:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360670.590087; Tue, 05 Jul 2022 08:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dcd-0004XH-7h; Tue, 05 Jul 2022 08:09:27 +0000 Received: by outflank-mailman (input) for mailman id 360670; Tue, 05 Jul 2022 08:09:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dcc-0004XB-CI for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 08:09:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dcc-0007bs-4I; Tue, 05 Jul 2022 08:09:26 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.0.187]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8dcb-0000Ow-U8; Tue, 05 Jul 2022 08:09:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Jj7tSBcIfDp8cmv6dKZdNQK/tyXjHeaCtGdb8D86sGE=; b=OL+RB3YC72wMF4a/iUiIJAAmc2 J39OX85JDjtrgwCursN8mjIXqy7p1hSovpQeEbIbYfFlXP8n0/aJWhpznbyB7zXcj2nAYaEODnygs mXKXz57plsE8IKy/9XXuyeSgJcA2BiqSGXIX5/VrYsgehg5xZCNDUF4thUwnQegUE408=; Message-ID: <721ef265-7b3f-80cc-3d26-bd88b9971d26@xen.org> Date: Tue, 5 Jul 2022 09:09:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree To: Penny Zheng , Stefano Stabellini Cc: "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/07/2022 08:45, Penny Zheng wrote: > Hi Stefano and Julien Hi Penny, >> -----Original Message----- >> From: Stefano Stabellini >>>> + res = fdt_property_cell(fdt, "xen,id", shm_id); >>> >>> Looking at the Linux binding, "xen,id" is meant to be a string. But >>> here you are writing it as an integer. >> >> Good catch! >> >> >>> Given that the Linux binding is already merged, I think the Xen >>> binding should be changed. >> >> We would be compliant with both bindings (xen and linux) just by writing >> shm_id as string here, but if it is not too difficult we might as well harmonize >> the two bindings and also define xen,shm-id as a string. >> >> On the Xen side, I would suggest to put a clear size limit so that the string is >> easier to handle. > > I've already made the xen,shm-id parsed as a string too, seeing the below code: > " > prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); > if ( !prop_id ) > return -ENOENT; > shm_id = simple_strtoul(prop_id->data, NULL, 10); Why do you want to convert the string to a number? > if ( shm_id >= NR_MEM_BANKS ) IIRC, you are not using "shm_id" to index any bank. So why do you want to check against NR_MEM_BANKS? > { > printk("fdt: invalid `xen,shm-id` %lu for static shared memory node.\n", > shm_id); > return -EINVAL; > } > " > The size limit is smaller than 256, just as stated in doc: > " > - xen,shm-id > > A string that represents the unique identifier of the shared memory > region. The maximum identifier shall be "xen,shm-id = 255". The first sentence reads as the xen,shm-id can a free form string. But then the second sentence suggests a number (not a string). In any case, it is still unclear why you want to convert the string to an ID. From my understanding, Stefano was suggested a limit on the characters rather than a limit on the number. If the latter is desirable, then the documentation should be a bit clearer and you need to validate the input provided by the user. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 08:33:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 08:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360676.590098 (Exim 4.92) (envelope-from ) id 1o8e01-0007zA-7c; Tue, 05 Jul 2022 08:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360676.590098; Tue, 05 Jul 2022 08:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8e01-0007z3-3x; Tue, 05 Jul 2022 08:33:37 +0000 Received: by outflank-mailman (input) for mailman id 360676; Tue, 05 Jul 2022 08:33:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8dzz-0007yx-Cv for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 08:33:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60087.outbound.protection.outlook.com [40.107.6.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27a99e89-fc3d-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 10:33:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8633.eurprd04.prod.outlook.com (2603:10a6:20b:43c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 08:33:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 08:33:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27a99e89-fc3d-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ay+gKhjyaAs+C0PWnKhss6PBWaa2TwQdRmpVzlTLfBwjHvy/bVRcLDdotqbooqAweyMDCAor36nP/0qeopDeujqjNoWYrBh5v06kmsYNq4yKi6L8hlIcUc0B+QiOPYppwi4AsXYrjmawbJbbikqZY7CFdgnXKU7kLj/ScpipgqPAbRdcKcLkcglcRfWL4G505YcuvmYJhAhByIjisq2D9uYSFy+asZ3K0BaiLBvGHOHFvrJBWMmRNgVD2mZmHgggnnCapXFwdNPpyfmTkgG+FrWiuRZqciOUxdxSJs6/lciyRRDMTVXfZTtyu4ois0pOo2FCRf9sOIWHzBtI4o402w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hd7SjqojnAvgXUt9V3Q1YihQSM+psdO9zlfh5i52V2I=; b=kDAQJYuAmtgyKxafOnqAWGdIoVJCkSisNk8WH7GpeGsB1V8N7DtziuqKfKUz+drbCYVfyV3R6uLiYBI0fHXyrh+1MEYiWWyP1UQ29z6o+EB1zij33NK/4yplJLO4Rdro+4mMeosvIff00GAmHI9plta6/oQKk+2mPD42opvoLr6Yu4abRL3xYzuRxPuevkUvFctmOEKI0608ws0b2Vkrly6o6tHvVJCdXOsoEGJ1F1OBVjadvSkxCmrutbrnG3TCBii5RkZNwePnBmgrbURdtgpgN2x+o5APLCjyWDb8nYhdHoHAS6MUld8cRVLiUokM7KCLEP7uByez1p8aGKQOjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hd7SjqojnAvgXUt9V3Q1YihQSM+psdO9zlfh5i52V2I=; b=SEAq48tt+sp3w8A/QoryITRcrqui8cxLDFVGn2K+vqFsetp9P7RTFzWOxolnSkCja4+FGjo2Jr+o5o/LQNIdeZHhR0ws6EpqMgg2SJqVYJLrceU0qmJ7ElxME/AHrpWKsiohkCZCT/AXOZjsXhS8uU0/naetBSIq8c3O1aHgOL1XQpATGSXf5K3ICEUO4GA7Qkn0arCeyDOc4G02G/9qUoHIu4vvZXgFaf400+6dqG34SgD0Eci7t09gLwsWL4ylam36da11VBXlrJENrw7G+vY0J7wHrgHJCg5GOcLFy/bIYeIpCV/YxFOYacHS/zFc1+5OMCmX0UwdgDmN1w5g0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <949332d6-7915-392d-26a6-f3aaeefefc4f@suse.com> Date: Tue, 5 Jul 2022 10:33:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 01/12] IOMMU/x86: support freeing of pagetables Content-Language: en-US To: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Paul Durrant , Wei Liu References: <24eb0b99-c2c4-08aa-740d-df94d2505599@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 39204360-ed00-4bb0-0440-08da5e610ad6 X-MS-TrafficTypeDiagnostic: AM9PR04MB8633:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: E3QUcgjYpscPmSDa5WUgeowoiFzofMk+aNi47hR52mKxggPOjtkxzsZurHjp5VgNnHDF2fLiDH0YDEdZeTPAHXbc5U62/bXMpwqFFBTXOZbFg6v3QrpU6MJah8wO1eYbzesYKzajodvwpuC4+3gS5LDuINhbUIqzWk0KvwlXFbUl+FdRs/AdxGfVQtUVt5xaguXK6pC6sAm0HAVBM8gmCLj4Lr8Dew6H6dMH9cRocvQK52jcMZa0GByWaeWsScXakv0r8FdXDlnJsydpFlMvJFhPIP/7KWW1u6mpD8xdtrlD0eACyz2ovwknoBuN1YGAgNi6/88Y6wG79LXbUatz0UF+tGB1XPgbh71hQbk2uZIh7Ch0eFVAZTtmwSTwind7WuUzPdId50iyDC1Uq0Ql3HaA++O33+6WnNAGp+7tdIK91UvOuftJSbEi1P+9rtDoNlj95Cl2cxL22p7sFhyQyrRRkQH+c+kR/VirLqrLPzuxwa2aBEPqeY8uaV2ICnQGLg6MGrRDEo+XiqqJRt3vzZeNCkgtf+waD6sihKBkgr2lRnyVhcc5hoZY90c71ZWyJWKGtRUx88dvn/7ss0LLg+s2t8labttWgYYmfP3PjakBS8pe2zTF+BH7W9d6wK6hDZEPX65yUcmGpEvvzG+b5+ICT1fBf6dphE9clycXuKe564VwxzdyyuZ52EnNegUdgy5/d2dIgyNf55D7jpsnlDNkBwtAcbYTGHCtG1wC2yiiAz5oAj4jShxUbosGMyXo5pT2vw+u/EMCykxKrOY/pqhcXRecIQxa4Khw89zv+ngoU/m+s3evO6LolIawkaxQwbggIHDfjnoAnrC9b+fG/zBde0FZenis98acuvfMjDXy88D1dxHoitM0MFqgqfWj X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(346002)(136003)(366004)(39860400002)(6486002)(31696002)(8936002)(5660300002)(478600001)(53546011)(8676002)(6506007)(86362001)(2616005)(6512007)(26005)(41300700001)(2906002)(38100700002)(83380400001)(186003)(36756003)(6916009)(66476007)(66556008)(54906003)(4326008)(31686004)(316002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WXNHd09PdStudThrU3o1TXU3V2J3VmkxWFJ2YUNaUVg2dXZIRXNpeUY4dHdt?= =?utf-8?B?eGVYYXhEMWgyU2xVbm1RYWVwNVR1M1hhS2w2Tzh5TTA0SURlbjRhY3l1bnVn?= =?utf-8?B?VkZqYjZzS3EwT29oem5YeGlmMnNXZFJSRjZMeW1Ddm1Vc1czbU93V3N4bDhZ?= =?utf-8?B?WjJqeGZEVzFBSHN1bnZlQmt5blE5SXEyazhTaHRkSFJvUUVtbStlaDFHb25l?= =?utf-8?B?eXdyZnJpODdCdjJXK0lvNnkyNEkxdld6VjBtN3RDVE5kOUw1YUVnQm5GSHFx?= =?utf-8?B?VEVqYUlrQW9LRFJzNDB0QzNrdDM4azBlZ1h1NjN3Z0lranp3TnJEZzUyenR0?= =?utf-8?B?ZGJJdHhHS0c1d0R4bVR1bG83NmQ3WGd5ckRwOW1JQ3lTbW1Qd3FiYmpYRmY5?= =?utf-8?B?OEFrM0wxM3MxU3NFb0ovcUIvdmpxZDU5L0pxZ2tRaDBwUW1hMTgyNHJnaUhl?= =?utf-8?B?ang5cGxxTzFpaEJZVTgvRm1HblZSODMyc3k0SkhqUmRRamE5QTQ0N3U1Tm9W?= =?utf-8?B?UTBEK29qaGJSbkxNN2JHTnVXVjU1SVh3eUsrN1NtRER0MWFIdjZ0dzNVMGpk?= =?utf-8?B?NWZxSlFxNTRSVGxDN2ZyNXZYOFFGWkc5V1VnRG1SMTQ2Zm9hK1prUHRkU3B4?= =?utf-8?B?VjRhQkp6L1YzNDJnWTFhbzBLN0tVS3BzQmlOdU5PWlRjUExDeU9qeHF1NXRZ?= =?utf-8?B?dDVwNEI5MFU2bnFnS1AxSU1ySUpzM2JUMndISm1YanZWY1N5enJkVFdHWXBK?= =?utf-8?B?c0FuRkRTam1ZUmdvNVBaRnptd0RPWmpxWlE4SjdMVy9PSTFqUHRucllqUHRL?= =?utf-8?B?R3dwaXBkUm9EbVFzR1YzcjZueGg1NkJFNk12cVRNN0VJL3oybTU2a2dCUmp5?= =?utf-8?B?emZCbWVadXNnTEdaOGdYQVN4U0VpNENYV0ZyYURvR2NYVlo2NnB2NXVaRTU4?= =?utf-8?B?V3lSR01jd0NGL3Bmekw1R0d3SitPM1NTVEFCN2l1SDVIdXdZTDlRMnRJY3lO?= =?utf-8?B?UGdsUWltQkJtOG9EK1h1YURPUTFaT0NyUGtZODE0NDlyN1VuV1hVOGRmeWhx?= =?utf-8?B?MzZCTHN4bVFKcEhMQXlRRW0xSkc4MUVia0VlVTZCRE5jcURCV0RObUNKN0pt?= =?utf-8?B?ZzdxTUN0dk5TZmNCNHVQaVhod0VwenMyMzJmZTF4Qm9DdEZZTGJPWXdjbzdM?= =?utf-8?B?SVMzOTFrU2h5QnY3c2I4UUY0SmNSem5ZRXUvd3h3UzRjczFteXkwckU4UmYz?= =?utf-8?B?UjlYZkxRR2k4R3J6cGRQS3VqekhPay9IZnpjWGNubkk5V3l2Q3dMOXZuTDZV?= =?utf-8?B?QVJIZWxTc3dVb2hBeFVSYzJhaGhoMVU1WDBId1BaZWg2SklwMFd2Nk1SN3BH?= =?utf-8?B?UlJIcDVoMUsyOXR6L0VBSWlkeGVPYURaSXM3YTQxcURXczRpY0Fqdm9IaDRP?= =?utf-8?B?eFpRNWw2OEVaVkQwNHBaanFKVXYrU2xabTNTcFNkRVBWL1AzWWJiaExEQ053?= =?utf-8?B?MlRQMXNkeHF4cjR1bUpBMG1ZWVk5VmxhOXhoOWZjY05KcHFvaTRZU09CdXBG?= =?utf-8?B?WDEva1hvTmx4NE1XYTlvRklQY2QrTm1GbWtPVVh0cnc4UUt0VkVIemV3R0Zn?= =?utf-8?B?SlVXTXNYQWtraFQvS241bGdlNWVmZzQyaTVTU3RMTkd5Nm9iT0ZpOWxhVDFR?= =?utf-8?B?dnF2QWdTc0pHQ1djRnRjL09hU091OFV6a3pZZnF0Q0NkZWZDOHFBUVJaelZN?= =?utf-8?B?WERuUE5pa3JYemxJbmF3Y2pRYmVzb3UxY0lnWTdEUmFwZDlabGlSQ2NOdnZF?= =?utf-8?B?V0JEQ0o4QlVxZGNzWkhYVEM4Y2F6TXpjM0syeXYvMU90dnNSS05UZU8zcHNF?= =?utf-8?B?M2VDUHVDZjZVa29RbGFocjUwRzRHNVB0Qy8yaW1nZDhucG1aTkxpU0Q1QTVO?= =?utf-8?B?OGthY2EyOUhnOExETTFuNzFPc3lxQ1VKK1pVY0JJdjd6OU1tOG1rZFZuZVNt?= =?utf-8?B?R1d4NERDODRNS2NDbDJ3YjdvSkhOTmJUMjlwNFpkdmUvVkFERjgzUCtGL0xu?= =?utf-8?B?VS9oV05WYlJLTWcxNmtIVUJTcVFwVTBXTHVGTG1tZW9CK0wrWlYyK3UzWnJu?= =?utf-8?Q?RaS14nmbiCQ1eceW8WnM9XneB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 39204360-ed00-4bb0-0440-08da5e610ad6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 08:33:31.4389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UX25DETCcIAAmEI+d2SyO8cG4RWgzHOkA831Qe87tD0IP3I7J+mlFjZb7LgUgVPok66T7OMfk407Y6SH+Ka2vA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8633 On 28.06.2022 14:39, Roger Pau Monné wrote: > On Thu, Jun 09, 2022 at 12:16:38PM +0200, Jan Beulich wrote: >> For vendor specific code to support superpages we need to be able to >> deal with a superpage mapping replacing an intermediate page table (or >> hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is >> needed to free individual page tables while a domain is still alive. >> Since the freeing needs to be deferred until after a suitable IOTLB >> flush was performed, released page tables get queued for processing by a >> tasklet. >> >> Signed-off-by: Jan Beulich >> --- >> I was considering whether to use a softirq-tasklet instead. This would >> have the benefit of avoiding extra scheduling operations, but come with >> the risk of the freeing happening prematurely because of a >> process_pending_softirqs() somewhere. >> --- >> v6: Extend comment on the use of process_pending_softirqs(). >> v5: Fix CPU_UP_PREPARE for BIGMEM. Schedule tasklet in CPU_DOWN_FAILED >> when list is not empty. Skip all processing in CPU_DEAD when list is >> empty. >> v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base. >> v3: Call process_pending_softirqs() from free_queued_pgtables(). >> >> --- a/xen/arch/x86/include/asm/iommu.h >> +++ b/xen/arch/x86/include/asm/iommu.h >> @@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns >> int __must_check iommu_free_pgtables(struct domain *d); >> struct domain_iommu; >> struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); >> +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); >> >> #endif /* !__ARCH_X86_IOMMU_H__ */ >> /* >> --- a/xen/drivers/passthrough/x86/iommu.c >> +++ b/xen/drivers/passthrough/x86/iommu.c >> @@ -12,6 +12,7 @@ >> * this program; If not, see . >> */ >> >> +#include >> #include >> #include >> #include >> @@ -551,6 +552,103 @@ struct page_info *iommu_alloc_pgtable(st >> return pg; >> } >> >> +/* >> + * Intermediate page tables which get replaced by large pages may only be >> + * freed after a suitable IOTLB flush. Hence such pages get queued on a >> + * per-CPU list, with a per-CPU tasklet processing the list on the assumption >> + * that the necessary IOTLB flush will have occurred by the time tasklets get >> + * to run. (List and tasklet being per-CPU has the benefit of accesses not >> + * requiring any locking.) >> + */ >> +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); >> +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); >> + >> +static void free_queued_pgtables(void *arg) > > I think this is missing a cf_check attribute? Oh, indeed - thanks for spotting. We're still lacking compiler detection of such issues. >> +{ >> + struct page_list_head *list = arg; >> + struct page_info *pg; >> + unsigned int done = 0; > > Might be worth adding an: > > ASSERT(list == &this_cpu(free_pgt_list)); > > To make sure tasklets are never executed on the wrong CPU. Sure, added. > Apart form that: > > Reviewed-by: Roger Pau Monné Thanks. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 08:44:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 08:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360683.590108 (Exim 4.92) (envelope-from ) id 1o8eAb-0001CQ-C6; Tue, 05 Jul 2022 08:44:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360683.590108; Tue, 05 Jul 2022 08:44:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8eAb-0001CJ-9N; Tue, 05 Jul 2022 08:44:33 +0000 Received: by outflank-mailman (input) for mailman id 360683; Tue, 05 Jul 2022 08:44:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8eAa-0001CD-C0 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 08:44:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2049.outbound.protection.outlook.com [40.107.21.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af812554-fc3e-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 10:44:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB9450.eurprd04.prod.outlook.com (2603:10a6:10:369::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 08:44:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 08:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af812554-fc3e-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KjZKGFam89p2hcwuBQnhH+gfWVTx3PUyyfniwiGqiNgoshmlnDxaHPO75zg04BVhnbDDhEto+YJkp9N3BhtE7UATVhfYc1b5F5Tl4nnbqBGZg6N8OB9nHWokGd4oUZ0JRi4KH0j2BAKI9XKjv1gJlL7m3eSKoUVev/omzHMbHzBaDl5ZtRRIFW7XY5/JAkF3nrkXUaD2TuFj4HXkE/En/1x5q8N3xuA3jsemK615KzaoB0hcW6Lhn+6mpPdM0Haiz1cJF4iDT6L+c1ND+0NaHvwvQRgU1/1e8TVpZ4wXmDOP75vQvAbj22h7L2ZCjzSvl/vqZEG1f4JlavnfhW2Ldg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1cDwZpqa5KPrlAl4ZCkM3Ax2z2QShSo5yP48/j/vqPg=; b=IhgGFEbHN1vzgyKO1tySorF1c3bCXJJ9GagJ3cWi3Uue8c8k9dbeKP9Qd0mQ4WEvtDWpva6HJkYkB5dGT7krnBh/WpKk8/hloKxnB2H1pVMPscjzsHyVfsfiS0kMhGB6h/k+JbPIzmOOErRCJrhPaW3gbwHYCEtq+qLxI1SiXvsLAXoVUQVuLa5bDwic2RHjLKFW7azVwaJh6QyWA6FMhTAklodX04KrDfbTSLyd6BYvx5bnicdkOI2g1kIO3SEGEhsFRM6hUjNpnBdP00wexZqcQ1ZBCMzCHes69JZxvE1OfI2KhaLq5lgs1ZduDkILBGKW3QNSBve4FLRO0FhBnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1cDwZpqa5KPrlAl4ZCkM3Ax2z2QShSo5yP48/j/vqPg=; b=5zbNyf9EraiRqvP7aaxp9jGdu8SCV9l8SnNYxbZW4Am5O3OCQOee9DFPnBn59bv9E6nuWaxY2AiApEX9LZPM+VbcfqZR6kVvTjNpxcdhaTfWX1RpR/vRhfFbuOE9BehgMu7PeHvex4GD9fdWR4LS3Ins1UJ/zOXYGBsqC+0c35rOvoylIsh4zbm2KhgAyYweuEgu+AekHtVH05loF3YrY+f1+5upv0pqGfG0eKy9Uu2VM3i1mvlXxmIVeFFqCxPsFOieCfw+nBiWnIzEL0cton2T0EW4ONHmqITglLLMP8om3sv1XFamV/zNLqeeynH/kSNYN5gpAgmVKj4x3mg47w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3cb46257-c6e7-9735-c824-abb296668ee3@suse.com> Date: Tue, 5 Jul 2022 10:44:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Ping: [PATCH v2 1/2] x86/mwait-idle: add 'preferred-cstates' command line option Content-Language: en-US From: Jan Beulich To: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Wei Liu , "xen-devel@lists.xenproject.org" References: <46c6bf61-5669-0de2-163d-64b9a3ce07a7@suse.com> In-Reply-To: <46c6bf61-5669-0de2-163d-64b9a3ce07a7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31884b70-d7b6-4ea7-3bcf-08da5e629273 X-MS-TrafficTypeDiagnostic: DB9PR04MB9450:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /AJGcCjUZ6XykNgldPNeXxBmlUcZAIgLs9NN2Zdpp/KQIxE7nBOCu4w4otnRIePN3XqvXldi6/pZeBoHDZIzlpgo9/RlaCJeE116IMJdMVzIvFGHdr5eJewYlMFK/tieXnBG6uEbotYTo6C7JTNIW1WDmDuyiGCoLKhaYxCzhMkx+MvAFtqTNDXnA9XX4JILc+FR1CnWJN7ewtfQ1EE62co4luMNDqEZJ3rH7El/w5+saFVbdMqG7J18PsE5MT48ih00nMpVa/5L+i6oa6Ye3ZzbvCrUxGVOzhINXkIhbCAo3yj90Y4eg1IIvpSBpHE3VlOYmyjaZ9tTYXwYB25PHJDhcEjUqjNMHBtKZdKKjB/rVWQPq4fVjanLkEArez2yAwN5xZ0Q66y8VAP8j8aSy4TQ9OF/9V9zPOhXHIlucSk4+lPvoV/ChUJUsoWtHtkCgJ0qOkTBYIuKEPYiro/1skmVSGJ5So/wO1D+Qy5ZPHz/svL4IJIpcMRxeGtCEtHRC8jMdAPopRGOTkmKnHg0sWDWaJNFeL7QWYtIOVN2is4rn+dZci99J6QADZeo852cMUz/07cn0iEnp0L5qLsTh/k98NTXN4ASQ06x1iV09oq7yRzZapVuFNWIj0XbIXld4I7SB7xYI0q5YFj3CbeByBI2Z7wecf5D+4SNwJrMiJLQkA4zLlf57esvTlZtOZRo8RdeXaCjLaWk1NvQ2uEYK/OjQ7TI0WwF9OScxrr5zCFLRoYdXD4ph1dzGQA7cc4lIOW9kHtVQp6k2pA6f77l6PW2jl2lVdklxDj+gB0q7LaFQZaGMkURUOJOLriMABaZax0mD9RgGh8fiStItkqwWCIWoMrRg8qsLgoOYsCf7LA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(346002)(39860400002)(396003)(376002)(38100700002)(66946007)(110136005)(66476007)(5660300002)(4326008)(8676002)(66556008)(54906003)(316002)(86362001)(31696002)(26005)(2906002)(2616005)(36756003)(6486002)(41300700001)(478600001)(8936002)(6506007)(30864003)(186003)(53546011)(83380400001)(6512007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3NNaEJ4UjVJTWpCRzRzeGtYN1I4L2FWdUNlSTVDVTJLWTVCTU0vRVhQQ3gv?= =?utf-8?B?MG5zSWJXQnFKNjBJTlZ5Wk01bkFmZXN5cGZPZi9xWnlUT3FFOEV3VVM4WFVY?= =?utf-8?B?b09UOTl1Z0VTYjdUazNSN09KMnlFS0ZIcjhlVnlISWhmN0JTV0dkWE9WTE56?= =?utf-8?B?L2ZnSi91a2xYNFM0VExVUmZYSmE0cnBxWTg0VzczSTFIYTc5VWRVdkQ3U0tz?= =?utf-8?B?WHpFSnlnai9HekcyazM1K2pRaWpETmVwcjVIV2RERXErMWtYU0w1M09Ha1VC?= =?utf-8?B?SnozWkduYXpRZGV1S0ZyVkhQSWU0Ykp6RmNXcnF6Rngyc2Q4V1RMdEM1Z0Fs?= =?utf-8?B?R1FGODVBS2JXUnBFRzJ4V2dRT3YxbHVBeklhLzV1TFN2eDZDeDMwd00rUlJy?= =?utf-8?B?eTU3OTBDUXBkVW5MV1FSSW5XSnNaeVBEcmcrTHVuczRnQk5oZm12eUlsRzh4?= =?utf-8?B?MXMzVmVGdFZCS0JFemZZRE9xWUVxZW52NmZjeFFsdDNlRDFjNHlrWXpIdnQv?= =?utf-8?B?cEJ0SUduY3A5N2xJbXNoOVdpTXRrY0M1UW5sdm1ZcUNmc3N2Y2dkSVlFcDYy?= =?utf-8?B?VDRkSUtuNkFvT3pEYitsbWpDTitDaVVFZThqV2FQWHRNellWQzNWTWJIb2tY?= =?utf-8?B?VDVEeGh1bVAycXFOTGlBanJqc0x0aVZGSTAvTnlWWlJ3MElnWFdOUDRMMGZk?= =?utf-8?B?Nkd3ZExMc2FMNURCZHlhaVhEYW5KQmRsQzcwVm82d09rTFd0VXkwbzVNNmVu?= =?utf-8?B?MVdKNExURWwxS1Z4MzRFYVgwV1ZUSE1UYmNBNDNtU3BpRTBiQmt2OExYTktT?= =?utf-8?B?TGY0anV4T0NwbkllWFNnMTZwT2JVT0hRVllSa2VubHJsOExLWVpWaWpxWVNl?= =?utf-8?B?dU0yTG5HTWxNZzBmT2hQZ2lybmZTMTdHbkgyeHlUUGFmRHFqM2dxTFZEbWdz?= =?utf-8?B?eVhFQ0IvNm4zK2NvSlE1S2hnNU9uSDFZK0pMczJTcGJ4Z0Vub1hZTFBWNFBv?= =?utf-8?B?ckZLWnZHTDNmQnk3N0xCS3hXVHJKWTlGbnRIRmxVdmU1RmtLdFRZaXlndE5I?= =?utf-8?B?dG0wWU94V3VCQ1N1SXBiWWVMWGxkbDVrcE14VjhLMmVOR3I2eTdHRktHTE1m?= =?utf-8?B?KytkVFhKZmFBWmNkd0NvUHQwdEV2dmo0VVJzcis5alVoelhwMW1QV093aEhz?= =?utf-8?B?Rlp0ekQ1TlBDRkpIMm5rMW9udC9UQU5KYnpwaFZodEdQSFRmaEZna2NaY21Q?= =?utf-8?B?dmpiZ3lYRGdYZVMrRjhqMGVod0hwQ3lMZXYvYU1FYXhIdFBwTWgvMEdZclVH?= =?utf-8?B?V2NlYXJoYTdralIxWDNiYXdBd0l6NGozTjVqUElZaDdnUE9MRmc5N0lNSU5h?= =?utf-8?B?RU5tNnRVYTRScGpnZlZkZWdDNXJBTVhIeG04bkZMaWxIZlV3bk4yY2lXQ1Yx?= =?utf-8?B?U3dZU2wwV0U3bGdmQnlHR0FsZGFvN1luMU5vc2V2Y20wYW1hMDRnQUdobWNS?= =?utf-8?B?R0dld1IrL0tzSlhTVEhyU1hNVGJ5T0doYjZMbVMyeHEyeW9EUkdFQU1hMTI3?= =?utf-8?B?S0NEVHpHcFM0QUFJNWdCNHhOR1BiMzd3RUdhdHlNckZxM1Z6NUhIaUVWbzdH?= =?utf-8?B?YVh5enhReElEdjNJS1crOHllQVV5b1dLa25GK3VqKzlRejJ2OXBMbTBweUs5?= =?utf-8?B?eUVLZGVjMDY1b2hOQSsrU3QzNzliM3NmMnVSYVArbVBGVFROL1FMNG81OS8w?= =?utf-8?B?c1BvME9QdTlRWFFDWmZaNy8wci9VbXRobk1DTWprbEZZejhVWkxMQlVVQTRS?= =?utf-8?B?ZTNoTy92cmtHVVVFSzJ2eHhGdnR5RWxZNzUybGsrbW85YnZNeURVaWs4M0Zw?= =?utf-8?B?OHpielhFYjd3TGpsMkJJMm9CcGhpNnZ6VWFKRnppak53YjZrWitpckEvSmlK?= =?utf-8?B?R25hUmRtN2dZckpKV1VKSFBXU1ZzME1LNm5Ba1RpdGRYaHc1a1FacGg3M2Vp?= =?utf-8?B?VnhIdWNRVThRTkNad0VERkNJTmNqa0dHNW5GMXRRekthNmxmd1hmMFlMODdI?= =?utf-8?B?TGxNVysxdlJmK1RRaXdPUlZjblI0UzJPSmg4cnpxRUlsazFiejcyUTU4VmN0?= =?utf-8?Q?lUzX0VpKSHS4IZfEqS7Gp+M78?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 31884b70-d7b6-4ea7-3bcf-08da5e629273 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 08:44:28.4896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3IOoADXeQQuQTUS8beWH3HUnmh69o5NpkqYq6V8geJS4ZY8JTarQUBGtKrQKlOJ5+7gteMd9+f9m3XGOdhS/lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB9450 On 02.06.2022 12:26, Jan Beulich wrote: > From: Artem Bityutskiy > > On Sapphire Rapids Xeon (SPR) the C1 and C1E states are basically mutually > exclusive - only one of them can be enabled. By default, 'intel_idle' driver > enables C1 and disables C1E. However, some users prefer to use C1E instead of > C1, because it saves more energy. > > This patch adds a new module parameter ('preferred_cstates') for enabling C1E > and disabling C1. Here is the idea behind it. > > 1. This option has effect only for "mutually exclusive" C-states like C1 and > C1E on SPR. > 2. It does not have any effect on independent C-states, which do not require > other C-states to be disabled (most states on most platforms as of today). > 3. For mutually exclusive C-states, the 'intel_idle' driver always has a > reasonable default, such as enabling C1 on SPR by default. On other > platforms, the default may be different. > 4. Users can override the default using the 'preferred_cstates' parameter. > 5. The parameter accepts the preferred C-states bit-mask, similarly to the > existing 'states_off' parameter. > 6. This parameter is not limited to C1/C1E, and leaves room for supporting > other mutually exclusive C-states, if they come in the future. > > Today 'intel_idle' can only be compiled-in, which means that on SPR, in order > to disable C1 and enable C1E, users should boot with the following kernel > argument: intel_idle.preferred_cstates=4 > > Signed-off-by: Artem Bityutskiy > Signed-off-by: Rafael J. Wysocki > Origin: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git da0e58c038e6 > > Enable C1E (if requested) not only on the BSP's socket / package. Alter > command line option to fit our model, and extend it to also accept > string form arguments. > > Signed-off-by: Jan Beulich > --- > v2: Also accept string form arguments for command line option. Restore > C1E-control related enum from Linux, despite our somewhat different > use (and bigger code churn). Any chance of getting an ack here, then also unblocking the 2nd patch? Thanks, Jan > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -1885,6 +1885,12 @@ paging controls access to usermode addre > ### ple_window (Intel) > > `= ` > > +### preferred-cstates (x86) > +> `= ( | List of ( C1 | C1E | C2 | ... )` > + > +This is a mask of C-states which are to be used preferably. This option is > +applicable only on hardware were certain C-states are exclusive of one another. > + > ### psr (Intel) > > `= List of ( cmt: | rmid_max: | cat: | cos_max: | cdp: )` > > --- a/xen/arch/x86/cpu/mwait-idle.c > +++ b/xen/arch/x86/cpu/mwait-idle.c > @@ -82,10 +82,29 @@ boolean_param("mwait-idle", opt_mwait_id > > static unsigned int mwait_substates; > > +/* > + * Some platforms come with mutually exclusive C-states, so that if one is > + * enabled, the other C-states must not be used. Example: C1 and C1E on > + * Sapphire Rapids platform. This parameter allows for selecting the > + * preferred C-states among the groups of mutually exclusive C-states - the > + * selected C-states will be registered, the other C-states from the mutually > + * exclusive group won't be registered. If the platform has no mutually > + * exclusive C-states, this parameter has no effect. > + */ > +static unsigned int __ro_after_init preferred_states_mask; > +static char __initdata preferred_states[64]; > +string_param("preferred-cstates", preferred_states); > + > #define LAPIC_TIMER_ALWAYS_RELIABLE 0xFFFFFFFF > /* Reliable LAPIC Timer States, bit 1 for C1 etc. Default to only C1. */ > static unsigned int lapic_timer_reliable_states = (1 << 1); > > +enum c1e_promotion { > + C1E_PROMOTION_PRESERVE, > + C1E_PROMOTION_ENABLE, > + C1E_PROMOTION_DISABLE > +}; > + > struct idle_cpu { > const struct cpuidle_state *state_table; > > @@ -95,7 +114,7 @@ struct idle_cpu { > */ > unsigned long auto_demotion_disable_flags; > bool byt_auto_demotion_disable_flag; > - bool disable_promotion_to_c1e; > + enum c1e_promotion c1e_promotion; > }; > > static const struct idle_cpu *icpu; > @@ -924,6 +943,15 @@ static void cf_check byt_auto_demotion_d > wrmsrl(MSR_MC6_DEMOTION_POLICY_CONFIG, 0); > } > > +static void cf_check c1e_promotion_enable(void *dummy) > +{ > + uint64_t msr_bits; > + > + rdmsrl(MSR_IA32_POWER_CTL, msr_bits); > + msr_bits |= 0x2; > + wrmsrl(MSR_IA32_POWER_CTL, msr_bits); > +} > + > static void cf_check c1e_promotion_disable(void *dummy) > { > u64 msr_bits; > @@ -936,7 +964,7 @@ static void cf_check c1e_promotion_disab > static const struct idle_cpu idle_cpu_nehalem = { > .state_table = nehalem_cstates, > .auto_demotion_disable_flags = NHM_C1_AUTO_DEMOTE | NHM_C3_AUTO_DEMOTE, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_atom = { > @@ -954,64 +982,64 @@ static const struct idle_cpu idle_cpu_li > > static const struct idle_cpu idle_cpu_snb = { > .state_table = snb_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_byt = { > .state_table = byt_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > .byt_auto_demotion_disable_flag = true, > }; > > static const struct idle_cpu idle_cpu_cht = { > .state_table = cht_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > .byt_auto_demotion_disable_flag = true, > }; > > static const struct idle_cpu idle_cpu_ivb = { > .state_table = ivb_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_ivt = { > .state_table = ivt_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_hsw = { > .state_table = hsw_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_bdw = { > .state_table = bdw_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_skl = { > .state_table = skl_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_skx = { > .state_table = skx_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_icx = { > .state_table = icx_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static struct idle_cpu __read_mostly idle_cpu_spr = { > .state_table = spr_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_avn = { > .state_table = avn_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_knl = { > @@ -1020,17 +1048,17 @@ static const struct idle_cpu idle_cpu_kn > > static const struct idle_cpu idle_cpu_bxt = { > .state_table = bxt_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_dnv = { > .state_table = dnv_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > static const struct idle_cpu idle_cpu_snr = { > .state_table = snr_cstates, > - .disable_promotion_to_c1e = true, > + .c1e_promotion = C1E_PROMOTION_DISABLE, > }; > > #define ICPU(model, cpu) \ > @@ -1241,6 +1269,25 @@ static void __init skx_idle_state_table_ > } > > /* > + * spr_idle_state_table_update - Adjust Sapphire Rapids idle states table. > + */ > +static void __init spr_idle_state_table_update(void) > +{ > + /* Check if user prefers C1E over C1. */ > + if (preferred_states_mask & BIT(2, U)) { > + if (preferred_states_mask & BIT(1, U)) > + /* Both can't be enabled, stick to the defaults. */ > + return; > + > + spr_cstates[0].flags |= CPUIDLE_FLAG_DISABLED; > + spr_cstates[1].flags &= ~CPUIDLE_FLAG_DISABLED; > + > + /* Request enabling C1E using the "C1E promotion" bit. */ > + idle_cpu_spr.c1e_promotion = C1E_PROMOTION_ENABLE; > + } > +} > + > +/* > * mwait_idle_state_table_update() > * > * Update the default state_table for this CPU-id > @@ -1261,6 +1308,9 @@ static void __init mwait_idle_state_tabl > case INTEL_FAM6_SKYLAKE_X: > skx_idle_state_table_update(); > break; > + case INTEL_FAM6_SAPPHIRERAPIDS_X: > + spr_idle_state_table_update(); > + break; > } > } > > @@ -1268,6 +1318,7 @@ static int __init mwait_idle_probe(void) > { > unsigned int eax, ebx, ecx; > const struct x86_cpu_id *id = x86_match_cpu(intel_idle_ids); > + const char *str; > > if (!id) { > pr_debug(PREFIX "does not run on family %d model %d\n", > @@ -1309,6 +1360,39 @@ static int __init mwait_idle_probe(void) > pr_debug(PREFIX "lapic_timer_reliable_states %#x\n", > lapic_timer_reliable_states); > > + str = preferred_states; > + if (isdigit(str[0])) > + preferred_states_mask = simple_strtoul(str, &str, 0); > + else if (str[0]) > + { > + const char *ss; > + > + do { > + const struct cpuidle_state *state = icpu->state_table; > + unsigned int bit = 1; > + > + ss = strchr(str, ','); > + if (!ss) > + ss = strchr(str, '\0'); > + > + for (; state->name[0]; ++state) { > + bit <<= 1; > + if (!cmdline_strcmp(str, state->name)) { > + preferred_states_mask |= bit; > + break; > + } > + } > + if (!state->name[0]) > + break; > + > + str = ss + 1; > + } while (*ss); > + > + str -= str == ss + 1; > + } > + if (str[0]) > + printk("unrecognized \"preferred-cstates=%s\"\n", str); > + > mwait_idle_state_table_update(); > > return 0; > @@ -1400,8 +1484,18 @@ static int cf_check mwait_idle_cpu_init( > if (icpu->byt_auto_demotion_disable_flag) > on_selected_cpus(cpumask_of(cpu), byt_auto_demotion_disable, NULL, 1); > > - if (icpu->disable_promotion_to_c1e) > + switch (icpu->c1e_promotion) { > + case C1E_PROMOTION_DISABLE: > on_selected_cpus(cpumask_of(cpu), c1e_promotion_disable, NULL, 1); > + break; > + > + case C1E_PROMOTION_ENABLE: > + on_selected_cpus(cpumask_of(cpu), c1e_promotion_enable, NULL, 1); > + break; > + > + case C1E_PROMOTION_PRESERVE: > + break; > + } > > return NOTIFY_DONE; > } > > From xen-devel-bounces@lists.xenproject.org Tue Jul 05 09:38:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 09:38:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360690.590119 (Exim 4.92) (envelope-from ) id 1o8f0p-0006pZ-EM; Tue, 05 Jul 2022 09:38:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360690.590119; Tue, 05 Jul 2022 09:38:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8f0p-0006pS-Bd; Tue, 05 Jul 2022 09:38:31 +0000 Received: by outflank-mailman (input) for mailman id 360690; Tue, 05 Jul 2022 09:38:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8f0o-0006pI-Dt; Tue, 05 Jul 2022 09:38:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8f0o-0000ij-9r; Tue, 05 Jul 2022 09:38:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8f0n-0004qR-VD; Tue, 05 Jul 2022 09:38:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8f0n-0001Es-Uk; Tue, 05 Jul 2022 09:38:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=58Yu2Ybd/Uy3YyKffjePddT1Bh584ZLneIrzIyoI1yM=; b=KQHCpF6kQc4kZ+dv+HbwPcdwAy GFbUpieV0TvIS/MAuhF6wRfvMxUm9aHAFAlrQ2i3f/uhXoVJqh65DfocUYSjeKVjTW581RcOqsNyr +RDva1jKGmpFUdnH8uJUFIeG8BJylYV7RK5VR7AJGwDcBUQc/J9qzBsBM15/8tYombO0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171497: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=35609616a2353d23b43d6c490daed333f60c917c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 05 Jul 2022 09:38:29 +0000 flight 171497 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171497/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 35609616a2353d23b43d6c490daed333f60c917c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 725 days Failing since 151818 2020-07-11 04:18:52 Z 724 days 706 attempts Testing same since 171497 2022-07-05 04:20:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115185 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 09:52:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 09:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360699.590131 (Exim 4.92) (envelope-from ) id 1o8fE0-0000qs-Np; Tue, 05 Jul 2022 09:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360699.590131; Tue, 05 Jul 2022 09:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fE0-0000ql-Kv; Tue, 05 Jul 2022 09:52:08 +0000 Received: by outflank-mailman (input) for mailman id 360699; Tue, 05 Jul 2022 09:52:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fDz-0000qf-JF for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 09:52:07 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1f74aff1-fc48-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 11:52:05 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f74aff1-fc48-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657014725; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=0OZgWbX3Z4laFHJRntrRBS1Y1NcUpD4ge4AzoKJG7ok=; b=fmz1vv4obVCbl2KDqLt2/h904Qi+OZVVC7Vt/FtMioBmTjbUkEwROXej sNfUpphTM04nrjNzu6rOqfu+FBrdzS3US9rWpJL+78u5yeWTiz8ji0akg ZWlovxb/SLZD8cuMdUHbXi4/bjLV6qc5BQONWP6OsMyGzh3NDAtFmvX4N A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 77650235 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jdXj1aP5SbNZpsDvrR2ll8FynXyQoLVcMsEvi/4bfWQNrUomhTIAn 2UXWT+Eb/6KYWrzcot2YYTjpE9QsZOAnYU1TAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFUMpBsJ00o5wbZm2tMw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z7 +5Nv56fRycSHpKdxb0wQydUHjt1MvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRQqiDP 5BCNFKDajyfMwdiJXgeS6tiu9mEhn7afjxHul288P9fD2/7k1UqjemF3MDuUuOHRIN+nkuej mvc+iLyBRRyHMOb4SqI9DSrnOCntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3A UEO5jAnq6R00UWxV8T8RDWxunvCtRkZM/J0DuYzri+EzKHZ5wKELmEeS3hKb9lOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhRSJOSIXAmEiXg87HFZczsndrIwphR2aG76PD5WJYs3J9SDYm m7X8nZl1uRC1KbnxI3gowmZ3mvESozhC1dsu16JBj/NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N702wcH82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYib0PPImM9vgV5xzpUQFKTgCfqmNBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ MbznTeEBncGE6V3pAeLqxMm+eZznEgWnDqLLbiilkjP+efPPxa9FOZaWGZim8hktctoVi2Oq 4YBXyZLoj0CONDDjt7/qNJMcwlXdSJkXfgbaaV/L4a+H+avI0l5Y9e5/F/rU9UNc3h9/gsQw kyAZw== IronPort-HdrOrdr: A9a23:0zvK3qB5uaEqdBPlHemu55DYdb4zR+YMi2TC1yhKKCC9Vvbo8P xG/c5rsSMc5wx8ZJhNo7+90ey7MBXhHP1OkOws1NWZLWrbUQKTRekIh+bfKn/bak/DH4ZmpN 5dmsNFaOEYY2IVsfrH X-IronPort-AV: E=Sophos;i="5.92,245,1650945600"; d="scan'208";a="77650235" Date: Tue, 5 Jul 2022 10:51:50 +0100 From: Anthony PERARD To: Bertrand Marquis CC: Luca Fancellu , Xen-devel , Wei Chen , Wei Liu Subject: Re: [PATCH] tools/helpers: fix snprintf argument in init-dom0less.c Message-ID: References: <20220629124938.26498-1-luca.fancellu@arm.com> <4DB9F3AE-0BCC-45BA-9934-0304FBF84E82@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <4DB9F3AE-0BCC-45BA-9934-0304FBF84E82@arm.com> On Mon, Jul 04, 2022 at 03:32:08PM +0000, Bertrand Marquis wrote: > Hi Luca, > > > On 29 Jun 2022, at 13:49, Luca Fancellu wrote: > > > > Fix snprintf argument in init-dom0less.c because two instances of > > the function are using libxl_dominfo struct members that are uint64_t > > types, so change "%lu" to "%"PRIu64 to handle it properly when > > building on arm32 and arm64. > > > > Signed-off-by: Luca Fancellu > Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 05 10:01:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 10:01:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360705.590142 (Exim 4.92) (envelope-from ) id 1o8fMX-0002Rp-KD; Tue, 05 Jul 2022 10:00:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360705.590142; Tue, 05 Jul 2022 10:00:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fMX-0002Ri-GN; Tue, 05 Jul 2022 10:00:57 +0000 Received: by outflank-mailman (input) for mailman id 360705; Tue, 05 Jul 2022 10:00:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fMV-0002RY-Ql; Tue, 05 Jul 2022 10:00:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fMV-0001Dy-NR; Tue, 05 Jul 2022 10:00:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fMV-0005Ot-Bd; Tue, 05 Jul 2022 10:00:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8fMV-00020R-BD; Tue, 05 Jul 2022 10:00:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XQmX/f4iQeem8/wQfr22pi92tKIvCPWkxb/16DX8BVE=; b=DUWR6upuIhzQL08wF2CfmWgY91 NX94WLQFIof/UrB9Kn67fnCLXJGDqqVSEZeo4mzx1eg0XiftOWo83zpCEtJVRevd487S/PoWBqSLB qOorqRNtn4sOyC1jDtAh8Mrp2mHYb82ZMJO4//r2rK0X3vC2SiOl0y6T9c1fLp0y1mlo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171496: regressions - FAIL X-Osstest-Failures: xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Tue, 05 Jul 2022 10:00:55 +0000 flight 171496 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171496/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-pvops 6 kernel-build fail REGR. vs. 171491 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171491 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171491 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171491 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171491 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171491 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171491 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171491 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171491 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171491 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171491 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171491 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171491 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171496 2022-07-05 01:54:23 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm blocked test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jul 05 10:04:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 10:04:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360712.590153 (Exim 4.92) (envelope-from ) id 1o8fPs-00033w-4O; Tue, 05 Jul 2022 10:04:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360712.590153; Tue, 05 Jul 2022 10:04:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fPs-00033p-1B; Tue, 05 Jul 2022 10:04:24 +0000 Received: by outflank-mailman (input) for mailman id 360712; Tue, 05 Jul 2022 10:04:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8fPq-00033h-93 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 10:04:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d65763c1-fc49-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 12:04:20 +0200 (CEST) Received: from DBBPR09CA0006.eurprd09.prod.outlook.com (2603:10a6:10:c0::18) by PR2PR08MB4828.eurprd08.prod.outlook.com (2603:10a6:101:1d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 10:04:17 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::54) by DBBPR09CA0006.outlook.office365.com (2603:10a6:10:c0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 10:04:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 10:04:16 +0000 Received: ("Tessian outbound 514db98d9a19:v121"); Tue, 05 Jul 2022 10:04:16 +0000 Received: from 74025194f98e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A6FC3227-28A7-49A0-A6CE-94EFA22EF21A.1; Tue, 05 Jul 2022 10:04:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 74025194f98e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 10:04:09 +0000 Received: from AM5PR0301CA0010.eurprd03.prod.outlook.com (2603:10a6:206:14::23) by AM6PR08MB3558.eurprd08.prod.outlook.com (2603:10a6:20b:4b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 10:04:00 +0000 Received: from AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::bf) by AM5PR0301CA0010.outlook.office365.com (2603:10a6:206:14::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 10:04:00 +0000 Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT053.mail.protection.outlook.com (10.152.16.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 10:03:59 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 5 Jul 2022 10:03:43 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Tue, 5 Jul 2022 10:03:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d65763c1-fc49-11ec-a8e4-439420d8e422 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=n9lcCIqjztMuK1iIqL/IvxZBIIa+UaxJXRkuZQ197aSaGNbk3ICRsvU0YuBjI7FTJCIQwWkQecxs5b76YpUP4kGXJMl3kwAiMXlztNQDvQKmVqPU9cGFnLcDL78snumwxH406ZzpKSOnaYznkLygWDMF5jIF2/FzH1dv++Hhq+RWS6w6uPGcSdPCwcIds5ihqt693am+5jxyhYR+GeR/Tol3buDcX8OSJo5nT0SLUxJi8c/++gJwxVaMfOzUQXg4cESP77oM0ZSGLcBu2dYDniz1+J+Oqja5AOcw+s07RzF/DICYK2wCzPWD/KnqSzrQCoSGwokbAC0RvAqA6mGPFg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KKPQDlzSmhq0Bdz4XcoxAsKDlVHZsxrn92qhJlKA72c=; b=ONz1+dPVXtVJ0rtZmxxpf+01lKvDzJsoIR/U9fB7M64c5+7rskXyy1hb7ZWrJevxqh6535h+WAHtMJGlp7tXedtb9hPLbLsTzIxxaIm1va6w9PpAOEF5OuoQwtBHZWz0YazbcI0Wc4BADiXbZ0TLL8tVxshomSznHIGxlwq2Y7N07f6Glduk7PaFIKHon9CjsvnEHwnxGoX3xCPVkYY2oJMeTIN7JxOunNVdsHU6EKOu8QTUf2QTy+Q3AMzh7uAOD+x7az8UleyuCixW49tonXUVlw0Oi8EsE/KaXlcmO1hbrWq0/GLDR8+KVpciLZrc7uyjw2V5X9N7KtTZnTjcRQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KKPQDlzSmhq0Bdz4XcoxAsKDlVHZsxrn92qhJlKA72c=; b=YRbSBeq2ILsZCkf7Anc3LNE/h5sjtlf6jB61TBHmWpS2d8uyYdXqRiSROsv5n0+Ns4PtydC2I9E0/+a3AU290nRK/6B2YvuJ4wJ5cl8BJ60ZibeNG4ngVOdns8qa/Kw1LIh3yl0gndwyUjn7npA9qwlrKk8rD0nK09F0tldBX1g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: fcdaf3c7d758c7b5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPesk1+1WfiYKYMcgLTA+PjNjj/HfeeF+CmPTxgq7uXjZaeA+8N/vFssjnzwn1IOTTlNZQYd68/y/XklnqiLLvrFajChtVQWOA/ig+nBHjMWWQdKaf23g2rUIOxQIBv+psnLy61rayQErDsUIvn4RsyQmo+I1FncvA6J36hv2Mg3SGYqMl1mZCb3SucLGh/xK2+slV7I3YR1IzWoWYck6MzbJE8j/GY9CNWUGl8Yw7N/79u+iB7GTh29XUwSgCtOmEHJKP5SVmhlsoqBUgtbSKlvAIX8sUWMe8aPiymZPCv1seNOEdKR2EXEcyPyQIaYeDE6R+XgskxoPbK/cUqBpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KKPQDlzSmhq0Bdz4XcoxAsKDlVHZsxrn92qhJlKA72c=; b=Ga9J379CChXBJYyqLJ2hy0KBAAQte1FDFBsPiH1391BCqlbn9cJTSFCBDUaMabbxkOsiimQB8SYZZcpdjZIllstbS9iPVAupMM1+z5+Mjr6EmbWPfudMd92iaHbt742D9uQXIS7TbKJbzZG9cVoiXQd4jha7XonX5njeIY4s5/DAhPsD82phHZzlIxbj8cN+4d0C/PvwKCUi2B5mESoHcTVgObS6gTF85L2LJYUrIAUOMzBNxtMV8/TDH/JY8FV5wVoZLde2IZvT9RiqmtVz2yJbayLh187l2ZTmnSOGhbz3GoxaWF75VY+WrEbQ0WYD8qP6fh/vA0Zv42JXRnMlHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KKPQDlzSmhq0Bdz4XcoxAsKDlVHZsxrn92qhJlKA72c=; b=YRbSBeq2ILsZCkf7Anc3LNE/h5sjtlf6jB61TBHmWpS2d8uyYdXqRiSROsv5n0+Ns4PtydC2I9E0/+a3AU290nRK/6B2YvuJ4wJ5cl8BJ60ZibeNG4ngVOdns8qa/Kw1LIh3yl0gndwyUjn7npA9qwlrKk8rD0nK09F0tldBX1g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Jan Beulich , Julien Grall Subject: [PATCH v3] xen/arm32: avoid EFI stub wchar_t size linker warning Date: Tue, 5 Jul 2022 18:03:19 +0800 Message-ID: <20220705100319.1298197-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: ab4cdd91-317a-48b2-8a3f-08da5e6db899 X-MS-TrafficTypeDiagnostic: AM6PR08MB3558:EE_|DBAEUR03FT021:EE_|PR2PR08MB4828:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C+zWwGp4K3bDyERm4jnjb3onsWIAKkolOgrat8Us2xsPOtab49SjMRCbW/K0ZMvXCuQm2F5Blw5bmZhXg2EYrjsJK/58S2CCII79SGartgAoz7F7RR3qf3GZk2iZ4GRd0nrK/8ZLMh6bVDKEFBDRoGv9vLuADRVmOMOojRC55eC+C5v8uEVIxMvdjxnvX6z2CSIAkcjRmMNAzpviQiDYStP7Sjkf8HxY6DIhkFFnvmdngcB0FCOpZ3qDs8lx0o2B0CV7Vj39OmawsuYFFsDwTL8gAsGg6gBD24GLgFNas6XSMStpoYdQSdQe5Hk44diqc+5LUQDFMda5m0mbIqJiddmndAoGmIjTQBBoGMekDbOG2m0T47bUJc6jysLxT2sTjwOQwmOtbAET8IERckD0Rv0BXa4qe6MFYA3a5IGrLXx+zP/1SOX7Z5RcHTsuPOaq+gciipnwbkV4TTWKGdrinUpUTg8gZ/mrGujd8QAWA67VssfhHhiIMEH94MFsUO5AG+ni9h8Uk5/uYAJ/3Huxqw0CFXKgZSUBRKAT6iXupf1+KKQiGEP0UbTVGHEg5aUne3yX4jEy7OvILcogMCFtOz0WAzFj/tZgzaLd6FYllQ3l3YmVtdu0tYBhO+O4GvMpi2A0P4JlO02ESmvbjDC7RHHnCjmEiWGTgRggcopdQv3R4NzcVpBmV687dMRlcck+pqrJv2HuSmmM/oJu1WVWG4+wuxZNG66lrPpd2ad++7MgjtTJWyrsHgDY5aJFGSy1J+YCG1OHSjPrl5qExY9diomLlR4n6s7DUg7r6AIzc39eWt6wQNNNOJvCGt7q+JblvNc8fRSOiYvoGy34EuOtAbvHU1MtDdMMA3e+t5whd60= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(40470700004)(36840700001)(46966006)(478600001)(7696005)(356005)(40460700003)(70206006)(5660300002)(86362001)(44832011)(41300700001)(8936002)(2906002)(26005)(36860700001)(82740400003)(81166007)(6666004)(426003)(36756003)(336012)(47076005)(82310400005)(186003)(40480700001)(1076003)(2616005)(4326008)(70586007)(83380400001)(8676002)(316002)(6916009)(54906003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3558 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ae6aadc6-a369-4f3e-8b39-08da5e6dae49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GOhFd3RYbJFr5xklPe49KoZ3n6T1Ddqa0R3ErwMKIoyAohr7bDNKqU78j0Qbn6c8LTC3ixr332MyNCqbuznbJVdxPpPujT1Q9MpD8qBOZdIZ1E2YMBXhZMfU0df6gT9khzCfo6MzQN1RndrmzZvox6Xw+/3h3G2MFGNAZhLCGffV33nX0CYETODXfqHrzEdE6L4/ZzOxvg3b4GblLRGFIf/rogNKT40t1laA99pi9UQcSk/RKJL0qpuoXCGJTq3jInufbKqyK2fByUDZPHOyBIe8fdbmpKLkeYWjfObZ46zXbR9mnPR0Kie8phhjRhzKTsPIF7JQ4+790Fu3GwrLBB/d6yamAE3yNmu4cek0ZevTsXcR+C5DyBhyz1GMph6atOfHpVnX2iNZY+85VNSqKrCPimMLzmvcIyKiydyognjM5I4RE3EiF2T8uPql9MSfeCoyaeyMFjOnU5lKemWRAWbNwNfxBBRe0nWSo79PsuiZXHG0lw4LS755ADOkcb5j14stGMHt3JcMmRdVBPjVAjfr+ZWCwRXs4E0QGZajpghVqozLeuEaUbB/x731sZwTR6as/W6kwxD9Xm5LbV/70a1dsmBlwm74oNIDkPPOyws2JaUWs4FKfu+Ds2CE+9W7hpDORwF7c0WsoUJtrYRxhSWE5xk7v3g7bVhPcK9Zt71g6veLqqMz30HGAou3eaFBIEej1eryiptvg1rQlker34v7fjsfOxH6qrSSs7vE+Duft0sIrr/0/nh8vYtpZXmk+Z2T1Hcm1J1c8vGHdlIjbjYEdk5YXZDIE4tZtgEUL+atYtQ7oxEByE91QG0e/PGg X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(346002)(136003)(36840700001)(46966006)(40470700004)(82310400005)(8676002)(4326008)(70586007)(70206006)(81166007)(1076003)(478600001)(186003)(6666004)(7696005)(41300700001)(2616005)(107886003)(54906003)(6916009)(82740400003)(83380400001)(316002)(26005)(47076005)(86362001)(426003)(336012)(2906002)(8936002)(36756003)(36860700001)(5660300002)(40480700001)(40460700003)(44832011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 10:04:16.7862 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab4cdd91-317a-48b2-8a3f-08da5e6db899 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4828 Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall --- v2 -> v1: 1. Adjust title to add arm32 as prefix. 2. Update description to remove gnu-efi. v1 -> v2: 1. Use CONFIG_ARM_EFI to replace CONFIG_ARM_32 to gate "-fno-short-whar". --- xen/arch/arm/efi/Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/efi/Makefile b/xen/arch/arm/efi/Makefile index dffe72e589..bd954a3b2d 100644 --- a/xen/arch/arm/efi/Makefile +++ b/xen/arch/arm/efi/Makefile @@ -9,4 +9,7 @@ else # will not be cleaned in "make clean". EFIOBJ-y += stub.o obj-y += stub.o + +$(obj)/stub.o: CFLAGS-y += -fno-short-wchar + endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 10:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 10:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360771.590185 (Exim 4.92) (envelope-from ) id 1o8gEq-0001Ut-Sl; Tue, 05 Jul 2022 10:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360771.590185; Tue, 05 Jul 2022 10:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gEq-0001Um-PX; Tue, 05 Jul 2022 10:57:04 +0000 Received: by outflank-mailman (input) for mailman id 360771; Tue, 05 Jul 2022 10:57:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gEo-0001Ug-Q1 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 10:57:03 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31e15cfd-fc51-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 12:57:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6553.eurprd04.prod.outlook.com (2603:10a6:10:10f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 10:56:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 10:56:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31e15cfd-fc51-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GsvTRT4lemodHtUSENUsxZKxgysVU9BW1qdQnwgfk4XrLOxiKL7TT6RCpEdLwTf1OadloSRQkkkrAs0w3i0IeEfrbTeXPh8jx9b05LZR32vCbJ4Y8DDIZKTRPRAuz0YAprOiFNg8ESbAxcW4kohPgO3yIsuPtA/0X5HWdskhQXK4lrHficFT/CTd6or4Jb9u/+PhjNG9Hfvxuom1L0b7QEcZm7V7REyMZHWq8OYCm1lQQZZjMwuXB1uA6G6SkXDkPfhhCZZ+oEyhWjOlenaxSsVOFXvrwhwdGoWyed4Nka6w1a7aNGcuwaKWewE6G9A+Ko2zVxkzg77gxfWNqROj+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9YsDQetN1expk9M0MJKOywrzAPpHOWaDrCoMJc3+6nU=; b=j3lB8+6y4vpaTKP47RelYqZ7RR+9ZQzAbfH8TfwE7WtLCjhp8dritWME5iX3TP62Hzux5D79tPNwK3D4ZsxN83b1d5iMH9zvjhxI4Dq2uGw9iZPvjxxXkSb5wj1aJat4aZ2v+6OLOf6XmubAVkXIrVQhjvQTR+fJI+BiPcdyM9yF++xWtF/rAtufzRq+W1+Xx7gt97ffoH9cQcaSmot5Bdq5xYFugupA0/86iSQq16sRgYR5BtGFqOFK0n1Mc42wbLHpgECU82v5Y372acAKA5BRs/vJ5MQTZWWXKN9zzIjHtrGYcJkXTo4G0D9zz1TNsvn6YKhsJam2VsW4gEUHQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9YsDQetN1expk9M0MJKOywrzAPpHOWaDrCoMJc3+6nU=; b=sRJEEhdl198J73pE2PQDtAinK2zWS3ZNtpsd/U1khHi8SbCJBzqDltbsaEb0jUpByBRKHYpPGVFjSdPVjP7+mB44soAf18f/nDZilAM3nOSG8ajdgJ49vx4w6jPnxNnpVAv9cUPB+uaBNIeM3DZO5B+Ujg8PE0wj/6weLiBMRc4DqZyQLWGFXvFOiSABkMMiUBUP0pkXIPJZVQUUnSGTdbxfJNDj5gy+ZnFQ2iDXlIXRfz4M6lvR4i+5Ya5U2B4oJMER1iqpBI7yDGZioDBAcrCLkeoFcjDZf8ej0iM+GLMD3K3xmUA5NDaArtwN4W/n7U5Z21vrkrEe+A4KQZx/xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 12:56:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> Cc: xen-devel@lists.xenproject.org From: Jan Beulich In-Reply-To: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FRYP281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be42e38d-6de6-4c7b-397d-08da5e751486 X-MS-TrafficTypeDiagnostic: DB8PR04MB6553:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UNTNc/vvidKniOwHyTAEa5LTJLwbAojBc4s2G9fI/CJC+wvGyg4w4++bjdt8UXyZ5yvj+m33/PF0CW4U72YVfP3il5jsaDHxoFEjMMWJ3vuVC0t/wx5gLOKPG6H4qzHK30NG8YnWsZHioxM1KZkIfUq+1Z0XOQjyDVpeb+ynYmlF3GGXEgdOMQhtND6K94rfCpM3WqrFJYMexQBNKMDGvceGMLLBK6vazJtfSb0YF/rXIUySg+ZiI8GRYyELkaXL2MoX7OtBj9fkHcA0ZgShUIkzM3/U35q2lnAcOJ0p1h4iVitb9C5KJ9maUk+AwpFIZyt8vuoHKnp2vYZExvx7cwRqq3NrMo6rjqTJs9vS+gUOI1Ag1WGgOJ6UIZrFN7RwpbOnVOlUPwriV9K7LeK0H1SfKXK+WpO140XvXcTmO7ltyeFx89WTg8NvVXQdiCOIkP5FdEv5k9V43UugIo1nGdJp2/fFzhxvezBUHA5Cp0Za+rhs7ZtI451hGsHslESQbR/Xf42fXfUnhQAEO/0bVJYJ+L5n0sA5/vVczDW/o4HF+920fYV8XNvXFXPLr+01zmPDzjbs9rXfBYZUROkoFNUGXuoDOzomzW/0ZXOpQaXH1NfBE0+6MY65TBRSGuUmUMSxh8GnWq5u/2B/xtf91zvnM+l3j5TX3gKcNPdDg8AkqrzvH0EpLwnU1Tdqxq2AXq4Eb9fbSqEQmnkRgQmKoCF9g/2O3bFbyCxkzEffutnXq5k8cTX6Ilqf8Ja7G8OxTgLpUNUh4X1MQHy21C9Yz/vwVWNUSKcUadNyL7CASPhPMYSPCoc5bdCxCYb3EWIeGROSHoXcxU6jFJNgQJWPtAA0pj103sEKeQLZr0yiG9l/bTs9Itnya874tVxUuSx3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(39860400002)(366004)(396003)(136003)(6916009)(316002)(26005)(41300700001)(6512007)(6506007)(53546011)(478600001)(966005)(6486002)(2906002)(66476007)(66556008)(66946007)(4326008)(8676002)(5660300002)(8936002)(38100700002)(86362001)(31696002)(36756003)(31686004)(186003)(83380400001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emJNS2d4UFpiNW9scktZRFNaRWNQNHFvbmxuMUQyWDdYbDlabHFjejNXbWdU?= =?utf-8?B?UXA1MnRKT0dMeTZIT1ZLYTViSXVVa0p0bTJsLy9rbC9LS0E5RHJSTGd1eUZQ?= =?utf-8?B?bmFIcmZnMVNKdmVpdk9LdWdicHhQeCtxMkV4eFN3VUExNmZNcTQ0Z2N3T3pU?= =?utf-8?B?NTJlQ2E4Wnd2L053MjZ3MDZYeWlZRndwdWhWWHljNVNpK3dxUmh3R3RZNmlN?= =?utf-8?B?MFAxbWd4L0JDUk8xeXFtMVphdlVWTXAyYWhjZ2d0djJOYk5VR0NlSzRuaVFO?= =?utf-8?B?bzF0M1V4NXkwMU12OXNnUUEvT0V3Z3Z6OUdLZXBnTHNYZG9YdUJTN0Fua3E3?= =?utf-8?B?MHpldmhDa0x0VDU2ZWhqMzZMMkhPV3JoNjkwTEFVTm1NR2xQeGxhZDNwaDJ3?= =?utf-8?B?TzhTSHk1bGdYVXZXUWJFM1lYRHVHaFlheGRYRUhIUlA1YkxoZUxjWllubXhq?= =?utf-8?B?RmFIVDhFZDJDYXorSXJrNDVpemt4NTB1RitNK0pYQjVHRit2MmJmQ1FkdEMy?= =?utf-8?B?dWlINmt4eDQyWjRVaGU0MTNUZTh4TWFMMVpUbzBCMHpyc0FnYmpJSzcvcEUy?= =?utf-8?B?Ui9lS3E2RVhrQzl4VCtaV29ZUDlhNHBPd0pEUGo0aXFzUnBobHZreWc3dkht?= =?utf-8?B?OVNvT2w1bkk4ZmZnQTR1SE9OeXhyQVFocFV0MVdCT0tEV3Q0VmJmdlBVTzNR?= =?utf-8?B?bjFEdDRnSms0cnFxanBEaFZOaDN3ZlB4YytPQVhKY2w2L0tFd1h1azQ5dkZD?= =?utf-8?B?RjFKM0NndXNWSktYT2hidGt6bWpONXJJUTlrZllxSExnWm1nd3ZUVlExN0ds?= =?utf-8?B?VFc4RDVOV0M3aGpsbllQdzJIcE5LblNPUEt4dXRsWTU0QklrdjdkY1puMUlH?= =?utf-8?B?R2ZvZi9FQjdHL1ZidHJncVlIa0VTSjVuOWMraVoybXNaWWIxU1NWaEJrQ1di?= =?utf-8?B?NXVxRXhMd2ZpNXY4WGRYNHBJUitkT0taR3F6Y1ZQUG1rd20rRUpONithT2Yy?= =?utf-8?B?dkFoR1d0YW1wZlA3Yy9GV3Zjeit1Z0hVZStEanZvSWdrMElSRm1VWHdzWGdz?= =?utf-8?B?eG9zcW5jaGRSSzVWLzVla1IyclZlK0xudVNWTk5YZXZDYlJNbDZ5ck1CY01U?= =?utf-8?B?SFQ0QnFYRXRpNEp1aVdmUmY5UVcrb2lYVlJhUU1lcytxYWdHM1dNR0ZvMUJj?= =?utf-8?B?MGNkMTNnQ0R3bVVSUXprSmJyaDBmVnp5eS81REVtSk94V20veEs3bmpCMjRX?= =?utf-8?B?UU50MVB3UFU4MmowT3VXRndHQ2JnRi9GVjdqdllWN1pwYWRjeXRVWjdNYUtP?= =?utf-8?B?dEdRSEpIUXBEa1NyTGRHQ0JEUDhDd2ROR3VFbklaZXUyY2pOMGxWUjQ3WWwv?= =?utf-8?B?WVJpN0ZQbnNIWlg1dWZNL0NMWkJiNUtMZG1sZVRKTVEwcjhQcW50aXcvVWw4?= =?utf-8?B?NkpXSzl1MVphMVhLMlRidVdFNi9Jd2p1ck12Q3p6dzNmc2daenMzRDg5cUsy?= =?utf-8?B?ejdIQTdHdk5YMzlPVkUyQ0xlYTlNOWZZK2ZQclE5Y3lKMUdIOUdwVytmZFdn?= =?utf-8?B?QmxSMzZMa3Ezb3QxMk1nQ21SV3dmN0NyaExKSmNJS3lZMTZSbmlScU9za3hh?= =?utf-8?B?bUlRYy8rU1NPR0RsNnNaWmV0V3BEL0lmVHF2QnBNQXR2TG5NUDBIQkFtelds?= =?utf-8?B?RWtBQnM5ait3aFovR2VoOXNXNkZwMC8wN2o5TzlxS2FoTXNDRU9mMTBaNzJU?= =?utf-8?B?cVFEcnlSY3ZaS3Z3RkFPQlRHZnZyZk1pNXUrTFh0NUIxMXAyMExXMDlTUFVl?= =?utf-8?B?SktyMWNuK1pYZjRXd3puZFFJbE43b0hpZkN0T25YQXdJdXJKWVRQd2dhM2VC?= =?utf-8?B?UUlrWE5pU29RTUZqd1duNVBJOUF1SnRNaHlkWmduY1I4OU83WG42U0kzU2dB?= =?utf-8?B?b2h0MWVra2VkMmswVnV2ODRuUUh3ay9FVEJ0RWtiektLRE4ydmgvZGlNNDVl?= =?utf-8?B?REdOTHZwUGpDbmVVenFiUWhEbmltSVpVZFkzVG1NMUd1aTFKakhvQ0dzc0x0?= =?utf-8?B?ZzdqeXVzNjZETWlMSWpBc3FZSTYrUCswWXJST1U3bGZ5YUgvMEdwOGNuT3g2?= =?utf-8?Q?ai2zRWHYnrbq345OSGfZjHIzz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: be42e38d-6de6-4c7b-397d-08da5e751486 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 10:56:57.5809 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vYeA5M/BIuB/eI72RgTAkgc8vj1Oa/JhiwkBZyvwFkcmVsKFRMZdboT+YoZECrizGlB56bxV+jYleTFtB6KXWg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6553 On 24.06.2022 20:17, Demi Marie Obenour wrote: > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the ESRT shall be stored in memory of type EfiBootServicesData. However, > memory of type EfiBootServicesData is considered general-purpose memory > by Xen, so the ESRT needs to be moved somewhere where Xen will not > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, > which Xen will not reuse. dom0 can use the ESRT if (and only if) it is > in memory of type EfiRuntimeServicesData. > > Earlier versions of this patch reserved the memory in which the ESRT was > located. This created awkward alignment problems, and required either > splitting the E820 table or wasting memory. It also would have required > a new platform op for dom0 to use to indicate if the ESRT is reserved. > By copying the ESRT into EfiRuntimeServicesData memory, the E820 table > does not need to be modified, and dom0 can just check the type of the > memory region containing the ESRT. The copy is only done if the ESRT is > not already in EfiRuntimeServicesData memory, avoiding memory leaks on > repeated kexec. > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ > for details. > > Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich with one further adjustment: > @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop > #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ > (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) > > +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) > +{ > + EFI_STATUS status; > + UINTN info_size = 0, map_key, mdesc_size; > + void *memory_map = NULL; > + UINT32 ver; > + unsigned int i; > + > + for ( ; ; ) { In reply to v7 I said: "Nit: Style: for ( ; ; ) { " which you've dealt with just partly. This time I'll take care of this while committing. Also for future patches please remember that having brief per-revision change notes are quite helpful to reviewers. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 10:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 10:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360772.590196 (Exim 4.92) (envelope-from ) id 1o8gF9-0001o5-4w; Tue, 05 Jul 2022 10:57:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360772.590196; Tue, 05 Jul 2022 10:57:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gF9-0001ny-1r; Tue, 05 Jul 2022 10:57:23 +0000 Received: by outflank-mailman (input) for mailman id 360772; Tue, 05 Jul 2022 10:57:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gF7-0001nW-GQ for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 10:57:21 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3d858c8a-fc51-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 12:57:20 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1o8gF4-0004up-Rj; Tue, 05 Jul 2022 12:57:18 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d858c8a-fc51-11ec-bd2d-47488cf2e6aa Message-ID: <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> Date: Tue, 5 Jul 2022 12:57:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> From: Thorsten Leemhuis In-Reply-To: <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1657018640;cde10339; X-HE-SMSGID: 1o8gF4-0004up-Rj [CCing tglx, mingo, Boris and Juergen] On 04.07.22 14:26, Jan Beulich wrote: > On 04.07.2022 13:58, Thorsten Leemhuis wrote: >> On 25.05.22 10:55, Jan Beulich wrote: >>> On 28.04.2022 16:50, Jan Beulich wrote: >>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >>>> with pat_enabled()") pat_enabled() returning false (because of PAT >>>> initialization being suppressed in the absence of MTRRs being announced >>>> to be available) has become a problem: The i915 driver now fails to >>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I >>>> located the induced failure), and its error handling is flaky enough to >>>> (at least sometimes) result in a hung system. >>>> >>>> Yet even beyond that problem the keying of the use of WC mappings to >>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular >>>> graphics frame buffer accesses would have been quite a bit less >>>> performant than possible. >>>> >>>> Arrange for the function to return true in such environments, without >>>> undermining the rest of PAT MSR management logic considering PAT to be >>>> disabled: Specifically, no writes to the PAT MSR should occur. >>>> >>>> For the new boolean to live in .init.data, init_cache_modes() also needs >>>> moving to .init.text (where it could/should have lived already before). >>>> >>>> Signed-off-by: Jan Beulich >>> >>> The Linux kernel regression tracker is pestering me because things are >>> taking so long (effectively quoting him), and alternative proposals >>> made so far look to have more severe downsides. >> >> Has any progress been made with this patch? It afaics is meant to fix >> this regression, which ideally should have been fixed weeks ago (btw: >> adding a "Link:" tag pointing to it would be good): >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ >> >> According to Juergen it's still needed: >> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ >> >> Or was a different solution found to fix that regression? > > No progress and no alternatives I'm aware of. Getting closer to the point where I need to bring this to Linus attention. I hope this mail can help avoiding this. Jan, I didn't follow this closely, but do you have any idea why Dave, Luto, and Peter are ignoring this? Is reverting bdd8b6c98239 a option to get the regression fixed? Would a repost maybe help getting this rolling again? BTW, for anyone new to this, Jan's patch afaics is supposed to fix the regression reported here: https://lore.kernel.org/all/YnHK1Z3o99eMXsVK@mail-itl/ Side note: Juergen Gross recently posted related patches in this code area to fix some other problems (regressions?), but his efforts look stalled, too: https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ And he recently stated this Jan's patch is still needed, even if his changes make it in. https://lore.kernel.org/all/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ This from my point all looks a bit... unsatisfying. :-/ Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Tue Jul 05 11:02:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 11:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360785.590206 (Exim 4.92) (envelope-from ) id 1o8gJr-0003bN-OY; Tue, 05 Jul 2022 11:02:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360785.590206; Tue, 05 Jul 2022 11:02:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gJr-0003bG-Lf; Tue, 05 Jul 2022 11:02:15 +0000 Received: by outflank-mailman (input) for mailman id 360785; Tue, 05 Jul 2022 11:02:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gJq-0003bA-NO for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 11:02:14 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2066.outbound.protection.outlook.com [40.107.21.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ec568b84-fc51-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 13:02:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7688.eurprd04.prod.outlook.com (2603:10a6:20b:29d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Tue, 5 Jul 2022 11:02:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 11:02:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec568b84-fc51-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C8qiKw36X4HNoVASbHpuYgOUjigMd6FpueDc8l8b6QGyAGMEbmlNpQmY0gF9j7JmYdCRyY2hcJ4PKB/z5yE8rAWkHr+e9bJu5Sufbg00FxcDcAwzA2LjAiV7DpATzD/oEL4pn+tJHYnVVTX2ttj7ma/0bqiKDYvBLx52AVd67u1PDZQArDV12W3l9EqwIZkJZlkA8VP+4geSJvRoi/+mIfKAWImnFkyIeuZNRQqimeu/SgBbwuCgKjRzRhuxrMbJTQKfglR10bw6F9LzlBUdxCvNWzqZjagLfkDwA5HOBtw8621TZRXqxXAxgQ0N3qiwUJpOb7VebfZ9rMKiiTkylA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AYH1xbiMFY1SnMBh6dliIztJ1za5epjTdSfp6gjPJvY=; b=P6ASlxXDZmqMv9buIcJWkMTBlZX+NaD59M6I/gUnyWxGU04HE/mdNlLyNbYb7Bb6DOPHCzo1V3gCt/UBfuX+icEUzveGQ9G2cRV5tISuHk0O3BSM+E0KfHQrNGRFyZ6M10HFGEkyXAd1bDKsfJEt8iXklNGAOvl+nK8a4wFtTkLmta1QzBtWdPAPVVy490gcXu2o+lBS0B3xMgEuOpVv7XcM7HDyMO40XU7eEcAul6UZ4i8xSMgCsEVEIfHAElnjp5+b6H4S4dRBRRSk+tXTSbMRZ+4wngoFrGT931HLj67ChVs3p8zP5A+i1o1qlufj/4dYagrxhuvFo6NDVKWS2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AYH1xbiMFY1SnMBh6dliIztJ1za5epjTdSfp6gjPJvY=; b=qBChq/9HRGZlOAmRSO10GEnRPMA3vbTl+mLSGsoG3fwD4SAbLk30FbDNLqQYj0BP85rmKcWvzacQ3+DWiiZpDNBRUXUhr0K+uDU5oKt2JbYEqasIVg2+tYfZSFEhQziUQYdlTIcg42zc30o9ENO/knV6p3ZdT4jY2ZYpdTewtvTJOy51AS5vA7t0jtc1JODgAYIJZjDrgFQUj528A2RJbOr5fxOxpz2viGSVFjPtWHpwGEJNXLZL200ijS8piaykBAdnMfCE8UM1GSNJ6DOI6u9YoAuQk8jX0oa4WH494yvGJR59FSTswGgRqL3pS/dKdmvoTVrlZeFipAMF+uoiwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 13:02:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Thorsten Leemhuis Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> From: Jan Beulich In-Reply-To: <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR02CA0006.eurprd02.prod.outlook.com (2603:10a6:20b:6e::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5d4b6885-7796-421f-2b01-08da5e75cf26 X-MS-TrafficTypeDiagnostic: AS8PR04MB7688:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I5jBSMg+jY3GH6Y2BfxaUTk10LCMT6sU3J8XiiIVc1RyRf2rDWsW97iCp81jNQN0xOSH8jd2TWrWCVk7tkCTP6gwaExnQaCWZWsBdemWjnHW2KrkUgCqaT0BOO6+//qmsxNCW69gsiTG9/h3xAGwgodbKwVP08Rht/GFX25BEnFqZXT/HWMjAHDsh/SOb6k9Un+rygaaXwJDRV9miBhAz7ZlbhyOs9vg9igA2QQpfQyvbRjtXW4snAlRF3kL+Khd2T4zcPTwgbAaEdlJ7EpHwPIL4TlfoXnanDaAXIKdtTYCC8QCah/O1lttozhIbbRs/t1LTWkf8Cy164Itn+n1iVBiWmewlR9saVlyFd/8ZldkkSP+DTGEwJiErzNPBiCpI57CnDw7PCToHUDnTP6Luw50mhqiDnmerv5Ak3ssjPwRmmbWbdKwYOpKVoVh36P1dHj3J5JxQu/0yCTriYL+AU/WRkOYKdG9kaqmwFOq9wp/z5i4ca/CqXzURXsD2ttxJPXYBXdju9Co0jwljuJA4ob9wBggTg7yvyFwuSWJMvRrt8UklHIhWqY1Y/yUFtYwEaSImwB9XbyPoM//r+AzFD58vdk14ZRRx1IrT/cldEyMTMLmNmhvYxb5t6HArbDgxSTL4cJrtYgza+PDRiYYxKYMi5+xaDD2zyOAkzP8D1JkM4wRe57zdzXHdEOfWH9Umu5VoKoKVMWw1Lul9nE+HvRtW3h1jQTG6mveHd7G33nufHv428b2K57YYHE+8kJ2eY986P81mOvneYiphNnKZ8pP3fTa0cu0cliZHvJBVpzsjQum9ocON+CjkcIKO+6hHNJ7f1CIyvU//c8qANRzTO9bOp/xWwAEs+YKkyfwkWAcUMiZhxYoeXW0561nnwlFXIsa6XLuPs+scOrweU5fqX+D5A9uj2ZiYORfPCwY+tY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(376002)(136003)(366004)(86362001)(31696002)(38100700002)(5660300002)(2906002)(41300700001)(7416002)(316002)(966005)(6486002)(8936002)(26005)(66476007)(66946007)(66556008)(186003)(54906003)(478600001)(6506007)(83380400001)(53546011)(107886003)(4326008)(6512007)(2616005)(6916009)(8676002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REtRWjdzY25uYlQ0NVJqakxDcWtnbktUVVlaNVByTVc1VXhzelBWUER1WmFy?= =?utf-8?B?RkczY0pvVmZxNTBKVVZVc0RhcTh6QjFZWWFJVHlOdGtnZmdhUkdGT3NXY05W?= =?utf-8?B?clRuWmdCTmhpZlNZdzJtOVRJNlJ0d2VSMmxkeVZUZ2QvUmRTR0ZYNE45R3Ew?= =?utf-8?B?SUZDR0FPSTd2S3NvT1BqdE92YWV6SFI4a0t1aG00N3VjTEJaWW0rNDBsVlIw?= =?utf-8?B?aU5MNm10R01jeHJVOUNtUS9OSG11M1B4M1J6KzRrV3BWdmptMk5SNi9HaFlq?= =?utf-8?B?czhuTE1VeEYzdDZuTkdYbFRWeGJKMW12K1IwMnpRakdxS1ZqbmhaeUFPSDJR?= =?utf-8?B?OG9jWTBYbW9Bcm9jWUF6ZWxMbHFnWmh4aE9ac3lVM3ZPeXVtcW4xdzlrZmtr?= =?utf-8?B?QzNxT1Q1ZkthUG5DMFJGOUhFK1pmQndNWWMzaEpFN2h2bEIyS2I0dmp6TFcv?= =?utf-8?B?WVhvMmhXQXpyQ0gvempyeEhzRE9ucFRmRWtjOUxYbWhnajZlajJRMFJ0a01Q?= =?utf-8?B?RXh0WGJodm5nd3kvM1cxUVJQOHY5OC9iZVJlTDR1Qk81SFUwNGlSaTllc3Z2?= =?utf-8?B?YUEzUkZHd3VQM2Z6eGcxOW51Lzk5Z00rbTZ1a2l3VHpxZFpybHRxb1JDTEFr?= =?utf-8?B?U3dBZkJBQ2xXTFlRTFBsbVQzNy9XMWpOY0ZnQ1N0VUFOUjUzSzRlZXVQZVJV?= =?utf-8?B?aDRDVlpUb3pVcUxKeDQzTkEzbjREK2xaMUN5ZEI5MHoyUjFTelBtYkpaL1R4?= =?utf-8?B?LzhTb25ubkRic2VQQmdBc3JDbzVtUzh1bVlYY1A5Q2NUbzQxbEMwd0sxKzFW?= =?utf-8?B?ZitrQ0ZVZGsrc0t1QTZuN3ZRZ2xPUFdrQXN5T1E5VUh2dzV0ODlYM2EreWRi?= =?utf-8?B?UGhRRk1oeXgvUUZ4OHk5aDFMMjI1T1QvOEhQL2dBQjkvWTJkclFmckxuY2FI?= =?utf-8?B?WWQxTEZnR1YzMlFCb3JqV1FZUWxXVzFOY3Q0RDhXZ3ZnZkRiRnRFNTdFMlJh?= =?utf-8?B?M1o5bFhYY3hvd0N2RHpGNnVVVmMzNktqWlRxRXRWNHFOdVBBaEZHaFR2SHlL?= =?utf-8?B?VFA4M2Z3Qi8vWVhiaVFITFNLYWFubXBaT2JyZmo0aVdOQS80OGN0R1lOTDNy?= =?utf-8?B?MTFXek05alRXMGo2UHEzUHVXci9mNmtkQjJlbFJOVnJNNk9OaHZYVk16MnNt?= =?utf-8?B?dnppQXdhUXRrRmNid1Zqc2ozdC8yKy9wNjNBeDZYWG1PR090L24yWnhPa3hh?= =?utf-8?B?eEYyaG9jTzd4K3pLUWZ0S084QWNtRFRZUjRuTW54dTdIUWdENlZTcmU3QlVn?= =?utf-8?B?UHJhMTFBeTR1aGM5SzhBRkJFeUdWa1JubGIvZG9TN1JYSUR2OVovSDhUTERz?= =?utf-8?B?c2hpalVvZVBGeUlJVUVXMmdOREFMVnBqZVpEN3lXZy9UVFlIZlFGZlNQd0tv?= =?utf-8?B?MkFWeGVTTmlFMEFac0RqVGVEazQ3M25ZdGZmVU5RRHBRelVJRmpHK3lUWjJy?= =?utf-8?B?MmZYaHZVZWVXMm5tdllEdDg5V1pFL0pSUVN3Q1VudnZOV2FFcXRwSXVCOUI0?= =?utf-8?B?WnBsZE1iTVRJY2xVUEV2eUM1R2ZGRjd4aXR3MHZxWkNxV3g4eUgyR1NWdzMr?= =?utf-8?B?M3d0T2UxTlFzSFZ2UXVvMDlHTHFxN3lWd3B5UFdrSnM3U21aY2F5SVJDNnpV?= =?utf-8?B?S3ExQkNRSUVHbTJUNnNHeVVGQitYQ0cycktibHFXY2xMYXV2ZUgxRDl6Lzg3?= =?utf-8?B?NVVaNHBPODFkQ0xtWkRGRURXczFHMFVKSHYzdmIxakorem5CQjVaRXJteXJh?= =?utf-8?B?a2tnN3hKUHVSRjg4elRsTzhaOWU2NmFRYjZrUHllSXdva1pNeEtqQ3VQUVd6?= =?utf-8?B?eVZaYS9IanZDWG01TlRjZnF4SnlWL3huR1ErSVhlOXBQTlBvdWdxRHRlY3hZ?= =?utf-8?B?WGRsTlBCOWtuVmJVaXpSNlhpWGVqSHlZbUJqWWVremRKMHNDWTVKWTZVZEow?= =?utf-8?B?Tmt3Q3ZZaDR0OFV6cThMM3pXbnRtY3MzdDNaN0Y2aHJZQ3Y5T3p2UUcxaW9V?= =?utf-8?B?TlNVbTNCdjdEekg3SGxUL2YxMXBVNnJUVS8xSHZsSkl4SElVS2JZbHNIZ0VT?= =?utf-8?Q?/7Dy0FWpOFnIyMKMkuCv4ddKa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5d4b6885-7796-421f-2b01-08da5e75cf26 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 11:02:10.6853 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ci2xg1HmWvDqFGPynUi1IphCiUmHvckIAiu3D8AuwtmUt0m2wGpthU4UKbdGUoKFJvZoFXzOPRMd5JhsPiKYAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7688 On 05.07.2022 12:57, Thorsten Leemhuis wrote: > [CCing tglx, mingo, Boris and Juergen] > > On 04.07.22 14:26, Jan Beulich wrote: >> On 04.07.2022 13:58, Thorsten Leemhuis wrote: >>> On 25.05.22 10:55, Jan Beulich wrote: >>>> On 28.04.2022 16:50, Jan Beulich wrote: >>>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT >>>>> with pat_enabled()") pat_enabled() returning false (because of PAT >>>>> initialization being suppressed in the absence of MTRRs being announced >>>>> to be available) has become a problem: The i915 driver now fails to >>>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I >>>>> located the induced failure), and its error handling is flaky enough to >>>>> (at least sometimes) result in a hung system. >>>>> >>>>> Yet even beyond that problem the keying of the use of WC mappings to >>>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular >>>>> graphics frame buffer accesses would have been quite a bit less >>>>> performant than possible. >>>>> >>>>> Arrange for the function to return true in such environments, without >>>>> undermining the rest of PAT MSR management logic considering PAT to be >>>>> disabled: Specifically, no writes to the PAT MSR should occur. >>>>> >>>>> For the new boolean to live in .init.data, init_cache_modes() also needs >>>>> moving to .init.text (where it could/should have lived already before). >>>>> >>>>> Signed-off-by: Jan Beulich >>>> >>>> The Linux kernel regression tracker is pestering me because things are >>>> taking so long (effectively quoting him), and alternative proposals >>>> made so far look to have more severe downsides. >>> >>> Has any progress been made with this patch? It afaics is meant to fix >>> this regression, which ideally should have been fixed weeks ago (btw: >>> adding a "Link:" tag pointing to it would be good): >>> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ >>> >>> According to Juergen it's still needed: >>> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ >>> >>> Or was a different solution found to fix that regression? >> >> No progress and no alternatives I'm aware of. > > Getting closer to the point where I need to bring this to Linus > attention. I hope this mail can help avoiding this. > > Jan, I didn't follow this closely, but do you have any idea why Dave, > Luto, and Peter are ignoring this? No, I don't. > Is reverting bdd8b6c98239 a option to get the regression fixed? No, that change is warranted. > Would a repost maybe help getting this rolling again? No idea, but it doesn't seem very likely - there have been ample pings and alike. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 11:16:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 11:16:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360792.590217 (Exim 4.92) (envelope-from ) id 1o8gXN-0005Hk-4G; Tue, 05 Jul 2022 11:16:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360792.590217; Tue, 05 Jul 2022 11:16:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gXN-0005Hd-1F; Tue, 05 Jul 2022 11:16:13 +0000 Received: by outflank-mailman (input) for mailman id 360792; Tue, 05 Jul 2022 11:16:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gXL-0005G3-Ue for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 11:16:11 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df9e933c-fc53-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 13:16:10 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1809E1FFEC; Tue, 5 Jul 2022 11:16:10 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 662E313A79; Tue, 5 Jul 2022 11:16:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id hzNoF3kdxGJ/JQAAMHmgww (envelope-from ); Tue, 05 Jul 2022 11:16:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df9e933c-fc53-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657019770; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TaWxCdjvaRes7WYd6QLi0mKZlR/DFE5akzRD/3c4d7Q=; b=tafgg8VIoYtJNLTJM9zO+BZhAdpEZjcPq4vTPCC5msgt80X6QpRwhjFvl/z2Xdb6wqH+AW xsZhiVbkX3KdqgLhAkaMee39rlsQOaBeSbYVAXpHNZepQqnnevMEyKuT0jKNGD7CIZnOkH pU7Etwl/pKP8hdq+R+w3XiAbMruByx0= Message-ID: <89608dee-20d3-e580-a47c-dfdfdd7e5064@suse.com> Date: Tue, 5 Jul 2022 13:16:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v3 0/3] virtio: support requiring restricted access per device Content-Language: en-US To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org Cc: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Michael S. Tsirkin" , Jason Wang , Stefano Stabellini , Oleksandr Tyshchenko , Arnd Bergmann , Russell King , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org References: <20220622063838.8854-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220622063838.8854-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YrKAGapgLp1zY4xUN1376H0w" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YrKAGapgLp1zY4xUN1376H0w Content-Type: multipart/mixed; boundary="------------jpSLB39kfCLZNXM8IIs95MDN"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-arch@vger.kernel.org Cc: Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Michael S. Tsirkin" , Jason Wang , Stefano Stabellini , Oleksandr Tyshchenko , Arnd Bergmann , Russell King , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org Message-ID: <89608dee-20d3-e580-a47c-dfdfdd7e5064@suse.com> Subject: Re: [PATCH v3 0/3] virtio: support requiring restricted access per device References: <20220622063838.8854-1-jgross@suse.com> In-Reply-To: <20220622063838.8854-1-jgross@suse.com> --------------jpSLB39kfCLZNXM8IIs95MDN Content-Type: multipart/mixed; boundary="------------CJCnuUWxe21ySz0VL0WYBQeV" --------------CJCnuUWxe21ySz0VL0WYBQeV Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMjIuMDYuMjIgMDg6MzgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IEluc3RlYWQgb2Yg YW4gYWxsIG9yIG5vdGhpbmcgYXBwcm9hY2ggYWRkIHN1cHBvcnQgZm9yIHJlcXVpcmluZw0K PiByZXN0cmljdGVkIG1lbW9yeSBhY2Nlc3MgcGVyIGRldmljZS4NCj4gDQo+IENoYW5nZXMg aW4gVjM6DQo+IC0gbmV3IHBhdGNoZXMgMSArIDINCj4gLSBiYXNpY2FsbHkgY29tcGxldGUg cmV3b3JrIG9mIHBhdGNoIDMNCj4gDQo+IEp1ZXJnZW4gR3Jvc3MgKDMpOg0KPiAgICB2aXJ0 aW86IHJlcGxhY2UgcmVzdHJpY3RlZCBtZW0gYWNjZXNzIGZsYWcgd2l0aCBjYWxsYmFjaw0K PiAgICBrZXJuZWw6IHJlbW92ZSBwbGF0Zm9ybV9oYXMoKSBpbmZyYXN0cnVjdHVyZQ0KPiAg ICB4ZW46IGRvbid0IHJlcXVpcmUgdmlydGlvIHdpdGggZ3JhbnRzIGZvciBub24tUFYgZ3Vl c3RzDQoNCkFueSBmdXJ0aGVyIGNvbW1lbnRzPw0KDQoNCkp1ZXJnZW4NCg== --------------CJCnuUWxe21ySz0VL0WYBQeV Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------CJCnuUWxe21ySz0VL0WYBQeV-- --------------jpSLB39kfCLZNXM8IIs95MDN-- --------------YrKAGapgLp1zY4xUN1376H0w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLEHXgFAwAAAAAACgkQsN6d1ii/Ey8f dgf9HGUvKWq5gvG8sQv3deiL+6OJosApTovIh1v8jrEiqfeQBmOitoLnVLxgCtmf0St06X0trCWo U3lZjAkEtLcKCEmhy+4wRW6uXl4TWieYFFJMycMfQh5eJj+IjcQtF7Zae0heo+JJynWw5t/qcFYS y5EFaFYFX5fAKlnZ4XRY0eAgH0UZDXJn+vEFHQ+4Ef5WcmKzQnPhZPNn8Mt64qYMU7vuy3KhsO+V QuhjKFCR58eqt0cBq4j/1a8k1f42DVaHdJouTXfF1eVD7Dr3K/KRQsfGTP5pj7EM6WxQQYL+/n7v xNyDSvmaDigB79VbVtcrOxorjiTB738EDIDxh6lcJQ== =nl6Z -----END PGP SIGNATURE----- --------------YrKAGapgLp1zY4xUN1376H0w-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 11:31:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 11:31:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360805.590245 (Exim 4.92) (envelope-from ) id 1o8gm7-0007xl-Ox; Tue, 05 Jul 2022 11:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360805.590245; Tue, 05 Jul 2022 11:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gm7-0007xe-M4; Tue, 05 Jul 2022 11:31:27 +0000 Received: by outflank-mailman (input) for mailman id 360805; Tue, 05 Jul 2022 11:31:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8gm5-0007wb-GL for xen-devel@lists.xen.org; Tue, 05 Jul 2022 11:31:25 +0000 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0046a6aa-fc56-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 13:31:24 +0200 (CEST) Received: by mail-ed1-f51.google.com with SMTP id y4so1514885edc.4 for ; Tue, 05 Jul 2022 04:31:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0046a6aa-fc56-11ec-a8e4-439420d8e422 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0mErTqv2k9WqU7agWwCCMwY4gUf/se24czzxygf3Mgg=; b=cmFU/hzDOnDqmckRX84NItiVifBNyPSfkpf6J/CD4QNjLT8Xyb1AGn1LxAUscSyh59 VOUTf01+CGPd+4jZIi1yySeEqKyimYv4IGwdl7OBp05+/NmC7B+vFsfEZFQB4Drz5CsU SaOeMk2GCyN9Mq6Iw5USRjf5Vj6sVZlm2ssQyhDj0CP0zv/m8o1vpQ++S46LGQLTbLjl HoigFiHDsdbnYdGcyk9NvKBuafec+E+tf9d4M2l0ToddEzymPVIb98NeaDzwoAEZvZ1p zsa+7vbnN1qdj9/bPxpX/eqLgUZwpzshQJFEYOAFydNTNq+qnPwMxRfITXSI92BXOMN7 D5nQ== X-Gm-Message-State: AJIora9FMEmsL13obWz/y13EGGe2vdUyLvV0k3TkEWI3H7x9rlq+hP2+ 8PW4RWXLHC/tvUXlPJBZ15+1xBh0aXeFKboAVms= X-Google-Smtp-Source: AGRyM1u7+xOMUqetg98xIfysF5Pd/b8S2BdoVtwwYaAv2CC+nZgDlV1ASgY6cR2VxTdylPCnDOyv6WhEkHC4GQRSxZQ= X-Received: by 2002:a05:6402:390b:b0:43a:281e:48fc with SMTP id fe11-20020a056402390b00b0043a281e48fcmr17011424edb.214.1657020684075; Tue, 05 Jul 2022 04:31:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Tue, 5 Jul 2022 19:31:12 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: multipart/mixed; boundary="00000000000042a25905e30d31b3" --00000000000042a25905e30d31b3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 5, 2022 at 5:04 PM Jan Beulich wrote: > > On 04.07.2022 18:31, G.R. wrote: > > On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monn=C3=A9 wrote: > >>> I retried with the following: > >>> pci=3D['05:00.0,permissive=3D1,msitranslate=3D1'] > >>> Those extra options suppressed some error logging, but still didn't > >>> make the device usable to the domU. > >>> The nvmecontrol command still get ABORTED result from the kernel... > >>> > >>> The only thing remained in the QEMU file is this one: > >>> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30= , entry 0) > >> > >> Hm it seems like Xen doesn't find the position of the MSI-X table > >> correctly, given there's only one error path from msi.c returning > >> -ENODATA (61). > >> > >> Are there errors from pciback when this happens? I would expect the > >> call to pci_prepare_msix() from pciback to fail and thus also report > >> some error? > >> > >> I think it's likely I will have to provide an additional debug patch > >> to Xen, maybe Jan has an idea of what could be going on. > >> > > pciback reports the same MSI-x related error. > > But even with DEBUG enabled, I didn't see more context reported. > > Please find details from the attachment. > > And nothing pertinent in "xl dmesg"? Looking back through the thread I > couldn't spot a complete hypervisor log (i.e. from boot to assignment > attempt). An issue with MSI-X table determination, as Roger suspects, > would typically be associated with a prominent warning emitted to the > log. But there are also further possible sources of -ENXIO, which > would go silently. Please find the xl dmesg in the attachment. It's with the two FreeBSD domU attempts so it should have captured some culprits if there is any... --00000000000042a25905e30d31b3 Content-Type: application/octet-stream; name="xldmesg_really_full.log" Content-Disposition: attachment; filename="xldmesg_really_full.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l582ovd10 IFhlbiA0LjE0LjMKKFhFTikgWGVuIHZlcnNpb24gNC4xNC4zIChmaXJlbWV0ZW9yQCkgKGdjYyAo RGViaWFuIDExLjIuMC0xMykgMTEuMi4wKSBkZWJ1Zz1uICBGcmkgSmFuICA3IDIxOjI4OjUyIEhL VCAyMDIyCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6IFNhdCBKYW4gMTQgMTU6NDE6MzIgMjAxNyAr MDgwMCBnaXQ6ZmY3OTJhODkzYS1kaXJ0eQooWEVOKSBidWlsZC1pZDogYzQzZmNjNjlmYjVmYzli Y2QyOTJiMzFiYTYxOGE3ZDIzMzVlYzY5YQooWEVOKSBCb290bG9hZGVyOiBHUlVCIDIuMDQtMjAK KFhFTikgQ29tbWFuZCBsaW5lOiBwbGFjZWhvbGRlciBkb20wX21lbT0yRyxtYXg6M0csbWluOjFH IGRvbTBfbWF4X3ZjcHVzPTQgbG9nbHZsPWFsbCBndWVzdF9sb2dsdmw9YWxsIGlvbW11PXZlcmJv c2UKKFhFTikgWGVuIGltYWdlIGxvYWQgYmFzZSBhZGRyZXNzOiAweDg3YTAwMDAwCihYRU4pIFZp ZGVvIGluZm9ybWF0aW9uOgooWEVOKSAgVkdBIGlzIHRleHQgbW9kZSA4MHgyNSwgZm9udCA4eDE2 CihYRU4pICBWQkUvRERDIG1ldGhvZHM6IFYyOyBFRElEIHRyYW5zZmVyIHRpbWU6IDEgc2Vjb25k cwooWEVOKSBEaXNjIGluZm9ybWF0aW9uOgooWEVOKSAgRm91bmQgNSBNQlIgc2lnbmF0dXJlcwoo WEVOKSAgRm91bmQgNSBFREQgaW5mb3JtYXRpb24gc3RydWN0dXJlcwooWEVOKSBDUFUgVmVuZG9y OiBJbnRlbCwgRmFtaWx5IDYgKDB4NiksIE1vZGVsIDE1OCAoMHg5ZSksIFN0ZXBwaW5nIDEwIChy YXcgMDAwOTA2ZWEpCihYRU4pIFhlbi1lODIwIFJBTSBtYXA6CihYRU4pICBbMDAwMDAwMDAwMDAw MDAwMCwgMDAwMDAwMDAwMDA5ZDNmZl0gKHVzYWJsZSkKKFhFTikgIFswMDAwMDAwMDAwMDlkNDAw LCAwMDAwMDAwMDAwMDlmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDAwMDBlMDAwMCwg MDAwMDAwMDAwMDBmZmZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAwMDAxMDAwMDAsIDAw MDAwMDAwODM1YmZmZmZdICh1c2FibGUpCihYRU4pICBbMDAwMDAwMDA4MzVjMDAwMCwgMDAwMDAw MDA4MzVjMGZmZl0gKEFDUEkgTlZTKQooWEVOKSAgWzAwMDAwMDAwODM1YzEwMDAsIDAwMDAwMDAw ODM1YzFmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDgzNWMyMDAwLCAwMDAwMDAwMDg4 YzBiZmZmXSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODhjMGMwMDAsIDAwMDAwMDAwODkwN2Rm ZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDg5MDdlMDAwLCAwMDAwMDAwMDg5MWY0ZmZm XSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODkxZjUwMDAsIDAwMDAwMDAwODk1ZGNmZmZdIChB Q1BJIE5WUykKKFhFTikgIFswMDAwMDAwMDg5NWRkMDAwLCAwMDAwMDAwMDg5ZWZlZmZmXSAocmVz ZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDA4OWVmZjAwMCwgMDAwMDAwMDA4OWVmZmZmZl0gKHVzYWJs ZSkKKFhFTikgIFswMDAwMDAwMDg5ZjAwMDAwLCAwMDAwMDAwMDhmN2ZmZmZmXSAocmVzZXJ2ZWQp CihYRU4pICBbMDAwMDAwMDBlMDAwMDAwMCwgMDAwMDAwMDBlZmZmZmZmZl0gKHJlc2VydmVkKQoo WEVOKSAgWzAwMDAwMDAwZmUwMDAwMDAsIDAwMDAwMDAwZmUwMTBmZmZdIChyZXNlcnZlZCkKKFhF TikgIFswMDAwMDAwMGZlYzAwMDAwLCAwMDAwMDAwMGZlYzAwZmZmXSAocmVzZXJ2ZWQpCihYRU4p ICBbMDAwMDAwMDBmZWUwMDAwMCwgMDAwMDAwMDBmZWUwMGZmZl0gKHJlc2VydmVkKQooWEVOKSAg WzAwMDAwMDAwZmYwMDAwMDAsIDAwMDAwMDAwZmZmZmZmZmZdIChyZXNlcnZlZCkKKFhFTikgIFsw MDAwMDAwMTAwMDAwMDAwLCAwMDAwMDAwODZlN2ZmZmZmXSAodXNhYmxlKQooWEVOKSBBQ1BJOiBS U0RQIDAwMEYwNUIwLCAwMDI0IChyMiBBTEFTS0EpCihYRU4pIEFDUEk6IFhTRFQgODk1MTIwQTgs IDAwRDQgKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBB Q1BJOiBGQUNQIDg5NTUwOUMwLCAwMTE0IChyNiBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1J ICAgICAxMDAxMykKKFhFTikgQUNQSTogRFNEVCA4OTUxMjIxOCwgM0U3QTYgKHIyIEFMQVNLQSAg ICBBIE0gSSAgMTA3MjAwOSBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBGQUNTIDg5NURDMDgw LCAwMDQwCihYRU4pIEFDUEk6IEFQSUMgODk1NTBBRDgsIDAwRjQgKHI0IEFMQVNLQSAgICBBIE0g SSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQooWEVOKSBBQ1BJOiBGUERUIDg5NTUwQkQwLCAwMDQ0 IChyMSBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1JICAgICAxMDAxMykKKFhFTikgQUNQSTog RklEVCA4OTU1MEMxOCwgMDA5QyAocjEgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAg MTAwMTMpCihYRU4pIEFDUEk6IE1DRkcgODk1NTBDQjgsIDAwM0MgKHIxIEFMQVNLQSAgICBBIE0g SSAgMTA3MjAwOSBNU0ZUICAgICAgIDk3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTUwQ0Y4LCAwMjA0 IChyMSBBTEFTS0EgICAgQSBNIEkgICAgIDEwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU1MEYwMCwgMTdENSAocjIgQUxBU0tBICAgIEEgTSBJICAgICAzMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NTI2RDgsIDkzM0QgKHIxIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMSBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTVCQTE4LCAzMUM3 IChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDMwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU1RUJFMCwgMjM1OCAocjIgQUxBU0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IEhQRVQgODk1NjBGMzgsIDAwMzggKHIxIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBBQ1BJOiBTU0RUIDg5NTYwRjcwLCAxQkUx IChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDEwMDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog U1NEVCA4OTU2MkI1OCwgMEY5RSAocjIgQUxBU0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAx NjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1NjNBRjgsIDJEMUIgKHIyIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBVRUZJIDg5NTY2ODE4LCAwMDQy IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTog TFBJVCA4OTU2Njg2MCwgMDA1QyAocjEgQUxBU0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEw MDAwMTMpCihYRU4pIEFDUEk6IFNTRFQgODk1NjY4QzAsIDI3REUgKHIyIEFMQVNLQSAgICBBIE0g SSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQooWEVOKSBBQ1BJOiBTU0RUIDg5NTY5MEEwLCAwRkZF IChyMiBBTEFTS0EgICAgQSBNIEkgICAgICAgIDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTog REJHUCA4OTU2QTBBMCwgMDAzNCAocjEgQUxBU0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEw MDAwMTMpCihYRU4pIEFDUEk6IERCRzIgODk1NkEwRDgsIDAwNTQgKHIwIEFMQVNLQSAgICBBIE0g SSAgICAgICAgMiAgICAgICAxMDAwMDEzKQooWEVOKSBBQ1BJOiBETUFSIDg5NTZBMTMwLCAwMEE4 IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAgIDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTog V1NNVCA4OTU2QTFEOCwgMDAyOCAocjEgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAg MTAwMTMpCihYRU4pIFN5c3RlbSBSQU06IDMyNjI5TUIgKDMzNDEyMjIwa0IpCihYRU4pIE5vIE5V TUEgY29uZmlndXJhdGlvbiBmb3VuZAooWEVOKSBGYWtpbmcgYSBub2RlIGF0IDAwMDAwMDAwMDAw MDAwMDAtMDAwMDAwMDg2ZTgwMDAwMAooWEVOKSBEb21haW4gaGVhcCBpbml0aWFsaXNlZAooWEVO KSBmb3VuZCBTTVAgTVAtdGFibGUgYXQgMDAwZmNlMTAKKFhFTikgU01CSU9TIDMuMSBwcmVzZW50 LgooWEVOKSBVc2luZyBBUElDIGRyaXZlciBkZWZhdWx0CihYRU4pIEFDUEk6IFBNLVRpbWVyIElP IFBvcnQ6IDB4MTgwOCAoMjQgYml0cykKKFhFTikgQUNQSTogdjUgU0xFRVAgSU5GTzogY29udHJv bFsxOjE4MDRdLCBzdGF0dXNbMToxODAwXQooWEVOKSBBQ1BJOiBJbnZhbGlkIHNsZWVwIGNvbnRy b2wvc3RhdHVzIHJlZ2lzdGVyIGRhdGE6IDA6MHg4OjB4MyAwOjB4ODoweDMKKFhFTikgQUNQSTog U0xFRVAgSU5GTzogcG0xeF9jbnRbMToxODA0LDE6MF0sIHBtMXhfZXZ0WzE6MTgwMCwxOjBdCihY RU4pIEFDUEk6IDMyLzY0WCBGQUNTIGFkZHJlc3MgbWlzbWF0Y2ggaW4gRkFEVCAtIDg5NWRjMDgw LzAwMDAwMDAwMDAwMDAwMDAsIHVzaW5nIDMyCihYRU4pIEFDUEk6ICAgICAgICAgICAgIHdha2V1 cF92ZWNbODk1ZGMwOGNdLCB2ZWNfc2l6ZVsyMF0KKFhFTikgQUNQSTogTG9jYWwgQVBJQyBhZGRy ZXNzIDB4ZmVlMDAwMDAKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwMV0gbGFwaWNfaWRb MHgwMF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwMl0gbGFwaWNfaWRb MHgwMl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwM10gbGFwaWNfaWRb MHgwNF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNF0gbGFwaWNfaWRb MHgwNl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNV0gbGFwaWNfaWRb MHgwOF0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwNl0gbGFwaWNfaWRb MHgwYV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwN10gbGFwaWNfaWRb MHgwMV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwOF0gbGFwaWNfaWRb MHgwM10gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwOV0gbGFwaWNfaWRb MHgwNV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwYV0gbGFwaWNfaWRb MHgwN10gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwYl0gbGFwaWNfaWRb MHgwOV0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUMgKGFjcGlfaWRbMHgwY10gbGFwaWNfaWRb MHgwYl0gZW5hYmxlZCkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDFdIGhpZ2gg ZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDAyXSBoaWdo IGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwM10gaGln aCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDRdIGhp Z2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA1XSBo aWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgwNl0g aGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4MDdd IGhpZ2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsweDA4 XSBoaWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRbMHgw OV0gaGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgQUNQSTogTEFQSUNfTk1JIChhY3BpX2lkWzB4 MGFdIGhpZ2ggZWRnZSBsaW50WzB4MV0pCihYRU4pIEFDUEk6IExBUElDX05NSSAoYWNwaV9pZFsw eDBiXSBoaWdoIGVkZ2UgbGludFsweDFdKQooWEVOKSBBQ1BJOiBMQVBJQ19OTUkgKGFjcGlfaWRb MHgwY10gaGlnaCBlZGdlIGxpbnRbMHgxXSkKKFhFTikgT3ZlcnJpZGluZyBBUElDIGRyaXZlciB3 aXRoIGJpZ3NtcAooWEVOKSBBQ1BJOiBJT0FQSUMgKGlkWzB4MDJdIGFkZHJlc3NbMHhmZWMwMDAw MF0gZ3NpX2Jhc2VbMF0pCihYRU4pIElPQVBJQ1swXTogYXBpY19pZCAyLCB2ZXJzaW9uIDMyLCBh ZGRyZXNzIDB4ZmVjMDAwMDAsIEdTSSAwLTExOQooWEVOKSBBQ1BJOiBJTlRfU1JDX09WUiAoYnVz IDAgYnVzX2lycSAwIGdsb2JhbF9pcnEgMiBkZmwgZGZsKQooWEVOKSBBQ1BJOiBJTlRfU1JDX09W UiAoYnVzIDAgYnVzX2lycSA5IGdsb2JhbF9pcnEgOSBoaWdoIGxldmVsKQooWEVOKSBBQ1BJOiBJ UlEwIHVzZWQgYnkgb3ZlcnJpZGUuCihYRU4pIEFDUEk6IElSUTIgdXNlZCBieSBvdmVycmlkZS4K KFhFTikgQUNQSTogSVJROSB1c2VkIGJ5IG92ZXJyaWRlLgooWEVOKSBFbmFibGluZyBBUElDIG1v ZGU6ICBQaHlzLiAgVXNpbmcgMSBJL08gQVBJQ3MKKFhFTikgQUNQSTogSFBFVCBpZDogMHg4MDg2 YTIwMSBiYXNlOiAweGZlZDAwMDAwCihYRU4pIFBDSTogTUNGRyBjb25maWd1cmF0aW9uIDA6IGJh c2UgZTAwMDAwMDAgc2VnbWVudCAwMDAwIGJ1c2VzIDAwIC0gZmYKKFhFTikgUENJOiBNQ0ZHIGFy ZWEgYXQgZTAwMDAwMDAgcmVzZXJ2ZWQgaW4gRTgyMAooWEVOKSBQQ0k6IFVzaW5nIE1DRkcgZm9y IHNlZ21lbnQgMDAwMCBidXMgMDAtZmYKKFhFTikgW1ZULURdSG9zdCBhZGRyZXNzIHdpZHRoIDM5 CihYRU4pIFtWVC1EXWZvdW5kIEFDUElfRE1BUl9EUkhEOgooWEVOKSBbVlQtRF0gIGRtYXJ1LT5h ZGRyZXNzID0gZmVkOTAwMDAKKFhFTikgW1ZULURdZHJoZC0+YWRkcmVzcyA9IGZlZDkwMDAwIGlv bW11LT5yZWcgPSBmZmZmODJjMDAwMjFkMDAwCihYRU4pIFtWVC1EXWNhcCA9IDFjMDAwMGM0MDY2 MDQ2MiBlY2FwID0gMTllMmZmMDUwNWUKKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAwOjAwOjAy LjAKKFhFTikgW1ZULURdZm91bmQgQUNQSV9ETUFSX0RSSEQ6CihYRU4pIFtWVC1EXSAgZG1hcnUt PmFkZHJlc3MgPSBmZWQ5MTAwMAooWEVOKSBbVlQtRF1kcmhkLT5hZGRyZXNzID0gZmVkOTEwMDAg aW9tbXUtPnJlZyA9IGZmZmY4MmMwMDAyMWYwMDAKKFhFTikgW1ZULURdY2FwID0gZDIwMDhjNDA2 NjA0NjIgZWNhcCA9IGYwNTBkYQooWEVOKSBbVlQtRF0gSU9BUElDOiAwMDAwOjAwOjFlLjcKKFhF TikgW1ZULURdIE1TSSBIUEVUOiAwMDAwOjAwOjFlLjYKKFhFTikgW1ZULURdICBmbGFnczogSU5D TFVERV9BTEwKKFhFTikgW1ZULURdZm91bmQgQUNQSV9ETUFSX1JNUlI6CihYRU4pIFtWVC1EXSBl bmRwb2ludDogMDAwMDowMDoxNC4wCihYRU4pIFtWVC1EXWZvdW5kIEFDUElfRE1BUl9STVJSOgoo WEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDA6MDIuMAooWEVOKSBVc2luZyBBQ1BJIChNQURU KSBmb3IgU01QIGNvbmZpZ3VyYXRpb24gaW5mb3JtYXRpb24KKFhFTikgU01QOiBBbGxvd2luZyAx MiBDUFVzICgwIGhvdHBsdWcgQ1BVcykKKFhFTikgSVJRIGxpbWl0czogMTIwIEdTSSwgMjM3NiBN U0kvTVNJLVgKKFhFTikgU3dpdGNoZWQgdG8gQVBJQyBkcml2ZXIgeDJhcGljX2NsdXN0ZXIKKFhF TikgQ1BVMDogVFNDOiByYXRpbzogMjkyIC8gMgooWEVOKSBDUFUwOiBidXM6IDEwMCBNSHogYmFz ZTogMzUwMCBNSHogbWF4OiA0NTAwIE1IegooWEVOKSBDUFUwOiA4MDAgLi4uIDM1MDAgTUh6CihY RU4pIHhzdGF0ZTogc2l6ZTogMHg0NDAgYW5kIHN0YXRlczogMHgxZgooWEVOKSBDUFUwOiBJbnRl bCBtYWNoaW5lIGNoZWNrIHJlcG9ydGluZyBlbmFibGVkCihYRU4pIFNwZWN1bGF0aXZlIG1pdGln YXRpb24gZmFjaWxpdGllczoKKFhFTikgICBIYXJkd2FyZSBmZWF0dXJlczogSUJSUy9JQlBCIFNU SUJQIEwxRF9GTFVTSCBTU0JEIE1EX0NMRUFSCihYRU4pICAgQ29tcGlsZWQtaW4gc3VwcG9ydDog SU5ESVJFQ1RfVEhVTksgU0hBRE9XX1BBR0lORwooWEVOKSAgIFhlbiBzZXR0aW5nczogQlRJLVRo dW5rIEpNUCwgU1BFQ19DVFJMOiBJQlJTKyBTU0JELSwgT3RoZXI6IElCUEIgTDFEX0ZMVVNIIFZF UlcgQlJBTkNIX0hBUkRFTgooWEVOKSAgIEwxVEY6IGJlbGlldmVkIHZ1bG5lcmFibGUsIG1heHBo eXNhZGRyIEwxRCA0NiwgQ1BVSUQgMzksIFNhZmUgYWRkcmVzcyA4MDAwMDAwMDAwCihYRU4pICAg U3VwcG9ydCBmb3IgSFZNIFZNczogTVNSX1NQRUNfQ1RSTCBSU0IgRUFHRVJfRlBVIE1EX0NMRUFS CihYRU4pICAgU3VwcG9ydCBmb3IgUFYgVk1zOiBNU1JfU1BFQ19DVFJMIFJTQiBFQUdFUl9GUFUg TURfQ0xFQVIKKFhFTikgICBYUFRJICg2NC1iaXQgUFYgb25seSk6IERvbTAgZW5hYmxlZCwgRG9t VSBlbmFibGVkICh3aXRoIFBDSUQpCihYRU4pICAgUFYgTDFURiBzaGFkb3dpbmc6IERvbTAgZGlz YWJsZWQsIERvbVUgZW5hYmxlZAooWEVOKSBVc2luZyBzY2hlZHVsZXI6IFNNUCBDcmVkaXQgU2No ZWR1bGVyIHJldjIgKGNyZWRpdDIpCihYRU4pIEluaXRpYWxpemluZyBDcmVkaXQyIHNjaGVkdWxl cgooWEVOKSAgbG9hZF9wcmVjaXNpb25fc2hpZnQ6IDE4CihYRU4pICBsb2FkX3dpbmRvd19zaGlm dDogMzAKKFhFTikgIHVuZGVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogMAooWEVOKSAgb3Zlcmxv YWRfYmFsYW5jZV90b2xlcmFuY2U6IC0zCihYRU4pICBydW5xdWV1ZXMgYXJyYW5nZW1lbnQ6IHNv Y2tldAooWEVOKSAgY2FwIGVuZm9yY2VtZW50IGdyYW51bGFyaXR5OiAxMG1zCihYRU4pIGxvYWQg dHJhY2tpbmcgd2luZG93IGxlbmd0aCAxMDczNzQxODI0IG5zCihYRU4pIFBsYXRmb3JtIHRpbWVy IGlzIDI0LjAwME1IeiBIUEVUCihYRU4pIERldGVjdGVkIDM1MDQuNTIwIE1IeiBwcm9jZXNzb3Iu CihYRU4pIGFsdCB0YWJsZSBmZmZmODJkMDQwNDM5MjkwIC0+IGZmZmY4MmQwNDA0NDQyMzgKKFhF TikgSW50ZWwgVlQtZCBpb21tdSAwIHN1cHBvcnRlZCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdC CihYRU4pIEludGVsIFZULWQgaW9tbXUgMSBzdXBwb3J0ZWQgcGFnZSBzaXplczogNGtCLCAyTUIs IDFHQgooWEVOKSBJbnRlbCBWVC1kIFNub29wIENvbnRyb2wgbm90IGVuYWJsZWQuCihYRU4pIElu dGVsIFZULWQgRG9tMCBETUEgUGFzc3Rocm91Z2ggbm90IGVuYWJsZWQuCihYRU4pIEludGVsIFZU LWQgUXVldWVkIEludmFsaWRhdGlvbiBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1kIEludGVycnVw dCBSZW1hcHBpbmcgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBQb3N0ZWQgSW50ZXJydXB0IG5v dCBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1kIFNoYXJlZCBFUFQgdGFibGVzIGVuYWJsZWQuCihY RU4pIEkvTyB2aXJ0dWFsaXNhdGlvbiBlbmFibGVkCihYRU4pICAtIERvbTAgbW9kZTogUmVsYXhl ZAooWEVOKSBJbnRlcnJ1cHQgcmVtYXBwaW5nIGVuYWJsZWQKKFhFTikgbnJfc29ja2V0czogMQoo WEVOKSBFbmFibGVkIGRpcmVjdGVkIEVPSSB3aXRoIGlvYXBpY19hY2tfb2xkIG9uIQooWEVOKSBF TkFCTElORyBJTy1BUElDIElSUXMKKFhFTikgIC0+IFVzaW5nIG9sZCBBQ0sgbWV0aG9kCihYRU4p IC4uVElNRVI6IHZlY3Rvcj0weEYwIGFwaWMxPTAgcGluMT0yIGFwaWMyPS0xIHBpbjI9LTEKKFhF TikgVFNDIGRlYWRsaW5lIHRpbWVyIGVuYWJsZWQKKFhFTikgQWxsb2NhdGVkIGNvbnNvbGUgcmlu ZyBvZiAxMjggS2lCLgooWEVOKSBtd2FpdC1pZGxlOiBNV0FJVCBzdWJzdGF0ZXM6IDB4MTExNDIx MjAKKFhFTikgbXdhaXQtaWRsZTogdjAuNC4xIG1vZGVsIDB4OWUKKFhFTikgbXdhaXQtaWRsZTog bGFwaWNfdGltZXJfcmVsaWFibGVfc3RhdGVzIDB4ZmZmZmZmZmYKKFhFTikgVk1YOiBTdXBwb3J0 ZWQgYWR2YW5jZWQgZmVhdHVyZXM6CihYRU4pICAtIEFQSUMgTU1JTyBhY2Nlc3MgdmlydHVhbGlz YXRpb24KKFhFTikgIC0gQVBJQyBUUFIgc2hhZG93CihYRU4pICAtIEV4dGVuZGVkIFBhZ2UgVGFi bGVzIChFUFQpCihYRU4pICAtIFZpcnR1YWwtUHJvY2Vzc29yIElkZW50aWZpZXJzIChWUElEKQoo WEVOKSAgLSBWaXJ0dWFsIE5NSQooWEVOKSAgLSBNU1IgZGlyZWN0LWFjY2VzcyBiaXRtYXAKKFhF TikgIC0gVW5yZXN0cmljdGVkIEd1ZXN0CihYRU4pICAtIFZNQ1Mgc2hhZG93aW5nCihYRU4pICAt IFZNIEZ1bmN0aW9ucwooWEVOKSAgLSBWaXJ0dWFsaXNhdGlvbiBFeGNlcHRpb25zCihYRU4pICAt IFBhZ2UgTW9kaWZpY2F0aW9uIExvZ2dpbmcKKFhFTikgSFZNOiBBU0lEcyBlbmFibGVkLgooWEVO KSBWTVg6IERpc2FibGluZyBleGVjdXRhYmxlIEVQVCBzdXBlcnBhZ2VzIGR1ZSB0byBDVkUtMjAx OC0xMjIwNwooWEVOKSBIVk06IFZNWCBlbmFibGVkCihYRU4pIEhWTTogSGFyZHdhcmUgQXNzaXN0 ZWQgUGFnaW5nIChIQVApIGRldGVjdGVkCihYRU4pIEhWTTogSEFQIHBhZ2Ugc2l6ZXM6IDRrQiwg Mk1CLCAxR0IKKFhFTikgYWx0IHRhYmxlIGZmZmY4MmQwNDA0MzkyOTAgLT4gZmZmZjgyZDA0MDQ0 NDIzOAooWEVOKSBCcm91Z2h0IHVwIDEyIENQVXMKKFhFTikgU2NoZWR1bGluZyBncmFudWxhcml0 eTogY3B1LCAxIENQVSBwZXIgc2NoZWQtcmVzb3VyY2UKKFhFTikgQWRkaW5nIGNwdSAwIHRvIHJ1 bnF1ZXVlIDAKKFhFTikgIEZpcnN0IGNwdSBvbiBydW5xdWV1ZSwgYWN0aXZhdGluZwooWEVOKSBB ZGRpbmcgY3B1IDEgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDIgdG8gcnVucXVldWUg MAooWEVOKSBBZGRpbmcgY3B1IDMgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDQgdG8g cnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDUgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcg Y3B1IDYgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDcgdG8gcnVucXVldWUgMAooWEVO KSBBZGRpbmcgY3B1IDggdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDkgdG8gcnVucXVl dWUgMAooWEVOKSBBZGRpbmcgY3B1IDEwIHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSAx MSB0byBydW5xdWV1ZSAwCihYRU4pIG1jaGVja19wb2xsOiBNYWNoaW5lIGNoZWNrIHBvbGxpbmcg dGltZXIgc3RhcnRlZC4KKFhFTikgTlggKEV4ZWN1dGUgRGlzYWJsZSkgcHJvdGVjdGlvbiBhY3Rp dmUKKFhFTikgRG9tMCBoYXMgbWF4aW11bSA5NTIgUElSUXMKKFhFTikgKioqIEJ1aWxkaW5nIGEg UFYgRG9tMCAqKioKKFhFTikgIFhlbiAga2VybmVsOiA2NC1iaXQsIGxzYiwgY29tcGF0MzIKKFhF TikgIERvbTAga2VybmVsOiA2NC1iaXQsIFBBRSwgbHNiLCBwYWRkciAweDEwMDAwMDAgLT4gMHgy ZTJjMDAwCihYRU4pIFBIWVNJQ0FMIE1FTU9SWSBBUlJBTkdFTUVOVDoKKFhFTikgIERvbTAgYWxs b2MuOiAgIDAwMDAwMDA4NTAwMDAwMDAtPjAwMDAwMDA4NTQwMDAwMDAgKDUwNDMxNCBwYWdlcyB0 byBiZSBhbGxvY2F0ZWQpCihYRU4pICBJbml0LiByYW1kaXNrOiAwMDAwMDAwODZkOWZhMDAwLT4w MDAwMDAwODZlN2ZmM2Y2CihYRU4pIFZJUlRVQUwgTUVNT1JZIEFSUkFOR0VNRU5UOgooWEVOKSAg TG9hZGVkIGtlcm5lbDogZmZmZmZmZmY4MTAwMDAwMC0+ZmZmZmZmZmY4MmUyYzAwMAooWEVOKSAg SW5pdC4gcmFtZGlzazogMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg UGh5cy1NYWNoIG1hcDogMDAwMDAwODAwMDAwMDAwMC0+MDAwMDAwODAwMDQwMDAwMAooWEVOKSAg U3RhcnQgaW5mbzogICAgZmZmZmZmZmY4MmUyYzAwMC0+ZmZmZmZmZmY4MmUyYzRiOAooWEVOKSAg WGVuc3RvcmUgcmluZzogMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg Q29uc29sZSByaW5nOiAgMDAwMDAwMDAwMDAwMDAwMC0+MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAg UGFnZSB0YWJsZXM6ICAgZmZmZmZmZmY4MmUyZDAwMC0+ZmZmZmZmZmY4MmU0ODAwMAooWEVOKSAg Qm9vdCBzdGFjazogICAgZmZmZmZmZmY4MmU0ODAwMC0+ZmZmZmZmZmY4MmU0OTAwMAooWEVOKSAg VE9UQUw6ICAgICAgICAgZmZmZmZmZmY4MDAwMDAwMC0+ZmZmZmZmZmY4MzAwMDAwMAooWEVOKSAg RU5UUlkgQUREUkVTUzogZmZmZmZmZmY4MmFiNjE2MAooWEVOKSBEb20wIGhhcyBtYXhpbXVtIDQg VkNQVXMKKFhFTikgW1ZULURdaW9tbXVfZW5hYmxlX3RyYW5zbGF0aW9uOiBpb21tdS0+cmVnID0g ZmZmZjgyYzAwMDIxZDAwMAooWEVOKSBbVlQtRF1pb21tdV9lbmFibGVfdHJhbnNsYXRpb246IGlv bW11LT5yZWcgPSBmZmZmODJjMDAwMjFmMDAwCihYRU4pIEluaXRpYWwgbG93IG1lbW9yeSB2aXJx IHRocmVzaG9sZCBzZXQgYXQgMHg0MDAwIHBhZ2VzLgooWEVOKSBTY3J1YmJpbmcgRnJlZSBSQU0g aW4gYmFja2dyb3VuZAooWEVOKSBTdGQuIExvZ2xldmVsOiBBbGwKKFhFTikgR3Vlc3QgTG9nbGV2 ZWw6IEFsbAooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioKKFhFTikgQm9vdGVkIG9uIEwxVEYtdnVsbmVyYWJsZSBoYXJkd2FyZSB3aXRoIFNN VC9IeXBlcnRocmVhZGluZwooWEVOKSBlbmFibGVkLiAgUGxlYXNlIGFzc2VzcyB5b3VyIGNvbmZp Z3VyYXRpb24gYW5kIGNob29zZSBhbgooWEVOKSBleHBsaWNpdCAnc210PTxib29sPicgc2V0dGlu Zy4gIFNlZSBYU0EtMjczLgooWEVOKSAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioKKFhFTikgQm9vdGVkIG9uIE1MUERTL01GQkRTLXZ1bG5lcmFibGUg aGFyZHdhcmUgd2l0aCBTTVQvSHlwZXJ0aHJlYWRpbmcKKFhFTikgZW5hYmxlZC4gIE1pdGlnYXRp b25zIHdpbGwgbm90IGJlIGZ1bGx5IGVmZmVjdGl2ZS4gIFBsZWFzZQooWEVOKSBjaG9vc2UgYW4g ZXhwbGljaXQgc210PTxib29sPiBzZXR0aW5nLiAgU2VlIFhTQS0yOTcuCihYRU4pICoqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgooWEVOKSAzLi4uIDIu Li4gMS4uLiAKKFhFTikgWGVuIGlzIHJlbGlucXVpc2hpbmcgVkdBIGNvbnNvbGUuCihYRU4pICoq KiBTZXJpYWwgaW5wdXQgdG8gRE9NMCAodHlwZSAnQ1RSTC1hJyB0aHJlZSB0aW1lcyB0byBzd2l0 Y2ggaW5wdXQpCihYRU4pIEZyZWVkIDU1MmtCIGluaXQgbWVtb3J5CihYRU4pIFBDSSBhZGQgZGV2 aWNlIDAwMDA6MDA6MDAuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAxLjAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDowMDowMi4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6 MTIuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjE0LjAKKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDowMDoxNC4yCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTYuMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjAwOjE2LjMKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDox Ny4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWIuMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjAwOjFjLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxYy41CihYRU4pIFBD SSBhZGQgZGV2aWNlIDAwMDA6MDA6MWQuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFm LjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxZi40CihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6MDA6MWYuNQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAxOjAwLjAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDowNDowMC4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDU6MDAu MAooWEVOKSBIVk0gZDF2MCBzYXZlOiBDUFUKKFhFTikgSFZNIGQxdjEgc2F2ZTogQ1BVCihYRU4p IEhWTSBkMSBzYXZlOiBQSUMKKFhFTikgSFZNIGQxIHNhdmU6IElPQVBJQwooWEVOKSBIVk0gZDF2 MCBzYXZlOiBMQVBJQwooWEVOKSBIVk0gZDF2MSBzYXZlOiBMQVBJQwooWEVOKSBIVk0gZDF2MCBz YXZlOiBMQVBJQ19SRUdTCihYRU4pIEhWTSBkMXYxIHNhdmU6IExBUElDX1JFR1MKKFhFTikgSFZN IGQxIHNhdmU6IFBDSV9JUlEKKFhFTikgSFZNIGQxIHNhdmU6IElTQV9JUlEKKFhFTikgSFZNIGQx IHNhdmU6IFBDSV9MSU5LCihYRU4pIEhWTSBkMSBzYXZlOiBQSVQKKFhFTikgSFZNIGQxIHNhdmU6 IFJUQwooWEVOKSBIVk0gZDEgc2F2ZTogSFBFVAooWEVOKSBIVk0gZDEgc2F2ZTogUE1USU1FUgoo WEVOKSBIVk0gZDF2MCBzYXZlOiBNVFJSCihYRU4pIEhWTSBkMXYxIHNhdmU6IE1UUlIKKFhFTikg SFZNIGQxIHNhdmU6IFZJUklESUFOX0RPTUFJTgooWEVOKSBIVk0gZDF2MCBzYXZlOiBDUFVfWFNB VkUKKFhFTikgSFZNIGQxdjEgc2F2ZTogQ1BVX1hTQVZFCihYRU4pIEhWTSBkMXYwIHNhdmU6IFZJ UklESUFOX1ZDUFUKKFhFTikgSFZNIGQxdjEgc2F2ZTogVklSSURJQU5fVkNQVQooWEVOKSBIVk0g ZDF2MCBzYXZlOiBWTUNFX1ZDUFUKKFhFTikgSFZNIGQxdjEgc2F2ZTogVk1DRV9WQ1BVCihYRU4p IEhWTSBkMXYwIHNhdmU6IFRTQ19BREpVU1QKKFhFTikgSFZNIGQxdjEgc2F2ZTogVFNDX0FESlVT VAooWEVOKSBIVk0gZDF2MCBzYXZlOiBDUFVfTVNSCihYRU4pIEhWTSBkMXYxIHNhdmU6IENQVV9N U1IKKFhFTikgSFZNMSByZXN0b3JlOiBDUFUgMAooWEVOKSBkMTogYmluZDogbV9nc2k9MTYgZ19n c2k9MzYgZGV2PTAwLjAwLjUgaW50eD0wCihkMSkgSFZNIExvYWRlcgooZDEpIERldGVjdGVkIFhl biB2NC4xNC4zCihkMSkgWGVuYnVzIHJpbmdzIEAweGZlZmZjMDAwLCBldmVudCBjaGFubmVsIDEK KGQxKSBTeXN0ZW0gcmVxdWVzdGVkIFNlYUJJT1MKKGQxKSBDUFUgc3BlZWQgaXMgMzUwNSBNSHoK KGQxKSBSZWxvY2F0aW5nIGd1ZXN0IG1lbW9yeSBmb3IgbG93bWVtIE1NSU8gc3BhY2UgZGlzYWJs ZWQKKGQxKSBQQ0ktSVNBIGxpbmsgMCByb3V0ZWQgdG8gSVJRNQooZDEpIFBDSS1JU0EgbGluayAx IHJvdXRlZCB0byBJUlExMAooZDEpIFBDSS1JU0EgbGluayAyIHJvdXRlZCB0byBJUlExMQooZDEp IFBDSS1JU0EgbGluayAzIHJvdXRlZCB0byBJUlE1CihkMSkgcGNpIGRldiAwMTozIElOVEEtPklS UTEwCihkMSkgcGNpIGRldiAwMjowIElOVEEtPklSUTExCihkMSkgcGNpIGRldiAwNDowIElOVEEt PklSUTUKKGQxKSBwY2kgZGV2IDA1OjAgSU5UQS0+SVJRMTAKKGQxKSBSQU0gaW4gaGlnaCBtZW1v cnk7IHNldHRpbmcgaGlnaF9tZW0gcmVzb3VyY2UgYmFzZSB0byA0MGY4MDAwMDAKKGQxKSBwY2kg ZGV2IDAzOjAgYmFyIDEwIHNpemUgMDAyMDAwMDAwOiAwZjAwMDAwMDgKKGQxKSBwY2kgZGV2IDAy OjAgYmFyIDE0IHNpemUgMDAxMDAwMDAwOiAwZjIwMDAwMDgKKGQxKSBwY2kgZGV2IDA0OjAgYmFy IDMwIHNpemUgMDAwMDQwMDAwOiAwZjMwMDAwMDAKKGQxKSBwY2kgZGV2IDA0OjAgYmFyIDEwIHNp emUgMDAwMDIwMDAwOiAwZjMwNDAwMDAKKGQxKSBwY2kgZGV2IDAzOjAgYmFyIDMwIHNpemUgMDAw MDEwMDAwOiAwZjMwNjAwMDAKKGQxKSBwY2kgZGV2IDA1OjAgYmFyIDEwIHNpemUgMDAwMDAyMDAw OiAwZjMwNzAwMDAKKGQxKSBwY2kgZGV2IDAzOjAgYmFyIDE0IHNpemUgMDAwMDAxMDAwOiAwZjMw NzIwMDAKKGQxKSBwY2kgZGV2IDA1OjAgYmFyIDI0IHNpemUgMDAwMDAwODAwOiAwZjMwNzMwMDAK KGQxKSBwY2kgZGV2IDAyOjAgYmFyIDEwIHNpemUgMDAwMDAwMTAwOiAwMDAwMGMwMDEKKGQxKSBw Y2kgZGV2IDA1OjAgYmFyIDE0IHNpemUgMDAwMDAwMTAwOiAwZjMwNzM4MDAKKGQxKSBwY2kgZGV2 IDA0OjAgYmFyIDE0IHNpemUgMDAwMDAwMDQwOiAwMDAwMGMxMDEKKGQxKSBwY2kgZGV2IDA1OjAg YmFyIDIwIHNpemUgMDAwMDAwMDIwOiAwMDAwMGMxNDEKKGQxKSBwY2kgZGV2IDAxOjEgYmFyIDIw IHNpemUgMDAwMDAwMDEwOiAwMDAwMGMxNjEKKGQxKSBwY2kgZGV2IDA1OjAgYmFyIDE4IHNpemUg MDAwMDAwMDA4OiAwMDAwMGMxNzEKKGQxKSBwY2kgZGV2IDA1OjAgYmFyIDFjIHNpemUgMDAwMDAw MDA0OiAwMDAwMGMxNzkKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTEgZ2ZuPWYzMDcwIG1mbj1h MjYxMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1mMzA3MyBtZm49YTI2MTUg bnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tMSBnZm49ZjMwNzQgbWZuPWEyNjE2IG5yPTEK KFhFTikgaW9wb3J0X21hcDphZGQ6IGRvbTEgZ3BvcnQ9YzE0MCBtcG9ydD00MDYwIG5yPTIwCihY RU4pIGlvcG9ydF9tYXA6YWRkOiBkb20xIGdwb3J0PWMxNzAgbXBvcnQ9NDA5MCBucj04CihYRU4p IGlvcG9ydF9tYXA6YWRkOiBkb20xIGdwb3J0PWMxNzggbXBvcnQ9NDA4MCBucj00CihkMSkgTXVs dGlwcm9jZXNzb3IgaW5pdGlhbGlzYXRpb246CihkMSkgIC0gQ1BVMCAuLi4gMzktYml0IHBoeXMg Li4uIGZpeGVkIE1UUlJzIC4uLiB2YXIgTVRSUnMgWzEvOF0gLi4uIGRvbmUuCihkMSkgIC0gQ1BV MSAuLi4gMzktYml0IHBoeXMgLi4uIGZpeGVkIE1UUlJzIC4uLiB2YXIgTVRSUnMgWzEvOF0gLi4u IGRvbmUuCihkMSkgV3JpdGluZyBTTUJJT1MgdGFibGVzIC4uLgooZDEpIExvYWRpbmcgU2VhQklP UyAuLi4KKGQxKSBDcmVhdGluZyBNUCB0YWJsZXMgLi4uCihkMSkgTG9hZGluZyBBQ1BJIC4uLgoo ZDEpIHZtODYgVFNTIGF0IGZjMTAwMjgwCihkMSkgQklPUyBtYXA6CihkMSkgIDEwMDAwLTEwMGUz OiBTY3JhdGNoIHNwYWNlCihkMSkgIGMwMDAwLWZmZmZmOiBNYWluIEJJT1MKKGQxKSBFODIwIHRh YmxlOgooZDEpICBbMDBdOiAwMDAwMDAwMDowMDAwMDAwMCAtIDAwMDAwMDAwOjAwMGEwMDAwOiBS QU0KKGQxKSAgSE9MRTogMDAwMDAwMDA6MDAwYTAwMDAgLSAwMDAwMDAwMDowMDBjMDAwMAooZDEp ICBbMDFdOiAwMDAwMDAwMDowMDBjMDAwMCAtIDAwMDAwMDAwOjAwMTAwMDAwOiBSRVNFUlZFRAoo ZDEpICBbMDJdOiAwMDAwMDAwMDowMDEwMDAwMCAtIDAwMDAwMDAwOmYwMDAwMDAwOiBSQU0KKGQx KSAgSE9MRTogMDAwMDAwMDA6ZjAwMDAwMDAgLSAwMDAwMDAwMDpmYzAwMDAwMAooZDEpICBbMDNd OiAwMDAwMDAwMDpmYzAwMDAwMCAtIDAwMDAwMDAwOmZjMDBiMDAwOiBOVlMKKGQxKSAgWzA0XTog MDAwMDAwMDA6ZmMwMGIwMDAgLSAwMDAwMDAwMTowMDAwMDAwMDogUkVTRVJWRUQKKGQxKSAgWzA1 XTogMDAwMDAwMDE6MDAwMDAwMDAgLSAwMDAwMDAwNDowZjgwMDAwMDogUkFNCihkMSkgSW52b2tp bmcgU2VhQklPUyAuLi4KKGQxKSBTZWFCSU9TICh2ZXJzaW9uIHJlbC0xLjEzLjAtMS1nZDU0Mjky NC1YZW4pCihkMSkgQlVJTEQ6IGdjYzogKERlYmlhbiAxMS4yLjAtMTMpIDExLjIuMCBiaW51dGls czogKEdOVSBCaW51dGlscyBmb3IgRGViaWFuKSAyLjM3CihkMSkgCihkMSkgRm91bmQgWGVuIGh5 cGVydmlzb3Igc2lnbmF0dXJlIGF0IDQwMDAwMDAwCihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBk b20xIGdmbj1mMzA3MCBtZm49YTI2MTAgbnI9MgooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9t MSBnZm49ZjMwNzMgbWZuPWEyNjE1IG5yPTEKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTEg Z2ZuPWYzMDc0IG1mbj1hMjYxNiBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1m MzA3MCBtZm49YTI2MTAgbnI9MgooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tMSBnZm49ZjMwNzMg bWZuPWEyNjE1IG5yPTEKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTEgZ2ZuPWYzMDc0IG1mbj1h MjYxNiBucj0xCihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb20xIGdmbj1mMzA3MCBtZm49YTI2 MTAgbnI9MgooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tMSBnZm49ZjMwNzMgbWZuPWEyNjE1 IG5yPTEKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTEgZ2ZuPWYzMDc0IG1mbj1hMjYxNiBu cj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1mMzA3MCBtZm49YTI2MTAgbnI9Mgoo WEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tMSBnZm49ZjMwNzMgbWZuPWEyNjE1IG5yPTEKKFhFTikg bWVtb3J5X21hcDphZGQ6IGRvbTEgZ2ZuPWYzMDc0IG1mbj1hMjYxNiBucj0xCihYRU4pIGlvcG9y dF9tYXA6cmVtb3ZlOiBkb20xIGdwb3J0PWMxNDAgbXBvcnQ9NDA2MCBucj0yMAooWEVOKSBpb3Bv cnRfbWFwOnJlbW92ZTogZG9tMSBncG9ydD1jMTcwIG1wb3J0PTQwOTAgbnI9OAooWEVOKSBpb3Bv cnRfbWFwOnJlbW92ZTogZG9tMSBncG9ydD1jMTc4IG1wb3J0PTQwODAgbnI9NAooWEVOKSBpb3Bv cnRfbWFwOmFkZDogZG9tMSBncG9ydD1jMTQwIG1wb3J0PTQwNjAgbnI9MjAKKFhFTikgaW9wb3J0 X21hcDphZGQ6IGRvbTEgZ3BvcnQ9YzE3MCBtcG9ydD00MDkwIG5yPTgKKFhFTikgaW9wb3J0X21h cDphZGQ6IGRvbTEgZ3BvcnQ9YzE3OCBtcG9ydD00MDgwIG5yPTQKKFhFTikgaW9wb3J0X21hcDpy ZW1vdmU6IGRvbTEgZ3BvcnQ9YzE0MCBtcG9ydD00MDYwIG5yPTIwCihYRU4pIGlvcG9ydF9tYXA6 cmVtb3ZlOiBkb20xIGdwb3J0PWMxNzAgbXBvcnQ9NDA5MCBucj04CihYRU4pIGlvcG9ydF9tYXA6 cmVtb3ZlOiBkb20xIGdwb3J0PWMxNzggbXBvcnQ9NDA4MCBucj00CihYRU4pIGlvcG9ydF9tYXA6 YWRkOiBkb20xIGdwb3J0PWMxNDAgbXBvcnQ9NDA2MCBucj0yMAooWEVOKSBpb3BvcnRfbWFwOmFk ZDogZG9tMSBncG9ydD1jMTcwIG1wb3J0PTQwOTAgbnI9OAooWEVOKSBpb3BvcnRfbWFwOmFkZDog ZG9tMSBncG9ydD1jMTc4IG1wb3J0PTQwODAgbnI9NAooWEVOKSBpb3BvcnRfbWFwOnJlbW92ZTog ZG9tMSBncG9ydD1jMTQwIG1wb3J0PTQwNjAgbnI9MjAKKFhFTikgaW9wb3J0X21hcDpyZW1vdmU6 IGRvbTEgZ3BvcnQ9YzE3MCBtcG9ydD00MDkwIG5yPTgKKFhFTikgaW9wb3J0X21hcDpyZW1vdmU6 IGRvbTEgZ3BvcnQ9YzE3OCBtcG9ydD00MDgwIG5yPTQKKFhFTikgaW9wb3J0X21hcDphZGQ6IGRv bTEgZ3BvcnQ9YzE0MCBtcG9ydD00MDYwIG5yPTIwCihYRU4pIGlvcG9ydF9tYXA6YWRkOiBkb20x IGdwb3J0PWMxNzAgbXBvcnQ9NDA5MCBucj04CihYRU4pIGlvcG9ydF9tYXA6YWRkOiBkb20xIGdw b3J0PWMxNzggbXBvcnQ9NDA4MCBucj00CihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb20xIGdm bj1mMzA3MCBtZm49YTI2MTAgbnI9MgooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tMSBnZm49 ZjMwNzMgbWZuPWEyNjE1IG5yPTEKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTEgZ2ZuPWYz MDc0IG1mbj1hMjYxNiBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb20xIGdmbj1mMzA3MCBt Zm49YTI2MTAgbnI9MgooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tMSBnZm49ZjMwNzMgbWZuPWEy NjE1IG5yPTEKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTEgZ2ZuPWYzMDc0IG1mbj1hMjYxNiBu cj0xCihYRU4pIGRbSU9dOiBhc3NpZ24gKDAwMDA6MDU6MDAuMCkgZmFpbGVkICgtMTYpCihYRU4p IEhWTSBkNXYwIHNhdmU6IENQVQooWEVOKSBIVk0gZDV2MSBzYXZlOiBDUFUKKFhFTikgSFZNIGQ1 djIgc2F2ZTogQ1BVCihYRU4pIEhWTSBkNXYzIHNhdmU6IENQVQooWEVOKSBIVk0gZDUgc2F2ZTog UElDCihYRU4pIEhWTSBkNSBzYXZlOiBJT0FQSUMKKFhFTikgSFZNIGQ1djAgc2F2ZTogTEFQSUMK KFhFTikgSFZNIGQ1djEgc2F2ZTogTEFQSUMKKFhFTikgSFZNIGQ1djIgc2F2ZTogTEFQSUMKKFhF TikgSFZNIGQ1djMgc2F2ZTogTEFQSUMKKFhFTikgSFZNIGQ1djAgc2F2ZTogTEFQSUNfUkVHUwoo WEVOKSBIVk0gZDV2MSBzYXZlOiBMQVBJQ19SRUdTCihYRU4pIEhWTSBkNXYyIHNhdmU6IExBUElD X1JFR1MKKFhFTikgSFZNIGQ1djMgc2F2ZTogTEFQSUNfUkVHUwooWEVOKSBIVk0gZDUgc2F2ZTog UENJX0lSUQooWEVOKSBIVk0gZDUgc2F2ZTogSVNBX0lSUQooWEVOKSBIVk0gZDUgc2F2ZTogUENJ X0xJTksKKFhFTikgSFZNIGQ1IHNhdmU6IFBJVAooWEVOKSBIVk0gZDUgc2F2ZTogUlRDCihYRU4p IEhWTSBkNSBzYXZlOiBIUEVUCihYRU4pIEhWTSBkNSBzYXZlOiBQTVRJTUVSCihYRU4pIEhWTSBk NXYwIHNhdmU6IE1UUlIKKFhFTikgSFZNIGQ1djEgc2F2ZTogTVRSUgooWEVOKSBIVk0gZDV2MiBz YXZlOiBNVFJSCihYRU4pIEhWTSBkNXYzIHNhdmU6IE1UUlIKKFhFTikgSFZNIGQ1IHNhdmU6IFZJ UklESUFOX0RPTUFJTgooWEVOKSBIVk0gZDV2MCBzYXZlOiBDUFVfWFNBVkUKKFhFTikgSFZNIGQ1 djEgc2F2ZTogQ1BVX1hTQVZFCihYRU4pIEhWTSBkNXYyIHNhdmU6IENQVV9YU0FWRQooWEVOKSBI Vk0gZDV2MyBzYXZlOiBDUFVfWFNBVkUKKFhFTikgSFZNIGQ1djAgc2F2ZTogVklSSURJQU5fVkNQ VQooWEVOKSBIVk0gZDV2MSBzYXZlOiBWSVJJRElBTl9WQ1BVCihYRU4pIEhWTSBkNXYyIHNhdmU6 IFZJUklESUFOX1ZDUFUKKFhFTikgSFZNIGQ1djMgc2F2ZTogVklSSURJQU5fVkNQVQooWEVOKSBI Vk0gZDV2MCBzYXZlOiBWTUNFX1ZDUFUKKFhFTikgSFZNIGQ1djEgc2F2ZTogVk1DRV9WQ1BVCihY RU4pIEhWTSBkNXYyIHNhdmU6IFZNQ0VfVkNQVQooWEVOKSBIVk0gZDV2MyBzYXZlOiBWTUNFX1ZD UFUKKFhFTikgSFZNIGQ1djAgc2F2ZTogVFNDX0FESlVTVAooWEVOKSBIVk0gZDV2MSBzYXZlOiBU U0NfQURKVVNUCihYRU4pIEhWTSBkNXYyIHNhdmU6IFRTQ19BREpVU1QKKFhFTikgSFZNIGQ1djMg c2F2ZTogVFNDX0FESlVTVAooWEVOKSBIVk0gZDV2MCBzYXZlOiBDUFVfTVNSCihYRU4pIEhWTSBk NXYxIHNhdmU6IENQVV9NU1IKKFhFTikgSFZNIGQ1djIgc2F2ZTogQ1BVX01TUgooWEVOKSBIVk0g ZDV2MyBzYXZlOiBDUFVfTVNSCihYRU4pIEhWTTUgcmVzdG9yZTogQ1BVIDAKKFhFTikgZDU6IGJp bmQ6IG1fZ3NpPTE2IGdfZ3NpPTM2IGRldj0wMC4wMC41IGludHg9MAooZDUpIEhWTSBMb2FkZXIK KGQ1KSBEZXRlY3RlZCBYZW4gdjQuMTQuMwooZDUpIFhlbmJ1cyByaW5ncyBAMHhmZWZmYzAwMCwg ZXZlbnQgY2hhbm5lbCAxCihkNSkgU3lzdGVtIHJlcXVlc3RlZCBTZWFCSU9TCihkNSkgQ1BVIHNw ZWVkIGlzIDM1MDUgTUh6CihkNSkgUmVsb2NhdGluZyBndWVzdCBtZW1vcnkgZm9yIGxvd21lbSBN TUlPIHNwYWNlIGRpc2FibGVkCihkNSkgUENJLUlTQSBsaW5rIDAgcm91dGVkIHRvIElSUTUKKGQ1 KSBQQ0ktSVNBIGxpbmsgMSByb3V0ZWQgdG8gSVJRMTAKKGQ1KSBQQ0ktSVNBIGxpbmsgMiByb3V0 ZWQgdG8gSVJRMTEKKGQ1KSBQQ0ktSVNBIGxpbmsgMyByb3V0ZWQgdG8gSVJRNQooZDUpIHBjaSBk ZXYgMDE6MyBJTlRBLT5JUlExMAooZDUpIHBjaSBkZXYgMDI6MCBJTlRBLT5JUlExMQooZDUpIHBj aSBkZXYgMDQ6MCBJTlRBLT5JUlE1CihkNSkgcGNpIGRldiAwNTowIElOVEEtPklSUTEwCihkNSkg Tm8gUkFNIGluIGhpZ2ggbWVtb3J5OyBzZXR0aW5nIGhpZ2hfbWVtIHJlc291cmNlIGJhc2UgdG8g MTAwMDAwMDAwCihkNSkgcGNpIGRldiAwMzowIGJhciAxMCBzaXplIDAwMjAwMDAwMDogMGYwMDAw MDA4CihkNSkgcGNpIGRldiAwMjowIGJhciAxNCBzaXplIDAwMTAwMDAwMDogMGYyMDAwMDA4Cihk NSkgcGNpIGRldiAwNDowIGJhciAzMCBzaXplIDAwMDA0MDAwMDogMGYzMDAwMDAwCihkNSkgcGNp IGRldiAwNDowIGJhciAxMCBzaXplIDAwMDAyMDAwMDogMGYzMDQwMDAwCihkNSkgcGNpIGRldiAw MzowIGJhciAzMCBzaXplIDAwMDAxMDAwMDogMGYzMDYwMDAwCihkNSkgcGNpIGRldiAwNTowIGJh ciAxMCBzaXplIDAwMDAwNDAwMDogMGYzMDcwMDA0CihkNSkgcGNpIGRldiAwMzowIGJhciAxNCBz aXplIDAwMDAwMTAwMDogMGYzMDc0MDAwCihkNSkgcGNpIGRldiAwMjowIGJhciAxMCBzaXplIDAw MDAwMDEwMDogMDAwMDBjMDAxCihkNSkgcGNpIGRldiAwNTowIGJhciAyMCBzaXplIDAwMDAwMDEw MDogMGYzMDc1MDA0CihkNSkgcGNpIGRldiAwNDowIGJhciAxNCBzaXplIDAwMDAwMDA0MDogMDAw MDBjMTAxCihkNSkgcGNpIGRldiAwMToxIGJhciAyMCBzaXplIDAwMDAwMDAxMDogMDAwMDBjMTQx CihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb201IGdmbj1mMzA3MCBtZm49YTI1MDAgbnI9MgooWEVO KSBtZW1vcnlfbWFwOmFkZDogZG9tNSBnZm49ZjMwNzMgbWZuPWEyNTAzIG5yPTEKKFhFTikgbWVt b3J5X21hcDphZGQ6IGRvbTUgZ2ZuPWYzMDc1IG1mbj1hMjUwNCBucj0xCihkNSkgTXVsdGlwcm9j ZXNzb3IgaW5pdGlhbGlzYXRpb246CihkNSkgIC0gQ1BVMCAuLi4gMzktYml0IHBoeXMgLi4uIGZp eGVkIE1UUlJzIC4uLiB2YXIgTVRSUnMgWzEvOF0gLi4uIGRvbmUuCihkNSkgIC0gQ1BVMSAuLi4g MzktYml0IHBoeXMgLi4uIGZpeGVkIE1UUlJzIC4uLiB2YXIgTVRSUnMgWzEvOF0gLi4uIGRvbmUu CihkNSkgIC0gQ1BVMiAuLi4gMzktYml0IHBoeXMgLi4uIGZpeGVkIE1UUlJzIC4uLiB2YXIgTVRS UnMgWzEvOF0gLi4uIGRvbmUuCihkNSkgIC0gQ1BVMyAuLi4gMzktYml0IHBoeXMgLi4uIGZpeGVk IE1UUlJzIC4uLiB2YXIgTVRSUnMgWzEvOF0gLi4uIGRvbmUuCihkNSkgV3JpdGluZyBTTUJJT1Mg dGFibGVzIC4uLgooZDUpIExvYWRpbmcgU2VhQklPUyAuLi4KKGQ1KSBDcmVhdGluZyBNUCB0YWJs ZXMgLi4uCihkNSkgTG9hZGluZyBBQ1BJIC4uLgooZDUpIHZtODYgVFNTIGF0IGZjMTAwMzAwCihk NSkgQklPUyBtYXA6CihkNSkgIDEwMDAwLTEwMGUzOiBTY3JhdGNoIHNwYWNlCihkNSkgIGMwMDAw LWZmZmZmOiBNYWluIEJJT1MKKGQ1KSBFODIwIHRhYmxlOgooZDUpICBbMDBdOiAwMDAwMDAwMDow MDAwMDAwMCAtIDAwMDAwMDAwOjAwMGEwMDAwOiBSQU0KKGQ1KSAgSE9MRTogMDAwMDAwMDA6MDAw YTAwMDAgLSAwMDAwMDAwMDowMDBjMDAwMAooZDUpICBbMDFdOiAwMDAwMDAwMDowMDBjMDAwMCAt IDAwMDAwMDAwOjAwMTAwMDAwOiBSRVNFUlZFRAooZDUpICBbMDJdOiAwMDAwMDAwMDowMDEwMDAw MCAtIDAwMDAwMDAwOjdmODAwMDAwOiBSQU0KKGQ1KSAgSE9MRTogMDAwMDAwMDA6N2Y4MDAwMDAg LSAwMDAwMDAwMDpmYzAwMDAwMAooZDUpICBbMDNdOiAwMDAwMDAwMDpmYzAwMDAwMCAtIDAwMDAw MDAwOmZjMDBiMDAwOiBOVlMKKGQ1KSAgWzA0XTogMDAwMDAwMDA6ZmMwMGIwMDAgLSAwMDAwMDAw MTowMDAwMDAwMDogUkVTRVJWRUQKKGQ1KSBJbnZva2luZyBTZWFCSU9TIC4uLgooZDUpIFNlYUJJ T1MgKHZlcnNpb24gcmVsLTEuMTMuMC0xLWdkNTQyOTI0LVhlbikKKGQ1KSBCVUlMRDogZ2NjOiAo RGViaWFuIDExLjIuMC0xMykgMTEuMi4wIGJpbnV0aWxzOiAoR05VIEJpbnV0aWxzIGZvciBEZWJp YW4pIDIuMzcKKGQ1KSAKKGQ1KSBGb3VuZCBYZW4gaHlwZXJ2aXNvciBzaWduYXR1cmUgYXQgNDAw MDAwMDAKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBu cj0yCihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9 MQooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEK KFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihYRU4p IG1lbW9yeV9tYXA6YWRkOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1v cnlfbWFwOmFkZDogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKFhFTikgbWVtb3J5X21h cDpyZW1vdmU6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6 cmVtb3ZlOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1vcnlfbWFwOnJl bW92ZTogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKFhFTikgbWVtb3J5X21hcDphZGQ6 IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb201 IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tNSBnZm49 ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTUgZ2ZuPWYz MDcwIG1mbj1hMjUwMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb201IGdmbj1mMzA3 MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tNSBnZm49ZjMwNzUg bWZuPWEyNTA0IG5yPTEKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1h MjUwMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMg bnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEK KFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihY RU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVO KSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKFhFTikg bWVtb3J5X21hcDphZGQ6IGRvbTUgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihYRU4pIG1lbW9y eV9tYXA6YWRkOiBkb201IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1vcnlfbWFw OmFkZDogZG9tNSBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKFhFTikgSFZNIGQ2djAgc2F2ZTog Q1BVCihYRU4pIEhWTSBkNnYxIHNhdmU6IENQVQooWEVOKSBIVk0gZDZ2MiBzYXZlOiBDUFUKKFhF TikgSFZNIGQ2djMgc2F2ZTogQ1BVCihYRU4pIEhWTSBkNiBzYXZlOiBQSUMKKFhFTikgSFZNIGQ2 IHNhdmU6IElPQVBJQwooWEVOKSBIVk0gZDZ2MCBzYXZlOiBMQVBJQwooWEVOKSBIVk0gZDZ2MSBz YXZlOiBMQVBJQwooWEVOKSBIVk0gZDZ2MiBzYXZlOiBMQVBJQwooWEVOKSBIVk0gZDZ2MyBzYXZl OiBMQVBJQwooWEVOKSBIVk0gZDZ2MCBzYXZlOiBMQVBJQ19SRUdTCihYRU4pIEhWTSBkNnYxIHNh dmU6IExBUElDX1JFR1MKKFhFTikgSFZNIGQ2djIgc2F2ZTogTEFQSUNfUkVHUwooWEVOKSBIVk0g ZDZ2MyBzYXZlOiBMQVBJQ19SRUdTCihYRU4pIEhWTSBkNiBzYXZlOiBQQ0lfSVJRCihYRU4pIEhW TSBkNiBzYXZlOiBJU0FfSVJRCihYRU4pIEhWTSBkNiBzYXZlOiBQQ0lfTElOSwooWEVOKSBIVk0g ZDYgc2F2ZTogUElUCihYRU4pIEhWTSBkNiBzYXZlOiBSVEMKKFhFTikgSFZNIGQ2IHNhdmU6IEhQ RVQKKFhFTikgSFZNIGQ2IHNhdmU6IFBNVElNRVIKKFhFTikgSFZNIGQ2djAgc2F2ZTogTVRSUgoo WEVOKSBIVk0gZDZ2MSBzYXZlOiBNVFJSCihYRU4pIEhWTSBkNnYyIHNhdmU6IE1UUlIKKFhFTikg SFZNIGQ2djMgc2F2ZTogTVRSUgooWEVOKSBIVk0gZDYgc2F2ZTogVklSSURJQU5fRE9NQUlOCihY RU4pIEhWTSBkNnYwIHNhdmU6IENQVV9YU0FWRQooWEVOKSBIVk0gZDZ2MSBzYXZlOiBDUFVfWFNB VkUKKFhFTikgSFZNIGQ2djIgc2F2ZTogQ1BVX1hTQVZFCihYRU4pIEhWTSBkNnYzIHNhdmU6IENQ VV9YU0FWRQooWEVOKSBIVk0gZDZ2MCBzYXZlOiBWSVJJRElBTl9WQ1BVCihYRU4pIEhWTSBkNnYx IHNhdmU6IFZJUklESUFOX1ZDUFUKKFhFTikgSFZNIGQ2djIgc2F2ZTogVklSSURJQU5fVkNQVQoo WEVOKSBIVk0gZDZ2MyBzYXZlOiBWSVJJRElBTl9WQ1BVCihYRU4pIEhWTSBkNnYwIHNhdmU6IFZN Q0VfVkNQVQooWEVOKSBIVk0gZDZ2MSBzYXZlOiBWTUNFX1ZDUFUKKFhFTikgSFZNIGQ2djIgc2F2 ZTogVk1DRV9WQ1BVCihYRU4pIEhWTSBkNnYzIHNhdmU6IFZNQ0VfVkNQVQooWEVOKSBIVk0gZDZ2 MCBzYXZlOiBUU0NfQURKVVNUCihYRU4pIEhWTSBkNnYxIHNhdmU6IFRTQ19BREpVU1QKKFhFTikg SFZNIGQ2djIgc2F2ZTogVFNDX0FESlVTVAooWEVOKSBIVk0gZDZ2MyBzYXZlOiBUU0NfQURKVVNU CihYRU4pIEhWTSBkNnYwIHNhdmU6IENQVV9NU1IKKFhFTikgSFZNIGQ2djEgc2F2ZTogQ1BVX01T UgooWEVOKSBIVk0gZDZ2MiBzYXZlOiBDUFVfTVNSCihYRU4pIEhWTSBkNnYzIHNhdmU6IENQVV9N U1IKKFhFTikgSFZNNiByZXN0b3JlOiBDUFUgMAooWEVOKSBkNjogYmluZDogbV9nc2k9MTYgZ19n c2k9MzYgZGV2PTAwLjAwLjUgaW50eD0wCihkNikgSFZNIExvYWRlcgooZDYpIERldGVjdGVkIFhl biB2NC4xNC4zCihkNikgWGVuYnVzIHJpbmdzIEAweGZlZmZjMDAwLCBldmVudCBjaGFubmVsIDEK KGQ2KSBTeXN0ZW0gcmVxdWVzdGVkIFNlYUJJT1MKKGQ2KSBDUFUgc3BlZWQgaXMgMzUwNSBNSHoK KGQ2KSBSZWxvY2F0aW5nIGd1ZXN0IG1lbW9yeSBmb3IgbG93bWVtIE1NSU8gc3BhY2UgZGlzYWJs ZWQKKGQ2KSBQQ0ktSVNBIGxpbmsgMCByb3V0ZWQgdG8gSVJRNQooZDYpIFBDSS1JU0EgbGluayAx IHJvdXRlZCB0byBJUlExMAooZDYpIFBDSS1JU0EgbGluayAyIHJvdXRlZCB0byBJUlExMQooZDYp IFBDSS1JU0EgbGluayAzIHJvdXRlZCB0byBJUlE1CihkNikgcGNpIGRldiAwMTozIElOVEEtPklS UTEwCihkNikgcGNpIGRldiAwMjowIElOVEEtPklSUTExCihkNikgcGNpIGRldiAwNDowIElOVEEt PklSUTUKKGQ2KSBwY2kgZGV2IDA1OjAgSU5UQS0+SVJRMTAKKGQ2KSBObyBSQU0gaW4gaGlnaCBt ZW1vcnk7IHNldHRpbmcgaGlnaF9tZW0gcmVzb3VyY2UgYmFzZSB0byAxMDAwMDAwMDAKKGQ2KSBw Y2kgZGV2IDAzOjAgYmFyIDEwIHNpemUgMDAyMDAwMDAwOiAwZjAwMDAwMDgKKGQ2KSBwY2kgZGV2 IDAyOjAgYmFyIDE0IHNpemUgMDAxMDAwMDAwOiAwZjIwMDAwMDgKKGQ2KSBwY2kgZGV2IDA0OjAg YmFyIDMwIHNpemUgMDAwMDQwMDAwOiAwZjMwMDAwMDAKKGQ2KSBwY2kgZGV2IDA0OjAgYmFyIDEw IHNpemUgMDAwMDIwMDAwOiAwZjMwNDAwMDAKKGQ2KSBwY2kgZGV2IDAzOjAgYmFyIDMwIHNpemUg MDAwMDEwMDAwOiAwZjMwNjAwMDAKKGQ2KSBwY2kgZGV2IDA1OjAgYmFyIDEwIHNpemUgMDAwMDA0 MDAwOiAwZjMwNzAwMDQKKGQ2KSBwY2kgZGV2IDAzOjAgYmFyIDE0IHNpemUgMDAwMDAxMDAwOiAw ZjMwNzQwMDAKKGQ2KSBwY2kgZGV2IDAyOjAgYmFyIDEwIHNpemUgMDAwMDAwMTAwOiAwMDAwMGMw MDEKKGQ2KSBwY2kgZGV2IDA1OjAgYmFyIDIwIHNpemUgMDAwMDAwMTAwOiAwZjMwNzUwMDQKKGQ2 KSBwY2kgZGV2IDA0OjAgYmFyIDE0IHNpemUgMDAwMDAwMDQwOiAwMDAwMGMxMDEKKGQ2KSBwY2kg ZGV2IDAxOjEgYmFyIDIwIHNpemUgMDAwMDAwMDEwOiAwMDAwMGMxNDEKKFhFTikgbWVtb3J5X21h cDphZGQ6IGRvbTYgZ2ZuPWYzMDcwIG1mbj1hMjUwMCBucj0yCihYRU4pIG1lbW9yeV9tYXA6YWRk OiBkb202IGdmbj1mMzA3MyBtZm49YTI1MDMgbnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9t NiBnZm49ZjMwNzUgbWZuPWEyNTA0IG5yPTEKKGQ2KSBNdWx0aXByb2Nlc3NvciBpbml0aWFsaXNh dGlvbjoKKGQ2KSAgLSBDUFUwIC4uLiAzOS1iaXQgcGh5cyAuLi4gZml4ZWQgTVRSUnMgLi4uIHZh ciBNVFJScyBbMS84XSAuLi4gZG9uZS4KKGQ2KSAgLSBDUFUxIC4uLiAzOS1iaXQgcGh5cyAuLi4g Zml4ZWQgTVRSUnMgLi4uIHZhciBNVFJScyBbMS84XSAuLi4gZG9uZS4KKGQ2KSAgLSBDUFUyIC4u LiAzOS1iaXQgcGh5cyAuLi4gZml4ZWQgTVRSUnMgLi4uIHZhciBNVFJScyBbMS84XSAuLi4gZG9u ZS4KKGQ2KSAgLSBDUFUzIC4uLiAzOS1iaXQgcGh5cyAuLi4gZml4ZWQgTVRSUnMgLi4uIHZhciBN VFJScyBbMS84XSAuLi4gZG9uZS4KKGQ2KSBXcml0aW5nIFNNQklPUyB0YWJsZXMgLi4uCihkNikg TG9hZGluZyBTZWFCSU9TIC4uLgooZDYpIENyZWF0aW5nIE1QIHRhYmxlcyAuLi4KKGQ2KSBMb2Fk aW5nIEFDUEkgLi4uCihkNikgdm04NiBUU1MgYXQgZmMxMDAzMDAKKGQ2KSBCSU9TIG1hcDoKKGQ2 KSAgMTAwMDAtMTAwZTM6IFNjcmF0Y2ggc3BhY2UKKGQ2KSAgYzAwMDAtZmZmZmY6IE1haW4gQklP UwooZDYpIEU4MjAgdGFibGU6CihkNikgIFswMF06IDAwMDAwMDAwOjAwMDAwMDAwIC0gMDAwMDAw MDA6MDAwYTAwMDA6IFJBTQooZDYpICBIT0xFOiAwMDAwMDAwMDowMDBhMDAwMCAtIDAwMDAwMDAw OjAwMGMwMDAwCihkNikgIFswMV06IDAwMDAwMDAwOjAwMGMwMDAwIC0gMDAwMDAwMDA6MDAxMDAw MDA6IFJFU0VSVkVECihkNikgIFswMl06IDAwMDAwMDAwOjAwMTAwMDAwIC0gMDAwMDAwMDA6N2Y4 MDAwMDA6IFJBTQooZDYpICBIT0xFOiAwMDAwMDAwMDo3ZjgwMDAwMCAtIDAwMDAwMDAwOmZjMDAw MDAwCihkNikgIFswM106IDAwMDAwMDAwOmZjMDAwMDAwIC0gMDAwMDAwMDA6ZmMwMGIwMDA6IE5W UwooZDYpICBbMDRdOiAwMDAwMDAwMDpmYzAwYjAwMCAtIDAwMDAwMDAxOjAwMDAwMDAwOiBSRVNF UlZFRAooZDYpIEludm9raW5nIFNlYUJJT1MgLi4uCihkNikgU2VhQklPUyAodmVyc2lvbiByZWwt MS4xMy4wLTEtZ2Q1NDI5MjQtWGVuKQooZDYpIEJVSUxEOiBnY2M6IChEZWJpYW4gMTEuMi4wLTEz KSAxMS4yLjAgYmludXRpbHM6IChHTlUgQmludXRpbHMgZm9yIERlYmlhbikgMi4zNwooZDYpIAoo ZDYpIEZvdW5kIFhlbiBoeXBlcnZpc29yIHNpZ25hdHVyZSBhdCA0MDAwMDAwMAooWEVOKSBtZW1v cnlfbWFwOnJlbW92ZTogZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5 X21hcDpyZW1vdmU6IGRvbTYgZ2ZuPWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9yeV9t YXA6cmVtb3ZlOiBkb202IGdmbj1mMzA3NSBtZm49YTI1MDQgbnI9MQooWEVOKSBtZW1vcnlfbWFw OmFkZDogZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5X21hcDphZGQ6 IGRvbTYgZ2ZuPWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb202 IGdmbj1mMzA3NSBtZm49YTI1MDQgbnI9MQooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tNiBn Zm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTYgZ2Zu PWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb202IGdmbj1m MzA3NSBtZm49YTI1MDQgbnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tNiBnZm49ZjMwNzAg bWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTYgZ2ZuPWYzMDczIG1mbj1h MjUwMyBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb202IGdmbj1mMzA3NSBtZm49YTI1MDQg bnI9MQooWEVOKSBtZW1vcnlfbWFwOnJlbW92ZTogZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5y PTIKKFhFTikgbWVtb3J5X21hcDpyZW1vdmU6IGRvbTYgZ2ZuPWYzMDczIG1mbj1hMjUwMyBucj0x CihYRU4pIG1lbW9yeV9tYXA6cmVtb3ZlOiBkb202IGdmbj1mMzA3NSBtZm49YTI1MDQgbnI9MQoo WEVOKSBtZW1vcnlfbWFwOmFkZDogZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikg bWVtb3J5X21hcDphZGQ6IGRvbTYgZ2ZuPWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9y eV9tYXA6YWRkOiBkb202IGdmbj1mMzA3NSBtZm49YTI1MDQgbnI9MQooWEVOKSBtZW1vcnlfbWFw OnJlbW92ZTogZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5X21hcDpy ZW1vdmU6IGRvbTYgZ2ZuPWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9yeV9tYXA6cmVt b3ZlOiBkb202IGdmbj1mMzA3NSBtZm49YTI1MDQgbnI9MQooWEVOKSBtZW1vcnlfbWFwOmFkZDog ZG9tNiBnZm49ZjMwNzAgbWZuPWEyNTAwIG5yPTIKKFhFTikgbWVtb3J5X21hcDphZGQ6IGRvbTYg Z2ZuPWYzMDczIG1mbj1hMjUwMyBucj0xCihYRU4pIG1lbW9yeV9tYXA6YWRkOiBkb202IGdmbj1m MzA3NSBtZm49YTI1MDQgbnI9MQo= --00000000000042a25905e30d31b3-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 11:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 11:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360814.590256 (Exim 4.92) (envelope-from ) id 1o8hCw-0002L8-58; Tue, 05 Jul 2022 11:59:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360814.590256; Tue, 05 Jul 2022 11:59:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hCw-0002L1-0q; Tue, 05 Jul 2022 11:59:10 +0000 Received: by outflank-mailman (input) for mailman id 360814; Tue, 05 Jul 2022 11:59:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hCu-0002Ks-Dt for xen-devel@lists.xen.org; Tue, 05 Jul 2022 11:59:08 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de7e000e-fc59-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 13:59:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7898.eurprd04.prod.outlook.com (2603:10a6:10:1ed::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 11:59:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 11:59:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de7e000e-fc59-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQlXatSYyAPUb8RcCXAl1TM/eIlVgASChECw7lfQIYU83ASK9dj2TlYbWCLfxtuEevruuihunEm5RN3nxzHnwKC5QMWaIbbtJm8cNKwDDHPdvPTvXwB/v/R+BBmf6CzbQKpCstBDW1rBSp4lVBff3MK4fcxD5ipTe7pDRvExpjkUl6bbXva6JT+4PDi6akXmY69du+lZsHEOX3boQidAQ4GUxjwpjr2F0OjIWXT9j2kEFsr+/gOUy7SeuvevcJOlDtvWRsIQT/rkMrnIEMgvuPGQ77doGG6z7Ihzbk8ciProUA4H88G5wzk6D1jeM3FFYsy86pZpBz3pM2zUCb4ZOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=z69hHlsITH5q8CXok0Q2UKGeWhmtuhywEZWkEyPNaP8=; b=B4tWdzDbynmEpashzUpM65BsyjxbvdalslrJohMH8zKbeUDRokz8cWAeGtNaK4KdwzVGFwECj74oZ1OSPAz88P/6QOBwNyN87PZf0lEugh/UM25uBCe/7n0SjDAaWLb5ufziTxE6D6DTdOIWQDASqsFuMCUnNnYRNdJk12s2WQG6jKhVzPXUD1VZR+nY/3h0qw5zfTjhlE5LkrjvXkZlenpsKtoCqjVX3K/PgnLDvMaN/nW/e+vY0F2/eIS0+ZBcMu/pg5OjXgtpHd+F25hcsOWP9Hj+vCkkOfmzEMtRtYEdFagVVnLL00KzSQT1zREkhIK8H+Q6JIX08/NdwJJVhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z69hHlsITH5q8CXok0Q2UKGeWhmtuhywEZWkEyPNaP8=; b=ZxBVeWf89yPuNkSPjmYXYSGNJL18x7n4bCj9L5JJ2P1khXGf9v8anPvtUaaM3PZS1h1KdhcNI48QS73yNDjwgR+aC9V4Y8ESGZlrrRXeuCd1jm6x4RBpFsr3QOL98McVo1X9cf22UPPLCPFEIEKmK+6Rn7QlvOEC7PDohpw+Nm/3Won3iSVVXvParwwXumfIXVJ4PTLgRGk1Q2IVy4991dvFk3063dbsvjpR77ypawW7sQISeMvN2KoErb6q9r9141MtoGLISsd1RDqq1W9lXV6awhCmP5YcCV/V7wwW49rgCbgLCt33ATnfcQqbWROTgqIWnkRqucsA/5RYYBuddg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 13:59:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P191CA0092.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8a::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1660cfac-4ecf-4f4e-b6fa-08da5e7dc166 X-MS-TrafficTypeDiagnostic: DBBPR04MB7898:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4NVIhCMjI2T0W93PJE82OhOpgugNUtj0wZFSu/CwaxcuvBiPK7uxJ2rA5FInmtb8RCS90FKPKrRzqDeIe5n4xKfj8tomN4/0Lp5b84TmHH+VQmVT+i+LuGL0Uen2D0GIIyT574SRfgcp83Qi4NAQp35yr6nsgACcKFLHRKsPX0LRyZz9g1u023jA2dZbzHooVkiXesmW5cBIwVHrCZmXw+JHVDitvKJSIKwiSgriVfXdlZg+uA7+bdR5HngvPHi6rvZh1ETQvRkrePUG3W7FXiHnkhe+A1oQDrpk35YuwvLOVx25PKGNe3Gso01TwJsl8uoHwokart3AUrZd2wn8BkNnv3tZNgFgfzrcvH83rJmiDcJTLu67QZxoPhRL7mexDxbFj3BwO376eaIp7QxAsfxEYX1HrZUhxG2dziMso+J47g+h3cH9VF3QC/xo1rBesBS4rmxoe5aJ9TNjWIfUWTioFsCIdf9FoVPrPov4dAHiloMDqwbePmjkGZ4BvTnHmFcmEKvzZ501BQJ7WJVVaXwMhF6LfRM6r7MApZ64MmbdjDxFrVV82ybEwGyRYHY5fzufUP44Iw5pjccow6K0flXeymTw5qXU5AbhxoJaxxCV/fjooSZVDmbgbypooLfAkypmKfVa5iXYUWsn3WVZ8+Ui6rkYdmbCdRuMx49OTXMUAhY5th+upOJ408/eyfMAFDH0WHtSij4dxGhONyjqskUCYz9va00DLGZ0U6AxMH+H/g6BQiZzHe960iwVTN3Lj8CYe6/K4o5U114+hMzTWE1d0LaGTkECNqdxDCjp8wBe6axegZcHJl+6kv1rzyp9JE4rDfq4W3ZpEQybrNl9lg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(376002)(346002)(39860400002)(366004)(8936002)(31696002)(6486002)(478600001)(86362001)(38100700002)(66946007)(4326008)(6512007)(8676002)(66476007)(66556008)(5660300002)(2616005)(26005)(186003)(53546011)(36756003)(316002)(6916009)(31686004)(2906002)(6506007)(41300700001)(83380400001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cm9aOGhmQmppNythU3NMK2EweWJsRTk0bzBWUGtMb0F0TXp2QnZuYmYyU21k?= =?utf-8?B?andBcllZTVBPREJ6OEtBcjRkb01rT1NIaER0VEFySldvY2g2dk5rRVZpcldj?= =?utf-8?B?a0RTT0JwNWs2Z2grckV3aHFkR3llYk5jSHNnS0xzdmRDeHhjMnBDd3Z3YkFQ?= =?utf-8?B?aXRSUUEvU0xoeFg1S3ZYR3ZyUy9qODVqbmdDK1lsTzNLTWdMYy9hVlo5KzBK?= =?utf-8?B?Rmk3ODExTHkwa1F5T3hRTlJ3WW94NVBWV3NRSngzZXh0OFhRQkhwa3F0ajBV?= =?utf-8?B?SmcwZjYxZk16ditISnNVVEhNRkdFbkpLV2xLNXhRTUNWVzl5dHIzVy96cHRO?= =?utf-8?B?dnRGdDRkclBLWVpiZUVVRDU5dm5aYy9NTlNFVDN6Y0pRaGhDV0RHWlM5Z2RL?= =?utf-8?B?bFJnMWJkd2ptWUE5cE5BeUcrQzhNdFdIVzljRDd4ODB5dVF5TThLMEhLTG94?= =?utf-8?B?UDhjNURuK2kwWGF5RFhJN2ROa28rSDhpR1RTd1ZnMjAzNUl0VTVObzNCaXZT?= =?utf-8?B?anJzc1R6VFNKN0ErVDFEWmN1dmdoRTJQZmxlZ2Vxa2FuNWVqRVg1QkpYVkxL?= =?utf-8?B?cmhraHpxQVJvMko5Y1J5N00wdVA1bytqNHZOOGdWQ1poOExxTUFyOU1jb0lS?= =?utf-8?B?TU5FaWpSRVIxdmhiekhNeW1VOVRNM2VtYXV2Si9laWVoV3BwaGFqdUZ1bFc5?= =?utf-8?B?RlQwSklVdm5UaGF0by9GTkFhZmE4ZWxqRkwvVEpIRjBGaDN3UnE0QTNaRjl5?= =?utf-8?B?bXArYnB5dmJ5VVhIenFWQXRQQ1lIOFI1OVZRdjR3MWlrdmNlUC9RQUpJdXJE?= =?utf-8?B?eHVTWDlTQUtFVlNmTi9wNy9ERk1wTWdCSEtlaUVBQUpKd0lhSG5FNFhMWHVk?= =?utf-8?B?ZE9sUEZXZkpkSldjQ28wQWFycWN4UE81VnJZay8rdUlITHRMU1h6UXZXNkJ6?= =?utf-8?B?WkloQ0NCMUdPTnpBc2FoYXdtSDQ2UW1wYU83ajdtejM2RDFTaDdUSVNrK2dI?= =?utf-8?B?Q2ZmWUF5QmRvbTU3alhKWjdBbUpWOTJwTzQwNXk2cUtINWJybDVvbXFPd1VF?= =?utf-8?B?ekpqK1hlcGc2T1A5SnRjd2FHeExGRm5hODVwbFFUMkF2UmZJWGhYTFZFYTh4?= =?utf-8?B?WWx6amhFbUJhVWdVYzM2dURudTZHbzZGdlRjVnZna1dySFBIU2RSY29oelhH?= =?utf-8?B?WkZoNXBsT3VlQU5vNUtHYzYxVEhSRXJVSGNZQmJ5bnhBOUI2MGdpV0ppbE12?= =?utf-8?B?UWJOSDE1RFd1QW1wMFR4Q2wzTkFhMTZxN1dvT056UjZaNTB4M05TRFBOWWxw?= =?utf-8?B?eUdUMGMwSWtMK1VCSlpzQk0vMm0zRXVLM2JvM1M2aC9nRmlJc1JSSExZTk40?= =?utf-8?B?R2dyOHBVc0dPc0pUMTh3M0NRRnlMY1g2RmVhUEN4dkdBekVNa0ZEWVAyUWlJ?= =?utf-8?B?MUp2dHl4K0NmZnd3S0NEYWtsdG1PSExyNSt0Q3ZkYkNsQTF5d1BiR1A2NU5p?= =?utf-8?B?bXpiSE5hZzFCeFVqc0NIOTNiTDhSYkJyNzlIY2Riak9WQmswSE13VDJlZWFz?= =?utf-8?B?UzlDNkJnWXVyajM4aTBoTm51VVBRZWpNTVUwakt2TUkvRWRvdW9hcVhZN3NZ?= =?utf-8?B?dm4wQlFsRXJpY1llZE1JNDIzNWdGK2YzQTR2MXJYb1RoWHBPYndmRHdDNk5z?= =?utf-8?B?cjQ4bVAvOGVjVmxFbGRkcHdDeVk3bkZzMlVnd2ZWcjJEQkZRUWZwMExvLzAz?= =?utf-8?B?a1hDT1JlVUJEdFlYemdrSCtoYXNxWStyYVJVbEk3ZmRTakdUM3JoUlVsTlRx?= =?utf-8?B?OUdDSW90RmJZa0lQKy9GdHIxWnR2TzZIVWF5WXNXeGpaWmJpdVNRQlJvZ0pV?= =?utf-8?B?TXhsWXo4dGVjNk85bnF3a0ZiL0RGbzl1WnpHQVBwR21vLzA0TmhYSEpnblRF?= =?utf-8?B?cXlmSmwzY0sxNUFwVWVNQ0UrbEo4Vi9JYmZ0UmZaN1pCaHd0TmUxeUIyWkZk?= =?utf-8?B?N3RuT2p1aWJjcUxxaEg0SmVVNXZOTGRlSEVTdlFaTDB6aXdXUHRKK3pTbnNN?= =?utf-8?B?ck9OMHI2QnY4dHREMVZNdWR5b1dVa0phZVBuZ1lhVWdpbHpUUW1YbElQZlF3?= =?utf-8?Q?i4u7s1nhDGVANRjcL5QEnVhpj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1660cfac-4ecf-4f4e-b6fa-08da5e7dc166 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 11:59:03.6878 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cn17wy5LCQ1+chxOQRkO79Y/pXxGSj4qq3ybJziTtM+qR4CLMRApQbGylYV3XzOUXs+uSqxlZu1d34gYAlraUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7898 On 05.07.2022 13:31, G.R. wrote: > On Tue, Jul 5, 2022 at 5:04 PM Jan Beulich wrote: >> >> On 04.07.2022 18:31, G.R. wrote: >>> On Tue, Jul 5, 2022 at 12:21 AM Roger Pau Monné wrote: >>>>> I retried with the following: >>>>> pci=['05:00.0,permissive=1,msitranslate=1'] >>>>> Those extra options suppressed some error logging, but still didn't >>>>> make the device usable to the domU. >>>>> The nvmecontrol command still get ABORTED result from the kernel... >>>>> >>>>> The only thing remained in the QEMU file is this one: >>>>> [00:05.0] msi_msix_setup: Error: Mapping of MSI-X (err: 61, vec: 0x30, entry 0) >>>> >>>> Hm it seems like Xen doesn't find the position of the MSI-X table >>>> correctly, given there's only one error path from msi.c returning >>>> -ENODATA (61). >>>> >>>> Are there errors from pciback when this happens? I would expect the >>>> call to pci_prepare_msix() from pciback to fail and thus also report >>>> some error? >>>> >>>> I think it's likely I will have to provide an additional debug patch >>>> to Xen, maybe Jan has an idea of what could be going on. >>>> >>> pciback reports the same MSI-x related error. >>> But even with DEBUG enabled, I didn't see more context reported. >>> Please find details from the attachment. >> >> And nothing pertinent in "xl dmesg"? Looking back through the thread I >> couldn't spot a complete hypervisor log (i.e. from boot to assignment >> attempt). An issue with MSI-X table determination, as Roger suspects, >> would typically be associated with a prominent warning emitted to the >> log. But there are also further possible sources of -ENXIO, which >> would go silently. > Please find the xl dmesg in the attachment. > It's with the two FreeBSD domU attempts so it should have captured > some culprits if there is any... Nothing useful in there. Yet independent of that I guess we need to separate the issues you're seeing. Otherwise it'll be impossible to know what piece of data belongs where. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:04:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:04:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360836.590279 (Exim 4.92) (envelope-from ) id 1o8hIB-00044Y-Hs; Tue, 05 Jul 2022 12:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360836.590279; Tue, 05 Jul 2022 12:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hIB-00043c-AZ; Tue, 05 Jul 2022 12:04:35 +0000 Received: by outflank-mailman (input) for mailman id 360836; Tue, 05 Jul 2022 12:04:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hI9-0003wr-CM for xen-devel@lists.xen.org; Tue, 05 Jul 2022 12:04:33 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9fe1ecbf-fc5a-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:04:31 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hHq-0003Mr-Tk; Tue, 05 Jul 2022 12:04:14 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8hHq-0004Es-Ry; Tue, 05 Jul 2022 12:04:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9fe1ecbf-fc5a-11ec-a8e4-439420d8e422 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=g1mXuTM+U4DKdljHQ+D3DvmRHTBXPbfGm4btX9/SYfM=; b=4qpdMxNsUkoRPL6bWhcJgOPUaV MzNhVq7R1cUabFeHYG0sdzlf0FhO5AICghcSFvAYRSIDO2sD6mmvQdVUV9Y8kiiTPNqJHygC2YiVK c2aaZ3nZY6ajRkqacavqV3CvQhec27OY49KPfh8juuz+yMgSFB4yvYnoTQP1Im3QlQ5U=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 403 v3 (CVE-2022-26365,CVE-2022-33740,CVE-2022-33741,CVE-2022-33742) - Linux disk/nic frontends data leaks Message-Id: Date: Tue, 05 Jul 2022 12:04:14 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-26365,CVE-2022-33740,CVE-2022-33741,CVE-2022-33742 / XSA-403 version 3 Linux disk/nic frontends data leaks UPDATES IN VERSION 3 ==================== Public release. ISSUE DESCRIPTION ================= Linux Block and Network PV device frontends don't zero memory regions before sharing them with the backend (CVE-2022-26365, CVE-2022-33740). Additionally the granularity of the grant table doesn't allow sharing less than a 4K page, leading to unrelated data residing in the same 4K page as data shared with a backend being accessible by such backend (CVE-2022-33741, CVE-2022-33742). IMPACT ====== An untrusted backend can access data not intended to be shared. If such mappings are made with write permissions the backend could also cause malfunctions and/or crashes to consumers of contiguous data in the shared pages. VULNERABLE SYSTEMS ================== All Linux guests using PV devices are vulnerable in case potentially malicious PV device backends are being used. MITIGATION ========== There is no mitigation available other than not using PV devices in case a backend is suspected to be potentially malicious. CREDITS ======= The issue related to not zeroing memory areas used for shared communications was discovered by Roger Pau Monné of Citrix. The issue related to leaking contiguous data in granted pages was disclosed publicly. RESOLUTION ========== Applying the attached patches to Linux makes the disk and network frontends capable of protecting themselves against potentially malicious backends. The signaling of whether a frontend should consider a backend as potentially malicious can be done from either the Linux kernel command line or the toolstack. Two different patches are provided for each Xen branch, but only the first patch will be applied to the official Xen repository for each branch. For the xen-unstable branch patch 1 introduces a new field to the disk and nic configurations that allow signaling on a per-device basis whether the backend should be trusted. This is an ABI incompatible change, and cannot be applied to stable branches. Patch 2 introduces support to libxl for libxl_{disk,nic}_backend_untrusted environment variable to be used in order to set whether disk and network frontends should be trusted in the absence of a per-device setting. Patch 2 is provided as a courtesy for users of stable branches that might come to rely on this behavior. For the stable branches (Xen 4.16.x - Xen 4.13.x) patch 1 introduces support to libxl for libxl_{disk,nic}_backend_untrusted environment variable to be used in order to set whether disk and network backends should be trusted. Patch 2 reverts patch 1 and instead provides the more fine grained per-device options that break the libxl ABI. Note that applying patch 2 to any of the stable releases will require a rebuild of any consumers of the libxl library, as it introduces an ABI breakage and hence won't be applied to the official repository stable branches. Users of stable releases wanting to use the functionality provided by patch 2 will need to apply it manually. Regardless of the combinations of patches applied, in the absence of any environment variable mentioned above backends will be trusted by default. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa403/xsa403-?.patch xen-unstable xsa403/xsa403-4.16-?.patch Xen 4.16.x - Xen 4.15.x xsa403/xsa403-4.14-?.patch Xen 4.14.x - Xen 4.13.x xsa403/xsa403-linux-*.patch Linux 5.18 $ sha256sum xsa403*/* f28624407a3f040456ef2c52a18d8dcf486274ea082335ea38c9791646f4989c xsa403/xsa403-1.patch e06451655775009ceaf460bbba65374c05203eed295ff43fc5fa32a8d390a94a xsa403/xsa403-2.patch 5efb8af5ed5614f5e2e8d606a9debb3503cd9e114551525826fc5a7f9de91c02 xsa403/xsa403-4.14-1.patch 9ead8c6e4d694f3042c8d2fab4ea81619c4a9fc2aa7a0f485e9c873d927d283c xsa403/xsa403-4.14-2.patch ae778d5731ae663cca32d59ed9b1be51200b85c441771a9c6657c112e9550a15 xsa403/xsa403-4.16-1.patch 8ef7bd06f646fa72f22892d2b72ae44ff4e6c00d9817d52a71262be174862ee3 xsa403/xsa403-4.16-2.patch 8192d0c313448d7aa12c13d1632db3bd68835c19f60c237b87548d5c528852b0 xsa403/xsa403-linux-1.patch 4b288d3266f9396bedc7de823909aed4d1a89fe86b2edd1d625b0e32741688cf xsa403/xsa403-linux-2.patch dddf68625be516f0524fe7bb439272769cf7d612e15e00ac936bc047fd182f8a xsa403/xsa403-linux-3.patch 4e38a50a0e5ec6e90d2fffef003f8eb93a68518f4636c15cd59568ddf1861988 xsa403/xsa403-linux-4.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of patches or mitigations is NOT permitted (except where all the affected systems and VMs are administered and used only by organisations which are members of the Xen Project Security Issues Predisclosure List). Specifically, deployment on public cloud systems is NOT permitted. This is because the patches need to be applied in the affected guests. Switching from PV to non-PV devices is observable by the guests and has usually a bad performance impact. Deployment is permitted only AFTER the embargo ends. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLEFf0MHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZSVkIALkao7hSqBVJhnVifpXpLn+mxfECoI6lgQ1sphz6 oJ7U2QxuI6j6gVSUPk3GglYjKurGBYZjBAX6fBU8po9Zdagz/iuOXCif41NHobP8 POscgXMjKR4HPE8liXNYzSbTAbn7qiyNCxBO5yGK/jPMIC8K9+0ed+9ese6VVXSj 4buiqlkLb9FP5xTCGbtt/raZoGVVRx+LLhwC8dlNXllEvI1cJIK18pfnPF+ZUQwL kXAx2figt3ZE1yNVv4Efnp2bMvv/XUGNU6X/ONP7wCKChzTOGdMyPMBJ1r73ceAn TSvVuWDBoiWCLVIY1leTjRx9xxbQq84htGG68i8nQrHckz8= =Wl2G -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-1.patch" Content-Disposition: attachment; filename="xsa403/xsa403-1.patch" Content-Transfer-Encoding: base64 RnJvbSAzMTk0YWIyNDk0ZjgzM2RiZmQxZjBhZmRmYjJmNjY3MTE2NDdiYTI5 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBGcmksIDggQXByIDIw MjIgMTA6MjE6MTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSB0b29scy9saWJ4 bDogcmVwb3J0IHRydXN0ZWQgYmFja2VuZCBzdGF0dXMgdG8gZnJvbnRlbmRz Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsg Y2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0 CgpBbGxvdyBhZG1pbmlzdHJhdG9ycyB0byBub3RpZnkgYSBmcm9udGVuZCBk cml2ZXIgdGhhdCBpdCdzIGJhY2tlbmQKY291bnRlcnBhcnQgaXMgbm90IHRv IGJlIHRydXN0ZWQsIHNvIHRoZSBmcm9udGVuZCBjYW4gZGVwbG95IHdoYXRl dmVyCm1pdGlnYXRpb25zIHJlcXVpcmVkIGluIG9yZGVyIHRvIHNlY3VyZSBp dHNlbGYuCgpBbGxvdyBzdWNoIG9wdGlvbiBmb3IgZGlzayBhbmQgbmV0d29y ayBmcm9udGVuZHMgb25seSwgYXMgdGhvc2UgYXJlCnRoZSBvbmx5IGhhcmRl bmVkIG9uZXMgY3VycmVudGx5IHN1cHBvcnRlZC4KClRoaXMgaXMgcGFydCBv ZiBYU0EtNDAzCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEFudGhvbnkgUEVS QVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPgotLS0KIGRvY3MvbWFu L3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBvZC5pbiAgICB8IDI5ICsrKysr KysrKysrKysrKysrKysrKysKIGRvY3MvbWFuL3hsLW5ldHdvcmstY29uZmln dXJhdGlvbi41LnBvZC5pbiB8ICA5ICsrKysrKysKIHRvb2xzL2luY2x1ZGUv bGlieGwuaCAgICAgICAgICAgICAgICAgICAgICB8ICA4ICsrKysrKwogdG9v bHMvbGlicy9saWdodC9saWJ4bF9kaXNrLmMgICAgICAgICAgICAgIHwgIDMg KysrCiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX25pYy5jICAgICAgICAgICAg ICAgfCAgNSArKysrCiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlk bCAgICAgICAgICAgfCAgNiArKystLQogdG9vbHMvbGlicy91dGlsL2xpYnhs dV9kaXNrX2wubCAgICAgICAgICAgIHwgIDMgKysrCiB0b29scy94bC9jaGVj ay14bC1kaXNrLXBhcnNlICAgICAgICAgICAgICAgfCAyNiArKysrKysrKysr KysrKysrKysrCiB0b29scy94bC9jaGVjay14bC12aWYtcGFyc2UgICAgICAg ICAgICAgICAgfCAxOCArKysrKysrKysrKysrKwogdG9vbHMveGwveGxfcGFy c2UuYyAgICAgICAgICAgICAgICAgICAgICAgIHwgIDQgKysrCiB4ZW4vaW5j bHVkZS9wdWJsaWMvaW8vYmxraWYuaCAgICAgICAgICAgICAgfCAgOCArKysr KysKIHhlbi9pbmNsdWRlL3B1YmxpYy9pby9uZXRpZi5oICAgICAgICAgICAg ICB8ICA2ICsrKysrCiAxMiBmaWxlcyBjaGFuZ2VkLCAxMjMgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2NzL21hbi94 bC1kaXNrLWNvbmZpZ3VyYXRpb24uNS5wb2QuaW4gYi9kb2NzL21hbi94bC1k aXNrLWNvbmZpZ3VyYXRpb24uNS5wb2QuaW4KaW5kZXggNzFkMGU4NmUzZC4u OTVkMDM5NjU1YSAxMDA2NDQKLS0tIGEvZG9jcy9tYW4veGwtZGlzay1jb25m aWd1cmF0aW9uLjUucG9kLmluCisrKyBiL2RvY3MvbWFuL3hsLWRpc2stY29u ZmlndXJhdGlvbi41LnBvZC5pbgpAQCAtMzQ0LDYgKzM0NCwzNSBAQCBjYW4g YmUgdXNlZCB0byBkaXNhYmxlICJob2xlIHB1bmNoaW5nIiBmb3IgZmlsZSBi YXNlZCBiYWNrZW5kcyB3aGljaAogd2VyZSBpbnRlbnRpb25hbGx5IGNyZWF0 ZWQgbm9uLXNwYXJzZSB0byBhdm9pZCBmcmFnbWVudGF0aW9uIG9mIHRoZQog ZmlsZS4KIAorPWl0ZW0gQjx0cnVzdGVkPiAvIEI8dW50cnVzdGVkPgorCis9 b3ZlciA0CisKKz1pdGVtIERlc2NyaXB0aW9uCisKK1JlcG9ydHMgd2hldGhl ciB0aGUgYmFja2VuZCBzaG91bGQgYmUgdHJ1c3RlZCBieSB0aGUgZnJvbnRl bmQKKworPWl0ZW0gU3VwcG9ydGVkIHZhbHVlcworCit0cnVzdGVkLCB1bnRy dXN0ZWQKKworPWl0ZW0gTWFuZGF0b3J5CisKK05vCisKKz1pdGVtIERlZmF1 bHQgdmFsdWUKKwordHJ1c3RlZAorCis9YmFjaworCitBbiBhZHZpc29yeSBz ZXR0aW5nIGZvciB0aGUgZnJvbnRlbmQgZHJpdmVyIG9uIHdoZXRoZXIgdGhl IGJhY2tlbmQgc2hvdWxkIGJlCit0cnVzdGVkLiAgVGhlIGZyb250ZW5kIHNo b3VsZCBkZXBsb3kgd2hhdGV2ZXIgcHJvdGVjdGlvbnMgaXQgaGFzIGF2YWls YWJsZSB0bworcHJldmVudCBhbiB1bnRydXN0ZWQgYmFja2VuZCBmcm9tIGFj Y2Vzc2luZyBndWVzdCBkYXRhIG5vdCByZWxhdGVkIHRvIHRoZSBJL08KK3By b2Nlc3Npbmcgb3IgY2F1c2luZyBtYWxmdW5jdGlvbiB0byB0aGUgZnJvbnRl bmQgb3IgdGhlIHdob2xlIGRvbWFpbi4KKworTm90ZSBmcm9udGVuZHMgY2Fu IGlnbm9yZSBzdWNoIHJlY29tbWVuZGF0aW9uLgorCiA9YmFjawogCiAKZGlm ZiAtLWdpdCBhL2RvY3MvbWFuL3hsLW5ldHdvcmstY29uZmlndXJhdGlvbi41 LnBvZC5pbiBiL2RvY3MvbWFuL3hsLW5ldHdvcmstY29uZmlndXJhdGlvbi41 LnBvZC5pbgppbmRleCBjZjkyZDc5NjBjLi5mM2UzNzliY2Y4IDEwMDY0NAot LS0gYS9kb2NzL21hbi94bC1uZXR3b3JrLWNvbmZpZ3VyYXRpb24uNS5wb2Qu aW4KKysrIGIvZG9jcy9tYW4veGwtbmV0d29yay1jb25maWd1cmF0aW9uLjUu cG9kLmluCkBAIC0yNTgsMyArMjU4LDEyIEBAIE5PVEU6IFRoaXMgc2hvdWxk IG5vdCBiZSBzZXQgdW5sZXNzIHlvdSBoYXZlIGEgcmVhc29uIHRvLgogU3Bl Y2lmaWVzIHRoZSBNVFUgKGkuZS4gdGhlIG1heGltdW0gc2l6ZSBvZiBhbiBJ UCBwYXlsb2FkLCBleGNsdXNpbmcgaGVhZGVycykuIFRoZQogZGVmYXVsdCB2 YWx1ZSBpcyAxNTAwIGJ1dCwgaWYgdGhlIFZJRiBpcyBhdHRhY2hlZCB0byBh IGJyaWRnZSwgaXQgd2lsbCBiZSBzZXQgdG8gbWF0Y2gKIHVubGVzcyBvdmVy cmlkZGVuIGJ5IHRoaXMgcGFyYW1ldGVyLgorCis9aGVhZDIgdHJ1c3RlZCAv IHVudHJ1c3RlZAorCitBbiBhZHZpc29yeSBzZXR0aW5nIGZvciB0aGUgZnJv bnRlbmQgZHJpdmVyIG9uIHdoZXRoZXIgdGhlIGJhY2tlbmQgc2hvdWxkIGJl Cit0cnVzdGVkLiAgVGhlIGZyb250ZW5kIHNob3VsZCBkZXBsb3kgd2hhdGV2 ZXIgcHJvdGVjdGlvbnMgaXQgaGFzIGF2YWlsYWJsZSB0bworcHJldmVudCBh biB1bnRydXN0ZWQgYmFja2VuZCBmcm9tIGFjY2Vzc2luZyBndWVzdCBkYXRh IG5vdCByZWxhdGVkIHRvIHRoZSBJL08KK3Byb2Nlc3Npbmcgb3IgY2F1c2lu ZyBtYWxmdW5jdGlvbiB0byB0aGUgZnJvbnRlbmQgb3IgdGhlIHdob2xlIGRv bWFpbi4KKworTm90ZSBmcm9udGVuZHMgY2FuIGlnbm9yZSBzdWNoIHJlY29t bWVuZGF0aW9uLgpkaWZmIC0tZ2l0IGEvdG9vbHMvaW5jbHVkZS9saWJ4bC5o IGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5oCmluZGV4IDUxYTliNmNmYWMuLmM4 ZmYyNGY5MjkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2luY2x1ZGUvbGlieGwuaAor KysgYi90b29scy9pbmNsdWRlL2xpYnhsLmgKQEAgLTUyNyw2ICs1MjcsMTQg QEAKICAqLwogI2RlZmluZSBMSUJYTF9IQVZFX01BWF9HUkFOVF9WRVJTSU9O IDEKIAorLyoKKyAqIExJQlhMX0hBVkVfe0RJU0ssTklDfV9UUlVTVEVEIGlu ZGljYXRlcyB0aGF0IHRoZSBsaWJ4bF9kZXZpY2VfZGlzayBhbmQKKyAqIGxp YnhsX2RldmljZV9uaWMgc3RydWN0cyBoYXZlIGEgZmllbGQgdG8gc2lnbmFs IHdoZXRoZXIgdGhlIGJhY2tlbmQgb2YgdGhlCisgKiBkZXZpY2UgaXMgdG8g YmUgdHJ1c3RlZC4gIFN1Y2ggaW5mb3JtYXRpb24gaXMgcHJvcGFnYXRlZCB0 byB0aGUgZnJvbnRlbmQuCisgKi8KKyNkZWZpbmUgTElCWExfSEFWRV9ESVNL X1RSVVNURUQgMQorI2RlZmluZSBMSUJYTF9IQVZFX05JQ19UUlVTVEVEIDEK KwogLyoKICAqIGxpYnhsIEFCSSBjb21wYXRpYmlsaXR5CiAgKgpkaWZmIC0t Z2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9kaXNrLmMgYi90b29scy9s aWJzL2xpZ2h0L2xpYnhsX2Rpc2suYwppbmRleCBhNWNhNzc4NTBmLi45ZGEy YjJlZDI3IDEwMDY0NAotLS0gYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX2Rp c2suYworKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2Rpc2suYwpAQCAt MTU5LDYgKzE1OSw3IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RldmljZV9kaXNr X3NldGRlZmF1bHQobGlieGxfX2djICpnYywgdWludDMyX3QgZG9taWQsCiAg ICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZkaXNrLT5kaXNjYXJkX2Vu YWJsZSwgISFkaXNrLT5yZWFkd3JpdGUpOwogICAgIGxpYnhsX2RlZmJvb2xf c2V0ZGVmYXVsdCgmZGlzay0+Y29sb19lbmFibGUsIGZhbHNlKTsKICAgICBs aWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmRpc2stPmNvbG9fcmVzdG9yZV9l bmFibGUsIGZhbHNlKTsKKyAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQo JmRpc2stPnRydXN0ZWQsIHRydWUpOwogCiAgICAgcmMgPSBsaWJ4bF9fcmVz b2x2ZV9kb21pZChnYywgZGlzay0+YmFja2VuZF9kb21uYW1lLCAmZGlzay0+ YmFja2VuZF9kb21pZCk7CiAgICAgaWYgKHJjIDwgMCkgcmV0dXJuIHJjOwpA QCAtMzk1LDYgKzM5Niw4IEBAIHN0YXRpYyB2b2lkIGRldmljZV9kaXNrX2Fk ZChsaWJ4bF9fZWdjICplZ2MsIHVpbnQzMl90IGRvbWlkLAogICAgICAgICBm bGV4YXJyYXlfYXBwZW5kKGZyb250LCBHQ1NQUklOVEYoIiVkIiwgZGV2aWNl LT5kZXZpZCkpOwogICAgICAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250LCAi ZGV2aWNlLXR5cGUiKTsKICAgICAgICAgZmxleGFycmF5X2FwcGVuZChmcm9u dCwgZGlzay0+aXNfY2Ryb20gPyAiY2Ryb20iIDogImRpc2siKTsKKyAgICAg ICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwgInRydXN0ZWQiKTsKKyAgICAg ICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwgbGlieGxfZGVmYm9vbF92YWwo ZGlzay0+dHJ1c3RlZCkgPyAiMSIgOiAiMCIpOwogCiAgICAgICAgIC8qCiAg ICAgICAgICAqIE9sZCBQViBrZXJuZWwgZGlzayBmcm9udGVuZHMgYmVmb3Jl IDIuNi4yNiByZWx5IG9uIHRvb2wgc3RhY2sgdG8KZGlmZiAtLWdpdCBhL3Rv b2xzL2xpYnMvbGlnaHQvbGlieGxfbmljLmMgYi90b29scy9saWJzL2xpZ2h0 L2xpYnhsX25pYy5jCmluZGV4IDBiOWU3MGM5ZDEuLmQ2YmYwNmZjMzQgMTAw NjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfbmljLmMKKysrIGIv dG9vbHMvbGlicy9saWdodC9saWJ4bF9uaWMuYwpAQCAtMTE2LDYgKzExNiw4 IEBAIHN0YXRpYyBpbnQgbGlieGxfX2RldmljZV9uaWNfc2V0ZGVmYXVsdChs aWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKICAgICAgICAgYWJvcnQo KTsKICAgICB9CiAKKyAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJm5p Yy0+dHJ1c3RlZCwgdHJ1ZSk7CisKICAgICByZXR1cm4gcmM7CiB9CiAKQEAg LTI1NSw2ICsyNTcsOSBAQCBzdGF0aWMgaW50IGxpYnhsX19zZXRfeGVuc3Rv cmVfbmljKGxpYnhsX19nYyAqZ2MsIHVpbnQzMl90IGRvbWlkLAogICAgIGZs ZXhhcnJheV9hcHBlbmQoYmFjaywgImhvdHBsdWctc3RhdHVzIik7CiAgICAg ZmxleGFycmF5X2FwcGVuZChiYWNrLCAiIik7CiAKKyAgICBmbGV4YXJyYXlf YXBwZW5kKGZyb250LCAidHJ1c3RlZCIpOworICAgIGZsZXhhcnJheV9hcHBl bmQoZnJvbnQsIGxpYnhsX2RlZmJvb2xfdmFsKG5pYy0+dHJ1c3RlZCkgPyAi MSIgOiAiMCIpOworCiAgICAgcmV0dXJuIDA7CiB9CiAKZGlmZiAtLWdpdCBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsIGIvdG9vbHMvbGli cy9saWdodC9saWJ4bF90eXBlcy5pZGwKaW5kZXggMmE0MmRhMmY3ZC4uODk5 NjIyMThiNCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90 eXBlcy5pZGwKKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5p ZGwKQEAgLTcxMiw3ICs3MTIsOCBAQCBsaWJ4bF9kZXZpY2VfZGlzayA9IFN0 cnVjdCgiZGV2aWNlX2Rpc2siLCBbCiAgICAgKCJjb2xvX3BvcnQiLCBpbnRl Z2VyKSwKICAgICAoImNvbG9fZXhwb3J0Iiwgc3RyaW5nKSwKICAgICAoImFj dGl2ZV9kaXNrIiwgc3RyaW5nKSwKLSAgICAoImhpZGRlbl9kaXNrIiwgc3Ry aW5nKQorICAgICgiaGlkZGVuX2Rpc2siLCBzdHJpbmcpLAorICAgICgidHJ1 c3RlZCIsIGxpYnhsX2RlZmJvb2wpLAogICAgIF0pCiAKIGxpYnhsX2Rldmlj ZV9uaWMgPSBTdHJ1Y3QoImRldmljZV9uaWMiLCBbCkBAIC03ODAsNyArNzgx LDggQEAgbGlieGxfZGV2aWNlX25pYyA9IFN0cnVjdCgiZGV2aWNlX25pYyIs IFsKICAgICAoImNvbG9fZmlsdGVyX3NlY19yZWRpcmVjdG9yMV9vdXRkZXYi LCBzdHJpbmcpLAogICAgICgiY29sb19maWx0ZXJfc2VjX3Jld3JpdGVyMF9x dWV1ZSIsIHN0cmluZyksCiAgICAgKCJjb2xvX2NoZWNrcG9pbnRfaG9zdCIs IHN0cmluZyksCi0gICAgKCJjb2xvX2NoZWNrcG9pbnRfcG9ydCIsIHN0cmlu ZykKKyAgICAoImNvbG9fY2hlY2twb2ludF9wb3J0Iiwgc3RyaW5nKSwKKyAg ICAoInRydXN0ZWQiLCBsaWJ4bF9kZWZib29sKSwKICAgICBdKQogCiBsaWJ4 bF9kZXZpY2VfcGNpID0gU3RydWN0KCJkZXZpY2VfcGNpIiwgWwpkaWZmIC0t Z2l0IGEvdG9vbHMvbGlicy91dGlsL2xpYnhsdV9kaXNrX2wubCBiL3Rvb2xz L2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmwKaW5kZXggM2JkNjM5YWFiMC4u ZTExNTQ2MGQ5OSAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy91dGlsL2xpYnhs dV9kaXNrX2wubAorKysgYi90b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tf bC5sCkBAIC0yMDgsNiArMjA4LDkgQEAgY29sby1leHBvcnQ9W14sXSosPwl7 IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImNvbG8tZXhwb3J0IiwgY29sb19l eHBvcnQsIEZST01FUVUKIGFjdGl2ZS1kaXNrPVteLF0qLD8JeyBTVFJJUCgn LCcpOyBTQVZFU1RSSU5HKCJhY3RpdmUtZGlzayIsIGFjdGl2ZV9kaXNrLCBG Uk9NRVFVQUxTKTsgfQogaGlkZGVuLWRpc2s9W14sXSosPwl7IFNUUklQKCcs Jyk7IFNBVkVTVFJJTkcoImhpZGRlbi1kaXNrIiwgaGlkZGVuX2Rpc2ssIEZS T01FUVVBTFMpOyB9CiAKK3RydXN0ZWQsPwkJeyBsaWJ4bF9kZWZib29sX3Nl dCgmRFBDLT5kaXNrLT50cnVzdGVkLCB0cnVlKTsgfQordW50cnVzdGVkLD8J CXsgbGlieGxfZGVmYm9vbF9zZXQoJkRQQy0+ZGlzay0+dHJ1c3RlZCwgZmFs c2UpOyB9CisKICAvKiB0aGUgdGFyZ2V0IG1hZ2ljIHBhcmFtZXRlciwgZWF0 cyB0aGUgcmVzdCBvZiB0aGUgc3RyaW5nICovCiAKIHRhcmdldD0uKgl7IFNU UklQKCcsJyk7IFNBVkVTVFJJTkcoInRhcmdldCIsIHBkZXZfcGF0aCwgRlJP TUVRVUFMUyk7IH0KZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL2NoZWNrLXhsLWRp c2stcGFyc2UgYi90b29scy94bC9jaGVjay14bC1kaXNrLXBhcnNlCmluZGV4 IDY0M2Y0ZjRlY2IuLjE4ZmI2Njk0MGEgMTAwNzU1Ci0tLSBhL3Rvb2xzL3hs L2NoZWNrLXhsLWRpc2stcGFyc2UKKysrIGIvdG9vbHMveGwvY2hlY2steGwt ZGlzay1wYXJzZQpAQCAtMTc4LDQgKzE3OCwzMCBAQCBkaXNrOiB7CiBFTkQK IG9uZSAwICBjZHJvbSBuby1kaXNjYXJkIHZkZXY9aGRhIHRhcmdldD0vc29t ZS9kaXNrL2ltYWdlLmlzbwogCisjIHRlc3Qgc2V0dGluZyB0cnVzdGVkCitl eHBlY3RlZCA8PEVORAorZGlzazogeworICAgICJwZGV2X3BhdGgiOiAiL3Nv bWUvZGlzay9pbWFnZS5yYXciLAorICAgICJ2ZGV2IjogImhkYSIsCisgICAg ImZvcm1hdCI6ICJyYXciLAorICAgICJyZWFkd3JpdGUiOiAxLAorICAgICJ0 cnVzdGVkIjogIlRydWUiCit9CisKK0VORAorb25lIDAgIHRydXN0ZWQgdmRl dj1oZGEgdGFyZ2V0PS9zb21lL2Rpc2svaW1hZ2UucmF3CisKKyMgdGVzdCBz ZXR0aW5nIHVudHJ1c3RlZAorZXhwZWN0ZWQgPDxFTkQKK2Rpc2s6IHsKKyAg ICAicGRldl9wYXRoIjogIi9zb21lL2Rpc2svaW1hZ2UucmF3IiwKKyAgICAi dmRldiI6ICJoZGEiLAorICAgICJmb3JtYXQiOiAicmF3IiwKKyAgICAicmVh ZHdyaXRlIjogMSwKKyAgICAidHJ1c3RlZCI6ICJGYWxzZSIKK30KKworRU5E CitvbmUgMCAgdW50cnVzdGVkIHZkZXY9aGRhIHRhcmdldD0vc29tZS9kaXNr L2ltYWdlLnJhdworCiBjb21wbGV0ZQpkaWZmIC0tZ2l0IGEvdG9vbHMveGwv Y2hlY2steGwtdmlmLXBhcnNlIGIvdG9vbHMveGwvY2hlY2steGwtdmlmLXBh cnNlCmluZGV4IDA0YmQ5NDYzZDguLmQ2NjY0MDhkNGQgMTAwNzU1Ci0tLSBh L3Rvb2xzL3hsL2NoZWNrLXhsLXZpZi1wYXJzZQorKysgYi90b29scy94bC9j aGVjay14bC12aWYtcGFyc2UKQEAgLTE2MCw0ICsxNjAsMjIgQEAgb25lICRl IHJhdGU9NDI5Nk1CL3NANDI5NHMKIGV4cGVjdGVkIDwvZGV2L251bGwKIG9u ZSAkZSByYXRlPUAKIAorIyB0ZXN0IHRydXN0ZWQgc2V0dGluZworZXhwZWN0 ZWQgPDxFTkQKK3ZpZjogeworICAgICJ0cnVzdGVkIjogIlRydWUiCit9CisK K0VORAorb25lIDAgdHJ1c3RlZAorCisjIHRlc3QgdW50cnVzdGVkIHNldHRp bmcKK2V4cGVjdGVkIDw8RU5ECit2aWY6IHsKKyAgICAidHJ1c3RlZCI6ICJG YWxzZSIKK30KKworRU5ECitvbmUgMCB1bnRydXN0ZWQKKwogY29tcGxldGUK ZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMgYi90b29scy94bC94 bF9wYXJzZS5jCmluZGV4IGI5OGMwZGUzNzguLjY0NGFiOGY4ZmQgMTAwNjQ0 Ci0tLSBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMKKysrIGIvdG9vbHMveGwveGxf cGFyc2UuYwpAQCAtNTY1LDYgKzU2NSwxMCBAQCBpbnQgcGFyc2VfbmljX2Nv bmZpZyhsaWJ4bF9kZXZpY2VfbmljICpuaWMsIFhMVV9Db25maWcgKipjb25m aWcsIGNoYXIgKnRva2VuKQogICAgICAgICBuaWMtPmRldmlkID0gcGFyc2Vf dWxvbmcob3BhcmcpOwogICAgIH0gZWxzZSBpZiAoTUFUQ0hfT1BUSU9OKCJt dHUiLCB0b2tlbiwgb3BhcmcpKSB7CiAgICAgICAgIG5pYy0+bXR1ID0gcGFy c2VfdWxvbmcob3BhcmcpOworICAgIH0gZWxzZSBpZiAoIXN0cmNtcCgidHJ1 c3RlZCIsIHRva2VuKSkgeworICAgICAgICBsaWJ4bF9kZWZib29sX3NldCgm bmljLT50cnVzdGVkLCB0cnVlKTsKKyAgICB9IGVsc2UgaWYgKCFzdHJjbXAo InVudHJ1c3RlZCIsIHRva2VuKSkgeworICAgICAgICBsaWJ4bF9kZWZib29s X3NldCgmbmljLT50cnVzdGVkLCBmYWxzZSk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgZnByaW50ZihzdGRlcnIsICJ1bnJlY29nbml6ZWQgYXJndW1lbnQg YCVzJ1xuIiwgdG9rZW4pOwogICAgICAgICByZXR1cm4gMTsKZGlmZiAtLWdp dCBhL3hlbi9pbmNsdWRlL3B1YmxpYy9pby9ibGtpZi5oIGIveGVuL2luY2x1 ZGUvcHVibGljL2lvL2Jsa2lmLmgKaW5kZXggNGNkYmE3OWFiYS4uYWI4NjNm MTc1YSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lm LmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmgKQEAgLTM2 Myw2ICszNjMsMTQgQEAKICAqICAgICAgdGhhdCB0aGUgZnJvbnRlbmQgcmVx dWlyZXMgdGhhdCB0aGUgbG9naWNhbCBibG9jayBzaXplIGlzIDUxMiBhcyBp dAogICogICAgICBpcyBoYXJkY29kZWQgKHdoaWNoIGlzIHRoZSBjYXNlIGlu IHNvbWUgZnJvbnRlbmQgaW1wbGVtZW50YXRpb25zKS4KICAqCisgKiB0cnVz dGVkCisgKiAgICAgIFZhbHVlczogICAgICAgICAwLzEgKGJvb2xlYW4pCisg KiAgICAgIERlZmF1bHQgdmFsdWU6ICAxCisgKgorICogICAgICBBIHZhbHVl IG9mICIwIiBpbmRpY2F0ZXMgdGhhdCB0aGUgZnJvbnRlbmQgc2hvdWxkIG5v dCB0cnVzdCB0aGUKKyAqICAgICAgYmFja2VuZCwgYW5kIHNob3VsZCBkZXBs b3kgd2hhdGV2ZXIgbWVhc3VyZXMgYXZhaWxhYmxlIHRvIHByb3RlY3QgZnJv bQorICogICAgICBhIG1hbGljaW91cyBiYWNrZW5kIG9uIHRoZSBvdGhlciBl bmQuCisgKgogICotLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIFZpcnR1YWwg RGV2aWNlIFByb3BlcnRpZXMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQog ICoKICAqIGRldmljZS10eXBlCmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9w dWJsaWMvaW8vbmV0aWYuaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9pby9uZXRp Zi5oCmluZGV4IDAwZGQyNTg3MTIuLjM1MDliMDk2ZjggMTAwNjQ0Ci0tLSBh L3hlbi9pbmNsdWRlL3B1YmxpYy9pby9uZXRpZi5oCisrKyBiL3hlbi9pbmNs dWRlL3B1YmxpYy9pby9uZXRpZi5oCkBAIC0xNjAsNiArMTYwLDEyIEBACiAg KiBiZSBhcHBsaWVkIGlmIGl0IGlzIHNldC4KICAqLwogCisvKgorICogVGhl IHNldHRpbmcgb2YgInRydXN0ZWQiIG5vZGUgdG8gIjAiIGluIHRoZSBmcm9u dGVuZCBwYXRoIHNpZ25hbHMgdGhhdCB0aGUKKyAqIGZyb250ZW5kIHNob3Vs ZCBub3QgdHJ1c3QgdGhlIGJhY2tlbmQsIGFuZCBzaG91bGQgZGVwbG95IHdo YXRldmVyIG1lYXN1cmVzCisgKiBhdmFpbGFibGUgdG8gcHJvdGVjdCBmcm9t IGEgbWFsaWNpb3VzIGJhY2tlbmQgb24gdGhlIG90aGVyIGVuZC4KKyAqLwor CiAvKgogICogQ29udHJvbCByaW5nCiAgKiA9PT09PT09PT09PT0KLS0gCjIu MzYuMAoK --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-2.patch" Content-Disposition: attachment; filename="xsa403/xsa403-2.patch" Content-Transfer-Encoding: base64 RnJvbSBiMTExOWNhNWIyYjEyZDY3ZjIyMDRhM2YxMTBhODBiYzBkNzQ4NWNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBUaHUsIDMwIEp1biAy MDIyIDE0OjM1OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gdG9vbHMvbGli eGw6IGVudiB2YXJpYWJsZSB0byBzaWduYWwgd2hldGhlciBkaXNrL25pYyBi YWNrZW5kCiBpcyB0cnVzdGVkCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2Ugc3VwcG9ydCBpbiBsaWJ4 bCBmb3IgZmV0Y2hpbmcgdGhlIGRlZmF1bHQgYmFja2VuZCB0cnVzdGVkCm9w dGlvbiBmb3IgZGlzayBhbmQgbmljIGRldmljZXMuCgpVc2VycyBjYW4gc2V0 IGxpYnhsX3tkaXNrLG5pY31fYmFja2VuZF91bnRydXN0ZWQgZW52aXJvbm1l bnQgdmFyaWFibGUKdG8gbm90aWZ5IGxpYnhsIG9mIHdoZXRoZXIgdGhlIGJh Y2tlbmRzIGZvciBkaXNrIGFuZCBuaWMgZGV2aWNlcwpzaG91bGQgYmUgdHJ1 c3RlZC4gIFN1Y2ggaW5mb3JtYXRpb24gaXMgcGFzc2VkIGludG8gdGhlIGZy b250ZW5kIHNvIGl0CmNhbiB0YWtlIHRoZSBhcHByb3ByaWF0ZSBtZWFzdXJl cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDAzLgoKV0FSTklORzogdGhpcyBw YXRjaCB3aWxsIG5ldmVyIGJlIGFwcGxpZWQgdG8gdGhlIGludGVuZGVkCnJl cG9zaXRvcnkvYnJhbmNoIGJlY2F1c2UgaXQncyBvbmx5IGZvciBzdGFibGUg YnJhbmNoZXMgaW4gb3JkZXIgdG8KYXZvaWQgYnJlYWtpbmcgdGhlIGxpYnhs IEFCSS4KClNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2Vy LnBhdUBjaXRyaXguY29tPgotLS0KIHRvb2xzL2xpYnMvbGlnaHQvbGlieGxf ZGlzay5jIHwgNSArKysrLQogdG9vbHMvbGlicy9saWdodC9saWJ4bF9uaWMu YyAgfCA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygr KSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS90b29scy9saWJzL2xp Z2h0L2xpYnhsX2Rpc2suYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZGlz ay5jCmluZGV4IDlkYTJiMmVkMjcuLmVjMTdlZDcyOTcgMTAwNjQ0Ci0tLSBh L3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZGlzay5jCisrKyBiL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfZGlzay5jCkBAIC0xNTksNyArMTU5LDEwIEBAIHN0 YXRpYyBpbnQgbGlieGxfX2RldmljZV9kaXNrX3NldGRlZmF1bHQobGlieGxf X2djICpnYywgdWludDMyX3QgZG9taWQsCiAgICAgbGlieGxfZGVmYm9vbF9z ZXRkZWZhdWx0KCZkaXNrLT5kaXNjYXJkX2VuYWJsZSwgISFkaXNrLT5yZWFk d3JpdGUpOwogICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgmZGlzay0+ Y29sb19lbmFibGUsIGZhbHNlKTsKICAgICBsaWJ4bF9kZWZib29sX3NldGRl ZmF1bHQoJmRpc2stPmNvbG9fcmVzdG9yZV9lbmFibGUsIGZhbHNlKTsKLSAg ICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmRpc2stPnRydXN0ZWQsIHRy dWUpOworICAgIGlmIChnZXRlbnYoImxpYnhsX2Rpc2tfYmFja2VuZF91bnRy dXN0ZWQiKSkKKyAgICAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZk aXNrLT50cnVzdGVkLCBmYWxzZSk7CisgICAgZWxzZQorICAgICAgICBsaWJ4 bF9kZWZib29sX3NldGRlZmF1bHQoJmRpc2stPnRydXN0ZWQsIHRydWUpOwog CiAgICAgcmMgPSBsaWJ4bF9fcmVzb2x2ZV9kb21pZChnYywgZGlzay0+YmFj a2VuZF9kb21uYW1lLCAmZGlzay0+YmFja2VuZF9kb21pZCk7CiAgICAgaWYg KHJjIDwgMCkgcmV0dXJuIHJjOwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9s aWdodC9saWJ4bF9uaWMuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfbmlj LmMKaW5kZXggZDZiZjA2ZmMzNC4uMTlmNmVlMWNkNCAxMDA2NDQKLS0tIGEv dG9vbHMvbGlicy9saWdodC9saWJ4bF9uaWMuYworKysgYi90b29scy9saWJz L2xpZ2h0L2xpYnhsX25pYy5jCkBAIC0xMTYsNyArMTE2LDEwIEBAIHN0YXRp YyBpbnQgbGlieGxfX2RldmljZV9uaWNfc2V0ZGVmYXVsdChsaWJ4bF9fZ2Mg KmdjLCB1aW50MzJfdCBkb21pZCwKICAgICAgICAgYWJvcnQoKTsKICAgICB9 CiAKLSAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJm5pYy0+dHJ1c3Rl ZCwgdHJ1ZSk7CisgICAgaWYgKGdldGVudigibGlieGxfbmljX2JhY2tlbmRf dW50cnVzdGVkIikpCisgICAgICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVs dCgmbmljLT50cnVzdGVkLCBmYWxzZSk7CisgICAgZWxzZQorICAgICAgICBs aWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJm5pYy0+dHJ1c3RlZCwgdHJ1ZSk7 CiAKICAgICByZXR1cm4gcmM7CiB9Ci0tIAoyLjM3LjAKCg== --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-4.14-1.patch" Content-Disposition: attachment; filename="xsa403/xsa403-4.14-1.patch" Content-Transfer-Encoding: base64 RnJvbSAzNDBjYjkzOGI5NTdhMmJhYWFlZTE3MDBhODgyMTQ4ZGM0Yzc4OGJj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBUaHUsIDMwIEp1biAy MDIyIDE0OjM1OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gdG9vbHMvbGli eGw6IGVudiB2YXJpYWJsZSB0byBzaWduYWwgd2hldGhlciBkaXNrL25pYyBi YWNrZW5kCiBpcyB0cnVzdGVkCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2Ugc3VwcG9ydCBpbiBsaWJ4 bCBmb3IgZmV0Y2hpbmcgdGhlIGRlZmF1bHQgYmFja2VuZCB0cnVzdGVkCm9w dGlvbiBmb3IgZGlzayBhbmQgbmljIGRldmljZXMuCgpVc2VycyBjYW4gc2V0 IGxpYnhsX3tkaXNrLG5pY31fYmFja2VuZF91bnRydXN0ZWQgZW52aXJvbm1l bnQgdmFyaWFibGUKdG8gbm90aWZ5IGxpYnhsIG9mIHdoZXRoZXIgdGhlIGJh Y2tlbmRzIGZvciBkaXNrIGFuZCBuaWMgZGV2aWNlcwpzaG91bGQgYmUgdHJ1 c3RlZC4gIFN1Y2ggaW5mb3JtYXRpb24gaXMgcGFzc2VkIGludG8gdGhlIGZy b250ZW5kIHNvIGl0CmNhbiB0YWtlIHRoZSBhcHByb3ByaWF0ZSBtZWFzdXJl cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDAzLgoKU2lnbmVkLW9mZi1ieTog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Ci0tLQog dG9vbHMvbGlieGwvbGlieGxfZGlzay5jIHwgMyArKysKIHRvb2xzL2xpYnhs L2xpYnhsX25pYy5jICB8IDMgKysrCiAyIGZpbGVzIGNoYW5nZWQsIDYgaW5z ZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2Rp c2suYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2Rpc2suYwppbmRleCBkZGMxZWVj MTc2Li4zNjg2MmJiYmNiIDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4 bF9kaXNrLmMKKysrIGIvdG9vbHMvbGlieGwvbGlieGxfZGlzay5jCkBAIC0z OTUsNiArMzk1LDkgQEAgc3RhdGljIHZvaWQgZGV2aWNlX2Rpc2tfYWRkKGxp YnhsX19lZ2MgKmVnYywgdWludDMyX3QgZG9taWQsCiAgICAgICAgIGZsZXhh cnJheV9hcHBlbmQoZnJvbnQsIEdDU1BSSU5URigiJWQiLCBkZXZpY2UtPmRl dmlkKSk7CiAgICAgICAgIGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsICJkZXZp Y2UtdHlwZSIpOwogICAgICAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250LCBk aXNrLT5pc19jZHJvbSA/ICJjZHJvbSIgOiAiZGlzayIpOworICAgICAgICBm bGV4YXJyYXlfYXBwZW5kKGZyb250LCAidHJ1c3RlZCIpOworICAgICAgICBm bGV4YXJyYXlfYXBwZW5kKGZyb250LCBnZXRlbnYoImxpYnhsX2Rpc2tfYmFj a2VuZF91bnRydXN0ZWQiKSA/ICIwIgorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA6ICIxIik7CiAKICAgICAgICAgLyoKICAgICAgICAgICogT2xkIFBW IGtlcm5lbCBkaXNrIGZyb250ZW5kcyBiZWZvcmUgMi42LjI2IHJlbHkgb24g dG9vbCBzdGFjayB0bwpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGxf bmljLmMgYi90b29scy9saWJ4bC9saWJ4bF9uaWMuYwppbmRleCAwNzg4MGIz OWUxLi40ZDA5ZmI4YjQ2IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4 bF9uaWMuYworKysgYi90b29scy9saWJ4bC9saWJ4bF9uaWMuYwpAQCAtMjM3 LDYgKzIzNyw5IEBAIHN0YXRpYyBpbnQgbGlieGxfX3NldF94ZW5zdG9yZV9u aWMobGlieGxfX2djICpnYywgdWludDMyX3QgZG9taWQsCiAgICAgZmxleGFy cmF5X2FwcGVuZChmcm9udCwgR0NTUFJJTlRGKAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgTElCWExfTUFDX0ZNVCwgTElCWExfTUFD X0JZVEVTKG5pYy0+bWFjKSkpOwogCisgICAgZmxleGFycmF5X2FwcGVuZChm cm9udCwgInRydXN0ZWQiKTsKKyAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250 LCBnZXRlbnYoImxpYnhsX25pY19iYWNrZW5kX3VudHJ1c3RlZCIpID8gIjAi IDogIjEiKTsKKwogICAgIHJldHVybiAwOwogfQogCi0tIAoyLjM3LjAKCg== --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-4.14-2.patch" Content-Disposition: attachment; filename="xsa403/xsa403-4.14-2.patch" Content-Transfer-Encoding: base64 RnJvbSBlZDFlMGMzNjQ2NDFhNTJmZGZlYWM0YjQxZjUyZjFjMDc0NzkxNTZj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBGcmksIDggQXByIDIw MjIgMTA6MjE6MTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSB0b29scy9saWJ4 bDogcmVwb3J0IHRydXN0ZWQgYmFja2VuZCBzdGF0dXMgdG8gZnJvbnRlbmRz Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsg Y2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0 CgpBbGxvdyBhZG1pbmlzdHJhdG9ycyB0byBub3RpZnkgYSBmcm9udGVuZCBk cml2ZXIgdGhhdCBpdCdzIGJhY2tlbmQKY291bnRlcnBhcnQgaXMgbm90IHRv IGJlIHRydXN0ZWQsIHNvIHRoZSBmcm9udGVuZCBjYW4gZGVwbG95IHdoYXRl dmVyCm1pdGlnYXRpb25zIHJlcXVpcmVkIGluIG9yZGVyIHRvIHNlY3VyZSBp dHNlbGYuCgpBbGxvdyBzdWNoIG9wdGlvbiBmb3IgZGlzayBhbmQgbmV0d29y ayBmcm9udGVuZHMgb25seSwgYXMgdGhvc2UgYXJlCnRoZSBvbmx5IGhhcmRl bmVkIG9uZXMgY3VycmVudGx5IHN1cHBvcnRlZC4KClRoaXMgaXMgcGFydCBv ZiBYU0EtNDAzCgpXQVJOSU5HOiB0aGlzIHBhdGNoIHdpbGwgbmV2ZXIgYmUg YXBwbGllZCB0byB0aGUgaW50ZW5kZWQKcmVwb3NpdG9yeS9icmFuY2ggYmVj YXVzZSBpdCBicmVha3MgdGhlIGxpYnhsIEFCSS4KClNpZ25lZC1vZmYtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZp ZXdlZC1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJp eC5jb20+Ci0tLQogZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUu cG9kICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKysrKwogZG9jcy9t YW4veGwtbmV0d29yay1jb25maWd1cmF0aW9uLjUucG9kIHwgIDkgKysrKysr KysKIHRvb2xzL2xpYnhsL2NoZWNrLXhsLWRpc2stcGFyc2UgICAgICAgICB8 IDI2ICsrKysrKysrKysrKysrKysrKysrKysKIHRvb2xzL2xpYnhsL2NoZWNr LXhsLXZpZi1wYXJzZSAgICAgICAgICB8IDE4ICsrKysrKysrKysrKysrKwog dG9vbHMvbGlieGwvbGlieGwuaCAgICAgICAgICAgICAgICAgICAgIHwgIDgg KysrKysrKwogdG9vbHMvbGlieGwvbGlieGxfZGlzay5jICAgICAgICAgICAg ICAgIHwgIDQgKystLQogdG9vbHMvbGlieGwvbGlieGxfbmljLmMgICAgICAg ICAgICAgICAgIHwgIDQgKysrLQogdG9vbHMvbGlieGwvbGlieGxfdHlwZXMu aWRsICAgICAgICAgICAgIHwgIDYgKysrLS0KIHRvb2xzL2xpYnhsL2xpYnhs dV9kaXNrX2wubCAgICAgICAgICAgICB8ICAzICsrKwogdG9vbHMveGwveGxf cGFyc2UuYyAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysKIHhlbi9pbmNs dWRlL3B1YmxpYy9pby9ibGtpZi5oICAgICAgICAgICB8ICA4ICsrKysrKysK IHhlbi9pbmNsdWRlL3B1YmxpYy9pby9uZXRpZi5oICAgICAgICAgICB8ICA2 ICsrKysrCiAxMiBmaWxlcyBjaGFuZ2VkLCAxMTggaW5zZXJ0aW9ucygrKSwg NSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kb2NzL21hbi94bC1kaXNr LWNvbmZpZ3VyYXRpb24uNS5wb2QgYi9kb2NzL21hbi94bC1kaXNrLWNvbmZp Z3VyYXRpb24uNS5wb2QKaW5kZXggNDZmZWVkYjk1ZS4uYWY2MmEyNTY4MyAx MDA2NDQKLS0tIGEvZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUu cG9kCisrKyBiL2RvY3MvbWFuL3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBv ZApAQCAtMzQ0LDYgKzM0NCwzNSBAQCBjYW4gYmUgdXNlZCB0byBkaXNhYmxl ICJob2xlIHB1bmNoaW5nIiBmb3IgZmlsZSBiYXNlZCBiYWNrZW5kcyB3aGlj aAogd2VyZSBpbnRlbnRpb25hbGx5IGNyZWF0ZWQgbm9uLXNwYXJzZSB0byBh dm9pZCBmcmFnbWVudGF0aW9uIG9mIHRoZQogZmlsZS4KIAorPWl0ZW0gQjx0 cnVzdGVkPiAvIEI8dW50cnVzdGVkPgorCis9b3ZlciA0CisKKz1pdGVtIERl c2NyaXB0aW9uCisKK1JlcG9ydHMgd2hldGhlciB0aGUgYmFja2VuZCBzaG91 bGQgYmUgdHJ1c3RlZCBieSB0aGUgZnJvbnRlbmQKKworPWl0ZW0gU3VwcG9y dGVkIHZhbHVlcworCit0cnVzdGVkLCB1bnRydXN0ZWQKKworPWl0ZW0gTWFu ZGF0b3J5CisKK05vCisKKz1pdGVtIERlZmF1bHQgdmFsdWUKKwordHJ1c3Rl ZAorCis9YmFjaworCitBbiBhZHZpc29yeSBzZXR0aW5nIGZvciB0aGUgZnJv bnRlbmQgZHJpdmVyIG9uIHdoZXRoZXIgdGhlIGJhY2tlbmQgc2hvdWxkIGJl Cit0cnVzdGVkLiAgVGhlIGZyb250ZW5kIHNob3VsZCBkZXBsb3kgd2hhdGV2 ZXIgcHJvdGVjdGlvbnMgaXQgaGFzIGF2YWlsYWJsZSB0bworcHJldmVudCBh biB1bnRydXN0ZWQgYmFja2VuZCBmcm9tIGFjY2Vzc2luZyBndWVzdCBkYXRh IG5vdCByZWxhdGVkIHRvIHRoZSBJL08KK3Byb2Nlc3Npbmcgb3IgY2F1c2lu ZyBtYWxmdW5jdGlvbiB0byB0aGUgZnJvbnRlbmQgb3IgdGhlIHdob2xlIGRv bWFpbi4KKworTm90ZSBmcm9udGVuZHMgY2FuIGlnbm9yZSBzdWNoIHJlY29t bWVuZGF0aW9uLgorCiA9YmFjawogCiAKZGlmZiAtLWdpdCBhL2RvY3MvbWFu L3hsLW5ldHdvcmstY29uZmlndXJhdGlvbi41LnBvZCBiL2RvY3MvbWFuL3hs LW5ldHdvcmstY29uZmlndXJhdGlvbi41LnBvZAppbmRleCAwYWMyNGM0YTE4 Li5kMzIzY2RhY2Q5IDEwMDY0NAotLS0gYS9kb2NzL21hbi94bC1uZXR3b3Jr LWNvbmZpZ3VyYXRpb24uNS5wb2QKKysrIGIvZG9jcy9tYW4veGwtbmV0d29y ay1jb25maWd1cmF0aW9uLjUucG9kCkBAIC0yNDksMyArMjQ5LDEyIEBAIG9u IHRoZSB1bmRlcmx5aW5nIG5ldGJhY2sgaW1wbGVtZW50YXRpb24uCiBTcGVj aWZpZXMgdGhlIGRldmlkIG1hbnVhbGx5IGluc3RlYWQgb2YgbGV0dGluZyB4 bCBjaG9vc2UgdGhlIGxvd2VzdCBpbmRleCBhdmFpbGFibGUuCiAKIE5PVEU6 IFRoaXMgc2hvdWxkIG5vdCBiZSBzZXQgdW5sZXNzIHlvdSBoYXZlIGEgcmVh c29uIHRvLgorCis9aGVhZDIgdHJ1c3RlZCAvIHVudHJ1c3RlZAorCitBbiBh ZHZpc29yeSBzZXR0aW5nIGZvciB0aGUgZnJvbnRlbmQgZHJpdmVyIG9uIHdo ZXRoZXIgdGhlIGJhY2tlbmQgc2hvdWxkIGJlCit0cnVzdGVkLiAgVGhlIGZy b250ZW5kIHNob3VsZCBkZXBsb3kgd2hhdGV2ZXIgcHJvdGVjdGlvbnMgaXQg aGFzIGF2YWlsYWJsZSB0bworcHJldmVudCBhbiB1bnRydXN0ZWQgYmFja2Vu ZCBmcm9tIGFjY2Vzc2luZyBndWVzdCBkYXRhIG5vdCByZWxhdGVkIHRvIHRo ZSBJL08KK3Byb2Nlc3Npbmcgb3IgY2F1c2luZyBtYWxmdW5jdGlvbiB0byB0 aGUgZnJvbnRlbmQgb3IgdGhlIHdob2xlIGRvbWFpbi4KKworTm90ZSBmcm9u dGVuZHMgY2FuIGlnbm9yZSBzdWNoIHJlY29tbWVuZGF0aW9uLgpkaWZmIC0t Z2l0IGEvdG9vbHMvbGlieGwvY2hlY2steGwtZGlzay1wYXJzZSBiL3Rvb2xz L2xpYnhsL2NoZWNrLXhsLWRpc2stcGFyc2UKaW5kZXggNjQzZjRmNGVjYi4u MThmYjY2OTQwYSAxMDA3NTUKLS0tIGEvdG9vbHMvbGlieGwvY2hlY2steGwt ZGlzay1wYXJzZQorKysgYi90b29scy9saWJ4bC9jaGVjay14bC1kaXNrLXBh cnNlCkBAIC0xNzgsNCArMTc4LDMwIEBAIGRpc2s6IHsKIEVORAogb25lIDAg IGNkcm9tIG5vLWRpc2NhcmQgdmRldj1oZGEgdGFyZ2V0PS9zb21lL2Rpc2sv aW1hZ2UuaXNvCiAKKyMgdGVzdCBzZXR0aW5nIHRydXN0ZWQKK2V4cGVjdGVk IDw8RU5ECitkaXNrOiB7CisgICAgInBkZXZfcGF0aCI6ICIvc29tZS9kaXNr L2ltYWdlLnJhdyIsCisgICAgInZkZXYiOiAiaGRhIiwKKyAgICAiZm9ybWF0 IjogInJhdyIsCisgICAgInJlYWR3cml0ZSI6IDEsCisgICAgInRydXN0ZWQi OiAiVHJ1ZSIKK30KKworRU5ECitvbmUgMCAgdHJ1c3RlZCB2ZGV2PWhkYSB0 YXJnZXQ9L3NvbWUvZGlzay9pbWFnZS5yYXcKKworIyB0ZXN0IHNldHRpbmcg dW50cnVzdGVkCitleHBlY3RlZCA8PEVORAorZGlzazogeworICAgICJwZGV2 X3BhdGgiOiAiL3NvbWUvZGlzay9pbWFnZS5yYXciLAorICAgICJ2ZGV2Ijog ImhkYSIsCisgICAgImZvcm1hdCI6ICJyYXciLAorICAgICJyZWFkd3JpdGUi OiAxLAorICAgICJ0cnVzdGVkIjogIkZhbHNlIgorfQorCitFTkQKK29uZSAw ICB1bnRydXN0ZWQgdmRldj1oZGEgdGFyZ2V0PS9zb21lL2Rpc2svaW1hZ2Uu cmF3CisKIGNvbXBsZXRlCmRpZmYgLS1naXQgYS90b29scy9saWJ4bC9jaGVj ay14bC12aWYtcGFyc2UgYi90b29scy9saWJ4bC9jaGVjay14bC12aWYtcGFy c2UKaW5kZXggMDJjNmRiYWViNi4uNjZmNmZjYmRiMyAxMDA3NTUKLS0tIGEv dG9vbHMvbGlieGwvY2hlY2steGwtdmlmLXBhcnNlCisrKyBiL3Rvb2xzL2xp YnhsL2NoZWNrLXhsLXZpZi1wYXJzZQpAQCAtMjEwLDQgKzIxMCwyMiBAQCBv bmUgJGUgcmF0ZT00Mjk2TUIvc0A0Mjk0cwogZXhwZWN0ZWQgPC9kZXYvbnVs bAogb25lICRlIHJhdGU9QAogCisjIHRlc3QgdHJ1c3RlZCBzZXR0aW5nCitl eHBlY3RlZCA8PEVORAordmlmOiB7CisgICAgInRydXN0ZWQiOiAiVHJ1ZSIK K30KKworRU5ECitvbmUgMCB0cnVzdGVkCisKKyMgdGVzdCB1bnRydXN0ZWQg c2V0dGluZworZXhwZWN0ZWQgPDxFTkQKK3ZpZjogeworICAgICJ0cnVzdGVk IjogIkZhbHNlIgorfQorCitFTkQKK29uZSAwIHVudHJ1c3RlZAorCiBjb21w bGV0ZQpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGlieGwuaCBiL3Rvb2xz L2xpYnhsL2xpYnhsLmgKaW5kZXggMWNkNmMzOGU4My4uODY1NTA2ZDFkZCAx MDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGwuaAorKysgYi90b29scy9s aWJ4bC9saWJ4bC5oCkBAIC00MzgsNiArNDM4LDE0IEBACiAgKi8KICNkZWZp bmUgTElCWExfSEFWRV9DUkVBVEVJTkZPX1BBU1NUSFJPVUdIIDEKIAorLyoK KyAqIExJQlhMX0hBVkVfe0RJU0ssTklDfV9UUlVTVEVEIGluZGljYXRlcyB0 aGF0IHRoZSBsaWJ4bF9kZXZpY2VfZGlzayBhbmQKKyAqIGxpYnhsX2Rldmlj ZV9uaWMgc3RydWN0cyBoYXZlIGEgZmllbGQgdG8gc2lnbmFsIHdoZXRoZXIg dGhlIGJhY2tlbmQgb2YgdGhlCisgKiBkZXZpY2UgaXMgdG8gYmUgdHJ1c3Rl ZC4gIFN1Y2ggaW5mb3JtYXRpb24gaXMgcHJvcGFnYXRlZCB0byB0aGUgZnJv bnRlbmQuCisgKi8KKyNkZWZpbmUgTElCWExfSEFWRV9ESVNLX1RSVVNURUQg MQorI2RlZmluZSBMSUJYTF9IQVZFX05JQ19UUlVTVEVEIDEKKwogLyoKICAq IGxpYnhsIEFCSSBjb21wYXRpYmlsaXR5CiAgKgpkaWZmIC0tZ2l0IGEvdG9v bHMvbGlieGwvbGlieGxfZGlzay5jIGIvdG9vbHMvbGlieGwvbGlieGxfZGlz ay5jCmluZGV4IDM2ODYyYmJiY2IuLjViNTA0MWQzOTEgMTAwNjQ0Ci0tLSBh L3Rvb2xzL2xpYnhsL2xpYnhsX2Rpc2suYworKysgYi90b29scy9saWJ4bC9s aWJ4bF9kaXNrLmMKQEAgLTE1OSw2ICsxNTksNyBAQCBzdGF0aWMgaW50IGxp YnhsX19kZXZpY2VfZGlza19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsIHVp bnQzMl90IGRvbWlkLAogICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVsdCgm ZGlzay0+ZGlzY2FyZF9lbmFibGUsICEhZGlzay0+cmVhZHdyaXRlKTsKICAg ICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmRpc2stPmNvbG9fZW5hYmxl LCBmYWxzZSk7CiAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZkaXNr LT5jb2xvX3Jlc3RvcmVfZW5hYmxlLCBmYWxzZSk7CisgICAgbGlieGxfZGVm Ym9vbF9zZXRkZWZhdWx0KCZkaXNrLT50cnVzdGVkLCB0cnVlKTsKIAogICAg IHJjID0gbGlieGxfX3Jlc29sdmVfZG9taWQoZ2MsIGRpc2stPmJhY2tlbmRf ZG9tbmFtZSwgJmRpc2stPmJhY2tlbmRfZG9taWQpOwogICAgIGlmIChyYyA8 IDApIHJldHVybiByYzsKQEAgLTM5Niw4ICszOTcsNyBAQCBzdGF0aWMgdm9p ZCBkZXZpY2VfZGlza19hZGQobGlieGxfX2VnYyAqZWdjLCB1aW50MzJfdCBk b21pZCwKICAgICAgICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwgImRldmlj ZS10eXBlIik7CiAgICAgICAgIGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsIGRp c2stPmlzX2Nkcm9tID8gImNkcm9tIiA6ICJkaXNrIik7CiAgICAgICAgIGZs ZXhhcnJheV9hcHBlbmQoZnJvbnQsICJ0cnVzdGVkIik7Ci0gICAgICAgIGZs ZXhhcnJheV9hcHBlbmQoZnJvbnQsIGdldGVudigibGlieGxfZGlza19iYWNr ZW5kX3VudHJ1c3RlZCIpID8gIjAiCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIDogIjEiKTsKKyAgICAgICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwg bGlieGxfZGVmYm9vbF92YWwoZGlzay0+dHJ1c3RlZCkgPyAiMSIgOiAiMCIp OwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIE9sZCBQViBrZXJuZWwgZGlz ayBmcm9udGVuZHMgYmVmb3JlIDIuNi4yNiByZWx5IG9uIHRvb2wgc3RhY2sg dG8KZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX25pYy5jIGIvdG9v bHMvbGlieGwvbGlieGxfbmljLmMKaW5kZXggNGQwOWZiOGI0Ni4uYTkzZjVh MmQ2NCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfbmljLmMKKysr IGIvdG9vbHMvbGlieGwvbGlieGxfbmljLmMKQEAgLTExMyw2ICsxMTMsOCBA QCBzdGF0aWMgaW50IGxpYnhsX19kZXZpY2VfbmljX3NldGRlZmF1bHQobGli eGxfX2djICpnYywgdWludDMyX3QgZG9taWQsCiAgICAgICAgIGFib3J0KCk7 CiAgICAgfQogCisgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZuaWMt PnRydXN0ZWQsIHRydWUpOworCiAgICAgcmV0dXJuIHJjOwogfQogCkBAIC0y MzgsNyArMjQwLDcgQEAgc3RhdGljIGludCBsaWJ4bF9fc2V0X3hlbnN0b3Jl X25pYyhsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIExJQlhMX01BQ19GTVQsIExJ QlhMX01BQ19CWVRFUyhuaWMtPm1hYykpKTsKIAogICAgIGZsZXhhcnJheV9h cHBlbmQoZnJvbnQsICJ0cnVzdGVkIik7Ci0gICAgZmxleGFycmF5X2FwcGVu ZChmcm9udCwgZ2V0ZW52KCJsaWJ4bF9uaWNfYmFja2VuZF91bnRydXN0ZWQi KSA/ICIwIiA6ICIxIik7CisgICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwg bGlieGxfZGVmYm9vbF92YWwobmljLT50cnVzdGVkKSA/ICIxIiA6ICIwIik7 CiAKICAgICByZXR1cm4gMDsKIH0KZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhs L2xpYnhsX3R5cGVzLmlkbCBiL3Rvb2xzL2xpYnhsL2xpYnhsX3R5cGVzLmlk bAppbmRleCA5ZDNmMDVmMzk5Li5lMzkxZGQ4OTExIDEwMDY0NAotLS0gYS90 b29scy9saWJ4bC9saWJ4bF90eXBlcy5pZGwKKysrIGIvdG9vbHMvbGlieGwv bGlieGxfdHlwZXMuaWRsCkBAIC02OTgsNyArNjk4LDggQEAgbGlieGxfZGV2 aWNlX2Rpc2sgPSBTdHJ1Y3QoImRldmljZV9kaXNrIiwgWwogICAgICgiY29s b19wb3J0IiwgaW50ZWdlciksCiAgICAgKCJjb2xvX2V4cG9ydCIsIHN0cmlu ZyksCiAgICAgKCJhY3RpdmVfZGlzayIsIHN0cmluZyksCi0gICAgKCJoaWRk ZW5fZGlzayIsIHN0cmluZykKKyAgICAoImhpZGRlbl9kaXNrIiwgc3RyaW5n KSwKKyAgICAoInRydXN0ZWQiLCBsaWJ4bF9kZWZib29sKSwKICAgICBdKQog CiBsaWJ4bF9kZXZpY2VfbmljID0gU3RydWN0KCJkZXZpY2VfbmljIiwgWwpA QCAtNzY2LDcgKzc2Nyw4IEBAIGxpYnhsX2RldmljZV9uaWMgPSBTdHJ1Y3Qo ImRldmljZV9uaWMiLCBbCiAgICAgKCJjb2xvX2ZpbHRlcl9zZWNfcmVkaXJl Y3RvcjFfb3V0ZGV2Iiwgc3RyaW5nKSwKICAgICAoImNvbG9fZmlsdGVyX3Nl Y19yZXdyaXRlcjBfcXVldWUiLCBzdHJpbmcpLAogICAgICgiY29sb19jaGVj a3BvaW50X2hvc3QiLCBzdHJpbmcpLAotICAgICgiY29sb19jaGVja3BvaW50 X3BvcnQiLCBzdHJpbmcpCisgICAgKCJjb2xvX2NoZWNrcG9pbnRfcG9ydCIs IHN0cmluZyksCisgICAgKCJ0cnVzdGVkIiwgbGlieGxfZGVmYm9vbCksCiAg ICAgXSkKIAogbGlieGxfZGV2aWNlX3BjaSA9IFN0cnVjdCgiZGV2aWNlX3Bj aSIsIFsKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsdV9kaXNrX2wu bCBiL3Rvb2xzL2xpYnhsL2xpYnhsdV9kaXNrX2wubAppbmRleCA3YTQ2ZjRh MzBjLi4wODJiYjJjZTc4IDEwMDY0NAotLS0gYS90b29scy9saWJ4bC9saWJ4 bHVfZGlza19sLmwKKysrIGIvdG9vbHMvbGlieGwvbGlieGx1X2Rpc2tfbC5s CkBAIC0yMDgsNiArMjA4LDkgQEAgY29sby1leHBvcnQ9W14sXSosPwl7IFNU UklQKCcsJyk7IFNBVkVTVFJJTkcoImNvbG8tZXhwb3J0IiwgY29sb19leHBv cnQsIEZST01FUVUKIGFjdGl2ZS1kaXNrPVteLF0qLD8JeyBTVFJJUCgnLCcp OyBTQVZFU1RSSU5HKCJhY3RpdmUtZGlzayIsIGFjdGl2ZV9kaXNrLCBGUk9N RVFVQUxTKTsgfQogaGlkZGVuLWRpc2s9W14sXSosPwl7IFNUUklQKCcsJyk7 IFNBVkVTVFJJTkcoImhpZGRlbi1kaXNrIiwgaGlkZGVuX2Rpc2ssIEZST01F UVVBTFMpOyB9CiAKK3RydXN0ZWQsPwkJeyBsaWJ4bF9kZWZib29sX3NldCgm RFBDLT5kaXNrLT50cnVzdGVkLCB0cnVlKTsgfQordW50cnVzdGVkLD8JCXsg bGlieGxfZGVmYm9vbF9zZXQoJkRQQy0+ZGlzay0+dHJ1c3RlZCwgZmFsc2Up OyB9CisKICAvKiB0aGUgdGFyZ2V0IG1hZ2ljIHBhcmFtZXRlciwgZWF0cyB0 aGUgcmVzdCBvZiB0aGUgc3RyaW5nICovCiAKIHRhcmdldD0uKgl7IFNUUklQ KCcsJyk7IFNBVkVTVFJJTkcoInRhcmdldCIsIHBkZXZfcGF0aCwgRlJPTUVR VUFMUyk7IH0KZGlmZiAtLWdpdCBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMgYi90 b29scy94bC94bF9wYXJzZS5jCmluZGV4IDM0YWMyMDc3M2QuLjIwYWFlODBi NTkgMTAwNjQ0Ci0tLSBhL3Rvb2xzL3hsL3hsX3BhcnNlLmMKKysrIGIvdG9v bHMveGwveGxfcGFyc2UuYwpAQCAtNTYzLDYgKzU2Myw4IEBAIGludCBwYXJz ZV9uaWNfY29uZmlnKGxpYnhsX2RldmljZV9uaWMgKm5pYywgWExVX0NvbmZp ZyAqKmNvbmZpZywgY2hhciAqdG9rZW4pCiAgICAgICAgIGZwcmludGYoc3Rk ZXJyLCAidGhlIGFjY2VsIHBhcmFtZXRlciBmb3IgdmlmcyBpcyBjdXJyZW50 bHkgbm90IHN1cHBvcnRlZFxuIik7CiAgICAgfSBlbHNlIGlmIChNQVRDSF9P UFRJT04oImRldmlkIiwgdG9rZW4sIG9wYXJnKSkgewogICAgICAgICBuaWMt PmRldmlkID0gcGFyc2VfdWxvbmcob3BhcmcpOworICAgIH0gZWxzZSBpZiAo IXN0cmNtcCgidW50cnVzdGVkIiwgdG9rZW4pKSB7CisgICAgICAgIGxpYnhs X2RlZmJvb2xfc2V0KCZuaWMtPnRydXN0ZWQsIGZhbHNlKTsKICAgICB9IGVs c2UgewogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgInVucmVjb2duaXplZCBh cmd1bWVudCBgJXMnXG4iLCB0b2tlbik7CiAgICAgICAgIHJldHVybiAxOwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggYi94 ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYuaAppbmRleCA0Y2RiYTc5YWJh Li5hYjg2M2YxNzVhIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMv aW8vYmxraWYuaAorKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYu aApAQCAtMzYzLDYgKzM2MywxNCBAQAogICogICAgICB0aGF0IHRoZSBmcm9u dGVuZCByZXF1aXJlcyB0aGF0IHRoZSBsb2dpY2FsIGJsb2NrIHNpemUgaXMg NTEyIGFzIGl0CiAgKiAgICAgIGlzIGhhcmRjb2RlZCAod2hpY2ggaXMgdGhl IGNhc2UgaW4gc29tZSBmcm9udGVuZCBpbXBsZW1lbnRhdGlvbnMpLgogICoK KyAqIHRydXN0ZWQKKyAqICAgICAgVmFsdWVzOiAgICAgICAgIDAvMSAoYm9v bGVhbikKKyAqICAgICAgRGVmYXVsdCB2YWx1ZTogIDEKKyAqCisgKiAgICAg IEEgdmFsdWUgb2YgIjAiIGluZGljYXRlcyB0aGF0IHRoZSBmcm9udGVuZCBz aG91bGQgbm90IHRydXN0IHRoZQorICogICAgICBiYWNrZW5kLCBhbmQgc2hv dWxkIGRlcGxveSB3aGF0ZXZlciBtZWFzdXJlcyBhdmFpbGFibGUgdG8gcHJv dGVjdCBmcm9tCisgKiAgICAgIGEgbWFsaWNpb3VzIGJhY2tlbmQgb24gdGhl IG90aGVyIGVuZC4KKyAqCiAgKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0g VmlydHVhbCBEZXZpY2UgUHJvcGVydGllcyAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiAgKgogICogZGV2aWNlLXR5cGUKZGlmZiAtLWdpdCBhL3hlbi9p bmNsdWRlL3B1YmxpYy9pby9uZXRpZi5oIGIveGVuL2luY2x1ZGUvcHVibGlj L2lvL25ldGlmLmgKaW5kZXggOWZjZjkxYTJmZS4uM2FmOTg3ZDI2MiAxMDA2 NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2lvL25ldGlmLmgKKysrIGIv eGVuL2luY2x1ZGUvcHVibGljL2lvL25ldGlmLmgKQEAgLTE2MCw2ICsxNjAs MTIgQEAKICAqIGJlIGFwcGxpZWQgaWYgaXQgaXMgc2V0LgogICovCiAKKy8q CisgKiBUaGUgc2V0dGluZyBvZiAidHJ1c3RlZCIgbm9kZSB0byAiMCIgaW4g dGhlIGZyb250ZW5kIHBhdGggc2lnbmFscyB0aGF0IHRoZQorICogZnJvbnRl bmQgc2hvdWxkIG5vdCB0cnVzdCB0aGUgYmFja2VuZCwgYW5kIHNob3VsZCBk ZXBsb3kgd2hhdGV2ZXIgbWVhc3VyZXMKKyAqIGF2YWlsYWJsZSB0byBwcm90 ZWN0IGZyb20gYSBtYWxpY2lvdXMgYmFja2VuZCBvbiB0aGUgb3RoZXIgZW5k LgorICovCisKIC8qCiAgKiBDb250cm9sIHJpbmcKICAqID09PT09PT09PT09 PQotLSAKMi4zNy4wCgo= --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-4.16-1.patch" Content-Disposition: attachment; filename="xsa403/xsa403-4.16-1.patch" Content-Transfer-Encoding: base64 RnJvbSA4YzY3OTE3OThkZTRiNjg5MjNlNDIyZjU2NTU4MWFmMWVlNzQxMjRj IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBUaHUsIDMwIEp1biAy MDIyIDE0OjM1OjM1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gdG9vbHMvbGli eGw6IGVudiB2YXJpYWJsZSB0byBzaWduYWwgd2hldGhlciBkaXNrL25pYyBi YWNrZW5kCiBpcyB0cnVzdGVkCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQt VHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5z ZmVyLUVuY29kaW5nOiA4Yml0CgpJbnRyb2R1Y2Ugc3VwcG9ydCBpbiBsaWJ4 bCBmb3IgZmV0Y2hpbmcgdGhlIGRlZmF1bHQgYmFja2VuZCB0cnVzdGVkCm9w dGlvbiBmb3IgZGlzayBhbmQgbmljIGRldmljZXMuCgpVc2VycyBjYW4gc2V0 IGxpYnhsX3tkaXNrLG5pY31fYmFja2VuZF91bnRydXN0ZWQgZW52aXJvbm1l bnQgdmFyaWFibGUKdG8gbm90aWZ5IGxpYnhsIG9mIHdoZXRoZXIgdGhlIGJh Y2tlbmRzIGZvciBkaXNrIGFuZCBuaWMgZGV2aWNlcwpzaG91bGQgYmUgdHJ1 c3RlZC4gIFN1Y2ggaW5mb3JtYXRpb24gaXMgcGFzc2VkIGludG8gdGhlIGZy b250ZW5kIHNvIGl0CmNhbiB0YWtlIHRoZSBhcHByb3ByaWF0ZSBtZWFzdXJl cy4KClRoaXMgaXMgcGFydCBvZiBYU0EtNDAzLgoKU2lnbmVkLW9mZi1ieTog Um9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+Ci0tLQog dG9vbHMvbGlicy9saWdodC9saWJ4bF9kaXNrLmMgfCAzICsrKwogdG9vbHMv bGlicy9saWdodC9saWJ4bF9uaWMuYyAgfCAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCA2IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS90b29scy9saWJz L2xpZ2h0L2xpYnhsX2Rpc2suYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf ZGlzay5jCmluZGV4IDkzOTM2ZDBkZDAuLjBhYWY2YWZjZTggMTAwNjQ0Ci0t LSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZGlzay5jCisrKyBiL3Rvb2xz L2xpYnMvbGlnaHQvbGlieGxfZGlzay5jCkBAIC0zOTUsNiArMzk1LDkgQEAg c3RhdGljIHZvaWQgZGV2aWNlX2Rpc2tfYWRkKGxpYnhsX19lZ2MgKmVnYywg dWludDMyX3QgZG9taWQsCiAgICAgICAgIGZsZXhhcnJheV9hcHBlbmQoZnJv bnQsIEdDU1BSSU5URigiJWQiLCBkZXZpY2UtPmRldmlkKSk7CiAgICAgICAg IGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsICJkZXZpY2UtdHlwZSIpOwogICAg ICAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250LCBkaXNrLT5pc19jZHJvbSA/ ICJjZHJvbSIgOiAiZGlzayIpOworICAgICAgICBmbGV4YXJyYXlfYXBwZW5k KGZyb250LCAidHJ1c3RlZCIpOworICAgICAgICBmbGV4YXJyYXlfYXBwZW5k KGZyb250LCBnZXRlbnYoImxpYnhsX2Rpc2tfYmFja2VuZF91bnRydXN0ZWQi KSA/ICIwIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICIxIik7CiAK ICAgICAgICAgLyoKICAgICAgICAgICogT2xkIFBWIGtlcm5lbCBkaXNrIGZy b250ZW5kcyBiZWZvcmUgMi42LjI2IHJlbHkgb24gdG9vbCBzdGFjayB0bwpk aWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9uaWMuYyBiL3Rv b2xzL2xpYnMvbGlnaHQvbGlieGxfbmljLmMKaW5kZXggMGI5ZTcwYzlkMS4u MzRjM2ZlNmRmMCAxMDA2NDQKLS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4 bF9uaWMuYworKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX25pYy5jCkBA IC0yNTUsNiArMjU1LDkgQEAgc3RhdGljIGludCBsaWJ4bF9fc2V0X3hlbnN0 b3JlX25pYyhsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBkb21pZCwKICAgICBm bGV4YXJyYXlfYXBwZW5kKGJhY2ssICJob3RwbHVnLXN0YXR1cyIpOwogICAg IGZsZXhhcnJheV9hcHBlbmQoYmFjaywgIiIpOwogCisgICAgZmxleGFycmF5 X2FwcGVuZChmcm9udCwgInRydXN0ZWQiKTsKKyAgICBmbGV4YXJyYXlfYXBw ZW5kKGZyb250LCBnZXRlbnYoImxpYnhsX25pY19iYWNrZW5kX3VudHJ1c3Rl ZCIpID8gIjAiIDogIjEiKTsKKwogICAgIHJldHVybiAwOwogfQogCi0tIAoy LjM3LjAKCg== --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-4.16-2.patch" Content-Disposition: attachment; filename="xsa403/xsa403-4.16-2.patch" Content-Transfer-Encoding: base64 RnJvbSBjNGViNTI3Y2U0ZTY2YjQyMjllMzAyZDMwNzk5MDdlYWQ5ZTUwNDc3 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBGcmksIDggQXByIDIw MjIgMTA6MjE6MTEgKzAyMDAKU3ViamVjdDogW1BBVENIXSB0b29scy9saWJ4 bDogcmVwb3J0IHRydXN0ZWQgYmFja2VuZCBzdGF0dXMgdG8gZnJvbnRlbmRz Ck1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4dC9wbGFpbjsg Y2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29kaW5nOiA4Yml0 CgpBbGxvdyBhZG1pbmlzdHJhdG9ycyB0byBub3RpZnkgYSBmcm9udGVuZCBk cml2ZXIgdGhhdCBpdCdzIGJhY2tlbmQKY291bnRlcnBhcnQgaXMgbm90IHRv IGJlIHRydXN0ZWQsIHNvIHRoZSBmcm9udGVuZCBjYW4gZGVwbG95IHdoYXRl dmVyCm1pdGlnYXRpb25zIHJlcXVpcmVkIGluIG9yZGVyIHRvIHNlY3VyZSBp dHNlbGYuCgpBbGxvdyBzdWNoIG9wdGlvbiBmb3IgZGlzayBhbmQgbmV0d29y ayBmcm9udGVuZHMgb25seSwgYXMgdGhvc2UgYXJlCnRoZSBvbmx5IGhhcmRl bmVkIG9uZXMgY3VycmVudGx5IHN1cHBvcnRlZC4KClRoaXMgaXMgcGFydCBv ZiBYU0EtNDAzCgpXQVJOSU5HOiB0aGlzIHBhdGNoIHdpbGwgbmV2ZXIgYmUg YXBwbGllZCB0byB0aGUgaW50ZW5kZWQKcmVwb3NpdG9yeS9icmFuY2ggYmVj YXVzZSBpdCBicmVha3MgdGhlIGxpYnhsIEFCSS4KClNpZ25lZC1vZmYtYnk6 IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpSZXZp ZXdlZC1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJp eC5jb20+Ci0tLQogZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUu cG9kLmluICAgIHwgMjkgKysrKysrKysrKysrKysrKysrKysrKwogZG9jcy9t YW4veGwtbmV0d29yay1jb25maWd1cmF0aW9uLjUucG9kLmluIHwgIDkgKysr KysrKwogdG9vbHMvaW5jbHVkZS9saWJ4bC5oICAgICAgICAgICAgICAgICAg ICAgIHwgIDggKysrKysrCiB0b29scy9saWJzL2xpZ2h0L2xpYnhsX2Rpc2su YyAgICAgICAgICAgICAgfCAgNCArLS0KIHRvb2xzL2xpYnMvbGlnaHQvbGli eGxfbmljLmMgICAgICAgICAgICAgICB8ICA0ICsrLQogdG9vbHMvbGlicy9s aWdodC9saWJ4bF90eXBlcy5pZGwgICAgICAgICAgIHwgIDYgKysrLS0KIHRv b2xzL2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmwgICAgICAgICAgICB8ICAz ICsrKwogdG9vbHMveGwvY2hlY2steGwtZGlzay1wYXJzZSAgICAgICAgICAg ICAgIHwgMjYgKysrKysrKysrKysrKysrKysrKwogdG9vbHMveGwvY2hlY2st eGwtdmlmLXBhcnNlICAgICAgICAgICAgICAgIHwgMTggKysrKysrKysrKysr KysKIHRvb2xzL3hsL3hsX3BhcnNlLmMgICAgICAgICAgICAgICAgICAgICAg ICB8ICA0ICsrKwogeGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggICAg ICAgICAgICAgIHwgIDggKysrKysrCiB4ZW4vaW5jbHVkZS9wdWJsaWMvaW8v bmV0aWYuaCAgICAgICAgICAgICAgfCAgNiArKysrKwogMTIgZmlsZXMgY2hh bmdlZCwgMTIwIGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUucG9k LmluIGIvZG9jcy9tYW4veGwtZGlzay1jb25maWd1cmF0aW9uLjUucG9kLmlu CmluZGV4IDcxZDBlODZlM2QuLjk1ZDAzOTY1NWEgMTAwNjQ0Ci0tLSBhL2Rv Y3MvbWFuL3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBvZC5pbgorKysgYi9k b2NzL21hbi94bC1kaXNrLWNvbmZpZ3VyYXRpb24uNS5wb2QuaW4KQEAgLTM0 NCw2ICszNDQsMzUgQEAgY2FuIGJlIHVzZWQgdG8gZGlzYWJsZSAiaG9sZSBw dW5jaGluZyIgZm9yIGZpbGUgYmFzZWQgYmFja2VuZHMgd2hpY2gKIHdlcmUg aW50ZW50aW9uYWxseSBjcmVhdGVkIG5vbi1zcGFyc2UgdG8gYXZvaWQgZnJh Z21lbnRhdGlvbiBvZiB0aGUKIGZpbGUuCiAKKz1pdGVtIEI8dHJ1c3RlZD4g LyBCPHVudHJ1c3RlZD4KKworPW92ZXIgNAorCis9aXRlbSBEZXNjcmlwdGlv bgorCitSZXBvcnRzIHdoZXRoZXIgdGhlIGJhY2tlbmQgc2hvdWxkIGJlIHRy dXN0ZWQgYnkgdGhlIGZyb250ZW5kCisKKz1pdGVtIFN1cHBvcnRlZCB2YWx1 ZXMKKwordHJ1c3RlZCwgdW50cnVzdGVkCisKKz1pdGVtIE1hbmRhdG9yeQor CitObworCis9aXRlbSBEZWZhdWx0IHZhbHVlCisKK3RydXN0ZWQKKworPWJh Y2sKKworQW4gYWR2aXNvcnkgc2V0dGluZyBmb3IgdGhlIGZyb250ZW5kIGRy aXZlciBvbiB3aGV0aGVyIHRoZSBiYWNrZW5kIHNob3VsZCBiZQordHJ1c3Rl ZC4gIFRoZSBmcm9udGVuZCBzaG91bGQgZGVwbG95IHdoYXRldmVyIHByb3Rl Y3Rpb25zIGl0IGhhcyBhdmFpbGFibGUgdG8KK3ByZXZlbnQgYW4gdW50cnVz dGVkIGJhY2tlbmQgZnJvbSBhY2Nlc3NpbmcgZ3Vlc3QgZGF0YSBub3QgcmVs YXRlZCB0byB0aGUgSS9PCitwcm9jZXNzaW5nIG9yIGNhdXNpbmcgbWFsZnVu Y3Rpb24gdG8gdGhlIGZyb250ZW5kIG9yIHRoZSB3aG9sZSBkb21haW4uCisK K05vdGUgZnJvbnRlbmRzIGNhbiBpZ25vcmUgc3VjaCByZWNvbW1lbmRhdGlv bi4KKwogPWJhY2sKIAogCmRpZmYgLS1naXQgYS9kb2NzL21hbi94bC1uZXR3 b3JrLWNvbmZpZ3VyYXRpb24uNS5wb2QuaW4gYi9kb2NzL21hbi94bC1uZXR3 b3JrLWNvbmZpZ3VyYXRpb24uNS5wb2QuaW4KaW5kZXggY2Y5MmQ3OTYwYy4u ZjNlMzc5YmNmOCAxMDA2NDQKLS0tIGEvZG9jcy9tYW4veGwtbmV0d29yay1j b25maWd1cmF0aW9uLjUucG9kLmluCisrKyBiL2RvY3MvbWFuL3hsLW5ldHdv cmstY29uZmlndXJhdGlvbi41LnBvZC5pbgpAQCAtMjU4LDMgKzI1OCwxMiBA QCBOT1RFOiBUaGlzIHNob3VsZCBub3QgYmUgc2V0IHVubGVzcyB5b3UgaGF2 ZSBhIHJlYXNvbiB0by4KIFNwZWNpZmllcyB0aGUgTVRVIChpLmUuIHRoZSBt YXhpbXVtIHNpemUgb2YgYW4gSVAgcGF5bG9hZCwgZXhjbHVzaW5nIGhlYWRl cnMpLiBUaGUKIGRlZmF1bHQgdmFsdWUgaXMgMTUwMCBidXQsIGlmIHRoZSBW SUYgaXMgYXR0YWNoZWQgdG8gYSBicmlkZ2UsIGl0IHdpbGwgYmUgc2V0IHRv IG1hdGNoCiB1bmxlc3Mgb3ZlcnJpZGRlbiBieSB0aGlzIHBhcmFtZXRlci4K KworPWhlYWQyIHRydXN0ZWQgLyB1bnRydXN0ZWQKKworQW4gYWR2aXNvcnkg c2V0dGluZyBmb3IgdGhlIGZyb250ZW5kIGRyaXZlciBvbiB3aGV0aGVyIHRo ZSBiYWNrZW5kIHNob3VsZCBiZQordHJ1c3RlZC4gIFRoZSBmcm9udGVuZCBz aG91bGQgZGVwbG95IHdoYXRldmVyIHByb3RlY3Rpb25zIGl0IGhhcyBhdmFp bGFibGUgdG8KK3ByZXZlbnQgYW4gdW50cnVzdGVkIGJhY2tlbmQgZnJvbSBh Y2Nlc3NpbmcgZ3Vlc3QgZGF0YSBub3QgcmVsYXRlZCB0byB0aGUgSS9PCitw cm9jZXNzaW5nIG9yIGNhdXNpbmcgbWFsZnVuY3Rpb24gdG8gdGhlIGZyb250 ZW5kIG9yIHRoZSB3aG9sZSBkb21haW4uCisKK05vdGUgZnJvbnRlbmRzIGNh biBpZ25vcmUgc3VjaCByZWNvbW1lbmRhdGlvbi4KZGlmZiAtLWdpdCBhL3Rv b2xzL2luY2x1ZGUvbGlieGwuaCBiL3Rvb2xzL2luY2x1ZGUvbGlieGwuaApp bmRleCAyYmJiZDIxZjBiLi43MDVmYzg4NDUyIDEwMDY0NAotLS0gYS90b29s cy9pbmNsdWRlL2xpYnhsLmgKKysrIGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5o CkBAIC01MjcsNiArNTI3LDE0IEBACiAgKi8KICNkZWZpbmUgTElCWExfSEFW RV9NQVhfR1JBTlRfVkVSU0lPTiAxCiAKKy8qCisgKiBMSUJYTF9IQVZFX3tE SVNLLE5JQ31fVFJVU1RFRCBpbmRpY2F0ZXMgdGhhdCB0aGUgbGlieGxfZGV2 aWNlX2Rpc2sgYW5kCisgKiBsaWJ4bF9kZXZpY2VfbmljIHN0cnVjdHMgaGF2 ZSBhIGZpZWxkIHRvIHNpZ25hbCB3aGV0aGVyIHRoZSBiYWNrZW5kIG9mIHRo ZQorICogZGV2aWNlIGlzIHRvIGJlIHRydXN0ZWQuICBTdWNoIGluZm9ybWF0 aW9uIGlzIHByb3BhZ2F0ZWQgdG8gdGhlIGZyb250ZW5kLgorICovCisjZGVm aW5lIExJQlhMX0hBVkVfRElTS19UUlVTVEVEIDEKKyNkZWZpbmUgTElCWExf SEFWRV9OSUNfVFJVU1RFRCAxCisKIC8qCiAgKiBsaWJ4bCBBQkkgY29tcGF0 aWJpbGl0eQogICoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfZGlzay5jIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9kaXNrLmMKaW5k ZXggMGFhZjZhZmNlOC4uODNhMmQ3MGZjOSAxMDA2NDQKLS0tIGEvdG9vbHMv bGlicy9saWdodC9saWJ4bF9kaXNrLmMKKysrIGIvdG9vbHMvbGlicy9saWdo dC9saWJ4bF9kaXNrLmMKQEAgLTE1OSw2ICsxNTksNyBAQCBzdGF0aWMgaW50 IGxpYnhsX19kZXZpY2VfZGlza19zZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2Ms IHVpbnQzMl90IGRvbWlkLAogICAgIGxpYnhsX2RlZmJvb2xfc2V0ZGVmYXVs dCgmZGlzay0+ZGlzY2FyZF9lbmFibGUsICEhZGlzay0+cmVhZHdyaXRlKTsK ICAgICBsaWJ4bF9kZWZib29sX3NldGRlZmF1bHQoJmRpc2stPmNvbG9fZW5h YmxlLCBmYWxzZSk7CiAgICAgbGlieGxfZGVmYm9vbF9zZXRkZWZhdWx0KCZk aXNrLT5jb2xvX3Jlc3RvcmVfZW5hYmxlLCBmYWxzZSk7CisgICAgbGlieGxf ZGVmYm9vbF9zZXRkZWZhdWx0KCZkaXNrLT50cnVzdGVkLCB0cnVlKTsKIAog ICAgIHJjID0gbGlieGxfX3Jlc29sdmVfZG9taWQoZ2MsIGRpc2stPmJhY2tl bmRfZG9tbmFtZSwgJmRpc2stPmJhY2tlbmRfZG9taWQpOwogICAgIGlmIChy YyA8IDApIHJldHVybiByYzsKQEAgLTM5Niw4ICszOTcsNyBAQCBzdGF0aWMg dm9pZCBkZXZpY2VfZGlza19hZGQobGlieGxfX2VnYyAqZWdjLCB1aW50MzJf dCBkb21pZCwKICAgICAgICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwgImRl dmljZS10eXBlIik7CiAgICAgICAgIGZsZXhhcnJheV9hcHBlbmQoZnJvbnQs IGRpc2stPmlzX2Nkcm9tID8gImNkcm9tIiA6ICJkaXNrIik7CiAgICAgICAg IGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsICJ0cnVzdGVkIik7Ci0gICAgICAg IGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsIGdldGVudigibGlieGxfZGlza19i YWNrZW5kX3VudHJ1c3RlZCIpID8gIjAiCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDogIjEiKTsKKyAgICAgICAgZmxleGFycmF5X2FwcGVuZChmcm9u dCwgbGlieGxfZGVmYm9vbF92YWwoZGlzay0+dHJ1c3RlZCkgPyAiMSIgOiAi MCIpOwogCiAgICAgICAgIC8qCiAgICAgICAgICAqIE9sZCBQViBrZXJuZWwg ZGlzayBmcm9udGVuZHMgYmVmb3JlIDIuNi4yNiByZWx5IG9uIHRvb2wgc3Rh Y2sgdG8KZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfbmlj LmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX25pYy5jCmluZGV4IDM0YzNm ZTZkZjAuLmQ2YmYwNmZjMzQgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2xpYnMvbGln aHQvbGlieGxfbmljLmMKKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9u aWMuYwpAQCAtMTE2LDYgKzExNiw4IEBAIHN0YXRpYyBpbnQgbGlieGxfX2Rl dmljZV9uaWNfc2V0ZGVmYXVsdChsaWJ4bF9fZ2MgKmdjLCB1aW50MzJfdCBk b21pZCwKICAgICAgICAgYWJvcnQoKTsKICAgICB9CiAKKyAgICBsaWJ4bF9k ZWZib29sX3NldGRlZmF1bHQoJm5pYy0+dHJ1c3RlZCwgdHJ1ZSk7CisKICAg ICByZXR1cm4gcmM7CiB9CiAKQEAgLTI1Niw3ICsyNTgsNyBAQCBzdGF0aWMg aW50IGxpYnhsX19zZXRfeGVuc3RvcmVfbmljKGxpYnhsX19nYyAqZ2MsIHVp bnQzMl90IGRvbWlkLAogICAgIGZsZXhhcnJheV9hcHBlbmQoYmFjaywgIiIp OwogCiAgICAgZmxleGFycmF5X2FwcGVuZChmcm9udCwgInRydXN0ZWQiKTsK LSAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250LCBnZXRlbnYoImxpYnhsX25p Y19iYWNrZW5kX3VudHJ1c3RlZCIpID8gIjAiIDogIjEiKTsKKyAgICBmbGV4 YXJyYXlfYXBwZW5kKGZyb250LCBsaWJ4bF9kZWZib29sX3ZhbChuaWMtPnRy dXN0ZWQpID8gIjEiIDogIjAiKTsKIAogICAgIHJldHVybiAwOwogfQpkaWZm IC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgYi90 b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbAppbmRleCAyYTQyZGEy ZjdkLi44OTk2MjIxOGI0IDEwMDY0NAotLS0gYS90b29scy9saWJzL2xpZ2h0 L2xpYnhsX3R5cGVzLmlkbAorKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhs X3R5cGVzLmlkbApAQCAtNzEyLDcgKzcxMiw4IEBAIGxpYnhsX2RldmljZV9k aXNrID0gU3RydWN0KCJkZXZpY2VfZGlzayIsIFsKICAgICAoImNvbG9fcG9y dCIsIGludGVnZXIpLAogICAgICgiY29sb19leHBvcnQiLCBzdHJpbmcpLAog ICAgICgiYWN0aXZlX2Rpc2siLCBzdHJpbmcpLAotICAgICgiaGlkZGVuX2Rp c2siLCBzdHJpbmcpCisgICAgKCJoaWRkZW5fZGlzayIsIHN0cmluZyksCisg ICAgKCJ0cnVzdGVkIiwgbGlieGxfZGVmYm9vbCksCiAgICAgXSkKIAogbGli eGxfZGV2aWNlX25pYyA9IFN0cnVjdCgiZGV2aWNlX25pYyIsIFsKQEAgLTc4 MCw3ICs3ODEsOCBAQCBsaWJ4bF9kZXZpY2VfbmljID0gU3RydWN0KCJkZXZp Y2VfbmljIiwgWwogICAgICgiY29sb19maWx0ZXJfc2VjX3JlZGlyZWN0b3Ix X291dGRldiIsIHN0cmluZyksCiAgICAgKCJjb2xvX2ZpbHRlcl9zZWNfcmV3 cml0ZXIwX3F1ZXVlIiwgc3RyaW5nKSwKICAgICAoImNvbG9fY2hlY2twb2lu dF9ob3N0Iiwgc3RyaW5nKSwKLSAgICAoImNvbG9fY2hlY2twb2ludF9wb3J0 Iiwgc3RyaW5nKQorICAgICgiY29sb19jaGVja3BvaW50X3BvcnQiLCBzdHJp bmcpLAorICAgICgidHJ1c3RlZCIsIGxpYnhsX2RlZmJvb2wpLAogICAgIF0p CiAKIGxpYnhsX2RldmljZV9wY2kgPSBTdHJ1Y3QoImRldmljZV9wY2kiLCBb CmRpZmYgLS1naXQgYS90b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5s IGIvdG9vbHMvbGlicy91dGlsL2xpYnhsdV9kaXNrX2wubAppbmRleCAzYmQ2 MzlhYWIwLi5lMTE1NDYwZDk5IDEwMDY0NAotLS0gYS90b29scy9saWJzL3V0 aWwvbGlieGx1X2Rpc2tfbC5sCisrKyBiL3Rvb2xzL2xpYnMvdXRpbC9saWJ4 bHVfZGlza19sLmwKQEAgLTIwOCw2ICsyMDgsOSBAQCBjb2xvLWV4cG9ydD1b XixdKiw/CXsgU1RSSVAoJywnKTsgU0FWRVNUUklORygiY29sby1leHBvcnQi LCBjb2xvX2V4cG9ydCwgRlJPTUVRVQogYWN0aXZlLWRpc2s9W14sXSosPwl7 IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImFjdGl2ZS1kaXNrIiwgYWN0aXZl X2Rpc2ssIEZST01FUVVBTFMpOyB9CiBoaWRkZW4tZGlzaz1bXixdKiw/CXsg U1RSSVAoJywnKTsgU0FWRVNUUklORygiaGlkZGVuLWRpc2siLCBoaWRkZW5f ZGlzaywgRlJPTUVRVUFMUyk7IH0KIAordHJ1c3RlZCw/CQl7IGxpYnhsX2Rl ZmJvb2xfc2V0KCZEUEMtPmRpc2stPnRydXN0ZWQsIHRydWUpOyB9Cit1bnRy dXN0ZWQsPwkJeyBsaWJ4bF9kZWZib29sX3NldCgmRFBDLT5kaXNrLT50cnVz dGVkLCBmYWxzZSk7IH0KKwogIC8qIHRoZSB0YXJnZXQgbWFnaWMgcGFyYW1l dGVyLCBlYXRzIHRoZSByZXN0IG9mIHRoZSBzdHJpbmcgKi8KIAogdGFyZ2V0 PS4qCXsgU1RSSVAoJywnKTsgU0FWRVNUUklORygidGFyZ2V0IiwgcGRldl9w YXRoLCBGUk9NRVFVQUxTKTsgfQpkaWZmIC0tZ2l0IGEvdG9vbHMveGwvY2hl Y2steGwtZGlzay1wYXJzZSBiL3Rvb2xzL3hsL2NoZWNrLXhsLWRpc2stcGFy c2UKaW5kZXggNjQzZjRmNGVjYi4uMThmYjY2OTQwYSAxMDA3NTUKLS0tIGEv dG9vbHMveGwvY2hlY2steGwtZGlzay1wYXJzZQorKysgYi90b29scy94bC9j aGVjay14bC1kaXNrLXBhcnNlCkBAIC0xNzgsNCArMTc4LDMwIEBAIGRpc2s6 IHsKIEVORAogb25lIDAgIGNkcm9tIG5vLWRpc2NhcmQgdmRldj1oZGEgdGFy Z2V0PS9zb21lL2Rpc2svaW1hZ2UuaXNvCiAKKyMgdGVzdCBzZXR0aW5nIHRy dXN0ZWQKK2V4cGVjdGVkIDw8RU5ECitkaXNrOiB7CisgICAgInBkZXZfcGF0 aCI6ICIvc29tZS9kaXNrL2ltYWdlLnJhdyIsCisgICAgInZkZXYiOiAiaGRh IiwKKyAgICAiZm9ybWF0IjogInJhdyIsCisgICAgInJlYWR3cml0ZSI6IDEs CisgICAgInRydXN0ZWQiOiAiVHJ1ZSIKK30KKworRU5ECitvbmUgMCAgdHJ1 c3RlZCB2ZGV2PWhkYSB0YXJnZXQ9L3NvbWUvZGlzay9pbWFnZS5yYXcKKwor IyB0ZXN0IHNldHRpbmcgdW50cnVzdGVkCitleHBlY3RlZCA8PEVORAorZGlz azogeworICAgICJwZGV2X3BhdGgiOiAiL3NvbWUvZGlzay9pbWFnZS5yYXci LAorICAgICJ2ZGV2IjogImhkYSIsCisgICAgImZvcm1hdCI6ICJyYXciLAor ICAgICJyZWFkd3JpdGUiOiAxLAorICAgICJ0cnVzdGVkIjogIkZhbHNlIgor fQorCitFTkQKK29uZSAwICB1bnRydXN0ZWQgdmRldj1oZGEgdGFyZ2V0PS9z b21lL2Rpc2svaW1hZ2UucmF3CisKIGNvbXBsZXRlCmRpZmYgLS1naXQgYS90 b29scy94bC9jaGVjay14bC12aWYtcGFyc2UgYi90b29scy94bC9jaGVjay14 bC12aWYtcGFyc2UKaW5kZXggMDJjNmRiYWViNi4uNjZmNmZjYmRiMyAxMDA3 NTUKLS0tIGEvdG9vbHMveGwvY2hlY2steGwtdmlmLXBhcnNlCisrKyBiL3Rv b2xzL3hsL2NoZWNrLXhsLXZpZi1wYXJzZQpAQCAtMjEwLDQgKzIxMCwyMiBA QCBvbmUgJGUgcmF0ZT00Mjk2TUIvc0A0Mjk0cwogZXhwZWN0ZWQgPC9kZXYv bnVsbAogb25lICRlIHJhdGU9QAogCisjIHRlc3QgdHJ1c3RlZCBzZXR0aW5n CitleHBlY3RlZCA8PEVORAordmlmOiB7CisgICAgInRydXN0ZWQiOiAiVHJ1 ZSIKK30KKworRU5ECitvbmUgMCB0cnVzdGVkCisKKyMgdGVzdCB1bnRydXN0 ZWQgc2V0dGluZworZXhwZWN0ZWQgPDxFTkQKK3ZpZjogeworICAgICJ0cnVz dGVkIjogIkZhbHNlIgorfQorCitFTkQKK29uZSAwIHVudHJ1c3RlZAorCiBj b21wbGV0ZQpkaWZmIC0tZ2l0IGEvdG9vbHMveGwveGxfcGFyc2UuYyBiL3Rv b2xzL3hsL3hsX3BhcnNlLmMKaW5kZXggYjk4YzBkZTM3OC4uNjQ0YWI4Zjhm ZCAxMDA2NDQKLS0tIGEvdG9vbHMveGwveGxfcGFyc2UuYworKysgYi90b29s cy94bC94bF9wYXJzZS5jCkBAIC01NjUsNiArNTY1LDEwIEBAIGludCBwYXJz ZV9uaWNfY29uZmlnKGxpYnhsX2RldmljZV9uaWMgKm5pYywgWExVX0NvbmZp ZyAqKmNvbmZpZywgY2hhciAqdG9rZW4pCiAgICAgICAgIG5pYy0+ZGV2aWQg PSBwYXJzZV91bG9uZyhvcGFyZyk7CiAgICAgfSBlbHNlIGlmIChNQVRDSF9P UFRJT04oIm10dSIsIHRva2VuLCBvcGFyZykpIHsKICAgICAgICAgbmljLT5t dHUgPSBwYXJzZV91bG9uZyhvcGFyZyk7CisgICAgfSBlbHNlIGlmICghc3Ry Y21wKCJ0cnVzdGVkIiwgdG9rZW4pKSB7CisgICAgICAgIGxpYnhsX2RlZmJv b2xfc2V0KCZuaWMtPnRydXN0ZWQsIHRydWUpOworICAgIH0gZWxzZSBpZiAo IXN0cmNtcCgidW50cnVzdGVkIiwgdG9rZW4pKSB7CisgICAgICAgIGxpYnhs X2RlZmJvb2xfc2V0KCZuaWMtPnRydXN0ZWQsIGZhbHNlKTsKICAgICB9IGVs c2UgewogICAgICAgICBmcHJpbnRmKHN0ZGVyciwgInVucmVjb2duaXplZCBh cmd1bWVudCBgJXMnXG4iLCB0b2tlbik7CiAgICAgICAgIHJldHVybiAxOwpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2lvL2Jsa2lmLmggYi94 ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYuaAppbmRleCA0Y2RiYTc5YWJh Li5hYjg2M2YxNzVhIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9wdWJsaWMv aW8vYmxraWYuaAorKysgYi94ZW4vaW5jbHVkZS9wdWJsaWMvaW8vYmxraWYu aApAQCAtMzYzLDYgKzM2MywxNCBAQAogICogICAgICB0aGF0IHRoZSBmcm9u dGVuZCByZXF1aXJlcyB0aGF0IHRoZSBsb2dpY2FsIGJsb2NrIHNpemUgaXMg NTEyIGFzIGl0CiAgKiAgICAgIGlzIGhhcmRjb2RlZCAod2hpY2ggaXMgdGhl IGNhc2UgaW4gc29tZSBmcm9udGVuZCBpbXBsZW1lbnRhdGlvbnMpLgogICoK KyAqIHRydXN0ZWQKKyAqICAgICAgVmFsdWVzOiAgICAgICAgIDAvMSAoYm9v bGVhbikKKyAqICAgICAgRGVmYXVsdCB2YWx1ZTogIDEKKyAqCisgKiAgICAg IEEgdmFsdWUgb2YgIjAiIGluZGljYXRlcyB0aGF0IHRoZSBmcm9udGVuZCBz aG91bGQgbm90IHRydXN0IHRoZQorICogICAgICBiYWNrZW5kLCBhbmQgc2hv dWxkIGRlcGxveSB3aGF0ZXZlciBtZWFzdXJlcyBhdmFpbGFibGUgdG8gcHJv dGVjdCBmcm9tCisgKiAgICAgIGEgbWFsaWNpb3VzIGJhY2tlbmQgb24gdGhl IG90aGVyIGVuZC4KKyAqCiAgKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0g VmlydHVhbCBEZXZpY2UgUHJvcGVydGllcyAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCiAgKgogICogZGV2aWNlLXR5cGUKZGlmZiAtLWdpdCBhL3hlbi9p bmNsdWRlL3B1YmxpYy9pby9uZXRpZi5oIGIveGVuL2luY2x1ZGUvcHVibGlj L2lvL25ldGlmLmgKaW5kZXggMDBkZDI1ODcxMi4uMzUwOWIwOTZmOCAxMDA2 NDQKLS0tIGEveGVuL2luY2x1ZGUvcHVibGljL2lvL25ldGlmLmgKKysrIGIv eGVuL2luY2x1ZGUvcHVibGljL2lvL25ldGlmLmgKQEAgLTE2MCw2ICsxNjAs MTIgQEAKICAqIGJlIGFwcGxpZWQgaWYgaXQgaXMgc2V0LgogICovCiAKKy8q CisgKiBUaGUgc2V0dGluZyBvZiAidHJ1c3RlZCIgbm9kZSB0byAiMCIgaW4g dGhlIGZyb250ZW5kIHBhdGggc2lnbmFscyB0aGF0IHRoZQorICogZnJvbnRl bmQgc2hvdWxkIG5vdCB0cnVzdCB0aGUgYmFja2VuZCwgYW5kIHNob3VsZCBk ZXBsb3kgd2hhdGV2ZXIgbWVhc3VyZXMKKyAqIGF2YWlsYWJsZSB0byBwcm90 ZWN0IGZyb20gYSBtYWxpY2lvdXMgYmFja2VuZCBvbiB0aGUgb3RoZXIgZW5k LgorICovCisKIC8qCiAgKiBDb250cm9sIHJpbmcKICAqID09PT09PT09PT09 PQotLSAKMi4zNy4wCgo= --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-linux-1.patch" Content-Disposition: attachment; filename="xsa403/xsa403-linux-1.patch" Content-Transfer-Encoding: base64 RnJvbSBkODU4MzljNzhhZTI1OWJjNmQ1ZTNjMjk1NWVlMTYwMmM2Y2Q2ZjAw IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBXZWQsIDMwIE1hciAy MDIyIDA5OjAzOjQ4ICswMjAwClN1YmplY3Q6IFtQQVRDSCAxLzRdIHhlbi9i bGtmcm9udDogZml4IGxlYWtpbmcgZGF0YSBpbiBzaGFyZWQgcGFnZXMKTUlN RS1WZXJzaW9uOiAxLjAKQ29udGVudC1UeXBlOiB0ZXh0L3BsYWluOyBjaGFy c2V0PVVURi04CkNvbnRlbnQtVHJhbnNmZXItRW5jb2Rpbmc6IDhiaXQKCldo ZW4gYWxsb2NhdGluZyBwYWdlcyB0byBiZSB1c2VkIGZvciBzaGFyZWQgY29t bXVuaWNhdGlvbiB3aXRoIHRoZQpiYWNrZW5kIGFsd2F5cyB6ZXJvIHRoZW0s IHRoaXMgYXZvaWRzIGxlYWtpbmcgdW5pbnRlbmRlZCBkYXRhIHByZXNlbnQK b24gdGhlIHBhZ2VzLgoKVGhpcyBpcyBDVkUtMjAyMi0yNjM2NSwgcGFydCBv ZiBYU0EtNDAzLgoKU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8 cm9nZXIucGF1QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ci0tLQogZHJpdmVycy9ibG9jay94ZW4t YmxrZnJvbnQuYyB8IDcgKysrKy0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5z ZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jIGIvZHJpdmVycy9ibG9jay94ZW4t YmxrZnJvbnQuYwppbmRleCA5MWQ3NGRhY2IxYjEuLjBmMmI0Y2I5NTJhNSAx MDA2NDQKLS0tIGEvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYworKysg Yi9kcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jCkBAIC0zMTMsNyArMzEz LDcgQEAgc3RhdGljIGludCBmaWxsX2dyYW50X2J1ZmZlcihzdHJ1Y3QgYmxr ZnJvbnRfcmluZ19pbmZvICpyaW5mbywgaW50IG51bSkKIAkJCWdvdG8gb3V0 X29mX21lbW9yeTsKIAogCQlpZiAoaW5mby0+ZmVhdHVyZV9wZXJzaXN0ZW50 KSB7Ci0JCQlncmFudGVkX3BhZ2UgPSBhbGxvY19wYWdlKEdGUF9OT0lPKTsK KwkJCWdyYW50ZWRfcGFnZSA9IGFsbG9jX3BhZ2UoR0ZQX05PSU8gfCBfX0dG UF9aRVJPKTsKIAkJCWlmICghZ3JhbnRlZF9wYWdlKSB7CiAJCQkJa2ZyZWUo Z250X2xpc3RfZW50cnkpOwogCQkJCWdvdG8gb3V0X29mX21lbW9yeTsKQEAg LTE2ODksNyArMTY4OSw3IEBAIHN0YXRpYyBpbnQgc2V0dXBfYmxrcmluZyhz dHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LAogCWZvciAoaSA9IDA7IGkgPCBp bmZvLT5ucl9yaW5nX3BhZ2VzOyBpKyspCiAJCXJpbmZvLT5yaW5nX3JlZltp XSA9IEdSQU5UX0lOVkFMSURfUkVGOwogCi0Jc3JpbmcgPSBhbGxvY19wYWdl c19leGFjdChyaW5nX3NpemUsIEdGUF9OT0lPKTsKKwlzcmluZyA9IGFsbG9j X3BhZ2VzX2V4YWN0KHJpbmdfc2l6ZSwgR0ZQX05PSU8gfCBfX0dGUF9aRVJP KTsKIAlpZiAoIXNyaW5nKSB7CiAJCXhlbmJ1c19kZXZfZmF0YWwoZGV2LCAt RU5PTUVNLCAiYWxsb2NhdGluZyBzaGFyZWQgcmluZyIpOwogCQlyZXR1cm4g LUVOT01FTTsKQEAgLTIyMDgsNyArMjIwOCw4IEBAIHN0YXRpYyBpbnQgYmxr ZnJvbnRfc2V0dXBfaW5kaXJlY3Qoc3RydWN0IGJsa2Zyb250X3JpbmdfaW5m byAqcmluZm8pCiAKIAkJQlVHX09OKCFsaXN0X2VtcHR5KCZyaW5mby0+aW5k aXJlY3RfcGFnZXMpKTsKIAkJZm9yIChpID0gMDsgaSA8IG51bTsgaSsrKSB7 Ci0JCQlzdHJ1Y3QgcGFnZSAqaW5kaXJlY3RfcGFnZSA9IGFsbG9jX3BhZ2Uo R0ZQX0tFUk5FTCk7CisJCQlzdHJ1Y3QgcGFnZSAqaW5kaXJlY3RfcGFnZSA9 IGFsbG9jX3BhZ2UoR0ZQX0tFUk5FTCB8CisJCQkgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgX19HRlBfWkVSTyk7CiAJCQlpZiAo IWluZGlyZWN0X3BhZ2UpCiAJCQkJZ290byBvdXRfb2ZfbWVtb3J5OwogCQkJ bGlzdF9hZGQoJmluZGlyZWN0X3BhZ2UtPmxydSwgJnJpbmZvLT5pbmRpcmVj dF9wYWdlcyk7Ci0tIAoyLjM2LjAKCg== --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-linux-2.patch" Content-Disposition: attachment; filename="xsa403/xsa403-linux-2.patch" Content-Transfer-Encoding: base64 RnJvbSAyNmQ1Njc1OGI2M2RmZTg5MWI2MzBkMmIzZGJjYmNlZjcxMjAwZTNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBXZWQsIDYgQXByIDIw MjIgMTc6Mzg6MDQgKzAyMDAKU3ViamVjdDogW1BBVENIIDIvNF0geGVuL25l dGZyb250OiBmaXggbGVha2luZyBkYXRhIGluIHNoYXJlZCBwYWdlcwpNSU1F LVZlcnNpb246IDEuMApDb250ZW50LVR5cGU6IHRleHQvcGxhaW47IGNoYXJz ZXQ9VVRGLTgKQ29udGVudC1UcmFuc2Zlci1FbmNvZGluZzogOGJpdAoKV2hl biBhbGxvY2F0aW5nIHBhZ2VzIHRvIGJlIHVzZWQgZm9yIHNoYXJlZCBjb21t dW5pY2F0aW9uIHdpdGggdGhlCmJhY2tlbmQgYWx3YXlzIHplcm8gdGhlbSwg dGhpcyBhdm9pZHMgbGVha2luZyB1bmludGVuZGVkIGRhdGEgcHJlc2VudApv biB0aGUgcGFnZXMuCgpUaGlzIGlzIENWRS0yMDIyLTMzNzQwLCBwYXJ0IG9m IFhTQS00MDMuCgpTaWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxy b2dlci5wYXVAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jv c3MgPGpncm9zc0BzdXNlLmNvbT4KLS0tCiBkcml2ZXJzL25ldC94ZW4tbmV0 ZnJvbnQuYyB8IDMgKystCiAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25z KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQv eGVuLW5ldGZyb250LmMgYi9kcml2ZXJzL25ldC94ZW4tbmV0ZnJvbnQuYwpp bmRleCBlMmI0YTE4OTNhMTMuLmFmMzI5NjE3MWQ4NiAxMDA2NDQKLS0tIGEv ZHJpdmVycy9uZXQveGVuLW5ldGZyb250LmMKKysrIGIvZHJpdmVycy9uZXQv eGVuLW5ldGZyb250LmMKQEAgLTI3Myw3ICsyNzMsOCBAQCBzdGF0aWMgc3Ry dWN0IHNrX2J1ZmYgKnhlbm5ldF9hbGxvY19vbmVfcnhfYnVmZmVyKHN0cnVj dCBuZXRmcm9udF9xdWV1ZSAqcXVldWUpCiAJaWYgKHVubGlrZWx5KCFza2Ip KQogCQlyZXR1cm4gTlVMTDsKIAotCXBhZ2UgPSBwYWdlX3Bvb2xfZGV2X2Fs bG9jX3BhZ2VzKHF1ZXVlLT5wYWdlX3Bvb2wpOworCXBhZ2UgPSBwYWdlX3Bv b2xfYWxsb2NfcGFnZXMocXVldWUtPnBhZ2VfcG9vbCwKKwkJCQkgICAgIEdG UF9BVE9NSUMgfCBfX0dGUF9OT1dBUk4gfCBfX0dGUF9aRVJPKTsKIAlpZiAo dW5saWtlbHkoIXBhZ2UpKSB7CiAJCWtmcmVlX3NrYihza2IpOwogCQlyZXR1 cm4gTlVMTDsKLS0gCjIuMzYuMAoK --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-linux-3.patch" Content-Disposition: attachment; filename="xsa403/xsa403-linux-3.patch" Content-Transfer-Encoding: base64 RnJvbSA1OWY0NmM2OGM0NDJhMzQ4YTU2NzhhMmVhODc0ODYzNTc5MjkwMTQz IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBUaHUsIDcgQXByIDIw MjIgMTI6MjA6MDYgKzAyMDAKU3ViamVjdDogW1BBVENIIDMvNF0geGVuL25l dGZyb250OiBmb3JjZSBkYXRhIGJvdW5jaW5nIHdoZW4gYmFja2VuZCBpcwog dW50cnVzdGVkCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4 dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgpCb3VuY2UgYWxsIGRhdGEgb24gdGhlIHNrYnMgdG8gYmUg dHJhbnNtaXR0ZWQgaW50byB6ZXJvZWQgcGFnZXMgaWYgdGhlCmJhY2tlbmQg aXMgdW50cnVzdGVkLiBUaGlzIGF2b2lkcyBsZWFraW5nIGRhdGEgcHJlc2Vu dCBpbiB0aGUgcGFnZXMKc2hhcmVkIHdpdGggdGhlIGJhY2tlbmQgYnV0IG5v dCBwYXJ0IG9mIHRoZSBza2IgZnJhZ21lbnRzLiAgVGhpcwpyZXF1aXJlcyBp bnRyb2R1Y2luZyBhIG5ldyBoZWxwZXIgaW4gb3JkZXIgdG8gYWxsb2NhdGUg c2ticyB3aXRoIGEKc2l6ZSBtdWx0aXBsZSBvZiBYRU5fUEFHRV9TSVpFIHNv IHdlIGRvbid0IGxlYWsgY29udGlndW91cyBkYXRhIG9uIHRoZQpncmFudGVk IHBhZ2VzLgoKUmVwb3J0aW5nIHdoZXRoZXIgdGhlIGJhY2tlbmQgaXMgdG8g YmUgdHJ1c3RlZCBjYW4gYmUgZG9uZSB1c2luZyBhCm1vZHVsZSBwYXJhbWV0 ZXIsIG9yIGZyb20gdGhlIHhlbnN0b3JlIGZyb250ZW5kIHBhdGggYXMgc2V0 IGJ5IHRoZQp0b29sc3RhY2sgd2hlbiBhZGRpbmcgdGhlIGRldmljZS4KClRo aXMgaXMgQ1ZFLTIwMjItMzM3NDEsIHBhcnQgb2YgWFNBLTQwMy4KClNpZ25l ZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXgu Y29tPgpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPgotLS0KIGRyaXZlcnMvbmV0L3hlbi1uZXRmcm9udC5jIHwgNDkgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBj aGFuZ2VkLCA0NyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbmV0L3hlbi1uZXRmcm9udC5jIGIvZHJpdmVy cy9uZXQveGVuLW5ldGZyb250LmMKaW5kZXggYWYzMjk2MTcxZDg2Li5lMjVi ZDY4OWIzMmIgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3hlbi1uZXRmcm9u dC5jCisrKyBiL2RyaXZlcnMvbmV0L3hlbi1uZXRmcm9udC5jCkBAIC02Niw2 ICs2NiwxMCBAQCBtb2R1bGVfcGFyYW1fbmFtZWQobWF4X3F1ZXVlcywgeGVu bmV0X21heF9xdWV1ZXMsIHVpbnQsIDA2NDQpOwogTU9EVUxFX1BBUk1fREVT QyhtYXhfcXVldWVzLAogCQkgIk1heGltdW0gbnVtYmVyIG9mIHF1ZXVlcyBw ZXIgdmlydHVhbCBpbnRlcmZhY2UiKTsKIAorc3RhdGljIGJvb2wgX19yZWFk X21vc3RseSB4ZW5uZXRfdHJ1c3RlZCA9IHRydWU7Cittb2R1bGVfcGFyYW1f bmFtZWQodHJ1c3RlZCwgeGVubmV0X3RydXN0ZWQsIGJvb2wsIDA2NDQpOwor TU9EVUxFX1BBUk1fREVTQyh0cnVzdGVkLCAiSXMgdGhlIGJhY2tlbmQgdHJ1 c3RlZCIpOworCiAjZGVmaW5lIFhFTk5FVF9USU1FT1VUICAoNSAqIEhaKQog CiBzdGF0aWMgY29uc3Qgc3RydWN0IGV0aHRvb2xfb3BzIHhlbm5ldF9ldGh0 b29sX29wczsKQEAgLTE3NSw2ICsxNzksOSBAQCBzdHJ1Y3QgbmV0ZnJvbnRf aW5mbyB7CiAJLyogSXMgZGV2aWNlIGJlaGF2aW5nIHNhbmU/ICovCiAJYm9v bCBicm9rZW47CiAKKwkvKiBTaG91bGQgc2ticyBiZSBib3VuY2VkIGludG8g YSB6ZXJvZWQgYnVmZmVyPyAqLworCWJvb2wgYm91bmNlOworCiAJYXRvbWlj X3QgcnhfZ3NvX2NoZWNrc3VtX2ZpeHVwOwogfTsKIApAQCAtNjY4LDYgKzY3 NSwzMyBAQCBzdGF0aWMgaW50IHhlbm5ldF94ZHBfeG1pdChzdHJ1Y3QgbmV0 X2RldmljZSAqZGV2LCBpbnQgbiwKIAlyZXR1cm4gbnhtaXQ7CiB9CiAKK3N0 cnVjdCBza19idWZmICpib3VuY2Vfc2tiKGNvbnN0IHN0cnVjdCBza19idWZm ICpza2IpCit7CisJdW5zaWduZWQgaW50IGhlYWRlcmxlbiA9IHNrYl9oZWFk cm9vbShza2IpOworCS8qIEFsaWduIHNpemUgdG8gYWxsb2NhdGUgZnVsbCBw YWdlcyBhbmQgYXZvaWQgY29udGlndW91cyBkYXRhIGxlYWtzICovCisJdW5z aWduZWQgaW50IHNpemUgPSBBTElHTihza2JfZW5kX29mZnNldChza2IpICsg c2tiLT5kYXRhX2xlbiwKKwkJCQkgIFhFTl9QQUdFX1NJWkUpOworCXN0cnVj dCBza19idWZmICpuID0gYWxsb2Nfc2tiKHNpemUsIEdGUF9BVE9NSUMgfCBf X0dGUF9aRVJPKTsKKworCWlmICghbikKKwkJcmV0dXJuIE5VTEw7CisKKwlp ZiAoIUlTX0FMSUdORUQoKHVpbnRwdHJfdCluLT5oZWFkLCBYRU5fUEFHRV9T SVpFKSkgeworCQlXQVJOX09OQ0UoMSwgIm1pc2FsaWduZWQgc2tiIGFsbG9j YXRlZFxuIik7CisJCWtmcmVlX3NrYihuKTsKKwkJcmV0dXJuIE5VTEw7CisJ fQorCisJLyogU2V0IHRoZSBkYXRhIHBvaW50ZXIgKi8KKwlza2JfcmVzZXJ2 ZShuLCBoZWFkZXJsZW4pOworCS8qIFNldCB0aGUgdGFpbCBwb2ludGVyIGFu ZCBsZW5ndGggKi8KKwlza2JfcHV0KG4sIHNrYi0+bGVuKTsKKworCUJVR19P Tihza2JfY29weV9iaXRzKHNrYiwgLWhlYWRlcmxlbiwgbi0+aGVhZCwgaGVh ZGVybGVuICsgc2tiLT5sZW4pKTsKKworCXNrYl9jb3B5X2hlYWRlcihuLCBz a2IpOworCXJldHVybiBuOworfQogCiAjZGVmaW5lIE1BWF9YRU5fU0tCX0ZS QUdTICg2NTUzNiAvIFhFTl9QQUdFX1NJWkUgKyAxKQogCkBAIC03MjEsOSAr NzU1LDEzIEBAIHN0YXRpYyBuZXRkZXZfdHhfdCB4ZW5uZXRfc3RhcnRfeG1p dChzdHJ1Y3Qgc2tfYnVmZiAqc2tiLCBzdHJ1Y3QgbmV0X2RldmljZSAqZGV2 CiAKIAkvKiBUaGUgZmlyc3QgcmVxIHNob3VsZCBiZSBhdCBsZWFzdCBFVEhf SExFTiBzaXplIG9yIHRoZSBwYWNrZXQgd2lsbCBiZQogCSAqIGRyb3BwZWQg YnkgbmV0YmFjay4KKwkgKgorCSAqIElmIHRoZSBiYWNrZW5kIGlzIG5vdCB0 cnVzdGVkIGJvdW5jZSBhbGwgZGF0YSB0byB6ZXJvZWQgcGFnZXMgdG8KKwkg KiBhdm9pZCBleHBvc2luZyBjb250aWd1b3VzIGRhdGEgb24gdGhlIGdyYW50 ZWQgcGFnZSBub3QgYmVsb25naW5nIHRvCisJICogdGhlIHNrYi4KIAkgKi8K LQlpZiAodW5saWtlbHkoUEFHRV9TSVpFIC0gb2Zmc2V0IDwgRVRIX0hMRU4p KSB7Ci0JCW5za2IgPSBza2JfY29weShza2IsIEdGUF9BVE9NSUMpOworCWlm IChucC0+Ym91bmNlIHx8IHVubGlrZWx5KFBBR0VfU0laRSAtIG9mZnNldCA8 IEVUSF9ITEVOKSkgeworCQluc2tiID0gYm91bmNlX3NrYihza2IpOwogCQlp ZiAoIW5za2IpCiAJCQlnb3RvIGRyb3A7CiAJCWRldl9jb25zdW1lX3NrYl9h bnkoc2tiKTsKQEAgLTIyNDcsNiArMjI4NSwxMCBAQCBzdGF0aWMgaW50IHRh bGtfdG9fbmV0YmFjayhzdHJ1Y3QgeGVuYnVzX2RldmljZSAqZGV2LAogCiAJ aW5mby0+bmV0ZGV2LT5pcnEgPSAwOwogCisJLyogQ2hlY2sgaWYgYmFja2Vu ZCBpcyB0cnVzdGVkLiAqLworCWluZm8tPmJvdW5jZSA9ICF4ZW5uZXRfdHJ1 c3RlZCB8fAorCQkgICAgICAgIXhlbmJ1c19yZWFkX3Vuc2lnbmVkKGRldi0+ bm9kZW5hbWUsICJ0cnVzdGVkIiwgMSk7CisKIAkvKiBDaGVjayBpZiBiYWNr ZW5kIHN1cHBvcnRzIG11bHRpcGxlIHF1ZXVlcyAqLwogCW1heF9xdWV1ZXMg PSB4ZW5idXNfcmVhZF91bnNpZ25lZChpbmZvLT54YmRldi0+b3RoZXJlbmQs CiAJCQkJCSAgIm11bHRpLXF1ZXVlLW1heC1xdWV1ZXMiLCAxKTsKQEAgLTI0 MTQsNiArMjQ1Niw5IEBAIHN0YXRpYyBpbnQgeGVubmV0X2Nvbm5lY3Qoc3Ry dWN0IG5ldF9kZXZpY2UgKmRldikKIAkJcmV0dXJuIGVycjsKIAlpZiAobnAt Pm5ldGJhY2tfaGFzX3hkcF9oZWFkcm9vbSkKIAkJcHJfaW5mbygiYmFja2Vu ZCBzdXBwb3J0cyBYRFAgaGVhZHJvb21cbiIpOworCWlmIChucC0+Ym91bmNl KQorCQlkZXZfaW5mbygmbnAtPnhiZGV2LT5kZXYsCisJCQkgImJvdW5jaW5n IHRyYW5zbWl0dGVkIGRhdGEgdG8gemVyb2VkIHBhZ2VzXG4iKTsKIAogCS8q IHRhbGtfdG9fbmV0YmFjaygpIHNldHMgdGhlIGNvcnJlY3QgbnVtYmVyIG9m IHF1ZXVlcyAqLwogCW51bV9xdWV1ZXMgPSBkZXYtPnJlYWxfbnVtX3R4X3F1 ZXVlczsKLS0gCjIuMzYuMAoK --=separator Content-Type: application/octet-stream; name="xsa403/xsa403-linux-4.patch" Content-Disposition: attachment; filename="xsa403/xsa403-linux-4.patch" Content-Transfer-Encoding: base64 RnJvbSA2MWIzN2FiZWMwZDE4ZGNhNDYxN2Q4NmEzZDI3OWY5NjExNGUyN2Uy IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSb2dlciBQYXUgTW9u bmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgpEYXRlOiBUaHUsIDcgQXByIDIw MjIgMTM6MDQ6MjQgKzAyMDAKU3ViamVjdDogW1BBVENIIDQvNF0geGVuL2Js a2Zyb250OiBmb3JjZSBkYXRhIGJvdW5jaW5nIHdoZW4gYmFja2VuZCBpcwog dW50cnVzdGVkCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRlbnQtVHlwZTogdGV4 dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgpTcGxpdCB0aGUgY3VycmVudCBib3VuY2UgYnVmZmVyaW5n IGxvZ2ljIHVzZWQgd2l0aCBwZXJzaXN0ZW50IGdyYW50cwppbnRvIGl0J3Mg b3duIG9wdGlvbiwgYW5kIGFsbG93IGVuYWJsaW5nIGl0IGluZGVwZW5kZW50 bHkgb2YKcGVyc2lzdGVudCBncmFudHMuICBUaGlzIGFsbG93cyB0byByZXVz ZSB0aGUgc2FtZSBjb2RlIHBhdGhzIHRvCnBlcmZvcm0gdGhlIGJvdW5jZSBi dWZmZXJpbmcgcmVxdWlyZWQgdG8gYXZvaWQgbGVha2luZyBjb250aWd1b3Vz IGRhdGEKaW4gc2hhcmVkIHBhZ2VzIG5vdCBwYXJ0IG9mIHRoZSByZXF1ZXN0 IGZyYWdtZW50cy4KClJlcG9ydGluZyB3aGV0aGVyIHRoZSBiYWNrZW5kIGlz IHRvIGJlIHRydXN0ZWQgY2FuIGJlIGRvbmUgdXNpbmcgYQptb2R1bGUgcGFy YW1ldGVyLCBvciBmcm9tIHRoZSB4ZW5zdG9yZSBmcm9udGVuZCBwYXRoIGFz IHNldCBieSB0aGUKdG9vbHN0YWNrIHdoZW4gYWRkaW5nIHRoZSBkZXZpY2Uu CgpUaGlzIGlzIENWRS0yMDIyLTMzNzQyLCBwYXJ0IG9mIFhTQS00MDMuCgpT aWduZWQtb2ZmLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0 cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0Bz dXNlLmNvbT4KLS0tCiBkcml2ZXJzL2Jsb2NrL3hlbi1ibGtmcm9udC5jIHwg NDkgKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tCiAxIGZp bGUgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJvbnQuYyBi L2RyaXZlcnMvYmxvY2sveGVuLWJsa2Zyb250LmMKaW5kZXggMGYyYjRjYjk1 MmE1Li4yNTc3MDZjMzY0NmUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvYmxvY2sv eGVuLWJsa2Zyb250LmMKKysrIGIvZHJpdmVycy9ibG9jay94ZW4tYmxrZnJv bnQuYwpAQCAtMTUyLDYgKzE1MiwxMCBAQCBzdGF0aWMgdW5zaWduZWQgaW50 IHhlbl9ibGtpZl9tYXhfcmluZ19vcmRlcjsKIG1vZHVsZV9wYXJhbV9uYW1l ZChtYXhfcmluZ19wYWdlX29yZGVyLCB4ZW5fYmxraWZfbWF4X3Jpbmdfb3Jk ZXIsIGludCwgMDQ0NCk7CiBNT0RVTEVfUEFSTV9ERVNDKG1heF9yaW5nX3Bh Z2Vfb3JkZXIsICJNYXhpbXVtIG9yZGVyIG9mIHBhZ2VzIHRvIGJlIHVzZWQg Zm9yIHRoZSBzaGFyZWQgcmluZyIpOwogCitzdGF0aWMgYm9vbCBfX3JlYWRf bW9zdGx5IHhlbl9ibGtpZl90cnVzdGVkID0gdHJ1ZTsKK21vZHVsZV9wYXJh bV9uYW1lZCh0cnVzdGVkLCB4ZW5fYmxraWZfdHJ1c3RlZCwgYm9vbCwgMDY0 NCk7CitNT0RVTEVfUEFSTV9ERVNDKHRydXN0ZWQsICJJcyB0aGUgYmFja2Vu ZCB0cnVzdGVkIik7CisKICNkZWZpbmUgQkxLX1JJTkdfU0laRShpbmZvKQlc CiAJX19DT05TVF9SSU5HX1NJWkUoYmxraWYsIFhFTl9QQUdFX1NJWkUgKiAo aW5mbyktPm5yX3JpbmdfcGFnZXMpCiAKQEAgLTIxMCw2ICsyMTQsNyBAQCBz dHJ1Y3QgYmxrZnJvbnRfaW5mbwogCXVuc2lnbmVkIGludCBmZWF0dXJlX2Rp c2NhcmQ6MTsKIAl1bnNpZ25lZCBpbnQgZmVhdHVyZV9zZWNkaXNjYXJkOjE7 CiAJdW5zaWduZWQgaW50IGZlYXR1cmVfcGVyc2lzdGVudDoxOworCXVuc2ln bmVkIGludCBib3VuY2U6MTsKIAl1bnNpZ25lZCBpbnQgZGlzY2FyZF9ncmFu dWxhcml0eTsKIAl1bnNpZ25lZCBpbnQgZGlzY2FyZF9hbGlnbm1lbnQ7CiAJ LyogTnVtYmVyIG9mIDRLQiBzZWdtZW50cyBoYW5kbGVkICovCkBAIC0zMTIs NyArMzE3LDcgQEAgc3RhdGljIGludCBmaWxsX2dyYW50X2J1ZmZlcihzdHJ1 Y3QgYmxrZnJvbnRfcmluZ19pbmZvICpyaW5mbywgaW50IG51bSkKIAkJaWYg KCFnbnRfbGlzdF9lbnRyeSkKIAkJCWdvdG8gb3V0X29mX21lbW9yeTsKIAot CQlpZiAoaW5mby0+ZmVhdHVyZV9wZXJzaXN0ZW50KSB7CisJCWlmIChpbmZv LT5ib3VuY2UpIHsKIAkJCWdyYW50ZWRfcGFnZSA9IGFsbG9jX3BhZ2UoR0ZQ X05PSU8gfCBfX0dGUF9aRVJPKTsKIAkJCWlmICghZ3JhbnRlZF9wYWdlKSB7 CiAJCQkJa2ZyZWUoZ250X2xpc3RfZW50cnkpOwpAQCAtMzMyLDcgKzMzNyw3 IEBAIHN0YXRpYyBpbnQgZmlsbF9ncmFudF9idWZmZXIoc3RydWN0IGJsa2Zy b250X3JpbmdfaW5mbyAqcmluZm8sIGludCBudW0pCiAJbGlzdF9mb3JfZWFj aF9lbnRyeV9zYWZlKGdudF9saXN0X2VudHJ5LCBuLAogCSAgICAgICAgICAg ICAgICAgICAgICAgICAmcmluZm8tPmdyYW50cywgbm9kZSkgewogCQlsaXN0 X2RlbCgmZ250X2xpc3RfZW50cnktPm5vZGUpOwotCQlpZiAoaW5mby0+ZmVh dHVyZV9wZXJzaXN0ZW50KQorCQlpZiAoaW5mby0+Ym91bmNlKQogCQkJX19m cmVlX3BhZ2UoZ250X2xpc3RfZW50cnktPnBhZ2UpOwogCQlrZnJlZShnbnRf bGlzdF9lbnRyeSk7CiAJCWktLTsKQEAgLTM3OCw3ICszODMsNyBAQCBzdGF0 aWMgc3RydWN0IGdyYW50ICpnZXRfZ3JhbnQoZ3JhbnRfcmVmX3QgKmdyZWZf aGVhZCwKIAkvKiBBc3NpZ24gYSBncmVmIHRvIHRoaXMgcGFnZSAqLwogCWdu dF9saXN0X2VudHJ5LT5ncmVmID0gZ250dGFiX2NsYWltX2dyYW50X3JlZmVy ZW5jZShncmVmX2hlYWQpOwogCUJVR19PTihnbnRfbGlzdF9lbnRyeS0+Z3Jl ZiA9PSAtRU5PU1BDKTsKLQlpZiAoaW5mby0+ZmVhdHVyZV9wZXJzaXN0ZW50 KQorCWlmIChpbmZvLT5ib3VuY2UpCiAJCWdyYW50X2ZvcmVpZ25fYWNjZXNz KGdudF9saXN0X2VudHJ5LCBpbmZvKTsKIAllbHNlIHsKIAkJLyogR3JhbnQg YWNjZXNzIHRvIHRoZSBHRk4gcGFzc2VkIGJ5IHRoZSBjYWxsZXIgKi8KQEAg LTQwMiw3ICs0MDcsNyBAQCBzdGF0aWMgc3RydWN0IGdyYW50ICpnZXRfaW5k aXJlY3RfZ3JhbnQoZ3JhbnRfcmVmX3QgKmdyZWZfaGVhZCwKIAkvKiBBc3Np Z24gYSBncmVmIHRvIHRoaXMgcGFnZSAqLwogCWdudF9saXN0X2VudHJ5LT5n cmVmID0gZ250dGFiX2NsYWltX2dyYW50X3JlZmVyZW5jZShncmVmX2hlYWQp OwogCUJVR19PTihnbnRfbGlzdF9lbnRyeS0+Z3JlZiA9PSAtRU5PU1BDKTsK LQlpZiAoIWluZm8tPmZlYXR1cmVfcGVyc2lzdGVudCkgeworCWlmICghaW5m by0+Ym91bmNlKSB7CiAJCXN0cnVjdCBwYWdlICppbmRpcmVjdF9wYWdlOwog CiAJCS8qIEZldGNoIGEgcHJlLWFsbG9jYXRlZCBwYWdlIHRvIHVzZSBmb3Ig aW5kaXJlY3QgZ3JlZnMgKi8KQEAgLTcwNSw3ICs3MTAsNyBAQCBzdGF0aWMg aW50IGJsa2lmX3F1ZXVlX3J3X3JlcShzdHJ1Y3QgcmVxdWVzdCAqcmVxLCBz dHJ1Y3QgYmxrZnJvbnRfcmluZ19pbmZvICpyaQogCQkuZ3JhbnRfaWR4ID0g MCwKIAkJLnNlZ21lbnRzID0gTlVMTCwKIAkJLnJpbmZvID0gcmluZm8sCi0J CS5uZWVkX2NvcHkgPSBycV9kYXRhX2RpcihyZXEpICYmIGluZm8tPmZlYXR1 cmVfcGVyc2lzdGVudCwKKwkJLm5lZWRfY29weSA9IHJxX2RhdGFfZGlyKHJl cSkgJiYgaW5mby0+Ym91bmNlLAogCX07CiAKIAkvKgpAQCAtOTgzLDExICs5 ODgsMTIgQEAgc3RhdGljIHZvaWQgeGx2YmRfZmx1c2goc3RydWN0IGJsa2Zy b250X2luZm8gKmluZm8pCiB7CiAJYmxrX3F1ZXVlX3dyaXRlX2NhY2hlKGlu Zm8tPnJxLCBpbmZvLT5mZWF0dXJlX2ZsdXNoID8gdHJ1ZSA6IGZhbHNlLAog CQkJICAgICAgaW5mby0+ZmVhdHVyZV9mdWEgPyB0cnVlIDogZmFsc2UpOwot CXByX2luZm8oImJsa2Zyb250OiAlczogJXMgJXMgJXMgJXMgJXNcbiIsCisJ cHJfaW5mbygiYmxrZnJvbnQ6ICVzOiAlcyAlcyAlcyAlcyAlcyAlcyAlc1xu IiwKIAkJaW5mby0+Z2QtPmRpc2tfbmFtZSwgZmx1c2hfaW5mbyhpbmZvKSwK IAkJInBlcnNpc3RlbnQgZ3JhbnRzOiIsIGluZm8tPmZlYXR1cmVfcGVyc2lz dGVudCA/CiAJCSJlbmFibGVkOyIgOiAiZGlzYWJsZWQ7IiwgImluZGlyZWN0 IGRlc2NyaXB0b3JzOiIsCi0JCWluZm8tPm1heF9pbmRpcmVjdF9zZWdtZW50 cyA/ICJlbmFibGVkOyIgOiAiZGlzYWJsZWQ7Iik7CisJCWluZm8tPm1heF9p bmRpcmVjdF9zZWdtZW50cyA/ICJlbmFibGVkOyIgOiAiZGlzYWJsZWQ7IiwK KwkJImJvdW5jZSBidWZmZXI6IiwgaW5mby0+Ym91bmNlID8gImVuYWJsZWQi IDogImRpc2FibGVkOyIpOwogfQogCiBzdGF0aWMgaW50IHhlbl90cmFuc2xh dGVfdmRldihpbnQgdmRldmljZSwgaW50ICptaW5vciwgdW5zaWduZWQgaW50 ICpvZmZzZXQpCkBAIC0xMjA5LDcgKzEyMTUsNyBAQCBzdGF0aWMgdm9pZCBi bGtpZl9mcmVlX3Jpbmcoc3RydWN0IGJsa2Zyb250X3JpbmdfaW5mbyAqcmlu Zm8pCiAJaWYgKCFsaXN0X2VtcHR5KCZyaW5mby0+aW5kaXJlY3RfcGFnZXMp KSB7CiAJCXN0cnVjdCBwYWdlICppbmRpcmVjdF9wYWdlLCAqbjsKIAotCQlC VUdfT04oaW5mby0+ZmVhdHVyZV9wZXJzaXN0ZW50KTsKKwkJQlVHX09OKGlu Zm8tPmJvdW5jZSk7CiAJCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZShpbmRp cmVjdF9wYWdlLCBuLCAmcmluZm8tPmluZGlyZWN0X3BhZ2VzLCBscnUpIHsK IAkJCWxpc3RfZGVsKCZpbmRpcmVjdF9wYWdlLT5scnUpOwogCQkJX19mcmVl X3BhZ2UoaW5kaXJlY3RfcGFnZSk7CkBAIC0xMjI2LDcgKzEyMzIsNyBAQCBz dGF0aWMgdm9pZCBibGtpZl9mcmVlX3Jpbmcoc3RydWN0IGJsa2Zyb250X3Jp bmdfaW5mbyAqcmluZm8pCiAJCQkJCQkJICAwVUwpOwogCQkJCXJpbmZvLT5w ZXJzaXN0ZW50X2dudHNfYy0tOwogCQkJfQotCQkJaWYgKGluZm8tPmZlYXR1 cmVfcGVyc2lzdGVudCkKKwkJCWlmIChpbmZvLT5ib3VuY2UpCiAJCQkJX19m cmVlX3BhZ2UocGVyc2lzdGVudF9nbnQtPnBhZ2UpOwogCQkJa2ZyZWUocGVy c2lzdGVudF9nbnQpOwogCQl9CkBAIC0xMjQ3LDcgKzEyNTMsNyBAQCBzdGF0 aWMgdm9pZCBibGtpZl9mcmVlX3Jpbmcoc3RydWN0IGJsa2Zyb250X3Jpbmdf aW5mbyAqcmluZm8pCiAJCWZvciAoaiA9IDA7IGogPCBzZWdzOyBqKyspIHsK IAkJCXBlcnNpc3RlbnRfZ250ID0gcmluZm8tPnNoYWRvd1tpXS5ncmFudHNf dXNlZFtqXTsKIAkJCWdudHRhYl9lbmRfZm9yZWlnbl9hY2Nlc3MocGVyc2lz dGVudF9nbnQtPmdyZWYsIDBVTCk7Ci0JCQlpZiAoaW5mby0+ZmVhdHVyZV9w ZXJzaXN0ZW50KQorCQkJaWYgKGluZm8tPmJvdW5jZSkKIAkJCQlfX2ZyZWVf cGFnZShwZXJzaXN0ZW50X2dudC0+cGFnZSk7CiAJCQlrZnJlZShwZXJzaXN0 ZW50X2dudCk7CiAJCX0KQEAgLTE0MzcsNyArMTQ0Myw3IEBAIHN0YXRpYyBp bnQgYmxraWZfY29tcGxldGlvbih1bnNpZ25lZCBsb25nICppZCwKIAlkYXRh LnMgPSBzOwogCW51bV9zZyA9IHMtPm51bV9zZzsKIAotCWlmIChicmV0LT5v cGVyYXRpb24gPT0gQkxLSUZfT1BfUkVBRCAmJiBpbmZvLT5mZWF0dXJlX3Bl cnNpc3RlbnQpIHsKKwlpZiAoYnJldC0+b3BlcmF0aW9uID09IEJMS0lGX09Q X1JFQUQgJiYgaW5mby0+Ym91bmNlKSB7CiAJCWZvcl9lYWNoX3NnKHMtPnNn LCBzZywgbnVtX3NnLCBpKSB7CiAJCQlCVUdfT04oc2ctPm9mZnNldCArIHNn LT5sZW5ndGggPiBQQUdFX1NJWkUpOwogCkBAIC0xNDk2LDcgKzE1MDIsNyBA QCBzdGF0aWMgaW50IGJsa2lmX2NvbXBsZXRpb24odW5zaWduZWQgbG9uZyAq aWQsCiAJCQkJICogQWRkIHRoZSB1c2VkIGluZGlyZWN0IHBhZ2UgYmFjayB0 byB0aGUgbGlzdCBvZgogCQkJCSAqIGF2YWlsYWJsZSBwYWdlcyBmb3IgaW5k aXJlY3QgZ3JlZnMuCiAJCQkJICovCi0JCQkJaWYgKCFpbmZvLT5mZWF0dXJl X3BlcnNpc3RlbnQpIHsKKwkJCQlpZiAoIWluZm8tPmJvdW5jZSkgewogCQkJ CQlpbmRpcmVjdF9wYWdlID0gcy0+aW5kaXJlY3RfZ3JhbnRzW2ldLT5wYWdl OwogCQkJCQlsaXN0X2FkZCgmaW5kaXJlY3RfcGFnZS0+bHJ1LCAmcmluZm8t PmluZGlyZWN0X3BhZ2VzKTsKIAkJCQl9CkBAIC0xNzg3LDYgKzE3OTMsMTAg QEAgc3RhdGljIGludCB0YWxrX3RvX2Jsa2JhY2soc3RydWN0IHhlbmJ1c19k ZXZpY2UgKmRldiwKIAlpZiAoIWluZm8pCiAJCXJldHVybiAtRU5PREVWOwog CisJLyogQ2hlY2sgaWYgYmFja2VuZCBpcyB0cnVzdGVkLiAqLworCWluZm8t PmJvdW5jZSA9ICF4ZW5fYmxraWZfdHJ1c3RlZCB8fAorCQkgICAgICAgIXhl bmJ1c19yZWFkX3Vuc2lnbmVkKGRldi0+bm9kZW5hbWUsICJ0cnVzdGVkIiwg MSk7CisKIAltYXhfcGFnZV9vcmRlciA9IHhlbmJ1c19yZWFkX3Vuc2lnbmVk KGluZm8tPnhiZGV2LT5vdGhlcmVuZCwKIAkJCQkJICAgICAgIm1heC1yaW5n LXBhZ2Utb3JkZXIiLCAwKTsKIAlyaW5nX3BhZ2Vfb3JkZXIgPSBtaW4oeGVu X2Jsa2lmX21heF9yaW5nX29yZGVyLCBtYXhfcGFnZV9vcmRlcik7CkBAIC0y MTk4LDEwICsyMjA4LDEwIEBAIHN0YXRpYyBpbnQgYmxrZnJvbnRfc2V0dXBf aW5kaXJlY3Qoc3RydWN0IGJsa2Zyb250X3JpbmdfaW5mbyAqcmluZm8pCiAJ aWYgKGVycikKIAkJZ290byBvdXRfb2ZfbWVtb3J5OwogCi0JaWYgKCFpbmZv LT5mZWF0dXJlX3BlcnNpc3RlbnQgJiYgaW5mby0+bWF4X2luZGlyZWN0X3Nl Z21lbnRzKSB7CisJaWYgKCFpbmZvLT5ib3VuY2UgJiYgaW5mby0+bWF4X2lu ZGlyZWN0X3NlZ21lbnRzKSB7CiAJCS8qCi0JCSAqIFdlIGFyZSB1c2luZyBp bmRpcmVjdCBkZXNjcmlwdG9ycyBidXQgbm90IHBlcnNpc3RlbnQKLQkJICog Z3JhbnRzLCB3ZSBuZWVkIHRvIGFsbG9jYXRlIGEgc2V0IG9mIHBhZ2VzIHRo YXQgY2FuIGJlCisJCSAqIFdlIGFyZSB1c2luZyBpbmRpcmVjdCBkZXNjcmlw dG9ycyBidXQgZG9uJ3QgaGF2ZSBhIGJvdW5jZQorCQkgKiBidWZmZXIsIHdl IG5lZWQgdG8gYWxsb2NhdGUgYSBzZXQgb2YgcGFnZXMgdGhhdCBjYW4gYmUK IAkJICogdXNlZCBmb3IgbWFwcGluZyBpbmRpcmVjdCBncmVmcwogCQkgKi8K IAkJaW50IG51bSA9IElORElSRUNUX0dSRUZTKGdyYW50cykgKiBCTEtfUklO R19TSVpFKGluZm8pOwpAQCAtMjMwMiw2ICsyMzEyLDggQEAgc3RhdGljIHZv aWQgYmxrZnJvbnRfZ2F0aGVyX2JhY2tlbmRfZmVhdHVyZXMoc3RydWN0IGJs a2Zyb250X2luZm8gKmluZm8pCiAJCWluZm8tPmZlYXR1cmVfcGVyc2lzdGVu dCA9CiAJCQkhIXhlbmJ1c19yZWFkX3Vuc2lnbmVkKGluZm8tPnhiZGV2LT5v dGhlcmVuZCwKIAkJCQkJICAgICAgICJmZWF0dXJlLXBlcnNpc3RlbnQiLCAw KTsKKwlpZiAoaW5mby0+ZmVhdHVyZV9wZXJzaXN0ZW50KQorCQlpbmZvLT5i b3VuY2UgPSB0cnVlOwogCiAJaW5kaXJlY3Rfc2VnbWVudHMgPSB4ZW5idXNf cmVhZF91bnNpZ25lZChpbmZvLT54YmRldi0+b3RoZXJlbmQsCiAJCQkJCSJm ZWF0dXJlLW1heC1pbmRpcmVjdC1zZWdtZW50cyIsIDApOwpAQCAtMjU3MCw2 ICsyNTgyLDEzIEBAIHN0YXRpYyB2b2lkIGJsa2Zyb250X2RlbGF5X3dvcmso c3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQogCXN0cnVjdCBibGtmcm9udF9p bmZvICppbmZvOwogCWJvb2wgbmVlZF9zY2hlZHVsZV93b3JrID0gZmFsc2U7 CiAKKwkvKgorCSAqIE5vdGUgdGhhdCB3aGVuIHVzaW5nIGJvdW5jZSBidWZm ZXJzIGJ1dCBub3QgcGVyc2lzdGVudCBncmFudHMKKwkgKiB0aGVyZSdzIG5v IG5lZWQgdG8gcnVuIGJsa2Zyb250X2RlbGF5X3dvcmsgYmVjYXVzZSBncmFu dHMgYXJlCisJICogcmV2b2tlZCBpbiBibGtpZl9jb21wbGV0aW9uIG9yIGVs c2UgYW4gZXJyb3IgaXMgcmVwb3J0ZWQgYW5kIHRoZQorCSAqIGNvbm5lY3Rp b24gaXMgY2xvc2VkLgorCSAqLworCiAJbXV0ZXhfbG9jaygmYmxrZnJvbnRf bXV0ZXgpOwogCiAJbGlzdF9mb3JfZWFjaF9lbnRyeShpbmZvLCAmaW5mb19s aXN0LCBpbmZvX2xpc3QpIHsKLS0gCjIuMzYuMAoK --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:04:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:04:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360839.590326 (Exim 4.92) (envelope-from ) id 1o8hIE-00057x-D8; Tue, 05 Jul 2022 12:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360839.590326; Tue, 05 Jul 2022 12:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hIE-00056o-3Q; Tue, 05 Jul 2022 12:04:38 +0000 Received: by outflank-mailman (input) for mailman id 360839; Tue, 05 Jul 2022 12:04:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hIB-0003yR-Kz for xen-devel@lists.xen.org; Tue, 05 Jul 2022 12:04:35 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9eb7ed0d-fc5a-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:04:32 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hHu-0003NI-Fw; Tue, 05 Jul 2022 12:04:18 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8hHu-0004G2-Eq; Tue, 05 Jul 2022 12:04:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9eb7ed0d-fc5a-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=QAl9nOVTcMC4khUODf/sp9Yo/Uls9NnRuFaD0BAPueY=; b=l6Mf2w3V7T4K7eM3Mo/eb7VX3F xemvX6yj6UVHsLHOZT1kzGbGTkp9kZ+K1SKP3ai1rk+8jFWo4iv9Bq5eDYYTgEJps+wKn+YoxqOyB 3upUaM0vPzMA4/g1x2Y1tus1ZGTcLCTGxZkJObN/hFG6mxSklMZI7Ln9RBswKGV9vITw=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 405 v3 (CVE-2022-33743) - network backend may cause Linux netfront to use freed SKBs Message-Id: Date: Tue, 05 Jul 2022 12:04:18 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-33743 / XSA-405 version 3 network backend may cause Linux netfront to use freed SKBs UPDATES IN VERSION 3 ==================== Public release. ISSUE DESCRIPTION ================= While adding logic to support XDP (eXpress Data Path), a code label was moved in a way allowing for SKBs having references (pointers) retained for further processing to nevertheless be freed. IMPACT ====== A misbehaving or malicious backend may cause a Denial of Service (DoS) in the guest. Information leaks or privilege escalation cannot be ruled out. VULNERABLE SYSTEMS ================== Linux versions 5.9 - 5.18 are vulnerable. Linux versions 5.8 and earlier are not vulnerable. This vulnerability only increases the capability of an attacker in systems with less than fully privileged network backends (e.g. network driver domains). For systems where netback runs in dom0 (the default configuration), this vulnerability does not increase the capabilities of an attacker. MITIGATION ========== There is no mitigation available other than not using PV devices in case a backend is suspected to be potentially malicious. CREDITS ======= This issue was discovered by Jan Beulich of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa405-linux.patch Linux 5.9 - 5.19-rc $ sha256sum xsa405* 69716b78fbd996bce0414079bbb5f002029c5a82924aaae0db78a13c4b385f0a xsa405-linux.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of patches or mitigations is NOT permitted (except where all the affected systems and VMs are administered and used only by organisations which are members of the Xen Project Security Issues Predisclosure List). Specifically, deployment on public cloud systems is NOT permitted. This is because the patches need to be applied in the affected guests. Switching from PV to non-PV devices is observable by the guests and has usually a bad performance impact. Deployment is permitted only AFTER the embargo ends. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLEFgAMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZgG4H/3KYUQdJlSEq2AEmIZhh1HDdhj/9n9Wxm0eHEqEQ pXvflqbqb2glZpQyWcFPcY4oRRYvy58p9FIEi3PJD+52K/7h58XcTEZKDFP87z53 iqATbN4s/wHQ45xWAuIEHsmfLRtj3gIr4qviux3dtygKMjo6cZDX7Ethv6j0xdgc lEUfvisH+3ZXG+JOQbZyxmi6g1SGDf1TJQczXR1rJjIp/npTupfFO+4r+vpiypbI 6ytFrRwmqfzuO8Mz5Wqrda8Fkk3JYoYtJdBfd/hYNu5vBN0d4o82sbZpuzVgdRI4 H+R90MB1XpZJ/mSYEDBbEctbmTFfJrRvr9yGjtCi8ivvQ5I= =fMa/ -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa405-linux.patch" Content-Disposition: attachment; filename="xsa405-linux.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ZW4tbmV0ZnJvbnQ6IHJlc3RvcmUgX19za2JfcXVldWVfdGFpbCgpIHBv c2l0aW9uaW5nIGluIHhlbm5ldF9nZXRfcmVzcG9uc2VzKCkKClRoZSBjb21t aXQgcmVmZXJlbmNlZCBiZWxvdyBtb3ZlZCB0aGUgaW52b2NhdGlvbiBwYXN0 IHRoZSAibmV4dCIgbGFiZWwsCndpdGhvdXQgYW55IGV4cGxhbmF0aW9uLiBJ biBmYWN0IHRoaXMgYWxsb3dzIG1pc2JlaGF2aW5nIGJhY2tlbmRzIHVuZHVl CmNvbnRyb2wgb3ZlciB0aGUgZG9tYWluIHRoZSBmcm9udGVuZCBydW5zIGlu LCBhcyBlYXJsaWVyIGRldGVjdGVkIGVycm9ycwpyZXF1aXJlIHRoZSBza2Ig dG8gbm90IGJlIGZyZWVkIChpdCBtYXkgYmUgcmV0YWluZWQgZm9yIGxhdGVy IHByb2Nlc3NpbmcKdmlhIHhlbm5ldF9tb3ZlX3J4X3Nsb3QoKSwgb3IgaXQg bWF5IHNpbXBseSBiZSB1bnNhZmUgdG8gaGF2ZSBpdCBmcmVlZCkuCgpUaGlz IGlzIENWRS0yMDIyLTMzNzQzIC8gWFNBLTQwNS4KCkZpeGVzOiA2YzVhYTZm YzRkZWYgKCJ4ZW4gbmV0d29ya2luZzogYWRkIGJhc2ljIFhEUCBzdXBwb3J0 IGZvciB4ZW4tbmV0ZnJvbnQiKQpTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+ClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdy b3NzIDxqZ3Jvc3NAc3VzZS5jb20+Ci0tLQpUaGUgY2hhbmdlIGluIHF1ZXN0 aW9uIGFzIHdlbGwgYXMgdGhlIHJlc3BlY3RpdmUgbmV0aWYuaCBjaGFuZ2Ug d2VudAppbiB3aXRob3V0IGFueSBYZW4gcGVyc29uJ3MgYWNrIG9yIFItYjsg b25seSB0aGUgY29ycmVzcG9uZGluZyBiYWNrZW5kCmNoYW5nZSBoYXMgUGF1 bCdzIFItYi4gVGhpcyBpbiBwYXJ0aWN1bGFyIG1lYW5zIHRoYXQgdGhlIGlu dGVyZmFjZQphZGRpdGlvbiBpcyBzdGlsbCB1bm9mZmljaWFsIChhbmQgYXQg cmlzayBvZiBjb2xsaWRpbmcgd2l0aCBzb21lb25lCmVsc2UncyksIGZvciBu b3QgaGF2aW5nIGJlZW4gY29tbWl0dGVkIHRvIHRoZSBjYW5vbmljYWwgY29w eSBvZiB0aGUKaGVhZGVyIGluIHhlbi5naXQuCgotLS0gYS9kcml2ZXJzL25l dC94ZW4tbmV0ZnJvbnQuYworKysgYi9kcml2ZXJzL25ldC94ZW4tbmV0ZnJv bnQuYwpAQCAtMTA1Myw4ICsxMDUzLDEwIEBAIHN0YXRpYyBpbnQgeGVubmV0 X2dldF9yZXNwb25zZXMoc3RydWN0IG4KIAkJCX0KIAkJfQogCQlyY3VfcmVh ZF91bmxvY2soKTsKLW5leHQ6CisKIAkJX19za2JfcXVldWVfdGFpbChsaXN0 LCBza2IpOworCituZXh0OgogCQlpZiAoIShyeC0+ZmxhZ3MgJiBYRU5fTkVU UlhGX21vcmVfZGF0YSkpCiAJCQlicmVhazsKIAo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:04:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:04:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.360843.590351 (Exim 4.92) (envelope-from ) id 1o8hIG-0005eA-7p; Tue, 05 Jul 2022 12:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 360843.590351; Tue, 05 Jul 2022 12:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hIF-0005bb-Tj; Tue, 05 Jul 2022 12:04:39 +0000 Received: by outflank-mailman (input) for mailman id 360843; Tue, 05 Jul 2022 12:04:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hID-0003yR-LE for xen-devel@lists.xen.org; Tue, 05 Jul 2022 12:04:37 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ee01fca-fc5a-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:04:32 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hHz-0003No-39; Tue, 05 Jul 2022 12:04:23 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8hHz-0004HG-2A; Tue, 05 Jul 2022 12:04:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ee01fca-fc5a-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=Y5Aw9EVfdlix6vLX+W3t433fZ2ikgPc5rEtvnO0yoTc=; b=6IRBwThY58/hcpCkCLK0hyENDW 8XR2RDCYKEVOKCt7BuUgJ7foGl4bn/dauM9CxptAo7l9+p9OrH15Q8WSeymvy3a72TRQXKA6XEuwl KniRi3zsFG6jE0O5iuaMOskb783tET01dY8aIPjMwPO2QEACTpxJAkNlOf80Puv+NzBk=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 406 v3 (CVE-2022-33744) - Arm guests can cause Dom0 DoS via PV devices Message-Id: Date: Tue, 05 Jul 2022 12:04:23 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-33744 / XSA-406 version 3 Arm guests can cause Dom0 DoS via PV devices UPDATES IN VERSION 3 ==================== Public release. ISSUE DESCRIPTION ================= When mapping pages of guests on Arm, dom0 is using an rbtree to keep track of the foreign mappings. Updating of that rbtree is not always done completely with the related lock held, resulting in a small race window, which can be used by unprivileged guests via PV devices to cause inconsistencies of the rbtree. These inconsistencies can lead to Denial of Service (DoS) of dom0, e.g. by causing crashes or the inability to perform further mappings of other guests' memory pages. IMPACT ====== A guest performing multiple I/Os of PV devices in parallel can cause DoS of dom0 and thus of the complete host. VULNERABLE SYSTEMS ================== Only Arm systems (32-bit and 64-bit) are vulnerable. Dom0 Linux versions 3.13 - 5.18 are vulnerable. X86 systems are not vulnerable. MITIGATION ========== There is no mitigation available. CREDITS ======= This issue was discovered by Oleksandr Tyshchenko of EPAM. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa406-linux.patch Linux 3.13 - 5.19-rc $ sha256sum xsa406* 7a789f564b3365cade6e95d549dbbd5a8b7b5e53d09bc5a463c77dfefd5a4182 xsa406-linux.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLEFgEMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZwJUIAJSrSYNMQE4jo1sJFKjEJ3cHy6CymbJC94JSm2Tf HzeMlwd7NQF3Sc2HSWQoCSI+0TiRb6bJpfZASsbL/E3b6zcm3+VxwS7HVUtvHXhN HJYRUMN9vckUkGwWDYbgveI7uie9P7gpjwi5CEXxQf4NO9Oloyk2J5bijktzbBN2 9FIZ7zFuiSRwGtr2WRaozCSzgg4EGiPRc5eMCFMP+K0P+oRvpkE52wWo/ZOPzW8T xocUIcvQK335ib04OCS3oqJZrRNwrvX6Vn+CifXac2WHR9tQ24VnTq1iYRrVD+5x kxpg4IuiNc2eD8lZCLnKEUDUj6LzWvgxKoxXgJFKXlESb0A= =57so -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa406-linux.patch" Content-Disposition: attachment; filename="xsa406-linux.patch" Content-Transfer-Encoding: base64 eGVuL2FybTogRml4IHJhY2UgaW4gUkItdHJlZSBiYXNlZCBQMk0gYWNjb3Vu dGluZwoKRHVyaW5nIHRoZSBQViBkcml2ZXIgbGlmZSBjeWNsZSB0aGUgbWFw cGluZ3MgYXJlIGFkZGVkIHRvCnRoZSBSQi10cmVlIGJ5IHNldF9mb3JlaWdu X3AybV9tYXBwaW5nKCksIHdoaWNoIGlzIGNhbGxlZCBmcm9tCmdudHRhYl9t YXBfcmVmcygpIGFuZCBhcmUgcmVtb3ZlZCBieSBjbGVhcl9mb3JlaWduX3Ay bV9tYXBwaW5nKCkKd2hpY2ggaXMgY2FsbGVkIGZyb20gZ250dGFiX3VubWFw X3JlZnMoKS4gQXMgYm90aCBmdW5jdGlvbnMgZW5kCnVwIGNhbGxpbmcgX19z ZXRfcGh5c190b19tYWNoaW5lX211bHRpKCkgd2hpY2ggdXBkYXRlcyB0aGUg UkItdHJlZSwKdGhpcyBmdW5jdGlvbiBjYW4gYmUgY2FsbGVkIGNvbmN1cnJl bnRseS4KClRoZXJlIGlzIGFscmVhZHkgYSAicDJtX2xvY2siIHRvIHByb3Rl Y3QgYWdhaW5zdCBjb25jdXJyZW50IGFjY2Vzc2VzLApidXQgdGhlIHByb2Js ZW0gaXMgdGhhdCB0aGUgZmlyc3QgcmVhZCBvZiAicGh5c190b19tYWNoLnJi X25vZGUiCmluIF9fc2V0X3BoeXNfdG9fbWFjaGluZV9tdWx0aSgpIGlzIG5v dCBjb3ZlcmVkIGJ5IGl0LCBzbyB0aGlzIG1pZ2h0CmxlYWQgdG8gdGhlIGlu Y29ycmVjdCBtYXBwaW5ncyB1cGRhdGUgKHJlbW92aW5nIGluIG91ciBjYXNl KSBpbiBSQi10cmVlLgoKSW4gbXkgZW52aXJvbm1lbnQgdGhlIHJlbGF0ZWQg aXNzdWUgaGFwcGVucyByYXJlbHkgYW5kIG9ubHkgd2hlbgpQViBuZXQgYmFj a2VuZCBpcyBydW5uaW5nLCB0aGUgeGVuX2FkZF9waHlzX3RvX21hY2hfZW50 cnkoKSBjbGFpbXMKdGhhdCBpdCBjYW5ub3QgYWRkIG5ldyBwZm4gPC0+IG1m biBtYXBwaW5nIHRvIHRoZSB0cmVlIHNpbmNlIGl0IGlzCmFscmVhZHkgZXhp c3RzIHdoaWNoIHJlc3VsdHMgaW4gYSBmYWlsdXJlIHdoZW4gbWFwcGluZyBm b3JlaWduIHBhZ2VzLgoKQnV0IHRoZXJlIG1pZ2h0IGJlIG90aGVyIGJhZCBj b25zZXF1ZW5jZXMgcmVsYXRlZCB0byB0aGUgbm9uLXByb3RlY3RlZApyb290 IHJlYWRzIHN1Y2ggdXNlLWFmdGVyLWZyZWUsIGV0Yy4KCldoaWxlIGF0IGl0 LCBhbHNvIGZpeCB0aGUgc2ltaWxhciB1c2FnZSBpbiBfX3Bmbl90b19tZm4o KSwgc28KaW5pdGlhbGl6ZSAic3RydWN0IHJiX25vZGUgKm4iIHdpdGggdGhl ICJwMm1fbG9jayIgaGVsZCBpbiBib3RoCmZ1bmN0aW9ucyB0byBhdm9pZCBw b3NzaWJsZSBiYWQgY29uc2VxdWVuY2VzLgoKVGhpcyBpcyBDVkUtMjAyMi0z Mzc0NCAvIFhTQS00MDYuCgpSZXBvcnRlZC1ieTogT2xla3NhbmRyIFR5c2hj aGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPgpTaWduZWQt b2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hj aGVua29AZXBhbS5jb20+ClJldmlld2VkLWJ5OiBTdGVmYW5vIFN0YWJlbGxp bmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+Ci0tLQogYXJjaC9hcm0veGVu L3AybS5jIHwgNiArKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvYXJjaC9hcm0v eGVuL3AybS5jIGIvYXJjaC9hcm0veGVuL3AybS5jCmluZGV4IDg0YTFjZWEu LjMwOTY0OGMxIDEwMDY0NAotLS0gYS9hcmNoL2FybS94ZW4vcDJtLmMKKysr IGIvYXJjaC9hcm0veGVuL3AybS5jCkBAIC02MywxMSArNjMsMTIgQEAgc3Rh dGljIGludCB4ZW5fYWRkX3BoeXNfdG9fbWFjaF9lbnRyeShzdHJ1Y3QgeGVu X3AybV9lbnRyeSAqbmV3KQogCiB1bnNpZ25lZCBsb25nIF9fcGZuX3RvX21m bih1bnNpZ25lZCBsb25nIHBmbikKIHsKLQlzdHJ1Y3QgcmJfbm9kZSAqbiA9 IHBoeXNfdG9fbWFjaC5yYl9ub2RlOworCXN0cnVjdCByYl9ub2RlICpuOwog CXN0cnVjdCB4ZW5fcDJtX2VudHJ5ICplbnRyeTsKIAl1bnNpZ25lZCBsb25n IGlycWZsYWdzOwogCiAJcmVhZF9sb2NrX2lycXNhdmUoJnAybV9sb2NrLCBp cnFmbGFncyk7CisJbiA9IHBoeXNfdG9fbWFjaC5yYl9ub2RlOwogCXdoaWxl IChuKSB7CiAJCWVudHJ5ID0gcmJfZW50cnkobiwgc3RydWN0IHhlbl9wMm1f ZW50cnksIHJibm9kZV9waHlzKTsKIAkJaWYgKGVudHJ5LT5wZm4gPD0gcGZu ICYmCkBAIC0xNTIsMTAgKzE1MywxMSBAQCBib29sIF9fc2V0X3BoeXNfdG9f bWFjaGluZV9tdWx0aSh1bnNpZ25lZCBsb25nIHBmbiwKIAlpbnQgcmM7CiAJ dW5zaWduZWQgbG9uZyBpcnFmbGFnczsKIAlzdHJ1Y3QgeGVuX3AybV9lbnRy eSAqcDJtX2VudHJ5OwotCXN0cnVjdCByYl9ub2RlICpuID0gcGh5c190b19t YWNoLnJiX25vZGU7CisJc3RydWN0IHJiX25vZGUgKm47CiAKIAlpZiAobWZu ID09IElOVkFMSURfUDJNX0VOVFJZKSB7CiAJCXdyaXRlX2xvY2tfaXJxc2F2 ZSgmcDJtX2xvY2ssIGlycWZsYWdzKTsKKwkJbiA9IHBoeXNfdG9fbWFjaC5y Yl9ub2RlOwogCQl3aGlsZSAobikgewogCQkJcDJtX2VudHJ5ID0gcmJfZW50 cnkobiwgc3RydWN0IHhlbl9wMm1fZW50cnksIHJibm9kZV9waHlzKTsKIAkJ CWlmIChwMm1fZW50cnktPnBmbiA8PSBwZm4gJiYKLS0gCjIuNy40Cgo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:10:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:10:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361065.590405 (Exim 4.92) (envelope-from ) id 1o8hO8-0004YB-KF; Tue, 05 Jul 2022 12:10:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361065.590405; Tue, 05 Jul 2022 12:10:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hO8-0004Y4-Gf; Tue, 05 Jul 2022 12:10:44 +0000 Received: by outflank-mailman (input) for mailman id 361065; Tue, 05 Jul 2022 12:10:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hKt-0003wr-HR for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:07:23 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150041.outbound.protection.outlook.com [40.107.15.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 064e8da6-fc5b-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:07:22 +0200 (CEST) Received: from DB8PR06CA0020.eurprd06.prod.outlook.com (2603:10a6:10:100::33) by DB6PR0802MB2150.eurprd08.prod.outlook.com (2603:10a6:4:85::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Tue, 5 Jul 2022 12:07:19 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::bd) by DB8PR06CA0020.outlook.office365.com (2603:10a6:10:100::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Tue, 5 Jul 2022 12:07:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 12:07:19 +0000 Received: ("Tessian outbound ef501234d194:v121"); Tue, 05 Jul 2022 12:07:19 +0000 Received: from cd99d427b84e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B63FC358-BF4E-4A4D-B7B7-F3D4F520C0D9.1; Tue, 05 Jul 2022 12:07:08 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd99d427b84e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 12:07:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2423.eurprd08.prod.outlook.com (2603:10a6:4:99::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 12:07:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 12:07:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 064e8da6-fc5b-11ec-a8e4-439420d8e422 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lTijokD91UPpGP/z9rxyYJvu2+FEsOu9AsUwSs8gupdX/FajA+91F0NpFEIF2+a2D/Kd6JBgEnfPKH8dBOBYNkCbn/A0tui4IDEyJWVmr51fMucB3Bq4D7Y8pyUQO8FH4Y04ehN3i1Tk2oquu67Y8l0aHLQlUKl3cnmFtG1Dl9fDdBRSR8WADWmOPwsUyGtxDHVGuOfm3e25rzd89Ce/Kzfm2slKmmJdfER22ftiwiDEANKhVU0wCGakTDlTtxv36NNL9sWEoAObbbA2ey2rRJlNqwOxHTZ4kqrjOlWWtwyZebzd6Om3Yn5Ggx4PWH1PuiLScwlBSjDWGEFfm1PSWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJAiatbeIknsUIbYDqTpSK9a+9TNf6F3bojQhB2LLfE=; b=N0yrjAS+ADTaNyyPQkeJgJD0fhwOms3nO80Rw6bkuOpa8O2elyMfjtenI4XtDV2dJtUP/YJs3vqbv/G9fNCwl0F8e+dCuE/IByLnWdRH7gi72QmWKo/hnKFpDw7t972lRcq8cbTsMgReV+x49GjvgZXBNphSvQnYzKIRKL+A4zd4awMZjuNAVUZ/OnGiPsJvVBcIuD3urauLqD1ereasVPj9hPsXjQpzpB5MK4UL/o4ZM6e1JaEjAk3i6EKmUnB3VMNjyUyxZkitPtyd+vpJa+F2fyN2jygrcdXQyU0hNNuE/OPXAP4o8MfshMEen1HOyQQiwYrYXXY70Gq3+JYfoQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zJAiatbeIknsUIbYDqTpSK9a+9TNf6F3bojQhB2LLfE=; b=VMdOTBNMmK2RHhPf5eDHkMYGgOdzIjDXvoLcR7ZOGIWQbd73Cn3RkxbeMagjUVlMX+nxedZsklx9wQF+mp/SzsaJAydm0c5I2G4UHRvC3qjnnpqBLneI7uVej+JmOLMERYaH26euYRvvoysHVI5+yWx5vfE8MqUf+yyfOyadQCE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 06446c525ddfd82f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHrIUDJOMDL+e9n71/DzpVHMRZH8dfVnlfF+WSznK8TP5nFqLtWiPyi8RlzWF/cZ92Ksn0MR2HZ81l/9qheI6PFKfv5U+R04YlI9RoTFjq7Jviacmag+QN8Fy6KOOvWMsIv4z/Zpc6hz2eHAHKHQQoEEyn4ZuDEXwQV9JklPByDaITHV41G6S+RcnwdyUIoCck8lu1Ojf5ecjvgRNc5ZWC5Sbqj4yCbeUWz8sjVldrfuz8rTOBazjLGojiKikmPrAuKQBi9bUr3KW4dASJ8fZTlV5nznpTd1WVRLK/CKYGRBbR14euY9iwRruJYTVSg1r/dDwTI8MGJeL6RiDJ7G2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zJAiatbeIknsUIbYDqTpSK9a+9TNf6F3bojQhB2LLfE=; b=jziJNKKQi87lKfCX6mEwHIXif0GCdMoDmlN0NP/6sa50PHsM7kdUml2of8JkRo+Kw2XbiTX2+UwNcPYJrSMkdjph6tG0NCyhmbUodf1gaSo1BrTlVttvk8E1GFDbHPKy/n5ypNijbMT5Zh5WWW/zH0xbI1rOsOt9WA6U2+Oy6ewfVo/N9R/0FbSiif6dSB2iT/UrYT+94WMa3skChdMPrvB7uArcPmI1aywXBK6EzKgUj5/+nuj2cA4Qgr7053z1gb6p7PMlr7JUhwa/yhymdNiw42MAfo3tEvDIQESJ9VysGiOQSnuMNCZ1kUykq2tpOPTA95WKAZpxt6mbKRCvDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zJAiatbeIknsUIbYDqTpSK9a+9TNf6F3bojQhB2LLfE=; b=VMdOTBNMmK2RHhPf5eDHkMYGgOdzIjDXvoLcR7ZOGIWQbd73Cn3RkxbeMagjUVlMX+nxedZsklx9wQF+mp/SzsaJAydm0c5I2G4UHRvC3qjnnpqBLneI7uVej+JmOLMERYaH26euYRvvoysHVI5+yWx5vfE8MqUf+yyfOyadQCE= From: Bertrand Marquis To: Julien Grall CC: Michal Orzel , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross , Dario Faggioli Subject: Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned Thread-Topic: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned Thread-Index: AQHYiig4f5ZNYQgFekivSKiReIklQK1mNqmAgAABsoCACYLPAA== Date: Tue, 5 Jul 2022 12:07:04 +0000 Message-ID: <32242AE5-AF31-4AE1-94FC-4375E9CEE007@arm.com> References: <20220627131543.410971-1-michal.orzel@arm.com> <20220627131543.410971-4-michal.orzel@arm.com> <4ee1fbaf-9d31-d28e-cb8d-f330c6a1923f@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4234b753-70d6-4269-0dc1-08da5e7ee8cd x-ms-traffictypediagnostic: DB6PR0802MB2423:EE_|DBAEUR03FT017:EE_|DB6PR0802MB2150:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YY5a7f2VLqwwBCYQJzMZnn1Z/QiIIz6m9nYZrinhannbETx1oaVGzb9MyITAjKtlVW4k2ZE5MoB3GX+EvceChkFi8tu1qcDffCmlXqe8dL4QIVRJBY4WXYYNq+kcHRiJXZxODln4RyQPxJWaPn1pBrwUEyI1uqR0VsJygbywEc/E0kZ7xBIRrWlO+TNN4qSojxcfFgmSR9AJKTGZD5/d31ah2G5ZWx4E/E62LrZD+DDUSpAfwjzjJMYNdLP/tVXgHgGbsEudmgrUlccJbj/GpeCRPtdAFFvrsZmyTiaGmgktICAZKPzMfigHra809QrxB6BqdBiVB71BEKL1G1H3D6r/WttxClr90ZuAAIMUko2EvW+uqCulNSHGZgZ1cpzjosUMInT3PhwPmue4OXM0L/+aCFD56L9cai2mFYzQzxIu/ok+i/OQKoe8CZyJW80T7RsqtNHdE8Mvoen6psE7uxgWPWmevAr6ARZe0bzwq3KXEC1qaxWVaLf0sUmlNBYlYELjNRg6+qxRcV+03GyUsAbfBFWXBxgjLVhpEercGA2O1peoDRHZj5DXNOfabzMrPB6tFUqpjwJa2RdbhlslAIVuhxB7Y9Q7mwGEk3ftJ9DoxagjbTOiP/6PcnS+QZk7a5u+468faFBUgBHKcZzPuQVhfbG8mb3ZKmME3ApA4K7qVwFyqe0GvleLXOY+hmCgwqlUk2D3WNR+XReqikLhrUYMtPgYBITFPiNSpiI1cqdCk/q6oH1j6R+C9aD0ieZ6EVKRrjcqmTNXnw22St9q9wUU6CePGkiO41gHH8+NCe18aGxpTh185P6O2iie60PlFU0+fww17Wd85f7uwfBtSNdr8LzIy2JNMEYBU1kDgtY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(91956017)(66556008)(4326008)(66446008)(66946007)(64756008)(8676002)(66476007)(76116006)(186003)(38100700002)(38070700005)(316002)(2616005)(6486002)(122000001)(71200400001)(41300700001)(6506007)(478600001)(6512007)(26005)(54906003)(53546011)(6916009)(83380400001)(2906002)(4744005)(33656002)(5660300002)(86362001)(8936002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <966CD3112E3D9C4A875BAD2B20B809C7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2423 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 646c8403-8dac-42db-a405-08da5e7ee066 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GOyYnuwwQPz9Q0pGL4YCmfqbu6pe2eBbyO3/VXPXO6QVfqnkTztMMNfv7JV6UjMmQ6YqNAwdAC+vCspH0WuYt6MPcfcwC+qUzS3OWVrDQnfLb7DqHZFDwmC21WUf7yhbT0KNyPWzYtBodIoEo1v58qthZT46A26GcYzuY/3BPZoftXXU7xuZtDI7Q8FqBmdllRYKZI+T59+WA/YUuUfASVypuib7bS/NpLTQTn22Yki8KcwyoYe/kThPIoOcz0NXM5TzicT9dDnBwigD73OLQD+/8MgRSZEy1cTUCi7W6Q9O6kMCHzq/A9oY+5fnAYNdtwBMx856AL/cv37stOvpn/GX5qb1IDboNF4jgm2W64CnQWRqcab/5ff19vHHSlhYvpctJj/VnCkVflDODDNXbU+WuK2/nXG2JdmSW+TQDKAgSFRznmO+PE7Kz6Kz3tgsM3hD6K9l8si6i0BtOkzWLfMYOmvrX2Vi2NCqARcjisuTIY45Y//EeNXl7aqsq0Wy9adw6Pm9uyBtr9dzm6Yrul/fX7lHOtx7WfFRsUc0gQaKNax9E6Iamb+HXHzhIh8LAOLz1WDGAK/6Ituzvk35oLbEHvTdTm6LmsZWUFRiwLCO1PhmbrZwhF2A5GzidP8ebuuC+ne0MCpCaWXDy1xnXKxaoxMWlWnGBlO5UM2uQUjNp+YuBZuX6Y5u/ASClhp9NikNcwItOAD5DS5FeZ9bJRz/DwSKyhTxRNKli9J8aDFjmxRn3gF4zqUHWSUVH+AwL6Ddk8RCIAqoul2L9/svkrCaa8T6lkb88X0HrvSVoVgnzVssoLZqNGsRALP+Uciq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(346002)(39860400002)(46966006)(36840700001)(40470700004)(36860700001)(4744005)(8936002)(81166007)(4326008)(53546011)(26005)(83380400001)(5660300002)(6506007)(6862004)(8676002)(70586007)(70206006)(82310400005)(36756003)(40480700001)(2616005)(107886003)(186003)(47076005)(6512007)(2906002)(54906003)(336012)(478600001)(86362001)(356005)(33656002)(40460700003)(316002)(6486002)(41300700001)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:07:19.0833 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4234b753-70d6-4269-0dc1-08da5e7ee8cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2150 Hi Julien, > On 29 Jun 2022, at 11:52, Julien Grall wrote: >=20 > Hi, >=20 > On 29/06/2022 11:46, Michal Orzel wrote: >> On 27.06.2022 15:15, Michal Orzel wrote: >>> This is just for the style and consistency reasons as the former is >>> being used more often than the latter. >>>=20 >>> Signed-off-by: Michal Orzel >> It looks like this change was forgotten when merging other patches from = the series. >=20 > I noticed the same and was going to commit it yesterday night. However, i= t is technically missing an ack/review for trace.c (this is maintained by G= eorge). >=20 > The change is small and likely not controversial. So I guess we could do = without George's review. That said, I would like to give him a chance to an= swer (I will commit it on Friday if there are no answer). Just a gentle ping on this. Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:21:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361096.590416 (Exim 4.92) (envelope-from ) id 1o8hYO-0006Dv-OI; Tue, 05 Jul 2022 12:21:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361096.590416; Tue, 05 Jul 2022 12:21:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hYO-0006Do-LH; Tue, 05 Jul 2022 12:21:20 +0000 Received: by outflank-mailman (input) for mailman id 361096; Tue, 05 Jul 2022 12:21:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hYN-0006Di-74 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:21:19 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f8768e8d-fc5c-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:21:18 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id d16so10979411wrv.10 for ; Tue, 05 Jul 2022 05:21:18 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id f2-20020a7bcd02000000b003a0499df21asm23593767wmj.25.2022.07.05.05.21.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 05:21:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f8768e8d-fc5c-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tPhfptPQ+gX4JT3/bdcuFrr3jLpw/OzsoZ0rq0knECo=; b=c7RW1YzHeXwf/jMD6hKO4ac6PtBxZevHvqEFxKZAEyrFE3UDM35GRArSoIVYrOo6a+ mHet7288DBwJFewo+jkPcjpqGFf6Yu2Aog2CmJuwa+vVQpEDDQKIaZzGZwkbFTiIWWkw TcqK+BEkLjJkdlKKq58IoUCj3IKXldoMbgja4QPTZiGBs4kzBHRs2YJKZp2eOhxafWVi PL+M0Lt6964owd2o3D3/sUH2ChuW4wNVRBFSkruadV8dcKwdogMXkW/rTjiCCF1E+8KN 7tKThLgQE1aCb4ceLoPoEQoqmBvkZ6103E4h8tLi2oMtGA/Kaai5HLWf3eJJ2KvXwFQ9 JCVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tPhfptPQ+gX4JT3/bdcuFrr3jLpw/OzsoZ0rq0knECo=; b=AqvnbGeEzvAr0WKK5s2j1WR7c4NOkjJ3FoGPCR6Sgf/IrcuPjBMnFKe7ocTdO9Cghj 7WzotoOfGvLo6wEmTTlMUIUeqXMr7HoHfZfLET15lWrLQQG3XOBO2ntydpM5+roVzAiI hzZXZKDS46e+wDSglZXkL7wQPRY1JvW0OCIhszbmBE/G2MBPfVIYT/4PPElfOGBx1ndP UK2j+sLKMeXEEEwPJxVq+0qyB0EYih93wtpxAaYBV3TUaRa7WEe/nViE9bcgCppGABKb 47KaAe1oGkkRRNXS3t0pp2LL8f49MiFYX3mtrJZ7n08Pts8uqaONAuWloAlh9oGzuHeG eyPg== X-Gm-Message-State: AJIora8BK7x/pgUjziwZvUSmjFQOtcwye84ok08+wuF0bgnAItNH+Mpt lfa2k+ezuU5p+K+HlGiBU5YrRw/YSlU= X-Google-Smtp-Source: AGRyM1vURze8NoGnLqDBdnnAAi5xOemowMS4E7esieCudqMDa3GdgI2GB6b/ddTHYC1ZzRPRcfVffA== X-Received: by 2002:a5d:60c2:0:b0:21d:6a52:3db9 with SMTP id x2-20020a5d60c2000000b0021d6a523db9mr9792684wrt.61.1657023677181; Tue, 05 Jul 2022 05:21:17 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Date: Tue, 5 Jul 2022 15:21:14 +0300 Message-Id: <20220705122114.419634-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the function prototype of show_stack() in header file so that it is visible before its definition in traps.c. Although show_stack() is referenced only in traps.c, it is declared with external linkage because, during development, it is often called also by other files for debugging purposes. Declaring it static would increase development effort. Add appropriate comment Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/processor.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 4188ec6bfb..c021160412 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[]; void panic_PAR(uint64_t par); void show_execution_state(const struct cpu_user_regs *regs); +/* Debugging functions are declared with external linkage to aid development. */ void show_registers(const struct cpu_user_regs *regs); +void show_stack(const struct cpu_user_regs *regs); //#define dump_execution_state() run_in_exception_handler(show_execution_state) #define dump_execution_state() WARN() -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361115.590431 (Exim 4.92) (envelope-from ) id 1o8hlH-0007yV-WC; Tue, 05 Jul 2022 12:34:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361115.590431; Tue, 05 Jul 2022 12:34:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hlH-0007yO-Si; Tue, 05 Jul 2022 12:34:39 +0000 Received: by outflank-mailman (input) for mailman id 361115; Tue, 05 Jul 2022 12:34:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hlG-0007wD-B2 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:34:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140042.outbound.protection.outlook.com [40.107.14.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d505a991-fc5e-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:34:37 +0200 (CEST) Received: from AS8PR04CA0109.eurprd04.prod.outlook.com (2603:10a6:20b:31e::24) by PA4PR08MB7596.eurprd08.prod.outlook.com (2603:10a6:102:272::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 12:34:35 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::a0) by AS8PR04CA0109.outlook.office365.com (2603:10a6:20b:31e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 12:34:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 12:34:34 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Tue, 05 Jul 2022 12:34:34 +0000 Received: from 14b5b9d96f5a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34B10BFA-18E5-470C-A151-8ED6FD7F360D.1; Tue, 05 Jul 2022 12:34:28 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 14b5b9d96f5a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 12:34:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3710.eurprd08.prod.outlook.com (2603:10a6:803:c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Tue, 5 Jul 2022 12:34:26 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 12:34:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d505a991-fc5e-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IVXsSH3+AViOK5FdxuDhS5Aqk217lPW9B7Qjgk4K5/r0S1tbQxO2mzqaMp4QFGMb/lVMko47S484Dan76mRJqWRyqogkXujvnP+LWuUPmDWeYNgQG/V+JQptXvX7Q7ehMwnPcYupU+rTQMDrl7dr2PgotRV5Z20tgH5VNTvGQ5EnDL0LxB0rOigeR0MQ5r+7Ebwgx13x7G4QaYNrecXIWgq0fQUjzD+SAOxrnnIz3sCRIAQvOTc3LHGh2GC9hh3aDa2Uf6ClzTiweuDKWWuYDdrVwDB0F4ZkjbkVSAORBxXya0z1/Llz8J1tm7TH+xQWhMAwUstI0qgVVzearipUGA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=EW9WaAx25etSEZdJiWed67ewgg5MnhaG83FhmeonEzDJv7I4Lu6e6MyUJoD8JV4Ip+CAY4TIKO7PoGxGnxKSAlxjMxt3VbQZGsIdfKvROhuM+U5nVnNdnrMThZF3NE44wl1E2rJnPb77m0OxIzDFUjtdzggb7fFOZiiqY3isFw3m1VjhxftXnNX/pAUPB2gmjvvxvZhCHp9kG8RiEXkyJnsw9YJupPRjYhXHf9MqxzGV3QUGvp5sNKTXhsf6iTWDUbsHiRQOwnSecmcPEIgGBrVgzhxbasby1p5bEjSL5L/SD73P5R2cHghBL4l4wBMBD5s2kWOywmwoZu8oh8/Xog== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=qv2k+aQM4tsh1maMfXcSviUC6LJEH/U8eWMx3g2jWTMDX/LXe/jDV/H18+DeemUb88kLz+fwHNUnVvb2x2IeMCJxtbam9ptJdDRovDq55MOs8+YEm84wWSE5liPsnqXZ3wHRH50/Blch1Gg2s1pOP1dfAvoYPkLwBFiDx2tpLV4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0f162e2246515229 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lVmWcMXM56XTlxayB4wX4OFlVbVIbGjvxH/AqGEQGBjbfhY80MB4NBDvomalSZFmSu2K0Gl62Qb8AFxKlbHTuz/UBYHX3q1I0F0tbM8iqaKIm+HYJb8uYu7XuYeDYA2RT29XHZQDzzS3xfx7JBskB3jLl3Tud/4gTSrnlY4Hb6zYRlx8Xsqj1/j1rYGfpQ21ie9xDFEsFwtSvJ+aRutJrvXUTfAorCDbphUZVXcF2z8L+L94TSCKkhsQ8lFOVvArgNHpXXshcRUQuzXMNyV6YGou+8U1RUMZ6A2gIeaOhXLY0neG5sVo74hw5HweMYiACtKhR1SMXWnOceOHtqcEfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=ZtPeVEEkGLUZNcN3P9Y/uRmTR7SC4/NERAAYa+oiWsy6aRveuuJcULb877VsTfxakSZXrE3s5R7NNaKRDMDs7NOYoP+MvFhERB5QfAHNV52Q49z4+B4Xk0Evklo+mCNWHaDpEx+P0IYzFVbvU34keBz1pXmZgNM+VY6sxTLun98YdcOIFo7T5pX4g6HEEvimCZatKh1bNXgCY1sBHoXHBDlddjS0HGPxh2cM9KYHmAHmcLgGp/tUXaKCXf3sXkuKMFq7OYGvS+4Vx/cL/kA2SUSJNq9S8reqeXZoER5vp29TtgHUebOL50WBjKRbTiT4CUK/Yr6hSO40RuxrmlNHdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HXyJhOCr6VrkrYsOXyERShNoJHw+wd2rE9vtb2Re0Vk=; b=qv2k+aQM4tsh1maMfXcSviUC6LJEH/U8eWMx3g2jWTMDX/LXe/jDV/H18+DeemUb88kLz+fwHNUnVvb2x2IeMCJxtbam9ptJdDRovDq55MOs8+YEm84wWSE5liPsnqXZ3wHRH50/Blch1Gg2s1pOP1dfAvoYPkLwBFiDx2tpLV4= From: Bertrand Marquis To: Xenia Ragiadakou CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Thread-Topic: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Thread-Index: AQHYkGnF2mJV3nmWm0mEL2tvTat45a1vtkuA Date: Tue, 5 Jul 2022 12:34:25 +0000 Message-ID: References: <20220705122114.419634-1-burzalodowa@gmail.com> In-Reply-To: <20220705122114.419634-1-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5d885490-f858-4aec-e660-08da5e82b7d2 x-ms-traffictypediagnostic: VI1PR08MB3710:EE_|AM5EUR03FT005:EE_|PA4PR08MB7596:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NpbqRVxQmxsWU2JHvbVv9Pxk2JU2qywU4JfnBKOzi5zSm5pLrtgWSRUp1D9TODFsHDqssSBwsRysO3fECyrE2HCxHbeOz1Er0OKB00QOQ+RdfIZcXWkJk1TSMOzO84D69gXVKhuyOBu1nTXjw5JjORvDOX7AxCMjJA0o2rbKJL/oBn7Y2i9loRQGo2CwNh9KDb/AQFKe6gZbagLkpN95oKlSXS+IDj+hAx1PUooKdGOglWcaCAJNizJcwnXuhXk9tWQ6onPNuD7zN/Ow5PMHpNAayK9J9dlbggDlwSrK2JSlA5U/faKM0jH5GSaLCsIla4onDLUhrcjCqZV4AIxQKf38gU+FjudvQ7jN4PAFEF48XpE4FunikcjgWjORUWpOLFETY4gVuhapDAt1Di7TWenTz36L6G/X1c7+4Hl9p8ebvPM5zELd97qUljGGAosRRRhB18Zh/xaMS/oK5o6Axx9kmqEx7ay9bjbsonJyaZyPVdwfa4zAGf3v6m+9tlPEwAcIPS2lKEsP60Br/HnS5j1WgoGNmB0cYd+5I7dDkdjRXK+Xt1JQTaIw69d3A5T1UugMP9biTtsxyvFv0QjjltqF5tUitA0J3FBmE3rrvveaRCtjBqmco1WD0k1OvEckg0rxYtN/PzlZDhZ9VsORBvOyRZ6hGXMKlUjSHvCVEYImMuKIEMeVoU4HQHHJIHG2+jwmjKgepfQH4OhSc3Zy768wSVkakNXsD4O6a6/46sVXyEdQivcf22to/b5eTGk8cwTx3kiHJT0F668KRjT8izoNQURsKpDpYwQyW9yb8grwzf9rqH0RPnzPYksVwJf95bFpt4RKwlBw/wHrMf4Vp1arCFuRqVx40vpFoTK16CY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(91956017)(4326008)(66446008)(66556008)(66476007)(76116006)(66946007)(64756008)(38100700002)(8676002)(38070700005)(186003)(316002)(2616005)(6486002)(71200400001)(122000001)(41300700001)(26005)(6506007)(478600001)(6512007)(53546011)(54906003)(6916009)(2906002)(33656002)(5660300002)(8936002)(86362001)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3710 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8ece35b1-fd2f-4267-ad91-08da5e82b256 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0MWibpBsNWUx402tFP6F4Q9TXks7N0nAS8gJgzWeTl/jk7F/8q/L4OIZWwWqzWqBN4mHLCH8z35pvYU5rCK/i95sJuBcgkMhcLppJUgvEKpv+Ym4pSLyt09ZxWk536HVJdQtpBKjPBEv3s8b8M0JY8U60kZ0xodBPA0P//nOMQMNtNEd78OYceSHmqoAUHQ59YeRd3D1tT+C/HTKKhMhB+yvPfl2A8g+U1BGK4e5Q5merdSmuWmmPdO9q0twIfVth46OCv8DCzOgLiKGLdumT4towg8+cRuQkvsPPv64a8nV7PIqwzCuIv/6NiMKVAHc6YYurm778bvCDWqzaQq+BKENs8AqAlAUysM6v/kGn8ZhIAzcO+E053y1FOjJPRVVljtAXPRkqcvdprymUjg8IMuhIlL+W8Je2i0dLu1sTOTICKHmuDYq51sLcn1uqoRxyH+20F6F70TFqS5PrN2sgqNYgWq1iMelmYtT55FGuHrtWzs6lXc7S28tyqHK+1mmhAA8j+LW145PKfVWStU3an0bAr/A6Pb0BEcl33Z+b5MftyI4ZsPba33SIzTwMaFjKwAFV+0PwsWeO9aGIAzd6vD+INmKMiBBG3rCzojMieblzhMvFxQRI7Mx8R5RcPMlI6lSUPSHD5MJBHHy9EvLPLr2FE2jYGKoCLqQJ27B1YybwZ4rDA2iKf6MQwLLir5txmYHsI5pyjMzRJvz1dYaOCC7j5kitojY/sBMbvi3uLm05zYCCuRfxw1hiCV7zExH1BQ8JosyxbjEji93K0VgMxAyDukJsvTFmrkeWrz7Os2r3qEuEA/vQtoE7YZYQ2hi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(346002)(39860400002)(136003)(36840700001)(46966006)(40470700004)(6512007)(2616005)(86362001)(5660300002)(6862004)(107886003)(8936002)(478600001)(53546011)(33656002)(41300700001)(82310400005)(26005)(2906002)(356005)(70206006)(6506007)(36756003)(83380400001)(81166007)(40480700001)(47076005)(336012)(82740400003)(186003)(40460700003)(36860700001)(54906003)(6486002)(70586007)(4326008)(316002)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:34:34.8509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d885490-f858-4aec-e660-08da5e82b7d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7596 Hi Xenia, > On 5 Jul 2022, at 13:21, Xenia Ragiadakou wrote: >=20 > Add the function prototype of show_stack() in header fi= le > so that it is visible before its definition in traps.c. >=20 > Although show_stack() is referenced only in traps.c, it is declared with > external linkage because, during development, it is often called also by > other files for debugging purposes. Declaring it static would increase > development effort. Add appropriate comment >=20 > Signed-off-by: Xenia Ragiadakou Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > xen/arch/arm/include/asm/processor.h | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/= asm/processor.h > index 4188ec6bfb..c021160412 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[]; > void panic_PAR(uint64_t par); >=20 > void show_execution_state(const struct cpu_user_regs *regs); > +/* Debugging functions are declared with external linkage to aid develop= ment. */ > void show_registers(const struct cpu_user_regs *regs); > +void show_stack(const struct cpu_user_regs *regs); > //#define dump_execution_state() run_in_exception_handler(show_execution_= state) > #define dump_execution_state() WARN() >=20 > --=20 > 2.34.1 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:41:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:41:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361124.590442 (Exim 4.92) (envelope-from ) id 1o8hsE-0001Ah-Of; Tue, 05 Jul 2022 12:41:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361124.590442; Tue, 05 Jul 2022 12:41:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hsE-0001Aa-Ki; Tue, 05 Jul 2022 12:41:50 +0000 Received: by outflank-mailman (input) for mailman id 361124; Tue, 05 Jul 2022 12:41:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hsC-0001AP-Op for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:41:48 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140058.outbound.protection.outlook.com [40.107.14.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4e23004-fc5f-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:41:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2613.eurprd04.prod.outlook.com (2603:10a6:4:37::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:41:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:41:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4e23004-fc5f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kW430Gk2YoxrYANo+bhtELxsYYWIpXOrauMdAocVVvCNtDNE/MsF46uUb5ojNafuxyrIOx/eXUjlUUeghziTt7Ex7rpbu1LHyWB8RWEW128T4+aXN6MkAIin8ml8GWs4E/XP1RwYzUMO3sHoWnp1NNOv3lwUbAqHBtfrlfYLx6X329vgmvcOvg/DOxd62eghOBreu8ECs1usy8/EMZOT5gzmRinB/boJFYPj4d6X4fkCSmk2/Er1//MCrkVKftEACFCYbtXiswSCutdJ27IRxw5DxnhDLsOAiDFoK2tm+lTBqAMhs+6jbxT3wih+7lq0Q+pJPPiOTY/VtrsE5z5YFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SZgNX/Ze/9TuUARcqgxwlervi79kuR7lK9LTAC8e/6E=; b=Dp0JpIWeH1ZrVIrw9tJdc6ttcsl26637yVXi6YlaLBJlSOfqQAtijCsdOlReaE7ZXnB2b0frXnatKgHB4J1wwQ3Br31i5eHinfCC7taIZAXz4zV67GZZ3s9Qvn5uZR4fETy2ZUhiXqVvNTj4xI0FdLk/p2dOsHDJV0WoL0d9fpBU58jb/Jj0QDdaDeQeOAQETJGVT2teOpcYA/cv95tuvTIXLxOdXZELWC4JygAOH+Y7y1oT5AUCwf1USPg2+39OVnZlmhQkbQxrr4NIXCQTUUCfIqmvarZd2zqdERFzkTDvRL5rcKWq4o6KKIZoLz+AJ+q8TI1lDQ1TVmZqeQ9KDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SZgNX/Ze/9TuUARcqgxwlervi79kuR7lK9LTAC8e/6E=; b=ta1faLds2kSrjJue/pDu+PZM3Mw/Qw7dlkq4sFhk4y+AV3YiHwlC28cHWP2ikfiC4/vUAX0p69yneuJtyzMYU9J6qEH/HakCXLf7DYeQT5ZN9HegtgwSs0pwrkYB3CnEKLKIBSAcIasH3xuuUJ0fJ47B1yd2zJRsXnoMxCc4t+TQyekjpbKtV4uh068Wkjuj83yPrdcx+rmUMOKJLriDWPs7kwK6NnQi4IaFxSHJgjyyWxMRsA22t/YECpn/oUmQw2eOGzT7rxGLT3UAMnnqF7+lgsDEL/aH0Lg6NhJ25JtzrAN1936YK9BbcosNv+8wv24/5II5etTibG23BpzY/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Date: Tue, 5 Jul 2022 14:41:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: [PATCH v7 00/14] IOMMU: superpage support when not sharing pagetables To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0187.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e2bb20e-a6bb-4ed4-d40d-08da5e83b7fb X-MS-TrafficTypeDiagnostic: DB6PR0401MB2613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 205ZuG3/hvh4fvlE1/539LlfFtBDgdk66Yu0fkeGQpqA91xlapAslboHDTQaybGLTOQ95He6s6G6Ai62B9jXXXzWZ6E1+O+WtzTt2iyh4EKnqFBWAJjtuuhUaqwwkXwy/Nd8ViHqutk4ljW/4okFw9s/yi/5/jrm9PYkgxSxVQb1eb5Pysrd9x7C6VWoiXYggTdtqrX98U77zM5nHCFnXcfW2Q3IFXcmguBvxu6EylPzA6IDWt8ejJ/CuU/rCTj/+5d7DvJdCM/IbO7tevOkOtJrLRGjrQQedBZv2sMOTFUbgub/d8R72MulVDekow7dek4k2NVpDyV4bFLMn9bXGaDs4+pT1y4kVq4jY3u7tIIz1ohxXvkgauTSFMr2QvV3DJvOERcl+5kG5VJ5t62xfFO0q1+Ug/KsPM3dgwFuG11nuWpaIvjEVv0xeUbfT61tp1SW2pumOCwJQ/wSiUDuy8zkkqY4o3KGFIOhbR+IQA/C+qA/J3yFri50FGdeyK+P0HFeiolaW1uxi7KLhPUJmXZe1NDGBpDYDbxZxbQsbnouf542qsbmdZsGFfZpVqHvEUIJCcbAWzhvKLSF0eBaNBYCOP7CWq+kYxIENVKP0VbugXRo0f0v8hDMqecNT52j4t4iL613gkIrMY2oDSqi0rSQXCPizjW2/Co0A0dP9i5Kyp9LQ+5C1UNe+xHsrjVDi+dOfnxc9VewSGEVXbWk24NQRbEXo0jtrJywsj1LPemVR2PWwu34OSq8zSGGaDk/uoWumnBP5IRKf4XIJWQmCt8OgowNhcyPriiIYF4ha1+AXeyOGi9Qs28cFFiJPKNoVXtNZ6T/AufS3oZQfRTxbDi8cH8ejXxGEpqlHVezF6TWZHYFD73LfJu0LjA1vYKU X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(31696002)(38100700002)(966005)(6486002)(478600001)(86362001)(66946007)(4326008)(6512007)(8676002)(66476007)(66556008)(5660300002)(2616005)(26005)(186003)(36756003)(316002)(6916009)(31686004)(54906003)(6506007)(41300700001)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bWZFRTZYN0lKL1c4N1NrbXhDNXh5Vk1rZzVmVnh2RmN4RnBvSUZxY0hYUWs4?= =?utf-8?B?eHQxNHBNSURJWGo5d3ZrOTdycDNINzFiOUpFcDgzUzdCdzhVZEo2NDJVZ0JW?= =?utf-8?B?QkRWSFEwVkxkTjJzSzNrbEFVRXVIQnlSMU1xYTFVVkhreHJMUGticDAxZ092?= =?utf-8?B?aktwRUNmeXZMWmtMM0oxWFBRdDdubHBGRWk1UVFFQ3FSdW9yUVl1TzFQMjM2?= =?utf-8?B?TVZzbzMwcWo0bzNQSnRXNEd4N3NhV2NQd2JtbFZZVnQzRzh4enBibUt1bkdv?= =?utf-8?B?enltaklKSDBsYTJGM3RXMEpPK01sSmxkZlBvZklKQ0xFU3ROY3VZWWZ1S2dW?= =?utf-8?B?TmpuYVpXTTJVU0ZYMDlHSjRhRVZ1ako2ME0vd0FmdVdsSmliM0tWZ01najVU?= =?utf-8?B?NmlDT3lXeWxJM0p4cGNTcGs0b09YY3JIQm1hdDdEREhUOXhPbm9DOVFTcEpP?= =?utf-8?B?bjF3OGxDZ3FFRXlUWVZKTXlUQ2dnaE1xM3JKUWU5Mm5LTnV3MDZGbnJxQUl1?= =?utf-8?B?cUJoSWdDNTZNTEE3RHlqMGdSUmlrWDcwcTU0SW9qeFNRRFpObEtnd0kvTEE0?= =?utf-8?B?Q1VOMGpDekhISjhEUGU5K0FRWHhQcmpScDVSelZVYmx1aVlCZ2NNUklCUUFq?= =?utf-8?B?UXZnUXhKVVJFZFp4V0hCb05KS3NBWFhBRUtPaFZNZGlpeDBRNlJkQXRBd0Nk?= =?utf-8?B?d1lHbWh4UUcyODZiZ1BzcDVDUFN2cHZyNmpqTFhUTjI4RlBZaVZpMG9aZytG?= =?utf-8?B?NlMxazFIRm4rR0wxUVdBQ0FiSjZLd0V6YXo5ZFdxRkxwWmFoRFQzWkRIRENO?= =?utf-8?B?THJPSTR0eEZYaTJTN21vZmF2aDhrM0F3d3ptNEVXaVNRSXdUeE9mNFYwWVBk?= =?utf-8?B?T05zejk2TWV2bERGYjRSQ0o3cmd3eTQrekVmVFRvcjRnOTRxOXA0UjR6bThp?= =?utf-8?B?b2hDcXN5eUZUYTlkOFEzaFpOMDUrSXVvU0p4dFk0VE5wUVBJMjJDbllyVEVF?= =?utf-8?B?QVlTT1hZWnFaeFpKU3hEMW9oOVA0YkE0Wm1XK3N5RSt3cDN2dlVzZjM1Ylpo?= =?utf-8?B?emhzTGlpNEpKYy91RWNubDcybjcwYVVEbEVsdk14dld3d0xGdTBFS21qd3FB?= =?utf-8?B?K1JkOVdPV3pYcW0vSTVYNVJBWVFXUEg5d3R0UjdIKzkzMUE3VTJhenBLNGJu?= =?utf-8?B?eGR1VTFWS1J5TVQreDVQVW1BUjYwOTJZM0VXaE5TMXBNVWIvVHJZTHVUSVUz?= =?utf-8?B?VnZKN1NhaU80elZxb0JveDNqSXZTR3pCUWk5MUV1c2M2ckxSU2RBMlVDZ0lq?= =?utf-8?B?cVRpdG9IdUsvQzl2K2hCK283ZXVOSzFmc1JMOEN2c1BwOFI4c2JoTVVGWVEz?= =?utf-8?B?aXkwcXA2dTNsbHozNkJsbzhuakdtMkhXQjMxZE9ZVTBWSTNON0ZxOFZIanpi?= =?utf-8?B?WUY3QjlpOEVSYWZNY2NSWTRqVDJvUS9nQVZDVXVrc2Y2ZWs0OU5uMnFRKzQv?= =?utf-8?B?MDFWdm1Ld3k0UWdOYW1MRnAzYjR1QndtcVF0d1JJQXEreVNwNkJLclZyTi9O?= =?utf-8?B?TFg1WmZ1aVlxeWVzaFQvTEtxaHZHdU13cWUyOHJTNjd1SHNZWXRJM3gvQXFP?= =?utf-8?B?ZmN2WmxDSDMwR2FZNGVDckdteWdCcG81d25wUFpIQVlVSi9GQm9MZ2dRVnZy?= =?utf-8?B?MnZyWS9MakgxUzI5SUNMQWhzTENUQlJ4SzhVZGxWenhmVVJOUmQrNkRVMUo1?= =?utf-8?B?ZWt3NkZPQlh6QS9ERUVuMlZ4OThuQzZMZGxaUUh2dWZicFNBZEZnQ2pNNFpr?= =?utf-8?B?VXZiNHV4TFZOYUI1TkZtTFc0b1RCQkt5b2MraWlPMk00S0w4blU1YjcrS2xn?= =?utf-8?B?UDZUL2t4bFNFb1NUQ0pXeWxsZGJLWk9Qa09KbkUyZytyYk01VTZpK0lMMXdq?= =?utf-8?B?U2xwRjZlci9waldvc3JRVFFla1hzMSs5aHJpMjJOM2I4V3loeDRKQy9Gd2NT?= =?utf-8?B?Q2N4Vmd0V2QxaE1McjhLWW9xZWhSTWNQeVlSbW1oZ05pZlZxWW9BSUFvb0FC?= =?utf-8?B?YnM1b2MzWEpPaThSOUM5SDV6b2krNFVmb1E3dlVhclhtSlE1M0NHT2dzd1R0?= =?utf-8?Q?EiXJ05kE+NmkgAYDxM3zcoOrb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e2bb20e-a6bb-4ed4-d40d-08da5e83b7fb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:41:44.8213 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: maVDqHorIcbulMuiCrEC/gbbZx0Sx8AX5BYpWqpf0IMKsf9KF0sLaf/xrxp27ryZntM0Tpkg69SqLtIZ/SXcDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2613 For a long time we've been rather inefficient with IOMMU page table management when not sharing page tables, i.e. in particular for PV (and further specifically also for PV Dom0) and AMD (where nowadays we never share page tables). While up to about 3.5 years ago AMD code had logic to un-shatter page mappings, that logic was ripped out for being buggy (XSA-275 plus follow-on). This series enables use of large pages in AMD and Intel (VT-d) code; Arm is presently not in need of any enabling as pagetables are always shared there. It also augments PV Dom0 creation with suitable explicit IOMMU mapping calls to facilitate use of large pages there. Depending on the amount of memory handed to Dom0 this improves booting time (latency until Dom0 actually starts) quite a bit; subsequent shattering of some of the large pages may of course consume some of the saved time. Known fallout has been spelled out here: https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html See individual patches for details on the v7 changes. 01: iommu: add preemption support to iommu_{un,}map() 02: IOMMU/x86: perform PV Dom0 mappings in batches 03: IOMMU/x86: support freeing of pagetables 02: IOMMU/x86: new command line option to suppress use of superpage mappings 03: AMD/IOMMU: allow use of superpage mappings 04: VT-d: allow use of superpage mappings 05: x86: introduce helper for recording degree of contiguity in page tables 06: IOMMU/x86: prefill newly allocate page tables 07: AMD/IOMMU: free all-empty page tables 08: VT-d: free all-empty page tables 09: AMD/IOMMU: replace all-contiguous page tables by superpage mappings 10: VT-d: replace all-contiguous page tables by superpage mappings 11: IOMMU/x86: add perf counters for page table splitting / coalescing 12: VT-d: fold dma_pte_clear_one() into its only caller While not directly related (except that making this mode work properly here was a fair part of the overall work), at this occasion I'd also like to renew my proposal to make "iommu=dom0-strict" the default going forward. It already is not only the default, but the only possible mode for PVH Dom0. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:43:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361131.590453 (Exim 4.92) (envelope-from ) id 1o8htl-0001na-8V; Tue, 05 Jul 2022 12:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361131.590453; Tue, 05 Jul 2022 12:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8htl-0001nT-5Q; Tue, 05 Jul 2022 12:43:25 +0000 Received: by outflank-mailman (input) for mailman id 361131; Tue, 05 Jul 2022 12:43:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8htk-0001nN-11 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:43:24 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2045.outbound.protection.outlook.com [40.107.104.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e0b6f54-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:43:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6065.eurprd04.prod.outlook.com (2603:10a6:208:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:43:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:43:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e0b6f54-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CENuYn1a5CC1/0q4tYgDbKb06/+uiip/Y6wq2RvaO2/k9cBa6wv5MX7NF4TebW01LZqLqpicjY1qGo9oBTPUs+hb5dMV5vCeVKVYgfuw81ZEQx5dbYdE8Q8UNrkiU8JynwvvtrpHrDSv/QzPHTEQuh8x6be6rPE3FDDZi3dEU/LKTgfhj21dnmlrI0R0yaFP/Oq8WbLGjgdkVWFG7+XfpZMnROC9x0CHO4euE9isac4JXsUbnafqXM1r1Te2rpA+p6qmDXssBJ7LM81Eg3xY57hMwOO5QYn8w6eN16/vACpQp1Fa1n885M5/tJd/+0F4K4vVhoNbOjZyqC+GoYXbZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2kE9tF4OKVANrzWwJZfuQmt3GkZdJOPqWNjkumzgidE=; b=d3o3+cS+3VPOBjMM1d7m/NxT8OYuKC3u9lPtmdqA6NIXD7WwIJFRt4HHBkrz5UopNrhp982exh57LL2dz10d+oheM3Y9P9XOywTfUadZu9s3D23ouhVkfp/+pjZhSxjf67QbcVlIVMv8LKoIwEJxVmPcHuGMaayn4/pz1cqwoNGHGDSOX377rGGg0dFeS7qjoclVMknaVT0JBYrrfnZGR5yIRuVCl1FZAxEsR7x957ga+iYO4e50hD7xI8JKdTDTlEyaFgnxsGmlpI7dq7zf46tHVflK3mrKx/4Z8Mc8XyOOyecRcxjBcfdHBIKQGO85NzOtdBT6lHSzztIGbTx4gQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2kE9tF4OKVANrzWwJZfuQmt3GkZdJOPqWNjkumzgidE=; b=rBDHCdjcB6JYTPGOa2yEaV2bDkVAEfjzQ2kFcJbCemD2hFTWDx1U4bGBPHLchpR0Ep/elR6oIf0MM1SrJIe2gBfQQ4ZK3Y8Py/cJbREy1JY0wHzuZoYXVUY03LizI42B4uZt0EV5EFIlvkCX/sW285Qp+Ki8rBB7ehrP2egR3aOn8a0wygY8kUd9BHdSug6EjVi/HEOujZiQxwrxaKSzGT4FGuVG/ZJz1KLJXH0kDMSEaqfXGoxA+UMwj03esoXi2Ci30mcHyRGxV7W+gYIfTFgv8Q0ApvR+5pmkEN/2VYkrvDLy4JW2I5viqveDrR8T4DUAQBAMkbSJuL5YWuC6zw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b3e1a15-f358-3095-87fc-c47843eff94a@suse.com> Date: Tue, 5 Jul 2022 14:43:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 01/14] iommu: add preemption support to iommu_{un,}map() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6880204-5e4c-49e7-7585-08da5e83f11b X-MS-TrafficTypeDiagnostic: AM0PR04MB6065:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HvIA4oCjHZlVzsisnh7zCVojYSJaehvDZLGu/30RYv3t5W6O7B5h1RyrmdDgZgBO8FSMQS2RaR+3g9OXIuthQ0BcLb0FIVE6ok7W7keI2yJUG+FOKEgwguIVpROEqpfneHgGDVto2vVmuLdcE+82AGor7d9AsSag9F76N9o4PCi2pvDUZ+mmRgOrzd37NStDjiPgQ6FFNAwTP7Zgm74Q/zHtEn7zyN4hGX6Br5/mQ/7fBH4CPsM2EPnVFSMMxVLujrFfHQhw7FgSvLCnUlvXP/3jiBQLXZ4V7vN8xPwkROMTN60DX+NPzc8u7knuqsFMPBZFPFIhvCtt/xXPlzVGeJKo7DcuqmhcAhvzRDtuJTHGmaaIAYz7aVTPkuX89RxsETK428p2bXPjXIbCq5D7rraWYYZ3vJiWF9rrTiiAwZ4GhDgXQOZrTJLb/J6kldPzSGA+ggv3I+oNx1QCDTDQa2EelyBn0QwnZL/kWzgQHye8WUfb44KKmSNmkjRDseBj9kvKCmXUxcJGdoQmD8dPMmcWbBpVi0GZjMHgWguFDKpLR0HHR3aKLsgGtiM+4L0AimnFqOwRuVOxIssTm5uNtEywxFX7k0JCDOrEEI4pmgUc9kNouk1b+wTGa537dL9cBQB4996jsSeceT5ogu4RrtzxrR772xJyLHBiCgJME7ILnJnCysL7vwi2hyzuHnLvYz45RtU2iU+5J/3tAbahD2Nh9wsYKoYJ9XiVlvk/raFJPSX9+r/6JajpQpWnFPWB0bf2SiSiGMlK4Q6NMNkqKgDVfXHUhQrrw0WemZExu32cM/XSDmOL1mmTcT8IbW/Vm4dBfcfQJMZwiALHnm3Irq3ubkhvnkU4v14neBfHfmA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(376002)(39860400002)(346002)(366004)(83380400001)(31686004)(6506007)(36756003)(6486002)(478600001)(26005)(186003)(2616005)(6512007)(41300700001)(2906002)(31696002)(86362001)(54906003)(6916009)(4326008)(316002)(38100700002)(66476007)(66556008)(66946007)(8676002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1FHLzlmQ0p4RFlrUTV1VWlOMGxpOXl5NHNKdDZ0Wk1GL3VjNXp3WEhIM0xs?= =?utf-8?B?TjZXaGsvZXZOS1FmK0RMcHh3Z0w2ZGd3WmRsQ0hOa1hIdlFvL0hhVHRoUEdN?= =?utf-8?B?K2JOdk5sdmJPZUhma0h1RVhoWG1qRGNBb29PU01PT0xJT0ZRRWFVNnhRTGhR?= =?utf-8?B?UHVKdG8zUndGdm5Db2lFcFpESUExdU1uYWRTNnFDWlBWUDNuaVJlOFR3ZkEy?= =?utf-8?B?U2RxWVBJb0tQa0RuN0xseW14aDBXZ0JKQ2xXUUtxajlXUXVXUWh4WXNhaGhq?= =?utf-8?B?MkpzUUlGVGFCVFlmWWxIeklpTnAwdGxocnV6U3BYYnJiaFNGZ1pIM2JoZzVE?= =?utf-8?B?UDVCTEJOYnNDUkVVQkRhYXlja090YVhGSFVRLzRFbUkvemRYM3UyQnU3bVpp?= =?utf-8?B?dEVxYktoRjF2VEdhUzNONm5oSGgyZWZqOS80NTNSVFg3U05BQXhad2lGNTJN?= =?utf-8?B?N3cwVDd2a0kydmZ0aXh0QXA3WU5NMk1vWnYvcXhmVmQ0eGhBZkVpM3dDNHNM?= =?utf-8?B?a0VUTFlpNVdJT1FlU2FlMHJlVFU0amcxcDgzalNVQmF6L0oxYVJCbjRXZEc2?= =?utf-8?B?VVZpakh0M045a0NBbmttOTd5am83bnp5b1JyRElEeitSTTVJNlBJckFUbkVT?= =?utf-8?B?c3FTWUtYNUhrdUkvVFhsenE2RDg5aUdGb2ZNVFpxN2Voc21IL0UraGVjc0lj?= =?utf-8?B?UGZIZHE1R2xrTUhBcFloL0p0Tk42T2FhcHY0ckJHY0I5RndYRHJtaEZldTFC?= =?utf-8?B?SG81UTBoVXg3WHJKQTVKbktUYjY4andQRjNIQmt6dlp6V1BlMFVMYTRMbjl2?= =?utf-8?B?N1grNURLL3NJZFFtQldzZ2VXdzV3a1V5NnNMMXRtRkQ5N1doaUwzYzBYdEJS?= =?utf-8?B?KzhiR1JXdGJsWnlUd3dYV25JZXRUb1NVVUJhMldKRm5HT2VJQWNvc0JmWjR0?= =?utf-8?B?cS9ubG5CTXU1TzMveFpIL2FSWjZpOEl4Z2xQQnRNNXdmWWd0cTFleFFGUFU1?= =?utf-8?B?N28yR05mZi83SmhDdzNnMHExTXlrVnI2Zk5kdWdQSmRMZ1hXQlZzaFk3Q2Z6?= =?utf-8?B?TDhDSi8rWWdOWUFCS0x0cThuczRCUllFdGx6L2dGdld6N01nNUhCcXRqM1FE?= =?utf-8?B?MUVxTDVaT2ZBanc1ZTgyb0txeFpiOUQyMkFHSUZIYVNpUnNxRHZRVTJIbFlo?= =?utf-8?B?R2YyK3IzR0t1WnpVcWVOVFJZaFpQbm5vT0pKcGxIekp3b3FzbkhsMlp2MUlj?= =?utf-8?B?VSswKzE3UWswWFY1WlV4ODhEcjNBRW9CeHF0M0VNWDJiMlNxY2V2LzUrNmhw?= =?utf-8?B?anIvMUdUVGpUNmxSNzdKaXBtMDBXNUdQakZVNmVqVjR0NmVGMEJ4N2JKSDJt?= =?utf-8?B?NkdqTE16dWJRbHNRdE5QTmhYb0RoRXhaaTQ5UWw5YzVTU25aMTdNQ0RyVmlU?= =?utf-8?B?aVRUaytZNGZsaHNwM3V1NjYwdU5hRWw1azQwUmhPTzRPVEViT3kzVnJnaitJ?= =?utf-8?B?bi9xSE8zSDV0aHJoYUtDdWM3ZjRseko3K05BRXV6UTlnUkFlQ0dHSzBYZ2Zh?= =?utf-8?B?cGFPZWZ6QkNmY2NqSExPWjZOOXp0KzB1cWRqN1N5cUdOSTJPR3liVk9TWURL?= =?utf-8?B?RWlrOGxZOEpyNVhPS1ZBZlZNMkVHV25vVXVlbkVCNzlpc2JTVkJNeXFKTFMv?= =?utf-8?B?b0dRWFVoT2Q5cjY0a3BhdFI4aWttY3ZQd3dGR1Z6N1ozcnBaZ29YdGxHWCt4?= =?utf-8?B?akFrSzlaNi83QTcvSHYzVlpicmFZSnlYTGt1NlRsZVlKcFN6M0huaGhJc1NI?= =?utf-8?B?NXRWLzN2bERCZU14bUJ2azk3K25JYjc4TlM2RTIwL1RFcTN1NjQrTzAzbEVW?= =?utf-8?B?V04zYzc3d3dOOUVMRHVwMVZXaWxsYlRiY1lLekFMaTlzNHUzNFNPalVHK05o?= =?utf-8?B?UEdXOWpmRXBqa204bHJsdlVaTzRLeWM1R2hVOTNtWGtKYVFiMWdib051dmJE?= =?utf-8?B?dWNHaVhMcHpaMTdnQmdNUDBVTXdKc1hUaVFqWjFJbFR4Q2FVSnpzOUNFWmk4?= =?utf-8?B?R2dPbkJRV3RpNlFyWStTUXN5azRJMHBMZmtsZm1uQzBrU3BJMkNyTjhsQ1JL?= =?utf-8?Q?2QaL110ZMU0RM4Zj6Nhrgt0yA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6880204-5e4c-49e7-7585-08da5e83f11b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:43:20.6744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2l5S1V2py9wA3Enx4OlAGjgscuxKtgyiWXGYKe8uOidRvXDKGWm0HF8LqEIKnbbAcFF0POEtq+gNXA1NmtU6gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6065 From: Roger Pau Monné The loop in iommu_{,un}map() can be arbitrary large, and as such it needs to handle preemption. Introduce a new flag that signals whether the function should do preemption checks, returning the number of pages that have been processed in case a need for preemption was actually found. Note that the cleanup done in iommu_map() can now be incomplete if preemption has happened, and hence callers would need to take care of unmapping the whole range (ie: ranges already mapped by previously preempted calls). So far none of the callers care about having those ranges unmapped, so error handling in arch_iommu_hwdom_init() can be kept as-is. Note that iommu_legacy_{un,}map() are left without preemption handling: callers of those interfaces aren't going to modified to pass bigger chunks, and hence the functions won't be modified as they are legacy and uses should be replaced with iommu_{un,}map() instead if preemption is required. Signed-off-by: Roger Pau Monné Signed-off-by: Jan Beulich --- v7: Integrate into series, with quite a few adjustments (beyond mere re- basing). --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -308,13 +308,13 @@ static unsigned int mapping_order(const return order; } -int iommu_map(struct domain *d, dfn_t dfn0, mfn_t mfn0, - unsigned long page_count, unsigned int flags, - unsigned int *flush_flags) +long iommu_map(struct domain *d, dfn_t dfn0, mfn_t mfn0, + unsigned long page_count, unsigned int flags, + unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; - unsigned int order; + unsigned int order, j = 0; int rc = 0; if ( !is_iommu_enabled(d) ) @@ -329,6 +329,11 @@ int iommu_map(struct domain *d, dfn_t df order = mapping_order(hd, dfn, mfn, page_count - i); + if ( (flags & IOMMUF_preempt) && + ((!(++j & 0xfff) && general_preempt_check()) || + i > LONG_MAX - (1UL << order)) ) + return i; + rc = iommu_call(hd->platform_ops, map_page, d, dfn, mfn, flags | IOMMUF_order(order), flush_flags); @@ -341,7 +346,7 @@ int iommu_map(struct domain *d, dfn_t df d->domain_id, dfn_x(dfn), mfn_x(mfn), rc); /* while statement to satisfy __must_check */ - while ( iommu_unmap(d, dfn0, i, flush_flags) ) + while ( iommu_unmap(d, dfn0, i, 0, flush_flags) ) break; if ( !is_hardware_domain(d) ) @@ -365,7 +370,10 @@ int iommu_legacy_map(struct domain *d, d unsigned long page_count, unsigned int flags) { unsigned int flush_flags = 0; - int rc = iommu_map(d, dfn, mfn, page_count, flags, &flush_flags); + int rc; + + ASSERT(!(flags & IOMMUF_preempt)); + rc = iommu_map(d, dfn, mfn, page_count, flags, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) rc = iommu_iotlb_flush(d, dfn, page_count, flush_flags); @@ -373,25 +381,33 @@ int iommu_legacy_map(struct domain *d, d return rc; } -int iommu_unmap(struct domain *d, dfn_t dfn0, unsigned long page_count, - unsigned int *flush_flags) +long iommu_unmap(struct domain *d, dfn_t dfn0, unsigned long page_count, + unsigned int flags, unsigned int *flush_flags) { const struct domain_iommu *hd = dom_iommu(d); unsigned long i; - unsigned int order; + unsigned int order, j = 0; int rc = 0; if ( !is_iommu_enabled(d) ) return 0; + ASSERT(!(flags & ~IOMMUF_preempt)); + for ( i = 0; i < page_count; i += 1UL << order ) { dfn_t dfn = dfn_add(dfn0, i); int err; order = mapping_order(hd, dfn, _mfn(0), page_count - i); + + if ( (flags & IOMMUF_preempt) && + ((!(++j & 0xfff) && general_preempt_check()) || + i > LONG_MAX - (1UL << order)) ) + return i; + err = iommu_call(hd->platform_ops, unmap_page, d, dfn, - order, flush_flags); + flags | IOMMUF_order(order), flush_flags); if ( likely(!err) ) continue; @@ -425,7 +441,7 @@ int iommu_unmap(struct domain *d, dfn_t int iommu_legacy_unmap(struct domain *d, dfn_t dfn, unsigned long page_count) { unsigned int flush_flags = 0; - int rc = iommu_unmap(d, dfn, page_count, &flush_flags); + int rc = iommu_unmap(d, dfn, page_count, 0, &flush_flags); if ( !this_cpu(iommu_dont_flush_iotlb) && !rc ) rc = iommu_iotlb_flush(d, dfn, page_count, flush_flags); --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -124,14 +124,15 @@ void arch_iommu_check_autotranslated_hwd void arch_iommu_hwdom_init(struct domain *d); /* - * The following flags are passed to map operations and passed by lookup - * operations. + * The following flags are passed to map (applicable ones also to unmap) + * operations, while some are passed back by lookup operations. */ #define IOMMUF_order(n) ((n) & 0x3f) #define _IOMMUF_readable 6 #define IOMMUF_readable (1u<<_IOMMUF_readable) #define _IOMMUF_writable 7 #define IOMMUF_writable (1u<<_IOMMUF_writable) +#define IOMMUF_preempt (1u << 8) /* * flush_flags: @@ -153,12 +154,18 @@ enum #define IOMMU_FLUSHF_modified (1u << _IOMMU_FLUSHF_modified) #define IOMMU_FLUSHF_all (1u << _IOMMU_FLUSHF_all) -int __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, - unsigned long page_count, unsigned int flags, - unsigned int *flush_flags); -int __must_check iommu_unmap(struct domain *d, dfn_t dfn, - unsigned long page_count, - unsigned int *flush_flags); +/* + * For both of these: Negative return values are error indicators. Zero + * indicates full successful completion of the request, while positive + * values indicate partial completion, which is possible only with + * IOMMUF_preempt passed in. + */ +long __must_check iommu_map(struct domain *d, dfn_t dfn, mfn_t mfn, + unsigned long page_count, unsigned int flags, + unsigned int *flush_flags); +long __must_check iommu_unmap(struct domain *d, dfn_t dfn, + unsigned long page_count, unsigned int flags, + unsigned int *flush_flags); int __must_check iommu_legacy_map(struct domain *d, dfn_t dfn, mfn_t mfn, unsigned long page_count, From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:44:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361136.590464 (Exim 4.92) (envelope-from ) id 1o8huQ-0002Ky-Iz; Tue, 05 Jul 2022 12:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361136.590464; Tue, 05 Jul 2022 12:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8huQ-0002Kr-FD; Tue, 05 Jul 2022 12:44:06 +0000 Received: by outflank-mailman (input) for mailman id 361136; Tue, 05 Jul 2022 12:44:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8huO-0002H7-Os for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:44:05 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26652464-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:44:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2613.eurprd04.prod.outlook.com (2603:10a6:4:37::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:44:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:44:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26652464-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DP0e7rZrhRCpGDdGkPUcMJm7//LFvtq00xoN67ERTD4+sm7HwqgrbJPnhJC1mzWleHdffkaZ4ukpWF200fzOBrSVBO5NCUdHQiwsGetu4ixQuqQOPNFO1DXbtS6MKrw6YX74e4iasejJfxL481ezOspmElto8KYAm9n2AzMBEgELn8ufGVjLYH2NAEl/ooge0cwq8nLoADzdiMZ3h5dr2QYVIpEufzUOrdgMXmLeTfAa0RDd92JsDgXcKEzEsgde265jS6EyEaZWozXlhpVpfof3px9dYkjWgU3T6t4g39fo4M1JqU3VtskSd8I/oEULai41z9kBW/P1GwYpLM4Epw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7AowG0vv4ZZNfRrLvkMOzyPPLjiwpxv5SlEjEedcSkM=; b=cwRHCCpn2g+GY22eSdl1KDoeWZlth3nwEn9lOSW1i8cacyeUtHt03FF19sfQXup/6IVbDFUDQY1pw4CPTJlGNkilBIScpfj/MgfugVszK8HK+Ad3Cs741Qbc02E4+e4kLUyYezgGXwzomB75QuxHTM0ajnwoPK+hIXlE8qyIKivdn+qo7q/bBDizcc7eg/qEXwL71BpTs45vOQdaUV/rYiK/XAKlKMtedjQ1OPV9vJiEprk3Hi8yi/a2uHW5IRTTPDarpjvIMFPT/+cNllIEN65rtvjgyr3hSMXxVjbUZVPGEd1jQDaMlIdfIjyKfNn6iHdT2C6/YxOEHhHWbmWa8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7AowG0vv4ZZNfRrLvkMOzyPPLjiwpxv5SlEjEedcSkM=; b=xPwpKA9I/3/V44DMvfkXIV1u+SX+PRqoxwidIKRqYdz55093yvSqcZ0X6jV2Gua2Rt/NvzPndNirqLHTzK25UqT2oLeNenPCK9zpunc5ZdA3t3yzVbbLJxyp3ltpyEJQWzHSjPuUSRyY1YnQe3aqOAbP4pRagtVxsGI26y3KMTYkvsWE8fUT/Z3Nvh1Rn1BlIPhSKP4JL4Q5CGwP9Ltbw+cCe7iEeP5+R+rA7Z0IMGrr1tRF+ZAFdijddQDU3ORbbGV+u33XS+lrTryQCztrbZQj+fq4cxCcv+VCR/9kbTzfXU3jiWNGNPyYDcFS51qFWclYDXpbPbqV6jqhCPXt+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1adca369-c911-e126-6b94-b26859a01e5f@suse.com> Date: Tue, 5 Jul 2022 14:44:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 02/14] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 546c4a98-d0a3-4d4c-fd25-08da5e8409a2 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fJzdYLGHY22wgJ3efnWaCWf0Uj3YR6IHvO6AY2nsugIXj1/cUBaQ94sw68P2LCUqvi2B9c3LQcfs5huFhoZ4AkY+59Z/bMexlan6WzUqfvymeTdStKM3vBCNisnTz2fkhiAjipSUSgeFXOM5+fUM7iImttQN6NYNheA2pfVNRBJgIs9p9O9VCzZ7UopTHPLl8uhYKdu+qNRxSPKyM1ZmAu9egcuR+X0S1MT8WwuhWvGjWBArtJcxna1sP9xOJdUwxfLhIusKS9f9v9HRTf6tjQ1LUJvp84ZUvMRlGI7ohnRrv/h4w9lMlyzX0orZUAcLcwk7Qy90h1kDkJYCZyKgn8x+MuLPvC/ciJ9TDDqNMwWUOyl4vyPokUSCdWkW7mvN2uDlGierYtZNr4vDqA4WaYgpzyWYooDOkjaxezs0LbJGyIHdW5ys3Lm2p90pw+ir15kzSXfa30XPzBFX356ZpOOKrXZRPjz3gOhDL0UcOJ0bGT+P0IA5YPR6v1qstDPZzB+TMl78uq7RzMGEV0pBdX+4iW+pRi63ArmkW6OATMEgNGbkSUISvkO7troBbbn3wXHi8Jy8nDpnAoMb1UImfxSNAxMdfkXoMDDAhPRcK2eA1GIfSvJWLN3XTb5Ds43yCOiNJLWaoM51a5tj3879WuvPmFFL12CLCzcRX1V2KvI2dkAl/ZhPH1MTqZnwT9VqBifsLz1IRkGRP3/3DkmgkeAPImF1YMbONuqjY2kJZ4gIIFCmI0VwVUqYRuydPtLZh3+4N98Jpy1lw8Y95UxZXEpqY2QYD3SDpumpZQGeKhKClNdftIRKZcxyYDYO6x1mZPzZg4GfX7/1a74bAudVeQ8NH4fkD//oKPWXvhXs5t0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(31696002)(38100700002)(6486002)(478600001)(86362001)(66946007)(4326008)(6512007)(8676002)(66476007)(30864003)(66556008)(5660300002)(2616005)(26005)(186003)(36756003)(316002)(6916009)(31686004)(54906003)(6506007)(41300700001)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VS9KSC90cVRPRllXZGxxS0xNTTh1Slp6Vm95MllJdi85ZFNSL21NWHRpU3B4?= =?utf-8?B?bjd4Sk8rb1V2L1F6YmlDWFNieXZkMk5rUnNCb2Y1NVB3dHRXT25xZDlGN25K?= =?utf-8?B?bkxUemZmblN4OHVZdEtIemdMZmNWMnZDdEljazZaSnVkaFFzaGdQY2hJWlI5?= =?utf-8?B?c0VyaGFHaHl6alBsTzI1VTRrVXRObG4wc1pHT0pxczcyVXNiRitiMFVhUkE3?= =?utf-8?B?Qjh4TFgrVjBBNTZJZ21DTExmNWJ4TjUyb1YxeEhsYlR4MVRMTGZHeVZGaGNT?= =?utf-8?B?Z3I3R0xTTkt2MTdXOG52MWNMN0RSK0JDKzBSNDdHdzJyOEw0dEkvSys0ZkI5?= =?utf-8?B?TTA0L1VJb0RsdXp2SmoxTEhLM2VheFRLZ3cwY0tCUitsa240amt5NnRpMDI3?= =?utf-8?B?dWRaTTJ4bklCb3JjYmpPd2FTeVRTNk40TzJtWG9QR2hhTzFNcUFLOG1UcDZV?= =?utf-8?B?NzhVMS9XemRBMzc2RFZMRE5MRGNzckJBSVoxbnVXTTlUaHFMNTlRbkMzTFJM?= =?utf-8?B?L2xpSUUwRmNoZFkxcEYzTjBjU2IrREdrQU1QWUtmVEw0TGVwV1FMeURVMlVh?= =?utf-8?B?cVhVb0s3NStWYjFydmJ0ZnBrVDlMVElYV2VvVU1IcXJhaEpHZEJGK3h2a1kr?= =?utf-8?B?S3FtbXkydVRTejMwR0VLTkxtZjVHd21USWtaUlZzS3l6Y2lpVnE5TXowT0JT?= =?utf-8?B?aU12cVpwd1VjVy9VVVdIc1VlMTQ4amYzZkdMalRLcWk4UHZiSkR1MTV1SkMw?= =?utf-8?B?TkdySkY0VFQ3djJnbFAybHljcW9ucEhKOFl6WldjMDNOS0NCWHlhcm9DOC85?= =?utf-8?B?cTVZS00vQ25SU280Q0JCcmF0bkZlcEFWYy9GbTlORzl4anJ1QXVWNENhajB2?= =?utf-8?B?Mk1YbWY3ejd1a3dnSUJYOCtMblVpUXNFdGJmTXkzbXR1bys2UlM4OW4rbkV5?= =?utf-8?B?U2FIZlJjYWMyMldqVTNNNGVEdWN6d1dYNldOTXJ5TFVyR3ppRGtCYWRCS0h6?= =?utf-8?B?eFBibGJVUElpcWVtWEwwQ3NpY1JSN0h5NGZ6YzJHK1MyOTg3K1FwWmVsYVpj?= =?utf-8?B?Z0xkVFlQdUZUeWpvOFlJdXA5czl1aCtKMzZJdXhRdDlWM1IwWEkxUUl5NFhU?= =?utf-8?B?b3FtQmhoN3dpR0pPbUs3MUd5cHVXaDF2OEIrZTFiWDJtU0dUM3JjTWhld3lG?= =?utf-8?B?aFFaMXJQaGZlclJtRFpsS00wRlN5Qi8rMW1JbVBkMElSRlFNRmNSWHhXWmk1?= =?utf-8?B?QlpsZ2ptaFozL1lJMU9kNkh6TzVYMncvbUtSWXpCRW1GZ2JrcUlGdFJlMEla?= =?utf-8?B?aE1nTmN3Y3BDbjdUNFdXdkpiWGxVT2xmRDl2MUtRSW44Zkd2VUNRdXlFMzVK?= =?utf-8?B?Tlp3WHdvL0V4V2hRM0FYOHNJTE44RVRtSEtmb1RGUkxrNk1xRlUvdVNyaFFz?= =?utf-8?B?cDhQdjk1eGlqaHdWVytDaEtGQThqUUh0OTZHSjdmdzYrZ3doMXJ3eE0zZXhi?= =?utf-8?B?akM5YVBpZDR0Z2tPQXB4Z0NndndULzJFRVdlU2JPRUxnaVNnODRObzlKSDJr?= =?utf-8?B?QnhVc0huTjM3VU9RTVpNZ29iSGVCSURqNm9oQUJPQXVXZnlmZGExR1JoMFpY?= =?utf-8?B?UFRBcWVGekJSdjB2Z0prQ2FkRW5JTW1QM21mNlErTStQcDhXeU1LVmwwMk9K?= =?utf-8?B?NHZ3emRjaExjNzQ2R3EyK3dBVk1vcytWSkhJZmp6MHV0UDI2UGhETTFUbXpj?= =?utf-8?B?KzVrTTdxRE9JbXpDaTg2dXBwbk1wem45QkxxMzZPTnYwS0czNzlZaE03Rzk1?= =?utf-8?B?OW5yUkpJOCtVRk1hMWwzWlZMZFV4NG43dHlzSVBoaHJZblI1R3JXcEJ3YlVm?= =?utf-8?B?ZWU2NWNMR2xqeksxdmI5NWM2SlM5L3ovbkdIUWV6U0FVdFVoN1BwaXFIa21F?= =?utf-8?B?bDRVeUhodk96ODNTSDQrTVFRRzYwcUN4QkNBNG9Oc2RreGZ1YzBOL2d6WGpa?= =?utf-8?B?eHZHdTZLWGdWQU9xcnA1V3lZQ1BXL3NPMzc0SU9kZndycVRob0NaOUprVUtH?= =?utf-8?B?S3kyb0xuVGpXQmRRMGZyVUdydHZ1VXFBS0ZieDc2aXJoRHpKbHZ4aXN0VmUr?= =?utf-8?Q?FmstIF5GipGjHA+s/Y0FG8J/o?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 546c4a98-d0a3-4d4c-fd25-08da5e8409a2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:44:01.7967 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Sdn3wX+chzf50tOWYiG8qt9PdG0wIbEkUfMg9YIjzyrExDYincqxARlo06dVzmyQWdc61CNVuBwxX3EKRZD3/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2613 For large page mappings to be easily usable (i.e. in particular without un-shattering of smaller page mappings) and for mapping operations to then also be more efficient, pass batches of Dom0 memory to iommu_map(). In dom0_construct_pv() and its helpers (covering strict mode) this additionally requires establishing the type of those pages (albeit with zero type references). The earlier establishing of PGT_writable_page | PGT_validated requires the existing places where this gets done (through get_page_and_type()) to be updated: For pages which actually have a mapping, the type refcount needs to be 1. There is actually a related bug that gets fixed here as a side effect: Typically the last L1 table would get marked as such only after get_page_and_type(..., PGT_writable_page). While this is fine as far as refcounting goes, the page did remain mapped in the IOMMU in this case (when "iommu=dom0-strict"). Signed-off-by: Jan Beulich --- Subsequently p2m_add_identity_entry() may want to also gain an order parameter, for arch_iommu_hwdom_init() to use. While this only affects non-RAM regions, systems typically have 2-16Mb of reserved space immediately below 4Gb, which hence could be mapped more efficiently. Eventually we may want to overhaul this logic to use a rangeset based approach instead, punching holes into originally uniformly large-page- mapped regions. Doing so right here would first and foremost be yet more of a change. The installing of zero-ref writable types has in fact shown (observed while putting together the change) that despite the intention by the XSA-288 changes (affecting DomU-s only) for Dom0 a number of sufficiently ordinary pages (at the very least initrd and P2M ones as well as pages that are part of the initial allocation but not part of the initial mapping) still have been starting out as PGT_none, meaning that they would have gained IOMMU mappings only the first time these pages would get mapped writably. Consequently an open question is whether iommu_memory_setup() should set the pages to PGT_writable_page independent of need_iommu_pt_sync(). I didn't think I need to address the bug mentioned in the description in a separate (prereq) patch, but if others disagree I could certainly break out that part (needing to first use iommu_legacy_unmap() then). Note that 4k P2M pages don't get (pre-)mapped in setup_pv_physmap(): They'll end up mapped via the later get_page_and_type(). As to the way these refs get installed: I've chosen to avoid the more expensive {get,put}_page_and_type(), favoring to put in place the intended type directly. I guess I could be convinced to avoid this bypassing of the actual logic; I merely think it's unnecessarily expensive. Note also that strictly speaking the iommu_iotlb_flush_all() here (as well as the pre-existing one in arch_iommu_hwdom_init()) shouldn't be needed: Actual hooking up (AMD) or enabling of translation (VT-d) occurs only afterwards anyway, so nothing can have made it into TLBs just yet. --- v7: Restore after the prior verson having been reverted. Use preemption when calling iommu_map(). Correct log message in arch_iommu_hwdom_init(). v3: Fold iommu_map() into (the now renamed) iommu_memory_setup(). Move iommu_unmap() into mark_pv_pt_pages_rdonly(). Adjust (split) log message in arch_iommu_hwdom_init(). --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -46,7 +46,8 @@ void __init dom0_update_physmap(bool com static __init void mark_pv_pt_pages_rdonly(struct domain *d, l4_pgentry_t *l4start, unsigned long vpt_start, - unsigned long nr_pt_pages) + unsigned long nr_pt_pages, + unsigned int *flush_flags) { unsigned long count; struct page_info *page; @@ -71,6 +72,14 @@ static __init void mark_pv_pt_pages_rdon ASSERT((page->u.inuse.type_info & PGT_type_mask) <= PGT_root_page_table); ASSERT(!(page->u.inuse.type_info & ~(PGT_type_mask | PGT_pae_xen_l2))); + /* + * Page table pages need to be removed from the IOMMU again in case + * iommu_memory_setup() ended up mapping them. + */ + if ( need_iommu_pt_sync(d) && + iommu_unmap(d, _dfn(mfn_x(page_to_mfn(page))), 1, 0, flush_flags) ) + BUG(); + /* Read-only mapping + PGC_allocated + page-table page. */ page->count_info = PGC_allocated | 3; page->u.inuse.type_info |= PGT_validated | 1; @@ -107,11 +116,56 @@ static __init void mark_pv_pt_pages_rdon unmap_domain_page(pl3e); } +static void __init iommu_memory_setup(struct domain *d, const char *what, + struct page_info *page, unsigned long nr, + unsigned int *flush_flags) +{ + long rc; + mfn_t mfn = page_to_mfn(page); + + if ( !need_iommu_pt_sync(d) ) + return; + + while ( (rc = iommu_map(d, _dfn(mfn_x(mfn)), mfn, nr, + IOMMUF_readable | IOMMUF_writable | IOMMUF_preempt, + flush_flags)) > 0 ) + { + mfn_add(mfn, rc); + nr -= rc; + /* See comment below. */ + for ( ; rc--; ++page ) + { + ASSERT(!page->u.inuse.type_info); + page->u.inuse.type_info = PGT_writable_page | PGT_validated; + } + process_pending_softirqs(); + } + if ( rc ) + { + printk(XENLOG_ERR + "pre-mapping %s MFN [%lx,%lx) into IOMMU failed: %ld\n", + what, mfn_x(mfn), mfn_x(mfn) + nr, rc); + return; + } + + /* + * For successfully established IOMMU mappings the type of the page(s) + * needs to match (for _get_page_type() to unmap upon type change). Set + * the page(s) to writable with no type ref. + */ + for ( ; nr--; ++page ) + { + ASSERT(!page->u.inuse.type_info); + page->u.inuse.type_info = PGT_writable_page | PGT_validated; + } +} + static __init void setup_pv_physmap(struct domain *d, unsigned long pgtbl_pfn, unsigned long v_start, unsigned long v_end, unsigned long vphysmap_start, unsigned long vphysmap_end, - unsigned long nr_pages) + unsigned long nr_pages, + unsigned int *flush_flags) { struct page_info *page = NULL; l4_pgentry_t *pl4e, *l4start = map_domain_page(_mfn(pgtbl_pfn)); @@ -177,6 +231,10 @@ static __init void setup_pv_physmap(stru L3_PAGETABLE_SHIFT - PAGE_SHIFT, MEMF_no_scrub)) != NULL ) { + iommu_memory_setup(d, "P2M 1G", page, + SUPERPAGE_PAGES * SUPERPAGE_PAGES, + flush_flags); + *pl3e = l3e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE); vphysmap_start += 1UL << L3_PAGETABLE_SHIFT; continue; @@ -203,6 +261,9 @@ static __init void setup_pv_physmap(stru L2_PAGETABLE_SHIFT - PAGE_SHIFT, MEMF_no_scrub)) != NULL ) { + iommu_memory_setup(d, "P2M 2M", page, SUPERPAGE_PAGES, + flush_flags); + *pl2e = l2e_from_page(page, L1_PROT|_PAGE_DIRTY|_PAGE_PSE); vphysmap_start += 1UL << L2_PAGETABLE_SHIFT; continue; @@ -311,6 +372,7 @@ int __init dom0_construct_pv(struct doma unsigned long initrd_pfn = -1, initrd_mfn = 0; unsigned long count; struct page_info *page = NULL; + unsigned int flush_flags = 0; start_info_t *si; struct vcpu *v = d->vcpu[0]; void *image_base = bootstrap_map(image); @@ -573,6 +635,9 @@ int __init dom0_construct_pv(struct doma BUG(); } initrd->mod_end = 0; + + iommu_memory_setup(d, "initrd", mfn_to_page(_mfn(initrd_mfn)), + PFN_UP(initrd_len), &flush_flags); } printk("PHYSICAL MEMORY ARRANGEMENT:\n" @@ -606,6 +671,13 @@ int __init dom0_construct_pv(struct doma process_pending_softirqs(); + /* + * Map the full range here and then punch holes for page tables + * alongside marking them as such in mark_pv_pt_pages_rdonly(). + */ + iommu_memory_setup(d, "init-alloc", mfn_to_page(_mfn(alloc_spfn)), + alloc_epfn - alloc_spfn, &flush_flags); + mpt_alloc = (vpt_start - v_start) + pfn_to_paddr(alloc_spfn); if ( vinitrd_start ) mpt_alloc -= PAGE_ALIGN(initrd_len); @@ -690,7 +762,8 @@ int __init dom0_construct_pv(struct doma l1tab++; page = mfn_to_page(_mfn(mfn)); - if ( !page->u.inuse.type_info && + if ( (!page->u.inuse.type_info || + page->u.inuse.type_info == (PGT_writable_page | PGT_validated)) && !get_page_and_type(page, d, PGT_writable_page) ) BUG(); } @@ -719,7 +792,7 @@ int __init dom0_construct_pv(struct doma } /* Pages that are part of page tables must be read only. */ - mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages); + mark_pv_pt_pages_rdonly(d, l4start, vpt_start, nr_pt_pages, &flush_flags); /* Mask all upcalls... */ for ( i = 0; i < XEN_LEGACY_MAX_VCPUS; i++ ) @@ -794,7 +867,7 @@ int __init dom0_construct_pv(struct doma { pfn = pagetable_get_pfn(v->arch.guest_table); setup_pv_physmap(d, pfn, v_start, v_end, vphysmap_start, vphysmap_end, - nr_pages); + nr_pages, &flush_flags); } /* Write the phys->machine and machine->phys table entries. */ @@ -825,7 +898,9 @@ int __init dom0_construct_pv(struct doma if ( get_gpfn_from_mfn(mfn) >= count ) { BUG_ON(compat); - if ( !page->u.inuse.type_info && + if ( (!page->u.inuse.type_info || + page->u.inuse.type_info == (PGT_writable_page | + PGT_validated)) && !get_page_and_type(page, d, PGT_writable_page) ) BUG(); @@ -841,8 +916,12 @@ int __init dom0_construct_pv(struct doma #endif while ( pfn < nr_pages ) { - if ( (page = alloc_chunk(d, nr_pages - domain_tot_pages(d))) == NULL ) + count = domain_tot_pages(d); + if ( (page = alloc_chunk(d, nr_pages - count)) == NULL ) panic("Not enough RAM for DOM0 reservation\n"); + + iommu_memory_setup(d, "chunk", page, domain_tot_pages(d) - count, + &flush_flags); while ( pfn < domain_tot_pages(d) ) { mfn = mfn_x(page_to_mfn(page)); @@ -857,6 +936,10 @@ int __init dom0_construct_pv(struct doma } } + /* Use while() to avoid compiler warning. */ + while ( iommu_iotlb_flush_all(d, flush_flags) ) + break; + if ( initrd_len != 0 ) { si->mod_start = vinitrd_start ?: initrd_pfn; --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -348,8 +348,8 @@ static unsigned int __hwdom_init hwdom_i void __hwdom_init arch_iommu_hwdom_init(struct domain *d) { - unsigned long i, top, max_pfn; - unsigned int flush_flags = 0; + unsigned long i, top, max_pfn, start, count; + unsigned int flush_flags = 0, start_perms = 0; BUG_ON(!is_hardware_domain(d)); @@ -380,31 +380,57 @@ void __hwdom_init arch_iommu_hwdom_init( * First Mb will get mapped in one go by pvh_populate_p2m(). Avoid * setting up potentially conflicting mappings here. */ - i = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; + start = paging_mode_translate(d) ? PFN_DOWN(MB(1)) : 0; - for ( ; i < top; i++ ) + for ( i = start, count = 0; i < top; ) { unsigned long pfn = pdx_to_pfn(i); unsigned int perms = hwdom_iommu_map(d, pfn, max_pfn); - int rc; if ( !perms ) - rc = 0; + /* nothing */; else if ( paging_mode_translate(d) ) + { + int rc; + rc = p2m_add_identity_entry(d, pfn, perms & IOMMUF_writable ? p2m_access_rw : p2m_access_r, 0); - else - rc = iommu_map(d, _dfn(pfn), _mfn(pfn), 1ul << PAGE_ORDER_4K, - perms, &flush_flags); + if ( rc ) + printk(XENLOG_WARNING + "%pd: identity mapping of %lx failed: %d\n", + d, pfn, rc); + } + else if ( pfn != start + count || perms != start_perms ) + { + long rc; - if ( rc ) - printk(XENLOG_WARNING "%pd: identity %smapping of %lx failed: %d\n", - d, !paging_mode_translate(d) ? "IOMMU " : "", pfn, rc); + commit: + while ( (rc = iommu_map(d, _dfn(start), _mfn(start), count, + start_perms | IOMMUF_preempt, + &flush_flags)) > 0 ) + { + start += rc; + count -= rc; + process_pending_softirqs(); + } + if ( rc ) + printk(XENLOG_WARNING + "%pd: IOMMU identity mapping of [%lx,%lx) failed: %ld\n", + d, start, start + count, rc); + start = pfn; + count = 1; + start_perms = perms; + } + else + ++count; - if (!(i & 0xfffff)) + if ( !(++i & 0xfffff) ) process_pending_softirqs(); + + if ( i == top && count ) + goto commit; } /* Use if to avoid compiler warning */ From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:44:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:44:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361139.590475 (Exim 4.92) (envelope-from ) id 1o8huq-0002s2-Vj; Tue, 05 Jul 2022 12:44:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361139.590475; Tue, 05 Jul 2022 12:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8huq-0002rt-St; Tue, 05 Jul 2022 12:44:32 +0000 Received: by outflank-mailman (input) for mailman id 361139; Tue, 05 Jul 2022 12:44:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8huo-0002H7-LV for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:44:30 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140058.outbound.protection.outlook.com [40.107.14.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35fa6309-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:44:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2613.eurprd04.prod.outlook.com (2603:10a6:4:37::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:44:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35fa6309-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kL8LBiaAEBvf7qLD6agVUNSxaTLmrvXLZaej+LJWW3qFbNMkgF9h36ISRbMYC4iif0KhHR6B8pESs39SbVa7du3+EAAgpA+devYBut8AfLQzhVmkh15NijePUi7dPLzYjs5EZApaGrlkb/J9x7Hf4SBL3WEmlIT1LyHv+HtTywPkI4AqPyKk19X0yy0v6HyIGYwVEXjw7NTW4F6KswyAreCIoaZoKgRUArupkdT/s91xqNm+9iHs+sM1wBT15NbIA+qjBVVJHMp6W+BaklMXc/Q0IclL8f9RRe9uubm1ZfI8cm/RBMe1CfNkNmH5uaJniPDM7Lnu/255Uk2ktI+LRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tz6ozk9S/AhujlkpGh0jwCZXiL+OVP402DUlNiNYn5k=; b=RtJiwQGL9MCjvyeyUHPnBI6SCug4Vvpc6W0yvPQWdG4oIjgjkzxLsFf22Lu7v517BFqAPi0I1LOy+EbazHfkX6YvsAzBudz8Em4MQZpHgaiA5kbr5I7cac4Di9R52jGy+6S3S/966rOvpRPHd4kPuH+xn0x7hcFJR2OL0QuQBpMoQECHAW37TMp62CGway32WsRIvO9d8+ThX3goe7cS4t/xJjz0jTfnd6sibhKopAPjWmdAs/DTJsRNUg5oM3jY2qiSbFJvDZ9zzvp1pBmNRwSAmWlApBAYGwUuqmZ6b87enQeBlw5TC07BZiXo0tQifS9KPVGkv71qKa0VvUXS3A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tz6ozk9S/AhujlkpGh0jwCZXiL+OVP402DUlNiNYn5k=; b=FeIksqwS0FJlZsZx6jYdT7bMGr/qfRUWBYrjmngzaUI5d9Sx3McvBbVqh/wF2Km1imrisK8fCKYcIQrOGXOajUzJ+wk6JTtF/W841tbeQud+R2TYpeDhSgSoEHGdGowl1YQNYEFPFmePQ5sBxsBKR+YLqSRIaxGUBnv9vIAORCzYpExK9Ewzz/y7hUdaG7yZyP0wSFp8JTnbobImr8p3qV71uCn2wea924xGVltovkM9SNmNmUvFwIcCt5kBqwl/7P5WXfneD2h8Q+L8H3hFXO9z2OQkkK0ncAuKqQKCrIdVdkHY78bhCNN+nZ6pl3wx4p1vQGSq2jkmcXP9kkvC4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 14:44:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 03/14] IOMMU/x86: support freeing of pagetables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR07CA0058.eurprd07.prod.outlook.com (2603:10a6:20b:459::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 45afa46d-ca31-40b4-164e-08da5e841954 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YBgGshiM5C7vrHVxGj9SyG2zYY46XA2p++bdqO5mwSmRLOgTJUOhm3BVCxOv2O+45ezR/2kNGwkQuWyp40Z3LogBx3JdS8MxkRWL+FHRS6BxIdcMxZKnBwkq7jVW7hctPKh43dCmkF1vDymp/p93pRXZpZBXJQ4rMRXBiheM4IWiT2ZqVxEh4VkmVFXB58ywAAXioFt+xM5c88YRT/i9dpiyDaqu3e7jxOyF3rJ+KkNOBtnGd+nka15V/BQ+E8xu41gsQBqvWiTcouWwbiryXVCA93fWelaMVENUOA27y8rESqCg9QurSD5gcgIOQchT+6rAZJ7xv7HnhOSSGXJ11w+ryIzfoy7fUAgs/ejXHxUG6nxqkS8eQ7W9GmNznmTSVmHFcnPpnRLAAdPPaclqHeaP7duv51KzS+IKg7wKUJppd4p9GbhII8w76LMjvBmZ9aPP0GGU0q9el44jwfHH9A0yjOu5TaOLdGb5guUJbj1ZTlm3YytSzEqNj5l6/tCTdUndHMPc5B8kIJBnQHFnNMyXPTRPEd+ljDWIsppx0FlXwh/DpXc5FLO5O4fOKdwfMQ3rYTo+lsN0eeHRQiARbErZ/4xI67i/lierYdOGRC67tyaGWZiEs6OM0rE0qRpqwrA/lWaLsyIILw/a6+0KThwQGFsX1wfvxDGPu2Cqv0F3tYtf2exNHGlkdgUM1ilq/9CxZ/K8khbcV3rtpfuKmpH/yCriJk8osif/YW6YPHPbscNtFPIN/lXfIFOu54htv/ATwWMm4a69CVddt5JPQVr7weyRks302g01fdhvbsMaBdyjsJXDFfgl38MrzueiQ+jjcPB3MU+lH/uIBfF/rdpZXyAj7ych1mMFauHPwrEDTSGNWaPFnoWTpp5HsLnp X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(31696002)(38100700002)(6486002)(478600001)(86362001)(66946007)(4326008)(6512007)(8676002)(66476007)(66556008)(5660300002)(2616005)(26005)(186003)(36756003)(316002)(6916009)(31686004)(54906003)(6506007)(41300700001)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEd6aWpZZkpMR0hLQ21oRWx2R3RwOVRmL1RHYkhNMGZ0M01mR0JTaDlOTE9y?= =?utf-8?B?Z1BkaHdiZUpKbldhRmdIRFU2dTVpLzRYS0tBbk10RkxNVXZ6UzlBVmxwU2JT?= =?utf-8?B?cmRRR3M5bGZiaGtUNjkzTXdtc2w1L3lGcWJZR1FMQ1lnM3JYSzZjUUIwenBw?= =?utf-8?B?SWRtUWQza21qajNmWXJhTGV3MFVlQnZKUlRXTTgyT3hEdm85aUcxbTArQjBj?= =?utf-8?B?UlFDMlA2dXJiL2ErMGNYeWdjSkFicWFHRE1IT0t5SGR3VjdQZzF6emhScFVB?= =?utf-8?B?aVVEY3pzbStaQXhWSTRSZDhxVzUra2hleVFqMEdxQjIvdytLWGhueVc3cTFN?= =?utf-8?B?WlY2R01CSndDSlE4TzAvTlk2UnpkQ0xaeGRzTWM1ZHdCclJRRFpOU1pCQ0Jq?= =?utf-8?B?MjB3bSt0NHVDV21tc2RIbzZaeURLVEJ5akszMHV2ME9JeWtXUncwdml1M29F?= =?utf-8?B?aFlkQWJxQ2swVjJuWldqQ3FrTW9BeUxNYk0vTjdOZEVFdjBuZlVoR3JhME1a?= =?utf-8?B?SlRvL2EvTjNYbFpHL0VIeUM5QTBFemh6VnJVTXFSVjlyVWovaXAyaERxcWNt?= =?utf-8?B?blBCQWxvMWxpUllSSmVlZWxtOWVnaitpMEJ1ZS81Q1Z2a0RieFpLZGQvMGJS?= =?utf-8?B?ZTFjb3IyUWcxZmU4NGd6eEtHay9hVDlwRmhoSXdSM2dwbEtJdWNwWWZLV005?= =?utf-8?B?a2NYSjBPejFNTDhRSHp4N3JMYnNkRkxmNXA2VkN5cHQ5NzdmelFtbWJWdHRD?= =?utf-8?B?UWlPcXR4TUVVa3ltaTJLUkN0Nm9CelZzdFhXS0FRcDlhNnU2cGVoQ0dWN0Mv?= =?utf-8?B?akkwbzI1emtKWStRbUhaTFptenBuVGp6Q25TcU1jZGswUGpFZk5vVTIyYlNx?= =?utf-8?B?QnduT0o2SXAxWlB4Ym1XZ1Rka3lKTVc4QzVpcTRYek9jT0FIaEtKQ0hCR2VD?= =?utf-8?B?OFVMNnJhS1VmdVR3cEZDeFQ2aFB2dnNYSzlUS1FOamRXNDBPVnlPR1NFaEFP?= =?utf-8?B?MXpnakdGVGxxNDY1aWYvZ1BOdWhmc1RMTUtqbjUyeTdkdXlwdFZ1R2ExWlZi?= =?utf-8?B?RDJVbGxwYS9mMk84WmtpWDRoTXlGZThSdUppTUxMRlFWQUhLK3dXQjhLQTQw?= =?utf-8?B?VmVOZ0ZPY2UvaUZsV1NPMm9SamM5czBJaXNpbmZ2TGZpZHRqUkpTNjd3d2ln?= =?utf-8?B?QXlJeUZOelFHejNaY1lpeFhvTmpFVmtJWHdzYWhjRW9HTUQ2cXVPd1daWFRW?= =?utf-8?B?YXlhckV3VTdtT3llVUhKbDRIRGc0c3pTdVoxQ1dnd2w2ZFZDM05DSW1CU1Jr?= =?utf-8?B?dXJGMTZJdzhHY3lOV0piaHM1akhTUFZGamtxSkxOZ2duR2Z2NXluTFlGTjVF?= =?utf-8?B?bE9tS1RpclROYjZOSTlDSktydW1va2tyRlp0U3VaY3E3N2ttaVVGUDRxb29J?= =?utf-8?B?L3YxT0c1YW9EaTlLSnlzTWVEOERlZnlkVWFJbmxzL0JZUXlVd2xPbDhYdG9v?= =?utf-8?B?UHl0K2ljaXdzMmwyeTJIS0I3RlVIU296VlpRY1dqb3BQOGNUVXJoTjlKYUJT?= =?utf-8?B?UFB5cW84bll6ZnhObVdNeE83OHVxR0lkU3NlZGhaSC8vYWk3OGhpbjJzWVBB?= =?utf-8?B?Mkk4endhak1LZGhmYlNOOGxjT3VpOHd1c2ZPWUhyQjNyeTJvQ1gvWXNDZXA2?= =?utf-8?B?UWw2ampCb3ZjNkJOQXdta0dwU1Jpcmk4UTJWNXB3TWxTQmxWMXd5Q1JYekMr?= =?utf-8?B?aFM4TTRCcWhzajFBWkRsbnZkSGxGbEQ5clpMc1VpVkdqMStMVVdzVm5JQ1NB?= =?utf-8?B?OWozSTZyQ0JicHZQNEZiK2Flb3F0a3NuUDJwbG84eFRsRVRlYmpLTHkzVS9Q?= =?utf-8?B?ajhJNzZQamJ2ZUZkTmN4NHNLaUFCY1ZMbmFtNzM4MHJDV1NKcFYvamZ5ZkRB?= =?utf-8?B?alpNenZtNzc1UldYc1hmYnFmYjR4ZXZXRkhTVGdCRTVIaWdVdTd1MDdQSXBp?= =?utf-8?B?cjY3WXQ0RFd0aWdGM2JEQXdESTExRnk3Q0JQSUdRTnB5YnBhbDZXSnk3NTh1?= =?utf-8?B?MTVSalB4cmVrbEgramVQTE0zLzRMOFRCb2dKUzFVRHlwNWl5Wm95ZGgvbTVH?= =?utf-8?Q?CLE9jaeTHOQZYm/6HK0Aeov2q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 45afa46d-ca31-40b4-164e-08da5e841954 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:44:28.1387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: yED7xdMjgOAjActLXaU6gROgDvYZs4R4SKA/m5jVvFlV8sD5B1WBxM5n1mcrSqNA0MwgyoY22v+OvtKweJ7W6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2613 For vendor specific code to support superpages we need to be able to deal with a superpage mapping replacing an intermediate page table (or hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is needed to free individual page tables while a domain is still alive. Since the freeing needs to be deferred until after a suitable IOTLB flush was performed, released page tables get queued for processing by a tasklet. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- I was considering whether to use a softirq-tasklet instead. This would have the benefit of avoiding extra scheduling operations, but come with the risk of the freeing happening prematurely because of a process_pending_softirqs() somewhere. --- v7: Add cf_check to free_queued_pgtables(). Add ASSERT(). v6: Extend comment on the use of process_pending_softirqs(). v5: Fix CPU_UP_PREPARE for BIGMEM. Schedule tasklet in CPU_DOWN_FAILED when list is not empty. Skip all processing in CPU_DEAD when list is empty. v4: Change type of iommu_queue_free_pgtable()'s 1st parameter. Re-base. v3: Call process_pending_softirqs() from free_queued_pgtables(). --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -147,6 +147,7 @@ void iommu_free_domid(domid_t domid, uns int __must_check iommu_free_pgtables(struct domain *d); struct domain_iommu; struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); #endif /* !__ARCH_X86_IOMMU_H__ */ /* --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -12,6 +12,7 @@ * this program; If not, see . */ +#include #include #include #include @@ -556,6 +557,105 @@ struct page_info *iommu_alloc_pgtable(st return pg; } +/* + * Intermediate page tables which get replaced by large pages may only be + * freed after a suitable IOTLB flush. Hence such pages get queued on a + * per-CPU list, with a per-CPU tasklet processing the list on the assumption + * that the necessary IOTLB flush will have occurred by the time tasklets get + * to run. (List and tasklet being per-CPU has the benefit of accesses not + * requiring any locking.) + */ +static DEFINE_PER_CPU(struct page_list_head, free_pgt_list); +static DEFINE_PER_CPU(struct tasklet, free_pgt_tasklet); + +static void cf_check free_queued_pgtables(void *arg) +{ + struct page_list_head *list = arg; + struct page_info *pg; + unsigned int done = 0; + + ASSERT(list == &this_cpu(free_pgt_list)); + + while ( (pg = page_list_remove_head(list)) ) + { + free_domheap_page(pg); + + /* + * Just to be on the safe side, check for processing softirqs every + * once in a while. Generally it is expected that parties queuing + * pages for freeing will find a need for preemption before too many + * pages can be queued. Granularity of checking is somewhat arbitrary. + */ + if ( !(++done & 0x1ff) ) + process_pending_softirqs(); + } +} + +void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg) +{ + unsigned int cpu = smp_processor_id(); + + spin_lock(&hd->arch.pgtables.lock); + page_list_del(pg, &hd->arch.pgtables.list); + spin_unlock(&hd->arch.pgtables.lock); + + page_list_add_tail(pg, &per_cpu(free_pgt_list, cpu)); + + tasklet_schedule(&per_cpu(free_pgt_tasklet, cpu)); +} + +static int cf_check cpu_callback( + struct notifier_block *nfb, unsigned long action, void *hcpu) +{ + unsigned int cpu = (unsigned long)hcpu; + struct page_list_head *list = &per_cpu(free_pgt_list, cpu); + struct tasklet *tasklet = &per_cpu(free_pgt_tasklet, cpu); + + switch ( action ) + { + case CPU_DOWN_PREPARE: + tasklet_kill(tasklet); + break; + + case CPU_DEAD: + if ( !page_list_empty(list) ) + { + page_list_splice(list, &this_cpu(free_pgt_list)); + INIT_PAGE_LIST_HEAD(list); + tasklet_schedule(&this_cpu(free_pgt_tasklet)); + } + break; + + case CPU_UP_PREPARE: + INIT_PAGE_LIST_HEAD(list); + fallthrough; + case CPU_DOWN_FAILED: + tasklet_init(tasklet, free_queued_pgtables, list); + if ( !page_list_empty(list) ) + tasklet_schedule(tasklet); + break; + } + + return NOTIFY_DONE; +} + +static struct notifier_block cpu_nfb = { + .notifier_call = cpu_callback, +}; + +static int __init cf_check bsp_init(void) +{ + if ( iommu_enabled ) + { + cpu_callback(&cpu_nfb, CPU_UP_PREPARE, + (void *)(unsigned long)smp_processor_id()); + register_cpu_notifier(&cpu_nfb); + } + + return 0; +} +presmp_initcall(bsp_init); + bool arch_iommu_use_permitted(const struct domain *d) { /* From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:45:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:45:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361147.590486 (Exim 4.92) (envelope-from ) id 1o8hvO-0003VE-9o; Tue, 05 Jul 2022 12:45:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361147.590486; Tue, 05 Jul 2022 12:45:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hvO-0003V7-6I; Tue, 05 Jul 2022 12:45:06 +0000 Received: by outflank-mailman (input) for mailman id 361147; Tue, 05 Jul 2022 12:45:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hvN-0002rI-4N for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:45:05 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4a6feb3c-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:45:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2613.eurprd04.prod.outlook.com (2603:10a6:4:37::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:45:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:45:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a6feb3c-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bVAY5ZcpXdbPPEtp+phcfYumjdSpjlHqfCbjXyTvpgAsmlujic20tdYE6YIp1prwAR1YWz+RRZp+GMJVJ5MFAtWPci3/B3cLisLz663yvKiZ4Q5aCSVeScAY4xCRkSJ54cBtHY2KmkMsOoz4x/HaIVGR1u6vp+OLjfraWTqK+kzcUqde/q/+snn7FHsYqGmvFg91u8YTeskDPRuZOnPacDC9Y9lr9aK0ah+LPODjl6Km8SALdehy8SpLlSOByqO0YoNU6JAGEEFUZV5UpnGHYug8qxSQtuR3Zaa2+04GPTb0ak3zzQR39AOUzfcWg7g0ThD+/yOqjcUg+N8/6DfuJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z+8FHLsqYkAJd4jPM1gdjv6XWwzyRFyA3mYZWklG6gc=; b=enkUyvtvFsiD+1XepDyQncEmDiuk8lnJH68rKcrIoiRPhVi6IhsYjN8lzGkyzp7uDVzxdDp4iHaK/f4IqvYgjp26q+OUlg5IVYL7FSsbZmgdTON93qFNx+2T5I2GqU4eSjE4+DELRKfzBIzgaDHABODAiv4PNnWMqm7DY8hHdWk10QZlql4cR4FwO1l4LuUPGf4GsLX6uDal9QqDS6m7PfrIWNupCVeGhIbCNvPNipnmcrLT19oS9RC1nscUvz1TLJkqcr7zg5sOtK3XKMOlQxOmEUGKWpavKiGby+mvTUrk2D0RySMmyK7d8Hw/IxA47Zxpgzfk8VSsx/Qn5cOLVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z+8FHLsqYkAJd4jPM1gdjv6XWwzyRFyA3mYZWklG6gc=; b=dCn1XpUHKLEvS5irwb7E1cgU0K0fzfZoLm+3GhuxmjmnJQnDLp1Ifc5pXCUgH/v77MgKlt20hA7yjRUioXd2d76FytV4ZX2ZkrxWGNkkLwDP+dVYnn6eu4jspxTzKgZbkZ4svTb3k1J4r+KhoILC3KMsuXs5PIxsvxDXpFEiu8v+Bm1Q07Fgy5Nm75ExJ//xoK8V5Szd9tLPP184JlcS83L/6AoOhj4OF8szMmJB3OeXXytTRfgDOcxOsn3JAbyqVViwVxgUgUfwo7q+I8hD5MTaVOQDwN3uyg4iP2+0G2ZLU1aHI6Jjmjv/24x/1TTzVmBpMuzvSQbXRfIGZw9Tvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7e587d78-43bf-70e5-b629-b7fbed0ae0fc@suse.com> Date: Tue, 5 Jul 2022 14:45:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 04/14] IOMMU/x86: new command line option to suppress use of superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P192CA0041.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ad5b290-cfbf-4ce1-fc55-08da5e842e0e X-MS-TrafficTypeDiagnostic: DB6PR0401MB2613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5f7ttoFzyfMxf2hmb+Za23zGEMHXbcIhET+33YWrCKU2DnS0UCyIndaqaMmmhhXL2K+fFGKBk3qJ8Em+oalMW/rVmR5+RwHi4c1PvVKZT96lkTxmZzsq9i7o6fFhQyxcNvuB7ZNO0tDiVVFxS/kT8W8njh9A5OUVM1gTDMTc7il5LAWNZiBd31v8dXs6cdeyCeAWhib1PY3BoqVer8sCKfbyR6Lq2iNDCgdp5yYWS3hxZX4mW/ump9JpVjSQ2t/F8W6TvKzGDQpV3sox8rBXbDf0JscjNEEOj73X1ZsjKSEnUGrpiAdUK8RR4fXFK/pUgxcX6YzR0u27oNQ81S3bQczzYGZwTpyWHP2LBdfTMMhOP1sbpi2UH5jODW1F2pP34LYHc/fK/5C7ScywXueRiGeyq+bc20lsLAG1ofS33pdqTKBz461k6WMielQVN1Ct37UjMgSykjW8Ll09cl/WlhN6tYSEbUzaXvqs8hz77jdPi0/rdQavArT1mrx6Me9vj2t+z76fH2sH7gwbAXyBiV9exXpTu5kCUXiKgfnwW9/EqDkT9qk/SmqgAM9fFYROpu3I8/COFJg5J/OhnTay11WLxqPB1CFTwJANv2mTNQ5ZP1RON5Vl9JFqDAq4Rt6ZtymeEP4H97Ti4m+D93W0KGy5r8b6HUVqIrGafnJEGtjTwd9/AodptQhHiCHzBTbPkrW69RkqThWSbZsZpbt7duByv6J0eMXnhOj0XeBkR1Mo6/dt+36K6OXs0vUmPNpdPv7pxZfuqgWBxdsPV7zfhrRG0ODRABrz+iWBT0SqC52gjs3WXfLDVeh86bBdJqyfN1dbBMYqYgDXnMqQF4o8JJJDZiu/SQQ0Jn24uVW4lac= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(31696002)(38100700002)(6486002)(478600001)(86362001)(66946007)(4326008)(6512007)(8676002)(66476007)(66556008)(5660300002)(2616005)(26005)(186003)(36756003)(316002)(6916009)(31686004)(54906003)(6506007)(41300700001)(83380400001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anNIUGhmQndGenFQM1hFVkZjdlpiR3pvUzFxNE9DQ3NvVTU5UDQyQno5Nks4?= =?utf-8?B?RUhOV1JkYmFYcUVWSmxOWFN6T0pMbEtXenIyMHJkc3BEbmhnTkwwMStnVHFn?= =?utf-8?B?eXRNR2F2K2tvMXVUZWZnajlna3ZhOXdJNEZvS0UweVZKSk9Vd0tIWmQvNWFl?= =?utf-8?B?Qi9NblFnTVVDVHprTlRUK2lBZHpYeFRWNG84M016Sm03amlYcEVIWitIY2Nv?= =?utf-8?B?UUJ6cTJzYndWUzRpU05WTWZUY2l6SUxqODc4YTdJNUljK0xKTkZlS3B1UGln?= =?utf-8?B?bkx0MDZVYlR3a0hEMUlpUzNkRVVrSndFV01sOGRwcjVCdzE0d3VDU0J2em9n?= =?utf-8?B?SnVkeEN3RjJQZjRWYmNJblZZV1RLVEp4dEhRU2IrWFpkZlJoYzRYSlF4Rnkr?= =?utf-8?B?eUE4RzcvNUdMWGlPUGRXb0sySUJOQk5lNndpOG5pK1puMnpyV1U0NGZrRjAr?= =?utf-8?B?NVhvTFJPaVNDNFhPL0tkWmI4ZjlqM0daaG9oUEc3WW1xbEhiTFgraFl5L205?= =?utf-8?B?dGxKam5jM2k5aTNvZDY3NmdSNEtPUzdGYmo0T0ZuYjJ4VGtFUDNySXNLaWsy?= =?utf-8?B?Q09BNTU3aGNXMFBSQU1wMjJ3YU5Gem9MbkM3VjRLdHduc25wMHZaaUlFQUov?= =?utf-8?B?dlllSWRGWGRkdG1Sbmg1Z0VDMyt0YktOV21SNjI4ZzJMclQ1UFpBNS9idnZH?= =?utf-8?B?K3c0MnJubndVWTF0NmQ4cWpTclVqZm44K1JTeE5MQUNSQXhyeHZuYUdUWlFi?= =?utf-8?B?a0dYTEpvSXRFZENZcEcrdTIxVkxUM3dNSjlsTUVWZjNSYWtTZlJLSTB0TWdR?= =?utf-8?B?MWUwTUJpdXIwRFNWY2I2dEhaSHV1dXBuVHJlbGtDaUxRVHJqMjNBRS8ya1VQ?= =?utf-8?B?RGVpaHVUMmVod2doNUZIMWZzMDF4QjRSelN0dHRTTmR1U0dnTUZzdlIwSTN0?= =?utf-8?B?WGxBZ2RiWXV0bEZNUzcxemdXVUVwYUxaTFBBSFVISzlZelM3TGRLVk9wVTRD?= =?utf-8?B?SWhqWG4zTjY0eHFldnJ4eDVVb3h0S2dlQnJLN1JrRm1sSW5ic1ZVeXFhTERl?= =?utf-8?B?YUpMY1Y2N1JKUW1iY0ViN3VlSmJVeW9rdjlHVVR5Vmk2R0dxa09xVGJvL1FY?= =?utf-8?B?TlIyWHhJNTU3L3JNaFNLbVFmb2JzTzhvcWtPRm4wcitTMVNYaHo2RHAxclBD?= =?utf-8?B?SXloanlYSUNmVWE2TmxtK2FBdXFCbW5TZ0MyVmlpVDVCTnFDMlRnRzZ5WStR?= =?utf-8?B?RE8vRzRMTTJpajNCUldIdUJqOGVjMU5odktCVzFIZlFxdGd3M3pVQ1FPTUlu?= =?utf-8?B?ZDVLOG9jWHptRkxuN3VVU2UyQ1JvSjdJS3ZuM1phWGdhVTJ5VjR6MmFVaGkr?= =?utf-8?B?b1hBd004RFlCejVHemNVb0VVRnhrcUk5WDlmaTJZTWRFTlNZcTBJaldFaWdK?= =?utf-8?B?Tmh2TWlHWlBqNzFoNzFCMzVtMzhHU0tXYTlIYVhqZXhDczFteC9uMUxxQ1V5?= =?utf-8?B?QzhRNndOUlRnTEVnVWdjc0tRSEROTlFLMENXZEdoRjdsSW9hc3F0Yk1NcGZv?= =?utf-8?B?NHBUaTc5dDBDSGZwYlQycU9NczQ4M3FFdE5aS0tyZ1B6azE5YUw3Q3FibTlG?= =?utf-8?B?dGpNNXRybVhjc0FMK3A5NTkyNUNKQnordDZjVDhSZXRvazE4MHFZbk8yWUtJ?= =?utf-8?B?enlpOURYdWF1bjZuNFRMcTQ1SWJ4RTVUK0ZGbEY2REl6RGlaL0FxY3g5WUFZ?= =?utf-8?B?SVExUWsxSTVmSm9wYndjajFKVTBaOERGb2x6b1JldFRqSXNyMzBpaWZLdWJ3?= =?utf-8?B?QUVuNXZsdmFPMTYrQ0JyKzlwN29veGp5aEVYd0dUWDREME95dTZVRVFXdzJJ?= =?utf-8?B?OGQxN1dIY0RURm9oUWY4T3VOUkpOSnFuREdVckQ4YWlGOGR4NlNTeXV3YUtQ?= =?utf-8?B?Z3dWSWR1ZGV3UFVPekR5T2x1d21PNm1Xa0YyWTJnTy9Da2pHNDZ0VFRPb3pV?= =?utf-8?B?ZnBoek1ocGNmaE9PSW1TeVNXalJxVFZ6S2xibmpLbWZybnJ4RWI1K2l1dU90?= =?utf-8?B?WGtoanc1UGNoODRRT2NvQUdBUjljemtycWlQVjhWTVF6MkxLNUxDWHk4ODZ4?= =?utf-8?Q?QJii36vYgQS0dv8ORi7o4jCaB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ad5b290-cfbf-4ce1-fc55-08da5e842e0e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:45:02.9336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k8tstxAtPRIwVdAZ2a1peAGpE6ZI1P/IzSPBh2BQsCyjm3Gjxq/2FYl24NGzQ3NnSlY/GH9xL9PW4sWE6hXm9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2613 Before actually enabling their use, provide a means to suppress it in case of problems. Note that using the option can also affect the sharing of page tables in the VT-d / EPT combination: If EPT would use large page mappings but the option is in effect, page table sharing would be suppressed (to properly fulfill the admin request). Requested-by: Roger Pau Monné Signed-off-by: Jan Beulich --- v7: Fix condition in vtd_ept_page_compatible(). v6: New. --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -1405,7 +1405,7 @@ detection of systems known to misbehave ### iommu = List of [ , verbose, debug, force, required, quarantine[=scratch-page], - sharept, intremap, intpost, crash-disable, + sharept, superpages, intremap, intpost, crash-disable, snoop, qinval, igfx, amd-iommu-perdev-intremap, dom0-{passthrough,strict} ] @@ -1481,6 +1481,12 @@ boolean (e.g. `iommu=no`) can override t This option is ignored on ARM, and the pagetables are always shared. +* The `superpages` boolean controls whether superpage mappings may be used + in IOMMU page tables. If using this option is necessary to fix an issue, + please report a bug. + + This option is only valid on x86. + * The `intremap` boolean controls the Interrupt Remapping sub-feature, and is active by default on compatible hardware. On x86 systems, the first generation of IOMMUs only supported DMA remapping, and Interrupt Remapping --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -132,7 +132,7 @@ extern bool untrusted_msi; int pi_update_irte(const struct pi_desc *pi_desc, const struct pirq *pirq, const uint8_t gvec); -extern bool iommu_non_coherent; +extern bool iommu_non_coherent, iommu_superpages; static inline void iommu_sync_cache(const void *addr, unsigned int size) { --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -88,6 +88,8 @@ static int __init cf_check parse_iommu_p iommu_igfx = val; else if ( (val = parse_boolean("qinval", s, ss)) >= 0 ) iommu_qinval = val; + else if ( (val = parse_boolean("superpages", s, ss)) >= 0 ) + iommu_superpages = val; #endif else if ( (val = parse_boolean("verbose", s, ss)) >= 0 ) iommu_verbose = val; --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2213,8 +2213,10 @@ static bool __init vtd_ept_page_compatib if ( rdmsr_safe(MSR_IA32_VMX_EPT_VPID_CAP, ept_cap) != 0 ) return false; - return (ept_has_2mb(ept_cap) && opt_hap_2mb) <= cap_sps_2mb(vtd_cap) && - (ept_has_1gb(ept_cap) && opt_hap_1gb) <= cap_sps_1gb(vtd_cap); + return (ept_has_2mb(ept_cap) && opt_hap_2mb) <= + (cap_sps_2mb(vtd_cap) && iommu_superpages) && + (ept_has_1gb(ept_cap) && opt_hap_1gb) <= + (cap_sps_1gb(vtd_cap) && iommu_superpages); } static int cf_check intel_iommu_add_device(u8 devfn, struct pci_dev *pdev) --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -31,6 +31,7 @@ const struct iommu_init_ops *__initdata iommu_init_ops; struct iommu_ops __ro_after_init iommu_ops; bool __read_mostly iommu_non_coherent; +bool __initdata iommu_superpages = true; enum iommu_intremap __read_mostly iommu_intremap = iommu_intremap_full; @@ -104,8 +105,13 @@ int __init iommu_hardware_setup(void) mask_IO_APIC_setup(ioapic_entries); } + if ( !iommu_superpages ) + iommu_ops.page_sizes &= PAGE_SIZE_4K; + rc = iommu_init_ops->setup(); + ASSERT(iommu_superpages || iommu_ops.page_sizes == PAGE_SIZE_4K); + if ( ioapic_entries ) { restore_IO_APIC_setup(ioapic_entries, rc); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361153.590497 (Exim 4.92) (envelope-from ) id 1o8hwL-00047e-Mu; Tue, 05 Jul 2022 12:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361153.590497; Tue, 05 Jul 2022 12:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hwL-00047X-JK; Tue, 05 Jul 2022 12:46:05 +0000 Received: by outflank-mailman (input) for mailman id 361153; Tue, 05 Jul 2022 12:46:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hwK-0002H7-JC for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:46:04 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140053.outbound.protection.outlook.com [40.107.14.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6dfd3854-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:46:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2613.eurprd04.prod.outlook.com (2603:10a6:4:37::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:46:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:46:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dfd3854-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TeVZo6k2vo3HxUd61skklc3XW1YHRFA1fOxgL2y9K7gF3S7qWETxCDm6buR8rkgHZm3ZRtc1DQqltw78OFvGL4oSpmuQTOIZQyAZujSxVoz3XL6K3TJVYlITUiN3xJGuvmCcoKBRDSaBG8FkKPIpt0B0/7pe0QOiXwaj4fp1TeMhvgfanuF3vqSWvTUaP6hrD6jSQoYNKx1A0RKGXywJeiE2Te56qSp8lEOWxpNPfW98Qgl8yi2m3LjyY/veQf0Y7s+AwTDcwtDaZEWmkW/GQZ1BKtjDyso/apZv9cIA7NepiCkXBuPtKtj3/My1NBfK7djW2ej4MfHB23CuYkjq6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AxiRfgvA8ZTM896+3sr+fZ7fI2k/BkIKHoJCeGpTy2A=; b=SYYUiUPmOzbBNJ8XGGYzRh5+ninbFOY8YzF1rZTPWfaDH+gagyiK+H+Cdf2aAnw/QRsjY1vXqO8slONz9v7STFUl3T73yk12mM1XFZeHG3Pc12y3FKbxoKrwkb0IFQYs6NMu4TJn5fqulCOFNNO2CZqPiayOcscFmAx9NQBXgnfMhH8Vw7MEDhbiez55PoYOM2LRxcACdZEoVoWasRxwy85DxRWGlnFNJBAnk9dBEEvP6IfAKM33dEVAzSvfwbeQdt3NBr4ys78/dOrpCLqMjUtb9jTfSbYaWEJwgxUhob1wWRy2bVjs8TNzA+ZTrHx9AzrZQe20n9kllEAvpRzCRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AxiRfgvA8ZTM896+3sr+fZ7fI2k/BkIKHoJCeGpTy2A=; b=NaL8Twi3TlfKCL8nQeZ8ROXCnfc9Su4o1N1I3/u1WFg17c33+pZNiZAxnmap2jBQNAzI8wpBHOHvNsAO+5VUOrCD2QN8MNera4WqRY0hBz0we1FwMq+gyC5OyjOa50jcWiDS4/zD8fqkvbIRIOMOw1X5HoygLU/lnwQQCbWilqb+t/yPDCRd2DTfmZX0nHJJ0De+lLfuT+I4JXzYUeiYgBkzfz+Rr6XETE3Fhi2zmonOwEPbyeGMQLD4HLyPQd3xgQ0nIDp8od/v0QONBagTNMtsylrtF5Oc43UBa84RL3wue/VmXGLJnvSVpfkBINvzJ1oR9nbMtCMjpsVQX1ZEZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 14:45:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 05/14] AMD/IOMMU: allow use of superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P191CA0004.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 922945e6-f728-4313-9b10-08da5e84514e X-MS-TrafficTypeDiagnostic: DB6PR0401MB2613:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Am3lb050fsu1JpFh+dv896fE0Gef1NCKRuC9V50G3oUnQAXCj9III8IvjBqtLLxQ+8Qw8FfqCctj2yLVjRmA6gR21RqS8pQO5LvjXt9CpABke6ON/VQCSDHvX/sM5RSH8et8iv2Z2PoOYPUv3n/dWWAYdwQT6RVY45LOrJpJNTC81Tn9z4nxwMJOllCBEZt16NkTpDsZW5A6bhGxVQe5tSvLhQL51quv/d5D93jr6zdyxhJNIoGoLZ/zWj0lfKRc9zgSy9XUlDU73b3NEWFDkzllsxbULOzFhcBcckPwqLgtD6yKGQhE/lVMoC1Q1vF2pPNZ0Xe1nUgrYH706drhEKrrJcLdnyZIxEp9LMVdR39b7rXva86x7On5GTN8+sOIS60sJIQRbjMAAVzuAnGnih4MCc1YUMJZl7cPs3KvYh/4WxlJcfAvmytneh/u03vsgIFJW0bgvPYMZFRshsMS/CbzLYz3kFHJ9PeLXPPiWNrXmrcBuqMjEw8cIzu98+2dgDsz/AN7cdrF8IN3UsBQaNacO01sAVuDmTL7XbIac2j9ZmjSX74p8XKf/9l2Jl+cKZKVUf9ihODj+JOJ68b4RHVHC0cJU8dLrET3g0/EXsbDFJvv7ExAFQhFNs/LR74Jgl8ThAYjQ5GUH6dPIfo+WzZMlAY7uhlZfTu6ZSMPpD1EPSEuYfX6beUZ/OHT92DmAllSvCh1fTrhRSXZqd49q+q/VE34ZnZB7n867JF6gGa9vSYoMj2ifnEVw35pPPpbWcMmSJbHDysWn0ecJrlJCORV102tr15egk22qmj2JuoBXN9cVPmyEgxS8cZtOUlrOk5iajA9n7Cvc29YOBF19uGsG7YhOOZQkxpgKus2Qec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(39860400002)(346002)(8936002)(31696002)(38100700002)(6486002)(478600001)(86362001)(66946007)(4326008)(6512007)(8676002)(66476007)(66556008)(5660300002)(2616005)(26005)(186003)(36756003)(316002)(6916009)(31686004)(54906003)(6506007)(41300700001)(83380400001)(2906002)(6666004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkZBclorTmsybVRUWkRsZHlHVDl1SGFXUmpseHVBNEhrTHJ2Z0UzZFRjMVVG?= =?utf-8?B?aUJncDdQMzl0M2c3S0dielpKTW5Bai82cUVGYTBDYktFbVhDM3pGN0lIZ1dl?= =?utf-8?B?Z3pTRUR5SmtYZnR5Z2FOcWZPMm9hL0FYek5GOEU2ejYrRW1HUUtNZFplSGRw?= =?utf-8?B?b3M3Q3dYU2FXNFRSKzlGQkhJN0V0WkJIMGY4R0FhUlkwYmltUzBtWEFqcmhv?= =?utf-8?B?b3NjZVNYZENwZ0JITEZnbjlLSVBId2JVelVRd2VOOVkrald2akp6WHRBMkZU?= =?utf-8?B?RytiVSs0a3VNTzM3R1E5WnNxZXJEOC9RVEpkN3BYRXVxaENZRTBPblNVYTRX?= =?utf-8?B?bzRBemhkKyt2aWRHcFR3T284czN4bEdJN3dteWl4NnRuYXRzaDh3d3ltK2d6?= =?utf-8?B?Tkp0VjMzVHp3TlI1SWQ0ang4RHh1MlNxVzNWaEJZeGNjVHNPeGtLWDZlanRl?= =?utf-8?B?d0FUSWFxenJBTUlGYVFCS1Y2eU5mWHpnUnZvekxDZkYvOXVaZTlNVEFwNHBh?= =?utf-8?B?Wlhub01jU2I2Tkl4cUNvK2owSzIrQktMbFdwWjNRUmhweVZBeDlZMTVCUnZH?= =?utf-8?B?bnRUblQzWENhUjR2dWtrWXhZNitxdk91L1B6aW9LdllUR2huVjZuY1ZET09T?= =?utf-8?B?NXAzNHhrMXFtdDhKR1hxdEMvVi9oa0RKRGZTalNBNnBKSHlBaGsvbnp1K2xa?= =?utf-8?B?NjEwZGpvSTlGVHFDVXZndkdpZGNJdmtRdmFXVVlQdEkzMGh4V04yQzlkWE5n?= =?utf-8?B?cURjeDkwRzljRTEra3NJdDlkYllDdXkrOE5sVmU2dnMvNG1VaTcyT0p6ZTI0?= =?utf-8?B?UHdBdzhGbGVWSVVlK2hyclRJREE1anlHU0wrdFE2dnBoRTFsenA2RjRnY3U0?= =?utf-8?B?dGJ5NlBRTDhLcjk2RkNIbkJMRHpMWStpYnFTYTBqTFFvcGQxUXF4NjhNVEF3?= =?utf-8?B?V0lZLzJLY2FNbGp5OXlvZXUwMGNJWHBkSWhtSlB1c3N0OEVrRE9jWGMvRk5H?= =?utf-8?B?L3Q3S0l1aXgvRHdUT2FVY0NIb0JueFd0MmVuSUpnRkQxb1k4VUh5Y08wd3JZ?= =?utf-8?B?U0dXay8rYzdJZGNzcnNtaURpeU41YU9FZUxvVHlybEhzVGRBb001YUZXeXlD?= =?utf-8?B?QUlEaGRDT3hlWjI4cjBhdS9vK0tzN1A5VmRWcnRwTkdpNE9rZTZOOXBhcERu?= =?utf-8?B?RWlqaHBCSERPR05PSk15WVM0V3gvaHJmQisvZDVNUm9IbFJBTmZNNUN3RHBh?= =?utf-8?B?Z2VMWXdvQ21yNkRVVmlTL3FxS09kV3ZvaDUwMjh5QXdkRzFCUnRhMDZaWmcy?= =?utf-8?B?RDY1T3VHMlVpS3lJUVBWWXh4Mi82K0ZqRXdlK0tJa2hLQy9sdzIvb3EvREpR?= =?utf-8?B?bkFBcHlIZTJDcXBMZFFjYjNxdXVRRE9aQ2srUm02K1hzSWczTk1IQmpxQ1Q4?= =?utf-8?B?WVV4OWl3aDRENldORjNGM2hYcWtoeE15bUVielE4MWtFSjNOZzJqMXg3YSto?= =?utf-8?B?bzZlUmpxb0lBTmR3ODJBN2FsWWluN2VNSzl6SVZFUXJZRHExOU5xQk92Yjl4?= =?utf-8?B?WlJHRHA1ZHY0dzhaNTdoSVZTdmdLRVg0dGY5dEFlTkJDdHg0eTJiU3FJNDh6?= =?utf-8?B?Ump3ajRhZ09ud1VFekRlc0lxSEJEWkxTOVRDeXVWVmlDL1gzdjZMaWwxaUpG?= =?utf-8?B?aEVIR05VMXRpdlVHN3VSa1lCMGtpaThVM2dyK2p0VFRBWnVtWEV0U1M3U0tK?= =?utf-8?B?blZ0aXZhcTdkTXhtdTZJeXN3M2p6QnZjaHBnNTFwdnd1N3lDQXREYkwvMmo0?= =?utf-8?B?dDFDR1JEano3TFdQdngyMlhNRFhMRG1PbVQ5dnRqYnZHbFcxZlA4M1hxYjlD?= =?utf-8?B?OUZsenkwNzlRSDFkMHZRRDZBM1ZEbzhaTXFnUXpIbDVrQWdpdmcxQ2Z4d2ZF?= =?utf-8?B?SGx1YzVxdEFhUTludDMwRTMxNUU3ZGZHOEtBRXQrcTc1aVhZd0k4WHhMNVN6?= =?utf-8?B?dUZhOUU2TXp1TGloWGliWTF4Vy9QMlNCekZLY0lTZDhQSU9WZURXUDNRMGFP?= =?utf-8?B?OG96THdZaXQ3NjdTVTAwa3dKeGJYL1BmbzJPWXZGSnB3M1N3cmtKV2ZqSnRp?= =?utf-8?Q?Qa0v3MKeNIzmEzJ1ciRJ7/KTA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 922945e6-f728-4313-9b10-08da5e84514e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:46:02.0552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uAJnnFQfaygK3hPi9A5etlsjBj8Qs3K8361xn82YY1ZJooaM8ThWK9P8GLqTAUQ2DnuMNO5mHQhIEpJOmxtqMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2613 No separate feature flags exist which would control availability of these; the only restriction is HATS (establishing the maximum number of page table levels in general), and even that has a lower bound of 4. Thus we can unconditionally announce 2M and 1G mappings. (Via non- default page sizes the implementation in principle permits arbitrary size mappings, but these require multiple identical leaf PTEs to be written, which isn't all that different from having to write multiple consecutive PTEs with increasing frame numbers. IMO that's therefore beneficial only on hardware where suitable TLBs exist; I'm unaware of such hardware.) Note that in principle 512G and 256T mappings could also be supported right away, but the freeing of page tables (to be introduced in subsequent patches) when replacing a sufficiently populated tree with a single huge page would need suitable preemption, which will require extra work. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v5: Drop PAGE_SIZE_512G. In amd_iommu_{,un}map_page() assert page order is supported. v4: Change type of queue_free_pt()'s 1st parameter. Re-base. v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks where possible. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -32,12 +32,13 @@ static unsigned int pfn_to_pde_idx(unsig } static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, - unsigned long dfn) + unsigned long dfn, + unsigned int level) { union amd_iommu_pte *table, *pte, old; table = map_domain_page(_mfn(l1_mfn)); - pte = &table[pfn_to_pde_idx(dfn, 1)]; + pte = &table[pfn_to_pde_idx(dfn, level)]; old = *pte; write_atomic(&pte->raw, 0); @@ -351,15 +352,39 @@ static int iommu_pde_from_dfn(struct dom return 0; } +static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level) +{ + if ( level > 1 ) + { + union amd_iommu_pte *pt = map_domain_page(mfn); + unsigned int i; + + for ( i = 0; i < PTE_PER_TABLE_SIZE; ++i ) + if ( pt[i].pr && pt[i].next_level ) + { + ASSERT(pt[i].next_level < level); + queue_free_pt(hd, _mfn(pt[i].mfn), pt[i].next_level); + } + + unmap_domain_page(pt); + } + + iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); +} + int cf_check amd_iommu_map_page( struct domain *d, dfn_t dfn, mfn_t mfn, unsigned int flags, unsigned int *flush_flags) { struct domain_iommu *hd = dom_iommu(d); + unsigned int level = (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1; int rc; unsigned long pt_mfn = 0; union amd_iommu_pte old; + ASSERT((hd->platform_ops->page_sizes >> IOMMUF_order(flags)) & + PAGE_SIZE_4K); + spin_lock(&hd->arch.mapping_lock); /* @@ -384,7 +409,7 @@ int cf_check amd_iommu_map_page( return rc; } - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, true) || + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, true) || !pt_mfn ) { spin_unlock(&hd->arch.mapping_lock); @@ -394,8 +419,8 @@ int cf_check amd_iommu_map_page( return -EFAULT; } - /* Install 4k mapping */ - old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), 1, + /* Install mapping */ + old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level, (flags & IOMMUF_writable), (flags & IOMMUF_readable)); @@ -403,8 +428,13 @@ int cf_check amd_iommu_map_page( *flush_flags |= IOMMU_FLUSHF_added; if ( old.pr ) + { *flush_flags |= IOMMU_FLUSHF_modified; + if ( IOMMUF_order(flags) && old.next_level ) + queue_free_pt(hd, _mfn(old.mfn), old.next_level); + } + return 0; } @@ -413,8 +443,15 @@ int cf_check amd_iommu_unmap_page( { unsigned long pt_mfn = 0; struct domain_iommu *hd = dom_iommu(d); + unsigned int level = (order / PTE_PER_TABLE_SHIFT) + 1; union amd_iommu_pte old = {}; + /* + * While really we could unmap at any granularity, for now we assume unmaps + * are issued by common code only at the same granularity as maps. + */ + ASSERT((hd->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); + spin_lock(&hd->arch.mapping_lock); if ( !hd->arch.amd.root_table ) @@ -423,7 +460,7 @@ int cf_check amd_iommu_unmap_page( return 0; } - if ( iommu_pde_from_dfn(d, dfn_x(dfn), 1, &pt_mfn, flush_flags, false) ) + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, false) ) { spin_unlock(&hd->arch.mapping_lock); AMD_IOMMU_ERROR("invalid IO pagetable entry dfn = %"PRI_dfn"\n", @@ -435,14 +472,19 @@ int cf_check amd_iommu_unmap_page( if ( pt_mfn ) { /* Mark PTE as 'page not present'. */ - old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn)); + old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); } spin_unlock(&hd->arch.mapping_lock); if ( old.pr ) + { *flush_flags |= IOMMU_FLUSHF_modified; + if ( order && old.next_level ) + queue_free_pt(hd, _mfn(old.mfn), old.next_level); + } + return 0; } --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -747,7 +747,7 @@ static void cf_check amd_dump_page_table } static const struct iommu_ops __initconst_cf_clobber _iommu_ops = { - .page_sizes = PAGE_SIZE_4K, + .page_sizes = PAGE_SIZE_4K | PAGE_SIZE_2M | PAGE_SIZE_1G, .init = amd_iommu_domain_init, .hwdom_init = amd_iommu_hwdom_init, .quarantine_init = amd_iommu_quarantine_init, --- a/xen/include/xen/page-defs.h +++ b/xen/include/xen/page-defs.h @@ -21,4 +21,14 @@ #define PAGE_MASK_64K PAGE_MASK_GRAN(64K) #define PAGE_ALIGN_64K(addr) PAGE_ALIGN_GRAN(64K, addr) +#define PAGE_SHIFT_2M 21 +#define PAGE_SIZE_2M PAGE_SIZE_GRAN(2M) +#define PAGE_MASK_2M PAGE_MASK_GRAN(2M) +#define PAGE_ALIGN_2M(addr) PAGE_ALIGN_GRAN(2M, addr) + +#define PAGE_SHIFT_1G 30 +#define PAGE_SIZE_1G PAGE_SIZE_GRAN(1G) +#define PAGE_MASK_1G PAGE_MASK_GRAN(1G) +#define PAGE_ALIGN_1G(addr) PAGE_ALIGN_GRAN(1G, addr) + #endif /* __XEN_PAGE_DEFS_H__ */ From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:48:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361163.590524 (Exim 4.92) (envelope-from ) id 1o8hyH-00059y-RN; Tue, 05 Jul 2022 12:48:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361163.590524; Tue, 05 Jul 2022 12:48:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyH-00059G-LZ; Tue, 05 Jul 2022 12:48:05 +0000 Received: by outflank-mailman (input) for mailman id 361163; Tue, 05 Jul 2022 12:48:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyG-0004qy-83 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:48:04 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b52bc30f-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:48:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5252.eurprd04.prod.outlook.com (2603:10a6:208:cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:48:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:47:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b52bc30f-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J2Y4SB0nt/+lGPUEXk+04nHq25JN1bmQhQJKeBvQdchFcpy7WU3QQ/29NEX1WxyTdtIJGFqG8SRRZ6YBK0yLB4/szPnjIEua7mnFpenh3qAJP1H/nlHpsd+Dmu2Mf8js4wJVtiA5I9eFxWXIXISiWmZrA6Ie1X0w97JKbRYB+Cwusd8v6jWH5E48cQcC5nYdHr96OG9bzO90/OmZ+1RF9KxUmgVracsmskXuzbN8woOTeKoCcm29LdG0nXwoJKEKEDQZY389bc78jgCoybm1bEj3rTGOalXMkiByGfqlqhZbJqO6FUvz3NaNnlLjhF2OKE05G4ieWUQjvjhVLw0AEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBJ+nA86CUu4Iegk0a8bS6g3MTobVKpnG0RqAIWkZLM=; b=Ah2E6qAOLtnhMC2A3W/hR2Uo447DNGk1JBmsklLLI/58x75ojhd/wkxlswJ63XbBqbwZEinSa94E7WXcTutEeKYP8Zjls2H84f4RK3xTT9S1Dl41/McIJ3gw5wWIuGmCNN2c+gCmxe1o1p/Q7wTZ8HW0M257Xl6T2Fl7GsCTkD3xkp2SlE8psvIZvzjI0hh79wKEX8TjLbzwpsmaAGYbcMAh1ZscmJw4mlGrZ4mw0C5AcCF3zarpgDAkCp6Nhi/K1/AIwp4VmMpMXJu5rnnvUpKLcI4Bn148jCDUs8lMs39NRdcqmjh9Lm/dqSVqbhQwt8kGKnO46vptNhGDFKmctQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBJ+nA86CUu4Iegk0a8bS6g3MTobVKpnG0RqAIWkZLM=; b=QTwJWf3JfT2vsx/VyLm8Y8fKgpO6VBInY6R3CIKk0JQmNskOXSqZO0YXExSGw9caRRelqRuLj3AoKaK93QeLRXggqL2F9u8YzD2b9BXBJMIQpnmNhPuc7/+B9gwEIJpZfDAjnNShO6hO3aBpx1NCrmrZNGRrw6hzUyEXpRRpvoCowtEihg/AJZbpKmAt4A9fvdS3a2Qt69ON06BSt5AustmVY0ZwBuGqcKun5xvfdwBGnE6jErxCDUdHzIpdwYDHNMIgsS65U/8X75sxB9BZYCRXJuFjoMKqNQk7oCB/R3yfl2MztDiCFbg4pSbEPvKXjyN2J7kGQyxBlS9exNhgoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 14:47:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 08/14] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0411.eurprd06.prod.outlook.com (2603:10a6:20b:461::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bc706466-9186-450b-fc37-08da5e8484ac X-MS-TrafficTypeDiagnostic: AM0PR04MB5252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WAgGNLApFgpHZ7E0CNKvsAGRtRDK0qzaoR4DwfDZWDvGYI8diwHm1dpg3pZ2KPKVA7zLIlj0ILQW/otE1Bxll0Joi16mQhJMmw00L+kmx+Ml3wxP49+ttKgyptOxi3xxN0JGgvMG+6zMXmqpAMp4iD5n+ok73tJ1p9VA6ZZWS+iQvavm1cvcIBvZ99m5tC6JLnTxqQa54j9a/GFcFLTiXF6mlhyJLRnpLM/waDceFk14sVytW1Q+roIzpJRG0/00hdZtlaEfi9U9RB+siE/sh8RQ56+1UiCpNxA/gY+Dd1VYSjf8UhWpcOAjRjyGFFNQUuDaYQohG5JVCXJlCVsC8Rt47XAQEDphkqRL1WDZmhIEO2APzD3mpY8x9foLsYE3F74W3VMpSSrPPFylO0GHGfkxV20pyNRSaVbebpTVGldH+7HT9bkJfZi4SXx8gkKE604BQWLV8ph8F6zt71plwXixvsjoKBE4BeKfFbXpU/cgzgCnmeCehMMcAi/R6Tw3gmMHyGM6OkPaYiLQtJkQfzsAqdExERr28y97eOl5hvMp+EJ+BllxRbEqXCVxbSZHKYlmO1bRE+gEobcWhn61RTfUmtb9BygEJIXLs7zjzlHKdDYFaOUiCn+pM+yKufbRt0EK7nzzgHJ0UtsUoMhV34T7MLNYlyNR94UU1CSsUKOsZKigEHyxW7DZaxoBtgaLbsV41WyiOpgwF7//qk+SyKRaZx0cwUJnEXez4QONj29neRL7pYGP6H8Wi4SP6OezusZu6P5OSwU96kKrQ/5Ss8sm86d2zejt011TXa8olzHMTk2Oani5kEU2vPb19rCSsM6I8RimxlLV7cSgjRHr8WgubbWbBhv1sWHR6IIX7O0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(478600001)(5660300002)(8936002)(6916009)(54906003)(316002)(86362001)(31696002)(6486002)(66946007)(4326008)(66476007)(8676002)(66556008)(31686004)(2906002)(83380400001)(2616005)(186003)(6512007)(26005)(38100700002)(41300700001)(6506007)(6666004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlV2a3N4VVFsMmF1WWoyeHNud1J4SWJ6Uko3akFBKzJISWZOQzJuMzBRTzlh?= =?utf-8?B?ckhiQytQVUV6dXYxZnlhVDNzNVNwamVOUjI2MTVrblJJNjhMOWxkS1RUYUZx?= =?utf-8?B?L3NqSzhUKzloWFRqc3cybXRzaVYvRkJmYjh4bXQzYXlkZExFbVZ4OUR6cHMx?= =?utf-8?B?dnpyc0RHVlIxNEpnS2s5Wno4b0V5b2dIcnlpajFQblVMRENCbjIwaVcrOFVn?= =?utf-8?B?N3pvSUpFdEk2OXJmN0dBUUVJSFhyaGFzVUk5RE1teW5aemM5cG5Wc2xGMGpM?= =?utf-8?B?MkhUYVB5b0hPNUg0Ty8waURxQ3FUTVN3Rnc2OG5PUDg5NitRYUY5ZXJkZU52?= =?utf-8?B?MzArQTcwbmZ0R3EzZXpKLzMxMlpEVFA4SEZxOGU5RHpyK0ZBdEFHTVlFRUcy?= =?utf-8?B?UmZDdjdUVjIrMGl6WHYrZmwxcy94bmNnb1F3ZGdmVmFLL0FpYWJORndseXNu?= =?utf-8?B?QVI3SE9UVmFlcmw4NFJGL2RNbWxKY3RDK0k2V0NHM0YyQnNMb3B2K3FzcVlu?= =?utf-8?B?NjhiNmM2RS8wWUc4UUVrR3Exc3BjSGNOcmtFeFkycDF2M0R3L1RCVmF1Y0xY?= =?utf-8?B?VnpBck1SWGpPQ0lMV2xNQUZuWXhYSmE4SVc1dFRhUVkzakJsS1QvSTUwUTE1?= =?utf-8?B?RXV5bk1mbjRTQUI0M1F3SjBVWGdkNW0zUHNRWXc2UzVwb3UzRUcvRmpVTVpr?= =?utf-8?B?MktRRi9rNlF2aEx3L2tWRFU3aFM4bGdEdktBSWlaejJTOVZwV2RyTGZYNXhC?= =?utf-8?B?K3pQVEdGTlBhaVBpRnNpVHZtaFBCLzBERXJGVGt5TGtUa2cwYjJHQUEzSklj?= =?utf-8?B?TGVRSjN4SVltalk4RDVNNFRNQTUxRXFhUmEwREs5Z1AxNDNqL01XRFRKS3dk?= =?utf-8?B?b09TcTh6YzQ3VlBwMmlDYysvcjg3c3VWQzdFdENXNlhrOFFnQzM1VlNySlFO?= =?utf-8?B?QkV0TGtSL053TnBiaUFTdlBleExiTzBlcy9oOUw4MmJ3S1o5N0NYNFFLZWor?= =?utf-8?B?RlNhK3VUakx2RVVPTVRyMjFIa3pzVmczWjc1eDJVMEQ0QWdQNFd5Nkd3VmFs?= =?utf-8?B?NmlFM2Y5LzlVMnFrdTRjbS96bVp6eEduRHdQRU5CWnpsdmszcXZBKyt6TWly?= =?utf-8?B?QVJnc3YycWttL0lhOXdlRnAxWU9Wa2c1VGxIOUQ5akdEcUFkUG9XT3F6MlVI?= =?utf-8?B?QXl3andaa2VlcHVlWXVlbWFRTnFoYVMzeTVCZzE0R1pjWmRwSVN5cENmeFF2?= =?utf-8?B?aXIzM1FHWjJJR2YrWk02VldDbHhXT3FXUjJBNytlQWZDYWVLc3BMY0U2ek5K?= =?utf-8?B?VDRWRXhVVjVKTmk3U1NsT0Z5Q0Vlb0JBaTEwOUF2SS9ReUp1STAvTzV1bDkz?= =?utf-8?B?aisxZjlTTlhVeUN5QTdVWkFrWURKeVVRMWJib09HdjczY3BwM3NWbDdKSkps?= =?utf-8?B?bmlUZnp2d1hZdXExbW40Y0RnQzFHVStnQUllUTZyMk1vbk1OM09Md25SeGJQ?= =?utf-8?B?YnNnMEVnUHVoMmZ3L3BEN1kwQmtMaUliRUp3ZWtBL2YzUnl6bWJUb0hDYkdv?= =?utf-8?B?cVZIeUVZRzNjUllJLzFlaWVoQVNkTk40ajJjL0lYNTZNOEQ0YitVYjRMajVy?= =?utf-8?B?aitTNHZCWlhxZlA1YU54Ujl3RGpRUjJIVVBzODhoM21zOWRDWnpZVTV5ZVcr?= =?utf-8?B?MnVGZ092blZURXFySTFVTERZK29LVWRuUjlGaGkxNXZVVlFRblJlbEx4UEt2?= =?utf-8?B?U1E4L1RVano0SDR3Mk1OYmhXRjJxM0txQVpUeFRrZE03SHptUUtndUVqc25Z?= =?utf-8?B?L1Q5NmxTNDJzN0kxM0w5MERrbTQ1NnpBWEZFeHlRR1lXVlB2cEd1eVpvejM1?= =?utf-8?B?VUYyVHkwbVUyWDJmbWdMSUQwZGsvY1Z3R21hN2F5TlhZM25OVTBXaWt5d1FZ?= =?utf-8?B?OEg2MEZ0cWg5RmM1bG94Q2JhNlR4bStuYitQL3d3d3pvb0lEVDJEd2gvQ0c3?= =?utf-8?B?WWFlbkZQUnYzSWplaXJwMHUxcVRaVlM3dGh3M254dWh0TjBzNWZNSVRvcDQ3?= =?utf-8?B?K0xPSTEybkZnU0IvRXg5TVBiNmY5NTRGL0NwUGJWcElrb2lHNHdVelFndVhi?= =?utf-8?Q?5U2ZfWKka91rDbw3HQ2LDTa2x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc706466-9186-450b-fc37-08da5e8484ac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:47:28.2219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Zp3FlZr+YQqzyLOvBTWxJvy9+ynixkOvZP3gTA37sqUbvEekJBbK7dQzM0eTev2ggDO/x62/F8S5tzEhcURXDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 Page tables are used for two purposes after allocation: They either start out all empty, or they are filled to replace a superpage. Subsequently, to replace all empty or fully contiguous page tables, contiguous sub-regions will be recorded within individual page tables. Install the initial set of markers immediately after allocation. Make sure to retain these markers when further populating a page table in preparation for it to replace a superpage. The markers are simply 4-bit fields holding the order value of contiguous entries. To demonstrate this, if a page table had just 16 entries, this would be the initial (fully contiguous) set of markers: index 0 1 2 3 4 5 6 7 8 9 A B C D E F marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 "Contiguous" here means not only present entries with successively increasing MFNs, each one suitably aligned for its slot, and identical attributes, but also a respective number of all non-present (zero except for the markers) entries. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- An alternative to the ASSERT()s added to set_iommu_ptes_present() would be to make the function less general-purpose; it's used in a single place only after all (i.e. it might as well be folded into its only caller). While in VT-d's comment ahead of struct dma_pte I'm adjusting the description of the high bits, I'd like to note that the description of some of the lower bits isn't correct either. Yet I don't think adjusting that belongs here. --- v6: Use sizeof(). v5: Assert next_mfn is suitably aligned in set_iommu_ptes_present(). Use CONTIG_LEVEL_SHIFT in favor of PAGE_SHIFT-3. v4: Add another comment referring to pt-contig-markers.h. Re-base. v3: Add comments. Re-base. v2: New. --- a/xen/arch/x86/include/asm/iommu.h +++ b/xen/arch/x86/include/asm/iommu.h @@ -146,7 +146,8 @@ void iommu_free_domid(domid_t domid, uns int __must_check iommu_free_pgtables(struct domain *d); struct domain_iommu; -struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd); +struct page_info *__must_check iommu_alloc_pgtable(struct domain_iommu *hd, + uint64_t contig_mask); void iommu_queue_free_pgtable(struct domain_iommu *hd, struct page_info *pg); #endif /* !__ARCH_X86_IOMMU_H__ */ --- a/xen/drivers/passthrough/amd/iommu-defs.h +++ b/xen/drivers/passthrough/amd/iommu-defs.h @@ -446,11 +446,13 @@ union amd_iommu_x2apic_control { #define IOMMU_PAGE_TABLE_U32_PER_ENTRY (IOMMU_PAGE_TABLE_ENTRY_SIZE / 4) #define IOMMU_PAGE_TABLE_ALIGNMENT 4096 +#define IOMMU_PTE_CONTIG_MASK 0x1e /* The ign0 field below. */ + union amd_iommu_pte { uint64_t raw; struct { bool pr:1; - unsigned int ign0:4; + unsigned int ign0:4; /* Covered by IOMMU_PTE_CONTIG_MASK. */ bool a:1; bool d:1; unsigned int ign1:2; --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -21,6 +21,8 @@ #include "iommu.h" +#include + /* Given pfn and page table level, return pde index */ static unsigned int pfn_to_pde_idx(unsigned long pfn, unsigned int level) { @@ -113,9 +115,23 @@ static void set_iommu_ptes_present(unsig return; } + ASSERT(!(next_mfn & (page_sz - 1))); + while ( nr_ptes-- ) { - set_iommu_pde_present(pde, next_mfn, 0, iw, ir); + ASSERT(!pde->next_level); + ASSERT(!pde->u); + + if ( pde > table ) + ASSERT(pde->ign0 == find_first_set_bit(pde - table)); + else + ASSERT(pde->ign0 == CONTIG_LEVEL_SHIFT); + + pde->iw = iw; + pde->ir = ir; + pde->fc = true; /* See set_iommu_pde_present(). */ + pde->mfn = next_mfn; + pde->pr = true; ++pde; next_mfn += page_sz; @@ -295,7 +311,7 @@ static int iommu_pde_from_dfn(struct dom mfn = next_table_mfn; /* allocate lower level page table */ - table = iommu_alloc_pgtable(hd); + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); if ( table == NULL ) { AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); @@ -325,7 +341,7 @@ static int iommu_pde_from_dfn(struct dom if ( next_table_mfn == 0 ) { - table = iommu_alloc_pgtable(hd); + table = iommu_alloc_pgtable(hd, IOMMU_PTE_CONTIG_MASK); if ( table == NULL ) { AMD_IOMMU_ERROR("cannot allocate I/O page table\n"); @@ -726,7 +742,7 @@ static int fill_qpt(union amd_iommu_pte * page table pages, and the resulting allocations are always * zeroed. */ - pgs[level] = iommu_alloc_pgtable(hd); + pgs[level] = iommu_alloc_pgtable(hd, 0); if ( !pgs[level] ) { rc = -ENOMEM; @@ -784,7 +800,7 @@ int cf_check amd_iommu_quarantine_init(s return 0; } - pdev->arch.amd.root_table = iommu_alloc_pgtable(hd); + pdev->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); if ( !pdev->arch.amd.root_table ) return -ENOMEM; --- a/xen/drivers/passthrough/amd/pci_amd_iommu.c +++ b/xen/drivers/passthrough/amd/pci_amd_iommu.c @@ -342,7 +342,7 @@ int amd_iommu_alloc_root(struct domain * if ( unlikely(!hd->arch.amd.root_table) && d != dom_io ) { - hd->arch.amd.root_table = iommu_alloc_pgtable(hd); + hd->arch.amd.root_table = iommu_alloc_pgtable(hd, 0); if ( !hd->arch.amd.root_table ) return -ENOMEM; } --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -334,7 +334,7 @@ static uint64_t addr_to_dma_page_maddr(s goto out; pte_maddr = level; - if ( !(pg = iommu_alloc_pgtable(hd)) ) + if ( !(pg = iommu_alloc_pgtable(hd, 0)) ) goto out; hd->arch.vtd.pgd_maddr = page_to_maddr(pg); @@ -376,7 +376,7 @@ static uint64_t addr_to_dma_page_maddr(s } pte_maddr = level - 1; - pg = iommu_alloc_pgtable(hd); + pg = iommu_alloc_pgtable(hd, DMA_PTE_CONTIG_MASK); if ( !pg ) break; @@ -388,12 +388,13 @@ static uint64_t addr_to_dma_page_maddr(s struct dma_pte *split = map_vtd_domain_page(pte_maddr); unsigned long inc = 1UL << level_to_offset_bits(level - 1); - split[0].val = pte->val; + split[0].val |= pte->val & ~DMA_PTE_CONTIG_MASK; if ( inc == PAGE_SIZE ) split[0].val &= ~DMA_PTE_SP; for ( offset = 1; offset < PTE_NUM; ++offset ) - split[offset].val = split[offset - 1].val + inc; + split[offset].val |= + (split[offset - 1].val & ~DMA_PTE_CONTIG_MASK) + inc; iommu_sync_cache(split, PAGE_SIZE); unmap_vtd_domain_page(split); @@ -2168,7 +2169,7 @@ static int __must_check cf_check intel_i if ( iommu_snoop ) dma_set_pte_snp(new); - if ( old.val == new.val ) + if ( !((old.val ^ new.val) & ~DMA_PTE_CONTIG_MASK) ) { spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); @@ -3058,7 +3059,7 @@ static int fill_qpt(struct dma_pte *this * page table pages, and the resulting allocations are always * zeroed. */ - pgs[level] = iommu_alloc_pgtable(hd); + pgs[level] = iommu_alloc_pgtable(hd, 0); if ( !pgs[level] ) { rc = -ENOMEM; @@ -3115,7 +3116,7 @@ static int cf_check intel_iommu_quaranti if ( !drhd ) return -ENODEV; - pg = iommu_alloc_pgtable(hd); + pg = iommu_alloc_pgtable(hd, 0); if ( !pg ) return -ENOMEM; --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -253,7 +253,10 @@ struct context_entry { * 2-6: reserved * 7: super page * 8-11: available - * 12-63: Host physcial address + * 12-51: Host physcial address + * 52-61: available (52-55 used for DMA_PTE_CONTIG_MASK) + * 62: reserved + * 63: available */ struct dma_pte { u64 val; @@ -263,6 +266,7 @@ struct dma_pte { #define DMA_PTE_PROT (DMA_PTE_READ | DMA_PTE_WRITE) #define DMA_PTE_SP (1 << 7) #define DMA_PTE_SNP (1 << 11) +#define DMA_PTE_CONTIG_MASK (0xfull << PADDR_BITS) #define dma_clear_pte(p) do {(p).val = 0;} while(0) #define dma_set_pte_readable(p) do {(p).val |= DMA_PTE_READ;} while(0) #define dma_set_pte_writable(p) do {(p).val |= DMA_PTE_WRITE;} while(0) @@ -276,7 +280,7 @@ struct dma_pte { #define dma_pte_write(p) (dma_pte_prot(p) & DMA_PTE_WRITE) #define dma_pte_addr(p) ((p).val & PADDR_MASK & PAGE_MASK_4K) #define dma_set_pte_addr(p, addr) do {\ - (p).val |= ((addr) & PAGE_MASK_4K); } while (0) + (p).val |= ((addr) & PADDR_MASK & PAGE_MASK_4K); } while (0) #define dma_pte_present(p) (((p).val & DMA_PTE_PROT) != 0) #define dma_pte_superpage(p) (((p).val & DMA_PTE_SP) != 0) --- a/xen/drivers/passthrough/x86/iommu.c +++ b/xen/drivers/passthrough/x86/iommu.c @@ -26,6 +26,7 @@ #include #include #include +#include #include const struct iommu_init_ops *__initdata iommu_init_ops; @@ -534,11 +535,12 @@ int iommu_free_pgtables(struct domain *d return 0; } -struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd) +struct page_info *iommu_alloc_pgtable(struct domain_iommu *hd, + uint64_t contig_mask) { unsigned int memflags = 0; struct page_info *pg; - void *p; + uint64_t *p; #ifdef CONFIG_NUMA if ( hd->node != NUMA_NO_NODE ) @@ -550,7 +552,29 @@ struct page_info *iommu_alloc_pgtable(st return NULL; p = __map_domain_page(pg); - clear_page(p); + + if ( contig_mask ) + { + /* See pt-contig-markers.h for a description of the marker scheme. */ + unsigned int i, shift = find_first_set_bit(contig_mask); + + ASSERT((CONTIG_LEVEL_SHIFT & (contig_mask >> shift)) == CONTIG_LEVEL_SHIFT); + + p[0] = (CONTIG_LEVEL_SHIFT + 0ull) << shift; + p[1] = 0; + p[2] = 1ull << shift; + p[3] = 0; + + for ( i = 4; i < PAGE_SIZE / sizeof(*p); i += 4 ) + { + p[i + 0] = (find_first_set_bit(i) + 0ull) << shift; + p[i + 1] = 0; + p[i + 2] = 1ull << shift; + p[i + 3] = 0; + } + } + else + clear_page(p); iommu_sync_cache(p, PAGE_SIZE); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:48:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361160.590507 (Exim 4.92) (envelope-from ) id 1o8hyG-0004rI-7h; Tue, 05 Jul 2022 12:48:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361160.590507; Tue, 05 Jul 2022 12:48:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyG-0004rB-4g; Tue, 05 Jul 2022 12:48:04 +0000 Received: by outflank-mailman (input) for mailman id 361160; Tue, 05 Jul 2022 12:48:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyE-0004qq-9c for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:48:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70041.outbound.protection.outlook.com [40.107.7.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3f9e874-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:48:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 5 Jul 2022 12:47:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:47:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3f9e874-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IifTTQEATJ5rsOs+0MYWRNiVeYOl4HmRLv/0qT4Q1/S7hNiCjoOTbtXdaxOAEtRqxx8f5CXdV1E4Z4QcrI356jNZ/BWyBVfYvqelaj+K6GYoeAdE0ANeHfUtmsL6gRVE0p41sAW3FOAPWUkDxBETeFaAtIn87TNoEznJ+zEdyMbiqJQiPV9Z4c4T4g7raW3n0QtgGojmXaW9OOlYjgmd5/NgnNREqjZJYlmxwsNVZXw80eYWsg7/WdrO3b44mQAkK33aYHzIiOxPiAu+acFZTgg6eMOn2fFCGqrjbQq2eHuER5pH0pvRoYDgU0B6Quwsvgbl79rCDrIOl5vNrqce4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nzH6EFMW+e3+Xs7xettJZg30tav9rjlAdUzEqGTjlFU=; b=eNuEDpnJGvKgefB/KMfXzNBxiCUJB5nU/VNiWl+aHiG5xI+WxDOtlJbg+9zOdw6xU6nsjS5xuYnCVxf50oVlSMbJqjGJiSQDUChwjcTEteWZ+hu6fWLqUKrww5vgS9yggj1Jyj40XndtoxgnFARiUECqD6BbI2d5XelcZ0OtuZpVg7A6yc1boX70L58LBfOebaix1w2mu4xzHx4Bwdh6nHiqgrPQXnN+iQLdx6cRz4b9fVAlRFohrBTyastvOAiYofnXE0Vsz/6G7gTsT0G35sJ1/hmC6Sq7iuGBr03lUKE7wQLfjpNK7pw0LGEiFHloOv1UEFjdH8gSNF7RvxV41w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nzH6EFMW+e3+Xs7xettJZg30tav9rjlAdUzEqGTjlFU=; b=vZrmrFR22i1aPqYekL2ea2xnPgR619OXDSqa6tUwtORrSK6F/h9v2zLzmGevDHSs7Sf9TmRfWAyzosXSqY1tSA5z3hfobEoLXi3+L5VHyDOufS+0E4IKEj3NBy+DQAomK8qRA5Iv+ITd3cxCMNXxEoeFas6aj5ud9r7jYoQ6w/tDj8ndREyafbRXV04X1Q/u4H9SgAcoekVJRlm4YNSfBQZ/S+nmK1cFUy7b3ea1WfaZuww+Y0C7x+/Aa26iC9pwh58t4E4fuVh2mxy1pM659z+eiGXwmsrNTOKdsUOkLHW8qum5VRS94tgwLmbEv7GI7F3zg09F6C3nGf/WB7jHBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1ff53db0-088e-ec08-b757-b03639c09432@suse.com> Date: Tue, 5 Jul 2022 14:47:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 07/14] x86: introduce helper for recording degree of contiguity in page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0102.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4e76a39-2084-4ed2-6ff9-08da5e84771b X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KHX2nzvOmr4qFPnYicQka8unMweegtMNmAcJzW2JQRf4PSnFPmvUIrzPD/cyuolqQCn89da4Cjai+6/GaPpt8MbH3mwlZsyrErAgc0zH0N8ELDpGIHNuvuL6Sci5E3CzpEEMgy4/XVRj+dTMZEyqoGAZh7K9wettedRRHfTs/qvJssmkMDbm7Yj7HadSLcU5rfqTQN/T/WTceeUTjKJREqPQbwNW4od5JHrvP4xkvZQRPdy4auDjNv4bYF4NVvNRW+xr6EYPTG9fV48jL3oLyJQT6lxACLw0REaCO3PqLGQlUCjIpR+bUVx841AK0ONCq6Sj+OtyhBD9cJFnWreu+IsBa8zgQHCvgTdh6f9CCmYTVdWcbclPJDWlgndjoAQZDu2VrlLLt/GJ65sGTTh1t7owJPN/0uwWYMmR8vGsvP0Ji1HQEA7Gdn5sjp6rqTG0SPy/KPT5R4KvFd6VtffZiuygA3wcoIoELV5Y+KjKUVoeVwIFMGm+8QhjFLWX6x+wKlMaSDPAG8BRzu3LZiGtjhvbxKRJASyWDhBmT1CTgOmOb0fsNFIrPp1lfBHZNcyCf1AzrFUBv319o2rTolGsqGJvZBLeBwYvBnAOviYooIn5D3eHpLkPey7x2FIAI2lX1ut3gHBzA6NqmlPmAfF06CQmh+SbdKeUK6BGA3qVXEAypLHKsXjVpg75tzPBeMQNAhvQDhHEqTMBVvnPCQwuc72DzGDx5NJQuWt18n6Cm7cHgF7RoYwrJvvZ8Fsps/C5W/pMiq1nMtE3gOTEg2Fiv2oezf8kNTZ8ACs7INk97K5gRQN0WOhSMuIsbzAgQzsDA1Ge3Ulyqacw9EUlAAqW/TjsUIqEH0zfTcTEBP+D4FE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(478600001)(8936002)(5660300002)(6486002)(86362001)(31696002)(2906002)(6916009)(54906003)(316002)(41300700001)(2616005)(66476007)(66556008)(66946007)(186003)(83380400001)(6506007)(31686004)(38100700002)(36756003)(4326008)(8676002)(26005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SnZZb2RNbDJvL0pvRk1tbGFWN1kxcTNCSURRUkJhNjB5SlVSL2dDRHpvRkJQ?= =?utf-8?B?bDhFcjVIeUVtbUovYStGUUk0VE52ZFdyWVBxTklaY1liSWtpRXgzMW1SUzd6?= =?utf-8?B?WWVSUkY1YmNBeXlRMkRwNWRXUG9uTlZCYWtDKzVuZnlSb2ZWaHowVklMUGlh?= =?utf-8?B?N0I0WU9oU2VqOThva3lHdk1PWDlmUFYxZWF5WUtONFRFZmE2NkMxcmN5Qi9o?= =?utf-8?B?Ukx6YkhobzBGenZCS25vWGVXeDNoc0lBQXgzZUxCYUp1M09ZYzhqek5BaVR1?= =?utf-8?B?cGFUL1FuMnYxbkRCcklUeCtnanNKRGtQRzMwQndadHkvc3JYTjI1Q2FwbmRi?= =?utf-8?B?K05wV2tjZTVtYUZDMlM0djdEUmwyZW1VODZrMWZUUzQvcUVLTXl2RVdNMitR?= =?utf-8?B?SE50bFptM0NZNTE4MXFYRkxDNENzWFYwS00wZDF0YU9qQTU5S21MSFd4djJl?= =?utf-8?B?R1lEZndCeEdRNzB4YUtRL1AzMUhMelVJNWpiVitnMDIxc3BTOWlpdVZaSGp3?= =?utf-8?B?Ymo4TE1iSmJ6Z1Q3bkFtTW43amd1OEt0bUI3R1UvTEF0cWtLcHVBRVlwNkVo?= =?utf-8?B?OEcrTG1wdGVTbld4RndOWkZNa2hBQWl6cmQ3TVYvd0g2dFlMd25nT2ppeXJG?= =?utf-8?B?c3h2MVBFYVRQQ2tSYzFIVEt6Lzlia0lYZkY5RUE2S1VDUXpvOG05dDloN3o0?= =?utf-8?B?SVRZV1pGdVMxcCsvNC9vbDd2a1NIWGFveGhrTk1FSER0TFlXQkIrc0JIMVZh?= =?utf-8?B?K3NTMnIwazdDOTRDK0Nya0FLWC96dzM0WkN2MXRVWldyOElNKzFJWld6L1pk?= =?utf-8?B?S211MGxRWWIwK2xURTZ1M3FCSWNLWUpuSFQwNVhZTHdIaFgxbWdzRDE3Wmx3?= =?utf-8?B?NUo4OU1MWWxvZjlIZTFtdFppN0tibW5CanRRbUsxbTVSbzlEUHlTNndjQURn?= =?utf-8?B?Vmk4UG40NTZsdnoraGNmQ2xlSmZaS2ZWalZlanFDYVdTK2ZMZDNNL0gwRVhz?= =?utf-8?B?RXA1a0RsMk1OdnhkY0JEam5ndEtxZnk5R3NmVlhETVRNbzdaQ2Rob2laczJv?= =?utf-8?B?KzgxYjVLVWhlQU02S0NnT09abCszd0kxcG9INGdFQk96WnpicEd4dDFROVVq?= =?utf-8?B?d0s5c0RSTTJndVFTVlZYSDhOMW1pOHVRN1RSc0RYbExNRWdNY010MWFRemJ4?= =?utf-8?B?bWRUcXM0T0h3bHNrSFFxU2tCd0FvQ3F2V1BpTHRlOHBQb3hGNXZyeXNPVDQ4?= =?utf-8?B?RUVzVjU0K2IwVktOQUN3NjVySFAwYmZyRVh5MnNId3Zpd2QwbGJFTnVFRVkr?= =?utf-8?B?eE03MmhaRzVRaWNEU254cUZuY2hkemd2ZGx1QmgzcnhtcXpMcVB5S0xnMzZx?= =?utf-8?B?ZmlwVGovVm11Uy96NHpPVlA4dDBIbVhZTUE4Nk4wTmZhY2NGNHNwMUlQSFl2?= =?utf-8?B?QXlaUGtZNWJIZWdLbDhQSVQ0cHN3SnVXMElJVmJaaUdWQ1ZCSzFWb0hvbjZ0?= =?utf-8?B?bkJFZ3g0YVQwN2lBYUdicjA3d0lYWCtkcUk3NXdlMHNNSER3c0diK1hKdVBa?= =?utf-8?B?akZFWTVic2xmZ0JlS2V5dnVKMGNuR3o2a2FjZnRWaVNKUEVtUUVteDdSYUJ5?= =?utf-8?B?SFNoRyt3Tk9kTzhJYi9KeWd2UXRrRkg5blZOQlBQSGNJZjFQenNwVW90ek5Y?= =?utf-8?B?UjhNVnU4TFFhVHBSRWpDMXN0Wk1qdWRvQSthd0NKYkJyWnpFVnFFNHp5NFVY?= =?utf-8?B?S1h3M1VtNkdFditkSkpRTDdSYVZDdWJCZDZTdWVOTHR0QndPNHI1a0lHRm12?= =?utf-8?B?Y2QxdDZXRTFodjdaaE9YMVJJajZTRnBuNjVmTGJDNnhjSjA2LzJPb2FlL3Qr?= =?utf-8?B?ZlBTeG9PU0t2c0tWVVpCTXZEYVJuSEk0aHJ2a1phbzQ4cFZEQ1drQUZMcEFF?= =?utf-8?B?UHhyL2dpVnNIZXNuYUxWRG9PdHdPbk1sMHJ3SHViclBDQVo1ekNOYnZXd2VB?= =?utf-8?B?Y0FoczVCVFFHR0ZjaDVjN3QyNk9HRDM3TEpQNU0wUGkwa1hxMnhGUjFpTlFK?= =?utf-8?B?TkV0MFFKYWhlVTE2aVdTQ2lxcTlIblZQeWthdnc2ZUxXNlJhY3J1SHlkRXhY?= =?utf-8?Q?wpmLAXj/2vIJczfiESL3XTyU1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4e76a39-2084-4ed2-6ff9-08da5e84771b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:47:05.4733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6E6aurzClZBOFWPGA7ImmFoHM3ea5vP1JrKR/Exhzt3El9FL9kHTqJorPmT0LOf/WCUMXKTmurzr5NYFOKbg+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 This is a re-usable helper (kind of a template) which gets introduced without users so that the individual subsequent patches introducing such users can get committed independently of one another. See the comment at the top of the new file. To demonstrate the effect, if a page table had just 16 entries, this would be the set of markers for a page table with fully contiguous mappings: index 0 1 2 3 4 5 6 7 8 9 A B C D E F marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 "Contiguous" here means not only present entries with successively increasing MFNs, each one suitably aligned for its slot, but also a respective number of all non-present entries. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v5: Bail early from step 1 if possible. Arrange for consumers who are just after CONTIG_{LEVEL_SHIFT,NR}. Extend comment. v3: Rename function and header. Introduce IS_CONTIG(). v2: New. --- /dev/null +++ b/xen/arch/x86/include/asm/pt-contig-markers.h @@ -0,0 +1,110 @@ +#ifndef __ASM_X86_PT_CONTIG_MARKERS_H +#define __ASM_X86_PT_CONTIG_MARKERS_H + +/* + * Short of having function templates in C, the function defined below is + * intended to be used by multiple parties interested in recording the + * degree of contiguity in mappings by a single page table. + * + * Scheme: Every entry records the order of contiguous successive entries, + * up to the maximum order covered by that entry (which is the number of + * clear low bits in its index, with entry 0 being the exception using + * the base-2 logarithm of the number of entries in a single page table). + * While a few entries need touching upon update, knowing whether the + * table is fully contiguous (and can hence be replaced by a higher level + * leaf entry) is then possible by simply looking at entry 0's marker. + * + * Prereqs: + * - CONTIG_MASK needs to be #define-d, to a value having at least 4 + * contiguous bits (ignored by hardware), before including this file (or + * else only CONTIG_LEVEL_SHIFT and CONTIG_NR will become available), + * - page tables to be passed to the helper need to be initialized with + * correct markers, + * - not-present entries need to be entirely clear except for the marker. + */ + +/* This is the same for all anticipated users, so doesn't need passing in. */ +#define CONTIG_LEVEL_SHIFT 9 +#define CONTIG_NR (1 << CONTIG_LEVEL_SHIFT) + +#ifdef CONTIG_MASK + +#include +#include +#include + +#define GET_MARKER(e) MASK_EXTR(e, CONTIG_MASK) +#define SET_MARKER(e, m) \ + ((void)((e) = ((e) & ~CONTIG_MASK) | MASK_INSR(m, CONTIG_MASK))) + +#define IS_CONTIG(kind, pt, i, idx, shift, b) \ + ((kind) == PTE_kind_leaf \ + ? (((pt)[i] ^ (pt)[idx]) & ~CONTIG_MASK) == (1ULL << ((b) + (shift))) \ + : !((pt)[i] & ~CONTIG_MASK)) + +enum PTE_kind { + PTE_kind_null, + PTE_kind_leaf, + PTE_kind_table, +}; + +static bool pt_update_contig_markers(uint64_t *pt, unsigned int idx, + unsigned int level, enum PTE_kind kind) +{ + unsigned int b, i = idx; + unsigned int shift = (level - 1) * CONTIG_LEVEL_SHIFT + PAGE_SHIFT; + + ASSERT(idx < CONTIG_NR); + ASSERT(!(pt[idx] & CONTIG_MASK)); + + /* Step 1: Reduce markers in lower numbered entries. */ + while ( i ) + { + b = find_first_set_bit(i); + i &= ~(1U << b); + if ( GET_MARKER(pt[i]) <= b ) + break; + SET_MARKER(pt[i], b); + } + + /* An intermediate table is never contiguous with anything. */ + if ( kind == PTE_kind_table ) + return false; + + /* + * Present entries need in-sync index and address to be a candidate + * for being contiguous: What we're after is whether ultimately the + * intermediate table can be replaced by a superpage. + */ + if ( kind != PTE_kind_null && + idx != ((pt[idx] >> shift) & (CONTIG_NR - 1)) ) + return false; + + /* Step 2: Check higher numbered entries for contiguity. */ + for ( b = 0; b < CONTIG_LEVEL_SHIFT && !(idx & (1U << b)); ++b ) + { + i = idx | (1U << b); + if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != b ) + break; + } + + /* Step 3: Update markers in this and lower numbered entries. */ + for ( ; SET_MARKER(pt[idx], b), b < CONTIG_LEVEL_SHIFT; ++b ) + { + i = idx ^ (1U << b); + if ( !IS_CONTIG(kind, pt, i, idx, shift, b) || GET_MARKER(pt[i]) != b ) + break; + idx &= ~(1U << b); + } + + return b == CONTIG_LEVEL_SHIFT; +} + +#undef IS_CONTIG +#undef SET_MARKER +#undef GET_MARKER +#undef CONTIG_MASK + +#endif /* CONTIG_MASK */ + +#endif /* __ASM_X86_PT_CONTIG_MARKERS_H */ From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:48:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:48:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361161.590519 (Exim 4.92) (envelope-from ) id 1o8hyH-00056r-G2; Tue, 05 Jul 2022 12:48:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361161.590519; Tue, 05 Jul 2022 12:48:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyH-00056c-CB; Tue, 05 Jul 2022 12:48:05 +0000 Received: by outflank-mailman (input) for mailman id 361161; Tue, 05 Jul 2022 12:48:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyF-0004qy-Fs for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:48:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4afddd3-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:48:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5252.eurprd04.prod.outlook.com (2603:10a6:208:cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:48:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:48:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4afddd3-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nm3IJ4XilEA5dQuHiLq0ypPMUDrcfS9yHJVrPCwgx/BxjECU73yZOWB0pkDlB4HmBcmklt1Lz6cT0f7a9adZCr07nYvRsrhVFDAhKst2mSclsuzq417yXvmnt4NHnbVC5PO6ZBQZa5UeGdP70CNTsyqDoRhn2CWLuBLkuWKXg14xKKBeQNBhtI25ReJZqJaK71yeGBTF3fXia6xlvN3CUKN/c5k2d23Qk0fjlcuV88T3grPQBKX2/nWxv8/pRGfP4atzrjnlS/WfqJ4EqgDoPhh88BeE70m6QtME5NLvRuGOjQpm//1Zdq0XAYiN+vzhsL0G3SVOH0Fi5XayEjL5Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i1SRbMZ5vtUn4A75NysmPVCeWEjl1KBkL8Pu3NNkQeY=; b=cCRCT5sbnFJsYYp/dLCVIAyMhqlinWAfrijRae1CyliIsgVnvotXTiOl46e+vGa94jPqCoLoPofOjdue15L4lHDeC+o0Pxnxk0o08RNoiBvgXO2YkzreuCNzBBkyjvg0NUHWhqGmA9xM+injsqCHpk/pOaEzMoHQQnzdMgpG7OqW7XreG8xydMgZDTiaJ9wkcr5h3gFNOXA0R9s+Ln9josbXelelbaWRcgFWfEfcpXfvSFv9DPG6okiV6iuE59OFiLCQ1m2oqNodIjO1vPAWnfQMyKXr1NuTwObtw68N/8XO7/TnP916waTb9u9SxKW4jRt/rrgxfSOAKnXOHB6Omw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i1SRbMZ5vtUn4A75NysmPVCeWEjl1KBkL8Pu3NNkQeY=; b=OWe7mQQ1XegK+LkJ7EX8uhxjrh6da1L0UQKlZmnJYy5aTHCEzU8AiqM6hOY3kB7NdBLtsQV7QZkTnHfDeOAcg8MjcCbAvzmJjRIPbpOlpVO+6hys6sBfaEgLkCxBaYPk9rYhmr1oaAq9PINmln2uJeemGWiHrGitEMAJX01AoDq81a5/fzxqIs3yBoA0bZhgjOQWffWxG51S3GGAJEkb5H3Ax2vwuk1NCr7R8KmN2VHml7UMBDe1o53ORAu3G3ijN00Tsj57fZZUu1VuzhaFu6Ti/+056VMa94XrXqvvAFniARRHvloZ9+SS2aicbMBU5J+TKKGV1ZiFpR86wrUQUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8b375834-5f36-c1d5-f13d-dc9bb7b53134@suse.com> Date: Tue, 5 Jul 2022 14:47:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 09/14] AMD/IOMMU: free all-empty page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dfc798b1-66fb-4430-4631-08da5e84902d X-MS-TrafficTypeDiagnostic: AM0PR04MB5252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i8eYTngNIfSMExO9QXmyQkMhACZnADrE7jxudhD9cU6ElmI2uQZsPamZWb71zdKjHpZRAFM7xF+sYCbFyjsPqRyAqQjD7cIQDLq4hKJwDidchauKEZFUATwggkmswHXPYkgTQxnpVc3kW1B6vKwRifA2PpFEf/X7byRFjoVfXDcXGMCI5E7KemKVbLwR8+/SrgRW6okOgLPYZn9GnTH6Zxb2eVNjyaHSRQZDzZw+iLn+8PRFG46Z+cefEmTOy4neEAWynrtryRx3KTr/6IYWCLz+JN8g2200JzNRTZgM/v7EnuSUmVWYctW9QYGX2BICOYHNqjzN8rdztoBceeLKSVS70eRirsi35RiY3e5aRMPZf8de2FYu9C8VamK34Ruo1R0TpPFi4x0VZLEBIErsD6x0r034tLWJjF+w+RdcpxQj2uEcz8B4vc/g16nlONz7/DI6ZUkTSQBpb3LbNAGgKPg7vpU8pmMLKQtIAIOlmkc7b75enoo8ubrr+5tzxF9KVhqyfpdq0nIS5pTbQR59I2jSus+BzZBSa9CJnOc/pbnUaDJb1HIJTQd8LKQZpbIay/WlvrNT/Z5hr1gQRZPykt8BCEuOBMtV8IZrLquEnsW3dtHj6qMajyFRnBI7menEKqmEZNC7PUXgdcMHK6TvEMFDJU+Z9IT2lxpsXKHj/SuTvYR1IpIdvVUVB6YPBjRSog/lXsjlv1fHgjY9UOZmj3D1D0G3fmQuFE7+4PqmQKIgg/p+qI84NIym9i373gPL8WPuOgAHJ+EMOQ1A0MqEP5ozqqCJhC3mTzxvWCjCnxP5HGmMRcGbjfdFqxikCAtKssu8p3Nwu9TOGQW/c16wIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(478600001)(5660300002)(8936002)(6916009)(54906003)(316002)(86362001)(31696002)(6486002)(66946007)(4326008)(66476007)(8676002)(66556008)(31686004)(2906002)(83380400001)(2616005)(186003)(6512007)(26005)(38100700002)(41300700001)(6506007)(6666004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aktlcHdjNnFQVkRiRFg0K0JwV3dEWnNKcTMyTzFTM1ZJVTg2cU5BRE11OVds?= =?utf-8?B?UEV5Zmx5UmdpbGNKRHltMnRoY3FOVkt3NndacGtEcGNMa0xmY2VvaXVDVzNP?= =?utf-8?B?aHROOTEzWGgvbGYxcDkvZVh0clU0NWNyWU9FRVdXNGtJNWJEelhSOFhYUWZw?= =?utf-8?B?R1pnUXAyNmdsTnQ2eGxFNHk1TFhQelJUNXZLVW9uSGJhdDhLUURlZTBXU09W?= =?utf-8?B?TG5GZjdRNHF5ZHErWGdyYzQ1c1g1WHNNSWVuTDhlM1dyVUllaWE1QU40NmRL?= =?utf-8?B?bWd1dm5zeENZZ0hJUCs5WDhPZWJHck1zT05uQVR5U281NC9FNk5xUVVjaXpa?= =?utf-8?B?MVhRemdueFZ5QlpFVEpKRVNyYVIwektNVnV1NFVzSFRDd21JcklnK25Wc0ZQ?= =?utf-8?B?dS9wM05kZnNaWFpLYzRwN2gzYzdNTng3Rmo5V004M1laSGJpa08yeXdVVFlP?= =?utf-8?B?bk5HNEhrQmxOMVVRT1VZQkg1b1E0TDF6a29pcDA4L0xBQVRtenR3SzMyczZU?= =?utf-8?B?S0djRlp4SkdBV3dIMmxtaWU4a3hxdElyVGpuKzU5d0JuaERxajJ5UkNJckdN?= =?utf-8?B?UENKb1N1YmgzNWVSU2hiQXJKNzI2NnhrR2tBRFZqNXl4WFR6UFRnQkhqcXpa?= =?utf-8?B?ZCtxanZVR2ZQUmMxajB5ajJhMGhpZ2tkMjY4OUo1VVI0aHZLMHgrZlpFbWZo?= =?utf-8?B?N2pNc0ZGSDNMVFBFUFRyT3BSaHMyNVJQM2VTSEVtU2p3M2s2Z3F2eHM0aVky?= =?utf-8?B?QXZDUlpXdnB4amlMSDdzVGpoK0ZvMnl2cTlETUxlM0pIc1dDNHc2NWluQVBU?= =?utf-8?B?MlJpeEVrTFNZL2thMnBsWDBpN1kxTFpNTGJsTjJjSEs5ODRnZ1dnYmpmY01a?= =?utf-8?B?ZWxjdVEyM3JzdFFIYlZtWThhcTg2VlZaWmlZTy9Sdm5EMGtzWEtMQ2QrVEZN?= =?utf-8?B?MWg3dm42REJvZ0RQNi9OdHc1ZEVXRE5qRnQyT2ZHRWR4cExrdGZ2akRkaGNF?= =?utf-8?B?UDVoc1dqMUo0dFJOMEltQWpsSHNjRmJBaWp3KzBNMUhldms1Y1ppTXpDNlVk?= =?utf-8?B?N3RabkV0b29ZUTV1V1R0aEVkeGphV3MwRTFZd3lCTlhPZ0Z2MXZKUGI3QVZD?= =?utf-8?B?VHpYeTVXRkplU0toUXlMd1IxMVFzTUJQT2RQbmRTVDFiMHBaNTRJT0QrYVRJ?= =?utf-8?B?QlorZDVuYTFaQ1lTczdvTHVSbzZHOVNmKzZHalZjSFV0em9RSncrOC9ycysy?= =?utf-8?B?MFN1cVFmVVF4Ky9JSUszcW9Lc3hxYW04Skl3L3BZcHVyVGdFMUJlUGxtQ0t1?= =?utf-8?B?OFRFWGtWY01ZL0dIUmFJUUlvUit1SUFwUVdnNUVKZWpsQTFSRkMyY2d2ZWlV?= =?utf-8?B?TkZva1d5ZWhPVk1lSTVUYXZOWXFJck1CeGQ4c3hiMFNDd0FWQ1V0RzNjRk9m?= =?utf-8?B?TUMzWWY3RDN6LzFZd3lFZ1NJdkpJdFJDYlM2R1BZV0t0cXdkaHl4SEUzbXBn?= =?utf-8?B?cVJFYXFBKzl5d2VkQ2hVc1J0N1VMWFlwY2dGRjdQWmlSOWxUREtheFV3cm1D?= =?utf-8?B?MkFwOE1NeUdNUlJUVVhiYWZWT3FZSDY4YnR2dFNrbnpqcVRsMTVJalRNWTV2?= =?utf-8?B?ZjhsUEFjTlBtaml0OCtGV0UvNlBiWDJoQ1ZxTy9vWlRGR0Z2TFF3dkJGUEov?= =?utf-8?B?Q3puYityYkJvT2lGQ2xsS0NHbkYvZnV0dXJ0ekp3bk11bEVxdnNkcmNuZ1ow?= =?utf-8?B?MjZrUVRjVWJQeEVGRFQ3YkJabEhjcDdyaS9Zdi9sRDRSbGRXdEJCamdFZlRN?= =?utf-8?B?bXYyMVhUcElIL3p4K3dHWjVtb1pkSjFsT21yMUNFd3Zja1pwQmpzUTV2aGg1?= =?utf-8?B?K0hYZjJURmdOaVZUdTF1ZUMyQ0RrOHNCTWIvWDMxY3B0SUtPeGVVK053bTV2?= =?utf-8?B?Rkk3d1VJbU45enZqRnJ3V0YxcTBtQ3RCcnBaSHJYWXRlQUJ2WHN3M0hQY1Nk?= =?utf-8?B?bGxQM0RKMG1CcXhObTVQWEsvV0lvZ0I4MmYwOVY1ekQ5OFkycDdvT0RZQ0Vi?= =?utf-8?B?TXErWlJvUEdNTnBoTkhjb1ZwT1B0U0dtOHJxMHBqdUNFTnVjckRTNlZCL3k1?= =?utf-8?Q?lQvyHCC0xHjfMn6s8VsclPvO1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dfc798b1-66fb-4430-4631-08da5e84902d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:47:47.5176 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HhKj/Gwz7LR4mr+KHf6MrEZD2xZXCne6zeiyd/uhEbtlkwfQrzu3fB+UwA3tvgZrKBMJmrR7RyvL0vOmCFVmkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all places where entries get updated, not just the one where entries get cleared. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- v5: Re-base over changes earlier in the series. v4: Re-base over changes earlier in the series. v3: Re-base over changes earlier in the series. v2: New. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -21,6 +21,7 @@ #include "iommu.h" +#define CONTIG_MASK IOMMU_PTE_CONTIG_MASK #include /* Given pfn and page table level, return pde index */ @@ -35,16 +36,20 @@ static unsigned int pfn_to_pde_idx(unsig static union amd_iommu_pte clear_iommu_pte_present(unsigned long l1_mfn, unsigned long dfn, - unsigned int level) + unsigned int level, + bool *free) { union amd_iommu_pte *table, *pte, old; + unsigned int idx = pfn_to_pde_idx(dfn, level); table = map_domain_page(_mfn(l1_mfn)); - pte = &table[pfn_to_pde_idx(dfn, level)]; + pte = &table[idx]; old = *pte; write_atomic(&pte->raw, 0); + *free = pt_update_contig_markers(&table->raw, idx, level, PTE_kind_null); + unmap_domain_page(table); return old; @@ -87,7 +92,11 @@ static union amd_iommu_pte set_iommu_pte if ( !old.pr || old.next_level || old.mfn != next_mfn || old.iw != iw || old.ir != ir ) + { set_iommu_pde_present(pde, next_mfn, 0, iw, ir); + pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), + level, PTE_kind_leaf); + } else old.pr = false; /* signal "no change" to the caller */ @@ -326,6 +335,9 @@ static int iommu_pde_from_dfn(struct dom smp_wmb(); set_iommu_pde_present(pde, next_table_mfn, next_level, true, true); + pt_update_contig_markers(&next_table_vaddr->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_table); *flush_flags |= IOMMU_FLUSHF_modified; } @@ -351,6 +363,9 @@ static int iommu_pde_from_dfn(struct dom next_table_mfn = mfn_x(page_to_mfn(table)); set_iommu_pde_present(pde, next_table_mfn, next_level, true, true); + pt_update_contig_markers(&next_table_vaddr->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_table); } else /* should never reach here */ { @@ -487,8 +502,24 @@ int cf_check amd_iommu_unmap_page( if ( pt_mfn ) { + bool free; + /* Mark PTE as 'page not present'. */ - old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level); + old = clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); + + while ( unlikely(free) && ++level < hd->arch.amd.paging_mode ) + { + struct page_info *pg = mfn_to_page(_mfn(pt_mfn)); + + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, + flush_flags, false) ) + BUG(); + BUG_ON(!pt_mfn); + + clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); + *flush_flags |= IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } } spin_unlock(&hd->arch.mapping_lock); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:48:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:48:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361164.590541 (Exim 4.92) (envelope-from ) id 1o8hyS-0005tm-A8; Tue, 05 Jul 2022 12:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361164.590541; Tue, 05 Jul 2022 12:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyS-0005td-6z; Tue, 05 Jul 2022 12:48:16 +0000 Received: by outflank-mailman (input) for mailman id 361164; Tue, 05 Jul 2022 12:48:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hwr-0002H7-4s for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:46:37 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2052.outbound.protection.outlook.com [40.107.104.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 818efadb-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:46:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6065.eurprd04.prod.outlook.com (2603:10a6:208:139::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:46:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:46:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 818efadb-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iwLfJM6XjWiHI5Mb/VNr/+4IM6o8NlBY4BuKhUpLzjtKn7RtTTCCYb8hUoZgf2HypT3ymJdEZlKnYhVVSJhHNboLKpS87kJtV0SxKgHrDRP7eupEDQlIXtgrZ4eXSowj5yt3YDHmkbMcQB2nL+kfiWLaM8zJM4hjf7Ee5U/2DFKKFc6aV0AQOyilUhAtQ6t6ko0vVJ4M9V/+8pFp/fy4dVN5P6VV+nmHFvgV3bBvNQSPErYAwSAlMXTHgOOOnRTCU6nuetmE0v7tPs2BLD/tfe/Tyn1BW1t1roCACz8nHAagyZFxAle9E6erA2K9ZnvjBEZbn63LZPOyq0MhtRlzOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r9TbBkHolhWw357aMMMhJeh7vv8iPQuKs2+KWYhw3tU=; b=Jhy7PtBpO4/IbzKKwebjPIIvYBWG0jMo6k6/pyVrzJzknog1PRZZQwK1rIeVwfuiTsEAUtF70k9WYVLSl+lqYmf3n44zQtVzbUj8mN+DFGQlnlE99atepZZ/8KnQOWHY6zTkzGZ/SXvrVYxotknfK2Qc5DH7NiyFHYHvIcwoksdDqaWRSKYNfh3ZyYx6lkSIM5HaV8QOf1KhSWxnEGrqJJe3bZKOSJLW+dh6zD7g7ss8BbGDYvgNTDMqx0nZ1yyvMU5CpeAZnQ462+dWO7RCNZeUu+ewR9Dg9k9MZuKu4KyfCF5m8MuvLvrC4z3p9XORL84Nf/mDGzuanDu36Tejxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r9TbBkHolhWw357aMMMhJeh7vv8iPQuKs2+KWYhw3tU=; b=30F6K3uBwjJUuRu93fYxfi9eZ4lzhQOWT2Ss5hs/0HkMrssJjpLLrdYjkaFSuoLqaS4TSvSoRhoLhM1HstUmZTASaf9IbcZxiqK8jJ78J6xjYnwrp7dCeVn4EgLQ0zsdOFLDbo8piuOt3sg0a5IME7cwyseZmK93E5NV8cuHJiRMnaAyzdeXFy+1OrnAiTrHP7fB5Ow1lzc74P1yd7VI6D3Sfpb5f55JF55oNp8hcG+UKhSLnyzVyWeSJUAokgo8yP5bqWLnDU5wgkYzhAiGkjHDwZcfwUV8Iy+hHIbmjT9NMQruEGczC0XYFfZU09KPxRehir8KJ/bxIDNCEl9lmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <629e7e8a-b846-14cd-08eb-75433c8c3369@suse.com> Date: Tue, 5 Jul 2022 14:46:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 06/14] VT-d: allow use of superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0087.eurprd06.prod.outlook.com (2603:10a6:20b:464::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0d20481-ace4-43af-cb40-08da5e8464ce X-MS-TrafficTypeDiagnostic: AM0PR04MB6065:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVnmM27Nhwn7EPjuVI9rcbxI5SVaANOlv6d5HbDhFucy07l/duo3635renKb810yapyrLuuJXAhllUGD+WqEqOmnI+n/jUsQFc3FkyS4hfdMYSaAWfVhYtefF4IkBEXFqOQv7o/3EtjJYOOhFN5BQXUpXB2y8zIxkasGTi8jaL/qU/jhBt3AmAHRv4M3zKpP6TdvCQyFAk3AC+FdtjT9KGD62D9XA+jdHt+H7HzmzWsBSVMnw3KXaCybUsy7oqAm4ma3CAYjWHZcnOYIGBMkb6wYwualo0g50wGy/LpoF2H8qM7QNdnf969jrVgY56h3JONdF3V941MXfxZbCyJeurVlo3hBghfUC9xi3RTeoRHNmdVMj+k61QIa01EDMRjP4HsOiaKYNLjRXrBajvI4xKiTILmoDHFx2ibCB8LO+8d9k9kS9AcB7uIIsO0nBtS352jneJIqQO66bd7e1pAyMGifhidRVm7/r2CD56rwN7KwNG2m/9BXqkHaDRk+VAfVvmHsuBDlIwlzWVfXNDOfkRbaV2smjcuaDxQvxNErG8E5zxBNiart1MbbLjQKrlC0rPj62zmzW2e9AsnSCg3HUqyjis+/43sIZbhbv0LnX+yyra3nqUtirOLznWHtz81BKjcEAecpjbbFjw/X76z0x14eN8CF+XAybSAEI9RrWbKjBNwAAWbCq7Ti26ISqf+hyjr0Wygcg5X3xxt3iKRGhqI9uMly2O6U6L8UHdDbWFFdjYsE0KCbENO5HTGOqm37YzWdd6oMJXGuetmT9eEYGFk1C85gRutx5p0SRZNp2JtVoL0EbxmABlKfyTo4TzXhHWdiemAKalT/k4c6dvFTdukqjSEWeJPunfMzXQ/WgEc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(376002)(39860400002)(346002)(366004)(83380400001)(31686004)(6506007)(36756003)(6486002)(478600001)(26005)(186003)(2616005)(6512007)(41300700001)(2906002)(31696002)(86362001)(54906003)(6916009)(4326008)(316002)(38100700002)(66476007)(66556008)(66946007)(8676002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OEQ0L0JTV3o5ZnRSeXppMlo0ejlXNlZlR09SdHFnVTVOdEdKcGFpOGdzaktE?= =?utf-8?B?N25SdXNlTTZ5T3pjU3pSTUFwdVZSOFQzeHlOclFjNzRvNXcrM3lhSGJoLzJ2?= =?utf-8?B?Y204OVEwRkVrK0lFbkpNbXNuZ3ZKcnhXRnQwdCtaR1RRTmxDVDY5UHdLY20v?= =?utf-8?B?Q2h4cDAyL2FncTdmeDVMQTF4cE1aelhxZDBlN3VJR2RNKytSMzk4eHBNcTh2?= =?utf-8?B?L3ZlM1ZXVU8yRnpYTTBQZms2T2lkMWZjdFpRZkJpQzQzcjNxNkd2Vzd0aUFr?= =?utf-8?B?ZUdEdWRZRE5qeWVNZVlUT2xiaTRrRG5jYzJpR1pHOTdYM1ZieHFrdllHWXM4?= =?utf-8?B?aTNld04xZzdHTHJ5WkV6M2ViQ1ZrSjNJa0lQMTc2RDB4Z3FZY3plWFA0SHRJ?= =?utf-8?B?UlJnN0s4V2ZrUTRNbjhiamhPTVkzTStBWjFFM0Jxd1kza0dRY1h6MXFSczJ3?= =?utf-8?B?dWlwaVViMFBmOVlHS1NRcmE1azh3M3phK1p5SEtxRzJKTjF0UnUwVE9tdlFO?= =?utf-8?B?cHgvUDRrWmFaakhhT09PRUdyR2RBdXg3YlFKTFI5ekNGZXNXVkwzQzV2Uzg4?= =?utf-8?B?YVJueDZkc0QyM0RWVkFqRE9oTTZ6MFR3Unl0Z2JnSmV4OTdVU1psZW8weDVu?= =?utf-8?B?R0NGRmJoY1hXcHVYTlFpNGtMNUxnWmt1TEl5dFRaUlVWWEtNdWYwR2s2dFFM?= =?utf-8?B?cWkrbktGanF5WEVDaXR3VUloNmdkcG5YU1Y1UDFqWGh3dEN2YkhVUEg5dWRE?= =?utf-8?B?YW5JbG00UGk0azNFeUx2TUNOUTlqWlNHcHhLQkI0RVJxY1p1VWYxQVBZQjFR?= =?utf-8?B?blREbXp6YmwxU2pscUlkZzgwd2VzaU5tbjZFTjFiNTIvaTBBZHh1RGY5Y0Fj?= =?utf-8?B?WVBrcDNTZngwZCtvbDlMMXd1MHBOcUVralRBT2RJYTI1dis2V2xkMHQyZDVy?= =?utf-8?B?ampZYWo4S1JnNkVDQkRiRUFMTzh4ajhKN0NNeDltaVRQdS9LUThmN2hiUHh3?= =?utf-8?B?QmtyK0RZUVhLWHRQdDloMUtMYS90ajhCbURNMmV3TE91Q0dFRU1oYUR4Q1hz?= =?utf-8?B?dWFJbXZwMWc2aFpycElaT1FpTkJueldJTC9pRHlMbGx3R09qZFN6YzBZcW85?= =?utf-8?B?RGg3NEZYRXc3elVhWnFsTm1DZUZHbUMweVM2WmIwYm1MbzlpNnVKUCs4bjVM?= =?utf-8?B?WFdUeTYzYmJ5TUxDV1V5VEpNWUxDM0s5eWdmUGtlQVlJVmZCVlZaaEdxd25m?= =?utf-8?B?bnBieHpFbEpObXc0Rm1Qc2RzVHZzc3VDR0pEdm5CL1FzQlJ2N0hKd3g4bmFm?= =?utf-8?B?aVQ5T0duSFVMalIwQ3FpUHdaL0FyRFl3Vm1tM1BSYlFtRHZ3aVBaMThBYmIz?= =?utf-8?B?MStIL2h1aDJOTGdFSStXRzFNR2NYUmw3b0JjNi9tM1pHWDNIa1BLVStOanJv?= =?utf-8?B?TVYzYSt6T3FBRkd5UzVnVGVPR2I4MlBCLzdEbmhTUDZVZDN3d3FWdjN4c1Nr?= =?utf-8?B?NTJmWnVzOVA2TjdVZ0JWVUROOUxFbXNrRVZpS0VwUDFROUZybjRld1hUNGZl?= =?utf-8?B?YjF4YXFJMjJoRlBQNkEyZ1pnMDJLYnR0VVpsSEl0aDZQc0pPcGlDb2llS3F1?= =?utf-8?B?N3lhNWdtdmpHLzNwRS96S2p1QlorWGJpd1BwQTFldVBXR0NBQzBudWdsakR1?= =?utf-8?B?UnBwTXVYNFMxa3hVMEtoclFzUEVzVXgwSmZRRy9jYW81SEJHY3hQekFKdXl1?= =?utf-8?B?Q1k2UTlXdllIc1FDWkszYUVaMWZ2YlZPcTkxdko0eEErWVBBSm5SbVhIWEdG?= =?utf-8?B?NVEvYUhwaHpUNU1jNW5aYzJndFY2WUZWZlozcmtrbzN2Rks3Z295dDA3OElV?= =?utf-8?B?emtUM2F3REJ0N280ZFdjcWFOSlRnaG1GczNOK20rQTZJcDVBd0owSnBXRGxY?= =?utf-8?B?dEx1UWZQQzk3dFRodWxZdlZEYnhpMXQvdm1nejA4eCtaNzJtUkRneTg5Sk52?= =?utf-8?B?UkJXMFI1TEZ6aHUxSXlvd2p5eVZwT0NtWHk3NEZPQXZHcXRtVWZvSDJmWG1l?= =?utf-8?B?SkRrMWVZUVZGeG9sSGJoK3FMaEVudHc1aWgvaWtScUgvVzRMVytkWUtZMG1T?= =?utf-8?Q?sQcNZKWlgKwcH4AjwG+UFBk5s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0d20481-ace4-43af-cb40-08da5e8464ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:46:34.8189 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pyEXXP1xKVZZJ3W7dFCoixVirL0irMd9YCEB6KbF1N/3OnMYREpnlRv50q22D1mF7UkuDl6UF/ucAJS9xgdY5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6065 ... depending on feature availability (and absence of quirks). Also make the page table dumping function aware of superpages. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- v6: Re-base over addition of "iommu=no-superpages" command line option. v5: In intel_iommu_{,un}map_page() assert page order is supported. v4: Change type of queue_free_pt()'s 1st parameter. Re-base. v3: Rename queue_free_pt()'s last parameter. Replace "level > 1" checks where possible. Tighten assertion. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -779,18 +779,37 @@ static int __must_check cf_check iommu_f return ret; } +static void queue_free_pt(struct domain_iommu *hd, mfn_t mfn, unsigned int level) +{ + if ( level > 1 ) + { + struct dma_pte *pt = map_domain_page(mfn); + unsigned int i; + + for ( i = 0; i < PTE_NUM; ++i ) + if ( dma_pte_present(pt[i]) && !dma_pte_superpage(pt[i]) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(pt[i])), + level - 1); + + unmap_domain_page(pt); + } + + iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); +} + /* clear one page's page table */ static int dma_pte_clear_one(struct domain *domain, daddr_t addr, unsigned int order, unsigned int *flush_flags) { struct domain_iommu *hd = dom_iommu(domain); - struct dma_pte *page = NULL, *pte = NULL; + struct dma_pte *page = NULL, *pte = NULL, old; u64 pg_maddr; + unsigned int level = (order / LEVEL_STRIDE) + 1; spin_lock(&hd->arch.mapping_lock); - /* get last level pte */ - pg_maddr = addr_to_dma_page_maddr(domain, addr, 1, flush_flags, false); + /* get target level pte */ + pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, false); if ( pg_maddr < PAGE_SIZE ) { spin_unlock(&hd->arch.mapping_lock); @@ -798,7 +817,7 @@ static int dma_pte_clear_one(struct doma } page = (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte = page + address_level_offset(addr, 1); + pte = &page[address_level_offset(addr, level)]; if ( !dma_pte_present(*pte) ) { @@ -807,14 +826,20 @@ static int dma_pte_clear_one(struct doma return 0; } + old = *pte; dma_clear_pte(*pte); - *flush_flags |= IOMMU_FLUSHF_modified; spin_unlock(&hd->arch.mapping_lock); iommu_sync_cache(pte, sizeof(struct dma_pte)); unmap_vtd_domain_page(page); + *flush_flags |= IOMMU_FLUSHF_modified; + + if ( order && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + order / LEVEL_STRIDE); + return 0; } @@ -2092,8 +2117,12 @@ static int __must_check cf_check intel_i struct domain_iommu *hd = dom_iommu(d); struct dma_pte *page, *pte, old, new = {}; u64 pg_maddr; + unsigned int level = (IOMMUF_order(flags) / LEVEL_STRIDE) + 1; int rc = 0; + ASSERT((hd->platform_ops->page_sizes >> IOMMUF_order(flags)) & + PAGE_SIZE_4K); + /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) return 0; @@ -2116,7 +2145,7 @@ static int __must_check cf_check intel_i return 0; } - pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), 1, flush_flags, + pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), level, flush_flags, true); if ( pg_maddr < PAGE_SIZE ) { @@ -2125,13 +2154,15 @@ static int __must_check cf_check intel_i } page = (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte = &page[dfn_x(dfn) & LEVEL_MASK]; + pte = &page[address_level_offset(dfn_to_daddr(dfn), level)]; old = *pte; dma_set_pte_addr(new, mfn_to_maddr(mfn)); dma_set_pte_prot(new, ((flags & IOMMUF_readable) ? DMA_PTE_READ : 0) | ((flags & IOMMUF_writable) ? DMA_PTE_WRITE : 0)); + if ( IOMMUF_order(flags) ) + dma_set_pte_superpage(new); /* Set the SNP on leaf page table if Snoop Control available */ if ( iommu_snoop ) @@ -2152,14 +2183,26 @@ static int __must_check cf_check intel_i *flush_flags |= IOMMU_FLUSHF_added; if ( dma_pte_present(old) ) + { *flush_flags |= IOMMU_FLUSHF_modified; + if ( IOMMUF_order(flags) && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + IOMMUF_order(flags) / LEVEL_STRIDE); + } + return rc; } static int __must_check cf_check intel_iommu_unmap_page( struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_flags) { + /* + * While really we could unmap at any granularity, for now we assume unmaps + * are issued by common code only at the same granularity as maps. + */ + ASSERT((dom_iommu(d)->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); + /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) return 0; @@ -2516,6 +2559,7 @@ static int __init cf_check vtd_setup(voi { struct acpi_drhd_unit *drhd; struct vtd_iommu *iommu; + unsigned int large_sizes = iommu_superpages ? PAGE_SIZE_2M | PAGE_SIZE_1G : 0; int ret; bool reg_inval_supported = true; @@ -2558,6 +2602,11 @@ static int __init cf_check vtd_setup(voi cap_sps_2mb(iommu->cap) ? ", 2MB" : "", cap_sps_1gb(iommu->cap) ? ", 1GB" : ""); + if ( !cap_sps_2mb(iommu->cap) ) + large_sizes &= ~PAGE_SIZE_2M; + if ( !cap_sps_1gb(iommu->cap) ) + large_sizes &= ~PAGE_SIZE_1G; + #ifndef iommu_snoop if ( iommu_snoop && !ecap_snp_ctl(iommu->ecap) ) iommu_snoop = false; @@ -2629,6 +2678,9 @@ static int __init cf_check vtd_setup(voi if ( ret ) goto error; + ASSERT(iommu_ops.page_sizes == PAGE_SIZE_4K); + iommu_ops.page_sizes |= large_sizes; + register_keyhandler('V', vtd_dump_iommu_info, "dump iommu info", 1); return 0; @@ -2961,7 +3013,7 @@ static void vtd_dump_page_table_level(pa continue; address = gpa + offset_level_address(i, level); - if ( next_level >= 1 ) + if ( next_level && !dma_pte_superpage(*pte) ) vtd_dump_page_table_level(dma_pte_addr(*pte), next_level, address, indent + 1); else From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:48:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:48:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361166.590552 (Exim 4.92) (envelope-from ) id 1o8hyU-0006DC-LZ; Tue, 05 Jul 2022 12:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361166.590552; Tue, 05 Jul 2022 12:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyU-0006D1-HK; Tue, 05 Jul 2022 12:48:18 +0000 Received: by outflank-mailman (input) for mailman id 361166; Tue, 05 Jul 2022 12:48:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyS-0004qy-N6 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:48:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bcbe9998-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:48:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5252.eurprd04.prod.outlook.com (2603:10a6:208:cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:48:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:48:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcbe9998-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6ie8G5VVPknGrhLe9djxcfGEJRRYM9iZiKZCAMGJj7Ag0NUeCykw6PD7IyKifMFPGGd/w4NZXu65bOPjh4/AxCZhRV+je3qb3+ETeFiSgLc8pLW2EFnXus90tbicZ4ijMMC/BmRc7uOC7dWYYwvXsMq5KihDuz9AV4MBl8Ao40eBxC2mjbDXS1CSLzeMfDkQD9L6sq8eb5qYLZZJUukn08EyV1edNvj4cqdTY13yq1coioebNQOOmNPXMqCK4JMBJNJzBdf6RnQqFWpsQe7+Ny3YaKvSoHVJeJfzmXvKpk01JXny047wSn+LeJbehX6mCgrdRiUD6JwXEafBXLaeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8x0wNvPPnwdgiVsTXX9OqkK4ScAeymQhxLWbmrRAFA4=; b=XVBkvQgQ43gaCj9u7r/gzAkCvB3QH04QGUqeF9hRZvYvxoh63aOq1XM3D3bC0Vq873NKZItqzMAD8AQW/5ODIkuUTXIQjurQbv11+dba7/9vEnhjwY409JO9iUmFRhJQN6u0U7BsMhq3XkP95SnfNsZLG2mQpyyE1L6GkFnYwnQTiREEjLDFxA4ebNVcFOuQ6ZHaxU3mMWbmxevtb9pEj+QXSIqXaKkNq0enBoXUTjVyLTXIFVD6jKUN6nUG14PfC8aXv50Ld+ZdfEQlNqU5JMWECy6gqw3TmNtLSbkR/I6yU5EBXsA2K2OMce/YLUmWeaQ85Jjl6IDEoVYxDXFdig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8x0wNvPPnwdgiVsTXX9OqkK4ScAeymQhxLWbmrRAFA4=; b=AbsNOTCnCf5G35oceswlwWWiN1KlP5WNsXMELoE+neIB+pA9jLg4Gtd8LZzRR4S0LcSW9aPWhRssfYXKbEvKcVqWoAMMxLBVvWCFC4uOzcx5IUe8RVqRf9r8OEXI5uQVUwlLZnP/b/Gs8fMtRBkuRLHQhP2agpMu450iOMNoRd/s3vclpu5dttHI50b1bNaKzE/FZIg3rL2p4MWS3fsaZ4B3uZS6Al9E/fkDq816CACuncZ9AwINkdG1KjE3zMLoc4cjNA5WmCbjjW8u/uv5HYsXMIBDAoAtmjUl9EZcMTIHWirWSynk90FUvhbn0ufyKJTvNCtNEMkxTdQ7E14BqQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <28b6c824-683c-6a15-d891-651f79d99300@suse.com> Date: Tue, 5 Jul 2022 14:48:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 10/14] VT-d: free all-empty page tables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P194CA0096.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::37) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0879887-653e-4e6e-e4be-08da5e84a044 X-MS-TrafficTypeDiagnostic: AM0PR04MB5252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y22/CE7Zis4myGsIV8tMvlIm3Nw/Eg0AYhEaYBLvnqrdarKonAk/NwKDFHd8S2Tyx/x71fYgrT0vRaPEJfOfxBptpjuzvhbE2T6K4L1WMcBPGWeuZX+hj2YwuqjikXDylEuAhu1YDO7/jdoS19HIK1tNBIuMBGPuZNSe4vPMNrwD6yz3r39HrIExRBOITKcUcfxfOAJSGYf1g427ADHfAeNwj0shdyIIe+O6jQzwHHRlH8ssQFOOBRS/2JRCyv8buW0Xxy69JxGGuFtYvg4WX1tkleUyFXAb5yfr7pWdKr+kdsJj8qdLi7m7+Tg8aHLltD5l5hcCyAiOwdV1vVLpybmc1/SAwFkPPfHn/rYU9vsCpYmE/GfWRxW72MnBHjhqyAqoVuTmfq2luPN1T3cjph4P8CEY4IKFHdFUl80mr8+zvCy7YaixVpxibATwAMYtjOwjqP0LCaB9SbQnf8LQ1UaNAxXLZLvRyruytRaKrsEW5QAEc7Nb/2iDqkz72nOv6wtIVcemdwkOdEAYe5YFSb4ykl6HWV7YfNJv9VQDFKP/fWaRelZK+L8yOKHxu2qKuz75HlIcb8QXtwvlFRk470j5Y7RTMePmyrqTajmdH8Zg/BAqvQ50DiIyPlv6yoafG0JQoYK0KrS9H4Pf6ewXsv/1mAfW2RyX7M4E4IEsdGP/V5N6Vgih0nIfxW9lkeO78nv+kXGyCJAR4PSROXT9j+8oyrBwiMGrCSpMwn4FWcRDfuzpCSCcW/wwANcGCZfCRgUhXrNyXHBafEY+2hUzlYn2cLk3EqVPThO6XIB3kgnb69N6X4oMSe7gIi/U6CIda8PsZVruwp78pduvJQaSfGny5MwqPRYiDQcyKR+KjjQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(478600001)(5660300002)(8936002)(6916009)(54906003)(316002)(86362001)(31696002)(6486002)(66946007)(4326008)(66476007)(8676002)(66556008)(31686004)(2906002)(83380400001)(2616005)(186003)(6512007)(26005)(38100700002)(41300700001)(6506007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjRYTnZSOXBPeUhXMzl1dWsyR1psNHA4eFdiTDQxOEdJR1dUbU1EQUNNSHB1?= =?utf-8?B?RzFlNnVCZlZ1OEkxRk1JdjFMQ05QdGZZV0lYaGs1SjkrbTJQWmRlRkUrbS95?= =?utf-8?B?NkNoR0RNR0V1cE9FYTBWQU8rUU1YeXVpdHhlNWl5SkZpK3dmUDI4RSswWEo3?= =?utf-8?B?TlhvaHZCSGNuZEhMZFJFaW5nbS9WaE9qamFXSkNGR0p5L0I2Nkswa0U1Ym8x?= =?utf-8?B?bDVtci8zcG1ubjFvQTdXcFRURmZjVGd0ZnJkQlV6VmJpSG5PSll4R1lWUVRF?= =?utf-8?B?RDBEcSsvTjJ3Y3ZqVHpqSXlrUnlmSDFIcXc1NkcveVZsUXZUakJ5YkNqdjZR?= =?utf-8?B?VWNjaGZMb1BwYkxHaWREWkxIUlhOSFZWMi9IZ1Bxbzg1SnJ1S25nWVZmc1pn?= =?utf-8?B?L25zbUgxalU1YkYzeWxIUmpCMUh6dUNtRVlHdkw4QlRISklSL1UzUXMrUGdW?= =?utf-8?B?ZVAwWWlyNHZteS94QTNMMlg4UEFtMlFVUnNMYWo5UEpjWGh4cGpWWjluQlpp?= =?utf-8?B?dDkrN00yK1hBb2p5WlRKNnpVODRvRFo3QVR5Vy80cVlvSUwzS1lDUk9ubDJj?= =?utf-8?B?VUZLRzVKVzNyaEMxQjB0TGJtZmVUSlZtaTdDWTVkU2d4aW5pVXNWWFdrNExt?= =?utf-8?B?Q2ltdVIzTW1FSkluZUlHdXl2T3lMWlVDSTV6WVBFaS84blJ3ZWhJK0lpOUov?= =?utf-8?B?VnpYSmdNMlZQOVgvZUF3eHdQSDY5Qk9yN0lhTjkxWE5SSGZQd2lXYXp6MGJs?= =?utf-8?B?QURYSFUrZk5BZDAxSHZzVjNWQjlhN0VoNm1wVTdCZk12MVZ3NUZLZTl3Mlcy?= =?utf-8?B?bWk4SXg4R0d0TlgvdGw3ZHBCeGNTRjZ6cmptTUVzQXlnYWVIOXgxRGVMQ2xJ?= =?utf-8?B?N0FBeDFoZmw2MUZGK09DZ21pc3ZFMkZ0N29wQ1BaMGJ1MXBHbnJWaXdpSnpl?= =?utf-8?B?aUZlOEdia1ozZ2xvNnlkaVQzUkhiM2l4bkxlV3RPajdINTJGUU9uSDI1OVFN?= =?utf-8?B?SWJiUnNGREFlUmlGbU8wNmxFYUgvR1pDTFZvTzlGWkhUOThnMEhqWmN1QUov?= =?utf-8?B?NVBzcEFQd2tYMitpdmdUYURxU01yVGhQVDRDMGJMK3RGL3FsV0lCdExMejJx?= =?utf-8?B?bXNQcVVDMXFIenJVMVI5b0MxejBZTmVieGEwT29meDgwcEt2K1gzRzI1VXJq?= =?utf-8?B?dDgyQndCREVQbkxDd3Rkc01jdSt5VjgzOHVGZ1pjQmZnb25oSUdOek5HT1pp?= =?utf-8?B?anl2YUQzVjlCakI1NGM0WjkrVWdxbFNLS3BGbFk3b2dwZkJjK09sMzk3T1pm?= =?utf-8?B?MVhBMjRPR0ZqSkNEZDFHdDNKQXlNcUNLbjJIZzZGRzNnaE1ad1B2RTg3b3pJ?= =?utf-8?B?eGM1Vmx4d0Noc2JHQXgxeHh1Y2JjWTdmRmgwaGZ4aHR6UkVmdnJwLzdHeHhp?= =?utf-8?B?T2NITGNLQ0Fic0ZKNkN6cTR5K0k4M2svL1M2WkRQa2d6Z0FsaHFmK1FIeXc4?= =?utf-8?B?WW5jNGhWVVdNUk54dUhMT1dNVUxNMnRrdTlEOHhNdDFYOFl4Q2xNOHYwcFZj?= =?utf-8?B?L3p1Y2lPRTRSMTA5WnBjOWF2RXlub3N4NTM5dFd0TzRKaWN0OEphZkRxZlE0?= =?utf-8?B?NHZmb25oRmlNa2ZNdlNxUXYvODFrVjN5ZTlxOCtkQzRjWGVNWmszMlArZDRm?= =?utf-8?B?Z1FaTWVpQS8xMU5JS3pGSVEzZzZ6REFiM0ZSNzZGenRnNUY1ZWdyZHJnV0lr?= =?utf-8?B?UnJLSlJuWGFubVdsUnYvV0hvR05OOVRxSEliZW92L0Z6eC9pbDViQ2lSYnJO?= =?utf-8?B?R2tpY0hhNkNmYmZ4TXVzbkhXOVNRa1ZpWDlITGJvVDA3Rlg1T3p3TURtcWNp?= =?utf-8?B?THFBMk55TWpteGkwV1VZSmNvZmEwa1dZNUtBNTcvUWN5cWdyMnFrd3FQNmRV?= =?utf-8?B?Y3NDeXN2OUd3K29tL2dicDdITVgyQlUzZFUzTkFmWFFpZ1FsNHRhL21KM2VV?= =?utf-8?B?cXNjdTdkZ1BQb3RERjJ0TWgyb0hFVFliRnZaUDI5S21vdVNNVnR2aitzVW9G?= =?utf-8?B?bTQwKy8zWFEvWW5ibC9oc0hieHdNUWFkd2hVYU5Qb2V1TFd0S09NSEViS3Ev?= =?utf-8?Q?zhxoiylgVZ7yRDe0wuXZ8LoBt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0879887-653e-4e6e-e4be-08da5e84a044 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:48:14.5159 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kBcfg54tH01mvknuD7gps5K58vlo/jgTF8N2NPdrS1+AI/P54PgACJciVGOrzLAmFg5CC6KJBkGLmecDFvIqQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 When a page table ends up with no present entries left, it can be replaced by a non-present entry at the next higher level. The page table itself can then be scheduled for freeing. Note that while its output isn't used there yet, pt_update_contig_markers() right away needs to be called in all places where entries get updated, not just the one where entries get cleared. Note further that while pt_update_contig_markers() updates perhaps several PTEs within the table, since these are changes to "avail" bits only I do not think that cache flushing would be needed afterwards. Such cache flushing (of entire pages, unless adding yet more logic to me more selective) would be quite noticable performance-wise (very prominent during Dom0 boot). Also note that cache sync-ing is likely more strict than necessary. This is both to be on the safe side as well as to maintain the pattern of all updates of (potentially) live tables being accompanied by a flush (if so needed). Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- v4: Re-base over changes earlier in the series. v3: Properly bound loop. Re-base over changes earlier in the series. v2: New. --- The hang during boot on my Latitude E6410 (see the respective code comment) was pretty close after iommu_enable_translation(). No errors, no watchdog would kick in, just sometimes the first few pixel lines of the next log message's (XEN) prefix would have made it out to the screen (and there's no serial there). It's been a lot of experimenting until I figured the workaround (which I consider ugly, but halfway acceptable). I've been trying hard to make sure the workaround wouldn't be masking a real issue, yet I'm still wary of it possibly doing so ... My best guess at this point is that on these old IOMMUs the ignored bits 52...61 aren't really ignored for present entries, but also aren't "reserved" enough to trigger faults. This guess is from having tried to set other bits in this range (unconditionally, and with the workaround here in place), which yielded the same behavior. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -43,6 +43,9 @@ #include "vtd.h" #include "../ats.h" +#define CONTIG_MASK DMA_PTE_CONTIG_MASK +#include + /* dom_io is used as a sentinel for quarantined devices */ #define QUARANTINE_SKIP(d, pgd_maddr) ((d) == dom_io && !(pgd_maddr)) #define DEVICE_DOMID(d, pdev) ((d) != dom_io ? (d)->domain_id \ @@ -405,6 +408,9 @@ static uint64_t addr_to_dma_page_maddr(s write_atomic(&pte->val, new_pte.val); iommu_sync_cache(pte, sizeof(struct dma_pte)); + pt_update_contig_markers(&parent->val, + address_level_offset(addr, level), + level, PTE_kind_table); } if ( --level == target ) @@ -829,9 +835,31 @@ static int dma_pte_clear_one(struct doma old = *pte; dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + while ( pt_update_contig_markers(&page->val, + address_level_offset(addr, level), + level, PTE_kind_null) && + ++level < min_pt_levels ) + { + struct page_info *pg = maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, + false); + BUG_ON(pg_maddr < PAGE_SIZE); + + page = map_vtd_domain_page(pg_maddr); + pte = &page[address_level_offset(addr, level)]; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |= IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } spin_unlock(&hd->arch.mapping_lock); - iommu_sync_cache(pte, sizeof(struct dma_pte)); unmap_vtd_domain_page(page); @@ -2177,8 +2205,21 @@ static int __must_check cf_check intel_i } *pte = new; - iommu_sync_cache(pte, sizeof(struct dma_pte)); + + /* + * While the (ab)use of PTE_kind_table here allows to save some work in + * the function, the main motivation for it is that it avoids a so far + * unexplained hang during boot (while preparing Dom0) on a Westmere + * based laptop. + */ + pt_update_contig_markers(&page->val, + address_level_offset(dfn_to_daddr(dfn), level), + level, + (hd->platform_ops->page_sizes & + (1UL << level_to_offset_bits(level + 1)) + ? PTE_kind_leaf : PTE_kind_table)); + spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:49:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:49:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361185.590563 (Exim 4.92) (envelope-from ) id 1o8hzI-0007lC-6x; Tue, 05 Jul 2022 12:49:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361185.590563; Tue, 05 Jul 2022 12:49:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hzI-0007l5-3l; Tue, 05 Jul 2022 12:49:08 +0000 Received: by outflank-mailman (input) for mailman id 361185; Tue, 05 Jul 2022 12:49:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hzG-0004qq-UW for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:49:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dac05ebd-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:49:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 5 Jul 2022 12:48:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:48:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dac05ebd-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lNyE7v3chRcGj64NGPKufaH6CbJF34KKW+tHF9qxH/GQY0eL6Xsl3ouu90sTOqw5lf/l4jpgPtM94i+WKLoEyq7gLNYq92kywDmW/eFyLa91b4G38VkKbX5l5eT12NdWsQ4CIzLAz/ze4uEPkfZOWS1PQHKUK55lc95qE5gz5pO6cQ1WvTJdamWtzku5ZxBfd2YHdKOEQJP+yl0HEcklSYejXnMexrQmYHlZTu5LIndN0emerwzHkDQL79aMT0tRz5hCSolmxqJkOljp/80G4cL6VGg/GS4aq4yjwiPAoRm1aJ9aGcOZWnIFp3/B33eyZeiubDkAsG/FdKLiFyOMhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DfKw4w4lT3delgxvxQXi2BzPNtcGD1oKtqm/W3kaSWA=; b=c2X8o/Sekjzrf0stbeZ7jI9m5Nuk5spR2KsJzzoKGvXerUBy9MmzJ4ADzHXzKGCAJzMBhLVB4hO1uyJa32RbXgDD2/MmJbATAiNXllgPF6QT8X97apQqIYcA6yFJW4nL+r/soP8JSlP5Cd1dsnz5BQi7cFUZDoO53NIeVyL91LOTHEtVrI3hoNYURr9y2FnOr2Vlo9pbfSRfyFY0v0g77+Ou+ZcSa/1C1EqAvExBjMlay5LgTxtjK3QPZjCrVfCyqR5N4I73bTwA0yREMuB9DJ1j901eSs/J9NrNt7x3T+QDFtzHe+YVAQ+Xchtle4qU4nYWStBKQO30fR6C9wikRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DfKw4w4lT3delgxvxQXi2BzPNtcGD1oKtqm/W3kaSWA=; b=a2GQY/tJQZQ15VYjci3kY95TaZtoH7PWhwSHnyrgSGSq9zZnwy3ahcRQ42IzporjuYDtdSK9M3f3zqWyMMOZiqllaVpB4O0Fn2/fRK5Sza5uh795I3OvlC69wsSo5aT/+yyxhc+A3zJIya9Zw39/J2gv5qUPjwyfAOx92cja2H3TAzcyeLvgFot106l+BaVU4Hucqt/k/e1OHx+9b4OGdceprDRY1grxkvjZGghIh/S74QckCyyVLvf0xWziWwkSHkXuXCd58eUNZXHpeV1GnfffSMgDVfKjsLtCnZV/WkoiE1kTo2qQ5gKBr4TK/SqXTcwpG3PfWq0rfqV0rKz28Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9ccc854e-9a8b-ffed-cd68-d26e5b3347ec@suse.com> Date: Tue, 5 Jul 2022 14:48:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 12/14] VT-d: replace all-contiguous page tables by superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR07CA0002.eurprd07.prod.outlook.com (2603:10a6:20b:451::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e55dbdf-6b89-4732-8292-08da5e84ba47 X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A4lGjZNC1UAdRi7/Lz8b8r3tDeahl14AN8+1m4EZTeKVh6bKcxgEt0NK/Zl9f79oIGsyVNBbPLS+mX96zzB/jypTZKgu5VAg9s/bukjCzq/7f42g1sCoAnBMlJ/l9fx9vI6woYHkmV+3bI4wH5+gxcmB2L5oRrbt9zMBbt4lU8dPS2lwrWyUv8Q4eNy+q7TwyixfOsJcd2dsHXUkC5CElNUj10w6q0Jflr8KsUr8oLle6RfOHamd6jNZLmwg85HRacfG3uDTq5XddeNyKqoV5qYBmjZh1AiI7QhoMa7dcpu0EydTzOJdOHI1JSwhhuigmsgIOqPFNbFCGN+Fu8RkVr9Hd1UJbaxhYD13yD3VrsibABhx/h4tH6iwcg01CyOhrZu/ovviS4+pr5BiLWT6cTNK5FeDJWsO2h1hNVsPu0aXW47pAB4up/N5qawLkxReP7DDOaylVjcIkNoDJwYoMITI43gnv+qjqHadw87Lcr+L4IqXjBiGTRuqpRYc8bA3N49ej84ivV8r6Yz8/0DeZ2HpAFhZq0G/qC6HLaeOiUPGglKcO83npesczTmXKf5RpyMKPT2iMFkUSPJDRTNkWVIwnNKBszZsPb0rpNwaFZMEGcYiWLoakHZy3zZgMIX+uamFnsyRddyKBxE6COXkcR8Ovkiac2jSdsWV9sI9NFEIEfjDlLEzfZp5oMgeUSNo9KMPNFNk6xIrsvESbl2cQpd8YcAROH1iQk3XqYuWY7ov41qz0shTFfny5vyEP0/14PcbIGjkCqm/Dwjq7n40mRZ+Yor12QEhh6QCb128xb9gYffnyLna8PVmsIfUJ0r71pKPY9edcOw+fdFLCfqxCpRsDSAa8abCqHrwQ3bWbjs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(478600001)(8936002)(5660300002)(6486002)(86362001)(31696002)(2906002)(6916009)(54906003)(316002)(41300700001)(2616005)(66476007)(66556008)(66946007)(186003)(83380400001)(6506007)(31686004)(38100700002)(36756003)(4326008)(8676002)(26005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlY4U1ppQnIrVXF6T0JtNGJrLzdIM0tMYktQZjFMME5TMTJxUzE3YndxbUZ4?= =?utf-8?B?K1VLZGNQZ3NCaXRlRERaSXM2L1BVdVhudDN1cGQ0eGFvYlhuWkhQYnFjV2k5?= =?utf-8?B?ekQ3MUJIMWRrQ2xTd2ZvK0ZxUXM4bytrZHltVm91a295aU1hY0MrNEN0Ym9R?= =?utf-8?B?d2l6cTc0R2dEV1NDaWFQdEtHREpwNHJNWFpZUklXWjZxc2lVWm81d1o1MWY1?= =?utf-8?B?ajByMmZsSFhSRHdrL1R2djFGblQ0OXp2SER2RnBJcWdVQVJPN2lDTWlOZ3oz?= =?utf-8?B?dzhLZVVIQS9EWFYxSlNuZ0Rvamtsc0ZBeXFRRDBiczVEc1hPaWhVbTU0djlj?= =?utf-8?B?TWxySW9vSldRbDdHZitiemNhT0RZZUQyL2dpMk96U3k3WnNNRHVvOVZuRTZz?= =?utf-8?B?aFdtd1RFa2hLM2FEL0VCNEtQSWdUVzQ2S0FIKzlIc25sUlRHQm1uY0Q0YjB1?= =?utf-8?B?SnQ1LzkyYWZ5d1QxcGxTS1RNNHI2dkh5MndwRnlEdUoydmdiVHR0aVBjYnZU?= =?utf-8?B?cFJOTURnVC9xbmIzZDE3YVJBMG1ENE03OGFFU1gxaWM1UUtPWlJ4Z3B4OGhX?= =?utf-8?B?bXhxejRQaXR3WUlFRXlUdm85aUJxWnlGQ3Z3QnpRWEVvY1VsbEhWTEJMZHp3?= =?utf-8?B?TFhmV0d4RWNMeGg5WENpVjltaWl5Z3MzMmV6NVpsa2o5bjc5TnhEUjVVeHE4?= =?utf-8?B?RFpuUjEraGZBcEkvRWZPd0tjc055bVdkUUpRUXdZc3RGSVl1YW5jeks2Tmpl?= =?utf-8?B?dDlSbytDa2RCM0JtRkdLZlNzanArRENHQUluWjdENU9pUm9vekROUzcwV2hi?= =?utf-8?B?QzVPQTR1TUU5Q0F5WnlBb2IxczAzNGhmOXA4b215RWVnYm1JZVplYitJVWdt?= =?utf-8?B?UiswS2hwNHFqWjYrNE12T25iZkl4YllGaHFzeEVWc1ZBVk1YaS9UbjFJWVg1?= =?utf-8?B?bERFc1pYcFp4ZWUrSDNYcExVcng2Z1FSRGlBRHI3a0VQdzhzQlh1aG9ZK2xG?= =?utf-8?B?TXRkZEVWMldCMEhuYnBSUVJnbmgydWFIN3JLVW9zbWxMTFdPNHh4eTdtOTNp?= =?utf-8?B?VnM1RFJ5Wkd3bTI0RkpBVDBsTEd2UGpEaVozbnZIWlF5KzltUzNPN2szSk92?= =?utf-8?B?dnhWNkJEWGtISHlrY2pMTG9NWFNXczE0Y3pwWGNVVG5ZbkVWVXlDTjRXeGpo?= =?utf-8?B?QldQQnV0cWhJdlZneDR2Z2UvS2VucHZ0aFZBaDVPUnlqWHNIU0dwUGp6QWZx?= =?utf-8?B?SmtZbnZhcDN4TTJ3am0remI5VnpoUDZpblhtaFVIa0NMTS9NVEJBUGhlNDJX?= =?utf-8?B?TzU2T3A1dGNkNXpLMnZ0c2JsSDg1SlhlSXRrdktGVEdFd3VSalRkcVNvRDh3?= =?utf-8?B?LzVWNkJTdVJwVWlJbENNaDNMTmF0cFlQN04rZE9zMm4ya3lUODRnNHoybm9X?= =?utf-8?B?b0trbC91TzVicFZ5aU9Da1ducTNEUWVTSXdOWmdOc29IeFNKa29qcWVYWlVK?= =?utf-8?B?QWtQY1ZDa2FYYmJjMDE2L0tNUkpLcmowa1k4aUl2azhDV1NPU3Z4V1JyZ04x?= =?utf-8?B?aEFkQ2JYVlkrM0hPSDZIYVNOUGVrNDBLYmdmK294UUVsN21zZlBTblpiVFg5?= =?utf-8?B?NUJ4a0w0b1MvdFhGamZYS09OZGdPRktmYVFMemZPdmxiSnVyRXFGLzgzaG1Z?= =?utf-8?B?Tll0SDFnb053SzRuVWNJTHVjTU9sVEpyUUxOc1FDeXlxdG1YTmNnK3lSTmYz?= =?utf-8?B?TGlOam5sd2JjNXFlU1pYa2FLd1J0V01iMUFwMjRQN2g4THRMQ0JDVHc5TXlP?= =?utf-8?B?VjVjNmxGbG5NdEk0SWYxUSt6WXZUR3BYNm94bGp3RWlZcERjMmU1cFRpQVNG?= =?utf-8?B?bjdMQlBHUFpZR3J0RXA2M0xCckZvNzA3NjV0UTZtbGs2QVIzMGo4RUdDWmxG?= =?utf-8?B?cW01UWVoWjVBcDk3MDUrS3o0ZHdMd1hrNE93ODFxdUd1UFdYekY4eGs5bVRV?= =?utf-8?B?STJQT0E1UjdWYTVLZTBWR3RuUldJd1MxRzNJSEVYSklJbmxyWnl1a1hiZjBi?= =?utf-8?B?K2tsNUFJMmNLS0IwRExvdEhaV1Z1SFRhdXpHdURaNUc4SzE5NjZDYTJjZ054?= =?utf-8?Q?gxJfPliNkOCHbPMmPnJRklMuQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e55dbdf-6b89-4732-8292-08da5e84ba47 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:48:58.1695 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a/P730t/Ty3wWI2HCtYrrhIqfjqs9HJdxxrVBRxIk6Ikt+HNBTKaSGyNtk42DFhjvsHF6aeIwRQ8vlIabuAeOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap for whenever we (and obviously hardware) start supporting 512G mappings. Note that cache sync-ing is likely more strict than necessary. This is both to be on the safe side as well as to maintain the pattern of all updates of (potentially) live tables being accompanied by a flush (if so needed). Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- Unlike the freeing of all-empty page tables, this causes quite a bit of back and forth for PV domains, due to their mapping/unmapping of pages when they get converted to/from being page tables. It may therefore be worth considering to delay re-coalescing a little, to avoid doing so when the superpage would otherwise get split again pretty soon. But I think this would better be the subject of a separate change anyway. Of course this could also be helped by more "aware" kernel side behavior: They could avoid immediately mapping freed page tables writable again, in anticipation of re-using that same page for another page table elsewhere. --- v4: Re-base over changes earlier in the series. v3: New. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -2211,14 +2211,35 @@ static int __must_check cf_check intel_i * While the (ab)use of PTE_kind_table here allows to save some work in * the function, the main motivation for it is that it avoids a so far * unexplained hang during boot (while preparing Dom0) on a Westmere - * based laptop. + * based laptop. This also has the intended effect of terminating the + * loop when super pages aren't supported anymore at the next level. */ - pt_update_contig_markers(&page->val, - address_level_offset(dfn_to_daddr(dfn), level), - level, - (hd->platform_ops->page_sizes & - (1UL << level_to_offset_bits(level + 1)) - ? PTE_kind_leaf : PTE_kind_table)); + while ( pt_update_contig_markers(&page->val, + address_level_offset(dfn_to_daddr(dfn), level), + level, + (hd->platform_ops->page_sizes & + (1UL << level_to_offset_bits(level + 1)) + ? PTE_kind_leaf : PTE_kind_table)) ) + { + struct page_info *pg = maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + new.val &= ~(LEVEL_MASK << level_to_offset_bits(level)); + dma_set_pte_superpage(new); + + pg_maddr = addr_to_dma_page_maddr(d, dfn_to_daddr(dfn), ++level, + flush_flags, false); + BUG_ON(pg_maddr < PAGE_SIZE); + + page = map_vtd_domain_page(pg_maddr); + pte = &page[address_level_offset(dfn_to_daddr(dfn), level)]; + *pte = new; + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } spin_unlock(&hd->arch.mapping_lock); unmap_vtd_domain_page(page); --- a/xen/drivers/passthrough/vtd/iommu.h +++ b/xen/drivers/passthrough/vtd/iommu.h @@ -232,7 +232,7 @@ struct context_entry { /* page table handling */ #define LEVEL_STRIDE (9) -#define LEVEL_MASK ((1 << LEVEL_STRIDE) - 1) +#define LEVEL_MASK (PTE_NUM - 1UL) #define PTE_NUM (1 << LEVEL_STRIDE) #define level_to_agaw(val) ((val) - 2) #define agaw_to_level(val) ((val) + 2) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:49:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:49:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361188.590574 (Exim 4.92) (envelope-from ) id 1o8hzZ-0008Em-Eq; Tue, 05 Jul 2022 12:49:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361188.590574; Tue, 05 Jul 2022 12:49:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hzZ-0008Ef-C4; Tue, 05 Jul 2022 12:49:25 +0000 Received: by outflank-mailman (input) for mailman id 361188; Tue, 05 Jul 2022 12:49:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hzY-0008Ch-4s for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:49:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2083.outbound.protection.outlook.com [40.107.22.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4de258d-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:49:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5252.eurprd04.prod.outlook.com (2603:10a6:208:cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:49:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:49:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4de258d-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHTxO8oiTIlf3EUsEu+MSDZtWIZt7liqp3B3rF44SbRPfIFtRbLU70b6YNCBTmjAb0nDBgUvv7NUZx6i8x2gNLuIu2a67IEA8HN82+jF8inZKKweLBTOuKwlIevbGhE54NoKWX+SuPqONNFDQMzBR3A07Wk03JFtJ+eamFBMxTe13WZqaAX6j4NPnY/1brGLiV5y4/Iq1EOKCl/dqAyomwFxnVAR9pyQu8zXbNlNWCLh3f1mFCuGJcln40Vdi4VB/WZI/Uzfh0qmRMAFf6ZIGK3/43ZT9v40i7IFdjCwRL8ZXvcziEB/64aiOVSW+wBrWhN1ZyUCkVOHKZ+f5dwcPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iNSivqMUGJNXw6YV9IuRH2YBw0MQFLGrycARpWhZOTo=; b=LGFzy6lUnK0WjANKIyVvI6isM45ojcwuUEqvClC/F4+LgUss59P54pwbfNL0/F1vQ5FEXYoZYuDllW992OUZ5cKfs73x7MmkPr63ji1ggOwr4QCj+5sWwHvrl4PgIyW/kzgHrC3pCzPP7Kon3aOFkSw7gdMyL422X4T6e/y0fYaLxJkPuKMHZQOW2TIfV1eyhjTAusJtR+6oGC3PfX6wZWUUL6PkDnHd2ZsyA+EKM7MG0vfbinfCOapMiuU7hJGWtRlMT6JuxKsVEdSWLfkzDE9jbgGkB6MzBXPrlQ9poyna5YCIHKqw3tUyJyU4kzJkT1sHXCVdJx/eEttKevjIUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iNSivqMUGJNXw6YV9IuRH2YBw0MQFLGrycARpWhZOTo=; b=s6ipQUoUOHaut3n5ecjaui4pE5MhrkaZ5vomBt/vnuZ46bWfUzBQj8r0xxZkdoZBjKXdYo0IJbTCqKynnE/eZlF0xRe8ZMGSiEnnA5fiytvuzTIuLat8hggResZNa+bFG64aiRryDHpstlG1iBhoiZ/O71d0HovHpBczJhJ9KG11Bse6YJkNJb/y6U3aIPbW5uStbujXNLc0FoaCDd2aD850iBeQQKdMg2vO32FfYsbwF+hL83yVIE0yg0P6N0ngdP2A/S0jnzkOep3SxnjbuKMsKNEE8xw2+yXlohcJTpAT22JeajEXT0jzLPVwIlN9oP949F4AnhE7JZdeow3ilg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1dab40d4-75f1-566c-f982-610013db72f5@suse.com> Date: Tue, 5 Jul 2022 14:49:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 13/14] IOMMU/x86: add perf counters for page table splitting / coalescing Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0056.eurprd06.prod.outlook.com (2603:10a6:20b:463::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 10b99f2f-b887-4222-3cca-08da5e84c88e X-MS-TrafficTypeDiagnostic: AM0PR04MB5252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EYz5e7wS4dm/y06BLPEKKyf7a1huWjZ+0ZN7JqWcwsMXz+0h0WIzn3ETYgnSirXCiztPHW0pkCWhtn8fvkg76IsBq1MptrKTY1G2oFFqxOA/A0XdgOl7cW36VY1bJfx/u27L0RXhltR6088Hmzvu67wnwdtbJxvoHoAmoOW72+Ee6eZ95LIUjRrhZIvqjBX6U+O4uYXwENEMPhrPDYGMG56m4oU2/qjtCQH5iq0JTS7rA8gB3wku3Dk7dbCGYrare0/DU7k8GBN0Q6g5IvDRvTFTDGc+oHDTUaWVqeLxqXMCYYRYmtcIoSEMH3z/EmXnnqIRhw96dYaXfIDwnQFgpkldx3NBMKs1joZHHpcuIj0XlQ3Q8FfQyxhCDb15IVmTu64lcPQe9EZccKQfJSeSr6SwA06rRIIMrlvWfoOoeg3A0SrkRnCFZ05ZZZyzlpNQ6L6FMkQGRPO4EYey9alOcNUyDzJQKxgnIY73Ufh35W95RkYB8mg3e5ER+/Rj8X6/Bw+Aq1xlQ+5EZ+Nkib8rDwaQslljw0gzGWh+rYJtVB8UnNwwUakt8zumd03M65Ha8q2D9j63pTLR3ijDrEoRR6noqavHBtnG7DNg0hy9SZLpwwZGbNUVoKQsmywdAMC7hhcmJaYLsgPSXnUohvLq3JTa1hyUO5CTKRLgPGMm+QJSjwFurhOP9HH3VRjxQpX8IYyuSiOUP9mJ5jfkyQii6dybkqdCzKo7eIs/BG/1zxsx+vQVLFZUWsY4qyiWq5Qk+Sq1vMFF3tnvUeEeW9p6LbOYFL6frIe2qVac7+cUsE09ikxEgebZqUxsXXYbng1xOOAjpcl48yLnCLJMksNZdxh5oCoDeoG3HWfR6wh4KGc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(478600001)(5660300002)(8936002)(6916009)(54906003)(316002)(86362001)(31696002)(6486002)(66946007)(4326008)(66476007)(8676002)(66556008)(31686004)(2906002)(83380400001)(2616005)(186003)(6512007)(26005)(38100700002)(41300700001)(6506007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RjZHMzh1TjVsOTBMTXNUcTlCUWNxWmVIK20vNW5PeDhsaWdtQjdaUzJaWnBl?= =?utf-8?B?VVJRdXpNVG1wSlFnb242K0FqeGdNZ0piVmxlZ0haTlVLQ2FaZEFMNk5Oc0Zi?= =?utf-8?B?NHlHTWp4REJaSzNUZE56SGYxT3Nod1ZFNWUxaER2V2lyVitGQzBYektXZmFF?= =?utf-8?B?ZlRoZXBXeGNxNFovTzVHZEljbnpiWUxKMEZ1REV2Q0orZVJBWHRoWTFnK0Zy?= =?utf-8?B?eXA2SVJwSVZnK1FLS2xPUUx1WGR1VFQ1RUtaeWMvTkRtODgrMTM0Um1VVlBq?= =?utf-8?B?dkthdG9iMkxLcGJndFdyVUtvYllIMEgzaU5Vbm9wS3dTN1d6cXpRWVlnRmpz?= =?utf-8?B?RS9Ucm4yWnVGT0FKOHl2eXdWYlhhM1drU0VLc3J6NkN5RHJqMC9IaEtpdHpG?= =?utf-8?B?RlJibWdmeGcrQXd3R1Exd2IxY1lGdEdXeW9LcFpIRjdHUEVCa3NmeW5Fa29Z?= =?utf-8?B?UXhMYjVkbnJuVkZMbkJuV29KMFNpUHV0K0dvNDJqbVAzYktHMkJzdGNMb2J4?= =?utf-8?B?dVJlOStybUdGZTliWjUzSXZXVlRlUG9pdGU0T0lrd1FNN09JZnd5S25wWlhP?= =?utf-8?B?NGtIUHdMbTYzQzdwdXpDbk1nKzQ2a2FBUkhCMENXbHhjU1h0NGVyTWlQSzNG?= =?utf-8?B?WUJZOUhEamxYNGdxN0xnZlpORjlPRkNjamVBb1daRlM4Znh2SDh2c3ZJME5Y?= =?utf-8?B?aFQ4Qzd2V2RWbDVFaXoxTEo3bEFGdG83NjlhZXUzSXpEeXdaVDRCdnR4QjJU?= =?utf-8?B?TUI2Q294V05EMGQzakdLdFpObVRsbUI0Y01SclNHdDF5YUZVaVM1aU9yUUYx?= =?utf-8?B?Yzl2ektoM2xaVFcrblFHbGpYK3VhQ2h5OC9JWS96ZTB2Y1NUOTR1OEw5SUhj?= =?utf-8?B?TEZ6WXoxUXNMZG1TN2dnVEJUQThKTjdrZTRKcnhtTWw5RVVYakc3bC8xSzlJ?= =?utf-8?B?K0NxaWxINTZHR1dNRVBYVWRFdXRMR1ROT2lvcXRuVlFLY0YwVkZ2c2tEUXY4?= =?utf-8?B?VU1ZV09NSVM2eXlLMGs4WmNqaU9LUzZsTmJnblFUR0xtcHdDcXZsTDZmN3Y5?= =?utf-8?B?VDMweE9Rek5rMUhlSUpLMU1yaGhVTTl6SmxGYVZrZnpscmZnSFhqdm5KRW1l?= =?utf-8?B?Sys5ekRVeFd3Mlowb2dOLzJjaXFJNGFmcG9SQTNtRmdVejhyK056VkZLbWlX?= =?utf-8?B?Tko2T0R3NTJqSDJRN1FuUDZCRXlONmlLL3ZzNTZ0UnZyWXFySVhrTDFPKzI4?= =?utf-8?B?TkdpTE9xWEt5NGxNYktHWFg0TTJyMnd2bkxYOGZMb1d0WVBta1pWNmQ1RHhv?= =?utf-8?B?SGt6MFBEVjBkaWZ5VG81VGFldnkwZm5rbUlqYmNKVWZUZWxqd0UzRGVwemoz?= =?utf-8?B?V0w4QjFpSkJ2ZTE2Z2N2dkFaTlJFM09PcTk5VTNUY2pDSk9QU2JWbVp0UTdT?= =?utf-8?B?OGZDZlA4VmQraGttSytlMHVIVVRHRVZXSzllSEhRSEZWQnVuN01jOVhsT3Nr?= =?utf-8?B?UmxBUzlVbmxMc29GVEpBbWI1TXNYMENTKzd3ZE5uS2praG91eXlrVXFyajli?= =?utf-8?B?M1VYbHl0Tk9jWHg4WEdMQndocnQ4ZkNNWTl5UnVhdXFId1IySXA1SjBwMXk5?= =?utf-8?B?VGQ4M203Q1Nhc29JalFKN0ZXWFp0MEVvNzVNN0RWUWtDNEJCK1FXZ0dkZ3Y3?= =?utf-8?B?dXlNb1pKT3hOZ3loRTJoYk8wTGxqOHJ2MVZmcDJwMUFZVXhiY1J2bHJRV0lG?= =?utf-8?B?Mmw1STM2Rm1YcFpKenhUZ1hhajdWVVZqeGwxckpwVll6Nm9BNFNEZjE2WXZR?= =?utf-8?B?eEgwcm9kdGUrUHJHZWFmQ0JVaUZIcVFMMWU0Z1ZHZFJsS2F1VDYyS2NMYWpx?= =?utf-8?B?emZ1ODhYQ3dOTzROUWxzdU1DeW5KTWlMVHpBOUhEMTMxOWZaMExaYmZBN0V0?= =?utf-8?B?RmJlVmI2K1orSDlRcEpkTW96UkRhQm1KRVRMc3VpT0NVVUdGMkwvZmUzMlBJ?= =?utf-8?B?K3VrMG92a2JOVC9JM0E0V1pIa1dkV2FxcW5DNTRCck1sd2xmZWhqRy81eWRs?= =?utf-8?B?bmQzdlI1UU9rVmxnRnJJcTE3SjM5UWllKytncjRscmFKcGtEVEFncHZxampF?= =?utf-8?Q?vZiZuX+BsnNtQVhLndJSxip/7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 10b99f2f-b887-4222-3cca-08da5e84c88e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:49:22.1211 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6Z7w6Bo4bNWlyWAU6VKAKWwdcrckDfNA2bgfq7pYiclwDdkKDqmaJQPGMPwAvftYspGa2c6Q7HYx6CIrusDEdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 Signed-off-by: Jan Beulich Reviewed-by: Kevin tian Reviewed-by: Roger Pau Monné --- v3: New. --- a/xen/arch/x86/include/asm/perfc_defn.h +++ b/xen/arch/x86/include/asm/perfc_defn.h @@ -125,4 +125,7 @@ PERFCOUNTER(realmode_exits, "vmexit PERFCOUNTER(pauseloop_exits, "vmexits from Pause-Loop Detection") +PERFCOUNTER(iommu_pt_shatters, "IOMMU page table shatters") +PERFCOUNTER(iommu_pt_coalesces, "IOMMU page table coalesces") + /*#endif*/ /* __XEN_PERFC_DEFN_H__ */ --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -345,6 +345,8 @@ static int iommu_pde_from_dfn(struct dom level, PTE_kind_table); *flush_flags |= IOMMU_FLUSHF_modified; + + perfc_incr(iommu_pt_shatters); } /* Install lower level page table for non-present entries */ @@ -477,6 +479,7 @@ int cf_check amd_iommu_map_page( flags & IOMMUF_readable, &contig); *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } spin_unlock(&hd->arch.mapping_lock); @@ -543,6 +546,7 @@ int cf_check amd_iommu_unmap_page( clear_iommu_pte_present(pt_mfn, dfn_x(dfn), level, &free); *flush_flags |= IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } } --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -404,6 +404,8 @@ static uint64_t addr_to_dma_page_maddr(s if ( flush_flags ) *flush_flags |= IOMMU_FLUSHF_modified; + + perfc_incr(iommu_pt_shatters); } write_atomic(&pte->val, new_pte.val); @@ -857,6 +859,7 @@ static int dma_pte_clear_one(struct doma *flush_flags |= IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } spin_unlock(&hd->arch.mapping_lock); @@ -2239,6 +2242,7 @@ static int __must_check cf_check intel_i *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); } spin_unlock(&hd->arch.mapping_lock); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:50:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:50:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361196.590584 (Exim 4.92) (envelope-from ) id 1o8i07-0000WX-P3; Tue, 05 Jul 2022 12:49:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361196.590584; Tue, 05 Jul 2022 12:49:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i07-0000WQ-MO; Tue, 05 Jul 2022 12:49:59 +0000 Received: by outflank-mailman (input) for mailman id 361196; Tue, 05 Jul 2022 12:49:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i05-0000VQ-Qn for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:49:58 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f909813b-fc60-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:49:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 5 Jul 2022 12:49:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:49:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f909813b-fc60-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KO26Cn7V0S6ZGzioixxnZR/I/ytsg17vRBX4amzpMwYzNFgj5p9M8VrHITft0qvweorL93Z03M4mG1JwsoOrIWDov1KWd1x9W4SW+EpCXyAZn2eA+poRjekciM3Q/mXzlMyxzyfRecKY5DXF0AkOLk4UUCG8yksApvcM15UJKw7NBUyS3BwR6bQU0zJU71catuFxLAMvmlkkcyOQ2V+H/KdZgW4symb2X9twjyDpeTP+4Ed2IoNdjWu/TrGv8YXat38tJqW0sfNn30Sa09uKbOWsunsRFxZM0YIxudxsWCEa+LQ9V/oVEzJhD3QRirCU766Dydao+37TZE897eJV7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aNGQdoucDFou5j3M8E7Hd4miL8kBXhKfjN3w6aHaDIs=; b=iihD0+AumewRSrE30RzfNzlvQ2lfvQRp54rH6FemnK3k+l8LyoEX6OSrKM1frAcqu0A0Z/wqYOFlsOD1zIfoxIa1O/p4hT+ja+EFQvFvAoUSPgOCMF6Iupasw3lyZClhblNMEVAPY2Iqg5XnBYqESezT2V4FUorbVuCJFdskTrXHeL0OrH11cDsNXSaLAql94YdJG/i9Ei6LnRJD3yKIn16SaZwMz2aojOfQxa4L+cTwuBGM3xdcNFa4Frz6Ye/dCY1InPcgEzclB71UXR7NNkbw7G+hvJroC3XoTrc6pbSkDdOS3DsuoG71NP7p0V5NTHRr+dP224ROcocw3E1PLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aNGQdoucDFou5j3M8E7Hd4miL8kBXhKfjN3w6aHaDIs=; b=0Fw/nQxsZiIk0D+cu2W4jLQwglfG7LCOWoPv4IYP3vsyOJio/YqNohwoGQanjo6TLEpyl4PXt/mO7deHswNrV2PAeTIRKk/iuAcrOIFutLVuwbOyJbZxSso4DU8L/YK7Y4g7Wa+2PEGh5RpV79vJ8VX0Aoy2qxTNSRREi0++lmDOXF0gZNY13FLa/Ewdpi0IqPyizPL/yzigc8xf3cGrvGurC3li2N2UjLfRlraSDP+uqAXaIxfVlist2j7A4VZQ+HmyDR5uMVBxbiv7V8V5RwoTNpYSshxRngJYu6NvIoTAW7X1kjivV/NyZqUzDCW4amEXLl/CDlSnAgf+BuZFog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <20b9d343-fe6e-b5f1-1ad4-6795aaae0fcd@suse.com> Date: Tue, 5 Jul 2022 14:49:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 14/14] VT-d: fold dma_pte_clear_one() into its only caller Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3456e26b-3aad-49cd-3cf6-08da5e84d75f X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iF33EOjItENqFGKqIXi5TcQ83IEGIyfDsHTmB7jqBdHZ76fWJWO7I1q5bWYdvynKG2QHG1nuyhs8L+tMa87I1DwfZ6Cn+UpDk6eU/ZA91esCaV+EvQubTcyA2cHTOXN/aFhBTgTxQY4Pm6GtSu6nyJmZmEeRQIt4/stPIvY7R2u8/pcoT6fEvMO/Pf1bNcVy4aiMnqnuDzxJhgWPSSXz1C/9zSAalqRxV3un0O6t2lGu3xLgA4N4BV9fZ1vvHfWquQftA8VXQdmqvIemu8ItMHVZbUUYE93dM7P4+yf7Qv9ayAQB+X+xKFi912eHTQXNB2zv4aHiaOVR3ooYnOxwH0peqMW+lc9FNgc+KRtyKrTb+XWfCRqM20AwRc1GBa+uYILGRcnkr3mRvLx4TKc9T9o2bUIXhM+Z7doSM2cUIQ40+MFru2yzuMO27Q/wB60yiml1Fr/ATUGMUaQpxbZnlDtXx50cwoCd4hC8q5/MpiU6N60xbDscnMgV2uwPOeIOAqenXeZPubBbOeW+wcC4WpsD2unQCJVq5i75vo+NPY44RnpLj3BRfYvWlWLhBYaWqU0VTCI0vwdCiApnJm/ewzmnNdVhAWplBYLkfvKgHZdq+kQmnvsKF664kKntTVAVBimRN0V6ZoL2v0qzFEEXPNIVC6W0mNuunKWNuSJ5Rjdjqt/XTKzEJn2YTK8ZJQB2RVugWvJ6OEbG/7ydMDN37Jx+yXHeJ3fQK0ssmu1EtjkURZWh3EzYX3Gxk1nzeAhupZ85i0HqCiJmrE1VH6V8TMv1k5axCOtpF7/hrDBFJMwCSq68yCtSyeOgjTPZLCUPZVHP5Xy9k3m/4EvRv42fEA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(478600001)(8936002)(5660300002)(6486002)(86362001)(31696002)(2906002)(6916009)(54906003)(316002)(41300700001)(2616005)(66476007)(66556008)(66946007)(186003)(83380400001)(6506007)(31686004)(38100700002)(36756003)(4326008)(8676002)(26005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWxjc0haTFRrc3pzZjVETHJ5eEFXSUE3UkVJYjg5WnZoaDErVDhEdXdOOVpN?= =?utf-8?B?UjNMbHpPbWc2TytUS0x4UUVQMTJmcWM1blhaaDJMK0lINk9SVFcrVlNYSzBo?= =?utf-8?B?ODlaZTNtdXVxbFVzMElkZGEzbWdJbDNmUzRVV3VJczN2QlJCeFNKNWZjemw4?= =?utf-8?B?SDJ0bWhuNHNMUjZaYW0zNndoZnIzNXM5YzVRZUZhTGptaldvWWpEYlhHQjlK?= =?utf-8?B?M2NNdzI4a0RNZFVnWkh3bHl0Q2RSUDN4V1ZOZkNJejRHbUZpU09DeWtNc0FX?= =?utf-8?B?blNSVENNSWRONXhpUjNaeXdnWGpLcUI3NmQ2TloxQWpGalhGYkY5YmprNHcy?= =?utf-8?B?c2ZTcStWMFgvellqSm55VlgxckE0QlY0QktZQllYaURFYXpMdVZIQTc4SGJG?= =?utf-8?B?R1JrUENBNzk0WTJ6U1pDVzVaTGM0d1FNL3dqTFFDbWZ5dG9QMUlMZE1YUVd3?= =?utf-8?B?R0JxdUhjY0RsT3dSRlZvYlMyM1RjVGo3S2JNMFdpZ01NUTdiUFF3eGJLbWtw?= =?utf-8?B?VE9mQlFMT2JDMHpjYlhpYUNJTTYzZXdFRXlRNndFV21JZHpDLzFoU1BHMjdv?= =?utf-8?B?U1l3cjJDdzVrd1FPdGw5cE9UbjRheVNHZG1HTnZ4SzJtNVVXQllFWU5CTUxj?= =?utf-8?B?eFUwMXRXUjdKMkhMTGg4WGpTNWhTcklnTFpNVGpERDdDdzdtaXR4cnd1MmVC?= =?utf-8?B?dnpDekxHK3ladXZkS291UGl1aU5NMTF0eHdCTVhoOENNSlg1Y0FoVHM2aFF3?= =?utf-8?B?cmFZSjg2Sm1rQmY3YlJqVHREU0hLYnFHL2hPQmZVRHlsbGdEOG1pUlRpaFVH?= =?utf-8?B?Wjh5cHpMd2F1aFFHSy9jelRLUEIxeElGWU5sSjNtS2NpeHlFMHdBd0ZJNS8v?= =?utf-8?B?OXRYdW9Na0JlR0FSTk9vNmVib012S1pJVE9LVk9JNTZ1cWJPTm95amVHc3ZS?= =?utf-8?B?Q0cvMk1OQytMeUJ1akRpYnNMYkNxOG5Rc0REaWt5dklqMjhZUXJCc3BKdFRW?= =?utf-8?B?bkN2WVFtdC9jUWRKS05Qb1lGS0ZhK0l3dzVoUURHeHE2TjdvUDhPcjBkR1Mz?= =?utf-8?B?OVpMTjNLZUwzY3lObVdSSlBLSzJleG91YkJUeFplRTd0ZGZjWi90SkhWdGVk?= =?utf-8?B?amFBUU9ma0l0bnJJalA3cXJDOHJqUExSVmo1N1BCVzYwVHh4cEp5d2dqeG9T?= =?utf-8?B?VWFEL1NmMmltMWFvQTBDakUrVHp5c0JuRVIxRzQ0MDIyVGZKbDVmbzl5NjB3?= =?utf-8?B?SEZBZHQydXpCQXl6cjFpck9FUTlRcUJyK2pCY3A2T1VCNjZnVzQ1Tk5EOEhP?= =?utf-8?B?bW5KaUxHL2xBV2Ywem1EQ1ZCVUxET1dYVlZscDdZWk0zanY3Z0xhM3hFeU1l?= =?utf-8?B?Mm13eTdpYW1BTjB1N01QUjI1Q2puQkEwQ0RhQjNQZTJFa0JZbkFhYnEwME5B?= =?utf-8?B?T0tMVGQxeEFsRW9SMWpZeUdBVjZkMnhOUWltNXM4VkEvVERmRXRBYUtWZnZz?= =?utf-8?B?ZS85cVd4QnJYcDh6TjUvTzRxalFHdmppOS82Uk5hUktOSzBHUXNoSnUyVm5w?= =?utf-8?B?eW9iZEowVXJpQUlhck5nbW1CYU5WeTc0VzJvSXljQ2ZTWnZDb1pNSVZCN25D?= =?utf-8?B?OEtWcVVxOGxZSE1RWWxtaFFkb3o1cERZMlpnUEZWQy9FQy9wQzh4cmplcTQv?= =?utf-8?B?bnRURXZRa3hORER4Mk92TGlOMTV4cUl6bmw2SFZLTDhlbUZzTVpRbU1scTBx?= =?utf-8?B?anRRcDZRYmw2bVpyanJYcE1MZlFGWXNkMkRBNDhPejJsZTluVjlPNnFjS2tH?= =?utf-8?B?Z2V5SzNIYnZ2NkIrbDd0eHFWUHd5YSs3NXlXeXJCQ0dCbmt6Z2hHeGdKTC9U?= =?utf-8?B?OVo4NWhiejIvNHl6bUJ2c01ZdWFyNDZqY292TlR6UkUzdk80ODlhSWRJRUY5?= =?utf-8?B?RCtmLzBxZ0xkTXVpcUdtYUhYcm0ybmZWNWZQSko1U2xpZjErbzR1a2FCRi93?= =?utf-8?B?YXlZTk1RZk93clN0bDltYnBxMnRKOXpFMktndE43UWh1Ymp5em9KcXl6Ykgx?= =?utf-8?B?ekdiL1VTcmYxMWxQbjJWSzZzc1pGRXJZdVRXT2NabWpwcWNBc1IvODVEQmh4?= =?utf-8?Q?fGRuhWkMfni6ncXW3oGM1xESs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3456e26b-3aad-49cd-3cf6-08da5e84d75f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:49:46.9633 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Pw3aC+QfNz/3D79Y4nvJ0ki+itnp+r6oCrvgvudQ8Cn1w7FvhLRWHomb40pwb19AG9cpsm6b+L9+Z+wQQN/rgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 This way intel_iommu_unmap_page() ends up quite a bit more similar to intel_iommu_map_page(). No functional change intended. Signed-off-by: Jan Beulich Reviewed-by: Kevin Tian Reviewed-by: Roger Pau Monné --- v5: Re-base of changes earlier in the series. v4: New. --- a/xen/drivers/passthrough/vtd/iommu.c +++ b/xen/drivers/passthrough/vtd/iommu.c @@ -806,75 +806,6 @@ static void queue_free_pt(struct domain_ iommu_queue_free_pgtable(hd, mfn_to_page(mfn)); } -/* clear one page's page table */ -static int dma_pte_clear_one(struct domain *domain, daddr_t addr, - unsigned int order, - unsigned int *flush_flags) -{ - struct domain_iommu *hd = dom_iommu(domain); - struct dma_pte *page = NULL, *pte = NULL, old; - u64 pg_maddr; - unsigned int level = (order / LEVEL_STRIDE) + 1; - - spin_lock(&hd->arch.mapping_lock); - /* get target level pte */ - pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, false); - if ( pg_maddr < PAGE_SIZE ) - { - spin_unlock(&hd->arch.mapping_lock); - return pg_maddr ? -ENOMEM : 0; - } - - page = (struct dma_pte *)map_vtd_domain_page(pg_maddr); - pte = &page[address_level_offset(addr, level)]; - - if ( !dma_pte_present(*pte) ) - { - spin_unlock(&hd->arch.mapping_lock); - unmap_vtd_domain_page(page); - return 0; - } - - old = *pte; - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(*pte)); - - while ( pt_update_contig_markers(&page->val, - address_level_offset(addr, level), - level, PTE_kind_null) && - ++level < min_pt_levels ) - { - struct page_info *pg = maddr_to_page(pg_maddr); - - unmap_vtd_domain_page(page); - - pg_maddr = addr_to_dma_page_maddr(domain, addr, level, flush_flags, - false); - BUG_ON(pg_maddr < PAGE_SIZE); - - page = map_vtd_domain_page(pg_maddr); - pte = &page[address_level_offset(addr, level)]; - dma_clear_pte(*pte); - iommu_sync_cache(pte, sizeof(*pte)); - - *flush_flags |= IOMMU_FLUSHF_all; - iommu_queue_free_pgtable(hd, pg); - perfc_incr(iommu_pt_coalesces); - } - - spin_unlock(&hd->arch.mapping_lock); - - unmap_vtd_domain_page(page); - - *flush_flags |= IOMMU_FLUSHF_modified; - - if ( order && !dma_pte_superpage(old) ) - queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), - order / LEVEL_STRIDE); - - return 0; -} - static int iommu_set_root_entry(struct vtd_iommu *iommu) { u32 sts; @@ -2264,11 +2195,17 @@ static int __must_check cf_check intel_i static int __must_check cf_check intel_iommu_unmap_page( struct domain *d, dfn_t dfn, unsigned int order, unsigned int *flush_flags) { + struct domain_iommu *hd = dom_iommu(d); + daddr_t addr = dfn_to_daddr(dfn); + struct dma_pte *page = NULL, *pte = NULL, old; + uint64_t pg_maddr; + unsigned int level = (order / LEVEL_STRIDE) + 1; + /* * While really we could unmap at any granularity, for now we assume unmaps * are issued by common code only at the same granularity as maps. */ - ASSERT((dom_iommu(d)->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); + ASSERT((hd->platform_ops->page_sizes >> order) & PAGE_SIZE_4K); /* Do nothing if VT-d shares EPT page table */ if ( iommu_use_hap_pt(d) ) @@ -2278,7 +2215,62 @@ static int __must_check cf_check intel_i if ( iommu_hwdom_passthrough && is_hardware_domain(d) ) return 0; - return dma_pte_clear_one(d, dfn_to_daddr(dfn), order, flush_flags); + spin_lock(&hd->arch.mapping_lock); + /* get target level pte */ + pg_maddr = addr_to_dma_page_maddr(d, addr, level, flush_flags, false); + if ( pg_maddr < PAGE_SIZE ) + { + spin_unlock(&hd->arch.mapping_lock); + return pg_maddr ? -ENOMEM : 0; + } + + page = map_vtd_domain_page(pg_maddr); + pte = &page[address_level_offset(addr, level)]; + + if ( !dma_pte_present(*pte) ) + { + spin_unlock(&hd->arch.mapping_lock); + unmap_vtd_domain_page(page); + return 0; + } + + old = *pte; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + while ( pt_update_contig_markers(&page->val, + address_level_offset(addr, level), + level, PTE_kind_null) && + ++level < min_pt_levels ) + { + struct page_info *pg = maddr_to_page(pg_maddr); + + unmap_vtd_domain_page(page); + + pg_maddr = addr_to_dma_page_maddr(d, addr, level, flush_flags, false); + BUG_ON(pg_maddr < PAGE_SIZE); + + page = map_vtd_domain_page(pg_maddr); + pte = &page[address_level_offset(addr, level)]; + dma_clear_pte(*pte); + iommu_sync_cache(pte, sizeof(*pte)); + + *flush_flags |= IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + perfc_incr(iommu_pt_coalesces); + } + + spin_unlock(&hd->arch.mapping_lock); + + unmap_vtd_domain_page(page); + + *flush_flags |= IOMMU_FLUSHF_modified; + + if ( order && !dma_pte_superpage(old) ) + queue_free_pt(hd, maddr_to_mfn(dma_pte_addr(old)), + order / LEVEL_STRIDE); + + return 0; } static int cf_check intel_iommu_lookup_page( From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:50:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:50:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361201.590596 (Exim 4.92) (envelope-from ) id 1o8i0f-0001xt-6A; Tue, 05 Jul 2022 12:50:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361201.590596; Tue, 05 Jul 2022 12:50:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i0f-0001xk-2c; Tue, 05 Jul 2022 12:50:33 +0000 Received: by outflank-mailman (input) for mailman id 361201; Tue, 05 Jul 2022 12:50:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i0d-0001xL-Q3 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:50:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i0d-0004JR-1R; Tue, 05 Jul 2022 12:50:31 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.237.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8i0c-0000CF-QI; Tue, 05 Jul 2022 12:50:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IFM1tQAZdPrKjkRGc+JdhGaKY0PIEFYs4qE1xcicQKI=; b=UXD0pkTUqMLkU7/HypNxRBawj0 QMGpg0+I03/31QRGrHiMIrqN1o4Wz7CVG8J4g2Dit3UTRnzZeveR53aHf7gHIP4oAyo2hrYtyokQA cfHeMs1X7wzw3KsNJi0DX9PzkmxA6TUHIAg1fgcyeIFReiuMRr7ab7HTs2FZaEfIjQl8=; Message-ID: Date: Tue, 5 Jul 2022 13:50:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/7] xen/common: Use unsigned int instead of plain unsigned To: Bertrand Marquis Cc: Michal Orzel , Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Juergen Gross , Dario Faggioli References: <20220627131543.410971-1-michal.orzel@arm.com> <20220627131543.410971-4-michal.orzel@arm.com> <4ee1fbaf-9d31-d28e-cb8d-f330c6a1923f@arm.com> <32242AE5-AF31-4AE1-94FC-4375E9CEE007@arm.com> From: Julien Grall In-Reply-To: <32242AE5-AF31-4AE1-94FC-4375E9CEE007@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/07/2022 13:07, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 29 Jun 2022, at 11:52, Julien Grall wrote: >> >> Hi, >> >> On 29/06/2022 11:46, Michal Orzel wrote: >>> On 27.06.2022 15:15, Michal Orzel wrote: >>>> This is just for the style and consistency reasons as the former is >>>> being used more often than the latter. >>>> >>>> Signed-off-by: Michal Orzel >>> It looks like this change was forgotten when merging other patches from the series. >> >> I noticed the same and was going to commit it yesterday night. However, it is technically missing an ack/review for trace.c (this is maintained by George). >> >> The change is small and likely not controversial. So I guess we could do without George's review. That said, I would like to give him a chance to answer (I will commit it on Friday if there are no answer). > > Just a gentle ping on this. Thanks for the reminder, the patch is now merged. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 12:51:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 12:51:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361212.590606 (Exim 4.92) (envelope-from ) id 1o8i1f-0002g6-Fh; Tue, 05 Jul 2022 12:51:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361212.590606; Tue, 05 Jul 2022 12:51:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i1f-0002fx-D1; Tue, 05 Jul 2022 12:51:35 +0000 Received: by outflank-mailman (input) for mailman id 361212; Tue, 05 Jul 2022 12:51:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8i1e-0002fF-DQ for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:51:34 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32b1ecc0-fc61-11ec-a8e4-439420d8e422; Tue, 05 Jul 2022 14:51:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3089.eurprd04.prod.outlook.com (2603:10a6:206:b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5353.22; Tue, 5 Jul 2022 12:51:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:51:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32b1ecc0-fc61-11ec-a8e4-439420d8e422 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsjRHB8fAJzzaVtsi0vI4ftteJvfcM3PGASdlaOgt32SJM+jJP7ep6x93PN7j0FtaElevGjjV23KuMfKIOtFJn3q2uef/ZqfjtFd4DexnKkT8cwtM0i72buO7tkw426i6TUfTYzAqEVdnrArFT0dX+qZ8T9bY2Hot1m6QqONChaanbdIn+gOWLwcrYBk8MIQfX4oyT8TlY/4mUhoHLFsR73eMK9JPyu1RcaARrPAKQA8SsY/0+tJ4z9TEmRxI34/+2kZZz9p4/uIFQUf+LEDTcFqqbr9fJEAnKNgkZqXSuaLlkQVFIpdSFovoukqcQVnwIN73DUSognVGIZd6CF05w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qJN+mR+PAwJlyoU8lO+l9qqi0anunK/pXx4zylTd/KY=; b=G1TDMhT64Nee1aAEF9bikrkAP/KPZVg8sjtGgfjAiVkvQtb7iyIk6zYd2fAb4Boruhj54AwcL9bm4y4KSu3Zes59Og+dCkkWeuh+UOpPqWLVGTYGNaMwOfqn6Lezoa43TNLaViIpsPyj4tL9de+5+/sYdNoLmxtTOShUxVsnNUMgizKiOsdb54GRNfnslcjdcWfyju2wv6ai62X1iUlxnptwPK50w0t1+c3+XZKSKWLTU+Iv1IbYIwXkR5EizQJDiX5ny6UE/5BWfIxIlQj1YafpO4lPSwl4V0LOxsuEKrsM76ffgH7J5V3bPstCRNPZPklrQJJWVnrppIE0kaGsQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJN+mR+PAwJlyoU8lO+l9qqi0anunK/pXx4zylTd/KY=; b=IFRFBDJ4fSD4mIcsCTblS1Bi1K13YUY89y1uzncyCeorbP7+Xe2rcYiaX4bbT4LKkICW2Xb1FNs/0pjzvy2SJGPhU8kH9w7acktR2SxlxtPCTn2Puu7/hQkMx63LlnD1aSmjILv5EmHaqCsSImEJJ63ALNnD85sRHnzDdx2lyQHmxNOwCx7ZfKmI8ikDCj8l96w2TDF3rxWvhuggOP1te5lUJWxFnVuhDfoPOq6X2aNX9V7el0Gs0dlbqIVrD/McyM6Ao3yS2xOkt4Oown4q1VfAODhiC5HkgrPI4rvlm5kpNVg8BSCLV87VMleQ6yh2yPRGIPsG7oTDZXB+Qmd8HA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 14:51:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v7 00/14] IOMMU: superpage support when not sharing pagetables Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0127.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d198bfb3-9b6b-46d4-da67-08da5e851281 X-MS-TrafficTypeDiagnostic: AM5PR04MB3089:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8V4o7klWHQ/Ws2WRJGc/AK5wJyQ37F/RhbrQYXG9rbki72jhJWwZbf/+H+83fcjRQ8Dk3pDjWdlZOCUKjh/THfgKZ+YPUXagxeUdBahEW6fKbrB8a9zVsRHIex5mn1YoTcNkPGeWXCa1nt2x8qCFB+o5VN6ZGZ9XSkH7gnyCiabSesBUEyhJ+6wJgaRwHPpOcFypxgWPkLPAIuURHte30r/lv4qQ4VLUr0hyQ6OpukxMdvawl+e+YlTxKLkM9FOTbUhAh9T61UCAVwaqu/kJvmonCZSt0e5brtqFImfU/Q5wzaxzj4FxMmd2NDQCs3GdVwb9IdvaaqJjd9sZNmdYGrJx/8UvjXOkefXCIn7Qfk+aoBRmi5IVMM99FvolpWHDj903jBBUlqNrmt44E+wvsKrtGbs6F/kxW4Fnh6z6KtmW3bq4T7T0p3PZfVz/g+6PJUtD/Yo1MhV+YtVIThfdU8Xdu1e9XX6EXL2fnKbV8cI8RHCDYlGNQP9KOLr1PtD1LYg9sYrAgr04uWQke3kP64joihuxiIMw1eYM9RMpNvaryrqSKFq78VTvmj89b8JU/RwOqhOv8hFFMT5GT3kET8n9ecLjAAr3JuJ7Gs39o16ZdBHS3MNoeKBjxYR3/zYn8aRFxIaMv1Thz0YeD0PxytN457BOaxzujI27+miT3V4cPRaZqDi/TRdM9LMjw5e+ieeEn2Ud4hQZ9JxQ55VC+jVJDgAtleh17uWa0iBiqi04SBW3awv1fgmd5Wq5NCsu1/mP8XYYF0oFW2uzcyKl6cKKcacD79kU9Lf1cgOog6NKNyMfrl2oL1KhB+858nBVfKTabGCf//9ykvj2P/LK/U+yXVAsgHyd8CZ68gklQL+rGt2yczWjukEUJKVQ/FgI X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(478600001)(8936002)(5660300002)(966005)(6486002)(86362001)(31696002)(2906002)(6916009)(54906003)(316002)(41300700001)(2616005)(66476007)(66556008)(66946007)(186003)(83380400001)(53546011)(6506007)(31686004)(38100700002)(36756003)(4326008)(8676002)(26005)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3ArNWFPSzkwcUs3dEFoYmlGeHhFUmRZZFJlV2dXQVR2S0Ftc3NvSksrQzVz?= =?utf-8?B?R1VzZWJSeFlNSm9CRFpiZkt2cE1zWDYyR2c4Q0NqMGVqK1pseU5McUZ0Q1c0?= =?utf-8?B?aE1CeUFzT3V0MnRIYjNWdjdwQVY2RERudCs4czRHYXVjRlZwNEJPRmxLR1dy?= =?utf-8?B?dkgxQlR3SGJ6UWkrTkVpWEQvTGpiUlllOGRUWDFBWnNodjhoNVcrL0p0cnlr?= =?utf-8?B?bXN6YmJhZld2R3Z5L2tPYkFoN25VSmxCQzA2SDlZcGdwTmRiamthSTc1RlZu?= =?utf-8?B?dktSdXVCVXF5ZmZOTnBRYW1QWDB1T0g0aGp6SmVjSHo0MUxYMVo4U21hM21N?= =?utf-8?B?OTZiay9RUGYzNmNDR2JJaU5naG5YM25ZTjVHR2UzaDVKRmduZlBSZjdUdzh2?= =?utf-8?B?blhrTmt5ZmV5c1BIby9xS09mc2VSK0lWTnBXdjVHN0N4NEZFMkowbDkrVmFS?= =?utf-8?B?OVlnU0tDWFlDRDJkR0dmNEVDaVNNTE1zOG1WalhEcFFSUU05Qm0wTFVQU25E?= =?utf-8?B?YzFQajVFdTMvcmpHWStMVG1VNEdWYWxPeDZKMHkzQ2cvWUNEbVpZbmRVdHJ1?= =?utf-8?B?UjZYb09NaE45OTRZeU96Ly9RNzFrWEdtNG8xUDZnaldIaXYvRTFOU0w2OVlk?= =?utf-8?B?ekZuamNZTEVJK3R4OGx6ZHV0TnZlanZlNVVJOWVINDVyODNKNXd5L3VicnVM?= =?utf-8?B?V28rUDNZTzBoZHdRT2EwNG1zTWZRYjMxUWkycnEyd1Z4VTlQRi9PVWpuZDky?= =?utf-8?B?eTA1K21wSjZaMFNrUzFmM3RYVTJwc1ZJVGJIVWIrOXV3dkFjS29CR2R4L0ow?= =?utf-8?B?dkNuQ0JLYlEyVzRaS3NMNTFXd01RR2ZyWkxKM2tqdlhSVzBiNUpSeVpEN3ZK?= =?utf-8?B?eXMzdWpyUXdWSnhEdnNGdCsrbWJlOUtGd3BJYld0VklQbXBvdmtibkhFT1FD?= =?utf-8?B?M0U0TWVSK3ZMTXBjWlRWRmFIZHVPMzAvdE51b093ajBIQTE1aXB2cHhRa1A0?= =?utf-8?B?c1paM1VBQUxEWDNmSnNLazlRRW84WG1IL3F3VFc2OHFEYTRDdkw0L3lmc2M4?= =?utf-8?B?RENmY05HaFVvR3BoNWJrN2RHRHNKTXpCbFV6Nk5xMG9MMlBDd2ZoSEh4ZDRN?= =?utf-8?B?c0FnRWJvQ25zUDUyd01RSkdMVkJ0OHpKZkNmWm5RQnNjL09rK01TRXhPaTdS?= =?utf-8?B?b2VqNWlyVnk2NDVUSnIwNmRHek1JZXBOMzg4cDFCUFpIUGtIYWtZMWxyZnBx?= =?utf-8?B?NXlTNWJWOHo2T3BqZG5GTWpXaTcwOXJVUTJMa2pxNG9FVXNGbmp1TmduaXBB?= =?utf-8?B?SS96ZjNTRHFkRTg2dm1QTllhbURtODliTlVqdHh5RDhBaEd1aE1xVm5wVVRr?= =?utf-8?B?RXJ0Q3hRNmcyREZTTlR0RXBIWmkvRWFWSCtzT2tJODVQVitGMXFaQU43N0RY?= =?utf-8?B?RThjTmI2Wk1YL1J1dU5zd0FlU2lJcW40WnVKMmZjbHhkQWVsSkgxRU9tOS8y?= =?utf-8?B?ZjRqR1YxVTM4SHBkWFZab3MzeXJuVHZOU0NQNkd2aHIvZm9YeWJhaHNKcXJL?= =?utf-8?B?Qm1zUWgyaHM0VlFlQnRrejZkelI5SzNpU0V2SXJPcStmbTJjcEF2ckplQzZF?= =?utf-8?B?OWY2TUw3Qm84SElPdFNqZ3RjWE1URld6ek1HR3ovQnY4d2I0UVpXTTZ5bnFX?= =?utf-8?B?V3JuUjRiNlBwS3dBU0FnTTRkaXVzdmUxbnpVcEFxUnBlbWh5ajRSalk4c0hG?= =?utf-8?B?T2t1QUt2V0tCK1RtaG5uc3VLTExzSzZhbUV3QklpNTJMZGxCS2dlVmdBc0FC?= =?utf-8?B?em1IVGdEMzVWTzJyZE04T2x3OWFOME5WS2VqYjh4MURqUjU4Z1p2ZEg2Y0hP?= =?utf-8?B?TEczSit3dklERDZZc2N4TGR5QVI4ZTBQUHZiMEYrZWxvR210Q21lRlQzY2dn?= =?utf-8?B?bzY0cUJDY0dJYmZLNEdkMjB2UEJZeFNBWVliOE5NMXR4WjZSaDBJYjJ6NHYx?= =?utf-8?B?YWlxSUFPeWNnSEF0Y2NDYXJ1YnB5cy9rdTRhN1Z5TU5lUE1GZ1VaZUkrcnlV?= =?utf-8?B?bEdzOGFvMkJIQTlKT21sQTQwWTBXdW5jbzY1aWd5UkRLaDAyRys5TTYzQXU1?= =?utf-8?Q?EKBxoWKv2yZ8StaEe+gT5ookO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d198bfb3-9b6b-46d4-da67-08da5e851281 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:51:26.1913 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +c88wqrz6MfYjTQwL+05MWVeGDbYH0LC0XSxotzlNH9gegHunuDFlBarGVgvb4w1yqoQPb9I/7o0BSZnfsAMDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3089 On 05.07.2022 14:41, Jan Beulich wrote: > For a long time we've been rather inefficient with IOMMU page table > management when not sharing page tables, i.e. in particular for PV (and > further specifically also for PV Dom0) and AMD (where nowadays we never > share page tables). While up to about 3.5 years ago AMD code had logic > to un-shatter page mappings, that logic was ripped out for being buggy > (XSA-275 plus follow-on). > > This series enables use of large pages in AMD and Intel (VT-d) code; > Arm is presently not in need of any enabling as pagetables are always > shared there. It also augments PV Dom0 creation with suitable explicit > IOMMU mapping calls to facilitate use of large pages there. Depending > on the amount of memory handed to Dom0 this improves booting time > (latency until Dom0 actually starts) quite a bit; subsequent shattering > of some of the large pages may of course consume some of the saved time. > > Known fallout has been spelled out here: > https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html > > See individual patches for details on the v7 changes. > > 01: iommu: add preemption support to iommu_{un,}map() > 02: IOMMU/x86: perform PV Dom0 mappings in batches > 03: IOMMU/x86: support freeing of pagetables > 02: IOMMU/x86: new command line option to suppress use of superpage mappings > 03: AMD/IOMMU: allow use of superpage mappings > 04: VT-d: allow use of superpage mappings > 05: x86: introduce helper for recording degree of contiguity in page tables > 06: IOMMU/x86: prefill newly allocate page tables > 07: AMD/IOMMU: free all-empty page tables > 08: VT-d: free all-empty page tables > 09: AMD/IOMMU: replace all-contiguous page tables by superpage mappings > 10: VT-d: replace all-contiguous page tables by superpage mappings > 11: IOMMU/x86: add perf counters for page table splitting / coalescing > 12: VT-d: fold dma_pte_clear_one() into its only caller And I realize I've successfully screwed up numbering here. The order of patches if correct, though - it's just that from the 4th patch onwards all numbers are off by 2. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:00:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361227.590622 (Exim 4.92) (envelope-from ) id 1o8iAO-0004NT-Dq; Tue, 05 Jul 2022 13:00:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361227.590622; Tue, 05 Jul 2022 13:00:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iAO-0004NM-9b; Tue, 05 Jul 2022 13:00:36 +0000 Received: by outflank-mailman (input) for mailman id 361227; Tue, 05 Jul 2022 13:00:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8hyn-0004qy-Ur for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 12:48:38 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c96e42c6-fc60-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 14:48:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5252.eurprd04.prod.outlook.com (2603:10a6:208:cf::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 12:48:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 12:48:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c96e42c6-fc60-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ajwuKEErqwOf+V2F7YvoAcykl8DqtjgQifohKABtslu2USb/UFNflYPkcQQkRj74jiZU5XEIa4DdXRiLIpcYeNFOBZVZ35JUOy1MXshtJym74vRM6Ad70fupGr9ZECSyrWYNTsexW4iUmRa3rAM8sX543gJkCUhiH48E8fJygmFSXDrpSuSlQ/vYAAkKxHMmB+v9Xk+trO81WOMMRRt5fJ6TOBpmYX/sf1JpqeiOdF5ztLLvDuTCkf/Lma/t27G5nh5K78lhBcq8J3zh8Avp5j4Ng1Uu/+c/J+PM3t8WXUv9VtQPHHdK9ni5/NdwR9kFkaJP4jmaFFYWFBbWW052Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XpBKX8iKhA8N8952sSDbijOunJ7uuUUiGIDbjZy4Htk=; b=funM8mhIJ2zr5xlbGL9FNPtmj1BQ2C23JG9GiMQhiuSz486SAf3oaM7vfYC/OYO1HEnFvZU5ivNwM0ySdbN3IEGkCHdtJ68BckWgbUZfwftwXGPYM2Ew7CEVBZqEeL0eorp7tJ5Tc6w3uhfFtd5pFjXcLC5tVIbLmSce6/p3QoHy5Y83F8ZV0PlykP2IpzqTOWZPjzKNydvepQ1UHowqJrrvNEMLg9+g3U38UP1N0m6PtwR7Ni6/pbf/44R3S8Jg/p4FBBSZuUiyEmfWWDATqzz9MwTi+R4LLTNcmrjO7QHqHY4lr8pAvLGTM9b52AMPwSSyEAwSvMndY7fv9OwayA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XpBKX8iKhA8N8952sSDbijOunJ7uuUUiGIDbjZy4Htk=; b=B49s2NSJ+fJWQjplxkhKpCQ79poQQU7FuVM7AFFA49ELi7diiJ/ZB4xx6001tRAgXb1KpRlJ7aeLf4ENFbu0pIN3MHV0ct/jdeswnQQiSbFEttue0OUYYiGlbjhSuGA3RdcOGtoz52Nhul2KMuK72C5Apmo9LIxmXW3wDPG835CukJ57tN60fB4c9woZ+iwUtroeA/lmBgauZ/d8BnakqicDNLYjTqMRn4PPQEq87v2tG0U1nnikG5iMG5BO/QfBDDNaeuNHd7Sftd4H4oC2Ii7MDdNH+9D2kQOQgrKZkaa8Y7FuNSh1lxEmcIAhbzoNwsk2RO8wUUKbjKhXBnZT0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <718906a5-8c18-530a-89f5-02e2a2efb211@suse.com> Date: Tue, 5 Jul 2022 14:48:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v7 11/14] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0088.eurprd06.prod.outlook.com (2603:10a6:20b:464::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8f85225a-3cf5-43fe-6ab7-08da5e84acea X-MS-TrafficTypeDiagnostic: AM0PR04MB5252:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uxDCH4822zfGqegMWWKTfmt9Df5EsE8dBIA0oU6ou9sJTEFON6vx83cwdpFMVv5QCW8H0PetM6mJZXNZa4IZuuQ3cG7ichVMN4AomUjFxvKbO8qr2p9ZwUaeUXx6kuss8NzWRQ0EOyze5RO/wJ5UWphZQPnZKnZbceHWmzZ2qQ/PpiO8guKtBAzT25zyg8Y4KH+UM0kBUX31s6YTwJl1Jfj1k2HJ2D0LqB2SApHC0W1HvinmWR/hnGY3GsBzxT1n5ZrRaLpBAM7L59REf7PMCfn0qFTIzBUjCvJiP0YIn/zu31CcJxSiW0qGx2zs0e5gfUhdpuoIEG+4swUa7i/94lcesp5kuEVo6kAwBYCt+PLgM07lhRKDOS+fRfV/Wf8J9I3RZiwhgnEj6870TUJ0qfZRtKkxmwQxPaQviUj5bOtln7joNN1vLmXMg7RdBJvisXllvzfVsA6Cgrq/PNj7myoJ1fBEdvS1SwmLCe2Vcz9n+EIhbX/nfVk9902huRGq0fQSO5R8Cht2aFX+mA4g/gFBRc9M1VY2sCwn0TS2RRHzH3Grxr0J1EU+/Cyd7bljYr51RYh/cd/flIqaIXmvmkJHVy1feTPufo9r/1TBJUbMNOkVUYj+wUieJ94GS6XxYzEG9xWyjdP3eiPEXI82aVPBeEIk31OeXgJxxT6lR2tQvzgH2np0+qja94m5A66BolG6SXkwqCBiI5GX8g6PDdO2+G8Epj1h/lBprf8tOppzQwkTd08PVqBvP7XXMvjJGUxcsQ77+iW1Ju4mWbEXKuMjNxvsvPG0afaWRw+yi4oXI5pF+KngAXyDIVKDS8AVcFUUyG3KV6YH/Ydyb592wkJ5ApyEJTGR4xh/yF7jfsc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(478600001)(5660300002)(8936002)(6916009)(54906003)(316002)(86362001)(31696002)(6486002)(66946007)(4326008)(66476007)(8676002)(66556008)(31686004)(2906002)(83380400001)(2616005)(186003)(6512007)(26005)(38100700002)(41300700001)(6506007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2t1SUFYUFg4TUNyQWY0MnVNWVJQTWhNNWpQejJCdkdzN0ZKWG93SWFOY1Fx?= =?utf-8?B?Szk3NDQzUThhNEZzQjZ4aWRqRDIrQjdQZHhwOEY3S3ZDa2wzYmtaNmRlSEJN?= =?utf-8?B?VHNPc0FrejdjSGtpS1lRU0ZldDhqbEhhZ2ZTc1lZMFhDbTdDZUQySFovTGkr?= =?utf-8?B?cjNROVlQVGRKT3pMQnNQQzRpaEhzUkl0a3FIL0s3amFGbXZXdEpZdnAwRFZJ?= =?utf-8?B?TnZ5Yk1aUlBlQ2Q5U3p2NHVhR1FVNGZqSmxCZ0NrWnV1aWlQa2NaU0I2aENi?= =?utf-8?B?T2M0SjVrMUhpL29RWmxmVXBaZVdJaGRhYk5CRzhSeCtwNzN6TXQzakJ3Q1cx?= =?utf-8?B?Wm1LdllJNzFiYU0ycU9iWkFpQnBLU3JzVjY2ZSs4WjVzZGkzZ0R0a3lYRExm?= =?utf-8?B?ZHRLKyt4c2h4cFk2MlFuSmZVUnRzWGcvUGFDa0pzOExtTGdraXF1YitOaHA4?= =?utf-8?B?NlVZOThyZ2ZVUjdCZ1VlcUw3ZE9yb3E2Y3Z1ejZaSzloMFo3V3lxN21tSWwr?= =?utf-8?B?NGovemNkYm1ZUHlQRDV4czBic1FUQ21rSnZlTU1BT1VIMTJOWmJOcFBvOUlU?= =?utf-8?B?dXdMNENBTjlOL05pU2tFYWExeGdXd2tWMzl6eHk4MDlQTU91T2c3aVdWZTZN?= =?utf-8?B?Tjh5WmVHTkc4RmhnelFGUUFLR0hMVCtYR1lHK3dyM1FQRUZZVUk0ajZFUFp6?= =?utf-8?B?Y0hJRG9LSFcrUzVJNzYwMEg4Q2hhK2xBd3FCa0tTY3EyVFNCRkNsSVhaU2R6?= =?utf-8?B?Qkorc1E2SXErajhHK1h3U1M4bjVoNHIwZGdRUVFKUlF4MHNIWjJmdml6OXY4?= =?utf-8?B?bmpxMEtkNTM2S3BNSmhFOWdRT1NCV29ybGNLZE5mVFJmVmswZ2l4THZhM2xr?= =?utf-8?B?ZDlZM0NwRmtkUHpnT1lRV0psalhTTEplSjlTcCtyaDZJRjZTeXFjdWgwZnZF?= =?utf-8?B?Qit3NTVHb3MzRkxPYnNtaHdUZjhQUFQxVys0T09uR2szaTg5MzB4eTZnbEdU?= =?utf-8?B?VHRZRmk5TTVObzQyL0pMdmZrdllrZk1NYnB0OVc5K3dXSzlKUnZ5M1Z4U2x0?= =?utf-8?B?aEhPSURjMWkrd1FMMFUrK1hYODE4RjFOdEJNYXM0UnkvS1dpazV1Z2RvTVVv?= =?utf-8?B?Tld3VlFxTW5scXpweFFkcDRMZFdQUUdidG04RXF0Rm10a0xLc1RWc0dBY1dT?= =?utf-8?B?V3gzOGhhVkIzUi9SR1pIMWxVWUxrYndRMWNkZ2ZOUENFZGE4WWI3M2FrOEcz?= =?utf-8?B?aUk0UjFRUGF4UEVtRGc1RW56TmJBb3hRTTBhdmJlUkhNQjF6Q3NZa2Zia2pw?= =?utf-8?B?dkRUV0hUR0E2ci9LOGhHS0NvS25kVXkrUjlkZGwxNnMxT3hWZk9wcitmZXNp?= =?utf-8?B?YjNFV0x2TGN2RE0xdVZsMWNUUDRZNnJEYzFJWnJtc0FtQXdSUDUrbFBFYmlB?= =?utf-8?B?aHJoT0NRSFd3eGRkTlBGUnpPS3dkV0c0eFBDb1NKZUxsMUJwc1JseGpwSWdk?= =?utf-8?B?YjhxZGVmS25xZFNNL2c3TzBvRCsyeHFENEVnNHZBNzRWd0NaaFlWRmQ4aTJx?= =?utf-8?B?RTZwNnd3OWh6QzliUDZyeXlzOElmVWdzQ1FtUGt3a2tuNGtEQXJoODRsSzlV?= =?utf-8?B?TXBXZDRpWDZlSUdrM1QzcDJjMkpFZ0srTXg5VzdFUFJ4d3hQK01JMjhFTE4v?= =?utf-8?B?OFp5Y1F2VUhHVEs0S2k1eEF2bkxLQVNveStKSGpnbyt3WTBFeGtTYjE3NXNi?= =?utf-8?B?V2NRRmU1OEQ5TU5iN3MwMUY0MEpIeURiWFBkemtUeE9XRk0rN2liVWV4MXZE?= =?utf-8?B?bnQxajVGeWkrQ1Flc2w2anNFMURBdVE0aXkvR20zamZPNjlMbzU2NEQrTFhs?= =?utf-8?B?cml1QWlwRlNTUGQrVEl3MUU5WjFrc0JKVmhSQkxxQ2xDeThVNGZ2alNtY2pk?= =?utf-8?B?b2UwMnBYczlKRnpjR1dJNnFzWmxUV1h5SjVVRmk3MzcybW05c1htL3gyUGdh?= =?utf-8?B?TXh4U1JxdS9nNm1MNk9TbmFaNEVkZXR6L0tUdWJGQWNFd3dwV05uSmd2Tlo5?= =?utf-8?B?QVlhUDYwcW5JOW9jZGRIaDBIeHBnbkdvNU0xOWUxTUJ4Ujl2QlY1WUx1ZWVo?= =?utf-8?Q?a2e8V2BMHpBaZoxPsCb8IqNH9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f85225a-3cf5-43fe-6ab7-08da5e84acea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 12:48:35.7646 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KQeUTZTONFt65igDhM9wTsdtbm77WfCIlCF2SJ5qPlvHvKhq+pH9fDp7QlyKyh4+yjH/H6P4zO/CPrm5hf53+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5252 When a page table ends up with all contiguous entries (including all identical attributes), it can be replaced by a superpage entry at the next higher level. The page table itself can then be scheduled for freeing. Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- Unlike the freeing of all-empty page tables, this causes quite a bit of back and forth for PV domains, due to their mapping/unmapping of pages when they get converted to/from being page tables. It may therefore be worth considering to delay re-coalescing a little, to avoid doing so when the superpage would otherwise get split again pretty soon. But I think this would better be the subject of a separate change anyway. Of course this could also be helped by more "aware" kernel side behavior: They could avoid immediately mapping freed page tables writable again, in anticipation of re-using that same page for another page table elsewhere. --- v4: Re-base over changes earlier in the series. v3: New. --- a/xen/drivers/passthrough/amd/iommu_map.c +++ b/xen/drivers/passthrough/amd/iommu_map.c @@ -81,7 +81,8 @@ static union amd_iommu_pte set_iommu_pte unsigned long dfn, unsigned long next_mfn, unsigned int level, - bool iw, bool ir) + bool iw, bool ir, + bool *contig) { union amd_iommu_pte *table, *pde, old; @@ -94,11 +95,15 @@ static union amd_iommu_pte set_iommu_pte old.iw != iw || old.ir != ir ) { set_iommu_pde_present(pde, next_mfn, 0, iw, ir); - pt_update_contig_markers(&table->raw, pfn_to_pde_idx(dfn, level), - level, PTE_kind_leaf); + *contig = pt_update_contig_markers(&table->raw, + pfn_to_pde_idx(dfn, level), + level, PTE_kind_leaf); } else + { old.pr = false; /* signal "no change" to the caller */ + *contig = false; + } unmap_domain_page(table); @@ -409,6 +414,7 @@ int cf_check amd_iommu_map_page( { struct domain_iommu *hd = dom_iommu(d); unsigned int level = (IOMMUF_order(flags) / PTE_PER_TABLE_SHIFT) + 1; + bool contig; int rc; unsigned long pt_mfn = 0; union amd_iommu_pte old; @@ -452,8 +458,26 @@ int cf_check amd_iommu_map_page( /* Install mapping */ old = set_iommu_pte_present(pt_mfn, dfn_x(dfn), mfn_x(mfn), level, - (flags & IOMMUF_writable), - (flags & IOMMUF_readable)); + flags & IOMMUF_writable, + flags & IOMMUF_readable, &contig); + + while ( unlikely(contig) && ++level < hd->arch.amd.paging_mode ) + { + struct page_info *pg = mfn_to_page(_mfn(pt_mfn)); + unsigned long next_mfn; + + if ( iommu_pde_from_dfn(d, dfn_x(dfn), level, &pt_mfn, flush_flags, + false) ) + BUG(); + BUG_ON(!pt_mfn); + + next_mfn = mfn_x(mfn) & (~0UL << (PTE_PER_TABLE_SHIFT * (level - 1))); + set_iommu_pte_present(pt_mfn, dfn_x(dfn), next_mfn, level, + flags & IOMMUF_writable, + flags & IOMMUF_readable, &contig); + *flush_flags |= IOMMU_FLUSHF_modified | IOMMU_FLUSHF_all; + iommu_queue_free_pgtable(hd, pg); + } spin_unlock(&hd->arch.mapping_lock); From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:04:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361234.590632 (Exim 4.92) (envelope-from ) id 1o8iDv-00052r-Tb; Tue, 05 Jul 2022 13:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361234.590632; Tue, 05 Jul 2022 13:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iDv-00052k-Qn; Tue, 05 Jul 2022 13:04:15 +0000 Received: by outflank-mailman (input) for mailman id 361234; Tue, 05 Jul 2022 13:04:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iDt-00052X-O5 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:04:13 +0000 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [2a00:1450:4864:20::12a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7027ad4-fc62-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:04:12 +0200 (CEST) Received: by mail-lf1-x12a.google.com with SMTP id t25so20424754lfg.7 for ; Tue, 05 Jul 2022 06:04:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7027ad4-fc62-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OPb4vez3xMWgWw9qL4+82hBZyNzYuSAh7zaT/JzSON8=; b=ASlAVWOtaH6CL3Mv7qFkf1ThrptYMTe0Y+CzgkAxWYGoI+7YZZyjbbwKqBxqz3Rpxv w1RKo36oBFV3TKr8QTm2B8Jkj+xdrR0wXsXkqP74WXjz1cKtHzBjhAPR0XszETouidsr iHTRMp1Td8qd1XbCYs8B7r4n5RnoMVOLWDeDQvfBGSjrDL/oX7SqcRtfvZAfv6rEMQSS 22WKRT3Tqp/WEOUZleYv2FP4Jdp9k0Ho2Wf1CfMXYpJ+x02CVs7DXm2x/Ob4xeEY/Tbv oRL5nWjaX/Uhwjn9MIda57x5sUhHDkZ8U+zq6B/f291hyphaLHKt8veEN1xzse2ETpHp vmzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OPb4vez3xMWgWw9qL4+82hBZyNzYuSAh7zaT/JzSON8=; b=ysoEwwWDxeSmYs0xVxrr19OPwmt0wztmpLUBJy6GnUuk+cwXP4PPYtW//Dw4yyoTSU gsoTsmHCHhIombVebHNPaEfPAKo55G8B/2QeYatPBQdx86uh4VE5UKR5cPyY72NEggOT BcN3di6TLzd+kHjIj0D3eMvpf2YFBW9ZOABiwIoYxgMZB47I/zWburXsrcuDqJ5g9/Xi /b//SkP+d6xZFicAufj6IfRl6i55tYf8LDUgE0WgaCm3DbbJ8p6o6LmUyYIpfE5ubpSA atGBBftnucJshppb4lt7yL/K7EFVC50p4ittL0JVRqfp00qcJazcsEg6uUOi4zGSZTzn YrFQ== X-Gm-Message-State: AJIora94t0mPFlCak31SYaFGCbxjdysLGGhyF0N8iUgUoJCc834GkFN+ g0Z763nxvYfAaWOCcd5AM7DoN9OoEj2/E9SPyDSVw91F0C4= X-Google-Smtp-Source: AGRyM1uDT3UhDFAUVhsyHOthe8UWUn67px+vyaPc1JMeQXZIQ0dYGcjSekxGXt0a2DwHXY4MF1KnFukwhepEAjKXdAM= X-Received: by 2002:a05:6512:2508:b0:480:f1cb:64ad with SMTP id be8-20020a056512250800b00480f1cb64admr24139849lfb.359.1657026251886; Tue, 05 Jul 2022 06:04:11 -0700 (PDT) MIME-Version: 1.0 References: <20220630022110.31555-1-dpsmith@apertussolutions.com> <20220630022110.31555-4-dpsmith@apertussolutions.com> In-Reply-To: <20220630022110.31555-4-dpsmith@apertussolutions.com> From: Jason Andryuk Date: Tue, 5 Jul 2022 09:03:59 -0400 Message-ID: Subject: Re: [PATCH v9 3/3] xsm: refactor flask sid alloc and domain check To: "Daniel P. Smith" Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD Content-Type: text/plain; charset="UTF-8" On Wed, Jun 29, 2022 at 10:22 PM Daniel P. Smith wrote: > > The function flask_domain_alloc_security() is where a default sid should be > assigned to a domain under construction. For reasons unknown, the initial > domain would be assigned unlabeled_t and then fixed up under > flask_domain_create(). With the introduction of xenboot_t it is now possible > to distinguish when the hypervisor is in the boot state. There is no "default label" which is why unlabeled_t was used. flask_domain_create() does permission checks before setting the label from the config. flask_domain_alloc_security() - mallocs domain_security_struct - sets sid for system domains xen_t, domxen_t, domio_t - is called for all domains. flask_domain_create() - special cases labeling dom0_t so it can only be done once. - otherwise, ensures current has permission to domain_create. - sets sid for both cases. - has the config->ssidref passed in. - is only called for non-system, non-idle domains. > This commit looks to correct this by using a check to see if the hypervisor is > under the xenboot_t context in flask_domain_alloc_security(). If it is, then it > will inspect the domain's is_privileged field, and select the appropriate > default label, dom0_t or domU_t, for the domain. The logic for > flask_domain_create() was changed to allow the incoming sid to override the > default label. > > The base policy was adjusted to allow the idle domain under the xenboot_t > context to be able to construct domains of both types, dom0 and domU. Your patch special cases flask_domain_alloc_security() to assign dom0/domU. You already have a config and therefore config->ssidref, so that shouldn't be necessary since flask_domain_create() can use that ssidref. I don't see a precise reason for why this change is needed in the commit message. I know you are working on hyperlaunch, but I'm guessing at the rationale for this change. And hyperlaunch should be passing in a config with ssidref set instead of relying on the flask code to auto assign, so I'm not sure of why this change would be needed for hyperlaunch. Is the issue with only having a single creation of dom0_t? Can you change create_dom()'s dom0_cfg to specify the ssidref when creating dom0. I guess that would need a new xsm_dom0_ssidref hook (or something) to hide away the flask code. But that way there is less special casing in the code. flask_domain_alloc_security() could be left unchanged, and flask_domain_create could() be streamlined to just check the passed in ssidref. How does that sound? > Signed-off-by: Daniel P. Smith > --- > tools/flask/policy/modules/dom0.te | 3 +++ > tools/flask/policy/modules/domU.te | 3 +++ > xen/xsm/flask/hooks.c | 34 ++++++++++++++++++------------ > 3 files changed, 26 insertions(+), 14 deletions(-) > > diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te > index 0a63ce15b6..2022bb9636 100644 > --- a/tools/flask/policy/modules/dom0.te > +++ b/tools/flask/policy/modules/dom0.te > @@ -75,3 +75,6 @@ admin_device(dom0_t, ioport_t) > admin_device(dom0_t, iomem_t) > > domain_comms(dom0_t, dom0_t) > + > +# Allow they hypervisor to build domains of type dom0_t > +xen_build_domain(dom0_t) > diff --git a/tools/flask/policy/modules/domU.te b/tools/flask/policy/modules/domU.te > index b77df29d56..73fc90c3c6 100644 > --- a/tools/flask/policy/modules/domU.te > +++ b/tools/flask/policy/modules/domU.te > @@ -13,6 +13,9 @@ domain_comms(domU_t, domU_t) > migrate_domain_out(dom0_t, domU_t) > domain_self_comms(domU_t) > > +# Allow they hypervisor to build domains of type domU_t > +xen_build_domain(domU_t) > + > # Device model for domU_t. You can define distinct types for device models for > # domains of other types, or add more make_device_model lines for this type. > declare_domain(dm_dom_t) > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 8c9cd0f297..caa0ae7d4c 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -182,7 +182,15 @@ static int cf_check flask_domain_alloc_security(struct domain *d) > dsec->sid = SECINITSID_DOMIO; > break; > default: > - dsec->sid = SECINITSID_UNLABELED; > + if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) > + { > + if ( d->is_privileged ) > + dsec->sid = SECINITSID_DOM0; > + else > + dsec->sid = SECINITSID_DOMU; > + } > + else > + dsec->sid = SECINITSID_UNLABELED; > } > > dsec->self_sid = dsec->sid; > @@ -548,23 +556,21 @@ static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref) > { > int rc; > struct domain_security_struct *dsec = d->ssid; > - static int dom0_created = 0; > > - if ( is_idle_domain(current->domain) && !dom0_created ) > - { > - dsec->sid = SECINITSID_DOM0; > - dom0_created = 1; > - } > - else > + /* > + * If domain has not already been labeled or a valid new label is provided, > + * then use the provided label, otherwise use the existing label. > + */ > + if ( dsec->sid == SECINITSID_UNLABELED || ssidref > 0 ) > { > - rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, > - DOMAIN__CREATE, NULL); > - if ( rc ) > - return rc; The old code returned here before... > - > dsec->sid = ssidref; ... setting the sid. That is more robust since if the function fails, the sid is not changed. It's not a problem today as the xsm_domain_create() return value is checked, but it is more robust to restore that property. Regards, Jason > + dsec->self_sid = dsec->sid; > } > - dsec->self_sid = dsec->sid; > + > + rc = avc_current_has_perm(dsec->sid, SECCLASS_DOMAIN, > + DOMAIN__CREATE, NULL); > + if ( rc ) > + return rc; > > rc = security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN, > &dsec->self_sid); > -- > 2.20.1 > From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:17:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:17:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361242.590644 (Exim 4.92) (envelope-from ) id 1o8iQv-0006kj-92; Tue, 05 Jul 2022 13:17:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361242.590644; Tue, 05 Jul 2022 13:17:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iQv-0006kc-4b; Tue, 05 Jul 2022 13:17:41 +0000 Received: by outflank-mailman (input) for mailman id 361242; Tue, 05 Jul 2022 13:17:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iQu-0006kW-89 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:17:40 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80058.outbound.protection.outlook.com [40.107.8.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d766e386-fc64-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:17:38 +0200 (CEST) Received: from AM5PR1001CA0056.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::33) by DBAPR08MB5702.eurprd08.prod.outlook.com (2603:10a6:10:1a3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:17:23 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:15:cafe::32) by AM5PR1001CA0056.outlook.office365.com (2603:10a6:206:15::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Tue, 5 Jul 2022 13:17:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:17:22 +0000 Received: ("Tessian outbound 879f4da7a6e9:v121"); Tue, 05 Jul 2022 13:17:22 +0000 Received: from 37b9d8abd3a7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7B89F784-7A70-48A8-9312-BB9D54BE5D15.1; Tue, 05 Jul 2022 13:17:16 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 37b9d8abd3a7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:17:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PR3PR08MB5692.eurprd08.prod.outlook.com (2603:10a6:102:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:17:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 13:17:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d766e386-fc64-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gfw2faiirlJP6pQf7hNHLAxW/pqSDgEg62MoId6vgaciBaZhC3y0hUIJpkhZxAuyWAndJqb0x/fab5+ELMV9IyjF90nenQPnB2Jlz/6hRUYXJQd78un1GJHxkotjHxx7h5u1g9dZd0K4C41Pf58jvygSv6hbueoQc/b1yxbhFgmrJI/Q7eDhgwNGU/Vnk8xR08qKZl+423mL8R0Aw0YTgoNDf4FSIqzGYkcil8Y7VzrUcb2nQtT8om4o3Ms/6kKuqQ1BR7aXBeUgqnzP15XkzrYkb47n/qkYKvk7jXWtcX4+Xof2clfHlJhveGnzsHzS6z4y8/X8FIP0dnoYMJjl5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e4Kp3UtAAcyb8jUYsXp13qyiYcmqvqX4xjmdZ/twp54=; b=DtEPCJQy6275K4AL2yaBtABF8x9Cbu0jxEwI1iflL7gOcNawX7lEq3f6RPfFZd83+svUO/23/i1SZvft5dTsdr1hx1r6dJA0VJ5Wyi6yF/lv/pC/J9oK6JkAwU5zMkr460Kp9jtjElTbwkUrVB52eetlVGUv79U6BaIoPu/EHD+9SucGR604GbIvQdi+rPbLh6LeckvDvqMLY6hGHsjdZ2BSi1wACmjuZjFAWting5H6pPfyQzgqzJtVz/RKAvSfyZeJQDUViZGk11dLF56y0Rz1PeRTloFEtLM9+3T6uJB24XR1GbAtJkdjRysXcQzoJ3Mk9wxf+wbElpfrIyQMig== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4Kp3UtAAcyb8jUYsXp13qyiYcmqvqX4xjmdZ/twp54=; b=9dlgdQT486xcgiaSgXE/1HKVzM9BQGnESurkYRQOtbDul+hNL9YY/E+ZO4r19U1BtITabm0alDvqPL2D0OYAF2kEz617CjJPusijWdgObP/p4kYlgwUmwULQjsDB9liHwyFz8k/qn/mYBn/tiezVO714g46+6I++PJzkux4p2TI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a9aa006c8ed5a004 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TRq6ET49r3zAEhO7I8S0x/L7u/R/QOK5pK6yerSfV5Bb7wgkimPTZekPzH2GGyUnPa28vOS1rnkIZZsUc4cZ+S9wv3aPzwy/xy0OinKAf24d58yLDAFNs6mJj+j2ozV08iomjiA2EDi/CzSrYY9giFK9LJmQf1+TAqSY5mM1tMyJJ0aErfICvFS86Zc66RG/CbrUuf/L2KQ6iXyyP9pAMaInulfIjvoYswMuVxE5Z3laK49ZyKJ7liG2FDyL34GtNP9Ol1N6LZUZd2l13e6X5Mm50ccw0byqNAt4UmS/qQfrqF47KWx97Ix1H6dGklyG381Unxb0QLTpG/cp6smkyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e4Kp3UtAAcyb8jUYsXp13qyiYcmqvqX4xjmdZ/twp54=; b=isOMUWbnuKjujAIo4FbivbOrhWm70sgtwnQOgQ79LFpG3QlGIrtoAw8aDCovfqWmX23gf+O0caz3fRehaMHUPdnO6EZ6tyXW776eP5nvueKUcMYak+N5Thf/gbGEqjhI+HafM0yFy2ME9MmHSH+u8GWS4L8GV/chJIo91JTrq9tv925CMFbHdriXlWQvteG9Fkm0hGj1MkhGcCuIEnCFVCaByumMdSHZsEPJdE6nl/50Nv5w4i3+KnE2SScZ4Nm97QuqlVq1GUfTwNYCWrj6gZIrQJsGUWouz8z9JgMofR/dEJ72unTNa3KGgq3U/L9Lq7fwj3hbWYoq6AggvPBtbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4Kp3UtAAcyb8jUYsXp13qyiYcmqvqX4xjmdZ/twp54=; b=9dlgdQT486xcgiaSgXE/1HKVzM9BQGnESurkYRQOtbDul+hNL9YY/E+ZO4r19U1BtITabm0alDvqPL2D0OYAF2kEz617CjJPusijWdgObP/p4kYlgwUmwULQjsDB9liHwyFz8k/qn/mYBn/tiezVO714g46+6I++PJzkux4p2TI= From: Bertrand Marquis To: Anthony PERARD CC: Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v3 12/25] .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc} Thread-Topic: [XEN PATCH v3 12/25] .gitignore: Cleanup ignores of tools/libs/*/{headers.chk,*.pc} Thread-Index: AQHYh+Q4LI8v0EVuHkalG0x3wwvCIq1v00wA Date: Tue, 5 Jul 2022 13:17:14 +0000 Message-ID: <2ADCFCCF-0B10-450D-91AB-E399A13A83A3@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-13-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-13-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8623a4ee-5be9-499e-754f-08da5e88b263 x-ms-traffictypediagnostic: PR3PR08MB5692:EE_|AM5EUR03FT033:EE_|DBAPR08MB5702:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1q6zkuE+bB109QzYbQLVn8CRzpRNR44NlE5iMCZigbbE60zPmVaC166rUemghgp2h6NZDsysWe3cQLWAzThLGUOSLpxUWHqS7Ncn7N9Fiv+yC6uCUMQQTpdmdwgPUMJfPoS8MAb61BLgHHIoxYqOPF5edP0Cpgj3/keunidgI6BtPPaXoFd5ZdcrCaYdQ1T90jbOgxcz2hnRvJAOCCQQXcWTDfl9Y/2/BmhCiRiTfQlAKxgCUCxL9LrLv/U9KMUxNnzixYXu83zaQGLqFWcJe8uJAVnBE7/Lh5Q7I4r0fjMlrNPp7jZlGKrKOUqjU6AamqJNEqPOOx1BHwrm1d1zB4k5ie2xWb1wp2HiT6ILPbtXdSd0hDjZz76PqtiMRMnHL317uy+TzcIjC1S8UWlMXd/uHoCyibsfFSx7cqImm7lUD3ekObtDoSuSuaPh4DmwfkrwoDvRZNhHccnSwcnWo/7P/SXtm9naC7r3lbkVzNR3bPeTiVmBpZH4DWUGg5ApA8zHOWduQN6HRi9rebRFE6YHeBIr3ydD2h38BslZrnCf8v7UDcUUBqso74PcfGUH29nvTbanUeYu3BZjQy0mBMxmDXkVZn77Cz1tUqBwuz9xkdL4dc38k5Mf+kohIkPKvua/1FlgpHzyn6+Qhu2buBnS5B7Mzn7YtaQEY6qM/pRgqRm+R4fwob49Cq51u+2TsfbYHuV6IsAmFfdjB5CIW99p3PIGZBhkb9heu0GnhKPm8aRAHHs3KazF7xNuFI11sukNfIwjQmEPvYaqR4vMBZ5xwNQr6wj7zWc595GLBuJiglNb8W6dUiOHN/en/suvf1RoHyjhCESHY0jo7clAfXpyPW4aYuz9oSi3tDhuNE4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(366004)(346002)(396003)(33656002)(86362001)(38070700005)(122000001)(38100700002)(8936002)(478600001)(6486002)(2906002)(5660300002)(41300700001)(316002)(6916009)(54906003)(83380400001)(71200400001)(66446008)(4326008)(8676002)(91956017)(66476007)(66556008)(66946007)(76116006)(64756008)(186003)(26005)(6506007)(53546011)(2616005)(6512007)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <276A91DEF7F7404EA408371C3440E447@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5692 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9baf0ebf-bc8f-499d-5cea-08da5e88ad67 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: q36v78kWKS7VEPmS1EyC/+lVIPvC24Oho/Xj0hqetbRkfvzgtgUnccLL0RR4akY3w7ctpUVH5VctcjzQOQ1Xxo/wibuZRp2LIhTeBhZGRkNCLkxTmlQMz7bFrHuTexX0/KtjXpO0dld5MNSznAKUZBdaEMI/ZiSNPHz2frB8pu16WD0TgEH1UkBv/V+jSJJG6AyL8zm6G9KwYNv7r3q+I5c6XB627NAvAx/5Q1Lm7kdLGFo9/zpFea5GGRhYfBTwu57sDqKfjhJdrplh/dHLYKNXxlpHk0bMS0visrXK/0R/1LDQ1Mp8oTWS/yKtbqva6Gx0t6hThPAYZQYvBl5ywrDCjtf300weOsPSouqs2Rt0rnQMkPtWnQSg8ywjbs0z7tzzUcFX8JfC3IpMrOjChGJQiz8htX7qF19sr2ekBkxNOPqZzW25rfuYll7YOIHOfvcefLbyE4VVozA2N8hw2egBHevfKW+1siugdsAIBIpEJ5TQdLlM5TaYM5Umh7iUwBmPLlkVzDchiKs64KZ3V6oTpaP/w1xu0ciW3FVxGR8WcC7fTQsSUFMv499Ac2i2k2MvYJEn/9sYgfLE19gtdrmLJsvDeWgtOFUo+LwekQJ40phzEzVoawAaQDNzCLaBmfXmt5Hv7EzSQS6tetQjGFKoUjw6p7U+yTKMO/d+xcYYJD9tgoSF+EN57v+MRxxSRIfEhTqPD5Ijkcz5Fh9RaIA5ft5huf94YH7FremTXDXxgazSuQkBNIO+T7JiQBY9KTH3oLfwAicVBmqjWumQadSjwsoGRWnaOt2tntRaoiwUS5+72MFRyBwsx7AYLVLZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(376002)(36840700001)(40470700004)(46966006)(336012)(47076005)(186003)(40480700001)(478600001)(54906003)(4326008)(70586007)(8676002)(70206006)(107886003)(6512007)(2616005)(36756003)(83380400001)(26005)(53546011)(6506007)(86362001)(33656002)(40460700003)(36860700001)(82310400005)(2906002)(5660300002)(41300700001)(316002)(356005)(82740400003)(8936002)(81166007)(6862004)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:17:22.7147 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8623a4ee-5be9-499e-754f-08da5e88b263 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5702 Hi Anthony, > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Cheers Bertrand > --- >=20 > Notes: > v2: > - move new .gitignore entries to the one in tools/libs/ >=20 > .gitignore | 26 -------------------------- > tools/libs/.gitignore | 2 ++ > 2 files changed, 2 insertions(+), 26 deletions(-) >=20 > diff --git a/.gitignore b/.gitignore > index 8b6886f3fd..1de28c833c 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -106,26 +106,8 @@ tools/config.cache > config/Tools.mk > config/Stubdom.mk > config/Docs.mk > -tools/libs/toolcore/headers.chk > -tools/libs/toolcore/xentoolcore.pc > -tools/libs/toollog/headers.chk > -tools/libs/toollog/xentoollog.pc > -tools/libs/evtchn/headers.chk > -tools/libs/evtchn/xenevtchn.pc > -tools/libs/gnttab/headers.chk > -tools/libs/gnttab/xengnttab.pc > -tools/libs/hypfs/headers.chk > -tools/libs/hypfs/xenhypfs.pc > -tools/libs/call/headers.chk > -tools/libs/call/xencall.pc > tools/libs/ctrl/libxenctrl.map > -tools/libs/ctrl/xencontrol.pc > -tools/libs/foreignmemory/headers.chk > -tools/libs/foreignmemory/xenforeignmemory.pc > -tools/libs/devicemodel/headers.chk > -tools/libs/devicemodel/xendevicemodel.pc > tools/libs/guest/libxenguest.map > -tools/libs/guest/xenguest.pc > tools/libs/guest/xc_bitops.h > tools/libs/guest/xc_core.h > tools/libs/guest/xc_core_arm.h > @@ -145,21 +127,13 @@ tools/libs/light/testidl.c > tools/libs/light/test_timedereg > tools/libs/light/test_fdderegrace > tools/libs/light/tmp.* > -tools/libs/light/xenlight.pc > -tools/libs/stat/headers.chk > tools/libs/stat/libxenstat.map > -tools/libs/stat/xenstat.pc > -tools/libs/store/headers.chk > tools/libs/store/list.h > tools/libs/store/utils.h > -tools/libs/store/xenstore.pc > tools/libs/store/xs_lib.c > -tools/libs/util/*.pc > tools/libs/util/libxlu_cfg_y.output > tools/libs/util/libxenutil.map > -tools/libs/vchan/headers.chk > tools/libs/vchan/libxenvchan.map > -tools/libs/vchan/xenvchan.pc > tools/debugger/gdb/gdb-6.2.1-linux-i386-xen/* > tools/debugger/gdb/gdb-6.2.1/* > tools/debugger/gdb/gdb-6.2.1.tar.bz2 > diff --git a/tools/libs/.gitignore b/tools/libs/.gitignore > index 4a13126144..1ad7c7f0cb 100644 > --- a/tools/libs/.gitignore > +++ b/tools/libs/.gitignore > @@ -1 +1,3 @@ > +*/*.pc > +*/headers.chk > */headers.lst > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:20:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:20:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361247.590654 (Exim 4.92) (envelope-from ) id 1o8iTU-00087P-My; Tue, 05 Jul 2022 13:20:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361247.590654; Tue, 05 Jul 2022 13:20:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iTU-00087I-KF; Tue, 05 Jul 2022 13:20:20 +0000 Received: by outflank-mailman (input) for mailman id 361247; Tue, 05 Jul 2022 13:20:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iTT-000878-9a for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:20:19 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50058.outbound.protection.outlook.com [40.107.5.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 369ad09b-fc65-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:20:18 +0200 (CEST) Received: from AS9PR05CA0010.eurprd05.prod.outlook.com (2603:10a6:20b:488::15) by VI1PR08MB4205.eurprd08.prod.outlook.com (2603:10a6:803:e1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:20:15 +0000 Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::e8) by AS9PR05CA0010.outlook.office365.com (2603:10a6:20b:488::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 13:20:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:20:14 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Tue, 05 Jul 2022 13:20:14 +0000 Received: from c7c9d785d429.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FE22F2D3-D998-4E62-8CC4-4362272A2115.1; Tue, 05 Jul 2022 13:20:07 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c7c9d785d429.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:20:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6512.eurprd08.prod.outlook.com (2603:10a6:102:15a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:20:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 13:20:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 369ad09b-fc65-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CurmtmGSN0fdKwHr+ltWMq1AbwVwIsRjin2elxIXV53XYYVUc4hEowok3CSabqxq/jx0mUv7gj7zdLEcf+na7fpqSV29gKxIBIiYgfONyZZGhjNt9NHIx+lkyerHOiA/ZZuH+uniQh4/0SyzW2PDrE3WwHQW472L2uQu6/MZb5iq7GmGzBUFfVgSxsbB3BNyeXtbJtha+T8jBAlcFeXIH1S+ZATk8Mj3wb4dkxofSj97s81TDv6hcMSeO/MUFtzvxx8cDGxEvkVLGHGPNZGRsmBv/Wm3m8cSKa2oP4LAsmbnNSFaXGuN+kBPsrbTUpRMU9F2jZsRQtDf7FOZ4TF4Ag== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Do4TXdwFH3Dl/akG+UCNj7tGRJat+YqVatLtKicll0U=; b=ltapiPZ9k9qktbCzTZ5ELptmlBkw3U5HIg47E/VPQdeOAkCL40lpGGBvMLcqr16P9OYAc0dir+7XGb4J31Hmujy7BdixNVvqv6+sEjx+Zj/funVB+xVSaqhEPQUEY/nHUGSgZure4AF5N01rSIq4rnWgdLZrJ3dSPaH2j16G630b4RqTZ0krB8Z8Zf/KQkDB/UdXst1j6d25EW7EZnYvcSSzqGt3zUESPvVqiQE1q6+LtRECOKd4QmnZNzA1vzSCtxxBLp40VkBlqJVQlr/MtsF8AICYC4mFIDfr/KhApBdjSJPS9ORhBhPJEpLwEKUqwMRASh/Od7o2Ttc2ClVfEQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Do4TXdwFH3Dl/akG+UCNj7tGRJat+YqVatLtKicll0U=; b=gsmCWmJTrmmrpFhinmHgUnF8T9gwjjMonHNUBVVaQGIPsCalfXwP5yG5v0vCOW1b471bkR7rq0fCwAEbYKajFvukIX4SLPNynwgiUKxJQOyaUCPGpkOe59gRFNUd8DTDnESMuOKVYzL3nISQGuBk/Da1ZA8ypkGrVafigjRj01Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 31bd33e983dad591 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T8eCAZwIwKKrovszybfkKaJllHEdjgRV4qaNVu2IV4vJrOgMhRljWaRsAgpGcvTADxqgv+8gF7CFIvBCWCR4BVKawxVkNAjn+Sk8PIE5uNsUED7zVBMF3iA4IIfuTg6B7tASSf0Fai2XWWMkwSZ/RruRm9grYjBatpat12ZU7FYrXpu0YqGEWJ682oAbIC4EFg7MUt2o62cAtW7x6KGWTiJ5didqNlwtloIeZha+ixZtMx2hp6qWinAsC+1G3JC/TsAR9VHk7h6Xx5A+TA8DOZI5Dnjyfso1nYRarM6gVctkJoMAKCOe5m2AkNpgE/QN0KGgYnY5FTwL+tZY76kjWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Do4TXdwFH3Dl/akG+UCNj7tGRJat+YqVatLtKicll0U=; b=EfTDrX9ctvyxHR+pKbQRtoId5bzpluElc7aaUv0Jzh0G9H/8niALWoZH/LBNXKveb486OMAfS/pTSmHMpw+ZRfBb12/lVKqHtQQn+Oal2dtR+DqbygM9L2h6VV6R9s2egYD5fCpAGLWVKGYZcFnnB6PV9+vLNHc34eSaW+L/aaieO+8oRwM89tPy/rgbQrlcAqsHi7aUJEJedA6SyKhhFIzNxxeYlr8Kz2sZ/N77tYkn2pbzkuU+5Pr16C9yxBOmsI2Tu93tOxlDUbhiEfOmpDC0+pAGmz4DSxpFEYljAV6j5Dco2t1XKaoBs33iJSIJSdyrcmgCbbw+t9vm8q0XPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Do4TXdwFH3Dl/akG+UCNj7tGRJat+YqVatLtKicll0U=; b=gsmCWmJTrmmrpFhinmHgUnF8T9gwjjMonHNUBVVaQGIPsCalfXwP5yG5v0vCOW1b471bkR7rq0fCwAEbYKajFvukIX4SLPNynwgiUKxJQOyaUCPGpkOe59gRFNUd8DTDnESMuOKVYzL3nISQGuBk/Da1ZA8ypkGrVafigjRj01Q= From: Bertrand Marquis To: Anthony PERARD CC: Xen-devel , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v3 13/25] tools/libs/util: cleanup Makefile Thread-Topic: [XEN PATCH v3 13/25] tools/libs/util: cleanup Makefile Thread-Index: AQHYh+QwbYCKsLocd0aY57rJQgVGX61v1BiA Date: Tue, 5 Jul 2022 13:20:05 +0000 Message-ID: <05F4A5A8-56CF-4189-B5EA-160482F0912A@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-14-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-14-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0c3b2cdb-eb18-4159-b30e-08da5e8918df x-ms-traffictypediagnostic: PAXPR08MB6512:EE_|AM5EUR03FT004:EE_|VI1PR08MB4205:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ewr//1jYV1jc0fbwpgKBizeZveYGTcT3Rtkpk3uLDr8YkesvXcGdJabh36Y4hKabUEF6IbDTk57qOxVPjQxsgTaQieiXXoZJAHPaoYtcYHn2IPhoY8avraz+VUEjPYlZGe5L8cppTfcmmCFczYJZTf75kfQiByLEr524kuETCv5Umigua9+m9gx/wu7BB+yydvAQ4JgYrs8h2iwE8A5b9O0ZAXKl0wxNLNp1ca3pOd4payYyzbA3CtWB9DEWqdu/UhTWwT6AzbQlEBrD0hLNGnU//LGzor3l0HslvHCscsTT4LmCBUnNGIVuvdbUrjYPl5VwPvSNnrEoAAMiudXe3lmx8N1VWkzZBTlUXhhTD/xrLCOOor7ZUpcmFeSVKOxMIHdSRRvWJtLiN+LQgX30NVir6cF+1IGr43mk4jwqkuLiu5EDJdDrOn2TASAzSfeLlvg1CSVs7sEs36hTZXFQXzBKwxmws8Nme3eiiLz/mjo2B1LDmmOU+WGRVIBiSwTnFnhv+OGMJu5V0JsVCF2hmXYQW6Ry1AUHqClZq4hlKVBJghv8VfDKRQ9mrmK1KBQeKpCL7LyThIP8MTXpr/I3ZA7LU7wALPhEyWY92KzC/xET5EbF+93wNJbduTpirIxDUr73zp5gevWXsSX9SXDIXFETl8K1T+/TAwuAnb/uuIRP+tNfUOpH9abRF9QmIb6ILh33aOBbtNqVs2RYQgir+EGOi5CWuou2rpp3kJPPCQRRvyVjFWyyr5lAm5ydAR+zDwXkR9GU7JiOxi+X6/eyM0/zcaNaEdUx/4WwIwdE/iz+YSifc4jsy5Fls9R/JInA6M71x/fyHsIORSYGnuahPGcxM0x0NcfWucfTnCqpxFk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(4326008)(66476007)(64756008)(66446008)(91956017)(8676002)(6506007)(66556008)(76116006)(66946007)(41300700001)(71200400001)(6916009)(316002)(54906003)(6486002)(478600001)(8936002)(5660300002)(2906002)(38100700002)(36756003)(86362001)(33656002)(38070700005)(122000001)(186003)(2616005)(83380400001)(6512007)(26005)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6512 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0dbab758-7b1f-4fb7-97a0-08da5e89136a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G9slQcgV6fQg7mPTeE6JH71175xAIed0Q++hRNfl7hblUX1loyVCL/VrmGMMvp/1RLYjFcYIzjLcAUXXZrmeMoANcgShZhWZhAXZpwExO0Ju6LuQqWSLKOkxCpGTg1BlTFJXLRI9J8fwgbpadtpCkA4zRGK1cA6/Yd+/uQrBWEPJHlbd+RoIkTwIu6hHeYgebecR0XLm+GARFldyNgsauX7Ws1CvYa0FdOtd5WPVCZqeReHEaFzyLzw6FcEhqFfP9ToBnSzUSxm5OSbQDNV94G0RQcSoAWcW6qqgXgbJ/bYm18JWEsX219KiGw0y4JvllcmBuXQRAHOPosFuyzsBPt9zFVE1+Pj2JqEQZbg96/zJhhRBOBNndRmUv0xHr/LqW+rng51u8hzNntKUW9vU2hvNzBUVWyKEho2wBMIHlkS3t9eMZwF+ukFOWpwH4Vw/OSorLpXQbOXTi9wtYsLPMIZyK9AleZsX6olq5l+IYiaS7OqLkr/cEtcB0gw6U5Tsfb63U4kcXvt0/6+RovbVopUyQyQ78KOVbDKlxRsC2/Vz/NLaAVwDwVjbVyHneQTYXQY/6JeMx67odfrpUkjAEeyoP5I/6xDvKuKGW5iKOFxuwH8SdKSGjOh03msYWyel5RqbhjnkSrIdcJo6zBxQODq49ulM6u0rn5V/3K0f7ERO55Oa4UdLLE8FMEsdhI/dJyF9D+bURUU+nZcA0dzJtsmoUPWP7B+/fLzbALijGmq98Bv7fhkKGFa2DoY8K5oJvtXPAZxNLbwFDiPo+YCWqa68lVK7CcKDg9Yd3X9QKl5wlLFBqRfjlahvMPFnZOWL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(346002)(40470700004)(36840700001)(46966006)(36756003)(86362001)(81166007)(33656002)(36860700001)(82740400003)(83380400001)(107886003)(186003)(6512007)(53546011)(336012)(47076005)(356005)(26005)(2616005)(41300700001)(4326008)(70206006)(8676002)(6506007)(316002)(70586007)(6486002)(478600001)(5660300002)(2906002)(40480700001)(6862004)(8936002)(40460700003)(54906003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:20:14.6565 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c3b2cdb-eb18-4159-b30e-08da5e8918df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4205 Hi Anthony, > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Remove -I. from CFLAGS, it isn't necessary. >=20 > Removed $(AUTOSRCS), it isn't used. >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > tools/libs/util/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/tools/libs/util/Makefile b/tools/libs/util/Makefile > index ffe507b379..493d2e00be 100644 > --- a/tools/libs/util/Makefile > +++ b/tools/libs/util/Makefile > @@ -11,7 +11,7 @@ OBJS-y +=3D libxlu_pci.o >=20 > CFLAGS +=3D -Wno-format-zero-length -Wmissing-declarations \ > -Wno-declaration-after-statement -Wformat-nonliteral > -CFLAGS +=3D -I. $(CFLAGS_libxenctrl) > +CFLAGS +=3D $(CFLAGS_libxenctrl) >=20 > CFLAGS +=3D $(PTHREAD_CFLAGS) > LDFLAGS +=3D $(PTHREAD_LDFLAGS) > @@ -29,7 +29,6 @@ ifeq ($(BISON),) > endif >=20 > AUTOINCS =3D libxlu_cfg_y.h libxlu_cfg_l.h libxlu_disk_l.h > -AUTOSRCS =3D libxlu_cfg_y.c libxlu_cfg_l.c >=20 > LIBHEADER :=3D libxlutil.h > PKG_CONFIG_NAME :=3D Xlutil > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:21:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:21:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361256.590666 (Exim 4.92) (envelope-from ) id 1o8iUW-0000PZ-2Q; Tue, 05 Jul 2022 13:21:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361256.590666; Tue, 05 Jul 2022 13:21:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iUV-0000PR-UK; Tue, 05 Jul 2022 13:21:23 +0000 Received: by outflank-mailman (input) for mailman id 361256; Tue, 05 Jul 2022 13:21:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iUU-000878-Ec for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:21:22 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30046.outbound.protection.outlook.com [40.107.3.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c6de334-fc65-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:21:22 +0200 (CEST) Received: from DB6PR0801CA0045.eurprd08.prod.outlook.com (2603:10a6:4:2b::13) by AM0PR08MB4242.eurprd08.prod.outlook.com (2603:10a6:208:148::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 13:21:16 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:2b:cafe::a0) by DB6PR0801CA0045.outlook.office365.com (2603:10a6:4:2b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:21:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:21:16 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Tue, 05 Jul 2022 13:21:16 +0000 Received: from 4256015374b0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 41D970AC-53FC-4E2C-BD92-9EDF15AAA113.1; Tue, 05 Jul 2022 13:21:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4256015374b0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:21:08 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB6512.eurprd08.prod.outlook.com (2603:10a6:102:15a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:21:07 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 13:21:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c6de334-fc65-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PkiuNnQlVih/4SZjkEH1fJfhmNN8jg+lMHd6VHiNwaDv4vGFMEJ6WCc+Evn4lTIhL/ffb0U3CalRC0v/dLx4KyRR7Qe5ySVuxn1vhhDihZOzlH9WB/6DOSPiuVKdyK1I3tK8u785XmgmFbI7qndtCj0Qeatp4xBZpBqvsyLTW6yzPm47FL2K7zRNnH1WXNKlp5KFJYH9eYgGJ2k7/rkUo5OKWxW1DKyFcn6xYPcGNIXImiwNOHAg4aW+07gLOjMyXuvfqpl4glmOEGtkCS8VPaaEcc+bEWBiywGiw5EW539ibYD57EIJj7XYlJrFC8IGwur36OrVPaj+pK/mOn8VIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yl7ydSF5w2O77ENb8wz3ALgNAI2MdbbutsWtrg5Svic=; b=CS/MGJoMjWXBrGKX24cYDdPYKCTqoQbeqbA/4YFhx4hFLBZoAZFqDMx1P6oaxO0Bva6IUmYSvOacJ2PotiMGULGo4j+6AlrVULXfV3vOiXp/+TOg4Zy7b8Tssd6B2XIat+9Rbvj1xjyEeWjmekC2AuJ/Sdah9c43Ud7gH/o6l954sALaB3InxoxqVOfnnv4X4E7QJGjJfjHDvsMftIYnnQ9Z3EnPBcH4cEfI0QxAIWAM965djVsgzkKzbhx36hD7rdcx59Er4fnrWY8jxr+oJ/bxFSR+E97xIC7VAvTgomNYfcOymMUcz56uNAfsELyp+vaplEM8k/u25qNHAkVz4w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yl7ydSF5w2O77ENb8wz3ALgNAI2MdbbutsWtrg5Svic=; b=xeqsI8ihmOl2yje4qWR6ggRNTrQICM/wkZ7LVtD5kNGPxNod44jpeYebruvHtmG1So6XJ9EIIMM8Tzx6TpbNrrEBbV97oytbB6Wh8JGFgZAiWo3D5GbjOTwZrb8j2FZkthSwjym88Gvhy4AOMeKLPfBUIsW4NgjA2GQieNZJZL8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d1353698edf7850d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOWlDo4S0v9MYH2DpwrchK5Ye/b6YZGuM2Wp2zyzmYxUfnaNOpcB/NLcwvSTFkGg9AjZOTtrmftAJ6BLR3BoKlVFEsaOzuZiXvdMf9iQ/WiJclQathaNQsBjXX+MpYEAmAivv71za/OkNIzXbXljVJp3d9BxUpsj0gQ5GbLS3Wyc/IYSAOhRi/gZCtEJ49PuTFMVnakjSHY41cgHhiXhezcBzhNITdgvVRBKexRyj2gvLa7LQEizz8/GBqjxcUFo1sW/Z6L7fUnwKTntBuuQl6UbB5FDJ7nMM2XvkNGRuDi6BDfThAa5PDNx/oEr2VTmugRa5oT/U1EXS+VGFVoVDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yl7ydSF5w2O77ENb8wz3ALgNAI2MdbbutsWtrg5Svic=; b=S0sEMYsOmb/LcFkzoVIKOiSg/TM6bGUXMPwb2wEofknIF8KAWDswHwATQpTNmNziuZjI5AwiWZyw8Ab38KYN1CeplVF1xB1ySrgap1KhTvY3KNGJ19sKmLFhu9o3oK59qIgHuWj6fc/Xh68EM/vObMEoqMtQOoFiSpKnCLp6HfxyH2iLSPL9yts9aNiuyyJAJ9+R5LTUTGZn2jVpDy/zNwcMjD9y3oFTSni7Erwb9a9PWhr2E1YfcYq0L2Jq4LIna+0EOKmMxkYkQ1/YJ+V7RVTNIcjN9hqohHRJN4wQT4MbJpDKNABIlwWeK+4buqQ3q75ovIDKapHmcmeOGenF2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yl7ydSF5w2O77ENb8wz3ALgNAI2MdbbutsWtrg5Svic=; b=xeqsI8ihmOl2yje4qWR6ggRNTrQICM/wkZ7LVtD5kNGPxNod44jpeYebruvHtmG1So6XJ9EIIMM8Tzx6TpbNrrEBbV97oytbB6Wh8JGFgZAiWo3D5GbjOTwZrb8j2FZkthSwjym88Gvhy4AOMeKLPfBUIsW4NgjA2GQieNZJZL8= From: Bertrand Marquis To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v3 15/25] libs/libs.mk: Rename $(LIB) to $(TARGETS) Thread-Topic: [XEN PATCH v3 15/25] libs/libs.mk: Rename $(LIB) to $(TARGETS) Thread-Index: AQHYh+Q5fiim5oiltUCifj9IfmTKrq1v1GKA Date: Tue, 5 Jul 2022 13:21:07 +0000 Message-ID: <019778C8-041B-4740-8583-32EAC5AF3F7C@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-16-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-16-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 49d4e2e5-b35d-4f0f-e624-08da5e893d82 x-ms-traffictypediagnostic: PAXPR08MB6512:EE_|DBAEUR03FT011:EE_|AM0PR08MB4242:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PGrUHdqAGuIt0PNCTTaEB1/aDFKpkWUrJOul9hV00AZ5X0VBvcANeOOk7KGF2PQ+1WS2bswtY25j198o/1ecg5GPsmjrkZ7KAAEI97vE2o+JealCQntIk/AXJ81LhWcKVe5tDHA7d/Oco7ANjOfODGyGDzHMzTZ6Tzeyr5xAmv6RSYw2RJ/xgpmnQPgukqnBngHkd2d0+eipNob2r8mMdGhe6SUWoBzpBrQupcmPQCNQsNKUa2kwY24Ym7A29ZUKH8lSw2Kau9bDYwkdbDdnKpTvf1ErPztpuCg7tLf8Cuci/NAAIZI+Z4yRWao6T+MTl7WPRGtzrR8Vg0+6eEox4UJv2LqqIq+7AUH/4Hdd7uppRyTaOOQCYGbm/fRzyqWQf/G9K+ZuxRijSSZPYXkCuG1UnDYJnvlbkBgW6G0ysV2/HwekRmVe4Gm4DxH04rHbd3OGiL2OMamxHNEXJuVGsez1Au41CAa7GeyWVs0KLT4etgBNbPyGcYan4y6wlOe2Vj5eLwqFkMV/qqgIwdENKuUW9FgwjuWKyE6iBkvD3kTz6T/ytKkTgpNhNe6WctbUENgMymLE8xlkSEwjS5wB7KquheeMTYN7K1+ra/bd73ybMLiM8ZXVWwhANA3imeQSOEESSDeiKt3vRvD6qSevNx4o+OxX734WsIzWVByfyZoMflkHMncOR8GNELXlIXWMm00AnWlIPiBnXFo1cFnUUuPhKAX1JPU1h6/NUqo2wYP26+gS6rLQyS/y8G4yJnWwDEla9VjBcPDt/H/jcf4mmfveUQAp5z0rSLBJen/kHM+s1iDWhPJSb0jk/zwlnR+woKb7Bm/l/qikfiyUfyTro32bqaNb2XG9t7wZ358aFtE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(366004)(346002)(4326008)(66476007)(64756008)(66446008)(91956017)(8676002)(6506007)(66556008)(76116006)(66946007)(41300700001)(71200400001)(6916009)(316002)(54906003)(6486002)(478600001)(8936002)(5660300002)(2906002)(38100700002)(36756003)(86362001)(33656002)(38070700005)(122000001)(186003)(2616005)(83380400001)(6512007)(26005)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2F94C9A6A767B945920B6C724BAE9232@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6512 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7e69c7bb-74fe-4b36-00c5-08da5e893880 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yQndfrE6+QjXltdTDxx5x6kqxF/efIHgr2OhLkciFft3BwG7MYgvxQivtqxxeE2fiiSRBLw6b/bXCNx0xM41xGNMKZhbt3rqJtODSe7qIRD6AzfsdfuwoWOqqygQF1RrYhAxlL+gLw513Tw1bJJHqwlm6dRfpUtLFugCz1iDu+ob78G48QeLo6VWMLOTOK/DMaWYDwpEAOFPqjH1H0UjEf2OTdkjLjxrdB534BfAd1Jfk/4WsP5PSr+DF3w+Nz7RNe1GQqkBhq08ZG0YV6hKnMUZ5insqCocMRSasyPaVFuGnJLC47Q+egqN7MO1b7H4uDgMdcdTTj44jyD6aRiCkP68l7upj2BDe5nxnkR3xWqfDrhSw8znRgF1Uh6rCC5c8aHp53wz5rCkaIHQqAJPSBGT8jOz3IupzNuJ5sk6gNDeJC/eOlMXtLgX2+S5Hk85yfgSJ/zNRsKrfNYuCZHVsUnMCrzr83dBEq9Pk/yrbVD9S7HCjfOkX/IT48XnbiiY7kaJisXqVx7BzxJeIrNmpC7KdpVGDjcpzXKvi3RuZo+d1S1Pybw1KCmILh3zTiG/O17NzgCOBw0isZbaG3uZTspNObj+y2SpuTanTrJjL0CPQPoSoJh+tvT1SxFaoozOHzDEGERCx2Zb3ScqE2irX9DjnU1/lZL0wIaHmKZqEi8wMoJaCwuKZS3vuaYwHwDNwu2F2xwA5MVsxAW98BM0p/0//4CJTlGJHDyn6bhGrB2/wpdhm/IHGzGBAMY4rtKvNdQ5DKm4mTlMVoN5NFCVyVKXQsGVeqBcAdrhVCn1c+bMTYZXT8KEbjzVvPCDnqmo X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(346002)(36840700001)(46966006)(40470700004)(40480700001)(40460700003)(36860700001)(82310400005)(107886003)(186003)(2616005)(83380400001)(47076005)(33656002)(36756003)(2906002)(336012)(86362001)(4326008)(70206006)(8676002)(6862004)(70586007)(6506007)(6512007)(54906003)(8936002)(5660300002)(26005)(53546011)(6486002)(356005)(478600001)(82740400003)(41300700001)(81166007)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:21:16.1865 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49d4e2e5-b35d-4f0f-e624-08da5e893d82 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4242 HI Anthony, > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > tools/libs/libs.mk | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index 58d8166b09..e02f91f95e 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -23,9 +23,9 @@ LDLIBS +=3D $(foreach lib, $(USELIBS_$(LIBNAME)), $(LDL= IBS_libxen$(lib))) > PIC_OBJS :=3D $(OBJS-y:.o=3D.opic) >=20 > LIB_FILE_NAME =3D $(FILENAME_$(LIBNAME)) > -LIB :=3D lib$(LIB_FILE_NAME).a > +TARGETS :=3D lib$(LIB_FILE_NAME).a > ifneq ($(nosharedlibs),y) > -LIB +=3D lib$(LIB_FILE_NAME).so > +TARGETS +=3D lib$(LIB_FILE_NAME).so > endif >=20 > PKG_CONFIG ?=3D $(LIB_FILE_NAME).pc > @@ -55,7 +55,7 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR =3D $(XEN_INCLUD= E) > $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR =3D $(CURDIR) >=20 > .PHONY: all > -all: headers.chk $(LIB) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL) libxen$(L= IBNAME).map $(LIBHEADERS) > +all: headers.chk $(TARGETS) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL) libxe= n$(LIBNAME).map $(LIBHEADERS) >=20 > ifneq ($(NO_HEADERS_CHK),y) > headers.chk: > @@ -124,7 +124,7 @@ TAGS: >=20 > .PHONY: clean > clean:: > - rm -rf $(LIB) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > + rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(= MAJOR) > rm -f headers.chk headers.lst > rm -f $(PKG_CONFIG) > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:22:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:22:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361262.590677 (Exim 4.92) (envelope-from ) id 1o8iVB-00010n-FI; Tue, 05 Jul 2022 13:22:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361262.590677; Tue, 05 Jul 2022 13:22:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iVB-00010g-C2; Tue, 05 Jul 2022 13:22:05 +0000 Received: by outflank-mailman (input) for mailman id 361262; Tue, 05 Jul 2022 13:22:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iVA-0000o0-0w for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:22:04 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00076.outbound.protection.outlook.com [40.107.0.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 74d006f8-fc65-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 15:22:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5377.eurprd04.prod.outlook.com (2603:10a6:208:114::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 13:22:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 13:22:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 74d006f8-fc65-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hyy7gT20vY9OJUTybsJttzq3OxlVK32oi/UxUkQ65gmKt4fGobKdtxcc+O6t7p10l8eRGsT4wvXyb5KuaUEqAJwSfr+TQ0frG0S4rx2l8PkrxnFjVqLXWOHD+2lb6dYvYPlfBxmO0YANxqHAh1jm/it048i6fo1MZz7V0DkrvAgIYSqF9gngE/hoiMXszdnv3lbHFoAoq1fpDZwHVFVnPaRyz0yqVRLfRNsbqK6npAOHd5ow7+JhjjQoxk8IP1YlFRgrIyBANiuY2ix7+NkUDsxmq7jzJ97FKgXZ2oxvOsrXFQMFsioii8FZCkgJZVtiSbyChDBa+YSwMwOssxWk8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7NhW39gnfSd8D71BhfXGfLQQdqskP+09cdOVkmEgebk=; b=YHBO+D0aeOpjcGBzZhRhPMm7OVmpxBsUzgWWfgwtKhCz9/knKj21jGUVlbEOHEiA0TXriH+u0tBa0wrpspJ1/A936vIiJ4zcdgGdtNvqwqEgz2mUvHsc0hJcmdN1sMI4roMw0OfnYS0AOBj6BckifDsa7UFn/FUH8P2ajJNRikbxww0x+077+4wSPC88DaQsf+v4Q03JYUh+c8fq1Y9QIfLrnhVCCOqpZKz7HPRzwOzgOb9AXx0KZxzDwHw+A9aXVcb2cWPSi3u5Rf8OE4CqXQ6w7vPHYvOysV9/iBO+rs6rJKo/J0cD9sHZTD8bt6fsOPudKN4Ko0qD6i+hC9qoVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7NhW39gnfSd8D71BhfXGfLQQdqskP+09cdOVkmEgebk=; b=V510idh5R3nsPkN3g+BnVRKnmXGqJFVSfG/iR06hLW0iRIVf6lAPjML1jzSbkBpz6yLJvE1mD6JPxIFkdhCjrdnR5BTWUYCWy7dBy/USS/sZSNk1ckIXvVr75Z+lGlAPT3A+nBwIH4QmekrdhUQQCJfAEyuGNYzv5GS9VQQjCsC3hCJ0bf/7n1rQ6fsRpqTePrtiayf8tcf/EW0bXfz1G8pmfdVAao4xgUeek+WU4P5ec7d6bQ1E8i6jz8OHb7sEioDMN04ep3memmD50MOE8UrlN8/3nZCWXHMqlO1LXi8ZjWre6Cvd0J5aPpb4gsqD52kNMGUg/JVjpOPD0eqxkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 15:21:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/6] x86/Kconfig: add option for default x2APIC destination mode Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220630085439.83193-1-roger.pau@citrix.com> <20220630085439.83193-2-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220630085439.83193-2-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:20b:48b::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a771ccd0-b8b1-428a-7b46-08da5e89582c X-MS-TrafficTypeDiagnostic: AM0PR04MB5377:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DQfhoT/UtmWJrp+8H2GcDdivcQEZ52HTr9+6BEa/TLePFO8WJo5Bh0rEQOn28wflPlggml/z3lhT03weEUGQ85RlsEkfs0MZcUnIkApupn3ek8M2Hh+lAhe+4zxnsHe1cHZo+p46IO1596v/D20e6zDJh0UF0xMIHMwzlbOEqAPdlLyETC7iwdWp8oXlsZHKbgti12qNiIrafF8pAu1SYmWoK+4vsLHsH8ubksLCH9J9g01qmf82KNUcfZsCT1IYHmKTbkG/fSQY8QsPGHEo5bG3qCC0EbI72yGbmqJGt8H6Mm3aRaP7IDRrkUaxZvTZoVbu8/FLnJaptgHbtTVEUR0jjB6xJPz2C829+fjED1SIKsMXPusY5Raa9/L+kNQrICV0W3jZ/NWe7TcW1rPupLwwqZVGyHa6X/rN1qgSZbfqh94LSaBqG5scOs/2AAKCUDxN972AnEMY0XKiPd7sa+9EElJHm5zwi+r/F4XOaisXxMFnx7mOoCxRw9yIwEia1iOCsO7MnUoYHsMYdMa35u1A6N7iGwJZcCbsIpi3EmdPHfKeb0+PK9OyHfXHV2W+8dvyZx/2ADf3UV60muTQQluof9DpYs18OOo/AYDXLmHeza7g8rzlR7xciD979kt7O0Yswzu8pPCaFTRpubXSKHyz6RS+V9skR7KcswG27eWSafk3aoear5xLusogL6Ra62fR+ieriHa3r+9KvnbTB60u3pl578ttUi3uzZ08l6qYk3XEMYfUXFk+ymeNkMtLvmXm+Og4erdH2bTsVjMFrOxIyV+X6Vud+BdFThLOHYDCqnMnW5Bmp1TaGhYCcJM+nBMPDPXMTzDYao9pKcQ7yamS4TlaUhwyBCnBPG2HwF4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(346002)(366004)(396003)(136003)(478600001)(558084003)(6486002)(54906003)(41300700001)(26005)(6512007)(316002)(8936002)(6916009)(5660300002)(31696002)(53546011)(86362001)(31686004)(186003)(4326008)(8676002)(66556008)(66476007)(2616005)(66946007)(36756003)(38100700002)(6506007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUp1VmVyVTZTdTgzcjREWTFoZHZSSThud05TU05DcnpuYzlDWlF3Z3FLVzlr?= =?utf-8?B?NisxUCtoS1NRaWcvQklySUpFQm1maks3TmtJcTRJOUNSSWora2FlNXVtWnVC?= =?utf-8?B?YTFZV25oRlFpdWQ2NTNsTkdhVjFxcVZ6T0M4eDBnV2YzR0J2d3ppa3lmQ3Rm?= =?utf-8?B?N1pEUlBmWFl1TFkxVm9UQXBENHZMb0trU2R2YUM2SXduaHRjZUpMdGE3c29L?= =?utf-8?B?bHVSNjVYTFEwVmJyYnFIdDMxZGhyUUwwSXdqTXFHYVhOK1V3aHFwMTlYQ3JX?= =?utf-8?B?Qzl1aVpHc0JGRE5KUjBuc3ZHU1p1YzhNU0tQQWhKSmRwcmx3S3pTdTRpMGRY?= =?utf-8?B?YzI3MjNodUpkbS9HYVZZZllLckFhMUNRQUxWQTlJajFEcDhiL2ltN1pMeGhD?= =?utf-8?B?cXp5dmt0UTVVM0hBRGdRSGc5QlNpVWo5TFRZOEFMVVBGVVFjSXJiOVA1YVhp?= =?utf-8?B?dzZ3d2ZhWXFxTXdybEJEQUdNT0lwaUlWTEVGbmRxdFphUFZYSC9DK0pLMG5Q?= =?utf-8?B?UGt2Q3NtRDQxOER2bVJHb21EbWpBM2M1WDdKRm5zTm1YcEVQSjZpOCtZM0dF?= =?utf-8?B?WHlkWnF6WVpVYjJhMVFQUVR5UXRiM2Z3UEF6RWdQdlAxdjFPUG1kYWY1aXQ5?= =?utf-8?B?VVJrWVZDZzdWV3BBalk1bGcvbGU1UWROOWNtR1lIK1dacjNQcTdIcENDRGh3?= =?utf-8?B?dlpCSGE0bDA3V2M1NnBWUjJ2TXVtYlVPWnVPVzdsQnBOY2FXT2VBSElDOFdh?= =?utf-8?B?QWltRytWbDkxekFqenM0MnBSNC9ZNHFEMFJEMlFFdEJLamFrbDVJOUUxMUtF?= =?utf-8?B?Ung5ZGZ3aFhWQW5yMzl4ak1HSVIvd2t6ZUJTVmdPNUZaTThKTDYvK1U3VFlH?= =?utf-8?B?RmxMNElVc2o3Q005dnd4aHpKanppYXVBRmRnTHFkUmFCR3phb0J0UGVMNGtS?= =?utf-8?B?YTlvVnByK2E3Z3NxUkhEMHBDcFlGK2ZvNWE3a0dlL1lZaFhtWWNNYjJRTjJM?= =?utf-8?B?ck9LWFVjQTZxUFVtcDBnNjNSWlRkZ2JxbFV3QlN3Wis5cm9ZRDhqUDEzTURi?= =?utf-8?B?b3p5blE3dGNsQlR1WE9uRHRNeEdSV0d0cDBhdFRHQXJsVERNWnRiUTh2eVM2?= =?utf-8?B?emZyRXQveHM4MS9JZzducDFQOFJYTnVrd0hzd3g0dThkOXdDRklXWEd3bVhD?= =?utf-8?B?NlJBd1AzTVp4NVRTUFQvd3ZENUJyYkFDdURsaTRjQlVQaElyLzlIb0NoR1dJ?= =?utf-8?B?OVV0RXZMQm0wVklRTkd3MlpKTWlYZ1FPV2RHcUdNWFRCNEsxNnQwTkRDL25Q?= =?utf-8?B?TkQ5WWVKKzVjWngvTHo3NlZiaDJmc0dxRVVIb05MdDZSL0FuV3NQb3Jxd1pn?= =?utf-8?B?T283S1RCRTg1N0ptWk1lNTBMeG5YTUFwSnl3eVFSN0diSytaY3hSNkNZOGY3?= =?utf-8?B?UkM1MndyaGNWMUROU3J0SExET0lsbmNBaTlXeVZ4M3FUL29JNTZOZkpsc1Rm?= =?utf-8?B?elZuSHcyZ0xIelgvL0FHN25JWmszYjNQaDRuUk5SWm10NlhiOFd6ZjNhSDdW?= =?utf-8?B?Qnh1Q3ovRTI1TUVLWFo4MmIwNHZMam96a21WMHRHN0VQbU9TaWVnUHZvdGxt?= =?utf-8?B?Y1k0dXJ4Z1FHTXc3b2l5K1grYkFjSzkxTGoxQlQxY1o2RmR6WWFpZWJRK1JZ?= =?utf-8?B?Wjd5YTJsUHZUQkU3dVYxbWNpaHNkbjR1NjA2UnkwcnBwcVFqR3NrRWVISjFR?= =?utf-8?B?emxON0Myc2pxRlRlZHZSOGxVVDV0MjJhdHFxeUVQZ2pmSXg5d0s1bFB5b3hX?= =?utf-8?B?bmNXZ2F3dHp3enJzY0x0cDMwSVp4VjhJYkhuc3F4U1ltUDE2OEl2Wk5mS3dD?= =?utf-8?B?TlRReDJvUk9SMXZTYVp5RHVxRkJ1MmVWdXNsN01vbjVFWnZKR2VGM2tBQVA5?= =?utf-8?B?c1RMWDJMY1ZXZUFJd3ZYWDBGMGFERVExWjNMM3RhU1daeDVleGpGOHI3RGNs?= =?utf-8?B?Vm5EcUtDd25HRXNOY2tvajhJMVFqKzlWZXJ4QndvUlQrNHZISUpQSklJaTJJ?= =?utf-8?B?N3VxZ3FESTk1alBYcXdhdzk5dHpnVE9lcjhjZCtpSm9Oem9tbWt2WlVVNnEy?= =?utf-8?Q?FSt9VXYoc7Doh/n3v1EO7btjj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a771ccd0-b8b1-428a-7b46-08da5e89582c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:22:01.0593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /SajpQes/3bBvrtNL5DS6lwrjmMDJGQTy0yUx8dqLA/rDzjbbSOjOhGcSdWHdgL31m6oktEDhP+Cv8d58RWiOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5377 On 30.06.2022 10:54, Roger Pau Monne wrote: > Allow setting the default x2APIC destination mode from Kconfig to > Physical. > > Note the default destination mode is still Logical (Cluster) mode. > > Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:27:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361271.590688 (Exim 4.92) (envelope-from ) id 1o8iaM-0001jS-37; Tue, 05 Jul 2022 13:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361271.590688; Tue, 05 Jul 2022 13:27:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iaM-0001jL-0P; Tue, 05 Jul 2022 13:27:26 +0000 Received: by outflank-mailman (input) for mailman id 361271; Tue, 05 Jul 2022 13:27:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iaK-0001jE-W5 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:27:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34866774-fc66-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:27:24 +0200 (CEST) Received: from AM5PR1001CA0017.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::30) by PAXPR08MB6351.eurprd08.prod.outlook.com (2603:10a6:102:df::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:27:22 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:2:cafe::61) by AM5PR1001CA0017.outlook.office365.com (2603:10a6:206:2::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:27:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:27:21 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Tue, 05 Jul 2022 13:27:21 +0000 Received: from 47eb244027b7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0936B872-E09B-4150-9FB5-6CAFFD93B2DF.1; Tue, 05 Jul 2022 13:27:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 47eb244027b7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:27:15 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3847.eurprd08.prod.outlook.com (2603:10a6:20b:8a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 13:27:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 13:27:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34866774-fc66-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=XyuxXmiiYbiRSPW4KJfkYswPm1LDUL9Ma9vg+pRvNWUwU+1IS6h1Y4AZGC3hh1t+C/BVNPFqi7RPdfcIlSxE1UZCKWcxaEMBt48zO3IgeFEPSmHvKeol8GJyAe7fR4C1WqQ6ewLlSOdDN6fKibRgFI6do1ri375UIfzslfV7PEQ4KIKbcseA2qZIcPtPbAFm6fidc5BZjnTgSatu7xiuH524wGAq4DqQ9stFfq4agNhBC+5/XyZT1xsCojuC/7pZGu3CRfJFooVHqPfXyK0fAOaTD8F3ilTcVO3aT3QhSJ0NoQdlG1FfAwW/7W2R5Gk3yOMNvPh4SkmZhZuvy8mmDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=iYCRmXTWH3R41aopRWjO0W+Kd9b0sG6NkeTiQiriUBgPQemiZ5lk4gUF9y/giUlSIt6J3pVSVu3Vq+GOS7UHEOegMsNCjOJ5SjsXzhm+ilXKvsuWfAhSR/sKCMTrGIRMkHBORPEvdUeXFPiR5cJPKS3Up2SN0zDmNKpsRuCw7Zc2tFZ60Zh45Yji6o58VRXNxnXD5iwh97rraVStNRGEpUZ67gXloV63/odB+xa4s3POBE3JecCEpNnrmOkpdSnBoVYknYGKzvTN8lHgTp1liTNAwzhSXpI+/nljSviMEBoP2P6EJPtWjNRG8R855+EzJXQt4nizb+PzEAO8QpR4GA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=bkGixkY8cE/7dMOx0YV/726vzrBc/ZL0xVDWKDWUfqpAWLFWaEPwJWQW7U5/j0Cj7tdc3MKaef4OYapCUqW0v0v32Qv871YAwbDNztEUZbb35fTGhPWKQ1tcuPMosrBr362ryhQMzcrNN7zMxJRWkYRDUPh5jCIt8+14oxmwEGM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: efd1762cbdcfdde4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXHOKbl6T8PaW7dgxCcHQYVNtvBqgTWVZQ7RxlJkywrghAnSw3UBFcPPyNoy0mqwcgGKZZcy19Lj7Ps9a8WDUHrEd1J6uyD/zYP7hSYkKrinKbFDCfwrioTl3qmDXI1svKC5zFUUe5QpxV9zW4AHI+qcIWoiB5RHOo9L7L2UZHDVsy2RF8RgAoMd+TXLejYgRN3aJJPdcSJnanoO/lu4//XArNyPtSReJ960btlGaMcyULCNLBfOKSf9CuR5ZmNbi9Xv3Rhbu0Vh2qGDlLXcRIMJHv3w27eZ+SXOh0FxscIVJAvUOFl4EVjhfs0gEesXNsAhyAqqTnue2B/zFeJXwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=fDJecEfGK1P4+0dFygaKZ65XCd9XW6rL29O5j5dl4n9y0H2yOVOkwxo7bM81AN5JrMlO0XzggtUiRBIjLrKlNvkrcPgZlUdMrDj+OGCADr0SLELkoHas1AafgKqQUsw1tzEzRQ0rdQl1Pmx9jwgPRBzteov2mvYHYUCH9eOlrA2UfyGYI6PAxrJcQ8hKIjOxZnNHdN2jVyZhXcxbtSQRQPIKkXrWMUzj2VveZcKJCXDIKvTVLiTmACiz57EpU7lJ69bQ+rneKHiBg0vGCMn1aC3tHzcJirrDKVBCx6a8L3pltqDOIGfPU0nwWzHUM+k/XTGg74f6thCmuBtoS4Azfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvvWkkQIw2EDI2UOoH1zyEnMBj4a0QaZXykYEIApz5g=; b=bkGixkY8cE/7dMOx0YV/726vzrBc/ZL0xVDWKDWUfqpAWLFWaEPwJWQW7U5/j0Cj7tdc3MKaef4OYapCUqW0v0v32Qv871YAwbDNztEUZbb35fTGhPWKQ1tcuPMosrBr362ryhQMzcrNN7zMxJRWkYRDUPh5jCIt8+14oxmwEGM= From: Bertrand Marquis To: Anthony PERARD CC: Xen-devel , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v3 16/25] libs/libs.mk: Remove the need for $(PKG_CONFIG_INST) Thread-Topic: [XEN PATCH v3 16/25] libs/libs.mk: Remove the need for $(PKG_CONFIG_INST) Thread-Index: AQHYh+RFzqfxR1Q720uC1zVKAzFjWq1v1hUA Date: Tue, 5 Jul 2022 13:27:13 +0000 Message-ID: <44345ED4-CEBB-42F6-970E-B719C3E43842@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-17-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-17-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0c40df7f-ceb1-49d3-7a51-08da5e8a1780 x-ms-traffictypediagnostic: AM6PR08MB3847:EE_|AM5EUR03FT007:EE_|PAXPR08MB6351:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vlyTSSlesfr7GVPxEbXtmZ1heoD5AHtPV1kkCI7mES6pLff4d8X1j3eX3ogB2T0AcbWLIoFj1WIjgNFf2AaK5YuRgMt9W1Ebwbfyz6ClUIpiNBSqggLFFK8usRGjy1tU9srCwGqsRsywEL8W64FMVQSv26EZqDlGRU618rTM/sW/RlVMm1FT/hCSf9ljdU8HQdSgcFnWxkus2iMESDU+YeBzgfefSCC9/+SxERPhlpWlUAUsLtgzooMwvO3M5FZGCEpUqwWThG9g3S4Xy9ubVHPJ7lzvt7l7VttOkMMGx2pFppv1nD+Z/nCxLPdhKQ2QmuWWJb2w+Excx9bHYDiCJ8kpIN9JzbYEnXDomii/N2bSx8ZQsHmAmkaSzmQ8RN/l39ExvR845B+0ZHnCo9HcKRMAb+4DS13mpn94jPxHsQyPGHQ0sQgDTOFNbDfnlC1nqE/HCsEjwnq/tls8ZauMIcH39uescm569V62EJvvsIizEDq6SMuA84QWo5Sq40c0AgZ5V6laWmagBiLj0xVCcx2X+PNATsbvCFGEeFxRS7WmkYCH5folNvBDd5UXjFRkrcXqbt3ZCrcTvZKkg/afS6NQmgAOO81lhgLWeBKt9wCfjRaAmoGhtWKNPEYcO52idzhdoUuy/hQbaSdhJWqcHSwirqzQtCVkups+zb1oFWFl1Ja74/hJTYjeCvB7RmqOANVAxwKnaCs6uzlQHkVoiefrBCdlN72Ha70t+99VW9OLEsDnyC6OTgQ/6HRWNV9Oz1HETfOhdvJNxtQ4oefOOlQoB9KUJjJJGRfs6eDZNGi8ZwaP3X7a1+/P9MTF66TRWh7F4p4Q6jeFIRrvNkgvM3Lu54ry0S5vBvfg3LhQsE4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(186003)(66946007)(66476007)(38070700005)(83380400001)(41300700001)(6512007)(122000001)(38100700002)(91956017)(316002)(33656002)(64756008)(6916009)(71200400001)(6486002)(478600001)(6506007)(54906003)(53546011)(66446008)(8676002)(76116006)(66556008)(2616005)(4326008)(86362001)(8936002)(5660300002)(2906002)(26005)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <4C10717DCDC7E647A67A31733578DDAE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3847 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 44fcbb38-b216-438a-1c27-08da5e8a1269 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5CLDC5GJh63SdusU+G/HDHUDUPl6dEysS2JcwmAsaRuboEcipwDwUXcpa2/RISpVUR2yNx0XrI2tAoWqNP5JbD2u6FPcKC76dViESIgtKYu+wBrFqRc4CYehvPWS08P5X48NoL7bvv13XIt/509bfJZ34f4Im//KIsVVh3W6fn84JiAjImx64WmgTec+S1/9ndVhdTJb7tB3ryCtTXYNfkeyiMmMDPAkOyOrw4Chh1lQasqozrYAxp6GSqGkorSBHzrsEeJjUW4OoDdOoOiDYTfVmCeR/dHRR9KEKAwyZ7vhGedRpSLcZukIJ4oGoFaheshMa76H72Vdjf3wuoLCO9JQXmjriLQt/w5TZh9JjJIrZSAOHrj6Nzm6wZ/Hb1EWrjwdtG24g6/eqKH816Qqvv373ZSSZg9FPjOzmIshOlwAPkWZKrrey6bbTbWUhX4nV7rtvM9mCIjZYxPDfbtppkn5rJtr9+oVAj4Lt6/kFc4R+TgmXPOZtSkvfrBfunl4QPl0lPEMn5lp8Wu5+LQG535QI80Uv5ppuk3e53Dc7LZP44bLjL26ncyz96Ac260DNuFd8B8gGmyPC+t/MldwJ3BxeSMYi0/c13YMxULCizjCIsNRfL4cO7LQner0angyV/w5LcZ9KK9grZSNGe1D/Fcn4OxFeJzCnBDPaGXxI5GsmNUKB3B5z5cTWzNzvyaP1KFwJc9oAAwk17wWFb1CBNdbz3AE2/aFLAQlMLg6/4gLtzqWJ0sHOEa2GYcjNO5CMkXvpzQZXbQ36hMGB3xwCFEDX8u1R18mDxWCyDgdlCAqd9lptJOJUS77Ggvw0kyo X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(40470700004)(46966006)(36840700001)(36860700001)(8936002)(86362001)(40480700001)(81166007)(186003)(47076005)(336012)(107886003)(5660300002)(83380400001)(33656002)(36756003)(356005)(82740400003)(6862004)(478600001)(6506007)(2616005)(6486002)(316002)(26005)(41300700001)(54906003)(6512007)(53546011)(2906002)(70586007)(70206006)(4326008)(8676002)(82310400005)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:27:21.8671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0c40df7f-ceb1-49d3-7a51-08da5e8a1780 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6351 Hi Anthony, > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > We can simply use $(PKG_CONFIG) to set the parameters, and add it to > $(TARGETS) as necessary. >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > tools/libs/libs.mk | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index e02f91f95e..7aee449370 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -37,10 +37,10 @@ PKG_CONFIG_LIB :=3D $(LIB_FILE_NAME) > PKG_CONFIG_REQPRIV :=3D $(subst $(space),$(comma),$(strip $(foreach lib,$= (patsubst ctrl,control,$(USELIBS_$(LIBNAME))),xen$(lib)))) >=20 > ifneq ($(CONFIG_LIBXC_MINIOS),y) > -PKG_CONFIG_INST :=3D $(PKG_CONFIG) > -$(PKG_CONFIG_INST): PKG_CONFIG_PREFIX =3D $(prefix) > -$(PKG_CONFIG_INST): PKG_CONFIG_INCDIR =3D $(includedir) > -$(PKG_CONFIG_INST): PKG_CONFIG_LIBDIR =3D $(libdir) > +TARGETS +=3D $(PKG_CONFIG) > +$(PKG_CONFIG): PKG_CONFIG_PREFIX =3D $(prefix) > +$(PKG_CONFIG): PKG_CONFIG_INCDIR =3D $(includedir) > +$(PKG_CONFIG): PKG_CONFIG_LIBDIR =3D $(libdir) > endif >=20 > PKG_CONFIG_LOCAL :=3D $(PKG_CONFIG_DIR)/$(PKG_CONFIG) > @@ -55,7 +55,7 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR =3D $(XEN_INCLUD= E) > $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR =3D $(CURDIR) >=20 > .PHONY: all > -all: headers.chk $(TARGETS) $(PKG_CONFIG_INST) $(PKG_CONFIG_LOCAL) libxe= n$(LIBNAME).map $(LIBHEADERS) > +all: headers.chk $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(L= IBHEADERS) >=20 > ifneq ($(NO_HEADERS_CHK),y) > headers.chk: > @@ -127,7 +127,6 @@ clean:: > rm -rf $(TARGETS) *~ $(DEPS_RM) $(OBJS-y) $(PIC_OBJS) > rm -f lib$(LIB_FILE_NAME).so.$(MAJOR).$(MINOR) lib$(LIB_FILE_NAME).so.$(= MAJOR) > rm -f headers.chk headers.lst > - rm -f $(PKG_CONFIG) >=20 > .PHONY: distclean > distclean: clean > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:28:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:28:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361276.590699 (Exim 4.92) (envelope-from ) id 1o8ibJ-0002Is-FY; Tue, 05 Jul 2022 13:28:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361276.590699; Tue, 05 Jul 2022 13:28:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ibJ-0002Il-BB; Tue, 05 Jul 2022 13:28:25 +0000 Received: by outflank-mailman (input) for mailman id 361276; Tue, 05 Jul 2022 13:28:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ibH-0002FI-SH for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:28:24 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5756e15b-fc66-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:28:22 +0200 (CEST) Received: from DU2PR04CA0320.eurprd04.prod.outlook.com (2603:10a6:10:2b5::25) by AM4PR08MB2753.eurprd08.prod.outlook.com (2603:10a6:205:b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 13:28:20 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::cb) by DU2PR04CA0320.outlook.office365.com (2603:10a6:10:2b5::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 13:28:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:28:19 +0000 Received: ("Tessian outbound 879f4da7a6e9:v121"); Tue, 05 Jul 2022 13:28:19 +0000 Received: from b0ca8669104f.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB140AC8-CFD2-4CD3-99AF-18B2794C3B0A.1; Tue, 05 Jul 2022 13:28:08 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b0ca8669104f.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:28:08 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM9PR08MB6676.eurprd08.prod.outlook.com (2603:10a6:20b:2ff::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:28:05 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Tue, 5 Jul 2022 13:28:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5756e15b-fc66-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EURIAwbY+n70QWF6BBS2+/nedY4JwqsRp8z12XK/rO82RSs3H/Oe0HZUUqS3LQ+fKNI1IgDN/V+SsLwXAvwLyqJOSBqWQmmiVA0OaVJ3OgCAi7QvS7Kwom1ByFRRbwwJh9ZtZNY8FxE0btGrNBtL5YTgbqhbRP/5l6dTo3EHVz2gY0ne9alG85z5gzl3IElc6WP9XCnhQwzk2+XvTDLyXQXfP+nJfP8QQO1VGZMKf6GU4NqGyr50iuluuQoOmT2dp2KVvkQiJt1VZweqKPGDFOHmLaAvjr/l7ZWKlenwGtBdac+FmZ44cRXUMvy1EqmibKFvycw+lAugaollL/xv+w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuxF+E5c0NFcvjIRz9Oz5mpwJkWf85WGb601UpzGeZk=; b=PZVb0M1S9y388rqh+/Gj64LBVxr93DLdEiMWxfO7/YoUiQ2IO/Mimo2TT0VEv4EC+l5JBlBvw6VR6XlNGqqaXzJuipBy5K/4dugF7cjA0GYVI6HU5ekbqUucSpocOqJMluTLnU3z3SDkI8BL447Bl9tI61WrxfAacQQEtYPI+7hFOLR6BkBUutVVFXGqQNWBSbx/SwIVn5rMJyembpGNnmLxg0bWkVidh8jIE0qSmd3+BonmdxdTYkw4+ZRiNXhzIzLRS+iZVvfln5VLpPFjJ9t+ik8LuUnrXv6Ns2VmpYF6wRIbbK6yOGCe4V4H1ysXUd0xqFsK23i0j4GsLNLlSw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuxF+E5c0NFcvjIRz9Oz5mpwJkWf85WGb601UpzGeZk=; b=QTlh5SdnMZb7qB6TAEmSxYP+FyL0u1spns4Stq9EjgJnuX3J19Ev8oiLDPi3eKq33LLN0TSTH/OiQBXp3A6hicRWxLGw2BxebyPu4+o4xH3UacLCvDf8mWXFNZ1/uYgIlG0OtiQ5lKFT7G9hN3S6KZmUIbcyVWtaCCjtoykPiOM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9399af79af11ef54 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GyxiEcQfW9+EXbH6v8B56sN2iEwMcMHz/mX+t2GJzcjVUmdpLC41X3eveYZB/K9fbVqa+o1tGBKpEZBYhSBIX8nCTFB5yYfF4nIt8amW6XGXzmy+/mdWeiWvfKuBTdtXb20ChGGHOkjulL6YmoazfGpJ4NkS8O//zqxTRn0Ehfkt0t30A75YRHJdGsVEPHnRtR8zezZk0KabBw1x2jjTdi+lsoFRoOLqO1tCBiBbMINJYRoRg4JEkkkUTkRuAnMnSca1FH6G3PIv4LnHo66cd0IkuIIO2RYxh63bdxSLmMErSLs65OiiHFh3nF8BQl6gnmV6oPXJo2pmXxoa/q6fHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuxF+E5c0NFcvjIRz9Oz5mpwJkWf85WGb601UpzGeZk=; b=Cf0KRR12gSR3TyctxmkQaPKqLcYkYaVrmI1t3h2y6gKhjtfKf0zJsIUHTXgy7XsucqE5GBdtN/h/s0y9q0mDBjdrmhllSRoP7jIvO1q6SWPCjcXvIimZ96DZSTESxhJ9mfxNuGVd5SUYNxfa+akRqz2+luGXp51aFkWsjxGKk1IjuJUubRTaw4haHywln3USpdW+FLBg7f7aM8B4MSjxeRInni41bbvr7DH+XSEVZAqUwU7g7FrRyZL68IU8EheOQJM+MJHWt0kilSoqBET6g0guVqMgXnATWoRP34IsczaDG47HMwXI04C+SHH3Krg91xFnVxSugUCtGxqs0lddGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuxF+E5c0NFcvjIRz9Oz5mpwJkWf85WGb601UpzGeZk=; b=QTlh5SdnMZb7qB6TAEmSxYP+FyL0u1spns4Stq9EjgJnuX3J19Ev8oiLDPi3eKq33LLN0TSTH/OiQBXp3A6hicRWxLGw2BxebyPu4+o4xH3UacLCvDf8mWXFNZ1/uYgIlG0OtiQ5lKFT7G9hN3S6KZmUIbcyVWtaCCjtoykPiOM= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Topic: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Index: AQHYhkX79rj81mJ150e3nBZ0EA7O6K1bhmuAgAGTuoCAAAWegIAHwJEAgAAJPQCAAAcgAIAAB1iAgArhiIA= Date: Tue, 5 Jul 2022 13:28:05 +0000 Message-ID: References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> In-Reply-To: <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6fb5bac5-853b-4a57-6e1f-08da5e8a3a1a x-ms-traffictypediagnostic: AM9PR08MB6676:EE_|DBAEUR03FT018:EE_|AM4PR08MB2753:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LA5xWoCJrmO7WBkRqa1ERZ3yzqRcxe6kG7DnvvvdtYmwOZfoOfa7ymwIl1kyWPAiz59LyozZKNtvscGZh7fwFiogjFLTbAmR/E7TqSOOeOAwD4fq+WJnLHTuk/yhvRgn7fNiallojv341MrmBs7FLD+Mo5ru51hn/ITp1tcGB2AeSSdGgKF5TEGAAOzErePfPMSmXCENfD4kZ+5Ws1zLqsQKW3wUyB7u0RMrLADUcz8KFsvQv9kyoOUvWVNaD1X64Ol62One0/KSBuohd1sL/HUJEUDBJhPD4B2oVI0MW0i/qfilNWQaMsmuDkdIxshQXGotthgFk1zvnPX9SNjO4snLdbzdc1swM7s0A5NwMuz/KiVSD5RDhAPW1RUEYw2h53ugwj4Xf5k6nsKm9MvUpyYCagMCDiZRSqnDdCZWqjrxrvGBHgBnK3U7ux7SrBVDvnMTZYJ5TRW/3XjWggorXJs9ybNjEIUgQZjL7JBoT/dybWwwA8+W7URSnvnKHO335cfnAux8NjWv5aQiz9wgELP59ejau+vPBvE42RhekXL+NDzJYR02z/ytAWS26gwhynA6spYy+4BQz9v/jGtoqufTNmf3/2q0bl18KlxbxEHr/dqZJLBv5TJzMfwX2yQB3sWTn2PZ+4eymCEWdR3T2ao6U1haekxFYX2qWlJZOiy8rg6MPprUe9Iox4s2xxGTPuuM1fvcqLKnPof9kFhs1buL6vrCNncK2DZTh0Gogmi8fNBSgNplkDnYpB/EUbuQGnBi88f8OLL6SyynDuA1gLKQ0NHinWACGmhfdSxV8+p4+GJeer4EvRv+tfN+H77baoZSYag7PBMsx8WRxw+idsLwOO64eTAdg2y7G4e6F6k= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(366004)(346002)(66476007)(4326008)(8676002)(66556008)(66946007)(2616005)(66446008)(64756008)(91956017)(186003)(83380400001)(33656002)(2906002)(6506007)(36756003)(76116006)(38100700002)(71200400001)(26005)(6512007)(6486002)(54906003)(478600001)(41300700001)(5660300002)(86362001)(53546011)(38070700005)(316002)(122000001)(6916009)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <3C0447144E1CBF47B27402C5BA3CB58E@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6676 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9bb91f00-3301-4984-67eb-08da5e8a3170 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RxqKac5RX32/QChL4z+vehm1GhPUMgGCmX2AP/e/Zv/kpFZc0X8+Ud9ok0ykz677FZxiIPUqJTOZVhEwwIOMBU6lM7IA69yJlt7JWfjKxoAV+4dyoIANf5WYjsNIiH3SZsfL4StUG3apL0+tXmP4DeLF28xbyboVbLH2iSwi5JTvk/qwIBGNWFb92UCDMERZJnMPW81SrxuQDUxbmx4SUNE/bHJyL82Nc2h3gaLPiXKjCNB9LYVlLIkU1VUt+EFIuZcTNY+y+5Rc+JbLIS0WoZ8yyRx3aRu9VRoe29BGfVpQb9o0fDV6y6V+MTZmpxeWF7buZ3bbwE9B3THnblqoIXmR6Hquz5ge7vjM2yYeTbyLOZeqVV2oVtLYK7z1ZPxfqlm8dbw84KzXkQUIBEOCzwIGWG5x0R/bzgP6S+Fb4n8ldFCpwDwo4NuE7TLWIHzvMsEt/AiJkb+JwFUsIFAct1tpvHJ9X4QJ7CGGD+z64fRLKD6Ro74od62r/VPlJiiOe2amP+zH3bLzpF4mXChPx1fth2FQTgaW6JMmmSQV65sJk8yYiCVeODS4eeR6KxNBLgOYaPNDzVPAoXIkj7sYXwrF/yrILp/TBzOPySSk3ZxlyRmiJynVpIE3SMZE40c/ROk77W9AlrSsGDCKixGmgZr3BR6zfyQotxKLNZ196zEJi4q3UEzqHrLNiN55PTA1+mK+ArqRPNSsmLL9XMS7kPh3oFs78p1RZLwEEse6ckwXHGpoc+E0Ex1JN606D6QqBpGm1VHlXqr3oZUKDzcw0qCroRG4rXba0Lc5+y4VoVrUyf7c9BT3ZjfJlZJUxq0V X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(136003)(376002)(40470700004)(36840700001)(46966006)(33656002)(40460700003)(36860700001)(86362001)(82740400003)(356005)(82310400005)(8936002)(81166007)(6486002)(41300700001)(2906002)(6862004)(5660300002)(316002)(54906003)(478600001)(70206006)(70586007)(47076005)(336012)(40480700001)(186003)(83380400001)(6506007)(26005)(6512007)(2616005)(36756003)(8676002)(4326008)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:28:19.9498 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6fb5bac5-853b-4a57-6e1f-08da5e8a3a1a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2753 SGkgSnVsaWVuLA0KDQoNCj4gT24gMjggSnVuIDIwMjIsIGF0IDQ6MTggcG0sIEp1bGllbiBHcmFs bCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAyOC8wNi8yMDIyIDE1 OjUyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4gSGkgSnVsaWVuLA0KPj4+IE9uIDI4IEp1 biAyMDIyLCBhdCAxNToyNiwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+ Pj4gDQo+Pj4gDQo+Pj4gDQo+Pj4gT24gMjgvMDYvMjAyMiAxNDo1MywgUmFodWwgU2luZ2ggd3Jv dGU6DQo+Pj4+IEhpIEp1bGllbg0KPj4+IA0KPj4+IEhpIFJhaHVsLA0KPj4+IA0KPj4+Pj4gT24g MjMgSnVuIDIwMjIsIGF0IDQ6MzAgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdy b3RlOg0KPj4+Pj4gDQo+Pj4+PiANCj4+Pj4+IA0KPj4+Pj4gT24gMjMvMDYvMjAyMiAxNjoxMCwg UmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+Pj4gSGkgSnVsaWVuLA0KPj4+Pj4+PiBPbiAyMiBKdW4g MjAyMiwgYXQgNDowNSBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+ Pj4+Pj4+IA0KPj4+Pj4+PiBIaSwNCj4+Pj4+Pj4gDQo+Pj4+Pj4+IE9uIDIyLzA2LzIwMjIgMTU6 MzgsIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+Pj4+Pj4gR3Vlc3QgY2FuIHJlcXVlc3QgdGhlIFhl biB0byBjbG9zZSB0aGUgZXZlbnQgY2hhbm5lbHMuIElnbm9yZSB0aGUNCj4+Pj4+Pj4+IHJlcXVl c3QgZnJvbSBndWVzdCB0byBjbG9zZSB0aGUgc3RhdGljIGNoYW5uZWxzIGFzIHN0YXRpYyBldmVu dCBjaGFubmVscw0KPj4+Pj4+Pj4gc2hvdWxkIG5vdCBiZSBjbG9zZWQuDQo+Pj4+Pj4+IA0KPj4+ Pj4+PiBXaHkgZG8geW91IHdhbnQgdG8gcHJldmVudCB0aGUgZ3Vlc3QgdG8gY2xvc2Ugc3RhdGlj IHBvcnRzPyBUaGUgcHJvYmxlbSBJIGNhbiBzZWUgaXMuLi4NCj4+Pj4+PiBBcyBhIHN0YXRpYyBl dmVudCBjaGFubmVsIHNob3VsZCBiZSBhdmFpbGFibGUgZHVyaW5nIHRoZSBsaWZldGltZSBvZiB0 aGUgZ3Vlc3Qgd2Ugd2FudCB0byBwcmV2ZW50DQo+Pj4+Pj4gdGhlIGd1ZXN0IHRvIGNsb3NlIHRo ZSBzdGF0aWMgcG9ydHMuDQo+Pj4+PiBJIGRvbid0IHRoaW5rIGl0IGlzIFhlbiBqb2IgdG8gcHJl dmVudCBhIGd1ZXN0IHRvIGNsb3NlIGEgc3RhdGljIHBvcnQuIElmIHRoZSBndWVzdCBkZWNpZGUg dG8gZG8gaXQsIHRoZW4gaXQgd2lsbCBqdXN0IGJyZWFrIGl0c2VsZiBhbmQgbm90IFhlbi4NCj4+ Pj4gSXQgaXMgb2theSBmb3IgdGhlIGd1ZXN0IHRvIGNsb3NlIGEgcG9ydCwgcG9ydCBpcyBub3Qg YWxsb2NhdGVkIGJ5IHRoZSBndWVzdCBpbiBjYXNlIG9mIGEgc3RhdGljIGV2ZW50IGNoYW5uZWwu DQo+Pj4gQXMgSSB3cm90ZSBiZWZvcmUsIHRoZSBPUyB3aWxsIG5lZWQgdG8ga25vdyB0aGF0IHRo ZSBwb3J0IGlzIHN0YXRpY2FsbHkgYWxsb2NhdGVkIHdoZW4gaW5pdGlhbGl6aW5nIHRoZSBwb3J0 ICh3ZSBkb24ndCB3YW50IHRvIGNhbGwgdGhlIGh5cGVyY2FsbCB0byBiaW5kIHRoZSBldmVudCBj aGFubmVsKS4gQnkgZXh0ZW5kLCB0aGUgT1Mgc2hvdWxkIGJlIGFibGUgdG8ga25vdyB0aGF0IHdo ZW4gY2xvc2luZyBpdCBhbmQgc2tpcCB0aGUgaHlwZXJjYWxsLg0KPj4+IA0KPj4+PiBYZW4gaGFz IG5vdGhpbmcgdG8gZG8gZm9yIGNsb3NlIHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbCBhbmQganVz dCByZXR1cm4gMC4NCj4+PiANCj4+PiBYZW4gd291bGQgbm90IG5lZWQgdG8gYmUgbW9kaWZpZWQg aWYgdGhlIE9TIHdhcyBkb2luZyB0aGUgcmlnaHQgKGkuZS4gbm8gY2FsbGluZyBjbG9zZSkuDQo+ Pj4gDQo+Pj4gU28gaXQgaXMgc3RpbGwgdW5jbGVhciB3aHkgcGFwZXJpbmcgb3ZlciB0aGUgaXNz dWUgaW4gWGVuIGlzIHRoZSBiZXN0IHNvbHV0aW9uLg0KPj4gSXQgaXMgbm90IHRoYXQgYSBzdGF0 aWMgZXZlbnQgY2hhbm5lbCBjYW5ub3QgYmUgY2xvc2VkLCBpdCBpcyBqdXN0IHRoYXQgZHVyaW5n IGEgY2xvc2UgdGhlcmUgaXMgbm90aGluZyB0byBkbyBmb3IgWGVuIGFzIHRoZSBldmVudCBjaGFu bmVsIGlzIHN0YXRpYyBhbmQgaGVuY2UgaXMgbmV2ZXIgcmVtb3ZlZCBzbyBub25lIG9mIHRoZSBv cGVyYXRpb25zIHRvIGJlIGRvbmUgZm9yIGEgbm9uIHN0YXRpYyBvbmUgYXJlIG5lZWRlZCAobWF5 YmUgc29tZSBkYXkgc29tZSB3aWxsIGJlLCB3aG8ga25vd3MpLg0KPiANCj4gSSBmZWVsIHRoZXJl IGFyZSBzb21lIGRpc2FncmVlbWVudCBvbiB0aGUgbWVhbmluZyBvZiAiY2xvc2UiIGhlcmUuIElu IHRoZSBjb250ZXh0IG9mIGV2ZW50IGNoYW5uZWwsICJjbG9zZSIgbWVhbnMgdGhhdCB0aGUgcG9y dCBpcyBtYXJrZWQgYXMgRUNTX0ZSRUUuDQo+IA0KPiBTbyBJIHRoaW5rIHRoaXMgaXMgd3Jvbmcg dG8gc2F5IHRoYXQgdGhlcmUgaXMgbm90aGluZyB0byBkbyBmb3IgImNsb3NlIiBiZWNhdXNlIGFm dGVyIHRoaXMgb3BlcmF0aW9uIHRoZSBwb3J0IHdpbGwgc3RpbGwgYmUgIm9wZW4iICh0aGUgcG9y dCBzdGF0ZSB3aWxsIGJlIEVDU19JTlRFUkRPTUFJTikuDQo+IA0KPiBJbiBmYWN0LCB0byBtZSwg YSAic3RhdGljIiBwb3J0IGlzIHRoZSBzYW1lIGFzIGlmIHRoZSBldmVudCBjaGFubmVsIHdhcyBh bGxvY2F0ZWQgZnJvbSB0aGUgdG9vbHN0YWNrIChmb3IgaW5zdGFuY2UgdGhpcyBpcyB0aGUgY2Fz ZSBmb3IgWGVuc3RvcmVkKS4gSW4gc3VjaCBjYXNlLCB3ZSBhcmUgc3RpbGwgYWxsb3dpbmcgdGhl IGd1ZXN0IHRvIGNsb3NlIHRoZSBwb3J0IGFuZCB0aGVuIHJlLW9wZW5pbmcuIFNvIEkgZG9uJ3Qg cmVhbGx5IHNlZSB3aHkgd2Ugc2hvdWxkIGRpdmVyZ2UgaGVyZS4NCj4gDQo+PiBXaHkgcmVxdWly aW5nIHRoZSBPUyB0byBoYXZlIHRoZSBrbm93bGVkZ2Ugb2YgdGhlIGZhY3QgdGhhdCBhbiBldmVu dCBjaGFubmVsIGlzIHN0YXRpYyBvciBub3QgYW5kIGludHJvZHVjZSBzb21lIGNvbXBsZXhpdHkg b24gZ3Vlc3QgY29kZSBpZiB3ZSBjYW4gcHJldmVudCBpdCA/DQo+IA0KPiBJIGFtIGNvbmZ1c2Vk LiBZb3VyIE9TIGFscmVhZHkgbmVlZCB0byBrbm93IHRoYXQgdGhpcyBpcyBhIHN0YXRpYyBwb3J0 IChzbyBpdCBkb2Vzbid0IGNhbGwgdGhlIGh5cGVyY2FsbCB0byAib3BlbiIgdGhlIHBvcnQpLiBT byB3aHkgaXMgaXQgYSBub24taXNzdWUgZm9yICJvcGVuaW5nIiBidXQgb25lIGZvciAiY2xvc2lu ZyIgPw0KPiANCj4+IERvaW5nIHNvIHdvdWxkIG5lZWQgdG8gaGF2ZSBhIHNwZWNpZmljIGJpbmRp bmcgaW4gZGV2aWNlIHRyZWUgKG5vdCB0byBtZW50aW9uIHRoZSBpc3N1ZSBvbiBBQ1BJKSwgDQo+ IA0KPiBZb3UgYWxyZWFkeSBuZWVkIHRvIGNyZWF0ZSBhIERldmljZS1UcmVlIGJpbmRpbmcgdG8g ZXhwb3NlIHRoZSBzdGF0aWMgZXZlbnQtY2hhbm5lbC4gU28gd2h5IGlzIHRoaXMgYSBuZXcgcHJv YmxlbT8NCj4gDQo+IExpa2V3aXNlIGZvciBBQ1BJLCB5b3UgYWxyZWFkeSBoYXZlIHRoaXMgaXNz dWUgd2l0aCB5b3VyIGN1cnJlbnQgcHJvcG9zYWwuDQo+IA0KPj4gYSBuZXcgZHJpdmVyIGluIGxp bnV4IGtlcm5lbCwgZXRjIHdoZXJlIHJpZ2h0IG5vdyB3ZSBqdXN0IG5lZWQgdG8gaW50cm9kdWNl IGFuIGV4dHJhIElPQ1RMIGluIGxpbnV4IHRvIHN1cHBvcnQgdGhpcyBmZWF0dXJlLg0KPiANCj4g SSBkb24ndCB1bmRlcnN0YW5kIHdoeSB3b3VsZCBuZWVkIGEgbmV3IGRyaXZlciwgZXRjLiBHaXZl biB0aGF0IHlvdSBhcmUgaW50cm9kdWNpbmcgYSBuZXcgSU9DVEwgeW91IGNvdWxkIHBhc3MgYSBm bGFnIHRvIHNheSAiVGhpcyBpcyBhIHN0YXRpYyBldmVudCBjaGFubmVsIHNvIGRvbid0IGNsb3Nl IGl0Ii4NCg0KSSB0cmllZCB0byBpbXBsZW1lbnQgb3RoZXIgc29sdXRpb25zIHRvIHRoaXMgaXNz dWUuIFdlIGNhbiBpbnRyb2R1Y2UgYSBuZXcgZXZlbnQgY2hhbm5lbCBzdGF0ZSDigJxFQ1NfU1RB VElD4oCdIGFuZCBzZXQgdGhlDQpldmVudCBjaGFubmVsIHN0YXRlIHRvIEVDU19TVEFUSUMgd2hl biBYZW4gYWxsb2NhdGUgYW5kIGNyZWF0ZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWxzLg0KDQpG cm9tIGd1ZXN0IE9TIHdlIGNhbiBjaGVjayBpZiB0aGUgZXZlbnQgY2hhbm5lbCBpcyBzdGF0aWMg KHZpYSBFVlRDSE5PUF9zdGF0dXMoKSAgaHlwZXJjYWxsICksIGlmIHRoZSBldmVudCBjaGFubmVs IGlzDQpzdGF0aWMgZG9u4oCZdCB0cnkgdG8gY2xvc2UgdGhlIGV2ZW50IGNoYW5uZWwuIElmIGd1 ZXN0IE9TIHRyeSB0byBjbG9zZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwgWGVuIHdpbGwgcmV0 dXJuIGVycm9yIGFzIHN0YXRpYyBldmVudCBjaGFubmVsIGNhbuKAmXQgYmUgY2xvc2VkLg0KDQpk aWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMgYi9kcml2ZXJzL3hl bi9ldmVudHMvZXZlbnRzX2Jhc2UuYw0KaW5kZXggNDZkOTI5NWQ5YTZlLi5jNWNhMjliOGVkNzAg MTAwNjQ0DQotLS0gYS9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYw0KKysrIGIvZHJp dmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMNCkBAIC04MTUsOCArODE1LDE3IEBAIHN0YXRp YyB2b2lkIHhlbl9mcmVlX2lycSh1bnNpZ25lZCBpcnEpDQogDQogc3RhdGljIHZvaWQgeGVuX2V2 dGNobl9jbG9zZShldnRjaG5fcG9ydF90IHBvcnQpDQogew0KKyAgICAgICBzdHJ1Y3QgZXZ0Y2hu X3N0YXR1cyBzdGF0dXM7DQogICAgICAgIHN0cnVjdCBldnRjaG5fY2xvc2UgY2xvc2U7DQogDQor ICAgICAgIHN0YXR1cy5kb20gPSBET01JRF9TRUxGOw0KKyAgICAgICBzdGF0dXMucG9ydCA9IHBv cnQ7DQorICAgICAgIGlmIChIWVBFUlZJU09SX2V2ZW50X2NoYW5uZWxfb3AoRVZUQ0hOT1Bfc3Rh dHVzLCAmc3RhdHVzKSAhPSAwKQ0KKyAgICAgICAgICAgICAgIEJVRygpOw0KKw0KKyAgICAgICBp ZiAoc3RhdHVzLnN0YXR1cyA9PSBFVlRDSE5TVEFUX3N0YXRpYykNCisgICAgICAgICAgICAgICBy ZXR1cm47DQorDQogICAgICAgIGNsb3NlLnBvcnQgPSBwb3J0Ow0KICAgICAgICBpZiAoSFlQRVJW SVNPUl9ldmVudF9jaGFubmVsX29wKEVWVENITk9QX2Nsb3NlLCAmY2xvc2UpICE9IDApDQogICAg ICAgICAgICAgICAgQlVHKCk7DQoNCg0KUmVnYXJkcywNClJhaHVsDQo+IA0KPiBDaGVlcnMsDQo+ IA0KPiAtLSANCj4gSnVsaWVuIEdyYWxsDQoNCg== From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:29:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:29:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361282.590710 (Exim 4.92) (envelope-from ) id 1o8icG-0002wA-UH; Tue, 05 Jul 2022 13:29:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361282.590710; Tue, 05 Jul 2022 13:29:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8icG-0002w3-PQ; Tue, 05 Jul 2022 13:29:24 +0000 Received: by outflank-mailman (input) for mailman id 361282; Tue, 05 Jul 2022 13:29:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8icF-0002ps-7l for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:29:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b18c8ba-fc66-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:29:22 +0200 (CEST) Received: from DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) by DU0PR08MB7519.eurprd08.prod.outlook.com (2603:10a6:10:321::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Tue, 5 Jul 2022 13:29:20 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::30) by DB6PR07CA0067.outlook.office365.com (2603:10a6:6:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.14 via Frontend Transport; Tue, 5 Jul 2022 13:29:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:29:20 +0000 Received: ("Tessian outbound d5fa056a5959:v121"); Tue, 05 Jul 2022 13:29:20 +0000 Received: from e52ec1b325ec.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2184590D-EA4D-45A5-84E7-8889E85CE566.1; Tue, 05 Jul 2022 13:29:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e52ec1b325ec.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:29:13 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3847.eurprd08.prod.outlook.com (2603:10a6:20b:8a::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Tue, 5 Jul 2022 13:29:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Tue, 5 Jul 2022 13:29:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b18c8ba-fc66-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m88tbrFWFCZwBr3eP263jlwqRkw8s9Q6PWLXhKMNj6zNJjiyZTfHxW6H7qnTZCp/lzhG1mUc+noT34sw6Z/ZtmPAj+pOkiAzcTVPU+P4lfEKnEyW7s2sKAQfS+KNfxik4yBMm5khJ6TIjLdPAir1S/gzInZBYTAlHPP83s5mcF4VHSwSgM+BoFWpQkpfJE8cYoBKaj6CSuSLRNGbqOPbYjpUZpcPLr9IFZ8AzgXTV1oGmmTqbjndliyQvWTuQML8tXSAIlEvhw4abGN5RCyZF5NcL8RfigcLC7cU3wr+/mSaCZRsrZeYowTo7CniAWokalGFKaObgoGfxNK7eFTk6A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=JZmQuPe3Va9o12JN/AeuAzRckX0Si+i7ClhJuyDXVmotuOTpeRmQEEBCXgMnjHoqJ2twMmkwNshRIvjkJW9jUpDWZWg3MPHGQMqZtjwf4IbUcSN+1gm/7xQOHJboIkgvqD8HAxzunLHbfYQECgweJyXB7EFGWo6xXlyj6wv8kb+8vhuV8evTyBlCRBsPuiCVrrTdtDgGgXAuEPT+F/Ns7P+zHDPbPKSKIrhzcfCYyvnhMT9oaMZugYsu/VGoIZ8LfEMxCR9du8GQim+P8WAazHMOchPnbTJ8kgXWzlcANHK3K4OMt+ZeVZ1j2E4TbbBmM/KPN/AWuvekL2AyAt+OOQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=B0S2G9KYFI5xcZ/z2X2g/7e29ibEW+vtck6CEvrpWkXE4iM48out1K3zLdbxL7hAyrbd93DgGUpZmeljvABVV8KDOITIRzJZaKDoxgUaHPlDen6q/Cacq5rsoSIxHFsBPVC4qiZYlCiSQCwh1BhuukVbZtEw27MI1g+UKdTJfM4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3cd7bb388d1e3c19 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dlngEC1QADEXjnNopGdN6Ywj7cLcnA46tc4ERYwJf00/auUEG9doUhEKUnxBganSnUyfut40CZzZ9DEYFgjmXDYzcM8lwsj46iQyMP4cXIYW2JzQEUNXjbfDDzkQB2c20n/Iy7HKIr4Yxze/ovjuDn/+9Af1oqYppx3Haze/BjkYf3sDUehOrhSHdbcr+5JQPpaEUDGbHatJbv6CQjmiv/ddYqSL89DLPblhbYInm7vgKmwHEqbMSzEpYTIUwCsjnpGlXDCixnMHVGc/X/+YJECcNG6gCHjC3aPevmUkT2cHp+bO0DSFPU+V/OWNtQVLo0tfZPm3D8rYo0ns9iQvkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=HKC2JaxF5mN3HSbkMJpMXRTDVG4gswNmt58dtXLtN7A+OjE/X7kyKy54P707/Fu7KRvXYQF/EjKDuuL5AV4k0cWexwQrZXqvA8Iy1bBbEGF1sS9lInr9VQ1OILr0yk38bSOzFC5CJ9LRvQRcgyLJnpffyKrF1bqm5+HiBAaPL1VbRT3tz9ySM4iEuyobbuafidEPK891Qae2A/BLHPUpIpijQyGEr+TepMP9f0Tdim1AJUqJfIeofhdclMm54jQM8tSNSXKjY7E4WSAamB7dIsONSBUi9e12PR1PWBWNFQ6xd74SQLaK977ZGTPckJryKjBG3AXfJk1233DX0kh58Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QZRUVt6T4fRC/hSuLzaHk5FIy9dURYF/Ez4GzpFDPTY=; b=B0S2G9KYFI5xcZ/z2X2g/7e29ibEW+vtck6CEvrpWkXE4iM48out1K3zLdbxL7hAyrbd93DgGUpZmeljvABVV8KDOITIRzJZaKDoxgUaHPlDen6q/Cacq5rsoSIxHFsBPVC4qiZYlCiSQCwh1BhuukVbZtEw27MI1g+UKdTJfM4= From: Bertrand Marquis To: Anthony PERARD CC: Xen-devel , Wei Liu , Juergen Gross Subject: Re: [XEN PATCH v3 17/25] libs/libs.mk: Rework target headers.chk dependencies Thread-Topic: [XEN PATCH v3 17/25] libs/libs.mk: Rework target headers.chk dependencies Thread-Index: AQHYh+Q1zaZSd9AMO0OKzG6eXIwYj61v1qOA Date: Tue, 5 Jul 2022 13:29:11 +0000 Message-ID: <89F3BCB5-FD43-4091-8E10-4E03144D9C40@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-18-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-18-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3d019dfa-2017-4296-ecf0-08da5e8a5e0d x-ms-traffictypediagnostic: AM6PR08MB3847:EE_|DBAEUR03FT013:EE_|DU0PR08MB7519:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MBcypdyQmcJ8YoUds28rmqgZlANhwzGrUonWsuZ4f1FQ9hAsnsTv1MMf0xpZh1/aoD7jGsey0lfb5cdSiwkBwXBchvihszdV7jRC4045N5JYtzp+5VDWK3ifKmKpKzHLm5DcClZw9ioCQKiiF5EWPU8j7wJWiCic0tmUU2p1t/35dWiU2aqDlkmFAIQmK3eWPsempWm3tJIm3fg7oT9nwQlELYXgtcSW7svnA2j/yRtGBia2MnvPiM+c3b22asK9SmsAgHspTBTh8QEn2EYm9tkatrQbZnYkqe4kRwx06hsysh0a4XJpp6j8ooyPtnnf8sycHLD04swDu7Tbk+Yx5yTsqUfmxA5Yt1NXa4VxCzzYQgSM6EkWstPsgPfwH7cZ49yO04n7nVW9qFiyCX11IKfbR2jQghPnDxqYnCUgVK1NZyy2t2Q2nNVkanXc219RIgvpPpPu25Yy0EbQoQt4PAG7A+exRwbxrbGl4aKGp3pjDbLam6mLYKoD2/A6wUS8jA1NKc+/bf6IuwzjFn4hwpiXFKCkGUYzuY4vRx+YweKiqFGfSAdsd+1AthtAXs8p3GJALyIgk0+ZV2hJIInR4TJTuBH2EI0K3jKHwg4N2hOWeqY66pExvNM66A7WlIzvxiFOW65jzPTQOrJUxrUA77bjc7Vs3U5feWc60u4pcdWsnxdPw/JEMu8dkI6J3YxcVcmzCKP1IoGJxSwr05SXWg+JSalqjnGFFQaHiFcohFlSwb1TwP64xunfMkameDeHVIfv+pKqkTaKEMLSvbXZqrW9tOKbofoapOta/vqNIwqu0OAoB9bxh1xdzBbEFzyAyPyqFyWdyuXGZ5S/AFV9qFReka1F/3ul3qOUOoWkkh0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(136003)(39860400002)(346002)(186003)(66946007)(66476007)(38070700005)(83380400001)(41300700001)(6512007)(122000001)(38100700002)(91956017)(316002)(33656002)(64756008)(6916009)(71200400001)(6486002)(478600001)(6506007)(54906003)(53546011)(66446008)(8676002)(76116006)(66556008)(2616005)(4326008)(86362001)(8936002)(5660300002)(2906002)(26005)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3847 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 182901f9-ce7f-4309-099e-08da5e8a58cc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nFNDNRPdPdg2kaWtBRpWjoBpkpOT2Jx+THgHH5HjTGuYsN2UTmIEHzi9HQFVqSMjSREFrWxigrT6Xfo59MoaPlRHpm83V3nSgARr8OPtct9a/w32yQqjTL1VBjctx0gEBfuqEWLfzzI0HfuwTmx7RU2LtX1yilbVc+Nue27aKheM9UBhOk7nX0ao5qqjqEjNaZobSxDZ6c4CdocjAYZ94IynMjA7dA8kmamRugZIC7zLCc0omh9DHLJmwRoqDX1KiUDNfLuVpMqzm2VKe8fpkH4x5dxKb8Bm/OsY9pTm7aKqqF03rGzTdmI9bgD1N2G7UbTA0SMsX9ZAZLMtes1KJ9tSgdAZEswpfP809tm0twozfYQVJ6WVaIINlGP2h65XYBH8c+kHxpDEoTnhsGUlis0N1d/DsTGbcjy6OCf/lr6VUSDiIKKmZErNE8ALAFt8yG1IM102rqz5pSao3ByTjT+Un2iOPUR7ILwRjmR6emkf3LK1igmUIYWOX/6Aa3OwLGODKlsk9K8t4XHBRgz5Q3NCbRr4qY+MPsmUK4F4WEqk9mKDK4LqGyCXGZV4nT0XzE5ki+zcsf6bjx3IPJKFJrZ8f/yPdQyG9XMXlkvAYInsZ1h9s/CCw0E+3USbhqxSSeaEq3VgWRxihmOBBx+e8GBeSaS763e+SYWvI480f8RCjZO0UdLYPYQQEYkfBCftdcNJJ7uOsvnBeJ05MfSBPjFnaO2ihlx7uxt8Av/fhNUljEfZ5gsWl8qVufEnSK8JLlQ4fxVaZyaJ62WLg8mijvGX36FKkLtigHEMPjX+QIPrm3GChxH5gU0n91cqoyMH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(46966006)(40470700004)(107886003)(2616005)(6862004)(54906003)(5660300002)(8936002)(6512007)(70206006)(70586007)(86362001)(316002)(6506007)(81166007)(4326008)(53546011)(8676002)(26005)(33656002)(40460700003)(82740400003)(36860700001)(82310400005)(83380400001)(41300700001)(2906002)(40480700001)(47076005)(36756003)(336012)(186003)(6486002)(478600001)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:29:20.2658 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d019dfa-2017-4296-ecf0-08da5e8a5e0d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7519 Hi Anthony, > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > There is no need to call the "headers.chk" target when it isn't > wanted, so it never need to be .PHONY. >=20 > Also, there is no more reason to separate the prerequisites from the > recipe. >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > tools/libs/libs.mk | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) >=20 > diff --git a/tools/libs/libs.mk b/tools/libs/libs.mk > index 7aee449370..f778a7df82 100644 > --- a/tools/libs/libs.mk > +++ b/tools/libs/libs.mk > @@ -55,22 +55,20 @@ $(PKG_CONFIG_LOCAL): PKG_CONFIG_INCDIR =3D $(XEN_INCL= UDE) > $(PKG_CONFIG_LOCAL): PKG_CONFIG_LIBDIR =3D $(CURDIR) >=20 > .PHONY: all > -all: headers.chk $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(L= IBHEADERS) > +all: $(TARGETS) $(PKG_CONFIG_LOCAL) libxen$(LIBNAME).map $(LIBHEADERS) >=20 > ifneq ($(NO_HEADERS_CHK),y) > -headers.chk: > +all: headers.chk > + > +headers.chk: $(LIBHEADERS) $(AUTOINCS) > for i in $(filter %.h,$^); do \ > $(CC) -x c -ansi -Wall -Werror $(CFLAGS_xeninclude) \ > -S -o /dev/null $$i || exit 1; \ > echo $$i; \ > done >$@.new > mv $@.new $@ > -else > -.PHONY: headers.chk > endif >=20 > -headers.chk: $(LIBHEADERS) $(AUTOINCS) > - > headers.lst: FORCE > @{ set -e; $(foreach h,$(LIBHEADERS),echo $(h);) } > $@.tmp > @$(call move-if-changed,$@.tmp,$@) > --=20 > Anthony PERARD >=20 >=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:35:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:35:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361290.590721 (Exim 4.92) (envelope-from ) id 1o8ii5-0004VA-Hi; Tue, 05 Jul 2022 13:35:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361290.590721; Tue, 05 Jul 2022 13:35:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ii5-0004V3-Ej; Tue, 05 Jul 2022 13:35:25 +0000 Received: by outflank-mailman (input) for mailman id 361290; Tue, 05 Jul 2022 13:35:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ii4-0004Ux-HA for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:35:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60061.outbound.protection.outlook.com [40.107.6.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52024b69-fc67-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:35:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3916.eurprd04.prod.outlook.com (2603:10a6:8:10::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 13:35:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 13:35:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52024b69-fc67-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kcb1quNf7/GmF/oeIXgBio3Qhrr6B9rrpNocPHqBQNpc1hq8DyaQVVfGulhMNDwXLr07vzrYbuI3lK3xszjWvC9iClWdioJiaASocqLM7NLw/sSXDdXf2z6FtvI02oXM9dRTVyBIzoh5LCS7Z15y5yeq9bk/hEJVF9RqaC4qgCpxuCGOIMt11EfcbH1eRx18aaH1hGczH19HEXiaXoskShVTWyHelH/zVZIpvrVTx4YhrviDYN1RV5pquMI/s78Jukez5zj1upQsthAr3T3IfmamXe3QbGpIWTs049Skt5Rfx0DNJQkCpZS2NnLxP4GGdCgobVNldpFQZ/vDcqZ5Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kpdN2iSuPLfZw0yb6nsx8h0cV09fOyx50ifL7ES5vMs=; b=esJW5BsFWWIIkw5VFNDSCTtfhECIHdIARUiVXn5epG9oaZSK3382nqSZ4FOFn4qX21jyKoJSmhAtKBoV5i1KcyrJ3byrEvAH26j1VQcFIb9Jn1jmLUb0c9Ul+OlIrL9jymY+zPrLKXQzfP0O6hFfyCyaiCANe5x1cclyDv5nVsA7qMOkB7eBhVjwmHLfa4uhdD+3d3/kKcWyk+bK8Jm1s34akVWUdv/Yys3JK9DW7bpSi9jOgH4WMwGCBfGTWlc9vvg0rtv/Z1Gn2JYqFG5UivRL5gOQQe3krdX6zFLgbtftetYXxO4C6Gn1gh6mtiCxpliQxYnMOLp9uel6acotoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kpdN2iSuPLfZw0yb6nsx8h0cV09fOyx50ifL7ES5vMs=; b=JFVznxj8UfopvZy58G+1qV71PIrQxrech5BlBYOlkBa4NR+mKMJsBeccK6VNRYdSkk7wlMqUuAnU/CDtykkushZOIlPXTu4DbciBkSuu4/E6z4XHzHfM0X3+Y8BZceNsFNDUMgngpYdX7K0SV1fH8E7cbSYZv0MrqiSzqH+YkNY/r+jrptfEXeuBNC79JPGFJz+HWJEqVaRvIsLHrl1Vsy4azfkoUZIo2/qeOu6IpokGVCIrJtq/5JyApLxjO5zT8R7VlbS5BDvCgBqxZYj7ckPtLljrZQIpgSuWnjWmHF9xQ5fOl1sc2tQrICNu2nH+wXwuQm61vDiIvUudY/Ttmw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2a4fcad5-2f18-8ead-0395-bf1008e0d5f8@suse.com> Date: Tue, 5 Jul 2022 15:35:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/6] x86/setup: init nr_irqs after having detected x2APIC support Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220630085439.83193-1-roger.pau@citrix.com> <20220630085439.83193-4-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220630085439.83193-4-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6277ed3b-3ba3-4836-3bc2-08da5e8b353b X-MS-TrafficTypeDiagnostic: DB3PR0402MB3916:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S332pf29PdusG0NJis55c+rMIYdthdyjwsyq+GqWWwsifueKxrakUPKFMFlAVe/vjRqD0vNSw3r5UBhc6k7UGrlm70gy5kA1qCws5vqwmGnWQaYpd+q8qNr6Hot5CuU7BM1QBw1yFo0aQ9AN1rnxj5CvxbT76XS5Eun7x0RIw885JnOadil7l1WftD5s0yPz277d3aZMBjlzb1zxeE0JCXNNeUwd2v++F5MtodpKHB/qMULQAZ2kblL4hknvJ3I2iA2RmUM8kHqpiT4FSnkGtJtY22JhKlRFRPblpITwOXZK+h+1gos+DdWssram34hwvUKPHI7rEq4nJ75FSvXqB1lEWNrkI3PlOJyl0yDD5AZGHCRy7GkVhEdhIHyd2hNJk4WkUkKknXN3m6hiZKzIl5a8RYz2EKsCSBad04dApM8tnpsHKJSHlql1wBOTSgfORi4ex6fS5lF3BZHYCo61Jl5E+Laeejj+jcYFchOv141s46LMORZOtXuAPHfkoboEFYqOk+Ppt7vvrXhtQdwZLkYXez337Ts6XLbigQvRviw8kmL/HbyQfI6kv2mqHjSXb7Zm56H16JzrBz8XM5m1BU5k7g71F2HyPo4G4bIgP4TOumYPsvGghnGxi9prFy2vhxVw6/vrvbE+ocetz21f8Pxsdl+jlIjf6F+c/8SAt2PYxT17hQM1EJyow0DVdRkKCbW81k6XEKs1+Kul/aBd8RY951SJdw1pVONubRmdDjVGyVZkBFsasF70Irvii5RtWgpO8vSY+mqirSA9IaJRs/cME/yBg1A4jwPDnNkT0HvJXbNy1GdKPDFwHhtzrqLtKpIevRIAcuy3FCZ21DzqqBLxF8YF01ILrzfBqgEffaoaFacw5w+KxRkaLdrYBgT8fPgmOUrLXd14jf4I6P/Psw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(136003)(39860400002)(396003)(366004)(66946007)(66476007)(8676002)(4326008)(66556008)(38100700002)(54906003)(5660300002)(31696002)(86362001)(2906002)(8936002)(41300700001)(83380400001)(26005)(53546011)(2616005)(6512007)(186003)(6506007)(316002)(6916009)(6486002)(478600001)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3BsdGp5UGZpMjB3NGFxZGlKNFArVHB3RTF0K1F4VW0xV2ZVZkkzYzE4cGVz?= =?utf-8?B?VFh0YWxaSGxKVDllQnV5NVBtVXVKanBKZFJPWUFsOC95czZQOHFlenZuNlVx?= =?utf-8?B?akdHem5iK2MxSDZJUTRlOEtJQnYvbXphWTB0ZG5LZzdsYm1tWVhQUzZQWDRP?= =?utf-8?B?N3BJaG5UMnNMZk03RUt5cjUweWQwREtiWlNHcGJSSml0QlArWEhZR0Nia1du?= =?utf-8?B?R0ExL0ZZN1VSWVVPTzI2eWMrR25ZNUMzMXBRUmJ0anY3SnZJUzR4Mi9LUHBS?= =?utf-8?B?VFVQYkZhTHdPdzlGMXl1Z3IzWHhRNmRVUjlZUGE4cTRTYTc4VkhWU0hpK3FY?= =?utf-8?B?UUErK1ZoaXNGbGdLdVE0TjM4R25tcjZzN3Q0dE92K01QTXpRb0U5MXkwMW5x?= =?utf-8?B?Q2V3Uk9BVmJpRkFmYmVHaXNDem5sWk5qS0pYdWpNUU1EZXNJdG5ydGUxUklj?= =?utf-8?B?aUFnU2pZWEdiWmJDYWFhQTdvd3pqTjVKWFhtczUrU0pqZzd0T0NETmhMVzRD?= =?utf-8?B?OGtpWmpHS0V5b0RobWorSlUrZEIyait1TUI2b2piSFRFaUo5RDZzMklWcmcr?= =?utf-8?B?N0JMZEcxUjF6ZHI3YzFrRFNKZHNSMmRFK1N4d1Zhdm83SzdFMFE2YkJwMmtN?= =?utf-8?B?dlFNL3hJWFhwRitkUmtrREw3ZzhPWDdWcHQ3QlZiRlo3a3NqM1E0RHFkbVBl?= =?utf-8?B?Q0l0anNaMTJWZ3JLeWpWZGlJS0ZUbXZ4d2hSWXgzbFdYcGc5TnB2MUhqdktD?= =?utf-8?B?bzR0VEVvRzRaS2xWa1QrTFBpL1E3UkhCb0d0WmI5ZC96UHBBSlFqS3JOSXlY?= =?utf-8?B?Z2FZbVk1cXRONU9GT3RDT25BUzJRcEZZa2xRV242M2tiZVRBWndocUhpQjBZ?= =?utf-8?B?NFExNzVlbGthK0ozYnptcE1tV2xQd1lETVR0ZzBqS3V6eFhVeUdtQzBRNDlY?= =?utf-8?B?eGxLdllWN1VJN2ZTS2ZkbWZQOGVNMDRvWFR1dUt3a25JQlhMRUFtMDBTcm5E?= =?utf-8?B?Q21ISzJTa1hNNG01Z2d4MWw0Z0V0NUZPRnlvNEJzL2h2V0pIYjNaQjl4cG4y?= =?utf-8?B?MlVJbUh6ekNsT3pSUERHd21ybXhxSHdjcmZOUHRkc1A1VXZraUJaVTBwZmhl?= =?utf-8?B?S3JZYUFCVWZUZ25lRWtJMVRqczJ3OFQySFh0WnJpTmE1dzA0SHRweVRvckc2?= =?utf-8?B?OVREcGI4bGxUbklxTFVBdTA2d3l3SjhzVnhnelhxQ2gyaWI3ME01cS9Pam1E?= =?utf-8?B?bm8zWG93V2tHdlAxV0Z4cUJFMEhYVUtETGtUbGF3aXNwOTd0bjNka1dMSGpV?= =?utf-8?B?SmRnSURaczhjbkQ2b1lYNWFlZHAyTEVXcThyYjdxUytaMWhHMmhxeHYrWlo1?= =?utf-8?B?QndDaWZNRituWldxVXV4SG1hNlFocGdYdEkzaDFQSXBSYkxlRkRGRFd3Uk91?= =?utf-8?B?M3BEQ0tnUmIvV0NHNDJNanR2WENwWitzbTBSK1NKMS96UHpOY0VOOG5Yc3By?= =?utf-8?B?c2JLMWNLVTJ5WVBLRE5pVWxGZXBnbDgxbVBhMm9mNGY4ekF1MTFDbVVCNUFp?= =?utf-8?B?QzRHbFc5UGRFMWhPVHhWWVg1SVdtcnF2LzNMWEpyVjRoV1pjWHJTU1hPRUlz?= =?utf-8?B?dGRQQ2ZJTS9hSXlrTUlZbHlyU083cTJiYUFReFNWOEhtTURNMGhUMWpMVFd2?= =?utf-8?B?NUh3cUxMeWM3N3pyWHFtdmRwRThhcDRKQTlLdWtOWDh6RUJJakFpRm9NSVJM?= =?utf-8?B?SnFlbnlYbm5zMXJtN1lHamhuN01VNFQ0SzRMbU80Nmk1SVZHL1lRSVo1RG1K?= =?utf-8?B?STU1WjVHb1RpdEdSRHB5RksxcWYvRjQ3Q1lWRWVXUEJkTDg1Sk1oanZ3bnVL?= =?utf-8?B?QkRBSmZUZmRwQWlKKzdORzVpNlNqZERPQVZhVXpRdkVoTXBvanphMnUyV3JG?= =?utf-8?B?ZVlWUExJZG1yazNlZ2R6cGxoSS8vOThiNkJKdVRtdzVLOWlMOGhZUXJmVXZ1?= =?utf-8?B?a0cvdkcxd1RNeEY0Um5mTDgzSWU5UWNSVE5GbkZrWDBldmtrWjl5M2tTQXU0?= =?utf-8?B?MjBLWk5PenlKaVBIVnRNcGtrVzZ5Ym12bHY1MFEzODNmdjJIWmo0UnVJenp2?= =?utf-8?Q?NjWyYTMbiF6SJreUaUjVw7mAG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6277ed3b-3ba3-4836-3bc2-08da5e8b353b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:35:21.3667 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: naleaymMQr32DGslXx7TR7P4Q0GLC5foSoFylesNuGiXCn7Ec42kug7vXovy2ugmCErdnfaXawolrGEnbMYfJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3916 On 30.06.2022 10:54, Roger Pau Monne wrote: > Logic in ioapic_init() that sets the number of available vectors for > external interrupts requires knowing the x2APIC Destination Mode. As > such move the call after x2APIC BSP setup. "requires" reads as if this was the case already, which I don't think is true. The dependency likely appears with the next patch (didn't look there, yet). > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -2653,16 +2653,6 @@ void __init ioapic_init(void) > max_gsi_irqs, nr_irqs_gsi); > nr_irqs_gsi = max_gsi_irqs; > } > - > - if ( nr_irqs == 0 ) > - nr_irqs = cpu_has_apic ? > - max(0U + num_present_cpus() * NR_DYNAMIC_VECTORS, > - 8 * nr_irqs_gsi) : > - nr_irqs_gsi; > - else if ( nr_irqs < 16 ) > - nr_irqs = 16; > - printk(XENLOG_INFO "IRQ limits: %u GSI, %u MSI/MSI-X\n", > - nr_irqs_gsi, nr_irqs - nr_irqs_gsi); > } > > unsigned int arch_hwdom_irqs(domid_t domid) > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -420,6 +420,16 @@ int __init init_irq_data(void) > struct irq_desc *desc; > int irq, vector; > > + if ( nr_irqs == 0 ) > + nr_irqs = cpu_has_apic ? max(0U + num_present_cpus() * > + NR_DYNAMIC_VECTORS, 8 * nr_irqs_gsi) > + : nr_irqs_gsi; Splitting a function argument across lines and then putting the next argument on the same line is, well, confusing. May I suggest to either stick to the original line splitting or to go to if ( nr_irqs == 0 ) nr_irqs = cpu_has_apic ? max(0U + num_present_cpus() * NR_DYNAMIC_VECTORS, 8 * nr_irqs_gsi) : nr_irqs_gsi; ? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:37:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:37:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361295.590732 (Exim 4.92) (envelope-from ) id 1o8ije-00055k-Us; Tue, 05 Jul 2022 13:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361295.590732; Tue, 05 Jul 2022 13:37:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ije-00055d-Pz; Tue, 05 Jul 2022 13:37:02 +0000 Received: by outflank-mailman (input) for mailman id 361295; Tue, 05 Jul 2022 13:37:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ijZ-000559-4V for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:37:02 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 88ee498a-fc67-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 15:36:55 +0200 (CEST) Received: from zn.tnic (p200300ea970ff682329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f682:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6F3531EC04E4; Tue, 5 Jul 2022 15:36:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 88ee498a-fc67-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657028210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=GFZB6hQrFUj7F40WxfxetMyblgqJcf/FkHxEIUACZKI=; b=UXJSGTGPhKfbk/vTKth2c8W3kodpAwNsuy1N1adOQUCmwhQ+doBPisYXvL2+tJHpAO4SRy PZ2fcdm+R9pMMiuJzsvZXRgGd5Xc1qywRkYAfD59K8FhCTpvmodBn1cHTbaLuikehq0QiE x5aSzTULghRklPcujE5oJPxb81LwGBc= Date: Tue, 5 Jul 2022 15:36:46 +0200 From: Borislav Petkov To: Thorsten Leemhuis Cc: Jan Beulich , lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers , Juergen Gross Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Message-ID: References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> On Tue, Jul 05, 2022 at 12:57:18PM +0200, Thorsten Leemhuis wrote: > Side note: Juergen Gross recently posted related patches in this code > area to fix some other problems (regressions?), but his efforts look > stalled, too: > https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ I'm still waiting for a resumbission of this: https://lore.kernel.org/r/20220620113441.23961-1-jgross@suse.com -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361299.590743 (Exim 4.92) (envelope-from ) id 1o8ikl-0005bb-9h; Tue, 05 Jul 2022 13:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361299.590743; Tue, 05 Jul 2022 13:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ikl-0005bU-6H; Tue, 05 Jul 2022 13:38:11 +0000 Received: by outflank-mailman (input) for mailman id 361299; Tue, 05 Jul 2022 13:38:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ikj-0005VU-DS for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:38:09 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4ab7791-fc67-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:38:08 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5164321871; Tue, 5 Jul 2022 13:38:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 04F4013A79; Tue, 5 Jul 2022 13:38:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 3x1VO78+xGKiaAAAMHmgww (envelope-from ); Tue, 05 Jul 2022 13:38:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4ab7791-fc67-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657028288; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cBgfR3qOBG6NftUJTxAfLlOApMHXwbeEKMkgaw4ZLZA=; b=Rpac6sqM+ziOh5BuYL1ZXlFX8iHYOloHQ/2evL5U8tpTq6O5pbtUTrd4ZADTsWl4i0PHfS PvmR+fq1oqPCwwxBt1bAaQxziLecvxyqvxIiFSmlnzBrDQSxsYuZhmYcxSNqa1vPT1QfZR vzUlBra7BvqqIXoqij7OrM2qjcRBPcQ= Message-ID: Date: Tue, 5 Jul 2022 15:38:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov , Thorsten Leemhuis Cc: Jan Beulich , lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------mvmWJaq0Eb1P7nHo4bjJR33I" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------mvmWJaq0Eb1P7nHo4bjJR33I Content-Type: multipart/mixed; boundary="------------d1Bpr1iBO2LJODO9SE0RHXrr"; protected-headers="v1" From: Juergen Gross To: Borislav Petkov , Thorsten Leemhuis Cc: Jan Beulich , lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , the arch/x86 maintainers Message-ID: Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> In-Reply-To: --------------d1Bpr1iBO2LJODO9SE0RHXrr Content-Type: multipart/mixed; boundary="------------SDvCKX4PrJ2g5zrQNyWBTgzY" --------------SDvCKX4PrJ2g5zrQNyWBTgzY Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDUuMDcuMjIgMTU6MzYsIEJvcmlzbGF2IFBldGtvdiB3cm90ZToNCj4gT24gVHVlLCBK dWwgMDUsIDIwMjIgYXQgMTI6NTc6MThQTSArMDIwMCwgVGhvcnN0ZW4gTGVlbWh1aXMgd3Jv dGU6DQo+PiBTaWRlIG5vdGU6IEp1ZXJnZW4gR3Jvc3MgcmVjZW50bHkgcG9zdGVkIHJlbGF0 ZWQgcGF0Y2hlcyBpbiB0aGlzIGNvZGUNCj4+IGFyZWEgdG8gZml4IHNvbWUgb3RoZXIgcHJv YmxlbXMgKHJlZ3Jlc3Npb25zPyksIGJ1dCBoaXMgZWZmb3J0cyBsb29rDQo+PiBzdGFsbGVk LCB0b286DQo+PiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvZGRiMGNjMGQtY2VmYy00 ZjMzLTIzZjgtM2E5NGM3YzUxYTQ5QHN1c2UuY29tLw0KPiANCj4gSSdtIHN0aWxsIHdhaXRp bmcgZm9yIGEgcmVzdW1iaXNzaW9uIG9mIHRoaXM6DQo+IA0KPiBodHRwczovL2xvcmUua2Vy bmVsLm9yZy9yLzIwMjIwNjIwMTEzNDQxLjIzOTYxLTEtamdyb3NzQHN1c2UuY29tDQo+IA0K DQpIb3cgYXJlIHRob3NlIGRpcmVjdGx5IGNvbm5lY3RlZD8gSU1PIHRoZXkgYXJlIGluZGVw ZW5kZW50IGZyb20gZWFjaCBvdGhlci4NCg0KDQpKdWVyZ2VuDQo= --------------SDvCKX4PrJ2g5zrQNyWBTgzY Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------SDvCKX4PrJ2g5zrQNyWBTgzY-- --------------d1Bpr1iBO2LJODO9SE0RHXrr-- --------------mvmWJaq0Eb1P7nHo4bjJR33I Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLEPr8FAwAAAAAACgkQsN6d1ii/Ey+D vQf/Rt3ZGsCIYmKO8rOoGIX8Q0G1u2URt5xSeMW+OayhcGH7ORbMeOPyPCLXcuYcoLooZS449ecV geCixSFxS2nKKS1dpV3LUBuiSj15P1lQDJe09rD4iEKXIAgr5aiKlLd3axCpk2Q3AWkYipBCi8xM 2uNwQhhHDWuXMrGLbw0348Ib35bcYkrVxOL6bwbddgeM8gHMHo0PJw9YhxQetlQ/OEkMmXrGf6Sm A6hP054r1PNkhkk3tjJGMqYoX2jreTpA3fcEab8Tzdu/kmK0Z2GLjfTnjriSUmsq1oZh+QIcHdb2 udggK5W+jEKK4LrQljqcdMfhYn64/FjHY8WjuThAxw== =5Brw -----END PGP SIGNATURE----- --------------mvmWJaq0Eb1P7nHo4bjJR33I-- From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:47:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:47:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361309.590754 (Exim 4.92) (envelope-from ) id 1o8iu7-0007LY-Ah; Tue, 05 Jul 2022 13:47:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361309.590754; Tue, 05 Jul 2022 13:47:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iu7-0007LR-6g; Tue, 05 Jul 2022 13:47:51 +0000 Received: by outflank-mailman (input) for mailman id 361309; Tue, 05 Jul 2022 13:47:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iu5-0007LH-Dj; Tue, 05 Jul 2022 13:47:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iu5-0005Um-AP; Tue, 05 Jul 2022 13:47:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iu4-0004VV-SC; Tue, 05 Jul 2022 13:47:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8iu4-0005Z1-Rk; Tue, 05 Jul 2022 13:47:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Pyz/3u4Y1ovjvhPCPCBHe59dE0EHLRJRKtGDjXl7UT4=; b=lP8OIo6Zr3LZXdKqJb7TQyMoLp CAJF94zvx1d4U/cSBmqjGDWytUTElxPzq/p8GCLLdmKROr1/mN6/wdtanSZ6PErSlDLgMQDMvcxmc IViMMzwN3pFTcgn0NJ8MBLwuE84g9YnyyMMRot+SogJGauiPM6amMNn4RaAd9SBES0sc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171498: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c1084b6c5620a743f86947caca66d90f24060f56 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Tue, 05 Jul 2022 13:47:48 +0000 flight 171498 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171498/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux c1084b6c5620a743f86947caca66d90f24060f56 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 16 days Failing since 171280 2022-06-19 15:12:25 Z 15 days 43 attempts Testing same since 171495 2022-07-04 21:41:37 Z 0 days 2 attempts ------------------------------------------------------------ 485 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 19517 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:56:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361319.590765 (Exim 4.92) (envelope-from ) id 1o8j2o-0000Y5-75; Tue, 05 Jul 2022 13:56:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361319.590765; Tue, 05 Jul 2022 13:56:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j2o-0000Xy-4O; Tue, 05 Jul 2022 13:56:50 +0000 Received: by outflank-mailman (input) for mailman id 361319; Tue, 05 Jul 2022 13:56:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j2m-0000Xs-96 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:56:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j2l-0005eX-BT; Tue, 05 Jul 2022 13:56:47 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.237.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8j2l-0003tj-5X; Tue, 05 Jul 2022 13:56:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=D+dkj/jgym+ceY3z8amVg2pnE1tPUUK1qu/AlVLQbR4=; b=b9FFyiwaq3J4Ou15c5eu6720hW 4sWz3d5fldOTGS23ubDBJ0IFNl4eZoZLCTQzOy5xc8GYKLH5KCLfINbu2ygPX8AdaKle38iv2YcNM dBb6od/MsvW0px6X9vPvEKoL5rR+DuvbJ8z22AFKCiMJQC7Dx5SvFje2lVPhQJqtYLys=; Message-ID: <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> Date: Tue, 5 Jul 2022 14:56:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. To: Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 14:28, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 28 Jun 2022, at 4:18 pm, Julien Grall wrote: >>> a new driver in linux kernel, etc where right now we just need to introduce an extra IOCTL in linux to support this feature. >> >> I don't understand why would need a new driver, etc. Given that you are introducing a new IOCTL you could pass a flag to say "This is a static event channel so don't close it". > > I tried to implement other solutions to this issue. We can introduce a new event channel state “ECS_STATIC” and set the > event channel state to ECS_STATIC when Xen allocate and create the static event channels. From what you wrote, ECS_STATIC is just an interdomain behind but where you want Xen to prevent closing the port. From Xen PoV, it is still not clear why this is a problem to let Linux closing such port. From the guest PoV, there are other way to pass this information (see below). > > From guest OS we can check if the event channel is static (via EVTCHNOP_status() hypercall ), if the event channel is > static don’t try to close the event channel. If guest OS try to close the static event channel Xen will return error as static event channel can’t be closed. Why do you need this? You already need a binding indicating which ports will be pre-allocated. So you could update your binding to pass a flag telling Linux "don't close it". I have already proposed that before and I haven't seen any explanation why this is not a viable solution. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:56:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:56:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361320.590775 (Exim 4.92) (envelope-from ) id 1o8j2t-0000oj-EQ; Tue, 05 Jul 2022 13:56:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361320.590775; Tue, 05 Jul 2022 13:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j2t-0000oX-BM; Tue, 05 Jul 2022 13:56:55 +0000 Received: by outflank-mailman (input) for mailman id 361320; Tue, 05 Jul 2022 13:56:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j2s-0000o1-Ea for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:56:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2075.outbound.protection.outlook.com [40.107.22.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5273f784-fc6a-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 15:56:52 +0200 (CEST) Received: from AM5PR0301CA0032.eurprd03.prod.outlook.com (2603:10a6:206:14::45) by AM0PR08MB3667.eurprd08.prod.outlook.com (2603:10a6:208:d5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Tue, 5 Jul 2022 13:56:50 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::75) by AM5PR0301CA0032.outlook.office365.com (2603:10a6:206:14::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Tue, 5 Jul 2022 13:56:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Tue, 5 Jul 2022 13:56:49 +0000 Received: ("Tessian outbound 3c5325c30453:v121"); Tue, 05 Jul 2022 13:56:49 +0000 Received: from 65dd51f1652e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 60905307-56B7-43E1-9B86-1CF7DFA0D19F.1; Tue, 05 Jul 2022 13:56:41 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 65dd51f1652e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 05 Jul 2022 13:56:41 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by PR2PR08MB4634.eurprd08.prod.outlook.com (2603:10a6:101:1f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Tue, 5 Jul 2022 13:56:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 13:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5273f784-fc6a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bmiyuYlBPOhSoifMc8WoC9uzY7Orz4/K61/mVnVyZXtlSBqI25SKnHsvs4qmq8n57hygWZaJy1vXn/ZkjQ3whaAyOcRKVnXZMFhfynnh3F8g3t2Z8Fh1yIUfsHmbj8rizU/aJ3aZIpVezl7WgEkLtsbNCXW5FNdRCIIl/HnNPRcn80WRYCFXZ8O0W+cGFLvy/ewDbfmfNOU+58QKqKRMjWLOTaeZ+HbN7+eI5eOxxeCtbvj+9JzQxL1Vt4ADEHgXbNWyZTGsOlw7c0qVfdTxRHIKQxdc5wcWbnebPDHM4Emp7FwT/PxdPOP1CcJF//x1RSL9ifIk2NkqqMXuYvXPEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sF58efq28Kqz77hh5t3+w9/PYs/O0V/yxFSFpda/52s=; b=myCeGcA94n7aji3A5v6tv7WSkxbaeFkliVXtgL8Se+/o4h8iXlvoy4ylzYW4b/7/WL4Le9p2SKfeLNyNKdjyGOpuVsqcFPpp85/0ftVArbpFHh/4ZG/QhM743f5gOFMDWj0X6rWBYK9cz+zsxo1wdB6xW7NLh/qGUC7GmgrrvozPVpxAYwzJuuEruy1Mkxr1D5fviDrLTUGAelIRZpFBOV0nxHSNCz0EmKtmEMUFSy/JDqztxodSqbIouhc5dc3TXOU4Olwun6Rh4wK6g3WD0P6PyClKeYJxLR5g+DB51vak3NzdHStUwqPRkhwXdChgaK9aVww59PB/QhuZpC4imQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sF58efq28Kqz77hh5t3+w9/PYs/O0V/yxFSFpda/52s=; b=4kbBpfxvMes24RJgKvSdc4TCbAew5giWsiPPCLqK7OXvZWFs+r/n6IU/DlDLsW4m0B4ajTDQ+6bgSBu8CMYppgMCQik+UAtme0t0FAoXSR437+cbn29rrHqi1gv+ZxaEarEgtRvr458TiK8rsrsN4Ss5U/jKIh+rlzdl2kDvsn8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 10393512b0d23c7f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E9tl0Qw28IJhf36kccuJ2tOkUla02JXjKqHDr4GsGRKpRBYQhWptynH5dZpuW90/03sGdXJs1WYIRYe/x+DPgGZGvfpUhkjA2MbWd8Cgrx78lN/cbJKaQpGrLHijfusl3u4jvQtdsr7VW/UbRrG43NUIRJETyNG4W34UljUlmPoB/+bokMSM2/tpceapoqJ8hAQ6Pir927+3h9Kqr+qNI7V4vMFcI7MsBvL+5wZyi4yOVTwuAoPHS8Vf850+Hm+3fM5cDVSueeldoGQv39HjGcFhgaGpy96QNUYBji8k9zdEC9eThbNh/JUDmMQEvo8R2aRgPChMR7hJ9q2afz/T4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sF58efq28Kqz77hh5t3+w9/PYs/O0V/yxFSFpda/52s=; b=XECkKj9Eltw7hdj/P06qqB0VRixw67biVAcg3UPNLciNiQ4TmEzFWZhaW3SN0Kw9n2ofS2TvsEMAnLg8yW2HnH6Qu70HYVsnVEy1ccjctaLoa7bTwEfdqldnfjkfPTPVXKlkso6GojOyZyDBbPG56yaw/+T1tqn1OKOinSBm9ECQQikFH/5N8zejDXlJzSMa++60LS3OxjnXpLzk88/owODIXq2kt5UYgzt+11GGgFrWP/CzthiI+miGQ+yMYac6Wf3RGKs9PT7fgqbNRI4BIyZRUFTsSAZ5yOqn5GxLXHFJIhNdqZl1CtZe2FGtoa6AabwJaC58nPT9H51jpiDgvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sF58efq28Kqz77hh5t3+w9/PYs/O0V/yxFSFpda/52s=; b=4kbBpfxvMes24RJgKvSdc4TCbAew5giWsiPPCLqK7OXvZWFs+r/n6IU/DlDLsW4m0B4ajTDQ+6bgSBu8CMYppgMCQik+UAtme0t0FAoXSR437+cbn29rrHqi1gv+ZxaEarEgtRvr458TiK8rsrsN4Ss5U/jKIh+rlzdl2kDvsn8= From: Luca Fancellu To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Issue with check-endbr.sh during Xen build Thread-Topic: Issue with check-endbr.sh during Xen build Thread-Index: AQHYkHcMKffnFiUSAU+E175V5Z5atg== Date: Tue, 5 Jul 2022 13:56:39 +0000 Message-ID: <815D8CFC-86A4-4C63-AA51-83C4C29E7AAD@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88f501a7-00ac-41e2-1554-08da5e8e3523 x-ms-traffictypediagnostic: PR2PR08MB4634:EE_|AM5EUR03FT055:EE_|AM0PR08MB3667:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: S82BgshFoB6Z7bHTC3VGZCcBtJH9armtob4QfYDQAex/F1W/0qOqf1EfVrlQG/kI9/PUItpHmm4d1MmLomVBZ3I//vvPar4hzUM6OK10d1aOegfdwNyorqvB2f1b2cbVONDf6vc5K6YYsEHl0P819xrYhIAOYt4GrHz/umO+l7ccnNVKAAs/TZSTZTIrkYbhF1cGGDth9JKQpr9JB+jmiqXkSbwpTYraKPDcL3+if2Bw+v7PVhu0E7l7y4yefy3LOqZHFwhbt6zzzGn9oxStyudvI4i/zs5ISorFObdlg/TR6a7k7Oe9clgMtiU7mP7POV8R5QeeTgMvSSewTZyqHkonxxxjZaqN/yE4PgdeJcqY7Ln5zD+39MGaDTphqd2U8TtOpyXOcMzdUFO8BuvoegJeXwQsmTPqEBAXvpsx8FXu9/Yd/w4TpMrQDyc/8yrKGZKgEpaXZI9H3uy+S7M5EeuehK5jydAod5WZoHVlf6Ug4RmPXs+S+VMfK9gI5EQCjpB9560PnJNBkDXEfT7X/uTzvZtwtMn7RQkgZSCgK8cPDxoCgsUCqqXjmuVa5dqBB67iGIOCz17lzC4+N2XMrM7hKTYn8B6/NhE9eszmR9LcHBuQFKiIzFSMlHVvquiBxJ9fEgf6O2VAyOegszZ35gu8m4NTuV5U1LopOLcqIetlllRTCW4qRRwkQqMeW2XlDMjPCLdTm25zV6FywBNd7mKabAJUmXMq0n4Vowo1tUIw6v5wXIPaZqDZk4CjX41gEcD2LAOnvphhbnT/sETiAW4986zOqkrU+LRrVr82+e2obj1ZaZkRz+SGknG8poMbo4AQIA6WDkANhe0qwSEb0DQUX9lHAeDeSajUfxwDVlc= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(39860400002)(346002)(136003)(6506007)(8936002)(478600001)(5660300002)(2906002)(76116006)(91956017)(41300700001)(38070700005)(33656002)(122000001)(66446008)(64756008)(8676002)(4326008)(66476007)(66556008)(38100700002)(66946007)(36756003)(71200400001)(186003)(6486002)(6916009)(26005)(54906003)(6512007)(86362001)(2616005)(19627235002)(83380400001)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4634 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 365bc054-d440-465f-720a-08da5e8e2f45 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IKDzYTW7SrDGkjnl/tdtr/kFD5pTm4acZeAEzisZ/ICqx8uS/Ldo+wJVrPPUvRN4x7zXesxyZ5yPpoO7RnkT4Xes1lMpcIy3GyAKIWRe8mbxM/jdMfmZu48EygIhCRwSPpYpRwQ3BEDia8jb5xhTqCh874THMfXiZ8l2BlJnWbQp+Wbta8FOU2nEy/nD7YRU9KQTxBAc/lrzIp1BI/5ZFAfXWzVaQAE8MH4+oknCJlGGXad6Xvh3lEtXkpa+wxHPKNycz92ZJyykhr9i/z1Co9xVpg/rb3U26vFziaLeW0/ZYm09n0dYCjac19f2qV9GGmDF5ANVgsJSGbXNJfk5lkt5kj/C6ahUfnUcq/6VmaB9DWpDr9J4mr8FnSv+EqjZ88lqE6bg69zvp+5eH/ceG7YQ6BoYt0kkfQtXEIJIupq1MJFerurLnLtpiZBWxi2zpAD17qfneeeKWhk2OxTI8jj1E3D0gdTQInSYfdOCjsUqEIyaYg2pDzMkC1L1Gsp6I9zHhPfwOvfkosmd1OLRMDgd5kRXNWaDDHRA7DDBH8hST7TQeZotrotd8oyWXy/2OFfSMBtdPSslUOn7OkqzVqWonz+dFZw85wMcD+mVkDz/n/AwrxzZlDB3dc/vXlHnPf6RHUGORLM23KSMB3YT4Zu9JNxCcygK+tUu8lEb6dMWSN3+OadWNkTC+Z72Rpmv9F+urE+sJt/9qh7YKHmR5QkESQCe26t4cuaGYN7e74rX/S/aNTzvHo5lHqBFyK3Nt+DUCQ2z/jIl5u5ycAsW10EadGjhb70FaVpz0J1/dFzeORoaCIOq0dXyO3DzWSip X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(346002)(136003)(40470700004)(36840700001)(46966006)(4326008)(41300700001)(8676002)(6506007)(70206006)(70586007)(6486002)(316002)(54906003)(6916009)(40460700003)(478600001)(19627235002)(82310400005)(40480700001)(8936002)(2906002)(5660300002)(36860700001)(86362001)(36756003)(81166007)(33656002)(82740400003)(356005)(186003)(47076005)(2616005)(336012)(83380400001)(26005)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 13:56:49.5267 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88f501a7-00ac-41e2-1554-08da5e8e3523 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3667 SGkgYWxsLA0KDQpJ4oCZdmUgZW5jb3VudGVyZWQgYW4gaXNzdWUgYnVpbGRpbmcgWGVuIGZvciB4 ODZfNjQsIGJhc2ljYWxseSB0aGUgc2NyaXB0IGNoZWNrLWVuZGJyLnNoIHdhcyByZXR1cm5pbmcg YW4gZXJyb3I6DQrigJxFcnJvcjogTW9yZSB2YWxpZC1hZGRycyB0aGFuIGFsbC1hZGRyc+KAnS4N Cg0KSSBoYXZlIGZvdW5kIGEgc29sdXRpb24gYnV0IEnigJltIHdyaXRpbmcgYW55d2F5IHRvIHlv dSB0byBtYWtlIHlvdSBhd2FyZSBvZiB0aGUgaXNzdWUuDQoNCkluIG15IHNldHVwIEnigJltIHVz aW5nIGEgZG9ja2VyIGNvbnRhaW5lciB3aXRoIGJhc2UgaW1hZ2UgZnJvbSB1YnVudHU6MjIuMDQs IHdoZW4gSSBidWlsZCBmcm9tIHRoZSBjb250YWluZXIgaXQNCklzIGZhaWxpbmcsIGluc3RlYWQg d2hlbiBJ4oCZbSBidWlsZGluZyBmcm9tIG15IG1hY2hpbmUgaXQgaXMgd29ya2luZyBmaW5lLg0K DQpTbyBJ4oCZdmUgc2V0IC14IGluIHRoZSBzY3JpcHQgdG8gdHJhY2UgaXQgYW5kIEkgaGF2ZSB0 aGlzIGZvciBteSBob3N0IG1hY2hpbmUgKHhlbl94ODYtZG9ja2VyIGlzIGp1c3QgeGVuLXN5bXMp Og0KDQokIC4veGVuL3hlbi90b29scy9jaGVjay1lbmRici5zaCB0bXBfZmlsZXMveGVuX3g4Ni1k b2NrZXINCisgTVNHX1BGWD1jaGVjay1lbmRici5zaCB4ZW5feDg2LWRvY2tlcg0KKyBPQkpDT1BZ PW9iamNvcHkNCisgT0JKRFVNUD1vYmpkdW1wDQorIEFERFIyTElORT1hZGRyMmxpbmUNCisgbWt0 ZW1wIC1kDQorIEQ9L3RtcC90bXAuM1RtVnAyaWRDbQ0KKyB0cmFwIHJtIC1yZiAvdG1wL3RtcC4z VG1WcDJpZENtIEVYSVQNCisgVEVYVF9CSU49L3RtcC90bXAuM1RtVnAyaWRDbS94ZW4tc3ltcy50 ZXh0DQorIFZBTElEPS90bXAvdG1wLjNUbVZwMmlkQ20vdmFsaWQtYWRkcnMNCisgQUxMPS90bXAv dG1wLjNUbVZwMmlkQ20vYWxsLWFkZHJzDQorIEJBRD0vdG1wL3RtcC4zVG1WcDJpZENtL2JhZC1h ZGRycw0KKyBlY2hvIFgNCisgZ3JlcCAtYW9iIFggLXENCisgcGVybF9yZT10cnVlDQorIGVjaG8g WA0KKyBncmVwIC1hb2JQIFx4NTggLXENCisgb2JqZHVtcCAtaiAudGV4dCB0bXBfZmlsZXMveGVu X3g4Ni1kb2NrZXIgLWQgLXcNCisgZ3JlcCAJZW5kYnI2NCAqJA0KKyBjdXQgLWYgMSAtZCA6DQor IG9iamR1bXAgLWogLnRleHQgdG1wX2ZpbGVzL3hlbl94ODYtZG9ja2VyIC1oDQorIGF3ayAkMiA9 PSAiLnRleHQiIHtwcmludGYgInZtYV9oaT0lc1xudm1hX2xvPSVzXG4iLCBzdWJzdHIoJDQsIDEs IDgpLCBzdWJzdHIoJDQsIDksIDE2KX0NCisgZXZhbCB2bWFfaGk9ZmZmZjgyZDAgdm1hX2xvPTQw MjAwMDAwDQorIHZtYV9oaT1mZmZmODJkMCB2bWFfbG89NDAyMDAwMDANCisgb2JqY29weSAtaiAu dGV4dCB0bXBfZmlsZXMveGVuX3g4Ni1kb2NrZXIgLU8gYmluYXJ5IC90bXAvdG1wLjNUbVZwMmlk Q20veGVuLXN5bXMudGV4dA0KKyB0cnVlDQorIExDX0FMTD1DIGdyZXAgLWFvYlAgXHhmM1x4MGZc eDFlKFx4ZmF8XHhmYil8XHg2Nlx4MGZceDFmXHgwMSAvdG1wL3RtcC4zVG1WcDJpZENtL3hlbi1z eW1zLnRleHQNCisgYXdrIC1GOiB7cHJpbnRmICIlcyV4XG4iLCAiZmZmZjgyZDAiLCBpbnQoMHg0 MDIwMDAwMCkgKyAkMX0NCisgd2FpdA0KKyBzdGF0IC1jICVzIC90bXAvdG1wLjNUbVZwMmlkQ20v dmFsaWQtYWRkcnMNCisgdmFsX3N6PTI0MDA0DQorIHN0YXQgLWMgJXMgL3RtcC90bXAuM1RtVnAy aWRDbS9hbGwtYWRkcnMNCisgYWxsX3N6PTI0MDA0DQorIFsgMjQwMDQgLWVxIDAgXQ0KKyBbIDI0 MDA0IC1lcSAwIF0NCisgWyAyNDAwNCAtbHQgMjQwMDQgXQ0KKyBzb3J0IC90bXAvdG1wLjNUbVZw MmlkQ20vdmFsaWQtYWRkcnMgL3RtcC90bXAuM1RtVnAyaWRDbS9hbGwtYWRkcnMNCisgdW5pcSAt dQ0KKyB3YyAtbA0KKyBucl9iYWQ9MA0KKyBbIDAgLWVxIDAgXQ0KKyBleGl0IDANCisgcm0gLXJm IC90bXAvdG1wLjNUbVZwMmlkQ20NCg0KQW5kIEkgaGF2ZSB0aGlzIGZyb20gbXkgZG9ja2VyIGNv bnRhaW5lcjoNCg0KIyAuL3hlbi94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2ggdG1wX2ZpbGVzL3hl bl94ODYtZG9ja2VyDQorIE1TR19QRlg9J2NoZWNrLWVuZGJyLnNoIHhlbl94ODYtZG9ja2VyJw0K KyBPQkpDT1BZPW9iamNvcHkNCisgT0JKRFVNUD1vYmpkdW1wDQorIEFERFIyTElORT1hZGRyMmxp bmUNCisrIG1rdGVtcCAtZA0KKyBEPS90bXAvdG1wLnRSMFZ0OGwyaWUNCisgdHJhcCAncm0gLXJm IC90bXAvdG1wLnRSMFZ0OGwyaWUnIEVYSVQNCisgVEVYVF9CSU49L3RtcC90bXAudFIwVnQ4bDJp ZS94ZW4tc3ltcy50ZXh0DQorIFZBTElEPS90bXAvdG1wLnRSMFZ0OGwyaWUvdmFsaWQtYWRkcnMN CisgQUxMPS90bXAvdG1wLnRSMFZ0OGwyaWUvYWxsLWFkZHJzDQorIEJBRD0vdG1wL3RtcC50UjBW dDhsMmllL2JhZC1hZGRycw0KKyBlY2hvIFgNCisgZ3JlcCAtYW9iIFggLXENCisgcGVybF9yZT10 cnVlDQorIGVjaG8gWA0KKyBncmVwIC1hb2JQICdceDU4JyAtcQ0KKyBvYmpkdW1wIC1qIC50ZXh0 IHRtcF9maWxlcy94ZW5feDg2LWRvY2tlciAtZCAtdw0KKyBncmVwICcJZW5kYnI2NCAqJCcNCisg Y3V0IC1mIDEgLWQgOg0KKysgb2JqZHVtcCAtaiAudGV4dCB0bXBfZmlsZXMveGVuX3g4Ni1kb2Nr ZXIgLWgNCisrIGF3ayAnJDIgPT0gIi50ZXh0IiB7cHJpbnRmICJ2bWFfaGk9JXNcbnZtYV9sbz0l c1xuIiwgc3Vic3RyKCQ0LCAxLCA4KSwgc3Vic3RyKCQ0LCA5LCAxNil9Jw0KKyBldmFsIHZtYV9o aT1mZmZmODJkMCB2bWFfbG89NDAyMDAwMDANCisrIHZtYV9oaT1mZmZmODJkMA0KKysgdm1hX2xv PTQwMjAwMDAwDQorIG9iamNvcHkgLWogLnRleHQgdG1wX2ZpbGVzL3hlbl94ODYtZG9ja2VyIC1P IGJpbmFyeSAvdG1wL3RtcC50UjBWdDhsMmllL3hlbi1zeW1zLnRleHQNCisgdHJ1ZQ0KKyBMQ19B TEw9Qw0KKyBncmVwIC1hb2JQICdceGYzXHgwZlx4MWUoXHhmYXxceGZiKXxceDY2XHgwZlx4MWZc eDAxJyAvdG1wL3RtcC50UjBWdDhsMmllL3hlbi1zeW1zLnRleHQNCisgYXdrIC1GOiAne3ByaW50 ZiAiJXMleFxuIiwgImZmZmY4MmQwIiwgaW50KDB4NDAyMDAwMDApICsgJDF9Jw0KKyB3YWl0DQor KyBzdGF0IC1jICVzIC90bXAvdG1wLnRSMFZ0OGwyaWUvdmFsaWQtYWRkcnMNCisgdmFsX3N6PTI0 MDA0DQorKyBzdGF0IC1jICVzIC90bXAvdG1wLnRSMFZ0OGwyaWUvYWxsLWFkZHJzDQorIGFsbF9z ej0xOTY4Ng0KKyAnWycgMjQwMDQgLWVxIDAgJ10nDQorICdbJyAxOTY4NiAtZXEgMCAnXScNCisg J1snIDE5Njg2IC1sdCAyNDAwNCAnXScNCisgZWNobyAnY2hlY2stZW5kYnIuc2ggeGVuX3g4Ni1k b2NrZXIgRXJyb3I6IE1vcmUgdmFsaWQtYWRkcnMgdGhhbiBhbGwtYWRkcnMnDQpjaGVjay1lbmRi ci5zaCB4ZW5feDg2LWRvY2tlciBFcnJvcjogTW9yZSB2YWxpZC1hZGRycyB0aGFuIGFsbC1hZGRy cw0KKyBleGl0IDENCisgcm0gLXJmIC90bXAvdG1wLnRSMFZ0OGwyaWUNCg0KDQpBZnRlciBzcGVu ZGluZyBhIGJpdCBvZiB0aW1lIHRvIHVuZGVyc3RhbmQgd2hhdCB0aGUgc2NyaXB0IGRvZXMsIEni gJl2ZSBjaGVja2VkIHRoZSBhd2sgdmVyc2lvbg0KYW5kIHNlZW1zIHRoYXQgdGhlIHNjcmlwdCBp cyBmYWlsaW5nIGluIHRoZSBEb2NrZXIgY29udGFpbmVyIGJlY2F1c2UgdGhlcmUgaXMgbWF3ayB0 aGVyZToNCiMgYXdrIC1XIHZlcnNpb24NCm1hd2sgMS4zLjQgMjAyMDAxMjANCkNvcHlyaWdodCAy MDA4LTIwMTksMjAyMCwgVGhvbWFzIEUuIERpY2tleQ0KQ29weXJpZ2h0IDE5OTEtMTk5NiwyMDE0 LCBNaWNoYWVsIEQuIEJyZW5uYW4NCg0KcmFuZG9tLWZ1bmNzOiAgICAgICBzcmFuZG9tL3JhbmRv bQ0KcmVnZXgtZnVuY3M6ICAgICAgICBpbnRlcm5hbA0KY29tcGlsZWQgbGltaXRzOg0Kc3ByaW50 ZiBidWZmZXIgICAgICA4MTkyDQptYXhpbXVtLWludGVnZXIgICAgIDIxNDc0ODM2NDcNCg0KSW5z dGVhZCBpbiBteSBob3N0IG1hY2hpbmUgdGhlcmUgaXMgZ2F3azoNCiQgYXdrIC1XIHZlcnNpb24N CkdOVSBBd2sgNC4xLjQsIEFQSTogMS4xIChHTlUgTVBGUiA0LjAuMSwgR05VIE1QIDYuMS4yKQ0K W+KApl0NCg0KDQpTbyB0aGVyZSBzZWVtcyB0byBiZSBhIGRlcGVuZGVuY3kgb24gdGhlIGludGVy cHJldGVyIChvciBhdCBsZWFzdCBpdCBkb2VzbuKAmXQgd29yayB3aXRoIHRoYXQgdmVyc2lvbiBv ZiBtYXdrKS4NCg0KTXkgc29sdXRpb24gd2FzIHRvIGluc3RhbGwgZ2F3ayBpbiB0aGUgY29udGFp bmVyIGFuZCBldmVyeXRoaW5nIHdhcyB3b3JraW5nIGZpbmUgYWZ0ZXJ3YXJkcy4NCg0KQ2hlZXJz LA0KTHVjYQ0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 05 13:59:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 13:59:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361317.590787 (Exim 4.92) (envelope-from ) id 1o8j5S-0001ok-0p; Tue, 05 Jul 2022 13:59:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361317.590787; Tue, 05 Jul 2022 13:59:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8j5R-0001od-U3; Tue, 05 Jul 2022 13:59:33 +0000 Received: by outflank-mailman (input) for mailman id 361317; Tue, 05 Jul 2022 13:52:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8iyv-0000Tw-AK for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 13:52:49 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0ff53e0-fc69-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 15:52:48 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id z25so3099322lfr.2 for ; Tue, 05 Jul 2022 06:52:48 -0700 (PDT) Received: from mobilestation ([95.79.140.178]) by smtp.gmail.com with ESMTPSA id v19-20020ac258f3000000b00483f8c40c14sm262435lfo.243.2022.07.05.06.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 06:52:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0ff53e0-fc69-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hnG3EXAGSYglCl/wRCeE6XoUd122X8s3VFjj/Cl4BDo=; b=f0oPNRCtup46ssQPcrkajodUnXaa38S7aucBwdDILFTG2eeb4ezSSagYCCpSaPXn6q pM88V+eJuR+2wDKnqOvmIn2UBQeLj4Dvk+jM/7QzsaH+djXUCf8dVdZrR3Rum0ZxA4Fx 1+V5jQK4WZ6A6r+Z7pGJ3DHRh/l/I+n6TS11toC5D+NwQqpCXjbGQMtOFJd9gZJEVfoN 8o6r4MmM6XpKVa4t/W7kzcEgwfUE3Y+OozwbzeYUm+9Cfc1rCiR8kyXeLGCPMRo+QW0N dWcQwNP8U6XumHQBe98yfaBeLuhKipyLuPvGkvNRoq32ZtcDVOLho4L9W1jGhun/Kcvn 3uIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hnG3EXAGSYglCl/wRCeE6XoUd122X8s3VFjj/Cl4BDo=; b=DYCxxdqlBArowFOcxmzpJ3r2REB2O5PRn4zC6S0xTanNnghtFmg7Okub9bik2vIzTd QtvjwK5w6e4fIFdjvsnII+oO7KsEedU4U+3gH5oTvMkIbzwC76GwMVBq+G3hf5/ddIW4 cPmXcfFoX1PrVZxblZ7+RGyB6/ToqtplaJeMzHb3ieyMfOrpqS1w2zU8VLU8inOimGk8 TR9kaGrUsXYszZQJJomRKEb6a74JFQr/djYVXSVzrdeO1GK4O0Nu19klhWEFRVVtD7cu GyU/PtAxsG38JJRuQ5A8sD697VnquTuRi+Y8cTO8aUg2Gu2Xq2II2M7NY+dVG2fGmQ9U miGg== X-Gm-Message-State: AJIora/Oj8tCUPfs8Y33MYq0ZsGC7BoIJibkufRdvnSgSgjFyZVgSE30 PFJtJqKmaMT4rsHo+FtdIK4= X-Google-Smtp-Source: AGRyM1tzQQEVczY5NcmNDovprbd7u0K8INSqZ44DlUGhkZwwx9elVzmtIOyIVqDnGRJUYz9FEGSPyA== X-Received: by 2002:a05:6512:b1a:b0:47f:b574:9539 with SMTP id w26-20020a0565120b1a00b0047fb5749539mr21685925lfu.143.1657029167643; Tue, 05 Jul 2022 06:52:47 -0700 (PDT) Date: Tue, 5 Jul 2022 16:52:43 +0300 From: Serge Semin To: Samuel Holland , Marc Zyngier Cc: Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, kernel test robot Subject: Re: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled Message-ID: <20220705135243.ydbwfo4kois64elr@mobilestation> References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-2-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220701200056.46555-2-samuel@sholland.org> Hi Samuel On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote: > The MIPS GIC irqchip driver may be selected in a uniprocessor > configuration, but it unconditionally registers an IPI domain. > > Limit the part of the driver dealing with IPIs to only be compiled when > GENERIC_IRQ_IPI is enabled, which corresponds to an SMP configuration. Thanks for the patch. Some comment is below. > > Reported-by: kernel test robot > Signed-off-by: Samuel Holland > --- > > Changes in v3: > - New patch to fix build errors in uniprocessor MIPS configs > > drivers/irqchip/Kconfig | 3 +- > drivers/irqchip/irq-mips-gic.c | 80 +++++++++++++++++++++++----------- > 2 files changed, 56 insertions(+), 27 deletions(-) > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index 1f23a6be7d88..d26a4ff7c99f 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -322,7 +322,8 @@ config KEYSTONE_IRQ > > config MIPS_GIC > bool > - select GENERIC_IRQ_IPI > + select GENERIC_IRQ_IPI if SMP > + select IRQ_DOMAIN_HIERARCHY It seems to me that the IRQ domains hierarchy is supposed to be created only if IPI is required. At least that's what the MIPS GIC driver implies. Thus we can go further and CONFIG_IRQ_DOMAIN_HIERARCHY ifdef-out the gic_irq_domain_alloc() and gic_irq_domain_free() methods definition together with the initialization: static const struct irq_domain_ops gic_irq_domain_ops = { .xlate = gic_irq_domain_xlate, +#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY .alloc = gic_irq_domain_alloc, .free = gic_irq_domain_free, +#endif .map = gic_irq_domain_map, }; If the GENERIC_IRQ_IPI config is enabled, CONFIG_IRQ_DOMAIN_HIERARCHY will be automatically selected (see the config definition in kernel/irq/Kconfig). If the IRQs hierarchy is needed for some another functionality like GENERIC_MSI_IRQ_DOMAIN or GPIOs then they will explicitly enable the IRQ_DOMAIN_HIERARCHY config thus activating the denoted .alloc and .free methods definitions. To sum up you can get rid of the IRQ_DOMAIN_HIERARCHY config force-select from this patch and make the MIPS GIC driver code a bit more coherent. @Marc, please correct me if were wrong. -Serget > select MIPS_CM > > config INGENIC_IRQ > diff --git a/drivers/irqchip/irq-mips-gic.c b/drivers/irqchip/irq-mips-gic.c > index ff89b36267dd..8a9efb6ae587 100644 > --- a/drivers/irqchip/irq-mips-gic.c > +++ b/drivers/irqchip/irq-mips-gic.c > @@ -52,13 +52,15 @@ static DEFINE_PER_CPU_READ_MOSTLY(unsigned long[GIC_MAX_LONGS], pcpu_masks); > > static DEFINE_SPINLOCK(gic_lock); > static struct irq_domain *gic_irq_domain; > -static struct irq_domain *gic_ipi_domain; > static int gic_shared_intrs; > static unsigned int gic_cpu_pin; > static unsigned int timer_cpu_pin; > static struct irq_chip gic_level_irq_controller, gic_edge_irq_controller; > + > +#ifdef CONFIG_GENERIC_IRQ_IPI > static DECLARE_BITMAP(ipi_resrv, GIC_MAX_INTRS); > static DECLARE_BITMAP(ipi_available, GIC_MAX_INTRS); > +#endif /* CONFIG_GENERIC_IRQ_IPI */ > > static struct gic_all_vpes_chip_data { > u32 map; > @@ -472,9 +474,11 @@ static int gic_irq_domain_map(struct irq_domain *d, unsigned int virq, > u32 map; > > if (hwirq >= GIC_SHARED_HWIRQ_BASE) { > +#ifdef CONFIG_GENERIC_IRQ_IPI > /* verify that shared irqs don't conflict with an IPI irq */ > if (test_bit(GIC_HWIRQ_TO_SHARED(hwirq), ipi_resrv)) > return -EBUSY; > +#endif /* CONFIG_GENERIC_IRQ_IPI */ > > err = irq_domain_set_hwirq_and_chip(d, virq, hwirq, > &gic_level_irq_controller, > @@ -567,6 +571,8 @@ static const struct irq_domain_ops gic_irq_domain_ops = { > .map = gic_irq_domain_map, > }; > > +#ifdef CONFIG_GENERIC_IRQ_IPI > + > static int gic_ipi_domain_xlate(struct irq_domain *d, struct device_node *ctrlr, > const u32 *intspec, unsigned int intsize, > irq_hw_number_t *out_hwirq, > @@ -670,6 +676,48 @@ static const struct irq_domain_ops gic_ipi_domain_ops = { > .match = gic_ipi_domain_match, > }; > > +static int gic_register_ipi_domain(struct device_node *node) > +{ > + struct irq_domain *gic_ipi_domain; > + unsigned int v[2], num_ipis; > + > + gic_ipi_domain = irq_domain_add_hierarchy(gic_irq_domain, > + IRQ_DOMAIN_FLAG_IPI_PER_CPU, > + GIC_NUM_LOCAL_INTRS + gic_shared_intrs, > + node, &gic_ipi_domain_ops, NULL); > + if (!gic_ipi_domain) { > + pr_err("Failed to add IPI domain"); > + return -ENXIO; > + } > + > + irq_domain_update_bus_token(gic_ipi_domain, DOMAIN_BUS_IPI); > + > + if (node && > + !of_property_read_u32_array(node, "mti,reserved-ipi-vectors", v, 2)) { > + bitmap_set(ipi_resrv, v[0], v[1]); > + } else { > + /* > + * Reserve 2 interrupts per possible CPU/VP for use as IPIs, > + * meeting the requirements of arch/mips SMP. > + */ > + num_ipis = 2 * num_possible_cpus(); > + bitmap_set(ipi_resrv, gic_shared_intrs - num_ipis, num_ipis); > + } > + > + bitmap_copy(ipi_available, ipi_resrv, GIC_MAX_INTRS); > + > + return 0; > +} > + > +#else /* !CONFIG_GENERIC_IRQ_IPI */ > + > +static inline int gic_register_ipi_domain(struct device_node *node) > +{ > + return 0; > +} > + > +#endif /* !CONFIG_GENERIC_IRQ_IPI */ > + > static int gic_cpu_startup(unsigned int cpu) > { > /* Enable or disable EIC */ > @@ -688,11 +736,12 @@ static int gic_cpu_startup(unsigned int cpu) > static int __init gic_of_init(struct device_node *node, > struct device_node *parent) > { > - unsigned int cpu_vec, i, gicconfig, v[2], num_ipis; > + unsigned int cpu_vec, i, gicconfig; > unsigned long reserved; > phys_addr_t gic_base; > struct resource res; > size_t gic_len; > + int ret; > > /* Find the first available CPU vector. */ > i = 0; > @@ -780,30 +829,9 @@ static int __init gic_of_init(struct device_node *node, > return -ENXIO; > } > > - gic_ipi_domain = irq_domain_add_hierarchy(gic_irq_domain, > - IRQ_DOMAIN_FLAG_IPI_PER_CPU, > - GIC_NUM_LOCAL_INTRS + gic_shared_intrs, > - node, &gic_ipi_domain_ops, NULL); > - if (!gic_ipi_domain) { > - pr_err("Failed to add IPI domain"); > - return -ENXIO; > - } > - > - irq_domain_update_bus_token(gic_ipi_domain, DOMAIN_BUS_IPI); > - > - if (node && > - !of_property_read_u32_array(node, "mti,reserved-ipi-vectors", v, 2)) { > - bitmap_set(ipi_resrv, v[0], v[1]); > - } else { > - /* > - * Reserve 2 interrupts per possible CPU/VP for use as IPIs, > - * meeting the requirements of arch/mips SMP. > - */ > - num_ipis = 2 * num_possible_cpus(); > - bitmap_set(ipi_resrv, gic_shared_intrs - num_ipis, num_ipis); > - } > - > - bitmap_copy(ipi_available, ipi_resrv, GIC_MAX_INTRS); > + ret = gic_register_ipi_domain(node); > + if (ret) > + return ret; > > board_bind_eic_interrupt = &gic_bind_eic_interrupt; > > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:06:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:06:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361337.590797 (Exim 4.92) (envelope-from ) id 1o8jCK-0003R5-Nd; Tue, 05 Jul 2022 14:06:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361337.590797; Tue, 05 Jul 2022 14:06:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jCK-0003Qy-Kz; Tue, 05 Jul 2022 14:06:40 +0000 Received: by outflank-mailman (input) for mailman id 361337; Tue, 05 Jul 2022 14:06:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jCI-0003Qs-Qu for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:06:39 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50053.outbound.protection.outlook.com [40.107.5.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af513314-fc6b-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:06:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9078.eurprd04.prod.outlook.com (2603:10a6:20b:445::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 14:06:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:06:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af513314-fc6b-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ky0sEi+EeBM5HdjHIIvV4VQnbLro6yRx1dxvZp/rYT6asfF8ZTGQjCJ27abfmXOhPKxbgxAluuQiUjNglxHYQFZ1BA5QFvJGrmCxclgHbdAfdQxnayThf9J0e1/k/Sd51Uu2GFWVpTyMjeYkuh72M78Mh4bi/uAM2jHzwVY0UzhYZtanU2J+mJ49cCcCW/EGSTloEUkZrUEYtK1lcUTO+PuvA0XKvAM7Db78PPnAN1Usvzd8yOh0tf0i5nk3lrLrSENVDPcasnQGVq08nFqBkPAyD0BgcOtYTJ/mp92aIRFzBDw4G6Ud4SjiaV+ayXwnYX08jZVaG+yyVkCKawe60A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1bAOa85+pWScZPs8MLVb6ZZmrXViQP9KcG8Mi6dCzpA=; b=fs6oW7o/+FSrl/21Eyb9M7lD2SYcyWpCdYoz6TXjteVqhLfpUEoBNMxzSuPPRzBaYa5mNYpNJoYsARw+C9TPTyzYOgo1X52SCKJWP7fooaby++yqvxLYeJQRbgAYON9VZgTGX17VmnmsjyE/3tAxHBvz0JzDWtUrXxWacAmi5HTBsVONuhQqvOYQu92VGlQ1rmr2SRn8uS7GFOuHBw5KFQquThg/r1y2MCsVQhdFqs1ZDZopA/wJ3w4ZJQA8/EQV29McVlgxhas8PNmiGVC5WwPSbok+sKGYEZ26/vyH1YsywkTbPBcnaN1eoz5/FOUAgU9fa4+JNFcSrfkYkPTGOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1bAOa85+pWScZPs8MLVb6ZZmrXViQP9KcG8Mi6dCzpA=; b=J2Y+XTHpH7Ip5ntE2nRhCAGagnUgHkUTHpBGWQ7L5fmpx/VwjSSM5+n9iQQig0kjVFr3QNe0+w6XAWt/ysxxDuCrxdOlOTiHKLp8HbomxOR7V1tsyMU2/l+d3bFLNsd+EHeQgNCrILcGo/bhCm6vISWW+uiph8yyDBySMXItusVesxYBglZvH6W2oR0ngIYTnh0YaEGB73JB3bJGRaZkj0Joo0Yi2xsaPxNSvXnQQmsnX6ThY+pOYmpGxcQkk4Ieaio8HqByK30ife/IGFip1m97c1HpUxffVEbCyyGfZg5bRUmKEBVn/qUd/wl67lCrWrv4AebtNirM/zObl/JJsg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <69615e24-622c-1609-fcff-87e5112d998c@suse.com> Date: Tue, 5 Jul 2022 16:06:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/6] x86/irq: fix setting irq limits Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220630085439.83193-1-roger.pau@citrix.com> <20220630085439.83193-5-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220630085439.83193-5-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aabf6ed7-a267-42f7-91e2-08da5e8f919c X-MS-TrafficTypeDiagnostic: AS8PR04MB9078:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v8237egUnJAal36HED29p2ykv3qtNv0HxyGxWE3Jo0Ntq+53ksU+baknyO9jLXPj8cAQXm3GYf0X74iG3K+dKnAYoi9H+Q5G02gEhhTJ+tqSMEvH9fqiGZ/mOJ66kTOnsAw3f7AIpMKaAYOiPk4MSAeJOD9VkV9BY7vucvUKoW49rFJOM3VGGvbPLhMQ+qbOchfOFiIRpwvK4BWTt4LP3owKXr9jbIi9xojDHvK0lJ4NSJOLo3PrqLBjnV+FP+gUA123rpX/G088u4fHTZgkzmE3v/Qrc1y8CwV9S2o50ZVgJDD0noFYAgin57I1A5d2SAJ/Mgw/FwQbGX4JGvXlWpj1n6CzXQInLsT/+PNZrb6rnE1dZpE3AeIDGPe6tRg/pxGq2E5t9OY7uhoxBVYsxpqrMFXeB134a5FQ+a6Uincb6DqloItnOEUpur4lhVAIeoMWjCBixEF6COYZKhJrnuE+ZcGjBJRuXkKUU3zSpFS3aPJPkvXPKJgFXh/i4kDd8YnviNsYKzQwxMnJXHmGY6QqvNKD1X7RuKNtDsbalbe8Nkn1vIkwiVFM1r/JYYOEXpRTGYaxjKThRSS3k9G6q87hbnJgwrxajQwI/8X/MJhYUj8g18fAea7qtBeXQmFKVdjeddf8lzFAqV8eoDXNBIImWUOKvfhRHAtHv5zkww0xMbx1szgBCqdJp0IACN7M8cj8F+BzCOvcntYouEBqJ/vc8+l7lVvONadH8RwYMXwhfksAlmck3ex6t5H94CE4DrhogDhfa7joXNg76Sg/G69c8d3FUaLTxoVVnx2bN0ggc5Q7BN0Tyvg7HngqO+vyvCKIzIGXXwHl5xvfxVOKxVj6JoJSfAwVp8je9uF81vM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(396003)(136003)(366004)(376002)(6512007)(8936002)(5660300002)(53546011)(6506007)(26005)(66946007)(66556008)(4326008)(66476007)(8676002)(6916009)(54906003)(41300700001)(6486002)(316002)(31696002)(478600001)(86362001)(31686004)(83380400001)(36756003)(186003)(2906002)(2616005)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1lnVmpnMzRuN0p6YjQvbHhmZlRTZTYzRkx0cU5ReXJWdys5ZERsQ2JDSE5N?= =?utf-8?B?T3dUZm9UQmJ6Q3dtR1ZqelJlcFF2SzJEOXduRlorNlNaUitualh0L1RpZEMv?= =?utf-8?B?SGEzbXpjNExEaUE4L3A0S1JscTQ5UDZncFVYQnZtYjlXUHhJNmVuV3E1YWNp?= =?utf-8?B?Q1Y0VFQwUUU4NUlzdU5VdzJPQ2xIeW80ZjhDTW0zWHFITE9tMHorN2dybVZl?= =?utf-8?B?Qk9BNDhzR0twUFMwNitOanNqQXRmaU9IVmlNRGhMRTZvdjZJQThSdVIyeUw1?= =?utf-8?B?ZnludVlmS2pENklRZENRWWlNdkYrQ3JLMGNSc0Z6UVpUUWRJZzlIN2Jmcktr?= =?utf-8?B?ZlR1YUthY3pXR3R6U3FvNDgzT0daRDRia0ptc2p3MHp0YTVNVnh3dS9JVjYy?= =?utf-8?B?OGE2cmVvcUlub21tZkh6WndBVlhTR0d6K1k5QzhpcXBmVVN1UDNrbys5Y0k3?= =?utf-8?B?SXUyK1hvYjJyS2pqYW9NL2dlNFQ4c0ZlRTBmT09aK3M3UGhudmNCQ1dMVlBq?= =?utf-8?B?ZS81OW5hYldzeWJrMDNGVW9hSXBRZStvU2VYRThvRjNVaU5OeGpiRDVNeHNa?= =?utf-8?B?SEtpSVlveFlCZnVZWXp0YVRMdGpvUmEwVVVEZDhETitBcXlCTTUydEwvNjJ0?= =?utf-8?B?aXpwZkc3VWZ4UFE1SEVnWjI4clZRUGZmZCsvb0txWUJnTFJKN2ZaSTlDNUdY?= =?utf-8?B?QkhSVmxycGZLNlQ4U0JERlZtKzl6R21VZWIxcjYvTml0SEpUQXVPb2JtNXVN?= =?utf-8?B?MytLcEN5cjdIbFpLSkF3Rjg5SFU4TGxyejZRLytjQTRCak1XZ1lzMzlsWmxF?= =?utf-8?B?eTdvNzBlbHNMQ0pOY252K3hHRWdVWXJkQlBaNDRiT3RVTysybmlJdGwwZUdj?= =?utf-8?B?bDhZYXZYZ2Q4OGhoUXg2aEsvUEFsSEdScUQyZVJjUDJ1c25HeGpLcFNTRWNs?= =?utf-8?B?MFF0TTlzTHdwYlFicGNGdHlvMTR1YjNEUXNobnpDM0dyVmpCSnFGdmFhYitS?= =?utf-8?B?bGV3cDVlWGR5Rm16eFNjWnFvdHVFZWdWL2dFR1hldkRkYUNTdkxIeFY0MGhj?= =?utf-8?B?a2ZCVlp0c2lCLzdxK25XWnUxM3Rld0ZOQlVVc1c5YnpubXNTNDdNcnYzdEEv?= =?utf-8?B?cnU4UGFVVktGZTRWaGNKaitkdHoxNnhSZmEwNzB3RjVEVC83UXowSndGWXpF?= =?utf-8?B?cDhtV0prSzBRd0Q4Z1VCWFZkWEJ3Um9RYkI0K0JjMm1NTDkyUHZ1cjV1UVJY?= =?utf-8?B?SndNN2RQdzg3Ukh5SnVSbkx2d0QvZThsbFlSblJlZnJUdEQ1RGpadm9BOWtG?= =?utf-8?B?cTF3Y280S1pDMnRqTU9kZUJ0cHFWbXU1YzZrSGhCaUJ3RTBrVkROV0pLTXNw?= =?utf-8?B?SWhCZmJuUUtEWkxuc3lOT1Jrc3ZoQjEyMVFuSWlsOUJxZDlVRnFtdU55UVd3?= =?utf-8?B?Tis3ejhLTWMvWDhyNHhtUjVJNWpheFZjN0c4VysxZGVrR1UvT1JRb3FEVDJ6?= =?utf-8?B?SVdZZ3JsYzhTRHkydEVWamRWdU5BZUNGSkxrejMvY0x0bU1XbUlheUtEV2lQ?= =?utf-8?B?WWc4V3RiYjh3Z0lGOEc4cmV1Q29ObzByb0xSSUtWMEtPNXNPanBIb1dEL3Fx?= =?utf-8?B?eFpleDBDNUF4dUpWUzN5SHNsd2VzRDZiRVpPYVVicnBpUmpLSGpIOVpvZTIx?= =?utf-8?B?VFNMVVAyVG4zdCtJaXZraTlBYm91bkNkazhOandWTFVHb21QR244SVNlUHh3?= =?utf-8?B?M1lRNjF3MTZETUs3OFV1TExCb1NyaXdNanEwMXlCWHdyS1Y4eUhlRHdlekFI?= =?utf-8?B?aGx0eU02b1Y2YkhaNTZnU3ZHQUlCRGk0UVFFN0dsaXk0UzVrWkt6RTB0YWt1?= =?utf-8?B?KzhJN1cyMTNqQm9QbWF0Yys3clkvd0p6S0x5a0p2UFZBZ0ZwaVJyekNTSE9j?= =?utf-8?B?cVBDem9RT3I5VFZHclp4RmdHMG5SUVBRakdJclYreTFoZVMxUGErc1p2Tzlk?= =?utf-8?B?dmMvNnc4SzhMeUlqa0NUVTduUzJOUGVYT2dQT1RTRFJwSStBTDRiSnBGNFJq?= =?utf-8?B?WjFIaGIxTlJ3blUxYzhRYkJhM2lZeThXK25GZlNHSHcwZmlPYVNsVjMxUFRV?= =?utf-8?Q?zE/mmj4Ifiij8D2szDibmX7fH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aabf6ed7-a267-42f7-91e2-08da5e8f919c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:06:34.3575 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rNDdUZGxtyq0M6N0olzkfN8pBXg/HJ7CzaRM6xmrTlNxE1LX4RYo0ruRYWjH7TTfWzEjxt9qbUUELS0A0ifeeg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9078 On 30.06.2022 10:54, Roger Pau Monne wrote: > Current code to calculate nr_irqs assumes the APIC destination mode to > be physical, so all vectors on each possible CPU is available for use > by a different interrupt source. This is not true when using Logical > (Cluster) destination mode, where CPUs in the same cluster share the > vector space. > > Fix by calculating the maximum Cluster ID and use it to derive the > number of clusters in the system. Note the code assumes Cluster IDs to > be contiguous, or else we will set nr_irqs to a number higher than the > real amount of vectors (still not fatal). While not fatal, it could be (pretty) wasteful. Iirc discontiguous cluster numbers aren't unusual. It shouldn't be that difficult to actually count clusters. > The number of clusters is then used instead of the number of present > CPUs when calculating the value of nr_irqs. This takes care of x2APIC clustered mode, but leaves xAPIC flat mode still as broken as before. vec_spaces should be 1 in that case, shouldn't it? > --- a/xen/arch/x86/include/asm/apic.h > +++ b/xen/arch/x86/include/asm/apic.h > @@ -27,6 +27,8 @@ enum apic_mode { > extern bool iommu_x2apic_enabled; > extern u8 apic_verbosity; > extern bool directed_eoi_enabled; > +extern uint16_t x2apic_max_cluster_id; I don't see a need to use a fixed width type here; unsigned int will be quite fine afaict (and be in line with ./CODING_STYLE). Or if you want to save space, then it still would better be "unsigned short". > @@ -199,6 +201,9 @@ static int MP_processor_info_x(struct mpc_config_processor *m, > def_to_bigsmp = true; > } > > + x2apic_max_cluster_id = max(x2apic_max_cluster_id, > + (uint16_t)(apicid >> 4)); > + > return cpu; > } I assume you don't mean to also account for hotplug CPUs? If so, please add a respective statement to the description. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:09:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361342.590809 (Exim 4.92) (envelope-from ) id 1o8jEu-00042l-6u; Tue, 05 Jul 2022 14:09:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361342.590809; Tue, 05 Jul 2022 14:09:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jEu-00042e-2n; Tue, 05 Jul 2022 14:09:20 +0000 Received: by outflank-mailman (input) for mailman id 361342; Tue, 05 Jul 2022 14:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jEr-00042U-VL for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:09:18 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d152686-fc6c-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:09:16 +0200 (CEST) Received: from mail-bn8nam04lp2046.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 05 Jul 2022 10:09:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5751.namprd03.prod.outlook.com (2603:10b6:510:37::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Tue, 5 Jul 2022 14:09:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5395.022; Tue, 5 Jul 2022 14:09:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d152686-fc6c-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657030156; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tPqeXKha6sP5c9FAZHnaKkJoueNTzZ3V4wDFQ08QLZc=; b=MvzSamRzXWJiNDZVUqevAMrHWaGNN3tAF6sneSQBQY5AFSrzOd3tXGL9 szNX6l4Rskbwy2W76DcCB/RUdiN6InfKg6TUVlttzfjm9wA/AGwdIajqd wBvYAoEI3JB0fYD5O9IYLyIlPnwUNft6tqUS4bm3oxsiobdalXzXuhobo M=; X-IronPort-RemoteIP: 104.47.74.46 X-IronPort-MID: 74928077 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rLQ2e6uVGwUWIG2IXe87TxXPL+fnVGZfMUV32f8akzHdYApBsoF/q tZmKW+Pb/uMMzH1LowgPIvl9xgB78XRz9FkTAJqqH1mEH8W+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zV5 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi90EPCS3/YkYyVfMBFkbKsY+73tcCmW5Jn7I03uKxMAwt1IJWRuYcgy3LYyBmtDs /sFNDoKcxaPwfqsx662QfVtgcJlK9T3OIQYuTdryjSx4fQOGMifBfmVo4AEmmtu7ixNNa+2i 84xQDxjdhnfJTZIPU8aEskWl+a0nHjvNTZfrTp5oIJovzmJnFQuj9ABNvKSf4XNRfxngnq+5 Tma5DT/WD9CFfKAnG/tHnWEw7WncTnAcKYPH7T+2Pdsi1CXwnE7AQcTE1C8pJGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1ZpasEitcIwbSwn0 BmOhdyBLSd0rLSfRHaZ97GVhTC/Iy4YKSkFfyBsZRQBy8nupsc0lB2nczp4OKu8j9mwEzegx TmP9HQ6n+9L0ZBN0Lin91fahT7qvoLOUgM++gTQWCSi8x99Y4mmIYev7DA38Mp9EWpQdXHZ1 FBspiRUxLlTZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:exMWZagGKbTQilMcMqv0Ep+1jXBQX3l13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQwu2Vms hwrh2knosSAhXakCvn4d/UExlsi0qvuHIn1fUelnpFTOIlGfZsRKEkjTRo+a07bVTHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TtE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZek6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z74HSKyGG5fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMlP8Pe X-IronPort-AV: E=Sophos;i="5.92,247,1650945600"; d="scan'208";a="74928077" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAlaeRujLeexrYgr1uBUGVQjjv4yNo2RSRk2UEjddtFBptzlX7SCTjPtB5WzyFwpds3Ln9TzdZB1yKOXIBdWwHkUfjQsFWsNugQOsa0TsRn1sU7WgP2wtiH8Gwp1rTsfV6/JoHC4Qq7vlFJHJj8iixWYFnPWdrTHF5Yd8xtFln0ju/udCk6dIzM9VKd9FMAwMXcFJ8333owH2cHSiE0oMhjCh6ZzhGYfUOeu/R9ZkPp7VcZcGcBG4FWDKP3TA+cfvwUO9R4Q0WkZYt7oiOI1CJ1aiqtSzzKT6XidQqUGl7ztFGVhu/P2n1BRiI36/VPna5PpiFQmfapDVyIegpuo9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPqeXKha6sP5c9FAZHnaKkJoueNTzZ3V4wDFQ08QLZc=; b=M2EOLLdtV2JrmY/a49FORvh/2qluu4g1KYodwIOu8TBX9/y7bzhZ10pSfir+hFVsQ6wxxRfsJrh0J31sYdow+fMjVUUzR4xBJHva30kdBokV1x6zf9kBR5Rz9R0bHGJQVZee+bJL+xniuDNwbqwsKhRqHKDEMptwUyad4jBWpTV9S7eaKrGJFM3PIpYRURG60Ne3Kr0vSeWiEXFrn4A4rc2UFCv8QApCxr0ZcIk7Y7sUcpDtySN95uYyGZ9QPawm71yznUeZjEfJKpLo9AP+fNPvNsA6iAM+VVK//qAbI6XMhPXjYCT6oRIpXhKYHBwf2ZAZy4NHjFD4NtgOxILzgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPqeXKha6sP5c9FAZHnaKkJoueNTzZ3V4wDFQ08QLZc=; b=uaiPxF15CTkkwLQfUxgD+iJ4IwWRgvH7LovwWaA5xZ4jYDyhyzZhEontY9yIaNpcOb6e7qRO6WVDP6eKVvnbhcrYhzEAgdo5pn9aekpVFI22MheVZS/xkmCamZ/Tus+Yb0s0KvEZYJ1KczQBoHGmvFROX26t1HA50+dMKMg7r7U= From: Andrew Cooper To: Luca Fancellu , Xen-devel CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: Issue with check-endbr.sh during Xen build Thread-Topic: Issue with check-endbr.sh during Xen build Thread-Index: AQHYkHcMKffnFiUSAU+E175V5Z5atq1v0KAA Date: Tue, 5 Jul 2022 14:09:02 +0000 Message-ID: <529c9b80-fa74-6f2e-f9c5-e53f09aebbb3@citrix.com> References: <815D8CFC-86A4-4C63-AA51-83C4C29E7AAD@arm.com> In-Reply-To: <815D8CFC-86A4-4C63-AA51-83C4C29E7AAD@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f3c671f-1a44-4f9d-6db0-08da5e8fe9db x-ms-traffictypediagnostic: PH0PR03MB5751:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GQdaPUe1wWRcIcwqkroNua2zQjWfg74+HyHFot0MYYOxixlrPs35KWbF9T7lCkd+SGg/peFJlujEqeItKXQnwrXFMF0JTsgnRSJ+yPK9pemRxikOHQ8bPfI2AoOSm0jm73k/0V/sy5xb4OH4lgs6lJ7/K/StWXdFQ3qvAlNxq3Xl2p7d6PTYI7FV9vUGwKPu6ZE6DmYju7+EX8hifbxa59VTBEQgzd7g+2Jw12uY3EtTdqZd6R37ZM+qjwX/fib0s0CmIECaagjfL8hj7t8r1GhXXgcLPIQTW2ZAevdTEnlANu1484YwZlcnIBOz6QYXaHObZokbvvOMh9rtC5zZeJzKKPq3CdzTGiFuE7DRotRgCwXWuQqRzAaHgq5nTUKF2Yw/c/GdJ0zeMOQV8NJqWYFnqO/Ag5ike7yrA06G9iYngbMDRCnNH1lhfAPtZgDcOfXq2g0wY3+Ag+2U1h8ggwc/UgrIcP0qRbncOka5wlhBF6qhZbK77LnJV+S3JoyGUa0qJGLF4kgqZub47YvYqNZOplmr65OzQ234P3QWaKT+QOLGwZa13T4lDyxriMXbaWMP8+vbkohu4RkFjGcPX3jXyjylH7V3bmK3H82xhx10dD8UXiPR5mdEU6XQfhJSKMcIFRRTX7lZKAW4W48lU1U7geOiqoxmkGfi7eZ8cSHAkpF+LYbeKxHYAhVstErbTMQW8TUuNRmaGrb3MbjT0Uag6ojixLZpP3WG+hzLW7TKvb7FY44VvV2oJwtdCsrmdSxe/CMREtaaol4lyZ3DVRUjIkgFnPQP6n1bWn+B/uW6WHVIp50GABlaky65TsnPB1H9x7Sz5y2NpxTSl4RYg0Hmy8e1TOEBfXtBo+v1wlpwLdECZFhdeZvdh28DsGjH x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(366004)(346002)(66556008)(66476007)(66946007)(6512007)(76116006)(2906002)(4326008)(26005)(66446008)(91956017)(5660300002)(54906003)(71200400001)(8676002)(41300700001)(83380400001)(8936002)(478600001)(6486002)(2616005)(186003)(38070700005)(316002)(82960400001)(64756008)(36756003)(122000001)(6506007)(31686004)(86362001)(53546011)(38100700002)(110136005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cVhDNld3T0tNOW9UQUZuT2xzTU0vQncwR0p6M1dHN3hUZXA0U2RNWDcxVWJW?= =?utf-8?B?RUdOZU5Ib1RiNjE5UWJKaURMVEdaZjFqZytZUmZZa0tyUE9iQ1VsTERZZ25U?= =?utf-8?B?RVB4aGJ0SmgzTzdHejFEMEVIc1dqaUU4MVdiRUZCaHJtam5TVHlEeGRrKzcy?= =?utf-8?B?RFlhY210SHo1eWU4WFQ5a2Q3ZHhkY2tUZTRvWUlQVlF6eWNrOG9iTEFIWGVH?= =?utf-8?B?MlIzVFZJVnd3REhOWHVaRUdTR3lDTklpQXdKKzNEaUZvTitIb1krbmtRMUR5?= =?utf-8?B?eENPVkRXckl5Nmo0QkgxNmlWcXFzaThpaloyMWx2VTN1UHo1UlYwVFhxMTJj?= =?utf-8?B?WGN4b1l4N2VEU0dudmRxVDNlMWo3N2JyUTVkVzB6eFJhSnNpRzMwR0U1dTJR?= =?utf-8?B?SFlPeHdvQ2lqRFN0L09ENG05RlNzRVMwNkIzb0JnWHF2RlRmYTVIbUVmNWRl?= =?utf-8?B?eTgvZlRWbnNIUmZPUHNDakwvbHBEUFdyemtHUGVZZmFtck5TSm1OK2EweDkx?= =?utf-8?B?Tyt0b2FueEs2YS9JZkpkTkphcmJmT3dqRTFsYXMrU1FjeE1STk10QWxiVHVo?= =?utf-8?B?cjEra0tlQ1BXUGh6M3dwNDdsbzdGQ1ZtZFZsKzN4SkFCbjlqZGZYOU1mak0z?= =?utf-8?B?amYrRGJjcU16RFlhenUyS2U1ZDVaalk4MFVYU3BkcU5scEFXNjZXU0R5Y3cv?= =?utf-8?B?SGdnT2pyUWJLU1NTYUowUS9RYjBMTW5qclJCYU1ZN2FGRktNU0kydHVXYkZl?= =?utf-8?B?RVpaakNkWlRmN1UwZURKdVlLV0FiTlRXVzhXRjdUUHEzc1FHUWFGemFQNEhw?= =?utf-8?B?K0J4dWh2TDZFclFldW1NcUw1bHNJeG9OMjNhU25ZU0ppeHV5YXZUTkdZd3p0?= =?utf-8?B?eTN3am1zdWJHdW4rL3NNck1wdWdCUlN2QkR6bk5aa3IwRk80cXVDVnBDMEZr?= =?utf-8?B?Tk5KMDZCM2dYZS9wZlo3ZFdESUxqQjErRXN3cGREWTVUMTNMc2xLQk1xR253?= =?utf-8?B?M0JtRk1CRHNERytvbE9sdGhXcVdVNS9KdTVhTSs1ekFnM29VZGFKVElaT0No?= =?utf-8?B?M3J0YXBENkhCWmdxWVNpSEZVTnd4ZW5jdTh3VGNDL2hMS29pd0NQVUJtM29K?= =?utf-8?B?Sk5mVVFEdFZSRnJRN3Y4dnhoNmtzYnhIQ01UWW9oNEVPQ2FGbVdHMzJ1cFVU?= =?utf-8?B?WEtKdllEYkE0NzVDdXUzMlRkaWJRNksvVEJtOHRqOUhpeXUza2FTVUI3MjBW?= =?utf-8?B?YklqSjNFRVdtMmxpdWNrOGcvM0ZSS0MvVDdKNWZKc2pDTlZLVUx5cWU0eEZn?= =?utf-8?B?Mkhtb2g3SVZFelJWYjZKaVYwN0FRYjNQY1JXSlFZUGFxOUNyd28rc1laRUVn?= =?utf-8?B?MlV3b3JCR1I5R3NyT1UvaHVsRkJGdThVNndjRXc4UkJoOEVWVTl4V1lYVkhV?= =?utf-8?B?dVBGc1R6VWFXYjBZZHo0b1RYRndGZzJlL0VBTCtrdVZ3UkZQRlhYUTBINWZl?= =?utf-8?B?R0hRK01tdVlXK3NDNFdIL3JLa3d4NFQxS09OTlBvdG5XbnJVS21lWENYRUo0?= =?utf-8?B?eFhUTUMwVVBqS1VMazZabDV4NVdZdm9CZFFJY3dsS1Q4N1FDcjdYUUFBMENN?= =?utf-8?B?b01iZ3RKeXN0ZUovMmkxUng5VU8rbFpBZXZacUZSVDZ2OFpUQTlqc3d5RFNQ?= =?utf-8?B?NVR2UHIyMHkzMFF4WFdPbUxTdUtMRC9STTRkOTVyYVFZR2p2TmhqQ2VpUDZ3?= =?utf-8?B?VE5HbFovNG8ySTFYdWRwN3BjSllzWFpMRHM4bEpzTlB2di92RHhXQmlncmUz?= =?utf-8?B?L0RPdHJEL1NHUEV0d0U3bUNCSGVESWpHQ3BKWTZwVEd4K2VrK0dQMktPYnJk?= =?utf-8?B?NWNhbUJlanZZMHZkbGRvMXFlVE1lZHd1M0NreWI0ZkozSXNZWHIrNHZrWnRh?= =?utf-8?B?dGlKL0FHZEN1UFQ3S0FxQlRSNnZiNEU4RjV5UXNyYU5oekZtbnhyR1BHL1hQ?= =?utf-8?B?d2JnTW9TWDNPaFoyaU04YU9ncGV5dkx0UEEzNWZkM1dGRW8weC9uTXBUTVVt?= =?utf-8?B?QkhHSnZJSGsxeEZTcHBraVhmaXc1T3VmMUo1TWZWU0lGOGNjYUJYSnlLTXVT?= =?utf-8?Q?IcEQc0z7wPcv5QIJqAGEKPTfP?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3c671f-1a44-4f9d-6db0-08da5e8fe9db X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2022 14:09:02.2996 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YOJfJwwxm2X1lFITN4xnpaNTqJxe460ikMBLoOPSIOHyTaeH3M7naT/AW/UQhvYYMGzlKIhA0GOWlHC2TwTu4hPyhnLi1V1hWe9ivMfg3So= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5751 T24gMDUvMDcvMjAyMiAxNDo1NiwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4gQWZ0ZXIgc3BlbmRp bmcgYSBiaXQgb2YgdGltZSB0byB1bmRlcnN0YW5kIHdoYXQgdGhlIHNjcmlwdCBkb2VzLCBJ4oCZ dmUgY2hlY2tlZCB0aGUgYXdrIHZlcnNpb24NCj4gYW5kIHNlZW1zIHRoYXQgdGhlIHNjcmlwdCBp cyBmYWlsaW5nIGluIHRoZSBEb2NrZXIgY29udGFpbmVyIGJlY2F1c2UgdGhlcmUgaXMgbWF3ayB0 aGVyZToNCj4gIyBhd2sgLVcgdmVyc2lvbg0KPiBtYXdrIDEuMy40IDIwMjAwMTIwDQo+IENvcHly aWdodCAyMDA4LTIwMTksMjAyMCwgVGhvbWFzIEUuIERpY2tleQ0KPiBDb3B5cmlnaHQgMTk5MS0x OTk2LDIwMTQsIE1pY2hhZWwgRC4gQnJlbm5hbg0KPg0KPiByYW5kb20tZnVuY3M6ICAgICAgIHNy YW5kb20vcmFuZG9tDQo+IHJlZ2V4LWZ1bmNzOiAgICAgICAgaW50ZXJuYWwNCj4gY29tcGlsZWQg bGltaXRzOg0KPiBzcHJpbnRmIGJ1ZmZlciAgICAgIDgxOTINCj4gbWF4aW11bS1pbnRlZ2VyICAg ICAyMTQ3NDgzNjQ3DQo+DQo+IEluc3RlYWQgaW4gbXkgaG9zdCBtYWNoaW5lIHRoZXJlIGlzIGdh d2s6DQo+ICQgYXdrIC1XIHZlcnNpb24NCj4gR05VIEF3ayA0LjEuNCwgQVBJOiAxLjEgKEdOVSBN UEZSIDQuMC4xLCBHTlUgTVAgNi4xLjIpDQo+IFvigKZdDQo+DQo+DQo+IFNvIHRoZXJlIHNlZW1z IHRvIGJlIGEgZGVwZW5kZW5jeSBvbiB0aGUgaW50ZXJwcmV0ZXIgKG9yIGF0IGxlYXN0IGl0IGRv ZXNu4oCZdCB3b3JrIHdpdGggdGhhdCB2ZXJzaW9uIG9mIG1hd2spLg0KPg0KPiBNeSBzb2x1dGlv biB3YXMgdG8gaW5zdGFsbCBnYXdrIGluIHRoZSBjb250YWluZXIgYW5kIGV2ZXJ5dGhpbmcgd2Fz IHdvcmtpbmcgZmluZSBhZnRlcndhcmRzLg0KDQpIbW0uwqAgQVdLIGlzbid0IGV2ZW4gb24gdGhl IGxpc3Qgb2YgcmVxdWlyZW1lbnRzLCBidXQgd2UgdXNlIGl0IGFsbCBvdmVyDQp0aGUgcGxhY2Uu wqAgVGhhdCBzZWVtcyBsaWtlIGFuIGVycm9yLg0KDQpPdXIgRnJlZUJTRCBidWlsZCBlbnZpcm9u bWVudCBkb2Vzbid0IHVzZSBnYXdrLCBzbyBpdCdzIHJlYXNvbmFibGUgdG8NCmFzc3VtZSB3ZSBk b24ndCBmdW5kYW1lbnRhbGx5IGRlcGVuZCBvbiBnYXdrLg0KDQpBbnkgaWRlYSBob3cgZWFzeSBp dCB3b3VsZCBiZSB0byB0d2VhayBjaGVjay1lbmRici5zaCB0byBiZSBub24tZ2F3aw0KY29tcGF0 aWJsZT8NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:16:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:16:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361350.590820 (Exim 4.92) (envelope-from ) id 1o8jLW-0005bH-02; Tue, 05 Jul 2022 14:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361350.590820; Tue, 05 Jul 2022 14:16:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jLV-0005bA-TJ; Tue, 05 Jul 2022 14:16:09 +0000 Received: by outflank-mailman (input) for mailman id 361350; Tue, 05 Jul 2022 14:16:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jLV-0005b4-9R for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:16:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ffbbc66e-fc6c-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 16:16:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB3008.eurprd04.prod.outlook.com (2603:10a6:802:f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 14:15:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:15:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffbbc66e-fc6c-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XL4//Ci6Ac70HvYrvWAU2zK6G0I2QqxxmKgSYd0GfpJ2Ib/le83RBGGq7Kw6BAgZOyXgFvChpi1S7IJWvAKegEk/Ha2nns3c95YC23aqI+tUfZoVOaNl0mUnOT/DLOyRhvcVVLwaSKgcqaoiIf6Bo+WMUhbgsDCVoVa0GVTu+hQbCJbEGgfmytLAg8xi1Gfl6LwZF6lfqnHtE3Lc1uCKS7gCOrRKKmSbFDgQLRHuv48nQpL1MnvkPikcEuFt4lRaE1cuvq3H7y0S1502vuqrZTAIVkJjpVo/bgGME4CvxeDB89uKl9zNxsWkluwpPaVKb8hAxJTWpUrFHWtmKeC25g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OJRaAqWCSZDbFVRg2qdHGs4kdr5lV147tVg0bYJvx+8=; b=FRJPmLeHNHlssPOKZ/mr9naXoo/IeDVQyNxRCMU11jI+4LW5KiLTwQ/p3YCXNgF36Z5nQshi0ZlTAk3/h5y0UjQfkR0FnfOUQc0ONaKv6nGbtdxR2PVzqa6HGcOn/2c8m8SSOQ3owc7xxqhMUXb0XRFVah8iFh2xLMkXku/fmfRYHEGz6EcbPk96uERVuf8oCGJAzHLv3z0bTFep+J2l/sSz69etB2amMxkebjCs5VC1/2iSwqHSCHMajLtAfvVbgN/CbWgtRxy7MNgTNkgxsYVwkVvzksJiRPr/9njl72tyY5OsPqwrdJIe+1MNIiBcS/QEuynVouz9zPHC9IG8wQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OJRaAqWCSZDbFVRg2qdHGs4kdr5lV147tVg0bYJvx+8=; b=3ptJsql4kFK4uxfoHAkRBt6d9ydNNuNjeBBf4h04cwc0lFKIKVUsn+7zOFRzI2jhJ2TnlSvVnKeUN2B6Jvvov9cqhmPzqU5k9Mt4VLDwMMrghR/jBEYd1gO9koeYs8x+325cUIcmMgy5e+btZhrdpCoRGciCQ0Xbi5eJO7RmsrzkUWhBZTH2nDZnrCMVwo0C4WAnT5AoMxgbbN+yTxR23yCUjXyBKQPMRvjcqKdiFZvNOmhm2qd+voZqap3jvLia10J3h3d//La6F5/PU0Tse3cpgqXImD9ZSQZapWh5id/Ydw0Qd8tE4iO9CePi6G3myGpdlJSBcYQlEtmpr0ZSOA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1378d0a8-3001-3ab0-896d-cb38dcfc4c65@suse.com> Date: Tue, 5 Jul 2022 16:15:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/6] x86/irq: print nr_irqs as limit on the number of MSI(-X) interrupts Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220630085439.83193-1-roger.pau@citrix.com> <20220630085439.83193-6-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220630085439.83193-6-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR01CA0053.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6eb8c84a-cb5a-4981-0d8a-08da5e90e24d X-MS-TrafficTypeDiagnostic: VI1PR04MB3008:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pOh8AVMWAinhM5TXkoNRwKnG8qOH7MKDm5vV5A+tSGWGcK17bhrwgPqOWCUxGf+7RF6jEFPJi6B7zGr52GkdTudhiC5lMvhsFThWaGTBC3E1i23Af67X7BTUDUaw84UsarCxdjl4atj6IOVjwqReP/Spm8P5mBa/uaRDouoO09lXG3+eyUgRD+MEgPDSxK/kp48UCjJS1SRnv16vt4dB5T8I0TCuB0TpoSl3Jl9ZSa0Jn28GFMK1QHwZi/1+GaNuIYMR7OKg0VZGvAxlMrTDK0v92FqGkpLpMYQ8CRyJw8DRwoa8dp/k2h1g3zP00kuOL4H5DdfZVlMjbSos3Ev1pSTrUyo6+7C+FvjiuZJopLI0ZktZ6+Zrzbs5GCk+ORL9S/hGe+tmgMwYTaorKEwxaM2IflyESlXZofx/JabP5SfLYmHydoXX7sCVTpE6wTV9uug3Yt7exiZCWL04snUviTJciyAyXYT4MEnCDQLtXgRdQQTFzGtFS6dLh3sd6SU9dKC2Gnvi9x0AWZNZfjuu3DmXGE39X7ZpoC5i25EOS56gjxT04jHt228iJ4IcHXAemHoaDM+eWPh5wX8KobnuYT6BtxQLzCrzXjzi/faNuMIvEGxz9lybP2Ur9XLGIB+KzkeFUHkKaFBB8GIrSQHQdSq+vsd572AIL+AnoJPLzf7oq/ohJdTHDHwEEjgoty7/32dyPvlf3A76hbEcbtwABTmVES57P2oqRt9HWQMbAr8+LgKQT+PJke/FV0YoxkXKT7q5UphbAHhUg0Uh0f29EcD6aRF5MSS04UC9tOSeipO1PENlYb78nR9yktbq5/Lt43UdZwAfEvXts6e5qPrm9jOYiAC/aOSq5oyeQ/zpd70= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39860400002)(376002)(346002)(396003)(8936002)(5660300002)(54906003)(4326008)(8676002)(66476007)(66556008)(66946007)(86362001)(41300700001)(31696002)(6916009)(316002)(4744005)(186003)(26005)(36756003)(6512007)(2616005)(6506007)(6486002)(2906002)(53546011)(38100700002)(31686004)(83380400001)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RWJ2YzFlUVBraWpBdmkwcFp0emRNOE8vcm5LS0tIaEs0RG9iQlV2TnViMFFi?= =?utf-8?B?dmQ2b1RwQTJTU0xsalZnWTVmdFNyU3pPMGFkbVVBRVhabUppbnhpa2tiallZ?= =?utf-8?B?NkFRYkJzcmEyM0wvcDlwOEw4czlySVh3S29TRWdnVEc4dFgrY1lncm5BOW9x?= =?utf-8?B?Q2Z0dkhTTUN2UXFNSnk2eWNNNDFXVTlDWjB3RUc5VzFJYmF6Q2xneFd2VDRX?= =?utf-8?B?V0pZdmtrTUwwWmFpZmRGS2xXaW92cGtLNWNTSUpsUHdzQURXMWp4OStTS2or?= =?utf-8?B?Q3VHbWs0Mm5IMTZVRmNVbHRxYWxMNE5XZzFqSU5sTHZXTWNRUjBsQmU5Wm81?= =?utf-8?B?RHFJeE92RVFJb0lkTHQ4VzhkcllyMTBPaXRieEhDRmZxTVoweTYya1JqQjJq?= =?utf-8?B?R1dwdkdXOTdDRDJacTFUS1M1cDJUb2wzY3BjZXFKRS9XNHU2QXpCSVdPNWpl?= =?utf-8?B?VVpETnpsaXE5eEE3N1Y3Y2xvdUtTdm93aWRRNHh0dHdQZ2c3RUhRbE5xNUJH?= =?utf-8?B?Q3FrczdTdC9ObTZTT2ZscmxuTm5pMy9KTnI0SkFadXh4OGZaajNMRzlYZktK?= =?utf-8?B?cnlZRjE0WXdRYzM1RlhmUkF3TWh0bW9XSEkyeTA3cGFJK2h2TlBMWW1Bc1BP?= =?utf-8?B?aSsrbzl4Um9iVC9DYVg0Z2NRMzg3SWN4TFZhaEF6RHZjYnpWeXMrZ2pTYVYr?= =?utf-8?B?Vll5cnVIVjRSelFOclpCVTJBRGt3Tjh4SVpkRUFMYVlLOHNrK1F2ajVVOWR4?= =?utf-8?B?cUFjS2VtdXpYVVRsc1k1dzhaODRWRGhDQnR4V2dCWHNSZGtIZ0QwT2pwb2Ew?= =?utf-8?B?c1NrZkR4NXY0aDBJbjF1MzRSQ09SaytXa2h0RjJ4enNXaERzUUxuM05GUDNL?= =?utf-8?B?Qktub0dVUHZnU1BOQzRMNU1KOFdwZTFDQkJURG1RbVJoMHozblVQTEpKTDJW?= =?utf-8?B?SVpTdmkraE5GOHJuTFZzZlRPNzhMU3dyUlpKNk5TaVNlU2JwaHI2T2hubFpT?= =?utf-8?B?VDV4cFNQaFlMcjc0d055RUhjbDB6MW50ZjlTTGVTQXUxUjVXL2RuTjZUV3lo?= =?utf-8?B?Tllac08ybkdzYVpHVnZIUldBZUhlUlNjWmZvNW1iT2FtU21Kd2hKMnZzNTNX?= =?utf-8?B?V0dBS3RoZkZwbTlwK2YrTDFTTlNnUkc2UEFZWEp2djhuYkJ1MHZETWlNNzBO?= =?utf-8?B?N3ZQMFBDRWsrZjlIUjdTcHJMc0tVM3FIdjRjdS9uVzQxN09SM2J0UTJjWTJs?= =?utf-8?B?TUNNbndiZ3krQXQ5TGpURnBybk52bjJWMlNWUTQ2c2RyT1dZeHlka21KSzVw?= =?utf-8?B?ekp0dk5Tck5qU1BUVDRPcEJnV2Q2M1NZbk8wdEFiVUg4NmpRZjlMOHRsUGtL?= =?utf-8?B?UmNXN1gyTkh6MFZnTk92ZmF2NHUvekxZdmtDcnlKd00wRkVhMkVYdUIxVnJG?= =?utf-8?B?NXIzOCtZb2IzSzVYckNoclhKaG00VjFxRmR0bHhlKy9DcHNtemNpNXJTN3ds?= =?utf-8?B?MG9tRkhXcXVUVEluWHRFcnI0bVhHZTlqdHQzL2hXaW9CMisyQll1V2hHU1lH?= =?utf-8?B?Q25zbm9WSnlWT1FxQjVxY25oeWFiaFFDN0d1aU5RVjBOeUExOS96ZjFYU21X?= =?utf-8?B?MDMvZkQ1Szc3NFdqZlgyNWlMV1BxSjVNb3RsZlJ4ZzFEOVhPMStGZVUrYmlT?= =?utf-8?B?YVFha1NpNWdQKzRxN3kxNmthYkhxdnZidkNrK21PZXIxNUYwQ2RyR0I5QW0w?= =?utf-8?B?UkFKVFN1RXB5a0pjT0dPOFRLUjJaZ0o2NUU5NnFBQ1hoYUcwOStJY2IxSW1p?= =?utf-8?B?TjVFWDlweERLazg2UUpYZUk1aUpGOEozRUczQm01anlFTFVzMzNCZk1maXg2?= =?utf-8?B?ZW9lSFV2Wi8rT21wUlBNZGZGL29qWDBpQUcvUldxalFYbHZYYndaNVdMUUhV?= =?utf-8?B?citVRkxPZGp2TmZERTBUQ1lJZkRkZ2xyR2gxU2FzTW9taGhOUmNpVXpEYWlx?= =?utf-8?B?THVMM0ZHcDlWcnV0Y3NFd2o3aXMvQWpLL0VWMHZDS29zamd1K3ljaTYvOHAv?= =?utf-8?B?eDJSbnBvTlk0VTZNZUpjbjZVWEhWOFBZQ2k2TEVuVTQ1SU5ZVnFRa0FpM2hP?= =?utf-8?Q?e1ixoohGwMzUz/txWorEgHpIa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6eb8c84a-cb5a-4981-0d8a-08da5e90e24d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:15:59.2598 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0ewm89coPf103KvLeqfPWR6Sd37IyGQN2CNeiHVnhVCiOuOL73dhYM/gdhg4/TPQQ/4x5b+c+l/ovaAc8S+VqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3008 On 30.06.2022 10:54, Roger Pau Monne wrote: > Using nr_irqs minus nr_irqs_gsi is misleading, as GSI interrupts are > not allocated unless requested by the hardware domain, so a hardware > domain could not use any GSI (or just one for the ACPI SCI), and hence > (almost) all nr_irqs will be available for MSI(-X) usage. Looking at create_irq() I find a loop going from nr_irqs_gsi to nr_irqs. Similar in get_free_pirq(). All lower numbers aren't eligible for use by MSI/MSI-X. We can't allow the lower ones to be used for other than GSI purposes because we can't know whether any device will become enabled (perhaps long after boot) which wants to use a specific GSI. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:22:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:22:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361357.590831 (Exim 4.92) (envelope-from ) id 1o8jRS-0007EA-ME; Tue, 05 Jul 2022 14:22:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361357.590831; Tue, 05 Jul 2022 14:22:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jRS-0007E3-JE; Tue, 05 Jul 2022 14:22:18 +0000 Received: by outflank-mailman (input) for mailman id 361357; Tue, 05 Jul 2022 14:22:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jRR-0007Dx-JC for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:22:17 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dda3df0b-fc6d-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:22:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3363.eurprd04.prod.outlook.com (2603:10a6:208:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 14:22:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:22:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dda3df0b-fc6d-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A/ImTp7D3Q+ADopOx0pUDj9r7mEJ4CTX1Akuun7sRWKIP+sDe9G3sfffxw5SJCQxWRXYflTvpDl17Gv7BKK9zSpgDzzJ2j4yBXmLxaRQqTTMUU9xO2lzV+sLK4CKuK/ermNtDbZKYZ+4PFpSYOBpHSN4hzAPp0VjG2Gtjk1q7Vmq3BSPvpIMvrGi63kqJ4GSFbNYGIuW/AyMTitKLbSDhbg/OgrJoYowVFT2JprOhzVJGdyYqsiBhE6sX/HFYYC9Pkyd27z9zqSepg6FKminHrtjSdeDLqrurrw67nzcEz5dCYOA+ldLGS4Wq1++lSFHVwf7jj0vVHzWuGN9h+BeYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FDdtPKbPrMYdL9fmjw8kpdIPCiiqjZbIe+Ynkepvz7U=; b=dBKCKpaMpyeefwDBSNbSdzzy3k12la0i3g2KFlWvpwSw7h0oierNIw7bvryEOTovryyVoiLwHSNTDvU/0w0QNPIwa/ovhcMD2fH4K5/JnyeZoizdn3kHVfy3iH0uX3uyJ0AWjjOMVknwxZj2P/dbk0t2Nv1Hztc/r4/VLjHLVKms8J1gWJ6tgxObtE0gJjDkT7HBhq4h0XhrLqwdySHyHrwU9/FrQpL+kLBd2unhf0W2GVa7ELvf9Y7C6wZbgHgdnqR/msarTlqcNc+XuSNde7x/ovmZIDwz1U4qvoUDNEslBCfcwtkXC9/D+N/jw1ZDFb8hhkwlofDGGQhmXagoOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FDdtPKbPrMYdL9fmjw8kpdIPCiiqjZbIe+Ynkepvz7U=; b=WL1FiKb2LPYfsRDasmlTI6s+/pYWa5ABmAhNxikab2ed/1wlV+Ae+sPQT6jK70VR98hqWnsKTvH3uQdB18wU8L5i19pxUi6dORfymyTFj/OiDixUCpXdPIQ0L1UTgSvG2Oiga3E4I1ByFekgHCGUaSzBm6UCKYtHwUt+sxpMq9bMknBYOHXSLlDsVCxmKV5Hw0ND0PCkjl7eAMzv07NOjg9kjE1dwT2CMvZYcOgYtLHm5vK6UI8+uWLOfwsH3B8Byrxls99Dwx+ePsqQsoL4QNZwv+xbvUAlC7/m13rYphncYgUtjMT1urEtv8VqkYwCe6hoh0vBkkD6oSBCLJScrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22d3b019-7c34-5d92-ba1f-2afc88c0bd57@suse.com> Date: Tue, 5 Jul 2022 16:22:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 6/6] x86/irq: do not set nr_irqs based on nr_irqs_gsi in APIC mode Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220630085439.83193-1-roger.pau@citrix.com> <20220630085439.83193-7-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220630085439.83193-7-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0092.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cca1b381-d3ec-4191-7b10-08da5e91c0d3 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3363:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vhP4CJHxkZdezh7OkuFphakggAV7zbIHJvOYSXYR1kRcVwGYKVJqQXy6X8/Q/tUU8wSCb9UyVWfsMeTYQ/IUu5nzGGWGUyA0ynqy2PO2JIIjplD2IwGg6z2t1SGz+OSkuM3TwDOybtCQKBqMHBGpeNUGRQWizHT4KamNAe2wtGaqyVr92StRWHrhvH6S4QkJxHLCfDqg9yO0msEhXf5+SXQVBOHwChQmyIM6MxnsaulwAAsI19Hity6Hhq4k20AEcGhnI+sr5CfccGngNxNMaUMQIPxGduUvxeGpLC4MsdUg1AVLi3B9a5zPRjOl/q4r44tslzHvwbLuB/UqgyTh/wAbY2fLpGnxtsSQtSn5dTvGXPz6OS9u/86DHy4eHQuEGMRT7FLiZBK8oI0suSCekyHVBVqUIKm+/fOOe2XF5XhLUQPjM7uDU1lCboxr0/5n6dQjNptdonFJJGIWQ7FVOmSiyjhJYVOXrcXD92eK/gmqCSGn3mphv3TewF9Fh0mAFupec9lCzH/p0v+2tnhUsCNsvlDRo2jUm0IUPsVjOM0LhI2+eSTS3abaPhQ6g/LNBkWH3zBBXt1X7Hk7UIVbfSBWUTSeIDoLmnOf768XIX6zWmHAgvncZHtRn3dZ+qM5yAQ4IsUul2DTb0ecToNVu4QtSwJD+9xlPVXTIx582m4qDP5EZxj4cEOHXw1em6xfp44VAGdYYUvStI1omXnVQ/kG48OgRpyQwrCI3q6ypkdvdHR53NLQ+c4f/pui9xTpKbOisZAmzJfZDzW6owt1514PsdZn0usy0dH0ArQ5aSwAlZlkxz99S4rpzDybxLLSIhli7gKy/TTmkUV2QqOCr56RQ1tA2idBOUeBezdM2oA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39860400002)(376002)(346002)(396003)(8936002)(5660300002)(54906003)(4326008)(8676002)(66476007)(66556008)(66946007)(86362001)(41300700001)(31696002)(6916009)(316002)(4744005)(186003)(26005)(36756003)(6512007)(2616005)(6506007)(6486002)(2906002)(53546011)(38100700002)(31686004)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0ZqQ1I5clBMSjh6eklZZlZOaGZYTUp4ZnJwdytiUlQ2QW8xb2RVMkk3TkZQ?= =?utf-8?B?YTkzV2dQbjZJRGRBTWNtS2RtajV5Y3JMNzRaeUliK3kzQmwrY2FJNWk5bytN?= =?utf-8?B?cmtBTGJFMXBialQvYWVwZlplWXlTYUdISUpDbzM2OUpFY0hzYUF0dVZHMW1a?= =?utf-8?B?d2VwWUp3Nlo3Q3J2QjluZVd5TEhPYkRlRS9yU0NVUzJPdTNhRWI3b05acndw?= =?utf-8?B?V0NkY01YZ3J6M0Z4UzN5MFNUd2NvenZJcmFSdVFQQjVsZWpWN1hraHpjU05j?= =?utf-8?B?Nml3OU9QL1JmQVVNNGp2K2Z3OW1vSDVpbjZ2SG1TNHBRVGttcHlYNVg0Rm5v?= =?utf-8?B?amJ4alMyYWMvV1g0V0FVUzh4aktkR2x2STdpQTY4THBzcmc0MjBLVnlmUUpL?= =?utf-8?B?WkE0ajFjUWNiOG9BUWVrNDZ0TWhqN0c0ZUdPSlU0bjlmN091K3IvTytaZE1U?= =?utf-8?B?OWRKa2Ixa1g2RWEraFdKekFkVXc5SG8xR3hsZjQyM2dMSm9MQmZXY3lScTVk?= =?utf-8?B?UFR4NU9EWnpiTU9vRk52M3d4YXNWSml3T2tVV0sxSlh4MWhsMkxvTFZhVDho?= =?utf-8?B?dCtSeDhUQUtRUWUvdGU4UVgxYTg1ZE42Rmxuazl3VVVVK3NXWFpzRmNGeFha?= =?utf-8?B?NFV6a0hNZldIVXROMlpDd0lKZVJFYWJ0bnduMU1nYnZvOUR4RVN4VVhCREkr?= =?utf-8?B?emlWV3J0OCt1dFM5RFNLc0hzL2ZIeDU0WUJKVTA4a2tlZ3ZGTDBVQXZsRGlU?= =?utf-8?B?SjBZeGpidmVVVCtiZVQwK0Y3TE05Mit3VjVreVRtZjRNTWRsa2RldklUVHY4?= =?utf-8?B?c3pDdFMvcXhMelVaOW1xblloRlpnUDN5NEJuQi94eThXVDZxWTZmaEc2VGh2?= =?utf-8?B?NGRJWFhxNFQ3REIrUTZsUG9INzNSNVYvN0hSWllPU1JsbVhGM25oYWk1R3dE?= =?utf-8?B?WjV2d0c1MXRZWHFaWmJKckxNbG93V0N4UFRWbWM4MHkyZ2N3NUNRU1Vob3ZU?= =?utf-8?B?WDU3OG9BRWhyV1FGM0ZZeTIyQjQ2S0lHT0UyemVjMlRmVjJLcCtGOFVIMkFy?= =?utf-8?B?MzQ2ZUMza1BDbUhOVENnOU83Wm9hQ2x5QjcyaERUYjR6ZE9ZcE9VdVYrY0Jv?= =?utf-8?B?QTlnNzhDa2ZYK1FrTThqMmNRSVBFMitrbHZ1WkZTMGZ6YjQ0YzFxekljMWJh?= =?utf-8?B?ZUFpN0tBNngvUmZOMWo0eC9nNjIxMWRZTThsZ0hyTm5iL0hrc1JyTkw3ZGtE?= =?utf-8?B?TEV2VVluTmd3TDNIWDZFc3QwVzRaL1p5Y0krd1RwbkU2S1BBZnJTeTRHc005?= =?utf-8?B?YzRFT3g5bEx4ZXVIaDIzaXdobWZOVWxBNDdLWngxNjhlVzY2OVhKeENxR0tT?= =?utf-8?B?SzVLbG9sMnl1YWErL2tEV0xVMmNtUzR3MDRrZFVGM2cwcjhxVnlOTUFnYWNY?= =?utf-8?B?VmNraDYzS1NYWkJuN24wRmo4RlNoU3VxcDFySUhnR2tQVUx0dXY0b2wyUDZC?= =?utf-8?B?RStRVWtLQ2dMR25uamNYM2E3UnFyQjBPUHpYOXRZT0JINTdtaHh1cTE3M3Fu?= =?utf-8?B?SWg2aFV0dHhldEszcWlJSDBUaEhmZHZNZXFNalNVcC9mUTBmMDNuSFJUWHlT?= =?utf-8?B?VklVZndsQnZCS3Qyd1BzMlFSdmRNL29QZnlJa0NkZ3BCZEJFZ21pc0c1NXM0?= =?utf-8?B?V0RCNTdqcFpkWUI5U05kMFdYcG9jVVdQdXNjb1N4TjloclpiemZPaVNPUTNl?= =?utf-8?B?Vksvb2MwdFZVdEZ0cVVTZHhzSlprTDVFNUZ4dzlMVHNkalR2dHV4SmtOTkp5?= =?utf-8?B?bHg2WFd0SHZmNFRFZGFuTEpLemYrdFoyRzluaFFCUW1MeHUrQlJTajIrdVFS?= =?utf-8?B?UTJnUlRGN1VOM2xyR3ZTaEFQRS9qRWFBc0FOS0x5VS9DcFBzRjRRNU1BL2xl?= =?utf-8?B?V1E4dXIyTzY1OGhRVHBYN1FFWFVjQ2doSWZoV1JIS0JSZ3l4d295MTZnVER0?= =?utf-8?B?RzRCZTh0V2xrTUZ6Ujl1U1N6UGN1ZDVjTDlsWEJmTll4aGljZVJjdlEvdXcw?= =?utf-8?B?alF0REFQN01VMEpDZXpWOFdIcGJNUncxeW9YTjQ4RXAzZVlCbFNiMmtvUUx1?= =?utf-8?Q?myadJ0E8eM6Mhp+ZUthi9SXN/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cca1b381-d3ec-4191-7b10-08da5e91c0d3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:22:12.5637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +i1FtfX0imNpO8NacRgMkzClwR46r9fyeOA2223TABY0veiBjQ/kcL2/jy8iEvJLsA7HJ8lzjbBhmIxJm47/kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3363 On 30.06.2022 10:54, Roger Pau Monne wrote: > When using an APIC do not set nr_irqs based on a factor of nr_irqs_gsi > (currently x8), and instead do so exclusively based on the amount of > available vectors on the system. > > There's no point in setting nr_irqs to a value higher than the > available set of vectors, as vector allocation will fail anyway. Only if in the earlier calculation you include hotplug CPUs. > --- a/xen/arch/x86/irq.c > +++ b/xen/arch/x86/irq.c > @@ -426,8 +426,7 @@ int __init init_irq_data(void) > (x2apic_enabled && !x2apic_phys) ? x2apic_max_cluster_id + 1 > : num_present_cpus(); > > - nr_irqs = cpu_has_apic ? max(vec_spaces * NR_DYNAMIC_VECTORS, > - 8 * nr_irqs_gsi) > + nr_irqs = cpu_has_apic ? vec_spaces * NR_DYNAMIC_VECTORS > : nr_irqs_gsi; I wonder how useful it is to retain the !cpu_has_apic case here. I don't have much hope for Xen to work properly if APIC use was suppressed, and I'm unaware of x86-64 CPUs without APIC. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361369.590841 (Exim 4.92) (envelope-from ) id 1o8jll-0001To-Hi; Tue, 05 Jul 2022 14:43:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361369.590841; Tue, 05 Jul 2022 14:43:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jll-0001Th-Ed; Tue, 05 Jul 2022 14:43:17 +0000 Received: by outflank-mailman (input) for mailman id 361369; Tue, 05 Jul 2022 14:43:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jlk-0001Tb-9z for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:43:16 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ccfb711b-fc70-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:43:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2679.eurprd04.prod.outlook.com (2603:10a6:4:37::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 14:43:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:43:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ccfb711b-fc70-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aT+7HhVuN/Xz/HIiTazpDcHfZi9UFl3EM3GhboQfeDGiOKLGa0AC2EO5/Zz9AZQ4L+A/1JrNzj8drDhGE2Ch0Wd9EMJJwuoQpvPfb0Lau4gqfDrv7gzfZ1rvQcvLDHAc+5rcotk4c4SF8tLC5puwELyrk3Lkhlg7vChnMzSuZ4ifor5GFX+aVOaw2J9NDzEB5rafXnmWkIDe0Gnf7b8MCyIZDFvksAmhmoWQq8/6BBIccdM+ZpfwAL3+LwtcXiuLEDPsk9NHyTusvODHYv5OPwkEp+U+TYszdTP5jUTxsPeAMzJfoXEipbe+BCzGCkSeHUYcaVrp0qjNXrjd8sdKhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pHav9Rzph42TTthl8M1E87db8TxT+IIpSGpqcppw/h0=; b=dEgpqXV3LbbI+h+loyd3V4OXnZv6JDtQqFjVd4we8U6eseLfMe3jG5vy057QyejKTIsZsuG0jpkuhdma29KKHp/GxR29UAURpurBD6ZUIRfXbUzyHSfc/U93XujT1VecZ2e0JDVW3KdZEPHFgBatK7dBGgpxtbGBL1cTVebb28rSq4avzE6awV/eblfp2wcD/h1mqhsTTwy24Za6jsB3bGrtHAA2rhPxVcaraR0qLyDUL4MN0apThHiOY0SmMHGAzDBC2xMDiF9ujMVVYYtqgUYPj/VYl2WfFyueLg72dmoaLn4QrcpYaoftno6rNJL6tYLCK/Fm1NPGGvtwAyygcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pHav9Rzph42TTthl8M1E87db8TxT+IIpSGpqcppw/h0=; b=oqMW0OwhGSOWe+ufCLiTLZalXuSxM9WmANAvv2vi5Oc9sG9SSZCEOUpuwnGCwENKJs6KdqTH1OEp4XaRHSXLIM7uK1js/kxwsN87Vj39VjRJOJfmHzepGMjAQ/x36slj176x3PdMIMIUmJe7veRyUYgFSB08mHUFoOTOc8Lk24xcKDidPvKza0kE9T1tjQ8Ss8juZq+838QP7VA5WcA2jxTsr6/WH8OJ/EM1190id3B1tB2a7V/oL0uvyLNgjCrp1Z6w+SNNuZVYQwgrBbJsRxMsFV4RzCRi/gzICVZ6r7VaSQA8TpdHkmIf9bP5Xo02chixC9Yrdz9kZlrqvF1o0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9a581989-074d-fb31-5bc2-81fd4366cd68@suse.com> Date: Tue, 5 Jul 2022 16:43:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH RFC 5/6] amd/iommu: atomically update remapping entries when possible Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , xen-devel@lists.xenproject.org References: <20220421132114.35118-1-roger.pau@citrix.com> <20220421132114.35118-6-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220421132114.35118-6-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0021.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 720054c4-17c9-4c99-acf5-08da5e94b00e X-MS-TrafficTypeDiagnostic: DB6PR0401MB2679:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oWpeUrR4WNrmmARVYTQbyCd7tLypdkUEUYuRjOualfx7RZi7k8II17HKXtbSB4T6uelouT6CRy0Pks2z5tYAyevzEmx3G/VR4LpymYqlghXAOOqiDdfbiGF5DP5wiLQqurJMVqVHbI10t1sNol/9fvAxTZqZwzVWaAk2JsZwOUsTSmkJS2MQENBKO5FP7SysVb4WeBNpD/J+YTHTt1G8gOdCzPAywRMJXY96pesJ7Ek3qD0Qqlt+p5zW38F3+QSg8nNL+Kn6O03kWslHmlHilPEaytxTciGkFZRN4HabQs7xX1+/rI4DzhHIKnJgMuO4r13auXXf2e7EesQGVoSEg9Fm9t7r0CkpVzwW8EDsNrUl7tnE40Evk0ohsd2uqIAIBE+oZYYd/KbRsvwYsWsMPxo51WbZ7Ps2I7WocEOCusBMw0v4eqfg1L2w8QUwXc3n2g+kOibQrIva83eAjWi8FLt8JgSlFSiAn4oc9+j/a9/Fuf0bStXS+p1WUjxmf+lYcxG+rDY8nTbggn4FE24BITG8ahG1B64a5GNhu4i5azjH2bWA99QVPu4kBKJevzb6SHNlqnIxvQZUsZ+6g4/B8s8yiOVWXWM2VyKFLXqmydG59oVg35k0YuI8gYQOhTuE6pDC5pfnXSvC1Exr2Acgx32vd5g34ETpYe1JrMGNHqHOGmfWOJoRrhrTnqqd7D8UnCyaNNwgUO5g829wTVsN1M8MdX8XKbyQnVnolmyCUAG8MQUBOsMHOMZzCNo0ofuVT+h/UnSyVDDLK74sZWN3S/UxfZzuHiSaiVmjYWtNt7dQCQ5iUJqR1xbnfqacMNYSBP74/soVWKiNyDZhzfPNR2R3BWWpfu4Ex+eBAZbsm3w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(396003)(376002)(346002)(136003)(6916009)(86362001)(31696002)(4326008)(15650500001)(5660300002)(8936002)(38100700002)(316002)(8676002)(66476007)(66946007)(66556008)(2906002)(6506007)(36756003)(83380400001)(31686004)(53546011)(26005)(186003)(6512007)(41300700001)(2616005)(6486002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SFR2NTVraTVnT0VFcU9QRkdoSlYzRHlFcjZhSHRXZzBZY1Fudmo5N2dXbVdu?= =?utf-8?B?QUNTK3NGK2JycXZla09QcDZpcUhiN20yN3MrWG4wVzNHcFNNMHFQSnMrOEM0?= =?utf-8?B?N2h5WnNkWFBYUithamM2SmFFbkMwckQ3SjJyb3p2b3FCeWo4YWJnZTgrNGhn?= =?utf-8?B?NXBNSkUzeU1IdjBZOCswZ0krV2NWaHRhUTM2NS82ci9iWmEvam52bUIyQXp0?= =?utf-8?B?alJ2aW1nWTNWMERLOFgvRkM4M3hsWDBzUk9hWGp1QzRiRTVRbGNqY0xJbTd2?= =?utf-8?B?TzRsSHhtV2hFRnhGR1RRWVlTc0JnazlkZlBZNnljcW80UGFxWTR2MTVBb0tE?= =?utf-8?B?UWR5KzNDaUlCUDU3S2E5WWFXKzQ1QmU0WERUM2dQVHBqMy85dUtUc0s2Z05v?= =?utf-8?B?RzIxMHovM0ozSHgwUFl0SXQ1UXFsb3krNVkzcjJ5WFhNVkt6UWoxLy9UeTNi?= =?utf-8?B?SXZaMlpjUnpRd2VjaEFBYXFZampyaTRjc1B6R1hpUTFBbE1LSHVaZVlzaDh6?= =?utf-8?B?NUpjcFZBemdpNmwwcm9KTGtDNHVZc1dLR2FsZUYzL2NOWXU3bTdmTlNEMFM5?= =?utf-8?B?RVAva0t1Rk0ra3I1a2h4dHlybVRBeTNDMUZKU3ZHSmpkSkhqMTVpK1ZWT1Fs?= =?utf-8?B?TzBRS0t0NXI2MjFpNUZCcitVeVJNVEVsMXZuRExGQVZzOXlER2ZLWVVtbW1R?= =?utf-8?B?SVNRbVZwV01LMi9sendhYVMvcnE1dmtjSWRMTWVIZExCdXllRDFTcnZTTmtO?= =?utf-8?B?MlFjWVVJSm56UEo1QXpVVUhtdFN3Q3o0OTVwbzhjTDlldGhocXJvTXpJa2FZ?= =?utf-8?B?VVpWS3I5QnpWbENSWTF0WVN0UW5YMXQ3SjBoTWV6MytxL0tQRU80U1lFWjBs?= =?utf-8?B?SXdnNTVmdkhxaUpYQlF6TTZjK29RWjRLOUhTZHhjakowZHg5a20zdUdHdW1J?= =?utf-8?B?U0p6TGthN0lZNVhvZlBBazMrUnBUREZZSDBEUGl2OG9oVkRTMGFuZ2J4Q1hr?= =?utf-8?B?YWxIc3l5ZTdIakl6d2xvS3lmaXJHS2FuYXBPYlczREdLd1BhdEpEZXRHTDZJ?= =?utf-8?B?VXFTY3BTNWtvdzdlR0NZUHlrVnBSbU9CYUN6a0RnMHdZQzdkSkdZTzhGV1NW?= =?utf-8?B?dUJjdDl3aTZ3YlUzRmZ5WWZ2aUk4L1NqNUlqWlVTd3EyaVVramtaMXVieGxn?= =?utf-8?B?ZkxkaHg5bHkzY3Rla0cwcUVFcldQTElVUWM5TWd6RGM0ZkhhcWNINXVjcGI2?= =?utf-8?B?blJhRDJUL3NvR3NZaGdzMkRKbEUvTFg3a2FkK1BFWlhlYWNjWS9Zc0VmUjNr?= =?utf-8?B?REFuTDNBUFNMOXdES1I4Um5LQlBhUVJpY2FiRTRsZWJHV2lWL2VoYnhpZTlU?= =?utf-8?B?K2FEWUlUOWVTcEZHUjlJek14aG1aUEJQNGtJZkpoUjBiUlpuRzZJUjk5d1N1?= =?utf-8?B?TWpRYkxqd3BWMXFQWFV4RlIwd0drNWw0bUtxcmRLL0J1NUMvUVZsMDRPVWMy?= =?utf-8?B?bVVSZGxwQU40QVJWOUxPNVI5aTE2SjVNTmZSeEZSd29KeVVodmtPRnFWSEF1?= =?utf-8?B?NVQ1SitINmtVeUFBbUJzbWJPTFZVcDQ2enBnVjdMRWJuVHhvV3EvTmtyLytE?= =?utf-8?B?ZHE0Si9rMVVzQXBmUThaanlKUGxRLzFkVjYybUp0bmYyRndKZEgxdk9VdjhX?= =?utf-8?B?NDhTditiQ1dBN0RROXJ2cnJ1QkVGcjBFa2lsQWo2d015VmVWdVJXUUFGUjRO?= =?utf-8?B?T3owOFhxWnVTNFN6VUZvMm5mWDNKSStaU1lDTndsNEtxYjYvZGJLYWVYMGxN?= =?utf-8?B?TDJTUFJUSHJTSzlFNWtxOHZjME9HRjVhN09BblRRR0Fncm1ScnJ6OUlmQmxX?= =?utf-8?B?YmIxU01iLzRISFhRMElURTF0bjVPdGJoNk1aUDB5Q3k0dUtCS3RiK2VZVTVQ?= =?utf-8?B?ZE45Z3o2d1EzeFJxOGlEWmVhQ0dJSE9FUXMrQ1d1VEdLSkVZdytBODR0V3NU?= =?utf-8?B?UkJIaXZzK0w1bHJhYXJQZ0YzUW91bS84bTVFMEtVV1FRUktzSlNpZkFjM3dR?= =?utf-8?B?TzJnN0xzcUt2eU9Ca0N2L0ZSMXJJQk9GSTdDY21sUUdCdzV3c3VzUmFtWmty?= =?utf-8?Q?RRKNpDijJab0gV/HamPT6n3IZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 720054c4-17c9-4c99-acf5-08da5e94b00e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:43:12.9675 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wecfie/ruYVWGu4d7crLS26RUlB/GQVhZIMRvfR4vE5Xqz4bBU8t/eU3yqq0zXDR0+MU2iiKQrDSRrsrv2nyXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2679 On 21.04.2022 15:21, Roger Pau Monne wrote: > @@ -366,8 +383,11 @@ void cf_check amd_iommu_ioapic_update_ire( > fresh = true; > } > > - /* mask the interrupt while we change the intremap table */ > - if ( !saved_mask ) > + /* > + * Mask the interrupt while we change the intremap table if it can't be > + * done atomically. > + */ > + if ( !saved_mask && !cpu_has_cx16 && iommu->ctrl.ga_en ) > { > old_rte.mask = 1; > __ioapic_write_entry(apic, pin, true, old_rte); > @@ -383,6 +403,11 @@ void cf_check amd_iommu_ioapic_update_ire( > /* Keep the entry masked. */ > printk(XENLOG_ERR "Remapping IO-APIC %#x pin %u failed (%d)\n", > IO_APIC_ID(apic), pin, rc); > + if ( !saved_mask && (cpu_has_cx16 || !iommu->ctrl.ga_en) ) > + { > + old_rte.mask = 1; > + __ioapic_write_entry(apic, pin, true, old_rte); > + } > return; > } Iirc you have a question about this (wrt differing VT-d behavior) elsewhere. I'm not convinced of this masking. I could see it as a measure to prevent damage if an update was done partially, but I don't see such being possible here. Hence to me it would look more logical if the entry was simply left as is, leaving it to the caller to correctly deal with the failure. But of course that would first require telling the caller about the failure ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:51:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:51:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361377.590853 (Exim 4.92) (envelope-from ) id 1o8jtM-00036b-G2; Tue, 05 Jul 2022 14:51:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361377.590853; Tue, 05 Jul 2022 14:51:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jtM-00036U-C3; Tue, 05 Jul 2022 14:51:08 +0000 Received: by outflank-mailman (input) for mailman id 361377; Tue, 05 Jul 2022 14:51:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jtL-00036O-BB for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:51:07 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50065.outbound.protection.outlook.com [40.107.5.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e5dd3c8e-fc71-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:51:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4164.eurprd04.prod.outlook.com (2603:10a6:208:66::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 14:51:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:51:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5dd3c8e-fc71-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KsnaaJEG3rmlFStHgX4Sz8bNLpYUwASbSl+8lyD9eWhIFb85oEs+O9xdwC+RZ1qGoFFqyDONi6dkOBr0T4g0JiDAyImqiNRZhd7V+jw0+CJM5ymewscijPLCbuN/R6HSyBYha3iA1Yc8LOMxJr5Q+7bRM7Ek2UeUVf27Sx8PvgoaG2LsulRRUdvPSL+vV/OVIZq5cshUGGZTJANbLsP7mphUJNSpBryPsixOVVtQOp8Tzk/BejusnbU4jGfbCG3zAw2PpV2plfd6akmsS6zBWkzl/+viJnqjUC09lyVTagG/yp53LZrcYTXqQRxZ6MskJB2IdmtkHOcr8joi5AMzLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jZS310zd5Sxoxe73YQR1oFSKnO/oqUHJOhszMvxk7Pg=; b=fuMjxjABFLUmRx4Z0Kb5OKHWMSVnUtnBTlmyEOFwzh6bse6kSJZXgXSciespFAkEhCvTLsTqm4fOuHlRIYJvd6ThPPoUvPFuqePkIbB8L8+QXZbaMHnXnsm1L9/hR9SoDJpwbDjENlZ5UD1Cpfx0TNV167+zFf52UpEbK1My/XOaWHb0CQOdelTwndJYuge2AGtvnzzLu36j6VdW7Bgu+mJcrjdBUA53/42MGskMad9K9fMRRpJUeRJbpDBiG6rz+seFJY7b9zk9ea7TXg3MxB2ClokVb0d8oDigYZfDnill9Oy0FyummrMYHrUAQ2086EGX24fUxRXvv8AxUXg3Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jZS310zd5Sxoxe73YQR1oFSKnO/oqUHJOhszMvxk7Pg=; b=uaDTheQ0xbn0wghELx9TuDtIoNSz+6/QK70iBa8lJkGrAaXJEQi5VAEhqdLLrgKRJlQ2RaGAGggZF0MXgui8d5k/MKe5qTOGx+XxF+2ssEM2iBffmM/pUbwO5+abE2vUeOmAre2zJ4BXmrcWNocs2DGQRKQlRxgp46RQ1pTajcoFyxGZy0eOPykT8W8RprJ25/yBIgBVisC7WMm/0ZPaSELvMT+5fQ2R9r1hrY83hVDWMpJTWDBn0NXcBbgVbq2TDI9FQqveDk49jeSDQQZrRijQChaSPFtmJS+5KtkIGks5GSX96DORyzY0rXeiTjp8F1cm/BF+DhlOSYI6jwGdjQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0686490f-db40-2df6-e1a3-2c04918f8d1c@suse.com> Date: Tue, 5 Jul 2022 16:51:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH RFC 6/6] x86/ioapic: mask entry while updating Content-Language: en-US To: Roger Pau Monne Cc: Andrew Cooper , Wei Liu , xen-devel@lists.xenproject.org References: <20220421132114.35118-1-roger.pau@citrix.com> <20220421132114.35118-7-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220421132114.35118-7-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6850f5f7-7aaf-48bb-a261-08da5e95c860 X-MS-TrafficTypeDiagnostic: AM0PR04MB4164:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +m91HC4PPGes7v2unV/UE6NleIcmJHejVzhjeb7VWLmx9Gv3hIQBWocVtoNuaF6bwH/PmrmFet2T+7JDkNtw0OJ9ufjUukp0fBwqi/KiTK811Q59bjEEyXOsdGnF70KJ6dBXNn4ICi5jsnXeTFRYHmbv8u+82XFiyW9JpJOMtLT/mXGCdov4Oak+9Rf1L2axhmVbNBsCAVe0tBFHiJKVTAlGlNmeydmVW65jTaQzJZTr4cn9qgOGfjtbhFZTWjkYj6iuXfYxgfjWSxVnlS5Gey4Zvpsg0+slCy6Ogagf9Ag/ff631bH0m+uJ+qbKD5pyIzATW4fCYIEu5G5esvKp1XOfwnHsg7MbzfN1CqJQoF7L6dCjj3uaHEvc/HmmgPk+PB6//5fRZnN2yaZr0293c5ycsr+UFFkAKj5L85CsPp7bETM6NG9exhG7pULJUSmMfyztxlu6GUvX9YpXyuIUkPngDQ0wS6ZsyxjVwQI9RmhV/PJKfEtp/L+iUutoV5rPQKE+OBoVBMrEi1vZ0bgAkaNzSQdG2fPaycAAJCaiJtf46tsCXS2lPjiBpNdE4Fz951JoM5X9UiKu6poxwtBz2dCa8uSajTR/E4a/XT5b58lUyjc3azOkLrqQcUmigCc1K9l5/a7eYYyUkMT9mPP6aALxNQ9bP2trLVCkRiTL/bXPCiynC68NaEPKtKBHefuEZU9JNJXBfcy7AWCaGsuUWqvdYeI5NC+TD3fKzzkbxPJTWe+0LHforJrPGfOpK9gAUxaOlMy9CdgKB4I7vKX1MU2VtVU88pjykfK9fcE8Bsx9JZ3X1WrJrwDKiF6ZL92JrRezF5M9vrHxF5U/cfV3V3ps5zb3CDl0se4Ni6QW0xY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(376002)(346002)(366004)(26005)(6512007)(6486002)(4326008)(86362001)(2616005)(66476007)(8676002)(66556008)(478600001)(66946007)(2906002)(31696002)(8936002)(83380400001)(41300700001)(316002)(5660300002)(54906003)(6916009)(186003)(6506007)(38100700002)(36756003)(31686004)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEdMQ2VxZVY1Vkw4eXdpTkVjZjBXakpVYzJPRWw3ZnE0R1RzY0FmenlrczFZ?= =?utf-8?B?aERXTlI1UjJqb0ZHWjB5b2hVVVdxYzJKdE1XR1VocWJEVVBzRlI3YWYyZjhF?= =?utf-8?B?UGdlKzFBSWh3RHRrd1c5QTMrMmd2U3VpMENJdjh3QTBYa2R5cmtUbTI0ajA1?= =?utf-8?B?L2pFd25hMlVHeXRPRGRSOTg2TVpkcE9URWhlaGVSNUxSbGRGbDh5Y05nYVZ1?= =?utf-8?B?R3NVZ1ZSZzNIYW1qUVZDZEx4aWRjcHd5c2VndnhCWnF6YjRSV2FOSDg1d3h3?= =?utf-8?B?dGZsQUxhbUw4T3dncTdZRi9pQUpCNTlwckxNdmJUUzQ1b21kWnlVWnFmNTdt?= =?utf-8?B?YUhwYzNSYlNRdk9TZkxFNFNBT1ZQM1pIaVdwSE1LcnRGS0V2UGE3SnU1eGM1?= =?utf-8?B?ZXE0Yk4yMnorcUdYMFBuVlF0ZURoSmlGdU5HQ0dhVkJpRHVrUE96RkVlZHVH?= =?utf-8?B?cllkVHU3dENFdjZXMEZ4SkVJVFo1TS8yU2NIMStYbCtGcW1qbjNxSUY2MkVm?= =?utf-8?B?cHBzZk9qMFZrUDdwczdJM0U3N2dENkVET1I5UTBSbDJGcUZYQkxCWmh0bmNC?= =?utf-8?B?OTg0cnlERWVkcndSa0R1dzVtd2hadDBtR280VGxHSWtaeWFQb2QrU1l5UjhI?= =?utf-8?B?bVh6dk8zODFEZ1RTSTdveW1zRU5zL2tMTXU3ZHVFeWUvbFdtL2NhU3FRclFm?= =?utf-8?B?VElyZzVYRlJLUGIxTURhZlBMREdpNGZmNmQ3cWFjOUtBeXpnZFlmeDlTTjVh?= =?utf-8?B?dHdKOFhscFFzUUkxNWNBUndUOUNxUE02ZmtwWGd6Ly81TTVGVHhlNWpsUEJh?= =?utf-8?B?dS9zYStVYVEyMXhkTmUwMDNDRmdLVU80M3orZ2pzWEZZdnhlRDVjVmJqTWhY?= =?utf-8?B?OVo2N2JTbGM5OThBQnE5amVCY2FYa0dWZmhmRHRBeWE3ajFjTHBGa1FFMVFt?= =?utf-8?B?NUZ2K3VNRmhFL2dmMGtwRHA4ZllmdXYreWR4NXQzV0pxT0NkeEwwakVqb2dn?= =?utf-8?B?S29sejBCdDdneDQ1UDgrVlVGNlVodk5aUkJ0a0cvVSsrRmlIQk5veEdEcXll?= =?utf-8?B?NHBUZjhwMi9iR3Jsa2VjSEs0TDlUZCtqMURiODIrTWZBclF4akFyWTlBRnhr?= =?utf-8?B?bkRBaGROc0Zvc3UzZ2gxbUlyQ1dYRy91YjA3UkFyZXVWdk5vcTcxS2NzdG44?= =?utf-8?B?eSt3L1orVlVhZFNVTXFyN1BpbkxONldWRGF5YVZUZXZRTU5HNkZHNmJ2ZUdV?= =?utf-8?B?aFpvdVVRWkt3a2tkVElZMWhPT1ZhNU50WitUR3dBUElIWVFTTGJOYzhYRmtH?= =?utf-8?B?WEs3YjNTN3NJZmFmWUJnYXNSMUZJSUtBajJaeDB5TjlIN2dKdjUycndmN0s5?= =?utf-8?B?ajZ1RUVVRkhGQ1NucWNtb3dEckNXdFg1VUV1WWtZT1RFTm43cFNLK3JGZklz?= =?utf-8?B?UVlvNDN3eTlJcTBOVWdGcEdGbDJDbkVYRS9tMjJJMkNmc1dlNitsWWZOM1lm?= =?utf-8?B?WlFuOEplc2JUV0hZMHFPY2ZtRWJXbHdwbXFCZzFkQnFRaTh0RWE4V2dMNHQr?= =?utf-8?B?K2lxMnlPb2sxeDVwK1JIUkdnQnNCSTUzbm02ZnZBQkFxTmN6SjFWMHEwQ2Vw?= =?utf-8?B?cmljT0VlTEdJK3NHb21XNlB4NitlUkxWUzlTT2lPNDdMVTJTamp0ZmNZbU9x?= =?utf-8?B?Nkw0OTl0anl0MEx6VTFwdUtEZ1cxUW9WZHQzUVgrM0xHZ2VvMzk3bHpmQVJH?= =?utf-8?B?U2VlaGUzRm01R3RkMUxRakY2bzdFQnBRTVR4Z2NRb1VJYVg5T3REVjFibUda?= =?utf-8?B?NnQ2bmJWOFpHb29XR1ZNbDhlMnQ4V0kvWmw3alBqMWxDeE5yRTlYVytHVGhi?= =?utf-8?B?a1BNbzJSVWFHQkRIZEs3VWFHZGkwVFZqZ0J1ZzJadUttZ2tydTZiMHp3b1lS?= =?utf-8?B?TFZIdmZLeEVIL2VaVjROdGk5SS9XbVE1REl4cW16bUI3c3RpYUlqai9QYUdi?= =?utf-8?B?cFlGVW9GaGJJT2Q2VytlK3k2dExuTngvUGRSZWlPSjZkenEzNHlodzYzVEkr?= =?utf-8?B?ZkY0N2d2SVdVZGJiVm9VcUdXZ1orYk5sSG5YcnBXb040K0JONjlCMWUxQmFG?= =?utf-8?Q?MXAGMl8n/ayJYuD5YvOCQsdfj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6850f5f7-7aaf-48bb-a261-08da5e95c860 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:51:03.2198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qZxuHbLlEn1CvkI6hg+PgKd6RzxiJWE0h/BIj0aKjhtuIyLEBTEdf5QZ8KtU6K3vJxMVmIls08u2IUW3pyVrVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4164 On 21.04.2022 15:21, Roger Pau Monne wrote: > --- a/xen/arch/x86/io_apic.c > +++ b/xen/arch/x86/io_apic.c > @@ -267,12 +267,47 @@ void __ioapic_write_entry( > unsigned int apic, unsigned int pin, bool raw, > struct IO_APIC_route_entry e) > { > - union entry_union eu = { .entry = e }; > - > if ( raw || !iommu_intremap ) > { > - __io_apic_write(apic, 0x11 + 2 * pin, eu.w2); > - __io_apic_write(apic, 0x10 + 2 * pin, eu.w1); > + union entry_union eu = { .entry = e }; > + union entry_union curr = { > + .entry = __ioapic_read_entry(apic, pin, true), > + }; > + bool masked = true; > + > + if ( curr.entry.mask ) > + { > + /* > + * If pin is currently masked we can update the high part first > + * without worrying about the RTE being in an inconsistent state. > + */ > + if ( curr.w2 != eu.w2 ) > + __io_apic_write(apic, 0x11 + 2 * pin, eu.w2); > + if ( curr.w1 != eu.w1 ) > + __io_apic_write(apic, 0x10 + 2 * pin, eu.w1); > + return; > + } > + > + if ( curr.w1 != eu.w1 && curr.w2 != eu.w2 && !eu.entry.mask ) > + { > + /* > + * If updating both halves mask the entry while updating so > + * interrupts are not injected with an inconsistent RTE. > + */ > + eu.entry.mask = 1; > + masked = false; > + } > + > + if ( curr.w1 != eu.w1 ) > + __io_apic_write(apic, 0x10 + 2 * pin, eu.w1); > + if ( curr.w2 != eu.w2 ) > + __io_apic_write(apic, 0x11 + 2 * pin, eu.w2); > + > + if ( !masked ) > + { > + eu.entry.mask = 0; > + __io_apic_write(apic, 0x10 + 2 * pin, eu.w1); > + } For the write avoidance don't you want to hide differences in the r/o delivery_status field, e.g. by setting curr's to eu's after having read curr? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 14:56:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 14:56:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361383.590864 (Exim 4.92) (envelope-from ) id 1o8jyc-0003lj-2t; Tue, 05 Jul 2022 14:56:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361383.590864; Tue, 05 Jul 2022 14:56:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jyb-0003lc-W2; Tue, 05 Jul 2022 14:56:33 +0000 Received: by outflank-mailman (input) for mailman id 361383; Tue, 05 Jul 2022 14:56:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8jyb-0003lW-92 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 14:56:33 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20085.outbound.protection.outlook.com [40.107.2.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7f12518-fc72-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 16:56:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5331.eurprd04.prod.outlook.com (2603:10a6:208:65::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 14:56:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 14:56:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7f12518-fc72-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J0L/OOKo7Icn2BhWfz9Xq5Zuvlc3MOqjeZ+rUiAZ6i4BCRSXkZFwWVWPB2AQx+3EqoTXgwYH79CdQ2iEkVKlvtq+nun9wsr0M7WGyZ6W9nwRF358tVZ5Q5Yy1PL3O4vnfj05krRhFrS+Spe9ntLB8KNwRnQasOrMogUHnteIRxaOjm2nSaCVQ+/KumCQzfDOadM9qkle8bCsA+3ovcB8ynkMYxumWB4sJ4I/bOgH35SNeyTtnaYEAqCaRoqIf+IYbpG5UqyOtMdC1aAsjxksvvu2rGCxQzEx7zPhbOtGby8e0o0lK6vLIGEEk3kGYBQ3LvJjbGAGP0LGCaRhGdW/hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OhJ0XtDk3rChFR5ysA3+pv5k3UeXi2g5eZiEsHNwlSA=; b=CdawieJjtECmiFoQ7ZFngqbyNv5hVy2Tx4gX5UmKx8Y3ah2fSJJlSvd0ietxsyguIbfuecdtMShjz/z+AIAQT0z8jkfh78v+zXNFsj/v6lkQhHv3kkmYzGbMTgEoQPBsJ/07rDLG3Ep/diEE596E6AJGsY2YyS6JDp9RFf9Xsi8UX2NsA99nbUshg/fXOa/6GooHVyQM/z0CVNfdmIREOiZaDdb7rl2w9oKkaoWY1tkI8RN0XICfzZX2bXZ7Eu6Va7piSUpXZoulNCgjM6LiRIZA4WN323vq918HxCq2eNRGUqtKzbQKkbwFZR8Quht5HXXn1tPiccxvBQAbu8hqpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OhJ0XtDk3rChFR5ysA3+pv5k3UeXi2g5eZiEsHNwlSA=; b=uJ/Du0Xc0p2UD75Nsdt5wE4hBvec4dwQR28WMC0HaoNSTLBXVwJTKjylUYwUbf/63evLw3uy1gEAXD7lHyMwgCTnIBUxKhgo7PEm/XDlx2pi60t+MhZzxY0RSLR6+2k90NFC/m+sK0ecCtdOYWmC6vkNOBrN6mE53ba25Akw6jGPJZmvs2bCc6mRjPpv2JsmVIDRHuM3PEBWpfQgbMXgwiT1QHnrF88JkOa73XVZ4GfZg9Qv1E4IyjIq7XHOJsGvP6Jv/+bmC0tytvjGFN/k72dR70mHYhDtl30VqxtjXOROCrlq0/tBBHWKVn8a8rpk3L/r1FlfXbjcgLxAynzDEA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 16:56:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/8] xen/evtchn: make evtchn_bind_interdomain global Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 28f947cf-2989-40d3-a21f-08da5e968b45 X-MS-TrafficTypeDiagnostic: AM0PR04MB5331:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VS8zsRdb8oed7nzhwiZaBwtNKZBsbdFsfy7/K+60BdhmHZmLbpQ/QLSk9d4e7nS3HLn+3fYCetXJ6CGeCsDbJIo6JcSugzzIAI1VWP45FzIbmXHKgi6lwePi9453oZG9pLU8vYNqgmcZwdKzAQlU4WBm3y9BM18jGSb3HoWHpPnyujh37JSNznYdVT/lyehi49A2Iq1rzMEdRUbNoNhpWGMcq78VLHovGJJM0XGabz7BASnhYYhAjf16ylA/bNBGbFVGQtflYcLZ+GN/TDxddxWv/RmW6FQzccewIZdCcoxkImWBA2NSTwo+JI3rsHbu+qYTvgRy/2OsctvvtR6HeVgsAWjtcfeOGTyZ3wAyQ8A/WzRp31vOaB5YTdZzp8ZzM0n7OnJNW6VonpuvQX2ZEsOPaTCFEnqz38LrYq8lHhRWfvaL13KIi51iEKm+cKJJ0g+jmczG1GwRSCexfOC2IakNbnOeWrHvjz3giC1YZ1KVdNODhy74iL48Bh9wbM3qTlhHjbU9+tdcnpGZ1gA2oI37HEXtSjE/8zkZ6F6ie7uvZ2/0zs60EIPqGOPqEnuPMUSYDeybpI3E5LomUvrh5DtKJIbWhwLeQJ6u69hZiI3SliWYuRgP3yEDEN9KuuqluxjtOKcYtlspod7MpVudFFBKNG6iRODV1LQdJsvdXQ+o/LuBJ0egzwla1yi25MOKv0LjBn/UVS7If5PVwHXRx8L7LL1hM5adan0Y978S4PvdEeyS0mzFgLC7CD5tJu0pYGYVTkyazP8qXhr1zOKRf01cxgFDq0n2yKo8CsUi7tFj8apcF4vu2edoDi6yd9Kj+WYhc6m3R8PEbzUbp6xBrGyaov00KIH1zp8Ul/cxN/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(396003)(136003)(39860400002)(346002)(8936002)(31696002)(38100700002)(6486002)(86362001)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(66556008)(4744005)(5660300002)(2616005)(26005)(186003)(53546011)(316002)(36756003)(6916009)(31686004)(54906003)(2906002)(41300700001)(6506007)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2RyZG1TK0NPM2o4SHhXNlpuOThQYlBValQzQnE4RjVmcW8rb3kyY0dOTkRm?= =?utf-8?B?NFhlTDhpUmpSaU9QREtxWTYrcG9iOUcvVGpzaXZQTmdmQ0wwUVgrckRnZlFP?= =?utf-8?B?elFoR3ZiNmducXJCNTdNZmFrcUVYenIzM3QzMzBmbHlqZ3V2bWhKNWRKQkdF?= =?utf-8?B?YVBwN0l2SDcyS3l2dDJiUDVuMm1acUprVWZ3NHFoUHlnbjdCaVYwcTBKN1NH?= =?utf-8?B?SzRNbVRHc0xnUThRU3FQVndMMkhFbkhhS2s1Q1lqcittYlFsdS83eEk4K2J1?= =?utf-8?B?bmpiK1NpSXJaWk1leVN4TVNqMnM2bllpQ1BGcFdKYkMwNjNRM3pIM1BvOFFY?= =?utf-8?B?Z1hkSHdHWUU1eWl4RTJwcVVxSnB5TjNsbTc0VXJQKzdSMnpWYWViOXQwbjZk?= =?utf-8?B?Y2VsTldCVndCanJCMXVVNUtjVm8rekIwVGZCU2xaZ2VtS1NDSkI5SkdYL29l?= =?utf-8?B?QmVuVndSdzB5d0hyWXNmcmFXSWlxelh0UUhSL1g3Q1pmb3lCdW5RVlFtVHBI?= =?utf-8?B?dEtRemNENDh3N3hmUTVlakNac1h6b1NDQTl6bzNwakdueGIvWUhzZVB4Y3hm?= =?utf-8?B?NXROYzVzRWQxL09NTzVkSlVIaDZaRmQvREFXbzlUNkEwWUhmQnZaYnFadlg0?= =?utf-8?B?R3paYk5seFpnUW1GaEJOTFl6WnVqbm85aXlGblJBWUlxcmVqSTdwM2J2QWNu?= =?utf-8?B?amMzejRhVVpPRjNMS2Ewczl5ZnVEbituV0xtdTIwaVV1QmtZVkRTVlRzWWFB?= =?utf-8?B?V2kxWGdpTkJNNDFscnB1L21kNzNjWGhUNzRSZDZKRlJ2QUMrdkFwS293RnFw?= =?utf-8?B?RGZmNEYvM1k3dFhNVXJ5OUlFbFZlQU1uZWcwUVJzdTJ4UHlPVHJBVGZQREk1?= =?utf-8?B?MER0N3JPN3dqSUJLaXJoSWFBaU5IRGxPREJwS3N0bXI0UnBlRW9QY3dHb0E3?= =?utf-8?B?MFM1MVhCNUMweTA4RWVTS3MyTjhOdXpoTEpWei9XdFB4MEdmNnZDaFlnVkRP?= =?utf-8?B?cFZYRnhocytzemoxTVFGcDNjQTA3OC83aUUyRXNSVmkzV3N0RlFIVXlSc3hG?= =?utf-8?B?VG5vQ3JPQm9IRjlNZHZyVEwwL0s5MGhhMnJETUlaN3JKMXlleGpBWFljNStl?= =?utf-8?B?SFY5dk1tVExOUzhqZDJNUnJndmJxZnNsWVBQQ3pEOHZ2REovOGN4OGlDUG9o?= =?utf-8?B?a3oyWDJuQVB1L3NMNk8zZTRJQW50Ni9BQjFHTXFlY2IwVVA4ajA1OXB3cDlq?= =?utf-8?B?VSs3bHNxbDloOFRhdmFDMGRDMng2Qi9uU2tHODN2cnlQY1hRYndWeWdqUDJJ?= =?utf-8?B?Y3F6U3R6K20vdXpiNm1nOE83SnJOZ2trQVRkWmJiOVVjbkJjcFR4ekNIOHp1?= =?utf-8?B?dm85ciszZk4weGpLZ2llU214eTNKWk81dXRuZHJZQ0VVNlF0d1F5dGpKajJm?= =?utf-8?B?ZXRLSCtRYjVSWExJaExabTNPMGdvMmZOeUtQN2NBSU9pcXk4Z1hZNzl3UWZo?= =?utf-8?B?TW9qWHVtQldldzZEOTM0SDdzSlBlak4wM3RwVi9oWldockhVdlBuU2VXcDNR?= =?utf-8?B?bURCRHRobU9Ed2VzZWNneDB2b3dJRlNrbzREdkNVdmdNbEVmai9jY3NKZHcr?= =?utf-8?B?akRWREZzZmVmUkZCa1gzZ1RXbUdTMCtGRHozZEhGeFhBYi9lOFFYVU9oN3lL?= =?utf-8?B?UXphcDAyVVlNazJHMVl3SmtxZDBhME5vV2VwL0cvaExkU3dKZGc2ZU5IUzRH?= =?utf-8?B?eDYwZ3JQOUYxYjZGTVNKbWxFcFdmb0ZBZkJyMGpXYUZPb2lzUmhGQjZqUTBL?= =?utf-8?B?MWFmNzhvejBDRzJnRUN2UmVWM2w4TW9lWjdMbDl0UFBOUksrNzl5MVNSTXEv?= =?utf-8?B?UjBNTlhaem10UTFaKzNYWUw1K1dCUFJkZkhjUXoxcVYxQllETUdRS2Q5UUhP?= =?utf-8?B?alNHYUxsSEt1dGU4TFRyc1JiQjQrTjIxVTRvU1N4N09DYk56Q2M0NXNQc3Zl?= =?utf-8?B?Q01DSHdhT3JlYnBDdEx3QnplOW5oU3Q2MlBidlhlQ0UxRktxeG1UYTE4MFlF?= =?utf-8?B?a3I2TFZXbmFDV0FXVU9tajVIeWhnbGM0VmhsVUVabWxDSzk4Ly9MeVVwY3Ay?= =?utf-8?Q?HquqSm02XOxf6vHsD/7XrmAJH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28f947cf-2989-40d3-a21f-08da5e968b45 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 14:56:30.2454 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: weoaXUO3/J6xUZkNSq2BI9h/egn3B/0fjjc7OY3eFkcnOOPyf1+tUjVESZqX4WwKCYWHAzjmM9QZbW99hpk0IQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5331 On 22.06.2022 16:37, Rahul Singh wrote: > Event channel support will be added for dom0less domains to allocate > static event channel. It is necessary to have access to the > evtchn_bind_interdomain function to do that, so make > evtchn_bind_interdomain global and also make it __must_check. > > Signed-off-by: Rahul Singh In light of MISRA I don't think this should be a separate change. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:04:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361389.590875 (Exim 4.92) (envelope-from ) id 1o8k6W-0005Mg-TL; Tue, 05 Jul 2022 15:04:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361389.590875; Tue, 05 Jul 2022 15:04:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8k6W-0005MZ-Pa; Tue, 05 Jul 2022 15:04:44 +0000 Received: by outflank-mailman (input) for mailman id 361389; Tue, 05 Jul 2022 15:04:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8k6V-0005MT-R8 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:04:43 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbb877d6-fc73-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:04:42 +0200 (CEST) Received: from zn.tnic (p200300ea970ff682329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f682:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 7299F1EC0513; Tue, 5 Jul 2022 17:04:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbb877d6-fc73-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657033476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=A3o83DD+B1z/6kiI4KQQIPd6dtqOA5pz/dpE36h38W8=; b=jkN8Vw62hc7iKa88OPl2ClVxqDZZcTXMySFImEcGL0S8nJorx7CDCmqDTQMJnayaw9xIzk LHjGDPZOSaxrCRUZSFFMFEyCqqMiIRerKV2/mupELKxAl+F8Ac8RaI6qFg84cYP+XxKbP1 sYaLNFoWAfyJuXvx/Ucp4B3UoyvyWmI= Date: Tue, 5 Jul 2022 17:04:32 +0200 From: Borislav Petkov To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Message-ID: References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> On Thu, Apr 28, 2022 at 04:50:29PM +0200, Jan Beulich wrote: > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -62,6 +62,7 @@ > > static bool __read_mostly pat_bp_initialized; > static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > static bool __read_mostly pat_bp_enabled; > static bool __read_mostly pat_cm_initialized; Why yet another boolean var? Why not extend pat_enabled() to reflect the Xen case and explain it properly above it? My comment is likely wrong because I don't know what the Xen HV hides or doesn't but you get the idea... diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index d5ef64ddd35e..a8f1a02f9bc2 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -92,6 +92,13 @@ early_param("nopat", nopat); bool pat_enabled(void) { + /* + * Xen PV doesn't expose the PAT MSR to dom0 so the proper init path + * there cannot be exercised. Announce PAT is enabled in that case too. + */ + if (cpu_feature_enabled(X86_FEATURE_XENPV) && !pat_disabled) + return true; + return pat_bp_enabled; } EXPORT_SYMBOL_GPL(pat_enabled); -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:06:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:06:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361394.590886 (Exim 4.92) (envelope-from ) id 1o8k8B-0005w5-8o; Tue, 05 Jul 2022 15:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361394.590886; Tue, 05 Jul 2022 15:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8k8B-0005vy-5A; Tue, 05 Jul 2022 15:06:27 +0000 Received: by outflank-mailman (input) for mailman id 361394; Tue, 05 Jul 2022 15:06:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8k89-0005vo-Pt for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:06:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0940f7fa-fc74-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:06:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6025.eurprd04.prod.outlook.com (2603:10a6:10:cf::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 15:06:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:06:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0940f7fa-fc74-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EAtHXaa0lhoZt76IS6yQsJYdovcuq93izWnHsucSjdZ+Lcvc2z15xqkEv+71NAxhQSkTeo30pW2THv2fztsbo37iAHOKpqDjYl3AldvE5+W9ley8jexyakX9DnUZlj2mdPLfqvej4yNhEnyNQreVVP9YbFOXEemMyUgOMwYo1Kwkvrs3kywkNyMaTLu4jwAFs8TMXuiIAbfAl16Zy6zuD0H08jB3zy9Ch4zlAMqy7P+icVVj40KGHPRRMBWRrMWbJ0qRJsbTrJgwxP44TwNMQ+1j4mfbs0jP+UeqnhAcRshUI9qtsKGIgzQd9fNEa8hFE2RZLUMupCI/vrvNS+xfLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1K2o/RUtIEyu3ZgTyUpcbjVDofNnDg8YPvkvXfJ5DG0=; b=kitqLFWgWlkRZX99MKLhAdj5jaJojoPchSaerDKgG4ZEGAd5VQR8EKy2V1ngSzkmdspN7DvMQOHDvmhYoUskBDnFGEPTgDp+tVeiATK+oFXEL1O6Y9jvPrwdq0sfJi4G7wV4b1EJb7ClQ4cBrKLBv95vLhXXfCbEQzeUNZzTBbDCEBEV8ECCSTqhHKNEA0HgcrLa3YKW0ZhNDPG4a51hN+IOV3F7/fHzYW1vUFn3GM6TpfBjfR67culmOXle9GyLVNancpHzHZiq/sPEPDeA23UM7YZtk7baCfHRScccsYcGZ5Aynv5N64HMp3bTvBsTpYZOjZztNtQMZXk0CGhSJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1K2o/RUtIEyu3ZgTyUpcbjVDofNnDg8YPvkvXfJ5DG0=; b=Y8UHhwBWZVx6TlyOSa8T2dK/xaHGyLpDPXvduvWGhpZXBL/Pc6k36ML94ZggoKI/2/E17wt3ZUkF931kLpmjMhfDYRyLGEH0rLtmIhs7AswyuAXXYrns11/p3ctwZHX33OkMXqPjU76M0SALhEj0CvBiBNKEojnq0dBtr2dYhexxt+DipPTBggChB8UH2fO9G5v5xAZ2HOZXSHC9gXv/5bKSuq6akZ8/fSxss3Wzj7jtmXhm4n5aV9T87gn0tkz5SyHDlF/ek06NKC7kJq2tWS1Vw2fI5AU5yPt/SQJapr50ybUyeZOW9wstHtqBI7IukYBjPTtWqEDVnogIGc1SCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6a5cffb8-6510-8031-264a-807f3919ea24@suse.com> Date: Tue, 5 Jul 2022 17:06:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Julien Grall Cc: bertrand.marquis@arm.com, Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh , xen-devel@lists.xenproject.org References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> From: Jan Beulich In-Reply-To: <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR02CA0013.eurprd02.prod.outlook.com (2603:10a6:20b:6e::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84d49c29-3758-4c6c-0dc3-08da5e97eb43 X-MS-TrafficTypeDiagnostic: DBBPR04MB6025:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CpoQ/XfB0YSAMX3YB+VpmiEBrDa6ilqhp6VGlNczfS3e1YzAdhGMpDQhIjPD3TwguZHSd0+7yFltRbiAbcEdRkcj7b1gY2bxDdNHCILXXzBImqDLzMlWM3zPWBhySdZ+Y7HyUbarEZZ4R6etXid6fzhLOYzrqrfxlFJIVr5A1i89Fy5+LbUDwkvtjJqaQ+dNNBqU4Ebv7xKLmBY6TE6ywnDLXhYtkvT6FLVT+zLIeE3mFXa3AK2JuXqN9pFRuLh448KeYqLOSdS578mPye4vYAMTMGBZYIDE8un6g2NX4eLqJOWujGF1Cnv7q/KkdewDUDtHCbTke/WztbeZ62LFQsZmtMmISVtca5WIL6LbLf8SJGtjtvmALmDBlIbz4n5Wb8rqDiHYQBYHBTx6phqdtwBYKnxPBIaquLUYVjUwc2voMeX9wV3vzfksPbIPeWJwkdcTZUA3t/PDH19vsJ8as/d58Tdf34Z1uxRN+HdbBO/6b9Z9aCRHHOJ4/NGyqy/IItRi7wnkvCeV6NW6qgdFVdpXE//rFVWe1LF+MMCBLXxtdS3qMUi4UK1h7IjkXi5LfVYQSYIUCGIw/iKsQsPXMoRHLzcmstYKAO77F6F+f2Rq1ESRyQtUy/h2jL+893yM9ZH54IKaGMBZDiPZ/1bHCbBeldMmYOxId5BjMBnMGKo6o8Nilw3StLk0HjDfKsRjCz+4ezjQBBuXyByKY2VPOdE3hmClQzd8dTO5m3Atj5FV8tZJjcVWEkvzHWSHeOTaLkWlyZ/w0K1zlLcdOtZLgidHlOOX0RdGChPVYRe70GUGN0H/jeRzqHyiU0vZ3D1AZRcp7MIQttSxuV6dt/GzkWGcZ2ON8SC/FaOsftoTCoY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(366004)(39860400002)(316002)(54906003)(6916009)(31696002)(86362001)(8936002)(5660300002)(83380400001)(4326008)(8676002)(66946007)(66556008)(66476007)(6512007)(26005)(186003)(2616005)(38100700002)(6486002)(478600001)(53546011)(6506007)(41300700001)(36756003)(2906002)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dktYLytZYUVBQ2poV2lQOStpVENzQzludnZvWXlVRHVLWFZGV0xpVDJTRmJq?= =?utf-8?B?NW54aC9aVDlpTElQYnNkOFJZeWtFMFVVYy91Z21pL2lSdkNpUUpOeW1oNXd1?= =?utf-8?B?WXh3Z2Vac3AxY3MzOEZyZ1V6cHFwS1ZjTDl2R2NTUDJwaGl6RHQ3dWU1NXNm?= =?utf-8?B?L3ZHL1lpVlBOS0xYU3lyejRZRnREWFBzaU1XVmlrcGpKWVQvS1hVNDdjckdq?= =?utf-8?B?Q3JDOWhjMFQ1c2U5YnE5RFI2dE93TjlCc0VEZFk5NzFQTkdtNnZzbmdMRlhp?= =?utf-8?B?cENaazh2cHR1Rm0zYU5UaVhHeTBUdENWZFRjMDdiSDRwRkxSdTU1WjFxM3ZF?= =?utf-8?B?cVRybmE1UFhrdDQ1RmE2ZjdSZ1RwRjB2ME5DZldJM0pKSnRNK3h4bFpkTm9h?= =?utf-8?B?QXhuZkhEUXdmM25vTW44V1NwNENWazMvVGx0a2FrczRENk1ucUtjYndUK3px?= =?utf-8?B?VlhyMnhQeEh6VER2dGNHUUw1bm4xZjR3YnFrQWROOUJscVVodkNWM3FOVjRO?= =?utf-8?B?djE3Z0h1TDVORDEvRW9IdjF0eVlxcGoxeWtxQlR2a0hsdEw2VDVvL1hsVVNV?= =?utf-8?B?YVNvcXJnQkNyeFlqTHBvVFJpR0V5ejZJVXg0cHV6RTMvQjg1S0VrRTNSc0th?= =?utf-8?B?WEV4TDArTURqKzQxekRUa1FFY2xtWnpWVUxJY0tCazlYMHJiUjR1OWhIcmJL?= =?utf-8?B?elFJdytMajlNUGd4QWZVQUEzL3BUQ2VBVkRlVjg4WERwZC9yV1dWNXY3bEVH?= =?utf-8?B?eWRzTm81NmxIazBzSkQ5cEVGaUtmZFFtbHFibkpVY0FzRXc5QXFUcE5PR0wz?= =?utf-8?B?ZnBISEVNTzkzdWh3TmVGUVhvc0dvMVErelMyTk1HNlRRUmxMRWdITlhpVUZV?= =?utf-8?B?T1Evb3JLQnkzUllUUGdLYksrdGUvdXkxQmdOaTJYbjUwM0ppUW9uQkJDSDRQ?= =?utf-8?B?S0ExL0dGWW9UNm5pQVRwemFWM0M3bmlRd1dXc05pWnpQU2VtWDQwbW1rKzdj?= =?utf-8?B?MVpKS0RrRHJ2cWxFUVYxN3lpb2VTMlJob2FwaWNrZnFFMllZRWtGS1dnTXR2?= =?utf-8?B?WCtwcjV4WHM0Sll1aUQrSHJJQldoZjJINUR4U0FkRCtxKzJpa0RaVjVybXF4?= =?utf-8?B?cS82VFIvdHp4dFFhVitINWJ6VU9MSVZwenRUYUcyTWM0ekRHUzB4L2szVFEr?= =?utf-8?B?TXJYRTM2TE5iQVJoQk9oMW84anNJa1kzekt0WHBJQWMwWTc3dDJ5ZHRPU2k4?= =?utf-8?B?QTBCVWxsa1dBS2k1amhlRmt2Y05oT3JweVJwZVRRTTN0WTgzNCtuMFNOL3JE?= =?utf-8?B?T3ZvelgreWZiK2RmYnlpeUd0bmdBVnltYnlzcFFWaTJDbndrbXliWGo2d3Zm?= =?utf-8?B?SzBkSWFreTZIRlR4WTdxcFJ2ZmxCY0c3NkJna1RRd3pYeDlBbzhrUGNLOE42?= =?utf-8?B?Tkd6RFN1MjVYL2FaZEVUYUZmVUtiRzBCQWh6L0VRYVNaUkhIdmFqOGtGajN0?= =?utf-8?B?a2VrUFdQdWgxZ0VmREYvNXE0Y2lacGZISVM1TWtXcFRqQXJhbzE5dTI2QW1y?= =?utf-8?B?THc4Ym1UaGcwcUJmaGE0TFYwTzV4ZUE4elFVcXl5SUpQMU8vaVFVRzJrQjZ1?= =?utf-8?B?K1RXRzU0VUdHZ0QwbkpLdVVieDkxeUwwVmhDemFUTDd2SWszK2tUT0VhZGRk?= =?utf-8?B?b0VmbEhYa3ptbUZTMzlwV3VMcEFPN1hNRDB4WVd0eDA5d01wcHJiUUNsRUxJ?= =?utf-8?B?Rjl0K0F0YW82Q2xZS1dJMml3TGl2THRtV3ZmVWlmcDFmM3hsYjEreldsRExL?= =?utf-8?B?RUtMOExDWi9DQUpkdmFiRURaWnBxaXk2WkxVSjdDRFVlanUwVEQ2Sm00UmVQ?= =?utf-8?B?cUxxekxNYTNGOUxyTFF4N0tQMkxIZHEwa1FSQ0VxOUdBQlBwa1poWTRQWGJJ?= =?utf-8?B?QjBtdENWa0dPWURjcnZrUHNwaWZzUk5TSzZCQkdxdHpGb0tGaTcwSWFBcTVh?= =?utf-8?B?c2paVit6TlFwQWJJdGxJb2xBWkFEcEk5RGV2d0ZFS05YRWFVR0VzcC9MV2U4?= =?utf-8?B?amQ1TDV4TVdNcU15S3BwV0xlTWFKWHkyTnRDb2tCaUt3bGlieTJ3b01VQWg4?= =?utf-8?Q?/B0bCGJy1muPMJnMokuSvAZDu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84d49c29-3758-4c6c-0dc3-08da5e97eb43 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:06:20.7552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3//4S9OvYDhH435YY9lr0Mfik+QbkwWXlieutfdDyo5AwnFhnH9GPT9ZuqjVLhWj26293N0nHsvrx7F3F89Drg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6025 On 22.06.2022 16:51, Julien Grall wrote: > On 22/06/2022 15:37, Rahul Singh wrote: >> evtchn_alloc_unbound() always allocates the next available port. Static >> event channel support for dom0less domains requires allocating a >> specified port. >> >> Modify the evtchn_alloc_unbound() to accept the port number as an >> argument and allocate the specified port if available. If the port >> number argument is zero, the next available port will be allocated. > > I haven't yet fully reviewed this series. But I would like to point out > that this opening a security hole (which I thought I had mention before) > that could be exploited by a guest at runtime. > > You would need [1] or similar in order to fix the issue. I am wrote > "similar" because the patch could potentially be a problem if you allow > a guest to use FIFO (you may need to allocate a lot of memory to fill > the hole). At least from an abstract pov this is an issue with the shim then as well, at the very least when shim's and the underlying Xen's alloc algorithms would differ. With the nature of the shim that's not a security concern, though. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:11:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:11:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361403.590897 (Exim 4.92) (envelope-from ) id 1o8kCt-0007aV-1P; Tue, 05 Jul 2022 15:11:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361403.590897; Tue, 05 Jul 2022 15:11:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kCs-0007aO-UG; Tue, 05 Jul 2022 15:11:18 +0000 Received: by outflank-mailman (input) for mailman id 361403; Tue, 05 Jul 2022 15:11:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kCr-0007aI-Hi for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:11:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b739ccbf-fc74-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:11:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9362.eurprd04.prod.outlook.com (2603:10a6:20b:4e7::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:11:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:11:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b739ccbf-fc74-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9+ZGyeTh+2/tFa1HxQiZFfANxidxlg+z1py2DZn4GzrAQVcliRnewG5xYpPewcLetSNPsvRzJ2KjCItWMpb+KlyS+sFRvqJmpF9F3g97NJwL1cx3QK0p2/yNIqHd+sWg/TcboadENR3VRR3q8N0JJ0TjRZPJmvoOYaXU0XOIiWZ+lfVzjRv10lkTO0LyHUZ/PsXQevIjBPmi1Co5YWHVcWMvZjfDN3+FE7h2TsxUM97mcknujYwVGr9wNA0VXvQvP3cnjkVyhHapedSgbJVRf3r5vEC++LFAK+KRmSFNyQdmJ5WUuWp3s2sFL/NvXL/A2E2z9qhRva7G8soTpPYfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q7cFpSc752YWFu6Rl59QKu7tT3qs8s+cHdzmIBFCvyg=; b=iuKCcGwqK/YHa4YV1XiYqi5RrNOsgkHfYvQG06CrrQpdhyHB/qsw66EjvUOhkv+zFyna74FzJkR9pgcs0ZxLMbPIYxaoX5Pexpm7Cfg+7BdxY5I5gEdnnHca/9CGGCbRqHrm6NX9Ip7euXPzpG/jqVkzPNLur8zEqS7KW5bwAbsabpwsDSWYIoD3Q8IkIOHdUBm7WitnVoIT/BmWc7DrXv1Nwk/gqsIwESFB6xjxG6bV4IEdVmTI7DPUtTi4Q58R2sJ0CRN/qXA4I4fDQZsjObcU6lfidDqrTCb+SYfuqOV6mjpa1SqsIpXvTuq00V7dHVOl8BFY6IkEGANQP+KAqQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q7cFpSc752YWFu6Rl59QKu7tT3qs8s+cHdzmIBFCvyg=; b=p1auXpuGnGsVRd2LkZG0girAQExKk9KupAUq9OekYtJkbZWgyqxO/WMw9/yz5A1/pCCGtZICnlM0BDyB0vMSqg4rYSo6EpYBAPYrxw+znF8VagL6JvpzPr3S3PPsXnF9pfofUr/dkNMeKyrPtbU+lJzqROaTew8l8rkoWtE2GmAOgnTy1Y4ZZO0xOWilARRRZhc+bv/QPrT3tIZDdaShiBXaDDEELNKg7JsDwg85PszIOQUOYZU7BfRIM1oEetH16Ji/UxD9wH8giS0Zotmi2vNo0aVCy64cZLClKd7ZOTTkLIynokaspKslBS1kRTbkNZj1TcQcHDpGsFrH6KJH7g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> Date: Tue, 5 Jul 2022 17:11:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 42d840a4-a77d-47ff-0346-08da5e989a3f X-MS-TrafficTypeDiagnostic: AS4PR04MB9362:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Q4soOqu4qMwqduCFdKTbfDeF88friKOxpWEuEE/4TT4geWiLjKOk4+iPbX6DoQHsZ1aTD2lRDTv4hv2FbR9i2Akc1Lowt14JAhkduluPnj1VPlYeE43U1/L+9EjtxUZEzjgBMtAQsmbUuyhlcnO6ZyNIkyPbjmH/Kps80d0gGhAWXz5o83CLJ4iXtFIqIE1/65RxeT6QxwxhuXSnAbTV05DQBLtoU1d1gNTnVOfeM+522ngLnvLl9AXPvD0bpUuLatvZLe47O9gmtQaEh4GgjQfGTe5H8QTpz5Nf9DRh7IH0hX4WL9heDXtXljUr+wahugCQ0WecoJtDD07mTZPFo1XPN6vuzmoxJmmqJVkiG6HJfhvhyYrOZFuY9f99xF/9owqTIutPcokBcRHSZ8AFIIjyfBszl/b7W8Ie5uFhZfwHm5F0+7xLSxvTzYpCTmvODZQuwaIimTtAwcGKqj3XvDUOKB7KREjH0SCm9K6aZPBXJsJ/gPgrZo0djN1webmsqhBOe4aExt3NdyVAs3849dchgDBuiXZCXCL9is73aXL64wnle8Q5PJoL/E3qmVjUORI/sCMxzJXk8CQEYlYaJBAboBrYlM4EEBMRUKFT7j/rIGg6M0+KuURpwmXgGw0Vp4uRkXjLQKEu0w5Exma0bnFos4LnFyCAL0JM0gP5W/Qs8nzp5GwitsG0PXBYwh6vvlZDqn57Ig2bLoPKQ5dnQ2i9qLrNNcFCNw+HQ0WxTdsP2W6pTMMYDEXT1Nagkm53ZSQQrkU27YxVOef8rT4+3FRMHBOS7oHM6BDBe0otP/oZ8D5bwhptk5x+2BMhTNIHAoFeTrxuE2IHZTg/a31sz+ZBb8iAwhObg9kILJUlC+o= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(136003)(39860400002)(366004)(346002)(66476007)(66946007)(38100700002)(66556008)(54906003)(5660300002)(6916009)(4326008)(8936002)(2906002)(4744005)(8676002)(316002)(53546011)(6506007)(186003)(2616005)(478600001)(26005)(83380400001)(6512007)(6486002)(31696002)(86362001)(36756003)(41300700001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a0t2Q0U0T0ZzMndwQ0YwYTI4Q3BoS3BsYWhKeDZUU200Z1hkcjZtQ3lVODFa?= =?utf-8?B?dm1MVXRacFJjUmorVTl0Q2w5ekZ1SWVvMENDK3FTMzBaWUE1Vkg3aGNkZUtL?= =?utf-8?B?STZveVRQUUVLb29GSzVxWDFxS3MybXBhZVN2UUFieThCZE5xOTlwam5vdk9R?= =?utf-8?B?Qm8zTW1lZWJnV3Yra0ZtY3hNWTBNOFBLT212QVNYZ1pyRllRZmFrYWt0SDZq?= =?utf-8?B?dnZadkhFTTNpMXd6VGxOMTZGcWRpUGY1UzROblVXRVNIVGhMbkNYRXZoT3FP?= =?utf-8?B?ZDNOdlpNT0dpSnF6MloxRTV6ak02VXFUa3JJQ0NmN2ovTTJ6TWxZMjVweFkx?= =?utf-8?B?QnV2eDAzcDdrNUl4MjlTUlBoYjRpUysyYlFEakxzWm82WDFPSm1GUWdhM3Zp?= =?utf-8?B?YzNPc0xqc2VqNXpRUkZ4UVFEc2N3Y1lCcFMrOXFiUnVabkhxWktzRUhieHUr?= =?utf-8?B?Q2J5TjR0cmh0MERXU0RCSlBBT3JrUDVuWGNBNGsvL2grV2IvZlA3OWIwSWN3?= =?utf-8?B?WU9XSkR2ekloR1NSN21lR08zRktWUUM5M1pPNWlwb0NwckRYZDhISVluMUI2?= =?utf-8?B?d3FiRW8rZVNEVDIvL1Z5SXdjNFRaTi9wOVFWMlBTeUNJQk1kUnVtNEFxMGpu?= =?utf-8?B?TUlQWWh4bmd1MXBNVnFNUzA4T2I2S0tLVmtaeUUySEFza2VCaTBldFFXdHh6?= =?utf-8?B?U3pMS1dGWUxmZkFWeVJFOFlKallvREdHMDlBWHN5VVBHQURaczhQWk02a0Zj?= =?utf-8?B?MzZqazFPTXNuaENSNVV4QlQxRHhkbnp4TlVQMnp6Vjl5cW43ZmpINlZ4aFlQ?= =?utf-8?B?WGMzNTZvKzFRZFhVSFo0R2pZalM3Sm5BYk5xMHpBSTZmeFErQWl5dWJVVmlv?= =?utf-8?B?WWE4enl6NDZ5L1loM2VyNGhLcWc2WUpvN25RbmZvYW1EU29FUFlwSDRtcHR0?= =?utf-8?B?WTExZDJHY2poM01LUG1WQ3pFc3FYN2NYc21IcGFFMFZTek9qRnNFOTZsd0Ju?= =?utf-8?B?SW0zb2hteERhdGJCeXR3NmtCQmc3U1BOUHJzUS9NK1dXbGZrSm5RbW1JeWdV?= =?utf-8?B?RW9RWGxlT2JnSk9OTE5qMFNrbkhJTURrZWZHMFgrY1U1TThuM3ZmazJTbENw?= =?utf-8?B?NEF4MDNHaXNLTkVIMGVieTh6OUtrY3BxeFlVeUxJWFBlRHFqaVIzNjdLdUY0?= =?utf-8?B?Qmc4QWl0aU92S0ZNT1pOK2xOK0w4UEVzWEF6MlhPRlhJVTU0a3FCeGFSRGJL?= =?utf-8?B?eHFVV1V3dU80TWZnL0cyS2p6OXo1S3hmSUlTVmFhMlJTKzZQaTUwSTZkMkVG?= =?utf-8?B?ZG5RUTg2UHdXblFLTEhkbldaV3dkVERjODd3ek1BbDdnUlhJWHJ1RmxKSWZy?= =?utf-8?B?S0ZEWGlJaVRSaE53SUtmZTR4MGRtUkxEaDYvK2hSMGh4WWZkQWp6Wi83a0Ro?= =?utf-8?B?YVBGQlQxeXVWOFJGUGwwc2V5OUV2S2VIUGRyTTZhN1d5V3dibENNVCtHL2xU?= =?utf-8?B?ZzJTNFhPVkJuU3Ryb0UyeEJtSUxDVjgwMGkyc1ZZNitHRW5TTlBacDJXZG1P?= =?utf-8?B?cytOMThxZS9iUEZyMEtpT2ZMdkV5ZUx1eU5seVZoR0NnaTdKQXhXbllUaisv?= =?utf-8?B?N2J5WVJ3R0I3N3RKaDU0M3RPai94aGlhc1NoVG5iSy85aERoVmR1TCtDRFV0?= =?utf-8?B?dWhKbEx4UnhrSVVlR0ZSUWVtWm5Fang0WU9VdG8ySDBaS3hwWWFtNXBoY1Jt?= =?utf-8?B?WW95aDNWODZtRm9PVkpaOXppdE5waFpEQ1ovcWkyTWh6Y2c2MmdHUXlxMnNl?= =?utf-8?B?VzhBZjFEMVpBalZDZFhKQlN4bG44MWRUZDhtVnNra0puOHhkUXdvUWIvVytD?= =?utf-8?B?dWFFMmkwai9ra0ZvZTFsOUtBYlJnaFV6ZkNNZzdta3YweUlHTlhnMkVYRW84?= =?utf-8?B?VnEwSm9YRFZNY29UQ3JZNm5jOGxrVHNJTkJORWlnV0hGQTdpczBaYTB2RkRO?= =?utf-8?B?OTArOEZnV3dJOTBNZXlhTmVjZ2RGYWpEVURlR0xrUzRRTDE5b3k5clVtMllt?= =?utf-8?B?cjlRTzZsRTFjeG04dVNtUU9RME1jbndpWlVua0FhNENPWWFNYVU3OWdtN25Q?= =?utf-8?Q?OQMq5V4WUpchg+/K2Z0M/RsD5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42d840a4-a77d-47ff-0346-08da5e989a3f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:11:14.3613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xoDDudWehcaLFpKH4fU1zEDYT/DjCg738yHs7K+mRZ5JKRekqy38VtQ3fre58GVp5fHfmLnpkdUdsJ76yMX1Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9362 On 22.06.2022 16:38, Rahul Singh wrote: > @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) > spin_lock(&ld->event_lock); > } > > - if ( (lport = get_free_port(ld)) < 0 ) > - ERROR_EXIT(lport); > + if ( lport != 0 ) > + { > + if ( (rc = evtchn_allocate_port(ld, lport)) != 0 ) > + ERROR_EXIT_DOM(rc, ld); > + } > + else > + { > + int alloc_port = get_free_port(ld); > + > + if ( alloc_port < 0 ) > + ERROR_EXIT_DOM(alloc_port, ld); > + lport = alloc_port; > + } This is then the 3rd instance of this pattern. I think the logic wants moving into get_free_port() (perhaps with a name change). And of course like in the earlier patch the issue with sparse port numbers needs to be resolved. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:13:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:13:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361408.590908 (Exim 4.92) (envelope-from ) id 1o8kFJ-0008BY-DY; Tue, 05 Jul 2022 15:13:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361408.590908; Tue, 05 Jul 2022 15:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kFJ-0008BR-Ak; Tue, 05 Jul 2022 15:13:49 +0000 Received: by outflank-mailman (input) for mailman id 361408; Tue, 05 Jul 2022 15:13:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kFI-0008BL-4b for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:13:48 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130089.outbound.protection.outlook.com [40.107.13.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 110437b8-fc75-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:13:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4145.eurprd04.prod.outlook.com (2603:10a6:208:57::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:13:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:13:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 110437b8-fc75-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lIK2Ub9jErLO63a5VKz+lVERtQ0GD/zSX4fMUz0JGU9zGfTppLa3eHsGmSK02t8Vj8f0qC1Lokj3NMc3320d8T/3GblkyF4xR3E8EnP7/veYHfJz2OBvL4g6EempWC2iY6bCBx2sJbWRx9Uz1BeHbNUhJc4SBghyXWebmQNf1mbxnInIrHFlxDJ7/mqAxg/VXQkjt52PBgbSevl+31na5Nql8WfieVNiFPMT1cBPBj/v8E3LRGENE8KP4vflhemgCi/n91ZM20Jd1ZkZXWv4Zu1e/K6/LC2v0exxj4GUHBERzJNSOIfTGMummDFvKUaJW9X8gueZtTNZr0sT8XUznA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qBT/cGpCiJBEjCK8Jt/7h3bw8PB3+nQ5GhQuxfrLH/M=; b=NNXiWznXTo5eZw70HVewkMZ8vvVM7O1L2XhjO0d88sU9jX4GpfnheutDeU1+FVUO1KvVnmw4Xt1W00SfbdmMAft0WzyrHYZ3kCFM53joMakO8utjw79hW2OeUcoIND2ne0yYegM+mQAYN84H+JvpLvIOwfk1MHr9FZ1x4P+p1+y6hxiM/LRKeFOAcAyuh4HUzkxZm+f+3XWc6G5XMs4QTTz2+i5ofli1fD1s8ELvVjaiOl5ycplYl3v9gQ5C8VullyIZjF8jDpSJdCzTbEdlw3u5+HOC+OZ1sYzO4H8yKa7rkrVXHQfctxiBbWGUQCT3BOoFIDPdddS1O9x8ivt5Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qBT/cGpCiJBEjCK8Jt/7h3bw8PB3+nQ5GhQuxfrLH/M=; b=k+nhFCd5gS9T+qEqvNM4hzXFG2R5suscFbAP6GPQO9O1QQ0EVGs413MDm4QR/5jHP7jrjM7jpIxZFiglO3N1JZzIUPyvugFBySraD87T8lqZE+F9O/cSLT17A6Er9xTpgNpNZ4om6GbB+U0U+k0DQqlaarH38zLW8AZrRze1waj3KG4tvnyN6zpC7N/X4/3t/K3xn1tcXg20jM3enZnnYKB9eJGBB2zYoOo4pypI1LKppnsVlrsvsvQ4M6N146YzkiwWlIrA3t0IK0hbQCJitfQG5AIqu1bj479ow/WPLh7eQ/vIGE+8WZ3RkGpZvvGdwxFBAreSPCkvEUqg2+kPgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 17:13:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/8] xen/evtchn: modify evtchn_bind_interdomain to pass domain as argument Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <037b30aa5186cff516f8acf17a3a465663a8194a.1655903088.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <037b30aa5186cff516f8acf17a3a465663a8194a.1655903088.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0039.eurprd02.prod.outlook.com (2603:10a6:20b:3a::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 88694983-3591-473f-a8db-08da5e98f316 X-MS-TrafficTypeDiagnostic: AM0PR04MB4145:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xr6QdVBHj7IqjiTeMzBNp48nkzUi9PHtygXYbsTjBH4EvJ7wjCt2J4O5jf/Bpu1pbVW5IQx+zQyi7PolWKNIF5M1tP01bs5IiWY1pxEJR1M3dQ0DYlW+HjTImkyBXSm25Gbl2WTHbcqxQKE31eiM8rw3X5oaOGOVzdbAVqQEhm4I4u1aN2QWFmspmlZ3gU7aOgOUSEFvchHLv5PfPItgi9mHo59/cbBGd5FFGqUgYYuMEukNjVU+8ZDK7Y+ecOFfBcD5Icjsaaz32DoRN4L9oFVmJRsAPoZDecLzNFBpgOMdJ8SFMLYxwvayw5KdD4jdVyubOGlYQeZMNGZTTwNrzY9b6hWo0NbMtY/qjF+/jmc8zMMReKbhr6mBRQqk2mApuRGJLiOsZhbTAf8n0zOSlTHYtc20XUvBAvGVKbZLnxBNhRbbPWF8/pbLXa4EDW+DqS7XrrGqHK9vOzhxfGKRzTyiaHdDkfU2nS/NfP2xqWtybQBM1YKX2dYQ9Qa3CunpsFgUQfV/kGK65VUeGXmxF2x4qtBz0aRmfoBEc+y2JpBNQtHS2YK3BzRrPJvUL+Ge4PJtujSJBO4Y00mwHPBJbgVm8SgC8lD+ysnELQJ1kRD0KaDbX8haZHgvaeHeWfIwKcGTVHphBY93dv5xGSw3iLDm5m9aIvDi0l8INz76CobAyeYVWKgDdrZ0XG5Y4sfZ1aphibQeKR8nHBsnakubdSBVb80TlQjTohqIF1Gd+8Bm6QV+pEqru0ByuiSDzhlVEWGbQCA/cgvWF/S9egl6xQddjbgJY7nj8bSEUOIKSQ6LKv+F6cM8W8lj2nXDy2pEeviSADbP7OkONBgJuSn/dwQyuQxRiG21R/xrHrAuVu8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(366004)(39860400002)(136003)(186003)(86362001)(31696002)(38100700002)(41300700001)(53546011)(6506007)(316002)(66946007)(26005)(4744005)(478600001)(6486002)(54906003)(2906002)(66476007)(8676002)(2616005)(4326008)(36756003)(5660300002)(6512007)(6916009)(31686004)(66556008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVkvakdSS2p3Z0tXVnpIR291ZkFDcmkzRmFyWUl5dEhlYlM4clYzNUZRNzFS?= =?utf-8?B?cDFyaG9XOVR0aVIzNkVpb05FbWJMcmM1MjRWWm40c2twOGhyaEg4RUpON0dG?= =?utf-8?B?OGwzYzkwMVJHTkJ6SnNSVjh6ZWJVcXMvZmhxSjFQR1cwUEt1N0cyQ2tKU0FM?= =?utf-8?B?a0RhajQrVlNKT0xVZTQxVkxQbEpXWWs5U1ozMWlYK3d0TmlaWjNCVEFRUHlk?= =?utf-8?B?alJhSVlUMUhNbnMxSzNlbC9PcU9yQ1NoNm8rLzMrbTNYdExKVFJHNHdRZXVt?= =?utf-8?B?TFRMdmVtWVJmR3YvTHVIdTVzZlZMOWpyMDJXRmhjbkt4T21PRUkzanlla2Zj?= =?utf-8?B?a3FhUURvb3pEK3pUeWxDWk9wcmtacUNTUjl3MWY0Q2llRVF1TTZCd0NwdnVM?= =?utf-8?B?S2ZSYmxLRllQMk9mUzVKZi84TkNKM0g3R01ZbDJzbTVCVzB2RytwTTdzT3dh?= =?utf-8?B?Njh3Q29pUzZ4amhRaHpQVVkvY2hyMEoyMDdoVzZTaFZwRGVjR090UlZueFZH?= =?utf-8?B?OVVvWFEyeTlKWTIzUmd6L0lNV0pTQS9MUHM3ZW95SDA1L1N5NkZRWCs5T0xQ?= =?utf-8?B?S09qUTB5L0liNHM5aDc1aXR6TTJZcXhDVy9VSWhNT0paUjVJa1FCYmU4c3Zv?= =?utf-8?B?NGhRbXJhK0pvY2k2Z1hQbEsxZzZTVENQYVBKY1hrOGR1QktUbXNBbXlvbkNo?= =?utf-8?B?cy9VTjJJM0xGeVdIK1djUWQ5VXA4UGlncDZWbnd1RTdHWG93WWl1UjVZUnd0?= =?utf-8?B?UHA4TTNjRDFXNXFNT0R4Y3dDYzVER1ppOXJvalprVGpXQUF1S1Qxc1RoSlB4?= =?utf-8?B?S3hOZ0c2R0Iwd0lRTTVpU0pTb0xFSUtRVVkzNURSZGhISDBoZlZMMm9PQ1hp?= =?utf-8?B?dk1FbVo0UVc0TDRxcVdaemRibHBJRlB0bUJuT2lqRm1IcXhtOGNQRSs2ZzFK?= =?utf-8?B?RnY3L0t2bDRjRjlvK3hSN0VlaDNhQzBWN2ZlWDZLaTRkeUpXMXhEblJTM2RZ?= =?utf-8?B?RjhhRmQrTXA1eW9JRXRLMlhUWWlMSmlqdlI3QlhSNHZRRE5tL0dmRS9qUFNj?= =?utf-8?B?eFlHRVNFSEkvMmRNdlZSR293T2syaGF4NVVzczBzYVZxVUhvS1A5RFMvTEJl?= =?utf-8?B?NEt4WTlLaVhaMFo5ejk4SXhZZkdodmJRaU5PNU5rWVZ3QnBYTDVsRDRhS0po?= =?utf-8?B?STdWTUdnWW1ZY0dVUEJaMktUZjBXOFl5QnRzNG1TNzg3aUppWEg0RFlmQk5i?= =?utf-8?B?dlFVMEJNanVFV1h3YzlBaU1uN2JGa2l1ZGgxNXpralcwanFpcWUvbGtLS0Fn?= =?utf-8?B?NUlSUmFEM1V2TEhiMXJScFlGRTFsUmVmUUhVZDdIb3BIaDZrS1d5RkpvdnEz?= =?utf-8?B?ZmY2WjJXWXFHL2hwSEdiUmdraloyWVdZNTUydEtFWWJ5cU9zWk5nQjQ0NTZx?= =?utf-8?B?bTZ0Ykp0Vm9qTTU4d0pHUm1GdWJ2V3JaYUFsYVlkcFNKMnF2dGFqaFVvdWJm?= =?utf-8?B?OGdlT0U0V2JlK042ekZHKzNNVjJrOVlDTWNOaGVuNCtFRk1RRG5sTkoyRDdI?= =?utf-8?B?S3poZ2o0Z084RVhxOHdDT01YTkd0SUJFM2l5d2xQNmMzSkxLbS9kWjNDSmZh?= =?utf-8?B?dnpGbDZIUHAyN1EyQVpTT3p6aTJXNTIyQ2pma3BpR05KQzVaRTVFVC9qcTJk?= =?utf-8?B?RDlUVUJpYWZjdWZTd1ZBdkdYYnQ1bEtEWjBVYVJ0VTllY0lHaEs4NmVpb2Z4?= =?utf-8?B?aEJCTkZ0WnpteHhsbFJQMkZETG5jNHhGUkZ5Uzd0dVpHQXZMa2h6YVVqSVNF?= =?utf-8?B?Q1VYcWtzdHJ4SHZidTNKc1doWklyYVMva3VnWFRqdEpXd1l2ZDNyc3UzUFNm?= =?utf-8?B?UFVES1VGMGczT1Z4ekVUMng3QU1qejlVSEpsT0psdWhZVjlvZXE1UVVrRDFR?= =?utf-8?B?UnpnUlU3K09uZTI1eTFBcU1kbTNRYkpNRWVOaHk4SGRNMlc3b2lUYVJ3SEUz?= =?utf-8?B?MENudUFHSGhabTVFL1Q2MGhRS0Q2djBVMkJFT0RQQncvQW42MzhWaXFIL0lV?= =?utf-8?B?UzJtKzZjazNFWnNOUHN2bHI1OGJ3b0JYQ21sN1ROWVp4Z1Yya3ZreXo2ZEpP?= =?utf-8?Q?RJwg3yZwa/pWjpamhyN/vP/6D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88694983-3591-473f-a8db-08da5e98f316 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:13:43.3672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jmuFZ722ARtn4ERLj1HAz4mkml2Br8M8A7K86ipXCDpE0aA9Ze/dQk87SOC1d8QJs+8n2eZDRuSInngi2/PAzQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4145 On 22.06.2022 16:38, Rahul Singh wrote: > evtchn_bind_interdomain() finds the local domain from "current->domain" > pointer. > > evtchn_bind_interdomain() will be called from the XEN to support static > event channel during domain creation. "current" pointer is not valid at > that time, therefore modify the evtchn_bind_interdomain() to pass > domain as an argument. > > Signed-off-by: Rahul Singh I think this wants folding with the previous patch. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:17:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:17:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361415.590919 (Exim 4.92) (envelope-from ) id 1o8kIv-0000OO-V4; Tue, 05 Jul 2022 15:17:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361415.590919; Tue, 05 Jul 2022 15:17:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kIv-0000OH-Rf; Tue, 05 Jul 2022 15:17:33 +0000 Received: by outflank-mailman (input) for mailman id 361415; Tue, 05 Jul 2022 15:17:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kIu-0000OB-Db for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:17:32 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130071.outbound.protection.outlook.com [40.107.13.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96aee83e-fc75-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 17:17:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4145.eurprd04.prod.outlook.com (2603:10a6:208:57::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:17:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:17:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96aee83e-fc75-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dODqLNb418uyHRTES+tBzVqPzp20y8uVZnoJsPJlNblPV2FMfV9XRySEUmpt1XvhVnmeO20puU5pHqasHaFHOoMUCJJT0IiOySfmCRfGDYh7aMtycetCQb7yGj6hd62Cyoj1oEu/5BzrV1qUjgcWX42iuMqytSQvRYj1ugb/SSPcatthWBC6+JDB5g2lznRIas2StBItBzY8pVJ5Mh+lL8XezUQMTqiPl/m50faUnPAIj6OtRM6eLwQ3V5rX9OGRaDTMzyFp5PbTL4+D3NIt04w4foHmNT3qiypkNzzAuXAwjXdIGSZ3xFiU8+dPe6eJ2ZU4PJFe/oQrnMI0e9VU5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=usbEfZzNOLvr7RyaAHO1ybkqAzyYaYrE75GvVWP5K2A=; b=aD0ZIuJ7d0CNxQ4af2UcOdYUGeEmxgB61dtQr4dd6Mis+/ig1Ut9kTzkEXns7uNkxLMPRo3+8KOm8hiplZvB5Uug7vi/UrDsYF7iTtFSxiOI98vrkQn79srU4j/eCNDpssPXfvBhSMlQwAJzhEHAi1QiVy5UY05N0c8iNb6Am2Fc5ayfrg1aiN9g6CZqT7j8E02RArhrxDzwd2BL9LkKLppVCD13K6jYxQXGDe7SYCjARy9ztOkGpVHvCHAd8G98dsOJyCCcIiqY1EpsrReBQ6/7KrJDiXo36ni0svCWJYyL77BpCHFlN5J2JHyHtl4wsZeKyONnGefyGYuuq9Yo6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=usbEfZzNOLvr7RyaAHO1ybkqAzyYaYrE75GvVWP5K2A=; b=qkbanPS3V94J+UBjcTDz3LJgDwjwM0ZWzHjKnwDlWtOkxEObiBtaR5sfx3k3VxJtaPllU5UsmsTK5Hhgxhc4RsgnYG9Hi7xArd8ICnxRU57Qk5UklOCY7Bli7Jl5ucbWJH9bajpm8ClqATiyf8q7o3qO9dZHfPv8+Z/XsG/BnpM8psf/wlrwYa1a2N0taO1bAP5quqKMtbMXkt+CTG6V3vxgq8CcthGTpaIwD/1aqCH2vrMpC/7Rs1AWyLXj67jHcFg8MYM31EawOWzo7MHp+OSXp39syKIHjS7nRKqtoCQTyA3D6NUgjY53t5zoE5DJyH+VOKgOh6BCbuTnWKBdgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <377801cf-1948-eeda-feb9-b9996bba5d47@suse.com> Date: Tue, 5 Jul 2022 17:17:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0061.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::38) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 384b4f04-a870-450a-673e-08da5e9979ef X-MS-TrafficTypeDiagnostic: AM0PR04MB4145:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gIjrIWc9L/HRCbdGZDoJVhxfO+Es0VIYAxxrOCCKMHVFtgk3yFqagfw1ngE3t1pRHLzEZ5BlbRX8m+HZrkx7ctnB3d4JQlpAMuvucPJxTshlBYE0tg5ax4AWXWMUCGqTw1/toRFHD9Q4Jau0ko6AKW5ODZ21MdO2bs6yb2GrJN58PomI+6GKJzDLwR9iGx5NXOa1JynqCNNdO2Zn5ar/HXzs+VGArHqstl/TH1/sYsy+9MPjoGMNfQuXYjPtoQTCmWaPBvdmN6HpSnfqxBKUY0e6actgTgfiaMq7qb3eIvWQPtpj6hV1Pts/r5obqox1ghIrkQrtglKaubGozVHJ18nHfG+jAVTmcXR7Cl+mAbroSJaU6/hq3q4hLsZzuzf83+cmFtOR6/Y7ULgQUzyYqHGmMBRKSEXKxblKFEHA7et6whjev0MJvl4z6Y7IBJAtd5LCfjb1yHVbHLePvCWNxESALUQP3a38Ek5FaFe63mC9Ril8EvBRY9t+iSe7rR8UlzK+u9MHpxFC6aL9RVFH/A5Ja5IW9h4c4V7iON9fVAmQsYK0q6t5oTWMvGp4bztC7jQsVFSXtmh3+nR4/8BkN1KKt21Qy2fBBqrQ9uT/4Xoz8dTefOfU/731b4F/WJG0RwalOL7BrYVdFrqB09Q0GFp702Njgx9m0KUk+PxVARUoFgWp7DHhbZudbnvhRvRnAA/r+gUmgYGdSxq/SwZ8lcGdYFmjttMssolf0AAkIeYt0TJSw569453Y/I7by4zf9X/ZLIh4mxEHwh75M5IUjoBaQwPSN4LtWsXvKLLKBiF3K/voAfZFKpXUg02sBUjSGBBmHvOnDUud1fsBabkzGSVym1FL97FMG5Cb6zPgDjE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(366004)(39860400002)(136003)(186003)(83380400001)(86362001)(31696002)(38100700002)(41300700001)(53546011)(6506007)(316002)(66946007)(26005)(4744005)(478600001)(6486002)(54906003)(2906002)(66476007)(8676002)(2616005)(4326008)(36756003)(5660300002)(6512007)(6916009)(31686004)(66556008)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkJ1Zi9NZmNRK2tTbG1yOXcrT0V1RTdyQ1hTTGVudmdKUlZPY1ROcWl4WWk2?= =?utf-8?B?S3NLa05XOU4rK3BJK3plcVprbVBNYloyVnMwUnpZREpkdmN3ZVNDakI5TEZT?= =?utf-8?B?RXM0Q0lCWDRRc1IwSHd0NVhiemxpeFVzckRieml3ZEZmK1ZHL3NtSUZTemtL?= =?utf-8?B?dWZleWhrS0ZEQW1uV1ZwaWFXYTl6MS9ieExLb253d09SOGFYQ1FnbDgraSs0?= =?utf-8?B?WXZGNi9mNmJPdXRVSEhzMEtnYlFNazA4bitDV2hYczl5S1N6Q1E1Y1YzM1ZU?= =?utf-8?B?cjF1QWd4eFZ0WXd0ZHJldVczNnh6amluQ3RjYk5ta3QxOTNOTERDdWVWc3hl?= =?utf-8?B?MlhHa1YyOU9oLy9EaGJXejg5Q0JVcWoxa1RGT2Q3K3JlQXIxTnE0cmQzQm5C?= =?utf-8?B?ZVdoWVpNelB0THdPQ0ZXZDZNU2p4T2JwMVdWeDJyZFhnSTlBKzVYakVMR3c2?= =?utf-8?B?ckk0T2dXQ2lYdWc2K29LMTJVZXZZUVBWcER3SGovamdnemVaMmJNUDlsa0M5?= =?utf-8?B?MlpBRUd5d1Q3NXJsMjBZam1jT1Z4YWNDbUxqL1o4d0xWYUl1cC9kOUlxWExX?= =?utf-8?B?RUMySC9ldmZ3blhnbDNYVHRJVzlIOXp2eWc5K2d1bmRZckdiV3BTbXhERFlQ?= =?utf-8?B?TS9KdE1yeUprM1JEY3hDNTFvQ1JLU2ZlMmdpdndxNG1uMHVoaWFmTkMwV2JO?= =?utf-8?B?OE5SWnU2TXRtN0ZXY3lNRWUxZytCZE91MmxHWGFseXZ3MHJqZUxlWW1YSi8z?= =?utf-8?B?bHhZRXo1SXF4b1lLMlE3TDlFa2ZIcWtBcjJYdEJOOHZnNVlrS0ErU2hqdHF0?= =?utf-8?B?SWc3Ym5pOE1OR2N4UTczR3ArdVMvbGhSQjFhODNQcjlMWSs5ZExkeWk5Rk52?= =?utf-8?B?SkN5M2FxODB6ZlZFdE9KQ3FVRE5HbnN2K2hIRDZMa3dSK2dVRVZDWlJrMEpX?= =?utf-8?B?MFBSdEZrMEwweFR4Sm1rZlNsK0RYbFBVaTNZOTE4dEJLTGt5aXV2QzZFS01J?= =?utf-8?B?NWFOcWhyUGlTb2l6YVBINmdZUitSQlhKVENGNmFvKzlKL0oyNXVMMTk2ZWty?= =?utf-8?B?di8vdjRDelZrV1hJTSszdVRBamVpL0xVdFpkdkkwUURBTHMrQld3bnFxaTFV?= =?utf-8?B?cHo5dTRPY01JN2JGdUdBNlZkU0RGalk1b2FYOUE1UkRVU0hMd0RhZGVTMnpw?= =?utf-8?B?YVQrVUlzeTQ2MG1ML1RNRVZpRzlzRzMvUlNIT3dnK0pPOStTamlQREVvLzdU?= =?utf-8?B?dmRzekhYTGFndHVTNWlpOVF2WHRYeStSMENZbFhHdmphamxoVXRLVktMZUFN?= =?utf-8?B?VEczWCtTQVBOZU9VVzdqNHVveFIwelpuL2pUak9KdlZYM0x1U3dWcFJiWkhD?= =?utf-8?B?WTd4MUpiWUU4TTRTc1J0Z1E5M3RsTFBTQS9EV2NOdGUrK0RrbWJ1R21SNThR?= =?utf-8?B?V0VQSmhyQXVJTS9SQWtoSUpFTzJ0dHNzek85L09VOXBMR1JDOXNXaGNUeU1O?= =?utf-8?B?aW5sQzB0YmJ3a3Yxa1VuSzVpdGltR3R0ejBtQ3V1REJUQW1xRkkxR2VRd05W?= =?utf-8?B?M0g0VE9xaVBkRXdJamZ3TFoyS1ZOWHZTQzVZOU1OaFMxdnJVQ2xKVExBQXlo?= =?utf-8?B?azZ5TmZyU0FZbk9oSk9WaWZIUVk5MFNRbXpRRUNJWDVGcEwvUVhBRkNQWEJv?= =?utf-8?B?eG1WdmJqcW1xTWtHU0tFQ2NiY1BKVEtQL2V4ckVXb0VUemM4bU9GaExmN2lY?= =?utf-8?B?UlF2RS9zMU1HYTMzVXZ0SkhkWU1iaHZRenh2Q2gvS2phdU0wM3NtUytuWmlX?= =?utf-8?B?SnVMcDJ4NGZjNEsvcml4a2RobkFrNVJENE5IbnFNeEZwSTE0blpRd095eDFx?= =?utf-8?B?VVdYR1UxWHVDUjNTVzFWK2VkYXl0Tjl5Y2ttaEVydjJNNkNpaEtXSm1WVklO?= =?utf-8?B?WnluZ0lxQ3kvWDNVTU1WVmswV3ZBblErbFBQYjlzRUQycVMrRVZ2RllPRVFs?= =?utf-8?B?U1RRUy9PMTA5NmlPeFNSaThIRGErdDEyR3dQRjNoNXcydnlFZEJwTjd3RGVv?= =?utf-8?B?c1VTYlZrVHk2bkNXbHhyeTVza2ZEdUpvV1NBQlhBeSt4U2RnNlpRY1lsQmNv?= =?utf-8?Q?V905q4rtNr3F3e2AINkavZcko?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 384b4f04-a870-450a-673e-08da5e9979ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:17:29.6023 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rjEkP4BbZylvFVWSkirt3QmTa2kRRDfP7I3HpvaXt+wGABdmLrr+hQRLLnJa0mBTvS1Su4fjm3z21f9wt0yfug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4145 On 22.06.2022 16:38, Rahul Singh wrote: > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -119,6 +119,7 @@ struct evtchn > unsigned char priority; /* FIFO event channels only. */ > unsigned short notify_vcpu_id; /* VCPU for local delivery notification */ > uint32_t fifo_lastq; /* Data for identifying last queue. */ > + bool is_static; /* Static event channels. */ > > #ifdef CONFIG_XSM > union { _If_ this is the behavior we want in the first place (which I'm unconvinced of, seeing your discussion with Julien), then please be conservative with growing the structure. There are available (padding) bits, so you should first try to use any of those. If that's impossible (or undesirable), please at least briefly say why in the description. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:22:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:22:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361421.590929 (Exim 4.92) (envelope-from ) id 1o8kNu-0001zB-K1; Tue, 05 Jul 2022 15:22:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361421.590929; Tue, 05 Jul 2022 15:22:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kNu-0001z4-HS; Tue, 05 Jul 2022 15:22:42 +0000 Received: by outflank-mailman (input) for mailman id 361421; Tue, 05 Jul 2022 15:22:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kNs-0001yy-HG for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:22:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kNp-0007Nf-Li; Tue, 05 Jul 2022 15:22:37 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.237.31]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8kNp-0008Uj-FN; Tue, 05 Jul 2022 15:22:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CT0jRXhP/V+o9hJqgm/YKU9Ye/Vq6p8b65JoOMwOeTc=; b=yTgU7dbf8iFL4Xzjmd+A3v8VIK /DslWuwqpnbk/d6hLLSPmjRDwvD0wkIo15M0tNaeKrx740j9Xwu3aFvEnE0Le7p11+I0hto6rVEpw 9KG9uET4B5vToMO93Pdw5u1tmybAWPo86Y617r7BP9v0sCjI3oz3RMJGt7DQdNX3CAq4=; Message-ID: <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> Date: Tue, 5 Jul 2022 16:22:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port To: Jan Beulich , Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> From: Julien Grall In-Reply-To: <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 05/07/2022 16:11, Jan Beulich wrote: > On 22.06.2022 16:38, Rahul Singh wrote: >> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) >> spin_lock(&ld->event_lock); >> } >> >> - if ( (lport = get_free_port(ld)) < 0 ) >> - ERROR_EXIT(lport); >> + if ( lport != 0 ) >> + { >> + if ( (rc = evtchn_allocate_port(ld, lport)) != 0 ) >> + ERROR_EXIT_DOM(rc, ld); >> + } >> + else >> + { >> + int alloc_port = get_free_port(ld); >> + >> + if ( alloc_port < 0 ) >> + ERROR_EXIT_DOM(alloc_port, ld); >> + lport = alloc_port; >> + } > > This is then the 3rd instance of this pattern. I think the logic > wants moving into get_free_port() (perhaps with a name change). I think the code below would be suitable. I can send it or Rahul can re-use the commit [1]: diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index e6fb024218e949529c587b7c4755295786d6e7a7..757088580c2b2a3e55774f50b8ad7b3ec9243788 100644 (file) --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -292,6 +292,18 @@ void evtchn_free(struct domain *d, struct evtchn *chn) xsm_evtchn_close_post(chn); } +static int evtchn_get_port(struct domain *d, uint32_t port) +{ + int rc; + + if ( port != 0 ) + rc = evtchn_allocate_port(d, port); + else + rc = get_free_port(d); + + return rc != 0 ? rc : port; +} + static long evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc) { struct evtchn *chn; @@ -451,19 +463,10 @@ int evtchn_bind_virq(evtchn_bind_virq_t *bind, evtchn_port_t port) if ( read_atomic(&v->virq_to_evtchn[virq]) ) ERROR_EXIT(-EEXIST); - if ( port != 0 ) - { - if ( (rc = evtchn_allocate_port(d, port)) != 0 ) - ERROR_EXIT(rc); - } - else - { - int alloc_port = get_free_port(d); - - if ( alloc_port < 0 ) - ERROR_EXIT(alloc_port); - port = alloc_port; - } + port = rc = evtchn_get_port(d, port); + if ( rc < 0 ) + ERROR_EXIT(rc); + rc = 0; chn = evtchn_from_port(d, port); [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=commit;h=3860ed9915d6fee97a1088110ffd0a6f29f04d9a > > And of course like in the earlier patch the issue with sparse port > numbers needs to be resolved. > > Jan -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:23:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:23:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361426.590941 (Exim 4.92) (envelope-from ) id 1o8kP2-0002X9-Vk; Tue, 05 Jul 2022 15:23:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361426.590941; Tue, 05 Jul 2022 15:23:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kP2-0002X2-RZ; Tue, 05 Jul 2022 15:23:52 +0000 Received: by outflank-mailman (input) for mailman id 361426; Tue, 05 Jul 2022 15:23:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kP1-0002Wq-6M for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:23:51 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140052.outbound.protection.outlook.com [40.107.14.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 78a8b146-fc76-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 17:23:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3384.eurprd04.prod.outlook.com (2603:10a6:209:6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:23:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:23:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78a8b146-fc76-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UlIkhHgHDR8dshoMEkic9yk8cvDG9p4cCRqxWyN65rV7CUfXNSb2Qatr48HFvpiEjs7fh8wyiimaJUbF3ByQPX9RxHrbElbGDBX3rSnIFU1j4gKvLbqJ7jTdtzsmqW9VkqIyvfm2GLkpoBY4JBrvCO35aLmQuBzoHOl03PEMhSlP6pEMWIWJ9T3LUZ7NLG4zZVfwdIBTfQfGklTZVKgIHMtP2jQHRLTIvj72cwjkaugHKdEZCclR+NIDgkvSwI0QIzMNPHIkd7bnGYmMlE7LFplOpAFrBhX8F79dbSDsVNZMdBOgFEf2kCg0d3JaUuvCu2Reb+TVWj57Zj4Da8kQkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Raser1oRMnDf3FnglMlwWsez33cNCo08a0a4RUiHvl8=; b=AHj3BZWz8cNZ1GoYHLMR3tkO4VG9Wujig/DeQZAY6uaHkUFakjeanjy4sCez3W67m0LRKgXSEO1ZyviDct5tD6YqnDhZTDZyJwZhgCgvoLyErG1rHCcDWaKrRoMyGmfmQiLulOGrBVN4Xa2eu5A/7El4Bg46xsCyacp7YXrgFHzLJcl8yZ/7GJ00AQ/dveZb+KoV1W257jrAfMCPmQ26dDQpR1YbZdsh8JvxNWUMGXYIo2ddYlVF0haZHEuix+dnQ5F+jVrz6zfiJGpgu7XSVlCN6H6+FsEmwBet372+iSeTVew1F3QxhgZPxrMleJDn939fWCRFZ3s+fOq4yeX0TQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Raser1oRMnDf3FnglMlwWsez33cNCo08a0a4RUiHvl8=; b=kTTVVUw0oBTlW63RDKjMay8x2DkpJ8oJYiFiUi2/cHe/IHKxAitv1+9wguzsl1fCLU77II3db1fL/hI58CMsQWI3bukFu8a1B7ZVrC8OXElc+sEHtEthb2wZC05j0wSsK/dcw5mAPti63YnNzKyzGwRT5vpQlwLyS90p1EbO0WHxDEk0ml1iV73XX1XcmABmh5VJhUppPSKGqdWrGtKDer8+MNZMDvj/pJK1aVWJjRa4JmeSYKIAXVpLe8KkcsHWTpnfuXr8w3JDkluivGd93BGwAoYRMOfljjkSRIXPd1TwUt4CxeyJXGEN7xzZoFz0pld2G/jL26PAc067eHwyAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 17:23:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 6/8] xen/evtchn: don't set notification in evtchn_bind_interdomain() Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <0cb096d37f2ac6cb7c5aa04cad7ad5377a0934db.1655903088.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <0cb096d37f2ac6cb7c5aa04cad7ad5377a0934db.1655903088.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e60f159a-de57-404a-c835-08da5e9a5a5e X-MS-TrafficTypeDiagnostic: AM6PR0402MB3384:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CVFU4bXi1EEsmq5qc64CXWpYhv3ekzmr2a+VPfycQMAaZi6ZPJgPaD2qVgDbnon++twU9fjRgm7XKQwVMJBMm6NOhkbFUmOwFC0jAeQG3I6Ck5mO7S4S5L2M3n3wn2a0cTKzaSKUnySib7HIeX3PkdZ4QDcrreNm0Kt9lv4oi2N+ApAfni1yyb0ciTQ5FFLGZrrjih8/KIUyV7PAasL6MUVqw9rOfy+qTR84aDSG1k/FIXvMwN/a/8a6KP6ohH4W/zm5U7vnYs9W3+UUoKCnwm81M9nHwYkpIb+xqZ5GEKcL6L/pBeVyPz9gNEXT55bWnhvKgb9U74EP6OazJf0W2T6fxetx33QSfLJT+Zgz4T9moJTeKmsr5z84DPdbUimnbPOiLzjYP/C4bJ9FRZdfyabVUsCmc3CJGv7ZortG/t+C54GgtzzeG714wpBiZgHzUAgKzRki+/6EyuPUt/HM+QumbRV/m1ik+UFoXBMLZFjsXIvpHzOyuUezxR0p+wRlzbw9o25gVB9IBxXgrBoecAc3c8j0JgasFnWffRH2//TftxIVo/p2oKjF6Nc+o/UbX+T4n0/rYRWOAzZbTR3ugRQIN+vpT6lgjrXGqBaX1DuAhU9GFraoGSPaB2dycxLa62KCxmxBcntkI9Jn7rZQu08qjRE36cwsd4RLPJNyWpD5+Xsn6kzu1VFL0bF2npf5lA+bC0V0/IPRqJv/Ub7qSOcWfaMbE2ekgxNT6fcm3aDoKmJeheBLb/YTCcLeJRToiEPHsBttqxWX7tUn3Lu6UoNEihnSqxmSiMjnDK6J9qgY+FmB1bOZOl5WeqMVobGbXSgRWnNgNURlVURMNxjgECbDMoJF5HTek3nQkeXsIeI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(136003)(39860400002)(396003)(478600001)(5660300002)(4744005)(66556008)(8936002)(6916009)(15650500001)(54906003)(8676002)(31696002)(316002)(6486002)(4326008)(66946007)(66476007)(86362001)(2616005)(83380400001)(186003)(53546011)(6512007)(26005)(38100700002)(6506007)(31686004)(2906002)(41300700001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QS9FR0xVNzREOEttTVduMlRsNXkrQ0Q5MGUvSkJ3bVpEeHhPaFRnbDZuWUZT?= =?utf-8?B?M2hQY2JMM0c1L3p4dkJXRWxDdjN5QTh6YTdWSUpNejlpWEVQTlRXam5SUkJB?= =?utf-8?B?V2hnd2FnVFJQTGdOZjVTQzNSTzdOUndxTkMvZVJneDNXSXU5NjY1VW1NeVNs?= =?utf-8?B?eFdCeHphdHJzdC9Xb1dhUDVvY0RDMkFVaUdrK2xYR0JxbHhXL1pzWVdXWlNq?= =?utf-8?B?SnVCQ09tZkdTaEk5b2RoNUxHOHZNTHpuT2RkQTRKNFZYdWlKdWtmeThmNm1a?= =?utf-8?B?MmNpY2NuT21VSHMvQ2l5Z0tpZCtvVjhVdUNuOUtCVTlXN09JQ0VGWFZPald1?= =?utf-8?B?NTk1bDVHNzdqVDBtTW1oMkNJL2Q0K1hmSitBOXZiU1FIRDhCaWl0aCtKSXI4?= =?utf-8?B?RmpGTTI5NTlsdVpISlZwNXVUcEk2TUJidSs0QjRveWZRTzlnWmtNMjhPUSsz?= =?utf-8?B?SHE2MTE5ZnZ0WmNadVpDYUdGR2RaUVJtblJKOTZ1T3NIVTl4WHMwL1Z4NlVk?= =?utf-8?B?YTNaaFgxcEYzRnRwZjVwOFErWjhXcEtnMlFHNWdkRG5hSjFBNnEwam1EQktB?= =?utf-8?B?L3Qrd0tDeGJwbUV1WjFWaVlZZm9rMXpsZjN6R2x6bk5EdWNHNHRrQzRJbGV1?= =?utf-8?B?NHBydlZpZzVacVFpelBCZ3ZKYldlNGdId2hmZkptR3Zibi9nQk9hY2c1VDJs?= =?utf-8?B?VlpBVUloWE81Y2VhNkJ4Yy8vSi9nQytvTmpETWtqbHVZMVJpQzlRdmNVT29L?= =?utf-8?B?OThPQUd3d0VMbzc3bFBrelNndGVaZUNrZ1d5OUJLa3ZTNmJSSVJQajBzNlJK?= =?utf-8?B?WkdFWVBkSndpWURIZXRESnpEeXErYUhja25zN3MvdzVvMTNYVmZjcVJIQnhT?= =?utf-8?B?RnBTeGhsdDFqaEliTlp5TTRhZldESU5FMnAxUGtPbXhVd0hxd2V1T1NpVFYy?= =?utf-8?B?ZS84ZTVFV1JVdVpqeTZwMzJRTSt3ZFRHazdVV1pWTWNhU2lOSnFzclhybGRi?= =?utf-8?B?WmpBZzZ3YnBLVWdWd3pNL0FJb1MrMWQzTW9LNW5NM3RpMVduT3QxZ3B1K3Ru?= =?utf-8?B?YVlpZ2xYL0c0QWQzSUpvNmw1SGtMSVVtYnpxcjhYQzdvbXRka0k0WmlWcWFK?= =?utf-8?B?SmtHbkVNNUNrcUVSYVdjL2pKeWlCU1VlMnRJT0xFMVEzellBaWFJZ3hSU0ZD?= =?utf-8?B?TEF6dkZ2cVhlNlJXS0J3K2RsejU3OHM1QlJWbzVuc2RCRTlOb0VwZG9DdDBu?= =?utf-8?B?bTBORFRYUlB1RjJ1bEtiSlBYLzU1VSs3ekpCbGROUWpJRlNXSDRYZVBsck0v?= =?utf-8?B?TCtjYzE5T3JTMFk3STg2MlphcDFuYUJiUVhFcVhVSkVlZHMyMHo0U2owNkRt?= =?utf-8?B?Rm91ZzZrNU94ZkxQR0w4K09qQzJyYUw0K2N3YXN2V0wyRzluRWloOUw5ZzM1?= =?utf-8?B?RmlRRnlwREFMNlJ1amxrWnNXcTArZy9PSU1rT3Mzck9tVjVnRThPQkRtUkNX?= =?utf-8?B?MFpScjdQZHZuRG4vVWJTVXlrL05OL1lXUnJsNU03Rkt6VVY3ZCtyZWFYMXRS?= =?utf-8?B?bGFSbDBsWStibSsyclVUSHNaZmYwaDVYMlRyMDZONXFXRXUvVkdNckg5Z0VI?= =?utf-8?B?Y2lIeXlzdUsrOGZlZmp6TXZxMnYrZzB5WllHWUFBbi91Z1hEMFVHSHo0UzR0?= =?utf-8?B?eUFxaVVnWElaZHFYQnJ1ZHpYVW9CUHpvVEdSRFpNUlBUS0J4V3ErT25yalZw?= =?utf-8?B?VmpkWExLQzlxV3BoY1Q1blZWaHIzRWVkNXd4eFNPRjdkdUNIRnUvanlONk91?= =?utf-8?B?RDE0d1pnVzF0SEJtK1FzUzBBdzRONHJicU5mSitHQ0I4Skl4Sko4UVlRNDFR?= =?utf-8?B?Yk1ISk9YdVgyQmQ1eitQbHo3LzdGTFJVWkg4bTBGeTRDRDNyV3hwSWdCUTgy?= =?utf-8?B?RTE3WG51SXF0eWtFUVgxM1U0Vmxvd1JxbSsxYnBYbC9mQWxYaHI0d3FPb3Zy?= =?utf-8?B?TXZuQVdPRUxITnY2dXNKenY3bWhwNXNmbHhCNlVUd2tvZnJxZURCRk43YmZJ?= =?utf-8?B?bWpjc1NQeTh4VXlJQkdOVDJzN2hkWWhaQXhOdnNqTVJ2ODI0UnYxRmU5MTU2?= =?utf-8?Q?cdAh12pcCp4uEl/Kn2DZ02JlE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e60f159a-de57-404a-c835-08da5e9a5a5e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:23:46.1732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7Wl/4JjcR2uqR7kzy2MUnLMhx4iJ4kU3x865YFxc/sxUzxuhI3n7DL6lzY8GiAaRkpwO+GFFysUOGORxDHEWPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3384 On 22.06.2022 16:38, Rahul Singh wrote: > evtchn_bind_interdomain() sets the notification on the local port to > handle the lost notification on remote unbound port. > > Static event-channel will be created during domain creation, there is no > need to set the notification as remote domain is not alive. So _both_ sides are (to be) created by Xen? I think this wants to be an optimization _after_ the new users have been introduced; I don't think the excess notification is a problem? That way one can actually verify that the uses are as (at this point) guessed. Also the title shouldn't say (just) "don't" because it skips the step only conditionally. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:26:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:26:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361431.590952 (Exim 4.92) (envelope-from ) id 1o8kRY-0003Bp-BQ; Tue, 05 Jul 2022 15:26:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361431.590952; Tue, 05 Jul 2022 15:26:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kRY-0003Bi-8Z; Tue, 05 Jul 2022 15:26:28 +0000 Received: by outflank-mailman (input) for mailman id 361431; Tue, 05 Jul 2022 15:26:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kRW-0003BW-Tl for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:26:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2089.outbound.protection.outlook.com [40.107.21.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d50e0ec3-fc76-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:26:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3384.eurprd04.prod.outlook.com (2603:10a6:209:6::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:26:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:26:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d50e0ec3-fc76-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XJ28TGfPqxth5vtV3hw2byKK9ukTOcyQUj1wysb4JF67fVFK92ZrkAFKKOUAkcsudoqxeEXU5YBrzVejFy75hKmnzu+hwLST9WCRvTNx4J1oUdazyNPdXeuAb4/FpG6tIGdbc+heE2HafhZw0HorQRAvwY+oHMtqZVVl5cZR3hXeoFrZtgIaCJArwTk+Oy9T47os1Hq9oFw/1lREwPyYPppERskI46SLbKqlHXPEwKytcWm/h+zV6M9PX4AWIGeAtrAb3NPHzsA8IHLM2v5YDbNkOa9lY+iXb6nmiCzbQzuwWxxIe4L2ibo5oCr7YQQunCL/RzqUxsCQSL+4WSuT5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N9Fum4iO+jl06LBYo1mVpIcFvFCt32NSuWlXNSILZq8=; b=GE8NIm3LXyi6Y8vKFx3cicRiMWcL9R2wkFvMqadBbGEaE8W/Pc0KYoojep4/8JkV2eZcnAyojiO2L8/R+2A3MSNmJYsKT4BiD5qTva+RpdKjoRAJeeUZ5eco8lv0hifNr5qmtiG5zf4XPEcd/uoG/A6tUci+A+3NHZ/qgYmZYjNNSkjlEvoWm2klZfH9Ow8YXkOzVLBckbN9G3QX2MFwodyno3tocAs7f6cUiG/Wps9S31iN+/sQue96coiFBGJlAJHSgJXOVp48gC26dik0wgjArROnyRVIavDJAaZv0mkdfS3XUC1hDDA+v1R5t6T6haido2H2kyF5W5fSKAGlFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N9Fum4iO+jl06LBYo1mVpIcFvFCt32NSuWlXNSILZq8=; b=LnQQZ6ncmm0ub7ap25CLjYtanQEuYWIjCY8UCIDkJD6sCAcpAHlwivVR8LtJ2c9G8x70Pf9xT9cnl25KEP05vOonm/AFZ2j2gAyMLvl7VS9VXeWdDrxDiyqZwv8pUNd8rAVEQqBT3K6V4DxNbwTz3tx1GjG6gVflG5VQE3M0Y9GHoklK6/ZkCNkobAju0TOhaO93fl0N1uRp2qgeISVo+AuP+kO4+Ph4yLHimRe5u4bI44r55JmOkT+1qm5wf1M0Pr89bG9Wi0QdwfcDxRDcty8bobdkx2wGXKPPC7uSz84s/xzTIJXNG+ssEmkbB8Zp8avVCiFWjX+k8xwI9V8Oug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <164283fe-9623-b2e4-3c2a-13aecae5a638@suse.com> Date: Tue, 5 Jul 2022 17:26:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Content-Language: en-US To: Rahul Singh Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> From: Jan Beulich In-Reply-To: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0138.eurprd04.prod.outlook.com (2603:10a6:20b:48a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abd88571-1095-4ff5-c1bb-08da5e9ab849 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3384:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sbsn2TurDOs4raPtrmd1IFS9sQaOX+BxdfvOZ9a5hs17Niai2Nf+c6ZzBkXRuu6fG2cN6VwpWHVZF2oUuJaWKhLurOb0KdviNfQP0T0yGDUjZFlkM7/xawc409qY4uVkAQY+yawPq7YLiMXJZS8It6JMULhJ1cF7c0Wrgh89GM2EXOri2HRitBUsIZH8IMvpXvMnlVfXNl+7jyubCLYQ3brxLyftCZT2HgANfyEdjYxBd4mAf+1CK8w3r2r2orYMR8FxORBtPiIsKUcQ4vr46ph81H9IzMnarFNB6nd1UDL2GXOUzXdRwkFQ3xNepJKnVghucp2e9mWVKozjWmlhWeJNiOG4gol40umDtUa9U7qUH1qVO1jtvpoCs/HaomNw+7ShB7f33N5mF7Dd6bwJQ1LeKDWg+qt7GsiiVm2RoKuppxMJ6+8K2sk6MkpWn7crt8UKX9TrGyzUM63W6WmUPHvlNYIfFHR+2L/Lg0s//+XXeHMkOU4eTOmTp8//VoEta+5WYsJk4Ijp8asiVH/NuYFHVFTX1xzpwWFnXo/OxUDuaYDWwdeB7A6K+SePCiUJ5QXXnI9RpKo2cYlI1ksfv3GwrkGWWDagykws8Wf4UHx2WspXAdyiO6mDUN/C/0UAVP/Gv/yDHrG2h4bzXKvAv/AmK3dLtROWA88cP9ufFNuUua2moJhW4WJiLNmhrzNkvU7lr4MfYe6vJYLoYNrNa/UKLWEbeyXfuNAlqhXuRmPES9gLURIilgDrFuvZg/yQNZpEcf2N9cL+GW/SaUvnSFF/7TY7G9/Vh0faKMTX9PBMpTZ5HH/UDrGcgW4vmlE1e9bLtxheytyAvLIDG2vD31QK2mEIwQAPc5QUcIFaXLk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(136003)(39860400002)(396003)(478600001)(5660300002)(4744005)(66556008)(8936002)(6916009)(54906003)(8676002)(31696002)(316002)(6486002)(4326008)(66946007)(66476007)(86362001)(2616005)(186003)(53546011)(6512007)(26005)(38100700002)(6506007)(31686004)(2906002)(41300700001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzhPN041NStkRkxSQU8vSkFoenAvMDZmenhQZmJjT2pYWHljMTNNM0VRa2w4?= =?utf-8?B?Z1M0VUxVRHFmaFlpc1FmUG9uaXdjSEx2bEVIeS9meWJ0TE5CU1l3Uy9uUEEr?= =?utf-8?B?RVJ5N0NqaWFiZnRBMG5WTG5ySThIU0N3OFdxT0xTTVlMVzlhUm9IUzZRcmdh?= =?utf-8?B?ZzR0eThiODJPb1NqVjJQc2kwejhMcFpza0FCbmNtb1NsMGZiRG1jN0NaSTEr?= =?utf-8?B?SzA1MWpNUHp6UUl6OWg4OU5wNGJpOGQrVTM5Q2hTdTE0bEhzbC9VamRCNGEz?= =?utf-8?B?MndMS2NDNU51aE5qOGlIN0gxOU56Q2dvejMzZVd4cVVsaFcyem1BZ08wM2Fl?= =?utf-8?B?WG5QVXNXYUhPRWFtUElDcWVOTTBuWGVyUlRHdkY4a2ZZTko4OUdWaWFyZm1o?= =?utf-8?B?dmtWWjlLYjUvRlN3SlozWk1wQ2o4WkwyQ01NU3VMZnpReURjbDlNQi85UUpQ?= =?utf-8?B?REFxNEo4MUNXbWNHM3dnODVIbU9zZUIxemVsRUtleXo0bFdEV2l3bTdpbDZr?= =?utf-8?B?R00vV01aazJCOFBxNXh6dEhZOGNtcUt2MGVUMmVkQVNMTmljZnZ0dWZnOHdG?= =?utf-8?B?UWUwZlhUWDY3TnRyMnJxakVBbjJrbUwzUTR1c2RXWGpDQXhkcDNubmRWRFE2?= =?utf-8?B?Vks0dUV2UzlhU3NhM2lMV0NyMDJqMENRM2RNMDBhdUVhTE9JQnNwcjdjN25I?= =?utf-8?B?SG8xckFHRzBrWFR5WldJYXpLYlNHazQ0QW4wQXJzeW1qT1pEbnVZOTFIYi8x?= =?utf-8?B?YlBiUVYyVUxOcmErRkc1aS9zaCtRQkJzN0ptRVlER04xYkxHUlMzL0R3L1VQ?= =?utf-8?B?YjVwdW9jOEp3dXhzQ3lla2NzeFZkMGlmdWQyVGxvUzB6cUFFVVZhM1NwLzJC?= =?utf-8?B?VXFhUzNRY1NwTFh0WmxSSmJBRkpqLzhCRzF6Rld1VWFkc3NtelVVMHJvbHRu?= =?utf-8?B?VDlWaDhtZE5sb2dRek1PMWs4SWVyN1YxUXJzSTRoNkwzV3pnSVhCL1RSVVp6?= =?utf-8?B?VmMvUk1YM2d3Zk5lcjZ3bFp1b29iUS9tdDYvcUt5TXdjMDllMkRXaWFvZ1Y1?= =?utf-8?B?WS91U2RBcVdoZmkzZUIrdnRrVnNuM21QVFlINjQ0amdwOWsyU0dFM3RKajJZ?= =?utf-8?B?SjY3ei9QRHNyYTZ4QVJDbjI4bTZMdUxRY2ZRYml2VlhCK0s5dys2QlovdTFL?= =?utf-8?B?SXhzcUgyYzZQYmo1YVBTNm1lRHQxTXo3eElKZlBjaHkrbHJQaGpaNHh4bWZ2?= =?utf-8?B?cDdkSDB4WUxmRjhOYWVvZDB6VUEwUk4rU28zRitlQzQzZDFYUVBtMjA2aVla?= =?utf-8?B?WjBoKzRMSlorUnN5OXhDSHE5Z0tHT3F3RUVRUzArcXpkMnBHNEVKNXMrSGo4?= =?utf-8?B?VXdFUFVHbVFSTTc5Wmp5am1oaFRERFhIS3lHWGp0NVpyNW5NQjBhbzhIMkw5?= =?utf-8?B?NEZHWS9lUVJsRUFLNUF4ZHNXdXA5aTUvSmVuRnpLUm5HNlpXNHJKREorWlpN?= =?utf-8?B?ZVQ2N3Exb3NoK1AvamNuZ1Vmd1VJekh2cjB5NzBJdXdDbnR4Q2JGZnBpeFNl?= =?utf-8?B?dHRzZVZIcFBKMG5PQWh5K0NmK1ZIT0xWaFBxU2FIQll6ck9jWmFsUjVxNXdJ?= =?utf-8?B?WHdhMTRNaVE4T1R0QkNzdDhZcURQN2xiVGNkaWNmUnFCYmxWd0o3UGxwUSt1?= =?utf-8?B?ZU1uMUtsVDgvRHBOMEJsUzlFVjNpTWs3dSt0Wk1YSmZRNWFLTEhVZnZFd0lK?= =?utf-8?B?NThCS1RxZTRHRHkzUS9hcm9FR0hkUktGSW9vckZOczlWcWtIUW96eXRXb1lh?= =?utf-8?B?dm54M1NwL1lqbTV3WFlYTWc0bnJ6aWtHRFFicFJlalg3eWdyK0FrbmlnTTdJ?= =?utf-8?B?bk9TSFd3ZWhUVk4wUWxwREt2THNqT2s2WmJCKzR6LytXd1NQaHhOa2dzVXpu?= =?utf-8?B?aGhuTlFyQ0M5VVRFZ2F6UER3TTh2U0MxNUhUSG1NQzdkMFdydVo2ODQyMHpI?= =?utf-8?B?SkZtbG9xUi92ejVhdzh1UG4rK1E5ZGpqV3lHVkZJb0dSMjlRY1R2R1FxMEFi?= =?utf-8?B?L1BFdHdsaExXZFhyK2hGM1FSSlpMa3N0Z3lyaFZBVDJRUjRqUzhXMWNjeGRp?= =?utf-8?Q?RAqPcYS7g2ub3ZPQKbAyLq5KL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abd88571-1095-4ff5-c1bb-08da5e9ab849 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:26:23.7724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gAjUA5v84D3MCOWi1B1G4YX0sZUo6evHyYTiI1Ay2CyFWK5GFxAJmVhaH3haO5oTLQRq89oFOqvoDvP84iGUlA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3384 On 22.06.2022 16:38, Rahul Singh wrote: > --- a/xen/include/xen/event.h > +++ b/xen/include/xen/event.h > @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int port); > > /* Allocate a new event channel */ > int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, > - evtchn_port_t port); > + evtchn_port_t port, bool is_static); > > /* Bind an event channel port to interdomain */ > int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, > struct domain *ld, > - evtchn_port_t port); > + evtchn_port_t port, bool is_static); Didn't even pay attention to this the first time through: You're again touching functions you did alter already in earlier patches, and with them their pre-existing call sites. This is not only unnecessary code churn but also makes it harder to follow where a change came from when (perhaps much later) using "git blame" or alike. Please bring these functions into their intended shape in a single step (each). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:33:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:33:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361439.590963 (Exim 4.92) (envelope-from ) id 1o8kY7-0004kv-2i; Tue, 05 Jul 2022 15:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361439.590963; Tue, 05 Jul 2022 15:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kY6-0004ko-VI; Tue, 05 Jul 2022 15:33:14 +0000 Received: by outflank-mailman (input) for mailman id 361439; Tue, 05 Jul 2022 15:33:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kY6-0004ki-9o for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:33:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c800482e-fc77-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 17:33:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5230.eurprd04.prod.outlook.com (2603:10a6:803:5f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 15:33:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:33:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c800482e-fc77-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksZRUE9nK6L1sVZcdJliFFURnrcs9hG4BoSwAGgFj6npe6Mm71mq+zkPzJd92achHKOEmy8Ea2Fm5V4JrvP/qBY6Accrqm4ViOWxGP6GOiQHQE3njUKrmBqW9Fvd7H4kYtx6w1nc8uWJYjfKbSxytfQa0M/mlVnQk1Ygv6WQAbOVvsxT98dPUhjskobXPHNOfnii2m5ekrAK6kWK9z9QW+gjU5zCdn9OYrkJBtHn93fXsBAkYdFAIIVQdJ+hwzOFjVYuI1dgqvrtmSlYOQIhJN0HY5WS7BUn8ILG9jW30YKYh01JgRvw02zhDMCN2v9jjLwBggEuMk5SmNg601wYvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gMgqu4f335Zue4vhz33R3R//xB2cBoCpftUaPzU/Ubc=; b=hRRKK7bDnZzXF3xXV3RiOYQ64flRgEN6CaxMPi4VdvhDHbwGmwSnv2FWPV/omKlNCnOtxmSQwDFaPW2aUSunIAS8aPwS+ZoNVphoxDmTJORAODG3UyUVQsASZQ316l3Cv4440yH6Y/vKQzhJpb/EN2sp4qQmoDgvQAc4OKsgRW33AqE3orGjoRvuhKCISMppA/OV1+U8xz5EgN6jDP7U6zB7ZgI4uIjhr2PJIIS5HqGFN0RTjQssU1Vi524qvFBqcDOH7jqvqGYb66J4UVPL+J4GpVQL4qhN6SOP9LLnclKfYGT4ZSrPuNMBKOY5lM+DvFCL56B+U7FWgFPKMvfuYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gMgqu4f335Zue4vhz33R3R//xB2cBoCpftUaPzU/Ubc=; b=ok8qvJOT4sG5kIjmwwl809mxLbZROkiDoy1HUX2zU4u5AWk69jedxQgVjxM/Ctc1FyL8qMOnllRCKtnK7mBDMFoaG5V9TsYZ8D82+CHfui4aBhr8pH1xPLu+pqaislDO5nDuG1oi/4jDIjRo0okFzh4uPWnm8p647Pd5RnUVBO/rbbNB6YtONnQnjrrKvmxEGd2znRPLJTOcpwjXtAAIa+4Fyv3bc1YqaSO0+Az8IhY8hgDV4xN6TJaDQelJnL7aLmyAWw80mtWKX718UocOP5zTjp6i54ABUOWxZPJb5hWGe3qcaG5vC8EXp6esaIt1/VHLpnBwjQryuZD/lzQAAw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <593ab626-63f9-85f7-3ba5-d40f2c9bb28a@suse.com> Date: Tue, 5 Jul 2022 17:33:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Content-Language: en-US From: Jan Beulich To: Rahul Singh Cc: bertrand.marquis@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <164283fe-9623-b2e4-3c2a-13aecae5a638@suse.com> In-Reply-To: <164283fe-9623-b2e4-3c2a-13aecae5a638@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0101.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:88::42) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bf118381-631f-493c-51b8-08da5e9baa50 X-MS-TrafficTypeDiagnostic: VI1PR04MB5230:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bH/GfdguUhUnEE4rt7FQ/27zHxVbUtHNyj/bQRZN/J0MDOKKqx6MExLyCggrrZqpIRC3Z6X8S2WDfmk8fYFLQRrmhijct78MiWCbb75wAc6ur4Ib9KATnSCJmzFhlk1WOLkG0evCGQh6c0hQUW410W/hyIilbl897LQlKAvp48Ne4vwBHQ8+Xs7isv5qrMbPtnQfaS6YriFSVrftRgEerOQiYKxvRcdlefwAjrkbaGTq1O1luzp15nmltRsgzOhwsEh1H84YZ+MH37LLDlKUGTMNA41wq/mJXhxHQqBv7mPi0ZbsMUGqen2SMtGQc7h1P+BntZZZVam5HRSeukItgQYU3ykMGq1xBzSfPq7coZi+xBa1jBSvGcT3HVDAiC/6xXhf/xwQajDzSRAn6pTDpi1OY+f2gdvyBLWlqgJVPjvNhsOIp9tM3tRfkWtzXwroXaUjFxxKa/0VhionJTB/qNwU1B5EVW+37E5e+agy7zntcS/NT9f8xetjljQB+yYIovKrPOoj5p0UJnC+8IrrdCB5ur1+byfA0RYYhgZKKC177reIjKev76b02y6SsZuFCZc/rVuQ21sfxhqgsvZUAfvqGCNk1bb5qhxaWvKDL15B09Rht6YJplQpX4ldB3mH0hRM8g0Q1aFS4r5vmeYMR7GceuGs+WWzdKgIJA12PsM3fBl9rPpe47ojKqIhkECf76bC7JmrcO5sRVsIJoS4NNoKTcaqcMUqTrwwdfcX8N5aLzTWf939F50NWAAiZ11J9n7ECUbAJJYtr3JjbHJlqPiDxuWZtta2r3dX1aTjdCl8qK/jkpAlH0zx7Fqz7wYx+ex9t6wREPSUeThTq/WXGt1QrsP8vdUBgJX6FHFASis= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(366004)(376002)(39860400002)(66556008)(66476007)(66946007)(41300700001)(8676002)(53546011)(6506007)(38100700002)(4326008)(186003)(86362001)(8936002)(36756003)(5660300002)(2616005)(31696002)(316002)(31686004)(6512007)(2906002)(6486002)(478600001)(26005)(6916009)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0xpUjBMekQ1Y1kvZXE4am1mSG5TWVdKdVRKQ0lvSGhOREdLcXRHSHBuYWZJ?= =?utf-8?B?cFE5L0tFZDBEWm5GNTRFUjBORjBicHdTcmZqcVhMenlZNW03Z1lUUVVBM3E5?= =?utf-8?B?cGo2YUFhYzlTZXZyV0ZKNDA3c1dkTWtXb240Q2dNaWtFR2JvR25VaUFZSk52?= =?utf-8?B?Ry91YVNKYzBqdWdnbkFMYTFzamJaQmZIc0pLQ0dIaG1vZ0F2bXZUNzhOWWJ3?= =?utf-8?B?MkhlclltMnpWcmhIUW0ybkFRd3craXlIUlgwRyswQkJ6MERvRjdVa3BkdW14?= =?utf-8?B?d1ZTZ3c0ejI1WklmNkM5cGpOcnJxSUlZWldubVZRSmZiYWxVZktCT3BsQ1RZ?= =?utf-8?B?VjlpYk10VjRyblRZaDZqb1dBN3RXeWQ0WTZTbEh3SGs1U2Z3bi9KQTRsOUlT?= =?utf-8?B?NE4xN2hvaGpJZGNiM3FFVXZ4N29uK0x6NmxzQnVTQlZ5SURvaXBKaTRTV0VT?= =?utf-8?B?T2Fub3dhcDZBeENnVi9QVmkwU0x0OWdzRVRCUXFzYzJ1V29ScGRBbnpITDls?= =?utf-8?B?bkVnMzZ6dFJ5SDROOUorTHcyMVl4eTZwOHZ4ajh0MEgyaUkxTmR0bXNhRVUv?= =?utf-8?B?MTErcUFDa3k4NHlxTHdUR1BXTStiZmRnZkVYeVhDVTVRK3BnMGhYYUtZQXlJ?= =?utf-8?B?UVlEbE1LVGZNRll6Nkg0cndLOGt0Z0N6RmEvWjZLbVBSVjV5RHgyVUNkNEN4?= =?utf-8?B?NFJvTTIwTHQ5WUpFMmxLZ0lOL044VXdKQVJoLzdUa2QzYTI5ZmFhTXF6L2pV?= =?utf-8?B?czZDNk9pMERia0RlQWg1STI4azYrS3NnWTlUZGR6RkQvSWJ3dUw4SWJrL0E3?= =?utf-8?B?djZhd1NOS0srWlpwams0MTZsOGtIRkdNa0dJKzMzV3prRDdxVTE3aEtPY0ls?= =?utf-8?B?OWFlWkJwemJ2UXdWN2NBanY3M2kyaDhiM2dFNHMvMW5SSUNXNHdxWHNEWkpZ?= =?utf-8?B?Um9za3hYamF4dnVmYzU0bFo3cGEvTUI3Vm1adUZaUENIYXJGWkdHc2ppVUJk?= =?utf-8?B?eHh0cTdGekNZcVN3c0Qwb3p1OEMyVkNxeWZ2ZWxjRVk3TkpoN1ZGMlhFNlFw?= =?utf-8?B?UTBxZ1VySXZNRklCVXUvMG1KakVjRXJDcVEwQi9GdjNIWHgzYXlvemU4TXBR?= =?utf-8?B?ZXdER1lvdlQ2WGszWGJqOWd2bEZGbnZJODZET29Sb0xpYzZNNklZQVBKNmt0?= =?utf-8?B?cXFPYVpaK0MvRWNmdFM4d0p6MjYxT0ROQXFybzFlOTFhaXlPTkxLb1E2UHNG?= =?utf-8?B?RS9nWkpzTitQUU1RQncwL0FKNysxU0t3UkNBUms3dFQyZ2prRXVNbnhXTEZB?= =?utf-8?B?RFRpblZhKzkwRm5rSzVKd0s4VjN0QmVYcEVyR3NwNFI1KzRKZk9lUWNIOFBu?= =?utf-8?B?U1lXdm03ZzFhUHNEa25kVXVmSjY1N1RMYXZIS2JJRTR4WWI1aUEvRVB4d3g0?= =?utf-8?B?SWVSSTNOSFVIdFBFM1g4cHBpM2VkdXBGZlJhdU5TRGNBc2QrQmNLNjN1MjZN?= =?utf-8?B?UmpXN0pxMmVwY0R2M3dvZkR0ZXdHUmZGckwrOHpnaU9udTAySURaTUh4OFZG?= =?utf-8?B?QWtwS2xMeFc4M1BmTjM0VG1tOWFxMHVlNUJjUjVROTJST1kxQzd6S25DSFpm?= =?utf-8?B?L3BvK09RcllKYmpuVjFTcmJkT1p5d0FaaW4xRVR0bDA1MWpRYWtsajFsRlVh?= =?utf-8?B?L3VxMkhKT1FzcHJWdTREZnhESzg2VTF3MVpvNWZVdXVWUzZDUGF0TjgyODd5?= =?utf-8?B?RjdSekFEVnYyWkJCSlM1UzlhVitWckt2Z3VDVnhaZEozUllpTDI3aHNFQ3lP?= =?utf-8?B?SS9iTTZUUUN4SWg3RFR5Y1EvY2lQd3BIeHRvcDUwSE5lWWVUTTJXRFlYM3ky?= =?utf-8?B?Q2lETkNSNWZxcEJvbnVneGZGcWNXRCtnQVUvSFV6Q2I2MTRuRnp3Z2tvb21X?= =?utf-8?B?clJPNEdCMG01ekRLU3BkdkNPczl1aVM3eU5XcHZOZlZUL01RQ2RBMjd4UFVS?= =?utf-8?B?bHlYbTNjREplZ1k4azhpTHBScnU1NllHUTJiY2dRYmdGSElZSUhVazYzWDV1?= =?utf-8?B?b2swVlRMVHhmbnBZVkIxTmNNeklwWFZZMVZkVUdSK3Fac3RYcHBzeG0vdmYx?= =?utf-8?Q?KUmb/R8XBErtCeETZR9F2ppJB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bf118381-631f-493c-51b8-08da5e9baa50 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:33:09.8553 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jZXeAe7iMzbJkRPXQ8AGbDpemQ5WxG6OzPKaAz1lU/EmSCfzMjcKtCUoDb26PtkhX19tu61c/0CUrNNQz5i2kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5230 On 05.07.2022 17:26, Jan Beulich wrote: > On 22.06.2022 16:38, Rahul Singh wrote: >> --- a/xen/include/xen/event.h >> +++ b/xen/include/xen/event.h >> @@ -73,12 +73,12 @@ int evtchn_allocate_port(struct domain *d, unsigned int port); >> >> /* Allocate a new event channel */ >> int __must_check evtchn_alloc_unbound(evtchn_alloc_unbound_t *alloc, >> - evtchn_port_t port); >> + evtchn_port_t port, bool is_static); >> >> /* Bind an event channel port to interdomain */ >> int __must_check evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind, >> struct domain *ld, >> - evtchn_port_t port); >> + evtchn_port_t port, bool is_static); > > Didn't even pay attention to this the first time through: You're > again touching functions you did alter already in earlier patches, > and with them their pre-existing call sites. This is not only > unnecessary code churn but also makes it harder to follow where a > change came from when (perhaps much later) using "git blame" or > alike. Please bring these functions into their intended shape in > a single step (each). One more thing: Especially "bind" now has quite a few parameters for which without dom0less (i.e. particularly on x86) only a single value would ever be passed. Without LTO the compiler could still deal with this if the function remained static in all non-dom0less cases. Please consider whether you want to do so, or whether you want to find another solution to address this concern. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:42:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:42:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361446.590974 (Exim 4.92) (envelope-from ) id 1o8khF-0006Pr-1d; Tue, 05 Jul 2022 15:42:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361446.590974; Tue, 05 Jul 2022 15:42:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8khE-0006Pk-V9; Tue, 05 Jul 2022 15:42:40 +0000 Received: by outflank-mailman (input) for mailman id 361446; Tue, 05 Jul 2022 15:42:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8khD-0006Pe-BF for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:42:39 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18dfe85b-fc79-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 17:42:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3015.eurprd04.prod.outlook.com (2603:10a6:6:11::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 15:42:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:42:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18dfe85b-fc79-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkMkvTyxZ7iPYSI9fCxinYW99A5yBi2zBEwzcXMOadcGHL5aWHtjaRfHxQ57ms521Xb2yfosDohTJ0qsPdCArSDapy8tTvoMLs0bPRD+y/kRwrW4Dc5z+WgdSMRto6AgU3eZBD7JCq3nfk1fBZv0IN+jeI6MHSLd6Ms1s0/4Sb+0KQk1d4kLBZbozdcUVHwsAp6CZbNWsyX1iAqWXY5J6wcRSuwL4PnsgpQONpVUSMCtCrhqOMAqdEZ7kNwxkb3jCcjDROfinXvhq41fiGOHCHopWSqtVu1EZICOKLnCnaSCyiuKQTyOGMfVGFIvP9qc+VhL9IimEWlALDzTWbwJIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M5Dthn4IsHHsOh7wOId1n8WrGPsprAUglgudlnB1N6U=; b=AoVQGGb1GoAfDtkvQ0rYA2zEj1udLrVqWDP5I56e2nkcT5b0UqiiPvYj/sUETDmL3bcnYeG6Ke/tbbTFQZZeOJga/z4U47GZiv1TRcl3nwAxS0PX9aYPcocoOrqw71z7o9Ojf80fYK43ckiY2nZ17as7K+kLUfRhTzQjvnQU2hpRfFmrbWWCWBT8w3lfnnZQLSbXf9FfCoWklyBc5Kdx3Zlq4YffVR5gWyxj3VOx7GBFH1NthemcubYQnrz5SfUObmfmGaVAkHr/13qgHAToJaOW0Uya/t0yGeFlswRksNSfvQ+xSBG8GgbYAgAjE9tYyBC7X/Wil5fbWAeE3KaBPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M5Dthn4IsHHsOh7wOId1n8WrGPsprAUglgudlnB1N6U=; b=y42+oXNYCrnVtfHcly6iYl3QlVf7Vi3AStNYwswVDPSeSmlKfp3fKbBzlS1qFzN69LSaHhay0RBon4AmdUfV+Ahjd03boyP1Wu2RlGMsAa1KDD1AwQlWz4Pt15WNzpgwzwTTF+j+L/P+R6JNco2k+sgthQKLM1RA9fn7sF9cOFfwho4zMT8sSQOncIcVHWM/z/Ejs6lAypdLtF7ZRnNRba5st/4470yXWNSI6l0LSa6UkfHsG+VoN1NKK1bBhLyGtc4uqDI57q0WeuYcHP0vLDyzq11nTu9sXDd92Xwmzw/NucojDBnakThKEG/23G1Aa+KdneFv2mHtaS7nLVjA4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 17:42:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Content-Language: en-US To: Julien Grall , Rahul Singh Cc: bertrand.marquis@arm.com, Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> From: Jan Beulich In-Reply-To: <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0538.eurprd06.prod.outlook.com (2603:10a6:20b:49d::25) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 086fe9ce-2390-452a-b722-08da5e9cfb2b X-MS-TrafficTypeDiagnostic: DB6PR04MB3015:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h5BkC6UJqtgCPPnMnoKumvvM2g1Q8oYJeZIB1visK8hKQE9sfHFf8nnRe3CJ5i6X8SctJpiyBXNRhibZtkaXWsBvw5r6WyX+V6DyScvglVJJnTSTggoFm4hZRRN2cRlVDgkVKgZSLP5JFn0tv+QUFddits1F3hX79Kusju1Vxala4DiIAMl2sTyDl2GYlPb8XwNxG6t0VMpIC8e9bzHAdCiK0nAjvls5L/3+q1ZbGkn+RO5BMgjhLeK+SffSyZxKhr2RHjPut1X7qUow6w1lEvyHjvwIa+lvNA6CQJSdFd939fZNbYJrzBry53kCz6QeNA0AFZEmrX/zpNjYGDnpWRt4NaV42UOEaYLPzTuOsIrLQupIbcjgM+GwWZ5rcdEcumx2C2GiWKjcPZCDCH7gDDt30/W/Jfk06ng0UfgllilCNzF49+sASCDZczu6bQPB8ZggEjLmIKfDqIQ/vuIxa08Yo4K5B8aVXV5/UGDtWEeNngHYYtk/XDmFtGhe7jv5DKjGlPtpK1uNYVosy8oXqhRDv0UhsE36HeVhmEQ8MEeqnf6hb7b9MRFjoc11Vb5M1JWUCsqAKCO6hvG5zTHZztD9LcHED6V8DhikqM1elLgFZp4wv03yt7mua77XYwSxJOf1de+pj1tOTJdkk75vaq4vXxz91DRwemdtavUvpD6DsrSTPJ/Zym5oBaIRm44B8Kx7D+RD1X1KbP+w/ACXUh0+kKLzztsTXH1mNdhmx46VxxX/BTRurlUvpxg+PL0Dm36E+SpxCTy3MDuj7QBHCvXLvfJmwJhySddfZ0YivtGkTATqD5SOKGeizvS3IukURZaUgMj09vv1VNLH3XljvA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(366004)(376002)(346002)(136003)(8676002)(4326008)(66946007)(66556008)(478600001)(66476007)(6486002)(186003)(6666004)(53546011)(6506007)(41300700001)(2616005)(54906003)(110136005)(83380400001)(316002)(26005)(31696002)(86362001)(6512007)(2906002)(38100700002)(31686004)(36756003)(8936002)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWh4dzFSZitvdVlDOVBwMUlodElmYVpJejVaT0FHbDZLKytoTGowaEJNQVVO?= =?utf-8?B?QjBWSTZPMmJsQkQzVHY2aGJCZ0UyWE85RWkxYUJpRUtkR3BGUkZ2dmJsUTFC?= =?utf-8?B?N21hQjBQS1NDVTB5dkNSdjYxRCt4UHQ5cElQRWpmd2ovQ21XYmplVC9RN1F4?= =?utf-8?B?UXdhMlRYaWhUQVB1L1ppMHBVeXVCWExPaDFxL25XdVFibVVXZTNpQmhwdmRy?= =?utf-8?B?ckdZZkM4SnJYM3piRHp0aTZnODVLM3RlbG9LaFpQOHlvM0o3QUtDM08zcHds?= =?utf-8?B?UCtTTDE1WWZySmc0cDdFZU5vYUNJSVNvTlVYZExTU1VtYXJhdlpzenFDNUR6?= =?utf-8?B?UnIxVnZnYTRTdTVZNzZaVlliTEJ1MDR2dmoyR3J6aWFqV05TZkMvOC90eFRO?= =?utf-8?B?VkhTRVZ0Nys2bVB0Vnd1aDNXbDc1UWVJcVkyYjd6Y2lSN1BhR1QxRmkrNWJG?= =?utf-8?B?OWZZVlo5NzBtazBhQ1ZqcHpZR2M2YXFPUG45bmVtckJ0SjlkUXVSMWdOL2ps?= =?utf-8?B?bzdBenBYTVFpWElGVWhpOG43bnVwRUtjWGUwVmwwajZwK1UxTDM1V0Q1cWFM?= =?utf-8?B?V0o2c2N6M25JVlFjY1A0OE1nYkc3UmNDTTJGYkh5R05CYTJLUHdwYy9aTFk1?= =?utf-8?B?QVpmeSs3NHZtdnQ2SW0vQWdRN2YyUzRSWW91MXBIUHNXbzNZSDZ5eHBFNlJa?= =?utf-8?B?ZTNPbDZhRm55b1VqMERWMWlyVnh2dWV0ZjYxNEY4Z3RlR1dwTWxWYmt6NjZZ?= =?utf-8?B?STdMMjc0eG5GMm90WFBPdXJxUkliTDd4RVVYOHo3OCs4dlo0elJrZjRFNFFI?= =?utf-8?B?RHRCcDNaV3BsRC9nZjlDTjVCMHlhZTIvbTM1SDdYdVhrMjM3ZmRsUEN6aVps?= =?utf-8?B?ZjIyT01SVzd6L3Bqc05DR3dOV2hJTk53aE92M2JDOVZ1V1RENmtoZ09vRnoz?= =?utf-8?B?V0hHRFAyaHdFREo4ZjhWOXkwRm5mcHhLM0xVVDNJZEY5T1Vxc3NMQkhmWHpx?= =?utf-8?B?ZVFuNDBUS0RiYU5nTnZnc0VySzFkWnltcS9zbENRc0RZL0htY05ic2NxMkhU?= =?utf-8?B?T2d4L1dQbTNVWVVlanB1N2hjdmIyQkJGSmVIdERxRm1WNGNGRUplWWN0WXJF?= =?utf-8?B?SDltRVdCNXowczNORXZwclNTVk9vL3lPK0RSbjhRVjZvY0lzd2xBQU9vVTVs?= =?utf-8?B?TklUMkNUbUpCcVBFSVN0bDQ5MEFSVy9saDUvdSsrMktPS1QrSFR1TjBqNVpL?= =?utf-8?B?RFFkVGRPMTJCaGc4THVod0FGQWJJSUxzSkpneDVjb01EY1BYYmRpMU1zOE96?= =?utf-8?B?QWcvUXNBNlc4Y0pIdmZKOEVGaHNUT1Bka1kwQ21QSE5oTUFEN2k4enZNSXdy?= =?utf-8?B?bzFRNGduRUJtMW5qcUpoMXFSMzloVno3aE15djF2emlmdTR6TzNnWVFtbWtL?= =?utf-8?B?am8xS2R5TnltdVJwRHdDZHJYcmlBZE52aWFDOVZIYndMZ1FrM0dCVlgySkNZ?= =?utf-8?B?c0pDOFhMMFhMaWhacS9aZGRSL3JFS3ZpZnQyY2tuL3VjQTJmU2o1aXFWek1G?= =?utf-8?B?aENrcjlKdTZNOEl3c1AxOGd0VDdQWFBLaWV0ZEE0aEVNdC9OenJMaWx4MFVS?= =?utf-8?B?VDdBblgxUnJsWVNMQkQ1WkZKTG44ZlNSS1JvWi9BVEVERXZ3TDh1UGtPVW9z?= =?utf-8?B?aHQ0akRRYnN6VjRtUGo4YmwvcGNaeW1GZTVyTmxOb01KQ3hMd2N4MURnNndl?= =?utf-8?B?dlRuTmRBRXNUeTFlRFBPbmNTUzdCQkpyZkQrVTRrV2NRdDN1bHByVE1TbnJv?= =?utf-8?B?TUtUQm9MZGxjNXEvWklRN2dHOFEwcTNXaFF1OVNSdk92dEU1MUUxSzBTWEFk?= =?utf-8?B?b1FPTXoyWHVLVGs1cnZEZi9JWjdDTnhpeS9pMWZjV3plaHRnVGZkeG9XbHdT?= =?utf-8?B?RkNnc0w5WkFneC9qMHBwZlV4WTZicjFDNWNaK2EvSS9pVU5GVW4vbG13eHQw?= =?utf-8?B?aHRwZEl2ZndENVZMMmVaUFpEakw0VmlpL09YamplWHFZeDJYQ1ZMWHZpMERU?= =?utf-8?B?U1hlcW5XYzF2ZzRlc0JMQjNGMW1IL2RZYi9mTHlUYlRlbk1rVFBIdFZ2R01y?= =?utf-8?Q?kV9zxPBNx0NgIYH8D5W4CeICc?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 086fe9ce-2390-452a-b722-08da5e9cfb2b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:42:34.9764 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gJ3Eg4VI6p84FTWsWessyPg1rcULtIxOSF1hGs3qC1/W3z+ZESegQXfTiiNESseuvgRz+JxNGkFpALKxTa8SWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3015 On 05.07.2022 17:22, Julien Grall wrote: > Hi Jan, > > On 05/07/2022 16:11, Jan Beulich wrote: >> On 22.06.2022 16:38, Rahul Singh wrote: >>> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomain_t *bind) >>> spin_lock(&ld->event_lock); >>> } >>> >>> - if ( (lport = get_free_port(ld)) < 0 ) >>> - ERROR_EXIT(lport); >>> + if ( lport != 0 ) >>> + { >>> + if ( (rc = evtchn_allocate_port(ld, lport)) != 0 ) >>> + ERROR_EXIT_DOM(rc, ld); >>> + } >>> + else >>> + { >>> + int alloc_port = get_free_port(ld); >>> + >>> + if ( alloc_port < 0 ) >>> + ERROR_EXIT_DOM(alloc_port, ld); >>> + lport = alloc_port; >>> + } >> >> This is then the 3rd instance of this pattern. I think the logic >> wants moving into get_free_port() (perhaps with a name change). > > I think the code below would be suitable. I can send it or Rahul can > re-use the commit [1]: Ah yes; probably makes sense (right now) only in the context of his series. > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -292,6 +292,18 @@ void evtchn_free(struct domain *d, struct evtchn *chn) > xsm_evtchn_close_post(chn); > } > > +static int evtchn_get_port(struct domain *d, uint32_t port) Preferably evtchn_port_t. > +{ > + int rc; > + > + if ( port != 0 ) > + rc = evtchn_allocate_port(d, port); > + else > + rc = get_free_port(d); > + > + return rc != 0 ? rc : port; We commonly use "rc ?: port" in such cases. At which point I'd be inclined to make it just static int evtchn_get_port(struct domain *d, evtchn_port_t port) { return (port ? evtchn_allocate_port(d, port) : get_free_port(d)) ?: port; } But I can see you or others having reservations against such ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 15:56:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 15:56:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361453.590985 (Exim 4.92) (envelope-from ) id 1o8kur-00085L-Ai; Tue, 05 Jul 2022 15:56:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361453.590985; Tue, 05 Jul 2022 15:56:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kur-00085E-7O; Tue, 05 Jul 2022 15:56:45 +0000 Received: by outflank-mailman (input) for mailman id 361453; Tue, 05 Jul 2022 15:56:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8kup-000858-Oc for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 15:56:43 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fbfec00-fc7b-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 17:56:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6552.eurprd04.prod.outlook.com (2603:10a6:20b:f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 15:56:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 15:56:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fbfec00-fc7b-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlZ/aPlnkrnQiPS4KtMzYWgEh2HFKLz6m5vJNzrPzmNd04uSsBmxfIjIxcMqirteqmRKpDgQnfYh0G7l4j3LiYj5B/OKgrCC9avGC01MjngpFdeLLJh7xQ+pM8V3aE3M1Nm6FdGss7DVy6DK7nXlGd8ge7RAn884m7Dzrs+RomnWuAbMmvLn1vHbxE4ZyVKkR4/0CRzYCOqPpHn6arPpRbGdqv7RzFqIxT6+tZS2ixfEmFLakv0JtGNmCgT4wvp8Pe6MGC3sVVBDxZgr+xFOPPCsNLQQfet/D07fCUENRG0qAXuPYN5TLjFeSOgFw2oQwbXFO9MN7YZAxfwvSoTW4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gjMyEbqYPvaU75TqQFujOmryjN0HbAjJDuVylj2I6no=; b=iBBE19kEcwR2Vd8VdwFbYF2lKr935SjvQBtRVYZCCtzY+IN2+//9VLvpq8xMuvu+ohKP2Ctcgaqv0hby1VLJwzL0XNGPDnaOzepOmQFObFa8epq433IkoJE2pecj6blxIFjDCODQSqj40vkxl8Uz13yjAaqMdIp1DIOT79anI5/E7noez8M2H2VE0/FGcLsXtuucrlE+W+NcWZX5sBNjcEQMsjtwy9ntBT9oUQWiBzTTW6Pbr4jxt57ENg4u1YPZmjAfVRn3kj2ueaGNzehk9zoTaQNrm+VCpcp9fsOkJJ9B8icTH/JyTX4tFqllWzvlWZi6eyhr8pZ8ffrVFBzmJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gjMyEbqYPvaU75TqQFujOmryjN0HbAjJDuVylj2I6no=; b=yI1Nl/4eOz99TR2EN+142nUWT+Qyz1UWXjRosYAbu/Z3sbM80FId8AnaGuMOn/hHZ9a5X06skNMhrozQTzbBJjeTWgnDXMGbhoqpBNO+6Bptaw+UoQoX3OrctqZTpoCdm0dn8zzx3Bx3p6jZDBKnSz15MMQNPuuapD0P4uq493kPH6B1yH44ETOjlE5w/SgxiEvHzkY5Zgh3CV/kJeAOaBGnb1dNZC9zH7aA5IL7R+uILh8RNhc3C6qL43Do42ONJ5a/Prc9G0oWuUQ5j2Eu+Y8dnfk7D5k5I2g+gB+29jTXRo30nJ3g2vwCuULs5ogNPViYPdd+w/0hq4btAOx7VQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> Date: Tue, 5 Jul 2022 17:56:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR04CA0034.eurprd04.prod.outlook.com (2603:10a6:206:1::47) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c671b9b6-8487-434b-a49e-08da5e9ef23f X-MS-TrafficTypeDiagnostic: AM6PR04MB6552:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2nBrJZPhFGposH5ympZzqUM5Y5xpsknH6nLnEkoiLwFD9fa24NcPygDUUvHlfROoEHVtMt3i6XxGCdKdIKgtNu67+sEryF71Kc+lHmP31vLuTcrb8VxkeNeqZ1RiRMlu8JegXNNlFHUX63H/Nh2ZG+wQYj0CMUODpQK47fnhIC9ORnA72iLmaN8aKi2BzeimJNNTyQa1K/og0UR4O/WJJFy3RocNF5T1wmgXK8noWri/UbRE8446EfJc9dr+LOHEG2HrwR4lzZPgHfkFR7H5SFVTurxwNAP29FU/4lRHQ2JyO1MH1jlCpAThTVEj/gNqNleMtBedwaTkVTiAi09nCUe/+hkR9ny9ma2vNIYA9u9FTnrM8rbImLF1z8XRRXYrshGlo2uQIC6TmKwZkZUA1KEdb/SoJNQIvs9dtqHzVEDmi5VxJQjPZB9h8/86S5L4UpFi7rqF0s1BUvfi2xDjkvh8shrtOBlY2dxPe171oRckIwqHZRkLSydJT1QCA6YKfLiWGY2S/fP+kw/k+K8tqXBNHCeSjKtOW5RRrFGfw+LaOPL7w+7ra2JZcx3xNg+xuGmD7ZDM+IRRIWzg9CQU68Q/cnLk9pn40E7TsGxsmDwADx1B9Pew9RN8JzIUwlTQAE7SI17kMbv4ZEIBmQuPUygOAfMwKBiELHfg6IInzIjLp/RXizEcCJGggEvROomAPNQrAOu6TV7btO1rtl8NFXSBC7OUAmSJsy5hFtDrbTNzG5U01tXRZqFVhWdEuvoxTHyYTtpuboDDMmJ7Lvm9c/BU0cCoaLns1dwYcemXSYhFI1s2LnxhG6YELPH43tKBaYUy8fkV5MIhb+oFuUZmAYvckFn5fruXbZo6yIJbi94= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(366004)(39860400002)(136003)(186003)(83380400001)(31686004)(38100700002)(6666004)(41300700001)(66946007)(316002)(478600001)(6486002)(8936002)(2906002)(66476007)(6506007)(2616005)(5660300002)(4326008)(53546011)(86362001)(26005)(8676002)(6916009)(54906003)(31696002)(36756003)(6512007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?alVHbjZOWHFRSGU4Z2NmK1RtRkhQZDZiM2ZXVzlpdklnV0xWQkYrK0FJSXIz?= =?utf-8?B?MlhkMXhoVDBwQnJxeEtac2FjK00wbHNaNnRCY3hiSVdYVEx0MStYcnFkNWZG?= =?utf-8?B?OW5wcVR3bUliVnVGUGo5V1h6R0hXaytjNUQ3OTV0ZnFFbDhIYnBVWk95RnE1?= =?utf-8?B?WnVlTzg3c2RmNmcvQkx0R1dUQ3g0SGYyWnFuajRYNk1LeC9nK1FqT0s3dk9D?= =?utf-8?B?NmhESVJtQUVNQXlhSnNVWXFocjlHRmhmbnA3RDBXcXpjSUxRemZrMlczK1cr?= =?utf-8?B?SWZwWEJvRkMzZlZlUnhTOGdiS2w3bnBDVktEa3RQL1lZeUNmVEtMT0w2V3Vm?= =?utf-8?B?Wm9OM2NUL2RPV1pyTnBiTlRzUjNGaC85RjVscDFKYjdkUlJkVUNhbXBMSzNo?= =?utf-8?B?eGkwUVk4ZXp3Vkp5RTJySG5SNGord2RabVNVYkg2d3RUVzlHaE1RM3NiVHJP?= =?utf-8?B?TFRkRW1FWEF5RllrQW0rU2tYdndqRlVBNDh1d1E4Ly9PTFhJRVhQMDlremJF?= =?utf-8?B?VXBIVkpnTTgxTEcrMG04RGE5S3ZFSzZ3eXJERUMxS3dDVjNqU25LZW03QTQ0?= =?utf-8?B?TkpxVXg4L0pSYjZzZDJwZFhXRElCNWthQTFIc09YMytxUzY5N0hUQ3EvUTVv?= =?utf-8?B?bTJyWjRXQTlSTW1ZanlKR0JqM1pXL1dGU3l1eldhWWphMGU5SGRPRndEcW1j?= =?utf-8?B?VmVzVWlhQ3p5UC8rZDdhREY4Tm9wNTU0RWxBc0cxL2c3NStYSXFQd1ZuQTlG?= =?utf-8?B?ZXV6cFp6Tkt1eS9kNmtpbVR4d0Y4SDlmSHRST0FXclJNVnkwaWx4dnVQbkh1?= =?utf-8?B?SVk5R1hxSml1enovcytSdTlNT0R6THk1R1dwbVVKeVBrYUpnU3RmK1V5bzVs?= =?utf-8?B?S3pXV21hOEFOdkVLYXZ2cW82aWJSdzI2eEhWTWgrZGlaKzdjSnZnc0hXUDVT?= =?utf-8?B?ZnR4NFVlVjdJUG1zbXdUSE5ldUdjQ1owcUdtZkRnVVl3bkVMelg0cnNjd1JY?= =?utf-8?B?ZnAzeE5GZ2pnOUk4MEFINFZKNFd6SmtNNGhJTFpmN1lNajBoLzh0eVRLWlVD?= =?utf-8?B?dmJlVWlLVkduSGRnVEFMZ0N1cE1zSDM1OXF4ayt1RWdPb3lZdDhBQ3hmbHVn?= =?utf-8?B?YW5uQ0hPSldrR1BvYXpnKzJrSlBFNVYwbEFBNk50ejdUK3BCYmhJaStyU3Jy?= =?utf-8?B?TFdLWjhrS0hFRmRWQ3JMWjNiRzVONkJEdUVCRVRZVzNlMUttMC9aQjVTNngy?= =?utf-8?B?UjNZc29wc2VQc0g1KzdoNE81VlpZMXdnd1pwWWVyNWVmcmt4R2VNVlNJNGNy?= =?utf-8?B?dm96ZTRwODVJemx2dFpPRXVLcGUzbEw4d0NSaUdsOTEzTXdaZE1iU2VqUXRB?= =?utf-8?B?STlBUGl3R1lwdVQ3REVoeUk1QzhhVE1MRFdlYjV4UnczNTRvbDJWd2F3cUNH?= =?utf-8?B?WjR4QzBRbEhVTmRrWCtrTzZRd2wyRXlWTHBDbG5SeW91ZHNWTERuMzVFM1Rt?= =?utf-8?B?WWtEckhZanBrL3ZWM0xieDZZaDRKem9PZG1pOVNkY3IwSkdUVFlBckdEN1N1?= =?utf-8?B?WDBoZUxjMWhNRFhxU3Rkb2tnNTNKV0d2QUZKaFBBRnFkeFpwWHBVbDZ0YWtP?= =?utf-8?B?RmlUTVZkNy8wZ3RRSmU3VHZBSG1XeFcyS3hsYXB1V3NKSnZtWEZhMlVwM1B4?= =?utf-8?B?T05mODE1VWUxOXRrNXBibFJMVm1BcUtPakRJYy90VVVCUURkTys5SnFQQWxh?= =?utf-8?B?NXBqMFZIK0V0K3MyeEJpclhQeEUvOEtTRGZwclZ3OTA1Sk1tNGJqTDJWU1Er?= =?utf-8?B?dHF2VXdhRzFCb1Q5eFRUZlliODJKZVJYMmd1NEkrOE1lbC9VQWRxNDJoeGRR?= =?utf-8?B?SEZkOE90K3ZYRmpWM0pZaFp3S05TR2QzYVJSUXR4UEZpbzVrczJDUXZVK1VJ?= =?utf-8?B?TzRyZGxsMWJsMEFkNWc4SUNsaDBXL0hGaFc5ME5HUmY5L0d2eGpEUTI4R3Nq?= =?utf-8?B?WWl2YjJhV3JCc1IyaTZ4TEwzSi9Rc2tYQWFiZ0xsQXQzaEZiZ0h6ZXYxeTFS?= =?utf-8?B?ZU1JcUdybk5hNURmeTJpa2RXQWJ1Tk91SVdta2RpaXlJWC9iS3ZkUG96WVJw?= =?utf-8?Q?02F52fNzM/vlJgIYpSKXSK6m1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c671b9b6-8487-434b-a49e-08da5e9ef23f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 15:56:39.0166 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EhSO+smMmAB5qE7JdaKbv119E4Ynaei8gIxxtgY8+BQ1WdkhgLWS4RvsorVC3CY2qMYVQDTEn1xqn/E44GEz7w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6552 On 05.07.2022 17:04, Borislav Petkov wrote: > On Thu, Apr 28, 2022 at 04:50:29PM +0200, Jan Beulich wrote: >> --- a/arch/x86/mm/pat/memtype.c >> +++ b/arch/x86/mm/pat/memtype.c >> @@ -62,6 +62,7 @@ >> >> static bool __read_mostly pat_bp_initialized; >> static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); >> +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); >> static bool __read_mostly pat_bp_enabled; >> static bool __read_mostly pat_cm_initialized; > > Why yet another boolean var? Re-using pat_disabled like you do in your suggestion below won't work, because mtrr_bp_init() calls pat_disable() when MTRRs appear to be disabled (from the kernel's view). The goal is to honor "nopat" without honoring any other calls to pat_disable(). > Why not extend pat_enabled() to reflect the Xen case and explain it > properly above it? I can probably fiddle with pat_enabled() instead of with init_cache_modes(), but when making the change I had the feeling this might be less liked (as looking more hacky, at least to me). But besides the "where" the other question is: Do you really want me to limit this to Xen/PV, rather than - as I have it now - extending it to any hypervisor, which may behave in similar ways? Jan > My comment is likely wrong because I don't know what the Xen HV hides or > doesn't but you get the idea... > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > index d5ef64ddd35e..a8f1a02f9bc2 100644 > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > @@ -92,6 +92,13 @@ early_param("nopat", nopat); > > bool pat_enabled(void) > { > + /* > + * Xen PV doesn't expose the PAT MSR to dom0 so the proper init path > + * there cannot be exercised. Announce PAT is enabled in that case too. > + */ > + if (cpu_feature_enabled(X86_FEATURE_XENPV) && !pat_disabled) > + return true; > + > return pat_bp_enabled; > } > EXPORT_SYMBOL_GPL(pat_enabled); > From xen-devel-bounces@lists.xenproject.org Tue Jul 05 16:03:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 16:03:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361458.590996 (Exim 4.92) (envelope-from ) id 1o8l1e-0001lh-2m; Tue, 05 Jul 2022 16:03:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361458.590996; Tue, 05 Jul 2022 16:03:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8l1d-0001la-Uw; Tue, 05 Jul 2022 16:03:45 +0000 Received: by outflank-mailman (input) for mailman id 361458; Tue, 05 Jul 2022 16:03:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8l1c-0001lU-Fk for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 16:03:44 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140058.outbound.protection.outlook.com [40.107.14.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ad673ec-fc7c-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 18:03:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6552.eurprd04.prod.outlook.com (2603:10a6:20b:f3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Tue, 5 Jul 2022 16:03:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 16:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ad673ec-fc7c-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XpNuZtte6025YRrJe5T74vtSpwW2CJx6qOq4C8j6Ca2qs05vPXakjY1L47yDChzk0oJsgwsTTpcqgDrXfmKyIfZQwdgYwxmFW1IdfXiZScq1k9BiasPWuNWjaadmYJXBLBA9kM+JDJ1w8ySPoEiT58WXwQ8h+eGM8WnpmRLhomw6eD+CDlMsOND6ZdfDGIVWxtdwtrHXDdH7x8f6l+7kKEo/c3Qz4HWbXn7SJds/vh9kLskxgQQUBjBDRIN3nTNkX8DPvBi+xlxb0OBGpmsqYMa/7XmWhKxBqcySEvmLkxcVMmNjiK3nRlGbe0FRcXR0vI6hXmIrJ0y0VlRDaRAXQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Te3OjBPPCuEBN9Gih20oWOXZs8YlVys00XqJtm5VLUg=; b=T2avtRx2i5XUmz/jNC4s0jmbdFBinYRDdZS0kISoH9OhBM8+v0Leaz0JkEQ6I+cPDMKrRhVXmoOfxloc35krf1FGQU2wk9OkOMWUDTx72FyiXh6n+r2CsebO3kWmnZMnXwc7p34lwaFH7NoULBnPC6yS930rWij8+4HzZaD9P1ZdFvMEnyQwDovFP+PWmK0BnFppPb/N1DIPhVwgcY23bPwVJCSpvR++PDL0TFfjNqiX269oAy7X1WH3WvwCWdrj6cJvnJ6D2oPuhUuoQjj2BG0ba9AzvjGBNFtVTnN61ksRgX1B0wJPm/7iEi861qahrNlVje/nuAbBywmA1QmbAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Te3OjBPPCuEBN9Gih20oWOXZs8YlVys00XqJtm5VLUg=; b=BXCyjashDR7lmlbEpY7Z7eC5Ekwfo8viQ4jxxbmJdkTuFpv/hirVmryP4qGsNm60+2Oydx2hM7SXSfXREcV4TkRMlUzdWC7JUkezUXDC2L5RWpbXRAtyV8sfgAhnRvwWkfDSItyCc43CKl4CfZvpu6NbQP80W8vLmsBClliyPA40VRRSV7RVmlU1FrfPIHTHxsCRYfn/M4w2yF8d51BvsYh5BVCzaHTrgvLTxcZS0DhULxtuKJehBeETf/p+/5yZCxCJ1iJux/VA02bLY+MoVd7bkBk9J8+Jy8NaVXD+qWlJ9EPOFzL1cP9FywQv10IPvX0lycU7x4B88ttJE8Cexw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9916754f-b730-6201-5225-167995f69b51@suse.com> Date: Tue, 5 Jul 2022 18:03:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> In-Reply-To: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0105.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97d47202-8028-4725-bd08-08da5e9fee08 X-MS-TrafficTypeDiagnostic: AM6PR04MB6552:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wuk/Z2Rs21i7uIBtqoPleyeaTPRFK2E2S7KQd4zPTt8SR6p8wLP96PNYs90e2zlTn+KLFa1crJR/tT9ZpP/JqnI+MSdwCrXxMLcB8BSPnyXYyweYqUB7abwnvfd2u0VFtwcKTt7DdxG2WaRKeQQearVchxgLvc9FU9hjzQ0ulec0Yw+13oU3XEardiuQjsoBOBMqZbctjT76WPbOFXw3hnN1GtgYCjFi5wfGKraM85+35nkwIk0NqPRcnk1iHk9cTMpLzoM21s6T5Oj3PnsPtmcc/Do6FxXUfuG+JdsE2lrHmqzt0OZsfS82P486gV+Hqq1Oi4F4emqbylVWenSYWuyATjhcWMIh942e4j/dz8dOH/lCO9a3i99RtrMIzsLTK9wgK3zL2pB5Xqn8MuJBudSmMs3f2YxfmMYvGXnJvmFnMaDdWtnUh55iAJ35Hd12tXP/AaWdjCDnTvxvaaO+Vg3JG5pBDOeLbyS90/XF3SH6mnGBP7DdRfA0zACipTrUcUN3NX1VPXYTziFYexElIRrNzah0qlto2X0Lisso1FEcYKCIcwH9kf7L4qfWM8HrnZzR/7s4GVHp5bUAKrTtLeUbYSAMURQaZemRkGEfZSvV7DCan/XqE2hav0ZnSDbv1vhYvvxJcVdKgvUvsWeZGGlGRuBDsLzj1dwx2j3KNIdk2gj3qDmZaszV7cHkHtovIvUpotnWMvqoPJzTvohKAtBRXTM4l6XZxhNQhSdoQSKDV+O8veExRr7ncBsLExRgQ72y7SpQFmhWuYlWzW/HLIO/vg9EJDBe/CUx4vCZgHImjgkpEinBRYwr9zdUCdXIaBw08TsL8zCgANyaJ5i08bkXOvwddWTTWM/L0GuFNv8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(366004)(39860400002)(136003)(186003)(83380400001)(31686004)(38100700002)(41300700001)(66946007)(316002)(478600001)(6486002)(8936002)(2906002)(66476007)(6506007)(2616005)(5660300002)(4326008)(53546011)(86362001)(26005)(8676002)(6916009)(54906003)(31696002)(36756003)(6512007)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SDcxQmFVR3FZWUk3QlNiZzdVSm9kZm83dURsSGNnSW9SNXhFS3FGdEdKMXdY?= =?utf-8?B?UlpmalF2dU9vei9yNWN3bm5udjhRS2IydGJtTFNHQ01wUHhFOEQzTkxDUDVk?= =?utf-8?B?NDEwZTVZdWg1cVUwSjZBeXlxbnExdW9aU1hxU0lPS0xjWDc3ZjFMWUl3UVBY?= =?utf-8?B?aittN1hMMUprRjB6MHVrYzNHaFJLcGd6MlRKcmt0RmFQMmFQUkJDYWZzdkNU?= =?utf-8?B?YTBVNiswN3g4ZkFZQ2RCSGtYSWVzQytHZko1VlFxL3MyUFltU00yOSt5RXU5?= =?utf-8?B?YXZKdmptcHlIK2J0WDJSTDY0YmJWbVZJQjgveWoxT0YzZ2FIOHYycGFJSmpR?= =?utf-8?B?VldFY2ZEcW5FdzFObnAweWtjL3ViQTNsTjR0b1BBQmZsbm5WODBTZ3MxbmNP?= =?utf-8?B?Qm45RE92Yy8zNmVxc3ZSckRhckovSkFNTGFSalRnQ09Qb3Q1eHcrM1M3M3BB?= =?utf-8?B?WjdGbFJkRTBlK0kzdzZQMEZMVWtGZjZyNVZtQWNxenB6c1JjZ2laRFQ2cm92?= =?utf-8?B?WnFmQnMyTnRPQjJrUzFmekxZNWtLQ1owM3lJMDRNQ2pyT0VrZ1JMdmNtMTcr?= =?utf-8?B?aGJ0T2xtYnpsOFY5VFl4MHFTalFFeXhrZGhZbkVZNEYxSmVCczBjNXZxWHF0?= =?utf-8?B?cTRlMFR3S3Y0dGFrVUZkQXFVMGs5Sm9mYXhoUG9oWGdkZDhud3I1WE1TTi81?= =?utf-8?B?RXl3VTRBbjdDNVVZeUJUMUNVRG5veU9Fd1lUMmpDeEc5bk9vTUttMEFmalJz?= =?utf-8?B?MWV0aUQ2VzhpUXVlTmtmOFk2YUg5S3liQWFncTRYc2JOT1gwMVpmNENCQTFv?= =?utf-8?B?VjRkL25aRDBZVGxIeVNyOTJ5Qkp5TEwvYi9yMGFZQlRCZm4yOVVieGs5Rm1a?= =?utf-8?B?bDVOSEV1SU5aaXA4cSt1dEFRWnIvVUF1WEd4RklMOUk5U2NDVzFDMG9CcVpo?= =?utf-8?B?cGpMYmhvN2Z6VTB4czF0SXBXVHJvTDdIUzBKS3NIQlVSV08vVEpoVTZTYy9s?= =?utf-8?B?WXY2SFRuSVdTRWYrUGNpRDRncktVdmZuWjc4alh5ZEx5b29SbGJtcTF5Zk14?= =?utf-8?B?ZWRVblJTWXcrc1RWYlJCVTJjTXRaakZYQktuWTcyazAwOURhcTgyaU1xc09i?= =?utf-8?B?M1dQamVZWHhsME53dHIxWGovYWUwOXR3N09pdTI2eEVJOE5OaUltUitYU0M5?= =?utf-8?B?M2hpUVF1ZUhiTjdpa1N3RGZWUlU1b0pDVnJxcHlaY2krRUNiYzYrSVhHMzhE?= =?utf-8?B?MkNXd2t4RExxTWQ5Ny9odTNOZWs3RCs5UzUxWTcrV3NIdU8vWDNja2ttcWFn?= =?utf-8?B?bWVVTVJjaHZvS2dSTUtFVCs2M1UremR6dFFWVDE0YXh1VFM5L0pNVkdKWXJi?= =?utf-8?B?QXNXendBeHhQU3hYc2hxRCtLQktIbE1tOW0vWTIwN3RlcEVMU0phY1BPYk1B?= =?utf-8?B?Vjk5NnFxU0V1Y2RhMzY5cEJURkozUTBLNG4vMnhiT3JDUnNRY2JmWSthRyts?= =?utf-8?B?YmV3Y0JCMmdpTGFFTFlsM1ZnVEdnNVlFMEgvNUxFa1NvdjdSanVGUkJYRkVD?= =?utf-8?B?S1paa25PMVZnNWk5c1h2SHBvVDVLSEhjTzFET0xsVDJJNEJ6dTk2RFZvMkI5?= =?utf-8?B?RlllWXdlODBqTkQyRXJvZjFabUh1TzRiZFVLK1lxdzFhM2tnRWRmWEpGWVYz?= =?utf-8?B?MnBXU09RcFN3dTgxd1VSVjJoUFB3SVROOTdxNk5hdSt6RXJPK243SDZSaDB5?= =?utf-8?B?QUV4bkh3ZzVnZnI3TXJ0NjBmYUR0WWozMDZvejJwSm5CTXdSVUxNaDdtY3hX?= =?utf-8?B?NlN3T3B3bkdsSE5QQncrN2tJNmdNdzFFTVJHOHRzWmpEdTVmeTJrNFRJTjBm?= =?utf-8?B?ZFN5dEhGWTJ0amVuRTZSNytZK0lJOG45eUpYcTQzb29nRjMvV0I2MGQrcTBl?= =?utf-8?B?bFFFaG8zeFFrYVl5djBGcDhhVitKVFlZZHkvYWhlRGdjRm40RzlSZUZVQits?= =?utf-8?B?S1VRWmlPT1BaTHNveGxxdFFIM2VtUHJwbnBlWkJXNlJSYVRvdE9UN1ZjSDNh?= =?utf-8?B?aGliY2NScDFRQVV1MWZrZzZndFFPaVhzZUlDMWV6U09nRVdhNmZuT3lRZnhs?= =?utf-8?Q?Bwu/dkMY3Oocu8xPYBFbu7jxI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97d47202-8028-4725-bd08-08da5e9fee08 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 16:03:41.4269 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jk/jlBQeaHAZ6fYIj2+1u6W9TfbZ3gYl10GO2MoqhthwN02uwyl/r7BAqGCgUnQfZrzCJlyUaCY7dgIbW5wHUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6552 On 09.06.2022 17:52, Jan Beulich wrote: > With debug info retained, xen.efi can be quite large. Unlike for xen.gz > there's no intermediate step (mkelf32 there) involved which would strip > debug info kind of as a side effect. While the installing of xen.efi on > the EFI partition is an optional step (intended to be a courtesy to the > developer), adjust it also for the purpose of documenting what distros > would be expected to do during boot loader configuration (which is what > would normally put xen.efi into the EFI partition). > > Model the control over stripping after Linux'es module installation, > except that the stripped executable is constructed in the build area > instead of in the destination location. This is to conserve on space > used there - EFI partitions tend to be only a few hundred Mb in size. > > Signed-off-by: Jan Beulich > --- > GNU strip 2.38 appears to have issues when acting on a PE binary: > - file name symbols are also stripped; while there is a separate > --keep-file-symbols option (which I would have thought to be on by > default anyway), its use so far makes no difference, > - the string table grows in size, when one would expect it to retain its > size (or shrink), > - linker version is changed in and timestamp zapped from the header. > Older GNU strip (observed with 2.35.1) doesn't work at all ("Data > Directory size (1c) exceeds space left in section (8)"). > > Future GNU strip is going to honor --keep-file-symbols (and will also > have the other issues fixed). Question is whether we should use that > option (for the symbol table as a whole to make sense), or whether > instead we should (by default) strip the symbol table as well. Without any feedback / ack I guess I'll consider this of no interest (despite having heard otherwise, triggering me to put together the patch in the first place), and put on the pile of effectively rejected patches. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 16:10:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 16:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361465.591007 (Exim 4.92) (envelope-from ) id 1o8l8P-0003OE-T7; Tue, 05 Jul 2022 16:10:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361465.591007; Tue, 05 Jul 2022 16:10:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8l8P-0003O7-Q4; Tue, 05 Jul 2022 16:10:45 +0000 Received: by outflank-mailman (input) for mailman id 361465; Tue, 05 Jul 2022 16:10:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8l8O-0003O1-Ql for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 16:10:44 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30048.outbound.protection.outlook.com [40.107.3.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 057c0d2e-fc7d-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 18:10:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM4PR0401MB2370.eurprd04.prod.outlook.com (2603:10a6:200:4f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 16:10:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 16:10:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 057c0d2e-fc7d-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HLx5Nyvm/jQ3zGZvGuuwIYYgBO5Ut/UXxP+Hlb0wKK5Pylb7aJ8Y5Sd+I0IguadYQdq0ka8Wj3PQBFTIwh1/lJ0tVYvAH5FITCSiipSBOniMiTC42//Ywx3lQPxJsRZfhuNdIqxv4sUyI5ud5Ufn6Xj8gHmFDm51fB8LleZczaaEsbm2MCUgNjtfX09r6kZOJozsbSaKYELdu0LCe+ckmUqBJ8ungGmuhxi5B3MtHilecJZqY+ljV2jj0xGsnPsdlXpKnEJRiLQl/uHuKc4NCHxlFwXGBjxn5Ni2bgZgjMuaeqJ0Ahsreh6M5Kq7qh8HQTxep/wyRFkdLMnrPgYl1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9gw2sSL+GwIPEzkvXAHmQhaRvc0n8rVkAnKNJbGT88M=; b=gkKomHvcoyC+56897zactOJx+ZQAEhT/UsuedvWKuNPP3wdCre7Qchusls8pfPkcY5HXf2HmtNGGhZT/0HpaCmxWyK5UR/cQBso0Zz1NwyqiwlqHPEr+wwoaHVecH98DlwBbirto0of2uM0Gqx7jdNSDkgJCgwX7Jj3Ls71N0Hnt31/pRH4ijXeZnJ2RaygXxLwVkwsrPOr+YDrA8Xiuua4YQdckq9UgXOV+8uYYboh5pf5uQcmUY5wBh/Rrrs/FX4GnfpWrRwfBWPy7EK7KtpQ2PFcUOmvGWQijLMIiMB9xJd2+wkWL4PSMdrOwXvXRpUrf5wXAJA7WDvE+cBbu9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9gw2sSL+GwIPEzkvXAHmQhaRvc0n8rVkAnKNJbGT88M=; b=GppIHy9PqSBig6/6i4k6oSi9yjo4p5eUZj5QMDAtlAb/wzNTmiIiB/b1DtjiskfsbBvdVEpI+9ZYo+J8j6jTP4Z+ng/7dhSOwp2kYEgWjV7m5fQYknY+XfeGg9Sz0T8T57HZuCOqJtKiMJCtpQBoOPypigKHPH4QwJTnxFFpZ4QT9v9QJ5CA05msPg2Vw9178b4pFCAVuKOlNAkXrwVGu0x11PffJ2e80SSRyczwMwBI+/9FcV1cJB/HAIRffL0O2HQ6lZ7lDsECW52n3zOnnbK9z9jmyScKRKLqBwFK9KiHO2vnbfxU1ajXRGM1kafTVPEsvoY2JkS06F5GJokM6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 5 Jul 2022 18:10:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1.1] evtchn: add early-out to evtchn_move_pirqs() Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Dario Faggioli , "xen-devel@lists.xenproject.org" References: <8bca62e3-1075-f1f7-1a92-1a4c58ba2aeb@xen.org> From: Jan Beulich In-Reply-To: <8bca62e3-1075-f1f7-1a92-1a4c58ba2aeb@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0031.eurprd04.prod.outlook.com (2603:10a6:20b:312::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2d2ffc1-d78b-41c3-8102-08da5ea0e7eb X-MS-TrafficTypeDiagnostic: AM4PR0401MB2370:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zQQRMRMYgZUycveL81eaBlTqnAWBCqqnR1T5ttLoLfCqNcGCC5yzYxSzeyg4pT02Q0mtOQ7KRv41np60LwiibtUY8VfDfkfaikm9lVkpPzmIxL1nBoUFdBMjcemQ47pVfvlnAS7TXv7Zh9yqPNdcLW2HTM53n48EqXN146Ze8eQDH2wuPcbInrmPqokglK0DT+Qla5eHvKTlaw7oVCausgLh4sO3LlpN9ILJ1pdoC/SaaoiiJmRHPs8L81fpn7H1TTpliTq58lNdifqNKBOLZZ5qG4ZFGBZCY1SgePZ05171Vd35fWVtCpn38Hwdmt6naJrlhnActHZwn0yq/u9+dhCEqCGJRqSs6Ub6EyS6muGz80CUoAWr2Tggx5mxJ4SAOOLWRkUQw55vjuIQhiQ2WoswWlvpQxgK5mizb27a5O6QitsKtCdFed3egQvYDsUFOjbgIiIvNDv+/c93ZeJ43bEzjEoRf8tLeSLxwJdnDf8+vWFyFWdseKNX4fCxTKX2i3zFnoFdftlWw9FURIFwXT/BqQdhWwRweBeHBzP9ztdnB7IkKdwD3RgjAu8ah17tfcUKZ3SeBzC+yt4g7HSa9e+gliEzN8ktk+/j3sY2IGKROGgi9o1R26GzslsH9UsSVPbaSRw9F9fUxASlAQUd8x2bks8h3kORJQlococoIlGApf5bEC8sw8MvXakTlEOuMqSsDVle0w2OVXPIkJTrGTa8jOcV+AeMcfzCem6Vj7yqaL6nHs8AQCLfaVeFMmymxz4B7qmjx5zvN/LQ+G4EYQkjx8ff7Kk4k5BebVbxNi//8kzfF74tYJL8QOOqDhAnq3N//DUL/fiNyBHUNPjcgxl373gU5K7mjm5RaJSPP0s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(366004)(346002)(136003)(376002)(186003)(54906003)(6916009)(66476007)(6486002)(83380400001)(4326008)(8676002)(66556008)(66946007)(6512007)(2616005)(36756003)(31686004)(26005)(6506007)(53546011)(38100700002)(86362001)(31696002)(2906002)(5660300002)(41300700001)(316002)(8936002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MlMxYjN5NlBDcnNJZ01KYTRIalh3U0JLMGVZcmx6QTZvMXhkYURkQnRTODFU?= =?utf-8?B?TFJ4cmhjZFBKUFljNm9sVlBxbVFmQkZyQVRRYmZBMEMwMmZ2bjNhREw5Vnpq?= =?utf-8?B?cGs2L0hvbzNCSVI0ek4rbzQ5NTY1MjZ3RmxrWEhKU2Jvd3BOM09KRVU4STdK?= =?utf-8?B?aUJsUW1iU2xWa09TdUk0QURWSHF0VTFLUTViK1pDdm9YUzhRZnFUc3h2U2E1?= =?utf-8?B?WjJuc3JLeWxHekNyQlUwK3hHMmNxb2JGUm5UR2VSQ2lvdEw0ajBESFRpY210?= =?utf-8?B?U2JrWXVKcGVUUzNSYS8rd0FSWkNWbGpYZnJ5ZHdoOHpkTDkyYkJPWWRhYksr?= =?utf-8?B?Nm9rMFp4SnZRbWlVRXBZbytDL2U5aTlyWW0wNFl5Mys1aWpNQlJFZUpjZ3k3?= =?utf-8?B?UmFvR3d5ejhOMTNpVE5nckN1RlJ3WHpDbk9PVGJoKzhDbDlSOXNscHBZbGZw?= =?utf-8?B?VzJESk82NmJ0UERvZzZLWXNtdElURllCWHNGeFVWVkg5cnZ0c2dJOVNaY293?= =?utf-8?B?dUZpTWwrRkZJS0U5R3RteERxRWltVWRNSWhvcnVSRVA0K3VuNit4VUUrMFB6?= =?utf-8?B?WG42R3JqZkJGdGllYmx6TDdaeU5YODlTcVNZdWlsMU0zSlpiRjVNMDZOZzRy?= =?utf-8?B?Rkg5bG1NNmZTOTlmSVc3a3hTK0hZTXRlYXcrcWxlQ3dmSDNkVnVvSkhkUlJY?= =?utf-8?B?VWdBV3hpeVo3TGtZMDBySVFsR0lXSjRZeTVEdU55NHRqMEdnUitpMCtjTVBx?= =?utf-8?B?cEpVbjI0emlDc2hIM3V3YkdZRHZYT0ZxNHZnTmE5Y0hlZUgvSjNINFZqdWlG?= =?utf-8?B?LzVtY0FQU3QrTDJWb1NFYjViRVo5M0tEeFZKSmUyaGNtQTI1RnE5MXJEMEJ3?= =?utf-8?B?V2FuYXRBSDNJcGVzbGFYSnpiMHQ2VTNOS1pPRHFGQlcxYnJBcEVGWk1qLytO?= =?utf-8?B?bzcwUGJYS2FSdDR2dGpJdU1SRFRNa2JGZ0U1cWlJdXBZYUJyYmM3NUVNQjNq?= =?utf-8?B?dTYxYWF3UFhRcEtBTVQ5YnNBaVNOck1IRDZIM0FoSzYxSW8veWltWGR4Ni9H?= =?utf-8?B?U3VIQk9rZ1BRSXVxcmpFY3docVR4eFJocmpjSmFWSW9rczdkK0xaUjdUYWtz?= =?utf-8?B?QUlXYnBRK29NSWQwVlUzQXZUN3JzeTF5V2Jia1VIQkV5dDY5WjNXbXNnbTkw?= =?utf-8?B?MUI0TVJ0ODlBb3hiQzcvcGhRay8reHB2YVdhODdSOTZRbkpaZWpDTUhtd1Yy?= =?utf-8?B?ekhBVnNEWGU1SzVybENHUWNudC9QV3VBVjZDRURibmRqdVp1akEvWW9tWW9w?= =?utf-8?B?QUpLWThtSFJQTlliczBkZUp3Z0ZMb3Y5Vm9zU2JsN0hMcTFLL1g0VEp2UWcr?= =?utf-8?B?VFFPVFVDdzFuNGtRMjdKVTRuSzEvaCtydFU1UmRxL0g0ZHNkaU1KWU9jamxw?= =?utf-8?B?T3hYczdXMHpSM2tseXhXd0w5cnJBb00vTXFxZXJyTldSaFpCREptaDFwNVQ0?= =?utf-8?B?bzNubzV3SmszQXRQdGlmMlY0WmRVM3VBNDBEbzVuSFVZdHVxek5oZ2dUTVpV?= =?utf-8?B?L2NHQStHKzRDS0NtYUdxUlM4Vk5lclQ3cjJmY1ZtODdYL3hGVTFBZngxQ041?= =?utf-8?B?SjBidThqZWNEdFhOeFhuaDh2MkVtZEE4T3dDOU9hUHdRTTVuSjBzTUR1a2JU?= =?utf-8?B?cS9VUVNyeitBMjNvWk5pWVVkTkdmVTF2RmxVWTRJbFlROU9Qa2gvNWIwb014?= =?utf-8?B?ZWsyTzRKZ2RlVEgyeEQ2dkg1c3M2SXpUN0R1TW1XUjkrR2hHY21sNzZkM3Q1?= =?utf-8?B?dWZ6Y2prZ0RzRVpqcmk5TDZDRnh4ekNpVTd4SHJpMFJQKzc0UWxlR2kwUDk1?= =?utf-8?B?Z1BFc2NVWGw1Mkt4ZXVJNUZTYkhNT0RWY3daVkJOK21LSWRKRGM3MnhXNll5?= =?utf-8?B?Z055UUxvTVZGMHNUa3pMNHFRL2NpOWtwUlNGdkNESitHM1BFNzFJb3lQVi96?= =?utf-8?B?ZjVWWnhqK3pBQktIUHZCTnVTazNaQ3MzWVZvTFpqMUxOSkhva2c0WFhTZGlv?= =?utf-8?B?K3loYU50RGdZWnJmOVpCZXVuVmNudUFnby9jV1RpNTFCM0I3NEVhZ1hKcytC?= =?utf-8?Q?stMxgQhEqSka+rM+dXfLRmmA5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2d2ffc1-d78b-41c3-8102-08da5ea0e7eb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 16:10:40.6814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oueuZqaJRVYhhMJBfrHVCLOuWRdOLetABP213Yj5PVgi23eMJm8squNRGbglxaXXILAaR2eS3YmkVdkCIIAtwQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2370 On 26.04.2022 12:44, Julien Grall wrote: > On 26/04/2022 11:33, Jan Beulich wrote: >> See the code comment. The higher the rate of vCPU-s migrating across >> pCPU-s, the less useful this attempted optimization actually is. With >> credit2 the migration rate looks to be unduly high even on mostly idle >> systems, and hence on large systems lock contention here isn't very >> difficult to observe (as was the case for a failed 4.12 osstest flight). >> >> Signed-off-by: Jan Beulich >> Tested-by: Luca Fancellu >> >> --- a/xen/common/event_channel.c >> +++ b/xen/common/event_channel.c >> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v) >> unsigned int port; >> struct evtchn *chn; >> >> + /* >> + * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the >> + * vCPU-s they're to be delivered to run on. In order to limit lock >> + * contention, check for an empty list prior to acquiring the lock. In the >> + * worst case a pIRQ just bound to this vCPU will be delivered elsewhere >> + * until the vCPU is migrated (again) to another pCPU. >> + */ >> + if ( !v->pirq_evtchn_head ) >> + return; > > I was hoping Andrew would give some insight (hence why I haven't replied > to your previous answer). > > I am still not really convinced about this optimization. Aside what I > wrote about the IRQ raised on the "wrong" pCPU, the lock contention > would still be present if an OS is deciding to spread the PIRQs across > all the vCPUs. > > So it seems to me switching to a rwlock would help to address the > contention on all the cases. But that patch of mine didn't get any ack either, and hence at some point I've shelved it. The same is going to happen to this patch, and sooner or later we'll re-observe the issue osstest had hit (at least) once. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 05 16:14:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 16:14:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361470.591018 (Exim 4.92) (envelope-from ) id 1o8lC6-00040q-Da; Tue, 05 Jul 2022 16:14:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361470.591018; Tue, 05 Jul 2022 16:14:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lC6-00040j-AV; Tue, 05 Jul 2022 16:14:34 +0000 Received: by outflank-mailman (input) for mailman id 361470; Tue, 05 Jul 2022 16:14:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lC4-00040d-L5 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 16:14:32 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8d50984b-fc7d-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 18:14:31 +0200 (CEST) Received: from zn.tnic (p200300ea970ff682329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f682:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EE60F1EC056D; Tue, 5 Jul 2022 18:14:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d50984b-fc7d-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657037667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=N6tbxGmzXBxnpgTLBtsPda9RXrIjxRareOpLL9aV2cQ=; b=b1oDXangh6joLJ4eJiLlt65DHN5Z2xgOJEAqh8yBWaHfnBh5StIk5WDx8/vFl/Zg2uQHxr YDtaDYF84OYviCczo367n5Dg1lxaOv5KmseVlSKx/BLKSxtghSdfuiavw5fMJVFBq/i68g kPi/0377ZM6hMiN9YmdzYpu324hEM8A= Date: Tue, 5 Jul 2022 18:14:23 +0200 From: Borislav Petkov To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Message-ID: References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: > Re-using pat_disabled like you do in your suggestion below won't > work, because mtrr_bp_init() calls pat_disable() when MTRRs > appear to be disabled (from the kernel's view). The goal is to > honor "nopat" without honoring any other calls to pat_disable(). Actually, the current goal is to adjust Xen dom0 because: 1. it uses the PAT code 2. but then it does something special and hides the MTRRs which is not something real hardware does. So this one-off thing should be prominent, visible and not get in the way. As to mtrr_bp_init(), can you use X86_FEATURE_XENPV there to detect this special case when the kernel is running as dom0 and set stuff there accordingly so that it doesn't disable PAT? Then you don't have to touch pat_disabled() either but intergrate the Xen variant properly... > I can probably fiddle with pat_enabled() instead of with > init_cache_modes(), but when making the change I had the feeling > this might be less liked (as looking more hacky, at least to me). Why would that be more hacky? I'd much rather check upfront what the kernel is running on and act accordingly instead of hooking into random functions and then years later wonder why was it done in the first place. > But besides the "where" the other question is: Do you really want > me to limit this to Xen/PV, rather than - as I have it now - > extending it to any hypervisor, which may behave in similar ways? Well, do you know of some other HV which hides MTRRs from the guest? I haven't heard of any... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Jul 05 16:19:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 16:19:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361477.591029 (Exim 4.92) (envelope-from ) id 1o8lH9-0004oL-12; Tue, 05 Jul 2022 16:19:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361477.591029; Tue, 05 Jul 2022 16:19:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lH8-0004oE-Ub; Tue, 05 Jul 2022 16:19:46 +0000 Received: by outflank-mailman (input) for mailman id 361477; Tue, 05 Jul 2022 16:19:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lH7-0004o6-4g for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 16:19:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2049.outbound.protection.outlook.com [40.107.20.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 475cfcf9-fc7e-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 18:19:44 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB3321.eurprd04.prod.outlook.com (2603:10a6:7:8b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Tue, 5 Jul 2022 16:19:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::dfa:a64a:432f:e26b%7]) with mapi id 15.20.5395.021; Tue, 5 Jul 2022 16:19:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 475cfcf9-fc7e-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4ZuIUl79vvkVSDjUEZKhsmRTmfCsc3bGAeoy3QDWrDeEFiJq7PO1BGtTwFpa5jrM1zusTk0RHrh4TS1yIfOl+MWb3CpM5NRRp88wHm1pFnV1bpMWQpW8M6jyeVYoTF8NGEQ90g3aBOJnBaTccLVf8IifttW5JpVa/CILUh2TTkYC6Q+UCycxV1iZD+K/fexiGk83oP88APiDJbQWQjK+8VWmuAen01KtcoVdUOSBiRQzoOBmzTe4E2A9onzVQC4TFSk420EeFNqI2n2KkVnrRXV5iedygmFgFQ3GorKZZMy8hT60VS2XDkRWsPDsXUEAMc5C2ClAa1KRd0Nxmntog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzAGOelRAv5ki/nbdjsf/zB4fwKknW20ezHFghZgY8g=; b=M2TmKJsYF98KUqavCWE7+z2M0gejEMxbFhPLLaRHqVIJ0vonbMn+kb2GUoGGv1Cx8J5TNkTu95+4WxlbkPamiOFmyzYT7UM9tH93y+hDxeNl1KoIybC1XRbi1W7sPSePtWi4JVHfcafq8l0zq1NKpinIZN7Q/A2g74bOR2MVLP2MCzyMjM3Ig2Uc7YiVEKg+t95NQiqqrmkQ44dw3m8hgLmd0mIiyynFAwVKkcRGYT1yJ7Ydjl3OEzISACN99IhZz4KkHTVuGvS9oJaOnjq6fL4dKr9slugDw/x9GD1EP5K15hHFV3mcfTkP76i1r2FkyY/lNalqFCsinKB3GMQTcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzAGOelRAv5ki/nbdjsf/zB4fwKknW20ezHFghZgY8g=; b=Kd770PXo2I4GjKM/09w0poxc8ch+CEg7nKh93o43lh1dBRVBQSuVkxr5vGLFXSVKYI8IRfieP59tY3sZbHJBmyb/WyZ0cjJiI27lh+YDV020is91NyKsm5cWkfI1r3b8DWmPkP2DyAjFO8kwyTtwNX1Q6GAcZJT2Fqk9tXAZ/vQyLZnR8RUQbgfwxfuEzMhu0FLMjok6BovBd/KacdX1AcWgzwbW68LLKBQJMA78VPeY6WEL0VjoEanUCs7cqTSvFICGzWQjHG+RpG28smWKrT9M3loCO0jem4BPqCCKEMTDQgYSRxrPgxp5uBhAJQaizRuCDoULGYJyLacRNYyolQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3a5a1efc-e610-e151-fa58-25cfd9177f26@suse.com> Date: Tue, 5 Jul 2022 18:19:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: =?UTF-8?Q?Ping=c2=b2=3a_=5bPATCH=5d_x86=3a_enable_interrupts_around?= =?UTF-8?Q?_dump=5fexecstate=28=29?= Content-Language: en-US From: Jan Beulich To: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Cc: Wei Liu , "xen-devel@lists.xenproject.org" References: <66616751-24a8-7678-774b-35f6da4ad0b3@suse.com> In-Reply-To: <66616751-24a8-7678-774b-35f6da4ad0b3@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR0502CA0057.eurprd05.prod.outlook.com (2603:10a6:20b:56::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a108c00a-aa67-4a7d-39a2-08da5ea2299b X-MS-TrafficTypeDiagnostic: HE1PR0402MB3321:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vTBmpQYcpbj6MYJQyYWpPnbkU3XHJXPoXX7fDflyVmUbv7YTKZOVwn/XnDB4Me+2ojNPE8Ts/0b2Z4ikESHF6jSjGIlm2SmcnXDGj4jkonyomZ5r3fXg7aYvVxppYzkP5qlyjXSsb31Awm+PvWHUpxfhS1G1DVUM+949ARD87nm24fVTHCw3qGrdAZStUayZYTRWD6m1/M5V6KM9iZrjtbP0kqBgnbGnsCJzAMt75tGPpzluaNiFI+8AT9vWG8gRC6Xp4ReV9PHvd+DFYemQDGcmDH5UPnRnSOBntO5nMH0O02yGQ12jhZgfV2RTHq9jWPuqm37mMRZsiTCBUR8D8OsOvhmod3AxkD4X+4v8lihEP1yMKvjcMEMQSW1kzrlPTFZUzg/pwMduHJGPNRjaIrxw30qNmc0nBm8FjhBNHDQEmiuZ24ExUSbz9NoclNJdawmq4a5SLeizGJqoj31teFnZ6rxl+2w5HC5xq5+o15vg0HtIPRZy35DcNeK9ce/a9m7aJxNdOz9YC8SW91rXUrJO1Ov3twHUaH0Nf7CZ2+ABDF2shTNy239X+1a96OLd8M/hPTrDNIDiZFplLSTrf3a9nlsNL52StDEYiw3DIPQtGPmdzOAn7XEi43NPZL0AUUbp4K3m6XiGBH72iLrnDeXZ/Hbh1IXyYKgXeoWYoRVOtlnML9LgwdwvWDdIcFyIMLQ+FmlLvgctp/fmk/FLldIwKGZSlVygRAz+aqb5vxpvHP44wy962Rv+4M/hWnwq1mz1ZQ1VWi0g45YRaWsYXJ4nPJCW/xuYX5RVuu9LJajn4NVija14kpsaDW7nk6kSrw9I7tHYnXmRmqspIJbNI2TcFrAy4wzhsb2yuz4q++0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(376002)(346002)(39860400002)(26005)(6512007)(66946007)(83380400001)(41300700001)(2906002)(4326008)(66476007)(66556008)(5660300002)(6486002)(8936002)(2616005)(478600001)(186003)(53546011)(31696002)(110136005)(54906003)(36756003)(6506007)(31686004)(316002)(38100700002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c25yVmVrdlRFL0huVkVQbnRiRnBESTJmRjY4b0lIM1N6ZkJQYjJaQlpGSVZm?= =?utf-8?B?dEVMZEJiYWFkWFZnL2JDekJESmVCemZyMDhIb0RUZ3g0RlFsVGwrd3BmTit1?= =?utf-8?B?MGExMUlKMHlUYy9wMFViWGRtMmxZVTViUDJ1UEV4SmpRcyt1MkRwdG5nNEd4?= =?utf-8?B?Y0hlbFlOTzdFRS9ZUjJJMlMzK2VFb1A0T3BTaDdxcGtoMzdldmQ4KzQvcFhn?= =?utf-8?B?NEhoV0JvVWlwREFjdGNUWDhSOGJGaE5Wd0pSLzU4NDdvbkVFZTFmQ2gzTG9W?= =?utf-8?B?V0xJRHZQaDNna21LZzBLQjBveDM2QmNWbXp1OTFTK1IvdmFVWFg5ZHlvNkJZ?= =?utf-8?B?R1g1N0VaOTY1cVIzU2ZQaWZmZ1JuZUJ2bi9FRG9ySVBJQVJDWE05czN1ZEYw?= =?utf-8?B?Y1hiUzB2YUFMR2JYblhOU1g3VGpERmlZQjhVOFVtSHNuOHhVL3YwWXdiTzJH?= =?utf-8?B?cmxOSU5lTjR4VFdSRU0yTDB2TkhnYmpGT2dNazd1citMdDI0YitSQkZLbG1K?= =?utf-8?B?SHBBKy8xVmJtbUc2V2VMR0NVYWNBbDVtbGoxNVB1c2tQZ0lhZTFhQ1FuUlc5?= =?utf-8?B?cXVwbk1lQjVqbmg0L0N1Q1kxTWYrOFYyeGpiS1Zlb3ZpbUlIMU1GSmo4TGdo?= =?utf-8?B?b3VHc1AwTmZPZThGQmExQU1Xc3czbGM5QzdkWmMzMS8xYUkvK2x6cEw5YnN2?= =?utf-8?B?SWFFaUdHckVpclJ5M205YlcwUC82NllVcEJWVkViWkJIK3A1MFZFVUZIWTln?= =?utf-8?B?RkdMZG5RekZCcU54MkJMRThTK014eGFKNWk3SmQ0SjRzMmFGZVA3WjZqNDJx?= =?utf-8?B?QWlPclVaUnMyVVgyMTFrdXZWWk5SWjNuTFAxUFRUL1M0aGFZT3BXcGw3c0o5?= =?utf-8?B?Vzd1Sk02a2xnMjhGL0pMQ1A2bjhKOUZiY3FIMmZGUGhENm5mTUZ0dGkxenJW?= =?utf-8?B?cEpIQWxTZ0NkMFB5Vm5ZWEJpdHVYTWQvU2xqem9hRGYzMTdmbGxyV2NwYVlK?= =?utf-8?B?TGozSTVvTUNZcU9iNzIyU0ZNL2J4VW5vRjIvZlhBbm1QaHFHdjFwY0NPa1NB?= =?utf-8?B?RlZlSktiYnVrMzl2cjR4bzl4MHFRZjFXdm9KZERzQzlPc2ltUWplWEZqR0hT?= =?utf-8?B?QmlYSU5GT0d2N2JMQmwyYU12RDB5bEI0Z0lydmtheUd5TnA5R3lwMml3WjhB?= =?utf-8?B?ZUpFeFlKa2JLMkhaU2VTTDlkMWRiNUlWM1dzK011LzMrbzlBY29USG4rTHdH?= =?utf-8?B?dzMwSXFqemR0eVdjbytDTjhObW9KaTZYR3cvdVNBVGk5OHVnUWlpTWRQVXk1?= =?utf-8?B?Smh5RDRxSTlNRHFESzFPRjZQeXl1SDFzMzl0NlVsRElvTXlIS0NvTno0eWRV?= =?utf-8?B?Yk84MDNQUGI3VnNFcEgwMUd6dVE4bVhvUjF3UTVvV1hzNGRNT05BMVA5czNO?= =?utf-8?B?WWtIakc4eUxBdmNFSnpzTWdpbGZuTFJTaDdaZ0RWczN3azdFQ3YvaXFQbkV0?= =?utf-8?B?S1lBL0ZMOEpncVlYOEw4RlVPQkcxRmJpN2FNUGhHcHpWTm9Fc050STlCY1Y1?= =?utf-8?B?M2FqbFZRU2JRK2dudWNlaFFtV3owSExZM0tvcmNWanlzSGNocW9MemZhcFNr?= =?utf-8?B?cXZFc2lJWEtzRDMvS252cit6dVUreTN5SERVUFViYUlyTE1NYXk0RjdsODhl?= =?utf-8?B?SXNtZXRCR0tuZHFsWFNHUGJpKzdjWlRPUE1uTlNTMU5IakIrYlBGKzVMeHhP?= =?utf-8?B?WkRQbEdicVJoYmtTSngyMnlqQTlHajkrZUtpejNoZTBjRVllVEJCWVdKVTFB?= =?utf-8?B?eHZxaTNwUzdGcGxMbVJxT3VLUGxZUlE0SGZOZjFYUEZHY2x1QjlOYWt0b3Zh?= =?utf-8?B?eWRnemUxd3BRc3hzaXROeWJUUzMvRE5JSTdPaDFTdnFrVjZ3MytKaE5qVTZS?= =?utf-8?B?cC80eEp3MEpXYm93d1hlU1ZveUNHbnpFZStueW16ZWtHTExHdTcraDhvL0NN?= =?utf-8?B?WnNoMmJtRlF3aTVKenlMSlk2RkJZdE9LZyt0VzdRS0p3RE9TT0lpZVQ3NitI?= =?utf-8?B?TUZLUDdScnRqek5ZeHIxckFsdENYaUlVd0lIdDJ6dDlGWlBaRXMxd1M2b1Zx?= =?utf-8?Q?YePG1sf8lpx/0yTiL4i8N3x7p?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a108c00a-aa67-4a7d-39a2-08da5ea2299b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 16:19:40.3660 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dtpbPGL14HrdnpspuDSQ50pjfn8EX7KlzMAwWLaTyXhAnp+gJN+86D5/wFRVncPXAsZdRmzlKQKYQqfq/P/bTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB3321 On 11.01.2022 11:08, Jan Beulich wrote: > On 16.12.2021 14:33, Jan Beulich wrote: >> On 16.12.2021 12:54, Andrew Cooper wrote: >>> On 13/12/2021 15:12, Jan Beulich wrote: >>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>>> the consistency check in check_lock() for the p2m lock. To do so in >>>> spurious_interrupt() requires adding reentrancy protection / handling >>>> there. >>>> >>>> Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_state()") >>>> Signed-off-by: Jan Beulich > > There's a bug here which we need to deal with one way or another. > May I please ask for a response to the issues pointed out with > what you said in your earlier reply? I sincerely hope we won't ship another major version with this issue unfixed. The only option beyond applying this patch that I'm aware of is to revert the commit pointed at by Fixes:, which imo would be a shame (moving us further away from proper PVH support, including Dom0). Thanks, Jan >>>> --- >>>> The obvious (but imo undesirable) alternative is to suppress the call to >>>> show_hvm_stack() when interrupts are disabled. >>> >>> show_execution_state() need to work in any context including the #DF >>> handler, >> >> Why? There's no show_execution_state() on that path. >> >>> and >>> >>>     /* >>>      * Stop interleaving prevention: The necessary P2M lookups >>>      * involve locking, which has to occur with IRQs enabled. >>>      */ >>>     console_unlock_recursive_irqrestore(flags); >>>      >>>     show_hvm_stack(curr, regs); >>> >>> is looking distinctly dodgy... >> >> Well, yes, it does. If you have any better idea ... >> >>> For these kinds of purposes, it ought to be entirely fine to do a >>> lockless pagewalk of the p2m, because we have to maintain atomicity of >>> updates vs the hardware pagewalk anyway.  We do not care about any side >>> effects if the target isn't a RAM page. >>> >>> That ought to remove any IRQ problems from the equation. >> >> First - how do you suggest to signal to the page walk logic that there >> should be no lock acquired? And then I don't think there's a direct >> relationship here with what we need to guarantee correct hardware page >> walk behavior. Unless you mean to suggest that here we want to rely on >> either locking or interrupts being off (the latter guaranteeing that >> flush IPIs wouldn't complete while we're still doing software walking >> here). >> >> Jan >> >> > From xen-devel-bounces@lists.xenproject.org Tue Jul 05 16:33:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 16:33:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361483.591039 (Exim 4.92) (envelope-from ) id 1o8lUU-0007G0-7M; Tue, 05 Jul 2022 16:33:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361483.591039; Tue, 05 Jul 2022 16:33:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lUU-0007Ft-4m; Tue, 05 Jul 2022 16:33:34 +0000 Received: by outflank-mailman (input) for mailman id 361483; Tue, 05 Jul 2022 16:33:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lUT-0007Fj-DU; Tue, 05 Jul 2022 16:33:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lUT-0000jV-Ap; Tue, 05 Jul 2022 16:33:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8lUS-00035e-TO; Tue, 05 Jul 2022 16:33:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8lUS-0008AT-Si; Tue, 05 Jul 2022 16:33:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SERdplDQqnLGoG6YRUhbwLdPaa/josmxJJ1JO6ZLHO4=; b=06p67u34KXi88HPa1cU2f26/ti cgI/DX910HQjeisj+PDfFFKd3HOFKzNP2TKxN1dRd0KAyxWHK3oV33POwVsnsWUmlapnGcxrBWI/B tIF5xFPyf7RsU/uWGpeJ4tOUpdY0ElbTn0CqCzj0yQ1ksdzfKaLJj3ixdv31d9h5ClxE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171501: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a4d4c541f58b378bc9d499dcb554eb9fe22312c8 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Tue, 05 Jul 2022 16:33:32 +0000 flight 171501 xen-unstable-smoke real [real] flight 171504 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171501/ http://logs.test-lab.xenproject.org/osstest/logs/171504/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a4d4c541f58b378bc9d499dcb554eb9fe22312c8 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 1 days Testing same since 171501 2022-07-05 12:03:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 18:07:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 18:07:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361499.591053 (Exim 4.92) (envelope-from ) id 1o8mws-0000Xv-5h; Tue, 05 Jul 2022 18:06:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361499.591053; Tue, 05 Jul 2022 18:06:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8mws-0000Xo-35; Tue, 05 Jul 2022 18:06:58 +0000 Received: by outflank-mailman (input) for mailman id 361499; Tue, 05 Jul 2022 18:06:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8mwr-0000Xi-1t for xen-devel@lists.xen.org; Tue, 05 Jul 2022 18:06:57 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40aa4b69-fc8d-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 20:06:54 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id z13so21838994lfj.13 for ; Tue, 05 Jul 2022 11:06:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40aa4b69-fc8d-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xm9cRnemvM2twGxx12IaU3wNC0/7wuDcrWZFyp+aCCw=; b=P7Wl3YdFag8Abxx4LfcrDjXIKPqHVyRZxnhKH15469ihaLBzSkN3d1h1EZZPlyAW1m mrxjd5VpwggHVKaPdBZIo2Lrq6XjTq/sSFiinApZXyteG5a8mT8PyFZwY9hXdb1ArlzN lCOj0v/lRWGqZCKR4F+Fj/WoypNAbSOPmWk98ToWLQtUtRnPsSXFVC8+BfKLeYtlXH9P w8f/tQ/nbrDIXjTkIe8ts6APK3Zi1zWpl+opmimxdWeAS8jDuFkgjMWMmTmX/jJo3gIQ HSVXnYilMyt1/9fzwkqLRaT5c6CCPMj42aItlgkhRPVt/Z/c3S+JxNxoaPECkak+qJst qUlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xm9cRnemvM2twGxx12IaU3wNC0/7wuDcrWZFyp+aCCw=; b=lWoIEn6QPr2iHgNI+MeK/Fop1rqkCVm30BOZ4KmcOKDXHnIx48/ZzdKDiuhYzkirOi 0ysdO79bXxW3Kn4r8M1tVLBNY7FrQy3SpmMrR+qF+0pNMaqpaIMeYkal8wckZvmPL4SA rnckiGgJWjWWwQCbZwgNVQbcqCW8VjWYOZD3nOgpeoCyy48oUZvxoPB2/0uGQGQjxM5Q RD3IYGXkFnPI8LhhFFdjBXHJEV+KMjW5PpQAgilaQrEKFrvMkcAkwgNrFJsQKp+j6eMt a8uOFKor+eCFCKWTb5htsw5cTkZIqlSg19J3byr8x0YXpi1KTRJfmDdui6RbN/FzBAjk jy6Q== X-Gm-Message-State: AJIora8JblWiMHpqPltRl/r/cH6nsC8KJUwXDViS5z5at2rlBVZSI2Ig n+pnp9+9OSL1p1rXSgNo4XqQiRTezY/6Vjs98oKz8DKe8vQ= X-Google-Smtp-Source: AGRyM1uSn/QH7bfzo5fp8z3n9qjaAvtm9f77xE8UGvbjK4eoo9jdTpV0RPWb6owf4zAnuoiQDx7luEfsq0K4sqS889k= X-Received: by 2002:a05:6512:11d2:b0:47f:7ca3:c533 with SMTP id h18-20020a05651211d200b0047f7ca3c533mr22885472lfr.388.1657044414289; Tue, 05 Jul 2022 11:06:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jason Andryuk Date: Tue, 5 Jul 2022 14:06:42 -0400 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Cc: "G.R." , xen-devel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 4, 2022 at 11:57 AM Roger Pau Monn=C3=A9 = wrote: > > On Mon, Jul 04, 2022 at 11:44:14PM +0800, G.R. wrote: > > On Mon, Jul 4, 2022 at 11:33 PM Roger Pau Monn=C3=A9 wrote: > > > > > > Right, so hvmloader attempts to place a BAR from 05:00.0 and a BAR > > > from 00:17.0 into the same page, which is not that good behavior. It > > > might be sensible to attempt to share the page if both BARs belong to > > > the same device, but not if they belong to different devices. > > > > > > I think the following patch: > > > > > > https://lore.kernel.org/xen-devel/20200117110811.43321-1-roger.pau@ci= trix.com/ > > > > > > Might help with this. > > > > > > Thanks, Roger. > > I suppose this patch has been released in a newer XEN version that I > > can pick up if I decide to upgrade? > > Which version would it be? > > > > On the other hand, according to the other experiment I did, this may > > not be the only issue related to this device. > > Still not sure if the device or the SW stack is faulty this time... > > I don't think this patch has been applied to any release, adding Jason > who I think was also interested in the fix and might provide more > info. Roger wrote the above patch after I tried to upstream a Qubes QEMU patch https://lore.kernel.org/xen-devel/20190311180216.18811-7-jandryuk@gma= il.com/. The patch rounded up BAR sizes for passed through devices which ensured they couldn't share a page. But Roger rightfully pointed out that changing the BAR size is incorrect, and hvmloader could just enforce a minimum alignment. However, nothing prevents a guest from relocating the BARs again. I tested Roger's patch, but Qubes and OpenXT have kept using the QEMU patch. When I added the QEMU patch to OpenXT, I wrote in the commit message that it fixed probing an e1000e nic Regards, Jason From xen-devel-bounces@lists.xenproject.org Tue Jul 05 18:22:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 18:22:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361506.591064 (Exim 4.92) (envelope-from ) id 1o8nBy-00032R-Fs; Tue, 05 Jul 2022 18:22:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361506.591064; Tue, 05 Jul 2022 18:22:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8nBy-00032K-DE; Tue, 05 Jul 2022 18:22:34 +0000 Received: by outflank-mailman (input) for mailman id 361506; Tue, 05 Jul 2022 18:22:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8nBw-000329-Mu for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 18:22:33 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d48a75e-fc8f-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 20:22:30 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657045341126785.541076843804; Tue, 5 Jul 2022 11:22:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d48a75e-fc8f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657045347; cv=none; d=zohomail.com; s=zohoarc; b=jwte+WeMH47M0VffBiB+WjagJkAx1HlOcCG71PBrM8WHM/UDAV1QFbPRCxMZGDStPBu920NSLssLeeJ89VbcMXO9Uxnfwy8ZqnfysyqXiVT7A0navHVpiB32yVYkNkfkv/5SaKfx4DYJYF/BMbqHEtVVL2WK00xcf4dQtaGgcWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657045347; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Omgu0DEoeFPmQOIcUYF8shs0R/nLUy9MKTdQBW8vjJ4=; b=J1VJpqfOLEYALrcC1gBiRz+fGlQ3Uv9ybFVUsGeTECBCzehi3f5w5sF+PCJF+eeKTJ42OxMwtWH9tHlI8Lcz9znAecVNIhIcp0InvxqiwIzOYLzCOA0Y7KJH5M6sS5l8AE27TqQ7QIvs2qxsx1RLtrU1oLpGJLAil66iiwkRXno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657045347; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Omgu0DEoeFPmQOIcUYF8shs0R/nLUy9MKTdQBW8vjJ4=; b=toZzoQ1QARc31aCI7s3NDKFmxW7FgBgiG90tRuVGzS2pLMV8Hg8J5lgkHIoArgUI J3+deDaP2gCJrEIPuovBuWwU/fG7s/1JbFLgSyxkK6KsF3h15MEIfOvktL/OPgJi18v eKMXDQz8mofEwogdAOX4FQv4e25EN3R1XoBK8++k= Message-ID: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> Date: Tue, 5 Jul 2022 13:35:19 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Jason Andryuk Cc: xen-devel , Scott Davis , christopher.clark@starlab.io, Daniel De Graaf , Wei Liu , Anthony PERARD References: <20220630022110.31555-1-dpsmith@apertussolutions.com> <20220630022110.31555-4-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v9 3/3] xsm: refactor flask sid alloc and domain check In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/5/22 09:03, Jason Andryuk wrote: > On Wed, Jun 29, 2022 at 10:22 PM Daniel P. Smith > wrote: >> >> The function flask_domain_alloc_security() is where a default sid should be >> assigned to a domain under construction. For reasons unknown, the initial >> domain would be assigned unlabeled_t and then fixed up under >> flask_domain_create(). With the introduction of xenboot_t it is now possible >> to distinguish when the hypervisor is in the boot state. > > There is no "default label" which is why unlabeled_t was used. > flask_domain_create() does permission checks before setting the label > from the config. The call to flask_domain_alloc_security() is in a shared code path for both the hypervisor and toolstack domain creation. As such, there is no label provided since it is not desirable to codify the domain label in the general hypervisor code for when calling that shared path by the hypervisor during setup. Since the function is responsible for allocating the struct domain_security_struct{}, it is unwise to leave the value uninitialized, zero/0, as that in a non-existent sid. Therefore it implements a rudimentary assignment policy where if the current domain is the idle domain, it assumes it is constructing one of the system domains otherwise by default it assigns unlabeled_t. Additionally, if a sid of 0 is provided by the toolstack, either by not setting the sid or incorrectly setting the sid to 0, the result will be that the security server will assign the label unlabeled_t to the domain. This is what is meant by referring to it as the default label. It should be noted that under the default policy, unlabeled_t is not a valid type for a domain to run under. The result will be a failure as there are no rules to allow the construction of domains with this type. > flask_domain_alloc_security() > - mallocs domain_security_struct > - sets sid for system domains xen_t, domxen_t, domio_t > - is called for all domains. and you missed, - sets sid to unlabeled_t for all other domains. The missed action along with the second action is what goes to the point I was making in the commit message. This is because prior to the introduction of xenboot_t, the only means to distinguish between boot/setup time and runtime is if the domain id is a system domain id. The basis for that limited distinction comes from the assumption that domain_create() will block the use of a domain id from the reserved range if the current domain is not the idle domain. For which, it should be noted that there may be some unintended consequences. Whereas, with the introduction of the xenboot_t label, there is a slightly stronger binding to what state the construction of the domain is occurring. > flask_domain_create() > - special cases labeling dom0_t so it can only be done once. > - otherwise, ensures current has permission to domain_create. > - sets sid for both cases. > - has the config->ssidref passed in. > - is only called for non-system, non-idle domains. I would clarify that last statement, 'is only called for domains which require construction and assignment of resources', where assignment of resources refers to resources that will be labeled based on domin's sid, eg. domU_t_channel. >> This commit looks to correct this by using a check to see if the hypervisor is >> under the xenboot_t context in flask_domain_alloc_security(). If it is, then it >> will inspect the domain's is_privileged field, and select the appropriate >> default label, dom0_t or domU_t, for the domain. The logic for >> flask_domain_create() was changed to allow the incoming sid to override the >> default label. >> >> The base policy was adjusted to allow the idle domain under the xenboot_t >> context to be able to construct domains of both types, dom0 and domU. > > Your patch special cases flask_domain_alloc_security() to assign > dom0/domU. You already have a config and therefore config->ssidref, > so that shouldn't be necessary since flask_domain_create() can use > that ssidref. As I stated above, flask_domain_alloc_security() contains an existing policy for setting an initial value for the struct security_domain_struct{} it is allocating based on assumptions that are believed to be true. With the introduction of the xenboot_t transition, a more solid set of assumptions can be made, which allows for a more refined assignment policy. Second, you are assuming there is a config that has a valid ssidref set. Currently, dom0less does not support passing a sid in their configuration. As I have reasoned the code and explained above, I do not see how dom0less could construct a validly labeled domU, or more than one domU with FLASK in enforcing mode. Based on my review, three scenarios would play out for dom0less using FLASK, 1. The first domain to be constructed was a dom0. The first domain would be created, labeled as dom0_t, the flag dom0_created would be set to one, and then constructed. All subsequent domains would fail creation because, - they would be labeled as unlabeled_t by flask_domain_alloc_security() - the parameter ssidref to flask_domain_create() would be 0 - the !dom0_created check would fail - the call to avc_current_has_perm() would fail With avc_current_has_perm() failing because ssidref's value of 0 will be converted to unlabeled_t and the default/reference policy will deny xenboot_t domain create of unlabeled_t. The system will panic when the first domain creation failure occurrs. 2. The first domain is a domU and remaining may be either dom0 or domU. The first domain would be created, incorrectly labeled as dom0_t, the flag dom0_created would be set to one, and then constructed. All subsequent domains will fail as they did in case 1, and again the system will panic on the first domain creation failure. 3. A system with only a single domU. The domain would be created, incorrectly labeled as dom0_t, the flag dom0_created would be set to one, and then constructed. The system will then finish and transition to running with the single domain, except that domain will be fully privileged and not a domU as intended or expected. > I don't see a precise reason for why this change is needed in the > commit message. I know you are working on hyperlaunch, but I'm > guessing at the rationale for this change. And hyperlaunch should be > passing in a config with ssidref set instead of relying on the flask > code to auto assign, so I'm not sure of why this change would be > needed for hyperlaunch. Apologies, I was attempting to be concise and hit the main points versus a long diatribe. While FLASK is not security supported, we should still ensure that dom0less works completely as expected. Additionaly it should support traditional intial domain, dom0less, and the upcoming hyperlaunch without having to be special cased for each configuration. While hyperlaunch will provide the ability to specify a sid in its configuration, the initial domain and dom0less do not. Changing the XSM interface to suit the single instance of the former versus the two instances of the latter would seem slightly biased. To summarize in another way, FLASK has an internal sid assignement policy for when the hypervisor is contstructing domains during boot. This is so the main hypervisor code does not have to be made FLASK aware and potentially create a layering violation. The current sid assignment policy is split between allocation of the domain's security structure and the domain creation policy check. The hypervisor has evolved since this policy was incorporated, seeing the introduction of dom0less and soon hyperlaunch. This latest change introduces a new security context for the hypervisor during setup along with a domain transition for when the hypervisor moves to the running state. With this new distinction is now possible to construct a more informed initial sid assignment policy for domains conrstructed by the hypervisor. The new assignment policy exapnds the existing policy to say that if domain is not a system domain and the hypervisor is currently in the boot/setup state, inspect the domain config to see if it is a privileged domain, and set the label either dom0_t or domU_t accordingly. The new initial sid assignment policy results in all of its logic being centralized under the function flask_domain_alloc_security(). This allows for the logic of flask_domain_create() to morph, were by the parameter ssidref may now be treated simply as an override of the initial sid assignment that a toolstack or a hypervisor domain builder, such as hyperlaunch, may use to set the appropriate label. > Is the issue with only having a single creation of dom0_t? Can you > change create_dom()'s dom0_cfg to specify the ssidref when creating > dom0. I guess that would need a new xsm_dom0_ssidref hook (or > something) to hide away the flask code. But that way there is less > special casing in the code. flask_domain_alloc_security() could be > left unchanged, and flask_domain_create could() be streamlined to just > check the passed in ssidref. How does that sound? As I noted above, coding in a flask label into main hypervisor code would be a layering violation as it would assume the only XSM that would ever use the struct domain_security_struct{}. This would defeat the purpose of the introduction of struct domain_security_struct{} as it previouly was assumed to be a flask security label. Also previously mentioned, it goes beyond just dom0 config. Currently dom0less does not have a way to specify the sid in a domU domain config. This would mean another place with a flask label, domU_t, would have to be codified into main hypervisor code. IMHO, with a possible minor adjustment (see below), the approach here is the correct one. The two functions have distinct roles, flask_domain_alloc_security() is for allocating the structure and ensuring it is properly initialized. While flask_domain_create() is where the check occurs if a domain of either the initially assigned type or of the requested type, ssidref parameter, are allowed to be constructed by the current domain. That is what is acheived here without having to introduce a layering violation. >> Signed-off-by: Daniel P. Smith >> --- >> tools/flask/policy/modules/dom0.te | 3 +++ >> tools/flask/policy/modules/domU.te | 3 +++ >> xen/xsm/flask/hooks.c | 34 ++++++++++++++++++------------ >> 3 files changed, 26 insertions(+), 14 deletions(-) >> >> diff --git a/tools/flask/policy/modules/dom0.te b/tools/flask/policy/modules/dom0.te >> index 0a63ce15b6..2022bb9636 100644 >> --- a/tools/flask/policy/modules/dom0.te >> +++ b/tools/flask/policy/modules/dom0.te >> @@ -75,3 +75,6 @@ admin_device(dom0_t, ioport_t) >> admin_device(dom0_t, iomem_t) >> >> domain_comms(dom0_t, dom0_t) >> + >> +# Allow they hypervisor to build domains of type dom0_t >> +xen_build_domain(dom0_t) >> diff --git a/tools/flask/policy/modules/domU.te b/tools/flask/policy/modules/domU.te >> index b77df29d56..73fc90c3c6 100644 >> --- a/tools/flask/policy/modules/domU.te >> +++ b/tools/flask/policy/modules/domU.te >> @@ -13,6 +13,9 @@ domain_comms(domU_t, domU_t) >> migrate_domain_out(dom0_t, domU_t) >> domain_self_comms(domU_t) >> >> +# Allow they hypervisor to build domains of type domU_t >> +xen_build_domain(domU_t) >> + >> # Device model for domU_t. You can define distinct types for device models for >> # domains of other types, or add more make_device_model lines for this type. >> declare_domain(dm_dom_t) >> diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c >> index 8c9cd0f297..caa0ae7d4c 100644 >> --- a/xen/xsm/flask/hooks.c >> +++ b/xen/xsm/flask/hooks.c >> @@ -182,7 +182,15 @@ static int cf_check flask_domain_alloc_security(struct domain *d) >> dsec->sid = SECINITSID_DOMIO; >> break; >> default: >> - dsec->sid = SECINITSID_UNLABELED; >> + if ( domain_sid(current->domain) == SECINITSID_XENBOOT ) After some thinking while responding to the review, this check should move to the top and be negated. When requesting an allocation, if that request was not by the idle domain during startup, then it should immediately set the sid to SECINITSID_UNLABELED and return immediately. Making it past that check will mean that the request is from the idle domain during setup and should apply the initial sid policy. >> + { >> + if ( d->is_privileged ) >> + dsec->sid = SECINITSID_DOM0; >> + else >> + dsec->sid = SECINITSID_DOMU; >> + } >> + else >> + dsec->sid = SECINITSID_UNLABELED; >> } >> >> dsec->self_sid = dsec->sid; >> @@ -548,23 +556,21 @@ static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref) >> { >> int rc; >> struct domain_security_struct *dsec = d->ssid; >> - static int dom0_created = 0; >> >> - if ( is_idle_domain(current->domain) && !dom0_created ) >> - { >> - dsec->sid = SECINITSID_DOM0; >> - dom0_created = 1; >> - } >> - else >> + /* >> + * If domain has not already been labeled or a valid new label is provided, >> + * then use the provided label, otherwise use the existing label. >> + */ >> + if ( dsec->sid == SECINITSID_UNLABELED || ssidref > 0 ) >> { >> - rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, >> - DOMAIN__CREATE, NULL); >> - if ( rc ) >> - return rc; > > The old code returned here before... > >> - >> dsec->sid = ssidref; > > ... setting the sid. That is more robust since if the function fails, > the sid is not changed. It's not a problem today as the > xsm_domain_create() return value is checked, but it is more robust to > restore that property. You are right, my intent/assumption was to rely on the code calling an access check to correctly handle a failure response. I should reverse the logic and use ssidref as the temporary holder of the value to check, and only place that value into the struct on a successful check. > Regards, > Jason Thank you for looking at this. v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:02:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361535.591093 (Exim 4.92) (envelope-from ) id 1o8pgg-0003qi-6Q; Tue, 05 Jul 2022 21:02:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361535.591093; Tue, 05 Jul 2022 21:02:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgg-0003qa-3H; Tue, 05 Jul 2022 21:02:26 +0000 Received: by outflank-mailman (input) for mailman id 361535; Tue, 05 Jul 2022 21:02:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pge-0003b1-IA for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:02:24 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c427c8de-fca5-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 23:02:23 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id cl1so19261074wrb.4 for ; Tue, 05 Jul 2022 14:02:23 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id l26-20020a1ced1a000000b003a03ae64f57sm2897401wmh.8.2022.07.05.14.02.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:02:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c427c8de-fca5-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AQT9Zg3S1V+SLzJ9mIrWY3ddQbg0abcQqmYDqdswck8=; b=AFccQjNrQmfDG4VaWaef4xE8J6saJ7xJQU2+GqZgfhh3f4xKHvoOcergdPc8v6EZHB W8PpgIETewLVrLtE8R9SgobXUK/+twapNT7rfOAAy8o4KG1q9tilbcZ0O5lpDnjfffkm wpGNB4Co6W2b6dHDkhfv8qn6WvH6EmfRxh01kBX/nvQyCXNt2jwTye2XekvYS48NH1Gj XsVm+ZjelZR5VC4Cuxmm5CsT/9OLLqJRlX6jvF5n/TPuyRiQ3Wt878V/IACErpUdPda+ uQB4YXgo5oRIcn1dJoWBZOcOM0Amy/UkcShxImHmtnp49oxqJXh85b0T43VICgbLUSMs +wtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AQT9Zg3S1V+SLzJ9mIrWY3ddQbg0abcQqmYDqdswck8=; b=gttK81RYvI/aXKZNBVphCbKabgnQRFPxCCoLzGrfCyekcIjqDRFTjrGVNt6YYD77rf tPrkBXKjfrSQsXAwsAgNiHIE2eMnSyjwpVN4iY20gp2jC6DOHpxnMTl6SpWODVCiA3Jr MMe+ri8a6PbYCOgflZaTJJfUrtaq7qwsfp42/Eg9DBLHyEfOVCiFwK+cOChPyA1srq4K E3webX8slzDOBNzY7q4ZoC4VcPOETU8IyVES6G2N9/p82hegJO2blUYWITTssZQ6j+Gu i4cH7p5fpY+tSuCRzSmp00QGB5XtyVCHFOjaAsZfOLUFIA2nFxc5emPb0hKK4GAOsz8r QF2Q== X-Gm-Message-State: AJIora9sev63NwgQqd8MyW/UfIBU5AsfOFTMHhCYHhGVvpx4AKU3Ef4M /zZWq7uwrP82ySSVS8MzULnDCo4Ibe8= X-Google-Smtp-Source: AGRyM1uPOb9BIMjvnqYCviSjSCmTkegKo3dPghVnCPYleuQuvV702Na9iW7j4NSzdmepl3cQRLxReQ== X-Received: by 2002:a5d:64c3:0:b0:21d:720c:4ade with SMTP id f3-20020a5d64c3000000b0021d720c4ademr5695443wri.570.1657054942891; Tue, 05 Jul 2022 14:02:22 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations Date: Wed, 6 Jul 2022 00:02:15 +0300 Message-Id: <20220705210218.483854-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705210218.483854-1-burzalodowa@gmail.com> References: <20220705210218.483854-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the function prototypes of the functions below in header file so that they are visible before the function definitions in traps.c. enter_hypervisor_from_guest_preirq() enter_hypervisor_from_guest() do_trap_hyp_sync() do_trap_guest_sync() do_trap_irq() do_trap_fiq() leave_hypervisor_to_guest() Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/processor.h | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index c021160412..74cc07028f 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -576,10 +576,24 @@ void vcpu_regs_hyp_to_user(const struct vcpu *vcpu, void vcpu_regs_user_to_hyp(struct vcpu *vcpu, const struct vcpu_guest_core_regs *regs); +void enter_hypervisor_from_guest_preirq(void); + +void enter_hypervisor_from_guest(void); + +void do_trap_hyp_sync(struct cpu_user_regs *regs); + +void do_trap_guest_sync(struct cpu_user_regs *regs); + void do_trap_hyp_serror(struct cpu_user_regs *regs); void do_trap_guest_serror(struct cpu_user_regs *regs); +void do_trap_irq(struct cpu_user_regs *regs); + +void do_trap_fiq(struct cpu_user_regs *regs); + +void leave_hypervisor_to_guest(void); + register_t get_default_hcr_flags(void); /* -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:02:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:02:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361538.591126 (Exim 4.92) (envelope-from ) id 1o8pgj-0004cx-WF; Tue, 05 Jul 2022 21:02:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361538.591126; Tue, 05 Jul 2022 21:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgj-0004bp-S0; Tue, 05 Jul 2022 21:02:29 +0000 Received: by outflank-mailman (input) for mailman id 361538; Tue, 05 Jul 2022 21:02:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgi-0003b1-Ob for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:02:28 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6cbaf4e-fca5-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 23:02:28 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id bi22-20020a05600c3d9600b003a04de22ab6so7947890wmb.1 for ; Tue, 05 Jul 2022 14:02:28 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id l26-20020a1ced1a000000b003a03ae64f57sm2897401wmh.8.2022.07.05.14.02.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:02:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6cbaf4e-fca5-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HkaVC8qOCJ3UPIdTEyzMpTlDCcABnjbSgrgYQldov+o=; b=cOLxgFWU8N514uleMGCElsG8ATfStWkMOMl3HupjfmkmLHTtbL1rGUAz7f4c8oxM5g v9ohz2MBgInX8iL0H1AHDZTYDvXxVdzAFYRMrNXR9zq8dI0/KA3mZJ1sPg9lhnL51/Yh 0r+s4UDih+Spb0ZnWvlMH64yJZ0VbtvyWla+RbDVrRUyV07GE3Bp6KC97QlhFTWAySW/ k41g3s3RGzpTNVY6c8kADqsi6MtWCNeoi8nqDB6VZ/J+2XpGnu2QLVphybduZvfy+JDo mlTIMYk9StQXcbQ9/qQEpJM0STKGUvezUj5gC0qZvQKG7GnQ9RjfYwIqzjoW2uOLamz+ 53Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HkaVC8qOCJ3UPIdTEyzMpTlDCcABnjbSgrgYQldov+o=; b=ML3WmNQOeDKQOajrfFpwpwcCI3AvsDYHhmvV71E4wNsgnSSBUia7ia2hHjCzGvS9K6 ics/ypVihjbA1OBRdrelQZc9IbnYuVFz7KBcB789pYB+ObdBXKNut06rb0lDvNK5iyS0 tjKYcew1IfOpdIWBhuo0yFaCP5ZQK1wHuwZlCdqroGkZ/avCS4A3hCcBjoZAB0V4BAhI SZbriTqiaZ8sitdaH/Lr7+V3koCpB63heGCsO5bumDdXuNQPpURix7IlrN7ZzuVjNZp8 plUbfYphGXdde6EsD6hQq50M6+s548+60WCnCz4fZkMdaS7a1xI2UmxMn/hCUPk9QEDd plPw== X-Gm-Message-State: AJIora8NG205kmcliLW5nKKKnphak7e5U1JiEhRtMHj7oW4i/4xZBTWF sY2lBAayAVA03AhPJ8V7YcRTaQu2Y0g= X-Google-Smtp-Source: AGRyM1u2zRzYBC+jrV2YPjoAyboW0KZhHp1AN41tOKejBwQEN9SyFWgw/PxlF8NaValM6teFAW/gfw== X-Received: by 2002:a05:600c:a18d:b0:3a0:2c9a:b3de with SMTP id id13-20020a05600ca18d00b003a02c9ab3demr37965632wmb.147.1657054947271; Tue, 05 Jul 2022 14:02:27 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 4/4] xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation Date: Wed, 6 Jul 2022 00:02:18 +0300 Message-Id: <20220705210218.483854-5-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705210218.483854-1-burzalodowa@gmail.com> References: <20220705210218.483854-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function pv_console_evtchn() is defined in the header . If the header happens to be included by multiple files, this can result in linker errors due to multiple definitions, So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 violation warning by making pv_console_evtchn() inline with internal linkage. Signed-off-by: Xenia Ragiadakou --- xen/include/xen/pv_console.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/xen/pv_console.h b/xen/include/xen/pv_console.h index 4745f46f2d..a96a6368b1 100644 --- a/xen/include/xen/pv_console.h +++ b/xen/include/xen/pv_console.h @@ -19,7 +19,7 @@ static inline void pv_console_set_rx_handler(serial_rx_fn fn) { } static inline void pv_console_init_postirq(void) { } static inline void pv_console_puts(const char *buf, size_t nr) { } static inline size_t pv_console_rx(struct cpu_user_regs *regs) { return 0; } -evtchn_port_t pv_console_evtchn(void) +static inline evtchn_port_t pv_console_evtchn(void) { ASSERT_UNREACHABLE(); return 0; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:02:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361534.591081 (Exim 4.92) (envelope-from ) id 1o8pge-0003bK-Ve; Tue, 05 Jul 2022 21:02:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361534.591081; Tue, 05 Jul 2022 21:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pge-0003bD-Sm; Tue, 05 Jul 2022 21:02:24 +0000 Received: by outflank-mailman (input) for mailman id 361534; Tue, 05 Jul 2022 21:02:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgd-0003b1-RL for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:02:23 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c385edb9-fca5-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 23:02:22 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id be14-20020a05600c1e8e00b003a04a458c54so7926303wmb.3 for ; Tue, 05 Jul 2022 14:02:22 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id l26-20020a1ced1a000000b003a03ae64f57sm2897401wmh.8.2022.07.05.14.02.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:02:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c385edb9-fca5-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fShJyLsuEBJvmB+AxoM45kGpo7E54ZlICruQClfnbYQ=; b=lN/RlgPdxLosRgl/RUNehMS+zBujbjqZeIquKP7n+dgLl9r2vzJBVBmaq866sW8rz/ xioMPEXn3gvtZBlQUKZmIRx8CO6gZT+gfbkwMiI1gVAzXFsksnMvkX41zpxH++0kM25b mzOFPWS2jbnUy9doUan1B/0bNJPIqBYVGwqL4qJYr5WeYzDUnIPZTcEiA864BkVAjdwE 5A6GqmZL57kWuoRdPIVwDyYTMETk7OBFgxmnKsVDF6LDNG6jXfTxWyRaPW8iBg1x2W1F GyW+/LZBy84IQGhcDjVdhSebMlNndJak1FdYJuYLgCSjMS06MtaX0Sis14Fg6nlsOY1r 5+Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=fShJyLsuEBJvmB+AxoM45kGpo7E54ZlICruQClfnbYQ=; b=6T1TEaBvapE6tsvjcApidUnVBKQBJ3NWkYqIiknQpuSFH2WNS5/DEI/zxt4Wk8sDNA tKO3d+/5s7WsmdPUKHlMsRnZFND5uZQ1I/p9d5rWNX8rrq7CnjYzB9D/gcxiJlEpkwur A65InwCKw45Bypec79xG0/MIbfnRpZyCrAmv4kLul7UzfaFNclnMHTc5qGFaNSxMneoJ h8hp8liZ5yAOea3sfaH5VEMU+q9FPd1u1w5xzzTUcreeweE/CQXIWTdX2cOBP/DtRnZS IV+OiDy24B07JLnJYssOLa+OLTahm8+tPu9RCdUfMmn9dgM9Wy4U1a8pRYR+f51AAnfR MDew== X-Gm-Message-State: AJIora9pLtJa8217ul9v+1Rr3L3cQMX4HZV8zuF1H8FenISPB7cu3xX3 wmEVobLQCillxYNAUy7Xwnf3sxllUTI= X-Google-Smtp-Source: AGRyM1sdv5WuHFDy3B7P/CrdXFDQZJ/oOpxLP4iIGhi466AXlXHQKk+H+s6HACjE3FidvC7Su0IK3g== X-Received: by 2002:a05:600c:4149:b0:3a0:4728:60e7 with SMTP id h9-20020a05600c414900b003a0472860e7mr37583366wmm.10.1657054941594; Tue, 05 Jul 2022 14:02:21 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH 0/4] Fix MISRA C 2012 violations Date: Wed, 6 Jul 2022 00:02:14 +0300 Message-Id: <20220705210218.483854-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Resolve MISRA C 2012 Rule 8.4 violation warnings. Xenia Ragiadakou (4): xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations xen/common: time: Fix MISRA C 2012 Rule 8.7 violation xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation xen/arch/arm/domain.c | 2 +- xen/arch/arm/include/asm/processor.h | 14 ++++++++++++++ xen/common/time.c | 2 +- xen/include/xen/pv_console.h | 2 +- 4 files changed, 17 insertions(+), 3 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:02:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361536.591104 (Exim 4.92) (envelope-from ) id 1o8pgh-00046F-HJ; Tue, 05 Jul 2022 21:02:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361536.591104; Tue, 05 Jul 2022 21:02:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgh-000468-DO; Tue, 05 Jul 2022 21:02:27 +0000 Received: by outflank-mailman (input) for mailman id 361536; Tue, 05 Jul 2022 21:02:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgf-0003lq-Ul for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:02:25 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c524462e-fca5-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 23:02:25 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id s1so19237088wra.9 for ; Tue, 05 Jul 2022 14:02:25 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id l26-20020a1ced1a000000b003a03ae64f57sm2897401wmh.8.2022.07.05.14.02.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:02:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c524462e-fca5-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2dN0B8zmPwKiHY8p7Il+e7JbeI1aQAoit1LVTiMKcLU=; b=qTK4Va1hmn9ohnH4FMyIgYbT7056l29OKtk+X4/QlVnhHjUkDqKah6paQRdHzk01hu 0Dvb7Dq05GxhI/Hrr1HdpWnI1MhLWUgG42yWxUdsr0/+g6HZT3YoBccC0SuptxpvMVlr WGqsAyNkzARye3oH/Pky/YiP2pLn1szcYcVOqg5IhjVLdq1U2RF9fbi6YXjboCRJplGK l9SVDrufSnsBflrB8ksbZ4uDi1edSIaIx4cE2LHwuw+3zz+3S3sh4Mgjk8gKDWUNTk/Y B6NsnS82u/GJEa3k2d+3zVWf1ACtq0pgwn24GddnKUZ6QkEgV4TBIDqVnLcTGkMCh0IU Peew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2dN0B8zmPwKiHY8p7Il+e7JbeI1aQAoit1LVTiMKcLU=; b=3FMh+dlUbliDnRfkWJQe2kSpU1EVDh0PO3HJOAWFn65A3WkUEa8MThZLvSzq+LjbZQ N71HT67EWa0eHNucMxUQNUEYgxI0JTPqLLAH4EmxZvFaaI1dBOz5nNlv+UQf3AnRJWZl FQC8Rsh5wwHtDynJMF+CFmN8+mhyjxTo8xuUuzjNJSaRyvV7cbGYhFbyA1oD6vE5BFUK 3b+obclT6HRZjf1uWNcLpT2Fh1bVWSFTJocnJOMvCup2cutL/a8T+30aEiFsrX9gSH1h gpUwdcMBXvGFMfnSssJP7El1iyQlmhI/E3bPKzP6pXn6WRtSRV6Quf6OzTzBmgN8nkBp uWng== X-Gm-Message-State: AJIora/wf4+cjAKbeW6txiUOdskmj7hGu2viTZJQNb+vxlSY2gyn4lG4 ObOGEIQsBjoGi3Shrf/2enaCp9hyYnw= X-Google-Smtp-Source: AGRyM1sP9RfOibNcXJdbvksizclgfrXbx73MiR//wCf/Pc9eWTz6chQXRh308WzUU+ea4PDMr+g9pg== X-Received: by 2002:a5d:5908:0:b0:21d:6e91:9f3 with SMTP id v8-20020a5d5908000000b0021d6e9109f3mr7917149wrd.52.1657054944466; Tue, 05 Jul 2022 14:02:24 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH 2/4] xen/common: time: Fix MISRA C 2012 Rule 8.7 violation Date: Wed, 6 Jul 2022 00:02:16 +0300 Message-Id: <20220705210218.483854-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705210218.483854-1-burzalodowa@gmail.com> References: <20220705210218.483854-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The variable __mon_lengths is referenced only in time.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou --- xen/common/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/time.c b/xen/common/time.c index 22379f4ae2..92f7b72464 100644 --- a/xen/common/time.c +++ b/xen/common/time.c @@ -28,7 +28,7 @@ ((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0)) /* How many days are in each month. */ -const unsigned short int __mon_lengths[2][12] = { +static const unsigned short int __mon_lengths[2][12] = { /* Normal years. */ {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}, /* Leap years. */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:02:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361537.591114 (Exim 4.92) (envelope-from ) id 1o8pgi-0004M9-NJ; Tue, 05 Jul 2022 21:02:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361537.591114; Tue, 05 Jul 2022 21:02:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgi-0004Ly-KT; Tue, 05 Jul 2022 21:02:28 +0000 Received: by outflank-mailman (input) for mailman id 361537; Tue, 05 Jul 2022 21:02:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pgh-0003lq-5Z for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:02:27 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c602b98c-fca5-11ec-924f-1f966e50362f; Tue, 05 Jul 2022 23:02:26 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id bk26so4174893wrb.11 for ; Tue, 05 Jul 2022 14:02:26 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id l26-20020a1ced1a000000b003a03ae64f57sm2897401wmh.8.2022.07.05.14.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Jul 2022 14:02:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c602b98c-fca5-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=u5CyUBshkwHYJe1DDZsq4HHBEadXEMKhCxZMzLCqLMY=; b=pI2j9/zHI21aJwS6t7AiKATAAuYp1jk4Y+8d8r/utSvmIN7Y63+dzeczux93fegJPl 0+Qgod/t4+J8ZoxHjjIMsmV9tV0Dswt3i/1sDsp5ywUUdC+kLbdMrDDmDOTEo4rpaSR0 rCZeElbSpHPi6ekBqc76afDvdrv1Pcq8vekyIp6hnn9mAywGw1Eb+uRoZv8OLZkNFjsR X5Qsps539A6OpdMMyjjktnlX2WG4iHg+xZRS6S5DIcLEN1BaIoRNQnh1dHS8/KBcyWm0 NTAo4PFy259xmcVkq31SaqQ8o1M4czuGxVMlE+rA/IYky+s03cgQ7AM8MU4ylSYQhbNG WToQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u5CyUBshkwHYJe1DDZsq4HHBEadXEMKhCxZMzLCqLMY=; b=s/i3L2EDuiKbPkO8Isg/xO6Q30Z9TIG1Ov4+NZRvYVbMmtxMY1wwGXCbB2ybiKLr8d W6LtA+PFx5N2CfD5R+3nTOtHrtKDgTaDsW9VVjFBkT/AyL38adHb1YUzv9OQYsVdnn8A +6770YqKzCAct8eUc1O+mMettQk/75HxIax6ssq7JnwzRcJWdJY0yqlYB0yAwN9eqIVa fJQ2Q4Kjblg34YHCDBjjneBMEZcoFs/SsGUN0qe7aG31MQQQI81XXizXaHpeA/eWEknm DMiFGQsY1kiRUUuO1Ca7iNRbMol+9C11IE4YHQKe5ymoFOJskz+ihY0amA7LSFR7MT4s aQrw== X-Gm-Message-State: AJIora8oMQ8siEXFXYiuJ146lTGDvwhaV8zQ8bflm/0xSysgAFGiB8JI xEjN8f/enQVnH7JXvuOJlqnWEQMW0Gw= X-Google-Smtp-Source: AGRyM1vet7biqpwvDs2fcDYUpJlzinBxtCC41x/DTfpg0WwqZhHmqlBMN/URFYIMTZX8CnXvUU795g== X-Received: by 2002:a5d:6da8:0:b0:21d:2598:4e28 with SMTP id u8-20020a5d6da8000000b0021d25984e28mr35759389wrs.373.1657054945791; Tue, 05 Jul 2022 14:02:25 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Date: Wed, 6 Jul 2022 00:02:17 +0300 Message-Id: <20220705210218.483854-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220705210218.483854-1-burzalodowa@gmail.com> References: <20220705210218.483854-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function idle_loop() is referenced only in domain.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Since idle_loop() is referenced only in inline assembly, add the 'used' attribute to suppress unused-function compiler warning. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b5..2fa67266d0 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -63,7 +63,7 @@ static void do_idle(void) rcu_idle_exit(cpu); } -void idle_loop(void) +static __used void idle_loop(void) { unsigned int cpu = smp_processor_id(); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:21:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:21:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361568.591137 (Exim 4.92) (envelope-from ) id 1o8pz5-0000CB-Kl; Tue, 05 Jul 2022 21:21:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361568.591137; Tue, 05 Jul 2022 21:21:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pz5-0000C4-HV; Tue, 05 Jul 2022 21:21:27 +0000 Received: by outflank-mailman (input) for mailman id 361568; Tue, 05 Jul 2022 21:21:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pz3-0000Bu-UF; Tue, 05 Jul 2022 21:21:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pz3-0005rc-R1; Tue, 05 Jul 2022 21:21:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8pz3-0003x5-E2; Tue, 05 Jul 2022 21:21:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8pz3-00084x-Dc; Tue, 05 Jul 2022 21:21:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gQn4vuZpDhODBIVu07I6aggOJUfKYlfBOYWON8l1Ab0=; b=KSR++mtbxi2gNWYcQhqKG5QyP1 VSeLgGNUA99UPD5xRsugqGLX9hOsN4es7Koz4ciXaHi4KMweNwPxUeFrBgkMyuQ1Y6dzugxGJnHdg 2tEtuuGu7eQAQPfhNf3ahgNkRHV4wzlfBXK4oNcWJKfqcbaeNHQ8z9D1/w8kAoETJZWY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171506: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=61ff2733221e3b5bae5f647d9a460c7a68a5ace8 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Tue, 05 Jul 2022 21:21:25 +0000 flight 171506 xen-unstable-smoke real [real] flight 171508 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171506/ http://logs.test-lab.xenproject.org/osstest/logs/171508/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 1 days Failing since 171501 2022-07-05 12:03:08 Z 0 days 2 attempts Testing same since 171506 2022-07-05 17:00:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:28:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:28:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361578.591153 (Exim 4.92) (envelope-from ) id 1o8q5x-00011f-Dq; Tue, 05 Jul 2022 21:28:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361578.591153; Tue, 05 Jul 2022 21:28:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q5x-00011Y-BA; Tue, 05 Jul 2022 21:28:33 +0000 Received: by outflank-mailman (input) for mailman id 361578; Tue, 05 Jul 2022 21:28:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q5v-00011S-OU for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:28:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q5v-0005yx-EJ; Tue, 05 Jul 2022 21:28:31 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8q5v-0006Oq-8k; Tue, 05 Jul 2022 21:28:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+pey54swyfts97Tsq2W2Uaodk0Tn7hrFwBr0VV29qPQ=; b=nQqMxo4VjuLjTzgv5mV9z3VVAc a2HvRFI1DerXHDhZ7STICADpSsq4ZFvSvCoEZKTQ9/qj/yEbxUe/tMyGK0NhHDMjAuWvLyThIx+h8 +hy1hJ9ATGYPaaFQ+5IrlFk9O4XW2Lx68ZPS0mNyiZooRzrSXc17+U9eoLhnXzpKVo8Y=; Message-ID: Date: Tue, 5 Jul 2022 22:28:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-2-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220705210218.483854-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 22:02, Xenia Ragiadakou wrote: > Add the function prototypes of the functions below in header > file so that they are visible before the function definitions in traps.c. > enter_hypervisor_from_guest_preirq() > enter_hypervisor_from_guest() > do_trap_hyp_sync() > do_trap_guest_sync() > do_trap_irq() > do_trap_fiq() > leave_hypervisor_to_guest() I have actually came across those missing prototypes in the past and I have refrained to add them because they are not meant to be called from C. While I agree this is a violation of Misra C, I am still not convinced they should be added (there is no need to verify the prototype). So IMHO, they should be marked as deviation. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:29:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361583.591164 (Exim 4.92) (envelope-from ) id 1o8q6w-0001ZU-N1; Tue, 05 Jul 2022 21:29:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361583.591164; Tue, 05 Jul 2022 21:29:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q6w-0001ZN-K9; Tue, 05 Jul 2022 21:29:34 +0000 Received: by outflank-mailman (input) for mailman id 361583; Tue, 05 Jul 2022 21:29:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q6v-0001Z9-3g for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:29:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q6u-0005zu-IB; Tue, 05 Jul 2022 21:29:32 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8q6u-0006TZ-Cl; Tue, 05 Jul 2022 21:29:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1H/miVnlQ8KT0jnMBB4CKCDvF+Fxs3OlNXv4F1pMGQQ=; b=rP5NUmWFLJ6MB7mcNV+mTPfL0X hJgi7fYrCsxyFtcjcjBybic5Sd8Vy/Hh7eQkvhhk/T+bkFPbveoHFZZf7SdZ3IQss3IW9sgmC9ZZX a84GEbudZdSYnXlvjmXRS0OqX59Oj/BOaJBawfU/Fg6z3ImqxqMivA+jZRrcld1dpkZU=; Message-ID: <32147948-ce70-1217-c899-2c60f8502f16@xen.org> Date: Tue, 5 Jul 2022 22:29:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] xen/common: time: Fix MISRA C 2012 Rule 8.7 violation To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-3-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220705210218.483854-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 22:02, Xenia Ragiadakou wrote: > The variable __mon_lengths is referenced only in time.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. > > Signed-off-by: Xenia Ragiadakou Acked-by: Julien Grall Cheers, > --- > xen/common/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/common/time.c b/xen/common/time.c > index 22379f4ae2..92f7b72464 100644 > --- a/xen/common/time.c > +++ b/xen/common/time.c > @@ -28,7 +28,7 @@ > ((year) % 4 == 0 && ((year) % 100 != 0 || (year) % 400 == 0)) > > /* How many days are in each month. */ > -const unsigned short int __mon_lengths[2][12] = { > +static const unsigned short int __mon_lengths[2][12] = { > /* Normal years. */ > {31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31}, > /* Leap years. */ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:31:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:31:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361589.591175 (Exim 4.92) (envelope-from ) id 1o8q8l-00031K-6i; Tue, 05 Jul 2022 21:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361589.591175; Tue, 05 Jul 2022 21:31:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q8l-00031D-3c; Tue, 05 Jul 2022 21:31:27 +0000 Received: by outflank-mailman (input) for mailman id 361589; Tue, 05 Jul 2022 21:31:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q8k-000317-3w for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:31:26 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8q8j-00063v-Q1; Tue, 05 Jul 2022 21:31:25 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8q8j-0006Wh-L2; Tue, 05 Jul 2022 21:31:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=kcwx3drdFvcIqoy3tO7a+MHWkz6BwSqPPHI0d1+8BOk=; b=TeDOJ6P/a4cwrfhFNtFJOv/wWz YKtetnAj2t9Fu1GunpS6wwEsqOWSCvlG1feksTj5DQtXWcKJwfUnahENpUBcpW/+Y7XpIIo3nE85w j6OteGesTz5TDXutJQga8mzobLATxfc9xtsmbVZc5tpxQQUUh4O6eDkHF6lu0jLRQMnE=; Message-ID: Date: Tue, 5 Jul 2022 22:31:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220705210218.483854-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 22:02, Xenia Ragiadakou wrote: > The function idle_loop() is referenced only in domain.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > Since idle_loop() is referenced only in inline assembly, add the 'used' > attribute to suppress unused-function compiler warning. > > Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. > > Signed-off-by: Xenia Ragiadakou Acked-by: Julien Grall Cheers, > --- > xen/arch/arm/domain.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 2f8eaab7b5..2fa67266d0 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -63,7 +63,7 @@ static void do_idle(void) > rcu_idle_exit(cpu); > } > > -void idle_loop(void) > +static __used void idle_loop(void) > { > unsigned int cpu = smp_processor_id(); > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:37:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361599.591187 (Exim 4.92) (envelope-from ) id 1o8qEU-0003gK-SW; Tue, 05 Jul 2022 21:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361599.591187; Tue, 05 Jul 2022 21:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qEU-0003gD-P8; Tue, 05 Jul 2022 21:37:22 +0000 Received: by outflank-mailman (input) for mailman id 361599; Tue, 05 Jul 2022 21:37:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qET-0003g3-R6; Tue, 05 Jul 2022 21:37:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qET-0006AF-LM; Tue, 05 Jul 2022 21:37:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qET-0004Kx-C6; Tue, 05 Jul 2022 21:37:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8qET-0000CV-Bf; Tue, 05 Jul 2022 21:37:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uiIfQI/OC3r8QBamgkeWhRQF5TiCsiydDNAMNV2qiuU=; b=5IfMSELt6V4Pznwtr0tFXJRNLE zfLslUoV6UP57pVI6PX9c2hU4Peb7SbUlm5KnbN/kFr3w7RVNbvYhCLy+r93QtFfhzygHOp+T8pfO bXHuQTtNeBOGdGC9xLVFYMYxJj1n8e7LvKG6j1dMnXRovJEVAQk6kbmBCjxE8JNS6i7Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171502: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=19361471b59441cd6f2aa22d4fbee7a6e9e76586 X-Osstest-Versions-That: qemuu=1437479e5ee1a49ccd84cad9e7b010fb2ee9d805 From: osstest service owner Date: Tue, 05 Jul 2022 21:37:21 +0000 flight 171502 qemu-mainline real [real] flight 171509 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171502/ http://logs.test-lab.xenproject.org/osstest/logs/171509/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171509-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171493 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171493 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171493 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171493 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171493 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171493 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171493 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171493 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 19361471b59441cd6f2aa22d4fbee7a6e9e76586 baseline version: qemuu 1437479e5ee1a49ccd84cad9e7b010fb2ee9d805 Last test of basis 171493 2022-07-04 18:37:25 Z 1 days Testing same since 171502 2022-07-05 13:08:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Richard Henderson Song Gao Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 1437479e5e..19361471b5 19361471b59441cd6f2aa22d4fbee7a6e9e76586 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:38:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:38:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361607.591198 (Exim 4.92) (envelope-from ) id 1o8qFu-0004OB-8R; Tue, 05 Jul 2022 21:38:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361607.591198; Tue, 05 Jul 2022 21:38:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qFu-0004O4-46; Tue, 05 Jul 2022 21:38:50 +0000 Received: by outflank-mailman (input) for mailman id 361607; Tue, 05 Jul 2022 21:38:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qFs-0004Ny-Mw for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:38:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qFs-0006BA-3l; Tue, 05 Jul 2022 21:38:48 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qFr-00072S-UC; Tue, 05 Jul 2022 21:38:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Ho4kPetw5Wo51UAeG59Zo1LSsQ2wLJNgpP0wjzFmErA=; b=xHIuiFLNIFWeUSfZUGSqN/QGsA jN5AQmjiLfI3bVxWuSXSpKfDQlP56aPkkwCpJFxMkuKxAOiq/oXoYH4nPPFOCED9GXzJ1vucGPqqG Y22aOwd1vOIVfEpVFp3HJqbfqKsVY8wfdqynUCUf2mWkdz8zidZuf+Af6YMz6FXY1L5Q=; Message-ID: <47ed7737-5422-e4be-c99d-0e448616f5b5@xen.org> Date: Tue, 5 Jul 2022 22:38:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/4] xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-5-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220705210218.483854-5-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 22:02, Xenia Ragiadakou wrote: > The function pv_console_evtchn() is defined in the header . > If the header happens to be included by multiple files, this can result in > linker errors due to multiple definitions, > So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 violation > warning by making pv_console_evtchn() inline with internal linkage. There are multiple version of pv_console_evtchn(). The version below is only used when !CONFIG_XEN_GUEST. The header is also included multiple time within Xen. So I am a bit puzzled why we haven't seen this error before. Maybe this is unused when !CONFIG_XEN_GUEST? If yes, I would remove the call. If no, then I think the commit message should be clarified. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:43:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:43:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361614.591208 (Exim 4.92) (envelope-from ) id 1o8qK6-0005oe-OL; Tue, 05 Jul 2022 21:43:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361614.591208; Tue, 05 Jul 2022 21:43:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qK6-0005oX-La; Tue, 05 Jul 2022 21:43:10 +0000 Received: by outflank-mailman (input) for mailman id 361614; Tue, 05 Jul 2022 21:43:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qK4-0005oR-V4 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:43:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qK2-0006Hy-R5; Tue, 05 Jul 2022 21:43:06 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qK2-00078s-Lt; Tue, 05 Jul 2022 21:43:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=aZY4giMveJyLBS610knTB1DXOy9A34bMaW+08wC7CdM=; b=x+5hZJhWrtVCXCxJRHj0zT/lGM Hj99KnERJgt5jRIVR+eUMtV0PZaKhsEUl8fRbiNHygZvlnMzgHdPU10VmL9cz2aiTS+WIsxO5TrDu jYkzwf5Bc9g9RVisplY1zy2m8F4xayyL2gTjinxULk5ne0aLJUYdXd+CFBOpZPywAC9M=; Message-ID: <8c175c10-acb8-1d0b-0868-ed335e1ec7ec@xen.org> Date: Tue, 5 Jul 2022 22:43:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1.1] evtchn: add early-out to evtchn_move_pirqs() To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Dario Faggioli , "xen-devel@lists.xenproject.org" References: <8bca62e3-1075-f1f7-1a92-1a4c58ba2aeb@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 05/07/2022 17:10, Jan Beulich wrote: > On 26.04.2022 12:44, Julien Grall wrote: >> On 26/04/2022 11:33, Jan Beulich wrote: >>> See the code comment. The higher the rate of vCPU-s migrating across >>> pCPU-s, the less useful this attempted optimization actually is. With >>> credit2 the migration rate looks to be unduly high even on mostly idle >>> systems, and hence on large systems lock contention here isn't very >>> difficult to observe (as was the case for a failed 4.12 osstest flight). >>> >>> Signed-off-by: Jan Beulich >>> Tested-by: Luca Fancellu >>> >>> --- a/xen/common/event_channel.c >>> +++ b/xen/common/event_channel.c >>> @@ -1559,6 +1559,16 @@ void evtchn_move_pirqs(struct vcpu *v) >>> unsigned int port; >>> struct evtchn *chn; >>> >>> + /* >>> + * The work done below is an attempt to keep pIRQ-s on the pCPU-s that the >>> + * vCPU-s they're to be delivered to run on. In order to limit lock >>> + * contention, check for an empty list prior to acquiring the lock. In the >>> + * worst case a pIRQ just bound to this vCPU will be delivered elsewhere >>> + * until the vCPU is migrated (again) to another pCPU. >>> + */ >>> + if ( !v->pirq_evtchn_head ) >>> + return; >> >> I was hoping Andrew would give some insight (hence why I haven't replied >> to your previous answer). >> >> I am still not really convinced about this optimization. Aside what I >> wrote about the IRQ raised on the "wrong" pCPU, the lock contention >> would still be present if an OS is deciding to spread the PIRQs across >> all the vCPUs. >> >> So it seems to me switching to a rwlock would help to address the >> contention on all the cases. > > But that patch of mine didn't get any ack either, and hence at some > point I've shelved it. Looking at v5, your latest answer suggested you were going to drop the patch. So I didn't bother to review/ack the latest version. Now, in the context of this discussion, I think this is better than this approach. I will review the other patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:49:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:49:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361621.591220 (Exim 4.92) (envelope-from ) id 1o8qQG-0006ff-IV; Tue, 05 Jul 2022 21:49:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361621.591220; Tue, 05 Jul 2022 21:49:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qQG-0006fY-Fe; Tue, 05 Jul 2022 21:49:32 +0000 Received: by outflank-mailman (input) for mailman id 361621; Tue, 05 Jul 2022 21:49:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qQF-0006fS-2d for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:49:31 +0000 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [2a00:1450:4864:20::329]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58fafa62-fcac-11ec-bd2d-47488cf2e6aa; Tue, 05 Jul 2022 23:49:30 +0200 (CEST) Received: by mail-wm1-x329.google.com with SMTP id r81-20020a1c4454000000b003a0297a61ddso10513439wma.2 for ; Tue, 05 Jul 2022 14:49:30 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id y5-20020a056000108500b002167efdd549sm5804766wrw.38.2022.07.05.14.49.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 14:49:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58fafa62-fcac-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IkApP0qBnWfBhxv+dsAyKahnuOswQt2rNblrcG1NROA=; b=nxetrEp0FEGIUqLOxGkqr/LOvRAfoRPP7JKL2dSQthAxJyEUtmJw9ks6g94I+XocmZ RLb50jXS/wzUE/9JNA5HIM4tVb23gSXWpLaIIBq8BuxXKLxUFaSVrkfeHSBwaRyUrOY7 /vBPb/x09b8SRrkejY1MwQYZDe3E3kmA0ntBKVv8LdZ6G1AywIXouBWUMQXnQd5vRWkI p1b5pSVDYscc+puGcfhX2qBrqTc+iMMlrVWTEV+RRzaNYFBHWWlXw17Gtq1O5GolkdkY 80DXGFYth9eW8wyUEbUn6VnHcHDcmW8oC4LQOc0th5TGRoJwOExpY7jLaIa2gINQJJlC d+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IkApP0qBnWfBhxv+dsAyKahnuOswQt2rNblrcG1NROA=; b=UsIAZF6pwsPL2XPXsF/7ONRF/aIGudr7peBQDtrwlv6gF9/9z+msEBMmYW4LRqJgOt GNAvjy2eWZnXAOcx4nrhApbFX1qrb8JffTlHihOcErreffh0Es6IYyQcKp5pP8FDmAmC kNMygP/oOpj9WaR8Jlh3iNKq7UpDTfEZA92aEiV7vihZooxPpcEXikHAfOvC28tkCVNx q2TgdP29R9Xc4bPgU8C1zDYIlBwxr9ro448Z/5YDds4gYJ1DX8fFHZjZxW1pWUFWcR1i 6uI6LMGf9QCRcXXV1zxx3Whe8p3Pnipf4UfZWj+alI0YIT6AHN8KeyzVvJJdBfecniUk tW/w== X-Gm-Message-State: AJIora+K1bywOrHAi+2jbOfMtCeM/KGqJZl0hQHzEWJ+qfK1ILMbmCwH sNhV7G9izakS1dd7PP35Lzo= X-Google-Smtp-Source: AGRyM1sUl5v6+2mZNbRHJe4Sbn+IuHfpRCeSPAHBuh0xSy2oneQ+V7UVSL3vko6/ydOn21Kj2DzQkA== X-Received: by 2002:a1c:6a0d:0:b0:3a0:4b6e:b64e with SMTP id f13-20020a1c6a0d000000b003a04b6eb64emr38988406wmc.188.1657057769642; Tue, 05 Jul 2022 14:49:29 -0700 (PDT) Message-ID: <0accbe13-2155-185f-5d77-a590e1855af3@gmail.com> Date: Wed, 6 Jul 2022 00:49:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-2-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Julien, On 7/6/22 00:28, Julien Grall wrote: > Hi Xenia, > > On 05/07/2022 22:02, Xenia Ragiadakou wrote: >> Add the function prototypes of the functions below in >> header >> file so that they are visible before the function definitions in traps.c. >> enter_hypervisor_from_guest_preirq() >> enter_hypervisor_from_guest() >> do_trap_hyp_sync() >> do_trap_guest_sync() >> do_trap_irq() >> do_trap_fiq() >> leave_hypervisor_to_guest() > > I have actually came across those missing prototypes in the past and I > have refrained to add them because they are not meant to be called from C. > > While I agree this is a violation of Misra C, I am still not convinced > they should be added (there is no need to verify the prototype). Yes, there is no need. Here, I decided to follow the example of do_trap_hyp_serror() and do_trap_guest_serror() for consistency. > > So IMHO, they should be marked as deviation. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:50:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:50:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361626.591230 (Exim 4.92) (envelope-from ) id 1o8qR4-0007xy-SS; Tue, 05 Jul 2022 21:50:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361626.591230; Tue, 05 Jul 2022 21:50:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qR4-0007xp-PZ; Tue, 05 Jul 2022 21:50:22 +0000 Received: by outflank-mailman (input) for mailman id 361626; Tue, 05 Jul 2022 21:50:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qR3-0007xh-F1 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:50:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qR2-0006Pe-Tu; Tue, 05 Jul 2022 21:50:20 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qR2-0007YC-ON; Tue, 05 Jul 2022 21:50:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=7306w47pqjFIkVP2a5AFzWOidnDcnkqSr12fl/9Lq1o=; b=Wn/WDiNH+JujKuNl0GEMamscVX B273bC9H05wsgaGkyKeeoHvYxeY2Omzbbyc0VMQjFUOeo/KWjNogveBgjEYBKxzCs1kIYvcc6N3he jp3wX5mOgoFV9zjwGoUGSLf9LI2kwwb7kQsqSAaqxLqmVSTHF23sH9pCncwwztHQUg+E=; Message-ID: Date: Tue, 5 Jul 2022 22:50:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Jan Beulich , "xen-devel@lists.xenproject.org" , Anthony PERARD Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> <9916754f-b730-6201-5225-167995f69b51@suse.com> From: Julien Grall Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition In-Reply-To: <9916754f-b730-6201-5225-167995f69b51@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 05/07/2022 17:03, Jan Beulich wrote: > On 09.06.2022 17:52, Jan Beulich wrote: >> With debug info retained, xen.efi can be quite large. Unlike for xen.gz >> there's no intermediate step (mkelf32 there) involved which would strip >> debug info kind of as a side effect. While the installing of xen.efi on >> the EFI partition is an optional step (intended to be a courtesy to the >> developer), adjust it also for the purpose of documenting what distros >> would be expected to do during boot loader configuration (which is what >> would normally put xen.efi into the EFI partition). >> >> Model the control over stripping after Linux'es module installation, >> except that the stripped executable is constructed in the build area >> instead of in the destination location. This is to conserve on space >> used there - EFI partitions tend to be only a few hundred Mb in size. >> >> Signed-off-by: Jan Beulich >> --- >> GNU strip 2.38 appears to have issues when acting on a PE binary: >> - file name symbols are also stripped; while there is a separate >> --keep-file-symbols option (which I would have thought to be on by >> default anyway), its use so far makes no difference, >> - the string table grows in size, when one would expect it to retain its >> size (or shrink), >> - linker version is changed in and timestamp zapped from the header. >> Older GNU strip (observed with 2.35.1) doesn't work at all ("Data >> Directory size (1c) exceeds space left in section (8)"). >> >> Future GNU strip is going to honor --keep-file-symbols (and will also >> have the other issues fixed). Question is whether we should use that >> option (for the symbol table as a whole to make sense), or whether >> instead we should (by default) strip the symbol table as well. > > Without any feedback / ack I guess I'll consider this of no interest > (despite having heard otherwise, triggering me to put together the > patch in the first place), and put on the pile of effectively > rejected patches. Sorry, I haven't looked at this patch because I am not very familiar with the Makefile code. Reading through the commit message, I think having this patch would be quite beneficial. Regarding the review, Anthony has been working on the build system recently. So maybe he could give a review? (I have CCed him). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 21:56:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 21:56:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361632.591242 (Exim 4.92) (envelope-from ) id 1o8qWj-0000GD-EV; Tue, 05 Jul 2022 21:56:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361632.591242; Tue, 05 Jul 2022 21:56:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qWj-0000G6-BX; Tue, 05 Jul 2022 21:56:13 +0000 Received: by outflank-mailman (input) for mailman id 361632; Tue, 05 Jul 2022 21:56:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qWi-0000FL-Ca for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 21:56:12 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qWi-0006Xj-20; Tue, 05 Jul 2022 21:56:12 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qWh-0007q8-SV; Tue, 05 Jul 2022 21:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=bRPkaQ+mAtRkk9nQRLnLvO8fxCkGJ6LNM4AGtsIxDtY=; b=oyH8DvoMu7rCBq/lf7JbjSSkm0 8nwIkOb7vcXjRmJXjzZrYIYgKZgJASGRkxikFjSumrpvld/PFa8erFlFOx8cF6lp+6OrxgrwVEXk+ YqXdGmWroXNdn/c4++NZ1aA8vVwehx1wz7u8rrtby2Ey5ELUYfOKkoZ39SOLzH68wIwM=; Message-ID: <0afd7250-b157-7fb2-1fdb-78955d2bf262@xen.org> Date: Tue, 5 Jul 2022 22:56:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-2-burzalodowa@gmail.com> <0accbe13-2155-185f-5d77-a590e1855af3@gmail.com> From: Julien Grall Subject: Re: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations In-Reply-To: <0accbe13-2155-185f-5d77-a590e1855af3@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 22:49, Xenia Ragiadakou wrote: > On 7/6/22 00:28, Julien Grall wrote: >> Hi Xenia, >> >> On 05/07/2022 22:02, Xenia Ragiadakou wrote: >>> Add the function prototypes of the functions below in >>> header >>> file so that they are visible before the function definitions in >>> traps.c. >>> enter_hypervisor_from_guest_preirq() >>> enter_hypervisor_from_guest() >>> do_trap_hyp_sync() >>> do_trap_guest_sync() >>> do_trap_irq() >>> do_trap_fiq() >>> leave_hypervisor_to_guest() >> >> I have actually came across those missing prototypes in the past and I >> have refrained to add them because they are not meant to be called >> from C. >> >> While I agree this is a violation of Misra C, I am still not convinced >> they should be added (there is no need to verify the prototype). > > Yes, there is no need. Here, I decided to follow the example of > do_trap_hyp_serror() and do_trap_guest_serror() for consistency. do_trap_guest_serror() is called from C code (see arch/arm32/traps.c). do_trap_hyp_serror() is called only from assembly. I would argue that if you want consistency, then you should drop the prototype rather than modifying 90% of the other examples. Otherwise, this is not really consistency but more a design choice (you want to be fully compliant with MISRA). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 22:01:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 22:01:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361639.591253 (Exim 4.92) (envelope-from ) id 1o8qby-0001qZ-5V; Tue, 05 Jul 2022 22:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361639.591253; Tue, 05 Jul 2022 22:01:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qby-0001qS-01; Tue, 05 Jul 2022 22:01:38 +0000 Received: by outflank-mailman (input) for mailman id 361639; Tue, 05 Jul 2022 22:01:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qbw-0001qM-M2 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 22:01:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qbw-0006fW-4G; Tue, 05 Jul 2022 22:01:36 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qbv-00088q-Ux; Tue, 05 Jul 2022 22:01:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1ZABEC9njBC5aai4/GIav7Ak4LagUmq/AVgkeQZvHKE=; b=aZ0M/ryouasMZQWW2DRnryJ5SN pK8V3Sn1QDPHJFTxw8tuipyx1BVLV/wEoJhEfNHqSPlFtk0qrXE0o3yqmhuaXkZeLWG1qF5tlpMmj eFRGgcROiqPVOodoeeT6uwpcb6djnMz76OV2xxEHLatpkj4gfXA3j+WgFFMcTJGA5epU=; Message-ID: Date: Tue, 5 Jul 2022 23:01:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705122114.419634-1-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220705122114.419634-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 05/07/2022 13:21, Xenia Ragiadakou wrote: > Add the function prototype of show_stack() in header file > so that it is visible before its definition in traps.c. > > Although show_stack() is referenced only in traps.c, it is declared with > external linkage because, during development, it is often called also by > other files for debugging purposes. Declaring it static would increase > development effort. Add appropriate comment > > Signed-off-by: Xenia Ragiadakou With one request below: Acked-by: Julien Grall > --- > xen/arch/arm/include/asm/processor.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h > index 4188ec6bfb..c021160412 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[]; > void panic_PAR(uint64_t par); > > void show_execution_state(const struct cpu_user_regs *regs); > +/* Debugging functions are declared with external linkage to aid development. */ I agree that those functions are only used for debugging today. But there are no reason they can't be used in code in the future. So I would like this comment to be dropped because it could easily become stale. If the others argue for keeping it, then I think... > void show_registers(const struct cpu_user_regs *regs); > +void show_stack(const struct cpu_user_regs *regs); ... we need a newline here so it is clearer which set of functions you are referring to (at the moment one may think that dump_execution_state()) is also included. > //#define dump_execution_state() run_in_exception_handler(show_execution_state) > #define dump_execution_state() WARN() > Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 22:02:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 22:02:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361643.591264 (Exim 4.92) (envelope-from ) id 1o8qd4-0002Od-Df; Tue, 05 Jul 2022 22:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361643.591264; Tue, 05 Jul 2022 22:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qd4-0002OW-Aa; Tue, 05 Jul 2022 22:02:46 +0000 Received: by outflank-mailman (input) for mailman id 361643; Tue, 05 Jul 2022 22:02:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qd2-0002OG-Dk for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 22:02:44 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31d3173a-fcae-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 00:02:43 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id r14so13620483wrg.1 for ; Tue, 05 Jul 2022 15:02:43 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id s14-20020a5d510e000000b0021d60994b0asm10151482wrt.100.2022.07.05.15.02.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 15:02:42 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31d3173a-fcae-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Mcg72TBG1jxYz7iVjnqxrxdaFWvNUE9pET8iQOek4xA=; b=jhxkmdkB7haX9DAJ8QwVckaFsM9+56VTqdkyHC8d0QEDvK/O5ksR9mwCaYYj+DXG/x +gHTHAXco+KNQgwpTSpP7dO3UR/psmfeGg4tPd25UzNyD0X9FTWXEf1TJSzbxZESBYgI w9ZhwDU+FlSQ9NIEAPQTinidVM6LEQHolC4NhDvwHLFg6wn4vgH/Wt4qO2IBNkfoXvVP 62IJFJCATnpkzpkDWo36YM7YM5Mqcvw7fdh3Pvk6hSkMLWsI6kPNbwnBcL0gVXkpWQ80 Gutqk5Ih1/ZpyGv5H4f5rafpPzuMI48h9zjBPR04roDWPdiHMCoKlu5HnyP6WTHBpD4n dAHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Mcg72TBG1jxYz7iVjnqxrxdaFWvNUE9pET8iQOek4xA=; b=f83NkHcOV2gwoYISUIz+gi/HwPAbxnVrLYZJ8sMdVZhmv/JngvpWg/AB20f5P1JaPY q+0jxwlyDCfA3Du/jFElOJdgnaEEec3USinRkrKWtKa2aOJ6G1I69zu5P+4WQ/NT1Han 33V6p01PQjiPx0Hco8RM64Mv/AcZ+3/aU4u1U0mGRoQpSkK365kJEuBjKEpkJ1UzGHpT fFRMvE49TGIsJ7ISuHhZ3ecpj1F1N3L6jK652ckKKAlBhRP3PkRy8iB3COTbJ0gOuPJq o8HGOXMQsmf7Q+tgff2IyvQ0GuiVfn/4o5h0vxp4GhhuL7r01vijJJuhForszt55mse0 6z1Q== X-Gm-Message-State: AJIora83xdZRWyRRivJi2PxxbQ+ang9DJT9UAyr4Uqap9h6062E/JDDI wanwS0oZ+K8pHdoqWqtRC9M= X-Google-Smtp-Source: AGRyM1tnznu0hYs4Vnv79iV0LdGWQNC52y9NyDUoLmMR+4lTxWtjMGa38EGKJ1WDzEBz6M0+1YkB2A== X-Received: by 2002:a5d:55cd:0:b0:21d:6d9d:2c4e with SMTP id i13-20020a5d55cd000000b0021d6d9d2c4emr9283156wrw.544.1657058562994; Tue, 05 Jul 2022 15:02:42 -0700 (PDT) Message-ID: Date: Wed, 6 Jul 2022 01:02:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/4] xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-5-burzalodowa@gmail.com> <47ed7737-5422-e4be-c99d-0e448616f5b5@xen.org> From: Xenia Ragiadakou In-Reply-To: <47ed7737-5422-e4be-c99d-0e448616f5b5@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Julien, On 7/6/22 00:38, Julien Grall wrote: > Hi Xenia, > > On 05/07/2022 22:02, Xenia Ragiadakou wrote: >> The function pv_console_evtchn() is defined in the header >> . >> If the header happens to be included by multiple files, this can >> result in >> linker errors due to multiple definitions, >> So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 >> violation >> warning by making pv_console_evtchn() inline with internal linkage. > > There are multiple version of pv_console_evtchn(). The version below is > only used when !CONFIG_XEN_GUEST. > > The header is also included multiple time within Xen. So I am a bit > puzzled why we haven't seen this error before. Maybe this is unused when > !CONFIG_XEN_GUEST? > > If yes, I would remove the call. If no, then I think the commit message > should be clarified. You are right. I had to clarify that this holds when !CONFIG_XEN_GUEST. So when !CONFIG_XEN_GUEST, the function pv_console_evtchn() is defined inside the header file and the header is included only by a single file. This is why the error has not been triggered. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Jul 05 22:03:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 22:03:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361646.591275 (Exim 4.92) (envelope-from ) id 1o8qdd-0002ua-MP; Tue, 05 Jul 2022 22:03:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361646.591275; Tue, 05 Jul 2022 22:03:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qdd-0002uT-JP; Tue, 05 Jul 2022 22:03:21 +0000 Received: by outflank-mailman (input) for mailman id 361646; Tue, 05 Jul 2022 22:03:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qdb-0002tB-Vc for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 22:03:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8qdb-0006kw-P0; Tue, 05 Jul 2022 22:03:19 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8qdb-0008AR-Jo; Tue, 05 Jul 2022 22:03:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=M5+FvbEjnB1nQJ63M1p3GgPFPP7HPP8FjeLNywJGX0Y=; b=jJeJ/GbKobQjWVNDJ6WlUgjcJk JTcF9h/BrssoCyi8rtL8E7/NkSLN6qoB3/kOiHw9/ZBPu7ev2HW22QmDJqjlQpcVkjps1AhZHbAjO 44g/4DUOy7ODDOzRYkNS6gXxU0ZOdYJGQhgKCjZeki+ouIRbEccD8ADwJBZlsUV9Wfbg=; Message-ID: Date: Tue, 5 Jul 2022 23:03:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch To: Jiamei Xie , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20220630015336.3040355-1-jiamei.xie@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 30/06/2022 06:20, Jiamei Xie wrote: > Hi, Hi Jiamei, >> -----Original Message----- >> From: Jiamei Xie >> Sent: 2022年6月30日 9:54 >> To: xen-devel@lists.xenproject.org >> Cc: Jiamei Xie ; Stefano Stabellini >> ; Julien Grall ; Bertrand Marquis >> ; Volodymyr Babchuk >> ; Wei Chen >> Subject: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context >> switch >> >> virt_vtimer_save is calculating the new time for the vtimer in: >> "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset >> - boot_count". >> In this formula, "cval + offset" might cause uint64_t overflow. >> Changing it to "ticks_to_ns(v->domain->arch.virt_timer_base.offset - >> boot_count) + ticks_to_ns(v->arch.virt_timer.cval)" can avoid overflow, >> and "ticks_to_ns(arch.virt_timer_base.offset - boot_count)" will be >> always the same, which has been caculated in domain_vtimer_init. >> Introduce a new field virt_timer_base.nanoseconds to store this value >> for arm in struct arch_domain, so we can use it directly. >> >> Signed-off-by: Jiamei Xie >> Change-Id: Ib80cee51eaf844661e6f92154a0339ad2a652f9b > > I am sorry I forget to remove the Change-Id. No worries. This can be dropped on commit (if no other changes are requested). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 22:29:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 22:29:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361657.591292 (Exim 4.92) (envelope-from ) id 1o8r2l-0005ti-PR; Tue, 05 Jul 2022 22:29:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361657.591292; Tue, 05 Jul 2022 22:29:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8r2l-0005tb-MZ; Tue, 05 Jul 2022 22:29:19 +0000 Received: by outflank-mailman (input) for mailman id 361657; Tue, 05 Jul 2022 22:29:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8r2k-0005tV-Iu for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 22:29:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8r2k-0007JV-5r; Tue, 05 Jul 2022 22:29:18 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8r2j-0000xo-W6; Tue, 05 Jul 2022 22:29:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=bsS/akIE1f6M9t+O6fIMH/IXWZxRgLcgoDB4hcgV57Y=; b=G/xzicCp3BueALFci2EhZP5Vw7 ENxDpz15q6g3Yr19xjkT4lvpiApTZQEf+etzZK3V/all8yXzU7BLSrv95FEWTzzvi7cqDKdX3MRPJ V/NTCGiv6aqxhW+/iXEeXqHOlSt3laajafm2DRmAAJSIqfVJXcuquCFhb3GjbjMpRVgM=; Message-ID: <0144b4d7-6caa-5e7f-b8c3-9e72e0085e1f@xen.org> Date: Tue, 5 Jul 2022 23:29:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Jiamei Xie , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20220630015336.3040355-1-jiamei.xie@arm.com> From: Julien Grall Subject: Re: [PATCH v3] xen/arm: avoid overflow when setting vtimer in context switch In-Reply-To: <20220630015336.3040355-1-jiamei.xie@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jiamei, On 30/06/2022 02:53, Jiamei Xie wrote: > virt_vtimer_save is calculating the new time for the vtimer in: > "v->arch.virt_timer.cval + v->domain->arch.virt_timer_base.offset > - boot_count". > In this formula, "cval + offset" might cause uint64_t overflow. > Changing it to "ticks_to_ns(v->domain->arch.virt_timer_base.offset - > boot_count) + ticks_to_ns(v->arch.virt_timer.cval)" can avoid overflow, From the commit message, I can't quite make the connection between "cval + offset" will overflow and "ticks_to_ns(...) + ticks_to_ns(...)" will help. So how about the following: " virt_vtimer_save() will calculate the next deadline when the vCPU is scheduled out. At the moment, Xen will use the following equation: virt_timer.cval + virt_time_base.offset - boot_count The three values are 64-bit and one (cval) is controlled by domain. In theory, it would be possible that the domain has started a long time after the system boot. So virt_time_base.offset - boot_count may be a large numbers. This means a domain may inadvertently set a cval so the result would overflow. Consequently, the deadline would be set very far in the future. This could result to loss of timer interrupts or the vCPU getting block "forever". One way to solve the problem, would be to separately 1) compute when the domain was created in ns 2) convert cval to ns 3) Add 1 and 2 together The first part of the equation never change (the value is set/known at domain creation). So take the opportunity to store it in domain structure. " The code itself looks good to me. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 05 23:09:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 23:09:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361664.591303 (Exim 4.92) (envelope-from ) id 1o8reu-0002HW-Tc; Tue, 05 Jul 2022 23:08:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361664.591303; Tue, 05 Jul 2022 23:08:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8reu-0002HP-Qq; Tue, 05 Jul 2022 23:08:44 +0000 Received: by outflank-mailman (input) for mailman id 361664; Tue, 05 Jul 2022 23:08:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ret-0002HJ-BC for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 23:08:43 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 69102048-fcb7-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 01:08:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BE659B81A49; Tue, 5 Jul 2022 23:08:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A31FEC341C7; Tue, 5 Jul 2022 23:08:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69102048-fcb7-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657062519; bh=r1VDUMkTnRYUiegjaiup8SAtXqOPuKp/Q0u2H7QOE24=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=VDoNxz47GhCu/Z6UiG/g8rtERqz9z+wehRxOUZO5GETtoGiyJWeXpBBlDtwFP8/Nh x+SbN8HqXhhobn2Q0NNIm/9vkUWMT69bl6ogDP+Sg/Y41mzLURQxv+9NYiW8PEacFx fR2Zjw0LEveCWht4ZtKzyOT9wrtFFFunKt4WAtB8jhFukTwIjR65cZdF1lmrDcJ3u2 +c02SaY1m0VPQZvS11Ciu/lHCM66SN/w9T7Ak9Ha7uG47Hz8NgbATI+fhTitsG7LPk +XhBX0K4iO+spsF1c5ObrzKBmz314+nFENFsXawQABgfYtLNHTtzUcEhlXutPrdvaI u6TqrYupQYyKg== Date: Tue, 5 Jul 2022 16:08:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Xenia Ragiadakou , xen-devel@lists.xenproject.org, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations In-Reply-To: <0afd7250-b157-7fb2-1fdb-78955d2bf262@xen.org> Message-ID: References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-2-burzalodowa@gmail.com> <0accbe13-2155-185f-5d77-a590e1855af3@gmail.com> <0afd7250-b157-7fb2-1fdb-78955d2bf262@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 5 Jul 2022, Julien Grall wrote: > Hi Xenia, > > On 05/07/2022 22:49, Xenia Ragiadakou wrote: > > On 7/6/22 00:28, Julien Grall wrote: > > > Hi Xenia, > > > > > > On 05/07/2022 22:02, Xenia Ragiadakou wrote: > > > > Add the function prototypes of the functions below in > > > > header > > > > file so that they are visible before the function definitions in > > > > traps.c. > > > > enter_hypervisor_from_guest_preirq() > > > > enter_hypervisor_from_guest() > > > > do_trap_hyp_sync() > > > > do_trap_guest_sync() > > > > do_trap_irq() > > > > do_trap_fiq() > > > > leave_hypervisor_to_guest() > > > > > > I have actually came across those missing prototypes in the past and I > > > have refrained to add them because they are not meant to be called from C. > > > > > > While I agree this is a violation of Misra C, I am still not convinced > > > they should be added (there is no need to verify the prototype). > > > > Yes, there is no need. Here, I decided to follow the example of > > do_trap_hyp_serror() and do_trap_guest_serror() for consistency. > > do_trap_guest_serror() is called from C code (see arch/arm32/traps.c). > > do_trap_hyp_serror() is called only from assembly. I would argue that if you > want consistency, then you should drop the prototype rather than modifying 90% > of the other examples. > > Otherwise, this is not really consistency but more a design choice (you want > to be fully compliant with MISRA). Actually I am not sure that MISRA requires prototypes for assembly functions only meant to be called from assembly. I think MISRA requires detailed docs for anything assembly, but I don't think it requires C prototypes for all assembly functions. So I think we could skip them for now. At some point we'll discuss what we need to do for the assembly code but we haven't tackled that yet. From xen-devel-bounces@lists.xenproject.org Tue Jul 05 23:09:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 23:09:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361669.591314 (Exim 4.92) (envelope-from ) id 1o8rfy-0002ny-7h; Tue, 05 Jul 2022 23:09:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361669.591314; Tue, 05 Jul 2022 23:09:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rfy-0002nr-4I; Tue, 05 Jul 2022 23:09:50 +0000 Received: by outflank-mailman (input) for mailman id 361669; Tue, 05 Jul 2022 23:09:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rfw-0002nf-K2 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 23:09:48 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 906172b2-fcb7-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 01:09:47 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id h14-20020a1ccc0e000000b0039eff745c53so8054643wmb.5 for ; Tue, 05 Jul 2022 16:09:47 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id a8-20020a05600c348800b00397623ff335sm25002774wmq.10.2022.07.05.16.09.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Jul 2022 16:09:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 906172b2-fcb7-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=UxRgUYtveA0g1BrCmtLoff5ZhQg/fLd1u/kCMbjIj/M=; b=pAy5R8GEp73PJsCCXRojI0wXP8wu2bWFuUU1ImpLrwP7/2vh599Z+4pWRRXXVMgaan iuhM0u0Kd8dPN3X6FwWeS3vpaZY061jg3bpFQahP9arQWcJCBOFfBIfopqQO585K0bKZ HfN/BWopCbvT84VKqq6Mekk5jEISbHZBAx7yLCEh++eW+bEvokxz3tuRHc9t7Q5iXdQx 939f0D1Zf+6C6CA7bw2PSHrMcEFXN2tMkQ+I726lVK+E2PdjZn7TX5wlOgwqcHIDkW41 /iN2wvpG5y67TYELj3FJj5zztBOS24aQVJ90KkgA97UBrtgr19dKBi26MAq8Y4sYeRWN AERg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=UxRgUYtveA0g1BrCmtLoff5ZhQg/fLd1u/kCMbjIj/M=; b=Obm/pXVYOacm6Mwbx74jKoTwQBy9mkMkeVClk2iWqh4yUb9nGA4e3ESgjyi2mhPvZ8 TRGakbN+b7tFVIdL4S0gctHccmckjV+F7RlJNZvgLXEvnmHXDcf5fI29NTymWHhWUmUQ 1p0eClsBifTTIqcI7RW5RoZnHNmQY3rtWES3TQNxUQYTeOEE8M+gLoPs8npQzai2cv5A laMZxRM3uh+yozodh2wpeLciozGyNdi/PUWe79ddxyjodsCYfmDoKFrV2WKAPkAam/BZ ii9gNrGxeeQ1uX8OzMJspLO/bGcoZJIQoN6m6gBqhY2j12G5m6Ji9lwHuNyoO1/Ga0QZ Ar9w== X-Gm-Message-State: AJIora8kvns/U+NQBlZ9BmODu9x9QnSNxhyqBFJzv3KAr03gm+jJ0BKK 3mmzlC2j1Tdoq2bsYFhvnPs9dESH/fs= X-Google-Smtp-Source: AGRyM1vDfweH3KJ1ce8tBNXCFJd2lQRRyJqFTKuB4Dg/dZK9yp1y5pweSWXiV9u6Fo2Hqn/BdyNhuQ== X-Received: by 2002:a05:600c:3b13:b0:3a1:8ad9:9d2 with SMTP id m19-20020a05600c3b1300b003a18ad909d2mr27161215wms.129.1657062586997; Tue, 05 Jul 2022 16:09:46 -0700 (PDT) Message-ID: <863ac06a-665b-fac6-9812-fbb0e558ca20@gmail.com> Date: Wed, 6 Jul 2022 02:09:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 1/4] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violations Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-2-burzalodowa@gmail.com> <0accbe13-2155-185f-5d77-a590e1855af3@gmail.com> <0afd7250-b157-7fb2-1fdb-78955d2bf262@xen.org> From: Xenia Ragiadakou In-Reply-To: <0afd7250-b157-7fb2-1fdb-78955d2bf262@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Julien, On 7/6/22 00:56, Julien Grall wrote: > On 05/07/2022 22:49, Xenia Ragiadakou wrote: >> On 7/6/22 00:28, Julien Grall wrote: >>> Hi Xenia, >>> >>> On 05/07/2022 22:02, Xenia Ragiadakou wrote: >>>> Add the function prototypes of the functions below in >>>> header >>>> file so that they are visible before the function definitions in >>>> traps.c. >>>> enter_hypervisor_from_guest_preirq() >>>> enter_hypervisor_from_guest() >>>> do_trap_hyp_sync() >>>> do_trap_guest_sync() >>>> do_trap_irq() >>>> do_trap_fiq() >>>> leave_hypervisor_to_guest() >>> >>> I have actually came across those missing prototypes in the past and >>> I have refrained to add them because they are not meant to be called >>> from C. >>> >>> While I agree this is a violation of Misra C, I am still not >>> convinced they should be added (there is no need to verify the >>> prototype). >> >> Yes, there is no need. Here, I decided to follow the example of >> do_trap_hyp_serror() and do_trap_guest_serror() for consistency. > > do_trap_guest_serror() is called from C code (see arch/arm32/traps.c). You are right, my mistake. > > do_trap_hyp_serror() is called only from assembly. I would argue that if > you want consistency, then you should drop the prototype rather than > modifying 90% of the other examples. > > Otherwise, this is not really consistency but more a design choice (you > want to be fully compliant with MISRA). I agree with you that there is no need to declare the variables and functions that are called only from assembly, prior to their definitions. So, this kind of violations could be grouped together and provide a formal deviation. This seems to me reasonable. -- Xenia From xen-devel-bounces@lists.xenproject.org Tue Jul 05 23:17:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 23:17:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361676.591325 (Exim 4.92) (envelope-from ) id 1o8rn3-0004IZ-VY; Tue, 05 Jul 2022 23:17:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361676.591325; Tue, 05 Jul 2022 23:17:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rn3-0004IS-SJ; Tue, 05 Jul 2022 23:17:09 +0000 Received: by outflank-mailman (input) for mailman id 361676; Tue, 05 Jul 2022 23:17:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rn2-0004II-Ev; Tue, 05 Jul 2022 23:17:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rn2-0008A4-BV; Tue, 05 Jul 2022 23:17:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rn1-0006kW-V4; Tue, 05 Jul 2022 23:17:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8rn1-0007zL-Ub; Tue, 05 Jul 2022 23:17:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=K1kBGg6BthpKZYUvFa/JDB0bfLDcuOW9uHRQCh5diaI=; b=gfuBfoE1iTdfsZJv2iwUPYJBFH nxgk9zd0wj1yILrJGOeZmjLN8E4DdkIeH4w7bmK9bSCpz1dF8468YoZSudVagq8zxkiA6iBM2mBCE 0nSwHbzPWAtNWuFVxpf0IZLMdxt5Q+VsoE2Th+zEDcfwc19DGxXBxChnQ7Fz7iWgvTiw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171503: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c1084b6c5620a743f86947caca66d90f24060f56 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Tue, 05 Jul 2022 23:17:07 +0000 flight 171503 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171503/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux c1084b6c5620a743f86947caca66d90f24060f56 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 16 days Failing since 171280 2022-06-19 15:12:25 Z 16 days 44 attempts Testing same since 171495 2022-07-04 21:41:37 Z 1 days 3 attempts ------------------------------------------------------------ 485 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 19517 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 05 23:21:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 23:21:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361685.591336 (Exim 4.92) (envelope-from ) id 1o8rqw-0005t3-LS; Tue, 05 Jul 2022 23:21:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361685.591336; Tue, 05 Jul 2022 23:21:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rqw-0005sw-HW; Tue, 05 Jul 2022 23:21:10 +0000 Received: by outflank-mailman (input) for mailman id 361685; Tue, 05 Jul 2022 23:21:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8rqw-0005sq-1R for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 23:21:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25ca9a02-fcb9-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 01:21:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B765561D7F; Tue, 5 Jul 2022 23:21:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BEBEC341C7; Tue, 5 Jul 2022 23:21:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25ca9a02-fcb9-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657063266; bh=ihfTApSWQHrFN+uuv6Fc17WWuJi4GyHi8okPvF2awvQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=rh8n3OiAYCZ4BP5sLuyEuzJU3bzrZ56jtQhQVNf7RTboqKZBLgcwk0BMdQy43li8+ L6Ld6OlKGaPchSOOMLQba8tSOv3UUXlAaXTy+Tsi//PAGXRfjc5l/6/8QVTU8rrjnQ tn5bv5/u8Ag+zXFK75Q6qZMR1TdvefPOUdovUz962hT6MrB0ylcPDf14tlOtgMyifk G9lylUDA8xkR87lwJXLxskebwWooeGlo6CvQL0A8p9ZuBOXnwaHUfPBZEVvy7gEFFE S54izoLknXf8tP7moiAa+AaT32Pq2iquHXdXRiq7FTtxtDficEWlt099fPeiKmqIuS kKGGWuxbmD/HQ== Date: Tue, 5 Jul 2022 16:21:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Penny Zheng , Stefano Stabellini , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree In-Reply-To: <721ef265-7b3f-80cc-3d26-bd88b9971d26@xen.org> Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> <721ef265-7b3f-80cc-3d26-bd88b9971d26@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 5 Jul 2022, Julien Grall wrote: > On 04/07/2022 08:45, Penny Zheng wrote: > > Hi Stefano and Julien > > Hi Penny, > > > > -----Original Message----- > > > From: Stefano Stabellini > > > > > + res = fdt_property_cell(fdt, "xen,id", shm_id); > > > > > > > > Looking at the Linux binding, "xen,id" is meant to be a string. But > > > > here you are writing it as an integer. > > > > > > Good catch! > > > > > > > > > > Given that the Linux binding is already merged, I think the Xen > > > > binding should be changed. > > > > > > We would be compliant with both bindings (xen and linux) just by writing > > > shm_id as string here, but if it is not too difficult we might as well > > > harmonize > > > the two bindings and also define xen,shm-id as a string. > > > > > > On the Xen side, I would suggest to put a clear size limit so that the > > > string is > > > easier to handle. > > > > I've already made the xen,shm-id parsed as a string too, seeing the below > > code: > > " > > prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); > > if ( !prop_id ) > > return -ENOENT; > > shm_id = simple_strtoul(prop_id->data, NULL, 10); > > Why do you want to convert the string to a number? > > > > if ( shm_id >= NR_MEM_BANKS ) > > IIRC, you are not using "shm_id" to index any bank. So why do you want to > check against NR_MEM_BANKS? > > > { > > printk("fdt: invalid `xen,shm-id` %lu for static shared memory > > node.\n", > > shm_id); > > return -EINVAL; > > } > > " > > The size limit is smaller than 256, just as stated in doc: > > " > > - xen,shm-id > > > > A string that represents the unique identifier of the shared memory > > region. The maximum identifier shall be "xen,shm-id = 255". > > The first sentence reads as the xen,shm-id can a free form string. But then > the second sentence suggests a number (not a string). > > In any case, it is still unclear why you want to convert the string to an ID. > From my understanding, Stefano was suggested a limit on the characters rather > than a limit on the number. Just confirming that yes, I was suggesting a strict limit on the number of characters, assuming we accept a freeform string. I think a freeform string is more convenient and flexible for the user. But it is not required: our only requirement is that the Linux device tree Xen generates has "xen,id" in the form of a string, but that could be a string representing a number, e.g. "255". > If the latter is desirable, then the documentation should be a bit clearer and > you need to validate the input provided by the user. From xen-devel-bounces@lists.xenproject.org Tue Jul 05 23:48:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 05 Jul 2022 23:48:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361727.591365 (Exim 4.92) (envelope-from ) id 1o8sHa-0001SU-AW; Tue, 05 Jul 2022 23:48:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361727.591365; Tue, 05 Jul 2022 23:48:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8sHa-0001SN-67; Tue, 05 Jul 2022 23:48:42 +0000 Received: by outflank-mailman (input) for mailman id 361727; Tue, 05 Jul 2022 23:48:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8sHY-0001SH-HF for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 23:48:40 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fe2c1dd3-fcbc-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 01:48:39 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id ay16so24266895ejb.6 for ; Tue, 05 Jul 2022 16:48:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe2c1dd3-fcbc-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=IBaieNh81j3eG/6AbXAFBlYHy2DeNc7YIGUU+pf4AOg=; b=Y2tmj+WDjW3izOHwBHZQBJe5PTj553ADBVg3UPezPTikMNuGeaQ0GApe/RUxODQIFy T0wl5Teqs6+3Gf32puXW/Ck6T78o0EWMUVY4w78TQ22gbszEwUUn42IbQW5oYX/6kSZI xJQ3suVJoyKO2uRJNO/qPNIJFkOa3Ub4Kel0H/qxBR9TO4FOBugTcnRmJqaKGunQF126 IdhnknMuM1CQeuWnWBqLMlnjJ/t0rl6v5Y9Wf2SaU6z3rMAOH6L26ODlv31d/3B1oIhm eLA5nyMn3f9xQ4feOf3ZPuUuOg6zVByJCYr4/GCnuvXsiW38kRK4RsiRczEU2zeb/uH7 DN4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=IBaieNh81j3eG/6AbXAFBlYHy2DeNc7YIGUU+pf4AOg=; b=1mtZWadIa7NkC8QUSWUjpn8Clr6mt/pXkpoOzsFE1ryTMwzPMFxBJppiGxGEhBKAb1 vMcB03n63KaR8yCCztUm2h7l+gNTotoSI8QchotirHrmDaXTK+n0+XDrqliFitDVhIrH RkE8uEl1y+KgcBFg4OYjBIw1zgWZKZk9u8+3Aeqh1wQS8mR/F61b6f0GmWCb1mD96Q42 s9ErqskTfGDOLAsGzOtZBnIypWWr7jCrNQ6JtnYk8QIrVcP2GkKZinoZiuSrd0w7vTGh f8j+rs6HwwVYUOg2Tidqa2899mCa3WKGgXjyoMi6YBb9C3eVi5V5o+Lx2RCwmIbdNmoX bdfQ== X-Gm-Message-State: AJIora9u70iHn31KqraUcQLE4AvjqaszFuxVftEup032NRwb68bygUfG G2IK+S5fl9b9jQ4RvQRw8bgI+AGNqG/xZODRn5opayMFouuJWT39 X-Google-Smtp-Source: AGRyM1sMOSNGf2NTEeH/FnFLd4T33iiFVluDkixp9qJ4D59DJFqa67eRgABlhwSFfnp4WhBPlXjxaCA5v+e1CMDHmB0= X-Received: by 2002:a17:906:6a20:b0:726:7675:e15a with SMTP id qw32-20020a1709066a2000b007267675e15amr35293872ejc.668.1657064918510; Tue, 05 Jul 2022 16:48:38 -0700 (PDT) MIME-Version: 1.0 From: A Sudheer Date: Wed, 6 Jul 2022 05:18:19 +0530 Message-ID: Subject: access uart, i2c IO devices in DomU To: xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000d671c505e3177dd4" --000000000000d671c505e3177dd4 Content-Type: text/plain; charset="UTF-8" Hi All, On Xen-4.16 with Ubuntu-22.04 Dom0 and Ubuntu-22.04 HVM DomU, i need to access IO devices like UART and I2C. I am able to access them in Dom0. Can someone let me know how to access them in DomU. What are the cfg options to be provided ? Thanks Sudheer --000000000000d671c505e3177dd4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All,=C2=A0

On Xen-4.16 with Ubuntu-2= 2.04 Dom0 and Ubuntu-22.04 HVM DomU, i need to access=C2=A0IO devices like = UART and I2C.
I am able to access them in Dom0. Can someone let me know how to acc= ess them in DomU. What are the cfg options to be provided ?

<= /div>
Thanks=C2=A0
Sudheer
<= div>
--000000000000d671c505e3177dd4-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 02:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 02:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361735.591382 (Exim 4.92) (envelope-from ) id 1o8udM-0003s6-SB; Wed, 06 Jul 2022 02:19:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361735.591382; Wed, 06 Jul 2022 02:19:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8udM-0003rz-Oh; Wed, 06 Jul 2022 02:19:20 +0000 Received: by outflank-mailman (input) for mailman id 361735; Wed, 06 Jul 2022 02:19:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8udL-0003rt-3p for Xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 02:19:19 +0000 Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 076732bd-fcd2-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 04:19:15 +0200 (CEST) Received: from localhost.localdomain (c-174-62-72-237.hsd1.ca.comcast.net [174.62.72.237]) (authenticated bits=0) by d.mail.sonic.net (8.16.1/8.16.1) with ESMTPSA id 2662IU8p027439 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 5 Jul 2022 19:19:12 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 076732bd-fcd2-11ec-924f-1f966e50362f From: Sarah Newman To: Xen-devel@lists.xenproject.org Cc: Sarah Newman Subject: [PATCH] livepatch: create-diff-object: Check that the section has a secsym Date: Tue, 5 Jul 2022 19:18:17 -0700 Message-Id: <20220706021817.20437-1-sarah.newman@computer.org> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Sonic-CAuth: UmFuZG9tSVaVEmSg1xTBtjzAVRjHxuM+LVGVNX6KaNr2i39qskd5ASwGzOwn0QhP2gNq27gGa6GJxaQ7la8IsvO+yO6d65zV X-Sonic-ID: C;HiBT7dH87BGvsLBQfcNRkQ== M;4plqBtL87BGvsLBQfcNRkQ== X-Spam-Flag: No X-Sonic-Spam-Details: -0.0/5.0 by cerberusd A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it. This is a livepatch backport of kpatch upstream commit [1]: create-diff-object: Check that the section has a secsym ba3defa Signed-off-by: Sarah Newman [1] https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612 --- create-diff-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-diff-object.c b/create-diff-object.c index a516670..780e6c8 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf) list_for_each_entry(sec, &kelf->sections, list) { if (is_debug_section(sec)) { sec->include = 1; - if (!is_rela_section(sec)) + if (!is_rela_section(sec) && sec->secsym) sec->secsym->include = 1; } } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 03:40:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 03:40:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361744.591398 (Exim 4.92) (envelope-from ) id 1o8vtE-0004Qd-OW; Wed, 06 Jul 2022 03:39:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361744.591398; Wed, 06 Jul 2022 03:39:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8vtE-0004QW-Lb; Wed, 06 Jul 2022 03:39:48 +0000 Received: by outflank-mailman (input) for mailman id 361744; Wed, 06 Jul 2022 03:39:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8vtE-0004QM-1J; Wed, 06 Jul 2022 03:39:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8vtD-0006rC-Uy; Wed, 06 Jul 2022 03:39:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8vtD-0001qt-MK; Wed, 06 Jul 2022 03:39:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8vtD-0003iF-Lu; Wed, 06 Jul 2022 03:39:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ji+uP1rzOY2LmtqlgcnhS6EhWIiKhAjDmAwSsYrfQnE=; b=sEC8/ARL3SaqYyA4XTTtFUSRL9 UeSNLUFbjVBrQ5vNH4UaBZkcv1yHTFd/60eGi+4MtYwK9lDW0uXHDQsQnTHKXsWaMyFN89YFptAz8 iIuFdvAKo5Pwt3HaEaMES7cWmRXRZuoRY36eQCHgYLiF6dRfyZwRN62jHgVTX10nlq8o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171511: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=61ff2733221e3b5bae5f647d9a460c7a68a5ace8 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Wed, 06 Jul 2022 03:39:47 +0000 flight 171511 xen-unstable-smoke real [real] flight 171517 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171511/ http://logs.test-lab.xenproject.org/osstest/logs/171517/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 1 days Failing since 171501 2022-07-05 12:03:08 Z 0 days 3 attempts Testing same since 171506 2022-07-05 17:00:29 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 04:05:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 04:05:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361692.591410 (Exim 4.92) (envelope-from ) id 1o8wII-0008AD-T0; Wed, 06 Jul 2022 04:05:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361692.591410; Wed, 06 Jul 2022 04:05:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8wII-0008A6-PJ; Wed, 06 Jul 2022 04:05:42 +0000 Received: by outflank-mailman (input) for mailman id 361692; Tue, 05 Jul 2022 23:30:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8s0O-0007UN-A7 for xen-devel@lists.xenproject.org; Tue, 05 Jul 2022 23:30:56 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 831ec046-fcba-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 01:30:54 +0200 (CEST) Received: by mail-ed1-x530.google.com with SMTP id m16so1716088edb.11; Tue, 05 Jul 2022 16:30:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 831ec046-fcba-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=GfcysKack9u98LD+9jFe9m1kkIS9l/4gskecDGT1Tyg=; b=Dn576q5muipsNwTncrgD3aK2l/p+gqcMjP56jXliVMIPAxPF90qVCOKdj410P7RdBY XwcaZRFIakc9WKHRjNWs2oYeQzMR6Xdp+lDkiKlaeLI8YNKYblxMkOUqq1VoeWAfXAlq AbNkgmuD1gnGWpsIC3NN29D+hRtU4/dgYSHFIei38jxK6xISyWdTsJ/Hqcz4mlG5szYw 6EfwJA4GQdmc6YzXbViqktUI/lGjk1QwCfWeUQ270A5uZUCajAjmDXW6dBl80wjZTeS3 YMDxQGRNeLYJq5cuu4aC9SxCQNgjCik/vX0dL/jBQxPFp8cwRjrAuadzsLvdkjqbla3L f5ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=GfcysKack9u98LD+9jFe9m1kkIS9l/4gskecDGT1Tyg=; b=1VZB0WWYzgHjP70lgHd2Zy/aG+T5W+0Z/yDJIbyi7LElmkx5DbSOrVgdtIzRtXl7Qj 23ICVGO0l5gRZacNqVVa3Qoj+7lze4CU7dBnlAWcN6FnhZukRZD0UsBk2BfhIGIL6Qsf 22PwYoPVVyN1Md70lam5quXElyVwBYA/AJujA405Vu/Md9bU5iautzm3yNKkFNEqljuu fCA2wf7awPNrGHDrI2xsWkO5Cy9iYX1vB3djTYsgmcmaaMQROO85V2OSrtrHyetnRnpG b9cXYEIYlMNUQ/7UzYj0BgmRrQzTz/3l3MctuTPLRpmAUXDwqhZpwZhI0bul/bYqNDnJ hEyg== X-Gm-Message-State: AJIora+G2p3p7NkEwOoKPlalDWoNYTdRnmzqQV7MrVSR2/N6T1Hvmi5P Jq5yRse4rwWz+cEnhYzszgBIwd2MnioOn4AEoWG0kDyzodkWUfiK X-Google-Smtp-Source: AGRyM1sdNzWgpuQxgXE+rz9MAYioTlsOYPvN6qxcNxxLvYwLWEXFz//4qhR/wy8jstEh8CJNgCZGBAS3oNYL3WbwehU= X-Received: by 2002:a05:6402:3490:b0:435:9802:96ac with SMTP id v16-20020a056402349000b00435980296acmr49691918edc.40.1657063852851; Tue, 05 Jul 2022 16:30:52 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: A Sudheer Date: Wed, 6 Jul 2022 05:00:40 +0530 Message-ID: Subject: Re: xen domU access UART I2C To: xen-users@lists.xenproject.org, xen-devel@lists.xenproject.org Content-Type: multipart/alternative; boundary="00000000000051c31905e3173e49" --00000000000051c31905e3173e49 Content-Type: text/plain; charset="UTF-8" Hi All, < Posting my query again , added a few more details > On Xen-4.16 with Ubuntu-22.04 Dom0 and Ubuntu-22.04 HVM DomU, i need to access IO devices like UART and I2C. I am able to access them in Dom0. Can someone let me know how to access them in DomU. What are the cfg options to be provided ? Thanks Sudheer On Tue, Jul 5, 2022 at 10:26 AM A Sudheer wrote: > Hi All, > > On Xen with Ubuntu Dom0 and Ubuntu HVM DomU, i need to access IO devices > like UART and I2C. > I am able to access them in Dom0. Can someone let me know how to access > them in DomU. What are the cfg options to be provided ? > > Thanks > Sudheer > --00000000000051c31905e3173e49 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi All,=C2=A0

< Posting my query aga= in ,=C2=A0added a few more details >

On Xen-4.1= 6 with Ubuntu-22.04 Dom0 and Ubuntu-22.04 HVM DomU, i need to access=C2=A0I= O devices like UART and I2C.
I am able to access them in Dom0. Ca= n someone let me know how to access them in DomU. What are the cfg options = to be provided ?

Thanks=C2=A0
Sudheer

=
On Tue, Jul 5, 2022 at 10:26 AM A Sud= heer <asr7247@gmail.com> wro= te:
Hi All,=C2=A0

On Xen with Ubuntu Dom0 and Ubuntu HV= M DomU, i need to access=C2=A0IO devices like UART and I2C.
I am = able to access them in Dom0. Can someone let me know how to access them in = DomU. What are the cfg options to be provided ?

Th= anks=C2=A0
Sudheer
--00000000000051c31905e3173e49-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 05:45:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 05:45:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361764.591426 (Exim 4.92) (envelope-from ) id 1o8xqb-0002q6-9k; Wed, 06 Jul 2022 05:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361764.591426; Wed, 06 Jul 2022 05:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8xqb-0002pz-6h; Wed, 06 Jul 2022 05:45:13 +0000 Received: by outflank-mailman (input) for mailman id 361764; Wed, 06 Jul 2022 05:45:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8xqZ-0002pt-QM for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 05:45:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca663842-fcee-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 07:45:10 +0200 (CEST) Received: from DB6PR07CA0091.eurprd07.prod.outlook.com (2603:10a6:6:2b::29) by PR3PR08MB5657.eurprd08.prod.outlook.com (2603:10a6:102:87::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 05:45:05 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2b:cafe::2b) by DB6PR07CA0091.outlook.office365.com (2603:10a6:6:2b::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 05:45:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 05:45:04 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 05:45:04 +0000 Received: from fd905ba0196d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 24450164-3A01-458A-93B2-D656F3A104D7.1; Wed, 06 Jul 2022 05:44:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd905ba0196d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 05:44:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM4PR08MB2868.eurprd08.prod.outlook.com (2603:10a6:205:e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 05:44:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 05:44:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca663842-fcee-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=G4FMcDx0rsttcafVkWKnA6gpiVCTvwDqxsO6k1ZimjPca9TuB3dn299rn45TNPs8zIYlCNPwta7lhobuVRsbjzi9zPOZSskRnrtEGefVGhqcTCK69hh5JMwHdsnx8lrm1Sv7zho8YyrIwxayuTt4j0oDpqSbFVeD15eNh7EUDBaoExPoi17JTKeJZ7mgMNRt1fG/6jAYWoZRSYcD02pP8KbFWiox4vi2uFQ3fIIgqaaMSTJs7D0b4ekas9Xx3iA7f0z/CTVkmYLwmAfaf65O7PeUqU5tOFvhK6lnTsbFIsXMhAPU1svwkb+4TIsaeR3qp2bJ4n5dEnAOQg1oVoXRbg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=erelCa8FJWqRUxVjS1kxU6Xup7w6v0j0RKHKtGeaIp6mCRGF9JAzw88/ShJYfwSJlPEeMKmZVlM8rmmjhSuSSyz6FxbuEh/FTXDAS63TEoMectMYH7C9VYsoKizZ9BsfDmuRAJtIjazxGgbV5VJFUy/cdkPdaWgAROngJxv+P/16HpnmdVdPpylHI1DZ7kWpv1iu8zllPmOELYDp+2iHq98CcDWQ74swm6HNVGnwQNLqifhGTBccEV0sdyeg0xweGabj4UbWC9MIBefRA7xnN92PEmmLi2hmp+jf5soDlbEj8Yd/n8E6iiXe5xXZf9WqeWwdXOwIpXlfA36sqBkigQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=OuuLwSEFV7bI1RGgOdvxTDhRy5lYXx+9poaO6IXyBO8IdZwWdLCOE5q+d7wMRPITKm4/+l9i/D2NHKiZffkOuzr3KppktmMfhuVlcxNtiKPT6m7QA+W+G53GozOlJ4wk+nb+hQahADryZcv1QFxoparqgfDHxHPnJWPOkF16Ons= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5lIAX006YKmjqJl4gCdh8OU/KG9jxkNsJ9NDu2Fs3dpPBXxTQzByK03NWcOG7hZGfD9TSPx6kd9TsMegYPIwCV93eH6o60kwI3YFj3UVOCn5/WlkeEqWAWKJRPScjX4x0tNWBuWxdEGBwycKoNXy5eCdrcHTGlDM1SB8Z6d0oPgkUz5TrpD7o4bwD9m4AytBudcNi94+oP0JRQwnweqr4Eln7zPtNcK0nSXSD560a7Ct4s4M9TwyAI+zsZmiAzsJCUyiB+NxigQVH1neKbSB5NFdBNdV5sWRNQHBDnIxzkr8PnTCv2ehJzO2xcNdzsfZ7RL1Cf0goPaeYEXwPmL9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=dt7pbAifdRuGWFP+mAVIU6vWsS/f4+d/7tZT3RgsbS+SMnVTXxEQH7SToGBTOO93qTFmzfj02hONlLuQ5XWOS2SFKd5oiwF8VSSALnFXG5EREBNPM45B6Ko7X0RtDtt84WX2HjO4dMZ7zMothuAeGzCO1kd87H+rToHN5Y273bSkDb29z8nHmA8m8P+GTb/n1m5kWQFWQkGvL/6W40jeE3uPy9pbMhRj2MlNx5J6i0A7owNVHLpr9oWeIAxEdIxvoD/6GknBkVup1HAy7a+Pbr59kV5JlyKMh95QhACNzNhq/vZ5s8xP0KtnG6rTQAQ12wo0P3nkLz5Jq6ybdkVVzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XhGOJ/LgDrJTJvuRxeqPLbmWqef706X4agYcZ0WeL1M=; b=OuuLwSEFV7bI1RGgOdvxTDhRy5lYXx+9poaO6IXyBO8IdZwWdLCOE5q+d7wMRPITKm4/+l9i/D2NHKiZffkOuzr3KppktmMfhuVlcxNtiKPT6m7QA+W+G53GozOlJ4wk+nb+hQahADryZcv1QFxoparqgfDHxHPnJWPOkF16Ons= From: Henry Wang To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: RE: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Thread-Topic: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Thread-Index: AQHYfBklLU4Niq38ak2Q5vLM16P6ia1wGWKAgADj0nA= Date: Wed, 6 Jul 2022 05:44:56 +0000 Message-ID: References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> <9916754f-b730-6201-5225-167995f69b51@suse.com> In-Reply-To: <9916754f-b730-6201-5225-167995f69b51@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 50DD0495D0AEA54BBFD8DFF8B2C97B84.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 116e423b-012a-47e2-8d4f-08da5f12ad39 x-ms-traffictypediagnostic: AM4PR08MB2868:EE_|DBAEUR03FT041:EE_|PR3PR08MB5657:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ufh32Gzq4mS4z6G4X1MGxN4YDR4flIg2g3s2QYLDIZZKLUMwVlFLtplM2xWYxuab0+TR2NJkypl8GqVjVVpkSjp6qZTx0jn0H31ZIUE5dGDGOyUdxbe0iCBQ5yCOHL4isRdVtmeb1RQ3SNa3SvB9a/t6LsFqfYI6cGvCAbzg2D6+wDkkZsgl76LxTFrmk7/y60XCgsdAHsH+AKQ0pjJal58Ixy6Em21+tdQqu8851ZL/fcDI9stnTnsGQU5DjfHYkL9bLyLGPE0BXVrB5WX62OiZt6OoHs7d6XzXvPFp+Hx7x1xKwykakQwRsCL6n0puq+MhhoTt1h6yxSvdhapxxc9cESVgg1xmT09XeO6Ea+KYf+hl16BmKwg7FZsk7EHlLGKtChprjuExKdqMcRNd0+XfmeDht4xipkVksTq1lhDTrSrKuR4jxadQY/Tvp/5OcIq4r2ahBjzx1ui78WQ7GXXdF6mGsKhxb8Q5XOqiqtTm0Sf7CUrmT6LRxe2ybxGnTr4kLanRuWANJXgEmbgngkTa/1AYKgu2KYB2ZR9eMePTq9N4jlBy/zPqjpckPmTOn55F9KxU6SAJumoNMHgsWHVNmdd/z1jeQ1olUmNdv+VjyJKuZ4JrKxiggYUM3kY82JdsVkbiMJMpvb72pLhSCUI752pg/3ep3yveJlJ03ABch3yYNPFFIutxQ+NtSyoYPLRrmRy9Af/kWxRA4QGhPKmn471OLeLW4bc22+CEE5p/hrGiCRVWSNnpBV/B/zEUrmwsHGoNWFlo+JTZXAltLCdcUKofkc4MAVOVMO1Htiye318irzXVfrf/eo6tQFsp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(366004)(346002)(396003)(136003)(38070700005)(186003)(122000001)(52536014)(2906002)(8936002)(55016003)(33656002)(5660300002)(316002)(66946007)(66556008)(66476007)(66446008)(54906003)(64756008)(8676002)(478600001)(4326008)(76116006)(6506007)(7696005)(53546011)(9686003)(41300700001)(26005)(38100700002)(110136005)(71200400001)(86362001)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2868 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5fa4ac86-6d42-4164-d570-08da5f12a830 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A+86eEmvDjCOYC81MvWwp/15777yGK6vc9w09FCeP5uRwKsPytlkQUjh1qXk8cCXXmp5nKbp2N2uaIDsUkYO8OQTkQHIJy/XQOdMlP/Vh/uqdfEEg303IhsvE6/r51kryElEGL3siOVzMZ9eOFjLZ5UKVsB7mP6GEZkwN8sVWA6QPHGH8/cgr9d76DP+2q6ztr3vBZHesD/OjmR4VwKTrcrZZQzP+05/wNfA96WpIJZOPfzZQF88YxFLzuILtCRxLNd778DF6FQ31OJtD5Ec1NqV2E5aJg4apSJNiEYUCS2k8gJpdY60OzU2wsragH7XWyO1zFNikf0XbzOJvt7Yix591+UXoMs6wdgn+MqsYmxJ23NCcpjkaR9pJPqEIyTA8W+Kq9uXDvTKNr0ROO3T1ydyElR5cUkUpj8tYElJjotfvUS6a2YBEQ7SymGsXCi+/OvYNh93ehZ0iEZh9AHSay1x8h7h3yZZsfbbbfrOSOnIkTOpNi6Otqo4N0A4nU5IVkXcHKJm8jF9ZmN4ehr5Ul7gHOysyqpxNfAde/2f7mbSmOUW5oyb1gSwVMmoNZkybNyG0LPLuiFw3aygUNWjSi/AYUVn8L0aoENU4Op9qWMzxURiuRON3yBm0pyGqQPf9M33kILqvyDvTsdxiM74xchX9vhFZbMpwXGZdBMcU7phKFww1Isjs9AA5rkaK5iAFM88J5k/BMn43JyrZ7HG9E1hSGgFjYzz/934Xe3M/5i3ouFcCYYmCoAKUYR45TXO7UhLgVL6jbXTki0aOxcOxWrvuKJ+Gg8KVdIJ+Y+Azpr2i3jYJnSE68Fra36eWWib X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(36840700001)(46966006)(40470700004)(83380400001)(186003)(336012)(9686003)(47076005)(33656002)(70586007)(8676002)(4326008)(70206006)(52536014)(86362001)(478600001)(40460700003)(8936002)(5660300002)(81166007)(82740400003)(26005)(356005)(82310400005)(2906002)(36860700001)(41300700001)(40480700001)(107886003)(55016003)(53546011)(7696005)(6506007)(110136005)(54906003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 05:45:04.6470 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 116e423b-012a-47e2-8d4f-08da5f12ad39 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5657 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFJlOiBb UEFUQ0hdIEVGSTogc3RyaXAgeGVuLmVmaSB3aGVuIHB1dHRpbmcgaXQgb24gdGhlIEVGSSBwYXJ0 aXRpb24NCj4gDQo+IE9uIDA5LjA2LjIwMjIgMTc6NTIsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+ IFdpdGggZGVidWcgaW5mbyByZXRhaW5lZCwgeGVuLmVmaSBjYW4gYmUgcXVpdGUgbGFyZ2UuIFVu bGlrZSBmb3IgeGVuLmd6DQo+ID4gdGhlcmUncyBubyBpbnRlcm1lZGlhdGUgc3RlcCAobWtlbGYz MiB0aGVyZSkgaW52b2x2ZWQgd2hpY2ggd291bGQgc3RyaXANCj4gPiBkZWJ1ZyBpbmZvIGtpbmQg b2YgYXMgYSBzaWRlIGVmZmVjdC4gV2hpbGUgdGhlIGluc3RhbGxpbmcgb2YgeGVuLmVmaSBvbg0K PiA+IHRoZSBFRkkgcGFydGl0aW9uIGlzIGFuIG9wdGlvbmFsIHN0ZXAgKGludGVuZGVkIHRvIGJl IGEgY291cnRlc3kgdG8gdGhlDQo+ID4gZGV2ZWxvcGVyKSwgYWRqdXN0IGl0IGFsc28gZm9yIHRo ZSBwdXJwb3NlIG9mIGRvY3VtZW50aW5nIHdoYXQgZGlzdHJvcw0KPiA+IHdvdWxkIGJlIGV4cGVj dGVkIHRvIGRvIGR1cmluZyBib290IGxvYWRlciBjb25maWd1cmF0aW9uICh3aGljaCBpcyB3aGF0 DQo+ID4gd291bGQgbm9ybWFsbHkgcHV0IHhlbi5lZmkgaW50byB0aGUgRUZJIHBhcnRpdGlvbiku DQo+ID4NCj4gPiBNb2RlbCB0aGUgY29udHJvbCBvdmVyIHN0cmlwcGluZyBhZnRlciBMaW51eCdl cyBtb2R1bGUgaW5zdGFsbGF0aW9uLA0KPiA+IGV4Y2VwdCB0aGF0IHRoZSBzdHJpcHBlZCBleGVj dXRhYmxlIGlzIGNvbnN0cnVjdGVkIGluIHRoZSBidWlsZCBhcmVhDQo+ID4gaW5zdGVhZCBvZiBp biB0aGUgZGVzdGluYXRpb24gbG9jYXRpb24uIFRoaXMgaXMgdG8gY29uc2VydmUgb24gc3BhY2UN Cj4gPiB1c2VkIHRoZXJlIC0gRUZJIHBhcnRpdGlvbnMgdGVuZCB0byBiZSBvbmx5IGEgZmV3IGh1 bmRyZWQgTWIgaW4gc2l6ZS4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxq YmV1bGljaEBzdXNlLmNvbT4NCj4gPiAtLS0NCj4gPiBHTlUgc3RyaXAgMi4zOCBhcHBlYXJzIHRv IGhhdmUgaXNzdWVzIHdoZW4gYWN0aW5nIG9uIGEgUEUgYmluYXJ5Og0KPiA+IC0gZmlsZSBuYW1l IHN5bWJvbHMgYXJlIGFsc28gc3RyaXBwZWQ7IHdoaWxlIHRoZXJlIGlzIGEgc2VwYXJhdGUNCj4g PiAgIC0ta2VlcC1maWxlLXN5bWJvbHMgb3B0aW9uICh3aGljaCBJIHdvdWxkIGhhdmUgdGhvdWdo dCB0byBiZSBvbiBieQ0KPiA+ICAgZGVmYXVsdCBhbnl3YXkpLCBpdHMgdXNlIHNvIGZhciBtYWtl cyBubyBkaWZmZXJlbmNlLA0KPiA+IC0gdGhlIHN0cmluZyB0YWJsZSBncm93cyBpbiBzaXplLCB3 aGVuIG9uZSB3b3VsZCBleHBlY3QgaXQgdG8gcmV0YWluIGl0cw0KPiA+ICAgc2l6ZSAob3Igc2hy aW5rKSwNCj4gPiAtIGxpbmtlciB2ZXJzaW9uIGlzIGNoYW5nZWQgaW4gYW5kIHRpbWVzdGFtcCB6 YXBwZWQgZnJvbSB0aGUgaGVhZGVyLg0KPiA+IE9sZGVyIEdOVSBzdHJpcCAob2JzZXJ2ZWQgd2l0 aCAyLjM1LjEpIGRvZXNuJ3Qgd29yayBhdCBhbGwgKCJEYXRhDQo+ID4gRGlyZWN0b3J5IHNpemUg KDFjKSBleGNlZWRzIHNwYWNlIGxlZnQgaW4gc2VjdGlvbiAoOCkiKS4NCj4gPg0KPiA+IEZ1dHVy ZSBHTlUgc3RyaXAgaXMgZ29pbmcgdG8gaG9ub3IgLS1rZWVwLWZpbGUtc3ltYm9scyAoYW5kIHdp bGwgYWxzbw0KPiA+IGhhdmUgdGhlIG90aGVyIGlzc3VlcyBmaXhlZCkuIFF1ZXN0aW9uIGlzIHdo ZXRoZXIgd2Ugc2hvdWxkIHVzZSB0aGF0DQo+ID4gb3B0aW9uIChmb3IgdGhlIHN5bWJvbCB0YWJs ZSBhcyBhIHdob2xlIHRvIG1ha2Ugc2Vuc2UpLCBvciB3aGV0aGVyDQo+ID4gaW5zdGVhZCB3ZSBz aG91bGQgKGJ5IGRlZmF1bHQpIHN0cmlwIHRoZSBzeW1ib2wgdGFibGUgYXMgd2VsbC4NCj4gDQo+ IFdpdGhvdXQgYW55IGZlZWRiYWNrIC8gYWNrIEkgZ3Vlc3MgSSdsbCBjb25zaWRlciB0aGlzIG9m IG5vIGludGVyZXN0DQo+IChkZXNwaXRlIGhhdmluZyBoZWFyZCBvdGhlcndpc2UsIHRyaWdnZXJp bmcgbWUgdG8gcHV0IHRvZ2V0aGVyIHRoZQ0KPiBwYXRjaCBpbiB0aGUgZmlyc3QgcGxhY2UpLCBh bmQgcHV0IG9uIHRoZSBwaWxlIG9mIGVmZmVjdGl2ZWx5DQo+IHJlamVjdGVkIHBhdGNoZXMuDQoN CkkgZGlkIGEgdGVzdCBmb3IgdGhpcyBwYXRjaCBvbiBteSB4ODYgbWFjaGluZSBhbmQgSSB0aGlu ayB0aGlzIHBhdGNoIGlzDQpkb2luZyB0aGUgY29ycmVjdCB0aGluZywgc286DQoNClRlc3RlZC1i eTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQpJIGFsc28gbm90aWNlZCB0aGF0 IEp1bGllbiBpcyBzdWdnZXN0aW5nIG1heWJlIHdlIGNhbiBoYXZlIEFudGhvbnkgYXMNCnRoZSBy ZXZpZXdlciBmb3IgdGhpcyBwYXRjaCwgc28gSSBhbHNvIGFkZCBoaW0gaW4gdGhlIENDIG9mIHRo aXMgZW1haWwuDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:17:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:17:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361772.591443 (Exim 4.92) (envelope-from ) id 1o8yM7-0006ip-Rw; Wed, 06 Jul 2022 06:17:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361772.591443; Wed, 06 Jul 2022 06:17:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yM7-0006ii-PG; Wed, 06 Jul 2022 06:17:47 +0000 Received: by outflank-mailman (input) for mailman id 361772; Wed, 06 Jul 2022 06:17:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yM6-0006ic-KP for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 06:17:46 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5964c939-fcf3-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 08:17:45 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB3PR0402MB3787.eurprd04.prod.outlook.com (2603:10a6:8:12::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 06:17:43 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 06:17:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5964c939-fcf3-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fck9NlABHzM6lT7nv/wTqRHrOmJKV1J19XQ6ugs1EEA62cf6pIt2Rxw0UkeO17IXDbLGM6grZjh9snAxoWnELxXQasLBUad2umj0JFG7EMRknz1fEyAKg+fkuL6q4qdgz8bWvvbUDeKS8uhGVAAtOjS+JzwwgTEv9uboGn1+usrMyNDMGH6HPpxURRvu+AMXM1VY4IR7xqypFl2yLl/eitdrL4w9XrSo8i5P+3q5NlsX5yqvxul39iWmsOYUpwC58NQZcDj7GL0PsF1nH6N3/sv5qKHLpqCVICpLNvb+rDNmv4u8APZNTMyq2aG0OpQIzjtnaaYnZXvEk8EuO6nI7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/FaPivtjBKo/5QIQwt/UgWd4q1clpHngbxHENytT/I=; b=nv0LtVCwTEVUg2+YlWUsKy4pC88jdBd+9LsbVe2XRF4hwJ8/3y4jqvCX3A5wyqLZvJQ1HmDY4uiAatVPwD/Hw5El/+n4g5ldvABZ2mS5OKkNSsz7wiNGNdKyDChwvZvt94prfb7ycFPKdWBEde4RU753eDDeV1L0VwzsFn6laSeB4gTLUwqx4Fy/xQeedEVPHjTVjhrOnsYR5d7UVhpSP9zh4wGX3/aRIe3mx9KC1B20+hBT0TvbtQVcDXSxGA5MqOnP/Osgrvn2lnnqfSqHwk08/K3fnZcqIQTVQg29qElJxqRJ2iLz1dJgrZTUQp3uQCshSG4J6UXmL97hjtqeig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/FaPivtjBKo/5QIQwt/UgWd4q1clpHngbxHENytT/I=; b=2U5pKMOKRNxVP5EVh0vWGjoQO81jT09OHEh9zutfn5Z1I0H0psSo8LWwSfiUhDvm5CrS1WLHY3qGwHy91REbGj2GLeEfA04QKSlGLPqq7mnEyjidXUxAcu1/1StSSwxrmMYf3kShdCa4WLqFbcKBW8aCQFHx7uBcr7mU0aEHpmhubWti6WAkXg9SfuCdPIxt+muP1hAbsHUfCIwI15iRQXfvrzgMJAkw2c7Jf7MlFWaPx76ngdVk48nc7HMQJ+YcwuWVXzlX0UWcAjQGTkVwEh7rD5XZRFPce6xa+L9YIdtrbFG8YZaHWHuR42mAuM9hZxta2aPuktB8Ygzs3ppbjw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 08:17:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::19) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1a15c52d-1ced-4263-0bc7-08da5f173c96 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3787:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +dki65Glg8n1gvzCGzEehTgm4YIyP8Noz4wPdpGwPtOXtkk1rKEJ22b9EdPr7bKv/QZQ4K2E0aO5hk+FP84Exnpt1QNjpGsPZ5WxxNb9yLSZgo0wlnvgHdBZiARdlQgTS320oYndJfCwRuby2Z7ZwuMvsxIxOXBQy4ZtwrLdnrYwWxvYZLDZb96ST6yOrlczGWhCtx/lppU6jnCfR7JZQLShKkr/tOJvY7k8ZeKIsHkFtGSdpKNn346wqc16ZIUGV5aN7eaE4ACvxRqpJ1GjRBDnraASQsBx0Tvt7yvGyuENmNcNyVJhXNmDbnEPrxZRlhVFqaBOlLp1EHvqtvo/94cVzDs8aFteELbCp6FUxfc3cyUzopEpnMqCXVMLatRRQzqCT7msrcSl1LXOMWyqZi8UDRXG9e4wCnqXkciO1LP3jRwz7IV+kEee7zaxfXNsThDzv7q9dLpyeOLCxSpEI/V1i3fNKnB+cUK+ltuZIrtYVaAY/m0elV393/K5HaXJ+ZYaW2uC2gKgQE9WdOPFVffzphhpXXPtBSas0YDaw3ganD3SMlBmSOhG5Rlp7Hu33hywxyi76NKbb5wgylQXUPrbdJp9/VWlQPOqjqSkLZ3wAlCb7hJ+1Pn7d8DOE0V8xhRPo84POo0gwe4KmwpG6s1NiG8/axbMGkLjXon9mpNSV7xLFIkH7jStKCM9HGBeB08hgnYycgFu1DFZezg/9z5sXeTHGCgeuxSuudfWrlDZhd3kjQW0GrlPMoglr8w+Rrg99QdaXTgJ6R+18L1pvIVC96u+dX65arzs2lIDYB39mcjsIFb8NP6+80UhLe2YrT9Qi9ao1MFVM/o5gKl9SfXaTxLYsXQCQyoTCi8koF0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(366004)(396003)(376002)(136003)(6512007)(54906003)(6506007)(5660300002)(26005)(53546011)(6486002)(8936002)(66556008)(86362001)(66476007)(4326008)(66946007)(8676002)(6916009)(316002)(478600001)(41300700001)(186003)(31696002)(31686004)(36756003)(2906002)(2616005)(38100700002)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UHFrVkVkUkd0SFZJR3AvMHZyb0t4NU5pQ2EwQ0hoU28vckIwakpvNVpXMzBj?= =?utf-8?B?Q0J5cVZLTWZWelhXS25XZnBEZ1JWZTk4Z2VOR0RwdmVNSzNITGdUS0xLQW9q?= =?utf-8?B?eForSTdic0xpbi93TGdVTG1rWDhpWkJ1TncvY0dsRDhHbVo3VHlQaXN2dG5k?= =?utf-8?B?MWtVeG1VcFhwanFJaDE4aGE3TlpKUlJrcUprRCsrR1IxbEQ2cDVGQVZ6c3dv?= =?utf-8?B?TWtFb2R3aVArQ2k0MnF1MCtUc1NXOUZKekc3WWNJQXplcGtjMEZieTBlQ0FU?= =?utf-8?B?QVdzY0REUlBkMFhkL1I1eXFZemg0bzlOSlFXZFMrVzY3NVdubzUvNmk4VlJ1?= =?utf-8?B?TTVRM05qT1IzUGNYRkE3ZlZwWm55MXoxTTJaR3VWL0hZVzdtVDdZaThrMllz?= =?utf-8?B?Vmk3cjFyRlhUeXkwd1M4TVBCR3JVNSsrUHZRY1RwOVhqTUxYM0hkcHdDZGJp?= =?utf-8?B?UHZxYzV1aXAyZTdzVkNIdjVnSHE3MFJ6blQwYXhTRkxYZENaWEt0d3RvSXYx?= =?utf-8?B?Nk9vU0NaTzJnVkpkcjdQdnVuL2dCdmNVL2t4M0VjR3pNR2lGRXo2S3ZGVThP?= =?utf-8?B?OWMyNVpEK05xUUZTWktTUWd5WDdxUm94TXljYmlsR1hxUG9vVXM1SDRlVHJz?= =?utf-8?B?Witqbi9aanUrM3Q1aU5QMWQ4cXlnTHFxM2NOSmFNSm5WNG56aEpuN2hjMWFH?= =?utf-8?B?RjljU2ZuQlZQTWFIOGtJbnJ2UkhpOHlZVVlCMStZUWlFOXFCR2tqNGgvOTcr?= =?utf-8?B?ZXdGMFZDRXBxWHVjaXpkcENXeHl5ZU9KcSt5WU10RElNZ25ZOTBraU9KaHcw?= =?utf-8?B?ekR3SWhZekJMUkt2Um5JSFV3UStVdkgvdmttOE5hMTF3aXR4aWE3clZGTlBo?= =?utf-8?B?d3pCS092M2IxQUtmS243QzJSeHE5NTNkTFd3Zm9EUTdkaXlCRnpHUFFKbDV2?= =?utf-8?B?bVpmQ2w0Zzcza1JTNUplcUFVVlZ3dXUrMmg4dkhPRVJud2VydmFGT0xNZnJq?= =?utf-8?B?NDlueldmSmFkSTBVazJ2RjZVRlVKTVFPMGJjek5XM1crcWJMZDdOS0hnVUNQ?= =?utf-8?B?OVlpa2ltV1lZbjR0WUE3NGtJd1ZENWJqWWcrOVhnSGl5YldiYWFwVzNNSDE1?= =?utf-8?B?SmhXS1ZTTXdmclFrcFFJd1dDVWo0V0MzK29vSnZaaVBEWmFnVjFJcXlMeEFB?= =?utf-8?B?T21hbHFNQjhiRHdJWjJHSjhhajBXb1A3UUh0NFBVRU1iUmlFR1hkZGtoSjJs?= =?utf-8?B?NGtmSlFiRW84cnVyWnA0a0FWQUQzRVgreU5pNndDeXlRcEtFME55eXErVnVH?= =?utf-8?B?Q0toV01QWDJJNE5OMVJHcG4zR1JQRzBtL1k1SDlTL3JXc1ZmUHFmcVZPU01w?= =?utf-8?B?cU8yalBRYldERm5kTkx6bTAvMmRoVnFVSW91Y1dNWVpqR1BFSzJsUDdJc0pG?= =?utf-8?B?TnA0b1BaN0JGSjVQZUhQWXBrYWFIdjgzeTlNbXpPOHNJTTd0eGpTMUhsUGZY?= =?utf-8?B?QkEwekZCMWR1SkF0SmIyc3k2ZGd3a0pubmMwSFZsNnpIZFE3RWdUL1lUUllu?= =?utf-8?B?Ulg0ZE9UeHIxQURDTXU5a0dzYU45akRtOFNFUnFRdnhOYVFZRWJYYjZ4ZEdw?= =?utf-8?B?RjRpTFMwNXcyMDVxcXhoaS9MSWx3UmFqWDBoempzbForRk9hSnNMcUEzdlJz?= =?utf-8?B?eG56cFFRaGxYTVRJQlJSWFd5RDFLSnVvd3habzcwR29IcHVCcnVNS0dlQXcv?= =?utf-8?B?Lyt2SXl1cmtXdWVtWHl1U2hCVE9nTXBmcFNNQWdLTXBHR0Y5czF4UCt1TWlX?= =?utf-8?B?R0UyMEJOc2xzVVdLYkFjbFJ6eDByaUxsV1d3NUtzT2s3N0Yrbk9MRUdhcXRU?= =?utf-8?B?QXYra2NGeGRPM1RQbEJUNU9valV4Mm95VVhhcTBxS1A4UGdNV3MvU1N6RFJY?= =?utf-8?B?RDJ3SlVnZHlFdUJvRUc4eVFIZGcyL2tmQVJ1QS9jV2VWWkljVk1JUkVkbjhZ?= =?utf-8?B?VGpjS05ONmJKQ214ejdFbWFDM21MM0NRMnByM21XYXpGTVBzSVM1czNIQVdM?= =?utf-8?B?RjVXY29BOTJScGZqazN5S2RCNFFEWDFOcU8vRSs1OWFGZEZ1UE5xY2FHNm9m?= =?utf-8?Q?lmrr6Xqsc9douVJkvE4aMfkfB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1a15c52d-1ced-4263-0bc7-08da5f173c96 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 06:17:43.3105 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I0afLh/yH6v1DmY6Z8RlKepQkH80TrWasyUwR57tFxxhD+TyRk9ChdNnnWC9ZI12bWbgJ1TRMhFwfDpWo96nKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3787 On 05.07.2022 18:14, Borislav Petkov wrote: > On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: >> Re-using pat_disabled like you do in your suggestion below won't >> work, because mtrr_bp_init() calls pat_disable() when MTRRs >> appear to be disabled (from the kernel's view). The goal is to >> honor "nopat" without honoring any other calls to pat_disable(). > > Actually, the current goal is to adjust Xen dom0 because: > > 1. it uses the PAT code > > 2. but then it does something special and hides the MTRRs > > which is not something real hardware does. > > So this one-off thing should be prominent, visible and not get in the > way. > > As to mtrr_bp_init(), can you use X86_FEATURE_XENPV there to detect this > special case when the kernel is running as dom0 and set stuff there > accordingly so that it doesn't disable PAT? Sure, but that alone won't help. There's a beneficial side effect of running through pat_disable(): That way pat_init() will bail right away. Without that I'd need to further special case things there (as under Xen/PV PAT must not be written, only read) and I'd also need to set pat_bp_enabled and pat_bp_initialized somewhere. I could of course check X86_FEATURE_XENPV in all the necessary places, but I was quite certain _that_ wouldn't be liked (nor would I be convinced this is the right thing to do - see bottom). > Then you don't have to touch pat_disabled() either but intergrate the > Xen variant properly... > >> I can probably fiddle with pat_enabled() instead of with >> init_cache_modes(), but when making the change I had the feeling >> this might be less liked (as looking more hacky, at least to me). > > Why would that be more hacky? My view on it, as said. I did actually make several attempts, until reaching what I then submitted. All earlier ones were quite a bit more intrusive (see above for an outline). > I'd much rather check upfront what the kernel is running on and act > accordingly instead of hooking into random functions and then years > later wonder why was it done in the first place. Thank you for putting it that kindly. It was a pretty conscious decision where to make the changes, after - as said - quite a bit of trying other variants. History with Xen-specific changes has taught me to try to keep them as uninvasive and generic as possible. The more things smelled like Xen-only, the less they were liked. >> But besides the "where" the other question is: Do you really want >> me to limit this to Xen/PV, rather than - as I have it now - >> extending it to any hypervisor, which may behave in similar ways? > > Well, do you know of some other HV which hides MTRRs from the guest? > > I haven't heard of any... Any decent hypervisor will allow overriding CPUID, so in principle I'd expect any to permit disabling MTRR to leave a guest to use the (more modern and less cumbersome) PAT alone. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:26:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:26:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361778.591454 (Exim 4.92) (envelope-from ) id 1o8yU4-0008JN-Lw; Wed, 06 Jul 2022 06:26:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361778.591454; Wed, 06 Jul 2022 06:26:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yU4-0008JG-J9; Wed, 06 Jul 2022 06:26:00 +0000 Received: by outflank-mailman (input) for mailman id 361778; Wed, 06 Jul 2022 06:25:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yU3-0008JA-MX for xen-devel@lists.xen.org; Wed, 06 Jul 2022 06:25:59 +0000 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f74a1a2-fcf4-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 08:25:58 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id o25so25308560ejm.3 for ; Tue, 05 Jul 2022 23:25:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f74a1a2-fcf4-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ApREgiVEE79ZDkwD87JBYKvEQ4vbDLIk4pwSxFtkSrI=; b=sukODfX1QQ3Qk2FkDWFF+tjIYw0g84YC5BON9Ha1aryEnnU4XDGJcMm/E8M52gFaJp 5cqziA1ksHFZoOIfS7zaPuBv3/WMODfGiblYxFE/EdnklpnlSkUqgf2jtI3U0VtzO2/P uEixRw0cAEN7ffkIeUv5p3AIkAa6RjeNSYG5RokI0ULG+XC4INRX2yIG6F7pfCiI05qH xA7qfIren4QbnTp6HKIQ0dPdCxTfi8Xmh9t0JnRcx32sUxGgHl82xg8r8Dr15MRvo1BZ yHK0CgfBVthx1Vn8B9B92qFT01Asf84iwlQ1DAOx8oBdiDfpSkf1Wa9YTaNlOgfHj1PM uvDA== X-Gm-Message-State: AJIora/hpScCoJGR4v07YBFwmrTB5MlCLn5drwKGX7Zx3DgkuH8seShQ dIEYJtqgf3YwyJB9vC8R3zUAFoyEk0GnT0YOZNU= X-Google-Smtp-Source: AGRyM1t6nRCorcUOSkvT29hZ+U1BVBFFK6mxCF6hkHDrgCcKl/DdUxNGQ02Up5NJYS87lKKxyobM5XgaOFyE+leu+cE= X-Received: by 2002:a17:907:7f8b:b0:721:9c02:37f1 with SMTP id qk11-20020a1709077f8b00b007219c0237f1mr37109927ejc.211.1657088757869; Tue, 05 Jul 2022 23:25:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Wed, 6 Jul 2022 14:25:45 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: multipart/mixed; boundary="000000000000c6489d05e31d0a37" --000000000000c6489d05e31d0a37 Content-Type: text/plain; charset="UTF-8" On Tue, Jul 5, 2022 at 7:59 PM Jan Beulich wrote: > Nothing useful in there. Yet independent of that I guess we need to > separate the issues you're seeing. Otherwise it'll be impossible to > know what piece of data belongs where. Yep, I think I'm seeing several different issues here: 1. The FLR related DPC / AER message seen on the 1st attempt only when pciback tries to seize and release the SN570 - Later-on pciback operations appear just fine. 2. MSI-X preparation failure message that shows up each time the SN570 is seized by pciback or when it's passed to domU. 3. XEN tries to map BAR from two devices to the same page 4. The "write-back to unknown field" message in QEMU log that goes away with permissive=1 passthrough config. 5. The "irq 16: nobody cared" message shows up *sometimes* in a pattern that I haven't figured out (See attached) 6. The FreeBSD domU sees the device but fails to use it because low level commands sent to it are aborted. 7. The device does not return to the pci-assignable-list when the domU it was assigned shuts-down. (See attached) #3 appears to be a known issue that could be worked around with patches from the list. I suspect #1 may have something to do with the device itself. It's still not clear if it's deadly or just annoying. I was able to update the firmware to the latest version and confirmed that the new firmware didn't make any noticeable difference. I suspect issue #2, #4, #5, #6, #7 may be related, and the pass-through was not completely successful... Should I expect a debug build of XEN hypervisor to give better diagnose messages, without the debug patch that Roger mentioned? Thanks, Rui --000000000000c6489d05e31d0a37 Content-Type: text/x-log; charset="US-ASCII"; name="dom0_dmsg_for_domu_shutdown.log" Content-Disposition: attachment; filename="dom0_dmsg_for_domu_shutdown.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l597jxz00 WzU5MjEzLjMxMjg0OV0geGVuYnIwOiBwb3J0IDModmlmMy4wKSBlbnRlcmVkIGRpc2FibGVkIHN0 YXRlICAvL2RvbVUgc2h1dGRvd24gc2VxdWVuY2Ugc3RhcnQgZnJvbSBoZXJlCls1OTIxNS4yNDcz OTNdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcmVtb3ZpbmcKWzU5MjE1LjI0 NzM5NV0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBmb3VuZCBkZXZpY2UgdG8g cmVtb3ZlCls1OTIxNS4yNDczOTZdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazog cGNpc3R1Yl9kZXZpY2VfcmVsZWFzZQpbNTkyMTUuMzUyODkzXSBwY2liYWNrIDAwMDA6MDU6MDAu MDogeGVuX3BjaWJhY2s6IE1TSS1YIHJlbGVhc2UgZmFpbGVkICgtMTYpCls1OTIxNS4zNTMxOTld IHhlbl9wY2liYWNrOiByZW1vdmVkIDAwMDA6MDU6MDAuMCBmcm9tIHNlaXplIGxpc3QKWzU5MjE2 LjQ3NDEzOV0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBwcm9iaW5nLi4uCls1 OTcyOC4xNTAwNTNdIHhlbl9wY2liYWNrOiB3YW50cyB0byBzZWl6ZSAwMDAwOjA1OjAwLjAgICAg ICAvL21hbnVhbCB4bCBwY2ktYXNzaWduYWJsZS1hZGQgMDU6MDAuMApbNTk3MjguMTUwMDc0XSBw Y2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHByb2JpbmcuLi4KWzU5NzI4LjE1MDA3 NV0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBzZWl6aW5nIGRldmljZQpbNTk3 MjguMTUwMDc2XSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IHBjaXN0dWJfZGV2 aWNlX2FsbG9jCls1OTcyOC4xNTAwNzZdIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFj azogaW5pdGlhbGl6aW5nLi4uCls1OTcyOC4xNTAwNzddIHBjaWJhY2sgMDAwMDowNTowMC4wOiB4 ZW5fcGNpYmFjazogaW5pdGlhbGl6aW5nIGNvbmZpZwpbNTk3MjguMTUwMTY1XSBwY2liYWNrIDAw MDA6MDU6MDAuMDogeGVuX3BjaWJhY2s6IGVuYWJsaW5nIGRldmljZQpbNTk3MjguMTUwMjQ3XSB4 ZW46IHJlZ2lzdGVyaW5nIGdzaSAxNiB0cmlnZ2VyaW5nIDAgcG9sYXJpdHkgMQpbNTk3MjguMTUw MjUwXSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE2Cls1OTcyOC4xNTAyOTNdIHBjaWJhY2sgMDAw MDowNTowMC4wOiB4ZW5fcGNpYmFjazogTVNJLVggcHJlcGFyYXRpb24gZmFpbGVkICgtNikKWzU5 NzI4LjE1MDU4Ml0gcGNpYmFjayAwMDAwOjA1OjAwLjA6IHhlbl9wY2liYWNrOiBzYXZlIHN0YXRl IG9mIGRldmljZQpbNTk3MjguMTUwNzMxXSBwY2liYWNrIDAwMDA6MDU6MDAuMDogeGVuX3BjaWJh Y2s6IHJlc2V0dGluZyAoRkxSLCBEMywgZXRjKSB0aGUgZGV2aWNlCls1OTcyOC4yNTc1NThdIHBj aWJhY2sgMDAwMDowNTowMC4wOiB4ZW5fcGNpYmFjazogcmVzZXQgZGV2aWNlCg== --000000000000c6489d05e31d0a37 Content-Type: text/x-log; charset="US-ASCII"; name="bad_irq.log" Content-Disposition: attachment; filename="bad_irq.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l597jxzm1 WyAzNzQyLjQ0MDQ4N10gaXJxIDE2OiBub2JvZHkgY2FyZWQgKHRyeSBib290aW5nIHdpdGggdGhl ICJpcnFwb2xsIiBvcHRpb24pClsgMzc0Mi40NDA1MTZdIENQVTogMCBQSUQ6IDAgQ29tbTogc3dh cHBlci8wIE5vdCB0YWludGVkIDUuMTAuMTIwLmdhaWEuNzgueGVucGNpYmFja2RiZyAjNApbIDM3 NDIuNDQwNTE2XSBIYXJkd2FyZSBuYW1lOiBHaWdhYnl0ZSBUZWNobm9sb2d5IENvLiwgTHRkLiBD MjQ2Ti1XVTIvQzI0Nk4tV1UyLUNGLCBCSU9TIEYxIDEwLzAyLzIwMTkKWyAzNzQyLjQ0MDUxN10g Q2FsbCBUcmFjZToKWyAzNzQyLjQ0MDUxOF0gIDxJUlE+ClsgMzc0Mi40NDA1MjJdICBkdW1wX3N0 YWNrKzB4NmIvMHg4MwpbIDM3NDIuNDQwNTI0XSAgX19yZXBvcnRfYmFkX2lycSsweDMwLzB4YTIK WyAzNzQyLjQ0MDUyNV0gIG5vdGVfaW50ZXJydXB0LmNvbGQrMHhiLzB4NjEKWyAzNzQyLjQ0MDUy N10gIGhhbmRsZV9pcnFfZXZlbnQrMHg5Zi8weGIwClsgMzc0Mi40NDA1MjhdICBoYW5kbGVfZmFz dGVvaV9pcnErMHg3My8weDFjMApbIDM3NDIuNDQwNTI5XSAgZ2VuZXJpY19oYW5kbGVfaXJxKzB4 NDIvMHg1MApbIDM3NDIuNDQwNTMxXSAgX19ldnRjaG5fZmlmb19oYW5kbGVfZXZlbnRzKzB4MTU1 LzB4MTcwClsgMzc0Mi40NDA1MzNdICBfX3hlbl9ldnRjaG5fZG9fdXBjYWxsKzB4NjEvMHhhMApb IDM3NDIuNDQwNTM1XSAgX194ZW5fcHZfZXZ0Y2huX2RvX3VwY2FsbCsweDExLzB4MjAKWyAzNzQy LjQ0MDUzNl0gIGFzbV9jYWxsX2lycV9vbl9zdGFjaysweDEyLzB4MjAKWyAzNzQyLjQ0MDUzN10g IDwvSVJRPgpbIDM3NDIuNDQwNTM4XSAgeGVuX3B2X2V2dGNobl9kb191cGNhbGwrMHhhMi8weGMw ClsgMzc0Mi40NDA1MzldICBleGNfeGVuX2h5cGVydmlzb3JfY2FsbGJhY2srMHg4LzB4MTAKWyAz NzQyLjQ0MDU0MF0gUklQOiBlMDMwOnhlbl9oeXBlcmNhbGxfc2NoZWRfb3ArMHhhLzB4MjAKWyAz NzQyLjQ0MDU0Ml0gQ29kZTogNTEgNDEgNTMgYjggMWMgMDAgMDAgMDAgMGYgMDUgNDEgNWIgNTkg YzMgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2MgY2Mg NTEgNDEgNTMgYjggMWQgMDAgMDAgMDAgMGYgMDUgPDQxPiA1YiA1OSBjMyBjYyBjYyBjYyBjYyBj YyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYyBjYwpbIDM3NDIuNDQwNTQyXSBS U1A6IGUwMmI6ZmZmZmZmZmY4MjQwM2RlMCBFRkxBR1M6IDAwMDAwMjQ2ClsgMzc0Mi40NDA1NDNd IFJBWDogMDAwMDAwMDAwMDAwMDAwMCBSQlg6IDAwMDAwMDAwMDAwMDAwMDAgUkNYOiBmZmZmZmZm ZjgxMDAyM2FhClsgMzc0Mi40NDA1NDRdIFJEWDogMDAwMDAwMDAwMmQxYTMxYSBSU0k6IDAwMDAw MDAwMDAwMDAwMDAgUkRJOiAwMDAwMDAwMDAwMDAwMDAxClsgMzc0Mi40NDA1NDRdIFJCUDogZmZm ZmZmZmY4MjQxNTk0MCBSMDg6IDAwMDAwMDY2YTE3M2I1ZmMgUjA5OiAwMDAwMDM2NzZlYmY4NDJm ClsgMzc0Mi40NDA1NDVdIFIxMDogMDAwMDAwMDAwMDAzNDBlZSBSMTE6IDAwMDAwMDAwMDAwMDAy NDYgUjEyOiAwMDAwMDAwMDAwMDAwMDAwClsgMzc0Mi40NDA1NDVdIFIxMzogMDAwMDAwMDAwMDAw MDAwMCBSMTQ6IDAwMDAwMDAwMDAwMDAwMDAgUjE1OiAwMDAwMDAwMDAwMDAwMDAwClsgMzc0Mi40 NDA1NDZdICA/IHhlbl9oeXBlcmNhbGxfc2NoZWRfb3ArMHhhLzB4MjAKWyAzNzQyLjQ0MDU0OF0g ID8geGVuX3NhZmVfaGFsdCsweGMvMHgyMApbIDM3NDIuNDQwNTQ5XSAgPyBkZWZhdWx0X2lkbGUr MHg1LzB4MTAKWyAzNzQyLjQ0MDU1MF0gID8gZGVmYXVsdF9pZGxlX2NhbGwrMHgzMy8weGMwClsg Mzc0Mi40NDA1NTFdICA/IGRvX2lkbGUrMHgxZTkvMHgyNjAKWyAzNzQyLjQ0MDU1M10gID8gY3B1 X3N0YXJ0dXBfZW50cnkrMHgxNC8weDIwClsgMzc0Mi40NDA1NTVdICA/IHN0YXJ0X2tlcm5lbCsw eDUwMy8weDUyNgpbIDM3NDIuNDQwNTU2XSAgPyB4ZW5fc3RhcnRfa2VybmVsKzB4NjBmLzB4NjFi ClsgMzc0Mi40NDA1NTZdICA/IHN0YXJ0dXBfeGVuKzB4M2UvMHgzZQpbIDM3NDIuNDQwNTU3XSBo YW5kbGVyczoKWyAzNzQyLjQ0MDU3MF0gWzwwMDAwMDAwMDhlMjA5MDhlPl0gaTgwMV9pc3IgW2ky Y19pODAxXQpbIDM3NDIuNDQwNTg1XSBEaXNhYmxpbmcgSVJRICMxNgoK --000000000000c6489d05e31d0a37-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:33:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361786.591466 (Exim 4.92) (envelope-from ) id 1o8ybb-0001Yy-Kx; Wed, 06 Jul 2022 06:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361786.591466; Wed, 06 Jul 2022 06:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ybb-0001Yr-Gc; Wed, 06 Jul 2022 06:33:47 +0000 Received: by outflank-mailman (input) for mailman id 361786; Wed, 06 Jul 2022 06:33:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yba-0001Yi-A3 for xen-devel@lists.xen.org; Wed, 06 Jul 2022 06:33:46 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 958490ab-fcf5-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 08:33:45 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU2PR04MB8647.eurprd04.prod.outlook.com (2603:10a6:10:2de::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 06:33:42 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 06:33:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 958490ab-fcf5-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YTOc4cD0eI9s5FUrabso8vUMpNAMVNE0owpULnCoaZB/jwq07+7Rw6gvq6VOEV7YxwB1Ybbb8IR+b6XVRSPTUwSV5ONjSWh8sRtyVfirmOGh2OL6yKtyAckVQwFXAlBgdnT6ejsDCU+bLZUv/Qg6tpBZMS/kUiIs8uBt5QllP/+dM5xZYaiO0HIJjq4k/MS07n89QFFdf5QMzA2EhRuWb1ZozXL6W64gfef+Y6JcrbjxOiCVTrcqGYSnvvjn3IHJYcIUQY+Fh+ovAuN/sWJ4ThCs04f1Ii0icpCkpZYG0foCFDgV4iSTqrPN8MPN3bEfEvwCjsMY/GTvGMX9MT2psQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=INVfxvlkXcwzrlGO3ailGoI45hIptv/7gcrFGKyVzOM=; b=LYgRf8mMQFd7AaovfmdjwdKhzXY3wAnb+HPVckv9D3YDyZmar9amnC50Wih///99+zSFjqpTGUM9BxcmFWqVUvzxoNmPYZcB6YWfWTsvxOv1mMlxKW+9JTH/zE4qAIP9rriNqOl3WdFN6Kf23XKmGOhM3FzcMQ7ANRnNkngoPUVxWkzr2mm1J+QNsGHglTitGcScc1X6K5PThn1mW/FUptqu+xsiipRH2FWZaJmUEpXmGbAhiVTW8hkSOMkpo2qA7aagxXB6gc8m7zrY6J106zEg8bb/kVGEU25UVuBD8wNy4WebH0zNdUD5NXrMjpPnuCtitrLbzwzxaRaC18lTow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=INVfxvlkXcwzrlGO3ailGoI45hIptv/7gcrFGKyVzOM=; b=Jbm1lAjHTakUaVeBUQKL3PrJU/LRj+8QDUeg7l45MLXwF2eAEIpwxvXeYzSZk0IO0JEz/81gNavz9jUfCD2HTDEuDxhWzNIxOydm0565/2AZHKoA5E7mQjmGZNaD91B+7XmDKHEsu8E2HivdlMC01xap3cw+9w9J9wb5/qw/LQh4obzDkfBSEaNyoLxNAIBNbauoL3Q2pnZ+09tD+dwKgZ5CKj0Vmy/ezIoVgUWB5LgxPdpiE9e4OHTo6oWuesz5Tmc91jVXy2ShpBj0zqDRy74x2Jbv1XgtslBaddi18bwisL+dK+ZoAO1EC9lOE6nDO4kvBTJXHVFEU0w2kZymqA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 08:33:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91928dd3-e2cb-421b-dfbb-08da5f197866 X-MS-TrafficTypeDiagnostic: DU2PR04MB8647:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TMrvHklb/1Tt5auFBRdcWSDPvCaa0ECElScqJKOukMheQwZ99Z1A0mYBtdLpPbnno90/Fyn1ZvCCVfNlc+mwrUjnK60PVR8bATb1/cR8BoBZuoCmKzF/sX/FBkAdijFW11G30IUznwBoi0JxM5onIUe/evIwnp1bzZGe+Vlv1QdVfdS+HA39+19Po2GWLyfEpUxeqr6/KLMyyKad8jHNocaA3TJDwIVX8fAgd1+PEIeA5cUPhZ/m2H8xqrpOhsFee/47UMkGBeDdJgZODs+stuHf2iLkYQ2fU3zeO1aBJkuq32jW3Nsg/km4Mq/ImOZVF5O78/k6DABnI6C5Tc+CImHzifB8oHMJ4yIIPQ/YM8Tz4B3fojlnSiKSZzzAw9q2LOYNAXBc9hSOPtmnW/2YD5++PuHF9dDGbqU9A3bGA+AW5/iovdm3zWAvAMc8plVU/+tNRgx/pOMA4et4gsMdEWKoP4xL9Bg1ZqpPRFfxUryeSCuhaVyPQCtsnsvdIdd9BCIntjvsA0yJKzlQub+X1s51SNWtESuq4BLj/MfVkflu79qzQbdYhpYwhG24Ckr5v6tljcpMHGs+kevZzj3bPyFEPo7YHvc2ixWtV3bZmLYWHBQf7mGXppixdSdPU9vRVSoJ+4kMs/hTStj3AJ+E9VpnTga/t4rr6HRePyTOT0txBs1VbV99AFqZM7lxFF6FJYqLw7B2abyctOn4U7uOQWcoK4swwTa84Udm23aDN6N1Jf83WucMEB8OkVAC6xxeBhJkTPo4KgX8cmpDs6KIEDxPB+W6yvtH0vOs5e9qiNlypkHqGkEYWG9dbfN5OUzXlziPy+L0zdK2gwkEiYuwKv3ExYgp+JejvsFhLdDTS/U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(396003)(366004)(136003)(6506007)(31686004)(36756003)(6916009)(54906003)(31696002)(53546011)(86362001)(38100700002)(316002)(8676002)(2906002)(4326008)(83380400001)(41300700001)(66476007)(6486002)(5660300002)(66556008)(6512007)(26005)(66946007)(186003)(8936002)(2616005)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDV1bTFwVy9SazlBZldvVkd5a2pHYTcwUmNwdkpIQi92Y0UwQkRWeHZxRHow?= =?utf-8?B?VXBLZS9sUERIZUhNbkFxMmxJMStCR3F0WkwrWG1wZDRTUDl5Z0R4MHBER2Fy?= =?utf-8?B?cDZvY0tjc2VEVCtVay9lcXpURzlGMmZlMHB5TVRXelVQVkgvdTFIeGdHcW0z?= =?utf-8?B?TGd2QWZKNDVPdWNiNkxxc3loV2d1eGQwdlF0NTJyMW5nS2hJbExZcHhlTytR?= =?utf-8?B?Wm1jL0k2elJOaEZmSzlORmk4ZTBENUN2bHNaOXdsVDBpRWY1NzJmcjc2b0ps?= =?utf-8?B?TXBnRkZpUFRvTW1yKzJ0b1o5TFlrNCtkR2Z0TGhCMkRvWmVxaTR5STlreGh4?= =?utf-8?B?cklmS09jUnQ5QVRyL2FVMitKcDU0TkhINE94TnB1K2l0WTZLZXJPNG9IMmlS?= =?utf-8?B?SDRRbVFIMUx1bFVjbEJ4M1VFSjBBOVhUYVhLMUdsVDQ1b0VYaXZ2SVh2NUFR?= =?utf-8?B?cEVoUVVRaG5kUkhDSFpwbVQzdlNWYzRJQ2hKR2J6eGxQMVBHWHpkWXlZMzJN?= =?utf-8?B?N3JIb0szajM1UFNZbnJLNm4wM3paWjRZODkxaTRmRENXbFdIWnRjaGY3SUFy?= =?utf-8?B?bEpxazg1Tjl6U2xVRTgxTlBXbmNBbnVNc0JVYzUveGx5d21UcHdvRC9jMGhY?= =?utf-8?B?dXcwL1RwMVdHRi9SOUUwVU40ajVUd0k0NEs2YVhFc1ZraEZKNFQ4d2wwWGxJ?= =?utf-8?B?bnlvb25kOWVneG5aMlJrK2pWdnRjVnBsVHZiSnJWdmdhQm9OL01vQTg2UXo1?= =?utf-8?B?KzJmLzJpWFkwaGQybUVjOUJxWTQ1djM1Nk9Yc0wxaEorT3dqelZzZDZ1aEgw?= =?utf-8?B?a3VNb2dsM0hXbkE2L25XNmc5WnN3OTV3dVFjMzVWMDNINUhlTitrS2VDL3Vm?= =?utf-8?B?dHJiTXd6L2lqM2p6UmlyNXRKQXdkaCsxOUVMZ05ZZUIrUDEyTWtCTFVYTTdl?= =?utf-8?B?TTZaQ0ROdVNtZ0YrWC9aNlpleE1IajRNUHovZ0IrV0ZqRmdEdmh2cFlzU3kx?= =?utf-8?B?TENvVUVSQ1JCczRKYURseDYzLzRsdzNGa3hxeWZrOGJOVStrTmlBRTE0K2Rk?= =?utf-8?B?YU9YMmx3UTdUcEE4R0M5Q1gvajN5WUMweWU2SGgwUG8vNnNoUTdINFB3UEZC?= =?utf-8?B?QW5tcmVsZXNaaUVkTkttUU96Qi9ZM1c5ZW9pRXozVWxGU3BUczhiSDU1R3lv?= =?utf-8?B?ZGl1MFpSL0lIN2I5V0RuNGlpTERWajRtUzR3RGFYQlF2Y0p5Sm9tazMvNVZM?= =?utf-8?B?ejBqeUt6SW9rMURkbGpQakJMQkpWc2s5K0F2VGt2T0ZRRHpPWTQ4OVd1U2lS?= =?utf-8?B?dEpCRUFmYm8vS3VUK01jQko0YUlMekozcmJCMmN2aklsV1RFTHFVM2JiTVFu?= =?utf-8?B?UlY2TjdSRU0wVG9YV1M2RG1qZFNNUjJ5SEN1amhTc3ArMXoxUDl2QzJPdkZm?= =?utf-8?B?aHJyOVhYckRDakp3SDBYdGpRaFAxSUVHNWMycnF6a0Jjdk1HQzBZMENQcUtp?= =?utf-8?B?UVllK3JMVnVGcXUxTlFqa2FOQ2dSamdOMDJEeGpmc2hLMDFOZnBJbVByZkZk?= =?utf-8?B?Z3VtSmZncVVmYy91MVkwekkzcFR3RWpjRENEZDBBT1NVUHpYcFozdElRTXZ0?= =?utf-8?B?NXlEdXdWaytpUkd6NFZsN2xLMU1KWTlRM1dlUlk1KzdQSGtBL1ppZWdkQUkr?= =?utf-8?B?TXIwbEVZZTR1SCtsU012bGRlMDVORlQ0dmZBVSs0WFZaSm1YOVRuMXl4QW52?= =?utf-8?B?OEt3QlhicEcxZm4wRUZvU0Q0WVg0SnpVbzRLbldyRlE2TkhvMnZOMXhJUWFu?= =?utf-8?B?K3NYT24wWnZsZER3cUx3blMvc0Q0MW5WYmtBb0l4YUdyczJOb2tDRjBsZUww?= =?utf-8?B?U2ZrOUREMjdJbEZiUnZuYUl4ei9ncWFuaWpwUDBZME1lQ3VVQitFQkhDUlRw?= =?utf-8?B?YnBEZEFrSkpGUzlIb1VXa1Z3cG5mUUZNcnYrV1pXcFdxc1lBRmJmN3dVNEZv?= =?utf-8?B?S1kxaGNPMUVkMUQ0cW9NU2FSSy85am1OcVZyNG1yWHJjeDR2dllSYjJNRFUv?= =?utf-8?B?ai9sRFZuOVhvaVlaUHlQMHFLM2xKR3VmdEJpaE1WSWVBTlkwenhUdmtya3Jx?= =?utf-8?Q?PzeJshTzRG4UJvUkqWt5Lpu3q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91928dd3-e2cb-421b-dfbb-08da5f197866 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 06:33:42.6425 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OMKd1EQsjwpEVkNup++SRobyA/scpPaufxbfsWFjrmsV5yw+5T6Hf3VAdWiSw3o51jnRfxMISnhYrd8OjTur/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8647 On 06.07.2022 08:25, G.R. wrote: > On Tue, Jul 5, 2022 at 7:59 PM Jan Beulich wrote: >> Nothing useful in there. Yet independent of that I guess we need to >> separate the issues you're seeing. Otherwise it'll be impossible to >> know what piece of data belongs where. > Yep, I think I'm seeing several different issues here: > 1. The FLR related DPC / AER message seen on the 1st attempt only when > pciback tries to seize and release the SN570 > - Later-on pciback operations appear just fine. > 2. MSI-X preparation failure message that shows up each time the SN570 > is seized by pciback or when it's passed to domU. > 3. XEN tries to map BAR from two devices to the same page > 4. The "write-back to unknown field" message in QEMU log that goes > away with permissive=1 passthrough config. > 5. The "irq 16: nobody cared" message shows up *sometimes* in a > pattern that I haven't figured out (See attached) > 6. The FreeBSD domU sees the device but fails to use it because low > level commands sent to it are aborted. > 7. The device does not return to the pci-assignable-list when the domU > it was assigned shuts-down. (See attached) > > #3 appears to be a known issue that could be worked around with > patches from the list. > I suspect #1 may have something to do with the device itself. It's > still not clear if it's deadly or just annoying. > I was able to update the firmware to the latest version and confirmed > that the new firmware didn't make any noticeable difference. > > I suspect issue #2, #4, #5, #6, #7 may be related, and the > pass-through was not completely successful... > > Should I expect a debug build of XEN hypervisor to give better > diagnose messages, without the debug patch that Roger mentioned? Well, "expect" is perhaps too much to say, but with problems like yours (and even more so with multiple ones) using a debug hypervisor (or kernel, if there such a build mode existed) is imo always a good idea. As is using as up-to-date a version as possible. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:44:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:44:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361793.591477 (Exim 4.92) (envelope-from ) id 1o8ylu-0003Kd-J7; Wed, 06 Jul 2022 06:44:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361793.591477; Wed, 06 Jul 2022 06:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8ylu-0003KW-GF; Wed, 06 Jul 2022 06:44:26 +0000 Received: by outflank-mailman (input) for mailman id 361793; Wed, 06 Jul 2022 06:44:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yls-0003KQ-Hm for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 06:44:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11a365df-fcf7-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 08:44:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4189.eurprd04.prod.outlook.com (2603:10a6:803:3d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 06:44:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 06:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11a365df-fcf7-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OapNexyMsroq2B7vY4vcb8wI53pPf1I4NT+eYARm3gllMZ/iLl2D/f7MwKZs2jq/01rR5K9H9zp6SFvtK1C+yLuhDskKuTcJBkn+iQq3OfGPNakNnHTBQnfGxu2b+j4ypf73DUH2jZ9O4FQLAypM5NcRZaAw0wJUY1IULV81EO5ysBmBv85GUaUZh2YxSMyOZh1n+MQA9LfDTZjBcfUTvd6UGIMyT3773o+zc4wRV6sxbAzQyoAi0AvaRwFPXpJXhFy5Ey5y+00+2z1JOPJYmUPnIdHLWGL5d7/UYQ2cqlTP9sFOIEpskpop56beR/A3yfvREHsGV2BFNpx2pxImfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w/gK54icbsIHz2bCdPPSpmMzUybpoIrjdw7EWN6D9jM=; b=cPqGiju9j9g3V3uumTfPPT618NHlgV9wfkXsN/Mabqd6W4uwpT6yIkyXJWXDCnO2hV47W3xh7cg00HXsF8hHtko7d+kWlfUC+cp8w4nrtuu6bWF5atEPInJ8KpvWqjfUAH6RMvzUmAGrVXLKB2TJ/gz/fOAV1hGqpBINqJvb2Oe2/YtsH1xFfuSE1okfG1Cm5HiZ6DwUTh3LTZ/gIo8gaXOvhMx7pzUlMFwK+hNokm0AT13DpnaZQU6TMcNyodRE1TzXcTn+jF7vGT8dTOMmuX7SXxCGYpH3W6WNKCcZJI/d4K/3jXQLhbduOVCxTiEdY1A9CbpEkQ27K8eOteqOFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w/gK54icbsIHz2bCdPPSpmMzUybpoIrjdw7EWN6D9jM=; b=QXSTPhCqDzNbpCeMgW8KGBNP0/j/rdyLXQPRNbr46FZKJ/kixGNN+gfQ8YVhLoJNYjs0bmIJ45ujkJsPPTVSEVfIEH1WU5D1ZnDx+mNqZQ4DDvWxRS8+UWLqJmXpkL8rMIli1V4mDWiQl4zyiSHFRky5uPliUXliTtsBdWyD81EGtLKJ4kFXhVYvHRE02ZLErQII+uVThECOBgIi9eK0bJ+g/olQlkaL4/c2NdkenhrzjiQOh8PJm3yLAOk2/qvB0OeOWRwbrooYxMF67xnMRy1ITu1RYw1d5fIZu+H9Uq0UABcmNE/Hc+i9+3Ik0q7PHv7po8rskQ+o9EknSjk1xw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 08:44:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Content-Language: en-US To: xen-devel@lists.xenproject.org References: Cc: osstest service owner , Demi Marie Obenour From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 765d69bf-88a5-4430-7237-08da5f1af37c X-MS-TrafficTypeDiagnostic: VI1PR04MB4189:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5PsAAF3G7Tj41lAXhtunqBPEz6xR+2xuxMADJ+mRkmrSmaR0JpY8Zl7gXy6KCQyQs6abTWP/mXMuvW4tosXi1gCWAxudJQ+bhqdsRfBxjsueDnb6RDojsw3bKGkj2VF962XxFlpylkLGLn+igZN5nxWcKvwHhBqxkWqhrATp9I0u7qaB7vfag5U2z+cypdELTU21ivlTkoTjMjdyw/VVv6Vf3dZe4vHEQG2Ah0zD5YJCA2jbUYAE9Z5MrXVTzqjQiBrm79LVlM9zRTS6XbJ4d+x4g31kwsmc9TQbbQ57c5GN+fN158yK2grOWRQSy+/ShICsPgzK7Ev1eg4jUdttVUZw8e1aWz7F5sut4/BckOGwjoa8vLvixWejalDHgJYfpHtLxiH16JZVXoCAwyrb/LHUJbLa+kDv9+CWEIgpOK4z51d8b7qbROuj9z3EYLTlPwBNHWh0enOLryd/ggWJeE8joSYyH12kP0IikVMe2c3wKFOl9B/pEfEbWTrqHzjAvwZX1a8m3EcnEsjktLuRgLuVUeOzI9Q90O4/5maNjSGTyQhD3ZLjVEUG3CleHh4mFC1c4pV7QjfN5mzHkciQjxpzvdKzImIZd5XISSjDuW6gRmDSzpOG0XlD5+9IJvRVOKWeyj/fW3vSby0xuhEctKCem/qHJO/MOYUJ294WOrFeQoIqV3lL75sl6r36GVrn1wrQsxq39afEgNkmMBI31/dJuTQWjeIjVszZm3qxUy6jV0a7vF7DCEh9btpHgaTqfRh5crEpv2nVcavikV0PuCWOICeonswV2YgXIwjC0voALf5acBSyvx+EWZ9SU7YbE4QOZUpXcu8x/dujtTTbvIv5UO4WB7luKdNv4RUIUdqn8lCqCR7BhiyAdc8tYksHnv5GUsKDlDtgcsZ8wf4iXjB6kBTyyH9KFt/bb1U33aU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(376002)(39860400002)(366004)(83380400001)(31686004)(53546011)(6506007)(36756003)(6486002)(478600001)(966005)(26005)(186003)(2616005)(6512007)(41300700001)(31696002)(86362001)(54906003)(6916009)(4326008)(316002)(38100700002)(66476007)(66946007)(66556008)(2906002)(8676002)(5660300002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R1oySncram01cUJzN3lsaXdSTk1BKzRCTTducXhhZWVqR3lONDVyY21DeDR4?= =?utf-8?B?b1o2N3huWW0xU3Q2Zm5xeXRucGNNajk4Vm1hNFdCZlVyTXJkNkxvdHpOaHBi?= =?utf-8?B?eStGZUxCbyt2Y3M1bkxXOURNM0crNm56UWhwckR1QktQVE1KYjhyYkltVEpT?= =?utf-8?B?bHQvb0l4RzIxUjBsSHdCWmR3QjF4MnlybEY2cjlFMmk1a3NjcTJhNXcreU1o?= =?utf-8?B?SXhXNG01RTkzZXRBeGI2RUQvRjNzOHR5VU03MnlpWjV6TG9LRi81Y3NRWVQv?= =?utf-8?B?NGpJbXV3aVJHcWx4WjQva2U3SEk2Z040SEdXS2U5dnBkNG1Rc0MwcXpHdnFz?= =?utf-8?B?RjF6Y2dtdENmWm9uWTRhMFF4L3VEUjFzL1I3SHhhOVgySGpRdHpKcWN5anpt?= =?utf-8?B?ei9tdE9JcTJtaTFmK1dpOEkxZkVKMTVxSU5yaUxxQUZyNms4WEhCb2Z2TGg0?= =?utf-8?B?SVU2SEpYY1FQU2RnditsSGtpbW9OYzl0d0xNYXY5Wmt3R2hySkhkaUc1elRn?= =?utf-8?B?YS9BZXlYaTc3U3RqQUJ6M3dnWHlVeGVIejdzR0J4WDhNVDF5dUQwMHFwWFY4?= =?utf-8?B?dElJMnVEZWk1ZFNSdW5CTWVsdWMwa3J0amxTZnN3aUNXU1QySldFUUtVRDVM?= =?utf-8?B?a1FJM3dtdnMxOEhZSGg2cmFVSTNoUFBQb2Z1dVlFNVhyK1kyY1JOSVZMZnJQ?= =?utf-8?B?cGo5ODFmTmZFYks2L2kyR1htT0t5RXRMdVhiWTBQQ2cxRkcxSUg2RVRHejI0?= =?utf-8?B?dnNtZDJaVHNaMU10bHJESFBHSU9iSG80M2Z1TXJIN2MxSFZPUnBKWnVkcmdY?= =?utf-8?B?MUpDTzFCN2ZMN0hTV05hUm9sTWF2VTBValc5OTBMMDlYWncwSm84Yk5JUDM0?= =?utf-8?B?MHp2elRpaENhUmRhRzBmMElBYnJaeEp4dTM0VzlRUHFpSWlCdUE2M1dOeCt4?= =?utf-8?B?b2JVMm9OTjkrcHhPZ3BHcTlSVmZMUEovb2ZJU0tiQTNpM2o4aGN3dndvS3JD?= =?utf-8?B?bW5DSUcvQnBXYWRaaUZzdzFtSFhWMGprcEc3YjZtcC8wM09OYVd1bzkwQWVk?= =?utf-8?B?SlZ2dkFnSGIvR0l2UlJlcE14TDhJNUUrQmwvbXFJUG1wZ2ZJckk0QjN2bTYx?= =?utf-8?B?c3lqYSswM3Yxb0Z1V2QvQ3pXZkFsOHBOYjBiV1YvTjc3K2kySHR4TWVBcUpR?= =?utf-8?B?b1kzY2RPekdyWW90Q2tKQWYrMmhPSkcyaUR0T1ZQaFAwYmxkMU5UWlhIQVFy?= =?utf-8?B?YnYwK3gyVlRERmZMMS9VVUdxT2JVSGFYdUFVV1NpN3BrbGQxSkRPcHZqSDdV?= =?utf-8?B?dlhUQUVlbWpqS2JzYXNNa2NDb0tlT2dvWmt4TG9EWW85VW15VFJleG93a29j?= =?utf-8?B?a2tNM1pTc1pZRnozTDBFbFhtaWQxb3J5d1c3Q2RnRjZCL1d3Tm1IYXc0blVQ?= =?utf-8?B?MzVhU3lpTVBnVTlvVXJDUUY3TU5SOERGVTFRUUZUM21RbjZDM2YrbHBhV3ZI?= =?utf-8?B?MVZ2T0RLMzZqUlZOZlQ4cnJBQWl5dDF5TGdHNldaUEtHRE5Xb2RvNk9VRGNI?= =?utf-8?B?SjJnVU1jTER0cnZGVlZEaFpobnJiUzF0RDZEejRDcC9xQzFpbGNIVkYvaGw4?= =?utf-8?B?TVMvOUxrcUZyN284V2txNXNJSWozdTRxTE8xVm9DSUpwcHo0SGk1SHM5MERz?= =?utf-8?B?U2VhbnorekJTWllHdWlJTUVaTC9tbDkzWlhDb2RsQnNUZ2FTdzJqTFlaUHor?= =?utf-8?B?MWl0d0p6WEE1cFFJK1BkMTg0eng2bFVRWFR5MlBwV3Y2Q3RFbVhvVDFkdTJL?= =?utf-8?B?QmhiOE9SNnFCaHR2Ykl6ZkI4RnJhSmZDRHNsUlJwY3VqRGdybXlUVnFGNGhj?= =?utf-8?B?aHNYWGJtYmRFbjI0ZFhMWGZYanFVOHRKY3E2dnpUSzlqa3RyZ0lYWEt2WHQ0?= =?utf-8?B?V21aSDZMTlhjZ3VEWEZHQjRuSlVrdXpmUVF4VUdjRjFYNFhKei9DMFo1Qk5p?= =?utf-8?B?dGw4Z2w1dUplTnZFOU5KcXg0ejM2bllZZ0QwZGs3cUdvYzB4UTY4V1E2RjVU?= =?utf-8?B?OHM5MWpaMVdQVkJ0SWp5QVRmUy9lSWhwanltbXJNR1pZdUljR1VrVU0yZGov?= =?utf-8?Q?5DGFxohRjJ3VBhqpeAHUj9C80?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 765d69bf-88a5-4430-7237-08da5f1af37c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 06:44:18.9685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eLnLcCvshPKMuG5wI8TZefZMq8/uNN6JAJcOETK5d55DjQa0RorDIyizQU1Mt2w8PjlY1EBIBjS4Bk24PmPcxA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4189 On 06.07.2022 05:39, osstest service owner wrote: > flight 171511 xen-unstable-smoke real [real] > flight 171517 xen-unstable-smoke real-retest [real] > http://logs.test-lab.xenproject.org/osstest/logs/171511/ > http://logs.test-lab.xenproject.org/osstest/logs/171517/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Looking at what's under test, I guess ... > commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 > Author: Demi Marie Obenour > Date: Tue Jul 5 13:10:46 2022 +0200 > > EFI: preserve the System Resource Table for dom0 > > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the ESRT shall be stored in memory of type EfiBootServicesData. However, > memory of type EfiBootServicesData is considered general-purpose memory > by Xen, so the ESRT needs to be moved somewhere where Xen will not > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, > which Xen will not reuse. dom0 can use the ESRT if (and only if) it is > in memory of type EfiRuntimeServicesData. > > Earlier versions of this patch reserved the memory in which the ESRT was > located. This created awkward alignment problems, and required either > splitting the E820 table or wasting memory. It also would have required > a new platform op for dom0 to use to indicate if the ESRT is reserved. > By copying the ESRT into EfiRuntimeServicesData memory, the E820 table > does not need to be modified, and dom0 can just check the type of the > memory region containing the ESRT. The copy is only done if the ESRT is > not already in EfiRuntimeServicesData memory, avoiding memory leaks on > repeated kexec. > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ > for details. > > Signed-off-by: Demi Marie Obenour > Reviewed-by: Jan Beulich ... this is the most likely candidate, considering in the log all we see is: Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirty) EFI loader Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. But I guess we'll want to wait for the bi-sector to give us a more solid indication ... Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:54:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361799.591488 (Exim 4.92) (envelope-from ) id 1o8yvV-0004yG-Ie; Wed, 06 Jul 2022 06:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361799.591488; Wed, 06 Jul 2022 06:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yvV-0004y9-Dj; Wed, 06 Jul 2022 06:54:21 +0000 Received: by outflank-mailman (input) for mailman id 361799; Wed, 06 Jul 2022 06:54:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yvT-0004y3-7p for Xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 06:54:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73e3b29c-fcf8-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 08:54:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR04MB3012.eurprd04.prod.outlook.com (2603:10a6:206:f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 06:54:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 06:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73e3b29c-fcf8-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e8/9IwHtVNyyMmS/p0LLK270MTWpQlBeXaE2q+l6UPYJPfSXXfSRZ9lvqw+4WPI5Q66TTlZR+1qGcaQdcsYOy548Ywxkj0zEG7O05KDUnB/YfgZntIJzIFAPLN/aEEFrXDpqU7ACS74/HiB2ZwEesuzEPnD7INgD0JdrZjX+tKF55t1qVyozzVrakZhCY5+tsvrw01CtO+Slpd92jooDLZ4CJQMnTJmNziheOwPG5CK7klMhJ5Ktv7TMxLKEBRiGBuig/VTZNfE0GQ8MQa7rM96dKhn8k6I7ArRWpu3ktcw84sy7tRs04CjJKMgERLimhRloZ8uThM8v7Z+/OBC+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OcNK1E2+WvdMepGilGPDMb4jUR7+vQTyafiJd8TY0+4=; b=SX+xPxw1f5ABf3w8hiHrkmTH2m1WMsGgPe6QM4TWYTw9S0R4v77AbsFu4dzzSU4RD0g45t6KvWJ7vi9Av7Zm/BCbqSTX6CUJ1TlHilcAFDNKDMBW0RXxhcYlElXDZMlDL4XDzQdXr0+CogESIpHs4jW8PQl6xx/5jpF6Hf4GpFED0bdxLf/0FolOTLVF4Mn5hGZ4xGzM1iEHu7A0fbjo7kkhSFcyWYYSJHoG1Cr6JtHhGacL4apNbhaJ81w+eOOUvOkNakixfGLa3lYqJ8NAcCdgDiEA0ae3BPDsQzpqIrYAeawUrohMWD1RrsxLR1iE3T0iK6V9k+M1XzVmH7cQgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OcNK1E2+WvdMepGilGPDMb4jUR7+vQTyafiJd8TY0+4=; b=pbEfzq1uV7I1vJkoFyD/edM+0pg+VwLNxuN1X9D1aO4NVH7RccFpqGJpKFtnn3egK85oOo4w9SDb9mOcku6uE+W3bG2WQ0iKMfYCbJBorQIpQEyCQ0NkjjBQz0JfpPFwTJzo/B48eiPg23TYYZjaRaiU5oI+1shdiurnEmTwni9UCU3nMFXlzO0NOJ9LJx+JAojC1yrjAH4jkaualwn7AlKPZsoY7MOZATO22PQmL31Z+Pq4tGc6S9gLYsQvxJYYgB2evU0kh7WyeAC3+9f8lL3SM4CBRt60zXam2BxYWAvYDzOS+fW1eJxCTIUR98x+yudPcjrCE+4qcJeD+MjtQg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 08:54:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] livepatch: create-diff-object: Check that the section has a secsym Content-Language: en-US To: Sarah Newman References: <20220706021817.20437-1-sarah.newman@computer.org> Cc: Xen-devel@lists.xenproject.org, Konrad Wilk , Ross Lagerwall From: Jan Beulich In-Reply-To: <20220706021817.20437-1-sarah.newman@computer.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0159.eurprd06.prod.outlook.com (2603:10a6:20b:45c::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9bce038c-e68d-435c-7e6f-08da5f1c5750 X-MS-TrafficTypeDiagnostic: AM5PR04MB3012:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c0f2D4Y2ysWZ07JoOBOyyRpeM2XN9R/0zbVyKQYXub3igjuiJ+zmlfcu4ffSURkJgdqRQWYGgAeD+JGxlDpsK5RdTkL8YWwFvNkOhuB05zCZp1qU5ePwxliH1XeiRQ+ow4Y6tgEKt5kxqkk2y43zfRCz5i2qMJHK1aAppoR3Yd5Fy/BpzwmAUMF0BwjGD6rnhXlfHtb3tXFLwt3bQ6PqG+UlRuDs+oKWTPI4/SAsqUJPUWuhTKFHEjz7R1Ns6r43KuNxKXDvME+6xk5GMOS13qnFPIF5Jf97fZvYZe4oeLh2H/LDjLm3CYh8AFQ3FFTKS3W70c2je3hMbgOCfDXcdZL8AwlFj1WQWzMTcT73/MNas94yuIJWzLEc+jZF951HIalPJyx+1vbOYq92QWFZgsYR2ErI8AMENqdbqn1nrXpNC0d88FT4tj6D78NDZqTK+WnatdzwX6Nt1XVSLDfWeANe8LJYvPAa+72Efrnxc0ltXgR/zTCJRx8fd2Yl85U2u6i+5Xnr0CXoFTxeGLZaiaWPkUzApol4VynnyD3tRijqnfQZDVWSIpfmoBCttTxMh0HhcWvbCzWvTpTNSApom0MI66dj075LL+KMOfi8CT+XJM4HKGZu/CcPZZljSXzgudTydgLQRKaM3uNoM9luoevnVVMgmYzx4f1HwFtIxlZE0Cfc9ZCuA4kQhk/BuzkjuCZFahkLTXF7ohLAYoxkjQMIl172z46vvxENrWF7Q9owWl1VY+2YpjCxURovnGI6Hj2REQDg+L5D5ixf0NPzSWwrBBHMtlL7entErkphxKyQhTlwUxCPnLWDHCID6FkYIgPbcxpoTeaZaPsfG+f5PCxfKEcwtht+gLbAoXkODPeNZbvVNSiP8hG9onQBZTAS X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(26005)(6506007)(41300700001)(2906002)(54906003)(53546011)(316002)(36756003)(31686004)(6916009)(38100700002)(966005)(6486002)(8936002)(31696002)(5660300002)(86362001)(2616005)(4744005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmVDS3V0dERwdnNScUVWTTZhZHFSNExvVjRJUGw3b2piRUxpY3lWSm9lR0Rk?= =?utf-8?B?R2hSQzZwNndNYmVJc2NkRndhK29hNUk3RFE4K21aUjRQaGxkR2lEdEdMazNv?= =?utf-8?B?Szl0a1RHUW1ndlpBUWVSQnpGaHRrVFZSUXk0N09UNUdjbThZVXRVdjFDc2ZX?= =?utf-8?B?UDB2ZmlqNVdTZ2tpMEdtamo1cUdlZ1FyZ3hLZjBvVUU4R1F3WjZrSkMxMFVv?= =?utf-8?B?Mi9xTGVlak5ZSWNjNTJMVUlFMTRKQlgvYm5PYkpVVXk2cWtXUGpzRFlIMVV3?= =?utf-8?B?Q1l3VmJWNTdxOXVCSUY2UDVxdkNORUgzSTlPNndvUStUOGJHYkp5dWl0Wldu?= =?utf-8?B?ZVFPbkJtR1p4ell2dGVuVkJRSUtxSjZmdTNUbmVvUlllcHJ3amE5dm9talFD?= =?utf-8?B?Z2FYaUI1MVRKaG1GeDI0OWRVYjRPNytKYjlIQy9TbktmL1BEZ1BvK08rRlFP?= =?utf-8?B?b05xN2NQSXY2NmRXWkFvdGdYcWhETDdaVUlMTk1PVUhkYkJORXY1bm45WW90?= =?utf-8?B?V0pjdUNtREQ5dW9IN0VQWXlvNnNhaDRKUDdGNlQyVnpwRFRialBiUWxaa09x?= =?utf-8?B?Qm5kL3E0REVhQ1MrR3F0M0FiMEVLRS9KeUxhZm5XekY5dWw0dUhoMk9MV2Jm?= =?utf-8?B?WkZTMjdRRGFMNnl2bHpVTEZSVGJ4L3NETGV2SmpYaXA4TUJXT2h6VFVhdXpa?= =?utf-8?B?ODlkM3RGdTJhUDJaZFIrOEVML09ENkxBQm4zNEo4eUVXcTFhMm9RRjZIa0tK?= =?utf-8?B?enc3dERmTnh2U0dKSWdDekdtY0VnaEZRS25GNmlRNGFlbWgvR3Y2OVNyQkNL?= =?utf-8?B?UDlUdzhjeVBaZlkwUUpqMXRRZVFCOXk5OWJXYmhKYTJqYlpvcjVMNzg1cG5n?= =?utf-8?B?SGtrQktmSzN3SEZPMUxBWWMwdTU4NjdJTmcyYU5OVXVJUk55WFpIWHFZb3FP?= =?utf-8?B?ZTNCR3BBRDRkVUFnMVk3WU42MVh4ajlWRVRDQVRzYWtZSHVFYWhRNUJhMVFx?= =?utf-8?B?Y3RScXp0ekUxZGZ5cURFUUxaeWVTekNkbUJqbVozM1lGSXNmSko3bFFOWmpp?= =?utf-8?B?dGo1UVVTcFdNTEdCY092S2JkT2FnaUpEOGlsUjAydUVSaW5hQ2NuczNXcVdD?= =?utf-8?B?SmhVL0NsWVNiWlVLSTBLeUplZEJtNkljMU9naE53YkxySnFCT24ydDBMQnRO?= =?utf-8?B?c3JBaEVvVm1PZ01FUWJsMGltaHV3TnhSOG5jS1Q0NGgrZWlCK0RzbmQ0Zlow?= =?utf-8?B?MGFKVXZTRkh0amgyZmF0MXF2M2k3WkRtOUVVN0RTQWw2bFphajVwbkptVmt1?= =?utf-8?B?dVhhU25EQU5tYWtiSlZHNVU3bEpoS0FDNXpqbzZhZWhNcWd0Q090T1BaMG1r?= =?utf-8?B?SXFnbkViaUJkelI3VDBJVnRVanVlSTZ1bm5jQmRydEpxUXFPMGFWT2pRaEVn?= =?utf-8?B?MnIwY1RoZFlHUWI0N2Y4NmJsZW9PbzdtMEpwWnNZSmRaTnZMS09Oc21KcWkw?= =?utf-8?B?TlQ1b0h3NE9XaW9ycy9JS3M2WXdOY2hZUWp0bEdldUJjdkRaWkt1MEttUE1B?= =?utf-8?B?V1VaZXlpN2hQSElwQkx0S1lvWm9xTE0wdDBDZEdWWUZmSXRXcTQzVmtldVNB?= =?utf-8?B?MnNORnMxelFxYnhsaGE2blprSXpXRlZTcEl2ZVArWHYrTGxjSDB2UzRHZENI?= =?utf-8?B?UDdKUXBZTmNtOUNmeG5VSG9VMk4wcUxRSmQ0QTNOQ3hBTXFXTXhOY1czRklj?= =?utf-8?B?b1pHZVlGSlBGU3Z5YStvZzhJcmJrdHdUUGI1U0M5Q1BEQm4vNGczQVpjcnVn?= =?utf-8?B?RWtpNjk1NmtkMm8zUG5sbDU0T0RZWUxnbHdQSEE2dUhsMzBSZFpYSGRTOWdX?= =?utf-8?B?alpsdUhqWXdrZ1NnM1p4c2NqbHhxZGFLM1diTDUzeStLa0YrM1RMU2ZOaGVj?= =?utf-8?B?SWxXQWpCbjlVV0taZjFVWHlCM09UUXNXSGFTZFg0UktGMm5JMmlzQXI3V0NB?= =?utf-8?B?Z08rRm5HcDl4Rk5JT1pYaVhkY0N2dTZMekY0dGlIMGZiWjl6WS9pVUtrcjVq?= =?utf-8?B?eWtJMHVRZU9ubWVYZTBKbklJTGtheTc0UEs1Wk5jUHZUanUxL0dyaHdrU0hK?= =?utf-8?Q?Nakl559riz/1kMoXqgxF5ePJ0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9bce038c-e68d-435c-7e6f-08da5f1c5750 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 06:54:15.6368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RsFxVoBzUIjUtVgkgjhfvzLsQLSS+rQTM07E/w5pvTFy13TXT8Ww8+3r5LxXTtZn1ekSVZySwr0Qxm0+JtfGgg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3012 On 06.07.2022 04:18, Sarah Newman wrote: > A STT_SECTION symbol is not needed if if it is not used as a relocation > target. Therefore, a section, in this case a debug section, may not have > a secsym associated with it. > > This is a livepatch backport of kpatch upstream commit [1]: > create-diff-object: Check that the section has a secsym ba3defa > > Signed-off-by: Sarah Newman Reviewed-by: Jan Beulich However I think the 7-digit hash above wants either extending to at least 10 digits (better 12), or dropping altogether for having the full hash ... > [1] https://github.com/dynup/kpatch/commit/ba3defa06073dcc69917dbbbb9df570ca4e56612 ... here anyway. But I guess the rules set forth in xen.git:docs/process/sending-patches.pandoc could be applied here, and hence an Origin: tag would best be used. The other thing is: You didn't Cc any of the maintainer(s). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 06:57:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 06:57:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361805.591499 (Exim 4.92) (envelope-from ) id 1o8yyV-0005do-2r; Wed, 06 Jul 2022 06:57:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361805.591499; Wed, 06 Jul 2022 06:57:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yyV-0005dh-04; Wed, 06 Jul 2022 06:57:27 +0000 Received: by outflank-mailman (input) for mailman id 361805; Wed, 06 Jul 2022 06:57:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8yyT-0005dX-VC for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 06:57:26 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3103ffc-fcf8-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 08:57:24 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id F279C5C00B4; Wed, 6 Jul 2022 02:57:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Jul 2022 02:57:22 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 02:57:22 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3103ffc-fcf8-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657090642; x= 1657177042; bh=TNUF7M5+wGqWTbj7Pot6CFHrH63E3xsts9bkQ5kFXCg=; b=l wITBkj0ArBl29cm/yuug0jIOcaj5y5FEb2SBRFUPo6Q7NNdXx4LvPOSvmbNwb7PB thQABLkbfHp3xHrnMNi4UiQZTwOov7zOUVXGrGeW0wVj27DBcY21vWlZxYkShIQN 6xyFAsLrKMdNm8F/jTJB4dBP3wa7tGx8V3FGtbws5P+Ly27DgNkNqdUWDUJ8aUBH M0ix6tzELxjbvhreJrMEixmgOygKtfkXj8IkS1LKGzCmRFz3IgHz15USjaAGkRcg 5Tyhj52NvMHEaaRpCsyQfkNQVb8f4nmESazSKd8H3NTtGwVdygM3+sEIGKHF80GM SSO8LyaJIH7lHsySOm2Wg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657090642; x=1657177042; bh=TNUF7M5+wGqWTbj7Pot6CFHrH63E 3xsts9bkQ5kFXCg=; b=Ob+JLYb+Q/Pe5tiUMfhXW8BZx06MBmHxBvd18k/QUQqQ dx1iMn8Wl0uJtcgkil2wgrPRRJKxp3oDE+7M1tR4oyiVyu8qmoRb6YE0FNZXSaNJ shQoGoaq/2USUQ/FP7iwFqqcGc3xj4qvKA9hhm914sZiv3RFyuBZQYrO+5B1uxTI iWfmg/2n2KcGFtkCwyj7LF9zoti0Oa04DmN+LB/C6LwjWKwqBl+Lqps8GpExf8rt VOjdqEP+C2/oQm0aqOefrs9By7GFxcJ4Ue0dCO+Yy5NObkgiyC9LM52/+Im8CPWx MIx/h2u7gwwT7o3brHgY6L8I60M6K4buPDnFT0nGRw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeivddgudduvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeelfeejueekheekgeeitdegkeek leetvdfhuddufefgffehffehueevvdeileefhfenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 6 Jul 2022 02:56:51 -0400 From: Demi Marie Obenour To: Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cgtH4Z1nbZSnYISY" Content-Disposition: inline In-Reply-To: --cgtH4Z1nbZSnYISY Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Jul 2022 02:56:51 -0400 From: Demi Marie Obenour To: Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL > > commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 > > Author: Demi Marie Obenour > > Date: Tue Jul 5 13:10:46 2022 +0200 > >=20 > > EFI: preserve the System Resource Table for dom0 > > =20 > > The EFI System Resource Table (ESRT) is necessary for fwupd to iden= tify > > firmware updates to install. According to the UEFI specification = =C2=A723.4, > > the ESRT shall be stored in memory of type EfiBootServicesData. Ho= wever, > > memory of type EfiBootServicesData is considered general-purpose me= mory > > by Xen, so the ESRT needs to be moved somewhere where Xen will not > > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesDa= ta, > > which Xen will not reuse. dom0 can use the ESRT if (and only if) i= t is > > in memory of type EfiRuntimeServicesData. > > =20 > > Earlier versions of this patch reserved the memory in which the ESR= T was > > located. This created awkward alignment problems, and required eit= her > > splitting the E820 table or wasting memory. It also would have req= uired > > a new platform op for dom0 to use to indicate if the ESRT is reserv= ed. > > By copying the ESRT into EfiRuntimeServicesData memory, the E820 ta= ble > > does not need to be modified, and dom0 can just check the type of t= he > > memory region containing the ESRT. The copy is only done if the ES= RT is > > not already in EfiRuntimeServicesData memory, avoiding memory leaks= on > > repeated kexec. > > =20 > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-it= l/T/ > > for details. > > =20 > > Signed-off-by: Demi Marie Obenour > > Reviewed-by: Jan Beulich >=20 > ... this is the most likely candidate, considering in the log all we > see is: >=20 > Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirt= y) EFI loader > Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' > Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 > Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 > Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f > Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. This would not surprise me at all. I was hoping that Jan would be able to test this before he merged it, especially the ARM-specific stuff. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --cgtH4Z1nbZSnYISY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLFMk0ACgkQsoi1X/+c IsEkWxAAhGcmmF/bt5V+YNUhuHsRvaHaMAtQ1OZvLoP3X0fUWjeyW/bPehmJQiXd N69hQoAVNWIHw2tBR2EaH/JlXe0RHLMtPDeSBWzNBuPBW8zcqvvoGGPxAMWX1fD9 DJUPloL/6JelyaO0MJ3/V2LWR++LZuBTvFLGSc+mcbfUCqmykwhzRCwfAHQS/Bto 3jJPG7P1jN+58klq6ixS/Ewa43Qn4cb2BX8MaGajLKgI74/9F8Yok5SD84otD2BO gJYubE/mMulTuoNR6OkM7tx2g4rUvG7tMQop0H6Kbqthbu13JEhMxu/YV9rH0h7E WZxSpEfTyJ03cmDdgDkOfHiHi/ixGjckituAKwjZZbTAyWtKi3PmAA/gpmJ/r1Vy 94+4b8TUW6gEH0lhyaKT+cXQaks3bgpZ9cMCXU3OU3qByg05B88yiCz7hCZnxnpb SC4xbw7OBr+wDDDTvuuqd4BIuOP1AUx10bz9MoF/UartzMT0f3XhhTjRz4rtXDs/ cHQQ2GhwJRopJNvIJfZvgfQ4Rq7JM0FYbCE6H4IVuSFAcstTohq+Ir17OVfSJJ/N hWp8ulZPlCncMEThuan79vB9pUCjFZkrNlHSInLhr4odBtAtkuGbCBq3UdMIMwJl ofqsJblRGT0n0yTPGy5IE93HVyERJLGXdsFaK+ye3Db3J7wodUw= =A3Qx -----END PGP SIGNATURE----- --cgtH4Z1nbZSnYISY-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:02:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361812.591510 (Exim 4.92) (envelope-from ) id 1o8z3l-0007Hg-MU; Wed, 06 Jul 2022 07:02:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361812.591510; Wed, 06 Jul 2022 07:02:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8z3l-0007HZ-Jp; Wed, 06 Jul 2022 07:02:53 +0000 Received: by outflank-mailman (input) for mailman id 361812; Wed, 06 Jul 2022 07:02:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8z3k-0007HT-DD for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:02:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2088.outbound.protection.outlook.com [40.107.22.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6591063-fcf9-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:02:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6772.eurprd04.prod.outlook.com (2603:10a6:208:188::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 07:02:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 07:02:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6591063-fcf9-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oj/QKHZT60zKn6vNEfGwRJmW/ezv+rj2vEcNXYITBZAoci5GeACmFaD4bKC6K6LR6612dSQys+7LGXCbBezGybT7FEhUehyqx0gt6FZVQCVAlQpseJbgW6xWZa51wPcoerrhdyuIVHcIjSva7BPqpRY07FWmYvjCL5VhRKi2EfVRXSAc2G7sai/18s+EOPHX8oJ1oA0/RPyT+aGy76/jljP90h/89PVKvmjMSEjBF88uc8QUntBPoGXf73GMvsA7iO5U+di8H3BMPUwrvQMumGCrgv8xsmNW6KQSeZA7OnP7fUfWVr6iz4HGEmEpwLRg50aSvSHTMLVvv1XBy0dwPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mHJDN7apsUjgn76lgbjecD6ESKgMZWqrsjk2zWm1mcA=; b=LD+3t2thRZ/z/2Sb1ULDRviX9ZAKM0vzUIBV4NV+SxQg+KxSeZWOudRPqOGRyqvIXaxLjZl7UdZqt2yNKZQR6DX4IvL4zyNh1dONbDO6USn4wzkIMPoGO1i+koJuQ8JWEokunjMusK3IyPeSmpkDD9nezmqdDaebggPDGdwGrvMWLbdaoWy3gxObGGKaXAfsMCaNkZ+oIsJpVRjjIjHXiINhEhDWpz6Np8mIZScaUnWVaCBWls70gFUG73cy7g49gMI8in13NqBYel0ADd9tUCrK8yXvbyXNmPlRfobDX0qc1jK1nIEMpAKy53E6dJ5WxnKMLgHMmgZ+rT+s/QhGPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mHJDN7apsUjgn76lgbjecD6ESKgMZWqrsjk2zWm1mcA=; b=Cvr2EqYsngRxZ/v0aaiR8LPK1BOzUYblJsFZA8+56s3j9kVpzS8CQcXTpD5j5vZKvcrIQFX0ydlrawSH0wBH1zxRuMztkm31qsdS1xEnOBH6xv4TxRC/o1NqMKYS4b7E+tkfKZlgfOWcDeVqrK/0ijjmo4IpMZDxKkkY9x2hGutrb+MMd2mnzoi8cUUUPlaQwwKcF9J1zBOuFXZLNKLHGmYtOUC5pmonx7u7/bP1J6Fkqsy+F9y94fMcrtZHFzEqwYCzhjl8eMno9X1CISdyfNPs/m+3Kw/XRVA8SbVuNJAiO+NTVzfOdH/Ii0SK4zSAFW0iDIV0B8oTP75o2Zj3Tg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <12374e16-8f58-ebc1-fa78-16c9eb6f1d0b@suse.com> Date: Wed, 6 Jul 2022 09:02:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Content-Language: en-US To: Demi Marie Obenour Cc: osstest service owner , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d601995a-2fce-4bdf-0590-08da5f1d89b1 X-MS-TrafficTypeDiagnostic: AM0PR04MB6772:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VG+vXq2O0zmjt7Si5vNOgFkRvHXhCwAuQwuzC4RAyhq/gHdsEsA1Ql8vUO69NBWaMyMCKBo1j7op9Txa9lVTr0IAMqc8qgTZBsZRvfVnR8kAtdCAS1j1dbvGRf1kbktgI2dvPfdEhsCjU1RD1xa5W53FoKHJ5IHZ/gyDgLUg/mPvSj/8JdQvYjBMU+87IEeZ8n2jCAM4nqPlTs1CI5hY2SKkQ7sdYYk+lmMBSB6AOPW3gZRexQB7FE80zo/J8D1OkG1oJA1wigkbkbtoeu7SSJTOk29SimmluDezfb1atcUHwqCZz4F9XEfSbOmIUwyjugUQ+2TtTubTT/CiPk97v7gh2v+957OJdsUsStJiJf/gLOhXF8o+oDEnA+uVkpkZnHuxNWXA2+UWZq4RBvUsPyRKG053tNDRHiVWzo0olukW0Z3VZsjhOJxDoeey1a8aDvSvWUIs9tUkauhJBB0QxeoNZJUdmwTmWRMp/mC9oLiha38CIy7nswwLoOuIKKWj5DD6+qobt4/XAfK3D4LUlNhKLGrO2ShhqpAgqv29a2YOTDYYCXKiCmEFxpEuIUizYYiZKZx/Xmik4ayIM8ijqk9IiqNrDagcaVKMkrhak1mjvQVEpw+IB1gD38jAVuSKrT+YbLiHrd+bjN6exkWoTaL+Wuy0WRGTo0hqESzHtFdFBXIyke/hRb99brBid/jDVqGkCSJBqwxF7ey3XW39fmgM2NEFirqHmu3WMK+OZl8rkTlm2GPNIxqrG3yb2rggQW9mIpGgLRgjb2/sCm0EC4nH03WWYJWrRE1m75oeE9FrH0JPdkMNkACv/g4VjitUEq+YhiNmsz/o9b8oKJdsz2YbCDD1gwbvMK+bpH0vHOM8+sA6Hykbh5rQU/RGsduC X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(396003)(136003)(376002)(186003)(83380400001)(66556008)(4326008)(66476007)(66946007)(31686004)(8676002)(36756003)(966005)(316002)(6916009)(53546011)(6506007)(86362001)(2616005)(26005)(6512007)(478600001)(6486002)(8936002)(5660300002)(31696002)(2906002)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0VNbU5JcFlJY1Fhc1hrcVQzMkZkbHZmeVczdkVxVUlWTHpHZWdzdEpvbmlO?= =?utf-8?B?MXAyNnZzS1ZjaFlLWllYbW9BVzlSNUVvaVptTjVvNmJQcDhxNCtxQ2JwQ2Jn?= =?utf-8?B?SjNkd1dsQnh3cFdMbyt6b0hUZVJ3b2FxTy82REJFa2o5ZEgyNng3MmVNYkRQ?= =?utf-8?B?aEt0a3Q1eGJmbnh6ZTJMcE03Z0hnbVNpaW94Z3JCV09UZUJRMCtwQ2tpV2Nj?= =?utf-8?B?cjU1SFFkT0ZTU2VvWEdzc0J6U25QWm1NV0V4bmFzQWpwc3JEQkpVRUo1UlNW?= =?utf-8?B?RmpsV1Vhc1JHc25jZVhrV2lqQ1V3ZXc2dTcrenN3aTFPSjBtblJyd2NsVktE?= =?utf-8?B?SC9LUU9YY0VNb3l0WU9Qbjk1bFRPeXdGeVR0eEdlZDA2S28zRHY2cmFCdC9I?= =?utf-8?B?VVVYZGVEWDNubVh4RDRrLzJFbVZSc2UxbkZDSWdBVDVtbVpqQVVIWEd3QVB0?= =?utf-8?B?UUlKS1RFeXFuaWJzYXVneGM4UGdhbm1OYy9FelRDVjBhWE5kbUxicHhMZjVm?= =?utf-8?B?SDY5eUUzRzVFeDE1Vm5CdFU3ekxyYnU1RXlJQWlNYkJEU2VlZjlHclRKemlW?= =?utf-8?B?R3VIUEtLS0orQjJVZzVRNDZtVHFvQU5JbWJFcFcrdDc4N2ozOXQxN09IajJi?= =?utf-8?B?SzVyOE1KM3N1S1cySjZUUTZoOW4za3NOTUQ3OTZhZ2ROeWdYb0tOOERJYTdM?= =?utf-8?B?bW9oak4wMUpGK1cyUFV6SjYyczVvQnBDNjRDc0VCYVpobmp1MjFCWmczaXd0?= =?utf-8?B?YzEzZHNaa3lJeHpSMk1tTEpKOHFPMHBlbDRhL0VxWlg2eEZKNGVrbG9mdTJ5?= =?utf-8?B?UGZvd2lvOFVHQTJQa1hRaitHdFVTQVdST3huN1RsSkJzbmV1bHhuaHJ0T3F5?= =?utf-8?B?anBsQ0p1a1l6QWJkUjB3bzlVcGY2YWJzL0tCWGRUcHZMN1YrUFM4eEVnSG5r?= =?utf-8?B?UUJCRWtyS1I0MlhQR1JQZ0FrQnY2ZExNSjR0aXNSMElVWEgzVlljeHducHlU?= =?utf-8?B?TnlMaXo2dnB2TXpwNEY3VXNRUUs2UmlNcmRQbzVzNFBJWmlJMlRRWkNkK1hV?= =?utf-8?B?bkp4Zkh5Uk9xMytjaHJsSm9XQXIzclpBNE12dnhWQWxtcFptQmZVSldmMUhV?= =?utf-8?B?NUVGbGRNRVowMU82cktMZHpMcldFclF2YUNGbmNXcWI4dXRyN3BlV1VUcnpK?= =?utf-8?B?WkFQWkEyZUVudkRpelc1NEZ5QlhPY2czRHRSSmRqaDg5KzNjOVlMWUJOVTd2?= =?utf-8?B?WFBSMk1nakFGakdtR295R0NyNGsrVnFiTU5kZVJpZjRDZlcyTTZYQ05zRXZk?= =?utf-8?B?anNxU2xaZGZwQkUvYWhMVTEvVW1DZGJRdy9ZUE94bXF2UitXSkJFeE95dTZH?= =?utf-8?B?VHpyS3hBRldiYUI5eXdUeDRML0cySTFEajdnS3M3UHRRSWR3MG9ZVVFFVkxX?= =?utf-8?B?ZmlrNkdyaGo4YlBwUkw1NzFTMWdodzd3c2x1U2J2dXhzWEZZNVFwYVZNYmNG?= =?utf-8?B?NE9HbW96MmNyVFNDZUFHS0hqVE5yV25zOVl5VFc1YUkzRGh6V2VnMlJwMkFL?= =?utf-8?B?Q2FpMGJhRjh2L0VPOVZESk9LZDJybm81THN3bU5UOTVzVnE2UTh1RkQya0Rl?= =?utf-8?B?dC9yaWRGMFdPK1Z6cEd2d3hvL1VKRlljUW50N2pYT3ZCNkJXQ3ZqN1Q5Q25z?= =?utf-8?B?WVJ0UnZ6Vi9wcXRkY0NwWXlFRWVpeWhnK3VZdEs2VGU0OUk2U0FUcjFRQ1pm?= =?utf-8?B?dmZ0ekFhaW85TmprK2JJYUtqWllsa0FtaStzY0J2dVpObCtvZDFISkNtL3F5?= =?utf-8?B?akpZOG1yVU5QYlh2bjFVUm52WXZYZ3hnZ1h2Nlp3SkFjRXJ4SDRZbGtQa0gr?= =?utf-8?B?TGxlaXhUYUtZK25LcDFkY3pXWjRtT3dteGVvQWIrQzBGSUF3VzdETEFwNGJM?= =?utf-8?B?RTlBL3BOaEVUWm43eGNISUdNOXNhNFZGdlcvV2xqamVFMUdDRDVxSURqNmsw?= =?utf-8?B?ZHVsd2R3RHNzcFhwTDZIMmRPY1lmOU1xQkpweDJWMWhPWG9MY3RrRW5UK0hP?= =?utf-8?B?eDZLd3lEdkpwL3FCckl2ZEQ1WUkrajBGKzJjK3AvOTZDMmVXMUs0SzdvdXY1?= =?utf-8?Q?0XSMwaChW/f/STiS7rQGC+DgT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d601995a-2fce-4bdf-0590-08da5f1d89b1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:02:49.6835 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ep+xLgZiaMXSrheY+ksXM3NL4o5iynAMZSzCg1l1t6C4nQU83zWRs2vdynDNr9eWyydV/Y70AiP4liWtfJv0Kw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6772 On 06.07.2022 08:56, Demi Marie Obenour wrote: >>> commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 >>> Author: Demi Marie Obenour >>> Date: Tue Jul 5 13:10:46 2022 +0200 >>> >>> EFI: preserve the System Resource Table for dom0 >>> >>> The EFI System Resource Table (ESRT) is necessary for fwupd to identify >>> firmware updates to install. According to the UEFI specification §23.4, >>> the ESRT shall be stored in memory of type EfiBootServicesData. However, >>> memory of type EfiBootServicesData is considered general-purpose memory >>> by Xen, so the ESRT needs to be moved somewhere where Xen will not >>> overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, >>> which Xen will not reuse. dom0 can use the ESRT if (and only if) it is >>> in memory of type EfiRuntimeServicesData. >>> >>> Earlier versions of this patch reserved the memory in which the ESRT was >>> located. This created awkward alignment problems, and required either >>> splitting the E820 table or wasting memory. It also would have required >>> a new platform op for dom0 to use to indicate if the ESRT is reserved. >>> By copying the ESRT into EfiRuntimeServicesData memory, the E820 table >>> does not need to be modified, and dom0 can just check the type of the >>> memory region containing the ESRT. The copy is only done if the ESRT is >>> not already in EfiRuntimeServicesData memory, avoiding memory leaks on >>> repeated kexec. >>> >>> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ >>> for details. >>> >>> Signed-off-by: Demi Marie Obenour >>> Reviewed-by: Jan Beulich >> >> ... this is the most likely candidate, considering in the log all we >> see is: >> >> Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirty) EFI loader >> Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' >> Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 >> Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 >> Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f >> Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. > > This would not surprise me at all. I was hoping that Jan would be able > to test this before he merged it, especially the ARM-specific stuff. Jan (i.e. me)? I've never done any testing on Arm; all I do is build-test things there. Also if you suspected there might be issues, I think you should have arranged for someone to test this, i.e. at the very least indicate so in a post-commit-message remark targeted at the eventual committer. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:10:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:10:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361817.591521 (Exim 4.92) (envelope-from ) id 1o8zBE-0000S2-Gd; Wed, 06 Jul 2022 07:10:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361817.591521; Wed, 06 Jul 2022 07:10:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zBE-0000Rv-DG; Wed, 06 Jul 2022 07:10:36 +0000 Received: by outflank-mailman (input) for mailman id 361817; Wed, 06 Jul 2022 07:10:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zBC-0000Rp-JF for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:10:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b9e5b9b8-fcfa-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:10:33 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4422.eurprd04.prod.outlook.com (2603:10a6:20b:24::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 07:10:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 07:10:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9e5b9b8-fcfa-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fx1oJqFt9za+wtjWZeK1kd9uNoRo21+Qi6eJuRSpRqV5JaEU5/jdXw0QP0FpATTRQ07PCN6NTCLHqh1ylQ7E8ybnUTu0TRDhAq+nrlfppSd19mceLum6TLUdHD1OAoOy+5srcV2l9UuekWH/PxVvUj1ZTynduF8tq6BNJHB5KkAP3Z9/xhM6lhB9GEhfJaCKfCpBksR6hlLfRLO1jq6Vy93qGVKhE2GkjROG4wLRTkcLaKcwlGHetbuU6AlNZ0DBaAKSkuXkpQjHadKwdqa4Sn6vKlh/BDnFWhwRb8kRR6RQz73MQ7heJ/j26evIYRNOM4NNYgFqiphtlSKEhPJMcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CD9/NiGIUt6EuxRGUHKkxxWTlFzw9ckhYkOJsrDL13g=; b=SRzKcSif/1GiE2FS86I8rolqgzHiIAevA7eefBIR5V3wwL9RM2P7HwAqeX6MGAHH/sqdV5kLokY4/P5d0qa4oBE13qWMyGAbjrNkOmhlYRUzwUhWAwMcbiVLTyWU5vdJjY9TYLCv9Fdpg2cXCZ0+tHvX+1TRK+kMphNnQR6Tlf/xmeeV2TWtjw5gu7XcFstuM142E9sLTUp+wiMuXGfs52zBtrIxv+K6wlWrhbifabYr+vNVvhP1pVwQnTOHhZK2VjV9rtjf889usu2vN7ruJrTzVoa9cXyypgIo/Wp9SLQ+Aun+wLpHnNc9ADhUgjLRw56KYIaCDrLhQxNcy/n3nA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CD9/NiGIUt6EuxRGUHKkxxWTlFzw9ckhYkOJsrDL13g=; b=JAI2Jkny9qxQ9/AQ/QkgOXVsWagB1H5sU6jT3wtMtU/FQ1V9OMkJ0awf/ek+x//qA72MolgfOZHUSnBkLNsqN/PMO/trUeACOC5DQpuEL1p6kRdNNad/Xn+YGIvrjDAxq+CnfFu0AneEAct7FByDYxRjWQhTQecCyJP58+GwGpY3x2MxCKqbrP1sqxmbcpIEs8iaENvwx3EypfWd+Oduj2MpISgqSUP8ajgT03AEk7VSlyQn9/agLwGS+rzgygibDSxbL76TSFS6VIYMjAIJSiIvH8jVBhRjJXVTASgifHkpPJ3DG2BYCK5L8Nbw4nzEVjWKYgiORY0mAZR5m47+yA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> Date: Wed, 6 Jul 2022 09:10:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220705210218.483854-4-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f5ea9ec-8902-4171-9f47-08da5f1e9a71 X-MS-TrafficTypeDiagnostic: AM6PR04MB4422:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l+4tXliv99ThtGzHgx9CTD4yM4e391FrPSGVzJm4Fbp3gFR/ReCHMZ4b8r2i8bNhlttET2MtnQTLVQ+HvjuzfpViWfBFSqKEDMwM29Zk7TdYkePu6ybHxjGamamJeKkG9rsPio7+Sq1Ye+k6myhkHroAu7IA0IECbNu6Fnf3wqm+5farL20VmvjCHONtp39ZH1ELCaZyZWDd274h9Of1rtuNs0CuNaC8pMQXpzA6Hu16vD5m0UnEXpRB3M4z8ZSEEexoW/kiqQBPaPCJ607sSSsdumjbBupnRWvNu1Dc7u7fmM5aZdIWOokJ1w0EM/09/FkJcI5Cki67ZmdMNH5O9ywgFFWYafsiJV3UColwUlG1C4OOkcEZ3rmz78JWzd1NRXf1X/+3X9W9bvXXp1SdE335HfX4M9HPUyx5KbX0psmxlvXH1WGetG2huBh8r/6WDXTnnTOIJOYbrg0jwnuc2zUtqo5JbdRHywwpiOQ3eydErOgmPgPH6JFGpFGy7DTCqGc4kCLnXp6yYfnhyG0a9ic6BvAuhwV2rhehMn8qBcoagsJkKQi2Lwh3YliwKPxTiXWmP6tKGJBiZ7wfuSiihTL8rwY9I7k/puyXjoPmjLkytbgoYT4ectPj4Ulzc5XF2qfwZUk2Mdxbn8jrbRGifIxHDS0k598U2ety0d0pZ/yn5W3EdugmbuUqhDB/m80KI5uriHt3e9gbJL0AxNQlacplGCI6q4zEjKh5qpIcrgiG2Nk6bmoqeV0evxqsB9nOVYrvqmq0fpp2OqyxzY86bz/nRvJ6GiK6wnqYzawGgnQJQHqCWrsWIyjbukyQT4YBVlpM4c6R/U38webt+xbMqgduE332s72zU0+N0C1Fk4I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(396003)(346002)(136003)(39860400002)(6486002)(86362001)(31696002)(38100700002)(41300700001)(2616005)(186003)(6512007)(26005)(478600001)(53546011)(31686004)(6506007)(83380400001)(66556008)(6916009)(54906003)(8936002)(4326008)(8676002)(5660300002)(36756003)(2906002)(66476007)(4744005)(316002)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3VzN1dyVm5LMWpnMHdkOE1BaDEzNlpkY1NJL2xVbXFKM2wzREFnZElZUWpO?= =?utf-8?B?RmlJVXlkalovZVNVRVlkWERNVE5yNXptelMzemZ6ajBnWDhWUzhyQ1Nkam1y?= =?utf-8?B?WHhQNEJZa1c5WTN3eXRzMTNrVTQvYkVOYy96eWJ0VE03eCtlS3UzM3hZdVYw?= =?utf-8?B?SHZKMkVnN1AxQy9tc1hnZkFqQ0RTNENNdDVBdktqRDRuRDdPWWZXSHM2c1hZ?= =?utf-8?B?dnhjNjA3ajdCMDVSWmp3S1l0YjAxWm5qYkxMQ2tXb2MzZzZFYmJPY2pBb0c2?= =?utf-8?B?WUM4MmNEaWFkQUR6M0VhOTcxbmZobEFXUW8vem1LV2pWOW96UVhWQUVpenk1?= =?utf-8?B?WGNuK081dk9NUmNwVGdJa2VGbVlsMG9kSVoyNXg5QUZaeXBNbjN4N1JHejBB?= =?utf-8?B?NVZidnpoemNTK3E0NVV0MVd5elNsV3pHQXIyNzlLVkdETll5THQzRlJIM2R5?= =?utf-8?B?aEo0Nkx1Zm1IVHdWYVRFVjlBZFlrU0FqemtKUTBoZzA4aTc1aDBueFJVYU5j?= =?utf-8?B?akJ2cWVyRHNlaUNsNDFDWms2TmdGWEZqalNoZlRaMzBlSjlxS1pDZk40WGlE?= =?utf-8?B?SHE0RnFydmd1akorU2xjUndvM3VlUVJoakV3Q2VoK0c4UFdBZi9qb0FSbWxn?= =?utf-8?B?aWdxZWgyRXNKbGhDQmJjd1JhNDRMdnFlQnhKdU9OUThwUmxkZ2lzTWJjT0Fs?= =?utf-8?B?czgyeWEzVEg2YmdrNkQ4bzhidVdFUzE3NExCb2lxeFV2SUlPdWVUK2h0aWdH?= =?utf-8?B?MGFWaFBXRXQvbENERFk4Y3JKOVI5YnBLSGUzNVV1MlNaZVUyQUtQeWdEUkdy?= =?utf-8?B?c0JDUEhBdmNWZ001Mm5RRTBWRnZ6M2lOeDVWUXBzTmpXcDd3ZGlYcGsyR2hw?= =?utf-8?B?enhKQXc0L05nU1A4cFV0bTg3cnhDcmhxOGZXNXpqaEFVb2xRbm5NdVI5Rjd2?= =?utf-8?B?eVVWeEJvQjJOdG9HZ01xSnFvb01XcWdKY1JmZm1hMU9iNzBnQWFpZ2xybjh3?= =?utf-8?B?TmYvK04xa3ZEYTVwZjdMWDBOZHE1OVdvU2Nuazl1Z2lQVDMwTFBjS1RMMnBv?= =?utf-8?B?bHRDOUNGWmpKRnQyRzRsTDVsOVZ4ZzRSN3ZsbUFoQ09pRS9nUUlzaWEvRkNa?= =?utf-8?B?SFhkK0VXY1JMTHhFeE9oKzduOWkxc29oV0FsMUgzMWM3dExWQWFIZURCWmhS?= =?utf-8?B?Z1lrRzBsNmNEVEpZa0pqejJzZis1bU1wYjRJUUtHb0hPZ2EyR3Y1aXlQMUxC?= =?utf-8?B?RDZySCtKNUlLRW5GYm93dFhCamRZTXUxRlgwY3ZIKzNuYVpsakp0ZW1sZUx4?= =?utf-8?B?L21BT200NjNUUnJMcEc0dGM4cUE1WXpVYUo0UE02SGtIZDFJam83UTh4dXgv?= =?utf-8?B?bHRERHB0Nmplb0MrelZzMW9xdmZ4dy9HWXBUaVFMa2prZDVQUVUrMlJuQWxO?= =?utf-8?B?NFJhSCtGcDhZRElHejhsTzlzOFpIa0R2a2JLWUxFbGlEdFFreUd5bFp6S0dx?= =?utf-8?B?cUtZY05xUmNLeG05SEhidjlSdmpPa0JMQWt1TGFGbDJVbmRob1dNQ0RjVldq?= =?utf-8?B?WStFcS82emV2VzJMRE1GUFgxazZuUzR6U3ViaXo3UzdFeXdVdmV2UXJMNytk?= =?utf-8?B?TGFWMEZXUUc0MEU1N2dnMGRvKzlvZHErbDJSUndmYkFPV2UrNGpYWExWMjBq?= =?utf-8?B?d0tKVWc3eW1SSUFITzNENkVmUGM4djhpTXRYblY2WGRKVHFJdjNPM2huS053?= =?utf-8?B?WWgzN3laMGYzZ3YzaHZYeXRtMlJVRnpyeW83czNkYTJYTElUV253NGczUDBW?= =?utf-8?B?TnZYQ1FPck56MGkxQTc1SkRjQSt3Qi9RcG9Cc2hHN2RubTBRZGxaMURMVi90?= =?utf-8?B?NDh6Q2FhT0xDUHRTQ3hMOHhBaHNDQW1DczRDc3E5Q21PNE96cjBXNTU5RW4v?= =?utf-8?B?NlR2T0JMdXZIWHl1aEtHbDZjdjN0OHZ5bnd4Ym54YXk4MU5RZFZ3Qkx4cm1Y?= =?utf-8?B?bUV1dUlKYjkyb0tPMGdWT01PK2tJZmgzQ3lJRXlONXI3OWp5RGMrbHVndW50?= =?utf-8?B?SjJZa2FqbEVqVXJnUGNhVjV2VFNXNFF2RlRQY1daK2xFWG41RTRvYU9DbHFR?= =?utf-8?Q?l3WecAd2/YfD2Uq1pJKKk5hAw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f5ea9ec-8902-4171-9f47-08da5f1e9a71 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:10:27.3016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iUf5ilCtP5SxQMBFKwiMdhue2M7agey1OCsIWtbaMEXc8SVHZM2Dskgfl2jBBRI2NGJ9AOl8I6qvxp1IJeFBuQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4422 On 05.07.2022 23:02, Xenia Ragiadakou wrote: > The function idle_loop() is referenced only in domain.c. > Change its linkage from external to internal by adding the storage-class > specifier static to its definitions. > > Since idle_loop() is referenced only in inline assembly, add the 'used' > attribute to suppress unused-function compiler warning. While I see that Julien has already acked the patch, I'd like to point out that using __used here is somewhat bogus. Imo the better approach is to properly make visible to the compiler that the symbol is used by the asm(), by adding a fake(?) input. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:18:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361824.591532 (Exim 4.92) (envelope-from ) id 1o8zIc-0001C8-DA; Wed, 06 Jul 2022 07:18:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361824.591532; Wed, 06 Jul 2022 07:18:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zIc-0001C1-9h; Wed, 06 Jul 2022 07:18:14 +0000 Received: by outflank-mailman (input) for mailman id 361824; Wed, 06 Jul 2022 07:18:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zIb-0001Bv-Jf for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:18:13 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140050.outbound.protection.outlook.com [40.107.14.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb588d55-fcfb-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:18:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7382.eurprd04.prod.outlook.com (2603:10a6:10:1ab::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 07:18:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 07:18:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb588d55-fcfb-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCkA3BppV1zOgZuhpOj8fF1VdlCZq0qWEJbdxh71UsUA5fxFSXZoeXKqBFDDoCDc/f1Z6zOl+TnPIk/ZUd5KdjAirhpJeV+I7dMC5DjfeV902KPCCh/Jnt+CyLHzXFpzBekt/rvabnmg/c+XeKqVV1LbFmZON63yoqSGXaRiniJjnbyI47sIKix1eE7SBAZHKjbJUqtTauH09Wn/XPxIHZZKJlGwJhcsymqkGMtYyLMDGHEvKTbt8OQhRE7U7echmSy3E2YsjeLMfi28jZ/srP/W0siTW3Id2wx4pM9u68l6zyQCZKSlgOoaPk3UNPQaUPHvNi/VKhZFuuljQamxJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3M6YCCVgKCUlDjov+0FNJ1IkfPOdPvSMb4x+W+yB22w=; b=KCKpQC1WxXbWG/seDyc1O0fR4+XwlumUvgYXr/tQK5Q+To1H7rnQ2/K0vvgmKE3ql8vR99tpvf2j+167vYyKAZjoeWErR48WKh/out+W3xOQDgljEa+P1eGgzzdtXh0GYmTiRMaPVXivYMwUP/6qcTYlWa+x63h20CTet92UOggUdyoauDnfBPFTfWVkqX0y5wvPR9bVUN96sWXlLk6GnHUikTzF1BnLxbeyASs1AEnLluODCocJuNC5B/lBx27coSDGOu3Gnigg5NSq8Ly49oCgPIOT/1LErgWDUdNtUyoO11mjTfh382z9MulorZusWx7i2V8vfOkMqQwtcXLh9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3M6YCCVgKCUlDjov+0FNJ1IkfPOdPvSMb4x+W+yB22w=; b=KyRMMB8igtjBFeG91iZvWtq2rcVQr0xr95i5dBnUq0J5Bkpsrrkm7pm+lUE2MpV7L9LfU3hq/Lqg4rFWS6J/ElZCs3RIw3i51zXF9dxHsP7c/SMVyeEZy5Oa5EbWVP3pgTYxd0jVqNHYEb6BHktEMfde/Bkx+kREDIwpMVOh00x45nAVJncLglkno1ghKrJ/O53IOpclAM9hz7YX63A9MGOsc2tOR7T3UN2NFN9aR8+RmyczSod9tW5VV07cHZjLFI3KM3WTdEQ7sBERrrctDFBguimx2HymfdQ1cZDonFvH2Q3/BksHDCOl9UNfeBRqkhL+7lMyEvk8TXAT3OL4Bw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <540e8f0d-8a1f-f80d-c6f2-05192600c4bd@suse.com> Date: Wed, 6 Jul 2022 09:18:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/4] xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-5-burzalodowa@gmail.com> <47ed7737-5422-e4be-c99d-0e448616f5b5@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 906ba17d-a1ab-4d12-3128-08da5f1fae09 X-MS-TrafficTypeDiagnostic: DBAPR04MB7382:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MsEtb8YzVTFWp7vOVEnyWSk4iOVNN4IWfMnZp+2SK3oVc2QDwu8Tq8FtrYBhDYvAY8WlRpz7zJvsKWlgklgC2qLBIeRVuzA1C3dtUAU+Ffw+zD1Eya4xQgMStzGDWPgGReOeQyC84nLi5L/xaW9KLLCX9R6NeFdNrEGPR4g2PuRznH9Ue2/A5MxA9meTAc6b7mWSvAMGrMQ88TImFqZ/sAdhNiADR4Rg3IiQ9pPxd8EYwQDFnp9XOENg0+Ebm3hUe6GPQ28i5IKlkKoMpnBf0d0EiCIWGHp+vvPcsoxGDM0oP3CXNk+wI/1WAM94OfsvMSJPzh//GTbXzxSFgnrZ53tlTl8192cGgQ10xDeCo/gopofIlzTwI9Va0k0IR9A6fiFe/tRtQcGZjuPqm6LCUUk/BoIO5fC0iTbm29JvOSuURHsB1MdQYNPfTeoguRuKrYMCM0rD9sBDf+2kMbKITUamV9kdL0ATib4VnZKTL64c/axbsIyUw1rANoy4R2wQKGPlE3SrjFb0KIBhmE44mHcDL1iXPDYBqM8GXEHP3j+IehgaVaycpoAmPXsYRY7O1aiuEMWPZwRv59Bx6OyIRqvHvrFoSKeBB/D6aoIdU3LSucWFc+Auc327+zoFub30K9MRPvsBARJNRtDloV5gP7Ddfn2jNc1kBw9MXMi3ICrW6pzH0pvwtBO3H0rU830SlkFNym8Xm9l4qTsHjqgLoj5bf22n7nvbIfzoq5ZKYUwFO73Abo3+485iHU5XSm+V41b4uambI/8k0laYi1PVz1cxYfC7BZ8wn80DFkTpBY5CXIRBED5MyRKa6uWP56RlmSp7YIFdNYUlPbfnSB9i6Zq8numczLdBvrJG3+qzqiw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(39860400002)(396003)(136003)(346002)(41300700001)(2906002)(2616005)(38100700002)(6916009)(54906003)(36756003)(31686004)(6512007)(316002)(53546011)(6506007)(66946007)(66556008)(8676002)(4326008)(478600001)(31696002)(86362001)(66476007)(186003)(83380400001)(26005)(6486002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWYzN0hEUVk5SFVTeWlpYzYvWU5QakplRXhyRm4rUC9EdTQ1RkdnVTI2VXYw?= =?utf-8?B?VDZ4R3ZtdnM5QTg1bGhYSldTVHQxK1l0ZUhxRjNlRVZJMXBMVDExaE5TbWxU?= =?utf-8?B?NXZFWHh2WnVvYWJNaFdOMm5CSDVHY1lhNjIvaGJPNis5clFtTXRXdUlLUFlI?= =?utf-8?B?Z3d5Y0FiS1MwTlJQQVBJN0gzenJCbDZXTGpWUXZOcjEzM24wUC85RTNuUFdI?= =?utf-8?B?SjNYdmc1VzhZZ1MxdHNBWVR1dXpFMzBwQmVmeVB4eUJmeExsZkJIM0pTRDNU?= =?utf-8?B?VWJkMDBpVSt2cisrVmc2YUtyRWZDT1F3eU45RE93bHJiM3NUTGl4OUh0ckla?= =?utf-8?B?MUZmNWxBckZkbUVScElSeG1GU3hTQ3I3bHZhMkxMOS9TUTZueTlXS1I1d0o2?= =?utf-8?B?ZUx1eEdRK3pFWVAreXl5K3RNWlhmTzUzVnNhZmNRMWdJZm85MWRUcXVET1FM?= =?utf-8?B?M3BJbXU1dWY1UzBreXNQRW80UFJzR2FkT2xIUjFYcmZNRXI4bm5lZCtWVXdQ?= =?utf-8?B?ZE5PZFlVdExudDcxRno1R0pQeCt5Sm9Oei9RMkE1VTVDdXh5TFhabFFMbnlV?= =?utf-8?B?NXExMWppM3ZZbEJWQjh2WloyUGNlcEhjN0hBQ0F6YlZReFJZSlZZdjVhWmJ3?= =?utf-8?B?ZHpCRVJSMExrTi9JQk1GaTNIRU9UbjJoZldGcEZnaWhhcmlHZXRPMWtHZjFR?= =?utf-8?B?SFpHUXNQSGRUWkhjNklsYnJ2M1FHaHNOM2hKMjNBeVBVR3N1TzBNK0FjV3Nq?= =?utf-8?B?R0x4ZkE3RTdySGNKZGd4dHdaN0xmWE9WdDVCSytGMWFjTitZVlppVG5jNlhy?= =?utf-8?B?bVg5cEJiU2tydVlUY3hPZ0lET1dQNjhhcUVtQjhrb3U2TUsvRmN0TUNIU3lL?= =?utf-8?B?aFlNeHZwOTg0RVZjWFdyVXZTdmR3d0NJTWZneUZZQnpGSEFIL2hncHprdkFI?= =?utf-8?B?VU04c2lFbytLMFZlK1pkeFVmeXB5aktFaG5BdHpFam0yZDh4NEQ4cyt4cVNy?= =?utf-8?B?SW5SOUcwVG9Ga21vZGpSRGtIYVVKczV5L2hYa1FFcC9UU2ltdjBsOXBoRjNJ?= =?utf-8?B?QmN2SjFQNVI5cXlhdzFmWUlKd3NOMUIyS2FZWFlxWVJ6QkhWbytKeXNQN0w4?= =?utf-8?B?Wmh3eWVESElNUG91TVl0QWl4c25ObzVNS3plSUFtYlNGdS9lYVdiQ0ROWVRG?= =?utf-8?B?WmIyWHN2WmFFSmhkZS9zdlU5eVVkNUtydVYvcXZibnBKZExYK3E1aWlRMWhx?= =?utf-8?B?Z3FzMDBTV2QyRnoyVXBmaVpCNmNjNXI3eEpZenpBZFF4QWdvaktaYklLYjJz?= =?utf-8?B?aHVudlczbU5yaTZXaUJtNlROL1hqM1l0bHNTOUdvTlZ2eHh1Mk1GcWtobmUx?= =?utf-8?B?Uk9pREVobUVlbmNMeHRwdSswVGZHWEJCdUw3RWZzejVySzAvYkhJL3BZSWdE?= =?utf-8?B?VWR0WjBPL3FhaU1BUDA4aUpRdE9yakZHRGttOUszMjhCZlZqM1k2ek5sMFZT?= =?utf-8?B?aUZjM3ovY29CVWN0WENRSXlrRWJpSnNyMmVnWnFxK0MwNnVjRXlMVmx4Z1Vn?= =?utf-8?B?Y1dBVlhaQm9pK0ZEbFAzZURqZjJRMS9JcmU4VHhvUStuNW1tYW1tSWhDSmRl?= =?utf-8?B?UTVKdTdzNVpaWlg4bVIyZ200M3NQc1dNM2FqdUdCQkY2REd2Wll4c29zajY1?= =?utf-8?B?V2RXaUoxc0M4OEUxVVU2WU5KQXhuNy9jUWN1WElXdmd6VHRXZzBFOU1rL3dW?= =?utf-8?B?bDhJTnRNcVkxSXo0SzQ1RWRBT3RFSXgxUkRXeEh4UmpWeW90YTcveDZrcnQ5?= =?utf-8?B?b2IxZSt0cVFPZWlUV3ZjR0h5V1RpR01vWUlXdlpOSE5yS1lET3NlMFEwbWxp?= =?utf-8?B?TG9yRVlUR3V1MlJxYlVYdUg1c1V2WGtPOHh3cE9zWHA4OWVyUDg2L0xrSW1x?= =?utf-8?B?U2xFWTNLc0hub0J2bVVBdDB4UUZqU2d1cXduVnRvcGZZcFpEMFZ4dVlFMnE1?= =?utf-8?B?eEtxYkt3cUdhT2pSd3RTRlpUVndjVUlTTVQ0MmJIUUZSa1NrYzJtQmxYYnV4?= =?utf-8?B?Y3NlaDF6M3dmeUVnZDZURERIMmFnY2lpY0FLVTNBY2FXTHp2UXRNZFRSamlX?= =?utf-8?Q?MPYysuLe5BJk7wff6Zl+eGFW8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 906ba17d-a1ab-4d12-3128-08da5f1fae09 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:18:09.6371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cTWRyqteN9PxRwZpySVbeD/ooeo3KBeLhx1bw5bEQJmacD649tHtHyLrDFI/q8jgYaNrS4cKvjtU0yEvHUZtRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7382 On 06.07.2022 00:02, Xenia Ragiadakou wrote: > Hi Julien, > > On 7/6/22 00:38, Julien Grall wrote: >> Hi Xenia, >> >> On 05/07/2022 22:02, Xenia Ragiadakou wrote: >>> The function pv_console_evtchn() is defined in the header >>> . >>> If the header happens to be included by multiple files, this can >>> result in >>> linker errors due to multiple definitions, >>> So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 >>> violation >>> warning by making pv_console_evtchn() inline with internal linkage. >> >> There are multiple version of pv_console_evtchn(). The version below is >> only used when !CONFIG_XEN_GUEST. >> >> The header is also included multiple time within Xen. So I am a bit >> puzzled why we haven't seen this error before. Maybe this is unused when >> !CONFIG_XEN_GUEST? >> >> If yes, I would remove the call. If no, then I think the commit message >> should be clarified. > > You are right. I had to clarify that this holds when !CONFIG_XEN_GUEST. > So when !CONFIG_XEN_GUEST, the function pv_console_evtchn() is defined > inside the header file and the header is included only by a single file. > This is why the error has not been triggered. Irrespective of that it is as Julien suspects: The function is only ever referenced when XEN_GUEST. Hence the better course of action indeed looks to be to ditch the unused stub; we don't even need DCE here for there to not be any references. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361832.591543 (Exim 4.92) (envelope-from ) id 1o8zU7-0003nw-HD; Wed, 06 Jul 2022 07:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361832.591543; Wed, 06 Jul 2022 07:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zU7-0003np-CW; Wed, 06 Jul 2022 07:30:07 +0000 Received: by outflank-mailman (input) for mailman id 361832; Wed, 06 Jul 2022 07:30:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zU5-0003d3-KW for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:06 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60043.outbound.protection.outlook.com [40.107.6.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7304e0e9-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:30:03 +0200 (CEST) Received: from AM6PR02CA0003.eurprd02.prod.outlook.com (2603:10a6:20b:6e::16) by GV2PR08MB8052.eurprd08.prod.outlook.com (2603:10a6:150:75::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 07:29:59 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::e3) by AM6PR02CA0003.outlook.office365.com (2603:10a6:20b:6e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:29:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:29:58 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Wed, 06 Jul 2022 07:29:58 +0000 Received: from 5380c76ba81e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A8920B0-9821-417B-BAF5-DBEA0022BDDC.1; Wed, 06 Jul 2022 07:29:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5380c76ba81e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:29:52 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB7163.eurprd08.prod.outlook.com (2603:10a6:10:2cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:29:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:29:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7304e0e9-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EcoAUtHdjiNgcG18HdnrMWkzdTWoeCPLzJFqZeOwCIk5mRMe2KtBB7NikKFRIDcBNMgbaObo1/xB3khVthSmjlWve+nsJ8YDHJ3X/rctEOodrevncnq2M8x3tTXtyuZOeKBYEkPNgVsScewRrALOimlWuHo7X0ENYVP4Cc2/Ab+UmBHB3fgjVsEJsMQUVnEt+7ghSq5ZTU2sglviVHcYtgj1bC21Aqxr5d/Y5VRNBPRWsz47ixR9B4RCTKkvCCvgzPgumOUz7mXpzKb367/arZSAzWyaojcatkA6y2Nq05NFIUU7X1t7lUJG6zMubnfMFogWdoRqHIkv6pRC4/zuOQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mb5KbdQ5rA/52jZXsR1wenHO2L2amUf1FObhgDImYPg=; b=VTDh2laBww8TyknkIUzL6HEEiDlam/+TCgUD1Sx7GxLB8mrtPXqO+LAplgEOzv+kyXi8wlNlx3gNSA2agfBNNS1VOogxKWsvz+ycTs9kEq1xHXcbuOpQcC/6z3BV9dEL2uM5/1owGHadDweLv/ETbLHh9k7Dtcauo3cs+gGlYIVVZh5GjY+HEaatWfDHlCpWNDA0a0v7qOVfin8lhrW99mJnX+/ETkdxThCv+A1LcYhomDcQSE5Kl4QEm278MJ26HtWSwAUgd3LH+A456wulNH9ieHyCxEMn050JtyffHx8RKyIOmyCJNQnn/9Rr8JKJdeiiFLYrgCv2GjimBAgBfw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mb5KbdQ5rA/52jZXsR1wenHO2L2amUf1FObhgDImYPg=; b=G4G4Rgr3a8QG04/YeTw/NDVbRBQzV8brybG2fqIgkHR/h+AGuFs012+tNZHGsafKAXgcCt0SRxQrydbg0pg8F5a8vRAHNywGHpD8DCEeFhiPx27G2e5GNMSOJ2Js3+OFh29kNXaV/EglcTHIxAhtlHLJ3zwtvVg5gUphQtTICvc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dOUmOD1iyalMtyCl7wacvbAIP+D3J+n5G3WXQtzw1tqwKKXLQ4zyQIJuTwyVH2gYH3xAUTaeYSYBquD3OyHUGg8yAdL69nqBIcHFGcKcocPq9F0bhLT7+dPjFl6eNAjGKx2NZLSN+uADxIiV+vJuxCQzedA00SLBoGae8hqkp+8kFhTJNksV8u8YqSvLWcBqMsxd6JX7dZswkuhK7BFATEGca2e93vdg1yQf+wtpQjdbekis8WZVu+p3vUgQSEyMAG/ERXVi3a8EScVZAh1df0WUIz9NzRIHeluwAaN3MuIWHT5UgbcVeYqonS5O65eg/eiMKML7vIC9bydqMRVNSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mb5KbdQ5rA/52jZXsR1wenHO2L2amUf1FObhgDImYPg=; b=KOLYgvJzosLRBSIx9a0tmaBqJwv0ae/Yfl70fcV0jUGUubTj9P9woP/tLdrRZA206gml2jNUBabOqxfvNPA0DgCJxbrLi0+CNRN6FLNBmoLuPP9q05T12jUzi6LM/44bUZrXn8quyiNWoZgAB667+bOJ1cW/ipwGypPgDSZA6kTxK+r0ieG67wVdmh/qY6JrIaEU8NcokhFlI/TU++9jMLqsDREFB2BvKX9mDKo8eS7RZlgt+F//mwDY0RVO6jH962NTNgf/ituxUKcq58HxsFO4SUoQKaoQ8Q4PhOeIDuuLbRfa6uymMKyvBy1nqktPRe9NjJt9vvreSsBlSEewvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mb5KbdQ5rA/52jZXsR1wenHO2L2amUf1FObhgDImYPg=; b=G4G4Rgr3a8QG04/YeTw/NDVbRBQzV8brybG2fqIgkHR/h+AGuFs012+tNZHGsafKAXgcCt0SRxQrydbg0pg8F5a8vRAHNywGHpD8DCEeFhiPx27G2e5GNMSOJ2Js3+OFh29kNXaV/EglcTHIxAhtlHLJ3zwtvVg5gUphQtTICvc= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , Wei Liu , Roger Pau Monne Subject: RE: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Thread-Topic: [PATCH 2/2] x86/cpuid: set MCDT_NO for non-affected models Thread-Index: AQHYZrVdmvwWiFDXRUaq3IIw27eoBK1xLw1A Date: Wed, 6 Jul 2022 07:29:50 +0000 Message-ID: References: <20220513103500.3671-1-roger.pau@citrix.com> <20220513103500.3671-3-roger.pau@citrix.com> In-Reply-To: <20220513103500.3671-3-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 63AEDF267BC8604A98C156A0A63C5860.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: abff89dc-6e14-4454-0158-08da5f2154df x-ms-traffictypediagnostic: DB9PR08MB7163:EE_|AM5EUR03FT047:EE_|GV2PR08MB8052:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: uH/xloRCbTVGQzlLnj5MUgCNx4OGKt08XNZgh0RIO93iqF17XhQf8ZO5STBRADUiZdqd1b86QB7qzk0RiPRkE+smiir0lrz9dRtSogbV8gitvqXmTM/DiUiykigpJGsR6l00DeB8mT9AYWhebpMOn1naT7GifcVpeMQdyPEBMuiF0cDVuC7O7lTCvUudHQ9M2s88VOGcdgyXflk05bx5/4CoNG9CMTlv2sS6I4i59kN4CxlLOIRdhHMSpQj8J8Zuqc21vaITS4OupPnQyJrzBwDaE2CbTTcwKtL+miqCW4URGfC+jlh4Uw2tFhAG3VTvfacqcS6lxT2zs6rQa5Gq+Wk+7uSxbr6dLX454CY7Pr59hC0WndmkJB4leuNsBDTnlEZD0Ltj7d4WuyXSeM7zENURGp2tNMBve8XfJbP2ffIUAUD6Ml97ePd5Z1QH9viV0ohw8mxX9+MVQJdGVwNi0jxzjVVtjToO4iwF/WoPw9E8d8l2Ts8cmQutDcVRdHsbMbnxtSxIYw/bfgelu276YKv3CIoO5NOAhiGfgzr9yL5iq++HvSAmIsFb4Z2d5+c0pBpX1KIqb6RW9xjbdVzpnDYeMQKcW6Vsxe1FboFxHX4yS4lCDJxb/L0dhJTWUN6jR8naCybgCCjQ+lTLRSt3PdwEVkRh34CPNb5oPBk558UADZK7ZTuEx3PtFNTD4il/IFrB8fVEQuEuXsSCzZeN9yS3sdJd8se5zS+3jKe9OqSJ0iURlnhJjz9d0MmNi+o5G0vMQvDGHvdY8n+es3jtfGXqxtgIOxzST0DJZEmapQ0Cc+YwWaUYeL/5nbX3/SlsFncuN7f2Kdq+iNwiFBVK4d0vRhD8qpag2uosGi6oDeg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(366004)(376002)(39860400002)(478600001)(38070700005)(122000001)(186003)(6506007)(7696005)(6916009)(316002)(54906003)(38100700002)(66946007)(8676002)(4326008)(33656002)(76116006)(66476007)(52536014)(71200400001)(66446008)(2906002)(64756008)(66556008)(26005)(9686003)(55016003)(5660300002)(8936002)(41300700001)(83380400001)(86362001)(170073001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7163 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f5ac5f6c-aea8-4b60-dfc4-08da5f214fe3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VaqGJT7oCA+8HFHRpmwIA0bdDLNls8FGUbADddLuhagr0UtFAGhJUuQBjvvN4L/MEJ465BrnOuUNW6OMtF0xA1Z1NifN/rcIOpqNnECiwMwKBsPcI8nY+0GGyGssJw/rZsi1pzXGx0CAq9H8kLBn4g68+zQpt8NEpOIBmGEoa1DvdxScEE1Q86jU0s8hfE480wn/pumMUM9w6QfRkDMTfpO0w1vC1LdM/To5iq+oks88+mJ/ULANKgGkFhfgHy2HaCVTM5bHaUs0518nGjidIYTrMvYxpKltpklkHUg9ezpzFCj+y1ebm2cGL757EZEUZTXeE+wYxrIIeKFxyh0duk36zpXdKWbTqlirSuQC+SLhq5IltcAE1xR65NLFmOUs1TrZNcd5/+BmjaIXelReVultwvzRVBfCWo51rVrEmnUIkguqO24bGrL1ES7bxzbFyb2xRDcqlREeuY36P+E4QBIDqLi+c/6BxUwVl7U2HHoLkudBGeyH2Fxmfu2KuXmrIo53+ItRc8/OAn4JI5rYmw7L6badwN2y72Pas9Z8SFO4ur93PkEc6+5oGqNswikMe6MNNfqwouPvBQrHSSuDX3mMpugSG3amwOUEqFAG16IRX9srQM4OuvQLV6Kc1ZNJEEy9WxpPBjN/o8xkBpQq1scxf5CgYNyUyGdayO6nooPkvSMM+tC58N7qF81Ne+zULNaGXQS+IAQcJRRAw9NLvro3j9O1ioIACoasuAvyCtGLlDs0pk92u8bbjjSdcj05Fc7uBHZ5dOeR4JueKgV66hOvHJ9jzK9z5ddgTkvUqDCX58vBobm5ChnrHois4SREa1OIlqdH5r17wV0Or0v6Ugae+w2O1gcK6/31oTsgvjg= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(46966006)(40470700004)(36840700001)(2906002)(6506007)(336012)(47076005)(52536014)(83380400001)(7696005)(81166007)(70586007)(41300700001)(186003)(8936002)(36860700001)(107886003)(5660300002)(316002)(478600001)(55016003)(70206006)(8676002)(40480700001)(82740400003)(356005)(33656002)(4326008)(9686003)(82310400005)(6916009)(26005)(86362001)(40460700003)(54906003)(170073001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:29:58.8025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: abff89dc-6e14-4454-0158-08da5f2154df X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB8052 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBwYXRjaCBoYXMgYmVlbiBzdGFsZSBmb3IgbmVhcmx5 IDIgbW9udGhzLCB3aXRoIHRoZQ0KZmlyc3QgcGF0Y2ggaW4gc2VyaWVzIGFscmVhZHkgbWVyZ2Vk IGFuZCBzb21lIGRpc2N1c3Npb25zIGJldHdlZW4NCm1haW50YWluZXJzIGFuZCBhdXRob3IgaW4g dGhlIFBhdGNoICMyIHRocmVhZC4gU28gSSBhbSBzZW5kaW5nIHRoaXMNCmVtYWlsIGFzIGEgZ2Vu dGxlIHJlbWluZGVyLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeSANCg0KPiAtLS0tLU9yaWdpbmFs IE1lc3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0ggMi8yXSB4ODYvY3B1aWQ6IHNldCBNQ0RU X05PIGZvciBub24tYWZmZWN0ZWQgbW9kZWxzDQo+IA0KPiBTb21lIENQVSBtb2RlbHMgZG9uJ3Qg ZXhoaWJpdCBNQ0RUIGJlaGF2aW9yLCBidXQgYWxzbyBkb24ndCBleHBvc2UNCj4gTUNEVF9OTy4g IFNldCB0aGUgTUNEVF9OTyBiaXQgZm9yIENQVXMga25vd24gdG8gbm90IGV4aGliaXQgdGhlDQo+ IGJlaGF2aW9yLCBzbyBndWVzdHMgY2FuIGdldCB0aGlzIGluZm9ybWF0aW9uLCBhcyB1c2luZw0K PiBmYW1pbHkvbW9kZWwvc3RlcHBpbmcgZGV0ZWN0aW9uIHdoZW4gcnVubmluZyB2aXJ0dWFsaXpl ZCBpcyBub3QgdG8gYmUNCj4gcmVsaWVkLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1 IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IC0tLQ0KPiAgeGVuL2FyY2gveDg2L2Nw dS9pbnRlbC5jIHwgNzANCj4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr Kw0KPiAgeGVuL2FyY2gveDg2L2NwdWlkLmMgICAgIHwgMTAgKysrKysrDQo+ICAyIGZpbGVzIGNo YW5nZWQsIDgwIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv Y3B1L2ludGVsLmMgYi94ZW4vYXJjaC94ODYvY3B1L2ludGVsLmMNCj4gaW5kZXggZGM2YTBjNzgw Ny4uZDgyMWY0NjBhZSAxMDA2NDQNCj4gLS0tIGEveGVuL2FyY2gveDg2L2NwdS9pbnRlbC5jDQo+ ICsrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvaW50ZWwuYw0KPiBAQCAtNTE4LDYgKzUxOCw3MyBAQCBz dGF0aWMgdm9pZCBpbnRlbF9sb2dfZnJlcShjb25zdCBzdHJ1Y3QgY3B1aW5mb194ODYNCj4gKmMp DQo+ICAgICAgcHJpbnRrKCIldSBNSHpcbiIsIChmYWN0b3IgKiBtYXhfcmF0aW8gKyA1MCkgLyAx MDApOw0KPiAgfQ0KPiANCj4gK3ZvaWQgdXBkYXRlX21jZHRfbm8oc3RydWN0IGNwdWluZm9feDg2 ICpjKQ0KPiArew0KPiArI2RlZmluZSBGQU02X01PREVMKG0sIHMsIGMpIHsgNiwgbSwgcywgYyB9 DQo+ICsgICAgLyoNCj4gKyAgICAgKiBMaXN0IG9mIG1vZGVscyB0aGF0IGRvIG5vdCBleGhpYml0 IE1DRFQgYmVoYXZpb3IsIGJ1dCBtaWdodCBub3QNCj4gKyAgICAgKiBhZHZlcnRpc2UgTUNEVF9O TyBvbiBDUFVJRC4NCj4gKyAgICAgKi8NCj4gKyAgICBzdGF0aWMgY29uc3Qgc3RydWN0IHsNCj4g KyAgICAgICAgdWludDhfdCBmYW1pbHk7DQo+ICsgICAgICAgIHVpbnQ4X3QgbW9kZWw7DQo+ICsg ICAgICAgIHVpbnQ4X3Qgc3RlcHBpbmc7DQo+ICsgICAgICAgIGJvb2wgY2hlY2tfc3RlcHBpbmc7 DQo+ICsgICAgfSBtY2R0X25vW10gPSB7DQo+ICsgICAgICAgIC8qIEhhc3dlbGwgU2VydmVyIEVQ LCBFUDRTLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4M2YsIDIsIHRydWUpLA0KPiArICAg ICAgICAvKiBFbGtoYXJ0IExha2UuICovDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHgzZiwgNCwg dHJ1ZSksDQo+ICsgICAgICAgIC8qIENoZXJyeXZpZXcuICovDQo+ICsgICAgICAgIEZBTTZfTU9E RUwoMHg0YywgMCwgZmFsc2UpLA0KPiArICAgICAgICAvKiBCcm9hZHdlbGwgU2VydmVyIEUsIEVQ LCBFUDRTLCBFWC4gKi8NCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDRmLCAwLCBmYWxzZSksDQo+ ICsgICAgICAgIC8qIEJyb2Fkd2VsbCBERSBWMiwgVjMuICovDQo+ICsgICAgICAgIEZBTTZfTU9E RUwoMHg1NiwgMywgdHJ1ZSksDQo+ICsgICAgICAgIC8qIEJyb2Fkd2VsbCBERSBZMC4gKi8NCj4g KyAgICAgICAgRkFNNl9NT0RFTCgweDU2LCA0LCB0cnVlKSwNCj4gKyAgICAgICAgLyogQnJvYWR3 ZWxsIERFIEExLCBIZXdpdHQgTGFrZS4gKi8NCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDU2LCA1 LCB0cnVlKSwNCj4gKyAgICAgICAgLyogQW5uaWVkYWxlLiAqLw0KPiArICAgICAgICBGQU02X01P REVMKDB4NWEsIDAsIGZhbHNlKSwNCj4gKyAgICAgICAgLyogQXBvbGxvIExha2UuICovDQo+ICsg ICAgICAgIEZBTTZfTU9ERUwoMHg1YywgOSwgdHJ1ZSksDQo+ICsgICAgICAgIEZBTTZfTU9ERUwo MHg1YywgMHhhLCB0cnVlKSwNCj4gKyAgICAgICAgLyogRGVudmVydG9uLiAqLw0KPiArICAgICAg ICBGQU02X01PREVMKDB4NWYsIDEsIHRydWUpLA0KPiArICAgICAgICAvKiBYTU03MjcyLiAqLw0K PiArICAgICAgICBGQU02X01PREVMKDB4NjUsIDAsIGZhbHNlKSwNCj4gKyAgICAgICAgLyogQ291 Z2FyIE1vdW50YWluLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4NmUsIDAsIGZhbHNlKSwN Cj4gKyAgICAgICAgLyogQnV0dGVyLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4NzUsIDAs IGZhbHNlKSwNCj4gKyAgICAgICAgLyogR2VtaW5pIExha2UuICovDQo+ICsgICAgICAgIEZBTTZf TU9ERUwoMHg3YSwgMSwgdHJ1ZSksDQo+ICsgICAgICAgIEZBTTZfTU9ERUwoMHg3YSwgOCwgdHJ1 ZSksDQo+ICsgICAgICAgIC8qIFNub3dyaWRnZS4gKi8NCj4gKyAgICAgICAgRkFNNl9NT0RFTCgw eDg2LCA0LCB0cnVlKSwNCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDg2LCA1LCB0cnVlKSwNCj4g KyAgICAgICAgRkFNNl9NT0RFTCgweDg2LCA3LCB0cnVlKSwNCj4gKyAgICAgICAgLyogTGFrZWZp ZWxkIEItc3RlcC4gKi8NCj4gKyAgICAgICAgRkFNNl9NT0RFTCgweDhhLCAxLCB0cnVlKSwNCj4g KyAgICAgICAgLyogRWxraGFydCBMYWtlLiAqLw0KPiArICAgICAgICBGQU02X01PREVMKDB4OTYs IDEsIHRydWUpLA0KPiArICAgICAgICAvKiBKYXNwZXIgTGFrZS4gKi8NCj4gKyAgICAgICAgRkFN Nl9NT0RFTCgweDljLCAwLCB0cnVlKSwNCj4gKyAgICAgICAgeyB9DQo+ICsgICAgfTsNCj4gKyN1 bmRlZiBGQU02X01PREVMDQo+ICsgICAgY29uc3QgdHlwZW9mKG1jZHRfbm9bMF0pICptOw0KPiAr DQo+ICsgICAgZm9yIChtID0gbWNkdF9ubzsgbS0+ZmFtaWx5IHwgbS0+bW9kZWwgfCBtLT5zdGVw cGluZzsgbSsrKQ0KPiArICAgICAgICBpZiAoIGMtPng4NiA9PSBtLT5mYW1pbHkgJiYgYy0+eDg2 X21vZGVsID09IG0tPm1vZGVsICYmDQo+ICsgICAgICAgICAgICAgKCFtLT5jaGVja19zdGVwcGlu ZyB8fCBjLT54ODZfbWFzayA9PSBtLT5zdGVwcGluZykgKQ0KPiArICAgICAgICB7DQo+ICsgICAg ICAgICAgICBfX3NldF9iaXQoWDg2X0ZFQVRVUkVfTUNEVF9OTywgYy0+eDg2X2NhcGFiaWxpdHkp Ow0KPiArICAgICAgICAgICAgYnJlYWs7DQo+ICsgICAgICAgIH0NCj4gK30NCj4gKw0KPiAgc3Rh dGljIHZvaWQgY2ZfY2hlY2sgaW5pdF9pbnRlbChzdHJ1Y3QgY3B1aW5mb194ODYgKmMpDQo+ICB7 DQo+ICAJLyogRGV0ZWN0IHRoZSBleHRlbmRlZCB0b3BvbG9neSBpbmZvcm1hdGlvbiBpZiBhdmFp bGFibGUgKi8NCj4gQEAgLTU1Niw2ICs2MjMsOSBAQCBzdGF0aWMgdm9pZCBjZl9jaGVjayBpbml0 X2ludGVsKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykNCj4gIAlpZiAoKG9wdF9jcHVfaW5mbyAmJiAh KGMtPmFwaWNpZCAmIChjLT54ODZfbnVtX3NpYmxpbmdzIC0gMSkpKSB8fA0KPiAgCSAgICBjID09 ICZib290X2NwdV9kYXRhICkNCj4gIAkJaW50ZWxfbG9nX2ZyZXEoYyk7DQo+ICsNCj4gKwlpZiAo IWNwdV9oYXMoYywgWDg2X0ZFQVRVUkVfTUNEVF9OTykpDQo+ICsJCXVwZGF0ZV9tY2R0X25vKGMp Ow0KPiAgfQ0KPiANCj4gIGNvbnN0IHN0cnVjdCBjcHVfZGV2IGludGVsX2NwdV9kZXYgPSB7DQo+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvY3B1aWQuYyBiL3hlbi9hcmNoL3g4Ni9jcHVpZC5j DQo+IGluZGV4IDY2YmUxYTgwMTUuLmNhMmVkNDQxNDkgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNo L3g4Ni9jcHVpZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9jcHVpZC5jDQo+IEBAIC0zNjAsNiAr MzYwLDE2IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBjYWxjdWxhdGVfaG9zdF9wb2xpY3kodm9pZCkN Cj4gDQo+ICAgICAgcC0+YmFzaWMubWF4X2xlYWYgPQ0KPiAgICAgICAgICBtaW5fdCh1aW50MzJf dCwgcC0+YmFzaWMubWF4X2xlYWYsICAgQVJSQVlfU0laRShwLT5iYXNpYy5yYXcpIC0gMSk7DQo+ ICsNCj4gKyAgICAvKg0KPiArICAgICAqIEZvciBJbnRlbCBoYXJkd2FyZSBNQ0RUX05PIG1pZ2h0 IGJlIHNldCBieSBYZW4gZm9yIG1vZGVscyB0aGF0IGRvbid0DQo+ICsgICAgICogZXhoaWJpdCBN Q0RUIGJlaGF2aW9yIGJ1dCBhbHNvIGRvbid0IGhhdmUgdGhlIE1DRFRfTk8gYml0IHNldCBpbg0K PiArICAgICAqIENQVUlELiAgRXh0ZW5kIGZlYXQubWF4X3N1YmxlYWYgYmV5b25kIHdoYXQgaGFy ZHdhcmUgc3VwcG9ydHMgdG8NCj4gaW5jbHVkZQ0KPiArICAgICAqIHRoZSBmZWF0dXJlIGxlYWYg Y29udGFpbmluZyB0aGlzIGluZm9ybWF0aW9uLg0KPiArICAgICAqLw0KPiArICAgIGlmICggYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX01DRFRfTk8pICkNCj4gKyAgICAgICAgcC0+ZmVhdC5tYXhf c3VibGVhZiA9IG1heChwLT5mZWF0Lm1heF9zdWJsZWFmLCAydSk7DQo+ICsNCj4gICAgICBwLT5m ZWF0Lm1heF9zdWJsZWFmID0NCj4gICAgICAgICAgbWluX3QodWludDMyX3QsIHAtPmZlYXQubWF4 X3N1YmxlYWYsIEFSUkFZX1NJWkUocC0+ZmVhdC5yYXcpIC0gMSk7DQo+IA0KPiAtLQ0KPiAyLjM2 LjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361833.591554 (Exim 4.92) (envelope-from ) id 1o8zUK-00047Y-VE; Wed, 06 Jul 2022 07:30:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361833.591554; Wed, 06 Jul 2022 07:30:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUK-00047R-SP; Wed, 06 Jul 2022 07:30:20 +0000 Received: by outflank-mailman (input) for mailman id 361833; Wed, 06 Jul 2022 07:30:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUJ-0003d3-B0 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:19 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c31da45-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:30:18 +0200 (CEST) Received: from AM7PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:20b:130::27) by PAXPR08MB6477.eurprd08.prod.outlook.com (2603:10a6:102:12d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:16 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::f1) by AM7PR03CA0017.outlook.office365.com (2603:10a6:20b:130::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:14 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 06 Jul 2022 07:30:14 +0000 Received: from c14f5919e9c7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F196410-044A-4253-BDEE-34195120CF45.1; Wed, 06 Jul 2022 07:30:08 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c14f5919e9c7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:08 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:01 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c31da45-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MWK6jOM5tnTPAt6peMwFKOKeIVM6/3QDN8/82kUD1T0kkicxPho9ORX9NYimsOLcQYikPvWhGXHR7FpOYUHhy+hmjOu1HNJnnVpseuvGhqLcbKgnfb6Kd8p1PRMbLNx5evQEqpNsdNFg/13e8oNvmRwpwUIrlX7BkPsVNtNEbHEehFJQWULmwx1jQ7XbPCDhIOl7VVIGjm38EezM965AJ+RdQFGAO0Cx+IHka80GfYpJHXKItmosKWCd9F+Dn4xWanlgH73X98X9cC87MbMBSt7mkGUUSuGQNf+QINw35ZGeT9zEDgEGmfG1gaKt5x97XN/fowTVeEx3rOMimdR3Dg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+SsFrAz8LFJzc6j3+sB7yowLQVnl4nJlI4MGGzCSIzc=; b=Cae0eGyeHRmY5iq5dicLhiVzt/Qhr++3OZEPbcxBqrPD4VAgOYChxZVj/DwpZAreWqZWn8Je/AakQT0lRpXjcWA/okDemv3tuEdmYjjfarbXDpM2q6t5n32eHCEco5dYufptGy+PiNFDnnteAew0gYiAALoIlXcSYSVG3hChICDnmeJ8Kh+eseEav6WoWOBrc+pZelsyGNqneT6exIolxBYapZyZMQtKPbgir359RTAWNOeBTAz/UWXg9KlKHNTZ4tYUpSLhwH9O+p+goCxke/50K5w3bmr62rgDZg0iFEut4h6+wHklLuRbYc3pVKpOnqWeVz5keUodqg70E8RVGw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SsFrAz8LFJzc6j3+sB7yowLQVnl4nJlI4MGGzCSIzc=; b=tCl45rFAG8x8uLUMTLrDtaL79z75v9NsWSWHOjpX06pb7m5gHmNsWjvNqiXk/UdNMhRb0OoshjPVVCzdgEKH36SyGz8NjS2WMtDWxXwDOFHs1+PvU4cXHVfI8YzjNsM0QvBtx2qiAMyalCRAJyn9EAPmSL+hpLGSG7kNeAzbN9k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PbTvLI1q4JRb4M1tcBBhRwBr6M6wJ0nZJ45utpjFqioelJao6QRKfRx90r4RAellCi1uU/PvdVZ1wA8KGxPDiF10G24cpHL/KeelYCABSlKslpUe5FvBCr577RxduTOOLV+2QkHIEU1uaZp2LyE/DkhrOGemB8FSIrXod9v4BKpVn4S7Img77MGAvSLd1iFLf2N0t8DqubuE4oaOr4/xAs2G99i3Lg2nwDe8hZTosh7RbRvbvq0y6Dhomxx/JXlapI/66HSqYDlGx06ARUj/01e1YbAKtQ3ENVkT+5j793JjZHHGB1/qwkkF9YqfOlrwjTEbXWKoSrFB1NOXS1FWjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+SsFrAz8LFJzc6j3+sB7yowLQVnl4nJlI4MGGzCSIzc=; b=l9Sg4BZ36gNudDsr8ewXi/cqQkGmtqL+QhYblVbmHiYrgQ3zNd5CcA9oUKDMcJ/w14zfWZ44g+caP0CRlRRlu57VkPqQK53klanmt2MuOVuONWna/UfNrxl1c1/qleGMAmmsHWp/1XpM1gVqjCyuFQJ/T8AWyz1NjLJJAqdG+slHj/+9nZcx+015tLex+q9SgTbgrBH/QiofhnVW4djATzlAlNYrkm9xjBYLPYjMFHYNoY+Mt1NPeTx8R4avly39hzT+kEw2jyx5z0CmuKJm7jE3h9JNMfq3LC618XJukG8emddCWXvevz+Y2K8E/NDxsi9muILbqi2W95zvt4mA4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+SsFrAz8LFJzc6j3+sB7yowLQVnl4nJlI4MGGzCSIzc=; b=tCl45rFAG8x8uLUMTLrDtaL79z75v9NsWSWHOjpX06pb7m5gHmNsWjvNqiXk/UdNMhRb0OoshjPVVCzdgEKH36SyGz8NjS2WMtDWxXwDOFHs1+PvU4cXHVfI8YzjNsM0QvBtx2qiAMyalCRAJyn9EAPmSL+hpLGSG7kNeAzbN9k= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH] build/xen: fix symbol generation with LLVM LD Thread-Topic: [PATCH] build/xen: fix symbol generation with LLVM LD Thread-Index: AQHYYIullYwWquPok065ghlly9/2gK1xPR9A Date: Wed, 6 Jul 2022 07:30:01 +0000 Message-ID: References: <20220505142137.51306-1-roger.pau@citrix.com> In-Reply-To: <20220505142137.51306-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 29B218515032DC48ABC490A3FB8DC3E2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a5268200-5f71-4553-bf2a-08da5f215e30 x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|AM5EUR03FT013:EE_|PAXPR08MB6477:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 78XUTiSUmNmZGEd/K6oTPam4uQxBp8znm2+RIfheoxwL9aT4i1zLwA6QDrMrcX7E4xZtp0CuIYk5eR9QFUeel/NbCAqzDvjJNtf4s3bUScBetB/r6U2UsPtrNlfKsosKJUsFgOzQVBkVBPfY60+Xt0o8N67FyXKJ5QgJ3cDnTL1sev0lfw32PqWD9v8M7PSB7a2ROKnbnFPfN1mYgjcntFpxJOQTDlk8W0DqN10h0Tb1F6FlR8jmshRcSII58iZjjA0hW6qAwZ8GyF3IRSlg+HARWRm7rfm1K3/9doOhQ/ZLJPLF7R2epaYh7Q0+xYYhZGegqILEzPMNMw61KzNSmx0B0iU9DZnA1hgbv3YELov05RXjt0tCC0vZiyRjtx5i+4+rZgo/fiilQRLZLMnNwcs2zey1iOUNRhdprUVMA9Dxo8ALr7ZbuWdD6hHSl4Qg+vNyP2qeB3XznVNGstlTLY0vy9GA5B/mgwJt4SX0onBbLsnLRTGQ6an801i37O2JrLmdmpGMaRLYs+Uaz2ybohhWzjT9QRl8H1r3pXyMvPEpfYUpi+SCtVMgZiR10XJZrBohu6AuXJReJiY6+nB2h050kts0JRQdLpM0MEtRcwzFMm77mf8vbvCfAsF9xBypqrvFxzNUQDsUYY/Ee0rx4tMRMwF0/LifM2QYcCPvrXVI610/vJAxfXcvEYO2n8oKnWjVUisZzWXIWiiWdxHvMVrmoNXKPBUEUZFo0gne7djDLrzZLsxkznJpdd6E0ws9YDhJfp+UW51WbasqaQ07UVf77Zf2xMxExxleTqMNI1lm7Yx8wV6rDS1E/+CeDn8Q X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(6506007)(7696005)(86362001)(5660300002)(2906002)(38070700005)(66556008)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(71200400001)(54906003)(110136005)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7590f088-ad98-4173-8220-08da5f215634 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0Ztupxqxwa/41Y/I/9r+zfQJsbGmVM/tlUO9MiTTj1+dhe72se3cLtXvbS6ILIok/4mnZ5RswWB3qWNRiQGUHkEuI5yxXPqhWn0CvMIdNJ0RVvF/kTjfH32Lms9Rl4n/GzChm2Sm4N3hHesRZ4K/5sCFHHe7fUsOhvqHIVM4a//9OqXIKyKEqmEK7yUtpIdn3b0rgUC0wXD0hSD0fgyyXtRr8LasQpc0JL+lTLzjON4chvszrdEWW938u9MjIiMit8KrlkK7M2reucOdO1ylLAzHfhXgtnheukiNe19YATXxtg2YVRO6GLzWHvoytgAIPHFnxOrIFxkQVMChm+oZdwJz6xZiiTyYUNHxeoKfTHvtRBIj/zMFhkpxWt15RykgSO9Ds0d3DPflc0AOo7B1QHROMW1ZR4UtuLj4f4y/V/1OPibzhzHSJ1TnH/3zWgZiEttw+rWzcasfGSVD+wTVdAfRDDnmB6657RxZb3z+baKF+Il96xevbLMtSZ50oImYeoTM4r3rEr8PY7uuz+6C4jmAvCidzZhxOS7iKbpMZejXIrzvKugikc5cyKlgsYXxpjhexfqBN+egCZk1rE6PgKSAS7rBowZ1cy/Lf10kJvnPPhMBy5qGaKlxC1OO7TNBcags+zg4XBckbR1FwgpoWBoNUc1VqM8ve1/VP2XAO/P4+VZnSwlLFNHPPQvkCztJIN/xQHr9bIS4TG3Gm3/6X27anXqrCNOteU3YZRPFDudXrV4sv2OzeTSvPG+df46Vqs8KFS5oJ/txdKAlVWz6yaERHpcaB0KavSNDNc0Eucmz4CeB9CkLJv+xptjvEsc7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(36840700001)(46966006)(40470700004)(110136005)(54906003)(316002)(40460700003)(40480700001)(55016003)(478600001)(86362001)(2906002)(81166007)(82740400003)(356005)(186003)(70206006)(70586007)(47076005)(4326008)(83380400001)(52536014)(36860700001)(8936002)(5660300002)(336012)(6506007)(7696005)(9686003)(8676002)(41300700001)(26005)(82310400005)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:14.4510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a5268200-5f71-4553-bf2a-08da5f215e30 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6477 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBwYXRjaCBoYXMgYmVlbiBzdGFsZSBmb3IgbW9yZSB0 aGFuIDIgbW9udGhzIGFuZCBmcm9tDQp0aGUgZGlzY3Vzc2lvbiBpbiB0aGlzIHRocmVhZCBJIHRo aW5rIHNvbWUgYWN0aW9ucyBuZWVkIHRvIGJlIHRha2VuIGZyb20gdGhlDQphdXRob3IuIFNvIEkg YW0gc2VuZGluZyB0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJlbWluZGVyLg0KDQpLaW5kIHJlZ2Fy ZHMsDQpIZW5yeQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQ QVRDSF0gYnVpbGQveGVuOiBmaXggc3ltYm9sIGdlbmVyYXRpb24gd2l0aCBMTFZNIExEDQo+IA0K PiBDdXJyZW50IExMVk0gTEQgaW1wbGVtZW50YXRpb24gd2lsbCB0dXJuIGdsb2JhbCBoaWRkZW4g c3ltYm9scyBpbg0KPiBvYmplY3QgZmlsZXMgaW50byBsb2NhbCBvbmVzIHdoZW4gZ2VuZXJhdGlu ZyB0aGUgLnN5bXRhYiBvZiB0aGUgWGVuDQo+IGJpbmFyeSBpbWFnZS4NCj4gDQo+IFRoaXMgaXMg ZGlmZmVyZW50IGZyb20gR05VIGxkIGltcGxlbWVudGF0aW9uLCB0aGF0IHdpbGwgb25seSBkbyB0 aGUNCj4gY29udmVyc2lvbiAob3IgcmVtb3ZlIHRoZSBzeW1ib2xzKSB3aGVuIGdlbmVyYXRpb24g LmR5bnN5bSBidXQgbm90DQo+IC5zeW10YWIuICBTdWNoIGNvbnZlcnNpb24gYnJlYWtzIHRoZSBw cm9jZXNzaW5nIG9mIHN5bWJvbHMgZG9uZSBieQ0KPiB0b29scy9zeW1ib2xzLg0KPiANCj4gVXNl IHByb3RlY3RlZCBzeW1ib2wgdmlzaWJpbGl0eSBpbnN0ZWFkIG9mIGhpZGRlbiwgYXMgdGhhdCBw cmVzZXJ2ZXMNCj4gdGhlIHN5bWJvbCBiaW5kaW5nIHdoaWxlIG5vdCBnZW5lcmF0aW5nIEdPVCBv ciBQTFQgaW5kaXJlY3Rpb25zIHRoYXQNCj4gYXJlIG5vdCBjb21wYXRpYmxlIHdpdGggc29tZSBv ZiB0aGUgaW5saW5lIGFzc2VtYmx5IGNvbnN0cnVjdHMNCj4gY3VycmVudGx5IHVzZWQuDQo+IA0K PiBXaGlsZSB0aGVyZSBhbHNvIG1ha2UgdGhlIHZpc2liaWxpdHkgc2V0dGluZyBjb21waWxlciBz dXBwb3J0DQo+IG5vbi1vcHRpb25hbDogY29tcGlsZXJzIG5vdCBzdXBwb3J0aW5nIGl0IHdvbid0 IGJlIGFibGUgdG8gYnVpbGQgWGVuDQo+IGFueXdheSwgYW5kIHdpbGwganVzdCB0aHJvdyBhIGNv bXBpbGVyIGVycm9yIHNvb25lciByYXRoZXIgdGhhbiBsYXRlcg0KPiBkdXJpbmcgdGhlIGJ1aWxk Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogUm9nZXIgUGF1IE1vbm7DqSA8cm9nZXIucGF1QGNpdHJp eC5jb20+DQo+IC0tLQ0KPiAgeGVuL0tjb25maWcgICAgICAgICAgICAgICAgfCA0IC0tLS0NCj4g IHhlbi9pbmNsdWRlL3hlbi9jb21waWxlci5oIHwgOSArKysrKy0tLS0NCj4gIDIgZmlsZXMgY2hh bmdlZCwgNSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L3hlbi9LY29uZmlnIGIveGVuL0tjb25maWcNCj4gaW5kZXggMTM0ZTZlNjhhZC4uYTkxODJmYjEz ZCAxMDA2NDQNCj4gLS0tIGEveGVuL0tjb25maWcNCj4gKysrIGIveGVuL0tjb25maWcNCj4gQEAg LTI5LDEwICsyOSw2IEBAIGNvbmZpZyBMRF9JU19HTlUNCj4gIGNvbmZpZyBMRF9JU19MTFZNDQo+ ICAJZGVmX2Jvb2wgJChzdWNjZXNzLCQoTEQpIC0tdmVyc2lvbiB8IGhlYWQgLW4gMSB8IGdyZXAg LXEgIl5MTEQiKQ0KPiANCj4gLSMgLWZ2aXNpYmlsaXR5PWhpZGRlbiByZWR1Y2VzIC1mcGljIGNv c3QsIGlmIGl0J3MgYXZhaWxhYmxlDQo+IC1jb25maWcgQ0NfSEFTX1ZJU0lCSUxJVFlfQVRUUklC VVRFDQo+IC0JZGVmX2Jvb2wgJChjYy1vcHRpb24sLWZ2aXNpYmlsaXR5PWhpZGRlbikNCj4gLQ0K PiAgIyBVc2UgLWZ7ZnVuY3Rpb24sZGF0YX0tc2VjdGlvbnMgY29tcGlsZXIgcGFyYW1ldGVycw0K PiAgY29uZmlnIENDX1NQTElUX1NFQ1RJT05TDQo+ICAJYm9vbA0KPiBkaWZmIC0tZ2l0IGEveGVu L2luY2x1ZGUveGVuL2NvbXBpbGVyLmggYi94ZW4vaW5jbHVkZS94ZW4vY29tcGlsZXIuaA0KPiBp bmRleCA5MzNhZWMwOWE5Li5jMTQ0YjE3MjE3IDEwMDY0NA0KPiAtLS0gYS94ZW4vaW5jbHVkZS94 ZW4vY29tcGlsZXIuaA0KPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vY29tcGlsZXIuaA0KPiBAQCAt MTI1LDEwICsxMjUsMTEgQEANCj4gICNkZWZpbmUgX19tdXN0X2JlX2FycmF5KGEpIFwNCj4gICAg QlVJTERfQlVHX09OX1pFUk8oX19idWlsdGluX3R5cGVzX2NvbXBhdGlibGVfcCh0eXBlb2YoYSks DQo+IHR5cGVvZigmYVswXSkpKQ0KPiANCj4gLSNpZmRlZiBDT05GSUdfQ0NfSEFTX1ZJU0lCSUxJ VFlfQVRUUklCVVRFDQo+IC0vKiBSZXN1bHRzIGluIG1vcmUgZWZmaWNpZW50IFBJQyBjb2RlIChu byBpbmRpcmVjdGlvbnMgdGhyb3VnaCBHT1Qgb3IgUExUKS4gKi8NCj4gLSNwcmFnbWEgR0NDIHZp c2liaWxpdHkgcHVzaChoaWRkZW4pDQo+IC0jZW5kaWYNCj4gKy8qDQo+ICsgKiBSZXN1bHRzIGlu IG1vcmUgZWZmaWNpZW50IFBJQyBjb2RlIChubyBpbmRpcmVjdGlvbnMgdGhyb3VnaCBHT1Qgb3Ig UExUKQ0KPiArICogYW5kIGlzIGFsc28gcmVxdWlyZWQgYnkgc29tZSBvZiB0aGUgYXNzZW1ibHkg Y29uc3RydWN0cy4NCj4gKyAqLw0KPiArI3ByYWdtYSBHQ0MgdmlzaWJpbGl0eSBwdXNoKHByb3Rl Y3RlZCkNCj4gDQo+ICAvKiBNYWtlIHRoZSBvcHRpbWl6ZXIgYmVsaWV2ZSB0aGUgdmFyaWFibGUg Y2FuIGJlIG1hbmlwdWxhdGVkIGFyYml0cmFyaWx5LiAqLw0KPiAgI2RlZmluZSBPUFRJTUlaRVJf SElERV9WQVIodmFyKSBfX2FzbV9fICggIiIgOiAiK2ciICh2YXIpICkNCj4gLS0NCj4gMi4zNi4w DQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361834.591565 (Exim 4.92) (envelope-from ) id 1o8zUR-0004RZ-71; Wed, 06 Jul 2022 07:30:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361834.591565; Wed, 06 Jul 2022 07:30:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUR-0004RS-3c; Wed, 06 Jul 2022 07:30:27 +0000 Received: by outflank-mailman (input) for mailman id 361834; Wed, 06 Jul 2022 07:30:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUP-0003d3-2d for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:25 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7fa5fc24-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:30:24 +0200 (CEST) Received: from DB6P18901CA0020.EURP189.PROD.OUTLOOK.COM (2603:10a6:4:16::30) by AM8PR08MB6420.eurprd08.prod.outlook.com (2603:10a6:20b:314::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 07:30:22 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:16:cafe::64) by DB6P18901CA0020.outlook.office365.com (2603:10a6:4:16::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:19 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 06 Jul 2022 07:30:19 +0000 Received: from b3bf4f5880d5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 450D59ED-2C3F-4988-858A-66354B4F0D0A.1; Wed, 06 Jul 2022 07:30:13 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b3bf4f5880d5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:13 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:11 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7fa5fc24-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K7JCNv8kjfDFqDB/FbrXx3QjZprpyktbPmp0D55zTEb1mLK3CcCfMmhmZIS7pdIubEuxCyo+IaXOZr0rG8wRFaiGR9T7KUN80qv2D1nnBqeGCKcFvCV3mY9IDT/LjooZiv4wuo9z0sT1fxV5Gr7o3jpx4bm55scQCwUny26zmkdgZvkXqM9dMlXVPqMLDCN8xBcY0JYafLPgxRqNrM6UgQ0F6J6gufQkGVtZq5/jp2SSqn4nq4cyx2zjrYq63dDgHCiIZgZSjkA5WP3SWQU64pqc+LbqYRlvemTze1nEv9Z/+YyaCc0LMnoy1EqZjiw4fxJnkyLAufVPhpa4zFffmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31xSZXbvdsibcVIceV39U3OFfJH3Dlf23IBPFbdbs58=; b=lyS2vpd2VgBPzWAgB9vSCU9zG5uR+Q6IO10cfHphwjx6WFuC56bFUCZJZab+uWXATNkZrgvd+xkxouSdf+rmRz7EpPC8ao1Sc9mDXRc9vHY62aV1cqV5/f1y849tG8XGlHAvCkfTsUhkTNWWf0WreVbVsYugHLps49+ScWzZ4DbHb4MHjHD7VFjVjWBxihkG5dpOysgLJ3+0pp1oWj6N1L2Bowh2udd+dVMN6CqrkAF29CbSRrGq1T7ExYWu/YA9iDTE6HZ0IHW5JT2lVGZiRymDQEvOEc5NwdLeI42oAFPJJ22zfq016QU2WZ6tc3zQvMRP6mSzGNv7tIO+d6d1ww== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31xSZXbvdsibcVIceV39U3OFfJH3Dlf23IBPFbdbs58=; b=8VEC20byYKg6mbo82+C/rLFXOL3C9AEjicIrh2+a/aYni0g/QhkzDG9j3PHkf+VrfQnLiOLJMiziW7g2L3wbjw05ns3FidpZVVyFmrCOypKEVm4rtxo+WXuMBOUTAHrG+AZon3waNEgFd9qIQQVoceb5Btv5wYNujteeBGVUYEQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ChHgcHmMM3HivrGoq8e+P0iHQ4RMiK+SdN0f/xcZADkGZeWX8kIaKUcVBYbkVZ2phSZXOI0Lx6lJwUkpewmh/Jcaux0JyuCxWAfT9dVYn4Q63zGoeCVZ4ue34Cs9gLrBHU5nES7JVlF2aBjFYISbOqp8jHENeI3SorK5qqvlVKd+sVt2Ew4r+NJHkzYl8X7mcroj9Lg0rVYtOcyAmSr4p9QqajwJioxgtYg5/CPabF/ShQD2VlFgXnAD+9AXk2xKvyaG0zOer7VmAbPeIUnwKCDiLIUaR+8cW2GhNX3rsXPbfvn5zOBc5NegsNehsCT02dWA/p7b01dxVmm1sRSe4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=31xSZXbvdsibcVIceV39U3OFfJH3Dlf23IBPFbdbs58=; b=S9RNykFbEc9sTf0Xtr1qkGhUd7V5de2WMnmQqGTHJGxBcMOvFs/uyNz9Jcpqh/bcPrbVrfaSsJedU74ObxuYAZSM7ZV/OKp4J9MTiypxVZbK9ltRELHi7jj6Q0HNhBuYbhEAVR2h9VseBSooulKpA10RvoWpCmmm1uV6FTBsu5V05UOq0U81rF3a6Zo39vxYERQsMcMNWs9xW5907IC72xg2T7lisjV1o9iYUN7uNXQIe6Ks25LNabaxSCYMFslrzfqCD8XxmX768/tpsH5VocTK5hEvIZPXNfmbZwYlULm5p57OgU8tbqiHum/jC9SGBC+CevTyWjVhZ8DFdQD8Zg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=31xSZXbvdsibcVIceV39U3OFfJH3Dlf23IBPFbdbs58=; b=8VEC20byYKg6mbo82+C/rLFXOL3C9AEjicIrh2+a/aYni0g/QhkzDG9j3PHkf+VrfQnLiOLJMiziW7g2L3wbjw05ns3FidpZVVyFmrCOypKEVm4rtxo+WXuMBOUTAHrG+AZon3waNEgFd9qIQQVoceb5Btv5wYNujteeBGVUYEQ= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , Wei Liu , Jun Nakajima , Roger Pau Monne , Kevin Tian Subject: RE: [PATCH 0/5] x86/lbr: handle lack of model-specific LBRs Thread-Topic: [PATCH 0/5] x86/lbr: handle lack of model-specific LBRs Thread-Index: AQHYbE8ENIrU0fzd30KB0FdsdC25cq1xLOqQ Date: Wed, 6 Jul 2022 07:30:11 +0000 Message-ID: References: <20220520133746.66142-1-roger.pau@citrix.com> In-Reply-To: <20220520133746.66142-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DF598EA93A31854096E91FE1C16CC599.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3543d3c5-ed98-438c-dd0b-08da5f216115 x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|DBAEUR03FT039:EE_|AM8PR08MB6420:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YdeQVu+CDUQRRIO7S3zCHXjH1d200S1xV4o995edR0diN8fLTvsRi2w5zVXxBVQ0D3nYs9Wbkb6ULv67wEZtc0/rob6nF4kciNxijbEWwKRYSK7jwVbGIj551KCojb8UDCCNhvzYBeiUkv+VAZ6UOPdujpcZwEnmfP9do9q2eBrR+eQv0/ppCochProEUanDB+ap3bU4ukjaXuUMQloJcajKsSsUd+yLWn5Zl2cqIA8rwcrOPVXLZDDykSuTp4pY4+rntwfZkoiR5U3OL2JDA6vFAB4jC+BcyZoNCHEiJ0xhwH2Vl9ly2e8ESlerNGBKFkgj3p089RMVJAnaJEJrA3cllH0L363YkGSb0aZbprB/1C3M9SPXZTEtSkRDi9XVvV7RZ9hxgWQrIzK4Xqg/9Zf+TxGAdpagyYM+EH9Z0wusluIrJH8aioMy53TrIcm0rEtP+U57qBQpGT1YNh0CBFGjXODaE16gkO/ZZ+b8B+0n2WFpKEB03oLUQXNIvpb9lLp/oaOlWjrBSms/pb6/qXXkWIxKhN+8Xsio5DZSWjaEmqc2wDi4eGx1i2RO8JFUn5i+s5mPEtAdiFSYI3Ns3zqBqy7WE30TQw5BGM52ubzN6ZY9nQyfCPRYA9jc+ykmcunekXtikt+skbtOzgn3QVg3CvXxaeEqKPhMfhzHNu+K/UjX/lhGXU4OtOQyLX9a0JvZCtCGcxc1oWAqgFyUrN5uxC7FVMhN52maY5uZyvu5Hl0exti92Ykpl6ZQNO9QeHZ9gdp8yTMzBn8333dZFq2fhV78OwnRxa2l2Q3v5zN6RckNtJlX1qLVj6NMVPbK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(6506007)(7696005)(86362001)(5660300002)(2906002)(38070700005)(66556008)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(71200400001)(54906003)(122000001)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 365b1f8f-4d3e-453e-1b85-08da5f215c75 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bVkFCvOoM3vCnMvlIoJvhXBysG0VeyRI4EQPtghpu0rY2ajFZ7gT/l3UdW/RBmHBthFh9w36hkIP85WyTpgm/yGMYDONw9HKagBjGIKtOTd6PGW0B00S9Tgt5EtpBI9hvm8XOYt3eOB0lyGH+U+wH0wti+a886RqOtILWLvIAuRuDWjAf4EnIUtvxY6vHxH3dkeeKCuwhJB3mf2qLVxC60eKHzxrnq9QIKqzDM2MaArn9xR9Q1NGTBwXRXs1Tq9LtUweKMa5cZU/DvlqIQ4sIRtsn3D7z3sZEq1izqyPfpaI7MLs67ZisKe6Wv9dZQVcA/YMIt/IGI1SQVwMnhTBPekF/6bSFraE9/gqRmuADxHFh570Voc2VRnlzqJkpnEGaLC0AZXQGAKZcr3mDRVq4TcCAxXxk4+JFZPyFbmrfKUzl1Uh38y8sQf3N1zfdyF3DbuJj1bh2D0NITuOzW+9aeM8MdBEOBrkkJy+r6fHb+qaLEYKAM8e4ISsqZ4TDbk19TUvnsQ2BOobAZIUu2WeNoXMcjNKbzu+yQ1Yy2kRo1vGPIzqVA8ZAY/nnqcXdikpaAFyXQdTVF5k6h3QfYvRgNkAHP8qldGqMqsiafmBCC8LK0TUbcPBzwYYKVdqbCl3GpYNbIeEXUeOOII0n/ZuKGKk41SSbI40ybsVrDzrCwTMvCjRcLoy4xkphpRaqExnNPveJC4PQ2HEFLwonh0+B78E4eM763mjntleRuAGYERw94j4EbXkniyUhbQeV7wDY1qpIjryu/DjYxgpw1DbieU3RDYo9rDla2cq8MxCZKHKDnjHA9dp7KRMXI7+1HBA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(36840700001)(40470700004)(26005)(40460700003)(7696005)(6506007)(9686003)(186003)(83380400001)(82740400003)(336012)(107886003)(478600001)(40480700001)(2906002)(33656002)(55016003)(4326008)(8676002)(70206006)(70586007)(54906003)(86362001)(82310400005)(41300700001)(8936002)(81166007)(52536014)(5660300002)(36860700001)(6916009)(47076005)(316002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:19.3572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3543d3c5-ed98-438c-dd0b-08da5f216115 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6420 SGksIA0KDQpJdCBzZWVtcyB0aGF0IHRoaXMgc2VyaWVzIGhhcyBiZWVuIHN0YWxlIGZvciBtb3Jl IHRoYW4gYSBtb250aCwgc28gSSBhbSBzZW5kaW5nDQp0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJl bWluZGVyIHdpdGggY3VycmVudCBzdGF0dXM6DQoNClBhdGNoICMyLCAjMyBtaWdodCBuZWVkIGZ1 cnRoZXIgYWN0aW9ucyBmcm9tIHRoZSBtYWludGFpbmVycw0KDQpQYXRjaCAjNCBtaWdodCBuZWVk IGZ1cnRoZXIgYWN0aW9ucyBmcm9tIHRoZSBhdXRob3IuDQoNClBhdGNoICMxICM1IGhhcyBiZWVu IHJldmlld2VkL2Fja2VkLg0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQQVRDSCAwLzVdIHg4Ni9sYnI6IGhhbmRsZSBs YWNrIG9mIG1vZGVsLXNwZWNpZmljIExCUnMNCj4gDQo+IEhlbGxvLA0KPiANCj4gSW50ZWwgU2Fw cGhpcmUgUmFwaWRzIENQVXMgZG9lc24ndCBoYXZlIG1vZGVsLXNwZWNpZmljIE1TUnMsIGFuZCBo ZW5jZQ0KPiBvbmx5IGFyY2hpdGVjdHVyYWwgTEJScyBhcmUgYXZhaWxhYmxlLg0KPiANCj4gRmly c3RseSBpbXBsZW1lbnQgc29tZSBjaGFuZ2VzIHNvIFhlbiBrbm93cyBob3cgdG8gZW5hYmxlIGFy Y2ggTEJScyBzbw0KPiB0aGF0IHRoZSBsZXIgb3B0aW9uIGNhbiBhbHNvIHdvcmsgaW4gc3VjaCBz Y2VuYXJpbyAoZmlyc3QgdHdvIHBhdGNoZXMpLg0KPiANCj4gVGhlIGxhY2sgb2YgbW9kZWwtc3Bl Y2lmaWMgTEJScyBhbHNvIGFmZmVjdHMgZ3Vlc3RzLCBhcyBzZXR0aW5nDQo+IERFQlVHQ1RMTVNS LkxCUiBpcyBub3cgaWdub3JlZCAodmFsdWUgaGFyZHdpcmVkIHRvIDAsIHdyaXRlcyBpZ25vcmVk KSBieQ0KPiB0aGUgaGFyZHdhcmUgZHVlIHRvIHRoZSBsYWNrIG9mIG1vZGVsLXNwZWNpZmljIExC UnMuICBUaGUgTEJSIGZvcm1hdA0KPiByZXBvcnRlZCBpbiBQRVJGX0NBUEFCSUxJVElFUyBhbHNv IG5lZWQgdG8gYmUgZXhwb3NlZCwgYXMgdGhhdCdzIGEgd2F5DQo+IGZvciBndWVzdHMgdG8gZGV0 ZWN0IGxhY2sgb2YgbW9kZWwtc3BlY2lmaWMgTEJScyBwcmVzZW5jZSAocGF0Y2hlcyAzDQo+IGFu ZCA0KS4NCj4gDQo+IFBhdGNoIDUgaXMgYW4gaW5kZW50YXRpb24gZml4IHRoYXQgY2FuIGJlIG1l cmdlZCBpbnRvIHBhdGNoIDQ6IGRvbmUNCj4gc2VwYXJhdGVseSB0byBoZWxwIHJlYWRhYmlsaXR5 IG9mIHBhdGNoIDQuDQo+IA0KPiBUaGFua3MsIFJvZ2VyLg0KPiANCj4gUm9nZXIgUGF1IE1vbm5l ICg1KToNCj4gICB4ODYvbGVyOiB1c2UgZmVhdHVyZSBmbGFnIHRvIGNoZWNrIGlmIG9wdGlvbiBp cyBlbmFibGVkDQo+ICAgeDg2L2xicjogZW5hYmxlIGh5cGVydmlzb3IgTEVSIHdpdGggYXJjaCBM QlINCj4gICB4ODYvcGVyZjogZXhwb3NlIExCUiBmb3JtYXQgaW4gUEVSRl9DQVBBQklMSVRJRVMN Cj4gICB4ODYvdm14OiBoYW5kbGUgbm8gbW9kZWwtc3BlY2lmaWMgTEJSIHByZXNlbmNlDQo+ICAg eDg2L3ZteDogZml4IGluZGVudGF0aW9uIG9mIExCUg0KPiANCj4gIHhlbi9hcmNoL3g4Ni9odm0v dm14L3ZteC5jICAgICAgICAgICAgICAgICAgfCA1OSArKysrKysrKysrKysrKy0tLS0tLS0NCj4g IHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tc3ItaW5kZXguaCAgICAgICAgfCAxOCArKysrKysr DQo+ICB4ZW4vYXJjaC94ODYvbXNyLmMgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDkgKysr Kw0KPiAgeGVuL2FyY2gveDg2L3RyYXBzLmMgICAgICAgICAgICAgICAgICAgICAgICB8IDI5ICsr KysrKysrLS0NCj4gIHhlbi9hcmNoL3g4Ni94ODZfNjQvdHJhcHMuYyAgICAgICAgICAgICAgICAg fCAgMiArLQ0KPiAgeGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVzZXQuaCB8 ICAzICstDQo+ICA2IGZpbGVzIGNoYW5nZWQsIDk3IGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9u cygtKQ0KPiANCj4gLS0NCj4gMi4zNi4wDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361836.591576 (Exim 4.92) (envelope-from ) id 1o8zUV-0004nh-Mp; Wed, 06 Jul 2022 07:30:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361836.591576; Wed, 06 Jul 2022 07:30:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUV-0004ma-I8; Wed, 06 Jul 2022 07:30:31 +0000 Received: by outflank-mailman (input) for mailman id 361836; Wed, 06 Jul 2022 07:30:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUU-0004kS-G3 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 824d763c-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:30:28 +0200 (CEST) Received: from DB7PR05CA0024.eurprd05.prod.outlook.com (2603:10a6:10:36::37) by AS4PR08MB7805.eurprd08.prod.outlook.com (2603:10a6:20b:518::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 07:30:26 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:36:cafe::4c) by DB7PR05CA0024.outlook.office365.com (2603:10a6:10:36::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:26 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 07:30:22 +0000 Received: from 2e3c473d5b9b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7F5B1429-CE04-42A0-BD26-EFCF42EF5F0A.1; Wed, 06 Jul 2022 07:30:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2e3c473d5b9b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:14 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 824d763c-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y0zGq8sAHJ2yvA22E3YRtsvPbXThvZNgs4RLrQuQczgILBsbam3FJ78aBdkeGlVxfS4ZtvSGfzAaA/OFMfXrl6mAOmhnxLLAI0Xv+XMy5g0C7tcUhvsZ7yeikJgn6mpOlkJ4U91IlNNxhmMVg6FJWfE55EysRe03L+aHudPE13aNj0dxvyc5AdPi41rKVyr6ugDXHH0gCfBPXkvsHk2T4r8kIUm03pvEawTH9ow1S4Jgu0kP7uZGt6ZVgENCmxcoCmnQ7E+vzYJi376FzjVLq3d5jmr44eiFMqBNzWBEZQtELYjdDrHQA2Ou/7QY2+FqrEsgyZROiAW3ekk3LrvOJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xUxwgRynfVWRyyO6V5Lw4277BR0PPP6KDUF6z3x4pMY=; b=YiWhVVdFzbstVYlWKPhhxiWq8qVwSoeus/uJJjGrwvKgfh5YPgIhIWzWaQcXD2kwURtHTvmIOE6ngcgSTVO4+YmXiE/zdGZtsqWDiK2QEy7eb7WP+QMHp9lO/bBjvDAtPu2nFAUmDxLof1oZobP4aUw+BOICdIOv4lYRbX8QdY3UDZNtqwcdR9im6xkL0ckJtDJ/SNhkBEy+yWgqkAkub+DoZwOvEUZZI4HrDcynRGAFYrxkN68qA0B2vDqoE0pht0QjQjzKYxTfnmeQRSpWvp7T8H6UtpSLOCQVmopxvjrFCpPV8+yMUYFkDuRNVluADSrl50i2TQBIgjUStYhaHA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUxwgRynfVWRyyO6V5Lw4277BR0PPP6KDUF6z3x4pMY=; b=tl0N4ZGDq+Ft50WFQIX4t8K3E1uzPbzodBqQVAFtrbj4YYQHAhxH6o0JS7/+1Uz3HAuqTYU41XJj99VSffLUfz/bumVnllXWdBVXvsVeCEi7Jq6liQcSiQBFQZ4rIJKs53kezP+sH8It0PfDnwItUewaDxFHJEc0Ium1q0q2e4w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XYQIerRdI8dnm8ma1hhtOwK2eU4OM8ygiklWGOQMpjsUYlQ7dbFHuCXVi+g3w9grA5MNsFpdFfRCzhHKOfovdv0+H/4S6reO08J4k3LNmNz+uDRzODAJEGLQF+ySp30cyGTEoG1sESoh+r8cWPF9GIy+ZWQHXVD9W1CAVb0yFpS9SGCsIeIIDBTHEqq2m5kU5z0IAjaCXUL/RV7XSskx552CD3yG5gOjtD4ujl/9Onw1RpdPVJ42NxsOt593EdpWI0YirHIU9gfKnV8qSMytesPUESIYTnSUIGXHFnj0ipFxTS3YsAFQBKHvPe3gz2W4JEhK6gExINJJDO3sSAafJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xUxwgRynfVWRyyO6V5Lw4277BR0PPP6KDUF6z3x4pMY=; b=eko2ZzTNQ9muOiDdnq5r/MwbQWi64yh68bANIp4dAq/h0YbcKft+nKvw7PF1wxdLz6bIunEzaodzU/EgXMz+FBN0J+Sf2ttwvonrvLVjjNbBA8atUYiRbbc9oVY/KmwykrpxWkG+muuYvUzQoxj4a78mULqLtufkbxGG7VILg0ZMJqVlGX55q110Rqt1HjLb7pTdqnYEtpcPQhJgrlba4rVdBqc5ABjYjRt4137JIi+QN9GhWWfe2xTf94rdL5+XoM1jaCm/X9XXCOHmii6kBDhHvDvD4gAQ/m1nLd08aSW0xJvFQ0SqxB8SOsgXOA/QfZYvsNrWMk2/KTA99bgGjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xUxwgRynfVWRyyO6V5Lw4277BR0PPP6KDUF6z3x4pMY=; b=tl0N4ZGDq+Ft50WFQIX4t8K3E1uzPbzodBqQVAFtrbj4YYQHAhxH6o0JS7/+1Uz3HAuqTYU41XJj99VSffLUfz/bumVnllXWdBVXvsVeCEi7Jq6liQcSiQBFQZ4rIJKs53kezP+sH8It0PfDnwItUewaDxFHJEc0Ium1q0q2e4w= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: Matias Ezequiel Vara Larsen , Andrew Cooper , Matias Ezequiel Vara Larsen , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [RFC PATCH] xen/docs: Document acquire resource interface Thread-Topic: [RFC PATCH] xen/docs: Document acquire resource interface Thread-Index: AQHYb2Bcb8YJXiCzsUWjw/st9fAs9q1xKIAQ Date: Wed, 6 Jul 2022 07:30:14 +0000 Message-ID: References: <324b2ea5b95ef5233202aa8eed2085c665259753.1653390261.git.matias.vara@vates.fr> In-Reply-To: <324b2ea5b95ef5233202aa8eed2085c665259753.1653390261.git.matias.vara@vates.fr> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B742414786C5DE46B53B18E613BCF0F5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9bab420d-55be-476b-9106-08da5f21654e x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|DBAEUR03FT024:EE_|AS4PR08MB7805:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kdpppQVgZC7kyiuC7h8nbP4XsQ3MIkFWx88d5V6c7bTe4FCuzE2m17i9sEmCYfFWzxI8SlLGuDve5Lqv9B4SY8pyESoBcVRTqLLxCPU4ghZZ/uzyDl9YaAb5ZAWP8BDJRWWsbm04V/MT4htfEsB25svQBVLufWuEQzWo25b4CsPnL2Jkmy3di/rmJ484+F3kHc6osTkdYJ+cjFmO/H/5993DECNyFGl80bK4UZiQqGpceuphKDOy7qk7Ygg2d64PXNKl9imhqleD/Ky+6DS5eRR02VOHZyG6CW0cJWO0deQMEV9z3EGAGso1q/M/vbwVEIVKXJJ6Kr1zgnATmseX1YerQIUhwcxplxT9SrXB67fyRZxR4NLIzxo10s6+J1a9z3NkV8aPJexH631qVKj5UVW5V+niVMsM6OJf4wU4k1sDAQeMFWYGWuiGkLucrJDdVRFs4QotmWhjcuCkV+cEDhze/nxEPsNdyUmn1IFM2rC4tn0frGlzj3ouEv/ZOFQweGXpiHYBcRchVtdX/fhWmPNg9+m57HceCnvv7m0uqXDMlkwIjCtdqB5RLuErejOc/+32dwNDyFG5OpVdZadMyjxK71mVwe7lBhwFDHjIrEbOLLvW7Hu2oJES0r8ePyKJkFsKbpArvfg4iD61IbSISO7M4e5/yYXff6rlUVhS5e1FDg6T1/MN6po35kd+ozIzgKUJ+pC+awzGRzqh5Szsu0ZxJhJccRZblxJr9obeFrbM/TkFjoyLJkgTVuP8ecu2VtYuAWD0DZkH5zUOdsaoutpIqyuHOFo8LgRQXg25uUURyODZ2amBf7DkdJ1u8m3SrofaBZhXrp/bPh9bFMvJXTPSKp7wFNZjHBoe9hJ7Vho= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(30864003)(6506007)(7696005)(86362001)(5660300002)(2906002)(38070700005)(66556008)(966005)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(71200400001)(54906003)(122000001)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 263e9cec-9442-4f95-4eaf-08da5f215e54 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VC49y8N3bVI1cnx2RUsxjmZfh0DmQBIOWxrKnIrKYQsIJvuk23dYMIRq8inDgnAvl4ke92QwD49n9fyFGyUMKxm0RFtSBljsif8NvHGHh7OvEhk19UN6xQlMUl7TkDa5XqSES8yV3brGVU0uqUnvk8SfxkSwNd0ovjTXgTFbkWhUwotKD0jufntqWlmPm0D1JLcmCzJsV2boHeM9ccj+vtVzXVPcMe5oCVRSi9if+9NQCGstAm1PGvrRD/Vo3oJQwR9iGWMTaf/EuJnFEBoGGlqQpgcKnkijpf5aYZpeWJkxtOFblM9ps3L4EbILkIbXYp3MUaZ7EnBaJhQkj0LKO0YVrP0TpbV3N+GnJld943vUzMdg3J64iatRBWflfH2/EupALm9506VfAxHccWlmnnv8XazgLrh8aAiDgxmSMAmtuqJ0EgVWaStgvZ492XTNYAuvpIfRk7seF+Gl1bMxS5j/I3QiYkANgLOsrFUg+jI37z1hFLpuSAeKsqiUiCRpp423KsBLgArmh9e1ilrtwA2489MEdEqjE7xPedGkn08qLFm+A30D1JsSSWZ2xxoBOKgMEL+4Rl0snekfQAA1Z1bCXwYWKGLfL1ogUiPFcAHyGbsZ5G7/1RVcNbV6gKNL51fjL/Mt1cuSNAzxV1dIDOyqK7RVrTcdVafyTUJxmilnalLKk5jhoUOeB9B1VWRpn4cM6H6EqJBjJIQ9KIFb0GrtM5AU1BoigvxrXw7Cy0in7c4AiMxVI89yWU8Lvy39qFz4f1jUEa2/3qG0BUhnukaeuQkUSKtP5ytjmExfb01kuPeeizJKDevOFLjlg4dmMovYYpnE6I9sjHPad998UtuSSbA50K6slH+Y3n0EiEs= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(40470700004)(36840700001)(46966006)(478600001)(966005)(2906002)(82310400005)(356005)(86362001)(316002)(8676002)(4326008)(52536014)(70206006)(70586007)(81166007)(82740400003)(36860700001)(40480700001)(40460700003)(6916009)(54906003)(8936002)(5660300002)(30864003)(55016003)(26005)(33656002)(41300700001)(9686003)(336012)(186003)(7696005)(47076005)(83380400001)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:26.4553 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bab420d-55be-476b-9106-08da5f21654e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7805 Hi, It seems that this patch has been stale for more than a month. From my understanding, it is closely related to [1] and feedbacks from maintainers are needed. So I am sending this email as a gentle reminder about that. Thanks! Kind regards, Henry=20 [1] https://patchwork.kernel.org/project/xen-devel/list/?series=3D642393 > -----Original Message----- > Subject: [RFC PATCH] xen/docs: Document acquire resource interface >=20 > This commit creates a new doc to document the acquire resource interface. > This > is a reference document. >=20 > Signed-off-by: Matias Ezequiel Vara Larsen > --- > RFC: The current document still contains TODOs. I am not really sure why > different resources are implemented differently. I would like to understa= nd it > better so I can document it and then easily build new resources. I struct= ured > the document in two sections but I am not sure if that is the right way t= o do > it. >=20 > --- > .../acquire_resource_reference.rst | 337 ++++++++++++++++++ > docs/hypervisor-guide/index.rst | 2 + > 2 files changed, 339 insertions(+) > create mode 100644 docs/hypervisor-guide/acquire_resource_reference.rst >=20 > diff --git a/docs/hypervisor-guide/acquire_resource_reference.rst > b/docs/hypervisor-guide/acquire_resource_reference.rst > new file mode 100644 > index 0000000000..a9944aae1d > --- /dev/null > +++ b/docs/hypervisor-guide/acquire_resource_reference.rst > @@ -0,0 +1,337 @@ > +.. SPDX-License-Identifier: CC-BY-4.0 > + > +Acquire resource reference > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D > + > +Acquire resource allows you to share a resource between a domain and a > dom0 pv > +tool. Resources are generally represented by pages that are mapped into > the pv > +tool memory space. These pages are accessed by Xen and they may or may > not be > +accessed by the DomU itself. This document describes the api to build pv > tools. > +The document also describes the software components required to create > and > +expose a domain's resource. This is not a tutorial or a how-to guide. It > merely > +describes the machinery that is already described in the code itself. > + > +.. warning:: > + > + The code in this document may already be out of date, however it may > + be enough to illustrate how the acquire resource interface works. > + > + > +PV tool API > +----------- > + > +This section describes the api to map a resource from a pv tool. The api= is > based > +on the following functions: > + > +* xenforeignmemory_open() > + > +* xenforeignmemory_resource_size() > + > +* xenforeignmemory_map_resource() > + > +* xenforeignmemory_unmap_resource() > + > +The ``xenforeignmemory_open()`` function gets the handler that is used b= y > the > +rest of the functions: > + > +.. code-block:: c > + > + fh =3D xenforeignmemory_open(NULL, 0); > + > +The ``xenforeignmemory_resource_size()`` function gets the size of the > resource. > +For example, in the following code, we get the size of the > +``XENMEM_RESOURCE_VMTRACE_BUF``: > + > +.. code-block:: c > + > + rc =3D xenforeignmemory_resource_size(fh, domid, > XENMEM_resource_vmtrace_buf, vcpu, &size); > + > +The size of the resource is returned in ``size`` in bytes. > + > +The ``xenforeignmemory_map_resource()`` function maps a domain's > resource. The > +function is declared as follows: > + > +.. code-block:: c > + > + xenforeignmemory_resource_handle > *xenforeignmemory_map_resource( > + xenforeignmemory_handle *fmem, domid_t domid, unsigned int type, > + unsigned int id, unsigned long frame, unsigned long nr_frames, > + void **paddr, int prot, int flags); > + > +The size of the resource is in number of frames. For example, **QEMU** > uses it > +to map the ioreq server between the domain and QEMU: > + > +.. code-block:: c > + > + fres =3D xenforeignmemory_map_resource(xen_fmem, xen_domid, > XENMEM_resource_ioreq_server, > + state->ioservid, 0, 2, &addr, PROT_READ | PROT_WRITE, 0); > + > + > +The third parameter corresponds with the resource that we request from > the > +domain, e.g., ``XENMEM_resource_ioreq_server``. The seventh parameter > returns a > +point-to-pointer to the address of the mapped resource. > + > +Finally, the ``xenforeignmemory_unmap_resource()`` function unmaps the > region: > + > +.. code-block:: c > + :caption: tools/misc/xen-vmtrace.c > + > + if ( fres && xenforeignmemory_unmap_resource(fh, fres) ) > + perror("xenforeignmemory_unmap_resource()"); > + > +Sharing a resource with a pv tool > +--------------------------------- > + > +In this section, we describe how to build a new resource and share it wi= th a > pv > +too. Resources are defined in ``xen/include/public/memory.h``. In Xen-4.= 16, > +there are three resources: > + > +.. code-block:: c > + :caption: xen/include/public/memory.h > + > + #define XENMEM_resource_ioreq_server 0 > + #define XENMEM_resource_grant_table 1 > + #define XENMEM_resource_vmtrace_buf 2 > + > +The ``resource_max_frames()`` function returns the size of a resource. T= he > +resource may provide a handler to get the size. This is the definition o= f the > +``resource_max_frame()`` function: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/memory.c > + > + static unsigned int resource_max_frames(const struct domain *d, > + unsigned int type, unsigned = int id) > + { > + switch ( type ) > + { > + case XENMEM_resource_grant_table: > + return gnttab_resource_max_frames(d, id); > + > + case XENMEM_resource_ioreq_server: > + return ioreq_server_max_frames(d); > + > + case XENMEM_resource_vmtrace_buf: > + return d->vmtrace_size >> PAGE_SHIFT; > + > + default: > + return -EOPNOTSUPP; > + } > + } > + > +The ``_acquire_resource()`` function invokes the corresponding handler t= hat > maps > +the resource. The handler relies on ``type`` to select the right handler= : > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/memory.c > + > + static int _acquire_resource( > + struct domain *d, unsigned int type, unsigned int id, unsigned i= nt frame, > + unsigned int nr_frames, xen_pfn_t mfn_list[]) > + { > + switch ( type ) > + { > + case XENMEM_resource_grant_table: > + return gnttab_acquire_resource(d, id, frame, nr_frames, mfn_= list); > + > + case XENMEM_resource_ioreq_server: > + return acquire_ioreq_server(d, id, frame, nr_frames, mfn_lis= t); > + > + case XENMEM_resource_vmtrace_buf: > + return acquire_vmtrace_buf(d, id, frame, nr_frames, mfn_list= ); > + > + default: > + return -EOPNOTSUPP; > + } > + } > + > +Note that if a new resource has to be added, these two functions need to= be > +modified. These handlers have the common declaration: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/memory.c > + > + static int acquire_vmtrace_buf( > + struct domain *d, unsigned int id, unsigned int frame, > + unsigned int nr_frames, xen_pfn_t mfn_list[]) > + { > + > +The function returns in ``mfn_list[]`` a number of ``nr_frames`` of poin= ters > to > +mfn pages. For example, for the ``XENMEM_resource_vmtrace_buf`` > resource, the > +handler is defined as follows: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/memory.c > + > + static int acquire_vmtrace_buf( > + struct domain *d, unsigned int id, unsigned int frame, > + unsigned int nr_frames, xen_pfn_t mfn_list[]) > + { > + const struct vcpu *v =3D domain_vcpu(d, id); > + unsigned int i; > + mfn_t mfn; > + > + if ( !v ) > + return -ENOENT; > + > + if ( !v->vmtrace.pg || > + (frame + nr_frames) > (d->vmtrace_size >> PAGE_SHIFT) ) > + return -EINVAL; > + > + mfn =3D page_to_mfn(v->vmtrace.pg); > + > + for ( i =3D 0; i < nr_frames; i++ ) > + mfn_list[i] =3D mfn_x(mfn) + frame + i; > + > + return nr_frames; > + } > + > +Note that the handler only returns the mfn pages that have been previous= ly > +allocated in ``vmtrace.pg``. The allocation of the resource happens duri= ng > the > +instantiation of the vcpu. A set of pages is allocated during the instan= tiation > +of each vcpu. For allocating the page, we use the domheap with the > +``MEMF_no_refcount`` flag: > + > +.. What do we require to set this flag? > + > +.. code-block:: c > + > + v->vmtrace.pg =3D alloc_domheap_page(s->target, MEMF_no_refcount); > + > +To access the pages in the context of Xen, we are required to map the pa= ge > by > +using: > + > +.. code-block:: c > + > + va_page =3D __map_domain_page_global(page); > + > +The ``va_page`` pointer is used in the context of Xen. The function that > +allocates the pages runs the following verification after allocation. Fo= r > +example, the following code is from ``vmtrace_alloc_buffer()`` that allo= cates > +the page for vmtrace for a given vcpu: > + > +.. Why is this verification required after allocation? > + > +.. code-block:: c > + > + for ( i =3D 0; i < (d->vmtrace_size >> PAGE_SHIFT); i++ ) > + if ( unlikely(!get_page_and_type(&pg[i], d, PGT_writable_page)) = ) > + /* > + * The domain can't possibly know about this page yet, so fa= ilure > + * here is a clear indication of something fishy going on. > + */ > + goto refcnt_err; > + > +The allocated pages are released by first using ``unmap_domheap_page()`` > and > +then using ``free_domheap_page()`` to finally release the page. Note tha= t > the > +releasing of these resources may vary depending on how there are > allocated. > + > +Acquire Resources > +----------------- > + > +This section briefly describes the resources that rely on the acquire re= source > +interface. These resources are mapped by pv tools like QEMU. > + > +Intel Processor Trace (IPT) > +``````````````````````````` > + > +This resource is named ``XENMEM_resource_vmtrace_buf`` and its size in > bytes is > +set in ``d->vmtrace_size``. It contains the traces generated by the IPT.= These > +traces are generated by each vcpu. The pages are allocated during > +``vcpu_create()``. The pages are stored in the ``vcpu`` structure in > +``sched.h``: > + > +.. code-block:: c > + > + struct { > + struct page_info *pg; /* One contiguous allocation of d->vmtrace= _size > */ > + } vmtrace; > + > +During ``vcpu_create()``, the pg is allocated by using the per-domain he= ap: > + > +.. code-block:: c > + > + pg =3D alloc_domheap_pages(d, get_order_from_bytes(d->vmtrace_size), > MEMF_no_refcount); > + > +For a given vcpu, the page is loaded into the guest at > +``vmx_restore_guest_msrs()``: > + > +.. code-block:: c > + :caption: xen/arch/x86/hvm/vmx/vmx.c > + > + wrmsrl(MSR_RTIT_OUTPUT_BASE, page_to_maddr(v->vmtrace.pg)); > + > +The releasing of the pages happens during the vcpu teardown. > + > +Grant Table > +``````````` > + > +The grant tables are represented by the ``XENMEM_resource_grant_table`` > +resource. Grant tables are special since guests can map grant tables. Do= m0 > also > +needs to write into the grant table to set up the grants for xenstored a= nd > +xenconsoled. When acquiring the resource, the pages are allocated from > the xen > +heap in ``gnttab_get_shared_frame_mfn()``: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/grant_table.c > + > + gt->shared_raw[i] =3D alloc_xenheap_page() > + share_xen_page_with_guest(virt_to_page(gt->shared_raw[i]), d, > SHARE_rw); > + > +Then, pages are shared with the guest. These pages are then converted > from virt > +to mfn before returning: > + > +.. code-block:: c > + :linenos: > + > + for ( i =3D 0; i < nr_frames; ++i ) > + mfn_list[i] =3D virt_to_mfn(vaddrs[frame + i]); > + > +Ioreq server > +```````````` > + > +The ioreq server is represented by the ``XENMEM_resource_ioreq_server`` > +resource. An ioreq server provides emulated devices to HVM and PVH > guests. The > +allocation is done in ``ioreq_server_alloc_mfn()``. The following code > partially > +shows the allocation of the pages that represent the ioreq server: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/ioreq.c > + > + page =3D alloc_domheap_page(s->target, MEMF_no_refcount); > + > + iorp->va =3D __map_domain_page_global(page); > + if ( !iorp->va ) > + goto fail; > + > + iorp->page =3D page; > + clear_page(iorp->va); > + return 0; > + > +The function above is invoked from ``ioreq_server_get_frame()`` which is > called > +from ``acquire_ioreq_server()``. For acquiring, the function returns the > +allocated pages as follows: > + > +.. code-block:: c > + > + *mfn =3D page_to_mfn(s->bufioreq.page); > + > +The ``ioreq_server_free_mfn()`` function releases the pages as follows: > + > +.. code-block:: c > + :linenos: > + :caption: xen/common/ioreq.c > + > + unmap_domain_page_global(iorp->va); > + iorp->va =3D NULL; > + > + put_page_alloc_ref(page); > + put_page_and_type(page); > + > +.. TODO: Why unmap() and free() are not used instead? > diff --git a/docs/hypervisor-guide/index.rst b/docs/hypervisor- > guide/index.rst > index e4393b0697..961a11525f 100644 > --- a/docs/hypervisor-guide/index.rst > +++ b/docs/hypervisor-guide/index.rst > @@ -9,3 +9,5 @@ Hypervisor documentation > code-coverage >=20 > x86/index > + > + acquire_resource_reference > -- > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361842.591586 (Exim 4.92) (envelope-from ) id 1o8zUe-0005Mb-Vn; Wed, 06 Jul 2022 07:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361842.591586; Wed, 06 Jul 2022 07:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUe-0005MS-So; Wed, 06 Jul 2022 07:30:40 +0000 Received: by outflank-mailman (input) for mailman id 361842; Wed, 06 Jul 2022 07:30:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUd-0003d3-01 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:39 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87e97f7c-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:30:38 +0200 (CEST) Received: from DU2PR04CA0250.eurprd04.prod.outlook.com (2603:10a6:10:28e::15) by PR2PR08MB4842.eurprd08.prod.outlook.com (2603:10a6:101:22::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:30:34 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::4d) by DU2PR04CA0250.outlook.office365.com (2603:10a6:10:28e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:34 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Wed, 06 Jul 2022 07:30:33 +0000 Received: from 79309e511a9a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B7F04F9B-AC97-44B1-8FCE-6716EEDB236D.1; Wed, 06 Jul 2022 07:30:27 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 79309e511a9a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:27 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87e97f7c-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hXTzX7rsmJ3+Y4iEPyUuls2+JnU56VgAUs/87es+p3/LlQzzKwnoWRyCP5yB+IeqAdD2ghS4022atftZzQp47UUYAkeGyCHkj2FcXuCrleDM5Kza6ph0I4wpaD4Y3pXrQXYwWSXeVsGAs7LAX9Ca3QEjN0Rd92fDXprsmVqO/6yR0PI31fYW1dJpsgw6Ep9qv39Y1nDg1/N9azxlGwZV68ttaFMMgml03BWm6kP4241gq4hk6cIEVa16OU1GGPzW/72uZLdIi9DkZeTO0Lsz8UqHLNP3kDuVmOQUXR6dbNuOweIu37SsFHCVvL5kX6YH5cquAt/EWpC3BrNyM/6olg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gy6vtQvPHe/s3EBQ+9ORO4entkW9CaJE3vnSWfjN6n8=; b=cf2x8EuhhqKLeWBupzBHHU+C9KUUY3tFSgDdREJFfqLM6HodB4gDh2DtWD6HqYErMzxm/7hP0Kbz9HHD701+GMNI/X7jNsr4Fpqh6goaB/tpsrWczkAfuj+IuL4dGMlHjYVZY/Zb8fUWKYyQrx6902mfgq+KLgfKox5FF72zByoyPeAxhO82saRfml/WGBFhXPP4Ahh0zWCUh4+LSdV9PJ4Bxfpo3i+uu/dQuBqxQdxLkmRgCWkyO0zdq0q8Y9r/Bl1H31Co5icq5Xfd7YUBGhreq8fc+xQVgrlmRH1d85RMULNsRMMcPxpT2VCMU1VN6ruGJXGz2m8ysw50OzS1uQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy6vtQvPHe/s3EBQ+9ORO4entkW9CaJE3vnSWfjN6n8=; b=2NwNIVgF+sD53YLFcfxMJLpkpzmNf4SVv3y6d4CbXMKXSoghRZe7fX4UXPeI7MK9NkT2YGmx2hRdY5KQ17aSnewyoSue54FLTTg2IPsFRovDfjFuQmUhMFC+HORjo0H6LWRDurQl73cn33jvhsJsSWg9tiNIWIeOjBZ53nRpdG8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVRls5qWNCLgLaX3HhorMXb4gnrEyzhwNICdnz7DRIwSNy5E8mGIE3DJ1rqjNi80VpCKq3s5JHib5sUtlRUgGbPJUUhXRVM8mN053h2dmtMKT6vTmygcl2A1HKHlKtzuGJrvmBOiJDybyu8mdJhESgfLpbj//jlCPpCkgzRr2Hjg/VkBg5ebPD/2v1+tuY8r1auE/cGQeRCLZk+v1l9fRUw5LXWmTf/1/pBc3onGk82SSCH8sx5EoG98QGusoqt2OcNoeucLI/2eZ3Fs9eQMPFkDCZ9q/IORxAhi/Wd5j8Q/qQsnwthZKYtwwBQofd5G741o+oVmGe2/9jAwkjOI8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gy6vtQvPHe/s3EBQ+9ORO4entkW9CaJE3vnSWfjN6n8=; b=oeGh6p/QDBxsNZZTBP4b+413FvJN8mldPcXfPVyCKW94Ak1Jp+qNeRaaRXOlPigfmrvXXkLZ5mbLVVE5bvooOjhp+NreyEcykqAP+Xh6WBzDxFd3z17xAl8hZNWgP78SNtGKiNwBUuvFHByDqBaWu7AJEQHWiT4+39wO4ByLYWGmWj6EKqxBxpLr9wT+phbxErj3ZBosxhIp64nAA6hipqlHBTBvjYotpcmzRlvAzsQoUCaPbUl0cAkG3kI6HHhHhS3S5bCkdOS1OM1sVE+aDa13NwSWZ7CwDwmzxN02leAIiCVUZrKnHO111XqUMKa9uiMKRf9CSyR0TCkSag7plA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gy6vtQvPHe/s3EBQ+9ORO4entkW9CaJE3vnSWfjN6n8=; b=2NwNIVgF+sD53YLFcfxMJLpkpzmNf4SVv3y6d4CbXMKXSoghRZe7fX4UXPeI7MK9NkT2YGmx2hRdY5KQ17aSnewyoSue54FLTTg2IPsFRovDfjFuQmUhMFC+HORjo0H6LWRDurQl73cn33jvhsJsSWg9tiNIWIeOjBZ53nRpdG8= From: Henry Wang To: "xen-devel@lists.xenproject.org" , "christopher.w.clark@gmail.com" , Andrew Cooper CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" Subject: RE: [PATCH v6 0/9] xen: drop hypercall function tables Thread-Topic: [PATCH v6 0/9] xen: drop hypercall function tables Thread-Index: AQHYP4flEN1TZgxxxkSZpjQ9KWhqIa1xioog Date: Wed, 6 Jul 2022 07:30:23 +0000 Message-ID: References: <20220324140139.5899-1-jgross@suse.com> In-Reply-To: <20220324140139.5899-1-jgross@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3A4438CCA3DA4E4C85F88D87571BDF64.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7087e93a-8a3f-4e3b-49c9-08da5f2169ce x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|DBAEUR03FT013:EE_|PR2PR08MB4842:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zgmaJQacaoYPPSPWvKi1DVtU0I/RHFOsJxr7fkuv3tbG2rwLWE5VuLQ9AcTZE7t8ybIzmD3ao5Ods/qBXKHXUp2NVWnY//BPhlg3kcVwgQKbuRsKTUK5L3uxWsVCQPnDGeYaNW7H+TMwij2XHtAdU0+mSmTZLYcA7iyz9iXn7kSzP0CnNqJDInwwUN/2dAxhgdOsdsVINVjpywHJ2Irqb3huhR/ntnH2ZRP0pkVaTvE8fJ28PPn19ZfhNpxOvDFnt/EC17Sbe3liaMBQTPP868J0Lj++U5/hCtWDWWa5FBaar5rTXjOsYiO8r1poFXWK02ZWGDlDK7Rq+apiP+r1VI33W71CCeH789KqwqOM8bU+/peaT6Clg0Bd+44hyh+M/iHU5BpN1CJhgTkuqKBjR7J4pVZCM+G1YtcLON9TKdzSbt5hTDNvuBzs7LQ+QmAD/nWGS04hL4IKUmEzhNIfXzqFw0jUHRq1KQGgz5MAKhlBj8t1oAhnpr8UySyh58jnqjmjn4cyErpLgDggbOGUnjdXjnsVv4Ct1tRbn9t3hAvldDzOV/LbyuZTZvLRPIn7aDiBE39WfRf35UfuI985abpvhxX5qsapEnLQdoy57wkktj/iVU15qcrttR6DDIVd6CatkOEKs7nVp64BZa53D/w1BzHbpk75twOd/+pq/1wsBfz4PmaC5KhXGRg5kk9EZqCHxCT0ZKXE6AaLDFToBLWCSsjw5ZB+MsfmnRRN0KAwBuU5dHhaIeSCMteuzP/pRG/+54V/DUg6ZSNqgTADAoV/T1cEb3ccg2wuhwOJXEv54EFwhlhUfDAHWYk/AxfB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(6506007)(7696005)(86362001)(7416002)(5660300002)(2906002)(38070700005)(66556008)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(71200400001)(54906003)(110136005)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cb9ec012-dc4b-4e6b-a651-08da5f216378 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ocv5wfcZNGu0TP0ga5AiGAthwG5FRVd6D8hX9bFqEMpCN+rhLmjsuybc5GKsS8knioKSDJrCYurvJ2eqiDfrcVztpLbRbCGVWllLS/vklQyQwHiM/pC3kc87GlpXHFXQ7rAK1eFA9uKfduRcioI6LDbAhz39KygFASP+fWuKtUkbHpivgmJQJQUuKufZFA5ZKgShKVjX30m9s4FTKIAMYBQ9nSA50BCg04SRPwNiZ9gVb0oIMqRxZJp4nSKOH7uZV5D72/8JlnRXnuUNsQ7iCR60YTQ32n1YNn61KjWV85PD66rApE/OQCN4fKNRX2TyU9ctb0IIMV4sJpvOCFw8zJdOGswKXDy2YZqRQf7alFfn94igb+9Xd4OAQUbChlMw7gfaZU/nL6o/DCizkIlkNgcXNAEepL1fUJvpHwS9tOPwup8yTd1nYNp5lVlTuSLz5WjKlpAwzwUnaKgghNZwxwWV8hYQIIGHXE4P1dhJhv5qzK90U2hQF3dbaf4WzaZBR2tI0dFeFxe1akOWPblNrwnnYU4pE5LZSUwRjSorgmjJAhiFV7RLmIW9zBo+1quhHXFmh7oURpHavjrfAe13UKj8wzHITwvFo6kqVeQfctrhNtDIWwGz6SJwp/AaELSRoXkOsefWrkeR7fznJ2va9zC4sINOqVue0qvYDgYROK0oUk20Vyv7oj2nbBj2tJ+9Fi9oov7MaFz7koDij/MrmrlS4sHlHr5sm9CS0wi0Z+FlITgfc2XtN/PDpjA117MkGxGKA8u8EgKICi/gQOX3Wgl3wv4+DBh5KPPBoMj5Mf82Kn7cvyGgQj8l3tl6fcx6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(36840700001)(40470700004)(46966006)(82310400005)(70586007)(8676002)(4326008)(70206006)(81166007)(478600001)(7696005)(6506007)(186003)(107886003)(41300700001)(110136005)(9686003)(83380400001)(82740400003)(54906003)(316002)(26005)(47076005)(86362001)(336012)(356005)(2906002)(36860700001)(5660300002)(33656002)(40480700001)(8936002)(40460700003)(52536014)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:34.0032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7087e93a-8a3f-4e3b-49c9-08da5f2169ce X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4842 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGJlZW4gc3RhbGUgZm9yIG1vcmUg dGhhbiAzIG1vbnRocywgd2l0aDoNCg0KUGF0Y2ggIzEgbWVyZ2VkLg0KUGF0Y2ggIzIgbmVlZCBm ZWVkYmFjayByZWdhcmRpbmcgdGhlIGtleGVjIGFuZCBhcmdvIGNoYW5nZXMuDQpQYXRjaCAjMyAj NCAjNSAjNiAjNyAjOCAjOSByZXZpZXdlZC9hY2tlZC4NCg0KU28gc2VuZGluZyB0aGlzIGFzIGEg Z2VudGxlIHJlbWluZGVyIGZvciBrZXhlYyBhbmQgYXJnbyBtYWludGFpbmVycy4NClRoYW5rcyEN Cg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0K PiBTdWJqZWN0OiBbUEFUQ0ggdjYgMC85XSB4ZW46IGRyb3AgaHlwZXJjYWxsIGZ1bmN0aW9uIHRh Ymxlcw0KPiANCj4gSW4gb3JkZXIgdG8gYXZvaWQgaW5kaXJlY3QgZnVuY3Rpb24gY2FsbHMgb24g dGhlIGh5cGVyY2FsbCBwYXRoIGFzDQo+IG11Y2ggYXMgcG9zc2libGUgdGhpcyBzZXJpZXMgaXMg cmVtb3ZpbmcgdGhlIGh5cGVyY2FsbCBmdW5jdGlvbiB0YWJsZXMNCj4gYW5kIGlzIHJlcGxhY2lu ZyB0aGUgaHlwZXJjYWxsIGhhbmRsZXIgY2FsbHMgdmlhIHRoZSBmdW5jdGlvbiBhcnJheQ0KPiBi eSBhdXRvbWF0aWNhbGx5IGdlbmVyYXRlZCBjYWxsIG1hY3Jvcy4NCj4gDQo+IEFub3RoZXIgYnkt cHJvZHVjdCBvZiBnZW5lcmF0aW5nIHRoZSBjYWxsIG1hY3JvcyBpcyB0aGUgYXV0b21hdGljDQo+ IGdlbmVyYXRpbmcgb2YgdGhlIGh5cGVyY2FsbCBoYW5kbGVyIHByb3RvdHlwZXMgZnJvbSB0aGUg c2FtZSBkYXRhIGJhc2UNCj4gd2hpY2ggaXMgdXNlZCB0byBnZW5lcmF0ZSB0aGUgbWFjcm9zLg0K PiANCj4gVGhpcyBoYXMgdGhlIGFkZGl0aW9uYWwgYWR2YW50YWdlIG9mIHVzaW5nIHR5cGUgc2Fm ZSBjYWxscyBvZiB0aGUNCj4gaGFuZGxlcnMgYW5kIHRvIGVuc3VyZSByZWxhdGVkIGhhbmRsZXIg KGUuZy4gUFYgYW5kIEhWTSBvbmVzKSBzaGFyZQ0KPiB0aGUgc2FtZSBwcm90b3R5cGVzLg0KPiAN Cj4gQSB2ZXJ5IGJyaWVmIHBlcmZvcm1hbmNlIHRlc3QgKHBhcmFsbGVsIGJ1aWxkIG9mIHRoZSBY ZW4gaHlwZXJ2aXNvcg0KPiBpbiBhIDYgdmNwdSBndWVzdCkgc2hvd2VkIGEgdmVyeSBzbGltIGlt cHJvdmVtZW50IChsZXNzIHRoYW4gMSUpIG9mDQo+IHRoZSBwZXJmb3JtYW5jZSB3aXRoIHRoZSBw YXRjaGVzIGFwcGxpZWQuIFRoZSB0ZXN0IHdhcyBwZXJmb3JtZWQgdXNpbmcNCj4gYSBQViBhbmQg YSBQVkggZ3Vlc3QuDQo+IA0KPiBDaGFuZ2VzIGluIFYyOg0KPiAtIG5ldyBwYXRjaGVzIDYsIDE0 LCAxNQ0KPiAtIHBhdGNoIDc6IHN1cHBvcnQgaHlwZXJjYWxsIHByaW9yaXRpZXMgZm9yIGZhc3Rl ciBjb2RlDQo+IC0gY29tbWVudHMgYWRkcmVzc2VkDQo+IA0KPiBDaGFuZ2VzIGluIFYzOg0KPiAt IHBhdGNoZXMgMSBhbmQgNCByZW1vdmVkIGFzIGFscmVhZHkgYXBwbGllZA0KPiAtIGNvbW1lbnRz IGFkZHJlc3NlZA0KPiANCj4gQ2hhbmdlcyBpbiBWNDoNCj4gLSA1IHBhdGNoZXMgcmVtb3ZlZCBh bCBhbHJlYWR5IGFwcGxpZWQNCj4gLSBuZXcgcGF0Y2hlcyAxLCAzIGFuZCAxMQ0KPiAtIGF2b2lk IHN3aXRjaGluZyBBcm0gaHlwZXJjYWxsIGhhbmRsZXJzIHRvIHJldHVybiBsb25nIChubyBjaGFu Z2Ugb2YNCj4gICBoYW5kbGVycyByZXR1cm5pbmcgbG9uZyBhbHJlYWR5KQ0KPiANCj4gQ2hhbmdl cyBpbiBWNToNCj4gLSBwYXRjaCAzIG9mIFY0IGhhcyBiZWVuIGFwcGxpZWQgYWxyZWFkeQ0KPiAt IGNvbW1lbnRzIGFkZHJlc3NlZA0KPiAtIHJlYmFzZQ0KPiANCj4gQ2hhbmdlcyBpbiBWNjoNCj4g LSBwYXRjaCAxIG9mIFY1IGhhcyBiZWVuIGFwcGxpZWQgYWxyZWFkeQ0KPiAtIGZpeCBvZiBhIHJl YmFzZSBhcnRpZmFjdA0KPiANCj4gSnVlcmdlbiBHcm9zcyAoOSk6DQo+ICAgeGVuOiBtb3ZlIGRv X3ZjcHVfb3AoKSB0byBhcmNoIHNwZWNpZmljIGNvZGUNCj4gICB4ZW46IGhhcm1vbml6ZSByZXR1 cm4gdHlwZXMgb2YgaHlwZXJjYWxsIGhhbmRsZXJzDQo+ICAgeGVuOiBkb24ndCBpbmNsdWRlIGFz bS9oeXBlcmNhbGwuaCBmcm9tIEMgc291cmNlcw0KPiAgIHhlbjogaW5jbHVkZSBjb21wYXQvcGxh dGZvcm0uaCBmcm9tIGh5cGVyY2FsbC5oDQo+ICAgeGVuOiBnZW5lcmF0ZSBoeXBlcmNhbGwgaW50 ZXJmYWNlIHJlbGF0ZWQgY29kZQ0KPiAgIHhlbjogdXNlIGdlbmVyYXRlZCBwcm90b3R5cGVzIGZv ciBoeXBlcmNhbGwgaGFuZGxlcnMNCj4gICB4ZW4veDg2OiBjYWxsIGh5cGVyY2FsbCBoYW5kbGVy cyB2aWEgZ2VuZXJhdGVkIG1hY3JvDQo+ICAgeGVuL2FybTogY2FsbCBoeXBlcmNhbGwgaGFuZGxl cnMgdmlhIGdlbmVyYXRlZCBtYWNybw0KPiAgIHhlbi94ODY6IHJlbW92ZSBjZl9jaGVjayBhdHRy aWJ1dGUgZnJvbSBoeXBlcmNhbGwgaGFuZGxlcnMNCj4gDQo+ICAuZ2l0aWdub3JlICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxICsNCj4gIHhlbi9hcmNoL2FybS9kb21haW4uYyAg ICAgICAgICAgICAgICAgICAgfCAgMTUgKy0NCj4gIHhlbi9hcmNoL2FybS9odm0uYyAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDMgKy0NCj4gIHhlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9oeXBl cmNhbGwuaCAgICAgfCAgIDcgKy0NCj4gIHhlbi9hcmNoL2FybS9wbGF0Zm9ybV9oeXBlcmNhbGwu YyAgICAgICAgfCAgIDEgKw0KPiAgeGVuL2FyY2gvYXJtL3RyYXBzLmMgICAgICAgICAgICAgICAg ICAgICB8IDExNyArKy0tLS0tLS0NCj4gIHhlbi9hcmNoL3g4Ni9jb21wYXQuYyAgICAgICAgICAg ICAgICAgICAgfCAgIDYgKy0NCj4gIHhlbi9hcmNoL3g4Ni9jcHUvbWNoZWNrL21jZS5jICAgICAg ICAgICAgfCAgIDIgKy0NCj4gIHhlbi9hcmNoL3g4Ni9jcHUvdnBtdS5jICAgICAgICAgICAgICAg ICAgfCAgIDMgKy0NCj4gIHhlbi9hcmNoL3g4Ni9kb21haW4uYyAgICAgICAgICAgICAgICAgICAg fCAgMTEgKy0NCj4gIHhlbi9hcmNoL3g4Ni9kb21jdGwuYyAgICAgICAgICAgICAgICAgICAgfCAg IDQgKy0NCj4gIHhlbi9hcmNoL3g4Ni9odm0vZG0uYyAgICAgICAgICAgICAgICAgICAgfCAgIDIg Ky0NCj4gIHhlbi9hcmNoL3g4Ni9odm0vaHZtLmMgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0N Cj4gIHhlbi9hcmNoL3g4Ni9odm0vaHlwZXJjYWxsLmMgICAgICAgICAgICAgfCAxNzcgKystLS0t LS0tLS0tLQ0KPiAgeGVuL2FyY2gveDg2L2h5cGVyY2FsbC5jICAgICAgICAgICAgICAgICB8ICA1 OSAtLS0tLQ0KPiAgeGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2h5cGVyY2FsbC5oICAgICB8IDIw MSArKysrLS0tLS0tLS0tLS0NCj4gIHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9wYWdpbmcuaCAg ICAgICAgfCAgIDMgLQ0KPiAgeGVuL2FyY2gveDg2L21tLmMgICAgICAgICAgICAgICAgICAgICAg ICB8ICAxMyArLQ0KPiAgeGVuL2FyY2gveDg2L21tL3BhZ2luZy5jICAgICAgICAgICAgICAgICB8 ICAgMyArLQ0KPiAgeGVuL2FyY2gveDg2L3BoeXNkZXYuYyAgICAgICAgICAgICAgICAgICB8ICAg MiArLQ0KPiAgeGVuL2FyY2gveDg2L3BsYXRmb3JtX2h5cGVyY2FsbC5jICAgICAgICB8ICAgMyAr LQ0KPiAgeGVuL2FyY2gveDg2L3B2L2NhbGxiYWNrLmMgICAgICAgICAgICAgICB8ICAyNiArLQ0K PiAgeGVuL2FyY2gveDg2L3B2L2Rlc2NyaXB0b3ItdGFibGVzLmMgICAgICB8ICAgOCArLQ0KPiAg eGVuL2FyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jICAgICAgICAgICB8ICAgMiArLQ0KPiAgeGVu L2FyY2gveDg2L3B2L2h5cGVyY2FsbC5jICAgICAgICAgICAgICB8IDE4NyArKy0tLS0tLS0tLS0t LQ0KPiAgeGVuL2FyY2gveDg2L3B2L2lyZXQuYyAgICAgICAgICAgICAgICAgICB8ICAgNSArLQ0K PiAgeGVuL2FyY2gveDg2L3B2L21pc2MtaHlwZXJjYWxscy5jICAgICAgICB8ICAyMiArLQ0KPiAg eGVuL2FyY2gveDg2L3B2L3NoaW0uYyAgICAgICAgICAgICAgICAgICB8ICAgNCArLQ0KPiAgeGVu L2FyY2gveDg2L3RyYXBzLmMgICAgICAgICAgICAgICAgICAgICB8ICAgMiArLQ0KPiAgeGVuL2Fy Y2gveDg2L3g4Nl82NC9jb21wYXQvbW0uYyAgICAgICAgICB8ICAgMyArLQ0KPiAgeGVuL2FyY2gv eDg2L3g4Nl82NC9kb21haW4uYyAgICAgICAgICAgICB8ICAxNiArLQ0KPiAgeGVuL2FyY2gveDg2 L3g4Nl82NC9tbS5jICAgICAgICAgICAgICAgICB8ICAgMiAtDQo+ICB4ZW4vYXJjaC94ODYveDg2 XzY0L3BsYXRmb3JtX2h5cGVyY2FsbC5jIHwgICAxIC0NCj4gIHhlbi9jb21tb24vYXJnby5jICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDggKy0NCj4gIHhlbi9jb21tb24vY29tcGF0L2RvbWFp bi5jICAgICAgICAgICAgICAgfCAgMTUgKy0NCj4gIHhlbi9jb21tb24vY29tcGF0L2dyYW50X3Rh YmxlLmMgICAgICAgICAgfCAgIDMgKy0NCj4gIHhlbi9jb21tb24vY29tcGF0L2tlcm5lbC5jICAg ICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9jb21tb24vY29tcGF0L21lbW9yeS5jICAgICAg ICAgICAgICAgfCAgIDMgKy0NCj4gIHhlbi9jb21tb24vZG0uYyAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDIgKy0NCj4gIHhlbi9jb21tb24vZG9tYWluLmMgICAgICAgICAgICAgICAgICAg ICAgfCAgMTQgKy0NCj4gIHhlbi9jb21tb24vZG9tY3RsLmMgICAgICAgICAgICAgICAgICAgICAg fCAgIDIgKy0NCj4gIHhlbi9jb21tb24vZXZlbnRfY2hhbm5lbC5jICAgICAgICAgICAgICAgfCAg IDMgKy0NCj4gIHhlbi9jb21tb24vZ3JhbnRfdGFibGUuYyAgICAgICAgICAgICAgICAgfCAgIDQg Ky0NCj4gIHhlbi9jb21tb24vaHlwZnMuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0N Cj4gIHhlbi9jb21tb24va2VybmVsLmMgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4g IHhlbi9jb21tb24va2V4ZWMuYyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDYgKy0NCj4gIHhl bi9jb21tb24vbWVtb3J5LmMgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9j b21tb24vbXVsdGljYWxsLmMgICAgICAgICAgICAgICAgICAgfCAgIDQgKy0NCj4gIHhlbi9jb21t b24vc2NoZWQvY29tcGF0LmMgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9jb21tb24v c2NoZWQvY29yZS5jICAgICAgICAgICAgICAgICAgfCAgIDQgKy0NCj4gIHhlbi9jb21tb24vc3lz Y3RsLmMgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9jb21tb24veGVub3By b2YuYyAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9kcml2ZXJzL2NoYXIvY29u c29sZS5jICAgICAgICAgICAgICAgfCAgIDIgKy0NCj4gIHhlbi9pbmNsdWRlL01ha2VmaWxlICAg ICAgICAgICAgICAgICAgICAgfCAgMTMgKw0KPiAgeGVuL2luY2x1ZGUvaHlwZXJjYWxsLWRlZnMu YyAgICAgICAgICAgICB8IDI4NSArKysrKysrKysrKysrKysrKysrKw0KPiAgeGVuL2luY2x1ZGUv eGVuL2h5cGVyY2FsbC5oICAgICAgICAgICAgICB8IDE4NSArLS0tLS0tLS0tLS0tDQo+ICB4ZW4v c2NyaXB0cy9nZW5faHlwZXJjYWxsLmF3ayAgICAgICAgICAgIHwgMzE0ICsrKysrKysrKysrKysr KysrKysrKysrDQo+ICB4ZW4veHNtL3hzbV9jb3JlLmMgICAgICAgICAgICAgICAgICAgICAgIHwg ICA0ICstDQo+ICA1OCBmaWxlcyBjaGFuZ2VkLCA4NjEgaW5zZXJ0aW9ucygrKSwgOTM3IGRlbGV0 aW9ucygtKQ0KPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IHhlbi9pbmNsdWRlL2h5cGVyY2FsbC1kZWZz LmMNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vc2NyaXB0cy9nZW5faHlwZXJjYWxsLmF3aw0K PiANCj4gLS0NCj4gMi4zNC4xDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361845.591598 (Exim 4.92) (envelope-from ) id 1o8zUp-00064P-GM; Wed, 06 Jul 2022 07:30:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361845.591598; Wed, 06 Jul 2022 07:30:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUp-00064B-Ah; Wed, 06 Jul 2022 07:30:51 +0000 Received: by outflank-mailman (input) for mailman id 361845; Wed, 06 Jul 2022 07:30:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUn-0003d3-3U for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:49 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00052.outbound.protection.outlook.com [40.107.0.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8df83c53-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:30:48 +0200 (CEST) Received: from DU2PR04CA0252.eurprd04.prod.outlook.com (2603:10a6:10:28e::17) by AS8PR08MB6534.eurprd08.prod.outlook.com (2603:10a6:20b:31c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 07:30:46 +0000 Received: from DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::4b) by DU2PR04CA0252.outlook.office365.com (2603:10a6:10:28e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Wed, 6 Jul 2022 07:30:46 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT051.mail.protection.outlook.com (100.127.142.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:46 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Wed, 06 Jul 2022 07:30:46 +0000 Received: from f4987bb6deaf.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B2CB3A1-A80E-472C-BB2D-C1C6540FF577.1; Wed, 06 Jul 2022 07:30:40 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f4987bb6deaf.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:40 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:38 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8df83c53-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iz9I8mQpE16MZ40HUFjlROiH8ATALrkXCu+wA3msSgJf0rC85/fvmF1Wtxk8szwNK2mas1jxx4YxNa4LqIln3vZ+fR7W63BU9iRrQpTx5PKhY8mHu8MH8gmEwDAwGp7oREb2kuQVhxwN0G05fZOZmg8bHwhLQrnEeUw2wUudEfvR1zIWIr6Zfb+BcpjDcp/3uaNtKwBbhl5wJACykhVUBKDhirCfWJiUdYGEIrV/IMAEzKVKaiR3i5Jy0GfFvM1eswtrU1SMzc/0LRj06BS7v0NQAsjOhK3mrVFI/PxcTo0m8tRCzZPqcjFLcPctKs96Jr8Gpfvecr5cmC5QW8LJWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8+WXyd/soauYcseDQOtImG425U3uzMpi+wvqiEpPRg=; b=MnGIL4v1chWq8Y2lE9Wfus91CZUblACVLy4/jEclEO/OwdC4z6feSL4tFzYhpzf7WaBaBGsjV4ferUhN2l2rAqf+RvxBcMIozU/GYY+2UVs4BhpC4KgDfHljunEwoj24RRkC2QwsPJaStczA1t2IY8HukeqjHFZVfw9qKRASvUeXYv2006wEAuODwNfuRjnOhrIZkZ1ArS++pslX2SPIFiSC/0CKBcZfbwdxcDzwKQ/3UWBR0sQFSlUBx7vbQjAkG4x7GKhdZOurXBMSOjewd4bNnFOUhVUzMEXvkIBMmPbtPcs/WNpB0R7Vg+eTdisiGQm4UIILfH7gxXn1HRdtZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8+WXyd/soauYcseDQOtImG425U3uzMpi+wvqiEpPRg=; b=NLFZw1TM0KBZbPP8+t/leNGWX5j8TzigoEiCnaakF6zumkgzEw9RNYjltN4EAsJUNSHmuemhIe5HBTRIe+sKM54gtWB4XnNxKT1gvWEbeMhu+OuahE9RT5g0qmD21JRjVURieI04SE/QBhohte7kb+/ejBzzuB7kTxNj6J1BNVk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iUe5iVNxiweeDQ0lQcQIhmgTdo8Z3x/uRzA2Kvdz3vextZRjU0FRie+iCDQDoBaNtWprfJ/wU55I4znJvELhFi0GjIkOms6geVAy3i1VVUyqVoFDDJ7W5UhsA/KilYREH49BuDqaEyqL0gKAVrC9Su6b/t3YrmyPuyvkCt8DpYOs1SQJjkJ+AkgdA5c2quBS9DCC4OZiMx4vEj2+zdW54US6bsEXtyn3DLHBDgJW6CfRK5pNp7C/TaQwLcJoqrEBPgMIjq5YWiVL7v7808wRGzcm0GY1Yaz2DJNUCgcVZGtBkj5+6APkYHeDE4SQ2kjhAIT0yjvoGksXx7hbuS5djg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r8+WXyd/soauYcseDQOtImG425U3uzMpi+wvqiEpPRg=; b=BFJCyOZIIEgtMeqcJhdTE05uGg4Wq7KyYIddoxx8ZpCTs8Y9JBeehHQzok/OasroeNO/TbLTaRvnmnxs9hsavkmehAAL90OOk+ve0S1teYjZtMe2i1AYsd6hcng2SrEGLqtIBM0CJkrautHrUNThM+2LgCldTsuzWnEe6057Ius9/XYkvelm31LiVO1TD1TdcnmbGhRuHQr5LCHKAW9TldXbu9XA4K/xbhhGpkhoqRRWp5lZc7hnMPSkxeBh2kRAdZ+cLMoyrffCRxKeIrri+HR1UNJsd04RLeDEDeZ74BH7JGg+U5DTJGeGKcJ9aO9bewKOJ2yyUWOcXteuoJvA6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r8+WXyd/soauYcseDQOtImG425U3uzMpi+wvqiEpPRg=; b=NLFZw1TM0KBZbPP8+t/leNGWX5j8TzigoEiCnaakF6zumkgzEw9RNYjltN4EAsJUNSHmuemhIe5HBTRIe+sKM54gtWB4XnNxKT1gvWEbeMhu+OuahE9RT5g0qmD21JRjVURieI04SE/QBhohte7kb+/ejBzzuB7kTxNj6J1BNVk= From: Henry Wang To: Yuanjun Gong CC: "xen-devel@lists.xenproject.org" , Jan Beulich Subject: RE: [PATCH 1/1] tools/symbols: fix memory leak in build_initial_tok_table() Thread-Topic: [PATCH 1/1] tools/symbols: fix memory leak in build_initial_tok_table() Thread-Index: AQHYdM1wHtv6Z/xEr0qRtuqMggPoc61xJXTQ Date: Wed, 6 Jul 2022 07:30:38 +0000 Message-ID: References: <20220531082320.31294-1-ruc_gongyuanjun@163.com> <55be7afb-dc71-fa26-a1dd-59e573b9ac4c@suse.com> In-Reply-To: <55be7afb-dc71-fa26-a1dd-59e573b9ac4c@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 0927BF2F6FF13541BB795179E22B8C72.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 44ccd279-2333-4454-188a-08da5f217130 x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|DBAEUR03FT051:EE_|AS8PR08MB6534:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PsM/f4o/Hyn5i0K9smNd5KqV2EwNy58Ky9+D+Ct8eX/41XXqOycPCF/TjbKuQOXxjWewo6cnNW4x2JwsvgGAUQ7ngPrishvaXqvgffWrvzWTr0cHnd+voSxSwF6Is/lXJWCrXEdAWMgATH6PdC+hQuzPrhVkz8neXudI7nVRumoPqbWpbsUbfHkKwJpagQp4INRyQtvQzVEoJIeQRdufCGv0WY96pgc48+h7uNCqp6bJk0FR0Q15yiIPyN4d8TtMgrp9vjwVbN+VE+k/G7SZHCgHbsA+ahpDhdRTQNh3p6+uNaGLoSRAxiPHUYQU7AuhZY8C1oGFblyKrIlN9fifDBVi4VqnmjSgHZYJmkIsUCy810B6FZZlR1BNNeUov3k/0bDJCW7b7yAGzE9PcG68qJcjrpfSE+H9EqphYgLOYTvL3JaznVAMgdAem2GJ549SmX7mbHFqZLck+B1BXPzY8gpxX4aTXa9Kd2e9SSajhxk8g9Vcj+Wlb6BSKWi1njOhe8pA4UdY1Hn/A/ipZ/QlhzVw/24rJYuER+4CBCCKA1Bc6BuEmJr3VqNAmu1Igw833n2iQZ9JTOksJ2rJI5vmZ78+ib1AHG3QlozdO9iR84zFL6SES8M3Gd66aT9f7J+5bz+eBjxdP5z8RLuIrCn0L0WWGwrXCTKKbqLFNA30nFDdZkLFDuJUpEGXwfEOQkAd+fPTUKmPK/Su44VAJ0X9c9iyvxgTEjIvj+lOFwRFZknHsopuT5D/YKNZDwPk3TreNG6xFO2amrYxRl9Pwu1WCtEd4OrYlEpdXICztQDFQJOd0dWE734spR5zswhV9qJp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(6506007)(7696005)(86362001)(5660300002)(2906002)(38070700005)(66556008)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(53546011)(71200400001)(54906003)(122000001)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4c1fb843-da76-4e55-67d9-08da5f216c50 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 63khss9tVVg27zOQk42+9ylkdy2QpynhyOqQzpZ+AbUcZpbQpVMwF32mHJzx3iwoG6QCpG2KOop6d41lsXj/uVPEoUR2l7HaGXTxAfq8k2I2+zVNN4WW14RFut+JMWp1JKm93FbuCWYj83S/YwQc/XdPIStZRI6wpd7XJ4B7hyS/aZMMq/fEjwwBKDHe1yVOdZ8Vw4EFuLDbXqefERKdKPlfNFUSnz7fadHe5SsYkZs7AwFJk41Jn3wKc6pKdvUCJwIMkWKekwgAtaEeEOXSwedTJ6b1cWuGJ7jB3awjoq3Rh0NT7/+33vO+NWu5lCoSPRu5iHsHiLmDoZ2akoJVQeTvvpJJTgApCa2bGpttn0KnKzTBXXD6chQ0QXdqbevvKTVLOYC4TpTxXJf3EIYAZopC3U38YchPVi3YHPK58K3270kas3atA2XvBTouToY0yugUayqcx7eM0VPm7AjsWSnN4ldamevRTOuIupFscyqWUBSHQ0SSLtEwRqm3yIEDj8HNIWx4csDbs5DgA8P8sZoVOu59qdemUiL3uTkmc+gn4TvTh173FUvtbzmtPRr26J2qvZhbNEafJxqLPxBtpjqdSqhbPHyIPtT0IsKR469jIzmsxe0rFss/R+l6L0qxKkMHVbCdDjg9c72BYfqhppl+KCPsGy5/DtSU2Lpn7Jjei6Lp6a1SczssQEePEPcLhptTRjJXkjHyJ99jSeTDQP0rt2wyYe3aEtSF7TRiibM/BtKZ+cL/Q85C7dCJE//ysz4YHh5WyAeGrdenv62jq6y+MoV15uLbuqZ8kGHYMwAEC29p2T5pr4yOKA2EARr4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(36840700001)(40470700004)(107886003)(9686003)(47076005)(336012)(70206006)(8936002)(52536014)(6862004)(4326008)(8676002)(70586007)(5660300002)(41300700001)(7696005)(33656002)(86362001)(55016003)(40480700001)(82310400005)(6506007)(2906002)(186003)(26005)(53546011)(478600001)(82740400003)(83380400001)(81166007)(356005)(316002)(40460700003)(54906003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:46.3727 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 44ccd279-2333-4454-188a-08da5f217130 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6534 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBwYXRjaCBoYXMgYmVlbiBzdGFsZSBmb3IgbW9yZSB0 aGFuIGEgbW9udGgsIHdpdGgNCmZ1cnRoZXIgYWN0aW9ucyBuZWVkIHRvIGJlIHRha2VuIGZyb20g dGhlIGF1dGhvci4gU28gSSBhbSBzZW5kaW5nIHRoaXMNCmVtYWlsIGFzIGEgZ2VudGxlIHJlbWlu ZGVyLiBUaGFua3MhDQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gLS0tLS1PcmlnaW5hbCBN ZXNzYWdlLS0tLS0NCj4gU3ViamVjdDogUmU6IFtQQVRDSCAxLzFdIHRvb2xzL3N5bWJvbHM6IGZp eCBtZW1vcnkgbGVhayBpbg0KPiBidWlsZF9pbml0aWFsX3Rva190YWJsZSgpDQo+IA0KPiBPbiAz MS4wNS4yMDIyIDEwOjIzLCBZdWFuanVuIEdvbmcgd3JvdGU6DQo+ID4gRnJlZSB0aGUgdGFibGVb aV0uc3ltIGZpZWxkIG9mIHRoZSBpbnZhbGlkIHN5bV9lbnRyeSBzaW5jZQ0KPiA+IGl0IGlzIG1h bGxvYydlZCBkYXRhLg0KPiANCj4gSXQgd291bGQgaGVscCBpZiB5b3Ugc2FpZCB3aGV0aGVyIHRo aXMgd2FzIGp1c3QgYW4gb2JzZXJ2YXRpb24gZnJvbQ0KPiBlLmcuIHN0YXRpYyBjb2RlIGFuYWx5 c2lzIHZzIHlvdSBhY3R1YWxseSBoYXZpbmcgb2JzZXJ2ZWQgdGhlIHRvb2wNCj4gcnVubmluZyBv dXQgb2YgbWVtb3J5LiBUaGlzIGlzIGEgc2hvcnQtbGl2ZWQgcHJvY2VzcyBhZnRlciBhbGwsIHNv DQo+ICJsZWFraW5nIiBtZW1vcnkgaXMgbm90IG5vcm1hbGx5IG11Y2ggb2YgYSBwcm9ibGVtLg0K PiANCj4gPiAtLS0gYS94ZW4vdG9vbHMvc3ltYm9scy5jDQo+ID4gKysrIGIveGVuL3Rvb2xzL3N5 bWJvbHMuYw0KPiA+IEBAIC00MjIsNiArNDIyLDggQEAgc3RhdGljIHZvaWQgYnVpbGRfaW5pdGlh bF90b2tfdGFibGUodm9pZCkNCj4gPiAgCQkJCXRhYmxlW3Bvc10gPSB0YWJsZVtpXTsNCj4gPiAg CQkJbGVhcm5fc3ltYm9sKHRhYmxlW3Bvc10uc3ltLCB0YWJsZVtwb3NdLmxlbik7DQo+ID4gIAkJ CXBvcysrOw0KPiA+ICsJCQl9IGVsc2Ugew0KPiA+ICsJCQkJZnJlZSh0YWJsZVtpXS5zeW0pOw0K PiANCj4gSW5kZW50YXRpb24gaXMgd3JvbmcgaGVyZS4NCj4gDQo+IEphbg0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:30:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:30:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361847.591612 (Exim 4.92) (envelope-from ) id 1o8zUq-0006Mi-VM; Wed, 06 Jul 2022 07:30:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361847.591612; Wed, 06 Jul 2022 07:30:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUq-0006LP-NO; Wed, 06 Jul 2022 07:30:52 +0000 Received: by outflank-mailman (input) for mailman id 361847; Wed, 06 Jul 2022 07:30:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zUp-0004kS-3F for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:30:51 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70045.outbound.protection.outlook.com [40.107.7.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f19f297-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:30:50 +0200 (CEST) Received: from DU2PR04CA0289.eurprd04.prod.outlook.com (2603:10a6:10:28c::24) by DB6PR0802MB2165.eurprd08.prod.outlook.com (2603:10a6:4:86::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Wed, 6 Jul 2022 07:30:43 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::1e) by DU2PR04CA0289.outlook.office365.com (2603:10a6:10:28c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Wed, 6 Jul 2022 07:30:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:43 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Wed, 06 Jul 2022 07:30:43 +0000 Received: from b4611fb5d6bc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 150C2E10-C607-4A79-81D4-0FB1C1C109E4.1; Wed, 06 Jul 2022 07:30:36 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b4611fb5d6bc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:36 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PR2PR08MB4731.eurprd08.prod.outlook.com (2603:10a6:101:18::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:30:34 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f19f297-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=d6xYBZDtNx9YGubQz9chj+MfyNuI4U5jZplSaEpQVxJCuWlQ8cxB34DQoUYAjI0O9IYkgaiNEGosrHX4Cu9no3uyqRNZS9szlJrtM2dzBWupnnuKVVFRC2mAFwgi5/Pt7BTy2+BssG7xxjruLgDSkAGb7GIA4lBW0tqfGtH+NPmMn7B/VWNSYfUqf/AT5kO5HMi8ItxDApogu3JzCzIzwG4SOVXo42nQ9nLQESKjqYXVhycPrq9q6h2EavUIu8ciqTgjvmI40AyZrHroMDxPNX09t+yT30AFGTFHEDGr7iB6VdUaz9guTD8g/Z14FrfVipfgrK7Pnt97tzZU2u2NHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDSJvr1aCT51I79vsIGcfJxrL07Fyi9UKI54RhWZPI8=; b=F5PHR9vrSaOnAMuzHe8e+fy+AwX79NJuk+kDMgoKlHUQTl50zeZQxlXfj7WbrAmsS78WmSbYIPvWMExEQ5O6U1isHrKJYNZ7KV0ZVm58NOedAyNUj0i2baxOzpCjEBY0OLoMwZpOZrkxRuerKwvDKtmgOoTw8jWrIgw8jqWv2RHCFJ3/0+Xo2AhjHK0C/zpc661GiWjSoBc9aUY//AkVPnkkQ64f7phUikb3jEHMUCQnuOCra290HfiqTDSTSArDBpjCC3bh7W/pr6vmQUVt/NRO2nmmQVH1lLutOt5CujisB5wYV+PmzHRazrV3W6+TskrqXDhrQcjOTvF1xquenQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDSJvr1aCT51I79vsIGcfJxrL07Fyi9UKI54RhWZPI8=; b=hvIU/ZnKoFuHmam8Lz5ebbeSrrrVD5ZioEnXrc7FOJ05I55zI+omAHzlkNhMp+K6fF9yEqBBMhpY1dAFupVzyv4s2AZK4RT87VhOmqlBp4QvwEu8yj9mlPz/Lp0Qihld9s2i+wlvyXi+G8d/Is7wx7elVTF86Nn7EGL4fNEq444= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PW5vRR9XQebdPwmulEXg5trJI/hjLh482uy48uA832QASX010PDP46ynxB7WAXn04ENTqhppm6aVuyfWU3xmnZ8+50pT5Ddj7GAwq8vB3ksqsm1wGSzR/3ZKEo97hr2jq0w+Rrf4AjZgQ38mOJUCfC1FKiv//ssNdAVqyV4BMmt0yQuPeFJyxDwerG1CLzWFYztdneVY4v0ux3igcTSimoPGL/aROve/kDa7rNwGYZQmiJvmLwTPXNoZyDI88K4Ebyr2XFyUn/rMuHFKZWhlJzFg6Kpa/oyPizFuX4VC0i5gPok/XNFo9Ka1Qop3IXLViEFlHvm3VtqLHb8Zvr3NVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bDSJvr1aCT51I79vsIGcfJxrL07Fyi9UKI54RhWZPI8=; b=igp47OEjqtT9fgbyrhjFu4hM5DhsxDKyDZ5BJ1q2t84cBFtXtZ4DG5Hl1h/GVU4uhc3usLrdtTIslxS157mvEBJBX8C6SXe4gBcrzRTT8E8QW/LthiHgeVjwkELEt8Q4N09K3u8S8iWiT6M8euv2A1hdMGu0KnmZgtB4ws299HTVUpqdXvEXXDE+H7gkoi7Ep/iu+eGgyQo8F16f4pn52dYNSiC4fTg2U7eltcKeNn4mgGe2txowbhbHEOhHTnH2xcGLfDQatr6RZ9XYDQ5Kt/J4mI8K/C+RAGSYgdX0GshvQQg/gsBqXUY1x2pecfPKdYtEUcpRD/HeQRwQvnEjsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bDSJvr1aCT51I79vsIGcfJxrL07Fyi9UKI54RhWZPI8=; b=hvIU/ZnKoFuHmam8Lz5ebbeSrrrVD5ZioEnXrc7FOJ05I55zI+omAHzlkNhMp+K6fF9yEqBBMhpY1dAFupVzyv4s2AZK4RT87VhOmqlBp4QvwEu8yj9mlPz/Lp0Qihld9s2i+wlvyXi+G8d/Is7wx7elVTF86Nn7EGL4fNEq444= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" Subject: RE: [RFC PATCH 0/4] Introducing a common representation of boot info Thread-Topic: [RFC PATCH 0/4] Introducing a common representation of boot info Thread-Index: AQHYdHf6JvWZG2GXVE2XLLkq14FnwK1xI0fQ Date: Wed, 6 Jul 2022 07:30:34 +0000 Message-ID: References: <20220531024127.23669-1-dpsmith@apertussolutions.com> In-Reply-To: <20220531024127.23669-1-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: DF92FB237FF0DE43B361E50E8459391D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2e97b436-4e69-4ff1-e0cb-08da5f216f47 x-ms-traffictypediagnostic: PR2PR08MB4731:EE_|DBAEUR03FT060:EE_|DB6PR0802MB2165:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kDdbplB+KhxxdmeNGa1RD+/NEqUx6rJAdCWl9AyZQXl86WoAx8xlNtERQXxWjtxlQWetkjy8+58QOd9dFw6R06EXqVAW1fe9bVTIV9qsPSlC0UJ76EJBpUfCMysmAVwlF5EPWFimxcbvoMEQY5HjReT7KL2Ob+xTul59EYTj7zo9MfkRGRcnG2ULBk3QYcuJuduaHQpKESndV3EOYc4EpjAR4mNO16wTjFE17wz2kqXQcrXYHdRooevIkqX3Wah2TC5Ezvs/Ub2Ogu/peDRlHpCvVoiCf+Dij46FsCRXHoBi7z/OwLEKY9IrbVINJID7SYzC/y9ROWCSFEGLJArSB+93zCzIIKe1QMXf/k2qX0VGVtucW4L/MZX9Tvc3eZa8BXQu+aFES6+Oiq3VMO3AsPf2JSrCXRoLCwNCaXozBY8h/CLmIKkQ9Lan+H22j0nUlQGCmJ3PRzAhpx1g9E+HmU/eIFZ87VX5L3vpHQEigk01ST/7dGXn6YCbJ95xHNsGRu7Wp/5tXkenVRg8jj5vuo0hrTg4hFP8PhVKJUS4YFzNDXxO7UFRusp9u2tqnZ0brPpoBWyRFINxqbIxGqEqQ7PdxfhtrxrMDCPAuREdMZ8ochDe2Ctx7SsxMlm/nRvD600Zlo01QdPprt3gxPofXArf4XhsyQJpH73qLu8C0TwCKqptCs1fA25YgqBusZd2cRjz3btsMeEGWuXcj3+tabvUkRnlk7eRhGHPOpr8Wo7rq8T9EPIxdaxMgL8IdaJPE0rFkXJzE/HELabZOoe+Y8xQatSguwROsKv8mNH0FZqfpagkDyCXaYrIoa9cpWnm X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(83380400001)(41300700001)(52536014)(186003)(8936002)(6506007)(7696005)(86362001)(5660300002)(2906002)(38070700005)(66556008)(478600001)(55016003)(8676002)(33656002)(38100700002)(4326008)(64756008)(66446008)(66476007)(76116006)(66946007)(9686003)(26005)(316002)(71200400001)(54906003)(110136005)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4731 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e545182c-b358-42fe-c6bc-08da5f216a26 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2BhfsXWgwib7Esg/NZ0A2uRjhzyY6aSorP0qVVnzjX8TyJiCglgQssjt87buKK44uhfhPqf/NBhseny87XvoNM0JmhT17USBeRdWa+DkXMRSXqpOn6sLA3HcPSmwqhs9LCFxetx4vdAXQBz0OEEJ28EkY5/GiKqmNVre9PzmT2oVNFCN2taDYlVCgISadbpYT3PuG1XJio1MPyW/j0raun3bHaCjASicb5pBimuHzVIg9LVbpFKUVfi3Fbvx5qUGFnqeRk5WENKu/bXTLgxh3fDyawPCET/T6Fck1zQcMO7fELrg+KGxVE6I0JSiKsz/QqniZGioqQkgS1UCLG4WuoanszzMr/Uit1QmY/Xcu5BBTCPq1IFNvBPwSPVPVlSxpqIHthPWuJMcjd2vZfK9WGQqf4ydRUoS6aTRub1eiiC8cwI5rHZ4akyv6tkPng6Ci3O8w+v3hgWaq2cx1xYoyhWQw5eIrowJx9UiZLCmTqj3OM3d3+kz36lxL44ntDSgn8sxqcSYOSc2isDHLZL68gIUB52MMKBbXS1uB2CakJ/QeymtnCaLB8MWfFQFUlIUOX5LGmypiHp6zVUkkH8Dwjqpe3XEmbtgJBR6ZXggTWkUk5U6xFO58UF9KjDzuoNic65jC4F+pMCyLfCQGVmRy4SGBBnMQGQWFgmMp4TiDjMMbqL6SpQG2b/R1oEJuC+Ztiy53+5UyVCNk/VP1UDE/PsNLCHpAG2zVznsUhVrxXs5GUcOhAi6o63qGnrXtN5gtdO90/YDVtXg9rBKLJ2P65K1NpWdJsoSkskJU5p6nPjDPkIkGveZv6bt8w4GJGO6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(40470700004)(46966006)(36840700001)(9686003)(110136005)(47076005)(336012)(40460700003)(26005)(54906003)(82310400005)(186003)(316002)(52536014)(107886003)(83380400001)(86362001)(5660300002)(70586007)(2906002)(81166007)(40480700001)(55016003)(36860700001)(478600001)(6506007)(7696005)(8936002)(4326008)(8676002)(41300700001)(70206006)(33656002)(356005)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:43.1731 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e97b436-4e69-4ff1-e0cb-08da5f216f47 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2165 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGJlZW4gc3RhbGUgZm9yIG1vcmUg dGhhbiBhIG1vbnRoLCB3aXRoOg0KDQpQYXRjaCAjMSBoYXMgc29tZSBkaXNjdXNzaW9ucyBpbiB0 aHJlYWQuDQpQYXRjaCAjMiAjMyAjNCBuZWVkIHNvbWUgZmVlZGJhY2sgZnJvbSBtYWludGFpbmVy cy4NCg0KU28gc2VuZGluZyB0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJlbWluZGVyLiBUaGFua3Mh DQoNCktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N Cj4gU3ViamVjdDogW1JGQyBQQVRDSCAwLzRdIEludHJvZHVjaW5nIGEgY29tbW9uIHJlcHJlc2Vu dGF0aW9uIG9mIGJvb3QgaW5mbw0KPiANCj4gVGhpcyBzZXJpZXMgc2VydmVzIGFzIGEgcHJvcG9z YWwgdG8gYXJyaXZlIGF0IGEgY29tbW9uLCBjcm9zcy1hcmNoaXRlY3R1cmUNCj4gd2F5DQo+IGZv ciBib290IGluZm9ybWF0aW9uIHRvIGJlIHJlcHJlc2VudGVkIGR1cmluZyBzdGFydHVwLiBUaGlz IHByb3Bvc2FsIGlzDQo+IGRlcml2ZWQNCj4gZnJvbSB0aGUgc3RydWN0dXJlcyBkZXZpc2VkIHRv IHJlcHJlc2VudCBoeXBlcmxhdW5jaCBib290IGluZm9ybWF0aW9uLiBUaGUNCj4gaHlwZXJsYXVu Y2ggYm9vdCBpbmZvcm1hdGlvbiBzdHJ1Y3R1cmVzIHRoZW1zZWx2ZXMgd2VyZSBiYXNlZCBvbiB0 aGUgYm9vdA0KPiBpbmZvDQo+IHN0cnVjdHVyZXMgdXNlZCBieSBBcm0gYW5kIGRvbTBsZXNzLiBB IHNpZ25pZmljYW50IGVmZm9ydCB3ZW50IGludG8gZW5zdXJpbmcNCj4gdGhlIHN0cnVjdHVyZXMg YXJlIGFibGUgdG8gc3VwcG9ydCBkb20wbGVzcyBhcyB3ZWxsIGFzIGh5cGVybGF1bmNoLg0KPiAN Cj4gQXJtIGFuZCB4ODYgYm90aCBoYXZlIGFyY2ggc3BlY2lmaWMgaW5mb3JtYXRpb24gdGhhdCBt dXN0IGJlIHJlcHJlc2VudGVkLg0KPiBUaGUNCj4gYXBwcm9hY2ggaGVyZSBzb3VnaHQgdG8gc3Vw cG9ydCB0aGlzIHRocm91Z2ggYXJjaCBzdHJ1Y3R1cmVzIHdoaWxlDQo+IGF0dGVtcHRpbmcNCj4g dG8gbWF4aW1pemUgd2hhdCB3YXMgcmV0YWluZWQgaW4gdGhlIGNvbW1vbiBzdHJ1Y3R1cmVzLiBG b3IgdGhpcyBzZXJpZXMsIHRoZQ0KPiBmb2N1cyB3YXMgb24gY29udmVydGluZyB4ODYgb3ZlciB0 byB0aGUgbmV3IGJvb3QgaW5mbyBzdHJ1Y3R1cmVzLg0KPiANCj4gVGhlIG1vdGl2YXRpb24gZm9y IHRoaXMgc2VyaWVzIGlzIGR1ZSB0byB0aGUgZmFjdCB0aGF0IHRoZSBtdWx0aWJvb3QgdjENCj4g c3RydWN0dXJlcyB1c2VkIGJ5IHg4NiBhcmUgbm90IHN1ZmZpY2llbnQgZm9yIGh5cGVybGF1bmNo LiBJbiB0aGUgcHJldmlvdXNseQ0KPiBzdWJtaXRlZCBoeXBlcmxhdW5jaCBSRkMsIHRoaXMgd2Fz IG1hbmFnZWQgYnkgd3JhcHBpbmcgdGhlIG1iIHN0cnVjdHVyZXMNCj4gaW5zaWRl4o6EIHRoZSBo eXBlcmxhdW5jaCBzdHJ1Y3R1cmVzLiBUaGlzIGF0IGJlc3Qgd2FzIGNvdWxkIGJlIGNvbnNpZGVy ZWQNCj4gY3J1ZGUsIGJ1dCByZWFsbHkgaXQgd2FzIGp1c3QgYSBoYWNrLiBPbmUgb2YgdGhlIGdv YWxzIG9mIGh5cGVybGF1bmNoIGlzIHRvDQo+IHVuaWZ5IGFzIG11Y2ggYXMgcG9zc2libGUgd2l0 aCBkb20wbGVzcyB0byByZW1vdmUgYW55IHVubmVjZXNzYXJ5DQo+IGR1cGxpY2F0aW9uLg0KPiBB ZG9wdGluZyBhIGNvbW1vbiByZXByZXNlbnRhdGlvbiBmb3IgYm9vdCBpbmZvcm1hdGlvbiB3aWxs IHByb3ZpZGUgYSBzb2xpZA0KPiBmb3VuZGF0aW9uIGZvciB0aGlzIHVuaWZpY2F0aW9uLiBUaGUg YWRkZWQgYmVuZWZpdCBpcyB0aGF0IGluIGZldyBwbGFjZXMgdGhpcw0KPiB3aWxsIGVuYWJsZSBh biB1bm5lY2Vzc2FyeSBhcmNoIHNwZWNpZmljIHZlcnNpb24gb2YgbG9naWMsIFhTTSBmb3IgZXhh bXBsZQ0KPiB3b3VsZCBiZSBhYmxlIHRvIGRyb3AgYXJjaCBzcGVjaWZpYyBpbml0IGZ1bmN0aW9u cy4NCj4gDQo+IFRoaXMgc2VyaWVzIGJlaW5nIHN1Ym1pdHRlZCBhcyBhbiBSRkMgZHVlIHRvLA0K PiAqIHRoZSBudW1iZXIgb2YgZGVzaWduIGRlY2lzaW9ucyBiZWluZyBtYWRlIHdpdGhpbiB0aGUg c2VyaWVzDQo+ICogdGhlIGxpbWl0ZWQgdGVzdGluZyBhYmxlIHRvIGJlIGNvbXBsZXRlZA0KPiAq IGhvdyBleHRlbnNpdmUgdGhlIGNoYW5nZXMgd2lsbCBiZSBmb3IgeDg2DQo+IA0KPiBOQjogVGhp cyBzZXJpZXMgaXMgYnVpbHQgb24gdG9wIG9mIHRoZSB2MiBwYXRjaCBzZXJpZXMsICJ4c206IHJl ZmFjdG9yIGFuZA0KPiBvcHRpbWl6ZSBwb2xpY3kgbG9hZGluZyIuDQo+IA0KPiANCj4gRGFuaWVs IFAuIFNtaXRoICg0KToNCj4gICBrY29uZmlnOiBhbGxvdyBjb25maWd1cmF0aW9uIG9mIG1heGlt dW0gbW9kdWxlcw0KPiAgIGhlYWRlcnM6IGludHJvZHVjZSBnZW5lcmFsaXplZCBib290IGluZm8N Cj4gICB4ODY6IGFkb3B0IG5ldyBib290IGluZm8gc3RydWN0dXJlcw0KPiAgIHg4NjogcmVmYWN0 b3IgZW50cnlwb2ludHMgdG8gbmV3IGJvb3QgaW5mbw0KPiANCj4gIHhlbi9hcmNoL0tjb25maWcg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDEyICsrDQo+ICB4ZW4vYXJjaC9hcm0vaW5jbHVk ZS9hc20vc2V0dXAuaCAgICAgICAgICB8ICAgNSArLQ0KPiAgeGVuL2FyY2gveDg2L2Jvb3QvYm9v dF9pbmZvMzIuaCAgICAgICAgICAgfCAgODEgKysrKysrKysNCj4gIHhlbi9hcmNoL3g4Ni9ib290 L2RlZnMuaCAgICAgICAgICAgICAgICAgIHwgIDE3ICstDQo+ICB4ZW4vYXJjaC94ODYvYm9vdC9y ZWxvYy5jICAgICAgICAgICAgICAgICB8IDE4NyArKysrKysrKysrKy0tLS0tLQ0KPiAgeGVuL2Fy Y2gveDg2L2J6aW1hZ2UuYyAgICAgICAgICAgICAgICAgICAgfCAgMTYgKy0NCj4gIHhlbi9hcmNo L3g4Ni9jcHUvbWljcm9jb2RlL2NvcmUuYyAgICAgICAgIHwgMTM0ICsrKysrKysrLS0tLS0NCj4g IHhlbi9hcmNoL3g4Ni9kb20wX2J1aWxkLmMgICAgICAgICAgICAgICAgIHwgIDEzICstDQo+ICB4 ZW4vYXJjaC94ODYvZWZpL2VmaS1ib290LmggICAgICAgICAgICAgICB8ICA5NiArKysrKy0tLS0N Cj4gIHhlbi9hcmNoL3g4Ni9ndWVzdC94ZW4vcHZoLWJvb3QuYyAgICAgICAgIHwgIDU4ICsrKyst LQ0KPiAgeGVuL2FyY2gveDg2L2h2bS9kb20wX2J1aWxkLmMgICAgICAgICAgICAgfCAgNDIgKyst LQ0KPiAgeGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2Jvb3RpbmZvLmggICAgICAgfCAgNDUgKysr KysNCj4gIHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9iemltYWdlLmggICAgICAgIHwgICA1ICst DQo+ICB4ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vZG9tMF9idWlsZC5oICAgICB8ICAxNSArLQ0K PiAgeGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2d1ZXN0L3B2aC1ib290LmggfCAgIDYgKy0NCj4g IHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zZXR1cC5oICAgICAgICAgIHwgIDE0ICstDQo+ICB4 ZW4vYXJjaC94ODYvcHYvZG9tMF9idWlsZC5jICAgICAgICAgICAgICB8ICAzNCArKy0tDQo+ICB4 ZW4vYXJjaC94ODYvc2V0dXAuYyAgICAgICAgICAgICAgICAgICAgICB8IDIzNCArKysrKysrKysr KystLS0tLS0tLS0tDQo+ICB4ZW4vY29tbW9uL2VmaS9ib290LmMgICAgICAgICAgICAgICAgICAg ICB8ICAgNCArLQ0KPiAgeGVuL2luY2x1ZGUveGVuL2Jvb3RpbmZvLmggICAgICAgICAgICAgICAg fCAxMDEgKysrKysrKysrKw0KPiAgeGVuL2luY2x1ZGUveHNtL3hzbS5oICAgICAgICAgICAgICAg ICAgICAgfCAgMjYgKystDQo+ICB4ZW4veHNtL3hzbV9jb3JlLmMgICAgICAgICAgICAgICAgICAg ICAgICB8ICAyMiArLQ0KPiAgeGVuL3hzbS94c21fcG9saWN5LmMgICAgICAgICAgICAgICAgICAg ICAgfCAgNDQgKystLQ0KPiAgMjMgZmlsZXMgY2hhbmdlZCwgODA0IGluc2VydGlvbnMoKyksIDQw NyBkZWxldGlvbnMoLSkNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vYXJjaC94ODYvYm9vdC9i b290X2luZm8zMi5oDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2FyY2gveDg2L2luY2x1ZGUv YXNtL2Jvb3RpbmZvLmgNCj4gIGNyZWF0ZSBtb2RlIDEwMDY0NCB4ZW4vaW5jbHVkZS94ZW4vYm9v dGluZm8uaA0KPiANCj4gLS0NCj4gMi4yMC4xDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361872.591643 (Exim 4.92) (envelope-from ) id 1o8zc0-00007g-Hz; Wed, 06 Jul 2022 07:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361872.591643; Wed, 06 Jul 2022 07:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zc0-00007M-Be; Wed, 06 Jul 2022 07:38:16 +0000 Received: by outflank-mailman (input) for mailman id 361872; Wed, 06 Jul 2022 07:38:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zVI-0004kS-52 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:31:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2074.outbound.protection.outlook.com [40.107.104.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a068faae-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:31:19 +0200 (CEST) Received: from DB3PR06CA0007.eurprd06.prod.outlook.com (2603:10a6:8:1::20) by VE1PR08MB4735.eurprd08.prod.outlook.com (2603:10a6:802:a2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 07:31:01 +0000 Received: from DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::55) by DB3PR06CA0007.outlook.office365.com (2603:10a6:8:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Wed, 6 Jul 2022 07:31:01 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT027.mail.protection.outlook.com (100.127.142.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:30:59 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 06 Jul 2022 07:30:59 +0000 Received: from dbf3161c1f77.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7683D487-A868-4F6A-A518-536AA0D072E6.1; Wed, 06 Jul 2022 07:30:54 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dbf3161c1f77.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5815.eurprd08.prod.outlook.com (2603:10a6:10:1ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:30:51 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a068faae-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Lb5Yqs+P764uUXb2NrEughZdi0uMcL8FfU5JP4UutzFDhTXeJ9GTjrIlSG1yXAlVZudrg2vc182jsogNFss5DJkFV8Lh6Keky6U69rcwHiai3+zwfYwAw60XpHzOEklxdd1Gq6mwbs5Z4tObwBzuYwCQH9L9rxpvloOXDIKq62chx86imbiXdP02DfZ+rQGTcG/+/cRZ6IF0jmzqGbliztHRSmeyha+pPzMWPEWmMod3GNFZ/B1SbQYNZK/mf2fzBChrifKP/sL3n+ove63mFmoKVmH5fGWNo0tNPxfI6cjSRwVDR2bdLC1TWvdmE9cBURKUb+o52+SsZKtWdkJEeQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fEeGXJccAL/byznBojSUr6mFpv4OGH8k+PzD7qmDYh0=; b=XR2jlAnbf10FZnnorO4rHxL0yBA6AWZAzekGu6PWiA98LaB6y0IggY9e5DE/Kt4S2xxNNJRrZHZZ8jEK1B1PZZz8PyyOSxkVWgAXZjlCup2EVNgWQfBjne9XA2dTMTbafXZTTYvcnaEW8hZIsepdThARav9fX5WMe2vq0sey+ZHzp9Mdp0ocMc2WX8xFcKQuGMAcOgEO2r+HuqBitJ6RuuS9wB2SvF1yhywe3Vz/27w69ELFFoOKVPUXm6gZVkqRWU7N9R36DfHsCU6+JgRhUX5PpQVyglCAR9pYobNmFqgjuPwhV1ZlGrZaLIuP9Gz0yqfnpt1ssTmPrjQH9NHXKw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fEeGXJccAL/byznBojSUr6mFpv4OGH8k+PzD7qmDYh0=; b=8dKWbKU0oJNcRSJmPgV4To93wsP1YxCgaNBOUsjfGy/suAFtLV4zs5GwLK7eOlRAjYvq5M7fo3GpJnTBWh6stOhh7aJWgQ0qfSjRjJ1hO4KPtamrUQie9FY8HX+jtOsE9CZB+tVd6XNZHDsujHgCwmGmVcWAv1nzrQZRNmvSz9Y= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTXH4QgNrik7/NXIGklP0oLFlp12IC5GIcytKShGQQJvynpoJfjC7hAhQMuS6TFsOD72qfoNUlc7IdrVa0WZWJI2Y/zBfDuY6/LmT9J/PN6pb27eTeiQbcUkcQ5uNUhRwCslR2lue2UVovecsFm5FcKs2ZjCOzrC4ZYGpP6WJCeOzKl1+4AftDg/JatvXKRCpGcc10Du6bWCuVCIUvdRIwc+SOx6PTHOxzphBbUgGpji9E9Tlia3PZEdaI04R87DMQuYb9gkOBI/anQX/5hlgV+gaDa5GrzSy1jSV+vsFzLjf1bQ4xls6FnLj6mqBhhA3xwyK1cvHDNCu63ApUbPvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fEeGXJccAL/byznBojSUr6mFpv4OGH8k+PzD7qmDYh0=; b=N3czYBACFAwwGK7LdWwX6lqhzKzr3VNKC0wFaBoXxqECvzBDrb8uxCAFH4LsWrNSiVGH7iAuwXXikbg9xUctj0Y/EM4GPivMZtTVLcCV2YUrdG276XaNX7EA59VnJrCImmwz0Jfe3Ugw6WYSTlgHoUz2atdOlJcbBpio7Gr3TwUjE8/es+Z+NtB7KBZANE0zfZxWhD37yn+Rw9DdlS0dOAUAh6IGE1vzqMqeOYxHJ80sOXPQ5uydcsCprSEo3e9O03RaI55avhHmoBwJMy42k7GwYcZC634nGTMdSBIauAQ/Hyfhf39Ow0Mp9H+HfE2/jpDcirF4HC5iwCfKVsxPDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fEeGXJccAL/byznBojSUr6mFpv4OGH8k+PzD7qmDYh0=; b=8dKWbKU0oJNcRSJmPgV4To93wsP1YxCgaNBOUsjfGy/suAFtLV4zs5GwLK7eOlRAjYvq5M7fo3GpJnTBWh6stOhh7aJWgQ0qfSjRjJ1hO4KPtamrUQie9FY8HX+jtOsE9CZB+tVd6XNZHDsujHgCwmGmVcWAv1nzrQZRNmvSz9Y= From: Henry Wang To: Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= CC: Jan Beulich , "xen-devel@lists.xenproject.org" , Wei Liu Subject: RE: [PATCH v2 0/2] x86/mwait-idle: (remaining) SPR support Thread-Topic: [PATCH v2 0/2] x86/mwait-idle: (remaining) SPR support Thread-Index: AQHYdmtKDptcnBqdZkW5lEZmH5/NwK1xIxhw Date: Wed, 6 Jul 2022 07:30:51 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1C88DD95D85EAA4F8B89881FE9607025.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 102f38db-f5e8-420d-2250-08da5f217925 x-ms-traffictypediagnostic: DBAPR08MB5815:EE_|DBAEUR03FT027:EE_|VE1PR08MB4735:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: T0YYz0KU2z+1Uf7BteLdfZQvNqpW+YeIFRrTRfiULXXpERT0oKHrUnjtjjeGrNr7d/erJr6X7yEOsUGHv3CiUUY3NFwXivVu9AsD1GctXf3dLCVVStEBPSMlayjObajQpm9Qsxr5PzbA9JTvOyms0u1BIwMGXNi0skV5tUY/lcDSVgbmXGheaUifTyjKpY853bI4YdT5kRu7xPh7S5PciGhPwMgYceTkuoS2puZyR5a0tkdHQcoTR2oVOFpXzN/gBDc81A/Gp6SIi3xyLF6uhf85xuz6jxxttQzl1Y1WmLFBvtRvkJk7qIiUoCtYlNWJsV/RkUxfzXy22LO1FNGyMSHQsBaePpjVRuFvZQWKetDEICnegC1uzF8d8EQQ/ymvHYyFtlLXsyGa96mnb42e5u5UA2tggcW9Vd1ZK/w4AO2h5DqkiYbJLmGI4F5FMxdifXtex15+ON4ypcusrwr9CXYv+u5a1ATDhiUmRcf7rWCtQ4bJdqymMGsO6TGcUgqW7ylbDHV7OgYSnPJsqlcv7Mkijm86w1789g38UmDJFse9lrtsW1UAxV9uF0L4ehQaOQI2EFDcBphTDC5Ut54aEJICiHfk61QPRSVLKQBWzrY6A3PEOj6UkI5Zs8l9+6LBQ9x+/WnUXv6P34HVx1QPGSn0prut1iNCI9liGk+bAbjVIopKUX0dWwXufA/ilgPTcmkQnMwjx4zTyxMhhvoE6ixlqZpbgy0gkcXpGmYtZ0BClyu8lcq11doUiSfvSA4BVfqfr+18OGvEvSISpXdPFEiKtObpI/pI9QDeNHUp6M0lGXbr+wW/UQx4Xiw97gd8JD0BO7TisJqY+qi12Kft84G/vHuqaKV5ziuS8ftEVJU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(110136005)(966005)(478600001)(54906003)(41300700001)(71200400001)(9686003)(55016003)(26005)(4744005)(316002)(52536014)(122000001)(8936002)(5660300002)(38070700005)(86362001)(186003)(8676002)(66556008)(4326008)(66476007)(66446008)(64756008)(66946007)(76116006)(38100700002)(7696005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7c33ea91-684d-4b7b-3a79-08da5f21747b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fGKfqRHmFV+X84KEmHMKK34VUuYjAfwIOHqFlK92Pyc37tKHm15wLMHehZuVJXGLeclfaUxrGANoFtfdhRRJPo7cc///a/NZbaAMvK6gbjZHiA58mlTYGpNRXtt03BcdQw73JQBLtDs+RaFBT97zXbNF2VrQZsM1e0zoNYE3ErQ6N436dBRP0igChxLKEkPCI3C2wxqJmRgElRa/Xaq05sgmVwgUvgLQ5wU+CEdaE7BgCVc3OsFRoDG1GChNGc5KBXPia1o0QVFHQPoUlFw9MyQZ+sOXjiOrFW2f5Hp89IhvignwZIDVsjgRXTr6beXz0k/SHFKOKXqtppkKoG+0Ip1i0cAdtiN448dnUvDPUFqUaFm4JFXFvp9d1vrWN0d01VPB9BUa7l8kJTZva9CSYBsNtVrW9weKEt4nuetGF44QMobit0PZMPTb/uoqrzbAvnTCe+H0koGRwI8v3IcZSCguoqiKsIzdRWOSo7Q2SctOJrwVweklR4BePfdtReR8v1zaeDt+wCnugxgjK53Thq2D9s7oS0oYaDUQGdAQgs/vJeC+/wFlJ6i8UsYIzDG+gmJsBcwLR4x/9GU+Bh4BpolWkqJbc8sEc2FGkXZA7V5Qhy2mPnidFR0RUeF0IBdHHQlZV6hEht55ED/DGIIEbVP8zeJZ+sScxuExOUS0yrUnJ2q9wXkw3cPZ9G+zsDDGiCaV4bGmJZvHQDmv5Y1xZCbVVulB9xfW0kACknGOjlvT3cbaNj2f0/BZQ1OwoQa9pcog0rFjgKP8zzlbt2KgP45RYKptv38QXXOhuIvTZYym/lKCuLCJUpUTKWL3UYE58X+RyFoJECEKNPP//tzbIdP482GJVJIIMNBphI4lnTU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(36840700001)(40470700004)(9686003)(47076005)(336012)(70206006)(8936002)(52536014)(4326008)(8676002)(70586007)(5660300002)(41300700001)(7696005)(33656002)(86362001)(55016003)(40480700001)(82310400005)(6506007)(2906002)(966005)(186003)(26005)(478600001)(82740400003)(83380400001)(81166007)(356005)(316002)(40460700003)(54906003)(110136005)(4744005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:30:59.7382 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 102f38db-f5e8-420d-2250-08da5f217925 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4735 SGkNCg0KSXQgc2VlbXMgdGhhdCB0aGlzIHNlcmllcyBoYXMgYmVlbiBzdGFsZSBmb3IgbW9yZSB0 aGFuIGEgbW9udGgsIGFuZA0KYWN0aW9ucyBhcmUgbmVlZGVkIGZyb20gbWFpbnRhaW5lcnMgZm9y IFBhdGNoICMxIFsxXS4gU2VuZGluZyB0aGlzIGVtYWlsIGFzDQphIGdlbnRsZSByZW1pbmRlciBh Ym91dCB0aGF0LiBUaGFua3MhDQoNClsxXSBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3By b2plY3QveGVuLWRldmVsL3BhdGNoLzQ2YzZiZjYxLTU2NjktMGRlMi0xNjNkLTY0YjlhM2NlMDdh N0BzdXNlLmNvbS8NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0ggdjIgMC8yXSB4ODYvbXdhaXQtaWRsZTogKHJl bWFpbmluZykgU1BSIHN1cHBvcnQNCj4gDQo+IFN0aWxsIHByZXR0eSBmcmVzaCBmcm9tIExpbnV4 IDUuMTggKGFuZCB3aXRoIGFkanVzdG1lbnRzIHRvIGFkZHJlc3MgaXNzdWVzDQo+IG5vdGljZWQg d2hpbGUgcG9ydGluZy4NCj4gDQo+IDE6IGFkZCAncHJlZmVycmVkX2NzdGF0ZXMnIG1vZHVsZSBh cmd1bWVudA0KPiAyOiBhZGQgY29yZSBDNiBvcHRpbWl6YXRpb24gZm9yIFNQUg0KPiANCj4gSmFu DQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361870.591625 (Exim 4.92) (envelope-from ) id 1o8zbx-0008Eb-Tt; Wed, 06 Jul 2022 07:38:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361870.591625; Wed, 06 Jul 2022 07:38:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zbx-0008EU-QO; Wed, 06 Jul 2022 07:38:13 +0000 Received: by outflank-mailman (input) for mailman id 361870; Wed, 06 Jul 2022 07:38:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zVX-0004kS-BI for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:31:35 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150047.outbound.protection.outlook.com [40.107.15.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a98a22a3-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:31:34 +0200 (CEST) Received: from AS9PR06CA0316.eurprd06.prod.outlook.com (2603:10a6:20b:45b::25) by PAXPR08MB6560.eurprd08.prod.outlook.com (2603:10a6:102:12d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:31:33 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b:cafe::3d) by AS9PR06CA0316.outlook.office365.com (2603:10a6:20b:45b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:31 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 06 Jul 2022 07:31:31 +0000 Received: from d1992e24f0f4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA05B18E-897A-4CB4-9AAD-5B92C76D8FE5.1; Wed, 06 Jul 2022 07:31:25 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d1992e24f0f4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:31:25 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5815.eurprd08.prod.outlook.com (2603:10a6:10:1ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:31:23 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:31:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a98a22a3-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WrT5Oeo+YmyW5AVln73GmbVxBfknq+7b+7JzyAcFvQgOOLN5LBJqyqKn5rgpuYOguaZvg72aPXIsADKjt7EH25f5OPDKIYLNhLMVJcWh95jqC2vkYk+5rY0VT6/8siPJFyFKqSmPc12WBEGnw0JXpBi8Svnj2hPRgmaro22UPRq6/8LHfmMZHpyR7MPe1f1dIW7OMFEiV5pyx+Oo4hU2bzcDrAi0rkmpk+7RZT1E0K5LK5kTdKO+CXk5/ApqJGjG+tVWGWbvLR8FqZNA1NeKNrI3kahXCCqiQbZWTTf2r7GNR/Eo7lh07gbSh7KMOO6ffhpyQM8iv34iivXUXr8pow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0mHbNVx+Un0Ik5RuG8EjPbpZ0HrPLz5hsyKRWCcf1Es=; b=e8vEhE2JpoQkLBhKW11Kahf5v7kJN/GOZ4u3iQb8z35BiiAKq8ANVbhu9D1yZKKdtTfiOd41rQ5LW7bTzf7khH3U91N9zrWCLltShOmVvfrrOJiJcoSAZ1bO6kDSJg4kBXhf+LVmLP827GyKzbzxXbHc3nRiWBAYmCGJ+ZObPhrjDUaJPznBmpBXFyMVv1Q0cYrh3bv7/bKEEr27aiMXsj1/m6OOHsy8pzHUeQ36mIqVww0q6ehf3pqn5b8034mNZeTG/FG1fixXuwo8dkwDUPovMGpFWhKpa7gYsd4Z+tm4C7f2ZegLalV7qiZMZuMDsslDH4c66lmDuJo0SU5u6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0mHbNVx+Un0Ik5RuG8EjPbpZ0HrPLz5hsyKRWCcf1Es=; b=FHPHy8cBvuuFQWeMc+NGnS5GY4HrfwNaXA+r3ziKRgL+CfIo25ZdBdM0Zqvh0XAg4U96Wg5C28V0Y9zsyOwRXZTi56vjyRLItM/T7pOLbhRD9sakBRNeaMK1iNh20qIbywCKzvT6iqkFngKPjGjsMHemQkGvwzsKCc8mGEN8ekw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FFFSKD/541fYeaC5hetTQdi6djhoBqkpHcE5ZX5sHhvkWRLxaYlbfma5godrDs7nJHxgcX8QtJlAY0R9Q5CdH5OkxCdsl9Ka5UZDjn7bSl0HDwhuWlrJ3Nmi8Pa4oXLvCTYcECJFx8nNorug1vEDk9IV8x71R5zBplP19iHZxXZ9bi1DTvZR2um/tJBfH6ynF+QGc3MW3QVNLR98sJT8tQHVoBCLNDcPAFIR5yZU/oa6XQ1boeEyMnDe4dLPFC8N5NlwcyKAWY+NhkSkiZ4Y7I/fD/DuFSxbbWa2KklPtJ3NMvtNyb1KCh9Wpp/8d6vAlXYob2/g6XvDG/RC0Tt41Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0mHbNVx+Un0Ik5RuG8EjPbpZ0HrPLz5hsyKRWCcf1Es=; b=WZugPG2YF5Yn0m2bkTq4omTmucV8lTZhNMpwElgwQ8246OlwFFI8Gs/8OfEALHXygPq2b62h/6c0LFkpr8O+u6imiH87EtOLCiaHXh8gN/0dpFH/R5/1LzGKdbvhfXZj9GthSdB3i3BqwiDFWfDXpavZ/whoj3g+N3q4trN5GBT9SHU9k+CBjHXiTUAATmcI9Dl2ROd3bUaPJmZc7oaHiGIJ0op/+U6HDWlbpd/kAitZ8aH6N1QjtmFshTtZAYFAt+N/8gBnOzZMuLANM9nj2rwDm4RtltIdld9wBDOrLFiLtdj7nI2BFdOY77fDaY4IHUuTl6PsRN9aR4zlI9KT/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0mHbNVx+Un0Ik5RuG8EjPbpZ0HrPLz5hsyKRWCcf1Es=; b=FHPHy8cBvuuFQWeMc+NGnS5GY4HrfwNaXA+r3ziKRgL+CfIo25ZdBdM0Zqvh0XAg4U96Wg5C28V0Y9zsyOwRXZTi56vjyRLItM/T7pOLbhRD9sakBRNeaMK1iNh20qIbywCKzvT6iqkFngKPjGjsMHemQkGvwzsKCc8mGEN8ekw= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich Subject: RE: [PATCH 00/11] x86: support AVX512-FP16 Thread-Topic: [PATCH 00/11] x86: support AVX512-FP16 Thread-Index: AQHYgKKUofTsu/ArMEqHlGqkL58nDK1xEjhA Date: Wed, 6 Jul 2022 07:31:23 +0000 Message-ID: References: <9ba3aaa7-56ce-b051-f1c4-874276e493e1@suse.com> In-Reply-To: <9ba3aaa7-56ce-b051-f1c4-874276e493e1@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 00AF7A5FE3BCE9409F9D5F719378AC01.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a3e6169b-1631-4319-dd46-08da5f218c67 x-ms-traffictypediagnostic: DBAPR08MB5815:EE_|VE1EUR03FT003:EE_|PAXPR08MB6560:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D3r5haFif2a9x44qZ4wyTxBpk2azIHhu5UMjS4vwGT1kTAcCfqt7jHAikjyXV/XXXWtxYfLlc9IYXYBUfnzzTR+usYRDMxI74GJ9DgaDnxr+V7pqss64+gRNaxX6vVptrLBwikWmNYOFQGuKnF9/tXct5KhwhrqdY5BkdPIC5iBIAStlve9T9a+0QzWkQ9OwcTuzOhJ5jRt5TqtbgRlgmdaswPAGqjhsY1lnF++QLgAxq7FdrAw3SQ4aFidkE3jbrC1JsA+Riyh2004aUQnIKzLeCVZWkpSMk/Fuwagb/wJyg7LH8jZet2AB1IYuJBjO97O5PYHruSENs6PxAXKpj/JYEWziaggHPHtESaHR0QRODsTWWR1QD87ByXs8GV/R9KeUgbjkKagPqsNYH7o9zRihT2DmWBPqlIB9JklFljocJkHfjOBgyj1a6xIS18yzQKo+1lgTsSYarGQPp0rFFn0Ady7H5c7oeXakUCgvz1dEl6/HycsG6vWoXGzQkVsfxZZ1EUiXfCe4pPC/nborxYdLCO8S2lLYAjvpDE6ncGunnGMJ+HslLWI00TcXtPaFbNeGebThRJAeCx7UYo2ZbN6tcCUqSnf6iLqdbA55fZVOyAFwz8VTe6A+IYM9nr2Oru3lTn0TAslBKQIRt1xLAtX3tZBXN4SndtDjk6Du19ejUM09V3uqlS4aZSgAMK3Pk1Rgq0cMKHtDikCBYBzwY544Pdu4WdadfipkQodHQIY+3LnvCF7td4UiuLml87e6YMwXtiUdej7ey9kfCiWeidFOZoQOOVwa2Y9jGqWOznnNAOYPBXV2riTfl32XsuQJ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(478600001)(54906003)(41300700001)(71200400001)(9686003)(55016003)(26005)(316002)(52536014)(122000001)(6916009)(8936002)(5660300002)(38070700005)(86362001)(186003)(8676002)(66556008)(4326008)(66476007)(66446008)(64756008)(66946007)(76116006)(38100700002)(7696005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9a0a04b7-5665-433d-d4e0-08da5f21872a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kSEM78kcEAQWPlhACdrCalJjVl+G13Rn5O/PlYFOd04epFUi6tAdaLa0eSa9IYiHIdjQm0tKI2mgbYO69BIhJZq/P2KgNHwA7SJmaUM8B9jVEkowdES/NY2oezz7L+SSyTbRgUVFoSnMlPiEEZZLAPeXTnY1iXq8BFEqiT/GdclLLmGVa4DXahQQXVRZpT4CDlUinsM79+5fTZAssjz7I/jfhdbzqw0JXjWypm/a6SSYKCxEhT3kvUd3YEJOyUPpio2vYICPj9PF63D1a1GpKyIETCy1T1nMt+oH5huQtk8VJ0kxsTjTcNlNvn3h1yGuUmPFz9IUgMBcm8vQzeCT9wNOUWJhlkyimdbQuet0lI+FYh0zFURlIp+bBM120ODGDCawEprJ4+ABWYsstyNpPsE5eh67i7UxcH3gznEIdh4Cb4HqF+7x0xH74CZK/qxiITRczy6IZkp0GFQXETr/s2CPn/KLjOqfGOlGlb7w38VJ115YdLhHCOiZyrqCVQ6MMErGKKUazoseHR8SRe3YKR8pnZKdGncLt5aoCZIjeN6CBRV/SciygTQYulB8fjLLABxdPjjmRIL6OuHmNjcM7VYr7yIDJ1rdXNYZpLeJQAOrGHsUoiPK+gnZOd98o8flnZ7x4qiXmU4nm4K2cw4yMkMLHnQHuF9vucBaieJPeu6CDyYEcNA1KTEeK1Q+dojV/q5uCdirH0RMjOlEwZjcekRd0/Z+aMWAiAg/4lN4s7P0GOa5S1jWWlFGwjmKD985qpu8M4uuPvM5qWagnCCxkfN957qET4W3fljvf3FkXIVaKohPGBQ/T2G4Xyjb4iUV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(346002)(40470700004)(46966006)(36840700001)(36860700001)(86362001)(8936002)(5660300002)(83380400001)(107886003)(186003)(336012)(33656002)(356005)(81166007)(47076005)(82740400003)(6506007)(7696005)(478600001)(6916009)(316002)(9686003)(26005)(41300700001)(54906003)(70206006)(2906002)(70586007)(52536014)(8676002)(4326008)(55016003)(40480700001)(40460700003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:31:31.9273 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a3e6169b-1631-4319-dd46-08da5f218c67 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6560 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGJlZW4gc3RhbGUgZm9yIG5lYXJs eSBhIG1vbnRoLCB3aXRoIG5vdGhpbmcgaGVhcmQNCmZyb20gbWFpbnRhaW5lcnMuIFNvIEkgYW0g c2VuZGluZyB0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJlbWluZGVyIGZvciBtYWludGFpbmVycy4N ClRoYW5rcyENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0ggMDAvMTFdIHg4Njogc3VwcG9ydCBBVlg1MTItRlAx Ng0KPiANCj4gV2hpbGUgSSAocXVpdGUgb2J2aW91c2x5KSBkb24ndCBoYXZlIGFueSBzdWl0YWJs ZSBoYXJkd2FyZSwgSW50ZWwncw0KPiBTREUgYWxsb3dzIHRlc3RpbmcgdGhlIGltcGxlbWVudGF0 aW9uLiBBbmQgc2luY2UgdGhlcmUncyBubyBuZXcNCj4gc3RhdGUgKHJlZ2lzdGVycykgYXNzb2Np YXRlZCB3aXRoIHRoaXMgSVNBIGV4dGVuc2lvbiwgdGhpcyBzaG91bGQNCj4gc3VmZmljZSBmb3Ig aW50ZWdyYXRpb24uDQo+IA0KPiAwMTogQ1BVSUQ6IEFWWDUxMi1GUDE2IGRlZmluaXRpb25zDQo+ IDAyOiBoYW5kbGUgQVZYNTEyLUZQMTYgaW5zbnMgZW5jb2RlZCBpbiAwZjNhIG9wY29kZSBtYXAN Cj4gMDM6IGhhbmRsZSBBVlg1MTItRlAxNiBNYXA1IGFyaXRobWV0aWMgaW5zbnMNCj4gMDQ6IGhh bmRsZSBBVlg1MTItRlAxNiBtb3ZlIGluc25zDQo+IDA1OiBoYW5kbGUgQVZYNTEyLUZQMTYgZm1h LWxpa2UgaW5zbnMNCj4gMDY6IGhhbmRsZSBBVlg1MTItRlAxNiBNYXA2IG1pc2MgaW5zbnMNCj4g MDc6IGhhbmRsZSBBVlg1MTItRlAxNiBjb21wbGV4IG11bHRpcGxpY2F0aW9uIGluc25zDQo+IDA4 OiBoYW5kbGUgQVZYNTEyLUZQMTYgY29udmVyc2lvbiB0by9mcm9tIChwYWNrZWQpIGludDE2IGlu c25zDQo+IDA5OiBoYW5kbGUgQVZYNTEyLUZQMTYgZmxvYXRpbmcgcG9pbnQgY29udmVyc2lvbiBp bnNucw0KPiAxMDogaGFuZGxlIEFWWDUxMi1GUDE2IGNvbnZlcnNpb24gdG8vZnJvbSAocGFja2Vk KSBpbnR7MzIsNjR9IGluc25zDQo+IDExOiBBVlg1MTItRlAxNiB0ZXN0aW5nDQo+IA0KPiBXaGls ZSBJJ3ZlIHJlLWJhc2VkIHRoaXMgYWhlYWQgb2YgdGhlIGFsc28gcGVuZGluZyBBTVggc2VyaWVz IChhbmQsDQo+IG9idmlvdXNseSwgYWhlYWQgb2YgdGhlIG5vdCBldmVuIHN1Ym1pdHRlZCB5ZXQg S2V5TG9ja2VyIG9uZSksIHRoaXMNCj4gc2VyaWVzIGlzIGludGVudGlvbmFsbHkgYnVpbHQgb24g dG9wIG9mICJ4ODZlbXVsOiBhIGZldyBzbWFsbCBzdGVwcw0KPiB0b3dhcmRzIGRpc2ludGVncmF0 aW9uIiwgd2hpY2ggaGFzIGFscmVhZHkgYmVlbiBwZW5kaW5nIGZvciBmYXIgdG9vDQo+IGxvbmcu DQo+IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:38:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:38:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361871.591637 (Exim 4.92) (envelope-from ) id 1o8zc0-0008VT-60; Wed, 06 Jul 2022 07:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361871.591637; Wed, 06 Jul 2022 07:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zc0-0008VE-2W; Wed, 06 Jul 2022 07:38:16 +0000 Received: by outflank-mailman (input) for mailman id 361871; Wed, 06 Jul 2022 07:38:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zV4-0004kS-Lv for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:31:06 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30066.outbound.protection.outlook.com [40.107.3.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 985978ef-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:31:05 +0200 (CEST) Received: from DB3PR06CA0016.eurprd06.prod.outlook.com (2603:10a6:8:1::29) by AM9PR08MB6258.eurprd08.prod.outlook.com (2603:10a6:20b:287::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:31:03 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:8:1:cafe::f3) by DB3PR06CA0016.outlook.office365.com (2603:10a6:8:1::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:03 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Wed, 06 Jul 2022 07:31:03 +0000 Received: from 65e009a5c745.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA90A612-7718-4116-9470-D0F58085649A.1; Wed, 06 Jul 2022 07:30:57 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 65e009a5c745.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:30:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5815.eurprd08.prod.outlook.com (2603:10a6:10:1ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:30:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:30:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 985978ef-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cdGc9UiyHblvKunEJlXwXo1qGEv7FLDLFOi/u4XX13QuIcwWS71acpZT6NXKMd/10buQfBXHFUZS6ZZuMUHaMy63pawneHiFj/A9PwbyG84tViRHy5FcObjguGWjzM+go6pnMgnGJl2uJZgUseQsERcnSB+aMD28+F67gCDl1rKYyUUU6OHI61IUi1RrRQAPd56Wc4Xuqt3uUTdfwlbF95Mgvcqy3bD0w9BbUnzFmOs1vEXRXofhR69dkZhHNJe3ukjz75BlxVK/rUFUo8831jhuU+r4qibqTsKtIvMnGh47GIGqmWCL5WhRfOS5LH3s7VdAAryMZhMeMzqP4Dh2/Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mtvuUTHfMa9WQStmKLwcS73WtGEOGr1Z5Cx9umayByU=; b=lLGml07AncToljoiKFTKKqByT8hQJzQRxthO3NK96x1iGZFuSKPV8x2MIIebTB3MNd0oBcsoaB7aMzSZ5ILT5+sX/+ahUqihqG7OglurqQ/fZMX+Cw8Oa4BfP48EYIh+ksn2TiTk1n77vnJ4EIEjk/k2d+d9JVxjs3TgTvREVnIV5S5BYaKCeoYG6zA6VVjSOCD/bRxrsKXXirrrhn/ouaqV4hwEx8OTp3ZFVlsq7z7TQN2CX1pHh09We/IWg1N4kUR7yoxLp09mo5HbogGJ5G09vWhDuXfTodvq+w3jmDDrXQpNE7l1ESere29fuNrKVEr0HTFzIn9nTip+pKyzOA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mtvuUTHfMa9WQStmKLwcS73WtGEOGr1Z5Cx9umayByU=; b=oZ7SnARYR60nbp61Tpeb37YJd3FWdWxFY/1KBX+gfvTgOe0JwLzYrzuo/sSz7Sa7jNAW2k60GvdQain2KHB+Hlb2co5/trmX9N2sZlujEq8ekze0nVluOWKz9UZ6DR4uKlQy18TDja2SNVUynEt+V8r3L+wMtUi6l5BgAt20aBw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BFCSniWUxu9uz1v4ijp5b4QQeFDnuO7bc4JXg/vTDEHst9vp5lCcuDIOVkfMULkdg3LeW9dE3Dky1kqMlLq1SqVlSDNfOa/gyQtFZZgeZJ8mLbQHL4qrF0lsH016ohVPderfAHuOgsBOABnvILUsTer4oNVyLFniu6Rg+sRi47CyusAP+0tLSK1xtloGzUvVJm/mDGRSXtN3PACU8mP09dUWtb/63Lb1nWXNmeMLEb6/nrk/CBy3y48GpPKv+py09dMn5XYO2e/XRDD/5c5PRmhh5Uu+RY59agKrLMuzxJ/IXdbWaBfmNW2d1k1XRZghoiw1YUs/oKrqKNGYtxL1Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mtvuUTHfMa9WQStmKLwcS73WtGEOGr1Z5Cx9umayByU=; b=jGP1MPwprHcPEEBneVHIQcrK0Fh/GMRjIx6cv9e6MePW0vqiHT2uOXuUaO8wSCRYMleOHsKWzWl1E2Ai2BpgHJXULPsBf8y1JIsXmJG7TWCJBS5xhMj24GLNtL9vsBCl3MWD22gFxhbx87DmdmPactqgRCbWKRmf/VmGUCQwEPqWlZSel6tTKQVWyF3Qw+iJ4AC6r1SUxewPEEMkZa6+GqzSamH9S9ypJkoA4PKB71EiMCFN7ZW13ECMGEFqYJqmzhDyermf1rKULXdpUU2xtGyUdzuaxcBNo5T1vkf7/USK2UgLzU2CFS4dft9Z6izChwUUnOp6YMHci3ZWDEhzGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mtvuUTHfMa9WQStmKLwcS73WtGEOGr1Z5Cx9umayByU=; b=oZ7SnARYR60nbp61Tpeb37YJd3FWdWxFY/1KBX+gfvTgOe0JwLzYrzuo/sSz7Sa7jNAW2k60GvdQain2KHB+Hlb2co5/trmX9N2sZlujEq8ekze0nVluOWKz9UZ6DR4uKlQy18TDja2SNVUynEt+V8r3L+wMtUi6l5BgAt20aBw= From: Henry Wang To: =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Paul Durrant , Kevin Tian , Connor Davis Subject: RE: [PATCH v1 00/10] Add Xue - console over USB 3 Debug Capability Thread-Topic: [PATCH v1 00/10] Add Xue - console over USB 3 Debug Capability Thread-Index: AQHYentnmjUfxWhyPUGA3lyI6tN6Lq1xG/NA Date: Wed, 6 Jul 2022 07:30:55 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 01004FA587B2BC4AAC14735FB8BDFDB4.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: c85e3f77-409c-4e38-1444-08da5f217b4b x-ms-traffictypediagnostic: DBAPR08MB5815:EE_|DBAEUR03FT054:EE_|AM9PR08MB6258:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ap+RzDNYbmjmdXufgllTQ4Rtui9PLBieIBVoBQLEsoSYVjLrD8ntONtie0PtEGM4c0PhqG+VSA1zDIfeIEWHQIC6qOy0t3G4dKc2+IIzMout7ZkSmQ2xah76BhNFoSMjgVfiBAwdkfW7sL8yrJhbVSyfKS9hiHi9bL3ZY2mZ+GSVg6GzByvPsaxnjv8PDKdrMpdD/d49JVHjXV82/O5Ttn154S2JM0jIJMVZeoNVmlp8ZUK7W5bZwJkkYbuIx1D9DlSplBEa5CdtyJzBUuBVwKxXlqJD3wLW8K2w+5OHwO16YK89cnI5ydY+t3Xc+zrzj1rtiIop8cKt3dlshib+TUK70Ri0KpRq92EzNsBra4MfJf0wbu6RuUJoct/7KSsJ15cuZskPN9gHpwDaRwkPI0osvfTqd6lRgFej0qiqigSa8hzHU3enC0VYQjUU84rWmo+dgmuwOCTlPjSi3s4oxWjlEt8RP36doGcbrHlNwqjO9NVS5TcSiMUP92KDDnrqpSJc4939rztmmAIA8eENEeyJ1XWqxssUwtYUJ38GKfoKlz4TEeDYBDEj7tmbkidVNRimAxsCUXeOTlCr/ZqeFNRoDvQQwvJHoC45LwJ2O9y3+TebIZrOsOVcsrkeVENkmHzySeIOifjFsk3+yUJyNPCoCWN52TZLl7eIPr8Ep/ry8oGp3+VNxD9xUtB1u70QJv1YBRNzfDIVM36BKTkvs2MsW/IrcZzggZDxzyD5MzZ4vHfSIRs/xj9qVMYdRp7wQl7FKmlcjCB0dEwsgNhWhrfp6TeDAsZ9blEBtyJmbsIV6ckciQiUeG6uikRUkAJWyRsDRmCkthvdP0E+ADMVAg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(110136005)(966005)(478600001)(54906003)(41300700001)(71200400001)(7416002)(9686003)(55016003)(26005)(316002)(52536014)(122000001)(8936002)(5660300002)(38070700005)(86362001)(186003)(8676002)(66556008)(4326008)(66476007)(66446008)(64756008)(66946007)(66574015)(76116006)(38100700002)(7696005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c3000817-5999-4442-8fe0-08da5f217680 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3CwrCdqDBbxoKWiPTiZugTtg7pN2mkmiuh6EMvrMVJw+DKVPKWQFIlJezL0P6IbnWP05IEd3FbPKBUjjcPEHu+ku+2pk4sjjl6DRN8JZ4pRJDpDjNqRsf02Ae4L0xs1GDG3rQ/zFDYfpFe2oL4J/tc3t7ErTRd36ZjxG7y1KL1f+FylSSYMSNOi0gsZK1tp8Wgx15e7YcdA/T48WvKM8dDa5+1B5a4aEwkfVoc4bAUwa+VVIGGwQ+mAK9Uorc8DPyG37Yo0ygOtZ57Jq8XFExCirnvMMZR1UA29lX/4QFXv9IFYoluaNCW/smlqFDP8rNbqQKadd37ZuKNaM/IQSUg8fuqHtip0rJyR+C89CGLjnudHO7nmqIj+P6KF3C8Vw8zRvIvwrQ+ahsG8eK722vVF1lNPa8OWmXzR6+9a4khXwPCRQkmpflhvMr/VeqAb5IO+81pjk6yCUv+jq14iqlP1BN5a0kMfyUsMrZjBc7ve+NOlDLEvnPJHI913Nd5YYnfiTXFa7RbPll2SKIfeyxyLWNCSgr5m6DTDR/U2C8j9YMnRsjtNhT0Qd1KR9PXy8sAhsBGQ4k4Idf/txCzz27HGC/K2o598JJZ3tvazp2piX/krQ4dKMc5Owym5k4lJjtRT7f/ze/WgCnj26WnCjcECRMD4QyQUVzOYgVjY20Pa6C1GroL8oLTkXi0Pp66c3vYiyBA+cpnMHxQbQ3uRts53rNIWgiVVtXmSNY8EYJQM8uZBK+KEvRwFcf/cm8m4vErUleO2Pvb6FqdaCakOJ2mzSVBoz4GDWAGh8Mx4nbgaheK6xkZVAmhnCDJvJTjiBaxN+a88PicYsOFzop6miDw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(346002)(376002)(40470700004)(36840700001)(46966006)(82740400003)(356005)(82310400005)(41300700001)(83380400001)(54906003)(70206006)(8676002)(316002)(36860700001)(70586007)(4326008)(110136005)(81166007)(40460700003)(40480700001)(52536014)(55016003)(478600001)(26005)(186003)(7696005)(6506007)(8936002)(5660300002)(966005)(336012)(2906002)(66574015)(47076005)(86362001)(107886003)(33656002)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:31:03.3423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c85e3f77-409c-4e38-1444-08da5f217b4b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6258 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGJlZW4gc3RhbGUgZm9yIG1vcmUg dGhhbiBhIG1vbnRoLCB3aXRoOg0KDQpQYXRjaCAjMSAjMiAjMyBuZWVkcyBhY3Rpb25zIGZyb20g dGhlIGF1dGhvci4NClBhdGNoICM0IHJldmlld2VkLg0KUGF0Y2ggIzUgdG8gIzEwIG5lZWRzIGZl ZWRiYWNrIGZyb20gbWFpbnRhaW5lcnMuDQoNClNvIHNlbmRpbmcgdGhpcyBlbWFpbCBhcyBhIGdl bnRsZSByZW1pbmRlci4gVGhhbmtzIQ0KDQpLaW5kIHJlZ2FyZHMsDQpIZW5yeQ0KDQo+IC0tLS0t T3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IFN1YmplY3Q6IFtQQVRDSCB2MSAwMC8xMF0gQWRkIFh1 ZSAtIGNvbnNvbGUgb3ZlciBVU0IgMyBEZWJ1ZyBDYXBhYmlsaXR5DQo+IA0KPiBUaGlzIGlzIGlu dGVncmF0aW9uIG9mIGh0dHBzOi8vZ2l0aHViLmNvbS9jb25ub2pkL3h1ZSBpbnRvIG1haW5saW5l IFhlbi4NCj4gVGhpcyBwYXRjaCBzZXJpZXMgaW5jbHVkZXMgc2V2ZXJhbCBwYXRjaGVzIHRoYXQg SSBtYWRlIGluIHRoZSBwcm9jZXNzLCBzb21lDQo+IGFyZQ0KPiB2ZXJ5IGxvb3NlbHkgcmVsYXRl ZC4NCj4gDQo+IFRoZSBkcml2ZXIgZGV2ZWxvcGVkIGJ5IENvbm5vciBzdXBwb3J0cyBvdXRwdXQt b25seSBjb25zb2xlIHZpYSBVU0IzDQo+IGRlYnVnDQo+IGNhcGFiaWxpdHkuIFRoZSBjYXBhYmls aXR5IGlzIGRlc2lnbmVkIHRvIG9wZXJhdGUgbW9zdGx5IGluZGVwZW5kZW50bHkgb2YNCj4gbm9y bWFsIFhIQ0kgZHJpdmVyLCBzbyB0aGlzIHBhdGNoIHNlcmllcyBhbGxvd3MgZG9tMCB0byBkcml2 ZSBzdGFuZGFyZCBVU0IzDQo+IGNvbnRyb2xsZXIgcGFydCwgd2hpbGUgWGVuIHVzZXMgRGJDIGZv ciBjb25zb2xlIG91dHB1dC4NCj4gDQo+IENoYW5nZXMgc2luY2UgUkZDOg0KPiAgLSBtb3ZlIHRo ZSBkcml2ZXIgdG8geHVlLmMsIHJlbW92ZSBub24tWGVuIHBhcnRzLCByZW1vdmUgbm93IHVubmVl ZGVkDQo+IGFic3RyYWN0aW9uDQo+ICAtIGFkanVzdCBmb3IgWGVuIGNvZGUgc3R5bGUNCj4gIC0g YnVpbGQgZm9yIHg4NiBvbmx5DQo+ICAtIGRyb3AgcGF0Y2ggaGlkZGluZyB0aGUgZGV2aWNlIGZy b20gZG9tMA0KPiANCj4gQ2M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j b20+DQo+IENjOiBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+DQo+IENj OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IENjOiBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPg0KPiBDYzogU3RlZmFubyBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJu ZWwub3JnPg0KPiBDYzogV2VpIExpdSA8d2xAeGVuLm9yZz4NCj4gQ2M6ICJSb2dlciBQYXUgTW9u bsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+IENjOiBQYXVsIER1cnJhbnQgPHBhdWxAeGVu Lm9yZz4NCj4gQ2M6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KPiBDYzogQ29u bm9yIERhdmlzIDxjb25ub2pkYXZpc0BnbWFpbC5jb20+DQo+IA0KPiBDb25ub3IgRGF2aXMgKDEp Og0KPiAgIGRyaXZlcnMvY2hhcjogQWRkIHN1cHBvcnQgZm9yIFh1ZSBVU0IzIGRlYnVnZ2VyDQo+ IA0KPiBNYXJlayBNYXJjenlrb3dza2ktR8OzcmVja2kgKDkpOg0KPiAgIHh1ZTogcmVzZXQgWEhD SSBwb3J0cyB3aGVuIGluaXRpYWxpemluZyBkYmMNCj4gICB4dWU6IGFkZCBzdXBwb3J0IGZvciBz ZWxlY3Rpbmcgc3BlY2lmaWMgeGhjaQ0KPiAgIGVoY2ktZGJncDogZml4IHNlbGVjdGluZyBuLXRo IGVoY2kgY29udHJvbGxlcg0KPiAgIGNvbnNvbGU6IHN1cHBvcnQgbXVsdGlwbGUgc2VyaWFsIGNv bnNvbGUgc2ltdWx0YW5lb3VzbHkNCj4gICBJT01NVTogYWRkIGNvbW1vbiBBUEkgZm9yIGRldmlj ZSByZXNlcnZlZCBtZW1vcnkNCj4gICBJT01NVS9WVC1kOiB3aXJlIGNvbW1vbiBkZXZpY2UgcmVz ZXJ2ZWQgbWVtb3J5IEFQSQ0KPiAgIElPTU1VL0FNRDogd2lyZSBjb21tb24gZGV2aWNlIHJlc2Vy dmVkIG1lbW9yeSBBUEkNCj4gICB4dWU6IG1hcmsgRE1BIGJ1ZmZlcnMgYXMgcmVzZXJ2ZWQgZm9y IHRoZSBkZXZpY2UNCj4gICB4dWU6IGFsbG93IGRyaXZpbmcgdGhlIHJlc3Qgb2YgWEhDSSBieSBh IGRvbWFpbiB3aGlsZSBYZW4gdXNlcyBEYkMNCj4gDQo+ICBkb2NzL21pc2MveGVuLWNvbW1hbmQt bGluZS5wYW5kb2MgICAgICAgIHwgICAgNSArLQ0KPiAgeGVuL2FyY2gveDg2L0tjb25maWcgICAg ICAgICAgICAgICAgICAgICB8ICAgIDEgKy0NCj4gIHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9m aXhtYXAuaCAgICAgICAgfCAgICA0ICstDQo+ICB4ZW4vYXJjaC94ODYvc2V0dXAuYyAgICAgICAg ICAgICAgICAgICAgIHwgICAgMSArLQ0KPiAgeGVuL2RyaXZlcnMvY2hhci9LY29uZmlnICAgICAg ICAgICAgICAgICB8ICAgIDcgKy0NCj4gIHhlbi9kcml2ZXJzL2NoYXIvTWFrZWZpbGUgICAgICAg ICAgICAgICAgfCAgICAxICstDQo+ICB4ZW4vZHJpdmVycy9jaGFyL2NvbnNvbGUuYyAgICAgICAg ICAgICAgIHwgICA1OCArLQ0KPiAgeGVuL2RyaXZlcnMvY2hhci9laGNpLWRiZ3AuYyAgICAgICAg ICAgICB8ICAgIDIgKy0NCj4gIHhlbi9kcml2ZXJzL2NoYXIveHVlLmMgICAgICAgICAgICAgICAg ICAgfCAxMDg5ICsrKysrKysrKysrKysrKysrKysrKysrLQ0KPiAgeGVuL2RyaXZlcnMvcGFzc3Ro cm91Z2gvYW1kL2lvbW11X2FjcGkuYyB8ICAgMTYgKy0NCj4gIHhlbi9kcml2ZXJzL3Bhc3N0aHJv dWdoL2lvbW11LmMgICAgICAgICAgfCAgIDQwICstDQo+ICB4ZW4vZHJpdmVycy9wYXNzdGhyb3Vn aC92dGQvZG1hci5jICAgICAgIHwgIDIwMyArKy0tDQo+ICB4ZW4vaW5jbHVkZS94ZW4vaW9tbXUu aCAgICAgICAgICAgICAgICAgIHwgICAxMSArLQ0KPiAgeGVuL2luY2x1ZGUveGVuL3NlcmlhbC5o ICAgICAgICAgICAgICAgICB8ICAgIDEgKy0NCj4gIDE0IGZpbGVzIGNoYW5nZWQsIDEzNDIgaW5z ZXJ0aW9ucygrKSwgOTcgZGVsZXRpb25zKC0pDQo+ICBjcmVhdGUgbW9kZSAxMDA2NDQgeGVuL2Ry aXZlcnMvY2hhci94dWUuYw0KPiANCj4gYmFzZS1jb21taXQ6IDQ5ZGQ1MmZiMTMxMWRhZGFiMjlm NjYzNGQwYmMxZjRjMDIyYzM1N2ENCj4gLS0NCj4gZ2l0LXNlcmllcyAwLjkuMQ0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:38:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:38:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361876.591659 (Exim 4.92) (envelope-from ) id 1o8zc6-0000nO-UR; Wed, 06 Jul 2022 07:38:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361876.591659; Wed, 06 Jul 2022 07:38:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zc6-0000n5-RG; Wed, 06 Jul 2022 07:38:22 +0000 Received: by outflank-mailman (input) for mailman id 361876; Wed, 06 Jul 2022 07:38:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zVI-0003d3-Dy for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:31:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2089.outbound.protection.outlook.com [40.107.104.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a079ebfc-fcfd-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 09:31:19 +0200 (CEST) Received: from AS9PR06CA0214.eurprd06.prod.outlook.com (2603:10a6:20b:45e::19) by AM4PR08MB2641.eurprd08.prod.outlook.com (2603:10a6:205:b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 07:31:16 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45e:cafe::72) by AS9PR06CA0214.outlook.office365.com (2603:10a6:20b:45e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:16 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:15 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Wed, 06 Jul 2022 07:31:15 +0000 Received: from b977bd0d1553.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id FA59DAF8-B96C-42E6-9261-EA5177B078F2.1; Wed, 06 Jul 2022 07:31:09 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b977bd0d1553.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:31:09 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5815.eurprd08.prod.outlook.com (2603:10a6:10:1ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:31:07 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:31:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a079ebfc-fcfd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cQBymFvVxn42SkalXCFc0D8iytbQghAvwdfnURvWLwPBUlwbBMHpG8t6ICG0xAlIgdh2ic5que9pYHYSPVQ8cMYtcNsPZRaMqdhZZRE5YqR73bpDREj3sUW7dpx7CIyRA87dAvoEjCEa5iH5ZaR/TyFQ6CRajAzxZbAekGad1RNNgv2htwjQNxklMGFkUuaKZmBLrcJn/iTzdPm5hZ2nR7Ui4O/K0XgG5RsGQtlJAOhJUZAP2CP7n9d+kFIZNOCXtG10+sfFJvfhgBiL51QNNqLzIs18tzewhPgginbm9P5kXK6BbhAkSUGkaLPRi0tSBuPb0EI1a8QMitK4bfaVmg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=md3rIj2LDbTz4axTFS01V8rBLYw1u5gaIdGmxouJJAc=; b=FVY0vkfFsasOj6XPrrhZM4cZGlWiOkxkZc6+8xwfMaHbW1cZReEU6EIhT+NHytWWi92S6A3ifnL1glyPvyEuxo2U8klM/ByXmTDOlsy0Z/tKx5jvN6OTlf1KTFNgOHWhbLGrsf262dWOFq6vAljxdCsrpl3C8QlNUUDvnqtlOaYixRgHLAtrC8xYO8cspYGMMOVJB97d/Qa4JL0xwJEmT47AyK8FyyjasTFVAiFVpwUEjZdlLdjaOGhA+8PWkRkxxTzIeDhiKQbIzW1LmCSAy70XlLrf8bWqoDaGoQV29SVgXUQMmEns1WLO7xOXmgz52cUBP0HLw2OAXSygf4Fwpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=md3rIj2LDbTz4axTFS01V8rBLYw1u5gaIdGmxouJJAc=; b=N2qpVM5zLMWcFs2GkEV64mwDgcrqH1GOnfn0aDuAOc+EHL9dB7+vOre+lK5k62dqyfJJstfUEZMiN8JeHro7bHxpevIEwteGh1qN+NxO37CxY6cqGyYGsneE+vqSazGOZdD4p1i95H7+q/ni2v2TW0SNtvQ+VPgbTuMi4S5sJzM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FdodGb//XK0pVNwfS9mdd6QNFCy64O0CcuOeIjTOuT0yt9UYOJiRBMfN6o67xOucdMU5dImfff7YhQVHp3HVHDflDF0ZsLvo3ZVf8HWowOppuhNMQQNLXYAs1vU/5SUWrDTC3MYGhGbpMjaX1HImIl/upNUxx2m/E7ASrv9mxSP5UpI2HsdWFunQYiBxX+vZX7GjxvvxQ0lMlCiU7m5qmiOHGzea2YTRDgwJBy07qkUYx7YQ5jlL00/k8QNeu7kB8z4H+yl44n+aD6ftTjJZWdOxZC+nHgubLXr7egLtjg6c7W78/zpAqsOsEWmd6guT6jdzhqyng4HhUc9E37arCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=md3rIj2LDbTz4axTFS01V8rBLYw1u5gaIdGmxouJJAc=; b=L8bc90kAzmEwKHJNbDoHb1plDlcl/Yl83kQXRcnEOBegdVImqLSQJhlO1rcsDkgbJJb3/F8rKGq9A8PvoUircfBwSXEZX+RiG8Dt+67YkdYEFMzuSjxvTIPq5HnCzQflWzo3+1S2nIHCbEXEUoEz7Ezr2rKl7KcwCFI6yfwKKgnvt9U7SsYV+vI57XfrQEVKV2drvNyafVpbZrJuIRmBqRe50z3zvhOcF4BpJqLa8w/lks2NLdWyBDFY/Amuxsa+sQxN0C6Fiv/h1Syp0Lm5fKYqHHZBeg1yca0hdGepCuS2g9tI7C/dE3/tNSFIAAQpXqMmLAP6aknh3E57nBl/fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=md3rIj2LDbTz4axTFS01V8rBLYw1u5gaIdGmxouJJAc=; b=N2qpVM5zLMWcFs2GkEV64mwDgcrqH1GOnfn0aDuAOc+EHL9dB7+vOre+lK5k62dqyfJJstfUEZMiN8JeHro7bHxpevIEwteGh1qN+NxO37CxY6cqGyYGsneE+vqSazGOZdD4p1i95H7+q/ni2v2TW0SNtvQ+VPgbTuMi4S5sJzM= From: Henry Wang To: Roger Pau Monne , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Andrew Cooper , Wei Liu , Paul Durrant Subject: RE: [PATCH] iommu: add preemption support to iommu_{un,}map() Thread-Topic: [PATCH] iommu: add preemption support to iommu_{un,}map() Thread-Index: AQHYfKTqlNAQrdLOhUWuhz9XAirPe61xGNzw Date: Wed, 6 Jul 2022 07:31:07 +0000 Message-ID: References: <20220610083248.25800-1-roger.pau@citrix.com> In-Reply-To: <20220610083248.25800-1-roger.pau@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C824E2EA39FB4C46B0F34F690830950C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 721cb639-b167-4d02-c606-08da5f2182c5 x-ms-traffictypediagnostic: DBAPR08MB5815:EE_|VE1EUR03FT019:EE_|AM4PR08MB2641:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x1g32psGxxAiBs7uR52o4nGVerzmzaDXDwohUojuYPrHsBT73GYX/BhhrzP/lsyGsrFiiccWVnFgwYoWVsICIlwrdi1a7WJgBUPJxUxt/1DaceCAQclu6xVgcQ1SoIJupTHR3RTA9ehshpmeY+SdHsAHAPwSn4Oy+pR86yAR2vupXzKYZ2iJ8zzIxTNFMHz6zRlxcvUisHnwz+MPQO3JONR/Yxgzda11+fYxwWi7+HahGgECX3sDtbVx+cocaUhdoHNpv7IwtyJTMvuXObO/DqHgyqFiPuLf/8/TGbzfr7U2xRu3r3u9ML5FvshgGnf74v9MSFog5LNmDVssarTpsnG3CCJ7tbopJQxw0ktqSvGnzjLN4i9KUa8ir0/ATt7ZazjE8MF1d8otVg130WS8AcOcwo5S6nzwdnKMAPz9ZhRSh+jo1Aa6phiXtqvylf5Uidt0D0T4B5IGZud4+P4k8yURQQYzWqakFt3DOzdkZ0lv2YrpN/i2YHDj+RJhXUob/TMvLsSRVic0MCZ78BVqf0JuOCGocCHolSlzdakYgrI8sJVGc5+aWpNEyZBmk7xq5EZHZ2PPYgVPk35xv3PbKoS7vlmll1aebGGZsEo902kRg0cuHsq4DSaZQLRha7y+ABUYdyD9nkzL2sho1ez/AOdUWsWSV/NvRQU+pXHvCHC1XUCoaFkrZbk6vz/hQxvt4+IdmCmK+iSRuLwkySON/4XAInlNo3wxXvHpYZ8kC7KMjZEDZl91/y86YUwl/V/RljJL0izXoBFrxxwzXmXpxUtZ8U12H3t+90DftQFH+DuTnreGtJiYOZxlgjY/o6CI X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(110136005)(478600001)(54906003)(41300700001)(71200400001)(9686003)(55016003)(26005)(316002)(52536014)(122000001)(8936002)(5660300002)(38070700005)(86362001)(186003)(8676002)(66556008)(4326008)(66476007)(66446008)(64756008)(66946007)(76116006)(38100700002)(7696005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f484af84-918f-40bf-2a09-08da5f217d9e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hgp+mAjlapExMK8lnKaa8DkExjelmIA+WU+waJCsi7V4zXdxG4ALgsepJU7VAx1w+Hlm+wgJMdRgpUcsz4I9dfvXiTay6iGxkBgkpteyl0/ADeOpb/CmDxxWzSoaSE64+bjfn8oatnFIV3Ps4m+GOQa6fAICu+zdt2w2CTthZ+Qt8bad/YszXKogX2eu7I8maoZ9WSiMFaX6YJMlhbP1qIFQKiPX4BrB7KdnXORVYRoLmt50OFZHU6W0zeEQ9lcPHF/tf7z42I9fPx88OVxR7ZkZBAh9ASMVcMRu5yN6tBiXxpFTcr5qKOvsVv+s5bGVgSJJyR93I1xe4iPWh8NOKhkTt6qSYdh/tZbdLXaQOYU6kF7PpNloqS251pHQSntMLa18s/UyL0qlq9wsBLTrmmOD/pC9aRrXYPsEWCh01lgzjv6m4mTP9IqbLm6yNrSWX7odVUH2ZGPZ+V28uxBbbV/hIhvR7qh0Hbdqipgq9v9XiEmzlgiK7R7F9rRdKzI84/ZSe8fZwgV+yYgxQ2ovTjxU+E7fdxRhVfe4uLCNukyMeMzVC6uwjVrAYg3kwdicjXqnb1qNTbXialHwzsaylr7czXfhGVz5fG+Qb36biuWNs8palNg4KVq5A/ML3Nu5Nh52f8bS1oUNukvxdAEc+ATr7ISwZFVyyhEmnQ4xFUwrgnK2en1/t/TtoKhyTa3r92ivU55sOI/Ti9YALvj6d2sM58bH9QZcxFJ4POHtjcd6WJ7XejQ3ZY324GvGdESCK1fXvCY3myL5hTFuOhpA5XoH1JR5zHyqcN6HbcLMVFH53zqHhPwlFjB7V6/GBa13 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(46966006)(40470700004)(36840700001)(83380400001)(186003)(336012)(47076005)(8676002)(33656002)(70586007)(70206006)(52536014)(4326008)(86362001)(478600001)(40460700003)(5660300002)(356005)(82740400003)(26005)(81166007)(9686003)(82310400005)(41300700001)(36860700001)(40480700001)(55016003)(2906002)(8936002)(6506007)(7696005)(110136005)(54906003)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:31:15.7383 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 721cb639-b167-4d02-c606-08da5f2182c5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2641 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBwYXRjaCBoYXMgYmVlbiBzdGFsZSBmb3IgYSBtb250 aCwgd2l0aCBhY3Rpb25zIG5lZWRlZA0KZnJvbSB0aGUgYXV0aG9yLiBTbyBzZW5kaW5nIHRoaXMg ZW1haWwgYXMgYSBnZW50bGUgcmVtaW5kZXIuIFRoYW5rcyENCg0KS2luZCByZWdhcmRzLA0KSGVu cnkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0hdIGlv bW11OiBhZGQgcHJlZW1wdGlvbiBzdXBwb3J0IHRvIGlvbW11X3t1bix9bWFwKCkNCj4gDQo+IFRo ZSBsb29wIGluIGlvbW11X3t1bix9bWFwKCkgY2FuIGJlIGFyYml0cmFyeSBsYXJnZSwgYW5kIGFz IHN1Y2ggaXQNCj4gbmVlZHMgdG8gaGFuZGxlIHByZWVtcHRpb24uICBJbnRyb2R1Y2UgYSBuZXcg cGFyYW1ldGVyIHRoYXQgYWxsb3cNCj4gcmV0dXJuaW5nIHRoZSBudW1iZXIgb2YgcGFnZXMgdGhh dCBoYXZlIGJlZW4gcHJvY2Vzc2VkLCBhbmQgd2hpY2gNCj4gcHJlc2VuY2UgYWxzbyBzaWduYWxz IHdoZXRoZXIgdGhlIGZ1bmN0aW9uIHNob3VsZCBkbyBwcmVlbXB0aW9uDQo+IGNoZWNrcy4NCj4g DQo+IE5vdGUgdGhhdCB0aGUgY2xlYW51cCBkb25lIGluIGlvbW11X21hcCgpIGNhbiBub3cgYmUg aW5jb21wbGV0ZSBpZg0KPiBwcmVlbXB0aW9uIGhhcyBoYXBwZW5lZCwgYW5kIGhlbmNlIGNhbGxl cnMgd291bGQgbmVlZCB0byB0YWtlIGNhcmUgb2YNCj4gdW5tYXBwaW5nIHRoZSB3aG9sZSByYW5n ZSAoaWU6IHJhbmdlcyBhbHJlYWR5IG1hcHBlZCBieSBwcmV2aW91c2x5DQo+IHByZWVtcHRlZCBj YWxscykuICBTbyBmYXIgbm9uZSBvZiB0aGUgY2FsbGVycyBjYXJlIGFib3V0IGhhdmluZyB0aG9z ZQ0KPiByYW5nZXMgdW5tYXBwZWQsIHNvIGVycm9yIGhhbmRsaW5nIGluIGlvbW11X21lbW9yeV9z ZXR1cCgpIGFuZA0KPiBhcmNoX2lvbW11X2h3ZG9tX2luaXQoKSBjYW4gYmUga2VwdCBhcy1pcy4N Cj4gDQo+IE5vdGUgdGhhdCBpb21tdV9sZWdhY3lfe3VuLH1tYXAoKSBpcyBsZWZ0IHdpdGhvdXQg cHJlZW1wdGlvbiBoYW5kbGluZzoNCj4gY2FsbGVycyBvZiB0aG9zZSBpbnRlcmZhY2VzIGFyZSBu b3QgbW9kaWZpZWQgdG8gcGFzcyBiaWdnZXIgY2h1bmtzLA0KPiBhbmQgaGVuY2UgdGhlIGZ1bmN0 aW9ucyB3b24ndCBiZSBtb2RpZmllZCBhcyBhcmUgbGVnYWN5IGFuZCBzaG91bGQgYmUNCj4gcmVw bGFjZWQgd2l0aCBpb21tdV97dW4sfW1hcCgpIGluc3RlYWQgaWYgcHJlZW1wdGlvbiBpcyByZXF1 aXJlZC4NCj4gDQo+IEZpeGVzOiBmMzE4NWMxNjVkICgnSU9NTVUveDg2OiBwZXJmb3JtIFBWIERv bTAgbWFwcGluZ3MgaW4gYmF0Y2hlcycpDQo+IFNpZ25lZC1vZmYtYnk6IFJvZ2VyIFBhdSBNb25u w6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiAtLS0NCj4gIHhlbi9hcmNoL3g4Ni9wdi9kb20w X2J1aWxkLmMgICAgICAgIHwgMTUgKysrKysrKysrKysrLS0tDQo+ICB4ZW4vZHJpdmVycy9wYXNz dGhyb3VnaC9pb21tdS5jICAgICB8IDI2ICsrKysrKysrKysrKysrKysrKystLS0tLS0tDQo+ICB4 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC94ODYvaW9tbXUuYyB8IDEzICsrKysrKysrKysrLS0NCj4g IHhlbi9pbmNsdWRlL3hlbi9pb21tdS5oICAgICAgICAgICAgIHwgIDQgKystLQ0KPiAgNCBmaWxl cyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvcHYvZG9tMF9idWlsZC5jIGIveGVuL2FyY2gveDg2L3B2L2Rv bTBfYnVpbGQuYw0KPiBpbmRleCAwNGE0ZWEzYzE4Li5lNWE0Mjg3MGVjIDEwMDY0NA0KPiAtLS0g YS94ZW4vYXJjaC94ODYvcHYvZG9tMF9idWlsZC5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9wdi9k b20wX2J1aWxkLmMNCj4gQEAgLTc3LDcgKzc3LDggQEAgc3RhdGljIF9faW5pdCB2b2lkIG1hcmtf cHZfcHRfcGFnZXNfcmRvbmx5KHN0cnVjdA0KPiBkb21haW4gKmQsDQo+ICAgICAgICAgICAqIGlv bW11X21lbW9yeV9zZXR1cCgpIGVuZGVkIHVwIG1hcHBpbmcgdGhlbS4NCj4gICAgICAgICAgICov DQo+ICAgICAgICAgIGlmICggbmVlZF9pb21tdV9wdF9zeW5jKGQpICYmDQo+IC0gICAgICAgICAg ICAgaW9tbXVfdW5tYXAoZCwgX2RmbihtZm5feChwYWdlX3RvX21mbihwYWdlKSkpLCAxLCBmbHVz aF9mbGFncykgKQ0KPiArICAgICAgICAgICAgIGlvbW11X3VubWFwKGQsIF9kZm4obWZuX3gocGFn ZV90b19tZm4ocGFnZSkpKSwgMSwgZmx1c2hfZmxhZ3MsDQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgTlVMTCkgKQ0KPiAgICAgICAgICAgICAgQlVHKCk7DQo+IA0KPiAgICAgICAgICAvKiBS ZWFkLW9ubHkgbWFwcGluZyArIFBHQ19hbGxvY2F0ZWQgKyBwYWdlLXRhYmxlIHBhZ2UuICovDQo+ IEBAIC0xMjEsMTMgKzEyMiwyMSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgaW9tbXVfbWVtb3J5X3Nl dHVwKHN0cnVjdA0KPiBkb21haW4gKmQsIGNvbnN0IGNoYXIgKndoYXQsDQo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpDQo+ ICB7DQo+ICAgICAgaW50IHJjOw0KPiArICAgIHVuc2lnbmVkIGxvbmcgZG9uZTsNCj4gICAgICBt Zm5fdCBtZm4gPSBwYWdlX3RvX21mbihwYWdlKTsNCj4gDQo+ICAgICAgaWYgKCAhbmVlZF9pb21t dV9wdF9zeW5jKGQpICkNCj4gICAgICAgICAgcmV0dXJuOw0KPiANCj4gLSAgICByYyA9IGlvbW11 X21hcChkLCBfZGZuKG1mbl94KG1mbikpLCBtZm4sIG5yLA0KPiAtICAgICAgICAgICAgICAgICAg IElPTU1VRl9yZWFkYWJsZSB8IElPTU1VRl93cml0YWJsZSwgZmx1c2hfZmxhZ3MpOw0KPiArICAg IHdoaWxlICggKHJjID0gaW9tbXVfbWFwKGQsIF9kZm4obWZuX3gobWZuKSksIG1mbiwgbnIsDQo+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgSU9NTVVGX3JlYWRhYmxlIHwgSU9NTVVGX3dy aXRhYmxlLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZsdXNoX2ZsYWdzLCAmZG9u ZSkpID09IC1FUkVTVEFSVCApDQo+ICsgICAgew0KPiArICAgICAgICBtZm5fYWRkKG1mbiwgZG9u ZSk7DQo+ICsgICAgICAgIG5yIC09IGRvbmU7DQo+ICsgICAgICAgIHByb2Nlc3NfcGVuZGluZ19z b2Z0aXJxcygpOw0KPiArICAgIH0NCj4gKw0KPiAgICAgIGlmICggcmMgKQ0KPiAgICAgIHsNCj4g ICAgICAgICAgcHJpbnRrKFhFTkxPR19FUlIgInByZS1tYXBwaW5nICVzIE1GTiBbJWx4LCVseCkg aW50byBJT01NVQ0KPiBmYWlsZWQ6ICVkXG4iLA0KPiBkaWZmIC0tZ2l0IGEveGVuL2RyaXZlcnMv cGFzc3Rocm91Z2gvaW9tbXUuYw0KPiBiL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2lvbW11LmMN Cj4gaW5kZXggNzVkZjNhYThkZC4uNWMyYTM0MTExMiAxMDA2NDQNCj4gLS0tIGEveGVuL2RyaXZl cnMvcGFzc3Rocm91Z2gvaW9tbXUuYw0KPiArKysgYi94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9p b21tdS5jDQo+IEBAIC0zMTAsMTEgKzMxMCwxMSBAQCBzdGF0aWMgdW5zaWduZWQgaW50IG1hcHBp bmdfb3JkZXIoY29uc3Qgc3RydWN0DQo+IGRvbWFpbl9pb21tdSAqaGQsDQo+IA0KPiAgaW50IGlv bW11X21hcChzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4wLCBtZm5fdCBtZm4wLA0KPiAgICAg ICAgICAgICAgICB1bnNpZ25lZCBsb25nIHBhZ2VfY291bnQsIHVuc2lnbmVkIGludCBmbGFncywN Cj4gLSAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpmbHVzaF9mbGFncykNCj4gKyAgICAgICAg ICAgICAgdW5zaWduZWQgaW50ICpmbHVzaF9mbGFncywgdW5zaWduZWQgbG9uZyAqZG9uZSkNCj4g IHsNCj4gICAgICBjb25zdCBzdHJ1Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsN Cj4gICAgICB1bnNpZ25lZCBsb25nIGk7DQo+IC0gICAgdW5zaWduZWQgaW50IG9yZGVyOw0KPiAr ICAgIHVuc2lnbmVkIGludCBvcmRlciwgaiA9IDA7DQo+ICAgICAgaW50IHJjID0gMDsNCj4gDQo+ ICAgICAgaWYgKCAhaXNfaW9tbXVfZW5hYmxlZChkKSApDQo+IEBAIC0zMjcsNiArMzI3LDEyIEBA IGludCBpb21tdV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuMCwNCj4gbWZuX3QgbWZu MCwNCj4gICAgICAgICAgZGZuX3QgZGZuID0gZGZuX2FkZChkZm4wLCBpKTsNCj4gICAgICAgICAg bWZuX3QgbWZuID0gbWZuX2FkZChtZm4wLCBpKTsNCj4gDQo+ICsgICAgICAgIGlmICggZG9uZSAm JiAhKCsraiAmIDB4ZmZmZmYpICYmIGdlbmVyYWxfcHJlZW1wdF9jaGVjaygpICkNCj4gKyAgICAg ICAgew0KPiArICAgICAgICAgICAgKmRvbmUgPSBpOw0KPiArICAgICAgICAgICAgcmV0dXJuIC1F UkVTVEFSVDsNCj4gKyAgICAgICAgfQ0KPiArDQo+ICAgICAgICAgIG9yZGVyID0gbWFwcGluZ19v cmRlcihoZCwgZGZuLCBtZm4sIHBhZ2VfY291bnQgLSBpKTsNCj4gDQo+ICAgICAgICAgIHJjID0g aW9tbXVfY2FsbChoZC0+cGxhdGZvcm1fb3BzLCBtYXBfcGFnZSwgZCwgZGZuLCBtZm4sDQo+IEBA IC0zNDEsNyArMzQ3LDcgQEAgaW50IGlvbW11X21hcChzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBk Zm4wLCBtZm5fdA0KPiBtZm4wLA0KPiAgICAgICAgICAgICAgICAgICAgIGQtPmRvbWFpbl9pZCwg ZGZuX3goZGZuKSwgbWZuX3gobWZuKSwgcmMpOw0KPiANCj4gICAgICAgICAgLyogd2hpbGUgc3Rh dGVtZW50IHRvIHNhdGlzZnkgX19tdXN0X2NoZWNrICovDQo+IC0gICAgICAgIHdoaWxlICggaW9t bXVfdW5tYXAoZCwgZGZuMCwgaSwgZmx1c2hfZmxhZ3MpICkNCj4gKyAgICAgICAgd2hpbGUgKCBp b21tdV91bm1hcChkLCBkZm4wLCBpLCBmbHVzaF9mbGFncywgTlVMTCkgKQ0KPiAgICAgICAgICAg ICAgYnJlYWs7DQo+IA0KPiAgICAgICAgICBpZiAoICFpc19oYXJkd2FyZV9kb21haW4oZCkgKQ0K PiBAQCAtMzY1LDcgKzM3MSw3IEBAIGludCBpb21tdV9sZWdhY3lfbWFwKHN0cnVjdCBkb21haW4g KmQsIGRmbl90IGRmbiwNCj4gbWZuX3QgbWZuLA0KPiAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgbG9uZyBwYWdlX2NvdW50LCB1bnNpZ25lZCBpbnQgZmxhZ3MpDQo+ICB7DQo+ICAgICAg dW5zaWduZWQgaW50IGZsdXNoX2ZsYWdzID0gMDsNCj4gLSAgICBpbnQgcmMgPSBpb21tdV9tYXAo ZCwgZGZuLCBtZm4sIHBhZ2VfY291bnQsIGZsYWdzLCAmZmx1c2hfZmxhZ3MpOw0KPiArICAgIGlu dCByYyA9IGlvbW11X21hcChkLCBkZm4sIG1mbiwgcGFnZV9jb3VudCwgZmxhZ3MsICZmbHVzaF9m bGFncywgTlVMTCk7DQo+IA0KPiAgICAgIGlmICggIXRoaXNfY3B1KGlvbW11X2RvbnRfZmx1c2hf aW90bGIpICYmICFyYyApDQo+ICAgICAgICAgIHJjID0gaW9tbXVfaW90bGJfZmx1c2goZCwgZGZu LCBwYWdlX2NvdW50LCBmbHVzaF9mbGFncyk7DQo+IEBAIC0zNzQsMTEgKzM4MCwxMSBAQCBpbnQg aW9tbXVfbGVnYWN5X21hcChzdHJ1Y3QgZG9tYWluICpkLCBkZm5fdA0KPiBkZm4sIG1mbl90IG1m biwNCj4gIH0NCj4gDQo+ICBpbnQgaW9tbXVfdW5tYXAoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3Qg ZGZuMCwgdW5zaWduZWQgbG9uZyBwYWdlX2NvdW50LA0KPiAtICAgICAgICAgICAgICAgIHVuc2ln bmVkIGludCAqZmx1c2hfZmxhZ3MpDQo+ICsgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpm bHVzaF9mbGFncywgdW5zaWduZWQgbG9uZyAqZG9uZSkNCj4gIHsNCj4gICAgICBjb25zdCBzdHJ1 Y3QgZG9tYWluX2lvbW11ICpoZCA9IGRvbV9pb21tdShkKTsNCj4gICAgICB1bnNpZ25lZCBsb25n IGk7DQo+IC0gICAgdW5zaWduZWQgaW50IG9yZGVyOw0KPiArICAgIHVuc2lnbmVkIGludCBvcmRl ciwgaiA9IDA7DQo+ICAgICAgaW50IHJjID0gMDsNCj4gDQo+ICAgICAgaWYgKCAhaXNfaW9tbXVf ZW5hYmxlZChkKSApDQo+IEBAIC0zODksNiArMzk1LDEyIEBAIGludCBpb21tdV91bm1hcChzdHJ1 Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4wLA0KPiB1bnNpZ25lZCBsb25nIHBhZ2VfY291bnQsDQo+ ICAgICAgICAgIGRmbl90IGRmbiA9IGRmbl9hZGQoZGZuMCwgaSk7DQo+ICAgICAgICAgIGludCBl cnI7DQo+IA0KPiArICAgICAgICBpZiAoIGRvbmUgJiYgISgrK2ogJiAweGZmZmZmKSAmJiBnZW5l cmFsX3ByZWVtcHRfY2hlY2soKSApDQo+ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgICpkb25l ID0gaTsNCj4gKyAgICAgICAgICAgIHJldHVybiAtRVJFU1RBUlQ7DQo+ICsgICAgICAgIH0NCj4g Kw0KPiAgICAgICAgICBvcmRlciA9IG1hcHBpbmdfb3JkZXIoaGQsIGRmbiwgX21mbigwKSwgcGFn ZV9jb3VudCAtIGkpOw0KPiAgICAgICAgICBlcnIgPSBpb21tdV9jYWxsKGhkLT5wbGF0Zm9ybV9v cHMsIHVubWFwX3BhZ2UsIGQsIGRmbiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICBvcmRl ciwgZmx1c2hfZmxhZ3MpOw0KPiBAQCAtNDI1LDcgKzQzNyw3IEBAIGludCBpb21tdV91bm1hcChz dHJ1Y3QgZG9tYWluICpkLCBkZm5fdCBkZm4wLA0KPiB1bnNpZ25lZCBsb25nIHBhZ2VfY291bnQs DQo+ICBpbnQgaW9tbXVfbGVnYWN5X3VubWFwKHN0cnVjdCBkb21haW4gKmQsIGRmbl90IGRmbiwg dW5zaWduZWQgbG9uZw0KPiBwYWdlX2NvdW50KQ0KPiAgew0KPiAgICAgIHVuc2lnbmVkIGludCBm bHVzaF9mbGFncyA9IDA7DQo+IC0gICAgaW50IHJjID0gaW9tbXVfdW5tYXAoZCwgZGZuLCBwYWdl X2NvdW50LCAmZmx1c2hfZmxhZ3MpOw0KPiArICAgIGludCByYyA9IGlvbW11X3VubWFwKGQsIGRm biwgcGFnZV9jb3VudCwgJmZsdXNoX2ZsYWdzLCBOVUxMKTsNCj4gDQo+ICAgICAgaWYgKCAhdGhp c19jcHUoaW9tbXVfZG9udF9mbHVzaF9pb3RsYikgJiYgIXJjICkNCj4gICAgICAgICAgcmMgPSBp b21tdV9pb3RsYl9mbHVzaChkLCBkZm4sIHBhZ2VfY291bnQsIGZsdXNoX2ZsYWdzKTsNCj4gZGlm ZiAtLWdpdCBhL3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL3g4Ni9pb21tdS5jDQo+IGIveGVuL2Ry aXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMNCj4gaW5kZXggMTFhNGYyNDRlNC4uNTQ2ZTZk YmUyYSAxMDA2NDQNCj4gLS0tIGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMN Cj4gKysrIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gveDg2L2lvbW11LmMNCj4gQEAgLTQwMyw5 ICs0MDMsMTggQEAgdm9pZCBfX2h3ZG9tX2luaXQNCj4gYXJjaF9pb21tdV9od2RvbV9pbml0KHN0 cnVjdCBkb21haW4gKmQpDQo+ICAgICAgICAgIH0NCj4gICAgICAgICAgZWxzZSBpZiAoIHBmbiAh PSBzdGFydCArIGNvdW50IHx8IHBlcm1zICE9IHN0YXJ0X3Blcm1zICkNCj4gICAgICAgICAgew0K PiArICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBkb25lOw0KPiArDQo+ICAgICAgICAgIGNvbW1p dDoNCj4gLSAgICAgICAgICAgIHJjID0gaW9tbXVfbWFwKGQsIF9kZm4oc3RhcnQpLCBfbWZuKHN0 YXJ0KSwgY291bnQsIHN0YXJ0X3Blcm1zLA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAg JmZsdXNoX2ZsYWdzKTsNCj4gKyAgICAgICAgICAgIHdoaWxlICggKHJjID0gaW9tbXVfbWFwKGQs IF9kZm4oc3RhcnQpLCBfbWZuKHN0YXJ0KSwgY291bnQsDQo+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBzdGFydF9wZXJtcywgJmZsdXNoX2ZsYWdzLA0KPiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgJmRvbmUpKSA9PSAtRVJFU1RBUlQgKQ0KPiArICAg ICAgICAgICAgew0KPiArICAgICAgICAgICAgICAgIHN0YXJ0ICs9IGRvbmU7DQo+ICsgICAgICAg ICAgICAgICAgY291bnQgLT0gZG9uZTsNCj4gKyAgICAgICAgICAgICAgICBwcm9jZXNzX3BlbmRp bmdfc29mdGlycXMoKTsNCj4gKyAgICAgICAgICAgIH0NCj4gKw0KPiAgICAgICAgICAgICAgaWYg KCByYyApDQo+ICAgICAgICAgICAgICAgICAgcHJpbnRrKFhFTkxPR19XQVJOSU5HDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICIlcGQ6IElPTU1VIGlkZW50aXR5IG1hcHBpbmcgb2YgWyVseCwl bHgpIGZhaWxlZDogJWRcbiIsDQo+IGRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS94ZW4vaW9tbXUu aCBiL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oDQo+IGluZGV4IDc5NTI5YWRmMWYuLmU2NjQzYmNj MWMgMTAwNjQ0DQo+IC0tLSBhL3hlbi9pbmNsdWRlL3hlbi9pb21tdS5oDQo+ICsrKyBiL3hlbi9p bmNsdWRlL3hlbi9pb21tdS5oDQo+IEBAIC0xNTUsMTAgKzE1NSwxMCBAQCBlbnVtDQo+IA0KPiAg aW50IF9fbXVzdF9jaGVjayBpb21tdV9tYXAoc3RydWN0IGRvbWFpbiAqZCwgZGZuX3QgZGZuLCBt Zm5fdCBtZm4sDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBsb25nIHBh Z2VfY291bnQsIHVuc2lnbmVkIGludCBmbGFncywNCj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgIHVuc2lnbmVkIGludCAqZmx1c2hfZmxhZ3MpOw0KPiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgdW5zaWduZWQgaW50ICpmbHVzaF9mbGFncywgdW5zaWduZWQgbG9uZyAqZG9uZSk7DQo+ ICBpbnQgX19tdXN0X2NoZWNrIGlvbW11X3VubWFwKHN0cnVjdCBkb21haW4gKmQsIGRmbl90IGRm biwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgbG9uZyBwYWdlX2Nv dW50LA0KPiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgKmZsdXNo X2ZsYWdzKTsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50ICpm bHVzaF9mbGFncywgdW5zaWduZWQgbG9uZyAqZG9uZSk7DQo+IA0KPiAgaW50IF9fbXVzdF9jaGVj ayBpb21tdV9sZWdhY3lfbWFwKHN0cnVjdCBkb21haW4gKmQsIGRmbl90IGRmbiwgbWZuX3QNCj4g bWZuLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGxvbmcg cGFnZV9jb3VudCwNCj4gLS0NCj4gMi4zNi4xDQo+IA0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:38:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:38:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361886.591669 (Exim 4.92) (envelope-from ) id 1o8zcH-0001Vi-BN; Wed, 06 Jul 2022 07:38:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361886.591669; Wed, 06 Jul 2022 07:38:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zcH-0001VS-82; Wed, 06 Jul 2022 07:38:33 +0000 Received: by outflank-mailman (input) for mailman id 361886; Wed, 06 Jul 2022 07:38:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zVT-0004kS-4K for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:31:31 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20051.outbound.protection.outlook.com [40.107.2.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6fb688c-fcfd-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:31:30 +0200 (CEST) Received: from DB8PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:10:be::30) by AM4PR0802MB2164.eurprd08.prod.outlook.com (2603:10a6:200:5a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 07:31:28 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::13) by DB8PR03CA0017.outlook.office365.com (2603:10a6:10:be::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.22 via Frontend Transport; Wed, 6 Jul 2022 07:31:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 07:31:28 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 06 Jul 2022 07:31:28 +0000 Received: from aac9df073a6c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A4E254E7-A22F-42D2-A8D5-9ADD8DB29EBB.1; Wed, 06 Jul 2022 07:31:22 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aac9df073a6c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 07:31:22 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DBAPR08MB5815.eurprd08.prod.outlook.com (2603:10a6:10:1ab::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 07:31:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 07:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6fb688c-fcfd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=USwZgIFYz9Nbllup+16eu6V0jYh2oq5y3Z1ymy4MdM6HcEQ/qZbA4889g0dQ2KRs/3gutgKglJ9A1f8pHze3DLNJZXATu2KlRSAsxIlm00v4oKYXp1RsBpmRjJ3bwdR2oTa4FDz/Q5DVACk25/8GXXmlGqdpFp8hbTYMM1rKCpE3MjVB6LeakgPuVuRpaNWu96er2tqSxRxhF5aEwzcSs4S5irVCxOU6Oyd/345oIcDxvEJaEeKdlOIwyUZSv8kS2cVNUFYln9anfmfi72enbMHJQR+rXL8EWn+9giG0ve1mi4RG6qBuNBCPxgDek5t2dfbYLMkZme1bK0LMmtAkaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f7b1ELNsPHQzKLrMVcd7b8TftPA9NpV2UUza1FeAtlc=; b=YPq4eatGwnYdMb0z9Hv/XGgYrc9S4Gk2feiyKVtUkiM+ai6lHF21AkBDcJCRRD+TbmEqExdG1OsVjgfwuIPtOc/pizhn2fWZL4+/9mb9CGy5yiBS+Jm5DyRYJhVKb3QGrCcVd4Dkq3WwksVPSDbelx9fQrWoN+IeLSTJnDxQcM2dsAKoGVxieK/hh4RaOKZN/je15yhELNdwStVieoKUX1fMgybAR0nhCec8whHboEixlpW9rdrxU3HXne7Yhii5EDQJEjOov1uUSIvDXm3hWUmH1sCocukChK4s/G3/PVDz3x0PrULy/7sYsiQR+gr7LJbbiGIez2kXWbBEa0lffg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7b1ELNsPHQzKLrMVcd7b8TftPA9NpV2UUza1FeAtlc=; b=kGJ0FqEPh+Xdz1KjJoCC4yZk9078JJas9jNq4f5GkQs37pQjnlFfOPOTfvl4lRJLNed3vvxnTz5h5NbXhQHriH51wATc1prRHLHZe2kip9XN4JmSx3Jk9gKAgyV8yQvutVDtH12CvV+k5+oIHlavS1mb/PSEKtAcaSzOeAOSEzk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=So9oIWIuf4Z6iklaR/WHxHMUT7FO1DZ4bH34uaDHXX43685EzLnvqBW4ZgtcZHSK4yGQ9tNwT4ajD96Fw6JPF+9NRNgQAS+t3obtdRJ0O5//iGc7MrlMTYkTuujDlmCewESbuQ7Dtn2aGmOuu1YC+sT3VEkJo82AO6oMmxLZA7ZuvhPoy7blKil0VmTtAsM31fo0Qzj7tyj2pG7aoZOgJoKLlEsYIIWGXqT1qreoZ8H0qw8qEz7H9ykGW1wlcu7LXxwYfq9jtxedmA1q0hPJWxwb8RSLBzhHqia5IJ3jZRzoudv/JEfa0fvpLJPp3yXrvjvkSNSXCqlWmr4INoZw1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f7b1ELNsPHQzKLrMVcd7b8TftPA9NpV2UUza1FeAtlc=; b=Mu0tPUt7oEslVz51CHkePlI1pPlisuxZGs0IyVsX8WNZ0+Y7oCC7/yaeKN9J7C4NUdqZ/oYTUNy3hrUuABKUHZjnKNasfzrGn2WojdfcI86qqCjqSau5MHnqHrv7junmenbyUAWC8MkFDiPOmDyEU95fz+Vgyp/PJAMOxFlXP7fO1CqqHo09GRIaUTu0K24pcFottBcU/kig0M1+N0ycqkWcIbNCn061j/xt4gDdtiFZN88RvhGnRR1KpuDMZUEzxD9SoLJK0jrqnl/vX2xnRWrUN5KYUGQ6zTfoqpEOosseti8+r139fMlePh40xAcnW8jKOel4asUPfzWIRRRZUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f7b1ELNsPHQzKLrMVcd7b8TftPA9NpV2UUza1FeAtlc=; b=kGJ0FqEPh+Xdz1KjJoCC4yZk9078JJas9jNq4f5GkQs37pQjnlFfOPOTfvl4lRJLNed3vvxnTz5h5NbXhQHriH51wATc1prRHLHZe2kip9XN4JmSx3Jk9gKAgyV8yQvutVDtH12CvV+k5+oIHlavS1mb/PSEKtAcaSzOeAOSEzk= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: Andrew Cooper , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Jan Beulich Subject: RE: [PATCH v2 0/8] x86emul: a few small steps towards disintegration Thread-Topic: [PATCH v2 0/8] x86emul: a few small steps towards disintegration Thread-Index: AQHYgJ6R51Cg7cLRXES97vjccXbkla1xEZQA Date: Wed, 6 Jul 2022 07:31:20 +0000 Message-ID: References: <7f5287ad-8442-6c53-d513-f9a8345c4857@suse.com> In-Reply-To: <7f5287ad-8442-6c53-d513-f9a8345c4857@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 07CFC9DA19D33E459D83F559D061E325.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 33b511cd-b989-45f1-b808-08da5f218a03 x-ms-traffictypediagnostic: DBAPR08MB5815:EE_|DBAEUR03FT038:EE_|AM4PR0802MB2164:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bTJNihQN399R5xCxwk8Ninr04Id/DvlflVFN71GW/xjnA7Tc1M9GhMHiyVRSlA9NSYOQbpQSK5poAkXQAuq0YvToVwgeeXH5RosYLogCL5DvDL9tnhV/DlyRG/J9Nc6VM3IgyimiRx1uRue9H8OBPyPfLUTXrgTDTLYjgPGRLu/lSuAj5Sg5tw9YqFinCfVEhGrsGJ8zg8U9E3PwCDYiQrHri6tlu/vRKvNCT2VRr2d8AVkvW+F2X0n+iwW7Uj21zKhMbSSdbHZomZGJsSaAXVIwlSbpqQkXZIoLYt2dtsE0bf8B6xsaST+S7tozLn6j4LPz/1ew2qGkogCZtB7LJFcUONuhzCdoMQDKzIbM03jUB858ZzvM3U2367eYsUt7rARvC7eL9PkRgqP/B1dB2w5wfdTC1pTG7rdIYtdf8IEp6OjahPHQm7wXJWY/JyDas1FolYYDYKXpTjPHEZNMhv0sWTFEJY/X0W1WGHQxT+w1VLXNjqzPfmcSApAOvOPOdHldfTKurWSDo8PbgGBZi5/mA9eJQDwcOeBO6CtMHIYvR5SUDeWL9H2L/9pmIXC5rjdVaKUukQ9ro1vVOJvUCrYkNAS8YrJvbfjQAN8oYxjziBNyZ+7Qi/LLPItR13ReD/Y/0WH/HPWm2dMr4sbqHajsan8MrHXqXlNgN9ryHdpviqI6WDOs7l3S34g57Qspf+QQjGyOpn821epn7pA02C+kdTjslg7H2cPzMDVEagNx10eF6HaXQGH7WaBL3MLucIB4eenn8Db65tj2AikH8sezMl5NDejjA/0vgKv9vqn4NcaqKvcinbwW/gGMsZUz X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(478600001)(54906003)(41300700001)(71200400001)(9686003)(55016003)(26005)(316002)(52536014)(122000001)(6916009)(8936002)(5660300002)(38070700005)(86362001)(186003)(8676002)(66556008)(4326008)(66476007)(66446008)(64756008)(66946007)(76116006)(38100700002)(7696005)(2906002)(6506007)(33656002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR08MB5815 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 010e940b-5b0a-43fe-1345-08da5f2185c5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aaShANSQGVkF+eVtNLdHZOJkkK0Dw5fvEoULAh9HvYXGQ96So5/TmHVc3E4tejErAVdK5+Bhp9+j+34T6mT7jjOou394saD7ItXEnaUV6Fwg4x5d/CandxYbmHDXHsVRT/KoX0fx7kbwayqrdKCGzNUAHIFlLiFjdvEsRUom4b6K9/lZsjVfO8bip4zYWOeAdcr9LolfSDINbERKswRXFaJjdM85ZgoXWqtyJiGMrJBtEU+5356S0e1HEXE7KBbfJZArD+67e1tvuMptJS+vdcUOhyN3rW2F3rCL678zYQu6Cikllaaa+LaJwX7j2rrvVs/0T+cdsdVxG6e6cmsGl4COsUh5nXROp7/VfM6gkC4SuiEc86PKJa/4KdpTtUdoLZGNL8L4ktNYz9ZEcAg/xYCQ5m/qLb7MYcyWWfOH9oHxmwrK2sXstz/FEQdNnxrpRuNEwpybO6FgKJASEaoTtUYNC08bE8FKsTaYpoKdGZKIckwAO3qIezgWLPC89aA+NEeGep2QtbrwzbktNIspvTq6mxaAaWUAqVEL8KDIr17C/PcWDCRZoWfHv0y6H/CqkxC4pRUGnIAdXQUEjVYJJqvfd1D2r2eSqg4a2y8Z6nI0ODT7TRr32MqSiixcyCkN2/6/S0/FTJ0leF/yIAs5smdBLCfb1lGCp6OBibN0yaiwQ2+5Ie25w0jBMEe8Aw3kMvvXtlN5s/tbb7a6vW6OpuEinhvVzRLTIlumtBJ3htLZssLUIcTApKcAWLcGW0iDvLqhikLF3FjGA0RegJ3aL9eL7MZybY16KjNBJ9v+nipZW8pSLKHYpC5dkDKsB78t X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(40470700004)(36840700001)(7696005)(6506007)(356005)(81166007)(40480700001)(54906003)(6916009)(36860700001)(316002)(86362001)(82740400003)(55016003)(82310400005)(2906002)(8676002)(83380400001)(41300700001)(4326008)(107886003)(5660300002)(336012)(9686003)(47076005)(26005)(70206006)(70586007)(40460700003)(186003)(33656002)(8936002)(52536014)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 07:31:28.0405 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 33b511cd-b989-45f1-b808-08da5f218a03 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2164 SGksDQoNCkl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFzIGJlZW4gc3RhbGUgZm9yIG5lYXJs eSBhIG1vbnRoLCB3aXRoIG5vdGhpbmcgaGVhcmQNCmZyb20gbWFpbnRhaW5lcnMuIFNvIEkgYW0g c2VuZGluZyB0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJlbWluZGVyIGZvciBtYWludGFpbmVycy4N ClRoYW5rcyENCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQ0KPiBTdWJqZWN0OiBbUEFUQ0ggdjIgMC84XSB4ODZlbXVsOiBhIGZldyBzbWFsbCBz dGVwcyB0b3dhcmRzIGRpc2ludGVncmF0aW9uDQo+IA0KPiAuLi4gb2YgdGhlIGh1Z2UgbW9ub2xp dGhpYyBzb3VyY2UgZmlsZS4gVGhlIHNlcmllcyBpcyBsYXJnZWx5IGNvZGUNCj4gbW92ZW1lbnQg YW5kIGhlbmNlIGhhcyB0aGUgaW50ZW50aW9uIG9mIG5vdCBpbmN1cnJpbmcgYW55IGZ1bmN0aW9u YWwNCj4gY2hhbmdlLg0KPiANCj4gSXQgaGFzIG5vdyBiZWVuIGFsbW9zdCBhIHllYXIgc2luY2Ug dGhlIHYxIHN1Ym1pc3Npb24sIHdpdGhvdXQgaGF2aW5nDQo+IGhhZCBhbnkgZmVlZGJhY2suIFNv bWUgcmUtYmFzaW5nIHdhcyBuZWNlc3NhcnkgaW4gdGhlIG1lYW50aW1lLCBhbmQgYQ0KPiBuZXcg cGF0Y2ggKHRoZSBsYXN0IG9uZSkgaGFzIGJlZW4gYWRkZWQgLSBldmVuIGlmIHNlZW1pbmdseSB1 bnJlbGF0ZWQsDQo+IGl0IHdhcyBpbiB0aGlzIGNvbnRleHQgd2hlcmUgSSBkaWQgdGhpbmsgb2Yg dGhhdCBwb3NzaWJsZSBhZGp1c3RtZW50DQo+ICh3aGljaCBtYXkgd2FudCB0byBiZSB2aWV3ZWQg c29tZXdoYXQgUkZDLCBhcyBJIGtub3cgdGhlcmUgYXJlDQo+IHJlc2VydmF0aW9ucyBhZ2FpbnN0 IHRoZSB1c2Ugb2YgLU9zKS4NCj4gDQo+IDE6IHNwbGl0IG9mZiBvcGNvZGUgMGYwMSBoYW5kbGlu Zw0KPiAyOiBzcGxpdCBvZmYgb3Bjb2RlIDBmYWUgaGFuZGxpbmcNCj4gMzogc3BsaXQgb2ZmIG9w Y29kZSAwZmM3IGhhbmRsaW5nDQo+IDQ6IHNwbGl0IG9mZiBGUFUgb3Bjb2RlIGhhbmRsaW5nDQo+ IDU6IHNwbGl0IG9mZiBpbnNuIGRlY29kaW5nDQo+IDY6IG1vdmUgeDg2X2VtdWxfYmxrKCkgdG8g c2VwYXJhdGUgc291cmNlIGZpbGUNCj4gNzogbW92ZSB2YXJpb3VzIHV0aWxpdHkgZnVuY3Rpb25z IHRvIHNlcGFyYXRlIHNvdXJjZSBmaWxlcw0KPiA4OiBidWlsZCB3aXRoIC1Pcw0KPiANCj4gSmFu DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:40:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:40:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361906.591681 (Exim 4.92) (envelope-from ) id 1o8zdz-0003gw-Pe; Wed, 06 Jul 2022 07:40:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361906.591681; Wed, 06 Jul 2022 07:40:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zdz-0003gp-M2; Wed, 06 Jul 2022 07:40:19 +0000 Received: by outflank-mailman (input) for mailman id 361906; Wed, 06 Jul 2022 07:40:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zdy-0003gW-NS; Wed, 06 Jul 2022 07:40:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zdy-0003M8-KW; Wed, 06 Jul 2022 07:40:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zdy-0005r1-BL; Wed, 06 Jul 2022 07:40:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o8zdy-0005x2-Aq; Wed, 06 Jul 2022 07:40:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iIzYmrsu3SzM5aHVeQz3YAW9FFWALKgxj81UtP+/G3s=; b=ulCwl2u47BErE6T+1dsVgzRvfj r27Ul+nPPxnbtfpA5ia59IHpDT75s0bQKze7DULWE0/8K5prWj/xDbn0/6MselyK7NkUd4vpnDlnO LQsrkZ6bsVYLRyMoVlbLfmgLLbxYreqEdVfLz3FnNE3L1W0Iv0FgnA+2spPR5ZhxaZ8M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171512: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d82423a697790aac46680068ff64375cd12c6c94 X-Osstest-Versions-That: qemuu=19361471b59441cd6f2aa22d4fbee7a6e9e76586 From: osstest service owner Date: Wed, 06 Jul 2022 07:40:18 +0000 flight 171512 qemu-mainline real [real] flight 171523 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171512/ http://logs.test-lab.xenproject.org/osstest/logs/171523/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171523-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171502 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171502 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171502 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171502 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171502 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171502 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171502 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171502 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu d82423a697790aac46680068ff64375cd12c6c94 baseline version: qemuu 19361471b59441cd6f2aa22d4fbee7a6e9e76586 Last test of basis 171502 2022-07-05 13:08:29 Z 0 days Testing same since 171512 2022-07-05 22:07:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrij Mizyk Daniel P. Berrangé Marc-André Lureau Philippe Mathieu-Daudé Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 19361471b5..d82423a697 d82423a697790aac46680068ff64375cd12c6c94 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:54:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:54:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361920.591691 (Exim 4.92) (envelope-from ) id 1o8zr9-0005Yg-4x; Wed, 06 Jul 2022 07:53:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361920.591691; Wed, 06 Jul 2022 07:53:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zr9-0005YZ-2G; Wed, 06 Jul 2022 07:53:55 +0000 Received: by outflank-mailman (input) for mailman id 361920; Wed, 06 Jul 2022 07:53:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zr7-0005YT-T5 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:53:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zr5-0003cZ-Tz; Wed, 06 Jul 2022 07:53:51 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o8zr5-00064q-Oq; Wed, 06 Jul 2022 07:53:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=L6X3hOBY+bm+trshrQtoH0uqR+/T9n8UlILZkO8ZTP0=; b=2gSgaUCN3A/ZZUWWKGJdyCJ44i VPwzqx8Qr3gfb6XjXVIOenuXFun9i7mBeaRpUVVwPsohXGwAhCYXLz/zlgAJVpgY6/Q1kvnDN2KgV gi9A2j9ENb6x7hN7TMVccipP2ifeJkeUQegJoxPn01KzUFlxQtrC0mdqWtJftcQl3xfc=; Message-ID: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> Date: Wed, 6 Jul 2022 08:53:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL To: Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner , Demi Marie Obenour References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jan, On 06/07/2022 07:44, Jan Beulich wrote: > On 06.07.2022 05:39, osstest service owner wrote: >> flight 171511 xen-unstable-smoke real [real] >> flight 171517 xen-unstable-smoke real-retest [real] >> http://logs.test-lab.xenproject.org/osstest/logs/171511/ >> http://logs.test-lab.xenproject.org/osstest/logs/171517/ >> >> Regressions :-( >> >> Tests which did not succeed and are blocking, >> including tests which could not be run: >> test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 > > Looking at what's under test, I guess ... > >> commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 >> Author: Demi Marie Obenour >> Date: Tue Jul 5 13:10:46 2022 +0200 >> >> EFI: preserve the System Resource Table for dom0 >> >> The EFI System Resource Table (ESRT) is necessary for fwupd to identify >> firmware updates to install. According to the UEFI specification §23.4, >> the ESRT shall be stored in memory of type EfiBootServicesData. However, >> memory of type EfiBootServicesData is considered general-purpose memory >> by Xen, so the ESRT needs to be moved somewhere where Xen will not >> overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, >> which Xen will not reuse. dom0 can use the ESRT if (and only if) it is >> in memory of type EfiRuntimeServicesData. >> >> Earlier versions of this patch reserved the memory in which the ESRT was >> located. This created awkward alignment problems, and required either >> splitting the E820 table or wasting memory. It also would have required >> a new platform op for dom0 to use to indicate if the ESRT is reserved. >> By copying the ESRT into EfiRuntimeServicesData memory, the E820 table >> does not need to be modified, and dom0 can just check the type of the >> memory region containing the ESRT. The copy is only done if the ESRT is >> not already in EfiRuntimeServicesData memory, avoiding memory leaks on >> repeated kexec. >> >> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ >> for details. >> >> Signed-off-by: Demi Marie Obenour >> Reviewed-by: Jan Beulich > > ... this is the most likely candidate, considering in the log all we > see is: > > Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirty) EFI loader > Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' > Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 > Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 > Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f > Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. > > But I guess we'll want to wait for the bi-sector to give us a more > solid indication ... I have tested a Xen with and without this patch this morning and can EFI. I haven't looked into details yet why. Can we consider to revert it? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 06 07:58:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 07:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361926.591703 (Exim 4.92) (envelope-from ) id 1o8zuv-0006BF-MK; Wed, 06 Jul 2022 07:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361926.591703; Wed, 06 Jul 2022 07:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zuv-0006B8-II; Wed, 06 Jul 2022 07:57:49 +0000 Received: by outflank-mailman (input) for mailman id 361926; Wed, 06 Jul 2022 07:57:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o8zut-0006B2-W9 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 07:57:48 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51a92cb2-fd01-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 09:57:46 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8157E5C00DA; Wed, 6 Jul 2022 03:57:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 06 Jul 2022 03:57:44 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 03:57:44 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51a92cb2-fd01-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657094264; x= 1657180664; bh=dmjeI/GdbrlvLGdBYBq9CWM2/S9Mp4pyroeHZljMJHQ=; b=K sPlJ1qx2QCQ953UZhTVD6QA2qPie2OdvziAG7gfue8CjreWXcaWI7Dkaa9AGHUkl Jcd0xdvaMyN31o+TjT86bbol6Wz91m2LFzSByHLBTIk1KLhbUJgh16X8KwWSZUl9 oNLhyy/FNiaqcyPpKVpF1yY0EJ423uHQNvYqfjsrHClYWl+P3TgOfQ+pUCw3D+VW SnDAi19WaH3lK3wy24aKrSWbckd4krfv6iSL2fAOmxtdPelf88PaUNfdEzzi0xPj +3DXyGaBbfR0EYNfoRrflwCEnjfphaGMVKk4IiCmsKaDuZq6aDjPXB3Dxsd1zKo+ /W7zBflyihrQSD3A0qGSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657094264; x=1657180664; bh=dmjeI/GdbrlvLGdBYBq9CWM2/S9M p4pyroeHZljMJHQ=; b=FG/tB1sNY6xmhZ7UoL7kHBezV+CYmu36YHcHGtplQcSB 0gCKGtlN3bsXZBS9tB8azxlVeQyER8AuVaFwRGSaetuIt8ArQh7ggfMVOfJe+XNB wVZHMRWHbXuRb9y5QSrHY1UCIAzXtar2lZVFT9rUzIz+02pzG1SIlb5ZZnoKov6s AetL2+3LccLmGcEcRwo8FG6dheyK9fgDMXAf01e2vS7/TFs3+zRKUGpP9HP9WLh6 bhEVIiRw4SjNFpPZ2QRNq15uUPj51bfDken6kon/s1uNZRXyFttufYPZQX0or7RI z0eWgHcB40K7YLJCGjkNubXNajY42ZAGyMw2Ipp67g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeivddguddvfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefkefgkedvtefguedtffejlefh leetveekhefgfeetvefgtdektedtkeeuiedtfeenucffohhmrghinhepkhgvrhhnvghlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep uggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 6 Jul 2022 03:26:35 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: osstest service owner , xen-devel@lists.xenproject.org Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Message-ID: References: <12374e16-8f58-ebc1-fa78-16c9eb6f1d0b@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9QU2mazQtCSQEbPT" Content-Disposition: inline In-Reply-To: <12374e16-8f58-ebc1-fa78-16c9eb6f1d0b@suse.com> --9QU2mazQtCSQEbPT Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Jul 2022 03:26:35 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: osstest service owner , xen-devel@lists.xenproject.org Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL On Wed, Jul 06, 2022 at 09:02:47AM +0200, Jan Beulich wrote: > On 06.07.2022 08:56, Demi Marie Obenour wrote: > >>> commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 > >>> Author: Demi Marie Obenour > >>> Date: Tue Jul 5 13:10:46 2022 +0200 > >>> > >>> EFI: preserve the System Resource Table for dom0 > >>> =20 > >>> The EFI System Resource Table (ESRT) is necessary for fwupd to id= entify > >>> firmware updates to install. According to the UEFI specification= =C2=A723.4, > >>> the ESRT shall be stored in memory of type EfiBootServicesData. = However, > >>> memory of type EfiBootServicesData is considered general-purpose = memory > >>> by Xen, so the ESRT needs to be moved somewhere where Xen will not > >>> overwrite it. Copy the ESRT to memory of type EfiRuntimeServices= Data, > >>> which Xen will not reuse. dom0 can use the ESRT if (and only if)= it is > >>> in memory of type EfiRuntimeServicesData. > >>> =20 > >>> Earlier versions of this patch reserved the memory in which the E= SRT was > >>> located. This created awkward alignment problems, and required e= ither > >>> splitting the E820 table or wasting memory. It also would have r= equired > >>> a new platform op for dom0 to use to indicate if the ESRT is rese= rved. > >>> By copying the ESRT into EfiRuntimeServicesData memory, the E820 = table > >>> does not need to be modified, and dom0 can just check the type of= the > >>> memory region containing the ESRT. The copy is only done if the = ESRT is > >>> not already in EfiRuntimeServicesData memory, avoiding memory lea= ks on > >>> repeated kexec. > >>> =20 > >>> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-= itl/T/ > >>> for details. > >>> =20 > >>> Signed-off-by: Demi Marie Obenour > >>> Reviewed-by: Jan Beulich > >> > >> ... this is the most likely candidate, considering in the log all we > >> see is: > >> > >> Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-d= irty) EFI loader > >> Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' > >> Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 > >> Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 > >> Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f > >> Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. > >=20 > > This would not surprise me at all. I was hoping that Jan would be able > > to test this before he merged it, especially the ARM-specific stuff. >=20 > Jan (i.e. me)? I've never done any testing on Arm; all I do is build-test > things there. Also if you suspected there might be issues, I think you > should have arranged for someone to test this, i.e. at the very least > indicate so in a post-commit-message remark targeted at the eventual > committer. I don't have access to an ARM64 machine (other than a mobile device) myself, so I can't test anything on that platform. I did not *expect* there to be any issues, but I am not surprised that there are. I should have done a basic smoke test on x86, though. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --9QU2mazQtCSQEbPT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLFOUYACgkQsoi1X/+c IsF5ww/+MpL+dLCGIcFZxLwuSkevBR0p89ufuOJ1heCxbyY7CiPbfTjhNGyrD+bw SPBIACbxKIatJu3Mqlb7CfLpQHCF/fgcpe/6XOynDEblc1DGDpaAoie0vVDYRYwK l97nh19F6wy/xlRESGPaFRW2aAfPz4lnL7udYfs/fIM72pb3BWUpThGahe6vucDt aQtVFe7yBBjtZ3KfLSpCOohsX1LfTIpUH8aUrMF/ph6fSEqmmgqzmMrEj57T9Glp xslBTW50HF8CdyTSUNgu0UcApfr+FuROqdXjyMw5N29cdz+ep2YIZ97oULu77DX/ xwgQrE6IL7tnHrIkBliHD1WytZ4iOOCLIP0fb4X1rmrNCxHJIerI3VceC2uJ4HG4 TD7x8HitF7ie2RVuKtojIMkmwesb9+zqRzUt22Sj8CZHOc1blAnxaH7rJo/VUldL EOQQLkBj/xMXU+c9Jf7q0NK8lyn9WXU+QkPK8Ov/mjyRim/M9qLPBuyJ5NbefJmK 713aeZn+ImfZNt1wd9XMdpyEvOaEP45oT0KjcmDyOShG+ESTzhVUab8hZ3BMejMx 5aspG8WfL1GVj7kZqi/JOa8CYzjfz6niww/bsnRwzMpqAi8y9hWV4riak5TaQHW8 AzOq63MctQycywQX6/Buks9qO3EMYhJzbDuOwbg1Nh+LyWBpJrg= =jJsH -----END PGP SIGNATURE----- --9QU2mazQtCSQEbPT-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:05:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:05:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361936.591714 (Exim 4.92) (envelope-from ) id 1o902Z-0008NX-O5; Wed, 06 Jul 2022 08:05:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361936.591714; Wed, 06 Jul 2022 08:05:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o902Z-0008NQ-L3; Wed, 06 Jul 2022 08:05:43 +0000 Received: by outflank-mailman (input) for mailman id 361936; Wed, 06 Jul 2022 08:05:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o902Y-0008NK-Kw for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:05:42 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ca0cb6f-fd02-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 10:05:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4BBB95C01EA; Wed, 6 Jul 2022 04:05:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 06 Jul 2022 04:05:39 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 04:05:38 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ca0cb6f-fd02-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657094739; x= 1657181139; bh=S+iXG6vR99bBJb+KySeOfzJsoOuMGxh7CZz66f7wlos=; b=F JT2vOPBfudE93TJ+/L3uRxQtnpkyHH5Cxop03oB7n11Vxf3XfkNUdAeiImxCsqX1 3IUt++1xdYzlkSHYykw1tgnmIv+izHv+PvNqXAxx8n/tQvOprY8MRyu7ybQQy6UP BSX/Ne7fI7qCn0/LLVSzAZIvyuqeKkSmahpeYgsf3kve6NqSp5vQSoEez23FI2aq tDovL2cU6EZ4/db43J7dG4qM5HfvVhWBmiSrYT0HpZKPS5CUP6PEABDaqWPdMrlm fzCqAjoCq26k0y9tgXJEt17hmrBjBfT+RlcVv6kdiwCChLgjIIFZZptANaIFywKX 2zck9uPOqsHlv++ZBgYxw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657094739; x=1657181139; bh=S+iXG6vR99bBJb+KySeOfzJsoOuM Gxh7CZz66f7wlos=; b=rSn+rupbRJ1cPesPHMhb1dtDzfDQca/mkFYtPSH4Nk1i cWaH/ugMfRPzRkVHioulyB9wbTIUwnMNudMEND6ZTDG/qArywgjnXjK7myYHq5mb WwdN9MzTM3HD0WZ2GKxT11hOkyifzRAlyQEkqamtUD3TNgtNXZA2QrwSObm2EKzn gY48MdYo8xG9eE1sK+actKSIbC/cE6LsSbjHhhX4DPTRei3/Gwwv9TiHeor51oyk YMS9rbJ/jH8ghFGPNLkVRXgDgjuFOLFVCOuHA6/qu2EGAqXoQMW6ujc6cpMu2tzt PzgyG/+p23DNTaQtxbwapN2uLakSdJBCtAREm579GQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeivddguddvhecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekvdeuvdejgeevhfegvdegleeg teetueeihfevteffgfdvhfdvffejfedvieelgeenucffohhmrghinhepgigvnhhprhhojh gvtghtrdhorhhgpdhkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 6 Jul 2022 04:05:35 -0400 From: Demi Marie Obenour To: Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Message-ID: References: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9w2Cap5vluFac+Ud" Content-Disposition: inline In-Reply-To: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> --9w2Cap5vluFac+Ud Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Jul 2022 04:05:35 -0400 From: Demi Marie Obenour To: Julien Grall , Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL On Wed, Jul 06, 2022 at 08:53:49AM +0100, Julien Grall wrote: > Hi Jan, >=20 > On 06/07/2022 07:44, Jan Beulich wrote: > > On 06.07.2022 05:39, osstest service owner wrote: > > > flight 171511 xen-unstable-smoke real [real] > > > flight 171517 xen-unstable-smoke real-retest [real] > > > http://logs.test-lab.xenproject.org/osstest/logs/171511/ > > > http://logs.test-lab.xenproject.org/osstest/logs/171517/ > > >=20 > > > Regressions :-( > > >=20 > > > Tests which did not succeed and are blocking, > > > including tests which could not be run: > > > test-arm64-arm64-xl-xsm 8 xen-boot fail REGR.= vs. 171486 > >=20 > > Looking at what's under test, I guess ... > >=20 > > > commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 > > > Author: Demi Marie Obenour > > > Date: Tue Jul 5 13:10:46 2022 +0200 > > >=20 > > > EFI: preserve the System Resource Table for dom0 > > > The EFI System Resource Table (ESRT) is necessary for fwupd to i= dentify > > > firmware updates to install. According to the UEFI specificatio= n =C2=A723.4, > > > the ESRT shall be stored in memory of type EfiBootServicesData. = However, > > > memory of type EfiBootServicesData is considered general-purpose= memory > > > by Xen, so the ESRT needs to be moved somewhere where Xen will n= ot > > > overwrite it. Copy the ESRT to memory of type EfiRuntimeService= sData, > > > which Xen will not reuse. dom0 can use the ESRT if (and only if= ) it is > > > in memory of type EfiRuntimeServicesData. > > > Earlier versions of this patch reserved the memory in which the = ESRT was > > > located. This created awkward alignment problems, and required = either > > > splitting the E820 table or wasting memory. It also would have = required > > > a new platform op for dom0 to use to indicate if the ESRT is res= erved. > > > By copying the ESRT into EfiRuntimeServicesData memory, the E820= table > > > does not need to be modified, and dom0 can just check the type o= f the > > > memory region containing the ESRT. The copy is only done if the= ESRT is > > > not already in EfiRuntimeServicesData memory, avoiding memory le= aks on > > > repeated kexec. > > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail= -itl/T/ > > > for details. > > > Signed-off-by: Demi Marie Obenour > > > Reviewed-by: Jan Beulich > >=20 > > ... this is the most likely candidate, considering in the log all we > > see is: > >=20 > > Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-di= rty) EFI loader > > Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' > > Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 > > Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 > > Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f > > Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. > >=20 > > But I guess we'll want to wait for the bi-sector to give us a more > > solid indication ... >=20 > I have tested a Xen with and without this patch this morning and can EFI.= I > haven't looked into details yet why. >=20 > Can we consider to revert it? I'm fine with reverting it for now, but I would like to know what the bug was. Does a Xen with this patch boot okay on x86? If so, could it be temporarily turned off on ARM until the problem can be tracked down? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --9w2Cap5vluFac+Ud Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLFQlAACgkQsoi1X/+c IsG0zQ/3TAxDEWHyO7PbAj8RSOS093O7ZKU8DomvD27eC9a+egHWPXslzWcKUjfn N0rIpWIhB8EXAQsEsajziAsflixN3BumXpU56zukEs4Roh2lon2Ex8TQ53pexiX6 b9LJ3Y/D/P1dwxyH1/auu2wPT+qehHm/YKhDjCqfVeir2mP5Fjn3V7NafcWZ8AXA EalbdP2KOc4BXBEJPSFDbC97wPollFz1xdP0BbFGNMwiQwiZ8oMEkosSWEEKG4cV WCsUk2V7VPaTIDBgO0oornZ7VKQYPsTd75dnbFFKppayu4k+K4eJtxWwuAlT4PTe B5iwxcb109HvMEmg8e88ppdEhYJurOTJSBL4wSE0NpbU0rlX4uT2zvnoWNXB1Wd2 hR3emKrMe1Lf3L5sEkdrOYPZ3hFn8+uNnmhU0koMpQBzFLPycbFXWJqa21Rt7NY+ zi9qvBq8+QJkPN2BPs/mJckiUgXH2mkseFZYWJr9ReL6WMNJQxmUvLXvaHIyUKmE HLUnUK+nopwwELYZNrT/O7qLa4zF6dEplUgVzwH+598S74yLrBAWOVJPInuBSKR7 cJLTv+fALmAMQtKQ6COfzJfd6ZiR/zrVe3zJNP1KEKU0x3ikFnwR4vghJdhKJdod FwUN76mGUohzqfZeU73wez7OnWFXdPXP5YGGDo9qeiHcUshLRg== =PxNo -----END PGP SIGNATURE----- --9w2Cap5vluFac+Ud-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:17:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:17:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361942.591724 (Exim 4.92) (envelope-from ) id 1o90Dq-0001es-MX; Wed, 06 Jul 2022 08:17:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361942.591724; Wed, 06 Jul 2022 08:17:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90Dq-0001el-Ji; Wed, 06 Jul 2022 08:17:22 +0000 Received: by outflank-mailman (input) for mailman id 361942; Wed, 06 Jul 2022 08:17:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90Dp-0001ef-L8 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:17:21 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e45293a-fd04-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 10:17:20 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id h14-20020a1ccc0e000000b0039eff745c53so8517258wmb.5 for ; Wed, 06 Jul 2022 01:17:20 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id q11-20020adfea0b000000b0020fff0ea0a3sm34471738wrm.116.2022.07.06.01.17.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 01:17:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e45293a-fd04-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=loc17+3WYD5W3w9zBMYX7h5+wACGmAaV/gF7By+b5K8=; b=c7xwFVjl6i+/DXUWzvUZz5x7uu8ucah4IILFf3gBN/T/wVCRKcBbMCOeKSpO2cH5sa 0Iy7Ewb0UngjzdWyzkmO+RdnuL7hEvusj8ZVH8pvLFHgrWAsUrJIhMW+nGUh2VzJt+Mx EcbpWIS6b4IQuMb+QLkrtl/uTiM4m9H3OhFYfQHeACHRO9nClYTYcws6kyXUk/jks5E4 E4UeeACEOchHzsPX95qX/IXqHaIyMPH0PW8wWbz2ULUQlpfkScHSx/APwVN2Qa1yN61r yYUtsG0VRUz5HOM1rvA5fiLCSqETZmT6+fEmeXYbg56Yk6ZxfzdNBWMRVhfmyWVvIdZo O57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=loc17+3WYD5W3w9zBMYX7h5+wACGmAaV/gF7By+b5K8=; b=ujbPs6F/bE8wiWLVQ8zTZiBN0Y/8k2XgpEdQTWlL+b9siFrmxQ3zipdqV60olGBMsO uC9Ea2yr36iXURoXxJ3gmETHo5Y2CpXYRmE6FQJzCNQ6+OqOIKaiBGjeogOE+kAFcpTa A+luSGCnt4QYbg4wPUS1SUmiJ10J7ZKmFhic2YwlsFjvPIxCo3/JsyMGUH/IstwqO1aJ iw2PBF1ZlRDnKAxu4Y6xZR+7E/y8DtJlrLj5MBOr9M3GIOlGR7UiI/AgjPdPEzmY5zCE X6P6QkihLr2o4NtM6gPOV0JZVSVB+82HW3qvUgKIs5csLXX5sYpUKfjEBuvUf1G8PLHf 7ZWw== X-Gm-Message-State: AJIora+Q0qjVnenm0PTGgMogEu9aWtkIWwXQLmRXcbGIOTfgSvrzRnqy DLMXcCpF0jWcY3eixgU6sLA= X-Google-Smtp-Source: AGRyM1vW/3k4wUJE0lcdkZEuaQO86vsMns9bJM6DK2/BbiBPLZqJUPQi8TomfncMSI3JJAsupqp3+w== X-Received: by 2002:a7b:c3cd:0:b0:3a1:95b6:3fd0 with SMTP id t13-20020a7bc3cd000000b003a195b63fd0mr22221776wmj.75.1657095439868; Wed, 06 Jul 2022 01:17:19 -0700 (PDT) Message-ID: <4499c0fe-a9f5-919f-bf46-43d30ef8b04c@gmail.com> Date: Wed, 6 Jul 2022 11:17:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 4/4] xen/char: pv_console: Fix MISRA C 2012 Rule 8.4 violation Content-Language: en-US To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-5-burzalodowa@gmail.com> <47ed7737-5422-e4be-c99d-0e448616f5b5@xen.org> <540e8f0d-8a1f-f80d-c6f2-05192600c4bd@suse.com> From: Xenia Ragiadakou In-Reply-To: <540e8f0d-8a1f-f80d-c6f2-05192600c4bd@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/6/22 10:18, Jan Beulich wrote: > On 06.07.2022 00:02, Xenia Ragiadakou wrote: >> Hi Julien, >> >> On 7/6/22 00:38, Julien Grall wrote: >>> Hi Xenia, >>> >>> On 05/07/2022 22:02, Xenia Ragiadakou wrote: >>>> The function pv_console_evtchn() is defined in the header >>>> . >>>> If the header happens to be included by multiple files, this can >>>> result in >>>> linker errors due to multiple definitions, >>>> So, it is more appropriate to resolve this MISRA C 2012 Rule 8.4 >>>> violation >>>> warning by making pv_console_evtchn() inline with internal linkage. >>> >>> There are multiple version of pv_console_evtchn(). The version below is >>> only used when !CONFIG_XEN_GUEST. >>> >>> The header is also included multiple time within Xen. So I am a bit >>> puzzled why we haven't seen this error before. Maybe this is unused when >>> !CONFIG_XEN_GUEST? >>> >>> If yes, I would remove the call. If no, then I think the commit message >>> should be clarified. >> >> You are right. I had to clarify that this holds when !CONFIG_XEN_GUEST. >> So when !CONFIG_XEN_GUEST, the function pv_console_evtchn() is defined >> inside the header file and the header is included only by a single file. >> This is why the error has not been triggered. > > Irrespective of that it is as Julien suspects: The function is only ever > referenced when XEN_GUEST. Hence the better course of action indeed looks > to be to ditch the unused stub; we don't even need DCE here for there to > not be any references. Yes, if the function is not used at all when XEN_GUEST, then I think its definition is considered unreachable code (Rule 2.1) and needs to be removed. -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:17:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:17:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361944.591736 (Exim 4.92) (envelope-from ) id 1o90EC-00021h-2F; Wed, 06 Jul 2022 08:17:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361944.591736; Wed, 06 Jul 2022 08:17:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90EB-00021a-VX; Wed, 06 Jul 2022 08:17:43 +0000 Received: by outflank-mailman (input) for mailman id 361944; Wed, 06 Jul 2022 08:17:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90EA-000215-Pe for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:17:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90E8-0004bx-Mx; Wed, 06 Jul 2022 08:17:40 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.0.187]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o90E8-0007MQ-Gg; Wed, 06 Jul 2022 08:17:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bYRyEDOrnsxxD8N5mq/TeeunkwtRLIqNH5fRTqKwsr8=; b=uipiEAbcfMHO+N5TXYnXYST0O3 1gcvrga2RM9r6/OVYnXF8piHwwGQ/OJa+5r5lM8t3kIhmy6lomVCgefFyPifid3MYMsK5CdVdS2D/ 2n5N8bvD7JdbpepZUET7yS2SzfejP30bKP1nkq7yUC0+TkWtYIrxJBAWw/3Csq2EEfnk=; Message-ID: Date: Wed, 6 Jul 2022 09:17:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL To: Demi Marie Obenour , Jan Beulich , xen-devel@lists.xenproject.org Cc: osstest service owner References: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Demi, On 06/07/2022 09:05, Demi Marie Obenour wrote: > On Wed, Jul 06, 2022 at 08:53:49AM +0100, Julien Grall wrote: >> Hi Jan, >> >> On 06/07/2022 07:44, Jan Beulich wrote: >>> On 06.07.2022 05:39, osstest service owner wrote: >>>> flight 171511 xen-unstable-smoke real [real] >>>> flight 171517 xen-unstable-smoke real-retest [real] >>>> http://logs.test-lab.xenproject.org/osstest/logs/171511/ >>>> http://logs.test-lab.xenproject.org/osstest/logs/171517/ >>>> >>>> Regressions :-( >>>> >>>> Tests which did not succeed and are blocking, >>>> including tests which could not be run: >>>> test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 >>> >>> Looking at what's under test, I guess ... >>> >>>> commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 >>>> Author: Demi Marie Obenour >>>> Date: Tue Jul 5 13:10:46 2022 +0200 >>>> >>>> EFI: preserve the System Resource Table for dom0 >>>> The EFI System Resource Table (ESRT) is necessary for fwupd to identify >>>> firmware updates to install. According to the UEFI specification §23.4, >>>> the ESRT shall be stored in memory of type EfiBootServicesData. However, >>>> memory of type EfiBootServicesData is considered general-purpose memory >>>> by Xen, so the ESRT needs to be moved somewhere where Xen will not >>>> overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, >>>> which Xen will not reuse. dom0 can use the ESRT if (and only if) it is >>>> in memory of type EfiRuntimeServicesData. >>>> Earlier versions of this patch reserved the memory in which the ESRT was >>>> located. This created awkward alignment problems, and required either >>>> splitting the E820 table or wasting memory. It also would have required >>>> a new platform op for dom0 to use to indicate if the ESRT is reserved. >>>> By copying the ESRT into EfiRuntimeServicesData memory, the E820 table >>>> does not need to be modified, and dom0 can just check the type of the >>>> memory region containing the ESRT. The copy is only done if the ESRT is >>>> not already in EfiRuntimeServicesData memory, avoiding memory leaks on >>>> repeated kexec. >>>> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ >>>> for details. >>>> Signed-off-by: Demi Marie Obenour >>>> Reviewed-by: Jan Beulich >>> >>> ... this is the most likely candidate, considering in the log all we >>> see is: >>> >>> Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirty) EFI loader >>> Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' >>> Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 >>> Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 >>> Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f >>> Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. >>> >>> But I guess we'll want to wait for the bi-sector to give us a more >>> solid indication ... >> >> I have tested a Xen with and without this patch this morning and can EFI. I >> haven't looked into details yet why. >> >> Can we consider to revert it? > > I'm fine with reverting it for now, but I would like to know what the > bug was. Does a Xen with this patch boot okay on x86? I haven't tried and I don't know whether we have UEFI system on x86. > If so, could it > be temporarily turned off on ARM until the problem can be tracked down? I am not in favor of this approach. There are no reason for this to be x86-only aside there is a bug in the code. AFAICT, this is always an issue on Arm (both QEMU and Softiron fails to boot). It still not clear whether it might fail on some x86 systems. So we first need to figure out what's happening. I am planning to spend some time on it today (as a low priority). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:26:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:26:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361955.591747 (Exim 4.92) (envelope-from ) id 1o90MW-0003zQ-T6; Wed, 06 Jul 2022 08:26:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361955.591747; Wed, 06 Jul 2022 08:26:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90MW-0003zJ-Q3; Wed, 06 Jul 2022 08:26:20 +0000 Received: by outflank-mailman (input) for mailman id 361955; Wed, 06 Jul 2022 08:26:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90MV-0003zD-IM for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:26:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4eb6bb86-fd05-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 10:26:18 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D900B1596; Wed, 6 Jul 2022 01:26:17 -0700 (PDT) Received: from a015971.shanghai.arm.com (unknown [10.169.188.104]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2D9923F792; Wed, 6 Jul 2022 01:26:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eb6bb86-fd05-11ec-bd2d-47488cf2e6aa From: Jiamei Xie To: xen-devel@lists.xenproject.org Cc: Jiamei Xie , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Wei Chen Subject: [PATCH v4] xen/arm: avoid overflow when setting vtimer in context switch Date: Wed, 6 Jul 2022 16:25:58 +0800 Message-Id: <20220706082558.1116811-1-jiamei.xie@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit virt_vtimer_save() will calculate the next deadline when the vCPU is scheduled out. At the moment, Xen will use the following equation: virt_timer.cval + virt_time_base.offset - boot_count The three values are 64-bit and one (cval) is controlled by domain. In theory, it would be possible that the domain has started a long time after the system boot. So virt_time_base.offset - boot_count may be a large numbers. This means a domain may inadvertently set a cval so the result would overflow. Consequently, the deadline would be set very far in the future. This could result to loss of timer interrupts or the vCPU getting block "forever". One way to solve the problem, would be to separately 1) compute when the domain was created in ns 2) convert cval to ns 3) Add 1 and 2 together The first part of the equation never change (the value is set/known at domain creation). So take the opportunity to store it in domain structure. Signed-off-by: Jiamei Xie --- was "xen/arm: avoid vtimer flip-flop transition in context switch". v4 changes: - re-write commit message --- v3 changes: - re-write commit message - store nanoseconds in virt_timer_base instead of adding a new structure - assign to nanoseconds first, then seconds --- xen/arch/arm/include/asm/domain.h | 1 + xen/arch/arm/vtimer.c | 9 ++++++--- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index ed63c2b6f9..cd9ce19b4b 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -71,6 +71,7 @@ struct arch_domain struct { uint64_t offset; + s_time_t nanoseconds; } virt_timer_base; struct vgic_dist vgic; diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c index 6b78fea77d..aeaea78e4c 100644 --- a/xen/arch/arm/vtimer.c +++ b/xen/arch/arm/vtimer.c @@ -63,7 +63,9 @@ static void virt_timer_expired(void *data) int domain_vtimer_init(struct domain *d, struct xen_arch_domainconfig *config) { d->arch.virt_timer_base.offset = get_cycles(); - d->time_offset.seconds = ticks_to_ns(d->arch.virt_timer_base.offset - boot_count); + d->arch.virt_timer_base.nanoseconds = + ticks_to_ns(d->arch.virt_timer_base.offset - boot_count); + d->time_offset.seconds = d->arch.virt_timer_base.nanoseconds; do_div(d->time_offset.seconds, 1000000000); config->clock_frequency = timer_dt_clock_frequency; @@ -144,8 +146,9 @@ void virt_timer_save(struct vcpu *v) if ( (v->arch.virt_timer.ctl & CNTx_CTL_ENABLE) && !(v->arch.virt_timer.ctl & CNTx_CTL_MASK)) { - set_timer(&v->arch.virt_timer.timer, ticks_to_ns(v->arch.virt_timer.cval + - v->domain->arch.virt_timer_base.offset - boot_count)); + set_timer(&v->arch.virt_timer.timer, + v->domain->arch.virt_timer_base.nanoseconds + + ticks_to_ns(v->arch.virt_timer.cval)); } } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:43:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:43:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361962.591758 (Exim 4.92) (envelope-from ) id 1o90dR-0006kB-Cn; Wed, 06 Jul 2022 08:43:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361962.591758; Wed, 06 Jul 2022 08:43:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90dR-0006k4-9b; Wed, 06 Jul 2022 08:43:49 +0000 Received: by outflank-mailman (input) for mailman id 361962; Wed, 06 Jul 2022 08:43:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90dQ-0006jy-Vc for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:43:49 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c087d745-fd07-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 10:43:48 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id f190so8387243wma.5 for ; Wed, 06 Jul 2022 01:43:48 -0700 (PDT) Received: from [192.168.1.10] (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.gmail.com with ESMTPSA id h15-20020a1ccc0f000000b0039749b01ea7sm33352907wmb.32.2022.07.06.01.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 01:43:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c087d745-fd07-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=HvgVgBjxmDEC7BUXUWxN5Ar4FzPasbbILopqKZ/AQjY=; b=bFs7AISnYlfjo8ptoltfMipbLLwj3uti+l1tPCS0BufQBhLSp2avLjjhlpLInoe50i +MUnjxd2ENn3n8OPoz6MnDAJUoneWNy4aQuG7LXeklxLMLaYNlPh7UXRgo92VI3u1YT7 nqBugMTRQrJHs6e6/qlChoKLXIP2j5bmNS5/9N95gccsisDKDjUytk7h7SF9B/ekGpRV UPYKbZNUnhqJHieniq1LRvjAO14cqYkYCHJ3i2oJywu8vtbBeK53bfdW1OsFo7eXypPF Uj+ss5gtPzlwR4zFA4GAQYzfIN/0taOe2kz53vQMU+l6f/Kut+0p7aYnEDD4l+wxDcXq pmKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HvgVgBjxmDEC7BUXUWxN5Ar4FzPasbbILopqKZ/AQjY=; b=FNoKACnHoqV/R2RkGpGtdMRZKiBPkYC/B1K6+wRRiF1zJu0AKIEKw1+4c0Bx2bui/h XX5fwGKqJP744EzsMUo+M+KVZduP9852OUhLPKOLFGjTWn2HwvKl2ZBBuSSwIVwfHrin +WTfZ1IIf+cZoFAugklCYbnSpcW5AxEuUVEocoyH0xe3zbr+Lq+L5FqFPNeoARrR+u3m onLMhKI22TTg8Sn6TA8xgl9DihU7AJoywZ5smX9TmbX9wrNM8Pyew/umG8IYeN+6RjYo n+WEaylGZvggaidb7Ul7SasHMMBgeKAPIqoo1JYF5p+b6wf+Vlf+mErOcur45a35Y3SV 1jeg== X-Gm-Message-State: AJIora9NNEcN5Sf/xXfg3CALa21ah0RJRXM7PmTbzSvnUbTfEJJgRP2V WhUlYCT4O9bpAHRrSc8o/lo= X-Google-Smtp-Source: AGRyM1ueGTxN3952cGT56AtMHet2CLP64G68z63zsnHDQPrjYHeDzfLjqOnmzN+g6pp+6xK1dzxk8A== X-Received: by 2002:a1c:e907:0:b0:3a0:3e42:9c72 with SMTP id q7-20020a1ce907000000b003a03e429c72mr41321529wmc.162.1657097027502; Wed, 06 Jul 2022 01:43:47 -0700 (PDT) Message-ID: <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> Date: Wed, 6 Jul 2022 11:43:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> From: Xenia Ragiadakou In-Reply-To: <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/6/22 10:10, Jan Beulich wrote: > On 05.07.2022 23:02, Xenia Ragiadakou wrote: >> The function idle_loop() is referenced only in domain.c. >> Change its linkage from external to internal by adding the storage-class >> specifier static to its definitions. >> >> Since idle_loop() is referenced only in inline assembly, add the 'used' >> attribute to suppress unused-function compiler warning. > > While I see that Julien has already acked the patch, I'd like to point > out that using __used here is somewhat bogus. Imo the better approach > is to properly make visible to the compiler that the symbol is used by > the asm(), by adding a fake(?) input. I 'm afraid I do not understand what do you mean by "adding a fake(?) input". Can you please elaborate a little on your suggestion? -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:46:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:46:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361967.591768 (Exim 4.92) (envelope-from ) id 1o90gP-0007Ll-SH; Wed, 06 Jul 2022 08:46:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361967.591768; Wed, 06 Jul 2022 08:46:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90gP-0007Le-PO; Wed, 06 Jul 2022 08:46:53 +0000 Received: by outflank-mailman (input) for mailman id 361967; Wed, 06 Jul 2022 08:46:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90gO-0007LY-9Y for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:46:52 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2070.outbound.protection.outlook.com [40.107.20.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d94a737-fd08-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 10:46:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4296.eurprd04.prod.outlook.com (2603:10a6:209:50::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 6 Jul 2022 08:46:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 08:46:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d94a737-fd08-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ioR0u1HhB8K4jlvKallxTUrg3q78M8c0OPCD49Vdc0PNKW4CWOGYSXwpsnDBC0UyevOutK2mzaRQde6XESqgMBPSP/k6lq7S/T+Lvitdt7vHhrOM5sNiS3WiSCtkg8aCjwOBRyqrG/0E6c+px2V2ZbgHEQiGs84PimIXvRvmKHVDANUvjyhraTbLFs1JK3hiNJUkxyJBO/glLK6RJWOaAxehfryHsxX5/dTu+PkYO5OdD/dPjrL8m+rnIQEhFVkh9d3zRjGTg52F59pNGQWMRIJg9gF+z/aTAO0hvLI54M+GCnUKzJ0366M9KslKZvme6OHpYe2bLlf/tmZYeIBYGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OYwDSGtlzCDza/XFA6m56Oh4qahZA6wtvisv2G3Sy9w=; b=FiE0b/s6hXvj5DGqGZ9t4WuWdgTcz+zwdwmVU8xRZNlRTLeBGczcyiaEfx0oGnd1puQ8yXqdw+r4m05xGC7+m2nfGFqCm5jVSQE/5NXh4oMY6jMxrPk/bh0kL+m/0QMi+lD5/AdnPwn3WVcpi5Nfu8PY01zy2b2XBxj/BOidpQOlC2ayM9Dd1uv7BuQUgSD5aHIX8oHv5hwhg/ShpRSPDsVY+pACRt7I0aCtlvbavsgDkcKyNgQXqkwZBLNompR3eJ3UsXQMJ+uCwbX4lsoCWejFKG5XpS8my5SgtFFppDHlJWijzj0IbGpIKQ+GJsn7BjPBA2Tiv8vrV34yRhqnxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OYwDSGtlzCDza/XFA6m56Oh4qahZA6wtvisv2G3Sy9w=; b=L+E/+wGnrD9pzX1BKV7PGjKcb3+RO15ih0/swDDby9h2s1OmTuyrBhV33kXrYgut5yboV/3HTs7IST8FxWJ38A+reaVucErV+QXygTlsWaw83M7ZzbmKwH7yG6DhikNQWieQEDBD7bHlY6yRbZEI4OWTet11k6s/+cGTLIOCwjG6BQd5LCexONw57enMzIJ+Ho3eZ/5IrOsnLvqzKKK3V1UD1dooKZQyj2fDaqlQFwvaIpwMYUPmYorlkHsBkdbr0Q53As3A6Idqs5huazvwyjadRECqHTV2Njqr4876aDIgZcsMZknjS5dYvB1WzDKVaLYqMLYDvrJC0qwd6YnL2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <58b535a2-f916-3c95-6b96-4ab0b7541ec4@suse.com> Date: Wed, 6 Jul 2022 10:46:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Content-Language: en-US To: Julien Grall , Demi Marie Obenour Cc: osstest service owner , xen-devel@lists.xenproject.org References: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8P189CA0010.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68766e09-9f5b-4889-5f31-08da5f2c105f X-MS-TrafficTypeDiagnostic: AM6PR04MB4296:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CDF8KYc1UFKabHdF5AzuI7MQ/C4PI7bbGTkYCRfarigZgPn3KPse0qjls/AIwSSd2LYVP+vVZzN+eU70U2lQRFA9Fh6ixjr+Pu3Av7WdFqTqhpW7jp1+3s0yZrbD5N7Id4svT4gKpFe2ZPkG8SZdaAwJ0zsCUbK1x5aFmoibSYK+PkOHjlcjt3j6+lvUvrCeQGslIpynwJ/mSYaiqdn5Q6AlpP2pqF0Vz03vG94aZywr/O0swSPNNuYmqgBNVq2+MrgSEKgW1ysJR77zxkJnuHQQybyflWZ7arynI3kse4/pUE3YbOAMlq6/4vt0n7/eyL1TDW9zj1kys+FtVXYkaAvePFP4Hbnu7FZhfprV6sN5y/4urXnDixDsqLaUTIKg5Kv3Y8XPSaCmPx26GVj1HKAcPboHZ7yVxYQgnps8/LvXjK3tJ09GkwLZhUrlWf8WAcIobTnPAPl9c1qPxqxKE8xkWd7UQmee3O0BDfKGR48drhZtFdhOHzCHwfk2qDhliZeBRlXMm/XAd8NOZMI+tGCX99KonE4xIH6pNo5MhhQzG9PVt67v7922qSGzqq76sp9kwIJW74N7j9PAgOtuVOBNcbz5UX7qbBTIJsxq6lfZq5jbbhX7j9eo9TvQURNHa6ZJWKWq+gkg9t+3SuI8e8zcrmDmx4/gWx9MYYp/MWvmgnR65BHqbJE1yeFXLrHIpascdzqWMsmsFzLsQleKQW4ZU1JqAgWDLXVautaX8F6g3jkjPfE9q5mYvZJ/TF6W17oLMvhkN7+2Pb/ty+kbST1CnjLn+/E8pgI0jHFBn665Y1MRPLnSGe3YY4BztPUarkhHWnrxJM09Rzxv3Y6Czt/OGo/u3msmz7azfGBWOGVNMnxuDCTuCyFTBv/nSt4mMSnYyyg1rV7WrsMkXVs7Syta7keNKKlWef2wH+2BMPo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(26005)(6506007)(83380400001)(41300700001)(2906002)(110136005)(53546011)(316002)(36756003)(31686004)(38100700002)(966005)(6486002)(8936002)(31696002)(5660300002)(86362001)(2616005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aG1YckRYT1lJTXpUdGJlZ2lzZ1RrbXBLZ0xSWERqSTlrT04vZjI2Y0QwcndJ?= =?utf-8?B?SEE4a2I3QkpQa2RVanJHcXc4V3I1RGwyUHZHZkcxb0xUem1hK3hTUk41ZGRs?= =?utf-8?B?WlRVQzEzRUtlZ3M4SUdHRmtFc2JRMGZHdHlHVllqalF5UGdFYW1KMkRhSG1i?= =?utf-8?B?R3V1eXpxVlVhZmtBek40SFZUZW8yYnZYNWR5WUxKMHBTUkJGQmhZckN6dVVB?= =?utf-8?B?ekoxOU1WM3BFMW9zODQycFBDbXIweld0VHNidmlqczJSOUhHYlJQNGZYSGlx?= =?utf-8?B?SE93NlEzY0FHYWROVjZ3VjRUekVTMDVMRjF4dzFRbmlqTDNGaU5rcisyZWd1?= =?utf-8?B?YkozYjdPNjBaWEJPcmFqS25CQ2lVTERERHVtWFFlS043TFJkME1nQU1XNDBK?= =?utf-8?B?aUwrVit0NEl4cDZVUm1ySDhnNlFsR1FMcHcyclBwWWg5UGJCVU85L1hDUlF4?= =?utf-8?B?U1JRQ0ZVb0Rqc1ZCNkU3TXEzcVErckN5TTNuZklSU0NWeWZqSzdvaGlaUlh6?= =?utf-8?B?MVY0R1A1bWZtYzVkY3V6Zm5rbXpUZG9ra3BhM2xIck9rSFMxUktVbUorK29R?= =?utf-8?B?N2ltYWkyMVYrVGJnQkxyVkdOUVJzWWZsMDUzbjk1ZkNReVk2R3lwNGtBL3dD?= =?utf-8?B?UzVlTVhrTllPQk03a1VYSVI3ajJ0Z1VUZkZOZHdpa3JXUUEzTmd5R0lBbGRM?= =?utf-8?B?VWpvOVk2SktaWmpsMlFRU3NFUWVZeG1GT08wQWFuU2ZacENSOVlzTGFwTkFD?= =?utf-8?B?NStoSkNIeGNuOFUySHg5eFIwVWVrOVdlMWJKenlCTHhXWUNZeTFVaTdFOXhv?= =?utf-8?B?Um5vK0RUSFZkb0Z0a2VhVmJhOFZNcDg2aGVJRjRlSVJZNlhodWFGZ2tyUU1r?= =?utf-8?B?OVh4eWd3eXlYQkpyYjZGOE1hMkdTRzI1bHVNQThCZE5LR2dxSW5yMUxxVDU2?= =?utf-8?B?R3drUkFsUUxrVVdYdUJyYldrWHB1MHNGYmlxTFVjbHM5bm1YaUllNjBTcmJO?= =?utf-8?B?OUxjUTRUbG55MmV4TmNOa0Jad0xzZCtyRUp2S0pvRWNTSmQ1ZXBxallKRU82?= =?utf-8?B?UHVoQ3lZNVVIZENtZTZRTnFVZWtjblVRMng2YWNSclJFSksvZUZvTzBabFNP?= =?utf-8?B?ODJObEJhc21xTmFjbVVrc2EzcmxOVWE3RlRHcVE5bC81RzJha2VTQ21ORzFI?= =?utf-8?B?Mm95RElpTG1wMGYyQXRtNHFtUmZ6NjFyQ2M5akdWSnVYV3FXbzZGRFdBQSt4?= =?utf-8?B?Z2cvMlFwZSthSjZNQllyb3p4SnZLZlRJWHJjdjdYdG80MkxFYjRCTUpYWCtG?= =?utf-8?B?VVYxTVl2ZFlJUitCY2JPd0Jzd2pkZnBZZ1dENkZnR2ZQVFJzeDl4ZmM4U3Fa?= =?utf-8?B?ZkUwd0Q0QVhlT0FiRUQ3ZjRGdTlBNUN1VTNGRTgxWWJQYlRmNU1QMWYvZERa?= =?utf-8?B?QmN4cjlNTEVIVDk3Snp2MTZqREcwQUJ1R2xQbFZzU0ZsM0ZGTkxZRnFvN3BI?= =?utf-8?B?UlpMRGlEVWVKa0RybjJFaTNsbnlWaVBpTnRvRU00Ri9JMCsvckdDSm0xTFBH?= =?utf-8?B?YTJ5S0doK0Q5QU5hWDlXeC9CaCtId2dxMGZTVGdoUU04djRBdUM1aFo1eitD?= =?utf-8?B?dnE3STF1QVBNVXVkd21NN1BySnA5S1NNOFRZbG01NG5hRUVKenk4VENOeUY2?= =?utf-8?B?TWwzbkdKbGh3d1pQNUZtdVZ3WVpWa2ZSVFYrd1l6Vk84MkNIZjBwNERyV2pV?= =?utf-8?B?aEVsZWVtSjN3WmdldEZsUDYzVFRSNThldkNoMmFLRkxMSFZ4amszOEczQWFX?= =?utf-8?B?L0EyNnNLcmVhdXFESklMYWVIMjd0RlE4OXF3eklQQ29DT3Z3OGZRby9hMEph?= =?utf-8?B?TnlObnVZaTdESVo1cXJqVDBYOTAza3gzTWtXMk0zSXVHeTFYMFY5UnFPMGZL?= =?utf-8?B?NHB3Rk9YTkNxN0hLZ04vbjJTK0xOSVB0c3doNUpqckZyU0FMVHlHY0gxeUov?= =?utf-8?B?azBiOUNHZ2tueDFQNnY0TXlUNkhTQ2FpaVFkRFd6VXdaOGlFQjNsQ2YxaG9M?= =?utf-8?B?TVJ1OFN4QThWUnc0R1lwVSt2cytCbVNGOFJKNUtIcW13aENJUm5hU1o3WjhT?= =?utf-8?Q?n0d89InkaA25vPKfzFPEZ9ckP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68766e09-9f5b-4889-5f31-08da5f2c105f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 08:46:48.5794 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QSiP3o0zw2hDORRlDT+zUlZexXM3YDtjvcCA7QSR2+4nabQ5+mDj8iZGioiNJQs6ifGvSGymee10rjwpRiP0nw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4296 On 06.07.2022 10:17, Julien Grall wrote: > Hi Demi, > > On 06/07/2022 09:05, Demi Marie Obenour wrote: >> On Wed, Jul 06, 2022 at 08:53:49AM +0100, Julien Grall wrote: >>> Hi Jan, >>> >>> On 06/07/2022 07:44, Jan Beulich wrote: >>>> On 06.07.2022 05:39, osstest service owner wrote: >>>>> flight 171511 xen-unstable-smoke real [real] >>>>> flight 171517 xen-unstable-smoke real-retest [real] >>>>> http://logs.test-lab.xenproject.org/osstest/logs/171511/ >>>>> http://logs.test-lab.xenproject.org/osstest/logs/171517/ >>>>> >>>>> Regressions :-( >>>>> >>>>> Tests which did not succeed and are blocking, >>>>> including tests which could not be run: >>>>> test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 >>>> >>>> Looking at what's under test, I guess ... >>>> >>>>> commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 >>>>> Author: Demi Marie Obenour >>>>> Date: Tue Jul 5 13:10:46 2022 +0200 >>>>> >>>>> EFI: preserve the System Resource Table for dom0 >>>>> The EFI System Resource Table (ESRT) is necessary for fwupd to identify >>>>> firmware updates to install. According to the UEFI specification §23.4, >>>>> the ESRT shall be stored in memory of type EfiBootServicesData. However, >>>>> memory of type EfiBootServicesData is considered general-purpose memory >>>>> by Xen, so the ESRT needs to be moved somewhere where Xen will not >>>>> overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, >>>>> which Xen will not reuse. dom0 can use the ESRT if (and only if) it is >>>>> in memory of type EfiRuntimeServicesData. >>>>> Earlier versions of this patch reserved the memory in which the ESRT was >>>>> located. This created awkward alignment problems, and required either >>>>> splitting the E820 table or wasting memory. It also would have required >>>>> a new platform op for dom0 to use to indicate if the ESRT is reserved. >>>>> By copying the ESRT into EfiRuntimeServicesData memory, the E820 table >>>>> does not need to be modified, and dom0 can just check the type of the >>>>> memory region containing the ESRT. The copy is only done if the ESRT is >>>>> not already in EfiRuntimeServicesData memory, avoiding memory leaks on >>>>> repeated kexec. >>>>> See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ >>>>> for details. >>>>> Signed-off-by: Demi Marie Obenour >>>>> Reviewed-by: Jan Beulich >>>> >>>> ... this is the most likely candidate, considering in the log all we >>>> see is: >>>> >>>> Xen 4.17-unstable (c/s Mon Jun 27 15:15:39 2022 +0200 git:61ff273322-dirty) EFI loader >>>> Jul 5 23:09:15.692859 Using configuration file 'xen.cfg' >>>> Jul 5 23:09:15.704878 vmlinuz: 0x00000083fb1ac000-0x00000083fc880a00 >>>> Jul 5 23:09:15.704931 initrd.gz: 0x00000083f94b7000-0x00000083fb1ab6e8 >>>> Jul 5 23:09:15.836836 xenpolicy: 0x00000083f94b4000-0x00000083f94b6a5f >>>> Jul 5 23:09:15.980866 Using bootargs from Xen configuration file. >>>> >>>> But I guess we'll want to wait for the bi-sector to give us a more >>>> solid indication ... >>> >>> I have tested a Xen with and without this patch this morning and can EFI. I >>> haven't looked into details yet why. >>> >>> Can we consider to revert it? >> >> I'm fine with reverting it for now, but I would like to know what the >> bug was. Does a Xen with this patch boot okay on x86? > > I haven't tried and I don't know whether we have UEFI system on x86. > >> If so, could it >> be temporarily turned off on ARM until the problem can be tracked down? > > I am not in favor of this approach. There are no reason for this to be > x86-only aside there is a bug in the code. I agree - either we keep the patch in anticipation of a soon-ish fix, or we revert it. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:50:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:50:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361974.591783 (Exim 4.92) (envelope-from ) id 1o90jz-0000N8-IX; Wed, 06 Jul 2022 08:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361974.591783; Wed, 06 Jul 2022 08:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90jz-0000N1-E4; Wed, 06 Jul 2022 08:50:35 +0000 Received: by outflank-mailman (input) for mailman id 361974; Wed, 06 Jul 2022 08:50:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90jx-0000Mu-FY for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:50:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2078.outbound.protection.outlook.com [40.107.22.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0d330fe-fd08-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 10:50:31 +0200 (CEST) Received: from DBBPR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:c0::25) by VI1PR08MB3342.eurprd08.prod.outlook.com (2603:10a6:803:3e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Wed, 6 Jul 2022 08:50:28 +0000 Received: from DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:c0:cafe::4a) by DBBPR09CA0013.outlook.office365.com (2603:10a6:10:c0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 08:50:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT029.mail.protection.outlook.com (100.127.142.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 08:50:26 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Wed, 06 Jul 2022 08:50:26 +0000 Received: from 360ba3aa83e4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C26C1083-F962-4391-88BB-55012E668FA4.1; Wed, 06 Jul 2022 08:50:21 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 360ba3aa83e4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 08:50:21 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB5954.eurprd08.prod.outlook.com (2603:10a6:20b:287::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 08:50:18 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 08:50:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0d330fe-fd08-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TzKYarNmkO80RB7iuGwuu9IpKed2ezndcKtdYJaQWMiR7MxJdV+W5Sezph1ZhlRI/ZO4/ETefQefRv904kLPvZEoKJ14jQMG32J15t+DNA4xktrTUtAp5GRCFDxPua/eAoqgKJVZZwybwendM2p9/tM2PKh2Vq7PIFlNhji4XVvCYK0oB37n8jmtCpENAXGsFb9cSvMgetH7UhE7Ct3UzW365oD2Jkun7iACpiJ6FTZS1OyCLQja01eZSKbcW3V28Wo56krPTPVBdLNuxe4vnFa3BIAvyxBuyqfp0mkVidIb3ll/dx3NDdhpAXM8lBvq9is4fSC0DDBQ33KcNKUkIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CurvSqp5cNyRqwFe+syBbBLuj4xpK6gdCm7CiBgIV6k=; b=ekQT0FJQndR2ZXmqibn0DsmKjz2+AV1Iyre21qE0x0woPjycA7cr6md560qyIFTG8jjPA918SRnJSJDnXC+aG0gt2NrCJA2hdagHiiP1i72RR+btgxu912X7CFJ7pmnLzR+iSh1iCTvZIEz84BVHCDKHZfpwsPG0fv/PAm6b/jBYb3rEeHz1MF+XUBZaqTMzGHhDIElxHWkxE3dlJOqE/t5UTiQuu67ttmGWbNyScQqKqKFyPVrfVZMKu/iU/A1p+AxIjheMy+M3Z6s9xC/53v1UUA++BksuRDjM3LlaaCmoVP07O0hfL/9I6KlDok5t4zbCze3XhZ3xsa1CSwNmTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CurvSqp5cNyRqwFe+syBbBLuj4xpK6gdCm7CiBgIV6k=; b=mJhOHWdnVSfO/sA5Zj/A2rlWS+3bSMSahe9lleDV2BPLJBTQy/Qhd+YEajiw/YWpHOr5jR4r/cEGT7gfug4jUUfQ686S83H1VcrVYmpgUgoWjmp634YspEcs8rsZQ78Bjs4bbRVTsF0JZNAJ5zn8b105AvpW4cCEii1R4afk6EM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e9b87817e698827a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cTrVSXOevZaAxRdjZomablstJ8xmoZ4esFzndXchSXwVNizMe13sLTHl5BVfdTtBRj3R4/1PPzgEX2wpmAUCJJjCxtqOfSOvBy9YK4/fFkdCf27SIFeKlM7PLapJrVkvn1oHnGrnTfrDNyrryQzqdB5PKzBQ5qcHpoDKuJFATBJyUecuE5CEWzlViwvxP+fgzesccUoSELlj+0dDMYgT6BMvI5HtIw/kjKYUnm54v8Z2wxWlW7u/N1t8sDp20E9Vyv7hzhWCQexVuZ3dlEhzP7xRxwfBdtT4Va3eWSS6m2TPn1M3chVWC7/T1lVuDKrUM1lpkW52Z6zD8cbIoDfeLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CurvSqp5cNyRqwFe+syBbBLuj4xpK6gdCm7CiBgIV6k=; b=H4kGDsAv+bWOuG64nhgxE//siosLAGezLeR8yKod5SsoCb5CrRaRAX2Kq0m7Am5o4LmnTf4VBD6v8P2nZGzCRUAnxqnLoGC3QjZosKfWXKXnCyxd92TJBBSWYZcshJQ8h9hwkU+jg6uSECQgnObQXAZHoaoYl1adCyWThleEGvATjdw/oJCOf6n+LzMAjw3RWLOYDMIHbxNcQLJ8532d6SkDyeQrIXW/HyCQvv2Nqh65cR0lgFmKDbWDP+XdnfT6/keB+tPxpsIoqKNZbpw3d0ehSq4qxu4t5CHbA5GA7F91fMjC4Nd8qTIyUsi0kO3UQ8JOhcz2WVBMhfnhytEQ+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CurvSqp5cNyRqwFe+syBbBLuj4xpK6gdCm7CiBgIV6k=; b=mJhOHWdnVSfO/sA5Zj/A2rlWS+3bSMSahe9lleDV2BPLJBTQy/Qhd+YEajiw/YWpHOr5jR4r/cEGT7gfug4jUUfQ686S83H1VcrVYmpgUgoWjmp634YspEcs8rsZQ78Bjs4bbRVTsF0JZNAJ5zn8b105AvpW4cCEii1R4afk6EM= From: Luca Fancellu To: Demi Marie Obenour CC: Julien Grall , Jan Beulich , "xen-devel@lists.xenproject.org" , osstest service owner Subject: Re: [xen-unstable-smoke test] 171511: regressions - FAIL Thread-Topic: [xen-unstable-smoke test] 171511: regressions - FAIL Thread-Index: AQHYkQ2ayCyruiBcx0aaLuSnIAU1TK1w/DyAgAAMfAA= Date: Wed, 6 Jul 2022 08:50:18 +0000 Message-ID: <6A338DA4-03A3-4755-88C5-216F06EA1DAC@arm.com> References: <14334329-baf8-5b71-5a48-421e2b6652b5@xen.org> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 22c6f06f-dad0-42ba-3c47-08da5f2c929e x-ms-traffictypediagnostic: AM9PR08MB5954:EE_|DBAEUR03FT029:EE_|VI1PR08MB3342:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QdDVbKbQBWKUF2ubOyEQXKE6GgwgqwF1sKzJxVEJktaozg0X4fFTLVPABI5sAtI5LlKvVyvW5lKdea6Vvj3IfJQ6GUhr0P8toKhPN4iXGmiDjMEPx1YDDX9fuQIQWaL7n9KzDRfoPx8TS5HI0dBJ/dmqvBVNJJExCwDjUnWdml/tFDOWLUQUQHfBB9cVmGZInheNKLw1NIG9GjwB8TnCJonzTLoQEMbX3fH0SWZjsyPYxU1+ligaDOBfBMbTyaRsqJnZLwqGOQa5I8aV8qnsDBaIU0sHV6TQYxcFuY8Z7oUPlgL+rnBfIX+B+yRQI8VJq027UkhKcJ4UCoP68u7cwN+IfVDkyahTr/9iLRCwCmSyR4BZjPBxSPZwLseHeYNpYIvZXTj/TVhf7VkW4YnE4L7TPsJlK3+uO+3MooeM5r3j44CcZYQba7iIxZWEj64W/xA5SRgFsEb6olXo324rfLnG6cKyQGuBgOCOj1t41snecBbjN7SkysF2+n5expHTMJHIBlVHACLhtRVL4+T425O0QFCDH0XVidYNoN93YAh+ZANcnIqDcUBP13XwXdCgaEPLM8PpLk+rhPB93hFQJSzRHrfIq+Cj2fqBGONFRU3t2bz8JXQqyzdKAHwrl9VjVK48PdygSflO04nJIzYqQsD8n5s1PME/5/qC3CBLUyICr+NplnnmqAEjk/F+npcK3FDoEdi8Kvgs0LAmqRecO241EqSYaZQLq/3G7d1ng6efJ4HN8HkIlhHB8V4CKCU0z6cjPxjS6rXU30sCqcoKvl4uSzyQjBwKAcvYwVdzfQaejEjpurjTxnPxJLfjhcGFhH9x594VvtyDvgW53ETxAkEWHjIaMGoybne5iYd/75d9lQRnY59PbfOWltCh85Ca X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(366004)(39860400002)(136003)(346002)(8936002)(478600001)(86362001)(5660300002)(6486002)(83380400001)(966005)(2616005)(36756003)(186003)(316002)(54906003)(6916009)(38070700005)(26005)(6506007)(38100700002)(6512007)(122000001)(41300700001)(91956017)(2906002)(53546011)(66946007)(76116006)(4326008)(8676002)(64756008)(66556008)(66476007)(66446008)(71200400001)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB5954 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c70686b1-acb6-468c-d9f7-08da5f2c8d69 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mVWd64yKhZuRp8n1pSjEwWWHYZRqSbetKplqI0AJoNmn3uBOKEc5QyBEMHr/H2noY4OFeZcd6OrONn3w4rCxMhmx0iukIbPZxg4wC6oBAhJNCtxWLi3WjcmbK9b/f0Qg17iBOe4c/KWesimSNQ0xavyRcPPA1H4n1nEJ0rcTlWfc6kuKpbZc73+hsVic9BphqYXym0Ez05Xfics9P78/AS6a1LqETyRxzjuhIowLxEWsdyLMybwwWMoWJq8HDxcbC+17gABu0AVrVjIcb7XLLDc3aq/KvGppchGpq0Fu5D6EGYEXd4wNfiawnCc4egpJRZQU1dAaCcK7kD36GTeZvQPFzc6oGzkbWk7BjB7HMjJVd9OYfColpqbQDeTKPyeEbkzlbhx1RrXsG6csK9FZTFgu2dcF/WxbHLrqLSxOiqfQA2O4ObC0svz3yt63b3kt19meq0jAofr8Ti/sG2sRH2gKX56SrrHnF3XHFib4V9/sFnIHTGyszzBNPYiDn3JlLTTRKMjMm4VV1kPLP62ineTDWU+OK2JOI9q8OGdMvcILgypeXF9XgzaHCxpZXqZ3vrxEmBI8yH5dEsMWPnVk1hXce3KPJiZ1kScNnL5a2Dn1XqO3rPgpvsKuoBNxoYAp0E32X7cYskUE4/kiREZNO5SdoEmD0Y7BDekLg80RoV+QWfCnhTc9sajWlepXaxVaUWke/lWdLFdZdmzsTB8Qt/SbCLC2VK8PPctSTLoLTiVxMwIVumXNB2abnM0S0++Gm0ofGhGBsmLecFDJdVLO9OgzbEHjAEOVeOxNJfot4jrP8Hweuo8gQeh3l/zYRaH7Mc2/7haWz7Ffw+AsOncvUw7gfu0Dn3M6MWypUYN5IEA= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(36860700001)(6486002)(966005)(6862004)(478600001)(8936002)(6506007)(40460700003)(53546011)(33656002)(2906002)(26005)(6512007)(5660300002)(81166007)(82740400003)(41300700001)(356005)(86362001)(82310400005)(336012)(47076005)(4326008)(8676002)(186003)(2616005)(36756003)(40480700001)(70586007)(83380400001)(54906003)(70206006)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 08:50:26.9389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22c6f06f-dad0-42ba-3c47-08da5f2c929e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT029.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3342 DQoNCj4gT24gNiBKdWwgMjAyMiwgYXQgMDk6MDUsIERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBp bnZpc2libGV0aGluZ3NsYWIuY29tPiB3cm90ZToNCj4gDQo+IE9uIFdlZCwgSnVsIDA2LCAyMDIy IGF0IDA4OjUzOjQ5QU0gKzAxMDAsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4+IEhpIEphbiwNCj4+ IA0KPj4gT24gMDYvMDcvMjAyMiAwNzo0NCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gT24gMDYu MDcuMjAyMiAwNTozOSwgb3NzdGVzdCBzZXJ2aWNlIG93bmVyIHdyb3RlOg0KPj4+PiBmbGlnaHQg MTcxNTExIHhlbi11bnN0YWJsZS1zbW9rZSByZWFsIFtyZWFsXQ0KPj4+PiBmbGlnaHQgMTcxNTE3 IHhlbi11bnN0YWJsZS1zbW9rZSByZWFsLXJldGVzdCBbcmVhbF0NCj4+Pj4gaHR0cDovL2xvZ3Mu dGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3MTUxMS8NCj4+Pj4gaHR0cDov L2xvZ3MudGVzdC1sYWIueGVucHJvamVjdC5vcmcvb3NzdGVzdC9sb2dzLzE3MTUxNy8NCj4+Pj4g DQo+Pj4+IFJlZ3Jlc3Npb25zIDotKA0KPj4+PiANCj4+Pj4gVGVzdHMgd2hpY2ggZGlkIG5vdCBz dWNjZWVkIGFuZCBhcmUgYmxvY2tpbmcsDQo+Pj4+IGluY2x1ZGluZyB0ZXN0cyB3aGljaCBjb3Vs ZCBub3QgYmUgcnVuOg0KPj4+PiB0ZXN0LWFybTY0LWFybTY0LXhsLXhzbSA4IHhlbi1ib290IGZh aWwgUkVHUi4gdnMuIDE3MTQ4Ng0KPj4+IA0KPj4+IExvb2tpbmcgYXQgd2hhdCdzIHVuZGVyIHRl c3QsIEkgZ3Vlc3MgLi4uDQo+Pj4gDQo+Pj4+IGNvbW1pdCA4ZDQxMGFjMmMxNzhlMWRkMTAwMWNh ZGRkYmU5Y2E3NWE5NzM4Yzk1DQo+Pj4+IEF1dGhvcjogRGVtaSBNYXJpZSBPYmVub3VyIDxkZW1p QGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+Pj4+IERhdGU6IFR1ZSBKdWwgNSAxMzoxMDo0NiAy MDIyICswMjAwDQo+Pj4+IA0KPj4+PiBFRkk6IHByZXNlcnZlIHRoZSBTeXN0ZW0gUmVzb3VyY2Ug VGFibGUgZm9yIGRvbTANCj4+Pj4gVGhlIEVGSSBTeXN0ZW0gUmVzb3VyY2UgVGFibGUgKEVTUlQp IGlzIG5lY2Vzc2FyeSBmb3IgZnd1cGQgdG8gaWRlbnRpZnkNCj4+Pj4gZmlybXdhcmUgdXBkYXRl cyB0byBpbnN0YWxsLiBBY2NvcmRpbmcgdG8gdGhlIFVFRkkgc3BlY2lmaWNhdGlvbiDCpzIzLjQs DQo+Pj4+IHRoZSBFU1JUIHNoYWxsIGJlIHN0b3JlZCBpbiBtZW1vcnkgb2YgdHlwZSBFZmlCb290 U2VydmljZXNEYXRhLiBIb3dldmVyLA0KPj4+PiBtZW1vcnkgb2YgdHlwZSBFZmlCb290U2Vydmlj ZXNEYXRhIGlzIGNvbnNpZGVyZWQgZ2VuZXJhbC1wdXJwb3NlIG1lbW9yeQ0KPj4+PiBieSBYZW4s IHNvIHRoZSBFU1JUIG5lZWRzIHRvIGJlIG1vdmVkIHNvbWV3aGVyZSB3aGVyZSBYZW4gd2lsbCBu b3QNCj4+Pj4gb3ZlcndyaXRlIGl0LiBDb3B5IHRoZSBFU1JUIHRvIG1lbW9yeSBvZiB0eXBlIEVm aVJ1bnRpbWVTZXJ2aWNlc0RhdGEsDQo+Pj4+IHdoaWNoIFhlbiB3aWxsIG5vdCByZXVzZS4gZG9t MCBjYW4gdXNlIHRoZSBFU1JUIGlmIChhbmQgb25seSBpZikgaXQgaXMNCj4+Pj4gaW4gbWVtb3J5 IG9mIHR5cGUgRWZpUnVudGltZVNlcnZpY2VzRGF0YS4NCj4+Pj4gRWFybGllciB2ZXJzaW9ucyBv ZiB0aGlzIHBhdGNoIHJlc2VydmVkIHRoZSBtZW1vcnkgaW4gd2hpY2ggdGhlIEVTUlQgd2FzDQo+ Pj4+IGxvY2F0ZWQuIFRoaXMgY3JlYXRlZCBhd2t3YXJkIGFsaWdubWVudCBwcm9ibGVtcywgYW5k IHJlcXVpcmVkIGVpdGhlcg0KPj4+PiBzcGxpdHRpbmcgdGhlIEU4MjAgdGFibGUgb3Igd2FzdGlu ZyBtZW1vcnkuIEl0IGFsc28gd291bGQgaGF2ZSByZXF1aXJlZA0KPj4+PiBhIG5ldyBwbGF0Zm9y bSBvcCBmb3IgZG9tMCB0byB1c2UgdG8gaW5kaWNhdGUgaWYgdGhlIEVTUlQgaXMgcmVzZXJ2ZWQu DQo+Pj4+IEJ5IGNvcHlpbmcgdGhlIEVTUlQgaW50byBFZmlSdW50aW1lU2VydmljZXNEYXRhIG1l bW9yeSwgdGhlIEU4MjAgdGFibGUNCj4+Pj4gZG9lcyBub3QgbmVlZCB0byBiZSBtb2RpZmllZCwg YW5kIGRvbTAgY2FuIGp1c3QgY2hlY2sgdGhlIHR5cGUgb2YgdGhlDQo+Pj4+IG1lbW9yeSByZWdp b24gY29udGFpbmluZyB0aGUgRVNSVC4gVGhlIGNvcHkgaXMgb25seSBkb25lIGlmIHRoZSBFU1JU IGlzDQo+Pj4+IG5vdCBhbHJlYWR5IGluIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGEgbWVtb3J5LCBh dm9pZGluZyBtZW1vcnkgbGVha3Mgb24NCj4+Pj4gcmVwZWF0ZWQga2V4ZWMuDQo+Pj4+IFNlZSBo dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMDA4MTgxODQwMTguR04xNjc5QG1h aWwtaXRsL1QvDQo+Pj4+IGZvciBkZXRhaWxzLg0KPj4+PiBTaWduZWQtb2ZmLWJ5OiBEZW1pIE1h cmllIE9iZW5vdXIgPGRlbWlAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4+Pj4gUmV2aWV3ZWQt Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4+PiANCj4+PiAuLi4gdGhpcyBp cyB0aGUgbW9zdCBsaWtlbHkgY2FuZGlkYXRlLCBjb25zaWRlcmluZyBpbiB0aGUgbG9nIGFsbCB3 ZQ0KPj4+IHNlZSBpczoNCj4+PiANCj4+PiBYZW4gNC4xNy11bnN0YWJsZSAoYy9zIE1vbiBKdW4g MjcgMTU6MTU6MzkgMjAyMiArMDIwMCBnaXQ6NjFmZjI3MzMyMi1kaXJ0eSkgRUZJIGxvYWRlcg0K Pj4+IEp1bCA1IDIzOjA5OjE1LjY5Mjg1OSBVc2luZyBjb25maWd1cmF0aW9uIGZpbGUgJ3hlbi5j ZmcnDQo+Pj4gSnVsIDUgMjM6MDk6MTUuNzA0ODc4IHZtbGludXo6IDB4MDAwMDAwODNmYjFhYzAw MC0weDAwMDAwMDgzZmM4ODBhMDANCj4+PiBKdWwgNSAyMzowOToxNS43MDQ5MzEgaW5pdHJkLmd6 OiAweDAwMDAwMDgzZjk0YjcwMDAtMHgwMDAwMDA4M2ZiMWFiNmU4DQo+Pj4gSnVsIDUgMjM6MDk6 MTUuODM2ODM2IHhlbnBvbGljeTogMHgwMDAwMDA4M2Y5NGI0MDAwLTB4MDAwMDAwODNmOTRiNmE1 Zg0KPj4+IEp1bCA1IDIzOjA5OjE1Ljk4MDg2NiBVc2luZyBib290YXJncyBmcm9tIFhlbiBjb25m aWd1cmF0aW9uIGZpbGUuDQo+Pj4gDQo+Pj4gQnV0IEkgZ3Vlc3Mgd2UnbGwgd2FudCB0byB3YWl0 IGZvciB0aGUgYmktc2VjdG9yIHRvIGdpdmUgdXMgYSBtb3JlDQo+Pj4gc29saWQgaW5kaWNhdGlv biAuLi4NCj4+IA0KPj4gSSBoYXZlIHRlc3RlZCBhIFhlbiB3aXRoIGFuZCB3aXRob3V0IHRoaXMg cGF0Y2ggdGhpcyBtb3JuaW5nIGFuZCBjYW4gRUZJLiBJDQo+PiBoYXZlbid0IGxvb2tlZCBpbnRv IGRldGFpbHMgeWV0IHdoeS4NCj4+IA0KPj4gQ2FuIHdlIGNvbnNpZGVyIHRvIHJldmVydCBpdD8N Cj4gDQo+IEknbSBmaW5lIHdpdGggcmV2ZXJ0aW5nIGl0IGZvciBub3csIGJ1dCBJIHdvdWxkIGxp a2UgdG8ga25vdyB3aGF0IHRoZQ0KPiBidWcgd2FzLiBEb2VzIGEgWGVuIHdpdGggdGhpcyBwYXRj aCBib290IG9rYXkgb24geDg2PyBJZiBzbywgY291bGQgaXQNCj4gYmUgdGVtcG9yYXJpbHkgdHVy bmVkIG9mZiBvbiBBUk0gdW50aWwgdGhlIHByb2JsZW0gY2FuIGJlIHRyYWNrZWQgZG93bj8NCg0K SSBjYW4gdGVzdCBpdCB3aXRoIGFuIGFybTY0IG1hY2hpbmUsIEkgd2lsbCB0cnkgaXQgbm93LCB3 aWxsIGxldCB5b3Uga25vdy4NCg0KQ2hlZXJzLA0KTHVjYQ0KDQo+IC0tIA0KPiBTaW5jZXJlbHks DQo+IERlbWkgTWFyaWUgT2Jlbm91ciAoc2hlL2hlci9oZXJzKQ0KPiBJbnZpc2libGUgVGhpbmdz IExhYg0KDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:51:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:51:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361976.591793 (Exim 4.92) (envelope-from ) id 1o90kY-0000qc-RW; Wed, 06 Jul 2022 08:51:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361976.591793; Wed, 06 Jul 2022 08:51:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90kY-0000qV-Og; Wed, 06 Jul 2022 08:51:10 +0000 Received: by outflank-mailman (input) for mailman id 361976; Wed, 06 Jul 2022 08:51:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90kX-0000q1-0d for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:51:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80084.outbound.protection.outlook.com [40.107.8.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6a92ba6-fd08-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 10:51:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5122.eurprd04.prod.outlook.com (2603:10a6:208:ca::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 08:51:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 08:51:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6a92ba6-fd08-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nKN2V9Fj1i0v+FdyUBYJjssb5+QtUNhSnQR2pg2iXoLhVPJKl1DO69hctwBQkvVsDcGuG82wbcsIGV4Y3464ogQ1s4+4W06Cf840kAMvj/DB0DBDjkDiqgCgtYGn7a4NvBbZbJh9CepBFH399ktpP6pI8oZ0jTDVg4R2SO0+qnqkqJrGTg18TLoOvhmfCN1A99Y9Cz77lF+RSJQmf7vJy6qGvSfeDnnwzBKX4jxGlQnoek5yop5Oci0Ppe077Y4Z386gQKrp9g7Qc1Komwe8KpQws9zo+oYgn23LaKE/m/KC/+6G4CH0ay8bAMTQHUgSjTK54YeTJrRj4Ihg8Pjs2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YBNIL9BNcEakpDmLE8uqtNtzwj2UVAA+huGQiA/BClU=; b=TJynHGrSYLb/ILdmtXMKGIwy/k/99taHQTBaMZ/DYFP4rvJqTLkX9ZTlCc7m1spQaKf/vKT86PYdYbRg0/jjNx2lrSV59HpLbYs0wYmv7+Vu+0vVnN0beayWTAuDzV4ysvIY5ixImyDYduuOqckiJXTY20w0OIELe4EvoEmaRTSoAlngtpXJwbjFHS713zEouT7LlErmZ1A3x/8JzZYKTjU/e9DG+w48dPFM4w8Hdn+XTeBf/l1GbmxK0FKPKrIGxr+1DiXzO/knkq7JgcWwgLvB7Ciau5JxzktABK2LKFa0basyFIMqL44bhXPCassg/iK7LTs8oGTsW8ROxCaGhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YBNIL9BNcEakpDmLE8uqtNtzwj2UVAA+huGQiA/BClU=; b=R9Co/LIgF5/D9+DSJqg0tYevCEgPhy3iUZgquMUTgtYvclu52UQ6MoR0Cf4f1LbnmkjL7IhFmVfV6DxYq8NQwcWrMndthjf/Cb4rDe3S4cKpCHJmoOJ8ehSF7OJfJux0LnYLCdR64ixeJ1fF8wManL88gWkyigx94TYapyEPGtnHCapX0XGQdq5kpiXNCgo/PVoAFNENJeRQYuc53JOW7H1/4MhcnwTENhs0IY/iIiLJBFPMCHfOXk7uxvI779fu9IZ5SZ+x4yj5trzaTn6badQODAmV+wqEZVWLIh78NP3KPOxjFOQPItd3MgBjASwdjZfhz7imtocX5VbXBj+OwA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> Date: Wed, 6 Jul 2022 10:51:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> From: Jan Beulich In-Reply-To: <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6f9c7b0-1203-4e71-86be-08da5f2ca9a8 X-MS-TrafficTypeDiagnostic: AM0PR04MB5122:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: emNNibo718o5Ds8zV1o4WfsjBZb2rVR2bZr8JfM/gPn10odsnVByp0anYjE9BhrkYL/wabthwhTCY36jxBW4mHgmogtyO3oK0fkhuOxk41PA/gRyduacm2c+rRI+V5LGptiBmnm5pbzxA+jXmjgjL8cz8UmxC7xdqiQ1JhZk7ZzVsU00xzLgIizQrSBwgtnm6Emkm/3Mr3wqZftXCluCFu0ZUHzwzk7J4kH8IVujWJkxOHsgzpcGwAPHao21+lTlOZKKtq+epwRRq72bT3IwxCLe0yasLO/oCH/KvSBYmwsn3hvi8q95RnEaKVPokSvcDZeNLG7MgBHJ4jI7SH9SSsOgjHR2WmNQaXWQD4i37Crf6Ex2yF3KbswWrC+fmx7TCO4yP3SegDk2IWeFJMEjrmouIvpqIUBrHKLIEzqdVcM+TGv4NzFtV9ze8JLYXWOQcCanS+o+6s1q9XBgLuzXiUutCAc0/rA1jc8ZWsFf3xL6eSZ0dmaoEIWNcVQTcdTww8SzWbN65dssACu/MFx/4Wcqe90guFGsl5+Di4DnZtDUuGTlKRqBacHr9HoRWV1fAIKi27pXRPBNZNnl5PUnbLbjwjxnyuVFvtgDa2ou99j+aWXEK/glnbmNskdGwJGrYwq1LD3CdOs1OXaZ0ZFxd5d0Y1BS1s/l1jkEfiJeyZiPlcESl7jRTJcGLhkGyL11A7REbfTpjjExbV41YZeQDEOarpN3UBxfqsCrH0R0HNXP3hVsd5bbLE7TVuz9nfA4hZ1Vjp9NP6O+9f/tY/8RGV6QZ6PvicadxY0Ao1bqPvsXBJ1d9n6eAYcK2phVRwEhGaZ2IChz9yElm6nw1ukd1z7MUWssjOWnTrqiMf3z91U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(39860400002)(376002)(136003)(396003)(5660300002)(8936002)(2906002)(4326008)(83380400001)(8676002)(36756003)(86362001)(38100700002)(31696002)(6486002)(478600001)(6916009)(54906003)(66556008)(186003)(2616005)(66946007)(316002)(26005)(41300700001)(6512007)(53546011)(66476007)(6506007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGgyTk1BTFBjTURGdGpZNktrYVBIWGxvb3VhWkxJdWo4aEFhRUl0K3RqSjA2?= =?utf-8?B?MTBSaURxbXJqUDRZWWpVaXNXNUV4eklObnFlYks0dVZ4L1FVWm5EanAxdWdq?= =?utf-8?B?UEVRSHVWN3F3V3c3UzhSU2craDZ5SWkwSzZ0bnFnVlRsMzdZY2pXK0RpRmRM?= =?utf-8?B?VWY3MnlpVWFwOWNQWXBWWmNWaDdCWVJZRFZjUUY2REdUOWkvQVhQWEtqODd2?= =?utf-8?B?QUJ1cU02VDErcFE4eW9BT3JLcE1laHlxb1VjN0h6TXRTbFc2UVAyM1RSVkZS?= =?utf-8?B?OFdxTnMxQ1ZzUGVvMmR1TnpJTVJWaWZiNXZ2aTkzR0pMUktiYmo5d1FaMkpX?= =?utf-8?B?Q3FUeCt3ckF3N295Z0xQOXE0U3NCKzRwZ3BESEhJcWE0TTUwQjJ3eHp1K0lo?= =?utf-8?B?Rmd4MVYzMHBBNFYyOVVMRGVwZ0tTOHJrZytRRTJNb3VxZSs4b1krTitneHlL?= =?utf-8?B?TEhTMTdqZ1pHTzNGK1JUUElYbDI3N1oybnF4Zy9tYkhQVEk5eVhjdmkxU3Bw?= =?utf-8?B?cjBtS1lBSVFrem5MMlBBbGtFcm5VbWcwL3UxU21LaGdETy9ZUWFkL2VNaGVp?= =?utf-8?B?U0R5bmFIQkM1b2FJQ2JqTkVwMWN1R2RDYzdsc3o4aGpQU3pXUU9qYkFVRi80?= =?utf-8?B?WHhuS1ViRUIzT1NVb0lTUFlqcVlxaHU5V2VqKzZNRU8veEowV2o2MGxSQzJW?= =?utf-8?B?UXRQOU1IQmh0Zk5XUGszWVh1SnZuYS8wM3FjOFg1NjFqWWZqUjdXK0JZd1k2?= =?utf-8?B?NEtJTU9IU000SkVYVkMwN2pvcGsyZmtlTytFcEVCNEVPWmRlSlg3SGJoVngr?= =?utf-8?B?ZHRFdTV4OUcxTktFdG1Oc0NuaFNsajJSVzNHRlV6eEdla1BtZjZMSlVOS1Bj?= =?utf-8?B?R29IT1BXL2RmNWYrdW1LMVR2QU93anNDbHNkZ1REVDk3THlsNkZDMkZNRnZT?= =?utf-8?B?eDhXWkdqelZyRTViWlNsc2d6bGpNc2tkbU9zU2x0MnhtSHZYamhPQ2I1SnZX?= =?utf-8?B?cGtRUENoSDd5UFFQanROKzhsdlF1bzhvN0poWkJ2aVc0a1RyRXJyRE9iT0Qx?= =?utf-8?B?TzEwK2N2V0I2Snl0UHlVY1lpa2UrQmtrbHBiem9YdUFrQ21LUFJUVmQ5S1VS?= =?utf-8?B?UlE4QU5rSDYrMVJFUTRmOFByRDFQSGhrM2NuMVNIYk1OUVcrMzEwYlA5Zzht?= =?utf-8?B?UXdqNXRCNHdFMWpFYWhzV3NGTXFnOUVaMnF2UmRpbHZnc2Y2b1NIMVZtSXVU?= =?utf-8?B?dTNsS2lYeXh3NVdPbHFMTnpIOVNpS09SS3Z0bGpjRTI2Wk55WndEZlhBczlQ?= =?utf-8?B?a1pDbW1SMGo3aXJ3Y0F2N2tFdnhzZEx3YWZiRnlNWGNPOFk3QThSeGZqTnZi?= =?utf-8?B?eHRsV2l5TTU0K1FKak4va290M0VyRFNWMGFjSXIzcmxJQWF0dlgzS2pXYTkr?= =?utf-8?B?bkFuaWVFNTJ1RVY1WE1SV3Q2bWxkWjg3TlhlcURURkJWdit5a0syUnBjQnIz?= =?utf-8?B?LzFOL3F5THlRZkRFSjFFc0FYcVhQSXE5MVB3OWpxUDRuS3R3WUlLa3M1V3li?= =?utf-8?B?czFib01wNmk0UDRPTUZZeEdtcFJBMHE1eWNmQ25JbDJTUDRlaWhRWng1elZN?= =?utf-8?B?YVZaN0RXYkJhanVNY290NGRVUjI2M1ZaR09uaDR3U3NsZUlIcUhhZmFSUWZT?= =?utf-8?B?YWMyYTN2OGN6VDZxSDRwNjhlQ1BQYTU4anNRcVI0c3dqZ3o0ZlFDUlVpTGdv?= =?utf-8?B?bHI1QW9Ya0ZWMVZjNlZzM0lGaWdweXpUUkJSQzJjbjJsTmE1Tlp6cFZLSmZU?= =?utf-8?B?MzJmS0hGQVlOSWgwTjNjQXBGNkp5NkxwMFBCWDd4cmlWTm1JMldGK2NiY3ZQ?= =?utf-8?B?T0g0eUNubGVScnZlQjhzcmpKd216ZUVubG52SzZnQ1pQRlE1T0xuWUJRVzN4?= =?utf-8?B?TWx1RUwzbTQ5UXVwUHM4YW1YakdaUWwvVm5hK0h0cUJRb21KdU5iWjY2dkl0?= =?utf-8?B?VVV2NE5qc0hEVk9Ea25zNjNkQmxNQXJhbE4ra1E5OTdmM2lUaDRvdEpmazky?= =?utf-8?B?bHhMbXR4d1E3ZnpQaGVjaTRQR1B6ekN1Znh1RVdQVVFIbVRxdjZIOHB1RVpP?= =?utf-8?Q?SRglvwB5i9IKgFfT3uOuH8sWN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6f9c7b0-1203-4e71-86be-08da5f2ca9a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 08:51:05.7190 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MvhRyuyAaaWsZvMgPQXBsqEJO9PLj42sOZ6Pqsf+LZ2VUxNsV0ALqCLyrA20tEbC5VUe2L7idLKTo2JxqlVv8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5122 On 06.07.2022 10:43, Xenia Ragiadakou wrote: > On 7/6/22 10:10, Jan Beulich wrote: >> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>> The function idle_loop() is referenced only in domain.c. >>> Change its linkage from external to internal by adding the storage-class >>> specifier static to its definitions. >>> >>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>> attribute to suppress unused-function compiler warning. >> >> While I see that Julien has already acked the patch, I'd like to point >> out that using __used here is somewhat bogus. Imo the better approach >> is to properly make visible to the compiler that the symbol is used by >> the asm(), by adding a fake(?) input. > > I 'm afraid I do not understand what do you mean by "adding a fake(?) > input". Can you please elaborate a little on your suggestion? Once the asm() in question takes the function as an input, the compiler will know that the function has a user (unless, of course, it finds a way to elide the asm() itself). The "fake(?)" was because I'm not deeply enough into Arm inline assembly to know whether the input could then also be used as an instruction operand (which imo would be preferable) - if it can't (e.g. because there's no suitable constraint or operand modifier), it still can be an input just to inform the compiler. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 08:58:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 08:58:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361989.591808 (Exim 4.92) (envelope-from ) id 1o90rE-0001jj-LG; Wed, 06 Jul 2022 08:58:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361989.591808; Wed, 06 Jul 2022 08:58:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90rE-0001jc-Hk; Wed, 06 Jul 2022 08:58:04 +0000 Received: by outflank-mailman (input) for mailman id 361989; Wed, 06 Jul 2022 08:58:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90rD-0001jW-Qu for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 08:58:03 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60073.outbound.protection.outlook.com [40.107.6.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bde490e1-fd09-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 10:58:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3474.eurprd04.prod.outlook.com (2603:10a6:208:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 08:57:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 08:57:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bde490e1-fd09-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=et+5U5Kwtft6tpbcu+eq2lLGrfiDpO5YOy2tMEoE2kfQO452c+Io7JGHSbzS8x5Ll3jemOMcNQCscEkU6R7qzfNyA9aoKQ3uOqzNS10WwFrfx5zoW0NpXamezz2wRMABO5qsj2Pg3mI5CJB4HnoY5+Fmau2htBeExFfOxSbIzv65PImXxYycy3nB6tDsrac0MMC5Og/XlejiqzlqcxrSoxtseuRxO+UIrlHMMlayHTrksM+Mkeeg+YvI57fuM4QhglN5w8H7Djh1qEhaZ/kcIvJd14E/RnW5R+yNmiof8WUfZv7r1rerelTCdkBzQRDcPba7Zfp/LB5VKtFxW2Yd9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zc5aGFUSIi/PDU6V2AkIewtQkMKYDfqx5xJxUHFfjnM=; b=I/bE7Ez2o3OCuWw/5PiFJ6P3QcQyDv7L6eaL3a+5c6lKcicv7BkHlnI1yJDxa5ltlR6jZk2IoZ38zYdfyGv4rdZOR/8aPRd6Csr5B2LYsf+opMcDfz0tqNHLyFimYUr9qlt1Hu3/QEilqwgX1Bc3cR4qqvUosw1++ap/mbkqRBjX/5y9nhFlAmWYJjV73i+X5QoM3ZWrk3MbIAOTx1g/o+OcgscieXYC0kZJOF2v8WiobNFTCrs9N2Lu63+cPEuiHbX0ZvA/nmtbNyt9F7Gb5UtYS18HX865btQaRZEXkFmjy1xM2sXSj7gAhAhgtqce+2DIWjhZYFsZp9uQwEWnog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zc5aGFUSIi/PDU6V2AkIewtQkMKYDfqx5xJxUHFfjnM=; b=fV+b9cK/VuTwGQ948Ie7sWlIsKfwsEJLlyZLK5skBceMqGbxL/qexjOQeML/+vEyHskkHzzNys3Fz/XQLgMO8sOyq3HGj747pEC1nLeQsw3yB6gv7RRCTEYbgeRcm/QjeB+w4Z7PzuFxe6qaPWliIJfOjIuIZGBNY5V+Q4lKTAj8+EKg0cd7ZO/2tch3vaNL8YtVzpX7zpoc6TtIcJGkb1DlfkdILFqTlhY7rYJ+VGeFAD+qDleJuD4IHpyw/rtLg4OpFE0IhAlmR/IUnQ1dTEnjTSPIH3tWjIfS5YYo65V4Yg/SwyXqVFRYuMBRsPT9gD0MTKAnWGnv2jhuh8wb4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 10:57:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 0/9] xen: drop hypercall function tables Content-Language: en-US To: Henry Wang Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Juergen Gross , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" , "xen-devel@lists.xenproject.org" , "christopher.w.clark@gmail.com" , Andrew Cooper References: <20220324140139.5899-1-jgross@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P193CA0114.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1dc78095-24c0-45f8-20ea-08da5f2da050 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3474:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pTv8DcyzfFAzUHIzgGLUatDseiueNAj2LGfKLYGBW3lTGqkEUF2hlpSmUNTKDVfdfoPhjZi73J0EqBOrZPd2U4uZ/MYIX7r4DKwoEDUDEQ5B6Wcee8/FYUSMbSZEC89/LuJ4D3Tie46s9yPZOB3kq18hnDEIpqATl7PGvohdPKIDial9f9icEYaBzPqAxwWECVnITNFYhrDVhQLaeahN62ou4WcTniBFwRhBR035smbtkgnGIRtObiAWP8qGo49B+/ggwIEPMPq3LvHc6vr+N/K/QXUYaglyAgyxUVYS5gBh7EphDh3nn2i9IDen9sgv8L0sMW9sRyxKD01phFcut1nqRK3gInX5T0IPG514TRGgFDPPncCojwqkGnleFZ//4LPYFsg5O2hJQEmiOJgkamICQrEHw32yxlTTHIf+Ld4Hq9zQijFxNFpF+IjO8I4j/7q5IyJCBNFaJmlQZFQ3uwL+9RuV+vxabSiNF4wci+hTl47W8qCBy96wUHBzWZ9pqNPiCZkmfCQw0ef77Ii7nN1HTNEajMWZtk5e5Zja88IykAdJLrqHOEUdrh5VPgR4tZB7GN1iYOcOhocO4q4rfqZnCNTfNavAlN6kzNXCrdKKKJZLiISJXHRK6YTyMb5+uJOztLQQf8HboCcfOsg8PqPIeuJuO7XHgpGMnpCIWepRhQDyl+T+vhhNV8EedO0WcYQPD6CrFBY7fvEubWe3RvyJoNxJbDn9O0ny9AMzrbarpRUYDgim2SHDQ5JxBv44VQfvz/Dp8gISX7+vbmzjkrxmSWblGpatSx0tSklwBE6LqS6cQG/BbtLc8s4HtBopgXk6KfpDhbnibyZJ/o17mK8ghG3AyqkEI4S/XckjJoA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(7416002)(26005)(6506007)(83380400001)(41300700001)(2906002)(54906003)(66574015)(53546011)(316002)(36756003)(31686004)(38100700002)(6486002)(8936002)(31696002)(6862004)(5660300002)(86362001)(2616005)(4744005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUpyMTFkT1pONlRrSEtmZzdRUE5WVjBpaTNLNnBFQk5yTTd6VENwK3FYcEQ2?= =?utf-8?B?dVRucTJzZ2IyTXQwNTAyVmZaUUh6NWthS0dmMmtFMkVIZk9DTzBXUVhSM3JB?= =?utf-8?B?dFpPZDRsUXlUWHZYVFZ3NlVrdFlCTGw5WFFWOTBHaE9XTDRacXh4QTRuZGxS?= =?utf-8?B?N0xNa0NpRjRVZHVUMnFiV243UTR4ZTZxbFlWVzdBTURmWitTSW5HNGx3WnVm?= =?utf-8?B?VXIyZFpUVzRNRnIxTUJMRDU5dCtZUllqSW9PTjlONzJKc2hEakVXbndzcFJJ?= =?utf-8?B?UEtudVJMWHhPeEhOcXFod1pZTU0yRmJ1L0hwRS9lL0NyRTVzU2hsMWRodENG?= =?utf-8?B?UXFSUkFieElXWjBjZUs5bzAvcFFLZ09SOVBubXV4bHZUbi93ZHZKblVLanhi?= =?utf-8?B?dmlxeE53anl5ajZhZnVhWGpmWERsem01SjJZN2NwelA5RVF4NEpPR0hIeVIw?= =?utf-8?B?UmUzZW1EWW1QZE5vUWxkWEpXZnNDb1dScFg5UHU0TGJzQmYxT1dqQnZ5TTlw?= =?utf-8?B?VW5oaXNnSlYwOVNBSFhiU2VERDJqb0FrQ0R5YkV1blFoZldmdWlvVnkxT1Yr?= =?utf-8?B?T1FjU3NyQ0F3NENVRFpseGVNY2FLN0w1OU4xeDdzU3B0cTAzaU5OZzVTRk5V?= =?utf-8?B?Z2w2cHFZTXFremIvYktJMlR6TzhhQ21SM1BKZkYxQXJ0bGxPN0t1clErcjk0?= =?utf-8?B?bU9LdmZvVmtxK1liODNXZ1B6bHp1M3FGUk4zOWtHU1ZETHRXZEJTWUdsOU5X?= =?utf-8?B?b1hlRlJYQ1Zpekd2ejlwTUxxbTlwYWJEN0RkdWZ4OGlCRDRBSUNIcDN3WklQ?= =?utf-8?B?cXVsQ0UyNkFCWlZ3ZnVRc01FLzRNWWlaQXBUUng4NGd5WHd2VUY0S1V0blY3?= =?utf-8?B?SE9GajNnRGlSL1hOVnhveDZ2SzdvckIzL1c1QWJjN08vLzJuVW1SbXpqOUNs?= =?utf-8?B?bU1ISVN0SmJhVjVxZHJYa095YlpDYS9UNFh4QUw2OEZWWnZGQXJ6bXVPakw4?= =?utf-8?B?NE1oMERTQzhNU2o2UzR4eUhZY01kRE1sZU4rQ3U5VGpIMmF5cHBEY1NmcG9k?= =?utf-8?B?V2IwQXhxbzhMNEI0ZVRGUmQ1NkczWjNjcVlmK0RnTHRqSXp0Q1pmYzJjdHpR?= =?utf-8?B?a01pTnpYR253MC83UFZiYjFUemdKN2tFeVNNNXBUOU16WWs3RXpJd0NRMHlK?= =?utf-8?B?cmcwb0lZaXAwR0lDeEFvWmZkZ1I5bFlsNUNlNU1Dc0VhOXVFY1NYTUk3Wks3?= =?utf-8?B?WnRVMkFKQk1VTTg1eG9ET2lINi96VHhVQW9Pbi9HbTUvNVJOK1duUDh2M3lS?= =?utf-8?B?RmU3ZW95NjMwbjd3aHkzdDF0ZG9rRHgyWmpVNHRRZjA0UnBXNVNFTklybnVQ?= =?utf-8?B?RVNFNzZpU082enpkUjdYSW90NmxKQzlTL0ZDTU96dGlPODU2cnY4eENFV2d6?= =?utf-8?B?N3BEUXBTeXMrV0ZVWTVWUGN4d3BjZEJ2a0VZVHBsZmRYUWFjdDNlb21xYnpv?= =?utf-8?B?ZWRUVUFYeUY2Z0RUVkhBaGY0aSthUXpPQjJVMTA4Wnc0R0lPb0xheFVBSGJS?= =?utf-8?B?VHRkVzVZaFhZY0psK05UaCtNUXppUnJIanJvY3hBeC9pOFFDL3gxQjdnUDdi?= =?utf-8?B?YnMwWUZJaDlDUElaeVVDb3FKSTNhbUJHVUUza3ExL3JDemdTZkl5eE1wSkJM?= =?utf-8?B?a1VJZUtHSXQ4VUF2SmltM1lzTVBHMmpxN01reHdBc0ViMC9LeEpVa2JDS2RQ?= =?utf-8?B?c0pGQTV0MlFCS3dzODdKb0hkS0d5SHRLUHhDOGpNRDFmejVWWERIUktMZE1a?= =?utf-8?B?ZDVyVEZNNDJzaXFsR29pSUlnU3B3aTJmaURBeE15cThmVzhRNW5teEZaOGlT?= =?utf-8?B?d0VTWm9Tbkw1R3BsK1JacTNxOXlKNytnQ0c4NmtWRG5IMW5KMHRTZ1BURVI5?= =?utf-8?B?aGdSSkU0OGc1VWFOaHNDL2ZOeWJjc0piMWVVcVFwT0VJd2h0S2w4dm5ZVVpm?= =?utf-8?B?eG1PN0NyZzB3dlpiU3QwM0pRQ2NsTE9qT0FmemQzbUJTWjBodUt3ajhiRWVI?= =?utf-8?B?by9lSFRMMWhHbVRicHBmdU1panlxMDh0cFRSSTM3cDh5UlBRMngrbnRUdDZO?= =?utf-8?Q?ZloHXv5FA1qSSNFw8BGAs1oXu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dc78095-24c0-45f8-20ea-08da5f2da050 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 08:57:59.5369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uLhM4fBgXRbYe7DmnMD+IzFd3dghzM8GMEszC1YJh8Nq4IhNpeR2QjilhnKsdRSVCWtgUHM0Mr5wFkYFrzK3Gw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3474 On 06.07.2022 09:30, Henry Wang wrote: > It seems that this series has been stale for more than 3 months, with: > > Patch #1 merged. > Patch #2 need feedback regarding the kexec and argo changes. > Patch #3 #4 #5 #6 #7 #8 #9 reviewed/acked. > > So sending this as a gentle reminder for kexec and argo maintainers. Patch 3 was also merged. Patch 2 and 4 indeed only wait for said acks. Patches 5 and onwards are pending a clarification by Andrew as to performance concerns he had voiced. Jürgen did send a number of pings, with no result at all. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:01:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:01:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.361995.591819 (Exim 4.92) (envelope-from ) id 1o90uV-0003aR-AP; Wed, 06 Jul 2022 09:01:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 361995.591819; Wed, 06 Jul 2022 09:01:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90uV-0003aK-6y; Wed, 06 Jul 2022 09:01:27 +0000 Received: by outflank-mailman (input) for mailman id 361995; Wed, 06 Jul 2022 09:01:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90uT-0003aE-TC for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:01:25 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 366d686b-fd0a-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:01:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3474.eurprd04.prod.outlook.com (2603:10a6:208:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 09:01:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 09:01:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 366d686b-fd0a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ya7rxddcD8AndSZQThk3MXldrwA9DOJ3u51CZSY4Tkb8VzIsJXk9tIHbys2fdbAK+HsCJWtzFHQgla8wSiCQZ320iKTqxGJdsQDCbe98N7HS2wLiva4C/NZY3qpy0FqCdZFNdH0auCVIbac0IGLY2eZ6QCaGQZD2NcrG3lIzGMoVJEdiRT5ns39vZCrElF6jfm/wwFOUTxbPMm60YAt+V2bO973DizkcDCQLhrZ+vWxJLqtj1IN9nzvy22kSyRnXuJPKsxHZW/9O81Xr2/T+huwBDwFapnLKN1Os3mCWdo5l5l8wrkgj6TnqsJtkqt3Q83gQSWUO91amrh1zRu0jJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fkv2XVwsr90t6HhOorncs2A8E2c5BJgYWjXcZMWvKBA=; b=iXlqA5cwMZ65iFEQeuAQZWmtezdrgDCivkre01ZnijhtbyjFtU31m7mXhFF67a6k5LNTlXss9JzAybbzkcWNKE1rhnDUWbfhvBVW6+F/htMjIvQegiAPF6iz2z4aREkaa9cpE6oI/QAZRiDoL+49FNnoTr+QdUDouxzmH4fyA7AjLI/3RFP29Hjw2fMYLCf+JV8mv6jcJ4iIJD3woBBnAnArc64+VEiao3Atdx9hS2VPyXDJVGWM84ESXuNhHls8q7GjBGUdtfXAeZjUx0ZNaEHguftyUwrpb55a/uuDtXEi07mnOo/XHFaNLaS69IIn+GNH6Xy3w0XQlwZrVj+cmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fkv2XVwsr90t6HhOorncs2A8E2c5BJgYWjXcZMWvKBA=; b=O0gQ4SDCN4vgUmyVRWiu6w6v431b8vSsqzhgtKQK9XFBRC74O7cDlffyrd36LpCzy14cigP8Axh+JL1kca9mobtXyZ6ktpO7TI2SNWCib4t89iO0UriHuXgP3FAr4rlIuxY3IrJewJ5v0ZIdsCIr9g0soI9ne8YSoBDEYTtZ8WRqacwD4SOKUHYVjGjTb8I9T40NOyKm3zDbn0EV9dJinqStycYDY7GMAl7BdRWJbnq2OM8xnNb3Ib5ayXPBgfvocL5urDjynivEU6YVqmuDc1pZwC91b25Ssu/U62UBOKzvAGZzMMdR35cGtn/jDvVQHkZvJjPfXYMZMvn7TYfnxg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <46944677-13fd-829f-1b73-13720bf2956e@suse.com> Date: Wed, 6 Jul 2022 11:01:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC PATCH 0/4] Introducing a common representation of boot info Content-Language: en-US To: Henry Wang Cc: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , "Daniel P. Smith" , "xen-devel@lists.xenproject.org" References: <20220531024127.23669-1-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0061.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3dafe755-4261-4d04-8584-08da5f2e19ef X-MS-TrafficTypeDiagnostic: AM0PR0402MB3474:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MULdZ3vaTrQR3gwlWVjFBE/LSKC4f1IM8L1cS1cCJ6OSTHgmm4vDSs5k8io5wgKdTcXf6BEj709MVBOZxLh19hV4PoFU6ayWQy8DKwGh9UVjGA9jKAn1bhPaFkewnPpXy9EarklUzoP8mAMpiQyZ1/ydelDgMvFs1MzgmxOFiXQ9dcts87uFLBYkTsDfel9ocwftBQWgDOrcm0FfOwhF4PDbi2QNatKF+IIr1KzUc2yZD9KqbDUNVcaza3e/2cDieIdalUKVfL0C2jFciAvqBiVV9f3JkNFhtAn0l3a9jTNT41ncO/IGQG0blG4SMMqFM3+j4WLObqPCH0xgZ9nu5rc5a0Bs2QhJwkz45Q0ghQeIxpryPY4Xew339mrUFwn2N/vppYn3/kcu2VdANA5lcrSGpGhyancsdM7vwtXMZOU+UQtcHKy+NFUMi1Y/zwDktK+njOtPLCFbCLu/zZEVgltUWnvaezKLKOqPr9vbQgLGE6Wbl8WnQDmHlPxKxGt1BZMWLygxAeU3K8sbL6UEcEXmrvIsrql2m+karAAfr/jbb/s2vB5yMrdk/FfhSTjJRsVYeWud/Qa5ckvEiMWMrHgUPDWo+H8vx0V0H6eOl77+WZ36cOvLs0gW1TlfnBuMYmuZf6qbUi7gSV68pje3sRhYxSNGzelDGG7wi4oTbYe7XGEe2lCWMIl3NePEwTm7EFxVrFvr19kOClkSynjdsO/0m3Qpy9aERgkxkajr67c5+TGCZUt8qPjyg1kXfcFik3e8MTO9Y9vJ1XhA9hCw0Y92BZjV20rHL1HrCkRo05A5jKMBw+uFf39Rb7ttIpMaVV7I8iAsLv3VL3Rm3bBILSQ9JUz/WjnuKTV9prKLfoo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(26005)(6506007)(83380400001)(41300700001)(2906002)(54906003)(53546011)(316002)(36756003)(31686004)(38100700002)(6486002)(8936002)(31696002)(6862004)(5660300002)(86362001)(2616005)(4744005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bldVVWhBcy9CZk9MdkVHQkpYeHNoa00vWUdBU3hidWJLUHBBcHBrdzlVY0NM?= =?utf-8?B?citEQmxScmY1REU0dENPdVlrVUk2MXAwUTlJcTZ6eGdoT25FY1ZOUkxSNlhx?= =?utf-8?B?VXd1MllWcU96RGQvcUEvQm5IS3VYQmZDa25yWVlvbXcxRGtzL25xZDZybGw4?= =?utf-8?B?UnBrUVFwa1Z5WjhNOUUrSXFNQ3d5RjBLUDdJMlRMdTR6UXJzY1RwVHpuN3h1?= =?utf-8?B?LzkvOHRQUkxGSllGekd1MUk4SFV1aTlLM3FHbGVjUXdFWHdOQmhkNmdxaTYv?= =?utf-8?B?YUFnNGRaVWJ6REdKd0lPNTFnTmptd3pqUGx5cGJaOUdLQ0tUMkFzYnM0NEFj?= =?utf-8?B?WTNhWWhDNzVwTTJ0YVJuWUc0MkxTKzk4cTBNR3dzVGZKV1dSY21IUmFZZzd4?= =?utf-8?B?cFFjRTc1SktacXpSZjFSWHdkMXE4WGhiTmFMTUxtNllpcHRKQUZEZU8rVzZs?= =?utf-8?B?OU5YWXdlc1ZIcTNTSjhLYmxlR0VURkFHUU52d1FSbU1UL3VId1ZQR2hGU3Q5?= =?utf-8?B?UVlIcTZoYlpNMzliUWlhV0VreDhtNVZOeEdEbjk0MTA0T2thNkZvbEx1SjZ1?= =?utf-8?B?cW1Ia0FkdFViVzYza3ZFWExob29pMHlxWG5leUN4WmlXMHhXQ0lES3Rob1Bj?= =?utf-8?B?VE5QRnB6VW92NndjY0lYNTFEQmtGQkNBM0VhbmtSbURmQ2FjTlhBaWM3WmFY?= =?utf-8?B?WjdvQjBESXhKcGhSc2s4UlpmWmtINU03Ni9FSmlKS1RyaGc5ZEd1VFVZUGE2?= =?utf-8?B?dlFwUDk5aEhSWk9jNTZ2SEVvNXJKRXB1YjloeUs0QTQ0UERYMmV1YlFpZ1Q0?= =?utf-8?B?NVdCa0ZKSHZVYUwvYnhyMmUzYk5UaTk0QTJRV25aL01JOU8wUEdyZy83RmN5?= =?utf-8?B?d1BUejZ4MlErc25aemZybWc5S2wzUU5tejZsRVcrVC9Rdm1xSldIOU1mV1Qv?= =?utf-8?B?MFRvVmd6eEgxTE5rbVdjOWo2OHZsemJhZ2RERVBWb2wvUHViamRlVk5ncVl2?= =?utf-8?B?Tng1cnpNRDZQSGZkenhiMHRia085ZUFvUkxaV3dIbGxzYWFFdy9oYkpWRDJR?= =?utf-8?B?S0dsa1JOZ0ROMnR2R3Nhb2hiYVpxNVFkdzVJUUhpa01QRWRCa2JWcTJnUVZr?= =?utf-8?B?NlBhRWNsSkxqeTEybVM2RjVIQkNJTHJrakQxSmszMFBmYlRHQmd4ekM2Vm83?= =?utf-8?B?OFdUY2N5dTRzaFQ2cVZPQzk3cjJPMzQ2V1BWalE1aTgyMXN6YkxsNmF2dmtE?= =?utf-8?B?d2d6UGZsWFpIV1hnbkdIZGNHQTdYVHUvbElxNFVjb1NkWUJlZlgwVERpOUlp?= =?utf-8?B?bUFpS0NkMEJEVDJHUXR3QVhZSTJmOTR2TlNEc1QwUzdMdzhBSnp0Q2dLdHVH?= =?utf-8?B?bmZBSU02ME05ZXprejNFelg1UDJ0K3hDRCtCc2MvcXNQQ0hGRGtqYWtYN3lI?= =?utf-8?B?bWVrMjVMdHVKdXJGN0NFdUpPekxsWnp6Y0lhZStFY1RUZk13YXdqbk9QY1My?= =?utf-8?B?VmxsY3RTcUZETEF5cGRZSWxKYUNqN1RzWjFRTmF6Z3dlQmNTR1FScHU5Znk4?= =?utf-8?B?cUZpOG1qTkRWQVJwZmhTckk0b05UL2xmaFBUSXhyVTdsMW02NnlKL3VEQ0l3?= =?utf-8?B?NU1iN2hRNDB0WndQdVRHVzlNNFNmakQ3T0p4SURQLzBTcnEyOWY5ZURvZFFC?= =?utf-8?B?VFQycFJ2MFkwSFprS0VpanJJWmdjbUF1aElEZ09Zbk1GRkV4d1JJL0g1TEgr?= =?utf-8?B?cy9hOVNaYnc0aVVVT1lWZ3IyaDlTRnZXbFU3M2dMc1RHWU1pZzZjZnk0eGZR?= =?utf-8?B?L0hnZTNxeTREK09CaTFjRkVKNUljbWRhM2RHbnNMWXk1VnNPa2FIbWFmdTZi?= =?utf-8?B?ZUtlYmhVU083V2Z3YWt0RDNDU2JOYnJnK0pyVDEzZ21rdUlZVDU4Y3FKWGNz?= =?utf-8?B?MzQ4bE5kOXBhZlljQnlqdVdxdzlRVDF6a0RWMFN5S2NYaFNkV0ZEWHpCUFh2?= =?utf-8?B?ZlRIeGhkRVJTTlFxbHQwdHBGd0ZHcm96QkhEVGI3RDV2UXMzQmFhajhnaVU3?= =?utf-8?B?VWJ0ZmdJMExkTlFiZ01yWm5mZHBJOXlJRUVmaU0zVnZTeUtwa3FMVXZ4dkZk?= =?utf-8?Q?cKfzH2YvXAqxBMKBN2pvWxAOx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dafe755-4261-4d04-8584-08da5f2e19ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:01:23.6014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RYAQlclH21Xvx/N6366zVQEFmukk1n6QpxOdrrAb1vBpgOUIu3Ki58NveIRzcLCe+rlWquKKydHOFmCutl2eMg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3474 On 06.07.2022 09:30, Henry Wang wrote: > It seems that this series has been stale for more than a month, with: > > Patch #1 has some discussions in thread. > Patch #2 #3 #4 need some feedback from maintainers. > > So sending this email as a gentle reminder. Thanks! As a general remark: RFCs, at least in my view, take lower priority than "ordinary" patch submissions (and other work). I, for example, have this and other on my "to look at" list, but I can't really predict when all higher priority items would have been dealt with. It's the sad reality that in effect this often means RFCs won't be looked at at all. One of the many unfortunate effects of our limited review bandwidth. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:04:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:04:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362001.591830 (Exim 4.92) (envelope-from ) id 1o90xD-0004Ba-NU; Wed, 06 Jul 2022 09:04:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362001.591830; Wed, 06 Jul 2022 09:04:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90xD-0004BT-KX; Wed, 06 Jul 2022 09:04:15 +0000 Received: by outflank-mailman (input) for mailman id 362001; Wed, 06 Jul 2022 09:04:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90xC-0004BL-Hd for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:04:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9aefa537-fd0a-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:04:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3474.eurprd04.prod.outlook.com (2603:10a6:208:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 09:04:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 09:04:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9aefa537-fd0a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oe7zn9FJw8YnXXzmcpSHnDSAAluHhlPqFewSD8eISNQ6CyujGdOZbZksbatVll9qmZJnU/GDeeLflSRsiS6BjjKD/S5auq0b0kZRK9oZesmHqjqb4dN3Ck0URnhmA8zUY94TZD2IrxqEQWW6WpKwShwIYvx4g8Igv27haiXWeDX80uRXHMn4F01cFlpk9rjYWcvttcOp5/AXWabsbYiCnzxb8pNuIJKGcWmfHOW2dotPRHQeaqToM4OTm++xSdWB/wQFQnN8MbbO6g3SPMVcer8UtzY3VxPp6Q0h3xcGBk+0NWjgfgYe4fIhIP9LGZmWuDCBJmLQ5w6G0eHNyrbxzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U4nFSsecvelAWpIaWprEtG0wVFTJDUOXDZi4Qvv0RFg=; b=R8qin8ZqFgUmbh09fY9NV/1qt9EtZVtqHscwWDTsunBCnro+1jytqxsBg3ongWozPUpJA1il4YSh60+fVbliawlPah/QoRkY0RfY5ugFOc3Xyk4PlxxDm8A6wlkEghv4vOAKZvAh9sq6hcyYVQlV+srK8mp/veFQgcwireZJ2y0uZQ3kB/gPAQltD1nRNRqPhXErEJWdoy1fvyBT7xUUii6L4bRTffw5LlIHUkZNKhzee7XsbsCV+gEOTMH0Vn8IW2y+EUkYu95H/5acNNn+/ozFskXYXIIBoxtLcSg5XKdMwZAZEZH0lxBiLE+dyFFcVvgnxNlZa5HuO4zlu7uXOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=U4nFSsecvelAWpIaWprEtG0wVFTJDUOXDZi4Qvv0RFg=; b=1Dgci40YPLVLBgCdVQoTA5+P5vmG9QbdZKc8kPJX964wZnPMLR4oLQRU7RFLEbI6XgM2n+crkPwoTFzP+5MZ9VrvXfG+XORUGgcA2Da4NCbQiEFu9qghWs9SUut5EFYrueoZlGVKRfwlu6Y3p91g97Ulh7yHVn7Dc6qZc/7fZJJSI5BBLJ2TbjJQPe3zXHR9Yfv/7c4CZTMKbM6TKYOjqBVQimClvPd1UdWkvSC47KlUE3R2iLLr0toZGT3vrEJRGxnEWBsUs3MKz6yZuq7QfDQzG9I9IIf4Sz3UjLVM35D4XrK2vW6qp1NABodbnayl6wGfD7PUEXCfEGtf4WWQxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2377d0fc-1234-56af-fdef-935bdf8322a3@suse.com> Date: Wed, 6 Jul 2022 11:04:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] iommu: add preemption support to iommu_{un,}map() Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , Wei Liu , Paul Durrant , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <20220610083248.25800-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0100.eurprd04.prod.outlook.com (2603:10a6:20b:50e::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e8c1b04f-2257-46af-72a7-08da5f2e7e98 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3474:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 28QWXheLeHAY3sU19lFLqO1Fyc5OeSEbNpUON8EhDmdNj4LjPQJw5ad4aUtRxmR4JdMUYZha+WMKtw6mIYHIVnaJIaqyFzjpWawJfsJMmnxmyzMKDKhV7ZMfYKHrfrNwXXhxPz0PK8HXhgLk5N3I6jSmJe96Tsqjob51WYTY82OUaYlqK3lVCN1fK097h0POvn2ZK1HxOrnEJkz/AFZD3zn+VBfkAzcW6vq33BC6kK4kokpbUZTvCj0y5e7DjTOMyoWDDAGjqIYtG9CcU1dRiC6MiYredIxT15AVfIRDt/iK/wYdS3bP2x2dUt7vl2LzxA0qjwPH2D7RObRBKXuw3ME3pjVjwni1wJ0RMbqJFJJDEJ41MoZp9PeE2yNeMnTpMF8DiPySDaAsdhmL8bIeaU/DCKC9Id4EH/NNotjLyCW59BP/HuNI8xO8wZZ7xMyEXhJwqPFURhhMC4GZ2dj/Iay/LPjoz1AzDbX4VHfo3RDHanaXvdCpeLR2VHww16VOaPS8Ilet8zQdWEr6lL8AjpZR2HOuEb1uXhopiSaOfGBvL/Pc++i/dysRvzumswN6TpdsXlHv0jAdo9RvGQhIfngJKSQH6yJAX8QkfsO8yefzfso6m29S1seTO67CSB62s+Xr6mXoruiHJSy2MitJ9De03OgXzOb7hQ5Mz+IH/xsRuc4Gl+9qFQ/8u+rU03C/xqXACuDHwVZAVKlDiGXSvsKvvhCdF3PJH/F2J+V8H/DG4/SOy6R1VIpvYWGrTdu/RjfumjZx729VdpDZfzcAL+P2y0adae771/Z2SsLI0yydF3/Mb89F4NIW5l8rmM7iq5Fl/80T7aDu/n2NFr54JdWRXCyVtpyqbKUav4w6Tkkl6IaY8ylTTCAzcnYWPiLk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(26005)(6506007)(83380400001)(41300700001)(2906002)(54906003)(53546011)(316002)(36756003)(31686004)(38100700002)(966005)(6486002)(8936002)(31696002)(6862004)(5660300002)(86362001)(2616005)(4744005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEJ2bE43ZjQwMlZFNldjVVVBUVBHMUJadXBVYTF6QWVRQjFBQ3JYWXlZN085?= =?utf-8?B?VzVNYko3Z1hRMC95TkpXMGhSbXNBYkRwNUxYay9OT3UycExxRGJHQlNCb2pG?= =?utf-8?B?d3dLN0xOL1BsM0lCTDhtSFNMYzJrQXhERXRBOFRBZisyWDhFTFhoUmlYSlRO?= =?utf-8?B?VjJlTDZ6ajQrdFhUcHZldzl2Mk93QitNNU5RVGcyQ3lMaHEzSURtY2Yzam03?= =?utf-8?B?K1l1N2NnbFJWRmVEZExjczMzZ0FyQWpSN3Z1UENUeGNyNDRRbktoU1hybHZB?= =?utf-8?B?MlQ4WU5HMHNOVURmYU5ZSzVlcmIrTGIzRHkzS01hNW8wd2ZhSGdad3hEUCtu?= =?utf-8?B?K3EzNytNNHhEemY5aUZGK1V6ck5wTmlxRDBGUFFIZUtoU2RKemMyTUtBbDMy?= =?utf-8?B?eW1sMXczQmNHRllRUE1CaWtIclcwVmxTZk1jZlJLMUI4RGFOc3pYZGpuK2Ix?= =?utf-8?B?RVZWWXpNQ2NZS2RsekdiRTZZbU1VbkVtM0pVZmtwWDVvQVdhUFRocDF6akpU?= =?utf-8?B?YVV6b0hQWmRYMk1VRGdGTUE3TDNkK3YwbzZHT3Y0U3pzck16Z2J1RUV0ajFp?= =?utf-8?B?cCttR1EvYkFQVnU4UEJRdUtlLzJDWnMxWXo3UGplbE5aRlJUL25CeEl6aWVh?= =?utf-8?B?MlMxVUtTM2NWUWRrN1A3VE5oQ29ZdEhPdmtYWG92b2lsV1hyVTVUcUh2UUl1?= =?utf-8?B?dE9aTnY2SnhQZkJuNit4aVdmRVVPaGEzSUxwR0hpWFNuaE04M3BXdTVXcm15?= =?utf-8?B?OHBLQWVCVzk1WGJXamdyaVR6UTlQNi9hTktKaHlkUEltQnJTcXE4VzFZeFF5?= =?utf-8?B?WWsrcXlDVHpFOGRRRU9WMDFIeGNxVVU3NnN4ZW5HWkM4Y1lHbXZONFZmaUhn?= =?utf-8?B?LzJmZTJaS3piQ1RSV1lPYmJzZ3ZyZUF2bnZvbjBPOFBMY2ZWeWFVZ1NnY1FR?= =?utf-8?B?TnFoY2w0Q1hXL280SEtPeXM4Q3V6ZFpBclJOVW5JS0J3UFhybm50MGlPT08r?= =?utf-8?B?TGpCNVkwb0JKQVgvTzNBck4vYkd1SG42ZE9FclhBVmNYNFVwbWtJYi9DaTNj?= =?utf-8?B?YVRDSlpQWnVDbGwzRjZzL0hlOXZsM1FmTm1STkNOYW81Q1NMaEhTRDErbFdi?= =?utf-8?B?elZXQ1VhZGxLeWthaEp3aUcyRThhb3E1aW1NL2h4c3BXTktVTzhBOFp0QmVo?= =?utf-8?B?U2lETlBRNHBKODRoOHUxTjhRRm11TEVvVHJ4NU1DRXFCbWFpT29IYVdJZFgy?= =?utf-8?B?TG1ZbzRtMVFMTHl3MnlCU2xoV294dG55NGFJZkZEcG4rcEl4UFJJcDhjK1BC?= =?utf-8?B?QlBwT3ozekFtVm9tTnJTRDlmSW1YQmVBaVBXS0VmUFFCUWF0Wkc4RFY1ZGgr?= =?utf-8?B?OVBvcEVKeHBMelNMV1E1Yzc3SHp2ZlZrVnFQcWY0ckt1cjJzb0FFNUs0d2pD?= =?utf-8?B?WmtBVzVOdmZPM2VvWE9TS1Q5ZE13NW1jQWRkY2g1eG9LekFnbmg0SXlxTmNo?= =?utf-8?B?QmN6b0RZN1J5dkdOQytuMHNTTlJGQlFGVUdKZzFYM3dOVHd3M014SmFxN01z?= =?utf-8?B?V1dkTER5eExDWWRDanFsRGwyQlk5ZW9aOFdqenlMYk5xcjQwQlp3TzN3SmNj?= =?utf-8?B?ZmZUcUxyQlpVS3JVektPUTJqV3o0QndPdVhTOGlIOHhWWkxJOTVIVmhoaklI?= =?utf-8?B?VjZtSkZiMS9wZERHeGNPWi8wRHpUWVV5aXlRbFZjQVdtYXVGK1ZXYTJpcitJ?= =?utf-8?B?QmlTYVEwV1FIK0xHSkFYK28xVEpBY0NJMzdLSitOWkVTSCtBNHVZWDJUYVFF?= =?utf-8?B?MXA5OTZKN0lPZTEyZTY3TWdrRjJJRzlReW8xU2hEMklLME9hcHNRek1zNXhI?= =?utf-8?B?M0lnRVVYRVJPTDMxNzRvQktoWk1zYThDZ2t3bkY3YXp5WndyTmdUdnN2eGtz?= =?utf-8?B?ZkZ2WmkvMmZlY3ZBMStZRi9zTW5KeENIVXlPbitKbVJQd0h4SHRiNFR4SWZh?= =?utf-8?B?bXdVUlFNOFJqeE9DWHFXekROV2RvU2gvcld4cUNSemJ1OGlIa0w1M3hiRksx?= =?utf-8?B?OFdCTW41WXNlM0ZnNTVDVXB3aDUyeUI2Y3dPSkl6OVNkV0JBM0IrVzVUbld5?= =?utf-8?Q?JNV46V30fAq1Fv3Kil+teUVAH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8c1b04f-2257-46af-72a7-08da5f2e7e98 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:04:12.4963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KoaMjyAJZByn0VFt04tIjR/FUOMgS1yfwN1tl+9W9T79AYoezESGS5pHpkf8d5PzFOQRD9bHJJv8Bud6Zxqrbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3474 On 06.07.2022 09:31, Henry Wang wrote: > It seems that this patch has been stale for a month, with actions needed > from the author. So sending this email as a gentle reminder. Thanks! There's no action needed here from the author. See https://lists.xen.org/archives/html/xen-devel/2022-07/msg00166.html Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:05:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:05:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362007.591840 (Exim 4.92) (envelope-from ) id 1o90yL-0004jf-2e; Wed, 06 Jul 2022 09:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362007.591840; Wed, 06 Jul 2022 09:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90yK-0004jY-W5; Wed, 06 Jul 2022 09:05:24 +0000 Received: by outflank-mailman (input) for mailman id 362007; Wed, 06 Jul 2022 09:05:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o90yJ-0004jQ-Ov for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:05:23 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c4412b49-fd0a-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 11:05:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3474.eurprd04.prod.outlook.com (2603:10a6:208:1e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 09:05:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 09:05:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4412b49-fd0a-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zgtc8Ih+QUBPPx1t0X1O+JZTQXr4PfsoyLPelVDD32wPoQVxTS/8DT6fkGBl3XycvnQVG0AIJNPLtrN2Djin+xEPl5udpRtkSbVIpvud2F4Q/A3SKoAcdaujlCpBXlepXXdZw+Tz285jk3J2HQrX6fGcil5pN5CCDnGe9S+NqjJNqxa7ddwCFQwfwvbIx/cu3Sw1g1RhzLHnl1jASPln0pJ6nwHdEdlnO1wRNdBxo0Ql8aEbh53JUme8FvWjqyxsbm+2i+N0doacgqmY+DLRMqjtDFjA1G4Z48cfrSqpVcYJcA3uWRYZ4t5qHflotdd84VmGoHwGhUk23vqh5k2UtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZTh3XsPykSP6dLgfEdVlwHZEw7elspkfNXKu1gQ6NcE=; b=NjJ5rpOk187tGyg0L+eeR8gZu7s1wQfs1rPkGISU7Wn4ML2Z+/1DNZ0KgQNK1ad1ifaiNR+gduNha4rntjidORRqUzIELrbot662kBeWC24chhaoT9ZXGHDb4jMK38y3EAaTgNaUFJ4fyM9ufagERzCWmLUirCfr6kLM/htJ0YgmmSeoQxULQKoaEuqzfnNbFcIpd9JfpX3Psb4eTtXPT5rem6M94t5FdpA2wiWj/T9GeuNKggpRHPkXBd0wz/mgctQLpl3L9gNrIc5eGDDozsOaAdAyfJwud+BCHmZPkKkX0/BJalyxuO5tpFgiwBBqMt0W1xjAKUszyOfkHQxaMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZTh3XsPykSP6dLgfEdVlwHZEw7elspkfNXKu1gQ6NcE=; b=5itm6F0AI89JwtHn/3OhGqF3q+u/uvn7mtP7B4A8lxNjP8ed8GGNkvYW2pSeZ2UQZX3abMomsHKF54WNmgV09VCSgM3YrqHMgyhP+oQArdPUk6LQn9h9aHlpflyH9jSAFXpCqSvHP+CLW9oPnjZZ8jce9JYPuP+fOB1wiD7+6VMc0Hsq6FnSuu954799PhARXZ4YTYV75FFI5GQI5OMX0NQbvR1k+AfdHzlv2k+u1J/OCwCnPpvrXRw0r6ZZXFOS6G4/CCQWRahyFaI9oOZCu62lhBrZ7C4h+N6q6O633RfxIAmBxMs1bFaZu+BHNHjfEHnYfsCIRXp7AqI50z40XQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 11:05:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/8] x86emul: a few small steps towards disintegration Content-Language: en-US To: Henry Wang Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <7f5287ad-8442-6c53-d513-f9a8345c4857@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9e68a74-7c5a-4eaf-aee9-08da5f2ea7ba X-MS-TrafficTypeDiagnostic: AM0PR0402MB3474:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A3bW0pJPr86vTkVrk/W0UAkBG04oWVM6f+VpIo4p44GCDRG5hBSh51TcStWmiR9BcMGGmI9Ie58ZEJ/nSTXWMX5nYKlHvP4KDMcjUByb5vFxVaSpOoIiwbr2FbQH0Q1immaTR5ilVY2nwl04xyevSh6l7DC4XHW8AWAtvKBj6xQPmo2nLV7JGYVGWjFGOBOd5BinpDKMonnWssBcseiS25bpG/m2aSTc7MqjaHULrgxblYEoKuga8LP3o6K20TWJkmt6euNud1Y+Eyf075mZdEY3tGVLQmhtbIz4UzHnvh5UvQ70/mrdPCft/A6ZzM1Dbo0TqFnbmKqvUhTFRu8ick6al+CWSARlzPPu2noI4XDIAl6Znfg8fwoLM83o4jSVgPU5K5MWifY07JAkJOLoEOG1hm6eCMaqUvn0KRe7FOVZ89gukgvYdEEgTGD2VQp83GeOuoAhHkuG9qyv5bSG0Sx/HSq3jHmnorgMITR+AQPASHW7i/8Zftn6+ktsvwXoXF8aAFJH0B5WdpsqQUYMUL4z/FnOg5JEggm5k+bpBT1m7hVsp01xDSadyfhpALKLfjzhuv9/MPSZko3S/+bG3D2j2JXHNYJv5Wo52s8p7dSxuRb0HVsu7Id//RJgz4e1PopnxRGcPSuemY7aDoEZ/oboLSRdxDAcX2Tu6Kc0Gon5caFiWnTMwtVCBgJbaNIxBPxZmZp4NU/TAQwd5THm98QNm5WqRPSJgasUdIlojosmlox50V7ayYSFSP4wQdaFOWgaawn6wv+jBAnmMrFt404eD6HMbZ98m1oYk3RGU6FDgoq3fwJIVbIfgU0sXzXfT2E88WpT36GUHdL+jsrvVhoRfJKnjq+21kmpZhcLFXk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(396003)(366004)(376002)(186003)(26005)(6506007)(83380400001)(41300700001)(2906002)(54906003)(53546011)(316002)(36756003)(31686004)(38100700002)(6486002)(8936002)(31696002)(6862004)(5660300002)(86362001)(2616005)(66556008)(478600001)(66946007)(6512007)(4326008)(8676002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU1ibEFQRGcxWEErLzhHSFpyRGQ2MW1ha1hGelBlWk1TQVRTNWp4QnpFZVN3?= =?utf-8?B?VGtaZDZ0bVdWbDZRNkoxbnJjeUhsbS9xNGQ2UjBLQzNFbzdOV25zZGNialpm?= =?utf-8?B?SVJ2dS9wZEtRaHR4SWt5UEt3d0JjUFdUdXlsMTRKeEVMcnQrMXhIZW80ZC9X?= =?utf-8?B?SzJmekpQUWRVT24zVUFydjV0d2dZd0o3QnVuNURIZEIxUkowQWlGbVd3TXlw?= =?utf-8?B?bE1xS2x6Vm82M2pNdStOMDdIcHJLMDhLUzZFOEtEVnM4K3kvRzhHaEJ0NzNG?= =?utf-8?B?Y3h1ODltbEpyQmNpdTNtTzMycGRueWU1anZ6d1NJbk9nNGJPaCtjdHZNdjhs?= =?utf-8?B?QXQzTlhDbmQ0TTFzNGcwVVJHU0o5TUY5TlNzaDZ4M05YVGVTZm1CMWpyYWov?= =?utf-8?B?Q3NKeklYR1FObEZkdHVWaGpIQUZBZXM3aERJcFRnZ0RzMVRZNEN4Uk9tV09W?= =?utf-8?B?OE5kaDlaVmc5eVA1aktFZ2VxczhzVEdBbkIwMmVvdTNxelNrS2c4NkFOc2hD?= =?utf-8?B?dDgrZDhQL2N1bWN2WTlJcDJuYmpncG9aSnBVSmQ2SElQUnBOVWJNUXBJQjdQ?= =?utf-8?B?VE5QZzlVdC9NSUhuRW41dGt3bWdOYzhGODFuYTBxbkd2ZUo0TFFZdC96T1Bi?= =?utf-8?B?MHZUclh4NW54R3RrSUdQbWZuZXB3SFI0cW9ueG4xSy9hQTk1V0VEdDZvN0JG?= =?utf-8?B?SE1saURrY25lRHczWFNWdW9kZHNCWlg5WTJNMDF1OW91Rkt1QWpwV2RlYnVk?= =?utf-8?B?QUJwQ3UwRnFVNVptbEJRZXpxTHZGczN4cWlNVmhsbk83VGxyZURHZmNweURl?= =?utf-8?B?L1puVVZoeEpHWjVseDlKMVR2cE9PdmU2am1TZVpJRnlENlROdi9pWjBVYW9w?= =?utf-8?B?T1FQa1JNVHVWUmk3T0ZtQ0NreVB4YmJ3QkFQem9pL0dVNzVaQ24zaVhSOXdR?= =?utf-8?B?UFI4UTJEdkdEOUM3MXRWSytCMmVHZFdUZHR4NG5yU1Qwd1UvUnJLbjNLVHdT?= =?utf-8?B?Mm92SWl5WGdjc292ckVSdVNxNlFSM2dPcnk5cXA0V2lGR3BhdzgyYmNkSVBX?= =?utf-8?B?YTNBUS96eGo2WEV6eTg0NldVODYzaGVic3lXSkdQcU5YU1p0cXo4Y2tuRFp4?= =?utf-8?B?WHpOeStraG9GYTIyRVU4aHBYd1pESEJXZFlZbHlYdzNQaWdtWVhvQitkb0VU?= =?utf-8?B?dmhtU3pjQzEwU2dKa3hYS1lUQjhyNE1sa3Z5ZGtWTFI1aVFqTmlLUjVYeVFQ?= =?utf-8?B?OVdQTUtiT0FxYnhKSm5LWmF5QTViTU1MeDRmV1pBM3BKVm1PczhRYkdidkRP?= =?utf-8?B?YmMzL1VUbzRpZTQ2d2xNM1dwYXpUYTZnNmw5T1Q2QXVXbks3aXVkZEhmNXZG?= =?utf-8?B?YVkzNlh0cXRjd2hmdDBOS1E5NjM2MHBMRkZmcVZjT3hxek9XU1ZORTVuMlRV?= =?utf-8?B?aGFKNjVyQk41RXpSSUpVZ25rbFF2S2lFR0E2MldTVGNPRnpJUlNtSkhlbmpG?= =?utf-8?B?Zk91V01DYWkxMDFsU285Sld2ZGVrVHZRd0hSZk5xWkQxRDYyd0JWTldUNzV6?= =?utf-8?B?RkFPaVBVc2VqTnlFQ2pqNXdNS2JHL1F1SlliS1ZTV0ZraGEzc3hRWmlZVVE2?= =?utf-8?B?UWd5YytjeGRlV0haTWxBVFlUbHphNmtOZCtRWUN5MEVzTkFldENUemJpYUtO?= =?utf-8?B?Qzh1bXg3ZExDQk1iVkoxODg4aXEzaGk3OURKdll0TGhkYThkcmZOZmxEZmxa?= =?utf-8?B?OEd0cURvY21Mc3F0WXB4WmxqYUc3SU9uNWw0L1EzQlRiY3ZNM1lSQW90aVlu?= =?utf-8?B?cXY0SW51R0puYXdHY3lMSldWOXV3SDJoRHVQbVdjdlg4MUdqb1FycWVrVzF2?= =?utf-8?B?eS9ZSFZSSFk3MkdvQVdWUHk2S1BSbzEwanZoMEx4RnNIM1Zxd3lBalNRVUNV?= =?utf-8?B?RGpoaThsNmovbHpGLzg0eVl0UjMzMXUxOWFqYlpPQUhQaWplVWVrMlhQUnlT?= =?utf-8?B?cW9MODFuNERTUVJOUUsvSkRXN2RnMkVvQ1RQcGtzL2dhWElNTTlxcDlCQ0w0?= =?utf-8?B?c0xNRGFBbEp0MVUxc0loSERaaW42VHNMdHZwd3I4elN5RGhlRHVKbXZ1aFVz?= =?utf-8?Q?mFm8OkOdUf51GoqKIKshkk+Qf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9e68a74-7c5a-4eaf-aee9-08da5f2ea7ba X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:05:21.5072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GacpI0Jpxabu0sweOkphd33bl/imJq7Vv9iGUF4waIWhVWn6FTrrziRXjPFJe/G2vEeeUNkNGl3ru49R9UtqNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3474 On 06.07.2022 09:31, Henry Wang wrote: > It seems that this series has been stale for nearly a month, with nothing heard > from maintainers. So I am sending this email as a gentle reminder for maintainers. A month? That's only since v2 submission. See ... >> -----Original Message----- >> Subject: [PATCH v2 0/8] x86emul: a few small steps towards disintegration >> >> ... of the huge monolithic source file. The series is largely code >> movement and hence has the intention of not incurring any functional >> change. >> >> It has now been almost a year since the v1 submission, without having >> had any feedback. ... here. Jan >> Some re-basing was necessary in the meantime, and a >> new patch (the last one) has been added - even if seemingly unrelated, >> it was in this context where I did think of that possible adjustment >> (which may want to be viewed somewhat RFC, as I know there are >> reservations against the use of -Os). >> >> 1: split off opcode 0f01 handling >> 2: split off opcode 0fae handling >> 3: split off opcode 0fc7 handling >> 4: split off FPU opcode handling >> 5: split off insn decoding >> 6: move x86_emul_blk() to separate source file >> 7: move various utility functions to separate source files >> 8: build with -Os >> >> Jan > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:07:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362014.591852 (Exim 4.92) (envelope-from ) id 1o910g-0005RQ-Jg; Wed, 06 Jul 2022 09:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362014.591852; Wed, 06 Jul 2022 09:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o910g-0005RJ-G3; Wed, 06 Jul 2022 09:07:50 +0000 Received: by outflank-mailman (input) for mailman id 362014; Wed, 06 Jul 2022 09:07:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o910e-0005RD-Su for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:07:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1ad2cc15-fd0b-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:07:48 +0200 (CEST) Received: from AS9PR04CA0062.eurprd04.prod.outlook.com (2603:10a6:20b:48b::12) by AS1PR08MB7610.eurprd08.prod.outlook.com (2603:10a6:20b:475::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 6 Jul 2022 09:07:45 +0000 Received: from AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48b:cafe::d8) by AS9PR04CA0062.outlook.office365.com (2603:10a6:20b:48b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Wed, 6 Jul 2022 09:07:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT063.mail.protection.outlook.com (10.152.16.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14 via Frontend Transport; Wed, 6 Jul 2022 09:07:45 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Wed, 06 Jul 2022 09:07:45 +0000 Received: from 5cfe01c27468.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C146CBB7-0D65-40FF-B6BE-45DA990B26A1.1; Wed, 06 Jul 2022 09:07:39 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5cfe01c27468.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 09:07:38 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR0802MB2399.eurprd08.prod.outlook.com (2603:10a6:800:bb::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Wed, 6 Jul 2022 09:07:37 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Wed, 6 Jul 2022 09:07:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ad2cc15-fd0b-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TP/xjKxbJXR/eDogdQ3VXlHVhgHjYjHxxu/sBHITP1giPKIwzREk2OXQlfx05bMMoTnIorOWtJ1hBdF4mrBuY0ZeNUsj/Y322oEKV0qd5y2W1zSB8TyAhE8L5ss5jR2YVU0tyHHw0gnKt4xC7Cd9PI7ioyfwIVjkFYInza48fL9IpMkEOS6tuHJEBudEwTcINHYZx/Y916gQABJK7xn2pr6BCEVwtsAmuVGF9lQoTPsFm9uMRvdu9Q0oKtrpLaKYplPofOhZVI/uGagy80AZy2oqYXvB/YiyTidiJ5jdjyV7d9t1rakc+jxI8Y2pp/j3yWxym+L0MhGAgBTKv+jTWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IyE7le+BAxxg9H7KmKEflE2eP67E8EUeEHmzc/ony9Y=; b=OkfElylFaZqDPIXlh7F5o6iAXPqak9SsfNOFFgYVBorSTTtf24O0PUtaBtsoafhIlX7VeZmJSdNHZr4M57gpSBmvoKscrpRz483BK8V305B3YYy15GdhUBoHETnOFV/Ceictrty2WQSnOm96gmPdk01q8C7UGnZtviFfsSvuUZnZGYOqT3pYRByhau9S3AFhbm9hsoX/u3kx8/17W2Hai0W0ltwJQcrHGJ0WqDXjyq+JEe6qTrAhKU3WP1NyNA4Q12hLVjH+kwncqXIFtl0ughMRwEizq9/xSqw5xIlH6VrM2ek+0DjMlJ92JbL+W3NvY13jRy9roS+W+mn4177jhg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyE7le+BAxxg9H7KmKEflE2eP67E8EUeEHmzc/ony9Y=; b=2QCyABGB1QBIE2DnQmPa/IwGWE06lk6STjhBr4Tdj+IBghDAH/kAsWHGcfEl7lviX9mc8Y9HHjsyC6BC1K9Nx+aVEOshm1NDjqO1/b1HAbMfUBswl3L3tOo531TOABjk7qC6vsLNELeF4QG5bScubNd/BuoFxRM4o6qMED17MfQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f728d05cfd85233f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=INlQzSNuJEF5kFO6FnanYV70vRliuVPiSffMAhu3EEzBQIWoBsN2MYoOCqsMIgniLiYLQ1lWzmu8B2mdtOtSjBg4Vadviduo8Sy3cfuAs349WQOQOQqJNxJ6eN7XmGkpc8f/frYl3o/fCqSOt3IQm43I+bBvz6E6AaiwedT/DLJ+tcvV2Phs9Q9IKWl5uGwRG6NpZjHi5eHQOi1mqw2mjwz0P4D2c5NMPISHRKw/KqkZIvx/t4s5bmoDmkOWRoGkWWF8tD2pI039E6UiZKkb8ZePs0WyLYkaCjHEY6nBV169cFJHxYNs/L4TaMdRX5JbOJ0/zSjdDi0Z5bsl6H0NHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IyE7le+BAxxg9H7KmKEflE2eP67E8EUeEHmzc/ony9Y=; b=iVHsCHG3WkuoPEdlwQZOolIqgNJ6lx7tbXVRbeFe9iYxC/Xnq5riKFUIlcw91T4wZH0RMbcHUcu+2OuBCbRdRo/qjL8PTJ85tUi70HhuWNPWFOZU+RZlQ/P/SSezJuuuplxiolcEuwiQMjpMzid5qaRK/Gute7YCSctdCzt1QH8Rj8HZyzAVA1s0Uh/bZAhg/Ui3DbVj6biu+BE5U7mcBL9G/jIWi1HL2YFFkDMRWcaXBdlGweG8ipydn07cGcBPINhtUkZgU2gZMIGEdNFZl5jQxMC5u2PZjxnixWH+L8kDBfpxl5IZ1a/9UhOzPXnyZEVuYErWvycPCDu++X/IyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyE7le+BAxxg9H7KmKEflE2eP67E8EUeEHmzc/ony9Y=; b=2QCyABGB1QBIE2DnQmPa/IwGWE06lk6STjhBr4Tdj+IBghDAH/kAsWHGcfEl7lviX9mc8Y9HHjsyC6BC1K9Nx+aVEOshm1NDjqO1/b1HAbMfUBswl3L3tOo531TOABjk7qC6vsLNELeF4QG5bScubNd/BuoFxRM4o6qMED17MfQ= From: Bertrand Marquis To: Julien Grall CC: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Thread-Topic: [PATCH] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Thread-Index: AQHYkGnF2mJV3nmWm0mEL2tvTat45a1wVMEAgAC6FgA= Date: Wed, 6 Jul 2022 09:07:37 +0000 Message-ID: References: <20220705122114.419634-1-burzalodowa@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: efbfec3e-3709-4485-541e-08da5f2efda7 x-ms-traffictypediagnostic: VI1PR0802MB2399:EE_|AM5EUR03FT063:EE_|AS1PR08MB7610:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: pQpqtO33rOlwSrDptzyAD5SPdog5sRaJUHTBg+VNLGh2xCCfOWJpZLBhLXzSedBgmk9k9R7XdcqTzFA3uZ/U2uZQtTlhiylArHZM5+4f7K86gJ8y3apW0JcVbJsRkuavVMNthM5M3sHQ5D0UxavqoVqdUTFjvUBAL/Ac8sE81enmPsT1WfFC6MVDS96yxuSxRgdNGXQ182a+z9gvGYgNXS3PWkFDkC5/XbpMom9fn/eo98/LxrwEmB8oSgzs9nCgFqLnzXE3hCDE7gbBw8/hIWKOUqtWAeS321JdsTNIQDdDRVesjWXb4c6cdZ8y2fB/e8Y1SZkX8lbP9uVmG/TpyXG4dSeRSv1ahLdMK4nTOfp5gvNBw7hd+6UruhAxcgeloZiog0FZlaQexrwFDnRBWuVGRDzGhH427hCFRiuj1Tc/IF8YMIAYO/ubkb4rss0LiLGSp0MrFq4NSmU8b8gub/NiqgIUEznPZwTgTLz9uUec0DoLCmp/lMSPBO7EZLZDWqo+J7Mis2KsUcIFh4XAL7qifaVCYPeVrQfklnkzP9L+D+qDp0TobCo4qj5Z3jftWRI2GdWQ66Xhu/BnnNctbA3UWXmgLZKvCBEmcExiKpK9CWNpazMyt1W2DPkzHTfsPA9YO5u6/W9YNObx/KBCIYryyXkMQyeYnrrzTD7JBEYaJzbOaQoKhOCoI2Ov7+e97rq8z5Fi/e9XXr3Oi65vtorNNMSwLmMMNCrAGKexScbN/8oiUt8xAFB7iU/E2RSgzdEX+5TAQvsBMpB4P/nfEILfIbB6orhglzmK8Z/HcI2WM1CqABI6YYqhpUsAp/9SGFqJZ7c2ZmX5kNm5lEazPwdqb+G60TU6wo8aa4oGwS8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(54906003)(316002)(2616005)(53546011)(26005)(6506007)(6512007)(186003)(33656002)(36756003)(6916009)(478600001)(6486002)(71200400001)(38100700002)(2906002)(86362001)(8936002)(5660300002)(122000001)(76116006)(8676002)(4326008)(64756008)(66446008)(91956017)(66946007)(66556008)(66476007)(41300700001)(83380400001)(38070700005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2399 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b8720272-6d3b-4d5b-1374-08da5f2ef8a3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pNEZch174/UxmMlld1gDcUDsx3VIzcRDGFyJwiFqhLJshn3vFyVDKPdZUj+sVSVhUAv4tL540rwTzQ1K3IwHCkH61mvvMZYBPC/sw/+tI0ca3kFSPbsNeKcjnmTLBEI5qP6VWpaYZMjZFU/9hF6KHsR6dQvWxKcpVJhllsZsG6XhqB2dB9EoQp5NgFa7bz1J60NGY2uJcQCNo1daqJoDKi447DGTUIXRepKqHObCt/IK3h3hWZAadzJXeJAekQ6X6WCDEY2GVl69/s/pC6pao+Bd8gmGHtmEryEw2dhFQPFZ/G3ZC3VRe3iqV8mAa8InVXQLb2AB2orx4QgWht0PelTJ8IeEv+BqIRqCGorN7w5bsyDJvsZtZYTXQjY5cXhZthYlyHMGCk4mIddhv15IxG/fb3vEwPUy3QrxsjhXrWoM1bzw/JKKfQKDyHNvGu8nThpVfdTybtiJhR6bCah6OILPpQmabShOxX3dYW0Jm7fkmw77od6HHTLEpmmzh0kEluSKGsLC4YrjJ1tt9E0dNO/0tWG0Hmu5zxhy586IKYqIcpQb88MFCEso35EgKPG5byVSUYuuCGg61Ip/gPgORUspS6rD8q0QhXyfF73DidRvkawswiIpbKX2U5o3QyIcrUA1AHW4N7EAQEA75bgNBvywLUYSBm3KqU4jtJVITWOZJrhIdy0xlS8MjN0C8cuL4nsHvnOI+pk79NPRKpCI8ytBamymIjOytx2WpvjvqkYn2DF+O9i4rr0dkoX2gm9ONJI9d6lAL3nreDejQv4mnie88n47KdxE7Foc1L3dIl6KegPDE5DvdZ2X4kOHZuIt X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(36840700001)(40470700004)(107886003)(6512007)(2616005)(47076005)(336012)(70206006)(8936002)(6862004)(4326008)(8676002)(70586007)(5660300002)(36756003)(41300700001)(33656002)(86362001)(40480700001)(82310400005)(6506007)(2906002)(6486002)(186003)(26005)(53546011)(478600001)(82740400003)(83380400001)(81166007)(356005)(316002)(40460700003)(54906003)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:07:45.4457 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: efbfec3e-3709-4485-541e-08da5f2efda7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT063.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7610 Hi Julien, > On 5 Jul 2022, at 23:01, Julien Grall wrote: >=20 > Hi Xenia, >=20 > On 05/07/2022 13:21, Xenia Ragiadakou wrote: >> Add the function prototype of show_stack() in header f= ile >> so that it is visible before its definition in traps.c. >> Although show_stack() is referenced only in traps.c, it is declared with >> external linkage because, during development, it is often called also by >> other files for debugging purposes. Declaring it static would increase >> development effort. Add appropriate comment >> Signed-off-by: Xenia Ragiadakou >=20 > With one request below: >=20 > Acked-by: Julien Grall >=20 >> --- >> xen/arch/arm/include/asm/processor.h | 2 ++ >> 1 file changed, 2 insertions(+) >> diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include= /asm/processor.h >> index 4188ec6bfb..c021160412 100644 >> --- a/xen/arch/arm/include/asm/processor.h >> +++ b/xen/arch/arm/include/asm/processor.h >> @@ -558,7 +558,9 @@ extern register_t __cpu_logical_map[]; >> void panic_PAR(uint64_t par); >> void show_execution_state(const struct cpu_user_regs *regs); >> +/* Debugging functions are declared with external linkage to aid develo= pment. */ >=20 > I agree that those functions are only used for debugging today. But there= are no reason they can't be used in code in the future. > So I would like this comment to be dropped because it could easily become= stale. I think if someone is one day using this somewhere else then he should remo= ve the comment but in the current state the comment would be useful so that the next one going through Misra violations is not = trying to fix it. In the mid-term, if we have a standard way to document violations then the = comment should be replaced by it. >=20 > If the others argue for keeping it, then I think... >=20 >> void show_registers(const struct cpu_user_regs *regs); >> +void show_stack(const struct cpu_user_regs *regs); >=20 > ... we need a newline here so it is clearer which set of functions you ar= e referring to (at the moment one may think that dump_execution_state()) is= also included. agree Cheers Bertrand >=20 >> //#define dump_execution_state() run_in_exception_handler(show_executio= n_state) >> #define dump_execution_state() WARN() >> =20 >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:09:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:09:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362020.591863 (Exim 4.92) (envelope-from ) id 1o912b-0006HO-Ve; Wed, 06 Jul 2022 09:09:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362020.591863; Wed, 06 Jul 2022 09:09:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o912b-0006HH-SW; Wed, 06 Jul 2022 09:09:49 +0000 Received: by outflank-mailman (input) for mailman id 362020; Wed, 06 Jul 2022 09:09:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o912a-0006H7-Pr; Wed, 06 Jul 2022 09:09:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o912a-0005aR-Ma; Wed, 06 Jul 2022 09:09:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o912a-0000Vu-8P; Wed, 06 Jul 2022 09:09:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o912a-0005Xq-7W; Wed, 06 Jul 2022 09:09:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FBe+oTKJ4uPANXYlT5lb8HiTbZL0vKkJEPJ38EHyVR4=; b=OjT14wWkgvqRYqSzTSCx8Z4Z4M NbWoEX3xSvvI3U05ByI+LKiln2eUoKRH6/0xpJymWMFUpRJT89yZOXI9u4oTD6SGJwTG1Fmx0bDIl tkfDeYg9Ec/vyWSFZJLkh8Ja6Pp4mj5hZOnfv/ZxAfA56AcyvUZ+woXdKwawWYRcrsWM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171519: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=61ff2733221e3b5bae5f647d9a460c7a68a5ace8 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Wed, 06 Jul 2022 09:09:48 +0000 flight 171519 xen-unstable-smoke real [real] flight 171526 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171519/ http://logs.test-lab.xenproject.org/osstest/logs/171526/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 1 days Failing since 171501 2022-07-05 12:03:08 Z 0 days 4 attempts Testing same since 171506 2022-07-05 17:00:29 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:11:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362028.591874 (Exim 4.92) (envelope-from ) id 1o913z-0007eB-B7; Wed, 06 Jul 2022 09:11:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362028.591874; Wed, 06 Jul 2022 09:11:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o913z-0007e4-8M; Wed, 06 Jul 2022 09:11:15 +0000 Received: by outflank-mailman (input) for mailman id 362028; Wed, 06 Jul 2022 09:11:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o913x-0007dl-DZ for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:11:13 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30077.outbound.protection.outlook.com [40.107.3.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 94b5bb17-fd0b-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 11:11:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7377.eurprd04.prod.outlook.com (2603:10a6:20b:1de::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 09:11:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 09:11:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94b5bb17-fd0b-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DK/pIxZj3a8Q8oCReky6g278JlnfhAuk2twxzOZXq3u3GLe/np34Gp/CquZmQQnAbBfaeQ6Dh7EoV43W2QDEx2rfQxiHA5uT3rc0wtQpJLtHibY40A3asUxRNcEIYT2D9AZJjA1/OUT8uOeI3yVvzo2iAmFHNnJcVpCNx8C7HBL784Pew4OJebg5Xn6CDgJFrooQBJZJ1chVAxfzRkE+tFiGkrm3QbE8ZETZRtrJGk1zSGii+oe8pSgxh/DNwOaYu230VKU7ivBRVoxp9ZxQsYOaJn8jNl4ymvYTHdv/hZj/hf7ToeIXR8t/ttnubG1ei3baraCYhDawrzLHOI98Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KE6Grxf+1a7v6F27dwuW/AekNTIBe60veUrGoloN0qA=; b=a3wTgL34k0TfgFzpCcFF7U8ZwoxM6AkaQxplm3A3G39tU0r2wgLg3evngd/MU3J23V8TYQgV0jorqdsvFFTcccCaTKBQtLcGASQbHxGQcbHT2MaNBkEGIfaebpdpvmFxWV+4XoyvYQrzrgO00l/gA4q3DaswRle7EhNfVwrKMfqNIXJyGhrguj9tz4C6zaocRVaQ0hyWguf43Q+kJOE1Q0DZSwiMAZ4VTAkKXXN6uodQRVFKZYcbUTKLR/JqbRTtKvA7/VHDW4Jtd1H5yhPv7kSaPXUqAygFawTquoKoVGohkqOpqC24e0Jane8SovLWdxewIS4AsNX87V7HqDVdOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KE6Grxf+1a7v6F27dwuW/AekNTIBe60veUrGoloN0qA=; b=X/B+vLhTUlB4K81rKKSD03+RcdB9vpM01gp4p4nJfoLoABmuj4Nv5hwG7/peRoi23t9O1DUFiMv5tIDAsbqmzbwP2+ZTE57PNWlB2cXG8WVSU2ssk61q9jS95EiyC6qTwSKF4IZlcIP2hEcYMgPynpPwkLdwb4jeBIkfVewIGrq5ceVsaHH4UEQdV+ChXbkMZOV8eHJ15H2Hmht59RZYNN1a82UBfChpxR6Oovp4lBClbORCtY7PYqvs8jNtmPxCammRcj6hWl2aHA4qZJ1pwx1SPbgdRBerKnR60V8geZQtzMRwTvMwwTt+2KudDw/rJdDZT2kvuIQazxya1XThmA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <26138bc9-ca9e-9dda-0002-2ff90cd8a42a@suse.com> Date: Wed, 6 Jul 2022 11:11:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Fix compilation error with gcc13 Content-Language: en-US From: Jan Beulich To: Anthony Perard Cc: xen-devel@lists.xenproject.org, Juergen Gross , Wei Liu , Charles Arnold References: <46d17735-e96f-2eee-5d24-fc3d15526c6e@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR04CA0086.eurprd04.prod.outlook.com (2603:10a6:20b:50e::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de138004-02fa-4ab9-17ea-08da5f2f7718 X-MS-TrafficTypeDiagnostic: AM8PR04MB7377:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MC+xpoc0m+WjeeiR8HgMmqkGfGyaluCmBCyVNqzuM29qfMwEiK2UutcKroakS7rGEn3wsGoOF/7X/1p/LplHjXxdOQQ2QrYYvDzxa1iJJ1CzCo1YPDSO12xBvcH2bLdDFLJAEf8Fk6OnZZDbHRnweBhzhf4ZHmBs5WwYtIhHq/hZUa4V837Oe4dwczApMjrdG2+Gf9S4mKTgD9HAsux4f4zOsLVpO9PS4bJSEAKIdp7r5Hx6UlFD/3TamHi/7CsISA9Mv5MfmyqaJYaqQa9u/uemjHp3sJBgAymq6DXLa1+YWNAG29zg9PhfXOedK556FNku7S5o4+KjZh/Cxc40bC9RncDoqt/aBMSIXthLEozHRQCoHotorg3NjfOxK7SsFCRTXSGf99Upad3IPuOxWLFYSQB7nG15IDrD4GkWYWwWpK44gCymAf2n/Bjcb+Vis23lPWHn/UKoX8JcoLfBkFZfw99o6Cp39LD239Beo1jcQd+7dMMf0NhE1fVmC7SMJ4KXtT2SHh5UJUYUbzRXJP2+fTGym4QKsAvy0TXggekqxLcsLl3as9Knb4dVqbrfLWV/KrtJ1pBAyPhDAr2Dx6RVMpWIEEpeH7F2FHBfSo3aJ93SiKnf+CPcrVahAZebT0P0+/X1IZlzk/GRWluKQxNKKrbkgJzyAb6qFT9QR+F8cplOQhU5qKVKkVlk+rzHziT+B1xY42tJFemNamzuDYLy6ed4VVssvWq9Z6R3L0I8qU5X0ZMwtA+PzB0awcQgDG7WceqbcsAqsaN86lxt6GqUAya3pEwLfNWGhmC2kVqDEAsdP3B/0E0wOw2Oh0ITYfomoamYP8zi8MEs0vwGWiq8tqIxd7u1PHl8q99z8kM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(136003)(346002)(39860400002)(376002)(31696002)(86362001)(38100700002)(2616005)(186003)(8936002)(5660300002)(107886003)(31686004)(36756003)(6506007)(6486002)(478600001)(6512007)(6916009)(54906003)(41300700001)(53546011)(316002)(26005)(66946007)(2906002)(66476007)(66556008)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVgwbmxRTC93NkhKMllQZDVVN0x3TGxtSVdaeG0wT290dDdGMFJBQ0lqNEdn?= =?utf-8?B?SCtpVkU4TmJIVFkydzFTditkNzZSTERreXR5V2x3MXdUTFlzVzJtUEEyU2xy?= =?utf-8?B?dUhKdFpTZllLZjkzNy9HRCtEM3R4ODlqYko1eEY0bTBQalp2a0QxV0dBbHRt?= =?utf-8?B?WUpxQTMrMDk0R3BmWmFEMzA3SkZadkpOU2U2ZnRrWWxrYWZ3aUN3R0dTRFF1?= =?utf-8?B?WGlUazdJN1hjRnB4R0VrY1MwQjVyeG5VV2hKQis5d0NoYUUxdjgyQzFVZEE4?= =?utf-8?B?amhsUTFiNUJaRzg1Qk9ac2U0UFphU1dVb1hXL3dnYk1haFIrSUlyWU9qSVEz?= =?utf-8?B?QnhzZHFBTzZqWXlFWDBFY0FHak84U0FTSDZlUnFkTUw2YmdYekNsVlNTV0ly?= =?utf-8?B?YTFNampTb2FxRE05TnBEblJyZHNZTzZkUU1MaE4wNmxEQS96WGsxd1ZkQ2Mw?= =?utf-8?B?bi8zOEVGLzlZSXZydlJhaEhWbS9pUm5mdnBLVm9BZGJTSUVRT3BiVERVYldS?= =?utf-8?B?SlpNT0k0MWs3aUxSQzVIWDlxUXcrNk84RTNMRGZIRHJLNFhzeWEzVFlPVUxt?= =?utf-8?B?Wi9aNENkTlFYbVZQZ0JOcUhMdTh0UVRRMjQrelcwMlc0cEtKYzBwbUpOcklh?= =?utf-8?B?YW1MK0daQzkwbnFXcVF0MWdzTXdCT3o0NkF0UXZ1VkM4cENVeDc5NlV3NUJO?= =?utf-8?B?U3pGN2d0NmZnaGRyUEE0M1ZVcE4vV2huU3pDbDB4K3BkaGtYaS9PdlBubSsv?= =?utf-8?B?VGFQNXE1Smpja29ucHRWVmdTbk5sSTFrbi9JSFZ3ZGFaT0pkWDBNd2hVY0Vx?= =?utf-8?B?aENValBZbVZGTHBGa21uRGdaTnJEM21uajFsZER4UE9RdzVZSDUwc2UxMU5z?= =?utf-8?B?SllueWRBTDJyV25UeXU4YUd0OFhzOVdEb08ySUZVKzFiNkhXYzlJRitJRkRL?= =?utf-8?B?Ui9YSDJuOGJhU2t4U2FYNktiaHV3YnpRSk9WZFdUVks1REZjZytxNi9tUUVM?= =?utf-8?B?eDgxK1JXaUpGNy8zQkFLZzZ4L1pnWUZmZERBZTR2SFZ5M3M1MCtZVVJzeHRW?= =?utf-8?B?cmd2MUZhS0xKZzhwTjRxRzUvam1hem9XYTR2OW9DVHRyVnkxQ3p3cWxBQk5V?= =?utf-8?B?N1RseERreXc0aFZJTDlyZHl1eHlpMWYwNDVGYS9yaWZhb0hjYlRIR3ljOHoz?= =?utf-8?B?Z3VxWFdHMlBxMjhvR2N4aU0rNGg5VWVkVG5oK1c1N1BjY3YreHVtYnVBeHVZ?= =?utf-8?B?bndienU2eXVTZGhFVnptZkE2UUtyMGN2emZpQWd2RnMzN3dES1MveVdYTWFJ?= =?utf-8?B?UnhPTzQ0NHZSS1FlclhrMW4rMFlodmhJL1JLU3cvcEFRZ3NIdDdOUHBFdWRm?= =?utf-8?B?ejZ0RG5DcDMzVnA4TThVMUdackVVUVJESFY0T3JFSi83cHhrRW1pOXMyOXNV?= =?utf-8?B?UzVjdGREN0ZTSzNmOVRKODVRRHFWZUtYaHpUTUplRlg2c1AzeHc5d25QeTU1?= =?utf-8?B?VWFESUZkT3hTRUhHYlhobnR4MnptUWRvNWNjNHBJMHJwb01JRms4V1RLMXpE?= =?utf-8?B?VXNPY0lOR2p1cEY5aXRuZEhsbzlkODRPT2tNVXIzTldKQlVIRVltanlFM1ZK?= =?utf-8?B?ZmY4R3ZodlJnSVBFQWF6eTRDajBId0J3WE1vQWd6QzRHdkYyRWZhYm8vZ2Zo?= =?utf-8?B?YmIzd000WWpsOTltSGEyMllHV3FEaDZjVWhaV05UZVVxTWVoREpUdk5wNGMv?= =?utf-8?B?cEJabWlJOGEwVGNFUVA2dW9mUE5WaW40bk93Njh4OEUwWjBkSTl2RXY5Mng3?= =?utf-8?B?VUVoVUJNckMraWRwOUFuUzlVMXVwVUp5Y1dGTmw3T0d3NmhCUDMxYm9HS01E?= =?utf-8?B?L2RTKzdETU4renl4VE81cFU1dW1RS3ZrR2dxVWRLNEVpMUZRYXFhOG1PR1RM?= =?utf-8?B?R0JSOVdIR1NVYmoyaDFOSlpaOW9wbEZLOVRuNDRaMVhVd0xhbUZyUGNWRngz?= =?utf-8?B?L1RjWFZMcmRVc0ppakNZWkdNQTNsbG10cTIxU2lDdVZLakZyalQ2V1dZMzhv?= =?utf-8?B?alZiOUUxZmJ5ak1GNnZ4WGpRUkdlOC9SZGJDampLdFlGZ2VGbldIejhIK3VW?= =?utf-8?Q?HtK4HhWdTLHMEGvHZF7JYV5DZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: de138004-02fa-4ab9-17ea-08da5f2f7718 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:11:09.4078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lJwny1hGf6IgD6VZVVGFud3wXmQu0XfviSoWGnIc6ep+1yfmeHyXsrww6admFtvjqpbSxw/36Nqqw3NdOEKRhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7377 On 29.06.2022 08:29, Jan Beulich wrote: > (Cc-ing maintainers / reviewers) > > On 28.06.2022 18:09, Charles Arnold wrote: >> From 359f490021e69220313ca8bd2981bad4fcfea0db Mon Sep 17 00:00:00 2001 >> From: Charles Arnold >> Date: Tue, 28 Jun 2022 09:55:28 -0600 >> Subject: Fix compilation error with gcc13. >> >> xc_psr.c:161:5: error: conflicting types for 'xc_psr_cmt_get_data' >> due to enum/integer mismatch; >> >> Signed-off-by: Charles Arnold > > Reviewed-by: Jan Beulich > > The subject would benefit from having a "libxc: " prefix, to know at > the first glance which component is being touched. > >> --- a/tools/include/xenctrl.h >> +++ b/tools/include/xenctrl.h >> @@ -2520,7 +2520,7 @@ int xc_psr_cmt_get_l3_event_mask(xc_interface >> *xch, uint32_t *event_mask); >>  int xc_psr_cmt_get_l3_cache_size(xc_interface *xch, uint32_t cpu, >>                                   uint32_t *l3_cache_size); >>  int xc_psr_cmt_get_data(xc_interface *xch, uint32_t rmid, uint32_t cpu, >> -                        uint32_t psr_cmt_type, uint64_t *monitor_data, >> +                        xc_psr_cmt_type type, uint64_t *monitor_data, >>                          uint64_t *tsc); >>  int xc_psr_cmt_enabled(xc_interface *xch); >> > > The patch looks slightly garbled, reminding me of how things looked > for me before I adjusted TB configuration accordingly. I'd be fine > hand-editing the patch while committing, if no other need arises for > a v2 (and of course once a maintainer ack has been provided). Anthony - any chance of getting an ack on this pretty straightforward change (which I also consider a backporting candidate)? Thanks, Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:17:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362036.591885 (Exim 4.92) (envelope-from ) id 1o919t-0008O7-4c; Wed, 06 Jul 2022 09:17:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362036.591885; Wed, 06 Jul 2022 09:17:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o919t-0008O0-1c; Wed, 06 Jul 2022 09:17:21 +0000 Received: by outflank-mailman (input) for mailman id 362036; Wed, 06 Jul 2022 09:17:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o919r-0008Nu-3V for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:17:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2057.outbound.protection.outlook.com [40.107.22.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6e7c291f-fd0c-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:17:18 +0200 (CEST) Received: from AS9PR04CA0176.eurprd04.prod.outlook.com (2603:10a6:20b:530::8) by HE1PR0801MB1865.eurprd08.prod.outlook.com (2603:10a6:3:4f::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 09:17:13 +0000 Received: from AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:530:cafe::18) by AS9PR04CA0176.outlook.office365.com (2603:10a6:20b:530::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:17:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT013.mail.protection.outlook.com (10.152.16.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:17:13 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Wed, 06 Jul 2022 09:17:13 +0000 Received: from cdb71b135737.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3C448D74-A95C-45B4-A7F1-EE20F4585913.1; Wed, 06 Jul 2022 09:17:07 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cdb71b135737.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 09:17:07 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB6PR0801MB1927.eurprd08.prod.outlook.com (2603:10a6:4:75::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 09:17:04 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 09:17:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e7c291f-fd0c-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cvZfBDvEqFEXmbRcsa8DPTt7d1j7Ic8ea/eYm2VIwiOMJCBjzp6Xt1fTfOZrJJ6IaBY57IsU9YEpZ0MTT86TdE6V7kX7rkYHisKNYvXPPmtRTpbiRPV6s+cVO0xjH/ks3FPjjgVXbqv1SZvzNxuWw6ZUSbPAf4fRBWIuQ7QUtCjpXxL3w2bm2ltDsXP6THUeCAgaoKeG4HjWmosUw0c+MXf7ehqDdRfUQePvJ5Bfy05+I/3ABkQub4c/x5yA9Ylwdj4G4GlQePlSN9nk/r2xClsgIYNK+RJTGHjL0rO2N3LNBDGx6yWNPjSupAZS7BRbSGDkewjZcnd07tkXkDRz6g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRh2CKYfSGf7kAtuC0LCTobmSz7QZfyUv7M0qmkeChY=; b=N/0CJsMphgoTRR2U8s3N0ce3UYFCN5MVZz2xKvpxpwzOhjcs+HZxoFPF8B+HZDi6QeAsamsV/DenI3XWQ2phc4snmfVt1SapFfReyNpJl2pCVCi0pnj5XVoMw88F19AXrGJt7qOb4oULpMlQ3OphcklUo7U8C8iHx4WFRGx3OlwHMoJ3vH8si9G6TSSi+Juili4iKmrvIO4yfiXcwVW4bNfBEN9LtH5Y+arZvC6zXO8+lw3xRGAneEhmZN5rRk3T+P7P9XVJcvsDGfjwVTfMITA06/Rzp8uYtmZvQpkU7wJPraAT0NdLzu5r9E7jj4e4X+/cdfXYSgB8X3DPLeiWdQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRh2CKYfSGf7kAtuC0LCTobmSz7QZfyUv7M0qmkeChY=; b=UAIKacxfheSCqsP4IvRO1891araiYpEPOCkPzIMBLturE/gndXYotnURJn+8l7SKmj1rBRgwEtaatHaIJL6ev6lmJi7G/qG/Obwm8312FU56ZTyxxgs2LZW03YriIlgSuM1lDiaFMrFAJVhCsVwFl1uL6Xn6FMgI4pPJ7yINfys= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sc7dwpLz1QKwemOnquPVHQ8Kw/jFfRDOI4AOWWCi+AS1j+zRmFDZx2VFg4mluOLpPg+6C42ZzyABQD9eygjlajpb7LEmBRMVrrdxuDXONJfiLqdUcFhmRdWGXXdHxKBsQ1V82xuk6Yz8PuOVyEyww+HqTFvCpfqVknB0MEM7SCIBlPF0InGlM7Bztgy2Ssq5kw8De1BIo+1pD7bjaaHyd3WC3DXvce51DEojiEj+Re8gIikkjZt8pyC+MV5c4NIECAicWMUdmRj1TwlgByergJ6zLB76IExp8V/FYaVkfjSwqA8W5kLm4uF1NwU4EJjF48askxMoDXtqwYspbVzSQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kRh2CKYfSGf7kAtuC0LCTobmSz7QZfyUv7M0qmkeChY=; b=HEbJZ1/kigWMAeBqaouIFC2geEmQj8FlmNk5pmpdND4EvHnMsEYcUTg1IcrOOrYKn2uW3dxNMKqgkmM199fkkDFKLX+1EWSIQs1nFgFINsiao89lhBGZZTDf7cN3IwH6KaWSspm72ao6qN7yYk7uQ5G2BLsZMG1BssJQnu/4lpspjd5KAioRqeF9c4ZiE6YaMC2Fe3GnEbr/y66xHArscGJGqDEhnEzJLv+kJNeulXUw++4GqrL6zc9UA15OSS8Hqy0onU4DB7fp08r4p9mmVdkcTqZ7+jdXoD+Ek+NmW9yiwO5G+9v+LW2huqXLX4ZmwmWVttpO8NQx08ofq5bkvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kRh2CKYfSGf7kAtuC0LCTobmSz7QZfyUv7M0qmkeChY=; b=UAIKacxfheSCqsP4IvRO1891araiYpEPOCkPzIMBLturE/gndXYotnURJn+8l7SKmj1rBRgwEtaatHaIJL6ev6lmJi7G/qG/Obwm8312FU56ZTyxxgs2LZW03YriIlgSuM1lDiaFMrFAJVhCsVwFl1uL6Xn6FMgI4pPJ7yINfys= From: Henry Wang To: Jan Beulich , Andrew Cooper CC: Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" , "Wei Liu (LSG)" , Wei Liu Subject: RE: [PATCH v2 0/8] x86emul: a few small steps towards disintegration Thread-Topic: [PATCH v2 0/8] x86emul: a few small steps towards disintegration Thread-Index: AQHYgJ6R51Cg7cLRXES97vjccXbkla1xEZQAgAAcNoCAAADXUA== Date: Wed, 6 Jul 2022 09:17:03 +0000 Message-ID: References: <7f5287ad-8442-6c53-d513-f9a8345c4857@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1EB4E6712541D046A6441EEF64B86471.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ca4ef8e4-32b8-4339-b418-08da5f305013 x-ms-traffictypediagnostic: DB6PR0801MB1927:EE_|AM5EUR03FT013:EE_|HE1PR0801MB1865:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /21P8cTIjuBiHqJdPZUy/Vk9qnTMEZICsdT84a4PMFHRTPy2WYin2mULHa8qrxfXkUS4lKCxrx+3X5A3IOhLeoh/u1VSpHe5zBYqZT692QfGLhAq7djIJTJw0OSvR71LwDD7MrOLS4OhIy+AhprJjnjxlHTDJwtDZ6MzJ21EMjarZEB3E6csvMP7FPruFQoKs8KxNFGIfDVxkW3tMB/bINLbwUB1HO1VwttHEKNwz/4TXzri9MfAu3ybgZga+TXWa+kZ+WXbjCvssyxcaVlmEwbxDkEp/ZN+wA134AnWRALvHeOuPHURP44Jmtde2uYMSoLEMQ0ObbAFRLx8JdnAaG+0iIP/NjpHH6cY3PCKvT8gosogI8Op8XQy911PYUBUXkT3E/3vmt98hCnAY75O/+l0NE4mkjpymIg2l8Eq3BTnBWhBuIhXvVVSjYvAT02S/yigiNHnZ06p/aB16d0T2m2D3jVTlr0XnKNxOwq6xulRolsC2e1QmjM3/KHMjwV21EAc4+j0u+3upz40E30NaNEpIPfhT3mg6MY3uZNHMBxGle/Sw+XqQ/xjKVvwz0D9BloXWyE0AnxBONoSI+T34lHCRBnKuGrELb6oLYuLPDGwM+8Al12Ef+ZX5QAxvU68656BFNGAh9Px3HpQOT79mYPlHIEGz7sS7YidNviHdnzFbIuwlVWc1XCdFfDC9ao7+1ujxxg6VylVJfVDb1tfiCsZ5SxnjNo3dfHA4G44a9hUq2pk7a6Og8xnP2cYsl6R8HoYbcYm5c4li8syhd1cfPQ5MbwO7i6kybyDQQEvdTw3fl6LckJ0iNGOKibMrjbg X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(136003)(346002)(396003)(5660300002)(83380400001)(52536014)(76116006)(8936002)(66946007)(4326008)(33656002)(53546011)(6506007)(7696005)(9686003)(8676002)(26005)(41300700001)(478600001)(55016003)(110136005)(54906003)(316002)(38070700005)(66556008)(66446008)(186003)(66476007)(64756008)(86362001)(122000001)(71200400001)(38100700002)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1927 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba7f86e1-82d6-4063-3f60-08da5f304a4c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eDEHm+zBMQTZK87IP+R4r7WvsB3xZnF2ewh0UZ6ReOYurNoRcxr+qW8Nbd820mwhI4DzfyHo8JyVhV7Hm0OnMF1fe0Kl841YkC/S8bJYq5KXu20CCpwCM7zW17U/vG8+98HmMmRgESQ8T/f29JZIIFRu8sND2tv0VmA+IAkcJB1kYyLT8spGtyOfx9glpF5WmG9GZ3QpKDGENM8+gEoCmkc45chWie/G0YryU/z0ZUJg5D5eGaKQeez6kwnPRdbD8vE1i08JFibUhxrh9PvdYthqvO2iFRGa06S1cU3bt/p+nR9VvZoeDZywGMkdMqUvR5JnpDHIg+a0W4ybadiwnUFRwlIzsar73xNvCnbyPV/3tecdoJrMXCB/gkdt5fPfNiLrxGJiDzHOoYLfbbjJvSwZHPdtzGVNAYEzNTP6NkiOPF2nmzq7RvEnOdjD7PVjYHVp06y4lVAGMtQFBLzdo/e+5P26XgBZ0TSspbC/yKm93n9TmUod6WUxWexYMdNZ1Q64VCr94+4ej9Wpsg9z2MAhPg0Id2VZvMuF9NZ3XWuT4gt1QdwrJMLVQVzOrzasjvh0NpIPpppFh5Yva9Eexd+ZO5EqzQ05VLSJoMT/s0584sl/NW/5qMo15tnM5p+4gXeDk36o9PGrkfN+3SwrkuKb+YKRltPsvYXsiZ/Gooox45sOXyYQ6gybV4ONMqWXRcwKKD9NVw/khwDxXm3L7WYtsktJNN+l9yXEhsLlRvmmyKPrGYBen8jlXCWzPULRam1prMIxMKM3vpvsE9Ky/PCZbMOcC+tmpyrdQ1o/Ny6w2oagr0Ra952l/ZkDNIk0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(346002)(39860400002)(46966006)(36840700001)(40470700004)(8936002)(52536014)(107886003)(82310400005)(478600001)(33656002)(86362001)(4326008)(356005)(8676002)(70206006)(9686003)(70586007)(36860700001)(82740400003)(5660300002)(40480700001)(40460700003)(26005)(81166007)(55016003)(186003)(53546011)(47076005)(316002)(7696005)(336012)(2906002)(41300700001)(83380400001)(110136005)(6506007)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:17:13.2220 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca4ef8e4-32b8-4339-b418-08da5f305013 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1865 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gDQo+IE9uIDA2LjA3LjIwMjIgMDk6MzEsIEhlbnJ5 IFdhbmcgd3JvdGU6DQo+ID4gSXQgc2VlbXMgdGhhdCB0aGlzIHNlcmllcyBoYXMgYmVlbiBzdGFs ZSBmb3IgbmVhcmx5IGEgbW9udGgsIHdpdGggbm90aGluZw0KPiBoZWFyZA0KPiA+IGZyb20gbWFp bnRhaW5lcnMuIFNvIEkgYW0gc2VuZGluZyB0aGlzIGVtYWlsIGFzIGEgZ2VudGxlIHJlbWluZGVy IGZvcg0KPiBtYWludGFpbmVycy4NCj4gDQo+IEEgbW9udGg/IFRoYXQncyBvbmx5IHNpbmNlIHYy IHN1Ym1pc3Npb24uIFNlZSAuLi4NCg0KT2gsIHllcyBpbmRlZWQuIFRoYW5rIHlvdSBmb3IgdGhl IGJhY2tncm91bmQgaW5mb3JtYXRpb24sIG5vcm1hbGx5IEkgdXNlDQpwYXRjaHdvcmsgdG8gdHJh Y2sgc2VyaWVzIEkgZGlkIG1pc3NlZCB0aGUgdjEgYXMgdjEgaXMgc3VwZXJzZWRlZCBieSB2Mg0K dGhlcmUgKHRodXMgImEgbW9udGgiLCBidXQgaG9uZXN0bHkgdGhpcyBzZXJpZXMgaXMgc3RhbGUg Zm9yIG1vcmUgdGhhbiBhIHllYXIuLi4pLg0KDQo+IA0KPiA+PiAtLS0tLU9yaWdpbmFsIE1lc3Nh Z2UtLS0tLQ0KPiA+PiBTdWJqZWN0OiBbUEFUQ0ggdjIgMC84XSB4ODZlbXVsOiBhIGZldyBzbWFs bCBzdGVwcyB0b3dhcmRzIGRpc2ludGVncmF0aW9uDQo+ID4+DQo+ID4+IC4uLiBvZiB0aGUgaHVn ZSBtb25vbGl0aGljIHNvdXJjZSBmaWxlLiBUaGUgc2VyaWVzIGlzIGxhcmdlbHkgY29kZQ0KPiA+ PiBtb3ZlbWVudCBhbmQgaGVuY2UgaGFzIHRoZSBpbnRlbnRpb24gb2Ygbm90IGluY3VycmluZyBh bnkgZnVuY3Rpb25hbA0KPiA+PiBjaGFuZ2UuDQo+ID4+DQo+ID4+IEl0IGhhcyBub3cgYmVlbiBh bG1vc3QgYSB5ZWFyIHNpbmNlIHRoZSB2MSBzdWJtaXNzaW9uLCB3aXRob3V0IGhhdmluZw0KPiA+ PiBoYWQgYW55IGZlZWRiYWNrLg0KDQpUbyBwb3NzaWJseSBtYWtlIHRoZSBwaW5nIGJldHRlciwg SSB3aWxsIHRyeSBhZGQgV2VpIExpdSdzIGFub3RoZXIgMiBlbWFpbHMgaW4gdGhlDQpDQyBsaXN0 IChJIHdhcyBvbmNlIHRvbGQgYnkgaGltIGluIHRoaXMgd2F5IGhlIHdpbGwgYmUgbW9yZSBsaWtl bHkgdG8gbm90aWNlIHRoZSBlbWFpbCkNCmFuZCBwdXQgQW5kcmV3IGFzIFRPLg0KDQpLaW5kIHJl Z2FyZHMsDQpIZW5yeQ0KDQo+IA0KPiAuLi4gaGVyZS4NCj4gDQo+IEphbg0KPiANCj4gPj4gU29t ZSByZS1iYXNpbmcgd2FzIG5lY2Vzc2FyeSBpbiB0aGUgbWVhbnRpbWUsIGFuZCBhDQo+ID4+IG5l dyBwYXRjaCAodGhlIGxhc3Qgb25lKSBoYXMgYmVlbiBhZGRlZCAtIGV2ZW4gaWYgc2VlbWluZ2x5 IHVucmVsYXRlZCwNCj4gPj4gaXQgd2FzIGluIHRoaXMgY29udGV4dCB3aGVyZSBJIGRpZCB0aGlu ayBvZiB0aGF0IHBvc3NpYmxlIGFkanVzdG1lbnQNCj4gPj4gKHdoaWNoIG1heSB3YW50IHRvIGJl IHZpZXdlZCBzb21ld2hhdCBSRkMsIGFzIEkga25vdyB0aGVyZSBhcmUNCj4gPj4gcmVzZXJ2YXRp b25zIGFnYWluc3QgdGhlIHVzZSBvZiAtT3MpLg0KPiA+Pg0KPiA+PiAxOiBzcGxpdCBvZmYgb3Bj b2RlIDBmMDEgaGFuZGxpbmcNCj4gPj4gMjogc3BsaXQgb2ZmIG9wY29kZSAwZmFlIGhhbmRsaW5n DQo+ID4+IDM6IHNwbGl0IG9mZiBvcGNvZGUgMGZjNyBoYW5kbGluZw0KPiA+PiA0OiBzcGxpdCBv ZmYgRlBVIG9wY29kZSBoYW5kbGluZw0KPiA+PiA1OiBzcGxpdCBvZmYgaW5zbiBkZWNvZGluZw0K PiA+PiA2OiBtb3ZlIHg4Nl9lbXVsX2JsaygpIHRvIHNlcGFyYXRlIHNvdXJjZSBmaWxlDQo+ID4+ IDc6IG1vdmUgdmFyaW91cyB1dGlsaXR5IGZ1bmN0aW9ucyB0byBzZXBhcmF0ZSBzb3VyY2UgZmls ZXMNCj4gPj4gODogYnVpbGQgd2l0aCAtT3MNCj4gPj4NCj4gPj4gSmFuDQo+ID4NCg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:22:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:22:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362042.591896 (Exim 4.92) (envelope-from ) id 1o91Ei-0001Mp-OP; Wed, 06 Jul 2022 09:22:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362042.591896; Wed, 06 Jul 2022 09:22:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Ei-0001Mi-LP; Wed, 06 Jul 2022 09:22:20 +0000 Received: by outflank-mailman (input) for mailman id 362042; Wed, 06 Jul 2022 09:22:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Ei-0001MY-4S; Wed, 06 Jul 2022 09:22:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Ei-0005oU-0I; Wed, 06 Jul 2022 09:22:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Eh-0001JQ-GB; Wed, 06 Jul 2022 09:22:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o91Eh-0005Cz-Fj; Wed, 06 Jul 2022 09:22:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RAH849krSc8YlNDQc1Sv75bbSS0TZ1vnWkxGWt5jmA0=; b=hcnj1D0Nn98B3VFnnzjp6YUU4Q T9DJFRLZer0mfUNCvzG7Q4STjir9v7p5dkXJVbMbI6ViC0fIAW1bOyAVHYhzzh9UdU4r1THKeqMi1 te0lGyaACYX5vJfHeHpT4Brt0IwG5siB/PJ+aXJsEMf6tPRmWEhmeG+LsmnicJG9yHNE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171514: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e35e5b6f695d241ffb1d223207da58a1fbcdff4b X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Wed, 06 Jul 2022 09:22:19 +0000 flight 171514 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171514/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e35e5b6f695d241ffb1d223207da58a1fbcdff4b baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 17 days Failing since 171280 2022-06-19 15:12:25 Z 16 days 45 attempts Testing same since 171514 2022-07-05 23:41:16 Z 0 days 1 attempts ------------------------------------------------------------ 488 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 19695 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:28:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:28:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362051.591906 (Exim 4.92) (envelope-from ) id 1o91Kr-0002af-Hz; Wed, 06 Jul 2022 09:28:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362051.591906; Wed, 06 Jul 2022 09:28:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Kr-0002aY-Eg; Wed, 06 Jul 2022 09:28:41 +0000 Received: by outflank-mailman (input) for mailman id 362051; Wed, 06 Jul 2022 09:28:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91Kq-0002aS-So for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:28:40 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00060.outbound.protection.outlook.com [40.107.0.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04c3a3b6-fd0e-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 11:28:39 +0200 (CEST) Received: from DU2PR04CA0264.eurprd04.prod.outlook.com (2603:10a6:10:28e::29) by AS4PR08MB7925.eurprd08.prod.outlook.com (2603:10a6:20b:574::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 09:28:37 +0000 Received: from DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::9a) by DU2PR04CA0264.outlook.office365.com (2603:10a6:10:28e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Wed, 6 Jul 2022 09:28:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT048.mail.protection.outlook.com (100.127.142.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:28:36 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 06 Jul 2022 09:28:36 +0000 Received: from dd66ec49db92.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 83D90A54-C7B5-4C3C-A7BF-8334064A4CC1.1; Wed, 06 Jul 2022 09:28:30 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dd66ec49db92.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 09:28:30 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM5PR0802MB2404.eurprd08.prod.outlook.com (2603:10a6:203:a0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 09:28:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 09:28:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04c3a3b6-fd0e-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=GBoX4P433jl/LFzmXxMlZJLg1/apEarHLfbvyKJ4pAj5npaNEObbEKy7jvMUQesurwx7gczOqaQt2l+xweDDbUfFsP7GfDq4sEJzw3oW2unBuy/fTVXveGlFHfKrFBKTSQIlDOn+1B4Q66VyScFFJ1eX3C838uGKKKalBuMFF5C2FuK786j1pvxwrdqfRf9pJP1FwsTEbi/SfT74SYTAU0pLy2Tqb4Y0gr2RWEWCOIklXgMMM0GjTuwrKRdDBD+1P4GHvtOJw3Wwi05lueeTpc+XGffdiWZee/Yi7gsgFmIzsKGUykMf2MHHbz7L1HzHBQ0jvgqmGQOVT2qWz8lAyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YG3rKQnfuoIiGc64LK+407lz5Kp6l6aLTewi2Sn8cvA=; b=KTMztUpFY6osEPBNX0kDD9R/d3YEV8td8m3+AQp03+DRxleOycYWOdvjAWEaMjecSiY18RXrGdWC0hkJOQVXoHE9krx5ibcEhbdq+F5QqcrVD57ltlxyceiATvinxzPagbCgcis1Cq+WZFnzZABay1V0tqdXZXgISgV94e24gGFL00keTlrDfPDiwsd9c6xcG8AumIp9SYjBnsikWvpvVeiPZu3uES8/AXarwO1tI/2UKW7zBSJv6OmS3VAUmeb5Rbb9qZ4kwJ28xbBgcz8bHmbrFg3ewNp12ILVx0cpYERWQatQuZDhnx7la3JmqzwZ9xXdxRx0les/fFcNBvZC0g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YG3rKQnfuoIiGc64LK+407lz5Kp6l6aLTewi2Sn8cvA=; b=y6h3cJKLnq/4Cc/wsLi6IKfkZ8E0DXBAGKQSpdpaInUFW0IB6xxns9APZJ5BgfG8SvLSnOrTeIq0BmoEywMvi0K7nHj4KVaNhkYPCel8RBV9tvhWoYAkR3zO3kwSC55Hi9VNpy1RUOJmHW5iIAEBi07B527HlE/Gg2ic8quowDM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hp16wDlj2vSeKUTEsFcVnW5Pti5uHF5R45zK5uU3nsrRiVsbFrIChYhXtMOEgNL08T+soI5dk3HfStmOdCjbF4NBU4AKe8zGKoVctUX4LeJ/OkYkWAQ4MKXEvo5NJFFUJvPaVXphE5bUcmImieJzTvqrkDLj1vyL6Qfo+Pd6h/csDlocjt5QWPkRwEAGJkgR9hEQ1b7qQKNzg6MDfQhsXQnxNpJ/oL5WICX6Tm2L7Pux/YLaKyd672c437JclVBQnQP5YWM5HuP4upX7PONZcGWWwJ6loflnGnrpPh++7joaaZwLKmKWFeeL6JTTygvCh3saxQma9sjJvN31Nv0wLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YG3rKQnfuoIiGc64LK+407lz5Kp6l6aLTewi2Sn8cvA=; b=QS8ZEo1/SCmeBfEo87mi/0NwJEuKY1ztN5BJMl6of+YRSR3uuR8qWy8i9WKKYODpy/Oxo4Fngfv80ksVy1r1MrAQp11EponVVkQT3/2wvATH5oWBsHY4GpUL558LOLW08KXOFgAwLu4N0P7eDQuOERCPhDU8GxX/3gCahmVY3u1alqIfliZMFBasyABlz4olYfwoYcsdxL68NnJaB6wtqeldqNFCCaWoml0hhTC9DzYFzaW2EnKw8Ce2wJY0n7GiIyIRkLJ5z+B+DcOMSR7ade8p3/Wk40LvV8SJz8cffeSYMbQg6ALb0/sP9PMYHPnMayl6BjjhH8JNbbz5i8TK+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YG3rKQnfuoIiGc64LK+407lz5Kp6l6aLTewi2Sn8cvA=; b=y6h3cJKLnq/4Cc/wsLi6IKfkZ8E0DXBAGKQSpdpaInUFW0IB6xxns9APZJ5BgfG8SvLSnOrTeIq0BmoEywMvi0K7nHj4KVaNhkYPCel8RBV9tvhWoYAkR3zO3kwSC55Hi9VNpy1RUOJmHW5iIAEBi07B527HlE/Gg2ic8quowDM= From: Henry Wang To: Jan Beulich CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , "sstabellini@kernel.org" , "Daniel P. Smith" , "xen-devel@lists.xenproject.org" Subject: RE: [RFC PATCH 0/4] Introducing a common representation of boot info Thread-Topic: [RFC PATCH 0/4] Introducing a common representation of boot info Thread-Index: AQHYdHf6JvWZG2GXVE2XLLkq14FnwK1xI0fQgAAhtYCAAASccA== Date: Wed, 6 Jul 2022 09:28:28 +0000 Message-ID: References: <20220531024127.23669-1-dpsmith@apertussolutions.com> <46944677-13fd-829f-1b73-13720bf2956e@suse.com> In-Reply-To: <46944677-13fd-829f-1b73-13720bf2956e@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FAF8D3667A01B541B58C691FD1677C62.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 85b97d1f-26cf-48b1-9ac5-08da5f31e770 x-ms-traffictypediagnostic: AM5PR0802MB2404:EE_|DBAEUR03FT048:EE_|AS4PR08MB7925:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c+Cl7SPrkNyp3OgpAwoZ38QKKPaiTb5Me1LoBYeSBg/OZNSq71TWS1dp2j9kKh6z+r03gexq6ng5T8OoC7o0+oOlMATECOgSSQXQIKazR6MdYdUYX+URQF8n5wp+yYtrNeSrsxAvfNxwqog+nnrMS8DYM6PhdAkPm5bHDRyqeMnicIhQ5qZ6GJBKSNStnhXpFWcBL41nP7PTCU7jo8IOXVvOxnmMLKdrIhJqHQMLO2Y9E3RM58G2Qy75mA34WxEyjQ/4gKbr8rjosfvkcEsSok79ZAa6qvl6tLnw7KkBFYPRsbt8gSdq37xoTGCZXrzh/7tOTSpM3upvEV6QKmKSzzXOV85fuQkf5LUWDEWpQl5yPkr8r0enjl1yMcvsSvty3NuVO+NUtdWwoFQGpIw9NrS9QluXPL7r5rg6G/iD2oqYz6/ndZ4HvYiyH4IAOxF1hsb8cLlB4eGMH3Rnozya7kQiUmQJ7rq+X+cx2jxjzXel9RjMeBGL6NXKkTA6Sls2DAJAFavk6/KKgAR2hIpaN9WhKwNDCi+lVO6Kq+dWLe4oAUUfOmZD+15/iomukLXyM4XR0rbCsuTA7HIJ05eR1i7jWv93LtJjT/A4lWCCO+pzSr9ZXpyaEshD2lWX/mtD2xpupL8qzOOH91raflhCszay0Jm5hLpnxC6zfmBVFC8sTorISSATCwsyH2hl+s2qtq3r9A2kJfXMaFMHzxHLugmfb+AUkaB+jvGsP2j4tAFkaf5aJ/DJpUjfRv0958e5RWUas2zBW2vTqygDPMwH1h0CeWU+2Fxv2B+2uPi3WkuJu0rrbydV3xAW4hIhC4/W X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(52536014)(8936002)(478600001)(53546011)(9686003)(6506007)(5660300002)(41300700001)(2906002)(7696005)(33656002)(122000001)(26005)(86362001)(66476007)(66446008)(8676002)(55016003)(186003)(38070700005)(54906003)(83380400001)(76116006)(66556008)(6916009)(64756008)(4326008)(71200400001)(316002)(66946007)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2404 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b232a494-3014-43de-3d36-08da5f31e27f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XpT+r6NDQfJVcl1QMP3T5k/j/vzKFlEuqceBt7uy3oDdCVyANNnXQQOCLkShJOWIVv1rGCXCGhWcwzdY5gAg/AhLomEIjjtTvomSdDAv/ZmVsPX9oFmpJXnYANCv2PO2RtOXZMMhG9HdFo6EBgnEg0fWAPM6/vwmQMDkYfnVynhwKm35R80LDHLPxJqEahUFSxZxqrzjsjOMMvckSmZiX4aRjBAby9/TUuHna5erdeyJteKLEHQCuHViCCKJzOver1P+mcI2xQgrhUD+nGfdfZlhQoN+fQ591VSNp7li1cRJ4CwxC3VUlx2Sufvhq1VCPm9MUFKf7nYI6gfoBqU7LT/vpk6lMl2C1A08R1HE8Vk9S56lY783zWAaPV4ZOnBQM9eDhApzuKb21Bmr+QpUfSNmcAOxI3rqxy5+1QKiYBqChyJrkqZ/N7Hc3rndb5WOBAcukk7vMVEZfq9D3F0tGCdBYsnto080S2gU1j4HKCCPFNiFle9ac0QnrU5UJg3MH5r5h8jlA9CMk0i9Xe6S+XNskOqyPPQfcQyV+GdrLLMXjKP2YQKVk/mqJzSu+QOU+LdnG8DDXZOhmloO90QwclxMR1vKjAsNop4vKd3Qb8a0J/WmkknYEcm9/0edC24BljNA+ZgnLBqnTFfgZ/GS15QZs+sfQvmUCtxyrM2WDitoSWV5R+CcQsJI8MP6ZQozWK3cG/jBHfPXCB4pt6wJXJbijkb8ATFoIa3rT2pIbpQtzwgwWH0fAupHntiNce2YkBF7+XpFCLJiWsKwzAg5xXAJqTaTuvSVueyKdLAYIe3owqxWsaaBwOZTqy/jfsFc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(136003)(46966006)(36840700001)(40470700004)(26005)(40460700003)(7696005)(6506007)(9686003)(186003)(83380400001)(82740400003)(336012)(478600001)(53546011)(40480700001)(2906002)(33656002)(55016003)(4326008)(8676002)(70206006)(70586007)(54906003)(86362001)(82310400005)(41300700001)(8936002)(81166007)(52536014)(6862004)(5660300002)(36860700001)(47076005)(316002)(356005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:28:36.7299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85b97d1f-26cf-48b1-9ac5-08da5f31e770 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7925 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtSRkMgUEFUQ0ggMC80XSBJ bnRyb2R1Y2luZyBhIGNvbW1vbiByZXByZXNlbnRhdGlvbiBvZiBib290DQo+IGluZm8NCj4gDQo+ IE9uIDA2LjA3LjIwMjIgMDk6MzAsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+ID4gSXQgc2VlbXMgdGhh dCB0aGlzIHNlcmllcyBoYXMgYmVlbiBzdGFsZSBmb3IgbW9yZSB0aGFuIGEgbW9udGgsIHdpdGg6 DQo+ID4NCj4gPiBQYXRjaCAjMSBoYXMgc29tZSBkaXNjdXNzaW9ucyBpbiB0aHJlYWQuDQo+ID4g UGF0Y2ggIzIgIzMgIzQgbmVlZCBzb21lIGZlZWRiYWNrIGZyb20gbWFpbnRhaW5lcnMuDQo+ID4N Cj4gPiBTbyBzZW5kaW5nIHRoaXMgZW1haWwgYXMgYSBnZW50bGUgcmVtaW5kZXIuIFRoYW5rcyEN Cj4gDQo+IEFzIGEgZ2VuZXJhbCByZW1hcms6IFJGQ3MsIGF0IGxlYXN0IGluIG15IHZpZXcsIHRh a2UgbG93ZXIgcHJpb3JpdHkgdGhhbg0KPiAib3JkaW5hcnkiIHBhdGNoIHN1Ym1pc3Npb25zIChh bmQgb3RoZXIgd29yaykuIEksIGZvciBleGFtcGxlLCBoYXZlIHRoaXMNCj4gYW5kIG90aGVyIG9u IG15ICJ0byBsb29rIGF0IiBsaXN0LCBidXQgSSBjYW4ndCByZWFsbHkgcHJlZGljdCB3aGVuIGFs bA0KPiBoaWdoZXIgcHJpb3JpdHkgaXRlbXMgd291bGQgaGF2ZSBiZWVuIGRlYWx0IHdpdGguIEl0 J3MgdGhlIHNhZCByZWFsaXR5DQo+IHRoYXQgaW4gZWZmZWN0IHRoaXMgb2Z0ZW4gbWVhbnMgUkZD cyB3b24ndCBiZSBsb29rZWQgYXQgYXQgYWxsLiBPbmUgb2YNCj4gdGhlIG1hbnkgdW5mb3J0dW5h dGUgZWZmZWN0cyBvZiBvdXIgbGltaXRlZCByZXZpZXcgYmFuZHdpZHRoLg0KDQpJIGZ1bGx5IGFn cmVlIHdpdGggeW91IG9uIHRoYXQsIGFuZCB0byBiZSBob25lc3QgSSB0aGluayB5b3UgaGF2ZSBh bHJlYWR5DQpCZWVuIHJlYWxseSBhY3RpdmUgaW4gcmVzcG9uZGluZyBhbmQgcmV2aWV3aW5nIHNl cmllcy4gDQoNCkp1c3QgdG8gY2xhcmlmeSB0aGUgcHVycG9zZSBvZiBtZSBzZW5kaW5nIHRoZXNl IHJlbWluZGVyIGVtYWlscywgZnJvbSBteQ0KcGVyc3BlY3RpdmUsIHRob3NlIGVtYWlscyBhcmUg c2ltcGx5IGZvciB1cyB0byBub3QgZm9yZ2V0IHRoZXNlIHNlcmllcyAoYW5kDQphbHNvIG9uZSBv ZiB0aGUgcmVzcG9uc2liaWxpdGllcyBvZiBtZSBiZWluZyBhIHJlbGVhc2UgbWFuYWdlcikgaW5z dGVhZCBvZg0KcHVzaGluZyBhdXRob3JzL21haW50YWluZXJzIGFuZCBtYWtpbmcgdGhlbSBmZWVs IHN0cmVzc2Z1bCAtIEkgd2lsbCB0cnkgdG8NCnJlcGhyYXNlIGZvciBiZXR0ZXIgd29yZGluZyBp ZiBteSBwcmV2aW91c2x5IGVtYWlscyBtYWtlIHBlb3BsZSB0aGluayBpbg0KdGhpcyB3YXkuDQoN CktpbmQgcmVnYXJkcywNCkhlbnJ5DQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:32:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:32:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362056.591918 (Exim 4.92) (envelope-from ) id 1o91O5-0003yl-2D; Wed, 06 Jul 2022 09:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362056.591918; Wed, 06 Jul 2022 09:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91O4-0003ye-Up; Wed, 06 Jul 2022 09:32:00 +0000 Received: by outflank-mailman (input) for mailman id 362056; Wed, 06 Jul 2022 09:31:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91O3-0003yT-By for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:31:59 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30081.outbound.protection.outlook.com [40.107.3.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7b00b74b-fd0e-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:31:58 +0200 (CEST) Received: from AS9PR05CA0057.eurprd05.prod.outlook.com (2603:10a6:20b:489::35) by VE1PR08MB5853.eurprd08.prod.outlook.com (2603:10a6:800:1a5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 6 Jul 2022 09:31:55 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::99) by AS9PR05CA0057.outlook.office365.com (2603:10a6:20b:489::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Wed, 6 Jul 2022 09:31:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:31:53 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Wed, 06 Jul 2022 09:31:52 +0000 Received: from f06b5ce9ab52.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0B5F325F-476F-46BE-BCC4-9458451A6873.1; Wed, 06 Jul 2022 09:31:46 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f06b5ce9ab52.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 09:31:46 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by PA4PR08MB6223.eurprd08.prod.outlook.com (2603:10a6:102:e8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 09:31:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 09:31:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7b00b74b-fd0e-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WQrIWINJZBQnJ9iK9xziXyfl0xebvVAfLe5uYDWhPNqgnJbrDAKfkxBtPl+nP3v+ZYa3l3Dwjmi4SdXpuhlt5/CyBGzFdFc182tnW9HA/K1Qlv7z8un3Tl0OKJDJ50bsrKevRGNLeMKK976+yTnSvYO2x1i5FIWCB2Hoi0oqD+q2gUG7aXjZk9y6sdhjOA6+ZF69qr0BsQPCnc6wF3CyfCn4ADlH5RDmZABYCImYwrRHYUL2vkrDvx04BCmidSUvZvFAsLWI9EBMzuqXVpEfkq+aLz68hk3OMtdZ0e3H5Te+DVQIg/HcgjsdJgWDDA6KcpDwCJm1vTRudCB2RXLrWg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=22ugatgv8nquhOB/unRC+y5p5HIkbMis6iMPszAY0Is=; b=WnnmxJb56tI4zDd16yHTYVpzAr1Kf9/T0Jg4lPJeguWMjLi5ncp7jOKpRYk8aEmPgnGKLKbUUxRhLsroALIpdk2CqUNBMkBkFkNJfDX2OxYNuLF1EJcBVHK+4kbxeWPPCDV5SRyvdE5QBXr1JccKMifdejt6q5evYxpqzFr2W8NJi3SNvXmeiTF2xBt5RGat3n3Ml72Mg7KJWLUdZd2436+DlkQZPDP/WCAWw0nrBq98bHaePkiR6Y5jUY2hNtVlgrrkVnlC/j9wmK7WeIua7db8LpDh1Itw0yr9PD/50MYnkWQYKiahNL2bUvUZZ0r0bvlYQ4VIojbkFv+lajd9Pw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22ugatgv8nquhOB/unRC+y5p5HIkbMis6iMPszAY0Is=; b=bZelORMLlmR9OYugQDiyQecXkgYZar2OX2Rfm5yND2gyPrHexwe5hQaNMcG+t8hJu4r/0WtQejhB5pjKeekE8wSlZqwSY/NpyERlMICIuBxXietOuMf6fCgJqgYPSfGASXLA/+PZ+YOjjdFbj4gAWzUq9fu6zfUhDLgKHJm1aDQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kQ4L5TCK7irSpO7Zm+Xy1hY8t+yX+VaD2bhphCoOQIxF8itti/KxijlLwSlvBGLBz9dVH8gxT4KIYhPhaLC0k0TQ7EDiaXw9Nhv5sA2MqHycpyUl/ToVh98rtLOAHAlII5K18sasfyf+/+i/QmvslB81FAam5ynb22kBJwuXoaMmOF9zmzDuN6BL/JMBlp0iGppv/nu8FkRTElK9g3cc9yZMfNmGbBz6DzTAjQwncOPl38WdgmBcDhbo6o46N/Ju8wXU3fJaqQlvJxs67cHHgC9DBt0bSWueki5bnv+V9wQB2+ObORqKfULVs+1oJvBAkbaiayVYozEbF97jxyyAUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=22ugatgv8nquhOB/unRC+y5p5HIkbMis6iMPszAY0Is=; b=AfIrtHMTd1Gib35qvW1XYPMRmh4vCU65ycYtIaoTiZD2gUBPMGKbl6qZ/o22Xgg+Pj6X9+OoqnrulwhzEEz5yC1vsdphzXBquavy+7sgjbHq+V9evmZdYlnlPwBxx+4YidgoMzS85dO9JPOgIESup2ZkCRCRRO8L7BciQiD2QA5uJ1YVi64pnJdVP0FKAKcn1L4O1g/QysxKryxsEnA6rCG4ZJcLJy3CpQcID+PxRqZB+FiiiFM8meYIjq4veIe4o7npraUZsuuJO8QhYDLKAZtpWo09063o2DWwkWMeF1vKAkjA9oBGPNdu4rR2oYMrvRIcDBNEIwTg+ADLoZFARA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22ugatgv8nquhOB/unRC+y5p5HIkbMis6iMPszAY0Is=; b=bZelORMLlmR9OYugQDiyQecXkgYZar2OX2Rfm5yND2gyPrHexwe5hQaNMcG+t8hJu4r/0WtQejhB5pjKeekE8wSlZqwSY/NpyERlMICIuBxXietOuMf6fCgJqgYPSfGASXLA/+PZ+YOjjdFbj4gAWzUq9fu6zfUhDLgKHJm1aDQ= From: Henry Wang To: Jan Beulich CC: Andrew Cooper , Wei Liu , Paul Durrant , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH] iommu: add preemption support to iommu_{un,}map() Thread-Topic: [PATCH] iommu: add preemption support to iommu_{un,}map() Thread-Index: AQHYfKTqlNAQrdLOhUWuhz9XAirPe61xGNzwgAAcjwCAAAbb8A== Date: Wed, 6 Jul 2022 09:31:44 +0000 Message-ID: References: <20220610083248.25800-1-roger.pau@citrix.com> <2377d0fc-1234-56af-fdef-935bdf8322a3@suse.com> In-Reply-To: <2377d0fc-1234-56af-fdef-935bdf8322a3@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: E55B6877E7C26D4DAF347E3A247E92E5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1d704e63-b449-4f99-5823-08da5f325cb9 x-ms-traffictypediagnostic: PA4PR08MB6223:EE_|AM5EUR03FT014:EE_|VE1PR08MB5853:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oRr8c2qMjmglGnhg8JA0peMlNUANdYoFzfkBLjwk9ulgqFE3+CrZQXRvfPvaMKNMMbhIA2uOV46r7GlCvTRnjyooYQ9/es4+5MJsRyQREmSYNPMbVaB0xtDUIl7ihjlkD6sIiPaGBWExFgqQ/fLMay5mzTZ/lwqT5q49KXg8raitV0SEzMCjW5K6nt92gxyX/3s9Sfg5dzolbXMSSIBugejavnI3apaRR088QzcqNrpx3OMFSXoNRBlnUm6Y/Fk0gIGWdjojyy+IYfKXXnyrxOuAckTWOfi/G9dj6rzV3gUchZ9MzfxoOd+qDGtN6KQlcmTb3u2glsx7d5JFiO8j74g7ynelRaGpyecqtm2qy4sb7IEya5qhwVSEeb7pj4wbTNQCfKNuttA74yrNVROiHxja16belVwqw4LN1jtExIBFTsOb3pB/4+qhRK9cTxapE8OHMvr6aDD8i/IBNUKJbdeOUlhUewrkOHjgYOz4kEMoaROsCYrWYTFAuTFJD+T8kftDHXenZajmQseE4QgAo50ersBbOx7J0AzKOh0WubaLpnwdzgwD+T9xZbrVzsvbZly1UIXDN9f9DhN13dQyLe+Sp9mGfKyHiqynTqM8dg8QfVCoMHenQHE84HGTJ0pC5ZMZCrPn4D9Ac2Wc3sAW22rqwOmJUZTB7Jm1Mt0iUk8UAtbobwZSCu5uFiYnQbuuN/Sy2jknAo3g64aVHo1qsI5Wct0MfsKkWjRJ5rn1EgnjbJi0YUXQgnb5TX2JMV38sZdUEq5K3up6lHYstzbNNqCYVqKdehTMP/Xs6orniMn4BCyTzVezBiAfgLZFdcMibCKCcz9oQyp4Kmw8ULE4fA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(478600001)(38100700002)(966005)(71200400001)(186003)(2906002)(7696005)(6506007)(41300700001)(53546011)(33656002)(66556008)(54906003)(6916009)(122000001)(316002)(8936002)(5660300002)(86362001)(4744005)(38070700005)(52536014)(26005)(9686003)(4326008)(83380400001)(55016003)(66946007)(66476007)(66446008)(64756008)(76116006)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6223 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7a2e6287-c696-44cd-0401-08da5f32576e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UPJNrf9O+f08Ets29J8pXx7P6X5cMQPcDVXAzyA7WRYM6YZLrWT+pX3ysLrUD1bVL/OuVIOnr0RB7DGHBXKYbUId6nrMG3MKFgh64JTmnT3sronPCW2+U7jPv2Bh8C6d1ejRhnzIcSrpXofe6B/KZ6XRPeAX7Iak1imRQ9kN+XRkzaZhzf0TfKSXOLWqZHGn8+1lxNhmqBnxZT5dUOBsgENozZoJ2xHbruWkcbJd2hvNH2l++sVxXycTwgOF8umLEWr/yH7qGZdDE+4SLaYl+cJ909EpZn2y3giHVn+QCy32HLSlqFe4z5p4A3Sulm1qU8W/MmwZG/T63ZXgN3L434cpA9SKGmr1N7qPthzVMkzYMUkFbqARABN9eRFbEkPEtcOkzrYb0rjPVITrE76ALHYf8Ko4ZIh9hZnJibdUCmKAEy4WboaAof1qd/kcELz6RWblVkzZ9TN9PXsh3Ww4/CokChhes9NU2u5jIFlsM/5DSduG/rAe8YQWywnBFh+OoRwqqL2sPdhSsIfuY5oYuKOrLGVEKqOF4I0W0eHm655jdMnEoLEcXShtgWczVmtL8f00e5I2nKIks9qMwf8ydAxsnsAtEx6ChXVax33RQAkYb/+jXpIVBqBUmYO8mzu3aBZsPMNyVMBM0wGOv6JP+RCk9UArRbs+OJq9iAfkzebEfAbFlzYqoqEmJAk0ILZ3wkPJOia8Zd4210okMGtDD8Zz2Cpb0GHufKJdc0GlvyaRYGjjNRPubHD8ca19CR7roaYs69vWENEQbOqNWopbrhY902nPIYPQd79NElYTBf3wDt0flVbp93Jq9tLt676OYqiSsWct4U0q6iFr1MJE6psQ/k8vVIW85liqiLv1PkE= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(46966006)(40470700004)(36840700001)(7696005)(6506007)(356005)(81166007)(40480700001)(54906003)(53546011)(36860700001)(316002)(86362001)(82740400003)(55016003)(82310400005)(2906002)(4744005)(8676002)(83380400001)(41300700001)(4326008)(966005)(5660300002)(336012)(9686003)(47076005)(26005)(70206006)(70586007)(40460700003)(186003)(33656002)(8936002)(6862004)(52536014)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:31:53.4375 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1d704e63-b449-4f99-5823-08da5f325cb9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5853 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gaW9tbXU6IGFk ZCBwcmVlbXB0aW9uIHN1cHBvcnQgdG8gaW9tbXVfe3VuLH1tYXAoKQ0KPiANCj4gT24gMDYuMDcu MjAyMiAwOTozMSwgSGVucnkgV2FuZyB3cm90ZToNCj4gPiBJdCBzZWVtcyB0aGF0IHRoaXMgcGF0 Y2ggaGFzIGJlZW4gc3RhbGUgZm9yIGEgbW9udGgsIHdpdGggYWN0aW9ucyBuZWVkZWQNCj4gPiBm cm9tIHRoZSBhdXRob3IuIFNvIHNlbmRpbmcgdGhpcyBlbWFpbCBhcyBhIGdlbnRsZSByZW1pbmRl ci4gVGhhbmtzIQ0KPiANCj4gVGhlcmUncyBubyBhY3Rpb24gbmVlZGVkIGhlcmUgZnJvbSB0aGUg YXV0aG9yLiBTZWUNCj4gaHR0cHM6Ly9saXN0cy54ZW4ub3JnL2FyY2hpdmVzL2h0bWwveGVuLWRl dmVsLzIwMjItMDcvbXNnMDAxNjYuaHRtbA0KDQpJbmRlZWQsIHNvcnJ5IGFib3V0IG1pc3Npbmcg dGhpcyBpbmZvcm1hdGlvbi4gSSB0aGluayBJIG5lZWQgdG8gZW5oYW5jZSB0aGUNCnRvb2wgaW5z dGVhZCBvZiBtZXJlbHkgcmVseWluZyBvbiBwYXRjaHdvcmsuDQoNCktpbmQgcmVnYXJkcywNCkhl bnJ5DQoNCj4gDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 09:36:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 09:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362062.591929 (Exim 4.92) (envelope-from ) id 1o91S3-0004Za-I2; Wed, 06 Jul 2022 09:36:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362062.591929; Wed, 06 Jul 2022 09:36:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91S3-0004ZT-FB; Wed, 06 Jul 2022 09:36:07 +0000 Received: by outflank-mailman (input) for mailman id 362062; Wed, 06 Jul 2022 09:36:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91S2-0004ZN-9w for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:36:06 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10083.outbound.protection.outlook.com [40.107.1.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0e5190b7-fd0f-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:36:05 +0200 (CEST) Received: from AM6P191CA0045.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::22) by AM8PR08MB5650.eurprd08.prod.outlook.com (2603:10a6:20b:1d3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 09:36:02 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::21) by AM6P191CA0045.outlook.office365.com (2603:10a6:209:7f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:36:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 09:36:01 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 09:36:01 +0000 Received: from bd47dad8d79b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id ECBDA9B6-A812-4D98-8161-1740A2C1C4EC.1; Wed, 06 Jul 2022 09:35:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bd47dad8d79b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 09:35:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB7251.eurprd08.prod.outlook.com (2603:10a6:20b:342::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 09:35:54 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Wed, 6 Jul 2022 09:35:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e5190b7-fd0f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NEUURPcllllkfJTgehoRXSssmNSkElLAfrCT1MgHGWYAlOz05ylF5nuw1UxGvxxOHKKIRCCm5wezPfHcm9EAWMaLMFZoXGspyMalLTU4KIDQJUxXZJuZpcMoog8pOsRJndS3D02V0JbmLVQUnLq8LrTOcnl3l+FcHP/rKFrxN0cltQ+qAUygFpKLDAhkUQHXk0jA6kGYxYQdDgr7Pqgg7I3eIK0c9s5UtN6SqWQknxG2TgzjF6peV7bxUH6LnwyS6aZwD3Oz+Rg3J1i6T03dNhdgP7Sxdu5MCMxd04A4FtS/pQ5LF/mSCjDncU10teqhGbuZGC/2DYNOnEqutz9CNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3P5H9mviKLgVgThjr6sBpWT7u2I0flykxD933JykIOo=; b=ACXivyDJF6lYaZXxIzIyEPUMqcsOpc5WH9L6QILB5p64Q70bNtQuGCOes900N21ndkjz2Q/CH0A00IZ2PhWnBmOYo1FRaPanLl8fLkGQBvuYmV8Hr9/eY0ApU/dRDg1HxtYGtdm+aflzEzeNKkW0Zwa0uhIcGbfbjtUzUZYokEegJq3miqW2zvr4SWcVtwbhTlrvXXnDqnJpMzvj+fMOt19VCjpWwOF+7O1MrAMZpTSjJz4sgx1b6LDsTHpEYsSGH9Wm3UprbMf1ZPCtE5MuUJdlrQLGV70240FKu72tDJk5FudJtbidv1aNHOqrMyutpDXBDM+ICI8ZZ3qA79vXbQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3P5H9mviKLgVgThjr6sBpWT7u2I0flykxD933JykIOo=; b=D+5/YCBtguQ/ufSLg0BNzb5oMiwqFVnyyGOpjp+aVFe1gD2CTUErwy0DXSsw2Pcq4lMQj33t7PbUUXrHn1VHysD9JoAUDa6eduzjx8owK+l+IRvLx569fV9bPrD/RYwPRCKWzNyi0TCI4hYlFZMSW6zWVGAZ/xLG9EGtbAzovEE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XcjZXJN7uxCPiJ0Hx91nNhtmVFTk8RTVkDCCFUswz+b1kLrto9sGMERITlXMKmLhircrc8xyr2qD0jFxOq6WbKN51seJlea5tL6MwsaB0gtZQYOwxhUN5X/C9FsIbVHLnwmZ50CWkeI27RW8iYHAzSNA0IYFwsR1P8twxjfAEMXCuW2PGPBF6MEFjbI1SLs922Ie0dW682EO3278I8CgEXCt288yaZFYsyU5vHYpd5ZxCbmzzHUTWFh+kUfvOnetc4nwTVS7VNt09A/aobMzb/4DGtmj8JDJe0bJtT3h2VIuXhVcNCF4E6qOc+fPwhme0+oOCIisXCy/mzkEYovkDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3P5H9mviKLgVgThjr6sBpWT7u2I0flykxD933JykIOo=; b=A8HQOlvsg6FhYpAM2AOJSLKk4UU+0wntbMJDigyguiRM/u3rAdqkvZ80mWUcHCS+algueI6PJvMITyEWXWgFehxSmb3VRM+dDips4fUBlC5CfaGIhnFWoJgdPayeOY3hkpVIUkl3jUx4Y1g9IE+n1T1jgSD1lVRH30D8CcHA0mZnQYzk9xUxjrID9aLN+9D2u9NfWDJqKTYFX5DVmcDsXplZt5cokbhZJE0S1vPRKM7S7XcKSzNOKB886WJ5QSeQ/O+93X+mE3B+KBhu5lJscyV/KHneI/U1ZuchudV/FFZgdnup2mcg7AW6YuCBezNewQbUfdBU8fAeCzdQ/cV4dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3P5H9mviKLgVgThjr6sBpWT7u2I0flykxD933JykIOo=; b=D+5/YCBtguQ/ufSLg0BNzb5oMiwqFVnyyGOpjp+aVFe1gD2CTUErwy0DXSsw2Pcq4lMQj33t7PbUUXrHn1VHysD9JoAUDa6eduzjx8owK+l+IRvLx569fV9bPrD/RYwPRCKWzNyi0TCI4hYlFZMSW6zWVGAZ/xLG9EGtbAzovEE= From: Henry Wang To: Jan Beulich , Andrew Cooper , "christopher.w.clark@gmail.com" CC: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Juergen Gross , George Dunlap , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v6 0/9] xen: drop hypercall function tables Thread-Topic: [PATCH v6 0/9] xen: drop hypercall function tables Thread-Index: AQHYP4flEN1TZgxxxkSZpjQ9KWhqIa1xiooggAAjX4CAAAmFgA== Date: Wed, 6 Jul 2022 09:35:53 +0000 Message-ID: References: <20220324140139.5899-1-jgross@suse.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: EAE55572CA91B2478B8847F322806A0E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b5e5f64c-d9ce-4a04-2300-08da5f32f0d2 x-ms-traffictypediagnostic: AS8PR08MB7251:EE_|AM5EUR03FT007:EE_|AM8PR08MB5650:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GmJOBkbPUj5YNYF90pZ0sxbtFiQJ8BTxHkGlWszPnCfjPXlHZMYbHavt/Pdi11kGNrbFsG0CjgxjQlObIVIRdUTQVdMdt/QSg9HWo2DwTw6mllWvh/bofcq+wiFKV4RNcwx6zIB0xzVcvPLgBNbbJs9XIteQi2qzXldXD3+/uHituQyR3O5kp4B0FqH8eayd3VF9jQqSGFtkR+5Pd0YBoJa/WB2K/q1UPOkjAfPGSowSrrBygEdtqsY4LXgJJ1hEcq1iDe6xyHV4v2QsrLvPzWDJedAf0qvXDg7qvt9hgW609Ctv08dU8LuPLv5FkY66zADQi/r/W16sO+u24+nIjFHIOZJR3ct1hEYNL6QBn7f/A8UBrRHkAeqxSoNLt/X0Xi7ZUS7/wbe+YpeSU7iqZitTeqqtvuD7XHUnV1oF+Mwbsci1zaHY4zklsy11O4IIOsw7PLUR6+CZt1X3BG1r4xxthHP51vYJ8pNf2LeXXDEKKYMJllHA9egYGZVoxN6uVWSePZLhOB1qOw1NsbIfX9gpjgsWc+Un0WTMDaXgsFVVPZd7yIXBmLFWIl6foGyRoNHjEqotKC+tVRYTHV/CEEwyHOzEuoG74xLilp7Ln1fxJgmtM0/0CHm34VHMyXbjzOO5fcJMVmbCuQH1qsHNL7zFV7MeDCetOft50GL0+Kf7HuBGzOQMTlurpHpPi+W/OnMyNoVFcIxMM5ud68ra0yLlFmC/5G5ZkVsVo0wOhuTbS+Ilbunb/n7jNJbMfGFrnJBByI+Q2PyB/epN9Kp7ZPXMOm5DX3C5TtW/nGFopBY7piDVpTBLNlP2/S3LYpUk X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(38100700002)(122000001)(2906002)(38070700005)(478600001)(54906003)(186003)(83380400001)(66574015)(7416002)(5660300002)(4744005)(33656002)(52536014)(8936002)(66556008)(66476007)(71200400001)(41300700001)(55016003)(86362001)(53546011)(6506007)(66946007)(8676002)(4326008)(64756008)(7696005)(76116006)(316002)(26005)(66446008)(110136005)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7251 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 125893ac-436c-468f-bae1-08da5f32ebf6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xzo9GejShu3PPJmbPrsLkowq+mqFvoeuI5V5Lgk012SP4IJOECjpeuJStAOHrM+DWqa5XHtxqQlij+OOGe6OP0L2dBBdnlc96hNHxH3qlDsS6WzDS1MJ5lnayALtNaq5aRumNsIDwgjF+Cc1xAuaqKuwCEtBA3r35pljy1ssH9iUX1oIJy/HXp7uteJ0tCxckLCN6ET94sDmu/7YzXqDM9xqoDrlK/wAcvBAKfEJiUW1QPXqGi/+8KeHHDj1/4RT5+BNLrEB0+ADkWhGdSDeR7729PPyKK0xfZ8gstIqu3KXPIyPnBz5GbLljPjPS9uTfL/8eFfVD97wSOIrxgqEgBWoLyxs+BMSIan3oZ9U0lVi812LFFi62G/UlQzLyHInIJYYyV0AX1qWc0H9/GeARf+ECoqMiWzM1oQNGaBXanzbm7ckPY+SFESgqQ+ZpnlWh/OJcdYj1l9j9yoGfw/fjNIjEXE0xborTIoeFO4g11xNcW8L1ITNtEoWu3NQf+rEduTEhBC6kjhQKezDpkqAWtmKZrlcsmL20dQ6YUz/JsdJeK5jYURbtESYbkpBPsmU75u1qltUXtopcY5H62ZvC+1UjvIh3SB5jdFk0c/ddIIB3GCUJ87T4SamfzuHbZPaErUOJ8gRlWljuWhCWwyj5MvT6l5xhVT+4AeqvwGc/+VsAB+zByDOyTanLXj8Vjqxmvmf9C6l+rvNFn1OngIQOxx+HcLye3o5PvAt/BTzyz8/28zy6O0eX6wza+ips/m5n5+ZtIabWq6conwRHIhgknlJwR200xJvgTRVU0349s+0FMhszjK1leJxscdYgrXg X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(39860400002)(40470700004)(36840700001)(46966006)(26005)(186003)(82740400003)(6506007)(7696005)(356005)(54906003)(5660300002)(9686003)(4326008)(8676002)(66574015)(47076005)(70206006)(70586007)(8936002)(41300700001)(316002)(33656002)(336012)(52536014)(83380400001)(36860700001)(110136005)(4744005)(40480700001)(81166007)(82310400005)(53546011)(55016003)(2906002)(86362001)(478600001)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 09:36:01.9028 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5e5f64c-d9ce-4a04-2300-08da5f32f0d2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB5650 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwLzldIHhl bjogZHJvcCBoeXBlcmNhbGwgZnVuY3Rpb24gdGFibGVzDQo+IA0KPiBPbiAwNi4wNy4yMDIyIDA5 OjMwLCBIZW5yeSBXYW5nIHdyb3RlOg0KPiA+IEl0IHNlZW1zIHRoYXQgdGhpcyBzZXJpZXMgaGFz IGJlZW4gc3RhbGUgZm9yIG1vcmUgdGhhbiAzIG1vbnRocywgd2l0aDoNCj4gPg0KPiA+IFBhdGNo ICMxIG1lcmdlZC4NCj4gPiBQYXRjaCAjMiBuZWVkIGZlZWRiYWNrIHJlZ2FyZGluZyB0aGUga2V4 ZWMgYW5kIGFyZ28gY2hhbmdlcy4NCj4gPiBQYXRjaCAjMyAjNCAjNSAjNiAjNyAjOCAjOSByZXZp ZXdlZC9hY2tlZC4NCj4gPg0KPiA+IFNvIHNlbmRpbmcgdGhpcyBhcyBhIGdlbnRsZSByZW1pbmRl ciBmb3Iga2V4ZWMgYW5kIGFyZ28gbWFpbnRhaW5lcnMuDQo+IA0KPiBQYXRjaCAzIHdhcyBhbHNv IG1lcmdlZC4gUGF0Y2ggMiBhbmQgNCBpbmRlZWQgb25seSB3YWl0IGZvciBzYWlkIGFja3MuDQo+ IFBhdGNoZXMgNSBhbmQgb253YXJkcyBhcmUgcGVuZGluZyBhIGNsYXJpZmljYXRpb24gYnkgQW5k cmV3IGFzIHRvDQo+IHBlcmZvcm1hbmNlIGNvbmNlcm5zIGhlIGhhZCB2b2ljZWQuIErDvHJnZW4g ZGlkIHNlbmQgYSBudW1iZXIgb2YgcGluZ3MsDQo+IHdpdGggbm8gcmVzdWx0IGF0IGFsbC4NCg0K VGhhbmtzIGZvciB0aGUgaW5mb3JtYXRpb24sIGxldCBtZSBqdXN0IHB1dCBBbmRyZXcgKGZvciBr ZXhlYyBhbmQgUGF0Y2ggZnJvbQ0KIzUpIGFuZCBDaHJpc3RvcGhlciAoZm9yIGFyZ28pIGluIHRo ZSBUTzogbGlzdCB0byBzZWUgaWYgdGhleSBjYW4gcmVjZWl2ZSB0aGUgcGluZy4NCg0KS2luZCBy ZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:01:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:01:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362070.591940 (Exim 4.92) (envelope-from ) id 1o91q1-0008VC-OR; Wed, 06 Jul 2022 10:00:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362070.591940; Wed, 06 Jul 2022 10:00:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91q1-0008V5-LH; Wed, 06 Jul 2022 10:00:53 +0000 Received: by outflank-mailman (input) for mailman id 362070; Wed, 06 Jul 2022 09:46:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o91cQ-0006P7-TR for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 09:46:50 +0000 Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8dc7dca4-fd10-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 11:46:49 +0200 (CEST) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-10c0430e27dso9213925fac.4 for ; Wed, 06 Jul 2022 02:46:49 -0700 (PDT) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com. [209.85.210.52]) by smtp.gmail.com with ESMTPSA id u14-20020a056830230e00b00616c46f6daasm13153869ote.31.2022.07.06.02.46.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jul 2022 02:46:47 -0700 (PDT) Received: by mail-ot1-f52.google.com with SMTP id t26-20020a9d775a000000b006168f7563daso11475811otl.2 for ; Wed, 06 Jul 2022 02:46:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8dc7dca4-fd10-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=o8jOPstF035V3JBIGTjyEra8xnCZ4RAIho4NrHeIzoU=; b=kL4FALhvVXRC8PPK9GQSHb6XiRKFY/q/+R5RqlyBu39wH9vq3+CesPkY5umUMXh8le aaljtL0nhQOAoLu/ysiFdqTMyrvo0Tw/OCebQXSYd8+a1y+DI0IGY5E8b5YYVLFhxghb mElC6GbOOfoJumzSB/TAFDoOScBOXckRL76nevZVakcVbUQ/upavuH6XoTurvocnU9A8 kRPRUxTN/Yum69bgEoLoFo4rMW+kC2wypyMayWQ5OjHws7/tFDP7eGom5POGrs8f6P+9 xOEr+uoNONXKuU3tU/TrcuS8SoK9XtvFGHcOlxUw0vx335LMB3NE5X+g6X5WydJLTZcW 1yPA== X-Gm-Message-State: AJIora8YNKafhigM4+dbnIRoYTEWKcNJd+sqx7Ap3mBiWg2cxEdAA3dZ Y+S9p/hvniy5GopgHsnlwRifCaZfrA0g8w== X-Google-Smtp-Source: AGRyM1sP+pQjVx1jujy3oBX5gC1ME2n7dwyTo3wzNJGCrEmQrOAAKYf8JM+DX88UnSe6LKDbAtFpzA== X-Received: by 2002:a05:6870:51cb:b0:fb:5c97:bd1b with SMTP id b11-20020a05687051cb00b000fb5c97bd1bmr23764553oaj.104.1657100808029; Wed, 06 Jul 2022 02:46:48 -0700 (PDT) X-Received: by 2002:a05:6902:50e:b0:66e:7f55:7a66 with SMTP id x14-20020a056902050e00b0066e7f557a66mr6648581ybs.365.1657100796735; Wed, 06 Jul 2022 02:46:36 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144517.124597382@infradead.org> In-Reply-To: <20220608144517.124597382@infradead.org> From: Geert Uytterhoeven Date: Wed, 6 Jul 2022 11:46:25 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 19/36] objtool/idle: Validate __cpuidle code as noinstr To: Peter Zijlstra Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Hans Ulli Kroll , Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , NXP Linux Team , tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@hansenpartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:46 PM Peter Zijlstra wrote: > Idle code is very like entry code in that RCU isn't available. As > such, add a little validation. > > Signed-off-by: Peter Zijlstra (Intel) > arch/m68k/kernel/vmlinux-nommu.lds | 1 - > arch/m68k/kernel/vmlinux-std.lds | 1 - > arch/m68k/kernel/vmlinux-sun3.lds | 1 - FWIW Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:33:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:33:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362081.591957 (Exim 4.92) (envelope-from ) id 1o92L2-0004MZ-Bd; Wed, 06 Jul 2022 10:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362081.591957; Wed, 06 Jul 2022 10:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92L2-0004MS-6y; Wed, 06 Jul 2022 10:32:56 +0000 Received: by outflank-mailman (input) for mailman id 362081; Wed, 06 Jul 2022 10:32:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92L0-0004MM-3p for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:32:54 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20076.outbound.protection.outlook.com [40.107.2.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fca5dabe-fd16-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 12:32:51 +0200 (CEST) Received: from AM6PR10CA0104.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::45) by VI1PR08MB3582.eurprd08.prod.outlook.com (2603:10a6:803:89::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 10:32:49 +0000 Received: from VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::5e) by AM6PR10CA0104.outlook.office365.com (2603:10a6:209:8c::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 10:32:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT051.mail.protection.outlook.com (10.152.19.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 10:32:47 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Wed, 06 Jul 2022 10:32:46 +0000 Received: from 724a72532bf1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7B3E2D5B-909C-4C11-A33E-29BE947A8DA9.1; Wed, 06 Jul 2022 10:32:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 724a72532bf1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 10:32:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AS8PR08MB6005.eurprd08.prod.outlook.com (2603:10a6:20b:298::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 10:32:37 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 10:32:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fca5dabe-fd16-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Vov7YWrvge1ETXiSwZk0RNJ4SfJuAFC2onFT6BBlYdpGf0EIHHRQjpfYe+Lob+x/aFh0HqH/soaW3zK1lcs/DqQQIpswI7HWQ+9Dhe6+BLbyQiwWrzm+ArLtAeWMrdIzeXrcgkNQjhQi7kAo2+HQk4Xw7axxw0h+zNo9/YBW2d/3r/gLZjjxkrFjUW8sMDpa8nbNH6vHMnDJPJTOfcEOhQjlDpwZKMgf63fo+uXrFMDBHDduRafZ3CXh5utN3wf8NN49ZqH2OBb+evHtcqLEkg+/u1JXBqnqj7KKjjDw3HOS+OSYzAqMTxMkz6xloHnREHP7GcoWqh9fPJPOkpmAOA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a99kn8cDTGVaet3F/2ejtPnP0eRvnXZXSgpfklhkZ9k=; b=jibxyfhpnuAcbIoB1DJS1MAj63LA/RzWIOa8ZaczSsDZa/M7CfllKggr/jpHS1UUN96m1KtQWh0x2Gra5XtLeMLDMMTZcDQ2DbH1Ohm5QZb3gSzIg61Mgw6mCKPal+9DdSNIWAfVht7ZMxkixXQwnH1QgNWJJTkteR7Q6/PRrRbEI95eQv/sAss/WVULIIZu9U/5TuXnpUB1waa9J8Jd3W28k0RJ0Jgfqb1mvZ5odDCtVMUz0qFObKEcH3fJMRdPTQ49gzS7w3QIrBns1Lxvb/VPDEhuAnIMmhgML7ORn4pvzzjIWpuXcFU5mAemFYyyiIBPFnuq8T2Te9dsIKF2EA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a99kn8cDTGVaet3F/2ejtPnP0eRvnXZXSgpfklhkZ9k=; b=J7+zeIbnzPI+CiulVvI9kMG3LYbpGMhL6SSJrPKmNmbPg4S9w/hV8ZHzZhcpXDz/RlnYYUFzlfSs0JEK49IF/1fJkA8KJbDWSSV2d3Z4ifvQGkiQ78N+d8PnHjmGNwKZvNcT6ZcoQtYLVhVqQIO0FqGwhr+WgUWptJDemsZ4yBA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 79a98e931a455a49 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LXbH3E4JfecQSzpTM843Ntt2Lz5qk8S0YdD3cfFjIrgY0oET0RuYQYTOigBUL1ylElppQ97qlP03XxlEYNWbKX0fERFpPxD19+XoTt2cMXfgzo7XyWEKPIZBCCvVPHFOd64P+FuxFRQGGxvVmXETCbEC5qU8NeIh232dxLRaBm6b4674PJupdMsg86dB2JPIOkCjp26+FdeTOf570d+KZe1yahlOfXlYozsrgrnx6Jr13nPjvsAgtXPdsydBKl/rF5RY91nWFzBk72TJQ191rqmum4oDSH36n4L0h6aU26OEsMm5R3d+53t5VF6OhY1aglV92pQzZ3agnr0GzsoEbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a99kn8cDTGVaet3F/2ejtPnP0eRvnXZXSgpfklhkZ9k=; b=aGqL3N9vs5byiWUzMwyqdbTz2XKvBr0qQGr/OXyY+sOdY2kMqytu3oKoerzHY3ovqSr2+9JWSpPTHVK39dFB6oxgxKGxExXAoV7gp7aHTgWu5pM2AB3u8ccpLLt3czXwcyj+clauca5iFeTKlAqChSaGSjSXI0Y/jnCtL2Epmq5okHGWhPOBeol9+sGbiME1mtdhPc4PhBJN8351bcEYpq/QklGL/ddPfEznVSBHURHQLoXm+N86oGti3IwEwWhKxtoUX6LK2xQObta7MF3pfoJyrOI39Yk7GAcp/ubMvsWVuw6dI/enELzDhOQABryDUT5ZGjs/ifvSuz68Eu4FXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a99kn8cDTGVaet3F/2ejtPnP0eRvnXZXSgpfklhkZ9k=; b=J7+zeIbnzPI+CiulVvI9kMG3LYbpGMhL6SSJrPKmNmbPg4S9w/hV8ZHzZhcpXDz/RlnYYUFzlfSs0JEK49IF/1fJkA8KJbDWSSV2d3Z4ifvQGkiQ78N+d8PnHjmGNwKZvNcT6ZcoQtYLVhVqQIO0FqGwhr+WgUWptJDemsZ4yBA= From: Luca Fancellu To: Demi Marie Obenour CC: Xen-devel , Jan Beulich , Julien Grall Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Topic: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Index: AQHYh/bQ1tgd5TeBbEyn28hq3tAw6K1xN30A Date: Wed, 6 Jul 2022 10:32:37 +0000 Message-ID: <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> In-Reply-To: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 18707ed6-f19d-4712-7972-08da5f3adedb x-ms-traffictypediagnostic: AS8PR08MB6005:EE_|VE1EUR03FT051:EE_|VI1PR08MB3582:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tIDdMRpCrokXLFi+vP3L3Tfoyfko2gTJwuNoRAODLzkEE7MaJ5lW1I/zuqBBVHSnCR6sojLCFZm8ugE24ug9vOfpn0smVFLSN0OgFmP6qvH0v12JOsQYdl0U5aAcztX6Vcgi1HYoW0cec3SPASW7JqJyJoh0iz0r3SbCalaWouBqdSrh7mdabXQtl+92EFIh00taACG5ZxioQ8b8/+9HYFPZBiMDiqiUdSh8L+29MtOw3YwupFMbQ7PlQonUb2jnIYpzW5WCs/tY+dygOV7yTInooxddOtWkrmPqPmz7cYK7+OuoSfcQN/IULJ0Px5Zawk+huhKmge3EU2/3KLqxfzbfUojhZLJdLGbgo2hfvZ6x6v/fjr0IJb8bhM+/8988QdfsKl3LfvrN+FFgVTvyM4XS3d8YBXKTghPYAwEh95Vjdi8TA6WpCx3eQmSArEaP2vVPZHj+t6pxsYsjIdnciQWYJ70LTRbbncd1gBthDJj4f/5BOYSDBCx3BYsZsWCl8f4oaqNBtm6/nZIXYmCkjuxRU8FRsQlasoKdSCbeR9wr0TP759s4I19D8+D7wYrnoaaSmltltD0Htg1RlMIrjfm4TAsVZ0Gg1hefBz2d1PaMuOvt2smbjkdbyTi+e9MJPYWhh3PzZR8CtzSHu/iwz9r+TE5Z8Sz5h2yHh69NKhnA5+pLnb8lZTT8r+F5LhbCSHnEWv3O6GB3QNbwvJeSvb349R6KDCvtRjbm1PGfW1bkrMZSTpzd+qljpHC2OE/kHbmUtsiWDmQPfbPrQz5T3HJUnKd9uVeCLVDOU8pJbDAMFrwY+mKvvMm8TR5dC+6zh9aUUEASpP2jC1RZqwZ2sCC+3WvmNfW2pSSP7pI2lziiP/7Yl+DWJ7ykIaBVKYqP X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(346002)(136003)(478600001)(38100700002)(6486002)(966005)(71200400001)(186003)(2616005)(2906002)(6506007)(41300700001)(53546011)(36756003)(33656002)(66556008)(54906003)(6916009)(122000001)(316002)(8936002)(5660300002)(86362001)(38070700005)(6512007)(26005)(4326008)(83380400001)(66946007)(66476007)(66446008)(64756008)(76116006)(8676002)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6005 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b76fd222-9176-43a2-fb93-08da5f3ad8c7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QxQ6dDNcuKK12w3tYmfER3KAMZhMVfmK+VgmqVBao+cILtIXJyuq41CZSi6ymMcVfMfgODixzzg9vd/s0/waSneT2TaEVWVRVTtKL2iPsm9xjvCXeJvfPOTjEIObHzdMdm818ds2c1e8LlEInGk9OpV3291Iw68k90ApzXIt39xdEPfXGxemsmoAzJgXTjMOzvWsD6tc2z2oYy2K5OO0HODFpIZ5ugSW0Me8ZJaR7PQPqKCln1O4rchddn0l2oTpLA6UtSjxA6QX3X4TG3cqsydPqWJqkKmkf0rb+YsnM9hchOtj9mQ2m+TLKpANc8SD0wqqB/DdsC/g2O0CCtlMhECQgQbyFZIMwkezUT8oTSAlHoSp6RI2xzPFxSqz2WlsS2LwnMwhHDJeHgPspjOwmYMwL3Dhm7JnRS9PIOjgPiK4vTnI+C5Y0dOhkJXZBByqif4MwnJbu0Mu1yrPbydZ6NiX4LetX0q+53Jh6YC/cjKg2xRW3iCT+hO6+5mI3pztwyWAHR94imOXw6JymGOw308tEAvMBqJ0+8AlCzafYp29dtmciO2KHrmedISWvl8TU6XWBJCmc3BHEOoMMUqtUJG1okeMm5KRVHaNasgGfwIL1Y7lxl3pJ64X9azuERLZz7FHg4g+W6mfK42uOKPA+gthSErqHdwNUn8LYZsX8p5Go/Dpeah9geKHBH4kjnWwv0wCvIZ5/kqbaoPuNAHlKQfBRKTej5+1Jm3Q/DuHxPkp1bmnQqs04aqXpCbYO3pCFuQpPonI1ncdBd18OXKpY1F1fPXqj99oZVtVBPQe1YXHUNKDVH8c9bJZOlXfgZxgDEIWSXXo8wppszXAmtLqao7piY1Xw2W0wOfctZmu1bQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(346002)(40470700004)(46966006)(36840700001)(36860700001)(86362001)(2616005)(83380400001)(186003)(5660300002)(336012)(8936002)(356005)(36756003)(33656002)(82740400003)(81166007)(47076005)(6506007)(966005)(6486002)(478600001)(6862004)(54906003)(6512007)(41300700001)(53546011)(316002)(26005)(70586007)(2906002)(8676002)(4326008)(70206006)(82310400005)(40480700001)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:32:47.6631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18707ed6-f19d-4712-7972-08da5f3adedb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT051.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3582 DQorIENDIEp1bGllbiBHcmFsbA0KDQo+IE9uIDI0IEp1biAyMDIyLCBhdCAxOToxNywgRGVtaSBN YXJpZSBPYmVub3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+IHdyb3RlOg0KPiANCj4g VGhlIEVGSSBTeXN0ZW0gUmVzb3VyY2UgVGFibGUgKEVTUlQpIGlzIG5lY2Vzc2FyeSBmb3IgZnd1 cGQgdG8gaWRlbnRpZnkNCj4gZmlybXdhcmUgdXBkYXRlcyB0byBpbnN0YWxsLiAgQWNjb3JkaW5n IHRvIHRoZSBVRUZJIHNwZWNpZmljYXRpb24gwqcyMy40LA0KPiB0aGUgRVNSVCBzaGFsbCBiZSBz dG9yZWQgaW4gbWVtb3J5IG9mIHR5cGUgRWZpQm9vdFNlcnZpY2VzRGF0YS4gIEhvd2V2ZXIsDQo+ IG1lbW9yeSBvZiB0eXBlIEVmaUJvb3RTZXJ2aWNlc0RhdGEgaXMgY29uc2lkZXJlZCBnZW5lcmFs LXB1cnBvc2UgbWVtb3J5DQo+IGJ5IFhlbiwgc28gdGhlIEVTUlQgbmVlZHMgdG8gYmUgbW92ZWQg c29tZXdoZXJlIHdoZXJlIFhlbiB3aWxsIG5vdA0KPiBvdmVyd3JpdGUgaXQuICBDb3B5IHRoZSBF U1JUIHRvIG1lbW9yeSBvZiB0eXBlIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGEsDQo+IHdoaWNoIFhl biB3aWxsIG5vdCByZXVzZS4gIGRvbTAgY2FuIHVzZSB0aGUgRVNSVCBpZiAoYW5kIG9ubHkgaWYp IGl0IGlzDQo+IGluIG1lbW9yeSBvZiB0eXBlIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGEuDQo+IA0K PiBFYXJsaWVyIHZlcnNpb25zIG9mIHRoaXMgcGF0Y2ggcmVzZXJ2ZWQgdGhlIG1lbW9yeSBpbiB3 aGljaCB0aGUgRVNSVCB3YXMNCj4gbG9jYXRlZC4gIFRoaXMgY3JlYXRlZCBhd2t3YXJkIGFsaWdu bWVudCBwcm9ibGVtcywgYW5kIHJlcXVpcmVkIGVpdGhlcg0KPiBzcGxpdHRpbmcgdGhlIEU4MjAg dGFibGUgb3Igd2FzdGluZyBtZW1vcnkuICBJdCBhbHNvIHdvdWxkIGhhdmUgcmVxdWlyZWQNCj4g YSBuZXcgcGxhdGZvcm0gb3AgZm9yIGRvbTAgdG8gdXNlIHRvIGluZGljYXRlIGlmIHRoZSBFU1JU IGlzIHJlc2VydmVkLg0KPiBCeSBjb3B5aW5nIHRoZSBFU1JUIGludG8gRWZpUnVudGltZVNlcnZp Y2VzRGF0YSBtZW1vcnksIHRoZSBFODIwIHRhYmxlDQo+IGRvZXMgbm90IG5lZWQgdG8gYmUgbW9k aWZpZWQsIGFuZCBkb20wIGNhbiBqdXN0IGNoZWNrIHRoZSB0eXBlIG9mIHRoZQ0KPiBtZW1vcnkg cmVnaW9uIGNvbnRhaW5pbmcgdGhlIEVTUlQuICBUaGUgY29weSBpcyBvbmx5IGRvbmUgaWYgdGhl IEVTUlQgaXMNCj4gbm90IGFscmVhZHkgaW4gRWZpUnVudGltZVNlcnZpY2VzRGF0YSBtZW1vcnks IGF2b2lkaW5nIG1lbW9yeSBsZWFrcyBvbg0KPiByZXBlYXRlZCBrZXhlYy4NCj4gDQo+IFNlZSBo dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMDA4MTgxODQwMTguR04xNjc5QG1h aWwtaXRsL1QvDQo+IGZvciBkZXRhaWxzLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogRGVtaSBNYXJp ZSBPYmVub3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQo+IC0tLQ0KPiB4ZW4vY29t bW9uL2VmaS9ib290LmMgfCAxMzQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrDQo+IDEgZmlsZSBjaGFuZ2VkLCAxMzQgaW5zZXJ0aW9ucygrKQ0KPiANCj4gZGlmZiAt LWdpdCBhL3hlbi9jb21tb24vZWZpL2Jvb3QuYyBiL3hlbi9jb21tb24vZWZpL2Jvb3QuYw0KPiBp bmRleCBhMjVlMWQyOWYxLi5mNmYzNGFhODE2IDEwMDY0NA0KPiAtLS0gYS94ZW4vY29tbW9uL2Vm aS9ib290LmMNCj4gKysrIGIveGVuL2NvbW1vbi9lZmkvYm9vdC5jDQo+IEBAIC0zOSw2ICszOSwy NiBAQA0KPiAgIHsgMHg2MDVkYWI1MCwgMHhlMDQ2LCAweDQzMDAsIHsweGFiLCAweGI2LCAweDNk LCAweGQ4LCAweDEwLCAweGRkLCAweDhiLCAweDIzfSB9DQo+ICNkZWZpbmUgQVBQTEVfUFJPUEVS VElFU19QUk9UT0NPTF9HVUlEIFwNCj4gICB7IDB4OTFiZDEyZmUsIDB4ZjZjMywgMHg0NGZiLCB7 IDB4YTUsIDB4YjcsIDB4NTEsIDB4MjIsIDB4YWIsIDB4MzAsIDB4M2EsIDB4ZTB9IH0NCj4gKyNk ZWZpbmUgRUZJX1NZU1RFTV9SRVNPVVJDRV9UQUJMRV9HVUlEICAgIFwNCj4gKyAgeyAweGIxMjJh MjYzLCAweDM2NjEsIDB4NGY2OCwgezB4OTksIDB4MjksIDB4NzgsIDB4ZjgsIDB4YjAsIDB4ZDYs IDB4MjEsIDB4ODB9IH0NCj4gKyNkZWZpbmUgRUZJX1NZU1RFTV9SRVNPVVJDRV9UQUJMRV9GSVJN V0FSRV9SRVNPVVJDRV9WRVJTSU9OIDENCj4gKw0KPiArdHlwZWRlZiBzdHJ1Y3Qgew0KPiArICAg IEVGSV9HVUlEIEZ3Q2xhc3M7DQo+ICsgICAgVUlOVDMyIEZ3VHlwZTsNCj4gKyAgICBVSU5UMzIg RndWZXJzaW9uOw0KPiArICAgIFVJTlQzMiBMb3dlc3RTdXBwb3J0ZWRGd1ZlcnNpb247DQo+ICsg ICAgVUlOVDMyIENhcHN1bGVGbGFnczsNCj4gKyAgICBVSU5UMzIgTGFzdEF0dGVtcHRWZXJzaW9u Ow0KPiArICAgIFVJTlQzMiBMYXN0QXR0ZW1wdFN0YXR1czsNCj4gK30gRUZJX1NZU1RFTV9SRVNP VVJDRV9FTlRSWTsNCj4gKw0KPiArdHlwZWRlZiBzdHJ1Y3Qgew0KPiArICAgIFVJTlQzMiBGd1Jl c291cmNlQ291bnQ7DQo+ICsgICAgVUlOVDMyIEZ3UmVzb3VyY2VDb3VudE1heDsNCj4gKyAgICBV SU5UNjQgRndSZXNvdXJjZVZlcnNpb247DQo+ICsgICAgRUZJX1NZU1RFTV9SRVNPVVJDRV9FTlRS WSBFbnRyaWVzW107DQo+ICt9IEVGSV9TWVNURU1fUkVTT1VSQ0VfVEFCTEU7DQo+IA0KPiB0eXBl ZGVmIEVGSV9TVEFUVVMNCj4gKC8qIF9ub3RfIEVGSUFQSSAqLyAqRUZJX1NISU1fTE9DS19WRVJJ RlkpICgNCj4gQEAgLTU2Nyw2ICs1ODcsNDEgQEAgc3RhdGljIGludCBfX2luaXQgZWZpX2NoZWNr X2R0X2Jvb3QoY29uc3QgRUZJX0xPQURFRF9JTUFHRSAqbG9hZGVkX2ltYWdlKQ0KPiB9DQo+ICNl bmRpZg0KPiANCj4gK3N0YXRpYyBVSU5UTiBfX2luaXRkYXRhIGVzcnQgPSBFRklfSU5WQUxJRF9U QUJMRV9BRERSOw0KPiArDQo+ICtzdGF0aWMgc2l6ZV90IF9faW5pdCBnZXRfZXNydF9zaXplKGNv bnN0IEVGSV9NRU1PUllfREVTQ1JJUFRPUiAqZGVzYykNCj4gK3sNCj4gKyAgICBzaXplX3QgYXZh aWxhYmxlX2xlbiwgbGVuOw0KPiArICAgIGNvbnN0IFVJTlROIHBoeXNpY2FsX3N0YXJ0ID0gZGVz Yy0+UGh5c2ljYWxTdGFydDsNCg0KSGksDQoNCkZyb20gbXkgdGVzdHMgb24gYW4gYXJtNjQgbWFj aGluZSBzbyBmYXIgSSBjYW4gdGVsbCB0aGF0IGRlc2MgaXMgTlVMTCBoZXJlLA0KZm9yIHRoaXMg cmVhc29uIHdlIGhhdmUgdGhlIHByb2JsZW0uDQoNCknigJlsbCBoYXZlIGEgZnVydGhlciBsb29r IG9uIHRoZSBjYXVzZSBvZiB0aGlzLCBidXQgaWYgeW91IGFyZSBmYXN0ZXIgdGhhbiBtZSB5b3Ug YXJlDQp3ZWxjb21lIHRvIGdpdmUgeW91ciBvcGluaW9uIG9uIHRoYXQuDQoNCkNoZWVycywNCkx1 Y2ENCg0KPiArICAgIGNvbnN0IEVGSV9TWVNURU1fUkVTT1VSQ0VfVEFCTEUgKmVzcnRfcHRyOw0K PiArDQo+ICsgICAgbGVuID0gZGVzYy0+TnVtYmVyT2ZQYWdlcyA8PCBFRklfUEFHRV9TSElGVDsN Cj4gKyAgICBpZiAoIGVzcnQgPT0gRUZJX0lOVkFMSURfVEFCTEVfQUREUiApDQo+ICsgICAgICAg IHJldHVybiAwOw0KPiArICAgIGlmICggcGh5c2ljYWxfc3RhcnQgPiBlc3J0IHx8IGVzcnQgLSBw aHlzaWNhbF9zdGFydCA+PSBsZW4gKQ0KPiArICAgICAgICByZXR1cm4gMDsNCj4gKyAgICAvKg0K PiArICAgICAqIFRoZSBzcGVjaWZpY2F0aW9uIHJlcXVpcmVzIEVmaUJvb3RTZXJ2aWNlc0RhdGEs IGJ1dCBhY2NlcHQNCj4gKyAgICAgKiBFZmlSdW50aW1lU2VydmljZXNEYXRhLCB3aGljaCBpcyBh IG1vcmUgbG9naWNhbCBjaG9pY2UuDQo+ICsgICAgICovDQo+ICsgICAgaWYgKCAoZGVzYy0+VHlw ZSAhPSBFZmlSdW50aW1lU2VydmljZXNEYXRhKSAmJg0KPiArICAgICAgICAgKGRlc2MtPlR5cGUg IT0gRWZpQm9vdFNlcnZpY2VzRGF0YSkgKQ0KPiArICAgICAgICByZXR1cm4gMDsNCj4gKyAgICBh dmFpbGFibGVfbGVuID0gbGVuIC0gKGVzcnQgLSBwaHlzaWNhbF9zdGFydCk7DQo+ICsgICAgaWYg KCBhdmFpbGFibGVfbGVuIDw9IG9mZnNldG9mKEVGSV9TWVNURU1fUkVTT1VSQ0VfVEFCTEUsIEVu dHJpZXMpICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+ICsgICAgYXZhaWxhYmxlX2xlbiAtPSBv ZmZzZXRvZihFRklfU1lTVEVNX1JFU09VUkNFX1RBQkxFLCBFbnRyaWVzKTsNCj4gKyAgICBlc3J0 X3B0ciA9IChjb25zdCBFRklfU1lTVEVNX1JFU09VUkNFX1RBQkxFICopZXNydDsNCj4gKyAgICBp ZiAoIChlc3J0X3B0ci0+RndSZXNvdXJjZVZlcnNpb24gIT0NCj4gKyAgICAgICAgICBFRklfU1lT VEVNX1JFU09VUkNFX1RBQkxFX0ZJUk1XQVJFX1JFU09VUkNFX1ZFUlNJT04pIHx8DQo+ICsgICAg ICAgICAhZXNydF9wdHItPkZ3UmVzb3VyY2VDb3VudCApDQo+ICsgICAgICAgIHJldHVybiAwOw0K PiArICAgIGlmICggZXNydF9wdHItPkZ3UmVzb3VyY2VDb3VudCA+IGF2YWlsYWJsZV9sZW4gLyBz aXplb2YoZXNydF9wdHItPkVudHJpZXNbMF0pICkNCj4gKyAgICAgICAgcmV0dXJuIDA7DQo+ICsN Cj4gKyAgICByZXR1cm4gZXNydF9wdHItPkZ3UmVzb3VyY2VDb3VudCAqIHNpemVvZihlc3J0X3B0 ci0+RW50cmllc1swXSk7DQo+ICt9DQo+ICsNCj4gLyoNCj4gICogSW5jbHVkZSBhcmNoaXRlY3R1 cmUgc3BlY2lmaWMgaW1wbGVtZW50YXRpb24gaGVyZSwgd2hpY2ggcmVmZXJlbmNlcyB0aGUNCj4g ICogc3RhdGljIGdsb2JhbHMgZGVmaW5lZCBhYm92ZS4NCj4gQEAgLTg0NSw2ICs5MDAsOCBAQCBz dGF0aWMgVUlOVE4gX19pbml0IGVmaV9maW5kX2dvcF9tb2RlKEVGSV9HUkFQSElDU19PVVRQVVRf UFJPVE9DT0wgKmdvcCwNCj4gICAgIHJldHVybiBnb3BfbW9kZTsNCj4gfQ0KPiANCj4gK3N0YXRp YyBFRklfR1VJRCBfX2luaXRkYXRhIGVzcnRfZ3VpZCA9IEVGSV9TWVNURU1fUkVTT1VSQ0VfVEFC TEVfR1VJRDsNCj4gKw0KPiBzdGF0aWMgdm9pZCBfX2luaXQgZWZpX3RhYmxlcyh2b2lkKQ0KPiB7 DQo+ICAgICB1bnNpZ25lZCBpbnQgaTsNCj4gQEAgLTg2OCw2ICs5MjUsOCBAQCBzdGF0aWMgdm9p ZCBfX2luaXQgZWZpX3RhYmxlcyh2b2lkKQ0KPiAgICAgICAgICAgICBlZmkuc21iaW9zID0gKHVu c2lnbmVkIGxvbmcpZWZpX2N0W2ldLlZlbmRvclRhYmxlOw0KPiAgICAgICAgIGlmICggbWF0Y2hf Z3VpZCgmc21iaW9zM19ndWlkLCAmZWZpX2N0W2ldLlZlbmRvckd1aWQpICkNCj4gICAgICAgICAg ICAgZWZpLnNtYmlvczMgPSAodW5zaWduZWQgbG9uZyllZmlfY3RbaV0uVmVuZG9yVGFibGU7DQo+ ICsgICAgICAgIGlmICggbWF0Y2hfZ3VpZCgmZXNydF9ndWlkLCAmZWZpX2N0W2ldLlZlbmRvckd1 aWQpICkNCj4gKyAgICAgICAgICAgIGVzcnQgPSAoVUlOVE4pZWZpX2N0W2ldLlZlbmRvclRhYmxl Ow0KPiAgICAgfQ0KPiANCj4gI2lmbmRlZiBDT05GSUdfQVJNIC8qIFRPRE8gLSBkaXNhYmxlZCB1 bnRpbCBpbXBsZW1lbnRlZCBvbiBBUk0gKi8NCj4gQEAgLTEwNTEsNiArMTExMCw3MCBAQCBzdGF0 aWMgdm9pZCBfX2luaXQgZWZpX3NldF9nb3BfbW9kZShFRklfR1JBUEhJQ1NfT1VUUFVUX1BST1RP Q09MICpnb3AsIFVJTlROIGdvcA0KPiAjZGVmaW5lIElOVkFMSURfVklSVFVBTF9BRERSRVNTICgw eEJBQUFEVUwgPDwgXA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoRUZJX1BB R0VfU0hJRlQgKyBCSVRTX1BFUl9MT05HIC0gMzIpKQ0KPiANCj4gK3N0YXRpYyB2b2lkIF9faW5p dCBlZmlfcmVsb2NhdGVfZXNydChFRklfU1lTVEVNX1RBQkxFICpTeXN0ZW1UYWJsZSkNCj4gK3sN Cj4gKyAgICBFRklfU1RBVFVTIHN0YXR1czsNCj4gKyAgICBVSU5UTiBpbmZvX3NpemUgPSAwLCBt YXBfa2V5LCBtZGVzY19zaXplOw0KPiArICAgIHZvaWQgKm1lbW9yeV9tYXAgPSBOVUxMOw0KPiAr ICAgIFVJTlQzMiB2ZXI7DQo+ICsgICAgdW5zaWduZWQgaW50IGk7DQo+ICsNCj4gKyAgICBmb3Ig KCA7IDsgKSB7DQo+ICsgICAgICAgIHN0YXR1cyA9IGVmaV9icy0+R2V0TWVtb3J5TWFwKCZpbmZv X3NpemUsIG1lbW9yeV9tYXAsICZtYXBfa2V5LA0KPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAmbWRlc2Nfc2l6ZSwgJnZlcik7DQo+ICsgICAgICAgIGlmICggc3RhdHVz ID09IEVGSV9TVUNDRVNTICYmIG1lbW9yeV9tYXAgIT0gTlVMTCApDQo+ICsgICAgICAgICAgICBi cmVhazsNCj4gKyAgICAgICAgaWYgKCBzdGF0dXMgPT0gRUZJX0JVRkZFUl9UT09fU01BTEwgfHwg bWVtb3J5X21hcCA9PSBOVUxMICkNCj4gKyAgICAgICAgew0KPiArICAgICAgICAgICAgaW5mb19z aXplICs9IDggKiBlZmlfbWRlc2Nfc2l6ZTsNCj4gKyAgICAgICAgICAgIGlmICggbWVtb3J5X21h cCAhPSBOVUxMICkNCj4gKyAgICAgICAgICAgICAgICBlZmlfYnMtPkZyZWVQb29sKG1lbW9yeV9t YXApOw0KPiArICAgICAgICAgICAgbWVtb3J5X21hcCA9IE5VTEw7DQo+ICsgICAgICAgICAgICBz dGF0dXMgPSBlZmlfYnMtPkFsbG9jYXRlUG9vbChFZmlMb2FkZXJEYXRhLCBpbmZvX3NpemUsICZt ZW1vcnlfbWFwKTsNCj4gKyAgICAgICAgICAgIGlmICggc3RhdHVzID09IEVGSV9TVUNDRVNTICkN Cj4gKyAgICAgICAgICAgICAgICBjb250aW51ZTsNCj4gKyAgICAgICAgICAgIFByaW50RXJyKEwi Q2Fubm90IGFsbG9jYXRlIG1lbW9yeSB0byByZWxvY2F0ZSBFU1JUXHJcbiIpOw0KPiArICAgICAg ICB9DQo+ICsgICAgICAgIGVsc2UNCj4gKyAgICAgICAgICAgIFByaW50RXJyKEwiQ2Fubm90IG9i dGFpbiBtZW1vcnkgbWFwIHRvIHJlbG9jYXRlIEVTUlRcclxuIik7DQo+ICsgICAgICAgIHJldHVy bjsNCj4gKyAgICB9DQo+ICsNCj4gKyAgICAvKiBUcnkgdG8gb2J0YWluIHRoZSBFU1JULiAgRXJy b3JzIGFyZSBub3QgZmF0YWwuICovDQo+ICsgICAgZm9yICggaSA9IDA7IGkgPCBpbmZvX3NpemU7 IGkgKz0gZWZpX21kZXNjX3NpemUgKQ0KPiArICAgIHsNCj4gKyAgICAgICAgLyoNCj4gKyAgICAg ICAgICogRVNSVCBuZWVkcyB0byBiZSBtb3ZlZCB0byBtZW1vcnkgb2YgdHlwZSBFZmlSdW50aW1l U2VydmljZXNEYXRhDQo+ICsgICAgICAgICAqIHNvIHRoYXQgdGhlIG1lbW9yeSBpdCBpcyBpbiB3 aWxsIG5vdCBiZSB1c2VkIGZvciBvdGhlciBwdXJwb3Nlcy4NCj4gKyAgICAgICAgICovDQo+ICsg ICAgICAgIHZvaWQgKm5ld19lc3J0ID0gTlVMTDsNCj4gKyAgICAgICAgc2l6ZV90IGVzcnRfc2l6 ZSA9IGdldF9lc3J0X3NpemUoZWZpX21lbW1hcCArIGkpOw0KPiArDQo+ICsgICAgICAgIGlmICgg IWVzcnRfc2l6ZSApDQo+ICsgICAgICAgICAgICBjb250aW51ZTsNCj4gKyAgICAgICAgaWYgKCAo KEVGSV9NRU1PUllfREVTQ1JJUFRPUiAqKShlZmlfbWVtbWFwICsgaSkpLT5UeXBlID09DQo+ICsg ICAgICAgICAgICAgRWZpUnVudGltZVNlcnZpY2VzRGF0YSApDQo+ICsgICAgICAgICAgICBicmVh azsgLyogRVNSVCBhbHJlYWR5IHNhZmUgZnJvbSByZXVzZSAqLw0KPiArICAgICAgICBzdGF0dXMg PSBlZmlfYnMtPkFsbG9jYXRlUG9vbChFZmlSdW50aW1lU2VydmljZXNEYXRhLCBlc3J0X3NpemUs DQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZuZXdfZXNydCk7DQo+ ICsgICAgICAgIGlmICggc3RhdHVzID09IEVGSV9TVUNDRVNTICYmIG5ld19lc3J0ICkNCj4gKyAg ICAgICAgew0KPiArICAgICAgICAgICAgbWVtY3B5KG5ld19lc3J0LCAodm9pZCAqKWVzcnQsIGVz cnRfc2l6ZSk7DQo+ICsgICAgICAgICAgICBzdGF0dXMgPSBlZmlfYnMtPkluc3RhbGxDb25maWd1 cmF0aW9uVGFibGUoJmVzcnRfZ3VpZCwgbmV3X2VzcnQpOw0KPiArICAgICAgICAgICAgaWYgKCBz dGF0dXMgIT0gRUZJX1NVQ0NFU1MgKQ0KPiArICAgICAgICAgICAgew0KPiArICAgICAgICAgICAg ICAgIFByaW50RXJyKEwiQ2Fubm90IGluc3RhbGwgbmV3IEVTUlRcclxuIik7DQo+ICsgICAgICAg ICAgICAgICAgZWZpX2JzLT5GcmVlUG9vbChuZXdfZXNydCk7DQo+ICsgICAgICAgICAgICB9DQo+ ICsgICAgICAgIH0NCj4gKyAgICAgICAgZWxzZQ0KPiArICAgICAgICAgICAgUHJpbnRFcnIoTCJD YW5ub3QgYWxsb2NhdGUgbWVtb3J5IGZvciBFU1JUXHJcbiIpOw0KPiArICAgICAgICBicmVhazsN Cj4gKyAgICB9DQo+ICsNCj4gKyAgICBlZmlfYnMtPkZyZWVQb29sKG1lbW9yeV9tYXApOw0KPiAr fQ0KPiArDQo+IHN0YXRpYyB2b2lkIF9faW5pdCBlZmlfZXhpdF9ib290KEVGSV9IQU5ETEUgSW1h Z2VIYW5kbGUsIEVGSV9TWVNURU1fVEFCTEUgKlN5c3RlbVRhYmxlKQ0KPiB7DQo+ICAgICBFRklf U1RBVFVTIHN0YXR1czsNCj4gQEAgLTE0MTMsNiArMTUzNiw4IEBAIGVmaV9zdGFydChFRklfSEFO RExFIEltYWdlSGFuZGxlLCBFRklfU1lTVEVNX1RBQkxFICpTeXN0ZW1UYWJsZSkNCj4gICAgIGlm ICggZ29wICkNCj4gICAgICAgICBlZmlfc2V0X2dvcF9tb2RlKGdvcCwgZ29wX21vZGUpOw0KPiAN Cj4gKyAgICBlZmlfcmVsb2NhdGVfZXNydChTeXN0ZW1UYWJsZSk7DQo+ICsNCj4gICAgIGVmaV9l eGl0X2Jvb3QoSW1hZ2VIYW5kbGUsIFN5c3RlbVRhYmxlKTsNCj4gDQo+ICAgICBlZmlfYXJjaF9w b3N0X2V4aXRfYm9vdCgpOyAvKiBEb2Vzbid0IHJldHVybi4gKi8NCj4gQEAgLTE3NTMsMyArMTg3 OCwxMiBAQCB2b2lkIF9faW5pdCBlZmlfaW5pdF9tZW1vcnkodm9pZCkNCj4gICAgIHVubWFwX2Rv bWFpbl9wYWdlKGVmaV9sNHQpOw0KPiB9DQo+ICNlbmRpZg0KPiArDQo+ICsvKg0KPiArICogTG9j YWwgdmFyaWFibGVzOg0KPiArICogbW9kZTogQw0KPiArICogYy1maWxlLXN0eWxlOiAiQlNEIg0K PiArICogYy1iYXNpYy1vZmZzZXQ6IDQNCj4gKyAqIGluZGVudC10YWJzLW1vZGU6IG5pbA0KPiAr ICogRW5kOg0KPiArICovDQo+IC0tIA0KPiBTaW5jZXJlbHksDQo+IERlbWkgTWFyaWUgT2Jlbm91 ciAoc2hlL2hlci9oZXJzKQ0KPiBJbnZpc2libGUgVGhpbmdzIExhYg0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:42:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:42:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362088.591968 (Exim 4.92) (envelope-from ) id 1o92U7-00068k-B9; Wed, 06 Jul 2022 10:42:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362088.591968; Wed, 06 Jul 2022 10:42:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92U7-00068d-7l; Wed, 06 Jul 2022 10:42:19 +0000 Received: by outflank-mailman (input) for mailman id 362088; Wed, 06 Jul 2022 10:42:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92U6-00068X-QT for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:42:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150074.outbound.protection.outlook.com [40.107.15.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e26a27b-fd18-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 12:42:17 +0200 (CEST) Received: from FR0P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::12) by DU2PR08MB7360.eurprd08.prod.outlook.com (2603:10a6:10:2f3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 10:42:14 +0000 Received: from VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:15:cafe::6f) by FR0P281CA0007.outlook.office365.com (2603:10a6:d10:15::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 10:42:14 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT035.mail.protection.outlook.com (10.152.18.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 10:42:13 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 06 Jul 2022 10:42:13 +0000 Received: from 3cd16d376cc5.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4E87F0EE-C2F0-4357-A49F-5756644F9ECC.1; Wed, 06 Jul 2022 10:42:07 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3cd16d376cc5.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 10:42:07 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB6PR0801MB1783.eurprd08.prod.outlook.com (2603:10a6:4:2e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Wed, 6 Jul 2022 10:42:03 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 10:42:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e26a27b-fd18-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=UhVTPh7p4Q69kzVmoaGFrMsYujBZKWVPS1TzyeE3+NHgiQCYKJxYVUkUh6EN2cBqTJXMcCUPqnQ1exwB9+0e+uRzqgIWnqg2vcanlGF66/MI/CNKolmAd7v/XD48+5Kc+oLF37/w0WZy6wKop92RtrC2c4zW1GpZHvXk+15Ls9iWxU0CUqqYxbWPtlaYnNIerinxzcoA3Lo139rixau+QvTZyM9IHduYZMwWOyluOin7jppkiTnEDTwttXRYQV8J+KE00I7u1vDrzqy5JTlinqK6Vas8zCUdsh7THRo4Dm8NNlK4oZZ4QGJfNqRZedorosxmhrgaWDE/F99KBTCNyg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jxOhJ8WD+RSzAjdZgMNYj5h2Pt3OdaCjHSjWhNaf5s=; b=XL421N/kq5aNx16/bi3CYBF6Ps4/uQ4uC82h+T9EcBCbY8epriZDZbWaUJxpdUz5FUToXsh4wmkd4P5uUUzSjYEFeBuhpUzojIMNa/XKp+sGyvrRyANzt3XnoETlWtUkRxZoHbcJJxvuDcupcgArlwT4uwxfsN+cXyJkUbbckcNeHQ4njEiYrfMFbTxvSFZ+yrhW9Ubyk4jutEJXlF2Dw3CR1puNR7U1kq9CRX2Ewk50I/61rAWKZt32KSg3IazGZcCABC1KR1VKq83HUc0fdaeHL/WvO8GSu1y3/aKyQO27Dgrpl9OOt2wBTTAvT6TSVmuDApZ0TS008KwHt0A+sg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jxOhJ8WD+RSzAjdZgMNYj5h2Pt3OdaCjHSjWhNaf5s=; b=Qz9y68Ns5y7EM7SwRJiTdwYHmUO23GLBI9biRWuTcAE++oJ2iMsaVfHZtwx6PAChG9/3joWpaiRgYOcRv6qkMrSUy9zKN1oMGjimzVhXLZ4ZrLr/UfjnPH8ph/tvScoVA9jGC0jgHgOzkFXOZujyfqTD6gRmDf0eSnBN5r7ugYQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 89c812f6367c30f8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kv/y+i/2be4OXlTKAvCRBEznkfw4Lal5qJJYMAMYsQUCausUXAEBdPWPg2Jhh2UUFEkhJbf9lI6jMzUtId6XGaS1Qfmnx3cpIwO5ncGKRnidZTaEBLdW6lytX/RV+VzKXyJe7PFhtbWfCdPsklHNtrtYQHItmD3n6WR3mc75xyFJZOHCkCgdJS6QMMOLjlQU9fiKSgeL7XaTRsEjyVi8UE1vmWngji8cNMpuZl9wubvBHozOrjQCYqWcpBpnV5yRHKiPLxuxcCJiy1vh16rDvwD83SMFEDRYoCyqNOxioJhFExG+pOcK/iWtOVYHt6Wm7x5U+7CD/eRY9ObmwSrz/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jxOhJ8WD+RSzAjdZgMNYj5h2Pt3OdaCjHSjWhNaf5s=; b=VIMi0O8k01SaqIR8oIaMuhIdUwAQOu3WqzRgGKz/2Jq9QXdnP/ndbmDBn0SUXvQ5vVZWpRH1MYkXTBApgeOsxrG7sc8XNfou3VaoS2ylpV3Dac1ijUBWU01v4TDcgArfan/cRz8LqkHRvM4l4XUi0HSfGXex3ynw2sJhc4A7lhiHWYHurevCEAHgbPi1/DNe81hVl5yjH1xnJ2sutoCbG9cU56B7JndrUmYNYlkroI5HsQoQQTTVOcdlnKtt1QsO6LVt1spIYzPgBuaY0EFkbNjIcO4Y0JYN+n+MEGpaUZWo7axoBpFuJpOW/2oWpunt+zoLWF/LZSurgkcrfVjvEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jxOhJ8WD+RSzAjdZgMNYj5h2Pt3OdaCjHSjWhNaf5s=; b=Qz9y68Ns5y7EM7SwRJiTdwYHmUO23GLBI9biRWuTcAE++oJ2iMsaVfHZtwx6PAChG9/3joWpaiRgYOcRv6qkMrSUy9zKN1oMGjimzVhXLZ4ZrLr/UfjnPH8ph/tvScoVA9jGC0jgHgOzkFXOZujyfqTD6gRmDf0eSnBN5r7ugYQ= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Topic: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Index: AQHYhkX79rj81mJ150e3nBZ0EA7O6K1bhmuAgAGTuoCAAAWegIAHwJEAgAAJPQCAAAcgAIAAB1iAgArhiICAAAgBAIABW/CA Date: Wed, 6 Jul 2022 10:42:03 +0000 Message-ID: References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> In-Reply-To: <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 46e024d2-619b-4860-80c7-08da5f3c3047 x-ms-traffictypediagnostic: DB6PR0801MB1783:EE_|VE1EUR03FT035:EE_|DU2PR08MB7360:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: D6blRt0YxwXI3tByzm/ZNFDwvbdpiHcGVN0K3wXYVOkKqrVCmgx/RGISKcNCP36Z1AHmEcS+7J16MsUgEnbmW8ioYCeLKnATfPZy0NANzF8uX1nk/t86/ya1sUUuM/6Nk4wS5J8g/vuyYVeZBH+lzip2GO9FEH4IoWefBBhjOSY+T0/JwuxVHdOtrXEMXq54LlkeRyUrCW1E4LSYB1uZLBjIWRptZgZ9taD2B8oB61lr68v1c6yGrXrohqu/8V70zlrC3X8bQRa846RJk2GXWXMww3h60/zzsNnDKsW5OUrdLry+q5PREV1wyUJ0dNQRL1bLLAvOuJ9rfuOojxo+HBcNVOM2Ii1uSxUlPKnL646S9ZQXpG0Stwj+Jm7uFk6mbiU+a5vagMXNLx6iUqp5Qxz2+oqqP5B3e/FvlnlgHhb2tlo8QT1n34gRMXMI/FNZqtuybjF8ZsgkpBPfACQ30lM2RDlzDh6NGLjt7PkJjSPqlg2iB/WHDhPVz7mB8XzJGNfuIocEkV+uXPiXAtJQ67MEng2cSJl+I4tY74hxcgw9wDHnQpnVYrgjuF+0hZ9nptE2spw46aAkPljtCxKrhZOxqTNrw3JmgAAeJZ4cAWhiB9GJWOq0s5QakVFzMOU58JWOPpl9j9qktXtbjY66bxSes58UcNe2DBTLxTa50nP6CXJ6KDRIrwkoEXalD28PJYNld4yiMU8mFEgo66ZVKjOt/ot16PMxs40N92Vx+e0zGLMW1ftvlIoXA1dye+SF2UgFGMaICYdjtKepFkJ0ANjjQ+LAKOL0vL1AmgigMltQR2QgaOS8kWUiiA6YQVwRksr1nTHzhgCuPav5fTlGDaYwh34tUjsLtDIUnDLlxJU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(366004)(136003)(4326008)(8676002)(64756008)(38070700005)(66446008)(66476007)(66556008)(71200400001)(41300700001)(76116006)(53546011)(86362001)(66946007)(6506007)(2906002)(478600001)(33656002)(83380400001)(5660300002)(8936002)(122000001)(26005)(6486002)(6512007)(91956017)(186003)(2616005)(316002)(36756003)(38100700002)(54906003)(6916009)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9A4B87E8E8237A40B55BCA27E620DDFF@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1783 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8d650ccc-6ca0-403f-6b6a-08da5f3c2a18 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bbTM8M92kS6Tq5laLpj5qmtSPbM6uegLs/8Yxtxabe6RjHTOsrPR+r3RBgkvxxcVM0wxeJbfGZY+DF7vJu/0hQGLunxtKQXZlgw96C37spGgLMOeaOU7C0SY06H2AvAv+8cWyLI5W3tODrarvubelJoNskIbCNpM7v0PdXBT0+0jKJkjWi+r2DXXLa0hwuvTrqW9U6uJKIZggQAS1wol4wc/ECRSeZp25scMCBfF7mugMTMpZeEeCNjbFI5sjCJeozyMprXPQUyB7IBEN4ay28zEBQ9wyx17Okls0nNFrR181useG/MdRIDZxiPTmZJmW58WQ8OfhkOejA/qskeJwgOV4DtS3Du08YVPs519RCyI8K7Ax10kO2qhJo3nbl1nSnlASyqKEuCoABpc1JYwmSON2DxcBvxFhV4NfFRFETStyh640XDaJ81lo4J+IXINkr8C3HPK4aNXIhpvGMXueRFke+9f46Me/UWDx0N9ZnLpvxbbqLtHBB0GX2gzyBt5d2u5DnQylPN9RNxshmeqnBGvjoTPac9qfB1EF4eTq2j1Gv/a/8RGTciUWLpKA92z+2EhBc81Dzbo/kf6AN0THA3sXBJa7GRvrHX9MvD1madjPae3k6nA5Dx7/2WpO9TY3lH9Jvpf6myv9QSqksM5hTNziMtCqQLdCIgMm93I3O6KZ/qeiZzZXl5/z0mZTWRfkccIpWdDcdNcQjHjglIwMwgPVuuak9ipa85NqcHrzPAjJqzGNLxuVJ3IK3xG90Yfj6MhvKSWtpCuXdk1YkRb0QRfqQ6HqPgHmklZkM+owqFr8J/DNqt8fXoiJTZC/7AM X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(396003)(46966006)(40470700004)(36840700001)(316002)(70586007)(6486002)(70206006)(8676002)(6506007)(478600001)(4326008)(40480700001)(54906003)(82310400005)(6862004)(8936002)(40460700003)(5660300002)(2906002)(82740400003)(36860700001)(36756003)(86362001)(81166007)(33656002)(356005)(41300700001)(26005)(2616005)(186003)(83380400001)(47076005)(53546011)(6512007)(336012);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:42:13.7609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 46e024d2-619b-4860-80c7-08da5f3c3047 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7360 SGkgSnVsaWVuLA0KDQo+IE9uIDUgSnVsIDIwMjIsIGF0IDI6NTYgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAwNS8wNy8yMDIyIDE0OjI4 LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIFJhaHVsLA0KPiAN Cj4+PiBPbiAyOCBKdW4gMjAyMiwgYXQgNDoxOCBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4gd3JvdGU6DQo+Pj4+IGEgbmV3IGRyaXZlciBpbiBsaW51eCBrZXJuZWwsIGV0YyB3aGVy ZSByaWdodCBub3cgd2UganVzdCBuZWVkIHRvIGludHJvZHVjZSBhbiBleHRyYSBJT0NUTCBpbiBs aW51eCB0byBzdXBwb3J0IHRoaXMgZmVhdHVyZS4NCj4+PiANCj4+PiBJIGRvbid0IHVuZGVyc3Rh bmQgd2h5IHdvdWxkIG5lZWQgYSBuZXcgZHJpdmVyLCBldGMuIEdpdmVuIHRoYXQgeW91IGFyZSBp bnRyb2R1Y2luZyBhIG5ldyBJT0NUTCB5b3UgY291bGQgcGFzcyBhIGZsYWcgdG8gc2F5ICJUaGlz IGlzIGEgc3RhdGljIGV2ZW50IGNoYW5uZWwgc28gZG9uJ3QgY2xvc2UgaXQiLg0KPj4gSSB0cmll ZCB0byBpbXBsZW1lbnQgb3RoZXIgc29sdXRpb25zIHRvIHRoaXMgaXNzdWUuIFdlIGNhbiBpbnRy b2R1Y2UgYSBuZXcgZXZlbnQgY2hhbm5lbCBzdGF0ZSDigJxFQ1NfU1RBVElD4oCdIGFuZCBzZXQg dGhlDQo+PiBldmVudCBjaGFubmVsIHN0YXRlIHRvIEVDU19TVEFUSUMgd2hlbiBYZW4gYWxsb2Nh dGUgYW5kIGNyZWF0ZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWxzLg0KPiANCj4gRnJvbSB3aGF0 IHlvdSB3cm90ZSwgRUNTX1NUQVRJQyBpcyBqdXN0IGFuIGludGVyZG9tYWluIGJlaGluZCBidXQg d2hlcmUgeW91IHdhbnQgWGVuIHRvIHByZXZlbnQgY2xvc2luZyB0aGUgcG9ydC4NCj4gDQo+IEZy b20gWGVuIFBvViwgaXQgaXMgc3RpbGwgbm90IGNsZWFyIHdoeSB0aGlzIGlzIGEgcHJvYmxlbSB0 byBsZXQgTGludXggY2xvc2luZyBzdWNoIHBvcnQuIEZyb20gdGhlIGd1ZXN0IFBvViwgdGhlcmUg YXJlIG90aGVyIHdheSB0byBwYXNzIHRoaXMgaW5mb3JtYXRpb24gKHNlZSBiZWxvdykuDQoNCklm IExpbnV4IGNsb3NlcyB0aGUgcG9ydCwgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsIGNyZWF0ZWQg YnkgWGVuIGFzc29jaWF0ZWQgd2l0aCBzdWNoIHBvcnQgd2lsbCBub3QgYmUgYXZhaWxhYmxlIHRv IHVzZSBhZnRlcndhcmQuDQoNCldoZW4gSSBzdGFydGVkIGltcGxlbWVudGVkIHRoZSBzdGF0aWMg ZXZlbnQgY2hhbm5lbCBzZXJpZXMsIEkgdGhvdWdodCB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwg aGFzIHRvIGJlIGF2YWlsYWJsZSBmb3IgdXNlIGR1cmluZw0KdGhlIGxpZmV0aW1lIG9mIHRoZSBn dWVzdC4gVGhpcyBwYXRjaCBhdm9pZHMgY2xvc2luZyB0aGUgcG9ydCBpZiB0aGUgTGludXggdXNl ci1zcGFjZSBhcHBsaWNhdGlvbiB3YW50cyB0byB1c2UgdGhlIGV2ZW50IGNoYW5uZWwgYWdhaW4u DQoNClRoaXMgcGF0Y2ggaXMgZml4aW5nIHRoZSBwcm9ibGVtIGZvciBMaW51eCBPUywgYW5kIEkg YWdyZWUgd2l0aCB5b3UgdGhhdCB3ZSBzaG91bGQgbm90IG1vZGlmeSB0aGUgWGVuIHRvIGZpeCB0 aGUgTGludXggcHJvYmxlbS4NClRoZXJlZm9yZSwgSWYgdGhlIGd1ZXN0IGRlY2lkZWQgdG8gY2xv c2UgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsLCBYZW4gd2lsbCBjbG9zZSB0aGUgcG9ydC4gRXZl bnQgQ2hhbmVsIGFzc29jaWF0ZWQgd2l0aCB0aGUgcG9ydA0Kd2lsbCBub3QgYmUgYXZhaWxhYmxl IGZvciB1c2UgYWZ0ZXIgdGhhdC5JIHdpbGwgZGlzY2FyZCB0aGlzIHBhdGNoIGluIHRoZSBuZXh0 IHNlcmllcy4NCg0KPiANCj4+IEZyb20gZ3Vlc3QgT1Mgd2UgY2FuIGNoZWNrIGlmIHRoZSBldmVu dCBjaGFubmVsIGlzIHN0YXRpYyAodmlhIEVWVENITk9QX3N0YXR1cygpICBoeXBlcmNhbGwgKSwg aWYgdGhlIGV2ZW50IGNoYW5uZWwgaXMNCj4+IHN0YXRpYyBkb27igJl0IHRyeSB0byBjbG9zZSB0 aGUgZXZlbnQgY2hhbm5lbC4gSWYgZ3Vlc3QgT1MgdHJ5IHRvIGNsb3NlIHRoZSBzdGF0aWMgZXZl bnQgY2hhbm5lbCBYZW4gd2lsbCByZXR1cm4gZXJyb3IgYXMgc3RhdGljIGV2ZW50IGNoYW5uZWwg Y2Fu4oCZdCBiZSBjbG9zZWQuDQo+IFdoeSBkbyB5b3UgbmVlZCB0aGlzPyBZb3UgYWxyZWFkeSBu ZWVkIGEgYmluZGluZyBpbmRpY2F0aW5nIHdoaWNoIHBvcnRzIHdpbGwgYmUgcHJlLWFsbG9jYXRl ZC4gU28geW91IGNvdWxkIHVwZGF0ZSB5b3VyIGJpbmRpbmcgdG8gcGFzcyBhIGZsYWcgdGVsbGlu ZyBMaW51eCAiZG9uJ3QgY2xvc2UgaXQiLg0KPiANCj4gSSBoYXZlIGFscmVhZHkgcHJvcG9zZWQg dGhhdCBiZWZvcmUgYW5kIEkgaGF2ZW4ndCBzZWVuIGFueSBleHBsYW5hdGlvbiB3aHkgdGhpcyBp cyBub3QgYSB2aWFibGUgc29sdXRpb24uDQoNClNvcnJ5IEkgZGlkbuKAmXQgbWVudGlvbiB0aGlz IGVhcmxpZXIsIEkgc3RhcnRlZCB3aXRoIHlvdXIgc3VnZ2VzdGlvbiB0byBmaXggdGhlIGlzc3Vl IGJ1dCBhZnRlciBnb2luZyB0aHJvdWdoIHRoZSBMaW51eCBldnRjaG4gZHJpdmVyIGNvZGUNCml0 IGlzIG5vdCBzdHJhaWdodCBmb3J3YXJkIHRvIHRlbGwgTGludXggZG9u4oCZdCBjbG9zZSB0aGUg cG9ydC4gTGV0IG1lIHRyeSB0byBleHBsYWluLg0KDQpJbiBMaW51eCwgc3RydWN0IHVzZXJfZXZ0 Y2huIHt9IGlzIHRoZSBzdHJ1Y3QgdGhhdCBob2xkIHRoZSBpbmZvcm1hdGlvbiBmb3IgZWFjaCB1 c2VyIGV2dGNobiBvcGVuZWQuIFdlIGNhbiBhZGQgb25lIGJvb2wgcGFyYW1ldGVyIGluIHRoaXMg c3RydWN0IHRvIHRlbGwgTGludXggZHJpdmVyDQp2aWEgSU9DVEwgaWYgZXZ0Y2huIGlzIHN0YXRp Yy4gV2hlbiB1c2VyIGFwcGxpY2F0aW9uIGNsb3NlIHRoZSBmZCAiL2Rldi94ZW4vZXZ0Y2hu4oCd ICwgZXZ0Y2huX3JlbGVhc2UoKSB3aWxsIHRyYXZlcnNlIGFsbCB0aGUgZXZ0Y2huIGFuZCBjYWxs IGV2dGNobl91bmJpbmRfZnJvbV91c2VyKCkNCmZvciBlYWNoIGV2dGNobi4gZXZ0Y2huX3VuYmlu ZF9mcm9tX3VzZXIoKSB3aWxsIGNhbGwgIF9fdW5iaW5kX2Zyb21faXJxKGlycSkgdGhhdCB3aWxs IGNhbGwgeGVuX2V2dGNobl9jbG9zZSgpIC4gV2UgbmVlZCByZWZlcmVuY2VzIHRvICJzdHJ1Y3Qg dXNlcl9ldnRjaG7igJ0gaW4NCmZ1bmN0aW9uIF9fdW5iaW5kX2Zyb21faXJxKCkgdG8gcGFzcyBh cyBhcmd1bWVudCB0byB4ZW5fZXZ0Y2huX2Nsb3NlKCkgbm90IHRvIGNsb3NlIHRoZSBzdGF0aWMg ZXZlbnQgY2hhbm5lbC4gIEkgYW0gbm90IGFibGUgdG8gZmluZCBhbnkgd2F5IHRvIGdldCANCnN0 cnVjdCB1c2VyX2V2dGNobiBpbiBmdW5jdGlvbiBfX3VuYmluZF9mcm9tX2lycSgpICwgd2l0aG91 dCBtb2RpZnlpbmcgdGhlIG90aGVyIExpbnV4IHN0cnVjdHVyZS4NCg0KUmVnYXJkcywNClJhaHVs DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:44:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362093.591979 (Exim 4.92) (envelope-from ) id 1o92Vr-0006hk-NE; Wed, 06 Jul 2022 10:44:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362093.591979; Wed, 06 Jul 2022 10:44:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92Vr-0006hd-JH; Wed, 06 Jul 2022 10:44:07 +0000 Received: by outflank-mailman (input) for mailman id 362093; Wed, 06 Jul 2022 10:44:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92Vq-0006hT-9k for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:44:06 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8cffada6-fd18-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 12:44:04 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cffada6-fd18-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657104244; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=66dhwcKzqHemU6p1wmUfhDtEquNljMoqjZh7U9fdIDc=; b=iLhWMVR4+S2cwETs5jSy3VSZEUIK8XU40KcVJ/Hg17o9MQPMwZM3MCx6 Y9WjEJlFIPooOHs3tHMnPzIHYrOHplRNFuwiyLnTpLCzRQ4DyCcRzFGB6 ZVNxPJCJcLLoZiFQX/xgq8eGlG1C6fjxQiy3lPNI3vFIowH6zEcwV3AQz E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75203369 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:vdtuiqNm3y0Xx4jvrR3Yl8FynXyQoLVcMsEvi/4bfWQNrUp01WAFn TcWXW2FMqnZNzHxfNslPNjk908Hu8DVz9M1QQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH1dOKJQUBUjclkfJKlYAL/En03FFUMpBsJ00o5wbZm2tAw2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z4 opss6ebSh4SH6jrt8UYU0RiOQBSFPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALJc/3PIQZqzd4wCvQF/oOSpHfWaTao9Rf2V/cg+gRQKyGP JFHOFKDajyHURt9YVwlF640nfyNqVL9cSRU8nS88P9fD2/7k1UqjemF3MDuUt6FX8JOhW6Du 3nLuW/+B3kyK9i32TeDtHW2iYfnjS79HY4fCrC83vprm0GIgHweDgUMUlm2quX/jVSxM/pdI UEJ/islrYAp6VemCNL6WnWQq3eeuBkYV/JLDvY3rgqKz8LpDx2xXzZeCGQbMZp/6ZFwFWdCO kK1c83BL2NOtoa+Smum17KzghK3OXUvB04uTHpRJeca2OUPsL3fnzqWEIs8Sfbt3oCvcd3j6 2vU9XZj3t3/meZOjvzmpg6f3lpAs7CTFmYIChPrsnVJB++TTKqsfMSW5FfS9p6sx67JHwDa7 BDodyVzhd3i7K1hdwTXGY3h5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aJGCxP BGJ41gIus870J6WgUhfOtvZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB Kp3hf2EVC5AYYw+lWLeb75EjdcDm3FlrUuOFM+T8vhS+efHDJJjYexdYAXmgyFQxP7snTg5B P4Gb5LbkEkEDrCiCsQVmKZKRW03wbEALcieg6RqmiSre2KKxElJ5yft/I4c IronPort-HdrOrdr: A9a23:oONg/KxG52dVpspOQRX8KrPwFL1zdoMgy1knxilNoRw8SK2lfu SV7ZMmPHjP+VAssRAb6LS90ca7LU80maQb3WBVB8baYOCEghrMEGgB1/qA/9SIIUSXnYQx6U 4jSdkdNDSZNykDsS+Q2mmF+rgbruW6zA== X-IronPort-AV: E=Sophos;i="5.92,249,1650945600"; d="scan'208";a="75203369" Date: Wed, 6 Jul 2022 11:43:57 +0100 From: Anthony PERARD To: Jan Beulich CC: Charles Arnold , , Juergen Gross , Wei Liu Subject: Re: [PATCH] Fix compilation error with gcc13 Message-ID: References: <46d17735-e96f-2eee-5d24-fc3d15526c6e@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jun 29, 2022 at 08:29:02AM +0200, Jan Beulich wrote: > (Cc-ing maintainers / reviewers) > > On 28.06.2022 18:09, Charles Arnold wrote: > > From 359f490021e69220313ca8bd2981bad4fcfea0db Mon Sep 17 00:00:00 2001 > > From: Charles Arnold > > Date: Tue, 28 Jun 2022 09:55:28 -0600 > > Subject: Fix compilation error with gcc13. > > > > xc_psr.c:161:5: error: conflicting types for 'xc_psr_cmt_get_data' > > due to enum/integer mismatch; > > > > Signed-off-by: Charles Arnold > > Reviewed-by: Jan Beulich > > The subject would benefit from having a "libxc: " prefix, to know at > the first glance which component is being touched. > > > --- a/tools/include/xenctrl.h > > +++ b/tools/include/xenctrl.h > > @@ -2520,7 +2520,7 @@ int xc_psr_cmt_get_l3_event_mask(xc_interface > > *xch, uint32_t *event_mask); > > int xc_psr_cmt_get_l3_cache_size(xc_interface *xch, uint32_t cpu, > > uint32_t *l3_cache_size); > > int xc_psr_cmt_get_data(xc_interface *xch, uint32_t rmid, uint32_t cpu, > > - uint32_t psr_cmt_type, uint64_t *monitor_data, > > + xc_psr_cmt_type type, uint64_t *monitor_data, > > uint64_t *tsc); > > int xc_psr_cmt_enabled(xc_interface *xch); > > > > The patch looks slightly garbled, reminding me of how things looked > for me before I adjusted TB configuration accordingly. I'd be fine > hand-editing the patch while committing, if no other need arises for > a v2 (and of course once a maintainer ack has been provided). Acked-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:44:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:44:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362097.591990 (Exim 4.92) (envelope-from ) id 1o92Wh-0007Fe-27; Wed, 06 Jul 2022 10:44:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362097.591990; Wed, 06 Jul 2022 10:44:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92Wg-0007FX-UH; Wed, 06 Jul 2022 10:44:58 +0000 Received: by outflank-mailman (input) for mailman id 362097; Wed, 06 Jul 2022 10:44:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92Wf-00074T-UZ for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:44:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ac5dad36-fd18-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 12:44:57 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 06 Jul 2022 06:44:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO3PR03MB6696.namprd03.prod.outlook.com (2603:10b6:303:17b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 10:44:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 10:44:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ac5dad36-fd18-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657104296; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=8w44/UeYtiIwsz//ewK0Bds+3fKlFyIJoI0rfHEn9Qk=; b=Sd5fdNvVKEpKG1d5WmCbf/HVDm727rS0POSYKbLExMrQSUIMRE8AwBBX 1/MJnXDDX65iDnCbJaUJhdi1mJtBWy2izbMKEcj+vZfIEa3PGYotkg3Td gO6AO6rAILRo5JijVwjH16vR3DGERhWuCCwBqf0CMmiMgj/cWoSN9b22g Y=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 77743578 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8A+0LK8H/KeIQ37O8ONkDrUDqH+TJUtcMsCJ2f8bNWPcYEJGY0x3n GQfCm/Uaf2PZGHyctt/b4jioUkGu5DUyN9jGgs/r3s8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ74f5fs7Rh2NQw3oDnW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnbOXYw1qOaPSofwAaQFcCSFbZIpHv4aSdBBTseTLp6HHW13F5qw0SWQJZ8gf8OsxBnxS/ /sFLjxLdgqEm++93LO8TK9rm9gnK87oeogYvxmMzxmAVapgHc+FHfuMuYcwMDQY36iiGd73Y cYDZCUpRxPHexBVYX8cCY4knffujX76G9FdgA3K+vZsvjeDpOB3+L7TYNOJUdq6fMd+n0bAi V3JuH/mIzhPYbRzzhLAqBpAnNTnuT7wUcQ8Hbuz+/punXWa3GlVAxoTPXO3rPy4ok+4RdNEK kYQ9zYurK4970iiRJ/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceRzYny 1uIlNPBHiF0vfueTnf13rWJqTK/PwAFIGlEYjULJTbp+PHmqYA3yxfQFNBqFffvisWvQW2oh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7AJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:StQ0z6FL+UpVoJVUpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.92,249,1650945600"; d="scan'208";a="77743578" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IxJz41oMXAzLiIS68tJQ2SHv0Nh2sSw0uJPlid1SqiqYTJ4sPXVxfmwDg3wMYg6NkSK8vJcyfrkjbz6y/IbrI0t3biaOEScXtXR8c25q+a9rfe5rhiRVFFPIw5q+V35pXD9AhFNJzIIHs7QmdJf5xldrUW6E1WFc4BuINjOSfTTed3MMQOE882KI1CMZ4lTU3YndjNvCJE6Hr65T5H5N21RfZ4CAYR5nrM1ytZzKrAtkUU6OT1XqAAZ8bmEcaE956UcOuSjRtu1QGSBNCFTxLg8jN1sjbfjAgANf6wTAhu0n5xDFVjQeRh1RvsogF4bZWRXdntneVr9vEBUIc3ayfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8w44/UeYtiIwsz//ewK0Bds+3fKlFyIJoI0rfHEn9Qk=; b=FIIoLu9MLD+KZJA4ohglpJLa9bMMgh+giDpEtebzPWies03oirtI5iuVnbhOmrIyAU6UocTO0RC4OdhYk0aPLFS1tTd3fX5CUEaO9M5Fn3I0oGBXv7eF3FVP+dSzODgEFXcLTq8pOE1SyhxByxGMMFj9kIpL3syNq1dtrqvo1ASX7Qt/0szXLXwudFsOBnF4RyXYMkUEHSuE9D9DT7T1EMtV8XC+YKyIi8AefmLCyvJCK5Q/9KV1o4h1OecrGYglrstUdTdRkMI623GaVFI4bQfo/8p93tfm0FXljlnzjHzlQ8Uf4DbMpODY+5fDCqC2Owe6Ooe9Dg2utceMMaoi8g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8w44/UeYtiIwsz//ewK0Bds+3fKlFyIJoI0rfHEn9Qk=; b=C1sHPSjQ9Kt3ylKcwecJqPqktPYI+f7XSoEq60h9XY8sq2a7qcHW7lRNt2LPEqD/XBPKhoIPJdZH+eBYDWrwo2mtkHEOjwvvyCjCcsf1gLgGYAQT9UtaFLWgviiZF55AvPFQUJKXkuhhj4pqdUHH9KSvo/VbP0LxdaIAQrSs1Pc= From: Andrew Cooper To: Luca Fancellu , Demi Marie Obenour CC: Xen-devel , Jan Beulich , Julien Grall Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Topic: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Index: AQHYh/bGtXoG96D86Eiyr5Btw15f161xN36AgAADZIA= Date: Wed, 6 Jul 2022 10:44:46 +0000 Message-ID: <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> In-Reply-To: <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bd23ec88-7621-4cc4-0ded-08da5f3c8b10 x-ms-traffictypediagnostic: CO3PR03MB6696:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9a5PChu6BhCpOXCsSp5ZChvkG+IGmFTHQsK8E8RcORVbLU8r/pP1jChPKhwBeq4im0LkSwI1BvVZ1syfm3Kvt89v2uQzkLX+x6k2n9nt6NDM+GJbG+wvtmHhqcpHE6nmRa3Nz+rRspZMrTnXbS99tyT/YCFeztUxVDdY4XIrRoOUduzj4jFmhcp2hZLksUp69xgzbircrLGK3Q7BEIerml4XqR2VPfitqfp6+WZIyLlmkmTGfqmFHYvImUo52bFk2Zhbsa5MEDFSqSJBRHd5g0uvf6DDbD/4AIQVesP1c7a1mOIthTaQ8mZo5Ds6zBVTwLY42RJYKXSLkLJfKgD1ZSwgRsBhHFSjybWqhBvnWGMDd3DcMDz5OWDQHTBRnRvN28Ys43lBUgy53YxhbvBe+3UchjnQyKHZTZcrkgHjJdNvxy8ZqsF6E6ZQ0HUd/LV/fKLyQyTFQhHO8snln+Iro2TTsqeNPczguEscEOrnTpCIr+exHF3ieLByOoo06PyG5UE8136pKxYoXK42JXrekQi+YZxls9A/UV7zyBR0FcO1yBkeNRL3yKv+YBwtQAMrQggaAVZ4vixe5Ld4+LP0qFpV7wjgwRtLH94LK7zo02A/cucHneHzB6G88zxpu9W43DTW/rS4oim31TEOkNf77HN6Q2BBqLQ0yaoPtrUJySrdxi6OY1O6UoERXvhZoRVremQtC7pA63oitR2tMJaA2CjVQ9y1+ZnGE8nAB0eQt5DC2HFN9RVM8zpu3VstXfjxUE2zS+KPvNhEu3oyWybaENEJ5CCeUnSSxZ+9hOoI/pwfNIu1h1Ul66aL3r/rJ9C5tgntNhrFnqMwhyGQfbauMwujGxuD3ebeg7YmTlrs+4RkHoL/EAV5n6fosihYAQgG x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(39860400002)(376002)(366004)(66476007)(4326008)(8676002)(66556008)(2616005)(66446008)(64756008)(66946007)(31686004)(91956017)(186003)(38100700002)(82960400001)(6506007)(2906002)(36756003)(76116006)(26005)(6512007)(6486002)(54906003)(110136005)(478600001)(41300700001)(5660300002)(31696002)(38070700005)(86362001)(71200400001)(53546011)(316002)(122000001)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VVdGWWthS2dQZ3BmMDRUYzQvK1hybEc1YVFOaVhuczhGMVJqejlyMjYzWkRF?= =?utf-8?B?Wk1pTnFNM1RNdkNZTE1mYzMxQndWNElVOGxNdmdTZlBaU051dmM4WHB1YkFS?= =?utf-8?B?MUhZdUxqRjIvOUtBeERnWG5HTGt6MlM5OExOVXVvR3UwbG9sQldwOE9nbUJh?= =?utf-8?B?aDEzbTdVUkNXWW03OWI4dHJOQnY5RmQ5cGxKcWZBbnpUcjJsNW04dzRHV1Jr?= =?utf-8?B?Vk1pYjF4c20ybVgxRzloZUU5dzBRbWJLd0JUM0VrejFNRmlwblBPK05JcnpJ?= =?utf-8?B?d0h6aWVRaEpEaEwrMjRxdjF1eGluL29LN2J1bm5JYVIvSWFPeC92VVY1Z1FN?= =?utf-8?B?Y3RHYW1ncEEwam1mVGdjWWloVy9HaWhkZVUzYjh6cnE4Y0F5cnEvRzBnNzAr?= =?utf-8?B?NGVuNnJ3Q2JObkxDR2pyUHpZbGRNcVErekdkL1NsVmZMZG9QTnE2QzNqVGJv?= =?utf-8?B?UkVtRGRUUzhGcWwvTVk5aHNmQnFtZVRYQlhZSE5STWVyYk54ZXVOZjJSQWs2?= =?utf-8?B?TEtacUhkREdadkdYbExBVUZJcXVPVGJCK2ZXOFBNUDdJKzRxenFPQWZzYUJE?= =?utf-8?B?TjZpMENJb3dWSE9FS2kyRkR4M24rR1VWMHM0R2psUzBmdVVNMEpNenRUWk9E?= =?utf-8?B?OTNTWGNtam9rT3prc3YrYmhoeUdTZTI3anRzTEl1ZjRqbUt3U2gxTXhkKzhm?= =?utf-8?B?aVN4bkdnejMweXZ0cW1DY1M1b1ZIQ1pDU2NFVFN0a1N0WUg3QkV1cW5MeUFt?= =?utf-8?B?YTlpOWpFUXo0bkdFSXEzOURURVRBSDZZSnowWEQxQ0xXNTNhRWI3R3dubVM2?= =?utf-8?B?WFF3VGhhM2h0SmY3cDVYNnBBdmFTQ3ZYQUJSUWx5NERjZ01BZ2lTWVpFV3hr?= =?utf-8?B?T1JsdGRxNmlxRlNqU09aL3NZTm5iYUhwVnFMVG9zcE9sRXZHOStyakZFc0ZV?= =?utf-8?B?ZTIvN1hzaGFPMU5jbEpMWEFjOEY5U0cyQzNReWlVVWFnaVVwOUNTdVZVWFlu?= =?utf-8?B?enljVjNrdnBnN2Z2SjdyWjZIdnBVSnYxVDJZcHVMeXZUT2t6M0t6ZXg2eW5N?= =?utf-8?B?elNsTlhXblRnam4vYWN6ZytRQVU4Q1MvNjNpRVNJdnZ3bkdYcmhCMlBSSVpD?= =?utf-8?B?bkV2ZlhJS3J6eVZwcC9NT1pocmpsUjY1YWZLbTgvcEdXeDl1cU9Cc3cxWUVu?= =?utf-8?B?eVliMkxUTTJlM3RTUnBRYkh3RDJnZVRQWmJhTnhXK3JFSVI5aHBqQktpeWhE?= =?utf-8?B?L3BUR2xTc2tHaTRyWTBacTg4OG1QdmNVTTg3eWNHL2tnUWw5UUhuRWxUMWFV?= =?utf-8?B?MGhIRVhOdHpKZ2lGenhuRTlhNld0NnpvWlFEQTdGR3FHaldXTGphQVZ4RnRj?= =?utf-8?B?V1BTL2VodzNMV051cTV1REhPSENnVWhBL3hKeGptbFlvWCtSNWRjbE52dUhV?= =?utf-8?B?c0hYb3FjVlRGTGVoY3ZseDJ3emRmcVhtQlhWeW9zYnFjWVk1SzdNU3BsZlpz?= =?utf-8?B?cEVhVDlSa3RqdWFacUwwM2JsRldrMGFaa25nbTV3STE4TXNXRUpMTkVLdHlD?= =?utf-8?B?NGhYT2ZwOHhDZmlkQ1VjL3VHeGVuaFZFR1RxaXdoaVNrSjVYN1R0L0R6bzhC?= =?utf-8?B?MGROajlaOTFvcUh5SXg5cWw5NHVWR1FidUZRWTgzd3VwOHpKTnYxTW5GbHlG?= =?utf-8?B?QVgwRGJSSDZ6ZEZSdTBiNUg5cUt1ZUprU1pDcXlaL1gwQ1hicUJRUThobHR1?= =?utf-8?B?eGZmdlhVMmIySjUvcW45Tm5aREVkRHZoeGtSV1cxdnVPaks5elBjVGpzenRG?= =?utf-8?B?Wm1YT2tvTHh2aXN5SjlVZU5ORlN6ekVjU3ZObXAvSWR0ZzVQSnZSRnFibkJo?= =?utf-8?B?MHpqb1NQSlJvTlhHaDg5T3J4RTVSR3FndUZsTGVPN3VpdnprbmJyZjAybEZ5?= =?utf-8?B?bXlhN0x6T0RLaWRWb1YySk1PdWxmOFBkckN3ZFBqTzZKVjdDeUZOS015S1cv?= =?utf-8?B?ZGN5M2xSbTZjY0QxMjNNbWRMdkpmdlZ1U0pwNnJ6OFZPejQ3cnQxZ1I0Q1BH?= =?utf-8?B?cG1kQUZkaitzVVhZSy9MRG5KVUxCUEdrVHJDR3dhblFib0tPcENMNWhDRW9o?= =?utf-8?Q?UbZqiqJkn15XrpUcKeS9e2X/Z?= Content-Type: text/plain; charset="utf-8" Content-ID: <35AFB819C9151949B1F63517DF126937@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd23ec88-7621-4cc4-0ded-08da5f3c8b10 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jul 2022 10:44:46.1795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dH+xGxyoXoC5i87mcXzbBFWJyGDh8DhPrI4VkEV9N4DTix4LKidU257Tq8zoPkb8pPkhJeLfizEEEPT5LqKlHUNrayvYA/a7W7zU0qd9OaQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO3PR03MB6696 T24gMDYvMDcvMjAyMiAxMTozMiwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+IE9uIDI0IEp1biAy MDIyLCBhdCAxOToxNywgRGVtaSBNYXJpZSBPYmVub3VyIDxkZW1pQGludmlzaWJsZXRoaW5nc2xh Yi5jb20+IHdyb3RlOg0KPj4NCj4+IGRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2VmaS9ib290LmMg Yi94ZW4vY29tbW9uL2VmaS9ib290LmMNCj4+IGluZGV4IGEyNWUxZDI5ZjEuLmY2ZjM0YWE4MTYg MTAwNjQ0DQo+PiAtLS0gYS94ZW4vY29tbW9uL2VmaS9ib290LmMNCj4+ICsrKyBiL3hlbi9jb21t b24vZWZpL2Jvb3QuYw0KPj4gQEAgLTU2Nyw2ICs1ODcsNDEgQEAgc3RhdGljIGludCBfX2luaXQg ZWZpX2NoZWNrX2R0X2Jvb3QoY29uc3QgRUZJX0xPQURFRF9JTUFHRSAqbG9hZGVkX2ltYWdlKQ0K Pj4gfQ0KPj4gI2VuZGlmDQo+Pg0KPj4gK3N0YXRpYyBVSU5UTiBfX2luaXRkYXRhIGVzcnQgPSBF RklfSU5WQUxJRF9UQUJMRV9BRERSOw0KPj4gKw0KPj4gK3N0YXRpYyBzaXplX3QgX19pbml0IGdl dF9lc3J0X3NpemUoY29uc3QgRUZJX01FTU9SWV9ERVNDUklQVE9SICpkZXNjKQ0KPj4gK3sNCj4+ ICsgICAgc2l6ZV90IGF2YWlsYWJsZV9sZW4sIGxlbjsNCj4+ICsgICAgY29uc3QgVUlOVE4gcGh5 c2ljYWxfc3RhcnQgPSBkZXNjLT5QaHlzaWNhbFN0YXJ0Ow0KPiBIaSwNCj4NCj4gRnJvbSBteSB0 ZXN0cyBvbiBhbiBhcm02NCBtYWNoaW5lIHNvIGZhciBJIGNhbiB0ZWxsIHRoYXQgZGVzYyBpcyBO VUxMIGhlcmUsDQo+IGZvciB0aGlzIHJlYXNvbiB3ZSBoYXZlIHRoZSBwcm9ibGVtLg0KPg0KPiBJ 4oCZbGwgaGF2ZSBhIGZ1cnRoZXIgbG9vayBvbiB0aGUgY2F1c2Ugb2YgdGhpcywgYnV0IGlmIHlv dSBhcmUgZmFzdGVyIHRoYW4gbWUgeW91IGFyZQ0KPiB3ZWxjb21lIHRvIGdpdmUgeW91ciBvcGlu aW9uIG9uIHRoYXQuDQoNCkdpdmVuIHRoaXMgb2JzZXJ2YXRpb24sIHRoZXJlJ3MgY2xlYXJseSAu Li4NCg0KPiBAQCAtMTA1MSw2ICsxMTEwLDcwIEBAIHN0YXRpYyB2b2lkIF9faW5pdCBlZmlfc2V0 X2dvcF9tb2RlKEVGSV9HUkFQSElDU19PVVRQVVRfUFJPVE9DT0wgKmdvcCwgVUlOVE4gZ29wDQo+ ICNkZWZpbmUgSU5WQUxJRF9WSVJUVUFMX0FERFJFU1MgKDB4QkFBQURVTCA8PCBcDQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIChFRklfUEFHRV9TSElGVCArIEJJVFNfUEVSX0xP TkcgLSAzMikpDQo+DQo+ICtzdGF0aWMgdm9pZCBfX2luaXQgZWZpX3JlbG9jYXRlX2VzcnQoRUZJ X1NZU1RFTV9UQUJMRSAqU3lzdGVtVGFibGUpDQo+ICt7DQo+ICsgICAgRUZJX1NUQVRVUyBzdGF0 dXM7DQo+ICsgICAgVUlOVE4gaW5mb19zaXplID0gMCwgbWFwX2tleSwgbWRlc2Nfc2l6ZTsNCj4g KyAgICB2b2lkICptZW1vcnlfbWFwID0gTlVMTDsNCj4gKyAgICBVSU5UMzIgdmVyOw0KPiArICAg IHVuc2lnbmVkIGludCBpOw0KPiArDQo+ICsgICAgZm9yICggOyA7ICkgew0KPiArICAgICAgICBz dGF0dXMgPSBlZmlfYnMtPkdldE1lbW9yeU1hcCgmaW5mb19zaXplLCBtZW1vcnlfbWFwLCAmbWFw X2tleSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJm1kZXNjX3Np emUsICZ2ZXIpOw0KPiArICAgICAgICBpZiAoIHN0YXR1cyA9PSBFRklfU1VDQ0VTUyAmJiBtZW1v cnlfbWFwICE9IE5VTEwgKQ0KPiArICAgICAgICAgICAgYnJlYWs7DQo+ICsgICAgICAgIGlmICgg c3RhdHVzID09IEVGSV9CVUZGRVJfVE9PX1NNQUxMIHx8IG1lbW9yeV9tYXAgPT0gTlVMTCApDQo+ ICsgICAgICAgIHsNCj4gKyAgICAgICAgICAgIGluZm9fc2l6ZSArPSA4ICogZWZpX21kZXNjX3Np emU7DQo+ICsgICAgICAgICAgICBpZiAoIG1lbW9yeV9tYXAgIT0gTlVMTCApDQo+ICsgICAgICAg ICAgICAgICAgZWZpX2JzLT5GcmVlUG9vbChtZW1vcnlfbWFwKTsNCj4gKyAgICAgICAgICAgIG1l bW9yeV9tYXAgPSBOVUxMOw0KPiArICAgICAgICAgICAgc3RhdHVzID0gZWZpX2JzLT5BbGxvY2F0 ZVBvb2woRWZpTG9hZGVyRGF0YSwgaW5mb19zaXplLCAmbWVtb3J5X21hcCk7DQo+ICsgICAgICAg ICAgICBpZiAoIHN0YXR1cyA9PSBFRklfU1VDQ0VTUyApDQo+ICsgICAgICAgICAgICAgICAgY29u dGludWU7DQo+ICsgICAgICAgICAgICBQcmludEVycihMIkNhbm5vdCBhbGxvY2F0ZSBtZW1vcnkg dG8gcmVsb2NhdGUgRVNSVFxyXG4iKTsNCj4gKyAgICAgICAgfQ0KPiArICAgICAgICBlbHNlDQo+ ICsgICAgICAgICAgICBQcmludEVycihMIkNhbm5vdCBvYnRhaW4gbWVtb3J5IG1hcCB0byByZWxv Y2F0ZSBFU1JUXHJcbiIpOw0KPiArICAgICAgICByZXR1cm47DQo+ICsgICAgfQ0KPiArDQo+ICsg ICAgLyogVHJ5IHRvIG9idGFpbiB0aGUgRVNSVC4gIEVycm9ycyBhcmUgbm90IGZhdGFsLiAqLw0K PiArICAgIGZvciAoIGkgPSAwOyBpIDwgaW5mb19zaXplOyBpICs9IGVmaV9tZGVzY19zaXplICkN Cj4gKyAgICB7DQo+ICsgICAgICAgIC8qDQo+ICsgICAgICAgICAqIEVTUlQgbmVlZHMgdG8gYmUg bW92ZWQgdG8gbWVtb3J5IG9mIHR5cGUgRWZpUnVudGltZVNlcnZpY2VzRGF0YQ0KPiArICAgICAg ICAgKiBzbyB0aGF0IHRoZSBtZW1vcnkgaXQgaXMgaW4gd2lsbCBub3QgYmUgdXNlZCBmb3Igb3Ro ZXIgcHVycG9zZXMuDQo+ICsgICAgICAgICAqLw0KPiArICAgICAgICB2b2lkICpuZXdfZXNydCA9 IE5VTEw7DQo+ICsgICAgICAgIHNpemVfdCBlc3J0X3NpemUgPSBnZXRfZXNydF9zaXplKGVmaV9t ZW1tYXAgKyBpKTsNCg0KLi4uIGEgTlVMTCBwb2ludGVyIGhlcmUuwqAgQW5kIHRoZSBvbmx5IHdh eSB0aGF0IGNvdWxkIGhhcHBlbiBpcyBpZg0KZWZpX21lbW1hcCBpcyBOVUxMLg0KDQpXaGljaCBw ZXJoYXBzIGlzbid0IHN1cnByaXNpbmcgYmVjYXVzZSBwcmVzdW1hYmx5IEFSTSBnZXRzIG1lbW9y eQ0KaW5mb3JtYXRpb24gZnJvbSB0aGUgRFQsIG5vdCBFRkk/DQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362107.592001 (Exim 4.92) (envelope-from ) id 1o92dc-0000dc-TH; Wed, 06 Jul 2022 10:52:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362107.592001; Wed, 06 Jul 2022 10:52:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92dc-0000dV-QN; Wed, 06 Jul 2022 10:52:08 +0000 Received: by outflank-mailman (input) for mailman id 362107; Wed, 06 Jul 2022 10:52:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92db-0000dP-Gc for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:52:07 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf0c005-fd19-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 12:52:05 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 339F45C00E8; Wed, 6 Jul 2022 06:52:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 06 Jul 2022 06:52:02 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 06:52:01 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf0c005-fd19-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657104722; x= 1657191122; bh=9c4hdoBeP2Q0FjUJjioREfh5qqdrnbT9BntwAOAyppI=; b=E U03QxCB7C8j7dUWQNfIUfo1SZmEVErpdDgpz4bbLKJNn63VcNJvO0mHytkRhzIcQ cUFp0xx+DOmCO4CZtOR3FI7dcC7XYqM8cI2KBozoSa9Jt2rjIDRGrO9rif9qxiou yW31wKldFBLwRmggATdGRv0E8460rDC17VaMvNzQlknHgqMX5GgYaHCtop1hZyob KmuhIzpFt19w9xwvLZPm2X2FAxX5i15Tt938nqRmHpI+3Zp/cGcZNCH2l7lxrQHL nW1olAkQz8ykTsKE0wLZwluX3+BeFbPOMAkXjqeOSPnJvm6o9RdVnTBLjoTZGxry HE6rCM+m+05tl8TS/ZGOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657104722; x=1657191122; bh=9c4hdoBeP2Q0FjUJjioREfh5qqdr nbT9BntwAOAyppI=; b=kHH8VuWLsIGJ2lcPAouGbXiZ18gBXtDJ577tKJrlddXo GtV1x+pcSzD9gH95DeZOjUdk7Wx+j6Ckn+nrMXFu6h5s3B/aFGKKv3sVl/oxggXs tbW1T0F0HunT7+zWsG6z0gWy1fjqWkJD3Fmm709206HlNWsRtShRZMvBOlYHLO7W fiJIK01fRbtfovhfOY6DTXD0AOVzmxQNZ7RxtfJdsKfBRanhnvFDOpdLH8VQnV12 HsSKSgJU6wmFafgqNhRyUtHhG/tC4yaeXfddtye3MbPwrkb2opkiLqB/O5cPh3GN vA6w8QUWSe2/rTHrpcclkqhyW1Gp1ZUKq7KOAgCQww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 6 Jul 2022 06:51:54 -0400 From: Demi Marie Obenour To: Andrew Cooper , Luca Fancellu Cc: Xen-devel , Jan Beulich , Julien Grall Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Message-ID: References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8hAxd1sWeykijlYZ" Content-Disposition: inline In-Reply-To: <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> --8hAxd1sWeykijlYZ Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Jul 2022 06:51:54 -0400 From: Demi Marie Obenour To: Andrew Cooper , Luca Fancellu Cc: Xen-devel , Jan Beulich , Julien Grall Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 On Wed, Jul 06, 2022 at 10:44:46AM +0000, Andrew Cooper wrote: > On 06/07/2022 11:32, Luca Fancellu wrote: > >> On 24 Jun 2022, at 19:17, Demi Marie Obenour wrote: > >> > >> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > >> index a25e1d29f1..f6f34aa816 100644 > >> --- a/xen/common/efi/boot.c > >> +++ b/xen/common/efi/boot.c > >> @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LOA= DED_IMAGE *loaded_image) > >> } > >> #endif > >> > >> +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; > >> + > >> +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) > >> +{ > >> + size_t available_len, len; > >> + const UINTN physical_start =3D desc->PhysicalStart; > > Hi, > > > > From my tests on an arm64 machine so far I can tell that desc is NULL h= ere, > > for this reason we have the problem. > > > > I=E2=80=99ll have a further look on the cause of this, but if you are f= aster than me you are > > welcome to give your opinion on that. >=20 > Given this observation, there's clearly ... >=20 > > @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS= _OUTPUT_PROTOCOL *gop, UINTN gop > > #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ > > (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) > > > > +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) > > +{ > > + EFI_STATUS status; > > + UINTN info_size =3D 0, map_key, mdesc_size; > > + void *memory_map =3D NULL; > > + UINT32 ver; > > + unsigned int i; > > + > > + for ( ; ; ) { > > + status =3D efi_bs->GetMemoryMap(&info_size, memory_map, &map_k= ey, > > + &mdesc_size, &ver); > > + if ( status =3D=3D EFI_SUCCESS && memory_map !=3D NULL ) > > + break; > > + if ( status =3D=3D EFI_BUFFER_TOO_SMALL || memory_map =3D=3D N= ULL ) > > + { > > + info_size +=3D 8 * efi_mdesc_size; > > + if ( memory_map !=3D NULL ) > > + efi_bs->FreePool(memory_map); > > + memory_map =3D NULL; > > + status =3D efi_bs->AllocatePool(EfiLoaderData, info_size, = &memory_map); > > + if ( status =3D=3D EFI_SUCCESS ) > > + continue; > > + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); > > + } > > + else > > + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); > > + return; > > + } > > + > > + /* Try to obtain the ESRT. Errors are not fatal. */ > > + for ( i =3D 0; i < info_size; i +=3D efi_mdesc_size ) > > + { > > + /* > > + * ESRT needs to be moved to memory of type EfiRuntimeServices= Data > > + * so that the memory it is in will not be used for other purp= oses. > > + */ > > + void *new_esrt =3D NULL; > > + size_t esrt_size =3D get_esrt_size(efi_memmap + i); >=20 > ... a NULL pointer here.=C2=A0 And the only way that could happen is if > efi_memmap is NULL. >=20 > Which perhaps isn't surprising because presumably ARM gets memory > information from the DT, not EFI? >=20 > ~Andrew Which in turn would explain why the problem is ARM-specific, and would mean that disabling this on ARM would solve the problem. --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --8hAxd1sWeykijlYZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLFaU8ACgkQsoi1X/+c IsHVYhAAg5WrGsuRxiWCx+8Z38t4ygs2nGk0jTI+pxeSQZrmW3Gotx3RPu43KHTH D9HavUqlXGHuYJsJoXVCg1D6FQpI5LMXNzul+YDL7AgHoTYb4qebr+LlZRLVc5Cl Zg8nK6X8efyKQu6Kzobt1FxCLfxTxt3vd5FxGSPiYt6k7w/Beig2N7d3MoGvjXpd hz1VK07YMOicrfkt7HfnndFJQyeR7YPFo5AIBR3QoJgN2o8Ml3wC8CwnvpJkWdVL nucD3MEjcz/VfGT95Z9Wna+Hbgf+XXYZxvG+KR9OAJjFyjHGYbMvy1mEODa5u2Ov uEUsxpgTybzKP+nQ6JFzf7TuXvebosMkB7rqBmnPA7dyQiOqsWt4SucqA9Tifenm jE8t7I3LlD5l/AAENica3K/gqhwCr8DHJTTMVWDgaoHcBIEZvGfzZioMAa1NvKZS okjAUI41puUp0tEEctt6Uzg6RAwU+Y/N86qX82jYrwC02/sl6dUj1AsbRTiUJHw2 iKLxLfBQHeP/7jlOa6JH3TTNio3fXwcwooy9R+vMcUfpCLcLxnrJzeIAygajwjAH Dg+YwDmNx1xzSmbw8+/1IA9BxaF+smQXXNo40y0Vb/fvTm5PgmsLVV8Rqwae+E/i TBax8sFf3vjxaT/0xPgFKQpvdsiTMIFA6pjbHAq+1o4S6DoMR8U= =Dium -----END PGP SIGNATURE----- --8hAxd1sWeykijlYZ-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:55:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362113.592011 (Exim 4.92) (envelope-from ) id 1o92hJ-0001El-Di; Wed, 06 Jul 2022 10:55:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362113.592011; Wed, 06 Jul 2022 10:55:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92hJ-0001Ee-B2; Wed, 06 Jul 2022 10:55:57 +0000 Received: by outflank-mailman (input) for mailman id 362113; Wed, 06 Jul 2022 10:55:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92hH-0001EX-PT for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:55:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 351372e0-fd1a-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 12:55:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7139.eurprd04.prod.outlook.com (2603:10a6:208:19d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 10:55:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 10:55:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 351372e0-fd1a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TajT2OS3ALG4V44oFEBoUGwNQ4uqbGPp/WVsI9sgX0BBTHvfBjtsvtOkZDbBHGNjjHmRH4LMlfmwg6oLr+dY3tvH1NHswabRDz5J45XlN6xgPBcCI2ZquErtKrxOFgVnF0sefoCvCjEH+Mm1240ZNa6Wf0zyUIn/7JA+7bKboiX6xkDOvQ4auvNbt5sdfBSouZH8MRH4DjhTDgzB2rPID0j0cNP5GqwmxR8H49O7kBtcAPt9OnXexCGgOZbROZcTPpvm1MJeEbDiFYcmKiIVjCoe441FreNadgqHaZvt7yz9b0qyw/pWaWzbYtPuMMEwCSsecU5NAa5O7iVVPC3V/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dy74e9UxsClQ34n9reJ3A7fRNsPSLVhBat+prWBIMnk=; b=erFt95chKKnFLLc4DsgC5dHFPTStOyIeggvnJMLsLLfJxmARnH0L7u+PBAfTG55x9+eCf3As31bGrRrLBBhsUPKgQ7Ke6WzyOu01rjHROzAPEzz14z/CiW7VzCThEEzMzJiQ5vzt4fMWDabQSzgX0OGC5Y6Aw6wNHlwaoXXS6N4C7yffIXssVvidC4YdvA1L/CFlD3Np2H+BcryY1D1rM4GcspNiOPnFvsvLN/2etjnfpYIr/qn3MP1B1MT72/zGCW9e7EiEwSmO1/xPP4TMIfCm1K/rXriaN6MoA6rTrWvJTw7Pumq1bESfWp2Q2vtY4d53YhtKEMdtGQmcNn1lgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dy74e9UxsClQ34n9reJ3A7fRNsPSLVhBat+prWBIMnk=; b=pIX7jnEcUQ2xXOuFiVkLI7hYqabQERR3S0GD1Aclr9/dD/L5A/pkBge/1Ac0AwHMIyZ4Qv0luPogLXyUAvti7aINR7TuXo5qBXBiepCVHTaCVi/C1wXRRHeUiYAx1sK+LfcUaPEjC8IGhJX+XIbRPFwP68c3nOIX7tde+HAYTMfhxH19QFqRq+oCjitth40TDplEd5tutwtMp7eonCOviTlKNZ/xyasMWAYGlRH5MFK6kkEYvPAAZe6O0yzj0pGq8qNY1F+T+Tnkw/ad7uPN+OF3xxAjgfG8dFfNm4ZM624S1NImzvreQ+BJgJuzTkTd4pyYn7UVochQYTiLAEu4RQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 12:55:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Andrew Cooper , Demi Marie Obenour Cc: Xen-devel , Julien Grall , Luca Fancellu References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> From: Jan Beulich In-Reply-To: <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P194CA0017.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: abfa91c2-c57d-49ec-ad3b-08da5f3e17ef X-MS-TrafficTypeDiagnostic: AM0PR04MB7139:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cxqRbac7TiYgCrpQfaqCiupCVfl6VQBVgAxyVPB9HDisrdFZc8IuablWOaph1qpaSNwSfsScUM/vIdbKBdnDZ18U+Oho1MYu0xiJYKUuDOXKDRiMiYXGy41HyiL6yKy+BR7BleCcJHAgUpb+vvQNhaR9j3r44JHrBiVel96cYCVNts/rLWD/V/H6ku/o8phOUGXdTPhRbxmGHwkS/zSuJ1Sz9uaa69p7q7tUEGuKMt6f0tgUm1UE01Iv1GaR9tJpE+mNIusgdCtcJbN+yjhPLFwQVzlMXvam3IdunLmyeK69BxeoV0zw9M2CcdnLDnVYr8awZ9Pz1F4/V5C4vUx4LlJW6RbgztQUjOgP/fR+VCfHOh853tAA6xvZs+6F4IqSSGeqdUp8/u3gTx8mN5K210o/dtOMqpx2UKv6BrLMVrMbJn1wDCWFz6SDSDTtY8ku3yF3D9+8ZS/e+5fFFDqeGOhLabQHmhx4HGll4njycnUr8WXKfNFNkjlDKAT3cHLLrlQsDxCNdbYqqugfIhQXixuo3jnLjOnBBG8vU5ifOTRa5quxg6NcMCA6iBXZLGqvhS38HHZLzSEBE9Cpvym+A6yNk74WfGw/0fQH7vrjA1bFtYEhTjUlJCZAY5SWlKWj4pApCNCYsl3KyonmlzxgyW+qKY+ZxxMo5z/c0622GZQ/XxgiaeE/EM6F5WCZmCEQ/sUpPZZAO/77bx2MnBXO6ND7ErxKJvPhYL9OonDXRYjL/cHzfEjSWr8RmmPw9lDIbiFVTiOKh/8e/l45XjhgdsumDrk3yt+e1YILZIToVTyMkP+QHfT5rzCnTxrOzG4ZPrf+XKm3gNv45L3Nxl/3svAN79AxSRKBl6NrGCdLpHs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(346002)(366004)(396003)(136003)(2906002)(41300700001)(2616005)(38100700002)(316002)(31686004)(36756003)(53546011)(110136005)(54906003)(6506007)(6512007)(66946007)(66556008)(66476007)(8676002)(4326008)(86362001)(31696002)(478600001)(186003)(26005)(6486002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N1NZOUFhbG9lR016bjNGZUl1RDd2QzFiam9lL1R6Zm91VXVseGNnNVh5bkRM?= =?utf-8?B?QnFhR014RUpUMzA0MzRHelh6NjlhWkN3eFNTNExpQ3JCWi9pOURRVVBQbGE1?= =?utf-8?B?UDdQOTB2bmJGN3ZlRHRTQW85RVo2OHJjN3lybXNyZFgxMC8wdTJsUWh1VndQ?= =?utf-8?B?YjNWVUk3S0RZTTdlNE1GVkJSbGhjdjBYN245SklWYjZmQXdJU3RiLzRlcmNq?= =?utf-8?B?TnVMNjU4OW1Xbm52Qzg4bU10L2IyWEJ3Uk52UXFRSlBQQWhzS1VXMGR6Y2N0?= =?utf-8?B?Z2JoMEFheWx5V3Q0Q1M3YS9KRXBYNzY5Mmx1dTZUNkVGMXF2ODRCbHNOWG5k?= =?utf-8?B?enFOQlZlcy85YnVTSk5pMXJqZGZoNzU0OC9oTnkyV3JaN3FDOHVrNTdlZ1FD?= =?utf-8?B?dXpveG9wWWl1dk5ucGN4QTBpN0hGT09WMmQydlc3cUg3MHBUMXBkVjVPM0hH?= =?utf-8?B?QmQ5MXdKZVBPTXpnRHI3ZEQvYnlzU0ttTWFvYTJrUm1jQXpxWkZaa1hGb2oy?= =?utf-8?B?emJPYjMwYjBNcHJzNjlObjNPUmlmTXhMS0NCZjdJVmJWUDhkazRTVGYycHlH?= =?utf-8?B?TnVuUG95VTFLRmZpeW94dG40OTFrS1VxM2JnU0pvejkyVW42N3BPRnhMNmU3?= =?utf-8?B?NUc2dmlaVWZYNXB2R2VlTjkyYTRNbUVDbDBzS1YyT0NJbmR1SlhRWGg2NHI5?= =?utf-8?B?c1hleUhrd0pKbWhyb2RmQm13U1FaRk5HMVJTRGUvZm5LSUx2TnV6dEllZUZQ?= =?utf-8?B?RjZaWXZBZ0xiYTdUYUU3ZTVtanBsZytFbEFPRldZd2o4T0NsTHdDZFVwbjVI?= =?utf-8?B?ZkE2ZlU4akRKanQ2Z3ZCclMzMFA3SU9FWkRITlcwT2h4Qml5Y2NkTUVQbEZu?= =?utf-8?B?OGEyZWtJZEhoM3hWRUs3aVB0SVBSY0N3WFgyL25NdVhMSlRjZWtRNllCVDYw?= =?utf-8?B?MmV1WE5UUUdmODMwU1hUOCsrdFdZK3Q2TklLMkp2a1hsS0d0UTFTL055dEF5?= =?utf-8?B?R24zSG14dXVsczJQL3NoTHg4SDZFbHdIc0IrR3NZTFozMzdXaEpuemhrL01a?= =?utf-8?B?NEpOTTI1Nm1MNVlYZmh2S3d5cGVQbDNHUEkyVmJNMFN6SWw3cnd0aTFWbUVY?= =?utf-8?B?T3ZoWVdxWVF4bFpmellxZmdJZVV6Y2t0OXkyRVVEUG1iVjBYMGtlcWFWd0pK?= =?utf-8?B?cDFRdzM5MWRDTFZIM2xXRTN2S2Qwa2RlaGNzVXdxVW9vS3RuMzNMRGZtejBN?= =?utf-8?B?K0k4S3ZncGFxTUxSOHZjWHRjM212ZGQyY2doMk5zTXhmaks1a2JlaVU3MjJ5?= =?utf-8?B?T2RPa3RsL3AvL2cwSDBWWG1SNXdJT1JCcmx5WDVVemppQVdUWElZbTVIbERa?= =?utf-8?B?dFhFekNlSDQxdUFXY29uYldLZ3ZlUHhLYkU2SXVHU0Y0MXVnSkdOS1lvcVpo?= =?utf-8?B?c0pGa2d0TmcrdzB4ZTQyenhWWHVnbjVDeFhsSDdLcjZwS21wSS81T0RvNGF5?= =?utf-8?B?MVZsbWgvZGdhbXlLL3A2aDBDMGdleXZkdEc0eUZnSDJTR2Q3dWozck1lbUpN?= =?utf-8?B?R1RVQUVuRzNxdGFYaDVGaUNYSldrRUNCc3N6K1U0Y3owajlnN3NCbU45Vi9q?= =?utf-8?B?UlZtR0F2eFNXWlgrYXRQMVY4R25haUE5TzBCcHBqNU5WSitnRlBjSVora3ha?= =?utf-8?B?NTZyT3plTmVEZjVlU25BcE9rNHNMY082dHBIaVJWSUVmM0QyekhmWnFGRVBU?= =?utf-8?B?c2hoT3lDWHJSTkFqeXkxZktIYzdmSFN3Qkc1bi9WU3VReEVpODN0SjRvaWhu?= =?utf-8?B?dFpZRXQxYmo4N0Foa2cyNjdkVUhRRUJrODFPNmxOMHRObkpCWk5oK2ZuVHlR?= =?utf-8?B?bWZoZ0d0MndadnMyN3FYNVRROEJSeldUQzVlYkZveGxuRzJoWSsrZFo3RFhn?= =?utf-8?B?T3YyRDM4ZGowSXMxTzZqTTNCM1V3TTZ3azZVZUFoSGZXMldKZXJWYmdlM3pa?= =?utf-8?B?OHJMUjF2M3JyczR2L1hsQ0JoNGIxYzc1TG9mbU9TeTFkMDZqVlpwWjlWNEo5?= =?utf-8?B?ZlowSVYzK0Z5dHluenNDNWdSR3Bad2huYTc1Tm9FVUhDRlR0OG1zbDFkNkov?= =?utf-8?Q?C0GMTwRZUUtWTMkFfSJKadvE/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: abfa91c2-c57d-49ec-ad3b-08da5f3e17ef X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:55:52.1790 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ft3Wh1tguH48DGGZwnNih6T8G5j6eLcKE3rYyhWsi0ysNB1eGmcpC3pfcBzu7YL6AjM+Lj4jn7t6TU1cXPr1cA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7139 On 06.07.2022 12:44, Andrew Cooper wrote: > On 06/07/2022 11:32, Luca Fancellu wrote: >>> On 24 Jun 2022, at 19:17, Demi Marie Obenour wrote: >>> >>> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c >>> index a25e1d29f1..f6f34aa816 100644 >>> --- a/xen/common/efi/boot.c >>> +++ b/xen/common/efi/boot.c >>> @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) >>> } >>> #endif >>> >>> +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR; >>> + >>> +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) >>> +{ >>> + size_t available_len, len; >>> + const UINTN physical_start = desc->PhysicalStart; >> Hi, >> >> From my tests on an arm64 machine so far I can tell that desc is NULL here, >> for this reason we have the problem. >> >> I’ll have a further look on the cause of this, but if you are faster than me you are >> welcome to give your opinion on that. > > Given this observation, there's clearly ... > >> @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop >> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ >> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) >> >> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) >> +{ >> + EFI_STATUS status; >> + UINTN info_size = 0, map_key, mdesc_size; >> + void *memory_map = NULL; >> + UINT32 ver; >> + unsigned int i; >> + >> + for ( ; ; ) { >> + status = efi_bs->GetMemoryMap(&info_size, memory_map, &map_key, >> + &mdesc_size, &ver); >> + if ( status == EFI_SUCCESS && memory_map != NULL ) >> + break; >> + if ( status == EFI_BUFFER_TOO_SMALL || memory_map == NULL ) >> + { >> + info_size += 8 * efi_mdesc_size; >> + if ( memory_map != NULL ) >> + efi_bs->FreePool(memory_map); >> + memory_map = NULL; >> + status = efi_bs->AllocatePool(EfiLoaderData, info_size, &memory_map); >> + if ( status == EFI_SUCCESS ) >> + continue; >> + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); >> + } >> + else >> + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); >> + return; >> + } >> + >> + /* Try to obtain the ESRT. Errors are not fatal. */ >> + for ( i = 0; i < info_size; i += efi_mdesc_size ) >> + { >> + /* >> + * ESRT needs to be moved to memory of type EfiRuntimeServicesData >> + * so that the memory it is in will not be used for other purposes. >> + */ >> + void *new_esrt = NULL; >> + size_t esrt_size = get_esrt_size(efi_memmap + i); > > ... a NULL pointer here.  And the only way that could happen is if > efi_memmap is NULL. Incomplete refactoring - this needs to be memory_map, not efi_memmap. Of course efi_mdesc_size also needs to be mdesc_size. Didn't check for further leftover from the earlier patch version. I'm going to revert the commit. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:58:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:58:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362119.592023 (Exim 4.92) (envelope-from ) id 1o92jX-00027U-Ps; Wed, 06 Jul 2022 10:58:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362119.592023; Wed, 06 Jul 2022 10:58:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92jX-00027N-N6; Wed, 06 Jul 2022 10:58:15 +0000 Received: by outflank-mailman (input) for mailman id 362119; Wed, 06 Jul 2022 10:58:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92jW-00027F-Qr for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:58:14 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87d08568-fd1a-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 12:58:13 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C80235C00D7; Wed, 6 Jul 2022 06:58:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 06 Jul 2022 06:58:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 06:58:12 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87d08568-fd1a-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657105092; x= 1657191492; bh=hIAYHdDG10sBEFuuNt2DnlsfYXNg/iIRj5NijnFQs8E=; b=q fQC6tVtxBUBWeAKjVGW9c7DEiKBOgyRRvYBNnT3pP+Qg/HJgITnrcbwIta4bQS0I omD9C0Iw0GzF0+8MjDf3PwAu/P/2u+8j37sAMssOErBkPA9QHxYBf6BFvFwM8Uvq 7f4lKW253DY/LLi9P1n3q5mpYGvO9EnpDj/hNkXtIjFXKh2q8mZwqC82lIIomHYr pc9CHWq9HsWvW3AcQgvZ65JQ7s45rvi+zLVNKSVSY8tEWoKuKlDC9JfJEKdQlQ8i dhlHvkq6+a3a6fQ3es2Sa3vlKxZY3jY0CVy3SBjcvPvbTNK0aMWsTrCHAg6Szrsm qT5EPWSOfrrSZho4gSw3w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657105092; x=1657191492; bh=hIAYHdDG10sBEFuuNt2DnlsfYXNg /iIRj5NijnFQs8E=; b=q/0/IngZmROthYJZITAfml8iU5fV4+OJDxNRQ9viojM7 zMSq6X5i7crlUkLcDgJctxsjLzQLwU7P0B1gEghZf4jvuw5ZNrUngFcWYDR6SUgL i4qOrq5XmkUnK64/iwef7j9D+VUAHpNa7Zx7vqOSpqRAsnbludFU+O+Zm1nJTXLS VljIDCkn3xNfbDwLI2a7aTLjTDsNJwcit0L3TA1GLynB8HoIbN7sx79vLIIsQRF8 eQwJIOnLhVNllE2EZUZ8jmpUUaSAnoVTaAKgo7uz/n0neChLDTapxpC+BcpobF4a d/9Iq3kCU0XXrrQVv34gRl+xPj3fM1s27RN7XEZ6ww== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgfeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepvdejteegkefhteduhffgteffgeff gfduvdfghfffieefieekkedtheegteehffelnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Wed, 6 Jul 2022 06:58:09 -0400 From: Demi Marie Obenour To: Jan Beulich , Andrew Cooper Cc: Xen-devel , Julien Grall , Luca Fancellu Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Message-ID: References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ct2p07v3Jt0Vg8Dz" Content-Disposition: inline In-Reply-To: --Ct2p07v3Jt0Vg8Dz Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 6 Jul 2022 06:58:09 -0400 From: Demi Marie Obenour To: Jan Beulich , Andrew Cooper Cc: Xen-devel , Julien Grall , Luca Fancellu Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 On Wed, Jul 06, 2022 at 12:55:50PM +0200, Jan Beulich wrote: > On 06.07.2022 12:44, Andrew Cooper wrote: > > On 06/07/2022 11:32, Luca Fancellu wrote: > >>> On 24 Jun 2022, at 19:17, Demi Marie Obenour wrote: > >>> > >>> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > >>> index a25e1d29f1..f6f34aa816 100644 > >>> --- a/xen/common/efi/boot.c > >>> +++ b/xen/common/efi/boot.c > >>> @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LO= ADED_IMAGE *loaded_image) > >>> } > >>> #endif > >>> > >>> +static UINTN __initdata esrt =3D EFI_INVALID_TABLE_ADDR; > >>> + > >>> +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) > >>> +{ > >>> + size_t available_len, len; > >>> + const UINTN physical_start =3D desc->PhysicalStart; > >> Hi, > >> > >> From my tests on an arm64 machine so far I can tell that desc is NULL = here, > >> for this reason we have the problem. > >> > >> I=E2=80=99ll have a further look on the cause of this, but if you are = faster than me you are > >> welcome to give your opinion on that. > >=20 > > Given this observation, there's clearly ... > >=20 > >> @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHIC= S_OUTPUT_PROTOCOL *gop, UINTN gop > >> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ > >> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) > >> > >> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) > >> +{ > >> + EFI_STATUS status; > >> + UINTN info_size =3D 0, map_key, mdesc_size; > >> + void *memory_map =3D NULL; > >> + UINT32 ver; > >> + unsigned int i; > >> + > >> + for ( ; ; ) { > >> + status =3D efi_bs->GetMemoryMap(&info_size, memory_map, &map_= key, > >> + &mdesc_size, &ver); > >> + if ( status =3D=3D EFI_SUCCESS && memory_map !=3D NULL ) > >> + break; > >> + if ( status =3D=3D EFI_BUFFER_TOO_SMALL || memory_map =3D=3D = NULL ) > >> + { > >> + info_size +=3D 8 * efi_mdesc_size; > >> + if ( memory_map !=3D NULL ) > >> + efi_bs->FreePool(memory_map); > >> + memory_map =3D NULL; > >> + status =3D efi_bs->AllocatePool(EfiLoaderData, info_size,= &memory_map); > >> + if ( status =3D=3D EFI_SUCCESS ) > >> + continue; > >> + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); > >> + } > >> + else > >> + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"= ); > >> + return; > >> + } > >> + > >> + /* Try to obtain the ESRT. Errors are not fatal. */ > >> + for ( i =3D 0; i < info_size; i +=3D efi_mdesc_size ) > >> + { > >> + /* > >> + * ESRT needs to be moved to memory of type EfiRuntimeService= sData > >> + * so that the memory it is in will not be used for other pur= poses. > >> + */ > >> + void *new_esrt =3D NULL; > >> + size_t esrt_size =3D get_esrt_size(efi_memmap + i); > >=20 > > ... a NULL pointer here.=C2=A0 And the only way that could happen is if > > efi_memmap is NULL. >=20 > Incomplete refactoring - this needs to be memory_map, not efi_memmap. > Of course efi_mdesc_size also needs to be mdesc_size. Didn't check > for further leftover from the earlier patch version. I'm going to > revert the commit. Sorry about that. Want me to submit a v9? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --Ct2p07v3Jt0Vg8Dz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLFasIACgkQsoi1X/+c IsG5iA/+JI7johb6M2AFFrTshQVWX55/gp8RfDq23nFiGazRzlkl7FJ7x/hODVms tEQUSg9C25fa/OhC969evu18JKxMPt3qwT+Qe6Zdr8uEYDCe4ooAdBQjXDOXoGV0 PB59ORNgO62IknxPmGoKAJ/ILsL/U1ZISZaoCZq1njZjoa5xHj2irzJlwGlKdRi+ 4Lcg5WTYDz7d8VISbMIghKFYBrWYGEy5LKTBc26x7RqSxFzyEpDw0xLEH6x3R3xB AZGwWFk8ibrDONQLz9XyeI4T7kbmIsxHlODo5H0yuq2jGF/814soP1I2PQ2j9+yF +2FBfDpVBYefaTcyVcekYyqfOy5F4/X1HJQVlE9zfNzuxn4Djil7VJBJZmwQbTmo VxlBTIE3pHOgskylb6M42EJ6ft3JI4UFh5Fojowc1gOl0OSLxF1nMaEuPtNp+v5s 7LEPdY6uOvsaoA0wk62YTkSTqnNPhomvHAxqnWhRv/RPngRGN9amUh6Nbu9a6rbn XIcpUXsWVRMW9/U4Cd3Tn96rhHoPdzF4w7l85pgQSA1e6cMwqLuMdpOxVIMuklPL Edgrb4XjkGtunMjz2DCICGsLrAUiDYTcHOdXY7mk/VQ2eSeqw/5dX0b4PpLJ8JFU jbCtxGNsG99+WgWV8is1hq8KE3ZJZPeJhdurghbRvwbK8klndAw= =lpY5 -----END PGP SIGNATURE----- --Ct2p07v3Jt0Vg8Dz-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:58:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:58:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362123.592034 (Exim 4.92) (envelope-from ) id 1o92k0-0002ea-75; Wed, 06 Jul 2022 10:58:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362123.592034; Wed, 06 Jul 2022 10:58:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92k0-0002eT-3F; Wed, 06 Jul 2022 10:58:44 +0000 Received: by outflank-mailman (input) for mailman id 362123; Wed, 06 Jul 2022 10:58:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92jz-0002da-98 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:58:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92jw-0007W8-Af; Wed, 06 Jul 2022 10:58:40 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.237.30]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o92jw-0007TO-3t; Wed, 06 Jul 2022 10:58:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=41lDwE4fRYoItaHaK38C4LPcEe8cBh+JJvNzeZiL42Q=; b=WYfLjAKxtvmtjHI63ABGsgSaVf 1iaI6rS0Vwuxjb/lnRBFWMXU5gb3N4gkYkOzDKcBBicDX8clKsqFuP3svfqpX96vAAKtnuuIdvLeE RjObtq+gfxbfZN9aVuRnPQpN9xxzA+PMt96y7fEbkBm/3ZsvRmlGAoKs6mf2gsInGaag=; Message-ID: <46080c06-0be5-da5c-3e30-5df6e84e2b86@xen.org> Date: Wed, 6 Jul 2022 11:58:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 To: Andrew Cooper , Luca Fancellu , Demi Marie Obenour Cc: Xen-devel , Jan Beulich References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> From: Julien Grall In-Reply-To: <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Andrew, On 06/07/2022 11:44, Andrew Cooper wrote: > On 06/07/2022 11:32, Luca Fancellu wrote: >> @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop >> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ >> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) >> >> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) >> +{ >> + EFI_STATUS status; >> + UINTN info_size = 0, map_key, mdesc_size; >> + void *memory_map = NULL; >> + UINT32 ver; >> + unsigned int i; >> + >> + for ( ; ; ) { >> + status = efi_bs->GetMemoryMap(&info_size, memory_map, &map_key, >> + &mdesc_size, &ver); >> + if ( status == EFI_SUCCESS && memory_map != NULL ) >> + break; >> + if ( status == EFI_BUFFER_TOO_SMALL || memory_map == NULL ) >> + { >> + info_size += 8 * efi_mdesc_size; >> + if ( memory_map != NULL ) >> + efi_bs->FreePool(memory_map); >> + memory_map = NULL; >> + status = efi_bs->AllocatePool(EfiLoaderData, info_size, &memory_map); >> + if ( status == EFI_SUCCESS ) >> + continue; >> + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); >> + } >> + else >> + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); >> + return; >> + } >> + >> + /* Try to obtain the ESRT. Errors are not fatal. */ >> + for ( i = 0; i < info_size; i += efi_mdesc_size ) >> + { >> + /* >> + * ESRT needs to be moved to memory of type EfiRuntimeServicesData >> + * so that the memory it is in will not be used for other purposes. >> + */ >> + void *new_esrt = NULL; >> + size_t esrt_size = get_esrt_size(efi_memmap + i); > > ... a NULL pointer here.  And the only way that could happen is if > efi_memmap is NULL. > > Which perhaps isn't surprising because presumably ARM gets memory > information from the DT, not EFI? We are always using the EFI memory map on Arm. The information from the DT used to be removed, but now kept just to get the NUMA information outside of the EFI stub. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 06 10:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 10:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362130.592045 (Exim 4.92) (envelope-from ) id 1o92kZ-0003H6-En; Wed, 06 Jul 2022 10:59:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362130.592045; Wed, 06 Jul 2022 10:59:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92kZ-0003Gz-C1; Wed, 06 Jul 2022 10:59:19 +0000 Received: by outflank-mailman (input) for mailman id 362130; Wed, 06 Jul 2022 10:59:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92kX-0002RD-Ma for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 10:59:17 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80040.outbound.protection.outlook.com [40.107.8.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad9b3746-fd1a-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 12:59:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7139.eurprd04.prod.outlook.com (2603:10a6:208:19d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Wed, 6 Jul 2022 10:59:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 10:59:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad9b3746-fd1a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7cDyus65AbztAygQsrO4QWOzoUHlyIGVyvah8tcvufbxxCl5iC9kaxTea0qfATvSaUZXHXGJNeGWulngHzwT66S/nxMoHWm/8D0gvOYNqn283xXqc4DJ+fia5WCNYaX6dX3KLdWdMp41iZCNxwN2ZvZeBWNmh4dW1NlM12g77izJ5wUwItZef8tGUw7EVcVshPV+J2rPUYggEhRdnoJNbB6v1NpTS43SInwFmzh+GwICwkFdYWHv4zk4c5+5kcUQFGYd3HzF7MAP8/p5gQLXl6IaAj7hn1klaGQh48W+nzLpaZAukLBEkXpbCDPnmXx/6UIDosD290fJjvniUK33A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5WSB1M4P3ugheaXogNqtwf3c7T+etBrYrVKxCBMoqzY=; b=JrGjl5Kb6XccLwdbGMzeUnDpql8YMR+8/kfNJtNxS4I9n9ni2/v2QKjzs3nOCTQEjaoWPTu3E+2BH9kjAgjdUBmCzemBy7D8QLPvVaBRm/z7nyhh8zyrO2IZV5F2pgmYMgAbYWW+j9hOCSepwwP7ACjXoI5qTHsNhDZainwCVf9N3ylpRcDg3yKX3dNIILFC0CiJDRVtiRJY2g8aSmLZrDEk+fxZXDDi4c4bZzznQvd03tecZiWDp7MCr/mKDb0wXPYeG+Yb55sTiJnO98XZbqJOPVJFCFs/eO4lvIeNUZ+YzSyvm4leHM6qufaAJeM5dnpkqV3zxsfqTUZ3+rfPsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5WSB1M4P3ugheaXogNqtwf3c7T+etBrYrVKxCBMoqzY=; b=DYP4H48W/w2oebJ4ebJmBDC2sELZQyEsLCzUXIi+iceXr+S4CAeQ9GzCL6qsGcHhI/bFD0QmGp61EgoLih2OIbw84J22P6eEpbUJ1bpKEzsqM/ScENgfc+vDv9Sd8gHvT3DDyUdpg7Shl648EqXAi4JZ6d8BJY0ATMA8EJdSrSlFMIe5QUVysgZ4URZnnt9iUPPAyLKc0UwRmbYTIuCJ6VJp6OBVZUVbSmKD14vai3qvOAbI5JhjLD1eJSZUsIc0KzKOt5ux6eZh+3dy/Zb93rpvATzGKnqgVgwERwqE4Qr6VbxNW102nej/1YKS/BWLGAkLShdLNTNQEvaT1e5QFw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 6 Jul 2022 12:59:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour Cc: Xen-devel , Julien Grall , Luca Fancellu , Andrew Cooper References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0001.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb148bbe-3998-4f83-4bcf-08da5f3e9139 X-MS-TrafficTypeDiagnostic: AM0PR04MB7139:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CsJ9qGnjbjC19c976zP+ICUszJpLR/0IvdBet3SdKCDPV0VeLbFGebkhJCukksjzzqXxh8d07jQVGSJtTXUDrr8tfybrMNuOZ3/QupCiMyU7s40xmr8JGf2FRzjJQCAEszMjCNT5QbG8EJsuGtQ1I1cdl+fkJ0t45sdq4ZOd0co8Tm70yt2CfVqd9K2iGQPQ/BOm/hGSg6+SzvfWfjyM4TWcJRWnvVyaQ9ggpxuHG3jPf1k5zJL8+Toa2ULhyHzgl7FFx3alUw5t2e9XhBmzZyH93Qh5dyXws/NzBc8ztixhVH4Jys0+ol2RvnIIkECAtV9g46bWftcJJI08msl1LOrQI7XMEQAbSD92vr3MRWL8bEKUhpJws867Sr7iRJY1YIrzgeo4+HEqahyHZxAG/oLyiiklEDxcD+ndArTvznBqfRdsAxUftUnFNl5axGEnfozFbplxPwByIW0DO24G+KHDubbXkZWfAQO+NcxVhvG5WwHD3HxbNqMHrCFu6FYYL45Ze6+5oZ9/mDx4d5RvfeMfcVlXP1Y0y9v1N2d2oLs+mYw1TZ15dyQCsvLLMIC2gK7LPePMILqlrNDvbXWSTsXNaUBn+3hG7PbrX6wJH72EY2dTBmKJHuMuMaU5ZozlFCsyDnSlFv61rZDzdJr2uO4XMtvoZ8NsM2r7/URVVBeCjIzb4mt5UqnIfsv4gq9/IzBEkJcqEJSKtJ62q2qdOr4PwXOCEfSskhJvZ1SPGB3NOVDMQK2N2QHD38KM5GBPHPBZqkvgpzotVmCkijv51huI0QASMr3W7p0YIgOLwh0GyB78Bjz8UhHkUMsuhM1DGWxaVsBGUwXM2q/yyZ69iOgV/BgId+QjnUP6LUeJYiI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(346002)(366004)(396003)(136003)(2906002)(41300700001)(2616005)(38100700002)(316002)(31686004)(36756003)(53546011)(54906003)(6916009)(6506007)(6512007)(66946007)(66556008)(66476007)(8676002)(4326008)(86362001)(31696002)(478600001)(186003)(83380400001)(26005)(6486002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QTBLN3lJd3h6VWZqYWRxUFYzL2NaSzdzdUx0Y2paRmRqMWpoM01pcFRjdE41?= =?utf-8?B?NVNLbWd3MGFja0xDNkxjcWE5QStYcjcrTisra3lVV2g0aFJrWkoxdTJ0R3Fi?= =?utf-8?B?bWxYVmYxalNqSlZhb3J4a0Q5ZFJHWTRseitGdjF1YTNjNVI4ZU1kdHJUcUVM?= =?utf-8?B?ODNhSit0LzYrWXNJQVBaRWMwNHA2dXJTWkVJWU9WRWJWanNlOXpmdjRqTzFT?= =?utf-8?B?eTJVajdXc2ozQlQxUjhWR0FGL0p3em55UGJCemtPTDZxYWlHaWRlUVBxc0Ex?= =?utf-8?B?NTlLR09xd2xBdFhpRmxuT0ZMQlJzdkNBUUxVOXJoSWJNNFJlVmx6UHJ0STdp?= =?utf-8?B?cjJHOVdkU1dDdjcxQXRZam9Sd0lUaW9vRG5sdXVZUlBybGxsRmVSUFUvVWRh?= =?utf-8?B?N05malZsWXNGbWk3TUthd3hXdW9pMXptQ09mSS95RU0zTTlwem5vMTFDRGdk?= =?utf-8?B?bzBrbjJ0WnBib3g4MzdNQ3QwZXF3UmhvRkhZZVk5WWYvblpIblR1MVB6YmxG?= =?utf-8?B?TTRxbmlVTzhXZ2pTU01oTG1NVFpvWjk5WGhiWXVmVnhUU3hyQVhwRVBITzRx?= =?utf-8?B?SXdtSnc0WEFmY1BkVEltQmpITDZQNDUvbHhRVEQ3ZnQrVVU4bzQ3QUxmS3FO?= =?utf-8?B?MGtXREFBT0VUWEVnQ25QZUVXWkhVUTd4UHdXY085bm9iUGFCU3YzemYreDQx?= =?utf-8?B?ZXJ3bmozMTZwVkxKR0VGdDRESWk1U0pWRnRIcHUwTXZHdi9PNEcremd3Y0M2?= =?utf-8?B?clN3ak5FcDlIbFZ2Q09EQnpMOW1iRkkvTnRyTHcrYWk4VjFJTitoZW0yZS9M?= =?utf-8?B?TGc2N2JWL2tvaHlQZ0Z3OFJTMTYyRjJwKzhib1J6RlhDT0FmSlpRajNrazZv?= =?utf-8?B?VUJ3V0RUZzFwcGV5TkRmMlg5ZlE0elh6WWtsV2dxVE5iUW40MXk0cmR1VTdh?= =?utf-8?B?RmxtUFdoNDFmTzFMZmhtYzVxbDJraG8zYW9hZXpTa05qS1dMblozSkNFNnFr?= =?utf-8?B?eFR4RDcxakI2TDZrcXUrL0lLYlh2dnlrZ2p0UFFmQVNxUHAzNWpPQW8zT0tM?= =?utf-8?B?SEovN1VPWXFGcmZENWVGdDloWk1PK2VTMHpBZHQwMTNvUHk5bms0ai9GT05u?= =?utf-8?B?WWtZSDhHc2JHa1hlcnpNbytrM29HMnRMbzh3SUxTR2UwMlRtSC9lNDI1WVpQ?= =?utf-8?B?NWk0M2JuK1ZaMmYwU2I2UXhTUUhKd3VLNlBQUzEzUll2dmxnWFdaOGdlMEVX?= =?utf-8?B?WlQ3QjJwTmpVUURsRnVlalRlOWd6SmZuY3NpcCt5ViswUEVaenMrMUQ2ekZX?= =?utf-8?B?bm1ZRzFRNUhnS2RmSHE0U0hCNXQ0d1M2eXZoNnNCWHZTbUUrNHY1alRPcWUr?= =?utf-8?B?d1BabGUwM1pGWGlSR1VVbEoyUUJuQ2ZmK0EwTlZIWkxHbXdYNEs4bTVoekZn?= =?utf-8?B?MUlBTWVPNnQ0M2Z1bllxcEZuUFhZeVkySDdpNDNBbmZQZndmTDhlVE5LS1BZ?= =?utf-8?B?RWJKbVhPUFdLRk10THVKa2s3WkJFZ0pKV1l2ZzdYbGR3QVdDSndJVFJjUFla?= =?utf-8?B?RzF4T0ExbWJKcExRSzd5N0VFbDh3V09yRldmZ2Z4NURFWDNkVmFBNjUwaTFS?= =?utf-8?B?T3JMMHZSNVRzZnBMQkdESFVqbHZOd2ZhMGNNNDZSZklMTnExNWlqa1QveGVD?= =?utf-8?B?aFRxQ0tpWlBLMU9QRHpnSDVldVo0T3crUnRMT0xjMm1GRlZCRUk5U2NMTzJh?= =?utf-8?B?Ly8rM2lDRnY2Nm0yZlduTEIxZVFYbzNiVmthbjdxaStNaUZPUmQreTNmRmlZ?= =?utf-8?B?b0Y5elhkWEg2a3htRmp1UmprNHYrOVYycE8vQk9DNXZKdm52b1oyK0NtUFNX?= =?utf-8?B?MkR6WGtKVktLVXh6WFBHVUZJb1N2dDhydTNwYlBtTXpIbWk2MkdjUHNpY29V?= =?utf-8?B?a1JnNFd6MmZsaUtMM05YVnp2NGx6ais5VWVoRU8wd2dCTXQ1ckk0WUFJNnMv?= =?utf-8?B?UGJrZEhZTHVVSGFIN2FZYkY4SFNFbFViT3RaTmIycFh5bmFVU2g2SnZrcGJY?= =?utf-8?B?VjFJRkNXVTZWMTZJRzV0eG91WWx2Y0pXYW1Ubm9EbURESzFSRVpwcGozZmtz?= =?utf-8?Q?ZVQ+OMdUbV/hbi6iV/URDFAqf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb148bbe-3998-4f83-4bcf-08da5f3e9139 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 10:59:15.6502 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mjnL9SPf3HIQFHyi+b4m1hr/YFLTmEaLbNX9nGXMvE+KYKMc1IZHNKze3bFsd0HKVzUfy5dgnns3jl39SEgD2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7139 On 06.07.2022 12:58, Demi Marie Obenour wrote: > On Wed, Jul 06, 2022 at 12:55:50PM +0200, Jan Beulich wrote: >> On 06.07.2022 12:44, Andrew Cooper wrote: >>> On 06/07/2022 11:32, Luca Fancellu wrote: >>>>> On 24 Jun 2022, at 19:17, Demi Marie Obenour wrote: >>>>> >>>>> diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c >>>>> index a25e1d29f1..f6f34aa816 100644 >>>>> --- a/xen/common/efi/boot.c >>>>> +++ b/xen/common/efi/boot.c >>>>> @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) >>>>> } >>>>> #endif >>>>> >>>>> +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR; >>>>> + >>>>> +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) >>>>> +{ >>>>> + size_t available_len, len; >>>>> + const UINTN physical_start = desc->PhysicalStart; >>>> Hi, >>>> >>>> From my tests on an arm64 machine so far I can tell that desc is NULL here, >>>> for this reason we have the problem. >>>> >>>> I’ll have a further look on the cause of this, but if you are faster than me you are >>>> welcome to give your opinion on that. >>> >>> Given this observation, there's clearly ... >>> >>>> @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop >>>> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ >>>> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) >>>> >>>> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) >>>> +{ >>>> + EFI_STATUS status; >>>> + UINTN info_size = 0, map_key, mdesc_size; >>>> + void *memory_map = NULL; >>>> + UINT32 ver; >>>> + unsigned int i; >>>> + >>>> + for ( ; ; ) { >>>> + status = efi_bs->GetMemoryMap(&info_size, memory_map, &map_key, >>>> + &mdesc_size, &ver); >>>> + if ( status == EFI_SUCCESS && memory_map != NULL ) >>>> + break; >>>> + if ( status == EFI_BUFFER_TOO_SMALL || memory_map == NULL ) >>>> + { >>>> + info_size += 8 * efi_mdesc_size; >>>> + if ( memory_map != NULL ) >>>> + efi_bs->FreePool(memory_map); >>>> + memory_map = NULL; >>>> + status = efi_bs->AllocatePool(EfiLoaderData, info_size, &memory_map); >>>> + if ( status == EFI_SUCCESS ) >>>> + continue; >>>> + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); >>>> + } >>>> + else >>>> + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); >>>> + return; >>>> + } >>>> + >>>> + /* Try to obtain the ESRT. Errors are not fatal. */ >>>> + for ( i = 0; i < info_size; i += efi_mdesc_size ) >>>> + { >>>> + /* >>>> + * ESRT needs to be moved to memory of type EfiRuntimeServicesData >>>> + * so that the memory it is in will not be used for other purposes. >>>> + */ >>>> + void *new_esrt = NULL; >>>> + size_t esrt_size = get_esrt_size(efi_memmap + i); >>> >>> ... a NULL pointer here.  And the only way that could happen is if >>> efi_memmap is NULL. >> >> Incomplete refactoring - this needs to be memory_map, not efi_memmap. >> Of course efi_mdesc_size also needs to be mdesc_size. Didn't check >> for further leftover from the earlier patch version. I'm going to >> revert the commit. > > Sorry about that. Want me to submit a v9? Yes please. And please make sure you have tested this at least on x86. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:02:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:02:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362139.592055 (Exim 4.92) (envelope-from ) id 1o92nG-0004m9-U4; Wed, 06 Jul 2022 11:02:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362139.592055; Wed, 06 Jul 2022 11:02:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92nG-0004m2-R2; Wed, 06 Jul 2022 11:02:06 +0000 Received: by outflank-mailman (input) for mailman id 362139; Wed, 06 Jul 2022 11:02:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92nE-0004ls-Qb for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:02:05 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10040.outbound.protection.outlook.com [40.107.1.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 102ae7ee-fd1b-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 13:02:02 +0200 (CEST) Received: from AM6PR10CA0005.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::18) by PR3PR08MB5851.eurprd08.prod.outlook.com (2603:10a6:102:85::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 11:02:00 +0000 Received: from VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::ff) by AM6PR10CA0005.outlook.office365.com (2603:10a6:209:89::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Wed, 6 Jul 2022 11:01:59 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT003.mail.protection.outlook.com (10.152.18.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 11:01:58 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 11:01:58 +0000 Received: from 0fd366654a94.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2E189583-7E83-45C0-9AD3-22136D48E21C.1; Wed, 06 Jul 2022 11:01:52 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0fd366654a94.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 11:01:52 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DU0PR08MB7993.eurprd08.prod.outlook.com (2603:10a6:10:3e0::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 11:01:50 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.015; Wed, 6 Jul 2022 11:01:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 102ae7ee-fd1b-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hEgmOs+me5WpT3CZBTYkf6oVrHKkYspJ/k6ZVfmNKOEkIvosRmnjPER3XoUAQPO15dxTcnA6CFeGKhTmIFJrv+BCjvYC5v76UYiWSpJvUJWiQF1XGJeSRGvzeC299B20jEDc1gy5IBgZSVkXC7EUTzCOEZvk8dHEcNVQJpreMm2WWDuQT/Rg2dtbDszh9+qG42dLBK8tMQBa6LEZaqvsMg0rG6mAnjk+2nm5O/R10wIGo76rt4dsPM3IOvItEqemdxWLxvIlyoMdKIyTwmyIL58hAZd4QrzoiebamdijsxPzlaR+qLoZOeYP+cpHm9JDvbkeEFsoLxiqbUj4CXSWzA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+AHvB7ins89WpfSqIps/7lJFHP4PZk57CUcJRupgc2I=; b=m4bho4/cW7Hy85Ipu38ZFh/mHek/4qsaRSpmx+YoLmiy00Wuy6f8jNRdPpUM/gy9pohhQ23YpBMNlCo1q7dQJDj/JtdDYDy6uOUR4E6vggXOJ5DmVbyHVxSk5sHPuD3L3kugJV1EWjpl7NlJ8pfFMSYtykZRN/Oiu85Qbi6VcvtIZdwo7wkVNBToF3R8wWDlZlGPSbx4Uavic0ehVd9Alsq39gg54Sptx4JEjrs+l1qfyBTGqj201gJTKSvFHkFgD7j+dxwdCVrYnHSXudaS+yO3HXQRdehLCcw4i5u9/ia1huG2pUnPoN2RLa1eTirhrhg/EtwIOiUYIG4+mYzYDw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+AHvB7ins89WpfSqIps/7lJFHP4PZk57CUcJRupgc2I=; b=g8uBvh8eGuB4TGgmg+MyFIqJsjSSqsHGbw9z4kQn0wCm43SqTh0RWanGDkkuh+0lePYpAIASVnFq+Uj9z2zqcrK8SHfcL3hUFIgZBXwCZ1yTtYOH589sUCkeb1Rj426bT/5XDFRfQ+c6Qger6mZvzDl5SSPxUnU/g+Rba/9ZMoQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1c3dd1468fb7c9c5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hywtD6nEgcylpZqD6oGREErU+sz7UcAVtZW0Eu2DpAsF1N+GsS180WT8RjGrYlAwLziaYbiypmHpuNU9e41/5TNhdHUmv7CmX/V6bqWu8PE9axKE0IhzV340yIcVyZp7vMgE+ScBYRCPhSB11tfUO2ogQm/PGmj6gUYryXd8kb3gmy4qlRMdyFw90WnM6GT1ig24w7C9DAMuvtxJTJjvzOYBcRFH+rlPngsHObkOE6ILvDo87lLY+OEvhwZWWg3E6F0Cz3UxwoOC+1VA8CuPvGTsjG6hLdTI5OCOxMTNlkgS6Kdhk6+uyzqj0gW/BMRbNSMrfbxuK2Z0RGdWCFYskA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+AHvB7ins89WpfSqIps/7lJFHP4PZk57CUcJRupgc2I=; b=N7fmR1evGdbNstwaHW4j9ryUK0pi7FTiwBIzV9HiI32sJwpJ+F8lBfJLOorzXqraFBXu4/f2pi78pbvc8wRbSwwNVIIDLtPLCwDNpWeh649C7/Er+hvb/qs4twgQLGwYCMxkTT65bCiL32reezhF1yESvnTh2sPEwogHCErBXsxST9zNx0Xugs5IeNkpmO8icBJzTQXKCtfMPJoDu4S5mBq8djzt5rK0r2enwSgDmfGsii3zCsiSVNGBNSAahh6b6z9vkx1fWn5mPds9Y3NgsSkfM2oM0OuaFbYXKBLKry5dxd/31g/l8B4XnkMEB5c5GgVt8k97fC0GYy0u4vxToA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+AHvB7ins89WpfSqIps/7lJFHP4PZk57CUcJRupgc2I=; b=g8uBvh8eGuB4TGgmg+MyFIqJsjSSqsHGbw9z4kQn0wCm43SqTh0RWanGDkkuh+0lePYpAIASVnFq+Uj9z2zqcrK8SHfcL3hUFIgZBXwCZ1yTtYOH589sUCkeb1Rj426bT/5XDFRfQ+c6Qger6mZvzDl5SSPxUnU/g+Rba/9ZMoQ= From: Luca Fancellu To: Demi Marie Obenour CC: Xen-devel , Julien Grall , Andrew Cooper , Jan Beulich Subject: Re: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Topic: [PATCH v8] Preserve the EFI System Resource Table for dom0 Thread-Index: AQHYh/bQ1tgd5TeBbEyn28hq3tAw6K1xN30AgAADZgCAAAMXAIAAAKaAgAAATICAAAC6gA== Date: Wed, 6 Jul 2022 11:01:50 +0000 Message-ID: References: <7f773ea8d3967fc3dd2a485384a852c006fd82b9.1656093756.git.demi@invisiblethingslab.com> <863733AF-212D-4059-B780-3DDC0AC58FD7@arm.com> <19e001c3-fb66-2306-1e63-578239e91ad3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 31f9f0dd-a32c-4a55-3f53-08da5f3ef281 x-ms-traffictypediagnostic: DU0PR08MB7993:EE_|VE1EUR03FT003:EE_|PR3PR08MB5851:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: X3wP3fmgpP2qBWv12jdvhqe2DRCj1Xj+yapR4fWTmxnfZ3HjoZThq4AePSGmMn/E/a8/TK3uSdpPvCB0RXsemhmPO3lqxtyz1WU+0Y/vjfEYjt2y2M1872Vgop+5V+i4gH4SyR1+Lfnj7OS2EZ8PJ4Hjld5ozhjaEzo02EKLMvDBZ1EeqHrFAmJwrviy3kLahh8BxId0yw2Mtt88V4c/CGCTxjqIDcdTOcwTOdJL438GmGHVi0PUyJ/tSG6TYIUPOlXG7bhYNLFkQeEq9dgYffvud5wa5yGXGpEF1q8RduAGauZu4RzTEtod92SY6PXg/cgAn+SeEyCYbx7I4llMo7gY63u8LEP1J5Alzn96R4IE3Sn+z1lzDEIPXTx1IaHKESsdDnLkurYhBSUEBOdD0RihvSdRI9PijjXZiXS4IVpDU3NY8nz/psRlrN/57NUD+I1ktTZ+bLGYLfDh9Cg8Ty9BwvUwFVhqJ54Z6/1/Z0AxPQqBEWr7kcqV9WkmcNCHOlbqquMqqMIznGJJ/dA0uTGUiOhuqnuSxJJtYf9fA9iutnr3AEx1p6XAG5jSsPGb3D4o3CiNQzCs6Kpyma0lXoPTGnasftxN7KiLS8cKixkWVvJQgqNVfIeo2ozl4j6t/j3NEpHP2YrB+3ETrMQ7F45F0xPorMc42eJjrYJxIhippYcKuKwPwVz+96XByrvUKh2Dc5VQ487kaKvlIqt0RYQlGR3M0VKHLdiVtbBhOm77D0iLKzFJuDxwaRGWLXm4wIbwhrU5it26IT/Hxexgt585R2mV9HAM4U5kzFr5OZ0SJIkLGagmj0roHJ0kacqa6k8Bp+xOJ1vQZRUOG2fbxlVrUGWkeqgtEKtC3coTGwM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(39860400002)(136003)(396003)(346002)(66556008)(91956017)(66946007)(64756008)(66446008)(66476007)(76116006)(8676002)(2906002)(33656002)(4326008)(6916009)(86362001)(5660300002)(8936002)(316002)(36756003)(53546011)(26005)(83380400001)(38100700002)(41300700001)(71200400001)(478600001)(6486002)(6512007)(6506007)(54906003)(186003)(38070700005)(2616005)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <7BD8179C14824149B0D6908C47E870F6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7993 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 02cf9a29-840e-41f6-173d-08da5f3eed67 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qMRwZShj/+nYoEBZ/VrKcMW3usJ/oLCCa/PHk074f9BjtJgSv/ZmpzuuFgqOaxpGDANPG405iiagQKwAIDyrgDnGE1lULFXBJaoHW7I3UWAgYl8lQyCZtDn4GoP3BnN5DwYDWE1wFzWXqb0EyiRBIFHyPouylXes0ihMMb3K0m/c163gk34itGkpjaIjtQzjLwMDVSJKMg8vFwHZ81xmGnElwvoFUsa3HOhUtvMUTrbza7aF07MKB4CFvawY/wcQJFGIBHKO68HqBccRZQI3KQtHzcdN/n2YlIhwYz4MaywJi2GyW6rjDLr40KeTDlHVcyAlsowtraJsNf+mEF0BrVVd6rXZnjO+UF/Vp2Ay5/Y6sI7bH87uEQtDD8zkhwDwMdQqRKYWw+RiUsFIXx1MEoTE+EzKGMNABPLU209KDoZF1QT3TJtK73bD7VSYtGBNHDYmYN4OkRIhYNwQZmyg8KXVNeg2bnZq7L02csqlHS4rvEBBXOxeGyvimsq2OhJtSn544XCPXVHdPOR6GUtIha4q+7zmAz+odLn7U/6q9fFamshTt0ecKf+eLoxXA1WzQKbX5MJQoXiGqM+prtQplLkXpgkVOEe2NOBScLxQ3meZBxgLKAppPA8btpnqZyVke+S/46SL6dC7iEOQJfavMXNDF2JWWElK72roSvbm9qdeL0hkaQHY2+O64kJ0EB6Iv/A1MFSXm4MPuydnSq7wcLHP4e3BqnnZerTNGJZZ1DNTFH5rs50gBMjpQbw0Bq88ORMih1YUkfCgKsQl+48CDhAU08vCkKc4Dxpb8QrYAMJB+LgCstd2t5upCeutaST7 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(136003)(376002)(40470700004)(36840700001)(46966006)(107886003)(82310400005)(336012)(47076005)(83380400001)(186003)(70586007)(81166007)(40480700001)(82740400003)(40460700003)(41300700001)(36860700001)(53546011)(316002)(54906003)(6862004)(6486002)(6512007)(2906002)(478600001)(2616005)(8676002)(86362001)(4326008)(8936002)(356005)(5660300002)(70206006)(6506007)(26005)(36756003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 11:01:58.5951 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31f9f0dd-a32c-4a55-3f53-08da5f3ef281 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT003.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5851 DQoNCj4gT24gNiBKdWwgMjAyMiwgYXQgMTE6NTksIEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNl LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiAwNi4wNy4yMDIyIDEyOjU4LCBEZW1pIE1hcmllIE9iZW5v dXIgd3JvdGU6DQo+PiBPbiBXZWQsIEp1bCAwNiwgMjAyMiBhdCAxMjo1NTo1MFBNICswMjAwLCBK YW4gQmV1bGljaCB3cm90ZToNCj4+PiBPbiAwNi4wNy4yMDIyIDEyOjQ0LCBBbmRyZXcgQ29vcGVy IHdyb3RlOg0KPj4+PiBPbiAwNi8wNy8yMDIyIDExOjMyLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0K Pj4+Pj4+IE9uIDI0IEp1biAyMDIyLCBhdCAxOToxNywgRGVtaSBNYXJpZSBPYmVub3VyIDxkZW1p QGludmlzaWJsZXRoaW5nc2xhYi5jb20+IHdyb3RlOg0KPj4+Pj4+IA0KPj4+Pj4+IGRpZmYgLS1n aXQgYS94ZW4vY29tbW9uL2VmaS9ib290LmMgYi94ZW4vY29tbW9uL2VmaS9ib290LmMNCj4+Pj4+ PiBpbmRleCBhMjVlMWQyOWYxLi5mNmYzNGFhODE2IDEwMDY0NA0KPj4+Pj4+IC0tLSBhL3hlbi9j b21tb24vZWZpL2Jvb3QuYw0KPj4+Pj4+ICsrKyBiL3hlbi9jb21tb24vZWZpL2Jvb3QuYw0KPj4+ Pj4+IEBAIC01NjcsNiArNTg3LDQxIEBAIHN0YXRpYyBpbnQgX19pbml0IGVmaV9jaGVja19kdF9i b290KGNvbnN0IEVGSV9MT0FERURfSU1BR0UgKmxvYWRlZF9pbWFnZSkNCj4+Pj4+PiB9DQo+Pj4+ Pj4gI2VuZGlmDQo+Pj4+Pj4gDQo+Pj4+Pj4gK3N0YXRpYyBVSU5UTiBfX2luaXRkYXRhIGVzcnQg PSBFRklfSU5WQUxJRF9UQUJMRV9BRERSOw0KPj4+Pj4+ICsNCj4+Pj4+PiArc3RhdGljIHNpemVf dCBfX2luaXQgZ2V0X2VzcnRfc2l6ZShjb25zdCBFRklfTUVNT1JZX0RFU0NSSVBUT1IgKmRlc2Mp DQo+Pj4+Pj4gK3sNCj4+Pj4+PiArIHNpemVfdCBhdmFpbGFibGVfbGVuLCBsZW47DQo+Pj4+Pj4g KyBjb25zdCBVSU5UTiBwaHlzaWNhbF9zdGFydCA9IGRlc2MtPlBoeXNpY2FsU3RhcnQ7DQo+Pj4+ PiBIaSwNCj4+Pj4+IA0KPj4+Pj4gRnJvbSBteSB0ZXN0cyBvbiBhbiBhcm02NCBtYWNoaW5lIHNv IGZhciBJIGNhbiB0ZWxsIHRoYXQgZGVzYyBpcyBOVUxMIGhlcmUsDQo+Pj4+PiBmb3IgdGhpcyBy ZWFzb24gd2UgaGF2ZSB0aGUgcHJvYmxlbS4NCj4+Pj4+IA0KPj4+Pj4gSeKAmWxsIGhhdmUgYSBm dXJ0aGVyIGxvb2sgb24gdGhlIGNhdXNlIG9mIHRoaXMsIGJ1dCBpZiB5b3UgYXJlIGZhc3RlciB0 aGFuIG1lIHlvdSBhcmUNCj4+Pj4+IHdlbGNvbWUgdG8gZ2l2ZSB5b3VyIG9waW5pb24gb24gdGhh dC4NCj4+Pj4gDQo+Pj4+IEdpdmVuIHRoaXMgb2JzZXJ2YXRpb24sIHRoZXJlJ3MgY2xlYXJseSAu Li4NCj4+Pj4gDQo+Pj4+PiBAQCAtMTA1MSw2ICsxMTEwLDcwIEBAIHN0YXRpYyB2b2lkIF9faW5p dCBlZmlfc2V0X2dvcF9tb2RlKEVGSV9HUkFQSElDU19PVVRQVVRfUFJPVE9DT0wgKmdvcCwgVUlO VE4gZ29wDQo+Pj4+PiAjZGVmaW5lIElOVkFMSURfVklSVFVBTF9BRERSRVNTICgweEJBQUFEVUwg PDwgXA0KPj4+Pj4gKEVGSV9QQUdFX1NISUZUICsgQklUU19QRVJfTE9ORyAtIDMyKSkNCj4+Pj4+ IA0KPj4+Pj4gK3N0YXRpYyB2b2lkIF9faW5pdCBlZmlfcmVsb2NhdGVfZXNydChFRklfU1lTVEVN X1RBQkxFICpTeXN0ZW1UYWJsZSkNCj4+Pj4+ICt7DQo+Pj4+PiArIEVGSV9TVEFUVVMgc3RhdHVz Ow0KPj4+Pj4gKyBVSU5UTiBpbmZvX3NpemUgPSAwLCBtYXBfa2V5LCBtZGVzY19zaXplOw0KPj4+ Pj4gKyB2b2lkICptZW1vcnlfbWFwID0gTlVMTDsNCj4+Pj4+ICsgVUlOVDMyIHZlcjsNCj4+Pj4+ ICsgdW5zaWduZWQgaW50IGk7DQo+Pj4+PiArDQo+Pj4+PiArIGZvciAoIDsgOyApIHsNCj4+Pj4+ ICsgc3RhdHVzID0gZWZpX2JzLT5HZXRNZW1vcnlNYXAoJmluZm9fc2l6ZSwgbWVtb3J5X21hcCwg Jm1hcF9rZXksDQo+Pj4+PiArICZtZGVzY19zaXplLCAmdmVyKTsNCj4+Pj4+ICsgaWYgKCBzdGF0 dXMgPT0gRUZJX1NVQ0NFU1MgJiYgbWVtb3J5X21hcCAhPSBOVUxMICkNCj4+Pj4+ICsgYnJlYWs7 DQo+Pj4+PiArIGlmICggc3RhdHVzID09IEVGSV9CVUZGRVJfVE9PX1NNQUxMIHx8IG1lbW9yeV9t YXAgPT0gTlVMTCApDQo+Pj4+PiArIHsNCj4+Pj4+ICsgaW5mb19zaXplICs9IDggKiBlZmlfbWRl c2Nfc2l6ZTsNCj4+Pj4+ICsgaWYgKCBtZW1vcnlfbWFwICE9IE5VTEwgKQ0KPj4+Pj4gKyBlZmlf YnMtPkZyZWVQb29sKG1lbW9yeV9tYXApOw0KPj4+Pj4gKyBtZW1vcnlfbWFwID0gTlVMTDsNCj4+ Pj4+ICsgc3RhdHVzID0gZWZpX2JzLT5BbGxvY2F0ZVBvb2woRWZpTG9hZGVyRGF0YSwgaW5mb19z aXplLCAmbWVtb3J5X21hcCk7DQo+Pj4+PiArIGlmICggc3RhdHVzID09IEVGSV9TVUNDRVNTICkN Cj4+Pj4+ICsgY29udGludWU7DQo+Pj4+PiArIFByaW50RXJyKEwiQ2Fubm90IGFsbG9jYXRlIG1l bW9yeSB0byByZWxvY2F0ZSBFU1JUXHJcbiIpOw0KPj4+Pj4gKyB9DQo+Pj4+PiArIGVsc2UNCj4+ Pj4+ICsgUHJpbnRFcnIoTCJDYW5ub3Qgb2J0YWluIG1lbW9yeSBtYXAgdG8gcmVsb2NhdGUgRVNS VFxyXG4iKTsNCj4+Pj4+ICsgcmV0dXJuOw0KPj4+Pj4gKyB9DQo+Pj4+PiArDQo+Pj4+PiArIC8q IFRyeSB0byBvYnRhaW4gdGhlIEVTUlQuIEVycm9ycyBhcmUgbm90IGZhdGFsLiAqLw0KPj4+Pj4g KyBmb3IgKCBpID0gMDsgaSA8IGluZm9fc2l6ZTsgaSArPSBlZmlfbWRlc2Nfc2l6ZSApDQo+Pj4+ PiArIHsNCj4+Pj4+ICsgLyoNCj4+Pj4+ICsgKiBFU1JUIG5lZWRzIHRvIGJlIG1vdmVkIHRvIG1l bW9yeSBvZiB0eXBlIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGENCj4+Pj4+ICsgKiBzbyB0aGF0IHRo ZSBtZW1vcnkgaXQgaXMgaW4gd2lsbCBub3QgYmUgdXNlZCBmb3Igb3RoZXIgcHVycG9zZXMuDQo+ Pj4+PiArICovDQo+Pj4+PiArIHZvaWQgKm5ld19lc3J0ID0gTlVMTDsNCj4+Pj4+ICsgc2l6ZV90 IGVzcnRfc2l6ZSA9IGdldF9lc3J0X3NpemUoZWZpX21lbW1hcCArIGkpOw0KPj4+PiANCj4+Pj4g Li4uIGEgTlVMTCBwb2ludGVyIGhlcmUuICBBbmQgdGhlIG9ubHkgd2F5IHRoYXQgY291bGQgaGFw cGVuIGlzIGlmDQo+Pj4+IGVmaV9tZW1tYXAgaXMgTlVMTC4NCj4+PiANCj4+PiBJbmNvbXBsZXRl IHJlZmFjdG9yaW5nIC0gdGhpcyBuZWVkcyB0byBiZSBtZW1vcnlfbWFwLCBub3QgZWZpX21lbW1h cC4NCj4+PiBPZiBjb3Vyc2UgZWZpX21kZXNjX3NpemUgYWxzbyBuZWVkcyB0byBiZSBtZGVzY19z aXplLiBEaWRuJ3QgY2hlY2sNCj4+PiBmb3IgZnVydGhlciBsZWZ0b3ZlciBmcm9tIHRoZSBlYXJs aWVyIHBhdGNoIHZlcnNpb24uIEknbSBnb2luZyB0bw0KPj4+IHJldmVydCB0aGUgY29tbWl0Lg0K Pj4gDQo+PiBTb3JyeSBhYm91dCB0aGF0LiBXYW50IG1lIHRvIHN1Ym1pdCBhIHY5Pw0KPiANCj4g WWVzIHBsZWFzZS4gQW5kIHBsZWFzZSBtYWtlIHN1cmUgeW91IGhhdmUgdGVzdGVkIHRoaXMgYXQg bGVhc3Qgb24geDg2Lg0KDQpJIHdpbGwgdGVzdCBpdCBvbiBhcm02NCwgc28gcGxlYXNlIHBpbmcg bWUgaWYgSSBtaXNzIGl0LCBJIGdvdCBzdWJtZXJnZWQgYnkgTUwgbWFpbHMNCmFmdGVyIG15IGhv bGlkYXlzIGFuZCBJIGRpZG7igJl0IHRlc3QgKG9uIGFybSkgdGhpcyBvbmUgbGlrZSB0aGUgcHJl dmlvdXMgdmVyc2lvbiB0aGF0DQp5b3Ugc2VudCBiZWZvcmUNCg0KQ2hlZXJzLA0KTHVjYQ0KDQo+ IA0KPiBKYW4NCg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:04:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362146.592067 (Exim 4.92) (envelope-from ) id 1o92pd-0005Oy-Ir; Wed, 06 Jul 2022 11:04:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362146.592067; Wed, 06 Jul 2022 11:04:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92pd-0005Or-FL; Wed, 06 Jul 2022 11:04:33 +0000 Received: by outflank-mailman (input) for mailman id 362146; Wed, 06 Jul 2022 11:04:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92pc-0005Ol-0b for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:04:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o92pa-0007eg-NF; Wed, 06 Jul 2022 11:04:30 +0000 Received: from 54-240-197-225.amazon.com ([54.240.197.225] helo=[10.7.237.30]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o92pa-0007oz-EL; Wed, 06 Jul 2022 11:04:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=unt4ckH6F9RIeWF02YWNq/Qvil7c629ydQ+lDzxbPRk=; b=xOfD+3mz+BsK/YUEaAdkmN/ryz ajAWm0VTiyE34cZa6P552mHP/y28dehGA+lprHz8Y9nqGeawVw6O8MOC+PQ1R7eG/Hq0sgO609eyD E3gYXgKOdgoLVYVrsZHgMp0qaCYnOqfYBSXoas9Q1vL925IRbDnA7sjm1pUnJBUw4O7s=; Message-ID: Date: Wed, 6 Jul 2022 12:04:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. To: Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Juergen Gross References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit (+ Juergen for the Linux question) On 06/07/2022 11:42, Rahul Singh wrote: > Hi Julien, > >> On 5 Jul 2022, at 2:56 pm, Julien Grall wrote: >> >> >> >> On 05/07/2022 14:28, Rahul Singh wrote: >>> Hi Julien, >> >> Hi Rahul, >> >>>> On 28 Jun 2022, at 4:18 pm, Julien Grall wrote: >>>>> a new driver in linux kernel, etc where right now we just need to introduce an extra IOCTL in linux to support this feature. >>>> >>>> I don't understand why would need a new driver, etc. Given that you are introducing a new IOCTL you could pass a flag to say "This is a static event channel so don't close it". >>> I tried to implement other solutions to this issue. We can introduce a new event channel state “ECS_STATIC” and set the >>> event channel state to ECS_STATIC when Xen allocate and create the static event channels. >> >> From what you wrote, ECS_STATIC is just an interdomain behind but where you want Xen to prevent closing the port. >> >> From Xen PoV, it is still not clear why this is a problem to let Linux closing such port. From the guest PoV, there are other way to pass this information (see below). > > If Linux closes the port, the static event channel created by Xen associated with such port will not be available to use afterward. > > When I started implemented the static event channel series, I thought the static event channel has to be available for use during > the lifetime of the guest. This patch avoids closing the port if the Linux user-space application wants to use the event channel again. > > This patch is fixing the problem for Linux OS, and I agree with you that we should not modify the Xen to fix the Linux problem. > Therefore, If the guest decided to close the static event channel, Xen will close the port. Event Chanel associated with the port > will not be available for use after that.I will discard this patch in the next series. > >> >>> From guest OS we can check if the event channel is static (via EVTCHNOP_status() hypercall ), if the event channel is >>> static don’t try to close the event channel. If guest OS try to close the static event channel Xen will return error as static event channel can’t be closed. >> Why do you need this? You already need a binding indicating which ports will be pre-allocated. So you could update your binding to pass a flag telling Linux "don't close it". >> >> I have already proposed that before and I haven't seen any explanation why this is not a viable solution. > > Sorry I didn’t mention this earlier, I started with your suggestion to fix the issue but after going through the Linux evtchn driver code > it is not straight forward to tell Linux don’t close the port. Let me try to explain. > > In Linux, struct user_evtchn {} is the struct that hold the information for each user evtchn opened. We can add one bool parameter in this struct to tell Linux driver > via IOCTL if evtchn is static. When user application close the fd "/dev/xen/evtchn” , evtchn_release() will traverse all the evtchn and call evtchn_unbind_from_user() > for each evtchn. evtchn_unbind_from_user() will call __unbind_from_irq(irq) that will call xen_evtchn_close() . We need references to "struct user_evtchn” in > function __unbind_from_irq() to pass as argument to xen_evtchn_close() not to close the static event channel. I am not able to find any way to get > struct user_evtchn in function __unbind_from_irq() , without modifying the other Linux structure. > > Regards, > Rahul > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:33:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:33:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362159.592094 (Exim 4.92) (envelope-from ) id 1o93HM-0001FI-3G; Wed, 06 Jul 2022 11:33:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362159.592094; Wed, 06 Jul 2022 11:33:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93HL-0001FB-W1; Wed, 06 Jul 2022 11:33:11 +0000 Received: by outflank-mailman (input) for mailman id 362159; Wed, 06 Jul 2022 11:33:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93HK-0001F5-P1 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:33:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 692cf0dd-fd1f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 13:33:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DBF652272B; Wed, 6 Jul 2022 11:33:08 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7CBFE13A7D; Wed, 6 Jul 2022 11:33:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TK0KHfRyxWKrdQAAMHmgww (envelope-from ); Wed, 06 Jul 2022 11:33:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 692cf0dd-fd1f-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657107188; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HDZTuB45+6jVAoIDGG/LFM3iPuJIyyHb7bWYibnQiV4=; b=KTtnwfeOJsxLK1vxnn0QRAy34zTNRIWEqbA4SAP7tb4Sf5R364qOu4khBD5EMUFLVIavh4 8bNGtyBMXAvMO+/VmAbcQH3rCWwErsQHxmmET2YjfbK6gCboIWB+7VpkgyNJtU52jtRiyn l+4UtOAh6L9KUgW9ytXqDjhzrse8k/0= Message-ID: Date: Wed, 6 Jul 2022 13:33:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Julien Grall , Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> From: Juergen Gross Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------VNNkFKPml18H8NQ0OCFmnpj7" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------VNNkFKPml18H8NQ0OCFmnpj7 Content-Type: multipart/mixed; boundary="------------BCSJQRoR3Lzgqx0pIovebDgH"; protected-headers="v1" From: Juergen Gross To: Julien Grall , Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Message-ID: Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> In-Reply-To: --------------BCSJQRoR3Lzgqx0pIovebDgH Content-Type: multipart/mixed; boundary="------------vINSUXvVkn15CUSCPgudBR0P" --------------vINSUXvVkn15CUSCPgudBR0P Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDYuMDcuMjIgMTM6MDQsIEp1bGllbiBHcmFsbCB3cm90ZToNCj4gKCsgSnVlcmdlbiBm b3IgdGhlIExpbnV4IHF1ZXN0aW9uKQ0KPiANCj4gT24gMDYvMDcvMjAyMiAxMTo0MiwgUmFo dWwgU2luZ2ggd3JvdGU6DQo+PiBIaSBKdWxpZW4sDQo+Pg0KPj4+IE9uIDUgSnVsIDIwMjIs IGF0IDI6NTYgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+ DQo+Pj4NCj4+Pg0KPj4+IE9uIDA1LzA3LzIwMjIgMTQ6MjgsIFJhaHVsIFNpbmdoIHdyb3Rl Og0KPj4+PiBIaSBKdWxpZW4sDQo+Pj4NCj4+PiBIaSBSYWh1bCwNCj4+Pg0KPj4+Pj4gT24g MjggSnVuIDIwMjIsIGF0IDQ6MTggcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+ IHdyb3RlOg0KPj4+Pj4+IGEgbmV3IGRyaXZlciBpbiBsaW51eCBrZXJuZWwsIGV0YyB3aGVy ZSByaWdodCBub3cgd2UganVzdCBuZWVkIHRvIA0KPj4+Pj4+IGludHJvZHVjZSBhbiBleHRy YSBJT0NUTCBpbiBsaW51eCB0byBzdXBwb3J0IHRoaXMgZmVhdHVyZS4NCj4+Pj4+DQo+Pj4+ PiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHdvdWxkIG5lZWQgYSBuZXcgZHJpdmVyLCBldGMu IEdpdmVuIHRoYXQgeW91IGFyZSANCj4+Pj4+IGludHJvZHVjaW5nIGEgbmV3IElPQ1RMIHlv dSBjb3VsZCBwYXNzIGEgZmxhZyB0byBzYXkgIlRoaXMgaXMgYSBzdGF0aWMgDQo+Pj4+PiBl dmVudCBjaGFubmVsIHNvIGRvbid0IGNsb3NlIGl0Ii4NCj4+Pj4gSSB0cmllZCB0byBpbXBs ZW1lbnQgb3RoZXIgc29sdXRpb25zIHRvIHRoaXMgaXNzdWUuIFdlIGNhbiBpbnRyb2R1Y2Ug YSBuZXcgDQo+Pj4+IGV2ZW50IGNoYW5uZWwgc3RhdGUg4oCcRUNTX1NUQVRJQ+KAnSBhbmQg c2V0IHRoZQ0KPj4+PiBldmVudCBjaGFubmVsIHN0YXRlIHRvIEVDU19TVEFUSUMgd2hlbiBY ZW4gYWxsb2NhdGUgYW5kIGNyZWF0ZSB0aGUgc3RhdGljIA0KPj4+PiBldmVudCBjaGFubmVs cy4NCj4+Pg0KPj4+IMKgRnJvbSB3aGF0IHlvdSB3cm90ZSwgRUNTX1NUQVRJQyBpcyBqdXN0 IGFuIGludGVyZG9tYWluIGJlaGluZCBidXQgd2hlcmUgeW91IA0KPj4+IHdhbnQgWGVuIHRv IHByZXZlbnQgY2xvc2luZyB0aGUgcG9ydC4NCj4+Pg0KPj4+IMKgRnJvbSBYZW4gUG9WLCBp dCBpcyBzdGlsbCBub3QgY2xlYXIgd2h5IHRoaXMgaXMgYSBwcm9ibGVtIHRvIGxldCBMaW51 eCANCj4+PiBjbG9zaW5nIHN1Y2ggcG9ydC4gRnJvbSB0aGUgZ3Vlc3QgUG9WLCB0aGVyZSBh cmUgb3RoZXIgd2F5IHRvIHBhc3MgdGhpcyANCj4+PiBpbmZvcm1hdGlvbiAoc2VlIGJlbG93 KS4NCj4+DQo+PiBJZiBMaW51eCBjbG9zZXMgdGhlIHBvcnQsIHRoZSBzdGF0aWMgZXZlbnQg Y2hhbm5lbCBjcmVhdGVkIGJ5IFhlbiBhc3NvY2lhdGVkIA0KPj4gd2l0aCBzdWNoIHBvcnQg d2lsbCBub3QgYmUgYXZhaWxhYmxlIHRvIHVzZSBhZnRlcndhcmQuDQo+Pg0KPj4gV2hlbiBJ IHN0YXJ0ZWQgaW1wbGVtZW50ZWQgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsIHNlcmllcywg SSB0aG91Z2h0IHRoZSANCj4+IHN0YXRpYyBldmVudCBjaGFubmVsIGhhcyB0byBiZSBhdmFp bGFibGUgZm9yIHVzZSBkdXJpbmcNCj4+IHRoZSBsaWZldGltZSBvZiB0aGUgZ3Vlc3QuIFRo aXMgcGF0Y2ggYXZvaWRzIGNsb3NpbmcgdGhlIHBvcnQgaWYgdGhlIExpbnV4IA0KPj4gdXNl ci1zcGFjZSBhcHBsaWNhdGlvbiB3YW50cyB0byB1c2UgdGhlIGV2ZW50IGNoYW5uZWwgYWdh aW4uDQo+Pg0KPj4gVGhpcyBwYXRjaCBpcyBmaXhpbmcgdGhlIHByb2JsZW0gZm9yIExpbnV4 IE9TLCBhbmQgSSBhZ3JlZSB3aXRoIHlvdSB0aGF0IHdlIA0KPj4gc2hvdWxkIG5vdCBtb2Rp ZnkgdGhlIFhlbiB0byBmaXggdGhlIExpbnV4IHByb2JsZW0uDQo+PiBUaGVyZWZvcmUsIElm IHRoZSBndWVzdCBkZWNpZGVkIHRvIGNsb3NlIHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbCwg WGVuIHdpbGwgDQo+PiBjbG9zZSB0aGUgcG9ydC4gRXZlbnQgQ2hhbmVsIGFzc29jaWF0ZWQg d2l0aCB0aGUgcG9ydA0KPj4gd2lsbCBub3QgYmUgYXZhaWxhYmxlIGZvciB1c2UgYWZ0ZXIg dGhhdC5JIHdpbGwgZGlzY2FyZCB0aGlzIHBhdGNoIGluIHRoZSBuZXh0IA0KPj4gc2VyaWVz Lg0KPj4NCj4+Pg0KPj4+PiDCoEZyb20gZ3Vlc3QgT1Mgd2UgY2FuIGNoZWNrIGlmIHRoZSBl dmVudCBjaGFubmVsIGlzIHN0YXRpYyAodmlhIA0KPj4+PiBFVlRDSE5PUF9zdGF0dXMoKcKg IGh5cGVyY2FsbCApLCBpZiB0aGUgZXZlbnQgY2hhbm5lbCBpcw0KPj4+PiBzdGF0aWMgZG9u 4oCZdCB0cnkgdG8gY2xvc2UgdGhlIGV2ZW50IGNoYW5uZWwuIElmIGd1ZXN0IE9TIHRyeSB0 byBjbG9zZSB0aGUgDQo+Pj4+IHN0YXRpYyBldmVudCBjaGFubmVsIFhlbiB3aWxsIHJldHVy biBlcnJvciBhcyBzdGF0aWMgZXZlbnQgY2hhbm5lbCBjYW7igJl0IGJlIA0KPj4+PiBjbG9z ZWQuDQo+Pj4gV2h5IGRvIHlvdSBuZWVkIHRoaXM/IFlvdSBhbHJlYWR5IG5lZWQgYSBiaW5k aW5nIGluZGljYXRpbmcgd2hpY2ggcG9ydHMgd2lsbCANCj4+PiBiZSBwcmUtYWxsb2NhdGVk LiBTbyB5b3UgY291bGQgdXBkYXRlIHlvdXIgYmluZGluZyB0byBwYXNzIGEgZmxhZyB0ZWxs aW5nIA0KPj4+IExpbnV4ICJkb24ndCBjbG9zZSBpdCIuDQo+Pj4NCj4+PiBJIGhhdmUgYWxy ZWFkeSBwcm9wb3NlZCB0aGF0IGJlZm9yZSBhbmQgSSBoYXZlbid0IHNlZW4gYW55IGV4cGxh bmF0aW9uIHdoeSANCj4+PiB0aGlzIGlzIG5vdCBhIHZpYWJsZSBzb2x1dGlvbi4NCj4+DQo+ PiBTb3JyeSBJIGRpZG7igJl0IG1lbnRpb24gdGhpcyBlYXJsaWVyLCBJIHN0YXJ0ZWQgd2l0 aCB5b3VyIHN1Z2dlc3Rpb24gdG8gZml4IHRoZSANCj4+IGlzc3VlIGJ1dCBhZnRlciBnb2lu ZyB0aHJvdWdoIHRoZSBMaW51eCBldnRjaG4gZHJpdmVyIGNvZGUNCj4+IGl0IGlzIG5vdCBz dHJhaWdodCBmb3J3YXJkIHRvIHRlbGwgTGludXggZG9u4oCZdCBjbG9zZSB0aGUgcG9ydC4g TGV0IG1lIHRyeSB0byANCj4+IGV4cGxhaW4uDQo+Pg0KPj4gSW4gTGludXgsIHN0cnVjdCB1 c2VyX2V2dGNobiB7fSBpcyB0aGUgc3RydWN0IHRoYXQgaG9sZCB0aGUgaW5mb3JtYXRpb24g Zm9yIA0KPj4gZWFjaCB1c2VyIGV2dGNobiBvcGVuZWQuIFdlIGNhbiBhZGQgb25lIGJvb2wg cGFyYW1ldGVyIGluIHRoaXMgc3RydWN0IHRvIHRlbGwgDQo+PiBMaW51eCBkcml2ZXINCj4+ IHZpYSBJT0NUTCBpZiBldnRjaG4gaXMgc3RhdGljLiBXaGVuIHVzZXIgYXBwbGljYXRpb24g Y2xvc2UgdGhlIGZkIA0KPj4gIi9kZXYveGVuL2V2dGNobuKAnSAsIGV2dGNobl9yZWxlYXNl KCkgd2lsbCB0cmF2ZXJzZSBhbGwgdGhlIGV2dGNobiBhbmQgY2FsbCANCj4+IGV2dGNobl91 bmJpbmRfZnJvbV91c2VyKCkNCj4+IGZvciBlYWNoIGV2dGNobi4gZXZ0Y2huX3VuYmluZF9m cm9tX3VzZXIoKSB3aWxsIGNhbGzCoCBfX3VuYmluZF9mcm9tX2lycShpcnEpIA0KPj4gdGhh dCB3aWxsIGNhbGwgeGVuX2V2dGNobl9jbG9zZSgpIC4gV2UgbmVlZCByZWZlcmVuY2VzIHRv ICJzdHJ1Y3QgdXNlcl9ldnRjaG7igJ0gaW4NCj4+IGZ1bmN0aW9uIF9fdW5iaW5kX2Zyb21f aXJxKCkgdG8gcGFzcyBhcyBhcmd1bWVudCB0byB4ZW5fZXZ0Y2huX2Nsb3NlKCkgbm90IHRv IA0KPj4gY2xvc2UgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsLsKgIEkgYW0gbm90IGFibGUg dG8gZmluZCBhbnkgd2F5IHRvIGdldA0KPj4gc3RydWN0IHVzZXJfZXZ0Y2huIGluIGZ1bmN0 aW9uIF9fdW5iaW5kX2Zyb21faXJxKCkgLCB3aXRob3V0IG1vZGlmeWluZyB0aGUgDQo+PiBv dGhlciBMaW51eCBzdHJ1Y3R1cmUuDQoNClRoZSAic3RhdGljIiBmbGFnIHNob3VsZCBiZSBh ZGRlZCB0byBzdHJ1Y3QgaXJxX2luZm8uIEluIGNhc2UgYWxsIHJlbGV2YW50DQpldmVudCBj aGFubmVscyBhcmUgcmVhbGx5IHVzZXIgb25lcywgd2UgY291bGQgZWFzaWx5IGFkZCBhbm90 aGVyICJzdGF0aWMiDQpmbGFnIHRvIGV2dGNobl9tYWtlX3JlZmNvdW50ZWQoKSwgd2hpY2gg aXMgYWxyZWFkeSB1c2VkIHRvIHNldCBhIHVzZXINCmV2ZW50IGNoYW5uZWwgc3BlY2lmaWMg dmFsdWUgaW50byBzdHJ1Y3QgaXJxX2luZm8gd2hlbiBiaW5kaW5nIHRoZSBldmVudA0KY2hh bm5lbC4NCg0KDQpKdWVyZ2VuDQoNCg0K --------------vINSUXvVkn15CUSCPgudBR0P Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------vINSUXvVkn15CUSCPgudBR0P-- --------------BCSJQRoR3Lzgqx0pIovebDgH-- --------------VNNkFKPml18H8NQ0OCFmnpj7 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLFcvMFAwAAAAAACgkQsN6d1ii/Ey8D IAf/ah8W4Hq2MWMJWolw+W+xKt63F64RYAkWhLYjRP/YlVSx0f+o/tlLMUdgdBoWIcTb3sqg/F+9 wh0xwTa4qiihTAcApNi9ofGH0vLR1eg8LC7BNpi837ox2LBmoQgLMHRfF01ceDkpF/hDMZZKO1Cg eHEStS3i9V1RzQYJTEGv0LpCA2/AxiHDT4FNKSZkHZkbsH48gaTeOPx9CYruxrLnPDL370jWMQzb lnW6BtQnwUldzLcIlHWdbizZjdNZMfVUpduddHDtCa0hyKg2dFe1xtabjoBQTh2lXPjRMsfKPh24 7V+wOYg5daxx/g6zDgZLnoxzUAvi5chiFb84XdeaYg== =Db6w -----END PGP SIGNATURE----- --------------VNNkFKPml18H8NQ0OCFmnpj7-- From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:53:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:53:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362167.592110 (Exim 4.92) (envelope-from ) id 1o93bC-0004Aq-QJ; Wed, 06 Jul 2022 11:53:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362167.592110; Wed, 06 Jul 2022 11:53:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93bC-0004Aj-Nh; Wed, 06 Jul 2022 11:53:42 +0000 Received: by outflank-mailman (input) for mailman id 362167; Wed, 06 Jul 2022 11:53:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93bC-0004Ad-7n for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:53:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2089.outbound.protection.outlook.com [40.107.21.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46b8d463-fd22-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 13:53:40 +0200 (CEST) Received: from AS8PR04CA0101.eurprd04.prod.outlook.com (2603:10a6:20b:31e::16) by AM9PR08MB6193.eurprd08.prod.outlook.com (2603:10a6:20b:282::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 11:53:38 +0000 Received: from VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::7c) by AS8PR04CA0101.outlook.office365.com (2603:10a6:20b:31e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Wed, 6 Jul 2022 11:53:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT017.mail.protection.outlook.com (10.152.18.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 11:53:36 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Wed, 06 Jul 2022 11:53:36 +0000 Received: from d0d4842eaa9c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 81518F89-CC36-4B42-A010-B7CC5CAD553D.1; Wed, 06 Jul 2022 11:53:29 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d0d4842eaa9c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 11:53:29 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM9PR08MB7152.eurprd08.prod.outlook.com (2603:10a6:20b:3dd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 11:53:28 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 11:53:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46b8d463-fd22-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hXbSVl5owvks6v3gZFogd0RH5T852SIq0KD2H9++Lnw1QKwZj1SUI4P6AsA2ucqkQEble9AZKj5OXg4i7PWDCC0r83tqvgKzM4n7G0Qx6ejAu+6bQXWc+KUveX43cuec4fBqsrTReSap+Rns4VnbEdsY0Y8Moin+Vh2OotQTKZXYWK2S5GV/hwiQKnwY4mpg7zNf+u3n6q59Lrle1QsFVnV5oK+jRTJx6lcaYsDhN/N93KNhWTiuKaV9glDG21qT7YY0eZdnuD2gAexzTFiP+l6Wbm8YkAyTQgl1otAYdysfKI8abAsSDqiNG0EPU0zx5iNNbWbDyk4ZQCBtcK90TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vpe7j8NvqOpmkuLdRbbe/V1v9ng/QgJXcmvxSoYjtJI=; b=S1U2BggHYvR0gDORSA0OS4yHGR4bpGjM24g2GHDGCmpcaycVbTHhJu8b7+6SKi0N4VkWcvuC12D2N4oyNkcnlx/ikXXYuoDIAHvEgpqmWeXl15ixyEK6LAk7XizQpcE8sbNru54UXoTsWxZI4R58EeWLMdRL5ZcFja5uF9Gw+5qrRFO4ergSF/OlbysPXvkH7vJ1psqj76XqkMI33TM54Jx6mkhCmPrlLH3IN0/xkzANktJasttYI/Gxf9ICAPuuZ+MBYb5o32Lcvn0b5uYMTBPBWppka829i549e6MsULbYXg9iYr+sLttpV5AGzonrUx+bLbHlVchpX5/ysFeBCQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vpe7j8NvqOpmkuLdRbbe/V1v9ng/QgJXcmvxSoYjtJI=; b=qNvbnXSYmbl8xNBUCwHlGSRJOAwgoAOEJAmHN+v8UdfUKatRPpzD87rfSdfwEw6ZAbRo8OBAm8ndkgkzRRT9qqmHo1k1EgRso7O/lbl9CXcwP91IK70JnGUg34JnikBSc9aoTmUFHfreMQtSjlbLptPtHhgXyZ3qP+p0APbxtQU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e7b6ecec97bc0329 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JG+OgX/L6ZDNRosAXVKT7ay12UX4ZxtR5OdKZHZfYtkcVOgBvrUaapSsXb9jnzM0NlFUDoq3PnpzVNifo7qsfZEdtfNjkvqRnZfP72XaM8c32XvLKztU7VfsYzcCkbB4xN973dOZJK+q3V51tBRSfkDTSPPgxa4eYdMP1Dxk/FPv+sPD3p1/qTip3AIyGbEAD3z/OQpaXa5lxJsx1FfGvoik3yVGfQt/XWNzU8kRoFq/QzvkwSjJaUMeJjwcqm5Jnc3mKzGe8iobI3o+qHJZXN3M6puEw18I4bk4D5659K7YjJ6ATwkeXQvWuN10mCi5hj9cdYpUkj85T6dfpxGwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vpe7j8NvqOpmkuLdRbbe/V1v9ng/QgJXcmvxSoYjtJI=; b=h0xykj15s7YNc9fNHoFu5HPUk4JTuNtTixEybTANttJV6zKm2kXdxSRB3V3eCVCO1q7H68l+oanx+YNOBraCVclHCfLJkt2T0O4BICm1poFU2fsn+GCvvYhqMR3BnM45pjvhFXGItHQWN+tAHvb8V9xFQjK/oQMMStbe57mv8ZINZphLv21vYcxiSPFiHZRdeemcWgDyQOr4VFL4PhR9K4ovYYIM2WWw1mcFq0sB9B7EKKEIM7ww/na7j2U/ANurivv/5ZdhwBbNNIefmTC0QT9EqYRZ1qBOAmpibcn9C3ZlhDcwj2Ou6bSw2ySu6XCn6jnCYDRG7rE/I1ZzuHxNIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vpe7j8NvqOpmkuLdRbbe/V1v9ng/QgJXcmvxSoYjtJI=; b=qNvbnXSYmbl8xNBUCwHlGSRJOAwgoAOEJAmHN+v8UdfUKatRPpzD87rfSdfwEw6ZAbRo8OBAm8ndkgkzRRT9qqmHo1k1EgRso7O/lbl9CXcwP91IK70JnGUg34JnikBSc9aoTmUFHfreMQtSjlbLptPtHhgXyZ3qP+p0APbxtQU= From: Rahul Singh To: Jan Beulich CC: Bertrand Marquis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 1/8] xen/evtchn: make evtchn_bind_interdomain global Thread-Topic: [PATCH 1/8] xen/evtchn: make evtchn_bind_interdomain global Thread-Index: AQHYhkXPcukJScWMoU6OKeMe60D1nq1v8kMAgAFfMQA= Date: Wed, 6 Jul 2022 11:53:27 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a89b12d7-74f0-44da-2adb-08da5f462940 x-ms-traffictypediagnostic: AM9PR08MB7152:EE_|VE1EUR03FT017:EE_|AM9PR08MB6193:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nUP7tkAhJl98owpH8EuNK0q1tdW4oXGj5YPGzYSOwpBdNWn10il9XcEZw0UVXNNGmbq+hQK+7F/l8M+CfM8hWJOefQa8iSnmsItecTkAnOVkzNH6Ie22PK9MV4G7bNLV4/L6lYrp9KofBMS/KLkeaRF/sxNrFDKC6H5v/XsNzYtz6StUBg2IEE3SauBNO/JhfzJGZG/dfvmozeJh0XYzzKaDRxUSXsKiOkI15764YIPgfgUXOuo9DZPYAaN+BrlMdQEq5nA3pvj1T99sIhFw/pPhI7ICVVWVKWFWH9Iug29vwrf38N/gxrAYeSB+xpr26a/oGGi2/8OVxGIOy7fzxR7yZmRVn9vKTgu02KAakr/luAP9SJTeLNpA3N32voTqmvYYYGK0Bm83RuaMlKlKCtGAREqrd+/Nt98b8Gpxx6FpHKF2OecpZIXkcd1MKtnvCK57lB825zi8Qxm2Wfx7OqX/vfoH2hPQZBhllufkUcyoF/5AdgaSM/i+fE+NJjEfEx6awp0EUFCMMOafzXMegnGW9yvJjRV/bi6I6KJxUI26Xvui26lCMYxvpwS0vdIbzwxH3I2v9VL+32UULN/RfOTp0iFcNqi3dLL9vGK3eFlC1O8X7Q0pbuzw9R4N46f91h3FTkInvrp3x16FN8Axbp9ROAPFzS6KsLdGi5vB4OkOHsfRUIJbNbv7fXUBnTsbeuSf2dapIXnVEalxx/5gV+njRVFNblFiOc1pW8crBsqIXlpNjuCQY3T3PKjfUbUJ43ctoC4XmySmfznw0F3Zn4fity0blQrla7cZKMJjnlYGTjIEPhVv7dnVuLqkdSl4jyXvex5szJQXMCyfUxx6eIJFANomAoxD3ENHGaMj1nw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(366004)(376002)(66476007)(83380400001)(186003)(91956017)(71200400001)(33656002)(76116006)(66946007)(66556008)(66446008)(64756008)(8676002)(4326008)(86362001)(478600001)(6486002)(8936002)(5660300002)(4744005)(26005)(38070700005)(122000001)(38100700002)(2906002)(41300700001)(2616005)(53546011)(6506007)(54906003)(36756003)(6916009)(316002)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <755BA39929E06143852CD3C66A2D12BB@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7152 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be5f4129-9fdc-4295-e636-08da5f46239b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Id7UNKdJP6cwiITRGv1orr09Lw7j3qqTzsdFcITmuPoWRKXNYDCzaJQAd9J6w2uTTjzF2ZWVEFDaL26Sia6mRH3ymbwoGrAep4WWMty0oA1Hw8xOhkyn8mYe7WrDthZsiokzlv8BcLjfCNFHZm56RqIfFGwvfZLaAYJ3la137Xs55i7U10DqrBhrnQ/nTXROOfeFk4a0nc4RQAhleEdN4iSJ4+Yx5QRtIcLZVtbTSc2Gt/3KKFEuz3ObZb0NnO69Vg4Csv6bzKRyDUaSO/aELWUfBXeVLDLIhNmiMCGFMPluKZThaMECpfWh0iopr55CdgYD3cEvh+wJdTQmn22vU5OFLJUPXvyXFUBaXc0IU3kRmlRfbiSxZatAdQOyMNlpgeQCEQmPzhH596vCNp07zXF70XBOyAFdpJceiT7DnOcM8pdeGOE80qy4T/Cf4Tl3Azg97kJ1XjwSrXX3NTLDDZzXk6QniDLhMuBzyXCULSKEPC8oOUPYcE1tcD1b0gy4SSR32SDygZhTY7b/cyvSyU0XW/sbXJiWPLRLyh8xNfS4XKkfiBPv+0iiPEm3M4Nogn2fF7XL2qDG4e8D5kkISu3bGMG7n78/FGYJuQeJbe8Fj/E1VeYbwDqe+/M1G5ytWYFhjrvfwmlBtJ9BGmQ/bBYmyymoDmXOL56Ry8xDrsjfZDWjH1hgPxbSOGrwc0Cg+3DAE8BXuiwLuSgfryqUeMiwh6dSVG79VWrIPuaJKUaAvLUgS+cvgs8qwIHm5eWTpbBRcjHSTzl+byGyy5BoZp1Je7MCNrVhXno0QeR3N7LdSg8B+ZvMQT+0zFcWtuMV X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(396003)(346002)(46966006)(36840700001)(40470700004)(81166007)(336012)(47076005)(82310400005)(82740400003)(356005)(54906003)(316002)(6862004)(86362001)(4744005)(8936002)(5660300002)(83380400001)(40480700001)(70586007)(4326008)(8676002)(70206006)(40460700003)(26005)(36860700001)(6512007)(186003)(2616005)(6486002)(478600001)(53546011)(41300700001)(2906002)(6506007)(36756003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 11:53:36.9673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a89b12d7-74f0-44da-2adb-08da5f462940 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6193 Hi Jan, > On 5 Jul 2022, at 3:56 pm, Jan Beulich wrote: >=20 > On 22.06.2022 16:37, Rahul Singh wrote: >> Event channel support will be added for dom0less domains to allocate >> static event channel. It is necessary to have access to the >> evtchn_bind_interdomain function to do that, so make >> evtchn_bind_interdomain global and also make it __must_check. >>=20 >> Signed-off-by: Rahul Singh >=20 > In light of MISRA I don't think this should be a separate change. I will merge patch #1 #3 and #4 in next version. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:54:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:54:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362173.592122 (Exim 4.92) (envelope-from ) id 1o93cL-0004lq-7r; Wed, 06 Jul 2022 11:54:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362173.592122; Wed, 06 Jul 2022 11:54:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93cL-0004lj-56; Wed, 06 Jul 2022 11:54:53 +0000 Received: by outflank-mailman (input) for mailman id 362173; Wed, 06 Jul 2022 11:54:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93cJ-0004lV-Um for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:54:51 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2043.outbound.protection.outlook.com [40.107.22.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70d871c1-fd22-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 13:54:51 +0200 (CEST) Received: from AS9PR0301CA0043.eurprd03.prod.outlook.com (2603:10a6:20b:469::35) by VI1PR08MB5341.eurprd08.prod.outlook.com (2603:10a6:803:135::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Wed, 6 Jul 2022 11:54:37 +0000 Received: from AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:469:cafe::2c) by AS9PR0301CA0043.outlook.office365.com (2603:10a6:20b:469::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Wed, 6 Jul 2022 11:54:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT032.mail.protection.outlook.com (10.152.16.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 11:54:36 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Wed, 06 Jul 2022 11:54:36 +0000 Received: from 2c7ba2b4e1d1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5387D24A-7E70-4DA8-ACFC-AB9CA92B7E89.1; Wed, 06 Jul 2022 11:54:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2c7ba2b4e1d1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 11:54:27 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7802.eurprd08.prod.outlook.com (2603:10a6:150:59::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 11:54:23 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 11:54:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70d871c1-fd22-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CLUF/MSLPA9KYil+OKtMShXZr7Ew7/Ul40Ok5bvkShr43O94q9AgDTFMQHAZc/c6EDKcURvKdF7UnhP4pTgEJbkxZ0os7QbkxkVxtmceWAoJ9aRXg5oTs0qZgziS8ZRxAJHZDOx4jpnxcnD97YxEq/0baaMn711T2uQsFWK3Cp4rrPugJV3HOtJvt3JnvmccmmQh713ZJqw8Yk7QgyIG7u9ho4MK5fUcHEerZyVmf5i893PYvkgeh1kD9+XsMWVD1Scg2hp+C8FV6qDpG308rZRiZKK7ZAHExFYynLNrXvUgfaaTS7jx4vXWenlaTkuc3gLjkKfwoOblyBM7YX8AgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/a+kled6HyLt2uxnwrnF/nVz0cqm2yf5BD9ZX9pGkM=; b=DYeq4yanz+rf8Zn43WbOGeRLb+y6s0R7a0AuVqCtseCy79H7ohtcuWtOEPW3eTedwKSgFBpZIX1prOAyjUo1KeNO/pkhzr9d35o1bNJJY4AoTP6Md2wG+QSWV4XPtdmyh/WwkvPjvv9gRwxAi5djex8jGlIO2rXs5Go7Sul0iB5swOa0P3o2XgEwIPlewyd+lKEReci91sUpMd7uVvNk9vbcZGDy+myQO/Mp74cCuEkjA0tzBp8Sm0ZhDg9rTrAgCVHrOcMVC0zM+azV1B6/M+J3lY42CatEQYoG8n/5tu1mxouwGB0CKjoC+hCTQbOOzVKq+9JxRAOe4RHXiRnFJw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/a+kled6HyLt2uxnwrnF/nVz0cqm2yf5BD9ZX9pGkM=; b=emjZBZsosNuDGew6kxmh+nO6Jtynl4xF2WaFieMsr+bMSbnFUvVqbPDypbhMxYxzhqOm5X6bTqfsqGr6DKGiBrgAM8xcHsRUkl8hiNaP2dhvZH08qtc7uXZGjlXy7r3k+hWWZeWt2V+fQllnTS4JzDPKga1yFCIiERadplWmD4c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9c3f54e82dbc2bca X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ALGFwkMc3yKm6E3as209r3tTbxwH70zwGp/Lzk9B8DP7a0J6wO9mPaxmDxO8B1QOiJetRE5jFkfHwmfW+gnHg6nEsNOdhwbWIz64jxbZqAAz3RcQNjjF9UF0V+NVvU34jlwoF0DxcEm5yPrErrFyvu4PDcJB8vSh/0iKmStGo72XeptS0S8cguZ4+22Y93jBp1L5ndc0YJZK6Yb56ZV+9P4uFF2ArfqMQBWxNuGlNGrBVBJbrnGBLoiG+69Z0TO1H0sYBVb1n7AjSvhmHbM7WK4PZx54/ELQDXOhGo5WoyZQbEdtw/iHVmdapkkOSgTQaKKD1rfu742ns2ZEpzPSCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4/a+kled6HyLt2uxnwrnF/nVz0cqm2yf5BD9ZX9pGkM=; b=TTJq60iCAF5EfJyxfCz78ys/ru28U0QcVp1LgqWx61Ebq0+roDJSqfzqPOvGbhO+awAkOq0hiXfxtINHOxsTyqkf+/J5bCK+PgIWungcAnMgxDoYfzr3wWuG/dRT9cdPO3NysgEzxeoHdMl1NkFo0IyCcnFVA2ePjBt8Oxq7zlAoXcS7D6FNY7Bk2HSDVGIDrquwox1c1+MDzTGqxiCc5bTHqv7kLT9tBvFKLYU3fcjWVGsZ/BmhmfojSxcwEOl2YsLAxu9BCSlTLLagw22obLpLMqnmqTQ+7QgAciS5a1nbcZr8Zo4Wj10HA9SPg/yQ61ElKwXvhVwGwHQtgp/gYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4/a+kled6HyLt2uxnwrnF/nVz0cqm2yf5BD9ZX9pGkM=; b=emjZBZsosNuDGew6kxmh+nO6Jtynl4xF2WaFieMsr+bMSbnFUvVqbPDypbhMxYxzhqOm5X6bTqfsqGr6DKGiBrgAM8xcHsRUkl8hiNaP2dhvZH08qtc7uXZGjlXy7r3k+hWWZeWt2V+fQllnTS4JzDPKga1yFCIiERadplWmD4c= From: Rahul Singh To: Jan Beulich CC: Bertrand Marquis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 4/8] xen/evtchn: modify evtchn_bind_interdomain to pass domain as argument Thread-Topic: [PATCH 4/8] xen/evtchn: modify evtchn_bind_interdomain to pass domain as argument Thread-Index: AQHYhkXqHHUOFE7Oc0i6xmxR7R1MK61v9xKAgAFapQA= Date: Wed, 6 Jul 2022 11:54:22 +0000 Message-ID: <78444E5D-3679-44B0-91BD-30A8E71A0413@arm.com> References: <037b30aa5186cff516f8acf17a3a465663a8194a.1655903088.git.rahul.singh@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 457587a8-c567-4da6-2a8f-08da5f464cf1 x-ms-traffictypediagnostic: GV1PR08MB7802:EE_|AM5EUR03FT032:EE_|VI1PR08MB5341:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CBtKy2OuQCC/A0jEWCR5SbAkXBNBzqyUGAhuaK5zLSDqGH/rRF22kMr8HCIOrJDSAP9xhfbiqKdRXGDO8i3UKnGh8yfv1XoYVer/CTecsKz8aA1lj+TcvoLGoEzV+rDNIXuPpcQbTA1ypSmRx7eF3QQ3Bfw4TR1BroxrKxLNpBy8+2bbz1F5O58gS7Zs1+XqLHyU1WbZ6hsV9Nq1XcmrPNvWE7Q/HLgIZwyDerG88/DDjZIkXMapgFP9atMtiwx9IoCP3VLD19RykFhOFbvNtDlWXymC/lMQ5hGC6B7Ki+NOPTbQz/AVZrF2uN7ogyW5U7JCOBug2LErWcvS0QHnh6lSSabzLbaxdlRxkGVK03MfX7WuQ30D2FZXmeQ02q/Hu4d/Y6K4s5S6nS6avgbND0Q9lMPOU3TydHoOEjwLuFqoLwWLEw1EceqPhdUJVznby+RuKBfIHCnJLWt8HbGfxG0dtzT9Gj9wiMfI8I8YtZxyUMJx8FkOk0MCN+9pbfH2BdZzGwS7pcccvaS2jzHRFhkztnMuMuLtcch4dt9DQc74J9Zi2qZLF41+dRDUHhfhCbXjjzsQWBtjySVQXtHgzdW74s+5n5QMf84MLmT4pjHctuUn3isHWs9o1eONcDGb/0dgqjFH2XqogkQEoekLRcu1josf2eb0+AL6tfsGodLXaLk0+hmuR6onODtAOW5rmlgEkgZmxy7JgJYqBx6+8TWOJjnhSMnoJJ5tVGFdOJ9jGzXgflzcKKaHWqGHWbfDNnX/INMt/YqzbG/dylxVOgN/8uFr93n3kwS7x8ou0AkJkJyif0dvMlGznzz0TfBAlLzNOj65wkvV60p63Hbl5jVHRoH1nuHhYHnpDe4uFeY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(2906002)(36756003)(2616005)(33656002)(8936002)(186003)(38100700002)(91956017)(41300700001)(53546011)(26005)(4744005)(5660300002)(6512007)(6916009)(76116006)(38070700005)(66946007)(6506007)(4326008)(6486002)(66446008)(64756008)(66556008)(122000001)(8676002)(66476007)(71200400001)(316002)(54906003)(86362001)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <2A8AEA11D8AFAA40B7D0518281B672B0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7802 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8cc2ec4f-c730-4a37-0157-08da5f464484 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EjvKVZJ6w01obYlIJx65bKxTdsj5MhKvbhCOLmQnCy4ZFg/XKg4Vc0GtEdKbXNTnF9PgCSCUya1JfhiACoeW0e8X8bvAY+qoOanUYTVqjNFpNSd8iMbSsYSXP+lkZ3CFLvNCrc/SlLsDE/zxDna3IDRwk53zCu0wdYzyfUMWRuPx7LMds2zStz0u//Tu9s1XLVGLHIGXs5eifmTGZOTdrXEaWkSnpAVpF3SjdeeFi3HUKtOzX9em/iNki5UC4NsFaJXFzgJiLpyZqixsRj615iLLgWP35cJleXImRwwXxdFzj8e93qvYnTLFqTWASjQyZhUzmYH71poc+/aVvLT+P5e4mdM+fkt2xnvH8+b9wUGBoB0R7FLTKrVj2RSAuPLyX+B62u/v6Sjfq+f/HEc6RacYqcMW1M3t/r1W71GAeXyC8OdVG9ZHBSoo8+/lN/m0VZUdQBoQzqbjDf/9Z17y9OxOR14etc6TvEuHaLSF2nypnEsE3r41muQiA7lTDE6SibjuSppByYTKWstPPU6iZCSSxGLlXFSvZdiMJGSw98H3oVfs32dE3XqMCoVB+6CSv5Nq+x817U0DG+YwsnaKgHpkt9/PoUzI2Gsc4m2fP1MDhlWDwBQA3uirGk+tiRbbvkHNThRUKsUNliL+QqgCURzolllRj1tefLb0Y3PdPNK6Dbfn34Ix/Rrs1z0CYExvYo2h+W8LxVvTTsrZbjc1j6K7h18SgBjDtrSwHGd6UmHGXh5dNO12eR3fJb+OXGV5rHwIVfOFmzt9wTNLxaoaUDdQ6B8yZPa0Re6Jz/jwmrz895HC/gPY26xL5NJhwrG3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(36840700001)(40470700004)(46966006)(336012)(186003)(40480700001)(47076005)(54906003)(70206006)(70586007)(4326008)(8676002)(36756003)(6512007)(2616005)(26005)(6506007)(53546011)(81166007)(82310400005)(356005)(82740400003)(33656002)(40460700003)(36860700001)(86362001)(41300700001)(2906002)(5660300002)(4744005)(316002)(8936002)(478600001)(6486002)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 11:54:36.8944 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 457587a8-c567-4da6-2a8f-08da5f464cf1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5341 Hi Jan, > On 5 Jul 2022, at 4:13 pm, Jan Beulich wrote: >=20 > On 22.06.2022 16:38, Rahul Singh wrote: >> evtchn_bind_interdomain() finds the local domain from "current->domain" >> pointer. >>=20 >> evtchn_bind_interdomain() will be called from the XEN to support static >> event channel during domain creation. "current" pointer is not valid at >> that time, therefore modify the evtchn_bind_interdomain() to pass >> domain as an argument. >>=20 >> Signed-off-by: Rahul Singh >=20 > I think this wants folding with the previous patch. Ack. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:56:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:56:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362177.592133 (Exim 4.92) (envelope-from ) id 1o93e0-0005Ou-Kw; Wed, 06 Jul 2022 11:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362177.592133; Wed, 06 Jul 2022 11:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93e0-0005On-I1; Wed, 06 Jul 2022 11:56:36 +0000 Received: by outflank-mailman (input) for mailman id 362177; Wed, 06 Jul 2022 11:56:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93dz-0005Ob-2Z for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:56:35 +0000 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [2a00:1450:4864:20::430]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae65c62f-fd22-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 13:56:34 +0200 (CEST) Received: by mail-wr1-x430.google.com with SMTP id o4so21733252wrh.3 for ; Wed, 06 Jul 2022 04:56:34 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id m9-20020a05600c3b0900b003a04d19dab3sm24634680wms.3.2022.07.06.04.56.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 04:56:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae65c62f-fd22-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=w2XRrjOrjpaz12Jeqf1YAACZjWuCue/f9szg5gZlJPQ=; b=IZHysttEe7MEPbju0JlvAoUIGig3WPZzCZLJeuYGs1rPsxY9YE4tCcD3uZrZ9e4ay1 hr1Kxonrr6HjRjvHZJu7Qd/ZfFeb6f2DCXLEAR/nIm4cziU4XN+YJkGCZ9sexXkEBCbR at4yAa4jQ2dEFxPTvaduCWFe1f2N/7W15nH9q+pC71/GeSzt3REH7KGtPDro2IHw/E7A zxup0qNJundQP6y9fdu+wZfypO8Q4ohxIWtXczSM+LvsdtTHlW8gizUowxmrI5YXZdNd 1aqfKMOCoJv/SoEYlOuLSj59np239ZRlL/9rwQleU842M8TmYplBeCeoPnFvJamGM8hp OaTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=w2XRrjOrjpaz12Jeqf1YAACZjWuCue/f9szg5gZlJPQ=; b=FcyL6DyitZYXNyX3mPEDdmZqLqPi+Lh7pomsTQ7Mdr09f9b15VuGjs7/nlF0B9UDKo m7T2MDwF/3j6dV8RX4bviVnrwPQa5GgpYWBzE5DH4o2olbmAWzd4SFU8uCNbaGyBw7eh kCMHDKG73L+I+qkOPNgOjQc+6yex4jKkfiWX3woOjoUIzx8+gbdEqgEaGtaCvXVUU+LD n56dqbvO3kY/WSykSiRWBCJGctmrL/gZyM5A266D7cbehzJED6wsAWEkJ3KysxVnBt1F sCCOAEfo8PfjVcaiNl3yDBFyCVszVUtahR2mOrYbkfnJevXaNW0OAOBCQM23lCP1pBsz rvUA== X-Gm-Message-State: AJIora9hyG13DQUwY7c5SMnNcinmLXgRK4BaxGkI/nE+UQSYejWphEwX G9JLPnOkUn8SNMF0GjylVlWMYPNroGI= X-Google-Smtp-Source: AGRyM1tnte5FApRyJIN9lWoXQzVY9CNfJ2DbDEOo3Uf1WWjqhQu0crczUM/SAf3Km7lvqTEBS8VvhQ== X-Received: by 2002:adf:fd02:0:b0:21d:6f22:7857 with SMTP id e2-20020adffd02000000b0021d6f227857mr10506054wrr.633.1657108593186; Wed, 06 Jul 2022 04:56:33 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Subject: [PATCH v2] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Date: Wed, 6 Jul 2022 14:56:31 +0300 Message-Id: <20220706115631.654544-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the function prototype of show_stack() in header file so that it is visible before its definition in traps.c. Although show_stack() is referenced only in traps.c, it is declared with external linkage because, during development, it is often called also by other files for debugging purposes. Declaring it static would increase development effort. Add appropriate comment Signed-off-by: Xenia Ragiadakou --- Changes in v2: - add a new line after show_stack() to make obvious to which set of functions the comment is referring to. xen/arch/arm/include/asm/processor.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 4188ec6bfb..55f56b33bc 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -558,7 +558,10 @@ extern register_t __cpu_logical_map[]; void panic_PAR(uint64_t par); void show_execution_state(const struct cpu_user_regs *regs); +/* Debugging functions are declared with external linkage to aid development. */ void show_registers(const struct cpu_user_regs *regs); +void show_stack(const struct cpu_user_regs *regs); + //#define dump_execution_state() run_in_exception_handler(show_execution_state) #define dump_execution_state() WARN() -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:58:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:58:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362182.592144 (Exim 4.92) (envelope-from ) id 1o93fp-0006Hv-1h; Wed, 06 Jul 2022 11:58:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362182.592144; Wed, 06 Jul 2022 11:58:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93fo-0006Ho-Tm; Wed, 06 Jul 2022 11:58:28 +0000 Received: by outflank-mailman (input) for mailman id 362182; Wed, 06 Jul 2022 11:58:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93fn-0006Hd-2l for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:58:27 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2041.outbound.protection.outlook.com [40.107.22.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f135dd13-fd22-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 13:58:26 +0200 (CEST) Received: from AS9PR05CA0040.eurprd05.prod.outlook.com (2603:10a6:20b:489::23) by DB4PR08MB8197.eurprd08.prod.outlook.com (2603:10a6:10:383::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Wed, 6 Jul 2022 11:58:24 +0000 Received: from AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::9) by AS9PR05CA0040.outlook.office365.com (2603:10a6:20b:489::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20 via Frontend Transport; Wed, 6 Jul 2022 11:58:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT019.mail.protection.outlook.com (10.152.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 11:58:21 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Wed, 06 Jul 2022 11:58:15 +0000 Received: from 2cd8a98d0176.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7D06582F-D626-47BF-B62D-52A5B97C5736.1; Wed, 06 Jul 2022 11:58:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2cd8a98d0176.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 11:58:08 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7802.eurprd08.prod.outlook.com (2603:10a6:150:59::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 11:57:58 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 11:57:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f135dd13-fd22-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QAblQtGZEDVFY9RjGJ2AweEX5Ej+OJ0jg4i/ZIK8iT1hIPsvUKhBbZKsD/pFBDrJwV1AvVfWIAsvVBhxGSQYB3F+vOQyG0kVNhJaucgMC+nMm2Q6hn/0pIroFzBCz3B21z9WaWahYGcZFYYqAmmOAsEpnpb7icPqxLTWiMDGUPP6j2bXr59FdOyr8ywCeutSVwiMy2GWC2X8evajsfgLQR9LCkMyXyFSvXgTfaq6xI1ytBOw8FnrFKgp95fjWSRcBU2bZX6ogUDa6CQrsHs6zvmy5x0WtDOacK0CshTaO/RRc9x5bIasGRQaZLIu+8e0oXbKn1Z/9+S5xqc+jn2qUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ir3P2/8WVexRwE51Kmdee/xJgZjqwnO7nCx9vvwS8w=; b=f7dwJKqCu7JSjWL1VchoZK/SKLAH6mOIQuzgTNBdoXXM3iJu1jx0gskbfqyKhnAPd4jWgyuRgc35SWP91TxNItL7AuO9kqupiOpCwzK6IgPBmiD92kPb4jWp33NdWBX68aNJ9wpK1qpRp09tzAWVf1sMyyEVgG7KI/m9QoOlC5Jb88aFhoJZq8Rt/2SJzwdj1SH53/ntmyBWnvpgHKQYwZxljkgbHTh86Pu4MBgyZx75LY72Vl3CDGox1xAs7LFtGvGyuGN/71WCHpHNs+8E9BYQKZ9Z+G4prNMkSTCeq7saZ0c6DOa5Z50XDO+mt4Vj/Cp9grGwwD40lMmtsMyWRg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ir3P2/8WVexRwE51Kmdee/xJgZjqwnO7nCx9vvwS8w=; b=9zzhfyZ/uu/jPehHOpz7p1Jpn1Aof6hQPj79MYOWUTWu7VrhngUcgs7wEBP2VRKPzXz1z6vQH/vBXWmdPIXnvBLvKMV7wNHJa3rh7/wNC6cVeqSPgitjvyjghlcPueZ1pSQTn6ETncBYEi9uWCey1vD7CEHY15h6UZmrEjRBqSY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 475b56113fb5653a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bnj++qHnUZYFMkOAJaDV3jyy7yjZzDUMgZZkwc6Lz2C98N6ylf+7R+QSc6dOX44h90r7jGWrLSgO4xMS40ZPNuXENW+tyOlLTgRZqzO67RXRiE7rj5Yxs8qE/YLAY3eODc/WDDGHAK9jGtsfNvUp8AsURO7USq/ccAZrJCtMLXWFKEyKcriU02OvZAVraVAUsDIPuin8/qAg1HfavVVShtULfrN3llLc1xDWgdDFLe8XiciGyxfpbs6DvM6X2R6vWAMOfXyQssnUazeVSwbdA5MmcKE3M3Cfkl98MwyF/cpIdvVfHbHB/3AArKyT55WDsE62ChR+EiaqH7FGCRgVfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2ir3P2/8WVexRwE51Kmdee/xJgZjqwnO7nCx9vvwS8w=; b=PVF9WPoHWaLd7htjOv/dfEK1UmVxJRZSma0ye6xj206PyOo+nMqBc+xFtXtxuDv/P0BaMFQUKksc7pJo0qVV9cxm9RlQSO3kLMYKbiLo7z69OkB/3/eakrnPTBZu+tEr06EIk84Xa9pwwJ/3PcBp0RO0XxdqDb+ekrrP9W7miMSc9f7fgD3n99aIaJYPApRbVWYXKAig7REmtvZQng1YomHDh4+jLx9uAG04Z5GS/0CRvr/e7fZQQ+6kOQBMA+bQ27P9zVz6cxdCViElPm8PJ6LR8rPiDo+39V5OpEwLFrAI8GKMe6NJV5KqGn9ZKB1UzzYtwPSdwXveYkpXaBwYfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2ir3P2/8WVexRwE51Kmdee/xJgZjqwnO7nCx9vvwS8w=; b=9zzhfyZ/uu/jPehHOpz7p1Jpn1Aof6hQPj79MYOWUTWu7VrhngUcgs7wEBP2VRKPzXz1z6vQH/vBXWmdPIXnvBLvKMV7wNHJa3rh7/wNC6cVeqSPgitjvyjghlcPueZ1pSQTn6ETncBYEi9uWCey1vD7CEHY15h6UZmrEjRBqSY= From: Rahul Singh To: Julien Grall CC: Jan Beulich , Bertrand Marquis , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Thread-Topic: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Thread-Index: AQHYhkXgFvoQlpdPN0O1CKuVc36nOK1v9mEAgAADLoCAAVkogA== Date: Wed, 6 Jul 2022 11:57:57 +0000 Message-ID: References: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> In-Reply-To: <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 523de96d-138a-4189-c983-08da5f46d323 x-ms-traffictypediagnostic: GV1PR08MB7802:EE_|AM5EUR03FT019:EE_|DB4PR08MB8197:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: GFlWJMJagZfE+Y9zLTSdPb7FEDAKTyzycSTEyoIrALBEMHGg91Y/P10NfaaA6hJdewAi43SPOhOYVJflupfWiwF7AU0UE6qqKvfBxIc0NqXmcuBvK3+23bLb7HzWKFfZzFVlzZW0G0C2BHRbY/Ze0B2XETUnqxHrelQ1nmdlbvYF5q/PfWNOEIanqHNGcYJs2iwuSy9pJ4iOnnlAdBstAhYlK/XrzOzDTL69YbCXx9rCl4vKY3itxdzfPIg2MeGByGrLpoFb2+dWHsKPGVLPQDqna9nxuC+I7wdWbwOIhv0sQ/dRvinWnyOcBy2C113r9VO8xzeGMgHyrADZH76KtEM9juDJVvrcKCOJvsSHE8osGTttj4tOyI11UvAWrkoOoEGdvViXZHHB6wkC49bJ0u3TbxFZWNwZNTNl15QqMFbOAo2rloELN6f9xsLJEtiYNRLoBkOvzvtNmRWvPA5fQtYcEtrg7wx3nF0UzYpWu9L1gYM8hGPK+QqMS3Br9LgzW6C0UFuePGibFacWqHoMLFOrOVEGND1IS1aJU0PHXr7x1+gLbeLcPJSsV3e6MdVTLWogLS2GazdNrres+lqVVI8pI20NP9/7+Ua42KBU3TJFHzEE0pNoZVtMlBXrQkMHQs/I/J097vcPQGXbvRcixyeNTujbgzvfIIz53fLYu4byjtLMu4t5a+ybzS0BL5K1L7iSWchMCSFoUC8URlIOoDfwmnT5BveSTLPL/vx/6ayZAV81zDMlIoQQglmpY3NqO3XvZtF61NJqbyiJC1yy8V5aa8ZUuYavoosSSjI0tKwjdETnscex2NxQVBF3BnYUEXZM6N5ySYnPQjTWOD4VXWNE3Adex4MtGNFx+4WdB64= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(366004)(396003)(39860400002)(2906002)(36756003)(2616005)(33656002)(8936002)(83380400001)(186003)(38100700002)(91956017)(41300700001)(53546011)(26005)(4744005)(5660300002)(6512007)(6916009)(76116006)(38070700005)(66946007)(6506007)(4326008)(6486002)(66446008)(64756008)(66556008)(122000001)(8676002)(66476007)(71200400001)(316002)(54906003)(86362001)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <9C5AE0279D407D4C9962EB5B7055BCDB@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7802 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e9a19a2a-faf5-4cbe-75f8-08da5f46c4c0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DXcd+mKkTt5Lwx6ryyTl4UJSDyGztLiINJixbUJ5kVvaTT79p39c0mmkdmPn6ebAkRmMyLmXNgwJugnfOxRSMgz/g9Uh2FAmILZ0LCHdOal3jy68YPEAOMvrn8rCmNtpV+Nk5bWXXQUrG0rgg14Fq9w2/aKzhWkgc1Nz5n64FnEMVQvns/V+hxdLaUzrXrijQ2gPvm4nXYP92yhvQv/XI28Rakuf5Xwk721rWZ9L+jY4YgCNYLIm6tmXW3CsDnsMo6DimRjz2pW4UL/QrI0AHfV5QD5HSBk1BeSGsBB0w8yGVx2oIIsaJllb4p+N1PyIjMV03fJpPlZZi9yMjySRbEBnU7GK9PulBYpfhrL8JmiPL3nhV8Qreic1RNYm/i0Upl9pruH0H14/GV+oPx0Ep/i94RfZK2z8JVe9KdSdlHmtwNZ+aXMsr+J2NeD8uiLGvYGtVZKu+aBr/r0wLdlasVAJQVtcxXtWag4yvVJ3cqt50s9l7sfCjiruBG38dJvC4DAwaq6aE8zRf1/+niykN9md+TJwnkqZoCJ4I8JxVVxMS57R8wTQjfDlHNoL/O25F/aFAY5UsnyEZgNv8W+12YbrixQaC+VK0RrnXDoE0i+n/x4wVt4Upe96UFm4Psbw2Zt4J+6HBceiv/dYimCnZ8rdt7T0VpK9j3lhYPnYPVxmNtH9V4LJL9VpBeViHiSYeUkhOc8Q0tvC88zkgw5nPXxKdHejQ7fPuEyV9MGHJQDEoW1VGQo8KX7js7rxR9R31W6KeaagWsKejHeDOLMSwNrFHjS0J17LZ4IaqWldvX4iHq/NDoXy2xC3ovImLpal X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(346002)(46966006)(36840700001)(40470700004)(8936002)(6862004)(6486002)(33656002)(478600001)(86362001)(356005)(4326008)(8676002)(6512007)(70586007)(70206006)(36860700001)(82740400003)(4744005)(82310400005)(5660300002)(40480700001)(2616005)(40460700003)(26005)(81166007)(186003)(53546011)(36756003)(316002)(47076005)(54906003)(336012)(6506007)(83380400001)(2906002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 11:58:21.9032 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 523de96d-138a-4189-c983-08da5f46d323 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR08MB8197 Hi Julien, > On 5 Jul 2022, at 4:22 pm, Julien Grall wrote: >=20 > Hi Jan, >=20 > On 05/07/2022 16:11, Jan Beulich wrote: >> On 22.06.2022 16:38, Rahul Singh wrote: >>> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdomai= n_t *bind) >>> spin_lock(&ld->event_lock); >>> } >>> - if ( (lport =3D get_free_port(ld)) < 0 ) >>> - ERROR_EXIT(lport); >>> + if ( lport !=3D 0 ) >>> + { >>> + if ( (rc =3D evtchn_allocate_port(ld, lport)) !=3D 0 ) >>> + ERROR_EXIT_DOM(rc, ld); >>> + } >>> + else >>> + { >>> + int alloc_port =3D get_free_port(ld); >>> + >>> + if ( alloc_port < 0 ) >>> + ERROR_EXIT_DOM(alloc_port, ld); >>> + lport =3D alloc_port; >>> + } >> This is then the 3rd instance of this pattern. I think the logic >> wants moving into get_free_port() (perhaps with a name change). >=20 > I think the code below would be suitable. I can send it or Rahul can re-u= se the commit [1]: Thanks for the code. I will include this patch in next version. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Jul 06 11:59:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 11:59:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362189.592155 (Exim 4.92) (envelope-from ) id 1o93hA-0006vK-Fc; Wed, 06 Jul 2022 11:59:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362189.592155; Wed, 06 Jul 2022 11:59:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93hA-0006vD-Cn; Wed, 06 Jul 2022 11:59:52 +0000 Received: by outflank-mailman (input) for mailman id 362189; Wed, 06 Jul 2022 11:59:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93h9-0006v5-NI for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 11:59:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2075.outbound.protection.outlook.com [40.107.104.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23863ef3-fd23-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 13:59:50 +0200 (CEST) Received: from DB9PR05CA0005.eurprd05.prod.outlook.com (2603:10a6:10:1da::10) by VI1PR0802MB2528.eurprd08.prod.outlook.com (2603:10a6:800:ad::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Wed, 6 Jul 2022 11:59:47 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::aa) by DB9PR05CA0005.outlook.office365.com (2603:10a6:10:1da::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21 via Frontend Transport; Wed, 6 Jul 2022 11:59:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 6 Jul 2022 11:59:47 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Wed, 06 Jul 2022 11:59:47 +0000 Received: from 6b9f9c6e2203.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DC08EAFE-0B52-4A97-9E98-BC96C5D9FC98.1; Wed, 06 Jul 2022 11:59:40 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6b9f9c6e2203.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 06 Jul 2022 11:59:40 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM0PR08MB3554.eurprd08.prod.outlook.com (2603:10a6:208:e3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Wed, 6 Jul 2022 11:59:39 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Wed, 6 Jul 2022 11:59:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23863ef3-fd23-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=b4mlFdbmkKgdL+Mp5CxatbqjQDaGbyDId7XyzreOvyxzP38C41FZooqO1rpN5SSBdh8RW3uViA2pRGe+Cv4CK4m9gu+aM4TyJFU9nuv1TbHneaqlIdgSwwMr7DNN4GHIn6MmtphsbL01mMbs/j3KzGeUX9czq59vUBUOQe2iO8yqxSfgPobM5vAliWoXjm3omvD7gzA7Z73ikKiZEvG630SI+sy18Tkn2eu1CwHzZNoglHwtNrZ4dMFUocJVDR1DKj/Wx5XuacIhO/6WbuhmtmCTFabrx3lYomNFaGju+L+BWHmgSTYmpngi6Fbxuaewcuf4zlEC8kYgDK7oeSNuVg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xTcn2qsjfcs/sS6vCPWitDMWsvpXLXSi6QJa5DTFGPo=; b=Fo3gDFGPIMF7h30hYPeO3fMuoA6p1DIBTXU6Bflcz4mwuaNk/BiYNwb9xywrOo7pg1fEADar4Yq0hULouV2WDQmoyYjV9hKofRRmVF5UlZYIRDpl5I+8j9p7Z+vOwPDJAaO2mQPPcv2hxchi1QHHUzWXGvhWUs0M0cwyudxSHWSA8nX7bqCxQ0N9dufaxitcykzt0njKl6IZ/IH7js48JHFaCeQ8WMbujtojDwPkGa1FaQ04zmmi7/8mUNwEwh86mjiRaSMwDLEPto0YUSwixXlQeBRzLvIJDQpnIupHOU/RelCP/qy9d3ln4NqiKT7pUbUMacywCudXrWgw+W4hAg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTcn2qsjfcs/sS6vCPWitDMWsvpXLXSi6QJa5DTFGPo=; b=9qpitGgabb7OqxaMRWJLSve2R29Ye6Pk3pPHOMbH+t/p7MmA3U548OzZXfEdM6k0h3sU+eczBQyUY3h3wlB9sJqAj/Z2wXNzZonqRDxSGLgj8bYKDX7wz8gephMO6S5eSJb04TIMJLVUujV/FGerKqXttaT1aD3Ws7DenXUa5nA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: dfae215a2df38756 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CMWT6iiNU8gEDxrIInVTfjw+++1ZGaHiJgGxNV5h8ikmyLTVo72HZErQvkUGRSx9RaWPixgSvcH/7UL9z5b32OR2O73vmbMpt/pWlrjUEHrjUFazmiz/y3LNfW39fEMuot6XwU5kRkXFPHF96iRhybpbNYHuIq27PyyPBtSeLTsPqHyV91S2CZgDtW0fmS9SDHO+ltXl4NNAR5YbpfYbKE9+H2vjWHdjcCgyRa64ZMeBHbAr55h3ClKi+BcqYr6z0RbP6fNW8UnqXhLGZ4IRRqsh4ftlmVbbmE2OABlKBObEffDjuYG9ck5Kg6NXszQ19ob28wvEXl7F4qtEXzAPew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xTcn2qsjfcs/sS6vCPWitDMWsvpXLXSi6QJa5DTFGPo=; b=fGpgegX81ObHneF0RKf6v7uC77iBgUfNFAHc1qgqJAlC1QVmlIxn/zga4tJe0wutK9HXtYbBkS6B18CcXXfkzRpJ/dvJbp5phpKJ4sUgsIchQ24qaaQOR56u/r1hsKN2L40pTUnAP1mselZDqTDw6KDTzkNuRo0TabqGAI8/B9+ZNZO6wtWmGfLLMBUJBOBwbcdN3GHeLTuq9VjutnbZFCE9ReotlpVc1KjMTqFSENqX1BCOkoEqSysxCpUgKqA9i/070LAQ0ja0LE/7l6jfFpTF3JBmiQAOnPdZZYddVCidcEU+s+UJ+a96wf7qa+JT4B4r207NHquXkNktIJbFlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xTcn2qsjfcs/sS6vCPWitDMWsvpXLXSi6QJa5DTFGPo=; b=9qpitGgabb7OqxaMRWJLSve2R29Ye6Pk3pPHOMbH+t/p7MmA3U548OzZXfEdM6k0h3sU+eczBQyUY3h3wlB9sJqAj/Z2wXNzZonqRDxSGLgj8bYKDX7wz8gephMO6S5eSJb04TIMJLVUujV/FGerKqXttaT1aD3Ws7DenXUa5nA= From: Rahul Singh To: Jan Beulich CC: Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Thread-Topic: [PATCH 3/8] xen/evtchn: modify evtchn_bind_interdomain to allocate specified port Thread-Index: AQHYhkXgFvoQlpdPN0O1CKuVc36nOK1v9mEAgAADLoCAAAWTAIABVA4A Date: Wed, 6 Jul 2022 11:59:39 +0000 Message-ID: <46C308B8-E7D3-48F9-8BC6-662E725EEEC0@arm.com> References: <08fab20e71d280396d7b65397339ad9d9ab96d5c.1655903088.git.rahul.singh@arm.com> <9822e10e-ea7e-a39e-1270-14f0e2741325@suse.com> <473505a8-7df8-49a7-c33a-02b383efc22f@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: bac72ff6-44d6-4c6a-93c1-08da5f4705fd x-ms-traffictypediagnostic: AM0PR08MB3554:EE_|DBAEUR03FT014:EE_|VI1PR0802MB2528:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: PYW58KBXSLOSABBdnY88sE/4qcVvziBkTiWOogR++/sL4DPXxWiC1LX7NILCrQJQnKf3xaNkL2DhbvbyLulubTXh0i5t3/MLcx6JO8gN9wFrqp47pWh0YZVbwz3TzUrCZ3/pKT1rndNPKx0mhXkMEzO3zDygG2mO5960gJwy3fx0v7HB4HUmX9iErKKSBgsIyBVYelxOOfT2gjKBj4agFi1U9iRskBT/KFtuOQ7lseYsyTdbpWM4vxdsXqYS/MTv/B07zPmFA7eJkOPudmsKuXAMf6PBUqG0QdO/JzzFNIEd2yjB0CBaDK26QRPxso0TZxrw+hmEZem7O2ybEje5pgslE9YMwMOlISeTA2Rx6YDooX3RToy4VxzJ19tFmBkI0eQHH1w84INo4nlAgcqRdV60yIJtP7j/b2L497xeJ3a0u5pgAKEp6Md0IJnWu2E3rW7x9q1dTVpDPjed0MZDvFUxBU1Ik41Mev9W42KuNIa2JEOjDq9ELVtVBY+aiQfC3FPT3qnJi4yg1DG0mBV8hyWgSaP0IVynby1UMDPQ4N4A7XwLmFtOE9Zhfvn83wXlL52uhc0avRaXhBQ/96f3RdrO9sJuI69kFCgSMC0CmZyVVKl7RUpyx5RT7WN05TKURdlHJs/0mQEQNaGT4wNqdCjQNtGThQ/2pD4j/FMfuwXRsE8WKEPwIZDL6/eTWHBFLd3fHnIg4SlJT8b4S6YKcuHXJnCXOwrQRbhNYNcF0PC1CRShT+rOmD3j4LMSdjSD34LSJtwIUHv15MIalnKkyKK94cDrpbswWtYi2eisgMyMUZjR7L6hbW1GhlvVPMLPUtsNJxpeG2TkY0SZKbr1tCr5mrRj/pRJudgefmfJWPw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(136003)(396003)(6486002)(478600001)(54906003)(41300700001)(71200400001)(6512007)(26005)(316002)(122000001)(6916009)(8936002)(5660300002)(38070700005)(86362001)(53546011)(91956017)(186003)(8676002)(66556008)(4326008)(66476007)(2616005)(66446008)(64756008)(66946007)(76116006)(38100700002)(36756003)(2906002)(6506007)(33656002)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3554 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: cc0cc82b-473d-4f0a-a104-08da5f47011d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yi3Ul64pw2fV5SYHTqaTpnBsa1LpDofgDNsh84tCurf+BCs3MvoKkGJW8H5UaaLjq+w4b7nl+3UC39YERDvdBGpuDC3KxTkytWeGfmY9LoEHkYQcvsU+ju7Sww7Rtvp0hNq9oVW4XXc9hbqwX9NfnpAUpm4cLtz+kiw20pTUqlo9qwCCmZ3H/WmNG+MP5gJO35maPtq26hYwQbUtj8TxACh8S4bzDYXJskWuJNOxN3aHtpFM4ECYwlswXJsNOsrUKX4/Bjmb4OaUckyIXJG3xa0dQxz9rtO9h0R4guotisvVjggB77zDEo2cqf14Q8kxc3p7eMTV4uuAXSuJuP5Mz55VclJ4/bIYW7IKdzra5vxLfob7b/u7Iv0Nkhj6Qr8goaSPrZkKm9hVMv1COWYqZO4nBbVJMw3W/62eFXrYj/uX2XDQfCg6ran0gHoUDcVzY/sFW0ty0IcOUIi+Ym3GonYy4t5k8P+F/fWQAUXTUcLQXfEIx5jfHs5Zj4OL1XpfmnGMX9uFdJC+xA0kGe5umeo/QpGhJCRJADccMqSsQQR3RTh4G2r+AX1N4qi6LVDJDWszgk+01moFAugFxHrIBymtL5d6yCcyfSDnXGwnPuZkAcYGb1XgJxDIw7/FubCHHBRvoSj88IcUhBlgT0wkVcVo3SCuN/+cx0l+q59sEaoUvGqrhqEbaCzVEE8M91Kf9e2Hu2yZ3zUs0mD+EWplxzSUEORdNn+SZi3yZl+oGoxwiexBYwrxRbe7tdgkT/UW3LJwe65Ffmlu7E8Gg2nIvHbvacV8TQ/cZV/u0slwcP7ZxpHX1l/TUQxLvWmErdYR X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(36840700001)(46966006)(40470700004)(478600001)(5660300002)(8936002)(6862004)(6486002)(53546011)(33656002)(40460700003)(6506007)(86362001)(41300700001)(2906002)(26005)(6512007)(82740400003)(81166007)(356005)(36860700001)(82310400005)(47076005)(336012)(2616005)(186003)(40480700001)(83380400001)(70586007)(70206006)(54906003)(316002)(36756003)(8676002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 11:59:47.4011 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bac72ff6-44d6-4c6a-93c1-08da5f4705fd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2528 Hi Jan > On 5 Jul 2022, at 4:42 pm, Jan Beulich wrote: >=20 > On 05.07.2022 17:22, Julien Grall wrote: >> Hi Jan, >>=20 >> On 05/07/2022 16:11, Jan Beulich wrote: >>> On 22.06.2022 16:38, Rahul Singh wrote: >>>> @@ -387,8 +392,19 @@ int evtchn_bind_interdomain(evtchn_bind_interdoma= in_t *bind) >>>> spin_lock(&ld->event_lock); >>>> } >>>>=20 >>>> - if ( (lport =3D get_free_port(ld)) < 0 ) >>>> - ERROR_EXIT(lport); >>>> + if ( lport !=3D 0 ) >>>> + { >>>> + if ( (rc =3D evtchn_allocate_port(ld, lport)) !=3D 0 ) >>>> + ERROR_EXIT_DOM(rc, ld); >>>> + } >>>> + else >>>> + { >>>> + int alloc_port =3D get_free_port(ld); >>>> + >>>> + if ( alloc_port < 0 ) >>>> + ERROR_EXIT_DOM(alloc_port, ld); >>>> + lport =3D alloc_port; >>>> + } >>>=20 >>> This is then the 3rd instance of this pattern. I think the logic >>> wants moving into get_free_port() (perhaps with a name change). >>=20 >> I think the code below would be suitable. I can send it or Rahul can=20 >> re-use the commit [1]: >=20 > Ah yes; probably makes sense (right now) only in the context of his > series. Ack.=20 >=20 >> --- a/xen/common/event_channel.c >> +++ b/xen/common/event_channel.c >> @@ -292,6 +292,18 @@ void evtchn_free(struct domain *d, struct evtchn *c= hn) >> xsm_evtchn_close_post(chn); >> } >>=20 >> +static int evtchn_get_port(struct domain *d, uint32_t port) >=20 > Preferably evtchn_port_t. Ack.=20 >=20 >> +{ >> + int rc; >> + >> + if ( port !=3D 0 ) >> + rc =3D evtchn_allocate_port(d, port); >> + else >> + rc =3D get_free_port(d); >> + >> + return rc !=3D 0 ? rc : port; >=20 > We commonly use "rc ?: port" in such cases. At which point I'd be > inclined to make it just >=20 > static int evtchn_get_port(struct domain *d, evtchn_port_t port) > { > return (port ? evtchn_allocate_port(d, port) > : get_free_port(d)) ?: port; > } >=20 > But I can see you or others having reservations against such ... If everyone agree with above code I will modify the Julien patch to include this code in next version. Regards, Rahul From xen-devel-bounces@lists.xenproject.org Wed Jul 06 12:12:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 12:12:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362219.592166 (Exim 4.92) (envelope-from ) id 1o93sw-0001SL-6S; Wed, 06 Jul 2022 12:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362219.592166; Wed, 06 Jul 2022 12:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93sw-0001SE-3F; Wed, 06 Jul 2022 12:12:02 +0000 Received: by outflank-mailman (input) for mailman id 362219; Wed, 06 Jul 2022 12:12:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o93sv-0001S8-7e for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 12:12:01 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d639c0f4-fd24-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 14:12:00 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id d16so15460646wrv.10 for ; Wed, 06 Jul 2022 05:11:59 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id r12-20020a05600c35cc00b003a04e900552sm25651811wmq.1.2022.07.06.05.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 05:11:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d639c0f4-fd24-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w2XRrjOrjpaz12Jeqf1YAACZjWuCue/f9szg5gZlJPQ=; b=NP/L+f/O8awS0i+uldSRpWzqBMjnmJ7EyhXpdvSOXO/IEiTV/hvqcK4Oom9KNwSP03 r8t5ugr9gY+xOKQNQySQ1/iQEAmyKSih+5DMCxj1R+m22yL3nPc88FPKJv8/sAAqS2HN PfeZNLNZOh05x5AGpgKjIiIeVCn06Hj6QZlxmsBBLKgKP7OCNCHz2uJINtdjHIi90V4/ 2T+uwLWDnMTNSRp+5ieu9/chJgVn68NxHSyOTTaIjrSxM7hQvjhWkP44p9eMSe5pZcCz ersNPWw4VuH0ZE2cfZ4UP4QJSKAccRJORTQ9NoI+UZmCRCB8QLr+lmtJhyTGAxe+ptzm oZ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w2XRrjOrjpaz12Jeqf1YAACZjWuCue/f9szg5gZlJPQ=; b=eOlWZ5A8bmJWDMRM8j7vZl6vTujV9IY5T62kgI/p3tQMzN976Ipvcrh9DQD/0AJI+1 EOLPbO5n5E8y1pQwFRetziS9dcRnt2Ep8Ett9QVIrZSQJmg3Es1JfUHPaayFnbbKYRni jqFrlN1h21iL52IqZLT+YpF+sG3slelcmnoLpq2pHVdcsuwKAWEz++asNdbrgu9b4Gtt NeHhLoOFbMmP2l2cUSqAvqB9oIS+gBmdRS3XH2iqeNvfCt4M+Z07p3bkG4YDzfK1IlrJ 2JL38oHj65ykW0anSD8L0h9Ho023NrLlP78kz8dCvk+y1Cy8AySsGJVk2SFANKfXvgF2 ZmzQ== X-Gm-Message-State: AJIora+TzBzk2gt0ZWhkQC6PUlIq28HcirVPGqjLtgZ27VCLItQlrADS K9qyhDLUZ2Lian+fIDp6uHKuGo5m5MA= X-Google-Smtp-Source: AGRyM1t6fjaKIMGCK85ynYVZJHCY4T0hBuhA458hbYRcey/UQZ5+Y/Swtlvh10Mc47OhNrPqDcGFZA== X-Received: by 2002:a5d:4f02:0:b0:21d:63f6:380c with SMTP id c2-20020a5d4f02000000b0021d63f6380cmr19362119wru.635.1657109518960; Wed, 06 Jul 2022 05:11:58 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: [PATCH v2] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation Date: Wed, 6 Jul 2022 15:11:56 +0300 Message-Id: <20220706121156.666500-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add the function prototype of show_stack() in header file so that it is visible before its definition in traps.c. Although show_stack() is referenced only in traps.c, it is declared with external linkage because, during development, it is often called also by other files for debugging purposes. Declaring it static would increase development effort. Add appropriate comment Signed-off-by: Xenia Ragiadakou --- Changes in v2: - add a new line after show_stack() to make obvious to which set of functions the comment is referring to. xen/arch/arm/include/asm/processor.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h index 4188ec6bfb..55f56b33bc 100644 --- a/xen/arch/arm/include/asm/processor.h +++ b/xen/arch/arm/include/asm/processor.h @@ -558,7 +558,10 @@ extern register_t __cpu_logical_map[]; void panic_PAR(uint64_t par); void show_execution_state(const struct cpu_user_regs *regs); +/* Debugging functions are declared with external linkage to aid development. */ void show_registers(const struct cpu_user_regs *regs); +void show_stack(const struct cpu_user_regs *regs); + //#define dump_execution_state() run_in_exception_handler(show_execution_state) #define dump_execution_state() WARN() -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 13:18:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 13:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362235.592188 (Exim 4.92) (envelope-from ) id 1o94uV-00010z-7B; Wed, 06 Jul 2022 13:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362235.592188; Wed, 06 Jul 2022 13:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o94uV-00010s-49; Wed, 06 Jul 2022 13:17:43 +0000 Received: by outflank-mailman (input) for mailman id 362235; Wed, 06 Jul 2022 13:17:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o94uT-00010i-TY; Wed, 06 Jul 2022 13:17:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o94uT-0001Y2-Me; Wed, 06 Jul 2022 13:17:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o94uT-0002HO-BR; Wed, 06 Jul 2022 13:17:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o94uT-0000Ob-Ax; Wed, 06 Jul 2022 13:17:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZNybXjSun2xIDw2JgdMpFKeuzYr2Almk+WUqVw632dg=; b=R/JiRBOKXDX8MJRw61YhQmfpq1 i+wrGD4UMIjMKInTAsvJujoMc2v2rFJi8V3mIIxPqFq8WztxirPjK3d4JcwVhlB9hr2sqEBvEBZEU axdbrMlu5kTwz/Q8PIwtVoBvkGOU0F1ZKH9CqID1q6+n3tn9IjY9eqomeUGVRX6sM4xc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171516: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict::broken:regression xen-unstable:build-arm64-pvops:kernel-build:fail:regression xen-unstable:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:host-install(5):broken:heisenbug xen-unstable:test-amd64-i386-libvirt-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-examine:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Wed, 06 Jul 2022 13:17:41 +0000 flight 171516 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171516/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken build-arm64-pvops 6 kernel-build fail in 171496 REGR. vs. 171516 Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 5 host-install(5) broken pass in 171496 test-amd64-i386-libvirt-pair 11 xen-install/dst_host fail pass in 171496 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-examine 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl-xsm 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 171496 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 171496 n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171496 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171496 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171496 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171496 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171496 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171496 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171496 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171496 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171496 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171496 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171496 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171496 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171516 2022-07-06 01:53:06 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair fail test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict broken broken-step test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict host-install(5) Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Jul 06 13:36:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 13:36:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362243.592199 (Exim 4.92) (envelope-from ) id 1o95Cj-00041g-R2; Wed, 06 Jul 2022 13:36:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362243.592199; Wed, 06 Jul 2022 13:36:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Cj-00041Z-NN; Wed, 06 Jul 2022 13:36:33 +0000 Received: by outflank-mailman (input) for mailman id 362243; Wed, 06 Jul 2022 13:36:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Ci-00041O-4h; Wed, 06 Jul 2022 13:36:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Ch-0001rL-QA; Wed, 06 Jul 2022 13:36:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Ch-0002lO-FQ; Wed, 06 Jul 2022 13:36:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o95Ch-0000pF-Ev; Wed, 06 Jul 2022 13:36:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y3GUKBcjeSo9bSDCRBlv0ECtDOWXU22R5u3mZrSglic=; b=TIrKP1WBq9iG/AiyQtu2bT43Qg YS8LntSdIRZLF1Cp3b3n5Gn+fvusSLZT78vJZy/qGSZLRGdwcmJC7jSXXkWZ3hmEho4ja5msjSYPy wP07nVqMDZeSFpq8N32qtIULmn/mfPzf2SLi8FLG9YPZf7lyFdaMoaC87lQxNbZeusGo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171520: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-arm64-pvops:kernel-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=35609616a2353d23b43d6c490daed333f60c917c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 06 Jul 2022 13:36:31 +0000 flight 171520 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171520/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-pvops 6 kernel-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 35609616a2353d23b43d6c490daed333f60c917c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 726 days Failing since 151818 2020-07-11 04:18:52 Z 725 days 707 attempts Testing same since 171497 2022-07-05 04:20:30 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops fail build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115185 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 13:53:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 13:53:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362254.592209 (Exim 4.92) (envelope-from ) id 1o95Su-00071Q-Fx; Wed, 06 Jul 2022 13:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362254.592209; Wed, 06 Jul 2022 13:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Su-00071J-DH; Wed, 06 Jul 2022 13:53:16 +0000 Received: by outflank-mailman (input) for mailman id 362254; Wed, 06 Jul 2022 13:53:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95St-00071D-OX for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 13:53:15 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9a77d89-fd32-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 15:53:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9a77d89-fd32-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657115594; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=8PUQhGIEdViSZ8UN1+9n2akq3Ms/dOJCQVsz0k3zrAg=; b=WGhtt4W7GwvNeetrW9Hr3QsgiDcsVbx0huGE/FFuOt3m8HpgwG8/EM9o bk5a9LCSYyU1JQjQ+XtTWybyclNSgvhUzRvV02BC6DjqtNhBlnDQ7QmmO Qr/nKy9bNKnFgqTrMe2Vb5SLddz/VsvL4AaRBxMfz8F5HxU8TlaUaJYiK Q=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75190483 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LxY8Tq0zikgrNele/fbD5cxxkn2cJEfYwER7XKvMYLTBsI5bpzVRx jNJW2+PbquIZzTxL992PonipkNUvsWAzNZiTQtupC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1Ek/NtTo5w7Rj2tEw34Dja++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1cidvzSRgQEJeds+o/UEV3Gix4ZYdZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHEMYQFtXwm4SzfCf8+aZvCX7/L9ZlT2zJYasVmQquHN pJFOWEHgBLoSE1kfXU1DM4F29ynvljvcw9KqluXqv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0z7HxUbOdq32TeDtHW2iYfnkTvgXYMOFJWx7vNwnECI3WsXFQEXUl2g5/K+jyaWS99Zb kAZ5Ccqhawz71CwCMnwWQWip3yJtQJaXMBfe8U44gyQzqvf4y6CG3MJCDVGbbQOr9QqTDYn0 luImdLBBjF1trCRD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznX+okU66qt/PPSBr+4 TPWgyEzge05kptev0mkxmwrkw5At7CQEFNqv12PDj//hu9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 RDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0e5eIFcFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQP8cpKFHdpno3Ox74M4XRfK8EyPhXB HtmWZz0USZy5VpPllJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WUN5vYwtaQPUBshgtfvsiFyMr 753aprRoz0CAbKWX8Ui2dNKRbz8BSNjVc6eRg0+XrPrHzeK70l9UqCPmuJ8INM090mX/8+Rl kyAtoZj4AKXrRX6xc+iMxiPtJuHsU5DkE8G IronPort-HdrOrdr: A9a23:qRREpqivthd/jDXY17Sszl1GpXBQXtQji2hC6mlwRA09TySZ// rOoB19726StN9xYgBYpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ866U 4KSchD4bPLY2SS9fyKhTWFLw== X-IronPort-AV: E=Sophos;i="5.92,250,1650945600"; d="scan'208";a="75190483" From: George Dunlap To: CC: George Dunlap , Wei Liu , "Andrew Cooper" , Jan Beulich , "Stefano Stabellini" , Julien Grall , "Daniel P . Smith" Subject: [PATCH] MAINTAINERS: Make Daniel P. Smith sole XSM maintainer Date: Wed, 6 Jul 2022 14:52:45 +0100 Message-ID: <20220706135245.64915-1-george.dunlap@citrix.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain While mail hasn't been bouncing, Daniel De Graaf has not been responding to patch submissions or otherwise interacting with the community for several years. Daniel Smith has at least been working with the code, and is a regular member of our community; and he has agreed to step up into the role. Signed-off-by: George Dunlap --- CC: Wei Liu CC: Andrew Cooper CC: Jan Beulich CC: Stefano Stabellini CC: Julien Grall CC: Daniel P. Smith --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8a99526784..e12c499a28 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -649,8 +649,7 @@ F: xen/common/trace.c F: xen/include/xen/trace.h XSM/FLASK -M: Daniel De Graaf -R: Daniel P. Smith +M: Daniel P. Smith S: Supported F: tools/flask/ F: xen/include/xsm/ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 13:58:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 13:58:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362252.592221 (Exim 4.92) (envelope-from ) id 1o95Xx-0007rI-6b; Wed, 06 Jul 2022 13:58:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362252.592221; Wed, 06 Jul 2022 13:58:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Xx-0007rB-1y; Wed, 06 Jul 2022 13:58:29 +0000 Received: by outflank-mailman (input) for mailman id 362252; Wed, 06 Jul 2022 13:51:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95R6-0006zi-C1 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 13:51:24 +0000 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7babe9b-fd32-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 15:51:23 +0200 (CEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-31cb2c649f7so66161287b3.11 for ; Wed, 06 Jul 2022 06:51:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7babe9b-fd32-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5SiPC3jj492VC8TfaG5lxiX62rjLNKysidcQlbSYqow=; b=UWYqV0K+ik5Wj4BVvddmvfJa7bgzjlAqRtfQqPMO1VPWC5wrHl/mLcNuYY6B6nAqH1 bAyduHFyhkl7p+8TZO3K4Hvl2qYqRnj96WiTCpUJTDVIh8JM2tOOIj2Xe+CUIGuu7xua a4kVkhcqoYGL1bXReRQbtXcnvY7vCRRPljaxRdiK0XpJluoBlj8ZgkUt+yI0adR6SsuB vAFhsw4HJq3gI6MvEJruwpX+RqbxRNYGENpE+QJXllOcsKI0ogg/fEpJDo9lwoZcrs4P ljspHfgp8TrOfxXh9FSWy1Yo4K5GwrmoWwOtFI9p5udi8yytJSvjJ8iz8NgJ03N0DrAt 9FUg== X-Gm-Message-State: AJIora/yBDk29+amlyurx8T0BPV7wYo8KLVXX3AW4k1D55gUYGwkZqeW 38Vj2VTOUZoxP2R2/MkQryl880Iz3+0uf1cG5RQ= X-Google-Smtp-Source: AGRyM1t2zFLeLAi3TOz/3FKNOaozLIghzMJavy2698E42fvxt6d4SsTob1/anQx1a1kTDZPSEUZEInHEN/JL2sa2rXc= X-Received: by 2002:a81:1b97:0:b0:2db:640f:49d8 with SMTP id b145-20020a811b97000000b002db640f49d8mr45075306ywb.326.1657115480888; Wed, 06 Jul 2022 06:51:20 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144516.109792837@infradead.org> In-Reply-To: <20220608144516.109792837@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 15:51:09 +0200 Message-ID: Subject: Re: [PATCH 03/36] cpuidle/poll: Ensure IRQ state is invariant To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > cpuidle_state::enter() methods should be IRQ invariant > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Rafael J. Wysocki > --- > drivers/cpuidle/poll_state.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > --- a/drivers/cpuidle/poll_state.c > +++ b/drivers/cpuidle/poll_state.c > @@ -17,7 +17,7 @@ static int __cpuidle poll_idle(struct cp > > dev->poll_time_limit = false; > > - local_irq_enable(); > + raw_local_irq_enable(); > if (!current_set_polling_and_test()) { > unsigned int loop_count = 0; > u64 limit; > @@ -36,6 +36,8 @@ static int __cpuidle poll_idle(struct cp > } > } > } > + raw_local_irq_disable(); > + > current_clr_polling(); > > return index; > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 13:58:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 13:58:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362259.592227 (Exim 4.92) (envelope-from ) id 1o95Xx-0007un-GF; Wed, 06 Jul 2022 13:58:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362259.592227; Wed, 06 Jul 2022 13:58:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Xx-0007uK-A5; Wed, 06 Jul 2022 13:58:29 +0000 Received: by outflank-mailman (input) for mailman id 362259; Wed, 06 Jul 2022 13:54:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95UK-0007Zb-Vl for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 13:54:44 +0000 Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 301cc61e-fd33-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 15:54:44 +0200 (CEST) Received: by mail-yb1-f176.google.com with SMTP id 64so18154140ybt.12 for ; Wed, 06 Jul 2022 06:54:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 301cc61e-fd33-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nGlq0tAOl9peVDy+2hDU8oij0psSLrDezDLIhvJH3CU=; b=qIm3w2oSvR4xJEbz8Ki6ixlu+SWev4gdrkmQ2VBpJcgoO49ZOxhgyBY0qIJoQ8KLhX LgFFMLUTzOBMxDeDbzVIFmLsUOmG4YyQzez8vDvYqOoL130+uOLn4KJAu2aKQLKLNl1j U7GYicEiSeyWdkE5DKF/vmYkBTotN9WdVug+Iqxghgye4i/KpeTLWz9UwhEG3OqDMYAz pD4Aq3eDDJlLFbFaXIh5fxyV7ruyq77GEhPbwmuaz9REG9WphZIyiv0VeRss7VjKCKTj chcc4hKa3TGX86WxqVaFNn2YPb4yt16B0TTWptdPuewtKFB7buD3JoA+Gz7XnPYFfZo/ pZrA== X-Gm-Message-State: AJIora+QzHySWJ7rphAt0jYiM4vrnV7FoySHS4RWImG5bI5M1fX7pyFj wUa/v/CkNYa4d80FvpdKi5MluQOyQi39dTpgie0= X-Google-Smtp-Source: AGRyM1tDetZqwrRScub6Y4Pn1s0tSkry0FvKlyTlHU1qOUr14WujFHx6NLxGPd7DkQtOavHEbmevSefDFcyAl6P8ZZY= X-Received: by 2002:a25:fb02:0:b0:66e:3db9:5d49 with SMTP id j2-20020a25fb02000000b0066e3db95d49mr20145358ybe.137.1657115683016; Wed, 06 Jul 2022 06:54:43 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144516.235041924@infradead.org> In-Reply-To: <20220608144516.235041924@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 15:54:32 +0200 Message-ID: Subject: Re: [PATCH 05/36] cpuidle: Move IRQ state validation To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > Make cpuidle_enter_state() consistent with the s2idle variant and > verify ->enter() always returns with interrupts disabled. > > Signed-off-by: Peter Zijlstra (Intel) > --- > drivers/cpuidle/cpuidle.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -234,7 +234,11 @@ int cpuidle_enter_state(struct cpuidle_d > stop_critical_timings(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > rcu_idle_enter(); > + > entered_state = target_state->enter(dev, drv, index); > + if (WARN_ONCE(!irqs_disabled(), "%ps leaked IRQ state", target_state->enter)) I'm not sure if dumping a call trace here is really useful and WARN_ON() often gets converted to panic(). I would print an error message with pr_warn_once(). Otherwise LGTM. > + raw_local_irq_disable(); > + > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > rcu_idle_exit(); > start_critical_timings(); > @@ -246,12 +250,8 @@ int cpuidle_enter_state(struct cpuidle_d > /* The cpu is no longer idle or about to enter idle. */ > sched_idle_set_state(NULL); > > - if (broadcast) { > - if (WARN_ON_ONCE(!irqs_disabled())) > - local_irq_disable(); > - > + if (broadcast) > tick_broadcast_exit(); > - } > > if (!cpuidle_state_is_coupled(drv, index)) > local_irq_enable(); > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 14:00:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 14:00:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362271.592243 (Exim 4.92) (envelope-from ) id 1o95Zi-0001Pa-Sg; Wed, 06 Jul 2022 14:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362271.592243; Wed, 06 Jul 2022 14:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Zi-0001PT-PK; Wed, 06 Jul 2022 14:00:18 +0000 Received: by outflank-mailman (input) for mailman id 362271; Wed, 06 Jul 2022 13:59:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95Z1-0000Wk-B5 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 13:59:35 +0000 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dc9bcaa9-fd33-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 15:59:34 +0200 (CEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-3137316bb69so140642067b3.10 for ; Wed, 06 Jul 2022 06:59:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dc9bcaa9-fd33-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Onduqp6mjVbUTy8onn0jWt/mqpI9kGBQEYh+QUeZcBU=; b=3BzfFxCiTFPQ/pzeJcbUgBBMUJwnf/PxqYfknDjKqRp3DgDpr7v7oKYsa4X+Lc/mY3 MDZ70WS8ulqxtiBV0i02dIezuqn9EWQhRdNS8Nqsr0GfQjPigYofsmWIUt2moq3Te2Wn O2+jyjUpenbU58TkTvl5FywWUnxKFMghgYw4IF1ixGafajlxi97p1Qjew0mytzEJTmy+ 6XThNQr11Qhwcz986EtXMgSbmGwy6ba/I8Gz2NnLNNGvvyCvC4VfYSnglm8TknuqvBbn Qi30kUBmfC3mwY1FT8s3ssQwnIeZjCnA/g72nIgyjeVW6faHengv6fBpqgoNqvz9H7n5 k65g== X-Gm-Message-State: AJIora/43qGKUrYB2nYJFlI0KBtSnCZlqOFb4mtKNU/cPkYej1BKJnCI WeHzgqLI8Agt37PsJiKGPDVZTmcTU1t0VPg0wX0= X-Google-Smtp-Source: AGRyM1tNbC/Hml4tsQcA7xFkjwPTBe4V9sculTi4g4WqVg8ltnNA+flCFfg0CHpb2ZdV5OvqewQ30xyxgoEo0qXCWHo= X-Received: by 2002:a81:1b97:0:b0:2db:640f:49d8 with SMTP id b145-20020a811b97000000b002db640f49d8mr45117410ywb.326.1657115972382; Wed, 06 Jul 2022 06:59:32 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144516.998681585@infradead.org> In-Reply-To: <20220608144516.998681585@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 15:59:21 +0200 Message-ID: Subject: Re: [PATCH 17/36] acpi_idle: Remove tracing To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > All the idle routines are called with RCU disabled, as such there must > not be any tracing inside. > > Signed-off-by: Peter Zijlstra (Intel) This actually does some additional code duplication cleanup which would be good to mention in the changelog. Or even move to a separate patch for that matter. Otherwise LGTM. > --- > drivers/acpi/processor_idle.c | 24 +++++++++++++----------- > 1 file changed, 13 insertions(+), 11 deletions(-) > > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -108,8 +108,8 @@ static const struct dmi_system_id proces > static void __cpuidle acpi_safe_halt(void) > { > if (!tif_need_resched()) { > - safe_halt(); > - local_irq_disable(); > + raw_safe_halt(); > + raw_local_irq_disable(); > } > } > > @@ -524,16 +524,21 @@ static int acpi_idle_bm_check(void) > return bm_status; > } > > -static void wait_for_freeze(void) > +static __cpuidle void io_idle(unsigned long addr) > { > + /* IO port based C-state */ > + inb(addr); > + > #ifdef CONFIG_X86 > /* No delay is needed if we are in guest */ > if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) > return; > #endif > - /* Dummy wait op - must do something useless after P_LVL2 read > - because chipsets cannot guarantee that STPCLK# signal > - gets asserted in time to freeze execution properly. */ > + /* > + * Dummy wait op - must do something useless after P_LVL2 read > + * because chipsets cannot guarantee that STPCLK# signal > + * gets asserted in time to freeze execution properly. > + */ > inl(acpi_gbl_FADT.xpm_timer_block.address); > } > > @@ -553,9 +558,7 @@ static void __cpuidle acpi_idle_do_entry > } else if (cx->entry_method == ACPI_CSTATE_HALT) { > acpi_safe_halt(); > } else { > - /* IO port based C-state */ > - inb(cx->address); > - wait_for_freeze(); > + io_idle(cx->address); > } > > perf_lopwr_cb(false); > @@ -577,8 +580,7 @@ static int acpi_idle_play_dead(struct cp > if (cx->entry_method == ACPI_CSTATE_HALT) > safe_halt(); > else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) { > - inb(cx->address); > - wait_for_freeze(); > + io_idle(cx->address); > } else > return -ENODEV; > > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 14:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 14:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362275.592254 (Exim 4.92) (envelope-from ) id 1o95bP-0002Dl-Ec; Wed, 06 Jul 2022 14:02:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362275.592254; Wed, 06 Jul 2022 14:02:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95bP-0002De-BT; Wed, 06 Jul 2022 14:02:03 +0000 Received: by outflank-mailman (input) for mailman id 362275; Wed, 06 Jul 2022 14:00:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95a5-0001vY-Fs for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 14:00:41 +0000 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 04b37a4c-fd34-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 16:00:40 +0200 (CEST) Received: by mail-yb1-f182.google.com with SMTP id l11so27423688ybu.13 for ; Wed, 06 Jul 2022 07:00:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04b37a4c-fd34-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lln/3deL7qOtLziJcXYPqqy6CqnXU6Vj8A13Rxsyfck=; b=IPv7KWmzvFJ3hZwCR1AtdOj/vsRetuCSFAMtYQKZ2upkHH/A47LvnV7KGZ8XQa4lxe FLgwrTFFPo+esi3YnIJ2LhXWGQIhVey8f0DskNolZrBj6YJoPn1/KL767O2lWx9kunxt Lqu/NK4kysGDfUd7PY6c/RdOkhRO80UjsMme/RWa5ePS0pyB5T2R6+TbEUVc3J9IR/zl Yi5zBtvIrOy4Q4VbhU02wQWT5KKwjaG30K6oTb0IoaG78mgMgbY6qHAIBIcR53wfrRCt BQRZxPZupqM+uW0+mezStKTcE6tmBtXkRPA/ItarYuFxW20sCpJEEhWBtW2degMf6ydT 4btA== X-Gm-Message-State: AJIora8qciUqdC5TZ6cRuzCPpOtNDOStI/JvuKnYFxhF7zIyHZ0tZHN0 aVVRpzi7sWSGFNxOaC37YbI1plsjKW22Ya0fVlw= X-Google-Smtp-Source: AGRyM1vGBIO6ejUezqbzrzuaUC5etUaxh8lxWDh293Sam2Jc/zFfeBj4g08hdYpvSA8zzuIj5u2PxdHOfRWqZSWT82c= X-Received: by 2002:a05:6902:50e:b0:66e:7f55:7a66 with SMTP id x14-20020a056902050e00b0066e7f557a66mr7763507ybs.365.1657116039561; Wed, 06 Jul 2022 07:00:39 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144517.061583457@infradead.org> In-Reply-To: <20220608144517.061583457@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 16:00:28 +0200 Message-ID: Subject: Re: [PATCH 18/36] cpuidle: Annotate poll_idle() To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:46 PM Peter Zijlstra wrote: > > The __cpuidle functions will become a noinstr class, as such they need > explicit annotations. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Rafael J. Wysocki > --- > drivers/cpuidle/poll_state.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > --- a/drivers/cpuidle/poll_state.c > +++ b/drivers/cpuidle/poll_state.c > @@ -13,7 +13,10 @@ > static int __cpuidle poll_idle(struct cpuidle_device *dev, > struct cpuidle_driver *drv, int index) > { > - u64 time_start = local_clock(); > + u64 time_start; > + > + instrumentation_begin(); > + time_start = local_clock(); > > dev->poll_time_limit = false; > > @@ -39,6 +42,7 @@ static int __cpuidle poll_idle(struct cp > raw_local_irq_disable(); > > current_clr_polling(); > + instrumentation_end(); > > return index; > } > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 14:04:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 14:04:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362288.592264 (Exim 4.92) (envelope-from ) id 1o95dT-0002np-UV; Wed, 06 Jul 2022 14:04:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362288.592264; Wed, 06 Jul 2022 14:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95dT-0002ni-RY; Wed, 06 Jul 2022 14:04:11 +0000 Received: by outflank-mailman (input) for mailman id 362288; Wed, 06 Jul 2022 14:03:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95cQ-0002l5-En for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 14:03:06 +0000 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ab8c55c-fd34-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 16:03:05 +0200 (CEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-31c9b70c382so78568327b3.6 for ; Wed, 06 Jul 2022 07:03:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ab8c55c-fd34-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WBBLwGm3VvIAnm4uSuSyiWShri4w+bgQrIyP7HIMtP0=; b=25KDnRB5iR2bY/7u3WmcRU/XRZ3vszzGPCEKTRhQAhe73Lx18Sw+kuTwIj0DHOdfhw 5xCrECSLWfilz9lJp9D67XYKQgqbMrcjG2UxLDd0GTyvvFVt3uzQQrEwTIk9fCi86VH8 54HJqnRtoF1lkZ2Avuhqq7/K7vyRkPlNgaw8ymLUuW3ojXdq0xHatpxwkIYswUhCQ4Iq DpY2206V5sTpqOE2y666OxXanE2XYhllWyHln4Kfylsdqe8WfJYMu1LpGJ7Lj7b2bXM4 EgVxhGwxB+RUEgwfzSA1d3lGR4VsRg/0LfDrmKshx2Xx8N59kDG8M/WNV9yIpCRjp6h9 2cpg== X-Gm-Message-State: AJIora8sDTrov2UIN+7vkwv+OtbhQ2qAyMhBxUfmwZrdw7yKvwJqyLIA ABSmkZMuMbCyaZ1V09wl4JJd29kPjpCHIDOpJCQ= X-Google-Smtp-Source: AGRyM1shXjwii2Xu/qgQ1B1HadHYSMjqitGmbFlHxf4P7RndZwyBhPC2CaCRixiXqBuDMvjO7JXHYGnoD2iVhXDPhek= X-Received: by 2002:a81:a184:0:b0:31c:b00e:b5c4 with SMTP id y126-20020a81a184000000b0031cb00eb5c4mr15058481ywg.149.1657116183677; Wed, 06 Jul 2022 07:03:03 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144517.188449351@infradead.org> In-Reply-To: <20220608144517.188449351@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 16:02:52 +0200 Message-ID: Subject: Re: [PATCH 20/36] arch/idle: Change arch_cpu_idle() IRQ behaviour To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:46 PM Peter Zijlstra wrote: > > Current arch_cpu_idle() is called with IRQs disabled, but will return > with IRQs enabled. > > However, the very first thing the generic code does after calling > arch_cpu_idle() is raw_local_irq_disable(). This means that > architectures that can idle with IRQs disabled end up doing a > pointless 'enable-disable' dance. > > Therefore, push this IRQ disabling into the idle function, meaning > that those architectures can avoid the pointless IRQ state flipping. > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki > --- > arch/alpha/kernel/process.c | 1 - > arch/arc/kernel/process.c | 3 +++ > arch/arm/kernel/process.c | 1 - > arch/arm/mach-gemini/board-dt.c | 3 ++- > arch/arm64/kernel/idle.c | 1 - > arch/csky/kernel/process.c | 1 - > arch/csky/kernel/smp.c | 2 +- > arch/hexagon/kernel/process.c | 1 - > arch/ia64/kernel/process.c | 1 + > arch/microblaze/kernel/process.c | 1 - > arch/mips/kernel/idle.c | 8 +++----- > arch/nios2/kernel/process.c | 1 - > arch/openrisc/kernel/process.c | 1 + > arch/parisc/kernel/process.c | 2 -- > arch/powerpc/kernel/idle.c | 5 ++--- > arch/riscv/kernel/process.c | 1 - > arch/s390/kernel/idle.c | 1 - > arch/sh/kernel/idle.c | 1 + > arch/sparc/kernel/leon_pmc.c | 4 ++++ > arch/sparc/kernel/process_32.c | 1 - > arch/sparc/kernel/process_64.c | 3 ++- > arch/um/kernel/process.c | 1 - > arch/x86/coco/tdx/tdx.c | 3 +++ > arch/x86/kernel/process.c | 15 ++++----------- > arch/xtensa/kernel/process.c | 1 + > kernel/sched/idle.c | 2 -- > 26 files changed, 28 insertions(+), 37 deletions(-) > > --- a/arch/alpha/kernel/process.c > +++ b/arch/alpha/kernel/process.c > @@ -57,7 +57,6 @@ EXPORT_SYMBOL(pm_power_off); > void arch_cpu_idle(void) > { > wtint(0); > - raw_local_irq_enable(); > } > > void arch_cpu_idle_dead(void) > --- a/arch/arc/kernel/process.c > +++ b/arch/arc/kernel/process.c > @@ -114,6 +114,8 @@ void arch_cpu_idle(void) > "sleep %0 \n" > : > :"I"(arg)); /* can't be "r" has to be embedded const */ > + > + raw_local_irq_disable(); > } > > #else /* ARC700 */ > @@ -122,6 +124,7 @@ void arch_cpu_idle(void) > { > /* sleep, but enable both set E1/E2 (levels of interrupts) before committing */ > __asm__ __volatile__("sleep 0x3 \n"); > + raw_local_irq_disable(); > } > > #endif > --- a/arch/arm/kernel/process.c > +++ b/arch/arm/kernel/process.c > @@ -78,7 +78,6 @@ void arch_cpu_idle(void) > arm_pm_idle(); > else > cpu_do_idle(); > - raw_local_irq_enable(); > } > > void arch_cpu_idle_prepare(void) > --- a/arch/arm/mach-gemini/board-dt.c > +++ b/arch/arm/mach-gemini/board-dt.c > @@ -42,8 +42,9 @@ static void gemini_idle(void) > */ > > /* FIXME: Enabling interrupts here is racy! */ > - local_irq_enable(); > + raw_local_irq_enable(); > cpu_do_idle(); > + raw_local_irq_disable(); > } > > static void __init gemini_init_machine(void) > --- a/arch/arm64/kernel/idle.c > +++ b/arch/arm64/kernel/idle.c > @@ -42,5 +42,4 @@ void noinstr arch_cpu_idle(void) > * tricks > */ > cpu_do_idle(); > - raw_local_irq_enable(); > } > --- a/arch/csky/kernel/process.c > +++ b/arch/csky/kernel/process.c > @@ -101,6 +101,5 @@ void arch_cpu_idle(void) > #ifdef CONFIG_CPU_PM_STOP > asm volatile("stop\n"); > #endif > - raw_local_irq_enable(); > } > #endif > --- a/arch/csky/kernel/smp.c > +++ b/arch/csky/kernel/smp.c > @@ -314,7 +314,7 @@ void arch_cpu_idle_dead(void) > while (!secondary_stack) > arch_cpu_idle(); > > - local_irq_disable(); > + raw_local_irq_disable(); > > asm volatile( > "mov sp, %0\n" > --- a/arch/hexagon/kernel/process.c > +++ b/arch/hexagon/kernel/process.c > @@ -44,7 +44,6 @@ void arch_cpu_idle(void) > { > __vmwait(); > /* interrupts wake us up, but irqs are still disabled */ > - raw_local_irq_enable(); > } > > /* > --- a/arch/ia64/kernel/process.c > +++ b/arch/ia64/kernel/process.c > @@ -241,6 +241,7 @@ void arch_cpu_idle(void) > (*mark_idle)(1); > > raw_safe_halt(); > + raw_local_irq_disable(); > > if (mark_idle) > (*mark_idle)(0); > --- a/arch/microblaze/kernel/process.c > +++ b/arch/microblaze/kernel/process.c > @@ -138,5 +138,4 @@ int dump_fpu(struct pt_regs *regs, elf_f > > void arch_cpu_idle(void) > { > - raw_local_irq_enable(); > } > --- a/arch/mips/kernel/idle.c > +++ b/arch/mips/kernel/idle.c > @@ -33,13 +33,13 @@ static void __cpuidle r3081_wait(void) > { > unsigned long cfg = read_c0_conf(); > write_c0_conf(cfg | R30XX_CONF_HALT); > - raw_local_irq_enable(); > } > > void __cpuidle r4k_wait(void) > { > raw_local_irq_enable(); > __r4k_wait(); > + raw_local_irq_disable(); > } > > /* > @@ -57,7 +57,6 @@ void __cpuidle r4k_wait_irqoff(void) > " .set arch=r4000 \n" > " wait \n" > " .set pop \n"); > - raw_local_irq_enable(); > } > > /* > @@ -77,7 +76,6 @@ static void __cpuidle rm7k_wait_irqoff(v > " wait \n" > " mtc0 $1, $12 # stalls until W stage \n" > " .set pop \n"); > - raw_local_irq_enable(); > } > > /* > @@ -103,6 +101,8 @@ static void __cpuidle au1k_wait(void) > " nop \n" > " .set pop \n" > : : "r" (au1k_wait), "r" (c0status)); > + > + raw_local_irq_disable(); > } > > static int __initdata nowait; > @@ -245,8 +245,6 @@ void arch_cpu_idle(void) > { > if (cpu_wait) > cpu_wait(); > - else > - raw_local_irq_enable(); > } > > #ifdef CONFIG_CPU_IDLE > --- a/arch/nios2/kernel/process.c > +++ b/arch/nios2/kernel/process.c > @@ -33,7 +33,6 @@ EXPORT_SYMBOL(pm_power_off); > > void arch_cpu_idle(void) > { > - raw_local_irq_enable(); > } > > /* > --- a/arch/openrisc/kernel/process.c > +++ b/arch/openrisc/kernel/process.c > @@ -102,6 +102,7 @@ void arch_cpu_idle(void) > raw_local_irq_enable(); > if (mfspr(SPR_UPR) & SPR_UPR_PMP) > mtspr(SPR_PMR, mfspr(SPR_PMR) | SPR_PMR_DME); > + raw_local_irq_disable(); > } > > void (*pm_power_off)(void) = NULL; > --- a/arch/parisc/kernel/process.c > +++ b/arch/parisc/kernel/process.c > @@ -187,8 +187,6 @@ void arch_cpu_idle_dead(void) > > void __cpuidle arch_cpu_idle(void) > { > - raw_local_irq_enable(); > - > /* nop on real hardware, qemu will idle sleep. */ > asm volatile("or %%r10,%%r10,%%r10\n":::); > } > --- a/arch/powerpc/kernel/idle.c > +++ b/arch/powerpc/kernel/idle.c > @@ -51,10 +51,9 @@ void arch_cpu_idle(void) > * Some power_save functions return with > * interrupts enabled, some don't. > */ > - if (irqs_disabled()) > - raw_local_irq_enable(); > + if (!irqs_disabled()) > + raw_local_irq_disable(); > } else { > - raw_local_irq_enable(); > /* > * Go into low thread priority and possibly > * low power mode. > --- a/arch/riscv/kernel/process.c > +++ b/arch/riscv/kernel/process.c > @@ -39,7 +39,6 @@ extern asmlinkage void ret_from_kernel_t > void arch_cpu_idle(void) > { > cpu_do_idle(); > - raw_local_irq_enable(); > } > > void __show_regs(struct pt_regs *regs) > --- a/arch/s390/kernel/idle.c > +++ b/arch/s390/kernel/idle.c > @@ -66,7 +66,6 @@ void arch_cpu_idle(void) > idle->idle_count++; > account_idle_time(cputime_to_nsecs(idle_time)); > raw_write_seqcount_end(&idle->seqcount); > - raw_local_irq_enable(); > } > > static ssize_t show_idle_count(struct device *dev, > --- a/arch/sh/kernel/idle.c > +++ b/arch/sh/kernel/idle.c > @@ -25,6 +25,7 @@ void default_idle(void) > raw_local_irq_enable(); > /* Isn't this racy ? */ > cpu_sleep(); > + raw_local_irq_disable(); > clear_bl_bit(); > } > > --- a/arch/sparc/kernel/leon_pmc.c > +++ b/arch/sparc/kernel/leon_pmc.c > @@ -57,6 +57,8 @@ static void pmc_leon_idle_fixup(void) > "lda [%0] %1, %%g0\n" > : > : "r"(address), "i"(ASI_LEON_BYPASS)); > + > + raw_local_irq_disable(); > } > > /* > @@ -70,6 +72,8 @@ static void pmc_leon_idle(void) > > /* For systems without power-down, this will be no-op */ > __asm__ __volatile__ ("wr %g0, %asr19\n\t"); > + > + raw_local_irq_disable(); > } > > /* Install LEON Power Down function */ > --- a/arch/sparc/kernel/process_32.c > +++ b/arch/sparc/kernel/process_32.c > @@ -71,7 +71,6 @@ void arch_cpu_idle(void) > { > if (sparc_idle) > (*sparc_idle)(); > - raw_local_irq_enable(); > } > > /* XXX cli/sti -> local_irq_xxx here, check this works once SMP is fixed. */ > --- a/arch/sparc/kernel/process_64.c > +++ b/arch/sparc/kernel/process_64.c > @@ -59,7 +59,6 @@ void arch_cpu_idle(void) > { > if (tlb_type != hypervisor) { > touch_nmi_watchdog(); > - raw_local_irq_enable(); > } else { > unsigned long pstate; > > @@ -90,6 +89,8 @@ void arch_cpu_idle(void) > "wrpr %0, %%g0, %%pstate" > : "=&r" (pstate) > : "i" (PSTATE_IE)); > + > + raw_local_irq_disable(); > } > } > > --- a/arch/um/kernel/process.c > +++ b/arch/um/kernel/process.c > @@ -216,7 +216,6 @@ void arch_cpu_idle(void) > { > cpu_tasks[current_thread_info()->cpu].pid = os_getpid(); > um_idle_sleep(); > - raw_local_irq_enable(); > } > > int __cant_sleep(void) { > --- a/arch/x86/coco/tdx/tdx.c > +++ b/arch/x86/coco/tdx/tdx.c > @@ -178,6 +178,9 @@ void __cpuidle tdx_safe_halt(void) > */ > if (__halt(irq_disabled, do_sti)) > WARN_ONCE(1, "HLT instruction emulation failed\n"); > + > + /* XXX I can't make sense of what @do_sti actually does */ > + raw_local_irq_disable(); > } > > static bool read_msr(struct pt_regs *regs) > --- a/arch/x86/kernel/process.c > +++ b/arch/x86/kernel/process.c > @@ -699,6 +699,7 @@ EXPORT_SYMBOL(boot_option_idle_override) > void __cpuidle default_idle(void) > { > raw_safe_halt(); > + raw_local_irq_disable(); > } > #if defined(CONFIG_APM_MODULE) || defined(CONFIG_HALTPOLL_CPUIDLE_MODULE) > EXPORT_SYMBOL(default_idle); > @@ -804,13 +805,7 @@ static void amd_e400_idle(void) > > default_idle(); > > - /* > - * The switch back from broadcast mode needs to be called with > - * interrupts disabled. > - */ > - raw_local_irq_disable(); > tick_broadcast_exit(); > - raw_local_irq_enable(); > } > > /* > @@ -849,12 +844,10 @@ static __cpuidle void mwait_idle(void) > } > > __monitor((void *)¤t_thread_info()->flags, 0, 0); > - if (!need_resched()) > + if (!need_resched()) { > __sti_mwait(0, 0); > - else > - raw_local_irq_enable(); > - } else { > - raw_local_irq_enable(); > + raw_local_irq_disable(); > + } > } > __current_clr_polling(); > } > --- a/arch/xtensa/kernel/process.c > +++ b/arch/xtensa/kernel/process.c > @@ -183,6 +183,7 @@ void coprocessor_flush_release_all(struc > void arch_cpu_idle(void) > { > platform_idle(); > + raw_local_irq_disable(); > } > > /* > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -79,7 +79,6 @@ void __weak arch_cpu_idle_dead(void) { } > void __weak arch_cpu_idle(void) > { > cpu_idle_force_poll = 1; > - raw_local_irq_enable(); > } > > /** > @@ -96,7 +95,6 @@ void __cpuidle default_idle_call(void) > > cpuidle_rcu_enter(); > arch_cpu_idle(); > - raw_local_irq_disable(); > cpuidle_rcu_exit(); > > start_critical_timings(); > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 14:12:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 14:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362295.592276 (Exim 4.92) (envelope-from ) id 1o95l4-0004cH-Ro; Wed, 06 Jul 2022 14:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362295.592276; Wed, 06 Jul 2022 14:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95l4-0004cA-Md; Wed, 06 Jul 2022 14:12:02 +0000 Received: by outflank-mailman (input) for mailman id 362295; Wed, 06 Jul 2022 14:04:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o95eB-0003IU-7T for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 14:04:55 +0000 Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9bf35241-fd34-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 16:04:54 +0200 (CEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-31bf3656517so140694127b3.12 for ; Wed, 06 Jul 2022 07:04:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bf35241-fd34-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UBE539EKjjJ8zkn99yLgr6sf0hQeHTgO/l2k1f9VAKg=; b=CI3FpnTrwAoYWjrBJ3csJxAMAd1O2iKqsJR0ZcBe2CAVlPCiu7Hh0++cIJlceq0bxh p7EvCCSPvYwbAQ042vjl+IeYC2oo0s+b77CVd+f4Z31ylKMHk88/llVsoR9qQhyVV6x+ t6HEBNuJhSCRO7yvYWwNJV3rY3JahCRCSnT3IkmgHGMW/sI93KFYZzU01DkmG4u7RJwl NvPP0Kl6ZQL0ZfkU/Oje951wN50mRWj0Cr+LrQmyEC9/T5/4ZhQGIJAh26Lp+7enav8X fKn3gdDEk5oEAqnRsTPQ2du0zPOQA/wWD9slTu15UUM6OsX9Bpv9yzLA9x/Lk3vtHUC5 /K0g== X-Gm-Message-State: AJIora8vFlnX7TP2CsZuvFQX5RK/iXL3UTeEk9VdXRexd4mdmWVyj356 Ufw1tlhwTzIvzkSbxt5pYN4KpC95Sv0b8+Fq63M= X-Google-Smtp-Source: AGRyM1tzweDvK/HpOTrEcMtuYgu75xJlbU4wLmWYqVeEsIhNId5gL4a/NC1jAK4t+CVNf/Oa7/ufr1ZdqBFMCfc4FVA= X-Received: by 2002:a81:24c7:0:b0:314:1e60:a885 with SMTP id k190-20020a8124c7000000b003141e60a885mr46512506ywk.301.1657116293184; Wed, 06 Jul 2022 07:04:53 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144517.885263942@infradead.org> In-Reply-To: <20220608144517.885263942@infradead.org> From: "Rafael J. Wysocki" Date: Wed, 6 Jul 2022 16:04:42 +0200 Message-ID: Subject: Re: [PATCH 31/36] cpuidle,acpi: Make noinstr clean To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , jcmvbkbc@gmail.com, "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , "Paul E. McKenney" , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Wed, Jun 8, 2022 at 4:47 PM Peter Zijlstra wrote: > > vmlinux.o: warning: objtool: io_idle+0xc: call to __inb.isra.0() leaves .noinstr.text section > vmlinux.o: warning: objtool: acpi_idle_enter+0xfe: call to num_online_cpus() leaves .noinstr.text section > vmlinux.o: warning: objtool: acpi_idle_enter+0x115: call to acpi_idle_fallback_to_c1.isra.0() leaves .noinstr.text section > > Signed-off-by: Peter Zijlstra (Intel) Acked-by: Rafael J. Wysocki > --- > arch/x86/include/asm/shared/io.h | 4 ++-- > drivers/acpi/processor_idle.c | 2 +- > include/linux/cpumask.h | 4 ++-- > 3 files changed, 5 insertions(+), 5 deletions(-) > > --- a/arch/x86/include/asm/shared/io.h > +++ b/arch/x86/include/asm/shared/io.h > @@ -5,13 +5,13 @@ > #include > > #define BUILDIO(bwl, bw, type) \ > -static inline void __out##bwl(type value, u16 port) \ > +static __always_inline void __out##bwl(type value, u16 port) \ > { \ > asm volatile("out" #bwl " %" #bw "0, %w1" \ > : : "a"(value), "Nd"(port)); \ > } \ > \ > -static inline type __in##bwl(u16 port) \ > +static __always_inline type __in##bwl(u16 port) \ > { \ > type value; \ > asm volatile("in" #bwl " %w1, %" #bw "0" \ > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -593,7 +593,7 @@ static int acpi_idle_play_dead(struct cp > return 0; > } > > -static bool acpi_idle_fallback_to_c1(struct acpi_processor *pr) > +static __always_inline bool acpi_idle_fallback_to_c1(struct acpi_processor *pr) > { > return IS_ENABLED(CONFIG_HOTPLUG_CPU) && !pr->flags.has_cst && > !(acpi_gbl_FADT.flags & ACPI_FADT_C2_MP_SUPPORTED); > --- a/include/linux/cpumask.h > +++ b/include/linux/cpumask.h > @@ -908,9 +908,9 @@ static inline const struct cpumask *get_ > * concurrent CPU hotplug operations unless invoked from a cpuhp_lock held > * region. > */ > -static inline unsigned int num_online_cpus(void) > +static __always_inline unsigned int num_online_cpus(void) > { > - return atomic_read(&__num_online_cpus); > + return arch_atomic_read(&__num_online_cpus); > } > #define num_possible_cpus() cpumask_weight(cpu_possible_mask) > #define num_present_cpus() cpumask_weight(cpu_present_mask) > > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 14:53:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 14:53:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362309.592293 (Exim 4.92) (envelope-from ) id 1o96Op-0001di-6S; Wed, 06 Jul 2022 14:53:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362309.592293; Wed, 06 Jul 2022 14:53:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96Op-0001db-3B; Wed, 06 Jul 2022 14:53:07 +0000 Received: by outflank-mailman (input) for mailman id 362309; Wed, 06 Jul 2022 14:53:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96On-0001dR-T9; Wed, 06 Jul 2022 14:53:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96On-0003Dy-QT; Wed, 06 Jul 2022 14:53:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96On-0004au-HC; Wed, 06 Jul 2022 14:53:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o96On-0001KY-Gm; Wed, 06 Jul 2022 14:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LRS+cfNF0Dgpdt0k/m195AjeU+BjeaOwwo0A3RiPrMY=; b=x8tG75N5z5Ht5xlGJcDg36r4jk IY1ZBLj3dwcsuzh2t8YFcHgFdDCAmydfq9gLG+O/i0kec6Mn7uFpnQXkpePi/WZOkHb0dtf8vpAOl lZyI4t5EPpCO2GBGH8xDPJ6YmJURRapqBxITGrcXip7uEb12p+RXF5RyftJq9Ur/1lXA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171529: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:test-arm64-arm64-xl-xsm:xen-boot:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=61ff2733221e3b5bae5f647d9a460c7a68a5ace8 X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Wed, 06 Jul 2022 14:53:05 +0000 flight 171529 xen-unstable-smoke real [real] flight 171533 xen-unstable-smoke real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171529/ http://logs.test-lab.xenproject.org/osstest/logs/171533/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171486 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 2 days Failing since 171501 2022-07-05 12:03:08 Z 1 days 5 attempts Testing same since 171506 2022-07-05 17:00:29 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:18:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:18:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362317.592304 (Exim 4.92) (envelope-from ) id 1o96mr-0004i6-AN; Wed, 06 Jul 2022 15:17:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362317.592304; Wed, 06 Jul 2022 15:17:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96mr-0004hz-6B; Wed, 06 Jul 2022 15:17:57 +0000 Received: by outflank-mailman (input) for mailman id 362317; Wed, 06 Jul 2022 15:17:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o96mq-0004ht-3E for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:17:56 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cdec6f4c-fd3e-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 17:17:54 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdec6f4c-fd3e-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657120674; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=h8ds19eScE8j3L+YzqslAKx1TfX5HX9CLCVB/Da1hOY=; b=MHQMvOucpvNPns3N0/grzOpfJzFXHlSGzNlHN7j63QNciCkEU3tmboap IskdRoQW0w3UtFZCT5YGvbO3mwUgErPFEEVAOaKQLVaOg3TSVwIXXzo0E 5lR0+svOwNwdl1yRPHmwLOBqGAfJrVV1IV3i06TozvGCnlHDU+rnwV/95 Q=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75228734 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:aoZqA6ua8+bNB2hQLLUxVWqbPOfnVC5eMUV32f8akzHdYApBsoF/q tZmKWnTa/eMZWH1f9wjbIrg/EJS7Z7RydJmT1Y9rXoxHi4b+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zV5 4uoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi80MJWXur0TVyMATQFYZqRgp6fLcVyW5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUyNk6QPEYTUrsRIIgcvsqh1l+8SB13mWm8pIhp0WXp0AMkhdABN/KKI4fXFK25hH2wv Xna9m70BhUbMt23yjef9H+owOjVkkvTR4Y6BLC+sPlwjzW7xHEXCRAQfUu2p7++kEHWc9BVJ lEQ+yEuhbMv70HtRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhS68AXM3dGEGX3dabS1e6v+8uI1jqjuaG76PD5WJYs3J9SDYm m7X83Fm3+VO16bnxI3gowmZ3mvESozhC1dsu16JBj/NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N702wcH82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYib1NfMpOdjqUpp6pUQFKTgCfqmNBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ MbznTeEBncGE6V3pAeLqxMm+eZznEgWnDqLLbiilkjP+efPPxa9FOZaWGZim8hktctoVi2Oq 4YBXyZLoj0CONDDjt7/rddMcwtbcCNkVPgbaaV/L4a+H+avI0l5Y9e5/F/rU9YNc3h9/gsQw kyAZw== IronPort-HdrOrdr: A9a23:jWhyJq5YyJfCPGOhWQPXwMjXdLJyesId70hD6qhwISY6TiW9rb HLoB17726QtN9/YhwdcLy7VJVoBEmskqKdgrNhX4tKPjOHhILAFugLhuHfKn/bak7DH4ZmpM FdmsNFaeEYY2IUsfrH X-IronPort-AV: E=Sophos;i="5.92,250,1650945600"; d="scan'208";a="75228734" Date: Wed, 6 Jul 2022 16:17:48 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Message-ID: References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> On Thu, Jun 09, 2022 at 05:52:45PM +0200, Jan Beulich wrote: > With debug info retained, xen.efi can be quite large. Unlike for xen.gz > there's no intermediate step (mkelf32 there) involved which would strip > debug info kind of as a side effect. While the installing of xen.efi on > the EFI partition is an optional step (intended to be a courtesy to the > developer), adjust it also for the purpose of documenting what distros > would be expected to do during boot loader configuration (which is what > would normally put xen.efi into the EFI partition). > > Model the control over stripping after Linux'es module installation, > except that the stripped executable is constructed in the build area > instead of in the destination location. This is to conserve on space > used there - EFI partitions tend to be only a few hundred Mb in size. > > Signed-off-by: Jan Beulich > --- > GNU strip 2.38 appears to have issues when acting on a PE binary: > - file name symbols are also stripped; while there is a separate > --keep-file-symbols option (which I would have thought to be on by > default anyway), its use so far makes no difference, > - the string table grows in size, when one would expect it to retain its > size (or shrink), > - linker version is changed in and timestamp zapped from the header. > Older GNU strip (observed with 2.35.1) doesn't work at all ("Data > Directory size (1c) exceeds space left in section (8)"). > > Future GNU strip is going to honor --keep-file-symbols (and will also > have the other issues fixed). Question is whether we should use that > option (for the symbol table as a whole to make sense), or whether > instead we should (by default) strip the symbol table as well. I guess trying to keep those symbol might be useful, if it's not too big, to help debugging system in production. > --- a/xen/Makefile > +++ b/xen/Makefile > @@ -465,6 +465,22 @@ endif > .PHONY: _build > _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) > > +# Strip > +# > +# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped before it > +# is installed. If INSTALL_EFI_STRIP is '1', then the default option > +# --strip-debug will be used. Otherwise, INSTALL_EFI_STRIP value will be used > +# as the option(s) to the strip command. It would be useful to also document INSTALL_EFI_STRIP in ./INSTALL or in ./docs/misc/efi.pandoc (efi.pandoc is where EFI_VENDOR is documented for example, so probably a better place for the doc of the new option). > +ifdef INSTALL_EFI_STRIP > + > +ifeq ($(INSTALL_EFI_STRIP),1) > +efi-strip-opt := --strip-debug > +else > +efi-strip-opt := $(INSTALL_EFI_STRIP) > +endif > + > +endif > + > .PHONY: _install > _install: D=$(DESTDIR) > _install: T=$(notdir $(TARGET)) > @@ -489,6 +505,9 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_ > ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi; \ > ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T).efi; \ > if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \ > + $(if $(efi-strip-opt), \ > + $(STRIP) $(efi-strip-opt) -p -o $(TARGET).efi.stripped $(TARGET).efi && \ > + $(INSTALL_DATA) $(TARGET).efi.stripped $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi ||) \ This optional part of the script that ends with "||" means that if `strip` or `install` fails, we would install the non stripped binary. Is this something that's acceptable? (Plus of doing that is avoiding changing the next line, and avoiding a longer $(if ,). > $(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \ > elif [ "$(D)" = "$(patsubst $(shell cd $(XEN_ROOT) && pwd)/%,%,$(D))" ]; then \ > echo 'EFI installation only partially done (EFI_VENDOR not set)' >&2; \ An other thing, the "*.efi.stripped" file is I think going to be left over and not removed during `make clean`. Cheers, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362323.592315 (Exim 4.92) (envelope-from ) id 1o970b-0007cK-IX; Wed, 06 Jul 2022 15:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362323.592315; Wed, 06 Jul 2022 15:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o970b-0007cD-Fa; Wed, 06 Jul 2022 15:32:09 +0000 Received: by outflank-mailman (input) for mailman id 362323; Wed, 06 Jul 2022 15:32:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o970Z-0007c3-WF; Wed, 06 Jul 2022 15:32:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o970Z-0003uE-SW; Wed, 06 Jul 2022 15:32:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o970Z-0005WC-Iw; Wed, 06 Jul 2022 15:32:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o970Z-0005Ux-IS; Wed, 06 Jul 2022 15:32:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=j6rltrRj/RPAg7Cp7lMqZhG0YBIS/UGLa9KNYmQZQHs=; b=gTeVMG7SIBmkM1Geo7bcoGd8Zx X6MdUkQeQi2+cvIHHnB8xFgw3Tulfj/DDM26GVwFZd2wC1nmCPcOk/yTGXB4tS7wgMmYULen8CJA6 4vzu9k+EtBtTTNmHnvzCvcRGCx8cpBgmcAc37d3jky0th/M0mfRU3k/CugrEfPZvzOCg=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable-smoke bisection] complete test-arm64-arm64-xl-xsm Message-Id: From: osstest service owner Date: Wed, 06 Jul 2022 15:32:07 +0000 branch xen-unstable-smoke xenbranch xen-unstable-smoke job test-arm64-arm64-xl-xsm testid xen-boot Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Bug not present: 4df2e99d731402da48afb19dc970ccab5a0814d6 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171534/ commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/test-arm64-arm64-xl-xsm.xen-boot.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/test-arm64-arm64-xl-xsm.xen-boot --summary-out=tmp/171534.bisection-summary --basis-template=171486 --blessings=real,real-bisect,real-retry xen-unstable-smoke test-arm64-arm64-xl-xsm xen-boot Searching for failure / basis pass: 171529 fail [host=laxton1] / 171486 ok. Failure / basis pass flights: 171529 / 171486 Tree: linux git://xenbits.xen.org/linux-pvops.git Tree: linuxfirmware git://xenbits.xen.org/osstest/linux-firmware.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Basis pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/linux-pvops.git#f0f0e602f7c9781699ecda9be763eac0b03d54f0-f0f0e602f7c9781699ecda9be763eac0b03d54f0 git://xenbits.xen.org/osstest/linux-firmware.git#c530a75c1e6a472b0eb9558310b518f0dfcd8860-c530a75c1e6a472b0eb9558310b518f0dfcd8860 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedfaa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#4df2e99d731402da48afb19dc970ccab5a0814d6-61ff273\ 3221e3b5bae5f647d9a460c7a68a5ace8 Loaded 5001 nodes in revision graph Searching for test results: 171486 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 171501 [host=rochester0] 171505 [host=rochester0] 171506 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 171507 [host=rochester0] 171510 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 171513 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 171511 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 171515 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 c4184bf305dc14c3e150617904c40b120664efe6 171518 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 171521 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 171522 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 171519 [host=rochester1] 171524 pass f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 171527 [host=rochester1] 171530 [host=rochester1] 171531 [host=rochester1] 171529 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 171532 [host=rochester1] 171534 fail f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Searching for interesting versions Result found: flight 171486 (pass), for basis pass For basis failure, parent search stopping at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6, results HASH(0x558b35d49170) HASH(0x558b35d531c0) HASH(0x558b35d5c8b0) HASH(0x558b35d605c0) Result found: flight 171506 (fail), for basis failure (at ancestor ~260) Repro found: flight 171510 (pass), for basis pass Repro found: flight 171511 (fail), for basis failure 0 revisions at f0f0e602f7c9781699ecda9be763eac0b03d54f0 c530a75c1e6a472b0eb9558310b518f0dfcd8860 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 4df2e99d731402da48afb19dc970ccab5a0814d6 No revisions left to test, checking graph state. Result found: flight 171486 (pass), for last pass Result found: flight 171518 (fail), for first failure Repro found: flight 171521 (pass), for last pass Repro found: flight 171522 (fail), for first failure Repro found: flight 171524 (pass), for last pass Repro found: flight 171534 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Bug not present: 4df2e99d731402da48afb19dc970ccab5a0814d6 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171534/ commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/test-arm64-arm64-xl-xsm.xen-boot.{dot,ps,png,html,svg}. ---------------------------------------- 171534: tolerable ALL FAIL flight 171534 xen-unstable-smoke real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/171534/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: test-arm64-arm64-xl-xsm 8 xen-boot fail baseline untested jobs: test-arm64-arm64-xl-xsm fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362331.592326 (Exim 4.92) (envelope-from ) id 1o971L-0008D5-1C; Wed, 06 Jul 2022 15:32:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362331.592326; Wed, 06 Jul 2022 15:32:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971K-0008Cy-Tu; Wed, 06 Jul 2022 15:32:54 +0000 Received: by outflank-mailman (input) for mailman id 362331; Wed, 06 Jul 2022 15:32:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971I-00081g-Ll for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:53 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e4461717-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:32:50 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C2C9E5C0190; Wed, 6 Jul 2022 11:32:48 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Jul 2022 11:32:48 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:45 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4461717-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657121568; x=1657207968; bh=gXRVGiGc2esI8GnrDirdRc23m3W8gp6wUHz KCWUNLqg=; b=IUlZYj8f0MHmJYK8S606DeGQBwEbRHFDc+0GOatQc4r524hejGb E7GYO817FMbN34gSfJJTWn3beFHJHB809X6YLSZ+ZGkw/qnFrOV7/wmhaYYUhz9+ yt/pR9HtNFcIwMHzUjLY89M5AsiQ4pU+3YhZZ5c6a6GpLkW3oKK3UnCvMJiQBhY+ BcrDFW8ULr7vlynArX2M+w78NydirWGz8MdRfSoT2qutGp/HJL5eN43V2YSW3KFg QShHpNdem/iCyHYUoif9KrHD2EDgFVa4XX8FJud8C7NXp+FjTnnUYaZgISJp00XF gUiDe8e5lpjdhNwO8AOt0/OKaf7lsBLhs6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657121568; x=1657207968; bh=gXRVGiGc2esI8 GnrDirdRc23m3W8gp6wUHzKCWUNLqg=; b=3UFyDPQfzYosTaxseH7KuVuye5BVT vM1mhcshooWsV5bQ76uLp1wlU+/e95N062VrkT6uj5Md3ncP7tE07EhhCiQpxj29 hUj1ycj5WDvXT01h76BYn8Sl9W8E8BMBM64794risP5vjU+VM9H9DQb3/w78BmvL ZfG7qEkK7WJr3Leul7LNKexXcE40Yo139WDLSvMq8k1IOtiNG5ITtKqepiJ55WwK LvE78DyjedcPWbciS6mmtIdyOiHj+dK1/hm8t2/6eEpJfjE9tBAjyKksWRTE+uAt t5LEkZA0UPou8eoLmOzDDYEOTU/bjU2bpe3MOlx/GJm4RmlLhL/s3nacw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefgffg geevhffggfetfefhffeuvefhvdevkeehkedttddtgeefkeduheevffduleenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Kevin Tian , Connor Davis Subject: [PATCH v2 0/9] Add Xue - console over USB 3 Debug Capability Date: Wed, 6 Jul 2022 17:32:05 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports output-only console via USB3 debug capability. The capability is designed to operate mostly independently of normal XHCI driver, so this patch series allows dom0 to drive standard USB3 controller part, while Xen uses DbC for console output. Changes since RFC: - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction - adjust for Xen code style - build for x86 only - drop patch hidding the device from dom0 Changes since v1: - drop ehci patch - already applied - adjust for review comments from Jan (see changelogs in individual patches) Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Paul Durrant Cc: Kevin Tian Cc: Connor Davis Connor Davis (1): drivers/char: Add support for Xue USB3 debugger Marek Marczykowski-Górecki (8): xue: reset XHCI ports when initializing dbc xue: add support for selecting specific xhci console: support multiple serial console simultaneously IOMMU: add common API for device reserved memory IOMMU/VT-d: wire common device reserved memory API IOMMU/AMD: wire common device reserved memory API xue: mark DMA buffers as reserved for the device xue: allow driving the rest of XHCI by a domain while Xen uses DbC docs/misc/xen-command-line.pandoc | 5 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 3 +- xen/drivers/char/Kconfig | 9 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/console.c | 58 +- xen/drivers/char/xue.c | 1066 +++++++++++++++++++++++- xen/drivers/passthrough/amd/iommu_acpi.c | 16 +- xen/drivers/passthrough/iommu.c | 40 +- xen/drivers/passthrough/vtd/dmar.c | 203 ++-- xen/include/xen/iommu.h | 11 +- xen/include/xen/serial.h | 3 +- 12 files changed, 1323 insertions(+), 96 deletions(-) create mode 100644 xen/drivers/char/xue.c base-commit: 0544c4ee4b48f7e2715e69ff3e73c3d5545b0526 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362332.592332 (Exim 4.92) (envelope-from ) id 1o971L-0008Ga-Cr; Wed, 06 Jul 2022 15:32:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362332.592332; Wed, 06 Jul 2022 15:32:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971L-0008Fs-6d; Wed, 06 Jul 2022 15:32:55 +0000 Received: by outflank-mailman (input) for mailman id 362332; Wed, 06 Jul 2022 15:32:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971K-00081g-C6 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:54 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e691d91a-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:32:53 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C8A475C0170; Wed, 6 Jul 2022 11:32:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Jul 2022 11:32:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e691d91a-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121572; x=1657207972; bh=jTLjQ6SoY6 EYcoZ1VpBnLuSOpWBuAhAOnELQ3/iEcEM=; b=rzkhxG0SYBz5Iq251QGwCouSeM 5edrhyGAkhKHvqd/7077KeEWW63IwCBJN6NTr0TzZFTulwz0WcRC9Tw69fRTLzbF RF2tqZwWCQag3Hy3cqEabg7YQVPusLmdfURc7XJlOmIR719CzujlOZ8/qbSkjp+a FiUAhkBPhQHLpWI67ocViubCnQUpEqwOh69gvRG61iulyFjW3fc+2Uv0eX5S3MKj Qefgt/ugsX7apAMAuoMCMnxZSFHbzy0/Libh09sp5ecESrHBZVwu1ybCFjavampx FHfHtYP1YAamIl/Nl3CP71mZ64XAOq+hXgiKC8udXpeLEuzUgLPhS0YOaMZg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121572; x= 1657207972; bh=jTLjQ6SoY6EYcoZ1VpBnLuSOpWBuAhAOnELQ3/iEcEM=; b=X xl81hj67XgQ9b1T5I5QoRxyYqxrrcLlcCuS/mZkZzCv3ZBtm4Miu2qkdFEA3tMcj qri7Xt/w4h47qUH+ctBJPVA9QBt8jY6sGuNs2xYfA0KZNg2qD2yI1b2NyFxNypBY hUmgP/T9SNWC9+xVVAdlCNbKGOsMYCm4TZRAnApqO6oo7Drw5xQwWLyaoxcp2BD2 QXMoW4UJjozlwrZ4zRMkuGCfzgcd3m1T9QjvzLW4yaTHObq1NBmjiVayWur1OFBz UzDfM8di4F3fqHS66Rru7MqucnMq6RYPFk2tFDaLvTdRpUaesW+ohd6gsNz2J2Q1 yIBb/bwFpKB9Ih/rwj+jg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/9] xue: reset XHCI ports when initializing dbc Date: Wed, 6 Jul 2022 17:32:07 +0200 Message-Id: <4874087c2304034e0d917d649f7cb9d46c149ed6.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reset ports, to force host system to re-enumerate devices. Otheriwse it will require the cable to be re-plugged, or will wait in the "configuring" state indefinitely. Trick and code copied from Linux: drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - use uint32_t instead of u32 - code style --- xen/drivers/char/xue.c | 70 +++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 70 insertions(+) diff --git a/xen/drivers/char/xue.c b/xen/drivers/char/xue.c index 234b07b563bb..2cbbaea11fa0 100644 --- a/xen/drivers/char/xue.c +++ b/xen/drivers/char/xue.c @@ -63,6 +63,10 @@ ((1UL << XUE_PSC_CSC) | (1UL << XUE_PSC_PRC) | (1UL << XUE_PSC_PLC) | \ (1UL << XUE_PSC_CEC)) +#define XUE_XHC_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff) +#define PORT_RESET (1 << 4) +#define PORT_CONNECT (1 << 0) + #define xue_debug(...) printk("xue debug: " __VA_ARGS__) #define xue_alert(...) printk("xue alert: " __VA_ARGS__) #define xue_error(...) printk("xue error: " __VA_ARGS__) @@ -590,6 +594,68 @@ static void xue_init_strings(struct xue *xue, uint32_t *info) info[8] = (4 << 24) | (30 << 16) | (8 << 8) | 6; } +static void xue_do_reset_debug_port(struct xue *xue, + unsigned int id, unsigned int count) +{ + uint32_t *ops_reg; + uint32_t *portsc; + uint32_t val, cap_length; + int i; + + cap_length = (*(uint32_t*)xue->xhc_mmio) & 0xff; + ops_reg = xue->xhc_mmio + cap_length; + + id--; + for ( i = id; i < (id + count); i++ ) + { + portsc = ops_reg + 0x100 + i * 0x4; + val = *portsc; + if ( !(val & PORT_CONNECT) ) + *portsc = val | PORT_RESET; + } +} + +static void xue_reset_debug_port(struct xue *xue) +{ + uint32_t val, port_offset, port_count; + uint32_t *xcap; + uint32_t next; + uint32_t id; + uint8_t *mmio = (uint8_t *)xue->xhc_mmio; + uint32_t *hccp1 = (uint32_t *)(mmio + 0x10); + const uint32_t PROTOCOL_ID = 0x2; + + /** + * Paranoid check against a zero value. The spec mandates that + * at least one "supported protocol" capability must be implemented, + * so this should always be false. + */ + if ( (*hccp1 & 0xFFFF0000) == 0 ) + return; + + xcap = (uint32_t *)(mmio + (((*hccp1 & 0xFFFF0000) >> 16) << 2)); + next = (*xcap & 0xFF00) >> 8; + id = *xcap & 0xFF; + + /* Look for "supported protocol" capability, major revision 3 */ + for ( ; next; xcap += next, id = *xcap & 0xFF, next = (*xcap & 0xFF00) >> 8) + { + if ( id != PROTOCOL_ID && next ) + continue; + + if ( XUE_XHC_EXT_PORT_MAJOR(*xcap) != 0x3 ) + continue; + + /* extract ports offset and count from the capability structure */ + val = *(xcap + 2); + port_offset = val & 0xff; + port_count = (val >> 8) & 0xff; + + /* and reset them all */ + xue_do_reset_debug_port(xue, port_offset, port_count); + } +} + static void xue_enable_dbc(struct xue *xue) { struct xue_dbc_reg *reg = xue->dbc_reg; @@ -601,6 +667,10 @@ static void xue_enable_dbc(struct xue *xue) while ( (reg->ctrl & (1UL << XUE_CTRL_DCE)) == 0 ) xue_sys_pause(); + /* reset ports on initial open, to force re-enumerating by the host */ + if ( !xue->open ) + xue_reset_debug_port(xue); + wmb(); reg->portsc |= (1UL << XUE_PSC_PED); wmb(); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362333.592340 (Exim 4.92) (envelope-from ) id 1o971L-0008PX-QF; Wed, 06 Jul 2022 15:32:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362333.592340; Wed, 06 Jul 2022 15:32:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971L-0008Mx-HA; Wed, 06 Jul 2022 15:32:55 +0000 Received: by outflank-mailman (input) for mailman id 362333; Wed, 06 Jul 2022 15:32:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971K-000854-2u for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:54 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e59213c7-fd40-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 17:32:51 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 248725C013E; Wed, 6 Jul 2022 11:32:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 06 Jul 2022 11:32:51 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:48 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e59213c7-fd40-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121571; x=1657207971; bh=IqBP6+JuNA Q/j/nJw8bFO6UNMBb1h9U8UWwV+r/a7L0=; b=IYSErbR8EpB57V/wsoSocEUYhW PeSlyUIq06PqbwHNUEuToDWIGN4j1vpPo+stTHw6rG+3Yv8GLoEZ03e3FxY2eK6I RSN+kLBIdv6HqAkSvt1QsqO21VHr/UhpdhT6ZmH1/KF8AcH6jk+GxwkChfSvLzmx mX9ygoUEoP5GFVIth5PXkwf+HUNl+dnFfL8lKiYWCOx9K92uwHazA/b0cNAM3IFw pkZdbZPIxPuVS7nlfqsR3t+XdDQQhxRa10ia28WbNpADFeeBlXFycQc7b5ozTMVE acSHjK8ka6u7NHZDfyLsfcI0P/JZQ2gQSVW1FOrGXFTcg1g1NXX65ElOK63Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121571; x= 1657207971; bh=IqBP6+JuNAQ/j/nJw8bFO6UNMBb1h9U8UWwV+r/a7L0=; b=L aepcclHCuiVx+zt6CHogISTxGvqiaGYUJBrUPfXODFzj09cjYXmj/jvT6cOtSRua wXkM3UmO/wJLuqzdB8qoSzaDdmftaWH9aSEfVs99ufjYPbUHw9O3BuU1GO1+kree 17MeB6PklVahQk56DnH1rKLGvKtql904+qpGIbvY8dYEck5NrU35hCGF8w/WZgnx hFiK2yB2zGEnvCaR3RkYZVVIrLTBgQAI+Q6fzJRnCVVMHdxvWLERPcTqbz/k2kBo ztfR9n9/CfkitT0KhGIkuQKiMnWzctNGmlVTn6JLSeG+M4I60yHOf5zAYgIZ+gb2 A6t17KzbbwwKegS9k5Asw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeek udejueeuudetudffffdtheetteeileekkeefjeeljefhkeelffevueffkeelfeenucffoh hmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Date: Wed, 6 Jul 2022 17:32:06 +0200 Message-Id: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct uart_driver that uses xue as a backend. Note that only target -> host communication is supported for now. To use Xue as a console, add 'console=dbgp dbgp=xue' to the command line. [Marek] The Xue driver is taken from https://github.com/connojd/xue and heavily refactored to fit into Xen code base. Major changes include: - drop support for non-Xen systems - drop xue_ops abstraction - use Xen's native helper functions for PCI access - move all the code to xue.c, drop "inline" - build for x86 only - annotate functions with cf_check - adjust for Xen's code style At this stage, only the first xHCI is considered. Later patch adds support for choosing specific one. The driver is initiallized before memory allocator works, so all the transfer buffers (about 2MB of them) are allocated statically and will use memory even if XUE console is not selected. The driver can be disabled build time to reclaim this memory. Signed-off-by: Connor Davis Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - drop #pragma pack - fix indentation in Kconfig - minor style fixes - use cache_flush() - mark init functions as __init, and return bool - fix PCI_SBDF usage, use constants from pci_regs.h - add command line docs - allow disabling the driver in menuconfig, to reclaim 2MB allocated memory - guard unused debug functions with #ifdef XUE_DEBUG --- docs/misc/xen-command-line.pandoc | 5 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 3 +- xen/drivers/char/Kconfig | 9 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/xue.c | 933 +++++++++++++++++++++++++++++++- xen/include/xen/serial.h | 3 +- 7 files changed, 958 insertions(+) create mode 100644 xen/drivers/char/xue.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index a92b7d228cae..f9fa857bd84e 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` +> `= xue` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). +Use `ehci` for EHCI debug port, use `xue` for XHCI debug capability. +Xue driver will wait indefinitely for the debug host to connect - make sure the +cable is connected. + ### debug_stack_lines > `= ` diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/fixmap.h index 20746afd0a2a..bc39ffe896b1 100644 --- a/xen/arch/x86/include/asm/fixmap.h +++ b/xen/arch/x86/include/asm/fixmap.h @@ -25,6 +25,8 @@ #include #include +#define MAX_XHCI_PAGES 16 + /* * Here we define all the compile-time 'special' virtual * addresses. The point is to have a constant address at @@ -43,6 +45,8 @@ enum fixed_addresses { FIX_COM_BEGIN, FIX_COM_END, FIX_EHCI_DBGP, + FIX_XHCI_BEGIN, + FIX_XHCI_END = FIX_XHCI_BEGIN + MAX_XHCI_PAGES - 1, #ifdef CONFIG_XEN_GUEST FIX_PV_CONSOLE, FIX_XEN_SHARED_INFO, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 53a73010e029..58a0723a7501 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -946,6 +946,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) ns16550.irq = 3; ns16550_init(1, &ns16550); ehci_dbgp_init(); +#ifdef CONFIG_HAS_XHCI + xue_uart_init(); +#endif console_init_preirq(); if ( pvh_boot ) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index e5f7b1d8eb8a..d12b2205dafc 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -74,3 +74,12 @@ config HAS_EHCI help This selects the USB based EHCI debug port to be used as a UART. If you have an x86 based system with USB, say Y. + +config HAS_XHCI + bool "XHCI DbC UART driver" + depends on X86 + help + This selects the USB based XHCI debug capability to be used as a UART. + Enabling this option makes Xen use extra ~2MB memory, even if XHCI UART + (XUE) is not selected. + If you have an x86 based system with USB3, say Y. diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile index 14e67cf072d7..bda1e44d3f39 100644 --- a/xen/drivers/char/Makefile +++ b/xen/drivers/char/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o obj-$(CONFIG_HAS_OMAP) += omap-uart.o obj-$(CONFIG_HAS_SCIF) += scif-uart.o obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o +obj-$(CONFIG_HAS_XHCI) += xue.o obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o obj-$(CONFIG_ARM) += arm-uart.o obj-y += serial.o diff --git a/xen/drivers/char/xue.c b/xen/drivers/char/xue.c new file mode 100644 index 000000000000..234b07b563bb --- /dev/null +++ b/xen/drivers/char/xue.c @@ -0,0 +1,933 @@ +/* + * drivers/char/xue.c + * + * Xen port for the xue debugger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; If not, see . + * + * Copyright (c) 2019 Assured Information Security. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* uncomment to have xue_uart_dump() debug function */ +/* #define XUE_DEBUG 1 */ + +#define XUE_POLL_INTERVAL 100 /* us */ + +#define XUE_PAGE_SIZE 4096ULL + +/* Supported xHC PCI configurations */ +#define XUE_XHC_CLASSC 0xC0330U + +/* DbC idVendor and idProduct */ +#define XUE_DBC_VENDOR 0x1D6B +#define XUE_DBC_PRODUCT 0x0010 +#define XUE_DBC_PROTOCOL 0x0000 + +/* DCCTRL fields */ +#define XUE_CTRL_DCR 0 +#define XUE_CTRL_HOT 2 +#define XUE_CTRL_HIT 3 +#define XUE_CTRL_DRC 4 +#define XUE_CTRL_DCE 31 + +/* DCPORTSC fields */ +#define XUE_PSC_PED 1 +#define XUE_PSC_CSC 17 +#define XUE_PSC_PRC 21 +#define XUE_PSC_PLC 22 +#define XUE_PSC_CEC 23 + +#define XUE_PSC_ACK_MASK \ + ((1UL << XUE_PSC_CSC) | (1UL << XUE_PSC_PRC) | (1UL << XUE_PSC_PLC) | \ + (1UL << XUE_PSC_CEC)) + +#define xue_debug(...) printk("xue debug: " __VA_ARGS__) +#define xue_alert(...) printk("xue alert: " __VA_ARGS__) +#define xue_error(...) printk("xue error: " __VA_ARGS__) + +/****************************************************************************** + * TRB ring (summarized from the manual): + * + * TRB rings are circular queues of TRBs shared between the xHC and the driver. + * Each ring has one producer and one consumer. The DbC has one event + * ring and two transfer rings; one IN and one OUT. + * + * The DbC hardware is the producer on the event ring, and + * xue is the consumer. This means that event TRBs are read-only from + * the xue. + * + * OTOH, xue is the producer of transfer TRBs on the two transfer + * rings, so xue enqueues transfers, and the hardware dequeues + * them. The dequeue pointer of a transfer ring is read by + * xue by examining the latest transfer event TRB on the event ring. The + * transfer event TRB contains the address of the transfer TRB that generated + * the event. + * + * To make each transfer ring circular, the last TRB must be a link TRB, which + * points to the beginning of the next queue. Note that this implementation + * does not support multiple segments, so each link TRB points back to the + * beginning of its own segment. + ******************************************************************************/ + +/* TRB types */ +enum { + xue_trb_norm = 1, + xue_trb_link = 6, + xue_trb_tfre = 32, + xue_trb_psce = 34 +}; + +/* TRB completion codes */ +enum { xue_trb_cc_success = 1, xue_trb_cc_trb_err = 5 }; + +/* DbC endpoint types */ +enum { xue_ep_bulk_out = 2, xue_ep_bulk_in = 6 }; + +/* DMA/MMIO structures */ +struct xue_trb { + uint64_t params; + uint32_t status; + uint32_t ctrl; +}; + +struct xue_erst_segment { + uint64_t base; + uint16_t size; + uint8_t rsvdz[6]; +}; + +#define XUE_CTX_SIZE 16 +#define XUE_CTX_BYTES (XUE_CTX_SIZE * 4) + +struct xue_dbc_ctx { + uint32_t info[XUE_CTX_SIZE]; + uint32_t ep_out[XUE_CTX_SIZE]; + uint32_t ep_in[XUE_CTX_SIZE]; +}; + +struct xue_dbc_reg { + uint32_t id; + uint32_t db; + uint32_t erstsz; + uint32_t rsvdz; + uint64_t erstba; + uint64_t erdp; + uint32_t ctrl; + uint32_t st; + uint32_t portsc; + uint32_t rsvdp; + uint64_t cp; + uint32_t ddi1; + uint32_t ddi2; +}; + +#define XUE_TRB_MAX_TFR (XUE_PAGE_SIZE << 4) +#define XUE_TRB_PER_PAGE (XUE_PAGE_SIZE / sizeof(struct xue_trb)) + +/* Defines the size in bytes of TRB rings as 2^XUE_TRB_RING_ORDER * 4096 */ +#ifndef XUE_TRB_RING_ORDER +#define XUE_TRB_RING_ORDER 4 +#endif +#define XUE_TRB_RING_CAP (XUE_TRB_PER_PAGE * (1ULL << XUE_TRB_RING_ORDER)) +#define XUE_TRB_RING_BYTES (XUE_TRB_RING_CAP * sizeof(struct xue_trb)) +#define XUE_TRB_RING_MASK (XUE_TRB_RING_BYTES - 1U) + +struct xue_trb_ring { + struct xue_trb *trb; /* Array of TRBs */ + uint32_t enq; /* The offset of the enqueue ptr */ + uint32_t deq; /* The offset of the dequeue ptr */ + uint8_t cyc; /* Cycle state toggled on each wrap-around */ + uint8_t db; /* Doorbell target */ +}; + +#define XUE_DB_OUT 0x0 +#define XUE_DB_IN 0x1 +#define XUE_DB_INVAL 0xFF + +/* Defines the size in bytes of work rings as 2^XUE_WORK_RING_ORDER * 4096 */ +#ifndef XUE_WORK_RING_ORDER +#define XUE_WORK_RING_ORDER 3 +#endif +#define XUE_WORK_RING_CAP (XUE_PAGE_SIZE * (1ULL << XUE_WORK_RING_ORDER)) +#define XUE_WORK_RING_BYTES XUE_WORK_RING_CAP + +#if XUE_WORK_RING_CAP > XUE_TRB_MAX_TFR +#error "XUE_WORK_RING_ORDER must be at most 4" +#endif + +struct xue_work_ring { + uint8_t *buf; + uint32_t enq; + uint32_t deq; + uint64_t dma; +}; + +struct xue { + struct xue_dbc_reg *dbc_reg; + struct xue_dbc_ctx *dbc_ctx; + struct xue_erst_segment *dbc_erst; + struct xue_trb_ring dbc_ering; + struct xue_trb_ring dbc_oring; + struct xue_trb_ring dbc_iring; + struct xue_work_ring dbc_owork; + char *dbc_str; + + pci_sbdf_t sbdf; + uint64_t xhc_mmio_phys; + uint64_t xhc_mmio_size; + uint64_t xhc_dbc_offset; + void *xhc_mmio; + + int open; +}; + +static void xue_sys_pause(void) +{ + asm volatile("pause" ::: "memory"); +} + +static void *xue_sys_map_xhc(uint64_t phys, uint64_t size) +{ + size_t i; + + if ( size != MAX_XHCI_PAGES * XUE_PAGE_SIZE ) + return NULL; + + for ( i = FIX_XHCI_END; i >= FIX_XHCI_BEGIN; i-- ) + { + set_fixmap_nocache(i, phys); + phys += XUE_PAGE_SIZE; + } + + /* + * The fixmap grows downward, so the lowest virt is + * at the highest index + */ + return fix_to_virt(FIX_XHCI_END); +} + +static bool __init xue_init_xhc(struct xue *xue) +{ + uint32_t bar0; + uint64_t bar1; + uint64_t devfn; + + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so far + * are part of the chipset and are on bus 0. + */ + for ( devfn = 0; devfn < 256; devfn++ ) + { + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); + uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr == 0 || hdr == 0x80 ) + { + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) + { + xue->sbdf = sbdf; + break; + } + } + } + + if ( !xue->sbdf.sbdf ) + { + xue_error("Compatible xHC not found on bus 0\n"); + return false; + } + + /* ...we found it, so parse the BAR and map the registers */ + bar0 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0); + bar1 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_1); + + /* IO BARs not allowed; BAR must be 64-bit */ + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY || + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) != PCI_BASE_ADDRESS_MEM_TYPE_64 ) + return false; + + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); + xue->xhc_mmio_size = ~(pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0) & 0xFFFFFFF0) + 1; + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, bar0); + + xue->xhc_mmio_phys = (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 32); + xue->xhc_mmio = xue_sys_map_xhc(xue->xhc_mmio_phys, xue->xhc_mmio_size); + + return xue->xhc_mmio != NULL; +} + +/** + * The first register of the debug capability is found by traversing the + * host controller's capability list (xcap) until a capability + * with ID = 0xA is found. The xHCI capability list begins at address + * mmio + (HCCPARAMS1[31:16] << 2) + */ +static struct xue_dbc_reg *xue_find_dbc(struct xue *xue) +{ + uint32_t *xcap; + uint32_t next; + uint32_t id; + uint8_t *mmio = (uint8_t *)xue->xhc_mmio; + uint32_t *hccp1 = (uint32_t *)(mmio + 0x10); + const uint32_t DBC_ID = 0xA; + + /** + * Paranoid check against a zero value. The spec mandates that + * at least one "supported protocol" capability must be implemented, + * so this should always be false. + */ + if ( (*hccp1 & 0xFFFF0000) == 0 ) + return NULL; + + xcap = (uint32_t *)(mmio + (((*hccp1 & 0xFFFF0000) >> 16) << 2)); + next = (*xcap & 0xFF00) >> 8; + id = *xcap & 0xFF; + + /** + * Table 7-1 states that 'next' is relative to + * the current value of xcap and is a dword offset. + */ + while ( id != DBC_ID && next ) { + xcap += next; + id = *xcap & 0xFF; + next = (*xcap & 0xFF00) >> 8; + } + + if ( id != DBC_ID ) + return NULL; + + xue->xhc_dbc_offset = (uint64_t)xcap - (uint64_t)mmio; + return (struct xue_dbc_reg *)xcap; +} + +/** + * Fields with the same interpretation for every TRB type (section 4.11.1). + * These are the fields defined in the TRB template, minus the ENT bit. That + * bit is the toggle cycle bit in link TRBs, so it shouldn't be in the + * template. + */ +static uint32_t xue_trb_cyc(const struct xue_trb *trb) +{ + return trb->ctrl & 0x1; +} + +static uint32_t xue_trb_type(const struct xue_trb *trb) +{ + return (trb->ctrl & 0xFC00) >> 10; +} + +static void xue_trb_set_cyc(struct xue_trb *trb, uint32_t c) +{ + trb->ctrl &= ~0x1UL; + trb->ctrl |= c; +} + +static void xue_trb_set_type(struct xue_trb *trb, uint32_t t) +{ + trb->ctrl &= ~0xFC00UL; + trb->ctrl |= (t << 10); +} + +/* Fields for normal TRBs */ +static void xue_trb_norm_set_buf(struct xue_trb *trb, uint64_t addr) +{ + trb->params = addr; +} + +static void xue_trb_norm_set_len(struct xue_trb *trb, uint32_t len) +{ + trb->status &= ~0x1FFFFUL; + trb->status |= len; +} + +static void xue_trb_norm_set_ioc(struct xue_trb *trb) +{ + trb->ctrl |= 0x20; +} + +/** + * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event + * TRBs are read-only from software + */ +static uint64_t xue_trb_tfre_ptr(const struct xue_trb *trb) +{ + return trb->params; +} + +static uint32_t xue_trb_tfre_cc(const struct xue_trb *trb) +{ + return trb->status >> 24; +} + +/* Fields for link TRBs (section 6.4.4.1) */ +static void xue_trb_link_set_rsp(struct xue_trb *trb, uint64_t rsp) +{ + trb->params = rsp; +} + +static void xue_trb_link_set_tc(struct xue_trb *trb) +{ + trb->ctrl |= 0x2; +} + +static void xue_trb_ring_init(const struct xue *xue, + struct xue_trb_ring *ring, int producer, + int doorbell) +{ + memset(ring->trb, 0, XUE_TRB_RING_CAP * sizeof(ring->trb[0])); + + ring->enq = 0; + ring->deq = 0; + ring->cyc = 1; + ring->db = (uint8_t)doorbell; + + /* + * Producer implies transfer ring, so we have to place a + * link TRB at the end that points back to trb[0] + */ + if ( producer ) + { + struct xue_trb *trb = &ring->trb[XUE_TRB_RING_CAP - 1]; + xue_trb_set_type(trb, xue_trb_link); + xue_trb_link_set_tc(trb); + xue_trb_link_set_rsp(trb, virt_to_maddr(ring->trb)); + } +} + +static int xue_trb_ring_full(const struct xue_trb_ring *ring) +{ + return ((ring->enq + 1) & (XUE_TRB_RING_CAP - 1)) == ring->deq; +} + +static int xue_work_ring_full(const struct xue_work_ring *ring) +{ + return ((ring->enq + 1) & (XUE_WORK_RING_CAP - 1)) == ring->deq; +} + +static uint64_t xue_work_ring_size(const struct xue_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return XUE_WORK_RING_CAP - ring->deq + ring->enq; +} + +static void xue_push_trb(struct xue *xue, struct xue_trb_ring *ring, + uint64_t dma, uint64_t len) +{ + struct xue_trb trb; + + if ( ring->enq == XUE_TRB_RING_CAP - 1 ) + { + /* + * We have to make sure the xHC processes the link TRB in order + * for wrap-around to work properly. We do this by marking the + * xHC as owner of the link TRB by setting the TRB's cycle bit + * (just like with normal TRBs). + */ + struct xue_trb *link = &ring->trb[ring->enq]; + xue_trb_set_cyc(link, ring->cyc); + + ring->enq = 0; + ring->cyc ^= 1; + } + + trb.params = 0; + trb.status = 0; + trb.ctrl = 0; + + xue_trb_set_type(&trb, xue_trb_norm); + xue_trb_set_cyc(&trb, ring->cyc); + + xue_trb_norm_set_buf(&trb, dma); + xue_trb_norm_set_len(&trb, (uint32_t)len); + xue_trb_norm_set_ioc(&trb); + + ring->trb[ring->enq++] = trb; + cache_flush(&ring->trb[ring->enq - 1], sizeof(trb)); +} + +static int64_t xue_push_work(struct xue *xue, struct xue_work_ring *ring, + const char *buf, int64_t len) +{ + int64_t i = 0; + uint32_t start = ring->enq; + uint32_t end = 0; + + while ( !xue_work_ring_full(ring) && i < len ) + { + ring->buf[ring->enq] = buf[i++]; + ring->enq = (ring->enq + 1) & (XUE_WORK_RING_CAP - 1); + } + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); + else if ( i > 0 ) + { + cache_flush(&ring->buf[start], XUE_WORK_RING_CAP - start); + cache_flush(&ring->buf[0], end); + } + + return i; +} + +/* + * Note that if IN transfer support is added, then this + * will need to be changed; it assumes an OUT transfer ring only + */ +static void xue_pop_events(struct xue *xue) +{ + const int trb_shift = 4; + + struct xue_dbc_reg *reg = xue->dbc_reg; + struct xue_trb_ring *er = &xue->dbc_ering; + struct xue_trb_ring *tr = &xue->dbc_oring; + struct xue_trb *event = &er->trb[er->deq]; + uint64_t erdp = reg->erdp; + + rmb(); + + while ( xue_trb_cyc(event) == er->cyc ) { + switch (xue_trb_type(event)) { + case xue_trb_tfre: + if ( xue_trb_tfre_cc(event) != xue_trb_cc_success ) + { + xue_alert("tfre error cc: %u\n", xue_trb_tfre_cc(event)); + break; + } + tr->deq = + (xue_trb_tfre_ptr(event) & XUE_TRB_RING_MASK) >> trb_shift; + break; + case xue_trb_psce: + reg->portsc |= (XUE_PSC_ACK_MASK & reg->portsc); + break; + default: + break; + } + + er->cyc = (er->deq == XUE_TRB_RING_CAP - 1) ? er->cyc ^ 1 : er->cyc; + er->deq = (er->deq + 1) & (XUE_TRB_RING_CAP - 1); + event = &er->trb[er->deq]; + } + + erdp &= ~XUE_TRB_RING_MASK; + erdp |= (er->deq << trb_shift); + wmb(); + reg->erdp = erdp; +} + +/** + * xue_init_ep + * + * Initializes the endpoint as specified in sections 7.6.3.2 and 7.6.9.2. + * Each endpoint is Bulk, so the MaxPStreams, LSA, HID, CErr, FE, + * Interval, Mult, and Max ESIT Payload fields are all 0. + * + * Max packet size: 1024 + * Max burst size: debug mbs (from dbc_reg->ctrl register) + * EP type: 2 for OUT bulk, 6 for IN bulk + * TR dequeue ptr: physical base address of transfer ring + * Avg TRB length: software defined (see 4.14.1.1 for suggested defaults) + */ +static void xue_init_ep(uint32_t *ep, uint64_t mbs, uint32_t type, + uint64_t ring_dma) +{ + memset(ep, 0, XUE_CTX_BYTES); + + ep[1] = (1024 << 16) | ((uint32_t)mbs << 8) | (type << 3); + ep[2] = (ring_dma & 0xFFFFFFFF) | 1; + ep[3] = ring_dma >> 32; + ep[4] = 3 * 1024; +} + +/* Initialize the DbC info with USB string descriptor addresses */ +static void xue_init_strings(struct xue *xue, uint32_t *info) +{ + uint64_t *sda; + + /* clang-format off */ + const char strings[] = { + 6, 3, 9, 0, 4, 0, + 8, 3, 'A', 0, 'I', 0, 'S', 0, + 30, 3, 'X', 0, 'u', 0, 'e', 0, ' ', 0, + 'D', 0, 'b', 0, 'C', 0, ' ', 0, + 'D', 0, 'e', 0, 'v', 0, 'i', 0, 'c', 0, 'e', 0, + 4, 3, '0', 0 + }; + /* clang-format on */ + + memcpy(xue->dbc_str, strings, sizeof(strings)); + + sda = (uint64_t *)&info[0]; + sda[0] = virt_to_maddr(xue->dbc_str); + sda[1] = sda[0] + 6; + sda[2] = sda[0] + 6 + 8; + sda[3] = sda[0] + 6 + 8 + 30; + info[8] = (4 << 24) | (30 << 16) | (8 << 8) | 6; +} + +static void xue_enable_dbc(struct xue *xue) +{ + struct xue_dbc_reg *reg = xue->dbc_reg; + + wmb(); + reg->ctrl |= (1UL << XUE_CTRL_DCE); + wmb(); + + while ( (reg->ctrl & (1UL << XUE_CTRL_DCE)) == 0 ) + xue_sys_pause(); + + wmb(); + reg->portsc |= (1UL << XUE_PSC_PED); + wmb(); + + while ( (reg->ctrl & (1UL << XUE_CTRL_DCR)) == 0 ) + xue_sys_pause(); +} + +static void xue_disable_dbc(struct xue *xue) +{ + struct xue_dbc_reg *reg = xue->dbc_reg; + + reg->portsc &= ~(1UL << XUE_PSC_PED); + wmb(); + reg->ctrl &= ~(1UL << XUE_CTRL_DCE); + + while ( reg->ctrl & (1UL << XUE_CTRL_DCE) ) + xue_sys_pause(); +} + +static int xue_init_dbc(struct xue *xue) +{ + uint64_t erdp = 0; + uint64_t out = 0; + uint64_t in = 0; + uint64_t mbs = 0; + struct xue_dbc_reg *reg = xue_find_dbc(xue); + + if ( !reg ) + return 0; + + xue->dbc_reg = reg; + xue_disable_dbc(xue); + + xue_trb_ring_init(xue, &xue->dbc_ering, 0, XUE_DB_INVAL); + xue_trb_ring_init(xue, &xue->dbc_oring, 1, XUE_DB_OUT); + xue_trb_ring_init(xue, &xue->dbc_iring, 1, XUE_DB_IN); + + erdp = virt_to_maddr(xue->dbc_ering.trb); + if ( !erdp ) + return 0; + + memset(xue->dbc_erst, 0, sizeof(*xue->dbc_erst)); + xue->dbc_erst->base = erdp; + xue->dbc_erst->size = XUE_TRB_RING_CAP; + + mbs = (reg->ctrl & 0xFF0000) >> 16; + out = virt_to_maddr(xue->dbc_oring.trb); + in = virt_to_maddr(xue->dbc_iring.trb); + + memset(xue->dbc_ctx, 0, sizeof(*xue->dbc_ctx)); + xue_init_strings(xue, xue->dbc_ctx->info); + xue_init_ep(xue->dbc_ctx->ep_out, mbs, xue_ep_bulk_out, out); + xue_init_ep(xue->dbc_ctx->ep_in, mbs, xue_ep_bulk_in, in); + + reg->erstsz = 1; + reg->erstba = virt_to_maddr(xue->dbc_erst); + reg->erdp = erdp; + reg->cp = virt_to_maddr(xue->dbc_ctx); + reg->ddi1 = (XUE_DBC_VENDOR << 16) | XUE_DBC_PROTOCOL; + reg->ddi2 = XUE_DBC_PRODUCT; + + cache_flush(xue->dbc_ctx, sizeof(*xue->dbc_ctx)); + cache_flush(xue->dbc_erst, sizeof(*xue->dbc_erst)); + cache_flush(xue->dbc_ering.trb, XUE_TRB_RING_BYTES); + cache_flush(xue->dbc_oring.trb, XUE_TRB_RING_BYTES); + cache_flush(xue->dbc_iring.trb, XUE_TRB_RING_BYTES); + cache_flush(xue->dbc_owork.buf, XUE_WORK_RING_BYTES); + + return 1; +} + +static void xue_init_work_ring(struct xue *xue, + struct xue_work_ring *wrk) +{ + wrk->enq = 0; + wrk->deq = 0; + wrk->dma = virt_to_maddr(wrk->buf); +} + +/* @endcond */ + +/** + * Initialize the DbC and enable it for transfers. First map in the DbC + * registers from the host controller's MMIO region. Then allocate and map + * DMA for the event and transfer rings. Finally, enable the DbC for + * the host to enumerate. On success, the DbC is ready to send packets. + * + * @param xue the xue to open (!= NULL) + * @return true iff xue_open succeeded + */ +static bool __init xue_open(struct xue *xue) +{ + if ( !xue ) + return false; + + if ( !xue_init_xhc(xue) ) + return false; + + if ( !xue_init_dbc(xue) ) + return false; + + xue_init_work_ring(xue, &xue->dbc_owork); + xue_enable_dbc(xue); + xue->open = 1; + + return true; +} + +/** + * Commit the pending transfer TRBs to the DbC. This notifies + * the DbC of any previously-queued data on the work ring and + * rings the doorbell. + * + * @param xue the xue to flush + * @param trb the ring containing the TRBs to transfer + * @param wrk the work ring containing data to be flushed + */ +static void xue_flush(struct xue *xue, struct xue_trb_ring *trb, + struct xue_work_ring *wrk) +{ + struct xue_dbc_reg *reg = xue->dbc_reg; + uint32_t db = (reg->db & 0xFFFF00FF) | (trb->db << 8); + + if ( xue->open && !(reg->ctrl & (1UL << XUE_CTRL_DCE)) ) + { + if ( !xue_init_dbc(xue) ) + return; + + xue_init_work_ring(xue, &xue->dbc_owork); + xue_enable_dbc(xue); + } + + xue_pop_events(xue); + + if ( !(reg->ctrl & (1UL << XUE_CTRL_DCR)) ) + { + xue_error("DbC not configured"); + return; + } + + if ( reg->ctrl & (1UL << XUE_CTRL_DRC) ) + { + reg->ctrl |= (1UL << XUE_CTRL_DRC); + reg->portsc |= (1UL << XUE_PSC_PED); + wmb(); + } + + if ( xue_trb_ring_full(trb) ) + return; + + if ( wrk->enq == wrk->deq ) + return; + else if ( wrk->enq > wrk->deq ) + { + xue_push_trb(xue, trb, wrk->dma + wrk->deq, wrk->enq - wrk->deq); + wrk->deq = wrk->enq; + } + else + { + xue_push_trb(xue, trb, wrk->dma + wrk->deq, + XUE_WORK_RING_CAP - wrk->deq); + wrk->deq = 0; + if ( wrk->enq > 0 && !xue_trb_ring_full(trb) ) + { + xue_push_trb(xue, trb, wrk->dma, wrk->enq); + wrk->deq = wrk->enq; + } + } + + wmb(); + reg->db = db; +} + +/** + * Queue a single character to the DbC. A transfer TRB will be created + * if the character is a newline and the DbC will be notified that data is + * available for writing to the debug host. + * + * @param xue the xue to write to + * @param c the character to write + * @return the number of bytes written + */ +static int64_t xue_putc(struct xue *xue, char c) +{ + if ( !xue_push_work(xue, &xue->dbc_owork, &c, 1) ) + return 0; + + if ( c == '\n' ) + xue_flush(xue, &xue->dbc_oring, &xue->dbc_owork); + + return 1; +} + +struct xue_uart { + struct xue xue; + struct timer timer; + spinlock_t *lock; +}; + +static struct xue_uart xue_uart; + +static void cf_check xue_uart_poll(void *data) +{ + struct serial_port *port = data; + struct xue_uart *uart = port->uart; + struct xue *xue = &uart->xue; + unsigned long flags = 0; + + if ( spin_trylock_irqsave(&port->tx_lock, flags) ) + { + xue_flush(xue, &xue->dbc_oring, &xue->dbc_owork); + spin_unlock_irqrestore(&port->tx_lock, flags); + } + + serial_tx_interrupt(port, guest_cpu_user_regs()); + set_timer(&uart->timer, NOW() + MICROSECS(XUE_POLL_INTERVAL)); +} + +static void __init cf_check xue_uart_init_preirq(struct serial_port *port) +{ + struct xue_uart *uart = port->uart; + uart->lock = &port->tx_lock; +} + +static void __init cf_check xue_uart_init_postirq(struct serial_port *port) +{ + struct xue_uart *uart = port->uart; + + serial_async_transmit(port); + init_timer(&uart->timer, xue_uart_poll, port, 0); + set_timer(&uart->timer, NOW() + MILLISECS(1)); +} + +static int cf_check xue_uart_tx_ready(struct serial_port *port) +{ + struct xue_uart *uart = port->uart; + struct xue *xue = &uart->xue; + + return XUE_WORK_RING_CAP - xue_work_ring_size(&xue->dbc_owork); +} + +static void cf_check xue_uart_putc(struct serial_port *port, char c) +{ + struct xue_uart *uart = port->uart; + xue_putc(&uart->xue, c); +} + +static void cf_check xue_uart_flush(struct serial_port *port) +{ + s_time_t goal; + struct xue_uart *uart = port->uart; + struct xue *xue = &uart->xue; + + xue_flush(xue, &xue->dbc_oring, &xue->dbc_owork); + + goal = NOW() + MICROSECS(XUE_POLL_INTERVAL); + if ( uart->timer.expires > goal ) + set_timer(&uart->timer, goal); +} + +static struct uart_driver xue_uart_driver = { + .init_preirq = xue_uart_init_preirq, + .init_postirq = xue_uart_init_postirq, + .tx_ready = xue_uart_tx_ready, + .putc = xue_uart_putc, + .flush = xue_uart_flush, +}; + +static struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); +static struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); +static struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); +static struct xue_erst_segment erst __aligned(64); +static struct xue_dbc_ctx ctx __aligned(64); +static uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); +static char str_buf[XUE_PAGE_SIZE] __aligned(64); +static char __initdata opt_dbgp[30]; + +string_param("dbgp", opt_dbgp); + +void __init xue_uart_init(void) +{ + struct xue_uart *uart = &xue_uart; + struct xue *xue = &uart->xue; + + if ( strncmp(opt_dbgp, "xue", 3) ) + return; + + memset(xue, 0, sizeof(*xue)); + + xue->dbc_ctx = &ctx; + xue->dbc_erst = &erst; + xue->dbc_ering.trb = evt_trb; + xue->dbc_oring.trb = out_trb; + xue->dbc_iring.trb = in_trb; + xue->dbc_owork.buf = wrk_buf; + xue->dbc_str = str_buf; + + if ( xue_open(xue) ) + serial_register_uart(SERHND_DBGP, &xue_uart_driver, &xue_uart); +} + +#ifdef XUE_DEBUG +static void xue_dump(struct xue *xue) +{ + struct xue_dbc_reg *r = xue->dbc_reg; + + xue_debug("XUE DUMP:\n"); + xue_debug(" ctrl: 0x%x stat: 0x%x psc: 0x%x\n", r->ctrl, r->st, + r->portsc); + xue_debug(" id: 0x%x, db: 0x%x\n", r->id, r->db); + xue_debug(" erstsz: %u, erstba: 0x%lx\n", r->erstsz, r->erstba); + xue_debug(" erdp: 0x%lx, cp: 0x%lx\n", r->erdp, r->cp); + xue_debug(" ddi1: 0x%x, ddi2: 0x%x\n", r->ddi1, r->ddi2); + xue_debug(" erstba == virt_to_dma(erst): %d\n", + r->erstba == virt_to_maddr(xue->dbc_erst)); + xue_debug(" erdp == virt_to_dma(erst[0].base): %d\n", + r->erdp == xue->dbc_erst[0].base); + xue_debug(" cp == virt_to_dma(ctx): %d\n", + r->cp == virt_to_maddr(xue->dbc_ctx)); +} + +static void xue_uart_dump(void) +{ + struct xue_uart *uart = &xue_uart; + struct xue *xue = &uart->xue; + + xue_dump(xue); +} +#endif diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 6548f0b0a9cf..a737c526a181 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -171,6 +171,9 @@ struct ns16550_defaults { }; void ns16550_init(int index, struct ns16550_defaults *defaults); void ehci_dbgp_init(void); +#ifdef CONFIG_HAS_XHCI +void xue_uart_init(void); +#endif void arm_uart_init(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362334.592359 (Exim 4.92) (envelope-from ) id 1o971O-0000ac-7p; Wed, 06 Jul 2022 15:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362334.592359; Wed, 06 Jul 2022 15:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971O-0000aN-4E; Wed, 06 Jul 2022 15:32:58 +0000 Received: by outflank-mailman (input) for mailman id 362334; Wed, 06 Jul 2022 15:32:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971M-000854-2b for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:56 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e77d41e5-fd40-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 17:32:55 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 56BAA5C0110; Wed, 6 Jul 2022 11:32:54 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 06 Jul 2022 11:32:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:52 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e77d41e5-fd40-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121574; x=1657207974; bh=APJyRhX6/2 wxNUIPxM+2LptgYjBbjDcQ/gEU4+XF8Xs=; b=naexuyo7OOluAJjx3VQHuw8Gl6 aW45I0V55oVSyghev1vf3BRqZWyJE+tCeC1DTR4ADT4Yhm3FpbrGMUcNaRc7DR6J hEVsp9HyIRungb6cVyeEjrDIGxY3Xy0DB9ywqkz/s08qv6Ostexnj06+cmMRoOYe YOSSET76ixGIcZ4wYtH2EhUY4pL8HY54VbTYyUtxBYSmvgyd7w6ZAgxJiIFLqm04 BC/dgUWXgcHSTYJxHi1euS9aXoK6lBN+m7qJbmrW0tJhSTHK7aUNPOBwM38uh5oA 2p59nWLCgmaW1L9KzA5KrCIumU/NUnMf70xOnX59qlWc3GJhX45ThVNs5hYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121574; x= 1657207974; bh=APJyRhX6/2wxNUIPxM+2LptgYjBbjDcQ/gEU4+XF8Xs=; b=s UBi9VBdnDNPFrCpmFVea1nnjHnpNK0csRJtERX9rbUF1mnNZB5MnVLlN9Z03pscR SS51evZo5v68evtzvWs8XXW/NXgXIkMeMp2R1pwWyeV5C1op1IYEw/XTwJStocEa BGtkqx5JpcjCMkE215zTF5z/j8myto0kDOU78wxf0z1rY/61rZWMLwmfJz6LXGnE SEsOejcJ2jSqFCTkRZc6wkgk6zp5Ywhlp56icQBqeMZkqk1nFIo49CChUfTm5qvf bfQuDSkOh6tjP2h/37skRNvJ/25TdOyYoZvlxRpT133EBGfMDDyBxS+twCKGgo5c 9eMeLIOxrg9oOmgqtSZOA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 3/9] xue: add support for selecting specific xhci Date: Wed, 6 Jul 2022 17:32:08 +0200 Message-Id: <399a41db5eb32197364b47a7031c30464803fa76.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Handle parameters similar to dbgp=ehci. Implement this by not resettting xhc_cf8 again in xue_init_xhc(), but using a value found there if non-zero. Additionally, add xue->xhc_num to select n-th controller. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v2: - unsigned int xhc_num - code style --- docs/misc/xen-command-line.pandoc | 2 +- xen/drivers/char/xue.c | 53 ++++++++++++++++++++++++-------- 2 files changed, 42 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index f9fa857bd84e..1ab92bf7b50a 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,7 +721,7 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` -> `= xue` +> `= xue[ | @pci:. ]` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). diff --git a/xen/drivers/char/xue.c b/xen/drivers/char/xue.c index 2cbbaea11fa0..9d48068a5fba 100644 --- a/xen/drivers/char/xue.c +++ b/xen/drivers/char/xue.c @@ -205,6 +205,7 @@ struct xue { void *xhc_mmio; int open; + unsigned int xhc_num; /* look for n-th xhc */ }; static void xue_sys_pause(void) @@ -238,24 +239,35 @@ static bool __init xue_init_xhc(struct xue *xue) uint64_t bar1; uint64_t devfn; - /* - * Search PCI bus 0 for the xHC. All the host controllers supported so far - * are part of the chipset and are on bus 0. - */ - for ( devfn = 0; devfn < 256; devfn++ ) + if ( xue->sbdf.sbdf == 0 ) { - pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); - uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); - - if ( hdr == 0 || hdr == 0x80 ) + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so far + * are part of the chipset and are on bus 0. + */ + for ( devfn = 0; devfn < 256; devfn++ ) { - if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); + uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr == 0 || hdr == 0x80 ) { - xue->sbdf = sbdf; - break; + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) + { + if ( xue->xhc_num-- ) + continue; + xue->sbdf = sbdf; + break; + } } } } + else + { + /* Verify if selected device is really xHC */ + if ( (pci_conf_read32(xue->sbdf, PCI_CLASS_REVISION) >> 8) != XUE_XHC_CLASSC ) + xue->sbdf.sbdf = 0; + } if ( !xue->sbdf.sbdf ) { @@ -955,12 +967,29 @@ void __init xue_uart_init(void) { struct xue_uart *uart = &xue_uart; struct xue *xue = &uart->xue; + const char *e; if ( strncmp(opt_dbgp, "xue", 3) ) return; memset(xue, 0, sizeof(*xue)); + if ( isdigit(opt_dbgp[3]) || !opt_dbgp[3] ) + { + if ( opt_dbgp[3] ) + xue->xhc_num = simple_strtoul(opt_dbgp + 3, &e, 10); + } + else if ( strncmp(opt_dbgp + 3, "@pci", 4) == 0 ) + { + unsigned int bus, slot, func; + + e = parse_pci(opt_dbgp + 7, NULL, &bus, &slot, &func); + if ( !e || *e ) + return; + + xue->sbdf = PCI_SBDF(0, bus, slot, func); + } + xue->dbc_ctx = &ctx; xue->dbc_erst = &erst; xue->dbc_ering.trb = evt_trb; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:32:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:32:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362335.592363 (Exim 4.92) (envelope-from ) id 1o971O-0000eb-Kd; Wed, 06 Jul 2022 15:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362335.592363; Wed, 06 Jul 2022 15:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971O-0000e4-Ge; Wed, 06 Jul 2022 15:32:58 +0000 Received: by outflank-mailman (input) for mailman id 362335; Wed, 06 Jul 2022 15:32:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971N-00081g-G8 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:57 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e86c1d32-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:32:56 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E7E865C013E; Wed, 6 Jul 2022 11:32:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Jul 2022 11:32:55 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:54 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e86c1d32-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121575; x=1657207975; bh=/FmM9IRoHk jrJvz5SecKZ+9vnPpot8BHqRtqlD2wsdk=; b=TeSF8TQIHWZN5u8l7NlLQgmrM2 392VbjOuH3mKRqIp+KAzyPGq9YLgnpYQnIHQH0lzWrTp/kaCYeGzQjErBJWeo3tb MvJ+PLtttNzAuaScAuxBJFVnhq8ARuJRPzCTjpoda3gvSOUyz5kPLp3u9PMrRYiE 4Rbyna0jKb5qkWFntG+XleLPi8YfBW8SMrI8sTjk4jp/3vfxBgWQgQxq+T7+17MH oogqlRW0aOSO4qwhNLCcFLYZtMyPMVHy8687y0RyHpJmw4VGzxLv6VC1CgBad4V1 WrF8+c9rvESv1gtgD7V+tDZYtqTUsBxw+gKshhdqIdhOegoMfGTsARQNGH7Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121575; x= 1657207975; bh=/FmM9IRoHkjrJvz5SecKZ+9vnPpot8BHqRtqlD2wsdk=; b=v EBaxY41fGsJy42QkRx73YdFsYVw5q+FrdmcA8VDmYJrIVSqdhCONLT+l/sDgqjH7 sh11/yOHyqz85xdsmLAYB+CIlH67DFeSAvg7/3DeQyhmKJ8kIf/wf5GKjojrZZEq exuLtgrja6lWXvNf5ls0ALlDdlTN7e8llWpdlSvhFXCdSpiiY2WqyDNpdzPdOH4P 6vSynGaBwV8ityhz8IwgyNp/oUAnkruP0hXhiVRMNmqiEsF0voxcbPpfj/0095tb PEJ06OjS9HQCbcUsAY8QPymD7rXRBNNCNdSSeOQEngQ1W/juEQQIDlPtpvd4d+Hn SrMlgoqmUxD7QNoWrlc4Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 4/9] console: support multiple serial console simultaneously Date: Wed, 6 Jul 2022 17:32:09 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of MAX_SERCONS (4) is arbitrary, inspired by the number of SERHND_IDX values. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/char/console.c | 58 ++++++++++++++++++++++++++++++--------- 1 file changed, 45 insertions(+), 13 deletions(-) diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index f9937c5134c0..44b703296487 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; static uint32_t __read_mostly conring_size = _CONRING_SIZE; static uint32_t conringc, conringp; -static int __read_mostly sercon_handle = -1; +#define MAX_SERCONS 4 +static int __read_mostly sercon_handle[MAX_SERCONS]; +static int __read_mostly nr_sercon_handle = 0; #ifdef CONFIG_X86 /* Tristate: 0 disabled, 1 user enabled, -1 default enabled */ @@ -395,9 +397,17 @@ static unsigned int serial_rx_cons, serial_rx_prod; static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +/* Redirect any console output to *fn*, if *handle* is configured as a console. */ int console_steal(int handle, void (*fn)(const char *, size_t nr)) { - if ( (handle == -1) || (handle != sercon_handle) ) + int i; + + if ( handle == -1 ) + return 0; + for ( i = 0; i < nr_sercon_handle; i++ ) + if ( handle == sercon_handle[i] ) + break; + if ( nr_sercon_handle && i == nr_sercon_handle ) return 0; if ( serial_steal_fn != NULL ) @@ -415,10 +425,13 @@ void console_giveback(int id) void console_serial_puts(const char *s, size_t nr) { + int i; + if ( serial_steal_fn != NULL ) serial_steal_fn(s, nr); else - serial_puts(sercon_handle, s, nr); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_puts(sercon_handle[i], s, nr); /* Copy all serial output into PV console */ pv_console_puts(s, nr); @@ -956,7 +969,7 @@ void guest_printk(const struct domain *d, const char *fmt, ...) void __init console_init_preirq(void) { char *p; - int sh; + int sh, i; serial_init_preirq(); @@ -977,7 +990,8 @@ void __init console_init_preirq(void) continue; else if ( (sh = serial_parse_handle(p)) >= 0 ) { - sercon_handle = sh; + if ( nr_sercon_handle < MAX_SERCONS ) + sercon_handle[nr_sercon_handle++] = sh; serial_steal_fn = NULL; } else @@ -996,7 +1010,8 @@ void __init console_init_preirq(void) opt_console_xen = 0; #endif - serial_set_rx_handler(sercon_handle, serial_rx); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_set_rx_handler(sercon_handle[i], serial_rx); pv_console_set_rx_handler(serial_rx); /* HELLO WORLD --- start-of-day banner text. */ @@ -1014,7 +1029,8 @@ void __init console_init_preirq(void) if ( opt_sync_console ) { - serial_start_sync(sercon_handle); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_sync(sercon_handle[i]); add_taint(TAINT_SYNC_CONSOLE); printk("Console output is synchronous.\n"); warning_add(warning_sync_console); @@ -1121,13 +1137,19 @@ int __init console_has(const char *device) void console_start_log_everything(void) { - serial_start_log_everything(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_log_everything(sercon_handle[i]); atomic_inc(&print_everything); } void console_end_log_everything(void) { - serial_end_log_everything(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_log_everything(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1149,23 +1171,32 @@ void console_unlock_recursive_irqrestore(unsigned long flags) void console_force_unlock(void) { + int i; + watchdog_disable(); spin_debug_disable(); spin_lock_init(&console_lock); - serial_force_unlock(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_force_unlock(sercon_handle[i]); console_locks_busted = 1; console_start_sync(); } void console_start_sync(void) { + int i; + atomic_inc(&print_everything); - serial_start_sync(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_start_sync(sercon_handle[i]); } void console_end_sync(void) { - serial_end_sync(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_sync(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1291,7 +1322,8 @@ static int suspend_steal_id; int console_suspend(void) { - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); + if ( nr_sercon_handle ) + suspend_steal_id = console_steal(sercon_handle[0], suspend_steal_fn); serial_suspend(); return 0; } -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:33:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362336.592379 (Exim 4.92) (envelope-from ) id 1o971P-000129-Uk; Wed, 06 Jul 2022 15:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362336.592379; Wed, 06 Jul 2022 15:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971P-00011f-Q6; Wed, 06 Jul 2022 15:32:59 +0000 Received: by outflank-mailman (input) for mailman id 362336; Wed, 06 Jul 2022 15:32:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971O-00081g-OS for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:32:58 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e934b572-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:32:58 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 40BA75C010B; Wed, 6 Jul 2022 11:32:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 06 Jul 2022 11:32:57 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:56 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e934b572-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121577; x=1657207977; bh=ugqnVzOyfv 4jmGK3lamfJM0o6KeQBk0JkpJmDYjEpP4=; b=ilQbqMYO7lq2qfPQyIr8RvB85w 6g9JsNgj4wb6wzOMOE78OMT++eZaQ8cIjK8q50Ib0Kf2P2HCBDfqvdXefoiYIEba 22yM0XUDhcSj7L3/03nsvPNAxOlIjXAYObv5BSCL6Hamc4QnSfK0D680N09u2UNa xD2TGL0p0Axp12gbGDhmczFjfiigTW8xiilQMIjLaTmylx+BCf9QkxoUrGegPJsY IQ84JZUMnw3VFUBfi4xDVCwHq7FsNJuwAgSg3JuO2Jv5dHPS5E/4KL9A7FAF25YR Ogh1pT0yq5ahJkiiMWwL/+YveNuvWcWr0XTiopn1VmnnVR4TZYAvi+IMgOcQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121577; x= 1657207977; bh=ugqnVzOyfv4jmGK3lamfJM0o6KeQBk0JkpJmDYjEpP4=; b=M 6HFayEfAIjcXBe94I2gyjSLy3oulfGc8tAiaHgEkpr14I+vDV0ogAbbibU6XD6gL 8cNLhxlSU4fANxMp/f0EfbeJYx7xBLxHRCIzOY1TXchCyo4LPTgCVGJ0Zunf8+3w 7u3S1Z67IfsVhz3VbhHjPfv5JnmAClOxD47xfMKwBd1Xt8iafn2RpI5gyjUqlTjQ X/w+QocjPoXX5/1mZDZGPej63lPbjmRG8FIj5WO19aj4hnVgvUc0bBswvufpRDeg phRz/3eLfL+7egjvCFayhUrpWtB7thUCltZcRXO5AIP+p3EZE43ASJs+VsZYBt5I Y984faiXl7yGiWjy7jhWg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Date: Wed, 6 Jul 2022 17:32:10 +0200 Message-Id: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for user-supplied reserved memory, and it may be useful for other drivers in the future too. This commit just introduces an API, subsequent patches will plug it in appropriate places. The reserved memory ranges needs to be saved locally, because at the point when they are collected, Xen doesn't know yet which IOMMU driver will be used. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/passthrough/iommu.c | 40 ++++++++++++++++++++++++++++++++++- xen/include/xen/iommu.h | 11 +++++++++- 2 files changed, 51 insertions(+) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 75df3aa8ddaa..257691ad19ef 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -651,6 +651,46 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } +#define MAX_EXTRA_RESERVED_RANGES 20 +struct extra_reserved_range { + xen_pfn_t start; + xen_ulong_t nr; + u32 sbdf; +}; +static unsigned int __initdata nr_extra_reserved_ranges; +static struct extra_reserved_range __initdata extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; + +int iommu_add_extra_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr, u32 sbdf) +{ + unsigned int idx; + + if ( nr_extra_reserved_ranges >= MAX_EXTRA_RESERVED_RANGES ) + return -ENOMEM; + + idx = nr_extra_reserved_ranges++; + extra_reserved_ranges[idx].start = start; + extra_reserved_ranges[idx].nr = nr; + extra_reserved_ranges[idx].sbdf = sbdf; + return 0; +} + +int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void *ctxt) +{ + unsigned int idx; + int ret; + + for ( idx = 0; idx < nr_extra_reserved_ranges; idx++ ) + { + ret = func(extra_reserved_ranges[idx].start, + extra_reserved_ranges[idx].nr, + extra_reserved_ranges[idx].sbdf, + ctxt); + if ( ret < 0 ) + return ret; + } + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 79529adf1fa5..7640f40d77b5 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -297,6 +297,17 @@ struct iommu_ops { #endif }; +/* + * To be called by Xen internally, to register extra RMRR/IVMD ranges. + * Needs to be called before IOMMU initialization. + */ +extern int iommu_add_extra_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr, u32 sbdf); +/* + * To be called by specific IOMMU driver during initialization, + * to fetch ranges registered with iommu_add_extra_reserved_device_memory(). + */ +extern int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void *ctxt); + #include #ifndef iommu_call -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:33:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362337.592392 (Exim 4.92) (envelope-from ) id 1o971U-0001YW-Ce; Wed, 06 Jul 2022 15:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362337.592392; Wed, 06 Jul 2022 15:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971U-0001YA-8Z; Wed, 06 Jul 2022 15:33:04 +0000 Received: by outflank-mailman (input) for mailman id 362337; Wed, 06 Jul 2022 15:33:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971S-000854-48 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:33:02 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb2c432a-fd40-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 17:33:01 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 866095C0136; Wed, 6 Jul 2022 11:33:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Jul 2022 11:33:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:59 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb2c432a-fd40-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121580; x=1657207980; bh=A6IUb5PhcA I6HvRB0V+hA466Exyej9hEMYg/SSDCyCk=; b=giNnmr03OleSnwJ++SmNzG+uUj 8dD7FzdmjgL6RasPbWwx2xu8FR+i2dUcygeQYdNTW07eJrKH93fykc0tQv6kV89J PH54TA0cHlkfO0VYAeOpqOkFP+85JgzUY5Dfb5c/6lyB/FB43dpt9phtc7NabxfZ EwXqksbscPpcjN743r+8Mlue2qWELTz5Mq6/ICORGAeKee9ycgp7toAYmfmTYAYv 10xAZNKsTJqTsItteWEjL19hGTThWsjeNa75lFfCgUhg5RLMYyzJfywdUQKNTYeO i3Vu7SjFZe81SJ8xloGQ7ich8DwDMr1ulI2av4H9iGN4o3GcqwqpJlCvJQtw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121580; x= 1657207980; bh=A6IUb5PhcAI6HvRB0V+hA466Exyej9hEMYg/SSDCyCk=; b=k dH3cTDdbnh8i9bmHzv3nUXSMx+X5/hrxJtrRxwWOMYqpUsDSDjv0PYag8iREk4lO MP/Mhw/4Xxmc5DmeIucyvQRyMHJEIUOJ9V2m7QvjZUgxN21B3LFREFTNN+KoIEo4 JoT2ozwE6sTgNQ9/3uofMaMT9TGjRxVV10eEX0Un7CvZQ9K8+41yjPvEgzUMVsGo SA9sOjhr3OmJp2MCjYQA6iugzKmfNRlghA7AMkEvNCIqkK9syzwCQ5jRtw5f2Q5+ SVsp3LZJqTm7xYKQQQS3wp9/If08pvWeWRUDVQWao7T8dhDrET9d+wd1HKKjFtsB linyVnuHSSePJaxqAsmng== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper Subject: [PATCH v2 7/9] IOMMU/AMD: wire common device reserved memory API Date: Wed, 6 Jul 2022 17:32:12 +0200 Message-Id: <457056cbc6dcc00958b1f4e0cad35121e0cd1557.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/passthrough/amd/iommu_acpi.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index ac6835225bae..2a4896c05442 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1078,6 +1078,20 @@ static inline bool_t is_ivmd_block(u8 type) type == ACPI_IVRS_TYPE_MEMORY_IOMMU); } +static int __init cf_check add_one_extra_ivmd(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + struct acpi_ivrs_memory ivmd; + + ivmd.start_address = start << PAGE_SHIFT; + ivmd.memory_length = nr << PAGE_SHIFT; + ivmd.header.flags = ACPI_IVMD_UNITY | + ACPI_IVMD_READ | ACPI_IVMD_WRITE; + ivmd.header.length = sizeof(ivmd); + ivmd.header.device_id = id; + ivmd.header.type = ACPI_IVRS_TYPE_MEMORY_ONE; + return parse_ivmd_block(&ivmd); +} + static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) { const struct acpi_ivrs_header *ivrs_block; @@ -1121,6 +1135,8 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) AMD_IOMMU_DEBUG("IVMD: %u command line provided entries\n", nr_ivmd); for ( i = 0; !error && i < nr_ivmd; ++i ) error = parse_ivmd_block(user_ivmds + i); + if ( !error ) + error = iommu_get_extra_reserved_device_memory(add_one_extra_ivmd, NULL); /* Each IO-APIC must have been mentioned in the table. */ for ( apic = 0; !error && iommu_intremap && apic < nr_ioapics; ++apic ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:33:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362339.592402 (Exim 4.92) (envelope-from ) id 1o971V-0001jj-NE; Wed, 06 Jul 2022 15:33:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362339.592402; Wed, 06 Jul 2022 15:33:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971V-0001im-Ba; Wed, 06 Jul 2022 15:33:05 +0000 Received: by outflank-mailman (input) for mailman id 362339; Wed, 06 Jul 2022 15:33:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971T-00081g-OE for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:33:03 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ec2a991e-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:33:02 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 389A05C0143; Wed, 6 Jul 2022 11:33:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Jul 2022 11:33:02 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:33:00 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ec2a991e-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121582; x=1657207982; bh=Eq84+x/gpm KZZ+zmuklaLt+FseOD4ttC2HJ0766Jnt4=; b=hdYwMC+EKepNtFMV62HBLMx6DX 2/bNz/1JTmvwst161sTqM5pbMQ1+evWDgU6l8T2X4FgOw6MlqyQjiDu/ZD9aH3gM vC1Z7dpymX9g+Neg4UcMLR3PamkmtRC6gi0CT8qmMbYzgIG2pClm71V4yk/0r4Q3 rn3tDu+Fo05b2cCfHqAdaDZ1HroQnSKvNboGwO1G2vGZCYSyZIQVbYZOuaXjm5NM yEv8GABSWqYfN7qLXNraQFaqT4gARB6iuSosZ8MM32rhNO+spzInEZrZrWPxJAwd HK8Pc1R7m9tpyvRqCALy+oh7OAFm1fOuXpCipduOY40NZMQJoJs9z1UAoKQg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121582; x= 1657207982; bh=Eq84+x/gpmKZZ+zmuklaLt+FseOD4ttC2HJ0766Jnt4=; b=s WVpQNg50CH28xPgvzg7I2ZWewg2wzY0XkUNrHReV2tGrixzC5Sbdn/5hFP623Y4o ppH5SfpSD1MUg8lXnSqVOBJ2xcR3iSR9ZNfpXiKrziVAhOPicxi0pQyLQQNxwixn +emgYL5SLYfsGTL/7YEkvhA4dx69NxvRF6SRYx/k9VLpP9wayaAMzImvuXig8noa 9ZtSJftPqSZvY0m4zDCxghlt4r6uQp+A41X/BJZ3vuSPwqFHtVbUYDnMq1J+yzwc YYHqWJdbiDtRmT7Bq1zq3rWt514la6SCWcPT/xDC9lrk6PPWJbVglag6KjpUbkau 6U9D1iix3i/rMcm0b65eQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian Subject: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Date: Wed, 6 Jul 2022 17:32:13 +0200 Message-Id: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later patches), that domain will effectively have access to those buffers too. It does give such domain yet another way to DoS the system (as is the case when having PCI device assigned already), but also possibly steal the console ring content. Thus, such domain should be a trusted one. In any case, prevent anything else being placed on those pages by adding artificial padding. Using this API for DbC pages requires raising MAX_USER_RMRR_PAGES. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/char/xue.c | 43 ++++++++++++++++++++----------- xen/drivers/passthrough/vtd/dmar.c | 2 +- 2 files changed, 30 insertions(+), 15 deletions(-) diff --git a/xen/drivers/char/xue.c b/xen/drivers/char/xue.c index 9d48068a5fba..a6c49bb43e97 100644 --- a/xen/drivers/char/xue.c +++ b/xen/drivers/char/xue.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -952,13 +953,21 @@ static struct uart_driver xue_uart_driver = { .flush = xue_uart_flush, }; -static struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); -static struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); -static struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); -static struct xue_erst_segment erst __aligned(64); -static struct xue_dbc_ctx ctx __aligned(64); -static uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); -static char str_buf[XUE_PAGE_SIZE] __aligned(64); +struct xue_dma_bufs { + struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); + struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); + struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); + struct xue_erst_segment erst __aligned(64); + struct xue_dbc_ctx ctx __aligned(64); + uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); + char str_buf[XUE_PAGE_SIZE] __aligned(64); + /* + * Don't place anything else on this page - it will be + * DMA-reachable by the USB controller. + */ + char _pad[0] __aligned(XUE_PAGE_SIZE); +}; +static struct xue_dma_bufs xue_dma_bufs __aligned(XUE_PAGE_SIZE); static char __initdata opt_dbgp[30]; string_param("dbgp", opt_dbgp); @@ -990,16 +999,22 @@ void __init xue_uart_init(void) xue->sbdf = PCI_SBDF(0, bus, slot, func); } - xue->dbc_ctx = &ctx; - xue->dbc_erst = &erst; - xue->dbc_ering.trb = evt_trb; - xue->dbc_oring.trb = out_trb; - xue->dbc_iring.trb = in_trb; - xue->dbc_owork.buf = wrk_buf; - xue->dbc_str = str_buf; + xue->dbc_ctx = &xue_dma_bufs.ctx; + xue->dbc_erst = &xue_dma_bufs.erst; + xue->dbc_ering.trb = xue_dma_bufs.evt_trb; + xue->dbc_oring.trb = xue_dma_bufs.out_trb; + xue->dbc_iring.trb = xue_dma_bufs.in_trb; + xue->dbc_owork.buf = xue_dma_bufs.wrk_buf; + xue->dbc_str = xue_dma_bufs.str_buf; if ( xue_open(xue) ) + { + iommu_add_extra_reserved_device_memory( + PFN_DOWN(virt_to_maddr(&xue_dma_bufs)), + PFN_UP(sizeof(xue_dma_bufs)), + uart->xue.sbdf.sbdf); serial_register_uart(SERHND_DBGP, &xue_uart_driver, &xue_uart); + } } #ifdef XUE_DEBUG diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 661a182b08d9..2caa3e9ad1b0 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -845,7 +845,7 @@ out: return ret; } -#define MAX_USER_RMRR_PAGES 16 +#define MAX_USER_RMRR_PAGES 64 #define MAX_USER_RMRR 10 /* RMRR units derived from command line rmrr option. */ -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:33:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362338.592398 (Exim 4.92) (envelope-from ) id 1o971V-0001gX-A9; Wed, 06 Jul 2022 15:33:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362338.592398; Wed, 06 Jul 2022 15:33:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971U-0001et-UP; Wed, 06 Jul 2022 15:33:04 +0000 Received: by outflank-mailman (input) for mailman id 362338; Wed, 06 Jul 2022 15:33:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971T-000854-49 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:33:03 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eae134f3-fd40-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 17:33:01 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id D8895320039A; Wed, 6 Jul 2022 11:32:58 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 06 Jul 2022 11:32:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:32:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eae134f3-fd40-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121578; x=1657207978; bh=evEV0WFYEo SI8Y7yrgXC8kLje73u4yjd3P/XL+ndlpo=; b=xAG5ioSoqt1hUR6SUwfeglIzOo RcFVNAjLABt+uAIjNjxDIhghKxlCPrFNvz8RLQUpG2gnVdIw/vpUW9Ayp9oUeMSP vcYILZp7GLJTr6ukaZa3JSjqbPvSBsivRExDNmq4YV8oIxfTEHBkJ4rOwdWI1lds v9ubXal14ruUYUBRtQBo25zQrN3bzZAoQ42R9/zPOHip5CPA/g/w9DIhrlkH7eZY 1DBTzgkSjroNBgvXsB4/rIjqbmmePzNURC+C+kWPBpbALmiBSDOPs7RizEDis4XV K6xMOQjT++v0c5f48tZfvMptwaggcr5F7g0SnPTZaI6WHQKqAV6b4p7AmzJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121578; x= 1657207978; bh=evEV0WFYEoSI8Y7yrgXC8kLje73u4yjd3P/XL+ndlpo=; b=T zYiX4w0d4ZQP8nxPUyHW+tOtRuvhUWJqI3qdw/NDr9sER2ASbz3LOVogwHFxbCZ9 1AquxKu424sp8o2LnB0NvgBB66cdu+d22uQOFPEa+RpCiX6NcQCKAWnyeMo2OkRp qioYolTke09hMrMEqCjEAufDAllwaurs8Xllygh+RBermSHkhUInHVfy5TyRc4SZ FrkWghVzxVBi0n1Rd57PF2ZegvHjhIY/jH6Ph7u+aJmzvKCXlZ8nzotuJY8Tj5vr O5NypigMbIp4xSzxta3frGT1cgciV3Gj1F8cr9MfYEi0edD0JHgBGutt/mAKkddC zTvSo8KLClrZgE1/7k9xw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v2 6/9] IOMMU/VT-d: wire common device reserved memory API Date: Wed, 6 Jul 2022 17:32:11 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- 1 file changed, 119 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 367304c8739c..661a182b08d9 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,111 +861,148 @@ static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR]; /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn + +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + u32 *sbdf); static int __init add_user_rmrr(void) { + unsigned int i; + int ret; + + for ( i = 0; i < nr_rmrr; i++ ) + { + ret = add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } + return 0; +} + +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + u32 *sbdf) +{ struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; - for ( i = 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) + { + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } + + if ( (end_pfn - base_pfn) >= MAX_USER_RMRR_PAGES ) { - base = user_rmrrs[i].base_pfn; - end = user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + ERMRRU_ARG); + return 0; + } - if ( base > end ) + overlap = false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <= rmrru->end_address && + rmrru->base_address <= pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap = true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; - if ( (end - base) >= MAX_USER_RMRR_PAGES ) + base_iter = base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); - overlap = false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <= rmrru->end_address && - rmrru->base_address <= pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap = true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. */ + if ( base_iter <= end_pfn ) + return 0; - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr = xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; - /* Invalid pfn in range as the loop ended before end_pfn was reached. */ - if ( base <= end ) - continue; + rmrr->scope.devices = xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } - rmrr = xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg = 0; + for ( idx = 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] = sbdf[idx]; + seg |= PCI_SEG(sbdf[idx]); + } + if ( seg != PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } - rmrr->scope.devices = xmalloc_array(u16, user_rmrrs[i].dev_count); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment = seg; + rmrr->base_address = pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address = pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt = dev_count; - seg = 0; - for ( idx = 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] = user_rmrrs[i].sbdf[idx]; - seg |= PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg != PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); - rmrr->segment = seg; - rmrr->base_address = pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address = pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_MASK; - rmrr->scope.devices_cnt = user_rmrrs[i].dev_count; + return 1; +} - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] = { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} - return 0; +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL); } #include @@ -1010,7 +1047,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops = &intel_iommu_init_ops; - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } return ret; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362340.592418 (Exim 4.92) (envelope-from ) id 1o971X-0002DS-Jd; Wed, 06 Jul 2022 15:33:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362340.592418; Wed, 06 Jul 2022 15:33:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971X-0002CL-BM; Wed, 06 Jul 2022 15:33:07 +0000 Received: by outflank-mailman (input) for mailman id 362340; Wed, 06 Jul 2022 15:33:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o971V-00081g-Ab for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:33:05 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed224e52-fd40-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:33:04 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D0C825C0110; Wed, 6 Jul 2022 11:33:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 06 Jul 2022 11:33:03 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 6 Jul 2022 11:33:02 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed224e52-fd40-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1657121583; x=1657207983; bh=KNhvo36Hm8 tSnLm7qCfjQ1noa8heK9BU5yJ49iE2Lhk=; b=HSypKNz25Y14o8CyLUGEofqSJg EJfpN4QdMgtqN34Hr5RO8lHjz/MwFhm2jCEcQPUr9ViUMyVbNerNRnby//AtDXBi EpZQQl5X1y9gfat2DF3JREpYAlMEENFWCyvfThYzTK9XmXZtStTpcd0T0kJElpVb qN8zhftrdo8G3HziPCoJWQ3U/IHKNaTEXOjejCwL4dW6Xa39LRDtGGZGgYw+Kqa0 6cNpQWmEGfp+Dc2iAl/HRO3V+9YuQKo98WWaKFJ9dESPIsfhOVC9WzmFUZVYt8MZ /xYFgRe2E8O4dApOyua8QFngnAwogqwuHZNG/9XvoyccKcjGwPqvepaamlqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1657121583; x= 1657207983; bh=KNhvo36Hm8tSnLm7qCfjQ1noa8heK9BU5yJ49iE2Lhk=; b=r iVuK09+RakN3kOEDen/O7hbwhoaNctm4nmTc9u7ePOGg7WnUrLTgn9FYSmzN2tUZ nupq6/kxBt6vAhnBvqU1plndnrs7+w8ucIuWs8VX0XsTWC5x7QKi3gMOb4oqqjK/ zHaTmjIlGS31XDo0GwD6xwD3tyfGTl2IMMpCyy28qjtvT8NFlPoGCZAqP1kWmGba Db3XXbc6yYkwdpq4Mf9kC/X3qWkh347cCufR7QCAUB2Qa6khS/0Q2KtM0h9VY6Iq pkb9nEnqYIux6vZxpaKpsX6/GYvIHZtQbNor9BEGeImhzBIbpl+1ChNYt5l2EppK L2moXbCFatOPIgOTMyEOw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeifedgkeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC Date: Wed, 6 Jul 2022 17:32:14 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re-enabling bus mastering behind dom0's backs. Linux driver does similar thing - see drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). To avoid Linux messing with the DbC, mark this MMIO area as read-only. Signed-off-by: Marek Marczykowski-Górecki --- xen/drivers/char/xue.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/xen/drivers/char/xue.c b/xen/drivers/char/xue.c index a6c49bb43e97..3461e51e746a 100644 --- a/xen/drivers/char/xue.c +++ b/xen/drivers/char/xue.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include #include @@ -807,6 +808,7 @@ static void xue_flush(struct xue *xue, struct xue_trb_ring *trb, { struct xue_dbc_reg *reg = xue->dbc_reg; uint32_t db = (reg->db & 0xFFFF00FF) | (trb->db << 8); + uint32_t cmd; if ( xue->open && !(reg->ctrl & (1UL << XUE_CTRL_DCE)) ) { @@ -817,6 +819,16 @@ static void xue_flush(struct xue *xue, struct xue_trb_ring *trb, xue_enable_dbc(xue); } + /* Re-enable bus mastering, if dom0 (or other) disabled it in the meantime. */ + cmd = pci_conf_read16(xue->sbdf, PCI_COMMAND); +#define XUE_XHCI_CMD_REQUIRED (PCI_COMMAND_MEMORY|PCI_COMMAND_MASTER) + if ( (cmd & XUE_XHCI_CMD_REQUIRED) != XUE_XHCI_CMD_REQUIRED ) + { + cmd |= XUE_XHCI_CMD_REQUIRED; + pci_conf_write16(xue->sbdf, PCI_COMMAND, cmd); + } +#undef XUE_XHCI_CMD_REQUIRED + xue_pop_events(xue); if ( !(reg->ctrl & (1UL << XUE_CTRL_DCR)) ) @@ -916,6 +928,13 @@ static void __init cf_check xue_uart_init_postirq(struct serial_port *port) serial_async_transmit(port); init_timer(&uart->timer, xue_uart_poll, port, 0); set_timer(&uart->timer, NOW() + MILLISECS(1)); + +#ifdef CONFIG_X86 + if ( rangeset_add_range(mmio_ro_ranges, + PFN_DOWN(uart->xue.xhc_mmio_phys + uart->xue.xhc_dbc_offset), + PFN_UP(uart->xue.xhc_mmio_phys + uart->xue.xhc_dbc_offset + sizeof(*uart->xue.dbc_reg)) - 1) ) + printk(XENLOG_INFO "Error while adding MMIO range of device to mmio_ro_ranges\n"); +#endif } static int cf_check xue_uart_tx_ready(struct serial_port *port) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 15:38:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 15:38:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362387.592436 (Exim 4.92) (envelope-from ) id 1o976c-00060T-TV; Wed, 06 Jul 2022 15:38:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362387.592436; Wed, 06 Jul 2022 15:38:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o976c-00060H-Qo; Wed, 06 Jul 2022 15:38:22 +0000 Received: by outflank-mailman (input) for mailman id 362387; Wed, 06 Jul 2022 15:38:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o976a-0005xl-TL for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 15:38:21 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20042.outbound.protection.outlook.com [40.107.2.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a90343f3-fd41-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 17:38:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB7665.eurprd04.prod.outlook.com (2603:10a6:20b:283::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Wed, 6 Jul 2022 15:38:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Wed, 6 Jul 2022 15:38:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a90343f3-fd41-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V7kdJ+a5X3NrMmJggnq6MHOGGmLrkuQg2jpxNN4y4kS//NoqoqSm1YyURKLxYUqVSE83Hk7pIT2Dhzhib/+yxift/bhPZ/u9Ybw9Qe9Stx7XTrTOF0TeCxjPCdHEh6z2rH2xrTNo3AyybdBxzK/uckLCBAyvi1+L3hKx+9f41enbSnAwiHx6FaguGNWTaoSmrkSoeMzqFqlyhjo5MEATUa5N68pI1dlUGgjEmQAQYn4bCdf/iVATc47klS1UulkPdWW6Gj/PKfiEswx4Gfu3nZ4FakQqmbGq7/EBs09zj6K1qIkn7lwG83nZ+H8BoUR5hZR45yjgcANv7dhCt1UQvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f3IdF4c0WU+gLVVFCtReB28pUQ+BMTUs0ANzgGR34Js=; b=nyAbAY514Wym3ZTCLBmno4QOoTUnGZAOtjLCTcGwZPlYRpjxZcH7C0jI8IaNzrwNaiKK1GOOShaw4U4aa+gRVzIpii3mWm7NWu5S7XuuOsEey/4PrVJl4XGny9tqSK2rvZS+gIr63BDPosHHXbxIGXU/DhBkZZQXCiz97XhqJkVKQlCVw6JbZ5WjIM3f+dC3ongTXErTxgkmxXUrxE2AJ2hlziMqVROM1ZSbu6U3jrjTn31gLp0eRwuSnutVbP9Dk/lcyzWDDByyJq3V1R2VKm/Gl8YftpNAyVcoGRoitia87C1oN2w9lEvkTVvJ/eoHd5RSC8ScdLLOryeqgwCjcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f3IdF4c0WU+gLVVFCtReB28pUQ+BMTUs0ANzgGR34Js=; b=0sap8EqWkvqhAHpRRL7ixgQDZm3LkXT4KxyogtyDUjofL7ZangSOXTDpaaTD3btWKBT93KUaJbICUjsbJ3RWw+W9aJwdEF2dZnKhL0b4F11nRgBszmOrIzFt3oQ+X0gNLgiqwjjExASSVNn3VcD2FFeVO6ogfGOedOILt5I1MlrYcNto/OD0evjWJu63j0oU47+hCKNEIOmmvMVCINJkgV4z7byN1zmUDsMoVUz2zpj3O1euFF+uLDRpa9+QG7T2RoSEKdLqNUOHSvEDCSDkFbeNh/TfeJRJeKAq4TSoB7THlppLQZCM6Zf4iIMvlo0ROjYkRb1ZWRusHVxp8rJ6ZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <775bccd8-9fb4-35b5-cf75-75f3875201d0@suse.com> Date: Wed, 6 Jul 2022 17:38:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Content-Language: en-US To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0303.eurprd06.prod.outlook.com (2603:10a6:20b:45b::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1d16cfa-30e0-4984-7a49-08da5f658bfb X-MS-TrafficTypeDiagnostic: AM9PR04MB7665:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0gxk+2Wzbjg0wy9wzGs/yP+K3U6pM9BCGWFt2DwTyzOaMkdVnYZhUBYIiVRn9rLewi/nxez1pMKsBtqOp3XGYg/ubrrAIfoNynE7Ci704MJ7S/d8QtwVuHb+3mSA7FHdpwWfZYq5wBWBK39JDmOaPE8N06UyruQUt/bddJDia0YuWIm66M5/b1f2OmCG+bAXZICT80nk/5gAszYXEjtY16lGY91QKNumhM1O6TeriAkaeKCJvs7yIpC2MlNAOGmkXqQLbYsRuQvDy9f8BOwMzNYV4oZ8sf4IJweTixV2wczPj7PB9UIf5GlXd7C5HRlr4AFJG/MK0FhWQoK2VIUIqQfu4YSn+oN3xhLoD+B0IvKsu65cS+duHgKPGgbTsFzGO/9a3U2/ulrW2ONv9fKe13P5AMGGEsJ7FpkH8GY1eXH7ZV7uVXuDGm+ynFWNvVNIPXu1SxbN1OxgghfEJ7iEqAh3c1a0eBU28KeBmNa5Qn7i0d5hkXLUEDGvoWJNNKXNZmWC1YGdBL6dPmEQw5d+93qoPAOyWemzRw4BVqyYrlOFMJtjLOO1EwkgwOnYGzSO0qXwm/YB1ueMDoAUMWRZQnia3zBhfpCoQ/7AMjPGy9s15F3xTORDR+Pz1QtUZClTMWBocBTbUeroyZwC9+wdTYqpQHnXpabBIrwOLlVO6ybkeNM4XiOHc8bqwRjI2ptxkwFtLoQWuwy4v2ZabJBI3YlInZsmnDwTh9OcBFBdA5D4Xctar0TxBUdNAW6AuXLGgcnVmJk07H+2vxIKc3tdUplaA4QfdIw+4IAfyDREAVTl3kruGE/UkUcYs5hTC7nhFayQsGE1uzyNX0wL9tSm6ubxgfArpTA9cQZq8Z3MAE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(39860400002)(396003)(346002)(478600001)(6512007)(6486002)(66476007)(316002)(66946007)(86362001)(8936002)(31696002)(36756003)(8676002)(26005)(6916009)(54906003)(5660300002)(66556008)(4744005)(53546011)(4326008)(6506007)(31686004)(2616005)(2906002)(186003)(38100700002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTBvZGpOazJYRDdRUTZnQ1dlQjkxWnB4c3pDcEd1clduM1JVTWlZemMyclNQ?= =?utf-8?B?U3RPZWQ4VDF4b05ITUw4d2o4TDYzV2N3SXgzSStSZllWTzE5V2lrd0dGQ1dE?= =?utf-8?B?bjhZR29KT0hqYW5oY05mTTRBSVBteUwyMmFLTmtxczNDbDV6b0lGV0wwRU1H?= =?utf-8?B?azZXQ3Z3RXdUV1hkUy9MY3M2bkp5ZUdpK1hqUlhxMk95aFh6OEtIMTB5Q3lE?= =?utf-8?B?c0tRV0toRXNySUpxZjdBMXl1ZVVTWHpSMzdIMDNMZitucUx6Zm00cTQrYkwy?= =?utf-8?B?eE5ESnRTSGl5YzFnY3hzcURxVFkybjRrc2dPVERrTVI4Q1F4d3UxRGp6NTVn?= =?utf-8?B?eHFpRXVtcnFWWjJOQmlWNXlqWWxiTVlrUWR2eG1VTnF0cSs4M3c5Y2NqSUtB?= =?utf-8?B?cFBsVGpubGRiMEpvVzNxcC8zZWRoTTB2bnNGdHI4VVhBSDJ0b3pXT3NlRTE5?= =?utf-8?B?a0MvRzZldzdsV05nTCtmenlLRHdxOTdXckt4QS9BeEMvV3BMZWhBZGZpRjE4?= =?utf-8?B?MXg5VlRLUWg5UGdSeEhnZ3cydTV4a3FCSnJQQkN5ajUyNXIvQXJzNGlKWnI3?= =?utf-8?B?RHBuazV4VCtiQ0gvakRjY1BqQU12RDVuYmRCTFI1MytOVDYvc0Rjam1NS2t3?= =?utf-8?B?YVlyRUFpQmxlc3ZmeDRPZklCeG5WaVY5S0pBVnFVcS92VDc0SStKVkVzbCs2?= =?utf-8?B?Ym44NVRUS0NkY2lGeHMrdktpUDR5V3VnMjNxdFFyNzZCTzdkRVh1eW1xSnlT?= =?utf-8?B?WEV6aUEzNlRXTUVWUjY0QU1LQUJmNjNXWFB2VHNlWlN3TktYUU9Kai9qdUVw?= =?utf-8?B?MnZ5alJKSllNVmJvbzBpQzNqd0szQkN1MlMwL3MrL1lWK1RYak5CUUJXQlZk?= =?utf-8?B?SExLODBKSHp5S2YvTFFwcjZMOVk2UldKQ2dkVFoxU2ZQcDVqWW1XcUFVL1o5?= =?utf-8?B?bjZQUzhUVTByV0JhZW9BYlFIdFRzM3lhd0ZpL05RTzY4M2QzS3E0MnZyQ0Nv?= =?utf-8?B?S0tkUWQwRjBEdWpPSEtXZ1BrR2N6ZUF0RHJMWEZRWVpFY1VYcFc1M1BiVzVu?= =?utf-8?B?WEdUMG5ZcEptZGZISnByZlkvRTMzWjZuNGdvbXd5RXBEa1JtTkJqRlpWU2hX?= =?utf-8?B?dklGUzBlekxFY0h1T1p1OHZCaWVkSlBaMWNHUHZXYWtZOWdCOWRZbDV4ZXRX?= =?utf-8?B?TWZzS2xRSWpaaTJXMDJqa2RGTnNnditLRlFpUTcwc04vVDkxeFVOblR4ajZi?= =?utf-8?B?U0RKVFdOUDFrYkpMT1YwNi9JNytvRmxoNmFxM3RsK05tVHNjTysvYUZ6aHgy?= =?utf-8?B?MlFpQi9LTnlFd3FQMmw3ZUwrNnh3WjEvbk5DK1Rhc1lJNVE4ZVA0WGkyNkJF?= =?utf-8?B?MUNOalRwTUJhcHVhYmRkcEdkZnFybWdxVnJyRVZGWUZ4QlZrUmJNMTRybzJM?= =?utf-8?B?cyt2SU1MckpwRWJjN1pWcllHWDhldXJKa3hlb25jQVhyL0xia1NyRlNrRDBQ?= =?utf-8?B?elNQcWFWRGxocDhocGljWTNad0l2ZGhCNFhObSt0NTVOUkdRRTl1SE1PMDA3?= =?utf-8?B?QVg3UlNDVDhuZy9lUFBDTDlaQnk1L1FvUGFjaElxSDYvcVU3YkVKVzA5OHNw?= =?utf-8?B?RnFHMFdaODlIeXRBbFlVU3dkbjZIa094RlE1NnJmWWhBL0t2RzFyQzZnbW41?= =?utf-8?B?aCtldStiUnM0RGI1UVhYancwL1pCWnlQT25heVJ1YjdpNWpyckU0MGFkd2Ja?= =?utf-8?B?T0lYYzdFb2NqMmhmZkpXSCtIMm9CalB3REFBSEMrWStRMlVTT3ZJd0MrRTEw?= =?utf-8?B?aTJ6N2JFZzZzK3JLMW1ZR2JwUTVpNnh3b0tZNHdKaG9kaUJaNEhzTWtOd2cy?= =?utf-8?B?a3YvYzg3TGRKc1k4eEtUenZybGhrVmVCUmtwTThRNytpeTJoczhlNHB5VWFH?= =?utf-8?B?dW84cFNyQk1JYmJXREUrcXk0K3lsaUFBa2w1b2NlZmNpNjlVa2ZWdWpoRjZ3?= =?utf-8?B?b2hVZE5ZU1NQQnYzWjJOQlRDdjlTWERRRTE5VjY0UjcvdEZUaThESEwrOHk1?= =?utf-8?B?dXNydlhXODQxdVc5NVNwdFdIM205ZlVTcFZrNzgwektqQnVGQ0ZUa0tLL3Ja?= =?utf-8?Q?eQAzwSGMOaoheUFfl4QzMQ7wQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1d16cfa-30e0-4984-7a49-08da5f658bfb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2022 15:38:17.2914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vK0Aqd9yZJbttThOL6WRVw/K/CjjVso9t8D0bbIVVxsJ8VBGY9BjHl7Klq687Kvd3IC4GVrI+G3Y/33eAVBJoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7665 On 06.07.2022 17:17, Anthony PERARD wrote: > On Thu, Jun 09, 2022 at 05:52:45PM +0200, Jan Beulich wrote: >> --- a/xen/Makefile >> +++ b/xen/Makefile >> @@ -465,6 +465,22 @@ endif >> .PHONY: _build >> _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) >> >> +# Strip >> +# >> +# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped before it >> +# is installed. If INSTALL_EFI_STRIP is '1', then the default option >> +# --strip-debug will be used. Otherwise, INSTALL_EFI_STRIP value will be used >> +# as the option(s) to the strip command. > > It would be useful to also document INSTALL_EFI_STRIP in ./INSTALL or in > ./docs/misc/efi.pandoc (efi.pandoc is where EFI_VENDOR is documented for > example, so probably a better place for the doc of the new option). Well, imo it's far preferable to install _something_ that works (even if it consumes more space) than not installing anything. I'll look into addressing the other two comments you gave. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 06 17:01:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 17:01:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362446.592464 (Exim 4.92) (envelope-from ) id 1o98P7-0002DZ-6K; Wed, 06 Jul 2022 17:01:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362446.592464; Wed, 06 Jul 2022 17:01:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o98P7-0002DS-3c; Wed, 06 Jul 2022 17:01:33 +0000 Received: by outflank-mailman (input) for mailman id 362446; Wed, 06 Jul 2022 17:01:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o98P4-0002DM-I3 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 17:01:31 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4663f110-fd4d-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 19:01:28 +0200 (CEST) Received: from zn.tnic (p200300ea970ff625329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f625:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 372DB1EC0453; Wed, 6 Jul 2022 19:01:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4663f110-fd4d-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657126883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YuG9Q+oxYEiway3JJ+jBLFvim0S1LMN5Amv/Z4wmYOg=; b=EOVKH88UnwbLUGmgyTFs6FasfHgJZWGtuo5qd9U2XujbRMoomm+jklABu0L5mmqRDWIYKS 6sX8bZuCKS/Svvc1Ue3/+A9RQTeqkeFyDI7QVgA9nZl1k5a6QdUys/lsRGfvh+BIBPHXHN AyMRh/70e+IFGqqPfhAFHm5sislbIFo= Date: Wed, 6 Jul 2022 19:01:19 +0200 From: Borislav Petkov To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Message-ID: References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Wed, Jul 06, 2022 at 08:17:41AM +0200, Jan Beulich wrote: > Sure, but that alone won't help. Well, the MTRR code looks at X86_FEATURE_MTRR. If Xen doesn't expose the MTRRs, then that bit should be clear in the CPUID the guest sees. So in that case, you could test X86_FEATURE_XENPV at the end of mtrr_bp_init() and not disable PAT if running as a PV guest. Would that work? > There's a beneficial side effect of running through pat_disable(): > That way pat_init() will bail right away. Without that I'd need to > further special case things there (as under Xen/PV PAT must not be > written, only read) We have wrmsr_safe for that. > Any decent hypervisor will allow overriding CPUID, so in principle > I'd expect any to permit disabling MTRR to leave a guest to use > the (more modern and less cumbersome) PAT alone. So I'm being told that it would be generally beneficial for all kinds of virtualization solutions to be able to support PAT only, without MTRRs so it would be interesting to see how ugly it would become to decouple PAT from MTRRs in Linux... Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Wed Jul 06 17:50:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 17:50:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362453.592476 (Exim 4.92) (envelope-from ) id 1o99AU-0000Fw-RY; Wed, 06 Jul 2022 17:50:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362453.592476; Wed, 06 Jul 2022 17:50:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99AU-0000Fp-OC; Wed, 06 Jul 2022 17:50:30 +0000 Received: by outflank-mailman (input) for mailman id 362453; Wed, 06 Jul 2022 17:50:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99AT-0000Eu-SV for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 17:50:29 +0000 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [2a00:1450:4864:20::330]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e9989e7-fd54-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 19:50:27 +0200 (CEST) Received: by mail-wm1-x330.google.com with SMTP id u12-20020a05600c210c00b003a02b16d2b8so9408455wml.2 for ; Wed, 06 Jul 2022 10:50:27 -0700 (PDT) Received: from uni.. (adsl-146.37.6.170.tellas.gr. [37.6.170.146]) by smtp.googlemail.com with ESMTPSA id o4-20020a05600c378400b003a2b708c26dsm5807321wmr.40.2022.07.06.10.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 10:50:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e9989e7-fd54-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XKQ9VmXy5rX90RpfhKkPwWRfbVofooIOTElwk25AdsI=; b=kSPYsiPgnM6saXW2671Fwpi9pp5ktEyXzH5skLXNcJ6VFGQPqdbhaCBVf+rrmQMGuY TIR8zTZyMMX4xFlNDRkenjK0MSC/RmLaa6Gmm5PqJrmVfFO14PNQk7DgEGPReSJ0J8Ns 0Q8hMIs1l/oftpymTe5AaLE1VmjxSIlib0tI1tbPODb5Dlv6QeqHUljrwwQiDycwsHEo AxmOSQ7L3dIasZ24UYaKbv5LXgHhK/8BpugN1Y66CJwym8ler8ZfZAVw11oE5rI692RX Uw1IHFf7ZIzq8DicrvO5UJORKIkrL2h4wNO3OQCqH2jzNUnxSFhIcfsmnZbApimSK0JB sSuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XKQ9VmXy5rX90RpfhKkPwWRfbVofooIOTElwk25AdsI=; b=Aix9Lp8M6nZfgxU6Eoyg6kaEUcj5ZnSXNdIkgalDju9qrCgiJiAv11V6TTMuQnKY3V ctVOcP9qv0IIs7LPHfIcX0Sw01kxYUua7O3vB2EvNbkfXSdEIFgO00ucGmsHw5hFn0Pf m9TlF/RMErCRY2gPKwMRJ05gjJg4yFjbBwvwZlaJ2ygBj+y8AUUi6kwEdovyijP7hppp Xd8cIwlQAeEHEkxJVfxxHK2iFBq2RO3oYoHlBbj4c8Zl4t73EuRqHFuRqUcjyd6YnhIK DtDSkL4eapleyIM/x0rWHdOFwMrDs5l68hNV6W0b+ItkbGwgtRNfUOpTg6pGHICg6cN+ fyvA== X-Gm-Message-State: AJIora/eNk9s/VMx5y5tEBGeV5Cp6UA/f4uualqkxP2Fg83sLd5OQdji EExI/D2BoD4BJCM1SG1RKkOEupGo+Oo= X-Google-Smtp-Source: AGRyM1vqM7YG2Q1DT2DYxOKNL1W8BY3VVgJz4eOom1TeMgLeIuOJWI2i6N0KrWSphp4EEk5VCLw/Lg== X-Received: by 2002:a7b:c8d8:0:b0:3a0:42ca:d03 with SMTP id f24-20020a7bc8d8000000b003a042ca0d03mr45900838wml.167.1657129826772; Wed, 06 Jul 2022 10:50:26 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] xen/char: pv_console: Fix MISRA C 2012 Rule 2.1 violation Date: Wed, 6 Jul 2022 20:50:13 +0300 Message-Id: <20220706175013.675258-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove the definition of the function pv_console_evtchn(), when CONFIG_XEN_GUEST is not set, because the function is not used. Signed-off-by: Xenia Ragiadakou --- xen/include/xen/pv_console.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/xen/include/xen/pv_console.h b/xen/include/xen/pv_console.h index 4745f46f2d..55b20323fb 100644 --- a/xen/include/xen/pv_console.h +++ b/xen/include/xen/pv_console.h @@ -19,11 +19,6 @@ static inline void pv_console_set_rx_handler(serial_rx_fn fn) { } static inline void pv_console_init_postirq(void) { } static inline void pv_console_puts(const char *buf, size_t nr) { } static inline size_t pv_console_rx(struct cpu_user_regs *regs) { return 0; } -evtchn_port_t pv_console_evtchn(void) -{ - ASSERT_UNREACHABLE(); - return 0; -} #endif /* !CONFIG_XEN_GUEST */ #endif /* __XEN_PV_CONSOLE_H__ */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 18:25:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 18:25:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362464.592486 (Exim 4.92) (envelope-from ) id 1o99hk-0004wC-Ez; Wed, 06 Jul 2022 18:24:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362464.592486; Wed, 06 Jul 2022 18:24:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99hk-0004w5-CA; Wed, 06 Jul 2022 18:24:52 +0000 Received: by outflank-mailman (input) for mailman id 362464; Wed, 06 Jul 2022 18:24:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99hj-0004vv-91; Wed, 06 Jul 2022 18:24:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99hj-0007Yp-7B; Wed, 06 Jul 2022 18:24:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o99hi-0001g5-UP; Wed, 06 Jul 2022 18:24:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o99hi-0002Ru-Tz; Wed, 06 Jul 2022 18:24:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d9agzoHehICM11m1MmEmI58haghciWs8jAjhaDTbsGg=; b=cyYKizZevL2xNa+1iFtU4ngVTC s8wNfZEAIyBMJJrSaw4v8yEyIxf21xyxU3PVOW+SFNbpHi6ls9MuyxZX3KqnOr58hbLovgcUJp9GO +Ta0OA6z+WyuXV7jbqJOwUgDZPSQ9qldmTEdX3Gbagao68PCckjhnDdWfcViGc3v86tg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171535: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Wed, 06 Jul 2022 18:24:50 +0000 flight 171535 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171535/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171486 2022-07-04 13:00:25 Z 2 days Failing since 171501 2022-07-05 12:03:08 Z 1 days 6 attempts Testing same since 171535 2022-07-06 15:02:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Charles Arnold Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4df2e99d73..46cbd76faf 46cbd76faf737e9fe2d57aaf335a0203f66ba21c -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jul 06 19:01:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 19:01:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362472.592498 (Exim 4.92) (envelope-from ) id 1o9AH2-0001oI-89; Wed, 06 Jul 2022 19:01:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362472.592498; Wed, 06 Jul 2022 19:01:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9AH2-0001oB-54; Wed, 06 Jul 2022 19:01:20 +0000 Received: by outflank-mailman (input) for mailman id 362472; Wed, 06 Jul 2022 19:01:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9AH0-0001o1-Pl; Wed, 06 Jul 2022 19:01:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9AH0-0008CY-MD; Wed, 06 Jul 2022 19:01:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9AH0-0002bS-BQ; Wed, 06 Jul 2022 19:01:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9AH0-0007V1-B1; Wed, 06 Jul 2022 19:01:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yRTbb4cAwq5O+I53n+igL80Nd0wvMFeP/1FTySBn420=; b=5jTX7tieF+O/tn4Homs2WDUIVF OsH5E9LAsE/4ztgEFQRsfw/FKnUDHRNY3lVZXQc99enbQHE8/GCJJUx4SXLlgWnBPFz/ChVnNvaZp xvcrf1PzliIJAO/w5nyhp/YtlFA8z7r3CBRLh+DZo9uFu7YS1kpRBmZ78q2qwty0U3K8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171525: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=180c2f24d5e8eada41e012a3899d29bb695aae06 X-Osstest-Versions-That: qemuu=d82423a697790aac46680068ff64375cd12c6c94 From: osstest service owner Date: Wed, 06 Jul 2022 19:01:18 +0000 flight 171525 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171525/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171512 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171512 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171512 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171512 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171512 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171512 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171512 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171512 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 180c2f24d5e8eada41e012a3899d29bb695aae06 baseline version: qemuu d82423a697790aac46680068ff64375cd12c6c94 Last test of basis 171512 2022-07-05 22:07:21 Z 0 days Testing same since 171525 2022-07-06 07:42:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Chuck Zmudzinski Ding Hui Haochen Tong Jason Wang Jing Zhang Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d82423a697..180c2f24d5 180c2f24d5e8eada41e012a3899d29bb695aae06 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 06 19:13:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 19:13:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362481.592508 (Exim 4.92) (envelope-from ) id 1o9ASx-0003vH-Ha; Wed, 06 Jul 2022 19:13:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362481.592508; Wed, 06 Jul 2022 19:13:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ASx-0003vA-Eo; Wed, 06 Jul 2022 19:13:39 +0000 Received: by outflank-mailman (input) for mailman id 362481; Wed, 06 Jul 2022 19:13:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ASw-0003v4-9k for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 19:13:38 +0000 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [2607:f8b0:4864:20::829]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bc2c5075-fd5f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 21:13:37 +0200 (CEST) Received: by mail-qt1-x829.google.com with SMTP id ck6so19629005qtb.7 for ; Wed, 06 Jul 2022 12:13:37 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:84b5:e0c:e62c:c854]) by smtp.gmail.com with ESMTPSA id j4-20020a05620a410400b006a6278a2b31sm20538571qko.75.2022.07.06.12.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Jul 2022 12:13:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc2c5075-fd5f-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ugFZE0GvGQ65P2c1jnc3TTgZpxOaUaUfnChcx3q0VQU=; b=i+tfkKf+IBotv0HfkNxUVCaePW8LFiujYppTW0HQgiFtWrGNtZeyfB/wQ2xqUdLfEd K2F3TmHB8mjLjXlc2jFnMv54MT4JM22EQXz/tl0zlULBuckTVn5zNy2MRaYqbOqvPRPP CQ/gN3iLSmk/0Q1PBXjMCSsuxIBjcDOjIp6HdmetSSMQvhTl59fkiCiAb4NLBuVHfVGe szyruMjBIRtG5lvytbUnkiA/TS/3idm3CkHoXIJWgN+yff9/sRJAiY1A6gB4DNIuYX7W 91Q20xTry7Hu+jadJlTDewZwzGjw83mCzPoCRTgSZcRgQZaNmA2BJk2+622KGaxqzKSO eyaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ugFZE0GvGQ65P2c1jnc3TTgZpxOaUaUfnChcx3q0VQU=; b=uxyHifu9hF9DeD+Ebh19Qu++jA6ctk+WJdV7o6rzjoPAGLay2WLe+IPM/1PJd+aZgo Ja+cWbSwQWzKmtWEiHyeUsDcp04NdFQw1NEVBZSQf3W583AhijA9cHwfxo8bj7y70u7j /TpS9se33YXEN1FvQMKkebwaiHbvcOW1eFaJiOEgVlYLvRXpV3tjnqDWsTEdNBArPjZ0 456sH1wthDgKYmNYWZmolZVS1pM8hDYWXzIsADlT7N4mPzc3uYYVBgrrbgaW1rbJK8RA kVDHUGZs/ufilfnM4vyInnANwsoMAM1PEcgChXk1GsK2zppBotNcLIYryvGfwPPbALXU Rabg== X-Gm-Message-State: AJIora+jUOSEgywjM7rH0xZfQqLcOMcqa73Ph+UzrGuoW2NZih+FKaOK 4Air3y2jzPTgAewo3d6P+VY= X-Google-Smtp-Source: AGRyM1uJbcnhWdgw/ATCYMd1dtCv9jN/dKChgAFpHZqbNjDMrHlOWycFAkL6sVLAKqb2sjs7svV85g== X-Received: by 2002:a05:6214:c41:b0:45f:380d:2f6a with SMTP id r1-20020a0562140c4100b0045f380d2f6amr36968514qvj.54.1657134815677; Wed, 06 Jul 2022 12:13:35 -0700 (PDT) From: Jason Andryuk To: dpsmith@apertussolutions.com Cc: anthony.perard@citrix.com, christopher.clark@starlab.io, dgdegra@tycho.nsa.gov, jandryuk@gmail.com, scott.davis@starlab.io, wl@xen.org, xen-devel@lists.xenproject.org Subject: [RFC PATCH] flask: Remove magic SID setting Date: Wed, 6 Jul 2022 15:13:25 -0400 Message-Id: <20220706191325.440538-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> References: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit flask_domain_alloc_security and flask_domain_create has special code to magically label dom0 as dom0_t. This can all be streamlined by making create_dom0 set ssidref before creating dom0. create_domU is also extended to create domains with domU_t. xsm_ssidref_domU and xsm_ssidref_dom0 are introduced to abstract away the details. Signed-off-by: Jason Andryuk --- Untested on ARM. Minimally tested on x86. Needs your Flask permission changes for xenboot_t to create dom0_t and domU_t. This is what I was thinking would be a better way to handle SID assignment. Regards, Jason --- xen/arch/arm/domain_build.c | 2 ++ xen/arch/x86/setup.c | 1 + xen/include/xsm/dummy.h | 10 ++++++++++ xen/include/xsm/xsm.h | 12 ++++++++++++ xen/xsm/dummy.c | 2 ++ xen/xsm/flask/hooks.c | 31 +++++++++++++++++-------------- 6 files changed, 44 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..a7e88944c2 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3281,6 +3281,7 @@ void __init create_domUs(void) .max_grant_frames = -1, .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), + .ssidref = xsm_ssidref_domU(), }; unsigned int flags = 0U; @@ -3438,6 +3439,7 @@ void __init create_dom0(void) .max_grant_frames = gnttab_dom0_frames(), .max_maptrack_frames = -1, .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), + .ssidref = xsm_ssidref_dom0(), }; /* The vGIC for DOM0 is exactly emulating the hardware GIC */ diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8de..5a6086cfe3 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -771,6 +771,7 @@ static struct domain *__init create_dom0(const module_t *image, .arch = { .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, + .ssidref = xsm_ssidref_dom0(), }; struct domain *d; char *cmdline; diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 77f27e7163..12fbc224d0 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -124,6 +124,16 @@ static XSM_INLINE void cf_check xsm_security_domaininfo( return; } +static XSM_INLINE int cf_check xsm_ssidref_dom0(XSM_DEFAULT_VOID) +{ + return 0; +} + +static XSM_INLINE int cf_check xsm_ssidref_domU(XSM_DEFAULT_VOID) +{ + return 0; +} + static XSM_INLINE int cf_check xsm_domain_create( XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref) { diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 8dad03fd3d..a6a4ffe05a 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -55,6 +55,8 @@ struct xsm_ops { int (*set_system_active)(void); void (*security_domaininfo)(struct domain *d, struct xen_domctl_getdomaininfo *info); + int (*ssidref_dom0)(void); + int (*ssidref_domU)(void); int (*domain_create)(struct domain *d, uint32_t ssidref); int (*getdomaininfo)(struct domain *d); int (*domctl_scheduler_op)(struct domain *d, int op); @@ -220,6 +222,16 @@ static inline void xsm_security_domaininfo( alternative_vcall(xsm_ops.security_domaininfo, d, info); } +static inline int xsm_ssidref_dom0(void) +{ + return alternative_call(xsm_ops.ssidref_dom0); +} + +static inline int xsm_ssidref_domU(void) +{ + return alternative_call(xsm_ops.ssidref_domU); +} + static inline int xsm_domain_create( xsm_default_t def, struct domain *d, uint32_t ssidref) { diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c index e6ffa948f7..d46cfef0ec 100644 --- a/xen/xsm/dummy.c +++ b/xen/xsm/dummy.c @@ -16,6 +16,8 @@ static const struct xsm_ops __initconst_cf_clobber dummy_ops = { .set_system_active = xsm_set_system_active, .security_domaininfo = xsm_security_domaininfo, + .ssidref_dom0 = xsm_ssidref_dom0, + .ssidref_domU = xsm_ssidref_domU, .domain_create = xsm_domain_create, .getdomaininfo = xsm_getdomaininfo, .domctl_scheduler_op = xsm_domctl_scheduler_op, diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c index 8c9cd0f297..d6f786ea84 100644 --- a/xen/xsm/flask/hooks.c +++ b/xen/xsm/flask/hooks.c @@ -544,26 +544,27 @@ static void cf_check flask_security_domaininfo( info->ssidref = domain_sid(d); } +static int cf_check flask_ssidref_dom0(void) +{ + return SECINITSID_DOM0; +} + +static int cf_check flask_ssidref_domU(void) +{ + return SECINITSID_DOMU; +} + static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref) { int rc; struct domain_security_struct *dsec = d->ssid; - static int dom0_created = 0; - if ( is_idle_domain(current->domain) && !dom0_created ) - { - dsec->sid = SECINITSID_DOM0; - dom0_created = 1; - } - else - { - rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, - DOMAIN__CREATE, NULL); - if ( rc ) - return rc; + rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, + DOMAIN__CREATE, NULL); + if ( rc ) + return rc; - dsec->sid = ssidref; - } + dsec->sid = ssidref; dsec->self_sid = dsec->sid; rc = security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN, @@ -1805,6 +1806,8 @@ static int cf_check flask_argo_send( static const struct xsm_ops __initconst_cf_clobber flask_ops = { .set_system_active = flask_set_system_active, .security_domaininfo = flask_security_domaininfo, + .ssidref_dom0 = flask_ssidref_dom0, + .ssidref_domU = flask_ssidref_domU, .domain_create = flask_domain_create, .getdomaininfo = flask_getdomaininfo, .domctl_scheduler_op = flask_domctl_scheduler_op, -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 19:23:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 19:23:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362487.592520 (Exim 4.92) (envelope-from ) id 1o9Abv-0005ig-FM; Wed, 06 Jul 2022 19:22:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362487.592520; Wed, 06 Jul 2022 19:22:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Abv-0005iZ-AX; Wed, 06 Jul 2022 19:22:55 +0000 Received: by outflank-mailman (input) for mailman id 362487; Wed, 06 Jul 2022 19:22:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Abu-0005iT-3a for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 19:22:54 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 073fab99-fd61-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 21:22:52 +0200 (CEST) Received: by mail-vs1-xe2d.google.com with SMTP id d187so16051659vsd.10 for ; Wed, 06 Jul 2022 12:22:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 073fab99-fd61-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DQbLb5A6nnECqz9CwrVAxcb7ekECVDs2SKH8GTMd+X0=; b=ouVah9hX3Lr5fIsfQWXpJTmGvxs+Xxce5uAP8wEFcaSKzeHgsyO8GVZwGfNZNzACfC 4c6OyxGeN4W8y5v4S/j9wWuA8Vyyo+0deEZ5R3HkPHgu5x2rqe2XD1vusJ+GyYjSiwPq xxGEOUD+8MMPDrgB3hT3RvSs5DqWYIovRNxOaQmt93UmpHl8WaUXTOVDwwcf/y3Y/UKC Ml7YGzWba3HrIIUqVOK26xx60cJUuu6fP/e+jtEhotIsoCMnT1DCX55RLgkLymuuU73r zYJisY8JAy7BZgmXYZNlBTP5R+QeWc8Gie8rXiqJsn8M4zrdDCwhhuW5qycR+pXemQp8 auOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DQbLb5A6nnECqz9CwrVAxcb7ekECVDs2SKH8GTMd+X0=; b=yTAi3lptSEMJB1QGVX2ckCTCJz4z1zkDv0+x+ziPisDWyslyJDa5Mkpxn64FBJnZNZ zGdLRStFqSdyPIbkNC2mq4WsaKJkYVPBQeJPHSaeuys58AaNnLdfLHhDTFKKnXAI2vyr yLCTm9NLLsoT+rWrPzv8ykmWzHNRSf/TSEPq92mcRzHuAZwcNOitlEqrDti8jCgzQJzy Z9ndkVDTRxXATapvn6WxiEstnuQdAq+cm6e0U2LOoFWuk6lHPLMmsdksDETgtKQ052tG WSAsIKgSIVYiFgifkdfZ52FCGRhwi/z3FqE6OfXaIzIW5Rm8SfOLZgHExwSkhhyVXfS1 oz1g== X-Gm-Message-State: AJIora+31npwgxiWklj9ZBbhn6zJE0yGI77J/acmuIn/SCRa/IpuhA6c 6cHJ8ZINSXyKercgLFuLNBUAsBeuJoNnTpSe2vU= X-Google-Smtp-Source: AGRyM1tBSGBBnEMXlVbvqD3f5kUUGG/0JjsizctdAJQURdwvkvXgqR3ZWBOsBQHT454yivgO5Zvi/7j3pNKckfH3zxM= X-Received: by 2002:a67:e1cc:0:b0:357:1ea6:3d6f with SMTP id p12-20020a67e1cc000000b003571ea63d6fmr1629469vsl.0.1657135370848; Wed, 06 Jul 2022 12:22:50 -0700 (PDT) MIME-Version: 1.0 References: <20220324140139.5899-1-jgross@suse.com> <20220324140139.5899-3-jgross@suse.com> <5d7de637-3f7a-3e71-5dcf-cbeb1fa08b7b@suse.com> In-Reply-To: <5d7de637-3f7a-3e71-5dcf-cbeb1fa08b7b@suse.com> From: Christopher Clark Date: Wed, 6 Jul 2022 12:22:40 -0700 Message-ID: Subject: Re: [PATCH v6 2/9] xen: harmonize return types of hypercall handlers To: Juergen Gross Cc: xen-devel , Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Tue, Jun 28, 2022 at 11:24 PM Juergen Gross wrote: > > On 24.03.22 15:01, Juergen Gross wrote: > > Today most hypercall handlers have a return type of long, while the > > compat ones return an int. There are a few exceptions from that rule, > > however. > > > > Get rid of the exceptions by letting compat handlers always return int > > and others always return long, with the exception of the Arm specific > > physdev_op handler. > > > > For the compat hvm case use eax instead of rax for the stored result as > > it should have been from the beginning. > > > > Additionally move some prototypes to include/asm-x86/hypercall.h > > as they are x86 specific. Move the compat_platform_op() prototype to > > the common header. > > > > Rename paging_domctl_continuation() to do_paging_domctl_cont() and add > > a matching define for the associated hypercall. > > > > Make do_callback_op() and compat_callback_op() more similar by adding > > the const attribute to compat_callback_op()'s 2nd parameter. > > > > Change the type of the cmd parameter for [do|compat]_kexec_op() to > > unsigned int, as this is more appropriate for the compat case. > > > > Signed-off-by: Juergen Gross > > Reviewed-by: Jan Beulich > > Could I please have some feedback regarding the kexec and argo changes? Thanks for the ping on this and apologies for the delay. The Argo-related changes in this patch look ok, and I have built and tested Argo functionality with this patch applied with PV 32 and 64 bit guests, using XTF -- with successful results for the patch -- but I am behind on exercising it on a system that can run HVM guests, sorry. Given the HVM-related change described in the description of the patch, I think that such a test is needed and I am working on getting a build and a system installed to get that done. Christopher > > > Juergen > > > --- > > V2: > > - rework platform_op compat handling (Jan Beulich) > > V3: > > - remove include of types.h (Jan Beulich) > > V4: > > - don't move do_physdev_op() (Julien Grall) > > - carve out non style compliant parameter replacements (Julien Grall) > > V6: > > - remove rebase artifact (Jan Beulich) > > --- > > xen/arch/x86/domctl.c | 4 ++-- > > xen/arch/x86/hvm/hypercall.c | 8 ++----- > > xen/arch/x86/hypercall.c | 2 +- > > xen/arch/x86/include/asm/hypercall.h | 31 ++++++++++++++-------------- > > xen/arch/x86/include/asm/paging.h | 3 --- > > xen/arch/x86/mm/paging.c | 3 ++- > > xen/arch/x86/pv/callback.c | 14 ++++++------- > > xen/arch/x86/pv/emul-priv-op.c | 2 +- > > xen/arch/x86/pv/hypercall.c | 5 +---- > > xen/arch/x86/pv/iret.c | 4 ++-- > > xen/arch/x86/pv/misc-hypercalls.c | 14 ++++++++----- > > xen/common/argo.c | 6 +++--- > > xen/common/kexec.c | 6 +++--- > > xen/include/xen/hypercall.h | 20 ++++++++---------- > > 14 files changed, 58 insertions(+), 64 deletions(-) > > > > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > > index e49f9e91b9..ea7d60ffb6 100644 > > --- a/xen/arch/x86/domctl.c > > +++ b/xen/arch/x86/domctl.c > > @@ -221,8 +221,8 @@ long arch_do_domctl( > > case XEN_DOMCTL_shadow_op: > > ret = paging_domctl(d, &domctl->u.shadow_op, u_domctl, 0); > > if ( ret == -ERESTART ) > > - return hypercall_create_continuation(__HYPERVISOR_arch_1, > > - "h", u_domctl); > > + return hypercall_create_continuation( > > + __HYPERVISOR_paging_domctl_cont, "h", u_domctl); > > copyback = true; > > break; > > > > diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c > > index 62b5349e7d..3a35543997 100644 > > --- a/xen/arch/x86/hvm/hypercall.c > > +++ b/xen/arch/x86/hvm/hypercall.c > > @@ -124,8 +124,6 @@ static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x, \ > > (hypercall_fn_t *) compat_ ## x } > > > > -#define do_arch_1 paging_domctl_continuation > > - > > static const struct { > > hypercall_fn_t *native, *compat; > > } hvm_hypercall_table[] = { > > @@ -158,11 +156,9 @@ static const struct { > > #ifdef CONFIG_HYPFS > > HYPERCALL(hypfs_op), > > #endif > > - HYPERCALL(arch_1) > > + HYPERCALL(paging_domctl_cont) > > }; > > > > -#undef do_arch_1 > > - > > #undef HYPERCALL > > #undef HVM_CALL > > #undef COMPAT_CALL > > @@ -300,7 +296,7 @@ int hvm_hypercall(struct cpu_user_regs *regs) > > #endif > > > > curr->hcall_compat = true; > > - regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi); > > + regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi); > > curr->hcall_compat = false; > > > > #ifndef NDEBUG > > diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c > > index 2370d31d3f..07e1a45ef5 100644 > > --- a/xen/arch/x86/hypercall.c > > +++ b/xen/arch/x86/hypercall.c > > @@ -75,7 +75,7 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] = > > ARGS(dm_op, 3), > > ARGS(hypfs_op, 5), > > ARGS(mca, 1), > > - ARGS(arch_1, 1), > > + ARGS(paging_domctl_cont, 1), > > }; > > > > #undef COMP > > diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h > > index d6daa7e4cb..49973820af 100644 > > --- a/xen/arch/x86/include/asm/hypercall.h > > +++ b/xen/arch/x86/include/asm/hypercall.h > > @@ -11,6 +11,8 @@ > > #include /* for do_mca */ > > #include > > > > +#define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1 > > + > > typedef unsigned long hypercall_fn_t( > > unsigned long, unsigned long, unsigned long, > > unsigned long, unsigned long); > > @@ -80,7 +82,7 @@ do_set_debugreg( > > int reg, > > unsigned long value); > > > > -extern unsigned long cf_check > > +extern long cf_check > > do_get_debugreg( > > int reg); > > > > @@ -118,7 +120,7 @@ do_mmuext_op( > > extern long cf_check do_callback_op( > > int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg); > > > > -extern unsigned long cf_check > > +extern long cf_check > > do_iret( > > void); > > > > @@ -133,17 +135,20 @@ do_set_segment_base( > > unsigned int which, > > unsigned long base); > > > > +long cf_check do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > + > > +long cf_check do_xenpmu_op(unsigned int op, > > + XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg); > > + > > +long cf_check do_paging_domctl_cont( > > + XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl); > > + > > #ifdef CONFIG_COMPAT > > > > #include > > #include > > #include > > > > -extern int cf_check > > -compat_physdev_op( > > - int cmd, > > - XEN_GUEST_HANDLE_PARAM(void) arg); > > - > > extern int > > compat_common_vcpu_op( > > int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); > > @@ -154,12 +159,8 @@ extern int cf_check compat_mmuext_op( > > XEN_GUEST_HANDLE_PARAM(uint) pdone, > > unsigned int foreigndom); > > > > -DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t); > > -extern int cf_check compat_platform_op( > > - XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op); > > - > > -extern long cf_check compat_callback_op( > > - int cmd, XEN_GUEST_HANDLE(void) arg); > > +extern int cf_check compat_callback_op( > > + int cmd, XEN_GUEST_HANDLE(const_void) arg); > > > > extern int cf_check compat_update_va_mapping( > > unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags); > > @@ -177,12 +178,12 @@ extern int cf_check compat_set_gdt( > > extern int cf_check compat_update_descriptor( > > uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi); > > > > -extern unsigned int cf_check compat_iret(void); > > +extern int cf_check compat_iret(void); > > > > extern int cf_check compat_nmi_op( > > unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > > > -extern long cf_check compat_set_callbacks( > > +extern int cf_check compat_set_callbacks( > > unsigned long event_selector, unsigned long event_address, > > unsigned long failsafe_selector, unsigned long failsafe_address); > > > > diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h > > index f0b4efc66e..54c440be65 100644 > > --- a/xen/arch/x86/include/asm/paging.h > > +++ b/xen/arch/x86/include/asm/paging.h > > @@ -234,9 +234,6 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl, > > bool_t resuming); > > > > -/* Helper hypercall for dealing with continuations. */ > > -long cf_check paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); > > - > > /* Call when destroying a vcpu/domain */ > > void paging_vcpu_teardown(struct vcpu *v); > > int paging_teardown(struct domain *d); > > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > > index 1f0b94ad21..a7e2707ecc 100644 > > --- a/xen/arch/x86/mm/paging.c > > +++ b/xen/arch/x86/mm/paging.c > > @@ -21,6 +21,7 @@ > > > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -759,7 +760,7 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > return shadow_domctl(d, sc, u_domctl); > > } > > > > -long cf_check paging_domctl_continuation( > > +long cf_check do_paging_domctl_cont( > > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > > { > > struct xen_domctl op; > > diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c > > index 55148c7f9e..1be9d3f731 100644 > > --- a/xen/arch/x86/pv/callback.c > > +++ b/xen/arch/x86/pv/callback.c > > @@ -207,9 +207,9 @@ long cf_check do_set_callbacks( > > #include > > #include > > > > -static long compat_register_guest_callback(struct compat_callback_register *reg) > > +static int compat_register_guest_callback(struct compat_callback_register *reg) > > { > > - long ret = 0; > > + int ret = 0; > > struct vcpu *curr = current; > > > > fixup_guest_code_selector(curr->domain, reg->address.cs); > > @@ -256,10 +256,10 @@ static long compat_register_guest_callback(struct compat_callback_register *reg) > > return ret; > > } > > > > -static long compat_unregister_guest_callback( > > +static int compat_unregister_guest_callback( > > struct compat_callback_unregister *unreg) > > { > > - long ret; > > + int ret; > > > > switch ( unreg->type ) > > { > > @@ -283,9 +283,9 @@ static long compat_unregister_guest_callback( > > return ret; > > } > > > > -long cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg) > > +int cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(const_void) arg) > > { > > - long ret; > > + int ret; > > > > switch ( cmd ) > > { > > @@ -321,7 +321,7 @@ long cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg) > > return ret; > > } > > > > -long cf_check compat_set_callbacks( > > +int cf_check compat_set_callbacks( > > unsigned long event_selector, unsigned long event_address, > > unsigned long failsafe_selector, unsigned long failsafe_address) > > { > > diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > > index 22b10dec2a..5da00e24e4 100644 > > --- a/xen/arch/x86/pv/emul-priv-op.c > > +++ b/xen/arch/x86/pv/emul-priv-op.c > > @@ -22,13 +22,13 @@ > > #include > > #include > > #include > > +#include > > #include > > > > #include > > #include > > #include > > #include > > -#include > > #include > > #include > > #include > > diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c > > index e8fbee7bbb..fe8dfe9e8f 100644 > > --- a/xen/arch/x86/pv/hypercall.c > > +++ b/xen/arch/x86/pv/hypercall.c > > @@ -47,8 +47,6 @@ typedef struct { > > #define COMPAT_CALL(x) HYPERCALL(x) > > #endif > > > > -#define do_arch_1 paging_domctl_continuation > > - > > static const pv_hypercall_table_t pv_hypercall_table[] = { > > COMPAT_CALL(set_trap_table), > > HYPERCALL(mmu_update), > > @@ -109,11 +107,10 @@ static const pv_hypercall_table_t pv_hypercall_table[] = { > > #endif > > HYPERCALL(mca), > > #ifndef CONFIG_PV_SHIM_EXCLUSIVE > > - HYPERCALL(arch_1), > > + HYPERCALL(paging_domctl_cont), > > #endif > > }; > > > > -#undef do_arch_1 > > #undef COMPAT_CALL > > #undef HYPERCALL > > > > diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c > > index dd2965d8f0..55eb6a63bd 100644 > > --- a/xen/arch/x86/pv/iret.c > > +++ b/xen/arch/x86/pv/iret.c > > @@ -48,7 +48,7 @@ static void async_exception_cleanup(struct vcpu *curr) > > curr->arch.async_exception_state(trap).old_mask; > > } > > > > -unsigned long cf_check do_iret(void) > > +long cf_check do_iret(void) > > { > > struct cpu_user_regs *regs = guest_cpu_user_regs(); > > struct iret_context iret_saved; > > @@ -105,7 +105,7 @@ unsigned long cf_check do_iret(void) > > } > > > > #ifdef CONFIG_PV32 > > -unsigned int cf_check compat_iret(void) > > +int cf_check compat_iret(void) > > { > > struct cpu_user_regs *regs = guest_cpu_user_regs(); > > struct vcpu *v = current; > > diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c > > index 5649aaab44..635f5a644a 100644 > > --- a/xen/arch/x86/pv/misc-hypercalls.c > > +++ b/xen/arch/x86/pv/misc-hypercalls.c > > @@ -28,12 +28,16 @@ long cf_check do_set_debugreg(int reg, unsigned long value) > > return set_debugreg(current, reg, value); > > } > > > > -unsigned long cf_check do_get_debugreg(int reg) > > +long cf_check do_get_debugreg(int reg) > > { > > - unsigned long val; > > - int res = x86emul_read_dr(reg, &val, NULL); > > - > > - return res == X86EMUL_OKAY ? val : -ENODEV; > > + /* Avoid implementation defined behavior casting unsigned long to long. */ > > + union { > > + unsigned long val; > > + long ret; > > + } u; > > + int res = x86emul_read_dr(reg, &u.val, NULL); > > + > > + return res == X86EMUL_OKAY ? u.ret : -ENODEV; > > } > > > > long cf_check do_fpu_taskswitch(int set) > > diff --git a/xen/common/argo.c b/xen/common/argo.c > > index 297f6d11f0..26a01c2188 100644 > > --- a/xen/common/argo.c > > +++ b/xen/common/argo.c > > @@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > } > > > > #ifdef CONFIG_COMPAT > > -long cf_check > > +int cf_check > > compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, > > unsigned long arg4) > > { > > struct domain *currd = current->domain; > > - long rc; > > + int rc; > > xen_argo_send_addr_t send_addr; > > xen_argo_iov_t iovs[XEN_ARGO_MAXIOV]; > > compat_argo_iov_t compat_iovs[XEN_ARGO_MAXIOV]; > > @@ -2267,7 +2267,7 @@ compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > > > rc = sendv(currd, &send_addr.src, &send_addr.dst, iovs, niov, arg4); > > out: > > - argo_dprintk("<-compat_argo_op(%u)=%ld\n", cmd, rc); > > + argo_dprintk("<-compat_argo_op(%u)=%d\n", cmd, rc); > > > > return rc; > > } > > diff --git a/xen/common/kexec.c b/xen/common/kexec.c > > index a2ffb6530c..41669964d2 100644 > > --- a/xen/common/kexec.c > > +++ b/xen/common/kexec.c > > @@ -1213,7 +1213,7 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) uarg) > > return !!test_bit(bit, &kexec_flags); > > } > > > > -static int do_kexec_op_internal(unsigned long op, > > +static int do_kexec_op_internal(unsigned int op, > > XEN_GUEST_HANDLE_PARAM(void) uarg, > > bool_t compat) > > { > > @@ -1265,13 +1265,13 @@ static int do_kexec_op_internal(unsigned long op, > > return ret; > > } > > > > -long cf_check do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > +long cf_check do_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > { > > return do_kexec_op_internal(op, uarg, 0); > > } > > > > #ifdef CONFIG_COMPAT > > -int cf_check compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > +int cf_check compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > { > > return do_kexec_op_internal(op, uarg, 1); > > } > > diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h > > index 81aae7a662..a032ba2b4a 100644 > > --- a/xen/include/xen/hypercall.h > > +++ b/xen/include/xen/hypercall.h > > @@ -114,11 +114,6 @@ common_vcpu_op(int cmd, > > struct vcpu *v, > > XEN_GUEST_HANDLE_PARAM(void) arg); > > > > -extern long cf_check > > -do_nmi_op( > > - unsigned int cmd, > > - XEN_GUEST_HANDLE_PARAM(void) arg); > > - > > extern long cf_check > > do_hvm_op( > > unsigned long op, > > @@ -126,7 +121,7 @@ do_hvm_op( > > > > extern long cf_check > > do_kexec_op( > > - unsigned long op, > > + unsigned int op, > > XEN_GUEST_HANDLE_PARAM(void) uarg); > > > > extern long cf_check > > @@ -145,9 +140,6 @@ extern long cf_check do_argo_op( > > extern long cf_check > > do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); > > > > -extern long cf_check > > -do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg); > > - > > extern long cf_check > > do_dm_op( > > domid_t domid, > > @@ -205,15 +197,21 @@ extern int cf_check compat_xsm_op( > > XEN_GUEST_HANDLE_PARAM(void) op); > > > > extern int cf_check compat_kexec_op( > > - unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg); > > + unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg); > > > > DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t); > > extern int cf_check compat_multicall( > > XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list, > > uint32_t nr_calls); > > > > +int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > + > > +typedef struct compat_platform_op compat_platform_op_t; > > +DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t); > > +int compat_platform_op(XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op); > > + > > #ifdef CONFIG_ARGO > > -extern long cf_check compat_argo_op( > > +extern int cf_check compat_argo_op( > > unsigned int cmd, > > XEN_GUEST_HANDLE_PARAM(void) arg1, > > XEN_GUEST_HANDLE_PARAM(void) arg2, > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 19:58:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 19:58:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362494.592530 (Exim 4.92) (envelope-from ) id 1o9B9r-0001hK-7F; Wed, 06 Jul 2022 19:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362494.592530; Wed, 06 Jul 2022 19:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9B9r-0001hD-4b; Wed, 06 Jul 2022 19:57:59 +0000 Received: by outflank-mailman (input) for mailman id 362494; Wed, 06 Jul 2022 19:57:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9B9p-0001h3-EP for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 19:57:57 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ed662ea0-fd65-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 21:57:56 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 874CEB81EB7; Wed, 6 Jul 2022 19:57:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D749DC3411C; Wed, 6 Jul 2022 19:57:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed662ea0-fd65-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657137474; bh=SeI7GIhNWV7ePymEjCfbIYEMXriY2YCHmjJZCxyfDxs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=IcN8pAbcYWCwbcPmW8kIUzZsGHuLivkS/NygFxlX3oFLRlxayeu76itJqVdHo//5y +R9sePkj+NT/TJoFbkq88rv1EV8p72gzYAgP48XVjQ+qRFR1ixle8IE9/wpHz/J4zt kxAnvdGUYLk1lnt2QVxGrmQMtAn0Xob5b/DPj2Ojvy+U6KW2wfUOF/L+Xw90MEZtf4 6FoVArPQzymSwU7AnCzT4O/1VUlCG/IZiG9mhZEqF4fQc28AeNF3ASvXpPb0sd5Cks foJJYkJx+eCCTGibglXKib/3xborNeqa99MwCfEqDRmmBvPjbHqaH1iYxsgYRniOPh J8/QrY36543dA== Date: Wed, 6 Jul 2022 12:57:52 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: George Dunlap cc: xen-devel@lists.xenproject.org, Wei Liu , Andrew Cooper , Jan Beulich , Stefano Stabellini , Julien Grall , "Daniel P . Smith" Subject: Re: [PATCH] MAINTAINERS: Make Daniel P. Smith sole XSM maintainer In-Reply-To: <20220706135245.64915-1-george.dunlap@citrix.com> Message-ID: References: <20220706135245.64915-1-george.dunlap@citrix.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 6 Jul 2022, George Dunlap wrote: > While mail hasn't been bouncing, Daniel De Graaf has not been > responding to patch submissions or otherwise interacting with the > community for several years. Daniel Smith has at least been working > with the code, and is a regular member of our community; and he has > agreed to step up into the role. > > Signed-off-by: George Dunlap Acked-by: Stefano Stabellini > --- > CC: Wei Liu > CC: Andrew Cooper > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Grall > CC: Daniel P. Smith > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8a99526784..e12c499a28 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -649,8 +649,7 @@ F: xen/common/trace.c > F: xen/include/xen/trace.h > > XSM/FLASK > -M: Daniel De Graaf > -R: Daniel P. Smith > +M: Daniel P. Smith > S: Supported > F: tools/flask/ > F: xen/include/xsm/ > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 20:02:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 20:02:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362500.592541 (Exim 4.92) (envelope-from ) id 1o9BEP-0003Y3-Or; Wed, 06 Jul 2022 20:02:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362500.592541; Wed, 06 Jul 2022 20:02:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9BEP-0003Xw-Lw; Wed, 06 Jul 2022 20:02:41 +0000 Received: by outflank-mailman (input) for mailman id 362500; Wed, 06 Jul 2022 20:02:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9BEO-0003Xq-AZ for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 20:02:40 +0000 Received: from mail-vk1-xa2a.google.com (mail-vk1-xa2a.google.com [2607:f8b0:4864:20::a2a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95d47ad5-fd66-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 22:02:39 +0200 (CEST) Received: by mail-vk1-xa2a.google.com with SMTP id r184so1124573vkg.9 for ; Wed, 06 Jul 2022 13:02:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d47ad5-fd66-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AXLWtANm01GM5VLt1ZcmE4zffRDaqpad1U8GZvOJct0=; b=W8Wcnuk2DEp18S8viFXMwYS09eKwwZ8xVuIzLuXO1yTdKu0VV6uL3vWbBVWM/WKbMa qzFzEvyW88D0j+lPegsCiR727eZSYWAEGw8sO2ZCouCw9HJlvjvapHAs6pLQmGYb6ExJ FnASKIUwtc+1tuxismJCFaQB7vXUXEqg9SDhLHkMchbEg4HvWIX5+CtA/wWcM5llweCy fi0Gqee6u2oivOjrD/6NM9T/dVEb9bnWGAteMeSHBH9eslvAJQT8jNOvA7NuXucoaJjV IN4liS29+0lLvZU2z1UfSMquee9bsX7hNOiLVPbdZUI/7/guvc6AB9gdfyRsGTzMhzrL hoyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AXLWtANm01GM5VLt1ZcmE4zffRDaqpad1U8GZvOJct0=; b=CVbAEof0HFzViFa9hlClQZtpLMa8D5+Tf12dIvvT26ne/brnZpSkS8xpsvPoveYeE5 vCiBV91Vi0soS8MZeMbnUsCTjtNpooh+NO7BDCzLZyOoJ1Bw/GMXh7YOLI8IDLt9Uis8 I3auqgq1XtohTTwzkVLeRRqbR97y7JIt+YYdSPBMjQXU1AX4EtS2Y1FySnfm6FSzmBRn TCrJ5tE6khMdLLLGTn24yUpY2kysdHCHlL7vxLzYux1U9j6fG/4/PxxvQZgU6nudryCG PjqeHi5Q5Nj1WBPQMiUDQJC6ButBNDFQIwv2YfqLgls3WAx27vot17ttNeQcPv8N86yn yWPw== X-Gm-Message-State: AJIora9kqP9V5uEC8F7hsuoQKJ2apn/soTA7VYope7Koy9raEzD17AXm bQubjRCXet8lns/ssrbgSBza0Xca5+0eVjWbZCA= X-Google-Smtp-Source: AGRyM1s0UIW9qynCHn6vzim6vYN1TcqJjFk7sO6j3/okKreFl9FkUzWfd7oKBxf6kZ2TGjM+zEydx5THqZX+//4Dbno= X-Received: by 2002:ac5:c5ba:0:b0:36b:f95a:85ae with SMTP id f26-20020ac5c5ba000000b0036bf95a85aemr24340608vkl.1.1657137757981; Wed, 06 Jul 2022 13:02:37 -0700 (PDT) MIME-Version: 1.0 References: <20220706135245.64915-1-george.dunlap@citrix.com> In-Reply-To: <20220706135245.64915-1-george.dunlap@citrix.com> From: Christopher Clark Date: Wed, 6 Jul 2022 13:02:27 -0700 Message-ID: Subject: Re: [PATCH] MAINTAINERS: Make Daniel P. Smith sole XSM maintainer To: George Dunlap Cc: xen-devel , Wei Liu , Andrew Cooper , Jan Beulich , Stefano Stabellini , Julien Grall , "Daniel P . Smith" Content-Type: text/plain; charset="UTF-8" On Wed, Jul 6, 2022 at 6:53 AM George Dunlap wrote: > Some alternative text for consideration for this patch: Patch subject line: MAINTAINERS: Reassign XSM maintainership > While mail hasn't been bouncing, Daniel De Graaf has not been > responding to patch submissions or otherwise interacting with the > community for several years. Daniel Smith has at least been working > with the code, and is a regular member of our community; and he has > agreed to step up into the role. Daniel Smith is experienced with the XSM code, is an active participant in our community, and has accepted the invitation to become the sole maintainer. Thanks to Daniel De Graaf for his contributions to Xen. > > Signed-off-by: George Dunlap > --- > CC: Wei Liu > CC: Andrew Cooper > CC: Jan Beulich > CC: Stefano Stabellini > CC: Julien Grall > CC: Daniel P. Smith > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8a99526784..e12c499a28 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -649,8 +649,7 @@ F: xen/common/trace.c > F: xen/include/xen/trace.h > > XSM/FLASK > -M: Daniel De Graaf > -R: Daniel P. Smith > +M: Daniel P. Smith > S: Supported > F: tools/flask/ > F: xen/include/xsm/ > -- > 2.25.1 > > Christopher From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362517.592563 (Exim 4.92) (envelope-from ) id 1o9CCz-0003Xw-It; Wed, 06 Jul 2022 21:05:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362517.592563; Wed, 06 Jul 2022 21:05:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CCz-0003Xp-GG; Wed, 06 Jul 2022 21:05:17 +0000 Received: by outflank-mailman (input) for mailman id 362517; Wed, 06 Jul 2022 21:05:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CCy-0003HV-Cm for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:05:16 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54544701-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:05:15 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141504075850.5089371575083; Wed, 6 Jul 2022 14:05:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54544701-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141506; cv=none; d=zohomail.com; s=zohoarc; b=BjNz+vhtn7JZ5oNQY7AaCvfLF5xunP4mzu+LiWjrFMTtB3Ri1YD/I59SoR6a+VYGP40lFvuDZIoIeAFqkOM8qGMrtmEYAKutRzGblzu8U6e5jIZPRS0fSlWK3Zk7JffUEB4bz7WtnbF0QfeAbn7OV797ZCoc0+yoIz6MTRpFtjc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141506; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=L/WuBmkg15fArIYdTBpQjhnYAJp4Q8ksywWw6j7y7O8=; b=BMboqLQtUVXQKRboHj9iTOqC8mgYY3YdmkeTrUDYeRvSO4qZq7EZM5yDTY8+Dj5T47Qi+H2OHuek5SQHssJmEkiUrN5uln8SiSJo41diIH0BQrbn6kJIWAyrOqq3rl51Z2LI5FfP+jTPl7LaX2jngGVvhfn1577XTP3LSjlMRM8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141506; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=L/WuBmkg15fArIYdTBpQjhnYAJp4Q8ksywWw6j7y7O8=; b=KLftkx3bZqqDYrLUBhhP6M3pnGw4ilhiAar0WywhdGCFvn+xvKFDlx/Ye9/i623n e8THaiTSFzoZ53ZxWoTei+e8B/Fg9ehMnHIOnjb58IHArhBmvOKsCFGq2m10n+THzqJ WibxvAosMfuzhxBgJBu5hw+LKsmkYiLa+9sxuxpA= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Date: Wed, 6 Jul 2022 17:04:36 -0400 Message-Id: <20220706210454.30096-2-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External For x86 the number of allowable multiboot modules varies between the different entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and x86 this value is fixed to values based on generalized assumptions. With hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large allocations compiled into the hypervisor that will go unused by many use cases. This commit introduces a Kconfig variable that is set with sane defaults based on configuration selection. This variable is in turned used as the array size for the cases where a static allocated array of boot modules is declared. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/Kconfig | 12 ++++++++++++ xen/arch/arm/include/asm/setup.h | 5 +++-- xen/arch/x86/efi/efi-boot.h | 2 +- xen/arch/x86/guest/xen/pvh-boot.c | 2 +- xen/arch/x86/setup.c | 4 ++-- 5 files changed, 19 insertions(+), 6 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..24139057be 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,15 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_BOOTMODS + int "Maximum number of boot modules that a loader can pass" + range 1 32768 + default "8" if X86 + default "32" if ARM + help + Controls the build-time size of various arrays allocated for + parsing the boot modules passed by a loader when starting Xen. + + This is of particular interest when using Xen's hypervisor domain + capabilities such as dom0less. diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 2bb01ecfa8..312a3e4209 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -10,7 +10,8 @@ #define NR_MEM_BANKS 256 -#define MAX_MODULES 32 /* Current maximum useful modules */ +/* Current maximum useful modules */ +#define MAX_MODULES CONFIG_NR_BOOTMODS typedef enum { BOOTMOD_XEN, @@ -38,7 +39,7 @@ struct meminfo { * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. * The purpose of the domU flag is to avoid getting confused in * kernel_probe, where we try to guess which is the dom0 kernel and - * initrd to be compatible with all versions of the multiboot spec. + * initrd to be compatible with all versions of the multiboot spec. */ #define BOOTMOD_MAX_CMDLINE 1024 struct bootmodule { diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 6e65b569b0..4e1a799749 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[5]; +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 498625eae0..834b1ad16b 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -32,7 +32,7 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[8]; +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; static const char *__initdata pvh_loader = "PVH Directboot"; static void __init convert_pvh_info(multiboot_info_t **mbi, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8de..2aa1e28c8f 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1020,9 +1020,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > sizeof(module_map) * 8 ) + if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) { - mbi->mods_count = sizeof(module_map) * 8; + mbi->mods_count = CONFIG_NR_BOOTMODS; printk("Excessive multiboot modules - using the first %u only\n", mbi->mods_count); } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:05:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:05:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362516.592553 (Exim 4.92) (envelope-from ) id 1o9CCw-0003Hs-B8; Wed, 06 Jul 2022 21:05:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362516.592553; Wed, 06 Jul 2022 21:05:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CCw-0003Hl-8I; Wed, 06 Jul 2022 21:05:14 +0000 Received: by outflank-mailman (input) for mailman id 362516; Wed, 06 Jul 2022 21:05:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CCu-0003HV-5d for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:05:12 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 50096e6b-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:05:09 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141502311577.7833419610672; Wed, 6 Jul 2022 14:05:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50096e6b-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141504; cv=none; d=zohomail.com; s=zohoarc; b=kyW+l8tpmRu4KURI7nguDCk1XU6ruJVxwuNPOeI/B+gCqnkW/GiJTvQX8GSXd4WAEA4oJPjiKC0gD06SBD9qTHai6fHj8l34A6Hv/EZ1xmYtfs0+0LWFERFtMTTldceRYQixHfTDbdwXDxq6WWNFdifVa+366NJKL0beP7AemLk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141504; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=nTRkkvW+5JHPNvq9pdfiGGHPPr03Uu0sr0CrPi6JF7M=; b=K9a1cZ5KGyN5DnbS7w+VuzBqzxZHC2FHO2VDwVYmFPSubUxn/lAmc9nHmAF4fddPayVCZhpy6yOsqEOZ5SvL4jfvmYUTULRmF3F56+bqUh+3fimdPx/Ej+YkO10djHt2fP8s7GsTJcL5/R31/lsSVgnVU/ypYnpBgz7cZNDQQOg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141504; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=nTRkkvW+5JHPNvq9pdfiGGHPPr03Uu0sr0CrPi6JF7M=; b=cr8yHJ0R4w31Lljh61DPi2DMAYp8maiL4tr/1kDp8EFfN5YaGgTWLgqSwFpDdO5Z U8D5xFhZkEFw2rQux2xmf7HIfKicI9a8VtYhoFwUy2C/DR6OGYJPCxQbvS6RTu7F3XM NGe0EHyHhDehDYekByjQKiINFxWBgnCnkUUxyQmE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io Subject: [PATCH v1 00/18] Hyperlaunch Date: Wed, 6 Jul 2022 17:04:35 -0400 Message-Id: <20220706210454.30096-1-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This work being submitted in this series was made possible with a great thanks to Star Lab Cop ration and their generous funding of this project. The patch series is based on the existing xsm series for starting the idle domain privileged. After that, the first four commits were previously submitted as an RFC and expanded by an additional commit to refactor xen commandline handling. The remaining preliminary patches are FDT refactoring and a doc update. From there is where the series begins to  morph x86 arch to support building multiple domains at boot. This series has been fairly well tested using qemu with a multiboot1 bootoader and under EFI + GRUB multiboot2 boot. While there are likely some rough spots remaining in the series, it is at a point now where the series should be reviewed, exercised, and tested for consideration into tree. Information, including docuemntation, meeting minutes, presentations, and past series postings can be found on the Xen wiki: https://wiki.xenproject.org/wiki/Hyperlaunch Daniel P. Smith (18): kconfig: allow configuration of maximum modules introduction of generalized boot info x86: adopt new boot info structures x86: refactor entrypoints to new boot info x86: refactor xen cmdline into general framework fdt: make fdt handling reusable across arch docs: update hyperlaunch device tree documentation kconfig: introduce domain builder config option x86: introduce abstractions for domain builder x86: introduce the domain builder x86: initial conversion to domain builder x86: convert dom0 creation to domain builder x86: generalize physmap logic x86: generalize vcpu for domain building x86: rework domain page allocation x86: add pv multidomain construction builder: introduce domain builder hypfs tree tools: introduce example late pv helper .gitignore | 1 + .../designs/launch/hyperlaunch-devicetree.rst | 497 +++++++++++------- tools/helpers/Makefile | 11 + tools/helpers/builder-hypfs.c | 253 +++++++++ tools/helpers/hypfs-helpers.h | 9 + tools/helpers/late-init-pv.c | 287 ++++++++++ tools/helpers/late-init-pv.h | 29 + tools/helpers/xs-helpers.c | 117 +++++ tools/helpers/xs-helpers.h | 27 + xen/arch/Kconfig | 12 + xen/arch/arm/bootfdt.c | 115 +--- xen/arch/arm/include/asm/setup.h | 5 +- xen/arch/x86/Makefile | 1 + xen/arch/x86/boot/boot_info32.h | 97 ++++ xen/arch/x86/boot/defs.h | 17 +- xen/arch/x86/boot/reloc.c | 187 +++++-- xen/arch/x86/bzimage.c | 18 +- xen/arch/x86/cpu/microcode/core.c | 133 +++-- xen/arch/x86/dom0_build.c | 129 +---- xen/arch/x86/domain_builder.c | 284 ++++++++++ xen/arch/x86/efi/efi-boot.h | 96 ++-- xen/arch/x86/guest/xen/pvh-boot.c | 64 ++- xen/arch/x86/hvm/dom0_build.c | 62 +-- xen/arch/x86/include/asm/bootdomain.h | 30 ++ xen/arch/x86/include/asm/bootinfo.h | 99 ++++ xen/arch/x86/include/asm/bzimage.h | 5 +- xen/arch/x86/include/asm/dom0_build.h | 27 +- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/include/asm/setup.h | 18 +- xen/arch/x86/pv/Makefile | 2 +- .../x86/pv/{dom0_build.c => domain_builder.c} | 141 ++--- xen/arch/x86/pv/shim.c | 4 +- xen/arch/x86/setup.c | 392 ++++++-------- xen/common/Kconfig | 5 + xen/common/Makefile | 4 +- xen/common/domain-builder/Kconfig | 36 ++ xen/common/domain-builder/Makefile | 3 + xen/common/domain-builder/core.c | 207 ++++++++ xen/common/domain-builder/fdt.c | 295 +++++++++++ xen/common/domain-builder/fdt.h | 7 + xen/common/domain-builder/hypfs.c | 193 +++++++ xen/common/efi/boot.c | 4 +- xen/common/fdt.c | 131 +++++ xen/common/sched/core.c | 25 +- xen/include/xen/bootdomain.h | 58 ++ xen/include/xen/bootinfo.h | 132 +++++ xen/include/xen/device_tree.h | 50 +- xen/include/xen/domain_builder.h | 88 ++++ xen/include/xen/fdt.h | 79 +++ xen/include/xen/sched.h | 3 +- xen/include/xsm/xsm.h | 26 +- xen/xsm/xsm_core.c | 43 +- xen/xsm/xsm_policy.c | 56 +- 53 files changed, 3544 insertions(+), 1076 deletions(-) create mode 100644 tools/helpers/builder-hypfs.c create mode 100644 tools/helpers/hypfs-helpers.h create mode 100644 tools/helpers/late-init-pv.c create mode 100644 tools/helpers/late-init-pv.h create mode 100644 tools/helpers/xs-helpers.c create mode 100644 tools/helpers/xs-helpers.h create mode 100644 xen/arch/x86/boot/boot_info32.h create mode 100644 xen/arch/x86/domain_builder.c create mode 100644 xen/arch/x86/include/asm/bootdomain.h create mode 100644 xen/arch/x86/include/asm/bootinfo.h rename xen/arch/x86/pv/{dom0_build.c => domain_builder.c} (88%) create mode 100644 xen/common/domain-builder/Kconfig create mode 100644 xen/common/domain-builder/Makefile create mode 100644 xen/common/domain-builder/core.c create mode 100644 xen/common/domain-builder/fdt.c create mode 100644 xen/common/domain-builder/fdt.h create mode 100644 xen/common/domain-builder/hypfs.c create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/bootdomain.h create mode 100644 xen/include/xen/bootinfo.h create mode 100644 xen/include/xen/domain_builder.h create mode 100644 xen/include/xen/fdt.h -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:05:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:05:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362522.592575 (Exim 4.92) (envelope-from ) id 1o9CDR-0004EL-TG; Wed, 06 Jul 2022 21:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362522.592575; Wed, 06 Jul 2022 21:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CDR-0004EE-PN; Wed, 06 Jul 2022 21:05:45 +0000 Received: by outflank-mailman (input) for mailman id 362522; Wed, 06 Jul 2022 21:05:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CDQ-0003HV-Ux for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:05:45 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6569030e-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:05:44 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141505647707.2048656643256; Wed, 6 Jul 2022 14:05:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6569030e-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141507; cv=none; d=zohomail.com; s=zohoarc; b=F53S/fI0beguCKqm60AlEo0l4La9lTDv2Z7hwppp/9JlW0psYjuMVI0JmH4kZ7D9k6SngKWBHKNlTysjOK4KKdVAzHrLdvM10X44uJnj+gmSTx0+6DpA/Tgov94a+pEBYWiRahgXLUWzQXZIAVRxda/LAnACOEl/CXKLg+4BgRU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141507; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=l2m2wX7dK/BSzsuu2D0GCQSog1dryKjASVBBBj6qczc=; b=d+iNWiPGJvePrA882j0GnmZRKYwp7SDM2Da0ONiwyrk6IqSjb2Dtw1JKuV1dz3d7KCiEXj7c6BDCl8TRG75msUAbyX3TEN2WPvPUEyoGoAcVCazhQFrPjDRq6KXH2JFbtbJvMAFfUaFCHsslpVTe1rlZ2/o8vm60SrWzgwkYRXE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141507; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=l2m2wX7dK/BSzsuu2D0GCQSog1dryKjASVBBBj6qczc=; b=jZ3HDRBPmvgVEqQvaScvN6a7x+QzCI/HJxuq+G73s//FuigK1Kbkxg8aZApKRXPj BNUgBu1PTyrJT02m9fLWYAKzGQaGDLPpB9+5WLIxOIKskirDq4l+geAIgG8ibjTKIky 3h331NjICkt+HVEOcDtZe6s7uq/+nBKzXJQXDkdM= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v1 02/18] introduction of generalized boot info Date: Wed, 6 Jul 2022 17:04:37 -0400 Message-Id: <20220706210454.30096-3-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The x86 and Arm architectures represent in memory the general boot information and boot modules differently despite having commonality. The x86 representations are bound to the multiboot v1 structures while the Arm representations are a slightly generalized meta-data container for the boot material. The multiboot structure does not lend itself well to being expanded to accommodate additional metadata, both general and boot module specific. The Arm structures are not bound to an external specification and thus are able to be expanded for solutions such as dom0less. This commit introduces a set of structures patterned off the Arm structures to represent the boot information in a manner that captures common data. The structures provide an arch field to allow arch specific expansions to the structures. The intended goal of these new common structures is to enable commonality between the different architectures.  Specifically to enable dom0less and hyperlaunch to have a common representation of boot-time constructed domains. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/include/asm/bootinfo.h | 48 +++++++++++++++++++++++++ xen/include/xen/bootinfo.h | 54 +++++++++++++++++++++++++++++ 2 files changed, 102 insertions(+) create mode 100644 xen/arch/x86/include/asm/bootinfo.h create mode 100644 xen/include/xen/bootinfo.h diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h new file mode 100644 index 0000000000..b0754a3ed0 --- /dev/null +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -0,0 +1,48 @@ +#ifndef __ARCH_X86_BOOTINFO_H__ +#define __ARCH_X86_BOOTINFO_H__ + +/* unused for x86 */ +struct arch_bootstring { }; + +struct __packed arch_bootmodule { +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + uint32_t flags; + uint32_t headroom; +}; + +struct __packed arch_boot_info { + uint32_t flags; +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 +#define BOOTINFO_FLAG_X86_APM 1U << 10 + + bool xen_guest; + + char *boot_loader_name; + char *kextra; + + uint32_t mem_lower; + uint32_t mem_upper; + + uint32_t mmap_length; + paddr_t mmap_addr; +}; + +struct __packed mb_memmap { + uint32_t size; + uint32_t base_addr_low; + uint32_t base_addr_high; + uint32_t length_low; + uint32_t length_high; + uint32_t type; +}; + +#endif diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h new file mode 100644 index 0000000000..42b53a3ca6 --- /dev/null +++ b/xen/include/xen/bootinfo.h @@ -0,0 +1,54 @@ +#ifndef __XEN_BOOTINFO_H__ +#define __XEN_BOOTINFO_H__ + +#include +#include + +#include + +typedef enum { + BOOTMOD_UNKNOWN, + BOOTMOD_XEN, + BOOTMOD_FDT, + BOOTMOD_KERNEL, + BOOTMOD_RAMDISK, + BOOTMOD_XSM, + BOOTMOD_UCODE, + BOOTMOD_GUEST_DTB, +} bootmodule_kind; + +typedef enum { + BOOTSTR_EMPTY, + BOOTSTR_STRING, + BOOTSTR_CMDLINE, +} bootstring_kind; + +#define BOOTMOD_MAX_STRING 1024 +struct __packed boot_string { + bootstring_kind kind; + struct arch_bootstring *arch; + + char bytes[BOOTMOD_MAX_STRING]; + size_t len; +}; + +struct __packed boot_module { + bootmodule_kind kind; + paddr_t start; + mfn_t mfn; + size_t size; + + struct arch_bootmodule *arch; + struct boot_string string; +}; + +struct __packed boot_info { + char *cmdline; + + uint32_t nr_mods; + struct boot_module *mods; + + struct arch_boot_info *arch; +}; + +#endif -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:06:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362528.592586 (Exim 4.92) (envelope-from ) id 1o9CDl-0004mz-CZ; Wed, 06 Jul 2022 21:06:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362528.592586; Wed, 06 Jul 2022 21:06:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CDl-0004mq-8L; Wed, 06 Jul 2022 21:06:05 +0000 Received: by outflank-mailman (input) for mailman id 362528; Wed, 06 Jul 2022 21:06:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CDj-0003HV-7V for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:06:03 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f1c94b7-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:06:00 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165714150753612.876907581220394; Wed, 6 Jul 2022 14:05:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f1c94b7-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141508; cv=none; d=zohomail.com; s=zohoarc; b=UPoKzG2vjDE7b44mUrCaQIzMJ9+48/SRss8uMwYa78V+crmn4F+Aw8cFIZGRtmKNvWAw4k9Of3qFHGuR0NBc82WiwPUzEf1NFkr+Oh+W1A5WTYohvy687EmlLkTwwSY/k6VCbL2rRPLbIJ6uk+G4cijzVcr2k4u1tPxq+BnF26Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141508; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=8PbN8YfYMbKnd/HJJdmnKs6uVeRv2IP7bTXausYq7vM=; b=M/1dQpIsiqa3n4p5sECtc0xdD3SrovU7EJWpH6XQHHChN8Wx5wBMYAYo55Uh9QulREG8lpVntcTLyZkuyXNOGKyteSPhJadaPlKeoERkLY0tSYXPpDoJy5wbdiK2LaDR0orVGwgPdKdGdqUruVBa786X7hvyverAstF4dx699BE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141508; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=8PbN8YfYMbKnd/HJJdmnKs6uVeRv2IP7bTXausYq7vM=; b=dUfDcCAApjSdHeGYzC+Mh6hNUbKqtabL17PTsyQw3jnh6XfVYVAYZ2MgXOvojmja 8mGFYe0SW3rnf9ghwkkPHUkYl1kLuBr/nlXq5ROLgDvEOv2vMGHiuybHcoVmLgAUiFk uUtxrstCaLUniqznhuLH7EB2MJElF7PcC2qgj93w= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Daniel De Graaf Subject: [PATCH v1 03/18] x86: adopt new boot info structures Date: Wed, 6 Jul 2022 17:04:38 -0400 Message-Id: <20220706210454.30096-4-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit replaces the use of the multiboot v1 structures starting at __start_xen(). The majority of this commit is converting the fields being accessed for the startup calculations. While adapting the ucode boot module location logic, this code was refactored to reduce some of the unnecessary complexity. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/bzimage.c | 18 +- xen/arch/x86/cpu/microcode/core.c | 133 ++++++++------ xen/arch/x86/dom0_build.c | 11 +- xen/arch/x86/hvm/dom0_build.c | 42 ++--- xen/arch/x86/include/asm/bootinfo.h | 2 +- xen/arch/x86/include/asm/bzimage.h | 5 +- xen/arch/x86/include/asm/dom0_build.h | 15 +- xen/arch/x86/include/asm/setup.h | 14 +- xen/arch/x86/pv/dom0_build.c | 34 ++-- xen/arch/x86/setup.c | 245 +++++++++++++++----------- xen/include/xen/bootinfo.h | 47 +++++ xen/include/xsm/xsm.h | 26 ++- xen/xsm/xsm_core.c | 43 +++-- xen/xsm/xsm_policy.c | 56 +++--- 14 files changed, 413 insertions(+), 278 deletions(-) diff --git a/xen/arch/x86/bzimage.c b/xen/arch/x86/bzimage.c index ac4fd428be..03cb372957 100644 --- a/xen/arch/x86/bzimage.c +++ b/xen/arch/x86/bzimage.c @@ -69,10 +69,8 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) return 1; } -static unsigned long __initdata orig_image_len; - -unsigned long __init bzimage_headroom(void *image_start, - unsigned long image_length) +unsigned long __init bzimage_headroom( + void *image_start, unsigned long image_length) { struct setup_header *hdr = (struct setup_header *)image_start; int err; @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, if ( elf_is_elfbinary(image_start, image_length) ) return 0; - orig_image_len = image_length; headroom = output_length(image_start, image_length); if (gzip_check(image_start, image_length)) { @@ -104,12 +101,15 @@ unsigned long __init bzimage_headroom(void *image_start, return headroom; } -int __init bzimage_parse(void *image_base, void **image_start, - unsigned long *image_len) +int __init bzimage_parse( + void *image_base, void **image_start, unsigned int headroom, + unsigned long *image_len) { struct setup_header *hdr = (struct setup_header *)(*image_start); int err = bzimage_check(hdr, *image_len); - unsigned long output_len; + unsigned long output_len, orig_image_len; + + orig_image_len = *image_len - headroom; if ( err < 0 ) return err; @@ -125,7 +125,7 @@ int __init bzimage_parse(void *image_base, void **image_start, BUG_ON(!(image_base < *image_start)); - output_len = output_length(*image_start, orig_image_len); + output_len = output_length(*image_start, *image_len); if ( (err = perform_gunzip(image_base, *image_start, orig_image_len)) > 0 ) err = decompress(*image_start, orig_image_len, image_base); diff --git a/xen/arch/x86/cpu/microcode/core.c b/xen/arch/x86/cpu/microcode/core.c index 452a7ca773..bfdba85796 100644 --- a/xen/arch/x86/cpu/microcode/core.c +++ b/xen/arch/x86/cpu/microcode/core.c @@ -22,6 +22,7 @@ */ #include +#include #include #include #include @@ -54,7 +55,6 @@ */ #define MICROCODE_UPDATE_TIMEOUT_US 1000000 -static module_t __initdata ucode_mod; static signed int __initdata ucode_mod_idx; static bool_t __initdata ucode_mod_forced; static unsigned int nr_cores; @@ -147,74 +147,113 @@ static int __init cf_check parse_ucode(const char *s) } custom_param("ucode", parse_ucode); -void __init microcode_scan_module( - unsigned long *module_map, - const multiboot_info_t *mbi) +#define MICROCODE_MODULE_MATCH 1 +#define MICROCODE_MODULE_NONMATCH 0 + +static int __init microcode_check_module(struct boot_module *mod) { - module_t *mod = (module_t *)__va(mbi->mods_addr); uint64_t *_blob_start; unsigned long _blob_size; - struct cpio_data cd; + struct cpio_data cd = { NULL, 0 }; long offset; const char *p = NULL; - int i; - - ucode_blob.size = 0; - if ( !ucode_scan ) - return; if ( boot_cpu_data.x86_vendor == X86_VENDOR_AMD ) p = "kernel/x86/microcode/AuthenticAMD.bin"; else if ( boot_cpu_data.x86_vendor == X86_VENDOR_INTEL ) p = "kernel/x86/microcode/GenuineIntel.bin"; else + return -EFAULT; + + _blob_start = bootstrap_map(mod); + _blob_size = mod->size; + if ( !_blob_start ) + { + printk("Could not map multiboot module (0x%lx) (size: %ld)\n", + mod->start, _blob_size); + /* Non-fatal error, so just say no match */ + return MICROCODE_MODULE_NONMATCH; + } + + cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); + + if ( cd.data ) + { + ucode_blob.size = cd.size; + ucode_blob.data = cd.data; + + mod->kind = BOOTMOD_UCODE; + return MICROCODE_MODULE_MATCH; + } + + bootstrap_map(NULL); + + return 0; +} + +void __init microcode_scan_module(struct boot_info *bi) +{ + int idx = 0; + + if ( !ucode_scan ) return; /* - * Try all modules and see whichever could be the microcode blob. + * Try unidentified modules and see which could be the microcode blob. */ - for ( i = 1 /* Ignore dom0 kernel */; i < mbi->mods_count; i++ ) + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, idx); + while ( idx < bi->nr_mods ) { - if ( !test_bit(i, module_map) ) - continue; + int ret; - _blob_start = bootstrap_map(&mod[i]); - _blob_size = mod[i].mod_end; - if ( !_blob_start ) + ret = microcode_check_module(&bi->mods[idx]); + switch ( ret ) { - printk("Could not map multiboot module #%d (size: %ld)\n", - i, _blob_size); + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, ++idx); continue; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; } - cd.data = NULL; - cd.size = 0; - cd = find_cpio_data(p, _blob_start, _blob_size, &offset /* ignore */); - if ( cd.data ) - { - ucode_blob.size = cd.size; - ucode_blob.data = cd.data; - break; - } - bootstrap_map(NULL); } } -void __init microcode_grab_module( - unsigned long *module_map, - const multiboot_info_t *mbi) + +void __init microcode_grab_module(struct boot_info *bi) { - module_t *mod = (module_t *)__va(mbi->mods_addr); + ucode_blob.size = 0; if ( ucode_mod_idx < 0 ) - ucode_mod_idx += mbi->mods_count; - if ( ucode_mod_idx <= 0 || ucode_mod_idx >= mbi->mods_count || - !__test_and_clear_bit(ucode_mod_idx, module_map) ) - goto scan; - ucode_mod = mod[ucode_mod_idx]; -scan: + ucode_mod_idx += bi->nr_mods; + if ( ucode_mod_idx >= 0 && ucode_mod_idx <= bi->nr_mods && + bi->mods[ucode_mod_idx].kind == BOOTMOD_UNKNOWN ) + { + int ret = microcode_check_module(&bi->mods[ucode_mod_idx]); + + switch ( ret ) + { + case MICROCODE_MODULE_MATCH: + return; + case MICROCODE_MODULE_NONMATCH: + break; + default: + printk("%s: (err: %d) unable to check microcode\n", + __func__, ret); + return; + } + } + if ( ucode_scan ) - microcode_scan_module(module_map, mbi); + microcode_scan_module(bi); } +/* Undefining as they are not needed anymore */ +#undef MICROCODE_MODULE_MATCH +#undef MICROCODE_MODULE_NONMATCH + static struct microcode_ops __ro_after_init ucode_ops; static DEFINE_SPINLOCK(microcode_mutex); @@ -711,11 +750,6 @@ static int __init cf_check microcode_init(void) ucode_blob.size = 0; ucode_blob.data = NULL; } - else if ( ucode_mod.mod_end ) - { - bootstrap_map(NULL); - ucode_mod.mod_end = 0; - } return 0; } @@ -745,11 +779,6 @@ static int __init early_microcode_update_cpu(void) len = ucode_blob.size; data = ucode_blob.data; } - else if ( ucode_mod.mod_end ) - { - len = ucode_mod.mod_end; - data = bootstrap_map(&ucode_mod); - } if ( !data ) return -ENOMEM; @@ -799,7 +828,7 @@ int __init early_microcode_init(void) alternative_vcall(ucode_ops.collect_cpu_info); - if ( ucode_mod.mod_end || ucode_blob.size ) + if ( ucode_blob.size ) rc = early_microcode_update_cpu(); return rc; diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 79234f18ff..9ca5a99510 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -574,9 +575,9 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0(struct domain *d, const module_t *image, - unsigned long image_headroom, module_t *initrd, - char *cmdline) +int __init construct_dom0( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int rc; @@ -588,9 +589,9 @@ int __init construct_dom0(struct domain *d, const module_t *image, process_pending_softirqs(); if ( is_hvm_domain(d) ) - rc = dom0_construct_pvh(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pvh(d, image, initrd, cmdline); else if ( is_pv_domain(d) ) - rc = dom0_construct_pv(d, image, image_headroom, initrd, cmdline); + rc = dom0_construct_pv(d, image, initrd, cmdline); else panic("Cannot construct Dom0. No guest interface available\n"); diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 1864d048a1..4e903a848d 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -19,9 +19,9 @@ */ #include +#include #include #include -#include #include #include @@ -543,14 +543,13 @@ static paddr_t __init find_memory( return INVALID_PADDR; } -static int __init pvh_load_kernel(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, void *image_base, - char *cmdline, paddr_t *entry, - paddr_t *start_info_addr) +static int __init pvh_load_kernel( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, void *image_base, char *cmdline, + paddr_t *entry, paddr_t *start_info_addr) { - void *image_start = image_base + image_headroom; - unsigned long image_len = image->mod_end; + void *image_start = image_base + image->arch->headroom; + unsigned long image_len = image->size; struct elf_binary elf; struct elf_dom_parms parms; paddr_t last_addr; @@ -559,7 +558,9 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, struct vcpu *v = d->vcpu[0]; int rc; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = + bzimage_parse(image_base, &image_start, image->arch->headroom, + &image_len)) != 0 ) { printk("Error trying to detect bz compressed kernel\n"); return rc; @@ -606,7 +607,7 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, * simplify it. */ last_addr = find_memory(d, &elf, sizeof(start_info) + - (initrd ? ROUNDUP(initrd->mod_end, PAGE_SIZE) + + (initrd ? ROUNDUP(initrd->size, PAGE_SIZE) + sizeof(mod) : 0) + (cmdline ? ROUNDUP(strlen(cmdline) + 1, @@ -620,8 +621,8 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, if ( initrd != NULL ) { - rc = hvm_copy_to_guest_phys(last_addr, mfn_to_virt(initrd->mod_start), - initrd->mod_end, v); + rc = hvm_copy_to_guest_phys(last_addr, maddr_to_virt(initrd->start), + initrd->size, v); if ( rc ) { printk("Unable to copy initrd to guest\n"); @@ -629,11 +630,11 @@ static int __init pvh_load_kernel(struct domain *d, const module_t *image, } mod.paddr = last_addr; - mod.size = initrd->mod_end; - last_addr += ROUNDUP(initrd->mod_end, elf_64bit(&elf) ? 8 : 4); - if ( initrd->string ) + mod.size = initrd->size; + last_addr += ROUNDUP(initrd->size, elf_64bit(&elf) ? 8 : 4); + if ( initrd->string.kind == BOOTSTR_CMDLINE ) { - char *str = __va(initrd->string); + char *str = initrd->string.bytes; size_t len = strlen(str) + 1; rc = hvm_copy_to_guest_phys(last_addr, str, len, v); @@ -1216,10 +1217,9 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain *d) } } -int __init dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { paddr_t entry, start_info; int rc; @@ -1249,7 +1249,7 @@ int __init dom0_construct_pvh(struct domain *d, const module_t *image, return rc; } - rc = pvh_load_kernel(d, image, image_headroom, initrd, bootstrap_map(image), + rc = pvh_load_kernel(d, image, initrd, bootstrap_map(image), cmdline, &entry, &start_info); if ( rc ) { diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index b0754a3ed0..e5135e402b 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -24,7 +24,7 @@ struct __packed arch_boot_info { #define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 #define BOOTINFO_FLAG_X86_APM 1U << 10 - bool xen_guest; + bool xenguest; char *boot_loader_name; char *kextra; diff --git a/xen/arch/x86/include/asm/bzimage.h b/xen/arch/x86/include/asm/bzimage.h index 7ed69d3910..5a5a25b4d7 100644 --- a/xen/arch/x86/include/asm/bzimage.h +++ b/xen/arch/x86/include/asm/bzimage.h @@ -5,7 +5,8 @@ unsigned long bzimage_headroom(void *image_start, unsigned long image_length); -int bzimage_parse(void *image_base, void **image_start, - unsigned long *image_len); +int bzimage_parse( + void *image_base, void **image_start, unsigned int headroom, + unsigned long *image_len); #endif /* __X86_BZIMAGE_H__ */ diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index a5f8c9e67f..ad33413710 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -1,6 +1,7 @@ #ifndef _DOM0_BUILD_H_ #define _DOM0_BUILD_H_ +#include #include #include @@ -13,15 +14,13 @@ unsigned long dom0_compute_nr_pages(struct domain *d, unsigned long initrd_len); int dom0_setup_permissions(struct domain *d); -int dom0_construct_pv(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int __init dom0_construct_pv( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); -int dom0_construct_pvh(struct domain *d, const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline); +int __init dom0_construct_pvh( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..27c0d61819 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -1,7 +1,8 @@ #ifndef __X86_SETUP_H_ #define __X86_SETUP_H_ -#include +#include + #include extern const char __2M_text_start[], __2M_text_end[]; @@ -33,20 +34,17 @@ static inline void vesa_init(void) {}; #endif int construct_dom0( - struct domain *d, - const module_t *kernel, unsigned long kernel_headroom, - module_t *initrd, - char *cmdline); + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline); void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); void discard_initial_images(void); -void *bootstrap_map(const module_t *mod); +void *bootstrap_map(const struct boot_module *mod); int xen_in_range(unsigned long mfn); -void microcode_grab_module( - unsigned long *, const multiboot_info_t *); +void microcode_grab_module(struct boot_info *bi); extern uint8_t kbd_shift_flags; diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index e501979a86..f6131147ef 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -294,11 +295,9 @@ static struct page_info * __init alloc_chunk(struct domain *d, return page; } -int __init dom0_construct_pv(struct domain *d, - const module_t *image, - unsigned long image_headroom, - module_t *initrd, - char *cmdline) +int __init dom0_construct_pv( + struct domain *d, const struct boot_module *image, + struct boot_module *initrd, char *cmdline) { int i, rc, order, machine; bool compatible, compat; @@ -314,9 +313,9 @@ int __init dom0_construct_pv(struct domain *d, start_info_t *si; struct vcpu *v = d->vcpu[0]; void *image_base = bootstrap_map(image); - unsigned long image_len = image->mod_end; - void *image_start = image_base + image_headroom; - unsigned long initrd_len = initrd ? initrd->mod_end : 0; + unsigned long image_len = image->size; + void *image_start = image_base + image->arch->headroom; + unsigned long initrd_len = initrd ? initrd->size : 0; l4_pgentry_t *l4tab = NULL, *l4start = NULL; l3_pgentry_t *l3tab = NULL, *l3start = NULL; l2_pgentry_t *l2tab = NULL, *l2start = NULL; @@ -355,7 +354,9 @@ int __init dom0_construct_pv(struct domain *d, d->max_pages = ~0U; - if ( (rc = bzimage_parse(image_base, &image_start, &image_len)) != 0 ) + if ( (rc = + bzimage_parse(image_base, &image_start, image->arch->headroom, + &image_len)) != 0 ) return rc; if ( (rc = elf_init(&elf, image_start, image_len)) != 0 ) @@ -544,7 +545,7 @@ int __init dom0_construct_pv(struct domain *d, initrd_pfn = vinitrd_start ? (vinitrd_start - v_start) >> PAGE_SHIFT : domain_tot_pages(d); - initrd_mfn = mfn = initrd->mod_start; + initrd_mfn = mfn = mfn_x(initrd->mfn); count = PFN_UP(initrd_len); if ( d->arch.physaddr_bitsize && ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) @@ -559,12 +560,13 @@ int __init dom0_construct_pv(struct domain *d, free_domheap_pages(page, order); page += 1UL << order; } - memcpy(page_to_virt(page), mfn_to_virt(initrd->mod_start), + memcpy(page_to_virt(page), maddr_to_virt(initrd->start), initrd_len); - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; init_domheap_pages(mpt_alloc, mpt_alloc + PAGE_ALIGN(initrd_len)); - initrd->mod_start = initrd_mfn = mfn_x(page_to_mfn(page)); + bootmodule_update_mfn(initrd, page_to_mfn(page)); + initrd_mfn = mfn_x(initrd->mfn); } else { @@ -572,7 +574,7 @@ int __init dom0_construct_pv(struct domain *d, if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) BUG(); } - initrd->mod_end = 0; + initrd->size = 0; } printk("PHYSICAL MEMORY ARRANGEMENT:\n" @@ -583,7 +585,7 @@ int __init dom0_construct_pv(struct domain *d, nr_pages - domain_tot_pages(d)); if ( initrd ) { - mpt_alloc = (paddr_t)initrd->mod_start << PAGE_SHIFT; + mpt_alloc = initrd->start; printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr, mpt_alloc, mpt_alloc + initrd_len); } @@ -804,7 +806,7 @@ int __init dom0_construct_pv(struct domain *d, if ( pfn >= initrd_pfn ) { if ( pfn < initrd_pfn + PFN_UP(initrd_len) ) - mfn = initrd->mod_start + (pfn - initrd_pfn); + mfn = mfn_x(initrd->mfn) + (pfn - initrd_pfn); else mfn -= PFN_UP(initrd_len); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2aa1e28c8f..2700f4eb3e 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1,3 +1,4 @@ +#include #include #include #include @@ -270,8 +271,48 @@ static int __init cf_check parse_acpi_param(const char *s) } custom_param("acpi", parse_acpi_param); -static const module_t *__initdata initial_images; -static unsigned int __initdata nr_initial_images; +struct boot_info __initdata *boot_info; + +static void __init mb_to_bootinfo(multiboot_info_t *mbi, module_t *mods) +{ + static struct boot_info __initdata x86_binfo; + static struct arch_boot_info __initdata arch_x86_binfo; + static struct boot_module __initdata x86_mods[CONFIG_NR_BOOTMODS + 1]; + static struct arch_bootmodule __initdata + arch_x86_mods[CONFIG_NR_BOOTMODS + 1]; + int i; + + x86_binfo.arch = &arch_x86_binfo; + x86_binfo.mods = x86_mods; + + x86_binfo.cmdline = __va(mbi->cmdline); + + /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ + arch_x86_binfo.flags = mbi->flags; + arch_x86_binfo.mem_upper = mbi->mem_upper; + arch_x86_binfo.mem_lower = mbi->mem_lower; + arch_x86_binfo.mmap_length = mbi->mmap_length; + arch_x86_binfo.mmap_addr = mbi->mmap_addr; + arch_x86_binfo.boot_loader_name = __va(mbi->boot_loader_name); + + x86_binfo.nr_mods = mbi->mods_count; + for ( i = 0; i <= CONFIG_NR_BOOTMODS; i++) + { + x86_mods[i].arch = &arch_x86_mods[i]; + + if ( i < x86_binfo.nr_mods ) + { + bootmodule_update_start(&x86_mods[i], mods[i].mod_start); + x86_mods[i].size = mods[i].mod_end - mods[i].mod_start; + + x86_mods[i].string.len = strlcpy(x86_mods[i].string.bytes, + __va(mods[i].string), + BOOTMOD_MAX_STRING); + } + } + + boot_info = &x86_binfo; +} unsigned long __init initial_images_nrpages(nodeid_t node) { @@ -280,10 +321,10 @@ unsigned long __init initial_images_nrpages(nodeid_t node) unsigned long nr; unsigned int i; - for ( nr = i = 0; i < nr_initial_images; ++i ) + for ( nr = i = 0; i < boot_info->nr_mods; ++i ) { - unsigned long start = initial_images[i].mod_start; - unsigned long end = start + PFN_UP(initial_images[i].mod_end); + unsigned long start = mfn_x(boot_info->mods[i].mfn); + unsigned long end = start + PFN_UP(boot_info->mods[i].size); if ( end > node_start && node_end > start ) nr += min(node_end, end) - max(node_start, start); @@ -296,16 +337,15 @@ void __init discard_initial_images(void) { unsigned int i; - for ( i = 0; i < nr_initial_images; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t start = (uint64_t)initial_images[i].mod_start << PAGE_SHIFT; + uint64_t start = (uint64_t)boot_info->mods[i].start; init_domheap_pages(start, - start + PAGE_ALIGN(initial_images[i].mod_end)); + start + PAGE_ALIGN(boot_info->mods[i].size)); } - nr_initial_images = 0; - initial_images = NULL; + boot_info->nr_mods = 0; } extern char __init_begin[], __init_end[], __bss_start[], __bss_end[]; @@ -392,14 +432,14 @@ static void __init normalise_cpu_order(void) * Ensure a given physical memory range is present in the bootstrap mappings. * Use superpage mappings to ensure that pagetable memory needn't be allocated. */ -void *__init bootstrap_map(const module_t *mod) +void *__init bootstrap_map(const struct boot_module *mod) { static unsigned long __initdata map_cur = BOOTSTRAP_MAP_BASE; uint64_t start, end, mask = (1L << L2_PAGETABLE_SHIFT) - 1; void *ret; if ( system_state != SYS_STATE_early_boot ) - return mod ? mfn_to_virt(mod->mod_start) : NULL; + return mod ? maddr_to_virt(mod->start) : NULL; if ( !mod ) { @@ -408,8 +448,8 @@ void *__init bootstrap_map(const module_t *mod) return NULL; } - start = (uint64_t)mod->mod_start << PAGE_SHIFT; - end = start + mod->mod_end; + start = (uint64_t)mod->start; + end = start + mod->size; if ( start >= end ) return NULL; @@ -436,25 +476,25 @@ static void *__init move_memory( while ( size ) { - module_t mod; + struct boot_module mod; unsigned int soffs = src & mask; unsigned int doffs = dst & mask; unsigned int sz; void *d, *s; - mod.mod_start = (src - soffs) >> PAGE_SHIFT; - mod.mod_end = soffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - sz = mod.mod_end - soffs; + mod.start = src - soffs; + mod.size = soffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + sz = mod.size - soffs; s = bootstrap_map(&mod); - mod.mod_start = (dst - doffs) >> PAGE_SHIFT; - mod.mod_end = doffs + size; - if ( mod.mod_end > blksz ) - mod.mod_end = blksz; - if ( sz > mod.mod_end - doffs ) - sz = mod.mod_end - doffs; + mod.start = dst - doffs; + mod.size = doffs + size; + if ( mod.size > blksz ) + mod.size = blksz; + if ( sz > mod.size - doffs ) + sz = mod.size - doffs; d = bootstrap_map(&mod); memmove(d + doffs, s + soffs, sz); @@ -475,7 +515,7 @@ static void *__init move_memory( #undef BOOTSTRAP_MAP_LIMIT static uint64_t __init consider_modules( - uint64_t s, uint64_t e, uint32_t size, const module_t *mod, + uint64_t s, uint64_t e, uint32_t size, const struct boot_module *mod, unsigned int nr_mods, unsigned int this_mod) { unsigned int i; @@ -485,8 +525,8 @@ static uint64_t __init consider_modules( for ( i = 0; i < nr_mods ; ++i ) { - uint64_t start = (uint64_t)mod[i].mod_start << PAGE_SHIFT; - uint64_t end = start + PAGE_ALIGN(mod[i].mod_end); + uint64_t start = (uint64_t)mod[i].start; + uint64_t end = start + PAGE_ALIGN(mod[i].size); if ( i == this_mod ) continue; @@ -756,10 +796,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0(const module_t *image, - unsigned long headroom, - module_t *initrd, const char *kextra, - const char *loader) +static struct domain *__init create_dom0( + const struct boot_info *bi, const char *kextra, const char *loader) { struct xen_domctl_createdomain dom0_cfg = { .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, @@ -772,9 +810,14 @@ static struct domain *__init create_dom0(const module_t *image, .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, }; + struct boot_module *image = bootmodule_next_by_kind(bi, BOOTMOD_KERNEL, 0); + struct boot_module *initrd = bootmodule_next_by_kind(bi, BOOTMOD_RAMDISK, 0); struct domain *d; char *cmdline; - domid_t domid; + domid_t domid = 0; + + if ( image == NULL ) + panic("Error creating d%uv0\n", domid); if ( opt_dom0_pvh ) { @@ -801,7 +844,8 @@ static struct domain *__init create_dom0(const module_t *image, panic("Error creating d%uv0\n", domid); /* Grab the DOM0 command line. */ - cmdline = image->string ? __va(image->string) : NULL; + cmdline = (image->string.kind == BOOTSTR_CMDLINE) ? + image->string.bytes : NULL; if ( cmdline || kextra ) { static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; @@ -841,7 +885,7 @@ static struct domain *__init create_dom0(const module_t *image, write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, headroom, initrd, cmdline) != 0 ) + if ( construct_dom0(d, image, initrd, cmdline) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -865,7 +909,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) unsigned int initrdidx, num_parked = 0; multiboot_info_t *mbi; module_t *mod; - unsigned long nr_pages, raw_max_page, modules_headroom, module_map[1]; + unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; bool acpi_boot_table_init_done = false, relocated = false; @@ -910,12 +954,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) mod = __va(mbi->mods_addr); } - loader = (mbi->flags & MBI_LOADERNAME) - ? (char *)__va(mbi->boot_loader_name) : "unknown"; + mb_to_bootinfo(mbi, mod); + + loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) + ? boot_info->arch->boot_loader_name : "unknown"; /* Parse the command-line options. */ - cmdline = cmdline_cook((mbi->flags & MBI_CMDLINE) ? - __va(mbi->cmdline) : NULL, + cmdline = cmdline_cook((boot_info->arch->flags & BOOTINFO_FLAG_X86_CMDLINE) ? + boot_info->cmdline : NULL, loader); if ( (kextra = strstr(cmdline, " -- ")) != NULL ) { @@ -1016,19 +1062,22 @@ void __init noreturn __start_xen(unsigned long mbi_p) bootsym(boot_edd_info_nr)); /* Check that we have at least one Multiboot module. */ - if ( !(mbi->flags & MBI_MODULES) || (mbi->mods_count == 0) ) + if ( !(boot_info->arch->flags & BOOTINFO_FLAG_X86_MODULES) || + (boot_info->nr_mods == 0) ) panic("dom0 kernel not specified. Check bootloader configuration\n"); /* Check that we don't have a silly number of modules. */ - if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) + if ( boot_info->nr_mods > CONFIG_NR_BOOTMODS ) { - mbi->mods_count = CONFIG_NR_BOOTMODS; + boot_info->nr_mods = CONFIG_NR_BOOTMODS ; printk("Excessive multiboot modules - using the first %u only\n", - mbi->mods_count); + boot_info->nr_mods); } - bitmap_fill(module_map, mbi->mods_count); - __clear_bit(0, module_map); /* Dom0 kernel is always first */ + /* Dom0 kernel is the first boot module */ + boot_info->mods[0].kind = BOOTMOD_KERNEL; + if ( boot_info->mods[0].string.len ) + boot_info->mods[0].string.kind = BOOTSTR_CMDLINE; if ( pvh_boot ) { @@ -1052,19 +1101,19 @@ void __init noreturn __start_xen(unsigned long mbi_p) } else if ( efi_enabled(EFI_BOOT) ) memmap_type = "EFI"; - else if ( (e820_raw.nr_map = + else if ( (e820_raw.nr_map = copy_bios_e820(e820_raw.map, ARRAY_SIZE(e820_raw.map))) != 0 ) { memmap_type = "Xen-e820"; } - else if ( mbi->flags & MBI_MEMMAP ) + else if ( boot_info->arch->flags & BOOTINFO_FLAG_X86_MEMMAP ) { memmap_type = "Multiboot-e820"; - while ( bytes < mbi->mmap_length && + while ( bytes < boot_info->arch->mmap_length && e820_raw.nr_map < ARRAY_SIZE(e820_raw.map) ) { - memory_map_t *map = __va(mbi->mmap_addr + bytes); + struct mb_memmap *map = __va(boot_info->arch->mmap_addr + bytes); /* * This is a gross workaround for a BIOS bug. Some bootloaders do @@ -1165,17 +1214,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT); kexec_reserve_area(&boot_e820); - initial_images = mod; - nr_initial_images = mbi->mods_count; - - for ( i = 0; !efi_enabled(EFI_LOADER) && i < mbi->mods_count; i++ ) - { - if ( mod[i].mod_start & (PAGE_SIZE - 1) ) + for ( i = 0; !efi_enabled(EFI_LOADER) && i < boot_info->nr_mods; i++ ) + if ( boot_info->mods[i].start & (PAGE_SIZE - 1) ) panic("Bootloader didn't honor module alignment request\n"); - mod[i].mod_end -= mod[i].mod_start; - mod[i].mod_start >>= PAGE_SHIFT; - mod[i].reserved = 0; - } if ( xen_phys_start ) { @@ -1186,11 +1227,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) * respective reserve_e820_ram() invocation below. No need to * query efi_boot_mem_unused() here, though. */ - mod[mbi->mods_count].mod_start = virt_to_mfn(_stext); - mod[mbi->mods_count].mod_end = __2M_rwdata_end - _stext; + bootmodule_update_start(&boot_info->mods[boot_info->nr_mods], + virt_to_maddr(_stext)); + boot_info->mods[boot_info->nr_mods].size = __2M_rwdata_end - _stext; } - modules_headroom = bzimage_headroom(bootstrap_map(mod), mod->mod_end); + boot_info->mods[0].arch->headroom = bzimage_headroom( + bootstrap_map(&boot_info->mods[0]), + boot_info->mods[0].size); bootstrap_map(NULL); #ifndef highmem_start @@ -1247,7 +1291,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) { /* Don't overlap with modules. */ end = consider_modules(s, e, reloc_size + mask, - mod, mbi->mods_count, -1); + boot_info->mods, boot_info->nr_mods, -1); end &= ~mask; } else @@ -1351,31 +1395,32 @@ void __init noreturn __start_xen(unsigned long mbi_p) } /* Is the region suitable for relocating the multiboot modules? */ - for ( j = mbi->mods_count - 1; j >= 0; j-- ) + for ( j = boot_info->nr_mods - 1; j >= 0; j-- ) { - unsigned long headroom = j ? 0 : modules_headroom; - unsigned long size = PAGE_ALIGN(headroom + mod[j].mod_end); + struct boot_module *mod = boot_info->mods; + unsigned long headroom = mod[j].arch->headroom; + unsigned long size = PAGE_ALIGN(headroom + mod[j].size); - if ( mod[j].reserved ) + if ( mod[j].arch->flags & BOOTMOD_FLAG_X86_RELOCATED ) continue; /* Don't overlap with other modules (or Xen itself). */ end = consider_modules(s, e, size, mod, - mbi->mods_count + relocated, j); + boot_info->nr_mods + relocated, j); if ( highmem_start && end > highmem_start ) continue; if ( s < end && (headroom || - ((end - size) >> PAGE_SHIFT) > mod[j].mod_start) ) + ((end - size) >> PAGE_SHIFT) > mfn_x(mod[j].mfn)) ) { move_memory(end - size + headroom, - (uint64_t)mod[j].mod_start << PAGE_SHIFT, - mod[j].mod_end, 0); - mod[j].mod_start = (end - size) >> PAGE_SHIFT; - mod[j].mod_end += headroom; - mod[j].reserved = 1; + (uint64_t)mod[j].start, + mod[j].size, 0); + bootmodule_update_start(&mod[j], end - size); + mod[j].size += headroom; + mod[j].arch->flags |= BOOTMOD_FLAG_X86_RELOCATED; } } @@ -1387,8 +1432,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) while ( !kexec_crash_area.start ) { /* Don't overlap with modules (or Xen itself). */ - e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), mod, - mbi->mods_count + relocated, -1); + e = consider_modules(s, e, PAGE_ALIGN(kexec_crash_area.size), + boot_info->mods, + boot_info->nr_mods + relocated, -1); if ( s >= e ) break; if ( e > kexec_crash_area_limit ) @@ -1401,13 +1447,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) #endif } - if ( modules_headroom && !mod->reserved ) + if ( boot_info->mods[0].arch->headroom && + !(boot_info->mods[0].arch->flags & BOOTMOD_FLAG_X86_RELOCATED) ) panic("Not enough memory to relocate the dom0 kernel image\n"); - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - uint64_t s = (uint64_t)mod[i].mod_start << PAGE_SHIFT; + uint64_t s = (uint64_t)boot_info->mods[i].start; - reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(mod[i].mod_end)); + reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(boot_info->mods[i].size)); } if ( !xen_phys_start ) @@ -1472,10 +1519,10 @@ void __init noreturn __start_xen(unsigned long mbi_p) ASSERT(j); } map_e = boot_e820.map[j].addr + boot_e820.map[j].size; - for ( j = 0; j < mbi->mods_count; ++j ) + for ( j = 0; j < boot_info->nr_mods; ++j ) { - uint64_t end = pfn_to_paddr(mod[j].mod_start) + - mod[j].mod_end; + uint64_t end = mfn_to_maddr(boot_info->mods[j].mfn) + + boot_info->mods[j].size; if ( map_e < end ) map_e = end; @@ -1548,13 +1595,14 @@ void __init noreturn __start_xen(unsigned long mbi_p) } } - for ( i = 0; i < mbi->mods_count; ++i ) + for ( i = 0; i < boot_info->nr_mods; ++i ) { - set_pdx_range(mod[i].mod_start, - mod[i].mod_start + PFN_UP(mod[i].mod_end)); - map_pages_to_xen((unsigned long)mfn_to_virt(mod[i].mod_start), - _mfn(mod[i].mod_start), - PFN_UP(mod[i].mod_end), PAGE_HYPERVISOR); + set_pdx_range(mfn_x(boot_info->mods[i].mfn), + mfn_x(boot_info->mods[i].mfn) + + PFN_UP(boot_info->mods[i].size)); + map_pages_to_xen((unsigned long)maddr_to_virt(boot_info->mods[i].start), + boot_info->mods[i].mfn, + PFN_UP(boot_info->mods[i].size), PAGE_HYPERVISOR); } #ifdef CONFIG_KEXEC @@ -1704,7 +1752,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) mmio_ro_ranges = rangeset_new(NULL, "r/o mmio ranges", RANGESETF_prettyprint_hex); - xsm_multiboot_init(module_map, mbi); + xsm_bootmodule_init(boot_info); /* * IOMMU-related ACPI table parsing may require some of the system domains @@ -1773,7 +1821,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) init_IRQ(); - microcode_grab_module(module_map, mbi); + microcode_grab_module(boot_info); timer_init(); @@ -1921,8 +1969,11 @@ void __init noreturn __start_xen(unsigned long mbi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = find_first_bit(module_map, mbi->mods_count); - if ( bitmap_weight(module_map, mbi->mods_count) > 1 ) + initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); + if ( initrdidx < boot_info->nr_mods ) + boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; + + if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) printk(XENLOG_WARNING "Multiple initrd candidates, picking module #%u\n", initrdidx); @@ -1931,9 +1982,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(mod, modules_headroom, - initrdidx < mbi->mods_count ? mod + initrdidx : NULL, - kextra, loader); + dom0 = create_dom0(boot_info, kextra, loader); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 42b53a3ca6..dde8202f62 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -51,4 +51,51 @@ struct __packed boot_info { struct arch_boot_info *arch; }; +extern struct boot_info *boot_info; + +static inline unsigned long bootmodule_next_idx_by_kind( + const struct boot_info *bi, bootmodule_kind kind, unsigned long start) +{ + for ( ; start < bi->nr_mods; start++ ) + if ( bi->mods[start].kind == kind ) + return start; + + return bi->nr_mods + 1; +} + +static inline unsigned long bootmodule_count_by_kind( + const struct boot_info *bi, bootmodule_kind kind) +{ + unsigned long count = 0; + int i; + + for ( i=0; i < bi->nr_mods; i++ ) + if ( bi->mods[i].kind == kind ) + count++; + + return count; +} + +static inline struct boot_module *bootmodule_next_by_kind( + const struct boot_info *bi, bootmodule_kind kind, unsigned long start) +{ + for ( ; start < bi->nr_mods; start++ ) + if ( bi->mods[start].kind == kind ) + return &bi->mods[start]; + + return NULL; +} + +static inline void bootmodule_update_start(struct boot_module *b, paddr_t new_start) +{ + b->start = new_start; + b->mfn = maddr_to_mfn(new_start); +} + +static inline void bootmodule_update_mfn(struct boot_module *b, mfn_t new_mfn) +{ + b->mfn = new_mfn; + b->start = mfn_to_maddr(new_mfn); +} + #endif diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h index 8dad03fd3d..930939e925 100644 --- a/xen/include/xsm/xsm.h +++ b/xen/include/xsm/xsm.h @@ -16,8 +16,8 @@ #define __XSM_H__ #include +#include #include -#include /* policy magic number (defined by XSM_MAGIC) */ typedef uint32_t xsm_magic_t; @@ -776,15 +776,14 @@ static inline int xsm_argo_send(const struct domain *d, const struct domain *t) #endif /* XSM_NO_WRAPPERS */ -#ifdef CONFIG_MULTIBOOT -int xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi); -int xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size); -#endif +#ifndef CONFIG_HAS_DEVICE_TREE +int xsm_bootmodule_init(const struct boot_info *bi); +int xsm_bootmodule_policy_init( + const struct boot_info *bi, const unsigned char **policy_buffer, + size_t *policy_size); + +#else -#ifdef CONFIG_HAS_DEVICE_TREE /* * Initialize XSM * @@ -826,15 +825,14 @@ static const inline struct xsm_ops *silo_init(void) #include -#ifdef CONFIG_MULTIBOOT -static inline int xsm_multiboot_init ( - unsigned long *module_map, const multiboot_info_t *mbi) +#ifndef CONFIG_HAS_DEVICE_TREE +static inline int xsm_bootmodule_init(const struct boot_info *bi) { return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + static inline int xsm_dt_init(void) { return 0; diff --git a/xen/xsm/xsm_core.c b/xen/xsm/xsm_core.c index 2286a502e3..8631f3e7bb 100644 --- a/xen/xsm/xsm_core.c +++ b/xen/xsm/xsm_core.c @@ -10,6 +10,9 @@ * as published by the Free Software Foundation. */ +#include +#include +#include #include #include #include @@ -138,26 +141,34 @@ static int __init xsm_core_init(const void *policy_buffer, size_t policy_size) return 0; } -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_init( - unsigned long *module_map, const multiboot_info_t *mbi) +/* + * ifdef'ing this against multiboot is no longer valid as the boot module + * is agnostic and it will be possible to dropped the ifndef should Arm + * adopt boot info + */ +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_init(const struct boot_info *bi) { int ret = 0; - void *policy_buffer = NULL; + const unsigned char *policy_buffer = NULL; size_t policy_size = 0; printk("XSM Framework v" XSM_FRAMEWORK_VERSION " initialized\n"); if ( XSM_MAGIC ) { - ret = xsm_multiboot_policy_init(module_map, mbi, &policy_buffer, - &policy_size); - if ( ret ) - { - bootstrap_map(NULL); - printk(XENLOG_ERR "Error %d initializing XSM policy\n", ret); - return -EINVAL; - } + int ret = xsm_bootmodule_policy_init(bi, &policy_buffer, &policy_size); + bootstrap_map(NULL); + + if ( ret == -ENOENT ) + /* + * The XSM module needs a policy file but one was not located. + * Report as a warning and continue as the XSM module may late + * load a policy file. + */ + printk(XENLOG_WARNING "xsm: starting without a policy loaded!\n"); + else if ( ret ) + panic("Error %d initializing XSM policy\n", ret); } ret = xsm_core_init(policy_buffer, policy_size); @@ -165,9 +176,9 @@ int __init xsm_multiboot_init( return 0; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_init(void) { int ret = 0; @@ -215,9 +226,9 @@ bool __init has_xsm_magic(paddr_t start) return false; } -#endif +#endif /* CONFIG_HAS_DEVICE_TREE */ -#endif +#endif /* CONFIG_XSM */ long cf_check do_xsm_op(XEN_GUEST_HANDLE_PARAM(void) op) { diff --git a/xen/xsm/xsm_policy.c b/xen/xsm/xsm_policy.c index 8dafbc9381..c55ff2a574 100644 --- a/xen/xsm/xsm_policy.c +++ b/xen/xsm/xsm_policy.c @@ -18,61 +18,61 @@ * */ -#include -#ifdef CONFIG_MULTIBOOT -#include -#include -#endif #include +#include +#include + #ifdef CONFIG_HAS_DEVICE_TREE -# include # include #endif -#ifdef CONFIG_MULTIBOOT -int __init xsm_multiboot_policy_init( - unsigned long *module_map, const multiboot_info_t *mbi, - void **policy_buffer, size_t *policy_size) +# include + +#ifndef CONFIG_HAS_DEVICE_TREE +int __init xsm_bootmodule_policy_init( + const struct boot_info *bi, const unsigned char **policy_buffer, + size_t *policy_size) { - int i; - module_t *mod = (module_t *)__va(mbi->mods_addr); - int rc = 0; + unsigned long idx = 0; + int rc = -ENOENT; u32 *_policy_start; unsigned long _policy_len; - /* - * Try all modules and see whichever could be the binary policy. - * Adjust module_map for the module that is the binary policy. - */ - for ( i = mbi->mods_count-1; i >= 1; i-- ) - { - if ( !test_bit(i, module_map) ) - continue; +#ifdef CONFIG_XSM_FLASK_POLICY + /* Initially set to builtin policy, overriden if boot module is found. */ + *policy_buffer = xsm_flask_init_policy; + *policy_size = xsm_flask_init_policy_size; + rc = 0; +#endif - _policy_start = bootstrap_map(mod + i); - _policy_len = mod[i].mod_end; + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, idx); + while ( idx < bi->nr_mods ) + { + _policy_start = bootstrap_map(&bi->mods[idx]); + _policy_len = bi->mods[idx].size; if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC ) { - *policy_buffer = _policy_start; + *policy_buffer = (unsigned char *)_policy_start; *policy_size = _policy_len; printk("Policy len %#lx, start at %p.\n", _policy_len,_policy_start); - __clear_bit(i, module_map); + bi->mods[idx].kind = BOOTMOD_XSM; + rc = 0; break; - } bootstrap_map(NULL); + idx = bootmodule_next_idx_by_kind(bi, BOOTMOD_UNKNOWN, ++idx); } return rc; } -#endif -#ifdef CONFIG_HAS_DEVICE_TREE +#else + int __init xsm_dt_policy_init(void **policy_buffer, size_t *policy_size) { struct bootmodule *mod = boot_module_find_by_kind(BOOTMOD_XSM); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:06:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:06:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362535.592597 (Exim 4.92) (envelope-from ) id 1o9CE7-0005Ta-QC; Wed, 06 Jul 2022 21:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362535.592597; Wed, 06 Jul 2022 21:06:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CE7-0005TR-N7; Wed, 06 Jul 2022 21:06:27 +0000 Received: by outflank-mailman (input) for mailman id 362535; Wed, 06 Jul 2022 21:06:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CE6-0003HV-37 for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:06:26 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7d4658e6-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:06:24 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141508934176.79563610292462; Wed, 6 Jul 2022 14:05:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7d4658e6-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141510; cv=none; d=zohomail.com; s=zohoarc; b=R27CxvffThjlCN85YFvIcEeKXShctWJstvrmFXX9vLPYr2jkMH2DqDxvPcqRau4QcFdJlHcWDQNrhyKm/sD/MbnSNTfmNfe5IPpCDHUObz6CMcTXBJG7aZFtOiZX+h3kF8IQQXb5Hx7xZvbnP1VLmEODEjiD8IsSWhAp35QYFH8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141510; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=E/AB0m5ePJCFrkWnhxRrqf9yCakYmeSAVavi9TF9QYs=; b=L4yilOPz5AgLb7ClL5LK+pDGpZ90TeKwTaYW9OMItBJnzfRMVmiLqD3gxS1kO2vpiEyHFd6RxazobxCQe0Vjz69KkDGeIfsIu17lqitrB7N//kyOvFpbjqadSIQQzK1NNqrWwmalXULTZzZsvz+yrcIlc8/ryJRV6X7lbh5e8uc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141510; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=E/AB0m5ePJCFrkWnhxRrqf9yCakYmeSAVavi9TF9QYs=; b=ecg9RE4yp5kpuFIsVxGnBl9VZ2goLVel8IwuGsyJxtmowPE3FTFUldySQ4y3UXz0 t3UmfzzsH8bNQkEag+uJjDxRy8sq1byW1Op/hYNlRMuGR98vFHT/uIbhQZ9+GR7nm5H 6oQDY6ekC3qJmhRQxQE1P03SR4gmzXyo9KQaRbuE= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 04/18] x86: refactor entrypoints to new boot info Date: Wed, 6 Jul 2022 17:04:39 -0400 Message-Id: <20220706210454.30096-5-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This previous commit added a transition point from multiboot v1 structures to the new boot info structures at the earliest common point for all the x86 entrypoints. The result is that each of the entrypoints would construct a multiboot v1 structure from the structures used by each entrypoint.  This meant that multiboot2, EFI, and PVH all converted their structures over to mutliboot v1 to only be converted again upon entering __start_xen(). This commit drops the translation function and moves the population of the new boot info structures down into the various entrypoints. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/boot/boot_info32.h | 94 +++++++++++ xen/arch/x86/boot/defs.h | 17 +- xen/arch/x86/boot/reloc.c | 187 +++++++++++++++------- xen/arch/x86/efi/efi-boot.h | 96 ++++++----- xen/arch/x86/guest/xen/pvh-boot.c | 64 +++++--- xen/arch/x86/include/asm/guest/pvh-boot.h | 6 +- xen/arch/x86/setup.c | 71 +++----- xen/common/efi/boot.c | 4 +- 8 files changed, 359 insertions(+), 180 deletions(-) create mode 100644 xen/arch/x86/boot/boot_info32.h diff --git a/xen/arch/x86/boot/boot_info32.h b/xen/arch/x86/boot/boot_info32.h new file mode 100644 index 0000000000..01af950efc --- /dev/null +++ b/xen/arch/x86/boot/boot_info32.h @@ -0,0 +1,94 @@ +#ifndef __BOOT_INFO32_H__ +#define __BOOT_INFO32_H__ + +#include "defs.h" + +typedef enum { + BOOTMOD_UNKNOWN, + BOOTMOD_XEN, + BOOTMOD_FDT, + BOOTMOD_KERNEL, + BOOTMOD_RAMDISK, + BOOTMOD_XSM, + BOOTMOD_UCODE, + BOOTMOD_GUEST_DTB, +} bootmodule_kind; + +typedef enum { + BOOTSTR_EMPTY, + BOOTSTR_STRING, + BOOTSTR_CMDLINE, +} bootstring_kind; + +#define BOOTMOD_MAX_STRING 1024 +struct __packed boot_string { + u32 kind; + u64 arch; + + char bytes[BOOTMOD_MAX_STRING]; + u64 len; +}; + +struct __packed arch_bootmodule { + bool relocated; + u32 flags; +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 + u32 headroom; +}; + +struct __packed boot_module { + u32 kind; + u64 start; + u64 mfn; + u64 size; + + u64 arch; + struct boot_string string; +}; + +struct __packed arch_boot_info { + /* uint32_t */ + u32 flags; +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 +#define BOOTINFO_FLAG_X86_APM 1U << 10 + + /* bool */ + u8 xen_guest; + + /* char* */ + u64 boot_loader_name; + u64 kextra; + + /* uint32_t */ + u32 mem_lower; + u32 mem_upper; + + /* uint32_t */ + u32 mmap_length; + /* paddr_t */ + u64 mmap_addr; +}; + +struct __packed boot_info { + /* char* */ + u64 cmdline; + + /* uint32_t */ + u32 nr_mods; + /* struct boot_module* */ + u64 mods; + + /* struct arch_boot_info* */ + u64 arch; +}; + +#endif diff --git a/xen/arch/x86/boot/defs.h b/xen/arch/x86/boot/defs.h index f9840044ec..d742a2b52a 100644 --- a/xen/arch/x86/boot/defs.h +++ b/xen/arch/x86/boot/defs.h @@ -22,11 +22,11 @@ #include "../../../include/xen/stdbool.h" -#define __maybe_unused __attribute__((__unused__)) -#define __packed __attribute__((__packed__)) -#define __stdcall __attribute__((__stdcall__)) +#define __maybe_unused __attribute__((__unused__)) +#define __packed __attribute__((__packed__)) +#define __stdcall __attribute__((__stdcall__)) -#define NULL ((void *)0) +#define NULL ((void *)0) #define ALIGN_UP(arg, align) \ (((arg) + (align) - 1) & ~((typeof(arg))(align) - 1)) @@ -43,9 +43,10 @@ (void) (&_x == &_y); \ _x > _y ? _x : _y; }) -#define _p(val) ((void *)(unsigned long)(val)) +#define _p(val) ((void *)(unsigned long)(val)) +#define _addr(val) ((unsigned long)(void *)(val)) -#define tolower(c) ((c) | 0x20) +#define tolower(c) ((c) | 0x20) typedef unsigned char u8; typedef unsigned short u16; @@ -57,7 +58,7 @@ typedef u16 uint16_t; typedef u32 uint32_t; typedef u64 uint64_t; -#define U16_MAX ((u16)(~0U)) -#define UINT_MAX (~0U) +#define U16_MAX ((u16)(~0U)) +#define UINT_MAX (~0U) #endif /* __BOOT_DEFS_H__ */ diff --git a/xen/arch/x86/boot/reloc.c b/xen/arch/x86/boot/reloc.c index e22bb974bf..4c40cadff6 100644 --- a/xen/arch/x86/boot/reloc.c +++ b/xen/arch/x86/boot/reloc.c @@ -27,6 +27,7 @@ asm ( ); #include "defs.h" +#include "boot_info32.h" #include "../../../include/xen/multiboot.h" #include "../../../include/xen/multiboot2.h" @@ -138,65 +139,116 @@ static struct hvm_start_info *pvh_info_reloc(u32 in) return out; } -static multiboot_info_t *mbi_reloc(u32 mbi_in) +static struct boot_info *mbi_reloc(u32 mbi_in) { + const multiboot_info_t *mbi = _p(mbi_in); + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; int i; - multiboot_info_t *mbi_out; + uint32_t ptr; - mbi_out = _p(copy_mem(mbi_in, sizeof(*mbi_out))); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); - if ( mbi_out->flags & MBI_CMDLINE ) - mbi_out->cmdline = copy_string(mbi_out->cmdline); + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); - if ( mbi_out->flags & MBI_MODULES ) + if ( mbi->flags & MBI_CMDLINE ) + { + ptr = copy_string(mbi->cmdline); + binfo->cmdline = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; + } + + if ( mbi->flags & MBI_MODULES ) { module_t *mods; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; + + /* + * We have to allocate one more module slot here. At some point + * __start_xen() may put Xen image placement into it. + */ + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*bi_mods)); + binfo->nr_mods = mbi->mods_count; + binfo->mods = ptr; + bi_mods = _p(ptr); - mbi_out->mods_addr = copy_mem(mbi_out->mods_addr, - mbi_out->mods_count * sizeof(module_t)); + ptr = alloc_mem((mbi->mods_count + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); - mods = _p(mbi_out->mods_addr); + /* map the +1 allocated for Xen image */ + bi_mods[mbi->mods_count].arch = _addr(&arch_bi_mods[mbi->mods_count]); - for ( i = 0; i < mbi_out->mods_count; i++ ) + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; + + mods = _p(mbi->mods_addr); + + for ( i = 0; i < mbi->mods_count; i++ ) { + bi_mods[i].start = mods[i].mod_start; + bi_mods[i].size = mods[i].mod_end - mods[i].mod_start; + if ( mods[i].string ) - mods[i].string = copy_string(mods[i].string); + { + int j; + char *c = _p(mods[i].string); + + for ( j = 0; *c != '\0'; j++, c++ ) + bi_mods[i].string.bytes[j] = *c; + + bi_mods[i].string.len = j + 1; + } + + bi_mods[i].arch = _addr(&arch_bi_mods[i]); } } - if ( mbi_out->flags & MBI_MEMMAP ) - mbi_out->mmap_addr = copy_mem(mbi_out->mmap_addr, mbi_out->mmap_length); - - if ( mbi_out->flags & MBI_LOADERNAME ) - mbi_out->boot_loader_name = copy_string(mbi_out->boot_loader_name); + if ( mbi->flags & MBI_MEMMAP ) + { + arch_binfo->mmap_addr = copy_mem(mbi->mmap_addr, mbi->mmap_length); + arch_binfo->mmap_length = mbi->mmap_length; + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; + } - /* Mask features we don't understand or don't relocate. */ - mbi_out->flags &= (MBI_MEMLIMITS | - MBI_CMDLINE | - MBI_MODULES | - MBI_MEMMAP | - MBI_LOADERNAME); + if ( mbi->flags & MBI_LOADERNAME ) + { + ptr = copy_string(mbi->boot_loader_name); + arch_binfo->boot_loader_name = ptr; + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; + } - return mbi_out; + return binfo; } -static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) +static struct boot_info *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) { const multiboot2_fixed_t *mbi_fix = _p(mbi_in); const multiboot2_memory_map_t *mmap_src; const multiboot2_tag_t *tag; - module_t *mbi_out_mods = NULL; memory_map_t *mmap_dst; - multiboot_info_t *mbi_out; + struct boot_info *binfo; + struct arch_boot_info *arch_binfo; + struct boot_module *bi_mods; + struct arch_bootmodule *arch_bi_mods; #ifdef CONFIG_VIDEO struct boot_video_info *video = NULL; #endif u32 ptr; unsigned int i, mod_idx = 0; - ptr = alloc_mem(sizeof(*mbi_out)); - mbi_out = _p(ptr); - zero_mem(ptr, sizeof(*mbi_out)); + ptr = alloc_mem(sizeof(*binfo)); + zero_mem(ptr, sizeof(*binfo)); + binfo = _p(ptr); + + ptr = alloc_mem(sizeof(*arch_binfo)); + zero_mem(ptr, sizeof(*arch_binfo)); + binfo->arch = ptr; + arch_binfo = _p(ptr); /* Skip Multiboot2 information fixed part. */ ptr = ALIGN_UP(mbi_in + sizeof(*mbi_fix), MULTIBOOT2_TAG_ALIGN); @@ -206,21 +258,28 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) tag = _p(ALIGN_UP((u32)tag + tag->size, MULTIBOOT2_TAG_ALIGN)) ) { if ( tag->type == MULTIBOOT2_TAG_TYPE_MODULE ) - ++mbi_out->mods_count; + ++binfo->nr_mods; else if ( tag->type == MULTIBOOT2_TAG_TYPE_END ) break; } - if ( mbi_out->mods_count ) + if ( binfo->nr_mods ) { - mbi_out->flags |= MBI_MODULES; /* * We have to allocate one more module slot here. At some point * __start_xen() may put Xen image placement into it. */ - mbi_out->mods_addr = alloc_mem((mbi_out->mods_count + 1) * - sizeof(*mbi_out_mods)); - mbi_out_mods = _p(mbi_out->mods_addr); + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*bi_mods)); + binfo->mods = ptr; + bi_mods = _p(ptr); + + ptr = alloc_mem((binfo->nr_mods + 1) * sizeof(*arch_bi_mods)); + arch_bi_mods = _p(ptr); + + /* map the +1 allocated for Xen image */ + bi_mods[binfo->nr_mods].arch = _addr(&arch_bi_mods[binfo->nr_mods]); + + arch_binfo->flags |= BOOTINFO_FLAG_X86_MODULES; } /* Skip Multiboot2 information fixed part. */ @@ -232,39 +291,38 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) switch ( tag->type ) { case MULTIBOOT2_TAG_TYPE_BOOT_LOADER_NAME: - mbi_out->flags |= MBI_LOADERNAME; ptr = get_mb2_string(tag, string, string); - mbi_out->boot_loader_name = copy_string(ptr); + arch_binfo->boot_loader_name = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_LOADERNAME; break; case MULTIBOOT2_TAG_TYPE_CMDLINE: - mbi_out->flags |= MBI_CMDLINE; ptr = get_mb2_string(tag, string, string); - mbi_out->cmdline = copy_string(ptr); + binfo->cmdline = copy_string(ptr); + arch_binfo->flags |= BOOTINFO_FLAG_X86_CMDLINE; break; case MULTIBOOT2_TAG_TYPE_BASIC_MEMINFO: - mbi_out->flags |= MBI_MEMLIMITS; - mbi_out->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); - mbi_out->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); + arch_binfo->mem_lower = get_mb2_data(tag, basic_meminfo, mem_lower); + arch_binfo->mem_upper = get_mb2_data(tag, basic_meminfo, mem_upper); break; case MULTIBOOT2_TAG_TYPE_MMAP: if ( get_mb2_data(tag, mmap, entry_size) < sizeof(*mmap_src) ) break; - mbi_out->flags |= MBI_MEMMAP; - mbi_out->mmap_length = get_mb2_data(tag, mmap, size); - mbi_out->mmap_length -= sizeof(multiboot2_tag_mmap_t); - mbi_out->mmap_length /= get_mb2_data(tag, mmap, entry_size); - mbi_out->mmap_length *= sizeof(*mmap_dst); + arch_binfo->mmap_length = get_mb2_data(tag, mmap, size); + arch_binfo->mmap_length -= sizeof(multiboot2_tag_mmap_t); + arch_binfo->mmap_length /= get_mb2_data(tag, mmap, entry_size); + arch_binfo->mmap_length *= sizeof(*mmap_dst); - mbi_out->mmap_addr = alloc_mem(mbi_out->mmap_length); + arch_binfo->mmap_addr = alloc_mem(arch_binfo->mmap_length); + arch_binfo->flags |= BOOTINFO_FLAG_X86_MEMMAP; mmap_src = get_mb2_data(tag, mmap, entries); - mmap_dst = _p(mbi_out->mmap_addr); + mmap_dst = _p(arch_binfo->mmap_addr); - for ( i = 0; i < mbi_out->mmap_length / sizeof(*mmap_dst); i++ ) + for ( i = 0; i < arch_binfo->mmap_length / sizeof(*mmap_dst); i++ ) { /* Init size member properly. */ mmap_dst[i].size = sizeof(*mmap_dst); @@ -280,14 +338,27 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) break; case MULTIBOOT2_TAG_TYPE_MODULE: - if ( mod_idx >= mbi_out->mods_count ) + if ( mod_idx >= binfo->nr_mods ) break; - mbi_out_mods[mod_idx].mod_start = get_mb2_data(tag, module, mod_start); - mbi_out_mods[mod_idx].mod_end = get_mb2_data(tag, module, mod_end); + bi_mods[mod_idx].start = get_mb2_data(tag, module, mod_start); + bi_mods[mod_idx].size = get_mb2_data(tag, module, mod_end) + - bi_mods[mod_idx].start; + ptr = get_mb2_string(tag, module, cmdline); - mbi_out_mods[mod_idx].string = copy_string(ptr); - mbi_out_mods[mod_idx].reserved = 0; + if ( ptr ) + { + int i; + char *c = _p(ptr); + + for ( i = 0; *c != '\0'; i++, c++ ) + bi_mods[mod_idx].string.bytes[i] = *c; + + bi_mods[mod_idx].string.len = i + 1; + } + + bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]); + ++mod_idx; break; @@ -344,11 +415,11 @@ static multiboot_info_t *mbi2_reloc(uint32_t mbi_in, uint32_t video_out) video->orig_video_isVGA = 0x23; #endif - return mbi_out; + return binfo; } -void *__stdcall reloc(uint32_t magic, uint32_t in, uint32_t trampoline, - uint32_t video_info) +void *__stdcall reloc( + uint32_t magic, uint32_t in, uint32_t trampoline, uint32_t video_info) { alloc = trampoline; diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h index 4e1a799749..933eb30a28 100644 --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -11,14 +11,17 @@ #include static struct file __initdata ucode; -static multiboot_info_t __initdata mbi = { - .flags = MBI_MODULES | MBI_LOADERNAME -}; + +static struct boot_info __initdata efi_bi; +static struct arch_boot_info __initdata efi_bi_arch; /* * The array size needs to be one larger than the number of modules we * support - see __start_xen(). */ -static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; +static struct boot_module __initdata efi_mods[CONFIG_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata efi_arch_mods[CONFIG_NR_BOOTMODS + 1]; + +static const char *__initdata efi_loader = "PVH Directboot"; static void __init edd_put_string(u8 *dst, size_t n, const char *src) { @@ -269,20 +272,37 @@ static void __init noreturn efi_arch_post_exit_boot(void) : [cr3] "r" (idle_pg_table), [cs] "i" (__HYPERVISOR_CS), [ds] "r" (__HYPERVISOR_DS), - "D" (&mbi) + "D" (&efi_bi) : "memory" ); unreachable(); } -static void __init efi_arch_cfg_file_early(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static struct boot_info __init *efi_arch_bootinfo_init(void) { + int i; + + efi_bi.arch = &efi_bi_arch; + efi_bi.mods = efi_mods; + + for ( i=0; i <= CONFIG_NR_BOOTMODS; i++ ) + efi_bi.mods[i].arch = &efi_arch_mods[i]; + + efi_bi_arch.boot_loader_name = _p(efi_loader); + + efi_bi_arch.flags = BOOTINFO_FLAG_X86_MODULES | + BOOTINFO_FLAG_X86_LOADERNAME; + return &efi_bi; } -static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, - EFI_FILE_HANDLE dir_handle, - const char *section) +static void __init efi_arch_cfg_file_early( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) +{ +} + +static void __init efi_arch_cfg_file_late( + const EFI_LOADED_IMAGE *image, EFI_FILE_HANDLE dir_handle, + const char *section) { union string name; @@ -294,16 +314,15 @@ static void __init efi_arch_cfg_file_late(const EFI_LOADED_IMAGE *image, name.s = get_value(&cfg, "global", "ucode"); if ( name.s ) { - microcode_set_module(mbi.mods_count); + microcode_set_module(efi_bi.nr_mods); split_string(name.s); read_file(dir_handle, s2w(&name), &ucode, NULL); efi_bs->FreePool(name.w); } } -static void __init efi_arch_handle_cmdline(CHAR16 *image_name, - CHAR16 *cmdline_options, - const char *cfgfile_options) +static void __init efi_arch_handle_cmdline( + CHAR16 *image_name, CHAR16 *cmdline_options, const char *cfgfile_options) { union string name; @@ -311,10 +330,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, { name.w = cmdline_options; w2s(&name); - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); } if ( cfgfile_options ) - place_string(&mbi.cmdline, cfgfile_options); + place_string((uint32_t *)efi_bi.cmdline, cfgfile_options); /* Insert image name last, as it gets prefixed to the other options. */ if ( image_name ) { @@ -323,16 +342,10 @@ static void __init efi_arch_handle_cmdline(CHAR16 *image_name, } else name.s = "xen"; - place_string(&mbi.cmdline, name.s); + place_string((uint32_t *)efi_bi.cmdline, name.s); - if ( mbi.cmdline ) - mbi.flags |= MBI_CMDLINE; - /* - * These must not be initialized statically, since the value must - * not get relocated when processing base relocations later. - */ - mbi.boot_loader_name = (long)"EFI"; - mbi.mods_addr = (long)mb_modules; + if ( efi_bi.cmdline ) + efi_bi_arch.flags |= BOOTINFO_FLAG_X86_CMDLINE; } static void __init efi_arch_edd(void) @@ -695,9 +708,8 @@ static void __init efi_arch_memory_setup(void) #undef l2_4G_offset } -static void __init efi_arch_handle_module(const struct file *file, - const CHAR16 *name, - const char *options) +static void __init efi_arch_handle_module( + const struct file *file, const CHAR16 *name, const char *options) { union string local_name; void *ptr; @@ -715,17 +727,25 @@ static void __init efi_arch_handle_module(const struct file *file, w2s(&local_name); /* - * If options are provided, put them in - * mb_modules[mbi.mods_count].string after the filename, with a space - * separating them. place_string() prepends strings and adds separating - * spaces, so the call order is reversed. + * Set module string to filename and if options are provided, put them in + * after the filename, with a space separating them. */ + strlcpy(efi_bi.mods[efi_bi.nr_mods].string.bytes, local_name.s, + BOOTMOD_MAX_STRING); if ( options ) - place_string(&mb_modules[mbi.mods_count].string, options); - place_string(&mb_modules[mbi.mods_count].string, local_name.s); - mb_modules[mbi.mods_count].mod_start = file->addr >> PAGE_SHIFT; - mb_modules[mbi.mods_count].mod_end = file->size; - ++mbi.mods_count; + { + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, " ", + BOOTMOD_MAX_STRING); + strlcat(efi_bi.mods[efi_bi.nr_mods].string.bytes, options, + BOOTMOD_MAX_STRING); + } + efi_bi.mods[efi_bi.nr_mods].string.kind = BOOTSTR_CMDLINE; + + efi_bi.mods[efi_bi.nr_mods].start = file->addr; + efi_bi.mods[efi_bi.nr_mods].mfn = maddr_to_mfn(file->addr); + efi_bi.mods[efi_bi.nr_mods].size = file->size; + + ++efi_bi.nr_mods; efi_bs->FreePool(ptr); } diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c index 834b1ad16b..28cf5df0a3 100644 --- a/xen/arch/x86/guest/xen/pvh-boot.c +++ b/xen/arch/x86/guest/xen/pvh-boot.c @@ -18,6 +18,7 @@ * * Copyright (c) 2017 Citrix Systems Ltd. */ +#include #include #include #include @@ -31,12 +32,28 @@ bool __initdata pvh_boot; uint32_t __initdata pvh_start_info_pa; -static multiboot_info_t __initdata pvh_mbi; -static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; -static const char *__initdata pvh_loader = "PVH Directboot"; +static struct boot_info __initdata pvh_bi; +static struct arch_boot_info __initdata arch_pvh_bi; +static struct boot_module __initdata pvh_mods[CONFIG_NR_BOOTMODS + 1]; +static struct arch_bootmodule __initdata arch_pvh_mods[CONFIG_NR_BOOTMODS + 1]; +static char __initdata *pvh_loader = "PVH Directboot"; -static void __init convert_pvh_info(multiboot_info_t **mbi, - module_t **mod) +static struct boot_info __init *init_pvh_info(void) +{ + int i; + + pvh_bi.arch = &arch_pvh_bi; + pvh_bi.mods = pvh_mods; + + for ( i=0; i <= CONFIG_NR_BOOTMODS; i++ ) + pvh_bi.mods[i].arch = &arch_pvh_mods[i]; + + pvh_bi.arch->boot_loader_name = pvh_loader; + + return &pvh_bi; +} + +static void __init convert_pvh_info(struct boot_info *bi) { const struct hvm_start_info *pvh_info = __va(pvh_start_info_pa); const struct hvm_modlist_entry *entry; @@ -50,23 +67,22 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, * required. The extra element is used to aid relocation. See * arch/x86/setup.c:__start_xen(). */ - if ( ARRAY_SIZE(pvh_mbi_mods) <= pvh_info->nr_modules ) + if ( ARRAY_SIZE(pvh_mods) <= pvh_info->nr_modules ) panic("The module array is too small, size %zu, requested %u\n", - ARRAY_SIZE(pvh_mbi_mods), pvh_info->nr_modules); + ARRAY_SIZE(pvh_mods), pvh_info->nr_modules); /* * Turn hvm_start_info into mbi. Luckily all modules are placed under 4GB * boundary on x86. */ - pvh_mbi.flags = MBI_CMDLINE | MBI_MODULES | MBI_LOADERNAME; + bi->arch->flags = BOOTINFO_FLAG_X86_CMDLINE | BOOTINFO_FLAG_X86_MODULES + | BOOTINFO_FLAG_X86_LOADERNAME; BUG_ON(pvh_info->cmdline_paddr >> 32); - pvh_mbi.cmdline = pvh_info->cmdline_paddr; - pvh_mbi.boot_loader_name = __pa(pvh_loader); + bi->cmdline = _p(__va(pvh_info->cmdline_paddr)); - BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mbi_mods)); - pvh_mbi.mods_count = pvh_info->nr_modules; - pvh_mbi.mods_addr = __pa(pvh_mbi_mods); + BUG_ON(pvh_info->nr_modules >= ARRAY_SIZE(pvh_mods)); + bi->nr_mods = pvh_info->nr_modules; entry = __va(pvh_info->modlist_paddr); for ( i = 0; i < pvh_info->nr_modules; i++ ) @@ -74,15 +90,18 @@ static void __init convert_pvh_info(multiboot_info_t **mbi, BUG_ON(entry[i].paddr >> 32); BUG_ON(entry[i].cmdline_paddr >> 32); - pvh_mbi_mods[i].mod_start = entry[i].paddr; - pvh_mbi_mods[i].mod_end = entry[i].paddr + entry[i].size; - pvh_mbi_mods[i].string = entry[i].cmdline_paddr; + bi->mods[i].start = entry[i].paddr; + bi->mods[i].size = entry[i].size; + if ( entry[i].cmdline_paddr) + { + char *c = _p(__va(entry[i].cmdline_paddr)); + + safe_strcpy(bi->mods[i].string.bytes, c); + bi->mods[i].string.kind = BOOTSTR_CMDLINE; + } } rsdp_hint = pvh_info->rsdp_paddr; - - *mbi = &pvh_mbi; - *mod = pvh_mbi_mods; } static void __init get_memory_map(void) @@ -99,13 +118,16 @@ static void __init get_memory_map(void) sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); } -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) +void __init pvh_init(struct boot_info **bi) { - convert_pvh_info(mbi, mod); + *bi = init_pvh_info(); + convert_pvh_info(*bi); hypervisor_probe(); ASSERT(xen_guest); + (*bi)->arch->xen_guest = xen_guest; + get_memory_map(); } diff --git a/xen/arch/x86/include/asm/guest/pvh-boot.h b/xen/arch/x86/include/asm/guest/pvh-boot.h index 48ffd1a0b1..120baf4ebb 100644 --- a/xen/arch/x86/include/asm/guest/pvh-boot.h +++ b/xen/arch/x86/include/asm/guest/pvh-boot.h @@ -19,13 +19,13 @@ #ifndef __X86_PVH_BOOT_H__ #define __X86_PVH_BOOT_H__ -#include +#include #ifdef CONFIG_PVH_GUEST extern bool pvh_boot; -void pvh_init(multiboot_info_t **mbi, module_t **mod); +void __init pvh_init(struct boot_info **bi); void pvh_print_info(void); #else @@ -34,7 +34,7 @@ void pvh_print_info(void); #define pvh_boot 0 -static inline void pvh_init(multiboot_info_t **mbi, module_t **mod) +static inline void __init pvh_init(struct boot_info **bi) { ASSERT_UNREACHABLE(); } diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 2700f4eb3e..ad37f4a658 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -13,7 +13,6 @@ #include #include #include -#include #include #include #include @@ -273,47 +272,6 @@ custom_param("acpi", parse_acpi_param); struct boot_info __initdata *boot_info; -static void __init mb_to_bootinfo(multiboot_info_t *mbi, module_t *mods) -{ - static struct boot_info __initdata x86_binfo; - static struct arch_boot_info __initdata arch_x86_binfo; - static struct boot_module __initdata x86_mods[CONFIG_NR_BOOTMODS + 1]; - static struct arch_bootmodule __initdata - arch_x86_mods[CONFIG_NR_BOOTMODS + 1]; - int i; - - x86_binfo.arch = &arch_x86_binfo; - x86_binfo.mods = x86_mods; - - x86_binfo.cmdline = __va(mbi->cmdline); - - /* The BOOTINFO_FLAG_X86_* flags are a 1-1 map to MBI_* */ - arch_x86_binfo.flags = mbi->flags; - arch_x86_binfo.mem_upper = mbi->mem_upper; - arch_x86_binfo.mem_lower = mbi->mem_lower; - arch_x86_binfo.mmap_length = mbi->mmap_length; - arch_x86_binfo.mmap_addr = mbi->mmap_addr; - arch_x86_binfo.boot_loader_name = __va(mbi->boot_loader_name); - - x86_binfo.nr_mods = mbi->mods_count; - for ( i = 0; i <= CONFIG_NR_BOOTMODS; i++) - { - x86_mods[i].arch = &arch_x86_mods[i]; - - if ( i < x86_binfo.nr_mods ) - { - bootmodule_update_start(&x86_mods[i], mods[i].mod_start); - x86_mods[i].size = mods[i].mod_end - mods[i].mod_start; - - x86_mods[i].string.len = strlcpy(x86_mods[i].string.bytes, - __va(mods[i].string), - BOOTMOD_MAX_STRING); - } - } - - boot_info = &x86_binfo; -} - unsigned long __init initial_images_nrpages(nodeid_t node) { unsigned long node_start = node_start_pfn(node); @@ -900,15 +858,13 @@ static struct domain *__init create_dom0( /* How much of the directmap is prebuilt at compile time. */ #define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) -void __init noreturn __start_xen(unsigned long mbi_p) +void __init noreturn __start_xen(unsigned long bi_p) { char *memmap_type = NULL; char *cmdline, *kextra, *loader; void *bsp_stack; struct cpu_info *info = get_cpu_info(), *bsp_info; unsigned int initrdidx, num_parked = 0; - multiboot_info_t *mbi; - module_t *mod; unsigned long nr_pages, raw_max_page; int i, j, e820_warn = 0, bytes = 0; unsigned long eb_start, eb_end; @@ -945,16 +901,29 @@ void __init noreturn __start_xen(unsigned long mbi_p) if ( pvh_boot ) { - ASSERT(mbi_p == 0); - pvh_init(&mbi, &mod); + ASSERT(bi_p == 0); + pvh_init(&boot_info); } else { - mbi = __va(mbi_p); - mod = __va(mbi->mods_addr); - } + /* + * Since addresses were setup before virtual addressing was enabled, + * fixup pointers to virtual addresses for proper dereferencing. + */ + boot_info = __va(bi_p); + boot_info->cmdline = __va(boot_info->cmdline); + boot_info->mods = __va(boot_info->mods); + boot_info->arch = __va(boot_info->arch); + + boot_info->arch->boot_loader_name = + __va(boot_info->arch->boot_loader_name); - mb_to_bootinfo(mbi, mod); + for ( i = 0; i <= boot_info->nr_mods; i++ ) + { + boot_info->mods[i].mfn = maddr_to_mfn(boot_info->mods[i].start); + boot_info->mods[i].arch = __va(boot_info->mods[i].arch); + } + } loader = (boot_info->arch->flags & BOOTINFO_FLAG_X86_LOADERNAME) ? boot_info->arch->boot_loader_name : "unknown"; diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..287e48b49a 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -3,6 +3,7 @@ #include #include #include +#include #include #include #include @@ -11,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -1222,6 +1222,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) efi_arch_relocate_image(0); + efi_arch_bootinfo_init(); + if ( use_cfg_file ) { EFI_FILE_HANDLE dir_handle; -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362540.592608 (Exim 4.92) (envelope-from ) id 1o9CFp-0006Uh-Ad; Wed, 06 Jul 2022 21:08:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362540.592608; Wed, 06 Jul 2022 21:08:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFp-0006Ua-7s; Wed, 06 Jul 2022 21:08:13 +0000 Received: by outflank-mailman (input) for mailman id 362540; Wed, 06 Jul 2022 21:08:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFI-0003HV-Oz for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:07:40 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aa017a83-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:07:39 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141516660163.52773294084864; Wed, 6 Jul 2022 14:05:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa017a83-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141519; cv=none; d=zohomail.com; s=zohoarc; b=dFLnhlcLscM2iZicoi/+xsP7p2cnh9am/AF+aWaW7uI6a2L5Q49qlionMeMtt11RcPdGTppxE4RMf0KMM59eOZ8dxScKLyJlWWSa+kdXB87j5lprdsA0wug5lcgvjamjQvyDjembs059kUiNJX3LUW4eom39ICburkk9JUJusUs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141519; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=A6AMQVyod82qQaiZjmSPOr+I3hcKRNwtWIcfRwtz3po=; b=Xosg7reBeL0ZV68oKzyFJGUyXhGKQqw0EV1ygRN6bDcUaOCrwCSUE0QOIZEfmx1yh9h21WYjxavYRbqb1daB7C1DCZ9yNAmBKmrUkvAwEK3eqxT4NW7HxF/4/Z4UFFGR6kDGTtdReMK6ju+3x84Gq8mksMSaNlT0vTT8XDgE45I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141519; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=A6AMQVyod82qQaiZjmSPOr+I3hcKRNwtWIcfRwtz3po=; b=pRirURHJn2l6HPxONdBM7XV9yqVH3KutDYO5aDJWm7M4HkD0/n7clNGmoXavbIvf WDqes1mgJjiFQrsCkUOPGiVbNKw5+KZHdk1MqV2fsHtL7oAWD7r4aXKApWDswYhg7y+ aTVvf/N4MBkJUMECOzgVqHLbL7cNjq9ijztnYcIw= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v1 09/18] x86: introduce abstractions for domain builder Date: Wed, 6 Jul 2022 17:04:44 -0400 Message-Id: <20220706210454.30096-10-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit expands the new boot info structs to provide the initial abstractions for domain builder. Additionally, it reuses the memory allocation structures previously used for dom0, bring the structures and helper functions under the domain builder. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/boot/boot_info32.h | 3 ++ xen/arch/x86/dom0_build.c | 21 +--------- xen/arch/x86/include/asm/bootdomain.h | 30 +++++++++++++++ xen/arch/x86/include/asm/bootinfo.h | 2 + xen/include/xen/bootdomain.h | 52 +++++++++++++++++++++++++ xen/include/xen/bootinfo.h | 4 ++ xen/include/xen/domain_builder.h | 55 +++++++++++++++++++++++++++ 7 files changed, 147 insertions(+), 20 deletions(-) create mode 100644 xen/arch/x86/include/asm/bootdomain.h create mode 100644 xen/include/xen/bootdomain.h create mode 100644 xen/include/xen/domain_builder.h diff --git a/xen/arch/x86/boot/boot_info32.h b/xen/arch/x86/boot/boot_info32.h index 01af950efc..0e7821efb3 100644 --- a/xen/arch/x86/boot/boot_info32.h +++ b/xen/arch/x86/boot/boot_info32.h @@ -87,6 +87,9 @@ struct __packed boot_info { /* struct boot_module* */ u64 mods; + /* struct domain_builder* */ + u64 builder; + /* struct arch_boot_info* */ u64 arch; }; diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 9ca5a99510..e44f7f3c43 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -22,31 +23,11 @@ #include #include -struct memsize { - long nr_pages; - unsigned int percent; - bool minus; -}; - static struct memsize __initdata dom0_size; static struct memsize __initdata dom0_min_size; static struct memsize __initdata dom0_max_size = { .nr_pages = LONG_MAX }; static bool __initdata dom0_mem_set; -static bool __init memsize_gt_zero(const struct memsize *sz) -{ - return !sz->minus && sz->nr_pages; -} - -static unsigned long __init get_memsize(const struct memsize *sz, - unsigned long avail) -{ - unsigned long pages; - - pages = sz->nr_pages + sz->percent * avail / 100; - return sz->minus ? avail - pages : pages; -} - /* * dom0_mem=[min:,][max:,][] * diff --git a/xen/arch/x86/include/asm/bootdomain.h b/xen/arch/x86/include/asm/bootdomain.h new file mode 100644 index 0000000000..6f37ac99dc --- /dev/null +++ b/xen/arch/x86/include/asm/bootdomain.h @@ -0,0 +1,30 @@ +#ifndef __ARCH_X86_BOOTDOMAIN_H__ +#define __ARCH_X86_BOOTDOMAIN_H__ + +struct memsize { + long nr_pages; + unsigned int percent; + bool minus; +}; + +static inline bool memsize_gt_zero(const struct memsize *sz) +{ + return !sz->minus && sz->nr_pages; +} + +static inline unsigned long get_memsize( + const struct memsize *sz, unsigned long avail) +{ + unsigned long pages; + + pages = sz->nr_pages + sz->percent * avail / 100; + return sz->minus ? avail - pages : pages; +} + +struct arch_domain_mem { + struct memsize mem_size; + struct memsize mem_min; + struct memsize mem_max; +}; + +#endif diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index 2fcd576023..f02f4edcd7 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -45,6 +45,8 @@ struct __packed mb_memmap { uint32_t type; }; +struct arch_domain_builder { }; + static inline bool loader_is_grub2(const char *loader_name) { /* GRUB1="GNU GRUB 0.xx"; GRUB2="GRUB 1.xx" */ diff --git a/xen/include/xen/bootdomain.h b/xen/include/xen/bootdomain.h new file mode 100644 index 0000000000..b172d16f4e --- /dev/null +++ b/xen/include/xen/bootdomain.h @@ -0,0 +1,52 @@ +#ifndef __XEN_BOOTDOMAIN_H__ +#define __XEN_BOOTDOMAIN_H__ + +#include +#include + +#include + +#include + +struct domain; + +struct boot_domain { +#define BUILD_PERMISSION_NONE (0) +#define BUILD_PERMISSION_CONTROL (1 << 0) +#define BUILD_PERMISSION_HARDWARE (1 << 1) + uint32_t permissions; + +#define BUILD_FUNCTION_NONE (0) +#define BUILD_FUNCTION_BOOT (1 << 0) +#define BUILD_FUNCTION_CRASH (1 << 1) +#define BUILD_FUNCTION_CONSOLE (1 << 2) +#define BUILD_FUNCTION_STUBDOM (1 << 3) +#define BUILD_FUNCTION_XENSTORE (1 << 30) +#define BUILD_FUNCTION_INITIAL_DOM (1 << 31) + uint32_t functions; + /* On | Off */ +#define BUILD_MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ +#define BUILD_MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ +#define BUILD_MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ + uint32_t mode; + + domid_t domid; + uint8_t uuid[16]; + + uint32_t ncpus; + struct arch_domain_mem meminfo; + +#define BUILD_MAX_SECID_LEN 64 + unsigned char secid[BUILD_MAX_SECID_LEN]; + + struct boot_module *kernel; + struct boot_module *ramdisk; +#define BUILD_MAX_CONF_MODS 2 +#define BUILD_DTB_CONF_IDX 0 +#define BUILD_DOM_CONF_IDX 1 + struct boot_module *configs[BUILD_MAX_CONF_MODS]; + + struct domain *domain; +}; + +#endif diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 477294dc10..1d76d99a40 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -1,6 +1,7 @@ #ifndef __XEN_BOOTINFO_H__ #define __XEN_BOOTINFO_H__ +#include #include #include @@ -15,6 +16,7 @@ typedef enum { BOOTMOD_XSM, BOOTMOD_UCODE, BOOTMOD_GUEST_DTB, + BOOTMOD_GUEST_CONF, } bootmodule_kind; typedef enum { @@ -48,6 +50,8 @@ struct __packed boot_info { uint32_t nr_mods; struct boot_module *mods; + struct domain_builder *builder; + struct arch_boot_info *arch; }; diff --git a/xen/include/xen/domain_builder.h b/xen/include/xen/domain_builder.h new file mode 100644 index 0000000000..79785ef251 --- /dev/null +++ b/xen/include/xen/domain_builder.h @@ -0,0 +1,55 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef XEN_DOMAIN_BUILDER_H +#define XEN_DOMAIN_BUILDER_H + +#include +#include + +#include + +struct domain_builder { + bool fdt_enabled; +#define BUILD_MAX_BOOT_DOMAINS 64 + uint16_t nr_doms; + struct boot_domain domains[BUILD_MAX_BOOT_DOMAINS]; + + struct arch_domain_builder *arch; +}; + +static inline bool builder_is_initdom(struct boot_domain *bd) +{ + return bd->functions & BUILD_FUNCTION_INITIAL_DOM; +} + +static inline bool builder_is_ctldom(struct boot_domain *bd) +{ + return (bd->functions & BUILD_FUNCTION_INITIAL_DOM || + bd->permissions & BUILD_PERMISSION_CONTROL ); +} + +static inline bool builder_is_hwdom(struct boot_domain *bd) +{ + return (bd->functions & BUILD_FUNCTION_INITIAL_DOM || + bd->permissions & BUILD_PERMISSION_HARDWARE ); +} + +static inline struct domain *builder_get_hwdom(struct boot_info *info) +{ + int i; + + for ( i = 0; i < info->builder->nr_doms; i++ ) + { + struct boot_domain *d = &info->builder->domains[i]; + + if ( builder_is_hwdom(d) ) + return d->domain; + } + + return NULL; +} + +void builder_init(struct boot_info *info); +uint32_t builder_create_domains(struct boot_info *info); + +#endif /* XEN_DOMAIN_BUILDER_H */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362543.592619 (Exim 4.92) (envelope-from ) id 1o9CFq-0006kT-IR; Wed, 06 Jul 2022 21:08:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362543.592619; Wed, 06 Jul 2022 21:08:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFq-0006kM-EV; Wed, 06 Jul 2022 21:08:14 +0000 Received: by outflank-mailman (input) for mailman id 362543; Wed, 06 Jul 2022 21:08:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CEG-0003HV-HK for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:06:36 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8429ed03-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:06:35 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141510464427.8856190700619; Wed, 6 Jul 2022 14:05:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8429ed03-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141512; cv=none; d=zohomail.com; s=zohoarc; b=Sj9GD3wXJe1li2qmx6rCzq1a5bPyg/IU4xYez+aVKX/fxmGBiqp1rKPXeyTsThr6aET3CADBk7qdBmJvg8yeJPITrq6RLI8RPsgUZtKTelNBNsmokrLWHNv2PnB5dCGAoY1t1QI6YeqkXndAtzbp16tMdjeN8KV1sJ+enU6D0P8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141512; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=AEMYHg/g52JmQvYb/2PyAV5djmhaoa0EO/NLhuQyF24=; b=Cel0AKW74PFnVWaGk0Nr9FEYBuxI7D17IguiYiq+eJM+i+/zjT7YopKyKdE9jtBJ4eQD10vKCzyGYZfA5kSHsgXCbeZrzBRjTzPUz0SD2TK4py9oGvxsakGYUf8QIXwbkeN3+qy34KfaEFrZ10gzm2/41/MfCxlXOPews7YOc4w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141512; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=AEMYHg/g52JmQvYb/2PyAV5djmhaoa0EO/NLhuQyF24=; b=RPSyGPOqI3Ul6wYg6fIT7iqgt/RRDASbnvyhK7y64L0peQF7aP7hEsbWP1WL4xBQ KREuegYf57Bqj038i0OWJ0jMyNwKwKNBcG/EcgaLClt4w7VZPMP5CgwKIU7HPcXveeZ iPTS1mrz1yYkUGrzTXmYYUcav7Qo0vD2K44nIadw= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v1 05/18] x86: refactor xen cmdline into general framework Date: Wed, 6 Jul 2022 17:04:40 -0400 Message-Id: <20220706210454.30096-6-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This refactors xen cmdline processing into a general framework under the new boot info abstraction. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/include/asm/bootinfo.h | 49 ++++++++++++++++++++++++ xen/arch/x86/setup.c | 58 ++++------------------------- xen/include/xen/bootinfo.h | 11 ++++++ 3 files changed, 68 insertions(+), 50 deletions(-) diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h index e5135e402b..2fcd576023 100644 --- a/xen/arch/x86/include/asm/bootinfo.h +++ b/xen/arch/x86/include/asm/bootinfo.h @@ -45,4 +45,53 @@ struct __packed mb_memmap { uint32_t type; }; +static inline bool loader_is_grub2(const char *loader_name) +{ + /* GRUB1="GNU GRUB 0.xx"; GRUB2="GRUB 1.xx" */ + const char *p = strstr(loader_name, "GRUB "); + return (p != NULL) && (p[5] != '0'); +} + +static inline char *arch_prepare_cmdline(char *p, struct arch_boot_info *arch) +{ + p = p ? : ""; + + /* Strip leading whitespace. */ + while ( *p == ' ' ) + p++; + + /* GRUB2 and PVH don't not include image name as first item on command line. */ + if ( !(arch->xenguest || loader_is_grub2(arch->boot_loader_name)) ) + { + /* Strip image name plus whitespace. */ + while ( (*p != ' ') && (*p != '\0') ) + p++; + while ( *p == ' ' ) + p++; + } + + return p; +} + +static inline char *arch_bootinfo_prepare_cmdline( + char *cmdline, struct arch_boot_info *arch) +{ + if ( !cmdline ) + return ""; + + if ( (arch->kextra = strstr(cmdline, " -- ")) != NULL ) + { + /* + * Options after ' -- ' separator belong to dom0. + * 1. Orphan dom0's options from Xen's command line. + * 2. Skip all but final leading space from dom0's options. + */ + *arch->kextra = '\0'; + arch->kextra += 3; + while ( arch->kextra[1] == ' ' ) arch->kextra++; + } + + + return arch_prepare_cmdline(cmdline, arch); +} #endif diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index ad37f4a658..e4060d6219 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -716,34 +716,6 @@ ignore_param("edid"); */ ignore_param("placeholder"); -static bool __init loader_is_grub2(const char *loader_name) -{ - /* GRUB1="GNU GRUB 0.xx"; GRUB2="GRUB 1.xx" */ - const char *p = strstr(loader_name, "GRUB "); - return (p != NULL) && (p[5] != '0'); -} - -static char * __init cmdline_cook(char *p, const char *loader_name) -{ - p = p ? : ""; - - /* Strip leading whitespace. */ - while ( *p == ' ' ) - p++; - - /* GRUB2 and PVH don't not include image name as first item on command line. */ - if ( xen_guest || loader_is_grub2(loader_name) ) - return p; - - /* Strip image name plus whitespace. */ - while ( (*p != ' ') && (*p != '\0') ) - p++; - while ( *p == ' ' ) - p++; - - return p; -} - static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int limit) { unsigned int n = min(bootsym(bios_e820nr), limit); @@ -754,8 +726,7 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0( - const struct boot_info *bi, const char *kextra, const char *loader) +static struct domain *__init create_dom0(const struct boot_info *bi) { struct xen_domctl_createdomain dom0_cfg = { .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, @@ -804,16 +775,16 @@ static struct domain *__init create_dom0( /* Grab the DOM0 command line. */ cmdline = (image->string.kind == BOOTSTR_CMDLINE) ? image->string.bytes : NULL; - if ( cmdline || kextra ) + if ( cmdline || bi->arch->kextra ) { static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; - cmdline = cmdline_cook(cmdline, loader); + cmdline = arch_prepare_cmdline(cmdline, bi->arch); safe_strcpy(dom0_cmdline, cmdline); - if ( kextra ) + if ( bi->arch->kextra ) /* kextra always includes exactly one leading space. */ - safe_strcat(dom0_cmdline, kextra); + safe_strcat(dom0_cmdline, bi->arch->kextra); /* Append any extra parameters. */ if ( skip_ioapic_setup && !strstr(dom0_cmdline, "noapic") ) @@ -861,7 +832,7 @@ static struct domain *__init create_dom0( void __init noreturn __start_xen(unsigned long bi_p) { char *memmap_type = NULL; - char *cmdline, *kextra, *loader; + char *cmdline, *loader; void *bsp_stack; struct cpu_info *info = get_cpu_info(), *bsp_info; unsigned int initrdidx, num_parked = 0; @@ -929,20 +900,7 @@ void __init noreturn __start_xen(unsigned long bi_p) ? boot_info->arch->boot_loader_name : "unknown"; /* Parse the command-line options. */ - cmdline = cmdline_cook((boot_info->arch->flags & BOOTINFO_FLAG_X86_CMDLINE) ? - boot_info->cmdline : NULL, - loader); - if ( (kextra = strstr(cmdline, " -- ")) != NULL ) - { - /* - * Options after ' -- ' separator belong to dom0. - * 1. Orphan dom0's options from Xen's command line. - * 2. Skip all but final leading space from dom0's options. - */ - *kextra = '\0'; - kextra += 3; - while ( kextra[1] == ' ' ) kextra++; - } + cmdline = bootinfo_prepare_cmdline(boot_info); cmdline_parse(cmdline); /* Must be after command line argument parsing and before @@ -1951,7 +1909,7 @@ void __init noreturn __start_xen(unsigned long bi_p) * We're going to setup domain0 using the module(s) that we stashed safely * above our heap. The second module, if present, is an initrd ramdisk. */ - dom0 = create_dom0(boot_info, kextra, loader); + dom0 = create_dom0(boot_info); if ( !dom0 ) panic("Could not set up DOM0 guest OS\n"); diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index dde8202f62..477294dc10 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -53,6 +53,17 @@ struct __packed boot_info { extern struct boot_info *boot_info; +static inline char *bootinfo_prepare_cmdline(struct boot_info *bi) +{ + bi->cmdline = arch_bootinfo_prepare_cmdline(bi->cmdline, bi->arch); + + if ( *bi->cmdline == ' ' ) + printk(XENLOG_WARNING "%s: leading whitespace left on cmdline\n", + __func__); + + return bi->cmdline; +} + static inline unsigned long bootmodule_next_idx_by_kind( const struct boot_info *bi, bootmodule_kind kind, unsigned long start) { -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362545.592630 (Exim 4.92) (envelope-from ) id 1o9CG0-0007Gm-SX; Wed, 06 Jul 2022 21:08:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362545.592630; Wed, 06 Jul 2022 21:08:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CG0-0007GQ-Nk; Wed, 06 Jul 2022 21:08:24 +0000 Received: by outflank-mailman (input) for mailman id 362545; Wed, 06 Jul 2022 21:08:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CF4-0003HV-Ba for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:07:26 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a1ce176b-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:07:25 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141515007710.3122852676397; Wed, 6 Jul 2022 14:05:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a1ce176b-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141516; cv=none; d=zohomail.com; s=zohoarc; b=kn/VLgVHdrNiMJYv6C8ca0f3cdXI0qCRcFQLsnDcyMGQ1mki8dYJaC3NtgtMnjfgYBfWCjCcWod+iM56MB7VjEdyNP8q1wWzOTBPgidoReSQ46jpnhM77OeMjLtS9WasAHtekYzXvH7tBW3IoEpMn7uttyv5zClFn5gUZTO6KFI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141516; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=HKjJTQMRAU0h0mGoRHhFPzIn/dQiHWAlt9SCRVrEJ6w=; b=Tpb6tPRG3vu03zYlMxnzKUhhBtf1S5wuRqC8BBy2YpSyaWrcZEQRzU+/Jw+8zg14X2ifEFgBihC0cWFnLBYSX1XlJ3Tjg2XjkCDf3hYgaN5QH4ymcLFJHwHxSAILg0xL/yxB6gkEPIGLaxgxyx/CU0Q6YB3gIHZMlSb1h4MrGyE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141516; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=HKjJTQMRAU0h0mGoRHhFPzIn/dQiHWAlt9SCRVrEJ6w=; b=mARI0734kr2pktMr8wWc2nsNy5B6xK65nm0w1Rh8HNsFD0TZD1DC4JRFO1tG5/nh 53OJP4pGyVDIdK8mbuWT30tkLnig2RETxO93J7Kq9ijq2BdngSh0PYZBX72uFlEMPVr iquDN14+baAoOa9kZEiPo89oz1Fc4x7gHiuF2w8M= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v1 08/18] kconfig: introduce domain builder config option Date: Wed, 6 Jul 2022 17:04:43 -0400 Message-Id: <20220706210454.30096-9-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Hyperlaunch domain builder is the consolidated boot time domain building logic framework. This commit introduces the first config option for the domain builder to control support for loading the domain configurations via the flattened device tree. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/common/Kconfig | 1 + xen/common/domain-builder/Kconfig | 15 +++++++++++++++ 2 files changed, 16 insertions(+) create mode 100644 xen/common/domain-builder/Kconfig diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 9fc6683932..5a1c40e392 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -355,6 +355,7 @@ config ARGO If unsure, say N. +source "common/domain-builder/Kconfig" source "common/sched/Kconfig" config CRYPTO diff --git a/xen/common/domain-builder/Kconfig b/xen/common/domain-builder/Kconfig new file mode 100644 index 0000000000..893038cab3 --- /dev/null +++ b/xen/common/domain-builder/Kconfig @@ -0,0 +1,15 @@ + +menu "Domain Builder Features" + +config BUILDER_FDT + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED + select CORE_DEVICE_TREE + ---help--- + Enables the ability to configure the domain builder using a + flattened device tree. + + This feature is currently experimental. + + If unsure, say N. + +endmenu -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362546.592635 (Exim 4.92) (envelope-from ) id 1o9CG1-0007KG-4x; Wed, 06 Jul 2022 21:08:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362546.592635; Wed, 06 Jul 2022 21:08:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CG0-0007Iu-Vc; Wed, 06 Jul 2022 21:08:24 +0000 Received: by outflank-mailman (input) for mailman id 362546; Wed, 06 Jul 2022 21:08:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CES-0003HV-Iv for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:06:48 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8b0347d4-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:06:47 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141512149369.82004181151626; Wed, 6 Jul 2022 14:05:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b0347d4-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141514; cv=none; d=zohomail.com; s=zohoarc; b=AODrPQsGitTUc7ZsIrIKbdIQa6xWtcDmC6BK+chBmc+swcdHPajSLVx5jV/R1hPrR4dQqrrMSykfgyZu0oa+ikEIuYMa9ow7IODBaHHTyNYiWMdS/4D/lphTFwtjtOGY4z25kIRmdhC1xkIs9U65WiS+1Q6S82dxgv4bKphD7X0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141514; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=Rrvu8k3I40Yg9tyliHrdCDkFpt7JnYcfPTHvIPVr/5k=; b=eWvjAAp/PHtnXwC5AvtBUaLEcij1Ks1iaHLsJtJAs+DUFcbS4c3nS/yqosD8whlzwfcPF2uRx+i02QgAuIsJn9SNACDfFzRv7j/5ke4vGGlNsAyX34LZIc6qaxFQtG+Wz+YeIJT7ZY5uXZIc/0usrp5rTGOH/8k97VkOYMfLyXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141514; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=Rrvu8k3I40Yg9tyliHrdCDkFpt7JnYcfPTHvIPVr/5k=; b=FFl9IBi7r3Mtikob3O2PQ2vXENqfnpaqW4alNDMGkB4v5T+OWnYywPb/6ISTOLTs cKOSjO+Adt7DQVz5SuZR2tpvdckxGm1flVmsWtaH2/KRwwb38HTuRME0PgLSk30999N KGHKhtDy9EA8B6X3CJx2gGeN3KB3piigHb8wQovQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Volodymyr Babchuk Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v1 06/18] fdt: make fdt handling reusable across arch Date: Wed, 6 Jul 2022 17:04:41 -0400 Message-Id: <20220706210454.30096-7-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This refactors reusable code from Arm's bootfdt.c and device-tree.h that is general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is introduced for when the ability of parsing DTB files is needed by a capability such as hyperlaunch. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/arm/bootfdt.c | 115 +---------------------------- xen/common/Kconfig | 4 ++ xen/common/Makefile | 3 +- xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++ xen/include/xen/device_tree.h | 50 +------------ xen/include/xen/fdt.h | 79 ++++++++++++++++++++ 6 files changed, 218 insertions(+), 164 deletions(-) create mode 100644 xen/common/fdt.c create mode 100644 xen/include/xen/fdt.h diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..ddedb55fe7 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -14,53 +14,11 @@ #include #include #include +#include #include #include #include -static bool __init device_tree_node_matches(const void *fdt, int node, - const char *match) -{ - const char *name; - size_t match_len; - - name = fdt_get_name(fdt, node, NULL); - match_len = strlen(match); - - /* Match both "match" and "match@..." patterns but not - "match-foo". */ - return strncmp(name, match, match_len) == 0 - && (name[match_len] == '@' || name[match_len] == '\0'); -} - -static bool __init device_tree_node_compatible(const void *fdt, int node, - const char *match) -{ - int len, l; - const void *prop; - - prop = fdt_getprop(fdt, node, "compatible", &len); - if ( prop == NULL ) - return false; - - while ( len > 0 ) { - if ( !dt_compat_cmp(prop, match) ) - return true; - l = strlen(prop) + 1; - prop += l; - len -= l; - } - - return false; -} - -void __init device_tree_get_reg(const __be32 **cell, u32 address_cells, - u32 size_cells, u64 *start, u64 *size) -{ - *start = dt_next_cell(address_cells, cell); - *size = dt_next_cell(size_cells, cell); -} - static int __init device_tree_get_meminfo(const void *fdt, int node, const char *prop_name, u32 address_cells, u32 size_cells, @@ -108,77 +66,6 @@ static int __init device_tree_get_meminfo(const void *fdt, int node, return 0; } -u32 __init device_tree_get_u32(const void *fdt, int node, - const char *prop_name, u32 dflt) -{ - const struct fdt_property *prop; - - prop = fdt_get_property(fdt, node, prop_name, NULL); - if ( !prop || prop->len < sizeof(u32) ) - return dflt; - - return fdt32_to_cpu(*(uint32_t*)prop->data); -} - -/** - * device_tree_for_each_node - iterate over all device tree sub-nodes - * @fdt: flat device tree. - * @node: parent node to start the search from - * @func: function to call for each sub-node. - * @data: data to pass to @func. - * - * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. - * - * Returns 0 if all nodes were iterated over successfully. If @func - * returns a value different from 0, that value is returned immediately. - */ -int __init device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data) -{ - /* - * We only care about relative depth increments, assume depth of - * node is 0 for simplicity. - */ - int depth = 0; - const int first_node = node; - u32 address_cells[DEVICE_TREE_MAX_DEPTH]; - u32 size_cells[DEVICE_TREE_MAX_DEPTH]; - int ret; - - do { - const char *name = fdt_get_name(fdt, node, NULL); - u32 as, ss; - - if ( depth >= DEVICE_TREE_MAX_DEPTH ) - { - printk("Warning: device tree node `%s' is nested too deep\n", - name); - continue; - } - - as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; - ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; - - address_cells[depth] = device_tree_get_u32(fdt, node, - "#address-cells", as); - size_cells[depth] = device_tree_get_u32(fdt, node, - "#size-cells", ss); - - /* skip the first node */ - if ( node != first_node ) - { - ret = func(fdt, node, name, depth, as, ss, data); - if ( ret != 0 ) - return ret; - } - - node = fdt_next_node(fdt, node, &depth); - } while ( node >= 0 && depth > 0 ); - - return 0; -} - static int __init process_memory_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 41a67891bc..9fc6683932 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -31,8 +31,12 @@ config HAS_ALTERNATIVE config HAS_COMPAT bool +config CORE_DEVICE_TREE + bool + config HAS_DEVICE_TREE bool + select CORE_DEVICE_TREE config HAS_EX_TABLE bool diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..ebd3e2d659 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -10,6 +10,7 @@ obj-y += domain.o obj-y += event_2l.o obj-y += event_channel.o obj-y += event_fifo.o +obj-$(CONFIG_CORE_DEVICE_TREE) += fdt.o obj-$(CONFIG_CRASH_DEBUG) += gdbstub.o obj-$(CONFIG_GRANT_TABLE) += grant_table.o obj-y += guestcopy.o @@ -73,7 +74,7 @@ obj-y += sched/ obj-$(CONFIG_UBSAN) += ubsan/ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ -obj-$(CONFIG_HAS_DEVICE_TREE) += libfdt/ +obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/ CONF_FILE := $(if $(patsubst /%,,$(KCONFIG_CONFIG)),$(objtree)/)$(KCONFIG_CONFIG) $(obj)/config.gz: $(CONF_FILE) diff --git a/xen/common/fdt.c b/xen/common/fdt.c new file mode 100644 index 0000000000..ed9347e5f7 --- /dev/null +++ b/xen/common/fdt.c @@ -0,0 +1,131 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012-2014 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#include +#include +#include +#include +#include + +bool __init device_tree_node_matches( + const void *fdt, int node, const char *match) +{ + const char *name; + size_t match_len; + + name = fdt_get_name(fdt, node, NULL); + match_len = strlen(match); + + /* Match both "match" and "match@..." patterns but not + "match-foo". */ + return strncmp(name, match, match_len) == 0 + && (name[match_len] == '@' || name[match_len] == '\0'); +} + +bool __init device_tree_node_compatible( + const void *fdt, int node, const char *match) +{ + int len, l; + int mlen; + const void *prop; + + mlen = strlen(match); + + prop = fdt_getprop(fdt, node, "compatible", &len); + if ( prop == NULL ) + return false; + + while ( len > 0 ) { + if ( !dt_compat_cmp(prop, match) ) + return true; + l = strlen(prop) + 1; + prop += l; + len -= l; + } + + return false; +} + +void __init device_tree_get_reg( + const __be32 **cell, u32 address_cells, u32 size_cells, u64 *start, + u64 *size) +{ + *start = dt_next_cell(address_cells, cell); + *size = dt_next_cell(size_cells, cell); +} + +u32 __init device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt) +{ + const struct fdt_property *prop; + + prop = fdt_get_property(fdt, node, prop_name, NULL); + if ( !prop || prop->len < sizeof(u32) ) + return dflt; + + return fdt32_to_cpu(*(uint32_t*)prop->data); +} + +/** + * device_tree_for_each_node - iterate over all device tree sub-nodes + * @fdt: flat device tree. + * @node: parent node to start the search from + * @func: function to call for each sub-node. + * @data: data to pass to @func. + * + * Any nodes nested at DEVICE_TREE_MAX_DEPTH or deeper are ignored. + * + * Returns 0 if all nodes were iterated over successfully. If @func + * returns a value different from 0, that value is returned immediately. + */ +int __init device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data) +{ + /* + * We only care about relative depth increments, assume depth of + * node is 0 for simplicity. + */ + int depth = 0; + const int first_node = node; + u32 address_cells[DEVICE_TREE_MAX_DEPTH]; + u32 size_cells[DEVICE_TREE_MAX_DEPTH]; + int ret; + + do { + const char *name = fdt_get_name(fdt, node, NULL); + u32 as, ss; + + if ( depth >= DEVICE_TREE_MAX_DEPTH ) + { + printk("Warning: device tree node `%s' is nested too deep\n", + name); + continue; + } + + as = depth > 0 ? address_cells[depth-1] : DT_ROOT_NODE_ADDR_CELLS_DEFAULT; + ss = depth > 0 ? size_cells[depth-1] : DT_ROOT_NODE_SIZE_CELLS_DEFAULT; + + address_cells[depth] = device_tree_get_u32(fdt, node, + "#address-cells", as); + size_cells[depth] = device_tree_get_u32(fdt, node, + "#size-cells", ss); + + /* skip the first node */ + if ( node != first_node ) + { + ret = func(fdt, node, name, depth, as, ss, data); + if ( ret != 0 ) + return ret; + } + + node = fdt_next_node(fdt, node, &depth); + } while ( node >= 0 && depth > 0 ); + + return 0; +} diff --git a/xen/include/xen/device_tree.h b/xen/include/xen/device_tree.h index 430a1ef445..c98c898ffc 100644 --- a/xen/include/xen/device_tree.h +++ b/xen/include/xen/device_tree.h @@ -14,13 +14,12 @@ #include #include #include +#include #include #include #include #include -#define DEVICE_TREE_MAX_DEPTH 16 - /* * Struct used for matching a device */ @@ -158,17 +157,8 @@ struct dt_raw_irq { #define dt_irq(irq) ((irq)->irq) #define dt_irq_flags(irq) ((irq)->flags) -typedef int (*device_tree_node_func)(const void *fdt, - int node, const char *name, int depth, - u32 address_cells, u32 size_cells, - void *data); - extern const void *device_tree_flattened; -int device_tree_for_each_node(const void *fdt, int node, - device_tree_node_func func, - void *data); - /** * dt_unflatten_host_device_tree - Unflatten the host device tree * @@ -213,14 +203,6 @@ extern const struct dt_device_node *dt_interrupt_controller; struct dt_device_node * dt_find_interrupt_controller(const struct dt_device_match *matches); -#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) -#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) -#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) - -/* Default #address and #size cells */ -#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 -#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 - #define dt_for_each_property_node(dn, pp) \ for ( pp = dn->properties; pp != NULL; pp = pp->next ) @@ -230,36 +212,6 @@ dt_find_interrupt_controller(const struct dt_device_match *matches); #define dt_for_each_child_node(dt, dn) \ for ( dn = dt->child; dn != NULL; dn = dn->sibling ) -/* Helper to read a big number; size is in cells (not bytes) */ -static inline u64 dt_read_number(const __be32 *cell, int size) -{ - u64 r = 0; - - while ( size-- ) - r = (r << 32) | be32_to_cpu(*(cell++)); - return r; -} - -/* Helper to convert a number of cells to bytes */ -static inline int dt_cells_to_size(int size) -{ - return (size * sizeof (u32)); -} - -/* Helper to convert a number of bytes to cells, rounds down */ -static inline int dt_size_to_cells(int bytes) -{ - return (bytes / sizeof(u32)); -} - -static inline u64 dt_next_cell(int s, const __be32 **cellp) -{ - const __be32 *p = *cellp; - - *cellp = p + s; - return dt_read_number(p, s); -} - static inline const char *dt_node_full_name(const struct dt_device_node *np) { return (np && np->full_name) ? np->full_name : ""; diff --git a/xen/include/xen/fdt.h b/xen/include/xen/fdt.h new file mode 100644 index 0000000000..00f9f3792f --- /dev/null +++ b/xen/include/xen/fdt.h @@ -0,0 +1,79 @@ +/* + * Flattened Device Tree + * + * Copyright (C) 2012 Citrix Systems, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + */ +#ifndef __XEN_FDT_H__ +#define __XEN_FDT_H__ + +#include +#include +#include + +#define DEVICE_TREE_MAX_DEPTH 16 + +/* Default #address and #size cells */ +#define DT_ROOT_NODE_ADDR_CELLS_DEFAULT 2 +#define DT_ROOT_NODE_SIZE_CELLS_DEFAULT 1 + +#define dt_prop_cmp(s1, s2) strcmp((s1), (s2)) +#define dt_node_cmp(s1, s2) strcasecmp((s1), (s2)) +#define dt_compat_cmp(s1, s2) strcasecmp((s1), (s2)) + +/* Helper to read a big number; size is in cells (not bytes) */ +static inline u64 dt_read_number(const __be32 *cell, int size) +{ + u64 r = 0; + + while ( size-- ) + r = (r << 32) | be32_to_cpu(*(cell++)); + return r; +} + +/* Helper to convert a number of cells to bytes */ +static inline int dt_cells_to_size(int size) +{ + return (size * sizeof (u32)); +} + +/* Helper to convert a number of bytes to cells, rounds down */ +static inline int dt_size_to_cells(int bytes) +{ + return (bytes / sizeof(u32)); +} + +static inline u64 dt_next_cell(int s, const __be32 **cellp) +{ + const __be32 *p = *cellp; + + *cellp = p + s; + return dt_read_number(p, s); +} + + +bool __init device_tree_node_matches( + const void *fdt, int node, const char *match); + +bool __init device_tree_node_compatible( + const void *fdt, int node, const char *match); + +void __init device_tree_get_reg( + const __be32 **cell, u32 address_cells, u32 size_cells, u64 *start, + u64 *size); + +u32 __init device_tree_get_u32( + const void *fdt, int node, const char *prop_name, u32 dflt); + +typedef int (*device_tree_node_func)( + const void *fdt, int node, const char *name, int depth, u32 address_cells, + u32 size_cells, void *data); + +int device_tree_for_each_node( + const void *fdt, int node, device_tree_node_func func, void *data); + + +#endif /* __XEN_FDT_H__ */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362548.592653 (Exim 4.92) (envelope-from ) id 1o9CGA-0008Fi-MO; Wed, 06 Jul 2022 21:08:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362548.592653; Wed, 06 Jul 2022 21:08:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGA-0008F4-Ex; Wed, 06 Jul 2022 21:08:34 +0000 Received: by outflank-mailman (input) for mailman id 362548; Wed, 06 Jul 2022 21:08:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CEo-0003HV-Mr for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:07:11 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 980f365c-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:07:09 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141513567683.6191702459943; Wed, 6 Jul 2022 14:05:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 980f365c-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141515; cv=none; d=zohomail.com; s=zohoarc; b=hH8iSSh7V0tdIXTzS1Ubw9vFs83PaKUcRziQHL+OnMqNVNS+E5snNAWFFY5OgSg7/Gn3kZdza2/V1tL0Gjl7aAPtFzGdnkjby2Uckzh9VRrTTaMC5aZGjQZgi4gcQBUSIMAgp9PQ+PCiyz4TtSOizHarcl43IQz+VbnCbrkgkwM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141515; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=J77O8suVeejM9qg7gYOMo0/ft/qDVUpd9vIxutDZU4s=; b=PixWEodVN4GaUxiV7hsApDpWo0eO9647EbCs+EHkpFT7xrLOaxCIVbyEZyqhxqp89wC7ITrCcfNZWZNQ0gyliRHsIoJ+BPETPEVBEIuwOmwH0hd9vpiX0RHoz40lmz/ELE6LeFvijQnw1K9hKBctI+tRo/7TAog5aCu502CgyUI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141515; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Reply-To; bh=J77O8suVeejM9qg7gYOMo0/ft/qDVUpd9vIxutDZU4s=; b=QTlDaaVUp7U5CqwKiB/RSI74HNKmbgltsH7KOnzePAGUpWbfNmJ/rarveUhifBDu EYaHRDLi8V5n4IjeHtUC/HUFz/wS6mv+XhJ1oEU9BM8/SSW2TdMEkndQRIlFt9VZoSa 9khOUqhvWovwIACE+Kb5mpEKGTUOyPIdIzZ2JUy8= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v1 07/18] docs: update hyperlaunch device tree documentation Date: Wed, 6 Jul 2022 17:04:42 -0400 Message-Id: <20220706210454.30096-8-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit is to update the hyperlaunch device tree documentation to align with the DTB parsing implementation. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- .../designs/launch/hyperlaunch-devicetree.rst | 497 +++++++++++------- 1 file changed, 306 insertions(+), 191 deletions(-) diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst b/docs/designs/launch/hyperlaunch-devicetree.rst index b49c98cfbd..ae1a786d0b 100644 --- a/docs/designs/launch/hyperlaunch-devicetree.rst +++ b/docs/designs/launch/hyperlaunch-devicetree.rst @@ -13,12 +13,268 @@ difference is the introduction of the ``hypervisor`` node that is under the 2. Allows for the domain construction information to easily be sanitized by simple removing the ``/chosen/hypervisor`` node. + +The Hypervisor node +------------------- + +The ``hypervisor`` node is a top level container for the domains that will be built +by hypervisor on start up. The node will be named ``hypervisor`` with a ``compatible`` +property to identify which hypervisors the configuration is intended. The hypervisor +node will consist of one or more config nodes and one or more domain nodes. + +Properties +"""""""""" + +compatible + Identifies which hypervisors the configuration is compatible. Required. + + Format: "hypervisor,", e.g "hypervisor,xen" + +Child Nodes +""""""""""" + +* config +* domain + +Config Node +----------- + +A ``config`` node is for passing configuration data and identifying any boot +modules that is of interest to the hypervisor. For example this would be where +Xen would be informed of microcode or XSM policy locations. Each ``config`` +node will require a unique device-tree compliant name as there may be one or +more ``config`` nodes present in a single dtb file. To identify which +hypervisor the configuration is intended, the required ``compatible`` property +must be present. + +While the config node is not meant to replace the hypervisor commandline, there +may be cases where it is better suited for passing configuration details at +boot time. This additional information may be carried in properties assigned +to a ``config`` node. If there are any boot modules that are intended for the +hypervisor, then a ``module`` child node should be provided to identify the +boot module. + +Properties +"""""""""" + +compatible + Identifies the hypervisor the confiugration is intended. Required. + + Format: ",config", e.g "xen,config" + +bootargs + This is used to provide the boot params for Xen. + + Format: String, e.g. "flask=silo" + +Child Nodes +""""""""""" + +* module + +Domain Node +----------- + +A ``domain`` node is for describing the construction of a domain. Since there +may be one or more domain nodes, each one requires a unique, DTB compliant name +and a ``compatible`` property to identify as a domain node. + +A ``domain`` node may provide a ``domid`` property which will be used as the +requested domain id for the domain with a value of “0” signifying to use the +next available domain id, which is the default behavior if omitted. It should +be noted that a domain configuration is not able to request a domid of “0”. +Beyond that a domain node may have any of the following optional properties. + +Properties +"""""""""" + +compatible + Identifies the node as a domain node and for which hypervisor. Required. + + Format: ",domain", e.g "xen,domain" + +domid + Identifies the domid requested to assign to the domain. + + Format: Integer, e.g <0> + +permissions + This sets what Discretionary Access Control permissions + a domain is assigned. Optional, default is none. + + Format: Bitfield, e.g <3> or <0x00000003> + + PERMISSION_NONE (0) + PERMISSION_CONTROL (1 << 0) + PERMISSION_HARDWARE (1 << 1) + +functions + This identifies what system functions a domain will fulfill. + Optional, the default is none. + + Format: Bitfield, e.g <3221225487> or <0xC0000007> + + FUNCTION_NONE (0) + FUNCTION_BOOT (1 << 0) + FUNCTION_CRASH (1 << 1) + FUNCTION_CONSOLE (1 << 2) + FUNCTION_XENSTORE (1 << 30) + FUNCTION_LEGACY_DOM0 (1 << 31) + +.. note:: The `functions` bits that have been selected to indicate + ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits + (30, 31) such that should these features ever be fully replaced or retired, + the flags may be dropped without leaving a gap in the flag set. + +mode + The mode the domain will be executed under. Required. + + Format: Bitfield, e.g <5> or <0x00000005> + + MODE_PARAVIRTUALIZED (1 << 0) PV | PVH/HVM + MODE_ENABLE_DEVICE_MODEL (1 << 1) HVM | PVH + MODE_LONG (1 << 2) 64 BIT | 32 BIT + +domain-uuid + A globally unique identifier for the domain. Optional, + the default is NULL. + + Format: Byte Array, e.g [B3 FB 98 FB 8F 9F 67 A3] + +cpus + The number of vCPUs to be assigned to the domain. Optional, + the default is “1”. + + Format: Integer, e.g <0> + +memory + The amount of memory to assign to the domain, in KBs. This field uses a DTB + Reg which contains a start and size. For memory allocation start may or may + not have significance but size will always be used for the amount of memory + Required. + + Format: String min: | max: | , e.g. "256M" + +security-id + The security identity to be assigned to the domain when XSM + is the access control mechanism being used. Optional, + the default is “system_u:system_r:domU_t”. + + Format: string, e.g. "system_u:system_r:domU_t" + +Child Nodes +""""""""""" + +* module + +Module node +----------- + +This node describes a boot module loaded by the boot loader. A ``module`` node +will often appear repeatedly and will require a unique and DTB compliant name +for each instance. The compatible property is required to identify that the +node is a ``module`` node, the type of boot module, and what it represents. + +Depending on the type of boot module, the ``module`` node will require either a +``module-index`` or ``module-addr`` property must be present. They provide the +boot module specific way of locating the boot module in memory. + +Properties +"""""""""" + +compatible + This identifies what the module is and thus what the hypervisor + should use the module for during domain construction. Required. + + Format: "module,"[, "module,"] + module type: kernel, ramdisk, device-tree, microcode, xsm-policy, + config + + locating type: index, addr + +module-index + This identifies the index for this module when in a module chain. + Required for multiboot environments. + + Format: Integer, e.g. <0> + +module-addr + This identifies where in memory this module is located. Required for + non-multiboot environments. + + Format: DTB Reg , e.g. <0x0 0x20000> + +bootargs + This is used to provide the boot params to kernel modules. + + Format: String, e.g. "ro quiet" + +.. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. + Example Configuration --------------------- -Below are two example device tree definitions for the hypervisor node. The -first is an example of a multiboot-based configuration for x86 and the second -is a module-based configuration for Arm. +Below are examples device tree definitions for the hypervisor node. The first +is an example of booting a dom0 only configuration. Afterh that are a +multiboot-based configuration for x86 and a module-based configuration for Arm. + +Multiboot x86 Configuration Dom0-only: +"""""""""""""""""""""""""""""""""""""" +The following dts file can be provided to the Device Tree compiler, ``dtc``, to +produce a dtb file. +:: + + /dts-v1/; + + / { + chosen { + hypervisor { + compatible = "hypervisor,xen"; + + dom0 { + compatible = "xen,domain"; + + domid = <0>; + + permissions = <3>; + functions = <0xC000000F>; + mode = <5>; + + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 13 F0 8C]; + + cpus = <1>; + memory = <0x0 0x20000000>; + + kernel { + compatible = "module,kernel", "module,index"; + module-index = <1>; + }; + }; + + }; + }; + }; + +The resulting dtb file, in this case dom0-only.dtb, can then be used with a +GRUB menuentry as such, +:: + + menuentry 'Devuan GNU/Linux, with Xen hyperlaunch' { + insmod part_gpt + insmod ext2 + set root='hd0,gpt2' + + echo 'Loading Xen hyperlaunch ...' + + multiboot2 /xen.gz placeholder sync_console + echo 'Loading Dom0 hyperlaunch dtb ...' + module2 --nounzip /dom0-only.dtb + echo 'Loading Linux 5.4.36+ ...' + module2 /vmlinuz-5.4.36+ placeholder root=/dev/mapper/test01--vg-root ro quiet + echo 'Loading initial ramdisk ...' + module2 --nounzip /initrd.img-5.4.36+ + } + Multiboot x86 Configuration: """""""""""""""""""""""""""" @@ -31,89 +287,70 @@ Multiboot x86 Configuration: compatible = “hypervisor,xen” // Configuration container - config { + xen-config { compatible = "xen,config"; - module { - compatible = "module,microcode", "multiboot,module"; - mb-index = <1>; + bootargs = "console=com1,vga com1=115200,8n1 loglvl=all"; + + microcode { + compatible = "module,microcode", "module,index"; + module-index = <1>; }; - module { - compatible = "module,xsm-policy", "multiboot,module"; - mb-index = <2>; + policy { + compatible = "module,xsm-policy", "module,index"; + module-index = <2>; }; }; // Boot Domain definition - domain { + domB { compatible = "xen,domain"; domid = <0x7FF5>; - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) functions = <0x00000001>; memory = <0x0 0x20000>; cpus = <1>; - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <3>; - }; - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <4>; + kernel { + compatible = "module,kernel", "module,index"; + module-index = <3>; }; - module { - compatible = "module,config", "multiboot,module"; - mb-index = <5>; + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <4>; + }; + dom-config { + compatible = "module,config", "module,index"; + module-index = <5>; }; // Classic Dom0 definition - domain { + dom0 { compatible = "xen,domain"; domid = <0>; - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ mode = <5>; /* 64 BIT, PV */ - // UUID domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; cpus = <1>; memory = <0x0 0x20000>; - security-id = “dom0_t; + security-id = “system_u:system_r:dom0_t; - module { - compatible = "module,kernel", "multiboot,module"; - mb-index = <6>; + kernel { + compatible = "module,kernel", "module,index"; + module-index = <6>; bootargs = "console=hvc0"; }; - module { - compatible = "module,ramdisk", "multiboot,module"; - mb-index = <7>; + initrd { + compatible = "module,ramdisk", "module,index"; + module-index = <7>; }; }; @@ -137,89 +374,68 @@ Module Arm Configuration: compatible = “hypervisor,xen” // Configuration container - config { + xen-config { compatible = "xen,config"; - module { - compatible = "module,microcode”; + microcode { + compatible = "module,microcode”,"module,addr"; module-addr = <0x0000ff00 0x80>; }; - module { - compatible = "module,xsm-policy"; + policy { + compatible = "module,xsm-policy","module,addr"; module-addr = <0x0000ff00 0x80>; }; }; // Boot Domain definition - domain { + domB { compatible = "xen,domain"; domid = <0x7FF5>; - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) functions = <0x00000001>; memory = <0x0 0x20000>; cpus = <1>; - module { - compatible = "module,kernel"; + + kernel { + compatible = "module,kernel","module,addr"; module-addr = <0x0000ff00 0x80>; }; - - module { - compatible = "module,ramdisk"; + initrd { + compatible = "module,ramdisk","module,addr"; module-addr = <0x0000ff00 0x80>; }; - module { - compatible = "module,config"; + dom-config { + compatible = "module,config","module,addr"; module-addr = <0x0000ff00 0x80>; }; // Classic Dom0 definition - domain@0 { + dom0 { compatible = "xen,domain"; domid = <0>; - // PERMISSION_NONE (0) - // PERMISSION_CONTROL (1 << 0) - // PERMISSION_HARDWARE (1 << 1) permissions = <3>; - - // FUNCTION_NONE (0) - // FUNCTION_BOOT (1 << 0) - // FUNCTION_CRASH (1 << 1) - // FUNCTION_CONSOLE (1 << 2) - // FUNCTION_XENSTORE (1 << 30) - // FUNCTION_LEGACY_DOM0 (1 << 31) functions = <0xC0000006>; - - // MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ - // MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ - // MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ mode = <5>; /* 64 BIT, PV */ - // UUID domain-uuid = [B3 FB 98 FB 8F 9F 67 A3]; cpus = <1>; memory = <0x0 0x20000>; - security-id = “dom0_t”; + security-id = “system_u:system_r:dom0_t”; - module { - compatible = "module,kernel"; + kernel { + compatible = "module,kernel","module,addr"; module-addr = <0x0000ff00 0x80>; bootargs = "console=hvc0"; }; - module { - compatible = "module,ramdisk"; + intird { + compatible = "module,ramdisk","module,addr"; module-addr = <0x0000ff00 0x80>; }; }; @@ -240,104 +456,3 @@ provided to Xen using the standard method currently in use. The remaining modules would need to be loaded in the respective addresses specified in the `module-addr` property. - -The Hypervisor node -------------------- - -The hypervisor node is a top level container for the domains that will be built -by hypervisor on start up. On the ``hypervisor`` node the ``compatible`` -property is used to identify the type of hypervisor node present.. - -compatible - Identifies the type of node. Required. - -The Config node ---------------- - -A config node is for detailing any modules that are of interest to Xen itself. -For example this would be where Xen would be informed of microcode or XSM -policy locations. If the modules are multiboot modules and are able to be -located by index within the module chain, the ``mb-index`` property should be -used to specify the index in the multiboot module chain.. If the module will be -located by physical memory address, then the ``module-addr`` property should be -used to identify the location and size of the module. - -compatible - Identifies the type of node. Required. - -The Domain node ---------------- - -A domain node is for describing the construction of a domain. It may provide a -domid property which will be used as the requested domain id for the domain -with a value of “0” signifying to use the next available domain id, which is -the default behavior if omitted. A domain configuration is not able to request -a domid of “0”. After that a domain node may have any of the following -parameters, - -compatible - Identifies the type of node. Required. - -domid - Identifies the domid requested to assign to the domain. Required. - -permissions - This sets what Discretionary Access Control permissions - a domain is assigned. Optional, default is none. - -functions - This identifies what system functions a domain will fulfill. - Optional, the default is none. - -.. note:: The `functions` bits that have been selected to indicate - ``FUNCTION_XENSTORE`` and ``FUNCTION_LEGACY_DOM0`` are the last two bits - (30, 31) such that should these features ever be fully retired, the flags may - be dropped without leaving a gap in the flag set. - -mode - The mode the domain will be executed under. Required. - -domain-uuid - A globally unique identifier for the domain. Optional, - the default is NULL. - -cpus - The number of vCPUs to be assigned to the domain. Optional, - the default is “1”. - -memory - The amount of memory to assign to the domain, in KBs. - Required. - -security-id - The security identity to be assigned to the domain when XSM - is the access control mechanism being used. Optional, - the default is “domu_t”. - -The Module node ---------------- - -This node describes a boot module loaded by the boot loader. The required -compatible property follows the format: module, where type can be -“kernel”, “ramdisk”, “device-tree”, “microcode”, “xsm-policy” or “config”. In -the case the module is a multiboot module, the additional property string -“multiboot,module” may be present. One of two properties is required and -identifies how to locate the module. They are the mb-index, used for multiboot -modules, and the module-addr for memory address based location. - -compatible - This identifies what the module is and thus what the hypervisor - should use the module for during domain construction. Required. - -mb-index - This identifies the index for this module in the multiboot module chain. - Required for multiboot environments. - -module-addr - This identifies where in memory this module is located. Required for - non-multiboot environments. - -bootargs - This is used to provide the boot params to kernel modules. - -.. note:: The bootargs property is intended for situations where the same kernel multiboot module is used for more than one domain. -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362549.592663 (Exim 4.92) (envelope-from ) id 1o9CGB-0000AX-Vu; Wed, 06 Jul 2022 21:08:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362549.592663; Wed, 06 Jul 2022 21:08:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGB-00008t-Rn; Wed, 06 Jul 2022 21:08:35 +0000 Received: by outflank-mailman (input) for mailman id 362549; Wed, 06 Jul 2022 21:08:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFW-0003HV-9b for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:07:54 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1eea131-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:07:52 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141518204185.36893009232347; Wed, 6 Jul 2022 14:05:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1eea131-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141520; cv=none; d=zohomail.com; s=zohoarc; b=Ue1eFEAVuXgejFvAA+0yve4SHos8OvlwOoZRAvApcYMSGy+9pBEIMLkrMJiSyhD0HscYiMrbOqu8ZYkcnyyr/gJB0jISG4TDkwqKmpJspwli5Cd1urWnGazn6WLsIJN5PZlJspDbC6CiLa7eUI11SN3HUOHIPMEG956hzP0lfbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141520; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=F4LzAhNPz1Ut05j8lMJsWMf8SmFv3K61ZtdVdpesbfA=; b=gc6mXWqlp7guNMHg/OlgAe8zR8zr9/2z6/Hi3fR9d7Dn5sij9HLJzf3nVKYrM1vEE1M5AMbj59iBJ6ua5DkWYWGZxeij3czMtL4vYS2BhAe1+Fe0b2L39GADKlrdt5PAml8UOfz+iMKtGc2KYMSIL4dbWnyPu+mLQgxVGQvvvVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141520; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=F4LzAhNPz1Ut05j8lMJsWMf8SmFv3K61ZtdVdpesbfA=; b=e6xBEFOFce8A+eAooJUkrcJudnW0akQ8Er0WlYkmWnsHROtQYQ50y3+5ETDM1qiv mK0gjlizY++GnCuUB+7EG5yKBevt3+AaS7hhI8YHSPQ2ov/mamqP2kXJ/pUbCegif9r FR67yWmaULGDF3K0z6yMWppXs+d5NLFunVisrfAQ= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v1 10/18] x86: introduce the domain builder Date: Wed, 6 Jul 2022 17:04:45 -0400 Message-Id: <20220706210454.30096-11-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit introduces the domain builder configuration FDT parser along with the domain builder core for domain creation. To enable domain builder to be a cross architecture internal API, a new arch domain creation call is introduced for use by the domain builder. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/setup.c | 9 + xen/common/Makefile | 1 + xen/common/domain-builder/Makefile | 2 + xen/common/domain-builder/core.c | 96 ++++++++++ xen/common/domain-builder/fdt.c | 295 +++++++++++++++++++++++++++++ xen/common/domain-builder/fdt.h | 7 + xen/include/xen/bootinfo.h | 16 ++ xen/include/xen/domain_builder.h | 1 + 8 files changed, 427 insertions(+) create mode 100644 xen/common/domain-builder/Makefile create mode 100644 xen/common/domain-builder/core.c create mode 100644 xen/common/domain-builder/fdt.c create mode 100644 xen/common/domain-builder/fdt.h diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index e4060d6219..28dbfcd209 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -1,4 +1,6 @@ +#include #include +#include #include #include #include @@ -826,6 +828,13 @@ static struct domain *__init create_dom0(const struct boot_info *bi) return d; } +void __init arch_create_dom( + const struct boot_info *bi, struct boot_domain *bd) +{ + if ( builder_is_initdom(bd) ) + create_dom0(bi); +} + /* How much of the directmap is prebuilt at compile time. */ #define PREBUILT_MAP_LIMIT (1 << L2_PAGETABLE_SHIFT) diff --git a/xen/common/Makefile b/xen/common/Makefile index ebd3e2d659..eb108fa107 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -72,6 +72,7 @@ extra-y := symbols-dummy.o obj-$(CONFIG_COVERAGE) += coverage/ obj-y += sched/ obj-$(CONFIG_UBSAN) += ubsan/ +obj-y += domain-builder/ obj-$(CONFIG_NEEDS_LIBELF) += libelf/ obj-$(CONFIG_CORE_DEVICE_TREE) += libfdt/ diff --git a/xen/common/domain-builder/Makefile b/xen/common/domain-builder/Makefile new file mode 100644 index 0000000000..9561602502 --- /dev/null +++ b/xen/common/domain-builder/Makefile @@ -0,0 +1,2 @@ +obj-$(CONFIG_BUILDER_FDT) += fdt.o +obj-y += core.o diff --git a/xen/common/domain-builder/core.c b/xen/common/domain-builder/core.c new file mode 100644 index 0000000000..b030b07d71 --- /dev/null +++ b/xen/common/domain-builder/core.c @@ -0,0 +1,96 @@ +#include +#include +#include +#include +#include + +#include +#include + +#include "fdt.h" + +static struct domain_builder __initdata builder; + +void __init builder_init(struct boot_info *info) +{ + struct boot_domain *d = NULL; + + info->builder = &builder; + + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) + { + /* fdt is required to be module 0 */ + switch ( check_fdt(info, __va(info->mods[0].start)) ) + { + case 0: + printk("Domain Builder: initialized from config\n"); + info->builder->fdt_enabled = true; + return; + case -EINVAL: + info->builder->fdt_enabled = false; + break; + case -ENODATA: + default: + panic("%s: error occured processing DTB\n", __func__); + } + } + + /* + * No FDT config support or an FDT wasn't present, do an initial + * domain construction + */ + printk("Domain Builder: falling back to initial domain build\n"); + info->builder->nr_doms = 1; + d = &info->builder->domains[0]; + + d->mode = opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; + + d->kernel = &info->mods[0]; + d->kernel->kind = BOOTMOD_KERNEL; + + d->permissions = BUILD_PERMISSION_CONTROL | BUILD_PERMISSION_HARDWARE; + d->functions = BUILD_FUNCTION_CONSOLE | BUILD_FUNCTION_XENSTORE | + BUILD_FUNCTION_INITIAL_DOM; + + d->kernel->arch->headroom = bzimage_headroom(bootstrap_map(d->kernel), + d->kernel->size); + bootstrap_map(NULL); + + if ( d->kernel->string.len ) + d->kernel->string.kind = BOOTSTR_CMDLINE; +} + +uint32_t __init builder_create_domains(struct boot_info *info) +{ + uint32_t build_count = 0, functions_built = 0; + int i; + + for ( i = 0; i < info->builder->nr_doms; i++ ) + { + struct boot_domain *d = &info->builder->domains[i]; + + if ( ! IS_ENABLED(CONFIG_MULTIDOM_BUILDER) && + ! builder_is_initdom(d) && + functions_built & BUILD_FUNCTION_INITIAL_DOM ) + continue; + + if ( d->kernel == NULL ) + { + if ( builder_is_initdom(d) ) + panic("%s: intial domain missing kernel\n", __func__); + + printk(XENLOG_ERR "%s:Dom%d definiton has no kernel\n", __func__, + d->domid); + continue; + } + + arch_create_dom(info, d); + if ( d->domain ) + { + functions_built |= d->functions; + build_count++; + } + } + + return build_count; +} diff --git a/xen/common/domain-builder/fdt.c b/xen/common/domain-builder/fdt.c new file mode 100644 index 0000000000..937cc61e7a --- /dev/null +++ b/xen/common/domain-builder/fdt.c @@ -0,0 +1,295 @@ +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +#include "fdt.h" + +#define BUILDER_FDT_TARGET_UNK 0 +#define BUILDER_FDT_TARGET_X86 1 +#define BUILDER_FDT_TARGET_ARM 2 +static int __initdata target_arch = BUILDER_FDT_TARGET_UNK; + +static struct boot_module *read_module( + const void *fdt, int node, uint32_t address_cells, uint32_t size_cells, + struct boot_info *info) +{ + const struct fdt_property *prop; + const __be32 *cell; + struct boot_module *bm; + bootmodule_kind kind = BOOTMOD_UNKNOWN; + int len; + + if ( device_tree_node_compatible(fdt, node, "module,kernel") ) + kind = BOOTMOD_KERNEL; + + if ( device_tree_node_compatible(fdt, node, "module,ramdisk") ) + kind = BOOTMOD_RAMDISK; + + if ( device_tree_node_compatible(fdt, node, "module,microcode") ) + kind = BOOTMOD_UCODE; + + if ( device_tree_node_compatible(fdt, node, "module,xsm-policy") ) + kind = BOOTMOD_XSM; + + if ( device_tree_node_compatible(fdt, node, "module,config") ) + kind = BOOTMOD_GUEST_CONF; + + if ( device_tree_node_compatible(fdt, node, "module,index") ) + { + uint32_t idx; + + idx = (uint32_t)device_tree_get_u32(fdt, node, "module-index", 0); + if ( idx == 0 ) + return NULL; + + bm = &info->mods[idx]; + + bm->kind = kind; + + return bm; + } + + if ( device_tree_node_compatible(fdt, node, "module,addr") ) + { + uint64_t addr, size; + + prop = fdt_get_property(fdt, node, "module-addr", &len); + if ( !prop ) + return NULL; + + if ( len < dt_cells_to_size(address_cells + size_cells) ) + return NULL; + + cell = (const __be32 *)prop->data; + device_tree_get_reg( + &cell, address_cells, size_cells, &addr, &size); + + bm = bootmodule_next_by_addr(info, addr, NULL); + + bm->kind = kind; + + return bm; + } + + printk(XENLOG_WARNING + "builder fdt: module node %d, no index or addr provided\n", + node); + + return NULL; +} + +static int process_config_node( + const void *fdt, int node, const char *name, int depth, + uint32_t address_cells, uint32_t size_cells, void *data) +{ + struct boot_info *info = (struct boot_info *)data; + int node_next; + + if ( !info ) + return -1; + + for ( node_next = fdt_first_subnode(fdt, node); + node_next > 0; + node_next = fdt_next_subnode(fdt, node_next)) + read_module(fdt, node_next, address_cells, size_cells, info); + + return 0; +} + +static int process_domain_node( + const void *fdt, int node, const char *name, int depth, + uint32_t address_cells, uint32_t size_cells, void *data) +{ + struct boot_info *info = (struct boot_info *)data; + const struct fdt_property *prop; + struct boot_domain *domain; + int node_next, i, plen; + + if ( !info ) + return -1; + + if ( info->builder->nr_doms >= BUILD_MAX_BOOT_DOMAINS ) + return -1; + + domain = &info->builder->domains[info->builder->nr_doms]; + + domain->domid = (domid_t)device_tree_get_u32(fdt, node, "domid", 0); + domain->permissions = device_tree_get_u32(fdt, node, "permissions", 0); + domain->functions = device_tree_get_u32(fdt, node, "functions", 0); + domain->mode = device_tree_get_u32(fdt, node, "mode", 0); + + prop = fdt_get_property(fdt, node, "domain-uuid", &plen); + if ( prop ) + for ( i=0; i < sizeof(domain->uuid) % sizeof(uint32_t); i++ ) + *(domain->uuid + i) = fdt32_to_cpu((uint32_t)prop->data[i]); + + domain->ncpus = device_tree_get_u32(fdt, node, "cpus", 1); + + if ( target_arch == BUILDER_FDT_TARGET_X86 ) + { + prop = fdt_get_property(fdt, node, "memory", &plen); + if ( prop ) + { + int sz = fdt32_to_cpu(prop->len); + char s[64]; + unsigned long val; + + if ( sz >= 64 ) + panic("node %s invalid `memory' property\n", name); + + memcpy(s, prop->data, sz); + s[sz] = '\0'; + val = parse_size_and_unit(s, NULL); + + domain->meminfo.mem_size.nr_pages = PFN_UP(val); + domain->meminfo.mem_max.nr_pages = PFN_UP(val); + } + else + panic("node %s missing `memory' property\n", name); + } + else + panic("%s: only x86 memory parsing supported\n", __func__); + + prop = fdt_get_property(fdt, node, "security-id", + &plen); + if ( prop ) + { + int sz = fdt32_to_cpu(prop->len); + sz = sz > BUILD_MAX_SECID_LEN ? BUILD_MAX_SECID_LEN : sz; + memcpy(domain->secid, prop->data, sz); + } + + for ( node_next = fdt_first_subnode(fdt, node); + node_next > 0; + node_next = fdt_next_subnode(fdt, node_next)) + { + struct boot_module *bm = read_module(fdt, node_next, address_cells, + size_cells, info); + + switch ( bm->kind ) + { + case BOOTMOD_KERNEL: + /* kernel was already found */ + if ( domain->kernel != NULL ) + continue; + + bm->arch->headroom = bzimage_headroom(bootstrap_map(bm), bm->size); + bootstrap_map(NULL); + + if ( bm->string.len ) + bm->string.kind = BOOTSTR_CMDLINE; + else + { + prop = fdt_get_property(fdt, node_next, "bootargs", &plen); + if ( prop ) + { + int size = fdt32_to_cpu(prop->len); + size = size > BOOTMOD_MAX_STRING ? + BOOTMOD_MAX_STRING : size; + memcpy(bm->string.bytes, prop->data, size); + bm->string.kind = BOOTSTR_CMDLINE; + } + } + + domain->kernel = bm; + + break; + case BOOTMOD_RAMDISK: + /* ramdisk was already found */ + if ( domain->ramdisk != NULL ) + continue; + + domain->ramdisk = bm; + + break; + case BOOTMOD_GUEST_CONF: + /* guest config was already found */ + if ( domain->configs[BUILD_DOM_CONF_IDX] != NULL ) + continue; + + domain->configs[BUILD_DOM_CONF_IDX] = bm; + + break; + default: + continue; + } + } + + info->builder->nr_doms++; + + return 0; +} + +static int __init scan_node( + const void *fdt, int node, const char *name, int depth, u32 address_cells, + u32 size_cells, void *data) +{ + int rc = -1; + + /* skip nodes that are not direct children of the hyperlaunch node */ + if ( depth > 1 ) + return 0; + + if ( device_tree_node_compatible(fdt, node, "xen,config") ) + rc = process_config_node(fdt, node, name, depth, + address_cells, size_cells, data); + else if ( device_tree_node_compatible(fdt, node, "xen,domain") ) + rc = process_domain_node(fdt, node, name, depth, + address_cells, size_cells, data); + + if ( rc < 0 ) + printk("hyperlaunch fdt: node `%s'failed to parse\n", name); + + return rc; +} + +/* check_fdt + * Attempts to initialize hyperlaunch config + * + * Returns: + * -EINVAL: Not a valid DTB + * -ENODATA: Valid DTB but not a valid hyperlaunch device tree + * 0: Valid hyperlaunch device tree + */ +int __init check_fdt(struct boot_info *info, void *fdt) +{ + int hv_node, ret; + + ret = fdt_check_header(fdt); + if ( ret < 0 ) + return -EINVAL; + + hv_node = fdt_path_offset(fdt, "/chosen/hypervisor"); + if ( hv_node < 0 ) + return -ENODATA; + + if ( !device_tree_node_compatible(fdt, hv_node, "hypervisor,xen") ) + return -EINVAL; + + if ( IS_ENABLED(CONFIG_X86) && + device_tree_node_compatible(fdt, hv_node, "xen,x86") ) + target_arch = BUILDER_FDT_TARGET_X86; + else if ( IS_ENABLED(CONFIG_ARM) && + device_tree_node_compatible(fdt, hv_node, "xen,arm") ) + target_arch = BUILDER_FDT_TARGET_ARM; + + if ( target_arch != BUILDER_FDT_TARGET_X86 && + target_arch != BUILDER_FDT_TARGET_ARM ) + return -EINVAL; + + ret = device_tree_for_each_node(fdt, hv_node, scan_node, boot_info); + if ( ret > 0 ) + return -ENODATA; + + return 0; +} diff --git a/xen/common/domain-builder/fdt.h b/xen/common/domain-builder/fdt.h new file mode 100644 index 0000000000..b185718412 --- /dev/null +++ b/xen/common/domain-builder/fdt.h @@ -0,0 +1,7 @@ +/* SPDX-License-Identifier: GPL-2.0 */ + +#ifndef COMMON_BUILDER_FDT_H +#define COMMON_BUILDER_FDT_H + +int __init check_fdt(struct boot_info *info, void *fdt); +#endif diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h index 1d76d99a40..07b151e318 100644 --- a/xen/include/xen/bootinfo.h +++ b/xen/include/xen/bootinfo.h @@ -101,6 +101,22 @@ static inline struct boot_module *bootmodule_next_by_kind( return NULL; } +static inline struct boot_module *bootmodule_next_by_addr( + const struct boot_info *bi, paddr_t addr, struct boot_module *start) +{ + /* point end at the entry for xen */ + struct boot_module *end = &bi->mods[bi->nr_mods]; + + if ( !start ) + start = bi->mods; + + for ( ; start < end; start++ ) + if ( start->start == addr ) + return start; + + return NULL; +} + static inline void bootmodule_update_start(struct boot_module *b, paddr_t new_start) { b->start = new_start; diff --git a/xen/include/xen/domain_builder.h b/xen/include/xen/domain_builder.h index 79785ef251..c0d997f7bd 100644 --- a/xen/include/xen/domain_builder.h +++ b/xen/include/xen/domain_builder.h @@ -51,5 +51,6 @@ static inline struct domain *builder_get_hwdom(struct boot_info *info) void builder_init(struct boot_info *info); uint32_t builder_create_domains(struct boot_info *info); +void arch_create_dom(const struct boot_info *bi, struct boot_domain *bd); #endif /* XEN_DOMAIN_BUILDER_H */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362550.592668 (Exim 4.92) (envelope-from ) id 1o9CGC-0000Ey-Db; Wed, 06 Jul 2022 21:08:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362550.592668; Wed, 06 Jul 2022 21:08:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGC-0000EN-6F; Wed, 06 Jul 2022 21:08:36 +0000 Received: by outflank-mailman (input) for mailman id 362550; Wed, 06 Jul 2022 21:08:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFl-0003HV-0C for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:08:09 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bae41d24-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:08:07 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141520651940.6489274956703; Wed, 6 Jul 2022 14:05:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bae41d24-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141522; cv=none; d=zohomail.com; s=zohoarc; b=bmYSXXAUB8n4jSmYj9pKCDn2/3VNyaxHV4BJgn8SwBVOKjN4q5kJ6wB7JaTqWt+inxiWwVfWvTTdeP5mfEITFjzQoqbHXvMxBx/9V1hgI1JIZc8HO2zLpB4YfWrdECHcz5sOTii9yjMbBosZWbaUom5EXUkbEfTS6GHdMTQfp7w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141522; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=eTpqwxpSkEMWg//PoKCMIGmKB8+qr3bwNRO2rt7uCKo=; b=inPXKKpZqe9qe9iysKSIX2T1UnQj+vvh9u+rMs9FCpDbfzpENQQXg/rkhWdb9J7Lpz/I23ah36RQOCM1O/yQjnOgFw/Wx+LoqNcCEhHI7aYI9tHM3RiNbDwuVY9NLsyiQ0yAtI1V7EPibmXkebWlefXxu+fyEwzXvsNhSfOCWwU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141522; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=eTpqwxpSkEMWg//PoKCMIGmKB8+qr3bwNRO2rt7uCKo=; b=Uo4wzGK9lFd7R8bDuJokrOPOnARrls4G0FKlTP2ZIIA3y0D6zX+sWF1RQvA9SBdF tpvS/wxIfvEmRz6AbtHsSkSuF9f0hU0XvPUfqHJ1SOQ453SpXIlmZbmOF2JJoOfLAFA fPum7fIiqay1QIJx7SWKiUGo6X8e2FIFD/+bb7g4= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 11/18] x86: initial conversion to domain builder Date: Wed, 6 Jul 2022 17:04:46 -0400 Message-Id: <20220706210454.30096-12-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit is the first step in adopting domain builder. It goes through the dom0 creation and construction functions, converting them over to consume struct boot_domaain and changes the startup sequence to use the domain builder to create and construct dom0. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/dom0_build.c | 30 +++---- xen/arch/x86/hvm/dom0_build.c | 10 +-- xen/arch/x86/include/asm/dom0_build.h | 8 +- xen/arch/x86/include/asm/setup.h | 5 +- xen/arch/x86/pv/dom0_build.c | 39 ++++----- xen/arch/x86/setup.c | 114 +++++++++++++++----------- 6 files changed, 109 insertions(+), 97 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index e44f7f3c43..216c9e3590 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -556,31 +557,32 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } -int __init construct_dom0( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline) +int __init construct_domain(struct boot_domain *bd) { - int rc; + int rc = 0; /* Sanity! */ - BUG_ON(!pv_shim && d->domain_id != 0); - BUG_ON(d->vcpu[0] == NULL); - BUG_ON(d->vcpu[0]->is_initialised); + BUG_ON(!pv_shim && bd->domid != 0); + BUG_ON(bd->domain->vcpu[0] == NULL); + BUG_ON(bd->domain->vcpu[0]->is_initialised); process_pending_softirqs(); - if ( is_hvm_domain(d) ) - rc = dom0_construct_pvh(d, image, initrd, cmdline); - else if ( is_pv_domain(d) ) - rc = dom0_construct_pv(d, image, initrd, cmdline); - else - panic("Cannot construct Dom0. No guest interface available\n"); + if ( builder_is_initdom(bd) ) + { + if ( is_hvm_domain(bd->domain) ) + rc = dom0_construct_pvh(bd); + else if ( is_pv_domain(bd->domain) ) + rc = dom0_construct_pv(bd); + else + panic("Cannot construct Dom0. No guest interface available\n"); + } if ( rc ) return rc; /* Sanity! */ - BUG_ON(!d->vcpu[0]->is_initialised); + BUG_ON(!bd->domain->vcpu[0]->is_initialised); return 0; } diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 4e903a848d..2fee2ed926 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -19,6 +19,7 @@ */ #include +#include #include #include #include @@ -1217,10 +1218,9 @@ static void __hwdom_init pvh_setup_mmcfg(struct domain *d) } } -int __init dom0_construct_pvh( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline) +int __init dom0_construct_pvh(struct boot_domain *bd) { + struct domain *d = bd->domain; paddr_t entry, start_info; int rc; @@ -1249,8 +1249,8 @@ int __init dom0_construct_pvh( return rc; } - rc = pvh_load_kernel(d, image, initrd, bootstrap_map(image), - cmdline, &entry, &start_info); + rc = pvh_load_kernel(d, bd->kernel, bd->ramdisk, bootstrap_map(bd->kernel), + bd->kernel->string.bytes, &entry, &start_info); if ( rc ) { printk("Failed to load Dom0 kernel\n"); diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index ad33413710..571b25ea71 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -14,13 +14,9 @@ unsigned long dom0_compute_nr_pages(struct domain *d, unsigned long initrd_len); int dom0_setup_permissions(struct domain *d); -int __init dom0_construct_pv( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline); +int dom0_construct_pv(struct boot_domain *bd); -int __init dom0_construct_pvh( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline); +int dom0_construct_pvh(struct boot_domain *bd); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 27c0d61819..f9c1468fcc 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,9 +33,8 @@ void vesa_init(void); static inline void vesa_init(void) {}; #endif -int construct_dom0( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline); +int construct_domain(struct boot_domain *bd); + void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index f6131147ef..78ebb03b1b 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -4,6 +4,7 @@ * Copyright (c) 2002-2005, K A Fraser */ +#include #include #include #include @@ -295,9 +296,7 @@ static struct page_info * __init alloc_chunk(struct domain *d, return page; } -int __init dom0_construct_pv( - struct domain *d, const struct boot_module *image, - struct boot_module *initrd, char *cmdline) +int __init dom0_construct_pv(struct boot_domain *bd) { int i, rc, order, machine; bool compatible, compat; @@ -311,11 +310,12 @@ int __init dom0_construct_pv( unsigned long count; struct page_info *page = NULL; start_info_t *si; + struct domain *d = bd->domain; struct vcpu *v = d->vcpu[0]; - void *image_base = bootstrap_map(image); - unsigned long image_len = image->size; - void *image_start = image_base + image->arch->headroom; - unsigned long initrd_len = initrd ? initrd->size : 0; + void *image_base = bootstrap_map(bd->kernel); + unsigned long image_len = bd->kernel->size; + void *image_start = image_base + bd->kernel->arch->headroom; + unsigned long initrd_len = bd->ramdisk ? bd->ramdisk->size : 0; l4_pgentry_t *l4tab = NULL, *l4start = NULL; l3_pgentry_t *l3tab = NULL, *l3start = NULL; l2_pgentry_t *l2tab = NULL, *l2start = NULL; @@ -355,7 +355,7 @@ int __init dom0_construct_pv( d->max_pages = ~0U; if ( (rc = - bzimage_parse(image_base, &image_start, image->arch->headroom, + bzimage_parse(image_base, &image_start, bd->kernel->arch->headroom, &image_len)) != 0 ) return rc; @@ -545,7 +545,7 @@ int __init dom0_construct_pv( initrd_pfn = vinitrd_start ? (vinitrd_start - v_start) >> PAGE_SHIFT : domain_tot_pages(d); - initrd_mfn = mfn = mfn_x(initrd->mfn); + initrd_mfn = mfn = mfn_x(bd->ramdisk->mfn); count = PFN_UP(initrd_len); if ( d->arch.physaddr_bitsize && ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) @@ -560,13 +560,13 @@ int __init dom0_construct_pv( free_domheap_pages(page, order); page += 1UL << order; } - memcpy(page_to_virt(page), maddr_to_virt(initrd->start), + memcpy(page_to_virt(page), maddr_to_virt(bd->ramdisk->start), initrd_len); - mpt_alloc = initrd->start; + mpt_alloc = bd->ramdisk->start; init_domheap_pages(mpt_alloc, mpt_alloc + PAGE_ALIGN(initrd_len)); - bootmodule_update_mfn(initrd, page_to_mfn(page)); - initrd_mfn = mfn_x(initrd->mfn); + bootmodule_update_mfn(bd->ramdisk, page_to_mfn(page)); + initrd_mfn = mfn_x(bd->ramdisk->mfn); } else { @@ -574,7 +574,7 @@ int __init dom0_construct_pv( if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) BUG(); } - initrd->size = 0; + bd->ramdisk->size = 0; } printk("PHYSICAL MEMORY ARRANGEMENT:\n" @@ -583,9 +583,9 @@ int __init dom0_construct_pv( if ( domain_tot_pages(d) < nr_pages ) printk(" (%lu pages to be allocated)", nr_pages - domain_tot_pages(d)); - if ( initrd ) + if ( bd->ramdisk ) { - mpt_alloc = initrd->start; + mpt_alloc = bd->ramdisk->start; printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr, mpt_alloc, mpt_alloc + initrd_len); } @@ -806,7 +806,7 @@ int __init dom0_construct_pv( if ( pfn >= initrd_pfn ) { if ( pfn < initrd_pfn + PFN_UP(initrd_len) ) - mfn = mfn_x(initrd->mfn) + (pfn - initrd_pfn); + mfn = mfn_x(bd->ramdisk->mfn) + (pfn - initrd_pfn); else mfn -= PFN_UP(initrd_len); } @@ -866,8 +866,9 @@ int __init dom0_construct_pv( } memset(si->cmd_line, 0, sizeof(si->cmd_line)); - if ( cmdline != NULL ) - strlcpy((char *)si->cmd_line, cmdline, sizeof(si->cmd_line)); + if ( strlen(bd->kernel->string.bytes) > 0 ) + strlcpy((char *)si->cmd_line, bd->kernel->string.bytes, + sizeof(si->cmd_line)); #ifdef CONFIG_VIDEO if ( !pv_shim && fill_console_start_info((void *)(si + 1)) ) diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 28dbfcd209..860b9e3d64 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -45,7 +45,6 @@ #include #include #include -#include /* for bzimage_headroom */ #include /* for generic_apic_probe */ #include #include @@ -272,6 +271,24 @@ static int __init cf_check parse_acpi_param(const char *s) } custom_param("acpi", parse_acpi_param); +void __init arch_builder_apply_cmdline( + struct boot_info *info, struct boot_domain *bd) +{ + if ( skip_ioapic_setup && !strstr(bd->kernel->string.bytes, "noapic") ) + strlcat(bd->kernel->string.bytes, " noapic", MAX_GUEST_CMDLINE); + if ( (strlen(acpi_param) == 0) && acpi_disabled ) + { + printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); + strlcpy(acpi_param, "off", sizeof(acpi_param)); + } + if ( (strlen(acpi_param) != 0) && + !strstr(bd->kernel->string.bytes, "acpi=") ) + { + strlcat(bd->kernel->string.bytes, " acpi=", MAX_GUEST_CMDLINE); + strlcat(bd->kernel->string.bytes, acpi_param, MAX_GUEST_CMDLINE); + } +} + struct boot_info __initdata *boot_info; unsigned long __init initial_images_nrpages(nodeid_t node) @@ -728,7 +745,8 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0(const struct boot_info *bi) +static struct domain *__init create_dom0( + const struct boot_info *bi, struct boot_domain *bd) { struct xen_domctl_createdomain dom0_cfg = { .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, @@ -741,14 +759,10 @@ static struct domain *__init create_dom0(const struct boot_info *bi) .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, }, }; - struct boot_module *image = bootmodule_next_by_kind(bi, BOOTMOD_KERNEL, 0); - struct boot_module *initrd = bootmodule_next_by_kind(bi, BOOTMOD_RAMDISK, 0); - struct domain *d; char *cmdline; - domid_t domid = 0; - if ( image == NULL ) - panic("Error creating d%uv0\n", domid); + if ( bd->kernel == NULL ) + panic("Error creating d%uv0\n", bd->domid); if ( opt_dom0_pvh ) { @@ -764,45 +778,46 @@ static struct domain *__init create_dom0(const struct boot_info *bi) dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; /* Create initial domain. Not d0 for pvshim. */ - domid = get_initial_domain_id(); - d = domain_create(domid, &dom0_cfg, pv_shim ? 0 : CDF_privileged); - if ( IS_ERR(d) ) - panic("Error creating d%u: %ld\n", domid, PTR_ERR(d)); + bd->domid = get_initial_domain_id(); + bd->domain = domain_create(bd->domid, &dom0_cfg, pv_shim ? + 0 : CDF_privileged); + if ( IS_ERR(bd->domain) ) + panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); - init_dom0_cpuid_policy(d); + init_dom0_cpuid_policy(bd->domain); - if ( alloc_dom0_vcpu0(d) == NULL ) - panic("Error creating d%uv0\n", domid); + if ( alloc_dom0_vcpu0(bd->domain) == NULL ) + panic("Error creating d%uv0\n", bd->domid); /* Grab the DOM0 command line. */ - cmdline = (image->string.kind == BOOTSTR_CMDLINE) ? - image->string.bytes : NULL; + cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? + bd->kernel->string.bytes : NULL; if ( cmdline || bi->arch->kextra ) { - static char __initdata dom0_cmdline[MAX_GUEST_CMDLINE]; + char dom0_cmdline[MAX_GUEST_CMDLINE]; cmdline = arch_prepare_cmdline(cmdline, bi->arch); - safe_strcpy(dom0_cmdline, cmdline); + strlcpy(dom0_cmdline, cmdline, MAX_GUEST_CMDLINE); if ( bi->arch->kextra ) /* kextra always includes exactly one leading space. */ - safe_strcat(dom0_cmdline, bi->arch->kextra); + strlcat(dom0_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); /* Append any extra parameters. */ if ( skip_ioapic_setup && !strstr(dom0_cmdline, "noapic") ) - safe_strcat(dom0_cmdline, " noapic"); + strlcat(dom0_cmdline, " noapic", MAX_GUEST_CMDLINE); if ( (strlen(acpi_param) == 0) && acpi_disabled ) { printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); - safe_strcpy(acpi_param, "off"); + strlcpy(acpi_param, "off", sizeof(acpi_param)); } if ( (strlen(acpi_param) != 0) && !strstr(dom0_cmdline, "acpi=") ) { - safe_strcat(dom0_cmdline, " acpi="); - safe_strcat(dom0_cmdline, acpi_param); + strlcat(dom0_cmdline, " acpi=", MAX_GUEST_CMDLINE); + strlcat(dom0_cmdline, acpi_param, MAX_GUEST_CMDLINE); } - cmdline = dom0_cmdline; + strlcpy(bd->kernel->string.bytes, dom0_cmdline, MAX_GUEST_CMDLINE); } /* @@ -816,7 +831,7 @@ static struct domain *__init create_dom0(const struct boot_info *bi) write_cr4(read_cr4() & ~X86_CR4_SMAP); } - if ( construct_dom0(d, image, initrd, cmdline) != 0 ) + if ( construct_domain(bd) != 0 ) panic("Could not construct domain 0\n"); if ( cpu_has_smap ) @@ -825,14 +840,14 @@ static struct domain *__init create_dom0(const struct boot_info *bi) cr4_pv32_mask |= X86_CR4_SMAP; } - return d; + return bd->domain; } void __init arch_create_dom( const struct boot_info *bi, struct boot_domain *bd) { if ( builder_is_initdom(bd) ) - create_dom0(bi); + create_dom0(bi, bd); } /* How much of the directmap is prebuilt at compile time. */ @@ -1010,10 +1025,7 @@ void __init noreturn __start_xen(unsigned long bi_p) boot_info->nr_mods); } - /* Dom0 kernel is the first boot module */ - boot_info->mods[0].kind = BOOTMOD_KERNEL; - if ( boot_info->mods[0].string.len ) - boot_info->mods[0].string.kind = BOOTSTR_CMDLINE; + builder_init(boot_info); if ( pvh_boot ) { @@ -1168,11 +1180,6 @@ void __init noreturn __start_xen(unsigned long bi_p) boot_info->mods[boot_info->nr_mods].size = __2M_rwdata_end - _stext; } - boot_info->mods[0].arch->headroom = bzimage_headroom( - bootstrap_map(&boot_info->mods[0]), - boot_info->mods[0].size); - bootstrap_map(NULL); - #ifndef highmem_start /* Don't allow split below 4Gb. */ if ( highmem_start < GB(4) ) @@ -1905,22 +1912,29 @@ void __init noreturn __start_xen(unsigned long bi_p) cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", cpu_has_nx ? "" : "not "); - initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); - if ( initrdidx < boot_info->nr_mods ) - boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; - - if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) - printk(XENLOG_WARNING - "Multiple initrd candidates, picking module #%u\n", - initrdidx); - /* - * We're going to setup domain0 using the module(s) that we stashed safely - * above our heap. The second module, if present, is an initrd ramdisk. + * Boot description not provided, check to see if there are any remaining + * boot modules, the first one found will be provided as the ramdisk. */ - dom0 = create_dom0(boot_info); + if ( ! boot_info->builder->fdt_enabled ) + { + initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); + if ( initrdidx < boot_info->nr_mods ) + { + boot_info->builder->domains[0].ramdisk = &boot_info->mods[initrdidx]; + boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; + } + if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) + printk(XENLOG_WARNING + "Multiple initrd candidates, picking module #%u\n", + initrdidx); + } + + builder_create_domains(boot_info); + + dom0 = builder_get_hwdom(boot_info); if ( !dom0 ) - panic("Could not set up DOM0 guest OS\n"); + panic("No hardware domain was built\n"); heap_init_late(); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:08:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:08:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362561.592685 (Exim 4.92) (envelope-from ) id 1o9CGT-0001kc-1k; Wed, 06 Jul 2022 21:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362561.592685; Wed, 06 Jul 2022 21:08:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGS-0001kP-TC; Wed, 06 Jul 2022 21:08:52 +0000 Received: by outflank-mailman (input) for mailman id 362561; Wed, 06 Jul 2022 21:08:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGR-0007yd-FG for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:08:51 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d449487b-fd6f-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 23:08:50 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141525983954.9774962986977; Wed, 6 Jul 2022 14:05:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d449487b-fd6f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657141527; cv=none; d=zohomail.com; s=zohoarc; b=jeWDZKBFeS35Z9RwtifusSZdaz0wVhsCakQYdv1hC4oUrttUSv33m2Y7yH0bD2P6QVUjqMXCmcOgTkxjv5x9t0fKUE97ORr9n01rm6rWasw+RXYc3BaSlKHRE+4fNWyKC7g7NkGv8UEwUdnws6FhBq+7V7W+aXRFvHwIm/+AZu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141527; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=S145Tne13TWHR+Kbw2vROFs6IyEj+oY3nk3bfwwUXUQ=; b=RoIBD+Zdh1XKu5+7HD8tGQnZfQopwwZc5FMABbKmX6p+j6GILN4HjaOtPwRGGFDSEesWd1WYT5MTYzalRFM1UVOnz3Cp/Z9LywO30LOU0ZHKzWgts0LwBkT5CKKp6RuRh6uG6BYXkd/01XPijhDq414neIFdFbFmSaEeEicwLTc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141527; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=S145Tne13TWHR+Kbw2vROFs6IyEj+oY3nk3bfwwUXUQ=; b=nWNxOPu9Um2DRf6axihFZiQAw/zxtqclsbSsukXxsvcWKO+i4ULxpEmdDK3sOIBO USrlVMoZSQbi6KtDGQedZxaT8w9mO8edn3A+OL2ULR0MAOoay6/CdSjzLSbOo8KXjEN ltSed0UtH5hymmAU40fuCOoTw7exZvZ5o+97Rj6o= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 15/18] x86: rework domain page allocation Date: Wed, 6 Jul 2022 17:04:50 -0400 Message-Id: <20220706210454.30096-16-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This reworks all the dom0 page allocation functions for general domain construction. Where possible, common logic between the two was split into a separate function for reuse by the two functions. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/dom0_build.c | 76 ++++++------------- xen/arch/x86/domain_builder.c | 102 ++++++++++++++++++++++++++ xen/arch/x86/hvm/dom0_build.c | 11 +-- xen/arch/x86/include/asm/dom0_build.h | 14 +++- xen/arch/x86/pv/dom0_build.c | 2 +- 5 files changed, 142 insertions(+), 63 deletions(-) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 216c9e3590..0600773b8f 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -320,69 +320,31 @@ static unsigned long __init default_nr_pages(unsigned long avail) } unsigned long __init dom0_compute_nr_pages( - struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_len) + struct boot_domain *bd, struct elf_dom_parms *parms, + unsigned long initrd_len) { - nodeid_t node; - unsigned long avail = 0, nr_pages, min_pages, max_pages, iommu_pages = 0; + unsigned long avail, nr_pages, min_pages, max_pages; /* The ordering of operands is to work around a clang5 issue. */ if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set ) parse_dom0_mem(CONFIG_DOM0_MEM); - for_each_node_mask ( node, dom0_nodes ) - avail += avail_domheap_pages_region(node, 0, 0) + - initial_images_nrpages(node); - - /* Reserve memory for further dom0 vcpu-struct allocations... */ - avail -= (d->max_vcpus - 1UL) - << get_order_from_bytes(sizeof(struct vcpu)); - /* ...and compat_l4's, if needed. */ - if ( is_pv_32bit_domain(d) ) - avail -= d->max_vcpus - 1; - - /* Reserve memory for iommu_dom0_init() (rough estimate). */ - if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough ) - { - unsigned int s; - - for ( s = 9; s < BITS_PER_LONG; s += 9 ) - iommu_pages += max_pdx >> s; - - avail -= iommu_pages; - } + avail = dom_avail_nr_pages(bd, dom0_nodes); - if ( paging_mode_enabled(d) || opt_dom0_shadow || opt_pv_l1tf_hwdom ) + /* command line overrides configuration */ + if ( dom0_mem_set ) { - unsigned long cpu_pages; - - nr_pages = get_memsize(&dom0_size, avail) ?: default_nr_pages(avail); - - /* - * Clamp according to min/max limits and available memory - * (preliminary). - */ - nr_pages = max(nr_pages, get_memsize(&dom0_min_size, avail)); - nr_pages = min(nr_pages, get_memsize(&dom0_max_size, avail)); - nr_pages = min(nr_pages, avail); - - cpu_pages = dom0_paging_pages(d, nr_pages); - - if ( !iommu_use_hap_pt(d) ) - avail -= cpu_pages; - else if ( cpu_pages > iommu_pages ) - avail -= cpu_pages - iommu_pages; + bd->meminfo.mem_size = dom0_size; + bd->meminfo.mem_min = dom0_min_size; + bd->meminfo.mem_max = dom0_max_size; } - nr_pages = get_memsize(&dom0_size, avail) ?: default_nr_pages(avail); - min_pages = get_memsize(&dom0_min_size, avail); - max_pages = get_memsize(&dom0_max_size, avail); - - /* Clamp according to min/max limits and available memory (final). */ - nr_pages = max(nr_pages, min_pages); - nr_pages = min(nr_pages, max_pages); - nr_pages = min(nr_pages, avail); + nr_pages = get_memsize(&bd->meminfo.mem_size, avail) ? + : default_nr_pages(avail); + min_pages = get_memsize(&bd->meminfo.mem_min, avail); + max_pages = get_memsize(&bd->meminfo.mem_max, avail); - if ( is_pv_domain(d) && + if ( is_pv_domain(bd->domain) && (parms->p2m_base == UNSET_ADDR) && !memsize_gt_zero(&dom0_size) && (!memsize_gt_zero(&dom0_min_size) || (nr_pages > min_pages)) ) { @@ -395,7 +357,8 @@ unsigned long __init dom0_compute_nr_pages( * available between params.virt_base and the address space end. */ unsigned long vstart, vend, end; - size_t sizeof_long = is_pv_32bit_domain(d) ? sizeof(int) : sizeof(long); + size_t sizeof_long = is_pv_32bit_domain(bd->domain) ? + sizeof(int) : sizeof(long); vstart = parms->virt_base; vend = round_pgup(parms->virt_kend); @@ -416,7 +379,12 @@ unsigned long __init dom0_compute_nr_pages( } } - d->max_pages = min_t(unsigned long, max_pages, UINT_MAX); + /* Clamp according to min/max limits and available memory (final). */ + nr_pages = max(nr_pages, min_pages); + nr_pages = min(nr_pages, max_pages); + nr_pages = min(nr_pages, avail); + + bd->domain->max_pages = min_t(unsigned long, max_pages, UINT_MAX); return nr_pages; } diff --git a/xen/arch/x86/domain_builder.c b/xen/arch/x86/domain_builder.c index 1a4a6b1ca7..d8babb1090 100644 --- a/xen/arch/x86/domain_builder.c +++ b/xen/arch/x86/domain_builder.c @@ -8,7 +8,9 @@ #include #include +#include #include +#include extern unsigned long cr4_pv32_mask; @@ -40,6 +42,106 @@ struct vcpu *__init alloc_dom_vcpu0(struct boot_domain *bd) } +unsigned long __init dom_avail_nr_pages( + struct boot_domain *bd, nodemask_t nodes) +{ + unsigned long avail = 0, iommu_pages = 0; + bool is_ctldom = false, is_hwdom = false; + unsigned long nr_pages = bd->meminfo.mem_size.nr_pages; + nodeid_t node; + + if ( builder_is_ctldom(bd) ) + is_ctldom = true; + if ( builder_is_hwdom(bd) ) + is_hwdom = true; + + for_each_node_mask ( node, nodes ) + avail += avail_domheap_pages_region(node, 0, 0) + + initial_images_nrpages(node); + + /* Reserve memory for further dom0 vcpu-struct allocations... */ + avail -= (bd->domain->max_vcpus - 1UL) + << get_order_from_bytes(sizeof(struct vcpu)); + /* ...and compat_l4's, if needed. */ + if ( is_pv_32bit_domain(bd->domain) ) + avail -= bd->domain->max_vcpus - 1; + + /* Reserve memory for iommu_dom0_init() (rough estimate). */ + if ( is_hwdom && is_iommu_enabled(bd->domain) && !iommu_hwdom_passthrough ) + { + unsigned int s; + + for ( s = 9; s < BITS_PER_LONG; s += 9 ) + iommu_pages += max_pdx >> s; + + avail -= iommu_pages; + } + + if ( paging_mode_enabled(bd->domain) || + (is_ctldom && opt_dom0_shadow) || + (is_hwdom && opt_pv_l1tf_hwdom) ) + { + unsigned long cpu_pages = dom0_paging_pages(bd->domain, nr_pages); + + if ( !iommu_use_hap_pt(bd->domain) ) + avail -= cpu_pages; + else if ( cpu_pages > iommu_pages ) + avail -= cpu_pages - iommu_pages; + } + + return avail; +} + +unsigned long __init dom_compute_nr_pages( + struct boot_domain *bd, struct elf_dom_parms *parms, + unsigned long initrd_len) +{ + unsigned long avail, nr_pages = bd->meminfo.mem_size.nr_pages; + + if ( builder_is_initdom(bd) ) + return dom0_compute_nr_pages(bd, parms, initrd_len); + + avail = dom_avail_nr_pages(bd, node_online_map); + + if ( is_pv_domain(bd->domain) && (parms->p2m_base == UNSET_ADDR) ) + { + /* + * Legacy Linux kernels (i.e. such without a XEN_ELFNOTE_INIT_P2M + * note) require that there is enough virtual space beyond the initial + * allocation to set up their initial page tables. This space is + * roughly the same size as the p2m table, so make sure the initial + * allocation doesn't consume more than about half the space that's + * available between params.virt_base and the address space end. + */ + unsigned long vstart, vend, end; + size_t sizeof_long = is_pv_32bit_domain(bd->domain) ? + sizeof(int) : sizeof(long); + + vstart = parms->virt_base; + vend = round_pgup(parms->virt_kend); + if ( !parms->unmapped_initrd ) + vend += round_pgup(initrd_len); + end = vend + nr_pages * sizeof_long; + + if ( end > vstart ) + end += end - vstart; + if ( end <= vstart || + (sizeof_long < sizeof(end) && end > (1UL << (8 * sizeof_long))) ) + { + end = sizeof_long >= sizeof(end) ? 0 : 1UL << (8 * sizeof_long); + nr_pages = (end - vend) / (2 * sizeof_long); + printk("Dom0 memory clipped to %lu pages\n", nr_pages); + } + } + + /* Clamp according to available memory (final). */ + nr_pages = min(nr_pages, avail); + + bd->domain->max_pages = min_t(unsigned long, nr_pages, UINT_MAX); + + return nr_pages; +} + void __init arch_create_dom( const struct boot_info *bi, struct boot_domain *bd) { diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index ae3ffc614d..e94392be07 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -412,15 +412,16 @@ static __init void pvh_setup_e820(struct domain *d, unsigned long nr_pages) ASSERT(cur_pages == nr_pages); } -static void __init pvh_init_p2m(struct domain *d) +static void __init pvh_init_p2m(struct boot_domain *bd) { - unsigned long nr_pages = dom0_compute_nr_pages(d, NULL, 0); + unsigned long nr_pages = dom_compute_nr_pages(bd, NULL, 0); bool preempted; - pvh_setup_e820(d, nr_pages); + pvh_setup_e820(bd->domain, nr_pages); do { preempted = false; - paging_set_allocation(d, dom0_paging_pages(d, nr_pages), + paging_set_allocation(bd->domain, + dom0_paging_pages(bd->domain, nr_pages), &preempted); process_pending_softirqs(); } while ( preempted ); @@ -1239,7 +1240,7 @@ int __init dom0_construct_pvh(struct boot_domain *bd) * be done before the iommu initializion, since iommu initialization code * will likely add mappings required by devices to the p2m (ie: RMRRs). */ - pvh_init_p2m(d); + pvh_init_p2m(bd); iommu_hwdom_init(d); diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index f30e4b860a..6c26ab0878 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -9,9 +9,17 @@ extern unsigned int dom0_memflags; -unsigned long dom0_compute_nr_pages(struct domain *d, - struct elf_dom_parms *parms, - unsigned long initrd_len); +unsigned long dom_avail_nr_pages( + struct boot_domain *bd, nodemask_t nodes); + +unsigned long dom0_compute_nr_pages( + struct boot_domain *bd, struct elf_dom_parms *parms, + unsigned long initrd_len); + +unsigned long dom_compute_nr_pages( + struct boot_domain *bd, struct elf_dom_parms *parms, + unsigned long initrd_len); + int dom0_setup_permissions(struct domain *d); int dom0_construct_pv(struct boot_domain *bd); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 9d1c9fb8b0..ff5c93fa14 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -428,7 +428,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) } } - nr_pages = dom0_compute_nr_pages(d, &parms, initrd_len); + nr_pages = dom_compute_nr_pages(bd, &parms, initrd_len); if ( parms.pae == XEN_PAE_EXTCR3 ) set_bit(VMASST_TYPE_pae_extended_cr3, &d->vm_assist); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362584.592695 (Exim 4.92) (envelope-from ) id 1o9CPV-00047x-4f; Wed, 06 Jul 2022 21:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362584.592695; Wed, 06 Jul 2022 21:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CPV-00047q-1w; Wed, 06 Jul 2022 21:18:13 +0000 Received: by outflank-mailman (input) for mailman id 362584; Wed, 06 Jul 2022 21:18:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGd-0007yd-8I for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:09:03 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db23b078-fd6f-11ec-bd2d-47488cf2e6aa; Wed, 06 Jul 2022 23:09:01 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141527503522.1572181705782; Wed, 6 Jul 2022 14:05:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db23b078-fd6f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657141528; cv=none; d=zohomail.com; s=zohoarc; b=gyMMf/zIGC9Fq0T/pchioGdYxETpEQ8ygFPgLloVVR0kmUPJl4bGNK733wllR1bzvUqrPOByzdvNe0DwmtEpNORy779oUDrojao7j6eMLlhfERlOZ21kmzvVAEJZTQAF2/A9bS7QDkehJ6T8voTCf1WySFOL3X0cCPVJ9+p8MZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141528; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=wO71seG+2JNeV652NZFdlSDXjvFFYd1IqGaFh2WZtlI=; b=VI5MXUQS/c+tlvAWLP9HWBYIaRff7f2hWCsV+c1f2rOSeQFywFoy0kLC8FuLSl07f/B0x7kVktXfUPSVrlX9RlLFsQK2YGwWjS6zuPC9npOMsS4AkcuRUtGZhn7B3X00wJF/cG1602PQFCGzGnJdWQO1QI78LjbKCFYrv+K9jn4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141528; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=wO71seG+2JNeV652NZFdlSDXjvFFYd1IqGaFh2WZtlI=; b=I0y8K00pZ6ObMS2+85N1SZsq8Mekv/hZPJ2S606KXO/zt/f9QcXMKFwry/zwVMa1 55PkRhPS+rMlky8qIZaAvkfIkc7/nNh5sXvpCN3Ppi4LJjyqp8GlvTD3Ey6ixXYlidp pf2tKFSL+39oAY2iJsR9vy5dU+3KQWbAkV1DnVOM= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v1 16/18] x86: add pv multidomain construction Date: Wed, 6 Jul 2022 17:04:51 -0400 Message-Id: <20220706210454.30096-17-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This adds the ability to domain builder for the construction of multiple pv domains at boot. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/dom0_build.c | 31 ----- xen/arch/x86/domain_builder.c | 58 ++++++-- xen/arch/x86/include/asm/dom0_build.h | 2 - xen/arch/x86/include/asm/setup.h | 2 + xen/arch/x86/pv/Makefile | 2 +- .../x86/pv/{dom0_build.c => domain_builder.c} | 86 +++++++----- xen/common/domain-builder/Kconfig | 10 ++ xen/common/domain-builder/core.c | 130 ++++++++++++++++-- xen/include/xen/bootdomain.h | 6 + xen/include/xen/domain_builder.h | 19 +++ 10 files changed, 259 insertions(+), 87 deletions(-) rename xen/arch/x86/pv/{dom0_build.c => domain_builder.c} (92%) diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c index 0600773b8f..85a10f63aa 100644 --- a/xen/arch/x86/dom0_build.c +++ b/xen/arch/x86/dom0_build.c @@ -524,37 +524,6 @@ int __init dom0_setup_permissions(struct domain *d) return rc; } - -int __init construct_domain(struct boot_domain *bd) -{ - int rc = 0; - - /* Sanity! */ - BUG_ON(!pv_shim && bd->domid != 0); - BUG_ON(bd->domain->vcpu[0] == NULL); - BUG_ON(bd->domain->vcpu[0]->is_initialised); - - process_pending_softirqs(); - - if ( builder_is_initdom(bd) ) - { - if ( is_hvm_domain(bd->domain) ) - rc = dom0_construct_pvh(bd); - else if ( is_pv_domain(bd->domain) ) - rc = dom0_construct_pv(bd); - else - panic("Cannot construct Dom0. No guest interface available\n"); - } - - if ( rc ) - return rc; - - /* Sanity! */ - BUG_ON(!bd->domain->vcpu[0]->is_initialised); - - return 0; -} - /* * Local variables: * mode: C diff --git a/xen/arch/x86/domain_builder.c b/xen/arch/x86/domain_builder.c index d8babb1090..94f3ff4d5a 100644 --- a/xen/arch/x86/domain_builder.c +++ b/xen/arch/x86/domain_builder.c @@ -6,6 +6,7 @@ #include #include #include +#include #include #include @@ -189,18 +190,22 @@ void __init arch_create_dom( if ( !pv_shim && builder_is_ctldom(bd) ) is_privileged = CDF_privileged; - /* Create initial domain. Not d0 for pvshim. */ - bd->domid = get_initial_domain_id(); + /* Determine proper domain id. */ + if ( builder_is_initdom(bd) ) + bd->domid = get_initial_domain_id(); + else + bd->domid = bd->domid ? bd->domid : get_next_domid(); bd->domain = domain_create(bd->domid, &dom_cfg, is_privileged); if ( IS_ERR(bd->domain) ) panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); - init_dom0_cpuid_policy(bd->domain); + if ( builder_is_initdom(bd) ) + init_dom0_cpuid_policy(bd->domain); if ( alloc_dom_vcpu0(bd) == NULL ) panic("Error creating d%uv0\n", bd->domid); - /* Grab the DOM0 command line. */ + /* Grab the command line. */ cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? bd->kernel->string.bytes : NULL; if ( cmdline || bi->arch->kextra ) @@ -210,15 +215,23 @@ void __init arch_create_dom( cmdline = arch_prepare_cmdline(cmdline, bi->arch); strlcpy(dom_cmdline, cmdline, MAX_GUEST_CMDLINE); - if ( bi->arch->kextra ) - /* kextra always includes exactly one leading space. */ - strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); + if ( builder_is_initdom(bd) ) + { + if ( bi->arch->kextra ) + /* kextra always includes exactly one leading space. */ + strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); - apply_xen_cmdline(dom_cmdline); + apply_xen_cmdline(dom_cmdline); + } strlcpy(bd->kernel->string.bytes, dom_cmdline, MAX_GUEST_CMDLINE); } + if ( alloc_system_evtchn(bi, bd) != 0 ) + printk(XENLOG_WARNING "%s: " + "unable set up system event channels for Dom%d\n", + __func__, bd->domid); + /* * Temporarily clear SMAP in CR4 to allow user-accesses in construct_dom0(). * This saves a large number of corner cases interactions with @@ -240,3 +253,32 @@ void __init arch_create_dom( } } +int __init construct_domain(struct boot_domain *bd) +{ + int rc = 0; + + /* Sanity! */ + BUG_ON(bd->domid != bd->domain->domain_id); + BUG_ON(bd->domain->vcpu[0] == NULL); + BUG_ON(bd->domain->vcpu[0]->is_initialised); + + process_pending_softirqs(); + + if ( is_hvm_domain(bd->domain) ) + if ( builder_is_initdom(bd) ) + rc = dom0_construct_pvh(bd); + else + panic("Cannot construct HVM DomU. Not supported.\n"); + else if ( is_pv_domain(bd->domain) ) + rc = dom_construct_pv(bd); + else + panic("Cannot construct Dom0. No guest interface available\n"); + + if ( rc ) + return rc; + + /* Sanity! */ + BUG_ON(!bd->domain->vcpu[0]->is_initialised); + + return 0; +} diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index 6c26ab0878..3624a57641 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -22,8 +22,6 @@ unsigned long dom_compute_nr_pages( int dom0_setup_permissions(struct domain *d); -int dom0_construct_pv(struct boot_domain *bd); - int dom0_construct_pvh(struct boot_domain *bd); unsigned long dom0_paging_pages(const struct domain *d, diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 6f53623fb3..328f9a8611 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -36,6 +36,8 @@ static inline void vesa_init(void) {}; void apply_xen_cmdline(char *cmdline); int construct_domain(struct boot_domain *bd); +int dom_construct_pv(struct boot_domain *bd); + void setup_io_bitmap(struct domain *d); unsigned long initial_images_nrpages(nodeid_t node); diff --git a/xen/arch/x86/pv/Makefile b/xen/arch/x86/pv/Makefile index 6cda354cc4..d06a3c1de1 100644 --- a/xen/arch/x86/pv/Makefile +++ b/xen/arch/x86/pv/Makefile @@ -15,5 +15,5 @@ obj-$(CONFIG_PV_SHIM) += shim.o obj-$(CONFIG_TRACEBUFFER) += trace.o obj-y += traps.o -obj-bin-y += dom0_build.init.o +obj-bin-y += domain_builder.init.o obj-bin-y += gpr_switch.o diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/domain_builder.c similarity index 92% rename from xen/arch/x86/pv/dom0_build.c rename to xen/arch/x86/pv/domain_builder.c index ff5c93fa14..2ecf1b0ae3 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/domain_builder.c @@ -1,5 +1,5 @@ /****************************************************************************** - * pv/dom0_build.c + * pv/domain_builder.c * * Copyright (c) 2002-2005, K A Fraser */ @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -296,7 +297,7 @@ static struct page_info * __init alloc_chunk(struct domain *d, return page; } -int __init dom0_construct_pv(struct boot_domain *bd) +int __init dom_construct_pv(struct boot_domain *bd) { int i, rc, order, machine; bool compatible, compat; @@ -350,7 +351,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) /* Machine address of next candidate page-table page. */ paddr_t mpt_alloc; - printk(XENLOG_INFO "*** Building a PV Dom%d ***\n", d->domain_id); + printk(XENLOG_INFO "*** Constructing a PV Dom%d ***\n", d->domain_id); d->max_pages = ~0U; @@ -362,7 +363,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) if ( (rc = elf_init(&elf, image_start, image_len)) != 0 ) return rc; - if ( opt_dom0_verbose ) + if ( builder_is_ctldom(bd) && opt_dom0_verbose ) elf_set_verbose(&elf); elf_parse_binary(&elf); @@ -384,7 +385,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) { if ( unlikely(rc = switch_compat(d)) ) { - printk("Dom0 failed to switch to compat: %d\n", rc); + printk("Dom%d failed to switch to compat: %d\n", + d->domain_id, rc); return rc; } @@ -404,22 +406,23 @@ int __init dom0_construct_pv(struct boot_domain *bd) if ( elf_msb(&elf) ) compatible = false; - printk(" Dom0 kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", - elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", + printk(" Dom%d kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", + d->domain_id, elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", parms.pae ? ", PAE" : "", elf_msb(&elf) ? "msb" : "lsb", elf.pstart, elf.pend); if ( elf.bsd_symtab_pstart ) - printk(" Dom0 symbol map %#" PRIx64 " -> %#" PRIx64 "\n", - elf.bsd_symtab_pstart, elf.bsd_symtab_pend); + printk(" Dom%d symbol map %#" PRIx64 " -> %#" PRIx64 "\n", + d->domain_id, elf.bsd_symtab_pstart, elf.bsd_symtab_pend); if ( !compatible ) { - printk("Mismatch between Xen and DOM0 kernel\n"); + printk("Mismatch between Xen and DOM%d kernel\n", d->domain_id); return -EINVAL; } - if ( parms.elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type != XEN_ENT_NONE ) + if ( builder_is_initdom(bd) && + parms.elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type != XEN_ENT_NONE ) { if ( !pv_shim && !test_bit(XENFEAT_dom0, parms.f_supported) ) { @@ -443,7 +446,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) if ( value > __HYPERVISOR_COMPAT_VIRT_START ) { - printk("Dom0 expects too high a hypervisor start address\n"); + printk("Dom%d expects too high a hypervisor start address\n", + d->domain_id); return -ERANGE; } HYPERVISOR_COMPAT_VIRT_START(d) = @@ -487,7 +491,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) vstartinfo_start = round_pgup(vphysmap_end); vstartinfo_end = vstartinfo_start + sizeof(struct start_info); - if ( pv_shim ) + if ( pv_shim || ! builder_is_initdom(bd) ) { vxenstore_start = round_pgup(vstartinfo_end); vxenstore_end = vxenstore_start + PAGE_SIZE; @@ -578,8 +582,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) } printk("PHYSICAL MEMORY ARRANGEMENT:\n" - " Dom0 alloc.: %"PRIpaddr"->%"PRIpaddr, - pfn_to_paddr(alloc_spfn), pfn_to_paddr(alloc_epfn)); + " Dom%d alloc.: %"PRIpaddr"->%"PRIpaddr, + d->domain_id, pfn_to_paddr(alloc_spfn), pfn_to_paddr(alloc_epfn)); if ( domain_tot_pages(d) < nr_pages ) printk(" (%lu pages to be allocated)", nr_pages - domain_tot_pages(d)); @@ -596,7 +600,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) printk(" Init. ramdisk: %p->%p\n", _p(vinitrd_start), _p(vinitrd_end)); printk(" Phys-Mach map: %p->%p\n", _p(vphysmap_start), _p(vphysmap_end)); printk(" Start info: %p->%p\n", _p(vstartinfo_start), _p(vstartinfo_end)); - if ( pv_shim ) + if ( pv_shim || ! builder_is_initdom(bd) ) { printk(" Xenstore ring: %p->%p\n", _p(vxenstore_start), _p(vxenstore_end)); printk(" Console ring: %p->%p\n", _p(vconsole_start), _p(vconsole_end)); @@ -617,7 +621,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) ? v_end > HYPERVISOR_COMPAT_VIRT_START(d) : (v_start < HYPERVISOR_VIRT_END) && (v_end > HYPERVISOR_VIRT_START) ) { - printk("DOM0 image overlaps with Xen private area.\n"); + printk("DOM%d image overlaps with Xen private area.\n", d->domain_id); return -EINVAL; } @@ -768,9 +772,6 @@ int __init dom0_construct_pv(struct boot_domain *bd) init_hypercall_page(d, _p(parms.virt_hypercall)); } - /* Free temporary buffers. */ - discard_initial_images(); - /* Set up start info area. */ si = (start_info_t *)vstartinfo_start; clear_page(si); @@ -778,7 +779,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) si->shared_info = virt_to_maddr(d->shared_info); - if ( !pv_shim ) + if ( !pv_shim && builder_is_ctldom(bd) ) si->flags = SIF_PRIVILEGED | SIF_INITDOMAIN; if ( !vinitrd_start && initrd_len ) si->flags |= SIF_MOD_START_PFN; @@ -789,6 +790,19 @@ int __init dom0_construct_pv(struct boot_domain *bd) snprintf(si->magic, sizeof(si->magic), "xen-3.0-x86_%d%s", elf_64bit(&elf) ? 64 : 32, parms.pae ? "p" : ""); + if ( !builder_is_initdom(bd) ) + { + si->store_mfn = ((vxenstore_start - v_start) >> PAGE_SHIFT) + + alloc_spfn; + bd->store.mfn = si->store_mfn; + si->store_evtchn = bd->store.evtchn; + + si->console.domU.mfn = ((vconsole_start - v_start) >> PAGE_SHIFT) + + alloc_spfn; + bd->console.mfn = si->console.domU.mfn; + si->console.domU.evtchn = bd->console.evtchn; + } + count = domain_tot_pages(d); /* Set up the phys->machine table if not part of the initial mapping. */ @@ -871,23 +885,24 @@ int __init dom0_construct_pv(struct boot_domain *bd) sizeof(si->cmd_line)); #ifdef CONFIG_VIDEO - if ( !pv_shim && fill_console_start_info((void *)(si + 1)) ) - { - si->console.dom0.info_off = sizeof(struct start_info); - si->console.dom0.info_size = sizeof(struct dom0_vga_console_info); - } + if ( builder_is_hwdom(bd) ) + if ( !pv_shim && fill_console_start_info((void *)(si + 1)) ) + { + si->console.dom0.info_off = sizeof(struct start_info); + si->console.dom0.info_size = sizeof(struct dom0_vga_console_info); + } #endif /* * TODO: provide an empty stub for fill_console_start_info in the * !CONFIG_VIDEO case so the logic here can be simplified. */ - if ( pv_shim ) + if ( builder_is_hwdom(bd) && pv_shim ) pv_shim_setup_dom(d, l4start, v_start, vxenstore_start, vconsole_start, vphysmap_start, si); #ifdef CONFIG_COMPAT - if ( compat ) + if ( builder_is_hwdom(bd) && compat ) xlat_start_info(si, pv_shim ? XLAT_start_info_console_domU : XLAT_start_info_console_dom0); #endif @@ -926,15 +941,18 @@ int __init dom0_construct_pv(struct boot_domain *bd) if ( test_bit(XENFEAT_supervisor_mode_kernel, parms.f_required) ) panic("Dom0 requires supervisor-mode execution\n"); - rc = dom0_setup_permissions(d); - BUG_ON(rc != 0); + if ( builder_is_hwdom(bd) ) + { + rc = dom0_setup_permissions(d); + BUG_ON(rc != 0); + } if ( d->domain_id == hardware_domid ) iommu_hwdom_init(d); #ifdef CONFIG_SHADOW_PAGING /* Fill the shadow pool if necessary. */ - if ( opt_dom0_shadow || opt_pv_l1tf_hwdom ) + if ( builder_is_hwdom(bd) && (opt_dom0_shadow || opt_pv_l1tf_hwdom) ) { bool preempted; @@ -948,7 +966,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) } /* Activate shadow mode, if requested. Reuse the pv_l1tf tasklet. */ - if ( opt_dom0_shadow ) + if ( builder_is_hwdom(bd) && opt_dom0_shadow ) { printk("Switching dom0 to using shadow paging\n"); tasklet_schedule(&d->arch.paging.shadow.pv_l1tf_tasklet); @@ -960,8 +978,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) out: if ( elf_check_broken(&elf) ) - printk(XENLOG_WARNING "Dom0 kernel broken ELF: %s\n", - elf_check_broken(&elf)); + printk(XENLOG_WARNING "Dom%d kernel broken ELF: %s\n", + d->domain_id, elf_check_broken(&elf)); return rc; } diff --git a/xen/common/domain-builder/Kconfig b/xen/common/domain-builder/Kconfig index 893038cab3..0232e1ed8a 100644 --- a/xen/common/domain-builder/Kconfig +++ b/xen/common/domain-builder/Kconfig @@ -12,4 +12,14 @@ config BUILDER_FDT If unsure, say N. +config MULTIDOM_BUILDER + bool "Multidomain building (UNSUPPORTED)" if UNSUPPORTED + depends on BUILDER_FDT + ---help--- + Enables the domain builder to construct multiple domains. + + This feature is currently experimental. + + If unsure, say N. + endmenu diff --git a/xen/common/domain-builder/core.c b/xen/common/domain-builder/core.c index b030b07d71..c6a268eb96 100644 --- a/xen/common/domain-builder/core.c +++ b/xen/common/domain-builder/core.c @@ -1,6 +1,7 @@ #include #include #include +#include #include #include @@ -60,37 +61,144 @@ void __init builder_init(struct boot_info *info) d->kernel->string.kind = BOOTSTR_CMDLINE; } +static bool __init build_domain(struct boot_info *info, struct boot_domain *bd) +{ + if ( bd->constructed == true ) + return true; + + if ( bd->kernel == NULL ) + return false; + + printk(XENLOG_INFO "*** Building Dom%d ***\n", bd->domid); + + arch_create_dom(info, bd); + if ( bd->domain ) + { + bd->constructed = true; + return true; + } + + return false; +} + uint32_t __init builder_create_domains(struct boot_info *info) { uint32_t build_count = 0, functions_built = 0; + struct boot_domain *bd; int i; + if ( IS_ENABLED(CONFIG_MULTIDOM_BUILDER) ) + { + bd = builder_dom_by_function(info, BUILD_FUNCTION_XENSTORE); + if ( build_domain(info, bd) ) + { + functions_built |= bd->functions; + build_count++; + } + else + printk(XENLOG_WARNING "Xenstore build failed, system may be unusable\n"); + + bd = builder_dom_by_function(info, BUILD_FUNCTION_CONSOLE); + if ( build_domain(info, bd) ) + { + functions_built |= bd->functions; + build_count++; + } + else + printk(XENLOG_WARNING "Console build failed, system may be unusable\n"); + } + for ( i = 0; i < info->builder->nr_doms; i++ ) { - struct boot_domain *d = &info->builder->domains[i]; + bd = &info->builder->domains[i]; if ( ! IS_ENABLED(CONFIG_MULTIDOM_BUILDER) && - ! builder_is_initdom(d) && + ! builder_is_initdom(bd) && functions_built & BUILD_FUNCTION_INITIAL_DOM ) continue; - if ( d->kernel == NULL ) + if ( !build_domain(info, bd) ) { - if ( builder_is_initdom(d) ) + if ( builder_is_initdom(bd) ) panic("%s: intial domain missing kernel\n", __func__); - printk(XENLOG_ERR "%s:Dom%d definiton has no kernel\n", __func__, - d->domid); + printk(XENLOG_WARNING "Dom%d build failed, skipping\n", bd->domid); continue; } - arch_create_dom(info, d); - if ( d->domain ) + functions_built |= bd->functions; + build_count++; + } + + if ( IS_ENABLED(CONFIG_X86) ) + /* Free temporary buffers. */ + discard_initial_images(); + + return build_count; +} + +domid_t __init get_next_domid(void) +{ + static domid_t __initdata last_domid = 0; + domid_t next; + + for ( next = last_domid + 1; next < DOMID_FIRST_RESERVED; next++ ) + { + struct domain *d; + + if ( (d = rcu_lock_domain_by_id(next)) == NULL ) { - functions_built |= d->functions; - build_count++; + last_domid = next; + return next; } + + rcu_unlock_domain(d); } - return build_count; + return 0; +} + +int __init alloc_system_evtchn( + const struct boot_info *info, struct boot_domain *bd) +{ + evtchn_alloc_unbound_t evtchn_req; + struct boot_domain *c = builder_dom_by_function(info, + BUILD_FUNCTION_CONSOLE); + struct boot_domain *s = builder_dom_by_function(info, + BUILD_FUNCTION_XENSTORE); + int rc; + + evtchn_req.dom = bd->domid; + + if ( c != NULL && c != bd && c->constructed ) + { + evtchn_req.remote_dom = c->domid; + + rc = evtchn_alloc_unbound(&evtchn_req); + if ( rc ) + { + printk("Failed allocating console event channel for domain %d\n", + bd->domid); + return rc; + } + + bd->console.evtchn = evtchn_req.port; + } + + if ( s != NULL && s != bd && s->constructed ) + { + evtchn_req.remote_dom = s->domid; + + rc = evtchn_alloc_unbound(&evtchn_req); + if ( rc ) + { + printk("Failed allocating xenstore event channel for domain %d\n", + bd->domid); + return rc; + } + + bd->store.evtchn = evtchn_req.port; + } + + return 0; } diff --git a/xen/include/xen/bootdomain.h b/xen/include/xen/bootdomain.h index b172d16f4e..9c5d4d385e 100644 --- a/xen/include/xen/bootdomain.h +++ b/xen/include/xen/bootdomain.h @@ -47,6 +47,12 @@ struct boot_domain { struct boot_module *configs[BUILD_MAX_CONF_MODS]; struct domain *domain; + struct { + xen_pfn_t mfn; + unsigned int evtchn; + } store, console; + bool constructed; + }; #endif diff --git a/xen/include/xen/domain_builder.h b/xen/include/xen/domain_builder.h index c0d997f7bd..f9e43c9689 100644 --- a/xen/include/xen/domain_builder.h +++ b/xen/include/xen/domain_builder.h @@ -34,6 +34,22 @@ static inline bool builder_is_hwdom(struct boot_domain *bd) bd->permissions & BUILD_PERMISSION_HARDWARE ); } +static inline struct boot_domain *builder_dom_by_function( + const struct boot_info *info, uint32_t func) +{ + int i; + + for ( i = 0; i < info->builder->nr_doms; i++ ) + { + struct boot_domain *bd = &info->builder->domains[i]; + + if ( bd->functions & func ) + return bd; + } + + return NULL; +} + static inline struct domain *builder_get_hwdom(struct boot_info *info) { int i; @@ -51,6 +67,9 @@ static inline struct domain *builder_get_hwdom(struct boot_info *info) void builder_init(struct boot_info *info); uint32_t builder_create_domains(struct boot_info *info); +domid_t get_next_domid(void); +int alloc_system_evtchn( + const struct boot_info *info, struct boot_domain *bd); void arch_create_dom(const struct boot_info *bi, struct boot_domain *bd); #endif /* XEN_DOMAIN_BUILDER_H */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362587.592707 (Exim 4.92) (envelope-from ) id 1o9CPh-0004Uf-DP; Wed, 06 Jul 2022 21:18:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362587.592707; Wed, 06 Jul 2022 21:18:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CPh-0004UY-9X; Wed, 06 Jul 2022 21:18:25 +0000 Received: by outflank-mailman (input) for mailman id 362587; Wed, 06 Jul 2022 21:18:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CH2-0003HV-NY for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:09:28 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea5ee30e-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:09:27 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141530530395.5815075032556; Wed, 6 Jul 2022 14:05:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea5ee30e-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141532; cv=none; d=zohomail.com; s=zohoarc; b=S4Pd5Ua+YLIwBW93VjYZA95MP8py3To/IxTEvHAqYduNamfMq2orRibCfrPlbw4e0W5SbEcQjzJNHoO8adi04PODNP7v1xVl6Ge3ZxKm+WoV+YjmcdBjKq7Gs02QsPSrOEg4soztxITQkF2b1tdvUdz1G50FPFgtd2bd6aLeYo8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141532; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=TzFqy4EBOd/GMNv9mujkd/fHHyBVp+g+FM7/J81/w1g=; b=OnuQQ+lSE0NsCnvaZf7N5Oy4t7uo60pBy6j7JWFFJAUU2ZRoTtzvxJHk3hkBUPH9SyfpnoSBA86fsYVAfu45QgGpiUWn7FkmsJCQBbHlGYPOkDHQN1BG8qhwOx4pHLFVlmY1aEWpToFmcpomKZEjPeVf8y5H9P+PTwzgx5aFo0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141532; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=TzFqy4EBOd/GMNv9mujkd/fHHyBVp+g+FM7/J81/w1g=; b=VAT6AYQwoX3OC7hTtJyOksAXMnty1p42z36rkGo+COOWjf0qxxKa4yhRTWg51dnl DHjvb7Y0BR1DgJjTt9EaYI5B/oD2kEBacJGpeB7jlz6VxSAiAYWkzBkVod9i/Z/ojsJ Lcu4E9lvYH6WH+L1shVEAjQ8RUHBT1v40cCqBzE0= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH v1 18/18] tools: introduce example late pv helper Date: Wed, 6 Jul 2022 17:04:53 -0400 Message-Id: <20220706210454.30096-19-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The late pv helper is an example helper tool for late setup of Xenstore for a domain that was created by the hypervisor using hyperlaunch. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark christopher.clark@starlab.io --- .gitignore | 1 + tools/helpers/Makefile | 11 ++ tools/helpers/builder-hypfs.c | 253 ++++++++++++++++++++++++++++++ tools/helpers/hypfs-helpers.h | 9 ++ tools/helpers/late-init-pv.c | 287 ++++++++++++++++++++++++++++++++++ tools/helpers/late-init-pv.h | 29 ++++ tools/helpers/xs-helpers.c | 117 ++++++++++++++ tools/helpers/xs-helpers.h | 27 ++++ 8 files changed, 734 insertions(+) create mode 100644 tools/helpers/builder-hypfs.c create mode 100644 tools/helpers/hypfs-helpers.h create mode 100644 tools/helpers/late-init-pv.c create mode 100644 tools/helpers/late-init-pv.h create mode 100644 tools/helpers/xs-helpers.c create mode 100644 tools/helpers/xs-helpers.h diff --git a/.gitignore b/.gitignore index 18ef56a780..0e5d5ceaab 100644 --- a/.gitignore +++ b/.gitignore @@ -206,6 +206,7 @@ tools/fuzz/x86_instruction_emulator/x86_emulate tools/fuzz/x86_instruction_emulator/x86-emulate.[ch] tools/helpers/init-xenstore-domain tools/helpers/xen-init-dom0 +tools/helpers/late-init-pv tools/hotplug/common/hotplugpath.sh tools/hotplug/FreeBSD/rc.d/xencommons tools/hotplug/FreeBSD/rc.d/xendriverdomain diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 8d78ab1e90..c32481202d 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -14,6 +14,7 @@ ifeq ($(CONFIG_ARM),y) PROGS += init-dom0less endif endif +PROGS += late-init-pv XEN_INIT_DOM0_OBJS = xen-init-dom0.o init-dom-json.o $(XEN_INIT_DOM0_OBJS): CFLAGS += $(CFLAGS_libxentoollog) @@ -36,6 +37,13 @@ $(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenlight) $(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenctrl) $(INIT_DOM0LESS_OBJS): CFLAGS += $(CFLAGS_libxenevtchn) +LATE_INIT_PV_OBJS = late-init-pv.o builder-hypfs.o xs-helpers.o +$(LATE_INIT_PV_OBJS): CFLAGS += $(CFLAGS_libxentoollog) +$(LATE_INIT_PV_OBJS): CFLAGS += $(CFLAGS_libxenguest) +$(LATE_INIT_PV_OBJS): CFLAGS += $(CFLAGS_libxenctrl) +$(LATE_INIT_PV_OBJS): CFLAGS += $(CFLAGS_libxenhypfs) +$(LATE_INIT_PV_OBJS): CFLAGS += $(CFLAGS_libxenstore) + .PHONY: all all: $(PROGS) @@ -48,6 +56,9 @@ init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) init-dom0less: $(INIT_DOM0LESS_OBJS) $(CC) $(LDFLAGS) -o $@ $(INIT_DOM0LESS_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxenevtchn) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenguest) $(LDLIBS_libxenforeignmemory) $(APPEND_LDFLAGS) +late-init-pv: $(LATE_INIT_PV_OBJS) + $(CC) $(LDFLAGS) -o $@ $(LATE_INIT_PV_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenhypfs) $(APPEND_LDFLAGS) + .PHONY: install install: all $(INSTALL_DIR) $(DESTDIR)$(LIBEXEC_BIN) diff --git a/tools/helpers/builder-hypfs.c b/tools/helpers/builder-hypfs.c new file mode 100644 index 0000000000..d123426cfa --- /dev/null +++ b/tools/helpers/builder-hypfs.c @@ -0,0 +1,253 @@ + +#include +#include +#include +#include + +#include "late-init-pv.h" + +/* general size for static path array */ +#define HYPFS_MAX_PATH 100 + +bool has_builder_hypfs(xenhypfs_handle *hdl, uint32_t domid) +{ + struct xenhypfs_dirent *ent; + char path[HYPFS_MAX_PATH]; + unsigned int n; + + snprintf(path, HYPFS_MAX_PATH, "/builder/%d", domid); + + ent = xenhypfs_readdir(hdl, path, &n); + if ( ent ) + { + free(ent); + return true; + } + + return false; +} + +static int read_hypfs_bool(xenhypfs_handle *fshdl, const char *path, bool *val) +{ + struct xenhypfs_dirent *dirent; + void *raw_value; + + errno = 0; + + raw_value = xenhypfs_read_raw(fshdl, path, &dirent); + if ( raw_value == NULL ) + { + errno = EIO; + return false; + } + + if ( dirent->type != xenhypfs_type_bool ) + { + errno = EINVAL; + return false; + } + + *val = *(bool *)raw_value; + + free(raw_value); free(dirent); + return true; +} + +static bool read_hypfs_uint( + xenhypfs_handle *fshdl, const char *path, size_t sz, void *val) +{ + struct xenhypfs_dirent *dirent; + void *raw_value; + + errno = 0; + + raw_value = xenhypfs_read_raw(fshdl, path, &dirent); + if ( raw_value == NULL ) + { + errno = EIO; + return false; + } + + if ( (dirent->type != xenhypfs_type_uint) || + (dirent->size != sz) ) + { + errno = EINVAL; + return false; + } + + switch ( sz ) + { + case sizeof(uint8_t): + *(uint8_t *)val = *(uint8_t *)raw_value; + break; + case sizeof(uint16_t): + *(uint16_t *)val = *(uint16_t *)raw_value; + break; + case sizeof(uint32_t): + *(uint32_t *)val = *(uint32_t *)raw_value; + break; + case sizeof(uint64_t): + *(uint64_t *)val = *(uint64_t *)raw_value; + break; + default: + free(raw_value); free(dirent); + errno = EINVAL; + return false; + } + + free(raw_value); free(dirent); + return true; +} + +static uint8_t read_hypfs_uint8(xenhypfs_handle *fshdl, const char *path) +{ + uint8_t value; + + if ( !read_hypfs_uint(fshdl, path, sizeof(value), &value) ) + { + fprintf(stderr, "error: unable to read uint8_t from %s \n", path); + return 0; + } + + return value; +} + +static uint16_t read_hypfs_uint16(xenhypfs_handle *fshdl, const char *path) +{ + uint16_t value; + + if ( !read_hypfs_uint(fshdl, path, sizeof(value), &value) ) + { + fprintf(stderr, "error: unable to read uint16_t from %s \n", path); + return 0; + } + + return value; +} + +static uint32_t read_hypfs_uint32(xenhypfs_handle *fshdl, const char *path) +{ + uint32_t value; + + if ( !read_hypfs_uint(fshdl, path, sizeof(value), &value) ) + { + fprintf(stderr, "error: unable to read uint32_t from %s \n", path); + return 0; + } + + return value; +} + +static uint64_t read_hypfs_uint64(xenhypfs_handle *fshdl, const char *path) +{ + uint64_t value; + + if ( !read_hypfs_uint(fshdl, path, sizeof(value), &value) ) + { + fprintf(stderr, "error: unable to read uint64_t from %s \n", path); + return 0; + } + + return value; +} + +static bool is_constructed(xenhypfs_handle *fshdl, uint32_t domid) +{ + char path[HYPFS_MAX_PATH]; + bool constructed; + + snprintf(path, HYPFS_MAX_PATH, "/builder/%d/constructed", domid); + + if ( !read_hypfs_bool(fshdl, path, &constructed) ) + { + fprintf(stderr, "error: unable to read constructed field\n"); + return false; + } + + return constructed; +} + +#define XS_PATH "/builder/%d/xenstore" +#define CONS_PATH "/builder/%d/devices/console" + +int read_hypfs_tree(xenhypfs_handle *hdl, struct domain_info *di) +{ + char path[HYPFS_MAX_PATH]; + + if ( !is_constructed(hdl, di->domid) ) + { + fprintf(stderr, "error: domain %d did not get constructed\n", + di->domid); + return -EEXIST; + } + + if ( !di->override_uuid ) + { + snprintf(path, HYPFS_MAX_PATH, "/builder/%d/uuid", di->domid); + di->uuid = xenhypfs_read(hdl, path); + } + + snprintf(path, HYPFS_MAX_PATH, "/builder/%d/ncpus", di->domid); + di->num_cpu = read_hypfs_uint32(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read number of cpus\n"); + return -errno; + } + + snprintf(path, HYPFS_MAX_PATH, "/builder/%d/mem_size", di->domid); + di->mem_info.target = read_hypfs_uint32(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read memory size\n"); + return -errno; + } + + snprintf(path, HYPFS_MAX_PATH, "/builder/%d/mem_max", di->domid); + di->mem_info.max = read_hypfs_uint32(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read max memory\n"); + return -errno; + } + + /* Xenstore */ + snprintf(path, HYPFS_MAX_PATH, XS_PATH "/evtchn", di->domid); + di->xs_info.evtchn_port = read_hypfs_uint32(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read xenstore event channel port\n"); + return -errno; + } + + snprintf(path, HYPFS_MAX_PATH, XS_PATH "/mfn", di->domid); + di->xs_info.mfn = read_hypfs_uint64(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read xenstore page mfn\n"); + return -errno; + } + + /* Console */ + if ( di->cons_info.enable ) + { + snprintf(path, HYPFS_MAX_PATH, CONS_PATH "/evtchn", di->domid); + di->cons_info.evtchn_port = read_hypfs_uint32(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read xenstore event channel port\n"); + return -errno; + } + + snprintf(path, HYPFS_MAX_PATH, CONS_PATH "/mfn", di->domid); + di->cons_info.mfn = read_hypfs_uint64(hdl, path); + if ( errno != 0 ) + { + fprintf(stderr, "error: unable to read xenstore page mfn\n"); + return -errno; + } + } + + return 0; +} + diff --git a/tools/helpers/hypfs-helpers.h b/tools/helpers/hypfs-helpers.h new file mode 100644 index 0000000000..2b2de5967f --- /dev/null +++ b/tools/helpers/hypfs-helpers.h @@ -0,0 +1,9 @@ +#ifndef __HYPFS_HELPERS_H +#define __HYPFS_HELPERS_H + +#include "late-init-pv.h" + +bool has_builder_hypfs(xenhypfs_handle *hdl, uint32_t domid); +int read_hypfs_tree(xenhypfs_handle *hdl, struct domain_info *di); + +#endif diff --git a/tools/helpers/late-init-pv.c b/tools/helpers/late-init-pv.c new file mode 100644 index 0000000000..e1602be6d5 --- /dev/null +++ b/tools/helpers/late-init-pv.c @@ -0,0 +1,287 @@ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#include "hypfs-helpers.h" +#include "late-init-pv.h" +#include "xs-helpers.h" + +static struct option options[] = { + { "uuid", 1, NULL, 'u' }, + { "console", 0, NULL, 'c' }, + { "force", 0, NULL, 'f' }, + { "domain", 1, NULL, 'd' }, + { "verbose", 0, NULL, 'v' }, + { NULL, 0, NULL, 0 } +}; + +static void usage(void) +{ + fprintf(stderr, +"Usage:\n" +"\n" +"late-init-pv \n" +"\n" +"where options may include:\n" +"\n" +" --uuid override the UUID to use for the domain\n" +" --console configure the console\n" +" --force for @introduceDomain even if xenstore entries exist\n" +" --domain domain id of the domain to be initialized\n" +" -v[v[v]] verbosity constructing xenstore tree\n"); +} + +#define XS_DOM_PERM(x, d, k, v) \ + ret = do_xs_write_dom_with_perm(x, d, k, v, perms, num_perms); \ + if ( ret != 0 ) return ret \ + +#define XS_DIR_PERM(x, p, k, v) \ + ret = do_xs_write_dir_node_with_perm(x, p, k, v, perms, num_perms); \ + if ( ret != 0 ) return ret \ + +static int create_xs_entries( + struct xs_handle *xsh, uint16_t curr_domid, struct domain_info *di) +{ + char value[16]; + struct xs_permissions perms[2] = { + {.id = curr_domid, .perms = XS_PERM_NONE}, + {.id = di->domid, .perms = XS_PERM_READ}, + }; + uint32_t num_perms = (sizeof(perms) / sizeof((perms)[0])); + int ret = 0; + + while ( do_xs_start_transaction(xsh) == 0 ) + { + XS_DOM_PERM(xsh, di->domid, "", ""); + + snprintf(value, 16, "%d", di->domid); + XS_DOM_PERM(xsh, di->domid, "domid", value); + + XS_DOM_PERM(xsh, di->domid, "memory", ""); + snprintf(value, 16, "%d", di->mem_info.target); + XS_DOM_PERM(xsh, di->domid, "memory/target", value); + + if ( di->mem_info.max ) + snprintf(value, 16, "%d", di->mem_info.max); + else + snprintf(value, 16, "%d", di->mem_info.target); + XS_DOM_PERM(xsh, di->domid, "memory/static-max", value); + + XS_DOM_PERM(xsh, di->domid, "store", ""); + snprintf(value, 16, "%d", di->xs_info.evtchn_port); + XS_DOM_PERM(xsh, di->domid, "store/port", value); + + snprintf(value, 16, "%ld", di->xs_info.mfn); + XS_DOM_PERM(xsh, di->domid, "store/ring-ref", value); + + if ( di->cons_info.enable ) + { + char be_path[64], fe_path[64]; + + snprintf(fe_path, 64, "/local/domain/%d/console", di->domid); + snprintf(be_path, 64, "/local/domain/%d/backend/console/%d/0", + di->cons_info.be_domid, di->domid); + + /* Backend entries */ + XS_DIR_PERM(xsh, be_path, "", ""); + snprintf(value, 16, "%d", di->domid); + XS_DIR_PERM(xsh, be_path, "frontend-id", value); + XS_DIR_PERM(xsh, be_path, "frontend", fe_path); + XS_DIR_PERM(xsh, be_path, "online", "1"); + XS_DIR_PERM(xsh, be_path, "protocol", "vt100"); + + snprintf(value, 16, "%d", XenbusStateInitialising); + XS_DIR_PERM(xsh, be_path, "state", value); + + /* Frontend entries */ + XS_DOM_PERM(xsh, di->domid, "console", ""); + snprintf(value, 16, "%d", di->cons_info.be_domid); + XS_DIR_PERM(xsh, fe_path, "backend", be_path); + XS_DIR_PERM(xsh, fe_path, "backend-id", value); + XS_DIR_PERM(xsh, fe_path, "limit", "1048576"); + XS_DIR_PERM(xsh, fe_path, "type", "xenconsoled"); + XS_DIR_PERM(xsh, fe_path, "output", "pty"); + XS_DIR_PERM(xsh, fe_path, "tty", ""); + + snprintf(value, 16, "%d", di->cons_info.evtchn_port); + XS_DIR_PERM(xsh, fe_path, "port", value); + + snprintf(value, 16, "%ld", di->cons_info.mfn); + XS_DIR_PERM(xsh, fe_path, "ring-ref", value); + + } + + ret = do_xs_end_transaction(xsh); + switch ( ret ) + { + case 0: + break; /* proceed to loop break */ + case -EAGAIN: + continue; /* try again */ + default: + return ret; /* failed */ + } + + break; + } + + return ret; +} + +static bool init_domain(struct xs_handle *xsh, struct domain_info *di) +{ + xc_interface *xch = xc_interface_open(0, 0, 0); + xen_pfn_t con_mfn = 0L; + /*xc_dom_gnttab_seed will do nothing of front == back */ + uint32_t con_domid = di->domid; + int ret; + + /* console */ + if ( di->cons_info.enable ) + { + con_domid = di->cons_info.be_domid; + con_mfn = di->cons_info.mfn; + } + + ret = xc_dom_gnttab_seed(xch, di->domid, di->is_hvm, con_mfn, + di->xs_info.mfn, con_domid, di->xs_info.be_domid); + if ( ret != 0 ) + { + fprintf(stderr, "error (%d) setting up grant tables for dom%d\n", + ret, di->domid); + xc_interface_close(xch); + return false; + } + + xc_interface_close(xch); + + return xs_introduce_domain(xsh, di->domid, di->xs_info.mfn, + di->xs_info.evtchn_port); +} + +int main(int argc, char** argv) +{ + int opt, rv; + bool force = false; + struct xs_handle *xsh = NULL; + xenhypfs_handle *xhfs = NULL; + xentoollog_level minmsglevel = XTL_PROGRESS; + xentoollog_logger *logger = NULL; + struct domain_info di = { .domid = ~0 }; + + while ( (opt = getopt_long(argc, argv, "cfd:v", options, NULL)) != -1 ) + { + switch ( opt ) + { + case 'u': + di.override_uuid = true; + di.uuid = optarg; + break; + case 'c': + di.cons_info.enable = true; + break; + case 'f': + force = true; + break; + case 'd': + di.domid = strtol(optarg, NULL, 10); + break; + case 'v': + if ( minmsglevel ) + minmsglevel--; + break; + default: + usage(); + return 2; + } + } + + if ( optind != argc || di.domid == ~0 ) + { + usage(); + return 1; + } + + logger = (xentoollog_logger *)xtl_createlogger_stdiostream(stderr, + minmsglevel, 0); + + xhfs = xenhypfs_open(logger, 0); + if ( !xhfs ) + { + fprintf(stderr, "error: unable to acces xen hypfs\n"); + rv = 2; + goto out; + } + + if ( !has_builder_hypfs(xhfs, di.domid) ) + { + fprintf(stderr, "error: hypfs entry for domain %d not present\n", + di.domid); + rv = 3; + goto out; + } + + if ( read_hypfs_tree(xhfs, &di) != 0 ) + { + fprintf(stderr, "error: unable to parse hypfs for domain %d\n", + di.domid); + rv = 4; + goto out; + } + + xsh = xs_open(0); + if ( xsh == NULL ) + { + fprintf(stderr, "error: unable to connect to xenstored\n"); + rv = 5; + goto out; + } + + if ( xs_is_domain_introduced(xsh, di.domid) ) + { + if ( !force ) + { + fprintf(stderr, "error: domain %d already introduced\n", di.domid); + rv = 6; + goto out; + } + else + { + fprintf(stderr, "warning: re-introducting domain %d\n", di.domid); + } + } + + /* TODO: hardcdoding local domain to 0 for testing purposes */ + if ( (rv = create_xs_entries(xsh, 0, &di)) != 0 ) + { + fprintf(stderr, "error(%d): unable create xenstore entries\n", rv); + rv = 7; + goto out; + } + + init_domain(xsh, &di); + rv = 0; + +out: + if ( xsh ) + xs_close(xsh); + + if ( xhfs ) + xenhypfs_close(xhfs); + + if ( logger ) + xtl_logger_destroy(logger); + + return rv; +} diff --git a/tools/helpers/late-init-pv.h b/tools/helpers/late-init-pv.h new file mode 100644 index 0000000000..5d66e7870f --- /dev/null +++ b/tools/helpers/late-init-pv.h @@ -0,0 +1,29 @@ +#ifndef __LATE_INIT_PV_H +#define __LATE_INIT_PV_H + +struct domain_info { + uint16_t domid; + bool is_hvm; + bool override_uuid; + const char *uuid; + uint32_t num_cpu; + uint32_t max_cpu; + struct { + uint32_t target; + uint32_t max; + uint32_t video; + } mem_info; + struct { + uint16_t be_domid; + uint32_t evtchn_port; + uint64_t mfn; + } xs_info; + struct { + bool enable; + uint16_t be_domid; + uint32_t evtchn_port; + uint64_t mfn; + } cons_info; +}; + +#endif diff --git a/tools/helpers/xs-helpers.c b/tools/helpers/xs-helpers.c new file mode 100644 index 0000000000..a4d2bebbbd --- /dev/null +++ b/tools/helpers/xs-helpers.c @@ -0,0 +1,117 @@ + +#include +#include +#include +#include + +#define MAX_XS_PAATH 100 + +static xs_transaction_t t_id = XBT_NULL; + +int do_xs_start_transaction(struct xs_handle *xsh) +{ + t_id = xs_transaction_start(xsh); + if (t_id == XBT_NULL) + return -errno; + + return 0; +} + +int do_xs_end_transaction(struct xs_handle *xsh) +{ + if ( t_id == XBT_NULL ) + return -EINVAL; + + if (!xs_transaction_end(xsh, t_id, false)) + return -errno; + + return 0; +} + +int do_xs_write(struct xs_handle *xsh, char *path, char *val) +{ + if ( !xs_write(xsh, t_id, path, val, strlen(val)) ) + { + fprintf(stderr, "failed write: %s\n", path); + return -errno; + } + + return 0; +} + +int do_xs_perms( + struct xs_handle *xsh, char *path, struct xs_permissions *perms, + uint32_t num_perms) +{ + if ( !xs_set_permissions(xsh, t_id, path, perms, num_perms) ) + { + fprintf(stderr, "failed set perm: %s\n", path); + return -errno; + } + + return 0; +} + +int do_xs_write_dir_node_with_perm( + struct xs_handle *xsh, char *dir, char *node, char *val, + struct xs_permissions *perms, uint32_t num_perms) +{ + char full_path[MAX_XS_PAATH]; + int ret = 0; + + /* + * mainly for creating a value holding node, but + * also support creating directory nodes. + */ + if ( strlen(node) != 0 ) + snprintf(full_path, MAX_XS_PAATH, "%s/%s", dir, node); + else + snprintf(full_path, MAX_XS_PAATH, "%s", dir); + + ret = do_xs_write(xsh, full_path, val); + if ( ret < 0 ) + return ret; + + if ( perms != NULL && num_perms > 0 ) + ret = do_xs_perms(xsh, full_path, perms, num_perms); + + return ret; +} + +int do_xs_write_dir_node( + struct xs_handle *xsh, char *dir, char *node, char *val) +{ + return do_xs_write_dir_node_with_perm(xsh, dir, node, val, NULL, 0); +} + +int do_xs_write_dom_with_perm( + struct xs_handle *xsh, uint32_t domid, char *path, char *val, + struct xs_permissions *perms, uint32_t num_perms) +{ + char full_path[MAX_XS_PAATH]; + int ret = 0; + + /* + * mainly for creating a value holding node, but + * also support creating directory nodes. + */ + if ( strlen(path) != 0 ) + snprintf(full_path, MAX_XS_PAATH, "/local/domain/%d/%s", domid, path); + else + snprintf(full_path, MAX_XS_PAATH, "/local/domain/%d", domid); + + ret = do_xs_write(xsh, full_path, val); + if ( ret < 0 ) + return ret; + + if ( perms != NULL && num_perms > 0 ) + ret = do_xs_perms(xsh, full_path, perms, num_perms); + + return ret; +} + +int do_xs_write_dom( + struct xs_handle *xsh, uint32_t domid, char *path, char *val) +{ + return do_xs_write_dom_with_perm(xsh, domid, path, val, NULL, 0); +} diff --git a/tools/helpers/xs-helpers.h b/tools/helpers/xs-helpers.h new file mode 100644 index 0000000000..f57fcab843 --- /dev/null +++ b/tools/helpers/xs-helpers.h @@ -0,0 +1,27 @@ +#ifndef __XS_HELPERS_H +#define __XS_HELPERS_H + +#include + +int do_xs_start_transaction(struct xs_handle *xsh); +int do_xs_end_transaction(struct xs_handle *xsh); + +int do_xs_write(struct xs_handle *xsh, char *path, char *val); +int do_xs_perms( + struct xs_handle *xsh, char *path, struct xs_permissions *perms, + uint32_t num_perms); + +int do_xs_write_dir_node_with_perm( + struct xs_handle *xsh, char *dir, char *node, char *val, + struct xs_permissions *perms, uint32_t num_perms); +int do_xs_write_dir_node( + struct xs_handle *xsh, char *dir, char *node, char *val); + +int do_xs_write_dom_with_perm( + struct xs_handle *xsh, uint32_t domid, char *path, char *val, + struct xs_permissions *perms, uint32_t num_perms); +int do_xs_write_dom( + struct xs_handle *xsh, uint32_t domid, char *path, char *val); + +#endif + -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362590.592718 (Exim 4.92) (envelope-from ) id 1o9CPn-0004yj-Tk; Wed, 06 Jul 2022 21:18:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362590.592718; Wed, 06 Jul 2022 21:18:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CPn-0004yW-PM; Wed, 06 Jul 2022 21:18:31 +0000 Received: by outflank-mailman (input) for mailman id 362590; Wed, 06 Jul 2022 21:18:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGG-0003HV-Co for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:08:40 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd49b360-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:08:38 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141524647778.2526648624945; Wed, 6 Jul 2022 14:05:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd49b360-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141526; cv=none; d=zohomail.com; s=zohoarc; b=ivE0OgVasNv4eQ+byR5QWn20FbxaTUDbvjSFp7QK60cmoGErPzReroOliZ9dJcNo86nEzImdvkYHcLeQ0EE0i1mSC+sV3+welJ69edQhlqkuWydJEsg5xLd3xUZQIgk14bAKHFrXRu+zAnbD8+IGLihswPX/kGwE3g4q0tIt6yI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141526; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xIVNnCOl//0NwdRtYGKxNcLBDp2Qsryi1rBCkz4SStc=; b=NA5wwh6pTJaDIIYy6/E83Uv31PZFM7t/rjQcadECB5i4Fq1axnrHw49ObNlvXOPSxIFb3mOhgOR8VQWjEuhO1pPtuNdnTfYlCL0zqceDXJ9lPYIKIzzQNIH4Q1yxwnEZk++DsYLNu1/s0ySsi2lrBRh4kDRgoQS46Phh23O9HRY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141526; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=xIVNnCOl//0NwdRtYGKxNcLBDp2Qsryi1rBCkz4SStc=; b=AY9KKnkB06vn++m9x/9zLYHd04WXgZAGqZVmnQ120S7oQnhomKvMFWSSjhgdbGpM 4/+eyN9pEsyGzggIhX87IaIalNJlNIcUsdiQxA9WX8zTZgxlJnoXL+xBgh1maiQTWsi KvkpJF7h01BHXVVCBlJcogr1xHvhR1pzIRRtXrnA= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli Subject: [PATCH v1 14/18] x86: generalize vcpu for domain building Date: Wed, 6 Jul 2022 17:04:49 -0400 Message-Id: <20220706210454.30096-15-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Here, the vcpu initialization code for dom0 creation is generalized for use for other domains. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/domain_builder.c | 14 +++++++++++++- xen/arch/x86/hvm/dom0_build.c | 7 ++++--- xen/arch/x86/pv/dom0_build.c | 2 +- xen/common/sched/core.c | 25 ++++++++++++++++--------- xen/include/xen/sched.h | 3 ++- 5 files changed, 36 insertions(+), 15 deletions(-) diff --git a/xen/arch/x86/domain_builder.c b/xen/arch/x86/domain_builder.c index 308e1a1c67..1a4a6b1ca7 100644 --- a/xen/arch/x86/domain_builder.c +++ b/xen/arch/x86/domain_builder.c @@ -28,6 +28,18 @@ static unsigned int __init dom_max_vcpus(struct boot_domain *bd) return bd->ncpus; } +struct vcpu *__init alloc_dom_vcpu0(struct boot_domain *bd) +{ + if ( bd->functions & BUILD_FUNCTION_INITIAL_DOM ) + return alloc_dom0_vcpu0(bd->domain); + + bd->domain->node_affinity = node_online_map; + bd->domain->auto_node_affinity = true; + + return vcpu_create(bd->domain, 0); +} + + void __init arch_create_dom( const struct boot_info *bi, struct boot_domain *bd) { @@ -83,7 +95,7 @@ void __init arch_create_dom( init_dom0_cpuid_policy(bd->domain); - if ( alloc_dom0_vcpu0(bd->domain) == NULL ) + if ( alloc_dom_vcpu0(bd) == NULL ) panic("Error creating d%uv0\n", bd->domid); /* Grab the DOM0 command line. */ diff --git a/xen/arch/x86/hvm/dom0_build.c b/xen/arch/x86/hvm/dom0_build.c index 2fee2ed926..ae3ffc614d 100644 --- a/xen/arch/x86/hvm/dom0_build.c +++ b/xen/arch/x86/hvm/dom0_build.c @@ -696,9 +696,10 @@ static int __init pvh_load_kernel( return 0; } -static int __init pvh_setup_cpus(struct domain *d, paddr_t entry, +static int __init pvh_setup_cpus(struct boot_domain *bd, paddr_t entry, paddr_t start_info) { + struct domain *d = bd->domain; struct vcpu *v = d->vcpu[0]; int rc; /* @@ -722,7 +723,7 @@ static int __init pvh_setup_cpus(struct domain *d, paddr_t entry, .cpu_regs.x86_32.tr_ar = 0x8b, }; - sched_setup_dom0_vcpus(d); + sched_setup_dom_vcpus(bd); rc = arch_set_info_hvm_guest(v, &cpu_ctx); if ( rc ) @@ -1257,7 +1258,7 @@ int __init dom0_construct_pvh(struct boot_domain *bd) return rc; } - rc = pvh_setup_cpus(d, entry, start_info); + rc = pvh_setup_cpus(bd, entry, start_info); if ( rc ) { printk("Failed to setup Dom0 CPUs: %d\n", rc); diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index f1ea0575f0..9d1c9fb8b0 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -729,7 +729,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) printk("Dom%u has maximum %u VCPUs\n", d->domain_id, d->max_vcpus); - sched_setup_dom0_vcpus(d); + sched_setup_dom_vcpus(bd); d->arch.paging.mode = 0; diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index 250207038e..029f5ea24e 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -14,6 +14,8 @@ */ #ifndef COMPAT +#include +#include #include #include #include @@ -3399,13 +3401,13 @@ void wait(void) } #ifdef CONFIG_X86 -void __init sched_setup_dom0_vcpus(struct domain *d) +void __init sched_setup_dom_vcpus(struct boot_domain *bd) { unsigned int i; struct sched_unit *unit; - for ( i = 1; i < d->max_vcpus; i++ ) - vcpu_create(d, i); + for ( i = 1; i < bd->domain->max_vcpus; i++ ) + vcpu_create(bd->domain, i); /* * PV-shim: vcpus are pinned 1:1. @@ -3413,19 +3415,24 @@ void __init sched_setup_dom0_vcpus(struct domain *d) * onlining them. This avoids pinning a vcpu to a not yet online cpu here. */ if ( pv_shim ) - sched_set_affinity(d->vcpu[0]->sched_unit, + sched_set_affinity(bd->domain->vcpu[0]->sched_unit, cpumask_of(0), cpumask_of(0)); else { - for_each_sched_unit ( d, unit ) + for_each_sched_unit ( bd->domain, unit ) { - if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed ) - sched_set_affinity(unit, &dom0_cpus, NULL); - sched_set_affinity(unit, NULL, &dom0_cpus); + if ( builder_is_initdom(bd) ) + { + if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed ) + sched_set_affinity(unit, &dom0_cpus, NULL); + sched_set_affinity(unit, NULL, &dom0_cpus); + } + else + sched_set_affinity(unit, NULL, cpupool_valid_cpus(cpupool0)); } } - domain_update_node_affinity(d); + domain_update_node_affinity(bd->domain); } #endif diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b9515eb497..6ab7d69cbd 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -2,6 +2,7 @@ #ifndef __SCHED_H__ #define __SCHED_H__ +#include #include #include #include @@ -1003,7 +1004,7 @@ static inline bool sched_has_urgent_vcpu(void) } void vcpu_set_periodic_timer(struct vcpu *v, s_time_t value); -void sched_setup_dom0_vcpus(struct domain *d); +void sched_setup_dom_vcpus(struct boot_domain *d); int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t reason); int vcpu_set_hard_affinity(struct vcpu *v, const cpumask_t *affinity); void restore_vcpu_affinity(struct domain *d); -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362592.592723 (Exim 4.92) (envelope-from ) id 1o9CPo-00053l-A2; Wed, 06 Jul 2022 21:18:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362592.592723; Wed, 06 Jul 2022 21:18:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CPo-00052n-3f; Wed, 06 Jul 2022 21:18:32 +0000 Received: by outflank-mailman (input) for mailman id 362592; Wed, 06 Jul 2022 21:18:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CGq-0003HV-3V for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:09:16 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3214e47-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:09:14 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141528926584.3775148690877; Wed, 6 Jul 2022 14:05:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3214e47-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141530; cv=none; d=zohomail.com; s=zohoarc; b=N/FSL553HNCEa+TyNxWgI3ljiv4gg26j+KpjtiAjGUSlauyoUajpteJxNg7Jyy6Af3ugKVX9kpz5eob6Mk9uzLDrLqhu8aXf4wz0/e1JEVpkx6C/Tvvu2jgAp4cpWCfrCzZF+Ho2atm9u11XL7qgUR4dP6DchsYV7VKREwOEN0U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141530; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=uq/k8IUdG9nFheQBakIgF1OjCIHV4VLDEfRMPtZOoM8=; b=H5/S1fH1YZaeMcEQ3dOAI6jaIhWA12cDBec+iG1nb+ONKanf1xzIXuAwty+mETeOeFyXetRvjar64iVwKaKUXmG1WraATQ5HoFCaC9a9+dnJNLw581uFvlTn5qIy8iyfS4qC1sPY+8k9/vZRMHlZkM4dWwKxQ8UAQtBzBovWAhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141530; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=uq/k8IUdG9nFheQBakIgF1OjCIHV4VLDEfRMPtZOoM8=; b=bTNmAkvNs5MuJJWJBKqoCkjuO2VQ39BIvTeyEFTZb1nuzjCqnnzvEcoWhLsHH0KO tOrRcuESCFR2uzzOEPiL+jn2kA/hwybXIbPmTfXuy96Y63G1gmbr8c6JKZHou1MtVtk k2sEkZEoLi8N2IKJ617BthcUY51iiE+FGOF9Z+Os= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v1 17/18] builder: introduce domain builder hypfs tree Date: Wed, 6 Jul 2022 17:04:52 -0400 Message-Id: <20220706210454.30096-18-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This enables domain builder to construct a hypfs tree to expose relevant domain creation information for use by the boot domain and/or the runtime system. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/common/domain-builder/Kconfig | 11 ++ xen/common/domain-builder/Makefile | 1 + xen/common/domain-builder/core.c | 3 + xen/common/domain-builder/hypfs.c | 193 +++++++++++++++++++++++++++++ xen/include/xen/domain_builder.h | 13 ++ 5 files changed, 221 insertions(+) create mode 100644 xen/common/domain-builder/hypfs.c diff --git a/xen/common/domain-builder/Kconfig b/xen/common/domain-builder/Kconfig index 0232e1ed8a..4b98cccfab 100644 --- a/xen/common/domain-builder/Kconfig +++ b/xen/common/domain-builder/Kconfig @@ -22,4 +22,15 @@ config MULTIDOM_BUILDER If unsure, say N. +config BUILDER_HYPFS + bool "Domain builder hypfs support (UNSUPPORTED)" if UNSUPPORTED + depends on HYPFS + ---help--- + Exposes the domain builder construction information + through hypfs. + + This feature is currently experimental. + + If unsure, say N. + endmenu diff --git a/xen/common/domain-builder/Makefile b/xen/common/domain-builder/Makefile index 9561602502..7aa2ea2a53 100644 --- a/xen/common/domain-builder/Makefile +++ b/xen/common/domain-builder/Makefile @@ -1,2 +1,3 @@ obj-$(CONFIG_BUILDER_FDT) += fdt.o +obj-$(CONFIG_HYPFS) += hypfs.o obj-y += core.o diff --git a/xen/common/domain-builder/core.c b/xen/common/domain-builder/core.c index c6a268eb96..f41ca3ed35 100644 --- a/xen/common/domain-builder/core.c +++ b/xen/common/domain-builder/core.c @@ -134,6 +134,9 @@ uint32_t __init builder_create_domains(struct boot_info *info) /* Free temporary buffers. */ discard_initial_images(); + if ( IS_ENABLED(CONFIG_BUILDER_HYPFS) ) + builder_hypfs(info); + return build_count; } diff --git a/xen/common/domain-builder/hypfs.c b/xen/common/domain-builder/hypfs.c new file mode 100644 index 0000000000..28f8b13d85 --- /dev/null +++ b/xen/common/domain-builder/hypfs.c @@ -0,0 +1,193 @@ +#include +#include +#include +#include +#include +#include +#include +#include + +#define INIT_HYPFS_DIR(var, nam) \ + var.e.type = XEN_HYPFS_TYPE_DIR; \ + var.e.encoding = XEN_HYPFS_ENC_PLAIN; \ + var.e.name = (nam); \ + var.e.size = 0; \ + var.e.max_size = 0; \ + INIT_LIST_HEAD(&var.e.list); \ + var.e.funcs = (&hypfs_dir_funcs); \ + INIT_LIST_HEAD(&var.dirlist) + +#define INIT_HYPFS_FIXEDSIZE(var, typ, nam, contvar, fn, wr) \ + var.e.type = (typ); \ + var.e.encoding = XEN_HYPFS_ENC_PLAIN; \ + var.e.name = (nam); \ + var.e.size = sizeof(contvar); \ + var.e.max_size = (wr) ? sizeof(contvar) : 0; \ + var.e.funcs = (fn); \ + var.u.content = &(contvar) + +#define INIT_HYPFS_UINT(var, nam, contvar) \ + INIT_HYPFS_FIXEDSIZE(var, XEN_HYPFS_TYPE_UINT, nam, contvar, \ + &hypfs_leaf_ro_funcs, 0) + +#define INIT_HYPFS_BOOL(var, nam, contvar) \ + INIT_HYPFS_FIXEDSIZE(var, XEN_HYPFS_TYPE_BOOL, nam, contvar, \ + &hypfs_leaf_ro_funcs, 0) + +#define INIT_HYPFS_VARSIZE(var, typ, nam, msz, fn) \ + var.e.type = (typ) ; \ + var.e.encoding = XEN_HYPFS_ENC_PLAIN; \ + var.e.name = (nam); \ + var.e.max_size = (msz); \ + var.e.funcs = (fn) + +#define INIT_HYPFS_STRING(var, nam) \ + INIT_HYPFS_VARSIZE(var, XEN_HYPFS_TYPE_STRING, nam, 0, &hypfs_leaf_ro_funcs) + +struct device_node { + struct hypfs_entry_dir dir; + + uint32_t evtchn; + struct hypfs_entry_leaf evtchn_leaf; + + xen_pfn_t mfn; + struct hypfs_entry_leaf mfn_leaf; +}; + +struct domain_node { + char dir_name[HYPFS_DYNDIR_ID_NAMELEN]; + struct hypfs_entry_dir dir; + + char uuid[40]; + struct hypfs_entry_leaf uuid_leaf; + + uint16_t functions; + struct hypfs_entry_leaf func_leaf; + + uint32_t ncpus; + struct hypfs_entry_leaf ncpus_leaf; + + uint32_t mem_size; + struct hypfs_entry_leaf mem_sz_leaf; + + uint32_t mem_max; + struct hypfs_entry_leaf mem_mx_leaf; + + bool constructed; + struct hypfs_entry_leaf const_leaf; + + struct device_node xs; + + struct hypfs_entry_dir dev_dir; + + struct device_node con_dev; +}; + +static struct hypfs_entry_dir __read_mostly *builder_dir; +static struct domain_node __read_mostly *entries; + +static int __init alloc_hypfs(struct boot_info *info) +{ + if ( !(builder_dir = (struct hypfs_entry_dir *)xmalloc_bytes( + sizeof(struct hypfs_entry_dir))) ) + { + printk(XENLOG_WARNING "%s: unable to allocate hypfs dir\n", __func__); + return -ENOMEM; + } + + builder_dir->e.type = XEN_HYPFS_TYPE_DIR; + builder_dir->e.encoding = XEN_HYPFS_ENC_PLAIN; + builder_dir->e.name = "builder"; + builder_dir->e.size = 0; + builder_dir->e.max_size = 0; + INIT_LIST_HEAD(&builder_dir->e.list); + builder_dir->e.funcs = &hypfs_dir_funcs; + INIT_LIST_HEAD(&builder_dir->dirlist); + + if ( !(entries = (struct domain_node *)xmalloc_bytes( + sizeof(struct domain_node) * info->builder->nr_doms)) ) + { + printk(XENLOG_WARNING "%s: unable to allocate hypfs nodes\n", __func__); + return -ENOMEM; + } + + return 0; +} + +void __init builder_hypfs(struct boot_info *info) +{ + int i; + + printk("Domain Builder: creating hypfs nodes\n"); + + if ( alloc_hypfs(info) != 0 ) + return; + + for ( i = 0; i < info->builder->nr_doms; i++ ) + { + struct domain_node *e = &entries[i]; + struct boot_domain *bd = &info->builder->domains[i]; + uint8_t *uuid = bd->uuid; + + snprintf(e->dir_name, sizeof(e->dir_name), "%d", bd->domid); + + snprintf(e->uuid, sizeof(e->uuid), "%08x-%04x-%04x-%04x-%04x%08x", + *(uint32_t *)uuid, *(uint16_t *)(uuid+4), + *(uint16_t *)(uuid+6), *(uint16_t *)(uuid+8), + *(uint16_t *)(uuid+10), *(uint32_t *)(uuid+12)); + + e->functions = bd->functions; + e->constructed = bd->constructed; + + e->ncpus = bd->ncpus; + e->mem_size = (bd->meminfo.mem_size.nr_pages * PAGE_SIZE)/1024; + e->mem_max = (bd->meminfo.mem_max.nr_pages * PAGE_SIZE)/1024; + + e->xs.evtchn = bd->store.evtchn; + e->xs.mfn = bd->store.mfn; + + e->con_dev.evtchn = bd->console.evtchn; + e->con_dev.mfn = bd->console.mfn; + + /* Initialize and construct builder hypfs tree */ + INIT_HYPFS_DIR(e->dir, e->dir_name); + INIT_HYPFS_DIR(e->xs.dir, "xenstore"); + INIT_HYPFS_DIR(e->dev_dir, "devices"); + INIT_HYPFS_DIR(e->con_dev.dir, "console"); + + INIT_HYPFS_STRING(e->uuid_leaf, "uuid"); + hypfs_string_set_reference(&e->uuid_leaf, e->uuid); + INIT_HYPFS_UINT(e->func_leaf, "functions", e->functions); + INIT_HYPFS_UINT(e->ncpus_leaf, "ncpus", e->ncpus); + INIT_HYPFS_UINT(e->mem_sz_leaf, "mem_size", e->mem_size); + INIT_HYPFS_UINT(e->mem_mx_leaf, "mem_max", e->mem_max); + INIT_HYPFS_BOOL(e->const_leaf, "constructed", e->constructed); + + INIT_HYPFS_UINT(e->xs.evtchn_leaf, "evtchn", e->xs.evtchn); + INIT_HYPFS_UINT(e->xs.mfn_leaf, "mfn", e->xs.mfn); + + INIT_HYPFS_UINT(e->con_dev.evtchn_leaf, "evtchn", e->con_dev.evtchn); + INIT_HYPFS_UINT(e->con_dev.mfn_leaf, "mfn", e->con_dev.mfn); + + hypfs_add_leaf(&e->con_dev.dir, &e->con_dev.evtchn_leaf, true); + hypfs_add_leaf(&e->con_dev.dir, &e->con_dev.mfn_leaf, true); + hypfs_add_dir(&e->dev_dir, &e->con_dev.dir, true); + + hypfs_add_dir(&e->dir, &e->dev_dir, true); + + hypfs_add_leaf(&e->xs.dir, &e->xs.evtchn_leaf, true); + hypfs_add_leaf(&e->xs.dir, &e->xs.mfn_leaf, true); + hypfs_add_dir(&e->dir, &e->xs.dir, true); + + hypfs_add_leaf(&e->dir, &e->uuid_leaf, true); + hypfs_add_leaf(&e->dir, &e->func_leaf, true); + hypfs_add_leaf(&e->dir, &e->ncpus_leaf, true); + hypfs_add_leaf(&e->dir, &e->mem_sz_leaf, true); + hypfs_add_leaf(&e->dir, &e->mem_mx_leaf, true); + hypfs_add_leaf(&e->dir, &e->const_leaf, true); + + hypfs_add_dir(builder_dir, &e->dir, true); + } + + hypfs_add_dir(&hypfs_root, builder_dir, true); +} diff --git a/xen/include/xen/domain_builder.h b/xen/include/xen/domain_builder.h index f9e43c9689..086968b0fe 100644 --- a/xen/include/xen/domain_builder.h +++ b/xen/include/xen/domain_builder.h @@ -72,4 +72,17 @@ int alloc_system_evtchn( const struct boot_info *info, struct boot_domain *bd); void arch_create_dom(const struct boot_info *bi, struct boot_domain *bd); +#ifdef CONFIG_HYPFS + +void builder_hypfs(struct boot_info *info); + +#else + +static inline void builder_hypfs(struct boot_info *info) +{ + return; +} + +#endif + #endif /* XEN_DOMAIN_BUILDER_H */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362613.592740 (Exim 4.92) (envelope-from ) id 1o9CQA-0006SI-L4; Wed, 06 Jul 2022 21:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362613.592740; Wed, 06 Jul 2022 21:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CQA-0006SB-HX; Wed, 06 Jul 2022 21:18:54 +0000 Received: by outflank-mailman (input) for mailman id 362613; Wed, 06 Jul 2022 21:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CFv-0003HV-PX for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:08:20 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c1896274-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:08:18 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141521883800.3456952982841; Wed, 6 Jul 2022 14:05:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1896274-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141523; cv=none; d=zohomail.com; s=zohoarc; b=bAdaahGy4J37SFBsKk5H8bc+Y1NpSUjAYPOdZs9WMqgWUmz/Zwvvrfzy5TTzr8DH/vQKwczjCFpIjtRXMcqYkGwHNYpYwt+WN8h5//jorw4xFY3eOXvmHEFZyYVTIyzbpCA3DoXgNMrx4Qui1HqXSp5WQrY3T7PZgkLJCFn17oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141523; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=5yZIw87G7JzBKuFzenXeWr5cm81sZ/kPE47Ov9/J3Yw=; b=VrsMbbhs0gZbthX97HQSVVe0xHZ3BGb5gaYIJGs6PRAj8r/ktQ9r4WyNOplBTDVjiChPHg4tMWOiVsSlw2jA2DM/IOMt1Pd1ZftGRgg7MfZsFvaRjepWBVrgDZy3OoY6EHLmk4y1ByEUEq8hTShEyWcDjntlW82YCItpAWVYcVk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141523; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=5yZIw87G7JzBKuFzenXeWr5cm81sZ/kPE47Ov9/J3Yw=; b=HcH8j7DdN//CuLxUG8WR8URHxc2t0ESQHkc/VOm3waVqk4MQwx5E/uRU6qfE/Z7v spXjlI0NNzYSAseOlfEFUr0W4Gu7VaHq/KjJglaRkpzeVTQ5y1MpnSSH5Or5pu8uapp R1Fz8xz23VqlfKM4K9aHk8so8nv4sLtp1f5I172g= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 12/18] x86: convert dom0 creation to domain builder Date: Wed, 6 Jul 2022 17:04:47 -0400 Message-Id: <20220706210454.30096-13-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External This commit begins the transtion over to domain builder by coverting the dom0 creation logic into a generalized domain creation logic. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/Makefile | 1 + xen/arch/x86/domain_builder.c | 128 +++++++++++++++++++++++++++++++ xen/arch/x86/include/asm/setup.h | 1 + xen/arch/x86/setup.c | 109 +++----------------------- 4 files changed, 141 insertions(+), 98 deletions(-) create mode 100644 xen/arch/x86/domain_builder.c diff --git a/xen/arch/x86/Makefile b/xen/arch/x86/Makefile index 177a2ff742..2d5d398551 100644 --- a/xen/arch/x86/Makefile +++ b/xen/arch/x86/Makefile @@ -27,6 +27,7 @@ obj-y += desc.o obj-bin-y += dmi_scan.init.o obj-y += domain.o obj-bin-y += dom0_build.init.o +obj-bin-y += domain_builder.init.o obj-y += domain_page.o obj-y += e820.o obj-y += emul-i8254.o diff --git a/xen/arch/x86/domain_builder.c b/xen/arch/x86/domain_builder.c new file mode 100644 index 0000000000..308e1a1c67 --- /dev/null +++ b/xen/arch/x86/domain_builder.c @@ -0,0 +1,128 @@ +#include +#include +#include +#include +#include +#include +#include +#include + +#include +#include + +extern unsigned long cr4_pv32_mask; + +static unsigned int __init dom_max_vcpus(struct boot_domain *bd) +{ + unsigned int limit; + + if ( builder_is_initdom(bd) ) + return dom0_max_vcpus(); + + limit = bd->mode & BUILD_MODE_PARAVIRTUALIZED ? + MAX_VIRT_CPUS : HVM_MAX_VCPUS; + + if ( bd->ncpus > limit ) + return limit; + else + return bd->ncpus; +} + +void __init arch_create_dom( + const struct boot_info *bi, struct boot_domain *bd) +{ + struct xen_domctl_createdomain dom_cfg = { + .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, + .max_evtchn_port = -1, + .max_grant_frames = -1, + .max_maptrack_frames = -1, + .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), + .max_vcpus = dom_max_vcpus(bd), + .arch = { + .misc_flags = bd->functions & BUILD_FUNCTION_INITIAL_DOM && + opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, + }, + }; + unsigned int is_privileged = 0; + char *cmdline; + + if ( bd->kernel == NULL ) + panic("Error creating d%uv0\n", bd->domid); + + /* mask out PV and device model bits, if 0 then the domain is PVH */ + if ( !(bd->mode & + (BUILD_MODE_PARAVIRTUALIZED|BUILD_MODE_ENABLE_DEVICE_MODEL)) ) + { + dom_cfg.flags |= (XEN_DOMCTL_CDF_hvm | + (hvm_hap_supported() ? XEN_DOMCTL_CDF_hap : 0)); + + /* + * If shadow paging is enabled for the initial domain, mask out + * HAP if it was just enabled. + */ + if ( builder_is_initdom(bd) ) + if ( opt_dom0_shadow ) + dom_cfg.flags |= ~XEN_DOMCTL_CDF_hap; + + /* TODO: review which flags should be present */ + dom_cfg.arch.emulation_flags |= + XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; + } + + if ( iommu_enabled && builder_is_hwdom(bd) ) + dom_cfg.flags |= XEN_DOMCTL_CDF_iommu; + + if ( !pv_shim && builder_is_ctldom(bd) ) + is_privileged = CDF_privileged; + + /* Create initial domain. Not d0 for pvshim. */ + bd->domid = get_initial_domain_id(); + bd->domain = domain_create(bd->domid, &dom_cfg, is_privileged); + if ( IS_ERR(bd->domain) ) + panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); + + init_dom0_cpuid_policy(bd->domain); + + if ( alloc_dom0_vcpu0(bd->domain) == NULL ) + panic("Error creating d%uv0\n", bd->domid); + + /* Grab the DOM0 command line. */ + cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? + bd->kernel->string.bytes : NULL; + if ( cmdline || bi->arch->kextra ) + { + char dom_cmdline[MAX_GUEST_CMDLINE]; + + cmdline = arch_prepare_cmdline(cmdline, bi->arch); + strlcpy(dom_cmdline, cmdline, MAX_GUEST_CMDLINE); + + if ( bi->arch->kextra ) + /* kextra always includes exactly one leading space. */ + strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); + + apply_xen_cmdline(dom_cmdline); + + strlcpy(bd->kernel->string.bytes, dom_cmdline, MAX_GUEST_CMDLINE); + } + + /* + * Temporarily clear SMAP in CR4 to allow user-accesses in construct_dom0(). + * This saves a large number of corner cases interactions with + * copy_from_user(). + */ + if ( cpu_has_smap ) + { + cr4_pv32_mask &= ~X86_CR4_SMAP; + write_cr4(read_cr4() & ~X86_CR4_SMAP); + } + + if ( construct_domain(bd) != 0 ) + panic("Could not construct domain 0\n"); + + if ( cpu_has_smap ) + { + write_cr4(read_cr4() | X86_CR4_SMAP); + cr4_pv32_mask |= X86_CR4_SMAP; + } +} + diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index f9c1468fcc..6f53623fb3 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -33,6 +33,7 @@ void vesa_init(void); static inline void vesa_init(void) {}; #endif +void apply_xen_cmdline(char *cmdline); int construct_domain(struct boot_domain *bd); void setup_io_bitmap(struct domain *d); diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index 860b9e3d64..479b9fa149 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include #include @@ -745,109 +746,21 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li return n; } -static struct domain *__init create_dom0( - const struct boot_info *bi, struct boot_domain *bd) +void __init apply_xen_cmdline(char *cmdline) { - struct xen_domctl_createdomain dom0_cfg = { - .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, - .max_evtchn_port = -1, - .max_grant_frames = -1, - .max_maptrack_frames = -1, - .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), - .max_vcpus = dom0_max_vcpus(), - .arch = { - .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, - }, - }; - char *cmdline; - - if ( bd->kernel == NULL ) - panic("Error creating d%uv0\n", bd->domid); - - if ( opt_dom0_pvh ) - { - dom0_cfg.flags |= (XEN_DOMCTL_CDF_hvm | - ((hvm_hap_supported() && !opt_dom0_shadow) ? - XEN_DOMCTL_CDF_hap : 0)); - - dom0_cfg.arch.emulation_flags |= - XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; - } - - if ( iommu_enabled ) - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; - - /* Create initial domain. Not d0 for pvshim. */ - bd->domid = get_initial_domain_id(); - bd->domain = domain_create(bd->domid, &dom0_cfg, pv_shim ? - 0 : CDF_privileged); - if ( IS_ERR(bd->domain) ) - panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); - - init_dom0_cpuid_policy(bd->domain); - - if ( alloc_dom0_vcpu0(bd->domain) == NULL ) - panic("Error creating d%uv0\n", bd->domid); - - /* Grab the DOM0 command line. */ - cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? - bd->kernel->string.bytes : NULL; - if ( cmdline || bi->arch->kextra ) - { - char dom0_cmdline[MAX_GUEST_CMDLINE]; - - cmdline = arch_prepare_cmdline(cmdline, bi->arch); - strlcpy(dom0_cmdline, cmdline, MAX_GUEST_CMDLINE); - - if ( bi->arch->kextra ) - /* kextra always includes exactly one leading space. */ - strlcat(dom0_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); - - /* Append any extra parameters. */ - if ( skip_ioapic_setup && !strstr(dom0_cmdline, "noapic") ) - strlcat(dom0_cmdline, " noapic", MAX_GUEST_CMDLINE); - if ( (strlen(acpi_param) == 0) && acpi_disabled ) - { - printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); - strlcpy(acpi_param, "off", sizeof(acpi_param)); - } - if ( (strlen(acpi_param) != 0) && !strstr(dom0_cmdline, "acpi=") ) - { - strlcat(dom0_cmdline, " acpi=", MAX_GUEST_CMDLINE); - strlcat(dom0_cmdline, acpi_param, MAX_GUEST_CMDLINE); - } - - strlcpy(bd->kernel->string.bytes, dom0_cmdline, MAX_GUEST_CMDLINE); - } - - /* - * Temporarily clear SMAP in CR4 to allow user-accesses in construct_dom0(). - * This saves a large number of corner cases interactions with - * copy_from_user(). - */ - if ( cpu_has_smap ) + if ( skip_ioapic_setup && !strstr(cmdline, "noapic") ) + strlcat(cmdline, " noapic", MAX_GUEST_CMDLINE); + if ( (strlen(acpi_param) == 0) && acpi_disabled ) { - cr4_pv32_mask &= ~X86_CR4_SMAP; - write_cr4(read_cr4() & ~X86_CR4_SMAP); + printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); + strlcpy(acpi_param, "off", sizeof(acpi_param)); } - - if ( construct_domain(bd) != 0 ) - panic("Could not construct domain 0\n"); - - if ( cpu_has_smap ) + if ( (strlen(acpi_param) != 0) && + !strstr(cmdline, "acpi=") ) { - write_cr4(read_cr4() | X86_CR4_SMAP); - cr4_pv32_mask |= X86_CR4_SMAP; + strlcat(cmdline, " acpi=", MAX_GUEST_CMDLINE); + strlcat(cmdline, acpi_param, MAX_GUEST_CMDLINE); } - - return bd->domain; -} - -void __init arch_create_dom( - const struct boot_info *bi, struct boot_domain *bd) -{ - if ( builder_is_initdom(bd) ) - create_dom0(bi, bd); } /* How much of the directmap is prebuilt at compile time. */ -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 21:18:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 21:18:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362615.592743 (Exim 4.92) (envelope-from ) id 1o9CQA-0006Vx-Ub; Wed, 06 Jul 2022 21:18:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362615.592743; Wed, 06 Jul 2022 21:18:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CQA-0006V2-Qe; Wed, 06 Jul 2022 21:18:54 +0000 Received: by outflank-mailman (input) for mailman id 362615; Wed, 06 Jul 2022 21:18:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9CG5-0003HV-CG for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 21:08:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c751cda8-fd6f-11ec-924f-1f966e50362f; Wed, 06 Jul 2022 23:08:28 +0200 (CEST) Received: from sisyou.hme. (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657141523099239.14805637871416; Wed, 6 Jul 2022 14:05:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c751cda8-fd6f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1657141524; cv=none; d=zohomail.com; s=zohoarc; b=gprjnvHTCj66K/3zl3xhHAr3DXoKXA6PrEBBEZ49G2TOXH1XZxa2Tc6C4UMBoeW1Q66kFf5ub/ut0lmqwSR72NeUBuAUhkeolKv5LIrTrDFI3oESHd5BoMyuE2YvGp7hmGhkzNWOtQd9Rr7bsH6IPNn83jyeMqr9oFaRzLtPkbU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657141524; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WXmYD77YrhMc0tVJJp6RofHh/xQBmFJZqWBf4zSdvRM=; b=kF1fopmFVLXRCb0oG8SdiEpHINmWL3fgc14URNgau+LHLybQa2KwwHlKEYMswFj1y56cIvoxOWT6RjNQAYj88LnO9r6xCPsE/Pvpb1gPIgMNz6j7cBlyxJhffRGOz+0d3ENmlR/WQxFdcSDdaZWyib4iUO0eeat9cisxCKBPqMc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657141524; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-Id:Message-Id:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Reply-To; bh=WXmYD77YrhMc0tVJJp6RofHh/xQBmFJZqWBf4zSdvRM=; b=Pg4ZizoMIlxabe1CMIbyfMFO6yj6riZclXmO0O+HIaYdhWnOclu+DFPmxWcQaOuu u/R8ZTkPzgzFInWByC30mkDUEkoNBhXW0XqwohkreQPmMn68OmN0cgZt0tKXlYizng7 tEZ+BwCtVrprC7E5i4D075yzfVnJwnAxA8FqThMo= From: "Daniel P. Smith" To: xen-devel@lists.xenproject.org, Wei Liu Cc: "Daniel P. Smith" , scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v1 13/18] x86: generalize physmap logic Date: Wed, 6 Jul 2022 17:04:48 -0400 Message-Id: <20220706210454.30096-14-dpsmith@apertussolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> References: <20220706210454.30096-1-dpsmith@apertussolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External The existing physmap code is specific to dom0. In this commit, the dom0 physmap code is generalized for any domain and functions are renamed to reflect their new general nature. Signed-off-by: Daniel P. Smith Reviewed-by: Christopher Clark --- xen/arch/x86/include/asm/dom0_build.h | 2 +- xen/arch/x86/pv/dom0_build.c | 10 +++++----- xen/arch/x86/pv/shim.c | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/xen/arch/x86/include/asm/dom0_build.h b/xen/arch/x86/include/asm/dom0_build.h index 571b25ea71..f30e4b860a 100644 --- a/xen/arch/x86/include/asm/dom0_build.h +++ b/xen/arch/x86/include/asm/dom0_build.h @@ -21,7 +21,7 @@ int dom0_construct_pvh(struct boot_domain *bd); unsigned long dom0_paging_pages(const struct domain *d, unsigned long nr_pages); -void dom0_update_physmap(bool compat, unsigned long pfn, +void dom_update_physmap(bool compat, unsigned long pfn, unsigned long mfn, unsigned long vphysmap_s); #endif /* _DOM0_BUILD_H_ */ diff --git a/xen/arch/x86/pv/dom0_build.c b/xen/arch/x86/pv/dom0_build.c index 78ebb03b1b..f1ea0575f0 100644 --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -34,8 +34,8 @@ #define L3_PROT (BASE_PROT|_PAGE_DIRTY) #define L4_PROT (BASE_PROT|_PAGE_DIRTY) -void __init dom0_update_physmap(bool compat, unsigned long pfn, - unsigned long mfn, unsigned long vphysmap_s) +void __init dom_update_physmap( + bool compat, unsigned long pfn, unsigned long mfn, unsigned long vphysmap_s) { if ( !compat ) ((unsigned long *)vphysmap_s)[pfn] = mfn; @@ -815,7 +815,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) if ( pfn > REVERSE_START && (vinitrd_start || pfn < initrd_pfn) ) mfn = alloc_epfn - (pfn - REVERSE_START); #endif - dom0_update_physmap(compat, pfn, mfn, vphysmap_start); + dom_update_physmap(compat, pfn, mfn, vphysmap_start); if ( !(pfn & 0xfffff) ) process_pending_softirqs(); } @@ -831,7 +831,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) !get_page_and_type(page, d, PGT_writable_page) ) BUG(); - dom0_update_physmap(compat, pfn, mfn, vphysmap_start); + dom_update_physmap(compat, pfn, mfn, vphysmap_start); ++pfn; if ( !(pfn & 0xfffff) ) process_pending_softirqs(); @@ -851,7 +851,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) #ifndef NDEBUG #define pfn (nr_pages - 1 - (pfn - (alloc_epfn - alloc_spfn))) #endif - dom0_update_physmap(compat, pfn, mfn, vphysmap_start); + dom_update_physmap(compat, pfn, mfn, vphysmap_start); #undef pfn page++; pfn++; if ( !(pfn & 0xfffff) ) diff --git a/xen/arch/x86/pv/shim.c b/xen/arch/x86/pv/shim.c index 2ee290a392..fb2a7ef393 100644 --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -210,7 +210,7 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start, { \ share_xen_page_with_guest(mfn_to_page(_mfn(param)), d, SHARE_rw); \ replace_va_mapping(d, l4start, va, _mfn(param)); \ - dom0_update_physmap(compat, \ + dom_update_physmap(compat, \ PFN_DOWN((va) - va_start), param, vphysmap); \ } \ else \ @@ -238,7 +238,7 @@ void __init pv_shim_setup_dom(struct domain *d, l4_pgentry_t *l4start, si->console.domU.mfn = mfn_x(console_mfn); share_xen_page_with_guest(mfn_to_page(console_mfn), d, SHARE_rw); replace_va_mapping(d, l4start, console_va, console_mfn); - dom0_update_physmap(compat, (console_va - va_start) >> PAGE_SHIFT, + dom_update_physmap(compat, (console_va - va_start) >> PAGE_SHIFT, mfn_x(console_mfn), vphysmap); consoled_set_ring_addr(page); } -- 2.20.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 06 22:14:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 22:14:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362639.592762 (Exim 4.92) (envelope-from ) id 1o9DI8-0006ym-D9; Wed, 06 Jul 2022 22:14:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362639.592762; Wed, 06 Jul 2022 22:14:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9DI8-0006yf-9K; Wed, 06 Jul 2022 22:14:40 +0000 Received: by outflank-mailman (input) for mailman id 362639; Wed, 06 Jul 2022 22:14:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9DI7-0006yV-5r; Wed, 06 Jul 2022 22:14:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9DI7-0003Jc-2f; Wed, 06 Jul 2022 22:14:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9DI6-0004B6-NE; Wed, 06 Jul 2022 22:14:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9DI6-0007AC-Mi; Wed, 06 Jul 2022 22:14:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6h+1y4xubKKG3qmK+v9pIMmsbaS71Hqme/bUSSeJNIU=; b=Zrf9YhobFKxK+Vx47xsKWOm+CK 8W+4g6N60bmvTcCIlbY+Ozs2XQmkUw3F2CuIzoVVD3nPgMS2gmSnkDV6s+zcIfxHt1OLPrVNaCmri FquUsKvM4rT2m+q6iTI2Ze0kb9kYpU2T63GUtzazAz+25WtIr0WLiU7d9NAaUukQ6+Bg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171528: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e35e5b6f695d241ffb1d223207da58a1fbcdff4b X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Wed, 06 Jul 2022 22:14:38 +0000 flight 171528 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171528/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e35e5b6f695d241ffb1d223207da58a1fbcdff4b baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 17 days Failing since 171280 2022-06-19 15:12:25 Z 17 days 46 attempts Testing same since 171514 2022-07-05 23:41:16 Z 0 days 2 attempts ------------------------------------------------------------ 488 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 19695 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 06 23:42:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 23:42:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362648.592773 (Exim 4.92) (envelope-from ) id 1o9Ef5-0002DS-Tj; Wed, 06 Jul 2022 23:42:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362648.592773; Wed, 06 Jul 2022 23:42:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Ef5-0002DL-Qk; Wed, 06 Jul 2022 23:42:27 +0000 Received: by outflank-mailman (input) for mailman id 362648; Wed, 06 Jul 2022 23:42:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Ef4-0002DF-Cu for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 23:42:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48c59d5b-fd85-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 01:42:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E027661E9B; Wed, 6 Jul 2022 23:42:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 07631C3411C; Wed, 6 Jul 2022 23:42:21 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48c59d5b-fd85-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657150942; bh=wtneZk4H1Z7lB3VpbxUxdFAoXDMjcCtol2OAdax3Vwo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=iIk/GbIMmB+GFFSFClcAAxoMsvzsTRWTdmwjLPrG6Ow28loCpA4oNiD+ojg+Reqz7 lDu+OWkECPRVnv8yyWdV79etEVl3DFIC0Tu/s5TvpNS9odLf3PAnkcswVvY7dq6Pfm /l7JlgfNwe9QY4BneDTljY4Uau2CV0+5EtrA7bNWyVQCT/Uqxf/KxOU12tJTIloYDi NjrcuVvMDDgLLVHwWKQ0+pbCBWZoW4GXCens7F7QZwn+jOaxvyW611Ufpl4wG6hykl 4jKsNg+JZlzeW1D3+R6jv+/O2KNSJSGKDoXOB0eb42wfPViPc8lleuuNvidehhBrmI MbD8bTBPywRAw== Date: Wed, 6 Jul 2022 16:42:20 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, sstabellini@kernel.org, julien@xen.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com Subject: Re: [PATCH v2] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation In-Reply-To: <20220706121156.666500-1-burzalodowa@gmail.com> Message-ID: References: <20220706121156.666500-1-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 6 Jul 2022, Xenia Ragiadakou wrote: > Add the function prototype of show_stack() in header file > so that it is visible before its definition in traps.c. > > Although show_stack() is referenced only in traps.c, it is declared with > external linkage because, during development, it is often called also by > other files for debugging purposes. Declaring it static would increase > development effort. Add appropriate comment > > Signed-off-by: Xenia Ragiadakou Acked-by: Stefano Stabellini > --- > Changes in v2: > - add a new line after show_stack() to make obvious to which set of functions > the comment is referring to. > > xen/arch/arm/include/asm/processor.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/xen/arch/arm/include/asm/processor.h b/xen/arch/arm/include/asm/processor.h > index 4188ec6bfb..55f56b33bc 100644 > --- a/xen/arch/arm/include/asm/processor.h > +++ b/xen/arch/arm/include/asm/processor.h > @@ -558,7 +558,10 @@ extern register_t __cpu_logical_map[]; > void panic_PAR(uint64_t par); > > void show_execution_state(const struct cpu_user_regs *regs); > +/* Debugging functions are declared with external linkage to aid development. */ > void show_registers(const struct cpu_user_regs *regs); > +void show_stack(const struct cpu_user_regs *regs); > + > //#define dump_execution_state() run_in_exception_handler(show_execution_state) > #define dump_execution_state() WARN() > > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 23:46:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 23:46:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362653.592783 (Exim 4.92) (envelope-from ) id 1o9EjD-0002tU-HD; Wed, 06 Jul 2022 23:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362653.592783; Wed, 06 Jul 2022 23:46:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9EjD-0002tN-Ea; Wed, 06 Jul 2022 23:46:43 +0000 Received: by outflank-mailman (input) for mailman id 362653; Wed, 06 Jul 2022 23:46:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9EjC-0002tF-3d for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 23:46:42 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e143af2f-fd85-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 01:46:39 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CA334B81E4F; Wed, 6 Jul 2022 23:46:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 18ACDC3411C; Wed, 6 Jul 2022 23:46:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e143af2f-fd85-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657151197; bh=p52+6OYzpxBGgKhvFm+b8RBqSX/ki0bnnKZ7/BWyj9Y=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pgWZCvfCESEK81RquZPje2PIoSOF4kN50m5f21fa1hticnVpig3im/aempDCbvm94 JA2eouh6gQAR8zvwNlMcbbEDyvPIbD++3SocGC1lZW8fO/8vnaoNB3Diral5YpMfZv dqr4i3BeN+rgEjvTUFsEiPvmkRuAqEp+Zj0AKlsOfl5HkNH/ujz5iX5KV5f13i2g4M eIcQeerTxnowlzNS4GxkAYGmVU5rkP0QD67qkgSQTgd3KFe5aoTFWiuebftrwm6A+e aw5oQLrrXZ1mUkKpNeXbC7V1WxZaum+4uu1CZ8RSIvSJ3Y1G/0F6Zutjaxu+9jG36K GsjTph/gmSXpA== Date: Wed, 6 Jul 2022 16:46:35 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] xen/char: pv_console: Fix MISRA C 2012 Rule 2.1 violation In-Reply-To: <20220706175013.675258-1-burzalodowa@gmail.com> Message-ID: References: <20220706175013.675258-1-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 6 Jul 2022, Xenia Ragiadakou wrote: > Remove the definition of the function pv_console_evtchn(), > when CONFIG_XEN_GUEST is not set, because the function is not used. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > xen/include/xen/pv_console.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/xen/include/xen/pv_console.h b/xen/include/xen/pv_console.h > index 4745f46f2d..55b20323fb 100644 > --- a/xen/include/xen/pv_console.h > +++ b/xen/include/xen/pv_console.h > @@ -19,11 +19,6 @@ static inline void pv_console_set_rx_handler(serial_rx_fn fn) { } > static inline void pv_console_init_postirq(void) { } > static inline void pv_console_puts(const char *buf, size_t nr) { } > static inline size_t pv_console_rx(struct cpu_user_regs *regs) { return 0; } > -evtchn_port_t pv_console_evtchn(void) > -{ > - ASSERT_UNREACHABLE(); > - return 0; > -} > > #endif /* !CONFIG_XEN_GUEST */ > #endif /* __XEN_PV_CONSOLE_H__ */ > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Wed Jul 06 23:52:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 06 Jul 2022 23:52:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362660.592795 (Exim 4.92) (envelope-from ) id 1o9EpD-0004it-5p; Wed, 06 Jul 2022 23:52:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362660.592795; Wed, 06 Jul 2022 23:52:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9EpD-0004im-2n; Wed, 06 Jul 2022 23:52:55 +0000 Received: by outflank-mailman (input) for mailman id 362660; Wed, 06 Jul 2022 23:52:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9EpC-0004ig-AI for xen-devel@lists.xenproject.org; Wed, 06 Jul 2022 23:52:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bf30765a-fd86-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 01:52:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DC5C61F55; Wed, 6 Jul 2022 23:52:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DA65C3411C; Wed, 6 Jul 2022 23:52:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf30765a-fd86-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657151570; bh=mtvwmybBVzuD5FEfsA/4/5Xosx/4NjyqNhBjl6lmQ1w=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=HaFIfEUx1AgtQCCSrjHHb5p7OwOSOqmsvzeSTbG2p4iL9sv2sML2j1DE9sj9PmUQB mjomJEJmSXlOytCKspjfdmD0rSQsABoykEgrmzu4HtMl1hpzlzN55SGvWorfcKF59Q zaWapt5i3kchcFX0tZSKgRM4cqR121+cOOPvibcLc3o1zitEZLsuXmhho3BLPlnF6G Jg5KgkYw7a2lGYVBa16FxJiWWkNJgyCsiLAJBL4FyXzzOUo5Vs5CK7Wo7kCRB4R8y1 AtW5zN7ULhPbcl7byxOrQTCvIhfHjBFhW1YVhM3MYSmITuW4+9quzNbStqqPCjA+D2 aXzpGBaA18SIg== Date: Wed, 6 Jul 2022 16:52:48 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: Stefano Stabellini , Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree In-Reply-To: Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 4 Jul 2022, Penny Zheng wrote: > Hi Stefano and Julien > > > -----Original Message----- > > From: Stefano Stabellini > > Sent: Saturday, June 25, 2022 5:57 AM > > To: Julien Grall > > Cc: Penny Zheng ; xen-devel@lists.xenproject.org; > > Wei Chen ; Stefano Stabellini > > ; Bertrand Marquis ; > > Volodymyr Babchuk > > Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest > > device tree > > > > On Fri, 24 Jun 2022, Julien Grall wrote: > > > On 20/06/2022 06:11, Penny Zheng wrote: > > > > We expose the shared memory to the domU using the "xen,shared- > > memory-v1" > > > > reserved-memory binding. See > > > > Documentation/devicetree/bindings/reserved-memory/xen,shared- > > memory. > > > > txt in Linux for the corresponding device tree binding. > > > > > > > > To save the cost of re-parsing shared memory device tree > > > > configuration when creating shared memory nodes in guest device > > > > tree, this commit adds new field "shm_mem" to store shm-info per > > > > domain. > > > > > > > > For each shared memory region, a range is exposed under the > > > > /reserved-memory node as a child node. Each range sub-node is named > > > > xen-shmem@
and has the following properties: > > > > - compatible: > > > > compatible = "xen,shared-memory-v1" > > > > - reg: > > > > the base guest physical address and size of the shared > > > > memory region > > > > - xen,id: > > > > a string that identifies the shared memory region. > > > > > > > > Signed-off-by: Penny Zheng > > > > Reviewed-by: Stefano Stabellini > > > > --- > > > > v5 change: > > > > - no change > > > > --- > > > > v4 change: > > > > - no change > > > > --- > > > > v3 change: > > > > - move field "shm_mem" to kernel_info > > > > --- > > > > v2 change: > > > > - using xzalloc > > > > - shm_id should be uint8_t > > > > - make reg a local variable > > > > - add #address-cells and #size-cells properties > > > > - fix alignment > > > > --- > > > > xen/arch/arm/domain_build.c | 143 > > +++++++++++++++++++++++++++++- > > > > xen/arch/arm/include/asm/kernel.h | 1 + > > > > xen/arch/arm/include/asm/setup.h | 1 + > > > > 3 files changed, 143 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > > b/xen/arch/arm/domain_build.c index 1584e6c2ce..4d62440a0e 100644 > > > > --- a/xen/arch/arm/domain_build.c > > > > +++ b/xen/arch/arm/domain_build.c > > > > @@ -900,7 +900,22 @@ static int __init allocate_shared_memory(struct > > > > domain *d, > > > > return ret; > > > > } > > > > -static int __init process_shm(struct domain *d, > > > > +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, > > > > + paddr_t start, paddr_t size, > > > > + u32 shm_id) { > > > > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > > > > + return -ENOMEM; > > > > + > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id = shm_id; > > > > + kinfo->shm_mem.nr_banks++; > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static int __init process_shm(struct domain *d, struct kernel_info > > > > +*kinfo, > > > > const struct dt_device_node *node) > > > > { > > > > struct dt_device_node *shm_node; @@ -971,6 +986,14 @@ static > > > > int __init process_shm(struct domain *d, > > > > if ( ret ) > > > > return ret; > > > > } > > > > + > > > > + /* > > > > + * Record static shared memory region info for later setting > > > > + * up shm-node in guest device tree. > > > > + */ > > > > + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); > > > > + if ( ret ) > > > > + return ret; > > > > } > > > > return 0; > > > > @@ -1301,6 +1324,117 @@ static int __init make_memory_node(const > > > > struct domain *d, > > > > return res; > > > > } > > > > +#ifdef CONFIG_STATIC_SHM > > > > +static int __init make_shm_memory_node(const struct domain *d, > > > > + void *fdt, > > > > + int addrcells, int sizecells, > > > > + struct meminfo *mem) > > > > > > NIT: AFAICT mem is not changed, so it should be const. > > > > > > > +{ > > > > + unsigned long i = 0; > > > > > > NIT: This should be "unsigned int" to match the type of nr_banks. > > > > > > > + int res = 0; > > > > + > > > > + if ( mem->nr_banks == 0 ) > > > > + return -ENOENT; > > > > + > > > > + /* > > > > + * For each shared memory region, a range is exposed under > > > > + * the /reserved-memory node as a child node. Each range sub-node > > is > > > > + * named xen-shmem@
. > > > > + */ > > > > + dt_dprintk("Create xen-shmem node\n"); > > > > + > > > > + for ( ; i < mem->nr_banks; i++ ) > > > > + { > > > > + uint64_t start = mem->bank[i].start; > > > > + uint64_t size = mem->bank[i].size; > > > > + uint8_t shm_id = mem->bank[i].shm_id; > > > > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > > > > + char buf[27]; > > > > + const char compat[] = "xen,shared-memory-v1"; > > > > + __be32 reg[4]; > > > > + __be32 *cells; > > > > + unsigned int len = (addrcells + sizecells) * > > > > + sizeof(__be32); > > > > + > > > > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, > > > > mem->bank[i].start); > > > > + res = fdt_begin_node(fdt, buf); > > > > + if ( res ) > > > > + return res; > > > > + > > > > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > > > > + if ( res ) > > > > + return res; > > > > + > > > > + cells = reg; > > > > + dt_child_set_range(&cells, addrcells, sizecells, start, > > > > + size); > > > > + > > > > + res = fdt_property(fdt, "reg", reg, len); > > > > + if ( res ) > > > > + return res; > > > > + > > > > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"->%#"PRIx64"\n", > > > > + i, start, start + size); > > > > + > > > > + res = fdt_property_cell(fdt, "xen,id", shm_id); > > > > > > Looking at the Linux binding, "xen,id" is meant to be a string. But > > > here you are writing it as an integer. > > > > Good catch! > > > > > > > Given that the Linux binding is already merged, I think the Xen > > > binding should be changed. > > > > We would be compliant with both bindings (xen and linux) just by writing > > shm_id as string here, but if it is not too difficult we might as well harmonize > > the two bindings and also define xen,shm-id as a string. > > > > On the Xen side, I would suggest to put a clear size limit so that the string is > > easier to handle. > > I've already made the xen,shm-id parsed as a string too, seeing the below code: > " > prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); > if ( !prop_id ) > return -ENOENT; > shm_id = simple_strtoul(prop_id->data, NULL, 10); > if ( shm_id >= NR_MEM_BANKS ) > { > printk("fdt: invalid `xen,shm-id` %lu for static shared memory node.\n", > shm_id); > return -EINVAL; > } > " > The size limit is smaller than 256, just as stated in doc: > " > - xen,shm-id > > A string that represents the unique identifier of the shared memory > region. The maximum identifier shall be "xen,shm-id = 255". > " > Hope this fits what both of you suggested~~~ Yes. I think supporting arbitrary strings like "my-shared-mem-1" would be nice-to-have but I wouldn't make it a hard requirement. "255" as a string would match Linux's requirements for xen,id. From xen-devel-bounces@lists.xenproject.org Thu Jul 07 00:09:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 00:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362666.592806 (Exim 4.92) (envelope-from ) id 1o9F4s-0007fj-GE; Thu, 07 Jul 2022 00:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362666.592806; Thu, 07 Jul 2022 00:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9F4s-0007fc-CP; Thu, 07 Jul 2022 00:09:06 +0000 Received: by outflank-mailman (input) for mailman id 362666; Thu, 07 Jul 2022 00:09:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9F4q-0007fW-66 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 00:09:04 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 017314b9-fd89-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 02:09:02 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 4C5CBB81F5A; Thu, 7 Jul 2022 00:09:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B4A99C3411C; Thu, 7 Jul 2022 00:08:59 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 017314b9-fd89-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657152540; bh=hq32ZyKR/RWmwDjvNRS77lPyXTPv2bBPC3EmC0mfXbE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=KZGs541EG8FMENDvcYuNauFHA/929QJpg0kVdoXHpN7IMmH0nxGcgZKi+3yPJXJge P/jIxbKL4Xm25b5zzI9Z64NEwrMnf1M23A/f1RjUBMzCR+sJRWDpc4o7yamU9n6dxz xG006U/pg2i7TgDIoznht6++9r/MC7GmVAXhoZdvgslcPcC7dzMsUBjoqr6Ycl3dBM 3SNwv+NSfs1z3SO3ivLAjDgdaILsZbqhUjjgdEySwehuevl7yrpWeKxkH8/lfJXAy+ z15LFF2BD+I7Zzm8HkH3s5+PKEs/AvcwHee6nIQ7YKH1ppeZIAqlnmhJQIYg6IondA bJ5ekeALq013w== Date: Wed, 6 Jul 2022 17:08:57 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: Re: [ImageBuilder][PATCH v2 1/4] scripts: Add support for prepending path to file names In-Reply-To: <20220630140028.3227385-2-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220630140028.3227385-1-andrei.cherechesu@oss.nxp.com> <20220630140028.3227385-2-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 30 Jun 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > Added support for prepending path to file names in the final generated > u-boot script, for the use-case where we have the files in a separate > folder that can be accessed with a given $LOAD_CMD. > > For example, we can have "fatload mmc 0:2" as LOAD_CMD but the > files would need to be loaded from the /boot folder within the 2nd > partition, not from the root ("/"). By specifying the "-p " > parameter when running the script, paths like "/boot" can be > automatically prepended to the generated u-boot commands used > to load the files in board's memory. > > Also added the support to disk_image script, to enable generating > a FAT partition with the binaries deployed in a custom folder > within it, if the "-p" parameter is specified. > > Signed-off-by: Andrei Cherechesu Reviewed-by: Stefano Stabellini > --- > scripts/disk_image | 37 +++++++++++++++++++++++-------------- > scripts/uboot-script-gen | 12 ++++++++---- > 2 files changed, 31 insertions(+), 18 deletions(-) > > diff --git a/scripts/disk_image b/scripts/disk_image > index 12fb06b..97e798f 100755 > --- a/scripts/disk_image > +++ b/scripts/disk_image > @@ -539,7 +539,7 @@ function write_rootfs() > function print_help > { > echo "usage:" > - echo " $0 -c CONFIG_FILE -d UBOOT_DIRECTORY -t UBOOT_TYPE <-w WORK_DIRECTORY> <-s SLACK> <-a> -o IMG_FILE" > + echo " $0 -c CONFIG_FILE -d UBOOT_DIRECTORY -t UBOOT_TYPE <-w WORK_DIRECTORY> <-s SLACK> <-a> -o IMG_FILE <-p PREPEND_PATH>" > echo " $0 -h" > echo "where:" > echo " -c CONFIG_FILE - configuration file" > @@ -553,6 +553,7 @@ function print_help > echo " -s SLACK - free MB to add to each partition, default 128" > echo " -a specifies that the size of IMG_FILE has to be aligned to the nearest power of two" > echo " -o IMG_FILE - the output img file " > + echo " -p PREPEND_PATH - path to be appended before file names to customize deploy location within rootfs" > echo "Example:" > echo " $0 -c ../config -d ./build42 -w tmp -o disk.img" > } > @@ -564,7 +565,7 @@ then > exit 1 > fi > > -while getopts ":w:d:c:t:s:o:ah" opt > +while getopts ":w:d:c:t:s:o:ahp:" opt > do > case ${opt} in > t ) > @@ -606,6 +607,9 @@ do > a ) > ALIGN=1 > ;; > + p ) > + PREPEND_PATH="$OPTARG" > + ;; > h ) > print_help > exit 0 > @@ -828,56 +832,61 @@ mount /dev/mapper/diskimage1 $DESTDIR/part/disk1 > > # only copy over files that were counted for the partition size > cd "$UBOOT_OUT" > -cp --parents "$DOM0_KERNEL" "${DESTDIR_ABS}/part/disk1/" > -cp --parents "$DEVICE_TREE" "${DESTDIR_ABS}/part/disk1/" > -cp --parents "$UBOOT_SCRIPT" "${DESTDIR_ABS}/part/disk1/" > +if [ -n "$PREPEND_PATH" ] > +then > + mkdir -p "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > +fi > + > +cp --parents "$DOM0_KERNEL" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > +cp --parents "$DEVICE_TREE" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > +cp --parents "$UBOOT_SCRIPT" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > > if test "${DOM0_RAMDISK}" > then > - cp --parents "$DOM0_RAMDISK" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "$DOM0_RAMDISK" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > if test "$NUM_DT_OVERLAY" && test "$NUM_DT_OVERLAY" -gt 0 > then > i=0 > while test $i -lt "$NUM_DT_OVERLAY" > do > - cp --parents "${DT_OVERLAY[$i]}" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "${DT_OVERLAY[$i]}" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > i=$(( $i + 1 )) > done > fi > if test "${UBOOT_SOURCE}" > then > - cp --parents "$UBOOT_SOURCE" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "$UBOOT_SOURCE" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > if test "${XEN}" > then > - cp --parents "$XEN" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "$XEN" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > if test "$NUM_BOOT_AUX_FILE" && test "$NUM_BOOT_AUX_FILE" -gt 0 > then > i=0 > while test $i -lt "$NUM_BOOT_AUX_FILE" > do > - cp --parents "${BOOT_AUX_FILE[$i]}" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "${BOOT_AUX_FILE[$i]}" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > i=$(( $i + 1 )) > done > fi > if test "${BITSTREAM}" > then > - cp --parents "$BITSTREAM" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "$BITSTREAM" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > > i=0 > while test $i -lt $NUM_DOMUS > do > - cp --parents "${DOMU_KERNEL[$i]}" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "${DOMU_KERNEL[$i]}" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > if test "${DOMU_RAMDISK[$i]}" > then > - cp --parents "${DOMU_RAMDISK[$i]}" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "${DOMU_RAMDISK[$i]}" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > if test "${DOMU_PASSTHROUGH_DTB[$i]}" > then > - cp --parents "${DOMU_PASSTHROUGH_DTB[$i]}" "${DESTDIR_ABS}/part/disk1/" > + cp --parents "${DOMU_PASSTHROUGH_DTB[$i]}" "${DESTDIR_ABS}/part/disk1/${PREPEND_PATH}" > fi > i=$(( $i + 1 )) > done > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 085e29f..8f08cd6 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -316,7 +316,7 @@ function load_file() > then > echo "imxtract \$fit_addr $fit_scr_name $memaddr" >> $UBOOT_SOURCE > else > - echo "$LOAD_CMD $memaddr $relative_path" >> $UBOOT_SOURCE > + echo "$LOAD_CMD $memaddr ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE > fi > add_size $filename > } > @@ -891,7 +891,7 @@ function print_help > { > script=`basename "$0"` > echo "usage:" > - echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f]" > + echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH]" > echo " $script -h" > echo "where:" > echo " CONFIG_FILE - configuration file" > @@ -907,6 +907,7 @@ function print_help > echo " HINT - the file name of the crt and key file minus the suffix (ex, hint.crt and hint.key)" > echo " U-BOOT_DTB - u-boot control dtb so that the public key gets added to it" > echo " -f - enable generating a FIT image" > + echo " PREPEND_PATH - path to be appended before file names to match deploy location within rootfs" > echo " -h - prints out the help message and exits " > echo "Defaults:" > echo " CONFIG_FILE=$cfg_file, UBOOT_TYPE=\"LOAD_CMD\" env var, DIRECTORY=$uboot_dir" > @@ -914,7 +915,7 @@ function print_help > echo " $script -c ../config -d ./build42 -t \"scsi load 1:1\"" > } > > -while getopts ":c:t:d:ho:k:u:f" opt; do > +while getopts ":c:t:d:ho:k:u:fp:" opt; do > case ${opt} in > t ) > case $OPTARG in > @@ -953,6 +954,9 @@ while getopts ":c:t:d:ho:k:u:f" opt; do > f ) > fit_opt=y > ;; > + p ) > + prepend_path="$OPTARG" > + ;; > h ) > print_help > exit 0 > @@ -1179,5 +1183,5 @@ then > echo "$LOAD_CMD $fit_addr $FIT; source $fit_addr:boot_scr" > else > echo "Generated uboot script $UBOOT_SCRIPT, to be loaded at address $uboot_addr:" > - echo "$LOAD_CMD $uboot_addr $UBOOT_SCRIPT; source $uboot_addr" > + echo "$LOAD_CMD $uboot_addr ${prepend_path:+$prepend_path/}$UBOOT_SCRIPT; source $uboot_addr" > fi > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 00:17:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 00:17:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362672.592817 (Exim 4.92) (envelope-from ) id 1o9FD7-0000gx-AA; Thu, 07 Jul 2022 00:17:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362672.592817; Thu, 07 Jul 2022 00:17:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FD7-0000gq-6K; Thu, 07 Jul 2022 00:17:37 +0000 Received: by outflank-mailman (input) for mailman id 362672; Thu, 07 Jul 2022 00:17:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FD6-0000gk-8a for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 00:17:36 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3297939a-fd8a-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 02:17:34 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5529061F9D; Thu, 7 Jul 2022 00:17:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 73C81C3411C; Thu, 7 Jul 2022 00:17:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3297939a-fd8a-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657153052; bh=4aNjuGa9IHa9ISuWx3EdpyLorE0D2wrPjTcdXxdfNfA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=grMyzpm3FqXYRPpoknH9qUn5wxpQb+omW6/pPst636ubdPLMhDkcch1Y64Cpwntp5 NNzvUKg7HHEKMXYBGXxRO+R8K1dCRKLVw53K745uHuAh0VO7ct8WgjvL5a30rcB3Fb rvsLJWI8src+x6L2eJTfSiVoENBL26gz6WRp6nFJIUuNlvErMcxCUdgT+DN/yiVAcZ 4aumODLH11Sro8svhOpL03XxYM2aM59ipDhtYIKgSzvBVlQ2g8Mj79TjTSUe+z8ve5 22vMn5ZZj2KHhhQAKmVsoM4HrCrJfOzJoko83JRfFyr7Kieowyjuk/5Zc6Rk9PLkdX Ar49I8GYKe2EA== Date: Wed, 6 Jul 2022 17:17:30 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: Re: [ImageBuilder][PATCH v2 3/4] uboot-script-gen: Enable appending extra commands to boot script In-Reply-To: <20220630140028.3227385-4-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220630140028.3227385-1-andrei.cherechesu@oss.nxp.com> <20220630140028.3227385-4-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 30 Jun 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > Added the "-a" parameter which stands for APPEND_EXTRA_CMDS option, > which enables the user to specify the path to a text file that contains, > on each line, u-boot commands that will be added to the generated script as > "fixups", before the boot command. > > The file specified via the "-a" parameter will be copied as-is in the > generated script. > > Signed-off-by: Andrei Cherechesu > --- > scripts/uboot-script-gen | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index f8d2fb0..444c65a 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -416,6 +416,10 @@ function check_file_type() > elif [ "$type" = "Device Tree Blob" ] > then > type="Device Tree Blob\|data" > + > + elif [ "$type" = "text" ] > + then > + type="ASCII text" > fi > > file -L $filename | grep "$type" &> /dev/null > @@ -973,7 +977,7 @@ function print_help > { > script=`basename "$0"` > echo "usage:" > - echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH] [-s]" > + echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH] [-s] [-a APPEND_EXTRA_CMDS]" > echo " $script -h" > echo "where:" > echo " CONFIG_FILE - configuration file" > @@ -991,6 +995,7 @@ function print_help > echo " -f - enable generating a FIT image" > echo " PREPEND_PATH - path to be appended before file names to match deploy location within rootfs" > echo " -s - enable dynamic loading of binaries by storing their addresses and sizes u-boot env variables" > + echo " APPEND_EXTRA_CMDS - absolute path to file containing extra u-boot cmds (fixups) to be run before booting" > echo " -h - prints out the help message and exits " > echo "Defaults:" > echo " CONFIG_FILE=$cfg_file, UBOOT_TYPE=\"LOAD_CMD\" env var, DIRECTORY=$uboot_dir" Instead of adding it as a command line option, would it make sense to just source it from the ImageBuilder config file? Like: --- UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr" APPEND_EXTRA_CMDS="extra.txt" --- In other words I think we can skip parsing "-a" and just check if APPEND_EXTRA_CMDS is set > @@ -998,7 +1003,7 @@ function print_help > echo " $script -c ../config -d ./build42 -t \"scsi load 1:1\"" > } > > -while getopts ":c:t:d:ho:k:u:fp:s" opt; do > +while getopts ":c:t:d:ho:k:u:fp:sa:" opt; do > case ${opt} in > t ) > case $OPTARG in > @@ -1043,6 +1048,9 @@ while getopts ":c:t:d:ho:k:u:fp:s" opt; do > s ) > dynamic_loading_opt=y > ;; > + a ) > + extra_cmds_file=$OPTARG > + ;; > h ) > print_help > exit 0 > @@ -1235,6 +1243,13 @@ load_file $DEVICE_TREE "host_fdt" > bitstream_load_and_config # bitstream is loaded last but used first > device_tree_editing $device_tree_addr > > +# append extra u-boot commands (fixups) to script before boot command > +if test "$extra_cmds_file" > +then > + check_file_type "$extra_cmds_file" "text" > + cat $extra_cmds_file >> $UBOOT_SOURCE > +fi I think it should be below the setenv fdt_high command below. (Just before the echo "$BOOT_CMD... Other than that, it is fine, thank you! > # disable device tree reloation > echo "setenv fdt_high 0xffffffffffffffff" >> $UBOOT_SOURCE > > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 00:38:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 00:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362679.592828 (Exim 4.92) (envelope-from ) id 1o9FX1-0003uQ-2u; Thu, 07 Jul 2022 00:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362679.592828; Thu, 07 Jul 2022 00:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FX0-0003uJ-Vk; Thu, 07 Jul 2022 00:38:10 +0000 Received: by outflank-mailman (input) for mailman id 362679; Thu, 07 Jul 2022 00:38:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FWz-0003u9-Cp; Thu, 07 Jul 2022 00:38:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FWz-0006O5-8T; Thu, 07 Jul 2022 00:38:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9FWy-0001fx-Or; Thu, 07 Jul 2022 00:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9FWy-00062E-O6; Thu, 07 Jul 2022 00:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LXNZFrgL9PTN9m8SA+fdtUk5PVtfiA5N0sjF2ukVSjQ=; b=jUvzD7FYv9NCtrUajHkgM4tFds 9iAQIYSfx9/Fvlmu/vFRq8R2w5QvRF9jq3TWmbFDj7uEHg/vB6P9qhrMLNViWl9RpCw1P0Hkr8U0I exGDmd0EZt6GorjTi8nxUXt11Z7bhoR1SwRQ5cbBzv4ReiWmzRHOBBKpd8VApHVqV7x0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171536: trouble: broken/fail/pass X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-libvirt-pair:host-install/dst_host(7):broken:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Thu, 07 Jul 2022 00:38:08 +0000 flight 171536 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171536/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken test-amd64-amd64-libvirt-pair 7 host-install/dst_host(7) broken REGR. vs. 171516 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171516 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171516 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171516 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171516 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171516 2022-07-06 01:53:06 Z 0 days Testing same since 171536 2022-07-06 18:36:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Charles Arnold Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair broken test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken broken-step test-amd64-amd64-libvirt-pair host-install/dst_host(7) Not pushing. ------------------------------------------------------------ commit 46cbd76faf737e9fe2d57aaf335a0203f66ba21c Author: Xenia Ragiadakou Date: Wed Jul 6 13:07:43 2022 +0200 xen/time: fix MISRA C 2012 Rule 8.7 violation The variable __mon_lengths is referenced only in time.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Acked-by: Julien Grall commit eb40ae41b658e0421e4275c14dd18c7377b0752a Author: Roger Pau Monné Date: Wed Jul 6 13:06:57 2022 +0200 x86/Kconfig: add option for default x2APIC destination mode Allow setting the default x2APIC destination mode from Kconfig to Physical. Note the default destination mode is still Logical (Cluster) mode. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 8eeae8c2b4efefda8e946461e86cf2ae9c18e5a9 Author: Charles Arnold Date: Wed Jul 6 13:06:40 2022 +0200 libxc: fix compilation error with gcc13 xc_psr.c:161:5: error: conflicting types for 'xc_psr_cmt_get_data' due to enum/integer mismatch; Signed-off-by: Charles Arnold Reviewed-by: Jan Beulich Acked-by: Anthony PERARD commit 786049720041539409f47c6c1a1e718de490cf37 Author: Jan Beulich Date: Wed Jul 6 13:05:23 2022 +0200 Revert "EFI: preserve the System Resource Table for dom0" This reverts commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95, for breaking booting (on at least Arm64), apparently due to incomplete refactoring from an earlier version. commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 00:57:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 00:57:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362688.592839 (Exim 4.92) (envelope-from ) id 1o9Fp6-00078g-Mf; Thu, 07 Jul 2022 00:56:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362688.592839; Thu, 07 Jul 2022 00:56:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Fp6-00078Z-Jt; Thu, 07 Jul 2022 00:56:52 +0000 Received: by outflank-mailman (input) for mailman id 362688; Thu, 07 Jul 2022 00:56:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Fp5-00078T-AW for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 00:56:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ad7c8774-fd8f-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 02:56:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 366AB61FFA; Thu, 7 Jul 2022 00:56:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53D4BC3411C; Thu, 7 Jul 2022 00:56:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad7c8774-fd8f-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657155406; bh=sYzXcLj/Fo9Tar0VzolAUoZ9qPBWrQXPMFOq6nT4xI4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pxUDBYRAS5p6yacA2CoY4/JL6NOs3ZX8IYZUEfPPBHmImg1zjEPvJlPKVhnfEHYow ExCi4D/+n8ifIZOCdi2azLRycLpXHMsnuK8BsgkJ727VZSn1oAbDtKul8A2SjYcNJY fIgL7DaYJhsVhY361xgy9tupYZPGsk/mN6Gb4URACpCJKTx11AdU6HrpUY1+M0FNkI B6uqZm9Pk6rNP0f6qTBbJLv93cZZf96J7fdQGvZL94/fNxUAQyUqG73EwlyW9zkgTC llQvWwc4qq63Lp7Qy3YH7RzqQ5Q7IM+RGDnzeiPKbP9TSxRLUAkmZ6zwL/XtGRq8dO Pem6hFu4H15fQ== Date: Wed, 6 Jul 2022 17:56:44 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: Re: [ImageBuilder][PATCH v2 4/4] uboot-script-gen: Enable not adding boot command to script In-Reply-To: <20220630140028.3227385-5-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220630140028.3227385-1-andrei.cherechesu@oss.nxp.com> <20220630140028.3227385-5-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 30 Jun 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > If the "BOOT_CMD" variable is set to "none" inside the config > file, the boot command (i.e. "booti") will not by added to the > generated script, to allow the user to customize the u-boot env > or the device-tree after executing the script commands and before > actually booting. > > Added commands to store the addresses where the Xen image and > device-tree file are loaded, in 'host_kernel_addr' and 'host_fdt_addr' > variables, if the boot command is skipped and the "-s" parameter is > not used. > > The `booti` command can then be executed as part of the 'bootcmd' variable > in u-boot, which should contain: > 1. fetching the generated u-boot script > 2. executing the script > 3. running `booti ${host_kernel_addr} - ${host_fdt_addr}` command > > Signed-off-by: Andrei Cherechesu Reviewed-by: Stefano Stabellini I think this patch is fine in principle but I need to review in a bit more details patch #2 before I am able to commit it > --- > README.md | 5 ++++- > scripts/uboot-script-gen | 16 +++++++++++++--- > 2 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/README.md b/README.md > index cb15ca5..b1a9b9d 100644 > --- a/README.md > +++ b/README.md > @@ -80,7 +80,10 @@ Where: > > - BOOT_CMD specifies the u-boot command used to boot the binaries. > By default, it is 'booti'. The acceptable values are 'booti', 'bootm' > - and 'bootefi'. > + and 'bootefi' and 'none'. If the value is 'none', the BOOT_CMD is not > + added to the boot script, and the addresses for the Xen binary and the > + DTB are stored in 'host_kernel_addr' and 'host_fdt_addr' u-boot > + env variables respectively, to be used manually when booting. > > - DEVICE_TREE specifies the DTB file to load. > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 444c65a..994369c 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -966,7 +966,7 @@ function check_depends() > > function check_boot_cmd() > { > - if ! [[ " bootm booti bootefi " =~ " ${BOOT_CMD}" ]] > + if ! [[ " bootm booti bootefi none " =~ " ${BOOT_CMD}" ]] > then > echo "\"BOOT_CMD=$BOOT_CMD\" is not valid" > exit 1 > @@ -1255,9 +1255,19 @@ echo "setenv fdt_high 0xffffffffffffffff" >> $UBOOT_SOURCE > > if test "$dynamic_loading_opt" > then > - echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE > + if [ "$BOOT_CMD" != "none" ] > + then > + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE > + fi > else > - echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE > + if [ "$BOOT_CMD" != "none" ] > + then > + echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE > + else > + # skip boot command but store load addresses to be used later > + echo "setenv host_kernel_addr $kernel_addr" >> $UBOOT_SOURCE > + echo "setenv host_fdt_addr $device_tree_addr" >> $UBOOT_SOURCE > + fi > fi > > if test "$FIT" > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 01:45:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 01:45:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362694.592850 (Exim 4.92) (envelope-from ) id 1o9GZZ-0007kL-8B; Thu, 07 Jul 2022 01:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362694.592850; Thu, 07 Jul 2022 01:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZZ-0007kE-4K; Thu, 07 Jul 2022 01:44:53 +0000 Received: by outflank-mailman (input) for mailman id 362694; Thu, 07 Jul 2022 01:44:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZW-0007k8-Ry for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 01:44:51 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70072.outbound.protection.outlook.com [40.107.7.72]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6291c18e-fd96-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 03:44:48 +0200 (CEST) Received: from AM6P191CA0030.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::43) by AS8PR08MB6168.eurprd08.prod.outlook.com (2603:10a6:20b:294::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 01:44:44 +0000 Received: from AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8b:cafe::89) by AM6P191CA0030.outlook.office365.com (2603:10a6:209:8b::43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 01:44:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT038.mail.protection.outlook.com (10.152.17.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 01:44:43 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Thu, 07 Jul 2022 01:44:43 +0000 Received: from cd15004ef429.4 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 829FEF61-F61B-411C-B191-2786B1793686.1; Thu, 07 Jul 2022 01:44:33 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd15004ef429.4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 01:44:33 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM0PR08MB3059.eurprd08.prod.outlook.com (2603:10a6:208:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 01:44:31 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 01:44:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6291c18e-fd96-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=FCE5E7E5GQQ20K+G6fptxCog1Dsq9FzC9+ZMkGeJGF5welKSD0a1TDNCZO4mlFX2geojW3bj/jvpOY2+5Xa13hLLpbvjdB2IucfMuGLhQrgaQXLOiaE8W0OoWnRo8MEdn6GBpXQLdHsZ+v3ZQ1SEDUtFAGYtQqBfGJ3U+LBBwxS35xziVLzuAIkTBb2zysH+cv5NymgKzAM3DIwgZsohspd3L0pNfcSvk5Qrap+kaZdy0NwzYcF0wclxBr2bnHvNwlrV2wQW9RdqFr5w1oENNFlZlC/GM4t35gUaEZcK1k7I9U6mmgDCklXSQAOnbzgXqW739dLk9NbyiwzLzpMc8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BzKMgzJn6lcDh8AQWns1RMHYti4lDAifTNrK95jdCmc=; b=AHgmC2OzcMcidgT4wQfHxijiz7rnM8GS+kWMFIUfZIf+rrFHfVDNAwT9vOBg3/Sbd4H6RXeRGOB6G+HFU0Czdnochvr2jVA7QyJwiSz6gxiQuuqmBVGnJwCLG0SXLYdxhxqFX4uwsoNYZzqPr2xcJmmNfcyfdDSlYEzjVB7k8jMAxHVRWiwRiS3Q6U6eNlzvEcNVRiCJTRNYjpE49wzHcUSFv6qwACbc38bv1rJnSLLp0zT2tEOWPZ32ON1ypaaTsoFqLpr08kCY1+CKGq/BfgMmjE+6Mq/S5RfYLKqysw01XUiKr0ZKI9sVmUv6rMdD/SVq8njpjmcSfJMe+tRzTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BzKMgzJn6lcDh8AQWns1RMHYti4lDAifTNrK95jdCmc=; b=XNwy6Jhlo4fXvn4BKZnXoolIgCpKw1q7yAhlfupJG2Y7ii9vbg6rx9nxz2bdtITuKR2i7/dns2u40sBVx5qLgf5Q+/0qocWx17/lVzSIAWKVZoXN+k+jarNqi4x/IOU1cRzdncJQX4JgMGl+OyhrJAG3R+nrdyNAnCTrJskRiYg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iezwvvoHHyQPk9LxU4ElVQ2okNYkP3KyJH4FdXPRFxqXriR1LWI1bqeKZMbQv5L8LxmwA3cKae3/4sLMSPlp5cKEMGeQEAQeruTfclPwyHIIh4qCOTGTczhfOjYcAn1mALtj4X0Y6VIZL+1+bCEvss1jbZj+57raklB4LkCYNw+/OssMCfmS22rWrSo6UiO6eFVQXun7KBgKtgcfOxKc1O9JcZLhhqatASY6lnJGWWG81THWieLXXs33VRUO040x7jLX8PFUl+sguLnaVwJWA2Pk2C1L1Mw36K35dshCVZMn7POkjTluCHZFNYx5bPMro2EPN6MchCm1zaIVow4mmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BzKMgzJn6lcDh8AQWns1RMHYti4lDAifTNrK95jdCmc=; b=eFPvzyoUbCqasYk3QRvwvQO/YdRW8d7jYy4ECm1n0CEW8eLqgcN5ohOkWf2uqVOdJhR8PO5XGFHx8pyN4NkU97zp84U0hjsmA4Hud6DfVTy/HOSVQE6w09B2xCUqjv+4dcEGmwlibWJUtCtVfoFSJNKBVCbMekpRUz64nlXPjUIEEVz7O4UO0mLgLRl4SexqeFkQ17+md/Eb11o4B77cBPv2nEDZjiXNtaczzzGOQ7qG3Ln56F+HfPhqflvnc2uPQNsTgCJfFaDHp3a8VlyOI/MfMEG2jYXA1Kh77cFExYSYbC7LtDPQzbM/ybX4ljOvUuzZ8LQb+9SUSDC5mz7IEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BzKMgzJn6lcDh8AQWns1RMHYti4lDAifTNrK95jdCmc=; b=XNwy6Jhlo4fXvn4BKZnXoolIgCpKw1q7yAhlfupJG2Y7ii9vbg6rx9nxz2bdtITuKR2i7/dns2u40sBVx5qLgf5Q+/0qocWx17/lVzSIAWKVZoXN+k+jarNqi4x/IOU1cRzdncJQX4JgMGl+OyhrJAG3R+nrdyNAnCTrJskRiYg= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" , Volodymyr Babchuk CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: RE: [PATCH v1 06/18] fdt: make fdt handling reusable across arch Thread-Topic: [PATCH v1 06/18] fdt: make fdt handling reusable across arch Thread-Index: AQHYkXyfE6AfBDgn4kCb1ygs7X9Eba1yIjhw Date: Thu, 7 Jul 2022 01:44:31 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-7-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-7-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4C0966A4F0BF3446BF381DD1BD503BD7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 90333ed7-0f38-42ac-bfad-08da5fba4445 x-ms-traffictypediagnostic: AM0PR08MB3059:EE_|AM5EUR03FT038:EE_|AS8PR08MB6168:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: U8JS7PZmVbnI5kqvvNzS/710qqbPP84H7BNGSVUm5S+e4cMG2RH3rtVbYIWkxzryHoYm76onFygVmGNbb8nK213CrttMWMGEQip4RJKybP8pii4JGL/ffq1koKatom82W1oRtTrgSca2wsyLLDP0Glg/apOEqfd93JHCAcHcD8s8Kjwh4tYsNh8OGmIEBnN1MG7zanh2Rpth2L16Ov/H+iKN/Ug/WQ1w0aBeRXO0g4B/IZeVR5xYwJJlsD6Ep7iV3Gw2xzaZPjFdcMQH2vTWDt9ctbX5IoS5tzFyHvEXGjMKKcgN+ZGbioDVP2wpvsAaonaLfsucXs2RB+I/FP08ujzY8MT8oVJBMsEQDknMBaJiLZJpgfhD16HdKRvBj2mew17dtmzB7WLMSXUTrCcAsPeqKZ0Ip92KCpr4KftlT/5Qaf1kEQOcg9FsM9lqPSDKYysSRQEYm7kVo58XenfAxqyzy56rxHDxMfoSsL/L1ALjdU4PZ2MvY5XkIe2StW0al+GemM8IOJr5EkPHm+xBaNSh6RAwQa9ZiaeEnsU6iWjbWd65zvj3pJvAiHr2gy9uI4sfTBbdEsLTiyMnnZAZCL7j7kGf5R1V2TvaX7i1Nkw/1VYPhrlMikEtnYWmkr1mdX7DM4WieB1tZ0R9CPZTAw/Mgay0MStRM8JuQ7wTQnUwBUBVEaMXnjQcOBqIZDfk1Gj4WuHzgYmMJlEhBGa8zmEW6H9TG2gaz61gi4+cZWTZVfoFnjfJKU+Q5OhV8fMMLpwVjNSVU0DIiiJRmsdR3PD06mz/vNKaj4O8urofAsVk320rpuWRnzOzEN4sxnxg X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(7696005)(6506007)(9686003)(26005)(38070700005)(71200400001)(186003)(83380400001)(55016003)(33656002)(2906002)(122000001)(38100700002)(66556008)(478600001)(5660300002)(316002)(86362001)(41300700001)(52536014)(8936002)(7416002)(4744005)(66446008)(54906003)(4326008)(66476007)(110136005)(64756008)(66946007)(76116006)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3059 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3a9caa8e-0b6b-4143-61ab-08da5fba3cb0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ikJ4Ksw0PVDE8HWTxrFpo4vUAN5fqMy8GgxQ/9rI2h8YIu0blxSY/Eukjkb0/asKHGStG6NKpXd45yDitUFJoT2aJwalPrM/iOllnVKvqmi/sw5njHd7cSqwZAxWMaUU8+qBy3zyb1WGCBNLJDBwAz4V1zzGIhMoMbiDGPAQbKvsAfi7Zl/qKFdl/L94i5lnvZtyIBysIn8/0u1y+dXsN6vJIJVcTriE0nefYoqD7g3+tVjmAGuic2QADch0RfDfzrS9py8wS0q0WEPKoKr1exGK0w/67H4q66zoOimaZ9b1shyLDbey+i15/gQNck7pFoWsFHOUVBpSQR8+U2VjoQIEaOkwU22GD/Qg73w/Dck9zgS8krylGRgnyFzTOMkRwMRPJaF1J2vyuMiNXx/Og+GlEWXysMtz9PSjRNb0W9gST/UM7pHPLSXhbguH8/7E7uCPA6W1X5m65aZFyGJzUFuPa2LxiVr4cx+cT9Dbx1bugLPdhB/jD5dlQ0Fa1PRDpccTg7ria2HMo0YL3n5gx2pxZh/XJxFWvcSd8LAc2QQrdPxlvGHEE+nItPdxiQvOeKM1/VkQMj7llfTTBU7KizWyZ+M+qqDhnl/r4KEsLYaOo7cHCFkyyLNicAV/NpBw452tb/wZ3T1ExnugVNoSAJRCohenT7lazSL6Q5hNsYGXjrPOLhsZ6u5LajAjfIYbylTW4xJY0IkIQ+iLoDKvPHupRlJ97QC86gt7rdbkA8ItE87ddq3B5VTV246P/Lqo/MAly+ywo6VoNe4WentBOz00UyNhrorB5kYfgnGB63ynZegHbwGbalzv0pq/lMH3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(40470700004)(46966006)(36840700001)(336012)(82740400003)(81166007)(82310400005)(356005)(86362001)(54906003)(5660300002)(8936002)(4744005)(55016003)(316002)(47076005)(70586007)(40460700003)(36860700001)(8676002)(70206006)(83380400001)(26005)(9686003)(52536014)(40480700001)(4326008)(186003)(478600001)(110136005)(6506007)(33656002)(7696005)(2906002)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 01:44:43.9699 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90333ed7-0f38-42ac-bfad-08da5fba4445 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT038.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6168 Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 06/18] fdt: make fdt handling reusable across arch >=20 > This refactors reusable code from Arm's bootfdt.c and device-tree.h that = is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capab= ility > such as hyperlaunch. >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark Reviewed-by: Henry Wang Kind regards, Henry > --- > xen/arch/arm/bootfdt.c | 115 +---------------------------- > xen/common/Kconfig | 4 ++ > xen/common/Makefile | 3 +- > xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +------------ > xen/include/xen/fdt.h | 79 ++++++++++++++++++++ From xen-devel-bounces@lists.xenproject.org Thu Jul 07 01:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 01:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362695.592860 (Exim 4.92) (envelope-from ) id 1o9GZr-000864-Fv; Thu, 07 Jul 2022 01:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362695.592860; Thu, 07 Jul 2022 01:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZr-00085x-D1; Thu, 07 Jul 2022 01:45:11 +0000 Received: by outflank-mailman (input) for mailman id 362695; Thu, 07 Jul 2022 01:45:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZq-0007k8-2y for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 01:45:10 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10089.outbound.protection.outlook.com [40.107.1.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ee07926-fd96-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 03:45:09 +0200 (CEST) Received: from DB9PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:10:1d9::29) by AS1PR08MB7473.eurprd08.prod.outlook.com (2603:10a6:20b:4df::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 01:44:40 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::d7) by DB9PR02CA0024.outlook.office365.com (2603:10a6:10:1d9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 7 Jul 2022 01:44:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 01:44:39 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Thu, 07 Jul 2022 01:44:38 +0000 Received: from cd15004ef429.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A8709358-53A5-4520-A6EA-D515FD6688FF.1; Thu, 07 Jul 2022 01:44:32 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd15004ef429.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 01:44:32 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM0PR08MB3059.eurprd08.prod.outlook.com (2603:10a6:208:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 01:44:28 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 01:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ee07926-fd96-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ENhmKJ6yzCiy3H0zXjVWZ7G5raLcKMAHPPe51OsPugOUWHD/9bFrz5YYtCLKR0vIcxHMGEAfqa/EqdNytMNe6e/amNYpnt/QzTS4Jn79uatlDaE0Mgsd/ftzjUL8OeJMqPbjhiblHpfcsxKskc50q4dxxUbM0YWVm5q1boaPufz0QXshzHG+NONuFmPXs1sI3paW+euIYpcQ2JVi0fIWQqASwEcoyEauD/Ba3PjMaGLuP6w/Oe5LGvO/mASpRY2Nr8vB/Qy04vAsXagdSWX7ecqJSkmdSVWru6O77isROT5OS+RgUZgC4ULgPQoWGp+iBudOO/pW7OS0wV+SmWg1zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NYpcNpnVUoenC3Di66fS55RIcJXm/TNgvfGMfiqZVCI=; b=nSbjleLtaFzqIcWFGg24VslLirzSuJgLWX0BtpVsaj2MilRFge0Ao6EhkPah/bJoRVhCbC1RS/YKVdzWokbO7dmLycRsedJmV+BlhSaPE84lv/bNJAiqGFalOTnahNsXCa7SVTeJL21ggkz09Jm0Tl+rTXespDGcnl0vKi+IFv/r2wrKb6WxZfI0IL2Ki7BOiNb6FlX+Dnl44CxDk///yMKI1cf7VWI+ytLzyeQEFJ0u6ChRVnQEc/f9pLXk/QIxOzpttP1951vR5g5ansXQ0Bd9tix9pR9Mbz7fVfkyBhRGxJZ1WDAMVoVnoU+iG/BXberLRYdDgpkD7WHYGJ3NwA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NYpcNpnVUoenC3Di66fS55RIcJXm/TNgvfGMfiqZVCI=; b=MaeXfjzcttqU4SU1fbBx73OPzuFufZlF+ptshwQyV4SIAHxCsMUh2orbW3HLro0wNrzQmSzGdfRoavtZV0DnZ8+8MAffMTYV5R0L1148PdFrlfswtQ43IDBQ9UBwV7ohhKB8h9+c/QWfmMJCHIQuJs/we28mA2j1rcqkkho2Fqs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n2rGfiJlohTu6jD8HnyCBOenOZhx3IgDVnA//agBS/IQJ50LBmQRzBrSemqmi7Nxlgog5svDp9BOEY1qsFNlB2F8ae+WO+TDy9UGg9uiF7rjgwsUGMQNugDqmaI1Jjwbat+n4na5JKLWmkIbnAbV2nWQBwko5VzrHGUAyLtGB5+lEsDvm2KySuCW3b43/W74VW2WwAfApe25WukvxpvbTy/KDomyVY+IGj+MZQ6ZJi2fkVydz/ktBo8vZy1DR1NUh6SWMKYK46C0Gj6gKkIUUiT0VJonGWw7jygw33qr4J19/MPwcMNbORfUVQBAXf+ka5FNMEJ2mhNCBN1fS+XPPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NYpcNpnVUoenC3Di66fS55RIcJXm/TNgvfGMfiqZVCI=; b=aw4hw3pPX7Glud4wAmSP6p6m2ukTKHr6uV0dInYfxR/qhlz+4E+hirji6wyhgRUbVMjjdITUPvCad0YZaXrP9UpvXb6e1hvg8CL5QbzGrdQ2eUMRcTu10cyowzqMSlUc60QkRj41HdhDKFjrMMk66vwnsPDxyGYsxS0BYCHcAOHImsuDkPpNuyPWYmJCJV5M1i74uN67FgNIxjYTseu6Q6pxAlLRtB71lbiPRBAr0PEbK6Wwe/AVfSGmQifH9F6djvuYS2Yp6eUBECVZxBu0NJKZF7U623jW0q1Wft4x5qdhvaojUR5pW67u4BXortxE+u+TPlVZKBBQZi6U8YBS1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NYpcNpnVUoenC3Di66fS55RIcJXm/TNgvfGMfiqZVCI=; b=MaeXfjzcttqU4SU1fbBx73OPzuFufZlF+ptshwQyV4SIAHxCsMUh2orbW3HLro0wNrzQmSzGdfRoavtZV0DnZ8+8MAffMTYV5R0L1148PdFrlfswtQ43IDBQ9UBwV7ohhKB8h9+c/QWfmMJCHIQuJs/we28mA2j1rcqkkho2Fqs= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Andrew Cooper , Wei Liu , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Volodymyr Babchuk Subject: RE: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Thread-Topic: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Thread-Index: AQHYkXwoifwexgw7vU2lK0bNIn1Zbq1yHf8Q Date: Thu, 7 Jul 2022 01:44:28 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-2-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 704E277118C1A347AD3E8E4D2B8866B9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e280cf62-970d-4d62-26fb-08da5fba418f x-ms-traffictypediagnostic: AM0PR08MB3059:EE_|DBAEUR03FT026:EE_|AS1PR08MB7473:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 59EBJtEkSUXEPgTFQjFV2+e+Bmnx24S277IUB4URhT25S+PMbElzDpFuZRc29igvPKVy9U4qrhGzXdNs7BrZJv27+5hvDVxhrHN0Z5uWiC3RqNRCt3edlhhh3XKuEh0IhwBjxnbt71oUGV7lG9e9E2YVvzcF7gul+litcAalLG5n8DuOGEBhRVhkxkBSem/DDRfEjp2Bv5HvZLZwdCDwsJw4BXk24664D3ONydPrAhuL36LQHlpsEbhcz+6ILlVs1NrrdqeyI4gRYr1n5k9WvjIXTLQo/2h0lOBlcnCu+xZyry2TDkhsZRROJaH9okKDZsks1nekN9+1H69hTcl65hULLXVI2L0uVEQqtaS/k607ZlPY+x5jfxW6yCPf4o3tybk4uLqmVWp99V2TZVJbSbElYmDr+KcDivz42rKCpU61eOOADsezYyijCDW1MCAP3Y0MqD42gSH7KYf0eZxHRRs50hivmopjsbsF/QYqBU5/KxXsDOVu2TSzX8KBO5Ff/N1SpdfQjvP+PKupLJn1WhXGF4ULnEIVFH1JWygFJmPeN+oSqw8Je7K7xqLeBYO9Wk/3DI5fSrs66Mxvvm36OpwATRn/pByhLpbaTUnEWf7G0g5fudb/vBcDrAUHaPULaNCNyw5YZG/nGh/8i9WIg8C3tQK6lYpBEMccxz7qB9HwKVUe2HO78ZA2zfC+KciYUENEx8d6FrIgRT5fXzkzUWMvmZxM1qhBxYoV3N9gYueXXvzURpBF6bfxGGcqhmvt1TK7jHIhaEPEXdYYIRbM169EQ0VXMnpRcyqO66tSnmE1dGenjVq0gC94xTQSvegj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(7696005)(6506007)(9686003)(26005)(38070700005)(71200400001)(186003)(83380400001)(55016003)(33656002)(2906002)(122000001)(38100700002)(66556008)(478600001)(5660300002)(316002)(86362001)(41300700001)(52536014)(8936002)(7416002)(66446008)(54906003)(4326008)(66476007)(110136005)(64756008)(66946007)(76116006)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3059 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6505f504-28cf-42a6-a4ae-08da5fba3b0c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yjpWTin61pVct2mup+xJ5Lh9AuyAtojCNrKYCrwPHFn878dACykvOUUIIg8WVqi0Up2Y/MkA2mYYZiLAz9vFxwd6GDNJ0coyC0pL7oTfkjD1/WG1GzSwcj/1LMiaAW9WUVYET9cZAyKSnVBB+OHsYDJk5mlknPzChaY5oDExeSJfKynWqG//WuXUYYTOxD0UbSfeWwhnNY9H/nbp3zPE3cjQ51GIrv0Svvo9xCt5zvWyf9eYiOZYKrt7l4MWzfZTxtqanjD9HTqgOk+zgPqLVyNDwp+E65mudZz6K8Ze+foLCPM1i6DT/ebr8OueU3CsdeC+UTInIaTx9FmHtBI0ECcAMWFn+2/Uux+m2DAg36/ili05HT1Q+E4U/B5TYCFEGlc0lffQX1YgjAF4U0mj+KSEpk/ChvhEZuRHsKUFusrv/pO0yEhX5SldeoRlQpGcNSSi4OybfTqkF/Swum2SPHF1NWq1tGvUWb3aLVCH1Lpnt2WepSHktadNWLW8UWRORkzN8328LxWNFVEuGTCPgsxT9UV0nCKTdrgtgD1gw+1djyWwwOI+o6h9jBqcDQt4CAgxuF2AdHmjSm9zZsYZxCGH4XT69jf7gjK9ss1nBKwLR1D6ACXKTe8oxX8AFVC7P32kFXY8bGutZlm3BPyVNqLjaMM0ser/MO78biRPAojO2sUTWaQ7ijtN7C/ehsgSFWlm4i5HjoIEd1kM+Xnt8ul7SjQTfYbq8Ru0wuI3nL1v7twj6dFUVISvhndv/RoBNWxE5pdRxdmr1i1MVg8dOKoZ0LHLVKP85sWd4dh5612FUINiIRE3CGBc+3kadQUw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(136003)(46966006)(36840700001)(40470700004)(5660300002)(70586007)(70206006)(8936002)(52536014)(4326008)(8676002)(40480700001)(82310400005)(40460700003)(2906002)(55016003)(36860700001)(33656002)(81166007)(82740400003)(356005)(478600001)(83380400001)(41300700001)(316002)(54906003)(110136005)(186003)(336012)(47076005)(26005)(9686003)(7696005)(6506007)(107886003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 01:44:39.4646 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e280cf62-970d-4d62-26fb-08da5fba418f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR08MB7473 Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 01/18] kconfig: allow configuration of maximum modules >=20 > For x86 the number of allowable multiboot modules varies between the > different > entry points, non-efi boot, pvh boot, and efi boot. In the case of both A= rm > and > x86 this value is fixed to values based on generalized assumptions. With > hyperlaunch for x86 and dom0less on Arm, use of static sizes results in l= arge > allocations compiled into the hypervisor that will go unused by many use > cases. >=20 > This commit introduces a Kconfig variable that is set with sane defaults = based > on configuration selection. This variable is in turned used as the array = size > for the cases where a static allocated array of boot modules is declared. >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark Reviewed-by: Henry Wang > --- > xen/arch/Kconfig | 12 ++++++++++++ > xen/arch/arm/include/asm/setup.h | 5 +++-- > xen/arch/x86/efi/efi-boot.h | 2 +- > xen/arch/x86/guest/xen/pvh-boot.c | 2 +- > xen/arch/x86/setup.c | 4 ++-- > 5 files changed, 19 insertions(+), 6 deletions(-) >=20 > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index f16eb0df43..24139057be 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,15 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or > similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_BOOTMODS > + int "Maximum number of boot modules that a loader can pass" > + range 1 32768 > + default "8" if X86 > + default "32" if ARM > + help > + Controls the build-time size of various arrays allocated for > + parsing the boot modules passed by a loader when starting Xen. > + > + This is of particular interest when using Xen's hypervisor domain > + capabilities such as dom0less. > diff --git a/xen/arch/arm/include/asm/setup.h > b/xen/arch/arm/include/asm/setup.h > index 2bb01ecfa8..312a3e4209 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -10,7 +10,8 @@ >=20 > #define NR_MEM_BANKS 256 >=20 > -#define MAX_MODULES 32 /* Current maximum useful modules */ > +/* Current maximum useful modules */ > +#define MAX_MODULES CONFIG_NR_BOOTMODS >=20 > typedef enum { > BOOTMOD_XEN, > @@ -38,7 +39,7 @@ struct meminfo { > * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. > * The purpose of the domU flag is to avoid getting confused in > * kernel_probe, where we try to guess which is the dom0 kernel and > - * initrd to be compatible with all versions of the multiboot spec. > + * initrd to be compatible with all versions of the multiboot spec. Thanks for taking the chance to remove the space in the end of the sentence= . Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Thu Jul 07 01:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 01:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362696.592867 (Exim 4.92) (envelope-from ) id 1o9GZr-0008Ac-Um; Thu, 07 Jul 2022 01:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362696.592867; Thu, 07 Jul 2022 01:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZr-00088l-Mk; Thu, 07 Jul 2022 01:45:11 +0000 Received: by outflank-mailman (input) for mailman id 362696; Thu, 07 Jul 2022 01:45:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9GZq-00085j-VM for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 01:45:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2068.outbound.protection.outlook.com [40.107.22.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ea49b62-fd96-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 03:45:09 +0200 (CEST) Received: from DB6PR07CA0021.eurprd07.prod.outlook.com (2603:10a6:6:2d::31) by AM0PR08MB5491.eurprd08.prod.outlook.com (2603:10a6:208:189::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.20; Thu, 7 Jul 2022 01:45:06 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2d:cafe::df) by DB6PR07CA0021.outlook.office365.com (2603:10a6:6:2d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 7 Jul 2022 01:45:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 01:45:05 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Thu, 07 Jul 2022 01:45:05 +0000 Received: from ed51147882b1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BD3F4EC1-F2CA-471F-AFD8-8427370D9656.1; Thu, 07 Jul 2022 01:45:00 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ed51147882b1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 01:45:00 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM0PR08MB3059.eurprd08.prod.outlook.com (2603:10a6:208:5c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 01:44:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 01:44:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ea49b62-fd96-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eOauibWfV4Os3tBCZXboWiUw4fvD41T7A4uK3OFHbE2laYMD1HY6U7jL2GzqaY2eZxlBTF8SXXvbpJ2IThzhJtRsXJZY8perXyJnGKTnMoPOwWx5Sxuti/yQ319Cbe/eTTqJfStUqDx2aBRgxiUtn3HLGR7x0SzZy3JgTyjdIE0Oe8mZE2CYD2L0qrTlzbUv2EOsspY50adqztZGDNx/tjgU56WWg29+q6HWWgyn5p2hhc7wcGUKd0T/NjWPDApSQT6b+KvlERoaT9VapZZZb7conEturku5QkbP7ChxicXt1LTTOgWNSpNl7tpS8MY1layppMJfLwvGWPyEzk4Smw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHSUDKdQ+BNUmxf4Xd0+SExpB+G5oGAX26VlJjENGtM=; b=buzD7kNDmZ0CLvik51algAcUxpH6sTIMWBPPetV2kcTJWsrvKyk2+QM7oBc6qGrtfgWzTOttKAMODCjoDAXrjRoPUATZDnR9QX0BdetBbSH8clEUAe7cIrBQNDfYDCnroixDij2Iw6XfJudjy017Xy91DmEH17UL74zlhRbRsazuPPPR+fMV8N/lPIVFz8ogI+SQ4SL76niL21fKl3YCcZuAIfV+2G6Atv0T4umN8+ktahFTHUeHlA48/i8CVifmxi8gd0c9PTbRhCyAB8UzadRYwviYCY79d+Z879FI0VFqEz8kV0UNTyczCXZA55ymFjRSTVdd79qEWhCHCSF+Rw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHSUDKdQ+BNUmxf4Xd0+SExpB+G5oGAX26VlJjENGtM=; b=7nLVpel9JB+MVrJf7rYWJZiDZM1TmrxHNKwYicI0iFitExU1bR0IrLkOawwTucTtKtQ/eWQ/pFEmxNyJcDcKNKke2SjgM4p4K4U+n658FOxzJaVPVchfAp/YBeR2cbWoB4H7ujyCYkMzUcmg2lBMlW3mvP3d8zGcCh3w0v+UB1c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hNEwKDYGTiL6iG+04GTUZMvp7gfzX9DlBUy8o6IJGBEjA3CQgpjQ11vcQMwvi7Ml6+TbxunnAcin3EeVIvaL5U46k8Yq5PTYqP6W1oAPGBAdpmg2HPH9+isIOaaCkUuU2YoDgBXL62zogjDTUrzv4uiTOr1l1FHLkw7v+KJDE/dlcvztheM8UAZPaeAc8/dQ9jFZa3crqieqE4J0u0AK+Yrjrk1DUiKb+4WiphhdvwlPfcuu5pdaZWMgmFXRsY5gcHeLd53dEvgGeSBFG2SPGV51Yv0nLLa8PfUKAPHXO9zw9/htq2jX/Ram2RdZxSE+FaLRdkHb9en06xQopwC/og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sHSUDKdQ+BNUmxf4Xd0+SExpB+G5oGAX26VlJjENGtM=; b=dsuI55s2kA3luxxYu2/1zNM7QKZj0jQ47Rm+nuZmj28/u59a0jQXzftza02Xzynof5IaKup4iBs0D+c/KQcGKcwmVZXxAz5zPNXYJg5G15jxsGbtX9W1YA8Zn4m5BD2lOK0YJG7zZhRIIn3PIbXWEAVHfNLVJgLafn2jEgm46beatLk+5vwbD/jSWML0Fm7/5Dn382EusVf9L7PSsUJDmmcV4BrDXspwy8EPayKBPVfY+i9vu6jAsgVoR2iQplsRtC1LCJXKI4hkS1te7fin3mVCCizssjFURSzl4Rpw4LHHyub0br/tCz1Zvuo1GbxmEYZl7ZT0mtCbYzGjPQQGLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sHSUDKdQ+BNUmxf4Xd0+SExpB+G5oGAX26VlJjENGtM=; b=7nLVpel9JB+MVrJf7rYWJZiDZM1TmrxHNKwYicI0iFitExU1bR0IrLkOawwTucTtKtQ/eWQ/pFEmxNyJcDcKNKke2SjgM4p4K4U+n658FOxzJaVPVchfAp/YBeR2cbWoB4H7ujyCYkMzUcmg2lBMlW3mvP3d8zGcCh3w0v+UB1c= From: Henry Wang To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v1 08/18] kconfig: introduce domain builder config option Thread-Topic: [PATCH v1 08/18] kconfig: introduce domain builder config option Thread-Index: AQHYkXyVpDe0H51uh0O21IzCAZjY4K1yIunA Date: Thu, 7 Jul 2022 01:44:57 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-9-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-9-dpsmith@apertussolutions.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B74A75CBFA44B846A11B926FD888EFFC.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b8f9c927-be2b-4cbd-f053-08da5fba514e x-ms-traffictypediagnostic: AM0PR08MB3059:EE_|DBAEUR03FT058:EE_|AM0PR08MB5491:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: boq7Yc+mJuXk6ftHhuYrurb6BoBusiYM2uC78nv26FHxm8DZN2gkOyaBzwAQ84wzYGtm1bzmhoa1kmMc1KD/7ZYnvO5D/aMuCJFVQtqIyoJoeLJfhT3Lj3iNbOaoDq6GhmSbbzDOrnk6woW17Ib7RXXJLEuIwMBGFm+bBqvlckwyFNsHOJ3CZinXb8mZdKprEOfgwBoI0/LelZzozD7vkOr6qqAKQBFPTr7bA71q++0jlAnVtlALGIOmfPAcZyFUwL/GX+ulqrTukpk6qkv0gFiEKrSbD6WD4TdAWhRkknW7mfwUBbjXfg28yJRqRVtY2ACzIne2d1rAov+nAS95mRz6luPQSHMXtnKz0Z0dNPpZO5fM9ghsmMGRMl6Hgzo3PyjmKq0tPfsUPjndA4YEB5BI13kVvxY+wP+lD4JaD45Jnp1qUc6Pb5kFmB8i0rNK6l53sD7tlnZarDytEop2udOOwH9iHs7boRHWbMNBazECP8+Ppgab+or8w1j9NwQ/0qL5n3JADiNWcODkMUWdrb+UXa7tDj+jkt/ZV/PYXw/QEzalompIzQsE7fieVCQRp37y0rwdmPTdVy5OTMNUUQWQitdflyyxSJhJPFX+JfD9hOO30tlKFSKeKkv5AbUZqLpgwa1SS0adL9GQRQXNZOfMS5gz/8qKb1a86M6sRUNSNMUCys1xxqi3CQ32+iRDFYa7lnhruxRoh/GyBUHR/NirUFW4Dx+uEkZ/e9SucjDRG6jSV6ynamIxzifP/uwF6Sh0zvyCHX9ttQa/2mZ+mIaovNlxCIrcDO/p7pdSKktz3Bd0okLpmqsvPGdrhz0S X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(39860400002)(366004)(136003)(7696005)(6506007)(9686003)(26005)(38070700005)(71200400001)(186003)(83380400001)(55016003)(33656002)(2906002)(122000001)(38100700002)(66556008)(478600001)(5660300002)(316002)(86362001)(41300700001)(52536014)(8936002)(7416002)(4744005)(66446008)(54906003)(4326008)(66476007)(110136005)(64756008)(66946007)(76116006)(8676002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3059 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 386a646a-09dd-422b-4a41-08da5fba4c97 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2CgeByeT2xqAOEFHi0MiyzKb2A0b52OcLvAnT1jRN47xy4iuOdjggwdJLBGeMu4+k/uO7l2lKGzkDMWoKOl1gLDi6CNhhu7k7GH113PmaJQcIeNZPr6oqttWlcaXrmzHlBookyYYiJVB8hFlge74kR5QPgJml7x/CBIjPzAZ0oh1/kX7lEI2xIGwvjmRMVp+OfEEjNfQPp6Q7eL2n6zaYIY+wNkfS+1kdC0B9nkuL+D4yEeeDXlMGNaj1d2eSh7Ajt7a0RoPpw7SaC6kR8kIqKD5k6UoL81px8E2cgOfkP1gEa9Jl6CkwXwMW+B4FHFy7Tjy+hQPq+BeW8OLChYhvwyZmsU4nqlsP8LDRiXRKQCTuZ/akdVCbwC9oqdLzuHov6hwa68x4jl096Jl54qmLHLQNm1UWweGYRheIoHJaIoYwZl/t/5MlE3UO9zvOuAbYnSOJAfmmka9VqOMSosuJRKCI/0EFE4/9L0U+fQVCcmC28Lox/l3cJSj4GF0sAubnrafLbbdwZGAyMq43WK8YJ7/HucAqeBCSduS2pBjlBqnDuhze+kNribd7myjEoFycRTMnv2gmdFOpXWKQVg6yk/Cy614EM0bnH1n4rsWaJIMpGFKB0tsr0Yv9Y0iSIqzCkjHo+dYPA1FZWE+GslIsgk4CzBi9q9GRmuwfix0MM4PZyMWjeh+1nQHJVu2HPk0VxyTUTNVD6ZJOVWhgCzlSD9/bxWM3emHJTZhhwbYp42DN0KG68cLph0KNBYnGKPbRCWLDcZ9mF1y8NWv8HYfqdzwFjU3nqB3yAFzbPLQNauMA0ykCTyL3HUXvnPUMEwm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(33656002)(356005)(82310400005)(40460700003)(55016003)(110136005)(478600001)(8676002)(70206006)(82740400003)(54906003)(40480700001)(316002)(4326008)(86362001)(9686003)(26005)(83380400001)(336012)(70586007)(7696005)(47076005)(41300700001)(186003)(52536014)(6506007)(4744005)(2906002)(81166007)(5660300002)(8936002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 01:45:05.8873 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b8f9c927-be2b-4cbd-f053-08da5fba514e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5491 Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 08/18] kconfig: introduce domain builder config option >=20 > Hyperlaunch domain builder is the consolidated boot time domain building > logic > framework. This commit introduces the first config option for the domain > builder to control support for loading the domain configurations via the > flattened device tree. >=20 > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark Reviewed-by: Henry Wang Kind regards, Henry > --- > xen/common/Kconfig | 1 + > xen/common/domain-builder/Kconfig | 15 +++++++++++++++ From xen-devel-bounces@lists.xenproject.org Thu Jul 07 02:27:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 02:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362712.592883 (Exim 4.92) (envelope-from ) id 1o9HEJ-0006iJ-8e; Thu, 07 Jul 2022 02:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362712.592883; Thu, 07 Jul 2022 02:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9HEJ-0006iC-5I; Thu, 07 Jul 2022 02:26:59 +0000 Received: by outflank-mailman (input) for mailman id 362712; Thu, 07 Jul 2022 02:26:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9HEG-0006i6-C8 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 02:26:57 +0000 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 427630ac-fd9c-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 04:26:53 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 19:26:50 -0700 Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga002.fm.intel.com with ESMTP; 06 Jul 2022 19:26:50 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 19:26:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 19:26:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Jul 2022 19:26:49 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by BYAPR11MB3782.namprd11.prod.outlook.com (2603:10b6:a03:fd::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 02:26:47 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c%2]) with mapi id 15.20.5395.021; Thu, 7 Jul 2022 02:26:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 427630ac-fd9c-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657160813; x=1688696813; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=l02ZgzzjtxBR02xbLyESgJpMNKJgFapPVKFCv90Y5jI=; b=aTNSRWnn2AKp9G4pHgCdeWDfzF0TjaEfnORMj+1ThSshLyWp176lMdt6 WKr3rQLDcsx25ljMJYgVTU64xmFvE0KFG8yIIou2Pb2KOWKPOfGR6c+3p mn0zMJzNjYJ5eAXsIUDvpdkKCAA79uhpGJUHFR0Nc4XsEdG9Q5Jc1z9Ap +s6yTA1gsKfDF+SoB734eHmzEbrN2dNdMKqzaG01h0/M56PbwMvb5U6SL cB1XGqTrLUe7GijphOUTnqGquYwww0bGVw7GR7mXmGZ+nm5Y7nl7chHo8 xgHF/GmTe9Oz3RACBajB/lTmb8ZoYpHtShAdSZz6P8cB2GCE4pe+40M6f g==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="272705018" X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="272705018" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,251,1650956400"; d="scan'208";a="696342033" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PuQGcew/OQjHkx8jfMsz9X2gD0S9ZPd+j3JQhW6ObCyqlFk044ZV/7zhi93XFlwd+d+EqNBGN6dl0YvkErMRJx94CKgkhLxjDnjihx5yBN3xj/b2uJTEOPlJisZ73LlkLSkG9nG+1VGOZozjvjH+Z4x7X7reT6Q5GI1xa+nVGim0BBg9z/kwBVhKQDu3WJD3qcUVK9I51Jj7r4a/Kp52qqYps6GVKTTThvloD7cjAwO0BOz2HmUrD1xob1NW+QiPuvYfLoAQjXmCgjZD6eSp69yNOHsc5ymRVSF6ykJW6EYa5zK9DjFosQiqJzMIiEQ8G3GFaJEn3BAPRPkpNOZsMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l02ZgzzjtxBR02xbLyESgJpMNKJgFapPVKFCv90Y5jI=; b=RVJhFCAUPbnK/qAHpYHE4UuPj5A/ryyQGNtrKQNUf/WJtK1uhz04yZ6tFaTuh9p3TIDbxSH7EQqeY38rE5icefYNmS6AOT008t4t7eRZs7lk4NQKwnC0CZFAfqgMa0Z9KfHorOXKUL04wX0axtYMD+0C8dqzH2qTEYlw8atgxcJKYsSf+xLNB18Oenum38Gdhp5E8wphONmdYVzgNi+lYhCQeTcqwA4I0r8en6MYtU/xeO2E43DdN6JJkyF/ry551dXXXQ11HiwwG45HQLyou0MfXUGoWXLAlHiyt8n7+5HHaLPLITgiIFffXjDFJjOTDg6yCVlQPYdadUfKLVzqoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: "Beulich, Jan" , "xen-devel@lists.xenproject.org" CC: "Cooper, Andrew" , Paul Durrant , =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= Subject: RE: [PATCH v7 04/14] IOMMU/x86: new command line option to suppress use of superpage mappings Thread-Topic: [PATCH v7 04/14] IOMMU/x86: new command line option to suppress use of superpage mappings Thread-Index: AQHYkG0USa5jTvMMrkiGoFwB656pZa1yMPew Date: Thu, 7 Jul 2022 02:26:47 +0000 Message-ID: References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <7e587d78-43bf-70e5-b629-b7fbed0ae0fc@suse.com> In-Reply-To: <7e587d78-43bf-70e5-b629-b7fbed0ae0fc@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 075c31f6-bcbf-40e6-8e12-08da5fc0241c x-ms-traffictypediagnostic: BYAPR11MB3782:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kik+e0id8xnjl9NdTmW+Y0PlexKOnxvG8j0oPeYDcz0QMfpihF3b347TKQjzh+vnylpAp875GHVEuPQHaN30wWNXX+lEk4TuYYLDPFatyk40xn9nKfM1eP7bq7mpWbKxdzXzJ2hh5eSF+2X/tw1+cVEmdDWtOOTt4Go9wRXHdmmq7r7zRpPwoXjeuCTd2/x/6KE/9sby5vMJxGhT6r+pHVsyDnmpTE+QQTUTCKlIanMpcDckkX+NPk+TjqjgVwQvXiMM0c0VZX6Z6xHPHgBbVSgsMpZaoRtpyiU+qwHaC6GE5sLC33opTr8AcbRJtfxpLW3TxSwpZmHewGc9hbvH9QWwMLGIU7ZpmCTuCa2tj/4ZUMqdVeHjwwAhsmYPRqOmow9bVolr9eF5vqIMz36xyZcLAx3HVd8eQmRowPgKfxegO7viwsp3JLlqFpzIGh3D3VsKR9FYMTalu+ITVC313ZcxRAEkf2s2PVL7s6/Ou1HCdRoKYF9uDPaJk5pXkabU5hJi4+VMMRXGylS5ancKaJInfmsgUZA0AbOKMcVt/nbT34yTerj6M9c5JoSx4HNJ91z9pogmgNG2S5tHCnTA8bFTubhp+IPFpkuoZyD6+n3Nr1xGc0rhsuYaiQhWfaRsU+1CeRP4YhxbV5dyDtVeueVEHPL8Ovwq13TopVbmAUo/ZyTdnxSJYmdoq9uI+H4m1Z13V1jR0PrA4APd6dyjQ4y3WgrMBPDQA/MUbYDtyTnlDeHE5tTKoYSAQ871t7PoH+AxiULXC4qmpenJ/HS1AOAsodZO3p+baHxz52ewp/lV95MzFeDi2zDJj1t+eypF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(136003)(346002)(376002)(366004)(82960400001)(110136005)(316002)(4744005)(8676002)(54906003)(55016003)(5660300002)(86362001)(71200400001)(8936002)(83380400001)(66476007)(38070700005)(64756008)(76116006)(52536014)(66446008)(6506007)(4326008)(7696005)(41300700001)(66946007)(26005)(478600001)(66556008)(9686003)(2906002)(33656002)(38100700002)(122000001)(186003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WE9sckV4SENqWFkvNHFIbXVpKzVleFNBaFVtSktOaWc0Mys0TkFySER3dGVt?= =?utf-8?B?SC9VSmYzSVVORVVhMkx3SEljUXJKRmhiQ3lmbmVOb3Z2YWFFbjVJTHozNEdh?= =?utf-8?B?RVh6QVN3RzhCRHhITXVKaTMwaGUvMTM0Y0pnQ2prcmZ1QWFySXo5cklFVVJX?= =?utf-8?B?TkZpMllyLzNNSWVmeTdOVHgyMTZVOFFxQU1NQW11MlM3QlhyRUdNZUNrSHJs?= =?utf-8?B?bTNkanNURUhPTGhCNnBYUWpta0RQeHRTK1dSd1FsTjBZajFieThhMVNQTGJq?= =?utf-8?B?ZEYyTGhhbFVlZzVCb0RxMmdwbTdXMUlpL2RmTlhYUitoWlpBMGVaZlM4VXZj?= =?utf-8?B?UVVZcUJNMG9ZT0NiaUN1dUo0Rm5zZzdKS3dLK3NnTW5ZdG9zTjYrSDI1YzYy?= =?utf-8?B?L0VSRm1rM0ZYYVQyTWVpdTJQYWorcGViYlpuL0F4dCtsbHVXQ0NBWHlGUlU0?= =?utf-8?B?Sll1VUNBMGRUaEdpUXhCU1c3VWVnM0JLb0RsaGM4WHAvSFFsQ0doWUxJY2gx?= =?utf-8?B?K2FuSjZTMC9CUWZjeWFhR01MWTQrd2Y0WFJPRVFkZFRFUnNjeXZXbXo2UGU5?= =?utf-8?B?Qlp3KzUremVaV3htQlphNGVCS2xQYmwxaVYwNXpPdVlqWXVNWXpMbjhycTNl?= =?utf-8?B?UHpaY3Fqck03LzM5TCthM1JKN3ByNjlSTjl3eEtYdG1acnBqR2thbWZ1UDQw?= =?utf-8?B?cjBPVDlzS0gwYjFlOEJMeXVtY0JCSngvYjJNMUl2QlBpVjU3TU5RUnh4VXIz?= =?utf-8?B?ZTN6b1l5RDN4ME45cUR0TlM2U0VCaUJJajJ3a0p3Y2diYW1EZUZnZmtCaEJK?= =?utf-8?B?US9mZkViQ1JqU0E0M2tVRFV3RlU0YnRFc3BBU2hFM3FxMlJqR1pkTEhhUFRu?= =?utf-8?B?T3hpTmhUVG0yRE9TTm0wUGN1dHJLWWxoREJGTmpzL0NIL0lGL2pvNTJBOTBv?= =?utf-8?B?KzVPOHp5bFAyVzJNMVV2b2xYd3VkR2RFbllYQyt2d0IzZlRwNkRuSmZUeVJ5?= =?utf-8?B?MWtNSzdtZy92RUFNZUlBMHljRTkweklnYUs2Y3dBd3B6Y2lQOEQ2WGNRY2tG?= =?utf-8?B?U3RLUmhZeGtOYnM3eTlVZC9iZHpIM1hsbFl3MVZ3aUliaWhycWhsS1VQcDBp?= =?utf-8?B?MkRCUkFsbzVtSDhrTDdQNk9vYTkwZVRLOXV6cXZzVHVFbUJzclF3Q0Nkck5R?= =?utf-8?B?S3lrTGJ3UGtFRjVjenRxaHpWWEUvVWF0Z1Z5OU42V0VtVlpLbkhZck9mTHpD?= =?utf-8?B?d3d0Z1AvN21YWmN2NEE2UHR3ZEFoS0dFQzRMbVdrSG8zYnN1VXdrVDVuR3pK?= =?utf-8?B?SXh5OEMvV3RLT2xUOTV2NjNJcERORTRER0pkamtLRU5xU1pNdFpRNDRVWmdW?= =?utf-8?B?K1dtYlJ6d0tuanlHV3ozdW5ZUFpIMGFGL1o1VEgrNTAvWkV5ZFhyRWxwR3Bu?= =?utf-8?B?aTBaNHlwdFBkZW8vUDlhWG5WK2w2dmRvNk9aNmNGWStJZHBhZ01iYUUvUk45?= =?utf-8?B?T2lQK3JxenEwbzF5TjI5enczK3lwb0kxWlBzNktSNlVyK1kvR2VnVDNpQzJE?= =?utf-8?B?REFuSWVBc2dNcUpQRGdMdlR5RXhXWStuSGJkTzdLa2d0V1h2dVRyQUJoeWJN?= =?utf-8?B?dlJkcGV3Mm10U3V3T2ttZ3BFWHhmUCtTME5uNGo0emZmZk1KaDcwVVpkYXZE?= =?utf-8?B?eGt5VEVLanQySTl3RVBxS21QVGZnTm95cjVJL080cmRTWTVHYmJpTEFHSTNt?= =?utf-8?B?alU5cnJUNnJnOGVvcm1kSmp0cDc2U1ZaRFJleno3OWdSMG42ZlZsV0diMDZF?= =?utf-8?B?blQxMkd2WGpJUVRGaXNZSmVtRVN2SDU3SUpvemdqOWFPRDJFVWVmZVlkNnpp?= =?utf-8?B?NG1OcTRLcTMxT3N1UHhXNnNIbHFmdVZ6bEZ1bG1odE5iK1UyUFFtOWt5bWVa?= =?utf-8?B?VmJCUXdkUmtXK3diNTRGaXJIeFg1R3Z5OWUwRTlPWVFOVWlRYlhkNldySnAz?= =?utf-8?B?ZEVIdTdnZTZEME4yTExpNUZ4d2sxYWpoRXprVXdIUEFCUlNDQ01PL2c2cTNZ?= =?utf-8?B?a1VYTEk0ZHNrc3VMSFZFeGFmT2cvc1V3MzFYRlR1NDhITk9HbGpGLzg0Tngy?= =?utf-8?Q?p0c4Q3QMwrLzgsW0oD8tAYTJp?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 075c31f6-bcbf-40e6-8e12-08da5fc0241c X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 02:26:47.0400 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: trcTcWildx9kIRYsSC49f8ykwiOZipDxZLfvYOpq2grdmw/jO4FYKkjYS5usvucC9I0o1NytXylI0Wo6JwFYZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3782 X-OriginatorOrg: intel.com PiBGcm9tOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IFNlbnQ6IFR1ZXNkYXks IEp1bHkgNSwgMjAyMiA4OjQ1IFBNDQo+IA0KPiBCZWZvcmUgYWN0dWFsbHkgZW5hYmxpbmcgdGhl aXIgdXNlLCBwcm92aWRlIGEgbWVhbnMgdG8gc3VwcHJlc3MgaXQgaW4NCj4gY2FzZSBvZiBwcm9i bGVtcy4gTm90ZSB0aGF0IHVzaW5nIHRoZSBvcHRpb24gY2FuIGFsc28gYWZmZWN0IHRoZSBzaGFy aW5nDQo+IG9mIHBhZ2UgdGFibGVzIGluIHRoZSBWVC1kIC8gRVBUIGNvbWJpbmF0aW9uOiBJZiBF UFQgd291bGQgdXNlIGxhcmdlDQo+IHBhZ2UgbWFwcGluZ3MgYnV0IHRoZSBvcHRpb24gaXMgaW4g ZWZmZWN0LCBwYWdlIHRhYmxlIHNoYXJpbmcgd291bGQgYmUNCj4gc3VwcHJlc3NlZCAodG8gcHJv cGVybHkgZnVsZmlsbCB0aGUgYWRtaW4gcmVxdWVzdCkuDQo+IA0KPiBSZXF1ZXN0ZWQtYnk6IFJv Z2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBLZXZpbiBUaWFu IDxrZXZpbi50aWFuQGludGVsLmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 07 03:31:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 03:31:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362719.592894 (Exim 4.92) (envelope-from ) id 1o9IES-0007wE-VM; Thu, 07 Jul 2022 03:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362719.592894; Thu, 07 Jul 2022 03:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9IES-0007w7-QZ; Thu, 07 Jul 2022 03:31:12 +0000 Received: by outflank-mailman (input) for mailman id 362719; Thu, 07 Jul 2022 03:31:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9IES-0007uX-57 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 03:31:12 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10048.outbound.protection.outlook.com [40.107.1.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e0c57d1-fda5-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 05:31:09 +0200 (CEST) Received: from AS9PR04CA0122.eurprd04.prod.outlook.com (2603:10a6:20b:531::24) by AM6PR08MB3991.eurprd08.prod.outlook.com (2603:10a6:20b:a8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 03:31:06 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:531:cafe::84) by AS9PR04CA0122.outlook.office365.com (2603:10a6:20b:531::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 7 Jul 2022 03:31:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 03:31:05 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Thu, 07 Jul 2022 03:31:05 +0000 Received: from f8a3c7e6a6b0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2AEA2DA7-7EDA-4754-9BB3-30CF903CC43D.1; Thu, 07 Jul 2022 03:31:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f8a3c7e6a6b0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 03:31:00 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AM9PR08MB7032.eurprd08.prod.outlook.com (2603:10a6:20b:41e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 03:30:58 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::74fd:9baa:fd29:7ef7]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::74fd:9baa:fd29:7ef7%4]) with mapi id 15.20.5417.015; Thu, 7 Jul 2022 03:30:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e0c57d1-fda5-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T+lZ6GTIMMfiqf82O6h4mC3CkUUkHY/TA/NNwzVrfUXjbJpxnky0ixHJnA/ptPmpbeI1ZQNyicsGf1LQVTzAvHkL1tjR85Ut0gbeYwmQPcjn5I3I4vW6rY5QhmDTysp82zueXDh/t3D8n2JawbG/lAaMBue0PWypQG6D70+ZdtxLZ2+bXuCEO8bsLxivcEfZGBmv2p+6agGYYMqyJEvElpsrOHNmd8Nc/N9cZu9M4JggLUig0JGF5a96wYFy66qEysnwqdPO9OQTJeNKyWv4XJU8ILoCmgTenffZSoAb6aq4sm/4cUiNk/UjbxoQd1+bpeSkqKBvjiEU4RxPizNoyQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AS0SBTOWGJQLdu77eJQoj3EcSdOsUilKvSb+THZxMdc=; b=IErxdtLMXTdZF7rj2oc+ApmVEbeZFJZ0PV+oc6tfcddDUCPRx0v+crMBr73gvhh3BEx0hFs05t6tmCCMXO71UTtJiGkbtbUS4LwZ2rLDl264JrGw9rVqodWaBrQyWO62onnXWgxL49VPFGIHxGqDoWMM+9+ZTGL+QAwCsD+5+wMr4PwZ8amAfHS2eThCOj6k+8IAbJLrsBccXAiGoYLxg9CoXNl7xeZMD9hJS70AybAq/IMnx+hdEvVCe2Fh3UsN7TNhC5GPPcqOGXAofLBSQIyef2KsaYnj4F2OTjDM8ZXXK1LirB0Qp+V0QyYGmTuvoT/J2GmLgrnn5KzFgXxcPw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AS0SBTOWGJQLdu77eJQoj3EcSdOsUilKvSb+THZxMdc=; b=FDZ4n3Erjpi+7KNShaWHQxJBxq4+/jyU1sL2lsl+gggQTu1P68X+qnGVThreMMWgWNUOtRSdJxtcz6TyMcCWGX/cTGk5CCRInIUbo4/8hW1UwdFxZtNqSy/2JF+XVsCHlFiS6ELM0D/sccJsyHXtbkXAbWcMxqWgzLNV/puK4xI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHxJgnpZKlSt+ZYN3NkTfyR/saV4yVDpslwT8NaRHEPbVSENA1YwOg2yWgn0xse7rAHsCcioPIU1crSk7V2NQelasd9cVHOATL9iUuRxLSUsBj5kYyv6ZOG9/ej7OtD1Iej/KQ6OR4QaRZbfOpScXdpES/lbFf2kVv8KC1P8ihb4JqeuBBpMvrcQj90l5a0bYcXdXJ5pnoUmbD83ICT32twi6evc6X4NnDrO++4reyS/tNFN/d8vJjjx1FQ3WkxIm2/DutYXf0k8Hgw9T6s2qoKvI8O5l8nse5Mam7sRdlZWYWvgA993AfC43gsTTu2xi0c4AM3Zd/C895xCmUf5VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AS0SBTOWGJQLdu77eJQoj3EcSdOsUilKvSb+THZxMdc=; b=WJwvercPGJdRMBks4Goe3YnhqcqGWWtf4snQSvpPcnASeWGXup1FayUfBmfLLT5yLiMGCAvuSxAbaqryPPObwQM8e4Eck0HX7YjqTTNue0dsya6imv2sq7Xf0sG5KppceAu6YqVPHtPRDf7nGy4uTrSoi/+TzBmIeSI5PTC5xPwE19gk9H9TN1HrS0bJPvnqobwQjpVWtEb1ftIgPqQWhy+QoPkiByffXK613JuD/HFXt4Gt833QJHG2TykHM2CHngY33E3EwsMgo75ZVJPjiEQF9Woo6g02EHJbG0vGxAXKXUrZX2eZ3/u/cC/2KJNqihmJmuAEkDBrKMQBSysD0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AS0SBTOWGJQLdu77eJQoj3EcSdOsUilKvSb+THZxMdc=; b=FDZ4n3Erjpi+7KNShaWHQxJBxq4+/jyU1sL2lsl+gggQTu1P68X+qnGVThreMMWgWNUOtRSdJxtcz6TyMcCWGX/cTGk5CCRInIUbo4/8hW1UwdFxZtNqSy/2JF+XVsCHlFiS6ELM0D/sccJsyHXtbkXAbWcMxqWgzLNV/puK4xI= From: Jiamei Xie To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH] xen/char: pv_console: Fix MISRA C 2012 Rule 2.1 violation Thread-Topic: [PATCH] xen/char: pv_console: Fix MISRA C 2012 Rule 2.1 violation Thread-Index: AQHYkWD/iwSB6pN2ukOyl9oTmyPHm61yPTaA Date: Thu, 7 Jul 2022 03:30:57 +0000 Message-ID: References: <20220706175013.675258-1-burzalodowa@gmail.com> In-Reply-To: <20220706175013.675258-1-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FB83FB282B08C0479274D9E783CC850C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3749b008-bc89-4faa-be18-08da5fc92036 x-ms-traffictypediagnostic: AM9PR08MB7032:EE_|AM5EUR03FT043:EE_|AM6PR08MB3991:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 2qFGpEfw+Z+V3Gt418U6eC4LTVOtvdblNJk2P6atpCjt4ae6fSAmjUl6SR5aFJEcC4Qje+b1yAlbfFaWode7ZLi8h7KX5hanF2Z2xnjIM+PAaf7lFgcn02nshO2xo8s9MUZ56VSdb+TZ1FK3As9tTZsICgbPVMlp8h2NsxtIEuJwMFjNDesGFBdOlS2mYQjMR8G9A1LoSR5LBHS0pwuhmxS/ZE+HGw50Cz00QFl+3jyMqVmuRgVY8BnJkcH146BvHyUukCHQrx3VbTaFV0Qd5MO5C6arOd9vCOZWuYsOB2170beHq99yusXShnexFEkJkVvP3ex5CuYNa9aJ+0cWCa5xvwSggihUbFoRJNQDpgKKG2KLtyt2gN5f7WDUrmkLp7MA4inw1m4Lv2pdch+pOAhPlxaMqL3AZiE6PJFsA3VzK32hgJDXhx5x9hBUpIWU9vYngegkfJsdNQKqEF4UqAgcPkgeLM75AYWbpOBOU3R26HhyQH66pDc1ENHEofigZjQFGdQk9E0vRiQ7n/4e8y9ibZIdDN2BPiwLAi5a3NuvkcC2JZtYAgPIy/Q4H6OGlJPu4N3pqxlDF/9F9WnRqsYvKOOwrE7uZiKOaJwd8Jl3iFpV80xKbqZQXiQPJiIw7htJmhjI6U3rrC4R49CnrOysCLKynUsdQw4T3SSuwpN+m55LYvbddZc3ZAn5ep76IXDGs6aqbFGGtDWy7+5yqDrk1ylibAxhHz8X5WI1IVNpUcGGp5IvXYU9lFYM49bwKCTLo62OCJPJyTlT/5XmUd2FvitLzUK+Jp72okfK/thFAmoKrE+NXjBsdaiYSYMB X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(316002)(83380400001)(122000001)(38070700005)(71200400001)(38100700002)(110136005)(54906003)(8936002)(4326008)(66946007)(76116006)(8676002)(66556008)(66446008)(9686003)(64756008)(5660300002)(66476007)(26005)(6506007)(53546011)(478600001)(41300700001)(2906002)(33656002)(186003)(55016003)(7696005)(52536014)(86362001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7032 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab6e92cc-b60f-4d4d-9e69-08da5fc91b6f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: opzZqQOoD/90Yx5cdiu6lff7kTvqsSVr9cJbT6CACazhDA6UNMj9FzfAfKcpcG1bHOJKvf2OlBlBY8nT5u2BKmnxVr6j+4Jh1T8KJc7fMlycNHxYE8R1UhiVpP730KL7ZEa2Y8XbeM1zHCarGP4tvIPY14MmdTXw8rVIkDB0UZLZ1pIfyz5SgOl+lez7mvC5worjbjsfZd9Q9iTAHELSAQozNvv3+khoTGGH3rrNgH3gVrV+1b1O3L3BuAoVv8hrvIatG7NL4cnr3lq95nSuSOwIfL2wYq+O/lUnBIgxW2KM80BYXPN5N5JlAZVXtn6Jd3e+AiI5qmKK+6lfIT9jElKPxlQTbQjm3uxs+YpsBl31CuDL9hshZU3f/kkSmadWLmJBW31CZr/XjMBNp/nZeSvEX4cwJ04s2+kX863p9Tm1z8W4zNMDFt/UO7SS1Sgy9Nnp9kl3FA6/SwgkLdC/AnwMpR0usFBTiYAJ1U+E2JmJdLNFa7K5L6qVx5HR4KBSlk8LJeEcsnQtcMV097k6+lLilyJv8xI8dpNPoLpRYMGZZkLN7F/zMj8bhfMarhuMCEGPUxzTFpsN9b2YoT258+A1z0UdO56IJfsj160PbXQDB/GI945fC6BQVUhI+OMkUF5DC5KsG4WxfPZTM/EKq3HpnBmKn1Ysy274McKQWRQgBooYz9nIRabGCeuTeBe4p5YJk9uZr+hzUyZzqukzNBVjNU32udfxpDrvHfPbgU3XgXBG9GpNnjsVQYMooLh1X3I7nOZSeBZD53nU9Gn3fUiP+ZKHdaNUcteUxyCCNz+NOa4WKm9/1LnH97tb9HSG X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(39860400002)(376002)(40470700004)(46966006)(36840700001)(54906003)(86362001)(36860700001)(33656002)(81166007)(70206006)(4326008)(82740400003)(70586007)(40460700003)(40480700001)(316002)(356005)(110136005)(55016003)(53546011)(5660300002)(52536014)(8936002)(336012)(47076005)(83380400001)(9686003)(186003)(82310400005)(478600001)(26005)(41300700001)(2906002)(7696005)(6506007)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 03:31:05.9245 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3749b008-bc89-4faa-be18-08da5fc92036 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3991 Hi Xenia, > -----Original Message----- > From: Xen-devel On Behalf Of > Xenia Ragiadakou > Sent: Thursday, July 7, 2022 1:50 AM > To: xen-devel@lists.xenproject.org > Cc: Andrew Cooper ; George Dunlap > ; Jan Beulich ; Julien Grall > ; Stefano Stabellini ; Wei Liu > > Subject: [PATCH] xen/char: pv_console: Fix MISRA C 2012 Rule 2.1 violatio= n >=20 > Remove the definition of the function pv_console_evtchn(), > when CONFIG_XEN_GUEST is not set, because the function is not used. >=20 > Signed-off-by: Xenia Ragiadakou > --- > xen/include/xen/pv_console.h | 5 ----- > 1 file changed, 5 deletions(-) >=20 > diff --git a/xen/include/xen/pv_console.h b/xen/include/xen/pv_console.h > index 4745f46f2d..55b20323fb 100644 > --- a/xen/include/xen/pv_console.h > +++ b/xen/include/xen/pv_console.h > @@ -19,11 +19,6 @@ static inline void > pv_console_set_rx_handler(serial_rx_fn fn) { } > static inline void pv_console_init_postirq(void) { } > static inline void pv_console_puts(const char *buf, size_t nr) { } > static inline size_t pv_console_rx(struct cpu_user_regs *regs) { return = 0; } > -evtchn_port_t pv_console_evtchn(void) > -{ > - ASSERT_UNREACHABLE(); > - return 0; > -} >=20 > #endif /* !CONFIG_XEN_GUEST */ > #endif /* __XEN_PV_CONSOLE_H__ */ > -- > 2.34.1 >=20 I have run it on arm64, booting Xen+Dom0 and starting few guests, connectin= g consoles. It all works fine. Tested-by: Jiamei Xie From xen-devel-bounces@lists.xenproject.org Thu Jul 07 04:01:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 04:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362726.592905 (Exim 4.92) (envelope-from ) id 1o9Ihu-00048k-CF; Thu, 07 Jul 2022 04:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362726.592905; Thu, 07 Jul 2022 04:01:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Ihu-00048d-7w; Thu, 07 Jul 2022 04:01:38 +0000 Received: by outflank-mailman (input) for mailman id 362726; Thu, 07 Jul 2022 04:01:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Ihs-00048X-Qu for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 04:01:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7c7744f1-fda9-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 06:01:32 +0200 (CEST) Received: from AS9PR06CA0544.eurprd06.prod.outlook.com (2603:10a6:20b:485::14) by DB6PR0802MB2551.eurprd08.prod.outlook.com (2603:10a6:4:9f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Thu, 7 Jul 2022 04:01:30 +0000 Received: from AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:485:cafe::c8) by AS9PR06CA0544.outlook.office365.com (2603:10a6:20b:485::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15 via Frontend Transport; Thu, 7 Jul 2022 04:01:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT017.mail.protection.outlook.com (10.152.16.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 04:01:29 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Thu, 07 Jul 2022 04:01:29 +0000 Received: from 45ef77599f44.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 48230E00-9F2E-4FCE-8EA5-FB8F9C4D4304.1; Thu, 07 Jul 2022 04:01:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 45ef77599f44.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 04:01:23 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM9PR08MB6849.eurprd08.prod.outlook.com (2603:10a6:20b:301::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 04:01:19 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%6]) with mapi id 15.20.5395.021; Thu, 7 Jul 2022 04:01:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c7744f1-fda9-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QGmKY5H+mdZFoWCA5CFlF4zOnUGsFzBxU1Vhj+edtAsjr0EMsJ58ZqfMkcDiF+bZb3Gv2UqG3Xem/g5LUdT8la+M4NxPwl2rsyTtDb7oy1OBuivfc3YuT6gohmxlz2TixzmKABDRRYTYnoirfln6J4BmVyU65c0GumsUi1dPWC2xbU2ZnpXmo2IxN990+58+d8YuKgstADiWF3/rKV/p0L23gGlHQdeCRyY8gCMKqSFfZ9I9/+EVE3SgCHbLCcgEtJGNPZy+5OsAORFSmi83s6wGbl13/MCgf9AdbshpaA+4w6kl8PwggibGyIiCpMZNlKkBAQm8yGQEVOkZWi2Y1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cw1yN525yKkhsVbRuy1UxSu0d3aa02fU2gVk7Lvz1Ws=; b=lg1oyb2u3pLrG7XA3Wj+5W/NlHjoSS6b1RIFAQEYF5ciN32uvfMlUCmHNBDTuimUfWQP53K/lHCtr9zsjglotMUvmmwxwaCn7GGnO4Gv2MhhPV5SQqZgIW5m772YsdW87NIa+BuHmTIEe/cyQj6kx+pkiuG9xfyJBggUc5U1K+zBEdcT+KktI+9Dh1RQlzb6eTqE1MS6EDA1jIPuf6KbcUhOaZY7xgGSkDcei9Lpx43c4OWjkM22O6D/B9fJD/2R1zypoY9Eh0XykOCr2xcxecklhDPdAJeHOgpyfDKdOKZoHj8vTjO+NJMYuh1604VYmRCT7REBArzjXMdPiRuqCw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cw1yN525yKkhsVbRuy1UxSu0d3aa02fU2gVk7Lvz1Ws=; b=Blk2R5Wr9BHdbDncAP19HH6/9QHaNMhPkzC6NkCT20WoVtA8Tuu0ZPIGy3dI169+4DfoyHv+c672IkLMDD66m6g8tVdZPYpfp6lxK0K1l9zr7W+F0iEN0q7Ho5tQRjhgfy00B1X8vIzo8td5zuTgKp//D/GNOhl6eDZOMQkj2GI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YaLvW58dp72jygXd1CLvGKGAiAVrjqqIUBZREhqR+SpjlRs1oIBA+pSHsmnIB4OVIMrQoyi7mG3y9vpUg4h3zhjFdGlVonMEHG/bn5Dj6TlC7KI8VGtOMcnQYVIrPACROgFt8lyx2oyQJGUFCJ+AtAnhkCmhg0/rSMdNY624uqZB+M8KVJL+jH7UOO1iiIIQVb0s7bti07EIOIzs/bUT9EsuUMX2zUvRZiVPEsrqkLQuMLu6XPEFo7IjMl0ornk5UbfOJ2t/ajFsHSABlz+bdUMnyPBu/jYjLqGuXskn+F91xGHzR5uf+XhYFbEwcK+WEibo6B5gZjfoQAK/l+78Mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cw1yN525yKkhsVbRuy1UxSu0d3aa02fU2gVk7Lvz1Ws=; b=ASOQ4acl+4Xz7zh0ZK2BVFQaT74Jo8tT3cuznptW3NMq6LPvJ8iPZ6WLd22HkLAF5+/5iQOgkMt2vUtUxPdgnuPxQJG2wVVTCsm3+ZSgZ4lW+INoJRWkDW/ru5PZARqYMsjetFIS0DEIF1sGCpn2urBZdvDxydClads9IBRo6ww8IyY8l/TpBF+i+wEbpXEwg0P4TjtlaS5wGLkdyGOKaa3zmUqOtRI/VLoE+tiQN3o7lvHOJokG/+RHrzFzMGVpj0xFXF5zjGjj2fPLv/6G1GnbRrvvoSd2AwzVNyucYPVKvi6Askui7TzjbUcFjC+Mwcvk/2pAr7y7LUX/GHXubg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cw1yN525yKkhsVbRuy1UxSu0d3aa02fU2gVk7Lvz1Ws=; b=Blk2R5Wr9BHdbDncAP19HH6/9QHaNMhPkzC6NkCT20WoVtA8Tuu0ZPIGy3dI169+4DfoyHv+c672IkLMDD66m6g8tVdZPYpfp6lxK0K1l9zr7W+F0iEN0q7Ho5tQRjhgfy00B1X8vIzo8td5zuTgKp//D/GNOhl6eDZOMQkj2GI= From: Penny Zheng To: Stefano Stabellini , "julien@xen.org" CC: Julien Grall , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYhGRGiM2+sN9ON0uL+hMDdx46E61e+NuAgAApAYCADsZBcIAENhcAgAAuPSA= Date: Thu, 7 Jul 2022 04:01:18 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5801D63C32667D48A74DDFEB349B8CC7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e5fd3f23-96a7-4235-02b6-08da5fcd5f30 x-ms-traffictypediagnostic: AM9PR08MB6849:EE_|AM5EUR03FT017:EE_|DB6PR0802MB2551:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: viMFLsIGKfAhd8sIVYV7odOa5MwXtK56VeuElKZl0qu1w0OpajD7mOs8o8FewMLG7sg0v7bC2vUsYKgom/R5azXyVKs8sMS8XUmzUn5VHOB/nk5oFBl/bpHPsrSa4QWhfIsbCvKX1N/4P+GIIRBnq7RIppKdPLfFN9kqibhh2n98KFUap6oKx+lkIeTZ958yf7923zdojIlbZBRa8T9XikIcY00oFnnM7B9HTLZqRp39oy1yUjQnZZLxm3Ep0QvKs9S9eJlu9tT7YjKSp+cDw3gDDR04C3+IMTIRbMTUKe36dV8xpkzQYOOOpkq6ASNeb4y6COmXdpH5ojKT4H9ZbydKBayArEZKGZkufikox3FXlSUjfBIF7gINtKjatemoz/+BfWNzSfZEXTEbsl1ctXCM0R9hBi7fxummxEQ0naoDfQTF2iFozEt6HT/Xkd7hrwymTWkRTxtSJo9MCn5D+FNZ+wM0Zs5/UrN1vhKRBcwd5t2oHzaE9zj2jjDDatMPQU0lIAtOvxH1U2atCanWk45nRPOTbvhhTaYejAilI6L5SVlDiVBvWRz5m4JssmhzgiUVJwZ+K0q+xYQqCHnCS/Vfjrr7LC6HOKxu5nnGKchZdy++WpagHQGDe6NLH0XDV9YTsC6LPVGwKtcQ6UGxMMHQlCnwYhCzd5tULzpoSFCNsK6cC3QcViGwVDBApfHe/xGKIDtKdv/by9Eq38NpaaQZc+volEHgtpqOBQDkSkNvCiIxBGyHMRl1IhEveFV4h6K5hyh14jRQW/tc05cIrCP/PInmZ2uRCGS3eJHGkmVz0g2/w2EX9QzY1nyJZTaF X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(136003)(366004)(346002)(9686003)(66556008)(66446008)(66476007)(5660300002)(64756008)(4326008)(8936002)(76116006)(8676002)(66946007)(186003)(55016003)(33656002)(52536014)(86362001)(7696005)(53546011)(26005)(6506007)(41300700001)(2906002)(478600001)(71200400001)(38070700005)(83380400001)(122000001)(316002)(54906003)(38100700002)(110136005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6849 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4f4c5b6-69e3-4418-e8a6-08da5fcd5870 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eM/jT2yrkcSxXFcQ1W+Z7ivJhdlXOUkH9k22/m5NlIvsrEAXiYd6f4l7ojiGqUs3Q1G1Gr76NZRpZoW8SyFh94Cycw/QINEXs9yoROWJgxJKRNGg9Lgh34KhHPJ+f5DYnAbSt7RD0qiDIFReDc81xk0y7kJz63C08GtZbEGJPf6e2N9JsJ/Q1nnswgFVw6lSLNTfJ+Btb2J2oB+R4k7hszJz3pbKHuZrEduObLjv3EwAVWuKahwMW02bsQWRuY2S3Qic23wiyfOJGmoBOU0thP+tmXI7BzxLYDEYCFwHevC15MLDxRXAK7kLu+YbTEazsU4M7QGuVe9aRk1BqOyrAg5CTzWF4UmsQ9yI6/rI/sg7kfhyeY6tyxBhfstkd+eo32/QNlnef9si6IGR2W3wZ2Ubd23cyUanZmQX88BN3tIYTTN1tS5duw0WJ9d91BKHQjj4IdTHqknokOX00oWPmTzh34F2NQAk3EACOyjsp3/CDwt0InIu09orNkDtjI1hKru/P8oPrJYvC9adjwx1tAgTbxGlcOtAioYa5TFD0sRx6uinYqzvr+eYckx/etuVK+sZs5gUuiMVTbv0hWIeCs0XOTltRLNhrqIKD8mX66XpX7kEQwiGXVISnQAROIAdk58Xqze8JiZxzZQZ2WxwwbZetoN4O6ZuI0dxwvIT6nVXbP7BwfCuC76eMu/4wmReaQxR6UnlLu8yecKcVvVeUcubTI6fgokAJI0GXf+NQ/g6pW0+x3OC29Xy4NJtUKHXQCqFyuAN6lBrkMkd9jY+HQ3QpAh5biEiUtWEnxs79zxzGiXWjdc6hhFSsyYguOxK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(40470700004)(46966006)(36840700001)(81166007)(8676002)(4326008)(107886003)(82310400005)(6506007)(186003)(2906002)(7696005)(70586007)(33656002)(83380400001)(82740400003)(47076005)(70206006)(336012)(41300700001)(55016003)(356005)(26005)(40480700001)(40460700003)(110136005)(54906003)(36860700001)(478600001)(9686003)(86362001)(53546011)(5660300002)(8936002)(316002)(52536014);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 04:01:29.5481 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e5fd3f23-96a7-4235-02b6-08da5fcd5f30 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2551 Hi Stefano and julien > -----Original Message----- > From: Stefano Stabellini > Sent: Thursday, July 7, 2022 7:53 AM > To: Penny Zheng > Cc: Stefano Stabellini ; Julien Grall ; > xen-devel@lists.xenproject.org; Wei Chen ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest > device tree >=20 > On Mon, 4 Jul 2022, Penny Zheng wrote: > > Hi Stefano and Julien > > > > > -----Original Message----- > > > From: Stefano Stabellini > > > Sent: Saturday, June 25, 2022 5:57 AM > > > To: Julien Grall > > > Cc: Penny Zheng ; > > > xen-devel@lists.xenproject.org; Wei Chen ; > Stefano > > > Stabellini ; Bertrand Marquis > > > ; Volodymyr Babchuk > > > > > > Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in > > > guest device tree > > > > > > On Fri, 24 Jun 2022, Julien Grall wrote: > > > > On 20/06/2022 06:11, Penny Zheng wrote: > > > > > We expose the shared memory to the domU using the "xen,shared- > > > memory-v1" > > > > > reserved-memory binding. See > > > > > Documentation/devicetree/bindings/reserved-memory/xen,shared- > > > memory. > > > > > txt in Linux for the corresponding device tree binding. > > > > > > > > > > To save the cost of re-parsing shared memory device tree > > > > > configuration when creating shared memory nodes in guest device > > > > > tree, this commit adds new field "shm_mem" to store shm-info per > > > > > domain. > > > > > > > > > > For each shared memory region, a range is exposed under the > > > > > /reserved-memory node as a child node. Each range sub-node is > > > > > named xen-shmem@
and has the following properties: > > > > > - compatible: > > > > > compatible =3D "xen,shared-memory-v1" > > > > > - reg: > > > > > the base guest physical address and size of the shared > > > > > memory region > > > > > - xen,id: > > > > > a string that identifies the shared memory region. > > > > > > > > > > Signed-off-by: Penny Zheng > > > > > Reviewed-by: Stefano Stabellini > > > > > --- > > > > > v5 change: > > > > > - no change > > > > > --- > > > > > v4 change: > > > > > - no change > > > > > --- > > > > > v3 change: > > > > > - move field "shm_mem" to kernel_info > > > > > --- > > > > > v2 change: > > > > > - using xzalloc > > > > > - shm_id should be uint8_t > > > > > - make reg a local variable > > > > > - add #address-cells and #size-cells properties > > > > > - fix alignment > > > > > --- > > > > > xen/arch/arm/domain_build.c | 143 > > > +++++++++++++++++++++++++++++- > > > > > xen/arch/arm/include/asm/kernel.h | 1 + > > > > > xen/arch/arm/include/asm/setup.h | 1 + > > > > > 3 files changed, 143 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > > > b/xen/arch/arm/domain_build.c index 1584e6c2ce..4d62440a0e > > > > > 100644 > > > > > --- a/xen/arch/arm/domain_build.c > > > > > +++ b/xen/arch/arm/domain_build.c > > > > > @@ -900,7 +900,22 @@ static int __init > > > > > allocate_shared_memory(struct domain *d, > > > > > return ret; > > > > > } > > > > > -static int __init process_shm(struct domain *d, > > > > > +static int __init append_shm_bank_to_domain(struct kernel_info > *kinfo, > > > > > + paddr_t start, paddr= _t size, > > > > > + u32 shm_id) { > > > > > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > > > > > + return -ENOMEM; > > > > > + > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start =3D start= ; > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size =3D size; > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id =3D > shm_id; > > > > > + kinfo->shm_mem.nr_banks++; > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int __init process_shm(struct domain *d, struct > > > > > +kernel_info *kinfo, > > > > > const struct dt_device_node *node= ) > > > > > { > > > > > struct dt_device_node *shm_node; @@ -971,6 +986,14 @@ > > > > > static int __init process_shm(struct domain *d, > > > > > if ( ret ) > > > > > return ret; > > > > > } > > > > > + > > > > > + /* > > > > > + * Record static shared memory region info for later set= ting > > > > > + * up shm-node in guest device tree. > > > > > + */ > > > > > + ret =3D append_shm_bank_to_domain(kinfo, gbase, psize, > shm_id); > > > > > + if ( ret ) > > > > > + return ret; > > > > > } > > > > > return 0; > > > > > @@ -1301,6 +1324,117 @@ static int __init > make_memory_node(const > > > > > struct domain *d, > > > > > return res; > > > > > } > > > > > +#ifdef CONFIG_STATIC_SHM > > > > > +static int __init make_shm_memory_node(const struct domain *d, > > > > > + void *fdt, > > > > > + int addrcells, int sizece= lls, > > > > > + struct meminfo *mem) > > > > > > > > NIT: AFAICT mem is not changed, so it should be const. > > > > > > > > > +{ > > > > > + unsigned long i =3D 0; > > > > > > > > NIT: This should be "unsigned int" to match the type of nr_banks. > > > > > > > > > + int res =3D 0; > > > > > + > > > > > + if ( mem->nr_banks =3D=3D 0 ) > > > > > + return -ENOENT; > > > > > + > > > > > + /* > > > > > + * For each shared memory region, a range is exposed under > > > > > + * the /reserved-memory node as a child node. Each range > > > > > + sub-node > > > is > > > > > + * named xen-shmem@
. > > > > > + */ > > > > > + dt_dprintk("Create xen-shmem node\n"); > > > > > + > > > > > + for ( ; i < mem->nr_banks; i++ ) > > > > > + { > > > > > + uint64_t start =3D mem->bank[i].start; > > > > > + uint64_t size =3D mem->bank[i].size; > > > > > + uint8_t shm_id =3D mem->bank[i].shm_id; > > > > > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > > > > > + char buf[27]; > > > > > + const char compat[] =3D "xen,shared-memory-v1"; > > > > > + __be32 reg[4]; > > > > > + __be32 *cells; > > > > > + unsigned int len =3D (addrcells + sizecells) * > > > > > + sizeof(__be32); > > > > > + > > > > > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, > > > > > mem->bank[i].start); > > > > > + res =3D fdt_begin_node(fdt, buf); > > > > > + if ( res ) > > > > > + return res; > > > > > + > > > > > + res =3D fdt_property(fdt, "compatible", compat, sizeof(c= ompat)); > > > > > + if ( res ) > > > > > + return res; > > > > > + > > > > > + cells =3D reg; > > > > > + dt_child_set_range(&cells, addrcells, sizecells, start, > > > > > + size); > > > > > + > > > > > + res =3D fdt_property(fdt, "reg", reg, len); > > > > > + if ( res ) > > > > > + return res; > > > > > + > > > > > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"- > >%#"PRIx64"\n", > > > > > + i, start, start + size); > > > > > + > > > > > + res =3D fdt_property_cell(fdt, "xen,id", shm_id); > > > > > > > > Looking at the Linux binding, "xen,id" is meant to be a string. > > > > But here you are writing it as an integer. > > > > > > Good catch! > > > > > > > > > > Given that the Linux binding is already merged, I think the Xen > > > > binding should be changed. > > > > > > We would be compliant with both bindings (xen and linux) just by > > > writing shm_id as string here, but if it is not too difficult we > > > might as well harmonize the two bindings and also define xen,shm-id a= s a > string. > > > > > > On the Xen side, I would suggest to put a clear size limit so that > > > the string is easier to handle. > > > > I've already made the xen,shm-id parsed as a string too, seeing the bel= ow > code: > > " > > prop_id =3D fdt_get_property(fdt, node, "xen,shm-id", NULL); > > if ( !prop_id ) > > return -ENOENT; > > shm_id =3D simple_strtoul(prop_id->data, NULL, 10); > > if ( shm_id >=3D NR_MEM_BANKS ) > > { > > printk("fdt: invalid `xen,shm-id` %lu for static shared memory = node.\n", > > shm_id); > > return -EINVAL; > > } > > " > > The size limit is smaller than 256, just as stated in doc: > > " > > - xen,shm-id > > > > A string that represents the unique identifier of the shared memory > > region. The maximum identifier shall be "xen,shm-id =3D 255". > > " > > Hope this fits what both of you suggested~~~ >=20 > Yes. I think supporting arbitrary strings like "my-shared-mem-1" would be > nice-to-have but I wouldn't make it a hard requirement. >=20 Oh, the example "my-shared-mem-1" really expands my mind, I think I underst= and what you and Julien referred as free form string, which shall not be limite= d to only numeric number... thanks!!! You were suggesting a strict limit on the number of characters, TBH, I have= no clue What the standard is here. Any suggestions? If considering padding, maybe 19? " struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. *= / #ifdef CONFIG_STATIC_SHM char shm_id[19]; unsigned int nr_shm_borrowers; #endif }; " > "255" as a string would match Linux's requirements for xen,id. I will use your example "my-shm-mem-1", I think its better for users to understand, at least for me... From xen-devel-bounces@lists.xenproject.org Thu Jul 07 04:25:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 04:25:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362732.592916 (Exim 4.92) (envelope-from ) id 1o9J50-0007WC-9v; Thu, 07 Jul 2022 04:25:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362732.592916; Thu, 07 Jul 2022 04:25:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9J50-0007W5-5v; Thu, 07 Jul 2022 04:25:30 +0000 Received: by outflank-mailman (input) for mailman id 362732; Thu, 07 Jul 2022 04:25:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9J4y-0007Vv-IG; Thu, 07 Jul 2022 04:25:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9J4y-00046B-E6; Thu, 07 Jul 2022 04:25:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9J4x-0002fu-Ue; Thu, 07 Jul 2022 04:25:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9J4x-0005K9-TK; Thu, 07 Jul 2022 04:25:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=by9OgtFbYbCB+XaqNOyvS3hbk8nBqlVekJcPbFs42n4=; b=s7zxtKMyr40KRo6FBwoMKxsE6B SRTHHZXdDAS+XZSYvtJgV9Gy6SWzySwPjcUJZgiIs5/3SdMQv8hEB4Sn0j2DfNGp51VVJ/wgNkJLD 7De2tegWKUSyHM07lUypO7IvMsRZeHziG4yuyCcXqiG7sbW/3tFHaAFrQeQANcg5WRew=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171537: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9f09069cde34dcd86f5ecf3a3139fd752020812f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Thu, 07 Jul 2022 04:25:27 +0000 flight 171537 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171537/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9f09069cde34dcd86f5ecf3a3139fd752020812f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 18 days Failing since 171280 2022-06-19 15:12:25 Z 17 days 47 attempts Testing same since 171537 2022-07-06 22:42:57 Z 0 days 1 attempts ------------------------------------------------------------ 499 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 20617 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 06:20:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 06:20:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362741.592927 (Exim 4.92) (envelope-from ) id 1o9Kry-0006vo-J6; Thu, 07 Jul 2022 06:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362741.592927; Thu, 07 Jul 2022 06:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Kry-0006vh-G4; Thu, 07 Jul 2022 06:20:10 +0000 Received: by outflank-mailman (input) for mailman id 362741; Thu, 07 Jul 2022 06:20:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Krx-0006vb-Cq for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 06:20:09 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2076.outbound.protection.outlook.com [40.107.104.76]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d856b08b-fdbc-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 08:20:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7573.eurprd04.prod.outlook.com (2603:10a6:20b:29e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 06:20:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 06:20:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d856b08b-fdbc-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I+PNKrqTCz5JvGyuEe/ONSKq+i5Rkdiy6ll3SsWgL0hFk8SF0fqzK5PS3cZy+owJAc0kARN9dT2H402Kfd2X397vtdGav5v6wGGbaQjugzTb1c/WgDDgPzDnWMnDvEtpRUX66GxiGOvF3p4nrHRBKr/5OCKbuRxcFbTP6tJV9XUqDGJCGIQG4aegPVYkpRIELQPTtuqmjZyrmfWCaraMNVr+YcsbUqLQ1lhr6tXIja6LtL+JFkGDcnyijnP7IhupoK2jzMwJSDMpX7a2oRCkIw2seIFH4zMagAmnz/cwiCZG7tXdEWn05eHSPhyq2A2gj98XfNjbkhlMaF4U8smuEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jVWBJU6RNptKvn191Pl9QkBGWV0g1Mhctuqit6iXXtA=; b=lhGwAEiZxzXrnnmk27Ejap2Bv51DguvK+wIMYBm3IPzPySeAAMEPpj7sNHgf8VkVgHNdovh930PdWqnh4Yq3iFtaAH68Zz9sFrS2X9rDuRVSSfWStXFeZaI/4bGf8RoUhjiDOCGDbDMtfZh/ynGoBu0xrPiG1skR8Lifvv9EQbbh4xcfCCSP0+MgX12eejiyLrfyXol4sAgG5MffVPLDDsZSrpTGLFBrtD1EzHWudJO5L/99LPhLNdLP0Ewq+x/2JMEz5VhKF6xzyYQ+ck+SmtptNOUeCCxzQLFnN8HV4cVrok/0IRR0gRtBw0sXRlTJZk6RATPGq21CdEIHJZa/MQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jVWBJU6RNptKvn191Pl9QkBGWV0g1Mhctuqit6iXXtA=; b=HGP5BF4PONXrhqwJSYpUim6ly+AtadNM2OLPLTPEmJDBfHREtb3yGDGzqxt3JI8EXadPJUpUMraZQlBYFNhdX/Klwy9ot8kY1ZwZIifZbmciPsr0QnomzkfB6oD4cUQuARo5FlWnEh6ZSTU7EXjiEeqEvXMzSfofNRX1KMSEJ3Bv95Jw/x9Fapsqy+oQnGQyU5qj0qsZKCYfK6t5za4+ehErqSds0mkHwzwyxZ175VePI+tP9+FAS75LVlYOsj5ka+zlVrZnQnePkL4HuMjHgNab9Bswu6c7Xayl9Cf2ynUc2BEgNqm6jRdU9tNlFLTuRK8wezLZuvSELNGkBUTMZg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <137b94d8-596a-cdc9-b485-0ac854deab11@suse.com> Date: Thu, 7 Jul 2022 08:20:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v7 00/14] IOMMU: superpage support when not sharing pagetables Content-Language: en-US From: Jan Beulich To: Paul Durrant Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> In-Reply-To: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR02CA0002.eurprd02.prod.outlook.com (2603:10a6:20b:6e::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7235e956-ad45-4186-bede-08da5fe0bb1f X-MS-TrafficTypeDiagnostic: AS8PR04MB7573:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YCXQl4nIIdR9cv9OuqaiwkKXvr4X/HRAoVZHLYBtw34HYb2FOowzgrvDSbx4xNqC15eHpzMB5eueeVKOm2YMkO13p4sSSitFPxW5clzk4UOTLU60TvLz2ABSB2k0qDSdCRBJDtyN3vwWams0PTpEAQu/a5QImyK+DOszRosq3HFNGLaLdSWWnDux7cJj85+24bzNqwWHb48Ck598wnyjnvBaCAXjTpDglGwyxlll3x5I5yZ7mGDBY7msLrJWBL/7uX4x2Ib32rvBYQpo0G28lq1JTJvZNd5VIN53F6GhbMJhrfprbqIbPWl8yzgNj1KgPmp1nmytlafapC7m6r++awwuVGAHdCQrgGPtp31t1DZM/dAfMfQvareJRgvDpDftXQliciGwZVi9804H1osIsC/ZcQ6i6821PAIJzMl7eMxuMTExhbSDYtRYuhFoGksgUegdAufvKu+Ld5ebFwqVibA52IM9wBtuBxyrb79GwVUemuMfLHuvsroj8v3WwImXdLDZeOJXMgQQyOPJpxIqOrPN5sJhpVQoe+Jtf2AQPb72J+3agoqDlkUa5fpHdt9MUnzkRGmo6IIJMDa4uXMO51vUYi58YozH/tZj9Sjpm1ryiGLueKHTodqjMOticD2s8HcUHAAMutZL4OuvxXTQEGzpTOT5HosT8E1rwrihPtXpYcY+/78JWO6uFHNFplzS450BN17YBtqs6/rCjDe7jcxRJQYDN43dagNtE4Ruen2m4KcxhSReKSdKduNOx98z2905oVIFXDv84JMcGgUhYKryP+bGd41fE4rbY402s8HUSzPNKvyYP64Et4IiXXyvK3hMm/9OGW/TPnJaZzQmGSOJFb2H/1+w/uC3yov1TgNVQAon3yLwWW9FEj3Eatg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(376002)(39860400002)(366004)(136003)(36756003)(6486002)(6506007)(26005)(2616005)(6512007)(478600001)(186003)(83380400001)(38100700002)(53546011)(966005)(2906002)(31686004)(8676002)(54906003)(86362001)(8936002)(5660300002)(41300700001)(316002)(6916009)(4326008)(66946007)(31696002)(66556008)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Zm11ZmVuZ0dya3VVUW5SaDNzb1VHbVdsNkFLUkszK2UveU1PaXBsOWJ0M0dT?= =?utf-8?B?NkVXTWJCRFdURFJBMGF1TGl4L1BTZ1pTMHkrTXY1RzRSQnRJZStkL1JOWVVI?= =?utf-8?B?d0tMdFJFTVdETDRuUjNzL0tjcTQ3bjdRY29Ea1V3cU8zc1R4bmdQSUhjRGVz?= =?utf-8?B?Mzc4RlBFd3BhdFFFQ25kaHBUVUk3TUtiVGhnZzY1c2dFRkhoT1cxck1nWXpx?= =?utf-8?B?R1k1MFRaREJIbUdlbnRZdklpMXg3NDgzRno2ZURTNFVUc1lFd2JXTzBzNklX?= =?utf-8?B?TkVMQzI2cStCTzBhZHI2UlJCaGxHUnpCODVBa0F6dTNmbHVOaXZtV2txTkcv?= =?utf-8?B?VWVJZ3MvZGV6N1AzZ2hYSjF2QzZwSWJOTnJxdkRrci94UDJoenpobUdYRDgy?= =?utf-8?B?enE3THYzbGdFRDRsQ1pBNnNmZE5oY0hOWVIxQ2s0QkFKMFNwSHo1VVF0ZS9D?= =?utf-8?B?RjI1NUZTUW93QmszTjJmRW1zWW9ORHdMdmtTNitnNlpCdXhEMXJGU2Vrc01w?= =?utf-8?B?TnRuU1JQKzRoZWRRWWhyOW42aU5jN2ZNdTZubG9tZVBSNVdvanBYWHkzSmgz?= =?utf-8?B?eHVraGdRSisxOXVWT0tQQUwyaDc1Vy9jOUtzVWxXbWwvWXF1L1BPbWIreDRC?= =?utf-8?B?MlZ5RWhBZjVTemd0Z3RsWWI1ZlI4WUhRWUxUdTErMFczOGROekU5WTkvWnll?= =?utf-8?B?TGw2MlhQb3QzNVdmcmppYVkxRGVnSFVEYThSdXk4aWFORU4wZWdFMkVuM1No?= =?utf-8?B?ZUxIajlrekh4OG5uZTFVNk82eXJXNk5sZzF5QTNmNXRjM092V3hjT2F4U045?= =?utf-8?B?TUZjTGYrZi9xdDdTdTI2TUFMK1duRGRFOXpFbll6Tlk5ZDg5RjJld0I3ZDFJ?= =?utf-8?B?em52cW9jZml6eng4NkZMNnB1bk1abWgybmJENllGN3VIWkdBanhIcE93YUZ6?= =?utf-8?B?S1pvdlk5VFQ3MnNOWEtXVmN4K3UySXFKOFViUG5XZ0dsc0VjZ3VSWFdWUkFi?= =?utf-8?B?K0FQMk03UFFlWGNIQXdxZE0wYU5LMi9TQUdmS3BKeTM0R3FMVFJTbzRxL3d2?= =?utf-8?B?RUFkQ3ZYSmVYR0FJWlhHYzBpeXJBMDc1Nk5yckdBeVR5cno0M1BlQ2Z1cDJ2?= =?utf-8?B?VkFJd095bmNKZDNaSUQrQlllMkVTMmZUOTlmb2tWTjN6QWt4THZMaU1RelhM?= =?utf-8?B?b1c3c2hIcWFER3RaV09PZ1VSeDl0dlBhRENNeU5pcEQ0ZnVmdTFWYTR0dDRq?= =?utf-8?B?RlhUZjNpaDVCOWNPdUoydGNsbjNLZ250RUZXNllXZDVCM3F2bk16SnlkbkRu?= =?utf-8?B?SSt4S3cxVm1rWjB3QkZWMHdGWkxvamx0MkJMRm1kb25CcENEQzd6aFpJU2ZD?= =?utf-8?B?N3V1bHVHZzNSQlI2c29ITmRVMmlqemRyamdlUEhud1dWZWxNL0k2eURIb0FL?= =?utf-8?B?eHlTTlVwWDdIRmh2Sk90QUsvWU41YjI1b2l4QzRxcU5udjBZQWtEaFFqdkxM?= =?utf-8?B?MTF6VHU2eDFpQWIzWXBCODJ0WmVIdVdJL2piMmJnbGw0c05NTmhvOFlZanRi?= =?utf-8?B?UlcvdytQd3dtRXNRZlBiOEtYYUltZkpLcUpWNDI2N0krSzRDMldZNHM2bzdk?= =?utf-8?B?QTRicnZScmJjNFZOUXhIeC9TRDZZZ3Btdm8xald6N2FsYnYzUUVrVXkzTFlz?= =?utf-8?B?UzRVcnZXdUxZRDlXOXhBYUV3anJmS21iZmZGaU56NEhqYjVEYXFaa2M0K0hh?= =?utf-8?B?ZFJ6MTFBdFFFQ2w3eDA4MUtEdWsrNmNoWU1sVG5uOWt5VkVyNHpJbFlqenBN?= =?utf-8?B?dE5zaWoxUHdBMTEyVzkvclVPMS83czZadFc2Zm53M05HYkVKU0xxNEtzVFhK?= =?utf-8?B?eEF2R3pUNDdWMk1vWmhFeml2VDFjblZ6R2dUWVZWWTBqMUNDSTgvTE9OQXlD?= =?utf-8?B?clVZSDVXRDJ5dzhqdi9sRFhZR3RoRitMcm85ajFVVFlhM3I4enNLb1Z6cXlm?= =?utf-8?B?eGZybjJrQjF0SmxDSTVMMk1kOUNMcS9hTHNqSXJPNmVlZ2VGZXBhNHAxOHUy?= =?utf-8?B?L0x0bEMvQnlEOGN1TmxsSUZ1RDkyck1FRlF3REpYNnptamorWHo4cUFvT1J1?= =?utf-8?Q?lmNvqrwR90OBEvMHDuGaxofJ+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7235e956-ad45-4186-bede-08da5fe0bb1f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 06:20:04.4798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SWuGByRI73gYmEnri1PZQBX7qvdvvAt2KMXu5WeYRzwvhbf85QL+t+P9Q0XFDA8uVHij2jgohvBSEPh174S4HQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7573 On 05.07.2022 14:41, Jan Beulich wrote: > For a long time we've been rather inefficient with IOMMU page table > management when not sharing page tables, i.e. in particular for PV (and > further specifically also for PV Dom0) and AMD (where nowadays we never > share page tables). While up to about 3.5 years ago AMD code had logic > to un-shatter page mappings, that logic was ripped out for being buggy > (XSA-275 plus follow-on). > > This series enables use of large pages in AMD and Intel (VT-d) code; > Arm is presently not in need of any enabling as pagetables are always > shared there. It also augments PV Dom0 creation with suitable explicit > IOMMU mapping calls to facilitate use of large pages there. Depending > on the amount of memory handed to Dom0 this improves booting time > (latency until Dom0 actually starts) quite a bit; subsequent shattering > of some of the large pages may of course consume some of the saved time. > > Known fallout has been spelled out here: > https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html > > See individual patches for details on the v7 changes. > > 01: iommu: add preemption support to iommu_{un,}map() > 02: IOMMU/x86: perform PV Dom0 mappings in batches Paul, without meaning this to be a ping, may I ask whether - with Roger away for the next two months - you could find time to review these first two patches? I think this would then allow the entire series to go in. Thanks, Jan > 03: IOMMU/x86: support freeing of pagetables > 02: IOMMU/x86: new command line option to suppress use of superpage mappings > 03: AMD/IOMMU: allow use of superpage mappings > 04: VT-d: allow use of superpage mappings > 05: x86: introduce helper for recording degree of contiguity in page tables > 06: IOMMU/x86: prefill newly allocate page tables > 07: AMD/IOMMU: free all-empty page tables > 08: VT-d: free all-empty page tables > 09: AMD/IOMMU: replace all-contiguous page tables by superpage mappings > 10: VT-d: replace all-contiguous page tables by superpage mappings > 11: IOMMU/x86: add perf counters for page table splitting / coalescing > 12: VT-d: fold dma_pte_clear_one() into its only caller > > While not directly related (except that making this mode work properly > here was a fair part of the overall work), at this occasion I'd also > like to renew my proposal to make "iommu=dom0-strict" the default going > forward. It already is not only the default, but the only possible mode > for PVH Dom0. > > Jan > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 06:39:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 06:39:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362747.592937 (Exim 4.92) (envelope-from ) id 1o9LA4-0001JM-3P; Thu, 07 Jul 2022 06:38:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362747.592937; Thu, 07 Jul 2022 06:38:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LA4-0001JF-0a; Thu, 07 Jul 2022 06:38:52 +0000 Received: by outflank-mailman (input) for mailman id 362747; Thu, 07 Jul 2022 06:38:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LA2-0001J9-KS for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 06:38:50 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2050.outbound.protection.outlook.com [40.107.21.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75391459-fdbf-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 08:38:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5790.eurprd04.prod.outlook.com (2603:10a6:803:e7::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Thu, 7 Jul 2022 06:38:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 06:38:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75391459-fdbf-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVqooPY1la/VXv31gWYrZTHxT8fwRCF6ukm0HF12mrMRN4beZPj7Qs+X4zmJceUJ7VPFzwVedo6nWUXix6YhLVhNUlDcYoQ7IT2DfU97ekbvzqRCksIGQpCex1pi6xQEgvUbfZg/0K3jdXA4NpxutM8t2HIfc3ZlfDzKuvlLSNhWebacfKdcb+WZvmnxht8U1GUkqmXBHcsVGZdLcyfFuOaoLPvNPIjkVGsh1twXaVYaeGdFkQF8u0/xo7vYfsTtHGHecMdCPXbUFH/an3lenqvP31PTlyNOXKR3QGzPN4L7GrTYpHQuhvU38dDeZBMzuL4XuxCfTKYp2JYLKtt1iA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k8l4Nf8fQ67bEwIAO+a1iTiSd6Jzq1VNu3+xuHiRqxA=; b=SIZicQKRhmS7mZw5aZgll9PXqIgDPwdvC8FnfULNzebu5w69jc5ZUR8RGIbGCUAPBTFKODPd69mA7UHm7p5VexzQREKY+aBjBvB0TEmKu0l78igY9h+SfkXgOfZnL+C+emG/1OdxVF7CYtaP+PMQQl3ccjWibvjfUg4dBVCEfzNXzr+9Qfutt8DHZ1zR1xwwAa3l3nlvmedPNQtAQxR4pxm3McPkIO9EE2+UNpSOgj+ySljwEXf4YSRqKEtBllGKbH6qKS2Ub/mdXGUKbME5MJHNMtpf0fBMnCPWCSrSVH7yX5bDEej+2j2gaA4QqFAfzRCCx6HZwy3b0icDuVto3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k8l4Nf8fQ67bEwIAO+a1iTiSd6Jzq1VNu3+xuHiRqxA=; b=W+Zw5AEgOicnQomNBnVhdLUTUQlpq9PPbHcSSEnBcVnbxlhXDrU3qhQlcjPdWDoXEXaJ4UQDmjqQdqLX5rlmuBhJt/Q4bWk8xbAfZWOuzMntemgQG/XCrvd1IaBeUhGXoUOUFguXVOEgO4jBFHunb8cJxZ5UJPPt5vUyk6q1sNjBKsapeaMKlY9yqssKc0rWtwAGt93N7Kaq7BDBOoOfUk0zHQxCFGI+kK4m8QVD70xsT8/myn50JkYKR4H70YgYHvbcHqZYLRU/nb2Rmg9H1CzK4266pMy+RT5Fp6hIVwUkfjaL22otAeE+p/NBslaUBhoVX45IDqhUPv680xOFAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 7 Jul 2022 08:38:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0009.eurprd07.prod.outlook.com (2603:10a6:20b:46c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e90a53b-a53e-4780-bd70-08da5fe3589b X-MS-TrafficTypeDiagnostic: VI1PR04MB5790:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T0rEg8n6X0RTwHf3cXu5K/IKD/eV5Douibq3m9YtTyjnNtrvugrn2cQ09RbBk8MgQ06txc+nbi98jlYDK+irjZHMD/wQPnjzDoGYqU0ytxg3PlH+2cE8H0fUHGnqEhKp4/0B2pzig93+EQGesqpi8XS3t15+/vk0J7QFs/fOQNzXGhC5DdCRzh/s8Tc1cxQWxz3r8ekT438L3YT1J9hKXkMMMMTgZBUh5KEOr0PccuJYFf57fIk1Tr1hL3XcKZloONQu1wD2lW3ViuVY/B6YboIofSbnH91DEe5I1/CA12CYCNfuGovp78GDmJ2ic9UggWwaosK3TVPUwN6jB3YpHd7RoEPSzh0ceo3RmEshdqaxhqOfXVFXW3QXdI9ZG2bvZQXRMQToYDjgVI7R8YtqOkIacH+ZkxcmpCVz30dnrv0E8dc3y5TxEys+2aisI9ZQqBtLtbyJqPFuDLzyrJIyrCLEIGLDShFFLiGg+8ltnfawZdW7oh3+WEF09bRNOJpN93TaT0ONBvrhyUNKWqyYVL4HVMgQp87OXyO1XuVEfqKS0KvuwFzPUm4cn2YQctzDnmdeMT/6ITAaEl83zUblV/c1mlzmAe8JDMvuzjP2OrJqMo8pGA5lTUB/eX2jPgm1XmxH7TsRYrtcK2jPDRrRVBDKbdYDUiLlzk9gqoGVKu1gZixWAD9fhUXU8vbMxr0Qwc8RuQZL8SipbF1AEc/nW7nNi4m3kAcz9v7OKbU6OQtKrPcVk71sW0HttQeNgFvtaE1WkzPYlbGXk9/lMCTLzSmhjTFOAgfAoebNrGP1Wj7m6bDCaUhJVFJ5K2kqX7ceGacHuoAUafegy7gFJHA8iA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(396003)(366004)(376002)(39860400002)(8936002)(54906003)(86362001)(2906002)(31696002)(26005)(66556008)(8676002)(66946007)(316002)(5660300002)(6512007)(4326008)(6916009)(66476007)(186003)(31686004)(2616005)(478600001)(38100700002)(6486002)(6666004)(53546011)(36756003)(41300700001)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzlOMHhZV29sckdlVXBuRmpjaGgzYWtNdUY1M21UOEhxRS9pVnpKTlQ2cGx0?= =?utf-8?B?cU51RUlrWUF1NG1kTStrVVFUMXozWHBWUnFhSlhRNTBrMno5a2laZ3o1U0dk?= =?utf-8?B?U3pJMkcwbzZkNENrRkVuVTVBZkYwK0ROTDZyU3NNQjN4RU1BbThHQTh2eFl0?= =?utf-8?B?N21PdTlYVjNyZEgxa0t5SlNCSUtWSnJxWjlPNW4wTUczWVd6NUp2RzdQcmYy?= =?utf-8?B?aTJpeWNIQWpSclJtd0g1UmF3Y3gvSVRZb2MvWkJUeDdqRjUzVVdsdTJ3Uk80?= =?utf-8?B?YlAzaHo2VEV1OGYrQi9JcmlIOE5SZFBMRndRaWhtSTRrMVptWEdacVVxbG4x?= =?utf-8?B?Q24xYU1xTXV2RWN5OHpCQmNySGtlcWVzMjdqdDFuUnFOOWczcFFuWElUcFVK?= =?utf-8?B?alJaUWhaMzlIOGpueGlqYzRWTVhOcmhFVWJQcGprYXhDK2l5NXpUYWE5VXhq?= =?utf-8?B?VWpOT3RORWpWTG85dVF2OU9CYW9uY1pkb2dSNmNpWjNZOWhKeElRVG82dTNz?= =?utf-8?B?ZGlGTnU0VVJXUENvTm43RkJDZFdBNVdaYU01MkZ1dGpRUW5KOUhxMjNtMUpN?= =?utf-8?B?cmlQbStjUGt5SFc5a2NaUWgxT29manJrRy9PYjlhU0hwbGpLYTdUcWlSNlF3?= =?utf-8?B?bnJtVS9RamFBTThaSjJiNDdQQkh2dFhsZGpuNjRRZFd3N1lXc3JibWM3bklu?= =?utf-8?B?RzNMajBlb2ltdW4yaDRjS2M2a2dsSno4ckVXK2RYazlCTlRnTU0vais1dXY0?= =?utf-8?B?aWRTb3Ira1k1OUxYR1pQWlltU2M3R1pPaXc1elBYaDhZc0ZOczNhVkhVNER3?= =?utf-8?B?KzhQTysxVDlVU0J0N1dVM0FacktOTlhQWFhCam50S01JZTBRUi8yQ05Jclox?= =?utf-8?B?REhsR0QvLzBzckl2MG5uNHQ5OTFCK0FQQlZPTWVwL2d2MmFPRHRWdUN0cTBB?= =?utf-8?B?SVk3c2dCSWkzVDNiTXd5UFJLWFdTSDVYaVZ5aktwVElmc1IzWlMveTY4YWkz?= =?utf-8?B?YnpiNnhONFI2cWpaTVIzR25FYU9MTnk2VEhzTnBsZFlHVFd5bVQxd3NOL3Fv?= =?utf-8?B?YTRsa1NqU3Q2dEdlOWVPVFVUYWpEQzVIVm5uckx3bStXOWF6V0RBSy9wRWcz?= =?utf-8?B?VFVqWUVJeXU0bFBHcHJUdytoVzhzL0lDOWVSUm91RFZJVC9kMC9pWi9jSXNN?= =?utf-8?B?MXNSU0VQY282Lyt6bmJ6TE5XK2RUTHRTQzV1Qkh2aXBSMGlYWURMUW0zWVNE?= =?utf-8?B?OWkxTkNVRkt2b0NNK0NkdDJMVEJDOFQ5cGxXWTFzblVTVXlBbFRWWDIzZ1V0?= =?utf-8?B?RmEyTmFKbmhHa3VNbEdiaGhPbk1vaDBlNGtWUDBVMWwydzBaYmk2Z1pwMVVC?= =?utf-8?B?SHdzSGtFa2Y2ZUhWcElOOGtEWGN5SWZESFluOTFzRHdzbWhyM0VHK01jUmVQ?= =?utf-8?B?TkFuY3ZOREQ2K2lFS0hFVFpEcW1kcHNaamNadFZFaWduNnpxTXVrY2pQcEx3?= =?utf-8?B?cXcvUTQwQUlWeTRYSTNvb3E1bkMxM3pHbWVza2JCVEtoejlrRjFuSXJ2dFBl?= =?utf-8?B?ckJ4SWpDandWQ3FaMDZVaGE0VDRMRU1OdnVkMzJIUit6aVJmTzVxeTEwcHVJ?= =?utf-8?B?TzRFeUNrWlluR2dLQVR1a1I2Znl0dnl0RndVVVF2alRKTGlIOFZSMGZ6OXpO?= =?utf-8?B?cHVBSHJqenhDWTRMa2t6RU5NQjgxdDREMWhORFBKNENDa0ZNTE1GRHBnaXZJ?= =?utf-8?B?ZjBrR3JLNlkwSHBQZU9yYnJIU1hFOC9lNnVyUERtQnloVFNyVU1ibnZnYk9p?= =?utf-8?B?alROU3d0YWJFdlJISGVGaGhobnczbFVoYjdYa2pkOWtTT3hKVXEvWmdsOVdO?= =?utf-8?B?UldTQnV4ZHRqcTQ0akZCSWtEMGNvSk4wMjZ5bzZEQW4wcU00UW9YRmV2eDBi?= =?utf-8?B?M3BjVDE3OTNkcmw5R3ZyUnBJTFZ2SkY1TXEyckZFZklRSENvU09EYkpzcGZl?= =?utf-8?B?emNhOU5ScHBXTTFPU0ZTSGlkWDgxZHNTSjYwWHJsQ0gyaHNFQ2lEQ0RvVGY3?= =?utf-8?B?OHVNbVVNQlN0WEh1dUtycHNNTVBreVNxVkpXVnlWR0lUNXo1cGJqNEpCUGpS?= =?utf-8?Q?SXro35KzhBwa3Jt01KMVtB+l3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e90a53b-a53e-4780-bd70-08da5fe3589b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 06:38:47.6881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S40zdMHotd/81B+j4BnNjd8SZ3M6E+2s3AK6Lk8t6YkEA+gTC+VBVq/+Ezlp04osrzDojZEa85RTmwsvtOZpdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5790 On 06.07.2022 19:01, Borislav Petkov wrote: > On Wed, Jul 06, 2022 at 08:17:41AM +0200, Jan Beulich wrote: >> Sure, but that alone won't help. > > Well, the MTRR code looks at X86_FEATURE_MTRR. If Xen doesn't expose the > MTRRs, then that bit should be clear in the CPUID the guest sees. > > So in that case, you could test X86_FEATURE_XENPV at the end of > mtrr_bp_init() and not disable PAT if running as a PV guest. Would that > work? > >> There's a beneficial side effect of running through pat_disable(): >> That way pat_init() will bail right away. Without that I'd need to >> further special case things there (as under Xen/PV PAT must not be >> written, only read) > > We have wrmsr_safe for that. Well, right now the pvops hook for Xen swallows #GP anyway (wrongly so imo, but any of my earlier pointing out of that has been left unheard, despite even the code comments there saying "It may be worth changing that"). The point is therefore that after writing PAT, it would need reading back. In which case it feels (slightly) more clean to me to avoid the write attempt in the first place, when we know it's not going to work. >> Any decent hypervisor will allow overriding CPUID, so in principle >> I'd expect any to permit disabling MTRR to leave a guest to use >> the (more modern and less cumbersome) PAT alone. > > So I'm being told that it would be generally beneficial for all kinds of > virtualization solutions to be able to support PAT only, without MTRRs > so it would be interesting to see how ugly it would become to decouple > PAT from MTRRs in Linux... If I may ask - doesn't this mean this patch, in its current shape, is already a (small) step in that direction? In any event what you say doesn't sound to me like a viable (backportable) route to addressing the regression at hand. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 06:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 06:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362753.592948 (Exim 4.92) (envelope-from ) id 1o9LGm-0002il-Ql; Thu, 07 Jul 2022 06:45:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362753.592948; Thu, 07 Jul 2022 06:45:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LGm-0002ie-NY; Thu, 07 Jul 2022 06:45:48 +0000 Received: by outflank-mailman (input) for mailman id 362753; Thu, 07 Jul 2022 06:45:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LGl-0002iU-Em; Thu, 07 Jul 2022 06:45:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LGl-00079i-AD; Thu, 07 Jul 2022 06:45:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LGk-00064V-N5; Thu, 07 Jul 2022 06:45:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9LGk-0007YA-Mc; Thu, 07 Jul 2022 06:45:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eDOj9DKlurmPw0cLvUQryba9TBJOjeJJR5+R39aen+I=; b=ZFZmiZWgTDS0dFD3qBpSofRuRa sh9Aaap4w7E8L6PVnLdwWdh+YNHYQtb7TgqGzFZUh5g276BPyNk3RXdL20CF7KhdiX87Wgrj9ymSb hK/ocRUBs0tHK9su3Fzw9kQHN2ZcQcI0vI3MyCvEPdi3TD1iS5gEpfkCgFv/XZ0vaBuc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171540: all pass - PUSHED X-Osstest-Versions-This: ovmf=f193b945eac58ca379d3d21c77d5550b063580d6 X-Osstest-Versions-That: ovmf=e1eef3a8b01a25e75abf63d15bdc90157a74cba9 From: osstest service owner Date: Thu, 07 Jul 2022 06:45:46 +0000 flight 171540 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171540/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f193b945eac58ca379d3d21c77d5550b063580d6 baseline version: ovmf e1eef3a8b01a25e75abf63d15bdc90157a74cba9 Last test of basis 171446 2022-07-01 17:40:26 Z 5 days Testing same since 171540 2022-07-07 01:10:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kun Qin Kun Qin Kun Qin kuqin Michael Kubacki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e1eef3a8b0..f193b945ea f193b945eac58ca379d3d21c77d5550b063580d6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 07 07:27:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 07:27:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362761.592960 (Exim 4.92) (envelope-from ) id 1o9LvB-0000FM-26; Thu, 07 Jul 2022 07:27:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362761.592960; Thu, 07 Jul 2022 07:27:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9LvA-0000FE-UI; Thu, 07 Jul 2022 07:27:32 +0000 Received: by outflank-mailman (input) for mailman id 362761; Thu, 07 Jul 2022 07:27:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Lv9-0000F8-6N for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 07:27:31 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41fdeb5c-fdc6-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 09:27:29 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id z12so15408524wrq.7 for ; Thu, 07 Jul 2022 00:27:29 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id u23-20020a7bcb17000000b0039aef592ca0sm27595843wmj.35.2022.07.07.00.27.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 00:27:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41fdeb5c-fdc6-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1ql0Om+7fOyjMeo5Zo+X8dbi9gB0ZxyDgS56Zjlj/+o=; b=T6qrn0Gb8Y7vWefjUQRBaKWxuxiaIzM6L3hUYGmHVMZSZUf7gd6qdunsX3UEbp5nIA 15ipcEEzEYfl2hZUmIVITwWqA1c1EU19+qjFCR1VBMPDII7AgoLjaniNcaR/HXeXhibZ WKdWl5Tfa0Bp8WTmevVp79cLi1nFr4FJR66UaPvrK0A+O9LDnVoAXgtO+PqyzYZcd2wh bpGAa1wnbpbikwHtofiweADtBceJelbp2yMFbYK5CKf9D+LrRklosyHerNx1O5Fg5tb8 aswFRgnRjvNIObxs/XGKV+S5FCaDU0/OOPUubZgPgfpWCzjP9NKRqsPJLpY+gLV4M4Z+ X6Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1ql0Om+7fOyjMeo5Zo+X8dbi9gB0ZxyDgS56Zjlj/+o=; b=Efp3QfBfTL/ausdCxPv/9WzipDU41mXUoV2f2L7puYRDKb5CNSKCv5GOokCubLe+Ow EBg5UGPpfgcl3Qq3J87/xrTt1439ZulGOLHjqDgh4Z0T0hrL4KHOWJCoJKFecUIf8sT3 tINyoWC0W6LRGmBIbGTqRMDZN5bLPiUaGwMdRIRNzkoarxT9qaVhcWD5aNlhKA7Psqi/ dyVQjcOSO5EYosDgLIZ2hamm1CPmNZ8f085Pzf27kDDX2V7NH4GGQIoZf4OzsZmQzvPS nkCuh5NzzFJRtVWpPY0NW+BqdtjrlBvxyiD61jr0LtENCSVP0y4SDwfZuLwBhqRR8f4O zl7g== X-Gm-Message-State: AJIora9F0C192FSi1x2UaUVJAG5a7DlcGKKKS80GvV0QiMqBywKHVfc1 YJIqhmK/BxYqPLZh1AoYXdc= X-Google-Smtp-Source: AGRyM1thA8QiMUY9ZVScGtbHAL0Sbjo9lZJWBNtPn2z7E9WvFIPulZJoNXBljMe7WDcrRK7Os/FqbA== X-Received: by 2002:a05:6000:18ad:b0:21b:a24a:1786 with SMTP id b13-20020a05600018ad00b0021ba24a1786mr44003135wri.115.1657178849001; Thu, 07 Jul 2022 00:27:29 -0700 (PDT) Message-ID: Date: Thu, 7 Jul 2022 10:27:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> From: Xenia Ragiadakou In-Reply-To: <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/6/22 11:51, Jan Beulich wrote: > On 06.07.2022 10:43, Xenia Ragiadakou wrote: >> On 7/6/22 10:10, Jan Beulich wrote: >>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>> The function idle_loop() is referenced only in domain.c. >>>> Change its linkage from external to internal by adding the storage-class >>>> specifier static to its definitions. >>>> >>>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>>> attribute to suppress unused-function compiler warning. >>> >>> While I see that Julien has already acked the patch, I'd like to point >>> out that using __used here is somewhat bogus. Imo the better approach >>> is to properly make visible to the compiler that the symbol is used by >>> the asm(), by adding a fake(?) input. >> >> I 'm afraid I do not understand what do you mean by "adding a fake(?) >> input". Can you please elaborate a little on your suggestion? > > Once the asm() in question takes the function as an input, the compiler > will know that the function has a user (unless, of course, it finds a > way to elide the asm() itself). The "fake(?)" was because I'm not deeply > enough into Arm inline assembly to know whether the input could then > also be used as an instruction operand (which imo would be preferable) - > if it can't (e.g. because there's no suitable constraint or operand > modifier), it still can be an input just to inform the compiler. According to the following statement, your approach is the recommended one: "To prevent the compiler from removing global data or functions which are referenced from inline assembly statements, you can: -use __attribute__((used)) with the global data or functions. -pass the reference to global data or functions as operands to inline assembly statements. Arm recommends passing the reference to global data or functions as operands to inline assembly statements so that if the final image does not require the inline assembly statements and the referenced global data or function, then they can be removed." IIUC, you are suggesting to change asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) into asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); This gives, respectively: reset_stack_and_jump(idle_loop); 460: 9100001f mov sp, x0 464: 14000007 b 480 reset_stack_and_jump(idle_loop); 460: 9100001f mov sp, x0 464: 14000000 b 600 With this change, the functions return_to_new_vcpu32 and return_to_new_vcpu64, implemented in assembly and called in the same way as idle_loop(), need to be declared. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jul 07 07:55:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 07:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362768.592970 (Exim 4.92) (envelope-from ) id 1o9MM8-0004nX-A0; Thu, 07 Jul 2022 07:55:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362768.592970; Thu, 07 Jul 2022 07:55:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MM8-0004nQ-7O; Thu, 07 Jul 2022 07:55:24 +0000 Received: by outflank-mailman (input) for mailman id 362768; Thu, 07 Jul 2022 07:55:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MM7-0004nK-Dy for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 07:55:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2055.outbound.protection.outlook.com [40.107.21.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26b143ad-fdca-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 09:55:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0401MB2532.eurprd04.prod.outlook.com (2603:10a6:203:37::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Thu, 7 Jul 2022 07:55:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 07:55:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26b143ad-fdca-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cct7mlQ+fmofmRKmzqcl2c/8V04kDu6xrEXlaakl+Il1NzS6OS360UQRt5qtzF4Z7eIKLtpUJF2wtEKNhEmQZWhDflIK6fcmFKTUqOhYIv4DWnPlzasTbKBRJoBc8+oG5Y6VrmuNhBrFgkHuPM9L9a4qFpyHpKDZD0NAR45CTiUqB+QM0J9iSni34S3bXZCgybl+Q91hnWZpw2F80J63KQj/U06oGTNF0gibxnv70zdg1RoMAVAs53l24q5zPfp9My/5JSm6ohdc28YbqhTvXHrzXRel/n54CRPWotVPBtTeWRm3KiGkPgJk3tpwU5NnA1CdMhpt1scL4ATFGTBtDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vDoXUJYE2L1MXgeg5Vl21Hb74gqxgy51xSJU7VJ02sw=; b=hDTFAUhI/jirQgCyOZF9WS1sMeBwbkujoxX+dA9Tm/wZDh+RpaexWz+PzxsgWz6nck3DBSy11E+3tDbfCbWQ8kI3w56LW50LpkOtpiWdCvu5pr8NsF6dOKn4UioCsrvg7dzzogYzkNZo0hlvSbkQp0aAD0J+juMYkdfNovz1v5YTMWxiy/lG/iJo8JXFpWAMkRWxwEMQ4ZVdZmQHmdToWs4+A0rF8Cr7HBhwTnPVaVlMy4rZeILf6xYoIlssCuPYTbWFW9/Xlp8A997orGdzm/ic3D87EBcQ4AMK3lr2HBGrKbUaHfbgw9LIK/kkf1FaZmyi4JrBbivvQJAIRU/jBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vDoXUJYE2L1MXgeg5Vl21Hb74gqxgy51xSJU7VJ02sw=; b=vkvxyLebAtIKtH7UzJADo2f98j+nBZeAeWZDkAh5/HjR5Rr9+bnXE9vuy2B6vvUlBbzpJ/LOny/WHB4acilGGwb1cseWFm/ULINlZeyk5DGghNi4PzAY9Fsfw4ONN8LirZm/IID41ab39XYoNAg0DUmPzysn4kuOfkywmfmrdwXi7+WFNrN3r0bdfr2JsjxXXZlKaeFJIf0E3oXvtIjLTllOobam6Wx/OvS3MbeeP9+PE51dNiOxBmz6v9qokc5ZjFCHvTFLi64qwqi4bWOzWfiawQAC0tmRPPhyMmRv71whcVDVLhASae77WfcbMH57ArYmkd6q6yNdkDl/9oquBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 7 Jul 2022 09:55:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0011.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:8b::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0b2b5a92-43d5-4a08-668d-08da5fee09cd X-MS-TrafficTypeDiagnostic: AM5PR0401MB2532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i/0JC7Y2rJ07HWNPe2zTOfLD9Zjoc/gQC2QF2w2I8Fah9gBMfgO95e6vSGYluuWGQhB2NT+64EhhRARz7WUrQAPbqeNBoefo2UwDm1tDKWPF1qMXTiS58axKVOWa5ojvZirl4yKI48SCtVfQZ5n9TL/+AOLk0kx2sfb0/hgCR8dIPzayEieL5IqGtjXn7p4+YrsxAjlSGR72LKdfFTGFWkN0X4wOrezKBMRP/YbcZ9NZwYN0HFnPdqk96bNOWukirNohxITn2w4kxgy3X+due8xvHpAsKsYb2gdKvytTjyTPXm2eM2Ntoj/oi+kmxOs1yxpDLsi3qPoiQ05JMPNU2lrfLtFVzu78vPeTDFePSCoePLMiMlc1hg4vnxfxmZLUJKhPu4MZSOiJ7iRJdzWELDoCFETceUyu3ht8fQRQitqd75ZFRNRCj9vtzPKPNGqbRx96QSJ/lUu/qaKqSm83weTcFNmDkv+3Fot2DcmAHCQc5d4ygBJw1BhlgLUMYkwh2ReDgRT55bHJaIVSYpXzM2olXBsWHDlpwQA9puokOnjeJTAAPPFfk8xhh7S51A8bPIy2d304tDJsBszNibg0CXfvMs6yaaBuZqzcMNr0qQZ48mXQXOZOEy1F55gFX5lXkxO58UOlzgirLXEToiEu2QpKoIQ1RVAJiSYzv95XylebxPTIxhPyRsMOz193bNXKy/qhCBN0kMuOIJPlWSgzgpCpdf06PeTgoUNlVDFgnQiKrZW/lHt19VIjyn1HHgfiZsp8d8P2nr2P6qNQPid0kdS+VEpW5vlmHBZhxrpyZwn3vdavu/HDlo8uYJU1RPjhKQPA+P8WS0mQNUddUmshgA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(376002)(39860400002)(366004)(396003)(38100700002)(31696002)(86362001)(478600001)(6486002)(316002)(5660300002)(8936002)(6916009)(54906003)(66476007)(66946007)(4326008)(186003)(66556008)(8676002)(41300700001)(2906002)(83380400001)(6666004)(53546011)(31686004)(6512007)(26005)(2616005)(6506007)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N2NHcjNaN2dDY1dJZW9RS0hpdzdkeGIyRnRYNi9pa25vV2tXWUNOMnExeXdx?= =?utf-8?B?akxHcVpkNnpEWG1CUjVtZWljdDFGbUJSUDNpcXNwWGVwNnJ2S1crdDJvdGVK?= =?utf-8?B?MDJCNERCS3laSFRsT3l6MGVoZWxud2hVcFlQaC9MdHY3SUZxem9ZOXpseTVM?= =?utf-8?B?VVRWUjBpbHV6TFJtNVQ3eExKNi9BYnp5c01rRmJGbm1vRjlzSG5zVWJTVGpB?= =?utf-8?B?NkpzQ3k5ejVTamZvUHJDM0tpKzA4SE83b2gzTGJWWVA1Q1ZFK0l4MXlQWEU0?= =?utf-8?B?WTdwRThReHlnTmcrSEEvTWJ6aUlGQitlT2FpbWVwNlI4Mjk3QnFEQlU5ZWVO?= =?utf-8?B?N1dTSlgxVnA2eUpPYlZZdGJ0c3NRME0rNDdGcHhoSHZXYW93WFZQa0N0YTBa?= =?utf-8?B?TXNxUEhkTlJtdEFMVGh3TUlVMlBuOC9rR0o5S0FaVDg1RGxxMmYwbzZSTzNo?= =?utf-8?B?OUtWc2tLODZaczlhZGk4akZuUXo4azRld0ZEZm40WXFXT2U2QWZvMWJ2amhy?= =?utf-8?B?YUU5RjBNV09Qblg4a2ladmlmWFdZbm4rQzQwaHczWU41UkZFbW9IMU9zZXJn?= =?utf-8?B?OFc1NUo0Q3o2d0w1NnF4U2RzTll5eDVBMFFYcEE0SXBPamVXbWVReWlDR0VB?= =?utf-8?B?c3I1RjBHQVc1TDI4Y0hZVEFyaWtEWERqaDkvU1l2WWVNWFFLZzQ3Z1FqNUVX?= =?utf-8?B?OU54U3BsdHhXMnBiZ1plSUJIb1ZuN3NJcGE1Z3Z0UWVmMzdLamZxMy9FYk96?= =?utf-8?B?TWFwVEJnVUxBUC9sNklES3RIVW5PWjNTemNaNVAraUErVHM3SlVSb2Q0MlEr?= =?utf-8?B?VlppcTZFY2FreFJDZ2VDdEtSN1BrSHg4ZW9QY2ExMVQ3a05NY1RWbHNiUmdM?= =?utf-8?B?RklNTnFTOUwzM1RqMEJOMDAyeVRuaU1Rby9OcU82aloxOHc1OHdtS1ZpWnY5?= =?utf-8?B?RzJGY2JzVEEyNEVOZ0tFWUNyQ2VUOUptRzN0QWlQUmpjNStYVTRVNVpYZkp2?= =?utf-8?B?aHRBaHJYaTM1T0Q1ZkZQY2h2Q1lhTzFjWU1xV1dtRjZJQzJNaG5ScklubEZU?= =?utf-8?B?M3RSTitRTnlYdHNmYnIxaE9uOUF4UG9YSzRnK0oyWUhuc1pUZDF4d3dWdThu?= =?utf-8?B?TUE3NmYzdFBLWlJKMHYyT0hTSEFybEVHeXdZOFk3RSthbHJZOGEyRmF6NCtn?= =?utf-8?B?TkZmKzJCSzZPVTNIN3FuRzFFb09uT1BOQzdBVHI2dHlMSWhnVWl2Q1BGeGQ1?= =?utf-8?B?TGR6OTFIY0J1bHpYS09xSjRIRUNNUnBXdkUyNnBxSVpnSHpVOTRjRmJQdnVV?= =?utf-8?B?N3dhUUxnSGFEVkd6dHZjTzVxU0h5Mno5Zm8wVytUcG5Jak41cHFDd25XdGp3?= =?utf-8?B?cm1xaHpCRzNNcnNIRysyaHZKamxvT2Y1QzNSamZ6VEoxYU5NaHdIYVVuNVJX?= =?utf-8?B?dFRQeXIrVDJlb3kxL0xVLzdZekhDSFovU0xtNmhBeERNTTB4M2VqMmZyaXRZ?= =?utf-8?B?UHNleHE0VG9MYzh0K04wSlZVZ0RSNGh3aVZIRC9IWjkzZGhGSlhLL3RQUjFL?= =?utf-8?B?VXBxcERsT0FSOUZqQVdjeU54VUdXaUVtcVZaWWdQVVdkc244QWV1QjZtbnly?= =?utf-8?B?WXJpeGdTcGlpYnJEODVMTGM5dVlTb1ZNVERWVEZ6enoySndsb2tkTEs4bjhO?= =?utf-8?B?d00rbHRTcEY4dTdNMGZ0bytRTmxjblJoSUVBZncwUXdqZTFCMDlVeTJQVXBD?= =?utf-8?B?WXp0dzVMbDBPcFN6MWg0TzhRRmJtemtaYnVsckpuYy95N1dFSTR4YzlIbHpZ?= =?utf-8?B?VDRKeUllT2Z3ZmRUUG1jbUJnZk8rZWVCYXNsTE10MElTVlhrdnU2QVNUL2V1?= =?utf-8?B?RzE1dFZyU09uOEdUMzJJeTI0TmlQTjhLVE1OQUJjUjlRQzhXdjVzenZDc0NO?= =?utf-8?B?aE1RNnJvdncvUklKSkFrSWVXWGFjT3I0V1dFTDFUREErbU83L1lhQ0FNOVlz?= =?utf-8?B?WHpGUHdzZmRUVWx3MWVxN1oyVlgySjdyeWJZcmg0LzdDWTZBNFlYZ3JDTE1q?= =?utf-8?B?UzJXS1lLMHUzL2VtQ0JwQTdBdGE5OXNLMnVMa0xYcHZ0dHI1T09rcS9UTitw?= =?utf-8?Q?riID+hRdwliZzmiIKxfrTVcao?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b2b5a92-43d5-4a08-668d-08da5fee09cd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 07:55:19.9532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xfF1z/lSBFV+yS6rFk8LJrXTF0lcEdRgjtAQXaqTCBZHnEQhvl+JXjDQZONiECG76eyisCZorjJPk1acnf5JPw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2532 On 07.07.2022 09:27, Xenia Ragiadakou wrote: > On 7/6/22 11:51, Jan Beulich wrote: >> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>> On 7/6/22 10:10, Jan Beulich wrote: >>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>> The function idle_loop() is referenced only in domain.c. >>>>> Change its linkage from external to internal by adding the storage-class >>>>> specifier static to its definitions. >>>>> >>>>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>>>> attribute to suppress unused-function compiler warning. >>>> >>>> While I see that Julien has already acked the patch, I'd like to point >>>> out that using __used here is somewhat bogus. Imo the better approach >>>> is to properly make visible to the compiler that the symbol is used by >>>> the asm(), by adding a fake(?) input. >>> >>> I 'm afraid I do not understand what do you mean by "adding a fake(?) >>> input". Can you please elaborate a little on your suggestion? >> >> Once the asm() in question takes the function as an input, the compiler >> will know that the function has a user (unless, of course, it finds a >> way to elide the asm() itself). The "fake(?)" was because I'm not deeply >> enough into Arm inline assembly to know whether the input could then >> also be used as an instruction operand (which imo would be preferable) - >> if it can't (e.g. because there's no suitable constraint or operand >> modifier), it still can be an input just to inform the compiler. > > According to the following statement, your approach is the recommended one: > "To prevent the compiler from removing global data or functions which > are referenced from inline assembly statements, you can: > -use __attribute__((used)) with the global data or functions. > -pass the reference to global data or functions as operands to inline > assembly statements. > Arm recommends passing the reference to global data or functions as > operands to inline assembly statements so that if the final image does > not require the inline assembly statements and the referenced global > data or function, then they can be removed." > > IIUC, you are suggesting to change > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) > into > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); Yes, except that I can't judge about the "S" constraint. > This gives, respectively: > reset_stack_and_jump(idle_loop); > > 460: 9100001f mov sp, x0 > > 464: 14000007 b 480 > > > reset_stack_and_jump(idle_loop); > > 460: 9100001f mov sp, x0 > > 464: 14000000 b 600 > > > With this change, the functions return_to_new_vcpu32 and > return_to_new_vcpu64, implemented in assembly and called in the same way > as idle_loop(), need to be declared. Which imo is a good thing - these probably shouldn't have lived entirely behind the back of the compiler. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 08:23:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 08:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362777.592981 (Exim 4.92) (envelope-from ) id 1o9Mmw-0001Rk-QJ; Thu, 07 Jul 2022 08:23:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362777.592981; Thu, 07 Jul 2022 08:23:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Mmw-0001Rd-NS; Thu, 07 Jul 2022 08:23:06 +0000 Received: by outflank-mailman (input) for mailman id 362777; Thu, 07 Jul 2022 08:23:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Mmv-0001RX-Ok for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 08:23:05 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04f81043-fdce-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 10:23:03 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6D0FD62016; Thu, 7 Jul 2022 08:23:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF301C3411E; Thu, 7 Jul 2022 08:23:01 +0000 (UTC) Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o9Mmp-005rXS-7E; Thu, 07 Jul 2022 09:22:59 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04f81043-fdce-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657182181; bh=77PtLpTS/qpbww/8J/LGrQtKTBirOJTX8MN8Ui9XQsg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C4XXSYfqBm7jhADxfzqk/6WEI/haJhe/1MyTEVUiYwb5P0Ar3A4NKXEAQujuPspPd s3qSefHxSM6yAycSBOEk1x5rsX41Lz5CXWMfbKx+MFmlkdtWT2//rWeC4JZmK+kuzf ECU/jn91qz2SjvVIYKTSlVgpyAEteSUY53CHGeOdfan/ZYOpV2RhOmIOCcQwf6MG7i sgmXwysrqKOA4mKnZ3tQfGEWbFUHusfDO84IAYjAhD58ooo5Ed5J2OwoavWvff5Afm EAomLwlKGskSsbFGf0ELGfPJoWMt9Y95OsdWqoGMlW85HJC5m/Hz4sRuAeBe6tWwp9 HHg5eNbfeNzNA== Date: Thu, 07 Jul 2022 09:22:26 +0100 Message-ID: <87czehmiwt.wl-maz@kernel.org> From: Marc Zyngier To: Serge Semin Cc: Samuel Holland , Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, kernel test robot Subject: Re: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled In-Reply-To: <20220705135243.ydbwfo4kois64elr@mobilestation> References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-2-samuel@sholland.org> <20220705135243.ydbwfo4kois64elr@mobilestation> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: fancer.lancer@gmail.com, samuel@sholland.org, tglx@linutronix.de, andy.shevchenko@gmail.com, brgl@bgdev.pl, bhelgaas@google.com, boris.ostrovsky@oracle.com, bp@alien8.de, bcm-kernel-feedback-list@broadcom.com, chris@zankel.net, colin.king@intel.com, dave.hansen@linux.intel.com, decui@microsoft.com, f.fainelli@gmail.com, guoren@kernel.org, hpa@zytor.com, haiyangz@microsoft.com, deller@gmx.de, mingo@redhat.com, ink@jurassic.park.msu.ru, James.Bottomley@HansenPartnership.com, jbeulich@suse.com, joro@8bytes.org, jgross@suse.com, Julia.Lawall@inria.fr, kys@microsoft.com, keescook@chromium.org, kw@linux.com, linus.walleij@linaro.org, lpieralisi@kernel.org, mark.rutland@arm.com, mattst88@gmail.com, jcmvbkbc@gmail.com, mheyne@amazon.de, oleksandr_tyshchenko@epam.com, dalias@libc.org, rth@twiddle.net, rikard.falkeborn@gmail.com, robh@kernel.org, linux@armlinux.org.uk, sstabellini@kernel.org, sthemmin@microsoft.com, svens@stackframe.org, tsbogend@alpha.franken.de, wei.liu@ke rnel.org, xuwei5@hisilicon.com, will@kernel.org, ysato@users.sourceforge.jp, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, lkp@intel.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Tue, 05 Jul 2022 14:52:43 +0100, Serge Semin wrote: > > Hi Samuel > > On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote: > > The MIPS GIC irqchip driver may be selected in a uniprocessor > > configuration, but it unconditionally registers an IPI domain. > > > > Limit the part of the driver dealing with IPIs to only be compiled when > > GENERIC_IRQ_IPI is enabled, which corresponds to an SMP configuration. > > Thanks for the patch. Some comment is below. > > > > > Reported-by: kernel test robot > > Signed-off-by: Samuel Holland > > --- > > > > Changes in v3: > > - New patch to fix build errors in uniprocessor MIPS configs > > > > drivers/irqchip/Kconfig | 3 +- > > drivers/irqchip/irq-mips-gic.c | 80 +++++++++++++++++++++++----------- > > 2 files changed, 56 insertions(+), 27 deletions(-) > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > index 1f23a6be7d88..d26a4ff7c99f 100644 > > --- a/drivers/irqchip/Kconfig > > +++ b/drivers/irqchip/Kconfig > > @@ -322,7 +322,8 @@ config KEYSTONE_IRQ > > > > config MIPS_GIC > > bool > > - select GENERIC_IRQ_IPI > > + select GENERIC_IRQ_IPI if SMP > > > + select IRQ_DOMAIN_HIERARCHY > > It seems to me that the IRQ domains hierarchy is supposed to be > created only if IPI is required. At least that's what the MIPS GIC > driver implies. Thus we can go further and CONFIG_IRQ_DOMAIN_HIERARCHY > ifdef-out the gic_irq_domain_alloc() and gic_irq_domain_free() > methods definition together with the initialization: > > static const struct irq_domain_ops gic_irq_domain_ops = { > .xlate = gic_irq_domain_xlate, > +#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > .alloc = gic_irq_domain_alloc, > .free = gic_irq_domain_free, > +#endif > .map = gic_irq_domain_map, > }; > > If the GENERIC_IRQ_IPI config is enabled, CONFIG_IRQ_DOMAIN_HIERARCHY > will be automatically selected (see the config definition in > kernel/irq/Kconfig). If the IRQs hierarchy is needed for some another > functionality like GENERIC_MSI_IRQ_DOMAIN or GPIOs then they will > explicitly enable the IRQ_DOMAIN_HIERARCHY config thus activating the > denoted .alloc and .free methods definitions. > > To sum up you can get rid of the IRQ_DOMAIN_HIERARCHY config > force-select from this patch and make the MIPS GIC driver code a bit > more coherent. > > @Marc, please correct me if were wrong. Either way probably works correctly, but Samuel's approach is more readable IMO. It is far easier to reason about a high-level feature (GENERIC_IRQ_IPI) than an implementation detail (IRQ_DOMAIN_HIERARCHY). If you really want to save a handful of bytes, you can make the callbacks conditional on GENERIC_IRQ_IPI, and be done with it. But this can come as an additional patch. Thanks, M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Thu Jul 07 08:33:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 08:33:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362783.592993 (Exim 4.92) (envelope-from ) id 1o9MxE-0003La-QR; Thu, 07 Jul 2022 08:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362783.592993; Thu, 07 Jul 2022 08:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MxE-0003LT-NA; Thu, 07 Jul 2022 08:33:44 +0000 Received: by outflank-mailman (input) for mailman id 362783; Thu, 07 Jul 2022 08:33:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MxD-0003LJ-BN; Thu, 07 Jul 2022 08:33:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MxD-0001BN-8G; Thu, 07 Jul 2022 08:33:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9MxC-0001Lh-Pn; Thu, 07 Jul 2022 08:33:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9MxC-0001Oj-PJ; Thu, 07 Jul 2022 08:33:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LHtoKSYk5/3i5j3CK3QXGzZlulV5LX+JGN4Ix1YY4AM=; b=gC7ZDrBGapznRR4EYndV5Ihw9T 78x6ZkfKq3seFsIyfRN77RikDyQy9E3HzXLblIBYvK5fHogXvLUiF9SWowKbnC8yApl3Ux8U3DJRv 6yKdNW1qeWW/ycjhjbwvfMME2gshbzmnQ2wgYs2MPHJuDfzht3vB188yY+W9JuYpgOpM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171539: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0e3723005bfea2f70157bf951f3e6be03bbf6e74 X-Osstest-Versions-That: qemuu=180c2f24d5e8eada41e012a3899d29bb695aae06 From: osstest service owner Date: Thu, 07 Jul 2022 08:33:42 +0000 flight 171539 qemu-mainline real [real] flight 171543 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171539/ http://logs.test-lab.xenproject.org/osstest/logs/171543/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 22 guest-start.2 fail pass in 171543-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 171543-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171525 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171525 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171525 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171525 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171525 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171525 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171525 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171525 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171525 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 0e3723005bfea2f70157bf951f3e6be03bbf6e74 baseline version: qemuu 180c2f24d5e8eada41e012a3899d29bb695aae06 Last test of basis 171525 2022-07-06 07:42:30 Z 1 days Testing same since 171539 2022-07-07 01:09:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jason A. Donenfeld Laurent Vivier Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 180c2f24d5..0e3723005b 0e3723005bfea2f70157bf951f3e6be03bbf6e74 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 07 08:40:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 08:40:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362792.593004 (Exim 4.92) (envelope-from ) id 1o9N3S-0004xS-Nr; Thu, 07 Jul 2022 08:40:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362792.593004; Thu, 07 Jul 2022 08:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9N3S-0004xL-Js; Thu, 07 Jul 2022 08:40:10 +0000 Received: by outflank-mailman (input) for mailman id 362792; Thu, 07 Jul 2022 08:40:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9N3S-0004xF-0n for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 08:40:10 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 679b5d6e-fdd0-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 10:40:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DF0926209B; Thu, 7 Jul 2022 08:40:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E19CFC3411E; Thu, 7 Jul 2022 08:40:05 +0000 (UTC) Received: from ip-185-104-136-29.ptr.icomera.net ([185.104.136.29] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o9N3L-005rnz-LP; Thu, 07 Jul 2022 09:40:03 +0100 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 679b5d6e-fdd0-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657183206; bh=WbGmo8M7SuEpA4hho4LukBL6BvfNcnRlmWQ1qO9HJ/U=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=uLIozQmEuSEh/XitGSDU3I1WWg/wxHMYC8XcC0CKDSDzcPTnDKZ0WJpx/VEqUIrA6 90D1f2r+lQ/rkAoV0TsA7oITj6H3B4i9g/nqgpiUDGl1GBu9VW5UjrTUzUDkFxOd3t R011UxxdpHW1T1R9fwf8PvtZV61+cE8woR4NEOXyGsg98KLqjAIolLU8cqYo39f3uD 797WFWDXG+i4pUi5B49w4dAlDdo9l/by+B+rEyxEBVcat8WMWleVU9h22Q2v2qbO/H sZsFgrBRKSO1tpk8gVBtKIl4XC7u0rzO2ivKAc+YeTliCPwcnfyMVDLl7P8QP2Dxjk hWtBucMBog50Q== Date: Thu, 07 Jul 2022 09:39:58 +0100 Message-ID: <87bku1mi3l.wl-maz@kernel.org> From: Marc Zyngier To: Oleksandr Cc: Samuel Holland , Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 6/8] genirq: Add and use an irq_data_update_affinity helper In-Reply-To: References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-7-samuel@sholland.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.104.136.29 X-SA-Exim-Rcpt-To: olekstysh@gmail.com, samuel@sholland.org, tglx@linutronix.de, andy.shevchenko@gmail.com, brgl@bgdev.pl, bhelgaas@google.com, boris.ostrovsky@oracle.com, bp@alien8.de, bcm-kernel-feedback-list@broadcom.com, chris@zankel.net, colin.king@intel.com, dave.hansen@linux.intel.com, decui@microsoft.com, f.fainelli@gmail.com, guoren@kernel.org, hpa@zytor.com, haiyangz@microsoft.com, deller@gmx.de, mingo@redhat.com, ink@jurassic.park.msu.ru, James.Bottomley@HansenPartnership.com, jbeulich@suse.com, joro@8bytes.org, jgross@suse.com, Julia.Lawall@inria.fr, kys@microsoft.com, keescook@chromium.org, kw@linux.com, linus.walleij@linaro.org, lpieralisi@kernel.org, mark.rutland@arm.com, mattst88@gmail.com, jcmvbkbc@gmail.com, mheyne@amazon.de, oleksandr_tyshchenko@epam.com, dalias@libc.org, rth@twiddle.net, rikard.falkeborn@gmail.com, robh@kernel.org, linux@armlinux.org.uk, fancer.lancer@gmail.com, sstabellini@kernel.org, sthemmin@microsoft.com, svens@stackframe.org, tsbogend@alpha.f ranken.de, wei.liu@kernel.org, xuwei5@hisilicon.com, will@kernel.org, ysato@users.sourceforge.jp, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Sun, 03 Jul 2022 16:22:03 +0100, Oleksandr wrote: > > > On 01.07.22 23:00, Samuel Holland wrote: > > > Hello Samuel > > > Some architectures and irqchip drivers modify the cpumask returned by > > irq_data_get_affinity_mask, usually by copying in to it. This is > > problematic for uniprocessor configurations, where the affinity mask > > should be constant, as it is known at compile time. > > > > Add and use a setter for the affinity mask, following the pattern of > > irq_data_update_effective_affinity. This allows the getter function to > > return a const cpumask pointer. > > > > Signed-off-by: Samuel Holland > > --- > > > > Changes in v3: > > - New patch to introduce irq_data_update_affinity > > > > arch/alpha/kernel/irq.c | 2 +- > > arch/ia64/kernel/iosapic.c | 2 +- > > arch/ia64/kernel/irq.c | 4 ++-- > > arch/ia64/kernel/msi_ia64.c | 4 ++-- > > arch/parisc/kernel/irq.c | 2 +- > > drivers/irqchip/irq-bcm6345-l1.c | 4 ++-- > > drivers/parisc/iosapic.c | 2 +- > > drivers/sh/intc/chip.c | 2 +- > > drivers/xen/events/events_base.c | 7 ++++--- > > include/linux/irq.h | 6 ++++++ > > 10 files changed, 21 insertions(+), 14 deletions(-) > > > > diff --git a/arch/alpha/kernel/irq.c b/arch/alpha/kernel/irq.c > > index f6d2946edbd2..15f2effd6baf 100644 > > --- a/arch/alpha/kernel/irq.c > > +++ b/arch/alpha/kernel/irq.c > > @@ -60,7 +60,7 @@ int irq_select_affinity(unsigned int irq) > > cpu = (cpu < (NR_CPUS-1) ? cpu + 1 : 0); > > last_cpu = cpu; > > - cpumask_copy(irq_data_get_affinity_mask(data), > > cpumask_of(cpu)); > > + irq_data_update_affinity(data, cpumask_of(cpu)); > > chip->irq_set_affinity(data, cpumask_of(cpu), false); > > return 0; > > } > > diff --git a/arch/ia64/kernel/iosapic.c b/arch/ia64/kernel/iosapic.c > > index 35adcf89035a..99300850abc1 100644 > > --- a/arch/ia64/kernel/iosapic.c > > +++ b/arch/ia64/kernel/iosapic.c > > @@ -834,7 +834,7 @@ iosapic_unregister_intr (unsigned int gsi) > > if (iosapic_intr_info[irq].count == 0) { > > #ifdef CONFIG_SMP > > /* Clear affinity */ > > - cpumask_setall(irq_get_affinity_mask(irq)); > > + irq_data_update_affinity(irq_get_irq_data(irq), cpu_all_mask); > > #endif > > /* Clear the interrupt information */ > > iosapic_intr_info[irq].dest = 0; > > diff --git a/arch/ia64/kernel/irq.c b/arch/ia64/kernel/irq.c > > index ecef17c7c35b..275b9ea58c64 100644 > > --- a/arch/ia64/kernel/irq.c > > +++ b/arch/ia64/kernel/irq.c > > @@ -57,8 +57,8 @@ static char irq_redir [NR_IRQS]; // = { [0 ... NR_IRQS-1] = 1 }; > > void set_irq_affinity_info (unsigned int irq, int hwid, int redir) > > { > > if (irq < NR_IRQS) { > > - cpumask_copy(irq_get_affinity_mask(irq), > > - cpumask_of(cpu_logical_id(hwid))); > > + irq_data_update_affinity(irq_get_irq_data(irq), > > + cpumask_of(cpu_logical_id(hwid))); > > irq_redir[irq] = (char) (redir & 0xff); > > } > > } > > diff --git a/arch/ia64/kernel/msi_ia64.c b/arch/ia64/kernel/msi_ia64.c > > index df5c28f252e3..025e5133c860 100644 > > --- a/arch/ia64/kernel/msi_ia64.c > > +++ b/arch/ia64/kernel/msi_ia64.c > > @@ -37,7 +37,7 @@ static int ia64_set_msi_irq_affinity(struct irq_data *idata, > > msg.data = data; > > pci_write_msi_msg(irq, &msg); > > - cpumask_copy(irq_data_get_affinity_mask(idata), cpumask_of(cpu)); > > + irq_data_update_affinity(idata, cpumask_of(cpu)); > > return 0; > > } > > @@ -132,7 +132,7 @@ static int dmar_msi_set_affinity(struct irq_data *data, > > msg.address_lo |= MSI_ADDR_DEST_ID_CPU(cpu_physical_id(cpu)); > > dmar_msi_write(irq, &msg); > > - cpumask_copy(irq_data_get_affinity_mask(data), mask); > > + irq_data_update_affinity(data, mask); > > return 0; > > } > > diff --git a/arch/parisc/kernel/irq.c b/arch/parisc/kernel/irq.c > > index 0fe2d79fb123..5ebb1771b4ab 100644 > > --- a/arch/parisc/kernel/irq.c > > +++ b/arch/parisc/kernel/irq.c > > @@ -315,7 +315,7 @@ unsigned long txn_affinity_addr(unsigned int irq, int cpu) > > { > > #ifdef CONFIG_SMP > > struct irq_data *d = irq_get_irq_data(irq); > > - cpumask_copy(irq_data_get_affinity_mask(d), cpumask_of(cpu)); > > + irq_data_update_affinity(d, cpumask_of(cpu)); > > #endif > > return per_cpu(cpu_data, cpu).txn_addr; > > diff --git a/drivers/irqchip/irq-bcm6345-l1.c b/drivers/irqchip/irq-bcm6345-l1.c > > index 142a7431745f..6899e37810a8 100644 > > --- a/drivers/irqchip/irq-bcm6345-l1.c > > +++ b/drivers/irqchip/irq-bcm6345-l1.c > > @@ -216,11 +216,11 @@ static int bcm6345_l1_set_affinity(struct irq_data *d, > > enabled = intc->cpus[old_cpu]->enable_cache[word] & mask; > > if (enabled) > > __bcm6345_l1_mask(d); > > - cpumask_copy(irq_data_get_affinity_mask(d), dest); > > + irq_data_update_affinity(d, dest); > > if (enabled) > > __bcm6345_l1_unmask(d); > > } else { > > - cpumask_copy(irq_data_get_affinity_mask(d), dest); > > + irq_data_update_affinity(d, dest); > > } > > raw_spin_unlock_irqrestore(&intc->lock, flags); > > diff --git a/drivers/parisc/iosapic.c b/drivers/parisc/iosapic.c > > index 8a3b0c3a1e92..3a8c98615634 100644 > > --- a/drivers/parisc/iosapic.c > > +++ b/drivers/parisc/iosapic.c > > @@ -677,7 +677,7 @@ static int iosapic_set_affinity_irq(struct irq_data *d, > > if (dest_cpu < 0) > > return -1; > > - cpumask_copy(irq_data_get_affinity_mask(d), > > cpumask_of(dest_cpu)); > > + irq_data_update_affinity(d, cpumask_of(dest_cpu)); > > vi->txn_addr = txn_affinity_addr(d->irq, dest_cpu); > > spin_lock_irqsave(&iosapic_lock, flags); > > diff --git a/drivers/sh/intc/chip.c b/drivers/sh/intc/chip.c > > index 358df7510186..828d81e02b37 100644 > > --- a/drivers/sh/intc/chip.c > > +++ b/drivers/sh/intc/chip.c > > @@ -72,7 +72,7 @@ static int intc_set_affinity(struct irq_data *data, > > if (!cpumask_intersects(cpumask, cpu_online_mask)) > > return -1; > > - cpumask_copy(irq_data_get_affinity_mask(data), cpumask); > > + irq_data_update_affinity(data, cpumask); > > return IRQ_SET_MASK_OK_NOCOPY; > > } > > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > > index 46d9295d9a6e..5e8321f43cbd 100644 > > --- a/drivers/xen/events/events_base.c > > +++ b/drivers/xen/events/events_base.c > > @@ -528,9 +528,10 @@ static void bind_evtchn_to_cpu(evtchn_port_t evtchn, unsigned int cpu, > > BUG_ON(irq == -1); > > if (IS_ENABLED(CONFIG_SMP) && force_affinity) { > > - cpumask_copy(irq_get_affinity_mask(irq), cpumask_of(cpu)); > > - cpumask_copy(irq_get_effective_affinity_mask(irq), > > - cpumask_of(cpu)); > > + struct irq_data *data = irq_get_irq_data(irq); > > + > > + irq_data_update_affinity(data, cpumask_of(cpu)); > > + irq_data_update_effective_affinity(data, cpumask_of(cpu)); > > } > > > > Nit: commit description says about reusing irq_data_update_affinity() > only, but here we also reuse irq_data_update_effective_affinity(), so > I would mention that in the description. > > Reviewed-by: Oleksandr Tyshchenko # Xen bits b4 shouts because of your email address: NOTE: some trailers ignored due to from/email mismatches: ! Trailer: Reviewed-by: Oleksandr Tyshchenko # Xen bits Msg From: Oleksandr I've used the tag anyway, but you may want to fix your setup in the future. Thanks, M. -- Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362800.593026 (Exim 4.92) (envelope-from ) id 1o9Nj3-00032z-8h; Thu, 07 Jul 2022 09:23:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362800.593026; Thu, 07 Jul 2022 09:23:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj3-00032o-57; Thu, 07 Jul 2022 09:23:09 +0000 Received: by outflank-mailman (input) for mailman id 362800; Thu, 07 Jul 2022 09:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj1-00032J-CI for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:07 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 682b3be6-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:05 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BBEA81063; Thu, 7 Jul 2022 02:23:05 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5CB9D3F792; Thu, 7 Jul 2022 02:23:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 682b3be6-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v8 1/9] xen/arm: rename PGC_reserved to PGC_static Date: Thu, 7 Jul 2022 17:22:36 +0800 Message-Id: <20220707092244.485936-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PGC_reserved could be ambiguous, and we have to tell what the pages are reserved for, so this commit intends to rename PGC_reserved to PGC_static, which clearly indicates the page is reserved for static memory. Signed-off-by: Penny Zheng Acked-by: Jan Beulich --- v8 changes - no change --- v7 changes: - no change --- v6 changes: - rename PGC_staticmem to PGC_static --- v5 changes: - new commit --- xen/arch/arm/include/asm/mm.h | 6 +++--- xen/common/page_alloc.c | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index c4bc3cd1e5..8b2481c1f3 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,9 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is reserved */ -#define _PGC_reserved PG_shift(3) -#define PGC_reserved PG_mask(1, 3) + /* Page is static memory */ +#define _PGC_static PG_shift(3) +#define PGC_static PG_mask(1, 3) /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index fe0e15429a..ed56379b96 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,8 +151,8 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_reserved -#define PGC_reserved 0 +#ifndef PGC_static +#define PGC_static 0 #endif /* @@ -2286,7 +2286,7 @@ int assign_pages( for ( i = 0; i < nr; i++ ) { - ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_reserved))); + ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static))); if ( pg[i].count_info & PGC_extra ) extra_pages++; } @@ -2346,7 +2346,7 @@ int assign_pages( page_set_owner(&pg[i], d); smp_wmb(); /* Domain pointer must be visible before updating refcnt. */ pg[i].count_info = - (pg[i].count_info & (PGC_extra | PGC_reserved)) | PGC_allocated | 1; + (pg[i].count_info & (PGC_extra | PGC_static)) | PGC_allocated | 1; page_list_add_tail(&pg[i], page_to_list(d, &pg[i])); } @@ -2652,8 +2652,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_reserved. */ - pg[i].count_info |= PGC_reserved; + /* In case initializing page of static memory, mark it PGC_static. */ + pg[i].count_info |= PGC_static; } } @@ -2682,8 +2682,8 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, for ( i = 0; i < nr_mfns; i++ ) { - /* The page should be reserved and not yet allocated. */ - if ( pg[i].count_info != (PGC_state_free | PGC_reserved) ) + /* The page should be static and not yet allocated. */ + if ( pg[i].count_info != (PGC_state_free | PGC_static) ) { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", @@ -2697,10 +2697,10 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, &tlbflush_timestamp); /* - * Preserve flag PGC_reserved and change page state + * Preserve flag PGC_static and change page state * to PGC_state_inuse. */ - pg[i].count_info = PGC_reserved | PGC_state_inuse; + pg[i].count_info = PGC_static | PGC_state_inuse; /* Initialise fields which have other uses for free pages. */ pg[i].u.inuse.type_info = 0; page_set_owner(&pg[i], NULL); @@ -2722,7 +2722,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, out_err: while ( i-- ) - pg[i].count_info = PGC_reserved | PGC_state_free; + pg[i].count_info = PGC_static | PGC_state_free; spin_unlock(&heap_lock); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362799.593015 (Exim 4.92) (envelope-from ) id 1o9Niz-0002n5-0P; Thu, 07 Jul 2022 09:23:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362799.593015; Thu, 07 Jul 2022 09:23:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Niy-0002my-Tb; Thu, 07 Jul 2022 09:23:04 +0000 Received: by outflank-mailman (input) for mailman id 362799; Thu, 07 Jul 2022 09:23:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Niy-0002ms-1E for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:04 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 65a75539-fdd6-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:23:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2B3D11063; Thu, 7 Jul 2022 02:23:01 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4DC6C3F792; Thu, 7 Jul 2022 02:22:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65a75539-fdd6-11ec-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v8 0/9] populate/unpopulate memory when domain on static allocation Date: Thu, 7 Jul 2022 17:22:35 +0800 Message-Id: <20220707092244.485936-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so they shall never go back to heap allocator. This patch serie intends to fix this issue, by adding pages on the new list resv_page_list after having taken them off the "normal" list, when unpopulating memory, and retrieving pages from resv page list(resv_page_list) when populating memory. --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY, as it is used outside page_alloc.c - #ifdef-ary around is_domain_using_staticmem() is not needed anymore - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore - add page on the rsv_page_list *after* it has been freed - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - rename PGC_staticmem to PGC_static - remove #ifdef aroud function declaration - use domain instead of sub-systems - move non-zero is_domain_using_staticmem() from ARM header to common header - move PGC_static !CONFIG_STATIC_MEMORY definition to common header - drop the lock before returning --- v5 changes: - introduce three new commits - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes: - commit message refinement - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" - change name from "is_domain_static()" to "is_domain_using_staticmem" - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. - move #ifndef is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - change name from "is_domain_on_static_allocation" to "is_domain_static()" - put reserved pages on resv_page_list after having taken them off the "normal" list - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 - fix coding style Penny Zheng (9): xen/arm: rename PGC_reserved to PGC_static xen: do not free reserved memory into heap xen: update SUPPORT.md for static allocation xen: do not merge reserved pages in free_heap_pages() xen: add field "flags" to cover all internal CDF_XXX xen/arm: introduce CDF_staticmem xen/arm: unpopulate memory when domain is static xen: introduce prepare_staticmem_pages xen: retrieve reserved pages on populate_physmap SUPPORT.md | 7 ++ xen/arch/arm/domain.c | 2 - xen/arch/arm/domain_build.c | 5 +- xen/arch/arm/include/asm/domain.h | 3 +- xen/arch/arm/include/asm/mm.h | 8 +- xen/arch/arm/mm.c | 2 + xen/common/domain.c | 7 ++ xen/common/memory.c | 23 ++++ xen/common/page_alloc.c | 190 ++++++++++++++++++++++-------- xen/include/xen/domain.h | 8 ++ xen/include/xen/mm.h | 12 +- xen/include/xen/sched.h | 6 + 12 files changed, 215 insertions(+), 58 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362801.593036 (Exim 4.92) (envelope-from ) id 1o9Nj7-0003Ls-G2; Thu, 07 Jul 2022 09:23:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362801.593036; Thu, 07 Jul 2022 09:23:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj7-0003Lf-DB; Thu, 07 Jul 2022 09:23:13 +0000 Received: by outflank-mailman (input) for mailman id 362801; Thu, 07 Jul 2022 09:23:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj5-00032J-GI for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:11 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6abb262f-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:10 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A1881063; Thu, 7 Jul 2022 02:23:10 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E85133F792; Thu, 7 Jul 2022 02:23:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6abb262f-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v8 2/9] xen: do not free reserved memory into heap Date: Thu, 7 Jul 2022 17:22:37 +0800 Message-Id: <20220707092244.485936-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. This commit introduces a new helper free_domstatic_page to free static page in runtime, and free_staticmem_pages will be called by it in runtime, so let's drop the __init flag. Signed-off-by: Penny Zheng --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY in xen/mm.h, as it is used outside page_alloc.c --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages --- v6 changes: - adapt to PGC_static - remove #ifdef aroud function declaration --- v5 changes: - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h --- v4 changes: - no changes --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - fix the indentation --- v2 changes: - new commit --- --- xen/arch/arm/include/asm/mm.h | 4 ++- xen/arch/arm/mm.c | 2 ++ xen/common/page_alloc.c | 51 ++++++++++++++++++++++++++++++----- xen/include/xen/mm.h | 7 +++-- 4 files changed, 54 insertions(+), 10 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 8b2481c1f3..f1640bbda4 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,11 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is static memory */ +#ifdef CONFIG_STATIC_MEMORY +/* Page is static memory */ #define _PGC_static PG_shift(3) #define PGC_static PG_mask(1, 3) +#endif /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 009b8cd9ef..a3bc6d7a24 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1622,6 +1622,8 @@ void put_page(struct page_info *page) if ( unlikely((nx & PGC_count_mask) == 0) ) { + if ( unlikely(nx & PGC_static) ) + free_domstatic_page(page); free_domheap_page(page); } } diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index ed56379b96..9a80ca10fa 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,10 +151,6 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_static -#define PGC_static 0 -#endif - /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -2636,12 +2632,14 @@ struct domain *get_pg_owner(domid_t domid) #ifdef CONFIG_STATIC_MEMORY /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; + spin_lock(&heap_lock); + for ( i = 0; i < nr_mfns; i++ ) { mark_page_free(&pg[i], mfn_add(mfn, i)); @@ -2652,9 +2650,48 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_static. */ pg[i].count_info |= PGC_static; } + + spin_unlock(&heap_lock); +} + +void free_domstatic_page(struct page_info *page) +{ + struct domain *d = page_get_owner(page); + bool drop_dom_ref, need_scrub; + + ASSERT_ALLOC_CONTEXT(); + + if ( likely(d) ) + { + /* NB. May recursively lock from relinquish_memory(). */ + spin_lock_recursive(&d->page_alloc_lock); + + arch_free_heap_page(d, page); + + /* + * Normally we expect a domain to clear pages before freeing them, + * if it cares about the secrecy of their contents. However, after + * a domain has died we assume responsibility for erasure. We do + * scrub regardless if option scrub_domheap is set. + */ + need_scrub = d->is_dying || scrub_debug || opt_scrub_domheap; + + drop_dom_ref = !domain_adjust_tot_pages(d, -1); + + spin_unlock_recursive(&d->page_alloc_lock); + } + else + { + drop_dom_ref = false; + need_scrub = true; + } + + free_staticmem_pages(page, 1, need_scrub); + + if ( drop_dom_ref ) + put_domain(d); } /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3be754da92..f1a7d5c991 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,13 +85,12 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) -#ifdef CONFIG_STATIC_MEMORY /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +void free_domstatic_page(struct page_info *page); int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); -#endif /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( @@ -212,6 +211,10 @@ extern struct domain *dom_cow; #include +#ifndef PGC_static +#define PGC_static 0 +#endif + static inline bool is_special_page(const struct page_info *page) { return is_xen_heap_page(page) || (page->count_info & PGC_extra); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362802.593048 (Exim 4.92) (envelope-from ) id 1o9Nj9-0003ed-Tn; Thu, 07 Jul 2022 09:23:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362802.593048; Thu, 07 Jul 2022 09:23:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj9-0003eW-QN; Thu, 07 Jul 2022 09:23:15 +0000 Received: by outflank-mailman (input) for mailman id 362802; Thu, 07 Jul 2022 09:23:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nj8-0002ms-Qg for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:14 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6d2b33af-fdd6-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:23:14 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DBBA7106F; Thu, 7 Jul 2022 02:23:13 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 4BDF13F792; Thu, 7 Jul 2022 02:23:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d2b33af-fdd6-11ec-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v8 3/9] xen: update SUPPORT.md for static allocation Date: Thu, 7 Jul 2022 17:22:38 +0800 Message-Id: <20220707092244.485936-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SUPPORT.md doesn't seem to explicitly say whether static memory is supported, so this commit updates SUPPORT.md to add feature static allocation tech preview for now. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - use domain instead of sub-systems --- v5 changes: - new commit --- SUPPORT.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 70e98964cb..8e040d1c1e 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -286,6 +286,13 @@ to boot with memory < maxmem. Status, x86 HVM: Supported +### Static Allocation + +Static allocation refers to domains for which memory areas are +pre-defined by configuration using physical address ranges. + + Status, ARM: Tech Preview + ### Memory Sharing Allow sharing of identical pages between guests -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362804.593059 (Exim 4.92) (envelope-from ) id 1o9NjF-00043U-7E; Thu, 07 Jul 2022 09:23:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362804.593059; Thu, 07 Jul 2022 09:23:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjF-00043D-2T; Thu, 07 Jul 2022 09:23:21 +0000 Received: by outflank-mailman (input) for mailman id 362804; Thu, 07 Jul 2022 09:23:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjD-00032J-TR for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:19 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 6f575f0c-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:17 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E2DAD113E; Thu, 7 Jul 2022 02:23:17 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 10FB73F792; Thu, 7 Jul 2022 02:23:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f575f0c-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , Penny Zheng Subject: [PATCH v8 4/9] xen: do not merge reserved pages in free_heap_pages() Date: Thu, 7 Jul 2022 17:22:39 +0800 Message-Id: <20220707092244.485936-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The code in free_heap_pages() will try to merge pages with the successor/predecessor if pages are suitably aligned. So if the pages reserved are right next to the pages given to the heap allocator, free_heap_pages() will merge them, and give the reserved pages to heap allocator accidently as a result. So in order to avoid the above scenario, this commit updates free_heap_pages() to check whether the predecessor and/or successor has PGC_reserved set, when trying to merge the about-to-be-freed chunk with the predecessor and/or successor. Suggested-by: Julien Grall Signed-off-by: Penny Zheng Reviewed-by: Jan Beulich Reviewed-by: Julien Grall --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - adapt to PGC_static --- v5 changes: - change PGC_reserved to adapt to PGC_staticmem --- v4 changes: - no changes --- v3 changes: - no changes --- v2 changes: - new commit --- xen/common/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 9a80ca10fa..3260490688 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1475,6 +1475,7 @@ static void free_heap_pages( /* Merge with predecessor block? */ if ( !mfn_valid(page_to_mfn(predecessor)) || !page_state_is(predecessor, free) || + (predecessor->count_info & PGC_static) || (PFN_ORDER(predecessor) != order) || (phys_to_nid(page_to_maddr(predecessor)) != node) ) break; @@ -1498,6 +1499,7 @@ static void free_heap_pages( /* Merge with successor block? */ if ( !mfn_valid(page_to_mfn(successor)) || !page_state_is(successor, free) || + (successor->count_info & PGC_static) || (PFN_ORDER(successor) != order) || (phys_to_nid(page_to_maddr(successor)) != node) ) break; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362807.593070 (Exim 4.92) (envelope-from ) id 1o9NjJ-0004T4-E5; Thu, 07 Jul 2022 09:23:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362807.593070; Thu, 07 Jul 2022 09:23:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjJ-0004Sv-Au; Thu, 07 Jul 2022 09:23:25 +0000 Received: by outflank-mailman (input) for mailman id 362807; Thu, 07 Jul 2022 09:23:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjH-00032J-Ve for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:24 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7243478b-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:22 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA6C91063; Thu, 7 Jul 2022 02:23:22 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1E64C3F792; Thu, 7 Jul 2022 02:23:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7243478b-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v8 5/9] xen: add field "flags" to cover all internal CDF_XXX Date: Thu, 7 Jul 2022 17:22:40 +0800 Message-Id: <20220707092244.485936-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - no change --- v5 changes: - no change --- v4 changes: - no change --- v3 changes: - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - fix coding style --- xen/arch/arm/domain.c | 2 -- xen/arch/arm/include/asm/domain.h | 3 +-- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 +++ 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b5..4722988ee7 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d, ioreq_domain_init(d); #endif - d->arch.directmap = flags & CDF_directmap; - /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) goto fail; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index ed63c2b6f9..fe7a029ebf 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -29,7 +29,7 @@ enum domain_type { #define is_64bit_domain(d) (0) #endif -#define is_domain_direct_mapped(d) (d)->arch.directmap +#define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) /* * Is the domain using the host memory layout? @@ -103,7 +103,6 @@ struct arch_domain void *tee; #endif - bool directmap; } __cacheline_aligned; struct arch_vcpu diff --git a/xen/common/domain.c b/xen/common/domain.c index 3b1169d79b..875730df50 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -567,6 +567,9 @@ struct domain *domain_create(domid_t domid, /* Sort out our idea of is_system_domain(). */ d->domain_id = domid; + /* Holding CDF_* internal flags. */ + d->cdf = flags; + /* Debug sanity. */ ASSERT(is_system_domain(d) ? config == NULL : config != NULL); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b9515eb497..98e8001c89 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -596,6 +596,9 @@ struct domain struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; #endif + + /* Holding CDF_* constant. Internal flags for domain creation. */ + unsigned int cdf; }; static inline struct page_list_head *page_to_list( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362810.593081 (Exim 4.92) (envelope-from ) id 1o9NjN-0004z8-PT; Thu, 07 Jul 2022 09:23:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362810.593081; Thu, 07 Jul 2022 09:23:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjN-0004yw-LR; Thu, 07 Jul 2022 09:23:29 +0000 Received: by outflank-mailman (input) for mailman id 362810; Thu, 07 Jul 2022 09:23:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjM-00032J-EM for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:28 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 7505a66f-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:27 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 680B21063; Thu, 7 Jul 2022 02:23:27 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id EDCB73F792; Thu, 7 Jul 2022 02:23:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7505a66f-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v8 6/9] xen/arm: introduce CDF_staticmem Date: Thu, 7 Jul 2022 17:22:41 +0800 Message-Id: <20220707092244.485936-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng --- v8 changes: - #ifdef-ary around is_domain_using_staticmem() is not needed anymore --- v7 changes: - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore --- v6 changes: - move non-zero is_domain_using_staticmem() from ARM header to common header --- v5 changes: - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v4 changes: - no changes --- v3 changes: - change name from "is_domain_static()" to "is_domain_using_staticmem" --- v2 changes: - change name from "is_domain_on_static_allocation" to "is_domain_static()" --- xen/arch/arm/domain_build.c | 5 ++++- xen/include/xen/domain.h | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..b76a84e8f5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3287,9 +3287,12 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + if ( dt_property_read_bool(node, "direct-map") ) { - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) + if ( !(flags & CDF_staticmem) ) panic("direct-map is not valid for domain %s without static allocation.\n", dt_node_name(node)); diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 628b14b086..2c8116afba 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -35,6 +35,14 @@ void arch_get_domain_info(const struct domain *d, /* Should domain memory be directly mapped? */ #define CDF_directmap (1U << 1) #endif +/* Is domain memory on static allocation? */ +#ifdef CONFIG_STATIC_MEMORY +#define CDF_staticmem (1U << 2) +#else +#define CDF_staticmem 0 +#endif + +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) /* * Arch-specifics. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362816.593092 (Exim 4.92) (envelope-from ) id 1o9NjS-0005cD-8A; Thu, 07 Jul 2022 09:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362816.593092; Thu, 07 Jul 2022 09:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjS-0005bq-27; Thu, 07 Jul 2022 09:23:34 +0000 Received: by outflank-mailman (input) for mailman id 362816; Thu, 07 Jul 2022 09:23:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjQ-0002ms-Jv for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:32 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7799a294-fdd6-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:23:31 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 515631063; Thu, 7 Jul 2022 02:23:31 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 9AD033F792; Thu, 7 Jul 2022 02:23:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7799a294-fdd6-11ec-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v8 7/9] xen/arm: unpopulate memory when domain is static Date: Thu, 7 Jul 2022 17:22:42 +0800 Message-Id: <20220707092244.485936-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never go back to heap allocator. This commit puts reserved pages on the new list resv_page_list only after having taken them off the "normal" list, when the last ref dropped. Signed-off-by: Penny Zheng --- v8 changes: - adapt this patch for newly introduced free_domstatic_page - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list --- v7 changes: - Add page on the rsv_page_list *after* it has been freed --- v6 changes: - refine in-code comment - move PGC_static !CONFIG_STATIC_MEMORY definition to common header --- v5 changes: - adapt this patch for PGC_staticmem --- v4 changes: - no changes --- v3 changes: - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. --- v2 changes: - put reserved pages on resv_page_list after having taken them off the "normal" list --- xen/common/domain.c | 4 ++++ xen/common/page_alloc.c | 10 ++++++++-- xen/include/xen/mm.h | 6 ++++++ xen/include/xen/sched.h | 3 +++ 4 files changed, 21 insertions(+), 2 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 875730df50..4043498ffa 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid, INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); INIT_PAGE_LIST_HEAD(&d->xenpage_list); +#ifdef CONFIG_STATIC_MEMORY + INIT_PAGE_LIST_HEAD(&d->resv_page_list); +#endif + spin_lock_init(&d->node_affinity_lock); d->node_affinity = NODE_MASK_ALL; diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 3260490688..b01272a59a 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2681,8 +2681,6 @@ void free_domstatic_page(struct page_info *page) need_scrub = d->is_dying || scrub_debug || opt_scrub_domheap; drop_dom_ref = !domain_adjust_tot_pages(d, -1); - - spin_unlock_recursive(&d->page_alloc_lock); } else { @@ -2692,6 +2690,14 @@ void free_domstatic_page(struct page_info *page) free_staticmem_pages(page, 1, need_scrub); + if ( likely(d) ) + { + /* Add page on the resv_page_list *after* it has been freed. */ + if ( !drop_dom_ref ) + put_static_page(d, page); + spin_unlock_recursive(&d->page_alloc_lock); + } + if ( drop_dom_ref ) put_domain(d); } diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index f1a7d5c991..07b8a45f1a 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -91,6 +91,12 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, void free_domstatic_page(struct page_info *page); int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); +#ifdef CONFIG_STATIC_MEMORY +#define put_static_page(d, page) \ + page_list_add_tail((page), &(d)->resv_page_list) +#else +#define put_static_page(d, page) ((void)(d), (void)(page)) +#endif /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 98e8001c89..d4fbd3dea7 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -381,6 +381,9 @@ struct domain struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ +#ifdef CONFIG_STATIC_MEMORY + struct page_list_head resv_page_list; /* linked list */ +#endif /* * This field should only be directly accessed by domain_adjust_tot_pages() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:23:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362821.593102 (Exim 4.92) (envelope-from ) id 1o9Nja-0006RW-HB; Thu, 07 Jul 2022 09:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362821.593102; Thu, 07 Jul 2022 09:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nja-0006RN-Dr; Thu, 07 Jul 2022 09:23:42 +0000 Received: by outflank-mailman (input) for mailman id 362821; Thu, 07 Jul 2022 09:23:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjY-0002ms-KR for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:40 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 7c5996ea-fdd6-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:23:39 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 624DC1063; Thu, 7 Jul 2022 02:23:39 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AE2E53F792; Thu, 7 Jul 2022 02:23:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c5996ea-fdd6-11ec-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v8 9/9] xen: retrieve reserved pages on populate_physmap Date: Thu, 7 Jul 2022 17:22:44 +0800 Message-Id: <20220707092244.485936-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a static domain populates memory through populate_physmap at runtime, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. This commit also introduces a new helper acquire_reserved_page to make it work. Signed-off-by: Penny Zheng --- v8 changes: - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - drop the lock before returning --- v5 changes: - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes： - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - move is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 --- xen/common/memory.c | 23 ++++++++++++++ xen/common/page_alloc.c | 70 +++++++++++++++++++++++++++++++---------- xen/include/xen/mm.h | 1 + 3 files changed, 77 insertions(+), 17 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index f2d009843a..cb330ce877 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) mfn = _mfn(gpfn); } + else if ( is_domain_using_staticmem(d) ) + { + /* + * No easy way to guarantee the retrieved pages are contiguous, + * so forbid non-zero-order requests here. + */ + if ( a->extent_order != 0 ) + { + gdprintk(XENLOG_WARNING, + "Cannot allocate static order-%u pages for static %pd\n", + a->extent_order, d); + goto out; + } + + mfn = acquire_reserved_page(d, a->memflags); + if ( mfn_eq(mfn, INVALID_MFN) ) + { + gdprintk(XENLOG_WARNING, + "%pd: failed to retrieve a reserved page\n", + d); + goto out; + } + } else { page = alloc_domheap_pages(d, a->extent_order, a->memflags); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 6112f6a3ed..390a9c002d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2702,9 +2702,8 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -static bool __init prepare_staticmem_pages(struct page_info *pg, - unsigned long nr_mfns, - unsigned int memflags) +static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; @@ -2785,21 +2784,9 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, return pg; } -/* - * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, - * then assign them to one specific domain #d. - */ -int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, - unsigned int nr_mfns, unsigned int memflags) +static int assign_domstatic_pages(struct domain *d, struct page_info *pg, + unsigned int nr_mfns, unsigned int memflags) { - struct page_info *pg; - - ASSERT_ALLOC_CONTEXT(); - - pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); - if ( !pg ) - return -ENOENT; - if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) { /* @@ -2818,6 +2805,55 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } + +/* + * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, + * then assign them to one specific domain #d. + */ +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, + unsigned int nr_mfns, unsigned int memflags) +{ + struct page_info *pg; + + ASSERT_ALLOC_CONTEXT(); + + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); + if ( !pg ) + return -ENOENT; + + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) + return -EINVAL; + + return 0; +} + +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + struct page_info *page; + + /* Acquire a page from reserved page list(resv_page_list). */ + spin_lock(&d->page_alloc_lock); + page = page_list_remove_head(&d->resv_page_list); + spin_unlock(&d->page_alloc_lock); + if ( unlikely(!page) ) + return INVALID_MFN; + + if ( !prepare_staticmem_pages(page, 1, memflags) ) + goto fail; + + if ( assign_domstatic_pages(d, page, 1, memflags) ) + goto fail; + + return page_to_mfn(page); + + fail: + page_list_add_tail(page, &d->resv_page_list); + return INVALID_MFN; +} #endif /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 07b8a45f1a..559264b55d 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -97,6 +97,7 @@ int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, #else #define put_static_page(d, page) ((void)(d), (void)(page)) #endif +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:29:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:29:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362841.593114 (Exim 4.92) (envelope-from ) id 1o9NpE-0008GT-CC; Thu, 07 Jul 2022 09:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362841.593114; Thu, 07 Jul 2022 09:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NpE-0008GM-8b; Thu, 07 Jul 2022 09:29:32 +0000 Received: by outflank-mailman (input) for mailman id 362841; Thu, 07 Jul 2022 09:29:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NpC-0008GG-SC for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:29:31 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d063d57-fdd7-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:29:29 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0677A1F97D; Thu, 7 Jul 2022 09:29:29 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DA5AE13A33; Thu, 7 Jul 2022 09:29:28 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yq6lM3inxmLGFgAAMHmgww (envelope-from ); Thu, 07 Jul 2022 09:29:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d063d57-fdd7-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657186169; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=G1P8eRdGF/FuOqF2VxK31LjQw8VBl6xBhpvo5J3qD5I=; b=P96Kv92HBrLGV+Mmto+9Zz4I3bIirZoWl9vLP9cJy15a4FjT+TujiEuiSLzYru+Za9Byw/ Fsesomp150WdTeGIQ9u43ECnp7iES0sGxcZYgORw+l5jNRsJLbs/ZZB3us4vcxqvj4fHY8 n9qsJP6eenCObxVfAtYAwkcWdXTl2cE= Message-ID: <2d2c8fcd-63ee-3977-54d4-0810c883c09e@suse.com> Date: Thu, 7 Jul 2022 11:29:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom Content-Language: en-US To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD References: <20220624092806.27700-1-jgross@suse.com> From: Juergen Gross In-Reply-To: <20220624092806.27700-1-jgross@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YgskTndJnIkDiaEXLlMLeAZQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YgskTndJnIkDiaEXLlMLeAZQ Content-Type: multipart/mixed; boundary="------------jmpeRE3sBZ7s2nwnIPqYegOc"; protected-headers="v1" From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Wei Liu , Anthony PERARD Message-ID: <2d2c8fcd-63ee-3977-54d4-0810c883c09e@suse.com> Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom References: <20220624092806.27700-1-jgross@suse.com> In-Reply-To: <20220624092806.27700-1-jgross@suse.com> --------------jmpeRE3sBZ7s2nwnIPqYegOc Content-Type: multipart/mixed; boundary="------------bYDb6I97p9Fxgglo9FUtRzsB" --------------bYDb6I97p9Fxgglo9FUtRzsB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 UGluZz8NCg0KT24gMjQuMDYuMjIgMTE6MjgsIEp1ZXJnZW4gR3Jvc3Mgd3JvdGU6DQo+IElu IGNhc2Ugb2YgbWF4bWVtICE9IG1lbXNpemUgdGhlIEU4MjAgbWFwIG9mIHRoZSBQVkggc3R1 YmRvbSBpcyB3cm9uZywNCj4gYXMgaXQgaXMgbWlzc2luZyB0aGUgUkFNIGFib3ZlIG1lbXNp emUuDQo+IA0KPiBBZGRpdGlvbmFsbHkgdGhlIE1NSU8gYXJlYSBzaG91bGQgb25seSBjb3Zl ciB0aGUgSFZNIHNwZWNpYWwgcGFnZXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKdWVyZ2Vu IEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IC0tLQ0KPiAgIHRvb2xzL2hlbHBlcnMvaW5p dC14ZW5zdG9yZS1kb21haW4uYyB8IDE2ICsrKysrKysrKystLS0tLS0NCj4gICAxIGZpbGUg Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYg LS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMgYi90b29scy9o ZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMNCj4gaW5kZXggYjRmM2M2NWE4YS4uZGFk OGU0M2M0MiAxMDA2NDQNCj4gLS0tIGEvdG9vbHMvaGVscGVycy9pbml0LXhlbnN0b3JlLWRv bWFpbi5jDQo+ICsrKyBiL3Rvb2xzL2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYw0K PiBAQCAtNzEsOCArNzEsOSBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAqeGNo KQ0KPiAgICAgICBjaGFyIGNtZGxpbmVbNTEyXTsNCj4gICAgICAgaW50IHJ2LCB4c19mZDsN Cj4gICAgICAgc3RydWN0IHhjX2RvbV9pbWFnZSAqZG9tID0gTlVMTDsNCj4gLSAgICBpbnQg bGltaXRfa2IgPSAobWF4bWVtID8gOiAobWVtb3J5ICsgMSkpICogMTAyNDsNCj4gKyAgICBp bnQgbGltaXRfa2IgPSAobWF4bWVtID8gOiBtZW1vcnkpICogMTAyNCArIFg4Nl9IVk1fTlJf U1BFQ0lBTF9QQUdFUyAqIDQ7DQo+ICAgICAgIHVpbnQ2NF90IG1lbV9zaXplID0gTUIobWVt b3J5KTsNCj4gKyAgICB1aW50NjRfdCBtYXhfc2l6ZSA9IE1CKG1heG1lbSk7DQo+ICAgICAg IHN0cnVjdCBlODIwZW50cnkgZTgyMFszXTsNCj4gICAgICAgc3RydWN0IHhlbl9kb21jdGxf Y3JlYXRlZG9tYWluIGNvbmZpZyA9IHsNCj4gICAgICAgICAgIC5zc2lkcmVmID0gU0VDSU5J VFNJRF9ET01VLA0KPiBAQCAtMTU3LDIxICsxNTgsMjQgQEAgc3RhdGljIGludCBidWlsZCh4 Y19pbnRlcmZhY2UgKnhjaCkNCj4gICAgICAgICAgIGNvbmZpZy5mbGFncyB8PSBYRU5fRE9N Q1RMX0NERl9odm0gfCBYRU5fRE9NQ1RMX0NERl9oYXA7DQo+ICAgICAgICAgICBjb25maWcu YXJjaC5lbXVsYXRpb25fZmxhZ3MgPSBYRU5fWDg2X0VNVV9MQVBJQzsNCj4gICAgICAgICAg IGRvbS0+dGFyZ2V0X3BhZ2VzID0gbWVtX3NpemUgPj4gWENfUEFHRV9TSElGVDsNCj4gLSAg ICAgICAgZG9tLT5tbWlvX3NpemUgPSBHQig0KSAtIExBUElDX0JBU0VfQUREUkVTUzsNCj4g KyAgICAgICAgZG9tLT5tbWlvX3NpemUgPSBYODZfSFZNX05SX1NQRUNJQUxfUEFHRVMgPDwg WENfUEFHRV9TSElGVDsNCj4gICAgICAgICAgIGRvbS0+bG93bWVtX2VuZCA9IChtZW1fc2l6 ZSA+IExBUElDX0JBU0VfQUREUkVTUykgPw0KPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgTEFQSUNfQkFTRV9BRERSRVNTIDogbWVtX3NpemU7DQo+ICAgICAgICAgICBkb20tPmhp Z2htZW1fZW5kID0gKG1lbV9zaXplID4gTEFQSUNfQkFTRV9BRERSRVNTKSA/DQo+ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgR0IoNCkgKyBtZW1fc2l6ZSAtIExBUElDX0JBU0Vf QUREUkVTUyA6IDA7DQo+IC0gICAgICAgIGRvbS0+bW1pb19zdGFydCA9IExBUElDX0JBU0Vf QUREUkVTUzsNCj4gKyAgICAgICAgZG9tLT5tbWlvX3N0YXJ0ID0gKFg4Nl9IVk1fRU5EX1NQ RUNJQUxfUkVHSU9OIC0NCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgIFg4Nl9IVk1f TlJfU1BFQ0lBTF9QQUdFUykgPDwgWENfUEFHRV9TSElGVDsNCj4gICAgICAgICAgIGRvbS0+ bWF4X3ZjcHVzID0gMTsNCj4gICAgICAgICAgIGU4MjBbMF0uYWRkciA9IDA7DQo+IC0gICAg ICAgIGU4MjBbMF0uc2l6ZSA9IGRvbS0+bG93bWVtX2VuZDsNCj4gKyAgICAgICAgZTgyMFsw XS5zaXplID0gKG1heF9zaXplID4gTEFQSUNfQkFTRV9BRERSRVNTKSA/DQo+ICsgICAgICAg ICAgICAgICAgICAgICAgIExBUElDX0JBU0VfQUREUkVTUyA6IG1heF9zaXplOw0KPiAgICAg ICAgICAgZTgyMFswXS50eXBlID0gRTgyMF9SQU07DQo+IC0gICAgICAgIGU4MjBbMV0uYWRk ciA9IExBUElDX0JBU0VfQUREUkVTUzsNCj4gKyAgICAgICAgZTgyMFsxXS5hZGRyID0gZG9t LT5tbWlvX3N0YXJ0Ow0KPiAgICAgICAgICAgZTgyMFsxXS5zaXplID0gZG9tLT5tbWlvX3Np emU7DQo+ICAgICAgICAgICBlODIwWzFdLnR5cGUgPSBFODIwX1JFU0VSVkVEOw0KPiAgICAg ICAgICAgZTgyMFsyXS5hZGRyID0gR0IoNCk7DQo+IC0gICAgICAgIGU4MjBbMl0uc2l6ZSA9 IGRvbS0+aGlnaG1lbV9lbmQgLSBHQig0KTsNCj4gKyAgICAgICAgZTgyMFsyXS5zaXplID0g KG1heF9zaXplID4gTEFQSUNfQkFTRV9BRERSRVNTKSA/DQo+ICsgICAgICAgICAgICAgICAg ICAgICAgIG1heF9zaXplIC0gTEFQSUNfQkFTRV9BRERSRVNTIDogMDsNCj4gICAgICAgICAg IGU4MjBbMl0udHlwZSA9IEU4MjBfUkFNOw0KPiAgICAgICB9DQo+ICAgDQoNCg== --------------bYDb6I97p9Fxgglo9FUtRzsB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------bYDb6I97p9Fxgglo9FUtRzsB-- --------------jmpeRE3sBZ7s2nwnIPqYegOc-- --------------YgskTndJnIkDiaEXLlMLeAZQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLGp3gFAwAAAAAACgkQsN6d1ii/Ey+H jwgAjLflYjVm5G6JJNHFG910HBKPfTstQFxVdR5kPs+pW6dWypqJtaTOxzE3glCJ3hjR5Z98o3kA MhjRcwi1eCo7Yfx1W2W7oLKGt2VmjgysEX5IADKiHkOncU3xPo4TkPsIhqmOAYyQaVqdhnGikSJB QQQdAbbNT61vJYwUQthP/Tnh2fGcHq4eXe0hW/Rc8AlLdanX55g29gyh8CZkS5l3MdfUAyA7kcVC 8t4cRSPIO6TyhoMKO1qIdAIaT2OTnIpvEI4RspXU+pxpQEtJdxp2thYLgzk0vW09n/dq1SJ1pvwq K/dPO4xDLiuVjMIt2I8G3maxzMackaP4wjngUDPqig== =9lAD -----END PGP SIGNATURE----- --------------YgskTndJnIkDiaEXLlMLeAZQ-- From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:31:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:31:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362864.593125 (Exim 4.92) (envelope-from ) id 1o9NrU-0001VG-Px; Thu, 07 Jul 2022 09:31:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362864.593125; Thu, 07 Jul 2022 09:31:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NrU-0001V9-L7; Thu, 07 Jul 2022 09:31:52 +0000 Received: by outflank-mailman (input) for mailman id 362864; Thu, 07 Jul 2022 09:31:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NjX-00032J-2a for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:23:39 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 79d1636a-fdd6-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:23:35 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 75F361063; Thu, 7 Jul 2022 02:23:35 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 89C893F792; Thu, 7 Jul 2022 02:23:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79d1636a-fdd6-11ec-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v8 8/9] xen: introduce prepare_staticmem_pages Date: Thu, 7 Jul 2022 17:22:43 +0800 Message-Id: <20220707092244.485936-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220707092244.485936-1-Penny.Zheng@arm.com> References: <20220707092244.485936-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we want to use acquire_domstatic_pages() for populating memory for static domain on runtime, however, there are a lot of pointless work (checking mfn_valid(), scrubbing the free part, cleaning the cache...) considering we know the page is valid and belong to the guest. This commit splits acquire_staticmem_pages() in two parts, and introduces prepare_staticmem_pages to bypass all "pointless work". Signed-off-by: Penny Zheng Acked-by: Jan Beulich --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - adapt to PGC_static --- v5 changes: - new commit --- xen/common/page_alloc.c | 61 ++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index b01272a59a..6112f6a3ed 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2702,26 +2702,13 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -/* - * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of - * static memory. - * This function needs to be reworked if used outside of boot. - */ -static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, - unsigned long nr_mfns, - unsigned int memflags) +static bool __init prepare_staticmem_pages(struct page_info *pg, + unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; unsigned long i; - struct page_info *pg; - - ASSERT(nr_mfns); - for ( i = 0; i < nr_mfns; i++ ) - if ( !mfn_valid(mfn_add(smfn, i)) ) - return NULL; - - pg = mfn_to_page(smfn); spin_lock(&heap_lock); @@ -2732,7 +2719,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", - i, mfn_x(smfn) + i, + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info, pg[i].tlbflush_timestamp); goto out_err; } @@ -2756,6 +2743,38 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, if ( need_tlbflush ) filtered_flush_tlb_mask(tlbflush_timestamp); + return true; + + out_err: + while ( i-- ) + pg[i].count_info = PGC_static | PGC_state_free; + + spin_unlock(&heap_lock); + + return false; +} + +/* + * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of + * static memory. + * This function needs to be reworked if used outside of boot. + */ +static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, + unsigned long nr_mfns, + unsigned int memflags) +{ + unsigned long i; + struct page_info *pg; + + ASSERT(nr_mfns); + for ( i = 0; i < nr_mfns; i++ ) + if ( !mfn_valid(mfn_add(smfn, i)) ) + return NULL; + + pg = mfn_to_page(smfn); + if ( !prepare_staticmem_pages(pg, nr_mfns, memflags) ) + return NULL; + /* * Ensure cache and RAM are consistent for platforms where the guest * can control its own visibility of/through the cache. @@ -2764,14 +2783,6 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, flush_page_to_ram(mfn_x(smfn) + i, !(memflags & MEMF_no_icache_flush)); return pg; - - out_err: - while ( i-- ) - pg[i].count_info = PGC_static | PGC_state_free; - - spin_unlock(&heap_lock); - - return NULL; } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362877.593135 (Exim 4.92) (envelope-from ) id 1o9Nye-0002ih-Gk; Thu, 07 Jul 2022 09:39:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362877.593135; Thu, 07 Jul 2022 09:39:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nye-0002ia-Df; Thu, 07 Jul 2022 09:39:16 +0000 Received: by outflank-mailman (input) for mailman id 362877; Thu, 07 Jul 2022 09:39:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Nyc-0002iU-RW for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:39:14 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a94cc52a-fdd8-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 11:39:13 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D42A81FDCE; Thu, 7 Jul 2022 09:39:13 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8B52413A33; Thu, 7 Jul 2022 09:39:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id vNrDIMGpxmKbGwAAMHmgww (envelope-from ); Thu, 07 Jul 2022 09:39:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a94cc52a-fdd8-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657186753; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=8x8nnPqZhI2NQboezzcWTnGNqtcfgmJkkNECedEEebk=; b=jkczioW1jes3NWRNRo4QpczESuCY9sfPC9TW1dxjRrcd4ksg2m4OQuSzMAZ5PQq6ZL6Kgs YqCPvERM67Cwp2D9O0f5Of2X7c+Bo/7ex101l9jNmFtGPZdn0LT30lO5ehjKfJRJUXtsvl +dfzPjmoWEA/OYn3behMRt5Y71O+MIk= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] Config.mk: use newest Mini-OS commit Date: Thu, 7 Jul 2022 11:39:11 +0200 Message-Id: <20220707093911.22182-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Switch to use the newest Mini-OS commit in order to get the recent fixes. Signed-off-by: Juergen Gross --- Config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index a806ef0afb..e56844d964 100644 --- a/Config.mk +++ b/Config.mk @@ -230,7 +230,7 @@ MINIOS_UPSTREAM_URL ?= git://xenbits.xen.org/mini-os.git endif OVMF_UPSTREAM_REVISION ?= 7b4a99be8a39c12d3a7fc4b8db9f0eab4ac688d5 QEMU_UPSTREAM_REVISION ?= master -MINIOS_UPSTREAM_REVISION ?= 83ff43bff4bdd6879539fcb2b3d6ba5e61a64135 +MINIOS_UPSTREAM_REVISION ?= 5bcb28aaeba1c2506a82fab0cdad0201cd9b54b3 SEABIOS_UPSTREAM_REVISION ?= rel-1.16.0 -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 09:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 09:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362882.593147 (Exim 4.92) (envelope-from ) id 1o9NzI-0003EM-PN; Thu, 07 Jul 2022 09:39:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362882.593147; Thu, 07 Jul 2022 09:39:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NzI-0003EF-MP; Thu, 07 Jul 2022 09:39:56 +0000 Received: by outflank-mailman (input) for mailman id 362882; Thu, 07 Jul 2022 09:39:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9NzG-0003CJ-B0 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 09:39:54 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfaf0421-fdd8-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 11:39:52 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26793X85010169; Thu, 7 Jul 2022 09:37:42 GMT Received: from eur03-dba-obe.outbound.protection.outlook.com (mail-dbaeur03lp2173.outbound.protection.outlook.com [104.47.51.173]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3h5a2tb6df-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Jul 2022 09:37:41 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM0PR03MB4737.eurprd03.prod.outlook.com (2603:10a6:208:cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 09:37:37 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 09:37:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfaf0421-fdd8-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LzwdYqa/ciDu9uUT6A/hOLSW2KUiYx+8AyqwWyl7GuqAqUoq90AORDVHV30kOwFHv2Q2UBdrw+z/1u1wfeB2lZewVcRYVzibmrzCN2T4cj2lbv/Uw/vIPkKL5efGTNVbjkg855abbFpypXfqPCl61eU7PJBtKIUJscj60QaaQCJ1GGGrxLshlLYb79e6K9NkFRH9ZWVQbV9XoTnli0yH1N+8ZP0UTbAyY+slD+U8wSvlnD4HtqStJUzYHvzm83baEWJgTqhyHGsGxsIyulxlx8NcKsmHoV22H95cXtU2lf/O0IniqpZrJNk4Fv1/VIfXGDS3PtOKC6/n9uV97ol05Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ruarQZmNj43SLW9TQWws2/Vu+4+WGtOYXsQcS/yMp6E=; b=Ziwr9X+k1nNJK2MT+8tESLGPWl4okA4jmQ5Ew23viNW3jUsHTVmA5N2f35WxlhDUeAiFZi9Kr+5C0UBgQERWH7iBVT6eVjN8ZTI0rplnma8wZHVeNbRgQUyMRJ4x7/d2H7SYlKUtRLgRWGTrtSPcju1Cir7yL07py73FNPl/BYRfmZtwPYqB0F4UyXWnbSXeADVThBYs0KTl4Kd/W/wtL1iHNz5WUvlOj+s1H+jANeq3dhRJ0rG5P6NRwcD9kSx5wc86f7S9FsruImI1G+xXk4Jx7f+u3ZwveFJQxp2Puf2Nny6+9OQlAnEFvX2wCim4+wEiJZM9ghIRl5TjUXgcdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ruarQZmNj43SLW9TQWws2/Vu+4+WGtOYXsQcS/yMp6E=; b=Wev+E8hZQ4m8qoqDrosX+H5/hR7Bpmpms+Uc80EHMcO5HWQlEmZK8rH6mIMdjCO3afJkzZnoMBdTiU/1LPmn3RZIMQPLaT2jb5gqg5zNR20y+Jk2KVvrDNH09hBsN91m5G53IPznF1oRL4v3fXV0l4SGlvwenes/ZHQfqKSrkNy1k1iwLooxRJAdnHslH2Y0YtrmCnLT1jUZNvZnZ4io1R2RVariPJXqPD+0sCEzEFBWRVbYKCfAsAKWaUQ87FfigIqxp4tSZ718BpEQTBZvW4dUImPGg49Fdki8eShNL1n3i/rS97j+OxRqfTNnUNpRmfgAorNdMH+MmGB8Gy+hTA== From: Oleksandr Tyshchenko To: Marc Zyngier , Oleksandr CC: Samuel Holland , Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , =?utf-8?B?S3J6eXN6dG9mIFdpbGN6ecWEc2tp?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Serge Semin , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , "iommu@lists.linux-foundation.org" , "iommu@lists.linux.dev" , "linux-alpha@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hyperv@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" , "x86@kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3 6/8] genirq: Add and use an irq_data_update_affinity helper Thread-Topic: [PATCH v3 6/8] genirq: Add and use an irq_data_update_affinity helper Thread-Index: AQHYjYVqhNJG+4sRYkWyXsKH5qhjxa1sxkCAgAXY/ACAABASgA== Date: Thu, 7 Jul 2022 09:37:37 +0000 Message-ID: <4adea4b3-8e42-ef94-b29f-f375d167d55e@epam.com> References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-7-samuel@sholland.org> <87bku1mi3l.wl-maz@kernel.org> In-Reply-To: <87bku1mi3l.wl-maz@kernel.org> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08768308-e26f-4792-3532-08da5ffc5455 x-ms-traffictypediagnostic: AM0PR03MB4737:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1NVapwnjiW95BqQ7BoYPG6olQ4Bxy2HMcBhMalP14KVYpJijm5gEMc6/d4hoJnxQvpZxJHDPGZj60oqFrquf7yeMJXKNwTIZJgBoufSFIoOApzcI3qMtG8KufLQufGdoch9dzQaXxED/ga7v3S9ueOevm91WSIi0loqt7hyrbUr+JPYu8+2NU1YNIhghz7n6Ge+GiyvExtIVTAayJ2dqoqSpcRcp1rvr+FBYyeG1GZFTFyLFD3dvopMlxonNzCMkaWVVIuuJ1H6qcCzb5pyuwKb1lbMpIz6aXRgYljy6KY2uPKIIZTdKjLJIPsKe7c6xpCxprDYSMIXdqxX9AEJ6svymuXrzE5ZEG3/vtC6jup3DCivLU1AfL4LettBCyAba+bQDPmOucvs25JFxQ5h383d1Xx5C4sNouPCd5cELNiHNLLUofJ5ncoErc4Dw/nH7GFT/WaUKKHt1+VW6tsV+4nF4CPy3Uits/egQEeEPSlxCGk3cEUp7go1ZLXAEO2KTKmIrmXMDeyXP2P59aqHkUGBFvL735WtRF5ugeO+eTVRIYl1moewLTTkWYHbcQtXpxmI3J55sL32MvARVkt+zlKrCpNYQ2ogoQhZW5jEXgbhv4cW11iJ7yDUibT+YaLbOE1PKs7tdJCiQkWc3HRre9xSfpn44mkSpNfXPnNddBtzgaPqIHJSelJsRkcYCKzuqNNGJ4NzLIfFl8DNzZ5LbwjwtsDdbUr6Hh3xvV/JzrJEndHnM41E8nVBmKyVh4ccV3xzYwmhnLhw6ROWhuagHr5Iuj+1Zfc2IyCawwUbVRpeBuhJIEFthwwCEhzkgrr9gqZbqf3bJGc4qUnjim2sRD4mgUGrHfT96bqdO59kafxE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(376002)(136003)(396003)(346002)(53546011)(4326008)(6506007)(55236004)(316002)(8676002)(91956017)(2906002)(64756008)(8936002)(86362001)(66556008)(66446008)(26005)(83380400001)(478600001)(6512007)(66946007)(76116006)(31686004)(7366002)(31696002)(38100700002)(38070700005)(66476007)(7406005)(5660300002)(7416002)(186003)(71200400001)(41300700001)(6486002)(36756003)(122000001)(2616005)(54906003)(110136005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?elYrZ05YWWQvd0J5T2s1dHRiU3JqY05ZUUljd0J6eCtSMDVqTGV3Y3dEWXQv?= =?utf-8?B?MXk4TXFnZnpjeFNtNWUybmdtOGhhTnRqOGZhQ29VNGdkcjBzNmZGcjdnSVJo?= =?utf-8?B?TVFJM1RWdlQ1MmlYZGQ1a21Za1ZUT2JQQ3dOWWJNNVBSL0hxdUZpT0hRRHAx?= =?utf-8?B?OXZFNlVXU2xqK1VrVktKN1ljK1RjQ1RSNVg1Ty8zRXhtS3VVaEpYVUM4c3Rh?= =?utf-8?B?SFpYVldjME1DZDNZMEw5NExwMVVEeFdiZHVubnRrZVdCQzJPTXlOcDhKQ2p5?= =?utf-8?B?T1UxM1Q1UVpQZ0JzRngwVEpjTklKOU1TbTF1ZDZFQVBTTzNJTWJhVmJuSXd1?= =?utf-8?B?ZU5YdUtBNmJEa0xDYWdkUDM5SnFIempCTnlNRXBTWDEwMytKK3JSeVVxbUJH?= =?utf-8?B?MzhtL2tzL0lIMWRtZWNUN0puYWxuVHptdmlUMDlGWFZrWkkrMUhvVGt0RjRH?= =?utf-8?B?MTF0ZVBDRmN6dTFsS2dCL1RpNFRYbDZzdmgyTDdZQmVCVkZMSmdocDVYMjJJ?= =?utf-8?B?ZXAwVGoyc3JNd2dWMEFFVVEwYUNYeVRwTkc0bE15RmE2dEU3cFQvK1dxeVJ3?= =?utf-8?B?NW9lRlFzVnFzalMrOHFSY1VBTnFkbFY3VkZXajNVWmhVNWNya28wbXVUQ3pz?= =?utf-8?B?YldPM2M4NStKUUVIUFdtU09Od0IzQWc3QnNIZkFabUNpNE5nb3UwTU0rQVJ3?= =?utf-8?B?OFpWeHMweGpWeFRYM1lxaTF3K2RFNCsvZ2gxd1lSNW9jeXBNRFJ5V2RoRFRw?= =?utf-8?B?ekY4aTBVWnFCYjNocVNmRlBOT3lJdWJnTEcxMWc0Y0lMbjZXbGg5S0kzT1Vp?= =?utf-8?B?UVRSR0tZNFBLc3pqWEZaSk1qMDlUNnZZQUk2T1NoMUQzMXVYbzNIczFMSmpn?= =?utf-8?B?WmxvRWhWQVZtVWNTVTBKQzNkczY3VDVYdFNzTU9ZWEVSczhTK0ExQTd3RldX?= =?utf-8?B?eWJCRlV1U3Q5NXUxNWR6NHhzYzRGcXRtdUFybjk4TWlITWlmKzVNUndwT0wz?= =?utf-8?B?dkc4QWlUUUQzOWJKUVM3UXRsSzNUMnZhdmEwMlM3YWpqMjc2dzJBOWwwZXFX?= =?utf-8?B?M3FTUGU2SzVnZ3ZrQklZWXhnYnVmaGZXV1g1aG5SRVNldVBiYXowcjBjV1Jm?= =?utf-8?B?SnRtNEtZYUl2S2cxMm4yQWZ3VGFvZTc4NzgweXNtTHFYV3hNaEVLb0NtdXZm?= =?utf-8?B?MVFmY3NDczJ1d1p2UEt6VW5VTHM2K0daNFRlSitmbm1MaVdZQ1p1c2pGcTRX?= =?utf-8?B?L25iRkN0eHdyamYyYWdsMHN0Z1ZlRVBVTlZ5NEwrMTBEdVRtbTRpdFd3bG4w?= =?utf-8?B?SWM4U3liM0c4amRFSzgrTk5NeVhXNUNqcTZiZFphTlNNYzlUaUNNVnhxQVM0?= =?utf-8?B?cWoyUzFaeTN3dmRwbXdOMkdqSDBBRTNlZjdxWDR5aGUwcGZhUEUxYW50VW5h?= =?utf-8?B?RE9qYTdFaTJOU1FaZUovNFQ5SXBOTklYSWdoU1RPTHlxMUswYlhGeUc0Z09C?= =?utf-8?B?Y05WaDUwQVJTRjhMRTlkSXc5Z0VOTGRPTnQ2aG1xSnJDV0VYV0N5L2lDUEVM?= =?utf-8?B?d3c1b0NMaDJSRHQ3NjFzV0U2eGdScEtNeFlRUXc1VngvV09jY2pDOS94akZV?= =?utf-8?B?YTdyd0NZZ2xYd1dYZUlBdXNUTEhWcW1vdGlTdEl2Um5xOXkybHRIWkg3a3BL?= =?utf-8?B?VGhjNkJjVDBONHBSTk55cVlKT1Q1UWgrNVM2M2Evd3dQZWVndURFaEwwRDdG?= =?utf-8?B?aWRjNUVmYTRhTklCVU1vUmdtNVB0dURZZU1WN2g1NVhta2V0djV5VW95MEJB?= =?utf-8?B?S3RxQVpMNWMyMVFzTE9QNzVuSWtoNVpXV0t5YThmbzN2MnVXYkpZNk5tMDhy?= =?utf-8?B?ZndSMFlhZ096M253bUZkSFMyY0FkdzZVeTdWdDI0UHVsS2NRK2k5bENkbmhu?= =?utf-8?B?Vi9zOVdXVUZoMzVVckhFa2NQck1iK2g4RXlkSW1ndGJna25nTEVhSjY0Qk9E?= =?utf-8?B?SDJPcWEwU1ZteGJOcm82Q0JWR0VTeWU0R28zVGhWczJhcGdYYkhpOUFVcmZP?= =?utf-8?B?ZkszUmJ0WkxyL2hodFcyQlNTazMzZjNtcHc2RStidlVZODZyY1V0QXdjTnNU?= =?utf-8?B?UlUyUUtab3UydnJNV2d6OTZsWGJBSm4vZGtIZ0lCREMzdHA0TlhoTWlodkN4?= =?utf-8?Q?lsTpCOUfieyZwoafjdWvTG4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <1A2A6F3382BD034AA584D1B6BDD9A136@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08768308-e26f-4792-3532-08da5ffc5455 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 09:37:37.7457 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ryFqHslH8IpUz7b72RFfJvy4p1fW4q/x1ifnCR0X/7sOMjcumuUQn0fbg0IylHbthA6LFj9RR9LO/kflZiTFCn5LTqKCdQ5CGNoydWaZoLE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4737 X-Proofpoint-GUID: lIES_1e9YhpkrSQcZ5YNMjaxWVftG38H X-Proofpoint-ORIG-GUID: lIES_1e9YhpkrSQcZ5YNMjaxWVftG38H X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-07_06,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 bulkscore=0 impostorscore=0 mlxscore=0 phishscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207070037 DQpPbiAwNy4wNy4yMiAxMTozOSwgTWFyYyBaeW5naWVyIHdyb3RlOg0KDQoNCkhlbGxvIE1hcmMN Cg0KPiBPbiBTdW4sIDAzIEp1bCAyMDIyIDE2OjIyOjAzICswMTAwLA0KPiBPbGVrc2FuZHIgPG9s ZWtzdHlzaEBnbWFpbC5jb20+IHdyb3RlOg0KPj4NCj4+IE9uIDAxLjA3LjIyIDIzOjAwLCBTYW11 ZWwgSG9sbGFuZCB3cm90ZToNCj4+DQo+Pg0KPj4gSGVsbG8gU2FtdWVsDQo+Pg0KPj4+IFNvbWUg YXJjaGl0ZWN0dXJlcyBhbmQgaXJxY2hpcCBkcml2ZXJzIG1vZGlmeSB0aGUgY3B1bWFzayByZXR1 cm5lZCBieQ0KPj4+IGlycV9kYXRhX2dldF9hZmZpbml0eV9tYXNrLCB1c3VhbGx5IGJ5IGNvcHlp bmcgaW4gdG8gaXQuIFRoaXMgaXMNCj4+PiBwcm9ibGVtYXRpYyBmb3IgdW5pcHJvY2Vzc29yIGNv bmZpZ3VyYXRpb25zLCB3aGVyZSB0aGUgYWZmaW5pdHkgbWFzaw0KPj4+IHNob3VsZCBiZSBjb25z dGFudCwgYXMgaXQgaXMga25vd24gYXQgY29tcGlsZSB0aW1lLg0KPj4+DQo+Pj4gQWRkIGFuZCB1 c2UgYSBzZXR0ZXIgZm9yIHRoZSBhZmZpbml0eSBtYXNrLCBmb2xsb3dpbmcgdGhlIHBhdHRlcm4g b2YNCj4+PiBpcnFfZGF0YV91cGRhdGVfZWZmZWN0aXZlX2FmZmluaXR5LiBUaGlzIGFsbG93cyB0 aGUgZ2V0dGVyIGZ1bmN0aW9uIHRvDQo+Pj4gcmV0dXJuIGEgY29uc3QgY3B1bWFzayBwb2ludGVy Lg0KPj4+DQo+Pj4gU2lnbmVkLW9mZi1ieTogU2FtdWVsIEhvbGxhbmQgPHNhbXVlbEBzaG9sbGFu ZC5vcmc+DQo+Pj4gLS0tDQo+Pj4NCj4+PiBDaGFuZ2VzIGluIHYzOg0KPj4+ICAgIC0gTmV3IHBh dGNoIHRvIGludHJvZHVjZSBpcnFfZGF0YV91cGRhdGVfYWZmaW5pdHkNCj4+Pg0KPj4+ICAgIGFy Y2gvYWxwaGEva2VybmVsL2lycS5jICAgICAgICAgIHwgMiArLQ0KPj4+ICAgIGFyY2gvaWE2NC9r ZXJuZWwvaW9zYXBpYy5jICAgICAgIHwgMiArLQ0KPj4+ICAgIGFyY2gvaWE2NC9rZXJuZWwvaXJx LmMgICAgICAgICAgIHwgNCArKy0tDQo+Pj4gICAgYXJjaC9pYTY0L2tlcm5lbC9tc2lfaWE2NC5j ICAgICAgfCA0ICsrLS0NCj4+PiAgICBhcmNoL3BhcmlzYy9rZXJuZWwvaXJxLmMgICAgICAgICB8 IDIgKy0NCj4+PiAgICBkcml2ZXJzL2lycWNoaXAvaXJxLWJjbTYzNDUtbDEuYyB8IDQgKystLQ0K Pj4+ICAgIGRyaXZlcnMvcGFyaXNjL2lvc2FwaWMuYyAgICAgICAgIHwgMiArLQ0KPj4+ICAgIGRy aXZlcnMvc2gvaW50Yy9jaGlwLmMgICAgICAgICAgIHwgMiArLQ0KPj4+ICAgIGRyaXZlcnMveGVu L2V2ZW50cy9ldmVudHNfYmFzZS5jIHwgNyArKysrLS0tDQo+Pj4gICAgaW5jbHVkZS9saW51eC9p cnEuaCAgICAgICAgICAgICAgfCA2ICsrKysrKw0KPj4+ICAgIDEwIGZpbGVzIGNoYW5nZWQsIDIx IGluc2VydGlvbnMoKyksIDE0IGRlbGV0aW9ucygtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL2Fy Y2gvYWxwaGEva2VybmVsL2lycS5jIGIvYXJjaC9hbHBoYS9rZXJuZWwvaXJxLmMNCj4+PiBpbmRl eCBmNmQyOTQ2ZWRiZDIuLjE1ZjJlZmZkNmJhZiAxMDA2NDQNCj4+PiAtLS0gYS9hcmNoL2FscGhh L2tlcm5lbC9pcnEuYw0KPj4+ICsrKyBiL2FyY2gvYWxwaGEva2VybmVsL2lycS5jDQo+Pj4gQEAg LTYwLDcgKzYwLDcgQEAgaW50IGlycV9zZWxlY3RfYWZmaW5pdHkodW5zaWduZWQgaW50IGlycSkN Cj4+PiAgICAJCWNwdSA9IChjcHUgPCAoTlJfQ1BVUy0xKSA/IGNwdSArIDEgOiAwKTsNCj4+PiAg ICAJbGFzdF9jcHUgPSBjcHU7DQo+Pj4gICAgLQljcHVtYXNrX2NvcHkoaXJxX2RhdGFfZ2V0X2Fm ZmluaXR5X21hc2soZGF0YSksDQo+Pj4gY3B1bWFza19vZihjcHUpKTsNCj4+PiArCWlycV9kYXRh X3VwZGF0ZV9hZmZpbml0eShkYXRhLCBjcHVtYXNrX29mKGNwdSkpOw0KPj4+ICAgIAljaGlwLT5p cnFfc2V0X2FmZmluaXR5KGRhdGEsIGNwdW1hc2tfb2YoY3B1KSwgZmFsc2UpOw0KPj4+ICAgIAly ZXR1cm4gMDsNCj4+PiAgICB9DQo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvaWE2NC9rZXJuZWwvaW9z YXBpYy5jIGIvYXJjaC9pYTY0L2tlcm5lbC9pb3NhcGljLmMNCj4+PiBpbmRleCAzNWFkY2Y4OTAz NWEuLjk5MzAwODUwYWJjMSAxMDA2NDQNCj4+PiAtLS0gYS9hcmNoL2lhNjQva2VybmVsL2lvc2Fw aWMuYw0KPj4+ICsrKyBiL2FyY2gvaWE2NC9rZXJuZWwvaW9zYXBpYy5jDQo+Pj4gQEAgLTgzNCw3 ICs4MzQsNyBAQCBpb3NhcGljX3VucmVnaXN0ZXJfaW50ciAodW5zaWduZWQgaW50IGdzaSkNCj4+ PiAgICAJaWYgKGlvc2FwaWNfaW50cl9pbmZvW2lycV0uY291bnQgPT0gMCkgew0KPj4+ICAgICNp ZmRlZiBDT05GSUdfU01QDQo+Pj4gICAgCQkvKiBDbGVhciBhZmZpbml0eSAqLw0KPj4+IC0JCWNw dW1hc2tfc2V0YWxsKGlycV9nZXRfYWZmaW5pdHlfbWFzayhpcnEpKTsNCj4+PiArCQlpcnFfZGF0 YV91cGRhdGVfYWZmaW5pdHkoaXJxX2dldF9pcnFfZGF0YShpcnEpLCBjcHVfYWxsX21hc2spOw0K Pj4+ICAgICNlbmRpZg0KPj4+ICAgIAkJLyogQ2xlYXIgdGhlIGludGVycnVwdCBpbmZvcm1hdGlv biAqLw0KPj4+ICAgIAkJaW9zYXBpY19pbnRyX2luZm9baXJxXS5kZXN0ID0gMDsNCj4+PiBkaWZm IC0tZ2l0IGEvYXJjaC9pYTY0L2tlcm5lbC9pcnEuYyBiL2FyY2gvaWE2NC9rZXJuZWwvaXJxLmMN Cj4+PiBpbmRleCBlY2VmMTdjN2MzNWIuLjI3NWI5ZWE1OGM2NCAxMDA2NDQNCj4+PiAtLS0gYS9h cmNoL2lhNjQva2VybmVsL2lycS5jDQo+Pj4gKysrIGIvYXJjaC9pYTY0L2tlcm5lbC9pcnEuYw0K Pj4+IEBAIC01Nyw4ICs1Nyw4IEBAIHN0YXRpYyBjaGFyIGlycV9yZWRpciBbTlJfSVJRU107IC8v ID0geyBbMCAuLi4gTlJfSVJRUy0xXSA9IDEgfTsNCj4+PiAgICB2b2lkIHNldF9pcnFfYWZmaW5p dHlfaW5mbyAodW5zaWduZWQgaW50IGlycSwgaW50IGh3aWQsIGludCByZWRpcikNCj4+PiAgICB7 DQo+Pj4gICAgCWlmIChpcnEgPCBOUl9JUlFTKSB7DQo+Pj4gLQkJY3B1bWFza19jb3B5KGlycV9n ZXRfYWZmaW5pdHlfbWFzayhpcnEpLA0KPj4+IC0JCQkgICAgIGNwdW1hc2tfb2YoY3B1X2xvZ2lj YWxfaWQoaHdpZCkpKTsNCj4+PiArCQlpcnFfZGF0YV91cGRhdGVfYWZmaW5pdHkoaXJxX2dldF9p cnFfZGF0YShpcnEpLA0KPj4+ICsJCQkJCSBjcHVtYXNrX29mKGNwdV9sb2dpY2FsX2lkKGh3aWQp KSk7DQo+Pj4gICAgCQlpcnFfcmVkaXJbaXJxXSA9IChjaGFyKSAocmVkaXIgJiAweGZmKTsNCj4+ PiAgICAJfQ0KPj4+ICAgIH0NCj4+PiBkaWZmIC0tZ2l0IGEvYXJjaC9pYTY0L2tlcm5lbC9tc2lf aWE2NC5jIGIvYXJjaC9pYTY0L2tlcm5lbC9tc2lfaWE2NC5jDQo+Pj4gaW5kZXggZGY1YzI4ZjI1 MmUzLi4wMjVlNTEzM2M4NjAgMTAwNjQ0DQo+Pj4gLS0tIGEvYXJjaC9pYTY0L2tlcm5lbC9tc2lf aWE2NC5jDQo+Pj4gKysrIGIvYXJjaC9pYTY0L2tlcm5lbC9tc2lfaWE2NC5jDQo+Pj4gQEAgLTM3 LDcgKzM3LDcgQEAgc3RhdGljIGludCBpYTY0X3NldF9tc2lfaXJxX2FmZmluaXR5KHN0cnVjdCBp cnFfZGF0YSAqaWRhdGEsDQo+Pj4gICAgCW1zZy5kYXRhID0gZGF0YTsNCj4+PiAgICAgIAlwY2lf d3JpdGVfbXNpX21zZyhpcnEsICZtc2cpOw0KPj4+IC0JY3B1bWFza19jb3B5KGlycV9kYXRhX2dl dF9hZmZpbml0eV9tYXNrKGlkYXRhKSwgY3B1bWFza19vZihjcHUpKTsNCj4+PiArCWlycV9kYXRh X3VwZGF0ZV9hZmZpbml0eShpZGF0YSwgY3B1bWFza19vZihjcHUpKTsNCj4+PiAgICAgIAlyZXR1 cm4gMDsNCj4+PiAgICB9DQo+Pj4gQEAgLTEzMiw3ICsxMzIsNyBAQCBzdGF0aWMgaW50IGRtYXJf bXNpX3NldF9hZmZpbml0eShzdHJ1Y3QgaXJxX2RhdGEgKmRhdGEsDQo+Pj4gICAgCW1zZy5hZGRy ZXNzX2xvIHw9IE1TSV9BRERSX0RFU1RfSURfQ1BVKGNwdV9waHlzaWNhbF9pZChjcHUpKTsNCj4+ PiAgICAgIAlkbWFyX21zaV93cml0ZShpcnEsICZtc2cpOw0KPj4+IC0JY3B1bWFza19jb3B5KGly cV9kYXRhX2dldF9hZmZpbml0eV9tYXNrKGRhdGEpLCBtYXNrKTsNCj4+PiArCWlycV9kYXRhX3Vw ZGF0ZV9hZmZpbml0eShkYXRhLCBtYXNrKTsNCj4+PiAgICAgIAlyZXR1cm4gMDsNCj4+PiAgICB9 DQo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gvcGFyaXNjL2tlcm5lbC9pcnEuYyBiL2FyY2gvcGFyaXNj L2tlcm5lbC9pcnEuYw0KPj4+IGluZGV4IDBmZTJkNzlmYjEyMy4uNWViYjE3NzFiNGFiIDEwMDY0 NA0KPj4+IC0tLSBhL2FyY2gvcGFyaXNjL2tlcm5lbC9pcnEuYw0KPj4+ICsrKyBiL2FyY2gvcGFy aXNjL2tlcm5lbC9pcnEuYw0KPj4+IEBAIC0zMTUsNyArMzE1LDcgQEAgdW5zaWduZWQgbG9uZyB0 eG5fYWZmaW5pdHlfYWRkcih1bnNpZ25lZCBpbnQgaXJxLCBpbnQgY3B1KQ0KPj4+ICAgIHsNCj4+ PiAgICAjaWZkZWYgQ09ORklHX1NNUA0KPj4+ICAgIAlzdHJ1Y3QgaXJxX2RhdGEgKmQgPSBpcnFf Z2V0X2lycV9kYXRhKGlycSk7DQo+Pj4gLQljcHVtYXNrX2NvcHkoaXJxX2RhdGFfZ2V0X2FmZmlu aXR5X21hc2soZCksIGNwdW1hc2tfb2YoY3B1KSk7DQo+Pj4gKwlpcnFfZGF0YV91cGRhdGVfYWZm aW5pdHkoZCwgY3B1bWFza19vZihjcHUpKTsNCj4+PiAgICAjZW5kaWYNCj4+PiAgICAgIAlyZXR1 cm4gcGVyX2NwdShjcHVfZGF0YSwgY3B1KS50eG5fYWRkcjsNCj4+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9pcnFjaGlwL2lycS1iY202MzQ1LWwxLmMgYi9kcml2ZXJzL2lycWNoaXAvaXJxLWJjbTYz NDUtbDEuYw0KPj4+IGluZGV4IDE0MmE3NDMxNzQ1Zi4uNjg5OWUzNzgxMGE4IDEwMDY0NA0KPj4+ IC0tLSBhL2RyaXZlcnMvaXJxY2hpcC9pcnEtYmNtNjM0NS1sMS5jDQo+Pj4gKysrIGIvZHJpdmVy cy9pcnFjaGlwL2lycS1iY202MzQ1LWwxLmMNCj4+PiBAQCAtMjE2LDExICsyMTYsMTEgQEAgc3Rh dGljIGludCBiY202MzQ1X2wxX3NldF9hZmZpbml0eShzdHJ1Y3QgaXJxX2RhdGEgKmQsDQo+Pj4g ICAgCQllbmFibGVkID0gaW50Yy0+Y3B1c1tvbGRfY3B1XS0+ZW5hYmxlX2NhY2hlW3dvcmRdICYg bWFzazsNCj4+PiAgICAJCWlmIChlbmFibGVkKQ0KPj4+ICAgIAkJCV9fYmNtNjM0NV9sMV9tYXNr KGQpOw0KPj4+IC0JCWNwdW1hc2tfY29weShpcnFfZGF0YV9nZXRfYWZmaW5pdHlfbWFzayhkKSwg ZGVzdCk7DQo+Pj4gKwkJaXJxX2RhdGFfdXBkYXRlX2FmZmluaXR5KGQsIGRlc3QpOw0KPj4+ICAg IAkJaWYgKGVuYWJsZWQpDQo+Pj4gICAgCQkJX19iY202MzQ1X2wxX3VubWFzayhkKTsNCj4+PiAg ICAJfSBlbHNlIHsNCj4+PiAtCQljcHVtYXNrX2NvcHkoaXJxX2RhdGFfZ2V0X2FmZmluaXR5X21h c2soZCksIGRlc3QpOw0KPj4+ICsJCWlycV9kYXRhX3VwZGF0ZV9hZmZpbml0eShkLCBkZXN0KTsN Cj4+PiAgICAJfQ0KPj4+ICAgIAlyYXdfc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaW50Yy0+bG9j aywgZmxhZ3MpOw0KPj4+ICAgIGRpZmYgLS1naXQgYS9kcml2ZXJzL3BhcmlzYy9pb3NhcGljLmMg Yi9kcml2ZXJzL3BhcmlzYy9pb3NhcGljLmMNCj4+PiBpbmRleCA4YTNiMGMzYTFlOTIuLjNhOGM5 ODYxNTYzNCAxMDA2NDQNCj4+PiAtLS0gYS9kcml2ZXJzL3BhcmlzYy9pb3NhcGljLmMNCj4+PiAr KysgYi9kcml2ZXJzL3BhcmlzYy9pb3NhcGljLmMNCj4+PiBAQCAtNjc3LDcgKzY3Nyw3IEBAIHN0 YXRpYyBpbnQgaW9zYXBpY19zZXRfYWZmaW5pdHlfaXJxKHN0cnVjdCBpcnFfZGF0YSAqZCwNCj4+ PiAgICAJaWYgKGRlc3RfY3B1IDwgMCkNCj4+PiAgICAJCXJldHVybiAtMTsNCj4+PiAgICAtCWNw dW1hc2tfY29weShpcnFfZGF0YV9nZXRfYWZmaW5pdHlfbWFzayhkKSwNCj4+PiBjcHVtYXNrX29m KGRlc3RfY3B1KSk7DQo+Pj4gKwlpcnFfZGF0YV91cGRhdGVfYWZmaW5pdHkoZCwgY3B1bWFza19v ZihkZXN0X2NwdSkpOw0KPj4+ICAgIAl2aS0+dHhuX2FkZHIgPSB0eG5fYWZmaW5pdHlfYWRkcihk LT5pcnEsIGRlc3RfY3B1KTsNCj4+PiAgICAgIAlzcGluX2xvY2tfaXJxc2F2ZSgmaW9zYXBpY19s b2NrLCBmbGFncyk7DQo+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvc2gvaW50Yy9jaGlwLmMgYi9k cml2ZXJzL3NoL2ludGMvY2hpcC5jDQo+Pj4gaW5kZXggMzU4ZGY3NTEwMTg2Li44MjhkODFlMDJi MzcgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVycy9zaC9pbnRjL2NoaXAuYw0KPj4+ICsrKyBiL2Ry aXZlcnMvc2gvaW50Yy9jaGlwLmMNCj4+PiBAQCAtNzIsNyArNzIsNyBAQCBzdGF0aWMgaW50IGlu dGNfc2V0X2FmZmluaXR5KHN0cnVjdCBpcnFfZGF0YSAqZGF0YSwNCj4+PiAgICAJaWYgKCFjcHVt YXNrX2ludGVyc2VjdHMoY3B1bWFzaywgY3B1X29ubGluZV9tYXNrKSkNCj4+PiAgICAJCXJldHVy biAtMTsNCj4+PiAgICAtCWNwdW1hc2tfY29weShpcnFfZGF0YV9nZXRfYWZmaW5pdHlfbWFzayhk YXRhKSwgY3B1bWFzayk7DQo+Pj4gKwlpcnFfZGF0YV91cGRhdGVfYWZmaW5pdHkoZGF0YSwgY3B1 bWFzayk7DQo+Pj4gICAgICAJcmV0dXJuIElSUV9TRVRfTUFTS19PS19OT0NPUFk7DQo+Pj4gICAg fQ0KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyBiL2Ry aXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jDQo+Pj4gaW5kZXggNDZkOTI5NWQ5YTZlLi41 ZTgzMjFmNDNjYmQgMTAwNjQ0DQo+Pj4gLS0tIGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19i YXNlLmMNCj4+PiArKysgYi9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYw0KPj4+IEBA IC01MjgsOSArNTI4LDEwIEBAIHN0YXRpYyB2b2lkIGJpbmRfZXZ0Y2huX3RvX2NwdShldnRjaG5f cG9ydF90IGV2dGNobiwgdW5zaWduZWQgaW50IGNwdSwNCj4+PiAgICAJQlVHX09OKGlycSA9PSAt MSk7DQo+Pj4gICAgICAJaWYgKElTX0VOQUJMRUQoQ09ORklHX1NNUCkgJiYgZm9yY2VfYWZmaW5p dHkpIHsNCj4+PiAtCQljcHVtYXNrX2NvcHkoaXJxX2dldF9hZmZpbml0eV9tYXNrKGlycSksIGNw dW1hc2tfb2YoY3B1KSk7DQo+Pj4gLQkJY3B1bWFza19jb3B5KGlycV9nZXRfZWZmZWN0aXZlX2Fm ZmluaXR5X21hc2soaXJxKSwNCj4+PiAtCQkJICAgICBjcHVtYXNrX29mKGNwdSkpOw0KPj4+ICsJ CXN0cnVjdCBpcnFfZGF0YSAqZGF0YSA9IGlycV9nZXRfaXJxX2RhdGEoaXJxKTsNCj4+PiArDQo+ Pj4gKwkJaXJxX2RhdGFfdXBkYXRlX2FmZmluaXR5KGRhdGEsIGNwdW1hc2tfb2YoY3B1KSk7DQo+ Pj4gKwkJaXJxX2RhdGFfdXBkYXRlX2VmZmVjdGl2ZV9hZmZpbml0eShkYXRhLCBjcHVtYXNrX29m KGNwdSkpOw0KPj4+ICAgIAl9DQo+Pg0KPj4NCj4+IE5pdDogY29tbWl0IGRlc2NyaXB0aW9uIHNh eXMgYWJvdXQgcmV1c2luZyBpcnFfZGF0YV91cGRhdGVfYWZmaW5pdHkoKQ0KPj4gb25seSwgYnV0 IGhlcmUgd2UgYWxzbyByZXVzZSBpcnFfZGF0YV91cGRhdGVfZWZmZWN0aXZlX2FmZmluaXR5KCks IHNvDQo+PiBJIHdvdWxkIG1lbnRpb24gdGhhdCBpbiB0aGUgZGVzY3JpcHRpb24uDQo+Pg0KPj4g UmV2aWV3ZWQtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl cGFtLmNvbT4gIyBYZW4gYml0cw0KPiBiNCBzaG91dHMgYmVjYXVzZSBvZiB5b3VyIGVtYWlsIGFk ZHJlc3M6DQo+DQo+IE5PVEU6IHNvbWUgdHJhaWxlcnMgaWdub3JlZCBkdWUgdG8gZnJvbS9lbWFp bCBtaXNtYXRjaGVzOg0KPiAgICAgICEgVHJhaWxlcjogUmV2aWV3ZWQtYnk6IE9sZWtzYW5kciBU eXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4gIyBYZW4gYml0cw0KPiAg ICAgICBNc2cgRnJvbTogT2xla3NhbmRyIDxvbGVrc3R5c2hAZ21haWwuY29tPg0KDQpzb3JyeSBm b3IgdGhlIGluY29udmVuaWVuY2UNCg0KDQo+DQo+IEkndmUgdXNlZCB0aGUgdGFnIGFueXdheSwN Cg0KDQp0aGFuayB5b3UNCg0KDQo+ICAgYnV0IHlvdSBtYXkgd2FudCB0byBmaXggeW91ciBzZXR1 cCBpbiB0aGUNCj4gZnV0dXJlLg0KDQp5ZXMsIHdpbGwgZG8NCg0KDQo+DQo+IFRoYW5rcywNCj4N Cj4gCU0uDQo+DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 07 10:00:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 10:00:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362890.593158 (Exim 4.92) (envelope-from ) id 1o9OJ5-0007UM-Kp; Thu, 07 Jul 2022 10:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362890.593158; Thu, 07 Jul 2022 10:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OJ5-0007UF-H2; Thu, 07 Jul 2022 10:00:23 +0000 Received: by outflank-mailman (input) for mailman id 362890; Thu, 07 Jul 2022 10:00:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OJ3-0007U5-Ol; Thu, 07 Jul 2022 10:00:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OJ3-0002u6-M4; Thu, 07 Jul 2022 10:00:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OJ3-0003im-4v; Thu, 07 Jul 2022 10:00:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9OJ3-0001bf-41; Thu, 07 Jul 2022 10:00:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UBpt17szzhW7g6au5DMp/i43pbbMELGYLrqzCXtNO7Q=; b=ObDjTWe2Cj/ER/YNhp3SrBhRuD w0mHSoyVmw1VfZtjfu7z0XHb8KZA16x2Cn0Ip653ULZFYiNqoW7CEmqZzTNI6IfQZAe8uk5AyZ1ln joyq4k6yXZI86mcQ+sNEl99MWpXR/guFBQduYbqmZMrFe8pEDgwfzo2r6hsyaNpWNU3Q=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171538: FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-libvirt-pair::broken:regression xen-unstable:test-amd64-amd64-libvirt-pair:host-install/dst_host(7):broken:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Thu, 07 Jul 2022 10:00:21 +0000 flight 171538 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171538/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken in 171536 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-pair 7 host-install/dst_host(7) broken in 171536 pass in 171538 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 7 xen-install fail pass in 171536 test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail pass in 171536 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 171536 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171536 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171536 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171516 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171516 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171516 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171516 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171516 2022-07-06 01:53:06 Z 1 days Testing same since 171536 2022-07-06 18:36:51 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Charles Arnold Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken Not pushing. ------------------------------------------------------------ commit 46cbd76faf737e9fe2d57aaf335a0203f66ba21c Author: Xenia Ragiadakou Date: Wed Jul 6 13:07:43 2022 +0200 xen/time: fix MISRA C 2012 Rule 8.7 violation The variable __mon_lengths is referenced only in time.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou Acked-by: Julien Grall commit eb40ae41b658e0421e4275c14dd18c7377b0752a Author: Roger Pau Monné Date: Wed Jul 6 13:06:57 2022 +0200 x86/Kconfig: add option for default x2APIC destination mode Allow setting the default x2APIC destination mode from Kconfig to Physical. Note the default destination mode is still Logical (Cluster) mode. Signed-off-by: Roger Pau Monné Reviewed-by: Jan Beulich commit 8eeae8c2b4efefda8e946461e86cf2ae9c18e5a9 Author: Charles Arnold Date: Wed Jul 6 13:06:40 2022 +0200 libxc: fix compilation error with gcc13 xc_psr.c:161:5: error: conflicting types for 'xc_psr_cmt_get_data' due to enum/integer mismatch; Signed-off-by: Charles Arnold Reviewed-by: Jan Beulich Acked-by: Anthony PERARD commit 786049720041539409f47c6c1a1e718de490cf37 Author: Jan Beulich Date: Wed Jul 6 13:05:23 2022 +0200 Revert "EFI: preserve the System Resource Table for dom0" This reverts commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95, for breaking booting (on at least Arm64), apparently due to incomplete refactoring from an earlier version. commit 61ff2733221e3b5bae5f647d9a460c7a68a5ace8 Author: Michal Orzel Date: Mon Jun 27 15:15:39 2022 +0200 xen/common: Use unsigned int instead of plain unsigned This is just for the style and consistency reasons as the former is being used more often than the latter. Signed-off-by: Michal Orzel Reviewed-by: Juergen Gross Acked-by: Jan Beulich commit 54d8f27d0477937e1f99a414fc1ffd93d184b38a Author: Roger Pau Monne Date: Fri Apr 8 10:21:11 2022 +0200 tools/libxl: report trusted backend status to frontends Allow administrators to notify a frontend driver that it's backend counterpart is not to be trusted, so the frontend can deploy whatever mitigations required in order to secure itself. Allow such option for disk and network frontends only, as those are the only hardened ones currently supported. This is part of XSA-403 Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD commit a4d4c541f58b378bc9d499dcb554eb9fe22312c8 Author: Wei Chen Date: Tue Jul 5 13:12:15 2022 +0200 xen/arm32: avoid EFI stub wchar_t size linker warning Xen uses "-fshort-wchar" in CFLAGS for EFI common code. Arm32 is using stub.c of EFI common code for EFI stub functions. But "-fshort-wchar" CFLAG will cause a warning when build stub.c for Arm32: "arm-linux-gnueabihf-ld: warning: arch/arm/efi/built_in.o uses 2-byte wchar_t yet the output is to use 4-byte wchar_t; use of wchar_t values across objects may fail" This is because the "-fshort-wchar" flag causes GCC to generate code that is not binary compatible with code generated without that flag. Why this warning hasn't been triggered in Arm64 is because Arm64 does not use wchar type directly in any code for parameters, variables and return values. And in EFI code, wchar has been replaced by CHAR16 (the UEFI "abstraction" of wchar_t). CHAR16 has been specified as unsigned short type in typedef, the "-fshort-wchar" flag will not affect CHAR16. So Arm64 object files are exactly the same with "-fshort-wchar" and without "-fshort-wchar". We are also not using wchar in Arm32 codes, but Arm32 will embed ABI information in ".ARM.attributes" section. This section stores some object file attributes, like ABI version, CPU arch and etc. And wchar size is described in this section by "Tag_ABI_PCS_wchar_t" too. Tag_ABI_PCS_wchar_t is 2 for object files with "-fshort-wchar", but for object files without "-fshort-wchar" is 4. Arm32 GCC ld will check this tag, and throw above warning when it finds the object files have different Tag_ABI_PCS_wchar_t values. Xen need to keep "-fshort-wchar" in EFI code to force wchar to use short integers (2 bytes) instead of integers (4 bytes), but this is unnecessary for code out of EFI. So in this patch, we add "-fno-short-wchar" to override "-fshort-wchar" for Arm architectures without EFI enabled to remove above warning." Reported-and-Suggested-by: Jan Beulich Tested-by: Jan Beulich Signed-off-by: Wei Chen Reviewed-by: Jan Beulich Acked-by: Julien Grall commit c4184bf305dc14c3e150617904c40b120664efe6 Author: Jan Beulich Date: Tue Jul 5 13:11:51 2022 +0200 public: constify xsd_errors[] While in principle this could break existing users, I think such users deserve to be put in trouble. After all the table should have been const from the very beginning. Signed-off-by: Jan Beulich Reviewed-by: Juergen Gross commit 2b1ee386122a6e8bf66f5163cbda51084af6e0f4 Author: Luca Fancellu Date: Tue Jul 5 13:11:25 2022 +0200 tools/helpers: fix snprintf argument in init-dom0less.c Fix snprintf argument in init-dom0less.c because two instances of the function are using libxl_dominfo struct members that are uint64_t types, so change "%lu" to "%"PRIu64 to handle it properly when building on arm32 and arm64. Signed-off-by: Luca Fancellu Reviewed-by: Bertrand Marquis Acked-by: Anthony PERARD commit 8d410ac2c178e1dd1001cadddbe9ca75a9738c95 Author: Demi Marie Obenour Date: Tue Jul 5 13:10:46 2022 +0200 EFI: preserve the System Resource Table for dom0 The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Reviewed-by: Jan Beulich (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 10:14:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 10:14:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362898.593169 (Exim 4.92) (envelope-from ) id 1o9OWl-00016X-0q; Thu, 07 Jul 2022 10:14:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362898.593169; Thu, 07 Jul 2022 10:14:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OWk-00016Q-UR; Thu, 07 Jul 2022 10:14:30 +0000 Received: by outflank-mailman (input) for mailman id 362898; Thu, 07 Jul 2022 10:14:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OWj-00016K-HZ for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 10:14:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94458b4d-fddd-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 12:14:27 +0200 (CEST) Received: from [10.10.1.164] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165718883834873.99244568589927; Thu, 7 Jul 2022 03:13:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94458b4d-fddd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657188864; cv=none; d=zohomail.com; s=zohoarc; b=Qvt96hhaKicFIodSwQFQMxgv6LfDuM9tS3jNCFLNE6sWLtal1waL5QnVmE2sifHAbt2D1rR68MOWt1W1m+Yq/4HQkRH80u8bkbVBOiSPV6MVnbHdqRelu5/DfqiBd5kQXihhSxJmnGUmqCQUps0Ow5kHErz6h2rXTaArEM5Cnyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657188864; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=ik1sa6jEG1dGJOukf4gQK4lVK5UafSRrWJqoabAvrLY=; b=S3N64npI0YFJ+Dc15jAla5cAw42q9Llf7UchJwMxFQ7YpDuRhQLA2mN7d/x5ZOicpY1FjWyQmJ9IjBu68ewIvLwCRytdALJ6zEvC5VgbZf/QfCd5KKWPjZioMplqzvWBdVRAkbHqsQkVt1l63/eq19gSltMnSmw70n9I18lNB/Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657188864; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ik1sa6jEG1dGJOukf4gQK4lVK5UafSRrWJqoabAvrLY=; b=IPuzc0hwPPF/nJqpCVH4roqVd+/tDTeYP7X0jqI66WQTsVveeJA6M1J5E4lhp9jf NIBpwyY4QWp7QqnTEcvPDy2nu804rMPRpJgLtRkG9Q7wbxTS7H3ecIt1BXMG41pZ8/a aUT+BgLbyolGs6fjQyAhx1FfRQIH8m+2AOQcxZqQ= Message-ID: Date: Thu, 7 Jul 2022 06:12:51 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [RFC PATCH] flask: Remove magic SID setting Content-Language: en-US To: Jason Andryuk Cc: anthony.perard@citrix.com, christopher.clark@starlab.io, dgdegra@tycho.nsa.gov, scott.davis@starlab.io, wl@xen.org, xen-devel@lists.xenproject.org References: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> <20220706191325.440538-1-jandryuk@gmail.com> From: "Daniel P. Smith" In-Reply-To: <20220706191325.440538-1-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/6/22 15:13, Jason Andryuk wrote: > flask_domain_alloc_security and flask_domain_create has special code to > magically label dom0 as dom0_t. This can all be streamlined by making > create_dom0 set ssidref before creating dom0. Hmm, I wouldn't call it magical, it is the initialization policy for a domain labeling, which is specific to each policy module. I considered this approach already and my concern here is two fold. First, it now hard codes the concept of dom0 vs domU into the XSM API. There is an ever growing desire by solution providers to not have a dom0 and at most have a hardware domain if at all and this is a step backwards from that movement. Second, and related, is this now pushes the initial label policy up into the domain builder code away from the policy module and spreads it out. Hopefully Xen will evolve to have a richer set of initial domains and an appropriate initial label policy will be needed for this case. This approach will result in having to continually expand the XSM API for each new initial domain type. > create_domU is also extended to create domains with domU_t. > > xsm_ssidref_domU and xsm_ssidref_dom0 are introduced to abstract away > the details. > > Signed-off-by: Jason Andryuk > --- > Untested on ARM. Minimally tested on x86. Needs your Flask permission > changes for xenboot_t to create dom0_t and domU_t. > > This is what I was thinking would be a better way to handle SID > assignment. > > Regards, > Jason > --- > xen/arch/arm/domain_build.c | 2 ++ > xen/arch/x86/setup.c | 1 + > xen/include/xsm/dummy.h | 10 ++++++++++ > xen/include/xsm/xsm.h | 12 ++++++++++++ > xen/xsm/dummy.c | 2 ++ > xen/xsm/flask/hooks.c | 31 +++++++++++++++++-------------- > 6 files changed, 44 insertions(+), 14 deletions(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..a7e88944c2 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3281,6 +3281,7 @@ void __init create_domUs(void) > .max_grant_frames = -1, > .max_maptrack_frames = -1, > .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), > + .ssidref = xsm_ssidref_domU(), > }; > unsigned int flags = 0U; > > @@ -3438,6 +3439,7 @@ void __init create_dom0(void) > .max_grant_frames = gnttab_dom0_frames(), > .max_maptrack_frames = -1, > .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), > + .ssidref = xsm_ssidref_dom0(), > }; > > /* The vGIC for DOM0 is exactly emulating the hardware GIC */ > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index f08b07b8de..5a6086cfe3 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -771,6 +771,7 @@ static struct domain *__init create_dom0(const module_t *image, > .arch = { > .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, > }, > + .ssidref = xsm_ssidref_dom0(), > }; > struct domain *d; > char *cmdline; > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 77f27e7163..12fbc224d0 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -124,6 +124,16 @@ static XSM_INLINE void cf_check xsm_security_domaininfo( > return; > } > > +static XSM_INLINE int cf_check xsm_ssidref_dom0(XSM_DEFAULT_VOID) > +{ > + return 0; > +} > + > +static XSM_INLINE int cf_check xsm_ssidref_domU(XSM_DEFAULT_VOID) > +{ > + return 0; > +} > + > static XSM_INLINE int cf_check xsm_domain_create( > XSM_DEFAULT_ARG struct domain *d, uint32_t ssidref) > { > diff --git a/xen/include/xsm/xsm.h b/xen/include/xsm/xsm.h > index 8dad03fd3d..a6a4ffe05a 100644 > --- a/xen/include/xsm/xsm.h > +++ b/xen/include/xsm/xsm.h > @@ -55,6 +55,8 @@ struct xsm_ops { > int (*set_system_active)(void); > void (*security_domaininfo)(struct domain *d, > struct xen_domctl_getdomaininfo *info); > + int (*ssidref_dom0)(void); > + int (*ssidref_domU)(void); > int (*domain_create)(struct domain *d, uint32_t ssidref); > int (*getdomaininfo)(struct domain *d); > int (*domctl_scheduler_op)(struct domain *d, int op); > @@ -220,6 +222,16 @@ static inline void xsm_security_domaininfo( > alternative_vcall(xsm_ops.security_domaininfo, d, info); > } > > +static inline int xsm_ssidref_dom0(void) > +{ > + return alternative_call(xsm_ops.ssidref_dom0); > +} > + > +static inline int xsm_ssidref_domU(void) > +{ > + return alternative_call(xsm_ops.ssidref_domU); > +} > + > static inline int xsm_domain_create( > xsm_default_t def, struct domain *d, uint32_t ssidref) > { > diff --git a/xen/xsm/dummy.c b/xen/xsm/dummy.c > index e6ffa948f7..d46cfef0ec 100644 > --- a/xen/xsm/dummy.c > +++ b/xen/xsm/dummy.c > @@ -16,6 +16,8 @@ > static const struct xsm_ops __initconst_cf_clobber dummy_ops = { > .set_system_active = xsm_set_system_active, > .security_domaininfo = xsm_security_domaininfo, > + .ssidref_dom0 = xsm_ssidref_dom0, > + .ssidref_domU = xsm_ssidref_domU, > .domain_create = xsm_domain_create, > .getdomaininfo = xsm_getdomaininfo, > .domctl_scheduler_op = xsm_domctl_scheduler_op, > diff --git a/xen/xsm/flask/hooks.c b/xen/xsm/flask/hooks.c > index 8c9cd0f297..d6f786ea84 100644 > --- a/xen/xsm/flask/hooks.c > +++ b/xen/xsm/flask/hooks.c > @@ -544,26 +544,27 @@ static void cf_check flask_security_domaininfo( > info->ssidref = domain_sid(d); > } > > +static int cf_check flask_ssidref_dom0(void) > +{ > + return SECINITSID_DOM0; > +} > + > +static int cf_check flask_ssidref_domU(void) > +{ > + return SECINITSID_DOMU; > +} > + > static int cf_check flask_domain_create(struct domain *d, uint32_t ssidref) > { > int rc; > struct domain_security_struct *dsec = d->ssid; > - static int dom0_created = 0; > > - if ( is_idle_domain(current->domain) && !dom0_created ) > - { > - dsec->sid = SECINITSID_DOM0; > - dom0_created = 1; > - } > - else > - { > - rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, > - DOMAIN__CREATE, NULL); > - if ( rc ) > - return rc; > + rc = avc_current_has_perm(ssidref, SECCLASS_DOMAIN, > + DOMAIN__CREATE, NULL); > + if ( rc ) > + return rc; > > - dsec->sid = ssidref; > - } > + dsec->sid = ssidref; > dsec->self_sid = dsec->sid; > > rc = security_transition_sid(dsec->sid, dsec->sid, SECCLASS_DOMAIN, > @@ -1805,6 +1806,8 @@ static int cf_check flask_argo_send( > static const struct xsm_ops __initconst_cf_clobber flask_ops = { > .set_system_active = flask_set_system_active, > .security_domaininfo = flask_security_domaininfo, > + .ssidref_dom0 = flask_ssidref_dom0, > + .ssidref_domU = flask_ssidref_domU, > .domain_create = flask_domain_create, > .getdomaininfo = flask_getdomaininfo, > .domctl_scheduler_op = flask_domctl_scheduler_op, From xen-devel-bounces@lists.xenproject.org Thu Jul 07 10:19:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 10:19:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362908.593180 (Exim 4.92) (envelope-from ) id 1o9Obb-0001ku-Nb; Thu, 07 Jul 2022 10:19:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362908.593180; Thu, 07 Jul 2022 10:19:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Obb-0001kn-Km; Thu, 07 Jul 2022 10:19:31 +0000 Received: by outflank-mailman (input) for mailman id 362908; Thu, 07 Jul 2022 10:19:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Oba-0001kd-5u; Thu, 07 Jul 2022 10:19:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Oba-0003H8-1n; Thu, 07 Jul 2022 10:19:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ObZ-0004VT-9R; Thu, 07 Jul 2022 10:19:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9ObZ-0003ko-95; Thu, 07 Jul 2022 10:19:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=955bcjfJUzfqNjugc8aycnsEV8lLngHv/aAwCpISed4=; b=N/SXwO2dNQIbx5mH4QtVjIcu4J so68bsImm5q4it0hDcSWfqlClhU82ZSslSLdmwmgQOPFavoWwjhQ+arkbB34YEP116Qusn6bGTB4n kg89fMVz2Qw3LT1MHTQL68X/0kaeaAwqrWbjIDl3RrjWkxfxMdKWVJNsrY1dkz0DbiJc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171541: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=35609616a2353d23b43d6c490daed333f60c917c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 07 Jul 2022 10:19:29 +0000 flight 171541 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171541/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 35609616a2353d23b43d6c490daed333f60c917c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 727 days Failing since 151818 2020-07-11 04:18:52 Z 726 days 708 attempts Testing same since 171497 2022-07-05 04:20:30 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115185 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 10:38:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 10:38:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362916.593191 (Exim 4.92) (envelope-from ) id 1o9OtO-00051T-9Q; Thu, 07 Jul 2022 10:37:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362916.593191; Thu, 07 Jul 2022 10:37:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OtO-00051M-6Q; Thu, 07 Jul 2022 10:37:54 +0000 Received: by outflank-mailman (input) for mailman id 362916; Thu, 07 Jul 2022 10:37:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9OtM-00051F-Oj for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 10:37:52 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7737fe1-fde0-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 12:37:48 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 2679qcZo002560; Thu, 7 Jul 2022 10:37:38 GMT Received: from eur04-he1-obe.outbound.protection.outlook.com (mail-he1eur04lp2057.outbound.protection.outlook.com [104.47.13.57]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3h5ve810r7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Jul 2022 10:37:37 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by AM4PR0302MB2675.eurprd03.prod.outlook.com (2603:10a6:200:91::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 10:35:01 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2d63:5490:24b9:415b]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2d63:5490:24b9:415b%9]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 10:35:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7737fe1-fde0-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S3AWg4X8Q4Giq3Rz8CEJkdrNx96HxZi4Pz2exBKP/j2TCkrk3F3dONvkFza/iY8SqpsD9B+x/fFgCYf2TUA2HfTMtLhO5IyVKmtDoCaKeogcAk4D0bulm9CnZykKz55wmUDd7mTXksTP87TKkEYZ8hEbKk/rWEX1oeZJ7DNp0vuoaZLlTO/hTfxQ8lnfPNHWF2O43xYeWBEo3U8sjCLbbRxAi967p3tzISI5GkQxCT9eQ+6MgVbM1M3n9BOgEhTdFUr1aLXR7x8A95yMe9VU/9GA+PEC9JRx3ZxSpOBJhQe6NM/yqGwMnfAiOEn0qiW3DyitWRf/vp0NnfJH9QoB9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ba9u7UG7l6uCZKm4dIcahyaB8d9LWNf8nlzGyAamsfA=; b=TRRucJofv+YYiCCSUGIKfw8ub2LFdnrM4CU/MbPn88/1b2BOK1DY9u4qsYGkx0kiz/lSpV1tA6xJUvTrId3N/R47EujLadLexflV1wH4LAO8gmp2cRmt9wU9nOdrhUjA8Nws2VxavnzeQ4TZkPNSLnpY3AbEITHV41LC5/3Y2eWn0ifNCCOZM57f85fTdJuYMlqGojC4Hee6NjbkF3Ynf/LZrX+HLbVzSCP1MFfUmleQTOkiIsoetHHVb3LYlp27DpAW6Zrz3ZeW7pMHlxJkeGxxE6x2ZoGmbyHHzGqVmqMEZuY3RvnyRpkIJvCKOlKbBp3wRhloH/Dbe5JQorUY6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ba9u7UG7l6uCZKm4dIcahyaB8d9LWNf8nlzGyAamsfA=; b=Hl8PvunYrDe3oM4I67LbN+HvHUxS8SrL1msGDFJjeb5c/M4AsApgVxdn21HDBNoKPpqQG0EyEq/CuJ5RpflEWFIKTLXXpPvE/+tDMSxz46QMq6XYWwBhgozEIKsyhFwlO9c0JqbT+ugEB8s+fSOmuuLnsjn8uNLxFwxDHD7XwOmxUMrExejdJ3WH67IgkKCDoTzne5W8uTJqYnLR2rvkKMoPFuUyk//hCQ94VX1crEN2UFpug1pCHYYBN7to95xJlxKyiWv0BGHKIs+Mn7P5AvoI91YNnwyQOrRaywSx7XXpN5Ln5fpCZ2yBowOADD1PncjsAjDi8W4kDWv7fVIhWg== From: Oleksii Moisieiev To: "xen-devel@lists.xenproject.org" CC: Jan Beulich , Juergen Gross , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper , George Dunlap , Oleksii Moisieiev , Nick Rosbrook , Anthony PERARD , Paul Durrant Subject: [RFC] DVFS and Thermal management subsystem proposal Thread-Topic: [RFC] DVFS and Thermal management subsystem proposal Thread-Index: AQHYke02Cidd2c7KkEyfmAiMVFzcyw== Date: Thu, 7 Jul 2022 10:35:00 +0000 Message-ID: <20220707103500.GA1959452@EPUAKYIW015D> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1048ab47-e219-4768-5c9b-08da600458ab x-ms-traffictypediagnostic: AM4PR0302MB2675:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4lRd+JiJkrQ+NsVTm1ws71oaM5H0CQpfPPi38xLXDSsYuTEmxqqfeUuYui5p7q1iIEqDb8oTeOxk43sR4w7tp99cDA+lqGzyeSChDfU51yk3SCrHz8mCtM2/yZytu9T4agTAjYisI3DNJLDjt/P+lP3Xg21696HutNDDDmfsDaAX4LJXqJKqao5yMllTEIKWtUxKLENqbpS8Jjb1DeBiXywTZrxt8fR3bxQsrj80De3brGlPS5RzggT0Aqyha2lhN7HMWOEn3GfQCl2f/Trbba9OIG4TgaFNLuwk3U1/RUajYZ1fKv/t2914DmAoNiiX8nV9WYhDt0YRd/x4WUUuPsUdtgNbh4x85sUXc5Q6gD+UH4lujEFFlY2kNtDvGuCiu4RM7NkOz8FFQd/sngUVIkFbX5TcHQLUZovM+7VNImx5ya0YUF25eYOm5noZTtUrovQvO85VnEnXjcnB4hM1DxMKl40XtLtIwkAXpHQY/1BAFzrhPmnGxOshzrwoPSYqM+ZENqFTqSGSi0Jo2uIbRbaKzkRaYVBSYSdxg67fhR8KvmmgUSCo2Bu+q7IdSOWNTdIClBKPBie1HSa+wfS1I1G45fzo4eA3fbsBk4CAOLLEAjwtdMnBKhBSAkEa7QNGJ/hWnicHTyiYhg0MNuCpzed1GFotTlRy28lI9wsz+VIWFSemF49i4bK0In+foPFVrRh8WXiKrcl8UUrYQ3i3gjxilHR4ZtLDfV7Fhv1dbVRkS5izRVmHau2pBPZ8zUvCRvi6Il8QF6NvKWC+Uv5ue4QsC/sXh4YsBYEG7zivp15Se0DqVvu2zLtFCPNFHr8zY4V6o3hUqIHkyFOA4p1V+C9/0IYQBuxMa4UP5W6uwQQ6DxAJ5H/EaVghuOgJlRZ3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(396003)(39860400002)(366004)(346002)(376002)(136003)(83380400001)(86362001)(38070700005)(1076003)(186003)(966005)(9686003)(38100700002)(33656002)(66446008)(478600001)(71200400001)(41300700001)(7416002)(6916009)(64756008)(316002)(91956017)(122000001)(54906003)(5660300002)(8936002)(30864003)(6486002)(4326008)(2906002)(66946007)(76116006)(33716001)(6512007)(66556008)(55236004)(26005)(6506007)(8676002)(66476007)(21314003);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RSs0dklnV0ZEWGJOU2FnUkpqMExVanZiSWFSY3FkSkI5dnRZUklIM3IxZ05M?= =?utf-8?B?b1Q0Sld6VUNOUmZxeGN0UVlDSExNSUwyUTFZQ1BHdHBaaUNYSTQrM0ErUStL?= =?utf-8?B?bk9VV1haRHhGTEtNM1NXYncxMHhkNDgzUllwMGlJVFF6aTYyb2lZVUhPNHdE?= =?utf-8?B?WnBqekxLVmNDVnYxeE9xWHRYNWhpckQwQ1dMSWFDWVpsc1hNakU4WWxWSlpI?= =?utf-8?B?OHVJRlBEZnp3ejFnMFgxK0NXaGdPQkY2RWp5VHlTUW1TRGVzZjRMMHp0S3lQ?= =?utf-8?B?RHZCdTJYdmRiQ0xGNDlRWEp5WElwUVVkOHE0eXJjWUl5dldHaEw0UFE0UHBp?= =?utf-8?B?T085Q2VhKzY3aFVYekJyWUZYNTZJeGNLWncyMTNOMUNPL2ZhOVFLMFRzVUJ0?= =?utf-8?B?WWkzbkdxTWxvTG95SmozVmozZC91RCtpVCt3L21tdkc2SUFOZEpTcFJGMVZV?= =?utf-8?B?RGdwMHpOSXdJcVF3VHQ2cVlWNkY1Nmpjd3ZnMDdVNkdFbGE4em52N0FpNW9Y?= =?utf-8?B?Y0FicnoraHNZU1pyUlpOL0Eycm9oa0xHZGdqY05zRVQveFZsVGYyN01tTkxr?= =?utf-8?B?enl3dGMzT3BLSlM3Y0hRWndhUXdvMEExalNxbUNnaFYwcVNJWk0yQVJXWTc5?= =?utf-8?B?RjlXcXZ6Q05CZk9FbDk2bmV3WW5MM0lyY25lOSswUm8wU0xQTUdZNFBvcDBQ?= =?utf-8?B?UXgyOEpzblVZNE5Tb0NpczhVSlN1WGVvazZoTFZLeXhRRW40czhuQW5KbTQ5?= =?utf-8?B?YjFDVkdFak9pN1phSXl1WmxjSWdxeU9EZENMNFR5U3JPbXF6SGxMSmIzOEpT?= =?utf-8?B?WTJMeEtNbnd1eG90V2svS29Wa2g4WjJDdmJ3UWlRMDZmd2FQTmVua1NkTXZH?= =?utf-8?B?OHlzQ2dWbEtDQWRwRjdNaTd1OUVJTFNDVUNiYXprSWV0R3prVU8zbDRDSDhT?= =?utf-8?B?Y2hBRHZFeCtwZWRXRVBoUlJRMU03a1Y1dEpidUphc3FUUW91SEVUWWRrcTJt?= =?utf-8?B?UVh5N1dPanRvYVVDN3psZTJweDVxTkRzc21rOVc0YVc3ZllZZGFWNFVNNGhq?= =?utf-8?B?MGdBMnBSRXhoT2NCaFBUZVNjWExhbnExVkZ6SU9JbzlHVkpYVkswUm8zYUFi?= =?utf-8?B?Um9qc3RPQVVrRzlTYndlL0xKTEtzbW9EZzEvd1FOaGVQNnNnb0k5S1pCN1B4?= =?utf-8?B?Sm05RUxFRzhmNWFZZHhhVC9mS1F1RGd3SVlhdXlaT1QvcWo5Nk1udXYvYXp3?= =?utf-8?B?MDZaandQVm1HV1NXMDlqblpka1FhT0FnMHV6SDdTL0Vkb3BRN2lhMCttWGxi?= =?utf-8?B?OTJuZkwrVUhEK1FMSllGMUdwanQ1dkVuS0pPYVpkdHJITG55NVd0V2hWN0lt?= =?utf-8?B?ekdEMlJVL0tHSWNWb2NrZE91aDBSVWhqSEdRSTZDdjhVcGVDL0pvRGcvSTRp?= =?utf-8?B?MUxvTkFubWEzUThkYTJhUlhDRGRVTGdtM1lFcCsrWVdxeVBBQkt6K1RURzVi?= =?utf-8?B?bmoxNlFYLzZ3dUxrbVUzQnU4YjZpSFVZYlQyNDk4WUg1L3lzS3JtV0p1OG5k?= =?utf-8?B?VStjYWtxZHMxSFBieWVDVWNNRFRETmNuckxXeSs5b3NuUVBEdDFEN1kxb0h6?= =?utf-8?B?RVZhUHoxQjBRdXBES0Jza0FUejgrQVM1MXZYZkFJMTZDTlJLR3UzYURYVklY?= =?utf-8?B?cFNjME9QSXZaTDJ6cEhnQnR3NDI0UFIrYlQxbmpLVjZSTVlHa1VCN2lDT1ZN?= =?utf-8?B?eVdWZ05LekU4MlFMRnFkWjZTNnZuNXVCOGVXT1BMdFRadUMvRDZ1clBGMEZy?= =?utf-8?B?ZVBSRHBFMjZ6N1pEb0M1YUJXalVZUjJBU0JWQUdoNDAvcDFpL0gyNG1kUzZV?= =?utf-8?B?dEdlQ1BjRDBjRU8yNG5vSG5DRkQxSFAxOVVORGhNeGVKQy9zYUpEL1hyWHVi?= =?utf-8?B?aXIwQ1NlalIyTE9aZEtmdFdEbjZBOThwVjVwYStoTWtRaTdwT1lKaDBkREZl?= =?utf-8?B?RlZmZWIyS2NOcURqcVBwd0RZbGNtRWNuMCtqL2ppOTE3NGhwYmhpRU5UWkxm?= =?utf-8?B?MW9IUlk4YUJTb0N6T3R5WGdrQUNWK1I0US8vQmlTdVVZL09Jck8waFRvRmVT?= =?utf-8?B?TEtSY2tObUZOZUNVd3NOTHlGYlRnUVRwME5NUTF1eXBCa1RHeWJTSDErZytj?= =?utf-8?B?dFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <897A9F25DF3E5749806057D2CFA3C69E@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1048ab47-e219-4768-5c9b-08da600458ab X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 10:35:00.9482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: g4UbgR5/le9g0h5JqapcbBlabfSq+kdPt9nyNdyGDpkuM8X8e2a50+Vb+RirJf+Hot8kHmVrQvtRF5ssl132je7cMsDQvgS8jlug/m1M5pw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0302MB2675 X-Proofpoint-GUID: xKiiK1Lsgh_RspR_rUQEVpFUuaEjCAOB X-Proofpoint-ORIG-GUID: xKiiK1Lsgh_RspR_rUQEVpFUuaEjCAOB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-07_08,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 adultscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 mlxscore=0 phishscore=0 spamscore=0 malwarescore=0 impostorscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207070042 IyBTeW5vcHNpcw0KVGhpcyBkb2N1bWVudCBpcyBpbnRlbmRlZCB0byBkZXNjcmliZSB0aGUgZGVz aWduIG9mIHRoZSB0aGVybWFsIGJhc2VkIGNwdQ0KdGhyb3R0bGluZyBpbiB2aXJ0dWFsaXplZCBl bnZpcm9ubWVudHMuIFRoZSBnb2FsIGlzIHRvIHByb3ZpZGUgZ2VuZXJpYyB0aGVybWFsDQptYW5h Z2VtZW50IHN1YnN5c3RlbSwgd2hpY2ggc2hvdWxkIHdvcmsgd2l0aCBleGlzdGluZyBjcHVmcmVx IHN1YnN5c3RlbSBpbiBYRU4NCmFuZCBjb3VsZCBiZSB1c2VkIG9uIHZhcmlvdXMgYXJjaGl0ZWN0 dXJlcyBhbmQgaGFyZHdhcmUuDQoNCiMgQ3B1ZnJlcSBzdWJzeXN0ZW0gaW4gWEVODQoNCiMjIEJy aWVmIG92ZXJ2aWV3DQoNCiAgIEdvdmVybm9ycw0KKy0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KfCAr LS0tLS0tLS0tLS0tLS0tLSsgfCAgc3RydWN0IGNwdWZyZXFfZ292ZXJub3Igew0KfCB8ICBvbmRl bWFuZCAgICAgIHwgfCAgICAgIC5uYW1lDQp8ICstLS0tLS0tLS0tLS0tLS0tKyB8ICAgICAgLmdv dmVybm9yDQp8ICstLS0tLS0tLS0tLS0tLS0tKyB8ICAgICAgLmhhbmRsZV9vcHRpb24NCnwgfCAg cG93ZXJzYXZlICAgICB8IHwgIH0NCnwgKy0tLS0tLS0tLS0tLS0tLS0rIHwNCnwgKy0tLS0tLS0t LS0tLS0tLS0rIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICArLS0tLS0tLS0tLS0tLS0t LS0tLS0tLSsNCnwgfCAgcGVyZm9ybWFuY2UgICB8IHwtPmNwdWZyZXFfcmVnaXN0ZXJfZ292ZXJu b3IoKSB8ICstLS0tLS0tLS0tLS0tLS0tLS0tK3wNCnwgKy0tLS0tLS0tLS0tLS0tLS0rIHwgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8IHwgIGNwdWZyZXFfZGV2X2RydiAgfHwNCnwgKy0t LS0tLS0tLS0tLS0tLS0rIHwgICBjcHVmcmVxX3JlZ2lzdGVyX2RyaXZlcigpLT58ICstLS0tLS0t LS0tLS0tLS0tLS0tK3wNCnwgfCAgdXNlcnNwYWNlICAgICB8IHwgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICstLS0tLS0tLS0tLS0tLS0tLS0tK3wNCnwgKy0tLS0tLS0tLS0tLS0tLS0r IHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IHwgICAgIC4uLiAgICAgICAgICAgfHwN CnwgKy0tLS0tLS0tLS0tLS0tLS0rIHwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICst LS0tLS0tLS0tLS0tLS0tLS0tK3wNCnwgfCAgLi4uICAgICAgICAgICB8IHwgICAgc3RydWN0IGNw dWZyZXFfZHJpdmVyIHsgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCnwgKy0tLS0tLS0tLS0t LS0tLS0rIHwgICAgICAgLmluaXQgICAgICAgICAgICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0t LS0tLSsNCistLS0tLS0tLS0tLS0tLS0tLS0tLSsgICAgICAgLnZlcmlmeSAgICAgICAgICAgICAg ICB8ICAgIEhhcmR3YXJlICAgICAgICAgIHwNCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg LnNldHBvbGljeSAgICAgICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLnVwZGF0ZQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAudGFyZ2V0DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIC5nZXQNCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgLmdldGF2Zw0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAu ZXhpdA0KICAgICAgICAgICAgICAgICAgICAgICAgICB9DQoNCkNwdWZyZXEgc3Vic3lzdGVtIGNv bnNpc3RzIG9mIDIgcGFydHM6DQoxKSBDcHVmcmVxIGdvdmVybm9yLCB3aGljaCBzaG91bGQgYmUg cmVnaXN0ZXJlZCB1c2luZyBjcHVmcmVxX3JlZ2lzdGVyX2dvdmVybm9yDQpjYWxsOw0KMikgQ3B1 ZnJlcSBkcml2ZXIsIHdoaWNoIHByb3ZpZGVzIGFjY2VzcyB0byB0aGUgaGFyZHdhcmUgc2hvdWxk IGJlIHJlZ2lzdGVyZWQNCnVzaW5nIGNwdWZyZXFfcmVnaXN0ZXJfZHJpdmVyIGNhbGwuDQoNCiMj IEhhcmR3YXJlIGRyaXZlcnMNCg0KVGhlcmUgYXJlIHR3byBDcHVmcmVxIGhhcmR3YXJlIGRyaXZl cnMgaW1wbGVtZW50ZWQgYnkgdXMgKHNlZSBBcHBlbmRpeCAxIGFuZA0KQXBwZW5kaXggMikgdG8g cHJvdmlkZSBzdXBwb3J0IGZvciBSY2FyLTMgYW5kIGkuTVg4IGJvYXJkcy4gVGhvc2UgZHJpdmVy cyBhcmUNCmRlc2lnbmVkIHRvIHN1cHBvcnQgdGhlcm1hbCB0aHJvdHRsaW5nIHN1YnN5c3RlbS4g VGhleSBhcmUgZ29pbmcgdG8gYmUgdGhlIHBhcnQNCm9mIHRoZSBjb250cmlidXRpb24gcGFja2Fn ZS4NCg0KIyMgQ29uZmlndXJhdGlvbiBvcHRpb25zDQoNCkNwdWZyZXEgc3Vic3lzdGVtIGVuYWJs ZXMgd2l0aCB0aGUgZm9sbG93aW5nIGNvbmZpZyBwYXJhbToNCistLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSsNCkNPTkZJR19IQVNfQ1BVRlJFUT15DQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQoNCkNwdWZy ZXEgZGV2aWNlIGRyaXZlciBpcyBwbGF0Zm9ybSBzcGVjaWZpYyBhbmQgY2FuIGJlIHNlbGVjdGVk IG9uIGNvbXBpbGUgdGltZQ0KYnkgc2V0dGluZyBjb25maWcgcGFyYW1ldGVyOg0KKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tKw0KQ09ORklHX0NQVUZSRVFfWFhYDQorLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0r DQpXaGVyZSBYWFggaXMgdGhlIHBsYXRmb3JtIG5hbWUuDQpBZGRpdGlvbmFsIGNvbmZpZ3VyYXRp b24gaXMgYWxzbyBwb3NzaWJsZS4gVGhpcyBjb3VsZCBiZSBkb25lIGJ5IGRldmljZSB0cmVlDQpu b2RlcyBvciB1c2luZyBBQ1BJIGNvbmZpZ3VyYXRpb24uIEN1cnJlbnQgaW1wbGVtZW50YXRpb24g c3VwcG9ydHMgb25seQ0KZGV2aWNlLXRyZWUgY29uZmlndXJhdGlvbi4NCkRldmljZSB0cmVlIGNv bmZpZ3VyYXRpb24gaXMgZGVmaW5lZCBieSB0aGUgY3B1ZnJlcSBkcml2ZXIgaW1wbGVtZW50YXRp b24gYW5kDQptb3N0bHkgdXNpbmcgZGV2aWNlLXRyZWUgYmluZGluZ3MgZnJvbSBsaW51eCBrZXJu ZWwuIExpbnV4IGtlcm5lbCBkZWZpbmVzDQpjb21tb24gYW5kIHBsYXRmb3JtIHNwZWNpZmljIGNw dWZyZXEgYmluZGluZ3MuDQpTZWUgWzBdIC9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvY3B1ZnJlcSBhbmQNClswXSAvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL29w cCBmb3IgZGV0YWlscy4NClNvbWUgZXhhbXBsZXMgY2FuIGJlIGZvdW5kIGluIEFwcG5kaXggMSBh bmQgQXBwZW5kaXggMi4NCg0KQ3B1ZnJlcSBkcml2ZXIgaW5pdGlhbGl6ZXMgb24gWGVuIHN0YXJ0 IGJhc2VkIG9uIHRoZSBjb25maWd1cmF0aW9uIHBhcmFtZXRlcnMuDQpPbmx5IG9uZSBjcHVmcmVx IGRldmljZSBkcml2ZXIgY291bGQgYmUgZW5hYmxlZCBvbiBzeXN0ZW0uIFN3aXRjaGluZyB0byB0 aGUgZGlmZg0KQ3B1ZnJlcSBoYXJkd2FyZSBkcml2ZXIgc2hvdWxkIGJlIHByb2JlZCBiYXNlZCBv biBEZXZpY2UtdHJlZSBub2RlcyBvciBBQ1BJDQpjb25maWd1cmF0aW9uLg0KDQpUaGUgZGVmYXVs dCBnb3Zlcm5vciBjYW4gYmUgc2V0IGZyb20gdGhlIHhlbi1ib290YXJncyBhbmQgaGFzIHRoZSBm b2xsb3dpbmcNCmZvcm1hdDoNCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCmNwdWZyZXE9eGVuOm9u ZGVtYW5kDQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQoNCnhsLmNmZyAoZ3Vlc3QgY29uZmlndXJh dGlvbiBmaWxlcykgc3VwcG9ydCB0aGUgZm9sbG93aW5nIGNvbmZpZ3VyYXRpb24gb3B0aW9uOg0K Z3Vlc3RwbS4gSXQgZGVmaW5lcyBQTSBwb2xpY3kgZm9yIHRoZSBnaXZlbiBndWVzdC4gRm9yIGV4 YW1wbGU6DQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQpndWVzdHBtID0gIjAtNyINCistLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsNCmd1ZXN0cG0gPSAiMC03IiBsaW5lIGFsbG93cyBndWVzdCB0byBjaG9v c2UgT1BQIGxldmVscyBmcm9tIDAgdG8gNyBvdXQgb2YgMTUuDQpIaWdoZXIgT1BQIGxldmVscyB3 aWxsIGJlIGlnbm9yZWQgYnkgaHlwZXJ2aXNvci4NCg0KDQojIFhFTiBEeW5hbWljIFRoZXJtYWwg bWFuYWdlbWVudCBkZXNpZ24NCg0KIyMgU3lub3BzaXMNCg0KSW50cm9kdWNpbmcgdGhlIGRlc2ln biBvZiB0aGUgRHluYW1pYyBUaGVybWFsIE1hbmFnZW1lbnQgZm9yIFhlbiBoeXBlcnZpc29yLg0K VGhpcyBmZWF0dXJlIGlzIGFuIGVuaGFuY2VtZW50IG9mIHRoZSBYZW4gRFZGUyBmZWF0dXJlIGFu ZCB3aWxsIGFsbG93IHN5c3RlbQ0KYWRtaW4gdG8gY29uZmlndXJlIGRpZmZlcmVudCB0aGVybWFs IGdvdmVybm9ycyB3aGljaCB3aWxsIHBlcmZvcm0gQ1BVDQp0aHJvdHRsaW5nLCBiYXNlZCBvbiB0 aGUgQ1BVIGNvcmVzIHRlbXBlcmF0dXJlIGFuZCB0aGVybWFsIGNvbmZpZ3VyYXRpb24uDQoNCiMj IFRvcCBsZXZlbCBkZXNpZ24uDQoNCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLSsNCnwgICAgWEVOICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwNCnwgICAgICAgICAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tKyAgICAgICAgICAg IHwNCnwgICAgICAgICAgICAgIHwgICAgICBUaGVybWFsICAgICAgfCAgICAgICAgICAgIHwNCnwg ICAgICAgKy0tLS0tPnwgICAgIEdvdmVybm9yICAgICAgfCAgICAgICAgICAgIHwNCnwgICAgICAg fCAgICAgICstLS0tLS0tLS18LS0tLS0tLS0tKyAgICAgICAgICAgIHwNCnwgICAgICAgfCAgICAg ICAgICAgICAgICB8ICAgICAgICAgICAgICAgICAgICAgIHwNCnwgICAgICAgfCAgICAgICAgICAg ICAgICArLS0tLS0tLSsgICAgICAgICAgICAgIHwNCnwgICAgICAgfCAgICAgICAgICAgICAgICAg ICAgICAgIHwgICAgICAgICAgICAgIHwNCnwgICstLS0tLS0tLS0tLS0tLS0tLS0rICArLS0tLS0t LS0tLS0tLS0tLS0tKyAgIHwNCnwgIHwgICBUaGVybWFsICAgICAgICB8ICB8ICAgIENwdWZyZXEg ICAgICAgfCAgIHwNCnwgIHwgICBEcml2ZXIgICAgICAgICB8ICB8ICAgICAgICAgICAgICAgICAg fCAgIHwNCnwgICstLS0tLS0tLS0tLS0tLS0tLS0rICArLS0tLS0tLS0tLS0tLS0tLS0tKyAgIHwN CnwgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwNCistLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCiAgICAgICAgICAg ICAgICAgICAgXg0KICAgICAgICAgICAgICAgICAgICB8DQogICAgICAgICAgICAgICAgICAgIHwN CiAgICAgICAgICAgKy0tLS0tLS0tdi0tLS0tLS0tKw0KICAgICAgICAgICB8ICAgICAgICAgICAg ICAgICB8DQogICAgICAgICAgIHwgICAgSGFyZHdhcmUgICAgIHwNCiAgICAgICAgICAgfCAgICAg ICAgICAgICAgICAgfA0KICAgICAgICAgICArLS0tLS0tLS0tLS0tLS0tLS0rDQoNCg0KIyMgVGhl cm1hbCBtYW5hZ2VtZW50IHN1YnN5c3RlbSBkZXNpZ24gaW4gWEVODQoNCiArLS0tLS0tLS0tLS0t LS0tLS0tKw0KIHwgKy0tLS0tLS0tLS0tLS0tKyB8DQogfCB8ICBwb3dlcnNhdmUgICB8IHwgICAg ICAgICAgICAgICBzdHJ1Y3QgdGhlcm1hbF9nb3Zlcm5vciB7DQogfCArLS0tLS0tLS0tLS0tLS0r IHwgICAgICAgICAgICAgICAgICAgLm5hbWUNCiB8ICstLS0tLS0tLS0tLS0tLSsgfCAgICAgICAg ICAgICAgICAgICAuZ292ZXJub3INCiB8IHwgICBzdGVwd2lzZSAgIHwgfDwtLS0tLS0tLS0tLS0r ICAgICAuaGFuZGxlX29wdGlvbg0KIHwgKy0tLS0tLS0tLS0tLS0tKyB8ICAgICAgICAgICAgIHwg fQ0KIHwgKy0tLS0tLS0tLS0tLS0tKyB8ICAgICAgICAgICAgIHwNCiB8IHwgICAgIC4uLiAgICAg IHwgfCAgICAgICAgICAgICB8DQogfCArLS0tLS0tLS0tLS0tLS0rIHwgICAgICAgICAgICAgfA0K ICstLS0tLS0tLS0tLS0tLS0tLS0rICAgICAgICAgICAgIHYNCiAgICAgICAgICArLS0tLS0tLS0t LS0tLS0tLS0+cmVnaXN0ZXJfdGhlcm1hbF9nb3Zlcm5vcigpDQogICAgICAgICAgfA0KKy0tLS0t LS0tLXYtLS0tLS0tLSsgICAgICAgICAgICAgICAgICAgICAgICAgUG9sbGluZyB0ZW1wZXJhdHVy ZQ0KfCAgIGR5bl90aGVybWFsICAgIHw8LS0tLS0tLS0rICAgICAgICAgICAgICstLS0tLS0tLS0t LS0tLS0tLS0tLSsNCistLS0tLS0tLS0tLS0tLS0tLS0rICAgICAgICAgKy0tLS0tLS0tLS0tLT58 ICBwb2xsaW5nX2hhbmRsZXIoKSB8DQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQogcmVn aXN0ZXJfdGhlcm1hbF9kcml2ZXIoKSAgICAgICAgICAgICAgICB8IF9fY3B1ZnJlcV9kcml2ZXJf dGFyZ2V0KEhJR0gpIHwNCiAgICAgICAgICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KICAgICAgICAgICAgICAgICAgICAg ICBzdHJ1Y3QgdGhlcm1hbF9kcml2ZXIgeyAgIFNldCBISUdIIHByaW9yaXR5IHRvIHRoZQ0KICst LS0tLS0tLS0tLS0tLS0tLS0rICAgICAubmFtZSAgICAgICAgICAgICAgICAgIHRhcmdldCBwb2xp Y3kuIFNvIHRoaXMNCiB8ICB0aGVybWFsX2RyaXZlciAgfCAgICAgLmdldF90cmlwcyAgICAgICAg ICAgICBjb25maWd1cmF0aW9uIHdpbGwgb3ZlcnJpZGUNCiArLS0tLS0tLS0tLS0tLS0tLS0tKyAg ICAgLmdldF90ZW1wICAgICAgICAgICAgICBjcHVmcmVxIGdvdmVybm9yDQogICAgICAgICAgICAg ICAgICAgICAgICAgIC5zZXRfYWxhcm1fdGVtcA0KICstLS0tLS0tLS0tLS0tLS0tLS0rICB9DQog fCB0aGVybWFsX3NlbnNvcnMgIHwNCiArLS0tLS0tLS0tLS0tLS0tLS0tKw0KDQpEeW5hbWljIHRo ZXJtYWwgZmVhdHVyZSBjb25zaXN0cyBvZiB0aGUgMiBlbnRpdGllczogdGhlcm1hbCBnb3Zlcm5v ciBhbmQgZHJpdmVyDQoNClRoZXJtYWwgZ292ZXJub3Igc2hvdWxkIGJlIHJlZ2lzdGVyZWQgdXNp bmcgcmVnaXN0ZXJfdGhlcm1hbCBnb3Zlcm5vciBhbmQgd2lsbA0KcHJvdmlkZSB0aGUgZm9sbG93 aW5nIGludGVyZmFjZToNCg0KKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0Kc3RydWN0IHRoZXJtYWxf Z292ZXJub3Igew0KICAgIC5uYW1lID0gIm5hbWUiDQogICAgLmdvdmVybm9yID0gZ292X2RicywN CiAgICAuaGFuZGxlX29wdGlvbiA9IGhhbmRsZV9vcHQNCiAgICAudGVtcF9oYW5kbGVyID0gdF9o YW5kbGVyDQp9DQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQoNCldoZXJlIGdvdmVybm9yIHNob3Vs ZCBwcm9jZXNzIGNvbW1hbmRzIChzdGFydC9zdG9wL2V2ZW50KS4gRXZlbnQNCmNvbW1hbmQgaXMg bmVlZGVkIGlmIGh3IGRyaXZlciBzdXBwb3J0cyB0ZW1wX2FsYXJtIHNldC4gR292ZXJub3IgaXMg YWxzbw0KcmVzcG9uc2libGUgZm9yIHBvbGxpbmcgdGVtcGVyYXR1cmUgYW5kIGRvIHRocm90dGxp bmcgYnkgc2V0dGluZyBjcHVmcmVxDQpwb2xpY3kuIENwdWZyZXEgcG9saWN5IHdpbGwgYmUgc2V0 IHdpdGggdGhlIHByaW9yaXR5LCBISUdIIHRvIG92ZXJyaWRlIGNvbW1hbmRzDQpmcm9tIGNwdWZy ZXFfZ292ZXJub3IuIENvbW1hbmRzIGZyb20gY3B1ZnJlcSBnb3Zlcm5vciBzaG91bGQgYmUgaWdu b3JlZCB1bnRpbA0KdGhyb3R0bGluZyBpcyBpbiBwcm9ncmVzcy4NCg0KVGhlcm1hbCBkcml2ZXIg c2hvdWxkIHByb3ZpZGUgYWNjZXNzIHRvIHRoZSBoYXJkd2FyZSBhbmQgZ2l2ZSBpbnRlcmZhY2Ug dG8gdGhlDQppbmZvcm1hdGlvbi4gVGhlcm1hbCBkcml2ZXIgaXMgcmVzcG9uc2libGUgZm9yIHRo ZSBjb25maWd1cmF0aW9uIGFuZCBzaG91bGQNCnByb3ZpZGUgdGhpcyBjb25maWd1cmF0aW9uIHRv IGdvdmVybm9yLiBXZSBhcmUgcGxhbm5pbmcgdG8gcHJvdmlkZSBzdXBwb3J0IG9mDQp0aGUgUmNh ci0zIGFuZCBpLk1YOCBib2FyZHMgKHNlZSBBcHBlbmRpeCAzIGFuZCBBcHBlbmRpeCA0KS4NCg0K Ky0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KdGhlcm1hbF9kcml2ZXIgew0KICAgICAubmFtZQ0KICAg ICAuZ2V0X3RyaXBzDQogICAgIC5nZXRfdGVtcA0KICAgICAuc2V0X2FsYXJtX3RlbXANCn0NCist LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLSsNCg0KIyMgR292ZXJub3JzDQoNCkluIExpbnV4IEtlcm5lbCB0 aGVyZSBpcyBhbiBlbnRpdHkgY2FsbGVkIHRoZXJtYWwgZ292ZXJub3IsIHdoaWNoDQppcyByZXNw b25zaWJsZSBmb3IgdGhlIHN5c3RlbSBiZWhhdmlvdXIgd2hlbiBjcml0aWNhbCB0ZW1wZXJhdHVy ZXMgd2VyZQ0KcmVhY2hlZC4gVGhlIGZvbGxvd2luZyBnb3Zlcm5vcnMgYXJlIGdvaW5nIHRvIGJl IGltcGxlbWVudGVkIGluIFhlbjoNCg0KIyMjIFBvd2Vyc2F2ZSBnb3Zlcm5vcg0KDQpTZXRzIG1p bmltYWwgY3B1IGZyZXF1ZW5jeSBpZiBwYXNzaXZlIHRyaXAgdGVtcGVyYXR1cmUgd2FzIHJlYWNo ZWQuIFJlYm9vdGluZw0KYm9hcmQgb24gY3JpdGljYWwgdGVtcGVyYXR1cmUuDQoNCiMjIyMgRmFp ci1zaGFyZSBnb3Zlcm5vcg0KDQpVc2luZyAzIHBhcmFtZXRlcnMgdG8gY2FsY3VsYXRlIHRocm90 dGxlIHN0YXRlOiBQMTogbWF4IHRocm90dGxlIHN0YXRlOyBQMjoNCnBlcmNlbnRhZ2VbSV0vMTAw LiBTaG93cyBob3cgZWZmZWN0aXZlIGRldmljZSBpczsgUDM6DQpjdXJfdHJpcF9sZXZlbC9tYXhf bm9fb2ZfdHJpcHMuIE5ldyBjcHUgc3RhdGUgb2YgQ1BVID0gUDMgKiBQMiAqIFAxDQoNCiMjIyMg U3RlcC13aXNlIGdvdmVybm9yDQoNClNlcXVlbnRpYWxseSBzd2l0Y2hpbmcgc3RhdGUgdXBwZXIg aWYgdGVtcGVyYXR1cmUgaXMgcmlzaW5nIGFuZCBsb3dlcg0Kb3RoZXJ3aXNlLg0KDQojIyMjIFVz ZXItc3BhY2UgZ292ZXJub3INCg0KTm90aWZpZXMgZ3Vlc3RzIHdoZW4gdHJpcCB0ZW1wZXJhdHVy ZSB3YXMgcmVhY2hlZCBieSBzZXR0aW5nIGZsYWcgaW4geGVuaHlwZnMuDQoNCiMjIyBUaGVybWFs IGdvdmVybm9yIGNvbmZpZ3VyYXRpb24NCg0KVGhlcm1hbCBnb3Zlcm5vciBzaG91bGQgYmUgZW5h YmxlZCBpbiBYZW4gY29uZmlnIHBhcmFtdGVyZXJzOg0KKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0K Q09ORklHX0hBU19USEVSTUFMPXkNCkNPTkZJR19HT1ZfVEhFUk1BTF9GQUlSX1NIQVJFPXkNCkNP TkZJR19HT1ZfVEhFUk1BTF9TVEVQX1dJU0U9eQ0KQ09ORklHX0dPVl9USEVSTUFMX1BPV0VSU0FW RT15DQpDT05GSUdfR09WX1RIRVJNQUxfVVNFUlNQQUNFPXkNCistLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LSsNCldoZXJlIENPTkZJR19IQVNfVEhFUk1BTCBlbmFibGVzIER5bmFtaWMgVGhlcm1hbCBNYW5h Z2VtZW50LiBPdGhlciBwYXJhbWV0ZXJzDQplbmFibGUgZGlmZmVyZW50IHRoZXJtYWwgZ292ZXJu b3JzIGluIHN5c3RlbS4gVGhlIGRlZmF1bHQgZ292ZXJub3IgaXMgU1RFUF9XSVNFDQpvciB0aGUg Zmlyc3QgaW4gbGlzdCBpZiB3YXNu4oCZdCBzZXQgaW4gY21kbGluZSBvciBTVEVQX1dJU0Ugd2Fz IG5vdCBlbmFibGVkLg0KDQpJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uLCB0aGVybWFsIGRyaXZl ciBpcyB1c2luZyBkZXZpY2UtdHJlZSBub2RlcyB0byBwcm9iZQ0KZGV2aWNlIGRyaXZlci4gQUNQ SSBjb25maWd1cmF0aW9uIGlzIG5vdCB0aGUgcGFydCBvZiBjdXJyZW50IGltcGxlbWVudGF0aW9u Lg0KVGhlcm1hbCBkZXZpY2UgZHJpdmVyIGRlZmluZXMgdGhlIGRldmljZS10cmVlIGNvbmZpZ3Vy YXRpb24gZm9ybWF0IGJhc2VkIG9uDQp0aGVybWFsIGRldmljZSB0cmVlIGJpbmRpbmdzIGZyb20g dGhlIExpbnV4IGtlcm5lbCBzb3VyY2UgY29kZS4NClNlZSBbMF0gL0RvY3VtZXRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3RoZXJtYWwgZm9yIGRldGFpbHMuDQoNClRoZXJtYWwgZ292ZXJub3Ig Y2FuIGJlIGNvbmZpZ3VyZWQgaW4geGVuLWJvb3RhcmdzIGNvbW1hbmQgbGluZSBieSBhZGRpbmcg dGhlDQpmb2xsb3dpbmcgcGFyYW1ldGVyOg0KDQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQp0aGVy bWFsPXhlbjpzdGVwd2lzZQ0KKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KDQpYZW5oeXBmcyB1dGls aXR5IGNhbiBiZSB1c2VkIHRvIGdpdmUgdGhlIGN1cnJlbnQgc3RhdGUgb2YgdGhlIHRoZXJtYWw6 DQorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQo+eGVuaHlwZnMgbHMgL3RoZXJtYWwvDQp0aGVybWFs X2dvdmVybm9yDQphdmFpbF9nb3Zlcm5vcnMNClRyaXBzDQpUaHJvdHRsZQ0KY3VycmVudF90ZW1w DQo+eGVuaHlwZnMgY2F0IC90aGVybWFsL3RoZXJtYWxfZ292ZXJub3INCnN0ZXB3aXNlDQo+eGVu aHlwZnMgY2F0IC90aGVybWFsL2F2YWlsX2dvdmVybm9ycw0Kc3RlcHdpc2UgcG93ZXJzYXZlIHVz ZXJzcGFjZQ0KPnhlbmh5cGZzIGNhdCAvdGhlcm1hbC90cmlwcy8NCjEwNyhwYXNzaXZlKSAxMTco Y3JpdGljYWwpDQo+eGVuaHlwZnMgY2F0IC90aGVybWFsL3Rocm90dGxlDQowDQo+eGVuaHlwZnMg Y2F0IC90aGVybWwvY3VycmVudF90ZW1wLzANCjg1KGNsdXN0ZXIgMCkNCj54ZW5oeXBmcyBjYXQg L3RoZXJtbC9jdXJyZW50X3RlbXAvMQ0KODcoY2x1c3RlciAxKQ0KKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tKw0KDQpUaGVybWFsIGdvdmVybm9yIGNhbiBiZSBjaGFuZ2VkIGJ5IHRoZSBmb2xsb3dpbmcg Y29tbWFuZDoNCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj54ZW5oeXBmcyB3cml0ZSAvdGhlcm1h bC90aGVybWFsX2dvdmVybm9yIHBvd2Vyc2F2ZQ0KKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tKw0KDQoj IyBTdW1tYXJ5DQoNClRoZSBwcm9wb3NlZCBmZWF0dXJlIHdpbGwgcHJvdmlkZSBzbWFydGVyIHdh eSB0byBkbyB0aHJvdHRsaW5nIGluIGNhc2Ugb2YNCnRoZXJtYWwgYWxhcm0gaW4gWEVOLg0KDQoj IEFwcGVuZGl4IDEuIFJjYXItMyBjcHVmcmVxIGRyaXZlcg0KVGhlIHNvbHV0aW9uIGZvciBSY2Fy IEdlbjMgcGxhdGZvcm0gY29uc2lzdHMgb2YgdGhlIGZvbGxvd2luZyBzb2Z0d2FyZQ0KY29tcG9u ZW50czoNCuKAoiBBUk0gVHJ1c3RlZCBGaXJtd2FyZSwgd2hpY2ggYWN0cyBhcyBTQ1AgbW9kdWxl Lg0K4oCiIFhFTiBIeXBlcnZpc29yLCB3aGljaCBiZWFycyBzZXQgb2YgY3B1ZnJlcSBnb3Zlcm5v cnMuDQpBUk0gVHJ1c3RlZCBGaXJtd2FyZSBpbXBsZW1lbnRzIFNDTUkgcHJvdG9jb2wgd2l0aCBT TUNzIGFzIHRoZSBtYWlsYm94DQppbnRlcmZhY2UuIEFSTSBURiBpcyBjYXBhYmxlIG9mIGNvbnRy b2xsaW5nIHBlcmZvcm1hbmNlIHN0YXRlIG9mIGJvdGggQ29ydGV4DQpBNTcgY2x1c3RlciBhbmQg Q29ydGV4IEE1MyBjbHVzdGVyLg0KDQpBY3RpdmUgZ292ZXJub3IgZGVzaWRlcywgd2hpY2ggY2x1 c3RlciBzaG91bGQgYmUgYWx0ZXJlZCBhbmQgY29uZmlndXJlDQpwZXJmb3JtYW5jZSBieSBzZXR0 aW5nIE9QUCBsZXZlbCBpbiBIVy4NCkhXIGRyaXZlciBhY2Nlc3MgQVRGIHZpYSBTQ01JIHByb3Rv Y29sIGFuZCBzZXQncyB0aGUgcmVxdWVzdGVkIHBlcmZvcm1hbmNlDQpsZXZlbC4NCg0KIyBBcHBl bmRpeCAyIGkuTVg4IGNwdWZyZXEgZHJpdmVyDQpUaGUgc29sdXRpb24gZm9yIGkuTVg4IGlzIHNp bWlsYXIgdG8gdGhlIFJjYXItMyBhcyBpdCBoYXMgdGhlIHNhbWUgY29tcG9uZW50cw0KaW52b2x2 ZWQ6DQoqIEFSTSBUcnVzdGVkIEZpcm13YXJlLCB3aGljaCBwcm92aWRlcyBTQ1AgcHJvdG9jb2wu DQoqIFhFTiBIeXBlcnZpc29yLg0KKiBTQyBGaXJtd2FyZSB3aXRoIGFsdGVycyBwZXJmb3JtYW5j ZSBsZXZlbC4NCg0KaS5NWDggY3B1ZnJlcSBkcml2ZXIgdXNpbmcgU0NGVyBpbnRlcmZhY2UgdG8g YWNjZXNzIHRvIGNwdSBjbHVzdGVyczogQTUzIGFuZA0KQTcyLiBBUk0gVEYgaXMgdXNlZCB0byBj b250cm9sIGNwdSBmcmVxdWVuY3kgb2YgYm90aCBjbHVzdGVycyB1c2luZyBTTUMNCm1lc3NhZ2Vz LiBTQ0ZXIGludGVyZmFjZSBjYW4ndCBiZSB1c2VkIHRvIGNvbnRyb2wgY3B1IHBlcmZvcm1hbmNl LCBqdXN0IHRvIGdldA0KdGhlIGV4aXN0aW5nIHBlcmZvcm1hbmNlIHN0YXRlIGJlY2F1c2Ugb2Yg dGhlIGJvYXJkIGltcGxlbWVudGF0aW9uIGxpbWl0YXRpb25zLg0KDQpDcHVmcmVxIGRldmljZSBk cml2ZXIgdXNpbmcgZGV2aWNlLXRyZWUgYmluZGluZ3MgdG8gcmVjZWl2ZSB0byBvcHAtdGFibGVz DQpjb25maWd1cmF0aW9uLiBTZWUgWzBdIC9Eb2N1bWV0YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9vcHAgZm9yIGRldGFpbHMuDQoNCiMgQXBwZW5kaXggMyBSY2FyLTMgdGhlcm1hbCBkcml2ZXIN ClRoZSBzb2x1dGlvbiBmb3IgUmNhciBHZW4zIHBsYXRmb3JtIGFsbG93cyB0aGVybWFsIHN1YnN5 c3RlbSB0byBhY2Nlc3MgdGhlDQpoYXJkd2FyZSBhbmQgcmVhZCBzZW5zb3JzIHZhbHVlcy4gRHJp dmVyIGlzIGNvbmZpZ3VyZWQgZnJvbSB0aGUgZGV2aWNlLXRyZWUuDQpIYXJkd2FyZSBpcyBhYmxl IHRvIGdlbmVyYXRlIElSUSB3aGVuIGNyaXRpY2FsIHRlbXBlcmF0dXJlIHdhcyByZWFjaGVkLiBU aGVybWFsDQpkcml2ZXIgaGFuZGxlcyB0aGlzIElSUSBhbmQgc2VuZCBldmVudCB0byB0aGVybWFs IGdvdmVybm9yLg0KDQpUaGVtYWwgZGV2aWNlIGRyaXZlciB1c2luZyByY2FyLWdlbjMtdGhlcm1h bCBiaW5kaW5ncyBmb3IgdGhlIGNvbmZpZ3VyYXRpb24uDQpTZWUgWzBdIERvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy90aGVybWFsL3JjYXItZ2VuMy10aGVybWFsLnlhbWwgZm9yDQpk ZXRhaWxzLiBET01JRF9YRU4gb3duZXIgaXMgc2V0IHRvIHRoZSBwcm9jZXNzZWQgbm9kZXMsIHNv IHRob3NlIG5vZGVzIHNoYWxsDQpub3QgYmUgcGFzc2VkIHRvIHRoZSBndWVzdHMuDQoNCiMgQXBw ZW5kaXggNCBpLk1YOCB0aGVybWFsIGRyaXZlcg0KVGhlIHNvbHV0aW9uIGZvciBpLk1YOCBib2Fy ZCBhbGxvd3MgdGhlcm1hbCBzdWJzeXN0ZW0gdG8gcmVhZCB0aGVybWFsIHNlbnNvcnMNCnVzaW5n IFNDRlcgaW50ZXJmYWNlIHRvIGFjY2VzcyBoYXJkd2FyZS4gQ3VycmVudCBpbXBsZW1lbnRhdGlv biBmb2xsb3dzIHRoZQ0KaW1wbGVtZW50YXRpb24gb2YgaW14X3NjX3RoZXJtYWwgaW4gbGludXgg a2VybmVsLiBBbGFybSBldmVudHMgYXJlIHNlbnQgYmFzZWQNCm9uIHBvbGxpbmcgaW4gdGhlIHNl cGFyYXRlIHRocmVhZCAodXNlZCB0aW1lciBtZWNoYW5pc20pLiBQb2xsaW5nIHRpbWVvdXRzIGFy ZQ0Kc2V0IGluIHRoZSBEZXZpY2UtdHJlZSBub2RlLg0KDQppLk1YOCB0aGVybWFsIGRldmljZSBk cml2ZXIgdXNpbmcgaW14LXRoZXJtYWwgZGV2aWNlIHRyZWUgYmluZGluZ3MgZm9yIHRoZQ0KY29u ZmlndXJhdGlvbi4NClNlZSBbMF0gL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy90 aGVybWFsL2lteC10aGVybWFsLnlhbWwgZm9yDQpkZXRhaWxzLiBET01JRF9YRU4gb3duZXIgc2V0 IHRvIHRoZSBwcm9jZXNzZWQgbm9kZSwgc28gaXQgd29uJ3QgYmUgcGFzc2VkIHRvDQp0aGUgZ3Vl c3QuDQoNCiMgTGlua3MNClswXSBodHRwczovL2VsaXhpci5ib290bGluLmNvbS9saW51eC9sYXRl c3Qvc291cmNl From xen-devel-bounces@lists.xenproject.org Thu Jul 07 10:45:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 10:45:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362922.593201 (Exim 4.92) (envelope-from ) id 1o9P0x-000732-55; Thu, 07 Jul 2022 10:45:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362922.593201; Thu, 07 Jul 2022 10:45:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9P0x-00072v-2E; Thu, 07 Jul 2022 10:45:43 +0000 Received: by outflank-mailman (input) for mailman id 362922; Thu, 07 Jul 2022 10:45:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9P0v-00072j-Gg for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 10:45:41 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f19552a3-fde1-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 12:45:40 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id r9so21701136ljp.9 for ; Thu, 07 Jul 2022 03:45:40 -0700 (PDT) Received: from mobilestation ([95.79.140.178]) by smtp.gmail.com with ESMTPSA id g2-20020a056512118200b0047f701f6d09sm6766233lfr.184.2022.07.07.03.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 03:45:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f19552a3-fde1-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=WY98p2xpQdOFXmhJtt3xHyGiLiAUhi6XRf4hr9Uc3Wg=; b=b6GFfkBqjaMf2ocm+NmB4Pdq8BftwMkyn64oPaQ4MV4pvFzFkwxMEQeq6P80Hm4/xV qZ+8LuyU5wRQNERGgQNFjcHh58vvfaC0ptqNORWmxffraiT9/DjbcHTSFTsFBlux58Ot XhtqsfAx1Sa2gM/tjlsL0QsZtd9LNBgjw9CnnsV557EhbpHb9gCv8v2p+Oj+GmTrlkqp mUp+nL+5dVYNjaxqq1uCJh+k/gsHSTvygVI9uMaKcsKBGCdHzMWvDPsDHQivCRNcB3z5 282ePxgRE2AokBxYCEN4Y+8PqCSOtSZbzmUbIGk4eL7kv/uEwV39B6EvqmW8CS1gOdOi UC1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=WY98p2xpQdOFXmhJtt3xHyGiLiAUhi6XRf4hr9Uc3Wg=; b=F3HtDHZ0NjqlQIoKY7fhsr/gDbMq/AeaB6AxTmaW9ILGsQG5HB31zizCE39qbLwENM HrmOBAIv39Om9sg+ZCV5eCYdYlpMQDJCzVFQwOGZEl7Hw68774pEaYnWJvLUp5t7jsMk DyQZn37hJ5qJkj/V4nAfEhDaYm3dJ6vxGOsJ0WZ6pT75Wsi+ila7tUUBF2Tn9dTFshJ5 uGelobOnm7RKfrsiT6AiE1FzH7XhAFmU+oJj02khb0r3YaxvIYGWAaAIz6M2NSJljzEp kE8E0NNs7OhvXb/tYDBLirIQnj/H1b/Iowh394p0xL6QGaYMLvBQXNB/c6imcH0gfCZm uXCg== X-Gm-Message-State: AJIora+fIsfncU/Z4gissEZsbLlanAgRT1knrEs83rM3IBeDmrtnVJFb D9xEBH0/PPW+27a6FaiZDlQ= X-Google-Smtp-Source: AGRyM1u/4QG+lv01OuNQRv5dICfp1iMojBGdOQCB054Of0nHO6eJIDlEiA+XLi20gZMrDBLB66OBnA== X-Received: by 2002:a05:651c:158a:b0:25d:1cc9:3ce7 with SMTP id h10-20020a05651c158a00b0025d1cc93ce7mr13652854ljq.450.1657190739851; Thu, 07 Jul 2022 03:45:39 -0700 (PDT) Date: Thu, 7 Jul 2022 13:45:33 +0300 From: Serge Semin To: Marc Zyngier Cc: Samuel Holland , Thomas Gleixner , Andy Shevchenko , Bartosz Golaszewski , Bjorn Helgaas , Boris Ostrovsky , Borislav Petkov , Broadcom internal kernel review list , Chris Zankel , Colin Ian King , Dave Hansen , Dexuan Cui , Florian Fainelli , Guo Ren , "H. Peter Anvin" , Haiyang Zhang , Helge Deller , Ingo Molnar , Ivan Kokshaysky , "James E.J. Bottomley" , Jan Beulich , Joerg Roedel , Juergen Gross , Julia Lawall , "K. Y. Srinivasan" , Kees Cook , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Linus Walleij , Lorenzo Pieralisi , Mark Rutland , Matt Turner , Max Filippov , Maximilian Heyne , Oleksandr Tyshchenko , Rich Felker , Richard Henderson , Rikard Falkeborn , Rob Herring , Russell King , Stefano Stabellini , Stephen Hemminger , Sven Schnelle , Thomas Bogendoerfer , Wei Liu , Wei Xu , Will Deacon , Yoshinori Sato , iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org, x86@kernel.org, xen-devel@lists.xenproject.org, kernel test robot Subject: Re: [PATCH v3 1/8] irqchip/mips-gic: Only register IPI domain when SMP is enabled Message-ID: <20220707104533.7iakliv2f5i2qi33@mobilestation> References: <20220701200056.46555-1-samuel@sholland.org> <20220701200056.46555-2-samuel@sholland.org> <20220705135243.ydbwfo4kois64elr@mobilestation> <87czehmiwt.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87czehmiwt.wl-maz@kernel.org> On Thu, Jul 07, 2022 at 09:22:26AM +0100, Marc Zyngier wrote: > On Tue, 05 Jul 2022 14:52:43 +0100, > Serge Semin wrote: > > > > Hi Samuel > > > > On Fri, Jul 01, 2022 at 03:00:49PM -0500, Samuel Holland wrote: > > > The MIPS GIC irqchip driver may be selected in a uniprocessor > > > configuration, but it unconditionally registers an IPI domain. > > > > > > Limit the part of the driver dealing with IPIs to only be compiled when > > > GENERIC_IRQ_IPI is enabled, which corresponds to an SMP configuration. > > > > Thanks for the patch. Some comment is below. > > > > > > > > Reported-by: kernel test robot > > > Signed-off-by: Samuel Holland > > > --- > > > > > > Changes in v3: > > > - New patch to fix build errors in uniprocessor MIPS configs > > > > > > drivers/irqchip/Kconfig | 3 +- > > > drivers/irqchip/irq-mips-gic.c | 80 +++++++++++++++++++++++----------- > > > 2 files changed, 56 insertions(+), 27 deletions(-) > > > > > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > > > index 1f23a6be7d88..d26a4ff7c99f 100644 > > > --- a/drivers/irqchip/Kconfig > > > +++ b/drivers/irqchip/Kconfig > > > @@ -322,7 +322,8 @@ config KEYSTONE_IRQ > > > > > > config MIPS_GIC > > > bool > > > - select GENERIC_IRQ_IPI > > > + select GENERIC_IRQ_IPI if SMP > > > > > + select IRQ_DOMAIN_HIERARCHY > > > > It seems to me that the IRQ domains hierarchy is supposed to be > > created only if IPI is required. At least that's what the MIPS GIC > > driver implies. Thus we can go further and CONFIG_IRQ_DOMAIN_HIERARCHY > > ifdef-out the gic_irq_domain_alloc() and gic_irq_domain_free() > > methods definition together with the initialization: > > > > static const struct irq_domain_ops gic_irq_domain_ops = { > > .xlate = gic_irq_domain_xlate, > > +#ifdef CONFIG_IRQ_DOMAIN_HIERARCHY > > .alloc = gic_irq_domain_alloc, > > .free = gic_irq_domain_free, > > +#endif > > .map = gic_irq_domain_map, > > }; > > > > If the GENERIC_IRQ_IPI config is enabled, CONFIG_IRQ_DOMAIN_HIERARCHY > > will be automatically selected (see the config definition in > > kernel/irq/Kconfig). If the IRQs hierarchy is needed for some another > > functionality like GENERIC_MSI_IRQ_DOMAIN or GPIOs then they will > > explicitly enable the IRQ_DOMAIN_HIERARCHY config thus activating the > > denoted .alloc and .free methods definitions. > > > > To sum up you can get rid of the IRQ_DOMAIN_HIERARCHY config > > force-select from this patch and make the MIPS GIC driver code a bit > > more coherent. > > > > @Marc, please correct me if were wrong. > > Either way probably works correctly, but Samuel's approach is more > readable IMO. It is far easier to reason about a high-level feature > (GENERIC_IRQ_IPI) than an implementation detail (IRQ_DOMAIN_HIERARCHY). > The main idea of my comment was to get rid of the forcible IRQ_DOMAIN_HIERARCHY config selection, because the basic part of the driver doesn't depends on the hierarchical IRQ-domains functionality. It's needed only for IPIs and implicitly for the lower level IRQ device drivers like GPIO or PCIe-controllers, which explicitly enable the IRQ_DOMAIN_HIERARCHY config anyway. That's why instead of forcible IRQ_DOMAIN_HIERARCHY config selection (see Samuel patch) I suggested to make the corresponding functionality defined under the IRQ_DOMAIN_HIERARCHY config ifdefs, thus having the driver capable of creating the hierarchical IRQs domains only if it's required. > If you really want to save a handful of bytes, you can make the > callbacks conditional on GENERIC_IRQ_IPI, and be done with it. AFAIU I can't in this case. It must be either IRQ_DOMAIN_HIERARCHY ifdefs or explicit IRQ_DOMAIN_HIERARCHY select. There can be non-SMP (UP) systems with no need in IPIs but for instance having a GPIO or PCIe controller which require the hierarchical IRQ-domains support of the parental IRQ controller. So making the callbacks definition depended on the GENERIC_IRQ_IPI config state will break the driver for these systems. That's why I suggested to use CONFIG_IRQ_DOMAIN_HIERARCHY which activates the hierarchical IRQ domains support in the IRQ-chip system (see the irq_domain_ops structure conditional fields definition) and shall we have the suggested approach implemented in the MIPS GIC driver. -Sergey > But this can come as an additional patch. > > Thanks, > > M. > > -- > Without deviation from the norm, progress is not possible. From xen-devel-bounces@lists.xenproject.org Thu Jul 07 11:02:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 11:02:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362928.593213 (Exim 4.92) (envelope-from ) id 1o9PH3-0001wT-Iv; Thu, 07 Jul 2022 11:02:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362928.593213; Thu, 07 Jul 2022 11:02:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9PH3-0001wM-Fo; Thu, 07 Jul 2022 11:02:21 +0000 Received: by outflank-mailman (input) for mailman id 362928; Thu, 07 Jul 2022 11:02:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9PH2-0001wG-2r for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 11:02:20 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 446ef526-fde4-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 13:02:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4627.eurprd04.prod.outlook.com (2603:10a6:208:74::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 11:02:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 11:02:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 446ef526-fde4-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I3DUmzbGpHitjgWqA//jU9T2t7XetRXn05nLxUp/cQP8tGPwsIinkh18oSym4nMHz7IwZi/ArnUG8Gv+3WLh22PSV4lxeKbzPV5cvxciFYtKXeWAjSGxraZPtPTi/ocFNY0dGWqlzge+E6IHWpWWgNdzS/SniCjCAd5i13mdpt07lLOtpbAgL5JjK0GWau780RTLKqPof0+15DtqO3oivvwccnVlLh4hDDy6j7th1hyITFFfZE9SfeWwfNWoIbuoHrjz1QF6pomFjgqIVOpKQv+FgqEw5FLUyOYKfRCvSJtvx4vqK+jiGwnHCN7iAU5DzLXQQFktUT5HDQroYhOsiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gTBnkG3u3nbW69rLllx7S8Ed/m8Y9An/koezV6cZ6Y=; b=m4CikfXT1mQLbtluMPnrKvgvL3itPk3863XGKMvmbw3EeLa2BGRHRrP8iyn2aUZMuKZRaniKyI9OiEiinvwjbBKid+xb8XRTW+8dtwCdIJjQbJgSXlGfXpfEpd2NYQARN62ET2AcKRB1kVfQ454sCaCF4IIk2CbQat9rPa2vmH19EwYmrR08GhdMYLN/TjbPjuuRtAJ1RocKeAiwfuPtuSclrV0MRMDBmkEmN+5sf3uVntizjuerznThqZ8ikw8sBk7y4K/Ysw0Vf6Qy/AUMsy739TLafkavTh7+5FNGUFGdWNOYJIFqSSLcqkTNRpQ7WWI+WyHoJtoq7iFyqZN40w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gTBnkG3u3nbW69rLllx7S8Ed/m8Y9An/koezV6cZ6Y=; b=sitFvSYrVZPBhb5VjKWi6aMmBXMXbphuCrIsdP1//bMTBxR8eZRCCu6CeMa967gFdIehBfr111PVcZ02n3Msdtu7/oFVtcxDr8jAm/YP9nd+nTA4zdF9+iF3NyBnSsxQim08WuRPRjWSc4US0w9GCHlu3ONT0hCkv0PfNIcEluNSKAs+5R9ChjLkrAllAyUhmg1IYHWmbUL2KW85DSATuVn9PXW25cEmxuldItLn98e9qd1F29CdIi0hiqnGuJKFA4bTYTC8+kgqm9jyLXbgdFg9BKqUc315EwVVFQ6h4NpnY7+JxPj8Ejj6zubVfqVIilEvdGDgIZH83VAl4SlSig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0d24ac7e-c46f-b6e1-64a8-e28b2eec471a@suse.com> Date: Thu, 7 Jul 2022 13:02:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] Config.mk: use newest Mini-OS commit Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220707093911.22182-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220707093911.22182-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6212f580-4141-4a38-27ad-08da60082741 X-MS-TrafficTypeDiagnostic: AM0PR04MB4627:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L4rXSit6fyRuOByYWmazqv6F2t+KGdygZZ6Qk6VDEJ4La7n+Vkg3N9KXVElhvLctCx8IS9CiVqasxhSpZc0oQEyYClWfxJoG/cLWOZq4SS1jINkQu4P73EAmtGh/Mer0+7M/gLJYXOVbsIKyrYEClcPw8Kb73vFfvcAQDZHLXiRydmv+jwMh3beuO9/2nia1nTEmUtBRV5o/Fp3nZH3PxHKBMwMhpwwoNxLJf4WQHVSFOVW9jekfzOUq4Quos0J8R/GMt0fW2VyXHl+zQbvxJNHz6T0vdS+Ku4GW+PmSS67JaneIRMjn7Fi6ffIuHFz/WuuVco6+JOI/HVz5CJz+EwycJ7whh9eYkfm5AvAa9zJgqg2fL2qj87fE7oe53fu2saEgPoesF9u4ngNxuGdSLEozhFnszl6lTKusNgNXPubUEAkML88BN9wMV9EthdWXL/fJhUpujzF1ddCH6dPJ1GF5neIfIPXu+Jfa3qEdxVYPyY5sgMOEPMhFRSgyceqnEYCddlnDZ30aPm/PwxtRCxLRHZFwODzUpApohHAw14jyeE7kHUd4nBy0PnfwK8qbqBL8XQRv2i5H4Nb2JlGHL8/Du+ioS89JN5I9aK/FyvLexIy2BUdyx7+KmDoasmOTIx6gcbBjq/Cv9M/PCi+SPCOAz9/5Yqqi0AMdhDv/3QaK51HY1B+wTQOKuQRN2q4E6UnISc/jCxlcKK3Zh0M/9Gyqy1VJKxVSstNzei/gl1gmjDkDWOKk7Po/xjikgN0k7NWFUaCHvKxbz9U8Kl2OI4z7e7KDxOSCQbSO0epQAzgoA7/yJ+f/NqzbCARKwxLPCQiXPjC6frdkG8nTv/xEFnoYKc7v34XN7AI7BOSPMoA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(346002)(376002)(39860400002)(37006003)(66946007)(66556008)(66476007)(41300700001)(53546011)(8676002)(4326008)(38100700002)(36756003)(86362001)(6862004)(6506007)(5660300002)(31696002)(186003)(8936002)(2616005)(6486002)(2906002)(6512007)(478600001)(31686004)(26005)(6636002)(83380400001)(558084003)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkV1aUVlaUdDU1gyS2Y3UXNYVGpzNzJTSDVFclI1RklvSzJDTkt3citQZThD?= =?utf-8?B?aEtkd3lGaE5pOUppS25KNm5HNlZyQnJvT0MwSHZuWktBdU9JNnRhQmFwOGx0?= =?utf-8?B?RVF4eVlqb1YxTHk5SE4yR0lhY0JlY1dwdGR6TmpScktqNi9GOXluM1QxRVpI?= =?utf-8?B?Tm5EUE1LemdqUDNXd2R2Ti9HcHlZakJycGtYZWtaQXRSaDZNYmJzUXN3RXNQ?= =?utf-8?B?dTlXSmVMMWdkN255SGhYeGlWOGdxRWt1LzJBV1Q4aTlBN08vbEJHYjk0VnBu?= =?utf-8?B?ZVc1TjFOYXpiVWg0ODVTWWpQZHRrTkRUdU8rUWNONVloL3ZpRmtYWTczaGJs?= =?utf-8?B?aFZlczhwbFk2dnZxT0ZtVGtVNUdoS3ZFOHk3MTZhWWJIOXdqN2w3QlFqSDQz?= =?utf-8?B?TURSUGpwNU1jNUxrVzdnVU5tZ3R0VXAyUG1GQWNETHZ1Ym5PRGhTYWhPS0pj?= =?utf-8?B?REFjUThZWmNzcitDNTY3eE9sbm90Z0NZZ1h5U0VsMmV4b0plZFFlM0NLVS9n?= =?utf-8?B?QVlvZkJHRXozeUdoZXVOL1RHbUwxbXVUdHNFOXVSRmMyUVZzM1M5UFpkbVF2?= =?utf-8?B?UlAvTFVMN3BCY0FmSWYrbU9qK250S3cwME5EL2pBenBoQ2xkcHpDeFZZdGEv?= =?utf-8?B?dWExQXE2VUFZOHdVRmh1aE52anZSSm40WmVRTVdHeDlLT2NJVkZnOXVGelY5?= =?utf-8?B?SlkvZldQR0xNR0xyZ24reFRjcVRrY3A0VUpybjJ2R2tFN3pJQ0RQK2lTOHFP?= =?utf-8?B?SkR5eFY1KzNaVHoyKzczby8vamEvb2VFVWVDcXpEcENpQ1NrYm9Ca052TDQv?= =?utf-8?B?YXVreVBlTlZmL0ZWaUVISk95RzBYM3VGYVRzNjNHdDMwK1FwVHVpTTVUdXpS?= =?utf-8?B?STFDMTA5YWZDbkxGdmpDMWdLWFZ2RUVXc2tyV0c5a1IvNFY0cDZDNXlCTS93?= =?utf-8?B?RVlxVGtnaTBpSkM5VUo3VjVVTmJEMHhOVDMxR1FaMDhnakhSTnhPU01TdGRq?= =?utf-8?B?SldEbjUwTUZHMWVVNXpvd2g0b20vSUhtdzZZbU1uTGMrM2hzUTdRMXpBVWQ4?= =?utf-8?B?TW53L1NoYWlmTFUrOGN2U3NXNWVIWjdBU0RPZWI3akEyQU5GVDZYYkZuNHR2?= =?utf-8?B?S2Yva0NERHZTRHdxWHczUEE3NXlrSTBsR1VyTC91YXBCWXIrWmxpRmpNQ0sy?= =?utf-8?B?dWFDZHg3cjZJbnl6dURRbG1XVkozc0kwcWY2YndUS2lTeHUrN3RVbTdNNWQ2?= =?utf-8?B?Y1V1eTFkNm1DcHlRZVo0ZUFKWjJmV0d0UG8ybFlsb1N1Q2x2eWNXdEE4TDNY?= =?utf-8?B?RXF5b0x0TWxlRVdNSUFDaTFKK2h4MjZncWZXQjRlZ2pmOU83eW1oVTdzZzdi?= =?utf-8?B?Rk04ZWdsbEFZWkJSdWp0VFdjSnJ5M2lZRXJMOGtzTTcyc2ozeFdXekNGNGpw?= =?utf-8?B?Tk5OeWU2UTVZTXNVY3MyQ0g2WFZENkQ1MTJ0WHhxSWRGdXNmZWhKUElwc24r?= =?utf-8?B?Mndwekp6TVZhSDdVK1JQTWs2c1FTRGJaT3BLY0tTZlFCOTI3Q2NnSldnZWht?= =?utf-8?B?NEJzWkpSeEgwZ0E4OGpTU1FYNXh2OWltL0JSbDAxUjNBYmVubjdyQm1MeERx?= =?utf-8?B?ZDl5NW9rZ05udGhjY3BPRnp3U1d1Sm9maWVId2ZETHE4K2dIbEQvSE1UZUFu?= =?utf-8?B?emtqNVdEaVFHdWNqUW4rQ2txaWdhRGlPRVViUWo2czlBNTZqQWk0eGZqS3NG?= =?utf-8?B?OUtDQm9kTUVPWHVFMFE4ZWFtYUpGZHZzcWF0RVVKcEpUT0wvUnNCQWEvMGl0?= =?utf-8?B?ZVpZcitMMUpJL2pQQ29ZNTRGK2V4bEg3bHE1dVBIT3JpVnZkSEhrWExBdjlI?= =?utf-8?B?UmhMelJlTVY5S0lCaEwyMnVLaEMrYlRvVnM4UXcxRzhKNVRreWdCTHRtaDNp?= =?utf-8?B?RWtNT2h2aEdTRTNjRWdpaW5DUWlxc1YzVEx6N0VBV2VvZTZNbHBTY2h0Ylkx?= =?utf-8?B?ZWtmQmo2dkVYMlo3emRmeDczWE82c0xYRjJmelcvd0tzM2hrZFFVZVI3cVM1?= =?utf-8?B?bjR1L21oZjhDZUFXbTRzVHByUkRwZ0cybGNXQlJPZ0VjWEUyMHZaNTExcWRS?= =?utf-8?Q?5mXq6x9RiwuOudr3KdS21TNmG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6212f580-4141-4a38-27ad-08da60082741 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 11:02:16.3120 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zIyXsKRktADmb0GE0SI7YBx8dSw0ZdMoiwCSCZ0g2Bl4K7TCAhFFjwpnjZSYs/1BtNsQqi0jfgGY0wu0Im+6WQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4627 On 07.07.2022 11:39, Juergen Gross wrote: > Switch to use the newest Mini-OS commit in order to get the recent > fixes. > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Jul 07 11:05:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 11:05:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362933.593224 (Exim 4.92) (envelope-from ) id 1o9PK1-0002Wp-1y; Thu, 07 Jul 2022 11:05:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362933.593224; Thu, 07 Jul 2022 11:05:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9PK0-0002Wi-UX; Thu, 07 Jul 2022 11:05:24 +0000 Received: by outflank-mailman (input) for mailman id 362933; Thu, 07 Jul 2022 11:05:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9PJz-0002Wa-UV for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 11:05:23 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b25287ff-fde4-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 13:05:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4627.eurprd04.prod.outlook.com (2603:10a6:208:74::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 11:05:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 11:05:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b25287ff-fde4-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fRa9axbVu7kE6A9kPNrO4KY6Nti2J2c4BEp9CRUx1vK1zyMkw1jajKew3+aaDS2JAUSDFsUen6uEws4vaE6roi4vTA6OTWHw/yx/ddUmEKxiUCPKSwPghyqVOanY/IYbV1JwMFapScf+fqAIjTyq+9JAlo08m6llLGSoJwv8ipmToQNGcCD7MqL/D6W6gh404up3Y8SIicQuSZDDcNsVpfd+uQfIzlEzVEl/haEP4SjTJpHRXL4y8+hR3NlUD6bjzhTMQbOlS/x2TK0nR38nQ3gpfix46ysJ+2SPqpZlMkmHPJfqBAGXQvZ/n3qN3286EzUwvxf1g6n/TONQl6K3lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e4EKzq5hZ22D2Yi1afyRTi8OxZnH7RebU862RMjXOfw=; b=ctjV1uR9SCEtdePU39zL+L86vbc0Jh7GyUkinKA9TPKimYFOlC6jhpvbNJFhPI0Mu66HJb504h8NRvwBQaUbN9v45wYDer1RDB7Ix86XPZl5aKW0dwTkkV6rJ7/DuI8/4x0lEvXXpQNXNcGxrp2wxuXdHPKLqujl8jCDo7NoKLsQgduTp7wv5uLluFkoairAEajsBVdO98qbxN/4xKv00VvZx9FTKwl5UfVBFviemYnZcu55IfLIUoXu1IH1re7njFAzUzp2qAjSCFMV6Z/DhbMyxq0W5lQPcmmSUAqGukiWh887LS3iY1CQ4sEWXOeuUJ6rtqXGBekSYP/pA/Jdlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e4EKzq5hZ22D2Yi1afyRTi8OxZnH7RebU862RMjXOfw=; b=z4gFmqarYszDQoL/z7JvZZN/O8XNSIc39JA+t2YfkTAkHTFFEjAkctL7GFcVMNcKEUdNAPQ+LHdfKRpprWx9gY6acAwlYMhSPVEi65keQZUulHKm3s6jcSGotOaELq+E5uXsyu4/WE4lPqy1Yk3CMxemN6fOf+/mA7UBXR8CXYgPdc2PV665A12reLdp6CdojIfInYA8ynTOR4Wud+TPvPg+JmprUzlW857FJ7+/r5l4MMB7jMIYZZ6A8V6Yfd8BJ6eIzLu8N+DUaoEvravnyjOWi9xiBztEMVHvkBN5uMrdU2sk+QQ1UeQKqqbHftRbgcdwbH/61Cf8dH7xZSFkag== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5cee1dcb-b207-6c16-1486-694b8f868cfa@suse.com> Date: Thu, 7 Jul 2022 13:05:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 6/9] xen/arm: introduce CDF_staticmem Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220707092244.485936-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P250CA0024.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:330::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbbdbb68-31d1-4f9c-bb5a-08da60089581 X-MS-TrafficTypeDiagnostic: AM0PR04MB4627:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ofI+KJFPWPx/I0b4Nk2nVqJ6UyH7iST/w8kiwil4NydakLJEEa2JlzJlALf2Ygj4jHVwfbpHvx6U1fU35dSlYvRJ/ko0SoCCUGCwcku4UQ9+xxaXSTVjzUV4/mxcWuAvXh7yv0L3jYmQChm4m5+SOMZn7s4cJatpp1WCxxjvZhXYKRFaHUNEs6aHTx0d7kj9taFGf3Mke//HyhTvpSQLTpzp/XfX5Np1m0MPfBui+pRcQYYNeG7k8g3JIBPNbawWOBaD+Uy0siz2Sxglv6AKEyb01FozVeu0/zXt90SI2ZNJ56Dk8JwZsAsgq/+yeIBLElDF69tRwXbJglXTyF/2L6JI4aT48Ej/5S7K+lqFVZPjpSb/7SUGThyTM6j6BjgNSVaACttZM+z+Y/SrV+nyLAt/gkD/EYwjmmplJeUUXv8kpa72Ze7qrmfpNtiDiPnfaCd7M+h+IVW9udMkTsXLlKdwat5fzWcjqgC5ILj2jfCMCpKUyQp8RjNBSv612ObgMbnEKyLgCGh+EVZh58x/5xcnft4ivW2WPqJFMesCU/uJDpzZUQ0MNmZnrKHZcsUpNyZUJqoUEQXInyyQGq1I/epjQbbSQxx8oIO5JW0+h538dr124nkWjtXDvzrA5v7PqOvS6+2SQzkZqZv4Oe53IkQT4g/OWt304uaTsz3XgBzlh2OmOHAuUvtb5SogrvlpAtbWsafoeq6YUmNTyIlPCmIaxs9klqm4ljA4M4Rz1PTVUZCjpEI50LG9SAUixIRQl+gV9PeZxQ0fVKjBg3XhbCdjpZurbLDkav5ZEb7lNsv+3hNBhZVcA2VOWX3G3JDQOJnh1rl47I98E7SvSOsnpCzTT6MkRbkBLYAAVQlgsHk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(346002)(376002)(39860400002)(66946007)(66556008)(66476007)(41300700001)(53546011)(8676002)(4326008)(38100700002)(6916009)(36756003)(86362001)(6506007)(5660300002)(31696002)(4744005)(186003)(8936002)(2616005)(6486002)(7416002)(2906002)(6512007)(478600001)(31686004)(26005)(83380400001)(54906003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUVIT1QzczBSRE12RlJhOHU3NFNPRi95bU9NZVVDUzdCT1Z2ZG52blFUMTAz?= =?utf-8?B?NWV0RDYvSmNNTmRFK3ZmVW5iM1BvVzM5UWZUWG43N0grbnBxcjhIYytSbTd6?= =?utf-8?B?Zk04Wld6OHlNOGVQdFFFcVd0SThoc1pJYVlibk5md1hxUWQwZzNUblowcmNs?= =?utf-8?B?NTBRQmtPaVhwOStJcWFSQ2pxeDhuMFdDcW8zRkFCZkVwcEpxWXYrMTlvU0ds?= =?utf-8?B?S0QrbkxsSEl4UXU0dVArSlh5K3ZvTXZKQnczcXBteTZlZHYxQ3FZNDNTQ1RC?= =?utf-8?B?d1duUzVhYmQya052Nkk4TkNCLytxVWZWbXM4NUtQa2dWTHJIdm5vbFFRWU9l?= =?utf-8?B?NUpKU3ErczZVTGVXbVJqcDdveXRpWW1iTmNQeFFSTW5NZWVaeTNHK2hSSGxM?= =?utf-8?B?NmNYMWVYY1BRL0hRWXZxdG16ZFdCVGFIbkZzQlY1NlRmQTE4MnRuTW52S3B2?= =?utf-8?B?cEdRc1YwU0hWVjJpY2ZVSWpJRTdpYUZPVlQwUkc2MGowZ0JwZThlRjVSSzZu?= =?utf-8?B?RWd6ZHlMRno1eUhjeVJLS2NBaEFBM2hCK0RucWtzc29MWmRLd095eGNLcVQ2?= =?utf-8?B?N1ZQNTJRb3RqWEZjRFI5R3hFcGVYemtkVThHQXpTcTlvNXJESkFPVVhWR0Va?= =?utf-8?B?QkFyeWE0TzEyaEJKZ0tmdlZ6VnpqYmdUNDhXLzU4R0hoTFE4VDIzVTE4dlU2?= =?utf-8?B?a0dPZG9oakFyb0FxNitNT1RVT09WMGMzU09LY3JqdWIyNUFFZnQ3cWxkendr?= =?utf-8?B?NkpsTnM5ZW1EaFg2U1JJR1E1c2RnWG5GV0FZYkI0RzNtUkdxNDdBV09kVG5V?= =?utf-8?B?SlZ0TGxET3VvcTZJbmszZDdQQ0NSNlNkNWFuUUllc3MwZytXMUJBa1RWT01n?= =?utf-8?B?dURxTzZtaVJ0Wklvajd4dWFOSW1aTDNxbFJMNEtkbDkxbHRSWm00WFhhM0Jy?= =?utf-8?B?Mm5PeUdaNTRVTHZmRnI1SXhVaVh2eDBWSlNyWmx6UktmRFh6cmN5Z1AyaFpR?= =?utf-8?B?NWs3TWVvYk5GaXpVMFpEY1BJVStpdkRROEUzSU9sYVh2QXJhd0s5L3R0bStk?= =?utf-8?B?MHdPTXhvQU1LekVTYkUvNWVsQVNHVDNlVnZVcVlhcFZncVBjc1RDdDE2MCtV?= =?utf-8?B?bXNoNGs4cGhmRWxlSTM3eTRTNTNXZ0g1bFR5ZzVYMjNxaXd1ZlRsN2wwajFO?= =?utf-8?B?MzhFdTV4dmtOenBEK2o1dVpzajBTVXdSajBxNFo2VnBDRjJ0dHVReElzMXd3?= =?utf-8?B?YkdQQnVmbzVPRlZwSzBZSHpPclIxaWJaS0ROaTFCUU0yY0prSk41UGwrZFor?= =?utf-8?B?YTZnS2ZsUFl1T1ZhUnYvc3lyLzZ2VXAwd3NJM2lzMXNrSFRjdmYyQ0MxRm5v?= =?utf-8?B?YmxXTk9MRXp3OHFhRmIyY1lhZkloMXRpcXZSajdMTTBwV0JxemhkUlhmQWcw?= =?utf-8?B?aVNXSDVyOUhTOW51YUpWRXJsK1crSDJCdDJHUXZWMy9JZzd2ZnFpcW10STBY?= =?utf-8?B?ZGRSZWNBTzV2VUNkZ2VjUWhkcjl6aWRxK0NpMmVUNzRNeVNYdkNvcHJHWjF4?= =?utf-8?B?UENtNlNuNmdWNnZwTTJwVTJpeStrWFhBL25UNHJwbVBHSDdGbGYyaUZjSjVz?= =?utf-8?B?UjJZN1JUam8xUDVtWG5wMXd3NXhxdkV3MEQwNVVMOFNJekYxMkJITGlOTWhB?= =?utf-8?B?YzUvVWRDdndBRHQyU0FDQUVBbXR1QlVmQ1d1bksxWlpseklPVVVrSzZUSTMx?= =?utf-8?B?YXh1WkRYYU5LVTluZGpPeTdJcklvVVpPZi9FVWdBc1U3RDUwOVVuMVUySHQ5?= =?utf-8?B?dkpYR09ZWGwzN1E3WkkxVDlnaWlUUlR1cDJKZkl6WGxZcmR2bFpQblB6SGov?= =?utf-8?B?T2I4RzNWbnViN2h6YzJhRmdKdjBlci9Hd1hRaDhEeTlRY3V5N3VhUGMzV25z?= =?utf-8?B?VDlNbkxmampPRE5xVEFxeUZlTlQ1NWllL0U4a1ZCQlZHejdWWk1kcFQwZjNa?= =?utf-8?B?WTJSK3AzbVRtMkY4ZHVuWnpNVjkzNXl1dlRuWTlaQllxdVV0OXRMUk1DL3Vo?= =?utf-8?B?WTFmeXFNN044N2RJM2hWQU51bTErRGVxOVNHL0VsVjJtNkhoYWRTNlRmNlBM?= =?utf-8?Q?ItP88TXPMsVMDCWz3zOewbdSi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbbdbb68-31d1-4f9c-bb5a-08da60089581 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 11:05:21.2689 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CXCJfG17X9mexI+Kyd0KGGLownUNEx1VUIJGLyVicYn1yP7woe4wG7jb3VVcULfb6TirFbgEp9WElZmVUg788g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4627 On 07.07.2022 11:22, Penny Zheng wrote: > In order to have an easy and quick way to find out whether this domain memory > is statically configured, this commit introduces a new flag CDF_staticmem and a > new helper is_domain_using_staticmem() to tell. > > Signed-off-by: Penny Zheng Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Thu Jul 07 11:55:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 11:55:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362942.593235 (Exim 4.92) (envelope-from ) id 1o9Q6d-0001Zi-0N; Thu, 07 Jul 2022 11:55:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362942.593235; Thu, 07 Jul 2022 11:55:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Q6c-0001Zb-Td; Thu, 07 Jul 2022 11:55:38 +0000 Received: by outflank-mailman (input) for mailman id 362942; Thu, 07 Jul 2022 11:55:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Q6b-0001ZV-0f for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 11:55:37 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2079.outbound.protection.outlook.com [40.107.21.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b57f0eed-fdeb-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 13:55:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2737.eurprd04.prod.outlook.com (2603:10a6:203:95::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Thu, 7 Jul 2022 11:55:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 11:55:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b57f0eed-fdeb-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h12FesejtBGC6PoazOtW5eu2kDUkyB1BTFmA7StogqGudLhVTmHK7DUKfzA9m//Bl/3jlKXNJ3ASHi6TlowglcsaaOQ+JnEjDyO/a0PDLQNU6XpWz9wOnDCh+ormqqG2G2/eeywjF6stN57VtoR2oUEPPzNvhsyuc0UZBwCnarvdCOd+MSs4EyNkhSY8LXvysoe2qB0NBDG89NEZWloquQE3yovPs5tVzxQregWwwiJVa0Rrr73Cmj3Kv6JzckH1XbyBA+uPtYT33nnC7fY0ujxZdGhoB+zgM7kRdih2mX7Fzmeypzb+lKahJbeH6W21PUH+HITUk8lzyEixlcHO5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RMS5ols3p0aQi8ODPiMUrqXvEneE56yD24DzW4xORYI=; b=ithDGRj/zeg4dKKX9wJyQadHY/HkkjSwANyx5txyG5ajaLEDxc6eXPY8kYlhr7P/rrKuyL9oezQMl8tNSzYU/xCIQPsgJ9ifzgA4p8ScQaIlY34Q8yZ3IhIBmo+T5hvGSveI7jUkyXIt/McCIB+1NbHjIXu1txU3ckuczkJBPM9HBWX3ocmH5ultv16J/ZdclVJsgpi/KsX3wQXF1lm8nz8gCrxoWAjHORimuPsQf2j4x9+oua17TPxyYMOuY16noFv2BjvpLORDpZipiu5fwuECJs2xogSygzkl8xa21QeabOxj5yjS63MhyUgAiBWEQZNjdgstDBIIq4r3bDLJOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RMS5ols3p0aQi8ODPiMUrqXvEneE56yD24DzW4xORYI=; b=AW2feoHKLh/4ugTDJeSuaQ5Y1tC45HXaZsoOz91Qxt3oF+wRxUeLCPlxvTwzVN+jfHtYsvIFAO+B/yydnlahlhqlokYSp9OZxjRtkSA9gG+RZ5pK0VzISehXkQEChQTbl7VxR+b2au1l3qIAKwLMTaHbAM4HInlL9rlhmudf0krc+4DTH1ertfsUHk01r9xeczVGup42mcEC40fVC2wKbxbjRm3y1mnWe5Y17J3LyL0KSzdMa57jb0NLPhwBhezk29OH2id9QVC+TRe4cT1FU4mKEF7w6tdOqM7D2g287I7AhxhETwv4NH6VUK2eIzJCA+hp3iCQ9q7O21bBD+qi0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <16803e7f-5a7e-91c0-03f0-3133e0dff957@suse.com> Date: Thu, 7 Jul 2022 13:55:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [RFC] DVFS and Thermal management subsystem proposal Content-Language: en-US To: Oleksii Moisieiev Cc: Juergen Gross , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper , George Dunlap , Nick Rosbrook , Anthony PERARD , Paul Durrant , "xen-devel@lists.xenproject.org" References: <20220707103500.GA1959452@EPUAKYIW015D> From: Jan Beulich In-Reply-To: <20220707103500.GA1959452@EPUAKYIW015D> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0039.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1c48c93f-76a2-4f74-74e3-08da600f983c X-MS-TrafficTypeDiagnostic: AM5PR0402MB2737:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gPsNvac0gJN0nL+aljFE+OBwvIIof5SbkzX5Xtjle0KDKoj6DvKYlfSonwrhF6nYBfamlFs+u3FNSmLyOWtMtZc5irgn6WrFHTho7VE2LDcb/YO9nkeYAO7/gKaWp6nxW7LmCUkzioTeRzWQE1MNykzUfemWKVACfoVHnPe9VjVI2UNQzSq5MWdqCKEPPHrVW1DtxvtMC0s37P/W40Hx96P++7E2Gr4nAyZChp7MadS73PJbHetn30J0puXPq/7NhNEYYArwTIVIkmc97W9rFXMBz7deB/41/JhVezNr4oL1FqvTlLoAkPOzdX8QSI2H6IVTBGsR2oElAdqMxvtge/emhjzYR99sJpegf2J/wIRbWSmuRWjJy88GM9yfinnPCsbLPLQgmZuWi8y+2iqBmTZwJMu2+ZTzy1dxL5w/VsxgIR+x0RO/nsJByqHV48sDcuU/50T0/tLWgpSzibjexaESQLt/XOBvS5gpG2AxDCCAATpUkW8hM1bFQMEdIfsrgiO5VjwowPv2dW9IRY3rYuVggYZ3bMgozEnV1NtjELmkc1OH3UYZ8gsZbZFlfpWZWUBmxV9RcqImEfNAoDLueB397dtr9lKTDWCcGTQyMp6wH2wTAsqV1/B9QoshksC+WEOO0V0YtN0Hq7uQAKirnFtXEmZVae2BUMu2hQtemE+jULV8bHFaL3PqoG6MnP2cKmrNA/rJZkpUyvKK4KKkoRqndJFsouBg1ZlhJHPYFdjJpimMvnPOj3Ijll+huhuPBGa0mnGyUxzCMGi3nCzBah5kNe4BcGuilDH7jYntWmni0VwgcM/ietTf2bahtsEsOkw+tnr2cneZ8xJnptQLCUq+ThmvOc5m7ahuR3gz4HI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(136003)(346002)(39860400002)(366004)(83380400001)(6486002)(478600001)(31696002)(66476007)(8676002)(4326008)(66946007)(316002)(6916009)(54906003)(186003)(66556008)(2616005)(53546011)(41300700001)(38100700002)(86362001)(6512007)(5660300002)(36756003)(7416002)(31686004)(2906002)(26005)(6506007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1pTdlhQNWExaVlaQlV5WHhQYUt5eDNoSmRmblBOV0k1SnZFYWNteFNCcFNa?= =?utf-8?B?OXlDWU9hNEJsYWFGNGtNMTFNait2cnVxNjU1YWtNdXVJbzY2aVdZaU1Zd0pn?= =?utf-8?B?aUVPYW8yVzBWRWtlZkY0cUlRMStxTDA0VDN3UlE3R0FoKzlQUHlBdnU3Ukc4?= =?utf-8?B?VHhVVkNPc0wxeVZEZG93ZTJ1amZRM21TK1lUSjE2OFozZUFqOHMweldjM1lP?= =?utf-8?B?allpdDZSN3cydDNxaUhaRTZmcnVEelRUZ3ZhU0NVdURkWUV0dUsrOE1WRXFC?= =?utf-8?B?MUEzbmVvNXVjMSt0MTVTSUVRd3pGY0ZQbWlNUmlFMmRnSjVoYzhCdFJHdDVy?= =?utf-8?B?Y1l4ZFJjVmV5RVc3UFRzcUtRTm55NTVjVC9GcXhJTkRyVjdEUWNxNzhCazNB?= =?utf-8?B?eE1nd1pSSDUwRTQzOVJCcVVaNnI5akZUcDNMNVBKOU9XYlF4TjBVRWdyZkZ2?= =?utf-8?B?YktTMnowNWs2NktuM1ltZkUzTmdzY1BON3NxeVlVQ3Fpd2prRDlQUDR1c3du?= =?utf-8?B?cjVMeVJEVWVGSzJMc0FlNTd4MFJZZzgwVWJOOVJZcFc4YmFwRURjTGRmd2Zj?= =?utf-8?B?bGZoWGtJbmtrdE9UZzJpT3IxYlptSGZSVjB2VkJ4dHBHdEl3c1gvTXlYQWk4?= =?utf-8?B?ZEhYQjQvcFp2YkNCSTBWQWN1dUU3Qk5wRG5nR1BUZTBSTE9ody9PRHVlMjhw?= =?utf-8?B?T1BVTmpiUStqajVzQUZqdy9wVzZ2S1NBVkhSUG42bDlHTmFwNEYrbE1SNFBp?= =?utf-8?B?bG5lMVZFL3VKZ1pYNWpMS2gzOUhhQjEyQy9wNXpKeW0zTTJLOGpwWG5HendN?= =?utf-8?B?L3dzb2dUVS81U0k2bnZZaitOSkt0Q2FEZHBjNXZnZ1piZkszNFFXdC9JckZT?= =?utf-8?B?b1NRUnRmSDZkdVdhUGRjVjhOWWh6bklDS0ErbGZCWUVWZ21oK1FWWUQxR2ts?= =?utf-8?B?anFJOTlFNXhYWkRoNnhHS2plUHB2MWV1anJVa0Q0empycU52ZGwwT1FCMnBw?= =?utf-8?B?Sm80ZDFHakt0a2txaTlDbFRiS1VmRTdmQ2EwWENIWUtjNkVXWldweFIzM0Jp?= =?utf-8?B?ZjVPU3pYWjRHT1R5VDlPSFNNNk54Nkx2ODlkTTBFQ1ZWMFRwT1lkci9XZ2I4?= =?utf-8?B?WjkxWXA4djVOTXVNZGZoU082b3M2TXRKVWpzb3pseU1NYVJyMmIyNGtUVlpm?= =?utf-8?B?VDRuOE1tZHdCOUMyZndjbnVVdGtHcnoxaUlkSjU3WWd1cVYwY0hOVnl4MERP?= =?utf-8?B?dkZRNWQ1bElBYm1YQmc3U3RabTNYbk1Reit6dHByeGljU1VuYk9FY3BMdlE4?= =?utf-8?B?U3lQaXFnMFdBVzBCYU44dEJldUxyY0YrM0xqRzNvMjZWcktULzNOMzBBMjIz?= =?utf-8?B?bjF0VTAxTVRScU16Z1N6YUdIRVhJZ051d3VkczR3Qkw1OU04U2dKOUM5ZHJI?= =?utf-8?B?d25YTXk2Z1p5Y0V5M1h3WkJhempnQkhINFkxd29iaUY0M3Z0YWsyRlBoUlNR?= =?utf-8?B?bXFKdmwxSkRhT2lsNElQT3VZYjJNaDJoY3Q3WHRQMDFuOWRWeWE3cEU0MWhH?= =?utf-8?B?VE02M1dWODNqS2dpVjRja2wyMGZQWCs3YmpmeGIyWTlRVERFYkZNbzhzcmdV?= =?utf-8?B?cWRCNU1aOXVsZDZEd2NVVm8xVlpIS2dwZzBaejVpcThlK2hZSjlNU3VicU8x?= =?utf-8?B?VUpURDdnUmw3cXQvNmZpaFA1bjVNL0ZXRitEb0NXSWNKVmZqa0JRMjBDdHpG?= =?utf-8?B?R2d6Y1d3V1BtM2pJUVN6VG9DcjM1WXB2MW1rc0o2M2trc3pRMTlLWEtsTStU?= =?utf-8?B?THFXcXhwSldzR01EZ1FYYUt4TkVuMHJwSUNVNnUwdVNtK2ltQWxFT1pnSnZF?= =?utf-8?B?QzdvZURLUmMrMXMreU96RUY5TDFzVytGcFJpVTk5M0NObFNYMWxvdnN2TGU2?= =?utf-8?B?OHgyWk5DZXVTK1hFVjZzUVJvcndCeDdiYjN6aXBCMDNDQzU2M3o2eFFZV3do?= =?utf-8?B?VCtRMFFOeTJaM01ocUtNQTFpQjFiYU52c2hmeHVJaWcwZFBEem5BU29LUUYw?= =?utf-8?B?b3F1TXV0ZnlaSnozbmF4M0laSDFycGhRNjVsUUdNZ1BBNnZ5OFdacHhzRU1l?= =?utf-8?Q?7Va3ip3COmC40oKIOjLUFxoe5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1c48c93f-76a2-4f74-74e3-08da600f983c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 11:55:32.2627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0nuGOPOueE0YTNGY6gzAmKS37Je5Em/kcSBfy9nlRdo+eaHAOnyykvHlPAAH+h2zTDbDQvjDoQlNcSGq3feVGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2737 On 07.07.2022 12:35, Oleksii Moisieiev wrote: > # Synopsis > This document is intended to describe the design of the thermal based cpu > throttling in virtualized environments. The goal is to provide generic thermal > management subsystem, which should work with existing cpufreq subsystem in XEN > and could be used on various architectures and hardware. Looks quite plausible to me, just two questions: > # Cpufreq subsystem in XEN > > ## Brief overview > > Governors > +--------------------+ > | +----------------+ | struct cpufreq_governor { > | | ondemand | | .name > | +----------------+ | .governor > | +----------------+ | .handle_option > | | powersave | | } > | +----------------+ | > | +----------------+ | +----------------------+ > | | performance | |->cpufreq_register_governor() | +-------------------+| > | +----------------+ | | | cpufreq_dev_drv || > | +----------------+ | cpufreq_register_driver()->| +-------------------+| > | | userspace | | | +-------------------+| > | +----------------+ | | | ... || > | +----------------+ | | +-------------------+| > | | ... | | struct cpufreq_driver { +----------------------+ > | +----------------+ | .init +----------------------+ > +--------------------+ .verify | Hardware | > .setpolicy +----------------------+ > .update > .target > .get > .getavg > .exit > } > > Cpufreq subsystem consists of 2 parts: > 1) Cpufreq governor, which should be registered using cpufreq_register_governor > call; > 2) Cpufreq driver, which provides access to the hardware should be registered > using cpufreq_register_driver call. > > ## Hardware drivers > > There are two Cpufreq hardware drivers implemented by us (see Appendix 1 and > Appendix 2) to provide support for Rcar-3 and i.MX8 boards. Those drivers are > designed to support thermal throttling subsystem. They are going to be the part > of the contribution package. Are these drivers also intended to act as "ordinary" cpufreq drivers, i.e. controlled by cpufreq governors instead of thermal ones? > # XEN Dynamic Thermal management design > > ## Synopsis > > Introducing the design of the Dynamic Thermal Management for Xen hypervisor. > This feature is an enhancement of the Xen DVFS feature and will allow system > admin to configure different thermal governors which will perform CPU > throttling, based on the CPU cores temperature and thermal configuration. > > ## Top level design. > > +-----------------------------------------------+ > | XEN | > | +-------------------+ | > | | Thermal | | > | +----->| Governor | | > | | +---------|---------+ | > | | | | > | | +-------+ | > | | | | > | +------------------+ +------------------+ | > | | Thermal | | Cpufreq | | > | | Driver | | | | > | +------------------+ +------------------+ | > | | > +-----------------------------------------------+ > ^ > | > | > +--------v--------+ > | | > | Hardware | > | | > +-----------------+ > > > ## Thermal management subsystem design in XEN > > +------------------+ > | +--------------+ | > | | powersave | | struct thermal_governor { > | +--------------+ | .name > | +--------------+ | .governor > | | stepwise | |<------------+ .handle_option > | +--------------+ | | } > | +--------------+ | | > | | ... | | | > | +--------------+ | | > +------------------+ v > +----------------->register_thermal_governor() > | > +---------v--------+ Polling temperature > | dyn_thermal |<--------+ +--------------------+ > +------------------+ +------------>| polling_handler() | > +--------------------+ Polling (only)? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 11:59:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 11:59:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362946.593246 (Exim 4.92) (envelope-from ) id 1o9QA7-0002fY-Ga; Thu, 07 Jul 2022 11:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362946.593246; Thu, 07 Jul 2022 11:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QA7-0002fR-Cd; Thu, 07 Jul 2022 11:59:15 +0000 Received: by outflank-mailman (input) for mailman id 362946; Thu, 07 Jul 2022 11:59:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QA5-0002fL-5p for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 11:59:13 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30070.outbound.protection.outlook.com [40.107.3.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3658a64a-fdec-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 13:59:11 +0200 (CEST) Received: from DB6PR1001CA0021.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::31) by AS4PR08MB7555.eurprd08.prod.outlook.com (2603:10a6:20b:4fd::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 11:59:08 +0000 Received: from DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::fb) by DB6PR1001CA0021.outlook.office365.com (2603:10a6:4:b7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 7 Jul 2022 11:59:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT025.mail.protection.outlook.com (100.127.142.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 11:59:07 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Thu, 07 Jul 2022 11:59:07 +0000 Received: from 3ca93c1dbca8.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8491A75E-EDA2-4F4A-85D2-A044D76EBAFB.1; Thu, 07 Jul 2022 11:59:01 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3ca93c1dbca8.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 11:59:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBBPR08MB5223.eurprd08.prod.outlook.com (2603:10a6:10:f6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 11:58:58 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5395.020; Thu, 7 Jul 2022 11:58:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3658a64a-fdec-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TSQpxIIpBPOtqSSjJVWvvZecFtuAiiI5C456JBOk3toWaXXyddbKHPRxnf4msPkWmqePJFicqM80YGWZPfj0+CSUxumomePiupPau8pScHuUh5TPUXigG4ET8i/5CkQ3z231UXnXr4qRyTxoAFQ29qnKpx3+ZRjO5ZL+CGTOlNgQSQwDKwr/Rc8vr6ytRgWkd0tz3LV0n6XAtlYkizTQsCiaKZpgGMjCIl7TKIYBKjjZhzrZNIigpbB+RVB0IcXqVDiJQRhXCTsrtDWglq58/IvOLDNL1GkNJyURy74zuhjluNUCd+i2ACKUyWrCg+U1nIVAjTK014gYvOes7On7EA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ItFaFC+hS46Qdqm03JWlqnM4Wp6UfhakAlUpTVK1JK8=; b=O65aWpuVQXaJCiOKW1OyKkdBFa86Vun3v7lXYj9J3Ax70u/n2pyHuAraMaEjIuFQd6XOtWv/W8xgBAU6z9iK2/WfT6tM3wIzhcCiFmj/tgyELt3rI24SEgmwdkRb0XPBQUCeinPPq591NDFE75v90UWWRFZPbWzq9fWPFfb7p5myVEu2+sorKEN4e2e0fD5Gw8d2SnQ5y9l3w5J2oGnTMMsXU/KvL6DobYEGwuVvxRVkbN47q2g2kQHu9PdeSO2RbC+rNceO55/QjXjhRFbsWD6vvVqKpkQvmSI71qEVznLQNQmQRN0qrPCotAIJZmgQ1xalqNMsxFqyDpLIaauk1Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ItFaFC+hS46Qdqm03JWlqnM4Wp6UfhakAlUpTVK1JK8=; b=wZlNhDFvXUFs9XnAFct3AYjMJrB3WxZZanZrO8JVQ8Y7s+M+T0hYf7sBI0va7vjHbbSvTrabWVa0lulvSNP6lg6/EVGFq+Wp5HfxQCJ5GriD57+pyUpx8IyOwRS077fYdbmVW04uOjn772VmU7ewJpLWNhnGWKlv2oCXyx/p8HM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 77dad97c546ad625 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hU7H+JyjlHmZ4cDqZTqKGJ2jEB+626LTdOkyI4DHEkzy6X2msar2BO0aWbnpHy3S51v9SrYKhre4D86wJuxieMVyugPAcBSTvUGLj+1g6kPlSwIc/bNJOuJDQ+9OLyE9ddzrVXubN5hgcd/3GzwptvhGlb3TtxultRwb1uyKqSC7ZV06+ntMSHdT6gDflfaxB7TVOd0VPEKVl800l4KY5Dnf8dlk6E1s1BFZEKXnbW95+edHKVGZhPOVDkcckmoQ87y7uOGOMh+hHHv/WvT9WpZGvyWO5qIj+bBXjL/K4WOd0gyFyUSN68ZBzLEVYms5VJX2P9YM6rIS1UdeCcNgLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ItFaFC+hS46Qdqm03JWlqnM4Wp6UfhakAlUpTVK1JK8=; b=Jvuoae6dku/VN+OTavbwDALQrfGXBY/b8JmNfMmL/gS3y3CUHbsH12zyOb9P0cQvLOT7dpg0xUaJKYDeC23dnhrpAq2hc7MNaUBtuWMOFyBT6rd3rE1KHgVT1HdKPOMF3fFzX9+MJYZuKmHg/jdbgY2hq5C3jexTOZeWdltdbnCgVoKVxrFgT4twbV+kWx0idcw50mnh96jXY9KNkv6/DBR5Zso+61iCLiJjze2OvABRo6+PxLYbo9jSC6K/jvzUZJcW8/9ytwetJ40RPgMRf1lD6TH4tTf2dQY1iXVjC2pmaQ8mrnAmO7GByJdmlMLzWQN69UP1ek9KtTMrFMPSGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ItFaFC+hS46Qdqm03JWlqnM4Wp6UfhakAlUpTVK1JK8=; b=wZlNhDFvXUFs9XnAFct3AYjMJrB3WxZZanZrO8JVQ8Y7s+M+T0hYf7sBI0va7vjHbbSvTrabWVa0lulvSNP6lg6/EVGFq+Wp5HfxQCJ5GriD57+pyUpx8IyOwRS077fYdbmVW04uOjn772VmU7ewJpLWNhnGWKlv2oCXyx/p8HM= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <9f40f2c0-f586-a1cc-75c5-a0f339b89848@arm.com> Date: Thu, 7 Jul 2022 19:58:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Content-Language: en-US To: Henry Wang , Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> <9916754f-b730-6201-5225-167995f69b51@suse.com> From: Wei Chen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR04CA0159.apcprd04.prod.outlook.com (2603:1096:4::21) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 8034cc26-cdda-4c30-3d78-08da601018e4 X-MS-TrafficTypeDiagnostic: DBBPR08MB5223:EE_|DBAEUR03FT025:EE_|AS4PR08MB7555:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kY5/lJlfmmpDhekxKDbDCjqQn/j+GC5YZ1ZSoMQe5nluOy7wihQoeKkvhOcgAAJilI6eGWEjbISe3CZw5vs/Fyw5Db53c4kclLOhn1sAS4YfqMlVXJPihOM06J5W6ZDd4GvFt7stoGR9MGDe04sEa8dFJqRyyXYa+O47xFgXZYyaCJJenDzqUMHo90OGMfvHnXTLWmjgMn23ffLxBpTqJUYy+lVgnhqy96EQZs6bsraDiAVEGTGoc5NiQv0XrNPUkD0yNRWFRO3Cl4gV0PVYuEIiPnCuxfleWIc/AfOske+OL8TZeJ9MUope3IZ7tgWjP2iXrXDnypLCL68NW382YJCs+FPk9aqgevhXCv++5RcEQDkFZ+TeIteOuFIJjBJkcqLn2hpDLlR9vzM4rrYlgJZkSN93a+0SBIxGNcEcyZjNOb5M5HXWw+aO+BHLqAeB5oHddMkhS5NqHLd3A5JOvbddu0FXBSUnGW7OJ2Y787hZbyiHIkopN+2RDMyyvCuEAx7XBEkJpdEJhD6Py7w/a9ne2i3RUq09dtuJXUWNz3TYNdTsfrKNhobqrecUU7lsgQ7/B8kGN1/c3UBp76RGC+MLXgRCh/FNvxRaexjx1pOpZKBA+HMC3Vvak13XYOFT1MM7hN77zTmZxDd521e/9QkDwjnQKcEZLQmt3vFNV4FijPi3qzonp8kA6KAXw34vX7Oy7aSvfW3Hdn2trEGpgxO9QuAFBndvbC3HszvHi+8oDHo2yh+iO2OfyvzBmI0d4x5AAC5nkwb26qEie4nn/2CdO3JwzzsAl4e+Ev3zkYgg59LLLxPczbiAAg2VoP7R8cv9oTZ6knWDzWxYbfjWrjknTVNPedQGZhYO+Qk9GUE= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(346002)(376002)(39860400002)(8936002)(5660300002)(38100700002)(86362001)(478600001)(31696002)(6486002)(4326008)(31686004)(2906002)(26005)(110136005)(83380400001)(6512007)(186003)(54906003)(41300700001)(66556008)(66476007)(6506007)(2616005)(66946007)(316002)(53546011)(6666004)(8676002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5223 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f314dbdf-05a4-4b5f-e054-08da601012c3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gUwqJBohH8PvdSVS/j1hZRWgrihJXh/CZkGWpamSahwxQKKDwYIkPYcpSocyxb3ZD++E82MhhDhuyECqAvq2aITpSf08KP8ONT6VX3v62f6EJn7Vmzsi1pVe+r93+IjDQlVKyu9dlnhVFSTFZ9YRlUX5o7tS6r5c03CQT2z3L0UT/AcG1fo5XzTweO5HBU980btWCj3GnuW/jJWHOcYz+WOG1mDdCIpw5S878gXf/lYDGXMrrcUAKYQlRId5gpMB1avyR/gql+EIbfFID6wyK8R5S8BxtvoEAyVmZglrlNrKfZcscvxxro4oHygem34iOj6zikVHTZyD8BZPam3IQgIS+3AHJFht291dmjAmsH+aFY1Y18aoK8oZpv7o/VgupA6c7Rkx4E3qjmZjiERxk0ltkDF9KhjdE3mjY6YgJyimTRxs5u6z9qHRBns2xnhezIER3kosYkNGbTNswHzAj36rHMVzTY9am4Nm7ydB8uoYL3megqoF7QkvGF6BEWOJLjOVaNlrhPXf4jBEdsGE9ZNic6d1UoMX/b3/ET6jRGm1xCBGR+DsY7/vM25iENQeHmikPJKstIGxCZt5cbbw6PFb+eqS40rJobuJydFl/SuKEYEGm/fJ4eFeuXY5E0t0yT0Beo2Gmk9SpPfBq2QT6K6ovLFheJFFkf9Bf6l6NXxGswy6D0Gtx7CuysRRciDE34tVspyLV9b39SClyVS6YwMxd0psvVFiM4Cj02W8fxMsaD2REcTMzEx6MppzYmWFR1VahYP+utTwfQQrIcRKu9nu5++yiB0c8sRM2KZNYMGQR1Rl70x+DmJePjW4LuQv2rMbgR8lM1lwDJgYoYNIYb1Ffjo/4K/aAe6kDycDt+s= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(54906003)(110136005)(82310400005)(356005)(83380400001)(4326008)(8676002)(36756003)(70206006)(36860700001)(40480700001)(70586007)(31686004)(316002)(2616005)(6506007)(6666004)(6486002)(86362001)(336012)(478600001)(6512007)(26005)(82740400003)(186003)(31696002)(41300700001)(107886003)(8936002)(2906002)(47076005)(53546011)(5660300002)(81166007)(40460700003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 11:59:07.9544 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8034cc26-cdda-4c30-3d78-08da601018e4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT025.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7555 Hi Jan, On 2022/7/6 13:44, Henry Wang wrote: > Hi Jan, > >> -----Original Message----- >> Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition >> >> On 09.06.2022 17:52, Jan Beulich wrote: >>> With debug info retained, xen.efi can be quite large. Unlike for xen.gz >>> there's no intermediate step (mkelf32 there) involved which would strip >>> debug info kind of as a side effect. While the installing of xen.efi on >>> the EFI partition is an optional step (intended to be a courtesy to the >>> developer), adjust it also for the purpose of documenting what distros >>> would be expected to do during boot loader configuration (which is what >>> would normally put xen.efi into the EFI partition). >>> >>> Model the control over stripping after Linux'es module installation, >>> except that the stripped executable is constructed in the build area >>> instead of in the destination location. This is to conserve on space >>> used there - EFI partitions tend to be only a few hundred Mb in size. >>> >>> Signed-off-by: Jan Beulich >>> --- >>> GNU strip 2.38 appears to have issues when acting on a PE binary: >>> - file name symbols are also stripped; while there is a separate >>> --keep-file-symbols option (which I would have thought to be on by >>> default anyway), its use so far makes no difference, >>> - the string table grows in size, when one would expect it to retain its >>> size (or shrink), >>> - linker version is changed in and timestamp zapped from the header. >>> Older GNU strip (observed with 2.35.1) doesn't work at all ("Data >>> Directory size (1c) exceeds space left in section (8)"). >>> >>> Future GNU strip is going to honor --keep-file-symbols (and will also >>> have the other issues fixed). Question is whether we should use that >>> option (for the symbol table as a whole to make sense), or whether >>> instead we should (by default) strip the symbol table as well. >> >> Without any feedback / ack I guess I'll consider this of no interest >> (despite having heard otherwise, triggering me to put together the >> patch in the first place), and put on the pile of effectively >> rejected patches. > > I did a test for this patch on my x86 machine and I think this patch is > doing the correct thing, so: > > Tested-by: Henry Wang > Because there was no Arm EFI environment in hand at the time, Henry only tested the x86 part.I have setup an Arm platform with UEFI v2.70 (EDK II, 0x00010000) today, and this patch works well when boot Xen as an EFI application from UEFI shell. But the binaries sizes are the same with/without this patch. Is it expected? I have enabled: CONFIG_DEBUG=y CONFIG_DEBUG_INFO=y Is there anything I should be aware to test this patch? -rwxrwxr-x 1 weic weic 1081504 Jul 7 18:43 xen -rwxrwxr-x 1 weic weic 1081504 Jul 7 19:43 xen Tested-by (Arm only): Wei Chen Thanks, Wei Chen > I also noticed that Julien is suggesting maybe we can have Anthony as > the reviewer for this patch, so I also add him in the CC of this email. > > Kind regards, > Henry > >> >> Jan > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 12:06:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 12:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362964.593257 (Exim 4.92) (envelope-from ) id 1o9QH0-0004Ns-Lg; Thu, 07 Jul 2022 12:06:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362964.593257; Thu, 07 Jul 2022 12:06:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QH0-0004Nl-IX; Thu, 07 Jul 2022 12:06:22 +0000 Received: by outflank-mailman (input) for mailman id 362964; Thu, 07 Jul 2022 12:06:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QGy-0004Nf-Sp for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 12:06:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2044.outbound.protection.outlook.com [40.107.22.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 35ddf175-fded-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 14:06:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8887.eurprd04.prod.outlook.com (2603:10a6:10:2e2::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 12:06:16 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 12:06:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35ddf175-fded-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KfUJgS2kEaAfU/FgDEh6VHuzNjjCljA5lsCFJseznkRScjelIhBXXuNVEq9ZORBNrjwzipQ0Q1eUEIOxyJtc7Xv7byGuG25P96aQrNzdpNwkTxMIIsD0KJ/HJbmIVv/GeCQmgVddBg+cAO5tlDGpA2AQX073dsaErDe/fv56uqLvIlPRJDOuvVb2UyDvn25SKSyeeJb6nhjTs2X+t18r9GGUTgn0FjdiWWJDcJr9RcZjDRZboyawFS/a85SWlMzlOzKxUZv/5w9aw5c4y4ZF/uyvwAbsZgKww9FoQvwuKoYp3DRF5CqOswF/1hhMGjiQT0YRUESK/Pi2eFvF19Z1Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EGgmhBBHbPLjkajTGvRH38P2O1b/8d/vclKAYv/dbfM=; b=Hqsz+tvBPgkQQjkKg4UV80E7Xndlm3gZMG53VoKtnye1JAFKHUfbTgEIHPyZaJB7cwrqPLuhomB2/Tl+1rv/hS+P4IJUAdLiXZWx5KO37Mn1aVxuy8AI/hz57G73stiKYFs7qTLLpxB1z+N97DFD0D78VeY5Eu+xTa7ZrlxAozn6zYJu4nMkFFbTT7OfXOClAT6ltr+vAO6XWR4uXWfMFhkUMpUUmPSQ7Safsr6K9wz7ETUOA1nvXunn4aRNiRvBkuhRVtDTX9MQVB9YT9Xs3Cfxg9qN8ijvyX/bJT8mu8urTug0HMFOGPYz1BfKb30j8w7cBQCxTzylhg0OrHZyvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EGgmhBBHbPLjkajTGvRH38P2O1b/8d/vclKAYv/dbfM=; b=iwbnEJFNCQnVUg1OCnY0wmhx9/DhJP3WjZcnicHzj3wDI26QIntNT/d1rxPvjSZiGsCEXxRkvGTd28+E09kVDsivhce5KD2y2/QmjSUrvGyLcOLl1Jmc/UDAjzIlM/iCC2WZkdCALlaQIzJCmKdIElSlhKLXkmMcRl/WdaHr7u4F1N9bgNMit3mkAeOw1yXwhZU+Zt6kR/hZhdXGnVJ094UB9N+szvKD6tLGZwgoWDBJsgw+Jf7cpY8KKliyJRC+CscW2tXRR4/VqbV8DmQa+l3T5i5SK6+yI0ojr2irX3hWSrfaNOFKbTNf8ktcJQtcmfkRmLqPLxJ9M8tbMkrlLg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 7 Jul 2022 14:06:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition Content-Language: en-US To: Wei Chen Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD , Henry Wang , "xen-devel@lists.xenproject.org" References: <79ebbde2-4be8-d393-476d-25326a2aa327@suse.com> <9916754f-b730-6201-5225-167995f69b51@suse.com> <9f40f2c0-f586-a1cc-75c5-a0f339b89848@arm.com> From: Jan Beulich In-Reply-To: <9f40f2c0-f586-a1cc-75c5-a0f339b89848@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR08CA0041.eurprd08.prod.outlook.com (2603:10a6:20b:c0::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6bf3468a-e08b-423f-5ea4-08da6011182d X-MS-TrafficTypeDiagnostic: DU2PR04MB8887:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pWwi2WY3r3IF0JMYPyc+5D7WKfOCyFz1YCaLLEWJf4iUgZ2Hbi0GU31Zv2vUv9UrO3GCu1rA67zIM9Z2BojxRiMcI3i3jlcPGbYSKXhG6hKPiKEwP7aHoCh3bUxsP8szSTL60wXV6EnznVV7BGplkzrbbsRA59nCZjJna003STVtO5A67+GqzmCRWdhPyncvcVf46yOobN76HPPuFaixwLithj/n8M05wxFuewkCCGoob6bVjsqT5k8U+igP2HjEe+vquTgDn93L8HBjNkM7RExdxJ/eWO5GapooRvSod0FmPm7gy2DtoaW8nuzf+R4tFIFugEvJ6dpC9kppbOCrz8kujzHnq9xigMJE+dTji+sZbu/j0uOECaq/kN26CITMPrOTbChIuQWxVq9HoOnPMXJzxYUrPrixdDPAxe8O3wkvBTe21fghLoT5XHLMYgBL+RUGcnutSMzkAAnb3ZMxTVyxbz9ZpzZt+w2jVdykY0WRQWheRcWoQ763h7zPfQCFvEevf/F7pKXSoYQk83didjliiXmWbtoeotiNu+WELssUfELFIK84oauhK71gqJ4T7Jimk7QNAtC5fAQD5G0/WBI+H+kOL4Vy2ugV4vltK3pTE2wUX8ieZyhKhNHKEgRM8Ec6Qh3g8KbX9SU0hSaCeOkdaBFKRGEImUGBmTrFrLEdSeOs5PuzNKXjwyMQFCogHQ5L+AWaRe5Vomr0JLNUEEcWax2s4YR00n97vGx6gIUzHUcoHFjzgCY7E5tv8KgQOQ8MqwaKdDnAK09+B8iMfm+VjzQq8wr0q5l+60TBbW7It3sAcF3X74BP6MTAr2UXXRjj6VNmW+I8rlsjN4fpRAaNWYZm5z4SM6uD3WoYZwQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(376002)(396003)(346002)(31696002)(8676002)(66476007)(86362001)(66946007)(26005)(8936002)(6916009)(31686004)(6512007)(54906003)(2906002)(5660300002)(38100700002)(66556008)(4326008)(83380400001)(186003)(6486002)(36756003)(2616005)(6506007)(478600001)(53546011)(316002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0I2emt2eVhKSnRtQnkwd1YxeEY0VGljQmQ2R2VDUzdGYytvcmttZ0RQS0dr?= =?utf-8?B?ckN6c2ZJSzdrV0pIWGh0VE1PandKREVmWXVRR21WT3dHNUhuWlUxYlprYWM5?= =?utf-8?B?YnIwcytrRXhBWFhYT0ZxeW1zb0NCRktPYkdaN3lCcnl2VkRKeHNVWkFHRmVD?= =?utf-8?B?T3ZYZE9rd28vMDRVSktlSGkvR3ljdG1QQXIrQTFpMFM4bFF5ampFdDJnL2tC?= =?utf-8?B?Tk1mU0o5WTRObjZlNUxDMTN2TkFBaFExM3BnUlJSak45NGx1YWx1Qk1za1ZG?= =?utf-8?B?SGR4UHF6QnlRdFgvakszbWdyV1N2aUJzWnZ0ZkpDc284MHlCVDJPLzVhMDZk?= =?utf-8?B?WHR6b2wvR1h3Uy9aak1zalZqanpKWENUanVMT3QxQktCMHh5dnozU1E3VTlC?= =?utf-8?B?U21pdXdJM1RsRDQrYzhHOGcxOVdLcTNLOG4wTEtvSGVFWWk0azFla3FNenhL?= =?utf-8?B?NG1ETm1FTmVlWjUzYmVyYStoV2hsZytwTXBDNXFod3VPVEl4RmNXWC90UnZO?= =?utf-8?B?c05qeFVSelM1ckN2M3FKL3NUdXM0TkIyTkp1UUFjcEgwMjc0WWIrd2thdHBi?= =?utf-8?B?d3Npa05kR2ZWaVEzeTNZWXRJZEE5Z3dMcjBPbFFDakJzME10UlRpQkoxTXll?= =?utf-8?B?ZjJ5Y1labTZBbGx6eTAzRlBQa0s3My8xUDdxb05Tb0pxWkEyOTY3ckprb3ky?= =?utf-8?B?M3pwSndtSWk5RHlrdktybU54UCtkeGYyM0ZPeXR5NjByYVBVS1BBeEc2T1FY?= =?utf-8?B?OFlScElmelIwMFhkaEU1LzI5eHVlNW81UDVsbWJUY2hVdFF3ME9YT3RqWFVC?= =?utf-8?B?YS9Ya1ZjREZ5YW5iaEE1NEhBYkdjaXBoMGV6QVpSTUVkNWtLbk92cnAvYVRO?= =?utf-8?B?MmhXSHdHSEtQYlQ0bUpZQXloMldnQlBJZk1hcndwVkZqK1Erdjk4QWpVRERz?= =?utf-8?B?OEd3bzJncCtlc1U5anBBMUt3RVZqUXBKQkNyZVYwUW01aVphMytqQ01laU9l?= =?utf-8?B?YzhOTW9rRkZQQ1BqdzVoWFR1Mis1ZmpkeWVYdjBqckN1aWQ2R0t0OFE2T3Vy?= =?utf-8?B?SzIxQUNrUTVOV04wSXhNMGhyTmFTMUloTUFJRkkxVVpFN21jdE9VZ2YweDZM?= =?utf-8?B?dFNtemN4VDlzTXZ3WFJDVVRnOXlvMzN6VEVTUzByZjNFajZVb3dRRWI2dFdL?= =?utf-8?B?N2VRVU9wR3JENFpHQjRab0g0VDNYR3hFa011QXprSjhWd3ZFYkVicTI3Y1Uv?= =?utf-8?B?QVRhTm1JTGZlK1lQRlU0RWlGL1UrMVVDRnk3TDVVKzAranFLYlR5Nlg4QkJ2?= =?utf-8?B?UHh2THl0WERWUllHL0REY0ZxZTk2Vko1anQ1bFE2Zjc3TFVHSXMvcmRPV2lE?= =?utf-8?B?NlM4WjNsY2RtZVFlMU1aNTN6VVFEOElaamhFenpKemR0b3E3VVVWR29wNTVV?= =?utf-8?B?WHpKSEhFbFFscHFMdk5rKzVvb1FYTnNDOENYRmZXT2doZTg5RzlPdFNjaDBh?= =?utf-8?B?alVOZXBjczAwS0xPSkZKK0tKWTFhWlN2bXlCSnpISVRRNmJDQmc3TWxwZ0tJ?= =?utf-8?B?U29nYXlpVlhabEIxQi85YmZsUzBUcjRyNld5dUtLQ2paLzRFOXNMZ1VVdTFl?= =?utf-8?B?ZGVsaTdXNFNNSWZrMnlOb3Nwbi85ZnpYOHpWMVZ5bVNZck5HMlNDU2xjc0ZM?= =?utf-8?B?TktpYWE4YlBIMzJ5VjZuVElnNkU0cElJUU9mNExRQWdBdGE4QmdqV1BsZUVp?= =?utf-8?B?OVI0dDBraGgrVEV3bzJ2b0luRUV5cEJid3JKa1RtQ3BmbkFWbStqejhsYTNy?= =?utf-8?B?dVJiT2wwUEdiUUlGZitSZUtXRkg2MUl0TGI2c2twUXFtazI0TWc1V3d1RmZ5?= =?utf-8?B?Z0ZGM0kvS21mbzNIS2NMS1l6VlgzdEI3alV1S0UxU2wvc2tScncvMUxSZ2tw?= =?utf-8?B?NnBta2tSMmpVZ2JHd3p5SGpJSng5NVJzaVpMSCtmdWp5VHQ4M3ZrZ0NQVDVQ?= =?utf-8?B?WktxWDAvYkFTTE0vTkNqcmpPQVF0YzU5L2UwSVhUSlZzcG1IQURkQS84U0xU?= =?utf-8?B?R0VjdTdXa2w3a1RTQ0VJT2s5bzZ4ZkVqV2VySzhrcStsU0FTSlBYNHJ2eFcv?= =?utf-8?Q?BFaUxaPVMFVoRGbQTsYHLWTi/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bf3468a-e08b-423f-5ea4-08da6011182d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 12:06:16.4245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h5HKn1Z81W9vgvpKCkPkZJQyAmRw4898qnhszw90597PFWNtnB52yV965n1I+eMqPemuO7DMLr05yYc/5gfL9A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8887 On 07.07.2022 13:58, Wei Chen wrote: > Hi Jan, > > On 2022/7/6 13:44, Henry Wang wrote: >> Hi Jan, >> >>> -----Original Message----- >>> Subject: Re: [PATCH] EFI: strip xen.efi when putting it on the EFI partition >>> >>> On 09.06.2022 17:52, Jan Beulich wrote: >>>> With debug info retained, xen.efi can be quite large. Unlike for xen.gz >>>> there's no intermediate step (mkelf32 there) involved which would strip >>>> debug info kind of as a side effect. While the installing of xen.efi on >>>> the EFI partition is an optional step (intended to be a courtesy to the >>>> developer), adjust it also for the purpose of documenting what distros >>>> would be expected to do during boot loader configuration (which is what >>>> would normally put xen.efi into the EFI partition). >>>> >>>> Model the control over stripping after Linux'es module installation, >>>> except that the stripped executable is constructed in the build area >>>> instead of in the destination location. This is to conserve on space >>>> used there - EFI partitions tend to be only a few hundred Mb in size. >>>> >>>> Signed-off-by: Jan Beulich >>>> --- >>>> GNU strip 2.38 appears to have issues when acting on a PE binary: >>>> - file name symbols are also stripped; while there is a separate >>>> --keep-file-symbols option (which I would have thought to be on by >>>> default anyway), its use so far makes no difference, >>>> - the string table grows in size, when one would expect it to retain its >>>> size (or shrink), >>>> - linker version is changed in and timestamp zapped from the header. >>>> Older GNU strip (observed with 2.35.1) doesn't work at all ("Data >>>> Directory size (1c) exceeds space left in section (8)"). >>>> >>>> Future GNU strip is going to honor --keep-file-symbols (and will also >>>> have the other issues fixed). Question is whether we should use that >>>> option (for the symbol table as a whole to make sense), or whether >>>> instead we should (by default) strip the symbol table as well. >>> >>> Without any feedback / ack I guess I'll consider this of no interest >>> (despite having heard otherwise, triggering me to put together the >>> patch in the first place), and put on the pile of effectively >>> rejected patches. >> >> I did a test for this patch on my x86 machine and I think this patch is >> doing the correct thing, so: >> >> Tested-by: Henry Wang >> > > Because there was no Arm EFI environment in hand at the time, Henry only > tested the x86 part.I have setup an Arm platform with UEFI v2.70 (EDK > II, 0x00010000) today, and this patch works well when boot Xen as an EFI > application from UEFI shell. > > But the binaries sizes are the same with/without this patch. Is it expected? > I have enabled: > CONFIG_DEBUG=y > CONFIG_DEBUG_INFO=y Well, the way "xen" is built (and "xen.efi" only being an alias thereof), debug info is stripped in the course. That's quite different from x86, where - with a new enough linker - debug info is retained while linking (and it is truly linking by which xen.efi is built), and hence can make sense to strip while installing. > Is there anything I should be aware to test this patch? > > -rwxrwxr-x 1 weic weic 1081504 Jul 7 18:43 xen > -rwxrwxr-x 1 weic weic 1081504 Jul 7 19:43 xen > > Tested-by (Arm only): Wei Chen Thanks. Btw the proper form of the tag, as of a couple of months ago, is Tested-by: Wei Chen # arm Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 12:06:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 12:06:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362967.593268 (Exim 4.92) (envelope-from ) id 1o9QHY-0004oy-UZ; Thu, 07 Jul 2022 12:06:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362967.593268; Thu, 07 Jul 2022 12:06:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QHY-0004or-Rh; Thu, 07 Jul 2022 12:06:56 +0000 Received: by outflank-mailman (input) for mailman id 362967; Thu, 07 Jul 2022 12:06:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QHX-0004og-CC for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 12:06:55 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 493008d5-fded-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 14:06:53 +0200 (CEST) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 267BwHFs030574; Thu, 7 Jul 2022 12:06:45 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3h5fvvb7ag-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 07 Jul 2022 12:06:45 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com (2603:10a6:102:ea::23) by AM6PR03MB5266.eurprd03.prod.outlook.com (2603:10a6:20b:c4::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 12:06:39 +0000 Received: from PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2d63:5490:24b9:415b]) by PA4PR03MB7136.eurprd03.prod.outlook.com ([fe80::2d63:5490:24b9:415b%9]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 12:06:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 493008d5-fded-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRWGbBSbIGuz1BF16vmi/wnRtSHjUlyixsh8p3if1M2g1YYKMFy5lKsfQQp6cZo9c0AFf1/tl97VYVV9VHxjnUwrH6Cc5BqFFLh9QLtWRAkqMf8wUcKJd2zKhJeC0mdQx67N4qu2sgNp7zvgJJ+oc3XL2u45XbUqSGOrZtAMZUwHyhDjsszM3+rFaEPB/aW1M6fSRajDy8eNlFZn3gZWTvZO48w7SFFEalTOR0ZfvcGRN7oWGDFW2glCW+r+GCNvGW9AstJ1ryFXH6v1Y770afq/Dvr5R4nJLT7wkV1rnDFYUH7EYinUUldD60laA1+vdUnI+Jpx8VIXs6/Niw4RNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+GTJ/PGTCIjb+M63Zhn/rEyohdqXK81GiesLJm41nJc=; b=J8yUIkp1uDnxsDF2vNuQ+Hc93ZnZOAXn+ns65OtOYnF0xxIWxfTJj2fq5GvKMQRAUu1ncPt4QjsfFko7vvfO7G2dPMCjoJgOwlkfiuyRaTEB6H/y3SM/AtfaoaPby81tN/DIPnr4JmgQpYaPjpt3H6eaa6Hyd64x/YKf3nvlHlB9gPwtAyZcoZ/WZHqhSdRItPStaYQjngEW1N83am8XY0fOcuh/h4cxek3Ok0SZVXdbyjxhmVHX3P1X2ndQN6NyIpqsR6Wajjt6+/SO6mx35mBQczsGPVHTv3cU3VG2NJgrqW+FnM8ur91PObotahf691o1tqidwT4KfQrM5zgTJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+GTJ/PGTCIjb+M63Zhn/rEyohdqXK81GiesLJm41nJc=; b=IBSJQJOqjvcR6eYvuiHSvbt5Wn9siIyAjnsNDYBVgfPIgOx23mst9VJZ0vNZ2tj7DbbzdWUI/UG0QD6hU2dzxQZkuT2EEmlDUzWBbLRaAVfB1VO3ecsE1l0pBXZEmKstqJ29MdorRybMmHAXUnsZdtmu+K/BjSHvUxorD4OTrdENuikkC/TNh9ufI5QLeBoZlz1xupIC0yf4oN8NkYRJb1FSr0J8M+X4xShat9jXcUOyhot1WRw1xH3cBIwXXTNkkAOFUOcgwZXfVGHAVtXGNUNbtxq9Z6IMbsWXeT5lAqXAypPzdxZM0wSiiS4BXRYhSo3/PZcNdp2hKZVmNq5uvQ== From: Oleksii Moisieiev To: Jan Beulich CC: Juergen Gross , Wei Liu , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Andrew Cooper , George Dunlap , Nick Rosbrook , Anthony PERARD , Paul Durrant , "xen-devel@lists.xenproject.org" Subject: Re: [RFC] DVFS and Thermal management subsystem proposal Thread-Topic: [RFC] DVFS and Thermal management subsystem proposal Thread-Index: AQHYke02Cidd2c7KkEyfmAiMVFzcy61yzQ4AgAADHAA= Date: Thu, 7 Jul 2022 12:06:38 +0000 Message-ID: <20220707120638.GA1989842@EPUAKYIW015D> References: <20220707103500.GA1959452@EPUAKYIW015D> <16803e7f-5a7e-91c0-03f0-3133e0dff957@suse.com> In-Reply-To: <16803e7f-5a7e-91c0-03f0-3133e0dff957@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5cc53e90-6e79-4321-8abf-08da601125a0 x-ms-traffictypediagnostic: AM6PR03MB5266:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ofr+ESxF2Qx2R9PzT06BhKKzcJCqLnyU3IzNLQ/O7Yj4cr/7ZuqMjypV0LGSR8nZZUthqU1QIGxW7w9h7A9ehMDUT3xu+mrJPgcNUxn7LVRkLV5LvESEDdjKZ3ImpLKSOSWBfg23rDy8ahWpWjxaKTk/Vmo0jBF3yRha6xvT4MMbLMSzZ99Lo/EAEKXedLGTQaAkSdFZRABOJO+3Nvc+yNIZu06dtZ1BHf/LYk1jSAhuO6lOpXhUc94aq2b0aMeE02X6Py69qWun50LTQadNvIko6oPql6MnU08nOqxcGPNYM78XtD2DpDDfzHhe7vhDD8rfwNKszHEVAsNXf1YnccXqEC28Y1jHCbmZ4MQGHSqBI81+4V4O+/g7Xkjua1NFd/MKccAlkR55MromRQ4EK6rMUEZmDGmve9CAqxYfZTyjyv9yU1z/TPVD74UaDY805zAToTQCRSBL6tg/yDFeP8lwY2a6v7oPu88J8u8WXnrUdrsevLwGLBJT51GX0K3Ejn19Ngf8RRPJUk7jc3h8k4P90zMqQP2ObJX+v+Y78NFQLR4ewEJtUJQRG9u9Iv14aAPpvaRWxB06gWf0NNvNd/icIjB4aXRI7kI9sQ0tGR8hNpYA9HLCR23q0g3QxbmzURm0LS23O67h3VH/UDB5Le9LUU3RsyD5AtRgUBRXLxaqNC1BPrC0Km2BRIEGqMAINMJ/3N8gTtxNdgezJYsxAbciN1nD//iQM4MQeV+PQPEumVlwSYKLHQxEJ6HsJ1ZimJRGAKmoSXo3tRnZFib/WboicTCzZWmHIB50gFaw7VlwKqqkDwBW34JWHYnAGcFZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA4PR03MB7136.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(366004)(396003)(136003)(376002)(39860400002)(346002)(5660300002)(76116006)(66556008)(66476007)(64756008)(66946007)(4326008)(8676002)(66446008)(8936002)(7416002)(33716001)(2906002)(6916009)(38100700002)(33656002)(86362001)(83380400001)(38070700005)(91956017)(122000001)(6486002)(71200400001)(41300700001)(316002)(478600001)(55236004)(54906003)(186003)(1076003)(26005)(9686003)(6512007)(53546011)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YAEabt9NIZk2m2MFhrgjFd4eaiRi80m9rlsUrmvYDHTpEjktlgtaAd1EneX8?= =?us-ascii?Q?OdUx3ePKq2CJP4GKksDsk0XV53CPA8P58+StTS4sDzufpadZH/G0wTRwe6O3?= =?us-ascii?Q?0yt+bI6vA6seQxU2RNof8Kv2ROs5kw+vaQ99BQT8gF4gaShoHgL7VINzg8nR?= =?us-ascii?Q?XeHnoHgC/lHIL2kwyNe7Jc4sX8wmgKLHSwsJRNzvoJd9H+BU2btOWrtWOJJS?= =?us-ascii?Q?XG0ala84jd+C2oN+BbMFn+b8+LpNkGoTUwBChsF7f7rVfS5a7zwto2dRQmUu?= =?us-ascii?Q?0/7/3A6eh8cGGXwWvUnedCH7lALkNv3vnM2OOVpLOFB0JoFzYZOBMTZYWi7D?= =?us-ascii?Q?A2ux3oRmdLVC1FUiUYbvNqT+uGpR5KOoSj/N4FRK95wERJwY9I2ZAOylV8wK?= =?us-ascii?Q?ZunBX4EMJgTglDCY0fhL82jpypCbQRi2eqs7sE5SI9CM6y3R3gtTuVofZECv?= =?us-ascii?Q?TyIznijK+phvSPHaBVbeqs13ALtFqoCwphKBJ1gOQP4VwsdsobWQW7zy4U72?= =?us-ascii?Q?JBt1deK2DUnzaAZezcYHrWESZSbuJDnHO2pb6DF1tc1rWHSwEv55oz9eISax?= =?us-ascii?Q?k0mNFWPDbiO9gEx78YJjO8xP938JcMQuY/zv8qNSkDq0ZtiSMY9YsnxCyZkd?= =?us-ascii?Q?v87cytKpMi9tLvX5PUfpK6DDwfSL+IaIwcH3cjOKks2EVLMygoyMcnez16ZJ?= =?us-ascii?Q?ha2Q2qhnOHXsnXSjW+WXUDRzbwG1oHqXpbB0nJ1/RXjp1dxYTu08TcVryVB+?= =?us-ascii?Q?B8047PSandfe+ABveguHVcA56VFtevDSPQ7XoK0TRxvz0IyDCEToq/rz2dpC?= =?us-ascii?Q?eeQ98YOgZW50jPTRQ2erNHNX7ZOKHvEH5M0QP5Pj7GJQyQHhnMHkZN5AmuLZ?= =?us-ascii?Q?ihYzjNX+Xl/+sQMz0yuPPi9LewpJvYM8aFr6yKYKc7VUB7KkhanWHpEgxke5?= =?us-ascii?Q?tsh0C7nGyhNwUY2zDXxPzyCjQnPwJJ0/a8e+c5pZtUY7yItXJN33RdinEdHY?= =?us-ascii?Q?1yjO2/L5HK85y0yjjUDJEOmt7oASEYtiIuN8AngAINsV2Pz7JqD3P77FgzO9?= =?us-ascii?Q?RaDq0SLw6EYFaki6kCijSUOjz6zoOPmqPefk9ifNoAtlVQmJ7ISygRTPEuXt?= =?us-ascii?Q?bdVfLApxxU4Sbbib8HhdYZ70H0TF+dpXOEdOuTq02lz5H0ZNiq1M62YasMFh?= =?us-ascii?Q?exzrZ3NZX/6gukbUUV3T56yk+JRMK7APuEaf+z+1hLFWWFR9Wxiyj84O4B2a?= =?us-ascii?Q?nsrKKyuVzjqLOUVhg4EAdNRGoyps2SHWnrW7FqPnNnRKXyXyu0L42bMUzpEc?= =?us-ascii?Q?NP47w1nY13D/WY5XXbsNd3yny8jyfOvaUWITMiQeijpX1gOpllKTnnfmE8lC?= =?us-ascii?Q?evAqYIiTBofd6wVwCrVR7MYz5r/COyrdRvR6wVey4NBkeP8o7twbcg67pJXi?= =?us-ascii?Q?CkRIXU7QcYYDJra+BNs5TkZ4Gfr4iaqPHhOibJ91IEiWoo8O5VSOOOpT1Gvt?= =?us-ascii?Q?4Vgg9Z3jqOLjalTYDOdt0VT3Yfkpx+muIAb4NsqhhDbl3sWetiZshUNm8RI9?= =?us-ascii?Q?t0WEw2Pk58BIQhTu+bHaQSbekA/SnXDcST3BJtMbps5rpsZalD40s/VvXkfm?= =?us-ascii?Q?4g=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-ID: <6E4098D2890E2A4280AB5BABEC902926@eurprd03.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PA4PR03MB7136.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cc53e90-6e79-4321-8abf-08da601125a0 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 12:06:38.7698 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dk2NZh8vqGLPDuu9XsyEqbXfFaR4q5On2ynCasrnObdywXuOK1VP5OUhIg1zhjbrRzJWzmzv1VPjkRW427lOXCqMNUrcL83RTHamH9jo8X8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB5266 X-Proofpoint-ORIG-GUID: e6Qm8pTfDMgwiOYXS4j2nhAhWIQYsvRK X-Proofpoint-GUID: e6Qm8pTfDMgwiOYXS4j2nhAhWIQYsvRK X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-07_09,2022-06-28_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207070048 Hi Jan, On Thu, Jul 07, 2022 at 01:55:30PM +0200, Jan Beulich wrote: > On 07.07.2022 12:35, Oleksii Moisieiev wrote: > > # Synopsis > > This document is intended to describe the design of the thermal based c= pu > > throttling in virtualized environments. The goal is to provide generic = thermal > > management subsystem, which should work with existing cpufreq subsystem= in XEN > > and could be used on various architectures and hardware. >=20 > Looks quite plausible to me, just two questions: >=20 > > # Cpufreq subsystem in XEN > >=20 > > ## Brief overview > >=20 > > Governors > > +--------------------+ > > | +----------------+ | struct cpufreq_governor { > > | | ondemand | | .name > > | +----------------+ | .governor > > | +----------------+ | .handle_option > > | | powersave | | } > > | +----------------+ | > > | +----------------+ | +------------------= ----+ > > | | performance | |->cpufreq_register_governor() | +----------------= ---+| > > | +----------------+ | | | cpufreq_dev_dr= v || > > | +----------------+ | cpufreq_register_driver()->| +----------------= ---+| > > | | userspace | | | +----------------= ---+| > > | +----------------+ | | | ... = || > > | +----------------+ | | +----------------= ---+| > > | | ... | | struct cpufreq_driver { +------------------= ----+ > > | +----------------+ | .init +------------------= ----+ > > +--------------------+ .verify | Hardware = | > > .setpolicy +------------------= ----+ > > .update > > .target > > .get > > .getavg > > .exit > > } > >=20 > > Cpufreq subsystem consists of 2 parts: > > 1) Cpufreq governor, which should be registered using cpufreq_register_= governor > > call; > > 2) Cpufreq driver, which provides access to the hardware should be regi= stered > > using cpufreq_register_driver call. > >=20 > > ## Hardware drivers > >=20 > > There are two Cpufreq hardware drivers implemented by us (see Appendix = 1 and > > Appendix 2) to provide support for Rcar-3 and i.MX8 boards. Those drive= rs are > > designed to support thermal throttling subsystem. They are going to be = the part > > of the contribution package. >=20 > Are these drivers also intended to act as "ordinary" cpufreq drivers, > i.e. controlled by cpufreq governors instead of thermal ones? >=20 The idea is that cpufreq drivers acts as ordinary cpufreq drivers, controlled by cpufreq governors if temperature is fine. But cpufreq opp level can be overriden by thermal subsystem if critical or passive temperature was reached. > > # XEN Dynamic Thermal management design > >=20 > > ## Synopsis > >=20 > > Introducing the design of the Dynamic Thermal Management for Xen hyperv= isor. > > This feature is an enhancement of the Xen DVFS feature and will allow s= ystem > > admin to configure different thermal governors which will perform CPU > > throttling, based on the CPU cores temperature and thermal configuratio= n. > >=20 > > ## Top level design. > >=20 > > +-----------------------------------------------+ > > | XEN | > > | +-------------------+ | > > | | Thermal | | > > | +----->| Governor | | > > | | +---------|---------+ | > > | | | | > > | | +-------+ | > > | | | | > > | +------------------+ +------------------+ | > > | | Thermal | | Cpufreq | | > > | | Driver | | | | > > | +------------------+ +------------------+ | > > | | > > +-----------------------------------------------+ > > ^ > > | > > | > > +--------v--------+ > > | | > > | Hardware | > > | | > > +-----------------+ > >=20 > >=20 > > ## Thermal management subsystem design in XEN > >=20 > > +------------------+ > > | +--------------+ | > > | | powersave | | struct thermal_governor { > > | +--------------+ | .name > > | +--------------+ | .governor > > | | stepwise | |<------------+ .handle_option > > | +--------------+ | | } > > | +--------------+ | | > > | | ... | | | > > | +--------------+ | | > > +------------------+ v > > +----------------->register_thermal_governor() > > | > > +---------v--------+ Polling temperature > > | dyn_thermal |<--------+ +--------------------+ > > +------------------+ +------------>| polling_handler() | > > +--------------------+ >=20 > Polling (only)? >=20 Here I described "worst" scenario when HW do not support IRQ in case of alert. Both Rcar-3 and i.MX8 patforms have alerts so drivers will use irq handlers to do throttling. Best regards, Oleksii.= From xen-devel-bounces@lists.xenproject.org Thu Jul 07 12:46:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 12:46:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362977.593279 (Exim 4.92) (envelope-from ) id 1o9QtM-0002ZZ-Ra; Thu, 07 Jul 2022 12:46:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362977.593279; Thu, 07 Jul 2022 12:46:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QtM-0002ZS-OR; Thu, 07 Jul 2022 12:46:00 +0000 Received: by outflank-mailman (input) for mailman id 362977; Thu, 07 Jul 2022 12:45:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QtL-0002ZM-HX for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 12:45:59 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6295969-fdf2-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 14:45:42 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id e12so30901656lfr.6 for ; Thu, 07 Jul 2022 05:45:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6295969-fdf2-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FLcfrXYjK2fwrrDKdqGjcVMFG48UBdYQu2HVE7B/VAI=; b=IEjOMTXrJwNeqUA6s5mVpo4ZKCU936JfTqmXA1uWFc2yQFcG5eLJuLMLFIlDkwHYfD rjShJtrqPrcp+zuVj5aaTUk86TGljPaM+nnnEjGo4MA5ld6l8tj7sYRETVZAA2/DDFp4 9DNXEBnM/YOSvD2IMSvYNfWDgEtd5IjOUxENhVDuC2yZ6BIjOX2xlBheFVy7/40zRkJH 8DIQkGvdHtKf8Qjr8spRH8MT3pd4KLFRX7c/RVLijADkHTqM1BorCmfLDiSLzYAGOV9f B8sPJkvyU7daYXwaPrF6NxOc7cGlt/Si50jU7L/wVBZRtSXV9IpmKZMAcGTv9lN5x3sA 4x8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FLcfrXYjK2fwrrDKdqGjcVMFG48UBdYQu2HVE7B/VAI=; b=LH7QU95Fz2QOujRx5uftFGQJQvR0h9poBcdosIlxTsPyqVXLzN9rbK150gEGLX2wxc qtWdWWn/VHrLnB+98r8cmMWEU35HrMjKN8ZniVJ+y7tNT8gqIde9lXPx3Y1jW5xPGJZF ckdiHPeKsPevhN6KVRlJ3QiNT4ozKVr3loitLSHGUeFp5Ea3ZQCc86DcYGL73VerBfl6 LIDmEVB2KUnSMl2OVSyCEKYmo7Jn09DgU9HeaILEQkeoJbxvu3OPyzEluj/AZL+wP7DL 7FMMppYPLiAagzFcriyd/lgdg/g9XpgdGCp2WOTylxRG9KMYFnKNSkeSHw2PfoO4hqh9 v37g== X-Gm-Message-State: AJIora/gpHB4Jg5vn/et+8GsjnRx3sZW7+kQdc8HthvkvakcwZBuGN9w mW9LE0utN4bXtfWOBc71Ss4Jf6VAaMAkP6USc6M= X-Google-Smtp-Source: AGRyM1sntLAsGaKOHwMlrBARRF0dPEHb0dl2oRaVtuqPaCXTMNgajhqz8jZIxhDDUgoSgxO3zWS/kfcoWP/MDDjN4s8= X-Received: by 2002:a05:6512:2508:b0:480:f1cb:64ad with SMTP id be8-20020a056512250800b00480f1cb64admr32019790lfb.359.1657197957688; Thu, 07 Jul 2022 05:45:57 -0700 (PDT) MIME-Version: 1.0 References: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> <20220706191325.440538-1-jandryuk@gmail.com> In-Reply-To: From: Jason Andryuk Date: Thu, 7 Jul 2022 08:45:46 -0400 Message-ID: Subject: Re: [RFC PATCH] flask: Remove magic SID setting To: "Daniel P. Smith" Cc: Anthony PERARD , christopher.clark@starlab.io, Daniel De Graaf , Scott Davis , Wei Liu , xen-devel Content-Type: text/plain; charset="UTF-8" On Thu, Jul 7, 2022 at 6:14 AM Daniel P. Smith wrote: > > On 7/6/22 15:13, Jason Andryuk wrote: > > flask_domain_alloc_security and flask_domain_create has special code to > > magically label dom0 as dom0_t. This can all be streamlined by making > > create_dom0 set ssidref before creating dom0. > > Hmm, I wouldn't call it magical, it is the initialization policy for a > domain labeling, which is specific to each policy module. I considered > this approach already and my concern here is two fold. First, it now > hard codes the concept of dom0 vs domU into the XSM API. There is an > ever growing desire by solution providers to not have a dom0 and at most > have a hardware domain if at all and this is a step backwards from that > movement. Second, and related, is this now pushes the initial label > policy up into the domain builder code away from the policy module and > spreads it out. Hopefully Xen will evolve to have a richer set of > initial domains and an appropriate initial label policy will be needed > for this case. This approach will result in having to continually expand > the XSM API for each new initial domain type. Yeah, adding dom0 vs. domU into the XSM API isn't nice. My original idea was just for dom0, but I added the domU hook after you basically said in your other email that dom0less had to work. There should not be any more of these since they are just to provide backwards compatibility. A dom0/domU flask policy is not interesting for dom0less/hyperlaunch. So I don't see why xen/flask needs support for determining sids for domains. If you have dom0less/hyperlaunch + flask, every domain should have a ssidref defined in its config when building. If you require ssidrefs for dom0less/hyperlaunch + flask, then there is less initial label policy. An unspecified ssidref defaulting to unlabeled_t is fine. I saw your other patch as adding more "initial label policy" since it adds more special cases. I see requiring an explicit ssidref or getting unlabeled_t as a feature. Automatic labeling seems like a misfeature to me. Regards, Jason From xen-devel-bounces@lists.xenproject.org Thu Jul 07 12:46:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 12:46:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362978.593290 (Exim 4.92) (envelope-from ) id 1o9Qta-0002uu-8j; Thu, 07 Jul 2022 12:46:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362978.593290; Thu, 07 Jul 2022 12:46:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Qta-0002ul-4q; Thu, 07 Jul 2022 12:46:14 +0000 Received: by outflank-mailman (input) for mailman id 362978; Thu, 07 Jul 2022 12:46:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9QtZ-0002ZM-3j for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 12:46:13 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2083.outbound.protection.outlook.com [40.107.104.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bdd53a4f-fdf2-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 14:45:55 +0200 (CEST) Received: from DB6PR07CA0067.eurprd07.prod.outlook.com (2603:10a6:6:2a::29) by HE1PR0801MB1708.eurprd08.prod.outlook.com (2603:10a6:3:83::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 12:46:06 +0000 Received: from DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::59) by DB6PR07CA0067.outlook.office365.com (2603:10a6:6:2a::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.5 via Frontend Transport; Thu, 7 Jul 2022 12:46:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT005.mail.protection.outlook.com (100.127.142.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 12:46:05 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Thu, 07 Jul 2022 12:46:05 +0000 Received: from fcc92fca99e0.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2F46E9C8-C299-43E9-BFCA-AD193BB6BE62.1; Thu, 07 Jul 2022 12:45:54 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fcc92fca99e0.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 12:45:54 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM5PR0801MB1970.eurprd08.prod.outlook.com (2603:10a6:203:4a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Thu, 7 Jul 2022 12:45:49 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5395.022; Thu, 7 Jul 2022 12:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bdd53a4f-fdf2-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nWNl/X3nBwqEMzlww1lZXiKenIgQLXCeyp/WwVx9TEQCIJj2LBMEDix5qx5AQolOD/4B7vkN1rJk+89ABwBSgH4Q0ujD9/7AABSA04JH5FrB2wbODkdRNBuxjsAc6vLj451L/16pZAeO6o5hrg1XXpiCUwUr9HGtNSy8sl50YFDiRCNf37/LySMDwlfFSXVRqnw7QlcYYJlKhuBZpnltqbnjG9veMMCfEgeLS/BBISTwv/HNNGE+NV62HTSqc/yWWz35sKm5nILSEPrrvXYsYhblRkmEnoPpskqBuhLJxq6u3QiKKFgs0eJawgOUBdWzW+gTWBPaq4eEgYsb8048Vg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uk03DcIlcU6IXh9gtiFDnM0oFDBzzoxV/R5zUzRo4RQ=; b=PHbkgyTzCrX9FNXyOKWWaNHVE1JcFwSRT7tYkmH+u6Kwodrw88Hf5sLD6SdFr0FsgqKFt3VHv3/ZnVqhXwJAgRr6NYb5dVLjtemNve5bMR/Un4NyafnfgVs1pW2lz18nZWygLkqD4ipy5UPsmINWeA/VsiPKZbqhs/xYpYijF6w0ubeBSvU+zdtNLNzugHRMDhOTuiQbUz5KfFBbLUpHwsT4VBthp0UVigPwaOLBN+DcYDQMYsAba/0ZH9900ekllmXzBRkYRgcOq51OJcjyVaYgHnkfleAWBlz4D1Sav0cccx/TOblGfAYZJVM+q/wiqGm3vmZjV5gSBUawZbt0YQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uk03DcIlcU6IXh9gtiFDnM0oFDBzzoxV/R5zUzRo4RQ=; b=iS4Evl/fOHKNgtpYLafs5BG6DTRbXUew0bLeeMTg0Mlu8OtCigiR7IZWCoURvcpldLYN2R7v+ypSRCsM2CDiwLhb0QkqtG80cS3Yilrtk6X0RfGzCpZOZgVOQG3Xf6zO23EOAi30R1hF7jNS1j25Ivz/MgtoaXyGwUJGfHsuGb0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a5ad2a3803f48d4c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MiY2SMERUMZafZ0x/VquCTMsrGAQv/u3HQEMQ4Y9Wy9pflDPw+HWHxe0DGhu/szjwSMJvrgXdLA1Kh5t0juoe3rBzzncv2lDKPzdF6sj3NA9DQXjn2zTeXVGesHl6BxXSr8NUifTREFXGF0M4wRqnGbherP+0MnU2fbqw/9O42crDrOWQUgep5wEl0NKmGlwUZZSkS4dibDAlpP5mW2UIftfvlKvuVxfn5ztsxX57zf7JWnCZBd2psYVvnpccOSY8b+VZpJwkB66FSZmNyTcLUiQgNH/FtzOve8r1WwSje+QRLGhYd6Rp55TBKZyhkyQN5WPXUx9/DMCn4Os7PCKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uk03DcIlcU6IXh9gtiFDnM0oFDBzzoxV/R5zUzRo4RQ=; b=SAXmts+K86VSqM2/jTzhWHmZE3OzbbWrLdUUx6QINsNEADgh0z1HXyPkEWAYFfzJty04UTs55HKxmVQdirv5+F/MykYQR7hcM16HNBz9V8Pa9rWmbxEDWMPYVrw/0/m3svshTdhLqhqtQLPJwLgsMrLkzC2ihXaO5rLWhy5ag2CLuh7kCYoej2O9sL7EhzRZYGx5MJxCpKQmqCfIe6aXRCPpzpa/siRlra1Wg55VLJWjAokeXKP0SkyC/R4tYC90hBHJovDROrU1bPc+LDUYyhYRH8Y2WCvXfSDigf9O08GnTJ8gzNCeURcVe5Hw5nr61FuTN2cipRmQ1h6TUhC5+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uk03DcIlcU6IXh9gtiFDnM0oFDBzzoxV/R5zUzRo4RQ=; b=iS4Evl/fOHKNgtpYLafs5BG6DTRbXUew0bLeeMTg0Mlu8OtCigiR7IZWCoURvcpldLYN2R7v+ypSRCsM2CDiwLhb0QkqtG80cS3Yilrtk6X0RfGzCpZOZgVOQG3Xf6zO23EOAi30R1hF7jNS1j25Ivz/MgtoaXyGwUJGfHsuGb0= From: Rahul Singh To: Juergen Gross CC: Julien Grall , Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Topic: [PATCH 5/8] xen/evtchn: don't close the static event channel. Thread-Index: AQHYhkX79rj81mJ150e3nBZ0EA7O6K1bhmuAgAGTuoCAAAWegIAHwJEAgAAJPQCAAAcgAIAAB1iAgArhiICAAAgBAIABW/CAgAAGRACAAAgBgIABpqMA Date: Thu, 7 Jul 2022 12:45:49 +0000 Message-ID: <32D03119-39B7-4C81-B33F-01C3CC47C04B@arm.com> References: <91656930b5bfd49e40ff5a9d060d7643e6311f4f.1655903088.git.rahul.singh@arm.com> <7403EAA7-67A4-4A8D-835E-6015463B9016@arm.com> <67EA3F72-5F6D-4150-A9BA-EAF92E6C9EA1@arm.com> <289ebc8b-96f2-8764-5b17-680734e473fe@xen.org> <77952dd3-e777-f4ca-75d0-c168c10d46d0@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 85f5032e-5432-4ae3-cbca-08da6016a83e x-ms-traffictypediagnostic: AM5PR0801MB1970:EE_|DBAEUR03FT005:EE_|HE1PR0801MB1708:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7x7M2ZbQo9ecjpzueFR6Sh7huoYJ39+NiYWZ4tnk7TEZstmwoxSydD6IoHgqnWi2nrXxlgVKSoeF+xAhG8s5hsY31HNaZ7vBc89qSCIpVuoACgycRo8wQSVdDE9aiIpYQXHb2J6hVyW7h4R8fDhvqcnRySc4RDAKxv0D5PwD2Qi+26JjSctGWa+lSVOaQI4ONQjHJZpNEccqNEr6LoLtMr+SUtOFZ7H2mL2kW5UsNWMe90MlbfZgeOmjfuPcvjevUAAaK3i7nHoTwrJgWyKvXkeLmuS2B8V86GlnU3b+YUikgQ9in+wDxvEnAOSovFD9Ds4VHKh4tndO76G/JkOdq5AA8gFt82ky8NuUSsBCS7rPZMkhYcNKNoesFLKnWXTgWBe/ZoL6hHvBwu203p6cvXGtBD5cRxnc2dkjm3144I9fW17X2MzMdYfrJOdYYVd56xQRdz8ygnXjLpnohSnjwHg3RtkGVm7rQGuMblsvgNDdRVReb9euk8d20RaUqGqLIE5/AuUSPOd/yOfMZwv3sd02aAItn+LkN4b5dVfbcC1NOMj19S7P35/Zt51wvnigwi8JKgExP8BfKhQlhu60PvgAVi8iv8csF0E9NlQPDtkrG55YQ9eok7WNx/hbj+MJZvMEsApStHOvqws18eVG/uGhvC2Tt4/KIw5SpsSbLyjpjx1+A27A0IutdUbMSin2AyDQwnDipkbXCdTYi2olwHML7pjxXcOpaIq+dAW+RFOnn6LYoVeD+veBXsjL9k63IV6KnH/V8/TAWgDI0K0wuyyeaUeUKPLJpN7RSbLoTNhI09mzaqFOmbR1LJ03NCwbfTg/7uKL4f529/tlg6vsni6/tBgted+lIqpmlwytkY4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(36756003)(122000001)(38100700002)(5660300002)(186003)(8936002)(38070700005)(8676002)(91956017)(76116006)(4326008)(66946007)(66556008)(64756008)(66446008)(66476007)(2906002)(86362001)(6512007)(316002)(53546011)(33656002)(6916009)(26005)(54906003)(6506007)(41300700001)(2616005)(83380400001)(71200400001)(478600001)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9AFB477D655F634A9C6D10050638EFB3@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1970 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 14b81e02-81c2-4dfd-d4fe-08da60169eb5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RENSSxekhQ4edrMbrAEb7gV8PD+UbmDMdkjTJXEVwrNRiheAMyQG995b1tqmxdqjBBzknwbVXpws49bCbPjAH4DIvospjFrCZay75q2rbV3pw6faT1fyZUJyevFUtvbKHeaLGTuhKo/SWgnxRimVEVaiDrSObnWtit6o58u38bsTsI+iCiqqPReQXFTKLmM7HtgkZ85ql8NcXm5UPu7+Kf4dGoY4J3bYN32wKrXV0A4/313EKBXgwJ0+7kctr4pwI3zAu8MNbhA1K0D6tDE/BNeYITJmrryaHFqYxk/MdchlQHcV6czEgFQ1ai9f9hiCWD5OVt6ahE+BmKNwRC1D6oUk6nQ7nWvT36Ji9o+Jar1Q90NqT2eA68oNV1vm9nHTTxK6e70WQr+2mnzU9zYpKf4mfCwzeqsnlq5dhwKxITxfBpXLJzQRGBxWoz0ivtNSr/D6CMwHlRYev0vQJ0EVjKqk47afcDM16uoHltcqMFzVoDjdMKrXjwR/US8/PV6698Z+R2FdcKYtlfY/5FTWrxY+FESOnTyuNoUdSDNN1x2d+c0BbqX2WCJ0Bmi8FYrZPrV+4VOOFmbcXQZ4+vmSrqHITZHOCnlxyAxIxNzo08bZPDF9JSFX1aOLl0mDarqODdYv8snQrlZgB1zMWlcomOijiZQWGIIaMwMDU29eznJ3hehOlL7pbPHMUaqFGGIDgnBLHb2INVDvpuYb/L5Lqy75aEVySVNww6QZqYcT2SMsh/TGk62EAttgf0YKkMmwMZ23PAbW1mxClvXaNo0OvhdwQ4STSR1qgMky6PikNL0nfauWTKMxN3ntuzPYsy8N X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(39860400002)(136003)(36840700001)(40470700004)(46966006)(6486002)(6862004)(8936002)(40460700003)(186003)(478600001)(40480700001)(86362001)(5660300002)(336012)(2616005)(6506007)(26005)(2906002)(6512007)(47076005)(70206006)(53546011)(41300700001)(33656002)(82740400003)(356005)(83380400001)(82310400005)(81166007)(36860700001)(36756003)(8676002)(54906003)(4326008)(70586007)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 12:46:05.4424 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85f5032e-5432-4ae3-cbca-08da6016a83e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1708 SGkgSnVlcmdlbiwNCg0KPiBPbiA2IEp1bCAyMDIyLCBhdCAxMjozMyBwbSwgSnVlcmdlbiBHcm9z cyA8amdyb3NzQHN1c2UuY29tPiB3cm90ZToNCj4gDQo+IE9uIDA2LjA3LjIyIDEzOjA0LCBKdWxp ZW4gR3JhbGwgd3JvdGU6DQo+PiAoKyBKdWVyZ2VuIGZvciB0aGUgTGludXggcXVlc3Rpb24pDQo+ PiBPbiAwNi8wNy8yMDIyIDExOjQyLCBSYWh1bCBTaW5naCB3cm90ZToNCj4+PiBIaSBKdWxpZW4s DQo+Pj4gDQo+Pj4+IE9uIDUgSnVsIDIwMjIsIGF0IDI6NTYgcG0sIEp1bGllbiBHcmFsbCA8anVs aWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+PiANCj4+Pj4gDQo+Pj4+IA0KPj4+PiBPbiAwNS8wNy8y MDIyIDE0OjI4LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+Pj4+IEhpIEp1bGllbiwNCj4+Pj4gDQo+ Pj4+IEhpIFJhaHVsLA0KPj4+PiANCj4+Pj4+PiBPbiAyOCBKdW4gMjAyMiwgYXQgNDoxOCBwbSwg SnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+Pj4+IGEgbmV3IGRyaXZl ciBpbiBsaW51eCBrZXJuZWwsIGV0YyB3aGVyZSByaWdodCBub3cgd2UganVzdCBuZWVkIHRvIGlu dHJvZHVjZSBhbiBleHRyYSBJT0NUTCBpbiBsaW51eCB0byBzdXBwb3J0IHRoaXMgZmVhdHVyZS4N Cj4+Pj4+PiANCj4+Pj4+PiBJIGRvbid0IHVuZGVyc3RhbmQgd2h5IHdvdWxkIG5lZWQgYSBuZXcg ZHJpdmVyLCBldGMuIEdpdmVuIHRoYXQgeW91IGFyZSBpbnRyb2R1Y2luZyBhIG5ldyBJT0NUTCB5 b3UgY291bGQgcGFzcyBhIGZsYWcgdG8gc2F5ICJUaGlzIGlzIGEgc3RhdGljIGV2ZW50IGNoYW5u ZWwgc28gZG9uJ3QgY2xvc2UgaXQiLg0KPj4+Pj4gSSB0cmllZCB0byBpbXBsZW1lbnQgb3RoZXIg c29sdXRpb25zIHRvIHRoaXMgaXNzdWUuIFdlIGNhbiBpbnRyb2R1Y2UgYSBuZXcgZXZlbnQgY2hh bm5lbCBzdGF0ZSDigJxFQ1NfU1RBVElD4oCdIGFuZCBzZXQgdGhlDQo+Pj4+PiBldmVudCBjaGFu bmVsIHN0YXRlIHRvIEVDU19TVEFUSUMgd2hlbiBYZW4gYWxsb2NhdGUgYW5kIGNyZWF0ZSB0aGUg c3RhdGljIGV2ZW50IGNoYW5uZWxzLg0KPj4+PiANCj4+Pj4gRnJvbSB3aGF0IHlvdSB3cm90ZSwg RUNTX1NUQVRJQyBpcyBqdXN0IGFuIGludGVyZG9tYWluIGJlaGluZCBidXQgd2hlcmUgeW91IHdh bnQgWGVuIHRvIHByZXZlbnQgY2xvc2luZyB0aGUgcG9ydC4NCj4+Pj4gDQo+Pj4+IEZyb20gWGVu IFBvViwgaXQgaXMgc3RpbGwgbm90IGNsZWFyIHdoeSB0aGlzIGlzIGEgcHJvYmxlbSB0byBsZXQg TGludXggY2xvc2luZyBzdWNoIHBvcnQuIEZyb20gdGhlIGd1ZXN0IFBvViwgdGhlcmUgYXJlIG90 aGVyIHdheSB0byBwYXNzIHRoaXMgaW5mb3JtYXRpb24gKHNlZSBiZWxvdykuDQo+Pj4gDQo+Pj4g SWYgTGludXggY2xvc2VzIHRoZSBwb3J0LCB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwgY3JlYXRl ZCBieSBYZW4gYXNzb2NpYXRlZCB3aXRoIHN1Y2ggcG9ydCB3aWxsIG5vdCBiZSBhdmFpbGFibGUg dG8gdXNlIGFmdGVyd2FyZC4NCj4+PiANCj4+PiBXaGVuIEkgc3RhcnRlZCBpbXBsZW1lbnRlZCB0 aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwgc2VyaWVzLCBJIHRob3VnaHQgdGhlIHN0YXRpYyBldmVu dCBjaGFubmVsIGhhcyB0byBiZSBhdmFpbGFibGUgZm9yIHVzZSBkdXJpbmcNCj4+PiB0aGUgbGlm ZXRpbWUgb2YgdGhlIGd1ZXN0LiBUaGlzIHBhdGNoIGF2b2lkcyBjbG9zaW5nIHRoZSBwb3J0IGlm IHRoZSBMaW51eCB1c2VyLXNwYWNlIGFwcGxpY2F0aW9uIHdhbnRzIHRvIHVzZSB0aGUgZXZlbnQg Y2hhbm5lbCBhZ2Fpbi4NCj4+PiANCj4+PiBUaGlzIHBhdGNoIGlzIGZpeGluZyB0aGUgcHJvYmxl bSBmb3IgTGludXggT1MsIGFuZCBJIGFncmVlIHdpdGggeW91IHRoYXQgd2Ugc2hvdWxkIG5vdCBt b2RpZnkgdGhlIFhlbiB0byBmaXggdGhlIExpbnV4IHByb2JsZW0uDQo+Pj4gVGhlcmVmb3JlLCBJ ZiB0aGUgZ3Vlc3QgZGVjaWRlZCB0byBjbG9zZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwsIFhl biB3aWxsIGNsb3NlIHRoZSBwb3J0LiBFdmVudCBDaGFuZWwgYXNzb2NpYXRlZCB3aXRoIHRoZSBw b3J0DQo+Pj4gd2lsbCBub3QgYmUgYXZhaWxhYmxlIGZvciB1c2UgYWZ0ZXIgdGhhdC5JIHdpbGwg ZGlzY2FyZCB0aGlzIHBhdGNoIGluIHRoZSBuZXh0IHNlcmllcy4NCj4+PiANCj4+Pj4gDQo+Pj4+ PiBGcm9tIGd1ZXN0IE9TIHdlIGNhbiBjaGVjayBpZiB0aGUgZXZlbnQgY2hhbm5lbCBpcyBzdGF0 aWMgKHZpYSBFVlRDSE5PUF9zdGF0dXMoKSAgaHlwZXJjYWxsICksIGlmIHRoZSBldmVudCBjaGFu bmVsIGlzDQo+Pj4+PiBzdGF0aWMgZG9u4oCZdCB0cnkgdG8gY2xvc2UgdGhlIGV2ZW50IGNoYW5u ZWwuIElmIGd1ZXN0IE9TIHRyeSB0byBjbG9zZSB0aGUgc3RhdGljIGV2ZW50IGNoYW5uZWwgWGVu IHdpbGwgcmV0dXJuIGVycm9yIGFzIHN0YXRpYyBldmVudCBjaGFubmVsIGNhbuKAmXQgYmUgY2xv c2VkLg0KPj4+PiBXaHkgZG8geW91IG5lZWQgdGhpcz8gWW91IGFscmVhZHkgbmVlZCBhIGJpbmRp bmcgaW5kaWNhdGluZyB3aGljaCBwb3J0cyB3aWxsIGJlIHByZS1hbGxvY2F0ZWQuIFNvIHlvdSBj b3VsZCB1cGRhdGUgeW91ciBiaW5kaW5nIHRvIHBhc3MgYSBmbGFnIHRlbGxpbmcgTGludXggImRv bid0IGNsb3NlIGl0Ii4NCj4+Pj4gDQo+Pj4+IEkgaGF2ZSBhbHJlYWR5IHByb3Bvc2VkIHRoYXQg YmVmb3JlIGFuZCBJIGhhdmVuJ3Qgc2VlbiBhbnkgZXhwbGFuYXRpb24gd2h5IHRoaXMgaXMgbm90 IGEgdmlhYmxlIHNvbHV0aW9uLg0KPj4+IA0KPj4+IFNvcnJ5IEkgZGlkbuKAmXQgbWVudGlvbiB0 aGlzIGVhcmxpZXIsIEkgc3RhcnRlZCB3aXRoIHlvdXIgc3VnZ2VzdGlvbiB0byBmaXggdGhlIGlz c3VlIGJ1dCBhZnRlciBnb2luZyB0aHJvdWdoIHRoZSBMaW51eCBldnRjaG4gZHJpdmVyIGNvZGUN Cj4+PiBpdCBpcyBub3Qgc3RyYWlnaHQgZm9yd2FyZCB0byB0ZWxsIExpbnV4IGRvbuKAmXQgY2xv c2UgdGhlIHBvcnQuIExldCBtZSB0cnkgdG8gZXhwbGFpbi4NCj4+PiANCj4+PiBJbiBMaW51eCwg c3RydWN0IHVzZXJfZXZ0Y2huIHt9IGlzIHRoZSBzdHJ1Y3QgdGhhdCBob2xkIHRoZSBpbmZvcm1h dGlvbiBmb3IgZWFjaCB1c2VyIGV2dGNobiBvcGVuZWQuIFdlIGNhbiBhZGQgb25lIGJvb2wgcGFy YW1ldGVyIGluIHRoaXMgc3RydWN0IHRvIHRlbGwgTGludXggZHJpdmVyDQo+Pj4gdmlhIElPQ1RM IGlmIGV2dGNobiBpcyBzdGF0aWMuIFdoZW4gdXNlciBhcHBsaWNhdGlvbiBjbG9zZSB0aGUgZmQg Ii9kZXYveGVuL2V2dGNobuKAnSAsIGV2dGNobl9yZWxlYXNlKCkgd2lsbCB0cmF2ZXJzZSBhbGwg dGhlIGV2dGNobiBhbmQgY2FsbCBldnRjaG5fdW5iaW5kX2Zyb21fdXNlcigpDQo+Pj4gZm9yIGVh Y2ggZXZ0Y2huLiBldnRjaG5fdW5iaW5kX2Zyb21fdXNlcigpIHdpbGwgY2FsbCAgX191bmJpbmRf ZnJvbV9pcnEoaXJxKSB0aGF0IHdpbGwgY2FsbCB4ZW5fZXZ0Y2huX2Nsb3NlKCkgLiBXZSBuZWVk IHJlZmVyZW5jZXMgdG8gInN0cnVjdCB1c2VyX2V2dGNobuKAnSBpbg0KPj4+IGZ1bmN0aW9uIF9f dW5iaW5kX2Zyb21faXJxKCkgdG8gcGFzcyBhcyBhcmd1bWVudCB0byB4ZW5fZXZ0Y2huX2Nsb3Nl KCkgbm90IHRvIGNsb3NlIHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbC4gIEkgYW0gbm90IGFibGUg dG8gZmluZCBhbnkgd2F5IHRvIGdldA0KPj4+IHN0cnVjdCB1c2VyX2V2dGNobiBpbiBmdW5jdGlv biBfX3VuYmluZF9mcm9tX2lycSgpICwgd2l0aG91dCBtb2RpZnlpbmcgdGhlIG90aGVyIExpbnV4 IHN0cnVjdHVyZS4NCj4gDQo+IFRoZSAic3RhdGljIiBmbGFnIHNob3VsZCBiZSBhZGRlZCB0byBz dHJ1Y3QgaXJxX2luZm8uIEluIGNhc2UgYWxsIHJlbGV2YW50DQo+IGV2ZW50IGNoYW5uZWxzIGFy ZSByZWFsbHkgdXNlciBvbmVzLCB3ZSBjb3VsZCBlYXNpbHkgYWRkIGFub3RoZXIgInN0YXRpYyIN Cj4gZmxhZyB0byBldnRjaG5fbWFrZV9yZWZjb3VudGVkKCksIHdoaWNoIGlzIGFscmVhZHkgdXNl ZCB0byBzZXQgYSB1c2VyDQo+IGV2ZW50IGNoYW5uZWwgc3BlY2lmaWMgdmFsdWUgaW50byBzdHJ1 Y3QgaXJxX2luZm8gd2hlbiBiaW5kaW5nIHRoZSBldmVudA0KPiBjaGFubmVsLg0KPiANCg0KQXMg c3VnZ2VzdGVkIGJ5IHlvdSwgSSBtb2RpZmllZCB0aGUgTGludXggS2VybmVsIGJ5IGFkZGluZyDi gJxzdGF0aWMiIGZsYWcgaW4gc3RydWN0IGlycV9pbmZvIGFuZA0KaXQgd29ya3MgZmluZS4gV2Ug Y2FuIHNraXAgdGhlIGNsb3Npbmcgb2Ygc3RhdGljIGNoYW5uZWwgaWYgcmVxdWlyZWQuIA0KDQpJ IHdpbGwgc2VuZCB0aGUgcGF0Y2ggZm9yIHJldmlldyBvbmNlIEkgd2lsbCBzZW5kIHRoZSBwYXRj aCBmb3IgbmV3IGlvY3RsIGZvciBzdGF0aWMgZXZlbnQgY2hhbm5lbC4NCg0KUmVnYXJkcywNClJh aHVsDQoNCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 07 13:40:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 13:40:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.362992.593301 (Exim 4.92) (envelope-from ) id 1o9RkA-0003a9-ER; Thu, 07 Jul 2022 13:40:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 362992.593301; Thu, 07 Jul 2022 13:40:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9RkA-0003a1-Al; Thu, 07 Jul 2022 13:40:34 +0000 Received: by outflank-mailman (input) for mailman id 362992; Thu, 07 Jul 2022 13:40:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Rk8-0003Zq-GR; Thu, 07 Jul 2022 13:40:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Rk8-0006wH-Dw; Thu, 07 Jul 2022 13:40:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Rk7-0008IS-V5; Thu, 07 Jul 2022 13:40:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9Rk7-0005Sm-Ue; Thu, 07 Jul 2022 13:40:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZMFTMh5cilv8LW/rnnU23lgxw7phGxVRMyeej4pF73k=; b=KXPeWtu/FwHnAuSXSDfEdakQL3 sM/ig7ZG+T9uRM7vO1m+mARja0RY3vdwG54r6pkhsbPeHdxUuJgeQpj6LBLdeWbs6wYqKQ4HaOEhG PBm+nMkwTMUT0dTz1mV/0ClOGUAvgjP5HEDxErHCvxdvBFgatScLZ91P40e9KBqiM2n0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171546: all pass - PUSHED X-Osstest-Versions-This: ovmf=5496c763aaddc4a47639d4652abe23aa3419263a X-Osstest-Versions-That: ovmf=f193b945eac58ca379d3d21c77d5550b063580d6 From: osstest service owner Date: Thu, 07 Jul 2022 13:40:31 +0000 flight 171546 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171546/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5496c763aaddc4a47639d4652abe23aa3419263a baseline version: ovmf f193b945eac58ca379d3d21c77d5550b063580d6 Last test of basis 171540 2022-07-07 01:10:28 Z 0 days Testing same since 171546 2022-07-07 10:42:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ming Huang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f193b945ea..5496c763aa 5496c763aaddc4a47639d4652abe23aa3419263a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 07 14:46:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 14:46:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363009.593311 (Exim 4.92) (envelope-from ) id 1o9SlY-00048x-D9; Thu, 07 Jul 2022 14:46:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363009.593311; Thu, 07 Jul 2022 14:46:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9SlY-00048q-9p; Thu, 07 Jul 2022 14:46:04 +0000 Received: by outflank-mailman (input) for mailman id 363009; Thu, 07 Jul 2022 14:46:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9SlW-00048k-Ie for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 14:46:02 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8286445c-fe03-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 16:45:59 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8286445c-fe03-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657205159; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=GHa4za0cnyCaXsE/HB2cx8kWg7YDvwgRAJqgMqmSCy4=; b=eZa9sSfm8pbSkpG3GL68OtgPGLJ3M68doaupFj6L+VYy0Oq5zLymuWMu 3OJI+6+LBMknJlvZsx/HQez5uJrzm8WdV3BL8SfeOo6Et1cGD2YBO0iHJ do+BU7SeYqEYPPEhAYyswfMhbAIT75ZqwJw6qg/sivcrcZjiqg30McLm4 k=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75113405 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:hV8MwKJi4BMw2bZtFE+RhpUlxSXFcZb7ZxGr2PjKsXjdYENS1GEOz 2QdXz+Bbq2OMzHxeNxzYI218kIAsMKDmt5jTQdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dY32YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 I1WkaCXSFotB4nFgsccCQNbA2ZhIqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQquHP pFFMWcHgBLoJAZEIVQNA5QHrsj5h3jaUDAIkQiQjP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4cEhoNTnOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4UgA0A8F0L8o7tQW07qPOwAfDHGsUCSFeZ4lz3CMpfgDGx mNljvuwW2Ew6eXNGS/HnluHhWjsYHZIdAfucQdBFFJYuIe7/enfmzqVFr5e/LiJYsoZ8N0a6 xSDt2AAiroalqbnPI3rrAmc01pASnUkJzPZBzk7vUr/t2uVnKb/O+SVBaHztJ6s1rqxQFibp 2QjkMOD9u0IBpzlvHXTHbpUR+v3vqjZame0bbtT834Jrm3FxpJeVdoIvGEWyLlBaK7ohgMFk GeM4FgMtfe/zVOhbLNtYpLZNvnGOZPITIy/PtiNN4ImSsEoKGevoXA1DWbNjj+FraTZufxmU XttWZ30XShy5GUO5GfeetrxJpdynX1imzyPGcGTItbO+eP2WUN5gIwtaDOmBt3VJoveyOkJ2 76z7/e39ig= IronPort-HdrOrdr: A9a23:0rZIAa2EO2d1ImTDILYtVAqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF X-IronPort-AV: E=Sophos;i="5.92,253,1650945600"; d="scan'208";a="75113405" Date: Thu, 7 Jul 2022 15:45:36 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom Message-ID: References: <20220624092806.27700-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220624092806.27700-1-jgross@suse.com> On Fri, Jun 24, 2022 at 11:28:06AM +0200, Juergen Gross wrote: > In case of maxmem != memsize the E820 map of the PVH stubdom is wrong, > as it is missing the RAM above memsize. > > Additionally the MMIO area should only cover the HVM special pages. > > Signed-off-by: Juergen Gross > --- > tools/helpers/init-xenstore-domain.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c > index b4f3c65a8a..dad8e43c42 100644 > --- a/tools/helpers/init-xenstore-domain.c > +++ b/tools/helpers/init-xenstore-domain.c > @@ -157,21 +158,24 @@ static int build(xc_interface *xch) > config.flags |= XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap; > config.arch.emulation_flags = XEN_X86_EMU_LAPIC; > dom->target_pages = mem_size >> XC_PAGE_SHIFT; > - dom->mmio_size = GB(4) - LAPIC_BASE_ADDRESS; > + dom->mmio_size = X86_HVM_NR_SPECIAL_PAGES << XC_PAGE_SHIFT; > dom->lowmem_end = (mem_size > LAPIC_BASE_ADDRESS) ? > LAPIC_BASE_ADDRESS : mem_size; > dom->highmem_end = (mem_size > LAPIC_BASE_ADDRESS) ? > GB(4) + mem_size - LAPIC_BASE_ADDRESS : 0; > - dom->mmio_start = LAPIC_BASE_ADDRESS; > + dom->mmio_start = (X86_HVM_END_SPECIAL_REGION - > + X86_HVM_NR_SPECIAL_PAGES) << XC_PAGE_SHIFT; > dom->max_vcpus = 1; > e820[0].addr = 0; > - e820[0].size = dom->lowmem_end; > + e820[0].size = (max_size > LAPIC_BASE_ADDRESS) ? > + LAPIC_BASE_ADDRESS : max_size; > e820[0].type = E820_RAM; > - e820[1].addr = LAPIC_BASE_ADDRESS; > + e820[1].addr = dom->mmio_start; So, it isn't expected to have an entry covering the LAPIC addresses, right? I guess not as seen in df1ca1dfe20. But based on that same commit info, shouldn't the LAPIC address part of `dom->mmio_start, dom->mmio_size`? (I don't know how dom->mmio_start is used, yet, but maybe it's used by Xen or xen libraries to avoid allocations in the wrong places) Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:01:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:01:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363016.593323 (Exim 4.92) (envelope-from ) id 1o9T0g-0007U2-OV; Thu, 07 Jul 2022 15:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363016.593323; Thu, 07 Jul 2022 15:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T0g-0007Tv-Ky; Thu, 07 Jul 2022 15:01:42 +0000 Received: by outflank-mailman (input) for mailman id 363016; Thu, 07 Jul 2022 15:01:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T0f-0007Tp-A7 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 15:01:41 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4603b8b-fe05-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 17:01:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 416181FF4D; Thu, 7 Jul 2022 15:01:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 22EE713461; Thu, 7 Jul 2022 15:01:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id U/pyBlP1xmKgQAAAMHmgww (envelope-from ); Thu, 07 Jul 2022 15:01:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4603b8b-fe05-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657206099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sQfCKnsTd55wuOD6eFoikdzBukcpkLFNWRTUM4LtyuA=; b=I5DjIg5ln8I4Uno3AYaWUcYw9k2wbw2vzKicYuXgiW233nspN2b+ipk8022J7js/zNNXc+ IYyYma1LfAKr232/O6A+ibvolff4RUmeZKVBeygcWxtG51ZLpnBxNp8BxdLaBpznfD6KJ/ H60JbmdAcW0/Y8+xADk0VppuFnWq07A= Message-ID: <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> Date: Thu, 7 Jul 2022 17:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20220624092806.27700-1-jgross@suse.com> From: Juergen Gross Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------RcadQtd4U5XxXMiWjtI6zlJE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------RcadQtd4U5XxXMiWjtI6zlJE Content-Type: multipart/mixed; boundary="------------i9C7O0haINp8eyBlr3U7e8f0"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom References: <20220624092806.27700-1-jgross@suse.com> In-Reply-To: --------------i9C7O0haINp8eyBlr3U7e8f0 Content-Type: multipart/mixed; boundary="------------GqmSHwuyo0ehe0tg8NlRVJrB" --------------GqmSHwuyo0ehe0tg8NlRVJrB Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDcuMDcuMjIgMTY6NDUsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBGcmksIEp1 biAyNCwgMjAyMiBhdCAxMToyODowNkFNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4gSW4gY2FzZSBvZiBtYXhtZW0gIT0gbWVtc2l6ZSB0aGUgRTgyMCBtYXAgb2YgdGhlIFBW SCBzdHViZG9tIGlzIHdyb25nLA0KPj4gYXMgaXQgaXMgbWlzc2luZyB0aGUgUkFNIGFib3Zl IG1lbXNpemUuDQo+Pg0KPj4gQWRkaXRpb25hbGx5IHRoZSBNTUlPIGFyZWEgc2hvdWxkIG9u bHkgY292ZXIgdGhlIEhWTSBzcGVjaWFsIHBhZ2VzLg0KPj4NCj4+IFNpZ25lZC1vZmYtYnk6 IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4+IC0tLQ0KPj4gICB0b29scy9o ZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMgfCAxNiArKysrKysrKysrLS0tLS0tDQo+ PiAgIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQ0K Pj4NCj4+IGRpZmYgLS1naXQgYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWlu LmMgYi90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMNCj4+IGluZGV4IGI0 ZjNjNjVhOGEuLmRhZDhlNDNjNDIgMTAwNjQ0DQo+PiAtLS0gYS90b29scy9oZWxwZXJzL2lu aXQteGVuc3RvcmUtZG9tYWluLmMNCj4+ICsrKyBiL3Rvb2xzL2hlbHBlcnMvaW5pdC14ZW5z dG9yZS1kb21haW4uYw0KPj4gQEAgLTE1NywyMSArMTU4LDI0IEBAIHN0YXRpYyBpbnQgYnVp bGQoeGNfaW50ZXJmYWNlICp4Y2gpDQo+PiAgICAgICAgICAgY29uZmlnLmZsYWdzIHw9IFhF Tl9ET01DVExfQ0RGX2h2bSB8IFhFTl9ET01DVExfQ0RGX2hhcDsNCj4+ICAgICAgICAgICBj b25maWcuYXJjaC5lbXVsYXRpb25fZmxhZ3MgPSBYRU5fWDg2X0VNVV9MQVBJQzsNCj4+ICAg ICAgICAgICBkb20tPnRhcmdldF9wYWdlcyA9IG1lbV9zaXplID4+IFhDX1BBR0VfU0hJRlQ7 DQo+PiAtICAgICAgICBkb20tPm1taW9fc2l6ZSA9IEdCKDQpIC0gTEFQSUNfQkFTRV9BRERS RVNTOw0KPj4gKyAgICAgICAgZG9tLT5tbWlvX3NpemUgPSBYODZfSFZNX05SX1NQRUNJQUxf UEFHRVMgPDwgWENfUEFHRV9TSElGVDsNCj4+ICAgICAgICAgICBkb20tPmxvd21lbV9lbmQg PSAobWVtX3NpemUgPiBMQVBJQ19CQVNFX0FERFJFU1MpID8NCj4+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBMQVBJQ19CQVNFX0FERFJFU1MgOiBtZW1fc2l6ZTsNCj4+ICAgICAg ICAgICBkb20tPmhpZ2htZW1fZW5kID0gKG1lbV9zaXplID4gTEFQSUNfQkFTRV9BRERSRVNT KSA/DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdCKDQpICsgbWVtX3NpemUg LSBMQVBJQ19CQVNFX0FERFJFU1MgOiAwOw0KPj4gLSAgICAgICAgZG9tLT5tbWlvX3N0YXJ0 ID0gTEFQSUNfQkFTRV9BRERSRVNTOw0KPj4gKyAgICAgICAgZG9tLT5tbWlvX3N0YXJ0ID0g KFg4Nl9IVk1fRU5EX1NQRUNJQUxfUkVHSU9OIC0NCj4+ICsgICAgICAgICAgICAgICAgICAg ICAgICAgICBYODZfSFZNX05SX1NQRUNJQUxfUEFHRVMpIDw8IFhDX1BBR0VfU0hJRlQ7DQo+ PiAgICAgICAgICAgZG9tLT5tYXhfdmNwdXMgPSAxOw0KPj4gICAgICAgICAgIGU4MjBbMF0u YWRkciA9IDA7DQo+PiAtICAgICAgICBlODIwWzBdLnNpemUgPSBkb20tPmxvd21lbV9lbmQ7 DQo+PiArICAgICAgICBlODIwWzBdLnNpemUgPSAobWF4X3NpemUgPiBMQVBJQ19CQVNFX0FE RFJFU1MpID8NCj4+ICsgICAgICAgICAgICAgICAgICAgICAgIExBUElDX0JBU0VfQUREUkVT UyA6IG1heF9zaXplOw0KPj4gICAgICAgICAgIGU4MjBbMF0udHlwZSA9IEU4MjBfUkFNOw0K Pj4gLSAgICAgICAgZTgyMFsxXS5hZGRyID0gTEFQSUNfQkFTRV9BRERSRVNTOw0KPj4gKyAg ICAgICAgZTgyMFsxXS5hZGRyID0gZG9tLT5tbWlvX3N0YXJ0Ow0KPiANCj4gDQo+IFNvLCBp dCBpc24ndCBleHBlY3RlZCB0byBoYXZlIGFuIGVudHJ5IGNvdmVyaW5nIHRoZSBMQVBJQyBh ZGRyZXNzZXMsDQo+IHJpZ2h0PyBJIGd1ZXNzIG5vdCBhcyBzZWVuIGluIGRmMWNhMWRmZTIw Lg0KPiANCj4gQnV0IGJhc2VkIG9uIHRoYXQgc2FtZSBjb21taXQgaW5mbywgc2hvdWxkbid0 IHRoZSBMQVBJQyBhZGRyZXNzIHBhcnQgb2YNCj4gYGRvbS0+bW1pb19zdGFydCwgZG9tLT5t bWlvX3NpemVgPyAoSSBkb24ndCBrbm93IGhvdyBkb20tPm1taW9fc3RhcnQgaXMNCj4gdXNl ZCwgeWV0LCBidXQgbWF5YmUgaXQncyB1c2VkIGJ5IFhlbiBvciB4ZW4gbGlicmFyaWVzIHRv IGF2b2lkDQo+IGFsbG9jYXRpb25zIGluIHRoZSB3cm9uZyBwbGFjZXMpDQoNCkluIG15IHVu ZGVyc3RhbmRpbmcgdGhpcyBpcyB0aGUgcHVycG9zZSBvZiBsb3dtZW1fZW5kLg0KDQpPVE9I IEkgY2FuIG1vZGlmeSB0aGUgcGF0Y2ggdG8gYmUgYWxvbmcgdGhlIGxpbmVzIG9mIGRmMWNh MWRmZTIwLg0KDQoNCkp1ZXJnZW4NCg== --------------GqmSHwuyo0ehe0tg8NlRVJrB Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------GqmSHwuyo0ehe0tg8NlRVJrB-- --------------i9C7O0haINp8eyBlr3U7e8f0-- --------------RcadQtd4U5XxXMiWjtI6zlJE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLG9VIFAwAAAAAACgkQsN6d1ii/Ey+P CQf9GD4PaLhyCe9yoBl0cvI57rg+m55ntFb9xwolybAIJlsgE9oiQJCv0dHxEOOYJ8SirQC81uXi AdDiLWDUOwHTAD41bjO7nHvLBvqQvBbpQz541c2CjH64IWur2aJV8qBxuH1mVy+9+zlJPROkUk4V 2rNCvPfMTck76Yg9wsEuTtGF72Cw4OfhLdtbqjjr7vMPGx+L9M9WvcTZ28IialJwiLeeQC3o5AGg iBcx9TtoguBpiEO7tqPSVRnJtP64oXXoPsvY53YOovtLlW9a+vX9SMWODEh+iFFgU5/Kxb7vdhd/ fblkw9Tzy+JldsFEacHoLxPsvg1IcU6Vb+e7th9vTw== =bhrm -----END PGP SIGNATURE----- --------------RcadQtd4U5XxXMiWjtI6zlJE-- From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:04:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:04:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363022.593333 (Exim 4.92) (envelope-from ) id 1o9T3H-00086Z-8L; Thu, 07 Jul 2022 15:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363022.593333; Thu, 07 Jul 2022 15:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T3H-00086S-5G; Thu, 07 Jul 2022 15:04:23 +0000 Received: by outflank-mailman (input) for mailman id 363022; Thu, 07 Jul 2022 15:04:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T3F-00086M-Tb for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 15:04:22 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1264744a-fe06-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 17:04:20 +0200 (CEST) Received: from mail-dm3nam02lp2046.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Jul 2022 11:04:11 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BN9PR03MB5996.namprd03.prod.outlook.com (2603:10b6:408:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 15:04:10 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 15:04:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1264744a-fe06-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657206260; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=Jmb0kh5NjF+pGvoFIlAhHsXAw8ZYM5cPqKW/FimTJWQ=; b=OB7XP9XY7jgFLNnjlPRQS1lxOcinQjNM8TVQgrNverfAM6prKfv6lBCW MrptBGF3kLP987S7hUGWY+dE+siidaJmxJL5rL+EjIFMvmjphq5Yy8sZ5 MkvizV+JXFLVBMLQxEoahqN3E5jR5EQy0kot6osCXUroS9o6V5jmibfRI E=; X-IronPort-RemoteIP: 104.47.56.46 X-IronPort-MID: 75115363 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:DWyXiqjLjT1OjTZBFOJB8kouX161ZxAKZh0ujC45NGQN5FlGYwSy9 lOraxnFY6jUMyawOYxoOc7lxf41ycLVyd9lQANtqCs3E3sQ95PJD9rAJE2uNC/MIJacRU9u5 p1BM9DKdZ4/FiCN+EihOOjr8iF22azWGbD1A+WYZHwZqWOIMMsEoUsLd7kR3t446TTAPz6wh D/SnyH+EAKv0G4rbT8eu/7S9Boxsaz752tH4wQ1PK9F5gGHzyVIXc4Tfa2/ESD1E9JedgKYq 0cv710bEkfxpUpF5gaNy+6jGqEyaueOe1DI0BK6YoD66vR4jnVaPp0TabxNMy+7tx3Tx4ork IoV6sTqIesUFvakdNo1AkEw/x5WZcWqyJefSZRomZXOp6FuWyKEL8RGVCnaD6VBkgpEKTgmG cgjACIMdni+a9eem9pXfAXOavMLd6EHNKtH0p1pIKqw4fwOGfgvSI2SjTNUMatZammj0p8ya uJAAQeDYigsbDVJCAYcMcwfnt6jrTrlVQZVqFaSuaoetj27IAxZiNABMfLzU/nSH4B5ux3do WjLuWPkHhsdKdqTjyKf9W6hjfPOmiW9X58OELq/9bhhh1j7Km47UUVKEwfk56TnzBLgMz5cA xV8Fi4GgqU17kOmCPXgWRmxuFaPvwIGWsoWGOo/gO2I4vWJul/EXTZfJtJHQNcdlZAEQxst7 A6inuvKL2Ztl7LEQG3Io994qhv3Y0D5N1QqdSICCAcI/dTniIUylQ7UCMZuFravid/4Ei22x CqFxAAhg50DgMhN0L+0lXjFjCirvYPhVRMu60PcWWfNxgFzaZOhZoeowUPG9vsGJ4GcJnGDo XwFls62/O0IS5aXm0SlW/4RFbuk4/KENjz0glN1GZQlsTO39BaLQ4dU5z1vIVZzBewNczTpf Uz7tBtY4dlYO37CRaV6eZ6rAsImi63pD834V+v8Z8BLJJN2cWev/jxoI0iZ3GnvkU0luaA5J ZqfN82rCB4yCql5zTzwW+YU15cqwDwzwSXYQpWT8vi8+b+XZXrQRbJeNlKLNro99Pnc/FuT9 MtDPcyXzRkZSPf5fiTc7Y8UKxYNMGQ/Apf17cdQc4ZvPzZbJY3oMNeJqZtJRmCvt/4P/gsU1 hlRgnNl9Wc= IronPort-HdrOrdr: A9a23:nWbIf65hs6NfY65+PwPXwWSBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qADnhORICOgqTPqftWzd1FdAQ7sSircKrweAJ8S6zJ8k6U 4CSdkzNDSTNykdsS+S2mDRfLgdKZu8gdmVbIzlvhVQpHRRGsVdBnBCe2Om+yNNJDVuNN4cLt 6x98BHrz2vdTA8dcKgHEQIWODFupniiI/mSQRuPW9o1CC+yReTrJLqGRmR2RkTFxlVx605zG TDmwvloo2+rvCAzAPG3WO71eUWpDKh8KoCOCW/sLlWFtzesHfsWG2nYczHgNkBmpDt1L/tqq iKn/5vBbU015qbRBDJnfKk4Xid7N9p0Q6s9bbQuwqcneXpAD09EMZPnoRfb1/Q7Fchpsh11O ZR03uerIc/N2KJoM1T3am7a/n7/nDE3kbKvNRj+UC3a7FuIYN5vMga5gdYAZ0AFCX15MQuF/ RvFtjV4LJTfUmBZ37Us2FzyJj0N05DVCuuUwwHoIiYwjJWlHd2ww8Rw9EehG4J8NY4R4Nf7+ rJP6x0nPVFT9MQb6h6GOAdKPHHQVDlUFbJKiafMF7nHKYINzbErIP2+qw84KWwdJkB3PIJ6e P8uZNjxBoPkm7VeL2zNcdwg2HwqU2GLEfQ49Ab4YRlsbvhQ7euOTGfSTkV4r6dn8k= X-IronPort-AV: E=Sophos;i="5.92,253,1650945600"; d="asc'?scan'208,217";a="75115363" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LxuHEakBIrZPHwB06uHBG0RsNEMogCaIODJ5b+RVKJBx5yXCOJEhBKUhuu1uvl0XlQiVA9dbX2jnGTXBmu+IhAZQQd2xOduMJZPrQKBvPcPx0QyR7yPF5iuywIqC3mWiFHpXGzC70v+O1MahKvIgAZdXUJm/3v+l0zB5405hqTauG9FythUyYaHXTlG8I+YmXSFYCLpgYN8D/SxxfBAB2LqBXJIWIN1Vp+Nj5bJgM+7P5+69QBnmVKYmjRkBF4i6NqHLCyqVkEElF0VpKMO+LUx5Z+LLFRELJqB2OdOwZVPUND8vdEDF3Artne2pimIXhWyxqZNJTcjQ2TSS4qrnrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AJwQoERK+bfaDkMb10H+k1Khi6cTZR3AJZfP05UEqEE=; b=oGIkJhF5jIEHePR66RPWn/SyzDSSZmwTrHQ4R9RgPv6JuFt4r6bae9IjrvHXfG+VY17jsCkCC0RYxrg0xJ9EG+wfxsavuXZmvfqhtAQZ0TLeq8JOKeg0vcaVZmrJqIIi4304klroJnb/0HvyIJxIvKQ+y6gRs5kNubXTqMFkijEnmelTOuvDBl6h8LuFmqPsj55eH9p+rv1218DXnwFT1bHBBKnYApTIsXEOva6S7KE9fF7YxRYtRlhkdAXnEEbLQUYp21G7/TXN2udhjb7vewfZ4uwi1gvpnxPMPvWEL27qhY8Lfii/f5ql6kLNOpBIK9CYZfmGBlq8pTs5a3gjVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AJwQoERK+bfaDkMb10H+k1Khi6cTZR3AJZfP05UEqEE=; b=UZdunpZf0niIWmTqd+Z+GLsi5jYULsP4orSLirFGTvBOI1feNTjeRPAjzIOjmrlDSwxq1OqYW2LUj12hlHz4I2eKqdtG7GOQJXobxJIFSEQVBrjAI6+U8KkmWBCd15msuevt5nxJWiR5/u0MoGFaYfZP2as42l/MKLefNIYQjjY= From: George Dunlap To: Jane Malalane CC: Xen-devel , Wei Liu , Anthony Perard , Juergen Gross , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , Jun Nakajima , Kevin Tian , Roger Pau Monne Subject: Re: [PATCH v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Topic: [PATCH v10 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Index: AQHYTyjM9+S75qV8UU+hKsd4jxf1861zh0sA Date: Thu, 7 Jul 2022 15:04:09 +0000 Message-ID: References: <20220413112111.30675-1-jane.malalane@citrix.com> <20220413112111.30675-2-jane.malalane@citrix.com> In-Reply-To: <20220413112111.30675-2-jane.malalane@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6032c4fa-d1c0-403b-e7be-08da6029f226 x-ms-traffictypediagnostic: BN9PR03MB5996:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LYMk9PP76BvS4sa9lbCAIEmXKF87PF7t8yxoNSa1LRiiJwpAyE969c3PuQ6fyfA2fRRarR1WRIAsoXzCaXbte5HE9qOu4Oizp3JanXuvNdOTC37qiJI/Bn2H4MjBpCQthdNMimQVCyobg1D8tEyfASn38zkMmvLaaEW2su8w1p53EOdg/4Fw4pF1ZIfnPVCgdUkNpex/JZAK4jl+cN6SKcVaDG1GwZ/zYQzeu8bN2VesA56mKTP/E0CX8O2g2XinjBDPv84Qquzv90hhBDB/ZMc8ilbKuEg+Ks+VY2V1n3qVKwa4D0H5GfhjpLZzRYGHKfoGa8STKY8B444XEDHrjE0qOWimcTzJUCnr9oAVQTW+1cz0pfQuv3U7X7fVSQm8jGiawgcc+GU+bLPzIL9byFoqWBqK8mWKO8kDE3ZI5y5MDIJgH7v2yfWOzoW1+gwQjarsEDb6YJbv6DlDb1POEZRrjFVEameGdFUUlRw8roxpf7XrC21qpniZm++VQUR6ZziqyGj19N/abguZxt1KJvzgTsEM1wjf0u2vUApCH9MzcYlzABCNSrTJ6N9tSo2Pux2r/D0lzk6UDyxEapRBuWAG6ZI5r4CQNJA44eRExxX9MvKqTAVwp0PZp4f665jMrfCfuAzAGN4EJIhjtQQOSyqFKLzOCqNLBjKs/FhdyxlO4dlBBnkZzTcly6LINmzv8aBmg1ob9mWDHXdyVWg9VxTQkI7GSgWd5DWOMvP61b6OS2eiXkQjd0svQqZghsvnEHoRCsYXYeCzjucE6AdLvh1DIGYswlPURedYj2Htcku8DQ6IFJD4mce11hJzJBMhww0UhUaiLR12A4hiq/fE/eIkF292QMMFkhDTzzhvvQw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(107886003)(186003)(2616005)(38070700005)(316002)(36756003)(91956017)(71200400001)(76116006)(8676002)(4326008)(83380400001)(38100700002)(6636002)(37006003)(54906003)(64756008)(66946007)(66556008)(66476007)(66446008)(478600001)(6862004)(86362001)(53546011)(8936002)(6506007)(5660300002)(6512007)(33656002)(6486002)(7416002)(122000001)(82960400001)(26005)(2906002)(99936003)(41300700001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NnM4MnRkWk5hSzhMejNMY2o1L1h0U08rbERObk52SGhzdXBKZXI2STdCM2N1?= =?utf-8?B?THcyUHgyT3VSWmJTWUM2U0R3WVlJREZ5RVMwa1FlekNFcEhXUWdRZitON3FR?= =?utf-8?B?aHNsN3hEbnBkS3BCR1NlckNwM2VnaWpIZ001QU40TlVQd2NRblcwZm5HTVlV?= =?utf-8?B?K1o3ZFpvWEdOeGZUWm5ZR0Y2dWZUTVJ2cE1kQXZmQ0dnZ3NJZjI3KzJCMlVL?= =?utf-8?B?Y2xZU0k3ZVZpalRYSHg3WmJBSmtONDN0OWtyTlppdTUyUDNyc1VoWmJTT0JK?= =?utf-8?B?M1Z1TWZ5cnYvYTU5SlpTNFJGZVJrMEdTZ0ZUeEtqRDI0K1F1ck83Vy90YnBL?= =?utf-8?B?NllZY0JzbC9jY2ZYSThxOGhvOE1nVzg5dStzTDc4Zkp0dFVUcVFBNmEzM0Vi?= =?utf-8?B?NUlZMFBrdkpQS2VZclQ5WldkS3ZYektUVHZ6MExiTkN1TU1YNzUwMUwxVGNw?= =?utf-8?B?djhqbmxJS1hGU0M2QzVvekppL2ZRUERWUDQ4N1Y3TVlhN3pGRjcya210ekEw?= =?utf-8?B?Q3FmUVV6SEpFQ0RNT1l0WnJOak9IcmpIUGdaaDRXMWFRZ0FDRHRhRXRLUnMv?= =?utf-8?B?UkU1dmhudG5ydWlsbUZYNGc5SGlGTkJodkxFa0lHSU5lRC9lenJ2OFVzbmx3?= =?utf-8?B?YlpqZ3AwTThPWGY3cWRDRTN5aWFxQmFQalhpZEp5NXJGWnlkUXQ2TnRzZmRq?= =?utf-8?B?SVhLUkZybCt2L1lRdGJ4UlJFalc0NHZFTHg3M0FreUxXU1JtelI3cEpIM2JU?= =?utf-8?B?eHc3R0tZWFk1TEhPVFJ1N3ZMaGxHRlpBQ2ZUUXFnRlo4YnUzd1VtWTluUG9B?= =?utf-8?B?YS9HL2NrbjBJN0hjSWNtWWZZcWhockY2dWJWbHVoSUdpeW9tb3RFK0QvMTJS?= =?utf-8?B?alFPZ2VaallZNXRpNjlPYkZ5dGRjSFVpaWF4b29SUTZzNDBuZWdWdVdBNjR1?= =?utf-8?B?NHdmTlhFVnpwN1BoRVZpMERueHRyRVV6MlZyUGNtMjdoKzNJNHY3OFBHb0pk?= =?utf-8?B?dVZvTCtqUjRlek16eTRic1VFZEVLMkN2RklFZUx4Q0JPTUNUdmJYRUp0empo?= =?utf-8?B?YUp1eHM4ODdmdUFwTGlPamU2TFNFSjRYWXk4R3ZjTUE5U2dzY3dQQTFhaGUx?= =?utf-8?B?L0RtOElJT2RxZ1c5aFZndDV2SDlqRmlZWU1xaXR0UkNSb1IzTWZ0TGdBakxr?= =?utf-8?B?R2NrVlZ6ZHRTZGI3SWtzb0MvQitOWEkyTGlYSVpDTVNvU2VyMXlQMThnV2Vr?= =?utf-8?B?YWhXbGUxYjYxNkVuVlVmYWF0M2VtaXlwNXlvcjdCanpSbTZnRWFNQUFOR2Iy?= =?utf-8?B?R21uMWNZeFZ4OWNqS0g5eVQ3WXlqeFE5K0N6UGdhRk9XdnR3NDU1Wm5rZlpK?= =?utf-8?B?R21wZ0dHYSt2YVNxVjltZkd4TVlhaVZNVkVUdENzM2U3VC9OMnpLdlJPRmtM?= =?utf-8?B?cko1MEpKZTR6SGxjdGpHOEhjTWNVT0Q1QnFMT0tTbHRtZTZMcmpWc3MvZ2tH?= =?utf-8?B?RmxabEhoOVM2YVVOVXpmN1BFV2QwTDJPOXlxMytXNno0N0hLMDVNQzlxL2x4?= =?utf-8?B?QnYyRkQ4Z1JwQzJoeWdQVjlxS3lES1VaQUc0bDV0VkpPZUJONy8zZ0xRY2l5?= =?utf-8?B?dzFGOTFwTk16a3VQSE4rV0ZzcmYvZ3RtRVF1S3RmWUZaMWZwdUxPS29yNFRm?= =?utf-8?B?TFR6eWpRWG9oUjRTRndWQ3ZLdVN3RVdBbWlPNTQ4bjNDMVp4Rm80TFp2ay8z?= =?utf-8?B?QXV3T0p3S3VDam0ydjVQcGRvbkZ5MEJ1RXRSSDY4TzVmcjdRMmFGVDZXMlZa?= =?utf-8?B?K3R5TWVGS29ibGVYeVlNaGRTbWVFeWh0NVZCZ3pVVlo1TTF4UUd3V0pLaHhX?= =?utf-8?B?bzczQ1dPcTJpMDRVMHR6czJ4SktFNk9ERmVqUXVQempqQ1hmMDJ2ZEVpYVMz?= =?utf-8?B?QklxVmpGeEduajJKR25rY1JBQ0NQV3pNTlZyTFlIZWlFZmlnS0JvNTlEbk4r?= =?utf-8?B?R3BwYjBKeHkyU01majQ3MzkvZWI2b1RUY0t5YjNMYjYyTi8yeGltaXllbXQz?= =?utf-8?B?RjdkQXR6UXh5SnFaSCs3dG9XMjJRWHc1dEVjSTRsa1J6T3o1M2gxQitZUXdw?= =?utf-8?B?VXVuRldPOTcrajVzN2VTa0trNDZLUDFGa3V5QURpNmRXZVQ0MjE1VXE0SCs4?= =?utf-8?B?OWc9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_C5CA3C6F-4080-4848-812C-4FE2935DB469"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6032c4fa-d1c0-403b-e7be-08da6029f226 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 15:04:09.8751 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nnL6ykz539zmOf3MQLbFuvgl/o854NEWszTgQkxBtL7BoG7FqjFHNol8OkNZec8uipygSzUKY9deTUfo/fAUtRyjsOVj9k6Y0FB9dWv+Mac= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5996 --Apple-Mail=_C5CA3C6F-4080-4848-812C-4FE2935DB469 Content-Type: multipart/alternative; boundary="Apple-Mail=_EE3D3734-4774-47EE-B9B8-C6F68DD4840E" --Apple-Mail=_EE3D3734-4774-47EE-B9B8-C6F68DD4840E Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 13 Apr 2022, at 12:21, Jane Malalane = wrote: >=20 > Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and > XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and > x2APIC, on x86 hardware. This is so that xAPIC and x2APIC = virtualization > can subsequently be enabled on a per-domain basis. > No such features are currently implemented on AMD hardware. >=20 > HW assisted xAPIC virtualization will be reported if HW, at the > minimum, supports virtualize_apic_accesses as this feature alone means > that an access to the APIC page will cause an APIC-access VM exit. An > APIC-access VM exit provides a VMM with information about the access > causing the VM exit, unlike a regular EPT fault, thus simplifying some > internal handling. >=20 > HW assisted x2APIC virtualization will be reported if HW supports > virtualize_x2apic_mode and, at least, either apic_reg_virt or > virtual_intr_delivery. This also means that > sysctl follows the conditionals in vmx_vlapic_msr_changed(). >=20 > For that purpose, also add an arch-specific "capabilities" parameter > to struct xen_sysctl_physinfo. >=20 > Note that this interface is intended to be compatible with AMD so that > AVIC support can be introduced in a future patch. Unlike Intel that > has multiple controls for APIC Virtualization, AMD has one global > 'AVIC Enable' control bit, so fine-graining of APIC virtualization > control cannot be done on a common interface. >=20 > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane > Reviewed-by: "Roger Pau Monn=C3=A9" Reviewed-by: George Dunlap > Sorry for the delay --Apple-Mail=_EE3D3734-4774-47EE-B9B8-C6F68DD4840E Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 13 Apr 2022, at 12:21, Jane Malalane <Jane.Malalane@citrix.com> wrote:

Add = XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and
XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated = xAPIC and
x2APIC, on x86 hardware. This is so that xAPIC = and x2APIC virtualization
can subsequently be enabled on a = per-domain basis.
No such features are currently = implemented on AMD hardware.

HW assisted = xAPIC virtualization will be reported if HW, at the
minimum,= supports virtualize_apic_accesses as this feature alone means
that an access to the APIC page will cause an APIC-access VM = exit. An
APIC-access VM exit provides a VMM with = information about the access
causing the VM exit, unlike a = regular EPT fault, thus simplifying some
internal = handling.

HW assisted x2APIC virtualization = will be reported if HW supports
virtualize_x2apic_mode = and, at least, either apic_reg_virt or
virtual_intr_delivery. This also means that
sysctl follows the conditionals in = vmx_vlapic_msr_changed().

For that purpose, = also add an arch-specific "capabilities" parameter
to = struct xen_sysctl_physinfo.

Note that this = interface is intended to be compatible with AMD so that
AVIC= support can be introduced in a future patch. Unlike Intel that
has multiple controls for APIC Virtualization, AMD has one = global
'AVIC Enable' control bit, so fine-graining of APIC = virtualization
control cannot be done on a common = interface.

Suggested-by: Andrew Cooper = <andrew.cooper3@citrix.com>
Signed-off-by: = Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: = "Roger Pau Monn=C3=A9" <roger.pau@citrix.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

Sorry for the delay

= --Apple-Mail=_EE3D3734-4774-47EE-B9B8-C6F68DD4840E-- --Apple-Mail=_C5CA3C6F-4080-4848-812C-4FE2935DB469 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLG9egACgkQshXHp8eE G+1wjQf9Gga/GYbfMnLk0FMu3c0Nrv9BQsLyTM4/V141Lr13jxRnXikju/JxOC3e tTx7X4xx8vlsS4Ln8VoXp7SWtQDLH4Cr/snoCR9o2z+0H5bzPKTaOfiRUA57I2qx +TDA1C27d9JYhKexTIdq8tgwJWEKt0CDVt1MStLxgldmiuG3fcjdzCwyaqmIYrE9 Z28SuIuSG8p6DyNX1NSk9HBqYQyWuGK39BVKF8QqfBo4xf+ALQqpaUf622pLJVPx Kkz2WCWMA5upAtRS3SOxeooZgjJMBndSZXlty0n/qy7/d4AdW5FXuErsXj2H1DpN t4xSNJn9N9mQL6M7FDlVCzlxa9L6sA== =OXgs -----END PGP SIGNATURE----- --Apple-Mail=_C5CA3C6F-4080-4848-812C-4FE2935DB469-- From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:04:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363023.593345 (Exim 4.92) (envelope-from ) id 1o9T3W-0008QO-H6; Thu, 07 Jul 2022 15:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363023.593345; Thu, 07 Jul 2022 15:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T3W-0008QF-Dx; Thu, 07 Jul 2022 15:04:38 +0000 Received: by outflank-mailman (input) for mailman id 363023; Thu, 07 Jul 2022 15:04:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T3V-0008Po-61 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 15:04:37 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c1b18a5-fe06-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 17:04:35 +0200 (CEST) Received: from mail-dm3nam02lp2041.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Jul 2022 11:04:32 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by BN9PR03MB5996.namprd03.prod.outlook.com (2603:10b6:408:135::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Thu, 7 Jul 2022 15:04:29 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 15:04:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c1b18a5-fe06-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657206275; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=jUsgCGSQLuXFvk4rrV+lirV8ytq8DE33EI+U8NZ35xo=; b=SV1u3g823+9VWh4xUNJdkTJGpx2eql28hynioAjW+Q2ywohPBSzyKePP YYWAJzmUKDPdW2RKyGtz6dGKeiRSLykQk4TWzUCeVeiKEtevKDH8UU5Dz 5I33FZ/FX0vhtQCqHuTIQHmXzJ7aBlBfrb64aMeXH8DdB6+YCUlXC8Jkk I=; X-IronPort-RemoteIP: 104.47.56.41 X-IronPort-MID: 75292900 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FVj5w6I62/MJ/JiOFE+RnpUlxSXFcZb7ZxGr2PjLsTEM7AuW5UVEl zVBCC3DeKqUMyGmS21FGN638k8AusDdydVmHgVq+Sw2Fi5G85XPXYXHcxz+NXPIdZLIF0k4t poUYdSRfJ49QC+C/EagPuexoSBxj/nUF7OU5IIoQsxUbVYMpHAJ1UIz8wJAvrNVvDSZP++sk Y6q8sGPaAT6hDV/bGtItvPZ9Ulj46yj5DoT4wxhOqkU7QPSz3UbMskSdPq7R5farii4PQIYq 8LrluzRErbxpk91Yj+duu+nNBVMGNY+BCDW4pZsc/HKbiNq+2pjiM7XCNJGMR0N02rRwIgro DlwncfYpTkBb/WkdNs1C3G0IwkmVUGR0OaaSZQXmZX7I3zuKxMA8d03ZK0FFdRwFtJMKXNP7 ZQlxAUlNXhvsQ4ULIWTEYGAjux7RCXi0Rh2VntIlVk1Bt5+KXzPrjmjCXa1E17ci+gXdcsya fb1ZhJkRiX5RhseNm4rAY01keOv3FemaixH/Qf9SaofuwA/zSRX+Z21ap/5X4fPQs9Y2EGFu mjB4mL1RAkAM8CSwiaE9XTqgfLTmST8W8QZE7jQGvxC2QXPgDBMTkBIEwfiyRW6ohfWt9Z3B EET4CUj64Qv8kiiVvH2XgGioW7CtRkZMzZVO7JnslDXm/KMi+qfLnYrRBprK/oMjekNRWd26 VrKgIzYAgU65dV5TlrYrN94twiaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cRnvx xiaoS54gK8c5eYJ2L+85kvvmC+3q97CSQtdzgfdU3+h7wh5TJW4fIHu4l/ehd5CMYKYQ1+pr HUC3c+E44gmFoqRnSaAROEMGrCB5PufNjDYx1l1EPEJ+z2z9la5cItX4TU4I11mWu46fjvub F7WqBlmzpZZN3u3bod6e4u0Tc8tyMDd+c/NU/nVap9CZ8N3fQrfpiV2PxbMhibqjVQmlrw5N dGDa8GwAH0GCKNhij2rW+Ma1rxtzSc7rY/Oea3GI92c+eL2TBaopX0tazNisshRAHu4nTjo IronPort-HdrOrdr: A9a23:I31zy61hlb7HOcUSxVAmAAqjBLAkLtp133Aq2lEZdPSdGvbo8P xG+85rsSMc6QxhPU3I9urqBEDtexnhHL9OgbX5Xo3CYOCFggWVxehZhOPfKlvbdBEWndQx6U 4PScRD4aXLfDpHZL3BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.92,253,1650945600"; d="asc'?scan'208,217";a="75292900" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TooWe6PZfWpB7VYMeftQtIdCmhOwhsIDqnghgafDnS8KNY4fZFzgVIwIPk2ZstU7W6uumKZlZKNxKTPK+ZtaTqpbI8KLylFatTQonyI0mXzKK30O29WeYKNSwWVQTypFQd3iyTDK3aZU7FF8eLGtQWQj5hyUyTMx6wBqk65HRrNlCI/tUlbOW2Cx6DX0aAK2pV23urHpwxbNDC5K1qaQE/+QKvjR6mgqShwmyAZ9v4366yrtZCrvEj0lBaNEC/Ea4TIU7tHf7IRysOC8N9opQHYdfpD9rnKVF9ijTk/oaSp0QmFt2uArrNW/0eD0uB6kMMpNgsW1oZKrN12gkuS8Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tpzsmyGCfuLEOqB+1/PeJIU7gP6YhSpxhE8g7RsWB/I=; b=BI329931FSImV/cxx1ZJe+77qq10LwsAVmIQvo22qm5NN1S5ldDi3Q7HPvDyvbUrmItDewlf9C9s28EQ9sRdwgRp3Uordh9W/vqtjMzULi+M3VUUQf60YoiRyN5v5XQRW4AJVSmJ5IrT1Z3vij4UPCTpzEvdnKe1/QVM7YDq9eKHdW1feHb45JAyl0oCti/ioeanZXkBJbKIijXV0mn95w5gTbvXSYekKc5F56nzCLtUaRccK8BdXNk0zmiGq6kEz81g5FGUfmn5jAuqIDduFXcdznWTzGUNFaYfke2pjTxk2kzEenJzZFklaherewHKx0kcyufWUlfwCF56rnN7vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tpzsmyGCfuLEOqB+1/PeJIU7gP6YhSpxhE8g7RsWB/I=; b=AFtgaSZBRBf3oLZFy43YpY2hTd+9cl72cOMTyvhEudP1Wy1hhIb6N1OefNJzdzS53hsAMFA4XvE3UwE1OxMLvg/sskkICHtApLkkROZ8rAsSueKYBJiR0H2xsT0+fOU4mpSBxVNsc6mrTRX3wSO9Keyz5q/hJFmZO/SrgqzndUA= From: George Dunlap To: Jane Malalane CC: Xen-devel , Wei Liu , Anthony Perard , Juergen Gross , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Christian Lindig , David Scott , Volodymyr Babchuk , Roger Pau Monne Subject: Re: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Topic: [PATCH v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Index: AQHYTyjMyYwCRaSEX02AKbyBHUjKJq1zh2MA Date: Thu, 7 Jul 2022 15:04:29 +0000 Message-ID: <93BBE1BA-35F6-4218-922D-863ED4D69AA0@citrix.com> References: <20220413112111.30675-1-jane.malalane@citrix.com> <20220413112111.30675-3-jane.malalane@citrix.com> In-Reply-To: <20220413112111.30675-3-jane.malalane@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1861aafe-8335-42d2-ca94-08da6029fdcf x-ms-traffictypediagnostic: BN9PR03MB5996:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xtd2R2/NWzE7jsTlAkJ8RWvwpYoK4TkBUXRV5GcbXqTWtONQ1PxXdNQKtWhPzkhLAZJjHc0uYHOX3sKcy6A3V9+zLDI0zfyMrP2wlrG7aKWil3Zazx68jsZh/49Y47IuUo5Bn/g8hZBVktfkwAU4HnECaAjLzJQMEGaJZr5+YJaMb8TLfDq5LJ6Hevm0cZ8MqvoX4IDIEo0TNn9G/0nx+gyuXSA0NpvJoZF4YiUmWDSqPPOkCtSDIWyPB5eQxaJugzwzdSCdoC1gCe1G0uq3l8zJy/t15pu9Flf7U0s7Su9GxcjQ7TndaUNVOeueW5RtIW1EfyX0tCDEaI4BrB+ZC7KG/gKAFSTM9gVOIlrKP1mgMthRwLyg7RQ2m9ik+6UcatUICNUJ6tzCNF72YUbhwavq5pjfWKzdRgw/kdwm7pMBkQICJwKrCaJo3tqT1czNVSXFLcCpvQcx9/5kP2LB7yZmvF3Gh8mJFB4DxEPkm6wwzOxFw479mayGZxcc4GDftUYe4xbvA6WmYMcIc7WvpjZJGLOcTQX6pTsGtM8J1cjZFkw+bEdR5qdFWkaDHCmc4s94qAPtAAcj1EuJN3inAwvsiasvvJg+79pEEXX7M7FGQk0mjUgn/CNPktQZZG0icQOTB+Ywt+JRhy+7v3DlNEXgQDNmiqGNBLRqfLKjOdEMIPjJzD5zAeY5nWvl0E2eetZZ2jubhsSFyTMrMSAFH71t33GpF6qGMAq94OowsHHVP338oknZB5/p+XaEvKh4GFxMOJRY6bBoWaW92ZXvdwD9+RIO44unfovhrMHT11rnBEoi7L9RyB9y36WLikBn34j/zn6GptlQMX7N/cXu3VBSPB9qIfNf8nW4KXBHHgA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(107886003)(186003)(2616005)(38070700005)(316002)(36756003)(91956017)(71200400001)(76116006)(8676002)(4326008)(83380400001)(38100700002)(6636002)(37006003)(54906003)(64756008)(66946007)(66556008)(66476007)(66446008)(478600001)(6862004)(86362001)(53546011)(8936002)(6506007)(5660300002)(6512007)(33656002)(6486002)(122000001)(82960400001)(26005)(2906002)(99936003)(41300700001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NTNBZjRqVCtNS2ZjWWZ6UUpxODhrMEpkT3hZSWR5SUNNdXlEZ0hGQ20xYm4z?= =?utf-8?B?OGRGTGFYdVp3Tldla2NpT1g5UVU1ZllQUFUvaExybC9EcHd1WGRNVFpYdzZr?= =?utf-8?B?TUYwcmdGaUo2V0RzOC9oZm40TUJWMjJTVFpBMXZGSngyaFBhcGtNZUQzWXMx?= =?utf-8?B?L1JHcHRyUXZkRE5VczBtbHB3OVNnY1FqdWlQWlNIQ3BWTEVuQnlnYkVsRzFL?= =?utf-8?B?M0EzUDBWeU41dzdRbmEzMUlMTTVZQ2d4RmI2cmtOeGhHSEhnbHBIVDRCalJV?= =?utf-8?B?eHIyeis5dXFHU01ORzRiMjdyMFBremFPMUdKSllaK25oR3UvZk82MVdCKzF5?= =?utf-8?B?QkZycTd4azY3VWRhb0l0UENyWnF3TXJGTVdJUExiMFhRVUN5S1k2WlU3eVda?= =?utf-8?B?WWV3YU5WUzQzY3Vmb29QdTl5UjQ3NkpMZHY4NjFlTlNUaGRjTUwzbDRpVnpI?= =?utf-8?B?UUtqZGRGSG5aQ2dkUFZ5WVlnRCt0WnQvOEZ1OG9mNk9CQk1tSjQySDdHNmZx?= =?utf-8?B?Z29UbDZBbmREVldXcWRHVmF4c2duaFJPU0VNLzBrOGZBR3hsbHVXL3U4WU1X?= =?utf-8?B?cHFCbkFvRVNJQjFyWlpTbWJCQTVFQXZLYUJPVENaRVhaZTRKM3Z5Q0JzNGNK?= =?utf-8?B?TDJtSzRQZXlrVlBnR1M0bjIzeTB1WktXdy9tb252KzRya2d4RTNMWGlhc0hm?= =?utf-8?B?UFhGUnhQVmxrR2NJWUJYenpFQ2hNNTZqcE03N0Y3QllJQTFTUERGS2RIWENM?= =?utf-8?B?VUhONllHU0VsM0taa3dGNDMyTlJzV0FYdHpYZHJrM3lwUjh6YTRhaUNTU1Rp?= =?utf-8?B?ek5IMFhlQk81UHFJTVc3Y0dGdVk1NVBiTGVjVjc1UzRYa2RkTXN5ZjJsR1dv?= =?utf-8?B?aUJONHp5bU42dkRuRXlQZ0ZJbHJTZmx1ZjFkZTlPcldJUVFLa0NzSDhoRHdE?= =?utf-8?B?RzQvYkpwSWNibjNvNzdOMVdLL3lCdms2UFJETndRTmRZc2tkNVBFSkpxVGRu?= =?utf-8?B?T3c1L0EyWGVzSHFiTVVnOHhvOUpKWU5JbTJUWE4wRTJRRERLTXRBMzFYQ3p3?= =?utf-8?B?RXUxcUxFMWtsSW5ucElHVU1kQ2wyMlB4S1l6RksvQWZOTVhxL3dMdzJXV3Vw?= =?utf-8?B?eVBTWVc5THJlSlQxSlZ5V21WaFZ6Y1hUeUNNQlpWMkIyVTRVQmJ6bVB5RFln?= =?utf-8?B?ZUcwMEFienhHTjZsbkVBV1N2UTRWVkdBZnBscUxjQmsxRnRCbzZsRnVzakRa?= =?utf-8?B?dzQrV0djSW5LbXU3WWp1eStaSEVKSlVDU0tRWndMWXBpbjlpRzhLQjh5dlpC?= =?utf-8?B?aUpvNjdXZ2drMXhCRW4yZUlpOFBKMUNhYkFFV2MrTHU0NE8rbEZRdXNBMFJO?= =?utf-8?B?ZGJBaDNhNzg2ajBzU3cyblpiSjdMWlJxK04vUnJsN3FNR2xPYTFVWUVZeisx?= =?utf-8?B?dWNvMFI0a1NPTjZIQndSWVJaeFNma0xZcDVJSllYL1hQdmVqaG91QTE2U1lB?= =?utf-8?B?R3VsTkJLb0JUeUFiV0E0dzRJTzFGeFBvR2wxSnZ3WXpBVjF2SkhmbXFaKzVP?= =?utf-8?B?K2U4TjFQcW85dlJuaGhXYjF0QnhVVjBaZlJlUFYxS2tDNzg3ZW5JTy9ST3dS?= =?utf-8?B?UDRHemYxN1E0ckVVSTVmNjhiYnB5QXU1TG93OTlZa2dQR0tCYTcramNiT2Z1?= =?utf-8?B?VTJNMTJpalpJMHpuci9yVkR0L0xvUVNKWm05Tk42MkRMNkNiV2pqTzNZenF4?= =?utf-8?B?ZVBDTHcxcnhxQThHYUYraUxEcmoweXJ4RVE3MDFNOHF6cCs0YUJrcGhKZXRV?= =?utf-8?B?aXQ4VUZaUjVHMG9vWitpMzhSUFdscHNtcVlML0lTNzdmZHRMV2xvMmdxQVhQ?= =?utf-8?B?eVE3QzVXdlhvSGtZRmlQMTU2Y2tNci9YWVc2bjRqZk1rS1ROTjVnVm1Gelh5?= =?utf-8?B?QmF4MU9pNGhPOXJjWVNEN0NSZU9McS81d25JV2ZlQjhHUlljd3FySUR1V2Jm?= =?utf-8?B?VjYzdjViRFVucTZZUDRKWFZhUXNNTTI4UENiRXRudzVjaFRhMFo4SlFvYVFC?= =?utf-8?B?MVRkdWdEbEZxeFVBa0hxaVdIVW5nM2hldDc4aTgzNWE5dmNMT3hpMHI4SDhY?= =?utf-8?B?WGFJWnpBYWRPYzdVREJ5b2lpTmhJMEg3RXhLTkJEc1U4VmtOR3IxUWkyWXJn?= =?utf-8?B?dGc9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_42BFAA6B-3502-4303-A56B-BC40751AC0BC"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1861aafe-8335-42d2-ca94-08da6029fdcf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 15:04:29.4056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ixp+ArNskTyvWs7lObnEsC9aJ9wU6gcNZkzyN9i4a2baw47drsu7WXtz9k1cQZC5CIv89VSutnV5lgBcDLXUFRHuWpqPb/hmouLevvbyaII= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5996 --Apple-Mail=_42BFAA6B-3502-4303-A56B-BC40751AC0BC Content-Type: multipart/alternative; boundary="Apple-Mail=_6C193DFC-0E85-4211-A0C2-B3E798EB6AD3" --Apple-Mail=_6C193DFC-0E85-4211-A0C2-B3E798EB6AD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 13 Apr 2022, at 12:21, Jane Malalane = wrote: >=20 > Introduce a new per-domain creation x86 specific flag to > select whether hardware assisted virtualization should be used for > x{2}APIC. >=20 > A per-domain option is added to xl in order to select the usage of > x{2}APIC hardware assisted virtualization, as well as a global > configuration option. >=20 > Having all APIC interaction exit to Xen for emulation is slow and can > induce much overhead. Hardware can speed up x{2}APIC by decoding the > APIC access and providing a VM exit with a more specific exit reason > than a regular EPT fault or by altogether avoiding a VM exit. >=20 > On the other hand, being able to disable x{2}APIC hardware assisted > virtualization can be useful for testing and debugging purposes. >=20 > Note: >=20 > - vmx_install_vlapic_mapping doesn't require modifications regardless > of whether the guest has "Virtualize APIC accesses" enabled or not, > i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as > virtualize_apic_accesses is supported by the CPU. >=20 > - Both per-domain and global assisted_x{2}apic options are not part of > the migration stream, unless explicitly set in the respective > configuration files. Default settings of assisted_x{2}apic done > internally by the toolstack, based on host capabilities at create > time, are not migrated. >=20 > Suggested-by: Andrew Cooper > Signed-off-by: Jane Malalane > Reviewed-by: "Roger Pau Monn=C3=A9" Golang bits: Reviewed-by: George Dunlap > --Apple-Mail=_6C193DFC-0E85-4211-A0C2-B3E798EB6AD3 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 13 Apr 2022, at 12:21, Jane Malalane <Jane.Malalane@citrix.com> wrote:

Introduce a new per-domain creation x86 specific flag to
select whether hardware assisted virtualization should be = used for
x{2}APIC.

A = per-domain option is added to xl in order to select the usage of
x{2}APIC hardware assisted virtualization, as well as a = global
configuration option.

Having all APIC interaction exit to Xen for emulation is slow = and can
induce much overhead. Hardware can speed up = x{2}APIC by decoding the
APIC access and providing a VM = exit with a more specific exit reason
than a regular EPT = fault or by altogether avoiding a VM exit.

On= the other hand, being able to disable x{2}APIC hardware assisted
virtualization can be useful for testing and debugging = purposes.

Note:

- vmx_install_vlapic_mapping doesn't require modifications = regardless
of whether the guest has "Virtualize APIC = accesses" enabled or not,
i.e., setting the = APIC_ACCESS_ADDR VMCS field is fine so long as
virtualize_apic_accesses is supported by the CPU.

- Both per-domain and global assisted_x{2}apic = options are not part of
the migration stream, unless = explicitly set in the respective
configuration files. = Default settings of assisted_x{2}apic done
internally by = the toolstack, based on host capabilities at create
time, = are not migrated.

Suggested-by: Andrew = Cooper <andrew.cooper3@citrix.com>
Signed-off-by: = Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: = "Roger Pau Monn=C3=A9" <roger.pau@citrix.com>

Golang = bits:

Reviewed-by: George Dunlap = <george.dunlap@citrix.com>


= --Apple-Mail=_6C193DFC-0E85-4211-A0C2-B3E798EB6AD3-- --Apple-Mail=_42BFAA6B-3502-4303-A56B-BC40751AC0BC Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLG9fwACgkQshXHp8eE G+3kqQf+L6U5SSJM2QZEd12K4hoLJobxk55T5ctk9fRn33LpJYEJ8evnBddsXeH9 IlJ84OVuDDoxCoqeROdsUONfiUn73cttP6NBb53mZ+WrjAQ2hy7x7KlHFt8kAkGr EXTgLqhW6lIMZyaql9pMJyOzZuL9Vp0LLLqQ9+Lf+bPpTgTz6iR4rBzU3fjwjylt wGpen/kFNP+st7ZjW44Ie0AJHFSa8TazId9LmCNd35ZwBorbUOCwUwFjvKjt84Kr qhA3LePr+UetNo18OU/Xm93oQKPXGXE2p83YGQ0aYpdGZWXL/LEEPI+6/pJ+C5TU QLzxfNJUi8XFpbOQG7d2k8CxhP2Sjg== =/HbF -----END PGP SIGNATURE----- --Apple-Mail=_42BFAA6B-3502-4303-A56B-BC40751AC0BC-- From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:06:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363033.593356 (Exim 4.92) (envelope-from ) id 1o9T4x-0000qt-1m; Thu, 07 Jul 2022 15:06:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363033.593356; Thu, 07 Jul 2022 15:06:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T4w-0000qm-Uh; Thu, 07 Jul 2022 15:06:06 +0000 Received: by outflank-mailman (input) for mailman id 363033; Thu, 07 Jul 2022 15:06:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T4w-0000qW-9h; Thu, 07 Jul 2022 15:06:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T4w-0000Lt-53; Thu, 07 Jul 2022 15:06:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9T4v-0003qe-OS; Thu, 07 Jul 2022 15:06:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9T4v-0004yu-Nx; Thu, 07 Jul 2022 15:06:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=SZThY3ZEwN6VImXNVx8xhcZDpG3q0+okEBFcPXU3824=; b=MRiyjKRS1EmP8km1S4H7xAcpVf 0FL5R3GMV+9e97f/HC9bBG9do7wdakaxnU9pbOfvQNJWsUm/cU/TpTmFtPoBTs7OJDJIwhs5QS7zJ aHlYO6kOjVogfZczk9Z1Btm8StzMsXSi+3DiILKm8pL1qEMFGRqi9HBnmMsfWmCVNVXs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171542: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-arm64-arm64-xl-vhd:guest-start.2:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9f09069cde34dcd86f5ecf3a3139fd752020812f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Thu, 07 Jul 2022 15:06:05 +0000 flight 171542 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171542/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 18 guest-start.2 fail pass in 171537 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9f09069cde34dcd86f5ecf3a3139fd752020812f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 18 days Failing since 171280 2022-06-19 15:12:25 Z 17 days 48 attempts Testing same since 171537 2022-07-06 22:42:57 Z 0 days 2 attempts ------------------------------------------------------------ 499 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 20617 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:24:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:24:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363047.593367 (Exim 4.92) (envelope-from ) id 1o9TMp-0004HJ-LW; Thu, 07 Jul 2022 15:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363047.593367; Thu, 07 Jul 2022 15:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TMp-0004HC-IA; Thu, 07 Jul 2022 15:24:35 +0000 Received: by outflank-mailman (input) for mailman id 363047; Thu, 07 Jul 2022 15:24:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TMo-0004H6-SS for xen-devel@lists.xen.org; Thu, 07 Jul 2022 15:24:34 +0000 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e73f96f0-fe08-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 17:24:33 +0200 (CEST) Received: by mail-ed1-f54.google.com with SMTP id fd6so23587980edb.5 for ; Thu, 07 Jul 2022 08:24:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e73f96f0-fe08-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yKIX1Zf5uIz6Xx7Ku3sbPTiazshJJhCh8BzIuZZ0kg8=; b=7SeGRBI5rsW/eQ5wbh0wez4473N8g3s9PHAoBaddqwLg5RTwxVA1+9ZfJBS/wo2Ltn 8sRgr06mzfLhZUO+mTJSfVubprvsi/Hqgv9+8yE7C6ym2i0SXBGz3LKA1hs9N7TvJcuC SSZgiikPF2YOovw6G7ZiOsEIpZn77vj5UzihWq+h77ql9JRNLK7MkqKUkPNcRHyfQC/s 3e6gXE998TyCDXMoavTR0sxJrQzxz3jkx6IjqAT6E0oEwP1cVP/k40iHzktmT2JEQX11 6T/dJGMAiyvj+TcaA2111FJaeQvJ6H1P4K4Tfuj2iXRgQXdjpMQun+dYR43I/q8Yb8jG jYYg== X-Gm-Message-State: AJIora8E3a7zeeh7R2Feqw9fAtEDdfqzfx3nd/JPN9brPHOXzs7gfzl5 lKFtKjPdHTd7IfZRu99TLIPjCwdqScsq21/hEmk= X-Google-Smtp-Source: AGRyM1u31HggXWDgba9zCpkuSwc5LQwhOHw3PqS5C/hDFj7yV2fUdsLujwm5yHmvwKwnCUkGaNvUDmcDYb43hK1orFM= X-Received: by 2002:a05:6402:84f:b0:437:6293:d264 with SMTP id b15-20020a056402084f00b004376293d264mr61516301edz.317.1657207473181; Thu, 07 Jul 2022 08:24:33 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Thu, 7 Jul 2022 23:24:21 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Wed, Jul 6, 2022 at 2:33 PM Jan Beulich wrote: > > On 06.07.2022 08:25, G.R. wrote: > > On Tue, Jul 5, 2022 at 7:59 PM Jan Beulich wrote: > >> Nothing useful in there. Yet independent of that I guess we need to > >> separate the issues you're seeing. Otherwise it'll be impossible to > >> know what piece of data belongs where. > > Yep, I think I'm seeing several different issues here: > > 1. The FLR related DPC / AER message seen on the 1st attempt only when > > pciback tries to seize and release the SN570 > > - Later-on pciback operations appear just fine. > > 2. MSI-X preparation failure message that shows up each time the SN570 > > is seized by pciback or when it's passed to domU. > > 3. XEN tries to map BAR from two devices to the same page > > 4. The "write-back to unknown field" message in QEMU log that goes > > away with permissive=1 passthrough config. > > 5. The "irq 16: nobody cared" message shows up *sometimes* in a > > pattern that I haven't figured out (See attached) > > 6. The FreeBSD domU sees the device but fails to use it because low > > level commands sent to it are aborted. > > 7. The device does not return to the pci-assignable-list when the domU > > it was assigned shuts-down. (See attached) > > > > #3 appears to be a known issue that could be worked around with > > patches from the list. > > I suspect #1 may have something to do with the device itself. It's > > still not clear if it's deadly or just annoying. > > I was able to update the firmware to the latest version and confirmed > > that the new firmware didn't make any noticeable difference. > > > > I suspect issue #2, #4, #5, #6, #7 may be related, and the > > pass-through was not completely successful... > > > > Should I expect a debug build of XEN hypervisor to give better > > diagnose messages, without the debug patch that Roger mentioned? > > Well, "expect" is perhaps too much to say, but with problems like > yours (and even more so with multiple ones) using a debug > hypervisor (or kernel, if there such a build mode existed) is imo > always a good idea. As is using as up-to-date a version as > possible. I built both 4.14.3 debug version and 4.16.1 release version for testing purposes. Unfortunately they gave me absolutely zero information, since both of them are not able to get through issue #1 the FlR related DPC / AER issue. With 4.16.1 release, it actually can survive the 'xl pci-assignable-add' which triggers the first AER failure. But the 'xl pci-assignable-remove' will lead to xl segmentation fault... >[ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] >[ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 Since I'll need a couple of pci-assignable-add && pci-assignable-remove to get to a seemingly normal state, I cannot proceed from here. With 4.14.3 debug build, the hypervisor / dom0 reboots on 'xl pci-assignable-add'. [ 574.623143] pciback 0000:05:00.0: xen_pciback: resetting (FLR, D3, etc) the device [ 574.623203] pcieport 0000:00:1d.0: DPC: containment event, status:0x1f11 source:0x0000 [ 574.623204] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected [ 574.623209] pcieport 0000:00:1d.0: PCIe Bus Error: severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver ID) [ 574.623240] pcieport 0000:00:1d.0: device [8086:a330] error status/mask=00200000/00010000 [ 574.623261] pcieport 0000:00:1d.0: [21] ACSViol (First) [ 575.855026] pciback 0000:05:00.0: not ready 1023ms after FLR; waiting [ 576.895015] pciback 0000:05:00.0: not ready 2047ms after FLR; waiting [ 579.028311] pciback 0000:05:00.0: not ready 4095ms after FLR; waiting [ 583.294910] pciback 0000:05:00.0: not ready 8191ms after FLR; waiting [ 591.614965] pciback 0000:05:00.0: not ready 16383ms after FLR; waiting [ 609.534502] pciback 0000:05:00.0: not ready 32767ms after FLR; waiting [ 643.667069] pciback 0000:05:00.0: not ready 65535ms after FLR; giving up //<=======The reboot happens somewhere here, not immediately, but after a while... //Maybe I can get something from xl dmesg if I was quick enough and have connected from a second terminal... [ 644.773922] pciback 0000:05:00.0: xen_pciback: reset device [ 644.774050] pciback 0000:05:00.0: xen_pciback: xen_pcibk_error_detected(bus:5,devfn:0) [ 644.774051] pciback 0000:05:00.0: xen_pciback: device is not found/assigned [ 644.923432] pciback 0000:05:00.0: xen_pciback: xen_pcibk_error_resume(bus:5,devfn:0) [ 644.923437] pciback 0000:05:00.0: xen_pciback: device is not found/assigned [ 644.923616] pcieport 0000:00:1d.0: AER: device recovery successful > > Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:34:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:34:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363056.593378 (Exim 4.92) (envelope-from ) id 1o9TVw-0006JJ-L6; Thu, 07 Jul 2022 15:34:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363056.593378; Thu, 07 Jul 2022 15:34:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TVw-0006JC-Hk; Thu, 07 Jul 2022 15:34:00 +0000 Received: by outflank-mailman (input) for mailman id 363056; Thu, 07 Jul 2022 15:33:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TVv-0006J6-3L for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 15:33:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TVu-0000qG-Rb; Thu, 07 Jul 2022 15:33:58 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9TVu-0008Pw-J2; Thu, 07 Jul 2022 15:33:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rnJfiPsQmWZTbshkN65fFEtDQJwuywOCItlDl6yv4wQ=; b=ms5rDl8un0quL02IR424v6gTIH x0PVHQeUMlVt1YrGfgfdWfIBKBr9vObZw9SFaXE2n48TsDr68Emr3psvaaVvimuAZ6hIzUOqS8X0h s+0AbVU9o6W3L4hPEwWMpVxJm41zY6H6lBHRzd40TL5gfblLL56PZTj5R9wg3IcHP9AY=; Message-ID: Date: Thu, 7 Jul 2022 16:33:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] xen/arm: avoid overflow when setting vtimer in context switch To: Jiamei Xie , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Wei Chen References: <20220706082558.1116811-1-jiamei.xie@arm.com> From: Julien Grall In-Reply-To: <20220706082558.1116811-1-jiamei.xie@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jiamei, On 06/07/2022 09:25, Jiamei Xie wrote: > virt_vtimer_save() will calculate the next deadline when the vCPU is > scheduled out. At the moment, Xen will use the following equation: > > virt_timer.cval + virt_time_base.offset - boot_count > > The three values are 64-bit and one (cval) is controlled by domain. In > theory, it would be possible that the domain has started a long time > after the system boot. So virt_time_base.offset - boot_count may be a > large numbers. > > This means a domain may inadvertently set a cval so the result would > overflow. Consequently, the deadline would be set very far in the > future. This could result to loss of timer interrupts or the vCPU > getting block "forever". > > One way to solve the problem, would be to separately > 1) compute when the domain was created in ns > 2) convert cval to ns > 3) Add 1 and 2 together > > The first part of the equation never change (the value is set/known at > domain creation). So take the opportunity to store it in domain structure. > > Signed-off-by: Jiamei Xie Reviewed-by: Julien Grall The commit message is my own, I would like to Bertrand or Stefano to confirm they are happy with it :). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:36:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:36:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363062.593389 (Exim 4.92) (envelope-from ) id 1o9TY2-0006sl-1L; Thu, 07 Jul 2022 15:36:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363062.593389; Thu, 07 Jul 2022 15:36:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TY1-0006se-Up; Thu, 07 Jul 2022 15:36:09 +0000 Received: by outflank-mailman (input) for mailman id 363062; Thu, 07 Jul 2022 15:36:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TY0-0006sY-OX for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 15:36:08 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130079.outbound.protection.outlook.com [40.107.13.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 84761a5b-fe0a-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 17:36:07 +0200 (CEST) Received: from AS8P251CA0009.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:2f2::34) by VI1PR08MB3854.eurprd08.prod.outlook.com (2603:10a6:803:c2::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 7 Jul 2022 15:36:04 +0000 Received: from VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f2:cafe::c5) by AS8P251CA0009.outlook.office365.com (2603:10a6:20b:2f2::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17 via Frontend Transport; Thu, 7 Jul 2022 15:36:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT008.mail.protection.outlook.com (10.152.18.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 7 Jul 2022 15:36:02 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Thu, 07 Jul 2022 15:36:02 +0000 Received: from 307ba5673931.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BCA4E506-74D8-436C-BA28-3F2FA7F5D87E.1; Thu, 07 Jul 2022 15:35:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 307ba5673931.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 07 Jul 2022 15:35:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB7PR08MB3676.eurprd08.prod.outlook.com (2603:10a6:10:4d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Thu, 7 Jul 2022 15:35:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Thu, 7 Jul 2022 15:35:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 84761a5b-fe0a-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=L+gsgTEzSa/5yhp/VGbRNOp9L+SRlUSiXTPSXfbf4f3LrGs8pwYcfWMTi4xbrYvnvJrDGaemCUnh+Tk/OgUuXlROKbRgvg1g0o4/5Zdx51d7sMaqEKxPqRYFg84WDOCd1syiCRPFT1PXEsBEKh5tdIKycHABxx83X0KNvouVNI1mt4iyfisDlAJg/sJGoFIfth1UJcMLujFme5R/X6l7zCuP2HAYl4EiXPHip0/Glpnv2e1txlsiy09JDXpCkIzNfsSiF5NWOhXErX5uJSO2JIiRuA3L+IOSAaP/9qbBrbUas5v239RGTT9DQxlvbT/Xy02cp1koF7Ow2Xf4zKf9GQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGY+VV9hCUPZRXDBldhaSoi35/X4k/KdbHvCmaZMBHc=; b=VzRuACY4fNJxuwxD6KcDwQF1cMq/OdsobPBHVVoyA+mZxN8+aHW0YEjQyayiHcpVbnmUgJnGIJ+mLNVuROEMKEgSaVdwHHj3t1tFYVztpIfZT9d3RhvtO62cIQxbrzFme5UWw5fFZrIvqRIFlX+SmLej4Tx2KuaDkH6Iek9ugai6M7qM8SyvVZyoqjVnD2K7GWjvi43WimOB8IaZAE93TvbQFqBNwV/mSDV8NsJCDYnstkxd5R7AI2VTb6FHz9j+/jr8gbVrP8jicGCn5ady2trYGAYGrcSo3cSlodrJZPmap0yq1fpZzgHnZJRTqWB4rKRCc/p0brZNs5JYBZdDLQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGY+VV9hCUPZRXDBldhaSoi35/X4k/KdbHvCmaZMBHc=; b=2pZkclLqHNDqFzrVY0TIkpqNyN2K1rhMcnoskWq1kuxWUTEzc8p/q/OaPWPOWeGwOfzdEjS4zYCbcMyxO2wt6ZuA28jMezRfnRNc0Le9vuOiapQdx9BaIv+a1OHqeSmcM8wRFm/01+/T/VcIsFhoFMRrvf4Feja7KnNntulTb3c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8cee0535145a4286 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PBz4toH86alDcyWasL2eHOrhWYiI8KK+DYuvBFgTROf3NXhqV2js7bCzRkUVKcsoOmr2KyerojTPjoK7MQmWy4h/gKXToccUj8g7kkTopmy6VBQfck8HAtZyNaru0jVwV7CiPuBz9PbZW6Pd8DXXNJiPv86JSWaVDSxUbeg5AUp5vngkcd+twN7s1eidY7rd/wWe2JKL+CvrAjjKZJOER14SXCg4t7MrM280ytPgOWEEtKIhundCNik1Mtmpt3iUMotx7FL16K3TBa+fBUhAXMwM9NftRaw7X2AzS4eNax7+LqqCqUIEAEilcTktP0WnxLdwaKO4qtEFQj9YW3MZkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGY+VV9hCUPZRXDBldhaSoi35/X4k/KdbHvCmaZMBHc=; b=hOJVIdzXwueZMAO+S58raZIJaQegR5zq3+1e6/j62ISmTmy5AECB0T7UaY4AqV2TuQTK5/O6uixNCNFippkO3TCIjOjWLKPbKv7GHZF+EFSQkNYLJm6t+tDPcno7oQQWv7WL5NYvV6PNt8jBG8xMYwtYIrQjxQjz7POQsPzvmn3y0+0wWaBsmwkrOeTWQeFisg3yu2b0cPXaJJX4gXLnT0OlZqHNBz6zXv7gzrX/sthFs0+8nlM2sxWn+gMSen2yKTmkpU01yHd9hNhbKGdUK+53N3XswCIefyzb5lep5nEI2xMM1Xd2H2Y/HgjpiNe+i2GswG0u0kgofr4fZzKYsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pGY+VV9hCUPZRXDBldhaSoi35/X4k/KdbHvCmaZMBHc=; b=2pZkclLqHNDqFzrVY0TIkpqNyN2K1rhMcnoskWq1kuxWUTEzc8p/q/OaPWPOWeGwOfzdEjS4zYCbcMyxO2wt6ZuA28jMezRfnRNc0Le9vuOiapQdx9BaIv+a1OHqeSmcM8wRFm/01+/T/VcIsFhoFMRrvf4Feja7KnNntulTb3c= From: Bertrand Marquis To: Julien Grall CC: Jiamei Xie , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk , Wei Chen Subject: Re: [PATCH v4] xen/arm: avoid overflow when setting vtimer in context switch Thread-Topic: [PATCH v4] xen/arm: avoid overflow when setting vtimer in context switch Thread-Index: AQHYkRIUbyH8VqZ9NUOQezXCQ2anPa1zC8wAgAAAigA= Date: Thu, 7 Jul 2022 15:35:52 +0000 Message-ID: <0847A13D-967B-450D-85D4-3D644E821905@arm.com> References: <20220706082558.1116811-1-jiamei.xie@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 68e62fb2-d78a-4f8a-c48a-08da602e6678 x-ms-traffictypediagnostic: DB7PR08MB3676:EE_|VE1EUR03FT008:EE_|VI1PR08MB3854:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zWpKaH6cFGhCHpabb//QEEEHQLc4bFnFnAyY5sXfHQDrv7UAflMAmnyaPOtx3AIf7bCveLA5QsSwS9YwHnzD2gdNgW1wlvmsOlfAaE7cNhyysEqEgyr9y6RRKTkkEssEnGA3qAaJikLP7CahG8zPtMTdCWoCwkt7VzPku/wcoQPtwMrCv8I7DZx9mX7JMreldRpHlsj0WXgPdNibfmlW9SoSu6iM1uu5pY2lFHetxsI5gpe/P309JHKcyoXl4e/3/EN04AzAcc5s9aq4POV0NqEE+BWPup/PVhIQZ+cR8qXARb34iGM8cGz08MT9/h5LuHc09nY46uhs4flX6Ru9V8t90Yg5og98cLRUOCL7hdO7zMI/gQYTkyOzeGDw8eshMHptooT9nppr7ee+lVZaR9D+RFQVghOWktw1ln4W7d7HL75IBR+oJuofG6ovSTnB0Aa/gH2uim32euR1OUnOtC6kr9c/V7c2QCThcUpzC9NL+xqB1A38KUSa7J9OuCGBS36bAxetCAkA1RBNcAOLOai1DlA5vGafw/tgm0GUfYmJqEkaZE4NEn5ObQxggOnKgAjBOSxJaayQP9BA7snopHy6W24hJMQZQqEj3N/etRvmPCI6fJccT7J/RAYERzJtGQFgtxOkbZhqz3Kj91c+qeTJfR3HmW2NJDuoleXZs+x5vvMfk+gMvxRDmetcZsGeCwgPpS/BRWQngSgKgM882gaTmgdagCAZec9/g8F1Jd3pxWLbdhd565ggwdescDEiRBNtDAJ2pTcwPX+qWlJ0ua1e0Pxtr/LWTePEReXpo7byDswsf26gG1xNFBMkE+xBWjPlQdzv29Jqp3OORHEtmALus5DCnaBVeusli2WDuWI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(5660300002)(66946007)(91956017)(83380400001)(186003)(8676002)(8936002)(66556008)(38100700002)(316002)(66446008)(6916009)(54906003)(66476007)(2906002)(53546011)(2616005)(6506007)(33656002)(26005)(6512007)(71200400001)(478600001)(6486002)(41300700001)(4326008)(36756003)(64756008)(38070700005)(86362001)(76116006)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <44CC91E0230605478A2CAADD055139E0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3676 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 97cd2bde-d779-431a-8386-08da602e603b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ergipWglCBPoLiobrfm/nUCTw/4qpAKQuRI4dsfVEOp1M8ar1/qc0V/dRyQaTO3BI8zNLSS9UBOsQYaTb6tP/gNXXmwICxV2A7lx8Y3f7gAtSYADy9MVS1AblOK7MxQQWWW91kEbrcc817COeCg0N/EwrKI5oi7KvYA5N0kvae4RAeS0UJFpL32tfhwt0sBlmGJrrWg8QB5tt3GAIwXhbL4ZI1U1T8WmAYJjrBaRhpWCF0RUub2KhhtIinmqPrzZ1WakyVYXqdOe9pMpbB5jNBn0pBnqg/gBcaRurQY1Jh7er92xAK+672R9lcXCLP8lfkRUgHVArLdctpmF1nintWz0yWF9Y8CSdiCVJTFrXEs+T8BoqNqYi+/OXlRRlTSHbAqpI5Q/iG2EZGcG19RVOiQpivxTuwwfRLA23u2uDYKWWvI/oC7WEh/MUNcZmhNTzsXT/7R4KMapD4Yy0pqVAIRC2NC1Fgpm8Q+Z+x/9tN90UbLDa2GUtR2mo5PWdU8wIX51ctufIfbZElfjXDjAwtoy8gyxJByMljyjYahdjrZISjU9RDIeDlnF5dWOLZ6jtES1/N+ReezYUZZsa4MTcwmhW3sDQAflkoseIkFXA+CBiutC1LW/Y/oprNMbUGZ0Z1hE/7f+0jrINWV7mDVkMde0NzXwiKhevxf0G792M7jFGC9pxtiZ/cR0vsq1sC078hli0+NUuZ7lsScXWAuo1pKbxvS3195gItC8SBKS2nQYFOHeqLomhhimVpHvFtGYCk5Ffx14kYSNo9eib2/DN0wJHFnQzYQzANcZCVQxJxaz4MdQQvMFLdMOhz413z1L X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(36840700001)(46966006)(40470700004)(316002)(81166007)(83380400001)(356005)(82740400003)(36860700001)(54906003)(40460700003)(8936002)(86362001)(6512007)(8676002)(5660300002)(6862004)(336012)(70206006)(47076005)(2616005)(26005)(6506007)(70586007)(6486002)(53546011)(4326008)(36756003)(82310400005)(40480700001)(478600001)(33656002)(186003)(41300700001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 15:36:02.9049 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 68e62fb2-d78a-4f8a-c48a-08da602e6678 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT008.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3854 Hi Julien, > On 7 Jul 2022, at 16:33, Julien Grall wrote: >=20 > Hi Jiamei, >=20 > On 06/07/2022 09:25, Jiamei Xie wrote: >> virt_vtimer_save() will calculate the next deadline when the vCPU is >> scheduled out. At the moment, Xen will use the following equation: >> virt_timer.cval + virt_time_base.offset - boot_count >> The three values are 64-bit and one (cval) is controlled by domain. In >> theory, it would be possible that the domain has started a long time >> after the system boot. So virt_time_base.offset - boot_count may be a >> large numbers. >> This means a domain may inadvertently set a cval so the result would >> overflow. Consequently, the deadline would be set very far in the >> future. This could result to loss of timer interrupts or the vCPU >> getting block "forever". >> One way to solve the problem, would be to separately >> 1) compute when the domain was created in ns >> 2) convert cval to ns >> 3) Add 1 and 2 together >> The first part of the equation never change (the value is set/known at >> domain creation). So take the opportunity to store it in domain structur= e. >> Signed-off-by: Jiamei Xie >=20 > Reviewed-by: Julien Grall >=20 > The commit message is my own, I would like to Bertrand or Stefano to conf= irm they are happy with it :). I am ok with it so: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 07 15:36:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 15:36:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363065.593400 (Exim 4.92) (envelope-from ) id 1o9TYa-0007Oc-Bx; Thu, 07 Jul 2022 15:36:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363065.593400; Thu, 07 Jul 2022 15:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TYa-0007OT-7h; Thu, 07 Jul 2022 15:36:44 +0000 Received: by outflank-mailman (input) for mailman id 363065; Thu, 07 Jul 2022 15:36:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9TYY-0006sY-Bu for xen-devel@lists.xen.org; Thu, 07 Jul 2022 15:36:42 +0000 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 990e0413-fe0a-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 17:36:41 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id r21so4303408eju.0 for ; Thu, 07 Jul 2022 08:36:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 990e0413-fe0a-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=k9zvRBTAarQDBW+yV0xbSQ9HXjuCg1/YQ0xUJVgLye8=; b=C8EQ/2k6WaordlwWa8Vhquhi6QIIsUWRqmUXwVYlDI2t/hLii7/5/8rmKuASSrpZ3g Yc7T5tB8FI9+GR0PKfopz5bD9meT567b4B/R2Wr6VsJcDzW/Li9uOQslflhwNYJmZUlM sVR30UOEESh09S/FNU2KlcMs3zbMKa4Hg95KWVoIe5Bov5CzilGKZjsNjOyXbn5cDjiM VrkZtO2cFXp60idCzOs8tMEbiJrMbofxrYbYrZuTQEGV1RzvJJWZ7+2IBvrYgFwE0hcA yUGQ/e4Hcb1AZUBZsowtzOXwAHLAK2KMzkzqtI0T5J2KGwsEOu5eA+ly4DHifTocNvva 0Nqg== X-Gm-Message-State: AJIora/5AUjr8RhIQdbF3WRIcmmi/qLKDga5MyTyNqcyuKADdXsRZHas ZXgtdJtmrE5RDXKczkS6otlzScvy7FPRfIlQBrU= X-Google-Smtp-Source: AGRyM1t69BBXuQvouWBuAE+8agGyOBw6h/nlwjgXF1lmuCaBsDWVQCAge3WAmb9wo0oEzVPHPxk1fEZDtawbMkQr7xY= X-Received: by 2002:a17:906:9b8a:b0:722:e50e:2a6d with SMTP id dd10-20020a1709069b8a00b00722e50e2a6dmr46464711ejc.724.1657208200872; Thu, 07 Jul 2022 08:36:40 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: "G.R." Date: Thu, 7 Jul 2022 23:36:28 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= Content-Type: text/plain; charset="UTF-8" On Thu, Jul 7, 2022 at 11:24 PM G.R. wrote: > > On Wed, Jul 6, 2022 at 2:33 PM Jan Beulich wrote: > > > > > Should I expect a debug build of XEN hypervisor to give better > > > diagnose messages, without the debug patch that Roger mentioned? > > > > Well, "expect" is perhaps too much to say, but with problems like > > yours (and even more so with multiple ones) using a debug > > hypervisor (or kernel, if there such a build mode existed) is imo > > always a good idea. As is using as up-to-date a version as > > possible. > > I built both 4.14.3 debug version and 4.16.1 release version for > testing purposes. > Unfortunately they gave me absolutely zero information, since both of > them are not able to get through issue #1 > the FlR related DPC / AER issue. > With 4.16.1 release, it actually can survive the 'xl > pci-assignable-add' which triggers the first AER failure. > But the 'xl pci-assignable-remove' will lead to xl segmentation fault... > >[ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] > >[ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 > Since I'll need a couple of pci-assignable-add && > pci-assignable-remove to get to a seemingly normal state, I cannot > proceed from here. > > With 4.14.3 debug build, the hypervisor / dom0 reboots on 'xl > pci-assignable-add'. > > [ 574.623143] pciback 0000:05:00.0: xen_pciback: resetting (FLR, D3, > etc) the device > [ 574.623203] pcieport 0000:00:1d.0: DPC: containment event, > status:0x1f11 source:0x0000 > [ 574.623204] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected > [ 574.623209] pcieport 0000:00:1d.0: PCIe Bus Error: > severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver > ID) > [ 574.623240] pcieport 0000:00:1d.0: device [8086:a330] error > status/mask=00200000/00010000 > [ 574.623261] pcieport 0000:00:1d.0: [21] ACSViol (First) > [ 575.855026] pciback 0000:05:00.0: not ready 1023ms after FLR; waiting > [ 576.895015] pciback 0000:05:00.0: not ready 2047ms after FLR; waiting > [ 579.028311] pciback 0000:05:00.0: not ready 4095ms after FLR; waiting > [ 583.294910] pciback 0000:05:00.0: not ready 8191ms after FLR; waiting > [ 591.614965] pciback 0000:05:00.0: not ready 16383ms after FLR; waiting > [ 609.534502] pciback 0000:05:00.0: not ready 32767ms after FLR; waiting > [ 643.667069] pciback 0000:05:00.0: not ready 65535ms after FLR; giving up > //<=======The reboot happens somewhere here, not immediately, but > after a while... > //Maybe I can get something from xl dmesg if I was quick enough and > have connected from a second terminal... Unfortunately I didn't see anything from xl dmesg... I wish the 'xl dmesg' can support the follow mode (dmesg -w) that the Linux dmesg does. Here I have to manually repeat this command. The machine suddenly freezes after the 'giving up' message is out. I see nothing special in the log. Maybe I'm just not lucky enough to catch the output, not sure. From xen-devel-bounces@lists.xenproject.org Thu Jul 07 16:10:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 16:10:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363075.593410 (Exim 4.92) (envelope-from ) id 1o9U4w-0005hx-Vh; Thu, 07 Jul 2022 16:10:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363075.593410; Thu, 07 Jul 2022 16:10:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U4w-0005hq-Ru; Thu, 07 Jul 2022 16:10:10 +0000 Received: by outflank-mailman (input) for mailman id 363075; Thu, 07 Jul 2022 16:10:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U4v-0005hk-QS for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 16:10:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2081.outbound.protection.outlook.com [40.107.20.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43ad54bf-fe0f-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 18:10:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6160.eurprd04.prod.outlook.com (2603:10a6:803:fd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 16:10:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 16:10:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43ad54bf-fe0f-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ju8xy0RaFU2it4hpw2PkzNtS7igfirSYZSypNMeZRpmrMfIEIYqKx2bpUHKjc9Dv43uZsd4oyoHz+RCbDgbKKtqYiEc7pz5qk7ZBOA96pYJbEe1x+IP1JqBAOu5Fq+QA4HvCt0/ELp2ULCUkgCBNpZFcnrAGv2GktmPtRC87QaMc/wswXRZR+4n0SEnuxjn8Gsbhra5NKdGlNv0orDH4yVNgAocl37+hBOk5f+rGj9cKgBHaZ6anEakgfUHEmTvSuQAU6lsgHt2SfOC5llSyXVZ7YJpkmWhPwDyb/8de4h6B5O+JEkNy6ielQh+/ZS83cBMeLhtDiDFozv2IXuWnCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cHdlAz9eLtojN7BtpV3/c6vn67r/TQTAApEvmtC9hRg=; b=VnLe6QndA2S2w+3Ue2loKmJWilJ8hSH8CIwwxT/0JghviBAhf8JrDCDtgshNfTtYYcF8RjCVclZ/xiKwkdZsfvyEPXEgre6iSMiBgQsWETzagT8bZfrSdkMzKJFiBcSJ9+iDf+pLrM62peVZKTDuQ87Mx3rtcvGCrXID+GymhR/CDPA0f7g3h3+7CUQ/ak0xYWYZb/mX2Tyor4X2H9v5lx0kScaoaC5GXWGInAG20DU41Wff2nc7vBaqLW+pT0Dy1n8bZPIEpCAA7nkNrnJgQOXgdpJmCu0bbdjALTycWUqTAZGH+st1B5kVSXXeOcFQDihFUezTyc2Gui2nzadnew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cHdlAz9eLtojN7BtpV3/c6vn67r/TQTAApEvmtC9hRg=; b=mDoVhAiDoYuCvIVp5xGNTRmPrlVYgKGpBBz8VpRfy/lZcCF45j4DqQE+ZGz7dD2nOjw2e46ns6zeS/nb/uTwV6vBA3XiKtEqIBkT9QM5lKPBLR/hqRW+L//8Zxk3OqWQUUd5dBfR4xLMOq6t8Crn1sSXjUrsjjuO0mHhXvSJW6UaUp+G3mvpxKOt55wNxcmtPNugiCrT/YYxAKiKFg01siZnJcVFOScTZGknpgRRhMM3zP8L35XUUVrYJ9M+zfj1OaX9bOrKiU7cknBX3OExpKNRyXUc95EgEImsWsDqHc5bCO/tVdhdduhDwui7vg7olXXaNb0J5Uf0v69rAKsQ5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <11bc7bb6-d08b-acd6-7f5a-28b9f8c394ff@suse.com> Date: Thu, 7 Jul 2022 18:10:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: ***PING***: [PATCH v6 0/9] xen: drop hypercall function tables Content-Language: en-US To: Andrew Cooper Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Christopher Clark , Dario Faggioli , Daniel De Graaf , "Daniel P. Smith" , xen-devel@lists.xenproject.org, Juergen Gross References: <20220324140139.5899-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220324140139.5899-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bc9c9bd-1a28-4851-9878-08da603325a3 X-MS-TrafficTypeDiagnostic: VI1PR04MB6160:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IQSwbsmjkmLPKqWqk8Ih7eREDYdQMdWlNoLBsSREAolUthAE5VNVUcnngQc4RplUtRTqL2Zh3BFvff838KMWFXzCoJGBqWHmEmKTI0k6Sw0y1ZNZc6PIPx0eDja9gU7f7mbzZPBA9MC+V8M3MjoWUTq+sOD+XZZUTU0tg4KkCfPIomC3glZ/8rKnRRuRjROGQTVCfsdboIPiXaAMscA0khyYnBllQLbYhrkZaz0AAtYx7XttXHmErxir0SXQpCXxCVnZeYE47u1iEk2TY6s/iiF5PfcwKZgu6DjgEOpcLo5QQ6K8F672I8lEAEx41QgJHH56BL3MBRctoOle5Lhp5JIvixxSH+jNYXQqtPzQTT+Xe1se+LImarKO2Fkg9BSNTuE5OfgqLTMLn4F8B+mUGTuyTPkP01mmL92A2CuaDmeUHMUkInjz/QRYt2NRLwu6+s+Rn0cSD8l7XJV3/m5I11/kVzg5zSnyPOV0NQhiy+BTeucge4ypnB7qq1SkLl/IeL/KTcNCcmngehMJxjWusvd5GkcYuRg6g0XOfGnTVHVBRMSKM8t1brCO0GQ5RWXsBStGd1ClT4jmv93Gb7gQo13VwHS7W4Bmzz9Etomq04z6QcfSfeMZk/0CcRcnj4VgqSYCrSKU3Kz3BQtMH+158FrhDVgtPBRERTxhT0CCsssyGqHswXr0deagyaqa2TfKmaL3nzgwbpOwL15IYWCLjeEHaKGZ4GcEJf8yp5L6n36dZ+qvSSvqp3McEQK3MucxzuL7u2zW57rOAm8njHjeGv5c/aUzYiZaxYCliakNLx0MliXzCXANL3ohFqC9Tpt1EFKSTUTv2wcR0j5P8t73JQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(396003)(39860400002)(376002)(346002)(31686004)(38100700002)(31696002)(54906003)(2906002)(6916009)(6506007)(316002)(41300700001)(86362001)(66946007)(53546011)(66556008)(186003)(66476007)(8676002)(4326008)(26005)(107886003)(36756003)(7416002)(5660300002)(6512007)(2616005)(8936002)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1BOVHU0N1F5dDQrRDJ2WUtLQ2l6RTI3QURRSUk1VTR0T0tDcngrY0ZTS3h0?= =?utf-8?B?QzRZRFUzeVZpd2pWNjVjazZDTGZLOWVIYjh1ME9Cb0p4RitoNnVjaTdWVGNI?= =?utf-8?B?UFdlQ2krRmc4Q1NqVmF0SjN5ck9FK09MeUhMdGhrRkIveHZBTTNjc0pGdm4w?= =?utf-8?B?aGlCOEFKN2Fvc0hRSWlSejVDZmU4Lys2ZUxJU3pFU20rRGl4WHBQczlITE42?= =?utf-8?B?T291YXdZVEpLUERUYlRadXVCZTRxdkcwOUdFdDExTERCanBPZUdHTGpia3li?= =?utf-8?B?elNhUjU1NU5KVVh2bUlPOC80M092WHUrY1V1M2M1ZUtISjE5R3JmSGFuc2p6?= =?utf-8?B?eU1nbEhLWVUrRFc0L2RMSGNIalorMDF4RUY1VFdzQmtVTGoxZ0g4NzdKYS9r?= =?utf-8?B?bTZUQkxBc2xxeFdEa0g4NVhPWGMwTmh1Q1RrcVBCTGdaZTBld2JjcitISWcw?= =?utf-8?B?aFNTYzRyamUvcGI1a25UNEx1K1dlM0p5bVFzMS9mUU5BZWV1cGlTREZJNmEy?= =?utf-8?B?YzJQRTR1YlduT2dzZ0RDOXNNd3VDaFNzVjVZcVIrM2dYWnF3VUY3cERBWjEr?= =?utf-8?B?QklaR0NrVDAxVWs0NVMweGt3NXRvNzdVYzRJS3cwZldaVmhxbGVxdkJURU5m?= =?utf-8?B?bGp4YTB3QWo3S25BWE5rTXRpZVZHb1hFL2NlN29pb1FBTDd1YWZ4elJZMkdR?= =?utf-8?B?NnplMWQxNjR4WExkUDdMWFN4YTlTRm9EZkE4WDJXVVZBYThMQXJvaGRyU3pF?= =?utf-8?B?OGt0YTZyWXlvbkxqMTdHSUEvcFBxSm1VRVNPa2JLdGUxWlI2TExZQktNamJY?= =?utf-8?B?MTg2dTh1SmUxSzRsU2xrb1c3VXQ3OWRkMzVUWkg2aTIzS000aytRdG8zTW1R?= =?utf-8?B?UkZVV3hrcmY5K2x0RHEvdFBUSVVqOEVoWnU4ZjlTZllRQnZOZWFCVUtFOUts?= =?utf-8?B?YVBTVVZwN1FCMU43cmRKdmJVZ05jTk5LR3htek8rOFhZSjl5UGY5ZFVKMW00?= =?utf-8?B?L3AwdmJ2aTc1ZlI4ZWdPb0pxZVNYbEE3Qk1JczRFZ1lKRHc4Zy9lMGF6U0V2?= =?utf-8?B?a2lKc3VvVkxOVnEwbVFMWHh6R21JNGZhUlRaRWVkQzlXdHBSYjNHVlMyQytI?= =?utf-8?B?YVRoYjNtQ3dVKzJXQTRiNllDV0N3bnhtaWFKcGxzTm5NMWQ0L2NWRnI3MHlF?= =?utf-8?B?S2F6OS9SLzB5NzF4blJvcGxZNHh3WXRtdHFsTE1YTnlEUGlKSkFxQ1VtWUdF?= =?utf-8?B?R2hxblUwSXVvbVB4NnBqTmxVTlFaUGxla0lVeE5iRzRsU1NtQXpjdnI2aEtG?= =?utf-8?B?VEU4azRGb3BBU01sZCtrWm1UamxkRlhvNjhRaWh6NDFNdVVwQjFzbFdiVkc4?= =?utf-8?B?QVpFU08yU0hWU1R2MEZIM1dqQUZkK0VYTFZyYURjV3ZodnlHQTVGZkR4ODF2?= =?utf-8?B?YlliOE5hMWs2SjJ5UnhTanE0SUVNU1pCS01JK1cwMjdEMmhEL2oxV3MzYTF4?= =?utf-8?B?UE41dzkwRmptMWg2MFFuRjNJQ3JVQXhnRnhNRDl4UGZBZDVOUHAvcWJpL3d5?= =?utf-8?B?eks4eVpTTHdqTFVoT2dZck1INzNzcTk3SklVRnJDdjhqNE1VQ3RPazdnQ3Za?= =?utf-8?B?RGxZMVc3K0RzblYwaUw5MnJqT3J4WVpieThadlpkNno4THNWWWdRVmFBUFlP?= =?utf-8?B?UVk1QlVXb2xUZEJwWSswaG8wcWQ0NDVhcCs0OFREelkzOE9saExMd2g4R3Yx?= =?utf-8?B?RkNDVy9qL3FOU3FsMFNqZ2k1MWh3YVI4d2RLcFNGd3ZYdk9EMWFUZVhEWEV3?= =?utf-8?B?UVhKNFU1VmFJSDAvMk52KzVmOXJscHk5ZU5RNW5ya09Kdm4rNjhHZFFTSm5m?= =?utf-8?B?emovVG9BRmM4WTRYR3ZTaWFMUUMrTzBQSERQRzZrRXNMSzVUcFh2bTA4bElZ?= =?utf-8?B?UFYzZ2pEbUphUmdrNVlvKy94d25pSzdwOEwwbkdJVnFoS0c2ZXJKV1N4Q2hw?= =?utf-8?B?ZGJlSTR2Z3Yvazh3ZHZ4SUpzQU5QZC90T282VXhnUnJkU3hSampQd1lPYldt?= =?utf-8?B?VVFhQy9zQU9RNytJVVBhUWIrVzhBU3lvZ1JsS3ZIRG1vbGZNN1FyazRQOHNX?= =?utf-8?Q?h4Tpapb46wynmKhAFDEWaljDh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bc9c9bd-1a28-4851-9878-08da603325a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:10:01.9142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M5VkrsRnBHeASxZCcZd6mkRqhxn+7qbW70WtQ2XWs4mCNaIILyzkYIai301j/RQQYVvas+4+OLcXhWEDz9UfqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6160 Andrew, On 24.03.2022 15:01, Juergen Gross wrote: > Juergen Gross (9): > xen: move do_vcpu_op() to arch specific code > xen: harmonize return types of hypercall handlers > xen: don't include asm/hypercall.h from C sources > xen: include compat/platform.h from hypercall.h > xen: generate hypercall interface related code > xen: use generated prototypes for hypercall handlers > xen/x86: call hypercall handlers via generated macro > xen/arm: call hypercall handlers via generated macro > xen/x86: remove cf_check attribute from hypercall handlers we've discussed the state of this on the Community Call today. Unfortunately you weren't there. It was common consensus that we've waited long enough here, so unless very good reasons (including a timeline) appear very quickly, the plan is to commit the series (with REST acks to stand in for the few small areas were acks are still missing) early next week. Should performance issues really turn out excessively bad, we can still consider reverting down the road; I don't expect we would want to go that route though, and rather make incremental adjustments as necessary. Thanks for your understanding, Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 16:12:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 16:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363081.593421 (Exim 4.92) (envelope-from ) id 1o9U7b-0006Nx-FK; Thu, 07 Jul 2022 16:12:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363081.593421; Thu, 07 Jul 2022 16:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U7b-0006Nq-CU; Thu, 07 Jul 2022 16:12:55 +0000 Received: by outflank-mailman (input) for mailman id 363081; Thu, 07 Jul 2022 16:12:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U7Z-0006Nh-K6 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 16:12:53 +0000 Received: from mail-vs1-xe32.google.com (mail-vs1-xe32.google.com [2607:f8b0:4864:20::e32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a66c6648-fe0f-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 18:12:51 +0200 (CEST) Received: by mail-vs1-xe32.google.com with SMTP id f68so3914951vsc.11 for ; Thu, 07 Jul 2022 09:12:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a66c6648-fe0f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+hl2y3nIKg9E38P3WPe0QYRYh0hjH4w/nrEmwtwMELY=; b=Mbd3GePKjVYC5pfVsfSaV+6mE/huX9VXzEMk0wkC1drelY3DiQTiPpMx9JzBNxKmT/ t83ycZINtnnr2qX/bahAz60qjOt2ymTDubWPQe39IyNGq0w3P98d6wOzcB/IjjbwPDIO NNEDFGdbioKeT2N8e3CujiCvpcgeq6PlHLlBGbKRhquRSya3MsNntnGp1DyMCkX9IZMx 6jBsVrE27oirdKsykJ/TZmmE7yj1XX92yZ8FiujhOTk+kGt1a5rDRqNGvL7PygsOwPwr H7viJjiPTGrQXYBLv3xAo1Fgd5ajxNnceensohsCrh20DNsagj+UZOfHBvqIlRDTbhbr ZjcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+hl2y3nIKg9E38P3WPe0QYRYh0hjH4w/nrEmwtwMELY=; b=SwVHpd1DpWRwALSvlzoRn5RdFY6rgL5XM333sXHjRLRu9DfVjKXYKys249s0IvzhV2 SZUsKFNjMteXZk4ezNssCeVXvhk7eoHamlOVFz4GHQv+Koa3AkqoE0/n+RyOgNLTRzVB mTaxaGAKWHKOGHh45HXa1CHPeawthcbhzEU+IfeWKO08mLvglr4ouwEnRnKiTTnv4E77 RNfC2EMXhpw89Zx0EkoaPaPyiTXverjvWhKVqmZmPBBGAbSkKjVdKddg8pgyx8KokL5W XskpdaUk/hVWjwjwGHkzu8r+teWNI4e2Puc4Xz0mF/MCGcf3x99QkPm7ojQNrV3lJjKP D46w== X-Gm-Message-State: AJIora85nx5U2CvlCWI7D02iDv4EFB1Q9QUC5c+ukJ4rFu7FCFVCEFkw cG+yXuig1CL/0FbZLMMvSp0uzzLMgPSOAXum5Hc= X-Google-Smtp-Source: AGRyM1sPrHgUNOxU2l14bWxadM5Z99V0PmZnLtp3VzSzNKa7Bzo2NIW+Hr8F4PhxCOHLtvlxTSTiEZkABs7iipbi1EI= X-Received: by 2002:a67:e1d0:0:b0:357:2e3d:cd9 with SMTP id p16-20020a67e1d0000000b003572e3d0cd9mr1531611vsl.0.1657210370457; Thu, 07 Jul 2022 09:12:50 -0700 (PDT) MIME-Version: 1.0 References: <20220324140139.5899-1-jgross@suse.com> <20220324140139.5899-3-jgross@suse.com> <5d7de637-3f7a-3e71-5dcf-cbeb1fa08b7b@suse.com> In-Reply-To: From: Christopher Clark Date: Thu, 7 Jul 2022 09:12:39 -0700 Message-ID: Subject: Re: [PATCH v6 2/9] xen: harmonize return types of hypercall handlers To: Juergen Gross Cc: xen-devel , Andrew Cooper , Jan Beulich , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Wed, Jul 6, 2022 at 12:22 PM Christopher Clark wrote: > > On Tue, Jun 28, 2022 at 11:24 PM Juergen Gross wrote: > > > > On 24.03.22 15:01, Juergen Gross wrote: > > > Today most hypercall handlers have a return type of long, while the > > > compat ones return an int. There are a few exceptions from that rule, > > > however. > > > > > > Get rid of the exceptions by letting compat handlers always return int > > > and others always return long, with the exception of the Arm specific > > > physdev_op handler. > > > > > > For the compat hvm case use eax instead of rax for the stored result as > > > it should have been from the beginning. > > > > > > Additionally move some prototypes to include/asm-x86/hypercall.h > > > as they are x86 specific. Move the compat_platform_op() prototype to > > > the common header. > > > > > > Rename paging_domctl_continuation() to do_paging_domctl_cont() and add > > > a matching define for the associated hypercall. > > > > > > Make do_callback_op() and compat_callback_op() more similar by adding > > > the const attribute to compat_callback_op()'s 2nd parameter. > > > > > > Change the type of the cmd parameter for [do|compat]_kexec_op() to > > > unsigned int, as this is more appropriate for the compat case. > > > > > > Signed-off-by: Juergen Gross > > > Reviewed-by: Jan Beulich > > > > Could I please have some feedback regarding the kexec and argo changes? > > Thanks for the ping on this and apologies for the delay. The > Argo-related changes in this patch look ok, and I have built and > tested Argo functionality with this patch applied with PV 32 and 64 > bit guests, using XTF -- with successful results for the patch -- but > I am behind on exercising it on a system that can run HVM guests, > sorry. Given the HVM-related change described in the description of > the patch, I think that such a test is needed and I am working on > getting a build and a system installed to get that done. As discussed on the Xen Community Call today, for the Argo changes: Reviewed-by: Christopher Clark and tested for 32 and 64-bit PV guests on x86. thanks, Christopher > > Christopher > > > > > > > Juergen > > > > > --- > > > V2: > > > - rework platform_op compat handling (Jan Beulich) > > > V3: > > > - remove include of types.h (Jan Beulich) > > > V4: > > > - don't move do_physdev_op() (Julien Grall) > > > - carve out non style compliant parameter replacements (Julien Grall) > > > V6: > > > - remove rebase artifact (Jan Beulich) > > > --- > > > xen/arch/x86/domctl.c | 4 ++-- > > > xen/arch/x86/hvm/hypercall.c | 8 ++----- > > > xen/arch/x86/hypercall.c | 2 +- > > > xen/arch/x86/include/asm/hypercall.h | 31 ++++++++++++++-------------- > > > xen/arch/x86/include/asm/paging.h | 3 --- > > > xen/arch/x86/mm/paging.c | 3 ++- > > > xen/arch/x86/pv/callback.c | 14 ++++++------- > > > xen/arch/x86/pv/emul-priv-op.c | 2 +- > > > xen/arch/x86/pv/hypercall.c | 5 +---- > > > xen/arch/x86/pv/iret.c | 4 ++-- > > > xen/arch/x86/pv/misc-hypercalls.c | 14 ++++++++----- > > > xen/common/argo.c | 6 +++--- > > > xen/common/kexec.c | 6 +++--- > > > xen/include/xen/hypercall.h | 20 ++++++++---------- > > > 14 files changed, 58 insertions(+), 64 deletions(-) > > > > > > diff --git a/xen/arch/x86/domctl.c b/xen/arch/x86/domctl.c > > > index e49f9e91b9..ea7d60ffb6 100644 > > > --- a/xen/arch/x86/domctl.c > > > +++ b/xen/arch/x86/domctl.c > > > @@ -221,8 +221,8 @@ long arch_do_domctl( > > > case XEN_DOMCTL_shadow_op: > > > ret = paging_domctl(d, &domctl->u.shadow_op, u_domctl, 0); > > > if ( ret == -ERESTART ) > > > - return hypercall_create_continuation(__HYPERVISOR_arch_1, > > > - "h", u_domctl); > > > + return hypercall_create_continuation( > > > + __HYPERVISOR_paging_domctl_cont, "h", u_domctl); > > > copyback = true; > > > break; > > > > > > diff --git a/xen/arch/x86/hvm/hypercall.c b/xen/arch/x86/hvm/hypercall.c > > > index 62b5349e7d..3a35543997 100644 > > > --- a/xen/arch/x86/hvm/hypercall.c > > > +++ b/xen/arch/x86/hvm/hypercall.c > > > @@ -124,8 +124,6 @@ static long cf_check hvm_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg) > > > [ __HYPERVISOR_ ## x ] = { (hypercall_fn_t *) do_ ## x, \ > > > (hypercall_fn_t *) compat_ ## x } > > > > > > -#define do_arch_1 paging_domctl_continuation > > > - > > > static const struct { > > > hypercall_fn_t *native, *compat; > > > } hvm_hypercall_table[] = { > > > @@ -158,11 +156,9 @@ static const struct { > > > #ifdef CONFIG_HYPFS > > > HYPERCALL(hypfs_op), > > > #endif > > > - HYPERCALL(arch_1) > > > + HYPERCALL(paging_domctl_cont) > > > }; > > > > > > -#undef do_arch_1 > > > - > > > #undef HYPERCALL > > > #undef HVM_CALL > > > #undef COMPAT_CALL > > > @@ -300,7 +296,7 @@ int hvm_hypercall(struct cpu_user_regs *regs) > > > #endif > > > > > > curr->hcall_compat = true; > > > - regs->rax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi); > > > + regs->eax = hvm_hypercall_table[eax].compat(ebx, ecx, edx, esi, edi); > > > curr->hcall_compat = false; > > > > > > #ifndef NDEBUG > > > diff --git a/xen/arch/x86/hypercall.c b/xen/arch/x86/hypercall.c > > > index 2370d31d3f..07e1a45ef5 100644 > > > --- a/xen/arch/x86/hypercall.c > > > +++ b/xen/arch/x86/hypercall.c > > > @@ -75,7 +75,7 @@ const hypercall_args_t hypercall_args_table[NR_hypercalls] = > > > ARGS(dm_op, 3), > > > ARGS(hypfs_op, 5), > > > ARGS(mca, 1), > > > - ARGS(arch_1, 1), > > > + ARGS(paging_domctl_cont, 1), > > > }; > > > > > > #undef COMP > > > diff --git a/xen/arch/x86/include/asm/hypercall.h b/xen/arch/x86/include/asm/hypercall.h > > > index d6daa7e4cb..49973820af 100644 > > > --- a/xen/arch/x86/include/asm/hypercall.h > > > +++ b/xen/arch/x86/include/asm/hypercall.h > > > @@ -11,6 +11,8 @@ > > > #include /* for do_mca */ > > > #include > > > > > > +#define __HYPERVISOR_paging_domctl_cont __HYPERVISOR_arch_1 > > > + > > > typedef unsigned long hypercall_fn_t( > > > unsigned long, unsigned long, unsigned long, > > > unsigned long, unsigned long); > > > @@ -80,7 +82,7 @@ do_set_debugreg( > > > int reg, > > > unsigned long value); > > > > > > -extern unsigned long cf_check > > > +extern long cf_check > > > do_get_debugreg( > > > int reg); > > > > > > @@ -118,7 +120,7 @@ do_mmuext_op( > > > extern long cf_check do_callback_op( > > > int cmd, XEN_GUEST_HANDLE_PARAM(const_void) arg); > > > > > > -extern unsigned long cf_check > > > +extern long cf_check > > > do_iret( > > > void); > > > > > > @@ -133,17 +135,20 @@ do_set_segment_base( > > > unsigned int which, > > > unsigned long base); > > > > > > +long cf_check do_nmi_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > > + > > > +long cf_check do_xenpmu_op(unsigned int op, > > > + XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg); > > > + > > > +long cf_check do_paging_domctl_cont( > > > + XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl); > > > + > > > #ifdef CONFIG_COMPAT > > > > > > #include > > > #include > > > #include > > > > > > -extern int cf_check > > > -compat_physdev_op( > > > - int cmd, > > > - XEN_GUEST_HANDLE_PARAM(void) arg); > > > - > > > extern int > > > compat_common_vcpu_op( > > > int cmd, struct vcpu *v, XEN_GUEST_HANDLE_PARAM(void) arg); > > > @@ -154,12 +159,8 @@ extern int cf_check compat_mmuext_op( > > > XEN_GUEST_HANDLE_PARAM(uint) pdone, > > > unsigned int foreigndom); > > > > > > -DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t); > > > -extern int cf_check compat_platform_op( > > > - XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op); > > > - > > > -extern long cf_check compat_callback_op( > > > - int cmd, XEN_GUEST_HANDLE(void) arg); > > > +extern int cf_check compat_callback_op( > > > + int cmd, XEN_GUEST_HANDLE(const_void) arg); > > > > > > extern int cf_check compat_update_va_mapping( > > > unsigned int va, uint32_t lo, uint32_t hi, unsigned int flags); > > > @@ -177,12 +178,12 @@ extern int cf_check compat_set_gdt( > > > extern int cf_check compat_update_descriptor( > > > uint32_t pa_lo, uint32_t pa_hi, uint32_t desc_lo, uint32_t desc_hi); > > > > > > -extern unsigned int cf_check compat_iret(void); > > > +extern int cf_check compat_iret(void); > > > > > > extern int cf_check compat_nmi_op( > > > unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > > > > > -extern long cf_check compat_set_callbacks( > > > +extern int cf_check compat_set_callbacks( > > > unsigned long event_selector, unsigned long event_address, > > > unsigned long failsafe_selector, unsigned long failsafe_address); > > > > > > diff --git a/xen/arch/x86/include/asm/paging.h b/xen/arch/x86/include/asm/paging.h > > > index f0b4efc66e..54c440be65 100644 > > > --- a/xen/arch/x86/include/asm/paging.h > > > +++ b/xen/arch/x86/include/asm/paging.h > > > @@ -234,9 +234,6 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl, > > > bool_t resuming); > > > > > > -/* Helper hypercall for dealing with continuations. */ > > > -long cf_check paging_domctl_continuation(XEN_GUEST_HANDLE_PARAM(xen_domctl_t)); > > > - > > > /* Call when destroying a vcpu/domain */ > > > void paging_vcpu_teardown(struct vcpu *v); > > > int paging_teardown(struct domain *d); > > > diff --git a/xen/arch/x86/mm/paging.c b/xen/arch/x86/mm/paging.c > > > index 1f0b94ad21..a7e2707ecc 100644 > > > --- a/xen/arch/x86/mm/paging.c > > > +++ b/xen/arch/x86/mm/paging.c > > > @@ -21,6 +21,7 @@ > > > > > > #include > > > #include > > > +#include > > > #include > > > #include > > > #include > > > @@ -759,7 +760,7 @@ int paging_domctl(struct domain *d, struct xen_domctl_shadow_op *sc, > > > return shadow_domctl(d, sc, u_domctl); > > > } > > > > > > -long cf_check paging_domctl_continuation( > > > +long cf_check do_paging_domctl_cont( > > > XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl) > > > { > > > struct xen_domctl op; > > > diff --git a/xen/arch/x86/pv/callback.c b/xen/arch/x86/pv/callback.c > > > index 55148c7f9e..1be9d3f731 100644 > > > --- a/xen/arch/x86/pv/callback.c > > > +++ b/xen/arch/x86/pv/callback.c > > > @@ -207,9 +207,9 @@ long cf_check do_set_callbacks( > > > #include > > > #include > > > > > > -static long compat_register_guest_callback(struct compat_callback_register *reg) > > > +static int compat_register_guest_callback(struct compat_callback_register *reg) > > > { > > > - long ret = 0; > > > + int ret = 0; > > > struct vcpu *curr = current; > > > > > > fixup_guest_code_selector(curr->domain, reg->address.cs); > > > @@ -256,10 +256,10 @@ static long compat_register_guest_callback(struct compat_callback_register *reg) > > > return ret; > > > } > > > > > > -static long compat_unregister_guest_callback( > > > +static int compat_unregister_guest_callback( > > > struct compat_callback_unregister *unreg) > > > { > > > - long ret; > > > + int ret; > > > > > > switch ( unreg->type ) > > > { > > > @@ -283,9 +283,9 @@ static long compat_unregister_guest_callback( > > > return ret; > > > } > > > > > > -long cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg) > > > +int cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(const_void) arg) > > > { > > > - long ret; > > > + int ret; > > > > > > switch ( cmd ) > > > { > > > @@ -321,7 +321,7 @@ long cf_check compat_callback_op(int cmd, XEN_GUEST_HANDLE(void) arg) > > > return ret; > > > } > > > > > > -long cf_check compat_set_callbacks( > > > +int cf_check compat_set_callbacks( > > > unsigned long event_selector, unsigned long event_address, > > > unsigned long failsafe_selector, unsigned long failsafe_address) > > > { > > > diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c > > > index 22b10dec2a..5da00e24e4 100644 > > > --- a/xen/arch/x86/pv/emul-priv-op.c > > > +++ b/xen/arch/x86/pv/emul-priv-op.c > > > @@ -22,13 +22,13 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > #include > > > #include > > > #include > > > #include > > > -#include > > > #include > > > #include > > > #include > > > diff --git a/xen/arch/x86/pv/hypercall.c b/xen/arch/x86/pv/hypercall.c > > > index e8fbee7bbb..fe8dfe9e8f 100644 > > > --- a/xen/arch/x86/pv/hypercall.c > > > +++ b/xen/arch/x86/pv/hypercall.c > > > @@ -47,8 +47,6 @@ typedef struct { > > > #define COMPAT_CALL(x) HYPERCALL(x) > > > #endif > > > > > > -#define do_arch_1 paging_domctl_continuation > > > - > > > static const pv_hypercall_table_t pv_hypercall_table[] = { > > > COMPAT_CALL(set_trap_table), > > > HYPERCALL(mmu_update), > > > @@ -109,11 +107,10 @@ static const pv_hypercall_table_t pv_hypercall_table[] = { > > > #endif > > > HYPERCALL(mca), > > > #ifndef CONFIG_PV_SHIM_EXCLUSIVE > > > - HYPERCALL(arch_1), > > > + HYPERCALL(paging_domctl_cont), > > > #endif > > > }; > > > > > > -#undef do_arch_1 > > > #undef COMPAT_CALL > > > #undef HYPERCALL > > > > > > diff --git a/xen/arch/x86/pv/iret.c b/xen/arch/x86/pv/iret.c > > > index dd2965d8f0..55eb6a63bd 100644 > > > --- a/xen/arch/x86/pv/iret.c > > > +++ b/xen/arch/x86/pv/iret.c > > > @@ -48,7 +48,7 @@ static void async_exception_cleanup(struct vcpu *curr) > > > curr->arch.async_exception_state(trap).old_mask; > > > } > > > > > > -unsigned long cf_check do_iret(void) > > > +long cf_check do_iret(void) > > > { > > > struct cpu_user_regs *regs = guest_cpu_user_regs(); > > > struct iret_context iret_saved; > > > @@ -105,7 +105,7 @@ unsigned long cf_check do_iret(void) > > > } > > > > > > #ifdef CONFIG_PV32 > > > -unsigned int cf_check compat_iret(void) > > > +int cf_check compat_iret(void) > > > { > > > struct cpu_user_regs *regs = guest_cpu_user_regs(); > > > struct vcpu *v = current; > > > diff --git a/xen/arch/x86/pv/misc-hypercalls.c b/xen/arch/x86/pv/misc-hypercalls.c > > > index 5649aaab44..635f5a644a 100644 > > > --- a/xen/arch/x86/pv/misc-hypercalls.c > > > +++ b/xen/arch/x86/pv/misc-hypercalls.c > > > @@ -28,12 +28,16 @@ long cf_check do_set_debugreg(int reg, unsigned long value) > > > return set_debugreg(current, reg, value); > > > } > > > > > > -unsigned long cf_check do_get_debugreg(int reg) > > > +long cf_check do_get_debugreg(int reg) > > > { > > > - unsigned long val; > > > - int res = x86emul_read_dr(reg, &val, NULL); > > > - > > > - return res == X86EMUL_OKAY ? val : -ENODEV; > > > + /* Avoid implementation defined behavior casting unsigned long to long. */ > > > + union { > > > + unsigned long val; > > > + long ret; > > > + } u; > > > + int res = x86emul_read_dr(reg, &u.val, NULL); > > > + > > > + return res == X86EMUL_OKAY ? u.ret : -ENODEV; > > > } > > > > > > long cf_check do_fpu_taskswitch(int set) > > > diff --git a/xen/common/argo.c b/xen/common/argo.c > > > index 297f6d11f0..26a01c2188 100644 > > > --- a/xen/common/argo.c > > > +++ b/xen/common/argo.c > > > @@ -2207,13 +2207,13 @@ do_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > > } > > > > > > #ifdef CONFIG_COMPAT > > > -long cf_check > > > +int cf_check > > > compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > > XEN_GUEST_HANDLE_PARAM(void) arg2, unsigned long arg3, > > > unsigned long arg4) > > > { > > > struct domain *currd = current->domain; > > > - long rc; > > > + int rc; > > > xen_argo_send_addr_t send_addr; > > > xen_argo_iov_t iovs[XEN_ARGO_MAXIOV]; > > > compat_argo_iov_t compat_iovs[XEN_ARGO_MAXIOV]; > > > @@ -2267,7 +2267,7 @@ compat_argo_op(unsigned int cmd, XEN_GUEST_HANDLE_PARAM(void) arg1, > > > > > > rc = sendv(currd, &send_addr.src, &send_addr.dst, iovs, niov, arg4); > > > out: > > > - argo_dprintk("<-compat_argo_op(%u)=%ld\n", cmd, rc); > > > + argo_dprintk("<-compat_argo_op(%u)=%d\n", cmd, rc); > > > > > > return rc; > > > } > > > diff --git a/xen/common/kexec.c b/xen/common/kexec.c > > > index a2ffb6530c..41669964d2 100644 > > > --- a/xen/common/kexec.c > > > +++ b/xen/common/kexec.c > > > @@ -1213,7 +1213,7 @@ static int kexec_status(XEN_GUEST_HANDLE_PARAM(void) uarg) > > > return !!test_bit(bit, &kexec_flags); > > > } > > > > > > -static int do_kexec_op_internal(unsigned long op, > > > +static int do_kexec_op_internal(unsigned int op, > > > XEN_GUEST_HANDLE_PARAM(void) uarg, > > > bool_t compat) > > > { > > > @@ -1265,13 +1265,13 @@ static int do_kexec_op_internal(unsigned long op, > > > return ret; > > > } > > > > > > -long cf_check do_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > > +long cf_check do_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > > { > > > return do_kexec_op_internal(op, uarg, 0); > > > } > > > > > > #ifdef CONFIG_COMPAT > > > -int cf_check compat_kexec_op(unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > > +int cf_check compat_kexec_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg) > > > { > > > return do_kexec_op_internal(op, uarg, 1); > > > } > > > diff --git a/xen/include/xen/hypercall.h b/xen/include/xen/hypercall.h > > > index 81aae7a662..a032ba2b4a 100644 > > > --- a/xen/include/xen/hypercall.h > > > +++ b/xen/include/xen/hypercall.h > > > @@ -114,11 +114,6 @@ common_vcpu_op(int cmd, > > > struct vcpu *v, > > > XEN_GUEST_HANDLE_PARAM(void) arg); > > > > > > -extern long cf_check > > > -do_nmi_op( > > > - unsigned int cmd, > > > - XEN_GUEST_HANDLE_PARAM(void) arg); > > > - > > > extern long cf_check > > > do_hvm_op( > > > unsigned long op, > > > @@ -126,7 +121,7 @@ do_hvm_op( > > > > > > extern long cf_check > > > do_kexec_op( > > > - unsigned long op, > > > + unsigned int op, > > > XEN_GUEST_HANDLE_PARAM(void) uarg); > > > > > > extern long cf_check > > > @@ -145,9 +140,6 @@ extern long cf_check do_argo_op( > > > extern long cf_check > > > do_xenoprof_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg); > > > > > > -extern long cf_check > > > -do_xenpmu_op(unsigned int op, XEN_GUEST_HANDLE_PARAM(xen_pmu_params_t) arg); > > > - > > > extern long cf_check > > > do_dm_op( > > > domid_t domid, > > > @@ -205,15 +197,21 @@ extern int cf_check compat_xsm_op( > > > XEN_GUEST_HANDLE_PARAM(void) op); > > > > > > extern int cf_check compat_kexec_op( > > > - unsigned long op, XEN_GUEST_HANDLE_PARAM(void) uarg); > > > + unsigned int op, XEN_GUEST_HANDLE_PARAM(void) uarg); > > > > > > DEFINE_XEN_GUEST_HANDLE(multicall_entry_compat_t); > > > extern int cf_check compat_multicall( > > > XEN_GUEST_HANDLE_PARAM(multicall_entry_compat_t) call_list, > > > uint32_t nr_calls); > > > > > > +int compat_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) arg); > > > + > > > +typedef struct compat_platform_op compat_platform_op_t; > > > +DEFINE_XEN_GUEST_HANDLE(compat_platform_op_t); > > > +int compat_platform_op(XEN_GUEST_HANDLE_PARAM(compat_platform_op_t) u_xenpf_op); > > > + > > > #ifdef CONFIG_ARGO > > > -extern long cf_check compat_argo_op( > > > +extern int cf_check compat_argo_op( > > > unsigned int cmd, > > > XEN_GUEST_HANDLE_PARAM(void) arg1, > > > XEN_GUEST_HANDLE_PARAM(void) arg2, > > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 16:15:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 16:15:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363087.593433 (Exim 4.92) (envelope-from ) id 1o9U9V-0006yi-SH; Thu, 07 Jul 2022 16:14:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363087.593433; Thu, 07 Jul 2022 16:14:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U9V-0006yb-Pb; Thu, 07 Jul 2022 16:14:53 +0000 Received: by outflank-mailman (input) for mailman id 363087; Thu, 07 Jul 2022 16:14:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9U9U-0006yV-Qw for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 16:14:52 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60058.outbound.protection.outlook.com [40.107.6.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee1e2e16-fe0f-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 18:14:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5259.eurprd04.prod.outlook.com (2603:10a6:10:1b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Thu, 7 Jul 2022 16:14:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 16:14:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee1e2e16-fe0f-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PSIVuxJbJ3ylJBCB9QSrRIrmswjrOrAdqHFQaO0Mfe4FiqS1yc4HgFVJao1ls0wm9z1q8PE36ENzcbkQVjoLHYYup8xXujXZgNXv9iuq6huM2zbYXzg2bNFChmZgZlBZRrJ2nfEv6YJqZ/0gz1Wbj5DG3Au8xgw8dFY+S6KERRJQXxJBZrJ+CPHKsTFC6rt6ytpDI8CUihJlYVCY4/Szn8icJ4s8xtpKZbRwxFmdsJaVDHSWfIWNguqQV3riRFa9nJ7NrUJ5RbElcb35wXRdq8s/ZDfqNqTBdJqUWb5sgjjCv22OdQ9dyjlJWqCgBwwwSPKpQ714jsxf7APZhHKEoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JZ+xp+shX5rvZzJBLBCke+xj1fPXSAeGOTHFM4g1iFg=; b=TJFyILZTOEe3Z92l1LT2s/r5KRSDSQDn/YrUhYdoHLoSTL+Rsz26xYiiT2P8CotpEC27/2awhTT6F5Q4MAAF9Bqvo6wJFFWYJ0HIB1Jbiuf3ejz8Kr5XgHTN6c+TCVRzSZHKl7PPpRoPf1qqsq3i+0OAxKv5x0xJBuogULe3ZMGThU496VccGh/QDdRQmMzt/oi7TN/XIGiMKVgr8jyHwwTYJLXKxBohkNFeb68VNvN4kqn3LB4vUA3SXrwZJzX5jWdXrGLTcX+Ysorxe4E0f0ue8zysySEW2vF7P7SArI3O3ss0hH6uIrmKzbWOpTuj64KWLu1Cl+mVlSVJFdo2cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JZ+xp+shX5rvZzJBLBCke+xj1fPXSAeGOTHFM4g1iFg=; b=YDs525V8spDKx9d4LRRrkIRA9h+PTjEzdkXsHmad5/8wdVQOY+zyLxE46UKhPad4TQWdfU+u9vaGh6p9uXYgyf5MlIsw3+Z8n5plkBQ60A3LP12GKPRBKk9gIsGaunO0RmTc6rgf8XG4QLVIY+cTxW8I72LDXnVlpNWfiMTI6IcZ2A3W2gr4cfDnRT8UOwdXgBcSX46dfyKSJm+TJptxbwEnV0q0GY84zJVlDsSTYbTCVPXpU1F3RcsX+ZZ/WRECzaKh26qzGfiJ2cVxnJMnps2N3hQoLyU5ZKgWdn0cslZKbYS7qKAfqHf3aS9ylQ1f3EezW8XRKzRrTfev5bmpIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 7 Jul 2022 18:14:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: PING: [PATCH v6 0/3] amd/msr: implement MSR_VIRT_SPEC_CTRL for HVM guests Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Henry Wang , Community Manager , Roger Pau Monne , xen-devel@lists.xenproject.org References: <20220517153127.40276-1-roger.pau@citrix.com> From: Jan Beulich In-Reply-To: <20220517153127.40276-1-roger.pau@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24301e8d-6167-4238-1d67-08da6033d169 X-MS-TrafficTypeDiagnostic: DB7PR04MB5259:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mp9YSGjucwllNB61qz1RoZUQL7VwqlsmA2ubbeO+s3Om+BCZs2AB6samzXdaekRSjkKoka64FrumbLwYfig64yfnV2FLD4NRWSq7fvCFxUyfSlESZfdJ19+J1QKdazOO8KbrNO3EohpYYvsQNXA+kOlD5zWKBlOv2h+KeWxJEZGGF4ECjNwfpc3IYmrnz4qww9MlFzz3sSL2+zEsTi4eebXgsuhE3rOdGT+P9yAMW6nOBb154jx919+hFt5UFlkUVkamv42DTFEYyVjiNWnGrMLJWwYvOE1nFb8jvOyrwCoz2XQnoKesNgsQtZ30tkZwVXnG4aj1POELYCXfTk22dngVJWbLoOrMveh+QyQNqwi7V2kf7XavpotbxFilDwT0KJ4gegvnOXctcHmRM/QytqWZBf+Tl9prhhBIyan4/S/in0xVV96G58yxPe8ewe6x+urtQ8+76p4RsbPdeZtrkP7gkqxIuVHEDQFXCyy/Crz/RpgzKdLen16mcW7r9uRti+yWY5CBrlVR15LUQOYkPegI5eWKWj03lh9J8ZQsF4bH3duKovGoujtphNDmfkNtbXodEsnutpUlBi4MpUDMsF6XnANgCi+2EDw3Md87y3p0a2a4ZAHqJkG3ntUEptTHmiNFsWiEVD913gqlMDPPzGwRaAQ6QfqgGdPQ0gX1Tf65OOT03UnPYrxjMx1UmNHp6F/PFRDwKn7kQzdkLggXHd0S1+UpYLDz3WnAMq8Jv3U0wl1m7ihGjnggH6cOlUL4w8D+urg2LktYYREFgGTHvoOGD6PtE4sFmU60xATXk3Vhb0jFrIwj1YYB4dwGTjrmTip+tX0fSX16Q/2ARBEDSslmkwuj/F3l1aVuorAj8cc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(136003)(396003)(366004)(36756003)(6486002)(26005)(6506007)(2616005)(2906002)(53546011)(478600001)(186003)(6512007)(31686004)(38100700002)(8676002)(86362001)(66946007)(8936002)(5660300002)(41300700001)(54906003)(6916009)(316002)(66476007)(4326008)(31696002)(4744005)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2NIb2gxNExzYWl0TktVa2xadWgxZU8yWWhUeEVZVEhuZUtYbFY1eTJkcmc3?= =?utf-8?B?WkhyaTVYMmlpb1NUazR5eUVKR1ptdlhuSlNXcXBtOGY3VjEvV1RhZUtEdUV2?= =?utf-8?B?Z0srREw1czJLcFNIbjdqTXN6T3JsbDRyYlhaVDJwRVQ0c0huSFlycTFjeXFr?= =?utf-8?B?MjlMMWo1eDJXYjlaWExQNGlQdDM2bVhLei91c0g2bUYwd0FZNFFqTlN6TXZP?= =?utf-8?B?U1ZUUmJXdW10Ykd1VG9WUnJ5Q2xRMVVFNVBEMHhKekZIWXBMWlBQY2s1Y0hx?= =?utf-8?B?TEJlM2dPREMwckxhbnEvS1lJbWVJZWQrT1Nyc1VQSTRtc3VlTG51S29sdE9I?= =?utf-8?B?eDdwR0N1cWFhU0NRQjcyVi9teldIYU90NFNwOHdYR3JQNkYzekhMVWw0c3g1?= =?utf-8?B?bVZaZzdxOTZXSVNxYXl4MU9VTmZ6MExIU2wwak1zVVd4NjJJRWFUbzg3U3I0?= =?utf-8?B?dzJTd2EzbW9seVVlOG5veWxFTnMwMHNkZVp6WUtYaUFtNzRoSWVINjNwOHR5?= =?utf-8?B?NzNHWERoa3Y5UXovV042SlJGdXFINHpXaDdMNEhQK1JCREpnNWtoNDNoQ0Vw?= =?utf-8?B?ZEw0YlRmYng1VFdwQithQjU5SHB6TjBnUGt5TExOL1hpR0JEL0srbEJjbnBs?= =?utf-8?B?cVBPUm5hRTdUdDFYcFRUcTM3SFEvajRGR1RROUR3Z1JjRllwWWxkWmM2cnRW?= =?utf-8?B?Yjl6TDFHc3phSk5CS3FsdFoxVCsvVlRmeHhPbG1PWE4rVUpqc1VMaUhYbTNv?= =?utf-8?B?UkpMTkhUekhuNVV5cVJIUGkvYzNpbXF6cUtuaWNUQk8rQ3Y5dENFYjcrdkgx?= =?utf-8?B?ZU9rZFd0MUtmMkEvd1V3bWFkYXZnS1NvdmR4TU1RSzVPVzRBZ3lHMGxxQkt4?= =?utf-8?B?Ri9Ja2pNRDkyN0lFMFhSTjh6TldUT2s4Zk5rRnlvbmwwOVVCZEdrNkNTSi9Y?= =?utf-8?B?cHVTNlQ5aE1KL0lUZzVpRXY4VUwyU0R6Yk43cjc0N2M0WlVYbEZjYzI5Ly9M?= =?utf-8?B?MTUreGE2cmdsT1V0WU9rdEMyY2V3dUd0U3JLc0JGcTZwcERaK3IxZ1lNZU5P?= =?utf-8?B?NWJuQjNEeC83L2NtNjVFRkdYVE85b3VMcHBTTWlkQ3hpSVM4M2poOW9nTnJK?= =?utf-8?B?VjIxaGJMNVpuSDdGaFRmUkFYTFV3MjNaU0Y3YVVBVHJnazhsRzdtVDZIUEFG?= =?utf-8?B?dkRkVkJQU3pQZDhHdUVPZTVBaWJzSnhBa1d3WWFsRmNVUko0enFndWNyMll6?= =?utf-8?B?RWQ1Zmc4WlgzbkZXQUlTZlA2UzhxaERQUzZKdDhFYVgwWHlRSnNqelMrMTB2?= =?utf-8?B?ZU9MWm5kODNtMEpuMkErb2NGZGRneTYwN09md2RQTjRlQklzNkdlUWs1STRo?= =?utf-8?B?TnJNK0srK0dJNE94eUhlZHFlN0xzUmp2S0RabTM5Uk9kWmR1UzZVanllZEZk?= =?utf-8?B?cDFhQ0dHZ3dRbzFYaC9CQWFkeTI0UEdTeGcvbDR4ekkzRVpmNEwzdzdKN09u?= =?utf-8?B?VWRlc0xnMnQybkRyRTJIUHMxTG5mSXNoMEM5VEtvUVVFWTJRRGFhSG5TdXoz?= =?utf-8?B?bVVjbE9Ma0dhSTRwdEZzdTgrMEIzM1ZTT3Bxc25vVnlWcHZLU1FKU0NRUENW?= =?utf-8?B?dlFFQ1c4ZysyalloS1BuWGl3OHEvMjJlejNjN1NZc1Q4c2VicUtrQXJ6TTlI?= =?utf-8?B?dVBjMm5obEN3aVhjYWhKTEc0R3hncEJEa2g3U25qUkNhOW9pVE9YakMrTVR6?= =?utf-8?B?YjdXaGE4YmVWdkUyR3FUZ1V5OGtBRzIxdUozRHlXVFZqN29MZ0JPbjhhVGlk?= =?utf-8?B?TEpmVVNlWkNTM2Rndlprb1NGK0thRFlsY2Z2ZUNhQStBbmwwakQ4ZTRNak9t?= =?utf-8?B?Z0tIZ21rdGhETm9nQUV6WGIrRGM4YTZVdkJqcEdwVFZhbkI4QTZVeWFvakky?= =?utf-8?B?U0NNYzEyMHExOWpMSTcyRG5ScHhVUHQxREk4UFlRYXBVa2ozeVBmZ1Vta05x?= =?utf-8?B?endyQ3lvRTJqeXlPNTlYVjJJRnZoa0ZGSUZmNXR0eDJ3L0VZUC81TzBnYndz?= =?utf-8?B?cFM3NzNDUHdCYUl5QVBRbyt3ZzRQeTh1dlB0M2F6NjZOZEdidm5EWitjS1dw?= =?utf-8?Q?OsUf/p2mguVaUjbpEqvHOWtlG?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24301e8d-6167-4238-1d67-08da6033d169 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:14:50.0678 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M9cRw21klJ2KKsi6lgb5mgxuKifAXbozRZ7MflYgMLj5jjMmAYq07/gpVvJ7GpkNYJDBEcAffkpZbXQaSJUU3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5259 On 17.05.2022 17:31, Roger Pau Monne wrote: > Roger Pau Monne (3): > amd/msr: implement VIRT_SPEC_CTRL for HVM guests on top of SPEC_CTRL > amd/msr: allow passthrough of VIRT_SPEC_CTRL for HVM guests > amd/msr: implement VIRT_SPEC_CTRL for HVM guests using legacy SSBD While, somewhat different from Jürgen's series, here the delay is more voluntary (in that I had told Roger that I'd prefer to commit this only with your (perhaps informal) agreement, I think we also can't wait much longer. I'm willing to give it until the end of next week, so I guess I'd move forward with committing early the week after, unless I hear substantial arguments against doing so (at which point the two of us would likely need to decide who's going to pick up this work while Roger is away). Once again thanks for your understanding, Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 16:18:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 16:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363096.593444 (Exim 4.92) (envelope-from ) id 1o9UD6-0008CU-Fv; Thu, 07 Jul 2022 16:18:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363096.593444; Thu, 07 Jul 2022 16:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9UD6-0008CN-DF; Thu, 07 Jul 2022 16:18:36 +0000 Received: by outflank-mailman (input) for mailman id 363096; Thu, 07 Jul 2022 16:18:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9UD6-0008CH-0X for xen-devel@lists.xen.org; Thu, 07 Jul 2022 16:18:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 730f3e57-fe10-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 18:18:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5259.eurprd04.prod.outlook.com (2603:10a6:10:1b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Thu, 7 Jul 2022 16:18:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 16:18:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 730f3e57-fe10-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JInaqqVJxwHkQ9dkSf5PX+iYI1NLBX+YO9MteaEEESOzINLvw/kk/c322GQlAyLEhq/zoE0XvO1J3tdou84Osp9laf/N7aEFeG4uzrfmRT8MpICdpoS/reYb5TugVnikfRKq5XcQ6/BJuTzto9EwUtH0jSNC3tcMex7JzbFeHfe1M93c0ydtHhXAxkZoJ8f3OlUoDTzQBtMVtiv00upM/bM0/CJgct1D6JntxlnEnna3Du7a4mnu1mIIZCP+ADmcHwdekkR9M0ySuJtn+BT+lXXJLNalqsBF8T5PBemz1xYJkJU9fhDGoBZnwuzkreDnmLB0K52bUlWpSlhM8NKNdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vkBQYIncmfnZ6I7MvVd8YjOSYY1zkcjGVBb9JS5loRY=; b=RPaG+SEYyhlhq1FUJY6yI6r5mjUHNHlVKbumz61J4a31uHJUK8jvvh4NXhxfzFAkboSBtUaHPdoYAT5VIpVeEl0bB9ECzMihoDww1/lGz0MjNPHQ6vXs/ICB2QGycP0WbM1QaAIPl0HMjcgC0w7A6HGNoQgxKKjN9Q/7mJYFb/EH8NjXJvTWIGQW6dEOvIWIe3kHH+7TBrVbo/ObXphDAGrALHRPewXgcB3PtzFiofP0sIBH3sL/PpViQlf3gQ1tJmF91s+qFhl/7YYzwMDal4OVjfJwPpcQAlxBwPro/Oc6oXO6eac+OMOnOtvIJdy3SxGa2ctIAYcSMzz1DRoOFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vkBQYIncmfnZ6I7MvVd8YjOSYY1zkcjGVBb9JS5loRY=; b=kzowu6Mto8N8zWRVYnZtGMZzKyd+GIAHy+jZxZW1F6jv9RPK6T6VdMWHrtfS1QAHDNIJqjdSpLXhvQvKBrZeKlLF+mH2+mObEH/tka1GOCFTlEgEe0KzmASm73JfdhGipq9KdPV+W8L1WoaNDZKQf3VyEo+2aDrbCgegM+Q/m+M2GTUvINckN29c1a3Mr5oinGk6G1onHxueHtdtYpWrDING0e+HvArWihcWh11pArOzVMQn5zjbjS4fudyhQtRE04kxFkAOQ9a/5HJDEpTjLW4/vdu5n9DvZKjprUeYZ8JdrcV6DyZQt65zylq6/exkSxfFVhw5tXJXvXHBqCSqIQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <051bc3f1-c3d5-968e-7065-cae29bb5ca91@suse.com> Date: Thu, 7 Jul 2022 18:18:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e11c169-cab4-48f9-e480-08da6034526f X-MS-TrafficTypeDiagnostic: DB7PR04MB5259:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kLzcWNm5ACFZ+NhlkbdnefWX4+WAwhisx/v7JQBCDObhIH+HmbflVjiI35BvfnHfofA6y45W6NHkthPkNtHohj2pbKPZDq4RIK2cfZNGbnZl7IDrLSFUihyBxtQIeCzZkGhEBrKnfgjbWz+x2VClL/E7E2ocrZKFEQfLUc4Th/Hm8ftF2uWG9rq5JCvIhKcTCN38r4CnJmZqiyAz5PHk5gtvc9L8Rk40uzV4kdLU0XoZ9g2WMjDNyirNK4/60p+B/6uE/8mywlVtec0JkHn/oGZ9+MRQ/nljmh1gtk4F6J0eyU5UABn0uXqe485mO1PhkG5hrdpOEmP9ImRQJZXn1NndcImi1TH/UtEnLx1cWfeyKA1vXoOZ9V9hyj8irhbYdSbbIPRlr2ImLwiJAy0COGmWbTjr4du4LKjHK01bhPdJqMMVQo2MobJ1oDWmH9CgnkkhQohN88RQB5nNqHxSQ3g0kVYYdh/MZsL/Nk2ae5KlSCvODKWnt9j2a4H61znpInqJT7VtMW8NIa7GxwHzy8QI/ktkjTv9I63Y3d3z8Z+13ZSjQZOYeobRkWsJeAB8+GAUB2Cw5vX1j6Ov/qPN4RViGpcioFXac6FglJSNslJHZHhOXBwWa/O2TlFW7HUg0N9mzq/eX3GSmv/P6ftdxAKShlSxEriiebjKnWzQY3EAdOqjgb1yr7bok+uJkVFvcM8GDXv/40o5AgOKkWUK6yZABTx4HWJ1WHxDplB7saqWNKAjrmknFaWQ+DdwrOyxPFUl9/g+Qv4Hzno7kGy6Dm4eyAADU8tTKVj3pTvKbewie8dfV806sRlPpQbzFcrkrUUSJruMR8rdf2DAgWppCgMLBjBTfpPSsbwWiMORxpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(396003)(366004)(136003)(36756003)(6486002)(26005)(6506007)(2616005)(2906002)(53546011)(478600001)(83380400001)(186003)(6512007)(31686004)(38100700002)(8676002)(86362001)(66946007)(8936002)(5660300002)(54906003)(6916009)(316002)(41300700001)(66476007)(4326008)(31696002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjZZaHFqQjJZK05VbFFmZlF5TllKWFUrV2hIVENDN0NUTmdCY3FBOHBFWEdz?= =?utf-8?B?aTg0NHFpc2Z6YS9reXZJYnNZRUYrdTgyb2JKaFlqellvMEVUU3l2WlN5MGtz?= =?utf-8?B?YW42RmxCWlBJVGZQcERlQkpFYWVhOWNBZk8zWFZoR0ZBY2RnS29ObEFBeC9l?= =?utf-8?B?Q2krS24rTnRVY3BBbVZFZXdFT3FEcjZYMy9kK1NGSGlld0xsSk9zTjlVNDQ0?= =?utf-8?B?R3hpcEF6ZWpPQ0x6azdFM29UU3FueEZnMFZnNDJydHpCMEwzOFBSdFRQTjR2?= =?utf-8?B?VXBleGIwcmtqTWUrTVoxTVN3VXR5MUExRk9MVkkxTUhjYmgvYVI4QUE3OTYx?= =?utf-8?B?MC9tSURvWlJ2S3ZXS0JiMEpJaFNOQjhaTDdyWDRXekNJVzFNUzhNQ0dRUjVB?= =?utf-8?B?WjFSaTFUTmFKNksyejRoRUt1bFgwdWxPNml5eHVldG43VzRQTUpNNTMxNHlZ?= =?utf-8?B?MjZZdmViSE5IV05qUU5OTzNLSFFaWkdIc3Zzb0ZQczByVXdWcDYvTS9xUHVn?= =?utf-8?B?djh5Y1RmOEpuclFnTVFGcjFmVm5MQ2FSSDliL3JlQ0JwYjRDTkJ3S28rdDVB?= =?utf-8?B?ajhiMm5MUlA4RXp5Y2p1Qm1FMytOT3ZOUFAwOG44S3plZUxVa3ZxQmVhVS9D?= =?utf-8?B?eWptRGlSdWFOSkZ6cFV0RTdvUEdINUtMWG05eHN3RWFnSTRpcmZvcFcxMk1x?= =?utf-8?B?MUdyRTVIay9qUXYxNjkyVnp1ZFl6MGFha3c1RU9OaGdxQjFTRE1mRlZxUGNa?= =?utf-8?B?SlA5NnpoUFBWQktRVzlnN25nRXBhMzlvT3JBS0NlVUR5eXNndEJFdTZPY0li?= =?utf-8?B?a3BRby9VcU0wNDRBZlVNSExMOWZGaDhMeERGNEc0SGJNOHNSdFJRWDNjU3ph?= =?utf-8?B?NzRVanZ1T0JKWnBsUVJNazRXQjcwbjFUaW5UMjVYTWkzSVExWVVIaFVYVFFz?= =?utf-8?B?OGZaR05sMkQ4ZjVFWWJyYXQ0eDZDQUNRa2xJbkt6b0Rha0QrdG9GQzFreHBW?= =?utf-8?B?SFpLYW0rYXZ0dkdEZEdUbXJPUTVSOWdtdkVhaTVUWVZGSWZ4NlVaV1Z3YTk3?= =?utf-8?B?N2hFemw3dEpTalNNU1V4TVlOOGVUNWtteHhmdXBMNjVBc0R4bTlQMThRYW5D?= =?utf-8?B?NjI3aGowTlZKN09rdW9yV0FIcFJPNnJ2T3F4V2JpYmdvZ1d3S2N4U2FqRVM3?= =?utf-8?B?S3NmdVpwdStVMnYxb3Fhd0VKeEMwQjNXanUrVWlTbVlzVkh1a1greTY2dFl5?= =?utf-8?B?ek45UktMM1NGTkM2RTBzVXlDRlA3U0pnYkE0TlhpQi9ZUUlYOE1BMmhHb0hQ?= =?utf-8?B?TWdWYlBRRHRmRU85WC9SMy9OdnVXc2hTOTIzQkVtS3BUU29qZ0hTbmtXR0JE?= =?utf-8?B?d2VITWUzcW84azZ1YS9JZlJVMUlJK1htYStJdGFZYzkvT1ZmL2MrQnI3L1dT?= =?utf-8?B?UVEzbEJ1WUFycWozRTR2dVNZRDFFOUFNZW9pb3hqYXIyTHEvSENLVjlmSFNy?= =?utf-8?B?NDh0bkovN3B2bFVnU01XQ2Z1WTNhNW9pa01FblgvamJrclBSZVhpbGo2ZTJG?= =?utf-8?B?RlZRTUhxRit6WnorUXowQmd1NnFTeDRuZkFndmg2VkR5R3ZieXN4cENHY0RU?= =?utf-8?B?UmNFUzMwcHVIUWIzSzJwLzQ5eTZKWGlkc1JZL2NXNW54LzZiK3l6NDJqZzJ5?= =?utf-8?B?U0FMNmh5aGhaK0poM2dtaTJYT3FzeFJKNGlHNEVsY1RlUlBXeTNPKzl6aTRt?= =?utf-8?B?UzdxVUpZZ0xWWGZCMy9RMStzL1FSZFpucVNGSWcxZHR1RDBZMmYvc1BTWGxZ?= =?utf-8?B?RzV3UzVnVUxJeVZkYmpEQlpyaHNHK3ZRTFFob3hUbXhiLzUzTjVoQllacUVk?= =?utf-8?B?NVpHY2RpTDc2YkxlUFFFKzRMdGxZam9FWUZPMStyUFZnNkNNc2M4WVc0SEhw?= =?utf-8?B?Z01BekVBTmdBb1ZTczFqamZ6ckVXSXpJNU0xZ2JJN2paVXBMamJURzhoVUlN?= =?utf-8?B?aEw5aHRDRkk0aUh4dXpWSkd4THRXR3pBd3BtdGlHaVVjZU5KNCszOWs2YXFk?= =?utf-8?B?b0taV0ttUEVqT2R1ekpWQVJidVV6eWh5SFRDNlFWMDJWMG9LT0V4MDNtcE9E?= =?utf-8?Q?FrAXyLKB3Py7I8AyHkBhOAdjK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e11c169-cab4-48f9-e480-08da6034526f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:18:26.4914 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xdOqhqICL4iqIZVLqSJCh85EEdPenlsb2bk2egSsOYM6ouCj9zB1sZn2DO7nbNwsPUHh/Xctc83jSsLe0ioC/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5259 On 07.07.2022 17:36, G.R. wrote: > On Thu, Jul 7, 2022 at 11:24 PM G.R. wrote: >> >> On Wed, Jul 6, 2022 at 2:33 PM Jan Beulich wrote: >>> >>>> Should I expect a debug build of XEN hypervisor to give better >>>> diagnose messages, without the debug patch that Roger mentioned? >>> >>> Well, "expect" is perhaps too much to say, but with problems like >>> yours (and even more so with multiple ones) using a debug >>> hypervisor (or kernel, if there such a build mode existed) is imo >>> always a good idea. As is using as up-to-date a version as >>> possible. >> >> I built both 4.14.3 debug version and 4.16.1 release version for >> testing purposes. >> Unfortunately they gave me absolutely zero information, since both of >> them are not able to get through issue #1 >> the FlR related DPC / AER issue. >> With 4.16.1 release, it actually can survive the 'xl >> pci-assignable-add' which triggers the first AER failure. >> But the 'xl pci-assignable-remove' will lead to xl segmentation fault... >>> [ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] >>> [ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 >> Since I'll need a couple of pci-assignable-add && >> pci-assignable-remove to get to a seemingly normal state, I cannot >> proceed from here. >> >> With 4.14.3 debug build, the hypervisor / dom0 reboots on 'xl >> pci-assignable-add'. >> >> [ 574.623143] pciback 0000:05:00.0: xen_pciback: resetting (FLR, D3, >> etc) the device >> [ 574.623203] pcieport 0000:00:1d.0: DPC: containment event, >> status:0x1f11 source:0x0000 >> [ 574.623204] pcieport 0000:00:1d.0: DPC: unmasked uncorrectable error detected >> [ 574.623209] pcieport 0000:00:1d.0: PCIe Bus Error: >> severity=Uncorrected (Non-Fatal), type=Transaction Layer, (Receiver >> ID) >> [ 574.623240] pcieport 0000:00:1d.0: device [8086:a330] error >> status/mask=00200000/00010000 >> [ 574.623261] pcieport 0000:00:1d.0: [21] ACSViol (First) >> [ 575.855026] pciback 0000:05:00.0: not ready 1023ms after FLR; waiting >> [ 576.895015] pciback 0000:05:00.0: not ready 2047ms after FLR; waiting >> [ 579.028311] pciback 0000:05:00.0: not ready 4095ms after FLR; waiting >> [ 583.294910] pciback 0000:05:00.0: not ready 8191ms after FLR; waiting >> [ 591.614965] pciback 0000:05:00.0: not ready 16383ms after FLR; waiting >> [ 609.534502] pciback 0000:05:00.0: not ready 32767ms after FLR; waiting >> [ 643.667069] pciback 0000:05:00.0: not ready 65535ms after FLR; giving up >> //<=======The reboot happens somewhere here, not immediately, but >> after a while... >> //Maybe I can get something from xl dmesg if I was quick enough and >> have connected from a second terminal... > > Unfortunately I didn't see anything from xl dmesg... > I wish the 'xl dmesg' can support the follow mode (dmesg -w) that the > Linux dmesg does. > Here I have to manually repeat this command. The machine suddenly > freezes after the 'giving up' message is out. > I see nothing special in the log. Maybe I'm just not lucky enough to > catch the output, not sure. If the box reboots in the middle, I guess you really want to hook up a serial console. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 16:23:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 16:23:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363102.593454 (Exim 4.92) (envelope-from ) id 1o9UHo-0001A5-1P; Thu, 07 Jul 2022 16:23:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363102.593454; Thu, 07 Jul 2022 16:23:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9UHn-00019y-Uv; Thu, 07 Jul 2022 16:23:27 +0000 Received: by outflank-mailman (input) for mailman id 363102; Thu, 07 Jul 2022 16:23:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9UHn-00019p-9M for xen-devel@lists.xen.org; Thu, 07 Jul 2022 16:23:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20959c0b-fe11-11ec-924f-1f966e50362f; Thu, 07 Jul 2022 18:23:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS4PR04MB9386.eurprd04.prod.outlook.com (2603:10a6:20b:4e9::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.21; Thu, 7 Jul 2022 16:23:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Thu, 7 Jul 2022 16:23:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20959c0b-fe11-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxjzyPo35btAQHOZZZnLesyEkSNiL6bnorTObIeqdqD46bQ6lxWQg/Q7wMXgWcQeWMp8VzCcwIRsrO45UJly7rUpYx179FQScaA2j4n/fRc0KiyjEGZhnmeGY1eI9gjv2PKc7s/dvbQcRrTzIsUXpMkXCrMhDY10ZrH874ZqIzT+4li6ypi9DMSEIrTa3zQNcYimYl8WcvlrKo6M1aPnzffzVMKHh84UliKKzOGhciQY5P8y45MNPOgUHhhDOc91braMv4QpVZUlIsk0HbiobYUya9CLRJTRBLhB2TOauMpZFpPY9N2RcTMTWjkGOeB0M9RDSuUpY9uDf2LrO5wTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i7itPSpvibWGsBe0Aq83kx9QoMVNKCF9uTMtkyS1gJM=; b=Su0Fs1Y6qLeeMyC0L26zRZcUopOHodIXrsGTK0IKcVnvg0kUwVxDcksDfld81yCxRs9ZPk7hVdgOYb18q3zddcRbPYa1+FpQBTu4l7p/A3/YA5SFivFOducDZhL/DaIF4OmjXEC8q5s/C3RZKPiXz00jPpTpEIXBZXxQsL5W7U2iSjaqYMyxTiw0PsUdSzEIDbpxegDG52mkDJ5OoTaSqW7dBoaD2CDEIhSgYYg8yU487l5QPwj7BZZLHl2oR0zEr7h2Jm8zc7dfGhjDDKYtfGD/zjIbymBq4kecWp1MrZXNYAZuIbMe0EZ/m/nsEWpp+JUcXZbuiGue07H1QiVlQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i7itPSpvibWGsBe0Aq83kx9QoMVNKCF9uTMtkyS1gJM=; b=KZ5kxgvLqnyEIqbK69HwVVX6s7nY6ZvNY1oLhCc1D3Qe//0MHuIEIsRKErT4j7dEy/enW1GJVIJhlUQiLUBXZGahGy6zIxjhReMdBhyuYbgYd55cr7t6ooi0lk9VLI6ZtjIQ6uPFgJkCpoNUbOtOIc5xpoy4ARe0RgPnqDqVfpJYrPPZM+2lGjmeOqIJKjHdgPNhzZMxcZcVVaPDxkYR1Aqd+/ktlIIVNaZe26ze1VvmyXx/cjzq6Q7tVjDWlM/AlsXGDm/M33zVHJGXz68ga6yQBzgc+CRGv1ALIZ8iDd9XDLRaBdcNEIqEU4v0AI63+PBkPci/xT2TdH3zcQfg7w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <93c7b016-06f9-e3d2-5a7f-97a5f15c1a86@suse.com> Date: Thu, 7 Jul 2022 18:23:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: PCI pass-through problem for SN570 NVME SSD Content-Language: en-US To: "G.R." Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony Perard References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aef2e860-923a-478f-4700-08da60350365 X-MS-TrafficTypeDiagnostic: AS4PR04MB9386:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6vzM6ZpBXPQQEL82GqxhNAhFZ/xJGSk20Z6h/yu6p2jdehwvA3aUgivQNbbLBSP//RiUKrJo4cd/7Emkgks1h/KqbD2LbOFyq5o/FI8FwQ0zwy1dq3vKegHUB/ec0wC+wLiTzOZjfFJkvIuNI1CvEpjy495lsjcAdddoLbua+sXrWG3EPLGjTbQHpzWRmkALZyLQrgyfalffu3FdqsgX+CT6djEEmfpPmTzDNIAFAya3MCWuFFI4hutKbfr28hSZedtMzCVZvR55yXIE0n5awV07FLIfizXUnzOrtWxaAzBZGR2BF9VTZi5TSSY4R1t32bjgYNV8G21+yCeIjQQE/Raoh4xvyBqAi+BM6mjw/C6vNP8pj6SoytW/PpQvOllD0F0s9PK0b/oGVDYhPE1snx5A7r4MsTOqxlT7WfydGM1lsPTBr9fZF2TpcPM6MQg3uEQdADPtkBDqHFU34yFtioV3DDTja8LdCq6b4abb6pbYRDLjiefJClx6TNhnSI0GAXyN+fnwGsTSAhHzl2Funu5JIrD6KEba0CKKabJrp9iyA45FBpDkw8q5XfzJft306vaX/DFnfIQviABg72wB3VIf0wZJ9fYRB8OrKSiIxtMCC0CeVRlMAXhQUEE1CsH3t418yAXrdcpQNZpt46u/OMALsgKZm5+4jXkMiYdN2m7fPvBYBymWYMMCr9cZyh/1KbHuHINcadB8vp9HIZsr1emY41rUmsrzs/7AmUhfeZeZ2Az7jhtyqa8WpOun73N1uOWn+Le6T+lNBbc7N2IV4b0453JSeXI70UavhPR4XXjR8FkNbi50W79HvDtAog7sBwpJv1F/bZ25Wg3YlhcV19xvwyXz1ftkw+8qkCjvhv0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(376002)(396003)(346002)(2616005)(186003)(83380400001)(54906003)(316002)(38100700002)(31686004)(8676002)(6916009)(66946007)(66556008)(36756003)(66476007)(4326008)(478600001)(53546011)(31696002)(6486002)(86362001)(6506007)(8936002)(5660300002)(26005)(2906002)(41300700001)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjZGcXJaZkQ1eHpsZGVwd1BGNXFYYVFlNytLdjZLU1FhenRra2xDRlpQR1Rq?= =?utf-8?B?NENvY2FpWGdVK2ZweDlNa2d4SW9ta0R1MG1LOEZuY0lLbzJkNGk5Wnpjbi9a?= =?utf-8?B?eitnR284NFpLdmJ5RHdQYmw1VjVWQXR1T3lReE1FZTVLQVgyb2Q3R2hSaEFK?= =?utf-8?B?SjJ1VGVHMWFycUNYOXlyd1g2Z1E0OTl5WVZuam55MjROV21XU0dnRytUV043?= =?utf-8?B?UjQydXZSRkMxWkx2QU80RXZjbHVjUGFRWVU4enVnV0dlSW1WQzN3VVRrcm1x?= =?utf-8?B?K0lJL2kxZmtYWXMrcmI3ZmhQYy9TMkNpbnhOckFBN0VCRi91OTZHOUxpNks4?= =?utf-8?B?YlltZnpJcjVEakxxNUpNWGlLK1BDL05TR3lBLy9yQ3VyMnlKc3BncGkzQ012?= =?utf-8?B?S3paNUN4b2wzQUE2RGFsT00wZlpjd3ZFd3hnd1VsVjlSbjZ2YW5RZ1VPZU54?= =?utf-8?B?K3pLL0hQR0pVODlmMmRUMEZZUGtHaGxGOUVxcXRDZnBnTzBENEFZSmNnaTQ1?= =?utf-8?B?RlBHdGJvdHBwSEQya015dWpvU0ZlYTBlbWJrVGE5KzVmZ3JLN2kya2VuZG9h?= =?utf-8?B?ZWtwbVBDdnJBY3dkY1RPZ0RYYVNLaGNpbmtxWGRsZ212TnN1TGMzd2trUUJJ?= =?utf-8?B?bklTUmZibXJUZVIwK3lwM1VCcFZLbEFUN253TGQ2aS9PNnBjS243V2hvRkow?= =?utf-8?B?OVVjV3lCOFJjRmYvMzErM0ZKcUpEbWh1UVJQZ0FiYXVVU2ErZmxZam1Yem4w?= =?utf-8?B?eFJwL0EzMVY5SlBHNHRzajJ3WGxqSWNlbWhWZWJSeUowZVFhdXVJcmxHR0Q1?= =?utf-8?B?c0ZpSitWcmdGUXhMR21LMjNtYld4djlESFp4WjN2TG1vZENJVlgvTEt0OE1S?= =?utf-8?B?R1JpOWhjMExDV1VFUmxGekk2NnY2MWF1dk5SbEpscnd5MERXL2loY0k2ZTRj?= =?utf-8?B?YWdEL1hHMEgzV3pVWnArZWZ2eGJsZFh2RDJwMUt0aHJ2UUtLVmo0UnlqS3B4?= =?utf-8?B?RXRzNU1lS1d3Zm9sTFRLTUt5UEhQZUs3dHJHWGQ2aytPRWs3OFlzMnB2bG5I?= =?utf-8?B?UmdXL29iYklXVnp6V3d3VjB5WGJuanpSb1BITnR1STFvL3BLVTRYdlJFSzYr?= =?utf-8?B?SW1OWkRkQ1pHS3NnOUhUQmVDN1REaGlxZ25FL1JKRFNOVGtnamhUVlFUTkti?= =?utf-8?B?bnN1b2thNFdPSFd0NkNHTkliQmhxVWlIWTB6UUszMCtoRDBPK24zRTEwdVhl?= =?utf-8?B?YzJ4cnV6aVdJUC90U3g5N0J2b1MvdlA5dDdTd1gvS0F5WFZWdTZzSWJ3aHJ2?= =?utf-8?B?T2wzN296VUZseTg4YkVxTzJ4ZjIvNHdlVy9NZXFtMWppZTJGL0YzVEhGajhp?= =?utf-8?B?VjI1aWJGOERhYWthZ0xVbzN1SWFaRU84VWVBZTl4YjFPd3pZclRGVy90bUE2?= =?utf-8?B?YVpKVEc3ajFvMjFDOVhidm1zRVVleHdlOGZSQkgyaVNsOVhoSXhTUWYzSWR1?= =?utf-8?B?OVVNaFdndjc5M3J1VkkvdzJkZUc1NnkwZ3VWNG9xNTdEbU1oUmoxT0RWMnJ0?= =?utf-8?B?eVV5RVhpQ1RxS25rTTFkb2ZYaTJDN3BLVVk4YjRpWWtUQkh2K0RHQng0bnlu?= =?utf-8?B?alI1QWFhdVg2VFlLQnBVN2VmeVFRUUFxWVVHckNKL2lMalo2V3hmRXc2bGJ5?= =?utf-8?B?c2wybzNYNG40UnRmejVjWkxNWUY3VFVXbXRtR2FWYVo2Z1hYSkZIS1VlMm0y?= =?utf-8?B?ejlLNVBwczRLV1A5K1JYb0pYWWdBODg0aGJ2d0wrVlJjNXlZK3RyUENsZ2xV?= =?utf-8?B?SHVzakRKYnFNVnVGRmNCaFAvWXBTZTJKY3BhS3FoQXBBS3ZTSHUwdDBnUUVj?= =?utf-8?B?SFprZE9qRFdYSFFWTWs4TGgvWnV4emFra3BvWjM2KzNsQXNqSkhuVFFQQjlI?= =?utf-8?B?N2tPRy90MmlwSGp0TlBQeFIvQTVzRFovZ0FEZWt2QnlQQVJ1VkFEZ0E5SEsw?= =?utf-8?B?TEYrVFFESkgzNFlrYkRDSENVVFpnQjZQYXByR3ZsR09ac3JpTUFOcWRmZ3lp?= =?utf-8?B?OXNhM3VPRWlNWXBocGxMWHU2Qi9KMWNkOG0wME5CcVRtakpJY1JacTJSMlVI?= =?utf-8?Q?ePD0kilXm6KMJdyZE4EXHWEIy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aef2e860-923a-478f-4700-08da60350365 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2022 16:23:23.3786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aU2xiP3n8VZyx30DFlxn2x/4DWOZ+byWBc+tYVRRfO7+Wqkr4XtH9uxvG+wNT5KXYP2XCQHn1zC8dakZC3tHDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9386 On 07.07.2022 17:24, G.R. wrote: > On Wed, Jul 6, 2022 at 2:33 PM Jan Beulich wrote: >> >> On 06.07.2022 08:25, G.R. wrote: >>> On Tue, Jul 5, 2022 at 7:59 PM Jan Beulich wrote: >>>> Nothing useful in there. Yet independent of that I guess we need to >>>> separate the issues you're seeing. Otherwise it'll be impossible to >>>> know what piece of data belongs where. >>> Yep, I think I'm seeing several different issues here: >>> 1. The FLR related DPC / AER message seen on the 1st attempt only when >>> pciback tries to seize and release the SN570 >>> - Later-on pciback operations appear just fine. >>> 2. MSI-X preparation failure message that shows up each time the SN570 >>> is seized by pciback or when it's passed to domU. >>> 3. XEN tries to map BAR from two devices to the same page >>> 4. The "write-back to unknown field" message in QEMU log that goes >>> away with permissive=1 passthrough config. >>> 5. The "irq 16: nobody cared" message shows up *sometimes* in a >>> pattern that I haven't figured out (See attached) >>> 6. The FreeBSD domU sees the device but fails to use it because low >>> level commands sent to it are aborted. >>> 7. The device does not return to the pci-assignable-list when the domU >>> it was assigned shuts-down. (See attached) >>> >>> #3 appears to be a known issue that could be worked around with >>> patches from the list. >>> I suspect #1 may have something to do with the device itself. It's >>> still not clear if it's deadly or just annoying. >>> I was able to update the firmware to the latest version and confirmed >>> that the new firmware didn't make any noticeable difference. >>> >>> I suspect issue #2, #4, #5, #6, #7 may be related, and the >>> pass-through was not completely successful... >>> >>> Should I expect a debug build of XEN hypervisor to give better >>> diagnose messages, without the debug patch that Roger mentioned? >> >> Well, "expect" is perhaps too much to say, but with problems like >> yours (and even more so with multiple ones) using a debug >> hypervisor (or kernel, if there such a build mode existed) is imo >> always a good idea. As is using as up-to-date a version as >> possible. > > I built both 4.14.3 debug version and 4.16.1 release version for > testing purposes. > Unfortunately they gave me absolutely zero information, since both of > them are not able to get through issue #1 > the FlR related DPC / AER issue. > With 4.16.1 release, it actually can survive the 'xl > pci-assignable-add' which triggers the first AER failure. Then that's what needs debugging first. Yet from all I've seen so far I'm not sure who one the Xen side could be doing that, the more without themselves being able to repro - this seems more like a Linux side issue (and even outside of the pciback driver). > But the 'xl pci-assignable-remove' will lead to xl segmentation fault... >> [ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] >> [ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 That'll need debugging. Cc-ing Anthony for awareness, but I'm sure he'll need more data to actually stand a chance of doing something about it. Is there any chance you could be doing some debugging work yourself, at the very least to figure out where this (apparent) NULL deref is happening? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 07 18:00:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 18:00:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363110.593465 (Exim 4.92) (envelope-from ) id 1o9Vnm-0007Qp-5k; Thu, 07 Jul 2022 18:00:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363110.593465; Thu, 07 Jul 2022 18:00:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Vnm-0007Qi-2z; Thu, 07 Jul 2022 18:00:34 +0000 Received: by outflank-mailman (input) for mailman id 363110; Thu, 07 Jul 2022 18:00:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Vnk-0007QI-UJ for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 18:00:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Vnh-00049J-4s; Thu, 07 Jul 2022 18:00:29 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.13]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9Vng-0004QV-Sp; Thu, 07 Jul 2022 18:00:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lShGzR6qwIyBYvG26+ukeDZ0pjhDQ2kB8igP/AKpxEY=; b=z4gbfWFLICpw3fGEgRH8d8zOi4 8lZ0c+YNfdNPjD3GkvZaf8YKcJOIdN8UymxjEsOfJN963FkRzrSiVF9MIGbUybc9ytnwHD8qofdWp 7y3m/YXaveHiPlITuK7WEhSH0ALLmiJEaFjxdLM/wKGtDlIQbH+YVgG3X4E8HFMTOPr0=; Message-ID: <6683c78f-ab19-ebe7-b6f9-32019f2226ef@xen.org> Date: Thu, 7 Jul 2022 19:00:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 2/6] evtchn: convert domain event lock to an r/w one To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Ian Jackson , Wei Liu , Stefano Stabellini , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: <306e62e8-9070-2db9-c959-858465c50c1d@suse.com> <5f5fc6a7-6e27-8275-0f05-11ba5454156a@suse.com> From: Julien Grall In-Reply-To: <5f5fc6a7-6e27-8275-0f05-11ba5454156a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, As discussed in [1], I think it would good to revive this patch. AFAICT, this patch was dropped because the performance was thought to be minimal. However, I think it would be a better way to resolve the problem that one is trying to address [1]. So I will do another review of this patch. On 27/01/2021 08:16, Jan Beulich wrote: > Especially for the use in evtchn_move_pirqs() (called when moving a vCPU > across pCPU-s) and the ones in EOI handling in PCI pass-through code, > serializing perhaps an entire domain isn't helpful when no state (which > isn't e.g. further protected by the per-channel lock) changes. > > Unfortunately this implies dropping of lock profiling for this lock, > until r/w locks may get enabled for such functionality. > > While ->notify_vcpu_id is now meant to be consistently updated with the > per-channel lock held, an extension applies to ECS_PIRQ: The field is > also guaranteed to not change with the per-domain event lock held for > writing. Therefore the link_pirq_port() call from evtchn_bind_pirq() > could in principle be moved out of the per-channel locked regions, but > this further code churn didn't seem worth it. This doesn't seem to apply on upstream anymore. Would you be able to respin it? I have looked at the place where you use read_lock() rather than write_lock(). They all look fine to me, so I would be fine to give my reviewed-by on the next version (assuming there are nothing wrong with the rebase :)). Cheers, [1] https://lore.kernel.org/xen-devel/acd0dfae-b045-8505-3f6c-30ce72653660@suse.com/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 07 20:36:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 20:36:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363117.593477 (Exim 4.92) (envelope-from ) id 1o9YEV-0004B4-5q; Thu, 07 Jul 2022 20:36:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363117.593477; Thu, 07 Jul 2022 20:36:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YEV-0004Ax-2r; Thu, 07 Jul 2022 20:36:19 +0000 Received: by outflank-mailman (input) for mailman id 363117; Thu, 07 Jul 2022 20:36:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YET-0004An-GZ; Thu, 07 Jul 2022 20:36:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YET-00070V-DB; Thu, 07 Jul 2022 20:36:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YES-0003tL-Sj; Thu, 07 Jul 2022 20:36:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9YES-000588-S8; Thu, 07 Jul 2022 20:36:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qW0kbZUOkrrxiJ+lkISN/2O+q4MN7JbOOF2yhskZWSo=; b=sGOq+KzTuiDzCicZPp0+gSmPDb 5oa6dWVx307jFIOSQ9QPGESdDXFB7btG0Uk0KuUeIY7h8i1R+NjluED8U+Q7Q75hcTrUsivKtks2k G8b/S7Ywm4uw7AwflyymLOjNq3p/LmLWZ2chO0MMq4EVZap46UvExaCo0h2tPW+raqc0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171544: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8e9398e3b1a860b8c29c670c1b6c36afe8d87849 X-Osstest-Versions-That: qemuu=0e3723005bfea2f70157bf951f3e6be03bbf6e74 From: osstest service owner Date: Thu, 07 Jul 2022 20:36:16 +0000 flight 171544 qemu-mainline real [real] flight 171549 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171544/ http://logs.test-lab.xenproject.org/osstest/logs/171549/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 171539 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171549-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171539 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171539 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 8e9398e3b1a860b8c29c670c1b6c36afe8d87849 baseline version: qemuu 0e3723005bfea2f70157bf951f3e6be03bbf6e74 Last test of basis 171539 2022-07-07 01:09:39 Z 0 days Testing same since 171544 2022-07-07 08:35:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Kardashevskiy Daniel Henrique Barboza Fabiano Rosas Matheus Ferst Murilo Opsfelder Araujo Pali Rohár Richard Henderson Thomas Huth Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 680 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 07 20:38:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 20:38:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363124.593488 (Exim 4.92) (envelope-from ) id 1o9YGS-0005Fx-Jx; Thu, 07 Jul 2022 20:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363124.593488; Thu, 07 Jul 2022 20:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGS-0005Fq-Gq; Thu, 07 Jul 2022 20:38:20 +0000 Received: by outflank-mailman (input) for mailman id 363124; Thu, 07 Jul 2022 20:38:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGR-0005FX-61 for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 20:38:19 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb422a90-fe34-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 22:38:17 +0200 (CEST) Received: by mail-ej1-x62a.google.com with SMTP id ez10so4259042ejc.13 for ; Thu, 07 Jul 2022 13:38:18 -0700 (PDT) Received: from uni.. (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.googlemail.com with ESMTPSA id s17-20020a1709060c1100b00722e52d043dsm19344858ejf.114.2022.07.07.13.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 13:38:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb422a90-fe34-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jWcqEuvxM0/j0hASRiAWQ4nyDWpbIM9ewuBdZsVBjG4=; b=FZjcAC6BbZHyOX4ck/m6He8Ox1TnsMSg5WWzVe3xxnSjv23yjllmR4GtPmIEeTv8Jg XnZOxXuG+55RIaXgZUF8b8/e/viE7YFiKoMlGxa1zXGcFsqMymJhLDpgL6K0rwKuKwAe jd/DgovVw3gRYn/YYiXFYrpGRdaGEbwHFPBAsMA1OmS9vxqZ+SVato9Dw1CLZB+ngb9V cytB5gAK4GTqBabqh8VaQTSPewfcPSuJiPqNWVksEVuziYr/T+Sq2wbkKkKA3kmJrY/B BpDpnOqgQKZa3JD67bK+MwrqiY42G3iqCnaBXot2YiJfmieYKo48/XYaCB+GT0tZkc0B w8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=jWcqEuvxM0/j0hASRiAWQ4nyDWpbIM9ewuBdZsVBjG4=; b=yKxisd1bDOJvWwT2rdjjPRbGWqt/Ip1cAPT08N1pY5th3sIgY/jOaUX5nZr5bnyjW1 tL60JhUquDz1yToOKvOG7bKyBO/0nS+CKvEnGsX+CrWee7j6ylw/cLFF6vLS0CK/h6T9 ZWW5jyQrq4dFRmr1qJpyF2ASa+hCKWEl5YPFpvaQEnOrjFswij+iD+ICcLmaxoamteFq YoJizp+XSlYMVGLCYWXBzgS+TdbQIRP/llrUm0YLUXs2E2GNjWPH9iPHXROPGtK++bJl 8BXejxqKPa/BFFa8myPwHd6xbPOmIPjXhoi/fzO5dyIkSKJcuV2a/e2vCVXUQreL+CNu VWRg== X-Gm-Message-State: AJIora/nEof1CN9FFJ1s//0EAzU7bl8keh7s4cnYJDMg5W23lwkzrF8R hof2B2flWOXyGvQYFeC3XooLQ6316xI= X-Google-Smtp-Source: AGRyM1uPBRYIoOlIfxVSo5FrU2hEDcz3XjKBv0WnwMzVpkXX8EQT71fE85ZndhTt9wxdtPs6uUTxYw== X-Received: by 2002:a17:907:3d8d:b0:726:3f5e:dc58 with SMTP id he13-20020a1709073d8d00b007263f5edc58mr44029204ejc.416.1657226297455; Thu, 07 Jul 2022 13:38:17 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 0/2] Create a test job for testing static memory on qemu Date: Thu, 7 Jul 2022 23:38:01 +0300 Message-Id: <20220707203803.798317-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series - removes all the references to the XEN_CONFIG_EXPERT environmental variable which is not used anymore - creates a trivial arm64 test job that boots xen on qemu with a direct mapped dom0less domu with static memory and verifies, based on its logs, that the domu's memory node ranges are the same as the static memory ranges with which it was configured Xenia Ragiadakou (2): automation: Remove XEN_CONFIG_EXPERT leftovers automation: arm64: Create a test job for testing static allocation on qemu automation/build/README.md | 3 - automation/configs/arm/static_mem | 3 + automation/gitlab-ci/test.yaml | 24 +++++ automation/scripts/build | 8 +- automation/scripts/containerize | 1 - automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ 6 files changed, 147 insertions(+), 6 deletions(-) create mode 100644 automation/configs/arm/static_mem create mode 100755 automation/scripts/qemu-staticmem-arm64.sh -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 20:38:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 20:38:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363125.593499 (Exim 4.92) (envelope-from ) id 1o9YGX-0005Y3-SN; Thu, 07 Jul 2022 20:38:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363125.593499; Thu, 07 Jul 2022 20:38:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGX-0005Xu-ON; Thu, 07 Jul 2022 20:38:25 +0000 Received: by outflank-mailman (input) for mailman id 363125; Thu, 07 Jul 2022 20:38:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGW-0005FX-TF for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 20:38:25 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bece1b40-fe34-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 22:38:23 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id a9so4688769ejf.6 for ; Thu, 07 Jul 2022 13:38:24 -0700 (PDT) Received: from uni.. (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.googlemail.com with ESMTPSA id s17-20020a1709060c1100b00722e52d043dsm19344858ejf.114.2022.07.07.13.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 13:38:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bece1b40-fe34-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x5r3MkqNQKETdv3U9LPOk3V6DXnQBYUf9+YzV6L4cI4=; b=hkses1a30jzJ8OVxDA5IvEl9iNMgdz+7Oxoai2bEUc/31PEDl9VP5EVi63PL0vNIxj s7lGe7jVURr5NuMGildiKqxB07pXOqQjrxlLqgGtvK3In5sPOq6N6hQkH85M2qXBYG3n MgsHj0ba7D4E4XM7cTDJKGcsIIB2jm8quEbbt+htO8dHjDqKSyFycEorKx16+Q3PsfPy 18dn5M5CBIjbyVqePtBW4dFgW8JfdWzx1aQXb0SbYXxEu6e0G7XBV9Nwgtw2gwipdcXC 6cPcJuhyDiMfmNh8/Y1BjXIOvGS4cYQfn1vVBlZ/DRmXYjf0Qcyu/bx69t03vySaK8Py h/jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=x5r3MkqNQKETdv3U9LPOk3V6DXnQBYUf9+YzV6L4cI4=; b=ghp5csbTxyLFIEKXMsU0EIuEuzbz8BW46VnRDFGvXvzmce6PGuiCj74r1PXciWYs2/ 5ELKhs+jbDFlDq3ftEuPmwFPBGAN5OflK96nEVAk1SUWv3e3cLoC2d39+skLR7vJKdzy Pnqsnyf1dG3dMqOD7ijwRKNDqDLFwuDwfURYZOfG+uChBgR95oa0pQrHD3AmyfNwnOnX Rdf1hT1WTv+7PL+uG0rRSrIiHYGYKNcimf5gm8/EdGM0ZZEwyai5npUSNTv8i+X1J0vz YEr/5NFPx5+X9S1SGuQ607VYb8lZg5ebXMw9mzmJl12T2xLAIiCGcAY5Rik24blsvRjf sIwQ== X-Gm-Message-State: AJIora+5oVVuCt6YFeVXo+03YfPZunW8jjMzDNVfCiPk+e6Je7OTLXPB nxaww3e8M8mKI5X5wriMP7mDInhoZ9s= X-Google-Smtp-Source: AGRyM1u9kTlkyE3D8hqJUq/rFPvwAotF1//FwtOQn/TBvYkgopQWR0gZyAA0+6wwYl5CYZwdIDRlAA== X-Received: by 2002:a17:907:9620:b0:722:fc5e:3259 with SMTP id gb32-20020a170907962000b00722fc5e3259mr44292104ejc.579.1657226303408; Thu, 07 Jul 2022 13:38:23 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 1/2] automation: Remove XEN_CONFIG_EXPERT leftovers Date: Thu, 7 Jul 2022 23:38:02 +0300 Message-Id: <20220707203803.798317-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220707203803.798317-1-burzalodowa@gmail.com> References: <20220707203803.798317-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou --- automation/build/README.md | 3 --- automation/scripts/build | 4 ++-- automation/scripts/containerize | 1 - 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 2137957408..00305eed03 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -65,9 +65,6 @@ understands. - CONTAINER_NO_PULL: If set to 1, the script will not pull from docker hub. This is useful when testing container locally. -- XEN_CONFIG_EXPERT: If this is defined in your shell it will be - automatically passed through to the container. - If your docker host has Linux kernel > 4.11, and you want to use containers that run old glibc (for example, CentOS 6 or SLES11SP4), you may need to add diff --git a/automation/scripts/build b/automation/scripts/build index 281f8b1fcc..21b3bc57c8 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -91,6 +91,6 @@ for cfg in `ls ${cfg_dir}`; do echo "Building $cfg" make -j$(nproc) -C xen clean rm -f xen/.config - make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig - make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y + make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig + make -j$(nproc) -C xen done diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 8992c67278..9d4beca4fa 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -101,7 +101,6 @@ exec ${docker_cmd} run \ -v "${CONTAINER_PATH}":/build:rw${selinux} \ -v "${HOME}/.ssh":/root/.ssh:ro \ ${SSH_AUTH_DIR:+-v "${SSH_AUTH_DIR}":/tmp/ssh-agent${selinux}} \ - ${XEN_CONFIG_EXPERT:+-e XEN_CONFIG_EXPERT=${XEN_CONFIG_EXPERT}} \ ${CONTAINER_ARGS} \ -${termint}i --rm -- \ ${CONTAINER} \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 20:38:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 20:38:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363126.593510 (Exim 4.92) (envelope-from ) id 1o9YGb-0005qr-8J; Thu, 07 Jul 2022 20:38:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363126.593510; Thu, 07 Jul 2022 20:38:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGb-0005qf-4f; Thu, 07 Jul 2022 20:38:29 +0000 Received: by outflank-mailman (input) for mailman id 363126; Thu, 07 Jul 2022 20:38:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9YGZ-0005FX-Sw for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 20:38:28 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c08297b8-fe34-11ec-bd2d-47488cf2e6aa; Thu, 07 Jul 2022 22:38:26 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id r21so5625640eju.0 for ; Thu, 07 Jul 2022 13:38:27 -0700 (PDT) Received: from uni.. (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.googlemail.com with ESMTPSA id s17-20020a1709060c1100b00722e52d043dsm19344858ejf.114.2022.07.07.13.38.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 13:38:25 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c08297b8-fe34-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vpI0Eg9KfzwGX1e9i4YH3hbJD+D1xrKH9eSxJgwZEeo=; b=WxNh2FmivGG996dANC5w8c6Rv5bY/hKuttQb9oEjJjOKVwIKJOWKkZxBWF365PTGk2 5q57Rto6GNdfFzRjSqSbZbOAZx91EbDMCHGEV7VAcjFRgzWfv6a4P9ApSL9B4Ibwl6r9 kA0IuGH2nBdu57t5aRMmpOnZ//QNpf0jE5MIjhxPiRnagRxhcCp8qyUYD7NKxjNQAxqR RO/YynBg+mk+Q5crOgQ4NiHUDPGET62YFsk3fZnFh2VPTHcIdtVdob3kaiXYJ0GY+sLU NO9X8I136iFY4whMMksAqhiGqCuMkjoVB6bmCkeMFhbL6Yv7qQ28vUqIWreKL19HpRWU PTRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vpI0Eg9KfzwGX1e9i4YH3hbJD+D1xrKH9eSxJgwZEeo=; b=f6CkNry7mbtbuGK8Du/4st4nI6dE2CueUIz00Kba3CT+S81SyImsEb9kmRMf448sVH ERUl8PinWa+98Os4NEUK3BByiAlWX4UCGHv6GlNHoLLa0YigngrYmnrOxDush7BMMAGa L1aJ+ehX3C04POOFVopbtGm/YEgyve0CNUkCwA8Hg6Uz0p90lXxMCiaKTRwtbaWSCKuW 28m+rso06GgILwh1ht8SbCuB1L04dEpK9BrpP94sAH7lZu5YzUR7qCxIAuretgEMyMH9 6XZLt4b/hFyMRA/W59y1+5eg4DyC955zvPBGeHX08Ud4hhQYpAdBrO+rJBsQ9kFHiwhP ZFSg== X-Gm-Message-State: AJIora+96cbRK/F+7Je+d4TCgHEko42j95G0NyS0u91lTTSYfVFNjuhG UqrRSSFywVkHLO5XYFVpF4jjDHiro4A= X-Google-Smtp-Source: AGRyM1umJab1NL2O2IU6i1UNh78+R1b4ihs9PuE1i/OvJKkN9EfPjVSVGqdQIvDG00ygXXZZp/B9rA== X-Received: by 2002:a17:907:3e86:b0:6f5:917:10cc with SMTP id hs6-20020a1709073e8600b006f5091710ccmr46875855ejc.53.1657226306309; Thu, 07 Jul 2022 13:38:26 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Date: Thu, 7 Jul 2022 23:38:03 +0300 Message-Id: <20220707203803.798317-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220707203803.798317-1-burzalodowa@gmail.com> References: <20220707203803.798317-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add an arm subdirectory under automation/configs for the arm specific configs and add a config that enables static allocation. Modify the build script to search for configs also in this subdirectory and to keep the generated xen binary, suffixed with the config file name, as artifact. Create a test job that - boots xen on qemu with a single direct mapped dom0less guest configured with statically allocated memory - verifies that the memory ranges reported in the guest's logs are the same with the provided static memory regions For guest kernel, use the 5.9.9 kernel from the tests-artifacts containers. Use busybox-static package, to create the guest ramdisk. To generate the u-boot script, use ImageBuilder. Use the qemu from the tests-artifacts containers. Signed-off-by: Xenia Ragiadakou --- automation/configs/arm/static_mem | 3 + automation/gitlab-ci/test.yaml | 24 +++++ automation/scripts/build | 4 + automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ 4 files changed, 145 insertions(+) create mode 100644 automation/configs/arm/static_mem create mode 100755 automation/scripts/qemu-staticmem-arm64.sh diff --git a/automation/configs/arm/static_mem b/automation/configs/arm/static_mem new file mode 100644 index 0000000000..84675ddf4e --- /dev/null +++ b/automation/configs/arm/static_mem @@ -0,0 +1,3 @@ +CONFIG_EXPERT=y +CONFIG_UNSUPPORTED=y +CONFIG_STATIC_MEMORY=y \ No newline at end of file diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 42cd725a12..dc181f3777 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -205,3 +205,27 @@ qemu-smoke-x86-64-clang-pvh: - smoke - /^coverity-tested\/.*/ - /^stable-.*/ + +qemu-staticmem-arm64-gcc: + stage: test + image: registry.gitlab.com/xen-project/xen/${CONTAINER} + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-staticmem-arm64.sh 2>&1 | tee qemu-staticmem-arm64.log + dependencies: + - debian-unstable-gcc-arm64 + - kernel-5.9.9-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - qemu-staticmem.serial + - '*.log' + when: always + tags: + - arm64 + except: + - master + - smoke + - /^coverity-tested\/.*/ + - /^stable-.*/ diff --git a/automation/scripts/build b/automation/scripts/build index 21b3bc57c8..9c6196d9bd 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -83,6 +83,7 @@ fi # Build all the configs we care about case ${XEN_TARGET_ARCH} in x86_64) arch=x86 ;; + arm64) arch=arm ;; *) exit 0 ;; esac @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do rm -f xen/.config make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig make -j$(nproc) -C xen + if [[ ${arch} == "arm" ]]; then + cp xen/xen binaries/xen-${cfg} + fi done diff --git a/automation/scripts/qemu-staticmem-arm64.sh b/automation/scripts/qemu-staticmem-arm64.sh new file mode 100755 index 0000000000..5b89a151aa --- /dev/null +++ b/automation/scripts/qemu-staticmem-arm64.sh @@ -0,0 +1,114 @@ +#!/bin/bash + +base=(0x50000000 0x100000000) +size=(0x10000000 0x10000000) + +set -ex + +apt-get -qy update +apt-get -qy install --no-install-recommends u-boot-qemu \ + u-boot-tools \ + device-tree-compiler \ + cpio \ + curl \ + busybox-static + +# DomU Busybox +cd binaries +mkdir -p initrd +mkdir -p initrd/bin +mkdir -p initrd/sbin +mkdir -p initrd/etc +mkdir -p initrd/dev +mkdir -p initrd/proc +mkdir -p initrd/sys +mkdir -p initrd/lib +mkdir -p initrd/var +mkdir -p initrd/mnt +cp /bin/busybox initrd/bin/busybox +initrd/bin/busybox --install initrd/bin +echo "#!/bin/sh + +mount -t proc proc /proc +mount -t sysfs sysfs /sys +mount -t devtmpfs devtmpfs /dev +/bin/sh" > initrd/init +chmod +x initrd/init +cd initrd +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz +cd ../.. + +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom + +./binaries/qemu-system-aarch64 -nographic \ + -M virtualization=true \ + -M virt \ + -M virt,gic-version=2 \ + -cpu cortex-a57 \ + -smp 2 \ + -m 8G \ + -M dumpdtb=binaries/virt-gicv2.dtb + +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts + +# ImageBuilder +rm -rf imagebuilder +git clone https://gitlab.com/ViryaOS/imagebuilder + +echo "MEMORY_START=\"0x40000000\" +MEMORY_END=\"0x0200000000\" + +DEVICE_TREE=\"virt-gicv2.dtb\" + +XEN=\"xen-static_mem\" +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" + +NUM_DOMUS=1 +DOMU_MEM[0]=512 +DOMU_VCPUS[0]=1 +DOMU_KERNEL[0]=\"Image\" +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" + +UBOOT_SOURCE=\"boot.source\" +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config + +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/imagebuilder_config + +# Run the test +rm -f qemu-staticmem.serial +set +e +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ + -M virtualization=true \ + -M virt \ + -M virt,gic-version=2 \ + -cpu cortex-a57 \ + -smp 2 \ + -m 8G \ + -no-reboot \ + -device virtio-net-pci,netdev=vnet0 -netdev user,id=vnet0,tftp=binaries \ + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ + -dtb ./binaries/virt-gicv2.dtb \ + |& tee qemu-staticmem.serial + +set -e + +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 + +for ((i=0; i<${#base[@]}; i++)) +do + start="$(printf "0x%016x" ${base[$i]})" + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial + if test $? -eq 1 + then + exit 1 + fi +done + +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 + +exit 0 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 07 22:26:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 22:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363146.593527 (Exim 4.92) (envelope-from ) id 1o9Zx0-0005LR-Ro; Thu, 07 Jul 2022 22:26:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363146.593527; Thu, 07 Jul 2022 22:26:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Zx0-0005LK-OI; Thu, 07 Jul 2022 22:26:22 +0000 Received: by outflank-mailman (input) for mailman id 363146; Thu, 07 Jul 2022 22:26:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Zwz-0005LE-Dd for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 22:26:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9Zwz-0000h7-4c; Thu, 07 Jul 2022 22:26:21 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9Zwy-00012z-Ud; Thu, 07 Jul 2022 22:26:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=Q78BAse3nBz3bhG5pfcWO+iS90oUbCnM8Dl9Q7LWg60=; b=dWnqO4QtEjgb2g+EAFZrDcVixg kpA803kGNsTjT1ihQw34fRuj6lsZotZ5qzqA+/jKOke/FXEqcT0uda9qWK4FoQpNlr9gR2swn4kzK Wfd05n0zLUyGebpS9caWZMl9Ay22x2AO6oc7a7cFpKN/SEma+Pp1h5+oi90Srh0LNlBw=; Message-ID: <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> Date: Thu, 7 Jul 2022 23:26:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> From: Julien Grall Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu In-Reply-To: <20220707203803.798317-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 07/07/2022 21:38, Xenia Ragiadakou wrote: > Add an arm subdirectory under automation/configs for the arm specific configs > and add a config that enables static allocation. > > Modify the build script to search for configs also in this subdirectory and to > keep the generated xen binary, suffixed with the config file name, as artifact. > > Create a test job that > - boots xen on qemu with a single direct mapped dom0less guest configured with > statically allocated memory > - verifies that the memory ranges reported in the guest's logs are the same > with the provided static memory regions > > For guest kernel, use the 5.9.9 kernel from the tests-artifacts containers. > Use busybox-static package, to create the guest ramdisk. > To generate the u-boot script, use ImageBuilder. > Use the qemu from the tests-artifacts containers. > > Signed-off-by: Xenia Ragiadakou > --- > automation/configs/arm/static_mem | 3 + > automation/gitlab-ci/test.yaml | 24 +++++ > automation/scripts/build | 4 + > automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ > 4 files changed, 145 insertions(+) > create mode 100644 automation/configs/arm/static_mem > create mode 100755 automation/scripts/qemu-staticmem-arm64.sh > > diff --git a/automation/configs/arm/static_mem b/automation/configs/arm/static_mem > new file mode 100644 > index 0000000000..84675ddf4e > --- /dev/null > +++ b/automation/configs/arm/static_mem > @@ -0,0 +1,3 @@ > +CONFIG_EXPERT=y > +CONFIG_UNSUPPORTED=y > +CONFIG_STATIC_MEMORY=y > \ No newline at end of file Any particular reason to build a new Xen rather enable CONFIG_STATIC_MEMORY in the existing build? > diff --git a/automation/scripts/build b/automation/scripts/build > index 21b3bc57c8..9c6196d9bd 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -83,6 +83,7 @@ fi > # Build all the configs we care about > case ${XEN_TARGET_ARCH} in > x86_64) arch=x86 ;; > + arm64) arch=arm ;; > *) exit 0 ;; > esac > > @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do > rm -f xen/.config > make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig > make -j$(nproc) -C xen > + if [[ ${arch} == "arm" ]]; then > + cp xen/xen binaries/xen-${cfg} > + fi This feels a bit of a hack to be arm only. Can you explain why this is not enabled for x86 (other than this is not yet used)? > done > diff --git a/automation/scripts/qemu-staticmem-arm64.sh b/automation/scripts/qemu-staticmem-arm64.sh > new file mode 100755 > index 0000000000..5b89a151aa > --- /dev/null > +++ b/automation/scripts/qemu-staticmem-arm64.sh > @@ -0,0 +1,114 @@ > +#!/bin/bash > + > +base=(0x50000000 0x100000000) > +size=(0x10000000 0x10000000) From the name, it is not clear what the base and size refers too. Looking a bit below, it seems to be referring to the domain memory. If so, I would suggest to comment and rename to "domu_{base, size}". > + > +set -ex > + > +apt-get -qy update > +apt-get -qy install --no-install-recommends u-boot-qemu \ > + u-boot-tools \ > + device-tree-compiler \ > + cpio \ > + curl \ > + busybox-static > + > +# DomU Busybox > +cd binaries > +mkdir -p initrd > +mkdir -p initrd/bin > +mkdir -p initrd/sbin > +mkdir -p initrd/etc > +mkdir -p initrd/dev > +mkdir -p initrd/proc > +mkdir -p initrd/sys > +mkdir -p initrd/lib > +mkdir -p initrd/var > +mkdir -p initrd/mnt > +cp /bin/busybox initrd/bin/busybox > +initrd/bin/busybox --install initrd/bin > +echo "#!/bin/sh > + > +mount -t proc proc /proc > +mount -t sysfs sysfs /sys > +mount -t devtmpfs devtmpfs /dev > +/bin/sh" > initrd/init > +chmod +x initrd/init > +cd initrd > +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz > +cd ../.. > + > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > + > +./binaries/qemu-system-aarch64 -nographic \ > + -M virtualization=true \ > + -M virt \ > + -M virt,gic-version=2 \ > + -cpu cortex-a57 \ > + -smp 2 \ > + -m 8G \ > + -M dumpdtb=binaries/virt-gicv2.dtb > + > +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > + > +# ImageBuilder > +rm -rf imagebuilder > +git clone https://gitlab.com/ViryaOS/imagebuilder > + > +echo "MEMORY_START=\"0x40000000\" > +MEMORY_END=\"0x0200000000\" > + > +DEVICE_TREE=\"virt-gicv2.dtb\" > + > +XEN=\"xen-static_mem\" > +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is also not clear why you need to pass xsm=dummy. > + > +NUM_DOMUS=1 > +DOMU_MEM[0]=512 > +DOMU_VCPUS[0]=1 > +DOMU_KERNEL[0]=\"Image\" > +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" > +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" > +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" > + > +UBOOT_SOURCE=\"boot.source\" > +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config > + > +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/imagebuilder_config > + > +# Run the test > +rm -f qemu-staticmem.serial > +set +e > +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ > +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ > + -M virtualization=true \ > + -M virt \ > + -M virt,gic-version=2 \ > + -cpu cortex-a57 \ > + -smp 2 \ > + -m 8G \ > + -no-reboot \ > + -device virtio-net-pci,netdev=vnet0 -netdev user,id=vnet0,tftp=binaries \ > + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ > + -dtb ./binaries/virt-gicv2.dtb \ > + |& tee qemu-staticmem.serial > + > +set -e A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it would be better to consolidate in a single script. Looking briefly throught the existing scripts, it looks like it is possible to pass arguments (see qemu-smoke-x86-64.sh). > + > +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 > + > +for ((i=0; i<${#base[@]}; i++)) > +do > + start="$(printf "0x%016x" ${base[$i]})" > + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" > + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial > + if test $? -eq 1 > + then > + exit 1 > + fi > +done Please add a comment on top to explain what this is meant to do. However, I think we should avoid relying on output that we have written ourself. IOW, relying on Xen/Linux to always write the same message is risky because they can change at any time. > + > +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 07 22:43:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 22:43:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363153.593537 (Exim 4.92) (envelope-from ) id 1o9aDW-0000Gr-8p; Thu, 07 Jul 2022 22:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363153.593537; Thu, 07 Jul 2022 22:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aDW-0000Gk-68; Thu, 07 Jul 2022 22:43:26 +0000 Received: by outflank-mailman (input) for mailman id 363153; Thu, 07 Jul 2022 22:43:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aDU-0000Ga-Ts; Thu, 07 Jul 2022 22:43:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aDU-00012J-OE; Thu, 07 Jul 2022 22:43:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aDU-0008FV-5P; Thu, 07 Jul 2022 22:43:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9aDU-0007dr-4y; Thu, 07 Jul 2022 22:43:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=H3ak+uekY7aCjcSpcmVNhchL/wsk2A29TLQPy5iTm8s=; b=VVi3juLX5TSvnI3mu8J6o72uNc KmPGLPnuhruJG81E6EA6nGnVRaXNcObv/B9OWTRNjVbxLg+3W+tZM9GC2ckjiDMFKF78AJoZwfyES mP2bBPZUsD5B6zYnPjk6io3FSQA6KdCNHj2wtINXnkagirRAWlkVbAzjetoe68Ce08pU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171545: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c X-Osstest-Versions-That: xen=4df2e99d731402da48afb19dc970ccab5a0814d6 From: osstest service owner Date: Thu, 07 Jul 2022 22:43:24 +0000 flight 171545 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171545/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171516 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171516 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171516 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171516 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171516 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171516 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171516 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c baseline version: xen 4df2e99d731402da48afb19dc970ccab5a0814d6 Last test of basis 171516 2022-07-06 01:53:06 Z 1 days Testing same since 171536 2022-07-06 18:36:51 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Charles Arnold Demi Marie Obenour Jan Beulich Julien Grall Luca Fancellu Michal Orzel Roger Pau Monne Roger Pau Monné Wei Chen Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 4df2e99d73..46cbd76faf 46cbd76faf737e9fe2d57aaf335a0203f66ba21c -> master From xen-devel-bounces@lists.xenproject.org Thu Jul 07 23:06:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 23:06:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363173.593600 (Exim 4.92) (envelope-from ) id 1o9aZN-0004Uj-Us; Thu, 07 Jul 2022 23:06:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363173.593600; Thu, 07 Jul 2022 23:06:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aZN-0004Uc-Rd; Thu, 07 Jul 2022 23:06:01 +0000 Received: by outflank-mailman (input) for mailman id 363173; Thu, 07 Jul 2022 23:06:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aZM-0004To-Tk for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 23:06:00 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5ca17637-fe49-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 01:05:59 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C2BA062566; Thu, 7 Jul 2022 23:05:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 958C0C3411E; Thu, 7 Jul 2022 23:05:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5ca17637-fe49-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657235157; bh=dtDnyWtSQJjQ8WCmaFr9PdN8QwjA48vU0zaGYtPsEPo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=NN/O8oZFpyzr+vqMgi7GBQVoLX2AhRd4reAFYvV+sl2dQ/+/FqCk6bbmd1bCu/Niy HuMU2406JWd375D5ubJENg7Dj3hnWkdGm3EXeyHLpa8S3HDlnQPg7ufmejANecIQuA x4+KHgUDoMElxLNWJd2ccsgxASKj0ED+1O+79yPlRY1z0ivb8mMckO79Kfz0wIi23c LgOnTdDYWIRWCfmnMHJ/OZwC535RqPlNBeTdULLwP2NCgy5+UqhBIwy845e+6srxoA 7pN2HnEAG2/PsMgvS5lgBBh+zsRiusQtgJgYG8v8c1eJ5k4yQbo8BGLcV7VO1Q798w LkvisH/VIZMrQ== Date: Thu, 7 Jul 2022 16:05:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 1/2] automation: Remove XEN_CONFIG_EXPERT leftovers In-Reply-To: <20220707203803.798317-2-burzalodowa@gmail.com> Message-ID: References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-2-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 7 Jul 2022, Xenia Ragiadakou wrote: > The EXPERT config option cannot anymore be selected via the environmental > variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT > from the automation code. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > automation/build/README.md | 3 --- > automation/scripts/build | 4 ++-- > automation/scripts/containerize | 1 - > 3 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/automation/build/README.md b/automation/build/README.md > index 2137957408..00305eed03 100644 > --- a/automation/build/README.md > +++ b/automation/build/README.md > @@ -65,9 +65,6 @@ understands. > - CONTAINER_NO_PULL: If set to 1, the script will not pull from docker hub. > This is useful when testing container locally. > > -- XEN_CONFIG_EXPERT: If this is defined in your shell it will be > - automatically passed through to the container. > - > If your docker host has Linux kernel > 4.11, and you want to use containers > that run old glibc (for example, CentOS 6 or SLES11SP4), you may need to add > > diff --git a/automation/scripts/build b/automation/scripts/build > index 281f8b1fcc..21b3bc57c8 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -91,6 +91,6 @@ for cfg in `ls ${cfg_dir}`; do > echo "Building $cfg" > make -j$(nproc) -C xen clean > rm -f xen/.config > - make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig > - make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y > + make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig > + make -j$(nproc) -C xen > done > diff --git a/automation/scripts/containerize b/automation/scripts/containerize > index 8992c67278..9d4beca4fa 100755 > --- a/automation/scripts/containerize > +++ b/automation/scripts/containerize > @@ -101,7 +101,6 @@ exec ${docker_cmd} run \ > -v "${CONTAINER_PATH}":/build:rw${selinux} \ > -v "${HOME}/.ssh":/root/.ssh:ro \ > ${SSH_AUTH_DIR:+-v "${SSH_AUTH_DIR}":/tmp/ssh-agent${selinux}} \ > - ${XEN_CONFIG_EXPERT:+-e XEN_CONFIG_EXPERT=${XEN_CONFIG_EXPERT}} \ > ${CONTAINER_ARGS} \ > -${termint}i --rm -- \ > ${CONTAINER} \ > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 07 23:06:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 07 Jul 2022 23:06:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363172.593589 (Exim 4.92) (envelope-from ) id 1o9aZJ-0004EO-NU; Thu, 07 Jul 2022 23:05:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363172.593589; Thu, 07 Jul 2022 23:05:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aZJ-0004EH-Jy; Thu, 07 Jul 2022 23:05:57 +0000 Received: by outflank-mailman (input) for mailman id 363172; Thu, 07 Jul 2022 23:05:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9aZI-0004EB-5a for xen-devel@lists.xenproject.org; Thu, 07 Jul 2022 23:05:56 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59bf94b0-fe49-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 01:05:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D880F6252C; Thu, 7 Jul 2022 23:05:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89AECC3411E; Thu, 7 Jul 2022 23:05:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59bf94b0-fe49-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657235152; bh=9lg32DJ7cCwO6cGDJQOrQIYXC3O10m8zQ5zw+9wtk78=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dUMuHYx4LYhyyRnFdEGABuQI6OLj5NP1cJPti3xhCgR8NPdD0AxbDLIdtGtawvLo2 YyEy+hT7fTsUAAyZ1ZSD+AQMG99pr+1ZFcvtK/X++fBR9l+ObRL5P1MCWUF8SrHp7t qbKSBsPz2miDluElQgM0d3lQRoKwp1M7UfoQVT6zv7lfCqcoMUnmpi5EHhEvfZuwAO YgWgcL4du7NyhPPBXguVprDEjBg/LDYwkiXcFB2hCA9hVJJWQpSK28Td6RWWxbaVDi FCFOT5TOiUFlXC2nWVeo4PaLDAJ25euOIGVAcLbQRRvZZzzpXdxYMQeb/3bLxXsCuf 1w/c9s7okB4Vg== Date: Thu, 7 Jul 2022 16:05:49 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Xenia Ragiadakou , xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu In-Reply-To: <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> Message-ID: References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 7 Jul 2022, Julien Grall wrote: > Hi Xenia, > > On 07/07/2022 21:38, Xenia Ragiadakou wrote: > > Add an arm subdirectory under automation/configs for the arm specific > > configs > > and add a config that enables static allocation. > > > > Modify the build script to search for configs also in this subdirectory and > > to > > keep the generated xen binary, suffixed with the config file name, as > > artifact. > > > > Create a test job that > > - boots xen on qemu with a single direct mapped dom0less guest configured > > with > > statically allocated memory > > - verifies that the memory ranges reported in the guest's logs are the same > > with the provided static memory regions > > > > For guest kernel, use the 5.9.9 kernel from the tests-artifacts containers. > > Use busybox-static package, to create the guest ramdisk. > > To generate the u-boot script, use ImageBuilder. > > Use the qemu from the tests-artifacts containers. > > > > Signed-off-by: Xenia Ragiadakou > > --- > > automation/configs/arm/static_mem | 3 + > > automation/gitlab-ci/test.yaml | 24 +++++ > > automation/scripts/build | 4 + > > automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ > > 4 files changed, 145 insertions(+) > > create mode 100644 automation/configs/arm/static_mem > > create mode 100755 automation/scripts/qemu-staticmem-arm64.sh > > > > diff --git a/automation/configs/arm/static_mem > > b/automation/configs/arm/static_mem > > new file mode 100644 > > index 0000000000..84675ddf4e > > --- /dev/null > > +++ b/automation/configs/arm/static_mem > > @@ -0,0 +1,3 @@ > > +CONFIG_EXPERT=y > > +CONFIG_UNSUPPORTED=y > > +CONFIG_STATIC_MEMORY=y > > \ No newline at end of file > > Any particular reason to build a new Xen rather enable CONFIG_STATIC_MEMORY in > the existing build? > > > diff --git a/automation/scripts/build b/automation/scripts/build > > index 21b3bc57c8..9c6196d9bd 100755 > > --- a/automation/scripts/build > > +++ b/automation/scripts/build > > @@ -83,6 +83,7 @@ fi > > # Build all the configs we care about > > case ${XEN_TARGET_ARCH} in > > x86_64) arch=x86 ;; > > + arm64) arch=arm ;; > > *) exit 0 ;; > > esac > > @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do > > rm -f xen/.config > > make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig > > make -j$(nproc) -C xen > > + if [[ ${arch} == "arm" ]]; then > > + cp xen/xen binaries/xen-${cfg} > > + fi > > This feels a bit of a hack to be arm only. Can you explain why this is not > enabled for x86 (other than this is not yet used)? > > > done > > diff --git a/automation/scripts/qemu-staticmem-arm64.sh > > b/automation/scripts/qemu-staticmem-arm64.sh > > new file mode 100755 > > index 0000000000..5b89a151aa > > --- /dev/null > > +++ b/automation/scripts/qemu-staticmem-arm64.sh > > @@ -0,0 +1,114 @@ > > +#!/bin/bash > > + > > +base=(0x50000000 0x100000000) > > +size=(0x10000000 0x10000000) > > From the name, it is not clear what the base and size refers too. Looking a > bit below, it seems to be referring to the domain memory. If so, I would > suggest to comment and rename to "domu_{base, size}". > > > + > > +set -ex > > + > > +apt-get -qy update > > +apt-get -qy install --no-install-recommends u-boot-qemu \ > > + u-boot-tools \ > > + device-tree-compiler \ > > + cpio \ > > + curl \ > > + busybox-static > > + > > +# DomU Busybox > > +cd binaries > > +mkdir -p initrd > > +mkdir -p initrd/bin > > +mkdir -p initrd/sbin > > +mkdir -p initrd/etc > > +mkdir -p initrd/dev > > +mkdir -p initrd/proc > > +mkdir -p initrd/sys > > +mkdir -p initrd/lib > > +mkdir -p initrd/var > > +mkdir -p initrd/mnt > > +cp /bin/busybox initrd/bin/busybox > > +initrd/bin/busybox --install initrd/bin > > +echo "#!/bin/sh > > + > > +mount -t proc proc /proc > > +mount -t sysfs sysfs /sys > > +mount -t devtmpfs devtmpfs /dev > > +/bin/sh" > initrd/init > > +chmod +x initrd/init > > +cd initrd > > +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz > > +cd ../.. > > + > > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > > +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > > + > > +./binaries/qemu-system-aarch64 -nographic \ > > + -M virtualization=true \ > > + -M virt \ > > + -M virt,gic-version=2 \ > > + -cpu cortex-a57 \ > > + -smp 2 \ > > + -m 8G \ > > + -M dumpdtb=binaries/virt-gicv2.dtb > > + > > +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > > + > > +# ImageBuilder > > +rm -rf imagebuilder > > +git clone https://gitlab.com/ViryaOS/imagebuilder > > + > > +echo "MEMORY_START=\"0x40000000\" > > +MEMORY_END=\"0x0200000000\" > > + > > +DEVICE_TREE=\"virt-gicv2.dtb\" > > + > > +XEN=\"xen-static_mem\" > > +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" > > AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is also not > clear why you need to pass xsm=dummy. > > > + > > +NUM_DOMUS=1 > > +DOMU_MEM[0]=512 > > +DOMU_VCPUS[0]=1 > > +DOMU_KERNEL[0]=\"Image\" > > +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" > > +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" > > +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" > > + > > +UBOOT_SOURCE=\"boot.source\" > > +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config > > + > > +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c > > binaries/imagebuilder_config > > + > > +# Run the test > > +rm -f qemu-staticmem.serial > > +set +e > > +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ > > +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ > > + -M virtualization=true \ > > + -M virt \ > > + -M virt,gic-version=2 \ > > + -cpu cortex-a57 \ > > + -smp 2 \ > > + -m 8G \ > > + -no-reboot \ > > + -device virtio-net-pci,netdev=vnet0 -netdev user,id=vnet0,tftp=binaries > > \ > > + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ > > + -dtb ./binaries/virt-gicv2.dtb \ > > + |& tee qemu-staticmem.serial > > + > > +set -e > > A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it > would be better to consolidate in a single script. Looking briefly throught > the existing scripts, it looks like it is possible to pass arguments (see > qemu-smoke-x86-64.sh). One idea would be to make the script common and "source" a second script or config file with just the ImageBuilder configuration because it looks like it is the only thing different. > > + > > +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 > > + > > +for ((i=0; i<${#base[@]}; i++)) > > +do > > + start="$(printf "0x%016x" ${base[$i]})" > > + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" > > + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial > > + if test $? -eq 1 > > + then > > + exit 1 > > + fi > > +done > > Please add a comment on top to explain what this is meant to do. However, I > think we should avoid relying on output that we have written ourself. IOW, > relying on Xen/Linux to always write the same message is risky because they > can change at any time. Especially if we make the script common, then we could just rely on the existing check to see if the guest started correctly (no special check for static memory). > > + > > +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 02:11:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 02:11:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363184.593611 (Exim 4.92) (envelope-from ) id 1o9dSb-0001Vs-LN; Fri, 08 Jul 2022 02:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363184.593611; Fri, 08 Jul 2022 02:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9dSb-0001Vl-IO; Fri, 08 Jul 2022 02:11:13 +0000 Received: by outflank-mailman (input) for mailman id 363184; Fri, 08 Jul 2022 02:11:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9dSZ-0001U4-W5 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 02:11:12 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39750b96-fe63-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 04:11:08 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C4ED45C003F; Thu, 7 Jul 2022 22:11:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 07 Jul 2022 22:11:05 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 7 Jul 2022 22:11:03 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39750b96-fe63-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657246265; x= 1657332665; bh=CeQunBe4w1VGTt4GuoiqTtPLvP2BEXgJ6msZnCmtVzQ=; b=N 4zHrz6BZgjd5kJ7+1I+5srCpYpWn0fphaJ4miA0he6HJj7GO7YK2fvO9087WcJdt bMJW8GzGD5K09PNAXWRH81REeDMDLPh6thOsWWP8PA/ixLvV1znZ7VE0HVq9al41 obEg1DlKPSCuqUSj6m6xqx3RdXkWzU1ml0+pffiJE/CwjWoCnggLjHCBVd7E9rwc RijqhTl0JpZh7PRfyW01BYhNySrjkKOZRsMQAwZJzrsfuQqwCfqTix/AVg+AAXtl iMXXDoCC+eUIx6kNxOvzurLGIy5shztj0fA+2n3aAKTOIXIbkMIF8w4VF7YH6nzN /hu/66s1vdybO98p7BTXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657246265; x=1657332665; bh=CeQunBe4w1VGTt4GuoiqTtPLvP2B EXgJ6msZnCmtVzQ=; b=ZckhRdQIo5RACvC6c7bRPs5/d8fX7dqQZxqERy3BhPMg Wk8qZigTrmSFSZ4lo0ZrwUQtyN777uxyahn9Bb9TRASYEtw4yg93wUFkOHJKf0nH DcrCepW6IwJMMoWdITlMAo91jvYmsTMH7OwiYi5W8t9GRBidsh3nfvocyJbxeQpw CepQjbYDv3UjCuf7bjBNVaU45OuB3cj0XEM9CN8JbGFhbftqTbO6IgRTY3I3fIcs 6a7QGA+HfrGsSSfSVMSVwdz+v16jmVNV7wGBGJXAHEpyzIxYQ7jxPRNXmtr1h4Ur /ZFMHGcvmuQfFT76/YBb8AetztajnoeqWmkLonpe0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeiiedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdet vdfhkedutedvleffgeeutdektefhtefhfffhfeetgefhieegledvtddtkedtnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Fri, 8 Jul 2022 04:11:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="en7IelQQO5RTp+SB" Content-Disposition: inline In-Reply-To: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> --en7IelQQO5RTp+SB Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Fri, 8 Jul 2022 04:11:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger On Wed, Jul 06, 2022 at 05:32:06PM +0200, Marek Marczykowski-G=C3=B3recki w= rote: > diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig > index e5f7b1d8eb8a..d12b2205dafc 100644 > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -74,3 +74,12 @@ config HAS_EHCI > help > This selects the USB based EHCI debug port to be used as a UART. If > you have an x86 based system with USB, say Y. > + > +config HAS_XHCI > + bool "XHCI DbC UART driver" > + depends on X86 > + help > + This selects the USB based XHCI debug capability to be used as a UART. > + Enabling this option makes Xen use extra ~2MB memory, even if XHCI UA= RT My math sucks here... 58 pages is 232KiB. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --en7IelQQO5RTp+SB Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLHkjUACgkQ24/THMrX 1yzhGwf9HiTmRjBJ4SHproDDDg+2QMARzDTcqfXes1yTylDUxoTeBi9R1nJdSYIn ZV9ZBbt2xU+oW0xkEwewbeBE+Z1xpGGAy0N7z9Eof+mxrC2oX4sIrodSw7lCXioi JXifBKe2WMPKDC8IaOsVaIacR4/O+KMChfLj3RisNxPdIvWPSXJ2Gqx35kXWVvjV m18bkGtg9JJtnFCekfIVd0NRWv/vP+/j9z1SoDnWisUp5/nz1G7ZE4bN+mWkW/Nm 3YxBbNmPZK6Pk6ikc0iLrj3vcHSCMe8W/MFLcclC0FJ9Xw4F+gX5GOiTdMCKtiCx 43gbuVLwGfIE9tdX81p1R4dzU2Z2wA== =rlMM -----END PGP SIGNATURE----- --en7IelQQO5RTp+SB-- From xen-devel-bounces@lists.xenproject.org Fri Jul 08 02:29:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 02:29:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363193.593622 (Exim 4.92) (envelope-from ) id 1o9djx-0003io-BL; Fri, 08 Jul 2022 02:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363193.593622; Fri, 08 Jul 2022 02:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9djx-0003ih-6T; Fri, 08 Jul 2022 02:29:09 +0000 Received: by outflank-mailman (input) for mailman id 363193; Fri, 08 Jul 2022 02:29:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9djv-0003iY-Qq for xen-devel@lists.xen.org; Fri, 08 Jul 2022 02:29:07 +0000 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bcb103d2-fe65-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 04:29:06 +0200 (CEST) Received: by mail-ej1-f46.google.com with SMTP id u15so11024172ejx.9 for ; Thu, 07 Jul 2022 19:29:05 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcb103d2-fe65-11ec-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8vRMTEoe5E+ukqrDk6mXa763umsMszb5H3XKeVL2Zrk=; b=lfibtCZkBgCAU59J7+g/vOum2kbb8VxXgoKMSOdQc59FUs/Au9p2jzhF0yjBQEaO5s Oen1fLmXkMulzVSqUtK8I/eX73Rv+geOY9Atpj99kgcAvnvXpxAfTME43MQmsy0W491S y76U1DnmP+AS86OEVDMMM6SfGxouWrPiDU1/ihJ0zHLxj+D63PqojQna6GMnpnwgyz3v NCVE2EK5C9B6mFhrq1RjsZxkumN05KvhvUapZHiGZy/VeBllPnrect54OU5vpAa6DyNt inLYhb2Bd4gYSJvOCAYz7q0Wb2ZDfLd+lbUHrW+512QD+iRsLzfKP8okCBp7NqQ9c3IF JPog== X-Gm-Message-State: AJIora+873JIE4DnLnmog+hauQm5gSsZmwYFkN5JHeQdCDTyUcT3kCSb YFhlNMvo5AvrvtutJLuYNtAtBT/FlcEm/5WjIo0kieg8/2g= X-Google-Smtp-Source: AGRyM1s3BL1HsKMX/YujdcpJjgjjaAxFGZhF+l2Ha46HSeAMFN9jhhRtrp/01+vPzzKCLsQN6h/yZTXKi3umfcna9bc= X-Received: by 2002:a17:907:2814:b0:72a:3758:e948 with SMTP id eb20-20020a170907281400b0072a3758e948mr1261665ejc.8.1657247344904; Thu, 07 Jul 2022 19:29:04 -0700 (PDT) MIME-Version: 1.0 References: <93c7b016-06f9-e3d2-5a7f-97a5f15c1a86@suse.com> In-Reply-To: <93c7b016-06f9-e3d2-5a7f-97a5f15c1a86@suse.com> From: "G.R." Date: Fri, 8 Jul 2022 10:28:52 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony Perard Content-Type: text/plain; charset="UTF-8" On Fri, Jul 8, 2022 at 12:38 AM Jan Beulich wrote: > > On 07.07.2022 17:24, G.R. wrote: > > On Wed, Jul 6, 2022 at 2:33 PM Jan Beulich wrote: > >> > >> On 06.07.2022 08:25, G.R. wrote: > >>> On Tue, Jul 5, 2022 at 7:59 PM Jan Beulich wrote: > >>>> Nothing useful in there. Yet independent of that I guess we need to > >>>> separate the issues you're seeing. Otherwise it'll be impossible to > >>>> know what piece of data belongs where. > >>> Yep, I think I'm seeing several different issues here: > >>> 1. The FLR related DPC / AER message seen on the 1st attempt only when > >>> pciback tries to seize and release the SN570 > >>> - Later-on pciback operations appear just fine. > >>> 2. MSI-X preparation failure message that shows up each time the SN570 > >>> is seized by pciback or when it's passed to domU. > >>> 3. XEN tries to map BAR from two devices to the same page > >>> 4. The "write-back to unknown field" message in QEMU log that goes > >>> away with permissive=1 passthrough config. > >>> 5. The "irq 16: nobody cared" message shows up *sometimes* in a > >>> pattern that I haven't figured out (See attached) > >>> 6. The FreeBSD domU sees the device but fails to use it because low > >>> level commands sent to it are aborted. > >>> 7. The device does not return to the pci-assignable-list when the domU > >>> it was assigned shuts-down. (See attached) > >>> > >>> #3 appears to be a known issue that could be worked around with > >>> patches from the list. > >>> I suspect #1 may have something to do with the device itself. It's > >>> still not clear if it's deadly or just annoying. > >>> I was able to update the firmware to the latest version and confirmed > >>> that the new firmware didn't make any noticeable difference. > >>> > >>> I suspect issue #2, #4, #5, #6, #7 may be related, and the > >>> pass-through was not completely successful... > >>> > >>> Should I expect a debug build of XEN hypervisor to give better > >>> diagnose messages, without the debug patch that Roger mentioned? > >> > >> Well, "expect" is perhaps too much to say, but with problems like > >> yours (and even more so with multiple ones) using a debug > >> hypervisor (or kernel, if there such a build mode existed) is imo > >> always a good idea. As is using as up-to-date a version as > >> possible. > > > > I built both 4.14.3 debug version and 4.16.1 release version for > > testing purposes. > > Unfortunately they gave me absolutely zero information, since both of > > them are not able to get through issue #1 > > the FlR related DPC / AER issue. > > With 4.16.1 release, it actually can survive the 'xl > > pci-assignable-add' which triggers the first AER failure. > > Then that's what needs debugging first. Yet from all I've seen so > far I'm not sure who one the Xen side could be doing that, the more > without themselves being able to repro - this seems more like a > Linux side issue (and even outside of the pciback driver). > Yep, this one is likely not XEN related, as I've seen some discussions ([1],[2]) on similar syndrome (not necessarily same root cause though). The question is why this only shows up during the FLR attempt and if following pci-assignable-adds that do not trigger the error are actually reliable. BTW, I'm under the impression that the device is still usable in dom0 afterwards, I'll have to double check though... [1] https://patchwork.kernel.org/project/linux-pci/patch/20220408153159.106741-1-kai.heng.feng@canonical.com/ [2] https://patchwork.kernel.org/project/linux-pci/patch/20220127025418.1989642-1-kai.heng.feng@canonical.com/#24713767 > > But the 'xl pci-assignable-remove' will lead to xl segmentation fault... > >> [ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] > >> [ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 > > That'll need debugging. Cc-ing Anthony for awareness, but I'm sure > he'll need more data to actually stand a chance of doing something > about it. > > Is there any chance you could be doing some debugging work yourself, > at the very least to figure out where this (apparent) NULL deref is > happening? Yep, I can collect the call-stack for sure. > > Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 08 02:59:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 02:59:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363201.593633 (Exim 4.92) (envelope-from ) id 1o9eCz-0000bX-Ox; Fri, 08 Jul 2022 02:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363201.593633; Fri, 08 Jul 2022 02:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9eCz-0000bQ-Ln; Fri, 08 Jul 2022 02:59:09 +0000 Received: by outflank-mailman (input) for mailman id 363201; Fri, 08 Jul 2022 02:59:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9eCy-0000bD-Qs; Fri, 08 Jul 2022 02:59:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9eCy-0008PM-OL; Fri, 08 Jul 2022 02:59:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9eCy-0001dC-AD; Fri, 08 Jul 2022 02:59:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9eCy-0003B0-9Z; Fri, 08 Jul 2022 02:59:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hTSR0r4AuCBSpZK+2gRi/FpUv1MlFMBfIFEGbdMepD8=; b=H0TWSp3D8FMq3AuizKcZkJR5P3 RpBe0dlmIu/K9L+AYCKBmreBO3y2eQ2oyG5J/mwbKsDdz/UZkpmwoJde8stP8jtQv0mD61KINU4gA fFNYukXSGFIhy11n7s/3jOi42IKsIrTk9DaDRZvF6iN3C5t+gyjHrWtOIThQc2Z0cFFU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171547: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9f09069cde34dcd86f5ecf3a3139fd752020812f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Fri, 08 Jul 2022 02:59:08 +0000 flight 171547 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171547/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 9f09069cde34dcd86f5ecf3a3139fd752020812f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 18 days Failing since 171280 2022-06-19 15:12:25 Z 18 days 49 attempts Testing same since 171537 2022-07-06 22:42:57 Z 1 days 3 attempts ------------------------------------------------------------ 499 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 20617 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 08 04:13:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 04:13:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363208.593644 (Exim 4.92) (envelope-from ) id 1o9fMW-0003dR-6p; Fri, 08 Jul 2022 04:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363208.593644; Fri, 08 Jul 2022 04:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9fMW-0003dK-30; Fri, 08 Jul 2022 04:13:04 +0000 Received: by outflank-mailman (input) for mailman id 363208; Fri, 08 Jul 2022 04:13:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9fMU-0003dE-La for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 04:13:02 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 41047b32-fe74-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 06:13:00 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D01331FE05; Fri, 8 Jul 2022 04:12:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 868D3134A9; Fri, 8 Jul 2022 04:12:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 5uZhH8uux2KpTQAAMHmgww (envelope-from ); Fri, 08 Jul 2022 04:12:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 41047b32-fe74-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657253579; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=lrzw+Qqdip2nsfCNq9eOVaFJTXPMdrkiCgFxrgCBoiA=; b=O6X9HOHcY9G35+fQFSQhSv9s+e10W9RDexLSKAuAi1cEnrpUvWKV6RxX7jzxW7yM3R7+fq B3v3KTm7B58wrd1jN5+E5OgE0l2SqCK2wnyYhlxYbnDofX6NYp0rE+B+NEqpfLIxoFVKDp P2resB3vd317lb19CR5MEU+xVxdkHp4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Henry.Wang@arm.com, Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] docs: add reference to release cycle discussion Date: Fri, 8 Jul 2022 06:12:58 +0200 Message-Id: <20220708041258.10349-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit As it is coming up basically every release cycle of Xen, add a reference to the discussion why the current release scheme has been selected in the release management documentation. Signed-off-by: Juergen Gross --- docs/process/xen-release-management.pandoc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/process/xen-release-management.pandoc b/docs/process/xen-release-management.pandoc index b746c7157d..8f80d61d2f 100644 --- a/docs/process/xen-release-management.pandoc +++ b/docs/process/xen-release-management.pandoc @@ -19,6 +19,8 @@ The Xen hypervisor project now releases every 8 months. We aim to release in the first half of March/July/November. These dates have been chosen to avoid major holidays and cultural events; if one release slips, ideally the subsequent release cycle would be shortened. +The reasons for this schedule have been discussed on +[xen-devel](https://lists.xen.org/archives/html/xen-devel/2018-07/msg02240.html). We can roughly divide one release into two periods. The development period and the freeze period. The former is 6 months long and the latter is about 2 -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 06:18:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 06:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363215.593655 (Exim 4.92) (envelope-from ) id 1o9hJM-00057F-Ap; Fri, 08 Jul 2022 06:17:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363215.593655; Fri, 08 Jul 2022 06:17:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hJM-000578-81; Fri, 08 Jul 2022 06:17:56 +0000 Received: by outflank-mailman (input) for mailman id 363215; Fri, 08 Jul 2022 06:17:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hJK-00056y-At; Fri, 08 Jul 2022 06:17:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hJK-000493-8M; Fri, 08 Jul 2022 06:17:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hJJ-0003vS-Mk; Fri, 08 Jul 2022 06:17:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9hJJ-0005Ef-MG; Fri, 08 Jul 2022 06:17:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RJmSdFlGNM6w2j/olKXmb3vZJUQRoTg39/L2prrMIeQ=; b=aMmCWJpo021LEBJsMuRfiDjddd poWtwbl9Y0c5HavRyMehhMRUHqaH/EIwaVtzyiaOTt9v3gg56zNNMCTdcb5V+FAfygZVITO1VFjwn YJlZQAiBBfsJ13FEQziUfS9wxPZTsvG3paXs4ESZV/iRqpQ/Y8H1/7lOwRq8+VFUxwdc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171554: all pass - PUSHED X-Osstest-Versions-This: ovmf=e93bc6309ba743c6bdaae4d1dc6f0fb141c47ee5 X-Osstest-Versions-That: ovmf=5496c763aaddc4a47639d4652abe23aa3419263a From: osstest service owner Date: Fri, 08 Jul 2022 06:17:53 +0000 flight 171554 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171554/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e93bc6309ba743c6bdaae4d1dc6f0fb141c47ee5 baseline version: ovmf 5496c763aaddc4a47639d4652abe23aa3419263a Last test of basis 171546 2022-07-07 10:42:07 Z 0 days Testing same since 171554 2022-07-08 04:10:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Isaac Oram Oram, Isaac W jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5496c763aa..e93bc6309b e93bc6309ba743c6bdaae4d1dc6f0fb141c47ee5 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 08 06:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 06:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363224.593666 (Exim 4.92) (envelope-from ) id 1o9hYD-00007n-O8; Fri, 08 Jul 2022 06:33:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363224.593666; Fri, 08 Jul 2022 06:33:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hYD-00007f-Jb; Fri, 08 Jul 2022 06:33:17 +0000 Received: by outflank-mailman (input) for mailman id 363224; Fri, 08 Jul 2022 06:33:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hYC-00007V-ED; Fri, 08 Jul 2022 06:33:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hYC-0004PH-7q; Fri, 08 Jul 2022 06:33:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9hYB-0004ch-LU; Fri, 08 Jul 2022 06:33:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9hYB-0004YV-L5; Fri, 08 Jul 2022 06:33:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FJkMnSwFWZUS0s+1L8YZEO47ml4rHofBdJw1iep9n6c=; b=hjGavZw11R/OkbcfmbJKQ3wJYK uuSrsbANBsHo6QnRJ6h0ypGMOoaMs5q7HApPAChvm/OhdmCOh/cqYfgQXpchH/8BLBXM9YkucCzdM uvh1gx2fZSm6CDErPZI23RYtoBghZ2abZuablsebVl4UcQ8A11mob8vTn4L89Iz/s+g8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171548: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-examine:xen-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 X-Osstest-Versions-That: linux=871cbc208bf0aded1946cd1e3eebec75799d31e8 From: osstest service owner Date: Fri, 08 Jul 2022 06:33:15 +0000 flight 171548 linux-5.4 real [real] flight 171556 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171548/ http://logs.test-lab.xenproject.org/osstest/logs/171556/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171556-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171460 test-armhf-armhf-xl-credit2 14 guest-start fail like 171460 test-amd64-i386-examine 6 xen-install fail like 171465 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171465 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171465 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171465 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171465 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171465 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171465 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171465 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171465 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171465 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171465 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171465 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171465 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171465 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 baseline version: linux 871cbc208bf0aded1946cd1e3eebec75799d31e8 Last test of basis 171465 2022-07-03 03:28:58 Z 5 days Testing same since 171548 2022-07-07 15:41:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Gordeev Bjørn Mork Carlo Lobrano Chanwoo Choi Chris Ye Chuck Lever Dan Williams Daniele Palmas David S. Miller Demi Marie Obenour Dimitris Michailidis Dimitris Michailidis Doug Berger Duoming Zhou Eric Dumazet Florian Fainelli Greg Kroah-Hartman Guenter Roeck Heiko Carstens Heinz Mauelshagen Hulk Robot Jakub Kicinski Jamal Hadi Salim Jason A. Donenfeld Jason Gunthorpe Jason Wang Jay Vosburgh Jon Hunter Jose Alonso Juergen Gross Kamal Heib katrinzhou kernel test robot Krzysztof Kozlowski Leon Romanovsky Liam Howlett Liam R. Howlett Linux Kernel Functional Testing Maksym Glubokiy Masahiro Yamada Mathieu Desnoyers Miaoqian Lin Michael Ellerman Michael S. Tsirkin Michael Walle Michal Kalderon  Mike Snitzer Mikulas Patocka Naveen N. Rao Nicolas Dichtel Oleksandr Tyshchenko Oliver Neukum Pablo Neira Ayuso Paolo Abeni Petar Penkov Peter Oskolkov Peter Zijlstra (Intel) Roger Pau Monne Roger Pau Monné Sasha Levin Shuah Khan Sudip Mukherjee Tao Liu Victor Nogueira Willem de Bruijn Yang Yingliang Yevhen Orlov YueHaibing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 871cbc208bf0..49286fbdad47 49286fbdad47ecca61a4818e77bd0aced7f59383 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:17:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:17:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363237.593677 (Exim 4.92) (envelope-from ) id 1o9iEr-0006WR-SS; Fri, 08 Jul 2022 07:17:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363237.593677; Fri, 08 Jul 2022 07:17:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iEr-0006WK-Oc; Fri, 08 Jul 2022 07:17:21 +0000 Received: by outflank-mailman (input) for mailman id 363237; Fri, 08 Jul 2022 07:17:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iEr-0006WE-AH for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:17:21 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0106ec52-fe8e-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:17:20 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id ez10so6073011ejc.13 for ; Fri, 08 Jul 2022 00:17:19 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id 18-20020a170906329200b0072abb95eaa4sm7619472ejw.215.2022.07.08.00.17.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 00:17:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0106ec52-fe8e-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=AEU1mSHIXvqqwylw0IB3U4Ad98mWiw0OJkgCFIwOnAQ=; b=kc4ggJq1LKJVjKAWoHzmF17AHeWJadER1Y6af3Rlv0RyA/YavTqgpStE4/lsEXD1kr tscGi5MdK0Waagnu8YlGDt+UovFE1hO33Ev4tHFOtSVj4X9u/7wz5MKHls0VHy9LVOL+ 1SOElqAR2pruJMhlgxH77gu6Fxz08s7sc2P9QrkwXIT1z8AvsfzddqbecA4T8XHhVvz5 evZGzRlGxkI1ccTbValaQZeXaaL2++nLuexGOEjy07PKCGtjYbr0K4SU1ou7DjU479NT PJAAgPdnveIYUKFR/4dNItXMnuxUTCtShOzG7o7UVq+XdALhMmygTsF9fCddaoNi55sp gtEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=AEU1mSHIXvqqwylw0IB3U4Ad98mWiw0OJkgCFIwOnAQ=; b=3ZeUxoBnz9bWMuYkumqGIRiUuB5TzWYBLc3LSXK9XOwPbrP0IuhDRbbes+7m0LmdWf iFCIf7zuCJTmxJLo/+o0L+rAOas70AXD/GZAJzbwNKQR5pCJDR7bHZ51/QHN4m6orYyG tC6lCec/66tZv8lEiE7/Ize1bvkw3YW6OaaTdNcmiZ9pIvM+wS7aLP3lreqkgdsGDd4b /dVuVOjLD432UkIz82bnLdaDeXOtlnVGtmw3v+EKk5KLK/obDmBTQ0eCqMJeQDXmKY1J 7DUR300TPVHg/od5VE20h37o4+VIssUHTaM7Vwg629UwxEj5e4QjlOInCz5S+U3dwGWE dLEA== X-Gm-Message-State: AJIora8TPRLMODo9PSuTuh5PUShJVhpZaU7eKVDKa2bF60FCi5FkVIog axD79V4hTQUeN6Doy/C1cL3hvTLmoxE= X-Google-Smtp-Source: AGRyM1t4N0LY6yBx8oPChURkWOlD3O06cJbsjzXl9wmRNRL/1AR2izIa0DPKM+jm66TSipRopBRuPg== X-Received: by 2002:a17:907:d15:b0:72b:1718:59be with SMTP id gn21-20020a1709070d1500b0072b171859bemr2092202ejc.349.1657264639373; Fri, 08 Jul 2022 00:17:19 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 10:17:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Xenia Ragiadakou In-Reply-To: <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 7/8/22 01:26, Julien Grall wrote: > Hi Xenia, > > On 07/07/2022 21:38, Xenia Ragiadakou wrote: >> Add an arm subdirectory under automation/configs for the arm specific >> configs >> and add a config that enables static allocation. >> >> Modify the build script to search for configs also in this >> subdirectory and to >> keep the generated xen binary, suffixed with the config file name, as >> artifact. >> >> Create a test job that >> - boots xen on qemu with a single direct mapped dom0less guest >> configured with >> statically allocated memory >> - verifies that the memory ranges reported in the guest's logs are the >> same >> with the provided static memory regions >> >> For guest kernel, use the 5.9.9 kernel from the tests-artifacts >> containers. >> Use busybox-static package, to create the guest ramdisk. >> To generate the u-boot script, use ImageBuilder. >> Use the qemu from the tests-artifacts containers. >> >> Signed-off-by: Xenia Ragiadakou >> --- >>   automation/configs/arm/static_mem          |   3 + >>   automation/gitlab-ci/test.yaml             |  24 +++++ >>   automation/scripts/build                   |   4 + >>   automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ >>   4 files changed, 145 insertions(+) >>   create mode 100644 automation/configs/arm/static_mem >>   create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >> >> diff --git a/automation/configs/arm/static_mem >> b/automation/configs/arm/static_mem >> new file mode 100644 >> index 0000000000..84675ddf4e >> --- /dev/null >> +++ b/automation/configs/arm/static_mem >> @@ -0,0 +1,3 @@ >> +CONFIG_EXPERT=y >> +CONFIG_UNSUPPORTED=y >> +CONFIG_STATIC_MEMORY=y >> \ No newline at end of file > > Any particular reason to build a new Xen rather enable > CONFIG_STATIC_MEMORY in the existing build IIUC, the xen binary (built with the arm64_defconfig) is used by the two other arm64 test jobs qemu-smoke-arm64-gcc and qemu-alpine-arm64-gcc. I did not want to change its configuration. If there is no issue with changing its configuration, I can enable static memory and use this one. But to be honest, I would like to be able also to test with custom configs. >> diff --git a/automation/scripts/build b/automation/scripts/build >> index 21b3bc57c8..9c6196d9bd 100755 >> --- a/automation/scripts/build >> +++ b/automation/scripts/build >> @@ -83,6 +83,7 @@ fi >>   # Build all the configs we care about >>   case ${XEN_TARGET_ARCH} in >>       x86_64) arch=x86 ;; >> +    arm64) arch=arm ;; >>       *) exit 0 ;; >>   esac >> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>       rm -f xen/.config >>       make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} >> defconfig >>       make -j$(nproc) -C xen >> +    if [[ ${arch} == "arm" ]]; then >> +        cp xen/xen binaries/xen-${cfg} >> +    fi > > This feels a bit of a hack to be arm only. Can you explain why this is > not enabled for x86 (other than this is not yet used)? I did not want to change the existing behavior for x86. >>   done >> diff --git a/automation/scripts/qemu-staticmem-arm64.sh >> b/automation/scripts/qemu-staticmem-arm64.sh >> new file mode 100755 >> index 0000000000..5b89a151aa >> --- /dev/null >> +++ b/automation/scripts/qemu-staticmem-arm64.sh >> @@ -0,0 +1,114 @@ >> +#!/bin/bash >> + >> +base=(0x50000000 0x100000000) >> +size=(0x10000000 0x10000000) > > From the name, it is not clear what the base and size refers too. > Looking a bit below, it seems to be referring to the domain memory. If > so, I would suggest to comment and rename to "domu_{base, size}". They are the static memory regions allocated to the domu. >> + >> +set -ex >> + >> +apt-get -qy update >> +apt-get -qy install --no-install-recommends u-boot-qemu \ >> +                                            u-boot-tools \ >> +                                            device-tree-compiler \ >> +                                            cpio \ >> +                                            curl \ >> +                                            busybox-static >> + >> +# DomU Busybox >> +cd binaries >> +mkdir -p initrd >> +mkdir -p initrd/bin >> +mkdir -p initrd/sbin >> +mkdir -p initrd/etc >> +mkdir -p initrd/dev >> +mkdir -p initrd/proc >> +mkdir -p initrd/sys >> +mkdir -p initrd/lib >> +mkdir -p initrd/var >> +mkdir -p initrd/mnt >> +cp /bin/busybox initrd/bin/busybox >> +initrd/bin/busybox --install initrd/bin >> +echo "#!/bin/sh >> + >> +mount -t proc proc /proc >> +mount -t sysfs sysfs /sys >> +mount -t devtmpfs devtmpfs /dev >> +/bin/sh" > initrd/init >> +chmod +x initrd/init >> +cd initrd >> +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz >> +cd ../.. >> + >> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded >> +curl -fsSLO >> https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom >> + >> +./binaries/qemu-system-aarch64 -nographic \ >> +    -M virtualization=true \ >> +    -M virt \ >> +    -M virt,gic-version=2 \ >> +    -cpu cortex-a57 \ >> +    -smp 2 \ >> +    -m 8G \ >> +    -M dumpdtb=binaries/virt-gicv2.dtb >> + >> +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts >> + >> +# ImageBuilder >> +rm -rf imagebuilder >> +git clone https://gitlab.com/ViryaOS/imagebuilder >> + >> +echo "MEMORY_START=\"0x40000000\" >> +MEMORY_END=\"0x0200000000\" >> + >> +DEVICE_TREE=\"virt-gicv2.dtb\" >> + >> +XEN=\"xen-static_mem\" >> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" > > AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is > also not clear why you need to pass xsm=dummy. It is not clear to me either :). I will remove them. >> + >> +NUM_DOMUS=1 >> +DOMU_MEM[0]=512 >> +DOMU_VCPUS[0]=1 >> +DOMU_KERNEL[0]=\"Image\" >> +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" >> +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" >> +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" >> + >> +UBOOT_SOURCE=\"boot.source\" >> +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config >> + >> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c >> binaries/imagebuilder_config >> + >> +# Run the test >> +rm -f qemu-staticmem.serial >> +set +e >> +echo "  virtio scan; dhcp; tftpb 0x40000000 boot.scr; source >> 0x40000000"| \ >> +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ >> +    -M virtualization=true \ >> +    -M virt \ >> +    -M virt,gic-version=2 \ >> +    -cpu cortex-a57 \ >> +    -smp 2 \ >> +    -m 8G \ >> +    -no-reboot \ >> +    -device virtio-net-pci,netdev=vnet0 -netdev >> user,id=vnet0,tftp=binaries \ >> +    -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >> +    -dtb ./binaries/virt-gicv2.dtb \ >> +    |& tee qemu-staticmem.serial >> + >> +set -e > > A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think > it would be better to consolidate in a single script. Looking briefly > throught the existing scripts, it looks like it is possible to pass > arguments (see qemu-smoke-x86-64.sh). Yes, if there is no issue with changing qemu-smoke-arm64.sh, this is a very good idea. >> + >> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 >> + >> +for ((i=0; i<${#base[@]}; i++)) >> +do >> +    start="$(printf "0x%016x" ${base[$i]})" >> +    end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >> +    grep -q "node   0: \[mem ${start}-${end}\]" qemu-staticmem.serial >> +    if test $? -eq 1 >> +    then >> +        exit 1 >> +    fi >> +done > > Please add a comment on top to explain what this is meant to do. > However, I think we should avoid relying on output that we have written > ourself. IOW, relying on Xen/Linux to always write the same message is > risky because they can change at any time. The kernel is taken from a test-artifact container, so, IIUC, it won't change. >> + >> +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:35:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:35:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363246.593699 (Exim 4.92) (envelope-from ) id 1o9iWY-0001r8-Pt; Fri, 08 Jul 2022 07:35:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363246.593699; Fri, 08 Jul 2022 07:35:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iWY-0001qz-Mw; Fri, 08 Jul 2022 07:35:38 +0000 Received: by outflank-mailman (input) for mailman id 363246; Fri, 08 Jul 2022 07:35:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iWX-0001pv-1m for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:35:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d57fa29-fe90-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:35:34 +0200 (CEST) Received: from AM5PR0701CA0020.eurprd07.prod.outlook.com (2603:10a6:203:51::30) by AM8PR08MB6433.eurprd08.prod.outlook.com (2603:10a6:20b:36b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 07:35:31 +0000 Received: from VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::1c) by AM5PR0701CA0020.outlook.office365.com (2603:10a6:203:51::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.5 via Frontend Transport; Fri, 8 Jul 2022 07:35:31 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT057.mail.protection.outlook.com (10.152.19.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 07:35:30 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Fri, 08 Jul 2022 07:35:29 +0000 Received: from 43010edddf83.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D9AD7C36-F871-476A-805B-0953F634DBE1.1; Fri, 08 Jul 2022 07:35:20 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 43010edddf83.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 07:35:20 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AS8PR08MB6151.eurprd08.prod.outlook.com (2603:10a6:20b:290::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 07:35:17 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Fri, 8 Jul 2022 07:35:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d57fa29-fe90-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h18peno+Q7IeKI9SQP4AbI9n28MnIc4TScslgrikIavf28FooC8MVQ89EqW+QbdRdAa0hiLi9oWEdBqQCzkv6G8OOLAmA7b2lTfuxiSgS6i8yX8kSiFcdlGfelFy7XJ/1BCbhK9jFL51+RgCF8uJbRExfWbypv8Bgz+uWOAwVbqL4RJfK1wN9XAfJ3uzIqJmdzXRwWZ5dovamQZJxoqXNhfCM9GMijXjKUi1DqaMbMZLhP9zCEdkJ4le83gNDhfmz+fKmeUFvpfkNY11vjV3sLxeDavgsPZ+YgdAtSPWR6MB6QncvVGxskEOAoQZlsZw5HvsqVTpJtyGcdc84vTnWA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dE+WFuNzX8GpfHH4BB0wjIQK4dcy90sVhvBf4d2ehFY=; b=ZUxkiGIvwEXIymj4LK0yPDg0cF0Ikp4lQn5/Ir5VS6nv35YO8sVWGfoIBKBKR3XWmrpew+16JTMhf8aspn5iFSPNNQBzc1FHBcfxGKQd5j7I7Tuk9E5e7OYXLwCdS++RiWkeRaJ/kHhcv+i8F1gmIu0/JQ+RMAdjA23NKUqK1ugpd+E0pWdBGTfbVYRWQjIOwPxvMi2lS+6aA9NLiJnDojM4A/wSx76Fto7hZ72PawXozRqSVvQrj5bD0xJjGG/J7ezqzBSr7tttsIQuzuHvQMAcnDxyyxZtFU4nJj7pmVg8LVh8Dt6hNDi0lJD36mMT+vb1bLycTrHH1WlfI7KDGg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dE+WFuNzX8GpfHH4BB0wjIQK4dcy90sVhvBf4d2ehFY=; b=vVz31XpyBVPVECVKme7Y5LDZv52DboIEui23pjIXKViEud7jtSLDvclpT637qx144fMHHipVlMtn2dIwUyM4dnqfNBBvRbD2BVxwx0/5KO1Nw2l/+KM36cRFPWWSZaohCI2jNzTAjQ80qayQ7tJiH8fYo2Th1xOa2doKbr4Nlo4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxdHkqKyzLmlR3bVE55prs+SJBuFSnqasAx4K+tcTwyxie0XVDAFjMs6rYVbC7fI7+pLehl3vcrDPCwQHBRj6lh08vpsAPpdGZiQOn4/KxkXJwLvHVrq24Ka+Q7Z4WwMLNYpcsnbOAxNuUlDG3bhmO/5gj77JBrf43eZGfVL+V89E+tqVqdwaxlBYhSNGZbH0c7vos2BW9YEmc4eRhtYl7NF44P8zPuPnOpF/3Z3hiXhnurDY+wSTqk1n5DZWKSs9KVgJbzuy9hTM80Ij7WTGMUD6g4Gx+2nRONAvvwyAbkdh07hTRbYx9fBFK3lxE6X8n9eMdTCPjfc+f318AyM1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dE+WFuNzX8GpfHH4BB0wjIQK4dcy90sVhvBf4d2ehFY=; b=Lnr+WPWJbciCNZ9HpUB+ilC+wwP28OGy7lzmvLYW65jXOy1aHGmTBuVGw8tYfQLbJSIDnIQiq/FYc6DEQkFaZx4yjQjfyNjHsesMdwCpXser/CsgO79rkwQEX4Wq8+pGjau8jTzbniGtjK+xx6mmUrf7/Wx5FNHls5DBAhmkcWkJlNv3b2n2u3M5yPr493DJD6rXzDsmuUZuzfz1mcvmQPtDEpBaC6L8yCgFKORHYqhu+AinWWyy/9u9FgqUGbY+6+itxZW/j00aea3ULyhd9b0JmtFWHCfdBadh6LgWZZ3h3GoPMTqajHiTR/YJtnuECU6KcTwHbJZvG//6nd6zjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dE+WFuNzX8GpfHH4BB0wjIQK4dcy90sVhvBf4d2ehFY=; b=vVz31XpyBVPVECVKme7Y5LDZv52DboIEui23pjIXKViEud7jtSLDvclpT637qx144fMHHipVlMtn2dIwUyM4dnqfNBBvRbD2BVxwx0/5KO1Nw2l/+KM36cRFPWWSZaohCI2jNzTAjQ80qayQ7tJiH8fYo2Th1xOa2doKbr4Nlo4= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: Xen 4.17: Proposed release schedule Thread-Topic: Xen 4.17: Proposed release schedule Thread-Index: AdiSei6vjIC3DQhRQxe+drETJuVp3w== Date: Fri, 8 Jul 2022 07:35:17 +0000 Message-ID: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 36BB5B1F521FCC4EA4B75A6C404CB7D6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 69dba295-9261-400a-fd26-08da60b46f50 x-ms-traffictypediagnostic: AS8PR08MB6151:EE_|VE1EUR03FT057:EE_|AM8PR08MB6433:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zp2hskBSgDnsvHiYf5carenTbHNWtWUcK5rfqAbQCsxpduPcPgY/GdHXwzfWBxfQybjVgfxM/GUj3fc8FkLdnzgF79eFU5EGWfexZ27eN8q1/Nst6D+KWPpNfjf+0uTCf08XRYGeJcDhn06YAaFa9txDEwjIH0Z/g7Wy8aXMEXT1o4dESMR1mmLnwTFkFykGfFGx8a20RysRzjCSvuyo3O5Sas/EShN6HfD9RRNwN1Vdp4Ht4gM4l/sr4J1VkPCMD6N9BbpD/H8FfQz5i3MShur9TtIkkPqyDjf+KL7znqx7dMNzZd6v33+7Bxj+H6kQhReS1jZ1K76+zIY1RIvQ6WHVt9Bm51trnVzjujONw/E1iQnqBuMBhMVCPjIe2gmhlrANeVS67fEDRZ/LZES+vEUHuFzsvAqGqcgOv5SGxEH6Sfa54bCeWvl0S5EhrS30ZPft32yJkE0OQCc/xa9rw38KcEdRKYjYl9j5kwxqlv3R7e0YTN5qTz7onAzRCKrkFPMfDyur2CP0/XNpfHUMTqZvZe7MURrUN+nI6EdGkgfwhcoPWI/9lLUyuqqKKNQDt+6QtkqxEG/k56k0K1neU+NxK59IQi1vA+Qo7q0cW+gcW1KH6DF9QmHNOjRIJ8v3P8ntL7xzkqjbvJVXfdSJs+gEFUpFzszHfUJh6BIAmfdMwi5flzZ8h/8r+Sg7AenCO+gdH3y9PP/ASSp9WmzPzZyaZcBOacBFgQyVljVasEeC7Th0IhVCA3clRqPn2cOTAkNYKVVtrLUcRLGaJfwm//TkeOSgKOwjsRxRc+Bw7/xmmxXxmhYt9pYwgUJHGVdr X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(366004)(136003)(376002)(346002)(71200400001)(66556008)(66476007)(66446008)(64756008)(66946007)(4326008)(8676002)(76116006)(9686003)(54906003)(6916009)(316002)(38070700005)(86362001)(186003)(26005)(52536014)(2906002)(38100700002)(33656002)(41300700001)(122000001)(478600001)(7696005)(83380400001)(6506007)(5660300002)(8936002)(7416002)(55016003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6151 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fe8dccae-d6dc-465b-e8f5-08da60b46791 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eUQK+O/GpBv+PlV8FXkMrn5q7dllO48AfH/gq1gL6Xn+TVvzLxjgOtvSx+O9OyjA71aw1vPp6deKVJ8J9yVmZQrFkeamBaVWokEYbNaYedi725Rr2oeKXUeqaB26Wg4DafMSVRgj7QnTfRA6+E/5kIlkOpIl70+Ix3xedg8f+M54jazwwcBPzMd8q1QQRclG04EsYqG8s1GYfL5GAu/2s2uEDgTF0APyb98Cj7quHKF+ZzVNjQVOs3/gqSNB0pFUSzeAf2Pt5JenNMjefvE2ixPS8FbF/rfBEO0jVnRp7X4kpnB+9ulj0b0KtOTJm4xOjRVHnsx0QgSi1EJCEb5fr2LxYSzUH9krViglLmUWQA+7fHiwW0ynHOjtYp3qWko6GTtwPT1LJ1+m3jDPpeIAs0CfnTc/SLcDN7ipFkf9Aubr2pF3pCvO78DfBjmlSHhTDJ+nnuDHwSQsJoNGoQyvrNByeeje+GYqUc8cvsYWhLGW9VcI9vbjWTBDcXyw02Ct+THHsI+N/8soDUFmqolQhteGE5o6il5JUNunD1v7eUnfNZrCRwUKOJXrBW99DrtcbqzUKl6VXNJQxK8QS2M7tqZrcCJ0b1+ix+uE9uAvIGGyF0gk6jB0KMCduIsDhVepuXUKiiAOTj8inAhi0fVdTO22MhELuzJQcBQJcsyYbb+jkaIRMTyqQrpN1wCbvOoYsWvjukskJS7QM6FeWY7DDObuxKycgm6B0x7+tNLtey79z2iqA/i/EG/FgpQEZMSMQeyFda8n0O9UjdIBRPJ1rz+N/FtRR2Og1q0/pVunwaEeN6feoTTctLalZFF1hNrw X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(40470700004)(36840700001)(46966006)(5660300002)(9686003)(356005)(82740400003)(107886003)(36860700001)(26005)(8676002)(70586007)(70206006)(83380400001)(47076005)(8936002)(336012)(52536014)(186003)(4326008)(86362001)(82310400005)(478600001)(33656002)(41300700001)(55016003)(40460700003)(81166007)(316002)(6506007)(2906002)(40480700001)(6916009)(54906003)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 07:35:30.3211 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69dba295-9261-400a-fd26-08da60b46f50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT057.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6433 Hi, As discussed in the community call on July 7, the release schedule for Xen = 4.17 is proposed below. Please send comments ASAP and in any case by the end of Friday the 15th of July. I hope we can finalise the schedule then. Original date following the 8 month release cycle (August 2022) is likely t= o miss considering the summer season in Europe and the fact that we would have had= to feature freeze in July, but this is likely to be not feasible anymore. Based on the Xen 4.16 release timeline, for Xen 4.17 release: Proposed option 1: Wed Sep 28, 2022 (+9 months from Xen 4.16 release, after Xen Summit) - Last posting date Fri Jul 29, 2022 (+3 weeks from now) Patches adding new features should be posted to the mailing list by this date, although perhaps not in their final version. - Feature freeze Fri Aug 19, 2022 (+3 weeks from Last posting d= ate) Patches adding new features should be committed by this date. Straightforward bugfixes may continue to be accepted by maintainers. - Code freeze Fri Sep 9, 2022 (+3 weeks from Feature freeze) Bugfixes only. - Hard code freeze Fri Sep 16, 2022 (+1 week from Code freeze) Branch off staging-4.17. Bugfixes for serious bugs (including regressions), and low-risk fixes only. - Final commits Fri Sep 23, 2022 (+1 week from Hard code freez= e) Docs/prep only - Release Wed Sep 28, 2022 Proposed option 2: Wed Nov 2, 2022 (+1 year from Xen 4.16 release) - Last posting date Fri Aug 12, 2022 (+5 weeks from now) - Feature freeze Fri Sep 2, 2022 (+3 weeks from Last posting da= te) - Code freeze Fri Sep 23, 2022 (+3 weeks from Feature freeze= ) - Hard code freeze Fri Oct 14, 2022 (+3 weeks from Code freeze) - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code free= ze) - Release Wed Nov 2, 2022 As soon as the release schedule is decided, I will post reminders one week before important dates. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:35:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:35:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363245.593688 (Exim 4.92) (envelope-from ) id 1o9iWK-0001YC-Gw; Fri, 08 Jul 2022 07:35:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363245.593688; Fri, 08 Jul 2022 07:35:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iWK-0001Y5-ED; Fri, 08 Jul 2022 07:35:24 +0000 Received: by outflank-mailman (input) for mailman id 363245; Fri, 08 Jul 2022 07:35:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iWI-0001Xz-S4 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:35:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iWI-0005YE-70; Fri, 08 Jul 2022 07:35:22 +0000 Received: from [54.239.6.190] (helo=[192.168.18.211]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9iWH-0005jy-VX; Fri, 08 Jul 2022 07:35:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Mms2qwh+RVURms0tYhWd7gB3pp/cJzH0ZMiiPHLELzA=; b=HqYGY2+GYILrwBlF/xXmu/YaEd 4bdEGxR+a/RcKLz37bPayoDNNLu/U01ZD860ow7mJ7nQ+xBQSxVdJ8EsFfTWeN3XvZgwK8gx9JxFo DLPvVaP9bUvueNOzoYAJN2v49yc2Uiibb+6PfEXjVvH690pe6R2K+PxkOcOWtu+g8SPA=; Message-ID: <2176a93e-5949-022e-d107-e42c859626ef@xen.org> Date: Fri, 8 Jul 2022 08:35:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu To: Stefano Stabellini Cc: Xenia Ragiadakou , xen-devel@lists.xenproject.org, Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/07/2022 00:05, Stefano Stabellini wrote: > On Thu, 7 Jul 2022, Julien Grall wrote: >>> +# Run the test >>> +rm -f qemu-staticmem.serial >>> +set +e >>> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ >>> +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ >>> + -M virtualization=true \ >>> + -M virt \ >>> + -M virt,gic-version=2 \ >>> + -cpu cortex-a57 \ >>> + -smp 2 \ >>> + -m 8G \ >>> + -no-reboot \ >>> + -device virtio-net-pci,netdev=vnet0 -netdev user,id=vnet0,tftp=binaries >>> \ >>> + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >>> + -dtb ./binaries/virt-gicv2.dtb \ >>> + |& tee qemu-staticmem.serial >>> + >>> +set -e >> >> A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it >> would be better to consolidate in a single script. Looking briefly throught >> the existing scripts, it looks like it is possible to pass arguments (see >> qemu-smoke-x86-64.sh). > > One idea would be to make the script common and "source" a second > script or config file with just the ImageBuilder configuration because > it looks like it is the only thing different. This would mean creating a new bash script for every new test. This sounds a bit pointless if the only difference is the ImageBuilder configuration. Instead, it would be better to pass an argument to the script (like qemu-smoke-x86-64.sh) indicating which test we are going to perform. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:41:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:41:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363255.593710 (Exim 4.92) (envelope-from ) id 1o9ibq-00044A-EL; Fri, 08 Jul 2022 07:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363255.593710; Fri, 08 Jul 2022 07:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ibq-000443-Ar; Fri, 08 Jul 2022 07:41:06 +0000 Received: by outflank-mailman (input) for mailman id 363255; Fri, 08 Jul 2022 07:41:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ibp-00043x-3x for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:41:05 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130087.outbound.protection.outlook.com [40.107.13.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51be8336-fe91-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 09:41:04 +0200 (CEST) Received: from DU2PR04CA0263.eurprd04.prod.outlook.com (2603:10a6:10:28e::28) by AM6PR08MB4150.eurprd08.prod.outlook.com (2603:10a6:20b:ac::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Fri, 8 Jul 2022 07:40:49 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::8f) by DU2PR04CA0263.outlook.office365.com (2603:10a6:10:28e::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 07:40:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 07:40:49 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Fri, 08 Jul 2022 07:40:49 +0000 Received: from 6f50755b52d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17C2420E-80C8-4F8C-8716-96B49290F4B7.1; Fri, 08 Jul 2022 07:40:44 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6f50755b52d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 07:40:44 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB9PR08MB7196.eurprd08.prod.outlook.com (2603:10a6:10:2cf::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 07:40:42 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5395.020; Fri, 8 Jul 2022 07:40:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51be8336-fe91-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mWegoal3VtOB0JQjwJjOM/kBY9z51L4WtV6PxKOf44Ualg1p5jINTKvh5I2inmNaHvdcx32KPsXXcaSRtCrC935hX4tDVu/xfkhhjNHP2PzpxKKQhPLn2ZtkFDUOhsxZLtUC43ApLQnrgwENoxUsc4Hk8yv3k/es43PA2YOsYKsIIW/ribFsMfY29oRfsy37OQVb8Hd+Hwj4OQTpzaWe1BlIV7Q5ubUh4QYnbUKZZ0dSO35DJpETulAka1WzEmeHTy34z7vbq90TTOHLawW8XkN2dEgGDfzkP+1p4n3IHMA7c9VxLh8icy8rIE4ViIPXHuSQcd02tF/2UsxLRCPUYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5LvHjbpKbK4+MIQBatnJtmWrxqbXbvqYHq1uBYvzA0=; b=baG1Znsb6JKDiW6oD/9QmzH2aBz0H06TitKNhnoSCM2Qsy960lupIOxlm3kYo64+mFjNkydnHCKb55IMSy77vNp3zDLdiH+7Ab3goBJHEZxh2xgLHLVgS50sR5+QV2t8xDFE70jpOila975GlzsUyOv2v5qqFiw0ULAP8bE461wmcuWvOU72RAmum9SBOOnXcBRxLBPdUMQZHIgmmbUcO0cK9mZfXXwrWMv/w5vY3vGnN/FcLvy6WhlwljhbFZsAKfoH/c62Yd21/Kq65wVJUzoFUTWfsSc1mWo7AW8+DZUOYl4lxf0Sslc+r3g/22ILYkjfXVVlm6CsutBg3RnSSQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5LvHjbpKbK4+MIQBatnJtmWrxqbXbvqYHq1uBYvzA0=; b=PKL69cmyTv/SL3oQAPTmEUc/is0iHCv/qv8dv8+xi4CKmJ832jBAV9rzmHQjz0im/h8wXKnQ8L8egeLTusELfy/jn1vgk/2i0tpjgRQpxLq4H5e7C1fg/dIvuZv76npd0vzSlDrWLN2j5LByC+BlbVCH2ftP275Jsca+qwjO1Cw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkqLZlVJqbRgnRbSCnZVgFDHyTLJacbpR4wLR21xfFNjCOz/S+PPZ2GE/EFSmpPIm4o2x5MVNYJtYibxsgfPfaADFVr5kvzBPhcJKZe+ZRBsNtk/V9igKK7bof93zfDChfEO+Fq7//spUPkRkdUYMHv/32znf59D7iMnwoZJ21EMa0Xna4mmhBQnmdj6eniec3snThnslONTkjI9xjHWnO6LZ5yqZN8cUyq2hCkoSHleafo/aq+JJuasn9tQt/69u4l4lFOljK0HJQ72F5GPHryiBUZbr4iChOujP0R6sE3EfAUqqr/H4x+H5tuRBvCz2nX0u/GXte0PY9Isrp/6+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b5LvHjbpKbK4+MIQBatnJtmWrxqbXbvqYHq1uBYvzA0=; b=Q8zJM8hiTUxriKJIaZ07PQaWObsQRT1vZUZj+ZvOsSWtBwCZBbG9KVB1xIlyp0PjDCmFzqnnB5D9eqVsUYCibNgnjg2KSzK1BiCa81s40EWteeeIPDiMl9Lm9rJ9uWB+knppNq+6qx3Deu669DvnnjWjLIdcQz2c5PGfJTe4dMkqTkph88TIvVMNZ0VDPQ5VoACrAlYmdAznGdY7Y2uCqLLW5DFztOB6kdLWZ9X0Yu7A0jd2SR+nyrvwBCWmWcd6VxKsjCF5hF66jlvGcx79ckCmptTnj6WcirLCaidXzWdVrrx3yG+6X6Bd8R+ecxAPYcmQXzOO4g+KY5QRZlumTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b5LvHjbpKbK4+MIQBatnJtmWrxqbXbvqYHq1uBYvzA0=; b=PKL69cmyTv/SL3oQAPTmEUc/is0iHCv/qv8dv8+xi4CKmJ832jBAV9rzmHQjz0im/h8wXKnQ8L8egeLTusELfy/jn1vgk/2i0tpjgRQpxLq4H5e7C1fg/dIvuZv76npd0vzSlDrWLN2j5LByC+BlbVCH2ftP275Jsca+qwjO1Cw= From: Henry Wang To: Juergen Gross , "xen-devel@lists.xenproject.org" CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH] docs: add reference to release cycle discussion Thread-Topic: [PATCH] docs: add reference to release cycle discussion Thread-Index: AQHYkoEIOS7CuvPhdEyG1tvW/wWt5610FaPw Date: Fri, 8 Jul 2022 07:40:42 +0000 Message-ID: References: <20220708041258.10349-1-jgross@suse.com> In-Reply-To: <20220708041258.10349-1-jgross@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 87E54EDBFF3D4C40B2407414B6DBC951.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e992dcdc-ea2b-40c1-d3a8-08da60b52d87 x-ms-traffictypediagnostic: DB9PR08MB7196:EE_|DBAEUR03FT049:EE_|AM6PR08MB4150:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: htPJhBScpMdpkk6EVye9S+lPfc/Ds3aO/Ogv7A3QS9HPvJP6lFlK6rprbDMcqWp0Sz6h87+2Q2lImg2imKDennDjTMaiMIYDBqdpd+1uR9V0mFgxWnTW/BwOx9ALp922DIom1vkWQ/xX054U2lS5ke3G1a4VEIF1ZnB891c///2vH6LggaEa5kaPQWPZho/wQuvIk8+dLkMPtv9IhqI5T5MJYGy6crMumMOhKcTTOK/VCMkq0QqgL8DFZ2sX7YMmuCXkaFZzCVMmEjuB6zSBLm9lt4SMnKkqz8piLcDfqU2sEu6IH4AUorPWizZT/jQagJTa5ikx/+LD4Dxs1y6buFgvByqolFvkkOjBUpMU0D98PYEqnyq54nO3GaBgw20DSUnqUMdH5Q8Qmv2pQVwiNPC6m1w3x05OI9GssNMOZBk/fIOnW028lzZbCYmFUEPxcoSWwiOxQ7cYA0SBlBskVvolAkPRJsfZz4bXd+Yd8m0j/FoXC2zm/p+TrfczwRIZ8KOTHKRaDmUMoKMqjrwJowLR9GTWXLmnfOep3VrVxbQIUjTE398x8FPCCKye1M0oedFjPKktFuvDPoWJe/hDwfa+KT7orTRKlyQnmYnoA4ebADlD8KwzkY+KPyGS9KWBDDaDOVzD+CFLm8zKJGZ1eczgBY6w0G9cyAcRW9O4B3z18LZZmJUgab8n00ZO9P7yPZkVPJ0OzVsAcCalfDTVueJCo4yht022rH1ww+kup6cu6mOXZcI0F/zuPV8y/Rvt6NwmZkK/VDPExVjfu07+Z9hBNr1fwjdFFtuGX1Ad7ZAp6DkJrw2BRN65n/ila/5HDhyFtnjoY1/xzgv1mUNQ9TkKvrt9K0mR3PKiZ+Eq32Q= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(396003)(136003)(39860400002)(376002)(38070700005)(8936002)(5660300002)(4744005)(38100700002)(52536014)(45080400002)(316002)(122000001)(110136005)(54906003)(9686003)(26005)(478600001)(186003)(71200400001)(966005)(7696005)(6506007)(41300700001)(33656002)(66446008)(4326008)(66556008)(66476007)(83380400001)(76116006)(8676002)(2906002)(86362001)(55016003)(64756008)(66946007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7196 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 09bd9a99-2a8c-40ca-2ffc-08da60b52963 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xB1Bz9kZOcSvGzy/yDCpg1f4TgjcrHk8ne0vc6dbN+xSYrNG2x96W2tK8/08K/TNn8tf8vdIIHFjeVLTr3L9mXSown9ryEA9ACHVuTIAaUl/U35U92bBiOGR5ZkQAS70Y3djnh/rIeFFfzcMgqpfhDpw26fCXojUbIe46oGLXqEO6bOHHDTLu9a73LGYBNZZzb6jY8Zc2GZLOoVtjAitbamZkWdDNOlRdRjnnJknWHuiWuME8zNE9ltQNPsLSVG6t/dHJojGhgJnRQuS8SliKsD9VEsRQuXyz03NgSkfyBVUNhyGlFep/bBU3h/NT35CI7xrxxaVz9KnX+aZ1jC4xwIRbz/wvmrA4fs8JbZ7j2EAW2+hbvNTPV5nfm0GE12/0Nz5uHujnJwNRUPothpxupTX2bm7eQF1wtZz+L+VaXIlGYpnyXeCZu2MF5g8+KkyK+Fcy++gL2KnW6rkTxdSUhdMg8OgRPNVEinA6l2YBNGA8DO6E4I24LfONMGd4lWZzfzXyMn3G4RPmHHk5XCW7o7I30vcd7M/4SVWioLq9mN6ugrRfDDrNZOIfoJMDkZ3X8IntctRol5JmmMIsiRrEhp/dTW/VZ8TqKxJgxslue0Y2A8kG9SbYzSLxS3lRL0LFvA1jgSxUcXfFqOWo56zyzFm7lVda9xHhvxC+EuGKz9DpxUF0JZiCu8NXG4NeNgyuhBD+clF10yyTnqsshpYvzenSgJcx8tIfUKWo7sHPgtWC2w5Nh1lmWw8oD9T6VZTwAKVws1I9S9kQbvs0yRvtciOI9jdNHQNBy05dkqznd6ks2/rj25670TYMVqSKWHVkRfLMVi3bG1jDrJSCxUURutnbouXylolv+RLlhOg/Rw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(346002)(136003)(46966006)(40470700004)(36840700001)(478600001)(55016003)(7696005)(81166007)(36860700001)(33656002)(70206006)(8936002)(6506007)(83380400001)(2906002)(8676002)(5660300002)(82740400003)(4744005)(40480700001)(4326008)(70586007)(356005)(316002)(26005)(41300700001)(186003)(110136005)(40460700003)(47076005)(82310400005)(966005)(9686003)(52536014)(336012)(54906003)(86362001)(45080400002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 07:40:49.5569 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e992dcdc-ea2b-40c1-d3a8-08da60b52d87 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4150 Hi Juergen, > -----Original Message----- > Subject: [PATCH] docs: add reference to release cycle discussion >=20 > As it is coming up basically every release cycle of Xen, add a > reference to the discussion why the current release scheme has been > selected in the release management documentation. >=20 > Signed-off-by: Juergen Gross Thanks very much for this information and the change. Reviewed-by: Henry Wang Acked-by: Henry Wang Also btw, I have posted a proposal for the Xen 4.17 release [1], we can start the discussion there. [1] https://lore.kernel.org/xen-devel/AS8PR08MB7991145C8063D6939AFFED8F9282= 9@AS8PR08MB7991.eurprd08.prod.outlook.com/ Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:45:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363263.593733 (Exim 4.92) (envelope-from ) id 1o9ifv-0004vk-8o; Fri, 08 Jul 2022 07:45:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363263.593733; Fri, 08 Jul 2022 07:45:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ifv-0004vd-5z; Fri, 08 Jul 2022 07:45:19 +0000 Received: by outflank-mailman (input) for mailman id 363263; Fri, 08 Jul 2022 07:45:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ifu-0004vX-2M for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:45:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e8a3a012-fe91-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:45:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5162.eurprd04.prod.outlook.com (2603:10a6:10:1d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 07:45:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 07:45:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e8a3a012-fe91-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEywP+ml83p9L+uFRi90HyAvxHLOLdT729HPtZck1+cGDftSd+pmxVicjSxSZkvSbCyRLljPfv9S8LIkkw9HyE3RbEyEntxaaCpwJVQUf3Lozs8kqAqLNw5EWuM+5JrT+KoOdxxGxBWscqUYx+MFT5HF/Yuy/P5hqFIhx+pJV6tvbOEqOaif4fRh18vDqE38xqynA2hjE0dQlMUY6d8HT2iFalwyuOvUbUZ2wcmnau3nwkHR2ti3A4aWcgnC++Ntwq7M2Q2NelGPdxPQL+XVXejncJFVvBxXizXyNCcOcyq/bl5dn7CFk44uqJ+tA+m53f9ogyQnGjGxaOZVP8w8GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H4eikT7UR16x3SJhXouZIDaPJov9z+zIjrxXq/Q14iI=; b=TrlbbkfcQ9TTm4mpbRxpdAczmgYnZYEn1HgoGx/Uam1HqgWqxgPRBLqjsay8L14zKM2BtqhQ86UDZdJqWIkOVflsdmU1thGDW+AOumkgRNOUEewiSSY0C/p3IXAnfnH41DjDOmSpV6z5YzRw3Sx4e6mTxQq83nj9lZpA/nozG41LB0PI3hja7kMVhjiqV1qNWRTimvNYaQXXjiuoVwReXhEP1X4NZ1YGrsQyiiPfH0iKFEAO/QRVNlWPalqA5WpKP0JwupcNn/Wr+nNSPFQpRnnsSSXb6mWh23VNa53ic9o42WKktlPh9aLRm2DpHmnsKWW48gGPaY+gxbEf2Wf63Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4eikT7UR16x3SJhXouZIDaPJov9z+zIjrxXq/Q14iI=; b=bzfznHuph7j7S2aleIa70rkQbxqjOuWxsaiAbZGqs9OzT1PxdTl05G/L3O9xRY70icyS1UziZpomOlwkJ6u4+J0qLQcSCTmHrohL/8Vl9l8xUpHr2NVd9EdINFkP6dVxd8v6EkWfVBTwHPELhrB/P+4dQwicGMjXxJ0MG6ew9+EFhBHdRCD9VDXROxDcM83Q3I1GPRmc3JaVoI8wNWNSuh1USkFHUjUEQgmSwiko8Jcz4uzoi7HERrhz7atnp/w12Cr5w1/RvXoXSNc3tIRZlxCdYkW3dgq058N2/DA7UqcD6w7oOff6mKKGt17tCNA6O7hmBpF1xTLkr21BT85PcA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <22d754e3-f01d-4f4e-8a34-e8af65ef6437@suse.com> Date: Fri, 8 Jul 2022 09:45:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] docs: add reference to release cycle discussion Content-Language: en-US To: Juergen Gross Cc: Henry.Wang@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220708041258.10349-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220708041258.10349-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e471cd97-5cec-4b8d-b051-08da60b5ca64 X-MS-TrafficTypeDiagnostic: DB7PR04MB5162:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZUcJfJtMEI/1WwV2AAiTRNE8mJY7B/d0XWL6acjCzvUvavV9RDoqgI/sn9rOCpp+tbj6Fh9tpy5A0Kjrk1WOg/Evzkhge9+QWOPEqLNUTD81iXceOOH6DG9TIliOvziAMQ5SjB/PFO2Dt+lMzklr0R2S4C6wgV7vLvzwCh3bgmZ3hAgqZ/FPUy4TQqIC4VzAJstBWhZotrB8A8GiopxnuoumxLVMpeMLpe9gfMWQaFIgZfb2ROyL5U79ZWgj0HtZKcsD8yauJgjnDxw6mcS39h7ksKfqmJooNrEotCmLyQWkkNmYS93l+elYpz3gbGwmzjAR0t2rGbBRA39L5598iM7u7Jwl3Hu+C+F/4lfJ4RY+8NDluduLxTdntVtOKGtxFWu4ID+FbP8+CT/oyAqQmDHV6k+5WruD7fxknwSiriLtaD4ka6M3OTHI0vgLrR4vrJIan5IepWKyIC15wtgKy169SGyzearP0+S3MeeT+pGj3KpArOsnpyTPKgM7UFKHT/8FMCdKnaZrqf8ercYBKV0mOs1RPJ7/mLtogdvqljYz7uJ2mUtRuoPd0OJd6R2ql7R8KIRKwZP1Rzz7AJ0633wcmc9fzkAcKn3dIMBPHKBTZWBOrwWM8tq3SQgV00s0lqg8AvAtZsoq4/Yk6M5BBr86BgyPyt+wu6nx3aommQrLs2nVQGkA7p+z+GwnDr2LY5Xdo+lxYM2BzkoiPRKA03SYM+RPhcZYh3xQWwqd6X+c7wbGA2p4jb0D7fjCxCe4i9e5UfUWAw3urt77Cyypd+ywyIgRgnKIVsgOAH1Ou/EwQUfTauTwKblAyEu1QH7176I7fKZHZlqM23eR+VO4cerb+EIV6+Lkzk9i839FvWQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(136003)(376002)(346002)(366004)(38100700002)(31686004)(6636002)(2906002)(36756003)(37006003)(54906003)(41300700001)(66946007)(86362001)(6862004)(5660300002)(6486002)(66476007)(8936002)(66556008)(316002)(4326008)(6512007)(2616005)(478600001)(186003)(4744005)(31696002)(8676002)(26005)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dmxmanVaUXViMHV5SVlPNnNvMEpiUzFiSUZUcitoQk9uQnlqRGcyajhyOFUy?= =?utf-8?B?dWV2Y2VjOXQ2K1V1R21BSEhNdXNOeE45NlViMkxmbWhsNk14L3lwUEE0YzJG?= =?utf-8?B?M0Y4K1BQanFQNHp1S3JDWlEyVjMwK2FRZFZvck9jYWdQTk91QWZaTVl2VGdz?= =?utf-8?B?eFJXdUphb2xqU01oVzlHSE11OEFwUWZlZVNndklpSmpNb1NGS1lBeFhNNnB2?= =?utf-8?B?NzBlaXNHTnVXVlV5amRTeDQwWnJDVWhzblIzUnB2cnI5STlyU1I5NTJkeDFZ?= =?utf-8?B?VUV3ODAwcHpVcmszUkp3d3FxTFd0N284RnBzUjJhY3NIWVRKU2xwa2ZtTTJx?= =?utf-8?B?MndDM3FnU2R1enNyd1cvcnpLcUVrNy9zVVFiTzVIK0JBUDE3bUo2OUFsT21Z?= =?utf-8?B?U2tlQnBpYXRvMjdQRVdOcThlSU5OV0E2cU55QWVIcXhralcvTk1kdU9zU2Fw?= =?utf-8?B?eGdtd2dOcUNlVlp0amRLKytMWXM3NnJnL2NrY2tzdkdQdmk0QTNIekxsWm1N?= =?utf-8?B?aVFwZkxaV2V0U3VBSkJkRWIvQmM2cWFHVVZBSzFsWWpldDhQdFhXNlVPTHNu?= =?utf-8?B?ZUlPS3gvaUVENEZCMWw0dzA0blpMcTBSZzBhd2Fjbmd3L0J4NDgwOVhwOFd1?= =?utf-8?B?YVNSRU5jSkRWVTlwRG90d0VuZnJBaXVtYnpucXRQeVp4KzZYWHZ1SkZDUmw3?= =?utf-8?B?azlLWmRBZmhPbndReGxKUzl5NGhpdTJhK0RHY1AvRlc0SUZjVjdybDBhZXBz?= =?utf-8?B?SnltSlpYUVpSYTZ1MEtjTFlYTk1FT0FLL2ZOVWxKRXBGakxOWjQ2OWVzV2Js?= =?utf-8?B?eGRIYk1Vd0NKVTlJYUF3MUMxTmxNSGJBdjM0aUphanFzQlBOMGd2L3FlbWU3?= =?utf-8?B?czRVM25jUGdNRjlOY1RaMnFNeWEvY1BwWWdlUnNBOWw3Y3dEc0ZuNWJlNVFT?= =?utf-8?B?UUNIK3ZBNVRObDVkQWhoZGNqS1E0cFpyWW1ocmpCdVJFNG5GQlh5a21ibDJk?= =?utf-8?B?bmgwVlBTZlFlc3MvODBqNGlTSThlMWFQb3kvcncyVEZSZU1nSU9oelV1QVkr?= =?utf-8?B?V1BoRlkxMVdGWGdIdHd0dHBLcUFhMlFDSGpBSEpxN0NzUUNwb203anVmdXBa?= =?utf-8?B?Zy9hbUZRMnE4RjRmUjlnSnN4WjhCRGlFaWxMa01hT0s1NmlpTGVvbElyZEt6?= =?utf-8?B?aHpBS0F4VUdWWlY4Uy9VMTNzdWNCVUVpTG1PbWE4K3YweTF0VHJxekU5cmNJ?= =?utf-8?B?Q251RUJYVnEwbzlzUisxbms0ZEgxbGVvUXk2bU1JQjRoMENHelBPbFBhLzh6?= =?utf-8?B?MVVQd3orR3NjUERzdU9oQ2xkcGdOZXZKeTAzTVMrOElqKzR5Qjh1bysrREdm?= =?utf-8?B?Y1J5eVZLZE9zaFBHQTkyYW4zT1VsY2xWanNYdHIxSlV4OUFIQ2RaS3hHcmxv?= =?utf-8?B?U2cwU0ozUG1lUXA5dFEyTy91M28vZ2NFWmRPQVBudHQxYjAxRmRDMjV5RXpJ?= =?utf-8?B?dWxPZ2ZmYkZxVitkb1YxVGt5Qzg0SjZNeGpTOVVWN0NGeU8yTjd2VDUxWkZX?= =?utf-8?B?SDU2RXIwcDhCNkVCeHRmbkdwRERWNXVMaHhqU0owV0N1KzRoR1FxRjRkQzRp?= =?utf-8?B?ZFRaTjA0Wm1qcnRzOW1CU2JGR0FyMWptQnBaT2cxVFUxbW1sUHBMMkJCV2V5?= =?utf-8?B?ZW1hZWxKUkZxVzIxcVB1Z01oYjV4ak1TTnJhVXN1RGZHMVFndEdJMWxkMEJi?= =?utf-8?B?QzBldllDbU81T0p6elFTdm5JOVp4QzNMZGNWbnhNQTArQTZVSjZpemNjdUZi?= =?utf-8?B?UjFUYUxmTFJyc3hhTTUrenRQakNvcmh1aEZKM0FKV0lrbDdUOUpPQ3lpelZO?= =?utf-8?B?QlhCdmdtelphZzdKRkxwSC85djYzbCt4S0pWTUowK3RqOEpTZ1ZPK1ZFSGt3?= =?utf-8?B?VkVtZi9hQ0ZhekN2Um9lOUJ6ajFrTzJacFRGNnN3NHBoTXN3cjkwaUlxbzNa?= =?utf-8?B?NnNkb0pCRGtNN0pqa0tRSjlzTXh2RTZBRndQLzJCcDk5Z0VDeEx4b29QSHJh?= =?utf-8?B?cUQ1ZVVRc0pJNW1haDVoMDA4S08vdjBOVWtvWVhiUC9BbVhiQWxWQnRWQmVi?= =?utf-8?Q?S2gPD6uh5PowohaAV5jvwdGIb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e471cd97-5cec-4b8d-b051-08da60b5ca64 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 07:45:12.9008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6q9r2WyavcwTZ6TibVt/VniYgYoDN5tJHlHv8o3QKFsM6j/M3suEdh6HeorBp/vuvxubiDYs/nnOuzDTwe+QQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5162 On 08.07.2022 06:12, Juergen Gross wrote: > As it is coming up basically every release cycle of Xen, add a > reference to the discussion why the current release scheme has been > selected in the release management documentation. > > Signed-off-by: Juergen Gross Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:46:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:46:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363268.593744 (Exim 4.92) (envelope-from ) id 1o9igs-0005VP-KW; Fri, 08 Jul 2022 07:46:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363268.593744; Fri, 08 Jul 2022 07:46:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9igs-0005VG-HT; Fri, 08 Jul 2022 07:46:18 +0000 Received: by outflank-mailman (input) for mailman id 363268; Fri, 08 Jul 2022 07:46:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9igr-0005V6-7S for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:46:17 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9igr-0005pF-2l; Fri, 08 Jul 2022 07:46:17 +0000 Received: from [54.239.6.190] (helo=[192.168.18.211]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9igq-0006KE-TB; Fri, 08 Jul 2022 07:46:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Enrk0CMF9QdvkKEmX+ZyvNMDaUhuGcFGRrFhEb9mArk=; b=DMB021HDOWZyiaE07h7pfu3c3b dJYi5JuwML2tcii8ln8DXyYArxmx7vqwf66ugPfJtxJmFEYNGhiukvI7xHF+XbJkrSN5yKcksyO+7 asI0LNhoxMPgjEDTYmEvCPf/BBCwKPGGYr4NInSDTMx595lL6SqoNUqwepdImGwLIVDI=; Message-ID: <418ffeb7-a088-28e8-c1b3-8f5ced317666@xen.org> Date: Fri, 8 Jul 2022 08:46:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/07/2022 08:17, Xenia Ragiadakou wrote: > Hi Julien, Hi Xenia, > On 7/8/22 01:26, Julien Grall wrote: >> Hi Xenia, >> >> On 07/07/2022 21:38, Xenia Ragiadakou wrote: >>> Add an arm subdirectory under automation/configs for the arm specific >>> configs >>> and add a config that enables static allocation. >>> >>> Modify the build script to search for configs also in this >>> subdirectory and to >>> keep the generated xen binary, suffixed with the config file name, as >>> artifact. >>> >>> Create a test job that >>> - boots xen on qemu with a single direct mapped dom0less guest >>> configured with >>> statically allocated memory >>> - verifies that the memory ranges reported in the guest's logs are >>> the same >>> with the provided static memory regions >>> >>> For guest kernel, use the 5.9.9 kernel from the tests-artifacts >>> containers. >>> Use busybox-static package, to create the guest ramdisk. >>> To generate the u-boot script, use ImageBuilder. >>> Use the qemu from the tests-artifacts containers. >>> >>> Signed-off-by: Xenia Ragiadakou >>> --- >>>   automation/configs/arm/static_mem          |   3 + >>>   automation/gitlab-ci/test.yaml             |  24 +++++ >>>   automation/scripts/build                   |   4 + >>>   automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ >>>   4 files changed, 145 insertions(+) >>>   create mode 100644 automation/configs/arm/static_mem >>>   create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >>> >>> diff --git a/automation/configs/arm/static_mem >>> b/automation/configs/arm/static_mem >>> new file mode 100644 >>> index 0000000000..84675ddf4e >>> --- /dev/null >>> +++ b/automation/configs/arm/static_mem >>> @@ -0,0 +1,3 @@ >>> +CONFIG_EXPERT=y >>> +CONFIG_UNSUPPORTED=y >>> +CONFIG_STATIC_MEMORY=y >>> \ No newline at end of file >> >> Any particular reason to build a new Xen rather enable >> CONFIG_STATIC_MEMORY in the existing build > > IIUC, the xen binary (built with the arm64_defconfig) is used by the two > other arm64 test jobs qemu-smoke-arm64-gcc and qemu-alpine-arm64-gcc. I > did not want to change its configuration. > > If there is no issue with changing its configuration, I can enable > static memory and use this one. I would expect a Xen built to CONFIG_STATIC_MEMORY to continue to work in normal case. So it should be fine to enable by default. > But to be honest, I would like to be > able also to test with custom configs. That's fine. But in this case... > >>> diff --git a/automation/scripts/build b/automation/scripts/build >>> index 21b3bc57c8..9c6196d9bd 100755 >>> --- a/automation/scripts/build >>> +++ b/automation/scripts/build >>> @@ -83,6 +83,7 @@ fi >>>   # Build all the configs we care about >>>   case ${XEN_TARGET_ARCH} in >>>       x86_64) arch=x86 ;; >>> +    arm64) arch=arm ;; >>>       *) exit 0 ;; >>>   esac >>> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>>       rm -f xen/.config >>>       make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} >>> defconfig >>>       make -j$(nproc) -C xen >>> +    if [[ ${arch} == "arm" ]]; then >>> +        cp xen/xen binaries/xen-${cfg} >>> +    fi >> >> This feels a bit of a hack to be arm only. Can you explain why this is >> not enabled for x86 (other than this is not yet used)? > > I did not want to change the existing behavior for x86. ... I don't think this should be restricted to arm. I would also consider to do this change separately to avoid mixing infrastructure change and new test. [...] >>> +# ImageBuilder >>> +rm -rf imagebuilder >>> +git clone https://gitlab.com/ViryaOS/imagebuilder >>> + >>> +echo "MEMORY_START=\"0x40000000\" >>> +MEMORY_END=\"0x0200000000\" >>> + >>> +DEVICE_TREE=\"virt-gicv2.dtb\" >>> + >>> +XEN=\"xen-static_mem\" >>> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" >> >> AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is >> also not clear why you need to pass xsm=dummy. > > It is not clear to me either :). I will remove them. Where was this command line copied from? If it is an Arm documentation (or script), then they should be corrected. >>> + >>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 >>> + >>> +for ((i=0; i<${#base[@]}; i++)) >>> +do >>> +    start="$(printf "0x%016x" ${base[$i]})" >>> +    end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>> +    grep -q "node   0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>> +    if test $? -eq 1 >>> +    then >>> +        exit 1 >>> +    fi >>> +done >> >> Please add a comment on top to explain what this is meant to do. >> However, I think we should avoid relying on output that we have >> written ourself. IOW, relying on Xen/Linux to always write the same >> message is risky because they can change at any time. > > The kernel is taken from a test-artifact container, so, IIUC, it won't > change. This statement is correct today. However, we may decide to update the kernel or test multiple kernels (with different ouput). In the first case, it would be a matter of updating the script. This is annoying but not too bad. In the second case, we would need to have "if version X ... else if version Y ... ". Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:46:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:46:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363269.593755 (Exim 4.92) (envelope-from ) id 1o9ih7-0005s9-Sg; Fri, 08 Jul 2022 07:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363269.593755; Fri, 08 Jul 2022 07:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ih7-0005s2-PD; Fri, 08 Jul 2022 07:46:33 +0000 Received: by outflank-mailman (input) for mailman id 363269; Fri, 08 Jul 2022 07:46:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ih6-0005pn-1v for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:46:32 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 14cde0df-fe92-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:46:31 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id dn9so31043875ejc.7 for ; Fri, 08 Jul 2022 00:46:31 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id ba29-20020a0564021add00b00435a62d35b5sm29548359edb.45.2022.07.08.00.46.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 00:46:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14cde0df-fe92-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ARRkIZ8oM6AY7XkmPNQ+UAJJsD+UxhJYrjou3qsB+Ew=; b=Tabu27DFSa1QTsTGieIl0R3OJWDfCoyk9JiJuW1HBM1TXdrKj7PnOPUpzd1YZ6qUsB wfl5Yi8AfmQaONlu49rXKp4Ro+7kcfj4llGztHCRYPLquT+F9dkKf9ItXDKCuX0NqLCD VIudk2QhqMKfb13Sqd2qn/zfqAxt8yRq/AUEsB5hc5thHyU/qIyYpxx78KiYkK8k4p0V HaUWx+mEch+HyM3PkqpNJNUSgSRdNm1EbCzl9Kt73YHo400Dz3fyrWzV2LNmjeZcwt1s SB7tOF8DU38YkXFpzmnz3J6MXgI2KcFqRjO1l+kPsoNUXwDMJ0xnQD37m9YZ4MGO00CR YRxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ARRkIZ8oM6AY7XkmPNQ+UAJJsD+UxhJYrjou3qsB+Ew=; b=twxc4Oi79kdRm8Q1OV80YhEe6skvyRbvm5UeBUGfFDvtLIYZNkL9FRkeIkCXYCkUIg +6GKDiX+QaU5TKkX6Ja/VGIinPBH+QzpmHPd2WAO3VdLz//Y/F491UG3AFMK1P21AOG8 kfosHN5aXpsDsMOleYcuFC/IU7OJLd5ZiJHWIBfO6UsQOcBxMNp6IyJTL2Xh9JBTrjEd mWk7RxXaMxUN7XW6afVofHSyXJy+l1ohTergEE/1+fO4nROAcQn4kqXtbU6dtOFKp+sA soyZ6xtQvkgO0FQ8qDW/Cmfs8yR+GKR3M6/LPVMwoqsnTv2iNrievsrTcYHyevjPOi5p eI4A== X-Gm-Message-State: AJIora/jNqggyTtDL0lGO4A8q1lQFV04ds1Vm5Bmi9NefY4LaqFqZWbN wlUt7E0tmIZEHyWKqeB41n/0a9s7vEo= X-Google-Smtp-Source: AGRyM1uHFjO57EYgHOGL6FuR37nYm/5085Cdai4oROdXsNhyY3LiT29ERwNSywa3mnZemVF2Bdusgg== X-Received: by 2002:a17:906:9b8a:b0:722:e6e0:33d with SMTP id dd10-20020a1709069b8a00b00722e6e0033dmr2153998ejc.317.1657266390496; Fri, 08 Jul 2022 00:46:30 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 10:46:28 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Julien Grall , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> <2176a93e-5949-022e-d107-e42c859626ef@xen.org> From: Xenia Ragiadakou In-Reply-To: <2176a93e-5949-022e-d107-e42c859626ef@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/8/22 10:35, Julien Grall wrote: > Hi, > > On 08/07/2022 00:05, Stefano Stabellini wrote: >> On Thu, 7 Jul 2022, Julien Grall wrote: >>>> +# Run the test >>>> +rm -f qemu-staticmem.serial >>>> +set +e >>>> +echo "  virtio scan; dhcp; tftpb 0x40000000 boot.scr; source >>>> 0x40000000"| \ >>>> +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ >>>> +    -M virtualization=true \ >>>> +    -M virt \ >>>> +    -M virt,gic-version=2 \ >>>> +    -cpu cortex-a57 \ >>>> +    -smp 2 \ >>>> +    -m 8G \ >>>> +    -no-reboot \ >>>> +    -device virtio-net-pci,netdev=vnet0 -netdev >>>> user,id=vnet0,tftp=binaries >>>> \ >>>> +    -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >>>> +    -dtb ./binaries/virt-gicv2.dtb \ >>>> +    |& tee qemu-staticmem.serial >>>> + >>>> +set -e >>> >>> A lot of the code above is duplicated from qemu-smoke-arm64.sh. I >>> think it >>> would be better to consolidate in a single script. Looking briefly >>> throught >>> the existing scripts, it looks like it is possible to pass arguments >>> (see >>> qemu-smoke-x86-64.sh). >> One idea would be to make the script common and "source" a second >> script or config file with just the ImageBuilder configuration because >> it looks like it is the only thing different. > > This would mean creating a new bash script for every new test. This > sounds a bit pointless if the only difference is the ImageBuilder > configuration. Instead, it would be better to pass an argument to the > script (like qemu-smoke-x86-64.sh) indicating which test we are going to > perform. I agree with Julien, also because the ImageBuilder script depends on how qemu is configured. It is not completely independent. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:51:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:51:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363281.593766 (Exim 4.92) (envelope-from ) id 1o9im3-00085W-FV; Fri, 08 Jul 2022 07:51:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363281.593766; Fri, 08 Jul 2022 07:51:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9im3-00085P-CH; Fri, 08 Jul 2022 07:51:39 +0000 Received: by outflank-mailman (input) for mailman id 363281; Fri, 08 Jul 2022 07:51:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9im2-00085J-0f for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:51:38 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2042.outbound.protection.outlook.com [40.107.104.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb05d3dc-fe92-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:51:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7590.eurprd04.prod.outlook.com (2603:10a6:20b:23d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 07:51:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 07:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb05d3dc-fe92-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JWWcMvjIVbng4es19flMsjr2j30KbXssamt5bv+rhAd8TUU2xUrf7GdMxOrIkCtBkVzuUw+A9d/ehzpzP8fC5rB4nF9HrJBWQ7+96lDh9uS6wJ6L5P0+kiuqtU0hQkgInFnKmj1czfhC1/M+OGw0ITmjuY4DgSzVPe7eOMuOmG8zM4XHbgDJEU0wL9UVHYkpmFS+EuosTD9XEjl8r9nYLr6s6ha5qsUmZrTq6x7+aYla8v/XphaliAunbETGKsgesYNaJWuy5+6TzoXfrojUeQZHKWMJC/6CvnNeDtL8v4hg6/vIM4XqrEuN42OOFOR3orq5+bx/sNXh0HMO8j5J9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iL2qY6tJQrjKPPOxPFNictHF6qbFchNvv9rz/v7tlME=; b=auYwf++YCwN4UOFGzoOC43O/k4fjLAUU01GQFTvFhSQjwr9FPJTZVmb4Laq8cr2RuVMsTXaQ8W37TJaDeoy/ZNtTmCI28TPxGAMuJpORX6X/0fJyj2HZag8xSbaRc9uFWZXwXhieTJrAICr26xG5oY4s1jnyfSGBS/Wx+Ep5q6GaDqJ0VgC1t1NHSmAEl9Gv7iyo2oqRaz73T7x8HU9v4LUjcWA00z4PiEq99a5GJI9UKVJU10E2t+46i3U5SYmdxe5KHpJGX950zHWJHvW3hCy6yNypwIKUdxDJzoNzwbrOXoNZyke9c7Sm0GRhxzZpv2KqUFLl+sikxcCqUZPMUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iL2qY6tJQrjKPPOxPFNictHF6qbFchNvv9rz/v7tlME=; b=xRmLxN4hzmqavA7xwsY2as3SRO0UUBiCV6x7cyhqMVzZcn0xSB52t6Xy2FY5UydQDOYF6Q2Npzj7SfG4IZy6YECshVE/zZ9kt6AfXJX5DRAEFn9b7iNf5O/GV0eZ3YUEjp7eBHgmn8sFUexX9uBmWOk3eDgV8ZwuggFIPO8q5uULDB3nfI9sKmPt0XoBHGCNfqVrqK2UyUQxM6IXHhl9OxvDP12zSeJT0RcXZ8OlOgD3F6rjbXlxOHdP7o6uPglb/uNS2WrXb9nhoueXBkxZ311WZOu+LC0IaDfR/ZlsJA6bUncK6VzrjUejlg8HpBl17yScLIaiO7bz8CKwgMqeNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <73ba5d67-635b-b377-14c6-7dd488b10e32@suse.com> Date: Fri, 8 Jul 2022 09:51:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Xen 4.17: Proposed release schedule Content-Language: en-US To: Henry Wang Cc: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdfcdccd-b262-4098-5c29-08da60b6add8 X-MS-TrafficTypeDiagnostic: AS8PR04MB7590:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5uk9n/3kebr7FzOx6OwtMag2RmMjegHU9zqX7XL+VqR3GfApOnVEC/59SpQOzQMvAsluDv5KFiq520C29lhFEHhctjiN4OoeBRDMgzts40hZdwyW2XlT4G01r083vtYS6gRF6b4vlPlpCdAwa+9JYNTfz3Ao7ILZ1eZ1vkMZi8ohwG33LCpIBal2G3N3RG3IPYR/bBU1VZAnKLjenS9nduCOOxPpY9664/5x+KsOf9NQiGizSRNja4u6ZLoyxXc6UeiBiV8YH3OkA3gqRhs8P/eITKNPN1rpUrBwRT1jkbCq0MFSCkyKqjsnKUOjj5J3YbXacnUZLF1q9OqBU2Fe2RdG45lQrRWJ4jOmXGxiFhobfLUB7zhCbR9vZ3WME8aR7V254vWK3wuWszouZFVWzqm/BRrBzAYj8Ivkfv1PSRCP4gJUf4kI+eR+fRRHmha3qxm92fDJ9tZzEwAclTvoW43KqacqiPIlk6goem0nCG12nXx2pRG5COdrU2amT21qidcrE+im09LsGvzkH/kLXA73q5ZMC9s1zvr+QLfsOCj5QFkKvHarp3BkJjCEbsLIBAmGnXaxwXrfv+yF8ze0114pmIeEWI/N+KYWLTJdx95Bj2uwddJW8jpN7Uusv2cRU/xML40/MTMSHM2fodfLLadKsU4CWmkbzJdVRRWFXdop/BymSQUdSQkQrA5NpRLY7JAF6EN6vaQZesVznoenxXYEAdCzRn3nY9OGYGpCe9QDByxs2e/Ay48qzUyo7XQr3ZAY0rJzoS9mOOBStGduKQoUUp8seMIG+r+5kkixqpoarN8j2DWsCFkh8+xL/B3VxKupBDhvG4QBJTlSaujOvQ7tbFfVJ64y3tVafRQLq7A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(136003)(366004)(396003)(4326008)(6512007)(8936002)(6486002)(478600001)(31696002)(53546011)(6862004)(66946007)(66556008)(66476007)(186003)(54906003)(36756003)(316002)(26005)(83380400001)(31686004)(8676002)(2616005)(6506007)(38100700002)(86362001)(5660300002)(2906002)(41300700001)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnNsbUs2K2VvNHI3UWI0UkZJWU1yMUc4Sy9ZbitMTDRSTENkRTR5Q3ZEWHhq?= =?utf-8?B?MmgzMzhaejdUdGpKZXdTZ0VUUFBMOXkwMVlPTmk4UjlYL0xMV3dzL20wODNx?= =?utf-8?B?QndEL0NYTG5jOVNYbGUwYVMwU0h2enVFK3VwS3VDL1lib1FRMkFpSERDdjRM?= =?utf-8?B?aFJwM0tFa2w0dThyVWtUZm1QcVo1cmhsejFkUmV4Vm4rQXhOZU0yRm9QQ2VP?= =?utf-8?B?WmkwNWllb1J2L1JSOWx4RlA2VUtudmEyQ2RibGhuN3VMQ2l6ZU9ydWhRZW5O?= =?utf-8?B?eUdGMlQyYkJXbnVVNEl2K3Y2TG9GbGxBMWEwTDM3QjhpcDZCYkY5dFdqMVd1?= =?utf-8?B?VVVzNFBENkdndjkxNStVeW5PMUZVK3J4b1FZc3ZlTjFCQi9TU3V5b0xubE1T?= =?utf-8?B?a3JjZG1wb2owUDhMOXduVkF6UUhqdU1pUmNZU3greUZUL2UzdUsrRWtaTlMw?= =?utf-8?B?TXRxMjVhV1NWQWFJOGlIYlVJcmRMOTV3UWlpbVN0SGFXUjlNQk5sNTRiRHJn?= =?utf-8?B?d0xlK3dLM0Z5WjRIOFlEOFcyTzRlWmMzaW5QTHhVVTMzaVRnZ2NlbHJULzhW?= =?utf-8?B?NWNRRHltZmo1MDlFOXpWbnhKUjYxc1RIOENQdmlqdVZKcjI3VnJmbXpvc3kz?= =?utf-8?B?eExzekREN2YyY3ZHNTlyMlluMDUzTTZSRkZJT3Q0MVJ2VmRNMXhwR0QxbGM4?= =?utf-8?B?ZlU1M0dsQThZelFRdnVpZUhoa245b2VSOTlFb1R2RjJ3Z3JNSnMzcGVQVjMx?= =?utf-8?B?bXBrU3AxMkhoWTlNVTRIckVnTDlRUHNISnV2Ynp5ejE2M1k0am4yNGdJSVdF?= =?utf-8?B?cFhEQm9NU0xzaE1hOGJKZmljYThKa3U4eU1EWmRPYlUyTDFlb2lnd2QvZmNM?= =?utf-8?B?ZVh5RXhWMFE5TVRac2FtTHdKVlFrYVRnYVIzWUtNN0RDVGZDOVlvWWtLVW1E?= =?utf-8?B?bk9WbVk5UDNWQklSVU44NG1KKzcxdWNTTFdkd2pSM2dqbzhEUEJaT1AxOUJJ?= =?utf-8?B?SlVDTjhHUlhkMHhLa0NFQTBlYm9rQjRiRzl1K3dpem9QR010N3c0VGtZdUo3?= =?utf-8?B?M0VKZFpxRUtLaGFRSU9yU2FVUEhZWHBUM0hYd1FZemMwalVDa2RTcGo3d2NP?= =?utf-8?B?Ny9uRExtcStiL3o2VUltbUlHeFFrMFBWdkRoNkJiZ2ZuK0UyNHNoK2hRN0kv?= =?utf-8?B?a0VpT3hsdmdXTGt0KzVXWnRQNTNBKzRVS3NidisyWFhNOFZGbHA2dlkrT0Zn?= =?utf-8?B?ZFFHbUMybSs2Z2I0T2JDVVhWcDdLM3NqTnhURXRybVdwbkJJOUVabENZLzVh?= =?utf-8?B?NkljczZuSDlCZUlVVlM1UUVBaTBSbUFNNVhrNWJ0YjFGQVp1VjZOalErd3Ny?= =?utf-8?B?Y1hxTGI2QWFKSWNrLzRmaExYdWZFcDhQZDgyWlRrUUVJWC9LaXBFTGl4T0Yy?= =?utf-8?B?T3NMbWo0T0MzazRQMlZkd2tSUFJzSy9lTng2eWRzM21iU1N4MzB2VndVcDBH?= =?utf-8?B?YmpISVRKSHZLbVFWQXU0Zi92NTltVmgzakFGNjNWYXFnRllsRDRYZXJwNlFC?= =?utf-8?B?UXFIM1ZRaTAyenU5akNEVDlsc2syOTF1bFZhWXpxWERNTXRlVWJ0cU1QdkZC?= =?utf-8?B?cFlxWXIxdEtueHNrUm15VzJTdStHUGk4ZDdycUduTnBRT2tYOXFzTkpuUDFv?= =?utf-8?B?bDNxY09UcysyaEJzQWJYZjNWa2Q4b2FqTXlUeXBNMTM4Vm0yNXUzSGdHZkZD?= =?utf-8?B?cjFmRTd2MjNER3kreXpPdjIwTmM2b1Rra0d6QmtIRXNLZC9QbmMzZENrY2Y1?= =?utf-8?B?R0ZYeENyU1NWWlFhT2dXTGduem54Vk5wVkZIZ0hoNmFzZTF6YW5md3JKaVFD?= =?utf-8?B?Zmg0UjZ1QUZoUFFtckhCWFVCL3J2K0ZvbUVPcDdjalpCVzdWRko0K0NGZ3Fl?= =?utf-8?B?NUNjM3FjSGZiN3JUUHdtNCtKTEVaUXpvTjBySFpYdHk1dStZdHFsYitiSnpq?= =?utf-8?B?Z3Z5bUJnelVXMTEvV21PNkhPalBBVkpQcXFpT2JYbmdVZnhKMk9WWkNmQzZl?= =?utf-8?B?OVFuR3JtTWhhWHlkQVpSWlhoUktWdmpSdFRsaWpXQXJwUW5tWmorejRSN3NC?= =?utf-8?Q?YGMIUQsQSU16eYXJs4l+b7EMd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdfcdccd-b262-4098-5c29-08da60b6add8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 07:51:34.5017 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Dn3VwqvNvG8QvrtGXb5FhTc8hb/VnGSujsNy/shAdvYzl475qKFLTzpaUF13SmU3USOkOkXlLqVZrzL2jNEZg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7590 On 08.07.2022 09:35, Henry Wang wrote: > Proposed option 1: Wed Sep 28, 2022 > (+9 months from Xen 4.16 release, after Xen Summit) This would break our 8-month cadence or shorten 4.18 by a month (or more, 4.16 was late in November already, and we're liable to slip anyway - simply based on history). Therefore, as discussed on the call yesterday, ... > - Last posting date Fri Jul 29, 2022 (+3 weeks from now) > > Patches adding new features should be posted to the mailing list > by this date, although perhaps not in their final version. > > - Feature freeze Fri Aug 19, 2022 (+3 weeks from Last posting date) > > Patches adding new features should be committed by this date. > Straightforward bugfixes may continue to be accepted by maintainers. > > - Code freeze Fri Sep 9, 2022 (+3 weeks from Feature freeze) > > Bugfixes only. > > - Hard code freeze Fri Sep 16, 2022 (+1 week from Code freeze) > > Branch off staging-4.17. Bugfixes for serious bugs (including regressions), > and low-risk fixes only. > > - Final commits Fri Sep 23, 2022 (+1 week from Hard code freeze) > > Docs/prep only > > - Release Wed Sep 28, 2022 > > > Proposed option 2: Wed Nov 2, 2022 > (+1 year from Xen 4.16 release) ... my personal view is that this is the better alternative, considering the circumstances. Jan > - Last posting date Fri Aug 12, 2022 (+5 weeks from now) > > - Feature freeze Fri Sep 2, 2022 (+3 weeks from Last posting date) > > - Code freeze Fri Sep 23, 2022 (+3 weeks from Feature freeze) > > - Hard code freeze Fri Oct 14, 2022 (+3 weeks from Code freeze) > > - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code freeze) > > - Release Wed Nov 2, 2022 > > > As soon as the release schedule is decided, I will post reminders one > week before important dates. > > Kind regards, > Henry From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:52:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:52:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363286.593777 (Exim 4.92) (envelope-from ) id 1o9inA-0000Go-Uv; Fri, 08 Jul 2022 07:52:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363286.593777; Fri, 08 Jul 2022 07:52:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9inA-0000Gh-Rx; Fri, 08 Jul 2022 07:52:48 +0000 Received: by outflank-mailman (input) for mailman id 363286; Fri, 08 Jul 2022 07:52:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9in9-0000GV-I8 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:52:47 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f47f4d8f-fe92-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 09:52:46 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id EE0C721F5B; Fri, 8 Jul 2022 07:52:45 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7161213A80; Fri, 8 Jul 2022 07:52:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ax5RGk3ix2LlHQAAMHmgww (envelope-from ); Fri, 08 Jul 2022 07:52:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f47f4d8f-fe92-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657266765; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=t4D9RfTAQWC+qfyzoegfYjecdgOP1F1e53TNcrggaQ0=; b=sGB6+2n+TfYuS0IWWg6dRINUd1OVvDX+s/WXrWmvrrwb9xBE86UtOo8dF24h9e/xbylghc NBH7++l8mH7tF6unkIDydVmWYtoBI6/1Jw4D6GizU3KeN7b4N2GlwgMQgiKEs1ECxtXX5Q ds2He09bf5J7TLyinxWnN058ZwyI4Ko= Message-ID: <8de438f0-992f-0528-c083-50b28fc9cc8d@suse.com> Date: Fri, 8 Jul 2022 09:52:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: Xen 4.17: Proposed release schedule Content-Language: en-US To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" References: From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------2EEk60gvzM6RZwm0DQIoXtUb" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------2EEk60gvzM6RZwm0DQIoXtUb Content-Type: multipart/mixed; boundary="------------3vBh3taEIDchCDwcl8Z0GTg4"; protected-headers="v1" From: Juergen Gross To: Henry Wang , "xen-devel@lists.xenproject.org" Cc: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Message-ID: <8de438f0-992f-0528-c083-50b28fc9cc8d@suse.com> Subject: Re: Xen 4.17: Proposed release schedule References: In-Reply-To: --------------3vBh3taEIDchCDwcl8Z0GTg4 Content-Type: multipart/mixed; boundary="------------cAyvVxGvtPm9Lp0e3EZJocgq" --------------cAyvVxGvtPm9Lp0e3EZJocgq Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDcuMjIgMDk6MzUsIEhlbnJ5IFdhbmcgd3JvdGU6DQo+IEhpLA0KPiANCj4gQXMg ZGlzY3Vzc2VkIGluIHRoZSBjb21tdW5pdHkgY2FsbCBvbiBKdWx5IDcsIHRoZSByZWxlYXNl IHNjaGVkdWxlIGZvciBYZW4gNC4xNw0KPiBpcyBwcm9wb3NlZCBiZWxvdy4gUGxlYXNlIHNl bmQgY29tbWVudHMgQVNBUCBhbmQgaW4gYW55IGNhc2UgYnkgdGhlIGVuZCBvZg0KPiBGcmlk YXkgdGhlIDE1dGggb2YgSnVseS4gSSBob3BlIHdlIGNhbiBmaW5hbGlzZSB0aGUgc2NoZWR1 bGUgdGhlbi4NCj4gDQo+IE9yaWdpbmFsIGRhdGUgZm9sbG93aW5nIHRoZSA4IG1vbnRoIHJl bGVhc2UgY3ljbGUgKEF1Z3VzdCAyMDIyKSBpcyBsaWtlbHkgdG8gbWlzcw0KPiBjb25zaWRl cmluZyB0aGUgc3VtbWVyIHNlYXNvbiBpbiBFdXJvcGUgYW5kIHRoZSBmYWN0IHRoYXQgd2Ug d291bGQgaGF2ZSBoYWQgdG8NCj4gZmVhdHVyZSBmcmVlemUgaW4gSnVseSwgYnV0IHRoaXMg aXMgbGlrZWx5IHRvIGJlIG5vdCBmZWFzaWJsZSBhbnltb3JlLg0KPiANCj4gQmFzZWQgb24g dGhlIFhlbiA0LjE2IHJlbGVhc2UgdGltZWxpbmUsIGZvciBYZW4gNC4xNyByZWxlYXNlOg0K PiANCj4gUHJvcG9zZWQgb3B0aW9uIDE6IFdlZCBTZXAgMjgsIDIwMjINCj4gKCs5IG1vbnRo cyBmcm9tIFhlbiA0LjE2IHJlbGVhc2UsIGFmdGVyIFhlbiBTdW1taXQpDQo+IA0KPiAtIExh c3QgcG9zdGluZyBkYXRlICAgICAgICAgIEZyaSBKdWwgMjksIDIwMjIgKCszIHdlZWtzIGZy b20gbm93KQ0KPiANCj4gUGF0Y2hlcyBhZGRpbmcgbmV3IGZlYXR1cmVzIHNob3VsZCBiZSBw b3N0ZWQgdG8gdGhlIG1haWxpbmcgbGlzdA0KPiBieSB0aGlzIGRhdGUsIGFsdGhvdWdoIHBl cmhhcHMgbm90IGluIHRoZWlyIGZpbmFsIHZlcnNpb24uDQo+IA0KPiAtIEZlYXR1cmUgZnJl ZXplICAgICAgICAgICAgIEZyaSBBdWcgMTksIDIwMjIgKCszIHdlZWtzIGZyb20gTGFzdCBw b3N0aW5nIGRhdGUpDQo+IA0KPiBQYXRjaGVzIGFkZGluZyBuZXcgZmVhdHVyZXMgc2hvdWxk IGJlIGNvbW1pdHRlZCBieSB0aGlzIGRhdGUuDQo+IFN0cmFpZ2h0Zm9yd2FyZCBidWdmaXhl cyBtYXkgY29udGludWUgdG8gYmUgYWNjZXB0ZWQgYnkgbWFpbnRhaW5lcnMuDQo+IA0KPiAt IENvZGUgZnJlZXplICAgICAgICAgICAgICAgIEZyaSBTZXAgOSwgMjAyMiAoKzMgd2Vla3Mg ZnJvbSBGZWF0dXJlIGZyZWV6ZSkNCj4gDQo+IEJ1Z2ZpeGVzIG9ubHkuDQo+IA0KPiAtIEhh cmQgY29kZSBmcmVlemUgICAgICAgICAgIEZyaSBTZXAgMTYsIDIwMjIgKCsxIHdlZWsgZnJv bSBDb2RlIGZyZWV6ZSkNCj4gDQo+IEJyYW5jaCBvZmYgc3RhZ2luZy00LjE3LiBCdWdmaXhl cyBmb3Igc2VyaW91cyBidWdzIChpbmNsdWRpbmcgcmVncmVzc2lvbnMpLA0KPiBhbmQgbG93 LXJpc2sgZml4ZXMgb25seS4NCj4gDQo+IC0gRmluYWwgY29tbWl0cyAgICAgICAgICAgICAg RnJpIFNlcCAyMywgMjAyMiAoKzEgd2VlayBmcm9tIEhhcmQgY29kZSBmcmVlemUpDQo+IA0K PiBEb2NzL3ByZXAgb25seQ0KPiANCj4gLSBSZWxlYXNlICAgICAgICAgICAgICAgICAgICBX ZWQgU2VwIDI4LCAyMDIyDQo+IA0KPiANCj4gUHJvcG9zZWQgb3B0aW9uIDI6IFdlZCBOb3Yg MiwgMjAyMg0KPiAoKzEgeWVhciBmcm9tIFhlbiA0LjE2IHJlbGVhc2UpDQoNCisxIGZvciB0 aGlzIG9wdGlvbi4NCg0KPiANCj4gLSBMYXN0IHBvc3RpbmcgZGF0ZSAgICAgICAgICBGcmkg QXVnIDEyLCAyMDIyICgrNSB3ZWVrcyBmcm9tIG5vdykNCj4gDQo+IC0gRmVhdHVyZSBmcmVl emUgICAgICAgICAgICAgRnJpIFNlcCAyLCAyMDIyICgrMyB3ZWVrcyBmcm9tIExhc3QgcG9z dGluZyBkYXRlKQ0KPiANCj4gLSBDb2RlIGZyZWV6ZSAgICAgICAgICAgICAgICBGcmkgU2Vw IDIzLCAyMDIyICgrMyB3ZWVrcyBmcm9tIEZlYXR1cmUgZnJlZXplKQ0KPiANCj4gLSBIYXJk IGNvZGUgZnJlZXplICAgICAgICAgICBGcmkgT2N0IDE0LCAyMDIyICgrMyB3ZWVrcyBmcm9t IENvZGUgZnJlZXplKQ0KPiANCj4gLSBGaW5hbCBjb21taXRzICAgICAgICAgICAgICBGcmkg T2N0IDI4LCAyMDIyICgrMiB3ZWVrcyBmcm9tIEhhcmQgY29kZSBmcmVlemUpDQo+IA0KPiAt IFJlbGVhc2UgICAgICAgICAgICAgICAgICAgIFdlZCBOb3YgMiwgMjAyMg0KDQoNCkp1ZXJn ZW4NCg== --------------cAyvVxGvtPm9Lp0e3EZJocgq Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------cAyvVxGvtPm9Lp0e3EZJocgq-- --------------3vBh3taEIDchCDwcl8Z0GTg4-- --------------2EEk60gvzM6RZwm0DQIoXtUb Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLH4k0FAwAAAAAACgkQsN6d1ii/Ey+j OAf+LvLY/yhU0JSd6VkF6TEAwy09x/2wYYfVsPoAxRdJIJOd1b++/whdOYBjkSj3mHvqTl9M5JHh 1s/uo8lf+h+za1apHxmCX1wthqMM70l7Kx1nJpGVw0Ef/kM4itIPMQb/p/qdqqLsefY4DrnTZxAO 5/kFrUqO+RjWWRlLxhsC2HnZ6i4q/qyaIv37u32o7x5EytIN2851cbsbOf/AXhBqxMLF+peDD0Sf 6alZKe0xic0ZQCW394qmdoC4xXw3Zxrw5+CjjnENKjJRmqQnk4ccClJKLwJg0DTMGVcN4RDivGIL +348a3NwEIpReUo3JZbShDtIWTVYIyIcU8WmArrZlQ== =jS8y -----END PGP SIGNATURE----- --------------2EEk60gvzM6RZwm0DQIoXtUb-- From xen-devel-bounces@lists.xenproject.org Fri Jul 08 07:56:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 07:56:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363292.593788 (Exim 4.92) (envelope-from ) id 1o9iqn-0000vd-FH; Fri, 08 Jul 2022 07:56:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363292.593788; Fri, 08 Jul 2022 07:56:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iqn-0000vW-Bh; Fri, 08 Jul 2022 07:56:33 +0000 Received: by outflank-mailman (input) for mailman id 363292; Fri, 08 Jul 2022 07:56:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iqm-0000vQ-AI for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 07:56:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ab18372-fe93-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 09:56:31 +0200 (CEST) Received: from DU2PR04CA0182.eurprd04.prod.outlook.com (2603:10a6:10:28d::7) by DB9PR08MB7022.eurprd08.prod.outlook.com (2603:10a6:10:2c9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 07:56:04 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28d:cafe::67) by DU2PR04CA0182.outlook.office365.com (2603:10a6:10:28d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 07:56:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 07:56:03 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Fri, 08 Jul 2022 07:56:03 +0000 Received: from 590ab49098a2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0693F640-CFAC-4C61-82BB-509385B34AA9.1; Fri, 08 Jul 2022 07:55:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 590ab49098a2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 07:55:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2215.eurprd08.prod.outlook.com (2603:10a6:4:86::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 07:55:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::d9f0:12ef:bfa3:3adb%5]) with mapi id 15.20.5395.018; Fri, 8 Jul 2022 07:55:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ab18372-fe93-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QC0seYKL+mvvnQ67XHkMb92mPpDSxChsuBoCGfYSv8qRl8E7Q4b7jkRvLltmHSLE7HSpfgokRHGmN6G4aUITtlWSgqCzpkZJEg4mLfBtFGuaDJsFfYaV7M2g3XYVDslrGPIs2V9zoRmJmG+gyr9k/dN2BPizJu0ZcXE+0wfwK6873GxWvNcbzjIkjxw7IGz3CCElpc3n/ypKGZbPDt+LljuNEb1ssWoug9y3A3CgxA2UWWn/NEWLZ8yDu12sjrpNjcscyBaUpr1BfJWh/6gVMaZ6i+EyCkWqHk6OPKgdZHK9O0KSkDyujVu253C8NUAhSty9l5WFt1jvsjKtk5JgZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EEOAqz6BehGVcNCzctmITzvkSG+PJYzUHHc/7SBlfjA=; b=PCA5fhVCP/uzVJg50axBNsRjNn5EpkqXC4Dx8+PzMXDYfmNveyfFqeuQZ6hW8LmcNZeMazln73jk4gEZ11g9x261hbyMP3H9XYP3R990uqXglxKbZ6eEYzU6PnGs2lFJ0/QUVz3N0Tt4MC7/UrIDgHa/rEyhwI3FueeDh59wan3LQUmT9333QM01nLrHymAFDPbIYkDHBKqOHA7ggl/++z9fIs2ZQ79ZFkvdtCXRlWRUD8QwWAZiOFgsasi69GtMi887lIxF7amS65mfMHIZc0iHM8YOsUS3v/YRvTzoDu8G3I5rnqGdsP3jIKaAVKR27DskYc64L1FyS50/Swk+yw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EEOAqz6BehGVcNCzctmITzvkSG+PJYzUHHc/7SBlfjA=; b=0RPG30v+zu3Zn57U7PsiPEzGZ+DvwALzab49wxLFwMUwb8bD0s2dc8mYzUTy+0eqIBNSIRIg85giAaxeKu7r6rKZ+2nt4vCUXHaMQxNPijBk6KfRKoALPZqKgFwRxLVTOfmW/ysZ3EPjEyVMaC7osjHmgrZQTPa2Qh+DXil8Quk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7c2b2380d16812c3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kIA2dtmUtSiTPL/Flrj8X7aSMqPLUElNzs0hSIqxeoqNRhuJbgOGy1Dz+SSDmO4XV5WzIOKgcC6bXvuscn85V56Y9BFVEcS+/i7wb3UvfFn9ZfJkSM+Cd0Jv5vrZKm93flObFsDGIULuEJx6d7hg9BeLoask7Tp/K2jy4OZThkKuLmrV3sWGMT1lJkwAsfM55Qlj+LqNcmAnKgp3lYSmnK3FNHT98Du+UdxDICsfZXvIZ1N6opUvJpWpn1IWw8WeEABHoJMcDI1b7DpaOmmU3OZ/zvCJ8uLDpF21vVG1/vsR5A9N6dzP1Jv8Tdg9wIAy7HHoW7QKOJ6gLNui/IOKlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EEOAqz6BehGVcNCzctmITzvkSG+PJYzUHHc/7SBlfjA=; b=OpFHaYedWeqRGkB7hD3gGGhvBIKxfrvICDddm7PsWiVb8B+wIkzQCFqHS1arQmQUPLw4J9EpBpbTS6E/jzY1bj9hh1KOQq8zy1fMAzytVPLfqLPA1X/5BSvdqkjDy4O7r0ZIIFHZz1+VQ8FiN+Wt1hzfRPZ6obkJJIxx1Q9dfA2Xx7RBtIvF13GQlOCViqXMgi4ByonwWw2ogJaa3Q6gzZU50le4ikS4a1lxPbJZVjRYhUg+AbCHBi/4Am8T9V5vC0799g6/eRBc97s5qINbSm6Zcvtk+qANx59YJFhvc4ecvqhrnGGDGA1Df6ALzULBjaS48V7QDRnbg+joIZNRYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EEOAqz6BehGVcNCzctmITzvkSG+PJYzUHHc/7SBlfjA=; b=0RPG30v+zu3Zn57U7PsiPEzGZ+DvwALzab49wxLFwMUwb8bD0s2dc8mYzUTy+0eqIBNSIRIg85giAaxeKu7r6rKZ+2nt4vCUXHaMQxNPijBk6KfRKoALPZqKgFwRxLVTOfmW/ysZ3EPjEyVMaC7osjHmgrZQTPa2Qh+DXil8Quk= From: Bertrand Marquis To: Henry Wang CC: "xen-devel@lists.xenproject.org" , "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: Re: Xen 4.17: Proposed release schedule Thread-Topic: Xen 4.17: Proposed release schedule Thread-Index: AdiSei6vjIC3DQhRQxe+drETJuVp3wAJe8gA Date: Fri, 8 Jul 2022 07:55:40 +0000 Message-ID: <74D6D8FE-1F89-444C-A112-F187E64F963D@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 03c025f6-5087-4d69-bbbf-08da60b74e42 x-ms-traffictypediagnostic: DB6PR0802MB2215:EE_|DBAEUR03FT045:EE_|DB9PR08MB7022:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: NB8/d8+1zckOKkyzSP77BAEeefMKSHmB2qV/4PTO+gn7BAP0OYGhVoQy7F5w/Qm0XKECichmADyeQrPk6ToeL+1WEai9RuFLR9jFrynGL6/gKkk3W688LU17E1GQy0WG1tl+WJcHSr7M6wWugpnFYGqGQTvCpdYEK8169b2osqkuJ28y5xd0JptGSQSSpGJVxEE1Ys4mbg7lifg8WniXtM/jYVUAlap9NgKyKkVYcAauYCnAUFs1uYif/yr4uWAIJwsviGmVYHukWPCQw+IfUQE2tUZnPOjioI6Kq1iVV/1Y3dcZGHlJU6WrRYerCJoRIItMtzgt2EFSLkVs2k2hTSHizQXRrGIERiZ0u6lDukbLYvNunG65zyp0TEhoXXjCtQcxJnHNTXTnXwqGcmhEzOn17Y4illh6kc5HjGRZAukExwUkpvzr4uDhxgABpWHDNISpyCGNDwBXFJ2Jf2N0ea8V04OEQZFareLtToGdHYxFOJwOz404OMG6fVZjkztGgbLD6TSP8BCyPmS1Iowq6Sjdo14YeFXVOacA54VpNzBR17y0RuMNC46uCpx9SKemOhoXhD5SqB9bJQC6KaJ5cMNZOXZCWHa7EYVUetoJcVQKo8thS49EGofW9CiOlDm6ZGSVtPbuu5tYtPkmW24qtp1iN2ngj38QV8Oo6cyWQcSVcfrn53pNBQl+5h7cMF+Le3TBomYWMTMes4cEYW4rTVw7/3Q5xcijn0x+GcQrN4sSxS7NdxxoHKLpxI+BpsEO5E3mYIK47FGIr9cqu+lWAqmvJUu7uxM9x3V+wtUBs6iwhNFTx8kE2A5SkSFc6+qTwePt1DlMnel9TegiWL+z2nbp38zGlLZvCeYsy71DqoI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(346002)(376002)(136003)(53546011)(6862004)(4326008)(26005)(41300700001)(5660300002)(64756008)(2906002)(8936002)(33656002)(6506007)(66946007)(6486002)(122000001)(71200400001)(478600001)(36756003)(66446008)(38100700002)(91956017)(66556008)(76116006)(66476007)(8676002)(7416002)(2616005)(38070700005)(83380400001)(6512007)(54906003)(6636002)(186003)(37006003)(86362001)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <164116471B40FD4FA38B7AE09DE9381D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2215 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c71cde06-992f-4ed1-89d1-08da60b740c3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zF8aLVHlOxU+Pkkwzcz1YNSDiYKLDmWmzle/U7uBNmfkNm/PUstOYBpQDYfNAzM/kg2QpBVABqfej1fBSqifE9ORV2wcVy1aSbDoPbG/Py/vs1xzXC7kntxS6V+e89KJR/fHnEjiNbxTRe+Y0u7CpyhGWaRsby/TqJyGAg5xJHpVvfhP3qrDQ06ifX4Apgm9iJWBSi4IoUsfM4OOYWYRNGMXJQpsTajHtdMx70LLnRdmjh1/7efiTP0dtDnXj7MSkpv13y8mmGB8eg7MMVeTe4RLMxPnkCh3arSSbKkAzF47Dp5d64PyXAj7MGHFqEDY6ZKlq7ucRehwPjWb+ZiA0fqVotatU/XWz0ZdPKWNg2WCn5aJULcBdkmfP7JSOYNJKBsCwGeTcJvtrxiTdosE3z4gCS05w083IaRSHAasRP2AsTcWBUvYvYv7I+IaLYqh6Rel7kKK++W994Vt7I0g/ZZCUhKzcKV7opkLpLYGwruLgJOqWZ/ai5yIUJGdNTTsWdkBrQJA9pvDe68hu4eW4GrUKSeXW6zuccE4pQPCxDFbNX6TzJssimNmPqkmRSeGTkWHSsPAP92WhksYVp2BF3rNC+cYTLmwX3KSe2589JNmFurBLBd1T6aK4yvFQ0przx0SbMEvS4P5fl85XMsCyj36bPmrRqUVJc/ikzYJIKsl8DO4Kd69IOOgI8xltWrIyrI87m0L2VmfkMkLK89QV77vZlkS7NLShcPjHyp6Uj4l2aeYFzFWMlpPYFPfzgoQ4OjEtBooiMIpgOoNdvuerUJ97rwjSVmpdppgilsOUM1UvNXf6hsAMY4lSWjrVUG3 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(376002)(46966006)(36840700001)(40470700004)(5660300002)(8936002)(6862004)(40460700003)(36860700001)(40480700001)(2906002)(82310400005)(83380400001)(82740400003)(70206006)(81166007)(86362001)(54906003)(37006003)(6486002)(70586007)(36756003)(8676002)(316002)(186003)(4326008)(356005)(2616005)(6636002)(107886003)(336012)(33656002)(26005)(53546011)(47076005)(6506007)(6512007)(41300700001)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 07:56:03.4468 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03c025f6-5087-4d69-bbbf-08da60b74e42 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7022 > On 8 Jul 2022, at 08:35, Henry Wang wrote: >=20 > Hi, >=20 > As discussed in the community call on July 7, the release schedule for Xe= n 4.17 > is proposed below. Please send comments ASAP and in any case by the end o= f > Friday the 15th of July. I hope we can finalise the schedule then. >=20 > Original date following the 8 month release cycle (August 2022) is likely= to miss > considering the summer season in Europe and the fact that we would have h= ad to > feature freeze in July, but this is likely to be not feasible anymore. >=20 > Based on the Xen 4.16 release timeline, for Xen 4.17 release: >=20 > Proposed option 1: Wed Sep 28, 2022 > (+9 months from Xen 4.16 release, after Xen Summit) >=20 > - Last posting date Fri Jul 29, 2022 (+3 weeks from now) >=20 > Patches adding new features should be posted to the mailing list > by this date, although perhaps not in their final version. >=20 > - Feature freeze Fri Aug 19, 2022 (+3 weeks from Last posting= date) >=20 > Patches adding new features should be committed by this date. > Straightforward bugfixes may continue to be accepted by maintainers. >=20 > - Code freeze Fri Sep 9, 2022 (+3 weeks from Feature freez= e) >=20 > Bugfixes only. >=20 > - Hard code freeze Fri Sep 16, 2022 (+1 week from Code freeze) >=20 > Branch off staging-4.17. Bugfixes for serious bugs (including regressions= ), > and low-risk fixes only. >=20 > - Final commits Fri Sep 23, 2022 (+1 week from Hard code fre= eze) >=20 > Docs/prep only >=20 > - Release Wed Sep 28, 2022 >=20 >=20 > Proposed option 2: Wed Nov 2, 2022 > (+1 year from Xen 4.16 release) +1 for this option >=20 > - Last posting date Fri Aug 12, 2022 (+5 weeks from now) >=20 > - Feature freeze Fri Sep 2, 2022 (+3 weeks from Last posting = date) >=20 > - Code freeze Fri Sep 23, 2022 (+3 weeks from Feature free= ze) >=20 > - Hard code freeze Fri Oct 14, 2022 (+3 weeks from Code freeze) >=20 > - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code fr= eeze) >=20 > - Release Wed Nov 2, 2022 >=20 Bertrand From xen-devel-bounces@lists.xenproject.org Fri Jul 08 08:00:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 08:00:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363299.593799 (Exim 4.92) (envelope-from ) id 1o9iuq-00034b-9f; Fri, 08 Jul 2022 08:00:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363299.593799; Fri, 08 Jul 2022 08:00:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iuq-00034T-6F; Fri, 08 Jul 2022 08:00:44 +0000 Received: by outflank-mailman (input) for mailman id 363299; Fri, 08 Jul 2022 08:00:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iup-00034H-Oc for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 08:00:43 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9iuf-0006eZ-Ls; Fri, 08 Jul 2022 08:00:33 +0000 Received: from [54.239.6.190] (helo=[192.168.18.211]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9iuf-00074u-Ea; Fri, 08 Jul 2022 08:00:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Q2jemuyu2t51ULKJGG0792ZOnC+HDrw35wUr+fGi/K4=; b=FK6WOm3OvzLfOZvBAKWPUzvT/H 7NLMBg0Vhe/HRn7otLmmlDx7rGkFr9m930cMynxAETG8KRf9jT2Ihsiea+zOivSUXbjsLfHb9yfra CnWb4F5d/9O+4U6Je7d7IegNBVUuR6OkEGOqcIHk0UnYsASYxMiCsY66a7BRlodqSD8c=; Message-ID: Date: Fri, 8 Jul 2022 09:00:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Xen 4.17: Proposed release schedule To: Jan Beulich , Henry Wang Cc: "Daniel P. Smith" , George Dunlap , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" , "xen-devel@lists.xenproject.org" References: <73ba5d67-635b-b377-14c6-7dd488b10e32@suse.com> From: Julien Grall In-Reply-To: <73ba5d67-635b-b377-14c6-7dd488b10e32@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 08/07/2022 08:51, Jan Beulich wrote: > On 08.07.2022 09:35, Henry Wang wrote: >> Proposed option 1: Wed Sep 28, 2022 >> (+9 months from Xen 4.16 release, after Xen Summit) > > This would break our 8-month cadence or shorten 4.18 by a month (or > more, 4.16 was late in November already, and we're liable to slip > anyway - simply based on history). Therefore, as discussed on the > call yesterday, ... > >> - Last posting date Fri Jul 29, 2022 (+3 weeks from now) >> >> Patches adding new features should be posted to the mailing list >> by this date, although perhaps not in their final version. >> >> - Feature freeze Fri Aug 19, 2022 (+3 weeks from Last posting date) >> >> Patches adding new features should be committed by this date. >> Straightforward bugfixes may continue to be accepted by maintainers. >> >> - Code freeze Fri Sep 9, 2022 (+3 weeks from Feature freeze) >> >> Bugfixes only. >> >> - Hard code freeze Fri Sep 16, 2022 (+1 week from Code freeze) >> >> Branch off staging-4.17. Bugfixes for serious bugs (including regressions), >> and low-risk fixes only. >> >> - Final commits Fri Sep 23, 2022 (+1 week from Hard code freeze) >> >> Docs/prep only >> >> - Release Wed Sep 28, 2022 >> >> >> Proposed option 2: Wed Nov 2, 2022 >> (+1 year from Xen 4.16 release) > > ... my personal view is that this is the better alternative, considering > the circumstances. +1 > > Jan > >> - Last posting date Fri Aug 12, 2022 (+5 weeks from now) >> >> - Feature freeze Fri Sep 2, 2022 (+3 weeks from Last posting date) >> >> - Code freeze Fri Sep 23, 2022 (+3 weeks from Feature freeze) >> >> - Hard code freeze Fri Oct 14, 2022 (+3 weeks from Code freeze) >> >> - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code freeze) >> >> - Release Wed Nov 2, 2022 >> >> >> As soon as the release schedule is decided, I will post reminders one >> week before important dates. >> >> Kind regards, >> Henry > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 09:00:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 09:00:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363319.593810 (Exim 4.92) (envelope-from ) id 1o9jqf-0004O0-Rc; Fri, 08 Jul 2022 09:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363319.593810; Fri, 08 Jul 2022 09:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9jqf-0004Nt-OU; Fri, 08 Jul 2022 09:00:29 +0000 Received: by outflank-mailman (input) for mailman id 363319; Fri, 08 Jul 2022 09:00:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9jqe-0004Nn-Oy for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 09:00:28 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68efabf7-fe9c-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 11:00:27 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id os14so6380060ejb.4 for ; Fri, 08 Jul 2022 02:00:27 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id la21-20020a170907781500b0072aeda86ac3sm4740868ejc.149.2022.07.08.02.00.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 02:00:26 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68efabf7-fe9c-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Z5Kn/ekZSnQf1fpqDSkWLqugLoN29g75MMTjJpVoamI=; b=qLMwFgi4tjBc/Di8GBPZNC87JRfv10E2Q4/iixxxbGLt0iATTlq6O/TIBjzGVJCRA4 C22nTVR8rZ2l8SQ9eSPRTKhRoNOszcJtphl1H8ortkYJ7/FCdUjM5owc9nd2ZMtxUw0M RUXiq+9PFqfrCvgRo0ICGoyrMhhR+IuoTT6khaNzQPO8mVwPVTKs3O8EhNS/L5dvxm4e ZRQtxxieHnGyYlH6onvCABKGPRdecHDEMRp73C/X3QlEK6jTZLD0S2loo+8BHfg1NseM Zrwo0K2RZqF7X/pKpFRw4/dqOQIkGGH64y3vUeryBid2UWbtMG0LITIjZF1mwQ96Lg4z t6tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Z5Kn/ekZSnQf1fpqDSkWLqugLoN29g75MMTjJpVoamI=; b=pRMCMaTFgdwkqTFoF+Pu9IMunQ9z4ViTHkCDb3U2PiaxD/vmGSmqToCnSXDca8wwuG gyKgzX0jI+aScgetQnLZyjX1YRWkPTYwiNogDhLhCiYm9p5w4ch3H6K7TU3hfsn0yqFa GsQlkvKFlJhmgq2XJ00+mUAqkcb6RswdGwSUvmgpXEDslIbUfo1AKjzE+jamMdinBfdK 5Gwy3yY2sOUgsaA3qLRicWMX0fh+mLb8Q+RwOV+2iWXQC7X9rTMHUWYYdzenq1OaEKYn CSn0R5EnL58uLYo5WGZU2zGR8/DOn29g1dbx0V5HH4IKs7SGX1kIa+Q2d4xQpWbjhngb nRPQ== X-Gm-Message-State: AJIora9ajPx2M4Jis5F41Pa7r4E0y/jBIfeT22zMSZbM0ZNKoADzsmzJ Fi1WA0OpbTdz/+/JRq5xkz9TxWstcmM= X-Google-Smtp-Source: AGRyM1tmUlnXNXAJDUiSkmG5LkGRDT643uoq7c4ycC1BvroLEZQfsJDEU3ylZdan2SHni7u9Zc3stA== X-Received: by 2002:a17:906:ce:b0:718:bff8:58c3 with SMTP id 14-20020a17090600ce00b00718bff858c3mr2378011eji.512.1657270826778; Fri, 08 Jul 2022 02:00:26 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 12:00:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> <418ffeb7-a088-28e8-c1b3-8f5ced317666@xen.org> From: Xenia Ragiadakou In-Reply-To: <418ffeb7-a088-28e8-c1b3-8f5ced317666@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/8/22 10:46, Julien Grall wrote: > > > On 08/07/2022 08:17, Xenia Ragiadakou wrote: >> Hi Julien, > > Hi Xenia, > >> On 7/8/22 01:26, Julien Grall wrote: >>> Hi Xenia, >>> >>> On 07/07/2022 21:38, Xenia Ragiadakou wrote: >>>> Add an arm subdirectory under automation/configs for the arm >>>> specific configs >>>> and add a config that enables static allocation. >>>> >>>> Modify the build script to search for configs also in this >>>> subdirectory and to >>>> keep the generated xen binary, suffixed with the config file name, >>>> as artifact. >>>> >>>> Create a test job that >>>> - boots xen on qemu with a single direct mapped dom0less guest >>>> configured with >>>> statically allocated memory >>>> - verifies that the memory ranges reported in the guest's logs are >>>> the same >>>> with the provided static memory regions >>>> >>>> For guest kernel, use the 5.9.9 kernel from the tests-artifacts >>>> containers. >>>> Use busybox-static package, to create the guest ramdisk. >>>> To generate the u-boot script, use ImageBuilder. >>>> Use the qemu from the tests-artifacts containers. >>>> >>>> Signed-off-by: Xenia Ragiadakou >>>> --- >>>>   automation/configs/arm/static_mem          |   3 + >>>>   automation/gitlab-ci/test.yaml             |  24 +++++ >>>>   automation/scripts/build                   |   4 + >>>>   automation/scripts/qemu-staticmem-arm64.sh | 114 >>>> +++++++++++++++++++++ >>>>   4 files changed, 145 insertions(+) >>>>   create mode 100644 automation/configs/arm/static_mem >>>>   create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >>>> >>>> diff --git a/automation/configs/arm/static_mem >>>> b/automation/configs/arm/static_mem >>>> new file mode 100644 >>>> index 0000000000..84675ddf4e >>>> --- /dev/null >>>> +++ b/automation/configs/arm/static_mem >>>> @@ -0,0 +1,3 @@ >>>> +CONFIG_EXPERT=y >>>> +CONFIG_UNSUPPORTED=y >>>> +CONFIG_STATIC_MEMORY=y >>>> \ No newline at end of file >>> >>> Any particular reason to build a new Xen rather enable >>> CONFIG_STATIC_MEMORY in the existing build >> >> IIUC, the xen binary (built with the arm64_defconfig) is used by the >> two other arm64 test jobs qemu-smoke-arm64-gcc and >> qemu-alpine-arm64-gcc. I did not want to change its configuration. >> >> If there is no issue with changing its configuration, I can enable >> static memory and use this one. > > I would expect a Xen built to CONFIG_STATIC_MEMORY to continue to work > in normal case. So it should be fine to enable by default. > >> But to be honest, I would like to be able also to test with custom >> configs. > > That's fine. But in this case... > >> >>>> diff --git a/automation/scripts/build b/automation/scripts/build >>>> index 21b3bc57c8..9c6196d9bd 100755 >>>> --- a/automation/scripts/build >>>> +++ b/automation/scripts/build >>>> @@ -83,6 +83,7 @@ fi >>>>   # Build all the configs we care about >>>>   case ${XEN_TARGET_ARCH} in >>>>       x86_64) arch=x86 ;; >>>> +    arm64) arch=arm ;; >>>>       *) exit 0 ;; >>>>   esac >>>> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>>>       rm -f xen/.config >>>>       make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} >>>> defconfig >>>>       make -j$(nproc) -C xen >>>> +    if [[ ${arch} == "arm" ]]; then >>>> +        cp xen/xen binaries/xen-${cfg} >>>> +    fi >>> >>> This feels a bit of a hack to be arm only. Can you explain why this >>> is not enabled for x86 (other than this is not yet used)? >> >> I did not want to change the existing behavior for x86. > > > ... I don't think this should be restricted to arm. I would also > consider to do this change separately to avoid mixing infrastructure > change and new test. Sure. > > [...] > >>>> +# ImageBuilder >>>> +rm -rf imagebuilder >>>> +git clone https://gitlab.com/ViryaOS/imagebuilder >>>> + >>>> +echo "MEMORY_START=\"0x40000000\" >>>> +MEMORY_END=\"0x0200000000\" >>>> + >>>> +DEVICE_TREE=\"virt-gicv2.dtb\" >>>> + >>>> +XEN=\"xen-static_mem\" >>>> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" >>> >>> AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is >>> also not clear why you need to pass xsm=dummy. >> >> It is not clear to me either :). I will remove them. > > Where was this command line copied from? If it is an Arm documentation > (or script), then they should be corrected. Don't worry :) I was using them when debugging a script for parsing the xen cmdline and I dragged them around. Sorry about that. >>>> + >>>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 >>>> + >>>> +for ((i=0; i<${#base[@]}; i++)) >>>> +do >>>> +    start="$(printf "0x%016x" ${base[$i]})" >>>> +    end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>>> +    grep -q "node   0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>>> +    if test $? -eq 1 >>>> +    then >>>> +        exit 1 >>>> +    fi >>>> +done >>> >>> Please add a comment on top to explain what this is meant to do. >>> However, I think we should avoid relying on output that we have >>> written ourself. IOW, relying on Xen/Linux to always write the same >>> message is risky because they can change at any time. >> >> The kernel is taken from a test-artifact container, so, IIUC, it won't >> change. > > This statement is correct today. However, we may decide to update the > kernel or test multiple kernels (with different ouput). > > In the first case, it would be a matter of updating the script. This is > annoying but not too bad. In the second case, we would need to have "if > version X ... else if version Y ... ". The particular test was relying and had a dependency on this kernel. If the test is merged into the qemu-smoke-arm64.sh, the check above will leave and it will be tested whether the guest makes it to the busybox, based on the busybox logs, which also may change at any time. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 08 09:20:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 09:20:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363325.593821 (Exim 4.92) (envelope-from ) id 1o9k9h-0007qj-GX; Fri, 08 Jul 2022 09:20:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363325.593821; Fri, 08 Jul 2022 09:20:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9k9h-0007qc-CN; Fri, 08 Jul 2022 09:20:09 +0000 Received: by outflank-mailman (input) for mailman id 363325; Fri, 08 Jul 2022 09:20:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9k9f-0007qW-MR for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 09:20:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9k9f-00086A-FK; Fri, 08 Jul 2022 09:20:07 +0000 Received: from [54.239.6.184] (helo=[192.168.18.9]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9k9f-0002Sw-87; Fri, 08 Jul 2022 09:20:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=02zGjGqIEgMmwVZSBmY2xHaXjzCoDvLOWcBYaDLbwrg=; b=14KTACfTSDqwRY9aNp7eNd9pzG BET9SFcmDq8IVC6LnBdkxZ/I4J6ryGCOlT0Esi1azLxKCnGIuDMftfWuEb8XWpV87iegbmS9sflbh Ak8v37Vlp2qrOcjkYzxVJAKl7BLFwHP/HVQoypHyOfAMQelnJBzLOU+Iq9IOkmQpB/YA=; Message-ID: Date: Fri, 8 Jul 2022 10:20:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> <418ffeb7-a088-28e8-c1b3-8f5ced317666@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08/07/2022 10:00, Xenia Ragiadakou wrote: >>>>> + >>>>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || >>>>> exit 1 >>>>> + >>>>> +for ((i=0; i<${#base[@]}; i++)) >>>>> +do >>>>> +    start="$(printf "0x%016x" ${base[$i]})" >>>>> +    end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>>>> +    grep -q "node   0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>>>> +    if test $? -eq 1 >>>>> +    then >>>>> +        exit 1 >>>>> +    fi >>>>> +done >>>> >>>> Please add a comment on top to explain what this is meant to do. >>>> However, I think we should avoid relying on output that we have >>>> written ourself. IOW, relying on Xen/Linux to always write the same >>>> message is risky because they can change at any time. >>> >>> The kernel is taken from a test-artifact container, so, IIUC, it >>> won't change. >> >> This statement is correct today. However, we may decide to update the >> kernel or test multiple kernels (with different ouput). >> >> In the first case, it would be a matter of updating the script. This >> is annoying but not too bad. In the second case, we would need to have >> "if version X ... else if version Y ... ". > > The particular test was relying and had a dependency on this kernel. I think you missed my point. I don't disagree that the test today expects a specific version. However, there are nothing preventing us to change that so we long we have a matching initramfs/kernel. > If the test is merged into the qemu-smoke-arm64.sh, the check above will > leave and it will be tested whether the guest makes it to the busybox, > based on the busybox logs, which also may change at any time. I don't think I suggested that relying on busybox is better. Ideally we should run a script that prints a message. But this is not something I am going to argue for in this patch. Relying on one piece of line is already far better than trying to check logs for each components (e.g. xen, kernel, busysbox). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 09:54:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 09:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363336.593831 (Exim 4.92) (envelope-from ) id 1o9kgh-0004Ml-88; Fri, 08 Jul 2022 09:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363336.593831; Fri, 08 Jul 2022 09:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9kgh-0004Me-5J; Fri, 08 Jul 2022 09:54:15 +0000 Received: by outflank-mailman (input) for mailman id 363336; Fri, 08 Jul 2022 09:54:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9kgf-0004MY-JY for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 09:54:13 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb3499cd-fea3-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 11:54:12 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id g1so18608353edb.12 for ; Fri, 08 Jul 2022 02:54:12 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id l18-20020a1709060cd200b0072b131815e2sm1894941ejh.113.2022.07.08.02.54.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 02:54:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb3499cd-fea3-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=OVRPTcYrgM4ujl8nNdYJiDgM30qSp0rf06rirLBssmI=; b=CRU3ByfIGA/IgpfGVCyCa4eEPgCy1jImG5wSrVXflfjSI8gZix4oLw9VaYwL7j9Jgp adXYKPEXHxrx80vl7Coac/mBdFpeNR8B5Ti71faC/F6qBjGdVKNGSFNuMvH+gXVxS6si 7l8zVSiuvNJX4qukPCTCfYHtSAmCtIeZZY9M4pxAn3KdUjEG1E8DxJ77SquQBtoVpcEB ZPIRcQpWAFiEBunTt0WfxZy8XX+tD5mKTK15ryWNOxe+0p6sZu4YEvZMn/nw89FlOnyz h5azHe/vvr30+OD0ssJJ5ne0S2fVXeOHSJMigKphcL13/N1/M3em6H2H7mdVC1P1NI/i rGhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=OVRPTcYrgM4ujl8nNdYJiDgM30qSp0rf06rirLBssmI=; b=DZ2Il8JwHmNPwDXF6X0mWZRk+VbMnBdevTzdiyfApfT6/nyPBV2tkC4nNSogHIxZrV 8XZ/7PCFS2Cz8g+aDTrL+Ett0NWRTKsop0wMV+8+dC2+2o2Be10izCV5UQd9bTOpc1a/ RzjEcn4/1vTdwy2b6bdvFVmW9M0wBEPGe1uwb3AyCZe6cW/F41U+2T2SIqtmbFKPLws2 4t/UUW+4dALG1InADsZn4TrawfppuAopEv8tsQXD5XKvxnp/G83bM8uo0gFz8dLj/l50 0860nxiC8VE84gwOCtErSS9waDUkUeQV0SswC4Qth1sf1B88fcxCUhA6L77VXYPjHEL4 W8Dg== X-Gm-Message-State: AJIora/S9RfoH+tT+QgcJLxaPg82/b0lAvm9Bc3qVX7O//XcnR0F5XEH KIWP0rTAgqCXfZqbpHWs0CEuFapSgYM= X-Google-Smtp-Source: AGRyM1s31cNn+S8XpQYHTcv10ERmHMEXuv63zeGzu418Bj4VUqT2/xnekEORrs7vGKysLVP1FecZbA== X-Received: by 2002:a05:6402:42cb:b0:43a:5df2:bb5d with SMTP id i11-20020a05640242cb00b0043a5df2bb5dmr3676052edc.36.1657274051677; Fri, 08 Jul 2022 02:54:11 -0700 (PDT) Message-ID: Date: Fri, 8 Jul 2022 12:54:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Stefano Stabellini , Julien Grall Cc: xen-devel@lists.xenproject.org, Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 7/8/22 02:05, Stefano Stabellini wrote: > On Thu, 7 Jul 2022, Julien Grall wrote: >> Hi Xenia, >> >> On 07/07/2022 21:38, Xenia Ragiadakou wrote: >>> Add an arm subdirectory under automation/configs for the arm specific >>> configs >>> and add a config that enables static allocation. >>> >>> Modify the build script to search for configs also in this subdirectory and >>> to >>> keep the generated xen binary, suffixed with the config file name, as >>> artifact. >>> >>> Create a test job that >>> - boots xen on qemu with a single direct mapped dom0less guest configured >>> with >>> statically allocated memory >>> - verifies that the memory ranges reported in the guest's logs are the same >>> with the provided static memory regions >>> >>> For guest kernel, use the 5.9.9 kernel from the tests-artifacts containers. >>> Use busybox-static package, to create the guest ramdisk. >>> To generate the u-boot script, use ImageBuilder. >>> Use the qemu from the tests-artifacts containers. >>> >>> Signed-off-by: Xenia Ragiadakou >>> --- >>> automation/configs/arm/static_mem | 3 + >>> automation/gitlab-ci/test.yaml | 24 +++++ >>> automation/scripts/build | 4 + >>> automation/scripts/qemu-staticmem-arm64.sh | 114 +++++++++++++++++++++ >>> 4 files changed, 145 insertions(+) >>> create mode 100644 automation/configs/arm/static_mem >>> create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >>> >>> diff --git a/automation/configs/arm/static_mem >>> b/automation/configs/arm/static_mem >>> new file mode 100644 >>> index 0000000000..84675ddf4e >>> --- /dev/null >>> +++ b/automation/configs/arm/static_mem >>> @@ -0,0 +1,3 @@ >>> +CONFIG_EXPERT=y >>> +CONFIG_UNSUPPORTED=y >>> +CONFIG_STATIC_MEMORY=y >>> \ No newline at end of file >> >> Any particular reason to build a new Xen rather enable CONFIG_STATIC_MEMORY in >> the existing build? >> >>> diff --git a/automation/scripts/build b/automation/scripts/build >>> index 21b3bc57c8..9c6196d9bd 100755 >>> --- a/automation/scripts/build >>> +++ b/automation/scripts/build >>> @@ -83,6 +83,7 @@ fi >>> # Build all the configs we care about >>> case ${XEN_TARGET_ARCH} in >>> x86_64) arch=x86 ;; >>> + arm64) arch=arm ;; >>> *) exit 0 ;; >>> esac >>> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>> rm -f xen/.config >>> make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig >>> make -j$(nproc) -C xen >>> + if [[ ${arch} == "arm" ]]; then >>> + cp xen/xen binaries/xen-${cfg} >>> + fi >> >> This feels a bit of a hack to be arm only. Can you explain why this is not >> enabled for x86 (other than this is not yet used)? >> >>> done >>> diff --git a/automation/scripts/qemu-staticmem-arm64.sh >>> b/automation/scripts/qemu-staticmem-arm64.sh >>> new file mode 100755 >>> index 0000000000..5b89a151aa >>> --- /dev/null >>> +++ b/automation/scripts/qemu-staticmem-arm64.sh >>> @@ -0,0 +1,114 @@ >>> +#!/bin/bash >>> + >>> +base=(0x50000000 0x100000000) >>> +size=(0x10000000 0x10000000) >> >> From the name, it is not clear what the base and size refers too. Looking a >> bit below, it seems to be referring to the domain memory. If so, I would >> suggest to comment and rename to "domu_{base, size}". >> >>> + >>> +set -ex >>> + >>> +apt-get -qy update >>> +apt-get -qy install --no-install-recommends u-boot-qemu \ >>> + u-boot-tools \ >>> + device-tree-compiler \ >>> + cpio \ >>> + curl \ >>> + busybox-static >>> + >>> +# DomU Busybox >>> +cd binaries >>> +mkdir -p initrd >>> +mkdir -p initrd/bin >>> +mkdir -p initrd/sbin >>> +mkdir -p initrd/etc >>> +mkdir -p initrd/dev >>> +mkdir -p initrd/proc >>> +mkdir -p initrd/sys >>> +mkdir -p initrd/lib >>> +mkdir -p initrd/var >>> +mkdir -p initrd/mnt >>> +cp /bin/busybox initrd/bin/busybox >>> +initrd/bin/busybox --install initrd/bin >>> +echo "#!/bin/sh >>> + >>> +mount -t proc proc /proc >>> +mount -t sysfs sysfs /sys >>> +mount -t devtmpfs devtmpfs /dev >>> +/bin/sh" > initrd/init >>> +chmod +x initrd/init >>> +cd initrd >>> +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz >>> +cd ../.. >>> + >>> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded >>> +curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom >>> + >>> +./binaries/qemu-system-aarch64 -nographic \ >>> + -M virtualization=true \ >>> + -M virt \ >>> + -M virt,gic-version=2 \ >>> + -cpu cortex-a57 \ >>> + -smp 2 \ >>> + -m 8G \ >>> + -M dumpdtb=binaries/virt-gicv2.dtb >>> + >>> +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts >>> + >>> +# ImageBuilder >>> +rm -rf imagebuilder >>> +git clone https://gitlab.com/ViryaOS/imagebuilder >>> + >>> +echo "MEMORY_START=\"0x40000000\" >>> +MEMORY_END=\"0x0200000000\" >>> + >>> +DEVICE_TREE=\"virt-gicv2.dtb\" >>> + >>> +XEN=\"xen-static_mem\" >>> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" >> >> AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is also not >> clear why you need to pass xsm=dummy. >> >>> + >>> +NUM_DOMUS=1 >>> +DOMU_MEM[0]=512 >>> +DOMU_VCPUS[0]=1 >>> +DOMU_KERNEL[0]=\"Image\" >>> +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" >>> +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" >>> +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" >>> + >>> +UBOOT_SOURCE=\"boot.source\" >>> +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config >>> + >>> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c >>> binaries/imagebuilder_config >>> + >>> +# Run the test >>> +rm -f qemu-staticmem.serial >>> +set +e >>> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source 0x40000000"| \ >>> +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ >>> + -M virtualization=true \ >>> + -M virt \ >>> + -M virt,gic-version=2 \ >>> + -cpu cortex-a57 \ >>> + -smp 2 \ >>> + -m 8G \ >>> + -no-reboot \ >>> + -device virtio-net-pci,netdev=vnet0 -netdev user,id=vnet0,tftp=binaries >>> \ >>> + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >>> + -dtb ./binaries/virt-gicv2.dtb \ >>> + |& tee qemu-staticmem.serial >>> + >>> +set -e >> >> A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it >> would be better to consolidate in a single script. Looking briefly throught >> the existing scripts, it looks like it is possible to pass arguments (see >> qemu-smoke-x86-64.sh). > > One idea would be to make the script common and "source" a second > script or config file with just the ImageBuilder configuration because > it looks like it is the only thing different. > > >>> + >>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 >>> + >>> +for ((i=0; i<${#base[@]}; i++)) >>> +do >>> + start="$(printf "0x%016x" ${base[$i]})" >>> + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>> + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>> + if test $? -eq 1 >>> + then >>> + exit 1 >>> + fi >>> +done >> >> Please add a comment on top to explain what this is meant to do. However, I >> think we should avoid relying on output that we have written ourself. IOW, >> relying on Xen/Linux to always write the same message is risky because they >> can change at any time. > > Especially if we make the script common, then we could just rely on the > existing check to see if the guest started correctly (no special check > for static memory). In this case, how the test will verify that the static memory configuration has been taken into account and has not just been ignored? >>> + >>> +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 > -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 08 10:30:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 10:30:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363349.593843 (Exim 4.92) (envelope-from ) id 1o9lFw-0002In-2d; Fri, 08 Jul 2022 10:30:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363349.593843; Fri, 08 Jul 2022 10:30:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9lFv-0002Ig-Vd; Fri, 08 Jul 2022 10:30:39 +0000 Received: by outflank-mailman (input) for mailman id 363349; Fri, 08 Jul 2022 10:30:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9lFu-0002IW-W5; Fri, 08 Jul 2022 10:30:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9lFu-000108-QP; Fri, 08 Jul 2022 10:30:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9lFu-00045V-DU; Fri, 08 Jul 2022 10:30:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9lFu-000340-D7; Fri, 08 Jul 2022 10:30:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6JfUBiGVsDKOrjaFCUaXw1Y23U61Y0Dt4mxpcpeuIxw=; b=3I9yoFilAjYXb4PIYyOMrxx4ek xhogL2i9Yr1t26aQDbw6Mr1T7SxvcTAXgBIkLbvUbMY2e9Y/XQY/oOY9STjvFSWYpwaQOc6M9QhNU Plx6kU1k197tOsa4VVMbRbQlbttlOzde+AZPAFwZkJBs6YXFaAF9p4AUlPAveh9hb0vg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171551: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a74c66b1b933b37248dd4a3f70a14f779f8825ba X-Osstest-Versions-That: qemuu=0e3723005bfea2f70157bf951f3e6be03bbf6e74 From: osstest service owner Date: Fri, 08 Jul 2022 10:30:38 +0000 flight 171551 qemu-mainline real [real] flight 171558 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171551/ http://logs.test-lab.xenproject.org/osstest/logs/171558/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 171539 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171539 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171539 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu a74c66b1b933b37248dd4a3f70a14f779f8825ba baseline version: qemuu 0e3723005bfea2f70157bf951f3e6be03bbf6e74 Last test of basis 171539 2022-07-07 01:09:39 Z 1 days Failing since 171544 2022-07-07 08:35:56 Z 1 days 2 attempts Testing same since 171551 2022-07-07 21:07:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Kardashevskiy Daniel Henrique Barboza Dominique Martinet Fabiano Rosas Matheus Ferst Murilo Opsfelder Araujo Pali Rohár Richard Henderson Stefan Hajnoczi Thomas Huth Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 758 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 08 12:02:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 12:02:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363371.593853 (Exim 4.92) (envelope-from ) id 1o9mgF-0007ZH-Va; Fri, 08 Jul 2022 12:01:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363371.593853; Fri, 08 Jul 2022 12:01:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9mgF-0007ZA-Sp; Fri, 08 Jul 2022 12:01:55 +0000 Received: by outflank-mailman (input) for mailman id 363371; Fri, 08 Jul 2022 12:01:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9mgE-0007Z1-Ao for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 12:01:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c0d87c9f-feb5-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 14:01:52 +0200 (CEST) Received: from AM6P194CA0070.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::47) by AM9PR08MB7053.eurprd08.prod.outlook.com (2603:10a6:20b:410::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 12:01:50 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:84:cafe::1b) by AM6P194CA0070.outlook.office365.com (2603:10a6:209:84::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 12:01:50 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 12:01:49 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Fri, 08 Jul 2022 12:01:48 +0000 Received: from 7c40c9839e34.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7AB4A79F-1E43-452A-A5F8-F33FF1E42DA5.1; Fri, 08 Jul 2022 12:01:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7c40c9839e34.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 12:01:37 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4149.eurprd08.prod.outlook.com (2603:10a6:20b:b0::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Fri, 8 Jul 2022 12:01:35 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.018; Fri, 8 Jul 2022 12:01:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c0d87c9f-feb5-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ndo2QfRnjdB/iZ8XhzfqDppdClJRXADr7pZcvHoBLcp0bKwtGs0CaR09iql2FUU87NT9/+uhV5KDlAK70TxAi925WaAnm/ymR9udHl4ANNznyRMqtSuDNGVI0nn5DDEYMPRHd5l97JRzRr8AjUKPzQ+Bh2+kpFTwWAzhrXUVbod1bIkXK/KFAhFWe1WUKWZdz/fmr9dICLoYAeovQMDApBM/z4Ym3saxJ3ErDxsduKOJeivoQa7V9AMmdz3oUYGj+0xb0yqcZjm9bftZk6wlnPQOw4pBs9ctyQwfB3sgqwxjTf+CWyZHz6ERRxYVHbNpr4oxi5pR/spJnoXXkaBm/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fn1NLoRlIR8hwkspj78Ki0E2vJo8CIe6tZj3P9lPuWM=; b=Uq6vGfvihvCjn4pkSxRAlFlJTuYsL2PLqnaww+iYQUQe1eZ9/U63lytfxGmrKYKBHXhu/zSLQBXcOs3AlbMXzQo2asBVEYjgMOWz5JxzxzA2gFk2o5YDwTx2fnRB/MTfxfcbNtIUk8lqNY3pEg9pKlGzNU8UQXuRkDnAAdgg2Uiq8zBHlaeE/OiP2AcltpdJb8YPT2VCTlAqkglDPgsIGCL2rQTroM4etRlpFtSkA0PRx+VfJdDhjLkMz7+O0B0e0qNKHKZ8ceStN525fa8wqyRy05jJZ0zVixbWSRoO+DlUpQxt7RzJQkwJrBmCsilFNs3WzxP/C5lGGmb9a5yx4Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fn1NLoRlIR8hwkspj78Ki0E2vJo8CIe6tZj3P9lPuWM=; b=0HmLYZiEvJdQJO/BboFp7Gk3KSlpgcIMrKHEAEWFl9XxQu73fNgH73G7quINvEfSBIvqae9YG+/EbHm035nxtNSdUlfYPeXT0h40jB8mNjW+wkfG5nW4haRLpMlsbkri/nFivEXYNvSkQdoA7sGVErSshpDIrTstbPVa6RK2D6w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bc0093dee5883305 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hP+m38EMyapIKpOhCnYJzTkmwHQapKvevJHlAUTsZh7JGDHIrFjTYgmzqTR05gBIhvq7WJPoo9hbwM5q7btooOA9ZicnAvRADlFkGnZ60rCwsNUX7irDOc3XXKysxa4sZrywb0paIDQedPgwOZBIlGNeowd5Op8e1MFgGvhRxxu9vkN3ppYO9Q7Ctrg+m3Ra1Rh2ycpj7IKLcUrcUUPXC4HxvzGa4WAbrXT5C8U5B1H6/rx9yeqxAFjDzA1eugEF48FlsSFqTAvDdZrE4GC7unvePy+VDtZ+YQa0rNjKO3d2QJejUoOHtUwmLAg57hSSQLpt6tD1OtnGsvf52Z2OrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fn1NLoRlIR8hwkspj78Ki0E2vJo8CIe6tZj3P9lPuWM=; b=mLZHlkb8SpiC1aUDhvNC7hX5qtHNpMWVjcNa0E77Xc1fIsQOtlEl0Ht0/SdJyJXFTxrdTjBqdPFHJYy1Nz+koSVjIP5p/al9qhXygCOTVqLqm4Vw+Sh7btQ0Ezdxe+3ZCjg1xTaU1BhePGOzoUb2dE+HxIL/2TextNEBugze5Qc5GT3bNMhbXh6aa/lCvanOP26vdS+pTGkmuFXPQ6tTlVd7dzsfYkn4trC++/BmPbj/uNkBLHK+vyAdkVzbkT0rPxulOaNxB9nDOhW1fbRqm9Np6qWG6YtG/9rR2Jqgb6aPr+GzMWLBj1wr4zwprHApWLHHexNu9NU0+vY3z3nIMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fn1NLoRlIR8hwkspj78Ki0E2vJo8CIe6tZj3P9lPuWM=; b=0HmLYZiEvJdQJO/BboFp7Gk3KSlpgcIMrKHEAEWFl9XxQu73fNgH73G7quINvEfSBIvqae9YG+/EbHm035nxtNSdUlfYPeXT0h40jB8mNjW+wkfG5nW4haRLpMlsbkri/nFivEXYNvSkQdoA7sGVErSshpDIrTstbPVa6RK2D6w= From: Luca Fancellu To: Jens Wiklander CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Thread-Topic: [PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers Thread-Index: AQHYkrtluLmsjith/0ae41gwW1Q+gq10X3eA Date: Fri, 8 Jul 2022 12:01:34 +0000 Message-ID: References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-2-jens.wiklander@linaro.org> In-Reply-To: <20220622134219.1596613-2-jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4b5db3bc-7fb4-45d9-5b2c-08da60d9a392 x-ms-traffictypediagnostic: AM6PR08MB4149:EE_|VE1EUR03FT048:EE_|AM9PR08MB7053:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 94LorKCj5SuKKgLo5YbwhTIXe6lnUX+ie7hMVSLOrcXJfv8zV5lZb+cWZXgVfi924wVz4WzGkHyCFBS9ZS6yd52rxzH3dkv/6MM/rpmwkn98FzmV97n7YGDQhjt7zl5HseK8AiYHaZS42zr77gVbO+uaogDaq4wJt1mJrns38PZuRH8GWnPTrF3zFLIdhPckeXgBbvCIuGVKSeI9RLjFokLT4foNdlWtEdsc3k80458hgnRW2tKJCilNjhqYOXQW0C2Nh0PNZkqSvA325VcCdAuVuuu+TW+RfQwtMKuwbmeeeGHppUa3WR2nNdDiRqRPNG9CE5nuKL1WiAUR90k4gQclHeyWMAE20BZriIXD65G87onFQ8PKhmjFv5VGSwdiGMdIMX0fgIGOfDRBnB/QJ+e0LvzLKHp6w948mRhnH4tdkaBVnAB00Q8AWfsmp4DhgbZZqlcNCXT7Ft6iqdD0MehID6wf8XCQZwZYQfcrXwOyN2ZkC8FuRKWZ3EWlW4RMRsqWIZZRravjWeXnrBHj2A+znytmfNkEbMLIerFtYVc3SJ4fsKV1nUCqMU8Zl315+XM49Dr/hjwKIJ1u92wqVxrOPnyFPwps3cP4TjrMHV9cZrUuHcoBbcU7JQnuQtnvzE2Sck7EpCNkt+Em7OBclu7JINd6n3L6KsmGDSWX/ooAcTrH4XRY8q2OmFbAU9KQMnV/YMsLnkMKTBkqyLHuLQoEglYjVfysA6/LGCSVEvL5vpObNXY2kJOGegONn0uaMxpkfWHbXC1EC1ypQ0nRmfSgx2tu6PLlpp5A80GijKeuh6xaC6yx5ltA5krOLjF8ceIQrJu0MQOIbO3DzL3GmJIzJEMeBT1rk/IcbJ67Opja8YDqyPVnViIB+dc+qOas X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(53546011)(966005)(33656002)(86362001)(6486002)(6506007)(478600001)(41300700001)(6512007)(26005)(5660300002)(8936002)(2906002)(38070700005)(316002)(2616005)(83380400001)(54906003)(66556008)(64756008)(186003)(66446008)(66476007)(76116006)(38100700002)(66946007)(4326008)(36756003)(122000001)(91956017)(6916009)(8676002)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4149 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 950f0981-a69c-4eeb-ee85-08da60d99ab4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2z0OCnwUAYDcEIBcgzj5fLio9dACw3SD6/j/11j7HGHA+dhW7BH9oD/SWjBh2betgBUEln+2XK0M9WgzFKFYM7UEyHDhfmj37s649gICMeB+l6v6RCqM82gMGdB2XbysEUFn6YQCFGfltMtGMUlruEAx9KqxMN2wiIa666+b1bHIrRdJUIb53xNSSE+YM8kJ4N+5sewhaI8tf+rzdCGFR8brSbeMDJy7uU3BqfcqTjXcJCYrR1m6VfopUxQDwDYP3jbRJLI3F/tSdtnTn7gDjlrKs9FkGKTTSaFk8ZVz2wdDRFaNdItbuEKO9jnNoLws8UW6IbtrOlIYPlab2NncKBixj/SoKzAJLdEIfXdtBYV+S5ongdO8ywZ2ZqQijz703zNnK0S8rMYzez+Dcwel3MtkKcuZND88Hv3ZN6I+O/iz+jWhem8he2v6rUbfawQj1DaAfu09muOAKCEBveqUbppe4Dcd+AHBp2XdBx7ulO0psmNXE98Jbyx+2kA47/xDw60jaQWI0IxjQO0uxpCvUt9fnY80ENMMDLfz5UjQ9pmfnBAo2s/GwQatMI+TzyQbw0VvYk0XFHxf8WrXgn7daR42L7t28zoh66V/6wWeeB+aGClOCy6I1lL9DT/MisXehVSNzNUOBZPx2IyEzRop0T2EQqqEhClj1zLyzMQmCPRhB1UgpmtoITmni+NBWOYUJq1sMy7S+94Yd3Exw8z024RsTmyFwCzG7uW2FdQXyOiceuzVvf0zAlarE+UX7oxR6KD6iE95vRzue6MxJNcydOOjZrpuG5hTAFlJYnKArlfO2/Lrk2nbEO3kKmoxaBNMJZsP7+2O7lrSRcEawex8oBS7VBwrnapiF9zlY2CSN2I= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(396003)(39860400002)(36840700001)(40470700004)(46966006)(54906003)(8936002)(4326008)(36860700001)(966005)(8676002)(6862004)(70206006)(478600001)(36756003)(2616005)(70586007)(6486002)(316002)(40460700003)(86362001)(5660300002)(81166007)(53546011)(2906002)(6512007)(82740400003)(6506007)(82310400005)(356005)(41300700001)(26005)(47076005)(336012)(40480700001)(33656002)(186003)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 12:01:49.3700 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4b5db3bc-7fb4-45d9-5b2c-08da60d9a392 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7053 SGkgSmVucywNCg0KPiBPbiAyMiBKdW4gMjAyMiwgYXQgMTQ6NDIsIEplbnMgV2lrbGFuZGVyIDxq ZW5zLndpa2xhbmRlckBsaW5hcm8ub3JnPiB3cm90ZToNCj4gDQo+IFNNQ0NDIHYxLjIgQUFyY2g2 NCBhbGxvd3MgeDAteDE3IHRvIGJlIHVzZWQgYXMgYm90aCBwYXJhbWV0ZXIgcmVnaXN0ZXJzDQo+ IGFuZCByZXN1bHQgcmVnaXN0ZXJzIGZvciB0aGUgU01DIGFuZCBIVkMgaW5zdHJ1Y3Rpb25zLg0K PiANCj4gQXJtIEZpcm13YXJlIEZyYW1ld29yayBmb3IgQXJtdjgtQSBzcGVjaWZpY2F0aW9uIG1h a2VzIHVzZSBvZiB4MC14NyBhcw0KPiBwYXJhbWV0ZXIgYW5kIHJlc3VsdCByZWdpc3RlcnMuDQo+ IA0KPiBMZXQgdXMgYWRkIG5ldyBpbnRlcmZhY2UgdG8gc3VwcG9ydCB0aGlzIGV4dGVuZGVkIHNl dCBvZiBpbnB1dC9vdXRwdXQNCj4gcmVnaXN0ZXJzLg0KPiANCj4gVGhpcyBpcyBiYXNlZCBvbiAz ZmRjMGNiNTlkOTcgKCJhcm02NDogc21jY2M6IEFkZCBzdXBwb3J0IGZvciBTTUNDQ3YxLjINCj4g ZXh0ZW5kZWQgaW5wdXQvb3V0cHV0IHJlZ2lzdGVycyIpIGJ5IFN1ZGVlcCBIb2xsYSBmcm9tIHRo ZSBMaW51eCBrZXJuZWwNCj4gDQo+IFRoZSBTTUNDQyB2ZXJzaW9uIHJlcG9ydGVkIHRvIHRoZSBW TSBpcyBidW1wZWQgdG8gMS4yIGluIG9yZGVyIHRvIHN1cHBvcnQNCj4gaGFuZGxpbmcgRkYtQSBt ZXNzYWdlcy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEplbnMgV2lrbGFuZGVyIDxqZW5zLndpa2xh bmRlckBsaW5hcm8ub3JnPg0KPiAtLS0NCj4gDQoNCkkgdGhpbmsgeW91IG5lZWQgdG8gdXBkYXRl IHRoZSBjb3B5cmlnaHQgaW5mb3JtYXRpb24gb2YgdGhlIHNtY2NjLmggaGVhZGVyIChtYWludGFp bmVycyBjYW4gY29uZmlybSBpZiBpdOKAmXMgbmVlZGVkKSwNCmFsc28gaXQgc2VlbXMgdGhhdCB5 b3UgYWdyZWVkIHdpdGggSnVsaWVuIHRvIHVwZGF0ZSB0aGUgY29tbWl0IG1lc3NhZ2Ugd2l0aCBh IHJlZmVyZW5jZSB0byB0aGUgc3BlYyBidXQgbWF5YmUgeW91DQpmb3Jnb3QgYWJvdXQgdGhhdDoN Cmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvY29tbWVudC8yNDg5NzQxMy8NCg0KV2l0aCB0 aGVzZSBhZGRyZXNzZWQ6DQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNl bGx1QGFybS5jb20+DQoNCg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 08 12:17:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 12:17:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363377.593865 (Exim 4.92) (envelope-from ) id 1o9mut-0001Da-7g; Fri, 08 Jul 2022 12:17:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363377.593865; Fri, 08 Jul 2022 12:17:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9mut-0001DT-4S; Fri, 08 Jul 2022 12:17:03 +0000 Received: by outflank-mailman (input) for mailman id 363377; Fri, 08 Jul 2022 12:17:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9mur-0001DJ-CK; Fri, 08 Jul 2022 12:17:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9mur-0002wg-BJ; Fri, 08 Jul 2022 12:17:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9muq-0000rk-Vk; Fri, 08 Jul 2022 12:17:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9muq-0008Bv-VM; Fri, 08 Jul 2022 12:17:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Penj68HH2NvkkZcmfgg8eWBZRETz5xT2kxb1c3swWak=; b=MVcVvsDkHv1IlYMEnyuf1Gxzn1 JsSnp/E+aFZIoH9QOCeOhStc4dINtjO2xYWhFBGRS6o4TxNYBSflnGjJtsfmIJ0VSwBOWg5JU8BDD K6azWPgXdhhIsKp+W3NRH8SMIPwDDIdC1jnYZlQ+6NTelWBcfdWxrQ2MGs+SiBp1Doys=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171557: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 X-Osstest-Versions-That: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c From: osstest service owner Date: Fri, 08 Jul 2022 12:17:00 +0000 flight 171557 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171557/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 baseline version: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c Last test of basis 171535 2022-07-06 15:02:57 Z 1 days Testing same since 171557 2022-07-08 08:03:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Jiamei Xie # arm64 Juergen Gross Penny Zheng Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 46cbd76faf..980bfb1ac9 980bfb1ac9247e95790e283dbc03e231e02cced9 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 08 12:30:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 12:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363385.593875 (Exim 4.92) (envelope-from ) id 1o9n7Q-0003ON-F9; Fri, 08 Jul 2022 12:30:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363385.593875; Fri, 08 Jul 2022 12:30:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9n7Q-0003OG-Br; Fri, 08 Jul 2022 12:30:00 +0000 Received: by outflank-mailman (input) for mailman id 363385; Fri, 08 Jul 2022 12:29:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9n7P-0003OA-6n for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 12:29:59 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9n7O-00038P-Oa; Fri, 08 Jul 2022 12:29:58 +0000 Received: from [54.239.6.184] (helo=[192.168.18.9]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9n7O-0003pz-Hv; Fri, 08 Jul 2022 12:29:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=ASPa0/f6XDI6IFoBl0HtGFveuOn2hnbjOButwXxtLXo=; b=rRsTsA3G/dAavxuyKgoFE63nqX /S09mO6wrEhn+96+JXaIjAiJYM6FQrfKY3PwpQGcinV+u1zz2IoYVS7oMDnU2plg8Ioy0INY5/HS2 Yw+pZ9EUfg6dIbjjgZUPafyNqthCVCGBfhUJglsQ3nchzAw3+I94qiR1hue4qkaMW2u8=; Message-ID: Date: Fri, 8 Jul 2022 13:29:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers To: Luca Fancellu , Jens Wiklander Cc: Xen-devel , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-2-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Luca, On 08/07/2022 13:01, Luca Fancellu wrote: >> On 22 Jun 2022, at 14:42, Jens Wiklander wrote: >> >> SMCCC v1.2 AArch64 allows x0-x17 to be used as both parameter registers >> and result registers for the SMC and HVC instructions. >> >> Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as >> parameter and result registers. >> >> Let us add new interface to support this extended set of input/output >> registers. >> >> This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 >> extended input/output registers") by Sudeep Holla from the Linux kernel >> >> The SMCCC version reported to the VM is bumped to 1.2 in order to support >> handling FF-A messages. >> >> Signed-off-by: Jens Wiklander >> --- >> > > I think you need to update the copyright information of the smccc.h header (maintainers can confirm if it’s needed), We don't usually update the copyright header (not sure if we should). Instead, I think we rely on ``git log`` to find who has contributed to the file. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 12:47:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 12:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363397.593886 (Exim 4.92) (envelope-from ) id 1o9nOS-0006gN-UL; Fri, 08 Jul 2022 12:47:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363397.593886; Fri, 08 Jul 2022 12:47:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9nOS-0006gG-RB; Fri, 08 Jul 2022 12:47:36 +0000 Received: by outflank-mailman (input) for mailman id 363397; Fri, 08 Jul 2022 12:47:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9nOR-0006gA-Hu for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 12:47:35 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60051.outbound.protection.outlook.com [40.107.6.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23049203-febc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 14:47:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7718.eurprd04.prod.outlook.com (2603:10a6:20b:29b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 12:47:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 12:47:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23049203-febc-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FRJS0N/M9NrPVqXJ37EsuD9va6dhsKzEuwQ+skpuZJNs7VMsM7688980sLfZjQl8Qs47n+dZHbIHnvISkV/W5bT5cNooIvw90GUC7BhsMWpa6ibyfewiM/nX6oOX9WJP3+BdRAKBCfRV/xp1hubC0s+WKT0AOEPa5VXE22Dnn1k21b0IN+B351YCdBPC+8B2x+QDdzZVBtI2GTdyhfqljZjaCW1YVE5aLSKR7rt9K/wa/xQoyAi/7ynh1TfFs9s1zgs4f/b1/tGygu5QFECzuEbS+uCGessAytRZ2z2lsFhoITDYL5QiHfIb8sds6MwEBkmebAeSx/SLm687LEPYdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eVyHVNHwCl4ADOxL1R+EKqCtpgikFenruIqKwPh0kqM=; b=G8gkSgmadp5A6zNHocxcwD01U6nvvUtj2SQJ6WbZmhVOE2Y8XkRe+c9IQC8LzvrlHh6Yk74y9Z/esQy32cX3S+R3RlqtbIvi85DMnjxaLo8v0QTBsZKcDx+87HMd7dB1TJzvdXVF2Ut9Pv/ti0/tH40vBaOGlAbTzZaoQpoSSLP+Ftz22Wu/D4jTDT/bX2Qu7CQsf6NWWt5uNrDL1jBFu8jLpWrT7dxuD2masR/qk0ZczJpcuzDX5ZeF3vtUFDp+YOQiEociJvpbQX+Y6qJ9E0mDQ/0jaPUg6dhlxm+HHJVpN4YpXHv4i+c4v08LoC5MLhsKLoD4I8l4ksPnuWoKJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eVyHVNHwCl4ADOxL1R+EKqCtpgikFenruIqKwPh0kqM=; b=moh94dBriudnGC3Qw6OsX/W54XlZxNYhCuXkCbkLqUhZhhqUKr4HJVGYfKtLNLt/GudeswPmWr5jL4esHEw3jDC4ZygAYFMIzisAYLQu6T0BjhhhE0EZQKVvWxwM8FdLk0QGdUaWM21Ypkj1sbdDO3tRS6KMVusOzpCkv4przSJc/BR4k2RJTXYSlvsrXqUMQPWsqI1XAajS0K3FpU5aolhF4VoXBZgqXTB1oqQ0BQfpKGyd9SSm6MNrMps8uC+Qf77aU6LL/VqdkC3SD6uTqpxUySDMwBpgONwBXjIEeLhS1nzlUwoQoJZsMqJ8zlbxEJ7SjvDj1W/QoXs0780Czw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <670588e9-48aa-779c-ec5e-88d6b9d12a76@suse.com> Date: Fri, 8 Jul 2022 14:47:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 2/9] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220707092244.485936-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0051.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1b9af74-d3a4-4b9f-cfec-08da60e006af X-MS-TrafficTypeDiagnostic: AS8PR04MB7718:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QDw09LXXgvtdAk9Ifv9MeKFFdeoWX1Dtzo/B70EYXOpDHyx6FZC2YPYVwjqeyPEwOapalvD5ryOEIRNwTUeoSbmE04t6UnHorcl9ZVII8+Xap+mQXJbIA3pHYBNa0aGbBKL0rFiKZ7TFwct5wHU8PFMwZnNnCDRgGoPWmUVBd8WP7dKlJoQbS/Jqq/kS0dqSdQGuZ8xjL1eDbNxXhUkYI3zSFRfxTGnqbYA7XOwpsv6uNCUDNI0hTMFLgt/ksKIOKJBVDW96itfK3aWUQMtFA/p4Z6pz+jyOYU5OHvAqIwpnl01q0TyH/H4SUZKpIjsF3VUELgUOhhkMJWNXCdkdpgyMyTubJaBUD026iSOTBf79HL4IibuakljssrUutpKfim/lTQEsTsHYKmZwDJhOU+CqQPYUN+6FoyMjKZ+gOAeb5ZgTPsJkbCo9Xf0J7u8odhbo/BNWLehCtU6vECXM3VsVOzRoESgO8/KKHH0xE1MvhxtBZC6s3ulc/96Bfxro+nYc9m0HdNopL+HK75a7SFURSAeAAy+2kIkVB4Ovm4Jw1DXOivoxLRvZnNRhtjsBnpCngpS5l3J3SvsJAQb2ZdLfOkOjPPR7REgaFSzq+opgv3s7PmN6DQvEOlIrIUX2PFNWss22udoO/hpniejrXDZQHxYpwuEr2DzHe7K3S7LpJY5JMGUXaLBGNLNrYJByiyX0deR4Zv52351V9GwMYlgZYkaJYnIAX2hO9ZCqOGegyzPwqoGpB8iwFQ8QuDqW1o721TrZyRK2xW5FgReLfvp0AJCvy0ca+Hr4hSCiFMNK5trfs4+WWGFvQdA/1mN87DKZ2tfe5xxa3Cfs+7a/bPCFQh5llkzELvprxbMf8E8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(366004)(396003)(5660300002)(7416002)(8936002)(31686004)(36756003)(31696002)(2906002)(86362001)(38100700002)(26005)(6506007)(6512007)(54906003)(53546011)(6916009)(2616005)(6486002)(186003)(41300700001)(478600001)(66476007)(66556008)(316002)(8676002)(4326008)(83380400001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkxheXczZHNYTVl5YXVpT0VXN2NHdGV1RzNCN1pTNFhMUmkxdGgva0k0ZjR3?= =?utf-8?B?dDR1ei9vYzFXbitkVHc4NC80OVlHdmQ2eEY0T21CV1pZU2FTd2FjVVFPb1dk?= =?utf-8?B?bzBiS1AwZkgwZ21wODdPaEI5eVI0Q0VSMWxqQW12Vm1jUnZhOEo3Mk9Xb3gx?= =?utf-8?B?VnhwMjRra3M3bmVTa2FJMEg3VlYybTE0aG5Lc1VwbkJNQmIvVHpVN0tUT3l3?= =?utf-8?B?bXNHYjV3Q1MwNVV2aGNjN2MzWW0zUFZ5Rkd6RVZJRTMyR0l0MEIyVlpITXA4?= =?utf-8?B?YlZiUERoanY5S1NPVWhHY0JFNm5zSXVqcjEwM24xYno0b3UrR0NuWW1IbVd6?= =?utf-8?B?aEFxZ2ZSc0RMdmtadzQ2ZGxwOU1YRytKRFhxb21zVDc0M01lUkNJaGpvMHpV?= =?utf-8?B?bS9iZkNFd1FuS3oxak1CbXRpVTFhUDliSlB4ODFDSUxJSm1pcFQ5UHExM21r?= =?utf-8?B?c2tuRmRwRFgvUzY4TGhtbUxkL1VORVhuK2NjaTZTTnpQV1dzekVHandudkFH?= =?utf-8?B?c1VlbnR2REdTb3lEdkZTZ0F6dURPRFpacmVYZDhOMnIxL1JXK1hYZGxEMnFT?= =?utf-8?B?b3EvQkwyeHJoTTNINXppNlY5aTZXMFhJS1dMcjJxZXJhdUhPVTBDdTBWb0dE?= =?utf-8?B?MVBULy9WVkxXTkgxR3N0dHRRNldLemd2bU8rSlpTRW4yTzVWMjFHbFJwZTZC?= =?utf-8?B?TTNTRTlzQ2tRcGNTK1NMUTNGb3VZNTNmR1djaTJncW9ZNU1uNkhXZSs5WHJo?= =?utf-8?B?bC9lVFZLeWRPcGx3L1h3THczWVNNU3NVc2czZ09EbmlQL0pzNGZTOFcvNUl0?= =?utf-8?B?QTJKMFFMZmlPUUlDbnZKQytXcFgxQ2ZCdUlEcDNsQW4zTkRPNk9NRGtNSFQ2?= =?utf-8?B?RXhVYlhrLy91R0tCUmJyR1Iyd0pML1V5TUlhS3krMDRIN3lvUmFJQldOSDFj?= =?utf-8?B?Qjh3K0Y5T0JDb1hnNWlCZlBrUEt5Z21qWWhDS3QzdDhwZGdOQlQ1N1lYK2M5?= =?utf-8?B?RkpZSGh6WlhiUjE4amFDR1NOdXdFMWRQdjYvakFzbGdjY21EanVXVy9UV3Vv?= =?utf-8?B?K2I4b1pCQmxrc0Z4SFNUTURSdzU4UnFMVlhMU2V6eGJyeFU0eFY1akh4eDRk?= =?utf-8?B?UXNnbnhsQjVZMDZiUE0vZ1FsVmhpRVU4ajVJUkg4R3FLTUp0c1pBQ1ZyYnIz?= =?utf-8?B?ck1LOHVmM240MFo2eE5mNlc1dHdMMGpudWNXSkpuamFSd3FxUlp0VldVL2Zt?= =?utf-8?B?WGRpaSsyM0JlRTNra3NzNGtKQWl2NHNkVzlQNGozNnVDWmhVRGFSYXVtL21T?= =?utf-8?B?YlNYcEtKZ3VKL004dGsvZFBhSGxueFBqV2pSMnEzMGRQMHFmenNHdHJMdmt5?= =?utf-8?B?Q1F3U0RWVFdlNGZiNlRPRDE0RDFrYWpwVXl1OXRXMXBpQnFRU0U2cVluL1Rz?= =?utf-8?B?L3lwTHhYVGMvU2NYNVoxK0hqSWRhSVQvS0dQb2toeVc1SXpEVXZtNnExQ3hZ?= =?utf-8?B?SncwQXphcjZmM3V1Snp1alFGTGcvMzBIRXpJTHBHeVVFcisyTTJFVGZ4VTFV?= =?utf-8?B?Z3BOeXJGV2t5QVdGMU90Wk9hUWdsejF4T3pJSm9vSGFDamJWaGJEVGtGNUlW?= =?utf-8?B?ODVBb3pjUnRTdHRmbXd3ZnlWMGQ1UlI1OTgrcmhsajY2SFdWVmxuWlgxSWox?= =?utf-8?B?YVVURGJnT1hYOUszZ3lKTkFJMVBqYVJBb2VoRGo4M0FsaFRVZy82aGZMZzg5?= =?utf-8?B?bS9yUFBBT3drYkpFQlFBckR2ZGFmYVR2OUdLQmltTXVTQkpxOUhCTWRibDF2?= =?utf-8?B?bDk4S2FVNnQrUU1mWkRhSjJHS25sRE13VnpDWXJvR2x6aVRPQUJPYWd1U09k?= =?utf-8?B?aU1vUFl2Y3htd2dUTy9XdjJFd1MzRjkvRUtsOEhmQlNRK01GU0Y1WUdBZ3BN?= =?utf-8?B?UHpyUnRSK2hWTC85bStBYThWSnQzc3poZkpJcVkzYXRUQk5wS2FkdjZtbUQ0?= =?utf-8?B?dE1WYml0RUM2UndSeDFOV2VwQzRKL205SytITnpJb2xDZGNXckhjUXQ5MXhj?= =?utf-8?B?WUtVMUR2VVJFN3lKV2xEaFhuWFV1MTZ2V1lnVlcyWTZqalhZK2hFOWp2c2pw?= =?utf-8?Q?3MRzwLJAwScjekKW9O8JGaGTF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1b9af74-d3a4-4b9f-cfec-08da60e006af X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 12:47:32.9191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PbPuuC346m2iNyoyvu//3Pl+mHm8/JdYUz20w+F5v3WscLDXgy/wXffUyQKv+r/XdgkZGJBur0nPK/aD48UKvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7718 On 07.07.2022 11:22, Penny Zheng wrote: > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1622,6 +1622,8 @@ void put_page(struct page_info *page) > > if ( unlikely((nx & PGC_count_mask) == 0) ) > { > + if ( unlikely(nx & PGC_static) ) > + free_domstatic_page(page); > free_domheap_page(page); Didn't you have "else" there in the proposal you made while discussing v7? You also don't alter free_domheap_page() to skip static pages. > @@ -2652,9 +2650,48 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > scrub_one_page(pg); > } > > - /* In case initializing page of static memory, mark it PGC_static. */ > pg[i].count_info |= PGC_static; > } > + > + spin_unlock(&heap_lock); > +} > + > +void free_domstatic_page(struct page_info *page) > +{ > + struct domain *d = page_get_owner(page); > + bool drop_dom_ref, need_scrub; > + > + ASSERT_ALLOC_CONTEXT(); > + > + if ( likely(d) ) > + { > + /* NB. May recursively lock from relinquish_memory(). */ > + spin_lock_recursive(&d->page_alloc_lock); > + > + arch_free_heap_page(d, page); > + > + /* > + * Normally we expect a domain to clear pages before freeing them, > + * if it cares about the secrecy of their contents. However, after > + * a domain has died we assume responsibility for erasure. We do > + * scrub regardless if option scrub_domheap is set. > + */ > + need_scrub = d->is_dying || scrub_debug || opt_scrub_domheap; May I suggest that instead of copying the comment you simply add one here referring to the other one? Otoh I'm not sure about the "dying" case: What happens to a domain's static pages after its death? Isn't it that they cannot be re-used? If so, scrubbing is pointless. And whether the other reasons to scrub actually apply to static pages also isn't quite clear to me. > + drop_dom_ref = !domain_adjust_tot_pages(d, -1); > + > + spin_unlock_recursive(&d->page_alloc_lock); > + } > + else > + { > + drop_dom_ref = false; > + need_scrub = true; > + } Why this "else"? I can't see any way unowned paged would make it here. Instead you could e.g. have another ASSERT() at the top of the function. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 08 12:53:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 12:53:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363403.593897 (Exim 4.92) (envelope-from ) id 1o9nUO-0008VG-NN; Fri, 08 Jul 2022 12:53:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363403.593897; Fri, 08 Jul 2022 12:53:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9nUO-0008V9-Kj; Fri, 08 Jul 2022 12:53:44 +0000 Received: by outflank-mailman (input) for mailman id 363403; Fri, 08 Jul 2022 12:53:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9nUO-0008V3-0r for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 12:53:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2071.outbound.protection.outlook.com [40.107.22.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ff06d395-febc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 14:53:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5318.eurprd04.prod.outlook.com (2603:10a6:20b:7::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 12:53:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 12:53:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff06d395-febc-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dqLs1/tthdRETem1FhFPtcHO9pyhdWB2t+tVoqsWFCTLjDtn8ZH7XE92hQJoEx+bBRgKnjEg7V/dDgZq1a7OVhCQ7nHCIZmiXCMD+K6NdL1dfIl0ZXs8fc+lMd5t/zO/wApaepyOKzDyJAu0vy25Xe6c698IIukg8WXupE+/IFZr5YEReItbPDMcqDDFXyzZq1P8UgRekzRVBnE0QnhHC8oeLG33aTaNtITjaMCM8/da4EXImcTDLJxR0ZBgVIElL2cWLssoxWIuzSMmY3TCeGhbT/2vInKM4Lv+hYU48tQLwryxM0jTTLyWwDZsLmNilYg8r0niG8zdNTGWapIcZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N2rZCp2R3TP1sJYg+Uu2b6y/aHhd5RupaI5lUf4TZ20=; b=ZSR/lfVzpN3rJPbxzx6D0ndzqdnFPUNsCNKqmyLZU0fWxfTccV+WD2yIr+4Fj5u8B09vOBWPr6hCpfow2qgrfJ1unKWKnf8J6NxV124WLH4yD7UUHGU+9aZMTX/PMhVOz5mhQxx/7Dsw6+rtUIcu6KLbchHPr+yxY1xqxrPCN8EZRxa2XPUMUWAe30giaxr7HFvEfUYkQMYI4eAL0XebPFUUIufNxbsHOzUupTc+KB0jFP6Ho8lvC7T6gcBAAODiBmEC23s/CMcSHq5fzdF5qpvi4A/FwwkVZHCw5la/ZfcdYJ/v4PUQj7xGcT7Ku3t4Q2rG7au/geoNXGUJYtZnNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N2rZCp2R3TP1sJYg+Uu2b6y/aHhd5RupaI5lUf4TZ20=; b=1n0FfFFR34XJVeNuU+fgXEkpx3M/xAooxeFq4eFoXHnp2zBmrfsb0lxw4Sgvhz9D9425rZNX5djmrcXb5073dlT+Q7rDxcIrL2pLuzUFbv0wqcWZcIIrrDnEx+OvR1ZBkgF1yEXRcRO4Y8jlH5tbRqjAFW3gJzeJg7m0d+5v7NjxwYnC7LxPqv2NUUeUICOVtNV2VX/o2DGTNwpnjl2zwc9Xjo+ADNchjWA/un7yE78bt3T5L7uPcIPgvPrkbQRAunjsCUjln0Ta8I+4x5C+HtIc89EMAjQe0s4NzAmlSj7rLgNIRgHdYHl0PKS6qaF93ra/G+3YxLRvGBbLlkPE/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8be06889-1dd4-cc79-f2a3-0cd09cb1b735@suse.com> Date: Fri, 8 Jul 2022 14:53:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 7/9] xen/arm: unpopulate memory when domain is static Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-8-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220707092244.485936-8-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0031.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 81760f55-3d7c-46b1-8ed5-08da60e0e223 X-MS-TrafficTypeDiagnostic: AM6PR04MB5318:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 18V5GkUO8IuwaGhFOzs1eMPChyYja4fSbdedk7ccHygsoOmGfqVn23pAEKoYxgZGJHcGUcr5L4PbdVXI0YUQrYVJdzvzRrNsrQ3jyr6jQSkGRHMrpr/1dlbDpCdQvvFCmNx5FzPuuvnyCHLIDQ/6QmyO8coEUrbgkyKzDXjwFcfVZ7EHlMn6MYcr2Pz9QzVGNoGoP6kgOWNZU/ZQztKpzGR2AeuWYo2D6Zh2F7R1U00lD9Tkn0SMs1Qw3qiTSxHnGUdheXxp4KbkJytWc+61ZN3t9XqIz7iDhTSoZmT7SMj4isxc15DGsVxZEdRkl/heY/6OOlfq6z8IfyIPX1zU7JghZ0SOQzbpQ0UQqhMQZM2ylSHKdJXjyNaspFViIfFzT4fHDHn0NJEsbp8p9Uh2jCJ3qWygbbez+wZRCIWmYcNhAohABRubRvtEVp1TAmqJS8yVujztM6K50KDyzJo6WYfCkdsPEyvkbqiEjA23+OkhNYoWLsIdB4WeJ1+EPvejepAXvP8M7skcdVJwIm3ogoxE3Mm/JI+DWOqXMJTEFPeenhLvnUpW7WDbq1mi4jiFz7m6+8F1+PBq3gNgxny5YjRWeCXMD6byQDwrc3ng3u28gEOjif1an/9MJszAUNWQy0dmVd3/zdkNNar31kE9dN97PYcrWZ7OmXCVJ8ez/XRp8MRgeL7N9Xe0y/jZMvQ+odJfi3fgh6y0LCycwclO4ygaixKYEGNpAB6k0tO6KcFU5eP9qc3KFU/rDqExGJJIrMr0qz/Ai9Ap7+/oc8PCdeUakeekLmi2Du7O4JFLSyoDY79lS0CcR7RsdhU5sMfQNB9nIMIadJZH2l2pwMrWzV04TSb3BB9cjKFS3PLbXPs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(366004)(376002)(396003)(39860400002)(8936002)(5660300002)(2906002)(54906003)(6916009)(478600001)(8676002)(316002)(41300700001)(6506007)(26005)(66946007)(31686004)(4326008)(6486002)(6512007)(53546011)(186003)(36756003)(2616005)(66556008)(66476007)(86362001)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVFqYXRvUHRIUWRHeFYwRm16ZzI4UFVwYmtkaWxSamdrYzdaaFdFMkZ6aDUz?= =?utf-8?B?eU5iNzhJM3RPeGdvL3BmSUNVaFZDb2pmQjRzcnNyYlNyUThTL0lYT0VDUjNI?= =?utf-8?B?RVdTNFlnanp5R2E0RmlvaEpoc3gvWDUxK0g5QitiaWlNd0VFaUl4RTZzVm8y?= =?utf-8?B?WkZBeGEvbUZ1R2JDQkM0SnpzUDNRbVpYb3h6KzZpeWRDRkZxYzRoWUt2ZDNh?= =?utf-8?B?SktncldzSVdFQ2wxcVRKNzkxbXZyU1gva2I2dnlSN2wrRGd3b2g0cU9UbHF5?= =?utf-8?B?TkVJSGJLYXF6aHNXMVBkWmZuUEZZanIxbkVoOVZYdVFJNGZPTVM5WW9yUk1I?= =?utf-8?B?U0xnSGtoVmJsVHBobjNrWlNPc1lSVHcreDdIU0RPUmNoRnhKS2lPY0tnSlIx?= =?utf-8?B?QVc1WEtJU3NtWEFVZnBaVVpJdGtkc0p5bE9Uc2FUTTQ1cy94eHpMS1EvaC9Q?= =?utf-8?B?OFhyNmxvdWtNUDRXOTlYQ1lYWmd6LzJIYXFTRzU3bWVIb3p3UlowSUhwMWZF?= =?utf-8?B?aEViY1JoUWM5elJKRUVBalB5cnNtOWxaSVJwdjl1OFFEK1IwMitRSWFWZmJ1?= =?utf-8?B?MUJYOEF6QjdUUUtIMEErWlM3L082cU1IdW11Qk5oSUovSzNUYjVmVW9UMkU2?= =?utf-8?B?RHl5WUFuZVV0c0tFcWg4WEM5eWVVYjVia0lXSUdKNVFMK0FCNDBsM0xWS0t5?= =?utf-8?B?QUo4ZUc1Znl4UitDRXRtTE5tM1N5TDBXbjM5UlRsd3o1Q0QxQXRONGFhejB6?= =?utf-8?B?VEJ6S0NXODdEdElqS2kwYVl0ck9VazcwNWJzUzRvc2l3RDRqa0RhZ2tTbjNR?= =?utf-8?B?cVd2N0pNaTUza0ZNdldnN3NUaGdvNTc0UmdxcGtpeWhmMmdnNHp1eGQ0T1ZS?= =?utf-8?B?dDc4dHNSU01aOVEwUVpIbk93RFRYaG9qQzhZL3E0UlZ3QzNaMGxQUFI4a0Y4?= =?utf-8?B?ZGNFek1EeVlTU3VVT2JBZFRmU3BueWhVSGhBSmRtbmVqbjdjRVYrOWZ6c3Jq?= =?utf-8?B?QVV2cGFjMUNSMFB1QUFMYm1NbzlpczhsYXVTTFFDeC9FRlF5R0ZUakRLbWtP?= =?utf-8?B?NzFlcW8yM2V6cENFYnJxakt0aSt3NmNNRGljL0NVcnYwSWt6M2dpQ1A2Z01z?= =?utf-8?B?NHp6U2ZZT2J6bkd4SFdUbVEwYzlWb09BaEx4alF4TUUwVy9ObzFHQzY3RjFU?= =?utf-8?B?V0h6aUw1WEVhYldOcUM2WVY5cUd5WGVGdUJjQnhTTjBaKzB4NitrMXZpTHlH?= =?utf-8?B?MlR1Q0ZxczR2SUs2YUxOdy96Ry9vNWxFOXd0SGNobHJRcGcrTVR6YUdoYmxy?= =?utf-8?B?LzRrNUZ6OWlyUzludTJFR09uZnJPb3V4VEw5QmFOS2hRQkx0cVNTd2Q2d2ZQ?= =?utf-8?B?VWFzMUtoQ1l5aTdxcmozY3NZcmtkeVFKaUZESDFtQVFlQ2pTcmZrQW5jTEJt?= =?utf-8?B?dWJZbnNhNVA0VisyalgvamVycnp5RkJZSEt3MWN0bk5LcEsweHZZcXY3VDJu?= =?utf-8?B?NGswYkRrTlVaRHRadXEvUEJpU1ozVkVSa3FxZ3R5dGpIOW84M0JSSFd2ZDJP?= =?utf-8?B?aXM3ZkFGVWEwUlNUTmJoQVJ4Tk9JMEx5L0JMc3E4bjdTaGJVR1lZazBjZFcv?= =?utf-8?B?d2Ivekk4T2duRTA5RkRQR2FYK0Z3SkZRdkc5czN0VDdVRHFiMjBkRjJtMlBQ?= =?utf-8?B?WXJFNm81MVNnK3FPT3hlWWt4c2VHdmhlYVdvOXI4R3pseW1uZU9XTkFLNlA5?= =?utf-8?B?TFN1Z08wQWduWTBXUENkdGpvOHlxZ0NkRmpIaG9tanduYytpWTRRdGJGcHpY?= =?utf-8?B?V2MvN3plTzV6V3FXelE5UFN4d3d6NHVWcEFYLzBMdzRTUzhuVFJBUWRUcnJS?= =?utf-8?B?eGxEaE1Fb0I4b3Z4dzJkeTVzNENPcHpWcC93WU9ZT01MMEdMMGZCRXRMd1ZI?= =?utf-8?B?NDdZeXRDTitJVDVGSi9TUE4zQnpmV3BMYU9sbkt6UGt0TEZtYkx3UTFlbXdZ?= =?utf-8?B?b0pFU3hkTk54SCsxYXJ6QzgvalI1RmUyRmVBZDBXNGhPWWxIejNjcG81S2or?= =?utf-8?B?NjMzeGhGVG5RME1GZERyNHNjbTR1QnV3dHpBRCtpQnlpZnBiTHZnOHErVWpV?= =?utf-8?Q?k8MNy7gVwe5Z0EEX3S2yTpFwj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 81760f55-3d7c-46b1-8ed5-08da60e0e223 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 12:53:41.5049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FTgFwwspxxsJOmqmzERqPnzqYHxNji3wunqjrDrObbgkea8jRLyb649lSJxq1waB30yh8TxzN2TD9Xa8DdDjOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5318 On 07.07.2022 11:22, Penny Zheng wrote: > @@ -2692,6 +2690,14 @@ void free_domstatic_page(struct page_info *page) > > free_staticmem_pages(page, 1, need_scrub); > > + if ( likely(d) ) > + { > + /* Add page on the resv_page_list *after* it has been freed. */ > + if ( !drop_dom_ref ) > + put_static_page(d, page); I'm not happy about this name - it suggests similarity with put_page(), but is entirely different. But: Do we really need an helper macro here in the first place? This is static-mem specific code and hence ... > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -91,6 +91,12 @@ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > void free_domstatic_page(struct page_info *page); > int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > unsigned int memflags); > +#ifdef CONFIG_STATIC_MEMORY > +#define put_static_page(d, page) \ > + page_list_add_tail((page), &(d)->resv_page_list) ... this can live right at the use site since ... > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -381,6 +381,9 @@ struct domain > struct page_list_head page_list; /* linked list */ > struct page_list_head extra_page_list; /* linked list (size extra_pages) */ > struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ > +#ifdef CONFIG_STATIC_MEMORY > + struct page_list_head resv_page_list; /* linked list */ > +#endif ... this field is consistently available (i.e. it's all the same config option that controls things). Otherwise a nit on the macro: While the parentheses around d are needed, the ones around page are not. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:06:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:06:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363409.593909 (Exim 4.92) (envelope-from ) id 1o9ngo-0002QK-Ra; Fri, 08 Jul 2022 13:06:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363409.593909; Fri, 08 Jul 2022 13:06:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ngo-0002QD-OX; Fri, 08 Jul 2022 13:06:34 +0000 Received: by outflank-mailman (input) for mailman id 363409; Fri, 08 Jul 2022 13:06:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ngm-0002Q7-T9 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 13:06:33 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c874200e-febe-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 15:06:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4735.eurprd04.prod.outlook.com (2603:10a6:803:53::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 13:06:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 13:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c874200e-febe-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGQG2/TF5h0iq7jFABgcbN6ioI2mCcTWtJ5GkWGRJMeQ6GkxIrcFegOt6o7RbmwDukcN28eh4Eqq0UxoLt5Gex5O/Ix/BO7ttvL8+2zDuMxdo42xxW3zDH8YhHChsUSVVjbTkH9c3jnK4TD9cOfyd1IX0ZoW6/KVsxges5tChUrLvZaMza9/r27EZCpoBEvzud3LpCCZik25PTxgqw2MD0izSgB7BN3Ebng5/JZrQC88Ayl6oEUU/TQeQ84skzCRHP8s/BASvC9CmuXc8rlwG3jUA+aT/CjOsNMyaSBm0sM7+agTLrKfO/NrjtJaKwCwfohP/CyZTeZvIZgEO6K5+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AabFokN8GS/5Jif5f7ekO232MOoTvFwR/R6Y90bjom0=; b=IN2vhQf7+vIJznRMuJ2XsFIjRO3eRMCyAoCTKHbKhRgIvpAeblQDCwvu2VFEV77emQrMNwV9QsJ0q1bUUEidPI3p8E0O64t0yweD9qnioBS8Cu0wUSQJiR8O7TJ2VsdGlCsIuXW5HyX26DaOqyVJ2GDCJnSdDmrpPrWFTKjYOqK+NxW8bRIlJROs8xws7Dfq4ybb3Nja+D9NmnngVk7FF+7TmLZd3Xjsek/NSF5GT2mZv2JYR47AE7glcDgo94C0lcEmlQx/iG8ycL98oDwVeYDZagqvBcoHEFQvbcxvh+D7vmgVnRkBM5PNG5MClK76eHysVXa8v8nTQG7IlodFWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AabFokN8GS/5Jif5f7ekO232MOoTvFwR/R6Y90bjom0=; b=IL3Qg8aRoL9DOLpHqowvf1ocG43T+TW42nKiTUgjJjvNDy/d9NzKb9rFE2bOVohfN5d/RArqER+4L3Em9IdtIq0POLJwLkjv0YIZviiqi6BWCgo1YvnioM3tBoOZ3BbdxH6a2IdYHYF77jdswEYteTi2xEWhhNWHtGtcNWZb3PBPrgx5Lor3dDyPBG72pisZBJ1ycD9aRvHYOTtoQycA6CK7k6H9m/PDzRJ5E/1qe3Sjxk+W/1ZyJFxBfgj5fsGQv/xYnLI54puQxZBVCTDXqN60IN9khIiknO+cnq646oVpUTL2g2nmL2Ep/aIxnUVB9vRB5gxWgwc75mDw/SBTFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9697f641-d660-a346-3baf-18bc8ffab717@suse.com> Date: Fri, 8 Jul 2022 15:06:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 9/9] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-10-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220707092244.485936-10-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P250CA0013.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3931627-f392-47e0-cbb1-08da60e2ab4b X-MS-TrafficTypeDiagnostic: VI1PR04MB4735:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +9MfoEkez1kGwskkPGYM7Ozuayfn3IImkS7V5rG9jya2V9YaTmmQx0U3NPkjzz/wKomTstZMHtjF3SHVSw4tNOVKPNX0HLBapNM+aaX93d8NLqki+U+VGaJdzIASJpyOBv6Eq1z+Xw4d5SWrT2BC+IK9iXGyVRObQ3xRr7ONfDSpLkVmjc/oLPqiocPBUdC0vPra6OCP49fJxgjjaG1YdpVNlGBs1KY4ZzJVR9wLgqI7VkupWvqXz4pty4Q+E2Kq0RyaSm2zFwEGJJugxbskSaE+EOhLwFVRSgN0p1cko4ZqpwmFrSnPIxysYnNxRtAW6R5T42fML3M/C9j+Bo/uXghBFfiafls7z7EefpK17UrddCvuQo29r4J5KphWk+9BPJh5P+X2QWv7cKOIq7gmTVW8HGuCRWrbffPyZgyi4NJYrZ3UL3Rf/rXSTdpuDlZYHf27EkbcScYomPeCaiuC2JUz3VHGeFSjlFoMhs/lmNfbLslK+3bUuJ04Wd6ZE4VQo1U4JuBg5hgyYiLLGu8SvbdvTW3UoP9ktS+u9T9Vsm290HyJYsU13yv7w8kqiCZFU7/6T0ItJOugvWArDSuhgeapKT7Ru3ptu/riI9ij0a1qB6f+8WudnZL7fIpFwNuAKkFZPCNBB3Z8HWIWBopB9OTRHt/Mpz/w8MNU6snTuJZOAy70/j12s+5CM9lpTZgEKylDrEETwXwAWT6pbiWMVccWJ0D2CH8T0kAIzMHk/CtfLfdv5EHUGTtgu5DadRg7klyjejujsc2nyR692G4/1oV2xr8fYtu24YGyaYqlzFFzJAzG701+wHPgsKxL/i91+tXQWrXBVItolU8ZzePCa7mst128FL8ty1A4WUbfxPI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(396003)(136003)(376002)(346002)(38100700002)(8936002)(478600001)(26005)(54906003)(316002)(6916009)(6486002)(66946007)(4326008)(66556008)(8676002)(186003)(66476007)(2616005)(83380400001)(41300700001)(6512007)(53546011)(31686004)(2906002)(5660300002)(31696002)(86362001)(36756003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c20rSEFON1V0U2tCM1NNZ1hRL3VkVVVLNTU1WC83cXJmdFdtakpkMVYrb0VT?= =?utf-8?B?L3ZodjFQK21ydnQwbkxWRkM5WGVOODBibG5PK3ArRm9uSWpNc1lzcWZaODk4?= =?utf-8?B?TlhLQXYzOUdWRTVEME4xYW9RWjc4Y28vQXIwbUw1dHNyck9YVG9rSmtlYy9h?= =?utf-8?B?WFllUFNKbDF5WGZnU0p3aVZwcEw3a1FBYTg1L2V2T2pTaWM5ZnlOSzBRUDBJ?= =?utf-8?B?Vit3ckpLdGg3TWN1TVBBNkZCZ0ZSUWNxVGE3Si8xSkVEK1hSWC9GeGl2WmJh?= =?utf-8?B?ZWUzSFZCek8rRHF4aHowY2hQMGEvNGFpcklNUHRZWjNUWXBISEFwbCt4OUtv?= =?utf-8?B?clJvSkErcDYzYzlmVjBheDN0bjR3UDh3Ulpsa21SNUdJNUNBVW4wVjVQRlUz?= =?utf-8?B?OCtjNTdNZExiV3c0WWlHSkxOR0tsM3EvbHFNUnp3b3N4YndyRmVnUW03RitJ?= =?utf-8?B?eWh6RWZHcUIzN1BUN3d1Q3NIVDNESmRKc1BDMmVzQnVGUFRMWFovYXNnaFM4?= =?utf-8?B?aHZYdTErakJoQUVaVmRPU0s1czdCSFlESjhRQ1dUNjFuVnlTMFg2bTRjWitI?= =?utf-8?B?T1VKaXA5MmxGeDJlUjQ0V09zMWs5eUpSQXJtVXdQUEVmVngwUno1R1pqSHFY?= =?utf-8?B?ZDlrOWFvOVczbGFLSjVVdi9rOHV3anlLS1Y3Uk5HZWs3bWFnKys3N2RxTWJJ?= =?utf-8?B?YlVVaFZYNld1aWVIM08xcFp4MzVsM2NFRmlhWnYzL2N5S1Njd3FGSTBpSVZG?= =?utf-8?B?NVllSVBMNjcyVFhKUjl0NUYzdjlPOTdNZTRYMk1KM3Z4VTg1NXBZMTBDZHpN?= =?utf-8?B?UlVVWVBUL3lPRnArdlpUbm5OYS9kd3RoNWFmU3JaaEVtazVteC80OENzS1FS?= =?utf-8?B?Y09vQ0RLdGxWQWdlNFRlNjV0UlV2KzZ5UEZOV25CRGh6ZWdnYlExTGRCenox?= =?utf-8?B?bkZleE8wY1lYUjIvQnZndkk1QlVoS0xRekZyL2F0eklTT3BVOU15UzlsYldk?= =?utf-8?B?dThFTzRyaXE1ekdQaVdGbVJZYmtTN1JuZE4yQ0c0ZlE0QVM4UEh5MzQ0UG9G?= =?utf-8?B?aEZWaGlWYTljNE1FdDd5RmlqUlBnSEZ1djNHUWU2MnhYb21GQSt5b0JwY2tl?= =?utf-8?B?QzNEaEpWd0dxRkl1ejR4SzJETm5yd1FmVVVSNWpKb1psblNtVURKdkhjL1pv?= =?utf-8?B?VkMrWndUaGtrVkVJUnNtbVA0NDlvZzk4WXJKbjYzQUs2Zk50eStsOStURVJm?= =?utf-8?B?WHJPcW5jSzBmQzFCRjI2TU9vSTNkMHdyUDJCTkRCM0tVOU1IcUN5Z0lZcEpG?= =?utf-8?B?K0F4Uys0blNHN0ZMcHlsU1dHdnpqVHV3bDh0bnR5cXB2S3RnT1BDUXNlTHNs?= =?utf-8?B?RU1DSWgvM0MvNG5Bcml3L0ZjRkZpbHJJQXVXSXRRY3ozNFdRSkI5SWFrVHNV?= =?utf-8?B?S3BoVkNsRElBTHFUcG9wZnF6dTJtQTkrN0kvTlZ4MkhtcFB5UDJtRGJDSExk?= =?utf-8?B?czI3ZXJhTGZ6RCtOZ0Ntc0czaHU4N2dISVNMSU0vTG55QUIrV012YVp2cXF6?= =?utf-8?B?UFZvak0vMENKcU83L1FuRjRjbnh6MWpkeG9nb3hPNGRhYU5lQk0zVSt6YWN6?= =?utf-8?B?cnBTTk5RclUvYVRDd25NQ28xUGV2RmFhcUxrWUxTRmUzUEJhR0J1c05nMkwx?= =?utf-8?B?Q1ZBL0c3bk9UYlQvaUJEZU01UzZWV2hZZkhqNnF1ZjNKK3dOZjRMbXpyMm54?= =?utf-8?B?QlhhTzdSQVNQeFlYN3J5TUsxd0dGbC8rV1EwdW1uTXZiOXE4TzNJbGhjc2xi?= =?utf-8?B?RVJPYkNzYnBmV2plazlsdzBuYW1INkFHbnVXLzVBTGFmT2w4MlNWNEMvOWVx?= =?utf-8?B?bllmc01ZS0J0QU9VTHlQa3pWUUo0NVIyR1Y5Rjk4Rng4eEhtUGN1eEx3Mnht?= =?utf-8?B?QmlCd1VjMTY4S0FobUsvVlFpU2wrWnZZMDZ0V2dCT0poUTd3aFFOU0NhUTVQ?= =?utf-8?B?NmhuV1lnUXlRTEc5b2xXQU1Hemgzei9BOEhIKy9ORld1RFlaSVNZS0prVTNS?= =?utf-8?B?NW1JcUZSQVBkakhiWHRPRDR0bnprSVdpVk9PeVNsRytTVFhkQ0hTaVhqdHNR?= =?utf-8?Q?ViGwbzgt5xCy+RgcXrqPIlQtx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3931627-f392-47e0-cbb1-08da60e2ab4b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 13:06:28.0186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rffho7DehExKRcmc5I5r1JfIzj2FDvA+LYQJ1RO8GuXgSi+AKijmUAEnl9oVxVX25snrrgnwtiOoZ8ZyXe6FCA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4735 On 07.07.2022 11:22, Penny Zheng wrote: > --- a/xen/common/memory.c > +++ b/xen/common/memory.c > @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) > > mfn = _mfn(gpfn); > } > + else if ( is_domain_using_staticmem(d) ) > + { > + /* > + * No easy way to guarantee the retrieved pages are contiguous, > + * so forbid non-zero-order requests here. > + */ > + if ( a->extent_order != 0 ) > + { > + gdprintk(XENLOG_WARNING, > + "Cannot allocate static order-%u pages for static %pd\n", > + a->extent_order, d); I'm probably wrong in thinking that I did point out before that there's no real reason to have "static" twice in the message. Or am I mistaken in my understanding that only static domains can ever have static pages? > @@ -2818,6 +2805,55 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > > return 0; > } > + > +/* > + * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, > + * then assign them to one specific domain #d. > + */ > +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, > + unsigned int nr_mfns, unsigned int memflags) > +{ > + struct page_info *pg; > + > + ASSERT_ALLOC_CONTEXT(); > + > + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); > + if ( !pg ) > + return -ENOENT; > + > + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) > + return -EINVAL; > + > + return 0; > +} > + > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; Use ASSERT_ALLOC_CONTEXT() here as well? > + /* Acquire a page from reserved page list(resv_page_list). */ > + spin_lock(&d->page_alloc_lock); > + page = page_list_remove_head(&d->resv_page_list); > + spin_unlock(&d->page_alloc_lock); > + if ( unlikely(!page) ) > + return INVALID_MFN; > + > + if ( !prepare_staticmem_pages(page, 1, memflags) ) > + goto fail; Don't you need to undo what this did if ... > + if ( assign_domstatic_pages(d, page, 1, memflags) ) > + goto fail; ... this fails? Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:15:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:15:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363415.593919 (Exim 4.92) (envelope-from ) id 1o9noz-0004P2-MQ; Fri, 08 Jul 2022 13:15:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363415.593919; Fri, 08 Jul 2022 13:15:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9noz-0004Ov-JM; Fri, 08 Jul 2022 13:15:01 +0000 Received: by outflank-mailman (input) for mailman id 363415; Fri, 08 Jul 2022 13:15:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9noy-0004Op-E0 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 13:15:00 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7b4d0c6-febf-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 15:14:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C220121ECC; Fri, 8 Jul 2022 13:14:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6484213A80; Fri, 8 Jul 2022 13:14:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id VH/ZFtItyGJYNQAAMHmgww (envelope-from ); Fri, 08 Jul 2022 13:14:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7b4d0c6-febf-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657286098; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=36XAfuKXjscIMRoDtiDJGKATV58DDVN9bq8xNSF9IGE=; b=LOwT+zhDaiJgx3k1OdpAf7iPB3UfjhPRvulCjGstCP+2FsaxLiKewwWtC9llkLUIyeAlxb QxuaV7Ty2+jFclwaxx8SueMiQ/50/emx8Ogzkn5gCfShWmIWBMRfM8e3Um6ANNV0CNR983 IPXbnduDUEYWkwF6+sRxyiYzSg6BRNM= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , stable@vger.kernel.org Subject: [PATCH v3] x86/pat: fix x86_has_pat_wp() Date: Fri, 8 Jul 2022 15:14:56 +0200 Message-Id: <20220708131456.5645-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit x86_has_pat_wp() is using a wrong test, as it relies on the normal PAT configuration used by the kernel. In case the PAT MSR has been setup by another entity (e.g. Xen hypervisor) it might return false even if the PAT configuration is allowing WP mappings. This due to the fact that when running as Xen PV guest the PAT MSR is setup by the hypervisor and cannot be changed by the guest. This results in the WP related entry to be at a different position when running as Xen PV guest compared to the bare metal or fully virtualized case. The correct way to test for WP support is: 1. Get the PTE protection bits needed to select WP mode by reading __cachemode2pte_tbl[_PAGE_CACHE_MODE_WP] (depending on the PAT MSR setting this might return protection bits for a stronger mode, e.g. UC-) 2. Translate those bits back into the real cache mode selected by those PTE bits by reading __pte2cachemode_tbl[__pte2cm_idx(prot)] 3. Test for the cache mode to be _PAGE_CACHE_MODE_WP Cc: # 4.14 Fixes: f88a68facd9a ("x86/mm: Extend early_memremap() support with additional attrs") Signed-off-by: Juergen Gross --- V2: - fix indexing into __pte2cachemode_tbl[] V3: - expand commit message, add comment (Boris Petkov) --- arch/x86/mm/init.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c index d8cfce221275..57ba5502aecf 100644 --- a/arch/x86/mm/init.c +++ b/arch/x86/mm/init.c @@ -77,10 +77,20 @@ static uint8_t __pte2cachemode_tbl[8] = { [__pte2cm_idx(_PAGE_PWT | _PAGE_PCD | _PAGE_PAT)] = _PAGE_CACHE_MODE_UC, }; -/* Check that the write-protect PAT entry is set for write-protect */ +/* + * Check that the write-protect PAT entry is set for write-protect. + * To do this without making assumptions how PAT has been set up (Xen has + * another layout than the kernel), translate the _PAGE_CACHE_MODE_WP cache + * mode via the __cachemode2pte_tbl[] into protection bits (those protection + * bits will select a cache mode of WP or better), and then translate the + * protection bits back into the cache mode using __pte2cm_idx() and the + * __pte2cachemode_tbl[] array. This will return the really used cache mode. + */ bool x86_has_pat_wp(void) { - return __pte2cachemode_tbl[_PAGE_CACHE_MODE_WP] == _PAGE_CACHE_MODE_WP; + uint16_t prot = __cachemode2pte_tbl[_PAGE_CACHE_MODE_WP]; + + return __pte2cachemode_tbl[__pte2cm_idx(prot)] == _PAGE_CACHE_MODE_WP; } enum page_cache_mode pgprot2cachemode(pgprot_t pgprot) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:39:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:39:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363420.593930 (Exim 4.92) (envelope-from ) id 1o9oCu-0008U2-K4; Fri, 08 Jul 2022 13:39:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363420.593930; Fri, 08 Jul 2022 13:39:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oCu-0008Tv-HQ; Fri, 08 Jul 2022 13:39:44 +0000 Received: by outflank-mailman (input) for mailman id 363420; Fri, 08 Jul 2022 13:39:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oCt-0008Tp-2P for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 13:39:43 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20078.outbound.protection.outlook.com [40.107.2.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b386ce1-fec3-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 15:39:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4418.eurprd04.prod.outlook.com (2603:10a6:208:6d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 13:39:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.016; Fri, 8 Jul 2022 13:39:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b386ce1-fec3-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OOqvKzCdsJvLwRPXp3Gg2sZMlfOcUPZKh0lEuWEhq9ReLTcpURx3knkrKyMI4EJP+AxFYBMSzVccInZiqrJxwEYvYHCRrBoQtfEGlfeQVs3LhSLyXTNnAuiTLbYzeIOVI/Hds4XSO/CDkkyOuNFMw/ok7nKYGVg7eBEMgtmRPtIRrIscXRKx+nMsA7Cy1iBDtthUlHmi8WxJyiNAdE/8KOpWAdfjz7FuthZ8X1Ad1myytzpejfBPuSz4ZSOS4LD5PD0W0u9Yh/VREAwwyJNLZ0n3zkNIcvl8qRZeZL+bXBy3RmG5I4amNIM/mqDxlqPuhFdDHIKJdd1FNauXiSn/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cKdnm3XyVTt2oEDS8+TU2y+4wxHgZzHT82MYHpkWhDw=; b=bRfashimuCARo+a7ehsTuNV88bC5F3OaLXZXS7yn16fyIJfKllshDgmkdq8e7CppN2DFKE6pYNQCmnhhuk3/m0prfk5sIiIVqXdWH8TKcECUqmw/2kmJW6Kf3yYne72tSh1KOh6YKM291GKJmE43WAnGwpSuKg8yqtkFetbKvOU6+U3DkPoX6hPzwCxnvOPOC0WjCCKzVjFOBdZXtTl5im+hLfVxtmIeU6zSrcmVP+1JG2kxuaCaJxW+Gzd+Oa3k3CjQVvZrt4eub5cQ/4L1muB1tVeKl1fHcYXZo3Ni5B04wcp/VDGIwk6oNjcNrm/yTYU4u25pQdJB95kaghN/ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cKdnm3XyVTt2oEDS8+TU2y+4wxHgZzHT82MYHpkWhDw=; b=xk3RvprhAI/NVWSf2DsdPvgZSBW8esOlaiLW65y7yHE54gMb4CzjoSJsp6RXj/ilCnUsjNP0CbRxFw0nVq5GUn1kvK5vask2h2+EyBH3ict01ZsEpmhVHQy9Hk9AysSLATwjahCjO7t4V7OfaGwVE7znZSiSpskvrL3CV2njWyBcvZHaambbDin9/3tvlBWLtGdyl/hFYlQzI9Vbxiw9tmEKV7Ne8ek2jU05sdxynmr+2jmDd0i5ejVJAlGUqyiS5UsIw8v+MitegzlMVHbmBHjsKMb83c3IuZKm9Cw6HPyGF19qd4/m5+PPyHznfLI0I71yEYxkjeqtsR/omVGK1w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> Date: Fri, 8 Jul 2022 15:39:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu From: Jan Beulich Subject: [PATCH] xl: relax freemem()'s retry calculation Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 195fece6-f747-427b-f82f-08da60e74e4f X-MS-TrafficTypeDiagnostic: AM0PR04MB4418:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iZ8RIXH0NykgXQY5Ey7Tp1G9ejDqU11PA6aNW7IpMzZrAoUxPHejFoqLCMmLdAtkD9s5+w1ZbAGBDV1Cu1qcu2T8G8FQWCmY8m/QJPRYol/DWwrOfcBvfDrCUDHIuu2mC+MxFGAxzN7wnBv4qUs24v36ets3KNpQjfW5/WAYSUBATDvXmldDWEeakWaqew+FDlnqmKBdryvFUIqzgKoE1zAuAuVHV7RbW5rAIUM3JApxldmDZR5JozxTujRmd0loxd4O6xY7GFrptrTf0MgoNcXha3lHOVCJGcMDhmsDY1tJPHU9WyTrGbtXcYELwDrUm30W83O909cdbsAA14pDi5AW0BqplDrvbdix+ywINCqHmUpIQbW9ZFOqc4pHqrohKdWm1Do9NW313nAvztixefGZf04TH8+9SyAd0Arc8HEL73JxuxSJeAh7g5T+I2IxMxlN2IFgawe730omba6YreYzPztrUBsIpnVmDIqp15vCBjhl8AqYebtnjnWYgzaiKEPzEJ+DO6nDvgDtSV3SkmoL6E1Mh+1BfhsmuYb4ep7jFCHaLtZeCsELRXWW+kx56kgz7gHN78tQQSsVllPESGlYUG/dRjaMR7veduCXm69Uyv1G/ddJ3mCEYBwA6lVDiaOhkz1ExO96zaS0KCccnocFFVw3G7LZKPIPc7UDlInO5vzZtv46MOVDDUtd/zarRxVXoNqlUFDiL9PwB6q4Nf7MUARd8NiT3J5OyjwERxodJTS3l8wfEqZ8maszuDWUb7T9MPvZ9IymgK+P1AGrZ0QynkUrQ9SGXzEsBfjDGp8vv++QV2U0E37d/dvQOuC3/lFpEhfNmRUQFeSh5gSnHwUi5A9+d5yTOdwM1Y2uofgF7oyKGXsoZE6J+rGRTBV4 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(346002)(136003)(396003)(376002)(2616005)(5660300002)(6512007)(86362001)(26005)(66556008)(38100700002)(8936002)(6506007)(2906002)(41300700001)(478600001)(966005)(83380400001)(31696002)(186003)(31686004)(8676002)(6916009)(36756003)(54906003)(316002)(4326008)(66476007)(66946007)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXhUWVZoR0NVSmNMSlljbnlpWVl2NUdVU1ZLTWxwY2hZbjdYWFg4VVZ5UVMy?= =?utf-8?B?RXVpRXBVdFBYUURnSnlOM2ZTc01wOGlDSmhMenBBMXpUUi9OQW5zLy83Z0xh?= =?utf-8?B?ampWSi9ZOCthWCtUZWNyYVJOMmk4NnJXUUs0b0dUMTl4QjRSQ0VrSUtMZjhO?= =?utf-8?B?UEZPVGVWU2R6NzNYY0pWaks2bHNTRExrbGlNaDhDQ013a0sxdEIzSzdlWUlh?= =?utf-8?B?emlyaVJuY2Y1a00rS2owRkVqSGx1U1FnemxIN0xiRkxCcmVnemRoZnptWEZW?= =?utf-8?B?L1hFRWYrd0dFUjd3SlRSdFovanJFR2hNMzF1cERxUk8vQzAyRDlCRmhFS2lo?= =?utf-8?B?TXduV2lUYXQwQnhYOEhYWDF5Qy9mU29xSHFGUFJNZTVVd1JEV1g1UFNQcm51?= =?utf-8?B?eGtvUXE5VDVTT1VBSGxGN2JlZzIrTnFWaTVYQlFaOWo1ZkZ3ck50ODFEQXFi?= =?utf-8?B?UTBhK05IME5ZRkZHU0xTbmtGY0VZckJFWnJ6YWVLZmNLZW1IZFRveURwVnps?= =?utf-8?B?cFN6SGZGeERkTTBQUW8zWjJ1cUsvVnFUNk9uTVo4enRjV1BNNm9pR3ZqWFk4?= =?utf-8?B?bndTZ2pRN3dpRGpXc1pyNlJLcElyWnZod05FUEg2aVByUERmdklsNk1rdnly?= =?utf-8?B?MUVsVE4zeEFoUVpJWTFYdDRpNzQxVEtQeUNlelJ0K3F6eXUwd085Y1RJV1Vx?= =?utf-8?B?ZWlGMjFxZzRVQ0sxSnBHbmtzMlNpQ1U1Nkk1eGxRMTN2ZVNIb1hKM3Z1aUZR?= =?utf-8?B?Q21kWjNTUTVLK1VNL0llWS8xS3NGRU5tZWtFSm9PeUxRY0hDcnNlVlBzOFRI?= =?utf-8?B?Vm5HT0hDc1VjcEQ5SE5CWGd2Sm5tMVFmRFMrM21qYzlCTUZMbkdkamp1QndH?= =?utf-8?B?YnVzVi9oSGRHUkd1L0pGM1ZwblBKSzVtQ01WOU9HTzBDQ25NWDJEN0JEWUxq?= =?utf-8?B?MmJQNDl0WmpUZFJjY3hkaTRHbnhoQlNwcU1wRDRMbFJLSzJXM0VkQzlLNUZh?= =?utf-8?B?NW5wUlAyaEFEdTVzdWJTNmlLV2VsMStTMjVmaUFHbWVORlBlSFVTcjkveHVR?= =?utf-8?B?Q2hYcTZDM2ExTlNLWHlCenJZUk93bGxaSlJ5UVBZRlBPcDRJSkRMWUFrQzNK?= =?utf-8?B?bVJtK2NOd2VsNGR4aXBUS0c0S3E4ZVg5a0dsRlFubFlXNTlRU29BQVdVQkFs?= =?utf-8?B?QmJOOHQxdVpVa1dZSTliYmwvakNUaG9LTEE4UEFzUWFRcHBoU2owS3RvNWxV?= =?utf-8?B?K3JBRVlMUkVJUlh1bXgrTjZjbWYwbmVKSXl1MmwvTXBkd2J2eFVXVG5jZ0FR?= =?utf-8?B?TDdRQms3RmVtZldjTGErNEtOZWVsejVnUU94R3hzcWpvNGhXNDN6WjRpOUE5?= =?utf-8?B?bW9KVm5jZyttbHo4dTlCWDFtWWlyWjMrY0hSaG00c3pLdVY0STdvK2VvUWRW?= =?utf-8?B?TmtXQUlLL29WdkNhdm13eWZsRlJSTUpXMkhUTjVEdjVPTjFSQW9XQkNVcktn?= =?utf-8?B?cUlzMHQvWUMxdk51QUVwY2R3Tklmc1JyQ0VaYll5ZXNDOXpyNnJFSExpU1BN?= =?utf-8?B?bGlETFVWQWN3Njl4WEdQcmJkMTl4OENES0E1VmRXemUvSDgvZDRmZjZQeVV6?= =?utf-8?B?eWl6UDY0VThuakRZRjZtSkZQbXF0Q3FoZ1hDRHRlU3ZvQ0VpZG5pWFBTdS9S?= =?utf-8?B?UFk2eHYrTVl2Vy81SzJoQkJMVGUzNlprTDVGL2JzNFZFbHlXNkQ5YkhQQmNX?= =?utf-8?B?QW8rNmpYRUJYY0VVclZ2b1M0QzVrbHd4MXBJakt2QU9Vd0JQZEpreWYxQWxs?= =?utf-8?B?YmovSVBJUkFkdlBCT3EydUwyTkRMWGhXT3NCU0UyclZPOXRwR1BsVnN6WUI1?= =?utf-8?B?MGI4LzRoUXFyUmNoclhqMmNQTEdHNUcvazl6U2V3dFpJVFNoYml0RW1MTFht?= =?utf-8?B?ODJUaHlqS0h5ZHp1RzdrZEJWVWFmSWpreW5qaExRT0p1eWZCblNaTHpUSHpr?= =?utf-8?B?alRoRzdkalJiQkV6WkYzZXdKeUlBWE9DLzM2clVqZkl5a2Y5cXFQMUwyb2RY?= =?utf-8?B?SWEzcWxua1RmTFRPNUJxY0E0bzNjUzRJMElhMlFJaXBURkFpeG5vNE83aGZa?= =?utf-8?Q?RgDTsTlro5Cddz/Qbl41B/IYj?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 195fece6-f747-427b-f82f-08da60e74e4f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 13:39:39.5171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 13Hta00gHRVKaeYOcwLwd00HKf0K7FYpyzYUMd5K6sNEh96D6/FAymLv+aY2WKnyrSVphdaTWDSuyYAyi+3coQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4418 While in principle possible also under other conditions as long as other parallel operations potentially consuming memory aren't "locked out", in particular with IOMMU large page mappings used in Dom0 (for PV when in strict mode; for PVH when not sharing page tables with HAP) ballooning out of individual pages can actually lead to less free memory available afterwards. This is because to split a large page, one or more page table pages are necessary (one per level that is split). When rebooting a guest I've observed freemem() to fail: A single page was required to be ballooned out (presumably because of heap fragmentation in the hypervisor). This ballooning out of a single page of course went fast, but freemem() then found that it would require to balloon out another page. This repeating just another time leads to the function to signal failure to the caller - without having come anywhere near the designated 30s that the whole process is allowed to not make any progress at all. Convert from a simple retry count to actually calculating elapsed time, subtracting from an initial credit of 30s. Don't go as far as limiting the "wait_secs" value passed to libxl_wait_for_memory_target(), though. While this leads to the overall process now possibly taking longer (if the previous iteration ended very close to the intended 30s), this compensates to some degree for the value passed really meaning "allowed to run for this long without making progress". Signed-off-by: Jan Beulich --- see https://lists.xen.org/archives/html/xen-devel/2021-08/msg00781.html --- I further wonder whether the "credit expired" loop exit wouldn't better be moved to the middle of the loop, immediately after "return true". That way having reached the goal on the last iteration would be reported as success to the caller, rather than as "timed out". --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -321,7 +321,8 @@ static int domain_wait_event(uint32_t do */ static bool freemem(uint32_t domid, libxl_domain_config *d_config) { - int rc, retries = 3; + int rc; + double credit = 30; uint64_t need_memkb, free_memkb; if (!autoballoon) @@ -332,6 +333,8 @@ static bool freemem(uint32_t domid, libx return false; do { + time_t start; + rc = libxl_get_free_memory(ctx, &free_memkb); if (rc < 0) return false; @@ -345,12 +348,13 @@ static bool freemem(uint32_t domid, libx /* wait until dom0 reaches its target, as long as we are making * progress */ + start = time(NULL); rc = libxl_wait_for_memory_target(ctx, 0, 10); if (rc < 0) return false; - retries--; - } while (retries > 0); + credit -= difftime(time(NULL), start); + } while (credit > 0); return false; } From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:41:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:41:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363425.593942 (Exim 4.92) (envelope-from ) id 1o9oE9-0001QN-1d; Fri, 08 Jul 2022 13:41:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363425.593942; Fri, 08 Jul 2022 13:41:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oE8-0001QG-Ud; Fri, 08 Jul 2022 13:41:00 +0000 Received: by outflank-mailman (input) for mailman id 363425; Fri, 08 Jul 2022 13:41:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oE8-0001Q8-8E for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 13:41:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oE7-0004WW-6k; Fri, 08 Jul 2022 13:40:59 +0000 Received: from [54.239.6.184] (helo=[192.168.18.9]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9oE6-0007by-RN; Fri, 08 Jul 2022 13:40:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Xr4uRAEJHstj7mGYVcOfeS+4PKcDZXgsEkDQuVMa5oE=; b=l/Z6GnQPa0akbv2flJ2lG1xMlm YtD3N+07HS7Z4R622GIVyhghCxm7E2Nq93MZx4ZoZUcP01fnB9qna4HpRFygIuBrnPCTomGz69GF3 566O/JEK3PJcu2PmWE6p1JcICuVcEekcTU6zs3/VBDOL7ycqkjccjhRQ9TTUObpYqtK4=; Message-ID: <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> Date: Fri, 8 Jul 2022 14:40:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20220622134219.1596613-3-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, I haven't checked whether the FFA driver is complaint with the spec. I mainly checked whether the code makes sense from Xen PoV. This is a fairly long patch to review. So I will split my review in multiple session/e-mail. On 22/06/2022 14:42, Jens Wiklander wrote: > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. > > The implementation is the bare minimum to be able to communicate with > OP-TEE running as an SPMC at S-EL1. > > This is loosely based on the TEE mediator framework and the OP-TEE > mediator. > > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander > --- > SUPPORT.md | 7 + > tools/libs/light/libxl_arm.c | 3 + > tools/libs/light/libxl_types.idl | 1 + > tools/xl/xl_parse.c | 3 + These changes would need an ack from the toolstack maintainers. > xen/arch/arm/Kconfig | 11 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain.c | 10 + > xen/arch/arm/domain_build.c | 1 + > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/domain.h | 4 + > xen/arch/arm/include/asm/ffa.h | 71 ++ > xen/arch/arm/vsmc.c | 17 +- > xen/include/public/arch-arm.h | 2 + > 13 files changed, 1811 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/ffa.c > create mode 100644 xen/arch/arm/include/asm/ffa.h > > diff --git a/SUPPORT.md b/SUPPORT.md > index 70e98964cbc0..215bb3c9043b 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > No support for QEMU backends in a 16K or 64K domain. > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > + > + Status, Arm64: Tech Preview > + > +There are still some code paths where a vCPU may hog a pCPU longer than > +necessary. The FF-A mediator is not yet implemented for Arm32. > + > ### ARM: Guest Device Tree support > > Status: Supported > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } > > + config->arch.ffa_enabled = > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > + > return 0; > } > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > index 2a42da2f7d78..bf4544bef399 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > + ("ffa_enabled", libxl_defbool), This needs to be accompagnied with a define LIBXL_HAVE_* in tools/include/libxl.h. Please see the examples in the header. > ])), > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > ])), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); This option needs to be documented in docs/man/xl.cfg.5.pod.in. > > parse_vkb_list(config, d_config); > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index be9eff014120..e57e1d3757e2 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -139,6 +139,17 @@ config TEE > > source "arch/arm/tee/Kconfig" > > +config FFA > + bool "Enable FF-A mediator support" if EXPERT > + default n > + depends on ARM_64 > + help > + This option enables a minimal FF-A mediator. The mediator is > + generic as it follows the FF-A specification [1], but it only > + implements a small subset of the specification. Where would a user be able to find which subset of the specification that Xen implements? > + > + [1] https://developer.arm.com/documentation/den0077/latest > + > endmenu > > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index bb7a6151c13c..af0c69f793d4 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > obj-y += domctl.o > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > obj-y += efi/ > +obj-$(CONFIG_FFA) += ffa.o > obj-y += gic.o > obj-y += gic-v2.o > obj-$(CONFIG_GICV3) += gic-v3.o > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 8110c1df8638..a3f00e7e234d 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > goto fail; > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > + goto fail; > + > update_domain_wallclock_time(d); > > /* > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > enum { > PROG_pci = 1, > PROG_tee, > + PROG_ffa, > PROG_xen, > PROG_page, > PROG_mapping, > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > PROGRESS(tee): > ret = tee_relinquish_resources(d); > + if ( ret ) > + return ret; > + > + PROGRESS(ffa): > + ret = ffa_relinquish_resources(d); > if (ret ) > return ret; > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7ddd16c26da5..d708f76356f7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > dom0_cfg.arch.tee_type = tee_get_type(); > + dom0_cfg.arch.ffa_enabled = true; AFAICT, ffa_enabled is a uint8_t. So we should use 1. However, I am not convinced that using a uint8_t for what looks like a boolean is warrant. I will detail more on the definition. > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > if ( iommu_enabled ) > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > new file mode 100644 > index 000000000000..3117ce5cec4d > --- /dev/null > +++ b/xen/arch/arm/ffa.c > @@ -0,0 +1,1683 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > + * > + * Copyright (C) 2022 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. This doesn't look like to be a GPLv2 license. Can you clarify which license you are using? > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +/* Error codes */ All the #define below are using hard tab. Please use soft tab. > +#define FFA_RET_OK 0 > +#define FFA_RET_NOT_SUPPORTED -1 > +#define FFA_RET_INVALID_PARAMETERS -2 > +#define FFA_RET_NO_MEMORY -3 > +#define FFA_RET_BUSY -4 > +#define FFA_RET_INTERRUPTED -5 > +#define FFA_RET_DENIED -6 > +#define FFA_RET_RETRY -7 > +#define FFA_RET_ABORTED -8 > + > +/* FFA_VERSION helpers */ > +#define FFA_VERSION_MAJOR _AC(1,U) NIT: The use of _AC() is a bit pointless given that you are only use the values in C code. > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > +#define FFA_VERSION_MINOR _AC(1,U) > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > +#define MAKE_FFA_VERSION(major, minor) \ > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > + ((minor) & FFA_VERSION_MINOR_MASK)) > + > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > + FFA_VERSION_MINOR) NIT: I think it would be better that FFA_VERSION_MAJOR AND FFA_VERSION_MINOR are defined closer to FFA_MY_VERSION and they are renamed to FFA_MY_VERSION_*. I would also potentially move the 3 defines past all the definition related to the specification. This would make clearer that this is what Xen supports. > + > + > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) Coding style: You seem to use a mix of FOO(... , ...) and FOO(...,...). At mimimum, please be consistent within the file. For Xen, we usually add a space after the comma. [...] > +/* > + * Our rx/rx buffer shared with the SPMC > + */ Hmmm... The comment seems to be misplaced. > +static uint32_t ffa_version; This probably can be __read_mostly. > +static uint16_t *subsr_vm_created; What subsr stand for? > +static unsigned int subsr_vm_created_count; > +static uint16_t *subsr_vm_destroyed; > +static unsigned int subsr_vm_destroyed_count; > +static void *ffa_rx; > +static void *ffa_tx; subsr_vm_created, subsr_vm_destroyed, ffa_rx and ffa_tx can probably be __read_mostly. > +static unsigned int ffa_page_count; Is this related to ffa_rx? > +static DEFINE_SPINLOCK(ffa_buffer_lock); > + > +static LIST_HEAD(ffa_mem_list); > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > + > +static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; next_handle only seems to be used handle_mem_share(). So I think it would be better to move the definition (as static) within the function. This will reduce the number of global variables. > + > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > +{ > + return (uint64_t)reg0 << 32 | reg1; > +} > + > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > + uint64_t val) > +{ > + *reg0 = val >> 32; > + *reg1 = val; > +} Those two functions are the same as optee.c but with a different. I would rather prefer if we avoid the duplication and provide generic helpers in a pre-requisite. > + > +static bool ffa_get_version(uint32_t *vers) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_VERSION, .a1 = FFA_MY_VERSION, Coding sytle: Please set each field on their own line. > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > + { > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > + return false; > + } > + > + *vers = resp.a0; Coding style: We tend to add a newline before the last return. I am not necessarily going to comment about this on all the instances. So please have a look through the code. > + return true; > +} > + > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) FFA_RET_* will be negative, so shouldn't this return int32_t? > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_features(uint32_t id) > +{ > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_FEATURES, .a1 = id, }; Coding style. Please split each field on their own line. > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + return get_ffa_ret_code(&resp); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + uint32_t ret = ffa_features(id); > + > + if (ret) > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); > + return !ret; > +} > + > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > + uint32_t page_count) Aside the parameters, the helper looks very similar to ffa_features(), ffa_rxtx_unmap(). Can this be abstracted? Maybe using macro if you still want to have separate helper name. > +{ > + const struct arm_smccc_1_2_regs arg = { > +#ifdef CONFIG_ARM_64 > + .a0 = FFA_RXTX_MAP_64, > +#endif > +#ifdef CONFIG_ARM_32 > + .a0 = FFA_RXTX_MAP_32, > +#endif > + .a1 = tx_addr, .a2 = rx_addr, Coding: Please don't use hard tab and put each field on their own line. > + .a3 = page_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_RXTX_UNMAP, .a1 = vm_id, Coding style. Please add each field on their own line. > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_PARTITION_INFO_GET, .a1 = w1, .a2 = w2, .a3 = w3, .a4 = w4, Ditto. > + .a5 = w5, > + }; > + struct arm_smccc_1_2_regs resp; > + uint32_t ret; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + ret = get_ffa_ret_code(&resp); > + if ( !ret ) > + *count = resp.a2; > + > + return ret; > +} > + > +static uint32_t ffa_rx_release(void) > +{ > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_RX_RELEASE, }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > + register_t addr, uint32_t pg_count, > + uint64_t *handle) > +{ > + struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_MEM_SHARE_32, .a1 = tot_len, .a2 = frag_len, .a3 = addr, Ditto. > + .a4 = pg_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + /* > + * For arm64 we must use 64-bit calling convention if the buffer isn't > + * passed in our tx buffer. > + */ Can you explain why we would want to use the 32-bit calling convention if addr is 0? > + if (sizeof(addr) > 4 && addr) sizeof(addr) > 4 is a bit odd to read. I think it would be better to check that CONFIG_ARM_64 is set (i.e. IS_ENABLED()). > + arg.a0 = FFA_MEM_SHARE_64; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + *handle = reg_pair_to_64(resp.a3, resp.a2); > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + *handle = reg_pair_to_64(resp.a2, resp.a1); > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > + uint16_t sender_id) > +{ > + struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_MEM_FRAG_TX, .a1 = handle & UINT32_MAX, .a2 = handle >> 32, > + .a3 = frag_len, .a4 = (uint32_t)sender_id << 16, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > + uint32_t flags) > +{ > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_MEM_RECLAIM, .a1 = handle_lo, .a2 = handle_hi, .a3 = flags, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, OOI, why is this call returns int32_t when all the other use uint32_t (even if may returned negative values)? > + uint8_t msg) > +{ > + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; > + int32_t res; > + > + if ( msg != FFA_MSG_SEND_VM_CREATED && msg !=FFA_MSG_SEND_VM_DESTROYED ) > + return FFA_RET_INVALID_PARAMETERS; > + > + if ( msg == FFA_MSG_SEND_VM_CREATED ) > + exp_resp |= FFA_MSG_RESP_VM_CREATED; > + else > + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; NIT: I think it would be easier to read if you drop the first 'if' and instead write: if ( msg == ..._CREATED ) ... else if ( msg == ..._DESTROYED ) ... else return FFA_RET_INVALID_PARAMETERS. > + > + do { > + const struct arm_smccc_1_2_regs arg = { > + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, > + .a1 = sp_id, > + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, > + .a5 = vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) > + { > + /* > + * This is an invalid response, likely due to some error in the > + * implementation of the ABI. > + */ > + return FFA_RET_INVALID_PARAMETERS; > + } > + res = resp.a3; > + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); > + > + return res; > +} > + > +static u16 get_vm_id(struct domain *d) d is not meant to be modified by the helper. So please use 'const'. > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > + register_t v2, register_t v3, register_t v4, register_t v5, > + register_t v6, register_t v7) > +{ > + set_user_reg(regs, 0, v0); > + set_user_reg(regs, 1, v1); > + set_user_reg(regs, 2, v2); > + set_user_reg(regs, 3, v3); > + set_user_reg(regs, 4, v4); > + set_user_reg(regs, 5, v5); > + set_user_reg(regs, 6, v6); > + set_user_reg(regs, 7, v7); > +} > + > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) > +{ > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > +} > + > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, > + uint32_t handle_hi, uint32_t frag_offset, > + uint16_t sender_id) > +{ > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > + (uint32_t)sender_id << 16, 0, 0, 0); > +} > + > +static void handle_version(struct cpu_user_regs *regs) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + uint32_t vers = get_user_reg(regs, 1); > + > + if ( vers < FFA_VERSION_1_1 ) > + vers = FFA_VERSION_1_0; > + else > + vers = FFA_VERSION_1_1; I find a bit strange to 'cap' the version provided by the user. Is this part of the spec? > + > + ctx->guest_vers = vers; > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > +} > + > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > + register_t rx_addr, uint32_t page_count) Xen, Linux, and the firmware may use different page size. Below, you seem to have the page size will always be 4KB. Is this guaranteed by the spec? If not, how do all the 3 components agree on it? If yes, then I think this should be written down and we should have a BUILD_BUG_ON(PAGE_SIZE != SZ_4K). > +{ > + uint32_t ret = FFA_RET_INVALID_PARAMETERS; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + struct page_info *tx_pg; > + struct page_info *rx_pg; > + p2m_type_t t; > + void *rx; > + void *tx; > + > + if ( !smccc_is_conv_64(fid) ) > + { > + tx_addr &= UINT32_MAX; > + rx_addr &= UINT32_MAX; > + } > + > + /* For now to keep things simple, only deal with a single page */ > + if ( page_count != 1 ) > + return FFA_RET_NOT_SUPPORTED; > + > + /* Already mapped */ > + if ( ctx->rx ) > + return FFA_RET_DENIED; > + > + tx_pg = get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC); > + if ( !tx_pg ) > + return FFA_RET_INVALID_PARAMETERS; > + /* Only normal RAM for now */ This comment suggests the check below should be p2m_is_ram() but you are using p2m_ram_rw. > + if (t != p2m_ram_rw) Coding style: if ( ... ) > + goto err_put_tx_pg; > + > + rx_pg = get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC); > + if ( !tx_pg ) > + goto err_put_tx_pg; > + /* Only normal RAM for now */ Same about the comment. > + if ( t != p2m_ram_rw ) > + goto err_put_rx_pg; > + > + tx = __map_domain_page_global(tx_pg); > + if ( !tx ) > + goto err_put_rx_pg; > + > + rx = __map_domain_page_global(rx_pg); > + if ( !rx ) > + goto err_unmap_tx; > + > + ctx->rx = rx; > + ctx->tx = tx; > + ctx->rx_pg = rx_pg; > + ctx->tx_pg = tx_pg; > + ctx->page_count = 1; > + ctx->tx_is_mine = true; > + return FFA_RET_OK; > + > +err_unmap_tx: > + unmap_domain_page_global(tx); > +err_put_rx_pg: > + put_page(rx_pg); > +err_put_tx_pg: > + put_page(tx_pg); > + return ret; > +} > + > +static uint32_t handle_rxtx_unmap(void) > +{ > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + uint32_t ret; > + > + if ( !ctx->rx ) > + return FFA_RET_INVALID_PARAMETERS; > + > + ret = ffa_rxtx_unmap(get_vm_id(d)); > + if ( ret ) > + return ret; > + > + unmap_domain_page_global(ctx->rx); > + unmap_domain_page_global(ctx->tx); > + put_page(ctx->rx_pg); > + put_page(ctx->tx_pg); > + ctx->rx = NULL; > + ctx->tx = NULL; > + ctx->rx_pg = NULL; > + ctx->tx_pg = NULL; > + ctx->page_count = 0; > + ctx->tx_is_mine = false; > + > + return FFA_RET_OK; > +} > + > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + uint32_t ret = FFA_RET_DENIED; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + > + if ( !ffa_page_count ) > + return FFA_RET_DENIED; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || !ctx->tx_is_mine ) > + goto out; > + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); > + if ( ret ) > + goto out; > + if ( ctx->guest_vers == FFA_VERSION_1_0 ) > + { > + size_t n; > + struct ffa_partition_info_1_1 *src = ffa_rx; > + struct ffa_partition_info_1_0 *dst = ctx->rx; > + > + for ( n = 0; n < *count; n++ ) Who is going to sanitize 'count' and how do you make sure that... > + { > + dst[n].id = src[n].id; ... this will still be written within the page provided by the domain? > + dst[n].execution_context = src[n].execution_context; > + dst[n].partition_properties = src[n].partition_properties; > + } > + } > + else > + { > + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); > + > + memcpy(ctx->rx, ffa_rx, sz); > + } > + ffa_rx_release(); I saw above that you are expecting the ffa_rx to be "locked". Will it be the firmware to block another thread that may need ffa_rx? > + ctx->tx_is_mine = false; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static uint32_t handle_rx_release(void) > +{ > + uint32_t ret = FFA_RET_DENIED; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || ctx->tx_is_mine ) > + goto out; > + ret = FFA_RET_OK; > + ctx->tx_is_mine = true; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; > + struct arm_smccc_1_2_regs resp = { }; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + uint32_t src_dst; > + uint64_t mask; > + > + if ( smccc_is_conv_64(fid) ) > + mask = 0xffffffffffffffff; > + else > + mask = 0xffffffff; Please use GENMASK() (or similar). So it is easier to confirm the number of 'f' is correct. > + > + src_dst = get_user_reg(regs, 1); > + if ( (src_dst >> 16) != get_vm_id(d) ) > + { > + resp.a0 = FFA_ERROR; > + resp.a2 = FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + arg.a1 = src_dst; > + arg.a2 = get_user_reg(regs, 2) & mask; > + arg.a3 = get_user_reg(regs, 3) & mask; > + arg.a4 = get_user_reg(regs, 4) & mask; > + arg.a5 = get_user_reg(regs, 5) & mask; > + arg.a6 = get_user_reg(regs, 6) & mask; > + arg.a7 = get_user_reg(regs, 7) & mask; > + > + while ( true ) > + { > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_INTERRUPT: > + ctx->interrupted = true; > + goto out; > + case FFA_ERROR: > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + case FFA_MSG_SEND_DIRECT_RESP_32: > + case FFA_MSG_SEND_DIRECT_RESP_64: > + goto out; > + default: > + /* Bad fid, report back. */ > + memset(&arg, 0, sizeof(arg)); > + arg.a0 = FFA_ERROR; > + arg.a1 = src_dst; > + arg.a2 = FFA_RET_NOT_SUPPORTED; > + continue; > + } > + } > + > +out: > + set_user_reg(regs, 0, resp.a0); > + set_user_reg(regs, 1, resp.a1 & mask); > + set_user_reg(regs, 2, resp.a2 & mask); > + set_user_reg(regs, 3, resp.a3 & mask); > + set_user_reg(regs, 4, resp.a4 & mask); > + set_user_reg(regs, 5, resp.a5 & mask); > + set_user_reg(regs, 6, resp.a6 & mask); > + set_user_reg(regs, 7, resp.a7 & mask); You have already an helper to set all the registers. Why not using it? > +} I will continue the rest of the review at a later point. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:56:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:56:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363433.593952 (Exim 4.92) (envelope-from ) id 1o9oT6-0003cr-GK; Fri, 08 Jul 2022 13:56:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363433.593952; Fri, 08 Jul 2022 13:56:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oT6-0003ck-De; Fri, 08 Jul 2022 13:56:28 +0000 Received: by outflank-mailman (input) for mailman id 363433; Fri, 08 Jul 2022 13:56:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oT4-0003ce-LP for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 13:56:26 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf819d64-fec5-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 15:56:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf819d64-fec5-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657288584; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=s9DhedBEfAv/jul8K51L5AsUtOyMkxy6HPD4OGui4uw=; b=XaIKrwMMsclZW425wDD5jmL7u7CNQ1KgCutra12aTFjEr++mBbrgDF7u BFlsxDJUpCO76EsDYer4aQ51rXJDqqJMmaXdynHnOE7B6+TfJvX6sReY7 rZb7L6yz7ae/J9ZW8fnZwwmKim2WBkRMju9gIVc6sPrMsJUlupUsdTuxd I=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75372839 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Nc/ZTK/c3NQ8yty3Cca/DrUDaX6TJUtcMsCJ2f8bNWPcYEJGY0x3x zFNDW+BOKmNM2H1fosiO9y/8BtSvZeGy9QxSQA+qCo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ74f5fs7Rh2NQw3oDpW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnY2WeV8COavzpLUiV0NiTjFGLalE5paSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6BO pFGM2o0PXwsZTUVZnE5Jp0GzN6S3FXuTmJ6lnCkiu04tj27IAtZj+G2bYu9lsaxbcdahEGDv Urd4n/0RBodMbS3yzCI73atje/nhj7gVcQZE7jQ3vJjnlC73GEYDxwSE1yhrpGRiUOgWtQZN 00d/AIvq7Q/8AqgSdyVdx+lpjiCtx0VWdtVGsU77h2Azuzf5APxLnIDVTRbb9slsuc5QDUr0 hmCmNaBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbkRbnXttlVqmvgbXdAirsy jqHqCw/gbQ7jsMR0ai/u1fdjFqEpIXNTwMzzhXaWCSi9AwRWWK+T9X2sx6Bt68GddvHCAna1 JQZpySAxPEoPcmmkyqyfLQyGOuTuua9IDnen3c6SvHN6A+RF26fkZF4uW8jex0wbplUJVcFc 2eI51oPucY70G+CKPYuPtnvU5lCIb3IT4yNaxzCUjZZjnGdniej9TomW0Of1nuFfKMEwfBmY sfznSpB4B8n5UVbINmeHb51PUcDnHxW+I8qbcmTI+6b+bSffmWJbrwOLUGDaOs0hIvd/liKq Y8PaJvQlU8POAEbXsUx2ddCRbztBSFiba0aVuQNLrLTSuaYMDtJ5wDtLUMJJNU+wvU9ehbg9 XChQE5IoGfCaYn8AVzSMBhLMeq3Nb4m9C5TFXF8bD6Ahil4Ca7yvfh3SnfCVeR+nACV5aUvF KdtlgTpKqkndwkrDBxGMsKl89w6KEXy7e9MVgL8CAUCk1dbb1Sh0rfZksHHrkHi0gLfWRMCn oCd IronPort-HdrOrdr: A9a23:cpBuIayf4+SdTZB0fYEBKrPwIr1zdoMgy1knxilNoRw8SK2lfq eV7ZImPH7P+VEssR4b6LO90cW7Lk80lqQFhbX5X43SPjUO0VHAROoJgOffKlXbalTDH4VmtZ uIHZIRNDSJNykesfrH X-IronPort-AV: E=Sophos;i="5.92,255,1650945600"; d="scan'208";a="75372839" From: Jane Malalane To: Xen-devel CC: Jane Malalane , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , Christian Lindig , "David Scott" , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jun Nakajima , Kevin Tian Subject: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Date: Fri, 8 Jul 2022 14:55:59 +0100 Message-ID: <20220708135559.30719-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC and XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC to report accelerated xAPIC and x2APIC, on x86 hardware. This is so that xAPIC and x2APIC virtualization can subsequently be enabled on a per-domain basis. No such features are currently implemented on AMD hardware. HW assisted xAPIC virtualization will be reported if HW, at the minimum, supports virtualize_apic_accesses as this feature alone means that an access to the APIC page will cause an APIC-access VM exit. An APIC-access VM exit provides a VMM with information about the access causing the VM exit, unlike a regular EPT fault, thus simplifying some internal handling. HW assisted x2APIC virtualization will be reported if HW supports virtualize_x2apic_mode and, at least, either apic_reg_virt or virtual_intr_delivery. This also means that sysctl follows the conditionals in vmx_vlapic_msr_changed(). For that purpose, also add an arch-specific "capabilities" parameter to struct xen_sysctl_physinfo. Note that this interface is intended to be compatible with AMD so that AVIC support can be introduced in a future patch. Unlike Intel that has multiple controls for APIC Virtualization, AMD has one global 'AVIC Enable' control bit, so fine-graining of APIC virtualization control cannot be done on a common interface. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane Reviewed-by: "Roger Pau Monné" Reviewed-by: Jan Beulich Reviewed-by: Anthony PERARD Reviewed-by: Kevin Tian Reviewed-by: George Dunlap --- CC: George Dunlap CC: Nick Rosbrook CC: Wei Liu CC: Anthony PERARD CC: Andrew Cooper CC: Jan Beulich CC: Julien Grall CC: Stefano Stabellini CC: Juergen Gross CC: Christian Lindig CC: David Scott CC: "Roger Pau Monné" CC: Jun Nakajima CC: Kevin Tian v11: * explicity define arch_cap_list in stub_xc_physinfo for non-x86 arch v10: * Make assisted_x{2}apic_available conditional upon _vmx_cpu_up() v9: * Move assisted_x{2}apic_available to vmx_vmcs_init() so they get declared at boot time, after vmx_secondary_exec_control is set v8: * Improve commit message v7: * Make sure assisted_x{2}apic_available evaluates to false, to ensure Xen builds, when !CONFIG_HVM * Fix coding style issues v6: * Limit abi check to x86 * Fix coding style issue v5: * Have assisted_xapic_available solely depend on cpu_has_vmx_virtualize_apic_accesses and assisted_x2apic_available depend on cpu_has_vmx_virtualize_x2apic_mode and cpu_has_vmx_apic_reg_virt OR cpu_has_vmx_virtual_intr_delivery v4: * Fallback to the original v2/v1 conditions for setting assisted_xapic_available and assisted_x2apic_available so that in the future APIC virtualization can be exposed on AMD hardware since fine-graining of "AVIC" is not supported, i.e., AMD solely uses "AVIC Enable". This also means that sysctl mimics what's exposed in CPUID v3: * Define XEN_SYSCTL_PHYSCAP_ARCH_MAX for ABI checking and actually set "arch_capbilities", via a call to c_bitmap_to_ocaml_list() * Have assisted_x2apic_available only depend on cpu_has_vmx_virtualize_x2apic_mode v2: * Use one macro LIBXL_HAVE_PHYSINFO_ASSISTED_APIC instead of two * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo * Set assisted_x{2}apic_available to be conditional upon "bsp" and annotate it with __ro_after_init * Change XEN_SYSCTL_PHYSCAP_ARCH_ASSISTED_X{2}APIC to _X86_ASSISTED_X{2}APIC * Keep XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X{2}APIC contained within sysctl.h * Fix padding introduced in struct xen_sysctl_physinfo and bump XEN_SYSCTL_INTERFACE_VERSION --- tools/golang/xenlight/helpers.gen.go | 4 ++++ tools/golang/xenlight/types.gen.go | 2 ++ tools/include/libxl.h | 7 +++++++ tools/libs/gnttab/st8ojiU6 | 0 tools/libs/light/libxl.c | 3 +++ tools/libs/light/libxl_arch.h | 4 ++++ tools/libs/light/libxl_arm.c | 5 +++++ tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 11 +++++++++++ tools/ocaml/libs/xc/xenctrl.ml | 9 +++++++++ tools/ocaml/libs/xc/xenctrl.mli | 8 ++++++++ tools/ocaml/libs/xc/xenctrl_stubs.c | 18 ++++++++++++++++-- tools/xl/xl_info.c | 6 ++++-- xen/arch/x86/hvm/hvm.c | 3 +++ xen/arch/x86/hvm/vmx/vmcs.c | 7 +++++++ xen/arch/x86/include/asm/hvm/hvm.h | 5 +++++ xen/arch/x86/sysctl.c | 4 ++++ xen/include/public/sysctl.h | 11 ++++++++++- 18 files changed, 104 insertions(+), 5 deletions(-) create mode 100644 tools/libs/gnttab/st8ojiU6 diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff1081..dd4e6c9f14 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -3373,6 +3373,8 @@ x.CapVmtrace = bool(xc.cap_vmtrace) x.CapVpmu = bool(xc.cap_vpmu) x.CapGnttabV1 = bool(xc.cap_gnttab_v1) x.CapGnttabV2 = bool(xc.cap_gnttab_v2) +x.CapAssistedXapic = bool(xc.cap_assisted_xapic) +x.CapAssistedX2Apic = bool(xc.cap_assisted_x2apic) return nil} @@ -3407,6 +3409,8 @@ xc.cap_vmtrace = C.bool(x.CapVmtrace) xc.cap_vpmu = C.bool(x.CapVpmu) xc.cap_gnttab_v1 = C.bool(x.CapGnttabV1) xc.cap_gnttab_v2 = C.bool(x.CapGnttabV2) +xc.cap_assisted_xapic = C.bool(x.CapAssistedXapic) +xc.cap_assisted_x2apic = C.bool(x.CapAssistedX2Apic) return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d5258..87be46c745 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -1014,6 +1014,8 @@ CapVmtrace bool CapVpmu bool CapGnttabV1 bool CapGnttabV2 bool +CapAssistedXapic bool +CapAssistedX2Apic bool } type Connectorinfo struct { diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 835dfabc50..3a68e1b55a 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -536,6 +536,13 @@ #define LIBXL_HAVE_NIC_TRUSTED 1 /* + * LIBXL_HAVE_PHYSINFO_ASSISTED_APIC indicates that libxl_physinfo has + * cap_assisted_xapic and cap_assisted_x2apic fields, which indicates + * the availability of x{2}APIC hardware assisted virtualization. + */ +#define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 + +/* * libxl ABI compatibility * * The only guarantee which libxl makes regarding ABI compatibility diff --git a/tools/libs/gnttab/st8ojiU6 b/tools/libs/gnttab/st8ojiU6 new file mode 100644 index 0000000000..e69de29bb2 diff --git a/tools/libs/light/libxl.c b/tools/libs/light/libxl.c index a0bf7d186f..6d699951e2 100644 --- a/tools/libs/light/libxl.c +++ b/tools/libs/light/libxl.c @@ -15,6 +15,7 @@ #include "libxl_osdeps.h" #include "libxl_internal.h" +#include "libxl_arch.h" int libxl_ctx_alloc(libxl_ctx **pctx, int version, unsigned flags, xentoollog_logger * lg) @@ -410,6 +411,8 @@ int libxl_get_physinfo(libxl_ctx *ctx, libxl_physinfo *physinfo) physinfo->cap_gnttab_v2 = !!(xcphysinfo.capabilities & XEN_SYSCTL_PHYSCAP_gnttab_v2); + libxl__arch_get_physinfo(physinfo, &xcphysinfo); + GC_FREE; return 0; } diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index 1522ecb97f..207ceac6a1 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -86,6 +86,10 @@ int libxl__arch_extra_memory(libxl__gc *gc, uint64_t *out); _hidden +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo); + +_hidden void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src); diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index eef1de0939..39fdca1b49 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1431,6 +1431,11 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo) +{ +} + void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 89962218b4..47f6a30cde 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -1070,6 +1070,8 @@ libxl_physinfo = Struct("physinfo", [ ("cap_vpmu", bool), ("cap_gnttab_v1", bool), ("cap_gnttab_v2", bool), + ("cap_assisted_xapic", bool), + ("cap_assisted_x2apic", bool), ], dir=DIR_OUT) libxl_connectorinfo = Struct("connectorinfo", [ diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index 1feadebb18..e0a06ecfe3 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -866,6 +866,17 @@ int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, return rc; } +void libxl__arch_get_physinfo(libxl_physinfo *physinfo, + const xc_physinfo_t *xcphysinfo) +{ + physinfo->cap_assisted_xapic = + !!(xcphysinfo->arch_capabilities & + XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC); + physinfo->cap_assisted_x2apic = + !!(xcphysinfo->arch_capabilities & + XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC); +} + void libxl__arch_update_domain_config(libxl__gc *gc, libxl_domain_config *dst, const libxl_domain_config *src) diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 8eab6f60eb..6fa30ddb56 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -128,6 +128,14 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 + +type x86_physinfo_arch_cap_flag = + | CAP_X86_ASSISTED_XAPIC + | CAP_X86_ASSISTED_X2APIC + +type physinfo_arch_cap_flag = + | X86 of x86_physinfo_arch_cap_flag + type physinfo = { threads_per_core : int; @@ -141,6 +149,7 @@ type physinfo = (* XXX hw_cap *) capabilities : physinfo_cap_flag list; max_nr_cpus : int; + arch_capabilities : physinfo_arch_cap_flag list; } type version = diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index d3014a2708..01774da768 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -113,6 +113,13 @@ type physinfo_cap_flag = | CAP_Gnttab_v1 | CAP_Gnttab_v2 +type x86_physinfo_arch_cap_flag = + | CAP_X86_ASSISTED_XAPIC + | CAP_X86_ASSISTED_X2APIC + +type physinfo_arch_cap_flag = + | X86 of x86_physinfo_arch_cap_flag + type physinfo = { threads_per_core : int; cores_per_socket : int; @@ -124,6 +131,7 @@ type physinfo = { scrub_pages : nativeint; capabilities : physinfo_cap_flag list; max_nr_cpus : int; (** compile-time max possible number of nr_cpus *) + arch_capabilities : physinfo_arch_cap_flag list; } type version = { major : int; minor : int; extra : string; } type compile_info = { diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 513ee142d2..42c2bcd333 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -718,7 +718,7 @@ CAMLprim value stub_xc_send_debug_keys(value xch, value keys) CAMLprim value stub_xc_physinfo(value xch) { CAMLparam1(xch); - CAMLlocal2(physinfo, cap_list); + CAMLlocal4(physinfo, cap_list, x86_arch_cap_list, arch_cap_list); xc_physinfo_t c_physinfo; int r; @@ -737,7 +737,7 @@ CAMLprim value stub_xc_physinfo(value xch) /* ! XEN_SYSCTL_PHYSCAP_ XEN_SYSCTL_PHYSCAP_MAX max */ (c_physinfo.capabilities); - physinfo = caml_alloc_tuple(10); + physinfo = caml_alloc_tuple(11); Store_field(physinfo, 0, Val_int(c_physinfo.threads_per_core)); Store_field(physinfo, 1, Val_int(c_physinfo.cores_per_socket)); Store_field(physinfo, 2, Val_int(c_physinfo.nr_cpus)); @@ -749,6 +749,20 @@ CAMLprim value stub_xc_physinfo(value xch) Store_field(physinfo, 8, cap_list); Store_field(physinfo, 9, Val_int(c_physinfo.max_cpu_id + 1)); +#if defined(__i386__) || defined(__x86_64__) + x86_arch_cap_list = c_bitmap_to_ocaml_list + /* ! x86_physinfo_arch_cap_flag CAP_X86_ none */ + /* ! XEN_SYSCTL_PHYSCAP_X86_ XEN_SYSCTL_PHYSCAP_X86_MAX max */ + (c_physinfo.arch_capabilities); + /* + * arch_capabilities: physinfo_arch_cap_flag list; + */ + arch_cap_list = x86_arch_cap_list; +#else + arch_cap_list = Val_emptylist; +#endif + Store_field(physinfo, 10, arch_cap_list); + CAMLreturn(physinfo); } diff --git a/tools/xl/xl_info.c b/tools/xl/xl_info.c index 712b7638b0..3205270754 100644 --- a/tools/xl/xl_info.c +++ b/tools/xl/xl_info.c @@ -210,7 +210,7 @@ static void output_physinfo(void) info.hw_cap[4], info.hw_cap[5], info.hw_cap[6], info.hw_cap[7] ); - maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s\n", + maybe_printf("virt_caps :%s%s%s%s%s%s%s%s%s%s%s%s%s\n", info.cap_pv ? " pv" : "", info.cap_hvm ? " hvm" : "", info.cap_hvm && info.cap_hvm_directio ? " hvm_directio" : "", @@ -221,7 +221,9 @@ static void output_physinfo(void) info.cap_vmtrace ? " vmtrace" : "", info.cap_vpmu ? " vpmu" : "", info.cap_gnttab_v1 ? " gnttab-v1" : "", - info.cap_gnttab_v2 ? " gnttab-v2" : "" + info.cap_gnttab_v2 ? " gnttab-v2" : "", + info.cap_assisted_xapic ? " assisted_xapic" : "", + info.cap_assisted_x2apic ? " assisted_x2apic" : "" ); vinfo = libxl_get_version_info(ctx); diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index 5b16fb4cd8..0a32a948db 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -117,6 +117,9 @@ static const char __initconst warning_hvm_fep[] = static bool_t __initdata opt_altp2m_enabled = 0; boolean_param("altp2m", opt_altp2m_enabled); +bool __ro_after_init assisted_xapic_available; +bool __ro_after_init assisted_x2apic_available; + static int cf_check cpu_callback( struct notifier_block *nfb, unsigned long action, void *hcpu) { diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 56fed2db03..7329622dd4 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -2146,7 +2146,14 @@ int __init vmx_vmcs_init(void) ret = _vmx_cpu_up(true); if ( !ret ) + { + /* Check whether hardware supports accelerated xapic and x2apic. */ + assisted_xapic_available = cpu_has_vmx_virtualize_apic_accesses; + assisted_x2apic_available = cpu_has_vmx_virtualize_x2apic_mode && + (cpu_has_vmx_apic_reg_virt || + cpu_has_vmx_virtual_intr_delivery); register_keyhandler('v', vmcs_dump, "dump VT-x VMCSs", 1); + } return ret; } diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index caaeacabc7..8d162b2c99 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -388,6 +388,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value); #define hvm_tsc_scaling_ratio(d) \ ((d)->arch.hvm.tsc_scaling_ratio) +extern bool assisted_xapic_available; +extern bool assisted_x2apic_available; + #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0) #define hvm_paging_enabled(v) \ @@ -901,6 +904,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) #define hvm_tsc_scaling_supported false #define hap_has_1gb false #define hap_has_2mb false +#define assisted_xapic_available false +#define assisted_x2apic_available false #define hvm_paging_enabled(v) ((void)(v), false) #define hvm_wp_enabled(v) ((void)(v), false) diff --git a/xen/arch/x86/sysctl.c b/xen/arch/x86/sysctl.c index f82abc2488..716525f72f 100644 --- a/xen/arch/x86/sysctl.c +++ b/xen/arch/x86/sysctl.c @@ -135,6 +135,10 @@ void arch_do_physinfo(struct xen_sysctl_physinfo *pi) pi->capabilities |= XEN_SYSCTL_PHYSCAP_hap; if ( IS_ENABLED(CONFIG_SHADOW_PAGING) ) pi->capabilities |= XEN_SYSCTL_PHYSCAP_shadow; + if ( assisted_xapic_available ) + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC; + if ( assisted_x2apic_available ) + pi->arch_capabilities |= XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC; } long arch_do_sysctl( diff --git a/xen/include/public/sysctl.h b/xen/include/public/sysctl.h index 60c8711483..5672906729 100644 --- a/xen/include/public/sysctl.h +++ b/xen/include/public/sysctl.h @@ -35,7 +35,7 @@ #include "domctl.h" #include "physdev.h" -#define XEN_SYSCTL_INTERFACE_VERSION 0x00000014 +#define XEN_SYSCTL_INTERFACE_VERSION 0x00000015 /* * Read console content from Xen buffer ring. @@ -111,6 +111,13 @@ struct xen_sysctl_tbuf_op { /* Max XEN_SYSCTL_PHYSCAP_* constant. Used for ABI checking. */ #define XEN_SYSCTL_PHYSCAP_MAX XEN_SYSCTL_PHYSCAP_gnttab_v2 +/* The platform supports x{2}apic hardware assisted emulation. */ +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_XAPIC (1u << 0) +#define XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC (1u << 1) + +/* Max XEN_SYSCTL_PHYSCAP_X86_* constant. Used for ABI checking. */ +#define XEN_SYSCTL_PHYSCAP_X86_MAX XEN_SYSCTL_PHYSCAP_X86_ASSISTED_X2APIC + struct xen_sysctl_physinfo { uint32_t threads_per_core; uint32_t cores_per_socket; @@ -120,6 +127,8 @@ struct xen_sysctl_physinfo { uint32_t max_node_id; /* Largest possible node ID on this host */ uint32_t cpu_khz; uint32_t capabilities;/* XEN_SYSCTL_PHYSCAP_??? */ + uint32_t arch_capabilities;/* XEN_SYSCTL_PHYSCAP_{X86,ARM,...}_??? */ + uint32_t pad; uint64_aligned_t total_pages; uint64_aligned_t free_pages; uint64_aligned_t scrub_pages; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 13:57:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 13:57:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363437.593964 (Exim 4.92) (envelope-from ) id 1o9oUJ-00049L-Qd; Fri, 08 Jul 2022 13:57:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363437.593964; Fri, 08 Jul 2022 13:57:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oUJ-00049E-NR; Fri, 08 Jul 2022 13:57:43 +0000 Received: by outflank-mailman (input) for mailman id 363437; Fri, 08 Jul 2022 13:57:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oUH-000492-Px; Fri, 08 Jul 2022 13:57:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oUH-0004np-MY; Fri, 08 Jul 2022 13:57:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9oUH-0005Ra-6k; Fri, 08 Jul 2022 13:57:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9oUH-0001xj-6G; Fri, 08 Jul 2022 13:57:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vuXQfo6O72o+ztFDVYGq090OUDBFjZOC2w6Padjz1zI=; b=jCdH8iumxmZGw3XiU2Bq0iQ9ba o7TE3N8rzjMjE/lhQ5JFjrdoaWqw9n6iVrs0g9dG4XqjjJJFE4FJZRxlVutcHeNGqsJ9c/hsTixbn 9Hj0cK8W0ZBvo4wjGT1hAj1GtrYlT8dlHaoI+pzntlmKITth+y0EQBZCCIuWRMdsRMc8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171552: tolerable FAIL X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c X-Osstest-Versions-That: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c From: osstest service owner Date: Fri, 08 Jul 2022 13:57:41 +0000 flight 171552 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171552/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 171545 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171545 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171545 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171545 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171545 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171545 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171545 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171545 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171545 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171545 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171545 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171545 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171545 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c baseline version: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c Last test of basis 171552 2022-07-08 01:53:16 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:34:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:34:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363450.593974 (Exim 4.92) (envelope-from ) id 1o9p3O-0002Ea-Ry; Fri, 08 Jul 2022 14:33:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363450.593974; Fri, 08 Jul 2022 14:33:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9p3O-0002ET-P0; Fri, 08 Jul 2022 14:33:58 +0000 Received: by outflank-mailman (input) for mailman id 363450; Fri, 08 Jul 2022 14:33:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9p3N-0002EN-BP for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:33:57 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fcbec41c-feca-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 16:33:53 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Jul 2022 10:33:47 -0400 Received: from MW4PR03MB6539.namprd03.prod.outlook.com (2603:10b6:303:126::9) by BL1PR03MB6006.namprd03.prod.outlook.com (2603:10b6:208:313::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 14:33:44 +0000 Received: from MW4PR03MB6539.namprd03.prod.outlook.com ([fe80::e0da:b315:76f5:37f9]) by MW4PR03MB6539.namprd03.prod.outlook.com ([fe80::e0da:b315:76f5:37f9%8]) with mapi id 15.20.5395.020; Fri, 8 Jul 2022 14:33:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fcbec41c-feca-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657290833; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=3kukgLARFaz50JXu0PwK5hZ5dO7sM74fPM2c8+kbvPw=; b=cKE5SdEersToB9TkdIboQXxUrxDRsRbn14hX6xVueyy03qTBenNqJCFK redwgtKFIMppYzqN0mkCqh2fP1XRRxZMz5VnzElZfDSSJjD9/S+DzRZzz qMKGIaGpnVbnnJFSFrANpgwkl4tuZBbXCzOYO18me+vtGrTNfcC4CH5vk k=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 75198201 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rB2/UaAplc3FxBVW/6niw5YqxClBgxIJ4kV8jS/XYbTApGh0gzdSn GEeCz+GafyOY2fwe9pxPI3i/R9QuJ/dz9VjQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgH2eIdA970Ug5w7Fh0tYy6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+0 85hmq6QbT4qYJHypsI/VTVKOTlxaPguFL/veRBTsOS15mifKj7G5aUrC0s7e4oF5uxwHGdCs +QCLywAZQyCgOTwx6+nTu5rhYIoK8yD0IE34yk8i22GS6t2B8mdEs0m5vcBtNs0rstOB/fFe 8sQb3xrbRLMYhJnMVYLEpMu2uyvgxETdhUH9QvE9fBvugA/yiQyjpKwCuLOY+WWRJpxxhyzr HmZpW7AV0Ry2Nu3jGDtHmiXrv/Cm2b3VZwfEJW89+V2mxuDy2oLEhoUWFCn5/6jhSaWQdVEI VYT/Skohac3/U2vCNL6WnWQv3qsrhMaHd1KHIUS6guA167V6AaxHXUfQ3hKb9lOnM0rQT0n0 HeZktWvAiZg2JWOUm6U/LqQqTK0OAAWIHUEaCtCShEKi/Hhr5s0lQnnVct4Hei+ididMT353 T2itiU1gLQXy8kR2M2T/03BxTSlpZHLTws8zgTRQm+hqAh+YeaNZIG26F6d8fdJKq6YSEWMu D4PnM320QwVJZSElSjISuNdGrisvq+BKGeF3w8pGIQ9/TOw/XLlZZpX/Dx1OEZuNIADZCPtZ 0jQ/whW4fe/IUeXUEO+WKrpY+xC8EQqPY2Nuiz8BjaWXqVMSQ== IronPort-HdrOrdr: A9a23:CbUESKHO2YGR7EZRpLqFRJHXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5VoMkmsj6KdgLNhcItKOTOLhILGFvAE0WKP+Vzd8mjFh5ZgPM RbAuRD4b/LfD5HZK/BiWHWferIguP3iZxA7t2urUuFODsaD52ImD0JbzpzfHcXeCB2Qb4CUL aM7MtOoDStPV4NaN6gO3UDV+/f4/XWiZPPe3c9dlAawTjLqQntxK/xEhCe0BtbeShI260e/W /MlBG8zrm/ssu81gTX2wbontVrcZrau5t+7f63+4oowwbX+0OVjUNaKvm/VQUO0aKSAZAR4Z 7xSlkbToJOAjjqDxyISFPWqnXdOXAVmjDfIBaj8AXeiN28SzQgB8Vbg4VFNhPf9ko7pdl5lL lGxmSDqvNsfFv9dYvGlqr1v4EDrDvKnZMOq59ks5Vka/pWVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV4Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r9NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC76 gpkGkowVLaV3ieefFmhqc7gywlaF/NLgjF24VZ+4VzvKH6Sf7iLTCDIWpe5vednw== X-IronPort-AV: E=Sophos;i="5.92,255,1650945600"; d="scan'208,217";a="75198201" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXiMiy/kIgwie4H/Ch1eA3ZHA30RMLZzt0K2ise+U9rcAgfJBqFta5sjmEpHslDBTyDvDbycd1bTfooCMrfrlbxXlnPALpZ9WBHL2rgdKpfMA2yH0ALndtbLMMX1wnjJLtRgFtd5Yr6HMax7JPKEYVTOpfCJNZaXV/6z/gmqAam0UAJAt5gsgf+6iVH9iiJQlYVC3IiX7fwQiYYPX24gWpCkAktQvWZc+Zgiy1cZ0bEBEPJVB7g2sh8xJixDuEI1oAIELwF3lu4JyOF/WDe9cz6Jzw+t99jTW+Luq4BIzaixR03CZX9nK99LsWUV1PQTAQaIAfEJRX/pXVYec4XL3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3kukgLARFaz50JXu0PwK5hZ5dO7sM74fPM2c8+kbvPw=; b=DzsUFe5Dd/0gTWHfU+RGxGDHMEw3vVsQli94bSCNPbDVY6qkLAhJki0KCMBXE/hTddIVdKKqz11GRfoI/caO+XG5UyazhEPz5mvQHwvp9m99wqWs4tC2LL1X6fvKH/9GHLf6XTNRO8gJ2Ue77yDDo7yy21oEuIduZJZZEfndYN9rcfRKCaf8RNU6+oxkoLJhBlYGeFeU7keqEEFOHU+KU6Vil8GbzLFzvft3ZMdDZNr80piduw+fwbEMA8VkPyvOB5hq3g4UpHyG77nt6oqsjy7mUSIEyd5TVj/4lYpZmTKXROALheEeicMQYepb/aUOljPOqBSb/aUzdsRoIJc4lA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kukgLARFaz50JXu0PwK5hZ5dO7sM74fPM2c8+kbvPw=; b=Aw2lPJjsOvbQ7dFAmX8lHQ4mVWdqykoscWHnVrjrBkNTQ4JzU2Yut3qiDRGQhiDFBvkXVjIbHvAPP1C0qGx6qcwj96AWS7WEiDELhCDvVti6aQIre+xHxXrMUc33BiIe3R4mBXyTeuy8stKxd0AZvsqN1uqmHRfSPXEK96LoooE= From: Christian Lindig To: Jane Malalane CC: Xen-devel , George Dunlap , Nick Rosbrook , Wei Liu , Anthony Perard , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , David Scott , Roger Pau Monne , Jun Nakajima , Kevin Tian Subject: Re: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Topic: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Index: AQHYktKDJjC9h3GSPECMuS4XA01GsK10icwA Date: Fri, 8 Jul 2022 14:33:43 +0000 Message-ID: References: <20220708135559.30719-1-jane.malalane@citrix.com> In-Reply-To: <20220708135559.30719-1-jane.malalane@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5b490a0-cbdf-4ffe-01d3-08da60eedc0b x-ms-traffictypediagnostic: BL1PR03MB6006:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xFVxnavx/4ia3h07L0VaOvaI9JQinpZjvBlkjMk83AKTNPIwaO7UYWKArx5wAcrXDQo2HkwnOb9Ef/oL7N+7SatM4Br4ic80Ugjh8NRQevFGXIPxn8JmNNgp4F+ePC4eO1s0DFqL8Nxxb6lsBYduQskwJeKXB7jQLHBvvFjXYQnbb+A2e2J/goxJ89AtsTw+l+EsXPqOq/pGNJBpiqkIf2kUdTknArY52zn4uvCrvNBQQ69v9TF66S+/Qk4fRg1D+tnF1kpLo2kjG+iyQrZ5AOhgGxMWiWt6SNQwVya1oIgHzijzAJ6YiMV1bPXidAsSsn2A0fDj5YY0266mVBo9VxU/lUYhsbdLP7d8b3sC3GisQsJJ7fjfDwaxBUIoTSaFdNodryXYixk9etqmbs2fAgwBjb5XH8XHz1a7w6IDAlBS9vZekDMRzzaLrFifHDt4ysByV0Y6tOGLlKw1UQN8xyzmuoM47DZxhJY8jlK9/7CEO9ag13xryPnU2dUtGC3renS+4bQuyb7Ppv4u1lAKDMPuj4KArwSIDbyKV3ehqS/3afF8kDeCKTQEhk4trikumkwsLT4BD47wBAj8Otk7Q/qoziwr2Xuy9mY7Hpy3soBPmIvTukQpua012wGSnfb9PEjlP89p/9FShy3nIwdCcvFp0i3LoSN1O29ZZvcMastVf5b1mh70hF/PEEcVXAD7rXjQAijoenctPbNhJ6u5yrb1p/ky5VyAcbDv6INO6Uc/Xbk+nNPRhBvQaLRhBtF3Tx8VCzvC/XnO3aKv5nw2hz5hUuf9f7j5gT5GAGMWOI0SdtAF8XHryr0LER9brt/SYB/ME4urfNbGEPUWkEdzzxpaFr8zgKsjmwD1y5t/lGk= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR03MB6539.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(66446008)(186003)(36756003)(53546011)(6506007)(8936002)(2616005)(37006003)(7416002)(26005)(6862004)(6512007)(91956017)(64756008)(6636002)(54906003)(71200400001)(41300700001)(66556008)(44832011)(66476007)(316002)(6486002)(4326008)(66946007)(8676002)(2906002)(76116006)(5660300002)(38070700005)(558084003)(38100700002)(478600001)(82960400001)(33656002)(122000001)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cEhXK0s5ajlyMHJoRDMydmgzclkwM2R2SHFXRmVSaUJ0SnNZdSszKzhWMHV6?= =?utf-8?B?VVRyMmxBdG5kNng5cEE1ZFF5RCs2U0tGVGhIdStUMjBEQmk2dGhvMGtwOWNt?= =?utf-8?B?ZjFqdGJXTGFqRWV2WDZCZk5YbDJLbGcvZDRHeGp1VHd6VC9iTktvdmh5bFEz?= =?utf-8?B?eXdBL1FrckRIVnFKbnVvWDZtWk13cnpYY0NsVXRPUWFmdFBaRzBXNkNlS0M4?= =?utf-8?B?SmdGc3RGc0p5b1lBTDhUbHkvdUJoS3FoTmx6Ui9pcHR4QUFmNE5iQjFxSjlO?= =?utf-8?B?UU1KTlhmSzJYQkpEdkdsM0drSE1GT2EvVk5lWnVRclN3cFltcytZNXRyZVNk?= =?utf-8?B?UVAxNUhnTjdTSnFuTWIvZkY1c2I2bTZmdVpMbEJITHIrcDVjTEJ0bVhxdXdT?= =?utf-8?B?T2pEaFJoREhZaE1vaGF1dHh4RU5ScTRDZ09SSmNtYzgvQk5XZS9CUEIzbVlp?= =?utf-8?B?ZjVXeExiMjg1VjRaQzBxNkdISEdEMmpOTUFZeVlXd09GVUhUSjZPWnorSERt?= =?utf-8?B?MUlpalhZRW5xdmptcDNORnpwVkhEcFV5NjFmSDV6NzVGeGRmLzZNejZzc2c5?= =?utf-8?B?QTc0WFRRS0hNT3QyR3loTmk3ZWNSTUdMMC9KN3Exem9xbFByR3hha1VxNnV5?= =?utf-8?B?cm94eTU3MWJoV3lMdjdTbXVLVmJNMi8yQzduS1BpNHlCTFQ0OVltNmV3d3Jh?= =?utf-8?B?K29tQlZSSUR0aDhmR2h1OGpKaWVnSHd3Vk9nU3hkOHgxSWNNeEtrMmYxTm84?= =?utf-8?B?RSs4YStGQTFwYlMzeFlHcUp2QjVYQ01pUmh5eGx5UEdJOXZVVW5UYXl2b2xV?= =?utf-8?B?RXVBaEJWYkxVSGt5dmVROEZLSW13M1Fuam9ZUnl4K2pWUkdUL3lPUytVeGF6?= =?utf-8?B?aUF4QzYrZDVVYWcyNWdSNTdzSm8xeVZrQklBbDVTQmlVdTRYek1nQlpTTmJP?= =?utf-8?B?N3hIU3RNV3V6R0tVZkJORHF5a3N4MGx0VGJveHJqaWFMd0x6eFlhN0JibUZa?= =?utf-8?B?MXRMSGhUZ0NJL3dlTTM5TW9qVElDanFCRDJJbGltL2ZSVmd4REMyZTM2Q0N6?= =?utf-8?B?UUFudm9RUmtDM1owa0ZReWFKcExMTmRHalFpZVhuVkFEQnVObm45dGhyVE1o?= =?utf-8?B?cm9OdElOZlM2cytQQlRQclBxWlFpakpzaU5ydnYxZEthL0NzajRTbVFMZ3h3?= =?utf-8?B?YjlkT042QUczQ0doQ1pvVEY0eDByOGI3Z0JEY1Vjcmc3ZTUxdlpyVnQrcEcr?= =?utf-8?B?Z3JPOW5leld2TThWMjdnKzl0dUQxd2piL0thS3BYY3hJU0NEdzFKeW85SHhx?= =?utf-8?B?Z0ZMd0xOenlUc3o0ejQ4ekpRSm9hWHB6ay9qbHN4Zis5cW5Ga0JrUFNCYlF6?= =?utf-8?B?dmcvRjdrTHN0UDdHZzd6elVITDloYWJnUWZMOVJvTnhwVEQwbEd2VDRoeUZS?= =?utf-8?B?d3FYc015bGthK0ZabjZsVFhPbHQ4ZGZSMjhtZUxOWGI2M2hlaFYvYlNtQ1ZX?= =?utf-8?B?a3NZOStkSEM2RkZUOG1tNFR3TnlZcVM2VnU5YU9iaVlqNEMwVVphcHVQVDVR?= =?utf-8?B?YnpZbGpURjAvSFVqWlMycTdtWlF6aDVkcXIraisvbDhDb0tDUURzTTVkcDRo?= =?utf-8?B?SWdkTFpMcDhRMzZYOWJncDZGZFErZXlNcUpjOHQ5b1o2M2N0c1FCTzJmUGs4?= =?utf-8?B?dG1VeDVYMW1GcjRyNU5qb1QvZlJQSXVnTW9zTnQ0akxLU01kejdVR0pud3lD?= =?utf-8?B?RjQyenZUeXVHQ210S3VzK0xydmJzTjV5UlAyR2UzUXFBSDhpMktQMTlLSVYv?= =?utf-8?B?UTB0K3RRL0U5YUpORTlnRGhqWWFRUUxRTlk4cnI5d1gzUXl1cjNmSktoRFlC?= =?utf-8?B?RHZCdmtvWnpUL0xwT0lNSzJVZGR5ZFVxdWpJUzVjRWFCRE00ZkFjSDEyNUJT?= =?utf-8?B?MkpHRUFSNkVDekkzRGU0aXRPeHNVTFdhd1R3dUVtZkhYTWtaTEhja29sNVht?= =?utf-8?B?RUxLYmYxYS9VK3JKcUhiZTJhcTBrWGhGbjJEeG1ZMFNRM3poMVZaTFVlcThM?= =?utf-8?B?VlBWS3FTMkd4RTVKblRPVWxKaUg2bzFRZ20vbCtaeHF2WlVKWnk4cnh0c3hR?= =?utf-8?B?QUxVZVlxN3diaUFEeUR3c2lkTENmM3Ntd2lNb2l3emVBb2pORTBJOWdRVVZy?= =?utf-8?B?dEE9PQ==?= Content-Type: multipart/alternative; boundary="_000_A226BF44AE5A46898D56334A148D9075citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR03MB6539.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5b490a0-cbdf-4ffe-01d3-08da60eedc0b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 14:33:43.6382 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T9RHfzw39uMPEl5Thlo2NulY2DUOZT/AlLjOA+6F2zY5/vuy8VNtTW0WXL1n8NEVPMqXKEhD3cLXeNFwdS3PdEH2RdpUgnp0NlWWogPY6WU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6006 --_000_A226BF44AE5A46898D56334A148D9075citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 DQoNCk9uIDggSnVsIDIwMjIsIGF0IDE0OjU1LCBKYW5lIE1hbGFsYW5lIDxqYW5lLm1hbGFsYW5l QGNpdHJpeC5jb208bWFpbHRvOmphbmUubWFsYWxhbmVAY2l0cml4LmNvbT4+IHdyb3RlOg0KDQp0 b29scy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWwgICAgICAgfCAgOSArKysrKysrKysNCnRvb2xz L29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkgICAgICB8ICA4ICsrKysrKysrDQp0b29scy9vY2Ft bC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyAgfCAxOCArKysrKysrKysrKysrKysr4oCUDQoNCkFj a2VkLWJ5OiBDaHJpc3RpYW4gTGluZGlnIDxjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208bWFp bHRvOmNocmlzdGlhbi5saW5kaWdAY2l0cml4LmNvbT4+DQoNCg0K --_000_A226BF44AE5A46898D56334A148D9075citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5IHN0eWxlPSJ3b3JkLXdy YXA6IGJyZWFrLXdvcmQ7IC13ZWJraXQtbmJzcC1tb2RlOiBzcGFjZTsgbGluZS1icmVhazogYWZ0 ZXItd2hpdGUtc3BhY2U7IiBjbGFzcz0iIj4NCjxiciBjbGFzcz0iIj4NCjxkaXY+PGJyIGNsYXNz PSIiPg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2xhc3M9IiI+DQo8ZGl2IGNsYXNzPSIiPk9u IDggSnVsIDIwMjIsIGF0IDE0OjU1LCBKYW5lIE1hbGFsYW5lICZsdDs8YSBocmVmPSJtYWlsdG86 amFuZS5tYWxhbGFuZUBjaXRyaXguY29tIiBjbGFzcz0iIj5qYW5lLm1hbGFsYW5lQGNpdHJpeC5j b208L2E+Jmd0OyB3cm90ZTo8L2Rpdj4NCjxiciBjbGFzcz0iQXBwbGUtaW50ZXJjaGFuZ2UtbmV3 bGluZSI+DQo8ZGl2IGNsYXNzPSIiPjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdiKDAsIDAs IDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7IGZvbnQtc3R5bGU6 IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQwMDsgbGV0 dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50OiAwcHg7 IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNwYWNpbmc6 IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRpb246IG5v bmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNzPSIiPnRv b2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbA0KICZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwO3wgJm5ic3A7OSArKysrKysrKys8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdi KDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNz PSIiPnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbGkNCiAmbmJzcDsmbmJzcDsmbmJzcDsm bmJzcDsmbmJzcDt8ICZuYnNwOzggKysrKysrKys8L3NwYW4+PGJyIHN0eWxlPSJjYXJldC1jb2xv cjogcmdiKDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7 IGZvbnQtc3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWln aHQ6IDQwMDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQt aW5kZW50OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3 b3JkLXNwYWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRl Y29yYXRpb246IG5vbmU7IiBjbGFzcz0iIj4NCjxzcGFuIHN0eWxlPSJjYXJldC1jb2xvcjogcmdi KDAsIDAsIDApOyBmb250LWZhbWlseTogSGVsdmV0aWNhOyBmb250LXNpemU6IDEycHg7IGZvbnQt c3R5bGU6IG5vcm1hbDsgZm9udC12YXJpYW50LWNhcHM6IG5vcm1hbDsgZm9udC13ZWlnaHQ6IDQw MDsgbGV0dGVyLXNwYWNpbmc6IG5vcm1hbDsgdGV4dC1hbGlnbjogc3RhcnQ7IHRleHQtaW5kZW50 OiAwcHg7IHRleHQtdHJhbnNmb3JtOiBub25lOyB3aGl0ZS1zcGFjZTogbm9ybWFsOyB3b3JkLXNw YWNpbmc6IDBweDsgLXdlYmtpdC10ZXh0LXN0cm9rZS13aWR0aDogMHB4OyB0ZXh0LWRlY29yYXRp b246IG5vbmU7IGZsb2F0OiBub25lOyBkaXNwbGF5OiBpbmxpbmUgIWltcG9ydGFudDsiIGNsYXNz PSIiPnRvb2xzL29jYW1sL2xpYnMveGMveGVuY3RybF9zdHVicy5jDQogJm5ic3A7fCAxOCArKysr KysrKysrKysrKysr4oCUPC9zcGFuPjwvZGl2Pg0KPC9ibG9ja3F1b3RlPg0KPC9kaXY+DQo8ZGl2 IGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvZGl2Pg0KPGRpdiBzdHlsZT0ibWFyZ2luOiAwcHg7 IGZvbnQtc3RyZXRjaDogbm9ybWFsOyBmb250LXNpemU6IDExcHg7IGxpbmUtaGVpZ2h0OiBub3Jt YWw7IGZvbnQtZmFtaWx5OiBNZW5sbzsiIGNsYXNzPSIiPg0KPHNwYW4gc3R5bGU9ImZvbnQtdmFy aWFudC1saWdhdHVyZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPkFja2VkLWJ5OiBD aHJpc3RpYW4gTGluZGlnICZsdDs8YSBocmVmPSJtYWlsdG86Y2hyaXN0aWFuLmxpbmRpZ0BjaXRy aXguY29tIiBjbGFzcz0iIj5jaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb208L2E+Jmd0Ozwvc3Bh bj48L2Rpdj4NCjxkaXYgY2xhc3M9IiI+PHNwYW4gc3R5bGU9ImZvbnQtdmFyaWFudC1saWdhdHVy ZXM6IG5vLWNvbW1vbi1saWdhdHVyZXMiIGNsYXNzPSIiPjxiciBjbGFzcz0iIj4NCjwvc3Bhbj48 L2Rpdj4NCjxkaXYgY2xhc3M9IiI+PGJyIGNsYXNzPSIiPg0KPC9kaXY+DQo8L2JvZHk+DQo8L2h0 bWw+DQo= --_000_A226BF44AE5A46898D56334A148D9075citrixcom_-- From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363455.593986 (Exim 4.92) (envelope-from ) id 1o9pAy-0004Ec-MT; Fri, 08 Jul 2022 14:41:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363455.593986; Fri, 08 Jul 2022 14:41:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pAy-0004EV-IY; Fri, 08 Jul 2022 14:41:48 +0000 Received: by outflank-mailman (input) for mailman id 363455; Fri, 08 Jul 2022 14:41:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pAx-0004EL-36; Fri, 08 Jul 2022 14:41:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pAw-0005ip-V9; Fri, 08 Jul 2022 14:41:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pAv-0006nf-WF; Fri, 08 Jul 2022 14:41:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9pAv-0007oU-Vm; Fri, 08 Jul 2022 14:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=X3u3+Tg5kZ3nGFlqJPZLmz+QrfanVCgX7IxCsHjAI6M=; b=Ye0RPwZCU8D/GVxl+g/2jQnZJY y5yazpUrqF1hzogoRClEdKlwEK/SadWYKJy4arXoPGaCUkzgSIiE85A3wANHF8Lk2cvyq5BqgdnoS /xJyissEwPMmaBhLN4Q6Vyi+Y7s0zQyGHeuY3a+VmgNWUGFVhcrrSjACGp5heRnL89xo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171555: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 08 Jul 2022 14:41:45 +0000 flight 171555 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171555/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 728 days Failing since 151818 2020-07-11 04:18:52 Z 727 days 709 attempts Testing same since 171555 2022-07-08 04:20:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115427 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:42:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:42:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363462.593997 (Exim 4.92) (envelope-from ) id 1o9pBz-0004qI-4R; Fri, 08 Jul 2022 14:42:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363462.593997; Fri, 08 Jul 2022 14:42:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pBz-0004qB-1K; Fri, 08 Jul 2022 14:42:51 +0000 Received: by outflank-mailman (input) for mailman id 363462; Fri, 08 Jul 2022 14:42:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pBx-0004q3-N6 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:42:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ae8931c-fecc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:42:48 +0200 (CEST) Received: from mail-dm6nam12lp2172.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 08 Jul 2022 10:42:44 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by BLAPR03MB5538.namprd03.prod.outlook.com (2603:10b6:208:285::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:42:40 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782%6]) with mapi id 15.20.5395.021; Fri, 8 Jul 2022 14:42:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ae8931c-fecc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657291368; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=09lwFhduaGm3TxU85OxKxjRrE0YOkhVWz+ZIHW4XzfM=; b=Q9ADp+8ZGl52uUmqL3amCph083NMebfuc1iNwSOhueDWmDqttFPnulOj IIGcbM0JEO5OBERq9iq9o9GYkUfCKbm/xv0c6xxiwOA5JNQWnjK5DU8v7 xYmuw8zjTVjvLCMUxMg1od+ikRAxL1RAm1q946+1qJjdM+5MVS5E25m4R o=; X-IronPort-RemoteIP: 104.47.59.172 X-IronPort-MID: 75377074 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:QOI2qaJ15mA7NunCFE+RVpQlxSXFcZb7ZxGr2PjKsXjdYENS02YDn GodCD2Ob6vcZWvwett3Ooy18BwOuMTXzdc1SFdlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dY42YLR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 M1QtKa3GUQKAqiWpv0vVEBTCxBeAaITrdcrIVDn2SCS52vvViK2htlLUgQxN4Be/ftrC2ZT8 /BeMCoKch2Im+OxxvS8V/VogcMgasLsOevzuFk5lW2fUalgHMGFGvqQjTNb9G5YasRmP//Ya ow8YD5maB3GbjVEO0sNCYJ4l+Ct7pX6W2IF8w3K/fVri4TV5DNq9YLBFvrzRv6te+dHgUTBv 2XWoU2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nweDlgaWEW2pdG9i1WiQJRPJ koM4C0soKMuskuxQbHVRRqjqmSDuR0ac9VVGuw+rgqKz8L8/AKxFmUCCDlbZ7QOttIyRDEs/ k+EmZXuHzMHmKaOVXuX+7OQrDWzESsYN2kPYWkDVwRty9vsuoYolTrUU81uVqWyi7XdFTjuz hiQoSM5hrFVitQEv4254FaBhTuvr5rISwcd5wPLU2bj5QR8DKamapKp7x7H7P9GBIefUlSF+ nMDnqCjAPsmCJiMkGmBRbsLFbTwvfKdamSD2xhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLIT7wJiti8ggJyX6VM IronPort-HdrOrdr: A9a23:fEcVIqj5GryBv7XGura1DaS42XBQX3h13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8buYOCUghrTEGgE1/qv/9SAIVy1ygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3v5xA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3z8FOgk/gIsKwC zgqUjU96+ju/a0xlv3zGnI9albn9Pn159qGNGMsM4IMT/h4zzYJLiJGofy/wzdktvfrWrCo+ O85yvI+P4DrE85S1vF4ycFHTOQlgrGpUWSkGNwykGT3PARDAhKd/apw7gpPCcxonBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3/rFuG4O5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLEXQI5tlluZEU5XHNcrWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.92,255,1650945600"; d="scan'208";a="75377074" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hkhsr7j68sevpnecGEkiI5rr1iPA3PEWVMO1K23ZCPfVL/7lw7t7blRmwrQNZTXBzXpROroGCU9SnyJNEOsAbzSZ399adrZVA8/8xQxbCMrjxVetkYe++/DjxFAfOhbiSJBULmAH1pE6QkeyNvRA/9+uoZZbfECYC4+klqbuRABi0BzP0es+bwceSTP8OrgNNMkESJ+ALAsTHxtRXDhdJhDDxOhZzFnwCjwqap1RkO0sE4lmTIIAmZskc4IkMWP4ENo2IEtjMPmj3P3kS+5DnsQVfrOTucfaKffowTKuPZYJEZUdT9c1o0eqFN1yNxZtuiqP6ILeZwGKuNyFqItNsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=09lwFhduaGm3TxU85OxKxjRrE0YOkhVWz+ZIHW4XzfM=; b=jNk6yr1En6dv/WORVDool8xdrS21u5OYOBRbjBblE5iHB6rfsMvwq/odLpNToFvezljs38U/L1bkM9qfkejNXZnTe/RfOV+8A04oYPu8m13IX6DMAeLUfTzXzWJ3MK68Qaw14cPqkTVpIszXLtLtrwExC+e24FQTVWNipQob2MYvB7Jjsn5aMXtcJkVISvvkxRjTt6Gn1fI9OI+aRsWXkXwNoS8qlTAJnKIqhkHg7XAdI3gu+s9vokjMANyBC9hYMEBYsHWq1/wSozsegZUUO37wT/qhox0Y+NGutUwtI6TGvOPsZqT/ks+6Vgv98/gmcfxCtrWlRlqWPRke6CPr/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=09lwFhduaGm3TxU85OxKxjRrE0YOkhVWz+ZIHW4XzfM=; b=gqEONJcbrzGwzz7JOdaHSRq8qbBfByzN8R39KyVBjAgMJb23GPQplNz1hd6gJbJsD56cUMIwXfMRDxcI7E6D+hfuXtKlu4VjfDFuZbzzqu1dje6C9+i0vIjV8E2msO7g5wPkzeaVBrJA6Sf2m7i4/AaBMFNvwDhf0dTlslUxJvs= From: Jane Malalane To: Jan Beulich CC: Xen-devel , George Dunlap , Nick Rosbrook , Wei Liu , Anthony Perard , Andrew Cooper , Jan Beulich , Julien Grall , Stefano Stabellini , Juergen Gross , David Scott , Roger Pau Monne , Jun Nakajima , Kevin Tian Subject: Re: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Topic: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Thread-Index: AQHYktKDq8cM5FJ1YU2wVC8sy824sa10ic2AgAACfgA= Date: Fri, 8 Jul 2022 14:42:40 +0000 Message-ID: <94eb45a6-7c84-6b6a-e5c1-e2ced336e675@citrix.com> References: <20220708135559.30719-1-jane.malalane@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f203ac8-4384-469c-91d9-08da60f01c14 x-ms-traffictypediagnostic: BLAPR03MB5538:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XuJjE40UOl9BLpmzvFmfCfUpmziaHrEH+pZCwVMQtnIj7Nf18MrVD+Jxi/TQTjB9pVfJC/p4t+aCxL6Tmw8H4q3RnRwjdRfEVR6IsD5C5RetK0yN+52HMZvz9MeVz1ikaCemuLQ387HeP1bjmCTWjlVSLTYAjBXhh4c9w6E0JBy/ZdI7cF8VquCJ6GggPOEG801TYETSOs9XsKUVGceN+q1zIHBhuXEoJIw3kCGa3sho/i7Qog4KBfp0pVkKD1eCHDLNGbGYoyfqs2kwbeDsv2wsB/gWDOO2utmnSJigw7qGj7NTMI5GtqrSXh6zgqApwwAoVdfA+PQilX6Vr+kCURYRpwBuXdCO06jnaMEjBKEY0JZyP2xMpOVHRMPSzC9DqE1Q0zOpwax59HOioGaRrMYWuWps9zAwghBdbhjzeHlmWhIUoZtdR/DqkEHA30WWbp/3UHvIu7l+xbR9z0EkbKdylYCu8llTYqzPMUN4aSyCARBbZJaN2p8OOLcX12IsVaxARMlQeu5+g6b0rUGlWODxPrHIbBipReA/En8Wbd4zd/Gog5YH0lJ0O61Ou4RLGg3U9zml8R/XexdcOL4o9OfxxvTAGoolCXJUTeo+sQmu7CN7xh/z2d80tqxHWXGrigLdDeWt2SieLWIuBlO4utYqltNs2dXHLka8myxTOmkCIkFQvRTb7onQfHUziMVxHEQdH82Au2saHCyj+slpJx2uHw6NfXz+e77c/ZBWkaRlc2Vf9mxGwccEzg98lmnpGHNF5mwSuLnxwH5BsYkcm/n5qw5rczySwoUpgt0KGGuTWdqkw8vyZJmfJVHO3liCsB6gyzYXCsIW9oW1ADuSEw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(2616005)(31696002)(26005)(6506007)(38070700005)(2906002)(4744005)(6512007)(66556008)(8936002)(86362001)(6486002)(41300700001)(478600001)(53546011)(7416002)(5660300002)(186003)(83380400001)(36756003)(54906003)(122000001)(38100700002)(91956017)(82960400001)(31686004)(64756008)(66446008)(8676002)(6916009)(66476007)(71200400001)(4326008)(316002)(76116006)(66946007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MUtQUlJML25FSW5JcmRqU3FGK1VBblUyRmQ5UC85YmIvUlhZQlZqR0liK2lP?= =?utf-8?B?STlpMXRjbktndE43WkxXSi90TUh5V1IxbzRVNWk4R2xpZFpsRE5hdk1RbjdH?= =?utf-8?B?Q25nVGl0R3IwZ0Q1cDk2RUExQXphakptK3luUjdUZDFaNytDd1U2K1c3eTRY?= =?utf-8?B?VTZpeGFyYmwzRkhCMkNpanJLNHJCdk5XZmt4cmFnTW1vOWpLNGtOMnZNcjZw?= =?utf-8?B?VlM5SEVPdWFPL05qZUJDcWpBR1hXVHpDRENBWFd2WDFBYUw0UzcxMkgyUlVu?= =?utf-8?B?NWJienVJWUNqREQ0WFRkVURoUFBSQjYvQ0VNL05GejByeDhmVzlOS2tiUnhn?= =?utf-8?B?Y3dLdEJUVkFEQmN2cnlyYXMyU1hrOWZaMHJMRlpPbkZlZXFlNlYwaGJFeDVx?= =?utf-8?B?RzRHWVpxTEtPdmhvOWNkTXo3eHZFSFpZeG0yNHVLSjB6dCsvbTRqeCtmMlBZ?= =?utf-8?B?V2dWL1lFNnp0SURzMkhSMWRUWXJpUkpKUXFqcXFCUXNvWEZyNDY5TjdKRnNj?= =?utf-8?B?bjB3YmZCSkNQQVRZRExZRmJTUjUzSGRLZnhaUEU0SU9MSEowS2NTd1FsS0c2?= =?utf-8?B?ZUJJRUJtUGlYbktSRUw2MVlYc0hkZWphK28vUWRnSm44WFVab21MZTZybVpI?= =?utf-8?B?azV0OTlNRWF4S1lqMjNIWko1ME5yYlRvamFQdml3WVFmL3NtOEVzWmp2ejVv?= =?utf-8?B?WUs2SXJNOFNmdlFSTFlsNHcxUVE4N24rRys5cXplZW4yT0VPSFBJWExYZzMy?= =?utf-8?B?QnRSZHAxNWF1ZzZXVVJSOSs5dEFxZUp4bW1pY2FRZElTNE1kUzEzU2tGZ3Yw?= =?utf-8?B?UWI0UUZQY0h5US80MkljaU1IZmV4aGhvTnZEbXg1VGpzVFo2UnpjaTdhWnlk?= =?utf-8?B?dmRzUzR3K3Z6RTdrNzFlYTZRZ0EvQkNMaWtDRkQ5blJVMUhYWkE1cWJ0RTBJ?= =?utf-8?B?UzRjNU9uVUF2OUlINm5od2g3dzVBaU1SRysvZ0RLOS9kZVJEQWM3Zkc5N2FD?= =?utf-8?B?RlJobWNXSWZlRXhCZ3BRakJ3eXBhckhtZHVkM1paaXBwTjI0bDRXWUwyLzd2?= =?utf-8?B?U2p3VEswL1pwcDVGRVZBaTVQTmVuTVNZMFB5U05HQkQrV0FKeUZ6NVZRVk04?= =?utf-8?B?ZVdVa1lsMnlCVWN4bWxra3JORnVrbFhTUDJGRXBQZXZHR2VGa3ZGU2I0dnVC?= =?utf-8?B?WUhIMU9XTjJ4Tk11UFhLaE12eTlHRG40RG9SL0hGMVIyZDhOR1ovWCt5cVRS?= =?utf-8?B?OVlvdENneWZwREhTNjBGM0Qwck5LV3ZQb0tUUGhNRkM1NFRUV0lueXBIR2l3?= =?utf-8?B?YXhjSFAvdXVRaVA5UmxXT3RyYUxqT041YytiZWRadzFXaC9pMjNoMGZ2b2da?= =?utf-8?B?dlBxR1J6dmMwMVZzblRzRUpaM1pOSkR0Z0JiWUpqd3BRWEx6Z25Xc0F0dGFF?= =?utf-8?B?UmdUZ250S3dtenRFOXBialg3c0Q1Qi93bnM1QkE2em1NbGRBYXdKYTFsYnJh?= =?utf-8?B?WXlCbzVKNmc3K2laNjdCNStHMU50dDBuZmUxKzA0Yk9GcEVqOWFjaHFOcHlC?= =?utf-8?B?NWNvSEtVZzZwRTRaSTYwOVVqcXN4enNkUk5HaCtkWi9KbmxXdW5FMHo4MmdD?= =?utf-8?B?NitqdSs3c05iVU1sVkxXaXoxYnlmMEVpTUliRCtaaE9tQjBHbkJLVWQ3amE5?= =?utf-8?B?ZWQ4WmNnenREeFpFT2ZweWZhaERkWnBrZEliSUJKMWRab21yT1d6K1YxNWhr?= =?utf-8?B?dVE2b1BiY2hybnhtK05BL3kwL0F0YmN1bnU0a29KY1ZlbzdlRTRYYkZYZmwr?= =?utf-8?B?L1hqTXEzNVBzaU1qOHdYZ0k0WnYrWHVKR1RBRjEzT3h4TzVLajYzR3YyS2VF?= =?utf-8?B?VTcrT1VsTDBDQ3FSUDRhb1lndFhLc1NraUZTczUwOG9vUWRUclE1K29OT3lQ?= =?utf-8?B?c1oyZVhLd2JDRmVreHM1QnQ1VS84M3NSOGFjdFRaUmN3ZkgwU2F5T3BJSVNZ?= =?utf-8?B?bFNRN09sS1E4U2dOYjRhY3Y0cjFuSnp5M3lIOGhrcmpVTWtSVVh5clBOOTFD?= =?utf-8?B?MlQ5ZHg4RW9PcnE3aGV6VG1oOE5RNlJGU2ovTUEyZkZxbGNnTzF5Z3gvcUs4?= =?utf-8?B?M2F0ZzNmaFJlRkU4amw5cFlSaFJIYWdZZXFzQllmRk9aU0FPclRQOU9oU0ts?= =?utf-8?B?bmc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <4C72174E6399044E899A55F6461326B0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f203ac8-4384-469c-91d9-08da60f01c14 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 14:42:40.5405 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NcJCK4+pMNuQQPdiIC/qmph1zbzOd0icHazoRA3g3NLeZxa4z4Ht7bMvr5qU4c1bYDS3z6xzHCfDMYSYvgp45ORBqSwq5DI7ONQgGpxr37I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5538 T24gMDgvMDcvMjAyMiAxNTozMywgQ2hyaXN0aWFuIExpbmRpZyB3cm90ZToNCj4gDQo+IA0KPiBP biA4IEp1bCAyMDIyLCBhdCAxNDo1NSwgSmFuZSBNYWxhbGFuZSA8amFuZS5tYWxhbGFuZUBjaXRy aXguY29tPG1haWx0bzpqYW5lLm1hbGFsYW5lQGNpdHJpeC5jb20+PiB3cm90ZToNCj4gDQo+IHRv b2xzL29jYW1sL2xpYnMveGMveGVuY3RybC5tbCAgICAgICB8ICA5ICsrKysrKysrKw0KPiB0b29s cy9vY2FtbC9saWJzL3hjL3hlbmN0cmwubWxpICAgICAgfCAgOCArKysrKysrKw0KPiB0b29scy9v Y2FtbC9saWJzL3hjL3hlbmN0cmxfc3R1YnMuYyAgfCAxOCArKysrKysrKysrKysrKysr4oCUDQo+ IA0KPiBBY2tlZC1ieTogQ2hyaXN0aWFuIExpbmRpZyA8Y2hyaXN0aWFuLmxpbmRpZ0BjaXRyaXgu Y29tPG1haWx0bzpjaHJpc3RpYW4ubGluZGlnQGNpdHJpeC5jb20+Pg0KPiANCj4gDQpIZWxsbyBK YW4sDQoNCkkgYmVsaWV2ZSBJIG5vdyBoYXZlIGFsbCB0aGUgYWNrcyBuZWVkZWQgZm9yIHRoaXMg cGF0Y2ggc2VyaWVzLiANClJlZ2FyZGluZyB0aGUgY29tbWl0IG1lc3NhZ2Ugb2YgcGF0Y2ggMiwg SSB0aG91Z2h0IHRoYXQgZXhwbGFuYXRpb24gbWFkZSANCml0IGNsZWFyZXIgYnV0IEkgY2FuIGFs d2F5cyByZW1vdmUgaXQuDQoNClRoYW5rIHlvdSwNCg0KSmFuZS4= From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363469.594019 (Exim 4.92) (envelope-from ) id 1o9pO4-0007BR-Gu; Fri, 08 Jul 2022 14:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363469.594019; Fri, 08 Jul 2022 14:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pO4-0007BK-D0; Fri, 08 Jul 2022 14:55:20 +0000 Received: by outflank-mailman (input) for mailman id 363469; Fri, 08 Jul 2022 14:55:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pO3-0007Ai-70 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:19 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id faf61f11-fecd-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 16:55:17 +0200 (CEST) Received: from FR3P281CA0071.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::7) by PAXPR08MB7550.eurprd08.prod.outlook.com (2603:10a6:102:24d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:15 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::3e) by FR3P281CA0071.outlook.office365.com (2603:10a6:d10:4b::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.13 via Frontend Transport; Fri, 8 Jul 2022 14:55:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:14 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Fri, 08 Jul 2022 14:55:14 +0000 Received: from e4df9d7cd0e0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0D4ED391-D037-4F64-8AA7-E34F472A8656.1; Fri, 08 Jul 2022 14:55:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4df9d7cd0e0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:07 +0000 Received: from DB6PR0501CA0008.eurprd05.prod.outlook.com (2603:10a6:4:8f::18) by AM9PR08MB7029.eurprd08.prod.outlook.com (2603:10a6:20b:41b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 14:55:05 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::a7) by DB6PR0501CA0008.outlook.office365.com (2603:10a6:4:8f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:55:04 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:04 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:00 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:54:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faf61f11-fecd-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Y8rlz8VKvCJ+pb3wMHP1qpBkwPNuhFHtB0PdNP3YEn5chgAM9ryASwJgPHIuprT3oi//6PdAQbQVJXsdZCY5c+PMZkC+ZDcJPgTZ2hQ8pNxF9cA2XSzA5FjLiIb+F4DlAmu0fkxqa8X+Vy78NJhTKUwWsGA+hasxXuOJwsyIeCGbpF1+Uq1t3IbeqyTJYJNHMt7sjUMHWx/XWz12sbxT7FHo94/MnTECFODCoib5Zb4fhWk1NJjB4pN3TtDtDdpIwnFHqem1BXoINgv2olAjTWuwHQ1ltLdwddcy/N/Wa2uAGJxhOvOrj1jxniz+WkQl6tbvwLQpFAR0uKntv25XDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ho4BETRsxA2qUWrMdXER8nJ1DBBHm4uFN3lKRvF6is=; b=NDruzvjU1gpf2YANfcp81r7JhVKYs9/aag8ZsZxYfjHy1SCwhEqhgbqkVaHrELsbQ41OKZm5DaETIJd0EHzRKN6gUCj5W6Yz0lG6koUP9fOdZ/ofdeLMVsrY03jgO1iMK8YXdxivDFaqosbVZOJ84UENk2xhobfZBMMdc2C5Jvg5f5BLjwmWXHIFpOmG3IzuJh/Lc5jpSAh/bz5yBX59nspmAVotIiJ/l7t1SwzEnT2RAHaLj9VqvG+klWhWe3Ma8LyX0VZK+xUiu2Jpve+XRb4RmQLy78V9ZEm3POptNtVYqqvNB9JIxmtbuGMrDbTZ5tsQwm+MTO0bNnXDArTdcA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ho4BETRsxA2qUWrMdXER8nJ1DBBHm4uFN3lKRvF6is=; b=JGRpIbcUDYc8VOZ45VEnA5jLosCAjxYj5oIRqghV11XlYoe9L8v7ZD9nT/rdAV7xlY5EHn5HqGNdPtgzQINAva4Or1WwS7T8wEpYsAmHZRCoLRWT/b+PJZ1Bbomtm9JLIEfMoa/dz92th6BuxC1sjnylGlZtzx1zhTVxOTglOOk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: acad7d1847ba8541 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SW7SOapgsaHjy5V6+jxaS1v2fpGORrIv151bhleD8GlSdsJKBFWBYAO05H5auCvOy33B9xfJVrtQygf1cpnlgB66xCRvWbzpXKx2XQD8ZUUxPUIXdkUsQjF0Exll0TC4tWfYla4kJHPJXOI1bXwu3AiNqBUQeLSFjnput2EcMM3MAMEweCq4lpb1aMezjJ5LwdY3q7ktUWPd1Kgg/gLtBP99H6mIFOp2wXqRp++q928VHCtGSgfKQtU3R6mZ0tPuRVv+K4sJ11YQbaKdZ505vp33ZP4blzgTH6bt9AM8I4hm8ExS1PVJqFlRFCPuNxXvTBJxlh6+AxA3fNgH4hsLzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1ho4BETRsxA2qUWrMdXER8nJ1DBBHm4uFN3lKRvF6is=; b=Q4qjvS+JVog5XPlhW15T5rKgeJZS4cqEP74uaEbX7FJwLaRdP0LvYnKJMoz6jK6R463Ic22wspdCcSEa6gfe6NKQcH15aRkshSSjlVIH+EHanB7pAmRMVU6qkX8jsYtoruGl4sOvIl9L9ups+2KX2JigxOAbqQbs6uRwAbvlpAzrBlypD0uB6DOfbyGG31VYugc3hfRdt5+1kMIVH3WSmY//Y+cq3qjswbNaBEQ2khRExSLEHSY10MbRf28RSN7SyP9tBOEveeerXXYdN1aJkpTPVyejYcm1rOQ4yjqfzbuQeirrD+OTSgcCA7thhJY3UsZiBLeb6gRps6MnRE32gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1ho4BETRsxA2qUWrMdXER8nJ1DBBHm4uFN3lKRvF6is=; b=JGRpIbcUDYc8VOZ45VEnA5jLosCAjxYj5oIRqghV11XlYoe9L8v7ZD9nT/rdAV7xlY5EHn5HqGNdPtgzQINAva4Or1WwS7T8wEpYsAmHZRCoLRWT/b+PJZ1Bbomtm9JLIEfMoa/dz92th6BuxC1sjnylGlZtzx1zhTVxOTglOOk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Date: Fri, 8 Jul 2022 22:54:17 +0800 Message-ID: <20220708145424.1848572-3-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 7e826c80-2867-4879-d9c9-08da60f1dda5 X-MS-TrafficTypeDiagnostic: AM9PR08MB7029:EE_|VE1EUR03FT033:EE_|PAXPR08MB7550:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AJdPe4WqzibUEo4iL+zKkkA4luh8/sgCE6g9v4kfNCaN11LUAlKMskmnRYFFyOmKkWv2gVFcear9ZuiYsmeIV4nc+RV1tEEtmtxsq+U+9kmzPkkSVJl76vZZl8zXBtFn9A98EHGEBtX1FUErlwvnWvymp4s5Zs6CH17aMVutUSDiDqBmJPi4H2oBCRhTWZGPTzvlcQh64NsonbTLHCCQfl70BxwIeF/mfSVFP5Pm4QWz5NZlhQ38Y23QI3yHXOsPdhBQhsQW+ybxu7wv3s5Whbolmsu3wBCACJkF5pEvoWdt0ZsSkhhpLzTGjMk+J8IyrDJ5htVFLSQJpR5GDHe2WtvefqFUf72EV1HwMTTG+svAQrmSpds1DD6SKMkBydKLFVPOW14h1/lRlY1DJm2n6+rDXp7Mw/JhtFGwuNBk/3fBwQXVjpAnOihV/mmhz6n3aBZq0Zn2jgD4Tk0ha4aY2+0A2e02caKc+b436Yq2mz2Bq/SXAG5hpkH03sbJs0bKm1doX+2x5sqXsbd2Vctao7ox2MoJTIyc5bzRQWA588aNDKnGEIVCZgS9AFBsBTi64zBtTsUkz3+ZI7Hf2WS7vkSUlqIFOxxRqHkCKFQTe76pACnOyy7FOpKlSIUfKhe10ZE/4BjGZp+mNa3YvRw1rQXstuAC+TyhburzWnXt9USJnlJMC9hHEYyl2r+8dg+1i33ccT3XHYDDmABcvpxTuND2j+HXKnZKZQPeH1v8ZiySGI1GtvfUOxHD1LkTHLVpxy2JzfaBe7r1BpVMrUaTvWxs4R5X4YEErkV4fr0FhW7iKoyQ23x7BcnZlMg3T8pV+8mMpJky/Ax5vPMJzsLGFBolJPJVnfIAydBTw24hLdw= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(376002)(36840700001)(40470700004)(46966006)(82310400005)(44832011)(8936002)(40480700001)(5660300002)(81166007)(356005)(6916009)(1076003)(54906003)(82740400003)(7696005)(186003)(2616005)(478600001)(316002)(41300700001)(26005)(40460700003)(36860700001)(47076005)(336012)(6666004)(8676002)(4326008)(426003)(36756003)(70206006)(70586007)(83380400001)(2906002)(86362001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7029 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f8a719d-dc85-41a2-0ac2-08da60f1d7b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HdbZJfUTAZfylp7ukb+DMc25W7zMCIASwTQ8v7Lc3WMlMF7uu4zI+56geyFk4pcF+cEnFtdf4k6tKC5yx0SIRCJNWjwfizvdLZ+CPPEoybNuNDA3EjpbqrIZJkQzeNZAq6Hspec1+WlhWONdmjq9/DeCin+/rpKNf4pAMuXocfQUycURVwaPDoLPFiWHfCzHGwxAUEFofH/nGj+koYq5QIJpVpvxPpQdVQU2nHRfmC9C2TTwqMabpFF40p6lYAR21Ak4+hEO8M3gxWfEBQXVRfOQB956mRaPl8rv99Jq5amsvBKp4DH1QHak/1RuYnaVNIemdsVVmzFYBpTkQnYgb8sNPi0sqqddfFk/+Ksx51FPs2kaXPzmFh3OvFKUxReqNF2CZ0RwnGnmgBagV3steYEou6dyZLv2wEIEadxFTZ46tknMPpTo4WprNNava0cN6zv/guEi/jMeuNVJVOCLChEVbdVhcvcNbKHmag/+SQWIREDmQV+bQJBgoVFRDuvPO44M+3qE1NcH5f7H8NyVZP/HX5mTXs2gy0V2rh4g4kGyaGukaakiHtbZYfgdVzglF+suY88makgz37v1gsUoJ1d67Tfx27qs4OUlE14wxDX9BiAzEFihugqSVJrTELVANAZy+yz50XWWYMSyeK0AO2drVezkaovIaf9mNfuxVOXBzyy45OuuPuRHIvosNrbkfqr13kcsLJZJCDgFyhxPTngF5WJruQ3xcQgEbUfjMNFYI856AwnX4b/xf6HvLIxN5iHhgNUwMB1ykna4ntiJsYuo867xQ/5Jox6MBi9sBR9OQZZJk+KxGMQiJFkjYYsH X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(83380400001)(1076003)(426003)(82740400003)(186003)(5660300002)(2616005)(2906002)(47076005)(36860700001)(44832011)(40480700001)(36756003)(8936002)(336012)(54906003)(478600001)(41300700001)(7696005)(6666004)(26005)(4326008)(86362001)(82310400005)(40460700003)(81166007)(8676002)(70586007)(316002)(6916009)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:14.6959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7e826c80-2867-4879-d9c9-08da60f1dda5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7550 In current code, x86 is using two variables, numa_off and acpi_numa, to indicate the NUMA status. This is because NUMA is not coupled with ACPI, and ACPI still can work without NUMA on x86. With these two variables' combinations, x86 can have several NUMA status: NUMA swith on, NUMA swith off, NUMA swith on with NUMA emulation, NUMA swith on with no-ACPI, NUMA swith on with ACPI. In this case, we introduce an enumeration numa_mode in this patch to indicate above NUMA status, except NUMA on with emulation. Because NUMA emulation has another variable, numa_fake, to indicate the number of nodes for emulation. We can't use the enumeration to replace it at the same time. But it still can be indicated by numa_on and numa_fake as what it has been indicated. Based on the enumeration we introduce numa_enabled_with_firmware for callers to check NUMA status is enabled + ACPI. Using this helper is because some NUMA implementation will use other firmware, this helper will be easy to them to check enabled + others. As we have touched srat_disabled, we have corrected its return value from int to bool. Signed-off-by: Wei Chen --- v1 -> v2: 1. Remove fw_numa. 2. Use enumeration to replace numa_off and acpi_numa. 3. Correct return value of srat_disabled. 4. Introduce numa_enabled_with_firmware. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/arch/x86/include/asm/numa.h | 16 +++++++++++++--- xen/arch/x86/numa.c | 28 +++++++++++++++------------- xen/arch/x86/setup.c | 3 ++- xen/arch/x86/srat.c | 13 +++++++------ 5 files changed, 37 insertions(+), 24 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index 9a9cc4c240..ab0d56dd70 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -101,7 +101,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 -extern s8 acpi_numa; extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index c32ccffde3..ee8262d969 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -28,12 +28,22 @@ extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) #define VIRTUAL_BUG_ON(x) +/* Enumerations for NUMA status. */ +enum numa_mode { + numa_on = 0, + numa_off, + /* NUMA turns on, but ACPI table is bad or disabled. */ + numa_no_acpi, + /* NUMA turns on, and ACPI table works well. */ + numa_acpi, +}; + extern void numa_add_cpu(int cpu); extern void numa_init_array(void); -extern bool numa_off; - +extern bool numa_enabled_with_firmware(void); +extern enum numa_mode numa_status; -extern int srat_disabled(void); +extern bool srat_disabled(void); extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 627ae8aa95..0777a7518d 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -47,12 +47,16 @@ cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; -bool numa_off; -s8 acpi_numa = 0; +enum numa_mode numa_status; -int srat_disabled(void) +bool srat_disabled(void) { - return numa_off || acpi_numa < 0; + return numa_status == numa_off || numa_status == numa_no_acpi; +} + +bool __init numa_enabled_with_firmware(void) +{ + return numa_status == numa_acpi; } /* @@ -254,12 +258,13 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) #endif #ifdef CONFIG_ACPI_NUMA - if ( !numa_off && !acpi_scan_nodes(start, end) ) + if ( numa_status != numa_off && !acpi_scan_nodes(start, end) ) return; #endif printk(KERN_INFO "%s\n", - numa_off ? "NUMA turned off" : "No NUMA configuration found"); + numa_status == numa_off ? "NUMA turned off" + : "No NUMA configuration found"); printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", start, end); @@ -292,13 +297,13 @@ void numa_set_node(int cpu, nodeid_t node) static int __init cf_check numa_setup(const char *opt) { if ( !strncmp(opt,"off",3) ) - numa_off = true; + numa_status = numa_off; else if ( !strncmp(opt,"on",2) ) - numa_off = false; + numa_status = numa_on; #ifdef CONFIG_NUMA_EMU else if ( !strncmp(opt, "fake=", 5) ) { - numa_off = false; + numa_status = numa_on; numa_fake = simple_strtoul(opt+5,NULL,0); if ( numa_fake >= MAX_NUMNODES ) numa_fake = MAX_NUMNODES; @@ -306,10 +311,7 @@ static int __init cf_check numa_setup(const char *opt) #endif #ifdef CONFIG_ACPI_NUMA else if ( !strncmp(opt,"noacpi",6) ) - { - numa_off = false; - acpi_numa = -1; - } + numa_status = numa_no_acpi; #endif else return -EINVAL; diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8de..4841af5926 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -329,7 +329,8 @@ void srat_detect_node(int cpu) node_set_online(node); numa_set_node(cpu, node); - if ( opt_cpu_info && acpi_numa > 0 ) + /* Print CPU info when NUMA is enabled with ACPI. */ + if ( opt_cpu_info && numa_enabled_with_firmware() ) printk("CPU %d APIC %d -> Node %d\n", cpu, apicid, node); } diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index f53431f5e8..422e4c73e3 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -185,7 +185,7 @@ static __init void bad_srat(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); - acpi_numa = -1; + numa_status = numa_no_acpi; for (i = 0; i < MAX_LOCAL_APIC; i++) apicid_to_node[i] = NUMA_NO_NODE; for (i = 0; i < ARRAY_SIZE(pxm2node); i++) @@ -260,7 +260,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) apicid_to_node[pa->apic_id] = node; node_set(node, processor_nodes_parsed); - acpi_numa = 1; + numa_status = numa_acpi; if (opt_acpi_verbose) printk(KERN_INFO "SRAT: PXM %u -> APIC %08x -> Node %u\n", @@ -295,7 +295,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } apicid_to_node[pa->apic_id] = node; node_set(node, processor_nodes_parsed); - acpi_numa = 1; + numa_status = numa_acpi; if (opt_acpi_verbose) printk(KERN_INFO "SRAT: PXM %u -> APIC %02x -> Node %u\n", @@ -484,7 +484,7 @@ static int __init cf_check srat_parse_region( (ma->flags & ACPI_SRAT_MEM_NON_VOLATILE)) return 0; - if (numa_off) + if (numa_status == numa_off) printk(KERN_INFO "SRAT: %013"PRIx64"-%013"PRIx64"\n", ma->base_address, ma->base_address + ma->length - 1); @@ -499,7 +499,7 @@ void __init srat_parse_regions(paddr_t addr) u64 mask; unsigned int i; - if (acpi_disabled || acpi_numa < 0 || + if (acpi_disabled || numa_status == numa_no_acpi || acpi_table_parse(ACPI_SIG_SRAT, acpi_parse_srat)) return; @@ -528,7 +528,8 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) for (i = 0; i < MAX_NUMNODES; i++) cutoff_node(i, start, end); - if (acpi_numa <= 0) + /* Only when numa_on with good firmware, we can do numa scan nodes. */ + if (!numa_enabled_with_firmware()) return -1; if (!nodes_cover_memory()) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363468.594008 (Exim 4.92) (envelope-from ) id 1o9pO0-0006vQ-7j; Fri, 08 Jul 2022 14:55:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363468.594008; Fri, 08 Jul 2022 14:55:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pO0-0006vJ-4u; Fri, 08 Jul 2022 14:55:16 +0000 Received: by outflank-mailman (input) for mailman id 363468; Fri, 08 Jul 2022 14:55:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pNy-0006vD-GK for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:14 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150047.outbound.protection.outlook.com [40.107.15.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f78601f9-fecd-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:55:12 +0200 (CEST) Received: from AM5PR0402CA0013.eurprd04.prod.outlook.com (2603:10a6:203:90::23) by PR2PR08MB4713.eurprd08.prod.outlook.com (2603:10a6:101:22::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Fri, 8 Jul 2022 14:55:10 +0000 Received: from AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::88) by AM5PR0402CA0013.outlook.office365.com (2603:10a6:203:90::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:55:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT044.mail.protection.outlook.com (10.152.17.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:09 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Fri, 08 Jul 2022 14:55:09 +0000 Received: from 86cda3d7a080.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 17BC7FDF-488F-4B5D-8CA7-89AFB57836DB.1; Fri, 08 Jul 2022 14:55:03 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 86cda3d7a080.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:03 +0000 Received: from DB6PR0501CA0004.eurprd05.prod.outlook.com (2603:10a6:4:8f::14) by AM6PR08MB5287.eurprd08.prod.outlook.com (2603:10a6:20b:b0::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.14; Fri, 8 Jul 2022 14:54:59 +0000 Received: from DBAEUR03FT038.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::e0) by DB6PR0501CA0004.outlook.office365.com (2603:10a6:4:8f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17 via Frontend Transport; Fri, 8 Jul 2022 14:54:58 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT038.mail.protection.outlook.com (100.127.143.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:54:58 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:54:57 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:54:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f78601f9-fecd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dj1O6EmXJOY+M8DnRPih7/dBxbFEv5B3XYg7ujizs2fjCIqtb3LnzdsSVemnfBzHL6Yi9CNL0niHVaEiQ+zA0C12VO9rQuHFxSPA/ZuVGtyVuXp2mRxW9Ju8q54UcZspvolWq0128s3FTHI8h9SMHc2Nx4gUvcbIVfj/z4B9cqO8gpt+zZeXt87qPsEnwU4UjbDpc1MCg+t8rm7VGZdApPaRokMII/U1TWvck73DoZNckrbYotVa8tdNbrq7Aukg3Gd83cCClLuCY8bq3dBQEUpldNWr7k2rgwY6Yjf2/iUnaRazm5GOnv0n8YcbSImhwdqrJ9pW/k2SKS7h3UM3pg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aj9rrheaoXEduUj4KYU6olJZRmwgTRCWkOezbyAQ/9k=; b=CdX08dIF1t+OzPMGHOfbdHfGyX/WB7XI0H7VPs4LGHzao3EgfdIgDO6GhyIN2Gx+f9HPOmwWhTaGCsgnpZFGcmI4/1N51NXElhNFFyVHqJWu6xWL285IFEbvy2AdD4oD1rj9bDdn+YjhHGon6nVMmwppwldtJwmOSOXX0THTAZtx/hJAtg51P9FD87xXeHb1ZCP99npRwUCLSwPE5PNf9es0jFIGq1AM2OhXNemFEtS1S/ga/c0FHIIfpgS6+M++BAOgzsmuljOdqGRSb8ElRnQ1rmyw/5TV++tfbgj7bTA4227KQAYQH+3s9BKdEg4pUGP4wLtFrXTrm7yIAHVkDw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj9rrheaoXEduUj4KYU6olJZRmwgTRCWkOezbyAQ/9k=; b=NzhRyH8M8/Vk6H1saVsVIb3/LqOXl/CumRIz7VuSLwYeVM8hr4J8MgOUKPsHWpRImRbtVxMFcQ/aOTZuuK0ML38lcRO87fA2flpfW8+u4NWq6kOSXrm0GOUJHYoXjQpHIY9GOhpiGxaQl5duugOhvFeolgFPXcCjxSVW5xOgYnU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d9e61ec64daefca6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i91Ow+/rBOw/ykikzC2hBDM1oCRvJLjx8E75C5oujeboLGSPZgbBDME85Bf5+FWUNy5ZhStPmt/dkaboWmymo7kbXycsUyZrQspZJkHch4r2vjKtpls0qwgmDgLIEOyX2U64r8ojQCuhFiL5L/fITZbLyfSo5asO4Ts1qThQKm5omcq8ur9GJJzpgWjul0MsRebxRa3kIigs7iQAfCefrw4/BA3b9UDZpgjTUkjpt1h9AJc4CfyLk7cx9KWvRJ8hS7h0gM5R+BDFbzC+UBvOYbBqEphPg0IIGtcjkHjkH4ORnlbTvRdsZesPV0zWoljb3I7zWN531iPG9j0iZ0uBrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aj9rrheaoXEduUj4KYU6olJZRmwgTRCWkOezbyAQ/9k=; b=cJkgh39BvCfHn8c5CfEkcNtG850YgYxJZ2tkMVEX8ZaTeA+CHiNEi3lV16c7aVV2EaW1BdjnFpiCzAJ/EC3TIZ5DJYim3vNXO/QEW/195eq9KTPusszT+igTLZPiAji9XBDYYuvUkb7EvN7fgApXfInFShY1Sxq2vbAg2w5HQU8R9olgdPqq5vqTiZSDbUsNmk4B/vvwtjFTN7iS97/93nrp/NgCP9+tLCNKjH5QBKcE9WKogr+yNSQx3t2MIUgx7MY+hAgnbZiGTol6y/QrfIl2lHanG1/y11HQl+0Xh4uYjVbibMD1DgDryFcwHnlg4qXu9Omc8J4WwqnswoRygA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aj9rrheaoXEduUj4KYU6olJZRmwgTRCWkOezbyAQ/9k=; b=NzhRyH8M8/Vk6H1saVsVIb3/LqOXl/CumRIz7VuSLwYeVM8hr4J8MgOUKPsHWpRImRbtVxMFcQ/aOTZuuK0ML38lcRO87fA2flpfW8+u4NWq6kOSXrm0GOUJHYoXjQpHIY9GOhpiGxaQl5duugOhvFeolgFPXcCjxSVW5xOgYnU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Date: Fri, 8 Jul 2022 22:54:16 +0800 Message-ID: <20220708145424.1848572-2-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: cf32518d-7d79-4408-aa33-08da60f1da9f X-MS-TrafficTypeDiagnostic: AM6PR08MB5287:EE_|AM5EUR03FT044:EE_|PR2PR08MB4713:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hveMIibSlmdUxpZQdFdSN1ID2n8hbNQCFqZxX7sIfjxj2bHHTlTYoVKCNOeHDAxxJhhvT7Sm74hjBBpPgVmNoY6klyq1Qy1pKsuYqYyEsFVvPsPyBr9bKtZiURzXC4nw1NNQH5C5QKGOQMNAZ4rH1LqcTrofYJbRjBInDqGN7guetAMSiQutWO5/ATu7ffZgIqZ6zmt4vHtSr60zQJx74a2DqhdKe/ML9rNg1tR+o3bGlbgR8P7Pob93nT8Se+Onib1hs42F62yf/plBIUJf5uO0NbkKuqFu0Un6WDSoJOw+AMemXIpuZCoGz5qMxLJKmok07+hal5P8WR5MJhaOM9h2VaPh4R9MTmfPXgFGDOGmytRL5N72ZleMUBGM4JgiyedXIOIjnNejGsopd+LOUKZy7ONenIHyN476ItB/vOALkHKOKo5GSQ8RIMz2vp9yv8NwHAGH5yV7+wcXepSZ/PwVqYw5YjupHZabwgSIAVO9PUgIfe7ohO61k+m1FSTDbwWOKHUeOBdyJN9ekxY7tb5cFMOzWvCXFSzAzDM6cdbTfUloVSwGXyqOhu2R+NrfCCDNliieRCfH3K+21EsfJVhYrouFTGycUSUHAAA3Kz8BYsdQ7NOM3+UVXnvBPncmfgYkyxAku5L0PC8BbtmPunoEJIBxBRPY2IJiLykrrUekUOzawLoPyj/Z0rCcP0j5EsCXqT0p1+4Jre3hAcyd2MPNRmR8YBsDO6tjkFE4fpt3+WoaJ1eY8mULarMz2p3eCDTxqwOXrqbE6BD8VDOgTzvKJVvw/dLPXc/9/Y+EKpODAyeOp6IQGLUzemh2LVdNU5FuaMER1MDgRq0Tf2WTXF1ih5dRce1nTIek2NUGaUQ= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(376002)(39860400002)(46966006)(36840700001)(40470700004)(36860700001)(26005)(86362001)(81166007)(40460700003)(4326008)(70586007)(70206006)(356005)(54906003)(6916009)(40480700001)(316002)(82740400003)(2906002)(8676002)(47076005)(44832011)(426003)(186003)(1076003)(83380400001)(2616005)(15650500001)(336012)(478600001)(7696005)(82310400005)(41300700001)(6666004)(8936002)(36756003)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5287 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 01af82af-140f-44be-6046-08da60f1d3ea X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BFApOGkIxE6e4bK+H+FFgbS8NQCW8tQma9WkcikPtffSLzpgQoHbSty+nzzXPhE0HpyUzDNqIkTrT9N6B8thExrl+b3giQ37JZwK5IPwv4vabx/xrcSuBUmiqWd2nmzpLG24chuFbqIa0EgNMv8KUy5W7EqMEAPnviyWfc80pwa4ONN0UIAhjyCF5LWqNAbmu1i+z63W9ZDAx7Z2AKh7RwkWxsSE9sR1l/e+0x9838BRQouFsmMbrnS27XY6YdXvQUMCr8vTg1+3ExhsuDFGVT1JbLSZCDT1Nd9zmmpGXoVrfad36u+g6K2w8azCjyulAoK7zhmFojB3KUYVLxYmWUkl9sDM53gjCp97NutaQ0Ny92HIDcQfinZFpvfpPbZk7PhlUA1VU2xmKVKz6I6tiCYPgA/el3qi28PudjVv7jP4sUIiq/1uw1U1GCdACxLiRGPFNSbovvwCtqStCLltXDIaM0eLYzmn7ITdAuGfp8y3k8v4ftnAD+w2VniJLxzDW8/EmXblKSPStTYMF3OLJBCVxsxDw8Zb23lDSOdAqUWBxVOMh9eBHcQGOrvzMrlaitZBRzHqhci7V6cR584QtxV4He6iWeOjBcYIXyCv4PsC0Cf+FUtl7xu1knr4woCd73tVAweQwXTTSMRHiSLUgXyBlJ4n7wwmQJ1dR0KOP4n5OX6MfAoCwbrkwzykpJq2Y6iJ4C1hpX5y1EHRnc3fq9sjeyxNAgQp5jsf2eOyVQVxe9PEgW0rwolL+K6lF/kyQr/DavUk65mssngViy3GvE3vOfDj1GcNYkMXQza/4BZQwaC/EVvzSpg6E9sjvZm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(136003)(396003)(46966006)(36840700001)(40470700004)(54906003)(2616005)(83380400001)(186003)(1076003)(47076005)(40480700001)(316002)(6916009)(426003)(8676002)(70206006)(336012)(36756003)(4326008)(70586007)(86362001)(82310400005)(478600001)(81166007)(44832011)(40460700003)(7696005)(8936002)(82740400003)(5660300002)(2906002)(6666004)(15650500001)(41300700001)(36860700001)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:09.6385 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf32518d-7d79-4408-aa33-08da60f1da9f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4713 x86 provides a mem_hotplug variable to maintain the memory hotplug end address. We want to move some codes from x86 to common, so that it can be reused by other architectures. But not all architectures have supported memory hotplug. So in this patch, we introduce this helper to replace mem_hotplug direct access in these codes. This will give the ability of stubbing this helper to those architectures without memory hotplug support. Signed-off-by: Wei Chen --- v1 -> v2: 1. Refine the commit message. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. --- xen/arch/x86/include/asm/mm.h | 6 ++++++ xen/arch/x86/srat.c | 3 +-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h index 07b59c982b..b3dfbdb52b 100644 --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -476,6 +476,12 @@ static inline int get_page_and_type(struct page_info *page, extern paddr_t mem_hotplug; +static inline void mem_hotplug_update_boundary(paddr_t end) +{ + if ( end > mem_hotplug ) + mem_hotplug = end; +} + /****************************************************************************** * With shadow pagetables, the different kinds of address start * to get get confusing. diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index b62a152911..f53431f5e8 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -418,8 +418,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) memblk_nodeid[num_node_memblks] = node; if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { __set_bit(num_node_memblks, memblk_hotplug); - if (end > mem_hotplug) - mem_hotplug = end; + mem_hotplug_update_boundary(end); } num_node_memblks++; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363470.594030 (Exim 4.92) (envelope-from ) id 1o9pOB-0007Wi-Td; Fri, 08 Jul 2022 14:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363470.594030; Fri, 08 Jul 2022 14:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOB-0007Wb-QW; Fri, 08 Jul 2022 14:55:27 +0000 Received: by outflank-mailman (input) for mailman id 363470; Fri, 08 Jul 2022 14:55:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOA-0006vD-Pd for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:27 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061.outbound.protection.outlook.com [40.107.20.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ffd1eb02-fecd-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:55:25 +0200 (CEST) Received: from AM5P194CA0006.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::16) by PAXPR08MB6912.eurprd08.prod.outlook.com (2603:10a6:102:137::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:24 +0000 Received: from AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:8f:cafe::34) by AM5P194CA0006.outlook.office365.com (2603:10a6:203:8f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:24 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT064.mail.protection.outlook.com (10.152.17.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:23 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Fri, 08 Jul 2022 14:55:23 +0000 Received: from 32f413fbdd89.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C20FECCA-9427-4FEF-822D-2A857CD2E588.1; Fri, 08 Jul 2022 14:55:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 32f413fbdd89.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:17 +0000 Received: from DB6PR0202CA0044.eurprd02.prod.outlook.com (2603:10a6:4:a5::30) by DB9PR08MB6649.eurprd08.prod.outlook.com (2603:10a6:10:26c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:14 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::6a) by DB6PR0202CA0044.outlook.office365.com (2603:10a6:4:a5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:55:14 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:14 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:07 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffd1eb02-fecd-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wmw9uhcQvlqoQfsqQKnCb6GYRbv0nfzcevcMi9oDjhtet8V49Jka6Cn7iN71MV7YJs4OmYjZcTRvKhk6AvO6do8jtTUHb2XG2009Ml0rwsDSXVpEkE7qEzB60+tb4cGmEtKKoG3n41GRLMJiaME6pIwFtbvkplNSaTU2lcMopYt7yJEqRBK5hD+LOtBUB3OltG85t2pwWQ5HH4ZOrHv0It7yhM2ozas+/IJBNjlNNRrqTwvKHr8YLatgFN1BRgEQPSg2OmP9zO0AlYoIbAmdgODvYkXO3vEKo/LUIsjoNMuJ685k89nBUYPf5vCWgYkMa3HIKuoOAMxCETG7J7BROA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6hrldKnD93EUpTTS3t0Fp32LcqOWPG36yIxeFRBs9ew=; b=U1D0CzkuG/bS9NDAKPHyY3uDiuz20Eavvyfo8M0Ld/kL7u7MUffbRK8hcSFXUuo0WbEOo2dXfFm/EFEmvmzaBiUAbDrAEiPRzs4XNeU6plEDi+X8CErEZhJ8qZM1Uk0fzqfm/MIgzf8F2AvvrUbNPx4IKi1mH3DM+qbGoqI3CylWi3zKgEG+fbsnr2s/cPEvXNZIxs2+Uy7Tg5OKRNgSQh6OTQCj65Ol9iWW47/PJ5ROu72qxHqnxvlcUkxuoZry63dzcIzclpmpUOFA6q8JXxiUmXdILcEwTSYzfcw+e70juzaLOHKUSWY18c4DNXx2f82eNAaWe7416LrslsJ7Ng== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6hrldKnD93EUpTTS3t0Fp32LcqOWPG36yIxeFRBs9ew=; b=W52zosK23K2Dbskpj5kcMvByi2K0X6WLHttkygQDXQZvtxBCh8XLD+LHhyIGxyuSMSp2IzB+S8RQJA6n3p373HZQXwQb9B0JIW/YMcBoeQj5XDiWILkZw8uzBoQrfKmqc4DMy49thp1uNd5boMfLRmGhlp305LGYFvw9lAm2fyM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1e8f0e31302abb90 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIHrdJvFu0vMjmIyUBGHBwFFYq4cd+uNR0WGKg+FeGnM3E1Ro3ofkprkX0OGeJCnj11SucXA2RXUGHbQS7Xvk06DCyrWY22zLbeHKarJbcs8SRmNNz1XoiU6r7Nt1b7cACMAL0tspsqeIoH6A8t3bJFHoe9VX/kLnZirAv58TnLudgcm67+qVNNW4q/yqytHesY7vFBjUuYeqrZE8cLqhGIlojz2/QN3JBKvlwnRkxkOV+FVtgZim491wgG+N0AYI1lMi+qOkhfBOL6nX5WqYRmlz4LixSfFitigKpLaRYJ2SExb15uwJcaldq8Fc/2j2J4VrKvv5jLjfA180po3Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6hrldKnD93EUpTTS3t0Fp32LcqOWPG36yIxeFRBs9ew=; b=Ij8niYl0dRhV3OChGMOKPu08IIiWnM66A9e7957ZEBaQk3RDITL87wehcfZmj/kN7X5Xu8nTQIwD2m7wqDjTkGx4uwDXw9ifacl8rC4tO+Vrp3sXpK8Bo4AUneYGix4Q88TLb/M1Pk6MrgrZIP8f5gKWjhuvpcmhu1us6rwtAD/OgfdeG+Z85tnIzkrnb+x6S+frN5FeocAc5kZg5InTK9enykOekU0msmh08G1MvOc5wAvQYeYib1u3asu4UuV8MdkgAXNSrzB5gTj8Vg07WMkKG/quuc3/HK5J/7x3YHOBERoT3Q6uiZyNafa0gRgUS/xcMX5C5Cvf5PtzdwoIKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6hrldKnD93EUpTTS3t0Fp32LcqOWPG36yIxeFRBs9ew=; b=W52zosK23K2Dbskpj5kcMvByi2K0X6WLHttkygQDXQZvtxBCh8XLD+LHhyIGxyuSMSp2IzB+S8RQJA6n3p373HZQXwQb9B0JIW/YMcBoeQj5XDiWILkZw8uzBoQrfKmqc4DMy49thp1uNd5boMfLRmGhlp305LGYFvw9lAm2fyM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , Jiamei Xie Subject: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Date: Fri, 8 Jul 2022 22:54:19 +0800 Message-ID: <20220708145424.1848572-5-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 371f0f16-54cb-4d99-5546-08da60f1e2f3 X-MS-TrafficTypeDiagnostic: DB9PR08MB6649:EE_|AM5EUR03FT064:EE_|PAXPR08MB6912:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: C/TH2QUcBlatTcsOZce6fy1N79coYK1iS0Qql1xPWeWxV05ah19+w9cigN5uxOtvaCdvkndztLMYafHHdCW5WMgOQsOwwmOJFvsy/9AhRIILOLUo89Bt+av9NKsln+9XijMJQ+giOVD0R/UqyGZw9WSVfECn97813l1FCYkvt07f692KsPS4+v242jq5owAou+APQ70+rP340jEgHhHqX+kkLzz/vMWWtLif04vgJ5KczJxwZzFKeYp4CmYUltlobVxO7WCMZZ0poB683ppqGeLzPXx8vs6z39WNnCPd3QalSwWyfzdLhE3oFxlfIrv8ZABPyiyjvaZ8/g/Zx4QUe/J6wDM3WY9B1Ap6SYd41nSHZ6BPCVByTB5uGKyHHP5Dk00lyWRZHs8QzqmCx6dst/qmkZC55iXvkuHzW6Vexm/1CabCRK/RYxWj5fqIgG5GOTjCgWG1HVk1yTvhz1f0PVGB6sG8mHnbY8GQk5AcnuOfpX+TQdlay2mJgGwhSSEDr74GTa608htGBiqCCfffUCV1DXzhYMiqseKsoyvbsru4lrJRllXqwH3Y+hzpVKtwR7T95sdMlDNBELyxaXZnjf49QKMfoRRz4o6oU+OCDdgFEsSZkyivrO0e8u0j1un3fTDmjeU0XUIIjrMiA1JzyKl4Xmv7uSJWI4s6b6o7lJjb27GxVO/J37dpIV1SRxHGFyeq20x4o6nP1RErNefGf5+NPOBTN92wulr+Q5adiYMXcd9KjXQKtnOLPO65iVBWMUNCoHVXQCS8cTmcX6TkS7zsoZpvPdUoH3y7GoWu7LzyRYC+gC/7AN/hTeOSaaEtzoKe1JjuQ8I8XVKZyqwcLGsWB01dmc3SxYz/czNI+yk= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966006)(36840700001)(40470700004)(5660300002)(8936002)(44832011)(2906002)(40480700001)(40460700003)(82310400005)(83380400001)(36860700001)(82740400003)(86362001)(6666004)(81166007)(186003)(36756003)(6916009)(54906003)(7696005)(70206006)(70586007)(2616005)(4326008)(316002)(356005)(1076003)(26005)(47076005)(336012)(41300700001)(478600001)(426003)(8676002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6649 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0cccf23a-e4a2-49e3-7d59-08da60f1dd49 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t+y/a9yq0ij6V+9RnM/faSB+7E8mYS+EDOoqUYD5qi0SL/HTW5kjXZc6lMgbq5kXKILjhdnnRmsGwUJH7dCJU9UF6UeYF5B/77boXc5h6sdKhZ190ydLK0Q9LTXM2RYmna0AiFIkECtGynA7BpyxFW0QGawgEALuNfP5JGufkuwYrbl9efPtW2jSbPJ2N6ae6ncW/kSNdR4G9uudCpoAUnwfsUWqCK2p9rX+vZnQGedyihVWFvN5UXTvrq162UysYwcqYB+yMrnuLvGSis3BWOtNFWl4bSWM9J6KeNmEh3f3OowtlzeeFgYDhO9TAYoVi3/grBYAHq4bVfbkIg8torepf0pAPUvQnHLkOBTBTZX0pvnp6ugykDDn/HEZ/bBZHrMYLIrgKPD8Ks+f03XnPmLvyiiN/oggBmJ1gUFIDssSMbXVQl0zZgfjIuhO5fbnpL0aq+QG53htlB8g/rfaByM1wj7q73OSk95Mm2fSTt6hzPrF4YeVa8bAJ20yrnplbPTCevZQATK+CLMe5pjB1gabDYSw8PClZ24NDLA8WlKUal1NVX3j6JJBOrjvV0oCRdztfBotdmrwDVgDz4CJJ0wwn1R/h9E3OfKwhg1Q/q5T7yyYYIijrVLjZhQ5ik4GFjqUy6sqogjJO6190rgB4PaoBesIhA/mEJeOQIqs4n0mRSRj4mtbXuR0BZoAcKCPSPuv/zW2ga91M0NVjAwYGgSIMqMJTuHoXWpYbfFFA2S2QFyOfDQoKutnsQ7F3YFalxQscI/YWB8wDgEJg83czUJKlnZIa6l/JLk0qSSkGlOrSKs76kq5/yZhDXyDPMM8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(376002)(136003)(36840700001)(46966006)(40470700004)(336012)(41300700001)(40460700003)(36860700001)(6666004)(426003)(47076005)(1076003)(26005)(2616005)(316002)(7696005)(6916009)(83380400001)(54906003)(36756003)(2906002)(5660300002)(8936002)(81166007)(40480700001)(70206006)(4326008)(8676002)(44832011)(86362001)(70586007)(186003)(82740400003)(82310400005)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:23.6770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 371f0f16-54cb-4d99-5546-08da60f1e2f3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6912 VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This results in two lines of error-checking code in phys_to_nid that is not actually working and causing two compilation errors: 1. error: "MAX_NUMNODES" undeclared (first use in this function). This is because in the common header file, "MAX_NUMNODES" is defined after the common header file includes the ARCH header file, where phys_to_nid has attempted to use "MAX_NUMNODES". This error was resolved after we moved the phys_to_nid from x86 ARCH header file to common header file. 2. error: wrong type argument to unary exclamation mark. This is because, the error-checking code contains !node_data[nid]. But node_data is a data structure variable, it's not a pointer. So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to enable the two lines of error-checking code. And fix the left compilation errors by replacing !node_data[nid] to !node_data[nid].node_spanned_pages. Although NUMA allows one node can only have CPUs but without any memory. And node with 0 bytes of memory might have an entry in memnodemap[] theoretically. But that doesn't mean phys_to_nid can find any valid address from a node with 0 bytes memory. Signed-off-by: Wei Chen Tested-by: Jiamei Xie --- v1 -> v2: 1. Move from part#1 to part#2. (Comment from NUMA part1 series) 2. Refine the justification of using !node_data[nid].node_spanned_pages. (From NUMA part1 series) 3. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 4. Adjust the conditional express for ASSERT. 5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 6. Use conditional macro to gate MAX_NUMNODES for other architectures. --- xen/include/xen/numa.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index db0e524a0e..695ad51df0 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -36,8 +36,6 @@ struct node { extern int compute_hash_shift(struct node *nodes, int numnodes, nodeid_t *nodeids); -#define VIRTUAL_BUG_ON(x) - /* Enumerations for NUMA status. */ enum numa_mode { numa_on = 0, @@ -77,9 +75,9 @@ extern struct node_data node_data[]; static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) { nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); return nid; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363471.594041 (Exim 4.92) (envelope-from ) id 1o9pOH-0007vV-8G; Fri, 08 Jul 2022 14:55:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363471.594041; Fri, 08 Jul 2022 14:55:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOH-0007vF-49; Fri, 08 Jul 2022 14:55:33 +0000 Received: by outflank-mailman (input) for mailman id 363471; Fri, 08 Jul 2022 14:55:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOF-0007Ai-CM for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:31 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01da2c41-fece-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 16:55:29 +0200 (CEST) Received: from FR3P281CA0070.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::22) by DB9PR08MB7179.eurprd08.prod.outlook.com (2603:10a6:10:2cc::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:26 +0000 Received: from VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::3c) by FR3P281CA0070.outlook.office365.com (2603:10a6:d10:4b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.13 via Frontend Transport; Fri, 8 Jul 2022 14:55:26 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT033.mail.protection.outlook.com (10.152.18.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:25 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Fri, 08 Jul 2022 14:55:25 +0000 Received: from 31d9462c680e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6A78CC50-9495-420C-98C8-2FB08507F2EA.1; Fri, 08 Jul 2022 14:55:18 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 31d9462c680e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:18 +0000 Received: from DB9PR05CA0015.eurprd05.prod.outlook.com (2603:10a6:10:1da::20) by VI1PR08MB4511.eurprd08.prod.outlook.com (2603:10a6:803:f9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 8 Jul 2022 14:55:06 +0000 Received: from DBAEUR03FT009.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1da:cafe::46) by DB9PR05CA0015.outlook.office365.com (2603:10a6:10:1da::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:55:06 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT009.mail.protection.outlook.com (100.127.143.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:06 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:05 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:03 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01da2c41-fece-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Nwcj3sou0jYGFwTRilG6ZVxUBERKYDYiUsijrH3EKwp5hlgtX6gvhf/Sya1dxPkz+yL1xIOmmzYwml47SR7rER1FTFqH2wumJsUtXM3p03iLTF3mjmwGGRHVegbeE4PcbJ6cgjO7LFXEdIcekAmgmtCdr3c3LfDXt+MFmgrdAem/uW0iM8xu0ZaM8fo2C7I7jtt1wiQ5gyv2FuwNMmGTJseWXzKoXNS+oHOtKmZj8a7Ar8fRs8PGPPJSfftYaYygXa5bwrti4GyEnSi5jFF7Ujy6THXfbMc0VQPeigbFgtx3CoJ8LKMH/vSKpoZW5wpA3IA6SwbOoFi7hyQc/mvV6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rp+JDYzWrvvbuy8ZPNrJYoe9iSuHHdiEXdj+bJMmS4=; b=VOj0Buys+rflBeHYNVCjdrFf9RBsk9BH7M2W+pBMsDZKeyMrJL6KqxBtlKsPD++Tg53GrpF+Q6A8JjeJ8pGG0yrTjlbkNGS1QEhkXKn/sNWacntV4CbGAJM3jh5mMLEOWLEZpVRURPt1saKqla+L+1vaauy3pnhrjBrfXcv+H7Ib8yWWO/PFJD+tYP30KfZG2CNo+n01LkdJ0gei6tt+9CZOSGW9zG1+RNEBRvbWBwGLgANdKL6FB5XsRvK8afAqB2XZA1e3fKhbEBUcXlgZBQDVHnSGv6UMdwIpmzPYOfZuqWDfRHq6kIuThw28TXKCsfJAHFsZVpxnHbNsuS9Nkw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rp+JDYzWrvvbuy8ZPNrJYoe9iSuHHdiEXdj+bJMmS4=; b=NuzlkyGE5WN5hNskc657a6o1ZBVeO3f9DbA/+Oi/2cHzv/sC3FivNGHhPavH17y8CJYsupRnec2Sjz1FfIw/KgPq1qd33RUG/4r65Rz+QJzH7kIRQDfSU301ZxxT1BNsVL+n5dDUlxQHiL9eRTX6VQ+Bzm2U3oQs0DVZbI9D3H0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 06c9b3aeb875b9c1 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHakffQVIBqwEqU/rcqsZkv3OfKzeTVRJv8lNDqXsht+LDyfETVM2mrj45TRm0hqp9mXbNLIEWmjZEJ74dU360KQMfkE22aT0DpQOrH0ATZ5YNdk/uZ+paHvp2sWHRS3nabyqeAawRrMwsk3aqvHKWDBenSD3UgK+vXw+BYYZCM/NZgAOU4R5bFc7JPaEFLD5NoRAzzxddYVZSjJkgT20WRGKZnfNz5VASdHkV4tcisXDkCo2sWNGbcIP2uzBXB6vfojHMXzjT8M4VnmW4EQAcP1GyFQ7urkBqmrLg23ZjNQ+FzsXSyFeLiaAiEsDGSTOo3PKmOXpM/4p2wwc9MRTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9rp+JDYzWrvvbuy8ZPNrJYoe9iSuHHdiEXdj+bJMmS4=; b=XDDHBLczuF5YjM+by/18qz9RC+vlYB5pBh6p+M3Dv5Bv2Abj87WjP04g7Wwm65/29lbxmczOddzA89RvB9f8P6ymQXR4SzDwL58IWU15C+G995J/1NRrGppYKU1D07IMWVz7XBnCwlfxw212ZEpOOKc1765MulMKXmo9picKR4ZDOn4TzMZf0Vnyj4H62PFBEs29tn31kLPXYY/2pbPfeyNgCOLTB8rnkRACHVDw2iH8tfie84D6XizLtOGT2MkVOYLvBRyDhT4cY9L/CtkMJVHepKiEJn+Osav3BptywzZKoNvb9I/3EkLuCYaIJvyD60Gc9gU/AM4h3pGX0uIShg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9rp+JDYzWrvvbuy8ZPNrJYoe9iSuHHdiEXdj+bJMmS4=; b=NuzlkyGE5WN5hNskc657a6o1ZBVeO3f9DbA/+Oi/2cHzv/sC3FivNGHhPavH17y8CJYsupRnec2Sjz1FfIw/KgPq1qd33RUG/4r65Rz+QJzH7kIRQDfSU301ZxxT1BNsVL+n5dDUlxQHiL9eRTX6VQ+Bzm2U3oQs0DVZbI9D3H0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 3/9] xen/x86: move generically usable NUMA code from x86 to common Date: Fri, 8 Jul 2022 22:54:18 +0800 Message-ID: <20220708145424.1848572-4-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 49745b58-c02d-4413-75e0-08da60f1e43b X-MS-TrafficTypeDiagnostic: VI1PR08MB4511:EE_|VE1EUR03FT033:EE_|DB9PR08MB7179:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RYfULEEnsTM3mRQbRcX7hbjDdR0ym+QHsG2fxbH8o3XDHC/psvaQ2wA7UPPgXBxYFRXbCCKN6+10vpmF5H6BIObZ6AmMmsKLFm2FIwc4Gb3BqoM4gt5BBXNGOvwh7C9D9A49LV29OK50IxYDTceu0wRCrdVVPO1lOZmnlRH28ag0sgb8PGf9o2J09D8UX82qmwgyd44oH2EE7kO1FuVsnSk2NG3zYo8ad9JOzUGgrSEWnZLBOzoHzo4tyu67wvNBQSBjAm/5l05c0XJBB9y7QlewqHH/TtT9mTBwNhhRTi45/gEUA+xVJAn5RFYRv4HIth42f8BVp1qi+xu5O0GVs0R2lwpdYz81sohcosMIkR0a1xLn36yKCnkJG4lmEAGbw4EabA8HXIIl8rAA9PH2RF146ibgJVGeIe5lQdNLPgmBUAmrIJAwjvc4yaB+361VhrmKsV7VEdcynRstI2AswASJlzghoE47dEkxpoNnYaqFkzRNQy4xJo/F0Xmb25s4DbZ/rxPNmWXgc51CWTEds9RFTJxrU1hB/YbWzpdnYb+OQZ3hdzcDQJ1DzLuhPM8JCLcmcHLGXQ6RSs6T17uaDBDLnLKBgLdgSKX70NIxSQKTEVEMZu4VFP+kTGh0dgqAtfXgOwJQnk+fFPUWEe3H+a13TqzYZzun6M8QIdcr6pgO35edNCIRjQBX7FoowzufRD97urRUtQRLvyAbXjbgR5K91PTToWI1Cj76Y/+xSFDPgPbr19O/fenwu+3XNPxBGhMIqEkY6yNn2EOgojvEMYsutSvdOgqarMipsmOTPFsxttjAojZLhzKMM8/jIhiHEhuxG0FtQwbvz+cCN1lknF7TH07FBwZh7U00EwRVmD8= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(136003)(346002)(40470700004)(46966006)(36840700001)(82310400005)(70206006)(6916009)(83380400001)(4326008)(81166007)(70586007)(316002)(426003)(1076003)(186003)(2616005)(8676002)(41300700001)(356005)(26005)(478600001)(82740400003)(54906003)(47076005)(6666004)(86362001)(30864003)(40480700001)(2906002)(40460700003)(36860700001)(7696005)(44832011)(5660300002)(336012)(36756003)(8936002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4511 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c29c1cd3-efcf-4b6c-7b36-08da60f1d88b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8trM9A6Nu5O9y6dvk0Ca8Wh6MbhqUE/kcoJ5j8pAN8TONw9lZ9FiGtCWXfMIEgUgpHGzmwtlpSYjm2AYwxlcpzCQov2n21wByu4DiG1DwHT++OeLDdwJbMxeVL3Fy4XJCHeiNaWMsN5VHu13dlXzDBHqkMbLUrw3uTwsviU+FfNMvvBGXtDcYyFGZp9FclPkQgSV9VVm0ZLmb6FVrSRSbChtnCq7AaSCzN0MmtmtcTWx56aAp5pgJFP+EljoprDEE3okmd8Sxg9kroTxa4QMVRPdHWN5FHzpzlDDTlYQgvKhdederetOfVn6mSWQ/YLZNewFvhRcevUb0TeMJiyMzO+5llrxY/tZ/kRdi8oy6jHF+63NUmclRL52KJZ7/f3g00vt22giPrBXPTbFYV424F46AQUpCWRBYqT3IghhMAFCa6ikRHvDgtG7kC6/BQ7iWElsFjXEb29GFMpG4EtuKnVSBLpY6aehXLrDEsRTNnX13LKc3xYKH6szs3GN1R/TodMrD/HVLCFRD+hOZtlDUoLlXzwnm0KRyY8lfaOEB+hnHCrA620wGqfz8PiJ/omYTvVCV8Fj24hDisJdQ1hClV8+Hq+89LaXRDaxaKHCLj3R/0XXjoXObUGTEJLJgT/2KydplLMu+tLAeuizJSa3FkO+k8pNI1NDQc63FwYOcrNTLOCygDu3kghVDPzmVmKf6pW0ZrFrZ8QUN13rLeiwGt4OWGJY1hYCOjO5qrc+8H+Na5KVRPm+JHtKbCCF+uueeZbIXnqCySmpA1CXL3JBWUrXcug5BbPFOLGaoGT4rZ9PjgdJtr8bRYKOG/8N26Sq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(39860400002)(46966006)(36840700001)(40470700004)(107886003)(316002)(1076003)(36756003)(40480700001)(30864003)(82740400003)(6666004)(5660300002)(86362001)(6916009)(44832011)(2616005)(83380400001)(54906003)(8936002)(478600001)(47076005)(336012)(4326008)(8676002)(26005)(36860700001)(70586007)(7696005)(186003)(81166007)(426003)(82310400005)(41300700001)(2906002)(70206006)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:25.7427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 49745b58-c02d-4413-75e0-08da60f1e43b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7179 There are some codes in x86/numa.c can be shared by architectures to implement NUMA support. Just like some variables and functions to check and store NUMA memory map. And some variables and functions to do NUMA initialization. In this patch, we move them to common/numa.c and xen/numa.h and use the CONFIG_NUMA to gate them for non-NUMA supported architectures. As the target header file is Xen-style, so we trim some spaces and replace tabs for the codes that has been moved to xen/numa.h at the same time. As we have moved phy_to_nid to xen/numa.h, we don't need a separate MAX_NUMNODES in asm/numa.h. Now all architectures can use the same MAX_NUMNODES in xen/numa.h. The conditional macro can be removed. Signed-off-by: Wei Chen --- v1 -> v2: 1. New patch in v2. --- xen/arch/x86/include/asm/numa.h | 64 ----- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 431 +----------------------------- xen/common/Makefile | 1 + xen/common/numa.c | 439 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 74 ++++++ 6 files changed, 515 insertions(+), 495 deletions(-) create mode 100644 xen/common/numa.c diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index ee8262d969..d8960743d4 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -9,81 +9,17 @@ typedef u8 nodeid_t; extern int srat_rev; -extern nodeid_t cpu_to_node[NR_CPUS]; -extern cpumask_t node_to_cpumask[]; - -#define cpu_to_node(cpu) (cpu_to_node[cpu]) -#define parent_node(node) (node) -#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) -#define node_to_cpumask(node) (node_to_cpumask[node]) - -struct node { - paddr_t start, end; -}; - -extern int compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids); extern nodeid_t pxm_to_node(unsigned int pxm); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) -#define VIRTUAL_BUG_ON(x) - -/* Enumerations for NUMA status. */ -enum numa_mode { - numa_on = 0, - numa_off, - /* NUMA turns on, but ACPI table is bad or disabled. */ - numa_no_acpi, - /* NUMA turns on, and ACPI table works well. */ - numa_acpi, -}; - -extern void numa_add_cpu(int cpu); -extern void numa_init_array(void); -extern bool numa_enabled_with_firmware(void); -extern enum numa_mode numa_status; extern bool srat_disabled(void); -extern void numa_set_node(int cpu, nodeid_t node); extern nodeid_t setup_node(unsigned int pxm); extern void srat_detect_node(int cpu); -extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); extern nodeid_t apicid_to_node[]; extern void init_cpu_to_node(void); -static inline void clear_node_cpumask(int cpu) -{ - cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -/* Simple perfect hash to map pdx to node numbers */ -extern int memnode_shift; -extern unsigned long memnodemapsize; -extern u8 *memnodemap; - -struct node_data { - unsigned long node_start_pfn; - unsigned long node_spanned_pages; -}; - -extern struct node_data node_data[]; - -static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) -{ - nodeid_t nid; - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); - nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); - return nid; -} - -#define NODE_DATA(nid) (&(node_data[nid])) - -#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) -#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) -#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ - NODE_DATA(nid)->node_spanned_pages) #define arch_want_default_dmazone() (num_online_nodes() > 1) extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); diff --git a/xen/arch/x86/include/asm/setup.h b/xen/arch/x86/include/asm/setup.h index 21037b7f31..ae470ea12f 100644 --- a/xen/arch/x86/include/asm/setup.h +++ b/xen/arch/x86/include/asm/setup.h @@ -20,7 +20,6 @@ void early_time_init(void); void set_nr_cpu_ids(unsigned int max_cpus); -void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); void arch_init_memory(void); void subarch_init_memory(void); diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 0777a7518d..193314dbd9 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -4,20 +4,11 @@ * Adapted for Xen: Ryan Harper */ -#include -#include #include -#include +#include #include #include -#include -#include -#include -#include -#include #include -#include -#include #ifndef Dprintk #define Dprintk(x...) @@ -26,28 +17,12 @@ /* from proto.h */ #define round_up(x,y) ((((x)+(y))-1) & (~((y)-1))) -struct node_data node_data[MAX_NUMNODES]; - -/* Mapping from pdx to node id */ -int memnode_shift; -static typeof(*memnodemap) _memnodemap[64]; -unsigned long memnodemapsize; -u8 *memnodemap; - -nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { - [0 ... NR_CPUS-1] = NUMA_NO_NODE -}; /* * Keep BIOS's CPU2node information, should not be used for memory allocaion */ nodeid_t apicid_to_node[MAX_LOCAL_APIC] = { [0 ... MAX_LOCAL_APIC-1] = NUMA_NO_NODE }; -cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; - -nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; - -enum numa_mode numa_status; bool srat_disabled(void) { @@ -59,267 +34,6 @@ bool __init numa_enabled_with_firmware(void) return numa_status == numa_acpi; } -/* - * Given a shift value, try to populate memnodemap[] - * Returns : - * 1 if OK - * 0 if memnodmap[] too small (of shift too small) - * -1 if node overlap or lost ram (shift too big) - */ -static int __init populate_memnodemap(const struct node *nodes, - int numnodes, int shift, nodeid_t *nodeids) -{ - unsigned long spdx, epdx; - int i, res = -1; - - memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - if ( (epdx >> shift) >= memnodemapsize ) - return 0; - do { - if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) - return -1; - - if ( !nodeids ) - memnodemap[spdx >> shift] = i; - else - memnodemap[spdx >> shift] = nodeids[i]; - - spdx += (1UL << shift); - } while ( spdx < epdx ); - res = 1; - } - - return res; -} - -static int __init allocate_cachealigned_memnodemap(void) -{ - unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); - unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); - - memnodemap = mfn_to_virt(mfn); - mfn <<= PAGE_SHIFT; - size <<= PAGE_SHIFT; - printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", - mfn, mfn + size); - memnodemapsize = size / sizeof(*memnodemap); - - return 0; -} - -/* - * The LSB of all start and end addresses in the node map is the value of the - * maximum possible shift. - */ -static int __init extract_lsb_from_nodes(const struct node *nodes, - int numnodes) -{ - int i, nodes_used = 0; - unsigned long spdx, epdx; - unsigned long bitfield = 0, memtop = 0; - - for ( i = 0; i < numnodes; i++ ) - { - spdx = paddr_to_pdx(nodes[i].start); - epdx = paddr_to_pdx(nodes[i].end - 1) + 1; - if ( spdx >= epdx ) - continue; - bitfield |= spdx; - nodes_used++; - if ( epdx > memtop ) - memtop = epdx; - } - if ( nodes_used <= 1 ) - i = BITS_PER_LONG - 1; - else - i = find_first_bit(&bitfield, sizeof(unsigned long)*8); - memnodemapsize = (memtop >> i) + 1; - return i; -} - -int __init compute_hash_shift(struct node *nodes, int numnodes, - nodeid_t *nodeids) -{ - int shift; - - shift = extract_lsb_from_nodes(nodes, numnodes); - if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) - memnodemap = _memnodemap; - else if ( allocate_cachealigned_memnodemap() ) - return -1; - printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); - - if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) - { - printk(KERN_INFO "Your memory is not aligned you need to " - "rebuild your hypervisor with a bigger NODEMAPSIZE " - "shift=%d\n", shift); - return -1; - } - - return shift; -} -/* initialize NODE_DATA given nodeid and start/end */ -void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) -{ - unsigned long start_pfn = paddr_to_pfn(start); - unsigned long end_pfn = paddr_to_pfn(end); - - NODE_DATA(nodeid)->node_start_pfn = start_pfn; - NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; - - node_set_online(nodeid); -} - -void __init numa_init_array(void) -{ - int rr, i; - - /* There are unfortunately some poorly designed mainboards around - that only connect memory to a single CPU. This breaks the 1:1 cpu->node - mapping. To avoid this fill in the mapping for all possible - CPUs, as the number of CPUs is not known yet. - We round robin the existing nodes. */ - rr = first_node(node_online_map); - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( cpu_to_node[i] != NUMA_NO_NODE ) - continue; - numa_set_node(i, rr); - rr = cycle_node(rr, node_online_map); - } -} - -#ifdef CONFIG_NUMA_EMU -static int numa_fake __initdata = 0; - -/* Numa emulation */ -static int __init numa_emulation(unsigned long start_pfn, - unsigned long end_pfn) -{ - int i; - struct node nodes[MAX_NUMNODES]; - uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; - - /* Kludge needed for the hash function */ - if ( hweight64(sz) > 1 ) - { - u64 x = 1; - while ( (x << 1) < sz ) - x <<= 1; - if ( x < sz/2 ) - printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); - sz = x; - } - - memset(&nodes,0,sizeof(nodes)); - for ( i = 0; i < numa_fake; i++ ) - { - nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; - if ( i == numa_fake - 1 ) - sz = pfn_to_paddr(end_pfn) - nodes[i].start; - nodes[i].end = nodes[i].start + sz; - printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", - i, - nodes[i].start, nodes[i].end, - (nodes[i].end - nodes[i].start) >> 20); - node_set_online(i); - } - memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); - if ( memnode_shift < 0 ) - { - memnode_shift = 0; - printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); - return -1; - } - for_each_online_node ( i ) - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - numa_init_array(); - - return 0; -} -#endif - -void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) -{ - int i; - paddr_t start = pfn_to_paddr(start_pfn); - paddr_t end = pfn_to_paddr(end_pfn); - -#ifdef CONFIG_NUMA_EMU - if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) - return; -#endif - -#ifdef CONFIG_ACPI_NUMA - if ( numa_status != numa_off && !acpi_scan_nodes(start, end) ) - return; -#endif - - printk(KERN_INFO "%s\n", - numa_status == numa_off ? "NUMA turned off" - : "No NUMA configuration found"); - - printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", - start, end); - /* setup dummy node covering all memory */ - memnode_shift = BITS_PER_LONG - 1; - memnodemap = _memnodemap; - /* Dummy node only uses 1 slot in reality */ - memnodemap[0] = 0; - memnodemapsize = 1; - - nodes_clear(node_online_map); - node_set_online(0); - for ( i = 0; i < nr_cpu_ids; i++ ) - numa_set_node(i, 0); - cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); - setup_node_bootmem(0, start, end); -} - -void numa_add_cpu(int cpu) -{ - cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); -} - -void numa_set_node(int cpu, nodeid_t node) -{ - cpu_to_node[cpu] = node; -} - -/* [numa=off] */ -static int __init cf_check numa_setup(const char *opt) -{ - if ( !strncmp(opt,"off",3) ) - numa_status = numa_off; - else if ( !strncmp(opt,"on",2) ) - numa_status = numa_on; -#ifdef CONFIG_NUMA_EMU - else if ( !strncmp(opt, "fake=", 5) ) - { - numa_status = numa_on; - numa_fake = simple_strtoul(opt+5,NULL,0); - if ( numa_fake >= MAX_NUMNODES ) - numa_fake = MAX_NUMNODES; - } -#endif -#ifdef CONFIG_ACPI_NUMA - else if ( !strncmp(opt,"noacpi",6) ) - numa_status = numa_no_acpi; -#endif - else - return -EINVAL; - - return 0; -} -custom_param("numa", numa_setup); - /* * Setup early cpu_to_node. * @@ -368,146 +82,3 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } - -static void cf_check dump_numa(unsigned char key) -{ - s_time_t now = NOW(); - unsigned int i, j, n; - struct domain *d; - struct page_info *page; - unsigned int page_num_node[MAX_NUMNODES]; - const struct vnuma_info *vnuma; - - printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, - now); - - for_each_online_node ( i ) - { - paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); - - printk("NODE%u start->%lu size->%lu free->%lu\n", - i, node_start_pfn(i), node_spanned_pages(i), - avail_node_heap_pages(i)); - /* sanity check phys_to_nid() */ - if ( phys_to_nid(pa) != i ) - printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", - pa, phys_to_nid(pa), i); - } - - j = cpumask_first(&cpu_online_map); - n = 0; - for_each_online_cpu ( i ) - { - if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) - { - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - j = i; - n = 1; - } - else - ++n; - } - if ( n > 1 ) - printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); - else - printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); - - rcu_read_lock(&domlist_read_lock); - - printk("Memory location of each domain:\n"); - for_each_domain ( d ) - { - process_pending_softirqs(); - - printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); - - for_each_online_node ( i ) - page_num_node[i] = 0; - - spin_lock(&d->page_alloc_lock); - page_list_for_each(page, &d->page_list) - { - i = phys_to_nid(page_to_maddr(page)); - page_num_node[i]++; - } - spin_unlock(&d->page_alloc_lock); - - for_each_online_node ( i ) - printk(" Node %u: %u\n", i, page_num_node[i]); - - if ( !read_trylock(&d->vnuma_rwlock) ) - continue; - - if ( !d->vnuma ) - { - read_unlock(&d->vnuma_rwlock); - continue; - } - - vnuma = d->vnuma; - printk(" %u vnodes, %u vcpus, guest physical layout:\n", - vnuma->nr_vnodes, d->max_vcpus); - for ( i = 0; i < vnuma->nr_vnodes; i++ ) - { - unsigned int start_cpu = ~0U; - - if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) - printk(" %3u: pnode ???,", i); - else - printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); - - printk(" vcpus "); - - for ( j = 0; j < d->max_vcpus; j++ ) - { - if ( !(j & 0x3f) ) - process_pending_softirqs(); - - if ( vnuma->vcpu_to_vnode[j] == i ) - { - if ( start_cpu == ~0U ) - { - printk("%d", j); - start_cpu = j; - } - } - else if ( start_cpu != ~0U ) - { - if ( j - 1 != start_cpu ) - printk("-%d ", j - 1); - else - printk(" "); - start_cpu = ~0U; - } - } - - if ( start_cpu != ~0U && start_cpu != j - 1 ) - printk("-%d", j - 1); - - printk("\n"); - - for ( j = 0; j < vnuma->nr_vmemranges; j++ ) - { - if ( vnuma->vmemrange[j].nid == i ) - printk(" %016"PRIx64" - %016"PRIx64"\n", - vnuma->vmemrange[j].start, - vnuma->vmemrange[j].end); - } - } - - read_unlock(&d->vnuma_rwlock); - } - - rcu_read_unlock(&domlist_read_lock); -} - -static int __init cf_check register_numa_trigger(void) -{ - register_keyhandler('u', dump_numa, "dump NUMA info", 1); - return 0; -} -__initcall(register_numa_trigger); - diff --git a/xen/common/Makefile b/xen/common/Makefile index 3baf83d527..9a3a12b12d 100644 --- a/xen/common/Makefile +++ b/xen/common/Makefile @@ -26,6 +26,7 @@ obj-$(CONFIG_MEM_ACCESS) += mem_access.o obj-y += memory.o obj-y += multicall.o obj-y += notifier.o +obj-$(CONFIG_NUMA) += numa.o obj-y += page_alloc.o obj-$(CONFIG_HAS_PDX) += pdx.o obj-$(CONFIG_PERF_COUNTERS) += perfc.o diff --git a/xen/common/numa.c b/xen/common/numa.c new file mode 100644 index 0000000000..bc6a2ded14 --- /dev/null +++ b/xen/common/numa.c @@ -0,0 +1,439 @@ +/* + * Generic VM initialization for NUMA setups. + * Copyright 2002,2003 Andi Kleen, SuSE Labs. + * Adapted for Xen: Ryan Harper + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +struct node_data node_data[MAX_NUMNODES]; + +/* Mapping from pdx to node id */ +int memnode_shift; +static typeof(*memnodemap) _memnodemap[64]; +unsigned long memnodemapsize; +u8 *memnodemap; + +nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { + [0 ... NR_CPUS-1] = NUMA_NO_NODE +}; + +cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; + +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; + +enum numa_mode numa_status; + +/* + * Given a shift value, try to populate memnodemap[] + * Returns : + * 1 if OK + * 0 if memnodmap[] too small (of shift too small) + * -1 if node overlap or lost ram (shift too big) + */ +static int __init populate_memnodemap(const struct node *nodes, + int numnodes, int shift, nodeid_t *nodeids) +{ + unsigned long spdx, epdx; + int i, res = -1; + + memset(memnodemap, NUMA_NO_NODE, memnodemapsize * sizeof(*memnodemap)); + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + if ( spdx >= epdx ) + continue; + if ( (epdx >> shift) >= memnodemapsize ) + return 0; + do { + if ( memnodemap[spdx >> shift] != NUMA_NO_NODE ) + return -1; + + if ( !nodeids ) + memnodemap[spdx >> shift] = i; + else + memnodemap[spdx >> shift] = nodeids[i]; + + spdx += (1UL << shift); + } while ( spdx < epdx ); + res = 1; + } + + return res; +} + +static int __init allocate_cachealigned_memnodemap(void) +{ + unsigned long size = PFN_UP(memnodemapsize * sizeof(*memnodemap)); + unsigned long mfn = mfn_x(alloc_boot_pages(size, 1)); + + memnodemap = mfn_to_virt(mfn); + mfn <<= PAGE_SHIFT; + size <<= PAGE_SHIFT; + printk(KERN_DEBUG "NUMA: Allocated memnodemap from %lx - %lx\n", + mfn, mfn + size); + memnodemapsize = size / sizeof(*memnodemap); + + return 0; +} + +/* + * The LSB of all start and end addresses in the node map is the value of the + * maximum possible shift. + */ +static int __init extract_lsb_from_nodes(const struct node *nodes, + int numnodes) +{ + int i, nodes_used = 0; + unsigned long spdx, epdx; + unsigned long bitfield = 0, memtop = 0; + + for ( i = 0; i < numnodes; i++ ) + { + spdx = paddr_to_pdx(nodes[i].start); + epdx = paddr_to_pdx(nodes[i].end - 1) + 1; + if ( spdx >= epdx ) + continue; + bitfield |= spdx; + nodes_used++; + if ( epdx > memtop ) + memtop = epdx; + } + if ( nodes_used <= 1 ) + i = BITS_PER_LONG - 1; + else + i = find_first_bit(&bitfield, sizeof(unsigned long)*8); + memnodemapsize = (memtop >> i) + 1; + return i; +} + +int __init compute_hash_shift(struct node *nodes, int numnodes, + nodeid_t *nodeids) +{ + int shift; + + shift = extract_lsb_from_nodes(nodes, numnodes); + if ( memnodemapsize <= ARRAY_SIZE(_memnodemap) ) + memnodemap = _memnodemap; + else if ( allocate_cachealigned_memnodemap() ) + return -1; + printk(KERN_DEBUG "NUMA: Using %d for the hash shift.\n", shift); + + if ( populate_memnodemap(nodes, numnodes, shift, nodeids) != 1 ) + { + printk(KERN_INFO "Your memory is not aligned you need to " + "rebuild your hypervisor with a bigger NODEMAPSIZE " + "shift=%d\n", shift); + return -1; + } + + return shift; +} + +/* initialize NODE_DATA given nodeid and start/end */ +void __init setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end) +{ + unsigned long start_pfn = paddr_to_pfn(start); + unsigned long end_pfn = paddr_to_pfn(end); + + NODE_DATA(nodeid)->node_start_pfn = start_pfn; + NODE_DATA(nodeid)->node_spanned_pages = end_pfn - start_pfn; + + node_set_online(nodeid); +} + +void __init numa_init_array(void) +{ + int rr, i; + + /* + * There are unfortunately some poorly designed mainboards around + * that only connect memory to a single CPU. This breaks the 1:1 cpu->node + * mapping. To avoid this fill in the mapping for all possible + * CPUs, as the number of CPUs is not known yet. + * We round robin the existing nodes. + */ + rr = first_node(node_online_map); + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] != NUMA_NO_NODE ) + continue; + numa_set_node(i, rr); + rr = cycle_node(rr, node_online_map); + } +} + +#ifdef CONFIG_NUMA_EMU +static int numa_fake __initdata = 0; + +/* Numa emulation */ +static int __init numa_emulation(unsigned long start_pfn, + unsigned long end_pfn) +{ + int i; + struct node nodes[MAX_NUMNODES]; + uint64_t sz = pfn_to_paddr(end_pfn - start_pfn) / numa_fake; + + /* Kludge needed for the hash function */ + if ( hweight64(sz) > 1 ) + { + u64 x = 1; + while ( (x << 1) < sz ) + x <<= 1; + if ( x < sz/2 ) + printk(KERN_ERR "Numa emulation unbalanced. Complain to maintainer\n"); + sz = x; + } + + memset(&nodes,0,sizeof(nodes)); + for ( i = 0; i < numa_fake; i++ ) + { + nodes[i].start = pfn_to_paddr(start_pfn) + i * sz; + if ( i == numa_fake - 1 ) + sz = pfn_to_paddr(end_pfn) - nodes[i].start; + nodes[i].end = nodes[i].start + sz; + printk(KERN_INFO "Faking node %d at %"PRIx64"-%"PRIx64" (%"PRIu64"MB)\n", + i, + nodes[i].start, nodes[i].end, + (nodes[i].end - nodes[i].start) >> 20); + node_set_online(i); + } + memnode_shift = compute_hash_shift(nodes, numa_fake, NULL); + if ( memnode_shift < 0 ) + { + memnode_shift = 0; + printk(KERN_ERR "No NUMA hash function found. Emulation disabled.\n"); + return -1; + } + for_each_online_node ( i ) + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + numa_init_array(); + + return 0; +} +#endif + +void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) +{ + int i; + paddr_t start = pfn_to_paddr(start_pfn); + paddr_t end = pfn_to_paddr(end_pfn); + +#ifdef CONFIG_NUMA_EMU + if ( numa_fake && !numa_emulation(start_pfn, end_pfn) ) + return; +#endif + +#ifdef CONFIG_ACPI_NUMA + if ( numa_status != numa_off && !acpi_scan_nodes(start, end) ) + return; +#endif + + printk(KERN_INFO "%s\n", + numa_status == numa_off ? "NUMA turned off" + : "No NUMA configuration found"); + + printk(KERN_INFO "Faking a node at %"PRIpaddr"-%"PRIpaddr"\n", + start, end); + /* setup dummy node covering all memory */ + memnode_shift = BITS_PER_LONG - 1; + memnodemap = _memnodemap; + /* Dummy node only uses 1 slot in reality */ + memnodemap[0] = 0; + memnodemapsize = 1; + + nodes_clear(node_online_map); + node_set_online(0); + for ( i = 0; i < nr_cpu_ids; i++ ) + numa_set_node(i, 0); + cpumask_copy(&node_to_cpumask[0], cpumask_of(0)); + setup_node_bootmem(0, start, end); +} + +void numa_add_cpu(int cpu) +{ + cpumask_set_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +void numa_set_node(int cpu, nodeid_t node) +{ + cpu_to_node[cpu] = node; +} + +/* [numa=off] */ +static int __init cf_check numa_setup(const char *opt) +{ + if ( !strncmp(opt,"off",3) ) + numa_status = numa_off; + else if ( !strncmp(opt,"on",2) ) + numa_status = numa_on; +#ifdef CONFIG_NUMA_EMU + else if ( !strncmp(opt, "fake=", 5) ) + { + numa_status = numa_on; + numa_fake = simple_strtoul(opt+5,NULL,0); + if ( numa_fake >= MAX_NUMNODES ) + numa_fake = MAX_NUMNODES; + } +#endif +#ifdef CONFIG_ACPI_NUMA + else if ( !strncmp(opt,"noacpi",6) ) + numa_status = numa_no_acpi; +#endif + else + return -EINVAL; + + return 0; +} +custom_param("numa", numa_setup); + +static void cf_check dump_numa(unsigned char key) +{ + s_time_t now = NOW(); + unsigned int i, j, n; + struct domain *d; + struct page_info *page; + unsigned int page_num_node[MAX_NUMNODES]; + const struct vnuma_info *vnuma; + + printk("'%c' pressed -> dumping numa info (now = %"PRI_stime")\n", key, + now); + + for_each_online_node ( i ) + { + paddr_t pa = pfn_to_paddr(node_start_pfn(i) + 1); + + printk("NODE%u start->%lu size->%lu free->%lu\n", + i, node_start_pfn(i), node_spanned_pages(i), + avail_node_heap_pages(i)); + /* sanity check phys_to_nid() */ + if ( phys_to_nid(pa) != i ) + printk("phys_to_nid(%"PRIpaddr") -> %d should be %u\n", + pa, phys_to_nid(pa), i); + } + + j = cpumask_first(&cpu_online_map); + n = 0; + for_each_online_cpu ( i ) + { + if ( i != j + n || cpu_to_node[j] != cpu_to_node[i] ) + { + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + j = i; + n = 1; + } + else + ++n; + } + if ( n > 1 ) + printk("CPU%u...%u -> NODE%d\n", j, j + n - 1, cpu_to_node[j]); + else + printk("CPU%u -> NODE%d\n", j, cpu_to_node[j]); + + rcu_read_lock(&domlist_read_lock); + + printk("Memory location of each domain:\n"); + for_each_domain ( d ) + { + process_pending_softirqs(); + + printk("Domain %u (total: %u):\n", d->domain_id, domain_tot_pages(d)); + + for_each_online_node ( i ) + page_num_node[i] = 0; + + spin_lock(&d->page_alloc_lock); + page_list_for_each(page, &d->page_list) + { + i = phys_to_nid(page_to_maddr(page)); + page_num_node[i]++; + } + spin_unlock(&d->page_alloc_lock); + + for_each_online_node ( i ) + printk(" Node %u: %u\n", i, page_num_node[i]); + + if ( !read_trylock(&d->vnuma_rwlock) ) + continue; + + if ( !d->vnuma ) + { + read_unlock(&d->vnuma_rwlock); + continue; + } + + vnuma = d->vnuma; + printk(" %u vnodes, %u vcpus, guest physical layout:\n", + vnuma->nr_vnodes, d->max_vcpus); + for ( i = 0; i < vnuma->nr_vnodes; i++ ) + { + unsigned int start_cpu = ~0U; + + if ( vnuma->vnode_to_pnode[i] == NUMA_NO_NODE ) + printk(" %3u: pnode ???,", i); + else + printk(" %3u: pnode %3u,", i, vnuma->vnode_to_pnode[i]); + + printk(" vcpus "); + + for ( j = 0; j < d->max_vcpus; j++ ) + { + if ( !(j & 0x3f) ) + process_pending_softirqs(); + + if ( vnuma->vcpu_to_vnode[j] == i ) + { + if ( start_cpu == ~0U ) + { + printk("%d", j); + start_cpu = j; + } + } + else if ( start_cpu != ~0U ) + { + if ( j - 1 != start_cpu ) + printk("-%d ", j - 1); + else + printk(" "); + start_cpu = ~0U; + } + } + + if ( start_cpu != ~0U && start_cpu != j - 1 ) + printk("-%d", j - 1); + + printk("\n"); + + for ( j = 0; j < vnuma->nr_vmemranges; j++ ) + { + if ( vnuma->vmemrange[j].nid == i ) + printk(" %016"PRIx64" - %016"PRIx64"\n", + vnuma->vmemrange[j].start, + vnuma->vmemrange[j].end); + } + } + + read_unlock(&d->vnuma_rwlock); + } + + rcu_read_unlock(&domlist_read_lock); +} + +static int __init cf_check register_numa_trigger(void) +{ + register_keyhandler('u', dump_numa, "dump NUMA info", 1); + return 0; +} +__initcall(register_numa_trigger); diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 7aef1a88dc..db0e524a0e 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -18,4 +18,78 @@ (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) +/* The following content can be used when NUMA feature is enabled */ +#ifdef CONFIG_NUMA + +extern nodeid_t cpu_to_node[NR_CPUS]; +extern cpumask_t node_to_cpumask[]; + +#define cpu_to_node(cpu) (cpu_to_node[cpu]) +#define parent_node(node) (node) +#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) +#define node_to_cpumask(node) (node_to_cpumask[node]) + +struct node { + paddr_t start, end; +}; + +extern int compute_hash_shift(struct node *nodes, int numnodes, + nodeid_t *nodeids); + +#define VIRTUAL_BUG_ON(x) + +/* Enumerations for NUMA status. */ +enum numa_mode { + numa_on = 0, + numa_off, + /* NUMA turns on, but ACPI table is bad or disabled. */ + numa_no_acpi, + /* NUMA turns on, and ACPI table works well. */ + numa_acpi, +}; + +extern void numa_add_cpu(int cpu); +extern void numa_init_array(void); +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); +extern bool numa_enabled_with_firmware(void); +extern enum numa_mode numa_status; + +extern void numa_set_node(int cpu, nodeid_t node); +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); + +static inline void clear_node_cpumask(int cpu) +{ + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); +} + +/* Simple perfect hash to map pdx to node numbers */ +extern int memnode_shift; +extern unsigned long memnodemapsize; +extern u8 *memnodemap; + +struct node_data { + unsigned long node_start_pfn; + unsigned long node_spanned_pages; +}; + +extern struct node_data node_data[]; + +static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) +{ + nodeid_t nid; + VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); + nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; + VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); + return nid; +} + +#define NODE_DATA(nid) (&(node_data[nid])) + +#define node_start_pfn(nid) (NODE_DATA(nid)->node_start_pfn) +#define node_spanned_pages(nid) (NODE_DATA(nid)->node_spanned_pages) +#define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ + NODE_DATA(nid)->node_spanned_pages) + +#endif + #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363473.594052 (Exim 4.92) (envelope-from ) id 1o9pOL-0008Ku-PJ; Fri, 08 Jul 2022 14:55:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363473.594052; Fri, 08 Jul 2022 14:55:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOL-0008Kh-LL; Fri, 08 Jul 2022 14:55:37 +0000 Received: by outflank-mailman (input) for mailman id 363473; Fri, 08 Jul 2022 14:55:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOK-0007Ai-Hf for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:36 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140089.outbound.protection.outlook.com [40.107.14.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0594bba1-fece-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 16:55:35 +0200 (CEST) Received: from AS9PR06CA0759.eurprd06.prod.outlook.com (2603:10a6:20b:484::13) by DB8PR08MB4956.eurprd08.prod.outlook.com (2603:10a6:10:e0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Fri, 8 Jul 2022 14:55:29 +0000 Received: from AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::97) by AS9PR06CA0759.outlook.office365.com (2603:10a6:20b:484::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17 via Frontend Transport; Fri, 8 Jul 2022 14:55:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT015.mail.protection.outlook.com (10.152.16.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:27 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Fri, 08 Jul 2022 14:55:27 +0000 Received: from ad85ffab2f30.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DC83907C-7725-441D-8A51-276B809E94B0.1; Fri, 08 Jul 2022 14:55:21 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ad85ffab2f30.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:21 +0000 Received: from DB6PR0202CA0043.eurprd02.prod.outlook.com (2603:10a6:4:a5::29) by DB8PR08MB4170.eurprd08.prod.outlook.com (2603:10a6:10:a7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:19 +0000 Received: from DBAEUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::2) by DB6PR0202CA0043.outlook.office365.com (2603:10a6:4:a5::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:55:18 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT058.mail.protection.outlook.com (100.127.142.120) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:18 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:11 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0594bba1-fece-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bWeQtnwn7vpeYBK9GVTJ5pfyzM2KNiPqjJXFddUeVTs4QS4MXemfL4gH4ONmuKfP0BVQ38mPUqXl7KwEdncpFef5F9MTGLIEn2rq0LQ99vp5hWCDljzZx+DN+gY61S91hilUu6I8jteYGFO8oPNXoNdW6nH+nnVrgeHg/ez4Xg7JWO2LRox0mcs/xpHURGX/Hvxu3Ygk2I2LRu4qCyzec1ZiTKW0iNYVzXvLGyfgHKzkkco4I+r9AlGPY3nvHbrnV+fx21UzcbB4k/HfoiFVA9TrUe69LOP6QnQAV8m2hNJqGJf5GYkkzNB+LZ4sjstZD2O2DgfDREdL7xP/z1EgkA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9ZTzLCFsbwcnMhhUkqTjENjME/eU+MsQ1SV7aGwsNU=; b=SetGHbioTzqDcKYyNmDgcTJaek88+mTJjjYDMBG/JdpcLDrGPg2XBRIVsXgsjA7eCRve+bfKWuBbRi4o1FoZ5jT9nQk1sVA0uRlEPL203WlpPOtu3GU8uqucxmIlECwHkYxJW62EofqjdLvXTtTUzbTHAdsQj5lU2aeNLM8BP3+vNm7r0lJoW+rmkeO+Kw3lVyFiL8Qr/19wFf/hr064qGejtZ8Wv4PDpl8g7zxVqyXgfEpbl/S0s1wYpRDChKjqj5gUFsSdw5gTtIBZO0DKToG+Kng0ouVijhO1aB1z8EoHwUwEbqPWAo/ovmygvWzb1ilCp4wwhY+lWldVC4YcWw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9ZTzLCFsbwcnMhhUkqTjENjME/eU+MsQ1SV7aGwsNU=; b=64/QokKx4zCtG6mPCpg/5Jmq3QyyEV2ffKC1gJIEIwstes/1RPXmmJiPtznFuW+lhe5FxP/V7pePQOVKtY2iw1YW3OPo/4VSx02A4X9isfojQwa2O+zqglMs29LFP4XD2nxFxUqcr+FXRG36j3o6SRNWkaMaIzkcIcLf3T+blRQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 48b2e135b2c418b6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mC5YUSdxGVt+CAPSNB1J/xpfu4uuMgFdkcIudF1egaAqa3Ti2x+aqu1cwgPq1oAxen6KpiJtxntz7aZPII3o+EAYt0gPVPG/AGAgXDjM3D+Fx40Gk5eUk2TVydVCeJEyahVhEvHAEkj5jvXo1R1ApllvAhC3TrLdrBSXZU4Z33AVYHe1PrpqrWtYnb9y3D9f/R+V/htSVzW01p2jrRr27OoSnUtItMCx/D+8nDek+vZCqlK3Em81nZGStozct28Yq7HghkP9fEmLFAs3C3O8lZB/zRNjnWGndUL+wCQyIslIzowuILi/UAXb57c2EPZ558JJxn0Hz+qxIgArUJVBaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d9ZTzLCFsbwcnMhhUkqTjENjME/eU+MsQ1SV7aGwsNU=; b=kjSzMF7GpcPkwtBF5OLqLwb4TbYyOvLUSjwvV6hzlGvWqvnfkdHlvbysR+g1o3AWESq2Pf6vPBRbsUhwN/KO8ZMNyMawRuYWKEffS4TqS5+wTMK6l52UayEkWBL9yC22w26ZGqUB+KWfyUG413szFTCTl/Z1eWFKxU6B70cMmB9XKMeJg3GR+V409FLqUCiwxNdhmwbYhzbwpCp86xP3ck0vbWDTQqxXfJm174wXmxG9mCPy55tNLM9A810k3VwGSd7C4RI5tiInjq3nwbdx2dT9tvUpLp18wnR6NTpdTmvmK4Ff5SH8/tZnd9EdryVJn9oMjdvebfoBGsY3l61zkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d9ZTzLCFsbwcnMhhUkqTjENjME/eU+MsQ1SV7aGwsNU=; b=64/QokKx4zCtG6mPCpg/5Jmq3QyyEV2ffKC1gJIEIwstes/1RPXmmJiPtznFuW+lhe5FxP/V7pePQOVKtY2iw1YW3OPo/4VSx02A4X9isfojQwa2O+zqglMs29LFP4XD2nxFxUqcr+FXRG36j3o6SRNWkaMaIzkcIcLf3T+blRQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map Date: Fri, 8 Jul 2022 22:54:20 +0800 Message-ID: <20220708145424.1848572-6-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 6870b44f-5bf1-47ad-edf3-08da60f1e566 X-MS-TrafficTypeDiagnostic: DB8PR08MB4170:EE_|AM5EUR03FT015:EE_|DB8PR08MB4956:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0FdLpdkC/lCco0Buzm0eCtYPSfxKTy4mNh95uHebDev/JH057FQqBG1t0cN2kowQ4fcwD0i3eQynY4d8bGOjWgwaWOMJYaYVHVQZM9oD3ciXg+J7OT661ZGGXD7H5NOpMv5y3kV3D/oA7HG4LurcbSqJjLUjafwvV0bj/fsMCntJrZB8T1nq7yIegnax+KF3FpIQyb++jHB/dvotnLyYqxr9SVU3E1zqh7pnlfvHbzLNWn4YUaQBETHJCzEDet/6qbaHWHGudmjaLopnkUzQLxvSW6yokxuNJKKu2hIJMbpGfqNUkicEjiKwojizMaM54GsO8NbiWyw0gcZyQwG3TpO2fmvfJK8il93eYcAqnmEFqllKOj/m1rn8vUXKatyMe0Oz3Qo5Hej5S7lxme3vfotF/gUuVzdJ5vPQnYD7qzZgPYSotZWId4htUYPvO48ap5YSHdfXB4FmsXv63L6/EmdT4kobl02VpkuLYKaZbblaVymHgfPa/b1o/6bsoOBXkstdUfDLEF/M7Oh/B3jlDCrPnoneUI8cSinAIAu+jaYfDLb32bSvCP9TOIx3+v3XCq4xKmd+rcDZBkS5qi6Vo/ix/6g7Dj6CgaYUPbVtNmRL5KKSA8ZO61CBxLqUY/Y0jyEo6cVqWt0IT+9VzSDlNHdbCT7/btYiwj67CJk8geYyc4DaRgbsALvZjMlCRVt1T94qSCp3frSkoKasZ1z1g5guZDPFWXZTHKzYti23/cnikYyWg14CJAZT+fhirbPD3X43gXxXYyGOVboQjku2rApC/kcr37drYBIxjCenl6XqYVY11H1rCYtgIzrffKE4r/vNrCePO4JZP/YeoUGDqQ63WMO10aUDj+s/UvZdFpg= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(396003)(40470700004)(46966006)(36840700001)(356005)(70586007)(54906003)(8676002)(6916009)(478600001)(36860700001)(81166007)(36756003)(86362001)(316002)(47076005)(336012)(2616005)(26005)(426003)(41300700001)(7696005)(4326008)(186003)(1076003)(6666004)(82310400005)(40480700001)(70206006)(83380400001)(44832011)(5660300002)(8936002)(2906002)(82740400003)(40460700003)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4170 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 35509b3b-379b-4cef-b17a-08da60f1e014 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o56Jvfuzhg14kFFTQPv9tnebEy4szIO4OOZUelv4tf/2XBnfAmj/c7a4jWhGA+aLRCGZ7AMZF9XkVBiu28ubhP+zUp6KYKG3LYeBlk4R685WwnOyxsRT90LJSrohmrTPpwq0sj0/bz4yWmpw400xgjPzmfh9KKb4I+jO8dFoT70QJJEz3/RpQVcjqifJaDn1gyg9XFRaa0xxEwx+C+iNZO5JEdg6c6IAAzXWnXBS+7QIhlh81neYpFVYc/7AKkn9VfpfT24pc0rTwJs2psYn9C4NIRMfUrSjivcOByhAVD/mhU598CpadovmnkVArFADEzuhbZbFIfR1Ty+BTPIcdYY6waLWZ1RbhVWdA+UlpurlznYurw9CNuBUKJKf8FR0/emaHzmV630ADvtkI83aFXhWMg+KYTO52aXIqDaOYX/LnPSdIR64FBP6KM6cYxswEB+zLRwI56+ARSgOrCKI9fneUka1gzNkmnVQnrJuKKt2/R2EY0wW0bSRHowJtdAdxWLF+A0+8KinjuKCJ2LD99s66o1JYANPaY7nuFzPGkOl/HoifOVI4oMyfX6Efn9otHUKcq84sA6unDCuY2kwJw3QDV5Bjf/nEQol6W4Qi1zgpmoksvplrXN1ZLxKfzxdrCIlDlDn+1QA3oGkVWFaDrrGSDLBwcORbo3w0gIi8UuxZXGMjVY/oETDDf1UInp/FIIRbR3ZYjrBnsSSKeDlJDL1qR/xX+Oxf1rcbKrMOkeusyOLYN0nNn7ogMtOO4lp87JkRxRy3oN283I3Ebivhn3VDRdIzyEjIYSMzjv68YyB6BCtJErPrK6u86ENe7c8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(46966006)(36840700001)(40470700004)(47076005)(82310400005)(107886003)(2616005)(86362001)(316002)(426003)(1076003)(54906003)(186003)(336012)(6916009)(81166007)(36756003)(36860700001)(70206006)(8676002)(4326008)(70586007)(40460700003)(44832011)(26005)(2906002)(5660300002)(82740400003)(478600001)(8936002)(41300700001)(7696005)(83380400001)(40480700001)(6666004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:27.7834 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6870b44f-5bf1-47ad-edf3-08da60f1e566 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4956 The sanity check performed by the nodes_cover_memory function is also necessary for other architectures that do not yet support NUMA. But now, the code of nodes_cover_memory is tied to the x86 E820. In this case, we introduce arch_get_memory_map to decouple architecture specific memory map from this function. This means, other architectures like Arm can also use it to check its bootmem info. Depending on arch_get_memory_map, we make nodes_cover_memory become architecture independent. We also use neutral words to replace SRAT and E820 in the print message of this function. This will make the message more common. As arch_get_memory_map use unsigned int for index, we also adjust the index in nodes_cover_memory from int to unsigned int. Signed-off-by: Wei Chen --- v1 -> v2: 1. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 2. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. --- xen/arch/x86/numa.c | 23 +++++++++++++++++++++++ xen/arch/x86/srat.c | 18 +++++++++++------- xen/include/xen/numa.h | 3 +++ 3 files changed, 37 insertions(+), 7 deletions(-) diff --git a/xen/arch/x86/numa.c b/xen/arch/x86/numa.c index 193314dbd9..fb235c07ec 100644 --- a/xen/arch/x86/numa.c +++ b/xen/arch/x86/numa.c @@ -9,6 +9,7 @@ #include #include #include +#include #ifndef Dprintk #define Dprintk(x...) @@ -82,3 +83,25 @@ unsigned int __init arch_get_dma_bitsize(void) flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) + PAGE_SHIFT, 32); } + +/* + * This function provides the ability for caller to get one RAM entry + * from architectural memory map by index. + * + * This function will return zero if it can return a proper RAM entry. + * otherwise it will return -ENODEV for out of scope index, or return + * -EINVAL for non-RAM type memory entry. + */ +int __init arch_get_memory_map(unsigned int idx, paddr_t *start, paddr_t *end) +{ + if ( idx >= e820.nr_map ) + return -ENODEV; + + if ( e820.map[idx].type != E820_RAM ) + return -EINVAL; + + *start = e820.map[idx].addr; + *end = e820.map[idx].addr + e820.map[idx].size; + + return 0; +} diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 422e4c73e3..5bc9096a15 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -427,18 +427,22 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) Make sure the PXMs cover all memory. */ static int __init nodes_cover_memory(void) { - int i; + unsigned int i; - for (i = 0; i < e820.nr_map; i++) { + for (i = 0; ; i++) { int j, found; paddr_t start, end; - if (e820.map[i].type != E820_RAM) { + /* Try to loop memory map from index 0 to end. */ + found = arch_get_memory_map(i, &start, &end); + + /* Index relate entry is not RAM, skip it. */ + if (found == -EINVAL) continue; - } - start = e820.map[i].addr; - end = e820.map[i].addr + e820.map[i].size; + /* Reach the end of arch's memory map */ + if (found == -ENODEV) + break; do { found = 0; @@ -457,7 +461,7 @@ static int __init nodes_cover_memory(void) } while (found && start < end); if (start < end) { - printk(KERN_ERR "SRAT: No PXM for e820 range: " + printk(KERN_ERR "NUMA: No node for memory map range: " "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); return 0; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 695ad51df0..6d02204991 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -88,6 +88,9 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) #define node_end_pfn(nid) (NODE_DATA(nid)->node_start_pfn + \ NODE_DATA(nid)->node_spanned_pages) +extern int arch_get_memory_map(unsigned int idx, + paddr_t *start, paddr_t *end); + #endif #endif /* _XEN_NUMA_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363476.594063 (Exim 4.92) (envelope-from ) id 1o9pOP-0000Kq-02; Fri, 08 Jul 2022 14:55:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363476.594063; Fri, 08 Jul 2022 14:55:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOO-0000Kb-T6; Fri, 08 Jul 2022 14:55:40 +0000 Received: by outflank-mailman (input) for mailman id 363476; Fri, 08 Jul 2022 14:55:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pON-0006vD-Rd for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:40 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07899fed-fece-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:55:38 +0200 (CEST) Received: from DB6P192CA0016.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::26) by PA4PR08MB6032.eurprd08.prod.outlook.com (2603:10a6:102:e4::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Fri, 8 Jul 2022 14:55:36 +0000 Received: from DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::2a) by DB6P192CA0016.outlook.office365.com (2603:10a6:4:b8::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT046.mail.protection.outlook.com (100.127.142.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:35 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Fri, 08 Jul 2022 14:55:35 +0000 Received: from e2cefff5c73e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6E361E81-15BB-4980-BDFE-118B4EC5B781.1; Fri, 08 Jul 2022 14:55:29 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2cefff5c73e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:29 +0000 Received: from DB6P192CA0004.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::14) by DB7PR08MB3178.eurprd08.prod.outlook.com (2603:10a6:5:24::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:26 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::ca) by DB6P192CA0004.outlook.office365.com (2603:10a6:4:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:26 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:26 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:21 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07899fed-fece-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dUcjBxDOp0RiKR9LzrELyrmBSuLHdgOD6F0v3ODTD4xJ5TyiMM4oZDlBX0ksaBpwNzlNvF/9X5+MvrbbGxeWlu6g1wd0KPe7LQ/Q6Zl43tDLOD3L7cxbheRaFfHQfwpVGlMTbOSEHg49lDf1lsaQvErnFcogSKustXDZlBtD1RKeTHjz+ovCfFvTDwWZTPCEh7gn4jnsjVD3c0RiGxXr+olQntZdm1u1MNTCEi/9jhLo7Y5Dpx+6gsOeWxLSmAWbT1FyaU0zik2wA3DTR+KT68Y0pyBWHEO0ckHsje7HurXR0xrQfZmteXtCgtkFyvxGaw3E4WdCSPWE+X3mlM13zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQ5GWTIY4MWQGGyhLZ8eQoBIiDbRb+nQhneNRjZRrdA=; b=OMFoz5Tzop2xAvk8ORbRqKpTnwHvZdwrBLkvO2lbAGP7ZfMWoPRxPmjn0/8oPMgyYeNOLMBJfP3C6Bw2QWreuoZj/KZfL2YoBw4fq/qLVi+AuqVlOyN3JwnTP57dpNC1ZSGbnuq/8s2h8pxhEL6TI1KqPhcQcGCC2H5HmnG5L8HK7oTkWjGEP9InwPQc6UIwDImAMhZEeJEWa41m+xGyEv4crfC7QuFAWXmDmzfyQLycdINak+WJhnLD9p/+qiwaVx6okePa4Vpg5POLNKIU/Z6RxVDex4Ii5n9bTnNkfUUFYWzJbdUAVDTt4XlgOrc1f2o2UL8SOrxuNvnBbvIpaA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQ5GWTIY4MWQGGyhLZ8eQoBIiDbRb+nQhneNRjZRrdA=; b=iVdHgS6fU7FqzfL9hNkg4ZhXOhwgj2YvcTQi3xeoG90bN3wZf9zIi+gyC6wXCGZvRh2Cz//wDh2/i1wTfNv00L2nEXD9dNl5kcdjLsdjl5r1iK7Pqx7dR9okajC8C0Ymo33aY8wkGGKTWirCbDBrXFE5J12VBgxvcJX9G46KIrw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 15e1c48a565aa983 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sk+UwK2Hauzhbnx3shfUGBpacF2Qpvqatnk+geWuGsw0EKKsXwmBKDlceu67ezX4cV/NvzffR8r8TS0Kf+G67m5KYHqELXTr+duV+HpiU8Ud0dN+UzimnRiW51Kw2bwdFVonyhzYW75xX9GwS4INSrx/2MZ5UnyT8Wm3PPGFTMU+vhYuO61WiphtdVI/JyV5kXbk9Oi2EwdL30+Dd0dRlaQIv4IP92a/nGfW1FH0FMx1/qBYFh5loso2tmJP4IcbQEUZYlhBy6FlsRY8CJMpvAj64lIa/utSJ2keyP8d3OR9bY0VzuWo2lpK0HNRgWh6chTK1fkPqUVAx2f8VAD9Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UQ5GWTIY4MWQGGyhLZ8eQoBIiDbRb+nQhneNRjZRrdA=; b=PEQXCAxziGNx1u6AHJYJ+6hd8k734QBCCKZ4XadKZyVdsjClSHM3ia7GZcxutFlSMzCwhWsPHoHWhhs6cW6xnZTLwSMjuI+YzxhTrGYfZOfUyLLQQmaeJro6rs9czr6MU9yEjM8G2ROa+v0xjgUtWucs4s9iXsluXkaeWfbXKopEbl9lZkaKcPqvR6HaBfZ/zYr5ecPTabVs29gpKaeSaLxPc7NpCeY3UbGVnnbRd5Zn5mTqreQwTn7hTznYKH47nlugKKX2xYGny/7s/4HzyQrQZyLtQRYLLhCoClbgbehyNmc6hHTQKJ4PFmGo0QzXsEydMNejeMssYoOdNHZgxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQ5GWTIY4MWQGGyhLZ8eQoBIiDbRb+nQhneNRjZRrdA=; b=iVdHgS6fU7FqzfL9hNkg4ZhXOhwgj2YvcTQi3xeoG90bN3wZf9zIi+gyC6wXCGZvRh2Cz//wDh2/i1wTfNv00L2nEXD9dNl5kcdjLsdjl5r1iK7Pqx7dR9okajC8C0Ymo33aY8wkGGKTWirCbDBrXFE5J12VBgxvcJX9G46KIrw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 8/9] xen: rename acpi_scan_nodes to numa_scan_nodes Date: Fri, 8 Jul 2022 22:54:23 +0800 Message-ID: <20220708145424.1848572-9-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 69039600-7f7e-4b18-43bb-08da60f1ea35 X-MS-TrafficTypeDiagnostic: DB7PR08MB3178:EE_|DBAEUR03FT046:EE_|PA4PR08MB6032:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lA38u7ClFGoQyENw8XkQSPsE6AGjpZ1R/97AJp7/SCWYlvcohPAtsgUV9BIuiSzvEN3br38xCmgibvSmdm8QpSJdRJ/wiJ1N4yRGjIa5PFDL2ashpaM1yNIwWTfGJx5Tb3LXjXPvBjrv/tSVYX1xHU6rNUMA2dq8OQZoGD/l8Kk5Jx/a1yDeT/PwCYUSPQMYjgzDGNJcjYt/Ez5SoT9jSYu5Sa4BKXIPEmuEORE952UjdWN/QzhoG27w47DBWIw00KBkdTcrDnEiLqE+zPdLuj6QLtf2yrphGgvw49/+NfxdbqsCLOze/jT1CzxQPKoR2fbTGJbb3cZKeB+fjFCR/NOpUWhTmL9LNXYAxpH+Hk28yZlMqo2pmkBs9ayDdKXTAhhtkGa0yoX2AVqV2HkTesX7IfBRKDsMC66UR5h0hw3pAWywfawDvkLxdsEw1J9ke6/4vaUL38YSy86OHTkIhX9RXZYcOFZRlTG3/BpJI5lCf9pvYSvavOQvm+AZStWzLenS+AtC0WXzvjFyd2dLyuvHbcUXrsDdZbC9KmcYygQ2pWMxK4OuMmlIttvVO/U2DR/ZwwNnfZaEJBD2o6YmzEI1jS8jiZFhTzVidvT8it73EdlfOdQrVmMMpXX31kNZsuXiSKPrHMrA5l2uDCdeG68ZLNOaLUX9dyTGWxCUmiWg/ikKugjHoZFxI7/7iGXxdk1BNwYyyFrYs13ZxT9nEyVjWkZaqQAxqLO1AQ7mXq3/9VvNIk0gw35Ectk5Vc0vrh6PSfbYXmCoMDWPssnTNZOMYgTNH8TeaxiH9s0nU1HIzzjJ5ok22ikhyOY7Jl+xSQErBODocZ3dre+MTiizQcKzoLvtYQboqwgcrX3AfE4= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(39860400002)(136003)(40470700004)(36840700001)(46966006)(1076003)(8936002)(2616005)(478600001)(40480700001)(86362001)(83380400001)(6666004)(26005)(336012)(41300700001)(2906002)(47076005)(40460700003)(426003)(186003)(36756003)(82310400005)(44832011)(5660300002)(356005)(70586007)(4326008)(316002)(82740400003)(70206006)(8676002)(81166007)(54906003)(6916009)(7696005)(36860700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3178 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: af45ea87-b81d-4267-d5a6-08da60f1e4c4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Vt7KHSsxr9ifytSGnW7xWXyQxwgCTecBeyZt2MgShdrcVDHVlrHIhg6dL2enh88VbX59SAjP0cAtuXgLFDNglhclfRVOJNVLP3PyTSQJKFuJ+p8VnvaOGWKyw9UNInyRZxfJr85F1dVwv09d3QhXrz7/yGcy1sD8aHzTxMDlFR+DWR+2YSBGlbRgw9ujdgJu/1KJ4I3LcDfwHtR2whh38KWjZluS9tgBpWjWG/2UYGhY8i0CQfSoEsj0ZFqGYXT2QSuY17hfNWTayZDThgRBs7MfmDSoJe/5LqqzMtt5yJ+SFj3Z4m4CsXm0NIoo8BUl5/JyR4NhwS4TP+36A5T9w6TaBU85zFg2UEdW08CgvuV+l6mpCmVK80giINlFG9FUR9idNj6/E4l4CulMsGxxCm4zIfkC7hNUiJ7ABI9EypWaSSzvZp8x+/UQV2j2GWYMXueWDTdW26vHAMxpKEMYkCYN+AYzcDXBZ/32hxdI320YmV13NQvbfT2F+rStSFFeO7NC8vqU/wHTMPy3Eo12eazOSQU/cuWBhzFxkNW+KsOZYn6OjDcNeVk5Ly9JN1AQad5SgfI5XhHUDEg5/RFdeqIuN9ZxRyaFeWzHxTRV5d4e1aa0TimOzSvN7cvVYjDeVzk51qbkWBcHvUkqjU0hWKXiNHvSy6zqysJsw5DzJ9EiFtJbsOzmZcj0j5CkWrUziLifYluByi58FjdyK2sShwb0ElxGbthcsdRvEliH+9km2EpW2B9+Zr+ve7dJwoennAXuZ0de4VJkcR5f+lX4z9YtNbpZ8vi8CPJxoxtgNSkhwxJw4QrZMWlbJmyNgfO9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(40470700004)(46966006)(36840700001)(83380400001)(1076003)(426003)(86362001)(186003)(36756003)(2616005)(40460700003)(81166007)(47076005)(36860700001)(107886003)(336012)(8676002)(316002)(70586007)(478600001)(82740400003)(8936002)(44832011)(5660300002)(2906002)(54906003)(6916009)(82310400005)(4326008)(26005)(70206006)(41300700001)(7696005)(40480700001)(6666004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:35.8934 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 69039600-7f7e-4b18-43bb-08da60f1ea35 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6032 We have moved acpi_scan_nodes from x86 to common. Because of of our previous work, this function no longer has many ACPI characteristics, except some "SRAT" words in print messages. So we rename acpi_scan_nodes to a more generic name numa_scan_nodes, and replace "SRAT" words in print messages. After doing this, it doesn't make sense to use CONFIG_ACPI_NUMA to gate numa_scan_nodes in numa_initmem_init. As CONFIG_ACPI_NUMA will be selected by CONFIG_NUMA for x86. So, we replace CONFIG_ACPI_NUMA by CONFIG_NUMA. We take this opportunity to make this function static, since it currently has no external callers. Signed-off-by: Wei Chen --- v1 -> v2: 1. Merge two patches into this patch: 1. replace CONFIG_ACPI_NUMA by CONFIG_NUMA. 2. replace "SRAT" texts. 2. Turn numa_scan_nodes to static. --- xen/arch/x86/include/asm/acpi.h | 1 - xen/common/numa.c | 10 +++++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/include/asm/acpi.h b/xen/arch/x86/include/asm/acpi.h index ab0d56dd70..f6ea3f1a9a 100644 --- a/xen/arch/x86/include/asm/acpi.h +++ b/xen/arch/x86/include/asm/acpi.h @@ -101,7 +101,6 @@ extern unsigned long acpi_wakeup_address; #define ARCH_HAS_POWER_INIT 1 -extern int acpi_scan_nodes(u64 start, u64 end); #define NR_NODE_MEMBLKS (MAX_NUMNODES*2) extern struct acpi_sleep_info acpi_sinfo; diff --git a/xen/common/numa.c b/xen/common/numa.c index 5ab061e991..0f62638e4c 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -285,7 +285,7 @@ static int __init nodes_cover_memory(void) } /* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) +static int __init numa_scan_nodes(paddr_t start, paddr_t end) { int i; nodemask_t all_nodes_parsed; @@ -310,7 +310,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) if ( memnode_shift < 0 ) { printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); + "NUMA: No NUMA node hash function found. Contact maintainer\n"); numa_bad(); return -1; } @@ -323,7 +323,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) paddr_t size = nodes[i].end - nodes[i].start; if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); + printk(KERN_INFO "NUMA: node %u has no memory\n", i); setup_node_bootmem(i, nodes[i].start, nodes[i].end); } @@ -540,8 +540,8 @@ void __init numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn) return; #endif -#ifdef CONFIG_ACPI_NUMA - if ( numa_status != numa_off && !acpi_scan_nodes(start, end) ) +#ifdef CONFIG_NUMA + if ( numa_status != numa_off && !numa_scan_nodes(start, end) ) return; #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363477.594074 (Exim 4.92) (envelope-from ) id 1o9pOQ-0000hA-IB; Fri, 08 Jul 2022 14:55:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363477.594074; Fri, 08 Jul 2022 14:55:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOQ-0000fi-Ai; Fri, 08 Jul 2022 14:55:42 +0000 Received: by outflank-mailman (input) for mailman id 363477; Fri, 08 Jul 2022 14:55:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOO-0006vD-S0 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:41 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60049.outbound.protection.outlook.com [40.107.6.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07e0f916-fece-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:55:39 +0200 (CEST) Received: from DB6PR0601CA0012.eurprd06.prod.outlook.com (2603:10a6:4:7b::22) by AM0PR08MB3188.eurprd08.prod.outlook.com (2603:10a6:208:5e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:35 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:7b:cafe::18) by DB6PR0601CA0012.outlook.office365.com (2603:10a6:4:7b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:34 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Fri, 08 Jul 2022 14:55:34 +0000 Received: from 216719b84af4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8E07A32A-26C8-4653-A7AC-948110A42AB5.1; Fri, 08 Jul 2022 14:55:27 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 216719b84af4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:27 +0000 Received: from DB6P192CA0004.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::14) by AM0PR08MB5154.eurprd08.prod.outlook.com (2603:10a6:208:15d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 14:55:25 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::3b) by DB6P192CA0004.outlook.office365.com (2603:10a6:4:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:24 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:24 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:17 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07e0f916-fece-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DBlHUOywwnEnAxlQoRd65sHV4h+H3y3dTIk6cuDic5RgQCTEywUpA1pS0s2TBOld/ayDGgsQ5td6CEdUCYHWmO6caSiYhupcgoQ0ty9X7NvyKMb7sOsWk1OnZzgRmReW08B3cgQ7Vw1m0ZRouzGKMTj0Z4rOXgk28GYDF89EyXf0G4Zkp7x/9XgBE3hVThyg4vJbM7edodHbqIjUufOkrNAtcXge598mED60jCkBBJGLVLE/+dBwGmKPG/hhWP+adyxAxwfJmb628UVeHBb24FiI9USsL2hmIHLfQe0icmvC3gMJUwzcAD0hvwE/NGATao1mLWC/FjanuY0dlLToCw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hk0IhxXN/zYIHE4+iVUsSa2FBDhvvWOeQyK22TgQPPM=; b=gjuRq4aBbaHp/4qK7TSyKWmNQwea3+v4LZTS0/lukFFieNlIR3+CZJUgCzMIwGjEtNut5ZlkGp2Dn1OBQoO1Ecwmw3Dki0g33wmfo7qTx3qO+GCodRhh1z7h/k8/8cdU7ruo5Ym9EONx2hhuzeQiC3ZM8EtjKS0njSA00wKVL/0rkdNcyg1dhCtScvtMOM/UTC853+2bqqWoUoFjaZgsFasOvD+Ab/sc3hu37WJNqngKOiAZj/wgDTQTybG6hHPc96c5IBiY3xnH/AqRpxoxs2d+PjlaJCBFdddc8Jjf2q3/GVD/P6LPGTsCiqmEL8KEZ9nqg7K61KuZEqapzkxWvA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hk0IhxXN/zYIHE4+iVUsSa2FBDhvvWOeQyK22TgQPPM=; b=c86/JCq5BUh3HV5c59njQldpPEfVt2DOSe2hivj/Pb8zV4G91I3gXLrFglKW2iZKkZcWQRoplm6ShmpfCw1pyLKPghGpMm4pnxsQoC/iqxUl6yovuIVcRGq3HVSWAvYX7YIjnGwmprHuL+4VhAnM/17uOPSfftoM8HzvsjZE0Ik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1717f0940105f789 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bf8S3uppi2CODx1C2ONxHHSSp6FB5FBOJ15YJeDP5pyOA4DhFFFJtOyHDOwZm0GMdcQVMtdPQBR7LtwJUNY11sQ5e+amv+8I0ADqcasEf1Wz0/fCDngFDCdg+qT82ejCFEC01lg/ZiGN17aXqoPEz/rOBCPhxCFDwvLLRSyYWJVWLIGqgs9k6qIq/cMZZEFlwTzMWFsJELVW3uEuPUM+4POMiQMPn9EnfyDRW4VhjMogTsAhLMJRGjf+wiDg6rn1m1Zzd6O9Z9B+szHZJsfEwNYZXC5W8sxHLPaYuP4e7+qt6o2NhU9BELykQhYmoXBFkMjhDICd/QLlRyhAUeC/0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hk0IhxXN/zYIHE4+iVUsSa2FBDhvvWOeQyK22TgQPPM=; b=KCsp2QiU8FpTvkNq03chMe9LEmBzRPh4MgrFpjItHenpzgdK5hRP+LivJlagZ3M6iSaK3eGXmCpVWhrDSuSAylYRbLGoeGJcA17viOzqRDHDIPDWuFCawkYR6fIXhctDBJf/EYjFdeoDcSxjgH3pYmaD1eNS+CK76UAZZlpo30NEr7N4XIW2VHSkSRAKFByYkcjEeAUvKfqKt1saNPqYKmLSumYFcCOmhLbBmzsvC7bYt1jA3z/DB8Cxmq/PteWrBTjbCsxzWU9nLwHZP8dkc7vTusXoLnfbixycso1Figjl4F3TwZCNyvj/wbJ6zjsKkON0la9DI48RF6BURVr2Gg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hk0IhxXN/zYIHE4+iVUsSa2FBDhvvWOeQyK22TgQPPM=; b=c86/JCq5BUh3HV5c59njQldpPEfVt2DOSe2hivj/Pb8zV4G91I3gXLrFglKW2iZKkZcWQRoplm6ShmpfCw1pyLKPghGpMm4pnxsQoC/iqxUl6yovuIVcRGq3HVSWAvYX7YIjnGwmprHuL+4VhAnM/17uOPSfftoM8HzvsjZE0Ik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad Date: Fri, 8 Jul 2022 22:54:22 +0800 Message-ID: <20220708145424.1848572-8-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: b50017ba-3fef-49bb-4551-08da60f1e990 X-MS-TrafficTypeDiagnostic: AM0PR08MB5154:EE_|DBAEUR03FT045:EE_|AM0PR08MB3188:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LZiQA2NVb4dV6MKzZb22EPUEJSYe/N7aHI9PcAeFBAak9k4pzb1IRRJBqVKXMByjG8XZNHhHqAtYN26aXR7MSaGQiMdNNbu1OpVkMzuaoSYbRklxSJt0uRXC0IraB5muTRlzdr8f/AK//Rv6dVHkhWL5FnxOgVbEdjV4E0hAQJCeanSGRxzqw+CCCKYwr9nADkb2mh6f/d46NK9mKyjRUCEHxvTPec2qkhimqyG3GebSKZVmq+Iv6n4V86/W9UkT74VPH8J1XdK6tXAYljh8xeX6P31rdoUcLhTxc9A8GNVIYmRASA966QkwAUaegJdbf3p+xokLwvH3IN8GBubjm6NmhoF3lKsSM05ZHB24K+JAMXtN6VjWYuB5Ox0lorTHW5UBfBbP8u99TCXcDhhh1852d6hEm5w9++fDhBfnafB8EU9gZiZ21a6OXvwHDLrnKcfdy8bSiGdkjnpXJ+z0VcBI+XoH3iIebyGcOteu/xwgOvho+bSKd8zqC4Q0nhn8qszMNO0Wp7lmhGUsq2lpXBy690TZDPeL0669cTr+eMl0W1VQsJQJR/WM+J5WQGsEHiO9VYdecEulI+/yviEM4KMloEHmWcaBFw9diLUiFUQDYHhJgculG/UmcooFT90j52WmDMHLPr6Cb0R6lbH4gs3qoAV+rwkffxvKQOIvjzJglh6OMhNQlRB2Vf7Yh4Wl9JZM4j0y+zgJEJzzlE4FjrrL67tB2ejM0taC4NydBL1FxKNMoh2+sDFDRNmohotwHidor3hv9+/ID0S/qZBuip1+x2RwiUrFqtUeW9WJnsJ0/TNeDXTdnvtAqKFBS4T0bdr4/LWXjSi28iIGAJ07h+fWBQtiJKk45WqhjFoesFY= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(40470700004)(36840700001)(46966006)(82740400003)(426003)(7696005)(47076005)(86362001)(44832011)(40480700001)(336012)(82310400005)(6666004)(41300700001)(356005)(4326008)(2906002)(1076003)(2616005)(186003)(26005)(70586007)(70206006)(83380400001)(8676002)(6916009)(36756003)(40460700003)(8936002)(36860700001)(81166007)(478600001)(54906003)(316002)(5660300002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5154 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8b691d5c-4ac1-498f-234c-08da60f1e3a9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EsZtFZanV3m/BYHgKsWNMoXVQj6y5Gm5MuJX66rcY6jZLz0pOY5jEM+iAEMvNHiGtU72zaezKXjAIfAvYwBS1nBMvurh5YyTZeHG/n4pn/SBMTLQNQ7WQdLZqgSFzpmsM6PIa2LPdiTGNlUsU9cB7nygiXuIkXLghWmsA74f1mFrqK7W3L/Ahe5HJS4bakFZqGLrR6ek3ZUUfr9Xeh+NTEQi7mv3aLbHH/DFhQ+i77zPm87+iW1B145GPOK0zfX90eq2XU803rCfGso2AI1Sdr5KCjw7wEBa1sYUA2ZAuvqmtz/KV4xiGt+9oSiQvpGsA2Bu3jDr8hlAtaqJbn3gyhXUEYnuwcM10iD2KV7IlRll7zC2TQXV9F0DlQNeUarRRD/TjsrtIND6jJ9hlyUDl6zmB1csGqEzQ7xifnJbCHqV5Kj65lv1E5ckErzdyD+3RWp4MeJesz3o1rX83kn9SkQF9kpqd4MF/1O+Yu20nwSM7wqTolf4FpRVUBMXN9uzhmVbO5szKgfqzKsJpMnGfXIqHEYZsC+BRH4gjckkCo5tTkxFXAdeEqVJ7mhXbwXdodypz3G9WztNiAL9osYhqLqJHK3S02o8ecelsRgqXrsJ2hCebyxmg8RCwfIJoSmr7tiMxYd7g7mHoxtU26vhmtC0PbJze6ZGlCWSmKaIc72oZMCZECOZsF6inab8XwXsDAM0lG9ZuV6r8MeX9Dmi5Fvb9lD47mBKtZs75ffEqVN4zQQ0E1rmmJssg6Q5+YkzkS9Jvh71tfTVgv+mWTpJAIJck0DbVIctbVU3HYV0H8zIDVJ6RRrtVf7bVhU3MoSs X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(376002)(346002)(46966006)(36840700001)(40470700004)(47076005)(82310400005)(83380400001)(40460700003)(41300700001)(81166007)(54906003)(36860700001)(6666004)(36756003)(426003)(44832011)(40480700001)(2906002)(6916009)(336012)(70206006)(1076003)(107886003)(5660300002)(8936002)(70586007)(316002)(4326008)(26005)(8676002)(186003)(82740400003)(7696005)(2616005)(86362001)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:34.8277 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b50017ba-3fef-49bb-4551-08da60f1e990 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3188 When NUMA initialization code is failed in scanning SRAT. It will call bad_srat to set disable NUMA and clear relate data. But this name is ACPI specific, we have moved generically usable NUMA codes to common, bad_srat has came with these codes to common code. But it's not reasonable for other NUMA implementations to implement a fall back function named bad_srat. So in this patch, we rename bad_srat to numa_bad. Signed-off-by: Wei Chen --- v1 -> v2: 1. New in v2. --- xen/arch/x86/srat.c | 18 +++++++++--------- xen/common/numa.c | 4 ++-- xen/include/xen/numa.h | 2 +- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 9ae81afdff..4afb37bf9f 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -93,7 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -void __init bad_srat(void) +void __init numa_bad(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -153,7 +153,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) if (srat_disabled()) return; if (pa->header.length < sizeof(struct acpi_srat_x2apic_cpu_affinity)) { - bad_srat(); + numa_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -166,7 +166,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) pxm = pa->proximity_domain; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_bad(); return; } @@ -189,7 +189,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) if (srat_disabled()) return; if (pa->header.length != sizeof(struct acpi_srat_cpu_affinity)) { - bad_srat(); + numa_bad(); return; } if (!(pa->flags & ACPI_SRAT_CPU_ENABLED)) @@ -202,7 +202,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) } node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_bad(); return; } apicid_to_node[pa->apic_id] = node; @@ -225,7 +225,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) if (srat_disabled()) return; if (ma->header.length != sizeof(struct acpi_srat_mem_affinity)) { - bad_srat(); + numa_bad(); return; } if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) @@ -239,7 +239,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); - bad_srat(); + numa_bad(); return; } @@ -248,14 +248,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) pxm &= 0xff; node = setup_node(pxm); if (node == NUMA_NO_NODE) { - bad_srat(); + numa_bad(); return; } ret = numa_update_node_memblks(node, pxm, ma->base_address, ma->length, ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE); if (ret) - bad_srat(); + numa_bad(); } void __init acpi_numa_arch_fixup(void) {} diff --git a/xen/common/numa.c b/xen/common/numa.c index e3b66c54b5..5ab061e991 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -300,7 +300,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) if ( !nodes_cover_memory() ) { - bad_srat(); + numa_bad(); return -1; } @@ -311,7 +311,7 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) { printk(KERN_ERR "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); + numa_bad(); return -1; } diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 564add430c..4c4632ec27 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -52,7 +52,7 @@ extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); extern bool numa_enabled_with_firmware(void); extern enum numa_mode numa_status; -extern void bad_srat(void); +extern void numa_bad(void); extern void numa_set_node(int cpu, nodeid_t node); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363478.594085 (Exim 4.92) (envelope-from ) id 1o9pOR-0000yu-R3; Fri, 08 Jul 2022 14:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363478.594085; Fri, 08 Jul 2022 14:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOR-0000yO-Mz; Fri, 08 Jul 2022 14:55:43 +0000 Received: by outflank-mailman (input) for mailman id 363478; Fri, 08 Jul 2022 14:55:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOP-0006vD-Rl for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:42 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2077.outbound.protection.outlook.com [40.107.22.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0889c9d2-fece-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:55:40 +0200 (CEST) Received: from AS9PR06CA0729.eurprd06.prod.outlook.com (2603:10a6:20b:487::24) by AM6PR08MB5254.eurprd08.prod.outlook.com (2603:10a6:20b:d6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:37 +0000 Received: from AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::eb) by AS9PR06CA0729.outlook.office365.com (2603:10a6:20b:487::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT024.mail.protection.outlook.com (10.152.16.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 14:55:36 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Fri, 08 Jul 2022 14:55:35 +0000 Received: from 7752c8b1a1f5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 21BF7C73-F39F-40A6-B26C-B6A8A57BAA62.1; Fri, 08 Jul 2022 14:55:29 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7752c8b1a1f5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:29 +0000 Received: from DB6P192CA0005.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::15) by AM6PR08MB5046.eurprd08.prod.outlook.com (2603:10a6:20b:eb::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Fri, 8 Jul 2022 14:55:27 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::bc) by DB6P192CA0005.outlook.office365.com (2603:10a6:4:b8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:27 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:27 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:24 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0889c9d2-fece-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IDTGzsRhwksJULtKqTjY6DjwNdhsnNqurtg+okPYa72msuUM/toiN8f1PRWhNI6gNxthYwrCMTzl3T07UM6Pc/LA1RAA/2gsG0a3GZ9lDSAGzc2DTCmvU9SriTtTevWI5qYnQbqpRDjGR8jjjR880icLtm7IEvWn4QjnRugTZ3P7FwmHAEaFtT0sNrgnLcMkZ/xW3E63bZckMblrldi+14UGAHUQu+DFXXLSrhd4EFt16ME5PDHBjogsYSiYsEeiQvO+5i8CgAphLkFDXji17NG8DXwYtnm8TWPfOefUiqWOlhmbeCeRW2KwD7t0Bpjnk/WHcWXDIfgVqjV7GXYS1A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AqQSRNHq+Kh5K+Y/RMMNLbWNCA9xm34CxBmK5iY5sjc=; b=AfaHEjqEQ9V9viRakj2R4cKeA8zdehS1FtQEn74mzNDOLg+etnr0imuka4C2Z+bJzwbFpu/xXcoHo0bsvBexfGbbIWL5K89XvPqAgq+mB16IgP/z00hvyQzsKg2c05jLrwCXzId91AfG8+eJXTAsdk0ecdOMGC/LijDAx/i/uaz2g4/+A96cB/JUAb+lfUw0boJuqeN0cztx0Rv22RbR6CQI7TSneykEsICGY50lkqUYVspSArBbr2/A1AzYOkxWHwg+nuRMOGHK+XQx+M7LhBIK7kSn55TOIRkFsatjCRbB35F9u5HDSnpAKbBzIQ5Q5K0//dkdOwzsh+96MaODsg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AqQSRNHq+Kh5K+Y/RMMNLbWNCA9xm34CxBmK5iY5sjc=; b=Yc4jdjb/IM4tHSoDvl2tvsQZ7aRMwSB+6yNDdg02G/WFQYh6JMByaDhv3yv0fmiTwugRRwSKpEDbh06FMU7B1oGPEWp4gncrMVKDJ0RJqcUnpXAI8JfiG5Ivgu5k62DBrFcjECybBvFEXFcnBE9cgjTf4yaXLvezTRBgZI8Otdg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7288404d879e14c7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0JifeM/ZTVeOzaJd/rqJsYwn7ymazYlwX1IaRiHCQZXmTREvwpoWlPhp2oQQKngo1fHoKq18vZ2vpU+V2fVKU3xRuJX/b3IEO2yWzMnbwjdryuK6B1lWN789tLoLgcVcUZ9zA5AdtcP6sl5zj/5fbLzxNL9Zz9lS4klmqze8+OuOtScvHCSUgUazB/E239fjfwm+ZBttHKxPCUTB3oq+TYJvnnuE/Lil+bXJ8yRma+K3Q6btGEXM4YwxorcZfOPYXGvvaxiRG00vC/TrCpM/88qlIn1CDO9E0VCHmBlj4SnPQ6peu1d/m6JIO1VCmnbUH4x114o2UI9TYjERyNVvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AqQSRNHq+Kh5K+Y/RMMNLbWNCA9xm34CxBmK5iY5sjc=; b=Oey9p/ceIM+USjzcXwqHSC5QLXDOfn9XWku/cYDr4gJ4LkNRyFdV35/KbxI5b0CHQ6rbWBZc3JGdOjObKi2JOUqP2cDdHUjx9oi4CDwrKFBEVu62q47AfasenhqGu6I2PS1b26c2sQk9+EULuakylHOxK7msRNg16W7Sv3otSOyY5lXY2pdTJNBfHRaYkbja2hkabvGbLQyLG/Nmlc6O9UJXUovl8QsgzWRRf9M8NYnCskOj1oNTLdoIVCQe2mGfUOCOhPPuk28nJH9QscLNBo3vDQFHZ5iVYb4FUuURRTs/t+UlBQrFpRvplAClsSreOSENbqb7UXESUAOGu9CdhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AqQSRNHq+Kh5K+Y/RMMNLbWNCA9xm34CxBmK5iY5sjc=; b=Yc4jdjb/IM4tHSoDvl2tvsQZ7aRMwSB+6yNDdg02G/WFQYh6JMByaDhv3yv0fmiTwugRRwSKpEDbh06FMU7B1oGPEWp4gncrMVKDJ0RJqcUnpXAI8JfiG5Ivgu5k62DBrFcjECybBvFEXFcnBE9cgjTf4yaXLvezTRBgZI8Otdg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Date: Fri, 8 Jul 2022 22:54:24 +0800 Message-ID: <20220708145424.1848572-10-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 34c1eade-cf35-4824-f0db-08da60f1ea50 X-MS-TrafficTypeDiagnostic: AM6PR08MB5046:EE_|AM5EUR03FT024:EE_|AM6PR08MB5254:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3Fd/XZcz0ZlvEEnQuXvVOhYKfLZCJSXaErlE9aLZxtzt/Xeg6NI5VLQ/iB9kv/13ceusoWyVWb3nJxYod3NMcmij2fFxGnPCsgQ/2U3VQqWaeKVu+qWseuaD76yyce/WqTyTynjKb9kLS8nt3pqE6HykCb+YxDvu0EHVGUeb/2wdNMZQKEGJjvOeER1KgqOI9XeV7QLpG5IntslBpRMNW/AbmVaf6Z+OKJlpFYjPOPUuOLymC0T4GAs0GJoOizS8x/FQ6Y3D7rZfib8mQQeVVQpaxsa3l4pJ1X5rU8mSsfaXMGTZC2zz2fPYX44K0JnKSqIs4nJ3z3uiGWuVEcSOZS/5u1xrjn3jcioThO1eGQJz4vmFp9196adB+ahQj/fVJ4/p5HFu9awacXRa2n3/SYvekzAyqwVSqCr+NNjb5WoaAWE/WcSpJmYHw+l/+N0QluHR/4g+/Bx0mpOp73dbTE+WZDVH9Tunm4KRBMQthHilTm/x03LjKC6e717yKLCsY3h/UivZFGf1PoYJzdPTYZBpXylivg3w44m+Vb7wGs5a+ISyx/KQjuFAOcnp1w6MAiMksmAIgpbfcDwyQInQxf+3//XQxfiRY6GRFCKKHZX/ZVQdKl7FNHhI1O+yKsckE6ZL/xY/xnfUUg0U+l6+W2K7vtP3alG/LlHxAgrHhWDoMbAGALAJPCE2aIhByve8puKvEObz9WmgUOnvJSgi2CcMtCayWNuyeghfUinxphAupqaXhjGh/a5Z+uneQKj28DnfbRuirFtr+wjVTdK9g+aj92XI2UKs0aIyQDEFY/8rkcD6ayeEAd8/nji/OckJKQlw7+Y+9AiVfpjBcgi6maLzX054H/iRw46vsqZ3CiE= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(346002)(376002)(36840700001)(46966006)(40470700004)(4326008)(316002)(82310400005)(40460700003)(2616005)(7696005)(186003)(54906003)(41300700001)(426003)(81166007)(36756003)(26005)(83380400001)(6916009)(336012)(356005)(47076005)(82740400003)(8936002)(8676002)(1076003)(2906002)(40480700001)(5660300002)(86362001)(70586007)(36860700001)(44832011)(478600001)(70206006)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5046 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3780fdb9-8ead-4cc7-2fe2-08da60f1e543 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1xzEf1u4GSKjmXRMhzNXl8P3FhPn7fOaqzSWV0tYk1P12sfM2YG3zN3nk4zRM0CpeQOfmWBIHjwdi/GlVUvDB8R843ChXluT7aXKObN3sdjogQ9vk2cGwEZr+XUCzg+C31DLhzdPpwgDJSm35lc8AKNTnKQFpc8bb8eMvpCOaV3gpYoRXrgBQLMzx2Lp+DBVIowftpRPD3drBT6mc9cxJ8GQwyHThRgsUOes2vRQWE6a1kO6NkBTJZ/qYsdt5S16/LGN3EUk1mAGI0l+OAUiOODnoO4fNsoqy9S/eazA5OQIvzPOiAVfRpcwOPx2Wo3J7tiqXqJoUuGLOBFfzSNyoDR2Zydc7dhrUA6UP7GhiMnhnVSgTd61faN9s238y/iay/jXEhCTgXq4vcKkc/RnwivfWtOirtCJgpDM651C4zD3+1dX/W+LEdc4GWYTshDYEBla8kRfq77b397s0HJ8UYVieG3LpZPxKrLCY10KrOVaWPrA54jH2worZ1E0iux4ayzIsDP10RTr9Ks4GStrgrh2yrP6thqCFE8geb7qVMm5kEXwhyvnJGv5WYbM+qrVrFFYYXVmxSlbpEzhY9MbfMiuTtFUKhtNAoIDPLIPXF4crew47bYYcIUYHahKyHB7FidrYRkPTr3McjlYQMgpgtMdRFCLnexDD66nQ6z4wgP2bsWx+ybOcMmg8/bGhQeiU41I+PrbRomCSvi/jNsKF475B66Ql64QYCag+GGXFGHuQjhCY0yIsVzL5W1iZKbCdcEe0a8SHLwDekSEfscmBwOIS9oiuRcHjrIhU+6lfRKKgs1xyiEA03kjXCEY8rUr X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(376002)(36840700001)(40470700004)(46966006)(36756003)(4326008)(2906002)(478600001)(8676002)(336012)(70586007)(82740400003)(40480700001)(54906003)(40460700003)(70206006)(82310400005)(107886003)(81166007)(47076005)(186003)(5660300002)(1076003)(2616005)(44832011)(41300700001)(6916009)(316002)(36860700001)(7696005)(83380400001)(86362001)(26005)(8936002)(426003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:36.0435 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34c1eade-cf35-4824-f0db-08da60f1ea50 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT024.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5254 Current NUMA nodes number is a hardcode configuration. This configuration is difficult for an administrator to change unless changing the code. So in this patch, we introduce this new Kconfig option for administrators to change NUMA nodes number conveniently. Also considering that not all architectures support NUMA, this Kconfig option only can be visible on NUMA enabled architectures. Non-NUMA supported architectures can still use 1 as MAX_NUMNODES. As NODES_SHIFT is currently unused, we're taking this opportunity to remove it. Signed-off-by: Wei Chen --- v1 -> v2: 1. Add NODES_SHIFT remove message in commit log 2. Change NR_NUMA_NODES upper bound from 4095 to 255. --- xen/arch/Kconfig | 11 +++++++++++ xen/arch/x86/include/asm/numa.h | 2 -- xen/include/xen/numa.h | 10 +++++----- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig index f16eb0df43..4fc16f83ac 100644 --- a/xen/arch/Kconfig +++ b/xen/arch/Kconfig @@ -17,3 +17,14 @@ config NR_CPUS For CPU cores which support Simultaneous Multi-Threading or similar technologies, this the number of logical threads which Xen will support. + +config NR_NUMA_NODES + int "Maximum number of NUMA nodes supported" + range 1 255 + default "64" + depends on NUMA + help + Controls the build-time size of various arrays and bitmaps + associated with multiple-nodes management. It is the upper bound of + the number of NUMA nodes that the scheduler, memory allocation and + other NUMA-aware components can handle. diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index eeb431cdb7..db76281c08 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -3,8 +3,6 @@ #include -#define NODES_SHIFT 6 - typedef u8 nodeid_t; extern int srat_rev; diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 4c4632ec27..cac92d2688 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -3,14 +3,14 @@ #include -#ifndef NODES_SHIFT -#define NODES_SHIFT 0 -#endif - #define NUMA_NO_NODE 0xFF #define NUMA_NO_DISTANCE 0xFF -#define MAX_NUMNODES (1 << NODES_SHIFT) +#ifdef CONFIG_NR_NUMA_NODES +#define MAX_NUMNODES CONFIG_NR_NUMA_NODES +#else +#define MAX_NUMNODES 1 +#endif #define vcpu_to_node(v) (cpu_to_node((v)->processor)) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:55:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:55:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363482.594096 (Exim 4.92) (envelope-from ) id 1o9pOX-0001Yf-DI; Fri, 08 Jul 2022 14:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363482.594096; Fri, 08 Jul 2022 14:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOX-0001YP-A1; Fri, 08 Jul 2022 14:55:49 +0000 Received: by outflank-mailman (input) for mailman id 363482; Fri, 08 Jul 2022 14:55:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pOV-0007Ai-BG for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:55:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b8db247-fece-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 16:55:45 +0200 (CEST) Received: from AS9PR06CA0351.eurprd06.prod.outlook.com (2603:10a6:20b:466::17) by HE1PR0801MB1785.eurprd08.prod.outlook.com (2603:10a6:3:81::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 8 Jul 2022 14:55:34 +0000 Received: from AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:466:cafe::42) by AS9PR06CA0351.outlook.office365.com (2603:10a6:20b:466::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT004.mail.protection.outlook.com (10.152.16.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:33 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Fri, 08 Jul 2022 14:55:33 +0000 Received: from 561225665f87.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 54305FD9-A266-49F2-A9C8-21E68CE62572.1; Fri, 08 Jul 2022 14:55:26 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 561225665f87.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:55:26 +0000 Received: from DB6P192CA0010.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::20) by AM6PR08MB5096.eurprd08.prod.outlook.com (2603:10a6:20b:ee::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 14:55:23 +0000 Received: from DBAEUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::12) by DB6P192CA0010.outlook.office365.com (2603:10a6:4:b8::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:23 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT024.mail.protection.outlook.com (100.127.142.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:55:22 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:55:14 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b8db247-fece-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nVNsbL1FSLwPNF9QeRA22t26kaw/nWGND0g4sNK9/4wR6D5pNDV2vt2cnKyoYweOanoHld04OFoCr8ncY5t1AvBj/ukmkg50RibvUv2ihJ+D7uDvsGTmPXlX0rMejj4EdKXk63a0zEEOumoSutZKDofyT8q/bZCwecVQOd5O7JNYKw+z0UPmgkVCnNuElWN8bPh7uO6Zlk/DFGsICtOUG5kKmOW7tN2eEIU2tokJC4Kh9caY2pv2ynNc9rnoEUCAAGTrQAjJj6PxzEKGFk/SV+SRMK64x1Y1HO6MTezwV/23KuQ0MKSih1+PWG6r9BQOm3j91+Owwoj5AzrwVJ978w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uJcku4B3Sy8ii3n55n/z+fUNLo1qJfxiNfc00q729Dw=; b=l3r4HAsnK/PBLTht73V8h7d6IoFIYIKJ+hHdqrTYIXZ+6AnYOZryzZVyqeztEcitiVKsLHX9BBhEd/nrO2BuAMu3wfNm97vxDZj4JcUZuE98XaYoCA6FyV9mHziIFwrXNofwgpl/hYYOjpLGIPURP7AaFpGqoUPRVPR/pWCMyoIn7uDJAnUdkdaw0rFeGk+2gmo87PJd+AZDJ4I4LTiC4jOV9gUs7hHCBHT5dhuejKainkQhzk22WNRyvkEzusUmwMwj9LxmWPkIb4MhKI+nJ+kUskPbopb7KVVKjRStpB/A+AE61Xlut0/zDYNt6/wJPaNB6we7cQGmDUjkXfzpuA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJcku4B3Sy8ii3n55n/z+fUNLo1qJfxiNfc00q729Dw=; b=Hb6SQmaVh++q7O/4Eelh2dLWPZV+gfha2bkBYSY9g8WOK5Oo+WjIixyjGTgvr2CAvyFU8OFef3MrRQHG48MDxH5ldZkzl+tkuiANFBcdYJbWx/4TvGUQRCoynP8vJsUDoxlkYz1CvEBcUhKYXbbK10LNNjL69mVLZ7wobJlrNI0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 0d1a122662ef9862 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bc9Pkx3O0+GJjsdOW+pEqPl8Godm0dhrZK77vovOeG5Mtt2FQY5bQJeinEitlTqhpQoVGIv4eDKmnK0T0jgjl3Gt6zF/z8J/S67euF4v1jiBHgfIwiQbHQN6Aeo0p/wH34KMDOGM8NwHt0TAIr8y/dWVxu5yicfU/voTpyhBltIJ9xRrLdu/DbsCYBVws0kxtxg18tXI3+pLhc/86a4fidcdpeadPSTA0HU1V+I+6IgPQoKtaqz5Dmzw7+B2lYCnicbDkAP1TAEsR2Jp3LTDtN21YTR+oXB3d03th5KrFEYWztMVQ2fA4m4BBGy0UBKVrOf1p72N35nWYKlegj2DBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uJcku4B3Sy8ii3n55n/z+fUNLo1qJfxiNfc00q729Dw=; b=PGsB/YYMa/6bDgVLIUQfxjE4cIW+ERafdSyopYyX0Ga2+h5datoqhntYC046wJI54Z2wVcZBGHhd3iC0gE0dcpvIhjIFmz/IF0x/2Gt3YCJjK1+k966NLeeD/c9fPqlJysrvizf0qpNbWDEv1JLvJwWhi5sapvYhaDI2VGFBgvN9zqBy9clvTm5/Pw2bQcZ8otKwdWQIdp50t52smSFlLVmQUfoqN4dbYHHHDazVEnz41ZlMk+9+i+lvHeTRiwubqh9YndXB8A+ipgHxJ2H6+MeTmNDBm3/pxk0e78AGlBOMOTbtf4jVzC4yAPkrhaAk8aNX7BY7bC2NgsgyhCGOcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJcku4B3Sy8ii3n55n/z+fUNLo1qJfxiNfc00q729Dw=; b=Hb6SQmaVh++q7O/4Eelh2dLWPZV+gfha2bkBYSY9g8WOK5Oo+WjIixyjGTgvr2CAvyFU8OFef3MrRQHG48MDxH5ldZkzl+tkuiANFBcdYJbWx/4TvGUQRCoynP8vJsUDoxlkYz1CvEBcUhKYXbbK10LNNjL69mVLZ7wobJlrNI0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 to common Date: Fri, 8 Jul 2022 22:54:21 +0800 Message-ID: <20220708145424.1848572-7-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220708145424.1848572-1-wei.chen@arm.com> References: <20220708145424.1848572-1-wei.chen@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 754677fb-9a43-4b30-5624-08da60f1e8f2 X-MS-TrafficTypeDiagnostic: AM6PR08MB5096:EE_|AM5EUR03FT004:EE_|HE1PR0801MB1785:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6MrmC9oHO4NMqJXm0J1L06Ap6h8koLIkYn2AGzhbgJsGY09awhOvCMvsGU0MQdokll97Mux+hXwKi+QkX6UxuB5i7uc+3IDRV7Qequd+o/zRCjH6PgPNJKh7VVw7m5Zg71FRJeEGlawK31+C0P9LEBptydsjbCO6rtgvf5ssdZVEwHdHfIQ5Qm5lu7ilXnf41l+tHSU3q1dt3x3Og9/cBq7iIZ061y2szMluB8Iy+EFsWMUYeAVQlR0fWde+zkriZNBbMwhsyNdjSqjXvtiP1lsvpoXmW5T6SfRPlPWGCtJdzkyyymTSb/Zrj1Y7iRkN3GdhptO71ky/nZq77NAvgRm86c2rCYn8LLTSpG5xbAb1dGzOmKfB3hrRUi5c2HWExT6axzyO2JvuV5rmd5mRGL/og6M24Qz/sD3xxHfiG8vmorPysF+7LTWliCcW7cp8C0tcdmrnKhrZ/uwa97sU8DGpsOc4wcRdqZvooBNfquSa3WRuhIAMhM0kgC22JjWNM+N+2FOn3TxFpQ7RkmWzbUO2oIMnQozapd1voWKzlhOy9YsWS+SfQP664JMJH9R9SEOqsK6UrEWE7M2JaUwa6AMs/aT8of4xpRDKlkgJOQAUUxjyRV0YtBMeiXmezwA3tRoyeDCptYG9vZG5Cl+2ifY4ZwFpZrdMC78Nv1b5OWlCDkFGjoQbzgk7o//vFySZubgqMPeOm0AR76/T/9/uS1sek/bheei63OHsrgl/VheBF5+UfudteVzijFWkIkbDuNAMXHpz4qQAVsWsOQyPAK6KFMiZ8ompwYdK/+qSTWxy4nbvElKI9ECr0cFDK/15cTME9vW5OPKmV/R12Jc/fezE1QzAsSangR7c5f+OO7M= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(40470700004)(36840700001)(46966006)(186003)(40480700001)(70586007)(7696005)(70206006)(426003)(47076005)(336012)(2616005)(8676002)(6916009)(36756003)(1076003)(4326008)(54906003)(26005)(8936002)(5660300002)(83380400001)(40460700003)(316002)(86362001)(82310400005)(30864003)(2906002)(6666004)(44832011)(41300700001)(478600001)(36860700001)(356005)(82740400003)(81166007)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5096 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e28d4ec3-8ebc-4fb1-5e84-08da60f1e27a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZcZP1jXz6MdoKLNGA2Sy5cX3PzuDiWdCOB0Z9aGSRExDIgfkDDk3lPQ2zzGc5EHPPsGYFpD7J8bAah1AJ0916hjZ+FWN0wLu4lisDx1l27AULXQWnbM5VoD8/MWhmaFX9nOtDDUnRQiqDpDsF+XWCE40TKw4p5gsDvuOvSAVDxnkSB5m6MboDbdnNdlcX9rxPp+g5GBZiEBHZOJJlI4+2xXFgKOBkxfLSQvzDbMlY6DMoBy6m4AIVbl4fGtPwcbgvQWaqtcxmWda01LkWHB/ydUkFxsEaDPeuqqF4RfFaxUYmUog+7P03fd1fwLJjTO6YLkV3NTx132nmc3yJP3zragj3V8/tas5uVAOkzv1mUnUAH+DRaq0EBs0GH37OBtK1f5QchWCWY15sy214hNuuxV3nHezSgLR5k757zAI/Kd6W84fBwHFX6ifM/oj+86uulCxnP8+nShZXd//+VMk+9IHADLE00r/bDxEFKVhkepU5h10U3x3ghdAurS716WqcRejagMBAtA8CcIXC9V3L8tbaXmYLEPERKAPlq37y1Ul++nKryeRShUo0Fok/EcPyGrr8pdLZ1x5f0kc0umUYaqrwH4hJ/PmOIfdxXRFe74im13HW0Q/Mjcj9AaPxA/oEdOPEf+la4C1c07mJUwZMPyJ3HgpmtMIJ380qCaFpETTKGZehDcCTr3Mn1EqJO4mVMWu+uby+fk+EQ9bmEKpF6AC74D0m2/74DBRq5awJhSkvJ6sFH2lPMRLVu53LjKKRyupm8mIYKTRojsZ0hfFHZQQ6qpCL8Z8UCXABsPx3DXN/K77GdEd7ryo54WXS2eJ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(136003)(396003)(40470700004)(46966006)(36840700001)(8936002)(36756003)(2906002)(82740400003)(41300700001)(426003)(70206006)(5660300002)(336012)(8676002)(44832011)(4326008)(186003)(47076005)(83380400001)(6916009)(86362001)(30864003)(2616005)(7696005)(316002)(478600001)(26005)(107886003)(40460700003)(70586007)(36860700001)(81166007)(82310400005)(6666004)(1076003)(54906003)(40480700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:55:33.7146 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 754677fb-9a43-4b30-5624-08da60f1e8f2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1785 x86 has implemented a set of codes to scan NUMA nodes. These codes will parse NUMA memory and processor information from ACPI SRAT table. But except some ACPI specific codes, most of the scan codes like memory blocks validation, node memory range updates and some sanity check can be reused by other NUMA implementation. So in this patch, we move some variables and related functions for NUMA memory and processor to common code. At the same time, numa_set_processor_nodes_parsed has been introduced for ACPI specific code to update processor parsing results. With this helper, we can move most of NUMA memory affinity init code from ACPI. And bad_srat and node_to_pxm functions have been exported for common code to do architectural fallback and node to proximity converting. For those NUMA implementations haven't supported proximity domain to node map. A simple 1-1 mapping helper can help us to avoid the modification of some very valuable print messages. Signed-off-by: Wei Chen --- v1 -> v2: 1. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 2. Merge this single patch instead of serval patches to move x86 SRAT code to common. 3. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 4. Change the code style to target file's Xen code-style. 5. Adjust some __init and __initdata for some functions and variables. --- xen/arch/x86/include/asm/numa.h | 3 +- xen/arch/x86/srat.c | 288 ++---------------------------- xen/common/numa.c | 307 ++++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 7 + 4 files changed, 328 insertions(+), 277 deletions(-) diff --git a/xen/arch/x86/include/asm/numa.h b/xen/arch/x86/include/asm/numa.h index d8960743d4..eeb431cdb7 100644 --- a/xen/arch/x86/include/asm/numa.h +++ b/xen/arch/x86/include/asm/numa.h @@ -10,6 +10,7 @@ typedef u8 nodeid_t; extern int srat_rev; extern nodeid_t pxm_to_node(unsigned int pxm); +extern unsigned node_to_pxm(nodeid_t n); #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) @@ -22,8 +23,6 @@ extern void init_cpu_to_node(void); #define arch_want_default_dmazone() (num_online_nodes() > 1) -extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); - void srat_parse_regions(paddr_t addr); extern u8 __node_distance(nodeid_t a, nodeid_t b); unsigned int arch_get_dma_bitsize(void); diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c index 5bc9096a15..9ae81afdff 100644 --- a/xen/arch/x86/srat.c +++ b/xen/arch/x86/srat.c @@ -24,10 +24,6 @@ static struct acpi_table_slit *__read_mostly acpi_slit; -static nodemask_t memory_nodes_parsed __initdata; -static nodemask_t processor_nodes_parsed __initdata; -static struct node nodes[MAX_NUMNODES] __initdata; - struct pxm2node { unsigned pxm; nodeid_t node; @@ -35,19 +31,6 @@ struct pxm2node { static struct pxm2node __read_mostly pxm2node[MAX_NUMNODES] = { [0 ... MAX_NUMNODES - 1] = {.node = NUMA_NO_NODE} }; -static unsigned node_to_pxm(nodeid_t n); - -static int num_node_memblks; -static struct node node_memblk_range[NR_NODE_MEMBLKS]; -static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; -static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); - -enum conflicts { - NO_CONFLICT, - OVERLAP, - INTERLEAVE, -}; - static inline bool node_found(unsigned idx, unsigned pxm) { return ((pxm2node[idx].pxm == pxm) && @@ -110,78 +93,7 @@ nodeid_t setup_node(unsigned pxm) return node; } -int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) -{ - int i; - - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - if (nd->start <= start && nd->end >= end && - memblk_nodeid[i] == node) - return 1; - } - - return 0; -} - -static -enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, - paddr_t end, paddr_t nd_start, - paddr_t nd_end, unsigned int *mblkid) -{ - unsigned int i; - - /* - * Scan all recorded nodes' memory blocks to check conflicts: - * Overlap or interleave. - */ - for (i = 0; i < num_node_memblks; i++) { - struct node *nd = &node_memblk_range[i]; - - *mblkid = i; - - /* Skip 0 bytes node memory block. */ - if (nd->start == nd->end) - continue; - /* - * Use memblk range to check memblk overlaps, include the - * self-overlap case. As nd's range is non-empty, the special - * case "nd->end == end && nd->start == start" also can be covered. - */ - if (nd->end > start && nd->start < end) - return OVERLAP; - - /* - * Use node memory range to check whether new range contains - * memory from other nodes - interleave check. We just need - * to check full contains situation. Because overlaps have - * been checked above. - */ - if (nid != memblk_nodeid[i] && - nd->start >= nd_start && nd->end <= nd_end) - return INTERLEAVE; - } - - return NO_CONFLICT; -} - -static __init void cutoff_node(int i, paddr_t start, paddr_t end) -{ - struct node *nd = &nodes[i]; - if (nd->start < start) { - nd->start = start; - if (nd->end < nd->start) - nd->start = nd->end; - } - if (nd->end > end) { - nd->end = end; - if (nd->start > nd->end) - nd->start = nd->end; - } -} - -static __init void bad_srat(void) +void __init bad_srat(void) { int i; printk(KERN_ERR "SRAT: SRAT not used.\n"); @@ -259,7 +171,7 @@ acpi_numa_x2apic_affinity_init(const struct acpi_srat_x2apic_cpu_affinity *pa) } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); numa_status = numa_acpi; if (opt_acpi_verbose) @@ -294,7 +206,7 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) return; } apicid_to_node[pa->apic_id] = node; - node_set(node, processor_nodes_parsed); + numa_set_processor_nodes_parsed(node); numa_status = numa_acpi; if (opt_acpi_verbose) @@ -306,12 +218,9 @@ acpi_numa_processor_affinity_init(const struct acpi_srat_cpu_affinity *pa) void __init acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) { - struct node *nd; - paddr_t nd_start, nd_end; - paddr_t start, end; unsigned pxm; nodeid_t node; - unsigned int i; + int ret; if (srat_disabled()) return; @@ -322,15 +231,14 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) if (!(ma->flags & ACPI_SRAT_MEM_ENABLED)) return; - start = ma->base_address; - end = start + ma->length; /* Supplement the heuristics in l1tf_calculations(). */ - l1tf_safe_maddr = max(l1tf_safe_maddr, ROUNDUP(end, PAGE_SIZE)); + l1tf_safe_maddr = max(l1tf_safe_maddr, + ROUNDUP(ma->base_address + ma->length, + PAGE_SIZE)); - if (num_node_memblks >= NR_NODE_MEMBLKS) - { + if (!numa_memblks_available()) { dprintk(XENLOG_WARNING, - "Too many numa entry, try bigger NR_NODE_MEMBLKS \n"); + "Too many numa entries, try bigger NR_NODE_MEMBLKS!\n"); bad_srat(); return; } @@ -344,129 +252,10 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) return; } - /* - * For the node that already has some memory blocks, we will - * expand the node memory range temporarily to check memory - * interleaves with other nodes. We will not use this node - * temp memory range to check overlaps, because it will mask - * the overlaps in same node. - * - * Node with 0 bytes memory doesn't need this expandsion. - */ - nd_start = start; - nd_end = end; - nd = &nodes[node]; - if (nd->start != nd->end) { - if (nd_start > nd->start) - nd_start = nd->start; - - if (nd_end < nd->end) - nd_end = nd->end; - } - - /* It is fine to add this area to the nodes data it will be used later*/ - switch (conflicting_memblks(node, start, end, nd_start, nd_end, &i)) { - case OVERLAP: - if (memblk_nodeid[i] == node) { - bool mismatch = !(ma->flags & - ACPI_SRAT_MEM_HOT_PLUGGABLE) != - !test_bit(i, memblk_hotplug); - - printk("%sSRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", - mismatch ? KERN_ERR : KERN_WARNING, pxm, start, - end - 1, node_memblk_range[i].start, - node_memblk_range[i].end - 1); - if (mismatch) { - bad_srat(); - return; - } - break; - } - - printk(KERN_ERR - "SRAT: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, - node_memblk_range[i].end - 1); + ret = numa_update_node_memblks(node, pxm, ma->base_address, ma->length, + ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE); + if (ret) bad_srat(); - return; - - case INTERLEAVE: - printk(KERN_ERR - "SRAT： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", - pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), - node_memblk_range[i].start, node_memblk_range[i].end - 1); - bad_srat(); - return; - - case NO_CONFLICT: - break; - } - - if (!(ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE)) { - node_set(node, memory_nodes_parsed); - nd->start = nd_start; - nd->end = nd_end; - } - - printk(KERN_INFO "SRAT: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", - node, pxm, start, end - 1, - ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE ? " (hotplug)" : ""); - - node_memblk_range[num_node_memblks].start = start; - node_memblk_range[num_node_memblks].end = end; - memblk_nodeid[num_node_memblks] = node; - if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { - __set_bit(num_node_memblks, memblk_hotplug); - mem_hotplug_update_boundary(end); - } - num_node_memblks++; -} - -/* Sanity check to catch more bad SRATs (they are amazingly common). - Make sure the PXMs cover all memory. */ -static int __init nodes_cover_memory(void) -{ - unsigned int i; - - for (i = 0; ; i++) { - int j, found; - paddr_t start, end; - - /* Try to loop memory map from index 0 to end. */ - found = arch_get_memory_map(i, &start, &end); - - /* Index relate entry is not RAM, skip it. */ - if (found == -EINVAL) - continue; - - /* Reach the end of arch's memory map */ - if (found == -ENODEV) - break; - - do { - found = 0; - for_each_node_mask(j, memory_nodes_parsed) - if (start < nodes[j].end - && end > nodes[j].start) { - if (start >= nodes[j].start) { - start = nodes[j].end; - found = 1; - } - if (end <= nodes[j].end) { - end = nodes[j].start; - found = 1; - } - } - } while (found && start < end); - - if (start < end) { - printk(KERN_ERR "NUMA: No node for memory map range: " - "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); - return 0; - } - } - return 1; } void __init acpi_numa_arch_fixup(void) {} @@ -522,58 +311,7 @@ void __init srat_parse_regions(paddr_t addr) pfn_pdx_hole_setup(mask >> PAGE_SHIFT); } -/* Use the information discovered above to actually set up the nodes. */ -int __init acpi_scan_nodes(paddr_t start, paddr_t end) -{ - int i; - nodemask_t all_nodes_parsed; - - /* First clean up the node list */ - for (i = 0; i < MAX_NUMNODES; i++) - cutoff_node(i, start, end); - - /* Only when numa_on with good firmware, we can do numa scan nodes. */ - if (!numa_enabled_with_firmware()) - return -1; - - if (!nodes_cover_memory()) { - bad_srat(); - return -1; - } - - memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, - memblk_nodeid); - - if (memnode_shift < 0) { - printk(KERN_ERR - "SRAT: No NUMA node hash function found. Contact maintainer\n"); - bad_srat(); - return -1; - } - - nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); - - /* Finally register nodes */ - for_each_node_mask(i, all_nodes_parsed) - { - uint64_t size = nodes[i].end - nodes[i].start; - - if ( size == 0 ) - printk(KERN_INFO "SRAT: node %u has no memory\n", i); - - setup_node_bootmem(i, nodes[i].start, nodes[i].end); - } - for (i = 0; i < nr_cpu_ids; i++) { - if (cpu_to_node[i] == NUMA_NO_NODE) - continue; - if (!nodemask_test(cpu_to_node[i], &processor_nodes_parsed)) - numa_set_node(i, NUMA_NO_NODE); - } - numa_init_array(); - return 0; -} - -static unsigned node_to_pxm(nodeid_t n) +unsigned node_to_pxm(nodeid_t n) { unsigned i; diff --git a/xen/common/numa.c b/xen/common/numa.c index bc6a2ded14..e3b66c54b5 100644 --- a/xen/common/numa.c +++ b/xen/common/numa.c @@ -14,6 +14,21 @@ #include #include +static nodemask_t __initdata processor_nodes_parsed; +static nodemask_t __initdata memory_nodes_parsed; +static struct node __initdata nodes[MAX_NUMNODES]; + +static int num_node_memblks; +static struct node node_memblk_range[NR_NODE_MEMBLKS]; +static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; +static __initdata DECLARE_BITMAP(memblk_hotplug, NR_NODE_MEMBLKS); + +enum conflicts { + NO_CONFLICT, + OVERLAP, + INTERLEAVE, +}; + struct node_data node_data[MAX_NUMNODES]; /* Mapping from pdx to node id */ @@ -32,6 +47,298 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; enum numa_mode numa_status; +void __init numa_set_processor_nodes_parsed(nodeid_t node) +{ + node_set(node, processor_nodes_parsed); +} + +int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) +{ + int i; + + for ( i = 0; i < num_node_memblks; i++ ) + { + struct node *nd = &node_memblk_range[i]; + + if ( nd->start <= start && nd->end >= end && + memblk_nodeid[i] == node ) + return 1; + } + + return 0; +} + +static +enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, + paddr_t end, paddr_t nd_start, + paddr_t nd_end, unsigned int *mblkid) +{ + unsigned int i; + + /* + * Scan all recorded nodes' memory blocks to check conflicts: + * Overlap or interleave. + */ + for ( i = 0; i < num_node_memblks; i++ ) + { + struct node *nd = &node_memblk_range[i]; + + *mblkid = i; + + /* Skip 0 bytes node memory block. */ + if ( nd->start == nd->end ) + continue; + /* + * Use memblk range to check memblk overlaps, include the + * self-overlap case. As nd's range is non-empty, the special + * case "nd->end == end && nd->start == start" also can be covered. + */ + if ( nd->end > start && nd->start < end ) + return OVERLAP; + + /* + * Use node memory range to check whether new range contains + * memory from other nodes - interleave check. We just need + * to check full contains situation. Because overlaps have + * been checked above. + */ + if ( nid != memblk_nodeid[i] && + nd->start >= nd_start && nd->end <= nd_end ) + return INTERLEAVE; + } + + return NO_CONFLICT; +} + +static void __init cutoff_node(int i, paddr_t start, paddr_t end) +{ + struct node *nd = &nodes[i]; + + if ( nd->start < start ) + { + nd->start = start; + if ( nd->end < nd->start ) + nd->start = nd->end; + } + + if ( nd->end > end ) + { + nd->end = end; + if ( nd->start > nd->end ) + nd->start = nd->end; + } +} + +bool __init numa_memblks_available(void) +{ + return num_node_memblks < NR_NODE_MEMBLKS; +} + +/* + * This function will be called by NUMA memory affinity initialization to + * update NUMA node's memory range. In this function, we assume all memory + * regions belonging to a single node are in one chunk. Holes (or MMIO + * ranges) between them will be included in the node. + * + * So in numa_update_node_memblks, if there are multiple banks for each + * node, start and end are stretched to cover the holes between them, and + * it works as long as memory banks of different NUMA nodes don't interleave. + */ +int __init numa_update_node_memblks(nodeid_t node, unsigned pxm, + paddr_t start, paddr_t size, + bool hotplug) +{ + unsigned int i; + paddr_t end = start + size; + paddr_t nd_start = start; + paddr_t nd_end = end; + struct node *nd = &nodes[node]; + + /* + * For the node that already has some memory blocks, we will + * expand the node memory range temporarily to check memory + * interleaves with other nodes. We will not use this node + * temp memory range to check overlaps, because it will mask + * the overlaps in same node. + * + * Node with 0 bytes memory doesn't need this expandsion. + */ + if ( nd->start != nd->end ) + { + if ( nd_start > nd->start ) + nd_start = nd->start; + + if ( nd_end < nd->end ) + nd_end = nd->end; + } + + /* It is fine to add this area to the nodes data it will be used later*/ + switch ( conflicting_memblks(node, start, end, nd_start, nd_end, &i) ) + { + case OVERLAP: + if ( memblk_nodeid[i] == node ) + { + bool mismatch = !(hotplug) != !test_bit(i, memblk_hotplug); + + printk("%sNUMA: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with itself [%"PRIpaddr", %"PRIpaddr"]\n", + mismatch ? KERN_ERR : KERN_WARNING, pxm, start, end - 1, + node_memblk_range[i].start, node_memblk_range[i].end - 1); + if ( mismatch ) + return -EINVAL; + break; + } + + printk(KERN_ERR + "NUMA: PXM %u [%"PRIpaddr", %"PRIpaddr"] overlaps with PXM %u [%"PRIpaddr", %"PRIpaddr"]\n", + pxm, start, end - 1, node_to_pxm(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return -EINVAL; + + + case INTERLEAVE: + printk(KERN_ERR + "NUMA： PXM %u: [%"PRIpaddr", %"PRIpaddr"] interleaves with PXM %u memblk [%"PRIpaddr", %"PRIpaddr"]\n", + pxm, nd_start, nd_end - 1, node_to_pxm(memblk_nodeid[i]), + node_memblk_range[i].start, node_memblk_range[i].end - 1); + return -EINVAL; + + case NO_CONFLICT: + break; + } + + if ( !hotplug ) + { + node_set(node, memory_nodes_parsed); + nd->start = nd_start; + nd->end = nd_end; + } + + printk(KERN_INFO "NUMA: Node %u PXM %u [%"PRIpaddr", %"PRIpaddr"]%s\n", + node, pxm, start, end - 1, + hotplug ? " (hotplug)" : ""); + + node_memblk_range[num_node_memblks].start = start; + node_memblk_range[num_node_memblks].end = end; + memblk_nodeid[num_node_memblks] = node; + if ( hotplug ) + { + __set_bit(num_node_memblks, memblk_hotplug); + mem_hotplug_update_boundary(end); + } + num_node_memblks++; + + return 0; +} + +/* + * Sanity check to catch more bad SRATs (they are amazingly common). + * Make sure the PXMs cover all memory. + */ +static int __init nodes_cover_memory(void) +{ + unsigned int i; + + for ( i = 0; ; i++ ) + { + int j, found; + paddr_t start, end; + + /* Try to loop memory map from index 0 to end. */ + found = arch_get_memory_map(i, &start, &end); + + /* Index relate entry is not RAM, skip it. */ + if ( found == -EINVAL ) + continue; + + /* Reach the end of arch's memory map */ + if ( found == -ENODEV ) + break; + + do { + found = 0; + for_each_node_mask( j, memory_nodes_parsed ) + if ( start < nodes[j].end + && end > nodes[j].start ) + { + if ( start >= nodes[j].start ) + { + start = nodes[j].end; + found = 1; + } + + if ( end <= nodes[j].end ) + { + end = nodes[j].start; + found = 1; + } + } + } while ( found && start < end ); + + if ( start < end ) + { + printk(KERN_ERR "NUMA: No node for memory map range: " + "[%"PRIpaddr", %"PRIpaddr"]\n", start, end - 1); + return 0; + } + } + return 1; +} + +/* Use the information discovered above to actually set up the nodes. */ +int __init acpi_scan_nodes(paddr_t start, paddr_t end) +{ + int i; + nodemask_t all_nodes_parsed; + + /* First clean up the node list */ + for ( i = 0; i < MAX_NUMNODES; i++ ) + cutoff_node(i, start, end); + + /* Only when numa_on with good firmware, we can do numa scan nodes. */ + if ( !numa_enabled_with_firmware() ) + return -1; + + if ( !nodes_cover_memory() ) + { + bad_srat(); + return -1; + } + + memnode_shift = compute_hash_shift(node_memblk_range, num_node_memblks, + memblk_nodeid); + + if ( memnode_shift < 0 ) + { + printk(KERN_ERR + "SRAT: No NUMA node hash function found. Contact maintainer\n"); + bad_srat(); + return -1; + } + + nodes_or(all_nodes_parsed, memory_nodes_parsed, processor_nodes_parsed); + + /* Finally register nodes */ + for_each_node_mask( i, all_nodes_parsed ) + { + paddr_t size = nodes[i].end - nodes[i].start; + + if ( size == 0 ) + printk(KERN_INFO "SRAT: node %u has no memory\n", i); + + setup_node_bootmem(i, nodes[i].start, nodes[i].end); + } + + for ( i = 0; i < nr_cpu_ids; i++ ) + { + if ( cpu_to_node[i] == NUMA_NO_NODE ) + continue; + if ( !nodemask_test(cpu_to_node[i], &processor_nodes_parsed) ) + numa_set_node(i, NUMA_NO_NODE); + } + numa_init_array(); + return 0; +} + /* * Given a shift value, try to populate memnodemap[] * Returns : diff --git a/xen/include/xen/numa.h b/xen/include/xen/numa.h index 6d02204991..564add430c 100644 --- a/xen/include/xen/numa.h +++ b/xen/include/xen/numa.h @@ -52,6 +52,7 @@ extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); extern bool numa_enabled_with_firmware(void); extern enum numa_mode numa_status; +extern void bad_srat(void); extern void numa_set_node(int cpu, nodeid_t node); extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); @@ -90,6 +91,12 @@ static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) extern int arch_get_memory_map(unsigned int idx, paddr_t *start, paddr_t *end); +extern int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node); +extern bool numa_memblks_available(void); +extern int numa_update_node_memblks(nodeid_t node, unsigned pxm, + paddr_t start, paddr_t size, + bool hotplug); +extern void numa_set_processor_nodes_parsed(nodeid_t node); #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 14:58:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 14:58:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363521.594107 (Exim 4.92) (envelope-from ) id 1o9pRP-0004cr-2g; Fri, 08 Jul 2022 14:58:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363521.594107; Fri, 08 Jul 2022 14:58:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pRO-0004ck-Vv; Fri, 08 Jul 2022 14:58:46 +0000 Received: by outflank-mailman (input) for mailman id 363521; Fri, 08 Jul 2022 14:58:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pRN-0004bj-KU for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 14:58:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7613dd7c-fece-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 16:58:44 +0200 (CEST) Received: from DB6PR0201CA0031.eurprd02.prod.outlook.com (2603:10a6:4:3f::41) by DB6PR0801MB1911.eurprd08.prod.outlook.com (2603:10a6:4:74::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Fri, 8 Jul 2022 14:58:41 +0000 Received: from DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::46) by DB6PR0201CA0031.outlook.office365.com (2603:10a6:4:3f::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:58:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT054.mail.protection.outlook.com (100.127.142.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:58:41 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Fri, 08 Jul 2022 14:58:41 +0000 Received: from 7241878d3249.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7DF909BE-0E3F-4986-AFC6-960F5D47B902.1; Fri, 08 Jul 2022 14:54:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7241878d3249.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 14:54:58 +0000 Received: from DB8PR03CA0017.eurprd03.prod.outlook.com (2603:10a6:10:be::30) by DB6PR08MB2934.eurprd08.prod.outlook.com (2603:10a6:6:19::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Fri, 8 Jul 2022 14:54:56 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:be:cafe::76) by DB8PR03CA0017.outlook.office365.com (2603:10a6:10:be::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 14:54:56 +0000 Received: from nebula.arm.com (40.67.248.234) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 14:54:56 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 8 Jul 2022 14:54:55 +0000 Received: from ais-wip-ds.shanghai.arm.com (10.169.190.86) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 8 Jul 2022 14:54:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7613dd7c-fece-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QMou85lCaf58mIlTfoDIiyXjii8iYEQrOXzs9fBIMqKrvdIMk7pJVkvmYRQVyB5cDz+br4BV8N+EEiyRJ8TquBRNYmPv/SAgGdKmIx1KEr/lTJ0dvazjRXXhdBt6p1Hk/gGL49vMa7DG26pRz1Pq6jgiDEgHmXHNFpgvjo8EUlIrIcbpQBUidKVt7jsmlOzNeplSzLnoDdpiQTBGucvBODvWwKSq9YVb1/5Cl9/0mclTWNZM5LRJZUU4QifWJ/55v3ClEGATvDQtqfoeY+JFnv0W7UOZXUh3l7FXEb52ZdXwE69EQGdbmUrb+4ZuRXTNRJTchJarqYr3B6S15qmXqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LHdkOUdoAVcxQX9QxLdCraDOgBH9hRS+7Zn54KEbq5g=; b=fh+tpEv7u0u2zz/n6pUwfBTdVXez6DCNTzPDqbEBK6XY3TWM1JTKLlTCoDcKBds7b/SmTQhsQ9Ym+1dB6iR5J9AKpJ5sUsoCK9NnXbYXYlEUZLSWj2T/lSnarHlAlliGQA/0goMPs9qm0YI+R48Wwxo1H+SLTTKCtKyEr5XdEoO2PRlJFn7/F/Y83V4ncgmgnVcEpt0Q6NQbw6YWHnd6xYNTFhPC3/kp/TGVtdVvZkNHHDWd3u/v5fN35WJRZy9dxeo6Xhv2k/zEjCIugpmE/gai9bNgaaHw9fUVJKFkk+AK+Gqx9VNHVY5IAjuRbbxRrUpEoY339RvTQaflHh2+oA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHdkOUdoAVcxQX9QxLdCraDOgBH9hRS+7Zn54KEbq5g=; b=fk10K9XcduIAlrPzChNjkLT3h+8n///fPnEdtrhiRDluY4PIuVMhHan4WnJrmOhBLkO9zWthdq/CVN+cnpBk7gtII9I8v7EPMU7SSdKvB7s4PExezcV96ZOxtD/Q0NpwX0sR3D74/iVhthczYVQzNwe4UcjcAw95yceR6D4jykY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 37d6a05c52907ce5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WWIqIs+9Q1tfaPSoeHq6GxdhV94Uw9960sOavN8VnDpqCDaAWo0Df5WCWqu6+tOsK6yfrBmFa/Va/U2DddUZnwsY0SmtndF3ZXmtmDdnno94JvLUBqBwti3yYlXW51X8tJuQeVGJ6dwJPgagLy9mw5tUdTmvQuk3gbc4W6xQ/ejqIPQxsEVAqRR4V3kzgzvVgvb+E/dRP9S/SnBsoDFKiUWQWIxW8k5QTIaPCjgp7bGrO+Zpj9SAjbvPzIuO19lg5lyEEFAs+aZU6RM3G0rC11C4DEDW5rDcyApYmIngLZew0PEaw/zxDlx6ANUial0INiqLsKyn0JmaoA4s+ZCOwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LHdkOUdoAVcxQX9QxLdCraDOgBH9hRS+7Zn54KEbq5g=; b=D9lLSZqKW6L+0hF3+lFtYotiQMpDX0ed6e5MA1Uzdsweu8im1XLhZ2I+IPQ/B7PbFK4MrKVu+y1+BY1+qMz2lM6b4rfqe3ARDeijcoQ0D3OKEOpzsDBqU4bL0VLI7tMql28ISdCaKQqkqQgKHvistp6L/HAJpnEzcuuy+Zl6UNyI6vwJ0ZEgbXwIqgdr7Vmgl01Xa2JhLFpcOnRoSu0v0HeVufN5SCewxKoWQ8zyXpTYQClHYjZWGyV/1cdR3j3MSBiALQAdJIPZx01mL1gcfw4cgWueSLxXl/5EMsI4hXQ5XTrlrPwVAoDZg2br8pFjuNgEFZWAoN93pEE0xODYJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LHdkOUdoAVcxQX9QxLdCraDOgBH9hRS+7Zn54KEbq5g=; b=fk10K9XcduIAlrPzChNjkLT3h+8n///fPnEdtrhiRDluY4PIuVMhHan4WnJrmOhBLkO9zWthdq/CVN+cnpBk7gtII9I8v7EPMU7SSdKvB7s4PExezcV96ZOxtD/Q0NpwX0sR3D74/iVhthczYVQzNwe4UcjcAw95yceR6D4jykY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Wei Chen To: CC: , Wei Chen , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini Subject: [PATCH v2 0/9] Device tree based NUMA support for Arm - Part#2 Date: Fri, 8 Jul 2022 22:54:15 +0800 Message-ID: <20220708145424.1848572-1-wei.chen@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 871981d6-262f-40f2-e894-08da60f258bf X-MS-TrafficTypeDiagnostic: DB6PR08MB2934:EE_|DBAEUR03FT054:EE_|DB6PR0801MB1911:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: a4VBiwR7yvLaMu2mNRhGw02XqjiRMiWQGpmFkhvLabC6h/RjfbACvnWDRUJDql8vj4L17cQukSlBWy1V1hRz2zEtTaVPqiaZNlbuqAjSU6dtfERuih7Hl31VSqAdumlrjImJHMY4+VnmQDbJGpVtUXMdHb2isQ3yYF0JtztaQtLaOR70Y/x8qrp4dEv1hauErcdSDxSuMNA7OMV4/4z6Zm/tlopG7V81w4oirhdJ+6VXczo+5QKPRBtLDOQCPb3PtMp8JWe0LIUsD2407M0PuvJir72XUYlbhYWPlNqW+qV4h2AbZIS6SJe/ogtwxAw03SDKwvXcZjyZOaEIXRBpNUZxXpVRH1M9PdawvCka0TqcEu79Wc7Kj0MTxTbCVK80ETjK4JzTcAR55B6+hmfkPBHwVQOC3RAFiFBKLoRy6tGtjVKO77NnMq/eummdF4//3QoPCVu1gUDKJHFoFnoTT2sxRu/2IddtibR+alxnwvomBOrdbhDN8C3leneQSjJ/R/UF3amjTXU+MZdBzr2KGYiA7t8WC499qAh1pfCl3GM9xZMlJHDc/GcN0qXJLiULUjNPVfkhXeqsydl9cW0Fi9NQqcCBA9qTPjh4fYux/gynJCG4iBKjIOCIoXNm7oVqlpHj8EcmtsybyZu5FzGKN+lPjdmohPoz7awR17em03ejlfDYpMTBeLUTFcfIdEgFLGYJwOKdlu0wK+j8MjBVrCvXjHasRqKWDWzGwGdVTluoaW8ZaE8yIAEcWfi2HxI1GdpUK8smcjFI558ze/d9j8h+Um+qJtRSMvQACG9kzfq1qv82w96Oa521fLxCvE/p2djO1r+LcTrX5lnrVrGLdcM1hhWdYExTHLzv60nhDQuJUv3GOz8C8i/WiVoTFV8JnL7dxZsbaCm4PJHyQF+U/zX1saDwdmPMb7uk9cO9yNo= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(346002)(376002)(36840700001)(46966006)(40470700004)(5660300002)(4326008)(26005)(6666004)(82740400003)(81166007)(44832011)(70206006)(6916009)(70586007)(8936002)(966005)(316002)(41300700001)(356005)(54906003)(8676002)(7696005)(86362001)(36756003)(1076003)(336012)(83380400001)(478600001)(47076005)(186003)(40460700003)(2616005)(82310400005)(36860700001)(40480700001)(426003)(2906002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2934 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fe7e85f4-4e51-4d4d-c72e-08da60f1d26d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: c+4wysT8m6ldIoVL1CX0Xw2X0Vwj1Q1Ohx5JN3Qmh5wPecUH7ZWERSkl/ZRfgYrVqEi8w4+/nUO3Lz4ULqdiHQOO+b4wg0iTivUtdh9Psvq6EPmyD4i66nxQ8NhkH/MOf7QV8J3byyNo2fqclQedqtpwTvrQCB5xT3+lsdYPKMovblKr9NWa8npXCHmB9FUVg8ZlDnF++gV/bK1xoAC6diBXmfvzjCnuWclmFZDiWM8fZAddKrbHVu/tuGVeOtPBbSOjO3MV+RoJKtGqfQRmERwzDpnSaZPMGvFWlPKfb+izYHfXgIrRc+dmdkbC8KHBNyxEjsATlMEvXKddO4Hn1fs/vubcljnW2E/VvfIWnd8JW9llx7hQA7XadlrsGyhZZ5jrlj1LV+Kq2z5vp2BbsJ6EHkskIqAYM4byGEPDij7Zpm+65HxV58rz4gHmAVbHBzlUp0Nh4KPtx7VNjtv4pq0mt0iNEj8CNeqtEIcltpTkY+OoPrYuloCGibqwruCW0vrRDrkzHO162A/o2fmYHWFF1iMoQxR99OTWPK+y0Z8Tb+ymslFkZDTzWF+GWEzJN4X9JqoRHF9vaDnAYZLDD6P88Xk4tF74DL/nPTUxihSOD3mvKwaB6A3fzffFUvH3D/QkdqauCzEh9AH3Mq8mDCtU/0sNZP8jsEBPYTn4AtKFjAsTM6oYcg7KzQ82Eg3H+U1YRHfO8dZlZE48BUVr1KNINqH7svhhYsULwhAkn/muqeH6LJ8y6X42SLJWaRfakzRIDl4wQoKAqjduyy8zIQP6uSdpngGjdwh8d9JXxLyL9rCkKA1nYCYYcajgYCn3gn5BD+FLQoRmtRop/f01HRKtMO5//i/3FD577kgHdMfRxSp6cUo+eGeYlfqbW1CHne6HdficN428ifnsXsGs2Q== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(40470700004)(36840700001)(46966006)(186003)(107886003)(40480700001)(2616005)(1076003)(47076005)(316002)(54906003)(82310400005)(8676002)(6916009)(36756003)(83380400001)(336012)(70206006)(426003)(44832011)(70586007)(86362001)(4326008)(36860700001)(7696005)(966005)(478600001)(81166007)(5660300002)(2906002)(6666004)(40460700003)(26005)(82740400003)(41300700001)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 14:58:41.3514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 871981d6-262f-40f2-e894-08da60f258bf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1911 (The Arm device tree based NUMA support patch set contains 35 patches. In order to make stuff easier for reviewers, I split them into 3 parts: 1. Preparation. I have re-sorted the patch series. And moved independent patches to the head of the series - merged in [1] 2. Move generically usable code from x86 to common - this series. 3. Add new code to support Arm. This series only contains the second part patches. As the whole NUMA series has been reviewed for 1 round in [2], so this series would be v2) Xen memory allocation and scheduler modules are NUMA aware. But actually, on x86 has implemented the architecture APIs to support NUMA. Arm was providing a set of fake architecture APIs to make it compatible with NUMA awared memory allocation and scheduler. Arm system was working well as a single node NUMA system with these fake APIs, because we didn't have multiple nodes NUMA system on Arm. But in recent years, more and more Arm devices support multiple nodes NUMA system. So now we have a new problem. When Xen is running on these Arm devices, Xen still treat them as single node SMP systems. The NUMA affinity capability of Xen memory allocation and scheduler becomes meaningless. Because they rely on input data that does not reflect real NUMA layout. Xen still think the access time for all of the memory is the same for all CPUs. However, Xen may allocate memory to a VM from different NUMA nodes with different access speeds. This difference can be amplified in workloads inside VM, causing performance instability and timeouts. So in this patch series, we implement a set of NUMA API to use device tree to describe the NUMA layout. We reuse most of the code of x86 NUMA to create and maintain the mapping between memory and CPU, create the matrix between any two NUMA nodes. Except ACPI and some x86 specified code, we have moved other code to common. In next stage, when we implement ACPI based NUMA for Arm64, we may move the ACPI NUMA code to common too, but in current stage, we keep it as x86 only. This patch serires has been tested and booted well on one Arm64 NUMA machine and one HPE x86 NUMA machine. [1] https://lists.xenproject.org/archives/html/xen-devel/2022-06/msg00499.html [2] https://lists.xenproject.org/archives/html/xen-devel/2021-09/msg01903.html --- v1 -> v2: 1. Refine the commit messages of several patches. 2. Merge v1 patch#9,10 into one patch. Introduce the new functions in the same patch that this patch will be used first time. 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, in this case, we can drop mem_hotplug_boundary. 4. Remove fw_numa, use enumeration to replace numa_off and acpi_numa. 5. Correct return value of srat_disabled. 6. Introduce numa_enabled_with_firmware. 7. Refine the justification of using !node_data[nid].node_spanned_pages. 8. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. 9. Adjust the conditional express for ASSERT. 10. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. 11. Use conditional macro to gate MAX_NUMNODES for other architectures. 12. Use arch_get_memory_map to replace arch_get_memory_bank_range and arch_get_memory_bank_number. 13. Remove the !start || !end check, because caller guarantee these two pointers will not be NULL. 14. Add code comment for numa_update_node_memblks to explain: Assumes all memory regions belonging to a single node are in one chunk. Holes between them will be included in the node. 15. Merge this single patch instead of serval patches to move x86 SRAT code to common. 16. Export node_to_pxm to keep pxm information in NUMA scan nodes error messages. 17. Change the code style to target file's Xen code-style. 18. Adjust some __init and __initdata for some functions and variables. 19. Replace CONFIG_ACPI_NUMA by CONFIG_NUMA. Replace "SRAT" texts. 20. Turn numa_scan_nodes to static. 21. Change NR_NUMA_NODES upper bound from 4095 to 255. Wei Chen (9): xen/x86: introduce a helper to update memory hotplug end xen/x86: Use enumerations to indicate NUMA status xen/x86: move generically usable NUMA code from x86 to common xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid xen/x86: use arch_get_memory_map to get information from E820 map xen/x86: move NUMA scan nodes codes from x86 to common xen/x86: rename bad_srat to numa_bad xen: rename acpi_scan_nodes to numa_scan_nodes xen: introduce a Kconfig option to configure NUMA nodes number xen/arch/Kconfig | 11 + xen/arch/x86/include/asm/acpi.h | 2 - xen/arch/x86/include/asm/mm.h | 6 + xen/arch/x86/include/asm/numa.h | 61 +-- xen/arch/x86/include/asm/setup.h | 1 - xen/arch/x86/numa.c | 446 +----------------- xen/arch/x86/setup.c | 3 +- xen/arch/x86/srat.c | 310 ++----------- xen/common/Makefile | 1 + xen/common/numa.c | 746 +++++++++++++++++++++++++++++++ xen/include/xen/numa.h | 92 +++- 11 files changed, 902 insertions(+), 777 deletions(-) create mode 100644 xen/common/numa.c -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 15:09:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 15:09:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363534.594118 (Exim 4.92) (envelope-from ) id 1o9pbJ-0006i7-1d; Fri, 08 Jul 2022 15:09:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363534.594118; Fri, 08 Jul 2022 15:09:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pbI-0006i0-Uo; Fri, 08 Jul 2022 15:09:00 +0000 Received: by outflank-mailman (input) for mailman id 363534; Fri, 08 Jul 2022 15:08:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pbH-0006hu-3Q for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 15:08:59 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e3396857-fecf-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 17:08:56 +0200 (CEST) Received: from AM6P195CA0002.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::15) by AM4PR08MB2657.eurprd08.prod.outlook.com (2603:10a6:205:b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 15:08:54 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::13) by AM6P195CA0002.outlook.office365.com (2603:10a6:209:81::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Fri, 8 Jul 2022 15:08:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:08:54 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Fri, 08 Jul 2022 15:08:54 +0000 Received: from b1cfc813e8e8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6D99E7BF-BEDD-41D2-8222-22EAE994763B.1; Fri, 08 Jul 2022 15:08:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b1cfc813e8e8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 15:08:47 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DBBPR08MB6316.eurprd08.prod.outlook.com (2603:10a6:10:207::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Fri, 8 Jul 2022 15:08:46 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.018; Fri, 8 Jul 2022 15:08:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e3396857-fecf-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=K1aeZsQCgdVnPV9AeUV18yUlfOymJxAb4MjX6UaSJc0DRDfrSO9t+xnm+glxSW2HCcTw4ms8PSibOUWHi+7yktHrgb5CIGXx4r39FGCIMAn5P/v40nEY8MwANIfu4l3vgkeOItsp2+AMkwpCepOo53tyOZxKSqMV3yzL4Bv7uviB698JGxUD+aer2DwMuKmJGyRbJWity2u4ifaXD/P8C2ksaQYq1obktv0mEQJc5KnIdPA89EQzmvJSM4THyem0ANSGGyK06tc3xdJqloi1g6GrT+jGgx/wP64xm+S3jqsWu1iii/qNi8e/BUu7Om3FO3oBNLej2OHMZrDJH9I6gw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=fFL6LmLBoXzL8injvPKnCDUAlKf50JYsL69n9YTInUeRiv1cChFNpAoVSpsPWhxyjWz+aadI5e89SxAZB/07uf5qjhv1r2+tdVaLHzzGdfpDBbSyzMM1NVq9eJwkKWC/+tn643gi2V3YWmeHVc0PUDUPeF0VjgM2Ti48AOnVgtCKgS9m2SNKXkqQIhkls+uSHQKgDQAPIZWlJNVfx0udYFM1Abc8+RDNvGiGYYoQp0+P4/IyncvTL6hpriCnEDWPGwVLjq6A5s9cscW8S9WaZce4NFWDjIkbzScNHTePNYiKhnMIA3xs28DhqP7pd4WKEyDQHJExwYlaWC2vRXrK6w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=RtgV13OBk6CZr1W/Q8P2a8gsdypyQngIWb2Wa1F7uK0S5O7aw6R8/RMS05VFDrkjlqx4n0aBF3oa5JPVIV163xbOvB7uJtMNoi+PFIJCN/zkMWwSrSMsOT2I744lzXFtuuMo9kC5cgWxGQyo9FXILOyCLB1UwmM7rT1DPgV+y9w= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: a13394f68c6e6da2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1rUz410CoB9m2+Cj9GxBQ5qv8EJxCPMBPOrkh0spA4Fi8H4wtoX1lqywA2n+aVl3k2+95JhRwXcAcgsiMLviTGcwhKSAUSgn9JZ1CxG5xdWMV7goKsuhkHkwd0GksF02cU+j7qo7eMFzLHB9hJ4U9Y8IgixhlIXYXgccKjBEFGIRbOG3wBMPQtKRD3r0kjRPqUjfGY/22PkIvpm44wV6lgrUA2wzsf+FfA1Pk20buqNpvPXrLKEUlNXtvUpsFuAuNINGe5/U0bCwmHWrdwYqvmjOrEthq/ZN+1//M9fTvNia13y/DMH+ZAIgChePeIDN2Cj8TgxBJP6Emcvhhu/+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=EOE4N6pXegCpf00ZSn1nP3yjlt6HkgDHqcC5T72wawYFz2gNW2YlDcI8fmcy4Pwu+hWVxrU8SQ/FLeGxe5OXZxMaBLppmFy1Ab2u65jktPFmbUpttyRfKwU0xrulIjSjnFnnzAv/n58y62BNZSfZri1BtYzQQAKKK5iIXmOZBA62x/3PmtdUTtDPLLpS0LC11MNt0XazLTOkNz+ltiwOtxMy0ou7moXijtzVxd6H1g2mfmMH01gx/YD/vQk1WV6z1JKaGQic/L7kysVXL4k13376gvA8XFfBAlFGzrDO4pIWUw0Iob2V2cKKk0oHbX8A9vi1VdTSrZPu9HYiHiLaEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aslPFKamwsS2JBQ+nkIatLqI+rrqW7VJW2AJHpFWDSI=; b=RtgV13OBk6CZr1W/Q8P2a8gsdypyQngIWb2Wa1F7uK0S5O7aw6R8/RMS05VFDrkjlqx4n0aBF3oa5JPVIV163xbOvB7uJtMNoi+PFIJCN/zkMWwSrSMsOT2I744lzXFtuuMo9kC5cgWxGQyo9FXILOyCLB1UwmM7rT1DPgV+y9w= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH v3 01/25] tools/console: have one Makefile per program/directory Thread-Topic: [XEN PATCH v3 01/25] tools/console: have one Makefile per program/directory Thread-Index: AQHYh+QzkA5fhHLZ/km46EVDQz/TQa10qXOA Date: Fri, 8 Jul 2022 15:08:46 +0000 Message-ID: <3BDDC997-5475-42F4-AF9C-D996929555AA@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-2-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-2-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4771e505-3bdc-4ca9-18ab-08da60f3c626 x-ms-traffictypediagnostic: DBBPR08MB6316:EE_|VE1EUR03FT046:EE_|AM4PR08MB2657:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /e02x+BS8s+HCJqSL7mhL5SEJUrXc4paS4r//gqxg44OzR12bIkLKAgn2D1zAfEs17JQg0BfPesKjltKCHF/FSnKInQJknu9nRcmWMY6KMRjIDw1GQ3xJ308qHYlfwXReFpmbRBMSYGBULw2jEIo0cLndClU5FsuvLh1jrHaCpG/lubnA/nTXEfBWICu1Xx/GZ+ADbgiOtZuymrLvJpOu8YrwerIr7+H5vXUszY7yu14q9SaOojkKBWp5JqZjyT+SJg93WKsdc4irKCe13uaE3rY/vvOX65jj4fiT6txf+Qzddez/WL0mfku1/t9gM5m+Z3afT/+895/u0x3mlvoI5Fhzasf9P7gDDzwERLHtnpEjadgH8SHd3hXaTwqO9Z1wFLNzsHzrpl9LBGQFTCw4+6yAXPxyx86GYa3IsNzjfwYZ+E9l9aTD2P55Jd+UZ1y7e+PZOMREW++H2swjazhOCc1w96R6ucY0SQd4ds9K/n1z/xWhsH0TYJO+M7/ARGqlMXp2jTBFL9lMBPI9vsDnd/prL4DkPTZsui8Sp6atWuJSPQNp4Td/8xxQHZzaue3MdTxB7SguiDHWce9HqrjILtNaItXWQ48DBuZwkW/uAJSIWvm2U4zIOA6QqWe8lxfALh45acfJrsLod1c1Ky/x+hrMzzIhxtaSSyZZGt1AMy0djHaCv5B2+YykJEsqkCCTMITsyykMBdIjwZUhd48HKGl2k0RyNiL9Ukxc8P764IzAP8L51e4I9Bm0pn8foaidg5RQD9rwvVAn3ZSzAeGSAIekRCqCbRw9Z/pJZi3OqANtRG3Vf8D8zly+na++Y9org31S0/I+lSydMT/i+lCQDCC1Kmo75odEvksawrX6+8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(86362001)(5660300002)(33656002)(54906003)(8936002)(6916009)(71200400001)(122000001)(36756003)(6486002)(316002)(26005)(478600001)(2616005)(6512007)(186003)(66946007)(53546011)(41300700001)(4744005)(6506007)(8676002)(83380400001)(38100700002)(91956017)(66556008)(4326008)(38070700005)(66446008)(2906002)(66476007)(64756008)(76116006)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <91D7459EA762A14F8CD88A52489298EE@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6316 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: dc913dd5-f863-4a87-a42b-08da60f3c13a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F/eqiEh+Lzh08EPU66btzi6kw/R2C0pm86nldIT79hOld3Q6bso3UgNW5a8lT3uhJjlaiBTZkS4C22x7NQrqLn/m+1hQXXIYogKMhT6AnokKi4yBWvH8ur4M+3FMPCgG57Hb5nq4aUOEgnZpkpMOCne53luuuBUcQVFY7W7wkpuNd+tPmStRkN0Su35AQ8bm1CLwZIdkd94SPbLCcn3GxlWst8A7lAd+7bl1+7DRylclbVlXRdmuqgL1kOVZf3E2J/7vh57ndukOqneuWcOvIk1zYRdRo6AuezdgeTPqIQdz/l1dnXEM6cCopKVBUiiBwBq2FWjju9RPEpki9T4u/uNK1mlmQ/FXMXrqV5uMNvis5OgHSmzzGDSYwiYrK8j6kyR/5VoqIP07/PkSGKf7GxN2FBCjtV2NsYOus68pEqNYoNDfF14QWnAcTNdmHWLYuUEH16yNI+cIEgd6Cwhy8JrlCL00TaPxzyIwAs5Qi9IqXb657DYZfLaVmCp4riYAoSc+qeP4A+6I9yJ2IpATL8Q2OWNN5oHIRNW12qGAaS8dsJBS0h8wjnYmMHMtWcMEyT0D5wqXfV8izG9Chpy3ejtGOsSG8ANoOPLvDV6N8P34Y8fmlbjf47MzEWoJA8YHeKqM4D8Z3Y9+bkmjNljC4vvoPhdFGCpMVAJoIXv+UJOIMmE6iESKsTHAc8awjm29ZKSZgehUHe0Il4LMjw1Fh9xJrlTu6wbC+ijF7tYL7xqFMXYLYB9XDDppx7NLviW5ElOF0qOcWciMS9cLvR7RucmEShr18Am/jyG6pZ5dZ0WCAl5PS1V+zRNi+aHgMtJW X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(39860400002)(46966006)(40470700004)(36840700001)(70206006)(70586007)(316002)(6862004)(26005)(6512007)(8936002)(8676002)(6486002)(4326008)(5660300002)(2616005)(478600001)(82740400003)(356005)(53546011)(6506007)(86362001)(36860700001)(40460700003)(81166007)(33656002)(47076005)(336012)(2906002)(82310400005)(40480700001)(83380400001)(36756003)(4744005)(54906003)(186003)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:08:54.3113 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4771e505-3bdc-4ca9-18ab-08da60f3c626 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2657 > On 24 Jun 2022, at 17:03, Anthony PERARD wrot= e: >=20 > Sources of both xenconsoled and xenconsole are already separated into > different directory and don't share anything in common. Having two > different Makefile means it's easier to deal with *FLAGS. >=20 > Some common changes: > Rename $(BIN) to $(TARGETS), this will be useful later. > Stop removing *.so *.rpm *.a as they aren't created here. > Use $(OBJS-y) to list objects. > Update $(CFLAGS) for the directory rather than a single object. >=20 > daemon: > Remove the need for $(LDLIBS_xenconsoled), use $(LDLIBS) instead. > Remove the need for $(CONSOLE_CFLAGS-y) and use $(CFLAGS-y) > instead. >=20 > client: > Remove the unused $(LDLIBS_xenconsole) >=20 > Signed-off-by: Anthony PERARD Hi Antony, It looks good to me. Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 08 15:24:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 15:24:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363542.594129 (Exim 4.92) (envelope-from ) id 1o9ppn-0001E8-FS; Fri, 08 Jul 2022 15:23:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363542.594129; Fri, 08 Jul 2022 15:23:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ppn-0001E1-CT; Fri, 08 Jul 2022 15:23:59 +0000 Received: by outflank-mailman (input) for mailman id 363542; Fri, 08 Jul 2022 15:23:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9ppm-0001Dv-0g for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 15:23:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id facee61a-fed1-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 17:23:57 +0200 (CEST) Received: from AM6P195CA0107.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::48) by DB6PR0802MB2549.eurprd08.prod.outlook.com (2603:10a6:4:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Fri, 8 Jul 2022 15:23:52 +0000 Received: from VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::d9) by AM6P195CA0107.outlook.office365.com (2603:10a6:209:86::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:23:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT060.mail.protection.outlook.com (10.152.19.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:23:51 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Fri, 08 Jul 2022 15:23:50 +0000 Received: from ea1ed28e7f9b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E538BCCA-E71D-4E95-9C44-3F78A923BE73.1; Fri, 08 Jul 2022 15:23:43 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ea1ed28e7f9b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 15:23:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB7PR08MB3737.eurprd08.prod.outlook.com (2603:10a6:10:33::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 15:23:41 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.018; Fri, 8 Jul 2022 15:23:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: facee61a-fed1-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Tc8Qvg1eWsf44+CP4JdRIuvt1FrirVwbwDZ1cVecp5WlaBh/+PZ+1R8xW+dr3pP/jvv4bCslw8320TfYfwBBwY11DN/u9sX7BRotvVKaaVE3BMS40OEloemMQSxGoiVAKhbpkACsNwFTPUqMpLjcaNFrfdTKsRkmCgvcKw3vBPKj46k3ht+GnljZdBnaLvR9SXzw5K/t8tHvd8vw98i36JiwlMVtebdEOyRh0f+N58vA1JqLEVdISXAyU6BZ8W68ZntbN6bS5q/tUxCu8EwLzt+o0RbKyR1i+DGfHA7Ft+B/Nmn6sYfTDePxroggatltfIQB+p1h6f4VCI4J2Rm9GQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=IAJyMViybLDN6FUBNoZebqUXG14f7s8tIbvPTqBBbMwSg6eF/miRpDtjAS/e6fNIcQ1+Cpz7fTStb0WlcshbSOfVAOF3dgFsbRClF9elJOkjy22cGcXOVUylwjpYD/qGRuNKVnWlKG7rKP7++PuO0vhh1wMcwj0+zWJuOQfB0BwhzpQgHDwK59Lt0RhIKL6U6RRmJ+/pXsIt2lYBTOY8CC18YIcJ2YB8Clu8WdP4dVIYBM+AqACEFfRjTZvyA/WbMH67SkTQOdh8vjLV4igR3lk70eV++7Livw4vOrUBypRrUc6jcHLsQAfKgLs9yaLR/Js6L2uUhKgw3re+IHDhFw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=3Ohif10FjP+HGGzi1NrtzseMEcpiYq03Z71eP5BtAj+tCCMrVZRTHaum5lPZFDUXRlARc0YO1o6bbQEUoTa06nmVXazV7tPokjGqD/uktzakVAQ8YgFDACx0FsHyS24kC7BMtvCaSywcMqs9P3q0LmFgGe1SB2gQxnwQ3G8Ul+0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 93219a6f4131b75e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UnQ00g6tlUvyltLAHjgCl5+vzxUSDD2sZsHU5QGLO4QAioJVGn8s0lHRKvsQOb7ne4XowDpJMJ4CM+HhUkjORc27uU5RIynJEoQmVBBCLqnG2UTGDgrZ7bRBqQ5ilN0gWdofmZuG+Jgnpkl5sQbXUQQKcIWvqPEO6bfgeKjxm7BsFlV9cTO09HkmIZVlBqlNDA5ELg4W5VVvj2oVa5lmSv7V0m1RZk+K7nFH6qxs+uBwoVR2j9VY+75yj3UAq/C8zmeP35fbxhY+r3RNq3FbmmKj2DB4Pp1qJVJiGonAceHlGrwkxqtt6tcNy6XBtjpiCMzA8Uv4o9GRA4Afw6zs2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=N8wc5pMlUcaKd13Nyi6uw4MYqj4hREVkUw8rdxi0BiN5tSbjwmLP0ig/40Sxj1FTHKLsc/Ju/HKpTJ3ifpo20fYiq4yGCr6x8Ub/hBu2Arp2zdUnWNcps6ockKz7r1KsBGeAiD1l2srn3Geoot1FE5jF7+ABcSqLKWQrf+BVZwMm4h6mJovLN8n9dgk9CSW6mfPha4c0eK7dj/W3Z3afAaW80/UjOV3w7dHBHa6O3z11a16mA74VXI8SntWzBrG9tXAEatFAy7s1TCSLOaQLor1LJ0gubOxQZY4Yp8n3b1KecLiO+K7T72yvmCRdtBTyJP3mXKjLEWqoMS3YJPX7NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=njPODwD1bMmyTOF+1F7iWEpiew4wqIZuy7x2hUUoqhE=; b=3Ohif10FjP+HGGzi1NrtzseMEcpiYq03Z71eP5BtAj+tCCMrVZRTHaum5lPZFDUXRlARc0YO1o6bbQEUoTa06nmVXazV7tPokjGqD/uktzakVAQ8YgFDACx0FsHyS24kC7BMtvCaSywcMqs9P3q0LmFgGe1SB2gQxnwQ3G8Ul+0= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Elena Ufimtseva , Wei Liu Subject: Re: [XEN PATCH v3 02/25] tools/debugger/gdbsx: Fix and cleanup makefiles Thread-Topic: [XEN PATCH v3 02/25] tools/debugger/gdbsx: Fix and cleanup makefiles Thread-Index: AQHYh+Q7ENxA0CLOIEej7JYABIo4T610rZ4A Date: Fri, 8 Jul 2022 15:23:41 +0000 Message-ID: <7BE4800A-5196-40C6-9D4C-7F6D924E107F@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-3-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-3-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8adff8a1-7481-4cb0-fd23-08da60f5dcbb x-ms-traffictypediagnostic: DB7PR08MB3737:EE_|VE1EUR03FT060:EE_|DB6PR0802MB2549:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6ZUoxHqHmTZy76x6dHYW+v+V7wWidlTR76ocktRhc/wz5SkpkA1Vj+nNGKkIGn9ONmb5O1WG5x7QJYniIoDB0HAcM4Rt0ruk52JrPqg7p+Qo4t9zLoR5msYHBRC7ZQl5EZw9azWaBh/yivUh5SQUwsmTnb6A/56Kk3ElUN8Fzve1wo6M39ge93ookbjOP1xb6czoJKNiVD6u0LEONuIUzzjz6EbwjsVOEv0tvfIwlMLJS5lUdAvi934W7sxS3j8GXi16Dri3DthT1Lo4rbwBhFHz9Eao/IqsMj5MmGQ3HzH/PVCqWTk+J1oEznB1qLGWLs98DLJjSo+09vHOfwtq5rFszAi3pcOiFRyniMhCXLpSUw9Bvf/6GpwFV4BThQR9rtBct5xLXtfyi0XMIGQ1RYYd5nwK0YZfJDGkw3t9CkwOWi2pv2G2c9RuqcWBh0aPTWe7TT9ugOzp/djIHevQFabCZSplVzi51VWWC/FKNwz47k0/qmi1udu00e1M+0u1OzHGnD+zlGStk/6rsBgIX0uJl+/tMWCHAZNZKh73TCFhzMLOUL5uWvY1tezfDICEXrghsqgRhagJZRlAqP8DMKJOCFyNl5pGjoTpM8HsJyriu4X7dguLiC7ZS+8V08PGhTH8FpK7t1PeEok+E90dImnIP6Cm1H851vqQFDo49jnQxYa8AfrelaB7WhuNe762751HmjLm+5m5iGCgimYb+YB7vAnMVhgOV4xlycKviSSVVtcaMlsaQspRpByaAwTDbVJgQqp4fqi4sulMjHrsRZ3jw4H0Sigg787q2I1tyCAYGUbhgGfJCbKUDOCngvmWpTI1xjkW9Gg60keQohBihfUt9wlx12amQ7I1JEDgVrY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(39860400002)(376002)(346002)(396003)(6486002)(66946007)(38070700005)(76116006)(66446008)(91956017)(66476007)(64756008)(8676002)(4326008)(316002)(41300700001)(6916009)(71200400001)(478600001)(186003)(83380400001)(2616005)(66556008)(54906003)(53546011)(6506007)(6512007)(122000001)(26005)(5660300002)(86362001)(36756003)(8936002)(2906002)(33656002)(4744005)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <4D7468D452F8E14892AFA512110BAB8D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3737 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3301dbec-319c-469d-e84b-08da60f5d6d5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yYyex6dLk41bKYSplvLy/hiHvuE+z4WNp+xFZKMzM73/plTDZf5jAXMrzI2mpBfgnCIt+pI+i8plT7S3AyCFVCpw5GZQon1vN8E/jVmfMGC2EFZzX6o2Wi2rBJurj7TbNdCTQIpI7NuVRtsPICrzCQLbP74khO++UPdnGLwnFJj/VKhTzzDwTrLzHwbDF6yG1SOK+iT6NwG6hxnGTbgYs6sCXesBxfFLtP8Si2fJScPWpfcc0zRgVVEKwDVvl/hOLk3pDgsNgqlU0xNCP0iBy5magyHqq9ugq2V4TgdAQaAWzvQqt4NuDADVGAgBXr+c1L3Y4HQGZWkxX7TL7kMwBVfm/WXVYDiDcg1FeoQgN7Y3wDWZn6EP0EZlmJbS4fDsU1gf+Rfo95L683It/vRTeqZaYsWyJi2qceF4zwsD/wScjYJDR0pzBUOHq+z4niTPSCn1lHtCPCdONLSkbF95VDfWCZBW5JpO53pZvAAwC8w9zoBZITemFc7KcjLicLOZpiPhopDLS9WXpovg0jTkpzZiIVOacmqZc3vxomY4F23xI5Tdzpf23o43zNqjyNAaxRpsACRn5OJAPzZX2HvMNzE1SI6AqF4hYKf53sgLFxhE1d4EobVTRxw1E5wSteHDthbbc+ax8sqfNekqi2EZ2JNeBWjqexMpIkx4FDKKwp/c7BGThxd80HurIHaXZSEA+QbfPVF+bnR8Nguf3Sd3007cREVxBsLKa0110pjW4S8DhzuHSJsvSrRCsSpVFJW10MCd0pyrHU24LP4mgrYiKkmv2zKq2/lJEPGMs3sfBW7+lJq3i5OxejQD1c+Z/nzm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(40470700004)(36840700001)(46966006)(83380400001)(478600001)(6486002)(33656002)(70586007)(47076005)(86362001)(5660300002)(81166007)(336012)(356005)(70206006)(26005)(6862004)(186003)(82740400003)(4326008)(8676002)(40460700003)(54906003)(36860700001)(6512007)(53546011)(40480700001)(41300700001)(2616005)(82310400005)(6506007)(8936002)(2906002)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:23:51.1658 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8adff8a1-7481-4cb0-fd23-08da60f5dcbb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2549 > On 24 Jun 2022, at 17:03, Anthony PERARD wrot= e: >=20 > gdbsx/: > - Make use of subdir facility for the "clean" target. > - No need to remove the *.a, they aren't in this dir. > - Avoid calling "distclean" in subdirs as "distclean" targets do only > call "clean", and the "clean" also runs "clean" in subdirs. > - Avoid the need to make "gx_all.a" and "xg_all.a" in the "all" > recipe by forcing make to check for update of "xg/xg_all.a" and > "gx/gx_all.a" by having "FORCE" as prerequisite. Now, when making > "gdbsx", make will recurse even when both *.a already exist. > - List target in $(TARGETS). >=20 > gdbsx/*/: > - Fix dependency on *.h. > - Remove some dead code. > - List targets in $(TARGETS). > - Remove "build" target. > - Cleanup "clean" targets. > - remove comments about the choice of "ar" instead of "ld" > - Use "$(AR)" instead of plain "ar". >=20 > Signed-off-by: Anthony PERARD Hi Antony, Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 08 15:32:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 15:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363550.594140 (Exim 4.92) (envelope-from ) id 1o9pxV-0003Fl-Ab; Fri, 08 Jul 2022 15:31:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363550.594140; Fri, 08 Jul 2022 15:31:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pxV-0003Fe-6d; Fri, 08 Jul 2022 15:31:57 +0000 Received: by outflank-mailman (input) for mailman id 363550; Fri, 08 Jul 2022 15:31:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9pxT-0003FY-QE for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 15:31:55 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30085.outbound.protection.outlook.com [40.107.3.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1846e9ac-fed3-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 17:31:54 +0200 (CEST) Received: from AS9PR04CA0149.eurprd04.prod.outlook.com (2603:10a6:20b:48a::22) by DB6PR0802MB2309.eurprd08.prod.outlook.com (2603:10a6:4:86::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.18; Fri, 8 Jul 2022 15:31:51 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48a:cafe::38) by AS9PR04CA0149.outlook.office365.com (2603:10a6:20b:48a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 15:31:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:31:50 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Fri, 08 Jul 2022 15:31:50 +0000 Received: from b04c9f083286.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 84265E87-1B6F-4057-9C06-9D22E3656D0B.1; Fri, 08 Jul 2022 15:31:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b04c9f083286.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 15:31:44 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB9PR08MB6890.eurprd08.prod.outlook.com (2603:10a6:10:2a8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Fri, 8 Jul 2022 15:31:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.018; Fri, 8 Jul 2022 15:31:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1846e9ac-fed3-11ec-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a0p9bUiJNa3zDOVQwydo2A3q5my/XzhlmMt3/Yj+uCjsSyIrwVzN0z3mW4bD2tgUEEXP46eNJxjH2SxtT6FX8wB0NMt3qos0Wy3O6u6CTRaiRUs37oa9XuhJ6AMZ5jQI/JoucHVD47TnWhw/mUglJpTlO27Q25zVZAKQ42Zip8fRWvIUcLGrFSKgteh5QkIffbvU3KzgkxnMCy1YHzoLQpvBL2NxqHlXm3cJ24T+uIFLEIx74YVyopbQaNfWdREuvAwwPBjzJerB1KZM1GMK3Ws8Qa7BMeFBPzlA7bnQGhUS1XZ6h93s8UNe/8FIZs7ZB4SNKb5DFCD8pCwAIDerfg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ezPJzAsXEwac13tjxHuuerF/cCo2GDBmbk3Ctdu5I0s=; b=CqQBtJPAx0i7cU4sOYNrD5lTHZsAEfx3nKm1ZBWvXivqTHlfW5TJXuXP2pzXUfaplloVd8DfaacmMV5KdqB51fOjdV+0szpXxm2weRcFaMANZxCOdcizQa2l/r5RNiL/8hdg3/Vnm3p26L5N6v8W7vZ8129LgwOov5w4LZw0+TNXBYYBtZG7pdIYMncY/DxBvDSttfvFv3egKPxHjchpB+vRXwJHdV9CycjYXGCcNs7mE2El6l6TwbIgGaQTTDN4BjHBiuSQgy+gr4YtKNLo4MXvC/U9KzMbRIE6/znuNtQiw3jSe6bSP1yrx0mqm6v03mie8ZXsJTjI5Ihugq9jfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezPJzAsXEwac13tjxHuuerF/cCo2GDBmbk3Ctdu5I0s=; b=jqs5qZ6EgO7DDGtTQCxLdZUsQFE2HMOj6mNe7GYy8iTimnhedbCALvZmnbxwIfeMBbuFj3sGqzIY1Rn8csz8a56D0cyZZSKozWwXiNhVi8ozvXlSbEcyu+gQppB/HolyDDU64SYIKBH2MwmIEB/BluWA+Z3A22tnfnpSQQszrVY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 5a6d29ce09465e74 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aD0R78upZF+cMBcSqw8v1wpmdlI/lYqO7+IFGBJ+npmSZOw8QuD/53epuu//XHcZ1ZBIA5Gan9QAVsJQ29U8iwbQQJhtysHz5V3QZ0nQ81n3nmpsYSdYMbqkImsvsQS2BvxG7LSBlppAbr5pHBTlCuts86sfycWFFfXVDNUMVgcW+L/6vroN0BIYLea6LEvxp0zf7yx9L6nzjfNFKjZJxWx7hRcKTPWlhypW7eDa4M6RDm2sxnJcgzsQC5Vtx9XFNDGBUGPbobaeahIDmiYq01dakLkqPbQiK6Xi3nMhfMkx4VVoZ7Hpm/cNuRhBlCp2iGIlfB1QpKGM2heJhc6DCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ezPJzAsXEwac13tjxHuuerF/cCo2GDBmbk3Ctdu5I0s=; b=HrsCqymjefkQNzJ8WeTLrty9Ng9qKLLZlhWIB0guIs4PVLk6aiQ+rHgJqpZ/yxaaZsjLR1c7hsO1AID+WqtWUqi4CbJg1YMtPJCuTgxdKzjQEldzOvL0s52bcdP8AdD1rkXOC5zQdA79Dc80k59b30KcCCZpcRIl+qT6JA8Lmnxa516as7sESIUTDeixrD6Wy0EqHLteXbiezoNlkcyhaPCu1/uguNmlQ+XW3TsFVOnw3xLl8vMX94bALg432myHbR4Ir6qigwkOXjpmUICLDCXBGrBgBIjUrdUozEBuhIXoOp4nj7q8TmUip9KW4QofhPd+w1VeMBtnr4N3BFdICQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ezPJzAsXEwac13tjxHuuerF/cCo2GDBmbk3Ctdu5I0s=; b=jqs5qZ6EgO7DDGtTQCxLdZUsQFE2HMOj6mNe7GYy8iTimnhedbCALvZmnbxwIfeMBbuFj3sGqzIY1Rn8csz8a56D0cyZZSKozWwXiNhVi8ozvXlSbEcyu+gQppB/HolyDDU64SYIKBH2MwmIEB/BluWA+Z3A22tnfnpSQQszrVY= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 03/25] tools/examples: cleanup Makefile Thread-Topic: [XEN PATCH v3 03/25] tools/examples: cleanup Makefile Thread-Index: AQHYh+QvDezl/6q3/kugY7JDjo5uuK10r90A Date: Fri, 8 Jul 2022 15:31:43 +0000 Message-ID: <716DC528-89EB-44BF-9424-31F13C5DAAF8@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-4-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-4-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7b46d36f-5456-4a50-258e-08da60f6fa77 x-ms-traffictypediagnostic: DB9PR08MB6890:EE_|AM5EUR03FT040:EE_|DB6PR0802MB2309:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JQp82RqAxdrYmwQp9YGHXzRsDVav+sWm+CPRZRhkJGezfReX2CNujdNwPzqC5HyXC0ZAXGafsYnso5sT9STqCIsKaxwyGXRglZm9Ql7A9rrvp1mwWbAsQpxVVB1RaPPkfgwbwUnvsoORbnzcUcx8GfD87hJAqA+NGhk9w3qaDpryRL9xHVwCW1K9ElbV1UjPvIvJtLzYJPIoVc9i604jApQUF7zdktEqjWzQvqeDbXSFas+03awmWY9wer6LB9quMXmA3j8HG4mwvc4W+PBjGbv/075nM7WTa2GcLxSAe5fAF1LURTUdlo3RVX7h3WqAuGTkdJ0BcZDC8y5rUHHUoGEVeD6eJ5BbOJ2eos2P9cZQAkz4SmWwf6Sg7pdlpgmapZyE1kYkxbtMijCrTXRkKDLWYwQU/JxR6XQ1qKnvFw/7k7LCWXMRbEGkswr0qn4lUP6E9MmJOEz0/vwKL5SgTWh3d37KEb5rAq9xVU/IKQ6BTo8zfmWgHBURj6YqZktQK9yP2Q1mYS6ZrPw/tFOOa/QfPd3vtTbGTCqlnrxnfwzW9Xbikt70Ujn+7fIcQah1PgyS7eVNSgAWGClqGOPtrG/FpK2u4z5d5PrfmNxmG/QNtaDMjOXJpU0mb51wSruaEf6mAYgN9SV3yvXduMg/vV8SHZ5blFvyS59ilD2gxfz/Y+roPGvQO6NlOchKIRy4ZQrdOyLGhQ+Zbeni8YWLX90FZ1RfueVkFU20FwdG7r27V+bJW6Cwcgznpn6bODKAjnQ5Ztac4ax1ycYHH08qTTaUv1dRC3XzTVMLgh/8hMRmQgnCiBd7K2zU6o2iCGxmk+3+0LXA9cK6SbsD088lIHdkumtl9a7FmMAHn2n3Is8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(366004)(396003)(136003)(478600001)(6486002)(26005)(6512007)(38070700005)(122000001)(54906003)(33656002)(5660300002)(71200400001)(86362001)(53546011)(6916009)(41300700001)(8936002)(4744005)(316002)(2616005)(66946007)(66476007)(66556008)(91956017)(8676002)(4326008)(38100700002)(36756003)(76116006)(186003)(66446008)(64756008)(6506007)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6890 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b70fb872-46ab-4ac9-7c61-08da60f6f61a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QuR1Wjkt0qdEGV0Zn1z6JFGuYkjtWKdTMJZrcI75uMotqy7GNt7uCbqjiwC/ioZULdp5LUT/xBcoAu3wLW9r4N7OgLonu7dVnJzBYLwNJmTYX/rPDVin8+pgTAf6nOV3VNx6QY3as3uP6eQfHiuIl/kgfaOyH+qHE9zdlp0Bvi7vNDwL5vLk2qWsdQDKHubms859eEvbGBef20z5xOh0ujbGkH4b85L4H5Bk3VtdzJwy0DwhbgL9yyBWParH4BnHgT6qo6wPHfnFemlZsnLbtFKIzt+6NbMMrUP6l2kEJkdoHbZJiNbYnh5u4pog3Vvl2bfMwKBsvcE4jzuZhSnvdK+DplhOaSLNtkWMhaITivCzlVu4+NEicMOarsLFyoaL0c9SIN6zmWiBue6VNYSD4VJXysmHc2BR3c8GmxmMl1ZH4zixbjrbDiP8Yo6YDB3IZF3Nkpm3W02KjNQXU17gPZqxtcrk2Mqz1EGJDtT5um2J4gy8dYYejNKzjCtssd89Q+vlYwN2vHzCpP6sHinpB/+rHMu7hyqm32sxHa5WygV7JtoH8DaFb93+u1nDXE7kKCyDr/BTbn0c8mcV3Bovu8VW9udazXmVf0L2g/8tkc+mXIa1oBUn8lBlwgLUqqKqZJCPWUeeJsKKHaNrSbRh2GfertYtuQQiDwGtHr1SVeHS+ttcb5zs2JjnHEXgjEy7SVuuujqvaIhiKx9NceChQ9inCQg+xIGk4SjTB08J0wN+bM33YR53aBrp55EhCFxHSdDHKEqvxYXmW8TeINMpSryCBzwVBwsDxHqjuAiydu/BJSDsk8HJ7j8I+RzWWA3O X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(346002)(136003)(46966006)(36840700001)(40470700004)(6862004)(478600001)(82740400003)(4326008)(36860700001)(8936002)(81166007)(6506007)(33656002)(5660300002)(356005)(41300700001)(70206006)(53546011)(8676002)(70586007)(4744005)(40480700001)(2906002)(82310400005)(336012)(186003)(47076005)(54906003)(26005)(6486002)(6512007)(40460700003)(2616005)(86362001)(316002)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:31:50.6055 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7b46d36f-5456-4a50-258e-08da60f6fa77 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2309 > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Don't check if a target exist before installing it. For directory, > install doesn't complain, and for file it would prevent from updating > them. Also remove the existing loop and instead install all files with > a single call to $(INSTALL_DATA). >=20 > Remove XEN_CONFIGS-y which isn't used. >=20 > Remove "build" target. >=20 > Add an empty line after the first comment. The comment isn't about > $(XEN_READMES), it is about the makefile as a whole. >=20 > Signed-off-by: Anthony PERARD Hi Antony, Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 08 15:39:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 15:39:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363557.594151 (Exim 4.92) (envelope-from ) id 1o9q4c-0004Ud-3O; Fri, 08 Jul 2022 15:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363557.594151; Fri, 08 Jul 2022 15:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9q4b-0004UQ-W6; Fri, 08 Jul 2022 15:39:17 +0000 Received: by outflank-mailman (input) for mailman id 363557; Fri, 08 Jul 2022 15:39:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9q4Z-0004UI-MB for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 15:39:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e144222-fed4-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 17:39:13 +0200 (CEST) Received: from AS9PR04CA0096.eurprd04.prod.outlook.com (2603:10a6:20b:50e::26) by DB8PR08MB5353.eurprd08.prod.outlook.com (2603:10a6:10:112::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 15:39:11 +0000 Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::e7) by AS9PR04CA0096.outlook.office365.com (2603:10a6:20b:50e::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Fri, 8 Jul 2022 15:39:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:39:09 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Fri, 08 Jul 2022 15:39:09 +0000 Received: from 714279917464.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7F8CAC37-E1AD-4F2C-9CCB-16B2DB80A2B0.1; Fri, 08 Jul 2022 15:39:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 714279917464.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 08 Jul 2022 15:39:02 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4264.eurprd08.prod.outlook.com (2603:10a6:20b:72::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 8 Jul 2022 15:39:00 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.018; Fri, 8 Jul 2022 15:39:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e144222-fed4-11ec-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=k+ivsmD+6Jjv+xJLizYR0BYTYgR7A7VrfUkWL3FWqJl4kNsfAG00bjgWjMfOWHFoqOEScLlOEXVsbYtvRvDBKkFlD6KfjOmX09YIPlIMQDHfadwvhXMn491yUafkiMuQW3LZxoT43/jci67l4YAolejpCJrVh5MzIPdluvFxtE7+UXSFlp56xWTVKpQd8EiKK3SAQYV92TmAftEZmsnEG5UcI82xEdM8ArvYDNxUuSQjJ7cj4gLY+VvMlRyOR5JQAVVHDl0eduRIwB7/ALPdIGNEtxq+HubStoXlNSuiTCzNigjVvgU5L1OXtV1RzuPI8o0pxtumRdMbSsALbnOhig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oG4PfVFd5kpukvJPYaICv9heKExCAk04Gug1qemmM24=; b=AJFEzSfowf5NCRiZpmdood4zii22h8F3Wm/iHMvxebRKgqUIL/V6KY4ds/vWyvH3QJ/Psrvrbo51sS6y0hiujWD7gda7i+RWjSUzi/eaJvvncjCvrxEn7C0OUdIf3MlnFDxGoOezIVsbnL6oMdhYX1de3jh6oIR5KypXouOHy3fIr621fRIp3PuMUGCyuMq4GdeIWxdQwe4mOeD9gw9OlG5FiCAY3Ii8iryLrY62sReWwhoP6F8FyG5gCvfaZrhGSKBqAl/ez7Hjab8Y+lHLm+sJ36nfJfXPghJ0w1mWFmGOvh414Dzv+Q2ylkcCcRGy0VVe0uK8XKIv7BDmh4cX+A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oG4PfVFd5kpukvJPYaICv9heKExCAk04Gug1qemmM24=; b=DnejgJCrFtUQDK3Js1YmEId8wN/gUxcBeOlzjXXTWnAkj08V97t/LAAuCTmBR1uJstL2DY9hO79uNbWQR0vZsL1LydtXf1kBnvvF06rC9Wr+Fc/tAG61CEuOjTOOJJWFp1jb6MskMqBid7XAAgNvZaT5irrLYFB83vHgfcZUFrw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f908982e0e550806 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UiVeqKB+QvhGTq8cHrWDIfsVlzBjL0U1Nhjce4QzOh96uYV9eMGcqmD+IWUsH3xOFkEZsaftCNu5+tp+dFW1YGXlHodSExONS4SoPBtVWQmQxcv0cDmL+f4xK9g8c9sRVIahWSeU9BiZ23jXMwA6KIezoX7A9UuIUQ7V80MY2FmvfD0gUjhI1sXo5heLT093aPmh07YDH3STsN9Cdn5Zqp60Lnurus3qx/7ymo2PItpz3E6FyfaK4hMbD4SU9VbTYExIYtcOjTUQ7gzsE+qVfhWV1SvZnV4RMHTuQEu7GxEYJEyY+d48+Xx5rrUlLo7VIVMGYXodidtZbs4byO1PLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oG4PfVFd5kpukvJPYaICv9heKExCAk04Gug1qemmM24=; b=i4tUtiQtcwTS1wiYe0F3NGjmixN79R6kzevb8M2Iqevi7+dZqln4CizMuXb2+5Et+F+LLEx6NziR0M0R8lRfzO0ODv+MTAnc83JA1Z+XoU3r26G0PxX3oxHD+mE0s4rsb2qmur1+HXIP92Wy0CgJw6GegZAb/BwgR7WzEapBSKdTKvJlJBvLjPWt8eoqDy5xK+ZByPH9fnO04AXFXbXeT3kwuQWH//DlLvqea+oPv5X98aiF97ScmRprTJUdPvGfWR5Kd8z/bGjK85QY17DWYF3wLkj+Tb+wCjkD+CxekWxy35ZgNf5TN1CBMh1DvizE0tKqUTlUm4gCcL497x1+7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oG4PfVFd5kpukvJPYaICv9heKExCAk04Gug1qemmM24=; b=DnejgJCrFtUQDK3Js1YmEId8wN/gUxcBeOlzjXXTWnAkj08V97t/LAAuCTmBR1uJstL2DY9hO79uNbWQR0vZsL1LydtXf1kBnvvF06rC9Wr+Fc/tAG61CEuOjTOOJJWFp1jb6MskMqBid7XAAgNvZaT5irrLYFB83vHgfcZUFrw= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Thread-Topic: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Thread-Index: AQHYh+Qt/49JLdoEv0uAADgNQkPLF610seaA Date: Fri, 8 Jul 2022 15:39:00 +0000 Message-ID: <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-5-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4cb6ed2d-0258-4ff6-b1fb-08da60f8003a x-ms-traffictypediagnostic: AM6PR08MB4264:EE_|VE1EUR03FT010:EE_|DB8PR08MB5353:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IURZZQMUi/uJ953P0yqHJSmwesYaB9HfTciBwEZXz//lX8Ecjb1fJk1KaB9Y7RT4U+bs8DnHFTKxi08nkrNbAJ/URdnSn6LDgnfg7BvdIacqqb2MQKL3O0ZWR4B6oDbxOriW3jKSORmZ8N/0Fn5FvfmsuI2zsZSJKQzUVCjU1lztGOOorOlBwhX0BKyDSZzIsru3CbNCHuYs+UqcvL57UxDdgeyvraIGlNwTUazXvMHrBDzZTh8qj0TNJa1V9tKs8PynTxe6rbLd5MQsUoY1XuObUx/BcA0aqu1bQ2yvJiRlONR5HmKvuO2rKHc05FBDL/P8m4vNnRwqbp8vdkU36CXlDpgI7gVR5LXbzWCf1hT9aV+tMVfkNNbDjLljO1nAKefCNu8gv+IM2n8sUi6cXqqL5ewwrRaBpF7KgzmSKQx1Mn1IgX2P25e79akOzU1PgCFyRJiu++za88eDC8m38pz1VclgF8AFuM+n4ZBts4f7UqqzQV51I4DyFOs9Cw5x8Pj0J6UcnKtu4Dze1HQFKJyXBYTdfM6wb8pJn4JTc0+8I68iQiTOmvT9HXchAq6RmK1+a5/wh/MV6z22550GeLEKlYFfzrI+MGMCQE5Adb/CIpS0U432mTkWqzd6kxfUbRf5XqLJbNzgHpud62Rss6hOWgHZh7HTu2DjGal3XaLr9QicqXORS584f7PvbYvZrEYQa9QPg4rwKmHLZoLE7uL+YQt5FYeW5C1ggQItffIO0cWRRQMciubwuUkhSAyeg0Nb4XYv5jwXurVNqFmgOFxXedJRbPMIhgpCQrDHNAVov8h4YbCRMT2HGZz1GMXYUUf+GlBBe6/JSovpdo2oV3ea6Eo5RYeDN7s9p9RaW8E= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(366004)(39860400002)(33656002)(36756003)(478600001)(41300700001)(6486002)(53546011)(2906002)(316002)(86362001)(71200400001)(54906003)(38100700002)(6506007)(6916009)(122000001)(8676002)(64756008)(66556008)(6512007)(66946007)(91956017)(26005)(66476007)(5660300002)(2616005)(66446008)(4326008)(186003)(38070700005)(76116006)(83380400001)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <07EE36EEC82911448BE50038197F7180@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4264 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bcacd94b-af52-4927-0386-08da60f7fa8d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TyB7wdKtq2ofvtV0v0IGVB8Hut6VkI5DA+Il+bGIU09MwQbGhN7vSS/XCkB/8cxL1LQKs0pHA1kuJVA+j9w2whwAvrTTCCDgEkyr84b4XoznWIFN7NhY5ewVI+0MU65UH14w2jkhDyFULtgym20m6L/mTDGOafTEceY7lHqPcCnfBjD43EUuCe2C45PnPAcq60vJkMK3K//sGKged99EqoMJZGO2NPtpUoyGpaBaq9OYqdCN6bZUt+SA4t+agQCcGXY00yNO0pImAD23bIOTN8gv46UxPXHJf/vPgznXEfX5iY2YLLthpFsfa/Wi4ct7gDLRwUSd3UUrjGoBBy8JDuH286hiOj0pmkmsHtjC9moyPkVmtYZuZZeR/m4y7QlL4cdOpOha7W+77jvSC5yFFXJbiuvDHJMHjn3A99E2rz1Syol4PJJYME1E+4OFaTjURxe4TDjgkgSGOg3k7HjzhTE/dpYng3sd7g+kIa3ZjR4iSdwhqMIhh3MNmt9jVXPk4Pj562cWPRWBUIErJdTH+QihkxhilB1Z5+X1qXXszXWmOezfn13GvH7GtI+KdrbqJNw1SlsHlstrcBqZdbRUsTKhUlKe9vEwgyNMcDTRq+ZrVISUfPLRnUSYVm1u/xmyfCEeKPUYbSnGNmVcOV7se/vcr33PTCMcscefr1l/Pvr4yxSn+QhV5bIl5aX6uN3W2bcJCB7xSyGHXLWxXJ/6soic9bS7dBJ+VqXPCEUdQnLiiOanJJTXMwcvcOkVbxs0RtEfEaF0YUd8EbVO10lYJ+LvYjFRgxlBn6rMpvMP7vzPA6D11cVWS6b2t4NOuvs8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(40470700004)(36840700001)(46966006)(2906002)(478600001)(6486002)(53546011)(82310400005)(316002)(40480700001)(86362001)(54906003)(36756003)(33656002)(6512007)(41300700001)(70586007)(26005)(40460700003)(6506007)(70206006)(4326008)(8676002)(336012)(83380400001)(356005)(47076005)(186003)(82740400003)(36860700001)(8936002)(5660300002)(6862004)(81166007)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:39:09.7255 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4cb6ed2d-0258-4ff6-b1fb-08da60f8003a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB5353 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBTZXR1cCBwcm9wZXIgZGVwZW5kZW5jaWVz IHdpdGggbGliYWNwaSBzbyB3ZSBkb24ndCBuZWVkIHRvIHJ1biAibWFrZQ0KPiBodm1sb2FkZXIi IGluIHRoZSAiYWxsIiB0YXJnZXQuICgiYnVpbGQubyIgbmV3IHByZXJlcXVpc2l0ZSBpc24ndA0K PiBleGFjdGx5IHByb3BlciBidXQgYSBzaWRlIGVmZmVjdCBvZiBidWlsZGluZyB0aGUgJChEU0RU X0ZJTEVTKSBpcyB0bw0KPiBnZW5lcmF0ZSB0aGUgInNzZHRfKi5oIiBuZWVkZWQgYnkgImJ1aWxk Lm8iLikNCj4gDQo+IE1ha2UgdXNlIGlmICItaXF1b3RlIiBpbnN0ZWFkIG9mIGEgcGxhaW4gIi1J Ii4NCj4gDQo+IEZvciAicm9tcy5pbmMiIHRhcmdldCwgdXNlICIkKFNIRUxMKSIgaW5zdGVhZCBv ZiBwbGFpbiAic2giLiBBbmQgdXNlDQo+IGZ1bGwgcGF0aCB0byAibWtoZXgiIGluc3RlYWQgb2Yg YSByZWxhdGl2ZSBvbmUuIExhc3RseSwgYWRkICItZiIgZmxhZw0KPiB0byAibXYiLCBpbiBjYXNl IHRoZSB0YXJnZXQgYWxyZWFkeSBleGlzdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkg UEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPiAtLS0NCj4gdG9vbHMvZmlybXdh cmUvaHZtbG9hZGVyL01ha2VmaWxlIHwgMTYgKysrKysrKysrLS0tLS0tLQ0KPiAxIGZpbGUgY2hh bmdlZCwgOSBpbnNlcnRpb25zKCspLCA3IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBh L3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9NYWtlZmlsZSBiL3Rvb2xzL2Zpcm13YXJlL2h2bWxv YWRlci9NYWtlZmlsZQ0KPiBpbmRleCBiNzU0MjIwODM5Li5mYzIwOTMyMTEwIDEwMDY0NA0KPiAt LS0gYS90b29scy9maXJtd2FyZS9odm1sb2FkZXIvTWFrZWZpbGUNCj4gKysrIGIvdG9vbHMvZmly bXdhcmUvaHZtbG9hZGVyL01ha2VmaWxlDQo+IEBAIC02MCw4ICs2MCw3IEBAIFJPTVMgKz0gJChS T01CSU9TX1JPTSkgJChTVERWR0FfUk9NKSAkKENJUlJVU1ZHQV9ST00pDQo+IGVuZGlmDQo+IA0K PiAuUEhPTlk6IGFsbA0KPiAtYWxsOiBhY3BpDQo+IC0JJChNQUtFKSBodm1sb2FkZXINCj4gK2Fs bDogaHZtbG9hZGVyDQo+IA0KPiAuUEhPTlk6IGFjcGkNCj4gYWNwaToNCj4gQEAgLTczLDEyICs3 MiwxNSBAQCBzbWJpb3MubzogQ0ZMQUdTICs9IC1EX19TTUJJT1NfREFURV9fPSJcIiQoU01CSU9T X1JFTF9EQVRFKVwiIg0KPiBBQ1BJX1BBVEggPSAuLi8uLi9saWJhY3BpDQo+IERTRFRfRklMRVMg PSBkc2R0X2FueWNwdS5jIGRzZHRfMTVjcHUuYyBkc2R0X2FueWNwdV9xZW11X3hlbi5jDQo+IEFD UElfT0JKUyA9ICQocGF0c3Vic3QgJS5jLCUubywkKERTRFRfRklMRVMpKSBidWlsZC5vIHN0YXRp Y190YWJsZXMubw0KPiAtJChBQ1BJX09CSlMpOiBDRkxBR1MgKz0gLUkuIC1ETElCQUNQSV9TVERV VElMUz1cIiQoQ1VSRElSKS91dGlsLmhcIg0KPiArJChBQ1BJX09CSlMpOiBDRkxBR1MgKz0gLWlx dW90ZSAuIC1ETElCQUNQSV9TVERVVElMUz1cIiQoQ1VSRElSKS91dGlsLmhcIg0KPiBDRkxBR1Mg Kz0gLUkkKEFDUElfUEFUSCkNCj4gdnBhdGggYnVpbGQuYyAkKEFDUElfUEFUSCkNCj4gdnBhdGgg c3RhdGljX3RhYmxlcy5jICQoQUNQSV9QQVRIKQ0KPiBPQkpTICs9ICQoQUNQSV9PQkpTKQ0KPiAN Cj4gKyQoRFNEVF9GSUxFUyk6IGFjcGkNCj4gK2J1aWxkLm86ICQoRFNEVF9GSUxFUykNCj4gKw0K PiBodm1sb2FkZXI6ICQoT0JKUykgaHZtbG9hZGVyLmxkcw0KPiAJJChMRCkgJChMREZMQUdTX0RJ UkVDVCkgLU4gLVQgaHZtbG9hZGVyLmxkcyAtbyAkQCAkKE9CSlMpDQo+IA0KPiBAQCAtODcsMjEg Kzg5LDIxIEBAIHJvbXMuaW5jOiAkKFJPTVMpDQo+IA0KPiBpZm5lcSAoJChST01CSU9TX1JPTSks KQ0KPiAJZWNobyAiI2lmZGVmIFJPTV9JTkNMVURFX1JPTUJJT1MiID4+ICRALm5ldw0KPiAtCXNo IC4uLy4uL21pc2MvbWtoZXggcm9tYmlvcyAkKFJPTUJJT1NfUk9NKSA+PiAkQC5uZXcNCj4gKwkk KFNIRUxMKSAkKFhFTl9ST09UKS90b29scy9taXNjL21raGV4IHJvbWJpb3MgJChST01CSU9TX1JP TSkgPj4gJEAubmV3DQo+IAllY2hvICIjZW5kaWYiID4+ICRALm5ldw0KPiBlbmRpZg0KPiANCj4g aWZuZXEgKCQoU1REVkdBX1JPTSksKQ0KPiAJZWNobyAiI2lmZGVmIFJPTV9JTkNMVURFX1ZHQUJJ T1MiID4+ICRALm5ldw0KPiAtCXNoIC4uLy4uL21pc2MvbWtoZXggdmdhYmlvc19zdGR2Z2EgJChT VERWR0FfUk9NKSA+PiAkQC5uZXcNCj4gKwkkKFNIRUxMKSAkKFhFTl9ST09UKS90b29scy9taXNj L21raGV4IHZnYWJpb3Nfc3RkdmdhICQoU1REVkdBX1JPTSkgPj4gJEAubmV3DQo+IAllY2hvICIj ZW5kaWYiID4+ICRALm5ldw0KPiBlbmRpZg0KPiBpZm5lcSAoJChDSVJSVVNWR0FfUk9NKSwpDQo+ IAllY2hvICIjaWZkZWYgUk9NX0lOQ0xVREVfVkdBQklPUyIgPj4gJEAubmV3DQo+IC0Jc2ggLi4v Li4vbWlzYy9ta2hleCB2Z2FiaW9zX2NpcnJ1c3ZnYSAkKENJUlJVU1ZHQV9ST00pID4+ICRALm5l dw0KPiArCSQoU0hFTEwpICQoWEVOX1JPT1QpL3Rvb2xzL21pc2MvbWtoZXggdmdhYmlvc19jaXJy dXN2Z2EgJChDSVJSVVNWR0FfUk9NKSA+PiAkQC5uZXcNCj4gCWVjaG8gIiNlbmRpZiIgPj4gJEAu bmV3DQo+IGVuZGlmDQo+IC0JbXYgJEAubmV3ICRADQo+ICsJbXYgLWYgJEAubmV3ICRADQoNCkhl cmUsIGluc3RlYWQgb2YgLWYsIGlzIGl0IHNhZmVyIC11PyBXaGF04oCZcyB5b3VyIG9waW5pb24g b24gdGhhdD8gVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuDQoNCj4gDQo+IC5QSE9OWTogY2xl YW4NCj4gY2xlYW46DQo+IC0tIA0KPiBBbnRob255IFBFUkFSRA0KPiANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 08 15:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 15:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363564.594162 (Exim 4.92) (envelope-from ) id 1o9qN0-00085i-SK; Fri, 08 Jul 2022 15:58:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363564.594162; Fri, 08 Jul 2022 15:58:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qN0-00085b-PK; Fri, 08 Jul 2022 15:58:18 +0000 Received: by outflank-mailman (input) for mailman id 363564; Fri, 08 Jul 2022 15:56:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qLY-0007T3-KR for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 15:56:48 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2055.outbound.protection.outlook.com [40.107.243.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 911815c1-fed6-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 17:56:46 +0200 (CEST) Received: from DS7PR03CA0352.namprd03.prod.outlook.com (2603:10b6:8:55::32) by BYAPR12MB3287.namprd12.prod.outlook.com (2603:10b6:a03:131::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.17; Fri, 8 Jul 2022 15:56:41 +0000 Received: from DM6NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:8:55:cafe::bf) by DS7PR03CA0352.outlook.office365.com (2603:10b6:8:55::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21 via Frontend Transport; Fri, 8 Jul 2022 15:56:41 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT016.mail.protection.outlook.com (10.13.173.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5417.15 via Frontend Transport; Fri, 8 Jul 2022 15:56:41 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Fri, 8 Jul 2022 10:56:40 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Fri, 8 Jul 2022 10:56:40 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 911815c1-fed6-11ec-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WpRt3J9Ij2zBL3S/SeMc8LkgGmvl3mhNXHSRZUCRtQ+C4svFqiGwXr9HwO2YzwjweeGpKnn/wbGKO5Bm8nMiOERVo4EuYO9GXSAmivGplU11bMCACfqhqcT1NMywOCNgYFVmNLtsBhReII+sylB65sJ0SysPr1hw19Is8ksDisa3tc/1xI018qsIk4toP7R/HK+yXROesw3kDf6rIbHu5rkAcG3xGSTUh/t5k0zudEymsgBJ0whqprYK1YXSlZ+DZtqhcGnSfsVPL/uxJMwuGzb/OuoGBvMq3+Fd0kS8nSUvFR1KhX2Y9klxirrfMMkV+qTBBFOQm7Kvw1QpiXdq6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4YJM34CVvXAVx0+lmZ8dGXo6zj0lalqIn4kh4SnWjsY=; b=DhIAzsMdmI8wt/u0sVZlnnUzuY7ws9v8HGyc4Yl7I/GYasYwhdNe/7O3UXFmR2411i+dvllMhCuIBPz3S8d+rURNXhPqAbCljxHtwbrxeqiN32PKeamIeyb2hWUq2U4lcnQxudd5y8mkbdzyKT4CN9PMjbnAbPSLty9M4MJdVsf4NGCKhA6WvPAhtlDKpNgt9Ic3gp/IiTkyASn+aAFtQKrdcKhXtkg/h2Upt9Z0Azqx2JF3QH8EFp67csv/CdwveyCmtmOuYzmdoLFAptLwSHhwavTKEUAPXRTLgO1FthNvcQHpKojihngSR+ad1dmdnm5emrPylPKs7dfkD3U0dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4YJM34CVvXAVx0+lmZ8dGXo6zj0lalqIn4kh4SnWjsY=; b=yHx5hJsv0WcQkwWIj2GQpsc1sSSf3Z1TatLXyLKmEu+pZXI5OU+zoMj7s3vNTTwSkciyMt+VbXp9+1ixHONI9xnooquoOdGpTv3paLAGt+zD29nduANkic6KueTDfuSAyFcL4N+P26ZEuNdE5PNk3J5Uan1wAocjsBAOarJjMuM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Date: Fri, 8 Jul 2022 08:56:39 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou CC: Stefano Stabellini , Julien Grall , , Doug Goldstein Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu In-Reply-To: Message-ID: References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f95cbff-5525-4974-9c4c-08da60fa7335 X-MS-TrafficTypeDiagnostic: BYAPR12MB3287:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DCP+FyPDxrABPXSnr4n2p6W4X2tQE/tWaO8su141gB79MUEz7pJbQLM1Kpty?= =?us-ascii?Q?Nj8qtjj37KmvWe5Kls7wYaHyr7Ttpzf7GACsCYooF5LQvKjEqFSiSKlc165Y?= =?us-ascii?Q?kc+ZmeJt24gVOCg+UssumEVwSyQcaf+ol4w5vKppoo4e5LUel/RB2TP5jzkv?= =?us-ascii?Q?P6zftD5RRoQM65snIXaZN/E4nWyImWk/zFdWdTqwf+bqGGa7xkpKXWzk0sQk?= =?us-ascii?Q?2c9YGDk55J0dme8nyj+RTS/iNC+a3Zh0qvZC0ZcCwylpHxaY24113nYstmOt?= =?us-ascii?Q?Bl4h0qAg9/H5YAWh3CXTr2mnRQ7si/haRg3trJbJ3EkHfUwVcK5NIYSxNB9U?= =?us-ascii?Q?IL6Ql58dFHzCGM7GCsuFyotbpKtZAwBxvP2gBZmcu/9zoupZpOVsqyVSgxAk?= =?us-ascii?Q?10UOnmiTm4myFoRjqFoNZjuLx3ClRg6xroihw1SwTkgmeNI0vlNdwT4iGpfR?= =?us-ascii?Q?p6fO8rqfxp2+A/4wadZZNRf6fkqcvbSFlxvCjEhZJjoGq45ZETlRpKzaD9ri?= =?us-ascii?Q?2rcD4Cekp7ZlkbuhXJ9FRldcd1K2Vi0zHNAbpKK3ezGtgEKkEuTBjwxKQfbW?= =?us-ascii?Q?A7cmyoHhSsgmFeX+I9WTiiGVXRiTfeQqq7+XWDT9FOiizEnJbNmhEkiGSygx?= =?us-ascii?Q?l+ejU/iZYA8IDa9IL2ejeotVgtiuim/YdNfkcygNqo9a5w2CW9IZFX34GV5t?= =?us-ascii?Q?bk6IHMHnuNdu2BDbCwRke5H2UPDeqFIkayEFvs8t+wzT4Ero9QJ5ABIXiXry?= =?us-ascii?Q?bY8995FwthHd3AWr/Pn3mFIq6G4mtkzH6mPt/EmdsNeT5+ijCfUuVXkOmuNh?= =?us-ascii?Q?8Sftp+QtSWesr8L2AikFzPjmrCPHKm5oBqN8RrleNTbqgCiVr6ndMkHwR408?= =?us-ascii?Q?V/113ntCW3ECiLyHAng8ld32JPSa6BeX37PZvAXXbMVCfQi5t7x9hY/kEPFU?= =?us-ascii?Q?jKZSiaJp4hlAlvqLZLldK4FAZ8Xl8bnum08UXgufT2SxxEF5hr07OkNC4gEX?= =?us-ascii?Q?ny11?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(7916004)(346002)(136003)(396003)(376002)(39860400002)(40470700004)(46966006)(36840700001)(40460700003)(82310400005)(426003)(47076005)(966005)(6916009)(316002)(26005)(9686003)(186003)(41300700001)(54906003)(336012)(86362001)(40480700001)(44832011)(356005)(81166007)(36860700001)(33716001)(8676002)(2906002)(83380400001)(34020700004)(53546011)(478600001)(4326008)(70586007)(5660300002)(82740400003)(8936002)(70206006)(21314003)(36900700001)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2022 15:56:41.6236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f95cbff-5525-4974-9c4c-08da60fa7335 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB3287 On Fri, 8 Jul 2022, Xenia Ragiadakou wrote: > On 7/8/22 02:05, Stefano Stabellini wrote: > > On Thu, 7 Jul 2022, Julien Grall wrote: > > > Hi Xenia, > > > > > > On 07/07/2022 21:38, Xenia Ragiadakou wrote: > > > > Add an arm subdirectory under automation/configs for the arm specific > > > > configs > > > > and add a config that enables static allocation. > > > > > > > > Modify the build script to search for configs also in this subdirectory > > > > and > > > > to > > > > keep the generated xen binary, suffixed with the config file name, as > > > > artifact. > > > > > > > > Create a test job that > > > > - boots xen on qemu with a single direct mapped dom0less guest > > > > configured > > > > with > > > > statically allocated memory > > > > - verifies that the memory ranges reported in the guest's logs are the > > > > same > > > > with the provided static memory regions > > > > > > > > For guest kernel, use the 5.9.9 kernel from the tests-artifacts > > > > containers. > > > > Use busybox-static package, to create the guest ramdisk. > > > > To generate the u-boot script, use ImageBuilder. > > > > Use the qemu from the tests-artifacts containers. > > > > > > > > Signed-off-by: Xenia Ragiadakou > > > > --- > > > > automation/configs/arm/static_mem | 3 + > > > > automation/gitlab-ci/test.yaml | 24 +++++ > > > > automation/scripts/build | 4 + > > > > automation/scripts/qemu-staticmem-arm64.sh | 114 > > > > +++++++++++++++++++++ > > > > 4 files changed, 145 insertions(+) > > > > create mode 100644 automation/configs/arm/static_mem > > > > create mode 100755 automation/scripts/qemu-staticmem-arm64.sh > > > > > > > > diff --git a/automation/configs/arm/static_mem > > > > b/automation/configs/arm/static_mem > > > > new file mode 100644 > > > > index 0000000000..84675ddf4e > > > > --- /dev/null > > > > +++ b/automation/configs/arm/static_mem > > > > @@ -0,0 +1,3 @@ > > > > +CONFIG_EXPERT=y > > > > +CONFIG_UNSUPPORTED=y > > > > +CONFIG_STATIC_MEMORY=y > > > > \ No newline at end of file > > > > > > Any particular reason to build a new Xen rather enable > > > CONFIG_STATIC_MEMORY in > > > the existing build? > > > > > > > diff --git a/automation/scripts/build b/automation/scripts/build > > > > index 21b3bc57c8..9c6196d9bd 100755 > > > > --- a/automation/scripts/build > > > > +++ b/automation/scripts/build > > > > @@ -83,6 +83,7 @@ fi > > > > # Build all the configs we care about > > > > case ${XEN_TARGET_ARCH} in > > > > x86_64) arch=x86 ;; > > > > + arm64) arch=arm ;; > > > > *) exit 0 ;; > > > > esac > > > > @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do > > > > rm -f xen/.config > > > > make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} > > > > defconfig > > > > make -j$(nproc) -C xen > > > > + if [[ ${arch} == "arm" ]]; then > > > > + cp xen/xen binaries/xen-${cfg} > > > > + fi > > > > > > This feels a bit of a hack to be arm only. Can you explain why this is not > > > enabled for x86 (other than this is not yet used)? > > > > > > > done > > > > diff --git a/automation/scripts/qemu-staticmem-arm64.sh > > > > b/automation/scripts/qemu-staticmem-arm64.sh > > > > new file mode 100755 > > > > index 0000000000..5b89a151aa > > > > --- /dev/null > > > > +++ b/automation/scripts/qemu-staticmem-arm64.sh > > > > @@ -0,0 +1,114 @@ > > > > +#!/bin/bash > > > > + > > > > +base=(0x50000000 0x100000000) > > > > +size=(0x10000000 0x10000000) > > > > > > From the name, it is not clear what the base and size refers too. Looking > > > a > > > bit below, it seems to be referring to the domain memory. If so, I would > > > suggest to comment and rename to "domu_{base, size}". > > > > > > > + > > > > +set -ex > > > > + > > > > +apt-get -qy update > > > > +apt-get -qy install --no-install-recommends u-boot-qemu \ > > > > + u-boot-tools \ > > > > + device-tree-compiler \ > > > > + cpio \ > > > > + curl \ > > > > + busybox-static > > > > + > > > > +# DomU Busybox > > > > +cd binaries > > > > +mkdir -p initrd > > > > +mkdir -p initrd/bin > > > > +mkdir -p initrd/sbin > > > > +mkdir -p initrd/etc > > > > +mkdir -p initrd/dev > > > > +mkdir -p initrd/proc > > > > +mkdir -p initrd/sys > > > > +mkdir -p initrd/lib > > > > +mkdir -p initrd/var > > > > +mkdir -p initrd/mnt > > > > +cp /bin/busybox initrd/bin/busybox > > > > +initrd/bin/busybox --install initrd/bin > > > > +echo "#!/bin/sh > > > > + > > > > +mount -t proc proc /proc > > > > +mount -t sysfs sysfs /sys > > > > +mount -t devtmpfs devtmpfs /dev > > > > +/bin/sh" > initrd/init > > > > +chmod +x initrd/init > > > > +cd initrd > > > > +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz > > > > +cd ../.. > > > > + > > > > +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded > > > > +curl -fsSLO > > > > https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > > > > + > > > > +./binaries/qemu-system-aarch64 -nographic \ > > > > + -M virtualization=true \ > > > > + -M virt \ > > > > + -M virt,gic-version=2 \ > > > > + -cpu cortex-a57 \ > > > > + -smp 2 \ > > > > + -m 8G \ > > > > + -M dumpdtb=binaries/virt-gicv2.dtb > > > > + > > > > +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > > > > + > > > > +# ImageBuilder > > > > +rm -rf imagebuilder > > > > +git clone https://gitlab.com/ViryaOS/imagebuilder > > > > + > > > > +echo "MEMORY_START=\"0x40000000\" > > > > +MEMORY_END=\"0x0200000000\" > > > > + > > > > +DEVICE_TREE=\"virt-gicv2.dtb\" > > > > + > > > > +XEN=\"xen-static_mem\" > > > > +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" > > > > > > AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is also > > > not > > > clear why you need to pass xsm=dummy. > > > > > > > + > > > > +NUM_DOMUS=1 > > > > +DOMU_MEM[0]=512 > > > > +DOMU_VCPUS[0]=1 > > > > +DOMU_KERNEL[0]=\"Image\" > > > > +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" > > > > +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" > > > > +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" > > > > + > > > > +UBOOT_SOURCE=\"boot.source\" > > > > +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config > > > > + > > > > +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c > > > > binaries/imagebuilder_config > > > > + > > > > +# Run the test > > > > +rm -f qemu-staticmem.serial > > > > +set +e > > > > +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source > > > > 0x40000000"| \ > > > > +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ > > > > + -M virtualization=true \ > > > > + -M virt \ > > > > + -M virt,gic-version=2 \ > > > > + -cpu cortex-a57 \ > > > > + -smp 2 \ > > > > + -m 8G \ > > > > + -no-reboot \ > > > > + -device virtio-net-pci,netdev=vnet0 -netdev > > > > user,id=vnet0,tftp=binaries > > > > \ > > > > + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ > > > > + -dtb ./binaries/virt-gicv2.dtb \ > > > > + |& tee qemu-staticmem.serial > > > > + > > > > +set -e > > > > > > A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it > > > would be better to consolidate in a single script. Looking briefly > > > throught > > > the existing scripts, it looks like it is possible to pass arguments (see > > > qemu-smoke-x86-64.sh). > > One idea would be to make the script common and "source" a second > > script or config file with just the ImageBuilder configuration because > > it looks like it is the only thing different. > > > > > > > > + > > > > +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 > > > > + > > > > +for ((i=0; i<${#base[@]}; i++)) > > > > +do > > > > + start="$(printf "0x%016x" ${base[$i]})" > > > > + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" > > > > + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial > > > > + if test $? -eq 1 > > > > + then > > > > + exit 1 > > > > + fi > > > > +done > > > > > > Please add a comment on top to explain what this is meant to do. However, > > > I > > > think we should avoid relying on output that we have written ourself. IOW, > > > relying on Xen/Linux to always write the same message is risky because > > > they > > > can change at any time. > > > > Especially if we make the script common, then we could just rely on the > > existing check to see if the guest started correctly (no special check > > for static memory). > > In this case, how the test will verify that the static memory configuration > has been taken into account and has not just been ignored? There is no simple way that I can think of. We can trust that it worked, without checking that the ranges were actually static as requested. We can parse the Xen output like you did, although if it changes then the test will break. Or we could add a script to detect and print specific output but I don't know if there is something under /proc or /sys that we could simply "cat" from bash to check it. If there is a simple way to do this by cat'ing /proc or /sys then I think that would be great. Otherwise I think we could do as you did in this patch, which is not perfect but it works and if something changes in the Xen output we'll detect it right away given that gitlab-ci is run pre-commit. From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:04:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:04:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363571.594173 (Exim 4.92) (envelope-from ) id 1o9qT4-0001bq-Gm; Fri, 08 Jul 2022 16:04:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363571.594173; Fri, 08 Jul 2022 16:04:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qT4-0001bj-E2; Fri, 08 Jul 2022 16:04:34 +0000 Received: by outflank-mailman (input) for mailman id 363571; Fri, 08 Jul 2022 16:04:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qT3-0001bd-6U for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:04:33 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qT1-0007oq-IK; Fri, 08 Jul 2022 16:04:31 +0000 Received: from [54.239.6.184] (helo=[192.168.18.9]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9qT1-00066S-C6; Fri, 08 Jul 2022 16:04:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rzbOg72Z2GgK1xdreJJj7KZCOASVERvaMdhhLOzBo6s=; b=BQorHkv2+XKYTZwAvBd5DKlhoX J0TNucsjO802roiNNksMXOXrnkDq8Ft8xVi+wIxAXSJd+gMCU/FveUquBhNPaGgJLXrT3vLLv7Lkd hlBYOO/xKyuOv+LZFjFBVkPcS+rPOnfhUFb2jvWTimXXHAUWqkryOGnfx+6vw0aS9vGA=; Message-ID: <84efdf22-1e28-040f-a41d-0c3709e6b60b@xen.org> Date: Fri, 8 Jul 2022 17:04:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu To: Stefano Stabellini , Xenia Ragiadakou Cc: Stefano Stabellini , xen-devel@lists.xenproject.org, Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 08/07/2022 16:56, Stefano Stabellini wrote: > Or we could add a script to detect and print specific output but I > don't know if there is something under /proc or /sys that we could > simply "cat" from bash to check it. The domain device-tree should be /proc/device-tree. So you could check the properties from there. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363582.594199 (Exim 4.92) (envelope-from ) id 1o9qiG-0005Ow-GN; Fri, 08 Jul 2022 16:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363582.594199; Fri, 08 Jul 2022 16:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiG-0005O5-Ba; Fri, 08 Jul 2022 16:20:16 +0000 Received: by outflank-mailman (input) for mailman id 363582; Fri, 08 Jul 2022 16:20:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiF-00054g-LD for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:20:15 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d8f26d42-fed9-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:20:14 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d8f26d42-fed9-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657297214; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=OPOL1lal7rsNW/hGS9xlZBwEc0R8DY+uuDGsN9y09zc=; b=Z8ftb2+CVvHOuZSmjAI88GMqsBBg2ZFj5wXeE2Sg0oQSt9bsYKv9jblb D4OQwXNVW0+JLd0kLYOzPbtFb5xsemx+pjNxwCk1ZkpOesGtLI3SoRAmq 97PrCedNbxyq3tgyqMUaBLzGpGcHHQLYyOLqU8eifRw6BcgWZra6fjuLO Q=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74700441 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:VWtQ06LMl24ztx6hFE+RzZUlxSXFcZb7ZxGr2PjKsXjdYENS1zVVn DEeDWiFOK2IZmv9Ldp/ao2x9x8HsJHWndI3TQZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dY42YPR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 NVKn6TtblcKBPLFoeMTeQJjFgJAErITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQqqBP 5JFNWMHgBLoPj1AawY0I6oFjsSDv3b/fAN4lFSonP9ii4TU5FMoi+W8WDbPQfSIWMFUk0Cwt m/AuWPjDXkyFvaS1D6E+XKEnfLUkGXwX4d6PL+37Plxm3WI23ceThYRUDOTsfS/z0KzRd9bA 0gV4TY167g/8lSxSdvwVAH+p2SL1jYHQMZZGeA+7ACLy4LX7hyfC2xCSSROAPQ5sOcmSDps0 UWG9+4FHhQ27ufTEyjEsO7J83XiYkD5MFPuewcESiE9vv6zg7tshyvIQPx4K6uWsPLqTGSYL y+xkMQuu1kCpZdVivrhpAyY027ESovhFVBsuFiONo6xxkYgPdP+OdT1gbTOxawYRLt1WGVtq 5TtdyK2yOkVRa+AmyWWKAnmNOH4vq3VWNEwbLMGInXAy9hO0yT6FWyoyGsiTHqFy+5dEdMTX GfduBlK+LhYN2awYKl8buqZUpp3kvK5RYu1DK6OPrKih6SdkiferUmCgmbJhgjQfLUEy/lja f93j+72ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjG8vhT6pLHPCT9Ye5caDOmN7llhIvZ8FS92 4sObKOilkQAONASlwGKqOb/23hRdiNlbX03wuQKHtO+zv1OQjt/VKONn+NxK+SIXc19z4/1w 510YWcAoHKXuJENAVzihqxLAF83YatCkA== IronPort-HdrOrdr: A9a23:I+wugKxPXK4b/no+Q5r5KrPwKL1zdoMgy1knxilNoRw8SK2lfq GV7YwmPHDP+VUssR0b9uxofZPwJU80lqQFmLX5X43SPjUO0VHAROoJgOffKn/bakrDH4ZmpM FdmsNFaOEYY2IVsS+D2njcL+od X-IronPort-AV: E=Sophos;i="5.92,256,1650945600"; d="scan'208";a="74700441" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Juergen Gross Subject: [PATCH 2/3] xen/cmdline: Extend parse_boolean() to signal a name match Date: Fri, 8 Jul 2022 17:19:33 +0100 Message-ID: <20220708161934.10095-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220708161934.10095-1-andrew.cooper3@citrix.com> References: <20220708161934.10095-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain This will help parsing a sub-option which has boolean and non-boolean options available. First, rework 'int val' into 'bool has_neg_prefix'. This inverts it's value, but the resulting logic is far easier to follow. Second, reject anything of the form 'no-$FOO=' which excludes ambiguous constructs such as 'no-$foo=yes' which have never been valid. This just leaves the case where everything is otherwise fine, but parse_bool() can't interpret the provided string. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Juergen Gross --- xen/common/kernel.c | 20 ++++++++++++++++---- xen/include/xen/lib.h | 3 ++- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/xen/common/kernel.c b/xen/common/kernel.c index adff2d2c77f3..74dbaf31ea70 100644 --- a/xen/common/kernel.c +++ b/xen/common/kernel.c @@ -272,9 +272,9 @@ int parse_bool(const char *s, const char *e) int parse_boolean(const char *name, const char *s, const char *e) { size_t slen, nlen; - int val = !!strncmp(s, "no-", 3); + bool has_neg_prefix = !strncmp(s, "no-", 3); - if ( !val ) + if ( has_neg_prefix ) s += 3; slen = e ? ({ ASSERT(e >= s); e - s; }) : strlen(s); @@ -286,11 +286,23 @@ int parse_boolean(const char *name, const char *s, const char *e) /* Exact, unadorned name? Result depends on the 'no-' prefix. */ if ( slen == nlen ) - return val; + return !has_neg_prefix; + + /* Inexact match with a 'no-' prefix? Not valid. */ + if ( has_neg_prefix ) + return -1; /* =$SOMETHING? Defer to the regular boolean parsing. */ if ( s[nlen] == '=' ) - return parse_bool(&s[nlen + 1], e); + { + int b = parse_bool(&s[nlen + 1], e); + + if ( b >= 0 ) + return b; + + /* Not a boolean, but the name matched. Signal specially. */ + return -2; + } /* Unrecognised. Give up. */ return -1; diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h index aab1fc7c4a69..05ee1e18af6b 100644 --- a/xen/include/xen/lib.h +++ b/xen/include/xen/lib.h @@ -89,7 +89,8 @@ int parse_bool(const char *s, const char *e); /** * Given a specific name, parses a string of the form: * [no-]$NAME[=...] - * returning 0 or 1 for a recognised boolean, or -1 for an error. + * returning 0 or 1 for a recognised boolean. Returns -1 for general errors, + * and -2 for "not a boolean, but $NAME= matches". */ int parse_boolean(const char *name, const char *s, const char *e); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363581.594195 (Exim 4.92) (envelope-from ) id 1o9qiG-0005MC-7A; Fri, 08 Jul 2022 16:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363581.594195; Fri, 08 Jul 2022 16:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiG-0005M1-43; Fri, 08 Jul 2022 16:20:16 +0000 Received: by outflank-mailman (input) for mailman id 363581; Fri, 08 Jul 2022 16:20:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiE-00054g-GD for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:20:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7366dd3-fed9-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:20:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7366dd3-fed9-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657297213; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4G0pHe7Zlw0C/WopgFCHRK8VLGhJr1p2bjgFoVEoa40=; b=SSDrmT+vqsBKIRlCrzsNRMS4FBRyni5YVHA5l5aDttgcXdTEnI85jPrY mol1XNGvHrsJ5hD8TRFWOr1cQPy6zSm85ne4R1lExpYy2aJL/O/w+jXnn H2hyy+/P62UabJAe0qoAGJdDvT6vfTkPvmugxYKQyLg1UN2Kkuleng6cz 4=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74700440 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:WHrFha09UyLL48Fr2PbD5bZxkn2cJEfYwER7XKvMYLTBsI5bpz0Om GsaXmrUPfnYNjHyKI1zbYS28E8H7Z/Rm4BmG1dqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1Ek/NtTo5w7Rj2tEw0YDia++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1NsraIFCB5HZeTkd0aXTNDKCRdA4JZreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNamCO JJBNWY3BPjGS00QHgY0V7w7pfqTpSntSwx3hQLJoYNitgA/yyQuieOwYbI5YOeiWsF9jkue4 GXc8AzRIDsXKdiewjqt6W+3i6nEmiaTcJIfEvi0++BnhHWXx3cPE1sGWF2ju/67h0WiHdVFJ CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4E+oQ0FyqmonuvA+gAWYuVQVES+IJq5pjLdA17 WNlj+8FFBQ27uDKEyvBqefIxd+hEXNLdDFfPEfoWSNAuoC++99r03ojW/45SMaIYsvJ9SYcK txghAw3nP0tgMECzM1XFniX0mv39vAlouPYjzg7v15JDSsjPeZJn6TytTDmAQ9ode51tGWps nkegNS55+sTF5yLnyHlaLxTQe7zvqbaYGeC2w4H83wdG9KFoi/LkWd4uWgWGauUGpxcJW+Bj LH742u9G6O/zFP1NPQqMupd+uwhzLT6FMSNa804muFmO8ArHCfepXkGTRfJgwjFzRh9+Ylia MzzWZv9Uh4n5VFPkWPeqxE1iuRwmEjTBAr7GPjG8vhQ+eDEOiHJFelVYAvmgyJQxPrsnTg5O u13b6OioyizmsWkCsUL2eb/9Ww3EEU= IronPort-HdrOrdr: A9a23:Olm7BK/T0npAyZW6p6tuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.92,256,1650945600"; d="scan'208";a="74700440" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/3] x86/spec-ctrl: Honour spec-ctrl=0 for unpriv-mmio sub-option Date: Fri, 8 Jul 2022 17:19:32 +0100 Message-ID: <20220708161934.10095-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220708161934.10095-1-andrew.cooper3@citrix.com> References: <20220708161934.10095-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This was an oversight from when unpriv-mmio was introduced. Fixes: 8c24b70fedcb ("x86/spec-ctrl: Add spec-ctrl=unpriv-mmio") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/spec_ctrl.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index 7a4550db8318..ba64a09048be 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -122,6 +122,7 @@ static int __init cf_check parse_spec_ctrl(const char *s) opt_l1d_flush = 0; opt_branch_harden = false; opt_srb_lock = 0; + opt_unpriv_mmio = false; } else if ( val > 0 ) rc = -EINVAL; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:20:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:20:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363580.594184 (Exim 4.92) (envelope-from ) id 1o9qiA-00054t-SF; Fri, 08 Jul 2022 16:20:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363580.594184; Fri, 08 Jul 2022 16:20:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiA-00054m-PN; Fri, 08 Jul 2022 16:20:10 +0000 Received: by outflank-mailman (input) for mailman id 363580; Fri, 08 Jul 2022 16:20:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qi9-00054g-8G for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:20:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d3865ac0-fed9-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:20:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3865ac0-fed9-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657297206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Y7mZFxS2RWldNtqgu6etUWYDAXOJTO/Jp6WEGB9hmEo=; b=bJ3eI7g30OBSmoeUAMHccUQUrTyCITL/a6+vAPJx2VehqOdUvcj8YFjm 4oAPKYf1OhIiv6yiO+/XZHbDWCfv+5ovdjJdXLVk7bfd/0guTijFabTg0 BZaO7LLyHVoT1l8qnFUSuPYc5jDJWwuPTeTpzNn8WANFPkS9KIOo3NkF2 w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75816900 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:wCPpcaj9TiUZUcn0wHrrmBq4X161BRAKZh0ujC45NGQN5FlHY01je htvXDjSafyPZGD3LohyPojj80JVu5XSztcyHApprikwEigb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6jefSLlbFILas1hpZHGeIcw98z0M58wIFqtQw24LhXFvd4 YiaT/D3YzdJ5RYlagr41IrbwP9flKyaVOQw5wFWiVhj5TcyplFNZH4tDfjZw0jQG+G4KtWSV efbpIxVy0uCl/sb5nFJpZ6gGqECaua60QFjERO6UYD66vRJjnRaPqrWqJPwwKqY4tmEt4kZ9 TlDiXC/YSB5EoLco7klaghVQihSD4NF5r/5ClHq5KR/z2WeG5ft6/BnDUVwNowE4OdnR2pJ8 JT0KhhUMErF3bjvhuvmFK883azPL+GyVG8bklhmwSvUErANRpfbTr+RzdRZwC0xloZFGvO2i 88xNmc/NUqRO0Un1lE/MZ1itfqjuSLDTxoHiUqvp4UIwHf/01kkuFTqGIWMIYHbLSlPpW6Ho krW8mK/BQsVXPS94zeY9nOnhsfUgDj2HokVEdWQ5vNsxVGe2GEXIBkXTkeg5+m0jFakXNBSI FBS/TAhxZXe72TyEIO7BUfh5ifZ4FhMALK8DtHW9imqmob78z3EPlEVQ29IRO4It9E2excDg wrhc8zSOdB/jFGEYSvDq+jO9G/taXR9wXwqPnFdE1ZcizX3iMRq10+UEI4+eEKgpoetcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJGT9bxgbQjxawcRLt1t3HY1 JT+p+CQ7foVEbaGnzGXTeMGEdmBvqjYb2eF0QE/Rcd7p1xBHkJPm6gJsVmSw28wa645lcLBO heP6Wu9GrcJVJdVUUOHS93oUJl7pUQRPd/kSurVfrJzX3SFTyfepHsGTRfJhwjFyRFw+Ylia cbzWZv9Vh4yVPU4pAdass9AiNfHMAhlnjiNLX06pjz6uYejiIm9E+1bbwfSMLBpvMtpYmz9q r5iCidD8D0HOMWWX8Ud2dR7wYwiRZTjOa3Llg== IronPort-HdrOrdr: A9a23:8F9pUKqxzpLiLKEmmJzEj4MaV5oTeYIsimQD101hICG8cqSj+f xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.92,256,1650945600"; d="scan'208";a="75816900" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] x86/spec-ctrl: Add fine-grained cmdline suboptions for primitives Date: Fri, 8 Jul 2022 17:19:34 +0100 Message-ID: <20220708161934.10095-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220708161934.10095-1-andrew.cooper3@citrix.com> References: <20220708161934.10095-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Support controling the PV/HVM suboption of msr-sc/rsb/md-clear, which previously wasn't possible. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- docs/misc/xen-command-line.pandoc | 12 +++++-- xen/arch/x86/spec_ctrl.c | 66 +++++++++++++++++++++++++++++++++------ 2 files changed, 66 insertions(+), 12 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index da18172e50c5..de33ccc005fc 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -2257,7 +2257,8 @@ not be able to control the state of the mitigation. By default SSBD will be mitigated at runtime (i.e `ssbd=runtime`). ### spec-ctrl (x86) -> `= List of [ , xen=, {pv,hvm,msr-sc,rsb,md-clear}=, +> `= List of [ , xen=, {pv,hvm}=, +> {msr-sc,rsb,md-clear}=|{pv,hvm}=, > bti-thunk=retpoline|lfence|jmp, {ibrs,ibpb,ssbd,psfd, > eager-fpu,l1d-flush,branch-harden,srb-lock, > unpriv-mmio}= ]` @@ -2282,12 +2283,17 @@ in place for guests to use. Use of a positive boolean value for either of these options is invalid. -The booleans `pv=`, `hvm=`, `msr-sc=`, `rsb=` and `md-clear=` offer fine +The `pv=`, `hvm=`, `msr-sc=`, `rsb=` and `md-clear=` options offer fine grained control over the primitives by Xen. These impact Xen's ability to -protect itself, and Xen's ability to virtualise support for guests to use. +protect itself, and/or Xen's ability to virtualise support for guests to use. * `pv=` and `hvm=` offer control over all suboptions for PV and HVM guests respectively. +* Each other option can be used either as a plain boolean + (e.g. `spec-ctrl=rsb` to control both the PV and HVM sub-options), or with + `pv=` or `hvm=` subsuboptions (e.g. `spec-ctrl=rsb=no-hvm` to disable HVM + RSB only). + * `msr-sc=` offers control over Xen's support for manipulating `MSR_SPEC_CTRL` on entry and exit. These blocks are necessary to virtualise support for guests and if disabled, guests will be unable to use IBRS/STIBP/SSBD/etc. diff --git a/xen/arch/x86/spec_ctrl.c b/xen/arch/x86/spec_ctrl.c index ba64a09048be..328862bdf549 100644 --- a/xen/arch/x86/spec_ctrl.c +++ b/xen/arch/x86/spec_ctrl.c @@ -147,20 +147,68 @@ static int __init cf_check parse_spec_ctrl(const char *s) opt_rsb_hvm = val; opt_md_clear_hvm = val; } - else if ( (val = parse_boolean("msr-sc", s, ss)) >= 0 ) + else if ( (val = parse_boolean("msr-sc", s, ss)) != -1 ) { - opt_msr_sc_pv = val; - opt_msr_sc_hvm = val; + switch ( val ) + { + case 0: + case 1: + opt_msr_sc_pv = opt_msr_sc_hvm = val; + break; + + case -2: + s += strlen("msr-sc="); + if ( (val = parse_boolean("pv", s, ss)) >= 0 ) + opt_msr_sc_pv = val; + else if ( (val = parse_boolean("hvm", s, ss)) >= 0 ) + opt_msr_sc_hvm = val; + else + default: + rc = -EINVAL; + break; + } } - else if ( (val = parse_boolean("rsb", s, ss)) >= 0 ) + else if ( (val = parse_boolean("rsb", s, ss)) != -1 ) { - opt_rsb_pv = val; - opt_rsb_hvm = val; + switch ( val ) + { + case 0: + case 1: + opt_rsb_pv = opt_rsb_hvm = val; + break; + + case -2: + s += strlen("rsb="); + if ( (val = parse_boolean("pv", s, ss)) >= 0 ) + opt_rsb_pv = val; + else if ( (val = parse_boolean("hvm", s, ss)) >= 0 ) + opt_rsb_hvm = val; + else + default: + rc = -EINVAL; + break; + } } - else if ( (val = parse_boolean("md-clear", s, ss)) >= 0 ) + else if ( (val = parse_boolean("md-clear", s, ss)) != -1 ) { - opt_md_clear_pv = val; - opt_md_clear_hvm = val; + switch ( val ) + { + case 0: + case 1: + opt_md_clear_pv = opt_md_clear_hvm = val; + break; + + case -2: + s += strlen("md-clear="); + if ( (val = parse_boolean("pv", s, ss)) >= 0 ) + opt_md_clear_pv = val; + else if ( (val = parse_boolean("hvm", s, ss)) >= 0 ) + opt_md_clear_hvm = val; + else + default: + rc = -EINVAL; + break; + } } /* Xen's speculative sidechannel mitigation settings. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:20:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:20:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363583.594217 (Exim 4.92) (envelope-from ) id 1o9qiM-0005ye-Pm; Fri, 08 Jul 2022 16:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363583.594217; Fri, 08 Jul 2022 16:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiM-0005yV-MS; Fri, 08 Jul 2022 16:20:22 +0000 Received: by outflank-mailman (input) for mailman id 363583; Fri, 08 Jul 2022 16:20:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qiL-00054g-5S for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:20:21 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db6a532c-fed9-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:20:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db6a532c-fed9-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657297219; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JXYfonh7wj3ThAZmLEhpE9NLkOrzDAqig0RXIjQQqEU=; b=GwqvMqOurQ1dY7ipk+tgWSIrJEQZ3E/819NVtbRa9Srd2a0pPmbzg4jw ylgFiY0rCtoZb9/RqEDuSbT/WJ4VFaFGfvsqcyCSC0ApZtw53AOySPynQ 5lnjkhjovMek7XYSlaCdgM/sKsMjyVt0wYO74MF+6U14nJGjM8EKOWllH w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 77956798 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:f8nGGas6jHDgQMY5R70n+E+aH+fnVFpeMUV32f8akzHdYApBsoF/q tZmKWuPP/aKMWbwed5+OYu1o0lU7MLVmNRhQVY4rS5jHn8X+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zV6 YupyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8WLrLPm78+fiJDPAolbIEdoI7JP1uw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD yYcQWUwPUmePEwfUrsRIIwAsM6CrVXdTzFJ9U6TpY8m+Vf08iUkhdABN/KKI4fXFK25hH2wp H/C/mn/KgEXMpqY0zXt2m2orv/Cm2X8Qo16PKaj6vdgjVmXx2oSIB4bT122pb++kEHWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUSyiuA167V6AaxHXUfQ3hKb9lOiSMtbWV0j BnTxYqvXGEx9u3OIZ6AyluKhQyiJisWdkwvXjQrZlBUz4K7kY8trR2aG76PD5WJYs3J9SDYm m7X83Jn2+pD0abnxI3gowmZ3mvESozhC1dsu16JBj/NAhZRPtbNWmC+1bTMAR+sxq69R0LJg nULktP2AAsmXcDUz3zlrAng8diUCxe53N702wcH82EJrWjFxpJaVdk4DMtCDEloKN0YXjTif VXevwhcjLcKYib1N/YnPNLrVZ56pUQFKTgDfqmFBjapSsEoHDJrAQk0PRLAt4wTuBJEfV4D1 WezLp/3UCdy5VVPxzuqXeYNuYIWKtQF7TqLH/jTlk3/uZLHPSL9YepVYTOmM7FihIvZ8Vq9z jqqH5bTo/mpeLalOXe/HE96BQ1iEEXX8ris8ZIIKrLdclo2cIzjYteIqY4cl0Vet/w9vo/1E ruVAB8wJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:y48TFKhpmPGxOKj9ZFxRS0l1B3BQXtQji2hC6mlwRA09TySZ// rOoB19726TtN9xYgBGpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ8l6U 4KSchD4bPLY2SS9fyKhTWFLw== X-IronPort-AV: E=Sophos;i="5.92,256,1650945600"; d="scan'208";a="77956798" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Stefano Stabellini , Wei Liu Subject: [PATCH 0/3] x86/spec-ctrl: Bug / (mis)feature fixes Date: Fri, 8 Jul 2022 17:19:31 +0100 Message-ID: <20220708161934.10095-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Andrew Cooper (3): x86/spec-ctrl: Honour spec-ctrl=0 for unpriv-mmio sub-option xen/cmdline: Extend parse_boolean() to signal a name match x86/spec-ctrl: Add fine-grained cmdline suboptions for primitives docs/misc/xen-command-line.pandoc | 12 +++++-- xen/arch/x86/spec_ctrl.c | 67 +++++++++++++++++++++++++++++++++------ xen/common/kernel.c | 20 +++++++++--- xen/include/xen/lib.h | 3 +- 4 files changed, 85 insertions(+), 17 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:38:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:38:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363601.594228 (Exim 4.92) (envelope-from ) id 1o9qzg-0000eT-84; Fri, 08 Jul 2022 16:38:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363601.594228; Fri, 08 Jul 2022 16:38:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qzg-0000eM-4h; Fri, 08 Jul 2022 16:38:16 +0000 Received: by outflank-mailman (input) for mailman id 363601; Fri, 08 Jul 2022 16:38:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qze-0000b9-JY for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:38:14 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59a2990c-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:38:12 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 9040A3200991; Fri, 8 Jul 2022 12:38:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Jul 2022 12:38:08 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:38:06 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59a2990c-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1657298287; x= 1657384687; bh=KD3KK4qajRC4Z0kzf0DDUjxSr4hqLBOJDRxjLaucINg=; b=q vLxgIKuFC9yzKX461LjgdJMWMb9Xyo+11lTUGLsx2F9h/WCW6SY6oERYr0cRMVS0 /Y4lvJssLCd0jg/a9xBGkHwLd/r0ustBBzr0WA/lGzEUtN+pZUw1xIeqIdWuuXKI vnViVizKvI3nB9OV7CZPngbOfxmPjKRQQKbDVuqOffWidX9wHysfk+IjBilaqAOS wDXLvoU3g3/RGOAJO0BvT1ztK4pBD+4bB3as/RE1PZaCZBwMfkAdDYLmVN3+Q4w4 iyRv+nvZ7dd18s/kDKp4dCpZH/L8NF6BAhNSUQLCMP3JyfUvjSceTO05HIPlWh0e A1Aa4ljtr80IS2jcfN3cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1657298287; x=1657384687; bh=KD3KK4qajRC4Z0kzf0DDUjxSr4hqLBOJDRx jLaucINg=; b=AKODzjS5CvBQrpFFeAv2qZM719ZlgB3lopIVrjETHjrnhMgorr0 q+Ku5nSW2FDeCpzXWgPBevNMkixlMzReBFcQdnQlLUU0RnTm50uveIqdTfdbF8+5 WONajGkHTmt0avv/ql559heolfebQldp8Gqj1uml74rxFpBE3u66f4Wa7CDMuyua /RN3LELv+nSJNjMcMT5PxBCugeRikOBANDwORh1rpR+R/5hq3ILeCgEAIlfrs1VR lfeSD1k4YAoYVECEAOj8TtVXlFpI+v8dgMRfWK+redI21MGyClfG6Nf6QI8NZhsw lL8Egc87vJD1xU0gt7wdkExz2CPvnzXMn6w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: gntdev warning fixes Date: Fri, 8 Jul 2022 12:37:44 -0400 Message-Id: <20220708163750.2005-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The recent gntdev fixes introduced two incorrect WARN_ON()s, which triggered immediately on my system. Patches for master and all supported stable versions follow. From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:38:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:38:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363602.594238 (Exim 4.92) (envelope-from ) id 1o9qzv-0001Sr-GZ; Fri, 08 Jul 2022 16:38:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363602.594238; Fri, 08 Jul 2022 16:38:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qzv-0001Sk-DZ; Fri, 08 Jul 2022 16:38:31 +0000 Received: by outflank-mailman (input) for mailman id 363602; Fri, 08 Jul 2022 16:38:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qzu-0000b9-6F for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:38:30 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65044116-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:38:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 1664C320098A; Fri, 8 Jul 2022 12:38:27 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 08 Jul 2022 12:38:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:38:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65044116-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298306; x=1657384706; bh=SHamRkjqTyAr3nH7T1rIG7+h7aFHO22A/2u vJRAbcyU=; b=WQh8q0tluMw9RQlOpOae4YI83RM8QU8J+8n2r+/162ToKKVqGPr +m4PTB/UQENz4DC5MmyuXUaOvzypADYc+z8OYanM9BHneOqUH1y2cR/yA/jjJZKZ AGEHEJWRHHkmQX5la9T+dDEnHbJYco8+JL25+SfgV+jVTdXvbFsJLiUwccbEy/Fr yPt2OdUpsjnk6riecXMCxQUS6y8ncL8uLnwahcSHGp/YrQ5PbEdayrOoZ9rZiJ96 zKFIlWSUl+9luYQVi7K/t2TJIouNFOiu25n7L2XN2PSVYeglkzxgVcgBLJy3/t/Y 4pdRlsjt6E0iQ8KTXVCw65K+umfe1DrgGBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298306; x=1657384706; bh=SHamRkjqTyAr3 nH7T1rIG7+h7aFHO22A/2uvJRAbcyU=; b=PLBy5hHeQZcX2ypdyoj2GfoatrTHJ EAVwFUWZywMm5VL0vBpSTX9uZvjIrnZFnSg5SpFmDrgEVRpodVTkKK2BuMuvN9E5 H3hH0ljuYpg5kNju1YKYZO/gqq/7IVc3gZt5Rxpg2calW3xutUJ4e1dchS76ko5o LKZem2LM2ssL3FhT5HYcAUev6cDq0SIvy2cVg3n37POMJtIukAJJq9y2nGhAMPE4 HFj8G0Sv86v5Hptzvgrc4Nw+2NdFm6kPxQtQS001UOHz+H7DxGaFbr59/wwboQCd v0oPTHC2i9LC7eP6sJDy59OmctvzeDvr5bNjnnzM8swr/wOPQAocylU2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 4.19] Ignore failure to unmap -1 Date: Fri, 8 Jul 2022 12:37:45 -0400 Message-Id: <20220708163750.2005-2-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases wherr unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 73e9e72247b9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 492084814f55d8ed46d2d656db75b28a91dd7f06..27d955c5d9f9076266f77b9fedfa1a6a2ba08f56 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -416,7 +416,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:38:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:38:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363605.594250 (Exim 4.92) (envelope-from ) id 1o9qzz-0001pc-Ol; Fri, 08 Jul 2022 16:38:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363605.594250; Fri, 08 Jul 2022 16:38:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qzz-0001pV-Lx; Fri, 08 Jul 2022 16:38:35 +0000 Received: by outflank-mailman (input) for mailman id 363605; Fri, 08 Jul 2022 16:38:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9qzz-0000b9-8f for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:38:35 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6801c354-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:38:34 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 15C16320098B; Fri, 8 Jul 2022 12:38:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 08 Jul 2022 12:38:32 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:38:30 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6801c354-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298311; x=1657384711; bh=ig8GcuWSg8QXfRSyjrDA6qxRNwqouf+sjZK 0qbI6A6M=; b=UMimGG2Uo4lY7atREe2OP8S17UwSlHLVe/8rwvtepafcUCIerM/ +faYLQMq+QWk2ePkEKdH0xisdPrkUY8RM9HfbybzshoqXScDXiWukeOrL8SBiC7q 2bYf7P7djsCJm4p3x9qG9ovXkVz/nuxRmuH/JUDYCnAdC0pxNACm1AAb33Z9rpEt uFcN0NbUHA2r7MLfrnH7a/qwob9ehzd/2Wh/ETUf0iH2lWlBpIMGjq7IiY046E80 OgNKBOHEZE63eLhNRPmXdYjbGVAnVYvjarOgO6Jg83zGr23/yK4kAfsCaiwfMnTm zBpmMftHJCm+TP4J8BoN0zlc3y0JpPN4JjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298311; x=1657384711; bh=ig8GcuWSg8QXf RSyjrDA6qxRNwqouf+sjZK0qbI6A6M=; b=KW6PkF5vTTfz/RditvRVGIbRHVSo2 hJGbgtx3KXGhhsTRKqRnP+nWRgfxd79rqg4T3AXAnxqw7p1zunuMAGmkTZ6PKogF z2phKIH8YtcZMqizRwy9TqWcgctfhiWX5BVG6uGylSxM1xEjlVAsePMbGRviqOtY QMm6JSAdF9T3DPgMO8DKwAWm/1RIAf4qaFx3ql+dXq97Uaas+PJws0B+Rl56YoAo 4t9O60v4OzSZ6uH0x4zdd1gNwEI163U1noKNYLtsb7lK8BcNDDwThumvP2n3uGVm hh/TH9YT+otbypQrg35LjestKqW97vZdxb36ixcW3O+eKJK0OaYMD1gxg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 4.14] Ignore failure to unmap -1 Date: Fri, 8 Jul 2022 12:37:46 -0400 Message-Id: <20220708163750.2005-3-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases wherr unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 2fe26a9a7048 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 2827015604fbaa45f0ca60c342bbf71ce4132dec..799173755b785e2f3e2483855f75af1eba8e9373 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -393,7 +393,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:39:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:39:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363618.594261 (Exim 4.92) (envelope-from ) id 1o9r0s-0002t1-5a; Fri, 08 Jul 2022 16:39:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363618.594261; Fri, 08 Jul 2022 16:39:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0s-0002su-2V; Fri, 08 Jul 2022 16:39:30 +0000 Received: by outflank-mailman (input) for mailman id 363618; Fri, 08 Jul 2022 16:39:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0q-0001ny-P2 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:39:28 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8649aabe-fedc-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:39:26 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D4D0532009A4; Fri, 8 Jul 2022 12:39:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 08 Jul 2022 12:39:23 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:39:21 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8649aabe-fedc-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298362; x=1657384762; bh=jL+f1joq8YvrpHlirkwlocAEqytxnYsGsQN MmbsBj+k=; b=bkpVHl53b6JBmcsyJgTrDWib8he62qL7C+p5bEgemRrib5QUhn2 wpp+opvwGDksTCS5DUVqpjtWOjuBDCEbfUwfWhj7mVdOH6RAcgssxN0Fe5ZjJjaV YENGvqh/CV9AjykdnrGexhKaEfKXWLL11MRGYkGtRtcYMKlKYXywvicPXgvvlyO6 v5D9zvO0v/GMXLN65+F9Ge3H4T+vlDQCCAJkbd5k3b1LHim/UVfLp9J6Xnm2lcuD 4TBpLuEeLLvcxjShA2zitcrZRa24RNbVZFDXwo2uJVLiO2TjV1F9kgMaMOlFSGLb zyEdPOVsG3mcIombJvc9zA3KZbKdfH8AvxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298362; x=1657384762; bh=jL+f1joq8Yvrp HlirkwlocAEqytxnYsGsQNMmbsBj+k=; b=vKTndTFzZaxVI615asSUe9gpMDLgS +nHU0dIfe7pSOlYkTbY/jyN1iCYbEIf0PlPEzzOf0C2iEiUxwbhq0zRBRF3EOMyQ IWFkeBdr98gPxRkKA/I3BhShc5e9n5lDJImtif6Lc/9YQ0AcesTLt/+B0UxVGy7l taMR5r2kMaNFfBF7wNnNXxwKSkP/h3NZ57f7zHgUckakI2EgxhVt0Htgni6zE8VF ddAJN5qdEqSc/2NTKBo8xGGC4D4zEMnQEu+7EhdMeqDAaIJUBEW/2zYh6MkwaR3a YcIQKh05r/QoSvfANp5E5ubj55/NasCjHkZ3IbEKfMXt4+yHyeq4/rPjQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 5.18] Ignore failure to unmap INVALID_GRANT_HANDLE Date: Fri, 8 Jul 2022 12:37:50 -0400 Message-Id: <20220708163750.2005-7-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not INVALID_GRANT_HANDLE. The handle field of any page that was not successfully mapped will be INVALID_GRANT_HANDLE, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: d4a49d20cd7c ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4b56c39f766d4da68570d08d963f6ef40c8d9c37..22fcd503f4a4487d0aed147c94f432683dad8c73 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -396,13 +396,17 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - WARN_ON(map->kunmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset+i].status && + map->kunmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:40:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:40:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363621.594271 (Exim 4.92) (envelope-from ) id 1o9r1W-0004E2-FJ; Fri, 08 Jul 2022 16:40:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363621.594271; Fri, 08 Jul 2022 16:40:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r1W-0004Dv-CW; Fri, 08 Jul 2022 16:40:10 +0000 Received: by outflank-mailman (input) for mailman id 363621; Fri, 08 Jul 2022 16:40:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r1U-0004Dg-Nr; Fri, 08 Jul 2022 16:40:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r1U-0008V1-KY; Fri, 08 Jul 2022 16:40:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r1U-0003DD-5B; Fri, 08 Jul 2022 16:40:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9r1U-00029V-4h; Fri, 08 Jul 2022 16:40:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=S1z+LOECjll4rGab05FIN5sjmDorMmU6gn9CRO+LJV8=; b=u0GA8Q/Fu+fPQSyX8GtNeTDjCP +JZOwbminfH7LM6b45r94rFxYvPay30qbgc1LMXsQPUk3zWJ7oTHTgGhAjZ9B5UsAOhnbYjWkw4TJ IjC2LNYEP0T3tvg37lCIdyybyiA1u9ntzgYIeFPrYC8BH5AKOJE884yPxU88ORy0k/PY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171553: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e8a4e1c1bb697b1d9fc48f0e56dc0f50bc024bee X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Fri, 08 Jul 2022 16:40:08 +0000 flight 171553 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171553/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e8a4e1c1bb697b1d9fc48f0e56dc0f50bc024bee baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 19 days Failing since 171280 2022-06-19 15:12:25 Z 19 days 50 attempts Testing same since 171553 2022-07-08 03:03:18 Z 0 days 1 attempts ------------------------------------------------------------ 541 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 22593 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:40:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:40:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363625.594283 (Exim 4.92) (envelope-from ) id 1o9r20-0004jH-Ob; Fri, 08 Jul 2022 16:40:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363625.594283; Fri, 08 Jul 2022 16:40:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r20-0004jA-Ll; Fri, 08 Jul 2022 16:40:40 +0000 Received: by outflank-mailman (input) for mailman id 363625; Fri, 08 Jul 2022 16:40:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r1y-0004hN-Qy for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:40:38 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b1d3bad1-fedc-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 18:40:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A651BB828B5; Fri, 8 Jul 2022 16:40:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E35DCC341C0; Fri, 8 Jul 2022 16:40:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1d3bad1-fedc-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657298435; bh=UNIZH4By+8EFj8FchRhVPyjYaE0OqZ6LjzqwVHA0WuU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=H6Y479DBzfHqzyrj/HnspR9IoUcI8HQ19rMUAhiepmsWwkIsIDuvm0Dff1+XT4apV +EWF0ppiHMM/KDOdmIfuyG/+C32YoGTJmM93wE39TrIFYfnoVIv+4vUzpZlGWCSOPy QC5G+MEnTGf6KbDF867xOEWzYmdT7IcnDLwwqCrZ+61tMnk7krOqKJm+vRG2Oo255j CzusNGaRev18bcUHz4IJ1ucPuk/N8Rd40jt0YKfQvnpw3ySf2G44TFF/6RNKQoEu06 iOPqO6NJAPBBEUFHnzNxgYbAfemCJZlgjh9JZDJDqYQ7YHTs81PAH3Z7lGlYuol1G0 tOkgtuKCzmolA== Date: Fri, 8 Jul 2022 09:40:33 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Penny Zheng cc: Stefano Stabellini , "julien@xen.org" , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree In-Reply-To: Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 7 Jul 2022, Penny Zheng wrote: > Hi Stefano and julien > > > -----Original Message----- > > From: Stefano Stabellini > > Sent: Thursday, July 7, 2022 7:53 AM > > To: Penny Zheng > > Cc: Stefano Stabellini ; Julien Grall ; > > xen-devel@lists.xenproject.org; Wei Chen ; Bertrand > > Marquis ; Volodymyr Babchuk > > > > Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest > > device tree > > > > On Mon, 4 Jul 2022, Penny Zheng wrote: > > > Hi Stefano and Julien > > > > > > > -----Original Message----- > > > > From: Stefano Stabellini > > > > Sent: Saturday, June 25, 2022 5:57 AM > > > > To: Julien Grall > > > > Cc: Penny Zheng ; > > > > xen-devel@lists.xenproject.org; Wei Chen ; > > Stefano > > > > Stabellini ; Bertrand Marquis > > > > ; Volodymyr Babchuk > > > > > > > > Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes in > > > > guest device tree > > > > > > > > On Fri, 24 Jun 2022, Julien Grall wrote: > > > > > On 20/06/2022 06:11, Penny Zheng wrote: > > > > > > We expose the shared memory to the domU using the "xen,shared- > > > > memory-v1" > > > > > > reserved-memory binding. See > > > > > > Documentation/devicetree/bindings/reserved-memory/xen,shared- > > > > memory. > > > > > > txt in Linux for the corresponding device tree binding. > > > > > > > > > > > > To save the cost of re-parsing shared memory device tree > > > > > > configuration when creating shared memory nodes in guest device > > > > > > tree, this commit adds new field "shm_mem" to store shm-info per > > > > > > domain. > > > > > > > > > > > > For each shared memory region, a range is exposed under the > > > > > > /reserved-memory node as a child node. Each range sub-node is > > > > > > named xen-shmem@
and has the following properties: > > > > > > - compatible: > > > > > > compatible = "xen,shared-memory-v1" > > > > > > - reg: > > > > > > the base guest physical address and size of the shared > > > > > > memory region > > > > > > - xen,id: > > > > > > a string that identifies the shared memory region. > > > > > > > > > > > > Signed-off-by: Penny Zheng > > > > > > Reviewed-by: Stefano Stabellini > > > > > > --- > > > > > > v5 change: > > > > > > - no change > > > > > > --- > > > > > > v4 change: > > > > > > - no change > > > > > > --- > > > > > > v3 change: > > > > > > - move field "shm_mem" to kernel_info > > > > > > --- > > > > > > v2 change: > > > > > > - using xzalloc > > > > > > - shm_id should be uint8_t > > > > > > - make reg a local variable > > > > > > - add #address-cells and #size-cells properties > > > > > > - fix alignment > > > > > > --- > > > > > > xen/arch/arm/domain_build.c | 143 > > > > +++++++++++++++++++++++++++++- > > > > > > xen/arch/arm/include/asm/kernel.h | 1 + > > > > > > xen/arch/arm/include/asm/setup.h | 1 + > > > > > > 3 files changed, 143 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > > > > b/xen/arch/arm/domain_build.c index 1584e6c2ce..4d62440a0e > > > > > > 100644 > > > > > > --- a/xen/arch/arm/domain_build.c > > > > > > +++ b/xen/arch/arm/domain_build.c > > > > > > @@ -900,7 +900,22 @@ static int __init > > > > > > allocate_shared_memory(struct domain *d, > > > > > > return ret; > > > > > > } > > > > > > -static int __init process_shm(struct domain *d, > > > > > > +static int __init append_shm_bank_to_domain(struct kernel_info > > *kinfo, > > > > > > + paddr_t start, paddr_t size, > > > > > > + u32 shm_id) { > > > > > > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > > > > > > + return -ENOMEM; > > > > > > + > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id = > > shm_id; > > > > > > + kinfo->shm_mem.nr_banks++; > > > > > > + > > > > > > + return 0; > > > > > > +} > > > > > > + > > > > > > +static int __init process_shm(struct domain *d, struct > > > > > > +kernel_info *kinfo, > > > > > > const struct dt_device_node *node) > > > > > > { > > > > > > struct dt_device_node *shm_node; @@ -971,6 +986,14 @@ > > > > > > static int __init process_shm(struct domain *d, > > > > > > if ( ret ) > > > > > > return ret; > > > > > > } > > > > > > + > > > > > > + /* > > > > > > + * Record static shared memory region info for later setting > > > > > > + * up shm-node in guest device tree. > > > > > > + */ > > > > > > + ret = append_shm_bank_to_domain(kinfo, gbase, psize, > > shm_id); > > > > > > + if ( ret ) > > > > > > + return ret; > > > > > > } > > > > > > return 0; > > > > > > @@ -1301,6 +1324,117 @@ static int __init > > make_memory_node(const > > > > > > struct domain *d, > > > > > > return res; > > > > > > } > > > > > > +#ifdef CONFIG_STATIC_SHM > > > > > > +static int __init make_shm_memory_node(const struct domain *d, > > > > > > + void *fdt, > > > > > > + int addrcells, int sizecells, > > > > > > + struct meminfo *mem) > > > > > > > > > > NIT: AFAICT mem is not changed, so it should be const. > > > > > > > > > > > +{ > > > > > > + unsigned long i = 0; > > > > > > > > > > NIT: This should be "unsigned int" to match the type of nr_banks. > > > > > > > > > > > + int res = 0; > > > > > > + > > > > > > + if ( mem->nr_banks == 0 ) > > > > > > + return -ENOENT; > > > > > > + > > > > > > + /* > > > > > > + * For each shared memory region, a range is exposed under > > > > > > + * the /reserved-memory node as a child node. Each range > > > > > > + sub-node > > > > is > > > > > > + * named xen-shmem@
. > > > > > > + */ > > > > > > + dt_dprintk("Create xen-shmem node\n"); > > > > > > + > > > > > > + for ( ; i < mem->nr_banks; i++ ) > > > > > > + { > > > > > > + uint64_t start = mem->bank[i].start; > > > > > > + uint64_t size = mem->bank[i].size; > > > > > > + uint8_t shm_id = mem->bank[i].shm_id; > > > > > > + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ > > > > > > + char buf[27]; > > > > > > + const char compat[] = "xen,shared-memory-v1"; > > > > > > + __be32 reg[4]; > > > > > > + __be32 *cells; > > > > > > + unsigned int len = (addrcells + sizecells) * > > > > > > + sizeof(__be32); > > > > > > + > > > > > > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, > > > > > > mem->bank[i].start); > > > > > > + res = fdt_begin_node(fdt, buf); > > > > > > + if ( res ) > > > > > > + return res; > > > > > > + > > > > > > + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); > > > > > > + if ( res ) > > > > > > + return res; > > > > > > + > > > > > > + cells = reg; > > > > > > + dt_child_set_range(&cells, addrcells, sizecells, start, > > > > > > + size); > > > > > > + > > > > > > + res = fdt_property(fdt, "reg", reg, len); > > > > > > + if ( res ) > > > > > > + return res; > > > > > > + > > > > > > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"- > > >%#"PRIx64"\n", > > > > > > + i, start, start + size); > > > > > > + > > > > > > + res = fdt_property_cell(fdt, "xen,id", shm_id); > > > > > > > > > > Looking at the Linux binding, "xen,id" is meant to be a string. > > > > > But here you are writing it as an integer. > > > > > > > > Good catch! > > > > > > > > > > > > > Given that the Linux binding is already merged, I think the Xen > > > > > binding should be changed. > > > > > > > > We would be compliant with both bindings (xen and linux) just by > > > > writing shm_id as string here, but if it is not too difficult we > > > > might as well harmonize the two bindings and also define xen,shm-id as a > > string. > > > > > > > > On the Xen side, I would suggest to put a clear size limit so that > > > > the string is easier to handle. > > > > > > I've already made the xen,shm-id parsed as a string too, seeing the below > > code: > > > " > > > prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); > > > if ( !prop_id ) > > > return -ENOENT; > > > shm_id = simple_strtoul(prop_id->data, NULL, 10); > > > if ( shm_id >= NR_MEM_BANKS ) > > > { > > > printk("fdt: invalid `xen,shm-id` %lu for static shared memory node.\n", > > > shm_id); > > > return -EINVAL; > > > } > > > " > > > The size limit is smaller than 256, just as stated in doc: > > > " > > > - xen,shm-id > > > > > > A string that represents the unique identifier of the shared memory > > > region. The maximum identifier shall be "xen,shm-id = 255". > > > " > > > Hope this fits what both of you suggested~~~ > > > > Yes. I think supporting arbitrary strings like "my-shared-mem-1" would be > > nice-to-have but I wouldn't make it a hard requirement. > > > > Oh, the example "my-shared-mem-1" really expands my mind, I think I understand > what you and Julien referred as free form string, which shall not be limited to only > numeric number... thanks!!! > > You were suggesting a strict limit on the number of characters, TBH, I have no clue > What the standard is here. Any suggestions? > > If considering padding, maybe 19? > " > struct membank { > paddr_t start; > paddr_t size; > bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ > #ifdef CONFIG_STATIC_SHM > char shm_id[19]; > unsigned int nr_shm_borrowers; > #endif > }; > " Yeah I suggested a strict limit on the number of chars so that we could embed the string in struct membank. I would pick 16 characters which is equivalent to two uint64_t in terms of memory usage. > > "255" as a string would match Linux's requirements for xen,id. > > I will use your example "my-shm-mem-1", I think its better for users > to understand, at least for me... +1 From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363638.594293 (Exim 4.92) (envelope-from ) id 1o9r9P-0005uz-Lm; Fri, 08 Jul 2022 16:48:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363638.594293; Fri, 08 Jul 2022 16:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r9P-0005uP-In; Fri, 08 Jul 2022 16:48:19 +0000 Received: by outflank-mailman (input) for mailman id 363638; Fri, 08 Jul 2022 16:48:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0g-0000b9-S2 for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:39:18 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8206c30e-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:39:18 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 6CC8C3200993; Fri, 8 Jul 2022 12:39:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 08 Jul 2022 12:39:16 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:39:14 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8206c30e-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298354; x=1657384754; bh=Bt0vZIuA0Rz6B2Rlr6YNUv8F+fLJYzOFEfj BkkL+cAY=; b=lmMhq9OdTAOEZc2M8YBrhqYYMRSpYYrTeOzweTHgFlAS7KeLide o3OVx3Bg6lIsRiMF66s0XQwZD6cJ8k4FUofUxs6wVCrTue+sA4Gwn7NrA1BxQHHh AOQX4gOBOz+b65OSb8QNe51cNLuNhQ4ujUFREKngnGaDHSNKLYiLlTyuQ1BccURT Q/ABOpk8wgCWIeDzjHsFmS2mwbCw0um+u01728yv5xT0D/H8f9PuYAnV0uzJY8GB xxdJkxB19SYkxmivJ1+48uAqcqGQu1ENIe5/CFPufHt6KgRxo0hUFUAaIifKmm60 ZMl4ZF9UaBUga0PPh83bNJZpfmnGCxVZjXA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298354; x=1657384754; bh=Bt0vZIuA0Rz6B 2Rlr6YNUv8F+fLJYzOFEfjBkkL+cAY=; b=b3ajPECKz9aHjqWA19Aga+aejWdNR ouc/27lMZ3zxZ8TodexAhgL90G85eNGXTcYtplRopFnzODsdtF+u/X9ZkjWB2lHt jJcP1rA3cDleZGOeguQqekN459aky+uFQ1KV3TQGUq9xUlfYnJyXC48E25UOouBg h07SslXAzHZ0xy280GaV2MlEnxnfb4dUZbuZq3vvHUDksVBiu603vmjOYQg4MjTq eki61S3Jp7oSpOgYgQy+s/zk2rZVbfNcKjWphn41SjZSWUdx3q28aagXOx0Cve5k Foi5cG3E3c+QrZbKlblOnfmhLbl32boJ9tgfttrx0TXLKrUAZb89ezY+A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 5.10] Ignore failure to unmap -1 Date: Fri, 8 Jul 2022 12:37:48 -0400 Message-Id: <20220708163750.2005-5-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 79963021fd71 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f415c056ff8ab8d808ee2bacfaa3cad57af28204..54fee4087bf1078803c230ad2081aafa8415cf53 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -401,7 +401,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363639.594299 (Exim 4.92) (envelope-from ) id 1o9r9Q-00060A-0W; Fri, 08 Jul 2022 16:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363639.594299; Fri, 08 Jul 2022 16:48:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r9P-0005zl-SS; Fri, 08 Jul 2022 16:48:19 +0000 Received: by outflank-mailman (input) for mailman id 363639; Fri, 08 Jul 2022 16:48:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0r-0000b9-Jd for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:39:29 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 886c1f80-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:39:28 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 795D63200991; Fri, 8 Jul 2022 12:39:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Jul 2022 12:39:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:39:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 886c1f80-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298365; x=1657384765; bh=Y+RlhIU6vcdXRbbN1vVgH9bjMqskW29Y/Ef fMgEqJZQ=; b=i0/UL2zjjaZXX/VULC54735TU47noiExIU73NHexI5Bxj2aiX0F PjAdIyLfS5znmLt3U1EGUiwZEdG1A6flSJXWRrMUCa2tkjwlI543rATLXmAUNsrI pH1Ds2+O0W8FbSA6Ij/JSpjmzJpcmHLj6/RmOg5Zgxu5ZnTNQnV3lR/tZLItROmH hX8FIXzq+o4uo6H2xTZZVCwwxd8EORCvTEpkmvlOVd/bobdCWkSFCI/1n5+f0gj9 GoJZ38iv25vQfBxx2Xw5rF1QdSwCXAeJwqDRnTJ/XBIXgn7G6ML8PfwdiFCgh/iO zAqAfbSgIdZfPeN2BoYmok605G8ljA7/7Cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298365; x=1657384765; bh=Y+RlhIU6vcdXR bbN1vVgH9bjMqskW29Y/EffMgEqJZQ=; b=UsExiFmmlq5Bhu1AZQbdi1EhWgfBR raj6TZCIoz3BqdlBkU8FnClfQyAswdg2uPwh4SwBA0lS9QJCb4WIv/6SD3oLYTK5 cIWCyhVU/KmdjWMxaoYU3tZc0Bg1cKnF8z1kibyqnUDvtD5vzZciVrMrt2bm1XYv odBZRxmKeM0axP7J85s/7c6WM9wzminmaU1SaR/EH6HbBpjDkcZsH3dKEysBWiOZ nrvkWxJcuolGzP3jOtgCDoM+ZIKZ/oiiK0EH1TKmgY/YhsqAcpjxL5YWVTG287s8 syxYcvHp1BGRpe94zwHU6e8Yp+kq/djehOfu/DDXH8rvT7jz2WXpofDhw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH master] Ignore failure to unmap INVALID_GRANT_HANDLE Date: Fri, 8 Jul 2022 12:37:51 -0400 Message-Id: <20220708163750.2005-8-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not INVALID_GRANT_HANDLE. The handle field of any page that was not successfully mapped will be INVALID_GRANT_HANDLE, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4b56c39f766d4da68570d08d963f6ef40c8d9c37..22fcd503f4a4487d0aed147c94f432683dad8c73 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -396,13 +396,17 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - WARN_ON(map->kunmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset+i].status && + map->kunmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:48:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:48:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363640.594315 (Exim 4.92) (envelope-from ) id 1o9r9V-0006Xi-9d; Fri, 08 Jul 2022 16:48:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363640.594315; Fri, 08 Jul 2022 16:48:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r9V-0006Xb-6C; Fri, 08 Jul 2022 16:48:25 +0000 Received: by outflank-mailman (input) for mailman id 363640; Fri, 08 Jul 2022 16:48:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0k-0000b9-GD for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:39:22 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 842eabe2-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:39:21 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5D1173200993; Fri, 8 Jul 2022 12:39:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 08 Jul 2022 12:39:20 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:39:18 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 842eabe2-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298358; x=1657384758; bh=YHeW7qifHVJ0i9ystBYmFItIOJUEYVweocj CTyeUqgE=; b=jozxi6B7GVXnmh3t8QDbYoD0le9OiP6un3wxgt4UxfGn6p4Ox6G 3Mt9davcEK5cq4PpMoo7jkdEexw6g4/okj2ltO/VMAK/z/CrhrgEYmiy5IFO0uMp 3lWrqlgMjepPOJB+UGXbDCH7fLHWsNis93BMNE3mtst/BcR4VPxERE3QQhhDPu0y WxA9NyTF7kUyow/dgs+JOObprVZAncPSjiH43W98FHXLfs++FVdcNGzbXOo1JiM/ OH3Obm1JMQSOk6X6SPg3GIm6qq2mX+j5ZGe0dJb6gBoj2Ri7NxwIlxAuIXhBimxv BiBUsjcOx2rcriKSpZEHamPe3pvKwEuBeMQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298358; x=1657384758; bh=YHeW7qifHVJ0i 9ystBYmFItIOJUEYVweocjCTyeUqgE=; b=t33tFCk2Kzkm8oAuKC+Qik1G4G6qh u60fY7a133jXVHsUkPzf+0CHG36quOgdZd7wQCQXqW65EJDh122LyPggu4UxJ3Hu U06nNVUmU7+YDJMkYVHQUlp6v/kvxR7CJNibtS5bzhmJRvks7pq4TC4HauNlhYT1 Y9pe2FKHTpnUJizyoS49hxHq/+XDY0whzFn+sAhHPb9NGsZ+CnA0Eo7DCy3g72Uf rHKfqNY4nnmYNVsACKGN+yzyamrUQk91bApUdFw5jYXORWEtaVqNQQtQ1+RdtxW8 1NF9bWXc2ujrnyX5NaaJ5wC3ElfMkK9GNwbuxbPuPO7aarr6WmhB7IoZg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedvne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 5.15] Ignore failure to unmap INVALID_GRANT_HANDLE Date: Fri, 8 Jul 2022 12:37:49 -0400 Message-Id: <20220708163750.2005-6-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not INVALID_GRANT_HANDLE. The handle field of any page that was not successfully mapped will be INVALID_GRANT_HANDLE, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 87a54feba68f ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4b56c39f766d4da68570d08d963f6ef40c8d9c37..22fcd503f4a4487d0aed147c94f432683dad8c73 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -396,13 +396,17 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - WARN_ON(map->kunmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset+i].status && + map->kunmap_ops[offset+i].handle != + INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 16:48:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 16:48:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363641.594327 (Exim 4.92) (envelope-from ) id 1o9r9b-00073x-Ie; Fri, 08 Jul 2022 16:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363641.594327; Fri, 08 Jul 2022 16:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r9b-00073f-FV; Fri, 08 Jul 2022 16:48:31 +0000 Received: by outflank-mailman (input) for mailman id 363641; Fri, 08 Jul 2022 16:48:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9r0c-0000b9-IM for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 16:39:14 +0000 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f74a74b-fedc-11ec-924f-1f966e50362f; Fri, 08 Jul 2022 18:39:13 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 6DD903200998; Fri, 8 Jul 2022 12:39:11 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Jul 2022 12:39:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 12:39:10 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f74a74b-fedc-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657298350; x=1657384750; bh=U3b/H981CGu0C2wC9Ts2JrTkTC7Oo8KLBZW KsNQwvjA=; b=sNlj8utVGC0vIfiqJuCfPiXc7bDpbSIghAa2ibMfR0+3lmre7h/ bkjqWOnQIq9JERNm8h2aCUPGpo1NBA7Cn+5LNQgOPFPKG2B4vtRLvWwX1feWkyxM kMuruV9kZBNSUsuZbyaUMSbzPRYx2GkYTfK8+6bkv530NGqimavpWfa8aSDho2MY 4m/tLHN+bSxGFLXaNP6sPthDn5A/FI+3Fa5kBzioe7Ejmle3CQb97nhLvZ5qPxQa e7QbcHFXFQGBwremK4ujrTCe0NNpxUnEqahDXuBjN0cX6knW9IivvrTmnLDpzuBt +WO+BI8Zrs/u7T78QDjQx5Pt26T3v41qJ0w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657298350; x=1657384750; bh=U3b/H981CGu0C 2wC9Ts2JrTkTC7Oo8KLBZWKsNQwvjA=; b=zXCBKYLSEAVEPR6sIJRpBCJLDFjZF Dzh8pqG/UgiCP9+pB2Yjcc6dtWFTkyMEjmAyZBbr25oSOfhaPQ4tUnDYJoAJ2SZ0 oML6LbPCU/fGYAB8HIvO8KiR8HJP1S31NrZwBFgfBIkW8OEcPPT49AplrsHDXMVg Rnqvse2u//zm/rLCxlpHqUm1q7Y1YwcH3agBeQEdIio7x0Kk2V4S67XJ0GoN8ufU n+WZJoPDKD3nkeskhHMJ68BN2W6wRSPelEZMezf/MeD4QOI3zAKFTT8I/jhGSb62 TrXPDQuKZOl5sRRag0ha9CfVDKAHxs415AaxuS16YPsP6Qt/4LY9XjOvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedguddtfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Greg KH , Stefano Stabellini , Oleksandr Tyshchenko , Demi Marie Obenour Cc: Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: [PATCH 5.4] Ignore failure to unmap -1 Date: Fri, 8 Jul 2022 12:37:47 -0400 Message-Id: <20220708163750.2005-4-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases wherr unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: ee25841221c1 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f464793477650e631c8928e85c1990c5964c2e94..bba849e5d8a7b4d54925b842fbe3c6792e0f0214 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -413,7 +413,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 19:24:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 19:24:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363669.594338 (Exim 4.92) (envelope-from ) id 1o9tZm-0006oY-M1; Fri, 08 Jul 2022 19:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363669.594338; Fri, 08 Jul 2022 19:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9tZm-0006oR-Iv; Fri, 08 Jul 2022 19:23:42 +0000 Received: by outflank-mailman (input) for mailman id 363669; Fri, 08 Jul 2022 19:23:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9tZk-0006oL-IH for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 19:23:40 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 779356e1-fef3-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 21:23:38 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id l23so7443604ejr.5 for ; Fri, 08 Jul 2022 12:23:37 -0700 (PDT) Received: from [192.168.1.10] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.gmail.com with ESMTPSA id ck10-20020a170906c44a00b006fec27575f1sm20584375ejb.123.2022.07.08.12.23.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Jul 2022 12:23:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 779356e1-fef3-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=khMA9Z2o/pNJ70arxNMGf2ZW/aNmrg75x+nik7Psr0E=; b=VFLqZKJxBK7NUHN1Jg1pMpDEcs+8VU00Ui2wAnrOaLkyhSpWwSc4vxYHtc4aWVsaQt E8WKAjG8fSd7iOrHG9SLcmK14tXwFENaE2RxZiOvhTa25z0sl/7oDAt0gtN0A5jPiRIM 0n7fYu1m5flm12YfjN2lBizqeDSktXyBoXW7vnOxJTzJFbh4wLRZLFe/k6WUteqfAo3x NkFnygICpCbQ4TZ8jx6DinupNEMH83WcrJE73tM5oqng5bNH4jAn7gi2UMqJQxhFsZt+ b9Psm9i/UcAsrUii8eOSe/Cd9X9Bz+wqv4ltRmTN+xXiEACqJnh4tYkIlB4//4rfSnad TjNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=khMA9Z2o/pNJ70arxNMGf2ZW/aNmrg75x+nik7Psr0E=; b=Pr+veRfodB2OpZqcob40bUgilUxtkjA/UWW++PNSE67sn8y0QNbuhZjl+wIBV4qyTf QAJvN5aP/0GTZO+1e7naPwLzLxq4XwS/cncqmo9e66ydcerLuQhTk/HXW5AoQHzOtk5f AI3to/riirwr0pn8Ww1OzCi8iDy7tbrHI7Cj/nVOYDwP9RwwyZL7SZ4dezczNwaokTzt Y57ZvcbHYAeK15vW2nVRUbabBdIxMZ9uJ7ihgaZsSa0rECEZVIAj4M69MFhtBAtVOxFv s8dGYLQiioJ5M7YAkKdpPqwWKHusfoAIbwtojztO6sJxrZWIwDHlU5DLIRvXw9im+NIW u1kA== X-Gm-Message-State: AJIora+50rJN4RbfEZx5xNKcJ1eq7aTtii5AF9tdGduAGaXycrNWpnUV KpXQhmbmbWpTW0R4mwzonyE= X-Google-Smtp-Source: AGRyM1vND14//KzhnTGNbZzJ3z2ROZdhtHTQwKMWX0j+EWu0kMdNXjUF4mlRBoQRhyBRvDlkIMsoyg== X-Received: by 2002:a17:907:c0a:b0:726:22b1:9734 with SMTP id ga10-20020a1709070c0a00b0072622b19734mr5098832ejc.195.1657308217467; Fri, 08 Jul 2022 12:23:37 -0700 (PDT) Message-ID: <870a02d8-e1ad-f848-f13b-b4573d8c99ac@gmail.com> Date: Fri, 8 Jul 2022 22:23:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Stefano Stabellini Cc: Stefano Stabellini , Julien Grall , xen-devel@lists.xenproject.org, Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/8/22 18:56, Stefano Stabellini wrote: > On Fri, 8 Jul 2022, Xenia Ragiadakou wrote: >> On 7/8/22 02:05, Stefano Stabellini wrote: >>> On Thu, 7 Jul 2022, Julien Grall wrote: >>>> Hi Xenia, >>>> >>>> On 07/07/2022 21:38, Xenia Ragiadakou wrote: >>>>> Add an arm subdirectory under automation/configs for the arm specific >>>>> configs >>>>> and add a config that enables static allocation. >>>>> >>>>> Modify the build script to search for configs also in this subdirectory >>>>> and >>>>> to >>>>> keep the generated xen binary, suffixed with the config file name, as >>>>> artifact. >>>>> >>>>> Create a test job that >>>>> - boots xen on qemu with a single direct mapped dom0less guest >>>>> configured >>>>> with >>>>> statically allocated memory >>>>> - verifies that the memory ranges reported in the guest's logs are the >>>>> same >>>>> with the provided static memory regions >>>>> >>>>> For guest kernel, use the 5.9.9 kernel from the tests-artifacts >>>>> containers. >>>>> Use busybox-static package, to create the guest ramdisk. >>>>> To generate the u-boot script, use ImageBuilder. >>>>> Use the qemu from the tests-artifacts containers. >>>>> >>>>> Signed-off-by: Xenia Ragiadakou >>>>> --- >>>>> automation/configs/arm/static_mem | 3 + >>>>> automation/gitlab-ci/test.yaml | 24 +++++ >>>>> automation/scripts/build | 4 + >>>>> automation/scripts/qemu-staticmem-arm64.sh | 114 >>>>> +++++++++++++++++++++ >>>>> 4 files changed, 145 insertions(+) >>>>> create mode 100644 automation/configs/arm/static_mem >>>>> create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >>>>> >>>>> diff --git a/automation/configs/arm/static_mem >>>>> b/automation/configs/arm/static_mem >>>>> new file mode 100644 >>>>> index 0000000000..84675ddf4e >>>>> --- /dev/null >>>>> +++ b/automation/configs/arm/static_mem >>>>> @@ -0,0 +1,3 @@ >>>>> +CONFIG_EXPERT=y >>>>> +CONFIG_UNSUPPORTED=y >>>>> +CONFIG_STATIC_MEMORY=y >>>>> \ No newline at end of file >>>> >>>> Any particular reason to build a new Xen rather enable >>>> CONFIG_STATIC_MEMORY in >>>> the existing build? >>>> >>>>> diff --git a/automation/scripts/build b/automation/scripts/build >>>>> index 21b3bc57c8..9c6196d9bd 100755 >>>>> --- a/automation/scripts/build >>>>> +++ b/automation/scripts/build >>>>> @@ -83,6 +83,7 @@ fi >>>>> # Build all the configs we care about >>>>> case ${XEN_TARGET_ARCH} in >>>>> x86_64) arch=x86 ;; >>>>> + arm64) arch=arm ;; >>>>> *) exit 0 ;; >>>>> esac >>>>> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>>>> rm -f xen/.config >>>>> make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} >>>>> defconfig >>>>> make -j$(nproc) -C xen >>>>> + if [[ ${arch} == "arm" ]]; then >>>>> + cp xen/xen binaries/xen-${cfg} >>>>> + fi >>>> >>>> This feels a bit of a hack to be arm only. Can you explain why this is not >>>> enabled for x86 (other than this is not yet used)? >>>> >>>>> done >>>>> diff --git a/automation/scripts/qemu-staticmem-arm64.sh >>>>> b/automation/scripts/qemu-staticmem-arm64.sh >>>>> new file mode 100755 >>>>> index 0000000000..5b89a151aa >>>>> --- /dev/null >>>>> +++ b/automation/scripts/qemu-staticmem-arm64.sh >>>>> @@ -0,0 +1,114 @@ >>>>> +#!/bin/bash >>>>> + >>>>> +base=(0x50000000 0x100000000) >>>>> +size=(0x10000000 0x10000000) >>>> >>>> From the name, it is not clear what the base and size refers too. Looking >>>> a >>>> bit below, it seems to be referring to the domain memory. If so, I would >>>> suggest to comment and rename to "domu_{base, size}". >>>> >>>>> + >>>>> +set -ex >>>>> + >>>>> +apt-get -qy update >>>>> +apt-get -qy install --no-install-recommends u-boot-qemu \ >>>>> + u-boot-tools \ >>>>> + device-tree-compiler \ >>>>> + cpio \ >>>>> + curl \ >>>>> + busybox-static >>>>> + >>>>> +# DomU Busybox >>>>> +cd binaries >>>>> +mkdir -p initrd >>>>> +mkdir -p initrd/bin >>>>> +mkdir -p initrd/sbin >>>>> +mkdir -p initrd/etc >>>>> +mkdir -p initrd/dev >>>>> +mkdir -p initrd/proc >>>>> +mkdir -p initrd/sys >>>>> +mkdir -p initrd/lib >>>>> +mkdir -p initrd/var >>>>> +mkdir -p initrd/mnt >>>>> +cp /bin/busybox initrd/bin/busybox >>>>> +initrd/bin/busybox --install initrd/bin >>>>> +echo "#!/bin/sh >>>>> + >>>>> +mount -t proc proc /proc >>>>> +mount -t sysfs sysfs /sys >>>>> +mount -t devtmpfs devtmpfs /dev >>>>> +/bin/sh" > initrd/init >>>>> +chmod +x initrd/init >>>>> +cd initrd >>>>> +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz >>>>> +cd ../.. >>>>> + >>>>> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded >>>>> +curl -fsSLO >>>>> https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom >>>>> + >>>>> +./binaries/qemu-system-aarch64 -nographic \ >>>>> + -M virtualization=true \ >>>>> + -M virt \ >>>>> + -M virt,gic-version=2 \ >>>>> + -cpu cortex-a57 \ >>>>> + -smp 2 \ >>>>> + -m 8G \ >>>>> + -M dumpdtb=binaries/virt-gicv2.dtb >>>>> + >>>>> +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts >>>>> + >>>>> +# ImageBuilder >>>>> +rm -rf imagebuilder >>>>> +git clone https://gitlab.com/ViryaOS/imagebuilder >>>>> + >>>>> +echo "MEMORY_START=\"0x40000000\" >>>>> +MEMORY_END=\"0x0200000000\" >>>>> + >>>>> +DEVICE_TREE=\"virt-gicv2.dtb\" >>>>> + >>>>> +XEN=\"xen-static_mem\" >>>>> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" >>>> >>>> AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is also >>>> not >>>> clear why you need to pass xsm=dummy. >>>> >>>>> + >>>>> +NUM_DOMUS=1 >>>>> +DOMU_MEM[0]=512 >>>>> +DOMU_VCPUS[0]=1 >>>>> +DOMU_KERNEL[0]=\"Image\" >>>>> +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" >>>>> +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" >>>>> +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" >>>>> + >>>>> +UBOOT_SOURCE=\"boot.source\" >>>>> +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config >>>>> + >>>>> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c >>>>> binaries/imagebuilder_config >>>>> + >>>>> +# Run the test >>>>> +rm -f qemu-staticmem.serial >>>>> +set +e >>>>> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source >>>>> 0x40000000"| \ >>>>> +timeout -k 1 60 ./binaries/qemu-system-aarch64 -nographic \ >>>>> + -M virtualization=true \ >>>>> + -M virt \ >>>>> + -M virt,gic-version=2 \ >>>>> + -cpu cortex-a57 \ >>>>> + -smp 2 \ >>>>> + -m 8G \ >>>>> + -no-reboot \ >>>>> + -device virtio-net-pci,netdev=vnet0 -netdev >>>>> user,id=vnet0,tftp=binaries >>>>> \ >>>>> + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >>>>> + -dtb ./binaries/virt-gicv2.dtb \ >>>>> + |& tee qemu-staticmem.serial >>>>> + >>>>> +set -e >>>> >>>> A lot of the code above is duplicated from qemu-smoke-arm64.sh. I think it >>>> would be better to consolidate in a single script. Looking briefly >>>> throught >>>> the existing scripts, it looks like it is possible to pass arguments (see >>>> qemu-smoke-x86-64.sh). >>> One idea would be to make the script common and "source" a second >>> script or config file with just the ImageBuilder configuration because >>> it looks like it is the only thing different. >>> >>> >>>>> + >>>>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || exit 1 >>>>> + >>>>> +for ((i=0; i<${#base[@]}; i++)) >>>>> +do >>>>> + start="$(printf "0x%016x" ${base[$i]})" >>>>> + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>>>> + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>>>> + if test $? -eq 1 >>>>> + then >>>>> + exit 1 >>>>> + fi >>>>> +done >>>> >>>> Please add a comment on top to explain what this is meant to do. However, >>>> I >>>> think we should avoid relying on output that we have written ourself. IOW, >>>> relying on Xen/Linux to always write the same message is risky because >>>> they >>>> can change at any time. >>> >>> Especially if we make the script common, then we could just rely on the >>> existing check to see if the guest started correctly (no special check >>> for static memory). >> >> In this case, how the test will verify that the static memory configuration >> has been taken into account and has not just been ignored? > > There is no simple way that I can think of. > > We can trust that it worked, without checking that the ranges were > actually static as requested. > > We can parse the Xen output like you did, although if it changes then > the test will break. > > Or we could add a script to detect and print specific output but I > don't know if there is something under /proc or /sys that we could > simply "cat" from bash to check it. > > If there is a simple way to do this by cat'ing /proc or /sys then I > think that would be great. Otherwise I think we could do as you did in > this patch, which is not perfect but it works and if something changes > in the Xen output we'll detect it right away given that gitlab-ci is run > pre-commit. Ok, I 'll send another patch that will enable static memory for all arm xen builds and will use a single script. For the static memory case, I will try to verify the values of the guest's dt memory node via /proc/device-tree. Also, I will do some minor cleanups in qemu-smoke-arm64.sh because there are some inconsistencies for instance the dtb is named virt-gicv3 while runs with gicv2, a comment states that qemu gets installed while it is taken from test-artifacts container. Thanks to both of you for the review. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 08 19:54:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 19:54:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363675.594349 (Exim 4.92) (envelope-from ) id 1o9u3P-0003Yr-6z; Fri, 08 Jul 2022 19:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363675.594349; Fri, 08 Jul 2022 19:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9u3P-0003Yk-3n; Fri, 08 Jul 2022 19:54:19 +0000 Received: by outflank-mailman (input) for mailman id 363675; Fri, 08 Jul 2022 19:54:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9u3O-0003Ye-EK for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 19:54:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9u3O-0003eq-4j; Fri, 08 Jul 2022 19:54:18 +0000 Received: from [54.239.6.184] (helo=[192.168.18.9]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1o9u3N-0006S2-MS; Fri, 08 Jul 2022 19:54:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=rsKtzebgHNoI9DQVWrmHNJdycQ8IO4uAkc5ns2Wozgk=; b=U972Z9fhhYYRU3TCEd0MS5ujsI A2ihkCR73Pkk8OjO7dhiJPxDTCC4IOT1BLOhXfgPSYP1dir5gmNx4YM6urQOel1NuapBWGn/EutZv zHBecNm+7cAPnycvVqm9IB/TYi3svmCXHmAJr/1OmLqjdJ8OxPPTROhrHrpAwQDQxiRU=; Message-ID: Date: Fri, 8 Jul 2022 20:54:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Jens Wiklander , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: <20220622134219.1596613-3-jens.wiklander@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jens, This is the second part of the review. On 22/06/2022 14:42, Jens Wiklander wrote: > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > + struct ffa_address_range *range, uint32_t range_count, AFAICT, 'range' is not meant to be modified. So I would add 'const'. > + unsigned int start_page_idx, > + unsigned int *last_page_idx) > +{ > + unsigned int pg_idx = start_page_idx; > + unsigned long gfn; Below you are using gaddr_to_gfn() which will return gfn_t. This is using the typesafe infrastructure: gfn_t will be a structure with CONFIG_DEBUG=y to allow type checking and a plain 'unsigned long' when CONFIG_DEBUG=n. Please make sure to test build with CONFIG_DEBUG=y. As a side note, I would suggest to try booting as CONFIG_DEBUG as it enables extra check for the common pitfalls. > + unsigned int n; > + unsigned int m; > + p2m_type_t t; > + uint64_t addr; > + > + for ( n = 0; n < range_count; n++ ) > + { > + for ( m = 0; m < range[n].page_count; m++ ) > + { > + if ( pg_idx >= shm->page_count ) > + return FFA_RET_INVALID_PARAMETERS; Shouldn't we call put_page() to drop the references taken by get_page_from_gfn()? > + > + addr = read_atomic(&range[n].address); IIUC, range is part of the shared page with the guest. Where do you check that all the access will be within the shared page? > + gfn = gaddr_to_gfn(addr + m * PAGE_SIZE); Is addr meant to be page-aligned? Also, you are using the hypervisor page size here when AFAICT page_count is provided by the domain. How do you guarantee that both Xen and the domain agree on the page size? > + shm->pages[pg_idx] = get_page_from_gfn(d, gfn, &t, P2M_ALLOC); > + if ( !shm->pages[pg_idx] ) > + return FFA_RET_DENIED; > + pg_idx++; > + /* Only normal RAM for now */ Similar to my earlier remark, the comment doesn't match the check below. > + if ( t != p2m_ram_rw ) > + return FFA_RET_DENIED; > + } > + } > + > + *last_page_idx = pg_idx; > + > + return FFA_RET_OK; > +} > + > +static void put_shm_pages(struct ffa_shm_mem *shm) > +{ > + unsigned int n; > + > + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) > + { > + put_page(shm->pages[n]); > + shm->pages[n] = NULL; > + } > +} > + > +static void init_range(struct ffa_address_range *addr_range, > + paddr_t pa) > +{ > + memset(addr_range, 0, sizeof(*addr_range)); > + addr_range->address = pa; > + addr_range->page_count = 1; > +} > + > +static int share_shm(struct ffa_shm_mem *shm) AFAIU, share_shm() cannot be concurrently called. You seem to use ffa_buffer_lock to guarantee that. So I would suggest to add: 1) an ASSERT(spin_is_Locked(&ffa_buffer_lock)) 2) a comment on top of share_shm() explaining that the function should be called with ffa_buffer_lock taken. > +{ > + uint32_t max_frag_len = ffa_page_count * PAGE_SIZE; > + struct ffa_mem_transaction_1_1 *descr = ffa_tx; > + struct ffa_mem_access *mem_access_array; > + struct ffa_mem_region *region_descr; > + struct ffa_address_range *addr_range; > + paddr_t pa; > + paddr_t last_pa; > + unsigned int n; > + uint32_t frag_len; > + uint32_t tot_len; > + int ret; > + unsigned int range_count; > + unsigned int range_base; > + bool first; > + > + memset(descr, 0, sizeof(*descr)); > + descr->sender_id = shm->sender_id; > + descr->global_handle = shm->handle; > + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; > + descr->mem_access_count = 1; > + descr->mem_access_size = sizeof(*mem_access_array); > + descr->mem_access_offs = sizeof(*descr); > + mem_access_array = (void *)(descr + 1); > + region_descr = (void *)(mem_access_array + 1); The (void *)(descr + 1) seems to be very common in your comment. Can you consider to add a wrapper? This will make easier to read the code? > + > + memset(mem_access_array, 0, sizeof(*mem_access_array)); > + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; > + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; > + mem_access_array[0].region_offs = (vaddr_t)region_descr - (vaddr_t)ffa_tx; Same for calculating the offset. > + > + memset(region_descr, 0, sizeof(*region_descr)); > + region_descr->total_page_count = shm->page_count; > + > + region_descr->address_range_count = 1; > + last_pa = page_to_maddr(shm->pages[0]); For hardening purpose, I would suggest to check if shm->page_count is at least 1. If you think this could be a programming error then you could write: if ( .... ) { ASSERT_UNREACHABLE() return ; } > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > + { > + pa = page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE == pa ) > + { Coding style: We usually avoid {} for single line. > + continue; > + } > + region_descr->address_range_count++; > + } > + > + tot_len = sizeof(*descr) + sizeof(*mem_access_array) + > + sizeof(*region_descr) + > + region_descr->address_range_count * sizeof(*addr_range); How do you make sure that you will not write past the end of ffa_tx? I think it would be worth to consider adding an helper that would allow you to allocate space in ffa_tx and zero it. This would return an error if there is not enough space. > + > + addr_range = region_descr->address_range_array; > + frag_len = (vaddr_t)(addr_range + 1) - (vaddr_t)ffa_tx; > + last_pa = page_to_maddr(shm->pages[0]); > + init_range(addr_range, last_pa); > + first = true; > + range_count = 1; > + range_base = 0; > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > + { > + pa = page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE == pa ) > + { > + addr_range->page_count++; > + continue; > + } > + > + if ( frag_len == max_frag_len ) > + { > + if ( first ) > + { > + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > + first = false; > + } > + else > + { > + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > + } > + if ( ret <= 0) Coding style: Missing space before ). > + return ret; > + range_base = range_count; You set range_base but don't seem to read it > + range_count = 0; Same here. > + frag_len = sizeof(*addr_range); > + addr_range = ffa_tx; > + } > + else > + { > + frag_len += sizeof(*addr_range); > + addr_range++; > + } > + init_range(addr_range, pa); > + range_count++; > + } > + > + if ( first ) > + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > + else > + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > +} > + > +static int read_mem_transaction(uint32_t ffa_vers, void *buf, size_t blen, buf should be const if it is not meant to be modified by the function. > + struct ffa_mem_transaction_x *trans) > +{ > + uint16_t mem_reg_attr; > + uint32_t flags; > + uint32_t count; > + uint32_t offs; > + uint32_t size; > + > + if ( ffa_vers >= FFA_VERSION_1_1 ) > + { > + struct ffa_mem_transaction_1_1 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr = buf; > + trans->sender_id = read_atomic(&descr->sender_id); AFAIU, descr point to guest data. If yes, then we can't trust input. In which case, is this really necessary to use read_atomic() for every access? The reason I am asking is read_atomic() is quite a hammer when a compiler barrier should be sufficient. > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > + flags = read_atomic(&descr->flags); > + trans->global_handle = read_atomic(&descr->global_handle); > + trans->tag = read_atomic(&descr->tag); > + > + count = read_atomic(&descr->mem_access_count); > + size = read_atomic(&descr->mem_access_size); > + offs = read_atomic(&descr->mem_access_offs); > + } > + else > + { > + struct ffa_mem_transaction_1_0 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr = buf; > + trans->sender_id = read_atomic(&descr->sender_id); > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > + flags = read_atomic(&descr->flags); > + trans->global_handle = read_atomic(&descr->global_handle); > + trans->tag = read_atomic(&descr->tag); > + > + count = read_atomic(&descr->mem_access_count); > + size = sizeof(struct ffa_mem_access); > + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); > + } > + > + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || AFAIU, these checks are to ensure that the fields fit in your structure below. However, it is not clear to me why we are capping the values provided by the domain. I think this would be good to explain it in a comment. > + count > UINT8_MAX || offs > UINT16_MAX ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Check that the endpoint memory access descriptor array fits */ > + if ( size * count + offs > blen ) > + return FFA_RET_INVALID_PARAMETERS; > + > + trans->mem_reg_attr = mem_reg_attr; > + trans->flags = flags; > + trans->mem_access_size = size; > + trans->mem_access_count = count; > + trans->mem_access_offs = offs; > + return 0; > +} > + > +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, > + unsigned int frag_len) > +{ > + struct domain *d = current->domain; > + unsigned int o = offs; > + unsigned int l; > + int ret; > + > + if ( frag_len < o ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Fill up the first struct ffa_address_range */ > + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); > + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); > + s->range_offset += l; > + o += l; > + if ( s->range_offset != sizeof(s->range) ) > + goto out; > + s->range_offset = 0; > + > + while ( true ) > + { > + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, > + &s->current_page_idx); > + if ( ret ) > + return ret; > + if ( s->range_count == 1 ) > + return 0; > + s->range_count--; > + if ( frag_len - o < sizeof(s->range) ) > + break; > + memcpy(&s->range, s->buf + o, sizeof(s->range)); > + o += sizeof(s->range); > + } > + > + /* Collect any remaining bytes for the next struct ffa_address_range */ > + s->range_offset = frag_len - o; > + memcpy(&s->range, s->buf + o, frag_len - o); > +out: > + s->frag_offset += frag_len; > + return s->frag_offset; > +} > + > +static void handle_mem_share(struct cpu_user_regs *regs) > +{ > + uint32_t tot_len = get_user_reg(regs, 1); > + uint32_t frag_len = get_user_reg(regs, 2); > + uint64_t addr = get_user_reg(regs, 3); > + uint32_t page_count = get_user_reg(regs, 4); > + struct ffa_mem_transaction_x trans; > + struct ffa_mem_access *mem_access; > + struct ffa_mem_region *region_descr; > + struct domain *d = current->domain; > + struct ffa_ctx *ctx = d->arch.ffa; > + struct ffa_shm_mem *shm = NULL; > + unsigned int last_page_idx = 0; > + uint32_t range_count; > + uint32_t region_offs; > + int ret = FFA_RET_DENIED; > + uint32_t handle_hi = 0; > + uint32_t handle_lo = 0; > + > + /* > + * We're only accepting memory transaction descriptors via the rx/tx > + * buffer. > + */ > + if ( addr ) > + { > + ret = FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + /* Check that fragment legnth doesn't exceed total length */ Typo: s/legnth/length/ > + if ( frag_len > tot_len ) > + { > + ret = FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + spin_lock(&ctx->lock); > + > + if ( frag_len > ctx->page_count * PAGE_SIZE ) > + goto out_unlock; > + > + if ( !ffa_page_count ) > + { > + ret = FFA_RET_NO_MEMORY; > + goto out_unlock; > + } > + > + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); > + if ( ret ) > + goto out_unlock; > + > + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) > + { > + ret = FFA_RET_NOT_SUPPORTED; > + goto out; > + } > + > + /* Only supports sharing it with one SP for now */ > + if ( trans.mem_access_count != 1 ) > + { > + ret = FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + if ( trans.sender_id != get_vm_id(d) ) > + { > + ret = FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + /* Check that it fits in the supplied data */ > + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) > + goto out_unlock; > + > + mem_access = (void *)((vaddr_t)ctx->tx + trans.mem_access_offs); There are a bit too much open-cast in this series. Please try to reduce the numbers. In this case, the two casts are unnecessary because tx is already a void pointer. In addition to that, ctx->tx could be a "const void *" because it is not meant to be written by Xen. The const would also needs to be propagated to mem_access & co. > + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) > + { > + ret = FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_offs = read_atomic(&mem_access->region_offs); > + if ( sizeof(*region_descr) + region_offs > frag_len ) > + { > + ret = FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_descr = (void *)((vaddr_t)ctx->tx + region_offs); > + range_count = read_atomic(®ion_descr->address_range_count); > + page_count = read_atomic(®ion_descr->total_page_count); > + > + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count) This will allow a guest to allocate an arbitrarily large array in Xen. So please sanitize page_count before using it. > + if ( !shm ) > + { > + ret = FFA_RET_NO_MEMORY; > + goto out; > + } > + shm->sender_id = trans.sender_id; > + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); > + shm->page_count = page_count; > + > + if ( frag_len != tot_len ) > + { > + struct mem_frag_state *s = xzalloc(struct mem_frag_state); > + > + if ( !s ) > + { > + ret = FFA_RET_NO_MEMORY; > + goto out; > + } > + s->shm = shm; > + s->range_count = range_count; > + s->buf = ctx->tx; > + s->buf_size = ffa_page_count * PAGE_SIZE; > + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, > + frag_len); > + if ( ret <= 0 ) > + { > + xfree(s); > + if ( ret < 0 ) > + goto out; > + } > + else > + { > + shm->handle = next_handle++; > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + list_add_tail(&s->list, &ctx->frag_list); > + } > + goto out_unlock; > + } > + > + /* > + * Check that the Composite memory region descriptor fits. > + */ > + if ( sizeof(*region_descr) + region_offs + > + range_count * sizeof(struct ffa_address_range) > frag_len ) > + { > + ret = FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, > + 0, &last_page_idx); > + if ( ret ) > + goto out; > + if ( last_page_idx != shm->page_count ) > + { > + ret = FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + /* Note that share_shm() uses our tx buffer */ > + spin_lock(&ffa_buffer_lock); > + ret = share_shm(shm); > + spin_unlock(&ffa_buffer_lock); > + if ( ret ) > + goto out; > + > + spin_lock(&ffa_mem_list_lock); > + list_add_tail(&shm->list, &ffa_mem_list); A couple of questions: - What is the maximum size of the list? - Why is the list is global rather than per domain? In fact, looking at handle_mem_reclaim() it looks like a domain could potentially reclaim in memory (we don't seem to sanitize the input other than checking the handle is used). So it seems to me the list should be per-domain. > + spin_unlock(&ffa_mem_list_lock); > + > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + > +out: > + if ( ret && shm ) > + { > + put_shm_pages(shm); > + xfree(shm); > + } > +out_unlock: > + spin_unlock(&ctx->lock); > + > + if ( ret > 0 ) > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); > + else if ( ret == 0) Coding style: missing space before ). > + set_regs_success(regs, handle_lo, handle_hi); > + else > + set_regs_error(regs, ret); > +} > + I will continue the review later on. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 08 21:35:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 21:35:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363681.594360 (Exim 4.92) (envelope-from ) id 1o9vcS-0002Oj-C4; Fri, 08 Jul 2022 21:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363681.594360; Fri, 08 Jul 2022 21:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9vcS-0002Oc-9B; Fri, 08 Jul 2022 21:34:36 +0000 Received: by outflank-mailman (input) for mailman id 363681; Fri, 08 Jul 2022 21:34:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9vcQ-0002OW-TU for xen-devel@lists.xenproject.org; Fri, 08 Jul 2022 21:34:35 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bfdc1c8d-ff05-11ec-bd2d-47488cf2e6aa; Fri, 08 Jul 2022 23:34:31 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id AD3225C01C6; Fri, 8 Jul 2022 17:34:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 08 Jul 2022 17:34:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 8 Jul 2022 17:34:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfdc1c8d-ff05-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657316069; x=1657402469; bh=ZvfwDQKsaqgWSclCfQajDVrN5ftLm2Vl2Hi 1zLQKAI8=; b=gQKgSb8c3Tl4TTzcU+0D0F+GvNKaxrTIHHP3xgkMRqujZROHdEl eCr16QdJiXXLff9UmKD2U+cd7tS7RFafpni1/16mnmpn0dAQeWzUWWRFGc6gwOoo VrFqOsAvC/W6+Va+RDfiqcohhLgIIYe7LrJu+MbFmSTNjSgIG3ZhdoOc6gCajTdC xOs07m8O85lAQzSXLdsXHTiT6ZCQeK4uMG0kn/sGA/mfxC/i0MdqwUJo+iZTyogY Al+e/SXnBjKsjTSlop7/I2Crr3EBo+YSalvkft4ANLHznjGj+aKasYX7q3ZbhARJ O1hRTdD6Cz0QoSLzaXLzePRicLrWPeMNDAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657316069; x=1657402469; bh=ZvfwDQKsaqgWS clCfQajDVrN5ftLm2Vl2Hi1zLQKAI8=; b=Sl97MZIOVr7XhkxA/5dsEs8eGc64d 82lGqVRkkjNsHpaRwJ6bko7aUi9ipIhe6vy7H1ztwH4a85DEpv0Ao17O6Mdwi7y3 P7JrKtrFUho3CrdedTGIqFft+BFjaiJRoyfolmjto981AnfbCU1S2xNXjC8jQBAZ WKnzZN4ttuBdyhvMVuDRa2d8+8fAMA4q/O2XXprsR208BPwJK0YX7NdiiH1vUyD4 NKzvmiPq7yMPOzr6eINaA4Pt05lYZwjsY6RJrWHsypWW7meZtWaKJtgRWCnqvPip e4Rge5zGoDBN2iUePk+x26zTfRv/uanuzu54vxPkexDDQLmyVyEQ14NbA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudeijedgudeivdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffogggtgfesthekredtredtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepkeeileejueetgfeijeffgfelhfei teevffelfedufeejgeeljedvledvfeeuffevnecuffhomhgrihhnpehkvghrnhgvlhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Xen development discussion Cc: Demi Marie Obenour , Jan Beulich Subject: [PATCH v9] Preserve the EFI System Resource Table for dom0 Date: Fri, 8 Jul 2022 17:34:03 -0400 Message-Id: <20220708213403.2390-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Tested using qemu-system-x86_64 and xen.efi. Signed-off-by: Demi Marie Obenour --- xen/common/efi/boot.c | 134 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 134 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..d2f66a430d 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -39,6 +39,26 @@ { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b, 0x23} } #define APPLE_PROPERTIES_PROTOCOL_GUID \ { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a, 0xe0} } +#define EFI_SYSTEM_RESOURCE_TABLE_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} } +#define EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION 1 + +typedef struct { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 LowestSupportedFwVersion; + UINT32 CapsuleFlags; + UINT32 LastAttemptVersion; + UINT32 LastAttemptStatus; +} EFI_SYSTEM_RESOURCE_ENTRY; + +typedef struct { + UINT32 FwResourceCount; + UINT32 FwResourceCountMax; + UINT64 FwResourceVersion; + EFI_SYSTEM_RESOURCE_ENTRY Entries[]; +} EFI_SYSTEM_RESOURCE_TABLE; typedef EFI_STATUS (/* _not_ EFIAPI */ *EFI_SHIM_LOCK_VERIFY) ( @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) } #endif +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR; + +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start = desc->PhysicalStart; + const EFI_SYSTEM_RESOURCE_TABLE *esrt_ptr; + + len = desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt == EFI_INVALID_TABLE_ADDR ) + return 0; + if ( physical_start > esrt || esrt - physical_start >= len ) + return 0; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type != EfiRuntimeServicesData) && + (desc->Type != EfiBootServicesData) ) + return 0; + available_len = len - (esrt - physical_start); + if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) + return 0; + available_len -= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); + esrt_ptr = (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; + if ( (esrt_ptr->FwResourceVersion != + EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION) || + !esrt_ptr->FwResourceCount ) + return 0; + if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->Entries[0]) ) + return 0; + + return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +900,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, return gop_mode; } +static EFI_GUID __initdata esrt_guid = EFI_SYSTEM_RESOURCE_TABLE_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +925,8 @@ static void __init efi_tables(void) efi.smbios = (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 = (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt = (UINTN)efi_ct[i].VendorTable; } #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) +{ + EFI_STATUS status; + UINTN info_size = 0, map_key, mdesc_size; + void *memory_map = NULL; + UINT32 ver; + unsigned int i; + + for ( ; ; ) { + status = efi_bs->GetMemoryMap(&info_size, memory_map, &map_key, + &mdesc_size, &ver); + if ( status == EFI_SUCCESS && memory_map != NULL ) + break; + if ( status == EFI_BUFFER_TOO_SMALL || memory_map == NULL ) + { + info_size += 8 * mdesc_size; + if ( memory_map != NULL ) + efi_bs->FreePool(memory_map); + memory_map = NULL; + status = efi_bs->AllocatePool(EfiLoaderData, info_size, &memory_map); + if ( status == EFI_SUCCESS ) + continue; + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); + } + else + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); + return; + } + + /* Try to obtain the ESRT. Errors are not fatal. */ + for ( i = 0; i < info_size; i += mdesc_size ) + { + /* + * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * so that the memory it is in will not be used for other purposes. + */ + void *new_esrt = NULL; + size_t esrt_size = get_esrt_size(memory_map + i); + + if ( !esrt_size ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(memory_map + i))->Type == + EfiRuntimeServicesData ) + break; /* ESRT already safe from reuse */ + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + &new_esrt); + if ( status == EFI_SUCCESS && new_esrt ) + { + memcpy(new_esrt, (void *)esrt, esrt_size); + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); + if ( status != EFI_SUCCESS ) + { + PrintErr(L"Cannot install new ESRT\r\n"); + efi_bs->FreePool(new_esrt); + } + } + else + PrintErr(L"Cannot allocate memory for ESRT\r\n"); + break; + } + + efi_bs->FreePool(memory_map); +} + static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) { EFI_STATUS status; @@ -1413,6 +1536,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) if ( gop ) efi_set_gop_mode(gop, gop_mode); + efi_relocate_esrt(SystemTable); + efi_exit_boot(ImageHandle, SystemTable); efi_arch_post_exit_boot(); /* Doesn't return. */ @@ -1753,3 +1878,12 @@ void __init efi_init_memory(void) unmap_domain_page(efi_l4t); } #endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Fri Jul 08 23:21:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 08 Jul 2022 23:21:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363687.594370 (Exim 4.92) (envelope-from ) id 1o9xHC-0002mC-4e; Fri, 08 Jul 2022 23:20:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363687.594370; Fri, 08 Jul 2022 23:20:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9xHC-0002m5-1i; Fri, 08 Jul 2022 23:20:46 +0000 Received: by outflank-mailman (input) for mailman id 363687; Fri, 08 Jul 2022 23:20:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9xHA-0002lv-MT; Fri, 08 Jul 2022 23:20:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9xHA-0007UG-J7; Fri, 08 Jul 2022 23:20:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9xHA-0002Fb-0r; Fri, 08 Jul 2022 23:20:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9xHA-0000Q3-0P; Fri, 08 Jul 2022 23:20:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pqA6WIwUR1X2BP8ndhIls8xgQIIjI6DOksVLjm4AIak=; b=piRZQPcu/ScQd1tweHqKQQ2Vbb QnPKBWUp7guH1ZWfj3uq3RnC1JBEpVQwKEuk3d1/l98UZ6EZXAqObx2tHq20Ftuve6uFTEZwhYxWF 5FwL4kp7R3vSkH13l/uKRwqyDkMZO8oMo/2Bx57HxAT65FvlKQMkSVhi0O4TtDUP9ggA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171559: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=63b38f6c85acd312c2cab68554abf33adf4ee2b3 X-Osstest-Versions-That: qemuu=0e3723005bfea2f70157bf951f3e6be03bbf6e74 From: osstest service owner Date: Fri, 08 Jul 2022 23:20:44 +0000 flight 171559 qemu-mainline real [real] flight 171562 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171559/ http://logs.test-lab.xenproject.org/osstest/logs/171562/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 171562-retest test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171562-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171539 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171539 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171539 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171539 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171539 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 63b38f6c85acd312c2cab68554abf33adf4ee2b3 baseline version: qemuu 0e3723005bfea2f70157bf951f3e6be03bbf6e74 Last test of basis 171539 2022-07-07 01:09:39 Z 1 days Failing since 171544 2022-07-07 08:35:56 Z 1 days 3 attempts Testing same since 171559 2022-07-08 10:32:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexey Kardashevskiy Christian Borntraeger Daniel Henrique Barboza Dominique Martinet Fabiano Rosas Janis Schoetterl-Glausch Jason A. Donenfeld Matheus Ferst Murilo Opsfelder Araujo Pali Rohár Peter Maydell Richard Henderson Stefan Hajnoczi Thomas Huth Víctor Colombo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0e3723005b..63b38f6c85 63b38f6c85acd312c2cab68554abf33adf4ee2b3 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Jul 09 01:25:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 01:25:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363696.594382 (Exim 4.92) (envelope-from ) id 1o9zDC-0007Hi-50; Sat, 09 Jul 2022 01:24:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363696.594382; Sat, 09 Jul 2022 01:24:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zDC-0007Hb-1o; Sat, 09 Jul 2022 01:24:46 +0000 Received: by outflank-mailman (input) for mailman id 363696; Sat, 09 Jul 2022 01:24:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zDA-0007HV-5x for xen-devel@lists.xen.org; Sat, 09 Jul 2022 01:24:44 +0000 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e78c2f5e-ff25-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 03:24:40 +0200 (CEST) Received: by mail-ed1-f53.google.com with SMTP id x91so429899ede.1 for ; Fri, 08 Jul 2022 18:24:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e78c2f5e-ff25-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MsipBRfP8SBn/LlTsOcbdFBOW8KdxMFiLxrDlyfGQdY=; b=FrCn/VfnBZ+mvC0MXh2/KB17kkPFuYt5GXFZymqd5Lnp3SmC0eTaTPG4Xtqzzq8ndw VTuKBHMftA0w3kOAEKtCWG/Nu1FN6wOxOBo+LTgmFtulu5yDkoZodvgO8SPiu/3qFige avXJn1ngv8y8n/U9SfaSW4WpNpEPl/ve41dCm4+Z7kA3slEjX5jIyCw8fHCGyoXuPMY/ S2rTx7IFRysGdpaMZrgdTA7J4/00yJA4Cn+tUDMx9+H+W9xya2lkI9CiH54y9JF9Gchb W+LrZty7I9bN5Xmjld3mjrI3rdFqgbf5y7+tmqcH/lsKRloJiE+Ua8w2gUiUaEB5eB1h P3Iw== X-Gm-Message-State: AJIora/0Qfbc9+30lBmLh6z7TSXW9pPjlM5c27ueed7FbfDVkm1NZSQa 30/64IEr6Tp5pMluolLDZ2Q5A6mXLZH8oCjXczE= X-Google-Smtp-Source: AGRyM1u4Hn32apIYcOeJS6ad+9IbLK2PJjV3SwFsIfNOQmX8hoxbww6lrUpixKyrP6vHP60u/pyb+V1eDM67gyKN5FM= X-Received: by 2002:a05:6402:42cb:b0:43a:5df2:bb5d with SMTP id i11-20020a05640242cb00b0043a5df2bb5dmr8518752edc.36.1657329880090; Fri, 08 Jul 2022 18:24:40 -0700 (PDT) MIME-Version: 1.0 References: <93c7b016-06f9-e3d2-5a7f-97a5f15c1a86@suse.com> In-Reply-To: From: "G.R." Date: Sat, 9 Jul 2022 09:24:27 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony Perard Content-Type: multipart/mixed; boundary="000000000000c770d405e3552e0d" --000000000000c770d405e3552e0d Content-Type: text/plain; charset="UTF-8" On Fri, Jul 8, 2022 at 10:28 AM G.R. wrote: > > On Fri, Jul 8, 2022 at 12:38 AM Jan Beulich wrote: > > > But the 'xl pci-assignable-remove' will lead to xl segmentation fault... > > >> [ 655.041442] xl[975]: segfault at 0 ip 00007f2cccdaf71f sp 00007ffd73a3d4d0 error 4 in libxenlight.so.4.16.0[7f2cccd92000+7c000] > > >> [ 655.041460] Code: 61 06 00 eb 13 66 0f 1f 44 00 00 83 c3 01 39 5c 24 2c 0f 86 1b 01 00 00 48 8b 34 24 89 d8 4d 89 f9 4d 89 f0 4c 89 e9 4c 89 e2 <48> 8b 3c c6 31 c0 48 89 ee e8 53 44 fe ff 83 f8 04 75 ce 48 8b 44 > > > > That'll need debugging. Cc-ing Anthony for awareness, but I'm sure > > he'll need more data to actually stand a chance of doing something > > about it. > > > > Is there any chance you could be doing some debugging work yourself, > > at the very least to figure out where this (apparent) NULL deref is > > happening? > Yep, I can collect the call-stack for sure. The call-stack of the segfault is like this: 0x00007ffff7f0971f in name2bdf () from /usr/lib/libxenlight.so.4.16 (gdb) bt #0 0x00007ffff7f0971f in name2bdf () from /usr/lib/libxenlight.so.4.16 #1 0x00007ffff7f0a75e in libxl_device_pci_assignable_remove () from /usr/lib/libxenlight.so.4.16 #2 0x00005555555725bf in main_pciassignable_remove () #3 0x00005555555610ab in main () It's with a release version of libxenlight. Once I switch it to a debug version, the segment fault just goes away... This allows me to move on and test the behavior on 4.16.1 -- unfortunately no change observed at all. Once I get the SSD assigned to the FreeeBSD 12 domU, the domU still sees the device but fails to operate. This time I also built the debug version of 4.16.1 hypervisor. But unfortunately it shares the same reboot on the first pci-assignable-add problem. I cannot follow the suggestion of attaching a serial console yet. The motherboard does have a serial port connector, but I do not have a cable at the moment. Maybe I can grab one, but it takes some time... What I was able to do is to dump the 'xl dmesg' output from the dom0 boot with a debug hypervisor (see attached). It does give a few extra lines and hope they could be helpful. Thanks, G.R. --000000000000c770d405e3552e0d Content-Type: text/x-log; charset="US-ASCII"; name="xldmesg_4.16.1_dbgbuild.log" Content-Disposition: attachment; filename="xldmesg_4.16.1_dbgbuild.log" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5d72evm0 IFhlbiA0LjE2LjEKKFhFTikgWGVuIHZlcnNpb24gNC4xNi4xIChmaXJlbWV0ZW9yQCkgKGdjYyAo RGViaWFuIDExLjIuMC0xMykgMTEuMi4wKSBkZWJ1Zz15IEZyaSBKdWwgIDggMjE6MDk6NDEgSEtU IDIwMjIKKFhFTikgTGF0ZXN0IENoYW5nZVNldDogV2VkIEp1bCA2IDE2OjIyOjU1IDIwMjIgKzA4 MDAgZ2l0OjUxNGFiYTk2MjMKKFhFTikgYnVpbGQtaWQ6IDNlMDdiNjIxY2Y1MjAxYTgyYjg2N2E0 NGVmMWFkNThhMjMzZTRlYzgKKFhFTikgQm9vdGxvYWRlcjogR1JVQiAyLjA0LTIwCihYRU4pIENv bW1hbmQgbGluZTogcGxhY2Vob2xkZXIgZG9tMF9tZW09MkcsbWF4OjNHLG1pbjoxRyBkb20wX21h eF92Y3B1cz00IGxvZ2x2bD1hbGwgZ3Vlc3RfbG9nbHZsPWFsbCBpb21tdT12ZXJib3NlCihYRU4p IFhlbiBpbWFnZSBsb2FkIGJhc2UgYWRkcmVzczogMHg4N2EwMDAwMAooWEVOKSBWaWRlbyBpbmZv cm1hdGlvbjoKKFhFTikgIFZHQSBpcyB0ZXh0IG1vZGUgODB4MjUsIGZvbnQgOHgxNgooWEVOKSAg VkJFL0REQyBtZXRob2RzOiBWMjsgRURJRCB0cmFuc2ZlciB0aW1lOiAxIHNlY29uZHMKKFhFTikg RGlzYyBpbmZvcm1hdGlvbjoKKFhFTikgIEZvdW5kIDUgTUJSIHNpZ25hdHVyZXMKKFhFTikgIEZv dW5kIDUgRUREIGluZm9ybWF0aW9uIHN0cnVjdHVyZXMKKFhFTikgQ1BVIFZlbmRvcjogSW50ZWws IEZhbWlseSA2ICgweDYpLCBNb2RlbCAxNTggKDB4OWUpLCBTdGVwcGluZyAxMCAocmF3IDAwMDkw NmVhKQooWEVOKSBYZW4tZTgyMCBSQU0gbWFwOgooWEVOKSAgWzAwMDAwMDAwMDAwMDAwMDAsIDAw MDAwMDAwMDAwOWQzZmZdICh1c2FibGUpCihYRU4pICBbMDAwMDAwMDAwMDA5ZDQwMCwgMDAwMDAw MDAwMDA5ZmZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAwMDAwZTAwMDAsIDAwMDAwMDAw MDAwZmZmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAwMDAwMTAwMDAwLCAwMDAwMDAwMDgz NWJmZmZmXSAodXNhYmxlKQooWEVOKSAgWzAwMDAwMDAwODM1YzAwMDAsIDAwMDAwMDAwODM1YzBm ZmZdIChBQ1BJIE5WUykKKFhFTikgIFswMDAwMDAwMDgzNWMxMDAwLCAwMDAwMDAwMDgzNWMxZmZm XSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDA4MzVjMjAwMCwgMDAwMDAwMDA4OGMwYmZmZl0g KHVzYWJsZSkKKFhFTikgIFswMDAwMDAwMDg4YzBjMDAwLCAwMDAwMDAwMDg5MDdkZmZmXSAocmVz ZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDA4OTA3ZTAwMCwgMDAwMDAwMDA4OTFmNGZmZl0gKHVzYWJs ZSkKKFhFTikgIFswMDAwMDAwMDg5MWY1MDAwLCAwMDAwMDAwMDg5NWRjZmZmXSAoQUNQSSBOVlMp CihYRU4pICBbMDAwMDAwMDA4OTVkZDAwMCwgMDAwMDAwMDA4OWVmZWZmZl0gKHJlc2VydmVkKQoo WEVOKSAgWzAwMDAwMDAwODllZmYwMDAsIDAwMDAwMDAwODllZmZmZmZdICh1c2FibGUpCihYRU4p ICBbMDAwMDAwMDA4OWYwMDAwMCwgMDAwMDAwMDA4ZjdmZmZmZl0gKHJlc2VydmVkKQooWEVOKSAg WzAwMDAwMDAwZTAwMDAwMDAsIDAwMDAwMDAwZWZmZmZmZmZdIChyZXNlcnZlZCkKKFhFTikgIFsw MDAwMDAwMGZlMDAwMDAwLCAwMDAwMDAwMGZlMDEwZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAw MDAwMDBmZWMwMDAwMCwgMDAwMDAwMDBmZWMwMGZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAw MDAwZmVlMDAwMDAsIDAwMDAwMDAwZmVlMDBmZmZdIChyZXNlcnZlZCkKKFhFTikgIFswMDAwMDAw MGZmMDAwMDAwLCAwMDAwMDAwMGZmZmZmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDEw MDAwMDAwMCwgMDAwMDAwMDg2YzdmZmZmZl0gKHVzYWJsZSkKKFhFTikgQUNQSTogUlNEUCAwMDBG MDVCMCwgMDAyNCAocjIgQUxBU0tBKQooWEVOKSBBQ1BJOiBYU0RUIDg5NTEyMEE4LCAwMEQ0IChy MSBBTEFTS0EgICAgQSBNIEkgIDEwNzIwMDkgQU1JICAgICAxMDAxMykKKFhFTikgQUNQSTogRkFD UCA4OTU1MDlDMCwgMDExNCAocjYgQUxBU0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAgMTAw MTMpCihYRU4pIEFDUEk6IERTRFQgODk1MTIyMTgsIDNFN0E2IChyMiBBTEFTS0EgICAgQSBNIEkg IDEwNzIwMDkgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTogRkFDUyA4OTVEQzA4MCwgMDA0MAoo WEVOKSBBQ1BJOiBBUElDIDg5NTUwQUQ4LCAwMEY0IChyNCBBTEFTS0EgICAgQSBNIEkgIDEwNzIw MDkgQU1JICAgICAxMDAxMykKKFhFTikgQUNQSTogRlBEVCA4OTU1MEJEMCwgMDA0NCAocjEgQUxB U0tBICAgIEEgTSBJICAxMDcyMDA5IEFNSSAgICAgMTAwMTMpCihYRU4pIEFDUEk6IEZJRFQgODk1 NTBDMTgsIDAwOUMgKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQoo WEVOKSBBQ1BJOiBNQ0ZHIDg5NTUwQ0I4LCAwMDNDIChyMSBBTEFTS0EgICAgQSBNIEkgIDEwNzIw MDkgTVNGVCAgICAgICA5NykKKFhFTikgQUNQSTogU1NEVCA4OTU1MENGOCwgMDIwNCAocjEgQUxB U0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1 NTBGMDAsIDE3RDUgKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMzAwMCBJTlRMIDIwMTYwNTI3KQoo WEVOKSBBQ1BJOiBTU0RUIDg5NTUyNkQ4LCA5MzNEIChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAg IDEgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTogU1NEVCA4OTU1QkExOCwgMzFDNyAocjIgQUxB U0tBICAgIEEgTSBJICAgICAzMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1 NUVCRTAsIDIzNTggKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQoo WEVOKSBBQ1BJOiBIUEVUIDg5NTYwRjM4LCAwMDM4IChyMSBBTEFTS0EgICAgQSBNIEkgICAgICAg IDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTogU1NEVCA4OTU2MEY3MCwgMUJFMSAocjIgQUxB U0tBICAgIEEgTSBJICAgICAxMDAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IFNTRFQgODk1 NjJCNTgsIDBGOUUgKHIyIEFMQVNLQSAgICBBIE0gSSAgICAgMTAwMCBJTlRMIDIwMTYwNTI3KQoo WEVOKSBBQ1BJOiBTU0RUIDg5NTYzQUY4LCAyRDFCIChyMiBBTEFTS0EgICAgQSBNIEkgICAgICAg IDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTogVUVGSSA4OTU2NjgxOCwgMDA0MiAocjEgQUxB U0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEwMDAwMTMpCihYRU4pIEFDUEk6IExQSVQgODk1 NjY4NjAsIDAwNUMgKHIxIEFMQVNLQSAgICBBIE0gSSAgICAgICAgMiAgICAgICAxMDAwMDEzKQoo WEVOKSBBQ1BJOiBTU0RUIDg5NTY2OEMwLCAyN0RFIChyMiBBTEFTS0EgICAgQSBNIEkgICAgIDEw MDAgSU5UTCAyMDE2MDUyNykKKFhFTikgQUNQSTogU1NEVCA4OTU2OTBBMCwgMEZGRSAocjIgQUxB U0tBICAgIEEgTSBJICAgICAgICAwIElOVEwgMjAxNjA1MjcpCihYRU4pIEFDUEk6IERCR1AgODk1 NkEwQTAsIDAwMzQgKHIxIEFMQVNLQSAgICBBIE0gSSAgICAgICAgMiAgICAgICAxMDAwMDEzKQoo WEVOKSBBQ1BJOiBEQkcyIDg5NTZBMEQ4LCAwMDU0IChyMCBBTEFTS0EgICAgQSBNIEkgICAgICAg IDIgICAgICAgMTAwMDAxMykKKFhFTikgQUNQSTogRE1BUiA4OTU2QTEzMCwgMDBBOCAocjEgQUxB U0tBICAgIEEgTSBJICAgICAgICAyICAgICAgIDEwMDAwMTMpCihYRU4pIEFDUEk6IFdTTVQgODk1 NkExRDgsIDAwMjggKHIxIEFMQVNLQSAgICBBIE0gSSAgMTA3MjAwOSBBTUkgICAgIDEwMDEzKQoo WEVOKSBTeXN0ZW0gUkFNOiAzMjU5N01CICgzMzM3OTQ1MmtCKQooWEVOKSBObyBOVU1BIGNvbmZp Z3VyYXRpb24gZm91bmQKKFhFTikgRmFraW5nIGEgbm9kZSBhdCAwMDAwMDAwMDAwMDAwMDAwLTAw MDAwMDA4NmM4MDAwMDAKKFhFTikgRG9tYWluIGhlYXAgaW5pdGlhbGlzZWQKKFhFTikgZm91bmQg U01QIE1QLXRhYmxlIGF0IDAwMGZjZTMwCihYRU4pIFNNQklPUyAzLjEgcHJlc2VudC4KKFhFTikg VXNpbmcgQVBJQyBkcml2ZXIgZGVmYXVsdAooWEVOKSBBQ1BJOiBQTS1UaW1lciBJTyBQb3J0OiAw eDE4MDggKDI0IGJpdHMpCihYRU4pIEFDUEk6IHY1IFNMRUVQIElORk86IGNvbnRyb2xbMToxODA0 XSwgc3RhdHVzWzE6MTgwMF0KKFhFTikgQUNQSTogSW52YWxpZCBzbGVlcCBjb250cm9sL3N0YXR1 cyByZWdpc3RlciBkYXRhOiAwOjB4ODoweDMgMDoweDg6MHgzCihYRU4pIEFDUEk6IFNMRUVQIElO Rk86IHBtMXhfY250WzE6MTgwNCwxOjBdLCBwbTF4X2V2dFsxOjE4MDAsMTowXQooWEVOKSBBQ1BJ OiAzMi82NFggRkFDUyBhZGRyZXNzIG1pc21hdGNoIGluIEZBRFQgLSA4OTVkYzA4MC8wMDAwMDAw MDAwMDAwMDAwLCB1c2luZyAzMgooWEVOKSBBQ1BJOiAgICAgICAgICAgICB3YWtldXBfdmVjWzg5 NWRjMDhjXSwgdmVjX3NpemVbMjBdCihYRU4pIEFDUEk6IExvY2FsIEFQSUMgYWRkcmVzcyAweGZl ZTAwMDAwCihYRU4pIE92ZXJyaWRpbmcgQVBJQyBkcml2ZXIgd2l0aCBiaWdzbXAKKFhFTikgQUNQ STogSU9BUElDIChpZFsweDAyXSBhZGRyZXNzWzB4ZmVjMDAwMDBdIGdzaV9iYXNlWzBdKQooWEVO KSBJT0FQSUNbMF06IGFwaWNfaWQgMiwgdmVyc2lvbiAzMiwgYWRkcmVzcyAweGZlYzAwMDAwLCBH U0kgMC0xMTkKKFhFTikgQUNQSTogSU5UX1NSQ19PVlIgKGJ1cyAwIGJ1c19pcnEgMCBnbG9iYWxf aXJxIDIgZGZsIGRmbCkKKFhFTikgQUNQSTogSU5UX1NSQ19PVlIgKGJ1cyAwIGJ1c19pcnEgOSBn bG9iYWxfaXJxIDkgaGlnaCBsZXZlbCkKKFhFTikgQUNQSTogSVJRMCB1c2VkIGJ5IG92ZXJyaWRl LgooWEVOKSBBQ1BJOiBJUlEyIHVzZWQgYnkgb3ZlcnJpZGUuCihYRU4pIEFDUEk6IElSUTkgdXNl ZCBieSBvdmVycmlkZS4KKFhFTikgRW5hYmxpbmcgQVBJQyBtb2RlOiAgUGh5cy4gIFVzaW5nIDEg SS9PIEFQSUNzCihYRU4pIEFDUEk6IEhQRVQgaWQ6IDB4ODA4NmEyMDEgYmFzZTogMHhmZWQwMDAw MAooWEVOKSBQQ0k6IE1DRkcgY29uZmlndXJhdGlvbiAwOiBiYXNlIGUwMDAwMDAwIHNlZ21lbnQg MDAwMCBidXNlcyAwMCAtIGZmCihYRU4pIFBDSTogTUNGRyBhcmVhIGF0IGUwMDAwMDAwIHJlc2Vy dmVkIGluIEU4MjAKKFhFTikgUENJOiBVc2luZyBNQ0ZHIGZvciBzZWdtZW50IDAwMDAgYnVzIDAw LWZmCihYRU4pIFtWVC1EXUhvc3QgYWRkcmVzcyB3aWR0aCAzOQooWEVOKSBbVlQtRF1mb3VuZCBB Q1BJX0RNQVJfRFJIRDoKKFhFTikgW1ZULURdICBkbWFydS0+YWRkcmVzcyA9IGZlZDkwMDAwCihY RU4pIFtWVC1EXWRyaGQtPmFkZHJlc3MgPSBmZWQ5MDAwMCBpb21tdS0+cmVnID0gZmZmZjgyYzAw MDIxZDAwMAooWEVOKSBbVlQtRF1jYXAgPSAxYzAwMDBjNDA2NjA0NjIgZWNhcCA9IDE5ZTJmZjA1 MDVlCihYRU4pIFtWVC1EXSBlbmRwb2ludDogMDAwMDowMDowMi4wCihYRU4pIFtWVC1EXWZvdW5k IEFDUElfRE1BUl9EUkhEOgooWEVOKSBbVlQtRF0gIGRtYXJ1LT5hZGRyZXNzID0gZmVkOTEwMDAK KFhFTikgW1ZULURdZHJoZC0+YWRkcmVzcyA9IGZlZDkxMDAwIGlvbW11LT5yZWcgPSBmZmZmODJj MDAwMjFmMDAwCihYRU4pIFtWVC1EXWNhcCA9IGQyMDA4YzQwNjYwNDYyIGVjYXAgPSBmMDUwZGEK KFhFTikgW1ZULURdIElPQVBJQzogMDAwMDowMDoxZS43CihYRU4pIFtWVC1EXSBNU0kgSFBFVDog MDAwMDowMDoxZS42CihYRU4pIFtWVC1EXSAgZmxhZ3M6IElOQ0xVREVfQUxMCihYRU4pIFtWVC1E XWZvdW5kIEFDUElfRE1BUl9STVJSOgooWEVOKSBbVlQtRF0gZW5kcG9pbnQ6IDAwMDA6MDA6MTQu MAooWEVOKSBbVlQtRF1kbWFyLmM6NjE3OiAgUk1SUjogWzg5OWUwMDAwLDg5YzI5ZmZmXQooWEVO KSBbVlQtRF1mb3VuZCBBQ1BJX0RNQVJfUk1SUjoKKFhFTikgW1ZULURdIGVuZHBvaW50OiAwMDAw OjAwOjAyLjAKKFhFTikgW1ZULURdZG1hci5jOjYxNzogIFJNUlI6IFs4YjAwMDAwMCw4ZjdmZmZm Zl0KKFhFTikgVXNpbmcgQUNQSSAoTUFEVCkgZm9yIFNNUCBjb25maWd1cmF0aW9uIGluZm9ybWF0 aW9uCihYRU4pIFNNUDogQWxsb3dpbmcgMTIgQ1BVcyAoMCBob3RwbHVnIENQVXMpCihYRU4pIElS USBsaW1pdHM6IDEyMCBHU0ksIDIzNzYgTVNJL01TSS1YCihYRU4pIFtWVC1EXXFpbnZhbC5jOjQy MTogUUk6IHVzaW5nIDI1Ni1lbnRyeSByaW5nKHMpCihYRU4pIFN3aXRjaGVkIHRvIEFQSUMgZHJp dmVyIHgyYXBpY19jbHVzdGVyCihYRU4pIENQVTA6IFRTQzogcmF0aW86IDI5MiAvIDIKKFhFTikg Q1BVMDogYnVzOiAxMDAgTUh6IGJhc2U6IDM1MDAgTUh6IG1heDogNDUwMCBNSHoKKFhFTikgQ1BV MDogODAwIC4uLiAzNTAwIE1IegooWEVOKSB4c3RhdGU6IHNpemU6IDB4NDQwIGFuZCBzdGF0ZXM6 IDB4MWYKKFhFTikgbWNlX2ludGVsLmM6NzczOiBNQ0EgQ2FwYWJpbGl0eTogZmlyc3RiYW5rIDAs IGV4dGVuZGVkIE1DRSBNU1IgMCwgQkNBU1QsIENNQ0kKKFhFTikgQ1BVMDogSW50ZWwgbWFjaGlu ZSBjaGVjayByZXBvcnRpbmcgZW5hYmxlZAooWEVOKSBTcGVjdWxhdGl2ZSBtaXRpZ2F0aW9uIGZh Y2lsaXRpZXM6CihYRU4pICAgSGFyZHdhcmUgaGludHM6CihYRU4pICAgSGFyZHdhcmUgZmVhdHVy ZXM6IElCUEIgSUJSUyBTVElCUCBTU0JEIEwxRF9GTFVTSCBNRF9DTEVBUgooWEVOKSAgIENvbXBp bGVkLWluIHN1cHBvcnQ6IElORElSRUNUX1RIVU5LIFNIQURPV19QQUdJTkcKKFhFTikgICBYZW4g c2V0dGluZ3M6IEJUSS1UaHVuayBKTVAsIFNQRUNfQ1RSTDogSUJSUysgU1RJQlAtIFNTQkQtLCBP dGhlcjogSUJQQiBMMURfRkxVU0ggVkVSVyBCUkFOQ0hfSEFSREVOCihYRU4pICAgTDFURjogYmVs aWV2ZWQgdnVsbmVyYWJsZSwgbWF4cGh5c2FkZHIgTDFEIDQ2LCBDUFVJRCAzOSwgU2FmZSBhZGRy ZXNzIDgwMDAwMDAwMDAKKFhFTikgICBTdXBwb3J0IGZvciBIVk0gVk1zOiBNU1JfU1BFQ19DVFJM IFJTQiBFQUdFUl9GUFUgTURfQ0xFQVIKKFhFTikgICBTdXBwb3J0IGZvciBQViBWTXM6IE1TUl9T UEVDX0NUUkwgRUFHRVJfRlBVIE1EX0NMRUFSCihYRU4pICAgWFBUSSAoNjQtYml0IFBWIG9ubHkp OiBEb20wIGVuYWJsZWQsIERvbVUgZW5hYmxlZCAod2l0aCBQQ0lEKQooWEVOKSAgIFBWIEwxVEYg c2hhZG93aW5nOiBEb20wIGRpc2FibGVkLCBEb21VIGVuYWJsZWQKKFhFTikgVXNpbmcgc2NoZWR1 bGVyOiBTTVAgQ3JlZGl0IFNjaGVkdWxlciByZXYyIChjcmVkaXQyKQooWEVOKSBJbml0aWFsaXpp bmcgQ3JlZGl0MiBzY2hlZHVsZXIKKFhFTikgIGxvYWRfcHJlY2lzaW9uX3NoaWZ0OiAxOAooWEVO KSAgbG9hZF93aW5kb3dfc2hpZnQ6IDMwCihYRU4pICB1bmRlcmxvYWRfYmFsYW5jZV90b2xlcmFu Y2U6IDAKKFhFTikgIG92ZXJsb2FkX2JhbGFuY2VfdG9sZXJhbmNlOiAtMwooWEVOKSAgcnVucXVl dWVzIGFycmFuZ2VtZW50OiBzb2NrZXQKKFhFTikgIGNhcCBlbmZvcmNlbWVudCBncmFudWxhcml0 eTogMTBtcwooWEVOKSBsb2FkIHRyYWNraW5nIHdpbmRvdyBsZW5ndGggMTA3Mzc0MTgyNCBucwoo WEVOKSBEaXNhYmxpbmcgSFBFVCBmb3IgYmVpbmcgdW5yZWxpYWJsZQooWEVOKSBQbGF0Zm9ybSB0 aW1lciBpcyAzLjU4ME1IeiBBQ1BJIFBNIFRpbWVyCihYRU4pIERldGVjdGVkIDM1MDQuMDEyIE1I eiBwcm9jZXNzb3IuCihYRU4pIEZyZWVkIDEwMjRrQiB1bnVzZWQgQlNTIG1lbW9yeQooWEVOKSBh bHQgdGFibGUgZmZmZjgyZDA0MDQ4YjViMCAtPiBmZmZmODJkMDQwNDk3ZDA2CihYRU4pIEludGVs IFZULWQgaW9tbXUgMCBzdXBwb3J0ZWQgcGFnZSBzaXplczogNGtCLCAyTUIsIDFHQgooWEVOKSBJ bnRlbCBWVC1kIGlvbW11IDEgc3VwcG9ydGVkIHBhZ2Ugc2l6ZXM6IDRrQiwgMk1CLCAxR0IKKFhF TikgSW50ZWwgVlQtZCBTbm9vcCBDb250cm9sIG5vdCBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1k IERvbTAgRE1BIFBhc3N0aHJvdWdoIG5vdCBlbmFibGVkLgooWEVOKSBJbnRlbCBWVC1kIFF1ZXVl ZCBJbnZhbGlkYXRpb24gZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBJbnRlcnJ1cHQgUmVtYXBw aW5nIGVuYWJsZWQuCihYRU4pIEludGVsIFZULWQgUG9zdGVkIEludGVycnVwdCBub3QgZW5hYmxl ZC4KKFhFTikgSW50ZWwgVlQtZCBTaGFyZWQgRVBUIHRhYmxlcyBlbmFibGVkLgooWEVOKSBJL08g dmlydHVhbGlzYXRpb24gZW5hYmxlZAooWEVOKSAgLSBEb20wIG1vZGU6IFJlbGF4ZWQKKFhFTikg SW50ZXJydXB0IHJlbWFwcGluZyBlbmFibGVkCihYRU4pIG5yX3NvY2tldHM6IDEKKFhFTikgRW5h YmxlZCBkaXJlY3RlZCBFT0kgd2l0aCBpb2FwaWNfYWNrX29sZCBvbiEKKFhFTikgRU5BQkxJTkcg SU8tQVBJQyBJUlFzCihYRU4pICAtPiBVc2luZyBvbGQgQUNLIG1ldGhvZAooWEVOKSAuLlRJTUVS OiB2ZWN0b3I9MHhGMCBhcGljMT0wIHBpbjE9MiBhcGljMj0tMSBwaW4yPS0xCihYRU4pIFRTQyBk ZWFkbGluZSB0aW1lciBlbmFibGVkCihYRU4pIEFsbG9jYXRlZCBjb25zb2xlIHJpbmcgb2YgMTI4 IEtpQi4KKFhFTikgbXdhaXQtaWRsZTogTVdBSVQgc3Vic3RhdGVzOiAweDExMTQyMTIwCihYRU4p IG13YWl0LWlkbGU6IHYwLjQuMSBtb2RlbCAweDllCihYRU4pIG13YWl0LWlkbGU6IGxhcGljX3Rp bWVyX3JlbGlhYmxlX3N0YXRlcyAweGZmZmZmZmZmCihYRU4pIFZNWDogU3VwcG9ydGVkIGFkdmFu Y2VkIGZlYXR1cmVzOgooWEVOKSAgLSBBUElDIE1NSU8gYWNjZXNzIHZpcnR1YWxpc2F0aW9uCihY RU4pICAtIEFQSUMgVFBSIHNoYWRvdwooWEVOKSAgLSBFeHRlbmRlZCBQYWdlIFRhYmxlcyAoRVBU KQooWEVOKSAgLSBWaXJ0dWFsLVByb2Nlc3NvciBJZGVudGlmaWVycyAoVlBJRCkKKFhFTikgIC0g VmlydHVhbCBOTUkKKFhFTikgIC0gTVNSIGRpcmVjdC1hY2Nlc3MgYml0bWFwCihYRU4pICAtIFVu cmVzdHJpY3RlZCBHdWVzdAooWEVOKSAgLSBWTUNTIHNoYWRvd2luZwooWEVOKSAgLSBWTSBGdW5j dGlvbnMKKFhFTikgIC0gVmlydHVhbGlzYXRpb24gRXhjZXB0aW9ucwooWEVOKSAgLSBQYWdlIE1v ZGlmaWNhdGlvbiBMb2dnaW5nCihYRU4pIEhWTTogQVNJRHMgZW5hYmxlZC4KKFhFTikgVk1YOiBE aXNhYmxpbmcgZXhlY3V0YWJsZSBFUFQgc3VwZXJwYWdlcyBkdWUgdG8gQ1ZFLTIwMTgtMTIyMDcK KFhFTikgSFZNOiBWTVggZW5hYmxlZAooWEVOKSBIVk06IEhhcmR3YXJlIEFzc2lzdGVkIFBhZ2lu ZyAoSEFQKSBkZXRlY3RlZAooWEVOKSBIVk06IEhBUCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdC CihYRU4pIGFsdCB0YWJsZSBmZmZmODJkMDQwNDhiNWIwIC0+IGZmZmY4MmQwNDA0OTdkMDYKKFhF TikgQnJvdWdodCB1cCAxMiBDUFVzCihYRU4pIFNjaGVkdWxpbmcgZ3JhbnVsYXJpdHk6IGNwdSwg MSBDUFUgcGVyIHNjaGVkLXJlc291cmNlCihYRU4pIEFkZGluZyBjcHUgMCB0byBydW5xdWV1ZSAw CihYRU4pICBGaXJzdCBjcHUgb24gcnVucXVldWUsIGFjdGl2YXRpbmcKKFhFTikgQWRkaW5nIGNw dSAxIHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSAyIHRvIHJ1bnF1ZXVlIDAKKFhFTikg QWRkaW5nIGNwdSAzIHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSA0IHRvIHJ1bnF1ZXVl IDAKKFhFTikgQWRkaW5nIGNwdSA1IHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSA2IHRv IHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSA3IHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5n IGNwdSA4IHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSA5IHRvIHJ1bnF1ZXVlIDAKKFhF TikgQWRkaW5nIGNwdSAxMCB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgMTEgdG8gcnVu cXVldWUgMAooWEVOKSBtY2hlY2tfcG9sbDogTWFjaGluZSBjaGVjayBwb2xsaW5nIHRpbWVyIHN0 YXJ0ZWQuCihYRU4pIFJ1bm5pbmcgc3R1YiByZWNvdmVyeSBzZWxmdGVzdHMuLi4KKFhFTikgRml4 dXAgI1VEWzAwMDBdOiBmZmZmODJkMDdmZmZlMDQ0IFtmZmZmODJkMDdmZmZlMDQ0XSAtPiBmZmZm ODJkMDQwMzg2ODA5CihYRU4pIEZpeHVwICNHUFswMDAwXTogZmZmZjgyZDA3ZmZmZTA0NSBbZmZm ZjgyZDA3ZmZmZTA0NV0gLT4gZmZmZjgyZDA0MDM4NjgwOQooWEVOKSBGaXh1cCAjU1NbMDAwMF06 IGZmZmY4MmQwN2ZmZmUwNDQgW2ZmZmY4MmQwN2ZmZmUwNDRdIC0+IGZmZmY4MmQwNDAzODY4MDkK KFhFTikgRml4dXAgI0JQWzAwMDBdOiBmZmZmODJkMDdmZmZlMDQ1IFtmZmZmODJkMDdmZmZlMDQ1 XSAtPiBmZmZmODJkMDQwMzg2ODA5CihYRU4pIE5YIChFeGVjdXRlIERpc2FibGUpIHByb3RlY3Rp b24gYWN0aXZlCihYRU4pIERvbTAgaGFzIG1heGltdW0gOTUyIFBJUlFzCihYRU4pICoqKiBCdWls ZGluZyBhIFBWIERvbTAgKioqCihYRU4pIEVMRjogcGhkcjogcGFkZHI9MHgxMDAwMDAwIG1lbXN6 PTB4MTM5NWQwOAooWEVOKSBFTEY6IHBoZHI6IHBhZGRyPTB4MjQwMDAwMCBtZW1zej0weDY4NTAw MAooWEVOKSBFTEY6IHBoZHI6IHBhZGRyPTB4MmE4NTAwMCBtZW1zej0weDMwZDk4CihYRU4pIEVM RjogcGhkcjogcGFkZHI9MHgyYWI2MDAwIG1lbXN6PTB4Mzc2MDAwCihYRU4pIEVMRjogbWVtb3J5 OiAweDEwMDAwMDAgLT4gMHgyZTJjMDAwCihYRU4pIEVMRjogbm90ZTogR1VFU1RfT1MgPSAibGlu dXgiCihYRU4pIEVMRjogbm90ZTogR1VFU1RfVkVSU0lPTiA9ICIyLjYiCihYRU4pIEVMRjogbm90 ZTogWEVOX1ZFUlNJT04gPSAieGVuLTMuMCIKKFhFTikgRUxGOiBub3RlOiBWSVJUX0JBU0UgPSAw eGZmZmZmZmZmODAwMDAwMDAKKFhFTikgRUxGOiBub3RlOiBJTklUX1AyTSA9IDB4ODAwMDAwMDAw MAooWEVOKSBFTEY6IG5vdGU6IEVOVFJZID0gMHhmZmZmZmZmZjgyYWI2MTYwCihYRU4pIEVMRjog bm90ZTogSFlQRVJDQUxMX1BBR0UgPSAweGZmZmZmZmZmODEwMDIwMDAKKFhFTikgRUxGOiBub3Rl OiBGRUFUVVJFUyA9ICIhd3JpdGFibGVfcGFnZV90YWJsZXN8cGFlX3BnZGlyX2Fib3ZlXzRnYiIK KFhFTikgRUxGOiBub3RlOiBTVVBQT1JURURfRkVBVFVSRVMgPSAweDg4MDEKKFhFTikgRUxGOiBu b3RlOiBQQUVfTU9ERSA9ICJ5ZXMiCihYRU4pIEVMRjogbm90ZTogTE9BREVSID0gImdlbmVyaWMi CihYRU4pIEVMRjogbm90ZTogdW5rbm93biAoMHhkKQooWEVOKSBFTEY6IG5vdGU6IFNVU1BFTkRf Q0FOQ0VMID0gMHgxCihYRU4pIEVMRjogbm90ZTogTU9EX1NUQVJUX1BGTiA9IDB4MQooWEVOKSBF TEY6IG5vdGU6IEhWX1NUQVJUX0xPVyA9IDB4ZmZmZjgwMDAwMDAwMDAwMAooWEVOKSBFTEY6IG5v dGU6IFBBRERSX09GRlNFVCA9IDAKKFhFTikgRUxGOiBub3RlOiBQSFlTMzJfRU5UUlkgPSAweDEw MDA0YjAKKFhFTikgRUxGOiBhZGRyZXNzZXM6CihYRU4pICAgICB2aXJ0X2Jhc2UgICAgICAgID0g MHhmZmZmZmZmZjgwMDAwMDAwCihYRU4pICAgICBlbGZfcGFkZHJfb2Zmc2V0ID0gMHgwCihYRU4p ICAgICB2aXJ0X29mZnNldCAgICAgID0gMHhmZmZmZmZmZjgwMDAwMDAwCihYRU4pICAgICB2aXJ0 X2tzdGFydCAgICAgID0gMHhmZmZmZmZmZjgxMDAwMDAwCihYRU4pICAgICB2aXJ0X2tlbmQgICAg ICAgID0gMHhmZmZmZmZmZjgyZTJjMDAwCihYRU4pICAgICB2aXJ0X2VudHJ5ICAgICAgID0gMHhm ZmZmZmZmZjgyYWI2MTYwCihYRU4pICAgICBwMm1fYmFzZSAgICAgICAgID0gMHg4MDAwMDAwMDAw CihYRU4pICBYZW4gIGtlcm5lbDogNjQtYml0LCBsc2IKKFhFTikgIERvbTAga2VybmVsOiA2NC1i aXQsIFBBRSwgbHNiLCBwYWRkciAweDEwMDAwMDAgLT4gMHgyZTJjMDAwCihYRU4pIFBIWVNJQ0FM IE1FTU9SWSBBUlJBTkdFTUVOVDoKKFhFTikgIERvbTAgYWxsb2MuOiAgIDAwMDAwMDA4NTAwMDAw MDAtPjAwMDAwMDA4NTQwMDAwMDAgKDUwNDMxNCBwYWdlcyB0byBiZSBhbGxvY2F0ZWQpCihYRU4p ICBJbml0LiByYW1kaXNrOiAwMDAwMDAwODZiOWZhMDAwLT4wMDAwMDAwODZjN2ZmM2Y2CihYRU4p IFZJUlRVQUwgTUVNT1JZIEFSUkFOR0VNRU5UOgooWEVOKSAgTG9hZGVkIGtlcm5lbDogZmZmZmZm ZmY4MTAwMDAwMC0+ZmZmZmZmZmY4MmUyYzAwMAooWEVOKSAgUGh5cy1NYWNoIG1hcDogMDAwMDAw ODAwMDAwMDAwMC0+MDAwMDAwODAwMDQwMDAwMAooWEVOKSAgU3RhcnQgaW5mbzogICAgZmZmZmZm ZmY4MmUyYzAwMC0+ZmZmZmZmZmY4MmUyYzRiOAooWEVOKSAgUGFnZSB0YWJsZXM6ICAgZmZmZmZm ZmY4MmUyZDAwMC0+ZmZmZmZmZmY4MmU0ODAwMAooWEVOKSAgQm9vdCBzdGFjazogICAgZmZmZmZm ZmY4MmU0ODAwMC0+ZmZmZmZmZmY4MmU0OTAwMAooWEVOKSAgVE9UQUw6ICAgICAgICAgZmZmZmZm ZmY4MDAwMDAwMC0+ZmZmZmZmZmY4MzAwMDAwMAooWEVOKSAgRU5UUlkgQUREUkVTUzogZmZmZmZm ZmY4MmFiNjE2MAooWEVOKSBEb20wIGhhcyBtYXhpbXVtIDQgVkNQVXMKKFhFTikgRUxGOiBwaGRy IDAgYXQgMHhmZmZmZmZmZjgxMDAwMDAwIC0+IDB4ZmZmZmZmZmY4MjM5NWQwOAooWEVOKSBFTEY6 IHBoZHIgMSBhdCAweGZmZmZmZmZmODI0MDAwMDAgLT4gMHhmZmZmZmZmZjgyYTg1MDAwCihYRU4p IEVMRjogcGhkciAyIGF0IDB4ZmZmZmZmZmY4MmE4NTAwMCAtPiAweGZmZmZmZmZmODJhYjVkOTgK KFhFTikgRUxGOiBwaGRyIDMgYXQgMHhmZmZmZmZmZjgyYWI2MDAwIC0+IDB4ZmZmZmZmZmY4MmJl MDAwMAooWEVOKSBbVlQtRF1pb21tdV9lbmFibGVfdHJhbnNsYXRpb246IGlvbW11LT5yZWcgPSBm ZmZmODJjMDAwMjFkMDAwCihYRU4pIFtWVC1EXWlvbW11X2VuYWJsZV90cmFuc2xhdGlvbjogaW9t bXUtPnJlZyA9IGZmZmY4MmMwMDAyMWYwMDAKKFhFTikgSW5pdGlhbCBsb3cgbWVtb3J5IHZpcnEg dGhyZXNob2xkIHNldCBhdCAweDQwMDAgcGFnZXMuCihYRU4pIFNjcnViYmluZyBGcmVlIFJBTSBp biBiYWNrZ3JvdW5kCihYRU4pIFN0ZC4gTG9nbGV2ZWw6IEFsbAooWEVOKSBHdWVzdCBMb2dsZXZl bDogQWxsCihYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKgooWEVOKSBCb290ZWQgb24gTDFURi12dWxuZXJhYmxlIGhhcmR3YXJlIHdpdGggU01U L0h5cGVydGhyZWFkaW5nCihYRU4pIGVuYWJsZWQuICBQbGVhc2UgYXNzZXNzIHlvdXIgY29uZmln dXJhdGlvbiBhbmQgY2hvb3NlIGFuCihYRU4pIGV4cGxpY2l0ICdzbXQ9PGJvb2w+JyBzZXR0aW5n LiAgU2VlIFhTQS0yNzMuCihYRU4pICoqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKgooWEVOKSBCb290ZWQgb24gTUxQRFMvTUZCRFMtdnVsbmVyYWJsZSBo YXJkd2FyZSB3aXRoIFNNVC9IeXBlcnRocmVhZGluZwooWEVOKSBlbmFibGVkLiAgTWl0aWdhdGlv bnMgd2lsbCBub3QgYmUgZnVsbHkgZWZmZWN0aXZlLiAgUGxlYXNlCihYRU4pIGNob29zZSBhbiBl eHBsaWNpdCBzbXQ9PGJvb2w+IHNldHRpbmcuICBTZWUgWFNBLTI5Ny4KKFhFTikgKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCihYRU4pIDMuLi4gMi4u LiAxLi4uIAooWEVOKSBYZW4gaXMgcmVsaW5xdWlzaGluZyBWR0EgY29uc29sZS4KKFhFTikgKioq IFNlcmlhbCBpbnB1dCB0byBET00wICh0eXBlICdDVFJMLWEnIHRocmVlIHRpbWVzIHRvIHN3aXRj aCBpbnB1dCkKKFhFTikgRnJlZWQgNjIwa0IgaW5pdCBtZW1vcnkKKFhFTikgZDA6IEZvcmNpbmcg d3JpdGUgZW11bGF0aW9uIG9uIE1GTnMgZTAwMDAtZWZmZmYKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDowMDowMC4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MDEuMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjAwOjAyLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxMi4w CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTQuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjAwOjE0LjIKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxNi4wCihYRU4pIFBDSSBh ZGQgZGV2aWNlIDAwMDA6MDA6MTYuMwooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjE3LjAK KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxYi4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6MDA6MWMuMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFjLjUKKFhFTikgUENJIGFk ZCBkZXZpY2UgMDAwMDowMDoxZC4wCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWYuMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFmLjMKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDowMDoxZi40CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MWYuNQooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjAxOjAwLjAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowNDowMC4wCihY RU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDU6MDAuMAooWEVOKSBlbXVsLXByaXYtb3AuYzoxMDI1 OmQwdjIgUkRNU1IgMHgwMDAwMDYzOSB1bmltcGxlbWVudGVkCihYRU4pIGVtdWwtcHJpdi1vcC5j OjEwMjU6ZDB2MiBSRE1TUiAweDAwMDAwNjExIHVuaW1wbGVtZW50ZWQKKFhFTikgZW11bC1wcml2 LW9wLmM6MTAyNTpkMHYyIFJETVNSIDB4MDAwMDA2MTkgdW5pbXBsZW1lbnRlZAooWEVOKSBlbXVs LXByaXYtb3AuYzoxMDI1OmQwdjIgUkRNU1IgMHgwMDAwMDY0MSB1bmltcGxlbWVudGVkCihYRU4p IGVtdWwtcHJpdi1vcC5jOjEwMjU6ZDB2MiBSRE1TUiAweDAwMDAwNjRkIHVuaW1wbGVtZW50ZWQK KFhFTikgZW11bC1wcml2LW9wLmM6MTAyNTpkMHYyIFJETVNSIDB4MDAwMDA2MDYgdW5pbXBsZW1l bnRlZAooWEVOKSBlbXVsLXByaXYtb3AuYzoxMDI1OmQwdjIgUkRNU1IgMHgwMDAwMDY0ZSB1bmlt cGxlbWVudGVkCihYRU4pIGVtdWwtcHJpdi1vcC5jOjEwMjU6ZDB2MiBSRE1TUiAweDAwMDAwMDM0 IHVuaW1wbGVtZW50ZWQKKFhFTikgZDA6IEZvcmNpbmcgcmVhZC1vbmx5IGFjY2VzcyB0byBNRk4g ZmVkMDAKKFhFTikgZW11bC1wcml2LW9wLmM6MTAyNTpkMHYzIFJETVNSIDB4YzAwMTEwMjAgdW5p bXBsZW1lbnRlZAo= --000000000000c770d405e3552e0d-- From xen-devel-bounces@lists.xenproject.org Sat Jul 09 02:14:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 02:14:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363708.594404 (Exim 4.92) (envelope-from ) id 1o9zyw-0007Yd-5B; Sat, 09 Jul 2022 02:14:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363708.594404; Sat, 09 Jul 2022 02:14:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zyw-0007YW-2H; Sat, 09 Jul 2022 02:14:06 +0000 Received: by outflank-mailman (input) for mailman id 363708; Sat, 09 Jul 2022 02:14:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zyv-0007YM-9G; Sat, 09 Jul 2022 02:14:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zyv-0004tq-6l; Sat, 09 Jul 2022 02:14:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1o9zyu-0006Ud-P4; Sat, 09 Jul 2022 02:14:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1o9zyu-0007uF-OM; Sat, 09 Jul 2022 02:14:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dWrAhyo+Fq0wFbfiqzFfb9HmaSWZ8HHggxEOTbxxIcw=; b=diAq1KeCKoXhWG9N+J7a694ISD fqr1/IB+ofPLNfuowzBPh9RRwt+Q8iKsOvMhbKwac2SX9w93fcYs4PxATT19MSyTHwEsKIvwc6+/z +mDXxToa6KwJi64jVbPf+ksVi6Wm+r9u9zjwM3SSJazPSqJRm7Bu6dfplzP7esqZ5d5I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171560: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-pvhv2-intel:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 X-Osstest-Versions-That: xen=46cbd76faf737e9fe2d57aaf335a0203f66ba21c From: osstest service owner Date: Sat, 09 Jul 2022 02:14:04 +0000 flight 171560 xen-unstable real [real] flight 171563 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171560/ http://logs.test-lab.xenproject.org/osstest/logs/171563/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 171563-retest test-amd64-amd64-xl-pvhv2-intel 20 guest-localmigrate/x10 fail pass in 171563-retest test-arm64-arm64-xl-vhd 13 guest-start fail pass in 171563-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171552 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 171563 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 171563 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171552 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171552 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171552 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171552 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171552 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171552 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171552 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171552 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171552 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171552 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171552 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171552 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 baseline version: xen 46cbd76faf737e9fe2d57aaf335a0203f66ba21c Last test of basis 171552 2022-07-08 01:53:16 Z 1 days Testing same since 171560 2022-07-08 14:09:36 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Jiamei Xie # arm64 Juergen Gross Penny Zheng Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel fail test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 46cbd76faf..980bfb1ac9 980bfb1ac9247e95790e283dbc03e231e02cced9 -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 09 04:28:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 04:28:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363717.594415 (Exim 4.92) (envelope-from ) id 1oA24F-0002o9-DD; Sat, 09 Jul 2022 04:27:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363717.594415; Sat, 09 Jul 2022 04:27:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA24F-0002o2-Af; Sat, 09 Jul 2022 04:27:43 +0000 Received: by outflank-mailman (input) for mailman id 363717; Sat, 09 Jul 2022 04:27:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA24E-0002nw-1f for xen-devel@lists.xen.org; Sat, 09 Jul 2022 04:27:42 +0000 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7678e597-ff3f-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 06:27:40 +0200 (CEST) Received: by mail-ej1-f44.google.com with SMTP id ez10so685311ejc.13 for ; Fri, 08 Jul 2022 21:27:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7678e597-ff3f-11ec-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rcEJ6NAWK4bKVWVQpG5ax76VwHHhmRjfe+BO7AFwhvE=; b=JTm+1Qd7D5jV0E+6Dnh9wB2VJ83q2yv6e/llImagrR/Y2qNaL5fJrqf3EBisPb/Tmu Rfh1Dt9py/dMesqADxxobL8Tmh+4NVUO+fnbqOhLjw77m/t2MH3EAYGNaKrMHGlvqD0Z lIKj02jepXXD6dxCb80xyTAavDxl8SQRJ7JIPhqCP3e5btpOOSreCnywC1JHIx/HbpkR 0Hu9XQVdMCg9SoDBgKUJqZ3pIErMxZfDdJg5Vt9bmQpEhkjMSDRly+DFwPKWkkUmRlRy tdIeW05wj/Kkf1LCyJEZzx4HgJa4Cdf5P3NEnAL3+XbGgj/Og5cwjiJOjm8S24FbPPe+ jlyQ== X-Gm-Message-State: AJIora/iVtnYrEwj/B0kcTD2VZF0NyuZ2oxKd1lL5uViG34W2e8x9SeI ILElzIUssOSFfJmzPt4xwJ53J8RLULZLtctVc0M= X-Google-Smtp-Source: AGRyM1swZbp7KYszXIAzHvD00YYQ8bdnInjt7oFa4o2MPYqXJG3R9UppX/bxOzBIXoDUBh6ySJhyzhZr/0roUmMD0HE= X-Received: by 2002:a17:907:a05c:b0:72b:347b:4f59 with SMTP id gz28-20020a170907a05c00b0072b347b4f59mr1507480ejc.764.1657340857534; Fri, 08 Jul 2022 21:27:37 -0700 (PDT) MIME-Version: 1.0 References: <93c7b016-06f9-e3d2-5a7f-97a5f15c1a86@suse.com> In-Reply-To: From: "G.R." Date: Sat, 9 Jul 2022 12:27:24 +0800 Message-ID: Subject: Re: PCI pass-through problem for SN570 NVME SSD To: Jan Beulich Cc: xen-devel , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Anthony Perard Content-Type: text/plain; charset="UTF-8" On Fri, Jul 8, 2022 at 10:28 AM G.R. wrote: > > On Fri, Jul 8, 2022 at 12:38 AM Jan Beulich wrote: > > > > > I built both 4.14.3 debug version and 4.16.1 release version for > > > testing purposes. > > > Unfortunately they gave me absolutely zero information, since both of > > > them are not able to get through issue #1 > > > the FlR related DPC / AER issue. > > > With 4.16.1 release, it actually can survive the 'xl > > > pci-assignable-add' which triggers the first AER failure. > > > > Then that's what needs debugging first. Yet from all I've seen so > > far I'm not sure who one the Xen side could be doing that, the more > > without themselves being able to repro - this seems more like a > > Linux side issue (and even outside of the pciback driver). > > > Yep, this one is likely not XEN related, as I've seen some discussions > ([1],[2]) on similar syndrome (not necessarily same root cause > though). > The question is why this only shows up during the FLR attempt and if > following pci-assignable-adds that do not trigger the error are > actually reliable. > BTW, I'm under the impression that the device is still usable in dom0 > afterwards, I'll have to double check though... I think I'm finally making progress here. Today I verified that the SSD does not survive FLR in Linux as long as AER / DPC is enabled. Irrelevant to pciback or whatever driver it attaches to, the same syndrome can be observed. And after the unsuccessful FLR, I can't even use the device on dom0 or the Linux itself. Forcing disabling ASPM does not fix the issue, as long as AER / DPC are left enabled. However, as long as AER / DPC is disabled (through pcie-aspm=off kernel command-line, which ironically doesn't turn off ASPM), the SSD device appears to FLR just fine and I'm still able to use it on the Linux host afterwards. And what's even better, the same pcie-aspm=off kernel command works in XEN env too. The FreeBSD12 domU is now able to access the SSD without issue now! Thanks, G.R. > > [1] https://patchwork.kernel.org/project/linux-pci/patch/20220408153159.106741-1-kai.heng.feng@canonical.com/ > [2] https://patchwork.kernel.org/project/linux-pci/patch/20220127025418.1989642-1-kai.heng.feng@canonical.com/#24713767 > From xen-devel-bounces@lists.xenproject.org Sat Jul 09 06:19:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 06:19:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363729.594426 (Exim 4.92) (envelope-from ) id 1oA3ns-0004JM-Ej; Sat, 09 Jul 2022 06:18:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363729.594426; Sat, 09 Jul 2022 06:18:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA3ns-0004JF-C8; Sat, 09 Jul 2022 06:18:56 +0000 Received: by outflank-mailman (input) for mailman id 363729; Sat, 09 Jul 2022 06:18:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA3nq-0004Im-Us; Sat, 09 Jul 2022 06:18:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA3nq-0001Ts-SH; Sat, 09 Jul 2022 06:18:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA3nq-0002MN-AN; Sat, 09 Jul 2022 06:18:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oA3nq-00007D-9r; Sat, 09 Jul 2022 06:18:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NIFN5nl2bZgMAxg3UJM91HzaNWLwNhS6PQiuQomQMiQ=; b=ZHiG9gnT6G1KLeFrXTdDV2gupG NxrfGuHcFf0Yc6g6j+RYT9z1q75Si4Vhd8kq5PfVti9SBBnSm9Lr7NCCSe0hz51cLAtbpWJV94UOR upQqIbf/UHnyMwoXybHIiIc1S/kGjrgGCaf6pEfRTwZQPXT3usM/QDUrocdGUGNdTF7c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171561: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-arm64-arm64-xl::broken:regression linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl:host-install(5):broken:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e8a4e1c1bb697b1d9fc48f0e56dc0f50bc024bee X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 09 Jul 2022 06:18:54 +0000 flight 171561 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171561/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl broken test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl 5 host-install(5) broken pass in 171553 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 15 migrate-support-check fail in 171553 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 171553 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e8a4e1c1bb697b1d9fc48f0e56dc0f50bc024bee baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 20 days Failing since 171280 2022-06-19 15:12:25 Z 19 days 51 attempts Testing same since 171553 2022-07-08 03:03:18 Z 1 days 2 attempts ------------------------------------------------------------ 541 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl broken test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-arm64-arm64-xl broken broken-step test-arm64-arm64-xl host-install(5) Not pushing. (No revision log; it would be 22593 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 09 06:34:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 06:34:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363737.594438 (Exim 4.92) (envelope-from ) id 1oA42o-0007Hm-Um; Sat, 09 Jul 2022 06:34:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363737.594438; Sat, 09 Jul 2022 06:34:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA42o-0007Hf-Rm; Sat, 09 Jul 2022 06:34:22 +0000 Received: by outflank-mailman (input) for mailman id 363737; Sat, 09 Jul 2022 06:34:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA42n-0007HZ-RK for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 06:34:21 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28c7ac30-ff51-11ec-924f-1f966e50362f; Sat, 09 Jul 2022 08:34:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id AA552CE2E97; Sat, 9 Jul 2022 06:34:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 956ECC3411C; Sat, 9 Jul 2022 06:34:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28c7ac30-ff51-11ec-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657348453; bh=2uTm3WC6wxy89V7V/4cci/5HmlCO92Cyj+BDgD/BNfo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MCBWD3s4U8kA4iVEWKblTdkSCNRCHOfNLpLNLmDlorBjcJyIIsm6Gg0jieTau6y2+ 8NJEmjoY7DtJ39rJgF+Ovd3Vjg3gGv+U+Cq/3gBKuYUi2DOiWvfQBqfzG06nMU2Qu+ 8UgwaK/hNQT6DH23pMYCoeHk+UPWkW14mhefAbi0= Date: Sat, 9 Jul 2022 08:34:10 +0200 From: Greg KH To: Demi Marie Obenour Cc: Juergen Gross , Linux kernel regressions , stable@vger.kernel.org, Linux kernel mailing list , Xen developer discussion Subject: Re: gntdev warning fixes Message-ID: References: <20220708163750.2005-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220708163750.2005-1-demi@invisiblethingslab.com> On Fri, Jul 08, 2022 at 12:37:44PM -0400, Demi Marie Obenour wrote: > The recent gntdev fixes introduced two incorrect WARN_ON()s, which > triggered immediately on my system. Patches for master and all > supported stable versions follow. > > This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. From xen-devel-bounces@lists.xenproject.org Sat Jul 09 08:29:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 08:29:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363752.594448 (Exim 4.92) (envelope-from ) id 1oA5pb-0000ik-Ll; Sat, 09 Jul 2022 08:28:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363752.594448; Sat, 09 Jul 2022 08:28:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA5pb-0000id-J3; Sat, 09 Jul 2022 08:28:51 +0000 Received: by outflank-mailman (input) for mailman id 363752; Sat, 09 Jul 2022 08:28:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA5pa-0000iT-IM; Sat, 09 Jul 2022 08:28:50 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA5pa-0004Lb-E9; Sat, 09 Jul 2022 08:28:50 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA5pa-00064E-2g; Sat, 09 Jul 2022 08:28:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oA5pa-0004UT-2E; Sat, 09 Jul 2022 08:28:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/AnGvYaZPE77aR2D4wWC3y8NAtcv3ZpI+RIHe33qTFg=; b=Or3W0dlJrmEg3p45R0rxrQF8x/ G4K+HCw0HjOv+JyLScl8WUSBFhGi3TPz7kjdLW76B51mgwcLbcR3OK7sJLj7O83OjKAQ+zzZVYz+c uthbUD1eskte0peWmL6d4RU1k0NZAItFn3w83dCKVyQg7hUrNTUg/jSvGiazGeXjEBRo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171565: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 09 Jul 2022 08:28:50 +0000 flight 171565 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171565/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 729 days Failing since 151818 2020-07-11 04:18:52 Z 728 days 710 attempts Testing same since 171555 2022-07-08 04:20:30 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115427 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 09 08:53:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 08:53:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363761.594460 (Exim 4.92) (envelope-from ) id 1oA6Cz-00059N-OG; Sat, 09 Jul 2022 08:53:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363761.594460; Sat, 09 Jul 2022 08:53:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA6Cz-00059G-JM; Sat, 09 Jul 2022 08:53:01 +0000 Received: by outflank-mailman (input) for mailman id 363761; Sat, 09 Jul 2022 08:52:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA6Cx-000594-Nw; Sat, 09 Jul 2022 08:52:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA6Cx-0004ms-Mu; Sat, 09 Jul 2022 08:52:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA6Cx-0006nJ-4J; Sat, 09 Jul 2022 08:52:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oA6Cx-0002W1-3u; Sat, 09 Jul 2022 08:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=sbPEeAEyAc4H7oK5grYT+XiM6F7EWE1R0Y/QMthHfl4=; b=x7R3A7GKQ2BarZKKHTLnXUFHl4 SGyYf/BhGk0Lzwq2zaZ+rK1Rnv4PazGjAw5utGAVLYeAVC8KO4nZ2CyglRVCTLGW4PR4SzgWkySY9 rzeYpsIYOTRuGVNTVg+E/Oxrz4ii5PlQZ1O1EwRvJ/51CqlL/5znJ0WIBbeIGTcdgP/0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171567: all pass - PUSHED X-Osstest-Versions-This: ovmf=86a0f84470f7df815c54b6da26874314e58c8a1a X-Osstest-Versions-That: ovmf=e93bc6309ba743c6bdaae4d1dc6f0fb141c47ee5 From: osstest service owner Date: Sat, 09 Jul 2022 08:52:59 +0000 flight 171567 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171567/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 86a0f84470f7df815c54b6da26874314e58c8a1a baseline version: ovmf e93bc6309ba743c6bdaae4d1dc6f0fb141c47ee5 Last test of basis 171554 2022-07-08 04:10:36 Z 1 days Testing same since 171567 2022-07-09 07:10:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kun Qin jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e93bc6309b..86a0f84470 86a0f84470f7df815c54b6da26874314e58c8a1a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 09 10:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 10:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363770.594471 (Exim 4.92) (envelope-from ) id 1oA7Js-00088q-Sd; Sat, 09 Jul 2022 10:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363770.594471; Sat, 09 Jul 2022 10:04:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7Js-00088j-Ny; Sat, 09 Jul 2022 10:04:12 +0000 Received: by outflank-mailman (input) for mailman id 363770; Sat, 09 Jul 2022 10:04:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7Jr-00088Z-Vm; Sat, 09 Jul 2022 10:04:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7Jr-00067v-SO; Sat, 09 Jul 2022 10:04:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7Jr-0000Ge-9H; Sat, 09 Jul 2022 10:04:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oA7Jr-0007Dw-8q; Sat, 09 Jul 2022 10:04:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UT36PftOLQCnd/fxXNS7xCq0DtCyRmSypPQScwrVL7o=; b=187Oh4gOK0i1fQrk+5g1lOIxOF vmVul/dFEXE5ph72vwzZDjZKpfI3wtMZ0e2JMZeYjjle5cwh4L/jefiYZAFt5ZwUBwVjHTtbNk3if 5n4eRNH3RcHgGir5+dj5Fr1EtH2YZBHyagUpsQ1L1tEorhr/Y/lA1QK0+CRRW4iGkJeo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171564: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 X-Osstest-Versions-That: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 From: osstest service owner Date: Sat, 09 Jul 2022 10:04:11 +0000 flight 171564 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171564/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail like 171560 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171560 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171560 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171560 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171560 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171560 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171560 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171560 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171560 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171560 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171560 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171560 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171560 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171560 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 baseline version: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 Last test of basis 171564 2022-07-09 02:16:06 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jul 09 10:10:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 10:10:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363779.594482 (Exim 4.92) (envelope-from ) id 1oA7QB-0001q5-M5; Sat, 09 Jul 2022 10:10:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363779.594482; Sat, 09 Jul 2022 10:10:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QB-0001py-JG; Sat, 09 Jul 2022 10:10:43 +0000 Received: by outflank-mailman (input) for mailman id 363779; Sat, 09 Jul 2022 10:10:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QA-0001pr-DQ for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 10:10:42 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6326e96e-ff6f-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 12:10:41 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id d16so1241363wrv.10 for ; Sat, 09 Jul 2022 03:10:41 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id r1-20020a5d6941000000b00210bac248c8sm1095853wrw.11.2022.07.09.03.10.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 03:10:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6326e96e-ff6f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2VzBKUbne564f7X98AD2TghzEOsZhMoWEw97a29fkeU=; b=ZXIArg7WwgzcYbM75bfLzAdWVDATXIBFk3Tw2qFFBUgIljtwi13Gcy2AHmIPVt7XIO ExXK8ZYZg3Ui5ZsvczTXKF8Hlr7Tl6ltaT8kJxiVostwcLdTCuw98eG0YK426BlP78hG HnOmSYPRV+fFhwNnBJEZbF32aPfrG+6oUnLRjZS8uwY19SniNmfSdKGGioOnJYWyaF6P PhZLn7ASOqIUjEzQTCDl/200XkVisybqgbrablIkwFdfxBwtMWH5yp00sSs5WTgDpsPb GXGBqR6T46Y1hOwZ12MMJUXik7e97pECT5wZlnxPj/r1Jw7EMIUJPhoYSn4pk+brXiBQ HTjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=2VzBKUbne564f7X98AD2TghzEOsZhMoWEw97a29fkeU=; b=MzYNq80/bfxLEeTJwsif8N/DascdBROmjx3lkwkNzke+spUS4DW9ViK0vSSqPm8YEj FQqEcRVAsOFcgQnWjUxp8PcA0lM10zU2a9+hhgnrVxNv8d0vBgl1acN4QAo5Z9mOYWkw kJRxWYuGG0ksQ7rAUphB5c54CaU96KBQCYOKRhaLr/yIR2Ym9P3a37KvPGnfVLg/+SLY +SYZgiUCzOAvZpAqIQyAvUFT08wow03ZjELeD74e5mRjd+QWNbf+SQinVva4FnH4LC6l zlYHP297YcDJxD2ifEZ9falMr/NhIxML+IRPugz3Sf395kwVe38OP2KRLIIPOZ5b8e3b TRBg== X-Gm-Message-State: AJIora+6Jo9Fw9oKq7zwDcziRWUmO1zlZ0Ft3ohm7VtsB+YOT8n2bYGX pqX0t/ce4coTK8130SavrhzDGtSZFICN8jvz X-Google-Smtp-Source: AGRyM1td5eFh9XLAbU+j4vlRvJLQTn6K72FcdKpCQEaAT7TOQXnu85qi0zZvazdZCEtNYIVL405wuw== X-Received: by 2002:a5d:644d:0:b0:21d:645c:d3f4 with SMTP id d13-20020a5d644d000000b0021d645cd3f4mr7173872wrw.484.1657361440348; Sat, 09 Jul 2022 03:10:40 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 1/4] tools: remove xenstore entries on vchan server closure Date: Sat, 9 Jul 2022 13:10:32 +0300 Message-Id: <20220709101035.2989428-1-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko --- tools/include/libxenvchan.h | 5 +++++ tools/libs/vchan/init.c | 23 +++++++++++++++++++++++ tools/libs/vchan/io.c | 4 ++++ tools/libs/vchan/vchan.h | 31 +++++++++++++++++++++++++++++++ 4 files changed, 63 insertions(+) create mode 100644 tools/libs/vchan/vchan.h diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index d6010b145d..30cc73cf97 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -86,6 +86,11 @@ struct libxenvchan { int blocking:1; /* communication rings */ struct libxenvchan_ring read, write; + /** + * Base xenstore path for storing ring/event data used by the server + * during cleanup. + * */ + char *xs_path; }; /** diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index c8510e6ce9..c6b8674ef5 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -46,6 +46,8 @@ #include #include +#include "vchan.h" + #ifndef PAGE_SHIFT #define PAGE_SHIFT 12 #endif @@ -251,6 +253,10 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base char ref[16]; char* domid_str = NULL; xs_transaction_t xs_trans = XBT_NULL; + + // store the base path so we can clean up on server closure + ctrl->xs_path = strdup(xs_base); + xs = xs_open(0); if (!xs) goto fail; @@ -298,6 +304,23 @@ retry_transaction: return ret; } +void close_xs_srv(struct libxenvchan *ctrl) +{ + struct xs_handle *xs; + + if (!ctrl->xs_path) + return; + + xs = xs_open(0); + if (!xs) + goto fail; + + xs_rm(xs, XBT_NULL, ctrl->xs_path); + +fail: + free(ctrl->xs_path); +} + static int min_order(size_t siz) { int rv = PAGE_SHIFT; diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c index da303fbc01..1f201ad554 100644 --- a/tools/libs/vchan/io.c +++ b/tools/libs/vchan/io.c @@ -40,6 +40,8 @@ #include #include +#include "vchan.h" + #ifndef PAGE_SHIFT #define PAGE_SHIFT 12 #endif @@ -384,5 +386,7 @@ void libxenvchan_close(struct libxenvchan *ctrl) if (ctrl->gnttab) xengnttab_close(ctrl->gnttab); } + if (ctrl->is_server) + close_xs_srv(ctrl); free(ctrl); } diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h new file mode 100644 index 0000000000..621016ef42 --- /dev/null +++ b/tools/libs/vchan/vchan.h @@ -0,0 +1,31 @@ +/** + * @file + * @section AUTHORS + * + * Copyright (C) 2021 EPAM Systems Inc. + * + * @section LICENSE + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + * + * @section DESCRIPTION + * + * This file contains common libxenvchan declarations. + */ +#ifndef LIBVCHAN_H +#define LIBVCHAN_H + +void close_xs_srv(struct libxenvchan *ctrl); + +#endif /* LIBVCHAN_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 09 10:10:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 10:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363780.594493 (Exim 4.92) (envelope-from ) id 1oA7QI-00028E-TO; Sat, 09 Jul 2022 10:10:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363780.594493; Sat, 09 Jul 2022 10:10:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QI-000283-Qk; Sat, 09 Jul 2022 10:10:50 +0000 Received: by outflank-mailman (input) for mailman id 363780; Sat, 09 Jul 2022 10:10:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QH-0001pr-DZ for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 10:10:49 +0000 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [2a00:1450:4864:20::429]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 678e645a-ff6f-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 12:10:48 +0200 (CEST) Received: by mail-wr1-x429.google.com with SMTP id q9so1249160wrd.8 for ; Sat, 09 Jul 2022 03:10:48 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id r1-20020a5d6941000000b00210bac248c8sm1095853wrw.11.2022.07.09.03.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 03:10:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 678e645a-ff6f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FdgXdjgQh89IeUkwMBUPt38dYuhV59i+wwEctSJttBo=; b=XUZyAbm/HuK+KfFKLsWaB5JNhioNRO8XZDjHEY+Dmcx0RPK29l9yP1uzinmFxHcwAN 5hHd2HgHRZ9zZwxBDgRcLCwkZdXqWGmMXIq1ZmVnvazkBW34un+0P2Eh0Lgpxv3nGusI 8NNmH3bcuCYZJBd6k4pR11TghUgyyHlTbnN1ejofXARgf01m0Y6B3iahCfO4opfoTNA6 RF7lg1S96OMee/7ijiyEYEec9atn9K4DanCVQE21nON/EjWUiFfYsJXhh+1wQmLzDtVY r8artQWFxCRxwNjePt7nAqU8JgYfERBUxVAaTk0wK5AG4TXkOs1z6LjhwHfT/+b07Z7E oWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FdgXdjgQh89IeUkwMBUPt38dYuhV59i+wwEctSJttBo=; b=gjV6zi+WTyB0vvhbiqGY3GFmDfdwBCue0YCgT+qmaqu1hYEXvlXw3FjPE0f4V8GXOC 4rPDEPEuTLaJf2Yu/tYAy3TM/A1UQed2rcxcvcvTklPENzieTZ/jE2BqVX292C3/GHaP T/Umasqd/73hcyxOzCu/OsXVY8SEKLvrpOh0kCF0jpQYyKVfWg0MF5XNDp0mCa1lMbvw QyoGscfyuNAcWbSJ2vegFOvE7QhuMNvFqhupQcxgG+AHdOcSiD1BIQYDpiYJGVgOzod8 WHTQnNuq9VyNkD1JoFSpsKaQUyx15boLm5TgZ4XhegXkg2SHUjBO8rpc9IdfkBw2faLp kjOA== X-Gm-Message-State: AJIora+XmTOhmfPdLvye/PHgsQtnUPRZUdTTb4kKOMiFTM7sqvJo97KZ GaVpodLekJK5zYEuohdvjhb4P8ReLPWFJ/d9 X-Google-Smtp-Source: AGRyM1s3flc8y7JDH8oC5SdUmy3+K27fy4iI+qwUMNPEojWjB0DIN7ZHYlXa76JGOR5J/zoUUcp51w== X-Received: by 2002:adf:ffc1:0:b0:21d:66a1:c3ee with SMTP id x1-20020adfffc1000000b0021d66a1c3eemr7178495wrs.364.1657361447755; Sat, 09 Jul 2022 03:10:47 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross Subject: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long Date: Sat, 9 Jul 2022 13:10:33 +0300 Message-Id: <20220709101035.2989428-2-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220709101035.2989428-1-dmitry.semenets@gmail.com> References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Current vchan implementation, while dealing with XenStore paths, allocates 64 bytes buffer on the stack which may not be enough for some use-cases. Make the buffer longer to respect maximum allowed XenStore path of XENSTORE_ABS_PATH_MAX. Signed-off-by: Oleksandr Andrushchenko --- tools/libs/vchan/init.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index c6b8674ef5..17945c24a1 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -249,7 +249,7 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base int ret = -1; struct xs_handle *xs; struct xs_permissions perms[2]; - char buf[64]; + char *buf; char ref[16]; char* domid_str = NULL; xs_transaction_t xs_trans = XBT_NULL; @@ -257,6 +257,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base // store the base path so we can clean up on server closure ctrl->xs_path = strdup(xs_base); + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) { + free(ctrl); + return 0; + } + xs = xs_open(0); if (!xs) goto fail; @@ -278,14 +284,14 @@ retry_transaction: goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ring_ref); - snprintf(buf, sizeof buf, "%s/ring-ref", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ctrl->event_port); - snprintf(buf, sizeof buf, "%s/event-channel", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) @@ -301,6 +307,7 @@ retry_transaction: free(domid_str); xs_close(xs); fail: + free(buf); return ret; } @@ -418,13 +425,20 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, { struct libxenvchan *ctrl = malloc(sizeof(struct libxenvchan)); struct xs_handle *xs = NULL; - char buf[64]; + char *buf; char *ref; int ring_ref; unsigned int len; if (!ctrl) return 0; + + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) { + free(ctrl); + return 0; + } + ctrl->ring = NULL; ctrl->event = NULL; ctrl->gnttab = NULL; @@ -435,8 +449,9 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, if (!xs) goto fail; + // find xenstore entry - snprintf(buf, sizeof buf, "%s/ring-ref", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -444,7 +459,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, free(ref); if (!ring_ref) goto fail; - snprintf(buf, sizeof buf, "%s/event-channel", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -474,6 +489,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, out: if (xs) xs_close(xs); + free(buf); return ctrl; fail: libxenvchan_close(ctrl); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 09 10:10:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 10:10:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363781.594504 (Exim 4.92) (envelope-from ) id 1oA7QL-0002Pc-6U; Sat, 09 Jul 2022 10:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363781.594504; Sat, 09 Jul 2022 10:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QL-0002PR-3L; Sat, 09 Jul 2022 10:10:53 +0000 Received: by outflank-mailman (input) for mailman id 363781; Sat, 09 Jul 2022 10:10:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QJ-0001pr-QA for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 10:10:52 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 68802849-ff6f-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 12:10:50 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id v14so1265469wra.5 for ; Sat, 09 Jul 2022 03:10:50 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id r1-20020a5d6941000000b00210bac248c8sm1095853wrw.11.2022.07.09.03.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 03:10:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68802849-ff6f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=o8OSB73HYoVg9SH33htKf8c4svw80U8RHuxNi/KmYSo=; b=Gidtaxn45o/M2tcSpD3avIRNJ/XA/1CQcNOOe0GKrRT6JAqr+PZowgh9w/Zu0x3qVx tP9zRq2RdD290davfVuQLBnGJ/b2DMmFD41qEojYq42cRgv3bLtWoTgfV0kPBfri3s6/ KhPwrh7skJDxMrVAjsqaP7W/dax2RayFgc2dBdeaz7aadJR+noevgnOlmPSW09z+4ox9 k9ry4Ms70XQ8mKqihkH0+sz0H1OTTqC6inI/UnshBtxleaaElBJf/Hpf7sIXXIg14BVt AejlUsVUCnwZ67dY/ykoOJ4g6G5Bps+RsiyztoU/xLcM3flIRrKtd6znydLMG0l5lA/8 yr3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=o8OSB73HYoVg9SH33htKf8c4svw80U8RHuxNi/KmYSo=; b=44DH+8yUHD3LF3ARiAiIP3mNGa6wesJOTiDwYJpw4jK/G8kz2u/pvix3Xgmzc50BoK iBKIv+2m81CtnaxjggddrD6BJ6WGF6qGlz8gBdKOaHnWKKLbuwNuPSpgP1mpy7ztlc92 vev/iYuR/MbxyfOIgffz5YJ1B+2ZriSSPGMoqAqLtUZ84+gVJ8OQEPUUEDz2nHNYaVvc g1Qifl9kV46JW8n2NGMVoBLFwa4iDVuzEnCKOJRcXLg7A7Na+kgvvkRF39ZyVy1QOtDn ZU3wqzgTbBx8ZnNS+nVUcYGLSIxWFX3jeH9Um6zqklysWRmDLe6tCl7j8yct3LuDGT7f Ngng== X-Gm-Message-State: AJIora/DmlB2GRG/g2D1V37Gwv/j4T6xNrn3kKtHus4Vff9EPONwjCf3 9u+9DxTn4TYgHKeDKBY/BkxzeIHdKtVz7n10 X-Google-Smtp-Source: AGRyM1u5sWLl27+RENYYLTGx78k88S+cr24F22Gu1Rl6lbJmmFI4mRn0JIyg+8b7UdUl/KhVpCSxsw== X-Received: by 2002:a5d:4e49:0:b0:21d:6e8a:fa3 with SMTP id r9-20020a5d4e49000000b0021d6e8a0fa3mr7159417wrt.528.1657361449328; Sat, 09 Jul 2022 03:10:49 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Anastasiia Lukianenko Subject: [PATCH 3/4] tools/libs/light: Add vchan support to libxl Date: Sat, 9 Jul 2022 13:10:34 +0300 Message-Id: <20220709101035.2989428-3-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220709101035.2989428-1-dmitry.semenets@gmail.com> References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add possibility to send commands from libxl and execute them on server side. Libxl vchan adds support for JSON messages processing. The using of libxl vchan is preventing the client from libxl from reading and writing from / to the local sysfs directly.To do this, the libxl vchan was added - instead of working with the read and write functions from / to the sysfs, functionality allows to send requests to the server, then receive and process the response. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko --- tools/helpers/Makefile | 4 +- tools/libs/light/Makefile | 7 +- tools/libs/light/libxl_vchan.c | 488 +++++++++++++++++++++++++++++++++ tools/libs/light/libxl_vchan.h | 92 +++++++ tools/xl/Makefile | 3 +- 5 files changed, 588 insertions(+), 6 deletions(-) create mode 100644 tools/libs/light/libxl_vchan.c create mode 100644 tools/libs/light/libxl_vchan.h diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 7f6c422440..3240ef2b6e 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -30,10 +30,10 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h all: $(PROGS) xen-init-dom0: $(XEN_INIT_DOM0_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) - $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) .PHONY: install install: all diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 453bea0067..ea8994af6d 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -77,6 +77,7 @@ SRCS-y += libxl.c SRCS-y += libxl_create.c SRCS-y += libxl_dm.c SRCS-y += libxl_pci.c +SRCS-y += libxl_vchan.c SRCS-y += libxl_dom.c SRCS-y += libxl_exec.c SRCS-y += libxl_xshelp.c @@ -175,7 +176,7 @@ LDUSELIBS-y += $(PTHREAD_LIBS) LDUSELIBS-y += -lyajl LDUSELIBS += $(LDUSELIBS-y) -$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h +$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) $(CFLAGS_libxenevtchn) -include $(XEN_ROOT)/tools/config.h $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\" $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore) libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools # include libacpi/x86.h @@ -231,13 +232,13 @@ libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDUSELIBS) $(APPEND_LDFLAGS) test_%: test_%.o test_common.o libxenlight_test.so - $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) testidl: testidl.o libxenlight.so - $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) install: installlocal $(LIBHEADERS) diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c new file mode 100644 index 0000000000..c87024f00f --- /dev/null +++ b/tools/libs/light/libxl_vchan.c @@ -0,0 +1,488 @@ +/* + * Vchan support for JSON messages processing + * + * Copyright (C) 2021 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#define VCHAN_EOM "\r\n" +/* + * http://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html + * 1.4.4 Domain Controlled Paths + * 1.4.4.1 ~/data [w] + * A domain writable path. Available for arbitrary domain use. + */ +#define VCHAN_SRV_DIR "/local/domain" + +struct vchan_state { + struct libxenvchan *ctrl; + + /* Server domain ID. */ + libxl_domid domid; + + /* XenStore path of the server with the ring buffer and event channel. */ + char *xs_path; + + int select_fd; + + /* GC used for state's lifetime allocations, such as rx_buf. */ + libxl__gc *gc; + /* Receive buffer. */ + char *rx_buf; + /* Current allocated size. */ + size_t rx_buf_size; + /* Actual data in the buffer. */ + size_t rx_buf_used; + + /* YAJL generator used to parse and create requests/replies. */ + yajl_gen gen; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen gen, + const char *field, char *val) +{ + libxl__json_object *result; + + libxl__yajl_gen_asciiz(gen, field); + result = libxl__json_object_alloc(gc, JSON_STRING); + result->u.string = val; + return libxl__json_object_to_yajl_gen(gc, gen, result); +} + +static libxl__json_object *libxl__vchan_arg_new(libxl__gc *gc, + libxl__json_node_type type, + libxl__json_object *args, + char *key) +{ + libxl__json_map_node *arg; + libxl__json_object *obj; + + obj = libxl__json_object_alloc(gc, type); + + GCNEW(arg); + + arg->map_key = key; + arg->obj = obj; + + flexarray_append(args->u.map, arg); + + return obj; +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_STRING, args, key); + + obj->u.string = val; +} + +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_BOOL, args, key); + + obj->u.b = val; +} + +static void reset_yajl_generator(struct vchan_state *state) +{ + yajl_gen_clear(state->gen); + yajl_gen_reset(state->gen, NULL); +} + +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf = NULL; + size_t len = 0; + + yajl_gen_get_buf(gen, &buf, &len); + LOG(DEBUG, "%s\n", buf); +} + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state) +{ + vchan_dump_gen(gc, state->gen); +} + +/* + * Find a JSON object and store it in o_r. + * return ERROR_NOTFOUND if no object is found. + */ +static int vchan_get_next_msg(libxl__gc *gc, struct vchan_state *state, + libxl__json_object **o_r) +{ + size_t len; + char *end = NULL; + const size_t eoml = sizeof(VCHAN_EOM) - 1; + libxl__json_object *o = NULL; + + if (!state->rx_buf_used) + return ERROR_NOTFOUND; + + /* Search for the end of a message which is CRLF. */ + end = memmem(state->rx_buf, state->rx_buf_used, VCHAN_EOM, eoml); + if (!end) + return ERROR_NOTFOUND; + + len = (end - state->rx_buf) + eoml; + + LOGD(DEBUG, state->domid, "parsing %zuB: '%.*s'", len, (int)len, + state->rx_buf); + + /* Replace \r by \0 so that libxl__json_parse can use strlen */ + state->rx_buf[len - eoml] = '\0'; + + o = libxl__json_parse(gc, state->rx_buf); + state->rx_buf_used -= len; + if (!o) { + LOGD(ERROR, state->domid, "Parse error"); + /* + * In case of parsing error get back to a known state: + * reset the buffer and continue reading. + */ + return ERROR_INVAL; + } + + memmove(state->rx_buf, state->rx_buf + len, state->rx_buf_used); + + LOGD(DEBUG, state->domid, "JSON object received: %s", JSON(o)); + + *o_r = o; + + return 0; +} + +static int vchan_process_packet(libxl__gc *gc, struct vchan_info *vchan, + libxl__json_object **resp_result) +{ + while (true) { + struct vchan_state *state = vchan->state; + int rc; + ssize_t r; + + if (!libxenvchan_is_open(state->ctrl)) + return ERROR_FAIL; + + /* Check if the buffer still has space or increase its size. */ + if (state->rx_buf_size - state->rx_buf_used < vchan->receive_buf_size) { + size_t newsize = state->rx_buf_size * 2 + vchan->receive_buf_size; + + if (newsize > vchan->max_buf_size) { + LOGD(ERROR, state->domid, + "receive buffer is too big (%zu > %zu)", + newsize, vchan->max_buf_size); + return ERROR_NOMEM; + } + + state->rx_buf_size = newsize; + state->rx_buf = libxl__realloc(state->gc, state->rx_buf, + state->rx_buf_size); + } + + do { + libxl__json_object *msg; + + r = libxenvchan_read(state->ctrl, + state->rx_buf + state->rx_buf_used, + state->rx_buf_size - state->rx_buf_used); + + if (r < 0) { + LOGED(ERROR, state->domid, "error reading"); + return ERROR_FAIL; + } else if (r == 0) + continue; + + LOG(DEBUG, "received %zdB: '%.*s'", r, + (int)r, state->rx_buf + state->rx_buf_used); + + state->rx_buf_used += r; + assert(state->rx_buf_used <= state->rx_buf_size); + + /* parse rx buffer to find one json object */ + rc = vchan_get_next_msg(gc, state, &msg); + if ((rc == ERROR_INVAL) || (rc == ERROR_NOTFOUND)) + continue; + if (rc) + return rc; + + if (resp_result) + return vchan->handle_response(gc, msg, resp_result); + else { + reset_yajl_generator(state); + return vchan->handle_request(gc, state->gen, msg); + } + } while (libxenvchan_data_ready(state->ctrl)); + } + + return 0; +} + +static int vchan_write(libxl__gc *gc, struct vchan_state *state, char *cmd) +{ + size_t len; + int ret; + + len = strlen(cmd); + while (len) { + ret = libxenvchan_write(state->ctrl, cmd, len); + if (ret < 0) { + LOGE(ERROR, "vchan write failed"); + return ERROR_FAIL; + } + cmd += ret; + len -= ret; + } + return 0; +} + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args) +{ + libxl__json_object *result; + char *request; + int ret; + + reset_yajl_generator(vchan->state); + request = vchan->prepare_request(gc, vchan->state->gen, cmd, args); + if (!request) + return NULL; + + ret = vchan_write(gc, vchan->state, request); + if (ret < 0) + return NULL; + + ret = vchan_write(gc, vchan->state, VCHAN_EOM); + if (ret < 0) + return NULL; + + ret = vchan_process_packet(gc, vchan, &result); + if (ret < 0) + return NULL; + + return result; +} + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan) +{ + char *json_str; + int ret; + + ret = vchan_process_packet(gc, vchan, NULL); + if (ret) + return ret; + + json_str = vchan->prepare_response(gc, vchan->state->gen); + if (!json_str) + return ERROR_INVAL; + + ret = vchan_write(gc, vchan->state, json_str); + if (ret) + return ret; + + return vchan_write(gc, vchan->state, VCHAN_EOM); +} + +static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file) +{ + char **domains; + unsigned int i, n; + libxl_domid domid = DOMID_INVALID; + + domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); + if (!n) + goto out; + + for (i = 0; i < n; i++) { + const char *tmp; + int d; + + if (sscanf(domains[i], "%d", &d) != 1) + continue; + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); + /* Found the domain where the server lives. */ + if (tmp) { + domid = d; + break; + } + } + +out: + return domid; +} + +static int vchan_init_client(libxl__gc *gc, struct vchan_state *state, + bool is_server) +{ + if (is_server) { + state->ctrl = libxenvchan_server_init(NULL, state->domid, + state->xs_path, 0, 0); + if (!state->ctrl) { + perror("Couldn't initialize vchan server"); + exit(1); + } + + } else { + state->ctrl = libxenvchan_client_init(CTX->lg, state->domid, + state->xs_path); + if (!state->ctrl) { + LOGE(ERROR, "Couldn't initialize vchan client"); + return ERROR_FAIL; + } + } + + state->ctrl->blocking = 1; + state->select_fd = libxenvchan_fd_for_select(state->ctrl); + if (state->select_fd < 0) { + LOGE(ERROR, "Couldn't read file descriptor for vchan client"); + return ERROR_FAIL; + } + + LOG(DEBUG, "Initialized vchan %s, XenSore at %s", + is_server ? "server" : "client", state->xs_path); + + return 0; +} + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server) +{ + struct vchan_state *state; + yajl_gen gen; + int ret; + + gen = libxl_yajl_gen_alloc(NULL); + if (!gen) { + LOGE(ERROR, "Failed to allocate yajl generator"); + return NULL; + } + +#if HAVE_YAJL_V2 + /* Disable beautify for data */ + yajl_gen_config(gen, yajl_gen_beautify, 0); +#endif + + state = libxl__zalloc(gc, sizeof(*state)); + state->domid = domid; + state->xs_path = vchan_xs_path; + state->gc = gc; + ret = vchan_init_client(gc, state, is_server); + if (ret) { + state = NULL; + yajl_gen_free(gen); + } + + state->gen = gen; + + return state; +} + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name) +{ + return GCSPRINTF(VCHAN_SRV_DIR "/%d/data/%s", domid, srv_name); +} + +/* + * Wait for the server to create the ring and event channel: + * since the moment we create a XS folder to the moment we start + * watching it the server may have already created the ring and + * event channel entries. Thus, we cannot watch reliably here without + * races, so poll for both entries to be created. + */ +static int vchan_wait_server_available(libxl__gc *gc, const char *xs_path) +{ + char *xs_ring, *xs_evt; + int timeout_ms = 5000; + + xs_ring = GCSPRINTF("%s/ring-ref", xs_path); + xs_evt = GCSPRINTF("%s/event-channel", xs_path); + + while (timeout_ms) { + unsigned int len; + void *file; + int entries = 0; + + file = xs_read(CTX->xsh, XBT_NULL, xs_ring, &len); + if (file) { + entries++; + free(file); + } + + file = xs_read(CTX->xsh, XBT_NULL, xs_evt, &len); + if (file) { + entries++; + free(file); + } + + if (entries == 2) + return 0; + + timeout_ms -= 10; + usleep(10000); + } + + return ERROR_TIMEDOUT; +} + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) +{ + libxl_domid domid; + char *xs_path, *vchan_xs_path; + libxl_uuid uuid; + libxl_ctx *ctx = libxl__gc_owner(gc); + + domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name); + if (domid == DOMID_INVALID) { + LOGE(ERROR, "Can't find vchan server"); + return NULL; + } + + xs_path = vchan_get_server_xs_path(gc, domid, srv_name); + LOG(DEBUG, "vchan server at %s\n", xs_path); + + /* Generate unique client id. */ + libxl_uuid_generate(&uuid); + + vchan_xs_path = GCSPRINTF("%s/" LIBXL_UUID_FMT, xs_path, + LIBXL_UUID_BYTES((uuid))); + + if (!xs_mkdir(ctx->xsh, XBT_NULL, vchan_xs_path)) { + LOG(ERROR, "Can't create xs_dir at %s", vchan_xs_path); + return NULL; + } + + if (vchan_wait_server_available(gc, vchan_xs_path)) { + LOG(ERROR, "Failed to wait for the server to come up at %s", + vchan_xs_path); + return NULL; + } + + return vchan_init_new_state(gc, domid, vchan_xs_path, false); +} + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state) +{ + if (!state) + return; + + LOG(DEBUG, "Closing vchan"); + libxenvchan_close(state->ctrl); + + yajl_gen_free(state->gen); +} diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h new file mode 100644 index 0000000000..0968875298 --- /dev/null +++ b/tools/libs/light/libxl_vchan.h @@ -0,0 +1,92 @@ +/* + Common definitions for JSON messages processing by vchan + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef LIBXL_VCHAN_H +#define LIBXL_VCHAN_H + +#include + +struct vchan_state; + +struct vchan_info { + struct vchan_state *state; + + /* Process request and produce the result by adding json-objects to gen .*/ + int (*handle_request)(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request); + /* Convert the prepared response into JSON string. */ + char *(*prepare_response)(libxl__gc *gc, yajl_gen gen); + + /* Prepare request as JSON string which will be sent. */ + char *(*prepare_request)(libxl__gc *gc, yajl_gen gen, char *request, + libxl__json_object *args); + /* Handle response and produce the output suitable for the requester. */ + int (*handle_response)(libxl__gc *gc, const libxl__json_object *response, + libxl__json_object **result); + + /* Handle new client connection on the server side. */ + int (*handle_new_client)(libxl__gc *gc); + + /* Buffer info. */ + size_t receive_buf_size; + size_t max_buf_size; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen hand, + const char *field, char *val); + +static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) +{ + return libxl__json_object_alloc(gc, JSON_MAP); +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val); +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val); + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args); + +void vchan_reset_generator(struct vchan_state *state); + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan); + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name); + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server); + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name); + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state); + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state); +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen); + +#endif /* LIBXL_VCHAN_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/xl/Makefile b/tools/xl/Makefile index b7f439121a..5dfff7fc6f 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -15,6 +15,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS) CFLAGS_XL += $(CFLAGS_libxenlight) CFLAGS_XL += $(CFLAGS_libxenutil) CFLAGS_XL += -Wshadow +CFLAGS_XL += $(CFLAGS_libxenvchan) XL_OBJS-$(CONFIG_X86) = xl_psr.o XL_OBJS = xl.o xl_cmdtable.o xl_sxp.o xl_utils.o $(XL_OBJS-y) @@ -33,7 +34,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 09 10:10:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 10:10:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363783.594515 (Exim 4.92) (envelope-from ) id 1oA7QQ-0002mj-Ky; Sat, 09 Jul 2022 10:10:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363783.594515; Sat, 09 Jul 2022 10:10:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QQ-0002mc-HR; Sat, 09 Jul 2022 10:10:58 +0000 Received: by outflank-mailman (input) for mailman id 363783; Sat, 09 Jul 2022 10:10:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oA7QP-0001pr-Fd for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 10:10:57 +0000 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [2a00:1450:4864:20::335]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a394c70-ff6f-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 12:10:53 +0200 (CEST) Received: by mail-wm1-x335.google.com with SMTP id c131-20020a1c3589000000b003a2cc290135so887663wma.2 for ; Sat, 09 Jul 2022 03:10:53 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id r1-20020a5d6941000000b00210bac248c8sm1095853wrw.11.2022.07.09.03.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Jul 2022 03:10:50 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a394c70-ff6f-11ec-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1t/r7Z1a+hfnt9hQpupUQYuausKRlncsenXFzN5C8E=; b=PyvvOkdux1CoFn/O9r8ks6GBPNKxlutTXmMtAHsFgKG4JfaAYlJNc3CHqG+2rapv2b bmUkS/K7EUCqN4bVgcjPDPKkK2aypo/z/cOo8033/2uf2yhQ7NysH99/5YURonZGkxkg SRpNyhcoxxWRu31C+NVUi0NzTV07yaqDwX6xALpgfaOR9hlwL2UfbFyefBmiAAm8IQhd 6YLfabzWniBQmQ7jap7OnWZlUinVeJ/a5P91RfsbBAVbrCISYo4W8RG6zFiDO1Q4iTbp kUi6MtUboFcF9RVRHveZwpVFZ8/HV150N3oYutXLgV8XDGumo1jm7bHLftozVdovZXVD 9n4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1t/r7Z1a+hfnt9hQpupUQYuausKRlncsenXFzN5C8E=; b=lwrebP5WxzWtxk0AhghNPhbAmazUAc4OjsavfQJelm6NbFdbUF5uqGky4QDcFZd9YY LGsdXJBxaSkYs39oPYg/4I+QHGmujJ1YM4SbEZ9iFXu5isU3GlbFDx58c+nsodmbRW0r Z/Y+U5mZmo1ovVYBMrJEth7jIKYEELMSbI0sM3lYhxshcR7jo9weMtd2S6Ugrauj4AeH xLMDdm8iY0AfVb5OcKWoWYKOO7A9w4Zl5CuaF09E01gw+RKjglBp1e3gqxQAJPtZHUUp CkXDpNMreXCk3DtTTRwnkp1ODHnx2rCwDJDQ8qaHIHCAukustu6CsyEy7SisBmurHgKO SC7w== X-Gm-Message-State: AJIora8FQlhj46USJsQNLbKVfr/84lGIs/VUDAIWyVq/hiXPHGMIe3ml Scis8QHOcREGZ2tw92yB6V8n4mfvo+FZt7Du X-Google-Smtp-Source: AGRyM1uQIIRv7uPEk4q9GWVPNBALSbAw9qb9Jp+ugHj9QJmoVrsM+sHKKPeDKK+RclpnSIAp+4DC0Q== X-Received: by 2002:a05:600c:a41:b0:39c:1512:98bd with SMTP id c1-20020a05600c0a4100b0039c151298bdmr4734975wmq.88.1657361451061; Sat, 09 Jul 2022 03:10:51 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Dmytro Semenets , Anastasiia Lukianenko , Volodymyr Babchuk Subject: [PATCH 4/4] tools/xl: Add pcid daemon to xl Date: Sat, 9 Jul 2022 13:10:35 +0300 Message-Id: <20220709101035.2989428-4-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220709101035.2989428-1-dmitry.semenets@gmail.com> References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add pcid daemon (based on vchan-node2) implements pcid protocol. Protocol is OS independed and should work on ane supported OS. Add essential functionality to handle pcid protocol: - define required constants - prepare for handling remote requests - prepare and send an error packet pcid server used if domain has passthrough PCI controller and we wants assign some device to other domain. pcid server should be launched in domain owns the PCI controller and process request from other domains. Message exchange imnplementation based on JSON via libvchan. Supported messages: - make_assignable - revert_assignable - is_device_assigned - resource_list - reset_device - write_bdf Signed-off-by: Dmytro Semenets Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko Signed-off-by: Volodymyr Babchuk --- docs/man/xl-pci-configuration.5.pod | 14 + tools/configure | 8 +- tools/configure.ac | 1 + tools/hotplug/FreeBSD/rc.d/xlpcid.in | 75 ++ tools/hotplug/Linux/init.d/xlpcid.in | 76 ++ tools/hotplug/Linux/systemd/Makefile | 1 + .../hotplug/Linux/systemd/xenpcid.service.in | 10 + tools/hotplug/NetBSD/rc.d/xlpcid.in | 75 ++ tools/include/libxl.h | 2 +- tools/include/pcid.h | 228 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_pci.c | 701 +++++------ tools/libs/light/libxl_pcid.c | 1095 +++++++++++++++++ tools/libs/light/libxl_types.idl | 2 + tools/libs/light/libxl_vchan.c | 64 +- tools/libs/light/libxl_vchan.h | 7 +- tools/libs/util/libxlu_pci.c | 6 +- tools/xl/Makefile | 4 +- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 7 + tools/xl/xl_parse.c | 1 + tools/xl/xl_pci.c | 4 +- tools/xl/xl_pcid.c | 81 ++ 23 files changed, 2070 insertions(+), 394 deletions(-) create mode 100644 tools/hotplug/FreeBSD/rc.d/xlpcid.in create mode 100644 tools/hotplug/Linux/init.d/xlpcid.in create mode 100644 tools/hotplug/Linux/systemd/xenpcid.service.in create mode 100644 tools/hotplug/NetBSD/rc.d/xlpcid.in create mode 100644 tools/include/pcid.h create mode 100644 tools/libs/light/libxl_pcid.c create mode 100644 tools/xl/xl_pcid.c diff --git a/docs/man/xl-pci-configuration.5.pod b/docs/man/xl-pci-configuration.5.pod index db3360307c..aacbd52c86 100644 --- a/docs/man/xl-pci-configuration.5.pod +++ b/docs/man/xl-pci-configuration.5.pod @@ -215,4 +215,18 @@ required to look up the B in the list of assignable devices. =back +=item B=I + +=over 4 + +=item Description + +This is domain name with pcid daemon running + +=item Default Value + +None. Domain name with pcid daemon selects automatically + +=back + =back diff --git a/tools/configure b/tools/configure index 45db3a5d5c..6124b2ab47 100755 --- a/tools/configure +++ b/tools/configure @@ -2452,7 +2452,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu -ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/xenstored/oxenstored.conf" +ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/FreeBSD/rc.d/xlpcid hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xlpcid hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain hotplug/NetBSD/rc.d/xlpcid ocaml/xenstored/oxenstored.conf" ac_config_headers="$ac_config_headers config.h" @@ -10053,7 +10053,7 @@ fi if test "x$systemd" = "xy"; then : - ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service" + ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service hotplug/Linux/systemd/xenpcid.service" fi @@ -10917,8 +10917,10 @@ do "../config/Tools.mk") CONFIG_FILES="$CONFIG_FILES ../config/Tools.mk" ;; "hotplug/FreeBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xencommons" ;; "hotplug/FreeBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xendriverdomain" ;; + "hotplug/FreeBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xlpcid" ;; "hotplug/Linux/init.d/sysconfig.xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xencommons" ;; "hotplug/Linux/init.d/sysconfig.xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xendomains" ;; + "hotplug/Linux/init.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xlpcid" ;; "hotplug/Linux/init.d/xen-watchdog") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xen-watchdog" ;; "hotplug/Linux/init.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xencommons" ;; "hotplug/Linux/init.d/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xendomains" ;; @@ -10929,6 +10931,7 @@ do "hotplug/Linux/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/xendomains" ;; "hotplug/NetBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xencommons" ;; "hotplug/NetBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xendriverdomain" ;; + "hotplug/NetBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xlpcid" ;; "ocaml/xenstored/oxenstored.conf") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/oxenstored.conf" ;; "config.h") CONFIG_HEADERS="$CONFIG_HEADERS config.h" ;; "hotplug/Linux/systemd/proc-xen.mount") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/proc-xen.mount" ;; @@ -10940,6 +10943,7 @@ do "hotplug/Linux/systemd/xendomains.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendomains.service" ;; "hotplug/Linux/systemd/xendriverdomain.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendriverdomain.service" ;; "hotplug/Linux/systemd/xenstored.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenstored.service" ;; + "hotplug/Linux/systemd/xenpcid.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenpcid.service" ;; *) as_fn_error $? "invalid argument: \`$ac_config_target'" "$LINENO" 5;; esac diff --git a/tools/configure.ac b/tools/configure.ac index f29c319b42..a874e96608 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -477,6 +477,7 @@ AS_IF([test "x$systemd" = "xy"], [ hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service + hotplug/Linux/systemd/xenpcid.service ]) ]) diff --git a/tools/hotplug/FreeBSD/rc.d/xlpcid.in b/tools/hotplug/FreeBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..2817bfaeed --- /dev/null +++ b/tools/hotplug/FreeBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/hotplug/Linux/init.d/xlpcid.in b/tools/hotplug/Linux/init.d/xlpcid.in new file mode 100644 index 0000000000..dce660098c --- /dev/null +++ b/tools/hotplug/Linux/init.d/xlpcid.in @@ -0,0 +1,76 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac + diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index a5d41d86ef..a3820e5f0a 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -13,6 +13,7 @@ XEN_SYSTEMD_SERVICE += xendomains.service XEN_SYSTEMD_SERVICE += xen-watchdog.service XEN_SYSTEMD_SERVICE += xen-init-dom0.service XEN_SYSTEMD_SERVICE += xendriverdomain.service +XEN_SYSTEMD_SERVICE += xenpcid.service ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \ $(XEN_SYSTEMD_MOUNT) \ diff --git a/tools/hotplug/Linux/systemd/xenpcid.service.in b/tools/hotplug/Linux/systemd/xenpcid.service.in new file mode 100644 index 0000000000..49c57f635a --- /dev/null +++ b/tools/hotplug/Linux/systemd/xenpcid.service.in @@ -0,0 +1,10 @@ +[Unit] +Description=Xen PCI host daemon +ConditionVirtualization=xen + +[Service] +Type=forking +ExecStart=@sbindir@/xl pcid + +[Install] +WantedBy=multi-user.target diff --git a/tools/hotplug/NetBSD/rc.d/xlpcid.in b/tools/hotplug/NetBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..2817bfaeed --- /dev/null +++ b/tools/hotplug/NetBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 310a3468a1..67ba46c78f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -2465,7 +2465,7 @@ int libxl_device_events_handler(libxl_ctx *ctx, */ int libxl_device_pci_assignable_add(libxl_ctx *ctx, libxl_device_pci *pci, int rebind); int libxl_device_pci_assignable_remove(libxl_ctx *ctx, libxl_device_pci *pci, int rebind); -libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num); +libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num, libxl_domid backend_domid); void libxl_device_pci_assignable_list_free(libxl_device_pci *list, int num); /* CPUID handling */ diff --git a/tools/include/pcid.h b/tools/include/pcid.h new file mode 100644 index 0000000000..2c1bd0727e --- /dev/null +++ b/tools/include/pcid.h @@ -0,0 +1,228 @@ +/* + Common definitions for Xen PCI client-server protocol. + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef PCID_H +#define PCID_H + +#define PCID_SRV_NAME "pcid" +#define PCID_XS_TOKEN "pcid-token" + +#define PCI_RECEIVE_BUFFER_SIZE 4096 +#define PCI_MAX_SIZE_RX_BUF MB(1) + +/* + ******************************************************************************* + * Common request and response structures used be the pcid remote protocol are + * described below. + ******************************************************************************* + * Request: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | cmd | string | String identifying the command | + * +-------------+--------------+----------------------------------------------+ + * + * Response: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | resp | string | Command string as in the request | + * +-------------+--------------+----------------------------------------------+ + * | error | string | "okay", "failed" | + * +-------------+--------------+----------------------------------------------+ + * | error_desc | string | Optional error description string | + * +-------------+--------------+----------------------------------------------+ + * + * Notes. + * 1. Every request and response must contain the above mandatory structures. + * 2. In case if a bad packet or an unknown command received by the server side + * a valid reply with the corresponding error code must be sent to the client. + * + * Requests and responses, which require SBDF as part of their payload, must + * use the following convention for encoding SBDF value: + * + * pci_device object: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | sbdf | string | SBDF string in form SSSS:BB:DD.F | + * +-------------+--------------+----------------------------------------------+ + */ + +#define PCID_MSG_FIELD_CMD "cmd" + +#define PCID_MSG_FIELD_RESP "resp" +#define PCID_MSG_FIELD_ERR "error" +#define PCID_MSG_FIELD_ERR_DESC "error_desc" + +/* pci_device object fields. */ +#define PCID_MSG_FIELD_SBDF "sbdf" + +#define PCID_MSG_ERR_OK "okay" +#define PCID_MSG_ERR_FAILED "failed" +#define PCID_MSG_ERR_NA "NA" + +#define PCID_SBDF_FMT "%04x:%02x:%02x.%01x" + +/* + ******************************************************************************* + * List assignable devices + * + * This command lists PCI devices that can be passed through to a guest domain. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "list_assignable". + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "list_assignable". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | devices | list | List of of pci_device objects | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_LIST_ASSIGNABLE "list_assignable" +#define PCID_MSG_FIELD_DEVICES "devices" + +/* + ******************************************************************************* + * Make device assignable + * + * This command makes given device assignable by ensuring that OS + * will not try to access it. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "make_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to save original driver name, + * so device later can be rebound back. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "make_assignable". + */ +#define PCID_CMD_MAKE_ASSIGNABLE "make_assignable" +#define PCID_MSG_FIELD_REBIND "rebind" + +/* + ******************************************************************************* + * Revert device from assignable state + * + * This command reverts effect of "make_assignable" command. Basically, + * now device can be used by OS again. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "revert_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to rebind device back to it's + * original driver, which name was saved by "make_assignable" command + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "revert_assignable". + */ +#define PCID_CMD_REVERT_ASSIGNABLE "revert_assignable" + +/* + ******************************************************************************* + * Check is device assigned + * + * This command checks device is assigned + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "is_device_assigned". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "is_device_assigned". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | result | bool | true if device assigned | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_IS_ASSIGNED "is_device_assigned" +#define PCID_MSG_FIELD_RESULT "result" + +/* + ******************************************************************************* + * Get device resources + * + * This command returns resource list of device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "resource_list". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "resource_list". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | resources | map | key 'iomem' - list of memory regions | + * | | | key 'irqs' - list of irqs | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_RESOURCE_LIST "resource_list" +/* Arguments */ +#define PCID_MSG_FIELD_DOMID "domid" +/* Result */ +#define PCID_MSG_FIELD_RESOURCES "resources" +#define PCID_RESULT_KEY_IOMEM "iomem" +#define PCID_RESULT_KEY_IRQS "irqs" + +/* + ******************************************************************************* + * Write BDF values to the pciback sysfs path + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "write_bdf". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "name" name of sysfs file of pciback driver + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "write_bdf". + */ +#define PCID_CMD_WRITE_BDF "write_bdf" +#define PCID_MSG_FIELD_NAME "name" + +/* + ******************************************************************************* + * Reset PCI device + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "reset_device". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "reset_device". + */ +#define PCID_CMD_RESET_DEVICE "reset_device" + +int libxl_pcid_process(libxl_ctx *ctx); + +#endif /* PCID_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index ea8994af6d..b64658e72f 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -77,6 +77,7 @@ SRCS-y += libxl.c SRCS-y += libxl_create.c SRCS-y += libxl_dm.c SRCS-y += libxl_pci.c +SRCS-y += libxl_pcid.c SRCS-y += libxl_vchan.c SRCS-y += libxl_dom.c SRCS-y += libxl_exec.c diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 4bbbfe9f16..3a2c4d57f7 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -18,6 +18,10 @@ #include "libxl_internal.h" +#include + +#include "libxl_vchan.h" + #define PCI_BDF "%04x:%02x:%02x.%01x" #define PCI_BDF_SHORT "%02x:%02x.%01x" #define PCI_BDF_VDEVFN "%04x:%02x:%02x.%01x@%02x" @@ -25,6 +29,161 @@ #define PCI_BDF_XSPATH "%04x-%02x-%02x-%01x" #define PCI_PT_QDEV_ID "pci-pt-%02x_%02x.%01x" +static int process_list_assignable(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_DEVICES, + response, JSON_ARRAY); + if (!*result) + return ERROR_INVAL; + + return 0; +} + +static int pci_handle_response(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + const libxl__json_object *command_obj; + const libxl__json_object *err_obj; + char *command_name; + int ret = 0; + + *result = NULL; + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_RESP, response, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad response. */ + return 0; + } + + err_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR, response, JSON_STRING); + if (!err_obj) { + /* Bad packet without error code field. */ + return 0; + } + + if (strcmp(err_obj->u.string, PCID_MSG_ERR_OK) != 0) { + const libxl__json_object *err_desc_obj; + + /* The response may contain an optional error string. */ + err_desc_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR_DESC, + response, JSON_STRING); + if (err_desc_obj) + LOG(ERROR, "%s", err_desc_obj->u.string); + else + LOG(ERROR, "%s", err_obj->u.string); + return ERROR_FAIL; + } + + command_name = command_obj->u.string; + LOG(DEBUG, "command: %s", command_name); + + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, response, result); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESULT, + response, JSON_BOOL); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESOURCES, + response, JSON_MAP); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + return ret; +} + +#define CONVERT_YAJL_GEN_TO_STATUS(gen) \ + ((gen) == yajl_gen_status_ok ? yajl_status_ok : yajl_status_error) + +static char *pci_prepare_request(libxl__gc *gc, yajl_gen gen, char *cmd, + libxl__json_object *args) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + yajl_status ret; + char *request = NULL; + int rc; + + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_open(gen)); + if (ret != yajl_status_ok) + return NULL; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_CMD, cmd); + if (rc) + return NULL; + + if (args) { + int idx = 0; + libxl__json_map_node *node = NULL; + + assert(args->type == JSON_MAP); + for (idx = 0; idx < args->u.map->count; idx++) { + if (flexarray_get(args->u.map, idx, (void**)&node) != 0) + break; + + ret = CONVERT_YAJL_GEN_TO_STATUS(libxl__yajl_gen_asciiz(gen, node->map_key)); + if (ret != yajl_status_ok) + return NULL; + ret = libxl__json_object_to_yajl_gen(gc, gen, node->obj); + if (ret != yajl_status_ok) + return NULL; + } + } + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_close(gen)); + if (ret != yajl_status_ok) + return NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + return NULL; + + request = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + + return request; +} + +static struct vchan_info *pci_vchan_get_client(libxl__gc *gc, libxl_domid backend_domid) +{ + static struct vchan_info *vchan = NULL; + + if (vchan) { + if (vchan->initialized) + return vchan; + } else { + vchan = libxl__zalloc(gc, sizeof(*vchan)); + } + vchan->state = vchan_new_client(gc, PCID_SRV_NAME, backend_domid); + if (!(vchan->state)) { + vchan = NULL; + goto out; + } + + vchan->handle_response = pci_handle_response; + vchan->prepare_request = pci_prepare_request; + vchan->receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + vchan->max_buf_size = PCI_MAX_SIZE_RX_BUF; + vchan->initialized = true; + +out: + return vchan; +} + +static void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan) +{ + vchan_fini_one(gc, vchan->state); + vchan->initialized = false; +} + static unsigned int pci_encode_bdf(libxl_device_pci *pci) { unsigned int value; @@ -359,33 +518,6 @@ static bool is_pci_in_array(libxl_device_pci *pcis, int num, return i < num; } -/* Write the standard BDF into the sysfs path given by sysfs_path. */ -static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, - libxl_device_pci *pci) -{ - int rc, fd; - char *buf; - - fd = open(sysfs_path, O_WRONLY); - if (fd < 0) { - LOGE(ERROR, "Couldn't open %s", sysfs_path); - return ERROR_FAIL; - } - - buf = GCSPRINTF(PCI_BDF, pci->domain, pci->bus, - pci->dev, pci->func); - rc = write(fd, buf, strlen(buf)); - /* Annoying to have two if's, but we need the errno */ - if (rc < 0) - LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); - close(fd); - - if (rc < 0) - return ERROR_FAIL; - - return 0; -} - #define PCI_INFO_PATH "/libxl/pci" static char *pci_info_xs_path(libxl__gc *gc, libxl_device_pci *pci, @@ -429,30 +561,33 @@ static void pci_info_xs_remove(libxl__gc *gc, libxl_device_pci *pci, xs_rm(ctx->xsh, XBT_NULL, path); } -libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) +libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num, libxl_domid backend_domid) { GC_INIT(ctx); libxl_device_pci *pcis = NULL, *new; - struct dirent *de; - DIR *dir; + struct vchan_info *vchan; + libxl__json_object *result, *dev_obj; + int i; *num = 0; - dir = opendir(SYSFS_PCIBACK_DRIVER); - if (NULL == dir) { - if (errno == ENOENT) { - LOG(ERROR, "Looks like pciback driver not loaded"); - } else { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER); - } + vchan = pci_vchan_get_client(gc, backend_domid); + if (!vchan) goto out; - } - while((de = readdir(dir))) { + result = vchan_send_command(gc, vchan, PCID_CMD_LIST_ASSIGNABLE, NULL); + if (!result) + goto vchan_free; + + for (i = 0; (dev_obj = libxl__json_array_get(result, i)); i++) { + const char *sbdf_str = libxl__json_object_get_string(dev_obj); unsigned int dom, bus, dev, func; - char *name; + const char *name; - if (sscanf(de->d_name, PCI_BDF, &dom, &bus, &dev, &func) != 4) + if (!sbdf_str) + continue; + + if (sscanf(sbdf_str, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) continue; new = realloc(pcis, ((*num) + 1) * sizeof(*new)); @@ -474,7 +609,9 @@ libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) (*num)++; } - closedir(dir); +vchan_free: + pci_vchan_free(gc, vchan); + out: GC_FREE; return pcis; @@ -490,44 +627,6 @@ void libxl_device_pci_assignable_list_free(libxl_device_pci *list, int num) free(list); } -/* Unbind device from its current driver, if any. If driver_path is non-NULL, - * store the path to the original driver in it. */ -static int sysfs_dev_unbind(libxl__gc *gc, libxl_device_pci *pci, - char **driver_path) -{ - char * spath, *dp = NULL; - struct stat st; - - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", - pci->domain, - pci->bus, - pci->dev, - pci->func); - if ( !lstat(spath, &st) ) { - /* Find the canonical path to the driver. */ - dp = libxl__zalloc(gc, PATH_MAX); - dp = realpath(spath, dp); - if ( !dp ) { - LOGE(ERROR, "realpath() failed"); - return -1; - } - - LOG(DEBUG, "Driver re-plug path: %s", dp); - - /* Unbind from the old driver */ - spath = GCSPRINTF("%s/unbind", dp); - if ( sysfs_write_bdf(gc, spath, pci) < 0 ) { - LOGE(ERROR, "Couldn't unbind device"); - return -1; - } - } - - if ( driver_path ) - *driver_path = dp; - - return 0; -} - static uint16_t sysfs_dev_get_vendor(libxl__gc *gc, libxl_device_pci *pci) { char *pci_device_vendor_path = @@ -639,116 +738,33 @@ bool libxl__is_igd_vga_passthru(libxl__gc *gc, return false; } -/* - * A brief comment about slots. I don't know what slots are for; however, - * I have by experimentation determined: - * - Before a device can be bound to pciback, its BDF must first be listed - * in pciback/slots - * - The way to get the BDF listed there is to write BDF to - * pciback/new_slot - * - Writing the same BDF to pciback/new_slot is not idempotent; it results - * in two entries of the BDF in pciback/slots - * It's not clear whether having two entries in pciback/slots is a problem - * or not. Just to be safe, this code does the conservative thing, and - * first checks to see if there is a slot, adding one only if one does not - * already exist. - */ - -/* Scan through /sys/.../pciback/slots looking for pci's BDF */ -static int pciback_dev_has_slot(libxl__gc *gc, libxl_device_pci *pci) -{ - FILE *f; - int rc = 0; - unsigned dom, bus, dev, func; - - f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); - - if (f == NULL) { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); - return ERROR_FAIL; - } - - while (fscanf(f, "%x:%x:%x.%d\n", &dom, &bus, &dev, &func) == 4) { - if (dom == pci->domain - && bus == pci->bus - && dev == pci->dev - && func == pci->func) { - rc = 1; - goto out; - } - } -out: - fclose(f); - return rc; -} - static int pciback_dev_is_assigned(libxl__gc *gc, libxl_device_pci *pci) { - char * spath; + struct vchan_info *vchan; int rc; - struct stat st; + libxl__json_object *args, *result; - if ( access(SYSFS_PCIBACK_DRIVER, F_OK) < 0 ) { - if ( errno == ENOENT ) { - LOG(ERROR, "Looks like pciback driver is not loaded"); - } else { - LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); - } - return -1; + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, - pci->domain, pci->bus, - pci->dev, pci->func); - rc = lstat(spath, &st); + args = libxl__vchan_start_args(gc); - if( rc == 0 ) - return 1; - if ( rc < 0 && errno == ENOENT ) - return 0; - LOGE(ERROR, "Accessing %s", spath); - return -1; -} - -static int pciback_dev_assign(libxl__gc *gc, libxl_device_pci *pci) -{ - int rc; + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); - if ( (rc = pciback_dev_has_slot(gc, pci)) < 0 ) { - LOGE(ERROR, "Error checking for pciback slot"); - return ERROR_FAIL; - } else if (rc == 0) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - } - - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - return 0; -} - -static int pciback_dev_unassign(libxl__gc *gc, libxl_device_pci *pci) -{ - /* Remove from pciback */ - if ( sysfs_dev_unbind(gc, pci, NULL) < 0 ) { - LOG(ERROR, "Couldn't unbind device!"); - return ERROR_FAIL; + result = vchan_send_command(gc, vchan, PCID_CMD_IS_ASSIGNED, args); + if (!result) { + rc = ERROR_FAIL; } + rc = result->u.b; + pci_vchan_free(gc, vchan); - /* Remove slot if necessary */ - if ( pciback_dev_has_slot(gc, pci) > 0 ) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't remove pciback slot"); - return ERROR_FAIL; - } - } - return 0; +out: + return rc; } static int libxl__device_pci_assignable_add(libxl__gc *gc, @@ -756,87 +772,29 @@ static int libxl__device_pci_assignable_add(libxl__gc *gc, int rebind) { libxl_ctx *ctx = libxl__gc_owner(gc); - unsigned dom, bus, dev, func; - char *spath, *driver_path = NULL; - const char *name; + struct vchan_info *vchan; int rc; - struct stat st; + libxl__json_object *args, *result; - /* Local copy for convenience */ - dom = pci->domain; - bus = pci->bus; - dev = pci->dev; - func = pci->func; - name = pci->name; - - /* Sanitise any name that is set */ - if (name) { - unsigned int i, n = strlen(name); - - if (n > 64) { /* Reasonable upper bound on name length */ - LOG(ERROR, "Name too long"); - return ERROR_FAIL; - } - - for (i = 0; i < n; i++) { - if (!isgraph(name[i])) { - LOG(ERROR, "Names may only include printable characters"); - return ERROR_FAIL; - } - } - } - - /* See if the device exists */ - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); - if ( lstat(spath, &st) ) { - LOGE(ERROR, "Couldn't lstat %s", spath); - return ERROR_FAIL; - } - - /* Check to see if it's already assigned to pciback */ - rc = pciback_dev_is_assigned(gc, pci); - if ( rc < 0 ) { - return ERROR_FAIL; - } - if ( rc ) { - LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); - goto name; + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Check to see if there's already a driver that we need to unbind from */ - if ( sysfs_dev_unbind(gc, pci, &driver_path ) ) { - LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", - dom, bus, dev, func); - return ERROR_FAIL; - } + args = libxl__vchan_start_args(gc); - /* Store driver_path for rebinding to dom0 */ - if ( rebind ) { - if ( driver_path ) { - pci_info_xs_write(gc, pci, "driver_path", driver_path); - } else if ( (driver_path = - pci_info_xs_read(gc, pci, "driver_path")) != NULL ) { - LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", - dom, bus, dev, func, driver_path); - } else { - LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", - dom, bus, dev, func); - } - } else { - pci_info_xs_remove(gc, pci, "driver_path"); - } + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_bool(gc, args, PCID_MSG_FIELD_REBIND, rebind); - if ( pciback_dev_assign(gc, pci) ) { - LOG(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; + result = vchan_send_command(gc, vchan, PCID_CMD_MAKE_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } -name: - if (name) - pci_info_xs_write(gc, pci, "name", name); - else - pci_info_xs_remove(gc, pci, "name"); - /* * DOMID_IO is just a sentinel domain, without any actual mappings, * so always pass XEN_DOMCTL_DEV_RDM_RELAXED to avoid assignment being @@ -844,12 +802,15 @@ name: */ rc = xc_assign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci), XEN_DOMCTL_DEV_RDM_RELAXED); - if ( rc < 0 ) { - LOG(ERROR, "failed to quarantine "PCI_BDF, dom, bus, dev, func); - return ERROR_FAIL; - } + if ( rc < 0 ) + LOG(ERROR, "failed to quarantine "PCI_BDF, pci->domain, pci->bus, + pci->dev, pci->func); - return 0; +vchan_free: + pci_vchan_free(gc, vchan); + +out: + return rc; } static int name2bdf(libxl__gc *gc, libxl_device_pci *pci) @@ -892,13 +853,8 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, { libxl_ctx *ctx = libxl__gc_owner(gc); int rc; - char *driver_path; - - /* If the device is named then we need to look up the BDF */ - if (pci->name) { - rc = name2bdf(gc, pci); - if (rc) return rc; - } + struct vchan_info *vchan; + libxl__json_object *args, *temp_obj, *result; /* De-quarantine */ rc = xc_deassign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci)); @@ -908,41 +864,43 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, return ERROR_FAIL; } - /* Unbind from pciback */ - if ( (rc = pciback_dev_is_assigned(gc, pci)) < 0 ) { - return ERROR_FAIL; - } else if ( rc ) { - pciback_dev_unassign(gc, pci); - } else { - LOG(WARN, "Not bound to pciback"); + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Rebind if necessary */ - driver_path = pci_info_xs_read(gc, pci, "driver_path"); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_STRING); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } + temp_obj->u.string = GCSPRINTF(PCID_SBDF_FMT, pci->domain, pci->bus, + pci->dev, pci->func); + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_SBDF, temp_obj); - if ( driver_path ) { - if ( rebind ) { - LOG(INFO, "Rebinding to driver at %s", driver_path); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_BOOL); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } - if ( sysfs_write_bdf(gc, - GCSPRINTF("%s/bind", driver_path), - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to %s", driver_path); - return -1; - } + temp_obj->u.b = rebind; + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_REBIND, temp_obj); - pci_info_xs_remove(gc, pci, "driver_path"); - } - } else { - if ( rebind ) { - LOG(WARN, - "Couldn't find path for original driver; not rebinding"); - } + result = vchan_send_command(gc, vchan, PCID_CMD_REVERT_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } - pci_info_xs_remove(gc, pci, "name"); +vchan_free: + pci_vchan_free(gc, vchan); - return 0; +out: + return rc; } int libxl_device_pci_assignable_add(libxl_ctx *ctx, libxl_device_pci *pci, @@ -1375,6 +1333,36 @@ static bool pci_supp_legacy_irq(void) #endif } +static int pciback_write_bdf(libxl__gc *gc, char *name, libxl_device_pci *pci) +{ + struct vchan_info *vchan; + int rc; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; + } + + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_NAME, name); + + result = vchan_send_command(gc, vchan, PCID_CMD_WRITE_BDF, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; + } +vchan_free: + pci_vchan_free(gc, vchan); +out: + return rc; +} + static void pci_add_dm_done(libxl__egc *egc, pci_add_state *pas, int rc) @@ -1382,41 +1370,51 @@ static void pci_add_dm_done(libxl__egc *egc, STATE_AO_GC(pas->aodev->ao); libxl_ctx *ctx = libxl__gc_owner(gc); libxl_domid domid = pas->pci_domid; - char *sysfs_path; - FILE *f; unsigned long long start, end, flags, size; int irq, i; int r; uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED; uint32_t domainid = domid; bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid); + struct vchan_info *vchan; + libxl__json_object *result; + libxl__json_object *args; + const libxl__json_object *value; + libxl__json_object *res_obj; + libxl_device_pci *pci = &pas->pci; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) + goto out; /* Convenience aliases */ bool starting = pas->starting; - libxl_device_pci *pci = &pas->pci; bool hvm = libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM; libxl__ev_qmp_dispose(gc, &pas->qmp); - if (rc) goto out; + args = libxl__vchan_start_args(gc); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_integer(gc, args, PCID_MSG_FIELD_DOMID, domid); + + result = vchan_send_command(gc, vchan, PCID_CMD_RESOURCE_LIST, args); + pci_vchan_free(gc, vchan); + if (!result) + goto out; + value = libxl__json_map_get(PCID_RESULT_KEY_IOMEM, result, JSON_ARRAY); /* stubdomain is always running by now, even at create time */ if (isstubdom) starting = false; - - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); start = end = flags = size = 0; irq = 0; - - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - rc = ERROR_FAIL; - goto out; - } for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { - if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + if ((res_obj = libxl__json_array_get(value, i)) == NULL) + continue; + const char *iomem_str = libxl__json_object_get_string(res_obj); + if (sscanf(iomem_str, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) continue; size = end - start + 1; if (start) { @@ -1426,7 +1424,6 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_ioport_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1437,29 +1434,21 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_iomem_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } } } } - fclose(f); if (!pci_supp_legacy_irq()) goto out_no_irq; - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - goto out_no_irq; - } - if ((fscanf(f, "%u", &irq) == 1) && irq) { + value = libxl__json_map_get(PCID_RESULT_KEY_IRQS, result, JSON_ARRAY); + if ((res_obj = libxl__json_array_get(value, i)) && + (irq = libxl__json_object_get_integer(res_obj))) { r = xc_physdev_map_pirq(ctx->xch, domid, irq, &irq); if (r < 0) { LOGED(ERROR, domainid, "xc_physdev_map_pirq irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1467,17 +1456,14 @@ static void pci_add_dm_done(libxl__egc *egc, if (r < 0) { LOGED(ERROR, domainid, "xc_domain_irq_permission irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } } - fclose(f); /* Don't restrict writes to the PCI config space from this VM */ if (pci->permissive) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/permissive", - pci) < 0 ) { + if (pciback_write_bdf(gc, "permissive", pci)) { LOGD(ERROR, domainid, "Setting permissive for device"); rc = ERROR_FAIL; goto out; @@ -1510,41 +1496,28 @@ out: pas->callback(egc, pas, rc); } -static int libxl__device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, - unsigned int dev, unsigned int func) -{ - char *reset; - int fd, rc; - - reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); - rc = write(fd, buf, strlen(buf)); - if (rc < 0) - LOGD(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno != ENOENT) - LOGED(ERROR, domain, "Failed to access pciback path %s", reset); - reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - rc = write(fd, "1", 1); - if (rc < 0) - LOGED(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno == ENOENT) { - LOGD(ERROR, domain, - "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, - domain, bus, dev, func); - } else { - LOGED(ERROR, domain, "Failed to access reset path %s", reset); +static int libxl__device_pci_reset(libxl__gc *gc, libxl_device_pci *pci) +{ + struct vchan_info *vchan; + int rc = 0; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - return -1; + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, pci->bus, pci->dev, pci->func)); + result = vchan_send_command(gc, vchan, PCID_CMD_RESET_DEVICE, args); + if (!result) + rc = ERROR_FAIL; + pci_vchan_free(gc, vchan); + + out: + return rc; } int libxl__device_pci_setdefault(libxl__gc *gc, uint32_t domid, @@ -1578,7 +1551,7 @@ static bool libxl_pci_assignable(libxl_ctx *ctx, libxl_device_pci *pci) int num; bool assignable; - pcis = libxl_device_pci_assignable_list(ctx, &num); + pcis = libxl_device_pci_assignable_list(ctx, &num, pci->backend_domid); assignable = is_pci_in_array(pcis, num, pci); libxl_device_pci_assignable_list_free(pcis, num); @@ -1594,6 +1567,12 @@ static void device_pci_add_stubdom_done(libxl__egc *egc, static void device_pci_add_done(libxl__egc *egc, pci_add_state *, int rc); +static void device_pci_get_backend_domd(libxl__gc *gc, libxl_device_pci *pci) +{ + if (pci->backend == NULL || libxl__resolve_domid(gc, pci->backend, &pci->backend_domid)) + pci->backend_domid = DOMID_INVALID; +} + void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, libxl_device_pci *pci, bool starting, libxl__ao_device *aodev) @@ -1620,6 +1599,8 @@ void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, pas->starting = starting; pas->callback = device_pci_add_stubdom_done; + device_pci_get_backend_domd(gc, pci); + if (libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { rc = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci)); if (rc) { @@ -1651,7 +1632,7 @@ void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, rc = pci_info_xs_write(gc, pci, "domid", GCSPRINTF("%u", domid)); if (rc) goto out; - libxl__device_pci_reset(gc, pci->domain, pci->bus, pci->dev, pci->func); + libxl__device_pci_reset(gc, pci); stubdomid = libxl_get_stubdom_id(ctx, domid); if (stubdomid != 0) { @@ -2216,7 +2197,7 @@ static void pci_remove_detached(libxl__egc *egc, /* don't do multiple resets while some functions are still passed through */ if ((pci->vdevfn & 0x7) == 0) { - libxl__device_pci_reset(gc, pci->domain, pci->bus, pci->dev, pci->func); + libxl__device_pci_reset(gc, pci); } if (!isstubdom) { diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c new file mode 100644 index 0000000000..d4a817dc6f --- /dev/null +++ b/tools/libs/light/libxl_pcid.c @@ -0,0 +1,1095 @@ +/* + Utils for xl pcid daemon + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#include +#include + +#include + +#include +#include +#include + +#include +#include + +#define DOM0_ID 0 + +#define PCI_BDF "%04x:%02x:%02x.%01x" + +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func); + +struct vchan_client { + XEN_LIST_ENTRY(struct vchan_client) list; + + /* This is the watch entry fired for this client. */ + char **watch_ret; + /* Length of the watch_ret[XS_WATCH_PATH]. */ + size_t watch_len; + + struct vchan_info info; + + /* + * This context is used by the processing loop to create its own gc + * and use it while processing commands, so we do not get OOM. + */ + libxl_ctx *ctx; + /* This gc holds all allocations made for the client needs itself. */ + libxl__gc gc[1]; + pthread_t run_thread; +}; + +static XEN_LIST_HEAD(clients_list, struct vchan_client) vchan_clients; + +static pthread_mutex_t vchan_client_mutex; + +static int make_error_reply(libxl__gc *gc, yajl_gen gen, char *desc, + char *command_name) +{ + int rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_FAILED); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR_DESC, desc); + if (rc) + return rc; + + return 0; +} + +static int process_list_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct dirent *de; + DIR *dir = NULL; + + dir = opendir(SYSFS_PCI_DEV); + if (dir == NULL) { + make_error_reply(gc, gen, strerror(errno), command_name); + return ERROR_FAIL; + } + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_DEVICES); + + *response = libxl__json_object_alloc(gc, JSON_ARRAY); + + while ((de = readdir(dir))) { + unsigned int dom, bus, dev, func; + + if (sscanf(de->d_name, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) + continue; + + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + node->u.string = de->d_name; + flexarray_append((*response)->u.array, node); + } + + closedir(dir); + + return 0; +} + +static bool pci_supp_legacy_irq(void) +{ +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ + return true; +#else + return false; +#endif +} + +static int process_list_resources(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct libxl__json_object *iomem = + libxl__json_object_alloc(gc, JSON_ARRAY); + struct libxl__json_object *irqs = + libxl__json_object_alloc(gc, JSON_ARRAY); + const struct libxl__json_object *json_sdbf; + const struct libxl__json_object *json_domid; + unsigned int dom, bus, dev, func; + libxl_domid domainid; + char *sysfs_path; + FILE *f; + unsigned long long start, end, flags; + int irq, i; + int rc = 0; + libxl__json_map_node *map_node = NULL; + + json_sdbf = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_sdbf) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + if (sscanf(libxl__json_object_get_string(json_sdbf), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_domid = libxl__json_map_get(PCID_MSG_FIELD_DOMID, request, JSON_INTEGER); + if (!json_domid) { + make_error_reply(gc, gen, "No mandatory parameter 'domid'", command_name); + return ERROR_FAIL; + } + domainid = libxl__json_object_get_integer(json_domid); + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESOURCES); + *response = libxl__json_object_alloc(gc, JSON_MAP); + + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + start = 0; + irq = 0; + + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + rc = ERROR_FAIL; + goto out; + } + for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { + if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + continue; + if (start) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + + node->u.string = GCSPRINTF("0x%llx 0x%llx 0x%llx", start, end, flags); + flexarray_append(iomem->u.array, node); + } + } + fclose(f); + if (!pci_supp_legacy_irq()) + goto out_no_irq; + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + goto out_no_irq; + } + if ((fscanf(f, "%u", &irq) == 1) && irq) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_INTEGER); + + node->u.i = irq; + flexarray_append(irqs->u.array, node); + } + fclose(f); + + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IRQS); + map_node->obj = irqs; + flexarray_append((*response)->u.map, map_node); +out_no_irq: + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IOMEM); + map_node->obj = iomem; + flexarray_append((*response)->u.map, map_node); + rc = 0; +out: + return rc; +} + +static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + char * spath; + int rc; + struct stat st; + + if (access(SYSFS_PCIBACK_DRIVER, F_OK) < 0) { + if (errno == ENOENT) { + LOG(ERROR, "Looks like pciback driver is not loaded"); + } else { + LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); + } + return -1; + } + + spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, + domain, bus, dev, func); + rc = lstat(spath, &st); + + if (rc == 0) + return 1; + if (rc < 0 && errno == ENOENT) + return 0; + LOGE(ERROR, "Accessing %s", spath); + return 0; +} + +static int process_pciback_write_bdf(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc = 0; + const char *name; + char *spath; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_NAME, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + name = libxl__json_object_get_string(json_o); + spath = GCSPRINTF("%s/%s", SYSFS_PCIBACK_DRIVER, name); + LOG(WARN, "sysf_write_bdf(%s, %d, %d, %d, %d)", spath, dom, bus, dev,func); + return rc; +} + +#define PCID_INFO_PATH "pcid" +#define PCID_BDF_XSPATH "%04x-%02x-%02x-%01x" + +static char *pcid_info_xs_path(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + return node ? + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH"/%s", + domain, bus, dev, func, node) : + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH, + domain, bus, dev, func); +} + + +static int pcid_info_xs_write(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node, + const char *val) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + int rc = libxl__xs_printf(gc, XBT_NULL, path, "%s", val); + + if (rc) LOGE(WARN, "Write of %s to node %s failed.", val, path); + + return rc; +} + +static char *pcid_info_xs_read(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + + return libxl__xs_read(gc, XBT_NULL, path); +} + +static void pcid_info_xs_remove(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + libxl_ctx *ctx = libxl__gc_owner(gc); + + /* Remove the xenstore entry */ + xs_rm(ctx->xsh, XBT_NULL, path); +} + + +/* Write the standard BDF into the sysfs path given by sysfs_path. */ +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + int rc, fd; + char *buf; + + fd = open(sysfs_path, O_WRONLY); + if (fd < 0) { + LOGE(ERROR, "Couldn't open %s", sysfs_path); + return ERROR_FAIL; + } + + buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + /* Annoying to have two if's, but we need the errno */ + if (rc < 0) + LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); + close(fd); + + if (rc < 0) + return ERROR_FAIL; + + return 0; +} + + +/* Unbind device from its current driver, if any. If driver_path is non-NULL, + * store the path to the original driver in it. */ +static int sysfs_dev_unbind(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, + char **driver_path) +{ + char * spath, *dp = NULL; + struct stat st; + + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", + domain, bus, dev, func); + if (!lstat(spath, &st)) { + /* Find the canonical path to the driver. */ + dp = libxl__zalloc(gc, PATH_MAX); + dp = realpath(spath, dp); + if ( !dp ) { + LOGE(ERROR, "realpath() failed"); + return -1; + } + + LOG(DEBUG, "Driver re-plug path: %s", dp); + + /* Unbind from the old driver */ + spath = GCSPRINTF("%s/unbind", dp); + if (sysfs_write_bdf(gc, spath, domain, bus, dev, func) < 0) { + LOGE(ERROR, "Couldn't unbind device"); + return -1; + } + } + + if (driver_path) + *driver_path = dp; + + return 0; +} + +/* + * A brief comment about slots. I don't know what slots are for; however, + * I have by experimentation determined: + * - Before a device can be bound to pciback, its BDF must first be listed + * in pciback/slots + * - The way to get the BDF listed there is to write BDF to + * pciback/new_slot + * - Writing the same BDF to pciback/new_slot is not idempotent; it results + * in two entries of the BDF in pciback/slots + * It's not clear whether having two entries in pciback/slots is a problem + * or not. Just to be safe, this code does the conservative thing, and + * first checks to see if there is a slot, adding one only if one does not + * already exist. + */ + +/* Scan through /sys/.../pciback/slots looking for pci's BDF */ +static int pciback_dev_has_slot(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + FILE *f; + int rc = 0; + unsigned s_domain, s_bus, s_dev, s_func; + + f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); + + if (f == NULL) { + LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); + return ERROR_FAIL; + } + + while (fscanf(f, "%x:%x:%x.%d\n", + &s_domain, &s_bus, &s_dev, &s_func) == 4) { + if (s_domain == domain && + s_bus == bus && + s_dev == dev && + s_func == func) { + rc = 1; + goto out; + } + } +out: + fclose(f); + return rc; +} + +static int pciback_dev_assign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + int rc; + + if ( (rc = pciback_dev_has_slot(gc, domain, bus, dev, func)) < 0 ) { + LOGE(ERROR, "Error checking for pciback slot"); + return ERROR_FAIL; + } else if (rc == 0) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + } + + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + return 0; +} + +static int process_pciback_dev_is_assigned(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESULT); + *response = libxl__json_object_alloc(gc, JSON_BOOL); + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + (*response)->u.b = rc; + return 0; +} + +static int device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + char *reset; + int fd, rc; + + reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + if (rc < 0) + LOGD(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno != ENOENT) + LOGED(ERROR, domain, "Failed to access pciback path %s", reset); + reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + rc = write(fd, "1", 1); + if (rc < 0) + LOGED(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno == ENOENT) { + LOGD(ERROR, domain, + "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, + domain, bus, dev, func); + } else { + LOGED(ERROR, domain, "Failed to access reset path %s", reset); + } + return -1; +} + +static int process_device_pci_reset(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = device_pci_reset(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + return rc; +} + +static int process_make_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct stat st; + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *spath, *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* See if the device exists */ + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); + if ( lstat(spath, &st) ) { + make_error_reply(gc, gen, strerror(errno), command_name); + LOGE(ERROR, "Couldn't lstat %s", spath); + return ERROR_FAIL; + } + + /* Check to see if it's already assigned to pciback */ + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) { + make_error_reply(gc, gen, "Can't check if device is assigned", + command_name); + return ERROR_FAIL; + } + if (rc) { + LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); + goto done; + } + + /* Check to see if there's already a driver that we need to unbind from */ + if (sysfs_dev_unbind(gc, dom, bus, dev, func, &driver_path)) { + LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", + dom, bus, dev, func); + return ERROR_FAIL; + } + + /* Store driver_path for rebinding back */ + if (rebind) { + if (driver_path) { + pcid_info_xs_write(gc, dom, bus, dev, func, "driver_path", + driver_path); + } else if ( (driver_path = + pcid_info_xs_read(gc, dom, bus, dev, func, + "driver_path")) != NULL ) { + LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", + dom, bus, dev, func, driver_path); + } else { + LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", + dom, bus, dev, func); + } + } else { + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + + if (pciback_dev_assign(gc, dom, bus, dev, func)) { + LOG(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + +done: + return 0; +} + +static int pciback_dev_unassign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + /* Remove from pciback */ + if ( sysfs_dev_unbind(gc, domain, bus, dev, func, NULL) < 0 ) { + LOG(ERROR, "Couldn't unbind device!"); + return ERROR_FAIL; + } + + /* Remove slot if necessary */ + if ( pciback_dev_has_slot(gc, domain, bus, dev, func) > 0 ) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't remove pciback slot"); + return ERROR_FAIL; + } + } + return 0; +} + +static int process_revert_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* Unbind from pciback */ + if ( (rc = pciback_dev_is_assigned(gc, dom, bus, dev, func)) < 0 ) { + make_error_reply(gc, gen, "Can't unbind from pciback", command_name); + return ERROR_FAIL; + } else if ( rc ) { + pciback_dev_unassign(gc, dom, bus, dev, func); + } else { + LOG(WARN, "Not bound to pciback"); + } + + /* Rebind if necessary */ + driver_path = pcid_info_xs_read(gc, dom, bus, dev, func, "driver_path"); + + if ( driver_path ) { + if ( rebind ) { + LOG(INFO, "Rebinding to driver at %s", driver_path); + + if ( sysfs_write_bdf(gc, + GCSPRINTF("%s/bind", driver_path), + dom, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to %s", driver_path); + return -1; + } + + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + } else { + if ( rebind ) { + LOG(WARN, + "Couldn't find path for original driver; not rebinding"); + } + } + + return 0; +} + +static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request) +{ + const libxl__json_object *command_obj; + libxl__json_object *command_response = NULL; + char *command_name; + int ret = 0; + + yajl_gen_map_open(gen); + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_CMD, request, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad request. */ + ret = make_error_reply(gc, gen, "Unsupported request or bad packet", + PCID_MSG_ERR_NA); + goto out; + } + + command_name = command_obj->u.string; + + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + ret = process_make_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + ret = process_revert_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + ret = process_pciback_dev_is_assigned(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + ret = process_device_pci_reset(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + ret = process_list_resources(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + ret = process_pciback_write_bdf(gc, gen, command_name, + request, &command_response); + else { + /* + * This is an unsupported command: make a reply and proceed over + * the error path. + */ + ret = make_error_reply(gc, gen, "Unsupported command", + command_name); + if (!ret) + ret = ERROR_NOTFOUND; + } + + if (ret) { + /* + * The command handler on error must provide a valid response, + * so we don't need to add any other field below. + */ + ret = 0; + goto out; + } + + if (command_response) { + ret = libxl__json_object_to_yajl_gen(gc, gen, command_response); + if (ret) + goto out; + } + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (ret) + goto out; + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_OK); +out: + yajl_gen_map_close(gen); + + vchan_dump_gen(gc, gen); + + return ret; +} + +static char *pcid_prepare_response(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + char *reply = NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + goto out; + + reply = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + +out: + return reply; +} + +static void server_fini_one(libxl__gc *gc, struct vchan_client *client) +{ + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_REMOVE(client, list); + pthread_mutex_unlock(&vchan_client_mutex); + + GC_FREE; + free(client); +} + +static void *client_thread(void *arg) +{ + struct vchan_client *client = arg; + + while (true) { + int ret; + /* + * libvchan uses garbage collector for processing requests, + * so we create a new one each time we process a packet and + * dispose it right away to prevent OOM. + */ + GC_INIT(client->ctx); + ret = vchan_process_command(gc, &client->info); + GC_FREE; + + if ((ret == ERROR_NOTFOUND) || (ret == ERROR_INVAL)) + continue; + if (ret < 0) + break; + } + vchan_fini_one(client->gc, client->info.state); + server_fini_one(client->gc, client); + return NULL; +} + +#define DEFAULT_THREAD_STACKSIZE (24 * 1024) +/* NetBSD doesn't have PTHREAD_STACK_MIN. */ +#ifndef PTHREAD_STACK_MIN +#define PTHREAD_STACK_MIN 0 +#endif + +#define READ_THREAD_STACKSIZE \ + ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ? \ + PTHREAD_STACK_MIN : DEFAULT_THREAD_STACKSIZE) + +static bool init_client_thread(libxl__gc *gc, struct vchan_client *new_client) +{ + + sigset_t set, old_set; + pthread_attr_t attr; + static size_t stack_size; +#ifdef USE_DLSYM + size_t (*getsz)(pthread_attr_t *attr); +#endif + + if (pthread_attr_init(&attr) != 0) + return false; + if (!stack_size) { +#ifdef USE_DLSYM + getsz = dlsym(RTLD_DEFAULT, "__pthread_get_minstack"); + if (getsz) + stack_size = getsz(&attr); +#endif + if (stack_size < READ_THREAD_STACKSIZE) + stack_size = READ_THREAD_STACKSIZE; + } + if (pthread_attr_setstacksize(&attr, stack_size) != 0) { + pthread_attr_destroy(&attr); + return false; + } + + sigfillset(&set); + pthread_sigmask(SIG_SETMASK, &set, &old_set); + + if (pthread_create(&new_client->run_thread, &attr, client_thread, + new_client) != 0) { + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + return false; + } + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + + return true; +} + +static void init_new_client(libxl_ctx *ctx, libxl__gc *gc, + struct clients_list *list, char **watch_ret) +{ + struct vchan_client *new_client; + char *xs_path = watch_ret[XS_WATCH_PATH]; + + LOG(DEBUG, "New client at \"%s\"", xs_path); + + new_client = malloc(sizeof(*new_client)); + if (!new_client) { + LOGE(ERROR, "Failed to allocate new client at \"%s\"", xs_path); + return; + } + + memset(new_client, 0, sizeof(*new_client)); + + new_client->watch_ret = watch_ret; + new_client->watch_len = strlen(xs_path); + new_client->ctx = ctx; + /* + * Remember the GC of this client, so we can dispose its memory. + * Use it from now on. + */ + LIBXL_INIT_GC(new_client->gc[0], ctx); + + new_client->info.state = vchan_init_new_state(new_client->gc, DOM0_ID, + xs_path, true); + if (!(new_client->info.state)) { + LOGE(ERROR, "Failed to add new client at \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + new_client->info.handle_request = pcid_handle_request; + new_client->info.prepare_response = pcid_prepare_response; + new_client->info.receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + new_client->info.max_buf_size = PCI_MAX_SIZE_RX_BUF; + + if (!init_client_thread(new_client->gc, new_client)) { + LOGE(ERROR, "Failed to create client's thread for \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_INSERT_HEAD(&vchan_clients, new_client, list); + pthread_mutex_unlock(&vchan_client_mutex); +} + +static void terminate_clients(void) +{ + struct vchan_client *client; + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + pthread_join(client->run_thread, NULL); + } + pthread_mutex_unlock(&vchan_client_mutex); +} + +int libxl_pcid_process(libxl_ctx *ctx) +{ + GC_INIT(ctx); + char *xs_path, *str; + char **watch_ret; + unsigned int watch_num; + libxl_domid domid; + int ret; + + pthread_mutex_init(&vchan_client_mutex, NULL); + + str = xs_read(ctx->xsh, 0, "domid", NULL); + if (!str) { + LOGE(ERROR, "Can't read own domid\n"); + ret = -ENOENT; + goto out; + } + + ret = sscanf(str, "%d", &domid); + free(str); + if (ret != 1) + { + LOGE(ERROR, "Own domid is not an integer\n"); + ret = -EINVAL; + goto out; + } + + xs_path = vchan_get_server_xs_path(gc, domid, PCID_SRV_NAME); + + /* Recreate the base folder: remove all leftovers. */ + ret = libxl__xs_rm_checked(gc, XBT_NULL, xs_path); + if (ret) + goto out; + + if (!xs_mkdir(CTX->xsh, XBT_NULL, xs_path)) + { + LOGE(ERROR, "xenstore mkdir failed: `%s'", xs_path); + ret = ERROR_FAIL; + goto out; + } + + /* Wait for vchan client to create a new UUID under the server's folder. */ + if (!xs_watch(CTX->xsh, xs_path, PCID_XS_TOKEN)) { + LOGE(ERROR, "xs_watch (%s) failed", xs_path); + ret = ERROR_FAIL; + goto out; + } + + while ((watch_ret = xs_read_watch(CTX->xsh, &watch_num))) { + struct vchan_client *client; + size_t len; + bool found; + + /* + * Any change under the base directory will fire an event, so we need + * to filter if this is indeed a new client or it is because vchan + * server creates nodes under its UUID. + * + * Never try to instantiate a vchan server right under xs_path. + */ + if (!strcmp(watch_ret[XS_WATCH_PATH], xs_path)) + continue; + + found = false; + len = strlen(watch_ret[XS_WATCH_PATH]); + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + str = client->watch_ret[XS_WATCH_PATH]; + + if (strstr(watch_ret[XS_WATCH_PATH], str)) { + /* + * Base path is a substring of the current path, so it can be: + * - a new node with different name, but starting with str + * - a subnode under str, so it will have '/' after str + * - same string + */ + if (len == client->watch_len) { + found = true; + break; + } + if (len > client->watch_len) { + if (watch_ret[XS_WATCH_PATH][client->watch_len] == '/') { + found = true; + break; + } + } + } + } + pthread_mutex_unlock(&vchan_client_mutex); + + if (!found) + init_new_client(ctx, gc, &vchan_clients, watch_ret); + } + + xs_unwatch(CTX->xsh, xs_path, PCID_XS_TOKEN); + +out: + terminate_clients(); + GC_FREE; + pthread_mutex_destroy(&vchan_client_mutex); + return ret; +} diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index f387d7b8b2..458acc0748 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -802,6 +802,8 @@ libxl_device_pci = Struct("device_pci", [ ("seize", bool), ("rdm_policy", libxl_rdm_reserve_policy), ("name", string), + ("backend", string), + ("backend_domid", libxl_domid), ]) libxl_device_rdm = Struct("device_rdm", [ diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c index c87024f00f..512b6b6641 100644 --- a/tools/libs/light/libxl_vchan.c +++ b/tools/libs/light/libxl_vchan.c @@ -99,6 +99,14 @@ void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, obj->u.b = val; } +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_INTEGER, args, key); + + obj->u.i = val; +} + static void reset_yajl_generator(struct vchan_state *state) { yajl_gen_clear(state->gen); @@ -297,34 +305,41 @@ int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan) return vchan_write(gc, vchan->state, VCHAN_EOM); } -static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file) +static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file, libxl_domid backend_domid) { - char **domains; - unsigned int i, n; - libxl_domid domid = DOMID_INVALID; + const char *tmp; - domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); - if (!n) - goto out; + if (backend_domid == DOMID_INVALID) { + char **domains; + unsigned int i, n; - for (i = 0; i < n; i++) { - const char *tmp; - int d; + domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); + if (!n) + goto out; - if (sscanf(domains[i], "%d", &d) != 1) - continue; + for (i = 0; i < n; i++) { + int d; - tmp = libxl__xs_read(gc, XBT_NULL, - GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); - /* Found the domain where the server lives. */ - if (tmp) { - domid = d; - break; + if (sscanf(domains[i], "%d", &d) != 1) + continue; + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); + /* Found the domain where the server lives. */ + if (tmp) { + backend_domid = d; + break; + } } + } else { + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, backend_domid, xs_file)); + if (!tmp) + backend_domid = DOMID_INVALID; } out: - return domid; + return backend_domid; } static int vchan_init_client(libxl__gc *gc, struct vchan_state *state, @@ -440,20 +455,19 @@ static int vchan_wait_server_available(libxl__gc *gc, const char *xs_path) return ERROR_TIMEDOUT; } -struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name, libxl_domid backend_domid) { - libxl_domid domid; char *xs_path, *vchan_xs_path; libxl_uuid uuid; libxl_ctx *ctx = libxl__gc_owner(gc); - domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name); - if (domid == DOMID_INVALID) { + backend_domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name, backend_domid); + if (backend_domid == DOMID_INVALID) { LOGE(ERROR, "Can't find vchan server"); return NULL; } - xs_path = vchan_get_server_xs_path(gc, domid, srv_name); + xs_path = vchan_get_server_xs_path(gc, backend_domid, srv_name); LOG(DEBUG, "vchan server at %s\n", xs_path); /* Generate unique client id. */ @@ -473,7 +487,7 @@ struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) return NULL; } - return vchan_init_new_state(gc, domid, vchan_xs_path, false); + return vchan_init_new_state(gc, backend_domid, vchan_xs_path, false); } void vchan_fini_one(libxl__gc *gc, struct vchan_state *state) diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h index 0968875298..e16db7a6ed 100644 --- a/tools/libs/light/libxl_vchan.h +++ b/tools/libs/light/libxl_vchan.h @@ -45,6 +45,7 @@ struct vchan_info { /* Buffer info. */ size_t receive_buf_size; size_t max_buf_size; + bool initialized; }; int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen hand, @@ -58,7 +59,9 @@ static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, char *key, char *val); void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, - char *key, bool val); + char *key, bool val); +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val); libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, char *cmd, libxl__json_object *args); @@ -72,7 +75,7 @@ char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name) struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, char *vchan_xs_path, bool is_server); -struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name); +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name, libxl_domid domid); void vchan_fini_one(libxl__gc *gc, struct vchan_state *state); diff --git a/tools/libs/util/libxlu_pci.c b/tools/libs/util/libxlu_pci.c index 551d8e3aed..7e2e8c6a6f 100644 --- a/tools/libs/util/libxlu_pci.c +++ b/tools/libs/util/libxlu_pci.c @@ -1,6 +1,8 @@ #define _GNU_SOURCE #include +#include +#include #include "libxlu_internal.h" #include "libxlu_disk_l.h" @@ -195,8 +197,10 @@ int xlu_pci_parse_spec_string(XLU_Config *cfg, libxl_device_pci *pci, name_present = true; pci->name = strdup(val); if (!pci->name) ret = ERROR_NOMEM; + } else if (!strcmp(key, "backend")) { + pci->backend = strdup(val); } else { - XLU__PCI_ERR(cfg, "Unknown PCI_SPEC_STRING option: %s", key); + XLU__PCI_ERR(cfg, "Unknown PCI_SPEC_STRING option: '%s'\n", key); ret = ERROR_INVAL; } diff --git a/tools/xl/Makefile b/tools/xl/Makefile index 5dfff7fc6f..0dbbbde17f 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -22,7 +22,7 @@ XL_OBJS = xl.o xl_cmdtable.o xl_sxp.o xl_utils.o $(XL_OBJS-y) XL_OBJS += xl_parse.o xl_cpupool.o xl_flask.o XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o -XL_OBJS += xl_info.o xl_console.o xl_misc.o +XL_OBJS += xl_info.o xl_console.o xl_misc.o xl_pcid.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o @@ -34,7 +34,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenstore) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd..1419a8c1e4 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -202,6 +202,7 @@ int main_loadpolicy(int argc, char **argv); int main_remus(int argc, char **argv); #endif int main_devd(int argc, char **argv); +int main_pcid(int argc, char **argv); #if defined(__i386__) || defined(__x86_64__) int main_psr_hwinfo(int argc, char **argv); int main_psr_cmt_attach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d488..5fbbe25a43 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -545,6 +545,13 @@ const struct cmd_spec cmd_table[] = { "-F Run in the foreground.\n" "-p, --pidfile [FILE] Write PID to pidfile when daemonizing.", }, + { "pcid", + &main_pcid, 0, 1, + "Daemon that acts as a server for the client in the libxl PCI", + "[options]", + "-f Run in the foreground.\n" + "-p, --pidfile [FILE] Write PID to pidfile when daemonizing.", + }, #if defined(__i386__) || defined(__x86_64__) { "psr-hwinfo", &main_psr_hwinfo, 0, 1, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index c8d2b794e5..5052ad9fe4 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1491,6 +1491,7 @@ void parse_config_data(const char *config_source, pci->power_mgmt = pci_power_mgmt; pci->permissive = pci_permissive; pci->seize = pci_seize; + pci->backend = NULL; /* * Like other pci option, the per-device policy always follows * the global policy by default. diff --git a/tools/xl/xl_pci.c b/tools/xl/xl_pci.c index b1c3ae2a72..a1c0bc1e17 100644 --- a/tools/xl/xl_pci.c +++ b/tools/xl/xl_pci.c @@ -13,7 +13,9 @@ */ #include +#include +#include #include #include #include @@ -156,7 +158,7 @@ static void pciassignable_list(bool show_names) libxl_device_pci *pcis; int num, i; - pcis = libxl_device_pci_assignable_list(ctx, &num); + pcis = libxl_device_pci_assignable_list(ctx, &num, DOMID_INVALID); if ( pcis == NULL ) return; diff --git a/tools/xl/xl_pcid.c b/tools/xl/xl_pcid.c new file mode 100644 index 0000000000..a5d38e672f --- /dev/null +++ b/tools/xl/xl_pcid.c @@ -0,0 +1,81 @@ +/* + Pcid daemon that acts as a server for the client in the libxl PCI + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +#include +#include +#include +#include +#include +#include + +#include +#include + +/* + * TODO: Running this code in multi-threaded environment + * Now the code is designed so that only one request to the server + * from the client is made in one domain. In the future, it is necessary + * to take into account cases when from different domains there can be + * several requests from a client at the same time. Therefore, it will be + * necessary to regulate the multithreading of processes for global variables. + */ + +int main_pcid(int argc, char *argv[]) +{ + int opt = 0, daemonize = 1, ret; + const char *pidfile = NULL; + static const struct option opts[] = { + {"pidfile", 1, 0, 'p'}, + COMMON_LONG_OPTS, + {0, 0, 0, 0} + }; + + SWITCH_FOREACH_OPT(opt, "fp:", opts, "pcid", 0) { + case 'f': + daemonize = 0; + break; + case 'p': + pidfile = optarg; + break; + } + + if (daemonize) { + ret = do_daemonize("xlpcid", pidfile); + if (ret) { + ret = (ret == 1) ? 0 : ret; + goto out_daemon; + } + } + + libxl_pcid_process(ctx); + + ret = 0; + +out_daemon: + exit(ret); +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 09 13:11:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 13:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363868.594526 (Exim 4.92) (envelope-from ) id 1oAAF4-0006gO-Qp; Sat, 09 Jul 2022 13:11:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363868.594526; Sat, 09 Jul 2022 13:11:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAAF4-0006gH-NS; Sat, 09 Jul 2022 13:11:26 +0000 Received: by outflank-mailman (input) for mailman id 363868; Sat, 09 Jul 2022 13:11:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAAF3-0006g7-43; Sat, 09 Jul 2022 13:11:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAAF3-0001Al-1K; Sat, 09 Jul 2022 13:11:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAAF2-0004tB-Fl; Sat, 09 Jul 2022 13:11:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAAF2-000374-FH; Sat, 09 Jul 2022 13:11:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+RSOzdcmUn/dBB7TTmWv0GGHg60/cmcjwQ4HnLpESaA=; b=1ccTIDUVWuN1nO60hjRrSlwf4G 0o8HLaZTuWpKJ/1BMrkYw7sokqSVhehDMgPBYtBLg9a/lohwG0e8C7YaE27p6tgUYo+orlaFZwQkm urLOosHA9P06tQOoOM3DT7tbZwLO20o5vIVh+NcUgQct2NAKzqtPYbogQQS3Bg0r/q8s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171566: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e5524c2a1fc4002a52e16236659e779767617a4f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 09 Jul 2022 13:11:24 +0000 flight 171566 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171566/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-arm64-arm64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e5524c2a1fc4002a52e16236659e779767617a4f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 20 days Failing since 171280 2022-06-19 15:12:25 Z 19 days 52 attempts Testing same since 171566 2022-07-09 06:23:04 Z 0 days 1 attempts ------------------------------------------------------------ 557 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23447 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 09 16:29:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 16:29:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363911.594536 (Exim 4.92) (envelope-from ) id 1oADKc-0002LI-Q7; Sat, 09 Jul 2022 16:29:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363911.594536; Sat, 09 Jul 2022 16:29:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADKc-0002LB-NZ; Sat, 09 Jul 2022 16:29:22 +0000 Received: by outflank-mailman (input) for mailman id 363911; Sat, 09 Jul 2022 16:29:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADKb-0002L5-Ih for xen-devel@lists.xenproject.org; Sat, 09 Jul 2022 16:29:21 +0000 Received: from mx1.molgen.mpg.de (mx3.molgen.mpg.de [141.14.17.11]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 462135e8-ffa4-11ec-bd2d-47488cf2e6aa; Sat, 09 Jul 2022 18:29:19 +0200 (CEST) Received: from [192.168.0.2] (ip5f5aedfa.dynamic.kabel-deutschland.de [95.90.237.250]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pmenzel) by mx.molgen.mpg.de (Postfix) with ESMTPSA id 4B3EE61EA1923; Sat, 9 Jul 2022 18:29:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 462135e8-ffa4-11ec-bd2d-47488cf2e6aa Message-ID: <9d547826-d4f8-1547-c842-6eded10a7584@molgen.mpg.de> Date: Sat, 9 Jul 2022 18:29:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.1 Content-Language: en-US To: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org From: Paul Menzel Subject: Lots of XEN init functions called in non-XEN environment Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Dear Linux folks, Booting Debian’s Linux kernel with `initcall_debug` on a laptop with no XEN being used, I see a lot of Xen related init functions to be called. ``` $ sudo dmesg | grep -e balloon -e xen [ 0.066207] calling xen_cons_init+0x0/0x50 @ 0 [ 0.066210] initcall xen_cons_init+0x0/0x50 returned 0 after 0 usecs [ 0.096491] calling xen_pvh_gnttab_setup+0x0/0x34 @ 1 [ 0.096491] initcall xen_pvh_gnttab_setup+0x0/0x34 returned -19 after 0 usecs [ 0.100353] calling xenbus_init+0x0/0x322 @ 1 [ 0.100353] initcall xenbus_init+0x0/0x322 returned -19 after 0 usecs [ 0.100353] calling register_xen_pci_notifier+0x0/0x2d @ 1 [ 0.100353] initcall register_xen_pci_notifier+0x0/0x2d returned 0 after 0 usecs [ 0.100353] calling xen_pcpu_init+0x0/0xb5 @ 1 [ 0.100353] initcall xen_pcpu_init+0x0/0xb5 returned -19 after 0 usecs [ 0.169465] calling balloon_init+0x0/0x1e0 @ 1 [ 0.169467] initcall balloon_init+0x0/0x1e0 returned -19 after 0 usecs [ 0.169470] calling xen_setup_shutdown_event+0x0/0x30 @ 1 [ 0.169473] initcall xen_setup_shutdown_event+0x0/0x30 returned -19 after 0 usecs [ 0.169476] calling xenbus_probe_backend_init+0x0/0x6b @ 1 [ 0.169482] initcall xenbus_probe_backend_init+0x0/0x6b returned 0 after 0 usecs [ 0.169485] calling xenbus_probe_frontend_init+0x0/0x4f @ 1 [ 0.169489] initcall xenbus_probe_frontend_init+0x0/0x4f returned 0 after 0 usecs [ 0.169491] calling xen_acpi_pad_init+0x0/0x3c @ 1 [ 0.169493] initcall xen_acpi_pad_init+0x0/0x3c returned -19 after 0 usecs [ 0.257640] calling xenfb_init+0x0/0x3b @ 1 [ 0.257642] initcall xenfb_init+0x0/0x3b returned -19 after 0 usecs [ 0.259498] calling xenbus_probe_initcall+0x0/0x6f @ 1 [ 0.259599] initcall xenbus_probe_initcall+0x0/0x6f returned 0 after 98 usecs [ 0.259615] calling xenbus_init+0x0/0x3b @ 1 [ 0.259617] initcall xenbus_init+0x0/0x3b returned -19 after 0 usecs [ 0.259620] calling xenbus_backend_init+0x0/0x44 @ 1 [ 0.259622] initcall xenbus_backend_init+0x0/0x44 returned -19 after 0 usecs [ 0.259666] calling xen_late_init_mcelog+0x0/0x5e @ 1 [ 0.259668] initcall xen_late_init_mcelog+0x0/0x5e returned -19 after 0 usecs [ 0.259811] calling xen_hvc_init+0x0/0x1de @ 1 [ 0.259813] initcall xen_hvc_init+0x0/0x1de returned -19 after 0 usecs [ 0.263794] calling xenkbd_init+0x0/0x3b @ 1 [ 0.263796] initcall xenkbd_init+0x0/0x3b returned -19 after 0 usecs [ 0.285181] calling balloon_wait_finish+0x0/0xda @ 1 [ 0.285183] initcall balloon_wait_finish+0x0/0xda returned -19 after 0 usecs ``` All these drivers(?) are enabled in Debian’s Linux configuration to also support XEN setups, but I wonder, if the system can’t detect once if it’s running in a XEN environment, and if it’s not then to skip all the XEN related init functions. Kind regards, Paul From xen-devel-bounces@lists.xenproject.org Sat Jul 09 17:11:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 17:11:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363919.594548 (Exim 4.92) (envelope-from ) id 1oADyu-0001jM-Tu; Sat, 09 Jul 2022 17:11:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363919.594548; Sat, 09 Jul 2022 17:11:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADyu-0001jF-P2; Sat, 09 Jul 2022 17:11:00 +0000 Received: by outflank-mailman (input) for mailman id 363919; Sat, 09 Jul 2022 17:10:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADyt-0001j5-El; Sat, 09 Jul 2022 17:10:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADyt-000699-Co; Sat, 09 Jul 2022 17:10:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oADys-00029F-Q8; Sat, 09 Jul 2022 17:10:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oADys-0001TF-Pf; Sat, 09 Jul 2022 17:10:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dsrP83HyH4Z0xOZUUEXEQwanw0cYOEYSRhIlYyYwZmQ=; b=VnX+/miH4vBRqxawIGXaAIoGio wHE2k6v0K1zi/gwU/0S2t2KzmP/RdQyE3g6mUIfxk/Phys229YqXOtZ99LI+E+FxeUz8fEH/FmonL 1Uc6P/hwBavbsiEVHgF+FhmiunN4VMv8v3PPuffYDW9hJefEDpDAwWs1itpO0BHcRcUs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171569: all pass - PUSHED X-Osstest-Versions-This: ovmf=c8e30482fd2b32a2ba86edbd4c2429c48b20c99b X-Osstest-Versions-That: ovmf=86a0f84470f7df815c54b6da26874314e58c8a1a From: osstest service owner Date: Sat, 09 Jul 2022 17:10:58 +0000 flight 171569 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171569/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c8e30482fd2b32a2ba86edbd4c2429c48b20c99b baseline version: ovmf 86a0f84470f7df815c54b6da26874314e58c8a1a Last test of basis 171567 2022-07-09 07:10:30 Z 0 days Testing same since 171569 2022-07-09 15:10:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeff Brasen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 86a0f84470..c8e30482fd c8e30482fd2b32a2ba86edbd4c2429c48b20c99b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 09 19:02:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 09 Jul 2022 19:02:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363937.594559 (Exim 4.92) (envelope-from ) id 1oAFih-0001lx-8C; Sat, 09 Jul 2022 19:02:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363937.594559; Sat, 09 Jul 2022 19:02:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAFih-0001lq-5W; Sat, 09 Jul 2022 19:02:23 +0000 Received: by outflank-mailman (input) for mailman id 363937; Sat, 09 Jul 2022 19:02:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAFif-0001lg-PD; Sat, 09 Jul 2022 19:02:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAFif-0008FN-LH; Sat, 09 Jul 2022 19:02:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAFif-00052n-3A; Sat, 09 Jul 2022 19:02:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAFif-0005lV-2h; Sat, 09 Jul 2022 19:02:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=7dKabxquQ/oYJydPG760+j7l45dlO0a9knEKrBH+Tus=; b=4FnQOGYxPwV68qCVe0Ze8a6uQG pFeRS380J+15oDE7pfFhauwa6N9bGGZMmGgsfGRiajslMwe7qKTXulrIJKVCpqa8tCzv3vXYfvMM0 r+GyM2EAFKQ/iXh0xADOF+Z3IQIShtTkXNcraoHNSYOJfn1AMfFXk4fZVglCkf0znHKA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171568: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e5524c2a1fc4002a52e16236659e779767617a4f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sat, 09 Jul 2022 19:02:21 +0000 flight 171568 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171568/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e5524c2a1fc4002a52e16236659e779767617a4f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 20 days Failing since 171280 2022-06-19 15:12:25 Z 20 days 53 attempts Testing same since 171566 2022-07-09 06:23:04 Z 0 days 2 attempts ------------------------------------------------------------ 557 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23447 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 00:30:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 00:30:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.363982.594570 (Exim 4.92) (envelope-from ) id 1oAKqI-00020L-JX; Sun, 10 Jul 2022 00:30:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 363982.594570; Sun, 10 Jul 2022 00:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAKqI-00020E-G8; Sun, 10 Jul 2022 00:30:34 +0000 Received: by outflank-mailman (input) for mailman id 363982; Sun, 10 Jul 2022 00:30:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAKqG-000203-Fv; Sun, 10 Jul 2022 00:30:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAKqG-0006oQ-C2; Sun, 10 Jul 2022 00:30:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAKqF-0004Wm-QJ; Sun, 10 Jul 2022 00:30:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAKqF-0001O3-Pp; Sun, 10 Jul 2022 00:30:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=I9MYWDA4rnR08Yo5MC0jjQiqqjpMj7QB0VJ1PzeiIck=; b=JsRM8/5mYmZkzBW7dtzRMMNqW6 bU3ClpUe+jwErruUwkSQKSmEbf4Pp+V4uIthSaLyYtWJ/UFcGw34bvAwPmjqtpZLX7CkPYIjRMFiO FiJWSGOJjc0V7lZVk5v25dx3/J2/GQiUQ2FWLQC3Vb3xLwGMVdzchEiu5usL3MgOAe5E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171570: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=d9cdc3b12525c85b4a2a8b6f3f8f61d9f467ab9a X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 10 Jul 2022 00:30:31 +0000 flight 171570 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171570/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux d9cdc3b12525c85b4a2a8b6f3f8f61d9f467ab9a baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 20 days Failing since 171280 2022-06-19 15:12:25 Z 20 days 54 attempts Testing same since 171570 2022-07-09 19:12:07 Z 0 days 1 attempts ------------------------------------------------------------ 558 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23494 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 02:59:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 02:59:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364544.594581 (Exim 4.92) (envelope-from ) id 1oAN9l-0000be-CB; Sun, 10 Jul 2022 02:58:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364544.594581; Sun, 10 Jul 2022 02:58:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAN9l-0000bW-7H; Sun, 10 Jul 2022 02:58:49 +0000 Received: by outflank-mailman (input) for mailman id 364544; Sun, 10 Jul 2022 02:58:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAN9j-0000bQ-6l for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 02:58:47 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3502bf8d-fffc-11ec-bd2d-47488cf2e6aa; Sun, 10 Jul 2022 04:58:44 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 16574219191281002.3677204736817; Sat, 9 Jul 2022 19:58:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3502bf8d-fffc-11ec-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657421921; cv=none; d=zohomail.com; s=zohoarc; b=GkXs1IZo9L/WTtQvSe/e8YZlbzUzrn8qem0tZstCOT6saM5KoCIajLz/ECawQJ0Fq0Tmn+Ga83WcKh8k8ozPW9Gyp+5EatL51ns5x+NCiewEbjL5V2MbMOQBDBvFzcGJvhZb6NzzOBazQpVgdq7UPnqXcWnql9WIhRt20llmOMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657421921; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=JuwqlljZ0pCG9JhQeB9bTp107EufSATKXjA5r12gq/U=; b=jPdo85qWe03noK39Nf8r9y/APeeJu5hEUVLhs8E3cuZaLAsH2tTA+iXeNNWKJf/oiBWzWmHn3tQXsv9fe5n5ZGFOmfys+ex0CMUYK4EtR3gBKmALlLDnpKseVekz/it1lx5qLRstxtrznAjfw4xgcF0O9b2ZXhPuCOtNT8O6tbE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657421921; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:From:From:To:To:Cc:Cc:References:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=JuwqlljZ0pCG9JhQeB9bTp107EufSATKXjA5r12gq/U=; b=HWShZCzztyBNj6I5bdMmTHec6Z9ERgxwErZkILZRxYqRhF6tF1KKUEiIl7A4KayM NDs6picNS0aCDEqCX3gwEU+oqKBl5e0yirjyuzGuFfx8oIcCbRH4RudUqhCuPZ78iLo F6Y+MqhcBZzZyfjwyATacEY/RIA/4NZ5pAcMS8sg= Message-ID: <7672d8bb-cae5-a07b-3410-6f495686c106@apertussolutions.com> Date: Sat, 9 Jul 2022 22:58:28 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: "Daniel P. Smith" To: Jason Andryuk Cc: Anthony PERARD , christopher.clark@starlab.io, Daniel De Graaf , Scott Davis , Wei Liu , xen-devel References: <92644952-48be-d25b-4471-121cfa14a5c0@apertussolutions.com> <20220706191325.440538-1-jandryuk@gmail.com> Content-Language: en-US Subject: Re: [RFC PATCH] flask: Remove magic SID setting In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/7/22 08:45, Jason Andryuk wrote: > On Thu, Jul 7, 2022 at 6:14 AM Daniel P. Smith > wrote: >> >> On 7/6/22 15:13, Jason Andryuk wrote: >>> flask_domain_alloc_security and flask_domain_create has special code to >>> magically label dom0 as dom0_t. This can all be streamlined by making >>> create_dom0 set ssidref before creating dom0. >> >> Hmm, I wouldn't call it magical, it is the initialization policy for a >> domain labeling, which is specific to each policy module. I considered >> this approach already and my concern here is two fold. First, it now >> hard codes the concept of dom0 vs domU into the XSM API. There is an >> ever growing desire by solution providers to not have a dom0 and at most >> have a hardware domain if at all and this is a step backwards from that >> movement. Second, and related, is this now pushes the initial label >> policy up into the domain builder code away from the policy module and >> spreads it out. Hopefully Xen will evolve to have a richer set of >> initial domains and an appropriate initial label policy will be needed >> for this case. This approach will result in having to continually expand >> the XSM API for each new initial domain type. > > Yeah, adding dom0 vs. domU into the XSM API isn't nice. My original > idea was just for dom0, but I added the domU hook after you basically > said in your other email that dom0less had to work. There should not > be any more of these since they are just to provide backwards > compatibility. Help me understand, why is it considered magic/undesirable to assign a label for Dom0/DomU in flask_domain_alloc_security() when the context is clearly discernible, yet it is acceptable to assign SECINITSID_XENBOOT, SECINITSID_DOMXEN, and SECINITSID_DOMIO? Specifically, when flask_domain_alloc_security() is called with the current domain labeled with SECINITSID_XENBOOT, we know it is creating either a system domain or a Dom0/DomU. At no time should there be a domain created at this time that needs to be labeled with SECINITSID_UNLABELED. When the current domain is no longer SECINITSID_XENBOOT, then the context is no longer understood and the only safe SID to initializat with is SECINITSID_UNLABELED. While I am more than open to listening as to why my opinion/approach may be flawed, codifying dom0 and/or domU into the XSM API is really a non-starter for me. > A dom0/domU flask policy is not interesting for dom0less/hyperlaunch. > So I don't see why xen/flask needs support for determining sids for > domains. If you have dom0less/hyperlaunch + flask, every domain > should have a ssidref defined in its config when building. If you > require ssidrefs for dom0less/hyperlaunch + flask, then there is less > initial label policy. An unspecified ssidref defaulting to > unlabeled_t is fine. Actually, a Dom0/DomU policy is very interesting for those of us that would like to see XSM/Flask to be the default policy regardless of the method of construction for the initial system. A specific test case I would run was a configuration containing a Dom0 and a DomU without XSM labels specified. This configuration should Just Work(tm). > I saw your other patch as adding more "initial label policy" since it > adds more special cases. I see requiring an explicit ssidref or > getting unlabeled_t as a feature. Automatic labeling seems like a > misfeature to me. This is the crux of the problem, you view the XSM API Expansion as label or fail while viewing the Default Initial Assignment as being automatic labeling. The reality is that this is not the case and that the end result between them is exactly the same, just with slightly different flows to get there. The difference being that the XSM API Expansion has codified Dom0/DomU into the XSM API and incurred an additional XSM call on each construction path. Consider the state sequence for struct domain_security_struct{} of the two under dom0less where labels cannot be specified, XSM API Expansion: 1. xsm_ssidref_{dom0,domU}() -> config->ssidref = SECINITSID_DOM0 or SECINITSID_DOMU respectively 2. xsm_alloc_security_domain() -> d->ssid->sid = SECINITSID_UNLABELED 3. xsm_domain_create() will always test config->ssidref, SECINITSID_DOM0 or SECINITSID_DOMU, because (1) will always set it and never as SECINITSID_UNLABELED Default Initial Assignment: 1. xsm_alloc_security_domain() -> d->ssid->sid = SECINITSID_DOM0 or SECINITSID_DOMU 2. config->ssidref = NULL 3. xsm_domain_create() will always test d->ssid->sid, SECINITSID_DOM0 or SECINITSID_DOMU because of (1) and never as SECINITSID_UNLABELED Hyperlaunch domain construction works differently, Dom0/DomU was not codified into the API and where possible the existing Dom0 API codifications were eliminated. The XSM API Expansion approach would result in a similar if statement that is in xsm_alloc_security_domain() under the Default Initial Assignment approach. It would likely occur in builder_create_domains(). There a check of the domain'a permissions and functions would occur to then call the appropriate xsm_ssid_{dom0,domu}() hook. Maybe some day it will be reasonable to expect labeling as a standard part of a domain's configuration, and thus acceptable to panic during boot when it is missing. Unfortunately, that is not today and no matter how it is dressed, the current model has to be a default label assignment based on the understanding that the context is boot-time domain construction. v/r, dps From xen-devel-bounces@lists.xenproject.org Sun Jul 10 05:34:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 05:34:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364552.594592 (Exim 4.92) (envelope-from ) id 1oAPaW-0001Fk-9T; Sun, 10 Jul 2022 05:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364552.594592; Sun, 10 Jul 2022 05:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAPaW-0001Fd-6Y; Sun, 10 Jul 2022 05:34:36 +0000 Received: by outflank-mailman (input) for mailman id 364552; Sun, 10 Jul 2022 05:34:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAPaU-0001FX-9S for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 05:34:34 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f90acb06-0011-11ed-924f-1f966e50362f; Sun, 10 Jul 2022 07:34:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A100B21F58; Sun, 10 Jul 2022 05:34:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 799DF13638; Sun, 10 Jul 2022 05:34:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XEIdHOZkymIiTAAAMHmgww (envelope-from ); Sun, 10 Jul 2022 05:34:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f90acb06-0011-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657431270; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OLa6hNL7L9C4iErVzQN4e+EJTyfdTuUa1Bz+P0yvcJ8=; b=rVKk/ARhgwFZbLuWWt4ixIllgMVJDOW502fqQEAGP0eWmeS3OwQTzseIkH+7OQ1FXEdoOV opKd4IziHCXYhTFiC2vik2TqhXKFG+lPGgb2ZntY5zRAVGoK1FRlP4NDmwhL7Bu3+tSLpZ OccpKHJM/NbqGitwGFjvDRLusOj18wg= Message-ID: <995c95e2-6df7-4c96-94c0-f069635a1044@suse.com> Date: Sun, 10 Jul 2022 07:34:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Paul Menzel , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <9d547826-d4f8-1547-c842-6eded10a7584@molgen.mpg.de> From: Juergen Gross Subject: Re: Lots of XEN init functions called in non-XEN environment In-Reply-To: <9d547826-d4f8-1547-c842-6eded10a7584@molgen.mpg.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------ywijOeQYnMfu4NtG09TwKltv" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------ywijOeQYnMfu4NtG09TwKltv Content-Type: multipart/mixed; boundary="------------oYe1aFiOOeipbheLAp7LvbiM"; protected-headers="v1" From: Juergen Gross To: Paul Menzel , Stefano Stabellini Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Message-ID: <995c95e2-6df7-4c96-94c0-f069635a1044@suse.com> Subject: Re: Lots of XEN init functions called in non-XEN environment References: <9d547826-d4f8-1547-c842-6eded10a7584@molgen.mpg.de> In-Reply-To: <9d547826-d4f8-1547-c842-6eded10a7584@molgen.mpg.de> --------------oYe1aFiOOeipbheLAp7LvbiM Content-Type: multipart/mixed; boundary="------------xnv5yJeidzGvavarsLLO21j8" --------------xnv5yJeidzGvavarsLLO21j8 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDcuMjIgMTg6MjksIFBhdWwgTWVuemVsIHdyb3RlOg0KPiBEZWFyIExpbnV4IGZv bGtzLA0KPiANCj4gDQo+IEJvb3RpbmcgRGViaWFu4oCZcyBMaW51eCBrZXJuZWwgd2l0aCBg aW5pdGNhbGxfZGVidWdgIG9uIGEgbGFwdG9wIHdpdGggbm8gWEVOIA0KPiBiZWluZyB1c2Vk LCBJIHNlZSBhIGxvdCBvZiBYZW4gcmVsYXRlZCBpbml0IGZ1bmN0aW9ucyB0byBiZSBjYWxs ZWQuDQo+IA0KPiBgYGANCj4gJCBzdWRvIGRtZXNnIHwgZ3JlcCAtZSBiYWxsb29uIC1lIHhl bg0KPiBbwqDCoMKgIDAuMDY2MjA3XSBjYWxsaW5nwqAgeGVuX2NvbnNfaW5pdCsweDAvMHg1 MCBAIDANCj4gW8KgwqDCoCAwLjA2NjIxMF0gaW5pdGNhbGwgeGVuX2NvbnNfaW5pdCsweDAv MHg1MCByZXR1cm5lZCAwIGFmdGVyIDAgdXNlY3MNCj4gW8KgwqDCoCAwLjA5NjQ5MV0gY2Fs bGluZ8KgIHhlbl9wdmhfZ250dGFiX3NldHVwKzB4MC8weDM0IEAgMQ0KPiBbwqDCoMKgIDAu MDk2NDkxXSBpbml0Y2FsbCB4ZW5fcHZoX2dudHRhYl9zZXR1cCsweDAvMHgzNCByZXR1cm5l ZCAtMTkgYWZ0ZXIgMCB1c2Vjcw0KPiBbwqDCoMKgIDAuMTAwMzUzXSBjYWxsaW5nwqAgeGVu YnVzX2luaXQrMHgwLzB4MzIyIEAgMQ0KPiBbwqDCoMKgIDAuMTAwMzUzXSBpbml0Y2FsbCB4 ZW5idXNfaW5pdCsweDAvMHgzMjIgcmV0dXJuZWQgLTE5IGFmdGVyIDAgdXNlY3MNCj4gW8Kg wqDCoCAwLjEwMDM1M10gY2FsbGluZ8KgIHJlZ2lzdGVyX3hlbl9wY2lfbm90aWZpZXIrMHgw LzB4MmQgQCAxDQo+IFvCoMKgwqAgMC4xMDAzNTNdIGluaXRjYWxsIHJlZ2lzdGVyX3hlbl9w Y2lfbm90aWZpZXIrMHgwLzB4MmQgcmV0dXJuZWQgMCBhZnRlciAwIHVzZWNzDQo+IFvCoMKg wqAgMC4xMDAzNTNdIGNhbGxpbmfCoCB4ZW5fcGNwdV9pbml0KzB4MC8weGI1IEAgMQ0KPiBb wqDCoMKgIDAuMTAwMzUzXSBpbml0Y2FsbCB4ZW5fcGNwdV9pbml0KzB4MC8weGI1IHJldHVy bmVkIC0xOSBhZnRlciAwIHVzZWNzDQo+IFvCoMKgwqAgMC4xNjk0NjVdIGNhbGxpbmfCoCBi YWxsb29uX2luaXQrMHgwLzB4MWUwIEAgMQ0KPiBbwqDCoMKgIDAuMTY5NDY3XSBpbml0Y2Fs bCBiYWxsb29uX2luaXQrMHgwLzB4MWUwIHJldHVybmVkIC0xOSBhZnRlciAwIHVzZWNzDQo+ IFvCoMKgwqAgMC4xNjk0NzBdIGNhbGxpbmfCoCB4ZW5fc2V0dXBfc2h1dGRvd25fZXZlbnQr MHgwLzB4MzAgQCAxDQo+IFvCoMKgwqAgMC4xNjk0NzNdIGluaXRjYWxsIHhlbl9zZXR1cF9z aHV0ZG93bl9ldmVudCsweDAvMHgzMCByZXR1cm5lZCAtMTkgYWZ0ZXIgMCANCj4gdXNlY3MN Cj4gW8KgwqDCoCAwLjE2OTQ3Nl0gY2FsbGluZ8KgIHhlbmJ1c19wcm9iZV9iYWNrZW5kX2lu aXQrMHgwLzB4NmIgQCAxDQo+IFvCoMKgwqAgMC4xNjk0ODJdIGluaXRjYWxsIHhlbmJ1c19w cm9iZV9iYWNrZW5kX2luaXQrMHgwLzB4NmIgcmV0dXJuZWQgMCBhZnRlciAwIHVzZWNzDQo+ IFvCoMKgwqAgMC4xNjk0ODVdIGNhbGxpbmfCoCB4ZW5idXNfcHJvYmVfZnJvbnRlbmRfaW5p dCsweDAvMHg0ZiBAIDENCj4gW8KgwqDCoCAwLjE2OTQ4OV0gaW5pdGNhbGwgeGVuYnVzX3By b2JlX2Zyb250ZW5kX2luaXQrMHgwLzB4NGYgcmV0dXJuZWQgMCBhZnRlciAwIA0KPiB1c2Vj cw0KPiBbwqDCoMKgIDAuMTY5NDkxXSBjYWxsaW5nwqAgeGVuX2FjcGlfcGFkX2luaXQrMHgw LzB4M2MgQCAxDQo+IFvCoMKgwqAgMC4xNjk0OTNdIGluaXRjYWxsIHhlbl9hY3BpX3BhZF9p bml0KzB4MC8weDNjIHJldHVybmVkIC0xOSBhZnRlciAwIHVzZWNzDQo+IFvCoMKgwqAgMC4y NTc2NDBdIGNhbGxpbmfCoCB4ZW5mYl9pbml0KzB4MC8weDNiIEAgMQ0KPiBbwqDCoMKgIDAu MjU3NjQyXSBpbml0Y2FsbCB4ZW5mYl9pbml0KzB4MC8weDNiIHJldHVybmVkIC0xOSBhZnRl ciAwIHVzZWNzDQo+IFvCoMKgwqAgMC4yNTk0OThdIGNhbGxpbmfCoCB4ZW5idXNfcHJvYmVf aW5pdGNhbGwrMHgwLzB4NmYgQCAxDQo+IFvCoMKgwqAgMC4yNTk1OTldIGluaXRjYWxsIHhl bmJ1c19wcm9iZV9pbml0Y2FsbCsweDAvMHg2ZiByZXR1cm5lZCAwIGFmdGVyIDk4IHVzZWNz DQo+IFvCoMKgwqAgMC4yNTk2MTVdIGNhbGxpbmfCoCB4ZW5idXNfaW5pdCsweDAvMHgzYiBA IDENCj4gW8KgwqDCoCAwLjI1OTYxN10gaW5pdGNhbGwgeGVuYnVzX2luaXQrMHgwLzB4M2Ig cmV0dXJuZWQgLTE5IGFmdGVyIDAgdXNlY3MNCj4gW8KgwqDCoCAwLjI1OTYyMF0gY2FsbGlu Z8KgIHhlbmJ1c19iYWNrZW5kX2luaXQrMHgwLzB4NDQgQCAxDQo+IFvCoMKgwqAgMC4yNTk2 MjJdIGluaXRjYWxsIHhlbmJ1c19iYWNrZW5kX2luaXQrMHgwLzB4NDQgcmV0dXJuZWQgLTE5 IGFmdGVyIDAgdXNlY3MNCj4gW8KgwqDCoCAwLjI1OTY2Nl0gY2FsbGluZ8KgIHhlbl9sYXRl X2luaXRfbWNlbG9nKzB4MC8weDVlIEAgMQ0KPiBbwqDCoMKgIDAuMjU5NjY4XSBpbml0Y2Fs bCB4ZW5fbGF0ZV9pbml0X21jZWxvZysweDAvMHg1ZSByZXR1cm5lZCAtMTkgYWZ0ZXIgMCB1 c2Vjcw0KPiBbwqDCoMKgIDAuMjU5ODExXSBjYWxsaW5nwqAgeGVuX2h2Y19pbml0KzB4MC8w eDFkZSBAIDENCj4gW8KgwqDCoCAwLjI1OTgxM10gaW5pdGNhbGwgeGVuX2h2Y19pbml0KzB4 MC8weDFkZSByZXR1cm5lZCAtMTkgYWZ0ZXIgMCB1c2Vjcw0KPiBbwqDCoMKgIDAuMjYzNzk0 XSBjYWxsaW5nwqAgeGVua2JkX2luaXQrMHgwLzB4M2IgQCAxDQo+IFvCoMKgwqAgMC4yNjM3 OTZdIGluaXRjYWxsIHhlbmtiZF9pbml0KzB4MC8weDNiIHJldHVybmVkIC0xOSBhZnRlciAw IHVzZWNzDQo+IFvCoMKgwqAgMC4yODUxODFdIGNhbGxpbmfCoCBiYWxsb29uX3dhaXRfZmlu aXNoKzB4MC8weGRhIEAgMQ0KPiBbwqDCoMKgIDAuMjg1MTgzXSBpbml0Y2FsbCBiYWxsb29u X3dhaXRfZmluaXNoKzB4MC8weGRhIHJldHVybmVkIC0xOSBhZnRlciAwIHVzZWNzDQo+IGBg YA0KPiANCj4gQWxsIHRoZXNlIGRyaXZlcnMoPykgYXJlIGVuYWJsZWQgaW4gRGViaWFu4oCZ cyBMaW51eCBjb25maWd1cmF0aW9uIHRvIGFsc28gc3VwcG9ydCANCj4gWEVOIHNldHVwcywg YnV0IEkgd29uZGVyLCBpZiB0aGUgc3lzdGVtIGNhbuKAmXQgZGV0ZWN0IG9uY2UgaWYgaXTi gJlzIHJ1bm5pbmcgaW4gYSANCj4gWEVOIGVudmlyb25tZW50LCBhbmQgaWYgaXTigJlzIG5v dCB0aGVuIHRvIHNraXAgYWxsIHRoZSBYRU4gcmVsYXRlZCBpbml0IGZ1bmN0aW9ucy4NCg0K WW91IGFyZSBhd2FyZSBob3cgaW5pdGNhbGwgaXMgd29ya2luZz8gSWYgbm90LCBJJ2QgcmVj b21tZW5kIHRvIHJlYWQgdGhlDQpjb2RlLg0KDQpTbyBob3cgd291bGQgeW91IHNraXAgaW5p dGNhbGxzIGZvciBYZW4gb3RoZXIgdGhhbiBiYWlsaW5nIG91dCBlYXJseSBpbg0KZWFjaCBY ZW4gcmVsYXRlZCBpbml0Y2FsbCBpZiB0aGUgc3lzdGVtIGlzIG5vdCBydW5uaW5nIGFzIGEg WGVuIGd1ZXN0LA0Kd2hpY2ggaXMgaG93IGl0IHdvcmtzIHRvZGF5Pw0KDQoNCkp1ZXJnZW4N Cg== --------------xnv5yJeidzGvavarsLLO21j8 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------xnv5yJeidzGvavarsLLO21j8-- --------------oYe1aFiOOeipbheLAp7LvbiM-- --------------ywijOeQYnMfu4NtG09TwKltv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLKZOUFAwAAAAAACgkQsN6d1ii/Ey+U 4gf+LF41bcvmCYRBeAaUf3PhXYcT1NWhqRd3zJEGMZGZo62OP4LH/qAY6QU6zzdwRkmyNOxgBlc4 pv0/nKmYNT/+d5IqGJ6gAi601kxZUbxKx+tPjAzzYgYnglNg5O/cASSReRq2kkS6leADuDJi9fVq Q8FaSBKAOiXI5iK1GuaqDlYLmrDuX6n0QidY4sU2wyUiHt1zcjDQvpTBRmr5MoXxunNaNK49/njd vV21Y5vjECt3tI2v4S5NrbpzhtwKgQSw4xk9u6R6diYo4RnWz6kPCYu1uA0EANoR7Y9SE5tZezEp 1ORsmtPxHBHAK41b07jRS3TeUeX+dUTqlPvZLpzuMQ== =E3ne -----END PGP SIGNATURE----- --------------ywijOeQYnMfu4NtG09TwKltv-- From xen-devel-bounces@lists.xenproject.org Sun Jul 10 06:13:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 06:13:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364559.594603 (Exim 4.92) (envelope-from ) id 1oAQC8-00062y-7Z; Sun, 10 Jul 2022 06:13:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364559.594603; Sun, 10 Jul 2022 06:13:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAQC8-00062r-4V; Sun, 10 Jul 2022 06:13:28 +0000 Received: by outflank-mailman (input) for mailman id 364559; Sun, 10 Jul 2022 06:13:27 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAQC6-00062e-V4; Sun, 10 Jul 2022 06:13:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAQC6-0007Q8-Qg; Sun, 10 Jul 2022 06:13:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAQC6-0003IX-5f; Sun, 10 Jul 2022 06:13:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAQC6-0004MI-4s; Sun, 10 Jul 2022 06:13:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=unQxg6G3PQ1RFiC8n/Vwo4C9CUnDMDCZULXIsVMWXac=; b=v6PZL9WjSdi4+d6zNeIUCnq/hR 2QTavdFoQkGMcXsBwoI7AprpJwMwcKhAj921TZ421dO8tDCRPHOKFVHvEc5ScPhg9hbrPz4fkJcp4 D5J/0gUTGbb2GBFGvBKRNfFzh0lmD2jCSR4ZXAHnG76+bOmLViuKehZ65B54L2JYrs+4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171571: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-armhf-armhf-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 10 Jul 2022 06:13:26 +0000 flight 171571 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171571/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-armhf-armhf-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 21 days Failing since 171280 2022-06-19 15:12:25 Z 20 days 55 attempts Testing same since 171571 2022-07-10 00:40:39 Z 0 days 1 attempts ------------------------------------------------------------ 561 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23544 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 07:46:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 07:46:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364589.594614 (Exim 4.92) (envelope-from ) id 1oARdb-0007eK-0x; Sun, 10 Jul 2022 07:45:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364589.594614; Sun, 10 Jul 2022 07:45:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oARda-0007eD-UK; Sun, 10 Jul 2022 07:45:54 +0000 Received: by outflank-mailman (input) for mailman id 364589; Sun, 10 Jul 2022 07:45:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oARdZ-0007e3-Jg; Sun, 10 Jul 2022 07:45:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oARdZ-0000gs-GF; Sun, 10 Jul 2022 07:45:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oARdZ-00066d-1l; Sun, 10 Jul 2022 07:45:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oARdZ-0002C2-1K; Sun, 10 Jul 2022 07:45:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dRKEUhsU0pTFxMP/RWtI2YgNsH9SqPKproam+AvZEF0=; b=AplS7UlcSukMwu9tQkYck0FwxW bow1PYSlh3xhv+nlMwaAdS6E18LvESe1f95eSOz/yXu7rgxsSbIH/OeMQdwt2eKvPcUW8ruszBsgl GmpzR6DxWHf4JqHYkhtDJa3yHNf52Kzw1hfo1BBB161XkHxcqFmgm1afKpDL4MWmTzSw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171573: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 10 Jul 2022 07:45:53 +0000 flight 171573 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171573/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 730 days Failing since 151818 2020-07-11 04:18:52 Z 729 days 711 attempts Testing same since 171555 2022-07-08 04:20:30 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115427 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 08:57:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 08:57:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364613.594626 (Exim 4.92) (envelope-from ) id 1oASku-0007Z7-NJ; Sun, 10 Jul 2022 08:57:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364613.594626; Sun, 10 Jul 2022 08:57:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oASku-0007Z0-I8; Sun, 10 Jul 2022 08:57:32 +0000 Received: by outflank-mailman (input) for mailman id 364613; Sun, 10 Jul 2022 08:57:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oASkt-0007Yq-8G; Sun, 10 Jul 2022 08:57:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oASkt-0002V4-30; Sun, 10 Jul 2022 08:57:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oASks-0007qd-N7; Sun, 10 Jul 2022 08:57:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oASks-0008Mu-Mc; Sun, 10 Jul 2022 08:57:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=A4WopVF3uiTohdw+hyDakEChyiF+6lfnY1uwrsHLEF4=; b=R97K7BjRHsC6be/377VHoBtyAn x/C2JI/jNmEniiwv3g59D7Bg1wLCgQ8Y/U51ZNGWK9UgODlRcWxCzi2cPf2WzgaXWoMoM/oxbbtRZ ZH5TiuCkbOqZyh7QtG9HwsdzwUZF3OEPzN858hCzDZP1t6OrgSoecu5Eb8/OdY8MiBDA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171572: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 X-Osstest-Versions-That: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 From: osstest service owner Date: Sun, 10 Jul 2022 08:57:30 +0000 flight 171572 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171572/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171564 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171564 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171564 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171564 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171564 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171564 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171564 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171564 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171564 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171564 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171564 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171564 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171564 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 baseline version: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 Last test of basis 171572 2022-07-10 01:53:20 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 10 13:26:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 13:26:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364662.594636 (Exim 4.92) (envelope-from ) id 1oAWwX-0001qx-LI; Sun, 10 Jul 2022 13:25:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364662.594636; Sun, 10 Jul 2022 13:25:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAWwX-0001qq-Ht; Sun, 10 Jul 2022 13:25:49 +0000 Received: by outflank-mailman (input) for mailman id 364662; Sun, 10 Jul 2022 13:25:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAWwW-0001qg-GF; Sun, 10 Jul 2022 13:25:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAWwW-0007fJ-EH; Sun, 10 Jul 2022 13:25:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAWwV-00063y-Vi; Sun, 10 Jul 2022 13:25:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAWwV-0001Ti-VF; Sun, 10 Jul 2022 13:25:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=81RH52aLpBCp95AVYC2emASSgtjH7Ox1PUnVVokg+bI=; b=YQyvoBUu33hwqWt80MSgcWTMfA qJ8LDlEjR9j2X+b+bOMG3BKOcYG6lctPF0b0nWzZLx0/vX6BxpYyRnGE7PMF6GzVvNrByS3VMciKQ bjadwBjcm/ihsD/43JwmSkVtRcXCNznUzmmgJsimQ65SFA2KWOpR/tSxiHGsAE2DNScY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171574: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 10 Jul 2022 13:25:47 +0000 flight 171574 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171574/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 21 days Failing since 171280 2022-06-19 15:12:25 Z 20 days 56 attempts Testing same since 171571 2022-07-10 00:40:39 Z 0 days 2 attempts ------------------------------------------------------------ 561 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23544 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 18:45:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 18:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364709.594647 (Exim 4.92) (envelope-from ) id 1oAbvu-00018X-DV; Sun, 10 Jul 2022 18:45:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364709.594647; Sun, 10 Jul 2022 18:45:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAbvu-00018Q-9f; Sun, 10 Jul 2022 18:45:30 +0000 Received: by outflank-mailman (input) for mailman id 364709; Sun, 10 Jul 2022 18:45:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAbvs-00018G-Uc; Sun, 10 Jul 2022 18:45:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAbvs-0005r3-Pg; Sun, 10 Jul 2022 18:45:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAbvs-0005KA-9t; Sun, 10 Jul 2022 18:45:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAbvs-0002aD-9Q; Sun, 10 Jul 2022 18:45:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=luhMZvzfvNskEXpQbSLqSDwKWVFsVbL4CCtFDqLhoNU=; b=jokXJW+ZfZyUqQ5ukcaRW6dIEn rtW0CPwg6uHu6qv2nhS5WCUafANxxFMpufP2ak/x+D8IHAbJqenh8h3qm4pVn0rwZ1vqs+1Kgd7NV YwfuLEClsc2gKgnuQmi/b2oS0cmytylrRCRucC83rNF/AcyD3FHnE50r9IER3XpwLll0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171575: regressions - FAIL X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-credit1:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt:xen-boot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-libvirt-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-libvirt-raw:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qcow2:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd11-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-pygrub:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-vhd:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-ovmf-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine:reboot:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvshim:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-qemuu-nested-intel:xen-boot:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-shadow:xen-boot:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/src_host:fail:regression linux-linus:test-amd64-amd64-pair:xen-boot/dst_host:fail:regression linux-linus:test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-pvhv2-amd:xen-boot:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-examine-bios:reboot:fail:regression linux-linus:test-amd64-amd64-examine-uefi:reboot:fail:regression linux-linus:test-amd64-amd64-dom0pvh-xl-amd:xen-boot:fail:regression linux-linus:test-amd64-coresched-amd64-xl:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-credit2:xen-boot:fail:regression linux-linus:test-arm64-arm64-libvirt-raw:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl:host-ping-check-xen:fail:heisenbug linux-linus:test-amd64-amd64-xl-rtds:xen-boot:fail:allowable linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Sun, 10 Jul 2022 18:45:28 +0000 flight 171575 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171575/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-credit1 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-libvirt-raw 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qcow2 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd11-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pygrub 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-multivcpu 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-vhd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-ovmf-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-ws16-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine 8 reboot fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-win7-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvshim 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-qemuu-nested-intel 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-libvirt-xsm 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-shadow 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-pair 12 xen-boot/src_host fail REGR. vs. 171277 test-amd64-amd64-pair 13 xen-boot/dst_host fail REGR. vs. 171277 test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-pvhv2-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-freebsd12-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-examine-bios 8 reboot fail REGR. vs. 171277 test-amd64-amd64-examine-uefi 8 reboot fail REGR. vs. 171277 test-amd64-amd64-dom0pvh-xl-amd 8 xen-boot fail REGR. vs. 171277 test-amd64-coresched-amd64-xl 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-qemut-debianhvm-amd64 8 xen-boot fail REGR. vs. 171277 test-amd64-amd64-xl-credit2 8 xen-boot fail REGR. vs. 171277 Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-raw 17 guest-start/debian.repeat fail pass in 171574 test-armhf-armhf-xl 10 host-ping-check-xen fail pass in 171574 Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 8 xen-boot fail REGR. vs. 171277 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171574 like 171277 test-armhf-armhf-xl 15 migrate-support-check fail in 171574 never pass test-armhf-armhf-xl 16 saverestore-support-check fail in 171574 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b1c428b6c3684ee8ddf4137d68b3e8d51d2a700f baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 21 days Failing since 171280 2022-06-19 15:12:25 Z 21 days 57 attempts Testing same since 171571 2022-07-10 00:40:39 Z 0 days 3 attempts ------------------------------------------------------------ 561 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl fail test-amd64-coresched-amd64-xl fail test-arm64-arm64-xl pass test-armhf-armhf-xl fail test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm fail test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd fail test-amd64-amd64-dom0pvh-xl-amd fail test-amd64-amd64-xl-qemut-debianhvm-amd64 fail test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-amd64-freebsd11-amd64 fail test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 fail test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios fail test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 fail test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine fail test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel fail test-amd64-amd64-xl-pvhv2-intel fail test-amd64-amd64-dom0pvh-xl-intel fail test-amd64-amd64-libvirt fail test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair fail test-amd64-amd64-libvirt-pair fail test-amd64-amd64-xl-pvshim fail test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 fail test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow fail test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi fail test-amd64-amd64-xl-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 23544 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 10 19:20:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 19:20:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364722.594657 (Exim 4.92) (envelope-from ) id 1oAcTa-0005gg-9E; Sun, 10 Jul 2022 19:20:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364722.594657; Sun, 10 Jul 2022 19:20:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAcTa-0005gZ-6a; Sun, 10 Jul 2022 19:20:18 +0000 Received: by outflank-mailman (input) for mailman id 364722; Sun, 10 Jul 2022 19:20:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAcTY-0005gT-L3 for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 19:20:16 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51cd87be-0085-11ed-bd2d-47488cf2e6aa; Sun, 10 Jul 2022 21:20:14 +0200 (CEST) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26AHXGYk020315; Sun, 10 Jul 2022 19:19:54 GMT Received: from eur01-he1-obe.outbound.protection.outlook.com (mail-he1eur01lp2056.outbound.protection.outlook.com [104.47.0.56]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3h71kujm83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Jul 2022 19:19:54 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by VI1PR03MB3056.eurprd03.prod.outlook.com (2603:10a6:802:30::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Sun, 10 Jul 2022 19:19:50 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Sun, 10 Jul 2022 19:19:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51cd87be-0085-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O62gmxvJAV++3UavCd/Jupt+O7UOfvU+3HpGfzgO7ufS4DZNxUuppXmmpqr6fZBpl7H0BGhwukGaW/6wA3hI9Jg36tORJa4BS1UpP0ShLfAbatwrr46Ie2ENnP+pSC32Jc0f+uSZFFmMoCe3jFPuouZizuyvYWshEPpAWizBjXSnmIrlgOJBYqcOvu/ojJFjjDKeK2KPgcCqcON7Jt8OOWqK42hPZ4EcY7OmV2ytwNbxW3PafsgIoVy+yrTe0repYzM2PbkMkSV4qRHomL7/YIlURiTyuzaRfCuwu7tejDaAXtMJjnzgpNKIjCntQs5MTP/dwf5J1U25oS2LRp8VmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZRHvcGm8ElQq6bAO2ejiNRTXZyHpnSAMPmZn0z/G8g=; b=iIyfAVfE+a46nMnwvQWJAGGqSwMvHFtkmRRhYUmiLy0/nSLO/qsbaSdVd1xPtfOOY5KxG+uD9SEtL8tlpwFP4/PNmIRQyrx3LE5LM0bRNosnfLYqKjXHbgb8PRZcp66CeHaKwNxcBqNo6kJxQf/tNwNXgNY8+QUDbjAn9j9P2eRWZrJ1GVGrWif0wU2Oz/gngS7EYkTINDHB9GY9WyWwTVVyEbc/Q+6hJb6uk5llYm02i7un5/jQR2rlSl3Ml/6ayMou2btBaHqhe96V4m/Vulry/s5thm+OsNEjLwDpmzQmbcoaiGgdhDeWis2n797743kMYUzzJanLPJss5lNPNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZRHvcGm8ElQq6bAO2ejiNRTXZyHpnSAMPmZn0z/G8g=; b=mgyoOWwkVgffpRDOkmRxrIPn8TGa6GLHQE3MOAs7F1L0bisNxNMb7ocHqoYYxv7NAV9HTPx4rTuE9YuUvNGOuqn5twyAo6lHKTUr4kCT2bv5zw0lI4QwEL1WXBHB3bO4KZvCb9tDC5/FaCrwCHrndwkef/l1L37/p8vPkqcQs/JDt238twzl2O2+0Jr/hoRkdt33JhhgWkmHxZA5vbtkOsJqC1lw/tnpF6jLnvM05fIxZHfYG6leYTSGVfMRziZ8+QIdhRYbs0vsjEd0hQcMboEVrDKs34XUVm0/zFcb3tCOc1bIA9MJKG+g+hMnaX79DBT8+GqFeph4+uj/znnhHQ== From: Oleksandr Tyshchenko To: Demi Marie Obenour CC: Linux kernel regressions , "stable@vger.kernel.org" , Greg KH , Linux kernel mailing list , Xen developer discussion , Stefano Stabellini , Juergen Gross Subject: Re: [PATCH master] Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Topic: [PATCH master] Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Index: AQHYkulN1X/lWVHlgEmBaIdfsTCb/q13/jiA Date: Sun, 10 Jul 2022 19:19:50 +0000 Message-ID: <45234f29-49f9-6089-1c97-7d2c6f29e70f@epam.com> References: <20220708163750.2005-1-demi@invisiblethingslab.com> <20220708163750.2005-8-demi@invisiblethingslab.com> In-Reply-To: <20220708163750.2005-8-demi@invisiblethingslab.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: df3ae64e-eca0-4fa8-3828-08da62a92923 x-ms-traffictypediagnostic: VI1PR03MB3056:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k1M7OkONTM4uebpYw6pW0ctcRzda5PzaU+CcWcxqonNNAYri51FVvfED2WXsjukfwKihz6iXVpLoXaPnDK47KcIiUpyd/IN7wD1uoWm9jKAXihgFeP4SgCjkfkC+b4UgVxzHkpeHsAMXSpIAoS/9z43a+fsOrVFzHNxdmqzPJ7XXkpnOPZmI1HwzL+NouVBAFnM/v6pSXwEL79OjSTDCGOZAO6boegFKbZ+3T29ExMIbrw53pZ0bpLL8Q19PGLh+IWoLROx9v4c4vrl8M/2eeH8zP3A8tAdhq4rStB7vl78uzCkEamVGEE1yZArLZJVrOEeT7dgxbgLk7qSGDYKzMuNPnXHl/X2UHjnQ7urK7YsQPCh+hpZfRSSd95Nq53cMBtn4ooJBgqriInMqBdNvBJ5vLRn5KeWHo4AwoN9rLKCB0hxRxq1/qYK8rQIBM5x0VrYbjA6TMQY8C8SYqMgXDFDMEyi3UOUwvG5Pic080Ic/059A2dOaOxLBi7fJcyVla7k3G4UdhfEIgN2iSBagewgwN6LCxc7xU7nRcP+7mqjpD0927XQSDEJzTCVCl+O0tqqdbLg3kYhbakjVVUMNhF/UPTjsIYv5YDH2IDDIQsTDUrNZIb9yaBqHAPOaMl/BiItiSDf8VhujS55BOodG4TEf1jENCGy2jh1GUpmmxNb7RPCZH3Vp+7vNJw5e3IiOooYgW0GRliOHlReNdwKugQVYxhrpDo5xFxiW9emikSBT1d+SMNqgngNh3k8A7LEch5cO0UhAQNrMXGgNK/Sc2SzpNk/SiQwtVCPwGLAPp6TzNuezCXTSwdYn0xjP5I7ToTOl+A69/32GsGNrVCmXGLGAD3o3fBScrdASDN7CcX0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(366004)(6916009)(54906003)(8676002)(26005)(66946007)(76116006)(6512007)(71200400001)(64756008)(66476007)(66556008)(66446008)(55236004)(91956017)(31686004)(36756003)(6506007)(53546011)(83380400001)(2906002)(316002)(4326008)(41300700001)(38100700002)(5660300002)(6486002)(31696002)(2616005)(8936002)(38070700005)(478600001)(186003)(86362001)(122000001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NmxwLzIyQUdmUTRHUFZuKzA4aVJUME9Tdzcvc0ZGUSthSWdQUWMyL1B6cHBx?= =?utf-8?B?S1dDY0tQZEc3ZmhCMGVpODcxQlBwSG5NajNGelladSt3ZnFZaDJXUWxQbTc3?= =?utf-8?B?QVdkNEczWjNzK1B2NGdyK2dKcjRJQTRXRXUzYjJ6R0p3TlR5YlluRUpsQTdW?= =?utf-8?B?V25zTUplV0tTbXI0L2dubmY5bjZDWDNNdXZYRVltU0RTM1NCY05UQS9IZFZD?= =?utf-8?B?V1dScGJKL3RROHA5SmxVNTEvU1huUktQZlpyU1ZpY0RTV3NRcUFialI5c0N2?= =?utf-8?B?SUFQMXlOclN0Ky9ld2hnUlhFQWVpbzBsTUszOHhKTVdscHZFVk5JWnpEV1I1?= =?utf-8?B?YUloMGUzeWpCdG0yS0RSUmI5TGNNQmZsWFA3YzZieWxGVDl3ZVQrZmkva3FE?= =?utf-8?B?Tyt0Mi8vbTExMG5UVHhoVGlIazQvZkpFV01jaTNWWC84WURaemVJTE5WUlBS?= =?utf-8?B?RkN2bkJiR2dyVVdXQ1N4ejdJcmJuTHpQTnZvRHg1dHY1Z0k3dExHWVRaakpC?= =?utf-8?B?RUxLTGVwOUdQTEtRdEhSblB5Q013VzF5U05nbzdpWGNBMTMreHUyY3ZFZ3dw?= =?utf-8?B?czN5UGw5dk1acUpmRUN2Rll1dzdVekIxZHR6U2lISi9QNVRDVU5DclEzY0xp?= =?utf-8?B?b1NGNU44SUM2QkxRd080dW42b3MzZXFjaDN4QVEydFd6QlRFeEtzbFlrQk5Z?= =?utf-8?B?QWhnMGNOMUp5dkFwNkltWmtaM01uMmVGUHprcnJKbnRSdW5LaTBCVFBxN2dI?= =?utf-8?B?UWdnc0czRUpoRGV6WWFDSzRkN3Bkem9YODRHTk0vYnVKYmZoL0N2b0R6bEFj?= =?utf-8?B?S2RlTlN2TXBMUHloRHU4d2J1RklYOHdQRnJjMEhCZENpVnlZR1dqL0owcDdO?= =?utf-8?B?b3lBUGFRYmcwcUtsOEU4N3crQ2E3cmFtMU9lUzgyTmIvakI1Q2VRTm9RbVZR?= =?utf-8?B?b0xsYXlUQXVuQlZmSEZHYTVmOTJjeUc1K0dqRW5HWFlWMTVFZ3JQcU9uTC81?= =?utf-8?B?a0tieGNrOHZvalpGdEZpdm9ocDFHODNWaDRZcWVhTzRObHpRNHRVb1Bwemti?= =?utf-8?B?d3pDU0M5RisrZm1OaFBMVU5GdnN3eVY3bkI5MlRKa0NZR2RMYUFqUUd2ZVhS?= =?utf-8?B?Q21VQkgwd0FyODRHWjNERlhTWGUwSDVSNURtS29HMlB6eDBoclFvVW1YK3NS?= =?utf-8?B?RTU1blZ1WTFHWDMyRU1sb0xiRi9Bc1NaQVlSQW1ubU5oYUs1MjJndXA2N3JM?= =?utf-8?B?bGx3cHVtRXVGY0VEWWR5ZWJQTTEvSFErZHRJNVkybzM0ZHhLWWpEcVJteWhO?= =?utf-8?B?dWFjcTVXTWQ3VFhCbzhMUnIzSzBXR00xeWlIbDF1UVVuV1ZtbkpIVUdBWWhZ?= =?utf-8?B?ZlQ1bGkrZUNTcXNTd1p1Vk1GVEhDL09FSTRmaGVZdXBxSWdyUVljVGhET1Fq?= =?utf-8?B?K1pIRU4vYW5BRmI2a0t4aFliNHh1bjFCMThQblNkcWhVT0VYME11SWpvdmJP?= =?utf-8?B?MnV6NjRhWGlWdEFVWDJaa2NTcWhEcytsZjVZM0JUaHIwZHZaOVdmNTdjTGRB?= =?utf-8?B?THpqamxtd0VOR3NtUmZEQnVaZmVQeWpEMVRUQ29lZWhDbndlSitZR3A0QnBW?= =?utf-8?B?QlVBLzRzVHZpSzRlVkhIdzBic1g3QnhYU1F0aW1vd0puOEpTTXkrWXl2Z2VH?= =?utf-8?B?U29KVkZQMVNRR094bnphZUZOMmpKYU1aN0NIU1hsUngxWUxjQmN2bThsM2hJ?= =?utf-8?B?cGV4VDIwMG9TYm5ST3VENEdJdGtnZ290NE9uWTVuMHVXaGxxZGpQc1ArMkhT?= =?utf-8?B?c3lleDdWcU9aYXZjVWd0WXEzYUdQZkpFSm5ZdVp4eE5hR1phQTFwT1BJV3Jl?= =?utf-8?B?eFdpcmhsQmY2aFQ5UGVWZkYrZnRWOVBwREZTOFJBVzArTGYyZURrb0lPeVZn?= =?utf-8?B?MjVPbnYyU09IdWFoam0vNlJndGFyTUJIMUpxRy9ZdVN5UkszWUJOa2RPbmRs?= =?utf-8?B?V2dwMitCR1FpQll0NW9nWGJtWkpMK0plT1RLSXBLRFg5NGRzbEN3NDJUdFFu?= =?utf-8?B?bHhaOWpEVjZqd0lYL0FVSkxkV0dVcmk4TURSOFJhdkUwZ2NZL2xBcHViTXFy?= =?utf-8?B?RlhuU215QUFzVjZJU3J0ZmZQK2JDaloxM3dDSFJTNE90WkxIRVkvTzFVWDRx?= =?utf-8?Q?l4lhrR49EcoY8czvBxda9wI=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <9312C2F2CEC1544ABC89467FDEFC2068@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: df3ae64e-eca0-4fa8-3828-08da62a92923 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2022 19:19:50.5046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DIXyn2cNOl0vJ8ABxbn0Lb6IkM438nWHYkFTe1DyRXNjhpXF13+SpkcKFU13Do/VjeCke6SH6PYSlehuo6zt4nyLYxYSBitFdSjbC7JAsOM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB3056 X-Proofpoint-ORIG-GUID: vD8Y23kT6HAateAt--dci38uyPHuKnAk X-Proofpoint-GUID: vD8Y23kT6HAateAt--dci38uyPHuKnAk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-10_18,2022-07-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 spamscore=0 adultscore=0 priorityscore=1501 mlxscore=0 phishscore=0 mlxlogscore=856 suspectscore=0 lowpriorityscore=0 clxscore=1011 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207100088 DQpPbiAwOC4wNy4yMiAxOTozNywgRGVtaSBNYXJpZSBPYmVub3VyIHdyb3RlOg0KDQpIZWxsbyBE ZW1pIE1hcmllDQoNCg0KUGxlYXNlIGFkZCBzdWJzeXN0ZW0gdG8gdGhlIGNvbW1pdCBzdWJqZWN0 LCBmb3IgZXhhbXBsZSAieGVuL2dudGRldjoiLg0KDQoNCj4gVGhlIGVycm9yIHBhdGhzIG9mIGdu dGRldl9tbWFwKCkgY2FuIGNhbGwgdW5tYXBfZ3JhbnRfcGFnZXMoKSBldmVuDQo+IHRob3VnaCBu b3QgYWxsIG9mIHRoZSBwYWdlcyBoYXZlIGJlZW4gc3VjY2Vzc2Z1bGx5IG1hcHBlZC4gIFRoaXMg d2lsbA0KPiB0cmlnZ2VyIHRoZSBXQVJOX09OKClzIGluIF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9u ZSgpLiAgVGhlIG51bWJlciBvZg0KPiB3YXJuaW5ncyBjYW4gYmUgdmVyeSBsYXJnZTsgSSBoYXZl IG9ic2VydmVkIHRob3VzYW5kcyBvZiBsaW5lcyBvZg0KPiB3YXJuaW5ncyBpbiB0aGUgc3lzdGVt ZCBqb3VybmFsLg0KPg0KPiBBdm9pZCB0aGlzIHByb2JsZW0gYnkgb25seSB3YXJuaW5nIG9uIHVu bWFwcGluZyBmYWlsdXJlIGlmIHRoZSBoYW5kbGUNCj4gYmVpbmcgdW5tYXBwZWQgaXMgbm90IElO VkFMSURfR1JBTlRfSEFORExFLiAgVGhlIGhhbmRsZSBmaWVsZCBvZiBhbnkNCj4gcGFnZSB0aGF0 IHdhcyBub3Qgc3VjY2Vzc2Z1bGx5IG1hcHBlZCB3aWxsIGJlIElOVkFMSURfR1JBTlRfSEFORExF LCBzbw0KPiB0aGlzIGNhdGNoZXMgYWxsIGNhc2VzIHdoZXJlIHVubWFwcGluZyBjYW4gbGVnaXRp bWF0ZWx5IGZhaWwuDQo+DQo+IFN1Z2dlc3RlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuY29tPg0KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBE ZW1pIE1hcmllIE9iZW5vdXIgPGRlbWlAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4gRml4ZXM6 IGRiZTk3Y2ZmN2RkOSAoInhlbi9nbnRkZXY6IEF2b2lkIGJsb2NraW5nIGluIHVubWFwX2dyYW50 X3BhZ2VzKCkiKQ0KPiAtLS0NCj4gICBkcml2ZXJzL3hlbi9nbnRkZXYuYyB8IDggKysrKysrLS0N Cj4gICAxIGZpbGUgY2hhbmdlZCwgNiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPg0K PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZ250ZGV2LmMgYi9kcml2ZXJzL3hlbi9nbnRkZXYu Yw0KPiBpbmRleCA0YjU2YzM5Zjc2NmQ0ZGE2ODU3MGQwOGQ5NjNmNmVmNDBjOGQ5YzM3Li4yMmZj ZDUwM2Y0YTQ0ODdkMGFlZDE0N2M5NGY0MzI2ODNkYWQ4YzczIDEwMDY0NA0KPiAtLS0gYS9kcml2 ZXJzL3hlbi9nbnRkZXYuYw0KPiArKysgYi9kcml2ZXJzL3hlbi9nbnRkZXYuYw0KPiBAQCAtMzk2 LDEzICszOTYsMTcgQEAgc3RhdGljIHZvaWQgX191bm1hcF9ncmFudF9wYWdlc19kb25lKGludCBy ZXN1bHQsDQo+ICAgCXVuc2lnbmVkIGludCBvZmZzZXQgPSBkYXRhLT51bm1hcF9vcHMgLSBtYXAt PnVubWFwX29wczsNCj4gICANCj4gICAJZm9yIChpID0gMDsgaSA8IGRhdGEtPmNvdW50OyBpKysp IHsNCj4gLQkJV0FSTl9PTihtYXAtPnVubWFwX29wc1tvZmZzZXQraV0uc3RhdHVzKTsNCj4gKwkJ V0FSTl9PTihtYXAtPnVubWFwX29wc1tvZmZzZXQraV0uc3RhdHVzICYmDQo+ICsJCQltYXAtPnVu bWFwX29wc1tvZmZzZXQraV0uaGFuZGxlICE9DQo+ICsJCQlJTlZBTElEX0dSQU5UX0hBTkRMRSk7 DQoNCg0KTml0OiBXaGlsZSBleHRlbmRpbmcgdGhlIGNoZWNrIEkgd291bGQgY2xhcmlmeSB0aGUg Zmlyc3QgaGFsZiBvZiBpdDogDQoibWFwLT51bm1hcF9vcHNbb2Zmc2V0K2ldLnN0YXR1cyAhPSBH TlRTVF9va2F5Ig0KDQoNCj4gICAJCXByX2RlYnVnKCJ1bm1hcCBoYW5kbGU9JWQgc3Q9JWRcbiIs DQo+ICAgCQkJbWFwLT51bm1hcF9vcHNbb2Zmc2V0K2ldLmhhbmRsZSwNCj4gICAJCQltYXAtPnVu bWFwX29wc1tvZmZzZXQraV0uc3RhdHVzKTsNCj4gICAJCW1hcC0+dW5tYXBfb3BzW29mZnNldCtp XS5oYW5kbGUgPSBJTlZBTElEX0dSQU5UX0hBTkRMRTsNCj4gICAJCWlmICh1c2VfcHRlbW9kKSB7 DQo+IC0JCQlXQVJOX09OKG1hcC0+a3VubWFwX29wc1tvZmZzZXQraV0uc3RhdHVzKTsNCj4gKwkJ CVdBUk5fT04obWFwLT5rdW5tYXBfb3BzW29mZnNldCtpXS5zdGF0dXMgJiYNCj4gKwkJCQltYXAt Pmt1bm1hcF9vcHNbb2Zmc2V0K2ldLmhhbmRsZSAhPQ0KPiArCQkJCUlOVkFMSURfR1JBTlRfSEFO RExFKTsNCg0KZGl0dG8NCg0KDQoNCldpdGggdXBkYXRlZCBzdWJqZWN0Og0KDQpSZXZpZXdlZC1i eTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0K DQoNCj4gICAJCQlwcl9kZWJ1Zygia3VubWFwIGhhbmRsZT0ldSBzdD0lZFxuIiwNCj4gICAJCQkJ IG1hcC0+a3VubWFwX29wc1tvZmZzZXQraV0uaGFuZGxlLA0KPiAgIAkJCQkgbWFwLT5rdW5tYXBf b3BzW29mZnNldCtpXS5zdGF0dXMpOw0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNo Y2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Sun Jul 10 21:55:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 21:55:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364751.594668 (Exim 4.92) (envelope-from ) id 1oAetc-0006ID-Bp; Sun, 10 Jul 2022 21:55:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364751.594668; Sun, 10 Jul 2022 21:55:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAetc-0006I6-8U; Sun, 10 Jul 2022 21:55:20 +0000 Received: by outflank-mailman (input) for mailman id 364751; Sun, 10 Jul 2022 21:55:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAeta-0006I0-2Y for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 21:55:18 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f936e5c5-009a-11ed-924f-1f966e50362f; Sun, 10 Jul 2022 23:55:13 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 02C375C00CD; Sun, 10 Jul 2022 17:55:12 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 10 Jul 2022 17:55:12 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Jul 2022 17:55:11 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f936e5c5-009a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1657490111; x= 1657576511; bh=bYOYM3GJ4HWkYd9UXZfvKiZiP3sprP1rEpmhtfOFK64=; b=j Lqce5XkEg5NecSrWF/ZNV9oQHlQQ3GQwHTc/gapx6tjo0+tJg7/HHKnOK/q52nOi GeRlf+BOrE30UEjcGF9o991q4uADYBGc8s3A0SS4jDNFX5/xroAqHpdz7nszH3pz wj4bVFYHflH4vD+8JF3XXk+evdFsGyPlozvVri/T3vMLpZtM5gcg8et9OU3lp+BD Hz1Gy1fwVdOdXAukQp+Up+qxmCF+oCUW1uyvqbEGPmW/LvPsSq2K4N21IKt8LnLB tMa7XOruY+7+F0UqXrEgHDQ83rF7DKLIp93mQlezxl2WnGWvU5Hzkvvf45V8+mgN 8yQQqmZDKoYx5lbB/6eWA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1657490111; x=1657576511; bh=bYOYM3GJ4HWkYd9UXZfvKiZiP3sprP1rEpm htfOFK64=; b=0as6LkJDhNwIofcsWDFsJRMrgeUub4XTmSzrAHgZp2YHey+HExs h1LIFGSid3YuYbLt1xcMURPi37PC/YYWvG0YFRVypPlKjDrZbz00aorOEhQjgkkH FXaFMsgE3OTaCagnWfl4FiGY6+y07uuAMYx90zW1Db/L2gzhteQbykLJIO4yBrnj 8pKvnlfTuq6cwXKB+HnAtUYAo/LQge5PGXOWuZN+nySxr5bZiTAC7re6TUWS7IG/ xcaTYqyjtyVzlAEoogDL4UBta8gXhUn4Z5dxH9M8u5yPqfDiEZkoskTDUu18j20S L58itg4AlLKu41DqFQzWc1z3n8KBAOAvxNQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejvddgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v10] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Date: Sun, 10 Jul 2022 17:54:37 -0400 Message-Id: <20220710215437.1351-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not INVALID_GRANT_HANDLE. The handle field of any page that was not successfully mapped will be INVALID_GRANT_HANDLE, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Reviewed-by: Oleksandr Tyshchenko Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4b56c39f766d4da68570d08d963f6ef40c8d9c37..44a1078da21b8a2333b4432900a8dbdfb8e13c53 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -396,13 +396,15 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay && + map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - WARN_ON(map->kunmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay && + map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sun Jul 10 22:12:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 22:12:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364758.594679 (Exim 4.92) (envelope-from ) id 1oAf9j-0000OJ-OD; Sun, 10 Jul 2022 22:11:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364758.594679; Sun, 10 Jul 2022 22:11:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAf9j-0000OC-Le; Sun, 10 Jul 2022 22:11:59 +0000 Received: by outflank-mailman (input) for mailman id 364758; Sun, 10 Jul 2022 22:11:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAf9i-0000O5-2y for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 22:11:58 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4ef0db89-009d-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 00:11:56 +0200 (CEST) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26AHXL8e024775; Sun, 10 Jul 2022 22:11:50 GMT Received: from eur04-vi1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2054.outbound.protection.outlook.com [104.47.14.54]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3h71042uju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 10 Jul 2022 22:11:50 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by HE1PR0301MB2393.eurprd03.prod.outlook.com (2603:10a6:3:68::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Sun, 10 Jul 2022 22:11:47 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Sun, 10 Jul 2022 22:11:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ef0db89-009d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nmWy954NtvBhV+7D25hwEgEpRylp4Nyku7Q1LNsX0zupYm2yutdkNzhEZ2A8B2ga9vQ3K0m8U0XDKVvFGgpQ4KjFpafCQ12ZuLvK+JvyukgaznuN5cexQNCWTd1xdRrwMG+7zF7CyjOHZRoMmr08fR7Q7kG1LK/Xycdo07GUa5z2jdjIrPidj6EikwuySI+3xNjHwQMvMZ5h04utupeCU0K2z5/JVZmzzHNBXq/kZAC/ZtMbw2XhBfBrLtyOv4a/NbODRZGZgDo0VVCV6yuefWh29Q6cC1tH/giysvcPpje/NBqzICSeAlvrf7Jj8T+hBOMao42tbhYweZPxpjQ6Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snIwBG6HQyuyLhuLbg2nDk33La6TnIs4V8U4r6xt4Ck=; b=Jd+/SLLIXTRKVS0+KnY1x9tWp3Qmtk0Tkw97Oq1I/VUYvnNKlWUHJrdi7Jubvn1W+pnAsB6DSzFFoAwZZubLDMZn74i0fNE0KKvKlIf9mGgHSpGsexc38IkcSuRhd3cftxXsHcv3IuzacIfNE1TyZiOCHbuP4Wm09fsM1FJBYkV+Gtyis/SGzRlb0BE+XAn5wb0BK/kK8Txb9qfs9UiMxTfVQjlo2PSJe7PhkxPXtF63Mqr55zAWDrTzbxGY3mjxn6Lv4YDJset1QVxZE6TCSq8FTRb15DakTqTkt5Rfs9Jf+JTDvJSahDkJfJCDkG1j9AQd0ZSz4AWVm9ozEatQdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=snIwBG6HQyuyLhuLbg2nDk33La6TnIs4V8U4r6xt4Ck=; b=Vn0vbImaqVrJaL7cH1aV7OIblZOIb3oLkPWHPruAE/2mJqLZvRjqquB6eO/ixMysRwd4HRdif2NlxT4A57Rtqi15L64aP+2r8DoAS0/Jb5oIXNatQmTk76n6dFGsX2q5h7mAiInfeLjHgBES6X3oR8ODUiFa960ECBQM+9QSmCpKTcPSb/1QdrdDUdlwAs+FJGKl7wclfUwy3BtjLqXMJibahSmKdHb5TsfDbt2yodkfmUSFoQjHBtylMkqAW4Hr4OvipyKsuqSSyQ4e4cqFAfRBkE8e1o2LqmDcZ1UI2MQxRfuXwuhcKJowSMsHZLAavC7hn8CCZ8qbEjIeAmJblg== From: Oleksandr Tyshchenko To: Demi Marie Obenour CC: "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Stefano Stabellini , Juergen Gross Subject: Re: [PATCH v10] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Topic: [PATCH v10] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Index: AQHYlKe9qMC33m5o/0mYv55xFOoM+614KsWA Date: Sun, 10 Jul 2022 22:11:45 +0000 Message-ID: References: <20220710215437.1351-1-demi@invisiblethingslab.com> In-Reply-To: <20220710215437.1351-1-demi@invisiblethingslab.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6646e8b-79c1-4dec-138c-08da62c12da3 x-ms-traffictypediagnostic: HE1PR0301MB2393:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8WSw7bqkZPtnRzUY3xAVY8JhnBerTczR8ZJg5ChnWpP5FJK+df/TpbsNfRq4a4bZROPx7NDlZW4BzaQ9LsZCOagRMQvZDXiNrnkdBL1JfGXBSkj2POQbMNeAAjYKYePhi7DGPpUNgpQp7X8huXNzUIOpSd448mPzyP1rHAOIuIR52sRBMUfZ/Yr9KRqLGsBLxKWbROJggN9l3Fjx2PffNJQzLDQJFbfaii+61q8DUOc89zTaU5dvQE78XttXwVo8iN03uTHHAQp63bYlzI58noOF1O35Bd5siouqd/NMddCUVyJuGpdod9YipFjK+H3YVtSvShC5lqxfTloiFWHDZHBy5Av4e2tQF5n3JiiBrWBEMJmtuUyypxYrzeQ8NBoJiQEW2zSxVCj9kDBLLECVCoFL4QvOgqthhzqAGlMkwN76nJ4Yts0ZPIzlUvokRTn/1ba84QheyUChoGo5CXAPuH7SAfoUCPgFf8NL8+1bjP6U4g2OvggZb2OgKmiMBk2GBQ9PI4GhSnlwSk2wbftRgfiA+2jnN+NSjMmDk9XsJNZRv7h82rCUOpAPsZJ4PVVUFlkfx+3lHFwPxuZ8R7OzGZ9VUPZAjSxUzkY+PE+sVZ10e2cPf4H3eMxhjF+ZSIvdFYMffjU2kFekBK/FDcVy5BRsVIYn8okvIoiw2HS0vWrETQPFM+rspLG0rikWWqSd178WyMmCEgTNePqbn3TYLaA3e8XRGgVv2Y2sPGg/pF6F5opKmBSfdmbGJKJmgTmKDA6Dp2Hn3XHsPugk790unjVrmrBV5AfCjKbYRQkGISJPKw4gF6McSdalmMFh/AlBu7kPq0waJI067sBnzTNQsJRPx7lk1FCQKCe5gAPZe6g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(366004)(39860400002)(136003)(5660300002)(6512007)(26005)(478600001)(6506007)(186003)(31686004)(36756003)(83380400001)(8936002)(55236004)(41300700001)(6486002)(2906002)(2616005)(53546011)(38100700002)(38070700005)(76116006)(64756008)(8676002)(66446008)(71200400001)(66556008)(66946007)(4326008)(66476007)(6916009)(86362001)(31696002)(91956017)(316002)(122000001)(54906003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cGpCaTJGZmRWdGxxMDBvdFJVLzdkMVQzZnF1M1Frb2lPQi96b2RobTk1T2lH?= =?utf-8?B?dnd1TzM2MTJKbGJEUlc4dVBkLzM1RW1KbjJOb2x4d1VBZjYrVGtKZDNybU9W?= =?utf-8?B?dmRGa0dDK0RpVkR1enFaWHFpOXJKL3RMdGFUMTdkZThSQjN6blk3UkpaaHJD?= =?utf-8?B?REpILzAwb3V6UWEyeVdrbUFDSUxaNHhLQ0E3TjVTS3J2Z29aUUtjeUFLa3lM?= =?utf-8?B?WURrbkdKd1AwdXlDbDhad0NpazNoSzU2ZzN6UmpsNUNHZWFtOGZMbHQ4OTFX?= =?utf-8?B?aG4xT0FweklQY0NNaXhwbGJkVUp1c0R4VUtoT2R2azlLVVp4THZmRmR6WHJO?= =?utf-8?B?TlJORklHZGRrUmFkL0VsQ0tRZzd0WDBsR0g3Wi9KN3A4NEdsWUh4bXpKYlNu?= =?utf-8?B?eXMxYURGZ1JUVEpWMzkvZCtsMFhYMjRxN3VySnJTQXZYV3pSVVNVTXVRcEJy?= =?utf-8?B?WWdpaTd0bnZjbzNvSnRLalIvM285eWpwTm5LQ3AwdXJKRE9xa1cydXB0Nko1?= =?utf-8?B?K0R1SkQzVno5eWExMmhndmJ6OFlpUm4zUGUvbWpnanRRelZxWS92OXVaemIv?= =?utf-8?B?SDRQaThVQ2pKb0JDTVhJRDdBYjZpSnNMa0FoSWhFc3FNdWtXY1dSUEhHbEhQ?= =?utf-8?B?TFFxMWQ4NlB0WW9yamtwUUFBcnczOTVRaWkrNVJLenJraytqUm16Q0x1Z0N0?= =?utf-8?B?dURmNVh6OEZzNnlxRXEvVjZSL09ZYmRNdDJ3S255QXA3RGo3YmFPaHR2ODh4?= =?utf-8?B?VEI1NmhITFQ4b3NzMUFZallXaGp4K0kyUDRGYlp6L0dOdjBRWTJocklqWVJN?= =?utf-8?B?LzJ4djV4d0F6VC9RUVhFYXZrZDBjU0hDbjhLNGsveGtuR2VxZU9iQ3p3Mnds?= =?utf-8?B?Zm15bDJ1T2V4NFZPd0VidG5aSHNtWWl2NFV2OXhmdUVmVXMrMTg1aThlQlU2?= =?utf-8?B?WXZkaUhxZ09FOGlvTmIzcXlrakdnclAxbWxRMmhhZStRc2VoMUVjODZRNmww?= =?utf-8?B?Q1lNQWFLZ051TEMxd2JwQURqZFNOblVoOFpndytXWFNhUlZJVVM1NXVWQTBD?= =?utf-8?B?anFnYkcvcHdhSEZra3hBaWh0ZWkyMmRUZmlTSnQ5YVNldFlIclJIV1REMm9a?= =?utf-8?B?RWVvNjZSQnErdmx0SWpTN0hPWWNuZ0RlOG5tOFB1eWxPZzJqS3d2OHNYWHRG?= =?utf-8?B?VC9oYVZpMGlPRkJTR2NZVUNSeG1sQVp0SWFSakk4eW5Fdktpek1VUzBFaHBw?= =?utf-8?B?b1BWNlA3eDhmV0dBSldZTDFrN2JZRFl0bGplK285aUFxay9JWWRXcnFRS1Rr?= =?utf-8?B?djc0THhvMjA4QUpQaW9VTEsrazdHK2ZPTnhqZ2RkTDdSRkxDMFJKdVkzbFgx?= =?utf-8?B?aVdhb3RQcnFWUFdOQ2QvR0hOMGdCQ2tLV1d5N2NXWTV4VDF2RWN0K0lyM2J2?= =?utf-8?B?V1FIWFcyYk9lWGFPaEtJVDVrcTg0cEw1c1RLRVBvSVNQWFh4eTZmd21kc3E4?= =?utf-8?B?T0UxK2JRY3p0cXVkL2hJT043bFhVNCtXMGJnb0swbmlkVWs2aFZsL0VGZVRX?= =?utf-8?B?b3VIZmY1Sy8xVnh4aXVtdEdjSlp3L2p4Q3Q0cDJ3Y05JNlVqcHNmWFgvamRJ?= =?utf-8?B?cHhqM3lIbU9qZjBVWkF3VjFzUm9yQ21Uc2k2ZU8waSthZmgxT2FRQ0Y4YjZK?= =?utf-8?B?NU9mempiQ0s5aXA3bThZdHJzdzBsSVJhSTlHQThvVDdqblF4VTVJN3RCVW5j?= =?utf-8?B?ZlNBQnZHRXQzWFZWUmtCb0hIKzNQRHNveUNuR3BzYzFPdVFyY1Frc25vakU5?= =?utf-8?B?dTEyYm5hRFRkcmVGUjg1RHd1cUJjNEtlcVc1a05TVXJOWTYyV01xMzJuR3Ux?= =?utf-8?B?Slo4S2dUMk8vcW5xT0FNSzlId3hwR3NZc3haQ3cvQk5iQ2l0K0hQekFweFJ2?= =?utf-8?B?SVBlSEN0bGlPUWgvVUtMSmpOL3h2Q3V1UXRNKzc3bHd2Qjh5c3ZIVkxyM1ll?= =?utf-8?B?LzZPYUhlWDl1czB2ZVJlbU43U1EzbVB6K3EwZzNBT3FkNE1HZmhSOWJwSjBS?= =?utf-8?B?YVZCZHdLb2xDSTZYdGE0cEJ2dHlUU1RnbzFIWEVkTmlpWmJKR2dLSVVYYWNC?= =?utf-8?B?RXlJQWM1dkthaEdjMXR2Uy9LclRacHpPRzdTVTFJZWppckFLcFd1bWhTa1Jn?= =?utf-8?Q?v28XMbNAFyDg0W8rZ2H2aeY=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6646e8b-79c1-4dec-138c-08da62c12da3 X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jul 2022 22:11:45.9906 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: k0ICk0vAuExrWgB1q42rQJEr+azO4czfCx0u6f1YZZV4qMtme4gjOswHqjvjvf+QtCzDyW+hg4ox6qjCxp1oIgs3D2cXtayyT4/cqcFi6ts= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0301MB2393 X-Proofpoint-ORIG-GUID: sc4AfgFpAWde7QLN2eLTy8qX7tR7QV9C X-Proofpoint-GUID: sc4AfgFpAWde7QLN2eLTy8qX7tR7QV9C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-10_18,2022-07-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 phishscore=0 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 spamscore=0 mlxlogscore=799 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207100102 DQpPbiAxMS4wNy4yMiAwMDo1NCwgRGVtaSBNYXJpZSBPYmVub3VyIHdyb3RlOg0KDQoNCkhlbGxv IERlbWkgTWFyaWUNCg0KPiBUaGUgZXJyb3IgcGF0aHMgb2YgZ250ZGV2X21tYXAoKSBjYW4gY2Fs bCB1bm1hcF9ncmFudF9wYWdlcygpIGV2ZW4NCj4gdGhvdWdoIG5vdCBhbGwgb2YgdGhlIHBhZ2Vz IGhhdmUgYmVlbiBzdWNjZXNzZnVsbHkgbWFwcGVkLiAgVGhpcyB3aWxsDQo+IHRyaWdnZXIgdGhl IFdBUk5fT04oKXMgaW4gX191bm1hcF9ncmFudF9wYWdlc19kb25lKCkuICBUaGUgbnVtYmVyIG9m DQo+IHdhcm5pbmdzIGNhbiBiZSB2ZXJ5IGxhcmdlOyBJIGhhdmUgb2JzZXJ2ZWQgdGhvdXNhbmRz IG9mIGxpbmVzIG9mDQo+IHdhcm5pbmdzIGluIHRoZSBzeXN0ZW1kIGpvdXJuYWwuDQo+DQo+IEF2 b2lkIHRoaXMgcHJvYmxlbSBieSBvbmx5IHdhcm5pbmcgb24gdW5tYXBwaW5nIGZhaWx1cmUgaWYg dGhlIGhhbmRsZQ0KPiBiZWluZyB1bm1hcHBlZCBpcyBub3QgSU5WQUxJRF9HUkFOVF9IQU5ETEUu ICBUaGUgaGFuZGxlIGZpZWxkIG9mIGFueQ0KPiBwYWdlIHRoYXQgd2FzIG5vdCBzdWNjZXNzZnVs bHkgbWFwcGVkIHdpbGwgYmUgSU5WQUxJRF9HUkFOVF9IQU5ETEUsIHNvDQo+IHRoaXMgY2F0Y2hl cyBhbGwgY2FzZXMgd2hlcmUgdW5tYXBwaW5nIGNhbiBsZWdpdGltYXRlbHkgZmFpbC4NCj4NCj4g U3VnZ2VzdGVkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IFJldmlld2Vk LWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+ DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IERlbWkgTWFy aWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBGaXhlczogZGJlOTdj ZmY3ZGQ5ICgieGVuL2dudGRldjogQXZvaWQgYmxvY2tpbmcgaW4gdW5tYXBfZ3JhbnRfcGFnZXMo KSIpDQoNCg0KTmV4dCB0aW1lIHBsZWFzZSBhZGQgYSBjaGFuZ2Vsb2csIGFsc28gSSBhc3N1bWUg Y3VycmVudCBwYXRjaCBvdWdodCB0byANCmJlIHYyIGluc3RlYWQgb2YgdjEwKQ0KDQoNCj4gLS0t DQo+ICAgZHJpdmVycy94ZW4vZ250ZGV2LmMgfCA2ICsrKystLQ0KPiAgIDEgZmlsZSBjaGFuZ2Vk LCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL3hlbi9nbnRkZXYuYyBiL2RyaXZlcnMveGVuL2dudGRldi5jDQo+IGluZGV4IDRiNTZjMzlm NzY2ZDRkYTY4NTcwZDA4ZDk2M2Y2ZWY0MGM4ZDljMzcuLjQ0YTEwNzhkYTIxYjhhMjMzM2I0NDMy OTAwYThkYmRmYjhlMTNjNTMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL2dudGRldi5jDQo+ ICsrKyBiL2RyaXZlcnMveGVuL2dudGRldi5jDQo+IEBAIC0zOTYsMTMgKzM5NiwxNSBAQCBzdGF0 aWMgdm9pZCBfX3VubWFwX2dyYW50X3BhZ2VzX2RvbmUoaW50IHJlc3VsdCwNCj4gICAJdW5zaWdu ZWQgaW50IG9mZnNldCA9IGRhdGEtPnVubWFwX29wcyAtIG1hcC0+dW5tYXBfb3BzOw0KPiAgIA0K PiAgIAlmb3IgKGkgPSAwOyBpIDwgZGF0YS0+Y291bnQ7IGkrKykgew0KPiAtCQlXQVJOX09OKG1h cC0+dW5tYXBfb3BzW29mZnNldCtpXS5zdGF0dXMpOw0KPiArCQlXQVJOX09OKG1hcC0+a3VubWFw X29wc1tvZmZzZXQgKyBpXS5zdGF0dXMgIT0gR05UU1Rfb2theSAmJg0KPiArCQkJbWFwLT5rdW5t YXBfb3BzW29mZnNldCArIGldLmhhbmRsZSAhPSBJTlZBTElEX0dSQU5UX0hBTkRMRSk7DQoNCg0K cy9rdW5tYXBfb3BzL3VubWFwX29wcw0KDQoNCltzbmlwXQ0KDQoNCi0tIA0KUmVnYXJkcywNCg0K T2xla3NhbmRyIFR5c2hjaGVua28NCg== From xen-devel-bounces@lists.xenproject.org Sun Jul 10 22:45:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 22:45:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364767.594690 (Exim 4.92) (envelope-from ) id 1oAfgE-0003xS-Gi; Sun, 10 Jul 2022 22:45:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364767.594690; Sun, 10 Jul 2022 22:45:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAfgE-0003xL-De; Sun, 10 Jul 2022 22:45:34 +0000 Received: by outflank-mailman (input) for mailman id 364767; Sun, 10 Jul 2022 22:45:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAfgD-0003xE-JW for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 22:45:33 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff9dc0ff-00a1-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 00:45:31 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657493127012599.1201374894324; Sun, 10 Jul 2022 15:45:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff9dc0ff-00a1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657493127; cv=none; d=zohomail.com; s=zohoarc; b=JAdxft4U/dGl7G2NbS3oW4Fm53+YpdXMX9q7j08jNY/vDWklWAeDxjISA7Pem+4w+XeuNx6K+JUlZ0VjVPdQBEO073sE2qIRfVE2bTLuLQxiMrv8wdavgl5tdAGMLpPJ4lpExY6m//fCoXjeAzbx8WfMYisQyYXc2EA0P/wtg7k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657493127; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:MIME-Version:Message-ID:Subject:To; bh=Oqn85uxt8exJ+v7wpy4rjqedf0idozszMXWwTlRgr2A=; b=JWktB5YXOIgawFPzFlzW5UzzMA0iSHeltib/KbAv0skR002GejT63SRynBe677H9gme4Y5SLhZPbRobUiTXgJNjpIK9Z9W31OjGoZ6yc0s3KOU/dmJkWL7VUqt+u0s4QegL1tkBeJZ99GFdc5ZeKU0f9V1c9BLR2+jyrXYi7EdE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657493127; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:From:From:Cc:Cc:To:To:Subject:Subject:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=Oqn85uxt8exJ+v7wpy4rjqedf0idozszMXWwTlRgr2A=; b=LPSu2bN2zagJxlJ9BL8/3suENeF0ZL0VTg6l162uxm60TVi0YfXb7TZppTEbgkgi HCXv3TeyXaxpm9CIaJmAZo7P7wyboRFiHULM30jo6mmi0qMcjvSDzoIaZ+RDtC6k+SK riZLD+XUUQjIW6FM5DgEEv+cm51E7X0XXF3yFgI0= Message-ID: Date: Sun, 10 Jul 2022 18:45:15 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US From: "Daniel P. Smith" Cc: Julien Grall , Bertrand Marquis , Stefano Stabellini , Christopher Clark , Rich Persaud , "Smith, Jackson" , "Brookes, Scott" , "Lei, Jason" , Scott Davis To: Xen-devel Subject: Hyperlaunch Working Group: Status and Next Steps (15JUL22) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External Greetings All, We will be holding a Hyperlaunch Working Group meeting on Friday, July 15th at 0900PDT/1200EDT/1700GMT. The agenda will be ready by Wednesday and can be found at the below cryptpad link. Call-in details will be published in the agenda once it has been set up. Agenda: https://cryptpad.fr/pad/#/2/pad/edit/0uw06jY29gjSJMxs8Q9CWipp/ -- V/r, Daniel P. Smith Apertus Solutions, LLC From xen-devel-bounces@lists.xenproject.org Sun Jul 10 23:06:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 10 Jul 2022 23:06:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364774.594702 (Exim 4.92) (envelope-from ) id 1oAfzn-0006WF-5F; Sun, 10 Jul 2022 23:05:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364774.594702; Sun, 10 Jul 2022 23:05:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAfzn-0006W8-2N; Sun, 10 Jul 2022 23:05:47 +0000 Received: by outflank-mailman (input) for mailman id 364774; Sun, 10 Jul 2022 23:05:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAfzl-0006W2-O0 for xen-devel@lists.xenproject.org; Sun, 10 Jul 2022 23:05:46 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0a961c8-00a4-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 01:05:42 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 0733C5C010F; Sun, 10 Jul 2022 19:05:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 10 Jul 2022 19:05:39 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 10 Jul 2022 19:05:38 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0a961c8-00a4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm2; t=1657494339; x= 1657580739; bh=f9bSjqSEnIXH1UABF2q7HoN67rLpDoOJdF+QGXn1KUY=; b=n ImRps3NNA9r8Ob0rontYzLsDJVt0ZKLdUPlwsX95x6GpbRD6x7Lyn02YYRWcPfYL 0VB408VfRNmsr7fuMixiDSJwzLQyGX6MyZgJHVZs1/aRPXq4IQi+ToW9sgeLHC9r 3K4OlkDn1n9DDTGW/BcRQZFjZRxwVsJNilVdcAgTFAxSTMjlH2qCbfItNvJ5LN97 83Z+wBkAHz6Zh8Nn93mhQxkpY1bQHO/H1wI1+TTIM00Nf+lb6a+g3DJUbt6YtT9P hI1VuWdLykvFiSBM6s+sIIYmcpm9Zg/ufniYgw50zJLNDfWxBpUc388JdyG1RHCi pzlxG/mF50z8cuOY+iFjA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1657494339; x=1657580739; bh=f9bSjqSEnIXH1UABF2q7HoN67rLpDoOJdF+ QGXn1KUY=; b=alILd2VqdjjP7T0DMJumMBXvyb06DgdGontjC9CN3A+FDaaueyI xVrkIj4AeGQOcN651bBOBMgm+ZVqCW0xNBNjdSS1aFkl30TLmV0/reDYtKe9EMvR ptroAa1dMqCNnif0v6TbAJMHh9OsQrN6nxSDioemRAzFhc2rEOq2oyCD+j7Ixp3T pCD2m3czGe0Yk3FHgfQn7MKYgQySVfQ5aivwMpIjaK99ZQFzooArZGBHxbp3jhf3 g/tzSzKRwTElGqtf9VHWQWP8thKU4Y3cFYPWCTrsFxlTCPKob8raooKgyBf6jU3c lI8sXehCvrvYYAUinIl7tBTgghiQ2yTspvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejvddgudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Date: Sun, 10 Jul 2022 19:05:22 -0400 Message-Id: <20220710230522.1563-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not INVALID_GRANT_HANDLE. The handle field of any page that was not successfully mapped will be INVALID_GRANT_HANDLE, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Changes since v2: - Use unmap_ops instead of kunmap_ops in the first WARN_ON Changes since v1: - Explicitly check for a status other than GNTST_okay instead of implicitly checking that it is nonzero. - Avoid wrapping a line as within a comparison, as this makes the code hard to read. diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 4b56c39f766d4da68570d08d963f6ef40c8d9c37..84b143eef395b1585f3a8c0fdcb301ce9fbc52ec 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -396,13 +396,15 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset + i].status != GNTST_okay && + map->unmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE; if (use_ptemod) { - WARN_ON(map->kunmap_ops[offset+i].status); + WARN_ON(map->kunmap_ops[offset + i].status != GNTST_okay && + map->kunmap_ops[offset + i].handle != INVALID_GRANT_HANDLE); pr_debug("kunmap handle=%u st=%d\n", map->kunmap_ops[offset+i].handle, map->kunmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 11 00:05:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 00:05:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364784.594713 (Exim 4.92) (envelope-from ) id 1oAgv4-0005AL-Mg; Mon, 11 Jul 2022 00:04:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364784.594713; Mon, 11 Jul 2022 00:04:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAgv4-0005AE-Jk; Mon, 11 Jul 2022 00:04:58 +0000 Received: by outflank-mailman (input) for mailman id 364784; Mon, 11 Jul 2022 00:04:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAgv2-0005A4-Tg; Mon, 11 Jul 2022 00:04:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAgv2-0004MA-Pv; Mon, 11 Jul 2022 00:04:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAgv2-0008PH-7p; Mon, 11 Jul 2022 00:04:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAgv2-0000tn-7M; Mon, 11 Jul 2022 00:04:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xtjMkaXJnpcRNNw6kJVxaBcIkZAFgrfoVq7UF/4QLO8=; b=2c1UwmAOcATfMnTzeazOeZv8k9 ilmzRA+m4rMbe+QibC+NmgSOsYD2l++/S91QfW1b7nsuaYnW+GxAVb8M2Tqfctsh6t7Loei+oOJu+ FZaulPYREtJSEjXEosUp3ywqiioOCq2UYXA0nSkOLtVb6U1tnwqmIfFwQp8GXmxh0wnI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171576: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=952c53cd357c71338a59d444933ed48a879229e1 X-Osstest-Versions-That: linux=354c6e071be986a44b956f7b57f1884244431048 From: osstest service owner Date: Mon, 11 Jul 2022 00:04:56 +0000 flight 171576 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171576/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171277 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171277 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171277 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171277 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171277 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171277 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171277 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171277 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 952c53cd357c71338a59d444933ed48a879229e1 baseline version: linux 354c6e071be986a44b956f7b57f1884244431048 Last test of basis 171277 2022-06-19 03:11:35 Z 21 days Failing since 171280 2022-06-19 15:12:25 Z 21 days 58 attempts Testing same since 171576 2022-07-10 19:09:30 Z 0 days 1 attempts ------------------------------------------------------------ 575 people touched revisions under test, not listing them all jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 354c6e071be9..952c53cd357c 952c53cd357c71338a59d444933ed48a879229e1 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Jul 11 04:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 04:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364804.594724 (Exim 4.92) (envelope-from ) id 1oAlRi-0003AV-8y; Mon, 11 Jul 2022 04:54:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364804.594724; Mon, 11 Jul 2022 04:54:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAlRi-0003AO-5I; Mon, 11 Jul 2022 04:54:58 +0000 Received: by outflank-mailman (input) for mailman id 364804; Mon, 11 Jul 2022 04:54:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAlRg-0003AE-E4; Mon, 11 Jul 2022 04:54:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAlRg-0004F0-BI; Mon, 11 Jul 2022 04:54:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAlRf-0006UQ-QS; Mon, 11 Jul 2022 04:54:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAlRf-0004Cm-Q1; Mon, 11 Jul 2022 04:54:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KRRr9/L81b98aKJjLHuSm2fgmUD3xORF2lj7ZWPTLNI=; b=y1+qLqChLWqragITcMbYVes7p5 l5hedxACcnSCubd7x7CcOBzuh58+JbX8IY2lNUXfAcMlP2Y0Hab4Ii65+mh1WrOM937cuzbmH8Oea 7Qb+kkPySBm/hCBPindLiO/eQXtEgCM9nsfRrCVLsMrYBodCwHV6517jsWTZtW64DgkA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171577: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=32346491ddf24599decca06190ebca03ff9de7f8 X-Osstest-Versions-That: linux=952c53cd357c71338a59d444933ed48a879229e1 From: osstest service owner Date: Mon, 11 Jul 2022 04:54:55 +0000 flight 171577 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171577/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171576 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171576 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171576 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171576 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171576 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171576 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171576 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171576 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 32346491ddf24599decca06190ebca03ff9de7f8 baseline version: linux 952c53cd357c71338a59d444933ed48a879229e1 Last test of basis 171576 2022-07-10 19:09:30 Z 0 days Testing same since 171577 2022-07-11 00:12:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Gordeev Linus Torvalds Oleg Nesterov Peter Zijlstra Sven Schnelle Thomas Zimmermann jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 952c53cd357c..32346491ddf2 32346491ddf24599decca06190ebca03ff9de7f8 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364812.594735 (Exim 4.92) (envelope-from ) id 1oAmft-0003Ub-3n; Mon, 11 Jul 2022 06:13:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364812.594735; Mon, 11 Jul 2022 06:13:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmfs-0003UU-Uu; Mon, 11 Jul 2022 06:13:40 +0000 Received: by outflank-mailman (input) for mailman id 364812; Mon, 11 Jul 2022 06:13:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmfr-0003UO-UH for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:13:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a667494-00e0-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:13:38 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E22562271C; Mon, 11 Jul 2022 06:13:37 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A8C4813322; Mon, 11 Jul 2022 06:13:37 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Tb/LJ5G/y2IUbgAAMHmgww (envelope-from ); Mon, 11 Jul 2022 06:13:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a667494-00e0-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657520017; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRux010CJbn92hHj/3FewkdNUmCFo5A2COG23gOjC+4=; b=RWbYB8yADxXJqO4bqj2C5lsm+an+68LmCd0x+R9EWm99QH6+tvFRiioynsogw2+WVF4r0U dIQSJNMTwFAC52duPI6etuX99dOjdZuRqIeCf0uPgQOAN5+NZ4S69rxJSMop/UBw0sFgpm 7dMYfr2PzYzuMqcU2OJrYtHnHAi/f/0= Message-ID: <13bad947-17da-f2cf-1fa3-a8db8c3b0778@suse.com> Date: Mon, 11 Jul 2022 08:13:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] xen/cmdline: Extend parse_boolean() to signal a name match Content-Language: en-US To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20220708161934.10095-1-andrew.cooper3@citrix.com> <20220708161934.10095-3-andrew.cooper3@citrix.com> From: Juergen Gross In-Reply-To: <20220708161934.10095-3-andrew.cooper3@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------xV9hNAVrvseUBjAk2tk3gB8z" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------xV9hNAVrvseUBjAk2tk3gB8z Content-Type: multipart/mixed; boundary="------------rQlnxSoOg1WQ0IMI4pvohMNm"; protected-headers="v1" From: Juergen Gross To: Andrew Cooper , Xen-devel Cc: George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Message-ID: <13bad947-17da-f2cf-1fa3-a8db8c3b0778@suse.com> Subject: Re: [PATCH 2/3] xen/cmdline: Extend parse_boolean() to signal a name match References: <20220708161934.10095-1-andrew.cooper3@citrix.com> <20220708161934.10095-3-andrew.cooper3@citrix.com> In-Reply-To: <20220708161934.10095-3-andrew.cooper3@citrix.com> --------------rQlnxSoOg1WQ0IMI4pvohMNm Content-Type: multipart/mixed; boundary="------------786ARqgJnwJkiEFBcYHHn4pP" --------------786ARqgJnwJkiEFBcYHHn4pP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDguMDcuMjIgMTg6MTksIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+IFRoaXMgd2lsbCBo ZWxwIHBhcnNpbmcgYSBzdWItb3B0aW9uIHdoaWNoIGhhcyBib29sZWFuIGFuZCBub24tYm9v bGVhbiBvcHRpb25zDQo+IGF2YWlsYWJsZS4NCj4gDQo+IEZpcnN0LCByZXdvcmsgJ2ludCB2 YWwnIGludG8gJ2Jvb2wgaGFzX25lZ19wcmVmaXgnLiAgVGhpcyBpbnZlcnRzIGl0J3MgdmFs dWUsDQo+IGJ1dCB0aGUgcmVzdWx0aW5nIGxvZ2ljIGlzIGZhciBlYXNpZXIgdG8gZm9sbG93 Lg0KPiANCj4gU2Vjb25kLCByZWplY3QgYW55dGhpbmcgb2YgdGhlIGZvcm0gJ25vLSRGT089 JyB3aGljaCBleGNsdWRlcyBhbWJpZ3VvdXMNCj4gY29uc3RydWN0cyBzdWNoIGFzICduby0k Zm9vPXllcycgd2hpY2ggaGF2ZSBuZXZlciBiZWVuIHZhbGlkLg0KPiANCj4gVGhpcyBqdXN0 IGxlYXZlcyB0aGUgY2FzZSB3aGVyZSBldmVyeXRoaW5nIGlzIG90aGVyd2lzZSBmaW5lLCBi dXQgcGFyc2VfYm9vbCgpDQo+IGNhbid0IGludGVycHJldCB0aGUgcHJvdmlkZWQgc3RyaW5n Lg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4NCg0KUmV2aWV3ZWQtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNl LmNvbT4NCg0KDQpKdWVyZ2VuDQo= --------------786ARqgJnwJkiEFBcYHHn4pP Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------786ARqgJnwJkiEFBcYHHn4pP-- --------------rQlnxSoOg1WQ0IMI4pvohMNm-- --------------xV9hNAVrvseUBjAk2tk3gB8z Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLLv5EFAwAAAAAACgkQsN6d1ii/Ey9m lQf/YmBptBcbt3J0jQ4t70sC14zeO/tI+zQk+OcxeQc7zTErNI5hVbJINQDu+ZKB5F6sxtm8fTCj Ud3WeTSrYHRImuH4eM2PwWeRZWanTOSp7lxE9vQYiO0iZ6G7Xd0SnVFpi3cl4dYQLNKGXkamJDEg /Qcpu93t6xBsb5iuxkVd6MzSNkt8zO7YRX3a4Qs+VciMmOQMLHBuDDVGN1D1PHcSmaWgagX5K591 q9dzrJs7RichVYnpetlATaAaJR8FCUKp2fc3k7Ey/BS7R+OlNqD7wYekv8+/t3iV4e1E3lhQAxgy JjaMv+7urKAV96y+8vRU+9qs1zOMirpg8rzhMWvyWg== =PwxM -----END PGP SIGNATURE----- --------------xV9hNAVrvseUBjAk2tk3gB8z-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:23:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:23:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364819.594746 (Exim 4.92) (envelope-from ) id 1oAmpH-00053a-VJ; Mon, 11 Jul 2022 06:23:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364819.594746; Mon, 11 Jul 2022 06:23:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmpH-00053T-Se; Mon, 11 Jul 2022 06:23:23 +0000 Received: by outflank-mailman (input) for mailman id 364819; Mon, 11 Jul 2022 06:23:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmpG-00053N-MY for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:23:22 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70052.outbound.protection.outlook.com [40.107.7.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f5ff674b-00e1-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:23:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3597.eurprd04.prod.outlook.com (2603:10a6:803:e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:23:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:23:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f5ff674b-00e1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jhSHoZmhQhRglT19ftCdng2WVY4tahoP7qPq18q/uRsWxbcJpIALX6P8Sa0pF3kqODJpRw27YpLpQKtoWYTeSNGEQdRIAX7XEVcDd0qSzhQjfZR0ap3hNAtU19ldq/3hOWj0rw+CxRdJehGOrEBJ7nzq9eXu3On/2StTrDhDsR+nt1221zGAdZ6yP1fJK6QPcjomHM6eyal3NTh5e+rq+cWPpAFkA8w3uMZC+BGwV0u+fihKfHtLhUvSr1DmI/Sw6sMyneH4HtJXqfphTFA3mizsJdG3phskgCNdTxFTF73Py2bNrcLUIdbgNhWJshDtxwHplRSbumqCnbX8f3nGMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FvwOenxpweemvxGZJcNdvRtzt0jhCyCzSNMC8WbtXDY=; b=fvcT6zY0KzxxUthjNUgAyYJquC1RkcBcLENlP6u//z//HI/KSYHCxZRlgudKN/gO03xgAWiiKDsXyFcQYrYOyhn08QJBZkYZDrWITIr1D8RZK+mr1jWLdjg4jbDt6Sf4rvpApECrpatxzTIEROjRFhPYaPpYdu5SJlGoPZVvFzdsLTs7RMMTYj1kHrNX18hm8NWWgfS8DsRffqRidXC8PrQs29Ls5xt+8ei75WE/Gx+alsUW/1uhuO9wQkqfiA/6/AHOEFFsJuTplAPc/Hmkva+q51D94S+Ak3LRI6xf/7FAceMK4cQ9wBnF/3l9f3f1jJlfglhXOtAwXb9L1L++zw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FvwOenxpweemvxGZJcNdvRtzt0jhCyCzSNMC8WbtXDY=; b=gXKOaYBEtu3PTxrGQ7CpfohyRh/G+bvsN1mUOmsgn8zaaKLtPcc6a37nYyurQNUZAFjV4leiTVdf7j/i1g27rVZ1NkoncOmhEb6gr44jrj71Bm/Z9Kha3LhrEwU686AhT26aBj+I0eo+XSKrMO+Vyy2ojUdU5npt+7vZBsRXkuBAQbXS6P1Zl/04ETfL6NrhNnb8gr8uonGzrAd3RONymD/aARCW+cwR6uF+4WwEpbYMXIkcXwRYIj1jSKw5SJJbBxwXwGQBM8NrPsu69ND0jDpwZJmblqADfHSkpU/48Txwpd3gVzAgwhP3HtnmpaHUdU0GaaYfhjAwm2hVOMuUFg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <042fa7b8-5262-f772-9b31-93b56ef01474@suse.com> Date: Mon, 11 Jul 2022 08:23:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v11 1/2] xen+tools: Report Interrupt Controller Virtualization capabilities on x86 Content-Language: en-US To: Jane Malalane Cc: Xen-devel , George Dunlap , Nick Rosbrook , Wei Liu , Anthony Perard , Andrew Cooper , Julien Grall , Stefano Stabellini , Juergen Gross , David Scott , Roger Pau Monne , Jun Nakajima , Kevin Tian References: <20220708135559.30719-1-jane.malalane@citrix.com> <94eb45a6-7c84-6b6a-e5c1-e2ced336e675@citrix.com> From: Jan Beulich In-Reply-To: <94eb45a6-7c84-6b6a-e5c1-e2ced336e675@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR07CA0056.eurprd07.prod.outlook.com (2603:10a6:20b:46b::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a1801e1-6b27-4e5d-2188-08da6305d900 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3597:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MwDdJLlq4xYQP7hVb2uHKCur7PGA1VdsqdJ+BueXEJ3NexJugMDyHf4OiueQVaGlUh2WnKRAuunItbdmbKYWDOTZaErjWtzoTet4aR3fmIrJv5+iM3YreJ1cr6cEduANV44dAYrGuWLl6LYROU/V/0Ou2O6l+yz6ztCetPomNPwFxaPsscljn5z4tPTZ/grR5BMAPhqexY2l0ydqGL/VGgekeGQt1Tds6p/TUQcv0ct5JrbA/C2yMrP+5w5K2XWFg6MYKjTaASAT+4LOudw3xN9FItZjeMv1qsw/Z8M/57sveRwRBcH1JZo3t4kbi6d9flVoJMFTz2JHA/P+i8KRWXos8icUf9imoUh2i+Jj1Z8YhN6UmF3OkZddg/NhM4LQVwtihwZmkBC3TtTNTzz0eukNJ4pbLfyI1NCFiaDmHuhMAdvV1TpQvSX87u9dxe7JVdVrLXQoJCloTIku+er7pKc+nVamnMLXbNbEE0I5sE9T2AdszJFBAImu5UQ4F7x3V2xbpHfXtrka8XI79hrBRZzNZOXAYoxqF4HbgbNXYrM+VZvKqzW3Z5ug8qrOvZQuFNdC9e5LGk7JqxX7lx/EVNA5RzDO0p40TtXCPU+aD/gJddYN8NJ21S2oMkdFFbrBekJFYaZeXgexeBbmppCtavlqKjd9ns7iM3NN1qSDxkjuyyEf9EWdfazg/p58tHnWlxKp5s1WXYPRZEjJUNjF9do0JHNy28wj9Ch2b+HSLvXpjqsPK/al6ynruDac1PTNxpZa/LQr2Tj/nGrNCZAKN5t8qNqoCwyeZMgqAIhRY3TrQ1KkB9FsINShRexqKIi3Pn+g6Wn2sOQNqUrM/lg7sqSG9fH6SACcJFsly6ZUFdc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39850400004)(136003)(366004)(376002)(396003)(346002)(66476007)(66556008)(83380400001)(66946007)(86362001)(4326008)(8676002)(53546011)(31696002)(4744005)(41300700001)(2906002)(6506007)(186003)(6486002)(6512007)(5660300002)(26005)(316002)(8936002)(7416002)(31686004)(38100700002)(36756003)(6916009)(2616005)(54906003)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjR3R1ZCTWluNDg2M3dwbnFKY1gydklaOHlXOE9CVzllVGQrOExZWG9lMDNO?= =?utf-8?B?YzRnbFZuUk1NQnhUWXBpZ0JEeFArRHBHQzJHcWpvaGpUbk94Zk9CZ2RUWldq?= =?utf-8?B?cjRsa2o3M1hJcEFjUGlzZ2d6UlNQc3V6cW5JckI1cEFCYndXckF6YlpqTUF4?= =?utf-8?B?cU0wM2RPeG9vcHBLNUtIZzREVUFTWHhsbzV1NTkyYWdaUHpURlF1Y0dkZjhr?= =?utf-8?B?UnRRTVhUaE4zVHA0Y1pYMGtsQnVFeEFIVSsrSU1TcnJZd0VUS3JmaGlSVGhI?= =?utf-8?B?RVlwayszWGNsYkY0VzE0bnM4WkpZeUZSR1NBMlFjUDNtZWg4T0xSdXFPL0o4?= =?utf-8?B?UUZTWUwwNkZQODVLZi9yVE8xUE8veXhQL3h3K1JXZmVSQks1WTR4Qlh0b3VG?= =?utf-8?B?Yi9takNiNEdTS0ExRjNsOTFoSnlTMU42UUpzQ3VzQ1NlaWdxcGRHNy9mU3B6?= =?utf-8?B?N2xwb1FWVlhlY0RwOThYV3hheG5RQWtlVmw1QVByakN5ajVSR1JuNVdLNFlK?= =?utf-8?B?WmxKOWRaVERKa3A4TEZHTGozQUk5UUx6YUhMdVBqUjRjZEZ3bXA1VUliRytz?= =?utf-8?B?R09XQ1JmSC9SamdMUlRzVnpsaHB4RS83cllPeXRNaHZxeHRvRXpNR3grdU9W?= =?utf-8?B?YXphZ0hZYlFpbGtWMGpoNm5rcG5YOHVDdUhjVmh6OFQxUGQwbFRLV1E4Q1lv?= =?utf-8?B?dWFZc3o5THhlY1BCd29PbHJNclFqTjdBVWRlclZlOGtvMVNZMDRkd2NSWmNO?= =?utf-8?B?MmxxNUp1UTdOaHp0TkxYN1hyaGR5M1Z2RzFhSWVBMDBhUDdoZlNaV0lkbFA3?= =?utf-8?B?d0JtcU5paTNjV0RGT1pYWkFMZW5Qd2pFVzVVQmhMc0ozS2VwRUJPRVcyQ2kr?= =?utf-8?B?bXgxbTUzTmNNbk00c3ZVU2w3c3FNQlc1MVlFV1J4NHVVdmRtRkFsN2RtVy83?= =?utf-8?B?Y3Bqc2trcVUxWkQyemEzclY2Sk5DVVJ3azhLZnM5dU9Gdi91S2hDNzdhaFZL?= =?utf-8?B?RnNiVDJQaHdRZU1KSHkwZ3Vxc2hBQWVUcFVHaXJUR1o3SnMyaDNGWFVHaWFG?= =?utf-8?B?TU54WlJNdjlhTEs3UVpvdURLVXRJYk5ia2t5Mk9RRzNJZTV3TUFwOTB0d1RX?= =?utf-8?B?NFp4bnVQMTRkUHlDUXBmdE4wMEhmNUx1SStwbS8zOVB0d0M0a2ZxeUFNcklZ?= =?utf-8?B?Wk0xWVBUSTBBMTdWWjFQM1d4Qmw3aGpKRFR5NU1jUlNtRFdYeEdwWHFDZGI2?= =?utf-8?B?MFlrR3BrcTI3QklWT3c4YUJhTHpFOFNwdU0yaDJTei9pNFNKbGRJODFWQlJH?= =?utf-8?B?cHVsSnFzcTF4RWQ2VkJxbXZUUnFGYkZpKzF5L0I1bjRhTDBqdis3SnNraUJj?= =?utf-8?B?RTFwQko3UlA1YVArSUYvWDJDUVMwLyswN05RY2VWN0dFOElYZWNDTXBObG1Q?= =?utf-8?B?cXBYdFd3Q0F4dzAwNk82dzRFdFZKdTQxSzhJajlMaUp6bHlCOU5SVEtPNHhz?= =?utf-8?B?VHY3RlFRS0NYYTQvNTYrQnZRNmZlczRlZXVxTDZWSnpPSFBlS2F2YlhDOS8x?= =?utf-8?B?Vm1CMmpmS0crczlwSmpKWHNFM1V3Zlh2eGp6Wm1aSlFaUzRwNURWUyttdnZy?= =?utf-8?B?dVRVVEs5d05ZRi8wajlvcEc3OE0wVUpJK3ZxdytsQ1pvT3dYdUg0S0ZvVW9X?= =?utf-8?B?ektKU0JxYnI1R3hqMXZGSUtNQ0NTaUVJZGo4bU5NRytSVG5CeFIvRmk3WG9L?= =?utf-8?B?UDdjblVOd1pwZVpPZUYwaTUxYmFxUDU2UUZFaWFrVDBweGorc1YrRUVSYnF5?= =?utf-8?B?M094aUYvMVdkLzVTZDlIVzZjMXBXMzBGdllUdk15UDNVbEt1ZkhuTEhzZEYv?= =?utf-8?B?S25MUm5hMUN4Q2laVnUxa01jTXdNbDNYN0VCdDJHWjd6UVFsdVpSNTR0NDFv?= =?utf-8?B?YlRhcjk4V0pmRnBoZ3JQdFpkVzR6aVB6L1FiaU95SlY5T0lzUjdSM3pBbDNm?= =?utf-8?B?c0M5VDBpazQ3TzJCWGNrUitYa1ltcm1TQkxiVEwvRkhhdFRpMWsveEJ2ZHBZ?= =?utf-8?B?Wnd5bDFYbU55a0RGZTd6ZXZEM0ltZWVadVBxcXY0MWRCKzB2TW10TGc0V3NC?= =?utf-8?Q?Dej/jAAmW6kwWBZYLjnD5HqDI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1801e1-6b27-4e5d-2188-08da6305d900 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:23:19.4403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ldcl0oO/a9Q+8dvAeZl/43raBYebXeJIMwVKB12BduhQw/kt/cxlU2xTSdTxVBRBYBYL2FSiFt2bybXMGuSwJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3597 On 08.07.2022 16:42, Jane Malalane wrote: > On 08/07/2022 15:33, Christian Lindig wrote: >> On 8 Jul 2022, at 14:55, Jane Malalane > wrote: >> >> tools/ocaml/libs/xc/xenctrl.ml | 9 +++++++++ >> tools/ocaml/libs/xc/xenctrl.mli | 8 ++++++++ >> tools/ocaml/libs/xc/xenctrl_stubs.c | 18 ++++++++++++++++— >> >> Acked-by: Christian Lindig > > > I believe I now have all the acks needed for this patch series. > Regarding the commit message of patch 2, I thought that explanation made > it clearer but I can always remove it. I haven't seen v11 2/2 anywhere, so I'm afraid I can't check what you're referring to. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:27:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364824.594757 (Exim 4.92) (envelope-from ) id 1oAmt1-0005gO-Fp; Mon, 11 Jul 2022 06:27:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364824.594757; Mon, 11 Jul 2022 06:27:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmt1-0005gH-Cq; Mon, 11 Jul 2022 06:27:15 +0000 Received: by outflank-mailman (input) for mailman id 364824; Mon, 11 Jul 2022 06:27:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmsz-0005gB-CR for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:27:13 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f7205f6-00e2-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:27:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2916.eurprd04.prod.outlook.com (2603:10a6:203:9d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:27:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:27:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f7205f6-00e2-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y1PAAqTpvpjrTe1FNqZZELMdSSPZnmrx+ZrkA60ABV3ywbfd4OU+SNB5gy/Q1Ji1MAbLD896pHG86b9k7IBVSgQ2LdinMmXP0EbtIEpXyQ7DNHQ9LdUayWYjttbQcUTjV0vrGSQ8JHS0GicQyswf/eFmmxFcxjwVW8MxK6TQAkmwzu2iB/Kkr81vxozMdPqGW6/GkVpNDebvmb6sb/s+pjKk7XYGnaYw/8CugGEkqgnU3oCGGkevuWx2M+4CArFXaphzw+g0G7xw6FvS3T8CD9G9BPWseYK3NACI07AMtD/X5otQ/EzbJLphCbdibLMuULpF/q97GwaJM6OyJ+A1yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pWLBQmHfGuHpotrsQwgdjey05YgjSg/pkJoyOWwi5j8=; b=Qq6Lh57Fqzy0WmGg1tbofD10t5ADjSyfXtbJ71fOIR9o35kBiQfqdSCaylF4C+GBS/43Xnc8wFHutNmajgT42xcqLGlXi3YWGmsT9z+JWktTwrQeLLzsIISa37crdu0IUOzFBI1GGDg4+P9yl3GbNrWK2AUTvwsFfzoYnvitDQJePCKyHvm/FB5HzZjIQOGqLWcBTEfTRNMyuXvvXVftYyeguMMOhgYk0armRyeMxqrmlg3cT4w4tLpy13DbKNF7BxcvwT4RHTjLKEDBeJGra1iQYFBaOb4nRHpIZO0zM4fZN3m5izlNnS5fADn/+p7vo1Ky4MMiuMWjQq8QSoE+vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pWLBQmHfGuHpotrsQwgdjey05YgjSg/pkJoyOWwi5j8=; b=kWDuPapVkLAGG0R6Lzjwl/uSIdFVvTiyvO26GBzmyvATq7QgnDMd5WMpV7r0ylmvzhnf25/cOQ7OEuTLHkFVhqQY1z4OASL35nWIcnthcHr/uLApQ+Wg2wwL3fW4wzHWeRfzN9p8og8gEEVUGF+seicYem6e/3G84A53UOJInzOHuQO62laoDevQw+6hNhN++eoahw23tKVXdvUqsDfwnVlPkLvA47+hfumhMK+WoWRsUuTaow3SsdPRk+k0a/TeI8SKOMw9cnjBjrxDQj8/bwmkqsurPM5iIuUJtGbDyDnDbfS9dtLZZxC35WN3npKsJGPBYD3hKft/f7/HhnHsgg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9dc4bd95-302c-0b39-8954-7c1822c091b7@suse.com> Date: Mon, 11 Jul 2022 08:27:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] xen/cmdline: Extend parse_boolean() to signal a name match Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Juergen Gross , Xen-devel References: <20220708161934.10095-1-andrew.cooper3@citrix.com> <20220708161934.10095-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220708161934.10095-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0069.eurprd06.prod.outlook.com (2603:10a6:20b:464::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6074ddd4-b1fd-4255-b7dc-08da630661b5 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2916:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 13rkFz7KTwyFcmQUAWYS30QlskFqpSnhK0z5Z7s2fakG+gfSVZmdsEpAi4W9nMBcs3U0YHXyd9hvu0PJSvjBphoIOMNzPhcCcxGikXn+E1lwRTuYgrxo68yNIULLuC1zp/ROX4VagW9OO4GDc2sTrlORPGQcERQ7uUC8nAzb2QC/vJ9qybR4miKqq9Wu0fmOrX+zJ+u3fV+lmXn5M7wsurQSsB2Bce892CZbQT6U1tglgX3Wuh6fLaIDPV6TyE00/oMt4ErHnxQpbswooDvuO/Re1yBXe4SGnmKgPL2uZ6ouIuAPFos5cIvp4CfIWzG6q40LbHu61AsWCHXXv6WpqLmpts7MQ5gkf5vlhh61PVSGxIHPqd0+WUgH271PE+uZxVideeAN9w7HF4hpdaWLfrBj/P03qE/Gk/yWHdZJv897YM/R+gPQHJJkx+uA3IRF0VLiNWCNfMm39c09E59aJHSTvSoBeQZHc/pxlAG2B995TG2BKBzTnXuBuDAdrAadWF+28alVN/UUFFYdzO5NOs+adwVCEt/M4+RUo/cHsxP261mvLQAwX7n6JFmlFFwHknmR5vvckTphOJV/TyBtdOlCO/fuCXXtVxJJED45DXxV5rz8y9m8LkwMqudogmMqV9EWgeHK6UVcc0vh+faJw020CZDtdqECnWUJLsRWfbFsw3C9jrCKDYJEZGoO2xg6ziwv4mKbJcee3DeaG19TNge6HdB1XEb6Beuic2n4plpwNkfTNs6+YUu+1AKqCi+Eysg/DvdaiD+yBN4b+II/nVw8tTdJ8X1JPA7ZynaxeUsEnWsDT5amOOj9SnyKt48mOiCj5y9YFTT+UFUUMwyTLgmIPOOI0q99wmmsQjoZsmo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39850400004)(376002)(396003)(346002)(366004)(136003)(6486002)(31686004)(478600001)(4744005)(38100700002)(36756003)(4326008)(8676002)(41300700001)(2906002)(5660300002)(6916009)(8936002)(316002)(54906003)(2616005)(66556008)(66946007)(66476007)(6512007)(53546011)(186003)(26005)(86362001)(31696002)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVB2UnNITWlrdHZuMjh3c0tFSzlCNVVZd1ZNcnc4ODFqOHhmTy83a3Mya1ds?= =?utf-8?B?SkVMa1gvUno1NjVxb2ZDb1dJZ056WDFYcytiRTVmeitvWjZSamgwUExRSTZq?= =?utf-8?B?MS9uOHBaZWo4OEJkcWUyTTd6Uld1NmxoNHNUQmZlZ1dpbjVtUnVoWTNSRGdK?= =?utf-8?B?RXEyNTZaVk83M3R5SkM5aHNKYmdVZEpqMEE0M0RhVit5OWZsYjh0L0xweHZo?= =?utf-8?B?Y2U0aWpDdlhGNm4wb29odzhsTXBZMXJVYys2dHRwY2R3WVlRUVBzWWtoUHVL?= =?utf-8?B?THdEbUVIamhpZnZndllNSm1CTjRPSW01dUoxRVAwRGFXcmx0dlNDVHIzZWJi?= =?utf-8?B?UjJZbmVFL1N3UE9JVDVxYTIveC9YMk9QWHVFc3k2bWx5bllBclJCcUc1NzJT?= =?utf-8?B?dUlKblJNdy9xL0VaSHphM0NCRVg2SGI5dXdVMS82cXExS3UxeGZtb0ZOTk5E?= =?utf-8?B?bW4wSVlnUlI2S0h5RDRzUzhqTjQvTllBZkx5K1BTNXB0RS91VFQ0MnJWVEMy?= =?utf-8?B?ZEVCZVlmZjYvcjZRSUozcUVzSzVGV0c1Q2ZvRUJhQmtKaDVsNFF5YkFDK3p0?= =?utf-8?B?MGs1TjVxc0R0c244SzlZcUxmaXlyRVc3NGh4d0Z6YUlMQUd6Qi92OVk5YmU4?= =?utf-8?B?QkhIaHpIdFhuZ1Ztb1RwMmwxc3ZqQ0hTK1lOd1FxeUlWTlF1NSsxYittTFVB?= =?utf-8?B?eENtekJmaEJFc21KS3JFWkFDamxic1lSbFBWTHcrQWJTaC9tMU53ZkVRWG1N?= =?utf-8?B?WTJEWTdlNFpjOXJpWFpXMjZVSHB1Q1IvL3B1bDJXZjBrekRnMmFtRkN3QlJ5?= =?utf-8?B?bWF0SE5VUjhMTzZWZzZmTWk1UHIvUmFSU25tRktVZFg1dlNhZFAxekhLYjVr?= =?utf-8?B?S0lId0RMT0tSWXllWnlJZlZPTkVDSzZnRVdUL2tPTWNPUEhtR1lBcElLYWZh?= =?utf-8?B?TCs0YzVPWUgxN2N5QTE1MUg4NFVWazc4YmxCVlo0MDdsWFgreHVrdms5dG4r?= =?utf-8?B?WHE0NVZiNFlkcVZyelh2eEVTOE1VKzExMzJOWjdXR2pJY3drWitCRDg3K3dr?= =?utf-8?B?MjRKNUt4RWNCR1RCN0t0OUFESHBSd3BKY2hMbW9MTTJ3Y09wTldRc2FuNFJj?= =?utf-8?B?SmF0dzdyN3NtMzZDeGhEWU5oenJVV1VrOTlkaTNhOVEzUFNUV0JOTEVrZ29J?= =?utf-8?B?Ky92UDZyaklFbU1WNWRCN0J4ZmFodnpRaVBpRUlZbmx6Tjh3L0kvYjlBcjl2?= =?utf-8?B?UW5JdDc2ejFFelpXNmN3ZUU4VmpzU3RVS2tJWVBQOVRQUWpTcHZYZ1R1dEhk?= =?utf-8?B?WXpWVDZzTGlyVEVVaGtmVWF6QXl0NzhGSmc2aVYzaW9mU3k1S2tFVXh1bEtt?= =?utf-8?B?QXRjZzdBOWNTOHFiNmdxdlRWVXN3U3RKT1RlTUZhclI5YWJyUlAvbngzRjNZ?= =?utf-8?B?dEd1N2J3V1ZYWDhNNCtSMzlhQ2Mvc2xXZUtmTG00a3lUd1d0RHo3UGpUaWlm?= =?utf-8?B?eWkzeEZSeUFTblNaMFJZbTArR29TUmR4KzNKMEFwMDJFNmdHYUF3RUJia3R0?= =?utf-8?B?a29JaHFsTlpNSXA0SVBSOHFKVDhzajdDTWMrcE1TTC9qZXN1MmhXWWJNelZw?= =?utf-8?B?TWt6MVF0Sk1wTGEvK1V2QnhUekJxc0RDYW1zWngyQW9DamlPQnZrNjI0MHhn?= =?utf-8?B?M1ExaGcrcmgvL0I4TjV2NnhsK2RQMytDak5YNVNQUm5EV0Nvem96a2FZS3M3?= =?utf-8?B?c1hQSlVFd0dHOS9FM2x3dmR1SkZOQnBFZmUxNGVsZk1LclpLYmR1TUNFUU1k?= =?utf-8?B?RUVreUxPcDBVUGZtWVRCN2ZQQjY2MFhGQ1JydCtLM2RQL0EyQnFhSURFcFda?= =?utf-8?B?N3gxZWUvYXFXMTZJSzFOTVFJNko2L3gyUGE1TkRtZDU1c2dxaDNteHR1M00w?= =?utf-8?B?akxicHFVNkh6YmJrT1IzWkJrYWY5MW9CZW1GWkhwNG1UZEpTNTk5cXo1OFZa?= =?utf-8?B?cHFRRUpkU3lubGI3bnhLdGJZUVpIbWtpd0hyZzNmZGp4cnN0QnhIcDZQNmFt?= =?utf-8?B?Rm5jWlBVUzhrc2tya2RnblZNODlES3pUcVhBaml6SldFS0VNbVJDa1AwbDVa?= =?utf-8?Q?atnqD5llXjJZIvwsfOP3VHCuO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6074ddd4-b1fd-4255-b7dc-08da630661b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:27:08.7849 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MbFuX+hFUpVatCDxXTc9ixEfI2h/AzZPsxiuW78bU+IrPBGRYwLcOVxe6DW4pVjFfRUhLdMFPpHQFJcIuFE1mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2916 On 08.07.2022 18:19, Andrew Cooper wrote: > This will help parsing a sub-option which has boolean and non-boolean options > available. > > First, rework 'int val' into 'bool has_neg_prefix'. This inverts it's value, > but the resulting logic is far easier to follow. > > Second, reject anything of the form 'no-$FOO=' which excludes ambiguous > constructs such as 'no-$foo=yes' which have never been valid. > > This just leaves the case where everything is otherwise fine, but parse_bool() > can't interpret the provided string. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:32:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:32:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364833.594768 (Exim 4.92) (envelope-from ) id 1oAmy4-0007ET-7b; Mon, 11 Jul 2022 06:32:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364833.594768; Mon, 11 Jul 2022 06:32:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmy4-0007EM-4b; Mon, 11 Jul 2022 06:32:28 +0000 Received: by outflank-mailman (input) for mailman id 364833; Mon, 11 Jul 2022 06:32:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAmy3-0007EG-L1 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:32:27 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50057.outbound.protection.outlook.com [40.107.5.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3aa83b68-00e3-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:32:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3694.eurprd04.prod.outlook.com (2603:10a6:803:1c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:32:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:32:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3aa83b68-00e3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=COuPCYtfXJk3AEbDobTkJmFpM5jjZRFOOr642elFGP+8bx1AJm0D7+ZHZPDFsc3ABKLWQXsBTJiU7MGaJUE43PUs2kA0gj7C7w4P+TCXwITbnw18TVPpfCLk91Zi1cHuxiK/RzjVRiv8tkcNgKujuRl++1S0zzDYH1avaFfgWysNCo1KWvIw/Nc/2UBGAi16BbkQuveioY0YyPKMnSrsN6s/ZSLHxwnTMpc+n0nlmnIL8UFHgCgPLVzBg2Wrz5tAxdPdnJZooPeb7Rz4IMVRSGQOJ64OULxg3bEW7A3qBIqbLIu7uh9mHm3ywrlSukOlMo2vbz7VlkhZL8S8ocRzSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K5v0hQa6b7GiCLPmZm5YtHqd20yvQvIonetEoOetWwQ=; b=bB6rQF5T3y198fTkT1mHsWd/KGacxu4RPHcstWdgMb9qH8y5NZVeyOjUidlobhs0avtLf9GPh3nJoPKIzg9wrwOknRNm7uroT6DJ/y6kRUDUfRYcToGQJeAyCDql3P1xWD9Ns+i2KsMFWSvEQC54IfdUq3YzuFw1XSqaSCJ/ldG6arAiVyh7vffANRppgpAQGBwHV4THAxfn0C1+fMn5hrbBqkjAzqPQZMvOH8hfDwDgiDiz5mSE7Zaeheaor+Qpu3DdvtiMVvOdCHsQuPP1MFkOCoAhYylW3HsrLVWg17qxxo2tMHFjkHsXGeo5wX3BLjhcTeBXCumn4RrQE754Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K5v0hQa6b7GiCLPmZm5YtHqd20yvQvIonetEoOetWwQ=; b=uRzWrRgYj0894A71lRHM6G2/uBQRZeZiHIe8/+fFsnVlQnOKNTk2I0wQFqavSGAEoTv7mYf7h9s3JAKRQ5Wgt2YhO44ZQhDshd3PrnuEp7pXTgfSN66T/k58qmODEe9HpgZU1o3JV7z6v82Xs/jk6sALs0Q6CPSIGuwIsGg5z3rUGaUPK0uQcIOcEpUmFXIgHl7nArI+XB9X+wnfx92YAE9VQshBs5Oyvthx1HKoG9B2SA8rWMNrEzEEDggQn7hAtElLApqFHxq5LiVeYeWHjtb2Hy5hm/HLALbvAVmHlPPhcXI6gTcYPWnbxVXQlAdFLtA7gRtZVAGaRNdqhp6pgQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6b1b2694-d46a-7713-6109-99c98fdf6b8e@suse.com> Date: Mon, 11 Jul 2022 08:32:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jiamei Xie , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-5-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-5-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5P194CA0013.EURP194.PROD.OUTLOOK.COM (2603:10a6:203:8f::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72466888-c4e1-4cd6-7246-08da63071d33 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3694:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K7grbAP7A4bvrZaCfVifFKpuw+LsZd4Q06IKjJsOBD4L25LiltdcKyIt8vWexS7XaCvZwHREgXhbnctJMQil2P01PF+cxSn7w2XZndnJs0wIBOI8U6FmCGLZKOmAqWV9THLzwRbBM7DFc8QMKSM32WbQ3d6WYb69R0vflIj5IsZ+BW81ZIvgTlsHxhcdNsAOA4crYGeY6Hz0aGYK9is8IWVb6JirHuj/+xACkLWZT3hMD/+z1lg1fmdaKF6at86y8zX07jYYsMnuDDGQlFmR8QI86LolZlztkBMCsXUTQE46FM1ipRN3mWA7HIeCtcaN/au91Jj3zlEq0qxvuls40OrXBT598s5BZKRC56bAXG96GGao1s5zwA5dztkfSr+TQqcy373aLsN65KZrBD+EX+0lmGl7XtaSXLy3QYu774hEFf9UNldPdvLOShrg589o1O5BP2P4ifl24+eqXOQM+P6Qhh2bZMrx4easCxIlnHlveS5+ecktrCDi0NQmvzSn5S46VkVJagXWA3lrZvPToNcvFJaLKEeNvXoQKnbjq0THxif9oMUvDU4WWnGeNuzzSQRl51ZxYI/O0kPhA+0sc6rXP5pWYOsMi6h+6IpkrEE8tWFnhhtS9YDRB4PYg7W6cdfI3SM86QUBSK6iEceyxETClVudRqIoFaqLvNkorI0IZ6Q85VxeO9kDOTBMZ/iSk6TQvWOnqyTJLkcS29HTmqbyTDsC3JEzIvgyiW3j46XHenTqXKIrNgWkQcigt4FXf05h6KHVoCzFQwVf1+2AJSSQBbfUwMwJNW17VbDRuU5+H6+C1OQa/yw2msTa1EvNxOwf3F7QjBXucp1Qlikg+4/BOtN74JK1SMscBjzTp64= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(366004)(346002)(39850400004)(5660300002)(6506007)(2906002)(54906003)(316002)(53546011)(6486002)(6916009)(31686004)(478600001)(36756003)(6512007)(26005)(41300700001)(2616005)(4326008)(8676002)(66946007)(66556008)(66476007)(8936002)(86362001)(38100700002)(31696002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Mlpac3pVL1JKZVM5YXQ5VStSczdWVnkwREY1c08wQmlsSWV4cDRNRXBMM2Ey?= =?utf-8?B?aVpEd0FjTUoycSt1U2FBL09tM2FIa3dTbU5tYy9ObHhVTG82MTBVd3JYdUNL?= =?utf-8?B?aDVLWVhManBLMy96SlIyeE5RM1hDaUZXcGlxWXo5TVZvZkZMMC8zM0Y1N2RJ?= =?utf-8?B?dFk2QmdIaE9jcEFxc3RzU0xGRlJONXdPRlVWa3JOckNlS2svb2lWYlpEOSt0?= =?utf-8?B?V1ZFS2J6T2M3UTFMelpsbVpHNWk2djBkU3pwcFpDWmRuOEM2eHcxbFJ5cFVy?= =?utf-8?B?UVRuSzFScjFkRlBpWC96ZExHSnI3OTNaMU1zeXFRTnlrcUVCemRqUnBuZUEw?= =?utf-8?B?V20zeEpINzg5VHBHL1MxajNBMXpHcUlMNFBxZmpmYWM4RWFiK1F6b1pRSWZY?= =?utf-8?B?TU1xNm9scVlDMTlYSTRRZXpyUWJkeHY3a2dJOHF2eCs4Q21Hb1Y5MzEvSjI5?= =?utf-8?B?YktXbTVLNi9ETnR4QVE2dHVMUWhOMzFHSC8xQUg1ME53VFZIdkR4ZWViYld2?= =?utf-8?B?ZEZXSGJiakg4aElZalJiK01HbGthVDNOUjg0ZDFKejRIUHYxR0lCcWRxVFpK?= =?utf-8?B?SDN1VHRmM0piZThjT1Z0eGtrSENFS0duSG03bW1qaHVWK0IyVWpweStva0ZY?= =?utf-8?B?bUl6d0QyVzBNdGpKTmdiMlEvV2NoeVNjWkVIWWcybGJNRC96QXh3aS9kTU1p?= =?utf-8?B?YzRLNDViTlZ2WmI4T05oZmFFaFZvM0hMYUM4Uk9DVHR3b1EvWXJ4djA1RFhL?= =?utf-8?B?SkQyV1pCeWZpYloycExETUQvZk5HYmhCYzlOamNoTjlxUnBIV0hJSThMK3Yr?= =?utf-8?B?T2FOV3NFMityaVRjKzBSUElKVjZ2U3J3MXhlQ051WVYzaXpDa2FMYXBlUHE2?= =?utf-8?B?Q3NFUlgreGkxY1plN3BhdkNHSGd2Z2RvZmVvVlU1ZjBSUFpROVU0VFJTaDFK?= =?utf-8?B?R2RDOFVTNkxaeExNazB5YnhiLzdubWZhbHdWTmtUeWhabDZhK3FUbTJWMHFi?= =?utf-8?B?WnNpSUNzUzJVZ0pXemJzQWNNekZ6c3lRRFo5cGpYU05sSXhUbXlpUG96T3ha?= =?utf-8?B?bkVPYlFPMWVZYW13MHUreFRTd1BsK2lMMk9LZXNVVW54SHMrTWNlQkF5bVIx?= =?utf-8?B?WWt6Y0Nld3drenBUSzcxRno1S0locXRCdUZRcW0rZ0hQd2ZscCtrWTJHSmF4?= =?utf-8?B?OVQzU3h6Ui9DVG9OOU1UaVBmRWcyRFRFaGZaYURzQ0lIK3lQSllyWmowakNx?= =?utf-8?B?ZlJqdXUyY01QRmtJV3lONzk3ODJFNVNLaTlGaU9jY2Vkbm02Q3ZsSitzaW9r?= =?utf-8?B?L3p5RmxuaG9yL0tHMkJPU1NrZGhWWWwwOFNvK1NJQlp3dklrK1NrcTFnQzdi?= =?utf-8?B?alRaRjh6V1k0V2NoNWszdXJDTlJvSzI0UVdNUXlGbFJNSWpxNkllNmNuSUNS?= =?utf-8?B?NmtPZEl6dGxNUHNNTXBUc3NTeDBraGxTeGdyZGNFTzBCUXRQOTllcTE4Ylh4?= =?utf-8?B?eEh0eTJWVXBIWUhUenE1WHczN2s2cnJFK1hEalBmYWhaeTMxbnN1NU9LYkl2?= =?utf-8?B?ODNDMDZRUGhrbmd6alhCYmM5WkNCcGtINE1JYklsQThXRkFTZWZtbU9nS2Yv?= =?utf-8?B?dFkrNnd0amxhN0F5bmJsWlJrb0pKT1BTcUl2VG05Wk04U2FsbFd4SFVRQllJ?= =?utf-8?B?RCsxd2hCNjB3ZFRKRm9WdjFpalBIOTh0VjNUc3hQVVVrcHk0THphQ0s5cS9Q?= =?utf-8?B?bFV0b3JKd0J1QXlIWFcrY0p0WGwxRVB1OEplVUMvMnpadXBKZXJDWDVsK1RT?= =?utf-8?B?alJsaFVYdlh0Tmt6S1hidFVTUzh0VUNqSHFOMVMwRWVJZkxJOGllVWVrQWRH?= =?utf-8?B?SUlFM2tZSGM1YWNHZXE5a3hpY3dqUTVTVll5b2Q3L0lpTjlQMnhkOHcybGsv?= =?utf-8?B?bk1rT0J0YXF2a3lvRVdCNjF1enhTNTUzOXRqK0cvMkFVcXg5MTRONU1oTGta?= =?utf-8?B?cDVmVkVDc21sMzZicUhqdUxOVUFqcjZ5MUFpbE5hT1B5amlSWFE3Y24vdzk2?= =?utf-8?B?K2d1bkdUeWxFUnppMkxQOE00RERxVjVsRW1VeUM3S2RXcHFXeFVOalVIOFlq?= =?utf-8?Q?0PME7hZTI/I+roPXlc6RAn2E7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 72466888-c4e1-4cd6-7246-08da63071d33 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:32:23.3584 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nupFVctiS18Jub/ZTsuQPGXADI7l4cPUlpTM2cclrDjwJ7jsh1PatV/rhv4ZHWBKUMm8omnkOL025+87i6j98Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3694 On 08.07.2022 16:54, Wei Chen wrote: > VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This > results in two lines of error-checking code in phys_to_nid > that is not actually working and causing two compilation > errors: > 1. error: "MAX_NUMNODES" undeclared (first use in this function). > This is because in the common header file, "MAX_NUMNODES" is > defined after the common header file includes the ARCH header > file, where phys_to_nid has attempted to use "MAX_NUMNODES". > This error was resolved after we moved the phys_to_nid from > x86 ARCH header file to common header file. > 2. error: wrong type argument to unary exclamation mark. > This is because, the error-checking code contains !node_data[nid]. > But node_data is a data structure variable, it's not a pointer. > > So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to > enable the two lines of error-checking code. And fix the left > compilation errors by replacing !node_data[nid] to > !node_data[nid].node_spanned_pages. Although NUMA allows one node > can only have CPUs but without any memory. And node with 0 bytes > of memory might have an entry in memnodemap[] theoretically. But > that doesn't mean phys_to_nid can find any valid address from a > node with 0 bytes memory. > > Signed-off-by: Wei Chen > Tested-by: Jiamei Xie > --- > v1 -> v2: > 1. Move from part#1 to part#2. (Comment from NUMA part1 series) > 2. Refine the justification of using > !node_data[nid].node_spanned_pages. (From NUMA part1 series) > 3. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. > 4. Adjust the conditional express for ASSERT. > 5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. > 6. Use conditional macro to gate MAX_NUMNODES for other architectures. The change looks okay, but can you please clarify what these last two points describe? They don't seem to match any change ... > --- a/xen/include/xen/numa.h > +++ b/xen/include/xen/numa.h > @@ -36,8 +36,6 @@ struct node { > extern int compute_hash_shift(struct node *nodes, int numnodes, > nodeid_t *nodeids); > > -#define VIRTUAL_BUG_ON(x) > - > /* Enumerations for NUMA status. */ > enum numa_mode { > numa_on = 0, > @@ -77,9 +75,9 @@ extern struct node_data node_data[]; > static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) > { > nodeid_t nid; > - VIRTUAL_BUG_ON((paddr_to_pdx(addr) >> memnode_shift) >= memnodemapsize); > + ASSERT((paddr_to_pdx(addr) >> memnode_shift) < memnodemapsize); > nid = memnodemap[paddr_to_pdx(addr) >> memnode_shift]; > - VIRTUAL_BUG_ON(nid >= MAX_NUMNODES || !node_data[nid]); > + ASSERT(nid < MAX_NUMNODES && node_data[nid].node_spanned_pages); > return nid; > } > ... in the entire patch. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:34:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:34:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364838.594779 (Exim 4.92) (envelope-from ) id 1oAn04-0007oP-KP; Mon, 11 Jul 2022 06:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364838.594779; Mon, 11 Jul 2022 06:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn04-0007oI-HH; Mon, 11 Jul 2022 06:34:32 +0000 Received: by outflank-mailman (input) for mailman id 364838; Mon, 11 Jul 2022 06:34:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn03-0007o8-PP; Mon, 11 Jul 2022 06:34:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn03-0006a8-Lb; Mon, 11 Jul 2022 06:34:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn03-0004U1-4M; Mon, 11 Jul 2022 06:34:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAn03-0000oa-3t; Mon, 11 Jul 2022 06:34:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OOjK79hyGK9W39T9NXaSqQGY/wg+JUAt65b6oPWUesI=; b=NULMVK50pYDK5cQPBWFbH5hY3A LHIgwcpcmHzseqTPdbzqT42K23E42L7OhGVYqW4FA7cgdUxWbWsWMmrMAFNX0XZlb/j4w4Z/JUuew t9FBNqUfysY/uj1NnQDHYbZRuTt6/ZS2oMam2uh8XGLzFNiwp7y2OFo+Z9gji930gCEE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171579: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 11 Jul 2022 06:34:31 +0000 flight 171579 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171579/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 3547875f3a8cf286a03b62f5e7bdb8e4b0eeee29 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 731 days Failing since 151818 2020-07-11 04:18:52 Z 730 days 712 attempts Testing same since 171555 2022-07-08 04:20:30 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115427 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:42:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:42:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364848.594790 (Exim 4.92) (envelope-from ) id 1oAn7L-0000zS-Hn; Mon, 11 Jul 2022 06:42:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364848.594790; Mon, 11 Jul 2022 06:42:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn7L-0000zL-E6; Mon, 11 Jul 2022 06:42:03 +0000 Received: by outflank-mailman (input) for mailman id 364848; Mon, 11 Jul 2022 06:42:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAn7K-0000zF-5c for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:42:02 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 912a28c2-00e4-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:42:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8498.eurprd04.prod.outlook.com (2603:10a6:20b:341::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:41:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:41:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 912a28c2-00e4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bU5ltNTj5VOpZXeWyLHQV4uU++ZcvA1f2Skou6DvoQjM12Ltcp0EPPFCvquNZtDYiQtpdPcjKuLz6P2v0HhEZBfgB4/DfIiXPI8Gmp2b3iSD/9WP8taTMb6ppLNH4+WrJZsV6vkxBhENsBF6u9APbtFMjp2C8cvEVhvYY08EnUncbstSsPlfMAGJccSyyvbkdEVzoRcmL3u7ESbcAGgsbEYOeA9kB6ODSRTkHkCPXjdx0SVJAQRtS0+Xe8Fpqz9KiolNtlkEnXijyv7o6Rujerm7vCk2V26GvmWqbdBVhoCYdGyVdw+DHRlkg2rS2r4MQpXsHZjCK5VjW8sYqwqnMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SVQPCx6foil+0u0VNm/ZGf4G2/wA7pcHMb2QEaFUE1I=; b=f0To4FmPZmP7pAfSd+ayFUbLzkpirTWFDld82HmRusT12u+ID27SXzwTkzFX3gWqHZqsqa2j9TLsOrKpQMP8sx02Ia0XIG4Q2volUeJUONRzmVgl3GSI0vVGo9ublnoPFWl56iJJvZt7CfzQD6ihjko+4UqBubSdVcw9SZozOSQRpQNBM8gexrjmEN6TeUHAqwJWThTBio0019ZEwyBmPHZuiWOeaSmCZVq4AmETX71+cVct9GjjgC+PqJ5zZJz4fSNljay8z287mXvVUyfiVDF12/3jGRbicuKnZ1CDYt3KgjlpwYUj9yD7Najwrqlg/X2oiPhAw3YEJ4bEtjpsdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SVQPCx6foil+0u0VNm/ZGf4G2/wA7pcHMb2QEaFUE1I=; b=OJUUWT/2cfB2wu0H0bQbbRhFAetm/MbFCvY2TkDUT1KwOMofqht6Z4o1IPn6dFUG1XV0KAKYE3O4ISIZv4qMpofsI5iaRbSitH6uOKdidE3fy1N/k3US4LnPZxHthDgytYNbCFuwecIgXwawh3LZ8WIM/6r5B/dPeqIhkOrdrBZlWkBP7UMqQWnw+1X5GpWOo6Hsc4UZZeaVqMqvJEfNuzSJagveCGFDM5fy7RSD4ceux4x1W8NZ2Jy5jaOjOcgMRLkYlFrNqy0EaHNrAcxgsEgpWuYCS6vSRok3jA9SboeekumDzPqxxtYJ2ASvfVEVwQEkwuvqIq7K3F+Dj5Xp9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 08:41:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour References: <20220708213403.2390-1-demi@invisiblethingslab.com> Cc: Xen development discussion From: Jan Beulich In-Reply-To: <20220708213403.2390-1-demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cddf1a7b-be5c-4af4-a612-08da6308745c X-MS-TrafficTypeDiagnostic: AS8PR04MB8498:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vPm6ahyHk9tcZ5Zo83hlWz21vg/H1vOdxKJ/Us5k2JFusXO82Oobc8st4U0+7rtRQT4jEfdJTWAxig/oZK9T549qzrBii/oAu5oPLpWynZ3QnnApQfZg9LB0rHD7zf8odtSvKHWlhGLQAkv9a+jfsXqGiqMnwwIDL+TG4NGIY/TstmUx8oDQFZBnSej1JJUPukrrD0cNIQzyfPsbflNE9anjOoGy1Cw4B9HnOiv+F9A5Xc3FElwXUH38bCafM50n3P3U57ynKiH5HrA8Nd/NkAfYefLOBHyBly5zq7J0BOAby/o4bgdSp2m5lxmI471LhC5bATPSTqd4GtfjYm2NjADq7soUViAlikqxD7fPIijcrB6jfJYigRkXQdaiLEwQuSMcxOsm2neAkgM+TJGGrKRhYWTAEINPob6iOKsBJ6GApn9l54qjEz04N6mnEvvFvs4HedFA5mnwtIcCjYKWVCjfoCuMpqIHmFj7BYaeeizudLuclatpks1JG7HWokaB458bNhyM1S8D1C81py89HrVW6a6qwVU2szfdbrVpsptn2Lw/RTXgmYZqZ1KzDsJ4q54080b7fMZjXprWoI0Yu1qgeungpx5b+AnD3p+GXmwr3W2EFL1DA/7L7NA6OC3v/jEUAGrNEgMMvXLx4Bcu0ooC2BGzadDwu/U28JaznMvxI/zLfLwOo5AXQK2unFZoi/Y0SG5HwValFmdkXqSlOV1TjRrzgUfhNxFHLCeRYnqBtoPRCbFkMiN6TMRodoHtHwC6Qw3ChLTpqK6RnFYGmHnTfJDVknHXHraOyNxX3p/rG5WG1iCsWoGilM5fAhpJKdNaLHbCFcXvf3xfh7zcUm2X+bSa/kPbUYM1vHPU8OVAYT5VD7CoY1Nt5Auew8Ty X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(396003)(39850400004)(346002)(6506007)(31696002)(38100700002)(2906002)(41300700001)(83380400001)(6512007)(86362001)(6916009)(8676002)(4326008)(36756003)(66556008)(31686004)(66946007)(66476007)(316002)(5660300002)(8936002)(478600001)(186003)(53546011)(2616005)(26005)(966005)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnRGd053N3djSGJvTnFocjExcFE0eXp4Z2ZUbVBNbEhDWnExMEJ1ekQ4bUFn?= =?utf-8?B?V1R2MzdUakNsT1F3L1NrL25tdXlkaVNFT1BXMEFvUVRxb1VMdlFreEkyc1VL?= =?utf-8?B?bFJYaGZ1bXBqZmo5WGZzMVYzUnFkL3E2NElhWWk2VFFRUEJnVG9oWGVBYm9C?= =?utf-8?B?ejNEN2IvUTMvbHp0elBaTmtQbStUaXFFdVArZzRVUm1BeFFVbzdxWEdxTFFN?= =?utf-8?B?MXIvVE5idEthTVhIdEc0d05ubHZpVDUzS2x5TitvUnAzc2FCb0tMNDc5bVF3?= =?utf-8?B?M3JnaUpqVzdTN3YxOXVNbzBvWVJFZEN0ZExYa3BqV3oyR2Y4SWxJTkIvb24y?= =?utf-8?B?dDkxRE5IeHVwVEYxSkZEWkx5VWpDV0FrRVFraURra09RVGNYRE9PV1k2N1hz?= =?utf-8?B?NFdrMTN5M3VXK2VBQWhSNWlwdWdqL2todTdpanR6MzMrWVY0NncyaWpoYVo5?= =?utf-8?B?M0NJWjluWnpuMnNMa1FOS1NGcXQ1UmJDYzVWM2FQR2Y5UzN5Nkw4aDhoR2k3?= =?utf-8?B?MkU4dEV2OHJSUlp6SU5aZ1NlcWJBeHpFWnNra1hGN0VzRUJhZU5XbkhyRkNV?= =?utf-8?B?Z25PaEtoV2V6QnlseXRSa1dsV2hXRmVjQ3RveUNiRkNmdUJiM3NVOWpIUUI3?= =?utf-8?B?eWV5TVZDV0F1STFTandFeUN1N29KRXBFdEJiVmlYV0RaUG5yVHorN3pVcHl1?= =?utf-8?B?QVZvVzlad2VwbGE2Mk13RlArRDlXRy90eVFiMEJhSTVaVEdUT2t2QUlWNjRn?= =?utf-8?B?Rk5RQkhIMTZuYnRlYkJmMFNaelFOVHhkT0FsWCsyNld2TFVzdGY1WWFJVXNq?= =?utf-8?B?cTBNRlU1MWIxQmhNa0lCTVUrU29nQ0lITEhsbkRjNmdsNWpmeHFUU0ZCVFVG?= =?utf-8?B?b0FlaXhDajFxb3BZc2xmVHZVTGZPalFnTFJUaDFIR0FEaWlnZGhaOVFZYzI4?= =?utf-8?B?elBSc0x5ODVtUm4vbklzMlYwemhYVXl1dlVwd04xSlNycFNMeWRjK2VFdXRp?= =?utf-8?B?RVVNWW5yaWJ2MWZNaVNvc2x0aXJkeE1ZTEc5TXhQdURhcGprSy9JRnowcWtq?= =?utf-8?B?K2N5K3YvWWk3QzVxb0N4ZE4wbmQzV01IN2N1aFlrYVlpMENwS3VieThXQlVu?= =?utf-8?B?K2VKblgyVEY1NHdHVTI2Z0owV3llVmZrSmJXY2lmRHJIbkkrUDB1L3pxQzFq?= =?utf-8?B?a3ZnZXRiSkhHQm9WL2dXLzB4YXZiNVE2WGkyWVFid0ZkWitoNmlHYjhWWnVO?= =?utf-8?B?S0tJTURERXNDYVVJS2NIM0VsVUJXbUZ1SzM3dU95Z3NkUHZ2NjNXL3RkRjBv?= =?utf-8?B?QmcyM1ZiYjFFa29ueUxrZTFCMGtRS2hXYlJIWVpiZm80UlZvdC8rVEJpVi9p?= =?utf-8?B?Z3c2a0R5MW56VHJtWEY5dFNNYTA0UGJNR1p0T2lXdE9JU0JUMGVkR0FuVTZt?= =?utf-8?B?M2V1YXVhdU5aWkg3YUpQUW91SitmektMNjNVa21uTkgzUDUraHhFenJmVFZB?= =?utf-8?B?YnRuNm1ZeUxrcmtmNkZ0My9IK1huc1drSnVGLzdqdnhQQW5OY0daM2xzamFz?= =?utf-8?B?M0xabW1obTdWekVMZXpCWlc5MlB1ZHMyMm9BVENuUUFWTjFNcERjWm9ZQVJD?= =?utf-8?B?bjJGd2EyczJNOExlR1F4V0xVOW8yUFhQK1ZNWlpraEwwd2x2MlpMY294L3Iw?= =?utf-8?B?TFJQODdxZVFIb2h4ZWZjWjBkd3pRakpHUnMwb2tYQXpkcjBJVkxGN1BReFhk?= =?utf-8?B?VWh4ZmJldTNxNGY1LzJENytSbTY1KzBSOFA3MjVSVkdCcWV2QVFnTzdickx3?= =?utf-8?B?LzdXZHpSMGNLWWRmSWRJUG1CMVdTY3hCbTRqRUx1a0dkdmRxcFJIbmpZYmxy?= =?utf-8?B?RzMreFo5K25XNmxWR3ozWklPQlUzR25hcE1FYklsZHlrQmNFRXlML3BjbVBO?= =?utf-8?B?OWVIeDd5cmc5TnZMOEpENjdOWW9lYXVlTUswMU11aWtFclRpNDZzNzJKQVdW?= =?utf-8?B?d0JPOE9jT1kxTFpMS2pvL2JrcC9aTlN2YW1TWXh6U0orc3kxOTcrem1MeFhk?= =?utf-8?B?NjJTK05jclUxbk56TS9Gb3p4Qmx4L25vYVU4Y0MwbEkzWURhUjlkQ3kwTVRw?= =?utf-8?Q?Dbq46xJ0lK6jXAZse3d0Vs7A4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cddf1a7b-be5c-4af4-a612-08da6308745c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:41:59.0557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xELfHhEMhhRUnnPSgk+LT4RSapJnLr0sp8MJ7PHl+R42dPzHbtrRe6GncCh4GT/ev3cOs89SS6djy9nXbzhf5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8498 On 08.07.2022 23:34, Demi Marie Obenour wrote: > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the ESRT shall be stored in memory of type EfiBootServicesData. However, > memory of type EfiBootServicesData is considered general-purpose memory > by Xen, so the ESRT needs to be moved somewhere where Xen will not > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, > which Xen will not reuse. dom0 can use the ESRT if (and only if) it is > in memory of type EfiRuntimeServicesData. > > Earlier versions of this patch reserved the memory in which the ESRT was > located. This created awkward alignment problems, and required either > splitting the E820 table or wasting memory. It also would have required > a new platform op for dom0 to use to indicate if the ESRT is reserved. > By copying the ESRT into EfiRuntimeServicesData memory, the E820 table > does not need to be modified, and dom0 can just check the type of the > memory region containing the ESRT. The copy is only done if the ESRT is > not already in EfiRuntimeServicesData memory, avoiding memory leaks on > repeated kexec. > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ > for details. Tested using qemu-system-x86_64 and xen.efi. > > Signed-off-by: Demi Marie Obenour > --- > xen/common/efi/boot.c | 134 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 134 insertions(+) > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > index a25e1d29f1..d2f66a430d 100644 As asked for before - please have a brief log of changes between versions (at least for the delta from the previous version) somewhere above from here. The patch looks almost okay to me (see below), but I'd like to ask for explicit confirmation that this time round you actually did test the change at least on one architecture (presumably x86). Iirc one of the Arm folks offered to test it on Arm64 - would have been nice if you had included whoever it was in Cc. > @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop > #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ > (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) > > +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) > +{ > + EFI_STATUS status; > + UINTN info_size = 0, map_key, mdesc_size; > + void *memory_map = NULL; > + UINT32 ver; > + unsigned int i; > + > + for ( ; ; ) { I'm sorry, but I'm now going to be picky and _not_ offer correcting this style violation for you anymore. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:45:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:45:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364854.594801 (Exim 4.92) (envelope-from ) id 1oAnAj-0001ak-2l; Mon, 11 Jul 2022 06:45:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364854.594801; Mon, 11 Jul 2022 06:45:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnAj-0001ad-00; Mon, 11 Jul 2022 06:45:33 +0000 Received: by outflank-mailman (input) for mailman id 364854; Mon, 11 Jul 2022 06:45:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnAh-0001aT-9M; Mon, 11 Jul 2022 06:45:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnAh-0006rX-7A; Mon, 11 Jul 2022 06:45:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnAg-0004t8-Lq; Mon, 11 Jul 2022 06:45:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAnAg-0003wy-LP; Mon, 11 Jul 2022 06:45:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vbtENd84WFaoI6k5svPTqP0tLGVgQk88EZqKngAc8Dw=; b=WGR/4ASxDLZwWwTIxyEo0gC6oc RDCC+kWpG0Ls/AoqBWDNdVOB+6gXq91xliNKgXbnZRfByI9XVOjoVHqzuWpvZ3IB4iCvlf2/LjPBq ySMxnjvil7lx5050d9xFbkeS+A44XBuZITxKyJ9wEZtHr2APKL59G8u3PPC7Gm4GuZgM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171580: all pass - PUSHED X-Osstest-Versions-This: ovmf=f6f3cc7eadcfb20898b8d67fbcae21ef56f6897b X-Osstest-Versions-That: ovmf=c8e30482fd2b32a2ba86edbd4c2429c48b20c99b From: osstest service owner Date: Mon, 11 Jul 2022 06:45:30 +0000 flight 171580 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171580/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f6f3cc7eadcfb20898b8d67fbcae21ef56f6897b baseline version: ovmf c8e30482fd2b32a2ba86edbd4c2429c48b20c99b Last test of basis 171569 2022-07-09 15:10:21 Z 1 days Testing same since 171580 2022-07-11 04:42:03 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: PaytonX Hsieh jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c8e30482fd..f6f3cc7ead f6f3cc7eadcfb20898b8d67fbcae21ef56f6897b -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:46:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:46:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364861.594812 (Exim 4.92) (envelope-from ) id 1oAnC5-0002BK-EA; Mon, 11 Jul 2022 06:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364861.594812; Mon, 11 Jul 2022 06:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnC5-0002BD-Aj; Mon, 11 Jul 2022 06:46:57 +0000 Received: by outflank-mailman (input) for mailman id 364861; Mon, 11 Jul 2022 06:46:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnC3-0002B0-Qw for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:46:55 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 402cd03b-00e5-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 08:46:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3061.eurprd04.prod.outlook.com (2603:10a6:6:a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 11 Jul 2022 06:46:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:46:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 402cd03b-00e5-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B7I0/o6R5xMTW7Fa/rl/vL9RCQo+c/N3ZSRrgVpejsOT/p4Fpua1FDp417eEjp20lOTZgKA4Tyon2UyXLHl5MX8ClqGypChRC+K+rcDg0Kc6BGOF5qPX4N/oiLUKN318Nitt9PsilqyjBtbK/DFNdtu85IVDUTN8p2cBdqwVsiy0tdHNT3Xi22vC0YOpoFNdFb/nEPSsF+ROWpFbEjlUtmar3KmztytUPd2oLXhIzp4+WCRrhqWmjgRIWkT3kseVjG0XPwUmykWvkP0FPQh5a5Qp0P2XsdRhIIUTxUXzSxS7EfRAQk1SyIgw54YSMUeubnYM8+hCichuysOOZgMJYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jpcu0rXtpvp6BX6xAVV6XQXy3vZUyclFj0M5ksrkFoc=; b=BXZDHVFOaYQf+AD3AVfdDhjAbyhoFIBJu8pmuAFx+eY9b6rRPcLRBunjAaGxyLYB9nPWFQ2QOOu0zX3SgdXqsXd2akD5OzZW0DalsCk5GqiRup2Kq1ajsz9s5wUYqhZDAEYye8vkKKBxjywGK2xfi2hb9yq4E6xi2SLha6XRri0ODXfTEjhgmLbrLlk8QyMwz9qI1m+w2cwWKWKwgR/SKcKfeQHqgMKZmWuPuXk9jgJkT00JO0i/z16bbfGZHzZLvKodfm/9SFbwW1iFR2Dkfq8SkYCEgtZBPEmxZV1hjA9mEHnxodZj4LAQka0cVkwhOnMQAlxaVHGiXEZmDSCGLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jpcu0rXtpvp6BX6xAVV6XQXy3vZUyclFj0M5ksrkFoc=; b=wURdPB6wXCFMYUv/GTUsRmTeO2LB89zpdiTNfiTsEXiaMCqe5tE4wynfLyIRG54N0NXRTaU/dR6zxKo3m92h8qOR9VvqlSpBO3UXvtP+VUsdAkVdStM3GKi9WSpt66JXmP9uVLdAfpwSReaXnKARptxncOhNsoUn6LUf2TYEwBq05mkJW7HmQzz7lITqOZe/ZrNEKocwF6VHBBRHawODEoPOk3a9z0tDhBZ6S4jaDwlHakiEYdJDBo51F/n8IT2c0Q6kmpk4TWagNWfLXhM2Le/WuFJ6fgKvemvdX5DPM63eq+zjEMChn4350ABFlxTeQGmSFzVSDZcMSNi9jmR/ng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 08:46:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/3] x86/spec-ctrl: Honour spec-ctrl=0 for unpriv-mmio sub-option Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220708161934.10095-1-andrew.cooper3@citrix.com> <20220708161934.10095-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220708161934.10095-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2088236e-1ef0-46af-0884-08da630922df X-MS-TrafficTypeDiagnostic: DB6PR04MB3061:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ukjbWn/5hYK0b8oCFPgL5mi6DCSp1jYtVurFVGVCmoHcEtYdTck+j96w7JdWPfGwtAmzCBwsjnq06RB5S1RtQFDYkKIEgcNsQP9HvOdSCQaHet7yVjgqMxctTXP+gcqQWqpOozCyuf1aTn1+C0Pck/ouoeNPPM9OVVyqu7GeI21yLac5soAuUbwumEULf6adnu61O0yd5HrHsS0qG8GfNxnO5ay7QqYLVW8+4CGI4dgqA/lOSWW+5VWvwZsRy9u/64DcmHug/uqOnDjdZzUKvwjC6SVtruzyjfjPkGcxHyDSZZDOPXmMusmtgu+wMkU/+yEdVl/awBLbohZnEdU7QakcK5UEg5i1aIwZ8oBlUHEgGIB5apcrvZNj9A7UNbDqWGzNWXCOxcl9rMPZQx+YQCOxGDk3utYfFsC5l2FbwByqjiUagvjwn1yJTKDomzUrGLvM+ydoL8Fg/kSh7sEyUFMg3JSE6X7rzMBTaU7U8xJHMoVGs7L6GPv3E6O3UjhWK8lktSBRXAl9NZO2CjK3c27jAXUTJeAl6BiBsm/nBLybtU0KkH4IfUOm3AsuHH3ebfRdhjgDU4Clo38wm9SykGpvstLeOO04wAJ02WtHrqUYQxNvM63zhGdpbHL701yLym8MAP1GvMubWpHNL1nzmmdw5JTSQ748AHP21rk8QFSYorAMyhP3zXpsYi0SUcqOWh/qwaZrc55MwetBuj2AMggboyi4RDVll7a9Pj2HY2ZU4BSfKU5reiQBp51rlMJikUkV84hU1BFMG/YzQGygPO/p7jLYwddt9Fsk+T5gxCo40NHjwWXJbF5O+DYcVnXS8P6EdCtyyasxHzMRrYVIOhwLjyJ3pRBrIUGYjXYCBso= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(39850400004)(396003)(376002)(136003)(186003)(478600001)(31696002)(53546011)(41300700001)(6506007)(66946007)(26005)(6512007)(2616005)(38100700002)(4744005)(31686004)(2906002)(5660300002)(8936002)(36756003)(316002)(8676002)(66476007)(66556008)(6916009)(86362001)(4326008)(6486002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SEVySVFRMU9CaXJwaUM0UGRHQk9wRTZOVDJ6am9rcVk4MWljdEZ3UE51WWk3?= =?utf-8?B?RUdwNHhZWEZtU0VNY2tRRDJXOTYzT2VGRCtpclVKR1BxMFJYYkk5VU1sTVE0?= =?utf-8?B?U0xvUUJ1RmhtVnVScDdOeWJTQk9jenFlc2JXQnJDRkg1MkdlalJ5VnBqakQ3?= =?utf-8?B?UzBia3gxN0w1cmRFZHlRTGs3eTFnWjZkaS9IUlR4UDdVT29OZTNJWkRPSm16?= =?utf-8?B?NGlxVTVMNnVRaTdFN1A2ZFJJdGozRGZ0Z2o5T2VWcHI1dVpUOUlGaWpCSFll?= =?utf-8?B?c002VDhGZ3lVMERFVG5JM1dEY0lqTVZsOEtCM1lnZmJpRjVzQlhPditFbU12?= =?utf-8?B?OGFpTE10ODYvUlJRVFZ0NWlnNHpuRE10TExYblZva0o0RzBmQUVnNy9iOFl1?= =?utf-8?B?Mk1jRHBnRmZyMDlIekhPNXZaeGs1UkxtSGJvMS9OT2MrUGNjWnJjeXAzUkhR?= =?utf-8?B?ZkxvaXBNZ3NieERLZlF3SmRsWE0vYzlyaHg2QmxjMlZ3NlBMaE8xcXo0K05i?= =?utf-8?B?SDU0enJkYWRUNjBleW11NDB0UGZGODVPc2wzOGpaMFVzM08xdCtWUFduYTRx?= =?utf-8?B?S044T0tMaHJMNmNxaGpiOFRjLzVxVjFBbVFaOVdsdFoxNW9aUXF4K3dFWUZN?= =?utf-8?B?bjM0STN6N2E2Q2t2cmZRZjVwUzBoUjJPNEtVd243eVczNDZzRkh0WExnWkkz?= =?utf-8?B?UmxZQWhDVUdHSUpSaWdhWUljdHJFSngzV3hMeXl1cmhrNjBuK3hzZHlwdm9x?= =?utf-8?B?SjJGMnZzSXBrNCtGSE5xenhsd3ZDc1hBa0NuZjlWbDJJY2M5cTNjdVFCZWN2?= =?utf-8?B?L0srSVUyME1lUXptNWFyKzVKU0NCMWlrNkRPMU5lZ1h0ZUhnQkRsZkdESzkr?= =?utf-8?B?Ym9ZMnpVV0JtQUppWXB5bjY0WGVNRnZucXdOcUpHbU1MRzlaL1VnamFsbEYv?= =?utf-8?B?WWFaR2tKZXpLMVhCendNVTQ1R1cvaHloMSs0MkVQWVhkdmV3VzNsb3RrQkZu?= =?utf-8?B?TER2SmJGeFljNXI2bFV6Q2ZhNE55WXlpYlREVWlta2I1L3duRkg0T3Fkd1RF?= =?utf-8?B?WG1ndi9iSjJrZFBqUlhHYy9zWkpyZVJYaEJ3TTlKelh6OHJMbzdDL1MvNW1w?= =?utf-8?B?Y0piYVdpOE9OamRqOGNHQmdyc3ZjbFVHZlF6TmhxbVdjbzFTdndjVmJPTDY2?= =?utf-8?B?cUhtejFTaWVyZzlmcDdIU3RIdzFaL1ZCbmEwdDdPdlk0eERSbUlKTW5hOWVw?= =?utf-8?B?RkI1YVJya21qQnE1Z2FBUjlKYy9MZ2RrUEJZb2s3MDNISU82OGF4WnVtWHJZ?= =?utf-8?B?YnU2SUdtWWEvZ3NqdXVGa2ZCSkg1bHY2SE5MWjlHcThkZGorYmI0VmhKS09N?= =?utf-8?B?cXF3bzVpalBOSW5qMGJVWEtlUU41SkNITzZZUVFSc2pHVFlTK0hJaWFkdGR4?= =?utf-8?B?MXFzTlBSVWs5NUJ0OTdlTFJhSmhzRVBaWjRYdHlEa3lrR2JmL1FwL0FEM3VR?= =?utf-8?B?MXhHYWo2UzZTTVpFeTRXc0tZT2l5OVZNM0V5d1UzYlhCeVRrdlpGQnp2MDJx?= =?utf-8?B?Z202UWRXemFOa1o4YkY3eXpoMzZualZRL0xWQnZiakJZVmhiYTFnRVQwem5V?= =?utf-8?B?NDNlYUcrU1ZsMmxTY2hLVXhKenNDcnlQcUZ4TGJMaWo3TEEva3FkZFU1YkZo?= =?utf-8?B?RnpyRHRpcW9qdHNvN2ZzQ2NsVTA2NnMrdFJzRWZWdUwzR0FkRnhIV3U1R2gr?= =?utf-8?B?b0crUHVIM3RxWnVFYm1RbnFKQXlRNVRsUTBNTXRMcmhVMlQ4OU1GbUJqYlBH?= =?utf-8?B?SmdCdExIMHZuR01DZXpNZklwNHJzaWMzYllaTWs2RFBqZSs4VmJHaitYZ0Yv?= =?utf-8?B?YnNsUUI5empJMlJqenUxekZEdE9nR1VEODRRd015cEVsM21XWjJNUnV0UDQ1?= =?utf-8?B?MEtJdHB1Q3pNeS9vMEo5NE9iRm9hZVFnU0FpcEZJQ01mdzIrTWt1Q0ROWDU5?= =?utf-8?B?bGhQb2Vxb3NCS21kc21uQzRrN0YyTFhRWThaTGVRYUZ0cFFrWEVCK0NCUERp?= =?utf-8?B?dS9tRXRIaXFmYjJGZWM1Y0VXenVmVXUxSUYvaTg5WjNzLytqMUlzYUxPM2x4?= =?utf-8?Q?h62l2uaajo5QVCEhWs62WtV+4?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2088236e-1ef0-46af-0884-08da630922df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:46:51.8650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lLFgpuCmqKRLMagidxKsqd6pLQELVr9Fkdnvu03xFbN1V2btNNjshOyLgNZ+OxZ5M9aQhGTcqgJmTIzZoklpUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3061 On 08.07.2022 18:19, Andrew Cooper wrote: > This was an oversight from when unpriv-mmio was introduced. > > Fixes: 8c24b70fedcb ("x86/spec-ctrl: Add spec-ctrl=unpriv-mmio") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich I'm not entirely certain in how far it wouldn't be useful to mention that "spec-ctrl=no-xen" is similarly corrected by this change. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:49:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:49:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364868.594823 (Exim 4.92) (envelope-from ) id 1oAnES-0002sY-S4; Mon, 11 Jul 2022 06:49:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364868.594823; Mon, 11 Jul 2022 06:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnES-0002sR-Nb; Mon, 11 Jul 2022 06:49:24 +0000 Received: by outflank-mailman (input) for mailman id 364868; Mon, 11 Jul 2022 06:49:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnES-0002sL-Bu for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:49:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2052.outbound.protection.outlook.com [40.107.22.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98f29b94-00e5-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 08:49:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6096.eurprd04.prod.outlook.com (2603:10a6:803:f6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:49:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:49:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98f29b94-00e5-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UFaYP1gbWg1L/HHV9QeFLlTdPlotE5wYdiYsfXw/+CvfdL9+smIaD+EWYllZb+UdRxxU/ZeAanorLnfSbbhsPDvOPzraMOh4Cx+EnjgJP04nQPVMAsVohL/ZkOhdvjUohLWAQqok/RZpesfXpn1qNPBSO5WAPTGRUCE/s9kgTaKP1uKdIps888/NCYhNby4YDJGyUmCVyVSwuYhbNdVWA9iQ0wkfVHVShFRsXAJX4SCWZCAeRMAA+Yt4VgwaKBmnal1c5kCS341vVQ5Bzp7WGEXqPRM7BnCrCnQSzvZO6k1GkkF/WxrQwkAhFcdMNcS+gGj0DrRpp69zR5OM4Pw96Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RHJyWPEeuM2dfUOwCD7WXTabkMnns4N96cScWwbhG3k=; b=S8DBKQd62uT+K3leSUtiE8oINvwX44jfmfpyU3dp05PjHO5t9OJ1vuEJHo3QIXgctDF03Ve7SED+dcLxovzsMJePJLRC5pw7dZWzbQBiX9jKqcSzbsOaKLSdlAMVeTDlUl0MCR6nFwrHz63e4TpnrAnIJHwyQpRvNABJTljSGE1exocd5WZOo+7mM8BzVfwrVsfI1JJw7kKqA5y7bMUyLrUMxqAiIcm4Wqw/tw2CBhEwudbkXNziq3hxK5WENLGOqEbu+/s4JNpl4OxaQAMsWdgqxFcG3/BkrTH+g4PnRoEoeKyUlNT+rB2twuEHjJlf18a2l3h+fstJRB59qPqnzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RHJyWPEeuM2dfUOwCD7WXTabkMnns4N96cScWwbhG3k=; b=nwldtidMarKMWr9DnWl4Xht9iUJhsCHdyUjDcFNZHr5EkCjAhXk89bfkwZxVod0ZXOzY6vut7t+V6vmK9/2lpEyKeXXX32D6ReO5pJncq0Rs6x3ZGhAMVS5BbQVe1SWQJXRPUrKZdOvlCMkvkZFZNPOqwwqhS1RgnrBY4xojmBZ6xx7/STp842VYJYOekYo2DsEHDvlkr321+pmKGBNUrhMwQC8WVMwU/DDg+Nn+vndrroxsh4wWq79vISAjPb3VemW5PWTRuctDM2ZLTbyLLL6QUxN1dSF9VIQ5oG+Rom7rTgB5p0PKBTcIqw5bLEGnMocyZcYBnVGOlf0Zx+w2tg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <56fcd704-cee2-2c49-fd03-b2271212ade9@suse.com> Date: Mon, 11 Jul 2022 08:49:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/3] x86/spec-ctrl: Add fine-grained cmdline suboptions for primitives Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220708161934.10095-1-andrew.cooper3@citrix.com> <20220708161934.10095-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220708161934.10095-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0049.eurprd06.prod.outlook.com (2603:10a6:20b:463::24) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6fd0f8f-f3a8-4309-5485-08da63097b95 X-MS-TrafficTypeDiagnostic: VI1PR04MB6096:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Rp3fR3uQ4PD4BkoS4VIyZP7NzHP4efGsSj5gMjRNtNIkbi/OFE5oa34ivKsIG2+nK+nSuDtbM+Iz+AimsPKC1tGr2PWsHJs9fN/ecpd/xFrdF9XwHTNlEO8J8JWAkwkGb7QjBg5VKs786pGgdtZYrE9gpnIQ+Kz3CIfMExfXMgw0KEf0jRxTs7za2XcIseOgh6LqndTKxEiY1e0oCAwEJQoihdThVDDBC/w2AXYr6ZlNidxOPSIqh9x9iIm3k/lg9t6Ikw0/VIz7r4NQaRiNOmk9fOPayCuZzK/+cKKRXMGLfBx4wz9LvtyGo8EhUyLcatuuy0qfLf9tJNofXi0tuj/8ePo2BpDtAkKGApKX44fG7Me3cTB0kSFnV0Oh9rrMZc8T8uVzi3BLhWwnO92H2ONfHGrYQmrKdO/qs89/gJvE7mYyjWSKMWsYSHqmsrVs6TG77qZ+gX8Y1jSDK9BIt0dRh5G5qZTVmPh+4zWku/4jSewZDIyxfNmPc9zgp9xc2kkO0GZI2oLHkHGDBMW/1dlT+aHCsygF09IbDKr42qEmXEwjIZ7cMCfbJhUmE+tstM0Gr4mwelArJ/tgVMfA30OEbGRihMNch4jY1k0Zix3HeelwuDfXiWlgQ9ZezdVDiHV5MuiJ81IY0PrcO3gfczXfTfVeNuqeG3elplATOBYulE6DmlNvJ61ROIa8uXeqcZnRpqWwwF9PGPGeysuP2IiSnH8hI0VH8s9EA7bVkXsDrPPmbDXZ52Z/EU/JbsFidgXoEKGbRL6hBLXQ4vOvag3dzKwvOCWKm3DhBK1Mvb6CbD6DIVvdjeMBV7NiTE3B7brN9+7qSby18u+bJeJ56fQeOom2CXgpHunxhN1NTs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(396003)(376002)(346002)(39850400004)(5660300002)(8936002)(2906002)(31696002)(86362001)(558084003)(36756003)(38100700002)(478600001)(54906003)(6486002)(6916009)(4326008)(8676002)(66556008)(2616005)(186003)(66476007)(66946007)(316002)(53546011)(6506007)(31686004)(26005)(6512007)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3hQaHJWeTBFbDcwSTFwUStGSGRrUE5Vc0lvWFk1S1IyYmJNTmJIOTJGSUVF?= =?utf-8?B?bjRsdmc0VDl5b1licGpkNXlteEZqemIyaUl6d1lKaStxa0dRUU5hWVcwRjJy?= =?utf-8?B?OHQ3TjhxWktQaXozL21tNmN3aW1obXZhM0VQZ3pCZWJvTCtFTVpneGR1NFdQ?= =?utf-8?B?VHRHbFNqMUozOEVUMi83eXF1b3kxU09CVzNlTHZkTHU0ZFRpV28xVTJLeFFk?= =?utf-8?B?Wk9QOStyT1hzT3VoTzZuVHBDOHdwZlZpRnZtUk5UTkNFWlZYK2FPckx3THBK?= =?utf-8?B?U2FkcmNxWEJMTm9QQVdTZStFNnNwZHRtdWp2RWxPVzFnL0RJNmJTOE4va0Jl?= =?utf-8?B?Wmd5M2tWTnA1c1J0N1VJc3lDZU5Rd0s5OU55MnpWVHNjekVIOHRkeWdQSkpN?= =?utf-8?B?TUFuVkxvVUV4MHVQSTBpRXl5cFdjbWxFOXV5YTJuQzhwdkJuVGtXQWVFUDg3?= =?utf-8?B?K1JGNU5pMHllNVBPdFlNV0tWVmNFTjdPa3dCb3VNdkF1UjQ5NHlYcEIwWkk1?= =?utf-8?B?SGJhb1F4L080M3ZaaXJYcVB1d29LVmVyZkJzcUwyYXpqVUlyb3RNVTVjOGo2?= =?utf-8?B?V0FGckJxT3N2dVJpS0puWWlJdCtpcGNSeFlXeGluRjBLamVBSWRjaVZ4MUVK?= =?utf-8?B?bzJkb1lZcG1VcFlwOHZxRUZGSG85NkV6SytuajI1UjRhd2VtbzRiOXRqZnRv?= =?utf-8?B?czJCQ1UzaTYrNUltKzlpRGR4MXVpNDl3Nk9nV3dpVm16MHVMT210aTZHcmlI?= =?utf-8?B?RGtCMmtVWkJwRDVySEFiR0lKYWwzOS80V1UrMEJGcUF3dWphNVdENW5UNXJ3?= =?utf-8?B?emNIeUpVODlYdDN0Yk5iVjNGVzB3Ym5vVVY1d3IzR0JVdFJuUVlhZjM5UHhW?= =?utf-8?B?cklCSG02WEhQdmFKeWpRMUJUQklESzZNem1pK2F3S2g3NWNEQ3c4TUVxVStV?= =?utf-8?B?QkxOcUozQndjSWlUbDFqNjlNZCtlQzI2d2JSL0lBWHpWV3Q3SDU4ck8rUzgx?= =?utf-8?B?MFF2WEhoeThIMkMwaTVocGJZY2RLQngzTGxRZ1IzbjROTVZPRGJ2bnhEZU00?= =?utf-8?B?SWxtNXVUdXpseWFLblJ4dTF3b1JXQzhNWGRxY1QvdjYzVVhucTlPMlJXOEg0?= =?utf-8?B?bER6eVNnYWo2N041ZDhzL2YxR0Y5N3pIU1cvT2VZd2ZTSTBDaDlyY3dEU3FB?= =?utf-8?B?S2dLRGoreFhKKzgreUlsN3ZtRlNiTTlldkpWR1lHSVdCWXk4R1NWa3VIS242?= =?utf-8?B?WEwySFEvTXhGVlA2VzBKQlV2djN5SStUbnEzTVI5RlZtcUYxdHN1SVNUR0pF?= =?utf-8?B?UmxldjBOSmFYeHVZeng3VFBBc1BVMk1HZnRUZjdpdkkrQXlKbndzc1gzZHhJ?= =?utf-8?B?OVludmZCbzViOUhsTlM4NXBuUm9iUTkyZGtySnFJcVgwNmpHT2FUN1lWNG0z?= =?utf-8?B?WlBKenZWczFKa1NITnM4cVRvd1N1clpiM3NrUXJkNDUwV21tMmMxUk1NYVFk?= =?utf-8?B?L0Vub3RQb1JxU0o2d3dYVlUyUWhWeGNzOHJPemdsNklVSUdzOWRqcTE4WEd0?= =?utf-8?B?RW5Jd1JrVURMeVZSVjVvSnpQaFhFM2FFNzZVenppUFBlMDBOR0Vxd1A2d3Mx?= =?utf-8?B?K1k4VEZacGZKdW9BL1lxd25kY1R0ZzVmZ1cxd0htL3FLWC9SVldkb1hMMWtr?= =?utf-8?B?ZTY3bkdSQjB6M3dTNUlObnJOMWZqQ2RUQjFxRkV2UFloVTdYYVpNRUxTZ283?= =?utf-8?B?T1VPS1J2U1Vmd2taQWVXbVRGTjQ3T2pTNGV2SlF5RWFhYisvL1J5NjRjMzls?= =?utf-8?B?OTVoSnBXMWtCdFdhcWhQMHd6STZNUit1N1BnekJtaHJzTEFJcVY5aUZtbTh6?= =?utf-8?B?MEpvSjlSY05OQ0JqTmtpWnZFdzhudEZURUx4Z0JGSnd5ZG5DaElUdVp0Zlcy?= =?utf-8?B?VlczdnBMRCtQVTg5ZFY2Wm1maUFNNzl2ZUVtQ2w2bHlWeXo2OUdGdmZhdmI2?= =?utf-8?B?ZmpUS1M4WTNML0EwYVNKcG5hbVJuOHEwN2QzYkRTekI4ZkhKelNqZHdRYWdH?= =?utf-8?B?MDB2TEN5eGxPTEg0RVFDWTBuMkVnZEdxbEYzNzNNd1IxTlVsakJ2NWI3Vlgz?= =?utf-8?Q?v4H7R3jIjtQwhcUDmh24zmeMx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6fd0f8f-f3a8-4309-5485-08da63097b95 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 06:49:20.7148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aNKbvQL1VsqZFyyaCOfGZ92/3v/+3l9HnScXmxQIM1jKsl/mUwzu1NstsrCH0S95zubO3tv/Foxjs2n6fTSqXg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6096 On 08.07.2022 18:19, Andrew Cooper wrote: > Support controling the PV/HVM suboption of msr-sc/rsb/md-clear, which > previously wasn't possible. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:54:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364877.594834 (Exim 4.92) (envelope-from ) id 1oAnJI-0004Ll-G2; Mon, 11 Jul 2022 06:54:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364877.594834; Mon, 11 Jul 2022 06:54:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnJI-0004Le-DA; Mon, 11 Jul 2022 06:54:24 +0000 Received: by outflank-mailman (input) for mailman id 364877; Mon, 11 Jul 2022 06:54:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnJH-0004LY-5X for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:54:23 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 49d3033e-00e6-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:54:21 +0200 (CEST) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26B6hKCk029828; Mon, 11 Jul 2022 06:54:09 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3h71ttuecu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Jul 2022 06:54:09 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by PR2PR03MB5306.eurprd03.prod.outlook.com (2603:10a6:101:23::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 06:54:05 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 06:54:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 49d3033e-00e6-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=neYO65rKganpB2LJc6WzVe/dOa9wKDZFOdO5TxJmQXaf1EihuYioBoYqG466NHDE+F6QLyuZnfVgKuyarq2jwLoM/wjxCEOhhZsH5+lYVAi5N08h4KgmryvzOtHun/FBgeuv2FKc0LjJZXCySbVtnZmtOtf1BO9zlfliZv58BE+kHY3YP6W7yJBSbGduYrh+zTwnJdl94XVcXLr9B7Gv3NpyXSifo4d3KIic4lDfErFR3pqlRFn+Z8lU5GtOB8EANZLkugowvgczkPXnqDtK/s96yfOPCRQHrhUoXCCiOQiy/7TYnBtDL1FS0HruznjwJAX1+iUf4sCMB/32PkdwOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pXNildLuXdb8Lep+GhPI+Ajed3Aqd60JVCApvAu7LTU=; b=mXcWWVuCUPcO+lL1LrgT3nTQIH+wwl9leH0o5RJIGDhcdHc/IskNIdIPj0AjZbpxxwJWD+kcv/cqHE5pZAIq6mE36D6ojtgYuSwKVXwlSa+rd5XWjLc/baP9eatwFbtomqNZnn18wBsa9vfCXySfqVadGuuunCaBOqab8AKLIH/oNymFX95FFRjuDyxv2xOHDp5gEiDXfwD+2Ngubs7unj/XlYrmRwtHlGXPoviQGJ6fMYvoNpztwOOKXg+kF7fNMyOkirzdXBQEfvcc8BVEh6aFq8kg0bM0TJz38Sf0I3sL3gqDjeu22UlmpC4P+/98dEczT0QbEwP+IKxCqcxsyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pXNildLuXdb8Lep+GhPI+Ajed3Aqd60JVCApvAu7LTU=; b=YGIrAK21DF9Hz4lklHUx8jkUsdDLEhBEVYM+VDOBy5vkB4vodwhvScXbTiQyEhBIEhy/jUptAGgAfWmeafag4yTB98l6GqyAYcHNrh5nJr/OGHY3VkwKwOxYA5LRbaIm7ESA3SZ9PLpqGNG7A0NkSUHdiJ7z/3Vltx387nN/jAfDX9YgvOTJkN0yjClyU8zznyeo9sQnXUWNqgxc3tWJNoLKv/PFsUta1/4keHwfopULlIH+VFr5oLIoGF+LoWv+gv9TUOLVO0MvuIeS36xiVzttDr2FmA1FALdyS5ci6G4PC2jzho5pjQjmmQMWvxjX4p3I6vh6Pt3ZIYiyQ691MA== From: Oleksandr Tyshchenko To: Demi Marie Obenour CC: "xen-devel@lists.xenproject.org" , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Stefano Stabellini , Juergen Gross Subject: Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Topic: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Thread-Index: AQHYlLGV8Y7Nvsnbgky2zNBgiFu4I614vKAA Date: Mon, 11 Jul 2022 06:54:05 +0000 Message-ID: References: <20220710230522.1563-1-demi@invisiblethingslab.com> In-Reply-To: <20220710230522.1563-1-demi@invisiblethingslab.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b41df076-94e1-48de-133e-08da630a258b x-ms-traffictypediagnostic: PR2PR03MB5306:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: S0B8tpeAYw/YW5fX2oqo+tPARFB15r++koy2sM4/6cv0pjK6gNmJhBBePVm/SsJNtG9LM4kZEBV68rKD2W2XwJfDCmBvpf97JaC2EmDGmYspIKHpKCz29EdPtBgs86GbTGudV0PXRFcOy3Qb140VMVfTx6eDerdwEfL62ShRG5bGmWdatIrJVCMv3RVJp13xxA2xW0+k/9p2WrmP+RGPAXFhTYJfeU5aAY/d1dNtAGXOcD8KlgO1lf+bkEjjWHv3enb55LNYOW9dyf4il9TloihusqL14dI0alfROw3XcGzgxv9d9p3PJunhkgqzASXZnOdUxxr71gp58Negzb5zTOwYmOg6r9YJRxByHaTaKQIGd1CcWYSJ1qsTNaUcFD9gfXWo9Q9+dsTJDgvgjfKfMKmS5CnCaoFalBVhkUOd0mFVr3i3s2Z0tZqWNOMvGioXhFnOV3dAbTcqFmPN1xXfcIHFVcVHtY8AH3I9rvym7UNpT4eCl+xE/iDAkD1XXNhoMHvRKq72Pg/ooDPdkrQR/XF3RFC5yDxmM3T5T6aAjPWJAqOFe3kI1MUqqc+Hx7aH5TsoUUSkWjsXUS0e4z0pQaXil7Ob296Xudvh8yG6SOeiadD08xAswZmR39uHyQiIHO1x4VBtEmiFNaMZBsd5jVvoLNXWVj/O8wtw5Q3Zle390HecrTqqfJHC7w397ZYoXXcwwO+7yPh20CqoOcDj2BVNq6+OiyF6NtrNN/HneSuGcPTu3FfHzf/rejM/yGnUDKEN+Fnu33NPNL3ALz0wSgdkVoULmmjKyBrEcJMNpSmnTnAaazKDHsvaY6aIBj13zW7NiHYItAvIiJ0I05B8EPVHU7eVuE5puo2oNYpRm/k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(71200400001)(4326008)(54906003)(64756008)(6916009)(316002)(8676002)(36756003)(66946007)(91956017)(66446008)(5660300002)(8936002)(41300700001)(66556008)(478600001)(66476007)(76116006)(6486002)(31686004)(83380400001)(2616005)(6506007)(2906002)(53546011)(186003)(26005)(55236004)(122000001)(38070700005)(31696002)(86362001)(38100700002)(6512007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bUJ3Sm45eUQwbi9sUmhtQWZVV2djNWtaT1FkWjRMajNCS2dNRmV4VFE2M0lD?= =?utf-8?B?VmVVYi9OUERvSEs3UWFadFkzWHhod3JPTmhBd0t5Lzg5WEx3V1BibXRaUHBW?= =?utf-8?B?Vy9KR0N3SmlvbEt6Ykt0WXBoNzZyZWZDci9tSldlUmg0Qml4Q1FGd3I0R2Rr?= =?utf-8?B?NXBMdUpxM0h4NTV3VkVLSzZCUWdpV1VybzRybjk0Z0pCZ01IRWpuaUtza2pN?= =?utf-8?B?YU5uOGtUQVJya1kvZEVSZHo1VXVvbDdhR09QSlpiVng0cWFRU2R2VjBlb1Ju?= =?utf-8?B?VVpPcDNZQVZDcjZjUk1pdmNaZUxtV3p3cnZkR0ZpWWp0M1VaVkR5RWxFWjg3?= =?utf-8?B?RU85VWx4b1Yra3hBMmRiZkNkMWtnVFZtU1RkMUMwQmN1UTFXYVViSTMwNmpn?= =?utf-8?B?bzBhRVJ5SzA2dVdpeDVaODBnMzlMZWpzaEZvWCtRNFNxSjh4aUZzMW9IMXVY?= =?utf-8?B?VktaeFk4TXR3ekExOVlQalFDOGloS0hhM2lpZFM2Skw0TzB1TnBjMUR0U2Zw?= =?utf-8?B?S3UwTHZYdTMyaTVKQkFDRFV4eUNaRlhldFg1c3A2Q3VoL0ZBazlEMXBpeWtG?= =?utf-8?B?UERCdlNteEpyNElyeGEvREgzUkQ3SUJzbi8rRGFiQk96b29ocEVTR3NUMnND?= =?utf-8?B?SFZkVW9yUmZjd2ZKeFNMUGdsM1g2cis3YzJkcmdrSXZBamhMVnRMbnBiSkEy?= =?utf-8?B?UUVETUpoZjhUVUJGajg2clc4Y2tYK1hSTlVZQi9PMkxtYWxRaVJwKzQvZFZ0?= =?utf-8?B?OUsyMkN5R1dVVUx2aEtaZXNtWGJxaWN1Yy9HZHlwS0w0OFkvc2J1SlQyVnM3?= =?utf-8?B?Wm5lNXZHUTZSTlB1ZkdTd3lRNS9ybFJxWUxydy9Mc20wK0d2NEo0TFh6a3FO?= =?utf-8?B?bVY0ZGM2RU54QjVUL2cya3N3N2VnZkJhbzEvakdDdzVycTFzV1h1aHYwZ2RP?= =?utf-8?B?ZW9QbUlQcWNUNWZmRUlUWUxYbFFhd2xPT2RjV1dJbDhOUTlvZ25NSGg4WHhi?= =?utf-8?B?b1liTFFuRE04aWdTSTIrdkVvajJwYTA0Vm9RSlJVc216dGZkdG15akJHa244?= =?utf-8?B?NGhFbWowVFdRb3NkTmxSYlRYc01LaW1PNjExbnpETUJINGp6NHQ5ZXlscmI3?= =?utf-8?B?SVRpeFFQY3NnNzdVRThwb0EzbFo5OWRFUnVSajA1Tmo3WURXWTgxeE16Q2Vk?= =?utf-8?B?Z24xZmxnRWJzT0tUSEtJTXpYL2VLVm1JS2xEdGtTS3MvZ25QNmZmWnd4U2FR?= =?utf-8?B?cThyRG5DNUMyVWVhOW5LVmc1RkgxYkY1MGxxMjNoSzQrc3dKZ1J4V1VmNDJw?= =?utf-8?B?SnFMN0RkUDhIUjdCTzY3Tkd4ZmR4WkFoMzgwSUtUcUlyaVI2R0hsOEJtbFJ4?= =?utf-8?B?TTErTk8zNnRvaDJZQ3U5bmZjalFJdlRsa0hNdldWSTh1aWxoZjdsRmp3QVhs?= =?utf-8?B?TDExRnRlSFdqZEM5Z3BabGFGZ0xDZGxOT1c2U2RKOFBxT1lmV0F4a1ZQc0c0?= =?utf-8?B?d05kenVnUHViQUJyeDlVVmxOU0dZbXRVZ1pnYnE5YmpQNlRMMG5BSTJMbDRV?= =?utf-8?B?ZnJwdmdIYktGdCtiU2wyUFNiUmF4RlYxMy8yRlUxdENDTXN1cURBOFVxR0Fh?= =?utf-8?B?RjBiYkxlc0dxUWNSMy9nQUJHK0tiQW9INlgwUnh1NklldmRGRSt3bE5zbHly?= =?utf-8?B?UHlwQkZXVG9MQUxMZlM5Y1h6emVvN2ZwUHVOWmdhVFBWMFZ1ZHdJRDBwMVk1?= =?utf-8?B?aGJicVZRZElOT2V4WmU5Q3Q5Tld4dEVDS29iaGpZcU9JTUM5dUc1M25jbnFY?= =?utf-8?B?dUdHb2RPV1NoSksrcTl5YjJhS0NRV3daMnJvS2NFeW1BQWR5NjhHSmlFY1FR?= =?utf-8?B?MDg5WnRlSEJqWlR2VmtBdXZFNnZRWVZadEZMRG9oSFA5ZVJzNWRTMGhRSjZE?= =?utf-8?B?M01tQndFNjJGSmJIeGg1ajVLRFBXazlWRHRwZC9Tc0puUTVKUFhRY0JaMkQ3?= =?utf-8?B?VDg3MkFObThtYm5VV3BFMFJBUUxqaHJjZ2lYTUowTzdIdlBveU5IaUJOSitO?= =?utf-8?B?ckVIRUhCNEY1anZGQ1JXNkJXWEtVaXJrZys1TUZwMnRYNnoxVlc0RHB2R3c1?= =?utf-8?B?SXpLaVNCdSszYlc1MTdCemFFS3B0ZzFncmVLK2QrdllFVE1NZ0QvUjF5ak5a?= =?utf-8?Q?jrNadq61XzYba9Xzt6AUEYM=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b41df076-94e1-48de-133e-08da630a258b X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 06:54:05.6571 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2M/d6CqEX3YvRI4TFf+L6yGFTG97EXtbejKdXzW7rl7EPIPh4kprkptAt6GdqjfGtCIN7rmG8NNg4zow8bd3YepohW7Lyjegk4q+MZrTLNo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5306 X-Proofpoint-GUID: fscVwrjyn69Ck4mtTOlBkJVYUyqDfB_0 X-Proofpoint-ORIG-GUID: fscVwrjyn69Ck4mtTOlBkJVYUyqDfB_0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-10_18,2022-07-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 bulkscore=0 impostorscore=0 suspectscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=375 lowpriorityscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207110028 DQpPbiAxMS4wNy4yMiAwMjowNSwgRGVtaSBNYXJpZSBPYmVub3VyIHdyb3RlOg0KDQpIZWxsbyBE ZW1pIE1hcmllDQoNCj4gVGhlIGVycm9yIHBhdGhzIG9mIGdudGRldl9tbWFwKCkgY2FuIGNhbGwg dW5tYXBfZ3JhbnRfcGFnZXMoKSBldmVuDQo+IHRob3VnaCBub3QgYWxsIG9mIHRoZSBwYWdlcyBo YXZlIGJlZW4gc3VjY2Vzc2Z1bGx5IG1hcHBlZC4gIFRoaXMgd2lsbA0KPiB0cmlnZ2VyIHRoZSBX QVJOX09OKClzIGluIF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9uZSgpLiAgVGhlIG51bWJlciBvZg0K PiB3YXJuaW5ncyBjYW4gYmUgdmVyeSBsYXJnZTsgSSBoYXZlIG9ic2VydmVkIHRob3VzYW5kcyBv ZiBsaW5lcyBvZg0KPiB3YXJuaW5ncyBpbiB0aGUgc3lzdGVtZCBqb3VybmFsLg0KPg0KPiBBdm9p ZCB0aGlzIHByb2JsZW0gYnkgb25seSB3YXJuaW5nIG9uIHVubWFwcGluZyBmYWlsdXJlIGlmIHRo ZSBoYW5kbGUNCj4gYmVpbmcgdW5tYXBwZWQgaXMgbm90IElOVkFMSURfR1JBTlRfSEFORExFLiAg VGhlIGhhbmRsZSBmaWVsZCBvZiBhbnkNCj4gcGFnZSB0aGF0IHdhcyBub3Qgc3VjY2Vzc2Z1bGx5 IG1hcHBlZCB3aWxsIGJlIElOVkFMSURfR1JBTlRfSEFORExFLCBzbw0KPiB0aGlzIGNhdGNoZXMg YWxsIGNhc2VzIHdoZXJlIHVubWFwcGluZyBjYW4gbGVnaXRpbWF0ZWx5IGZhaWwuDQo+DQo+IFN1 Z2dlc3RlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPiBDYzogc3RhYmxl QHZnZXIua2VybmVsLm9yZw0KPiBTaWduZWQtb2ZmLWJ5OiBEZW1pIE1hcmllIE9iZW5vdXIgPGRl bWlAaW52aXNpYmxldGhpbmdzbGFiLmNvbT4NCj4gRml4ZXM6IGRiZTk3Y2ZmN2RkOSAoInhlbi9n bnRkZXY6IEF2b2lkIGJsb2NraW5nIGluIHVubWFwX2dyYW50X3BhZ2VzKCkiKQ0KDQpSZXZpZXdl ZC1ieTogT2xla3NhbmRyIFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29t Pg0KDQoNCj4gLS0tDQo+ICAgZHJpdmVycy94ZW4vZ250ZGV2LmMgfCA2ICsrKystLQ0KPiAgIDEg ZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+DQo+IENoYW5n ZXMgc2luY2UgdjI6DQo+DQo+IC0gVXNlIHVubWFwX29wcyBpbnN0ZWFkIG9mIGt1bm1hcF9vcHMg aW4gdGhlIGZpcnN0IFdBUk5fT04NCj4NCj4gQ2hhbmdlcyBzaW5jZSB2MToNCj4NCj4gLSBFeHBs aWNpdGx5IGNoZWNrIGZvciBhIHN0YXR1cyBvdGhlciB0aGFuIEdOVFNUX29rYXkgaW5zdGVhZCBv Zg0KPiAgICBpbXBsaWNpdGx5IGNoZWNraW5nIHRoYXQgaXQgaXMgbm9uemVyby4NCj4gLSBBdm9p ZCB3cmFwcGluZyBhIGxpbmUgYXMgd2l0aGluIGEgY29tcGFyaXNvbiwgYXMgdGhpcyBtYWtlcyB0 aGUgY29kZQ0KPiAgICBoYXJkIHRvIHJlYWQuDQo+DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3hl bi9nbnRkZXYuYyBiL2RyaXZlcnMveGVuL2dudGRldi5jDQo+IGluZGV4IDRiNTZjMzlmNzY2ZDRk YTY4NTcwZDA4ZDk2M2Y2ZWY0MGM4ZDljMzcuLjg0YjE0M2VlZjM5NWIxNTg1ZjNhOGMwZmRjYjMw MWNlOWZiYzUyZWMgMTAwNjQ0DQo+IC0tLSBhL2RyaXZlcnMveGVuL2dudGRldi5jDQo+ICsrKyBi L2RyaXZlcnMveGVuL2dudGRldi5jDQo+IEBAIC0zOTYsMTMgKzM5NiwxNSBAQCBzdGF0aWMgdm9p ZCBfX3VubWFwX2dyYW50X3BhZ2VzX2RvbmUoaW50IHJlc3VsdCwNCj4gICAJdW5zaWduZWQgaW50 IG9mZnNldCA9IGRhdGEtPnVubWFwX29wcyAtIG1hcC0+dW5tYXBfb3BzOw0KPiAgIA0KPiAgIAlm b3IgKGkgPSAwOyBpIDwgZGF0YS0+Y291bnQ7IGkrKykgew0KPiAtCQlXQVJOX09OKG1hcC0+dW5t YXBfb3BzW29mZnNldCtpXS5zdGF0dXMpOw0KPiArCQlXQVJOX09OKG1hcC0+dW5tYXBfb3BzW29m ZnNldCArIGldLnN0YXR1cyAhPSBHTlRTVF9va2F5ICYmDQo+ICsJCQltYXAtPnVubWFwX29wc1tv ZmZzZXQgKyBpXS5oYW5kbGUgIT0gSU5WQUxJRF9HUkFOVF9IQU5ETEUpOw0KPiAgIAkJcHJfZGVi dWcoInVubWFwIGhhbmRsZT0lZCBzdD0lZFxuIiwNCj4gICAJCQltYXAtPnVubWFwX29wc1tvZmZz ZXQraV0uaGFuZGxlLA0KPiAgIAkJCW1hcC0+dW5tYXBfb3BzW29mZnNldCtpXS5zdGF0dXMpOw0K PiAgIAkJbWFwLT51bm1hcF9vcHNbb2Zmc2V0K2ldLmhhbmRsZSA9IElOVkFMSURfR1JBTlRfSEFO RExFOw0KPiAgIAkJaWYgKHVzZV9wdGVtb2QpIHsNCj4gLQkJCVdBUk5fT04obWFwLT5rdW5tYXBf b3BzW29mZnNldCtpXS5zdGF0dXMpOw0KPiArCQkJV0FSTl9PTihtYXAtPmt1bm1hcF9vcHNbb2Zm c2V0ICsgaV0uc3RhdHVzICE9IEdOVFNUX29rYXkgJiYNCj4gKwkJCQltYXAtPmt1bm1hcF9vcHNb b2Zmc2V0ICsgaV0uaGFuZGxlICE9IElOVkFMSURfR1JBTlRfSEFORExFKTsNCj4gICAJCQlwcl9k ZWJ1Zygia3VubWFwIGhhbmRsZT0ldSBzdD0lZFxuIiwNCj4gICAJCQkJIG1hcC0+a3VubWFwX29w c1tvZmZzZXQraV0uaGFuZGxlLA0KPiAgIAkJCQkgbWFwLT5rdW5tYXBfb3BzW29mZnNldCtpXS5z dGF0dXMpOw0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 11 06:56:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 06:56:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364880.594844 (Exim 4.92) (envelope-from ) id 1oAnLI-0004xf-RO; Mon, 11 Jul 2022 06:56:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364880.594844; Mon, 11 Jul 2022 06:56:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnLI-0004xY-Oj; Mon, 11 Jul 2022 06:56:28 +0000 Received: by outflank-mailman (input) for mailman id 364880; Mon, 11 Jul 2022 06:56:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnLH-0004xA-UF for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 06:56:27 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 956c1cd7-00e6-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 08:56:26 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 96ADA2278C; Mon, 11 Jul 2022 06:56:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6288C13524; Mon, 11 Jul 2022 06:56:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id LLo3FprJy2JHfAAAMHmgww (envelope-from ); Mon, 11 Jul 2022 06:56:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 956c1cd7-00e6-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657522586; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=15Lpxz7m/K0zmimJDOhkk99KZ262WAFilVkSyIFpJJg=; b=EG22l+Os5xB7oc2o9ZQykOVm8vboQT6lzZfdTrJ4KKdp5+opfAPk82/1xIMr+SbPlN2Us0 QPvDy828nFggMq0eTDCbOyCggIsCpiavdEZYRIekAQ4BS8y66Aoqk6XMiV/MlKaZPCoLqP SrJPQG3ZdngwqGMwRrXRTnb/LMENQ44= Message-ID: Date: Mon, 11 Jul 2022 08:56:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Content-Language: en-US To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220710230522.1563-1-demi@invisiblethingslab.com> From: Juergen Gross In-Reply-To: <20220710230522.1563-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HR0G2TUKyxlINMlPASC2HsHD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HR0G2TUKyxlINMlPASC2HsHD Content-Type: multipart/mixed; boundary="------------FfnGwjMERaMxLXCAN0gshF2I"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: Subject: Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE References: <20220710230522.1563-1-demi@invisiblethingslab.com> In-Reply-To: <20220710230522.1563-1-demi@invisiblethingslab.com> --------------FfnGwjMERaMxLXCAN0gshF2I Content-Type: multipart/mixed; boundary="------------AHvtRssDqnEsWxYK0zAsGoED" --------------AHvtRssDqnEsWxYK0zAsGoED Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMDE6MDUsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gVGhlIGVy cm9yIHBhdGhzIG9mIGdudGRldl9tbWFwKCkgY2FuIGNhbGwgdW5tYXBfZ3JhbnRfcGFnZXMo KSBldmVuDQo+IHRob3VnaCBub3QgYWxsIG9mIHRoZSBwYWdlcyBoYXZlIGJlZW4gc3VjY2Vz c2Z1bGx5IG1hcHBlZC4gIFRoaXMgd2lsbA0KPiB0cmlnZ2VyIHRoZSBXQVJOX09OKClzIGlu IF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9uZSgpLiAgVGhlIG51bWJlciBvZg0KPiB3YXJuaW5n cyBjYW4gYmUgdmVyeSBsYXJnZTsgSSBoYXZlIG9ic2VydmVkIHRob3VzYW5kcyBvZiBsaW5l cyBvZg0KPiB3YXJuaW5ncyBpbiB0aGUgc3lzdGVtZCBqb3VybmFsLg0KPiANCj4gQXZvaWQg dGhpcyBwcm9ibGVtIGJ5IG9ubHkgd2FybmluZyBvbiB1bm1hcHBpbmcgZmFpbHVyZSBpZiB0 aGUgaGFuZGxlDQo+IGJlaW5nIHVubWFwcGVkIGlzIG5vdCBJTlZBTElEX0dSQU5UX0hBTkRM RS4gIFRoZSBoYW5kbGUgZmllbGQgb2YgYW55DQo+IHBhZ2UgdGhhdCB3YXMgbm90IHN1Y2Nl c3NmdWxseSBtYXBwZWQgd2lsbCBiZSBJTlZBTElEX0dSQU5UX0hBTkRMRSwgc28NCj4gdGhp cyBjYXRjaGVzIGFsbCBjYXNlcyB3aGVyZSB1bm1hcHBpbmcgY2FuIGxlZ2l0aW1hdGVseSBm YWlsLg0KPiANCj4gU3VnZ2VzdGVkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IERl bWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBGaXhl czogZGJlOTdjZmY3ZGQ5ICgieGVuL2dudGRldjogQXZvaWQgYmxvY2tpbmcgaW4gdW5tYXBf Z3JhbnRfcGFnZXMoKSIpDQoNClJldmlld2VkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NA c3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------AHvtRssDqnEsWxYK0zAsGoED Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------AHvtRssDqnEsWxYK0zAsGoED-- --------------FfnGwjMERaMxLXCAN0gshF2I-- --------------HR0G2TUKyxlINMlPASC2HsHD Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLLyZoFAwAAAAAACgkQsN6d1ii/Ey9f KQf/W7zjk+LXMrWE/S19874/suItM4FQcKcLzdhBb5qFpObCR+bp1Mzgba1u+nOSeFvrR0Sda+Wo z1IvYewJ9/D4b5Lz1GXCNXBqL9PtTISn2aI61qPbA+s5Uo5yBr5bJiKah3GOqeunscsEtnbliFtL bn5rhhxVLruKScJgHxpxqPzGmRwHtESkMqS4ctJ+ACPZnQOnc7zteJR9UmSStl6GPzVsV1j15wbn /0ESdpnEYS7sPuIJ5cHluUTL2KdrBC6py51k2tejWgMJYYvQ2u5wGG96HLaO5qgU0JfXIFsgrfBh iEl/ENtMn2x6W5Xrvp89Fw6/U/t99BefPzw5ZkZUig== =mJgN -----END PGP SIGNATURE----- --------------HR0G2TUKyxlINMlPASC2HsHD-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 07:10:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 07:10:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364889.594855 (Exim 4.92) (envelope-from ) id 1oAnYL-0006h7-0d; Mon, 11 Jul 2022 07:09:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364889.594855; Mon, 11 Jul 2022 07:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnYK-0006h0-UK; Mon, 11 Jul 2022 07:09:56 +0000 Received: by outflank-mailman (input) for mailman id 364889; Mon, 11 Jul 2022 07:09:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnYJ-0006gu-P8 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 07:09:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 76d40db2-00e8-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 09:09:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4455620084; Mon, 11 Jul 2022 07:09:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 16F7813524; Mon, 11 Jul 2022 07:09:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id RaQDBMLMy2KkAgAAMHmgww (envelope-from ); Mon, 11 Jul 2022 07:09:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76d40db2-00e8-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657523394; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=K2VFV8qdbE6Z5NB6WOrUrcPao6W4Q0PYmnKxJXLDz8k=; b=ShChLikP3cfjSbOkgb24vwb3MfWZSF5EI5P5q9RpFTjysZwnrg0RH6FvRq0s8LaxuLkD14 9CuDMOCi+uDMNlvp5/VCnzsH6TmvW2v2o2MreB1TXQKvCNPAtnk+aoJYg56NhyWSEHTF6I tQ71ET6JpErNecT7vWlcOjYQR51lnhw= Message-ID: <20f563b2-68e1-e429-f762-78474c566d04@suse.com> Date: Mon, 11 Jul 2022 09:09:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: dmitry.semenets@gmail.com, xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> From: Juergen Gross Subject: Re: [PATCH 1/4] tools: remove xenstore entries on vchan server closure In-Reply-To: <20220709101035.2989428-1-dmitry.semenets@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------HAhON0yoFl6h3W5HEnaexa4f" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------HAhON0yoFl6h3W5HEnaexa4f Content-Type: multipart/mixed; boundary="------------0JVjvipApbVP4TBgLcVlgsat"; protected-headers="v1" From: Juergen Gross To: dmitry.semenets@gmail.com, xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD Message-ID: <20f563b2-68e1-e429-f762-78474c566d04@suse.com> Subject: Re: [PATCH 1/4] tools: remove xenstore entries on vchan server closure References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> In-Reply-To: <20220709101035.2989428-1-dmitry.semenets@gmail.com> --------------0JVjvipApbVP4TBgLcVlgsat Content-Type: multipart/mixed; boundary="------------8HgPWNx1j5RlPkUxdXqivo09" --------------8HgPWNx1j5RlPkUxdXqivo09 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDcuMjIgMTI6MTAsIGRtaXRyeS5zZW1lbmV0c0BnbWFpbC5jb20gd3JvdGU6DQo+ IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5r b0BlcGFtLmNvbT4NCj4gDQo+IHZjaGFuIHNlcnZlciBjcmVhdGVzIFhlblN0b3JlIGVudHJp ZXMgdG8gYWR2ZXJ0aXNlIGl0cyBldmVudCBjaGFubmVsIGFuZA0KPiByaW5nLCBidXQgdGhv c2UgYXJlIG5vdCByZW1vdmVkIGFmdGVyIHRoZSBzZXJ2ZXIgcXVpdHMuDQo+IEFkZCBhZGRp dGlvbmFsIGNsZWFudXAgc3RlcCwgc28gdGhvc2UgYXJlIHJlbW92ZWQsIHNvIGNsaWVudHMg ZG8gbm90IHRyeQ0KPiB0byBjb25uZWN0IHRvIGEgbm9uLWV4aXN0aW5nIHNlcnZlci4NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJf YW5kcnVzaGNoZW5rb0BlcGFtLmNvbT4NCj4gLS0tDQo+ICAgdG9vbHMvaW5jbHVkZS9saWJ4 ZW52Y2hhbi5oIHwgIDUgKysrKysNCj4gICB0b29scy9saWJzL3ZjaGFuL2luaXQuYyAgICAg fCAyMyArKysrKysrKysrKysrKysrKysrKysrKw0KPiAgIHRvb2xzL2xpYnMvdmNoYW4vaW8u YyAgICAgICB8ICA0ICsrKysNCj4gICB0b29scy9saWJzL3ZjaGFuL3ZjaGFuLmggICAgfCAz MSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ICAgNCBmaWxlcyBjaGFuZ2Vk LCA2MyBpbnNlcnRpb25zKCspDQo+ICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRvb2xzL2xpYnMv dmNoYW4vdmNoYW4uaA0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2luY2x1ZGUvbGlieGVu dmNoYW4uaCBiL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPiBpbmRleCBkNjAxMGIx NDVkLi4zMGNjNzNjZjk3IDEwMDY0NA0KPiAtLS0gYS90b29scy9pbmNsdWRlL2xpYnhlbnZj aGFuLmgNCj4gKysrIGIvdG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hhbi5oDQo+IEBAIC04Niw2 ICs4NiwxMSBAQCBzdHJ1Y3QgbGlieGVudmNoYW4gew0KPiAgIAlpbnQgYmxvY2tpbmc6MTsN Cj4gICAJLyogY29tbXVuaWNhdGlvbiByaW5ncyAqLw0KPiAgIAlzdHJ1Y3QgbGlieGVudmNo YW5fcmluZyByZWFkLCB3cml0ZTsNCj4gKwkvKioNCj4gKwkgKiBCYXNlIHhlbnN0b3JlIHBh dGggZm9yIHN0b3JpbmcgcmluZy9ldmVudCBkYXRhIHVzZWQgYnkgdGhlIHNlcnZlcg0KPiAr CSAqIGR1cmluZyBjbGVhbnVwLg0KPiArCSAqICovDQo+ICsJY2hhciAqeHNfcGF0aDsNCj4g ICB9Ow0KPiAgIA0KPiAgIC8qKg0KPiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy92Y2hhbi9p bml0LmMgYi90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPiBpbmRleCBjODUxMGU2Y2U5Li5j NmI4Njc0ZWY1IDEwMDY0NA0KPiAtLS0gYS90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPiAr KysgYi90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPiBAQCAtNDYsNiArNDYsOCBAQA0KPiAg ICNpbmNsdWRlIDx4ZW4vc3lzL2dudGRldi5oPg0KPiAgICNpbmNsdWRlIDxsaWJ4ZW52Y2hh bi5oPg0KPiAgIA0KPiArI2luY2x1ZGUgInZjaGFuLmgiDQo+ICsNCj4gICAjaWZuZGVmIFBB R0VfU0hJRlQNCj4gICAjZGVmaW5lIFBBR0VfU0hJRlQgMTINCj4gICAjZW5kaWYNCj4gQEAg LTI1MSw2ICsyNTMsMTAgQEAgc3RhdGljIGludCBpbml0X3hzX3NydihzdHJ1Y3QgbGlieGVu dmNoYW4gKmN0cmwsIGludCBkb21haW4sIGNvbnN0IGNoYXIqIHhzX2Jhc2UNCj4gICAJY2hh ciByZWZbMTZdOw0KPiAgIAljaGFyKiBkb21pZF9zdHIgPSBOVUxMOw0KPiAgIAl4c190cmFu c2FjdGlvbl90IHhzX3RyYW5zID0gWEJUX05VTEw7DQo+ICsNCj4gKwkvLyBzdG9yZSB0aGUg YmFzZSBwYXRoIHNvIHdlIGNhbiBjbGVhbiB1cCBvbiBzZXJ2ZXIgY2xvc3VyZQ0KDQpQbGVh c2UgZG9uJ3QgaW50cm9kdWNlIG5ldyB1c2FnZXMgb2YgdGhlIEMrKyBjb21tZW50IHN0eWxl Lg0KDQo+ICsJY3RybC0+eHNfcGF0aCA9IHN0cmR1cCh4c19iYXNlKTsNCg0KUmV0dXJuIGFu IGVycm9yIGluIGNhc2Ugb2Ygc3RyZHVwKCkgZmFpbHVyZT8NCg0KPiArDQo+ICAgCXhzID0g eHNfb3BlbigwKTsNCj4gICAJaWYgKCF4cykNCj4gICAJCWdvdG8gZmFpbDsNCj4gQEAgLTI5 OCw2ICszMDQsMjMgQEAgcmV0cnlfdHJhbnNhY3Rpb246DQo+ICAgCXJldHVybiByZXQ7DQo+ ICAgfQ0KPiAgIA0KPiArdm9pZCBjbG9zZV94c19zcnYoc3RydWN0IGxpYnhlbnZjaGFuICpj dHJsKQ0KPiArew0KPiArCXN0cnVjdCB4c19oYW5kbGUgKnhzOw0KPiArDQo+ICsJaWYgKCFj dHJsLT54c19wYXRoKQ0KPiArCQlyZXR1cm47DQo+ICsNCj4gKwl4cyA9IHhzX29wZW4oMCk7 DQo+ICsJaWYgKCF4cykNCj4gKwkJZ290byBmYWlsOw0KPiArDQo+ICsJeHNfcm0oeHMsIFhC VF9OVUxMLCBjdHJsLT54c19wYXRoKTsNCg0KSW4gdGhpcyBzaW1wbGUgY2FzZSBJJ2QgcHJl ZmVyDQoNCmlmICh4cykNCiAgICAgeHNfcm0oeHMsIFhCVF9OVUxMLCBjdHJsLT54c19wYXRo KTsNCg0KPiArDQo+ICtmYWlsOg0KPiArCWZyZWUoY3RybC0+eHNfcGF0aCk7DQoNCk5vIHhz X2Nsb3NlKCk/DQoNCg0KSnVlcmdlbg0K --------------8HgPWNx1j5RlPkUxdXqivo09 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------8HgPWNx1j5RlPkUxdXqivo09-- --------------0JVjvipApbVP4TBgLcVlgsat-- --------------HAhON0yoFl6h3W5HEnaexa4f Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLLzMEFAwAAAAAACgkQsN6d1ii/Ey90 XAf9GQj8w/1FSbWNKV3liYVKV7oPkNTaCkE5a80xZRZXUaZtXuwAkIDYqQKx1uGGTSNIyQUVae0X cBLevyLyOb/P2TxacXNhdsG487uC5ART4SZ+QqLKy9jR1cO1LtEeQ3RJdYWrgRbI8kkIPF7huqnC oMbWOwnkiLlksiK5b3Dl5LzXbG7J2qdDu0frnLfQ/U2eHttqd3DfHLPjVk1bsTFtXcxBZWjEnbBK dnTHkO87gr519qatcrBHL29jWQsCEt0Hc5WBS0ycR2EK3pOFTQHv6jnne7zK1TiPQQd7IiTSatzz IKYVrHShbQJOS5QvY9g6OXqb+0JA7Hr1Xh5+wOdeKQ== =m5fC -----END PGP SIGNATURE----- --------------HAhON0yoFl6h3W5HEnaexa4f-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 07:25:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 07:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364898.594866 (Exim 4.92) (envelope-from ) id 1oAnmt-0000hR-BB; Mon, 11 Jul 2022 07:24:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364898.594866; Mon, 11 Jul 2022 07:24:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnmt-0000hK-8V; Mon, 11 Jul 2022 07:24:59 +0000 Received: by outflank-mailman (input) for mailman id 364898; Mon, 11 Jul 2022 07:24:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAnmr-0000hE-L7 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 07:24:57 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f9cd65c-00ea-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 09:24:55 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A39A5226A1; Mon, 11 Jul 2022 07:24:54 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7648C13524; Mon, 11 Jul 2022 07:24:54 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id O4xnG0bQy2J1CAAAMHmgww (envelope-from ); Mon, 11 Jul 2022 07:24:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f9cd65c-00ea-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657524294; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UdHkqfH82oc9inS5aKFs8Nq9TUm3h4V1F4l9lAKv12A=; b=Lk4G0FeOCTSwEt8nMM8pRGAM1DMbTZogiuDstUkFuvqvJyXN49oDzUvRgWzSPe5Ad9Gi5N 0Up28OebQHIqXN7SpiyVHSIE8yl80Plap8shay/lNiK6fwAGgQXOQ7WOAawCKFDFAy6XBs Gsddu3VJazdkh3+goinSvJqP19bnvI0= Message-ID: <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> Date: Mon, 11 Jul 2022 09:24:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: dmitry.semenets@gmail.com, xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20220709101035.2989428-2-dmitry.semenets@gmail.com> From: Juergen Gross Subject: Re: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long In-Reply-To: <20220709101035.2989428-2-dmitry.semenets@gmail.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------3ERNcltNu0zbZAg8NwiGKGeR" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------3ERNcltNu0zbZAg8NwiGKGeR Content-Type: multipart/mixed; boundary="------------HLhae3TVHdPqWjEN1NsDMezD"; protected-headers="v1" From: Juergen Gross To: dmitry.semenets@gmail.com, xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD Message-ID: <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> Subject: Re: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20220709101035.2989428-2-dmitry.semenets@gmail.com> In-Reply-To: <20220709101035.2989428-2-dmitry.semenets@gmail.com> --------------HLhae3TVHdPqWjEN1NsDMezD Content-Type: multipart/mixed; boundary="------------EKNnpEc95D8GqeEqMIGH0G06" --------------EKNnpEc95D8GqeEqMIGH0G06 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMDkuMDcuMjIgMTI6MTAsIGRtaXRyeS5zZW1lbmV0c0BnbWFpbC5jb20gd3JvdGU6DQo+ IEZyb206IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNoZW5r b0BlcGFtLmNvbT4NCj4gDQo+IEN1cnJlbnQgdmNoYW4gaW1wbGVtZW50YXRpb24sIHdoaWxl IGRlYWxpbmcgd2l0aCBYZW5TdG9yZSBwYXRocywNCj4gYWxsb2NhdGVzIDY0IGJ5dGVzIGJ1 ZmZlciBvbiB0aGUgc3RhY2sgd2hpY2ggbWF5IG5vdCBiZSBlbm91Z2ggZm9yDQo+IHNvbWUg dXNlLWNhc2VzLiBNYWtlIHRoZSBidWZmZXIgbG9uZ2VyIHRvIHJlc3BlY3QgbWF4aW11bSBh bGxvd2VkDQo+IFhlblN0b3JlIHBhdGggb2YgWEVOU1RPUkVfQUJTX1BBVEhfTUFYLg0KPiAN Cj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9h bmRydXNoY2hlbmtvQGVwYW0uY29tPg0KPiAtLS0NCj4gICB0b29scy9saWJzL3ZjaGFuL2lu aXQuYyB8IDI4ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0NCj4gICAxIGZpbGUgY2hh bmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n aXQgYS90b29scy9saWJzL3ZjaGFuL2luaXQuYyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW5pdC5j DQo+IGluZGV4IGM2Yjg2NzRlZjUuLjE3OTQ1YzI0YTEgMTAwNjQ0DQo+IC0tLSBhL3Rvb2xz L2xpYnMvdmNoYW4vaW5pdC5jDQo+ICsrKyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW5pdC5jDQo+ IEBAIC0yNDksNyArMjQ5LDcgQEAgc3RhdGljIGludCBpbml0X3hzX3NydihzdHJ1Y3QgbGli eGVudmNoYW4gKmN0cmwsIGludCBkb21haW4sIGNvbnN0IGNoYXIqIHhzX2Jhc2UNCj4gICAJ aW50IHJldCA9IC0xOw0KPiAgIAlzdHJ1Y3QgeHNfaGFuZGxlICp4czsNCj4gICAJc3RydWN0 IHhzX3Blcm1pc3Npb25zIHBlcm1zWzJdOw0KPiAtCWNoYXIgYnVmWzY0XTsNCj4gKwljaGFy ICpidWY7DQo+ICAgCWNoYXIgcmVmWzE2XTsNCj4gICAJY2hhciogZG9taWRfc3RyID0gTlVM TDsNCj4gICAJeHNfdHJhbnNhY3Rpb25fdCB4c190cmFucyA9IFhCVF9OVUxMOw0KPiBAQCAt MjU3LDYgKzI1NywxMiBAQCBzdGF0aWMgaW50IGluaXRfeHNfc3J2KHN0cnVjdCBsaWJ4ZW52 Y2hhbiAqY3RybCwgaW50IGRvbWFpbiwgY29uc3QgY2hhciogeHNfYmFzZQ0KPiAgIAkvLyBz dG9yZSB0aGUgYmFzZSBwYXRoIHNvIHdlIGNhbiBjbGVhbiB1cCBvbiBzZXJ2ZXIgY2xvc3Vy ZQ0KPiAgIAljdHJsLT54c19wYXRoID0gc3RyZHVwKHhzX2Jhc2UpOw0KPiAgIA0KPiArCWJ1 ZiA9IG1hbGxvYyhYRU5TVE9SRV9BQlNfUEFUSF9NQVgpOw0KPiArCWlmICghYnVmKSB7DQo+ ICsJCWZyZWUoY3RybCk7DQo+ICsJCXJldHVybiAwOw0KPiArCX0NCj4gKw0KPiAgIAl4cyA9 IHhzX29wZW4oMCk7DQo+ICAgCWlmICgheHMpDQo+ICAgCQlnb3RvIGZhaWw7DQo+IEBAIC0y NzgsMTQgKzI4NCwxNCBAQCByZXRyeV90cmFuc2FjdGlvbjoNCj4gICAJCWdvdG8gZmFpbF94 c19vcGVuOw0KPiAgIA0KPiAgIAlzbnByaW50ZihyZWYsIHNpemVvZiByZWYsICIlZCIsIHJp bmdfcmVmKTsNCj4gLQlzbnByaW50ZihidWYsIHNpemVvZiBidWYsICIlcy9yaW5nLXJlZiIs IHhzX2Jhc2UpOw0KPiArCXNucHJpbnRmKGJ1ZiwgWEVOU1RPUkVfQUJTX1BBVEhfTUFYLCAi JXMvcmluZy1yZWYiLCB4c19iYXNlKTsNCj4gICAJaWYgKCF4c193cml0ZSh4cywgeHNfdHJh bnMsIGJ1ZiwgcmVmLCBzdHJsZW4ocmVmKSkpDQo+ICAgCQlnb3RvIGZhaWxfeHNfb3BlbjsN Cj4gICAJaWYgKCF4c19zZXRfcGVybWlzc2lvbnMoeHMsIHhzX3RyYW5zLCBidWYsIHBlcm1z LCAyKSkNCj4gICAJCWdvdG8gZmFpbF94c19vcGVuOw0KPiAgIA0KPiAgIAlzbnByaW50Zihy ZWYsIHNpemVvZiByZWYsICIlZCIsIGN0cmwtPmV2ZW50X3BvcnQpOw0KPiAtCXNucHJpbnRm KGJ1Ziwgc2l6ZW9mIGJ1ZiwgIiVzL2V2ZW50LWNoYW5uZWwiLCB4c19iYXNlKTsNCj4gKwlz bnByaW50ZihidWYsIFhFTlNUT1JFX0FCU19QQVRIX01BWCwgIiVzL2V2ZW50LWNoYW5uZWwi LCB4c19iYXNlKTsNCj4gICAJaWYgKCF4c193cml0ZSh4cywgeHNfdHJhbnMsIGJ1ZiwgcmVm LCBzdHJsZW4ocmVmKSkpDQo+ICAgCQlnb3RvIGZhaWxfeHNfb3BlbjsNCj4gICAJaWYgKCF4 c19zZXRfcGVybWlzc2lvbnMoeHMsIHhzX3RyYW5zLCBidWYsIHBlcm1zLCAyKSkNCj4gQEAg LTMwMSw2ICszMDcsNyBAQCByZXRyeV90cmFuc2FjdGlvbjoNCj4gICAJZnJlZShkb21pZF9z dHIpOw0KPiAgIAl4c19jbG9zZSh4cyk7DQo+ICAgIGZhaWw6DQo+ICsJZnJlZShidWYpOw0K PiAgIAlyZXR1cm4gcmV0Ow0KPiAgIH0NCj4gICANCj4gQEAgLTQxOCwxMyArNDI1LDIwIEBA IHN0cnVjdCBsaWJ4ZW52Y2hhbiAqbGlieGVudmNoYW5fY2xpZW50X2luaXQoc3RydWN0IHhl bnRvb2xsb2dfbG9nZ2VyICpsb2dnZXIsDQo+ICAgew0KPiAgIAlzdHJ1Y3QgbGlieGVudmNo YW4gKmN0cmwgPSBtYWxsb2Moc2l6ZW9mKHN0cnVjdCBsaWJ4ZW52Y2hhbikpOw0KPiAgIAlz dHJ1Y3QgeHNfaGFuZGxlICp4cyA9IE5VTEw7DQo+IC0JY2hhciBidWZbNjRdOw0KPiArCWNo YXIgKmJ1ZjsNCj4gICAJY2hhciAqcmVmOw0KPiAgIAlpbnQgcmluZ19yZWY7DQo+ICAgCXVu c2lnbmVkIGludCBsZW47DQo+ICAgDQo+ICAgCWlmICghY3RybCkNCj4gICAJCXJldHVybiAw Ow0KPiArDQo+ICsJYnVmID0gbWFsbG9jKFhFTlNUT1JFX0FCU19QQVRIX01BWCk7DQo+ICsJ aWYgKCFidWYpIHsNCj4gKwkJZnJlZShjdHJsKTsNCj4gKwkJcmV0dXJuIDA7DQo+ICsJfQ0K PiArDQo+ICAgCWN0cmwtPnJpbmcgPSBOVUxMOw0KPiAgIAljdHJsLT5ldmVudCA9IE5VTEw7 DQo+ICAgCWN0cmwtPmdudHRhYiA9IE5VTEw7DQo+IEBAIC00MzUsOCArNDQ5LDkgQEAgc3Ry dWN0IGxpYnhlbnZjaGFuICpsaWJ4ZW52Y2hhbl9jbGllbnRfaW5pdChzdHJ1Y3QgeGVudG9v bGxvZ19sb2dnZXIgKmxvZ2dlciwNCj4gICAJaWYgKCF4cykNCj4gICAJCWdvdG8gZmFpbDsN Cg0KWW91IGFyZSBsZWFraW5nIGJ1ZiBpbiB0aGlzIGNhc2UuDQoNCj4gICANCj4gKw0KPiAg IC8vIGZpbmQgeGVuc3RvcmUgZW50cnkNCj4gLQlzbnByaW50ZihidWYsIHNpemVvZiBidWYs ICIlcy9yaW5nLXJlZiIsIHhzX3BhdGgpOw0KPiArCXNucHJpbnRmKGJ1ZiwgWEVOU1RPUkVf QUJTX1BBVEhfTUFYLCAiJXMvcmluZy1yZWYiLCB4c19wYXRoKTsNCj4gICAJcmVmID0geHNf cmVhZCh4cywgMCwgYnVmLCAmbGVuKTsNCj4gICAJaWYgKCFyZWYpDQo+ICAgCQlnb3RvIGZh aWw7DQo+IEBAIC00NDQsNyArNDU5LDcgQEAgc3RydWN0IGxpYnhlbnZjaGFuICpsaWJ4ZW52 Y2hhbl9jbGllbnRfaW5pdChzdHJ1Y3QgeGVudG9vbGxvZ19sb2dnZXIgKmxvZ2dlciwNCj4g ICAJZnJlZShyZWYpOw0KPiAgIAlpZiAoIXJpbmdfcmVmKQ0KPiAgIAkJZ290byBmYWlsOw0K PiAtCXNucHJpbnRmKGJ1Ziwgc2l6ZW9mIGJ1ZiwgIiVzL2V2ZW50LWNoYW5uZWwiLCB4c19w YXRoKTsNCj4gKwlzbnByaW50ZihidWYsIFhFTlNUT1JFX0FCU19QQVRIX01BWCwgIiVzL2V2 ZW50LWNoYW5uZWwiLCB4c19wYXRoKTsNCj4gICAJcmVmID0geHNfcmVhZCh4cywgMCwgYnVm LCAmbGVuKTsNCj4gICAJaWYgKCFyZWYpDQo+ICAgCQlnb3RvIGZhaWw7DQo+IEBAIC00NzQs NiArNDg5LDcgQEAgc3RydWN0IGxpYnhlbnZjaGFuICpsaWJ4ZW52Y2hhbl9jbGllbnRfaW5p dChzdHJ1Y3QgeGVudG9vbGxvZ19sb2dnZXIgKmxvZ2dlciwNCj4gICAgb3V0Og0KPiAgIAlp ZiAoeHMpDQo+ICAgCQl4c19jbG9zZSh4cyk7DQo+ICsJZnJlZShidWYpOw0KPiAgIAlyZXR1 cm4gY3RybDsNCj4gICAgZmFpbDoNCj4gICAJbGlieGVudmNoYW5fY2xvc2UoY3RybCk7DQoN Ckp1ZXJnZW4NCg== --------------EKNnpEc95D8GqeEqMIGH0G06 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------EKNnpEc95D8GqeEqMIGH0G06-- --------------HLhae3TVHdPqWjEN1NsDMezD-- --------------3ERNcltNu0zbZAg8NwiGKGeR Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLL0EYFAwAAAAAACgkQsN6d1ii/Ey8V +gf/YVgyRUWBUNLLvnU2zcEL1T8V/jfbebCEft9U/tReFZOFbPTlYpNI2HlupcX6bkL2JMJkxKHe 7IrpE+H/OP9kydP/ud3gqyboETabe2n7Uj8FvrUWSh1CnlHUEzC3xw4xqJMQ+DQ/lN/HJmTpykHu NzORfgObJpdfYbYodQRTdN33u7VMp27k+zQMV9dC7RXdo+ChIf+PdQCsyvh8dWn2VVrz8koEOhYw VSHXJL2KAENVQtMdc2ymVT1Ltu3R0f9Ta67woSmTfi5yNGuOlFFMkFzfwsTiwCZcUvfm134yeT03 rEMvGsVWKDTnEVaHPWEPzBtxVTlhlplZs6hM3fEZNg== =6sEl -----END PGP SIGNATURE----- --------------3ERNcltNu0zbZAg8NwiGKGeR-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 07:49:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 07:49:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364905.594878 (Exim 4.92) (envelope-from ) id 1oAoAw-0003NP-B3; Mon, 11 Jul 2022 07:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364905.594878; Mon, 11 Jul 2022 07:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoAw-0003NI-7f; Mon, 11 Jul 2022 07:49:50 +0000 Received: by outflank-mailman (input) for mailman id 364905; Mon, 11 Jul 2022 07:49:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoAv-0003N8-9B; Mon, 11 Jul 2022 07:49:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoAv-000895-5D; Mon, 11 Jul 2022 07:49:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoAu-0006XL-PE; Mon, 11 Jul 2022 07:49:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAoAu-0003cL-Oj; Mon, 11 Jul 2022 07:49:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/tIKdDYyeqzJG4ZIEUHa7aPkuDe90ubjL0YmrXZQzlY=; b=Nphe6RSwOvYz6ujIeazVu/dLfD 78PrYyblp8uttCMVR5xEQ95w1CN3IOPB2Ep4Gy6nup/EDvJ4doRT6TusS8tQe220igYZeE82MLBfg aOPqnJzzQfuJyvCveWud6mOAcfeY9dMoQyGPnWPYreuWm+pEdYtqqxEIQAKSsPyKJxkw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171578: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 X-Osstest-Versions-That: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 From: osstest service owner Date: Mon, 11 Jul 2022 07:49:48 +0000 flight 171578 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171578/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171572 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171572 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171572 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171572 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171572 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171572 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171572 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171572 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171572 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171572 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171572 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171572 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171572 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 baseline version: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 Last test of basis 171578 2022-07-11 01:53:21 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jul 11 08:00:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 08:00:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364918.594889 (Exim 4.92) (envelope-from ) id 1oAoKw-0006DY-Rd; Mon, 11 Jul 2022 08:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364918.594889; Mon, 11 Jul 2022 08:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoKw-0006DR-OX; Mon, 11 Jul 2022 08:00:10 +0000 Received: by outflank-mailman (input) for mailman id 364918; Mon, 11 Jul 2022 08:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoKu-0006DK-QE for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 08:00:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79c693e8-00ef-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 10:00:06 +0200 (CEST) Received: from AS8PR04CA0102.eurprd04.prod.outlook.com (2603:10a6:20b:31e::17) by AS8PR08MB6961.eurprd08.prod.outlook.com (2603:10a6:20b:344::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Mon, 11 Jul 2022 08:00:04 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:31e:cafe::e7) by AS8PR04CA0102.outlook.office365.com (2603:10a6:20b:31e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Mon, 11 Jul 2022 08:00:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Mon, 11 Jul 2022 08:00:03 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Mon, 11 Jul 2022 08:00:02 +0000 Received: from 07bb5164edfc.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 74EDF590-346B-4F79-A45C-CC349AB7A089.1; Mon, 11 Jul 2022 07:59:57 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07bb5164edfc.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 07:59:56 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by GVXPR08MB7798.eurprd08.prod.outlook.com (2603:10a6:150:4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 11 Jul 2022 07:59:53 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 07:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79c693e8-00ef-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HudwDHVgPc6zorNXrKjIoKrwXqEeNLnccv7MYl8/hrlLKHpY2pzvl3N0LNq1K5koE1yCCPjuzM5PUnj+SQK6/DI0vvrf87dU8Ted+9xCQ35uRqodUOsu4VDdbNcGvB7HN4gHMIVhUPBGSZuJPs0EDRG4EkSG+VsJLBOVYwJ3rgO1OxNmYUbRUz76cjBzUB9tiYteYBdCRwoa9w9M75e1xGSmn+fFEMcHyiQC25lP36fvr3WgE5L3fAzFnysN/+OabD/QXED3tU+n68s6QXKw7z8qbaoFtgm1HW2mJqi9rXcpGO+ks5+cBUSlP6fxXcTgyi2Hdi7ycyvd52Ti/Ohe/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XO/HhnIGAYjzAOgdXEWYWnm0JHwl981Pp2F5LU/7NdU=; b=WvwyOCEGS3j42jfTZtOe3gc4PC9e8kx6znUQsiTi08tN7L/w6X+Wb1W5we3MXq8qPONsrmBrid+2tYa3t+oiUxlD6LTEe98ldvIAHrPgaBuhvzuk60EHoevYWTYxGsOZPp9N0mMWaCO9L9GaLIvm2z6WrI4b81TMyJVFwgwR7WhwSLXLFPMww25vlK+/kO7BjSh4zTCjt7kDy/PLWlf3Jlmq6MeMJjvDXJySBE3Wv6OWaZfeDbQhEV/A8wjisk4X9ayz9Jn5zMz3Te7VtzhMquL1GxhDdpPUQJKuhTbogKQc177yRbNAJTblW/6SniqlUrmUBDZK8QzANlA7wDQGhQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XO/HhnIGAYjzAOgdXEWYWnm0JHwl981Pp2F5LU/7NdU=; b=kffRdIC6DtWCHWjtHjT3S2IYF8qLvfX0Qj4gcUX6E7v2s0YT+odAfm2rmQa/AM9OaATP8/RsWjijSshvoXDXJ1edc+A9MYHHgOFDt4mv6RFDU3Kum9+Npf2tV5pib+w1NiKj00ajzZaWL4mLi5nSmeQR8vxM0BpYbQxLA9+EMOY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bd+sTbzDCRD/TRhb71GIDs0J70/YVbysn/AbiYvueXaODWY7jTKHdb3SgulUnH68eeM6/JtLF5NF6x4NW4wvX74a09rMI452A0OwTBJumjxy9dC/qGUuwE8CF+gwADb4ReauNzpvVnuOZsNQVN0Ug/yT4zUrs26fSPEIDKCBoLHWk7vYNczlRJPmJFv9qznxlw5IODr0Q8o+SY5ZNwAXFpLL4lYNK8HAEk2epCpk+W4BoSP1EAHMMjCQ6xxT8mVkYazO0Fe2yFRuicZhVJsiVVdmMWC3mQIwhiST9z7wR8lkhD5w3L3smFhaMKJ4Kuz7kBEji3qsHG08yW2ReKFiMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XO/HhnIGAYjzAOgdXEWYWnm0JHwl981Pp2F5LU/7NdU=; b=eH8WdD8g5CQxAdHPvUJU1v39+DErp2WKcvWbKZp08Q441y2pS8Ck2puYXUdTyAHvlMkFgWj//i81x2x7LwtyRrvflYfzVeWpGUluk9j12H1kx8pFOM4C9/ndj956m6zRNY8T14Z94zh/orX8LDWkVQk0qNoOBWd7ST1tD9DgCoBTrREJw2A3gFFMLP4zsNgKNDECTuQDVUWAapQrCFNhqKamBZIkyEXY+jFtxtyXFuTw01nrXGchoxaW1rghP0S6vfjh1sdKlGgMwFAT5s5HS0jDCSEjiMc7JMSql4ex+yp7DIzhZd0WfGwuekiQ5oGmvd/vYxZWJhC/p7xOXRBFfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XO/HhnIGAYjzAOgdXEWYWnm0JHwl981Pp2F5LU/7NdU=; b=kffRdIC6DtWCHWjtHjT3S2IYF8qLvfX0Qj4gcUX6E7v2s0YT+odAfm2rmQa/AM9OaATP8/RsWjijSshvoXDXJ1edc+A9MYHHgOFDt4mv6RFDU3Kum9+Npf2tV5pib+w1NiKj00ajzZaWL4mLi5nSmeQR8vxM0BpYbQxLA9+EMOY= From: Penny Zheng To: Stefano Stabellini CC: "julien@xen.org" , "xen-devel@lists.xenproject.org" , Wei Chen , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Topic: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest device tree Thread-Index: AQHYhGRGiM2+sN9ON0uL+hMDdx46E61e+NuAgAApAYCADsZBcIAENhcAgAAuPSCAAn2ogIAD+Wug Date: Mon, 11 Jul 2022 07:59:53 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-8-Penny.Zheng@arm.com> <84641d6e-202d-934c-9ea9-bbf090e29bdb@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 1579FEAE9BA8AF4FA53EEA214587A7A7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2c4dd65d-9767-4d85-4c8b-08da63135c70 x-ms-traffictypediagnostic: GVXPR08MB7798:EE_|AM5EUR03FT061:EE_|AS8PR08MB6961:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7RKa0i0B5gMkpBLGSXcc5dLDOClQ3lPpGBXuUEUXIRf5E3fwJ2y+RxdwtBpJGxcICLCudC9mKLAszKDnmRIuzTW1h5P+T2acXbRpeTYpOJg4NUy4fm8wQZW7GOWzCWEMAY8knrZmYeWPgT7XXYEJz2c0QJD/htjC6+1Y73OaD25JpHTwvwce+GC59LB9e4ObRk42jKzkxOWnhWGM+Fac7lq9aMuxhToKCcwgWCUyDYn7XxbStCboWADAr91//OjZYIydxRFGd2p5xVFp18/LpztTWjZAMalE09H2wMg0t+d16z/bWDRWEYZ1SjlzYS7gbTLb3LM1sVFyoe4kcXotKn3YpRUJv51ZrUXVFjngm/1fz/u8lAwelmFCvMtG2lbMqMTdLwuuIoxNW8o7IGuOnVHiGPwQBEq9ZY+V6TPe3fuHue4cfFPsgOGDfiFnHunKu6/od9aiFnraH3Eh8EcPMG2KD8hb1JfIfraR2PcTRvR75XC6xBLsghXWd7csMvwbWMVTfSsUNcxsznODG9O9duSyPPB7ne+VowsVDFdJ71Alanm93AeZ3I1Ek7pFlghCvkj/NYuCrR2MDIHCqBolZu73QKkEK1i4wjDwO6x8BpK8Dd1zqsBz5XgesAUzFCQMk8mZdooIk2DCWTYAop4cYbK5YKNL7InYr8tRhI6r0slXh9U0MTppnxn7+7qmt0C9scSee0yEqkGnwsgPyrwRRt0+gI1R3hTmoNsWo4c36CtHr1Ltg91VYDsHfGNpcQ9tlVuFAq7hvin/7G8rG/SWHl0o+rX+j1BtWqpfLLhzGRBXZg8f/NufboNwdfiwjSvP X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(376002)(346002)(136003)(396003)(54906003)(478600001)(316002)(6916009)(6506007)(2906002)(52536014)(71200400001)(7696005)(41300700001)(64756008)(66446008)(66556008)(55016003)(53546011)(66946007)(76116006)(66476007)(5660300002)(30864003)(8936002)(122000001)(38100700002)(38070700005)(86362001)(26005)(33656002)(186003)(83380400001)(4326008)(8676002)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR08MB7798 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bc321019-cec9-4e3e-fc28-08da631356b1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WbLN+AVikF/9Xn7TMQFv8iPHASHFtFpkyHrYiAyaOwZhrTJM3TkdfuHy4o0D8TKRxIc+WpN5aR56zCm9Rzs4UbVNkMHIQAGxJPj8bRbAKIa/NFfj+VcsQ2x5BtH6Lar3Px6VwawmpZlHvuTzE/SBoDanezXYSvBV1/uawVsh96P/mAWP3OOQiK8pYOabgLrC1adb6J8Zn+TtFUHxfHGyhnxRQ9LrYMoTgdn0HzZhgz27mzViZuzyRYEuIh6gss4rn/NCuXII44IlEzZBoWCLrEbt5LuX1jTbGDOTbRaiOcRKKDX8QDlc+pdlDLHrP0W3FmCpV95W6wqRJCDdQBupF4VwqiOFAikLGopvXzcU2SU4y++ykLKuYAr4Tx+dSVUtPvLtDJnuycYsoXqeU2RNfPs0PwDPUit/lIfIhWdfyQuVMtvRowbLvM1wzK21gtMrxxlK7EiCngv2JU7/to2kuejNCifCYPEmm4jrHqCq0OnYv9FIDSnA658r+WkpjRetq1nPt7dpYvLGkXfq9dPttCBPD3YEYxsPFzfTjyclTGIr3yBm/9NqBi6nEMOFz0V8bOULEpjSMNGJTVx3zrd4/+TB+jW2ryZHZeoJkxmi91IRxbXq6PS3L1uds/tKJUIwTMIHGcPrJ17yGoRfPHXB9C+ErrzLme8n8tPxaXHiIQW/kAXvJw4jpSreej8QMklkX9yC2gr/YO79FtoqmSHV8sULg15pyNNtNLk8OSzZGgVRB1Kk+ByJQdoUvJY3q8fWE7gj8Te8OvlF51hXKbjN/FDE7h5mKxfYWCMz+54sdBAypi/nZySJwZQ517Z9eyFP X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(356005)(81166007)(40480700001)(47076005)(36860700001)(336012)(83380400001)(54906003)(8936002)(55016003)(6862004)(5660300002)(82310400005)(316002)(478600001)(30864003)(82740400003)(6506007)(52536014)(4326008)(53546011)(8676002)(186003)(2906002)(9686003)(26005)(7696005)(41300700001)(86362001)(40460700003)(70586007)(70206006)(107886003)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 08:00:03.1800 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c4dd65d-9767-4d85-4c8b-08da63135c70 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6961 Hi Stefano > -----Original Message----- > From: Stefano Stabellini > Sent: Saturday, July 9, 2022 12:41 AM > To: Penny Zheng > Cc: Stefano Stabellini ; julien@xen.org; xen- > devel@lists.xenproject.org; Wei Chen ; Bertrand > Marquis ; Volodymyr Babchuk > > Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in guest > device tree >=20 > On Thu, 7 Jul 2022, Penny Zheng wrote: > > Hi Stefano and julien > > > > > -----Original Message----- > > > From: Stefano Stabellini > > > Sent: Thursday, July 7, 2022 7:53 AM > > > To: Penny Zheng > > > Cc: Stefano Stabellini ; Julien Grall > > > ; xen-devel@lists.xenproject.org; Wei Chen > > > ; Bertrand Marquis > ; > > > Volodymyr Babchuk > > > Subject: RE: [PATCH v5 7/8] xen/arm: create shared memory nodes in > > > guest device tree > > > > > > On Mon, 4 Jul 2022, Penny Zheng wrote: > > > > Hi Stefano and Julien > > > > > > > > > -----Original Message----- > > > > > From: Stefano Stabellini > > > > > Sent: Saturday, June 25, 2022 5:57 AM > > > > > To: Julien Grall > > > > > Cc: Penny Zheng ; > > > > > xen-devel@lists.xenproject.org; Wei Chen ; > > > Stefano > > > > > Stabellini ; Bertrand Marquis > > > > > ; Volodymyr Babchuk > > > > > > > > > > Subject: Re: [PATCH v5 7/8] xen/arm: create shared memory nodes > > > > > in guest device tree > > > > > > > > > > On Fri, 24 Jun 2022, Julien Grall wrote: > > > > > > On 20/06/2022 06:11, Penny Zheng wrote: > > > > > > > We expose the shared memory to the domU using the > > > > > > > "xen,shared- > > > > > memory-v1" > > > > > > > reserved-memory binding. See > > > > > > > Documentation/devicetree/bindings/reserved- > memory/xen,shared > > > > > > > - > > > > > memory. > > > > > > > txt in Linux for the corresponding device tree binding. > > > > > > > > > > > > > > To save the cost of re-parsing shared memory device tree > > > > > > > configuration when creating shared memory nodes in guest > > > > > > > device tree, this commit adds new field "shm_mem" to store > > > > > > > shm-info per domain. > > > > > > > > > > > > > > For each shared memory region, a range is exposed under the > > > > > > > /reserved-memory node as a child node. Each range sub-node > > > > > > > is named xen-shmem@
and has the following > properties: > > > > > > > - compatible: > > > > > > > compatible =3D "xen,shared-memory-v1" > > > > > > > - reg: > > > > > > > the base guest physical address and size of the > > > > > > > shared memory region > > > > > > > - xen,id: > > > > > > > a string that identifies the shared memory region. > > > > > > > > > > > > > > Signed-off-by: Penny Zheng > > > > > > > Reviewed-by: Stefano Stabellini > > > > > > > --- > > > > > > > v5 change: > > > > > > > - no change > > > > > > > --- > > > > > > > v4 change: > > > > > > > - no change > > > > > > > --- > > > > > > > v3 change: > > > > > > > - move field "shm_mem" to kernel_info > > > > > > > --- > > > > > > > v2 change: > > > > > > > - using xzalloc > > > > > > > - shm_id should be uint8_t > > > > > > > - make reg a local variable > > > > > > > - add #address-cells and #size-cells properties > > > > > > > - fix alignment > > > > > > > --- > > > > > > > xen/arch/arm/domain_build.c | 143 > > > > > +++++++++++++++++++++++++++++- > > > > > > > xen/arch/arm/include/asm/kernel.h | 1 + > > > > > > > xen/arch/arm/include/asm/setup.h | 1 + > > > > > > > 3 files changed, 143 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/xen/arch/arm/domain_build.c > > > > > > > b/xen/arch/arm/domain_build.c index 1584e6c2ce..4d62440a0e > > > > > > > 100644 > > > > > > > --- a/xen/arch/arm/domain_build.c > > > > > > > +++ b/xen/arch/arm/domain_build.c > > > > > > > @@ -900,7 +900,22 @@ static int __init > > > > > > > allocate_shared_memory(struct domain *d, > > > > > > > return ret; > > > > > > > } > > > > > > > -static int __init process_shm(struct domain *d, > > > > > > > +static int __init append_shm_bank_to_domain(struct > > > > > > > +kernel_info > > > *kinfo, > > > > > > > + paddr_t start, p= addr_t size, > > > > > > > + u32 shm_id) { > > > > > > > + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) > > > > > > > + return -ENOMEM; > > > > > > > + > > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start =3D > start; > > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size =3D si= ze; > > > > > > > + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id =3D > > > shm_id; > > > > > > > + kinfo->shm_mem.nr_banks++; > > > > > > > + > > > > > > > + return 0; > > > > > > > +} > > > > > > > + > > > > > > > +static int __init process_shm(struct domain *d, struct > > > > > > > +kernel_info *kinfo, > > > > > > > const struct dt_device_node *= node) > > > > > > > { > > > > > > > struct dt_device_node *shm_node; @@ -971,6 +986,14 @@ > > > > > > > static int __init process_shm(struct domain *d, > > > > > > > if ( ret ) > > > > > > > return ret; > > > > > > > } > > > > > > > + > > > > > > > + /* > > > > > > > + * Record static shared memory region info for later= setting > > > > > > > + * up shm-node in guest device tree. > > > > > > > + */ > > > > > > > + ret =3D append_shm_bank_to_domain(kinfo, gbase, > > > > > > > + psize, > > > shm_id); > > > > > > > + if ( ret ) > > > > > > > + return ret; > > > > > > > } > > > > > > > return 0; > > > > > > > @@ -1301,6 +1324,117 @@ static int __init > > > make_memory_node(const > > > > > > > struct domain *d, > > > > > > > return res; > > > > > > > } > > > > > > > +#ifdef CONFIG_STATIC_SHM > > > > > > > +static int __init make_shm_memory_node(const struct domain > *d, > > > > > > > + void *fdt, > > > > > > > + int addrcells, int si= zecells, > > > > > > > + struct meminfo *mem) > > > > > > > > > > > > NIT: AFAICT mem is not changed, so it should be const. > > > > > > > > > > > > > +{ > > > > > > > + unsigned long i =3D 0; > > > > > > > > > > > > NIT: This should be "unsigned int" to match the type of nr_bank= s. > > > > > > > > > > > > > + int res =3D 0; > > > > > > > + > > > > > > > + if ( mem->nr_banks =3D=3D 0 ) > > > > > > > + return -ENOENT; > > > > > > > + > > > > > > > + /* > > > > > > > + * For each shared memory region, a range is exposed und= er > > > > > > > + * the /reserved-memory node as a child node. Each > > > > > > > + range sub-node > > > > > is > > > > > > > + * named xen-shmem@
. > > > > > > > + */ > > > > > > > + dt_dprintk("Create xen-shmem node\n"); > > > > > > > + > > > > > > > + for ( ; i < mem->nr_banks; i++ ) > > > > > > > + { > > > > > > > + uint64_t start =3D mem->bank[i].start; > > > > > > > + uint64_t size =3D mem->bank[i].size; > > > > > > > + uint8_t shm_id =3D mem->bank[i].shm_id; > > > > > > > + /* Placeholder for xen-shmem@ + a 64-bit number + \0= */ > > > > > > > + char buf[27]; > > > > > > > + const char compat[] =3D "xen,shared-memory-v1"; > > > > > > > + __be32 reg[4]; > > > > > > > + __be32 *cells; > > > > > > > + unsigned int len =3D (addrcells + sizecells) * > > > > > > > + sizeof(__be32); > > > > > > > + > > > > > > > + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, > > > > > > > mem->bank[i].start); > > > > > > > + res =3D fdt_begin_node(fdt, buf); > > > > > > > + if ( res ) > > > > > > > + return res; > > > > > > > + > > > > > > > + res =3D fdt_property(fdt, "compatible", compat, > sizeof(compat)); > > > > > > > + if ( res ) > > > > > > > + return res; > > > > > > > + > > > > > > > + cells =3D reg; > > > > > > > + dt_child_set_range(&cells, addrcells, sizecells, > > > > > > > + start, size); > > > > > > > + > > > > > > > + res =3D fdt_property(fdt, "reg", reg, len); > > > > > > > + if ( res ) > > > > > > > + return res; > > > > > > > + > > > > > > > + dt_dprintk("Shared memory bank %lu: %#"PRIx64"- > > > >%#"PRIx64"\n", > > > > > > > + i, start, start + size); > > > > > > > + > > > > > > > + res =3D fdt_property_cell(fdt, "xen,id", shm_id); > > > > > > > > > > > > Looking at the Linux binding, "xen,id" is meant to be a string. > > > > > > But here you are writing it as an integer. > > > > > > > > > > Good catch! > > > > > > > > > > > > > > > > Given that the Linux binding is already merged, I think the > > > > > > Xen binding should be changed. > > > > > > > > > > We would be compliant with both bindings (xen and linux) just by > > > > > writing shm_id as string here, but if it is not too difficult we > > > > > might as well harmonize the two bindings and also define > > > > > xen,shm-id as a > > > string. > > > > > > > > > > On the Xen side, I would suggest to put a clear size limit so > > > > > that the string is easier to handle. > > > > > > > > I've already made the xen,shm-id parsed as a string too, seeing > > > > the below > > > code: > > > > " > > > > prop_id =3D fdt_get_property(fdt, node, "xen,shm-id", NULL); > > > > if ( !prop_id ) > > > > return -ENOENT; > > > > shm_id =3D simple_strtoul(prop_id->data, NULL, 10); > > > > if ( shm_id >=3D NR_MEM_BANKS ) > > > > { > > > > printk("fdt: invalid `xen,shm-id` %lu for static shared mem= ory > node.\n", > > > > shm_id); > > > > return -EINVAL; > > > > } > > > > " > > > > The size limit is smaller than 256, just as stated in doc: > > > > " > > > > - xen,shm-id > > > > > > > > A string that represents the unique identifier of the shared me= mory > > > > region. The maximum identifier shall be "xen,shm-id =3D 255". > > > > " > > > > Hope this fits what both of you suggested~~~ > > > > > > Yes. I think supporting arbitrary strings like "my-shared-mem-1" > > > would be nice-to-have but I wouldn't make it a hard requirement. > > > > > > > Oh, the example "my-shared-mem-1" really expands my mind, I think I > > understand what you and Julien referred as free form string, which > > shall not be limited to only numeric number... thanks!!! > > > > You were suggesting a strict limit on the number of characters, TBH, I > > have no clue What the standard is here. Any suggestions? > > > > If considering padding, maybe 19? > > " > > struct membank { > > paddr_t start; > > paddr_t size; > > bool xen_domain; /* whether the memory bank is bound to a Xen > > domain. */ #ifdef CONFIG_STATIC_SHM > > char shm_id[19]; > > unsigned int nr_shm_borrowers; > > #endif > > }; > > " >=20 > Yeah I suggested a strict limit on the number of chars so that we could > embed the string in struct membank. I would pick 16 characters which is > equivalent to two uint64_t in terms of memory usage. >=20 >=20 Hmm, Am I calculating wrongly? When it reaches to nr_shm_borrowers, it requires 4 bytes-aligned, and if it is 16 characters, it will ask extra 3 b= ytes to do the padding(8 + 8 + 1 + 16 + "3"). This is the reason why I chose 19,= to make use of every byte. Or maybe 16 characters is applied to be the multiple orders of 2, which has= more flexibility for newly added field? Just out of curiosity why you choose 16 over 19, hope it doesn't bother too= much~ > > > "255" as a string would match Linux's requirements for xen,id. > > > > I will use your example "my-shm-mem-1", I think its better for users > > to understand, at least for me... >=20 > +1 From xen-devel-bounces@lists.xenproject.org Mon Jul 11 08:00:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 08:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364922.594900 (Exim 4.92) (envelope-from ) id 1oAoLT-0006pi-6U; Mon, 11 Jul 2022 08:00:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364922.594900; Mon, 11 Jul 2022 08:00:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoLT-0006pb-1t; Mon, 11 Jul 2022 08:00:43 +0000 Received: by outflank-mailman (input) for mailman id 364922; Mon, 11 Jul 2022 08:00:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoLR-0006kW-FP for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 08:00:41 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d134543-00ef-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 10:00:39 +0200 (CEST) Received: from mail-bn1nam07lp2042.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jul 2022 04:00:32 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by SA1PR03MB6580.namprd03.prod.outlook.com (2603:10b6:806:1cb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 08:00:30 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782%6]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 08:00:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d134543-00ef-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657526439; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=iew1KypYLNnEardBDEJ1fNDRhWoT8y3h2nRFRCyAQvA=; b=bMRRO4jLxwNpRqDis7frfAKMS70Hhv1VmpBhvrgUwTskJcQgpuXCzFKF L2EDotYbWpoP7O+jB/wLKVXqBbche4Xjv1LbnPJUbbJVpXQiYDjTtSmX2 tns7oD8qWiu6zeByk3JwCqiX2r/Jq35klnsTHJePNF0qyUn1eK9wukkE+ M=; X-IronPort-RemoteIP: 104.47.51.42 X-IronPort-MID: 78058668 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:d/4/naxEw/MF7TPOGQR6t+fxxyrEfRIJ4+MujC+fZmUNrF6WrkUAz 2IYXGyAMqyLYjHzKIogbYy18x9UuZGEydMwTQZr/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX1JZS5LwbZj2NY32IHhWmthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl6qCBdx0RPY32nvVAYUBADmJvNJxU9+qSSZS/mZT7I0zuVVLJm68rJmdveIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtaeGuOWv7e03x9p7ixKNdTXY cdfTDNrZRDJZRBnMVYLEpMu2uyvgxETdhUH+ArI9fRpswA/yiRS74O1CNj1JOayBupchly9h HP052HAV0Ry2Nu3jGDtHmiXru3FkD7/WYkSPKal7fMsi1qWrkQMDDUGWF39puO24makXMlVM UsT+SwGoq079UjtRd74NzW6r2SDpQU0QMdLHqsx7wTl4qbd/QuxHGUPST9FLts8u6ceRyEsk FmAnNrrBDlmmLyTVX+ZsLyTqFuaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cQwc2 BiPpSk6wr8V1MgC0v3k+Uid22724J/UUgQy+wPbGHq/6R90b5KkYIru7kXH6fFHL8CSSVzpU GU4pvVyJdsmVfml/BFhis1XdF11z55p6AHhvGM= IronPort-HdrOrdr: A9a23:Ry8Q2aCmY8qwiiHlHegAsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsv6KdkrNhR4tKOzOW9VdATbsSprcKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUWF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlal9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4kow3TX+0aVjbZaKv+/VQMO0aSSAZER4Z 3xSiIbTodOArXqDyaISFXWqk/dOX0VmgLfIBej8AfeSIrCNX0H4oN69P1kWwqc5Ew6sN5m1q VXm2qfqppMFBvF2D/w/t7SSnhR5zyJSFcZ4JouZkZkIPwjQa4UqZZa8FJeEZ8GEi6/4Ic7EP N2BMWZ4PpNa1uVY33Qo2EqmbWXLzwONwbDRlJHtt2e0jBQknw8x0wExNYHlnNF8J4mUZFL6+ nNL6wtnrBTSc0da757GY46MIKKI32IRQiJPHOZIFzhGq1CM3XRq4Tv6LFw/+2ucIxg9upGpH 0AaiIriYcfQTOeNSTV5uw0zvnkehTMYR39jsdD+pN+prrwALL2LCzrciFcr/ed X-IronPort-AV: E=Sophos;i="5.92,262,1650945600"; d="scan'208";a="78058668" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iRuRurHaUy6auGhEDgknjF7cR7xv50zRQvjCL0LV7esIAyW1U14TQtiRnLeT9yoiPiVU+i4YTzmCdkOqTAnVYufYokAWS+5CjefZLo1hNiAtwcUHmx27lXbImt1vKDRPsybGsXgq7h5F1dKSUSfqzvhV9sydP7uEpg/skMIumds0dQM85CbdDPS+yevVNmIIjb710Bjacr+dymrMgh5GqIPCtTohKl16xrQsZK0HfR+zZqf3b3CFx11ntUUXitKlok+FTethFshbUKfc12fPvKrCykFbbDBgOeOEg50HWP0pOjXpwjJ4SLN6VhQWdCk4EbX/q6bgNJnISWs0faJ8+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iew1KypYLNnEardBDEJ1fNDRhWoT8y3h2nRFRCyAQvA=; b=IuNbzBBZC7Xe+tezsUQNK7Ws6YqH4e+eKoY4pUrNWmxMoafSgMb6KTslNUjc65VvP1llnT09QQoDTxf91XXTBpJd8bI3ewDlyHvgSoCY+RCRKpzMTnNbJt0/++gVFlDJFjm5DbgY1klNnrCJxHY8A/pyZinH7AoqIgavVbojx2Bjm0Q/UC8/0WLAiwVYqlSg5tpyqrhQX61qqW0TfyTA5tFtpxSi1cB2h3QeesRwc1ZTirAFJpURhBSTnrGGoG2pmghCgGysRxisg21lpp7E5PEMyBMcv+uRQSRUl2vMkVuxaQ9+NUO2BLJh0Yxsh//YsBEbAbxL2gqoIxBvV7RUPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iew1KypYLNnEardBDEJ1fNDRhWoT8y3h2nRFRCyAQvA=; b=fQoSqA4N6tLt/6Lb4Xf04wOtCM7M4sKyzPQiqozpRPBtplSG1QXoyfkkWMmIZwtKN4QzcBGUstIQsMbFJBzQHN3rVk9Ls3tC5zs39gWdKTPm4sm7IZ9Bx1uYb3fFrUFgSR5z3yu5xOTokDekW3Xb6qpK7CEC21BAjMga4z0vlu8= From: Jane Malalane To: Jan Beulich CC: Wei Liu , Anthony Perard , George Dunlap , Nick Rosbrook , "Gross, Jurgen" , Christian Lindig , David Scott , Andrew Cooper , Roger Pau Monne , "Nakajima, Jun" , Xen-devel Subject: Re: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Topic: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Index: AQHYi8Ac3FlD8zBv9U62svKKFrIqXq1nSpWAgAAsEQCAEWpoAA== Date: Mon, 11 Jul 2022 08:00:29 +0000 Message-ID: <6b01e02b-ba44-5f8d-f766-ac889c28d662@citrix.com> References: <20220629135534.19923-1-jane.malalane@citrix.com> <20220629135534.19923-3-jane.malalane@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6f23fab9-82e6-426f-a355-08da63136c4e x-ms-traffictypediagnostic: SA1PR03MB6580:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Uf4VU89MUInl3xgKXqkRkZd6IBPX9tj7nXo+WlAmXXwddIgr3Yqez1PS0oqdMx4g4UnFOhPVyGcUxp58xveIdMdI6YifjF2aMZW4L2g3fGXJJzKZFzhT8nRUpYQIfXAnVThG/qU6gT856tWCVIn6xY2XwX8Y/yhjuMlxX53vI0clh9y0gkjxtJl8Z1wVuo18HZfDO453QfKUpXfgVrdsHRRJo5kMZEAYlAME34SQRK45KIFDjB/+b2xb4T+W+6SBC4ORDYo8YcuE2kb2g3mCS46g8ZvXcAxE7wJ9w6d+iy6yCc+xrMYKE+rFk/n1n2RWv0O8Z2JBdRaIj8Kv3ofGVmegEF0Wyd9q+na1WY6OA+AmgC3zf/a0eVeLIk2EqY4yeWIN4oOZW6myuXh8oBTty0CEvpagiSRQOYO8uIMMlfKhlDsAswVlHKIJE+fc+lkLIVW9i0fZR8avH63WxEg5J2UHOgq+yJIWV8t7eLYZ1pBTNGvKJ8V/1KrAy36Zu6FlAJDnx0KaIemMEuSmv2xqK2Mfuy86JI0EUEMYMErlqDzSApxov600FPnrITiYwWs+Ud6n/PXHDj7HT12XwnRtY7R95412sosx1myCNuKpMtky6CIkqtPFt49rVNsnk7XjW/4zjbm7xPMLduGl5+IewJ1cxJ1zcOMrVSwDAMSha/PQxQ0ckOP0dz/TkbImwfflpW+NOIZch550t2C+7b+H5/BOsBvg6ra6/cEPGh7B6M/lraQWWOW7u8Py2s+aemHrnW10LFXPp9ZMj7aVDx97P3owDxadw4NFmsmihOwElZdqx32Ka4w+G7pu/TBxvoCbllH6ZGBm3aMa6X7u/jGlcpxAf1WspiaKQJwdGPotNMI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(396003)(366004)(346002)(376002)(54906003)(6916009)(76116006)(91956017)(38100700002)(31686004)(66446008)(83380400001)(36756003)(8676002)(66556008)(4326008)(66476007)(66946007)(64756008)(71200400001)(316002)(478600001)(41300700001)(6486002)(5660300002)(2906002)(8936002)(6512007)(2616005)(186003)(26005)(53546011)(82960400001)(38070700005)(31696002)(122000001)(86362001)(6506007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NmZaTHlycGFpVHk5NlNVMEFsZkY0UXBGV2FHSUcwWXRFSi82MEZMR2NPemxI?= =?utf-8?B?MkM4MEdNVnpZc3kvaWJVZkZLdnlGOWVIZkJXdlJIVWFRc2c3RjhXQXBudUcz?= =?utf-8?B?UjJwdTBqekdVTzRXQ1pDR0VYc1pvUGV5SUNBL3k2RnZ3NlFhVFVlZlk2S1or?= =?utf-8?B?S3lJTVhSSzVVUm1nc1ZxVk5FblBPcUk0Qm0vaHkrbkV6aVlCYnlvUHNTdEZP?= =?utf-8?B?T20wcTJYY0NuMnA1Vm9yY3hMMU9ZOEQvc1M5dHl4SVA2MTlncmg3UHBxbzR5?= =?utf-8?B?TXdnRzNldUlPT1BXcXlHR2NJTDBHaGtPMFFNMit0aWk2cEIzSnc3bjNid3BS?= =?utf-8?B?TWNnenI1N3RYOWxTR2pMV2Fua0lDMWZuSjlDMVFMTUFYRlVSRTh6VHpLTW9P?= =?utf-8?B?YndiNWI0QzgxTE5oYVhidFRHdmtnNWJTOHVOSHRxZXBWcncxbVd3bHpKcmtB?= =?utf-8?B?MWZkcUp2aUFlR1NiUHBQNXk5bFQwbXRrTzRtaEVTblRvRGdla2V0cWRFY2Ja?= =?utf-8?B?dXkvVm9Zdk9rL0tPV3pmUFljNWpKZHI1RmpQdnZFYm9vNFEzMjVjSGFRR2V4?= =?utf-8?B?R0ZUNVMrVWtNbHlnOUpwTER0RlRVL3liZmsrRzB2Q25ETDN4VjJEMzZOdzJ4?= =?utf-8?B?eE5OY3dLbzJCM2ZUUzc4MDRoMjRpL1hCa3F1RUVDRUk5eThZRytjMEtzMzE4?= =?utf-8?B?N3BaU3AvdFRqSWJKVHFKMzZNZzI5cnpUL1puTXFoQ3Y4NTgzQk1JZ2pEb2xO?= =?utf-8?B?UXFYbmVwK0lhdjBlZ3NYZnZvYVBwdTRTZnV2cTBkU0cySVBBNnlselNDZFd1?= =?utf-8?B?bktLT2pwd2xpQXJmN0FyUi9Ha21LN2FsK0ZPRmtGV09aWjJKU05qa0N2MTRT?= =?utf-8?B?YjB5MlVvdUdpU0FBV1l5djZaL2ZIekJKQVpEanJMY01JUkk0U2pTV1Nybys1?= =?utf-8?B?Q2VjMzQ1QXVOSlEvTXExbk5mOE1LR3lGQkhmeUxQeDVIaE1xbGlsdm1GTG16?= =?utf-8?B?S0RtelhsbHVZVTNrQitCWjdLbDl3c1B4NGM1R2VIaUJ5UEZYM1ljZDQvWnph?= =?utf-8?B?YTBQalpscUd0dUc1dC9KS1JoKzNWMVI5U2s1T05LRGgvcU1LSm9xY2pRYSsr?= =?utf-8?B?UTIrY0Y4U2FQT0NmZTBET3BiZWhzcm9FejNML3k4WkhFYXVmK0V4c2FBTWV0?= =?utf-8?B?RTZML3M0QVJVK2FMUmNNUzdJamhXRzBKc3pxaU9uRnlmeUsyQ1VGWkR1WlI4?= =?utf-8?B?bGx5M0U3c0hsaGt6SDNoK1dDUi9PNU55YnNuU1JZVG5nVnN5ZGFZLzIwMzJY?= =?utf-8?B?MGZPRjlIMFJiK3o2UDhJdWE3NE5JZVpTUFhtNXAyd3U4YklFN0FHTG02SEhL?= =?utf-8?B?RmdEYUtvaHBObUVRaGZYdnJTWDBvakVxa3FwYkFoMUtqWnZLOFgyWFFiWGlM?= =?utf-8?B?VEpnRENrbE9YMXUrZVVwU1hRUHZiRFBNNnR6SzRLem0zSjVmT0VNM3dUWXJ3?= =?utf-8?B?VlNnRkgyUmJLYkFNK3krUG1Ob3BmdElZOEtTZUtHN3hmejRsMEJyblIrMWha?= =?utf-8?B?QWwxM0JXRStRbkVFVGFMVlNyd3FrS3hWcy9IR0NTbmtZMlNOYmZRTUhzNHZ1?= =?utf-8?B?UVNUWUlNaTNDNXdoS28rdmZsTUtIVFg4R2crd2lBakdTOFcyVDVYei9TSDU1?= =?utf-8?B?enk1Rkx1WmNTTFV6d2xtWVVxRHNqS2R6a2F5MFVoYlNUa2dCQ0F3UlpZSFlC?= =?utf-8?B?R0J6TWtVMFFCYjlteDhxdGNzS2xFZFpUOXcwTnd1L05pMldHT0htN2VpQXEz?= =?utf-8?B?MFQxcnhHNUlxMWNhVDlKTjBtdVZDOFhmOGtZS2J4Nm9BRzcxS1BicEZGeEJy?= =?utf-8?B?cEQyczN0aTZrTVJhbFMzMThpNmpZNkhGZGNzQkE4cnZjdTJVU1BqWVQyWVlP?= =?utf-8?B?cmFFSFdRdUlpOUVlN0VLbkRZdDhCQ3EvRXM3RkNiY2QrR2VyQ1hpcUFMR3dD?= =?utf-8?B?TGhYZlMzdnpyTkl6SEEzRm5mampHYlhwODBSVXJCZ3oxb2t1WkszQTVnamgv?= =?utf-8?B?N0tOOEFoUTBDVVZvc3pWK0IzNDhPaitqeXZOYlMyd0MwWFYwS0oycitLMzdY?= =?utf-8?B?SlhkcXlWa2l3Y0VFTGFOWlFWbmMyZndpRjRaNzFGRm9JR2VLYjB2bzhmYUh2?= =?utf-8?B?Q1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <2D4F541CE45799458B4BE8AAB81E92D9@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f23fab9-82e6-426f-a355-08da63136c4e X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 08:00:29.8655 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Lib7TMgG5GO0LktYRuYYs4RdvV0mHCYAzbVa0/cQ5HKAlZqXpUvXBKoWxUIO7Lpb8llPHDwXpkJ8hb0MnPr8JbA0lKLu1VD5c8iBEg0tpQc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6580 T24gMzAvMDYvMjAyMiAwNzowMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDMwLjA2LjIwMjIg MDU6MjUsIFRpYW4sIEtldmluIHdyb3RlOg0KPj4+IEZyb206IEphbmUgTWFsYWxhbmUgPGphbmUu bWFsYWxhbmVAY2l0cml4LmNvbT4NCj4+PiBTZW50OiBXZWRuZXNkYXksIEp1bmUgMjksIDIwMjIg OTo1NiBQTQ0KPj4+DQo+Pj4gSW50cm9kdWNlIGEgbmV3IHBlci1kb21haW4gY3JlYXRpb24geDg2 IHNwZWNpZmljIGZsYWcgdG8NCj4+PiBzZWxlY3Qgd2hldGhlciBoYXJkd2FyZSBhc3Npc3RlZCB2 aXJ0dWFsaXphdGlvbiBzaG91bGQgYmUgdXNlZCBmb3INCj4+PiB4ezJ9QVBJQy4NCj4+Pg0KPj4+ IEEgcGVyLWRvbWFpbiBvcHRpb24gaXMgYWRkZWQgdG8geGwgaW4gb3JkZXIgdG8gc2VsZWN0IHRo ZSB1c2FnZSBvZg0KPj4+IHh7Mn1BUElDIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9u LCBhcyB3ZWxsIGFzIGEgZ2xvYmFsDQo+Pj4gY29uZmlndXJhdGlvbiBvcHRpb24uDQo+Pj4NCj4+ PiBIYXZpbmcgYWxsIEFQSUMgaW50ZXJhY3Rpb24gZXhpdCB0byBYZW4gZm9yIGVtdWxhdGlvbiBp cyBzbG93IGFuZCBjYW4NCj4+PiBpbmR1Y2UgbXVjaCBvdmVyaGVhZC4gSGFyZHdhcmUgY2FuIHNw ZWVkIHVwIHh7Mn1BUElDIGJ5IGRlY29kaW5nIHRoZQ0KPj4+IEFQSUMgYWNjZXNzIGFuZCBwcm92 aWRpbmcgYSBWTSBleGl0IHdpdGggYSBtb3JlIHNwZWNpZmljIGV4aXQgcmVhc29uDQo+Pj4gdGhh biBhIHJlZ3VsYXIgRVBUIGZhdWx0IG9yIGJ5IGFsdG9nZXRoZXIgYXZvaWRpbmcgYSBWTSBleGl0 Lg0KPj4NCj4+IEFib3ZlIGlzIG9idmlvdXMgYW5kIGNvdWxkIGJlIHJlbW92ZWQuDQo+Pg0KPj4g SSB0aGluayB0aGUga2V5IGlzIGp1c3QgdGhlIG5leHQgcGFyYWdyYXBoIGZvciB3aHkgd2UNCj4+ IHdhbnQgdGhpcyBwZXItZG9tYWluIGNvbnRyb2wuDQo+IA0KPiBJbmRlZWQsIGJ1dCB0aGUgcGFy YWdyYXBoIGFib3ZlIHNldHMgdGhlIGNvbnRleHQuIEl0IG1pZ2h0IGJlIHBvc3NpYmxlDQo+IHRv IHNob3J0ZW4gaXQsIGJ1dCAuLi4NCj4gDQo+PiBBcGFydCBmcm9tIHRoYXQ6DQo+Pg0KPj4gUmV2 aWV3ZWQtYnk6IEtldmluIFRpYW4gPGtldmluLnRpYW5AaW50ZWwuY29tPg0KPj4NCj4+Pg0KPj4+ IE9uIHRoZSBvdGhlciBoYW5kLCBiZWluZyBhYmxlIHRvIGRpc2FibGUgeHsyfUFQSUMgaGFyZHdh cmUgYXNzaXN0ZWQNCj4+PiB2aXJ0dWFsaXphdGlvbiBjYW4gYmUgdXNlZnVsIGZvciB0ZXN0aW5n IGFuZCBkZWJ1Z2dpbmcgcHVycG9zZXMuDQo+IA0KPiAuLi4gSSB0aGluayBpdCBpcyBkZXNpcmFi bGUgZm9yIHRoaXMgc2VudGVuY2UgdG8gc3RhcnQgd2l0aCAiT3RvaCIgb3INCj4gYWxpa2UuDQo+ IA0KPiBKYW5IZWxsbyBKYW4sDQoNCkluIHRoZSBwcmV2aW91cyBlbWFpbCwgSSB3YXMgcmVmZXJy aW5nIHRvIHRoaXMgZGlzY3Vzc2lvbiBhYm91dCB0aGUgDQpjb21taXQgbWVzc2FnZS4gSSBoYXZl bid0IHNlbnQgb3V0IGEgdjExIGJlY2F1c2UgdGhlcmUgd2FzIG5vIGNoYW5nZSANCm90aGVyIHRo YW4gdGhpcyBvbmUgc3VnZ2VzdGVkLiBXaGF0IEkgc2FpZCBlYXJsaWVyIHdhcyB0aGF0IEkgdGhv dWdodCANCnRoZSAiSGF2aW5nIGFsbCBBUElDIGludGVyYWN0aW9uIGV4aXQgdG8gWGVuIGZvciBl bXVsYXRpb24gaXMgc2xvdy4uLiIgDQpwYXJhZ3JhcGggcHJvdmlkZWQgY29udGV4dCBmb3Igd2hh dCBJIHNheSBhZnRlciBidXQgSSBhbSBoYXBweSB0byByZW1vdmUgaXQuDQoNClRoYW5rcywNCg0K SmFuZS4= From xen-devel-bounces@lists.xenproject.org Mon Jul 11 08:27:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 08:27:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364934.594911 (Exim 4.92) (envelope-from ) id 1oAokZ-0002Wf-Ny; Mon, 11 Jul 2022 08:26:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364934.594911; Mon, 11 Jul 2022 08:26:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAokZ-0002VM-IE; Mon, 11 Jul 2022 08:26:39 +0000 Received: by outflank-mailman (input) for mailman id 364934; Mon, 11 Jul 2022 08:26:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAokX-0002VG-VO for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 08:26:38 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60047.outbound.protection.outlook.com [40.107.6.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2d4263d0-00f3-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 10:26:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8983.eurprd04.prod.outlook.com (2603:10a6:10:2e2::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 08:26:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 08:26:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d4263d0-00f3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kFXppaNp0EzHbPHm5OpKx8GaFyfenLM9+2/e2rDJyNXTn5zeEBBJmhcDOco7FTXGVMJ+IQBqASObqa2DZ49iz1QrC3l7z9LxDRxXEK+crV4i0K4tNf0M7/odzSdm2A5geXPbFs8g5MIOwbiAVL7lXlaRwhkEmMM5cLF7gyOQg0vvC/JapxHKI1hGEE14/RIJX0qOb1aAt5qsSCrrDTPzKSL15OA9Kzr1D+XvvfrAP547Y/njLMSvYP3+h/ldrG1K6NTQvmtQSeRqCVH45blnktbusunxKXaHt0z1BfCXZ/J7KKRvSrmcnjQLVLRUxo9dPCnN34XU7IlPw4hBvI9q/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SSd7oNfivnMJE+omTLKeRVu6AOBoJecHJZhcH44Ew5U=; b=aRX8ooFhnaRUjY/46ZadA6NffEnWwMsAysajBnutHfrvJbd70k/FnDu2Fj++q7GCFhCzoVpZvnKmVogk+gBkK8USw+HwXMnBb1APgu+lfYu8mXyPGtd43Pj5EThmZdu+43ol9DEuhijF43e5ROKGRGYiJbsJykBRiKfTFBr3nJcxmdlP45dLAGeMFXwzbWGP9wQ8yZdsOI+XvUzRQhhBAahcoS/4BtRhCskJDIgkFrkIZmibFaRrLTM88nCnjwn7qu7f/6dbkJ/vx2SJw+Gt9+VZiXjBdKo4cRBHsp+LC/aJbHo2St2ZxypGK85bsoe9CiOIvUCjkK8HNNamgkW3KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SSd7oNfivnMJE+omTLKeRVu6AOBoJecHJZhcH44Ew5U=; b=iP5w9cDcycEKa+28L8bMczGxUJ77T67uV0RgGTxKVSlPW4+5pY17e6WMeAqe5uWT4ihaJWiYtd5JZAsU91b/Z55ZrgwyW3tqT2CzNCzoDQY69euxw+ESVKIfQ7b4f5L+x0+J95Dmp0j7S2/UP+tzIUza945T0bVSAAU8CyPKm0VGYwWmoWIXYF/kCjmDZuk/4cf77vA2fU3vxiHJTsz0K/+ogRQs6MwNWSAzEB/GTk/FKVC7t7/cKkJOyTN07y0M80nlRWHrzm6UeEMDUEQ4TwD+gnfiXU2VA0xyYWC+eCUYP23Bb6AJ5cctPp7OV4enq8AfOkaRUERu0DB3AzHdbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <64e06bd5-7919-7235-600f-b9b0e59ef66f@suse.com> Date: Mon, 11 Jul 2022 10:26:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Content-Language: en-US To: Jane Malalane Cc: Wei Liu , Anthony Perard , George Dunlap , Nick Rosbrook , "Gross, Jurgen" , Christian Lindig , David Scott , Andrew Cooper , Roger Pau Monne , "Nakajima, Jun" , Xen-devel References: <20220629135534.19923-1-jane.malalane@citrix.com> <20220629135534.19923-3-jane.malalane@citrix.com> <6b01e02b-ba44-5f8d-f766-ac889c28d662@citrix.com> From: Jan Beulich In-Reply-To: <6b01e02b-ba44-5f8d-f766-ac889c28d662@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0112.eurprd04.prod.outlook.com (2603:10a6:20b:31e::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc650e15-e888-4e41-f6e4-08da63170ee0 X-MS-TrafficTypeDiagnostic: DU2PR04MB8983:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gT/DcenU/zoXA5T12KaF+wT/Nw6SmddciwvQ6iA2AhjJ16F6d7TG1sY+XQMQaVax/M6DRipBtzzNAjBz3wKoS4ezMnf7IaexyJ/sw/IDMSHY27jYfgvWvd/BeZTbXz10C8Lc7sw58anBF+k49a9IQSNP46w3TnYvvjaDaM3ElpF/82lXFo7e2S4hfHjCwb5a93b5p4nd/APU2qNnVQiS1eKcY4absBfWkhMHz+7HYVQQaxEZRvCzvNH3hk6/tyyc+AH3RpqYj93sBIe1cx7GW+nzvp/aiR8FjB0QcVV3j6prest/FTZmh85cIR9yWRVkpCFro5GIxK41zFTdFtc0zUU72CyX9Eq+WMMXn5J2IKlwA6Um+f3MwPs5InO3UfHdMU6/sd+toqlUAMcfeP85si68jMS5SOUHFu3hKAdQIlG5zDfVcMck2E58Snoh+vbWnOrl3Vl6/nWtzPIf5butYIRcc65r7U/falrX5bnx5BRGyQF/x13s+StJ0Xn/gk5kmnRK3w45OUqDMdIlRjOpqnZP+r2nSZvelX95gP7Q/cu7LtXtpufPoMT8K/ZSP3kADC9S7mzoQCcjs4OHivA/sPIYFaoDbOAsul/II3t8a9Rq3OO/CD1IgvgF781lzu6d0c9I+7MMBaQgKPbbrVlG/K9ZELCINiMl0YNjNn/hucYWkCfgrW0uk/teTW8KGgNqVS8o1i0KzvZnoeWcGK+03fTv6CQtzcOMnzATW0MVrkzpskiBF7SwneF0QvjOACqCUAP+Zb3gFf9RC/Llvgp036KmFZJ2BTqwl7nBPCyyOFuI8MR/O0ANYghyeRajQAjZLYInALLSw5BIQaxqUaxTsA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(396003)(376002)(136003)(366004)(8936002)(478600001)(186003)(5660300002)(7416002)(6486002)(53546011)(2616005)(26005)(83380400001)(41300700001)(86362001)(2906002)(38100700002)(6506007)(31696002)(66946007)(31686004)(66556008)(316002)(66476007)(6916009)(36756003)(54906003)(8676002)(6512007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHcyY2haQWNpVzFNVTRoT1dTN2kzd1J0SUtGcnRQdXF1aTR1QmFGVWxWaG9D?= =?utf-8?B?QXBxemZKK1c2WWJ4enVxUUwzYzYzUmtwbDlWSkJnT0l2cVZLdzdBZGtlVXdl?= =?utf-8?B?aGFLUmEyeVlvOWwrQVQ0NTJZcTg5aGpudjlJYktVWkVqUFFxS3lkSjd6R3VK?= =?utf-8?B?YWp5WjU4SG11bnJwZ2NUbVVBNUx6QlBWL2w0bDNSMHNOM3UyallYd0tMait3?= =?utf-8?B?eE5TQmNsVEpKMmkvZGN1SEVxcGxtU0p1dkp2a2Jzc3h5KzdxSVAvdkZhYlRl?= =?utf-8?B?d0tSaUJDbG0vWnNPT2F4OE9tbDNuWGxkanV0MEErVi9pWHlpc2xrVEZkZnd6?= =?utf-8?B?OC8xRnF4aVIwQUJjWGpYL2lnQ2d4S21zZ1VKSU9BRisyOU9SeDB6UTZ5ZGhk?= =?utf-8?B?UVFDTzJMNTVGZVJ3TXJyRlFYckcyTUt5NlJTRVBtQmtVM3hhS3JiSkhDWmxh?= =?utf-8?B?dDZaekU4d2VLU2JtWlp3Q2E2emdtV3haQWVDY1E0YnlESm1rMm14aW9RSGcy?= =?utf-8?B?NXovRk1LT2J1b0Z5VElzL2dLRVU5TFJSTEZzazlEaldLYlFPekdaQUNHUmU0?= =?utf-8?B?bkdhUHhURU5vMGY5dGRZb1BYZ2NITFlqOEJJb2tOU3gzMU8rbDlFWXZjQXdM?= =?utf-8?B?WXNHdFlabWNFc093aUVxWjdCamJ5V2VRTERWSnJoQjYrWkFsNkV6Uk9xcG5K?= =?utf-8?B?WFFIaTJKYmJ2UFkxN0lTN3o0Z29Eb2F6N21xbjNhMDhiZVVFanZNbUpGYUxT?= =?utf-8?B?aFh6S1BrUHFPczZNQmlvemRDUmdzaFNBZmdibmFlVHpXN2wxd2RoMThHTW4v?= =?utf-8?B?d0dXblh2Nk1tUXd2U2psa2ozUGlJVmxjNW5EaUlQVzkzb1NobEZvMGcwa0lQ?= =?utf-8?B?QzVLdHZmcWlDUThOYTl1QXJSRU5BWUtkcDlia0pPMm5tRytuSnFCaDlyc3E4?= =?utf-8?B?OTNoT1F2aWtMNUxpV3l4Wmp4bFdQQ0JDSXJZZHVoaWZhS291bTBiZG82M0l2?= =?utf-8?B?MVhDZEQzbVpzT2kzNW91QjcvSjV3ZU15Z0psb0RkYWd5Z0FxTjJLYmcvRmcr?= =?utf-8?B?UGhiMlhzZXFQU0l1UE4wTWIxTHQya1RBSTJRbG53RW9ZTmpXMjB0T2VTWDNn?= =?utf-8?B?enZTTFpaRCs4alFFT29yVUNuWHVOVmlMRU1WaHl6Vi8yN0NBREJrRUxMNUor?= =?utf-8?B?MnRvTWttblowU2lSUzVqNi9kSGZWNkliWVcwQ2xNUm03U1BEcVMraWtxcCtl?= =?utf-8?B?UFMvOUEvbUR2NHpjQVlGMUR0V3JyeDRYMWs5NXUvcGZvMm5rSXFLRm5ZSnAr?= =?utf-8?B?THBuUjVFUTM2SHlvMFJFejMxRU9Bek04UHArdU80UmpmVm4rSFNmcjJJdXhy?= =?utf-8?B?RURQa0xKT0hYUW9zNkxhQjhBUDlsQzFhYjBIWmhabWZRd1dqRUJhNFhZbE1C?= =?utf-8?B?cE55T0xJY2U5Tm96TnpMSkRlNXJ6eE8rZU15RGxoVjRuZmtBYnpTSFJuOHRP?= =?utf-8?B?QldaSE1sTDUrSHFPODdRVDJOanNSb3A3aDJWMFcxWFFBWUJUa1l5UjNSOHVt?= =?utf-8?B?aFhaUjNCRTBON1pnR3RFek9yZ1d3RXB3OE9jbU1OSUFVMjBBdXRLc210YTdk?= =?utf-8?B?bHZXc2ZSRDNCazBkYVB1Z291Y2hHK085MTBOdStSSWtwdVJ2cG54ak9hNVo4?= =?utf-8?B?Yy9zeHZpeXZRZjRhcmpHcnZMZDlpc0F2RGErdXcyb2hRdmpZc0ZVMG12WVF5?= =?utf-8?B?Y01JSDY0bkRiRzZkR3VkNGl4dUZLWEtOd1NGT0E5YXJRaGg3cStBRUlmYkhS?= =?utf-8?B?NkZDNTJybWtyTnl5OEttcVlkWnB1em5mMWZ2VTU1L29IaXVTVktMUUwrenFh?= =?utf-8?B?akpoQ3JTdFM3TDBBdC95RE5lKzQzL0d3TGRLd01GTUN0eG1Nb1VMbk13L1Rm?= =?utf-8?B?d1Z1eTUzTWNoWmJXek1qMUoraVcvdGN1UXhtTnREbTc2QTVXOUk1ZTlnanAr?= =?utf-8?B?RVJsbEtEZlRnUDlSVkpvbTZKRERNOFlJQzJGTHdkV3UrVFAxNzNmQmx4NEgy?= =?utf-8?B?Umc3a25ybnpCeHpjL2tGUlFmeXo4TzdKL2diQS80TE9aREFQT0JhV0w5N0M5?= =?utf-8?Q?uNfgd1Ew22Sf60qkM1KYe77Pf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc650e15-e888-4e41-f6e4-08da63170ee0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 08:26:31.3243 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rLekwKc4bt6iDJa1NTsNOsSGzvMT3KLabM8hh6O6Eg3QTY8UUoFyZ8RMBI5Fw6vi5oRT2uBuD0O4O45YxL0FbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8983 On 11.07.2022 10:00, Jane Malalane wrote: > On 30/06/2022 07:03, Jan Beulich wrote: >> On 30.06.2022 05:25, Tian, Kevin wrote: >>>> From: Jane Malalane >>>> Sent: Wednesday, June 29, 2022 9:56 PM >>>> >>>> Introduce a new per-domain creation x86 specific flag to >>>> select whether hardware assisted virtualization should be used for >>>> x{2}APIC. >>>> >>>> A per-domain option is added to xl in order to select the usage of >>>> x{2}APIC hardware assisted virtualization, as well as a global >>>> configuration option. >>>> >>>> Having all APIC interaction exit to Xen for emulation is slow and can >>>> induce much overhead. Hardware can speed up x{2}APIC by decoding the >>>> APIC access and providing a VM exit with a more specific exit reason >>>> than a regular EPT fault or by altogether avoiding a VM exit. >>> >>> Above is obvious and could be removed. >>> >>> I think the key is just the next paragraph for why we >>> want this per-domain control. >> >> Indeed, but the paragraph above sets the context. It might be possible >> to shorten it, but ... >> >>> Apart from that: >>> >>> Reviewed-by: Kevin Tian >>> >>>> >>>> On the other hand, being able to disable x{2}APIC hardware assisted >>>> virtualization can be useful for testing and debugging purposes. >> >> ... I think it is desirable for this sentence to start with "Otoh" or >> alike. >> >> JanHello Jan, > > In the previous email, I was referring to this discussion about the > commit message. I haven't sent out a v11 because there was no change > other than this one suggested. What I said earlier was that I thought > the "Having all APIC interaction exit to Xen for emulation is slow..." > paragraph provided context for what I say after but I am happy to remove it. I'd be fine for it to be kept as you had it, but you really should have sent out both patches. There are rare cases where sending out individual updates within a series is reasonable (e.g. to avoid spamming the list with a large amount of unchanged patches), but I think here you want to make things easy for committers and not have them hunt down the earlier version. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 08:30:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 08:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364939.594922 (Exim 4.92) (envelope-from ) id 1oAoo9-0003uj-4v; Mon, 11 Jul 2022 08:30:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364939.594922; Mon, 11 Jul 2022 08:30:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoo9-0003uc-1q; Mon, 11 Jul 2022 08:30:21 +0000 Received: by outflank-mailman (input) for mailman id 364939; Mon, 11 Jul 2022 08:30:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoo8-0003uW-9s for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 08:30:20 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b18981c8-00f3-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 10:30:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 126FB5C010D; Mon, 11 Jul 2022 04:30:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 11 Jul 2022 04:30:17 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Jul 2022 04:30:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b18981c8-00f3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1657528217; x= 1657614617; bh=2N9aCDj202Z+yCenUvIsiCeBsatd0v7C6b11NQLfi/w=; b=m Fb7pLvTWiC0pWxLwQP5iJn1qsDqPRorTtgbyyS5swMm5t/6a/AOY/nzeJbpYGjrF T1P2w0DGKVrteFaMnTxkmaMLVg5Qk2+IYtJeHRAPVnSSBOYlm2be/nYPkPoT1Bh7 QEMMUEY1t1NSQUic8iSzFRmeF9MizqoCnV57RaVUh1ztk4cbjwAAbGobyAQJYC3Z nqBE/aHm85EO/24OXzqMUQcIo6y+bQ7W2go8SoFVXS40P/uI4q4QQHSFf3bVKFEc Ww97Unwjt2MZblg/OT3nw1Je5iT6L9kMdqvcNcQYwkicB1+tLpvoQy1vuYqxT6wa 3BTcwTwq0lu12blxHFckQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1657528217; x=1657614617; bh=2N9aCDj202Z+yCenUvIsiCeBsatd 0v7C6b11NQLfi/w=; b=Yz3ljaW/TD5y5Wez75KKBGHMoUf8Vz7fkcxMzGmB3kVK yM/8uERWekDwnYeZpJ13pu6iWEOe18qlTdLPqe5C06Y/kDKZQ3pPzzSwmzttkKvt VmL3exQ+wkZmt2/b4ErbTUhtng9jlSZj6KYqNbrqxTw9ZG4zvfxW9EY54zt0mxk5 As6Krq53fYtZs1c/DyUQGSgw4LEEVRMSVx8MJxwj2NoYWiCDCTWnqx5aM9l5YDmT tUlHeXPhLpIsspy9t0wO9FwjIM936/ilYTjRi8WACQbD34fbEAZf747k5vRmE9EX O1Jy7OJ0Ev/6d8Zbvro0urXEAdIhjWOWFVaRKZMnkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejfedgtddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepleefjeeukeehkeegiedtgeekkeel tedvhfduudefgfffheffheeuvedvieelfefhnecuffhomhgrihhnpehkvghrnhgvlhdroh hrghenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegu vghmihesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail Date: Mon, 11 Jul 2022 04:30:11 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Xen development discussion Subject: Re: [PATCH v9] Preserve the EFI System Resource Table for dom0 Message-ID: References: <20220708213403.2390-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ue0OKNrOXfLQGMxN" Content-Disposition: inline In-Reply-To: --ue0OKNrOXfLQGMxN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 11 Jul 2022 04:30:11 -0400 From: Demi Marie Obenour To: Jan Beulich Cc: Xen development discussion Subject: Re: [PATCH v9] Preserve the EFI System Resource Table for dom0 On Mon, Jul 11, 2022 at 08:41:59AM +0200, Jan Beulich wrote: > On 08.07.2022 23:34, Demi Marie Obenour wrote: > > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > > firmware updates to install. According to the UEFI specification =C2= =A723.4, > > the ESRT shall be stored in memory of type EfiBootServicesData. Howeve= r, > > memory of type EfiBootServicesData is considered general-purpose memory > > by Xen, so the ESRT needs to be moved somewhere where Xen will not > > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, > > which Xen will not reuse. dom0 can use the ESRT if (and only if) it is > > in memory of type EfiRuntimeServicesData. > >=20 > > Earlier versions of this patch reserved the memory in which the ESRT was > > located. This created awkward alignment problems, and required either > > splitting the E820 table or wasting memory. It also would have required > > a new platform op for dom0 to use to indicate if the ESRT is reserved. > > By copying the ESRT into EfiRuntimeServicesData memory, the E820 table > > does not need to be modified, and dom0 can just check the type of the > > memory region containing the ESRT. The copy is only done if the ESRT is > > not already in EfiRuntimeServicesData memory, avoiding memory leaks on > > repeated kexec. > >=20 > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ > > for details. Tested using qemu-system-x86_64 and xen.efi. > >=20 > > Signed-off-by: Demi Marie Obenour > > --- > > xen/common/efi/boot.c | 134 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 134 insertions(+) > >=20 > > diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c > > index a25e1d29f1..d2f66a430d 100644 >=20 > As asked for before - please have a brief log of changes between > versions (at least for the delta from the previous version) somewhere > above from here. Sorry about that, will fix in v10. > The patch looks almost okay to me (see below), but I'd like to ask > for explicit confirmation that this time round you actually did > test the change at least on one architecture (presumably x86). Iirc > one of the Arm folks offered to test it on Arm64 - would have been > nice if you had included whoever it was in Cc. I did, though it was in emulated QEMU (in full instruction emulation mode, no hardware virt). I had to disable EFI Runtime Services to avoid a fatal page fault (seemingly in the OVMF firmware), but this is unrelated as the same problem happens on master. Also, I killed the VM after systemd started and seemed to be running normally, on the ground that any problem caused by this patch would have triggered earlier. That said, this seems to cause another problem on a rebased patch. I will fix it after some sleep. > > @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS= _OUTPUT_PROTOCOL *gop, UINTN gop > > #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ > > (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) > > =20 > > +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) > > +{ > > + EFI_STATUS status; > > + UINTN info_size =3D 0, map_key, mdesc_size; > > + void *memory_map =3D NULL; > > + UINT32 ver; > > + unsigned int i; > > + > > + for ( ; ; ) { >=20 > I'm sorry, but I'm now going to be picky and _not_ offer correcting > this style violation for you anymore. No apology needed. Is the problem that the brace should be on a separate line, that the spaces around the semicolons should be removed, or both? --=20 Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab --ue0OKNrOXfLQGMxN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmLL35YACgkQsoi1X/+c IsEBiRAAtT3KY8QFZYbNLMlZ11KZ+dGGGc4EFXkoyBo0hozugTH2kbegHvgKBgVX kqSbiOLvBUVCQHnfPpDceMzP7ES3wYAImLIF0E0pOgPOiVTT+bFH1Kl9pZ5rOykE oqTHXikNOJ1GbQOCm+PWmQuaWuNnfUA9nUjYAZOvpT5MJ/5iEQGYYIBxATaggk7x 40/xXsV5oIkGwhXg6rNMF4wLu9mpoQHeQKhe0TR2fRGWpg1tFsF1OEbl15whtMPy tdqLoqpz+l4Yjaf836Z866gMZArDvBfSz23VSQPS8tmlwg+Cb2B0UK7bL5u2rSHk XNL93VHgqJKwiT4CylcBxuItDqx+hGbumcs0J1b/2Jkef5Chgmcd5Y2hGDAXEdSW uxlwGGS6Gdr200ymiM4OpM8zOqPifkQEd7+0MhqRA/6uLkiRnwDPpLX8CYQWryZs 5gxcOMVZ7w5diiqA8i2GFWL/2VGzR7aA2NgEouqtpJWiuOTluXx2XHDmEs0qSxq7 jLoenKddzCASSkn7q0DgFolKT2TOBQkXT6SHhJ5OqddR/HZjDlucfRmZdIM+B2sz zeBj10gblvGmQ3uCzS1OWQj3cxgQbtARoyedQjcSygJsVxjqibKzjDMA8jrxvA4X URc04OLvb89Bi90jCSTN0dING2ENjhOEqd+BFuvN6yT4ePdNZoo= =BhUw -----END PGP SIGNATURE----- --ue0OKNrOXfLQGMxN-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 08:32:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 08:32:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364946.594933 (Exim 4.92) (envelope-from ) id 1oAoq0-0004WY-GF; Mon, 11 Jul 2022 08:32:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364946.594933; Mon, 11 Jul 2022 08:32:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAoq0-0004WR-DG; Mon, 11 Jul 2022 08:32:16 +0000 Received: by outflank-mailman (input) for mailman id 364946; Mon, 11 Jul 2022 08:32:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAopz-0004WL-CT for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 08:32:15 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6d6eafd-00f3-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 10:32:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7222.eurprd04.prod.outlook.com (2603:10a6:10:1af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 08:32:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 08:32:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6d6eafd-00f3-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UjVLt7oYf+ZWIXVWWoP9DfNH3BWvuUat2moYyaQkuAphqktiCGyYNyS/vAFUiJ8Fis5cZ90F7IBFMAKa51VJ6sleF5E62oXqDgy3NY443SRRFG0KJohEd3+sC8sGwxvvLzk1XF4/wgPZ3tRjhekAt54xmLmg26vEYN826MqOyyCWb5HwXWnD2jCdqQmQ7odktP/kN1BMPFqHXr7ultgq05z3Uc+vcgjFB1a/r9jrcGxd8bSrwyCU5nsspRyUrrQsdO+exQbPZT+j8tgMx4pjSI2d4coTicRFCLTyQItrZ5cdxxs324PkiOSkAfkqK3bjUmRfHL1+fAAVM5xDoBRedQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jjrHqJ+4T+EXjrFd2As2FR11kJL8/AyAArI5WMMQFU=; b=agCbFXL7QCDQbdtmeRX8ard8B45M7CtTczjLub6+m7dN424m5X0fN4pFMqNtn/tLD0PSESMTFLP+eWc/bduhymNmb0BZ1FSAs0BaFd7FUBJameENbdrB77E3co28OgVMqQLabTIJlcCtxUmnqHWA+/4A6S9HlCyTj69cHz+MXOvYrb4NFyCq/g7yx+KluPVCZXjrz1wX7La4sd/acMY1RMhqT9L2VFAB1aawtQh3E0PIyqmgUJAm5bOIK+YQGEa4zAjusLgYGiNyLE/y5GryV2WrJwZvG0qOueZuwGCc8oauI8gFc47lHVevPOVjQf5EoBycQ8jgzpx8mSOKVHyLeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jjrHqJ+4T+EXjrFd2As2FR11kJL8/AyAArI5WMMQFU=; b=E2Lhmy5ZmPr08tKo3xa1cmf+P4VvOiO8Q+RlU4/A4QwUApgMT5BdYFquA2B6ylkYVWIGMW7OzQrauLUFs1DoXcdg1bca9pntZNRg9k5a51385NJqTIen1aufGnHoDmMtj6xYhvS7qF7+Ciil5kbTeatq/uhJFoC4pIu+eCCtZ3lx7COSfiGvoiX32CRYzxaRFT++4sZEJeGu4es9gs93G3GS/ehrJVFN8rrK9QizZf+AejRl1PrW0yB2DN0QbVqoZYjIb2v3IIytV7luUpavK9AU6hQ87dHvDI0gAK4nXfQ3en77Wp7jSX+qOccMVNPURlq4xFfEbrsPT9mzf4HKbg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 10:32:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour Cc: Xen development discussion References: <20220708213403.2390-1-demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0030.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bfcd9339-bdc3-4469-4d2c-08da6317da76 X-MS-TrafficTypeDiagnostic: DBAPR04MB7222:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ryGim/kVfQkeSY4ei/vhyjX12/AjiLJNAc/1eJAKqK8/dijXbdSgmRxNPIgAWB/ja6QKnS++iHO6fAsgeGr0BzMYsw8BGx7vpbfJArEvmjQhRMtFaKIfcT5kEjoi05veouDnxkufHy9bj+/cYPnhobNxtgq5jCc6HW7yxmnxfZenifNtITOhaZPD/EMRV6pUopXOnhUt/el4cgPt0/abx7bIoRc52TfkbibMpqpGW1ykljtIL1iuWE6gXrPDWNPO2+vTiZCGHT7kIcnoI8cAgfPgWS/XaPKZ6MfyD3BB/gvNxNL9YR81Cng7HlBHqI8uX5i/1+2yt4xh+G/xv1Ft5eYyMNpFRkfxYTXz8WXMJgx0i7+87r+b/Qt3lwUunWZwUim/Dpf5Mr9YtoqtVMoK+7HlCD+CLLpDOW1giz74otXzrlHJRq6XPe9Digi7IOgujAhSvSoZup9R3zD9z88Wb0XFrf7uWDgcw6HtWuT8I2uZmxh+r3yyvCSdtTfFVHgwIe/Zcc9EbLbGEYd9cNeTUVi5lappV2Blama8XPRZp/FsdkoPHJEeHG/6AIkInXVs7J0iEbCQ5lKvNHKK+kDtOwCzyPoRGrdJqLanHnIQCD/EYdwoPad2PfiawgbE80zk7OMo05Y+/MJfEg4PkkfU8y1Zx5zqS21deTVwSXm+t1aZWmUTut3WcElpZ6O5OUqRAySuksjFuycQllvP/porB2ZHBzV7BvK9G1XeSiH3leRXK2sQVARCk6/b+zDPLzBtOKI1OiMr00zbWnU2HdVBJwjTUhoIB7fY9otsY+FE5Lo6fqA0+N4bu+SME8zruztb29VLgS6YbltLrKFxMFQkN+wPDk7zknI2ikd4qC/3wAo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39850400004)(376002)(136003)(396003)(346002)(366004)(8676002)(66476007)(2616005)(186003)(4326008)(316002)(6486002)(66946007)(66556008)(36756003)(53546011)(6506007)(26005)(6916009)(6512007)(478600001)(41300700001)(86362001)(31696002)(38100700002)(31686004)(2906002)(8936002)(4744005)(83380400001)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QW00TktEb2hudjBoSCtxNTJ6NXVKR3dMTElQelEvQWhleE9sNTFGb25RMXpP?= =?utf-8?B?WUY1amJCUFc1YTlaZmNzYUltMjlTdlJQbk5lWGgrRmlyKzRWSXRMdktYYnRV?= =?utf-8?B?UXhHbGcwQTd1ZmhTZWFTc0RZMmZqbUprWWlpdStXRllUVFN0SDliQ2hWM1lt?= =?utf-8?B?RTg5ZERJNlBIajlxYzRvKzN0QkVsZHRBYm01MzdIQzY5NHhwK24zaWhrbTNm?= =?utf-8?B?bUI5VlYrTjdMUUp6ZnM2VXhxSnNWcHRMbndzcSsvWVRKa3U2RG44dHFabG53?= =?utf-8?B?OHV2eDlGSnptVGl0cFNSdFJ6aGlxdkV2Ui82UEpkZ0ZpZVlDSGZveDV1UUw0?= =?utf-8?B?NEtaMHZFdm42TDdsK2wrK1J5Rkhnc0M1MmZSb2t2aVpDQ3QrMDEyUzQ4VTVY?= =?utf-8?B?bUhOSTlxZkNkZ1o1R3EwYVFZdHBSSjMwMjFtcGNPcGMzaTBaZ2lGNXEzcVF1?= =?utf-8?B?cDZ1SHE4TktnZUFPdEtQSW1jVmpyNm1jZEczOFFSOXRCaUJYekdwSUdKVGpn?= =?utf-8?B?S1daczhLUUI1ZHhqc2lPNkQ1SUc3UjAwQkFzVlpmR3Q5UDhoYW9FcWpQRXMz?= =?utf-8?B?cDdtMzZKTTZSeVkyNi9lU2FWSWNvZDk3a05GQWVKOWNhOG1yRWNjcmFWNHlS?= =?utf-8?B?WEdhR0YwVU1xOFJTc1ZmdWU0dXhUanJIMlJxY2dlMlFKNDhCQitmbk93MU9Z?= =?utf-8?B?NGhuZzRZWDBEbVNiU2R3TDhsOVQ4YWE4VGFyYjA3bHJONldURERadHNzNDl5?= =?utf-8?B?RjduMkE4YnRIWVZ6S0NiQXN5eFZQbGkzRm5TUTJVbHFnQmlnckszUmJVb2Jj?= =?utf-8?B?WVRLY2Z6MFd3YUI5ZzFJMy90NjRTKzVQNDI3KzZnU1YzQjZwQjVrNnM5LzQ2?= =?utf-8?B?WHBzNVdFd2RXNTQ2cmZUTVhNbGF4azNjMjJUenozejhlS2NuemNkVjh1NnU3?= =?utf-8?B?bG9hdXpSVkxBdlZjTTVLTGxPNjhod3lmOFVSVDdrd2p3eTQzZnZ5akZhZjRU?= =?utf-8?B?YjV2bjRiRXFyN2s5eTE2Lzh0SmlxZllyNHRLTERXMU1VR3JNOHlRT2dmUVpi?= =?utf-8?B?ZzhydHFYc0o5MEp4NUcrR1Z6dEFJaVFwU0ZIOHRET3d4WHhTSFJhcncySk90?= =?utf-8?B?cnNXVzNYeDZjYTFrKzRMdkhTSUQxU0I0d3ozOVluMTh1eVhhaklaUno5L1Vz?= =?utf-8?B?NlVHT2F6UDZXa0dIeEFmM0MxeFhzRWRkenBLcFFLcFVUWEZDU1N5bjE0ZytK?= =?utf-8?B?MG5iVUl1WWNhSU1pM3VnTUpsQzJvelFhSDFGdWQrY0REaVBIdE9MUG9RR2pn?= =?utf-8?B?dTRpRm0za0tJU0xMRFhGWDVoSmJYZG1LN2tzQWNleFFBNzAxaVBxUllUUW9G?= =?utf-8?B?dk0yaytBVVY5YVlhUElSZVBjcTdnR3pjNlV6MkFpRFBXUm1SbWh5bGhHcVAv?= =?utf-8?B?YmQ1Q1FZYlFwd2N5UkIxcXpnTHNNQXRPeXhxQjNtS24yU0NBRzFKeVNHeUta?= =?utf-8?B?YTdjN0Z5bDZubnpRMEpmbzBhSVMyaCt4dE5nK2EvQ3hIZGhnV2VzdWZWQmRn?= =?utf-8?B?QkZreTNuSy8xYk8xM2tCcm5NTzN1SUVjWjZvTVlESW91aHoreE5BOUh0eXNR?= =?utf-8?B?UVBpVmRmWUcwbDdLZWpBbFRmeE5PTk55eDNKOGk4SEVpcTZhRUZ2ZkhXTFBi?= =?utf-8?B?OTRyYUswaURBZjJuSE54cWNKTnVFOWdiNHB1RDhJRTlhUjZON1ZHNmo3Vy9a?= =?utf-8?B?KzlrY0RyVE1qcTBhNXJ4UUNBTHB3S2dQa3dLN2M4ZDl2cnpuanhlS08yZ2cz?= =?utf-8?B?cVc2S3pHNzF6dEpYVytFU1pKYnB3eFJwS09oUVBvR1JOZDVLUjl5V3g3SHVO?= =?utf-8?B?dGE1OUZZMC9GWkpzVk05bGFvTlEvUjgzYUNycmVTRnVPWHpEbm1OZWlQUW1a?= =?utf-8?B?M00wZ3QzT21HNXdLMnFLT3RGbU53V2VxTVZ0b1RIWU5iZTlERXpWMWNlb2U0?= =?utf-8?B?VXQ3L09qVzVrTkpZd3hsTW1TREtaOFV5NUxITWpRR2JGNFR4SERIcHdnRWpX?= =?utf-8?B?MGtMT3AxTmxUWExhOGpqbXNMZzlheDhvRlRvK2pHL2dJMHFDbHJuREFvcHIx?= =?utf-8?Q?0fNCQMIYV2xO0b8ngcdKCp09a?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfcd9339-bdc3-4469-4d2c-08da6317da76 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 08:32:12.7867 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /nc31etUeZggnb9zxI+qN8BAO5X/8HPHc+bNhyRA0GmDYOKroc5rhdPhrN+iUlxxNhGf/FoMvO9lbJnf+MQ2vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7222 On 11.07.2022 10:30, Demi Marie Obenour wrote: > On Mon, Jul 11, 2022 at 08:41:59AM +0200, Jan Beulich wrote: >> On 08.07.2022 23:34, Demi Marie Obenour wrote: >>> @@ -1051,6 +1110,70 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop >>> #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ >>> (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) >>> >>> +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) >>> +{ >>> + EFI_STATUS status; >>> + UINTN info_size = 0, map_key, mdesc_size; >>> + void *memory_map = NULL; >>> + UINT32 ver; >>> + unsigned int i; >>> + >>> + for ( ; ; ) { >> >> I'm sorry, but I'm now going to be picky and _not_ offer correcting >> this style violation for you anymore. > > No apology needed. Is the problem that the brace should be on a > separate line, that the spaces around the semicolons should be removed, > or both? The former. Iirc you did actually _add_ the spaces upon my request. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 09:02:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 09:02:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364958.594944 (Exim 4.92) (envelope-from ) id 1oApJA-00089a-Te; Mon, 11 Jul 2022 09:02:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364958.594944; Mon, 11 Jul 2022 09:02:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oApJA-00089T-QX; Mon, 11 Jul 2022 09:02:24 +0000 Received: by outflank-mailman (input) for mailman id 364958; Mon, 11 Jul 2022 09:02:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oApJ9-00089N-Gq for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 09:02:23 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2bd3ea7c-00f8-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 11:02:20 +0200 (CEST) Received: from AS9PR06CA0176.eurprd06.prod.outlook.com (2603:10a6:20b:45c::14) by VI1PR08MB3966.eurprd08.prod.outlook.com (2603:10a6:803:de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Mon, 11 Jul 2022 09:02:17 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45c:cafe::1b) by AS9PR06CA0176.outlook.office365.com (2603:10a6:20b:45c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Mon, 11 Jul 2022 09:02:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 09:02:16 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Mon, 11 Jul 2022 09:02:16 +0000 Received: from c590733b9dcd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DE69C94E-720E-4104-B4AF-9BE0F30BC396.1; Mon, 11 Jul 2022 09:02:10 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c590733b9dcd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 09:02:10 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AS8PR08MB7720.eurprd08.prod.outlook.com (2603:10a6:20b:508::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 09:02:08 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 09:02:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bd3ea7c-00f8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TZc46EYmoMR40NpHzsm0wcU8xwRxgTxdduPwkQnuFDwbxplko/iKzjnaD1obW5pw6U05hEXJizyV7aE76D6PrfZhLa3kkDkML8Y9ax0z7j9WpVTICtFaKRKghNtYRYTXaH4HG2YnrOWV1noo05C7xU8T1JOMqOLWl9rwRo6xpsEpYLNFETQERM0O3XGqig2rpxRvYfXsEKDInnFwCzekLHTxNu050yO01JaAj8EdWwm/jV+JcxJCDfTeVpkb0EXVv77XssbRW79A0CuK4qy+OvCtuzfDPf2QoZFaZcj91XGqNqNyFLuKL4Ui/LAtbwgS0C2903OnjQ77Elsb2ek4jA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oeqjWtr0FEpFvDuYDMmkMOWVYwixDenrNgLSHZAnU2c=; b=ns10hfMfmkIgaPS6rnGIMcbWPmAVEkbtgNfr730RENLbwwBzWkXaoq72tiT0TSGN5dZPpPhU88Vg4wjnjpIYkQoovb+j1Hlzo3WcRlmBkK/bMs2f/+I3zZTjzQJ0Z4a+EkjAjuSFAzpWCoC8KDYo4xiRQoJ/uM4sUiZGXBIkXDWCT9T9hk08LxYoMUBEZAalailuyCKCFa41Sm4Q856eEua/zIkJcDJKf8fe2gDjlLeULi4CM9f/Fzgw/PzCgmqP5pkMlq+7xyFl/KBDwBotuA8waa3rSyH0FRznkeF8Wv+lbKPbNQBsVMzszwSC3OsRiACfzQAH+pyiTKXMw/wLkw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oeqjWtr0FEpFvDuYDMmkMOWVYwixDenrNgLSHZAnU2c=; b=F3rCnhfcr5UV87brenlf6hYK8WmoXVJ1Fa/PFqb6Hs6bR+wUXakRQQsR/tOD01dE/uKTXhCBrO/yOPIUNEpeqy9lGEbSyEYIR3yxjyN3c74w5KgSUov9ziMr/XTGnJwXLpKEqgItWxU3sSvq8mgcMj0eRCjxWImniaAjhLtTfYE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ELdjkkwQaFpRNywGzNK6bLRH3x1XWBGFuAp7Fnf2XC8qqcvm0B9/Xfk2PXUyzne4DHxb0nDLMb5JcxjHmKOUlMpJzz4D4mC6WFFjCmizkZZIurWqYhHkPXOfUh96UpOfdi7qMRigopSn7XM+KQsadHKwaBi6sDdtiW2bVg9yCe/d8D6ajlG5kgTOY5K1Hht9MzHtqX55zoMEfzoBNtmePW9y13/DXjIkr9bb6S40o/bZqQptzv4g6wVwHbjtEYholFYEs1F5nBI3fdOya8xPkYJcoofbYxCWF/+ip7TkA2Ufch67rsAaXfsScqnyZ8m0xQcQPyBaydBeOfdy6ghkLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oeqjWtr0FEpFvDuYDMmkMOWVYwixDenrNgLSHZAnU2c=; b=U7RRyhbSGxvBxtcuigdOmgJktO5FEzVbyLDTiFu9oRRnQDayfxkz1+GkgQ8/OIy0g7G6dbqChtMqJcPdN9XUULSMMGFnGbT25whIqLEON9VjFxYIQ10vjI9XeobCmt+ui4TLkDx6AbkDPrT9czxO5PAm7tKTZiNRgQmbw+VPjVsCn3Sust2gw1xlcYgkgRKYyqk3LAEGioczb1ZVCBHVf69nfxVwnuxP8xYnFoQsiflOjIS0lJXBRv/2LbH83Ds2rJzpvkmuj59KD5SiR5/plFqIdB0S+8BwnKVGdvmeR/Y+m/hR+JCQA/LqBZ8Ab2PlKerRRpHnzY0WWVyhQx4CMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oeqjWtr0FEpFvDuYDMmkMOWVYwixDenrNgLSHZAnU2c=; b=F3rCnhfcr5UV87brenlf6hYK8WmoXVJ1Fa/PFqb6Hs6bR+wUXakRQQsR/tOD01dE/uKTXhCBrO/yOPIUNEpeqy9lGEbSyEYIR3yxjyN3c74w5KgSUov9ziMr/XTGnJwXLpKEqgItWxU3sSvq8mgcMj0eRCjxWImniaAjhLtTfYE= From: Penny Zheng To: Xenia Ragiadakou , Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: RE: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Topic: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Index: AQHYkrCrc+1tnxXJvUu1rbw6AP/wja142SUQ Date: Mon, 11 Jul 2022 09:02:08 +0000 Message-ID: References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AAAAB21DA456AE4FBFBF11BFDB75888A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: cd1d806b-6507-46b3-b788-08da631c0db6 x-ms-traffictypediagnostic: AS8PR08MB7720:EE_|VE1EUR03FT064:EE_|VI1PR08MB3966:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?ZG1LazNrRVJrYTJ6L0I4Zml0NDJicVhDbm5HRjJKT3pnUUpPOHBGU01RNk0r?= =?utf-8?B?YXZsVHhCRSsyNzRyU21VaDN2NDhYK3g4eCthUXQyTStrMUpBYkM3WjRBMkdO?= =?utf-8?B?d3l0dG00SExjNGt6eUhGLzJSM2V1dW9WMnRMNDhmNG5yODgwbU0rb2ZtTWtj?= =?utf-8?B?Y3J2Rm93TmczNysyYWdOSFpVcFZUNDNmYXZKTHBGZmcvNjkyN1o2cW5hb2tr?= =?utf-8?B?M0FBUnplN1VqQlZrZUQ4MkhPZW5sT0ZQa0FaS1grSXJHMy85UXhzOXEwTXd4?= =?utf-8?B?NHBoU3RCMk1uVWhjcTZvNWROdzhZWHNBM1NCQkFlOTdDMXlSMDllMUV4bnlq?= =?utf-8?B?NmdKRklBQ2R5R3k2TjFZb2RWN3VRVW1wZ1I3OFg2SlhEbTBiWitvM2ZEWUNy?= =?utf-8?B?aUdpNWM5cHRaMTB0KzNIOC81aTl2cHNSdzVaajd4R3AxeEpIU3JEMklBVjdQ?= =?utf-8?B?RC9IUmJVT20zT0xuRWFQRUtuV2FEbkdSSGwyYi9Fc1VIbHBQRlA2WTVKZ0Ft?= =?utf-8?B?emZpSm1YTWhxTE5zdXZzeUc3a1NqQStUUyt5Q1dOcVZKNHErclp4T25ZMmVN?= =?utf-8?B?SHR5YlNRL004WmljNkV2SzJaMmg0aS9aK2JnM1J1Zk9XV2JOOEpMZjJRZFB6?= =?utf-8?B?a3c4bFVNM3R2VURQcTk2UnJQZnpiR2JEZ1dEc3IrZldpYjNRcDBGdWU2OXl2?= =?utf-8?B?d04wMXNFME5pMUcvblBLcHRwejRwWWtUbkI5VWtvY1VtVnNIbHc1UndYL0R2?= =?utf-8?B?Z01pVTdjZGlDN0M5STRsTEp2UU5ZZmpNSmNuRlhVNWRpaTBYV2E1NDk5MUtF?= =?utf-8?B?UlhBZzFLSkhLRk82WW9STVljaFh2dkdkK3pGWWVqL3ZIeTdUazFQWkgrUFFx?= =?utf-8?B?MGxqaUZETDk4UEZyeElNVHh3SkF3U1dBa2Y2UDBmam51V2cvLy9ma3pQbml0?= =?utf-8?B?ZDRRelVmVXFSSURUYTZkMkZmSG9YTUM0SldKbkx0amE0TXVXeDNPSXpnd1Bp?= =?utf-8?B?MFB5OGVwdzgrMCtWdFA3MC9JaU5WeFMvNHd6dklaK3Q2UnIzQUhjcVJxenJk?= =?utf-8?B?TFI4ZVZZNjlncXFZSU9DVmJEV3llNkRjQ3EvWUxOSm1zcHJtaSt1cm9hSXdw?= =?utf-8?B?TFo0bjRpZWliMWM2blBRaDU4SjZUQU1RTXB0OXBDYXp0NjlJcmx0ZGJuSmNT?= =?utf-8?B?cm9JSmd2YU9maVBmTEE5eldZZm5Dc2p6Y3dHdjBFS2o1a09xVm9zNnNOTWhw?= =?utf-8?Q?ypbX6hALAhRx+Aj?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(122000001)(33656002)(86362001)(38070700005)(9686003)(53546011)(7696005)(26005)(186003)(38100700002)(966005)(83380400001)(66476007)(64756008)(8676002)(66556008)(110136005)(54906003)(66946007)(4326008)(66446008)(41300700001)(76116006)(71200400001)(8936002)(2906002)(6506007)(316002)(5660300002)(52536014)(55016003)(478600001)(21314003)(139555002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7720 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 93f794f6-3d75-473b-57b3-08da631c08b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WqQJ9GdzTT90xTIfnvIkQbgv2u4USjUy/1aOEC/n89pxBQl6y12FDl65roMm3ba08O/7+nKzlOJiKvwW8wiKE39EW19l4DVImqJjIBSkNp7dd+bmCOzUulUdnACvowXJGjgJq0CHKAfW8XGZT+rc44K75H73A90txbLSZCzy8WtpzlODZ5hYTOs5U8ddfJJg1mU7Cb4RCE+J/xOoo/908deMMrgzz/zWEp8qvkA614PxOm6LzyvSrIJqE6SmmyCDgtw27n18i6rvQC8IETxVgNR9noei1DeE7cXBfzVW0OddTIa7xBUIJNyFwTTOCzX3Ro3w3vo6aJFm2Q9Q5Zx2ucI8T2UrqTt/moa51M+cE+JqxwvKpEs3YLlpwrpIfAetaVdVaDhOSDGuZP92KAxXcmTmxYQZNmGVwirdpx//Fq9QUOSCr/zFvknrYedvRPtT0iur0oPX7hZ6UZLzqW+Pr58A2smzWFUNs7TeWHE4/qbcCdkdW2e2qgjCPg9aHrLe6CUU5cEuTnSEdmslg65b/yGeacGOv5fnYub6pCe27S3gQr61iojb+Pg+D2Jii/vqUyXScgYmfXBdcIPfkq0dfYodar9oCGC0FFhGlKf0G1sdLK6+TiwJIymNRLINYqbVSN7AIx11WB/4wAl9Vxbx89shIJoLjz47/G3PDYdYyQORu9uL93Rym7Ic4PLmvQm3eP9nJi/4V6Lh2oFrjWjUQtxq4zoLiT+gLZIGdfefWj1fbrKTEB8nZMd6oPG1KN+noOCGc2CF+6OP6Rgza97tbcSWzCBvyDzIR/ymRiMiCkRLIXWJBXFAYOd67pqrkIB8OzUbXY9DkoOJ5rXO2KL+GsrAqIXJ0ZxD2wdb7sKj4RMwKzMccAo5Fiqjkbwj/PpSecG08KKc7mgZOgKnI34ZjJZanAJa5jKuAuasKjCnQwg17YH/dmE2MRnryA0G0Sm2 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39850400004)(36840700001)(40470700004)(46966006)(70206006)(5660300002)(8676002)(70586007)(55016003)(47076005)(336012)(82310400005)(186003)(4326008)(33656002)(54906003)(110136005)(40460700003)(966005)(8936002)(478600001)(86362001)(52536014)(81166007)(53546011)(356005)(6506007)(26005)(2906002)(7696005)(316002)(41300700001)(82740400003)(9686003)(40480700001)(107886003)(36860700001)(83380400001)(21314003)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 09:02:16.5241 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cd1d806b-6507-46b3-b788-08da631c0db6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3966 SGkgWGVuaWENCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYZW4tZGV2 ZWwgPHhlbi1kZXZlbC1ib3VuY2VzQGxpc3RzLnhlbnByb2plY3Qub3JnPiBPbiBCZWhhbGYgT2YN Cj4gWGVuaWEgUmFnaWFkYWtvdQ0KPiBTZW50OiBGcmlkYXksIEp1bHkgOCwgMjAyMiA1OjU0IFBN DQo+IFRvOiBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxp ZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2pl Y3Qub3JnOyBEb3VnIEdvbGRzdGVpbiA8Y2FyZG9lQGNhcmRvZS5jb20+DQo+IFN1YmplY3Q6IFJl OiBbUEFUQ0ggMi8yXSBhdXRvbWF0aW9uOiBhcm02NDogQ3JlYXRlIGEgdGVzdCBqb2IgZm9yIHRl c3RpbmcNCj4gc3RhdGljIGFsbG9jYXRpb24gb24gcWVtdQ0KPiANCj4gSGkgU3RlZmFubywNCj4g DQo+IE9uIDcvOC8yMiAwMjowNSwgU3RlZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiA+IE9uIFRo dSwgNyBKdWwgMjAyMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiA+PiBIaSBYZW5pYSwNCj4gPj4N Cj4gPj4gT24gMDcvMDcvMjAyMiAyMTozOCwgWGVuaWEgUmFnaWFkYWtvdSB3cm90ZToNCj4gPj4+ IEFkZCBhbiBhcm0gc3ViZGlyZWN0b3J5IHVuZGVyIGF1dG9tYXRpb24vY29uZmlncyBmb3IgdGhl IGFybQ0KPiA+Pj4gc3BlY2lmaWMgY29uZmlncyBhbmQgYWRkIGEgY29uZmlnIHRoYXQgZW5hYmxl cyBzdGF0aWMgYWxsb2NhdGlvbi4NCj4gPj4+DQo+ID4+PiBNb2RpZnkgdGhlIGJ1aWxkIHNjcmlw dCB0byBzZWFyY2ggZm9yIGNvbmZpZ3MgYWxzbyBpbiB0aGlzDQo+ID4+PiBzdWJkaXJlY3Rvcnkg YW5kIHRvIGtlZXAgdGhlIGdlbmVyYXRlZCB4ZW4gYmluYXJ5LCBzdWZmaXhlZCB3aXRoIHRoZQ0K PiA+Pj4gY29uZmlnIGZpbGUgbmFtZSwgYXMgYXJ0aWZhY3QuDQo+ID4+Pg0KPiA+Pj4gQ3JlYXRl IGEgdGVzdCBqb2IgdGhhdA0KPiA+Pj4gLSBib290cyB4ZW4gb24gcWVtdSB3aXRoIGEgc2luZ2xl IGRpcmVjdCBtYXBwZWQgZG9tMGxlc3MgZ3Vlc3QNCj4gPj4+IGNvbmZpZ3VyZWQgd2l0aCBzdGF0 aWNhbGx5IGFsbG9jYXRlZCBtZW1vcnkNCg0KQWx0aG91Z2ggeW91IHNhaWQgYm9vdGluZyBhIHNp bmdsZSBkaXJlY3QgbWFwcGVkIGRvbTBsZXNzIGd1ZXN0DQpjb25maWd1cmVkIHdpdGggc3RhdGlj YWxseSBhbGxvY2F0ZWQgbWVtb3J5IGhlcmUsIGxhdGVyIGluIGNvZGUsIHlvdSBhcmUNCm9ubHkg ZW5hYmxpbmcgc3RhdGljYWxseSBhbGxvY2F0ZWQgbWVtb3J5IGluIHRoZSBJbWFnZUJ1aWxkZXIg c2NyaXB0LA0KbWlzc2luZyB0aGUgZGlyZWN0LW1hcCBwcm9wZXJ0eS4NCiANCj4gPj4+IC0gdmVy aWZpZXMgdGhhdCB0aGUgbWVtb3J5IHJhbmdlcyByZXBvcnRlZCBpbiB0aGUgZ3Vlc3QncyBsb2dz IGFyZQ0KPiA+Pj4gdGhlIHNhbWUgd2l0aCB0aGUgcHJvdmlkZWQgc3RhdGljIG1lbW9yeSByZWdp b25zDQo+ID4+Pg0KPiA+Pj4gRm9yIGd1ZXN0IGtlcm5lbCwgdXNlIHRoZSA1LjkuOSBrZXJuZWwg ZnJvbSB0aGUgdGVzdHMtYXJ0aWZhY3RzIGNvbnRhaW5lcnMuDQo+ID4+PiBVc2UgYnVzeWJveC1z dGF0aWMgcGFja2FnZSwgdG8gY3JlYXRlIHRoZSBndWVzdCByYW1kaXNrLg0KPiA+Pj4gVG8gZ2Vu ZXJhdGUgdGhlIHUtYm9vdCBzY3JpcHQsIHVzZSBJbWFnZUJ1aWxkZXIuDQo+ID4+PiBVc2UgdGhl IHFlbXUgZnJvbSB0aGUgdGVzdHMtYXJ0aWZhY3RzIGNvbnRhaW5lcnMuDQo+ID4+Pg0KPiA+Pj4g U2lnbmVkLW9mZi1ieTogWGVuaWEgUmFnaWFkYWtvdSA8YnVyemFsb2Rvd2FAZ21haWwuY29tPg0K PiA+Pj4gLS0tDQo+ID4+PiAgICBhdXRvbWF0aW9uL2NvbmZpZ3MvYXJtL3N0YXRpY19tZW0gICAg ICAgICAgfCAgIDMgKw0KPiA+Pj4gICAgYXV0b21hdGlvbi9naXRsYWItY2kvdGVzdC55YW1sICAg ICAgICAgICAgIHwgIDI0ICsrKysrDQo+ID4+PiAgICBhdXRvbWF0aW9uL3NjcmlwdHMvYnVpbGQg ICAgICAgICAgICAgICAgICAgfCAgIDQgKw0KPiA+Pj4gICAgYXV0b21hdGlvbi9zY3JpcHRzL3Fl bXUtc3RhdGljbWVtLWFybTY0LnNoIHwgMTE0DQo+ICsrKysrKysrKysrKysrKysrKysrKw0KPiA+ Pj4gICAgNCBmaWxlcyBjaGFuZ2VkLCAxNDUgaW5zZXJ0aW9ucygrKQ0KPiA+Pj4gICAgY3JlYXRl IG1vZGUgMTAwNjQ0IGF1dG9tYXRpb24vY29uZmlncy9hcm0vc3RhdGljX21lbQ0KPiA+Pj4gICAg Y3JlYXRlIG1vZGUgMTAwNzU1IGF1dG9tYXRpb24vc2NyaXB0cy9xZW11LXN0YXRpY21lbS1hcm02 NC5zaA0KPiA+Pj4NCj4gPj4+IGRpZmYgLS1naXQgYS9hdXRvbWF0aW9uL2NvbmZpZ3MvYXJtL3N0 YXRpY19tZW0NCj4gPj4+IGIvYXV0b21hdGlvbi9jb25maWdzL2FybS9zdGF0aWNfbWVtDQo+ID4+ PiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+Pj4gaW5kZXggMDAwMDAwMDAwMC4uODQ2NzVkZGY0 ZQ0KPiA+Pj4gLS0tIC9kZXYvbnVsbA0KPiA+Pj4gKysrIGIvYXV0b21hdGlvbi9jb25maWdzL2Fy bS9zdGF0aWNfbWVtDQo+ID4+PiBAQCAtMCwwICsxLDMgQEANCj4gPj4+ICtDT05GSUdfRVhQRVJU PXkNCj4gPj4+ICtDT05GSUdfVU5TVVBQT1JURUQ9eQ0KPiA+Pj4gK0NPTkZJR19TVEFUSUNfTUVN T1JZPXkNCj4gPj4+IFwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQ0KPiA+Pg0KPiA+PiBBbnkg cGFydGljdWxhciByZWFzb24gdG8gYnVpbGQgYSBuZXcgWGVuIHJhdGhlciBlbmFibGUNCj4gPj4g Q09ORklHX1NUQVRJQ19NRU1PUlkgaW4gdGhlIGV4aXN0aW5nIGJ1aWxkPw0KPiA+Pg0KPiA+Pj4g ZGlmZiAtLWdpdCBhL2F1dG9tYXRpb24vc2NyaXB0cy9idWlsZCBiL2F1dG9tYXRpb24vc2NyaXB0 cy9idWlsZA0KPiA+Pj4gaW5kZXggMjFiM2JjNTdjOC4uOWM2MTk2ZDliZCAxMDA3NTUNCj4gPj4+ IC0tLSBhL2F1dG9tYXRpb24vc2NyaXB0cy9idWlsZA0KPiA+Pj4gKysrIGIvYXV0b21hdGlvbi9z Y3JpcHRzL2J1aWxkDQo+ID4+PiBAQCAtODMsNiArODMsNyBAQCBmaQ0KPiA+Pj4gICAgIyBCdWls ZCBhbGwgdGhlIGNvbmZpZ3Mgd2UgY2FyZSBhYm91dA0KPiA+Pj4gICAgY2FzZSAke1hFTl9UQVJH RVRfQVJDSH0gaW4NCj4gPj4+ICAgICAgICB4ODZfNjQpIGFyY2g9eDg2IDs7DQo+ID4+PiArICAg IGFybTY0KSBhcmNoPWFybSA7Ow0KPiA+Pj4gICAgICAgICopIGV4aXQgMCA7Ow0KPiA+Pj4gICAg ZXNhYw0KPiA+Pj4gICAgQEAgLTkzLDQgKzk0LDcgQEAgZm9yIGNmZyBpbiBgbHMgJHtjZmdfZGly fWA7IGRvDQo+ID4+PiAgICAgICAgcm0gLWYgeGVuLy5jb25maWcNCj4gPj4+ICAgICAgICBtYWtl IC1DIHhlbiBLQlVJTERfREVGQ09ORklHPS4uLy4uLy4uLy4uLyR7Y2ZnX2Rpcn0vJHtjZmd9IGRl ZmNvbmZpZw0KPiA+Pj4gICAgICAgIG1ha2UgLWokKG5wcm9jKSAtQyB4ZW4NCj4gPj4+ICsgICAg aWYgW1sgJHthcmNofSA9PSAiYXJtIiBdXTsgdGhlbg0KPiA+Pj4gKyAgICAgICAgY3AgeGVuL3hl biBiaW5hcmllcy94ZW4tJHtjZmd9DQo+ID4+PiArICAgIGZpDQo+ID4+DQo+ID4+IFRoaXMgZmVl bHMgYSBiaXQgb2YgYSBoYWNrIHRvIGJlIGFybSBvbmx5LiBDYW4geW91IGV4cGxhaW4gd2h5IHRo aXMNCj4gPj4gaXMgbm90IGVuYWJsZWQgZm9yIHg4NiAob3RoZXIgdGhhbiB0aGlzIGlzIG5vdCB5 ZXQgdXNlZCk/DQo+ID4+DQo+ID4+PiAgICBkb25lDQo+ID4+PiBkaWZmIC0tZ2l0IGEvYXV0b21h dGlvbi9zY3JpcHRzL3FlbXUtc3RhdGljbWVtLWFybTY0LnNoDQo+ID4+PiBiL2F1dG9tYXRpb24v c2NyaXB0cy9xZW11LXN0YXRpY21lbS1hcm02NC5zaA0KPiA+Pj4gbmV3IGZpbGUgbW9kZSAxMDA3 NTUNCj4gPj4+IGluZGV4IDAwMDAwMDAwMDAuLjViODlhMTUxYWENCj4gPj4+IC0tLSAvZGV2L251 bGwNCj4gPj4+ICsrKyBiL2F1dG9tYXRpb24vc2NyaXB0cy9xZW11LXN0YXRpY21lbS1hcm02NC5z aA0KPiA+Pj4gQEAgLTAsMCArMSwxMTQgQEANCj4gPj4+ICsjIS9iaW4vYmFzaA0KPiA+Pj4gKw0K PiA+Pj4gK2Jhc2U9KDB4NTAwMDAwMDAgMHgxMDAwMDAwMDApDQo+ID4+PiArc2l6ZT0oMHgxMDAw MDAwMCAweDEwMDAwMDAwKQ0KPiA+Pg0KPiA+PiAgRnJvbSB0aGUgbmFtZSwgaXQgaXMgbm90IGNs ZWFyIHdoYXQgdGhlIGJhc2UgYW5kIHNpemUgcmVmZXJzIHRvby4NCj4gPj4gTG9va2luZyBhIGJp dCBiZWxvdywgaXQgc2VlbXMgdG8gYmUgcmVmZXJyaW5nIHRvIHRoZSBkb21haW4gbWVtb3J5Lg0K PiA+PiBJZiBzbywgSSB3b3VsZCBzdWdnZXN0IHRvIGNvbW1lbnQgYW5kIHJlbmFtZSB0byAiZG9t dV97YmFzZSwgc2l6ZX0iLg0KPiA+Pg0KPiA+Pj4gKw0KPiA+Pj4gK3NldCAtZXgNCj4gPj4+ICsN Cj4gPj4+ICthcHQtZ2V0IC1xeSB1cGRhdGUNCj4gPj4+ICthcHQtZ2V0IC1xeSBpbnN0YWxsIC0t bm8taW5zdGFsbC1yZWNvbW1lbmRzIHUtYm9vdC1xZW11IFwNCj4gPj4+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHUtYm9vdC10b29scyBcDQo+ID4+PiArICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZpY2UtdHJlZS1jb21w aWxlciBcDQo+ID4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjcGlvIFwNCj4gPj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGN1cmwgXA0KPiA+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgYnVzeWJveC1zdGF0aWMNCj4gPj4+ICsNCj4gPj4+ICsjIERvbVUgQnVzeWJveA0KPiA+ Pj4gK2NkIGJpbmFyaWVzDQo+ID4+PiArbWtkaXIgLXAgaW5pdHJkDQo+ID4+PiArbWtkaXIgLXAg aW5pdHJkL2Jpbg0KPiA+Pj4gK21rZGlyIC1wIGluaXRyZC9zYmluDQo+ID4+PiArbWtkaXIgLXAg aW5pdHJkL2V0Yw0KPiA+Pj4gK21rZGlyIC1wIGluaXRyZC9kZXYNCj4gPj4+ICtta2RpciAtcCBp bml0cmQvcHJvYw0KPiA+Pj4gK21rZGlyIC1wIGluaXRyZC9zeXMNCj4gPj4+ICtta2RpciAtcCBp bml0cmQvbGliDQo+ID4+PiArbWtkaXIgLXAgaW5pdHJkL3Zhcg0KPiA+Pj4gK21rZGlyIC1wIGlu aXRyZC9tbnQNCj4gPj4+ICtjcCAvYmluL2J1c3lib3ggaW5pdHJkL2Jpbi9idXN5Ym94DQo+ID4+ PiAraW5pdHJkL2Jpbi9idXN5Ym94IC0taW5zdGFsbCBpbml0cmQvYmluIGVjaG8gIiMhL2Jpbi9z aA0KPiA+Pj4gKw0KPiA+Pj4gK21vdW50IC10IHByb2MgcHJvYyAvcHJvYw0KPiA+Pj4gK21vdW50 IC10IHN5c2ZzIHN5c2ZzIC9zeXMNCj4gPj4+ICttb3VudCAtdCBkZXZ0bXBmcyBkZXZ0bXBmcyAv ZGV2DQo+ID4+PiArL2Jpbi9zaCIgPiBpbml0cmQvaW5pdA0KPiA+Pj4gK2NobW9kICt4IGluaXRy ZC9pbml0DQo+ID4+PiArY2QgaW5pdHJkDQo+ID4+PiArZmluZCAuIHwgY3BpbyAtLWNyZWF0ZSAt LWZvcm1hdD0nbmV3YycgfCBnemlwID4gLi4vaW5pdHJkLmNwaW8uZ3oNCj4gPj4+ICtjZCAuLi8u Lg0KPiA+Pj4gKw0KPiA+Pj4gKyMgWFhYIFFFTVUgbG9va3MgZm9yICJlZmktdmlydGlvLnJvbSIg ZXZlbiBpZiBpdCBpcyB1bm5lZWRlZCBjdXJsDQo+ID4+PiArLWZzU0xPDQo+ID4+PiAraHR0cHM6 Ly9naXRodWIuY29tL3FlbXUvcWVtdS9yYXcvdjUuMi4wL3BjLWJpb3MvZWZpLXZpcnRpby5yb20N Cj4gPj4+ICsNCj4gPj4+ICsuL2JpbmFyaWVzL3FlbXUtc3lzdGVtLWFhcmNoNjQgLW5vZ3JhcGhp YyBcDQo+ID4+PiArICAgIC1NIHZpcnR1YWxpemF0aW9uPXRydWUgXA0KPiA+Pj4gKyAgICAtTSB2 aXJ0IFwNCj4gPj4+ICsgICAgLU0gdmlydCxnaWMtdmVyc2lvbj0yIFwNCj4gPj4+ICsgICAgLWNw dSBjb3J0ZXgtYTU3IFwNCj4gPj4+ICsgICAgLXNtcCAyIFwNCj4gPj4+ICsgICAgLW0gOEcgXA0K PiA+Pj4gKyAgICAtTSBkdW1wZHRiPWJpbmFyaWVzL3ZpcnQtZ2ljdjIuZHRiDQo+ID4+PiArDQo+ ID4+PiArI2R0YyAtSSBkdGIgLU8gZHRzIGJpbmFyaWVzL3ZpcnQtZ2ljdjIuZHRiID4NCj4gPj4+ ICtiaW5hcmllcy92aXJ0LWdpY3YyLmR0cw0KPiA+Pj4gKw0KPiA+Pj4gKyMgSW1hZ2VCdWlsZGVy DQo+ID4+PiArcm0gLXJmIGltYWdlYnVpbGRlcg0KPiA+Pj4gK2dpdCBjbG9uZSBodHRwczovL2dp dGxhYi5jb20vVmlyeWFPUy9pbWFnZWJ1aWxkZXINCj4gPj4+ICsNCj4gPj4+ICtlY2hvICJNRU1P UllfU1RBUlQ9XCIweDQwMDAwMDAwXCINCj4gPj4+ICtNRU1PUllfRU5EPVwiMHgwMjAwMDAwMDAw XCINCj4gPj4+ICsNCj4gPj4+ICtERVZJQ0VfVFJFRT1cInZpcnQtZ2ljdjIuZHRiXCINCj4gPj4+ ICsNCj4gPj4+ICtYRU49XCJ4ZW4tc3RhdGljX21lbVwiDQo+ID4+PiArWEVOX0NNRD1cImNvbnNv bGU9ZHR1YXJ0IGVhcmx5cHJpbnRrIHhzbT1kdW1teVwiDQo+ID4+DQo+ID4+IEFGQUlLLCBlYXJs eXByaW50ayBpcyBub3QgYW4gb3B0aW9uIGZvciBYZW4gb24gQXJtIChhdCBsZWFzdCkuIEl0IGlz DQo+ID4+IGFsc28gbm90IGNsZWFyIHdoeSB5b3UgbmVlZCB0byBwYXNzIHhzbT1kdW1teS4NCj4g Pj4NCj4gPj4+ICsNCj4gPj4+ICtOVU1fRE9NVVM9MQ0KPiA+Pj4gK0RPTVVfTUVNWzBdPTUxMg0K PiA+Pj4gK0RPTVVfVkNQVVNbMF09MQ0KPiA+Pj4gK0RPTVVfS0VSTkVMWzBdPVwiSW1hZ2VcIg0K PiA+Pj4gK0RPTVVfUkFNRElTS1swXT1cImluaXRyZC5jcGlvLmd6XCINCj4gPj4+ICtET01VX0NN RFswXT1cImVhcmx5cHJpbnRrIGNvbnNvbGU9dHR5QU1BMFwiDQo+ID4+PiArRE9NVV9TVEFUSUNf TUVNWzBdPVwiJHtiYXNlWzBdfSAke3NpemVbMF19ICR7YmFzZVsxXX0gJHtzaXplWzFdfVwiDQo+ ID4+PiArDQoNCllvdSB3b3VsZCBsaWtlIHRvIGFkZCAgRE9NVV9ESVJFQ1RfTUFQWzBdID0gMSB0 byBlbmFibGUgZGlyZWN0LW1hcC4NCg0KPiA+Pj4gK1VCT09UX1NPVVJDRT1cImJvb3Quc291cmNl XCINCj4gPj4+ICtVQk9PVF9TQ1JJUFQ9XCJib290LnNjclwiIiA+IGJpbmFyaWVzL2ltYWdlYnVp bGRlcl9jb25maWcNCj4gPj4+ICsNCj4gPj4+ICtiYXNoIGltYWdlYnVpbGRlci9zY3JpcHRzL3Vi b290LXNjcmlwdC1nZW4gLXQgdGZ0cCAtZCBiaW5hcmllcy8gLWMNCj4gPj4+IGJpbmFyaWVzL2lt YWdlYnVpbGRlcl9jb25maWcNCj4gPj4+ICsNCj4gPj4+ICsjIFJ1biB0aGUgdGVzdA0KPiA+Pj4g K3JtIC1mIHFlbXUtc3RhdGljbWVtLnNlcmlhbA0KPiA+Pj4gK3NldCArZQ0KPiA+Pj4gK2VjaG8g IiAgdmlydGlvIHNjYW47IGRoY3A7IHRmdHBiIDB4NDAwMDAwMDAgYm9vdC5zY3I7IHNvdXJjZQ0K PiA+Pj4gKzB4NDAwMDAwMDAifCBcIHRpbWVvdXQgLWsgMSA2MCAuL2JpbmFyaWVzL3FlbXUtc3lz dGVtLWFhcmNoNjQgLQ0KPiBub2dyYXBoaWMgXA0KPiA+Pj4gKyAgICAtTSB2aXJ0dWFsaXphdGlv bj10cnVlIFwNCj4gPj4+ICsgICAgLU0gdmlydCBcDQo+ID4+PiArICAgIC1NIHZpcnQsZ2ljLXZl cnNpb249MiBcDQo+ID4+PiArICAgIC1jcHUgY29ydGV4LWE1NyBcDQo+ID4+PiArICAgIC1zbXAg MiBcDQo+ID4+PiArICAgIC1tIDhHIFwNCj4gPj4+ICsgICAgLW5vLXJlYm9vdCBcDQo+ID4+PiAr ICAgIC1kZXZpY2UgdmlydGlvLW5ldC1wY2ksbmV0ZGV2PXZuZXQwIC1uZXRkZXYNCj4gPj4+ICt1 c2VyLGlkPXZuZXQwLHRmdHA9YmluYXJpZXMNCj4gPj4+IFwNCj4gPj4+ICsgICAgLWJpb3MgL3Vz ci9saWIvdS1ib290L3FlbXVfYXJtNjQvdS1ib290LmJpbiBcDQo+ID4+PiArICAgIC1kdGIgLi9i aW5hcmllcy92aXJ0LWdpY3YyLmR0YiBcDQo+ID4+PiArICAgIHwmIHRlZSBxZW11LXN0YXRpY21l bS5zZXJpYWwNCj4gPj4+ICsNCj4gPj4+ICtzZXQgLWUNCj4gPj4NCj4gPj4gQSBsb3Qgb2YgdGhl IGNvZGUgYWJvdmUgaXMgZHVwbGljYXRlZCBmcm9tIHFlbXUtc21va2UtYXJtNjQuc2guIEkNCj4g Pj4gdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIGNvbnNvbGlkYXRlIGluIGEgc2luZ2xlIHNj cmlwdC4gTG9va2luZw0KPiA+PiBicmllZmx5IHRocm91Z2h0IHRoZSBleGlzdGluZyBzY3JpcHRz LCBpdCBsb29rcyBsaWtlIGl0IGlzIHBvc3NpYmxlDQo+ID4+IHRvIHBhc3MgYXJndW1lbnRzIChz ZWUgcWVtdS1zbW9rZS14ODYtNjQuc2gpLg0KPiA+DQo+ID4gT25lIGlkZWEgd291bGQgYmUgdG8g bWFrZSB0aGUgc2NyaXB0IGNvbW1vbiBhbmQgInNvdXJjZSIgYSBzZWNvbmQNCj4gPiBzY3JpcHQg b3IgY29uZmlnIGZpbGUgd2l0aCBqdXN0IHRoZSBJbWFnZUJ1aWxkZXIgY29uZmlndXJhdGlvbiBi ZWNhdXNlDQo+ID4gaXQgbG9va3MgbGlrZSBpdCBpcyB0aGUgb25seSB0aGluZyBkaWZmZXJlbnQu DQo+ID4NCj4gPg0KPiA+Pj4gKw0KPiA+Pj4gKyhncmVwIC1xICJYZW4gZG9tMGxlc3MgbW9kZSBk ZXRlY3RlZCIgcWVtdS1zdGF0aWNtZW0uc2VyaWFsKSB8fA0KPiA+Pj4gK2V4aXQgMQ0KPiA+Pj4g Kw0KPiA+Pj4gK2ZvciAoKGk9MDsgaTwkeyNiYXNlW0BdfTsgaSsrKSkNCj4gPj4+ICtkbw0KPiA+ Pj4gKyAgICBzdGFydD0iJChwcmludGYgIjB4JTAxNngiICR7YmFzZVskaV19KSINCj4gPj4+ICsg ICAgZW5kPSIkKHByaW50ZiAiMHglMDE2eCIgJCgoJHtiYXNlWyRpXX0gKyAke3NpemVbJGldfSAt IDEpKSkiDQo+ID4+PiArICAgIGdyZXAgLXEgIm5vZGUgICAwOiBcW21lbSAke3N0YXJ0fS0ke2Vu ZH1cXSIgcWVtdS1zdGF0aWNtZW0uc2VyaWFsDQo+ID4+PiArICAgIGlmIHRlc3QgJD8gLWVxIDEN Cj4gPj4+ICsgICAgdGhlbg0KPiA+Pj4gKyAgICAgICAgZXhpdCAxDQo+ID4+PiArICAgIGZpDQo+ ID4+PiArZG9uZQ0KPiA+Pg0KPiA+PiBQbGVhc2UgYWRkIGEgY29tbWVudCBvbiB0b3AgdG8gZXhw bGFpbiB3aGF0IHRoaXMgaXMgbWVhbnQgdG8gZG8uDQo+ID4+IEhvd2V2ZXIsIEkgdGhpbmsgd2Ug c2hvdWxkIGF2b2lkIHJlbHlpbmcgb24gb3V0cHV0IHRoYXQgd2UgaGF2ZQ0KPiA+PiB3cml0dGVu IG91cnNlbGYuIElPVywgcmVseWluZyBvbiBYZW4vTGludXggdG8gYWx3YXlzIHdyaXRlIHRoZSBz YW1lDQo+ID4+IG1lc3NhZ2UgaXMgcmlza3kgYmVjYXVzZSB0aGV5IGNhbiBjaGFuZ2UgYXQgYW55 IHRpbWUuDQo+ID4NCj4gPiBFc3BlY2lhbGx5IGlmIHdlIG1ha2UgdGhlIHNjcmlwdCBjb21tb24s IHRoZW4gd2UgY291bGQganVzdCByZWx5IG9uDQo+ID4gdGhlIGV4aXN0aW5nIGNoZWNrIHRvIHNl ZSBpZiB0aGUgZ3Vlc3Qgc3RhcnRlZCBjb3JyZWN0bHkgKG5vIHNwZWNpYWwNCj4gPiBjaGVjayBm b3Igc3RhdGljIG1lbW9yeSkuDQo+IA0KPiBJbiB0aGlzIGNhc2UsIGhvdyB0aGUgdGVzdCB3aWxs IHZlcmlmeSB0aGF0IHRoZSBzdGF0aWMgbWVtb3J5IGNvbmZpZ3VyYXRpb24gaGFzDQo+IGJlZW4g dGFrZW4gaW50byBhY2NvdW50IGFuZCBoYXMgbm90IGp1c3QgYmVlbiBpZ25vcmVkPw0KPiANCg0K SWYgb25seSBzdGF0aWNhbGx5IGFsbG9jYXRlZCBtZW1vcnkgaXMgZW5hYmxlZCwgZ3Vlc3QgbWVt b3J5IGFkZHJlc3Mgd2lsbCBzdGlsbCBiZSBtYXBwZWQNCnRvIEdVRVNUX1JBTV9CQVNFKDB4NDAw MDAwMDApDQoNCj4gPj4+ICsNCj4gPj4+ICsoZ3JlcCAtcSAiQnVzeUJveCIgcWVtdS1zdGF0aWNt ZW0uc2VyaWFsKSB8fCBleGl0IDENCj4gPg0KPiANCj4gLS0NCj4gWGVuaWENCg0KLS0tDQpDaGVl cnMsDQpQZW5ueSBaaGVuZw0KDQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 11 09:21:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 09:21:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364964.594955 (Exim 4.92) (envelope-from ) id 1oApbE-0002F5-Hj; Mon, 11 Jul 2022 09:21:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364964.594955; Mon, 11 Jul 2022 09:21:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oApbE-0002Ey-E1; Mon, 11 Jul 2022 09:21:04 +0000 Received: by outflank-mailman (input) for mailman id 364964; Mon, 11 Jul 2022 09:21:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oApbC-0002Es-8V for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 09:21:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2073.outbound.protection.outlook.com [40.107.21.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6205fca-00fa-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 11:20:58 +0200 (CEST) Received: from AM6P191CA0060.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::37) by VI1PR08MB4272.eurprd08.prod.outlook.com (2603:10a6:803:101::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 09:20:56 +0000 Received: from AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:7f:cafe::39) by AM6P191CA0060.outlook.office365.com (2603:10a6:209:7f::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 09:20:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT055.mail.protection.outlook.com (10.152.17.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 09:20:55 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Mon, 11 Jul 2022 09:20:55 +0000 Received: from 1420e168e85f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34AB0E42-F08F-4D82-97D5-C5C98CA0213C.1; Mon, 11 Jul 2022 09:20:48 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1420e168e85f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 09:20:48 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by VE1PR08MB5870.eurprd08.prod.outlook.com (2603:10a6:800:1a8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Mon, 11 Jul 2022 09:20:46 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 09:20:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6205fca-00fa-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Eo3AD1hSWKynx0vwKtHX+H9mEnWyQBzMpMlQj1t0aePb1zDvqwvPoUQe/i6291GyZkF3qC7zjeZQlEA9kuHcVIhuli7S16aXHQnZZeleZG7Qh75r/5jDcpkE9pnGMZWDVyTc+gmooxtrTHvBUeVKgaB1dz+UGWFEwVVVgs8CHdib/w/9P41yi3W57ya9xt5+kzyKowqxAGPKbM0nkfV0OfdJ+np5lkCgmM8pYRDZex807KCmYE2oB+W+1fCIrReWD5SEYUn9zykHqKmQyy+UicKjuGUKEfwN3MuilVH89fOwkofZ7TO2HvwhQTPmWjX1VaMk49393S9OIbAjKb16Fg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FODdx/1HmDE7I6VeO3mvOhyvv5jnWK6h02+qYQ6RbC0=; b=eRf3nXjdJbihXm17E/OEePmX7HDRajNR+1Otwq1h5xXrDWa5ZpAupmVUkRpt6BvO/lj2xloy436AAhpGPHzlBsknoL9z5eMOyqkDsr2WTq+PGm3ElD2JvbdPIYHkcgSrfRXuabmWSy/WTMxPOEb7R1TgzjRAhJlbdL3IWEIRWKJEKFv5HWLBU4MjdnAdz/qoQPFVB9QVLDNXV7C6b5uD5GlMCClypskQSYu+KWGqJn5bCKk5K9Gs5csz7HoAbCxjt5ZPmpDVGmiIJHt3uiiaz1y/hlhgh7kb/jnPAvQnZDQCd9Jxx04j9/f1NlgvUTjbP+Mdim2fTuwwmFSxtKHl2Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FODdx/1HmDE7I6VeO3mvOhyvv5jnWK6h02+qYQ6RbC0=; b=0heX+/OJWx9A9rCabmZURDr2jNifeXewwhxQlwfGKXCtRAtcD8XTKBcA5SDJDaMsCN5d/lfYPH2A6ykCrtBdMYRGUCcIOdqrxUqN4aBD98occTpMpgoEqi235qLs2RnNmmomqThHXoHyWwtMQFQ08TPxCHrfF8f3ezzM+0LnPyc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 903d2891e31b90c3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kucPb3IjY34K6uHZ6TjM9nlKrThfEKF4B8VwqpFViCWmsbyZXjEj/q5ADaT4DuC5Mny6id942nJnFHCOEdQUQWMC6F2FkgV6rOz8v4bJnhbni5mmGaTWr1cJNVkmPddlJMiPaWGsXRoSxCLO5xtaQvruAMBDeVhDtQbv7h1CIW9JSpoN9/wqA9OacTbjc7MSfdDCTSJoq5qVhM4ZaBr9sZpLv+yro/3fXy4+f6xox9WCmpCyQch4EWrXXwkwJ6HWmqht/WiFM6cGOi8IOaBi0PNkMXrurd4u/rZjN/Q01BGrNUB46KPqkv6Uh4Gz15iHpa6lNWQrCcYvPjdh71qqXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FODdx/1HmDE7I6VeO3mvOhyvv5jnWK6h02+qYQ6RbC0=; b=IL3GAOAyWWWyMZE80+WkLJD+vpxMUw8E+MKBjyLaqO5bb1iAo1cKjlwgkzL5xcRtx78llOM6dLl1IVhZRsGKcD2vD6EySa7CHTOTRW/ALx4ec4WPN6hHe1a8sdRh3rqOdetJAbz9STC+Qbdc3M+PM6NrOaCBICLvzar38azP/r6ij891Qz2wyL/ClokHN0lH/lmcznX4lVkXo9Yj199HyJqsTeGHwiQFfJtiH/4HdfSTEhonQxwWUlTH1mKqD5m6HL3IlJoWTb6jZDHedFJlmItA+tAaPzxMsNYeX8lYkxoedrffMDk20Me3OteSJSzLIJB1UjpnzNxhEtlMuMpRYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FODdx/1HmDE7I6VeO3mvOhyvv5jnWK6h02+qYQ6RbC0=; b=0heX+/OJWx9A9rCabmZURDr2jNifeXewwhxQlwfGKXCtRAtcD8XTKBcA5SDJDaMsCN5d/lfYPH2A6ykCrtBdMYRGUCcIOdqrxUqN4aBD98occTpMpgoEqi235qLs2RnNmmomqThHXoHyWwtMQFQ08TPxCHrfF8f3ezzM+0LnPyc= From: Luca Fancellu To: Demi Marie Obenour CC: Xen development discussion , Jan Beulich Subject: Re: [PATCH v9] Preserve the EFI System Resource Table for dom0 Thread-Topic: [PATCH v9] Preserve the EFI System Resource Table for dom0 Thread-Index: AQHYkxKUjUJb6n+aY0G11gulhs4gPq146NqA Date: Mon, 11 Jul 2022 09:20:46 +0000 Message-ID: References: <20220708213403.2390-1-demi@invisiblethingslab.com> In-Reply-To: <20220708213403.2390-1-demi@invisiblethingslab.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8cb3c0ff-13e2-4c73-e6a0-08da631ea8b0 x-ms-traffictypediagnostic: VE1PR08MB5870:EE_|AM5EUR03FT055:EE_|VI1PR08MB4272:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: x/q4OnD0VXF8l5VtocHTrs6u0wORb7oynhyUpjtoNfQ4B/JbLkZPNIdRmwte8x5BjuictZgYy7rYdbiQqqvAF1u2Cg/EsSaCpD1TaRy8Xvxi3YjPnvdCWYfx+qITN5myDaRE40QBKwf2CHpF4lZ/J8X1TmOtZgSO/7JrDPxcJgkC1Z9dFP5sndYx0mg/AW8pmmB+qGIghvqVV8FMIhHIAoL6Uo6EysZ1T5LYRH9dBW7Cq+WMeo2eI425zWjiqj84MQ+cS/9G4FRNn+Jdrds6zslRl19X/X5ySzVfKLjzOEDSKKk35e0/Lkp2fNnuUe8Yd+HmXeSQLKbdRV16wrJEZGBoKtNkQ2D3oZF6O1AZM+a84IoAmCj1Hl9wXj1RZrWTu+x1lZGZmxaU6MEEWaIsJOnG+obQaYdMbvEKGO+D6zZqg6HspmhyvRiCayaEWdf+avALJW6GEI7vOF/dbUNDxQ5zXi8lucyFXtGlIozFj/pGwTwAOA+zhFJP1OGt3XV6ROBKZukvpXoIbXx5lrO9SUD0/J9V3agO48vgmJeBVeNZbaz/Tr1EtYhNq7YJ2+3VlY/WeNMPQrGzPMuBWGeItTv2zZPH0YR9rQY+HC/Qj8rSXBjTsE3GkavAjbLkkpdSnvceYErvHeqMUmhtWjWLshlEwmhI+j4vKQAWfZ19M2DsBsbJLDNA4XkU9GtTILHWrNcZVqIHSQFoTcz1j4FtVmn/G4Q65jdk3rBQwsYcsrsSP3gCjfh4A2UvhkACM53ViR8plhufKiB9VJpYNbFzdst4jvVh/CMZcmTQkwLlTKFZoNHxCTcclFIDYBL5Hui2JJQu/hZiivv43KmzYt2mEytpLuFHGR2iQh2t1mh+dJGZZCXxMZYEUBiymNjQ29pG X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(366004)(39850400004)(54906003)(6916009)(6506007)(53546011)(966005)(316002)(6486002)(5660300002)(2906002)(36756003)(38070700005)(91956017)(478600001)(41300700001)(6512007)(26005)(33656002)(71200400001)(122000001)(76116006)(2616005)(4326008)(66556008)(83380400001)(66946007)(8676002)(66476007)(64756008)(66446008)(86362001)(8936002)(38100700002)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5870 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a3d3dca1-60ec-4db4-9267-08da631ea31d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xKdGVWDOggwZkE1awbiOs1vRiWYImD1cQKlbAg2VIV8jatbwGo1ZC7QTUFqNRS6YDNW4sxTgottdpBOQbIBuLQmwYKNBsCsrhEr/EpVZFwHWapECL/kxflOWThThND3qBYa4MYZ75992NyHH2e9PaddO8RUn8MIvFcqcMOlan1VsBvypGfBj24CNqnVQCFRirUsv0hBb3naqagca9rH06I3TZyhUXHY+OMD/4u3DNdIW0XSJq7jnwvd8hwFcb+ODBgdgyRflDZ8qUjPHAg5ApgIQ7gNLJu1d6Pp0ROSL3NFKmayEa2S4PK6d7+t2g8fQ/wjvgK+qblGbH2ksKaoimayupqWf+2RRc/8NqJIlLx+UaScVy7k2HTyDRG5NYcKwlaIC9hC4hU5KLEmTcU5AmKkLkygioh0BPqRhF5HpF7/DOlzd3b6aOKb/bKiloXUMmwNdPfevXLCX0oVqZQ4DPBX1wNpAnHX+yoVo8ydoeR8/3jBaUgoQuEdZRc9sPiFop6n0CkAMFcf2/ZE3GzgVKRqp4CYD84UX5fPAc83hg88a2pM39q7UiScnityXMsPmn9FymfNa3AiUrp/3e9I75K8swxohjorge1HQmMhRRkczbTjrWlsxh00MFgpaOzvTPz4YrxYwq7jqXWgtMMtfbMHPSERnxaSIX/ad0RJMmYavlZr8BlcBZK8QqvOscYHj5W942Q8vZmXYdtHTN9HLTDpqKhajeRKQ9bArSd/4ICE7Fc3iQsG5wKZm3a4R+IUYXQ2QDwn1ZnvZTn37N9XNwCdoZvEZNiaeqJrqu/1nYhsjGbZpTHjQtiasv0u/ouOTFyr/fTg+DxuqF9c6XGmLGRbbcLbDVtGktCChSCi3tZY= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39850400004)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(478600001)(47076005)(83380400001)(40460700003)(54906003)(86362001)(82740400003)(336012)(107886003)(81166007)(356005)(2616005)(6486002)(966005)(6506007)(41300700001)(82310400005)(53546011)(26005)(4326008)(33656002)(36860700001)(40480700001)(70206006)(8676002)(70586007)(8936002)(316002)(6862004)(36756003)(5660300002)(186003)(6512007)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 09:20:55.6055 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8cb3c0ff-13e2-4c73-e6a0-08da631ea8b0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4272 DQoNCj4gT24gOCBKdWwgMjAyMiwgYXQgMjI6MzQsIERlbWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBp bnZpc2libGV0aGluZ3NsYWIuY29tPiB3cm90ZToNCj4gDQo+IFRoZSBFRkkgU3lzdGVtIFJlc291 cmNlIFRhYmxlIChFU1JUKSBpcyBuZWNlc3NhcnkgZm9yIGZ3dXBkIHRvIGlkZW50aWZ5DQo+IGZp cm13YXJlIHVwZGF0ZXMgdG8gaW5zdGFsbC4gIEFjY29yZGluZyB0byB0aGUgVUVGSSBzcGVjaWZp Y2F0aW9uIMKnMjMuNCwNCj4gdGhlIEVTUlQgc2hhbGwgYmUgc3RvcmVkIGluIG1lbW9yeSBvZiB0 eXBlIEVmaUJvb3RTZXJ2aWNlc0RhdGEuICBIb3dldmVyLA0KPiBtZW1vcnkgb2YgdHlwZSBFZmlC b290U2VydmljZXNEYXRhIGlzIGNvbnNpZGVyZWQgZ2VuZXJhbC1wdXJwb3NlIG1lbW9yeQ0KPiBi eSBYZW4sIHNvIHRoZSBFU1JUIG5lZWRzIHRvIGJlIG1vdmVkIHNvbWV3aGVyZSB3aGVyZSBYZW4g d2lsbCBub3QNCj4gb3ZlcndyaXRlIGl0LiAgQ29weSB0aGUgRVNSVCB0byBtZW1vcnkgb2YgdHlw ZSBFZmlSdW50aW1lU2VydmljZXNEYXRhLA0KPiB3aGljaCBYZW4gd2lsbCBub3QgcmV1c2UuICBk b20wIGNhbiB1c2UgdGhlIEVTUlQgaWYgKGFuZCBvbmx5IGlmKSBpdCBpcw0KPiBpbiBtZW1vcnkg b2YgdHlwZSBFZmlSdW50aW1lU2VydmljZXNEYXRhLg0KPiANCj4gRWFybGllciB2ZXJzaW9ucyBv ZiB0aGlzIHBhdGNoIHJlc2VydmVkIHRoZSBtZW1vcnkgaW4gd2hpY2ggdGhlIEVTUlQgd2FzDQo+ IGxvY2F0ZWQuICBUaGlzIGNyZWF0ZWQgYXdrd2FyZCBhbGlnbm1lbnQgcHJvYmxlbXMsIGFuZCBy ZXF1aXJlZCBlaXRoZXINCj4gc3BsaXR0aW5nIHRoZSBFODIwIHRhYmxlIG9yIHdhc3RpbmcgbWVt b3J5LiAgSXQgYWxzbyB3b3VsZCBoYXZlIHJlcXVpcmVkDQo+IGEgbmV3IHBsYXRmb3JtIG9wIGZv ciBkb20wIHRvIHVzZSB0byBpbmRpY2F0ZSBpZiB0aGUgRVNSVCBpcyByZXNlcnZlZC4NCj4gQnkg Y29weWluZyB0aGUgRVNSVCBpbnRvIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGEgbWVtb3J5LCB0aGUg RTgyMCB0YWJsZQ0KPiBkb2VzIG5vdCBuZWVkIHRvIGJlIG1vZGlmaWVkLCBhbmQgZG9tMCBjYW4g anVzdCBjaGVjayB0aGUgdHlwZSBvZiB0aGUNCj4gbWVtb3J5IHJlZ2lvbiBjb250YWluaW5nIHRo ZSBFU1JULiAgVGhlIGNvcHkgaXMgb25seSBkb25lIGlmIHRoZSBFU1JUIGlzDQo+IG5vdCBhbHJl YWR5IGluIEVmaVJ1bnRpbWVTZXJ2aWNlc0RhdGEgbWVtb3J5LCBhdm9pZGluZyBtZW1vcnkgbGVh a3Mgb24NCj4gcmVwZWF0ZWQga2V4ZWMuDQoNCkhpLA0KDQo+IA0KPiBTZWUgaHR0cHM6Ly9sb3Jl Lmtlcm5lbC5vcmcveGVuLWRldmVsLzIwMjAwODE4MTg0MDE4LkdOMTY3OUBtYWlsLWl0bC9ULw0K PiBmb3IgZGV0YWlscy4gIFRlc3RlZCB1c2luZyBxZW11LXN5c3RlbS14ODZfNjQgYW5kIHhlbi5l ZmkuDQoNCk5vdCBzdXJlIGlmIOKAnFRlc3RlZCB1c2luZyBxZW11LXN5c3RlbS14ODZfNjQgYW5k IHhlbi5lZmku4oCdIHNob3VsZCBiZSBhZGRlZA0KaW4gYSBzZWN0aW9uIGxpa2UgdGhpcyB1bmRl ciB5b3VyIFMtby1iOg0KDQotLS0NClRlc3RlZCB1c2luZyBxZW11LXN5c3RlbS14ODZfNjQgYW5k IHhlbi5lZmkuDQotLS0NCg0KPiANCj4gU2lnbmVkLW9mZi1ieTogRGVtaSBNYXJpZSBPYmVub3Vy IDxkZW1pQGludmlzaWJsZXRoaW5nc2xhYi5jb20+DQoNCknigJl2ZSB0ZXN0ZWQgVUVGSSBib290 IG9uIGFuIGFybTY0IG1hY2hpbmUgYW5kIFhlbitEb20wK0FDUEkgYm9vdHMgZmluZS4NCg0KU28g aWYgaW4gdjEwIHlvdSBkb27igJl0IGNoYW5nZSBhbnl0aGluZyBhcGFydCBmcm9tIHRoZSBzdHls ZSBpc3N1ZXMgbWVudGlvbmVkDQpieSBKYW4sIHlvdSBjYW4ga2VlcCBteSB0ZXN0ZWQtYnk6DQoN ClRlc3RlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQo+IA0K PiArc3RhdGljIHZvaWQgX19pbml0IGVmaV9yZWxvY2F0ZV9lc3J0KEVGSV9TWVNURU1fVEFCTEUg KlN5c3RlbVRhYmxlKQ0KPiArew0KPiArICAgIEVGSV9TVEFUVVMgc3RhdHVzOw0KPiArICAgIFVJ TlROIGluZm9fc2l6ZSA9IDAsIG1hcF9rZXksIG1kZXNjX3NpemU7DQo+ICsgICAgdm9pZCAqbWVt b3J5X21hcCA9IE5VTEw7DQo+ICsgICAgVUlOVDMyIHZlcjsNCj4gKyAgICB1bnNpZ25lZCBpbnQg aTsNCj4gKw0KPiArICAgIGZvciAoIDsgOyApIHsNCg0KSGVyZSwgY29kaW5nIHN0eWxlIHdhbnRz IHRoZSBicmFja2V0cyBvbiBhIG5ldyBsaW5lIChKYW4gY29tbWVudCk6DQoNCmZvciAoIDsgOyAp DQp7DQoNCg0KPiArICAgICAgICBzdGF0dXMgPSBlZmlfYnMtPkdldE1lbW9yeU1hcCgmaW5mb19z aXplLCBtZW1vcnlfbWFwLCAmbWFwX2tleSwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgJm1kZXNjX3NpemUsICZ2ZXIpOw0KPiANCg0KQ2hlZXJzLA0KTHVjYQ0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:14:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:14:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364986.594965 (Exim 4.92) (envelope-from ) id 1oAqRB-0007ty-HE; Mon, 11 Jul 2022 10:14:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364986.594965; Mon, 11 Jul 2022 10:14:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqRB-0007tr-Ej; Mon, 11 Jul 2022 10:14:45 +0000 Received: by outflank-mailman (input) for mailman id 364986; Mon, 11 Jul 2022 10:14:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqRA-0007th-DI; Mon, 11 Jul 2022 10:14:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqRA-0003g4-5G; Mon, 11 Jul 2022 10:14:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqR9-0001PA-KW; Mon, 11 Jul 2022 10:14:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAqR9-0004c8-K4; Mon, 11 Jul 2022 10:14:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nVxQjvQJiniIuWudLtsAIeTdH4slyk82tBH4guHHKTU=; b=elnWTLHfcdenbc6aNzg8ITh2i6 yJiKDrYoGZGZz7x9Lluva/O5oA6gZCFAhPeLim72GjEhpbLWC/KBcZjKTwwBjpiZd4ApUfJEM09nv 8IOLW6FIU6UZmDfWZmgVc9dRM/Q0albOv1AjtV/0LGndKpoar0bfE1ZQlV4ivjaF48pw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171581: all pass - PUSHED X-Osstest-Versions-This: ovmf=12dd064a1804536518eb12229836fa572c232502 X-Osstest-Versions-That: ovmf=f6f3cc7eadcfb20898b8d67fbcae21ef56f6897b From: osstest service owner Date: Mon, 11 Jul 2022 10:14:43 +0000 flight 171581 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171581/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 12dd064a1804536518eb12229836fa572c232502 baseline version: ovmf f6f3cc7eadcfb20898b8d67fbcae21ef56f6897b Last test of basis 171580 2022-07-11 04:42:03 Z 0 days Testing same since 171581 2022-07-11 08:42:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Robert Kowalewski jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f6f3cc7ead..12dd064a18 12dd064a1804536518eb12229836fa572c232502 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:18:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:18:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.364995.594977 (Exim 4.92) (envelope-from ) id 1oAqUX-0000Af-0m; Mon, 11 Jul 2022 10:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 364995.594977; Mon, 11 Jul 2022 10:18:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqUW-0000AX-U0; Mon, 11 Jul 2022 10:18:12 +0000 Received: by outflank-mailman (input) for mailman id 364995; Mon, 11 Jul 2022 10:18:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqUW-0000AR-5x for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:18:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2041.outbound.protection.outlook.com [40.107.20.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c3de4160-0102-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 12:18:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9568.eurprd04.prod.outlook.com (2603:10a6:102:26e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 10:18:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 10:18:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c3de4160-0102-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BuiuzZ2XZiuUrr819rtCdXumtBOAcheYrmOcZmVbfgf8nvfjZSKae6sJQZbnbrbjbTgXUyVL+z+dvjkkVRzu37Uq5xpytEMKolg5gy5+Fcb9PbHpQwp2vimJtiitw6Qfmr2053/rr+sZ7Q21rHxc1c2toqGoMffzitCyGqTid7W/gL92CmhAFz4LABkG4REd4DMc/H4v9c4fKgpi+x01IwtSvST6eAmsu6eYD3mP3wcva/uDDG42n1jxnfHRC5HC5cv0GmZVWmyCHoZAyB3Pj7N9u/Mmsnvfxygt1MZGrrO8FL96sqijJJkPQFMX7LYW3BYym0QpyMnK5fKUmRb2dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RtKYZMysepxFqdQWhwaNCzg3kFQr5pPutYk61gpWAzg=; b=dkPhFLZ4eLV1idZTgxBJhy/VJdxjcEAmJn46VpKqVqfl8BwyjDktIGjKA2bf1c0XSc2jAMnTu25XYLEeM1v/17gpP9kUQlcv0ioFXcDdEhghPqtSNppj10O6PvLNqdf+nZI1UfmkSJK9e2yOYORmhzKaw8DtsR0MY8OswNfIc658zvlNXO9rqX3eEvHdRNEcIaIqGs1Y2qtywolxhM/tz5VZSCPkvvQqNYiwouGTzlrBoIAXN1sZ6jF/mukG0NvYWw82J67zy2qggydvfvtaLNn8QYOXa8BO2LsZ3PnDOrj9YqVcY2bga3DAwt9r4gUu1pZywf/WuplDbmRu5jk+EA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RtKYZMysepxFqdQWhwaNCzg3kFQr5pPutYk61gpWAzg=; b=2m9FGefg+pFHVU9YeUnTb64NJaFRFmHiMU1hchdfQnhKfMuf8MVlE1rhr5kPY7oprjwt2JNk4CCVUkYaEAk81gkHTbcIeku6sBo4Q+Ew6J1w5poiLaN63SIVqVNXfZ5LupOn4P1JIdgPwa5J3lp3JKVnxYbirvJC775uRGHz3CxatZXDPNQSpa4WvlKMX6noeDcGCJRH1gkGJTnr6D1ZCPLHXmmlmHvDqfpsumQC7BEg+3obLw0o3Q2JaygXZHzTmBloG6Smq/DMeFe8q7myG0iMcaZXq5rTd4ZAPOU6nZ5sUa5FIf75hqTdElBUJrqAsG+fox3mHVgtgOidXaIDXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <48f157d0-ed5d-b584-fcff-1425c137335a@suse.com> Date: Mon, 11 Jul 2022 12:18:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 5/9] xen: generate hypercall interface related code Content-Language: en-US To: Juergen Gross , Anthony Perard Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220324140139.5899-1-jgross@suse.com> <20220324140139.5899-6-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220324140139.5899-6-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: CWLP123CA0164.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:88::32) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0724b647-f790-4c2c-8dc1-08da6326a6bc X-MS-TrafficTypeDiagnostic: PA4PR04MB9568:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NrPes/42KiapD4rXqgYm8uSaPlDONItEF/1Ctfo/ZLCsOpUCao29O+U5lvz1K0lEIvyacfyXdur7L0gYh0N4Ec9a1KKFfalUPvwIXP0kmfBL3B7xINOa5AlJUtEa3W9F+PEOHSgBPT1LS8DSJGruGMyzaI4sTwzl8MClxeIm3aGlysvdTelUzmLMKKL/0nOhuQ78Vz+K6xMvKCm/3udIqdeBycbwrQTe6jRg4RLVQAE5vo7PowjYVb/rEUEFiVRnYyFq2cq5Pq9Uu3u4nU1urc1o4JcWDJ5Qr2L9NYffBllgzNO1kido/LLJQRJfqKW02H1sxSMhkkJf7WyiO09k1OgOWXLebRW+pcH/TMdoNV5Eu2Q5u1yw5+CLmBgwQ5CKxcGjM1645OnCdCgHQRsXxSlQRofOXZvUDnqqRQfDWjQGviU4wxce/Rn9F4aLSq00Bl5OgpQ8zl079S3lPcCT9slUwkU6Nwg0O4lAOFOz3CyNpJ6AvuTPKIyoJzbN7xoDC6zlBwtZghT8f5omhvBlKL+4q33zrXOPJD2lLJhJA86zdOwLo70VHD9qKjXNe/iwGEhsIaRZfwph/GrLhvs/EjlnE2wlUjR59jvLtxw2JPGV88GvYjqzztPaJKZOVaIbQXniYzwyc1SvF8/bDmPBzSPIrT3PiqjQlWxLu5nUjjv/L2vDqnePN3OH2dM8wOGzvSuVti4HEoHFk4h4XrzwaU7gWTLK6dZMOL8Vjuyhsu4XjJn7Zlo72YBOQd8Zp9jwdXQtOETIOW8Or5E1cJCc+OPUNxIqemBUo1L59tN8hjz93qS89t6y/77RmoZujTP5cP5Q5723qgxZAjUOtB+0hoHGJSHa8GfNaFgHF7lJERg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(136003)(376002)(366004)(2906002)(6486002)(478600001)(186003)(36756003)(31686004)(2616005)(86362001)(31696002)(316002)(5660300002)(110136005)(54906003)(4326008)(8676002)(66556008)(66476007)(66946007)(8936002)(53546011)(6506007)(38100700002)(41300700001)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmFobGhQN1RnK21oaENvb2JOWXlUcWdvMmNwbVZMSytLalNwVUx6VEFOK0Fx?= =?utf-8?B?Z0N0Q283SkhoVWYrTHhvaGtTeVdkWSs5OTArMG81dnRidE8wU3hYd2F5Wi9z?= =?utf-8?B?QTh2SXFwcjdsckRLZ1ozTTBsWkE3U1k5SjVaamYyVXpseGJMRk56c3BnanhR?= =?utf-8?B?QVdNRWR6Ti9WbEZDTVNKYVBHK2tWVG9oa3c1Uzk4VGF5aGdEK1pyUmxjOUhP?= =?utf-8?B?MThEVTcrd3YxSCtuMnRQbzM0RFdndFFvTjhPV2pDb1psK3FaVmpoOWVERWpG?= =?utf-8?B?b2t1ZnNDWXpCd2RaUGNWU2tCMjZwdWlzbDNDQm81TSs5VGdsamtOVHkrNk9Y?= =?utf-8?B?N2lqU01RSWVGTWhMNFlVRlBVSVV4eVhTb3l5MURpKzl5VTRwR3NNOC9HSHV0?= =?utf-8?B?MHI5MzRkK293YW1CTzJTL1p6Vk1NV1plMDFTdXlNUXJvdG5mVnRwL3FBblZu?= =?utf-8?B?cHFBNGxzSy9xSWJxL0hBc0x3UTlURFdzbFpaRUhrSnBXbmJhV0ZobkUyL3gy?= =?utf-8?B?UzYwMDNUOXBTWnlZeTJ4WDhCYmlLK1lHT1hUU1NKcGlqdkM4QzdSa0UxcitN?= =?utf-8?B?eEU2ZkhVbnQrRThPaGt0cWdBejZZVnEzM0RnVFV4M2NVYUtnMDE5c2xRTFIr?= =?utf-8?B?L1oyOTJrODhMZEE3dmYwOHMvOFVaUUlIZFB4dkIrR2hYSTlqY09XM3IxcEla?= =?utf-8?B?MnFuQzhNZ2lwbG84MUJ2MVNpZWdXYjZXRjJiWVRCdThBTXd2NjhWSjFxUlVy?= =?utf-8?B?Nk50dTExSDdXeWVxQ2JXazZ3VmVYU24wL2U0QUpPWFNkVGxWeVN2NWlXczhW?= =?utf-8?B?Z1Zuc2s0ZGRNYVBMTWtHK3l6Z0lkRWNFSWMwUnNaQ3lMRGlkSXp6VjM4QVBM?= =?utf-8?B?ZTBNemV0SDZyMHdSakVabjJzTjZoMlpWQ1RCQ3hlbUtiWjJ1ZUJqaHVCcnBT?= =?utf-8?B?c1QwY1R6Z1liTnNUSXRlL3NUL3AzeXEvdGlrNUFuKzJncDVEZ2Rqb1V1TmJj?= =?utf-8?B?R0tpTGZNbVJpQlNXZFVnV0l1L2pqSTRETVBCdHFia1BOUmFnbW1WaEx5Q1I2?= =?utf-8?B?YWVLRC82eXJTZlpSRit5WjZ0Y3ZKR0VIQkVEY2ZlakljQm8zVGNyTSs4VE10?= =?utf-8?B?MmV3dW42ME9Xb0Y1Q2xQRjVPa2hNaEY4UnNiaUhKaDUxT0g4RWNwVEd0U1pD?= =?utf-8?B?RjlNU1pLYVBsazlTaVRvbUlhWEFObkk3aElDRXVKcGNtc0F6ckdhci9NMXhu?= =?utf-8?B?TS96OE9ERGpUVzBaTFBvU0ZyL1VhdGJwUlRhcGV4b2d3N3p0Z2dxOUxDbkNO?= =?utf-8?B?OGJXVUdtVWY3Ym1TeG9SQXBMenJBM24rUG42WFNzemNHcnIyeXJENDJVWGRu?= =?utf-8?B?Ym54UjQ1TnhYR1g5cUp0bmdacjl3UEdsMzlqOG1FelRCVU1WY0JtMnhDcUcw?= =?utf-8?B?ck5YWWIvL08vNk14REdNSCtPVW5xdVRlMWNwckhaQlMrcU9XQUo4MGVxbHF3?= =?utf-8?B?V2ZycXNJTHYzWWlZb3Q3M2ZrV2JxdVZKMGUycHROaWVlMkhucHdFZUswV25C?= =?utf-8?B?WEYvaU5Ua2RkY0cydWRmUFI1cURZdzh4WnZQUTBoeENFbkMxV3VCWHZZckpS?= =?utf-8?B?YVMyQmR4LzZRR1hZRm4ycGQ5UVZDVUhlSnk2bmI2OEZBNUJkSlBiekxHVHAz?= =?utf-8?B?czZoSTlzNWRtZTk0dW9Qck91MmJNUVBWWFZsUHVGaldueExKWGFORWRIVmJ6?= =?utf-8?B?Y0FaS3JkR1oxZGhqaEVJekhDN2VBTjVaUk5LdTM0bWNrcW93VnoxalVHY3Vh?= =?utf-8?B?ZG9pL0ZONXhEZGFLM214dVQ0b1NSc2ZXMVJWUWEvZkFmcExVbTV3enhzSWZm?= =?utf-8?B?Q2ZPdk9saFJOQlFSZkFhaktMR2J6MVhkMjdWbVI3dVMxLzZ1Q2pEMm0wVitC?= =?utf-8?B?Ujk1R3FCRm90OGlSQ0ZvTlBiUGVKMDNTWmxuNjZTMFhTNHE4a0lOYjlqYjdF?= =?utf-8?B?b3FjbzlkVWdQL1dPV0t1amNDY1p0b1pHS0xJUEh3TDJCZVZBV1lCbi93ZXpT?= =?utf-8?B?VEtWRTVIZ2lCWEp6NmJiV2xabTM1bXUyc1dqTkhUbFYvK09sZ3lrS3g4MW9v?= =?utf-8?Q?OdjUa9LEV5hoqeWw6QGdT0Rmq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0724b647-f790-4c2c-8dc1-08da6326a6bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 10:18:08.5503 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vD2vmdy5Zf506aDh/RFsPF6rNqo5W1SH89LrUux7XBo2oAyVrl4/yv+XiUtKv5UtbuqlnvwLOZhElX7MMZxIKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9568 On 24.03.2022 15:01, Juergen Gross wrote: > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -77,6 +77,18 @@ $(obj)/compat/xlat.h: $(addprefix $(obj)/compat/.xlat/,$(xlat-y)) $(obj)/config/ > cat $(filter %.h,$^) >$@.new > mv -f $@.new $@ > > +quiet_cmd_genhyp = GEN $@ > +define cmd_genhyp > + awk -f $(srctree)/scripts/gen_hypercall.awk <$< >$@ > +endef > + > +all: $(obj)/xen/hypercall-defs.h > + > +$(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(srctree)/scripts/gen_hypercall.awk FORCE > + $(call if_changed,genhyp) > + > +targets += xen/hypercall-defs.h > + > ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) > > all: $(obj)/headers.chk $(obj)/headers99.chk $(obj)/headers++.chk > @@ -132,3 +144,4 @@ all: lib-x86-all > endif > > clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h > +clean-files += xen/hypercall-defs.h hypercall-defs.i I've committed this as-is (with just fuzz suitably resolved), despite being uncertain whether xen/hypercall-defs.h - being part of targets - actually needs enumerating here (anymore). Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:39:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:39:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365016.595036 (Exim 4.92) (envelope-from ) id 1oAqp0-0003Iz-DW; Mon, 11 Jul 2022 10:39:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365016.595036; Mon, 11 Jul 2022 10:39:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqp0-0003Is-AP; Mon, 11 Jul 2022 10:39:22 +0000 Received: by outflank-mailman (input) for mailman id 365016; Mon, 11 Jul 2022 10:39:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqoz-0003Im-PH for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:39:21 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6c3f7c5-0105-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 12:39:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6c3f7c5-0105-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657535959; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=o61BUL37KyEgTZE8sS7VQM4OGp6wmIPN9Pluham6bUM=; b=T/7MiMnBA+feMGhrERur3vzQ6uoh8QQp1PF4hUd9eCSkARIX6q+t1yYz d2eGF+kVrG9Quhs2wj4kpL9HeNsgVCqrZzL6fXGMDoyQcgqyi7XoB+ALC V1U2q+9cArBxBLPDPSBWZ+EZU400ilsVfQ3WwyWidCEiCWyNsaZr4xmSH c=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75498249 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+y3AtqKm47VJzC2NFE+RqZUlxSXFcZb7ZxGr2PjKsXjdYENS1DAPm zBKUD2CPP/fY2H0fIx1atm+/RgE6pfQn4QyGQRlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA14+IMsdoUg7wbRh3dcx2YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 Md8h8CtTDwUApCWyMdHTgVVCztAEqITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBMDtIIMYvGAm1TzDBOwqaZvCX7/L9ZlT2zJYasVmQquCN ppDNWsHgBLobwNfOmgcJrgHtcj1vlOvSRBH9X/Fqv9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0z7DQsdL8e30iee/zSngeqntTP2XsceGaO18tZugUaP3SoDBRsOT1y5rPKlzEmkVLp3J U0O9y8jsaU17mS2VdTnRFujp2OetRMSXMBfHqs85R3l90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt8HYN2BytYaodU/HppTOsC+/ITIrAmBXMEfoUjA5D8nfTJAb10ySEY07SvPs17UZChmrn WnU8XFWa6E7yJdSiv7lpQ2vbyeE/MChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU JTpdqGjAAEy4XKlznXlrB0lRu3B2hp/DBXSgER0A74q/Cm39niocOh4uW8jexs2Yp9bJW6zP Cc/XD+9A7cKZhOXgVJfOdrtW6zGM4C6fTgaahwkRoUXOcUgHON21CpveVSRzwjQraTYqolmY c3zWZ/1VR4yUP07pBLrFrx1+eJ6mUgDKZb7GMmT5w65yoCXeHP9Ye5DaDNimMhitPPayOgUm v4CX/a3J+J3CbyhPHiOrtdNRb3IRFBiba3LRwVsXrbrCmJb9KsJUZc9HZtJl1RZoplo IronPort-HdrOrdr: A9a23:QTEt3KDD5hhQgt3lHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8v xG/c5rsiMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAH0WKI+VPd8kPFmtK1rZ 0QEJRDNA== X-IronPort-AV: E=Sophos;i="5.92,262,1650945600"; d="scan'208";a="75498249" From: Anthony PERARD To: CC: Anthony PERARD , G.R. , Wei Liu , Juergen Gross Subject: [XEN PATCH] libxl: Check return value of libxl__xs_directory in name2bdf Date: Mon, 11 Jul 2022 11:38:47 +0100 Message-ID: <20220711103847.21276-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain libxl__xs_directory() can potentially return NULL without setting `n`. As `n` isn't initialised, we need to check libxl__xs_directory() return value before checking `n`. Otherwise, `n` might be non-zero with `bdfs` NULL which would lead to a segv. Reported-by: "G.R." Fixes: 57bff091f4 ("libxl: add 'name' field to 'libxl_device_pci' in the IDL...") Signed-off-by: Anthony PERARD --- Hi G.R., you've reported a segv in name2bdf(), and that the only potential segv I've found. I hope it's the same one as you've experienced! --- tools/libs/light/libxl_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 96f88795b6..f4c4f17545 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -859,7 +859,7 @@ static int name2bdf(libxl__gc *gc, libxl_device_pci *pci) int rc = ERROR_NOTFOUND; bdfs = libxl__xs_directory(gc, XBT_NULL, PCI_INFO_PATH, &n); - if (!n) + if (!bdfs || !n) goto out; for (i = 0; i < n; i++) { -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:40:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:40:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365021.595047 (Exim 4.92) (envelope-from ) id 1oAqqB-0004cg-Ny; Mon, 11 Jul 2022 10:40:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365021.595047; Mon, 11 Jul 2022 10:40:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqqB-0004cZ-Ka; Mon, 11 Jul 2022 10:40:35 +0000 Received: by outflank-mailman (input) for mailman id 365021; Mon, 11 Jul 2022 10:40:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqqA-0004cL-3N for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:40:34 +0000 Received: from mail.skyhub.de (mail.skyhub.de [2a01:4f8:190:11c2::b:1457]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2d6b493-0105-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 12:40:31 +0200 (CEST) Received: from zn.tnic (p200300ea970ff601329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:970f:f601:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 964B31EC0518; Mon, 11 Jul 2022 12:40:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2d6b493-0105-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657536026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=DQveIvP21h/SanKF+N0Kr1ZyhDAmgYuWOYIW71suvFg=; b=CnP+YTdQFXXeMz4yz7lRKZrtDOotgh/qmneigxkyjFPzRx22eIHesEikobYkfzhA0eFGHx bgWLcABXTonqdCSQS/VeaNriU3qJ60lGziMlFEFviVrJ4ncqEsKyuMs/HXtUf2QXs9ucao boRyB8MdlK+myKDMfvTxFNaK5ZPE7Hk= Date: Mon, 11 Jul 2022 12:40:26 +0200 From: Borislav Petkov To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Message-ID: References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Jul 07, 2022 at 08:38:44AM +0200, Jan Beulich wrote: > Well, right now the pvops hook for Xen swallows #GP anyway (wrongly > so imo, but any of my earlier pointing out of that has been left > unheard, despite even the code comments there saying "It may be worth > changing that"). Oh great. ;-\ > The point is therefore that after writing PAT, it would need reading > back. In which case it feels (slightly) more clean to me to avoid the > write attempt in the first place, when we know it's not going to work. X86_FEATURE_XENPV check then. > If I may ask - doesn't this mean this patch, in its current shape, is > already a (small) step in that direction? In any event what you say > doesn't sound to me like a viable (backportable) route to addressing > the regression at hand. Backportable to where? To whatever tree has bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") ? If it is that, then 5.17 and newer. Anyway, I don't mind it as long as you put the proper splitting out ontop and it all goes as a single patchset, with the minimal fix CC:stable and queued first. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:44:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:44:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365028.595058 (Exim 4.92) (envelope-from ) id 1oAqtl-0005Gi-7G; Mon, 11 Jul 2022 10:44:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365028.595058; Mon, 11 Jul 2022 10:44:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqtl-0005Gb-3C; Mon, 11 Jul 2022 10:44:17 +0000 Received: by outflank-mailman (input) for mailman id 365028; Mon, 11 Jul 2022 10:44:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqtj-0005GV-S7 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:44:15 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 67fa3212-0106-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 12:44:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 218D220329; Mon, 11 Jul 2022 10:44:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC38913322; Mon, 11 Jul 2022 10:44:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id CEPRN/3+y2IRYAAAMHmgww (envelope-from ); Mon, 11 Jul 2022 10:44:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 67fa3212-0106-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657536254; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fNY2tzMpecI/Es63WOyi5BWI9B0cLSfSQLp3+4IlGPg=; b=F/iwf41xOHBS02am2XFkipnVqbzEkMAtw6Xoia4RVAIOPExFPe3f3zv99MKp9zB4AZ6NIA +9fFwtDK4eP9eoVhEJSq6VQx+UywHtH3quGCpYin1YGmWb0rS1ISCpyZo6WoX0mf6/S2S4 qTxQcePTk5bOp3MNukqhkwQSAm6FIRI= Message-ID: <490ef2d3-98e3-42f9-84e9-cf2122b14472@suse.com> Date: Mon, 11 Jul 2022 12:44:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH] libxl: Check return value of libxl__xs_directory in name2bdf Content-Language: en-US To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: "G.R." , Wei Liu References: <20220711103847.21276-1-anthony.perard@citrix.com> From: Juergen Gross In-Reply-To: <20220711103847.21276-1-anthony.perard@citrix.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------lAlZYpRiOY7rvg3t1TwCzJYV" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------lAlZYpRiOY7rvg3t1TwCzJYV Content-Type: multipart/mixed; boundary="------------Duz7u0ji8E8bnqoM7exFYdBF"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD , xen-devel@lists.xenproject.org Cc: "G.R." , Wei Liu Message-ID: <490ef2d3-98e3-42f9-84e9-cf2122b14472@suse.com> Subject: Re: [XEN PATCH] libxl: Check return value of libxl__xs_directory in name2bdf References: <20220711103847.21276-1-anthony.perard@citrix.com> In-Reply-To: <20220711103847.21276-1-anthony.perard@citrix.com> --------------Duz7u0ji8E8bnqoM7exFYdBF Content-Type: multipart/mixed; boundary="------------t3RRTQa1sGj3M0FRwJJ0rSb1" --------------t3RRTQa1sGj3M0FRwJJ0rSb1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTI6MzgsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBsaWJ4bF9feHNf ZGlyZWN0b3J5KCkgY2FuIHBvdGVudGlhbGx5IHJldHVybiBOVUxMIHdpdGhvdXQgc2V0dGlu ZyBgbmAuDQo+IEFzIGBuYCBpc24ndCBpbml0aWFsaXNlZCwgd2UgbmVlZCB0byBjaGVjayBs aWJ4bF9feHNfZGlyZWN0b3J5KCkNCj4gcmV0dXJuIHZhbHVlIGJlZm9yZSBjaGVja2luZyBg bmAuIE90aGVyd2lzZSwgYG5gIG1pZ2h0IGJlIG5vbi16ZXJvDQo+IHdpdGggYGJkZnNgIE5V TEwgd2hpY2ggd291bGQgbGVhZCB0byBhIHNlZ3YuDQo+IA0KPiBSZXBvcnRlZC1ieTogIkcu Ui4iIDxmaXJlbWV0ZW9yQHVzZXJzLnNvdXJjZWZvcmdlLm5ldD4NCj4gRml4ZXM6IDU3YmZm MDkxZjQgKCJsaWJ4bDogYWRkICduYW1lJyBmaWVsZCB0byAnbGlieGxfZGV2aWNlX3BjaScg aW4gdGhlIElETC4uLiIpDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRo b255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8 amdyb3NzQHN1c2UuY29tPg0KDQoNCkp1ZXJnZW4NCg== --------------t3RRTQa1sGj3M0FRwJJ0rSb1 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------t3RRTQa1sGj3M0FRwJJ0rSb1-- --------------Duz7u0ji8E8bnqoM7exFYdBF-- --------------lAlZYpRiOY7rvg3t1TwCzJYV Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLL/v0FAwAAAAAACgkQsN6d1ii/Ey/x nwf+IRMtHgSpJ7w7Tj1C4yvqDNNoxfzLXYUSkvBnqcSplc76Pqpee9HwoUt885jfrMwmB/+h1dq0 N6Xws1uV3KEpOV2efZTiMgkVWnSc8d6JyxdCfTnjE2qBqFEnKsYzypZoYpfDm47joXPWXfF8CUdv c8Otn6OwVkJvq3XLO71h2cEX0KrBGu+c76m2UlCvJ9YYGWP8jD1UT/rBLbpZzhmOQOPQjM5/NFWj JUt0nx4+1OF6Nd/51QlvCX3TTCOot8kMPz7fSlziB+X74vpiemP+KKPaHgbTn8LzMZeaC4vecWCh omfNLDoNkuXH1WvzLkjJIPdGHuDxjDrmrtTTe4uAeQ== =uFRv -----END PGP SIGNATURE----- --------------lAlZYpRiOY7rvg3t1TwCzJYV-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:50:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:50:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365039.595069 (Exim 4.92) (envelope-from ) id 1oAqzw-0006qk-0T; Mon, 11 Jul 2022 10:50:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365039.595069; Mon, 11 Jul 2022 10:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqzv-0006qd-Sy; Mon, 11 Jul 2022 10:50:39 +0000 Received: by outflank-mailman (input) for mailman id 365039; Mon, 11 Jul 2022 10:50:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAqzu-0006qX-9R for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:50:38 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c019064-0107-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 12:50:37 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BC6032284D; Mon, 11 Jul 2022 10:50:36 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7170B13322; Mon, 11 Jul 2022 10:50:36 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h3jmGXwAzGLdYgAAMHmgww (envelope-from ); Mon, 11 Jul 2022 10:50:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c019064-0107-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657536636; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IRr+ub8cB+llrj9b1Eu7Fe4+2ipE6S2QVXMNVbgFoSU=; b=l0mJ599vWK19JNh7qXa7zc+1pH4yenMnZZnSDc4ydvpu3xxT1X600e11WEeJfKzeMp+fOP MJmkWbEwdxu4t/5Rh9xfE3agcge0qCQUKk+NIhB1dfgy4MokQreuk2u9YLf/m2B22BYm2t xTh2rscl2M8yzzuHU31agE7ZFs9NR6w= Message-ID: <2e49ac6b-d234-27d6-5b6b-767365a1f474@suse.com> Date: Mon, 11 Jul 2022 12:50:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v6 5/9] xen: generate hypercall interface related code Content-Language: en-US To: Jan Beulich , Anthony Perard Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220324140139.5899-1-jgross@suse.com> <20220324140139.5899-6-jgross@suse.com> <48f157d0-ed5d-b584-fcff-1425c137335a@suse.com> From: Juergen Gross In-Reply-To: <48f157d0-ed5d-b584-fcff-1425c137335a@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------DBau36QdcOftjL5AQ00BLMVF" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------DBau36QdcOftjL5AQ00BLMVF Content-Type: multipart/mixed; boundary="------------nbAXcKk0XmqMDe0JblD0MF4W"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Anthony Perard Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org Message-ID: <2e49ac6b-d234-27d6-5b6b-767365a1f474@suse.com> Subject: Re: [PATCH v6 5/9] xen: generate hypercall interface related code References: <20220324140139.5899-1-jgross@suse.com> <20220324140139.5899-6-jgross@suse.com> <48f157d0-ed5d-b584-fcff-1425c137335a@suse.com> In-Reply-To: <48f157d0-ed5d-b584-fcff-1425c137335a@suse.com> --------------nbAXcKk0XmqMDe0JblD0MF4W Content-Type: multipart/mixed; boundary="------------Dpwu2SdrMXWTjzXD9wFosHwN" --------------Dpwu2SdrMXWTjzXD9wFosHwN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTI6MTgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAyNC4wMy4yMDIy IDE1OjAxLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gLS0tIGEveGVuL2luY2x1ZGUvTWFr ZWZpbGUNCj4+ICsrKyBiL3hlbi9pbmNsdWRlL01ha2VmaWxlDQo+PiBAQCAtNzcsNiArNzcs MTggQEAgJChvYmopL2NvbXBhdC94bGF0Lmg6ICQoYWRkcHJlZml4ICQob2JqKS9jb21wYXQv LnhsYXQvLCQoeGxhdC15KSkgJChvYmopL2NvbmZpZy8NCj4+ICAgCWNhdCAkKGZpbHRlciAl LmgsJF4pID4kQC5uZXcNCj4+ICAgCW12IC1mICRALm5ldyAkQA0KPj4gICANCj4+ICtxdWll dF9jbWRfZ2VuaHlwID0gR0VOICAgICAkQA0KPj4gK2RlZmluZSBjbWRfZ2VuaHlwDQo+PiAr ICAgIGF3ayAtZiAkKHNyY3RyZWUpL3NjcmlwdHMvZ2VuX2h5cGVyY2FsbC5hd2sgPCQ8ID4k QA0KPj4gK2VuZGVmDQo+PiArDQo+PiArYWxsOiAkKG9iaikveGVuL2h5cGVyY2FsbC1kZWZz LmgNCj4+ICsNCj4+ICskKG9iaikveGVuL2h5cGVyY2FsbC1kZWZzLmg6ICQob2JqKS9oeXBl cmNhbGwtZGVmcy5pICQoc3JjdHJlZSkvc2NyaXB0cy9nZW5faHlwZXJjYWxsLmF3ayBGT1JD RQ0KPj4gKwkkKGNhbGwgaWZfY2hhbmdlZCxnZW5oeXApDQo+PiArDQo+PiArdGFyZ2V0cyAr PSB4ZW4vaHlwZXJjYWxsLWRlZnMuaA0KPj4gKw0KPj4gICBpZmVxICgkKFhFTl9UQVJHRVRf QVJDSCksJChYRU5fQ09NUElMRV9BUkNIKSkNCj4+ICAgDQo+PiAgIGFsbDogJChvYmopL2hl YWRlcnMuY2hrICQob2JqKS9oZWFkZXJzOTkuY2hrICQob2JqKS9oZWFkZXJzKysuY2hrDQo+ PiBAQCAtMTMyLDMgKzE0NCw0IEBAIGFsbDogbGliLXg4Ni1hbGwNCj4+ICAgZW5kaWYNCj4+ ICAgDQo+PiAgIGNsZWFuLWZpbGVzIDo9IGNvbXBhdCBjb25maWcgZ2VuZXJhdGVkIGhlYWRl cnMqLmNoayB4ZW4vbGliL3g4Ni9jcHVpZC1hdXRvZ2VuLmgNCj4+ICtjbGVhbi1maWxlcyAr PSB4ZW4vaHlwZXJjYWxsLWRlZnMuaCBoeXBlcmNhbGwtZGVmcy5pDQo+IA0KPiBJJ3ZlIGNv bW1pdHRlZCB0aGlzIGFzLWlzICh3aXRoIGp1c3QgZnV6eiBzdWl0YWJseSByZXNvbHZlZCks IGRlc3BpdGUNCj4gYmVpbmcgdW5jZXJ0YWluIHdoZXRoZXIgeGVuL2h5cGVyY2FsbC1kZWZz LmggLSBiZWluZyBwYXJ0IG9mIHRhcmdldHMgLQ0KPiBhY3R1YWxseSBuZWVkcyBlbnVtZXJh dGluZyBoZXJlIChhbnltb3JlKS4NCg0KV2l0aG91dCBpdCBiZWluZyBlbnVtZXJhdGVkICJt YWtlIGNsZWFuIiB3aWxsIHN0aWxsIHJlbW92ZSBpdC4gU28gaXQgaXMNCm9idmlvdXNseSBu b3QgbmVlZGVkLg0KDQpTZW5kaW5nIGEgcGF0Y2ggLi4uDQoNCg0KSnVlcmdlbg0KDQo= --------------Dpwu2SdrMXWTjzXD9wFosHwN Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------Dpwu2SdrMXWTjzXD9wFosHwN-- --------------nbAXcKk0XmqMDe0JblD0MF4W-- --------------DBau36QdcOftjL5AQ00BLMVF Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLMAHwFAwAAAAAACgkQsN6d1ii/Ey8/ rwf+IqOwuOCCv5p+2aFUbrR4ExWRmihbGd/NvoFVVLFuIWWBzALBzGbgbN5hHHknqP5YpxQ0yenv Esd5ExQ4ZjMMFlQRilJHActELmdsIXBxVY/ovgkPypxVFM3RuMwagmtOIkO5xWqvwdG4oMiVV3iy WSTytUmljLWNmqjYFWop7EMgtmG+ZZQcIENTfsJYiPp6l7Dpxb8Erw8INw+i6+XKMP6ueKT9IRzQ r/iqPXUx3F2vtSbnNubYA8p2caE4p9yRm99Rq91xRKnGsv62aYxi32YF04NmfrulFcaeyFtOXm6F DUdbg4z1zEnppFybaUTbwgp+gGmUf2EWPE4jXYDgLA== =7En2 -----END PGP SIGNATURE----- --------------DBau36QdcOftjL5AQ00BLMVF-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 10:58:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 10:58:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365045.595079 (Exim 4.92) (envelope-from ) id 1oAr7l-0007cV-Oy; Mon, 11 Jul 2022 10:58:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365045.595079; Mon, 11 Jul 2022 10:58:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAr7l-0007cO-M8; Mon, 11 Jul 2022 10:58:45 +0000 Received: by outflank-mailman (input) for mailman id 365045; Mon, 11 Jul 2022 10:58:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAr7j-0007cI-Vv for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 10:58:43 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d90824e-0108-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 12:58:42 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 6A6C61FED0; Mon, 11 Jul 2022 10:58:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1C7B913322; Mon, 11 Jul 2022 10:58:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id z4+FBWICzGJfZgAAMHmgww (envelope-from ); Mon, 11 Jul 2022 10:58:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d90824e-0108-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657537122; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Jds5BRsfjOadmDwPclKxAiyMARYTIfOKkjIJkyT3rWg=; b=A1slG4u2uwkhEyuZIrCcUuJLLawHiSAlwVo51usOk1ObNmgA6CPif2GJ1kE/D5MTh4Cwdb k7aKJxLD1Y6NMGiaSy70yISPXAPcnNeKy+xfJQlGakSmUtDBzX8ENpLWconq7T/H6VrtTv IMOVl9QHCS/PzbzDrzEzZBIODfBeuP4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard Subject: [PATCH] xen/build: remove unneeded enumeration in clean-files Date: Mon, 11 Jul 2022 12:58:40 +0200 Message-Id: <20220711105840.10533-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enumerating a file from $(targets) in $(clean-files) isn't needed. Remove xen/include/xen/hypercall-defs.h from $(clean-files). Reported-by: Jan Beulich Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") Signed-off-by: Juergen Gross --- xen/include/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/include/Makefile b/xen/include/Makefile index 39d9f5556c..fa0d454ab7 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -225,4 +225,4 @@ all: lib-x86-all endif clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h -clean-files += xen/hypercall-defs.h hypercall-defs.i +clean-files += hypercall-defs.i -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Mon Jul 11 11:24:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 11:24:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365053.595091 (Exim 4.92) (envelope-from ) id 1oArW7-0002aa-O8; Mon, 11 Jul 2022 11:23:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365053.595091; Mon, 11 Jul 2022 11:23:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oArW7-0002aT-LI; Mon, 11 Jul 2022 11:23:55 +0000 Received: by outflank-mailman (input) for mailman id 365053; Mon, 11 Jul 2022 11:23:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oArW6-0002aN-G2 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 11:23:54 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00054.outbound.protection.outlook.com [40.107.0.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f17613bc-010b-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 13:23:52 +0200 (CEST) Received: from AM6PR10CA0001.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::14) by HE1PR0801MB1721.eurprd08.prod.outlook.com (2603:10a6:3:7f::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Mon, 11 Jul 2022 11:23:48 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:89:cafe::e4) by AM6PR10CA0001.outlook.office365.com (2603:10a6:209:89::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 11:23:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 11:23:47 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Mon, 11 Jul 2022 11:23:46 +0000 Received: from da329d17446c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D645E9D0-1D26-4EF3-82D5-C8B72EA2F4C8.1; Mon, 11 Jul 2022 11:23:40 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da329d17446c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 11:23:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DBBPR08MB5995.eurprd08.prod.outlook.com (2603:10a6:10:20b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 11:23:39 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 11:23:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f17613bc-010b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SG/M3MzvSJad01372ym8tIkffaRwkIzuwkln/rURJ76+BTqSRyacbY1em2/EPqqYQSOdRixUKWPFWYt13f+lRBd34Edah6fmYa009DZD1MS4dTbm0xqeT48tVjEM7HZo709VI6I1+GNXi4dYkoIi4dd8ORWCZ8+CbOAkc2cWMZJbHt57/ueuOPcJA7kRGBzkwdlePE2ibhpmPfdJ2SPTE+62XnDQ9M9f9MzXYgXjPV49h0EdEtxc9pPbBoDi91dvUPQvhXb1k6K/TJEmjFR5IsxNZH7T5tfzxJ6u1JdyPXgWN78WJI03jwVjw/twWVh/z7gN89u9jkcQ4/Ng+LrynQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vN/GkaxPwYjGzD08RCc4EsgGEq81YgTeTdA1sugD3YA=; b=OyRH0Rqo3eBdJPJ8cUCsL2Z7p/+p/oUMDdJ4D4NDHqKNQG8pfbXrgsCN8rtQwUc3NYXPPYZLPUJRKM2UkUKDKdV9Brzu02cJWZgjkD+D4PUhcVb5MBe58kmR/89Ps14p+0NFMjoAwPNtAOzTwoGP37rmCQDION85131INV7Tp+TbplJgCk4IhQO3V+uW5OZ3aUcpudtZFkw7bRu+ByYvuR8uCItg5R0hcVBqere8V7vfv5M+9yb3fS2ktBeXtefrQJ4820KM0HUOnZS7gAuLajKct/pbbSmHfqP9PU/85l3LBf8ezFAXSSH6pU0Ir3Nj3oGr5fKbjHLMzGUXyxspdw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vN/GkaxPwYjGzD08RCc4EsgGEq81YgTeTdA1sugD3YA=; b=Ze6lglozyWWNgM9E41FhToHJgj1/tAy851MHFenWAMnckKTfg2Vpk3EM2gzUQXsGj2osKbWrO8py0LSHnzCbKGThD0hhsKC0Qfi3mU4gJsVocL78zcZvaEzbVgWG9KGFN2nX6X3zvnI8xlI6nD+cOoay0hEYH17t66EONxiZuAo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2816708d7d24dbd5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mQ7qo11Vv3ekMvdAsGPL1aggKgPQZV8bJYbRtEFESCiMwhQWN6A6JNgDCXMkPhOsvgULoBGBj4Ssr5k7kt8XgKbV98mUglyMDLccPknaIjGt/DBoHbxHJq/QpYLne/BnhSgxJEh6ue7YD7mf6CfTj10sYrY0pwAMcaILKYId7Xu+FU9MVekGwQjgnaxZ+sD7UWFb5wCfDxlQpRItfKAVXXPWLtaPBtfC4LCsT/Vrj7aOUzvTSHRQkXuQ7kuUrfU6h/yw3QCKvhobdK2xnHIyNJp+i614k90iH8IutXX1qCM+vuDUppIRC8WDGU7cFqa39c7hV1uPT4t7H8qsWASAnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vN/GkaxPwYjGzD08RCc4EsgGEq81YgTeTdA1sugD3YA=; b=W9XKsgBDVqeVnYKlvyEmiQ0L4Dg7cuAM3n/EljXZ9/Ur3xQU2wuf3d0Dd7nLz/Xx5BVFX93SkAZNjR+yBZQ54u+fnAMPUpej/vTRFXWTD/e6RPpN8M03bKyYJLq+PzBrxVV78pc05TYu61htoxj+tRedVuxfOhW6JJ7HsvVtun9a+JkjaEaWHYG7jmYfkyM+DpxRVGlihMup1IeQRqaqSsKXwzfvcMSO/bkQUJwFwSfSfAIkTeFq7ECetpGBkIASAVEloUUyWS28SlO3P5LX7Irpq0Ro4hYEixbhenSQUsAcWkPYnuRTcYy+LhJQnlOw1hvIfAQJ5tYbN9UKdP69Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vN/GkaxPwYjGzD08RCc4EsgGEq81YgTeTdA1sugD3YA=; b=Ze6lglozyWWNgM9E41FhToHJgj1/tAy851MHFenWAMnckKTfg2Vpk3EM2gzUQXsGj2osKbWrO8py0LSHnzCbKGThD0hhsKC0Qfi3mU4gJsVocL78zcZvaEzbVgWG9KGFN2nX6X3zvnI8xlI6nD+cOoay0hEYH17t66EONxiZuAo= From: Luca Fancellu To: Anthony PERARD CC: Xen development discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH v3 05/25] tools/fuzz/libelf: rework makefile Thread-Topic: [XEN PATCH v3 05/25] tools/fuzz/libelf: rework makefile Thread-Index: AQHYh+Q0lHdw/SdCmkaxRBiHWRqzfK15IYuA Date: Mon, 11 Jul 2022 11:23:39 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-6-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-6-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3c82c5f5-9db5-47c4-57cc-08da632fd2c6 x-ms-traffictypediagnostic: DBBPR08MB5995:EE_|VE1EUR03FT019:EE_|HE1PR0801MB1721:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: COgehf02xwHYMMIgxH9H7OkPAsT+Ahv998u+zhLKS7dvYy/CNWLD1MfS2yeolBvTz5BeX2gHZcYzYzEM0QUWxQHnvfM3JILw0BqV8ODCre3cBJ3NCVShwjQK/633XMfJrOZ1I0M5/US+JDyfB214jEnN+71VYxEiUCP2T31+cFr9jNFkoikLjDt70RnbToyBT717rpQPC3YnujwZ01havs1F5qUug9gWmZW7LMa8IykvJ+oR0ZezzkwjHM7v1joExQ/hn+AqT3yrQORzhR40F6v9SQvt8jwr7X+svqFO6EH2WFyXKPNTwaipZ/3h8BmP3B+PFfreiqcWYI/XSeJPw4Gl15apoE1aqV27ttIajj2lfknD3hjHl2OOz3rNUrThgPDqa4BdMwOMFQ9OOX8kM06y4vGO+c4togm+FP44MYJfUM2APTEsfRqxxfg2KprCcDrfhqQHDCAP4gHndLcg00DfqqLccJlYEIPm2DvDTouBqBhIA2ovWQaYiElY5lxfUJMIXHoad9b49kikETccLv0ZWPSjXBU2TKUTq2LKwn9KKkk7EltQ1GdONp14ahaXZLiqgK4rb1NPgKgw2Izv4TFzbjYEBXgyly+ld6m7TYH85WRv00e9uIJl7no9Gxh/rBTz4eFoyMksQrlWOe3MPweXceOGjtVl0zt7/ervNpVDV6Irz444cErQrbkwfiCj3GjewXSTyhDMIzjfaHQGuW2rUJXSqYiEZ10xAV1BJM9jezk5GGab6tWWJ7/MbbX8gsyv96TkWxeyzEBt0nswKM5AlsZ0lIi8oDjN1YszarvnMc3AKRrm0VLfuSUJw/PFGNP52kXxt19N4NMMtSpn4OHh1L5qbamkc1q2F9igzec= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(38100700002)(122000001)(186003)(5660300002)(6916009)(4326008)(71200400001)(54906003)(66946007)(66556008)(36756003)(76116006)(64756008)(91956017)(8676002)(316002)(66446008)(66476007)(41300700001)(6486002)(6506007)(86362001)(2906002)(478600001)(8936002)(26005)(6512007)(33656002)(2616005)(38070700005)(4744005)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <65436ACC19D9BA40A6BFEAFBBB523A0F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5995 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 91a25d4f-236f-4375-eb42-08da632fcdab X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1cOkul7gerVdVN05jG+/d+WaV8zGzDMRicwpByAYoyUyyss1z+UIK2TQs+6PVZXR5YpdfLcHCx7C+dtSQ6aFylXJ+s0CxTraMELRDDPdypKuUYKo8lu8ijJ5/2DCUFESvEXga8Fh4OdCf2uB+lP0XjiKN7qGt28xnxkKzp2ZVSJiY3NigUoMKFiWoN2WnaEcGqOLTqD2YTB0rZzOE5FsXttOk2fUuYQ0lU/WjkHPqeKQXp3h5cyzu3F93+JQkkI7CKvALMKidWwluZrRazFPaj6Tyiqh4D5oUJL/fVGV32IXmxnTWZ0iOHK8onjctOI6hgJUyiHYGmcus3xsayrPVmvSfFiGWvPFw4Ie6DNEyk74kYC2BOObEZHd3bLu9/aYie1pqe1deORsPgocko3mfU2a1iwaLtgLSSeC8j8tGKuTbm7yP9buxJDVA0rAhI9xG3ujnX5XoGt8pOWVRYJy/CJqvLzPS9rEFLG/Ziayi7jnz64/Oo2IRP7MBTJTuFX3Qdfg4EARjIZrubrMRaTn9HZA+nI5Md/wBx/eF5Y04zAeY5CBO6RPZWMpZkZ4VaevKocsNyDlQ8wfXc63+cLzLOGIi33n9gmz2Zb/uQAtFgNJqu4W/+RRngf0qX2X00uZYQYE0/VVnWyD9ZeM4rij/JNihBV+ByyCjWCZrv3LrtBY6KNsniNIi98vtdcOnwj3t8Day99/7ND2LOqUB8ftINRy2+xeuPBt1X9+IblDUupV+AJpxRGSQ6mKFJVtm96VD3v06SmpCIzm9xN7OXeYcZtyfocdRId/lBS2cF0iaSKWz0b6hNm657OMCtJVMC/V X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(396003)(346002)(36840700001)(40470700004)(46966006)(36860700001)(2906002)(36756003)(6486002)(41300700001)(316002)(40460700003)(8936002)(33656002)(40480700001)(6862004)(4744005)(4326008)(70206006)(81166007)(5660300002)(82740400003)(6512007)(186003)(8676002)(53546011)(336012)(356005)(70586007)(6506007)(86362001)(54906003)(47076005)(2616005)(26005)(478600001)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 11:23:47.6125 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c82c5f5-9db5-47c4-57cc-08da632fd2c6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1721 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBSZW5hbWUgRUxGX0xJQl9PQkpTIHRvIExJ QkVMRl9PQkpTIGFzIHRvIGhhdmUgdGhlIHNhbWUgbmFtZSBhcyBpbg0KPiBsaWJzL2d1ZXN0Ly4N Cj4gDQo+IFJlcGxhY2UgIi1JIiBieSAiLWlxdW90ZSIuDQo+IA0KPiBSZW1vdmUgdGhlIHVzZSBv ZiAidnBhdGgiLiBJdCB3aWxsIG5vdCB3b3JrcyB3aGVuIHdlIHdpbGwgY29udmVydCB0aGlzDQo+ IG1ha2VmaWxlIHRvIHN1YmRpcm1rLiBJbnN0ZWFkLCB3ZSBjcmVhdGUgc3ltbGlua3MgdG8gdGhl IHNvdXJjZSBmaWxlcy4NCj4gDQo+IFNpbmNlIHdlIGFyZSBjcmVhdGluZyBhIG5ldyAuZ2l0aWdu b3JlIGZvciB0aGUgbGlua3MsIGFsc28gbW92ZSB0aGUNCj4gZXhpc3RpbmcgZW50cnkgdG8gaXQu DQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0 cml4LmNvbT4NCj4g4oCUDQpIaSBBbnRvbnksDQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1 IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 11 11:38:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 11:38:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365059.595102 (Exim 4.92) (envelope-from ) id 1oArkW-0004IL-16; Mon, 11 Jul 2022 11:38:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365059.595102; Mon, 11 Jul 2022 11:38:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oArkV-0004IE-UT; Mon, 11 Jul 2022 11:38:47 +0000 Received: by outflank-mailman (input) for mailman id 365059; Mon, 11 Jul 2022 11:38:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oArkU-0004I8-L4 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 11:38:47 +0000 Received: from sonic312-23.consmr.mail.gq1.yahoo.com (sonic312-23.consmr.mail.gq1.yahoo.com [98.137.69.204]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 040065c4-010e-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 13:38:44 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Mon, 11 Jul 2022 11:38:41 +0000 Received: by hermes--production-bf1-58957fb66f-dd4hs (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 8f307d8659d7a819d3d711f175c166e1; Mon, 11 Jul 2022 11:38:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 040065c4-010e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657539521; bh=w/ukMm5iwQWAeG3BAhYL3RaptUVhXqOYbZbqYfz4OBM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=sigCv5NtbCmuRMFy8E9TL10fWV6Mh6L/vwwQTQzX/S4+tju4GRDtGa5QKcHjQ6efV82JsKcLjJqsKtIU/oOZv7nURu2iW7ehYTlG12JSSZCmCQwA8UD4oOxvEJK59LW9w3erLeZ3sxBOFgHkNyat4pNRCrsORwMafAMgG0TCBsYaAV8EM2sJTYbJfIpmsxu6bNOpWHjagHX4j1sySB8Rife2POZjuVAiLVVcONsdJfoxZXs93yNP5JaE73yyrf+XxlAUn/6/CQKi1mcqE+LcYtOlg34L8qsW0cA2WrsbG7T72q4d10Q7d+s4GX/fttnnzJv26l65jk2obmkuEPpaag== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657539521; bh=mGozHT5h7zDYiUQg4KfZcbWrKhfFoSRR5f34X62/Xhn=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=kWCMBTqGUo34tUjsJTDbrjJxNVoKXiTyjOejeuiioasfOcRPe6QUoXITih8zqmrb2at9+lEg2TAQmtCGgARANfvA+h4R6gKmRCXmq2KA8hl8sRxTxPzPgGq1M73RVqMAAFN08gz1zXcNHXA1D9oBGgHi50mYjuDpwNjyglHjZ4OeCFcJiomxeb0I79TFOdfaqVHLi9gz0etLsk/ZO7VbDSH2D08O29kjz9H4cbP/NeP2m+fvBCm/zHIR4jyuV8QpQn1gE/6XPMIUiOYMxmmwNpbbQ3nSllqUYX4QcHKEQUiXoYu7ZmR1hyNXlHlEhO50OZS4JT1GZI7GpzB5EEgdKw== X-YMail-OSG: Ynrj1a0VM1kbZ5mDA11QppCioN22lv89ZLTgz652Y2gBXOBdaO2Ji8sovCmqZbY 6imIkVY.eDlrBXJAE_1uEP6r2gqGKo1tDMyhcdY4G6QAn99sg50AdupHfuIPmAMxaFtGhIeXoEvJ 7AzWY58U527WHrLDwGeW5iL2orK.mj2s4Z4OvRpqgEUd458LWFoRRYmtd9fZDF5eOZCoI8khhy18 ZPUXun.g.1cu8guQe13v9Au0.KfL88tskR8YQM4OLs3iV8cWi6_vz8ROAKre_D14Xq5JfGb6.OlZ FapNeA9h.Fy8stJa3i5lY9C5b7PXPKBPPIhbTfI9SgzMsEiucFl0gejFBRpkUJzu.queVDIemSFT aHbSbSZL5PDuiSu5mrgbHhAtTbxbjZV_FUMWY_nJjC0JU.p3EQxIlAQSEB4TnHcYDnpAiGWfZ3o8 Aq2GtUq.x4qh0_qbj9iamuh2ZJp7J7W9Yl2PbHhtnaWE09vjhHJld47UPzFiPu6KsWIdWcOy17rN uspch7iGYEzRA_u1xZ8c39SZ03j3hSUV3hFeJvNPVd91cwvxNYq3QpYf7Klavfst4eZ3.yoJ71Xj VCNmM1eZ5InzpZpJcmBrT1PXa7cFV1p8wV8_Ud7HT.5sblvmwceogARlmik69EBSlhLmgJL0_ulv PyD44AgyM8Aus2mWIcddCiaBsBoanuvs7_t_VS4xtcc6bCITtvY.hdjB5Kdp6YVS8kvM_DUfrSYN k5jPuqRymFZSnuV0.wac5o8TxLBHLSX9jOntUB2O1QNy7ix4cHwVylcqWB7NOtQ8CwV8QM0dqYbb Fb3V50c7Z7HX3X1trBm4AX9vOuIDaOBk78KlDVwvqvrDvATLrUE70pOdH0mwVtvM66XLhph6orOY XEs.KlO7jI3oqIReZu8ir5t3o.ZhggtnPPl01U_3XVXK03gW6scacUra4kTWpXWqMsUWH7YMMT1U Cw2jIyvsdcNcPABDcz77rrCC8wZjqtDVDwjWYn5qKNEfY6uXG7Vp9B9DM5ppTeGr9wmFY86q0mP2 D07IRDzL2e4ugzD8o6wsqQ03ur8YYA2FZiNeULlfPuNlAcQRh2iNtbTHUbiPFtKxQgf34K_UQkgp FyteWIYPN44G5N7_70Wci4n1P_RpA1mERVyQDHkuljrWo8rusonC8jQ3WiImXKa00MnVV0t4skS7 Z4b_4O3tJTClfYtEos2FFKBBwPQklkK5UK7xbZiwclKuNKqAigj8i3EQeaiI.0ZY3hCFkK9lB8y7 1pln1UVuL8M5iBGYWZAayOdW6uyc7nA.b8_VNPpIW2VBoWSTfgnvT91ttorEfjCUHWHnEGQhtvSj NDy4NJB0hAi1LGJW3MQ8OeoElrZVAe9KjOoLzfBem4_7.7MTQnybyzSLEJhE.Dv0MWn2alNF9hPq IBV.pOoO5nd3ogRJ04L2J_I6FuIBV.9T_t2CyG45VZS3H6QbkXCgnX2VLr5AjE.DpOtwqDh_JYLw eL15IHGVVM0zEA3f89.VIk3RcMIPCU.yIQfxIPykQjU1G1JplkNL7dkx4vG2bN63UJ0VfutodKZ9 k_zIgLxkTr.ZKhzZ_qeYIYy.n6N_zrlYmVZgeKIt9JL74zgjR2hwNVtJxqNI47u4NNbNx6w3DvZj .OaWBZ7R74GZDy5PJKBVJnn6_0ndGjhxFgItWqVS2XZJ5dkgfB_0twyAB58i4VNgTeC03OKsMtBs 2i0P5xK1ErezWMXO1EwaTsA6n6IIeLEvlVk8j8OeSqBM21iBluQkE1f.XEu4lz0ZkSKSQ17pwTrx hvR0HG84kt9k5e8FfUKOFv0lWuoG_ccW6aBxbTff.tgjHKOb4tlOhmMgSlfUtPry90dqMPs5GPWc XjXJZyX5WQKa4_VEKxDSsHKwkUS81E3XVJq7HdSbMN9omI2v_3huY2jpZv9Snh4P0915qCqmoYpT MWMF7m.PAwEELGpC1pOTVsCzQ3TWNs_.OvL0ijcglGE9wD0BFfHQ9uH_1F57RqbpDS6lfJMhund3 2uZ2gFYCb5WQmw19wTRptXJeW9_2s0Ew7_thqFEe1hpgoqRjuSijXd9qvTUMkRS5c_FkRMUJN7ab cGxXBz_nQIj81552ETlipWpITEa5cDZqtvauaN7j0zZAIaUeKcbDmWRY7pkQGmvyPFjFYhzl62JC aCeB4zgV9wlA7J7juEFGmxDyXvmkOCOv19_y5O_JWlrDqUa.irJZG_A4trI2auXipXRVwts6zlj1 VfcVfk6de4Q-- X-Sonic-MF: Message-ID: Date: Mon, 11 Jul 2022 07:38:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4555 On 7/5/22 12:14 PM, Borislav Petkov wrote: > On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: > > Re-using pat_disabled like you do in your suggestion below won't > > work, because mtrr_bp_init() calls pat_disable() when MTRRs > > appear to be disabled (from the kernel's view). The goal is to > > honor "nopat" without honoring any other calls to pat_disable(). I think Jan is speaking of the narrow goal of the patch that is causing the regression at hand: Commit bdd8b6c98239cad3a976d6f197afc2c794d3cef8 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") The author of that commit expressed the desire to more readily handle the nopat option in Linux in an architecture-independent way. in the commit message. The patch was not intended to cause a functional change, but it did - it caused a regression in Xen Dom0s running certain Intel graphics devices. > > Actually, the current goal is to adjust Xen dom0 because: > > 1. it uses the PAT code > > 2. but then it does something special and hides the MTRRs > > which is not something real hardware does. > > So this one-off thing should be prominent, visible and not get in the > way. Actually, this is probably the most insightful comment in all the words that have been written about this regression. This is a one-off thing, peculiar to Xen PV, but it is not visible enough and gets overlooked when changes are made. I guess I agree it should not get in the way either, and it doesn't, except when the lack of visibility of this one-off thing causes the author of a patch to overlook it and cause unforeseen problems for users of Xen on Linux. That is precisely what happened five years ago with commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") Have you looked at that patch? That is the one that introduced the regression that causes pat_enabled() to return a false negative on Xen Dom0 today, and it hid in the code for four and a half years and was only exposed as a regression with commit bdd8b6c98239cad3a9 last December, which again was written in a way that caused the regression on Xen because this one-off thing that Xen does was not visible enough to the author of the recent patch from last December that exposed this problem as a regression with Xen PV domains and certain Intel graphics adpapters. That patch did not take into account this not-visible-enough Xen case when MTRR is disabled but PAT is still supported by the CPU in Xen PV domains. So the proper way to fix this regression is by fixing that commit from five years ago. It is very simple. After some code re-factoring and other changes, today that commit can be fixed by something like: --- a/arch/x86/mm/pat/memtype.c    2022-06-16 07:32:05.000000000 -0400 +++ b/arch/x86/mm/pat/memtype.c    2022-07-09 17:51:56.783050765 -0400 @@ -315,6 +315,20 @@                PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);      }   +    else if (!pat_bp_enabled) { +        /* +         * In some environments, specifically Xen PV, PAT +         * initialization is skipped because MTRRs are +         * disabled even though PAT is available. In such +         * environments, set PAT to enabled to correctly +         * indicate to callers of pat_enabled() that CPU +         * support for PAT is available. +         */ +        pat_bp_enabled = true; +        pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); +    } +      __init_cache_modes(pat);  }   Like Jan's approach, it implements the fix in init_cache_modes(), but unlike Jan's approach, it only sets pat_bp_enabled and pat_bp_initialized to true if boot_cpu_has(X86_FEATURE_PAT) is true and rdmsrl(MSR_IA32_CR_PAT, pat) returns a valid value. No need to check for a hypervisor, just check if the CPU supports PAT here and that PAT MSR returns something valid here. If both are true, then set pat_bp_enabled to true. Regression solved. And that leaves the bigger goal of dealing with this one-off thing that Xen does in a more sane way for another day. I am working on a patch series that attempts to start the process by first re-factoring the currently confusing pat_disable functions and variables that will hopefully make this one-off Xen thing more visible and easier to understand so when someone wants to play around with the current way of deciding whether or not PAT is enabled on X86, no regression will occur on Xen or in any other environment. Best Regards, Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:12:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:12:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365069.595113 (Exim 4.92) (envelope-from ) id 1oAsHK-0000LD-OU; Mon, 11 Jul 2022 12:12:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365069.595113; Mon, 11 Jul 2022 12:12:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsHK-0000L6-La; Mon, 11 Jul 2022 12:12:42 +0000 Received: by outflank-mailman (input) for mailman id 365069; Mon, 11 Jul 2022 12:12:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsHI-0000L0-QS for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:12:41 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1c45128-0112-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 14:12:39 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id dn9so8465620ejc.7 for ; Mon, 11 Jul 2022 05:12:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1c45128-0112-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=nTRT+XvoLmZyFBS9ZT/hZlO9oFkjTu8ilUIyvvo4P5U=; b=e72/LW3C62xDZsxNAUCJngRk/D2pUS72363cHsdZWnHUo8TLyt24sognz47ExuJgyG VLiienT09YmWUueSzkiZniz67eI/cZbrXZ53ZNx53ZlBP0n3joud7ZAXXgE0Ah18qWS0 s4vUBKTvxrhJzWrpwcZsC7sFkfNUR6aWeSeqH1TnQ0LVlXtU2JZWyF/RYY5wiiT9mWU9 NR+Jj3zFvXRcAxjZr/s2ycGS8NUcbEPX3k2kUbf4MQZecG8iNQC7BM68MzHWfn5d+7Co YoTykfHh44G/uG/8XayDPycaA8xrE22A0gJEDJ/SFgMhZ6squcJ3udbWDqfiupbfgyh2 /3oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=nTRT+XvoLmZyFBS9ZT/hZlO9oFkjTu8ilUIyvvo4P5U=; b=nVyZnjwnbdhoiFBCeE+W0KTPpPDDzOxRlfGAftNIhH3jZVsk8RmeU3Z80tMsBzI6WP NyFt7ix2xLWbl3JZq8MyOD95AZGa12NMjFr6bc0nwcxeqUR7UtHUwT/UNHheUHWO/9Wu pxuoIU2BfwbggnWuhAC+i+5L6DidvcS784GW2ZYgkWR3420T6BhrFK+g7o4PYTYiysZt p1LV5iqwH/C3c4EwrfvJKtH5mAnYoQ4HBtR+mEm/+yK+YSgiS1HEyfDNnwn+b9NkMcmN Pood0Re7lB/RE3g2kZcSnA3WVai60kYaLxrnWrATT3CmADbYjKNta2/SgpPh07IZxFH1 w2DQ== X-Gm-Message-State: AJIora9n3TpT/2OCxg00apaxMaHLUbVJrfHi1vF7k3pD5CRn30zzBg90 XVbQVcU/G3iZWgYFBa4DVe8+/HQyVKm9470lP7X6X1B69qY= X-Google-Smtp-Source: AGRyM1ueXzbRF75hXioHAVQ4PEaDlANe+MkONanAm8tQMA0Z09PolfEgkpA7PjJCDNW7fH+Rg8qSDnFTCMx5wXjZj60= X-Received: by 2002:a17:906:dc8f:b0:725:28d1:422d with SMTP id cs15-20020a170906dc8f00b0072528d1422dmr17845553ejc.131.1657541558625; Mon, 11 Jul 2022 05:12:38 -0700 (PDT) MIME-Version: 1.0 References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20f563b2-68e1-e429-f762-78474c566d04@suse.com> In-Reply-To: <20f563b2-68e1-e429-f762-78474c566d04@suse.com> From: Dmytro Semenets Date: Mon, 11 Jul 2022 15:12:27 +0300 Message-ID: Subject: Re: [PATCH 1/4] tools: remove xenstore entries on vchan server closure To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D0=BF=D0=BD, 11 =D0=B8=D1=8E=D0=BB. 2022 =D0=B3. =D0=B2 10:09, Juergen Gro= ss : > > On 09.07.22 12:10, dmitry.semenets@gmail.com wrote: > > From: Oleksandr Andrushchenko > > > > vchan server creates XenStore entries to advertise its event channel an= d > > ring, but those are not removed after the server quits. > > Add additional cleanup step, so those are removed, so clients do not tr= y > > to connect to a non-existing server. > > > > Signed-off-by: Oleksandr Andrushchenko > > --- > > tools/include/libxenvchan.h | 5 +++++ > > tools/libs/vchan/init.c | 23 +++++++++++++++++++++++ > > tools/libs/vchan/io.c | 4 ++++ > > tools/libs/vchan/vchan.h | 31 +++++++++++++++++++++++++++++++ > > 4 files changed, 63 insertions(+) > > create mode 100644 tools/libs/vchan/vchan.h > > > > diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h > > index d6010b145d..30cc73cf97 100644 > > --- a/tools/include/libxenvchan.h > > +++ b/tools/include/libxenvchan.h > > @@ -86,6 +86,11 @@ struct libxenvchan { > > int blocking:1; > > /* communication rings */ > > struct libxenvchan_ring read, write; > > + /** > > + * Base xenstore path for storing ring/event data used by the ser= ver > > + * during cleanup. > > + * */ > > + char *xs_path; > > }; > > > > /** > > diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c > > index c8510e6ce9..c6b8674ef5 100644 > > --- a/tools/libs/vchan/init.c > > +++ b/tools/libs/vchan/init.c > > @@ -46,6 +46,8 @@ > > #include > > #include > > > > +#include "vchan.h" > > + > > #ifndef PAGE_SHIFT > > #define PAGE_SHIFT 12 > > #endif > > @@ -251,6 +253,10 @@ static int init_xs_srv(struct libxenvchan *ctrl, i= nt domain, const char* xs_base > > char ref[16]; > > char* domid_str =3D NULL; > > xs_transaction_t xs_trans =3D XBT_NULL; > > + > > + // store the base path so we can clean up on server closure > > Please don't introduce new usages of the C++ comment style. Most comments in this file are C++ style since libvchan introduced > > > + ctrl->xs_path =3D strdup(xs_base); > > Return an error in case of strdup() failure? > > > + > > xs =3D xs_open(0); > > if (!xs) > > goto fail; > > @@ -298,6 +304,23 @@ retry_transaction: > > return ret; > > } > > > > +void close_xs_srv(struct libxenvchan *ctrl) > > +{ > > + struct xs_handle *xs; > > + > > + if (!ctrl->xs_path) > > + return; > > + > > + xs =3D xs_open(0); > > + if (!xs) > > + goto fail; > > + > > + xs_rm(xs, XBT_NULL, ctrl->xs_path); > > In this simple case I'd prefer > > if (xs) > xs_rm(xs, XBT_NULL, ctrl->xs_path); > > > + > > +fail: > > + free(ctrl->xs_path); > > No xs_close()? > > > Juergen From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:18:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:18:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365076.595123 (Exim 4.92) (envelope-from ) id 1oAsNC-00015A-F1; Mon, 11 Jul 2022 12:18:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365076.595123; Mon, 11 Jul 2022 12:18:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsNC-000153-BT; Mon, 11 Jul 2022 12:18:46 +0000 Received: by outflank-mailman (input) for mailman id 365076; Mon, 11 Jul 2022 12:18:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsNB-00014x-CN for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:18:45 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b6f5fea-0113-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 14:18:44 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id DDEDE226DB; Mon, 11 Jul 2022 12:18:43 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9A6D913524; Mon, 11 Jul 2022 12:18:43 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ke8JJCMVzGLNDQAAMHmgww (envelope-from ); Mon, 11 Jul 2022 12:18:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b6f5fea-0113-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657541923; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=coJAKtWro/QwaPzIMIZrthrprFLcSmPOp/3UjS6lE4U=; b=Ds3bq2YgWb+RQCUSXyxzEK2NU1ytQGx7sDtukh5f6m52m2QjuBM/85EVrEWw2BK9AbEMdq I4qIxsSRsp07bO4Y8Oqrc7prDZsiIDOPj3m7zB3OAm7vOdgjcR0TOF5ersl20JncITLQwj XaxlttVT9Gg8XCgY60G6z3i9hTdKafM= Message-ID: <55665843-dff0-1e71-762e-088089f49f16@suse.com> Date: Mon, 11 Jul 2022 14:18:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/4] tools: remove xenstore entries on vchan server closure Content-Language: en-US To: Dmytro Semenets Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20f563b2-68e1-e429-f762-78474c566d04@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CAdvAzzbZbSyA8wUsTIPCwMC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CAdvAzzbZbSyA8wUsTIPCwMC Content-Type: multipart/mixed; boundary="------------2qNJJd3iXHnjcZN5T4BZyvC1"; protected-headers="v1" From: Juergen Gross To: Dmytro Semenets Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets Message-ID: <55665843-dff0-1e71-762e-088089f49f16@suse.com> Subject: Re: [PATCH 1/4] tools: remove xenstore entries on vchan server closure References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20f563b2-68e1-e429-f762-78474c566d04@suse.com> In-Reply-To: --------------2qNJJd3iXHnjcZN5T4BZyvC1 Content-Type: multipart/mixed; boundary="------------WZ0yoirnOlporgh2V4bfPdOc" --------------WZ0yoirnOlporgh2V4bfPdOc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTQ6MTIsIERteXRybyBTZW1lbmV0cyB3cm90ZToNCj4g0L/QvSwgMTEg 0LjRjtC7LiAyMDIyINCzLiDQsiAxMDowOSwgSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2Uu Y29tPjoNCj4+DQo+PiBPbiAwOS4wNy4yMiAxMjoxMCwgZG1pdHJ5LnNlbWVuZXRzQGdtYWls LmNvbSB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyA8b2xla3Nh bmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+PiB2Y2hhbiBzZXJ2ZXIgY3Jl YXRlcyBYZW5TdG9yZSBlbnRyaWVzIHRvIGFkdmVydGlzZSBpdHMgZXZlbnQgY2hhbm5lbCBh bmQNCj4+PiByaW5nLCBidXQgdGhvc2UgYXJlIG5vdCByZW1vdmVkIGFmdGVyIHRoZSBzZXJ2 ZXIgcXVpdHMuDQo+Pj4gQWRkIGFkZGl0aW9uYWwgY2xlYW51cCBzdGVwLCBzbyB0aG9zZSBh cmUgcmVtb3ZlZCwgc28gY2xpZW50cyBkbyBub3QgdHJ5DQo+Pj4gdG8gY29ubmVjdCB0byBh IG5vbi1leGlzdGluZyBzZXJ2ZXIuDQo+Pj4NCj4+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2Fu ZHIgQW5kcnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+ Pj4gLS0tDQo+Pj4gICAgdG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hhbi5oIHwgIDUgKysrKysN Cj4+PiAgICB0b29scy9saWJzL3ZjaGFuL2luaXQuYyAgICAgfCAyMyArKysrKysrKysrKysr KysrKysrKysrKw0KPj4+ICAgIHRvb2xzL2xpYnMvdmNoYW4vaW8uYyAgICAgICB8ICA0ICsr KysNCj4+PiAgICB0b29scy9saWJzL3ZjaGFuL3ZjaGFuLmggICAgfCAzMSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrDQo+Pj4gICAgNCBmaWxlcyBjaGFuZ2VkLCA2MyBpbnNl cnRpb25zKCspDQo+Pj4gICAgY3JlYXRlIG1vZGUgMTAwNjQ0IHRvb2xzL2xpYnMvdmNoYW4v dmNoYW4uaA0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNo YW4uaCBiL3Rvb2xzL2luY2x1ZGUvbGlieGVudmNoYW4uaA0KPj4+IGluZGV4IGQ2MDEwYjE0 NWQuLjMwY2M3M2NmOTcgMTAwNjQ0DQo+Pj4gLS0tIGEvdG9vbHMvaW5jbHVkZS9saWJ4ZW52 Y2hhbi5oDQo+Pj4gKysrIGIvdG9vbHMvaW5jbHVkZS9saWJ4ZW52Y2hhbi5oDQo+Pj4gQEAg LTg2LDYgKzg2LDExIEBAIHN0cnVjdCBsaWJ4ZW52Y2hhbiB7DQo+Pj4gICAgICAgIGludCBi bG9ja2luZzoxOw0KPj4+ICAgICAgICAvKiBjb21tdW5pY2F0aW9uIHJpbmdzICovDQo+Pj4g ICAgICAgIHN0cnVjdCBsaWJ4ZW52Y2hhbl9yaW5nIHJlYWQsIHdyaXRlOw0KPj4+ICsgICAg IC8qKg0KPj4+ICsgICAgICAqIEJhc2UgeGVuc3RvcmUgcGF0aCBmb3Igc3RvcmluZyByaW5n L2V2ZW50IGRhdGEgdXNlZCBieSB0aGUgc2VydmVyDQo+Pj4gKyAgICAgICogZHVyaW5nIGNs ZWFudXAuDQo+Pj4gKyAgICAgICogKi8NCj4+PiArICAgICBjaGFyICp4c19wYXRoOw0KPj4+ ICAgIH07DQo+Pj4NCj4+PiAgICAvKioNCj4+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy92 Y2hhbi9pbml0LmMgYi90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPj4+IGluZGV4IGM4NTEw ZTZjZTkuLmM2Yjg2NzRlZjUgMTAwNjQ0DQo+Pj4gLS0tIGEvdG9vbHMvbGlicy92Y2hhbi9p bml0LmMNCj4+PiArKysgYi90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPj4+IEBAIC00Niw2 ICs0Niw4IEBADQo+Pj4gICAgI2luY2x1ZGUgPHhlbi9zeXMvZ250ZGV2Lmg+DQo+Pj4gICAg I2luY2x1ZGUgPGxpYnhlbnZjaGFuLmg+DQo+Pj4NCj4+PiArI2luY2x1ZGUgInZjaGFuLmgi DQo+Pj4gKw0KPj4+ICAgICNpZm5kZWYgUEFHRV9TSElGVA0KPj4+ICAgICNkZWZpbmUgUEFH RV9TSElGVCAxMg0KPj4+ICAgICNlbmRpZg0KPj4+IEBAIC0yNTEsNiArMjUzLDEwIEBAIHN0 YXRpYyBpbnQgaW5pdF94c19zcnYoc3RydWN0IGxpYnhlbnZjaGFuICpjdHJsLCBpbnQgZG9t YWluLCBjb25zdCBjaGFyKiB4c19iYXNlDQo+Pj4gICAgICAgIGNoYXIgcmVmWzE2XTsNCj4+ PiAgICAgICAgY2hhciogZG9taWRfc3RyID0gTlVMTDsNCj4+PiAgICAgICAgeHNfdHJhbnNh Y3Rpb25fdCB4c190cmFucyA9IFhCVF9OVUxMOw0KPj4+ICsNCj4+PiArICAgICAvLyBzdG9y ZSB0aGUgYmFzZSBwYXRoIHNvIHdlIGNhbiBjbGVhbiB1cCBvbiBzZXJ2ZXIgY2xvc3VyZQ0K Pj4NCj4+IFBsZWFzZSBkb24ndCBpbnRyb2R1Y2UgbmV3IHVzYWdlcyBvZiB0aGUgQysrIGNv bW1lbnQgc3R5bGUuDQo+IE1vc3QgY29tbWVudHMgaW4gdGhpcyBmaWxlIGFyZSBDKysgc3R5 bGUgc2luY2UgbGlidmNoYW4gaW50cm9kdWNlZA0KDQpJIGtub3cuIE5ldmVydGhlbGVzcyBp bnRyb2R1Y2luZyBuZXcgY29kaW5nIHN0eWxlIHZpb2xhdGlvbnMgc2hvdWxkIGJlDQphdm9p ZGVkLCBlc3BlY2lhbGx5IGFzIGlvLmMgaXMgdXNpbmcgLyogLi4uICovIGFscmVhZHkuDQoN Cg0KSnVlcmdlbg0K --------------WZ0yoirnOlporgh2V4bfPdOc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------WZ0yoirnOlporgh2V4bfPdOc-- --------------2qNJJd3iXHnjcZN5T4BZyvC1-- --------------CAdvAzzbZbSyA8wUsTIPCwMC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLMFSMFAwAAAAAACgkQsN6d1ii/Ey9/ 3Af/QklEkyCcoQ3qojxEWj+Pew1afgR1c9Ap0x4hax0lKA462me8Ay5Myhf5bcv1tJ/wGWvpP2FM e0jGrcE67jw2Gu9Wdy2nodqqE8OmhHqgWZDmz7w2x5QOVoypOAixhSwKpjbOH3tZ7aVD+kcBHKg4 c2FXQkTDvuQf741cp2YFNnB4awfibieiaqsqGKyuvuj1+lrvsC0TgiWtHoIGkqrBmIzDgs/ou4T/ XVXDKSJDqVZNWMg8X9XGyO2pndftKkf87m5NoTFGm0TJkSY0kEkOrnegXH5JS1xFjgdbOTbGH+gX +E5gkrybX9cCgfpjTu8n0L/MYKiqFaXZPV8NpFUkFg== =ESBK -----END PGP SIGNATURE----- --------------CAdvAzzbZbSyA8wUsTIPCwMC-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:23:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:23:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365082.595134 (Exim 4.92) (envelope-from ) id 1oAsRX-0002TQ-W3; Mon, 11 Jul 2022 12:23:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365082.595134; Mon, 11 Jul 2022 12:23:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsRX-0002TJ-TU; Mon, 11 Jul 2022 12:23:15 +0000 Received: by outflank-mailman (input) for mailman id 365082; Mon, 11 Jul 2022 12:23:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsRX-0002TD-0y for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:23:15 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c05f19e-0114-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 14:23:13 +0200 (CEST) Received: by mail-ej1-x62a.google.com with SMTP id h23so8479346ejj.12 for ; Mon, 11 Jul 2022 05:23:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c05f19e-0114-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7z/Yw9bPW0DKGPmwQ7L+ORE6AGYICJHFKRHeV9+hFV8=; b=AT9EqtxGAhw/HNz9jVvPlD6wn9mv0vExV0mgbdwR4kjqrQVqMpOAj+pYVCvNCjdZ4G ndmjZa7laJUubXpRZkvAPBB7Y8G9bO8BSrljV8AYlArBI7N4eKQyOSTa4SKrwMTh4mn1 isVj2ZckCGYYc8Yni820umaxWqDfOSjhA5nuV+w2WvPSjG+uynmX3brRFyqTKhEo4e17 RF8Suej5Mh115ZgAmcPaD1KjliH//1QX3oPsAaWWynTZIjlDxVMxkdIzUwqJLpyn6/GR 3WPEs37JGcXxV2rQGvn+LGEcgjy6/zLPtbzivRy4WMROQxwBGJzt+94evhcp6fHNXDV4 L1Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7z/Yw9bPW0DKGPmwQ7L+ORE6AGYICJHFKRHeV9+hFV8=; b=7Fag6DK0o7mNzp0VnVoqNhvdT9R4Pd1Vn150FgubUCU+60e/tYJpwL0VorZ/lDKB+Y yQPqd62grmQsrmzbPk3Nni75wQAbV8PbghBQ48VYKN1NmLCQmRtKKMolbmBBp1n1wOyC 1wME8JTZdr5WghinufULa+mCvfZF8IWKFO+glhe4SWwH/AJFdInLce56GPuqg8imVYo/ WoGgMz8nma0XUuY+0RsqV4mXMDyf/uZTYNqObDMYQL+QVxBLUsVp2Ex3apTshYuSHllV N0/OHLp+TltkL9uTYN2Kwcq1X9ovM9iNldId4dOXGH3Rm5n0Oz7NzUAOu0b2Wk+A8LEu 5uNg== X-Gm-Message-State: AJIora8dsycPlI3Y/nQqdG68FW47Hk16s2Dv7vA2ZZ50fkTK+L3X213G rr+69/yP8sntzqyhb/Gm+Y4UEUhgj8tsCSuU7JU= X-Google-Smtp-Source: AGRyM1ul3/Uo69TqevUNUyvADa4YDbgHF6GpdCfR57h6fRrE9LnqCEviFE8YhRVMjNYzCpT8qu3JDmVBo16tyc7D37g= X-Received: by 2002:a17:906:dc8f:b0:725:28d1:422d with SMTP id cs15-20020a170906dc8f00b0072528d1422dmr17888687ejc.131.1657542193353; Mon, 11 Jul 2022 05:23:13 -0700 (PDT) MIME-Version: 1.0 References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20220709101035.2989428-2-dmitry.semenets@gmail.com> <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> In-Reply-To: <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> From: Dmytro Semenets Date: Mon, 11 Jul 2022 15:23:02 +0300 Message-ID: Subject: Re: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long To: Juergen Gross Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Juergen, =D0=BF=D0=BD, 11 =D0=B8=D1=8E=D0=BB. 2022 =D0=B3. =D0=B2 10:24, Juergen Gro= ss : > > On 09.07.22 12:10, dmitry.semenets@gmail.com wrote: > > From: Oleksandr Andrushchenko > > > > Current vchan implementation, while dealing with XenStore paths, > > allocates 64 bytes buffer on the stack which may not be enough for > > some use-cases. Make the buffer longer to respect maximum allowed > > XenStore path of XENSTORE_ABS_PATH_MAX. > > > > Signed-off-by: Oleksandr Andrushchenko > > --- > > tools/libs/vchan/init.c | 28 ++++++++++++++++++++++------ > > 1 file changed, 22 insertions(+), 6 deletions(-) > > > > diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c > > index c6b8674ef5..17945c24a1 100644 > > --- a/tools/libs/vchan/init.c > > +++ b/tools/libs/vchan/init.c > > @@ -249,7 +249,7 @@ static int init_xs_srv(struct libxenvchan *ctrl, in= t domain, const char* xs_base > > int ret =3D -1; > > struct xs_handle *xs; > > struct xs_permissions perms[2]; > > - char buf[64]; > > + char *buf; > > char ref[16]; > > char* domid_str =3D NULL; > > xs_transaction_t xs_trans =3D XBT_NULL; > > @@ -257,6 +257,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, i= nt domain, const char* xs_base > > // store the base path so we can clean up on server closure > > ctrl->xs_path =3D strdup(xs_base); > > > > + buf =3D malloc(XENSTORE_ABS_PATH_MAX); > > + if (!buf) { > > + free(ctrl); > > + return 0; > > + } > > + > > xs =3D xs_open(0); > > if (!xs) > > goto fail; > > @@ -278,14 +284,14 @@ retry_transaction: > > goto fail_xs_open; > > > > snprintf(ref, sizeof ref, "%d", ring_ref); > > - snprintf(buf, sizeof buf, "%s/ring-ref", xs_base); > > + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_base); > > if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) > > goto fail_xs_open; > > if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) > > goto fail_xs_open; > > > > snprintf(ref, sizeof ref, "%d", ctrl->event_port); > > - snprintf(buf, sizeof buf, "%s/event-channel", xs_base); > > + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_base)= ; > > if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) > > goto fail_xs_open; > > if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) > > @@ -301,6 +307,7 @@ retry_transaction: > > free(domid_str); > > xs_close(xs); > > fail: > > + free(buf); > > return ret; > > } > > > > @@ -418,13 +425,20 @@ struct libxenvchan *libxenvchan_client_init(struc= t xentoollog_logger *logger, > > { > > struct libxenvchan *ctrl =3D malloc(sizeof(struct libxenvchan)); > > struct xs_handle *xs =3D NULL; > > - char buf[64]; > > + char *buf; > > char *ref; > > int ring_ref; > > unsigned int len; > > > > if (!ctrl) > > return 0; > > + > > + buf =3D malloc(XENSTORE_ABS_PATH_MAX); > > + if (!buf) { > > + free(ctrl); > > + return 0; > > + } > > + > > ctrl->ring =3D NULL; > > ctrl->event =3D NULL; > > ctrl->gnttab =3D NULL; > > @@ -435,8 +449,9 @@ struct libxenvchan *libxenvchan_client_init(struct = xentoollog_logger *logger, > > if (!xs) > > goto fail; > > You are leaking buf in this case. No. buf released in line 474. ctrl leaks in fail case > > > > > + > > // find xenstore entry > > - snprintf(buf, sizeof buf, "%s/ring-ref", xs_path); > > + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_path); > > ref =3D xs_read(xs, 0, buf, &len); > > if (!ref) > > goto fail; > > @@ -444,7 +459,7 @@ struct libxenvchan *libxenvchan_client_init(struct = xentoollog_logger *logger, > > free(ref); > > if (!ring_ref) > > goto fail; > > - snprintf(buf, sizeof buf, "%s/event-channel", xs_path); > > + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_path)= ; > > ref =3D xs_read(xs, 0, buf, &len); > > if (!ref) > > goto fail; > > @@ -474,6 +489,7 @@ struct libxenvchan *libxenvchan_client_init(struct = xentoollog_logger *logger, > > out: > > if (xs) > > xs_close(xs); > > + free(buf); > > return ctrl; > > fail: > > libxenvchan_close(ctrl); > > Juergen From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:25:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:25:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365087.595146 (Exim 4.92) (envelope-from ) id 1oAsTn-00032r-EC; Mon, 11 Jul 2022 12:25:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365087.595146; Mon, 11 Jul 2022 12:25:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsTn-00032k-B7; Mon, 11 Jul 2022 12:25:35 +0000 Received: by outflank-mailman (input) for mailman id 365087; Mon, 11 Jul 2022 12:25:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsTm-00032e-6T for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:25:34 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8efef755-0114-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 14:25:33 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 873911F8EF; Mon, 11 Jul 2022 12:25:32 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4D21B13524; Mon, 11 Jul 2022 12:25:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SOh2EbwWzGLZEAAAMHmgww (envelope-from ); Mon, 11 Jul 2022 12:25:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8efef755-0114-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657542332; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GtViWUb8mkNm214gAIMTZGJNECGSz22IjiSDElrHzXU=; b=gwMLQ9CoUcSjGbsisAbD3wqM/kAmRNERKXGFW4LYXRWMK3xBhfn6TAXDmxNreEzE4owMWX QyHCF/I97Ieg3goBCbEFhrA1sO9fJsdMyfyRftNL43oXajv55ZvSGvy0jZzKG9D+seOUmo 4RCJeIR+VyV+whRuaZviPPTw6ntISDg= Message-ID: <458e3626-a6ac-6e58-29f2-ec669a71baf4@suse.com> Date: Mon, 11 Jul 2022 14:25:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long Content-Language: en-US To: Dmytro Semenets Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20220709101035.2989428-2-dmitry.semenets@gmail.com> <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------JRYTzRSY0rS2OmSe01ZsEnwC" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------JRYTzRSY0rS2OmSe01ZsEnwC Content-Type: multipart/mixed; boundary="------------ky4l10Hw2ZsYNNNldyCf0wp6"; protected-headers="v1" From: Juergen Gross To: Dmytro Semenets Cc: xen-devel@lists.xenproject.org, Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Dmytro Semenets Message-ID: <458e3626-a6ac-6e58-29f2-ec669a71baf4@suse.com> Subject: Re: [PATCH 2/4] tools: allow vchan XenStore paths more then 64 bytes long References: <20220709101035.2989428-1-dmitry.semenets@gmail.com> <20220709101035.2989428-2-dmitry.semenets@gmail.com> <7e32d853-a1e4-f828-7c27-dbd2e3595d5f@suse.com> In-Reply-To: --------------ky4l10Hw2ZsYNNNldyCf0wp6 Content-Type: multipart/mixed; boundary="------------yvkmly6i7qpmbUHvmFggB55w" --------------yvkmly6i7qpmbUHvmFggB55w Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTQ6MjMsIERteXRybyBTZW1lbmV0cyB3cm90ZToNCj4gSGVsbG8gSnVl cmdlbiwNCj4g0L/QvSwgMTEg0LjRjtC7LiAyMDIyINCzLiDQsiAxMDoyNCwgSnVlcmdlbiBH cm9zcyA8amdyb3NzQHN1c2UuY29tPjoNCj4+DQo+PiBPbiAwOS4wNy4yMiAxMjoxMCwgZG1p dHJ5LnNlbWVuZXRzQGdtYWlsLmNvbSB3cm90ZToNCj4+PiBGcm9tOiBPbGVrc2FuZHIgQW5k cnVzaGNoZW5rbyA8b2xla3NhbmRyX2FuZHJ1c2hjaGVua29AZXBhbS5jb20+DQo+Pj4NCj4+ PiBDdXJyZW50IHZjaGFuIGltcGxlbWVudGF0aW9uLCB3aGlsZSBkZWFsaW5nIHdpdGggWGVu U3RvcmUgcGF0aHMsDQo+Pj4gYWxsb2NhdGVzIDY0IGJ5dGVzIGJ1ZmZlciBvbiB0aGUgc3Rh Y2sgd2hpY2ggbWF5IG5vdCBiZSBlbm91Z2ggZm9yDQo+Pj4gc29tZSB1c2UtY2FzZXMuIE1h a2UgdGhlIGJ1ZmZlciBsb25nZXIgdG8gcmVzcGVjdCBtYXhpbXVtIGFsbG93ZWQNCj4+PiBY ZW5TdG9yZSBwYXRoIG9mIFhFTlNUT1JFX0FCU19QQVRIX01BWC4NCj4+Pg0KPj4+IFNpZ25l ZC1vZmYtYnk6IE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIDxvbGVrc2FuZHJfYW5kcnVzaGNo ZW5rb0BlcGFtLmNvbT4NCj4+PiAtLS0NCj4+PiAgICB0b29scy9saWJzL3ZjaGFuL2luaXQu YyB8IDI4ICsrKysrKysrKysrKysrKysrKysrKystLS0tLS0NCj4+PiAgICAxIGZpbGUgY2hh bmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4+Pg0KPj4+IGRpZmYg LS1naXQgYS90b29scy9saWJzL3ZjaGFuL2luaXQuYyBiL3Rvb2xzL2xpYnMvdmNoYW4vaW5p dC5jDQo+Pj4gaW5kZXggYzZiODY3NGVmNS4uMTc5NDVjMjRhMSAxMDA2NDQNCj4+PiAtLS0g YS90b29scy9saWJzL3ZjaGFuL2luaXQuYw0KPj4+ICsrKyBiL3Rvb2xzL2xpYnMvdmNoYW4v aW5pdC5jDQo+Pj4gQEAgLTI0OSw3ICsyNDksNyBAQCBzdGF0aWMgaW50IGluaXRfeHNfc3J2 KHN0cnVjdCBsaWJ4ZW52Y2hhbiAqY3RybCwgaW50IGRvbWFpbiwgY29uc3QgY2hhciogeHNf YmFzZQ0KPj4+ICAgICAgICBpbnQgcmV0ID0gLTE7DQo+Pj4gICAgICAgIHN0cnVjdCB4c19o YW5kbGUgKnhzOw0KPj4+ICAgICAgICBzdHJ1Y3QgeHNfcGVybWlzc2lvbnMgcGVybXNbMl07 DQo+Pj4gLSAgICAgY2hhciBidWZbNjRdOw0KPj4+ICsgICAgIGNoYXIgKmJ1ZjsNCj4+PiAg ICAgICAgY2hhciByZWZbMTZdOw0KPj4+ICAgICAgICBjaGFyKiBkb21pZF9zdHIgPSBOVUxM Ow0KPj4+ICAgICAgICB4c190cmFuc2FjdGlvbl90IHhzX3RyYW5zID0gWEJUX05VTEw7DQo+ Pj4gQEAgLTI1Nyw2ICsyNTcsMTIgQEAgc3RhdGljIGludCBpbml0X3hzX3NydihzdHJ1Y3Qg bGlieGVudmNoYW4gKmN0cmwsIGludCBkb21haW4sIGNvbnN0IGNoYXIqIHhzX2Jhc2UNCj4+ PiAgICAgICAgLy8gc3RvcmUgdGhlIGJhc2UgcGF0aCBzbyB3ZSBjYW4gY2xlYW4gdXAgb24g c2VydmVyIGNsb3N1cmUNCj4+PiAgICAgICAgY3RybC0+eHNfcGF0aCA9IHN0cmR1cCh4c19i YXNlKTsNCj4+Pg0KPj4+ICsgICAgIGJ1ZiA9IG1hbGxvYyhYRU5TVE9SRV9BQlNfUEFUSF9N QVgpOw0KPj4+ICsgICAgIGlmICghYnVmKSB7DQo+Pj4gKyAgICAgICAgICAgICBmcmVlKGN0 cmwpOw0KPj4+ICsgICAgICAgICAgICAgcmV0dXJuIDA7DQo+Pj4gKyAgICAgfQ0KPj4+ICsN Cj4+PiAgICAgICAgeHMgPSB4c19vcGVuKDApOw0KPj4+ICAgICAgICBpZiAoIXhzKQ0KPj4+ ICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4+PiBAQCAtMjc4LDE0ICsyODQsMTQgQEAg cmV0cnlfdHJhbnNhY3Rpb246DQo+Pj4gICAgICAgICAgICAgICAgZ290byBmYWlsX3hzX29w ZW47DQo+Pj4NCj4+PiAgICAgICAgc25wcmludGYocmVmLCBzaXplb2YgcmVmLCAiJWQiLCBy aW5nX3JlZik7DQo+Pj4gLSAgICAgc25wcmludGYoYnVmLCBzaXplb2YgYnVmLCAiJXMvcmlu Zy1yZWYiLCB4c19iYXNlKTsNCj4+PiArICAgICBzbnByaW50ZihidWYsIFhFTlNUT1JFX0FC U19QQVRIX01BWCwgIiVzL3JpbmctcmVmIiwgeHNfYmFzZSk7DQo+Pj4gICAgICAgIGlmICgh eHNfd3JpdGUoeHMsIHhzX3RyYW5zLCBidWYsIHJlZiwgc3RybGVuKHJlZikpKQ0KPj4+ICAg ICAgICAgICAgICAgIGdvdG8gZmFpbF94c19vcGVuOw0KPj4+ICAgICAgICBpZiAoIXhzX3Nl dF9wZXJtaXNzaW9ucyh4cywgeHNfdHJhbnMsIGJ1ZiwgcGVybXMsIDIpKQ0KPj4+ICAgICAg ICAgICAgICAgIGdvdG8gZmFpbF94c19vcGVuOw0KPj4+DQo+Pj4gICAgICAgIHNucHJpbnRm KHJlZiwgc2l6ZW9mIHJlZiwgIiVkIiwgY3RybC0+ZXZlbnRfcG9ydCk7DQo+Pj4gLSAgICAg c25wcmludGYoYnVmLCBzaXplb2YgYnVmLCAiJXMvZXZlbnQtY2hhbm5lbCIsIHhzX2Jhc2Up Ow0KPj4+ICsgICAgIHNucHJpbnRmKGJ1ZiwgWEVOU1RPUkVfQUJTX1BBVEhfTUFYLCAiJXMv ZXZlbnQtY2hhbm5lbCIsIHhzX2Jhc2UpOw0KPj4+ICAgICAgICBpZiAoIXhzX3dyaXRlKHhz LCB4c190cmFucywgYnVmLCByZWYsIHN0cmxlbihyZWYpKSkNCj4+PiAgICAgICAgICAgICAg ICBnb3RvIGZhaWxfeHNfb3BlbjsNCj4+PiAgICAgICAgaWYgKCF4c19zZXRfcGVybWlzc2lv bnMoeHMsIHhzX3RyYW5zLCBidWYsIHBlcm1zLCAyKSkNCj4+PiBAQCAtMzAxLDYgKzMwNyw3 IEBAIHJldHJ5X3RyYW5zYWN0aW9uOg0KPj4+ICAgICAgICBmcmVlKGRvbWlkX3N0cik7DQo+ Pj4gICAgICAgIHhzX2Nsb3NlKHhzKTsNCj4+PiAgICAgZmFpbDoNCj4+PiArICAgICBmcmVl KGJ1Zik7DQo+Pj4gICAgICAgIHJldHVybiByZXQ7DQo+Pj4gICAgfQ0KPj4+DQo+Pj4gQEAg LTQxOCwxMyArNDI1LDIwIEBAIHN0cnVjdCBsaWJ4ZW52Y2hhbiAqbGlieGVudmNoYW5fY2xp ZW50X2luaXQoc3RydWN0IHhlbnRvb2xsb2dfbG9nZ2VyICpsb2dnZXIsDQo+Pj4gICAgew0K Pj4+ICAgICAgICBzdHJ1Y3QgbGlieGVudmNoYW4gKmN0cmwgPSBtYWxsb2Moc2l6ZW9mKHN0 cnVjdCBsaWJ4ZW52Y2hhbikpOw0KPj4+ICAgICAgICBzdHJ1Y3QgeHNfaGFuZGxlICp4cyA9 IE5VTEw7DQo+Pj4gLSAgICAgY2hhciBidWZbNjRdOw0KPj4+ICsgICAgIGNoYXIgKmJ1ZjsN Cj4+PiAgICAgICAgY2hhciAqcmVmOw0KPj4+ICAgICAgICBpbnQgcmluZ19yZWY7DQo+Pj4g ICAgICAgIHVuc2lnbmVkIGludCBsZW47DQo+Pj4NCj4+PiAgICAgICAgaWYgKCFjdHJsKQ0K Pj4+ICAgICAgICAgICAgICAgIHJldHVybiAwOw0KPj4+ICsNCj4+PiArICAgICBidWYgPSBt YWxsb2MoWEVOU1RPUkVfQUJTX1BBVEhfTUFYKTsNCj4+PiArICAgICBpZiAoIWJ1Zikgew0K Pj4+ICsgICAgICAgICAgICAgZnJlZShjdHJsKTsNCj4+PiArICAgICAgICAgICAgIHJldHVy biAwOw0KPj4+ICsgICAgIH0NCj4+PiArDQo+Pj4gICAgICAgIGN0cmwtPnJpbmcgPSBOVUxM Ow0KPj4+ICAgICAgICBjdHJsLT5ldmVudCA9IE5VTEw7DQo+Pj4gICAgICAgIGN0cmwtPmdu dHRhYiA9IE5VTEw7DQo+Pj4gQEAgLTQzNSw4ICs0NDksOSBAQCBzdHJ1Y3QgbGlieGVudmNo YW4gKmxpYnhlbnZjaGFuX2NsaWVudF9pbml0KHN0cnVjdCB4ZW50b29sbG9nX2xvZ2dlciAq bG9nZ2VyLA0KPj4+ICAgICAgICBpZiAoIXhzKQ0KPj4+ICAgICAgICAgICAgICAgIGdvdG8g ZmFpbDsNCj4+DQo+PiBZb3UgYXJlIGxlYWtpbmcgYnVmIGluIHRoaXMgY2FzZS4NCj4gTm8u IGJ1ZiByZWxlYXNlZCBpbiBsaW5lIDQ3NC4gY3RybCBsZWFrcyBpbiBmYWlsIGNhc2UNCg0K ImdvdG8gZmFpbCIgd2lsbCBnbyB0byBsaW5lIDQ3NiwgYW5kIHRoZSBjYWxsIG9mIGxpYnhl bnZjaGFuX2Nsb3NlKCkNCndpbGwgZnJlZSBjdHJsLg0KDQo+Pg0KPj4+DQo+Pj4gKw0KPj4+ ICAgIC8vIGZpbmQgeGVuc3RvcmUgZW50cnkNCj4+PiAtICAgICBzbnByaW50ZihidWYsIHNp emVvZiBidWYsICIlcy9yaW5nLXJlZiIsIHhzX3BhdGgpOw0KPj4+ICsgICAgIHNucHJpbnRm KGJ1ZiwgWEVOU1RPUkVfQUJTX1BBVEhfTUFYLCAiJXMvcmluZy1yZWYiLCB4c19wYXRoKTsN Cj4+PiAgICAgICAgcmVmID0geHNfcmVhZCh4cywgMCwgYnVmLCAmbGVuKTsNCj4+PiAgICAg ICAgaWYgKCFyZWYpDQo+Pj4gICAgICAgICAgICAgICAgZ290byBmYWlsOw0KPj4+IEBAIC00 NDQsNyArNDU5LDcgQEAgc3RydWN0IGxpYnhlbnZjaGFuICpsaWJ4ZW52Y2hhbl9jbGllbnRf aW5pdChzdHJ1Y3QgeGVudG9vbGxvZ19sb2dnZXIgKmxvZ2dlciwNCj4+PiAgICAgICAgZnJl ZShyZWYpOw0KPj4+ICAgICAgICBpZiAoIXJpbmdfcmVmKQ0KPj4+ICAgICAgICAgICAgICAg IGdvdG8gZmFpbDsNCj4+PiAtICAgICBzbnByaW50ZihidWYsIHNpemVvZiBidWYsICIlcy9l dmVudC1jaGFubmVsIiwgeHNfcGF0aCk7DQo+Pj4gKyAgICAgc25wcmludGYoYnVmLCBYRU5T VE9SRV9BQlNfUEFUSF9NQVgsICIlcy9ldmVudC1jaGFubmVsIiwgeHNfcGF0aCk7DQo+Pj4g ICAgICAgIHJlZiA9IHhzX3JlYWQoeHMsIDAsIGJ1ZiwgJmxlbik7DQo+Pj4gICAgICAgIGlm ICghcmVmKQ0KPj4+ICAgICAgICAgICAgICAgIGdvdG8gZmFpbDsNCj4+PiBAQCAtNDc0LDYg KzQ4OSw3IEBAIHN0cnVjdCBsaWJ4ZW52Y2hhbiAqbGlieGVudmNoYW5fY2xpZW50X2luaXQo c3RydWN0IHhlbnRvb2xsb2dfbG9nZ2VyICpsb2dnZXIsDQo+Pj4gICAgIG91dDoNCj4+PiAg ICAgICAgaWYgKHhzKQ0KPj4+ICAgICAgICAgICAgICAgIHhzX2Nsb3NlKHhzKTsNCj4+PiAr ICAgICBmcmVlKGJ1Zik7DQo+Pj4gICAgICAgIHJldHVybiBjdHJsOw0KPj4+ICAgICBmYWls Og0KPj4+ICAgICAgICBsaWJ4ZW52Y2hhbl9jbG9zZShjdHJsKTsNCg0KDQpKdWVyZ2VuDQoN Cg== --------------yvkmly6i7qpmbUHvmFggB55w Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------yvkmly6i7qpmbUHvmFggB55w-- --------------ky4l10Hw2ZsYNNNldyCf0wp6-- --------------JRYTzRSY0rS2OmSe01ZsEnwC Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLMFrsFAwAAAAAACgkQsN6d1ii/Ey8A lwf7BJYBg8CoupjoEbuQteu50wsebLWKcV2RD3V1xPzAwJk5EsTssS603y1aApZaQijQEV51kkrl P9BfDriLZg55CEneYBljoVVvE09vHsi01DxLdLsB/E8eB1Lb4YyQgGg5hVJPKJBAQuHkXkWj93LK SY2qeAb8ziWmH+mtSWLecE+avEGbn5IAoek88gaCnMDEpfUqpWzMbyk1Jw9j6UnvHWhE7edN3kVM FEXQEF/QVB7CGhYcJxI3l7DaXXIXdDW58IXfNP4R5zBaa3os0ERxhWBQEezO6tRe8jwmStTrNLAj ifkQdzlLBcAHoqHcC7tgFFTyrywutS4VfKutpjCLNg== =P37F -----END PGP SIGNATURE----- --------------JRYTzRSY0rS2OmSe01ZsEnwC-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:28:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:28:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365095.595157 (Exim 4.92) (envelope-from ) id 1oAsWi-0003qH-Vc; Mon, 11 Jul 2022 12:28:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365095.595157; Mon, 11 Jul 2022 12:28:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsWi-0003qA-Sr; Mon, 11 Jul 2022 12:28:36 +0000 Received: by outflank-mailman (input) for mailman id 365095; Mon, 11 Jul 2022 12:28:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsWg-0003q2-TQ for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:28:35 +0000 Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9348eed-0114-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 14:28:32 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Mon, 11 Jul 2022 12:28:30 +0000 Received: by hermes--production-bf1-58957fb66f-2wrgg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID edfbbd6fa8ecbc3209f72e28e8d17388; Mon, 11 Jul 2022 12:28:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9348eed-0114-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657542510; bh=bkyH/2yEtsetdxmue4dlbWNa1NmKY5t/YHv6BZ96HxY=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=GTLIiN5fXmFB1C1BaPAx0SFI9AP04mdVHbZU/k0HfrHd2y+3PAc+SKx1Gp3mQnrNxUA9AsqFxPhec17O7g+roP7EC2u8pgAXAdAxrnuA8ZPmf/6I3NCTud1nQfPmWk67LgIEihqZfX1w3Wq65fMzPYRXKmSbxrfvM6YcvAynHiV74UihnPWetqicQePfBeB7GEEvGCppeeB/itVk7rPeq1Ml5nzWvkWvSx4iyXNWDIRv9TILZVYWqTtRfZh1QR88vXPHCJTd3OGbfCsFMaDnH9sdAPTAWQnVPxw5jHnz/ZVVi/77Yw+ZNIvqNdonDwbufcaiB/4G6xc/a4PommFEbA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657542510; bh=rKBwDKvOdcW0IXB0d2qgnDfP+2/IXQxx9Rz8JinpEDY=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=syjCYX+7xEuWmiENfAvcXceGPVibVZgEVJL+6ZHaqcik5TyXhXj658E7JPnjXb6yPj/wvJeAtgrqMaBaVCrKqCDlqBPbQCsxlPtBqX4PZaPevRi/WVg5ao3JsmvKVBF0h/l4mptWD4oezlz6TBt0G4qwOFvaKmG0XS+pcbgNJCGPY9P7Rl/XFziorASUN/RIBEv1auazfG9QX1C+p2zwyxEAf/vzbbIVVUMoxjkoL0tbN476un5MQD0eWgeFiT9V4pdXR2f0WvIlfNbkd4xN/7G7tnPnrJX4KbRwp6TEnejN4jcjQu30ZsMJ9jgbBCO5MFaxv+JPTMMZ+RQgbdLSRg== X-YMail-OSG: ljkONEYVM1nH882XyMvvMTZEG7U2TFqZe4hNcHqpvO7Oh8iFE55axji95cREcTU lQlMiUHgAcIW7xsdWAtaR6ltBhH01VcjxnMjkcwKYs1SdSspV6DrgwRM6Le_6hnKYi5yxPmpJq8Z ESoFIqeMAvMLXc.Yg4PO8SKQImqEZUc6KWYh4xDlrYXu2x7bD2uX8ww4qnAkCW.sfPQUQyJpDtgW 98jec3J3ntU5XroBufFy5Z29Lr6w9yyG1dETUL3zy1KVONJIbq_Bo3WRrD3l65ctLeI.K77hmxRj uvtIOOGlz6kJ.PvhrW6IzDBhK98Xu_J1lss6d7MfKiIr0MqUtI8Ga15cZ73P2ciAbMdJJP9RnBfC cROkIIMKr69kiXdGdI7eqgqo16i1ZmBlfICEh0V4PfpE16OC18U48aImTcdJGAnMY3LqBCjiN1Ob vO.69tLWqvGbNDDA57prB9yMmll7vJkCp7x_KoluF3JhRyLTCno9st9Ck77mjPdJqf9U0SQElSRZ 3Fi5fR7QwSG5l7guvQZxNe_1nnme1ErWS90sWGP0ThBI7vG39FfRQbWc5G_D.0EdSMl4YY.8PSO2 .CaJFEJyiOzRm9MNM22MF7sq1oqdi..kD_1AdOKB03sznOm31Vz2IMMLJ5HKVf8vii3B_ErkaZ3P ekNzZ4lcbOm9RNwONsuDa3BGxK0MRbO1hReG27CjlLRL2eFsm.vhM543BJKu8bqt1RAAW0UXgiVv d2YSOcxF3WY2.7rk7OyCJHcmLvLEkguFRTXGDHA2vAb_YBpt7ubsISmA_MXTNV4NmsKke8ZQwa28 M2_jhYw2nHMiVhL4Fx.WtVJWL1gnwSvnYd6LKS_DMhOx1ZckfrFgnxvdtbF1U90Bs2zUYDoVJieg BCnVaNnvV3Ez6wbNc.42iYOa0nG5OrvI4rzwKEklhn_.ZJqNU6y6DnFxZYc7YuwcRgqTGCdo2bQX TCvIhJie4gYW0qtO6.gxWpmIh4s55kc5L0B5l0fdKCPWjBFJJDgZTMmvOoT2zmKU1ts7hd3GA4rA _Ncvo26UKhytD58kupg.e_EolU1JR.oAKTFk0zF7f6x26oOpjD422QwwM8OsMeOiadEFTjuOYM7W qhKq9YF1xeMcteKRVqy8ZaOFALRgSGTGCW2BLZpRo5R9j7VjAiyopChAB7Vrw.Orqp4mxgigeq0f jV18X17SRZzqJIyR.qQzJFqgLRAsAyVD.4h8n9EFbMTTjeTdkDq2_51vJL56k1ftWNpckMmFOaam kKmUm0zdFSFhvVEucaisF5VZDzX8vLI_AjWjOQqc0NgQX_5xU6mVHFYMCjG_08HBiMKT4wxgZ1qT p1pq4EGiyvB0aFFRcDgQ1V8XzXLPv1y4Yue.LEQhawncZzxcLlhqZSGiGzftF8IpZf4PUEWPAsqh GJHvZq_xtp3_HKSAnomni8vBusPicdbZ8.xf4xGJjOMydarh1yVTkfo_.wWq.hRhxoQWGAX3WjA6 sbZ8tFXlubTyuKVMQHBQBYj.SjmEZQ8b2FcHplReORAfTApLuSM1ITg8bqs1hsNVDlk59_S_Kbtk yqo3DzTpweTkVYvYfrLMfT7liZLlsqZ_eOVpulMKKkZXC62fGF0mqcZUkldb9IhBxdQ9y7ls3kkK rikm8x9BbUnutghYZvj2kyJDKJD8iv9aiuDlxh03H9TKxO4mNxjh_DLrDu6nfNK8tfpYUGIzL8IA s4JTYaKI7TKw5Q4m2ZHSUFbA_VreILzyT4jht_D93f__OHxHSZvZEhjB.wOL5EsvLngxprhPMgyG VwltPAPc_qawIBdtD48ah5WjF3V7dmIR3L9SvOVHp2rmuuVXPRQNDFBupagPG_3i_6uypm4eUaFB nmUDLKm2F.AM1QLL5kc8US3VUmOobV.ZaZv7jrz7IRv2rl1Zl.SS9EpxoN6dz488eqYjb3vkQTXi 8GgrryN24MpIgHJ.p8HWz1K5vqMEbOC3aPHgg42O_ X-Sonic-MF: Message-ID: <63583497-152f-5880-4c8f-d47e2a81f5a6@netscape.net> Date: Mon, 11 Jul 2022 08:28:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen, with corrected patch To: Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4937 On 7/5/22 12:14 PM, Borislav Petkov wrote: > On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: > > Re-using pat_disabled like you do in your suggestion below won't > > work, because mtrr_bp_init() calls pat_disable() when MTRRs > > appear to be disabled (from the kernel's view). The goal is to > > honor "nopat" without honoring any other calls to pat_disable(). I think Jan is speaking of the narrow goal of the patch that is causing the regression at hand: Commit bdd8b6c98239cad3a976d6f197afc2c794d3cef8 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") The author of that commit expressed the desire to more readily handle the nopat option in Linux in an architecture-independent way. in the commit message. The patch was not intended to cause a functional change, but it did - it caused a regression in Xen Dom0s running certain Intel graphics devices. > > Actually, the current goal is to adjust Xen dom0 because: > > 1. it uses the PAT code > > 2. but then it does something special and hides the MTRRs > > which is not something real hardware does. > > So this one-off thing should be prominent, visible and not get in the > way. Actually, this is probably the most insightful comment in all the words that have been written about this regression. This is a one-off thing, peculiar to Xen PV, but it is not visible enough and gets overlooked when changes are made. I guess I agree it should not get in the way either, and it doesn't, except when the lack of visibility of this one-off thing causes the author of a patch to overlook it and cause unforeseen problems for users of Xen on Linux. That is precisely what happened five years ago with commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") Have you looked at that patch? That is the one that introduced the regression that causes pat_enabled() to return a false negative on Xen Dom0 today, and it hid in the code for four and a half years and was only exposed as a regression with commit bdd8b6c98239cad3a9 last December, which again was written in a way that caused the regression on Xen because this one-off thing that Xen does was not visible enough to the author of the recent patch from last December that exposed this problem as a regression with Xen PV domains and certain Intel graphics adpapters. That patch did not take into account this not-visible-enough Xen case when MTRR is disabled but PAT is still supported by the CPU in Xen PV domains. So the proper way to fix this regression is by fixing that commit from five years ago. It is very simple. After some code re-factoring and other changes, today that commit can be fixed by something like: --- a/arch/x86/mm/pat/memtype.c    2022-06-16 07:32:05.000000000 -0400 +++ b/arch/x86/mm/pat/memtype.c    2022-07-09 17:51:56.783050765 -0400 @@ -315,6 +315,19 @@                PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);      }   +    else if (!pat_bp_enabled) { +        /* +         * In some environments, specifically Xen PV, PAT +         * initialization is skipped because MTRRs are +         * disabled even though PAT is available. In such +         * environments, set PAT to enabled to correctly +         * indicate to callers of pat_enabled() that CPU +         * support for PAT is available. +         */ +        pat_bp_enabled = true; +        pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); +    } +      __init_cache_modes(pat);  }   [N.B. I am re-sending this message because this patch in the earlier message would be malformed because I deleted an inserted line without editing the line in the patch that defines how many new lines are inserted into the patched file. The change from the proposed patch in the previous message is: @@ -315,6 +315,20 @@ -> @@ -315,6 +315,19 @@ Sorry for the confusion.] Like Jan's approach, this patch implements the fix in init_cache_modes(), but unlike Jan's approach, it only sets pat_bp_enabled and pat_bp_initialized to true if boot_cpu_has(X86_FEATURE_PAT) is true and rdmsrl(MSR_IA32_CR_PAT, pat) returns a valid value. No need to check for a hypervisor, just check if the CPU supports PAT here and that PAT MSR returns something valid here. If both are true, then set pat_bp_enabled to true. Regression solved. And that leaves the bigger goal of dealing with this one-off thing that Xen does in a more sane way for another day. I am working on a patch series that attempts to start the process by first re-factoring the currently confusing pat_disable functions and variables that will hopefully make this one-off Xen thing more visible and easier to understand so when someone wants to play around with the current way of deciding whether or not PAT is enabled on X86, no regression will occur on Xen or in any other environment. Best Regards, Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:37:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:37:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365103.595168 (Exim 4.92) (envelope-from ) id 1oAsfP-0005OV-R1; Mon, 11 Jul 2022 12:37:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365103.595168; Mon, 11 Jul 2022 12:37:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsfP-0005OO-No; Mon, 11 Jul 2022 12:37:35 +0000 Received: by outflank-mailman (input) for mailman id 365103; Mon, 11 Jul 2022 12:37:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsfO-0005OI-J9 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:37:34 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39f9ec7a-0116-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 14:37:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39f9ec7a-0116-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657543051; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7xWmOgdryJI3VyJLWMTxs1yYMgXi2US8AQ2Ebi9EkUc=; b=KelpwQnAxuDDAwy0uZYiIrrFZ7lblUvQ9UX9qE/SCPSUzVKCJzuMkQbA TxNcUmFLyj++l4ruvdkrZEhf84S4WELlIQPBJVlnazlfAiZx/LA1gn1G6 EFR1SSqNAnAnXi84DqnbWWImA0sIKg2k2aWTWPTYliJj9YH7GSjHWWQMH o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75537927 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+hBDva+PBRHUZYqIJphBDrUDvH6TJUtcMsCJ2f8bNWPcYEJGY0x3z zcfUGnSbqqMZmvyLtggbIyx/EwAucWHy9RrSAs/pX88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ74f5fs7Rh2NQw3oHgW1rlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnY3haR0VJInxor0YCxdZFDlkFPVg1bCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKEWvHwm6DjdBPIvR53rSKTW/95Imjw3g6iiGN6BO pdCNms1M3wsZTVvN3UqUMgS39yZl13CeC9aqnC0qbEotj27IAtZj+G2bYu9lsaxbcdfk1ucp 2nG13/kGRxcP9uaoRKH/WirnfTnhj7gVcQZE7jQ3v1nnlyVgHASARs+VF2nrP3/gUm7M/pdN kpS/CMtpKoz8UWDT9/hUhn+q3mB1jYDX/JAHut87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YX6U6Lq8tz65PikRa2gYakcsVwwe6cPkp4I1ph3KR9dnVqWyi7XI9SrYm m7Q6nJk3vNK0JBNh/7TEU37byyEt8npVDIvwjjtB2f94AJ+fJSMP6qF5g2OhRpfF7p1XmVtr VBdxZXBt7hUUMjU/MCeaL5TRe/0vp5pJBWZ2AcyRMd5qlxB7lb5JehtDCdCyFCF2yruURvge wfttAxY//e/11P6PPYsM+pd5ynHpJUM9OgJtdiON7KimrArKGe6ENhGPCZ8JVzFnkk2ir0YM pyGa8uqBntyIf05kWXqGLdEjuN6nHxWKYbvqXfTlk7P7FZjTCTNFedt3KWmNIjVE59oUC2Kq o0CZqNmOj1UUfHkYzm/zLP/2WsidCBhbbiv8pQ/XrfafmJORTB6Y9eMkOxJRmCQt/kM/gs+1 irlChEwJZuWrSCvFDhmnVg5OemwBscv9yhhVcHuVH7xs0UejU+UxP93X/MKkXMPqISPEdYco yE5Rvi9 IronPort-HdrOrdr: A9a23:2NmLMK/Hhhrs11C84Fxuk+DUI+orL9Y04lQ7vn2YSXRuHPBw8P re+8jztCWE7Ar5N0tBpTntAsW9qBDnhPtICOsqTNSftWDd0QPCRuxfBOPZslvd8kbFl9K1u5 0OT0EHMqyTMWRH X-IronPort-AV: E=Sophos;i="5.92,262,1650945600"; d="scan'208";a="75537927" From: Jane Malalane To: Xen-devel CC: Jane Malalane , Wei Liu , "Anthony PERARD" , George Dunlap , Nick Rosbrook , Juergen Gross , Christian Lindig , David Scott , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jun Nakajima , Kevin Tian Subject: [PATCH v11 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Date: Mon, 11 Jul 2022 13:36:58 +0100 Message-ID: <20220711123658.2901-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Introduce a new per-domain creation x86 specific flag to select whether hardware assisted virtualization should be used for x{2}APIC. A per-domain option is added to xl in order to select the usage of x{2}APIC hardware assisted virtualization, as well as a global configuration option. Having all APIC interaction exit to Xen for emulation is slow and can induce much overhead. Hardware can speed up x{2}APIC by decoding the APIC access and providing a VM exit with a more specific exit reason than a regular EPT fault or by altogether avoiding a VM exit. On the other hand, being able to disable x{2}APIC hardware assisted virtualization can be useful for testing and debugging purposes. Note: - vmx_install_vlapic_mapping doesn't require modifications regardless of whether the guest has "Virtualize APIC accesses" enabled or not, i.e., setting the APIC_ACCESS_ADDR VMCS field is fine so long as virtualize_apic_accesses is supported by the CPU. - Both per-domain and global assisted_x{2}apic options are not part of the migration stream, unless explicitly set in the respective configuration files. Default settings of assisted_x{2}apic done internally by the toolstack, based on host capabilities at create time, are not migrated. Suggested-by: Andrew Cooper Signed-off-by: Jane Malalane Acked-by: Christian Lindig Reviewed-by: "Roger Pau Monné" Reviewed-by: Anthony PERARD Reviewed-by: Kevin Tian --- CC: Wei Liu CC: Anthony PERARD CC: George Dunlap CC: Nick Rosbrook CC: Juergen Gross CC: Christian Lindig CC: David Scott CC: Jan Beulich CC: Andrew Cooper CC: "Roger Pau Monné" CC: Jun Nakajima CC: Kevin Tian v11: * No change v10: * Improve commit message note on migration v9: * Fix style issues * Fix exit() logic for assisted_x{2}apic parsing * Add and use XEN_X86_MISC_FLAGS_MAX for ABI checking instead of using XEN_X86_ASSISTED_X2APIC directly * Expand commit message to mention migration is safe v8: * Widen assisted_x{2}apic parsing to PVH guests in parse_config_data() v7: * Fix void return in libxl__arch_domain_build_info_setdefault * Fix style issues * Use EINVAL when rejecting assisted_x{2}apic for PV guests and ENODEV otherwise, when assisted_x{2}apic isn't supported * Define has_assisted_x{2}apic macros for when !CONFIG_HVM * Replace "EPT" fault reference with "p2m" fault since the former is Intel-specific v6: * Use ENODEV instead of EINVAL when rejecting assisted_x{2}apic for PV guests * Move has_assisted_x{2}apic macros out of an Intel specific header * Remove references to Intel specific features in documentation v5: * Revert v4 changes in vmx_vlapic_msr_changed(), preserving the use of the has_assisted_x{2}apic macros * Following changes in assisted_x{2}apic_available definitions in patch 1, retighten conditionals for setting XEN_HVM_CPUID_APIC_ACCESS_VIRT and XEN_HVM_CPUID_X2APIC_VIRT in cpuid_hypervisor_leaves() v4: * Add has_assisted_x{2}apic macros and use them where appropriate * Replace CPU checks with per-domain assisted_x{2}apic control options in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves(), following edits to assisted_x{2}apic_available definitions in patch 1 Note: new assisted_x{2}apic_available definitions make later cpu_has_vmx_apic_reg_virt and cpu_has_vmx_virtual_intr_delivery checks redundant in vmx_vlapic_msr_changed() v3: * Change info in xl.cfg to better express reality and fix capitalization of x{2}apic * Move "physinfo" variable definition to the beggining of libxl__domain_build_info_setdefault() * Reposition brackets in if statement to match libxl coding style * Shorten logic in libxl__arch_domain_build_info_setdefault() * Correct dprintk message in arch_sanitise_domain_config() * Make appropriate changes in vmx_vlapic_msr_changed() and cpuid_hypervisor_leaves() for amended "assisted_x2apic" bit * Remove unneeded parantheses v2: * Add a LIBXL_HAVE_ASSISTED_APIC macro * Pass xcpyshinfo as a pointer in libxl__arch_get_physinfo * Add a return statement in now "int" libxl__arch_domain_build_info_setdefault() * Preserve libxl__arch_domain_build_info_setdefault 's location in libxl_create.c * Correct x{2}apic default setting logic in libxl__arch_domain_prepare_config() * Correct logic for parsing assisted_x{2}apic host/guest options in xl_parse.c and initialize them to -1 in xl.c * Use guest options directly in vmx_vlapic_msr_changed * Fix indentation of bool assisted_x{2}apic in struct hvm_domain * Add a change in xenctrl_stubs.c to pass xenctrl ABI checks --- docs/man/xl.cfg.5.pod.in | 15 +++++++++++++++ docs/man/xl.conf.5.pod.in | 12 ++++++++++++ tools/golang/xenlight/helpers.gen.go | 12 ++++++++++++ tools/golang/xenlight/types.gen.go | 2 ++ tools/include/libxl.h | 7 +++++++ tools/libs/light/libxl_arch.h | 5 +++-- tools/libs/light/libxl_arm.c | 9 ++++++--- tools/libs/light/libxl_create.c | 22 +++++++++++++--------- tools/libs/light/libxl_types.idl | 2 ++ tools/libs/light/libxl_x86.c | 28 ++++++++++++++++++++++++++-- tools/ocaml/libs/xc/xenctrl.ml | 2 ++ tools/ocaml/libs/xc/xenctrl.mli | 2 ++ tools/ocaml/libs/xc/xenctrl_stubs.c | 2 +- tools/xl/xl.c | 8 ++++++++ tools/xl/xl.h | 2 ++ tools/xl/xl_parse.c | 19 +++++++++++++++++++ xen/arch/x86/domain.c | 29 ++++++++++++++++++++++++++++- xen/arch/x86/hvm/vmx/vmcs.c | 4 ++++ xen/arch/x86/hvm/vmx/vmx.c | 13 ++++--------- xen/arch/x86/include/asm/hvm/domain.h | 6 ++++++ xen/arch/x86/include/asm/hvm/hvm.h | 5 +++++ xen/arch/x86/traps.c | 5 +++-- xen/include/public/arch-x86/xen.h | 5 +++++ 23 files changed, 187 insertions(+), 29 deletions(-) diff --git a/docs/man/xl.cfg.5.pod.in b/docs/man/xl.cfg.5.pod.in index b98d161398..6d98d73d76 100644 --- a/docs/man/xl.cfg.5.pod.in +++ b/docs/man/xl.cfg.5.pod.in @@ -1862,6 +1862,21 @@ firmware tables when using certain older guest Operating Systems. These tables have been superseded by newer constructs within the ACPI tables. +=item B + +B<(x86 only)> Enables or disables hardware assisted virtualization for +xAPIC. With this option enabled, a memory-mapped APIC access will be +decoded by hardware and either issue a more specific VM exit than just +a p2m fault, or altogether avoid a VM exit. The +default is settable via L. + +=item B + +B<(x86 only)> Enables or disables hardware assisted virtualization for +x2APIC. With this option enabled, certain accesses to MSR APIC +registers will avoid a VM exit into the hypervisor. The default is +settable via L. + =item B B<(x86 only)> Hides or exposes the No-eXecute capability. This allows a guest diff --git a/docs/man/xl.conf.5.pod.in b/docs/man/xl.conf.5.pod.in index df20c08137..95d136d1ea 100644 --- a/docs/man/xl.conf.5.pod.in +++ b/docs/man/xl.conf.5.pod.in @@ -107,6 +107,18 @@ Sets the default value for the C domain config value. Default: maximum grant version supported by the hypervisor. +=item B + +If enabled, domains will use xAPIC hardware assisted virtualization by default. + +Default: enabled if supported. + +=item B + +If enabled, domains will use x2APIC hardware assisted virtualization by default. + +Default: enabled if supported. + =item B Configures the default hotplug script used by virtual network devices. diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index dd4e6c9f14..dece545ee0 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1120,6 +1120,12 @@ x.ArchArm.Vuart = VuartType(xc.arch_arm.vuart) if err := x.ArchX86.MsrRelaxed.fromC(&xc.arch_x86.msr_relaxed);err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } +if err := x.ArchX86.AssistedXapic.fromC(&xc.arch_x86.assisted_xapic);err != nil { +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) +} +if err := x.ArchX86.AssistedX2Apic.fromC(&xc.arch_x86.assisted_x2apic);err != nil { +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) +} x.Altp2M = Altp2MMode(xc.altp2m) x.VmtraceBufKb = int(xc.vmtrace_buf_kb) if err := x.Vpmu.fromC(&xc.vpmu);err != nil { @@ -1605,6 +1611,12 @@ xc.arch_arm.vuart = C.libxl_vuart_type(x.ArchArm.Vuart) if err := x.ArchX86.MsrRelaxed.toC(&xc.arch_x86.msr_relaxed); err != nil { return fmt.Errorf("converting field ArchX86.MsrRelaxed: %v", err) } +if err := x.ArchX86.AssistedXapic.toC(&xc.arch_x86.assisted_xapic); err != nil { +return fmt.Errorf("converting field ArchX86.AssistedXapic: %v", err) +} +if err := x.ArchX86.AssistedX2Apic.toC(&xc.arch_x86.assisted_x2apic); err != nil { +return fmt.Errorf("converting field ArchX86.AssistedX2Apic: %v", err) +} xc.altp2m = C.libxl_altp2m_mode(x.Altp2M) xc.vmtrace_buf_kb = C.int(x.VmtraceBufKb) if err := x.Vpmu.toC(&xc.vpmu); err != nil { diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 87be46c745..253c9ad93d 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -520,6 +520,8 @@ Vuart VuartType } ArchX86 struct { MsrRelaxed Defbool +AssistedXapic Defbool +AssistedX2Apic Defbool } Altp2M Altp2MMode VmtraceBufKb int diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 3a68e1b55a..f351669039 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -543,6 +543,13 @@ #define LIBXL_HAVE_PHYSINFO_ASSISTED_APIC 1 /* + * LIBXL_HAVE_ASSISTED_APIC indicates that libxl_domain_build_info has + * assisted_xapic and assisted_x2apic fields for enabling hardware + * assisted virtualization for x{2}apic per domain. + */ +#define LIBXL_HAVE_ASSISTED_APIC 1 + +/* * libxl ABI compatibility * * The only guarantee which libxl makes regarding ABI compatibility diff --git a/tools/libs/light/libxl_arch.h b/tools/libs/light/libxl_arch.h index 207ceac6a1..03b89929e6 100644 --- a/tools/libs/light/libxl_arch.h +++ b/tools/libs/light/libxl_arch.h @@ -71,8 +71,9 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, libxl_domain_create_info *c_info); _hidden -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info); +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo); _hidden int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 39fdca1b49..7dee2afd4b 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -1384,14 +1384,15 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, } } -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info) +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo) { /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); if (b_info->type != LIBXL_DOMAIN_TYPE_PV) - return; + return 0; LOG(DEBUG, "Converting build_info to PVH"); @@ -1399,6 +1400,8 @@ void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, memset(&b_info->u, '\0', sizeof(b_info->u)); b_info->type = LIBXL_DOMAIN_TYPE_INVALID; libxl_domain_build_info_init_type(b_info, LIBXL_DOMAIN_TYPE_PVH); + + return 0; } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c index 2339f09e95..b9dd2deedf 100644 --- a/tools/libs/light/libxl_create.c +++ b/tools/libs/light/libxl_create.c @@ -75,6 +75,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, libxl_domain_build_info *b_info) { int i, rc; + libxl_physinfo info; if (b_info->type != LIBXL_DOMAIN_TYPE_HVM && b_info->type != LIBXL_DOMAIN_TYPE_PV && @@ -264,7 +265,18 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, if (!b_info->event_channels) b_info->event_channels = 1023; - libxl__arch_domain_build_info_setdefault(gc, b_info); + rc = libxl_get_physinfo(CTX, &info); + if (rc) { + LOG(ERROR, "failed to get hypervisor info"); + return rc; + } + + rc = libxl__arch_domain_build_info_setdefault(gc, b_info, &info); + if (rc) { + LOG(ERROR, "unable to set domain arch build info defaults"); + return rc; + } + libxl_defbool_setdefault(&b_info->dm_restrict, false); if (b_info->iommu_memkb == LIBXL_MEMKB_DEFAULT) @@ -457,14 +469,6 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, } if (b_info->max_grant_version == LIBXL_MAX_GRANT_DEFAULT) { - libxl_physinfo info; - - rc = libxl_get_physinfo(CTX, &info); - if (rc) { - LOG(ERROR, "failed to get hypervisor info"); - return rc; - } - if (info.cap_gnttab_v2) b_info->max_grant_version = 2; else if (info.cap_gnttab_v1) diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 47f6a30cde..f3ceb38c9e 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -648,6 +648,8 @@ libxl_domain_build_info = Struct("domain_build_info",[ ("vuart", libxl_vuart_type), ])), ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), + ("assisted_xapic", libxl_defbool), + ("assisted_x2apic", libxl_defbool), ])), # Alternate p2m is not bound to any architecture or guest type, as it is # supported by x86 HVM and ARM support is planned. diff --git a/tools/libs/light/libxl_x86.c b/tools/libs/light/libxl_x86.c index e0a06ecfe3..7c5ee74443 100644 --- a/tools/libs/light/libxl_x86.c +++ b/tools/libs/light/libxl_x86.c @@ -23,6 +23,15 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, if (libxl_defbool_val(d_config->b_info.arch_x86.msr_relaxed)) config->arch.misc_flags |= XEN_X86_MSR_RELAXED; + if (d_config->c_info.type != LIBXL_DOMAIN_TYPE_PV) + { + if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_xapic)) + config->arch.misc_flags |= XEN_X86_ASSISTED_XAPIC; + + if (libxl_defbool_val(d_config->b_info.arch_x86.assisted_x2apic)) + config->arch.misc_flags |= XEN_X86_ASSISTED_X2APIC; + } + return 0; } @@ -819,11 +828,26 @@ void libxl__arch_domain_create_info_setdefault(libxl__gc *gc, { } -void libxl__arch_domain_build_info_setdefault(libxl__gc *gc, - libxl_domain_build_info *b_info) +int libxl__arch_domain_build_info_setdefault(libxl__gc *gc, + libxl_domain_build_info *b_info, + const libxl_physinfo *physinfo) { libxl_defbool_setdefault(&b_info->acpi, true); libxl_defbool_setdefault(&b_info->arch_x86.msr_relaxed, false); + + if (b_info->type != LIBXL_DOMAIN_TYPE_PV) { + libxl_defbool_setdefault(&b_info->arch_x86.assisted_xapic, + physinfo->cap_assisted_xapic); + libxl_defbool_setdefault(&b_info->arch_x86.assisted_x2apic, + physinfo->cap_assisted_x2apic); + } + else if (!libxl_defbool_is_default(b_info->arch_x86.assisted_xapic) || + !libxl_defbool_is_default(b_info->arch_x86.assisted_x2apic)) { + LOG(ERROR, "Interrupt Controller Virtualization not supported for PV"); + return ERROR_INVAL; + } + + return 0; } int libxl__arch_passthrough_mode_setdefault(libxl__gc *gc, diff --git a/tools/ocaml/libs/xc/xenctrl.ml b/tools/ocaml/libs/xc/xenctrl.ml index 6fa30ddb56..0c71e5eef3 100644 --- a/tools/ocaml/libs/xc/xenctrl.ml +++ b/tools/ocaml/libs/xc/xenctrl.ml @@ -50,6 +50,8 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED + | X86_ASSISTED_XAPIC + | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { diff --git a/tools/ocaml/libs/xc/xenctrl.mli b/tools/ocaml/libs/xc/xenctrl.mli index 01774da768..a8458e19ca 100644 --- a/tools/ocaml/libs/xc/xenctrl.mli +++ b/tools/ocaml/libs/xc/xenctrl.mli @@ -44,6 +44,8 @@ type x86_arch_emulation_flags = type x86_arch_misc_flags = | X86_MSR_RELAXED + | X86_ASSISTED_XAPIC + | X86_ASSISTED_X2APIC type xen_x86_arch_domainconfig = { emulation_flags: x86_arch_emulation_flags list; diff --git a/tools/ocaml/libs/xc/xenctrl_stubs.c b/tools/ocaml/libs/xc/xenctrl_stubs.c index 42c2bcd333..19335bdf45 100644 --- a/tools/ocaml/libs/xc/xenctrl_stubs.c +++ b/tools/ocaml/libs/xc/xenctrl_stubs.c @@ -244,7 +244,7 @@ CAMLprim value stub_xc_domain_create(value xch, value wanted_domid, value config cfg.arch.misc_flags = ocaml_list_to_c_bitmap /* ! x86_arch_misc_flags X86_ none */ - /* ! XEN_X86_ XEN_X86_MSR_RELAXED all */ + /* ! XEN_X86_ XEN_X86_MISC_FLAGS_MAX max */ (VAL_MISC_FLAGS); #undef VAL_MISC_FLAGS diff --git a/tools/xl/xl.c b/tools/xl/xl.c index 2d1ec18ea3..31eb223309 100644 --- a/tools/xl/xl.c +++ b/tools/xl/xl.c @@ -57,6 +57,8 @@ int max_grant_frames = -1; int max_maptrack_frames = -1; int max_grant_version = LIBXL_MAX_GRANT_DEFAULT; libxl_domid domid_policy = INVALID_DOMID; +int assisted_xapic = -1; +int assisted_x2apic = -1; xentoollog_level minmsglevel = minmsglevel_default; @@ -201,6 +203,12 @@ static void parse_global_config(const char *configfile, if (!xlu_cfg_get_long (config, "claim_mode", &l, 0)) claim_mode = l; + if (!xlu_cfg_get_long (config, "assisted_xapic", &l, 0)) + assisted_xapic = l; + + if (!xlu_cfg_get_long (config, "assisted_x2apic", &l, 0)) + assisted_x2apic = l; + xlu_cfg_replace_string (config, "remus.default.netbufscript", &default_remus_netbufscript, 0); xlu_cfg_replace_string (config, "colo.default.proxyscript", diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd..528deb3feb 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -286,6 +286,8 @@ extern libxl_bitmap global_vm_affinity_mask; extern libxl_bitmap global_hvm_affinity_mask; extern libxl_bitmap global_pv_affinity_mask; extern libxl_domid domid_policy; +extern int assisted_xapic; +extern int assisted_x2apic; enum output_format { OUTPUT_FORMAT_JSON, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index 644ab8f8fd..1b5381cef0 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -2765,6 +2765,25 @@ skip_usbdev: xlu_cfg_get_defbool(config, "vpmu", &b_info->vpmu, 0); + if (b_info->type != LIBXL_DOMAIN_TYPE_PV) { + e = xlu_cfg_get_long(config, "assisted_xapic", &l , 0); + if (!e) + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, l); + else if (e != ESRCH) + exit(1); + else if (assisted_xapic != -1) /* use global default if present */ + libxl_defbool_set(&b_info->arch_x86.assisted_xapic, assisted_xapic); + + e = xlu_cfg_get_long(config, "assisted_x2apic", &l, 0); + if (!e) + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, l); + else if (e != ESRCH) + exit(1); + else if (assisted_x2apic != -1) /* use global default if present */ + libxl_defbool_set(&b_info->arch_x86.assisted_x2apic, + assisted_x2apic); + } + xlu_cfg_destroy(config); } diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c index 0d2944fe14..bc8f0b51ff 100644 --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include #include @@ -619,6 +620,8 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) bool hvm = config->flags & XEN_DOMCTL_CDF_hvm; bool hap = config->flags & XEN_DOMCTL_CDF_hap; bool nested_virt = config->flags & XEN_DOMCTL_CDF_nested_virt; + bool assisted_xapic = config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; + bool assisted_x2apic = config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; unsigned int max_vcpus; if ( hvm ? !hvm_enabled : !IS_ENABLED(CONFIG_PV) ) @@ -685,13 +688,31 @@ int arch_sanitise_domain_config(struct xen_domctl_createdomain *config) } } - if ( config->arch.misc_flags & ~XEN_X86_MSR_RELAXED ) + if ( config->arch.misc_flags & ~(XEN_X86_MSR_RELAXED | + XEN_X86_ASSISTED_XAPIC | + XEN_X86_ASSISTED_X2APIC) ) { dprintk(XENLOG_INFO, "Invalid arch misc flags %#x\n", config->arch.misc_flags); return -EINVAL; } + if ( (assisted_xapic || assisted_x2apic) && !hvm ) + { + dprintk(XENLOG_INFO, + "Interrupt Controller Virtualization not supported for PV\n"); + return -EINVAL; + } + + if ( (assisted_xapic && !assisted_xapic_available) || + (assisted_x2apic && !assisted_x2apic_available) ) + { + dprintk(XENLOG_INFO, + "Hardware assisted x%sAPIC requested but not available\n", + assisted_xapic && !assisted_xapic_available ? "" : "2"); + return -ENODEV; + } + return 0; } @@ -864,6 +885,12 @@ int arch_domain_create(struct domain *d, d->arch.msr_relaxed = config->arch.misc_flags & XEN_X86_MSR_RELAXED; + d->arch.hvm.assisted_xapic = + config->arch.misc_flags & XEN_X86_ASSISTED_XAPIC; + + d->arch.hvm.assisted_x2apic = + config->arch.misc_flags & XEN_X86_ASSISTED_X2APIC; + spec_ctrl_init_domain(d); return 0; diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c index 7329622dd4..683c650d77 100644 --- a/xen/arch/x86/hvm/vmx/vmcs.c +++ b/xen/arch/x86/hvm/vmx/vmcs.c @@ -1134,6 +1134,10 @@ static int construct_vmcs(struct vcpu *v) __vmwrite(PLE_WINDOW, ple_window); } + if ( !has_assisted_xapic(d) ) + v->arch.hvm.vmx.secondary_exec_control &= + ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; + if ( cpu_has_vmx_secondary_exec_control ) __vmwrite(SECONDARY_VM_EXEC_CONTROL, v->arch.hvm.vmx.secondary_exec_control); diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index f08a00dcbb..47554cc004 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3376,16 +3376,11 @@ static void vmx_install_vlapic_mapping(struct vcpu *v) void vmx_vlapic_msr_changed(struct vcpu *v) { - int virtualize_x2apic_mode; struct vlapic *vlapic = vcpu_vlapic(v); unsigned int msr; - virtualize_x2apic_mode = ( (cpu_has_vmx_apic_reg_virt || - cpu_has_vmx_virtual_intr_delivery) && - cpu_has_vmx_virtualize_x2apic_mode ); - - if ( !cpu_has_vmx_virtualize_apic_accesses && - !virtualize_x2apic_mode ) + if ( !has_assisted_xapic(v->domain) && + !has_assisted_x2apic(v->domain) ) return; vmx_vmcs_enter(v); @@ -3395,7 +3390,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) if ( !vlapic_hw_disabled(vlapic) && (vlapic_base_address(vlapic) == APIC_DEFAULT_PHYS_BASE) ) { - if ( virtualize_x2apic_mode && vlapic_x2apic_mode(vlapic) ) + if ( has_assisted_x2apic(v->domain) && vlapic_x2apic_mode(vlapic) ) { v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE; @@ -3416,7 +3411,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) vmx_clear_msr_intercept(v, MSR_X2APIC_SELF, VMX_MSR_W); } } - else + else if ( has_assisted_xapic(v->domain) ) v->arch.hvm.vmx.secondary_exec_control |= SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES; } diff --git a/xen/arch/x86/include/asm/hvm/domain.h b/xen/arch/x86/include/asm/hvm/domain.h index 698455444e..92bf53483c 100644 --- a/xen/arch/x86/include/asm/hvm/domain.h +++ b/xen/arch/x86/include/asm/hvm/domain.h @@ -117,6 +117,12 @@ struct hvm_domain { bool is_s3_suspended; + /* xAPIC hardware assisted virtualization. */ + bool assisted_xapic; + + /* x2APIC hardware assisted virtualization. */ + bool assisted_x2apic; + /* hypervisor intercepted msix table */ struct list_head msixtbl_list; diff --git a/xen/arch/x86/include/asm/hvm/hvm.h b/xen/arch/x86/include/asm/hvm/hvm.h index 8d162b2c99..03096f31ef 100644 --- a/xen/arch/x86/include/asm/hvm/hvm.h +++ b/xen/arch/x86/include/asm/hvm/hvm.h @@ -391,6 +391,9 @@ int hvm_get_param(struct domain *d, uint32_t index, uint64_t *value); extern bool assisted_xapic_available; extern bool assisted_x2apic_available; +#define has_assisted_xapic(d) ((d)->arch.hvm.assisted_xapic) +#define has_assisted_x2apic(d) ((d)->arch.hvm.assisted_x2apic) + #define hvm_get_guest_time(v) hvm_get_guest_time_fixed(v, 0) #define hvm_paging_enabled(v) \ @@ -907,6 +910,8 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned int reg, uint64_t val) #define assisted_xapic_available false #define assisted_x2apic_available false +#define has_assisted_xapic(d) ((void)(d), false) +#define has_assisted_x2apic(d) ((void)(d), false) #define hvm_paging_enabled(v) ((void)(v), false) #define hvm_wp_enabled(v) ((void)(v), false) #define hvm_pcid_enabled(v) ((void)(v), false) diff --git a/xen/arch/x86/traps.c b/xen/arch/x86/traps.c index bb3dfcc90f..cabebf4f5b 100644 --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -1117,7 +1117,8 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, if ( !is_hvm_domain(d) || subleaf != 0 ) break; - if ( cpu_has_vmx_apic_reg_virt ) + if ( cpu_has_vmx_apic_reg_virt && + has_assisted_xapic(d) ) res->a |= XEN_HVM_CPUID_APIC_ACCESS_VIRT; /* @@ -1126,7 +1127,7 @@ void cpuid_hypervisor_leaves(const struct vcpu *v, uint32_t leaf, * and wrmsr in the guest will run without VMEXITs (see * vmx_vlapic_msr_changed()). */ - if ( cpu_has_vmx_virtualize_x2apic_mode && + if ( has_assisted_x2apic(d) && cpu_has_vmx_apic_reg_virt && cpu_has_vmx_virtual_intr_delivery ) res->a |= XEN_HVM_CPUID_X2APIC_VIRT; diff --git a/xen/include/public/arch-x86/xen.h b/xen/include/public/arch-x86/xen.h index 7acd94c8eb..58a1e87ee9 100644 --- a/xen/include/public/arch-x86/xen.h +++ b/xen/include/public/arch-x86/xen.h @@ -317,9 +317,14 @@ struct xen_arch_domainconfig { * doesn't allow the guest to read or write to the underlying MSR. */ #define XEN_X86_MSR_RELAXED (1u << 0) +#define XEN_X86_ASSISTED_XAPIC (1u << 1) +#define XEN_X86_ASSISTED_X2APIC (1u << 2) uint32_t misc_flags; }; +/* Max XEN_X86_* constant. Used for ABI checking. */ +#define XEN_X86_MISC_FLAGS_MAX XEN_X86_ASSISTED_X2APIC + /* Location of online VCPU bitmap. */ #define XEN_ACPI_CPU_MAP 0xaf00 #define XEN_ACPI_CPU_MAP_LEN ((HVM_MAX_VCPUS + 7) / 8) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 11 12:38:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 12:38:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365107.595178 (Exim 4.92) (envelope-from ) id 1oAsfy-0005vl-7A; Mon, 11 Jul 2022 12:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365107.595178; Mon, 11 Jul 2022 12:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsfy-0005ve-4P; Mon, 11 Jul 2022 12:38:10 +0000 Received: by outflank-mailman (input) for mailman id 365107; Mon, 11 Jul 2022 12:38:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAsfw-0005OI-Fy for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 12:38:08 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4f5cfd01-0116-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 14:38:06 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 11 Jul 2022 08:38:03 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by SA2PR03MB5755.namprd03.prod.outlook.com (2603:10b6:806:111::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Mon, 11 Jul 2022 12:38:01 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782%6]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 12:38:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f5cfd01-0116-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657543086; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uJu8c5OJnhKP15Sn1Vm6hFvo4jwcZ86BmomBCS+edME=; b=aNjeB+f/LlC8i2YZ4o8BOOYSbZS1S6pgh66u2kQPpm82P+Itq+jyHKrN XEb1RkXhWSZCtfHloSocMf0aNrwG1E+RlbXxvGoa2Qw1RwLglOGNPuIFz h2OjlOu7BU1jpRA2xb6wlurHSAnrZTlbGwUeJGMDm6RVrT+v9JusTI77f I=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 75937914 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Ae326a01+VsXyRRwTfbD5RVwkn2cJEfYwER7XKvMYLTBsI5bpz0Gz TQXWTiEM/rbNGT0ct8iOom1o0oHvJaEztZmQFY/pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOCn9xGQ7InQLlbGILes1htZGEk1Ek/NtTo5w7Rj2tEx2IDga++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Wlb7rTy0EI5fwhc9DTD5RIQhZGpVvreqvzXiX6aR/zmXgWl61mbBLMxtzOocVvOFqHWtJ6 PoUbigXaQyOjP63x7T9TfRwgsMkL4/gO4Z3VnNIlGmFS6p5B86dBfmSjTNb9G5YasRmP//Ya ow8YD5maB3GbjVEO0sNCYJ4l+Ct7pX6W2IF+QnK9PNri4TV5BBs+angKOKORu6XFNxNvXiWg WjZ4k2sV3n2M/Tak1Jp6EmEhOXCgCf6U4I6D6Cj+7hhh1j77nMXIA0bUx28u/bRolS5QNhFL EsX/AIhqKEz8AqgSdyVdx+3unmfpTYHRsFdVeY97WmlxqPK7i6DC2MDTzoHb8Yp3Oc0WDps0 FaKltHoADVHsbuJRHbb/bCRxRuiNC5QIWIcaCssSQoe/8KlsIw1lgjITNtoDOiylNKdJN3r6 zWDrSx7gqpJi8cOjv+/5Qqf32rqoYXVRAko4AmRRnii8g5yeI+iYcqv9ETf6vFDao2eSzFto UQ5piRX18hWZbnlqcBHaLxl8G2BjxpdDADhvA== IronPort-HdrOrdr: A9a23:d72gZauAFcyCtBLM1dWh+Ere7skC2oMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTP2ftXrdyRGVxeZZnMbfKlzbambDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjKzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIA/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfoWG0hYczDgNkGmpDs1L8Yqq iIn/7mBbU215rlRBD3nfIq4Xim7N9h0Q6l9bbSuwqfnSWwfkNHNyMGv/MXTvKR0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59ks5Vza/prVFZql/1pwGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlLhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OEDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowFLau3iee/Fm8Kc7gywlGl/NIwgF4vsul6RRq/n7WKfhNzGFRRQnj9agys9vcfHmZw == X-IronPort-AV: E=Sophos;i="5.92,262,1650945600"; d="scan'208";a="75937914" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BIKGn9dL9tntgx29ONKrJw3/3nMIXxEEWdG/c05EL2rMe34aNQHAeW0SItX39C4HQ80FEIyRMWSdJCOznA5aqBjxm/M7zqurqPgCezKTRjupId05Ldol0yhio+nXHOYmmedvet7kjhpWNvBK7rBi5FSutCq2CkP1cjBfS/GsdAqX3loN6CslJ5jGNhHX0RszT64gvOdF4NrvTatGlXrWED7tofqRwVjFlJHB4Cms3FxIGxKf1ECpx0o75DOpbP3sfUipaItkJUFHxuI2hT9mwtwGO9IN29uRU+LDwzqA2lPzZyRbu1kgCKhLAtiGu1ig8ol24+poQDZOfZp7STwfyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uJu8c5OJnhKP15Sn1Vm6hFvo4jwcZ86BmomBCS+edME=; b=Q3H/YibytEBStHmsM1fxw5F7BN+xlER0mk0u5hXiJHYeoI0z1qa5ZE7wxx0f3TIPNLpAKbfRcxAmk/RwLclon/WAhCJpsM+nQ8V38foPVjaXBwO7pDs4wJDGrIaO20tNJVSD0lZXFPuSTQUYzZwYWJodRaXMp1sWh6y2vxen2m0pn84edcDLBqpRgt0pwde9IRxEMCxW/3LYxeXpBChAvvqC1ZrKdRd8PEyAGJRrWg+AA3JD2Azx9bIZS/y0XDHBPJakseY4aaJKVmfYDmZanz6SI+k+bdhBDBX+LHAwlv2kBABt8QGOX2GJNEY9U4a9ekx2/kH1/uLdjuTIhfnUSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJu8c5OJnhKP15Sn1Vm6hFvo4jwcZ86BmomBCS+edME=; b=ovHw2OB6NIKYFIQBoIkh20JBa1F0SwJ9khvt9VQXsfFOUvhbMxXajX7RvfkkhmrFtmO07x0ezVmBpqxBl95uMlnZSIt8Iv1ioYEN7KiP2BIdWK16VLR2DiozbuxAIki7bPdILyfezhD0t5wXeZXqEaGlVNfOFK8aAxGxFaf97Os= From: Jane Malalane To: Jan Beulich CC: Wei Liu , Anthony Perard , George Dunlap , Nick Rosbrook , "Gross, Jurgen" , Christian Lindig , David Scott , Andrew Cooper , Roger Pau Monne , "Nakajima, Jun" , Xen-devel Subject: Re: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Topic: [PATCH RESEND v10 2/2] x86/xen: Allow per-domain usage of hardware virtualized APIC Thread-Index: AQHYi8Ac3FlD8zBv9U62svKKFrIqXq1nSpWAgAAsEQCAEWpoAIAAB0qAgABGQoA= Date: Mon, 11 Jul 2022 12:38:01 +0000 Message-ID: References: <20220629135534.19923-1-jane.malalane@citrix.com> <20220629135534.19923-3-jane.malalane@citrix.com> <6b01e02b-ba44-5f8d-f766-ac889c28d662@citrix.com> <64e06bd5-7919-7235-600f-b9b0e59ef66f@suse.com> In-Reply-To: <64e06bd5-7919-7235-600f-b9b0e59ef66f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8af6df9-5c77-4ee0-8210-08da633a3199 x-ms-traffictypediagnostic: SA2PR03MB5755:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dG6HinZm8rTUaRPEIH+ayF/SL4teufaGTqOzB7qoyJju6X5g4JdgBNE1224K1A3ZoR31o8pCAcubgM/kA3Ck5gvDmQ0HJX4fEyoKawxtVsu2ULmiu2i2Vn/22lx1K1BOvV1JEVMM6cl43VFJ/7DdlqIMmsGjSJYU2am5YqW0739XrUcua6dn51Sk6RG6NvVdhK01EWJGdkyNxv0aHbKuF2F5di+jlw/LuFBPxqBfuJOlamrBRJYUGGMaFfTIiEUhI3nHpuhBCdn3KELqS6g/Se3n5ZjGqYXRJ1JoY7X9FLLOh7+7zWAe/eiya+6dbSL7hXukEPAqvu6EclHX7D6a5LS79OJhlAPM3qzZGXz/NrT2ekBK3dttgIAEcuzHdmkBxGEnarGl/WZR4r9LCn0FXbCkqAHtmgsPFcPEwRiY9qoXyOVRMFroHORBp9c+np1O2GIjkzSJRWRZIesE7GiMReOkjc5PeaTHOvbcGXeoaw4DccHEq4KIMfCliUq6rR8yLfdeGt5eUkL1FIxEDdDVvYbWOYqXnecNhqVdMQ1aasAYk38HFgy62v4deyxfDrDwrLRdXmZV0aQuKzruz1ffzsTYpoMXxf7tKn7gnGOjGPvE2ZO/U5G7MuzIt+oy6mtN5p7N68NAbXxljIUu6aWdpNnM1XoJbhvJ1BowvrxN6DiGRI3FFY+phOqFSPe3BjSds58hrvYS7ioVVt/xpISMJ36ZETyqzNTacet4qbGXpxDp71aL/5QAVbjB1/VXdhrRUPtKftWizA4dxWEap0fhCBAbeiDkCOfaCnCDn4QpKnTIMQeJqoWVgvO7gYBU4jlXQm68JsbyxIgKraHdJwPc2rWYhE1XtXNER05GczH4pi4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(366004)(136003)(39860400002)(83380400001)(316002)(66946007)(66446008)(54906003)(91956017)(66556008)(6506007)(8676002)(66476007)(64756008)(76116006)(4326008)(26005)(6916009)(186003)(53546011)(2616005)(38070700005)(5660300002)(86362001)(31696002)(71200400001)(6512007)(8936002)(41300700001)(2906002)(6486002)(478600001)(82960400001)(36756003)(38100700002)(122000001)(31686004)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QlZudFg2ZUtndVp6OGd1V2YwS0JNb3hPWjZqMk9tcTd0ZVlyQitOSmE2b0Zv?= =?utf-8?B?N2ZGNkxCS1JVZjFKR3k2TysyVko0cmhHNG4wSVgzV2tjd2xzOGJZVkJBQk9J?= =?utf-8?B?NkllamlKTWtOU0thczFLTWNnb0F3cFJiaDNYS3BSV2F1OWVDeFMrWUpYbU1J?= =?utf-8?B?SjI4VWlJSkg4TmMzTVVzQ3FXN0I0Rk5WcjBuWXBtMk91VjQzRmFxT3hwQTFC?= =?utf-8?B?Wmd6a3pVNy96OUVpcXZaNml2RW94Y2RaY055OTdHb0FWbGRSRlBWWHZNRCtX?= =?utf-8?B?bFhoanhLVmtvMEI1aXhCMXZUN0RKSW1GNjAzaG9oNE5sQmpvRUNhbGZRRlhC?= =?utf-8?B?SjByc2VuT01JZDkvdFhlb3ljU1J1eElXQ3A4MnFnaUZyTkR5VGhQT3RhaXA0?= =?utf-8?B?YXFlQnNYM3NuSkd1UWZQVzhvcUk0cnl1OW5WSVp6aW1WckY5cExVa21pdDZE?= =?utf-8?B?RjUwVmk2aXg1UUJ2UzRqa0JxOW9iWk1zV3pYMUZMdUFHaTJmeVBDTC81K2hW?= =?utf-8?B?b2VBZzk3TGNNQzFsK3hMZVZHa29ySTF3U2dwdUg0b2RFRVc2QUZldFAzWFpj?= =?utf-8?B?OGRuUHlrSzJyZEx2ZmtZV25lemF3RkFySlRIcTBuS0VPSWc4Z0ZoVTZuYWY0?= =?utf-8?B?YjNUcFNuL1lSRzRDeVlaNE0rYmxOT3h5ZFpaaSthbTkrdndQWHcwOGtnTE9r?= =?utf-8?B?RkxpOGVLbEZ6YVl2TUJEZWl1NUErbnl2VXpkRXlkSG1BNGxJK3krTTdmMG5C?= =?utf-8?B?bW1JYlNxRlB2cG5kOGlqVm54SUlNZWFoMzBIbDFodkIrYWtHdFowMmpIUUsr?= =?utf-8?B?bmhkYk1CMTlkcmgxVU1lZlFEQmdobnJpbjFheUY5a283WEFOSENpSFluVzJB?= =?utf-8?B?YWZLMnNLWC9INU5OcWdjN2dHUU1lMTFGbmNQM0hodVVTNWltczM1TVZDVHhJ?= =?utf-8?B?Nno0bTZRWkpUcllSOExLUVpQYmxQcktGWS9ieHlvNmtSbzhDT09CQ2xKRERS?= =?utf-8?B?cVdsVGFXZVRLaWNUWVo4d1FWdEJGVEdWdGYzdngxS1Yza0tZWUxXUlpBVWRN?= =?utf-8?B?R2ZlZDFiQTZNdzJKeDkxQ1VsY05qRU1yR2xWK2ZGdldoZ2pIMFRLV1ZRUGVr?= =?utf-8?B?SWVMVFdIc1ZRMnlLQ1FSQkwwNnhzNWd5dFY5SGJvOEoxYW5rdG5qVlFYTURY?= =?utf-8?B?d1dMTFF3NlBiTVNQYUpwKzgzVHI5OW5xUU9mUElNUnVlL1V3N3c3Z3JUWmRm?= =?utf-8?B?QWhkUURvdU5MWGVUWG50M2wycjVUWGZKclh5Y1QydHdLOGtSU2lUWHY2Ry9G?= =?utf-8?B?V0pUeXl5ZUZrYlJicEE2R2RKa2cwRGprTER1ZThaTnB2SmxkVUl3aGR1dWpR?= =?utf-8?B?K25VUnNhdGFnUGM1VkFpV1MyMUtpZjhrd0FkOHlSR2c3T2EyNnZZZ0ErUXRX?= =?utf-8?B?bWxxa1IwS05GQk81Sk44WFBYazFyZzJUamZEbmNTcE9IV0pkVzRZa2hLdk1r?= =?utf-8?B?UFovVFBTdk5GSThFNkFvVzdxdVVNa3JKaCszZUVsSCt5OFlYdUI3b3ZFZDVh?= =?utf-8?B?bkl0VXA1K1RIRk9CMTB3b005R0Erbzc3cXZCMElScVdBMlRyejZlK1kvY2NE?= =?utf-8?B?Z1hQeTNRaFZ3SXZEaHdHMGhiRGhmYUFabDhRT3pwQ2IzWDE1dytQTERtM21M?= =?utf-8?B?anVsOWN4Nzdib1hXN1FPS3dkUUpKb2YxeVJzMDByWkdSdWZlWFpQa2V0VHFD?= =?utf-8?B?amtJdlhHSU5aSFpGSUhwWnVsQjQ5aThBZ1BRdFB6VGZQYVd5MlVaSm81czc5?= =?utf-8?B?VFZZRzdwQ0pMWU5JOTFmeVo4aUowUmJjNFVkd2VnYk9CT05nejJrSEpFYjly?= =?utf-8?B?Q2tYSmF3VklUNThuU1N1SERtK285QWtyYUpZRWdnTWxUV1ZCWTFkQUY3VHJh?= =?utf-8?B?Vm0zUWpIb0JBNmxHbGRUU2FhbXNjMWxIYnlsbnhHeFFobzhwME5ya05TdW1C?= =?utf-8?B?SXA5NTVvUUxlemhkY2lBNWh1SWZ1RXRqeHdBVnU0WWxaWDRTdGtSZEZLaUZt?= =?utf-8?B?OFBlcFFHUXl5SHpXYTBHVmxXcSsxOTFDQ3BiMjF0S3FaVXJRK3ZNNWcxQzlC?= =?utf-8?B?aUtmTjhkQi9UWmQ2alhmQnduZlRaaW5sVm90dEtNYTdRSUYxQkhFVE95M3FK?= =?utf-8?B?MFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <171FF0D5EB95514DB9F9E0464F882BE0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8af6df9-5c77-4ee0-8210-08da633a3199 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 12:38:01.7118 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 8la4bzYEpf34nrDNq3hhU4PbS7HXrMFddWwy3HRklhCsg+cgPCeCv/9mI+Bz6b79fPp65N5v5ecDP7d31xQUP9jFqTPBrh1C4Bkz3u1se2U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5755 T24gMTEvMDcvMjAyMiAwOToyNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDExLjA3LjIwMjIg MTA6MDAsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+PiBPbiAzMC8wNi8yMDIyIDA3OjAzLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAzMC4wNi4yMDIyIDA1OjI1LCBUaWFuLCBLZXZpbiB3cm90 ZToNCj4+Pj4+IEZyb206IEphbmUgTWFsYWxhbmUgPGphbmUubWFsYWxhbmVAY2l0cml4LmNvbT4N Cj4+Pj4+IFNlbnQ6IFdlZG5lc2RheSwgSnVuZSAyOSwgMjAyMiA5OjU2IFBNDQo+Pj4+Pg0KPj4+ Pj4gSW50cm9kdWNlIGEgbmV3IHBlci1kb21haW4gY3JlYXRpb24geDg2IHNwZWNpZmljIGZsYWcg dG8NCj4+Pj4+IHNlbGVjdCB3aGV0aGVyIGhhcmR3YXJlIGFzc2lzdGVkIHZpcnR1YWxpemF0aW9u IHNob3VsZCBiZSB1c2VkIGZvcg0KPj4+Pj4geHsyfUFQSUMuDQo+Pj4+Pg0KPj4+Pj4gQSBwZXIt ZG9tYWluIG9wdGlvbiBpcyBhZGRlZCB0byB4bCBpbiBvcmRlciB0byBzZWxlY3QgdGhlIHVzYWdl IG9mDQo+Pj4+PiB4ezJ9QVBJQyBoYXJkd2FyZSBhc3Npc3RlZCB2aXJ0dWFsaXphdGlvbiwgYXMg d2VsbCBhcyBhIGdsb2JhbA0KPj4+Pj4gY29uZmlndXJhdGlvbiBvcHRpb24uDQo+Pj4+Pg0KPj4+ Pj4gSGF2aW5nIGFsbCBBUElDIGludGVyYWN0aW9uIGV4aXQgdG8gWGVuIGZvciBlbXVsYXRpb24g aXMgc2xvdyBhbmQgY2FuDQo+Pj4+PiBpbmR1Y2UgbXVjaCBvdmVyaGVhZC4gSGFyZHdhcmUgY2Fu IHNwZWVkIHVwIHh7Mn1BUElDIGJ5IGRlY29kaW5nIHRoZQ0KPj4+Pj4gQVBJQyBhY2Nlc3MgYW5k IHByb3ZpZGluZyBhIFZNIGV4aXQgd2l0aCBhIG1vcmUgc3BlY2lmaWMgZXhpdCByZWFzb24NCj4+ Pj4+IHRoYW4gYSByZWd1bGFyIEVQVCBmYXVsdCBvciBieSBhbHRvZ2V0aGVyIGF2b2lkaW5nIGEg Vk0gZXhpdC4NCj4+Pj4NCj4+Pj4gQWJvdmUgaXMgb2J2aW91cyBhbmQgY291bGQgYmUgcmVtb3Zl ZC4NCj4+Pj4NCj4+Pj4gSSB0aGluayB0aGUga2V5IGlzIGp1c3QgdGhlIG5leHQgcGFyYWdyYXBo IGZvciB3aHkgd2UNCj4+Pj4gd2FudCB0aGlzIHBlci1kb21haW4gY29udHJvbC4NCj4+Pg0KPj4+ IEluZGVlZCwgYnV0IHRoZSBwYXJhZ3JhcGggYWJvdmUgc2V0cyB0aGUgY29udGV4dC4gSXQgbWln aHQgYmUgcG9zc2libGUNCj4+PiB0byBzaG9ydGVuIGl0LCBidXQgLi4uDQo+Pj4NCj4+Pj4gQXBh cnQgZnJvbSB0aGF0Og0KPj4+Pg0KPj4+PiBSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8a2V2aW4u dGlhbkBpbnRlbC5jb20+DQo+Pj4+DQo+Pj4+Pg0KPj4+Pj4gT24gdGhlIG90aGVyIGhhbmQsIGJl aW5nIGFibGUgdG8gZGlzYWJsZSB4ezJ9QVBJQyBoYXJkd2FyZSBhc3Npc3RlZA0KPj4+Pj4gdmly dHVhbGl6YXRpb24gY2FuIGJlIHVzZWZ1bCBmb3IgdGVzdGluZyBhbmQgZGVidWdnaW5nIHB1cnBv c2VzLg0KPj4+DQo+Pj4gLi4uIEkgdGhpbmsgaXQgaXMgZGVzaXJhYmxlIGZvciB0aGlzIHNlbnRl bmNlIHRvIHN0YXJ0IHdpdGggIk90b2giIG9yDQo+Pj4gYWxpa2UuDQo+Pj4NCj4+PiBKYW5IZWxs byBKYW4sDQo+Pg0KPj4gSW4gdGhlIHByZXZpb3VzIGVtYWlsLCBJIHdhcyByZWZlcnJpbmcgdG8g dGhpcyBkaXNjdXNzaW9uIGFib3V0IHRoZQ0KPj4gY29tbWl0IG1lc3NhZ2UuIEkgaGF2ZW4ndCBz ZW50IG91dCBhIHYxMSBiZWNhdXNlIHRoZXJlIHdhcyBubyBjaGFuZ2UNCj4+IG90aGVyIHRoYW4g dGhpcyBvbmUgc3VnZ2VzdGVkLiBXaGF0IEkgc2FpZCBlYXJsaWVyIHdhcyB0aGF0IEkgdGhvdWdo dA0KPj4gdGhlICJIYXZpbmcgYWxsIEFQSUMgaW50ZXJhY3Rpb24gZXhpdCB0byBYZW4gZm9yIGVt dWxhdGlvbiBpcyBzbG93Li4uIg0KPj4gcGFyYWdyYXBoIHByb3ZpZGVkIGNvbnRleHQgZm9yIHdo YXQgSSBzYXkgYWZ0ZXIgYnV0IEkgYW0gaGFwcHkgdG8gcmVtb3ZlIGl0Lg0KPiANCj4gSSdkIGJl IGZpbmUgZm9yIGl0IHRvIGJlIGtlcHQgYXMgeW91IGhhZCBpdCwgYnV0IHlvdSByZWFsbHkgc2hv dWxkIGhhdmUNCj4gc2VudCBvdXQgYm90aCBwYXRjaGVzLiBUaGVyZSBhcmUgcmFyZSBjYXNlcyB3 aGVyZSBzZW5kaW5nIG91dCBpbmRpdmlkdWFsDQo+IHVwZGF0ZXMgd2l0aGluIGEgc2VyaWVzIGlz IHJlYXNvbmFibGUgKGUuZy4gdG8gYXZvaWQgc3BhbW1pbmcgdGhlIGxpc3QNCj4gd2l0aCBhIGxh cmdlIGFtb3VudCBvZiB1bmNoYW5nZWQgcGF0Y2hlcyksIGJ1dCBJIHRoaW5rIGhlcmUgeW91IHdh bnQgdG8NCj4gbWFrZSB0aGluZ3MgZWFzeSBmb3IgY29tbWl0dGVycyBhbmQgbm90IGhhdmUgdGhl bSBodW50IGRvd24gdGhlIGVhcmxpZXINCj4gdmVyc2lvbi4NCg0KQXBvbG9naWVzLCBtYWtlcyBz ZW5zZS4NCg0KVGhhbmtzLA0KDQpKYW5lLg== From xen-devel-bounces@lists.xenproject.org Mon Jul 11 13:16:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 13:16:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365119.595190 (Exim 4.92) (envelope-from ) id 1oAtHE-000263-7q; Mon, 11 Jul 2022 13:16:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365119.595190; Mon, 11 Jul 2022 13:16:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtHE-00025w-3x; Mon, 11 Jul 2022 13:16:40 +0000 Received: by outflank-mailman (input) for mailman id 365119; Mon, 11 Jul 2022 13:16:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtHC-00025q-BD for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 13:16:38 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10073.outbound.protection.outlook.com [40.107.1.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0707028-011b-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 15:16:35 +0200 (CEST) Received: from AS8PR05CA0022.eurprd05.prod.outlook.com (2603:10a6:20b:311::27) by VI1PR0801MB2079.eurprd08.prod.outlook.com (2603:10a6:800:8e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 13:16:33 +0000 Received: from AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::41) by AS8PR05CA0022.outlook.office365.com (2603:10a6:20b:311::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Mon, 11 Jul 2022 13:16:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT053.mail.protection.outlook.com (10.152.16.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 13:16:33 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Mon, 11 Jul 2022 13:16:33 +0000 Received: from 35722b311dfe.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 49C5D426-D7EA-439B-8774-C390F38A1743.1; Mon, 11 Jul 2022 13:16:27 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 35722b311dfe.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 13:16:26 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4279.eurprd08.prod.outlook.com (2603:10a6:20b:bb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Mon, 11 Jul 2022 13:16:24 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 13:16:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0707028-011b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=P+XLbzx7dWTX/hMxgLojT12BTfvuqZ8l/2W3aPRKgFFXcECMFHYYeKiPO4PvGY7I5jIHLm6jahQxOnRkRKRZL0IVr/gETTytd8ifIvk7eoW7sj4l0hqhwOmLaQ+WUQH+8WntlwNMuIR56AgCwWZA74EQTHi0CsB+b9x+3I+RRTgHaRLiVoiPbvLDh36n7s5bRvAtu6BBAHuiMC5Xy6rBTcVulJWvOL+ZZArAmn+1KfsELG2FzOOFBJFiGZlzaXu/Al+O0t1QykUlO7d9D5KF9YCiaZqgD947Na45GblzSpDz8rPyQs+If/DSbbCwWfCd55rHar+tV16hzk8p1jxI2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XyHL7k9sDbzNZSQxIZNh4sn2ME+ML1tTLUUsJeBh7w=; b=Pr0IKYUkYOLU5LUwcQBvm4ktUR39rVCvIyyPfC5+5xz/vhZTH4yCoxtTdBgLDkqjIFpM4a9BZLy30dFfvw9DluOOO3T4X0K46Yo6PZoK9SQ6XHSfW/1DMKSXHAEUNxkzJEaEFb7OoOvlBuuRmB+bRaPRMt2G/TnsCUeCAmqxsQaVW/cpAE5PM0BQVZctfg+05Px4t2O2wA5c3NkNZpGo/KrQVsCAPi+0bG11cxKHpNXtII1B9uof5HOukM3yT4c/1g6kvvEJdtfLHpP1rQDIojjAljt85UzK7p0CqUAsPfU3X72ECJcsx0BQnmERAbBZJhgL7ZPZkM+2dIfWlh7pRA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XyHL7k9sDbzNZSQxIZNh4sn2ME+ML1tTLUUsJeBh7w=; b=G2m0vAMtgpHvsCpJn+0QYQvwUBb5208f0PlVT+15BN8EnumhJYYkFJ90rQaibld5ZwhyjzbTJwCL0rjvNoJOt+iXxfhNyq0ZmFfbuLUWJ7arMzrc3EVi6XcdE4/lQTRplRfDt8czFdo19JAyk9iSGvF8SSKVwvgIieL8HkxSNik= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6c631df147a3a9e4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jBdzj2mLiL87hCWfbFDrvSFLpDz6QxIOMcQc4CGQV4Ebqrq7bVp2iG+rLzCsYAIjxXVZb9La/yKYxLG2TQJsMU2XIsDukUitA8E9SWGOxZ0nVPCTWAsmdkCHLFsnUAoouoMTZHSejxA4vmxA2UTRgJWCkkN9FbKkFqczhUO3A2BzteKGg2v6a5BpliD1S518jxe+quwi2TuNImNYegDgOQSgMqXFAXcZ6Ja7QJRV0TnrBga/rmLql5c9r2kdPowzh/+h0p+W0R2LIFMEm0ceIu6mI3Dc7MLgtkj4KO8GK8ieh+Tk4EJDC3Mij4U0au7mFZJHX3VpQYU0VJ2qZxul2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1XyHL7k9sDbzNZSQxIZNh4sn2ME+ML1tTLUUsJeBh7w=; b=R0wiBgpOS1WFHMrV5flGcBjIEOMljiuWzqKWUT1vO6tgiNm2FnUv7J6zJpiQo8zgJkm+lwhfPg8Ie6hEbFufKEwhSKnYRXlsnHKCpez6LyvH81kpSS/cxukIeofL8qLr/Q0OIr4cR/IG2lY8DoACuO5mi0Hty8Ywt0nfbCSPSKk6zaajEuE4Y3ViU6i7v6cduFxOgVHm36KV9vKWRRg1hLedi1WAEWodZvMtL1/zD/Ki/PZE/9uo45hEZdUJNziUTk1ay1YtkYJPnS5SjUxNrTHsIoNN5snLTEGkNzAOj95OELezBOLe4qefKWcjuDF2ikZSq+cwyoG4q7dQwoRPHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1XyHL7k9sDbzNZSQxIZNh4sn2ME+ML1tTLUUsJeBh7w=; b=G2m0vAMtgpHvsCpJn+0QYQvwUBb5208f0PlVT+15BN8EnumhJYYkFJ90rQaibld5ZwhyjzbTJwCL0rjvNoJOt+iXxfhNyq0ZmFfbuLUWJ7arMzrc3EVi6XcdE4/lQTRplRfDt8czFdo19JAyk9iSGvF8SSKVwvgIieL8HkxSNik= From: Luca Fancellu To: Anthony PERARD CC: Xen development discussion , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [XEN PATCH v3 06/25] tools/fuzz/x86_instruction_emulator: rework makefile Thread-Topic: [XEN PATCH v3 06/25] tools/fuzz/x86_instruction_emulator: rework makefile Thread-Index: AQHYh+Q/HQapn5xyFk+tBpnRucH3tK15QQ4A Date: Mon, 11 Jul 2022 13:16:24 +0000 Message-ID: <2F79AABB-DC61-4DC2-8C0D-23585B27AA4C@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-7-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-7-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0a7b0648-ccd4-4328-aaf2-08da633f937c x-ms-traffictypediagnostic: AM6PR08MB4279:EE_|AM5EUR03FT053:EE_|VI1PR0801MB2079:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YhtEvT8UwD417gCfr6Tykwo5/2elyF4mNxWDzcxKtWGzaAKqp6fazv9BJ2GeGVcp0eWk0Vntl85UPtYgiAXVcXRX9eFgLeKOWZQLQsou6gEUPYTxqbTZVrKEGQgJiUPC4wW1WpjYeFI+1vmvdDlR54myjjDW/seKDp/9e1lPYXnSdL8cE/LfgGCxhv7vkY/aLYVlyB8mIjOpQrPbqe2vwwnStGTlMjJRdQBNGf7VD5jDp/jBaRklQklJ+cbaQEbZaDwMApilXC1/ubgq8uxB9EfPIPbM6CR4ODl3DJMf4GjzmCGQs8V+VvgMnNrcqqIAFvgSbkITlgMUbUYf/hiaLhmZRHiHdhWqQ6GhjkHsAy7ZThpUCnoACiHvkkYaqRKkk6dAusjdJlg0WXyO8jduyCdywHTIjbxaepqxGGzUOzRET15ID1vhKtVlzPlSvdSaTROx2ocNVTk9M+iUjKQHK6VZp4ObCbG69qCBnj0yf+R7Gvz2+FJPLZbbO05yp//ZDqCtyrAoF6M4+p24GJZmHMV3UK++583dARshJ4pH9Z/hxX0DL/SAgYBTLqc5ybnB0pWp2NTXflaKjG5MeNcsJGdjuV2WehlBO1BAZr2Fy2NngWh/S3c27N0fz4dttMACc9/5ZG1534L6oJobfLrLdk84owdtCq26n8tWO3FzTJKiweG80tVnNE5uxqSahlI4gVDOBNui/t7UiZ88IEYjX4lesLUXRI1nz48ma2nJg5XUvjkbRc1ljnNcvaGVnBSbPJNK/7bOu3WQEFUZQ1rVuCroupuZk/Tza1Wt17/CKRJIKgfRajAeM3hobiBiB4xp3A4FC4jsH6KbIQ6fHUe34dYPpjGRXqcU849NrlYfz18= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(86362001)(2906002)(26005)(478600001)(6486002)(6512007)(38100700002)(41300700001)(6506007)(33656002)(53546011)(4744005)(2616005)(5660300002)(8936002)(186003)(83380400001)(38070700005)(6916009)(122000001)(36756003)(8676002)(71200400001)(66446008)(66556008)(66476007)(66946007)(76116006)(4326008)(91956017)(64756008)(54906003)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9AA3B884C220BE4FB86882A202569FEA@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4279 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 921a7725-8707-4bdf-92a1-08da633f8e32 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TLhdRAT1u9gCuDa6vudwwCKYj+60lk/zqc82w0hn7Hpb1BQTG5Q66WzFF8czjHCeKQwI12VO+KxptK4U3hn8T0Z68bCERnlRpdGdvfZhFwM+nScuYcCbR30TcYcmlNkUDBt1FA75+4lc/ufUpelmgCC0tDLxtC60Jodpjgmrxyr5KrZ/UIXYT3o5fx9XMMQPnP4mOsiyK+G12dpNWCaSqKcTCRcSKfQ5TLssR2T1IrloLpC+pJ1sXpckbRj20dfKfiQtbYk5VFTNiIU4aa6A/5Avx7LCRHOC7Eil5VGVL5umMKierHG569BecbnVDBG7BxluytnNGjjvBviURGAZKfcXRDBUgXARgQciIwEpp2k6yG0eZsETMLsRaEhieLVPVNSPL56zaPWqcuwZ0Ug5iPQhvCscuggkBNr0KN2ssN2qmZAvtZe1uXHqRMlNWvAdKr/rP1kEKoOBV5I/YmO6jbh4ce25ZLPqZHY4D5IP0Kz8v+WNdfcYnw6gZf2PEgj93vJJhP9/TLCH1o/7kDBgTndk7c19q013neGLi1fFqhVE3ZqT0ioUecuactbYWNqL21i8h/xaXlprSymttSOVWKcGhGV8JtIzyyzB4VWF9L9m0JzM7nhnX/mBGTtEczRvYLALCmWdCLcvuRCDaY0YcYCbKXbDirPAcdzOdHZIzIJZv0zFZaktLsuzjZ+hoStrLLZKb/ywhD+epuDPPb5wWCobu/sk/fyPFQvIk3WUut7J/aFJyoHSRwlOKyGddauLdkhZgv3OvrqOD8FvonU8ZrC+t/eDmrEY0/GVliNTKsSXSTnBMEkCXOncUgkNRh8w X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(36840700001)(46966006)(40470700004)(2906002)(47076005)(36860700001)(33656002)(336012)(6486002)(478600001)(83380400001)(356005)(40460700003)(82310400005)(36756003)(4744005)(40480700001)(186003)(5660300002)(316002)(8676002)(86362001)(70586007)(6862004)(81166007)(8936002)(54906003)(107886003)(4326008)(26005)(82740400003)(41300700001)(53546011)(6506007)(2616005)(6512007)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 13:16:33.4231 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0a7b0648-ccd4-4328-aaf2-08da633f937c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2079 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBSZXdvcmsgZGVwZW5kZW5jaWVzIG9mIGFs bCBvYmplY3RzLiBXZSBkb24ndCBuZWVkIHRvIGFkZCBkZXBlbmRlbmNpZXMNCj4gZm9yIGhlYWRl cnMgdGhhdCAkKENDKSBpcyBjYXBhYmxlIG9mIGdlbmVyYXRpbmcsIHdlIG9ubHkgbmVlZCB0bw0K PiBpbmNsdWRlICQoREVQU19JTkNMVURFKS4gU29tZSBkZXBlbmRlbmNpZXMgYXJlIHN0aWxsIG5l ZWRlZCBzbyBtYWtlDQo+IGtub3dzIHRvIGdlbmVyYXRlIHN5bWxpbmtzIGZvciB0aGVtLg0KPiAN Cj4gV2UgcmVtb3ZlIHRoZSB1c2Ugb2YgInZwYXRoIiBmb3IgY3B1aWQuYy4gV2hpbGUgaXQgd29y a3MgZmluZSBmb3Igbm93LA0KPiB3aGVuIHdlIHdpbGwgY29udmVydCB0aGlzIG1ha2VmaWxlIHRv IHN1YmRpcm1rLCB2cGF0aCB3aWxsIG5vdCBiZQ0KPiB1c2FibGUuIEFsc28sICItaXF1b3RlIiBp cyBub3cgbmVlZGVkIHRvIGJ1aWxkICJjcHVpZC5vIi4NCj4gDQo+IFJlcGxhY2UgIi1JLiIgYnkg Ii1pcXVvdGUgLiIsIHNvIGl0IGFwcGxpZXMgdG8gZG91YmxlLXF1b3RlIGluY2x1ZGVzDQo+IG9u bHkuDQo+IA0KPiBSYXRoZXIgdGhhbiBjaGVja2luZyBpZiBhIHN5bWxpbmsgZXhpc3QsIGFsd2F5 cyByZWdlbmVyYXRlIHRoZQ0KPiBzeW1saW5rLiBTbyBpZiB0aGUgc291cmNlIHRyZWUgY2hhbmdl ZCBsb2NhdGlvbiwgdGhlIHN5bWxpbmsgaXMNCj4gdXBkYXRlZC4NCj4gDQo+IFNpbmNlIHdlIGFy ZSBjcmVhdGluZyBhIG5ldyAuZ2l0aWdub3JlIGZvciB0aGUgc3ltbGluaywgYWxzbyBtb3ZlIHRo ZQ0KPiBlbnRyeSB0byBpdC4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxh bnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KPiDigJQNCg0KSGkgQW50b255LA0KDQpSZXZpZXdl ZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Mon Jul 11 13:39:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 13:39:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365126.595201 (Exim 4.92) (envelope-from ) id 1oAtcb-0004nF-6F; Mon, 11 Jul 2022 13:38:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365126.595201; Mon, 11 Jul 2022 13:38:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtcb-0004n8-3D; Mon, 11 Jul 2022 13:38:45 +0000 Received: by outflank-mailman (input) for mailman id 365126; Mon, 11 Jul 2022 13:38:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtcZ-0004n2-Bk for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 13:38:43 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c54d62f5-011e-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 15:38:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c54d62f5-011e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657546720; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=C1JIpxUxEqS1qXuzjxxekE0wJgUC+1iqSnMv/HZ4EYg=; b=Sq/UaQ4GCqhUH/r1mYkWv6nTVlUrlbnh9hAxLPEz83uoVFNa4I2aI2F1 7FYFoI0Li41OZglHqBY5N6//+npImRGfrK1LwvN+4HLef+34c4K9EseD3 XxiEv6jIsCik9kNPCmRqX5BdLMna2I6iwqMUcZzLJ2q6ZUFvzMCyPTQIZ g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 78082890 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:10OJiqkIOxP97FCaXGm2Rsvo5gzoJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIcWmvQb62MY2r8Ltoja4Tjpk8BupPUnNZhTlQ4qC8zQSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EgLd9IR2NYy24DmWlrV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYVD8UG/fip9UhShxyLAhGY4xG+7L+GC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3s3d8zTbfHLA+TIrKWani7t5ExjYgwMtJGJ4yY uJGOWI/NkSRO3WjPH8XC619wfW1r0DZMBQEqFCNrpE2/zPMmVkZPL/Fb4OOJ43iqd9utkSSq 3/C/m/5KgoHL9HZwj2AmlqzgsffkCW9X5gdfJWc6/VjxnOawGceDBkLfVKhpL+yjUvWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSICy 2e0uonHOg1Tqbi/dlulqJaUrj6LAH1ARYMdXhPoXTfp8vG6/txs1UqVE486eEKmpoarQG+tm lhmuAB73uxO1pBTis1X6Hid21qRSo71ohnZD+k9dkas9UtHaYGsfOREAnCLvK8bfO51orRs1 UXoevRyD8hUVPlhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeRg1bZZdJmO4O hO7VeZtCHh7ZSHCUEOKS9jpV5RCIVbIT7wJqcw4nvIRO8MsJWdrDQllZFKK3nCFrXXAZZoXY M/BGe71VC5yIf0+kFKeGrZGuZd2l39W+I8mbc2ip/hR+eHGNCD9pHZsGAbmU93VG4ve8V+Kq IcPbZHQo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:cTEk8qP9Ua50g8BcTsejsMiBIKoaSvp037Eqv3oedfVwSL39qy nIpoV96faUskd1ZJhOo7290cW7LU80sKQFh7X5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAtFD4bbLbGSS4/yU3DWF X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="78082890" Date: Mon, 11 Jul 2022 14:38:21 +0100 From: Anthony PERARD To: Luca Fancellu CC: Xen-devel , Jan Beulich , Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> On Fri, Jul 08, 2022 at 03:39:00PM +0000, Luca Fancellu wrote: > > On 24 Jun 2022, at 17:04, Anthony PERARD wrote: [...] > > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use > > full path to "mkhex" instead of a relative one. Lastly, add "-f" flag > > to "mv", in case the target already exist. > > > > Signed-off-by: Anthony PERARD > > --- > > diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile > > index b754220839..fc20932110 100644 > > --- a/tools/firmware/hvmloader/Makefile > > +++ b/tools/firmware/hvmloader/Makefile > > @@ -87,21 +89,21 @@ roms.inc: $(ROMS) > > > > ifneq ($(ROMBIOS_ROM),) > > echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new > > - sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new > > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new > > echo "#endif" >> $@.new > > endif > > > > ifneq ($(STDVGA_ROM),) > > echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new > > - sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new > > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new > > echo "#endif" >> $@.new > > endif > > ifneq ($(CIRRUSVGA_ROM),) > > echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new > > - sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new > > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new > > echo "#endif" >> $@.new > > endif > > - mv $@.new $@ > > + mv -f $@.new $@ > > Here, instead of -f, is it safer -u? What’s your opinion on that? The patch looks good to me. make want to rebuild the target, so there is no reason to keep the existing target. We do need to overwrite the existing target if it exist. Thanks for the reviews! -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 13:40:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 13:40:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365131.595211 (Exim 4.92) (envelope-from ) id 1oAteS-00067B-I1; Mon, 11 Jul 2022 13:40:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365131.595211; Mon, 11 Jul 2022 13:40:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAteS-000674-F3; Mon, 11 Jul 2022 13:40:40 +0000 Received: by outflank-mailman (input) for mailman id 365131; Mon, 11 Jul 2022 13:40:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAteR-00066y-2o for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 13:40:39 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70051.outbound.protection.outlook.com [40.107.7.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b926cf3-011f-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 15:40:37 +0200 (CEST) Received: from AS9PR04CA0092.eurprd04.prod.outlook.com (2603:10a6:20b:50e::6) by AS8PR08MB6695.eurprd08.prod.outlook.com (2603:10a6:20b:399::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Mon, 11 Jul 2022 13:40:34 +0000 Received: from AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::6a) by AS9PR04CA0092.outlook.office365.com (2603:10a6:20b:50e::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Mon, 11 Jul 2022 13:40:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT048.mail.protection.outlook.com (10.152.17.177) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 13:40:33 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Mon, 11 Jul 2022 13:40:33 +0000 Received: from 0fdd8ed34ac7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2F85C653-0F76-4295-926B-A769F466DF8C.1; Mon, 11 Jul 2022 13:40:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0fdd8ed34ac7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 13:40:26 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DBBPR08MB4759.eurprd08.prod.outlook.com (2603:10a6:10:f3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Mon, 11 Jul 2022 13:40:24 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5417.026; Mon, 11 Jul 2022 13:40:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b926cf3-011f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nzX0EM9ELMGczQnvtOdm3ynPBktFYg92hmiirsklHr+CAtW8vpUMgItQX7l/syRV9AV0biJwMjgzX3CdgfGe7uys27dTG7l+e6fdA/GTp+wrsPrIYD/sTbSakOrFNrrtTjQ3TFcp/gtVnleTUc7BwCbwd+nsXIWNs++7bI6QPJWSvYhtSHUSJoc+Ge+6TxpM60Sd+/hgMaRzJudsdJWkegqanBAAJm15W9nJjomRsAmQSNjKPBObmBCr2JpHd/WgL8GyoPmAMHpy2PRogplVelI4ZaWSy8Q6giCcqBGGPybL9JElikICN6ur9fyKK8woW0aNL5w/XMM1KxW+WCJUcQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=cU4NaVXZRGCkJvYCSnsypyhV7tn1K+yECBPq4O4+prHCSASLtfAHkce3Ut5+jPPxda5kfo2QlWIApHd/ey29O4LBkH4d3e/BM+RSxm13RvJ96eS1xqYuzPLPx9r4TwgdjU1iThK0i4sSoRwDdwMvtHk7jSzQOiSrMaIA9wEe06twjSIejkVne7WA/Lp6aOdqLg7kOJoJUVIb2xnlOx9ueoYT2fA0ocADK7BJzDI4RSmNF/RhbEnLARNGB/Nvsta42U6xQAdvvL5nHsiY9eXG3ZXyjcsBq8ydImvYPuVpu1yWKS/KT56aKb0EKo7/UmuEWOmZguVaYV7ymNF6uEc27w== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=pgvmor8lSvMe5bXxWuo09+4bvBbmcqLTejZ77AnX/lE4mZv80GpvKkVRI2Y8ft75lPnEHNlmCdMupasyovzC/Wlud+Raja7J/6hDiqkNN7orskpJOKsq1yS4+E/Vi1m91C7LsJr8bWpQmZuOrAcRIdShOZUudeZrCZqI0ETdyBU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6bbfb045e29fa712 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K21GRh6bKPRf/KnUkF6hYJ+QKClSM/lVcKwCnDKJl+mO072n6e7v9DLrUeg669KqRKWQJeagbSTXDdGxyZW2d75HwOOw6KY7fKeqt5gKPJUGTSC1NMdHHFApmCd4OgTySn5NVwPySnqdqXCU8b8EMubCdAfNtTlA6KuaDfLoW1o6D8Mrd1pALTkUdeDJ5iu6plnXEbHq30MtLCiOWCKRzHwERaA/TBGs8/WDRd+WIB9Yj2zoivwTSmVhJtnsh/8fRjpr5eiuEJnZSae+WYMiYYugSJdHH5agF2ibboKc6P2FIbmI3YffDLtpTaxL+/0AaKc8SNB8VjOKf7gapgXTTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=PzNWAMqh/+xBlsBhyYl9JvGIyMC/s0prXxbhh8MkocmBKHzh7qfWRCpZsQecA00fLGdI90hqHOO7avOSPHb+KIc8bHLwnw0Uz9y3xgbdZz8K2Zeux7LAG/XPPFDUt8ZNREGe3fCHrICMRr+iNHQIEqXtMkF/5DQykIWR5dcOAo5motyzgyeSorAVfOsVGbSrgHAbGDoOvu+I5biTH5yVRAXFaNDoSAOudBZRS8s3t/oFpAaRwi9hA8nlEWGVydKDeHyjxw6ylqdi6ePPcQaLxAzXfisnQQKmH40Sn+icxbSpa467vzRyUJaSn0o7iRb2bGzn3G1b4gvX9clCFRx7BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kiDl7AjcjKfAQDcF4b1pL5X+NtcCzrj+va2tVc3T7nU=; b=pgvmor8lSvMe5bXxWuo09+4bvBbmcqLTejZ77AnX/lE4mZv80GpvKkVRI2Y8ft75lPnEHNlmCdMupasyovzC/Wlud+Raja7J/6hDiqkNN7orskpJOKsq1yS4+E/Vi1m91C7LsJr8bWpQmZuOrAcRIdShOZUudeZrCZqI0ETdyBU= From: Luca Fancellu To: Anthony PERARD CC: Xen-devel , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Thread-Topic: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Thread-Index: AQHYh+Qt/49JLdoEv0uAADgNQkPLF610seaAgASVSoCAAACRgA== Date: Mon, 11 Jul 2022 13:40:23 +0000 Message-ID: <316E0891-D201-47BE-B616-A785CE1B114A@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2e464938-a073-4083-e16a-08da6342ee05 x-ms-traffictypediagnostic: DBBPR08MB4759:EE_|AM5EUR03FT048:EE_|AS8PR08MB6695:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hWipdXfb29WPqtHost+PCCM/LVm8DnKq9wFSnTuBenqKDkCunh2eHTjje13jTcXw00hLUmXBt9QQbsgT5SJCrWAtOz8xUN9j7DwlFfGQauxbLw17onc4DkQ2vz7UDJ5Jr16JDmwesKukAxbE288aA6pweJpDrgy+mbGwFCHyKmt2/CRFwzJ5ytmg4ozHfvRYDaGQ1+7UXTacwgyEWMx2IybsZtUNPuWmuAcTRaErEA3PCpeEnlJhFcO2ezqWNAXZU0eli7Mp5pv6Ei3gzCcaj7fhQL1fuvsTnu5hF0OxXBUJpMGzG6aXQIcrj2GPuEnelPkcXxaaTE+ss8z9PJgyJ8CrM3TV8n0lKVdvvK/hkp7S5EimTt/QRmZ+KLIIvJdjde28kGUnPDdrUrsCLFyTgIiENge0Cxt3hCH2Kcz3Mrjo5+H0OLlhF5gaWmBeEjA89fJLLKa1Lra1huzDWifj3HhnMUOQ9rbzvAkJorrvRD6BeM2T8YFA1hytopiT/D4rItOtghnoDj9urG3mXlhGeunjeURXOijbWZ+BDrzUlQLoyh1myv3lU+AbFQyz9PAZQVZPPuFXj7VYDirYZbCIZUkAdCIbcwL2TgvuJpTAykH+ghMyo6cSZ9FmqviBMCdw080VcQpG+jEOl8Zq0UKziuvSEF67fmifzyTo/p2akVFiONO8VIPJhaAJw3681B4E0/H13AGYhOkxlXpJWDBOfQO/el7svQ0vQq1peizdCR6nlKncESNsoQcUT/R6hlePD2CAe5T3SjWQd5C4NHt7TJMm4snnjgTcNARD3SjNrtn4QyfZlVeqoQsx7TEQ4cUlFWX4lCEFlTm0MIoGaHXJ3wGVkCsprz27Mj++9QCW5vo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(366004)(396003)(316002)(8936002)(5660300002)(122000001)(26005)(33656002)(91956017)(478600001)(54906003)(6512007)(38100700002)(6916009)(36756003)(2616005)(38070700005)(8676002)(66946007)(64756008)(66446008)(66476007)(71200400001)(76116006)(66556008)(6486002)(86362001)(53546011)(4326008)(186003)(6506007)(41300700001)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <17A887557D9ECF4FB09046BA530EF901@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4759 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9f40a5a7-cef8-4aa9-339a-08da6342e81e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YStjcKmmG36FT27FeiWCmH/AF/94pWJSrDPbjkrcmcrSwOTC7+uHBGNNZsXnygkVQo1Oe9/31hQyVapwi6ukqMPv7Yr7vwt6ZEXc44csECmwyEuHLfbkbgIwZkanlkZelrPszHseV9nO1dWTjSfGppxgqhCbK5tYem9EKEST6qKGK2nOFBYRHbOheDebosSiL6zdFSxaSTW9Tzns1+Iju0pciK4U4j/kkuSgOMmzalWqALPXoeWcxMFVytb48hnyM6lvX5j5C+YAyiBj5NkPiRCAI35fdqJDzHNsH+Jvs1Y+m8+ZfD5Fog5ZMBeqWNR8rPgyEWu0Eh9jkLEfDOm2n9TZq4ra8Bqh4bw7Tkv3W2AySN/CIsZ7PWmuVPnCqYVjBW/mk7zdn9kH3t9uQB7Gn9okFoEgW+Tcdxz3eZMNCj+dWcux7EhCpJCQjbL1FKtjq5qbcdfpMoD7+3BgeNTN0224jLSVLqz00i0uIzINV2UD56sh8XTQDweE/0dixkFBJaGbukXWtD5eQt1lcctUYBkHO/NRXY+BAHXk7Q/NyA0LpqhuAa0/VQxqq3NQhDYHjEkZvonfJBZJiowFlWeHJJ1NoxZyimrs7zicVHLjR99Cig/JN1YCaoEUq0aObjzxORxCVovrgZIc5auH38lm90BMYes/09fCxLlaiL/3uHx8k6r6Nkv9F9r6ABYgrUpJtmCxn/myCS+of7vEennlHrgchlZTtyW/Wv1e1IJEP5zzV3BykBqnyYmqmhmCfyJ60YctnGdN/43rl3yR+eR/g7wOxX0gWlNQ036VazzSsFDBoBUm7d1OLw/azvZa2ptd X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(478600001)(2906002)(41300700001)(186003)(82310400005)(4326008)(40480700001)(36756003)(8676002)(54906003)(33656002)(86362001)(6486002)(70586007)(53546011)(6506007)(70206006)(26005)(6512007)(316002)(81166007)(2616005)(356005)(82740400003)(40460700003)(8936002)(6862004)(5660300002)(336012)(47076005)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 13:40:33.7919 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2e464938-a073-4083-e16a-08da6342ee05 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT048.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6695 DQoNCj4gT24gMTEgSnVsIDIwMjIsIGF0IDE0OjM4LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBPbiBGcmksIEp1bCAwOCwgMjAyMiBhdCAw MzozOTowMFBNICswMDAwLCBMdWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4+IE9uIDI0IEp1biAyMDIy LCBhdCAxNzowNCwgQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+IHdy b3RlOg0KPiBbLi4uXQ0KPj4+IEZvciAicm9tcy5pbmMiIHRhcmdldCwgdXNlICIkKFNIRUxMKSIg aW5zdGVhZCBvZiBwbGFpbiAic2giLiBBbmQgdXNlDQo+Pj4gZnVsbCBwYXRoIHRvICJta2hleCIg aW5zdGVhZCBvZiBhIHJlbGF0aXZlIG9uZS4gTGFzdGx5LCBhZGQgIi1mIiBmbGFnDQo+Pj4gdG8g Im12IiwgaW4gY2FzZSB0aGUgdGFyZ2V0IGFscmVhZHkgZXhpc3QuDQo+Pj4gDQo+Pj4gU2lnbmVk LW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+Pj4g LS0tDQo+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9NYWtlZmlsZSBi L3Rvb2xzL2Zpcm13YXJlL2h2bWxvYWRlci9NYWtlZmlsZQ0KPj4+IGluZGV4IGI3NTQyMjA4Mzku LmZjMjA5MzIxMTAgMTAwNjQ0DQo+Pj4gLS0tIGEvdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL01h a2VmaWxlDQo+Pj4gKysrIGIvdG9vbHMvZmlybXdhcmUvaHZtbG9hZGVyL01ha2VmaWxlDQo+Pj4g QEAgLTg3LDIxICs4OSwyMSBAQCByb21zLmluYzogJChST01TKQ0KPj4+IA0KPj4+IGlmbmVxICgk KFJPTUJJT1NfUk9NKSwpDQo+Pj4gCWVjaG8gIiNpZmRlZiBST01fSU5DTFVERV9ST01CSU9TIiA+ PiAkQC5uZXcNCj4+PiAtCXNoIC4uLy4uL21pc2MvbWtoZXggcm9tYmlvcyAkKFJPTUJJT1NfUk9N KSA+PiAkQC5uZXcNCj4+PiArCSQoU0hFTEwpICQoWEVOX1JPT1QpL3Rvb2xzL21pc2MvbWtoZXgg cm9tYmlvcyAkKFJPTUJJT1NfUk9NKSA+PiAkQC5uZXcNCj4+PiAJZWNobyAiI2VuZGlmIiA+PiAk QC5uZXcNCj4+PiBlbmRpZg0KPj4+IA0KPj4+IGlmbmVxICgkKFNURFZHQV9ST00pLCkNCj4+PiAJ ZWNobyAiI2lmZGVmIFJPTV9JTkNMVURFX1ZHQUJJT1MiID4+ICRALm5ldw0KPj4+IC0Jc2ggLi4v Li4vbWlzYy9ta2hleCB2Z2FiaW9zX3N0ZHZnYSAkKFNURFZHQV9ST00pID4+ICRALm5ldw0KPj4+ ICsJJChTSEVMTCkgJChYRU5fUk9PVCkvdG9vbHMvbWlzYy9ta2hleCB2Z2FiaW9zX3N0ZHZnYSAk KFNURFZHQV9ST00pID4+ICRALm5ldw0KPj4+IAllY2hvICIjZW5kaWYiID4+ICRALm5ldw0KPj4+ IGVuZGlmDQo+Pj4gaWZuZXEgKCQoQ0lSUlVTVkdBX1JPTSksKQ0KPj4+IAllY2hvICIjaWZkZWYg Uk9NX0lOQ0xVREVfVkdBQklPUyIgPj4gJEAubmV3DQo+Pj4gLQlzaCAuLi8uLi9taXNjL21raGV4 IHZnYWJpb3NfY2lycnVzdmdhICQoQ0lSUlVTVkdBX1JPTSkgPj4gJEAubmV3DQo+Pj4gKwkkKFNI RUxMKSAkKFhFTl9ST09UKS90b29scy9taXNjL21raGV4IHZnYWJpb3NfY2lycnVzdmdhICQoQ0lS UlVTVkdBX1JPTSkgPj4gJEAubmV3DQo+Pj4gCWVjaG8gIiNlbmRpZiIgPj4gJEAubmV3DQo+Pj4g ZW5kaWYNCj4+PiAtCW12ICRALm5ldyAkQA0KPj4+ICsJbXYgLWYgJEAubmV3ICRADQo+PiANCj4+ IEhlcmUsIGluc3RlYWQgb2YgLWYsIGlzIGl0IHNhZmVyIC11PyBXaGF04oCZcyB5b3VyIG9waW5p b24gb24gdGhhdD8gVGhlIHBhdGNoIGxvb2tzIGdvb2QgdG8gbWUuDQo+IA0KPiBtYWtlIHdhbnQg dG8gcmVidWlsZCB0aGUgdGFyZ2V0LCBzbyB0aGVyZSBpcyBubyByZWFzb24gdG8ga2VlcCB0aGUN Cj4gZXhpc3RpbmcgdGFyZ2V0LiBXZSBkbyBuZWVkIHRvIG92ZXJ3cml0ZSB0aGUgZXhpc3Rpbmcg dGFyZ2V0IGlmIGl0DQo+IGV4aXN0Lg0KPiANCj4gVGhhbmtzIGZvciB0aGUgcmV2aWV3cyENCg0K T2sgdGhhbmtzIGZvciB0aGUgY2xhcmlmaWNhdGlvbiwgYXMgSSBzYWlkIHRoZSBjaGFuZ2VzIGxv b2tzIGdvb2QgdG8gbWU6DQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNl bGx1QGFybS5jb20+DQoNCg0KPiANCj4gLS0gDQo+IEFudGhvbnkgUEVSQVJEDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 11 13:41:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 13:41:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365137.595223 (Exim 4.92) (envelope-from ) id 1oAtfE-0006fm-TK; Mon, 11 Jul 2022 13:41:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365137.595223; Mon, 11 Jul 2022 13:41:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtfE-0006ff-Pt; Mon, 11 Jul 2022 13:41:28 +0000 Received: by outflank-mailman (input) for mailman id 365137; Mon, 11 Jul 2022 13:41:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtfD-0006fX-J5 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 13:41:27 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2082.outbound.protection.outlook.com [40.107.21.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 28f98e73-011f-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 15:41:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4066.eurprd04.prod.outlook.com (2603:10a6:208:5b::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 13:41:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 13:41:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28f98e73-011f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YR2FWXhb76ubqwZh17IzS7mS+J+0tGglf1BRUHvscUwpjGoBBGVSEjetPPocWSBTHyEDHAOT+ruNj1JfbpO1ekzGBwjUSK+YSdaE6xy6VSVagjez35ZxLBTJNGRJKjU/ymqD6SfeO1ZgZAZT0jwhC81qqCYvUY3+aH143Ohn/cnl4bmi5wL0L85RtAazS3zj0OFUn5muR6v6euy5ObMWW5cB9gPEpchx8LKfuFvtVSXGP874azc2LvPpM4AgXNPE4cydn0TCV9p9SwVHKVtypDr5EQnVO2iah/PC/V/AlwgH+CBdxw3e/+yHYViGJ2YwvB7U7iOjWI3SdUE6Qg2mQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PT8a6vqWuCNd0plAzJ9mH+Byt7yYLrj7br2ncgocIFg=; b=ZABandyfKfXZc6qqTq2rSMoXoLsuae3aj++TBviP6EiSWGBiPskljm99W+DKBO4xG0FoaAFzazN/4tNB0ayR+mId+kuIBdfCzF4JL5S7xs+7jE7LJIaCb4Xe+UkI93reLvtf/Iav1nM5qDSTGtCSPIvSSVWUz0azbfJ4KExQKzoZypsp6Hjtb2Z5EgG2XbcpIQcbfLDGmWsTmmReRIc5FpfYz9vutC+MRanY0nRJaQiacSwfvi5XF3Y1IW4bQie/bjF2RJvmQIXRxYMURioui4XUlfhe75kUyraq5wy1WcThyx2D1haWStM0Mi/fiDiYNwLctZHLgh+Mdu51076NCQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PT8a6vqWuCNd0plAzJ9mH+Byt7yYLrj7br2ncgocIFg=; b=J5/sw0hMy/rFATgMm4WXFXc4YvrCWurVUCnS6/13hBEEHGuce5lY+bU7eaqSahwI9HdROJ4I0++fIawaJihHygObllQRx/06pycsQEQ4BxAN+ttvAoQe158mrBgjeA2dFDhLmwGFpQYnswX018mPhAJ7qavdkWKNzBNKy2irz27DqLvkHU5uz8CUpjDuNTlrwyyYWEvcnWrzYAJ+Sm76JjUPdkaJRs6INQN7Pjz9Yil2ktMkRiICTUA+fGdvx2XzqwC/7et48gypAJaLD+R8KVm7O1Ouj/IdWkfUW2CWDclGgtD+JFnYcgyxXnyBIkXhfcVKFcutzfcMQM81ZncVtw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 15:41:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Content-Language: en-US To: Luca Fancellu Cc: Xen-devel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Anthony PERARD References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> From: Jan Beulich In-Reply-To: <35DF552D-E8EE-4478-891F-792F67D690D2@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0057.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3e493113-f248-45c0-dd3c-08da63430ba4 X-MS-TrafficTypeDiagnostic: AM0PR04MB4066:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TIfJPAfOeQVf3jVOHPhhIJHvg4YY0AgL6ERC53knXf+zesFMxC75XAuCuGQJBME4DHsxKKSBBvLcooaKPDTLx1OuU3DQc+3bg1BZLBhEJ+C+jRtgJLcW/lK2a7pROmWc3JLi/6b+YDyCIrR0fvy/EdR08S1Es8JZPJoZo/Ql4WT2244Sj04n7kcRYSPxGd+DXlQY9rfbxnlKSedfRFgY2fDwk95Zuh2t1N8ybP2+g5Lr37+gzhkAYAAoQtud4ApDfMe3I5iAxfLoHav2RmB4ajk31RIosEiN8WKVD32mC5VrjpNOLVFh0oPqqgYLeFr5kb3MsDaZnj+hVXdmcO9vvbIj+wqIi7M9DEsJOPf4bNBjtT8fIDrAjyTy+Uw68XEHIIowoBVSYzLMGI2Cvajgkmkz+SmKuR1BthYsLEpdOf8rG9zQhDw/P2TJnzx2gDgMIlC3VxQXuQrw9vuKBihs/zYiwJ/17gPb5vmIjIv0C6qd52e10l+VF6crWjjEazMdk68c+9NR9WowEYgH5cuLzCr4ZfLSPggkNjA6FYt3flEO+bpNMxPZW/qQ58kzY3s01R33ZlvWZUzqfotNqDCibZrq3TRI8Jr23hoi28Pk25yjtGF7bEsD9eQ4+P0y3z+NsdAaUQWDiYajoZ3Z786m/OX1kVqpZahcGLm+nFVf15xJ1X8en0WdYF8re/WHSI7ngAr/WNDS3uzyIGwqwz+p3qKEGePLxE30RFFxdRFqAM+70i0OegF8pUjC/qXPhB02lOQUZXTP2VWqz3TZTyYQcrNYYZe2q93HJkKNVOxNLr7Gdn8FNj1AD5CEy0qpp+ubiOCpY6mkXcVN8OUB+ZauUKEAWixcFV2KWJU1thiBaKg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(136003)(346002)(376002)(38100700002)(6506007)(86362001)(2906002)(31696002)(6512007)(4326008)(6916009)(41300700001)(8676002)(54906003)(36756003)(66946007)(66556008)(31686004)(316002)(66476007)(5660300002)(8936002)(186003)(478600001)(53546011)(2616005)(6486002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?clg4WFZ3d3hiTmx3UWtNZmJRbEV3MGVJT2xPanpWZU5VdngrRUVMVXJ5aGlW?= =?utf-8?B?RVRoVHhkUXNVR3BCSlRRRVRyV0lvVUkzMXg5Ly9RT3RweWUyZS9LZW0vQmxF?= =?utf-8?B?V1NOckVzemlWWGtMUlZUeSs2Tm0yeGFyY1RFa3FRQTV1bW9tUWdoTXo5MXNF?= =?utf-8?B?SGIxU1JjK1A0dy9yU0p6Qi8rRC81bFppdjFNUkhGMVAyQUlJODlpelhVa0pi?= =?utf-8?B?U0ppUElhTmdQMG1DZ2l0L3pmWm12d2NMQSt3R0gzbmgvaUxpSit2MkFYWTU2?= =?utf-8?B?UHA5SmdGWFdIT1lYQ0RhRk5XQmlYMUNMaWl5RXRST2ZuOUJwaURXZHlUN3FO?= =?utf-8?B?UVgxSlpBQXpNY0NVZVZsd0pRS3dCMUVtMVlQaDBqd0hPdFdqQXZtTGxwZVRl?= =?utf-8?B?RG5BNlNpVzhrOUFBdnJqMlVIQ3FpclpWZVNEU1Y3THltWGJaTWI4SWFpZ0Ju?= =?utf-8?B?cW5ETEVQMzM0eDV6RGYrSEhtR2VkZDlncElLSjlZdUtjSDg5WDU4R2g0MVlF?= =?utf-8?B?Q0NqNE9YMjhnVjV0bGNQRXM5ZVRYMUk4UkRoUFFDYUxxUkZhdXlPYWtoRnli?= =?utf-8?B?aTBvV2JrZjV5VjVlYkZ3UEl1b0JyTWtwc3VFTW44bEFCSjBxVURoclpiR2RG?= =?utf-8?B?OUNidForUHdkeDhHSUFEcFRCY29pL2NZQTNJOXByTTVONHBWdElyWC9QSFA4?= =?utf-8?B?bStDMGNUVFR2d1Y2dVB6UnRuUUYzK1NXdERIZ2M2NkhOSnVJWDQ5cnkyZGNR?= =?utf-8?B?VSs4c3RaT0hLRDNvWGZJalJ0QTdhMWZ2dGxYR1h4RVZ2V1hYWkUrUVdieU55?= =?utf-8?B?dG5HVURXSGEvaWExR0kwUVJ6YVlpRTBQQVRZbG92VitNVzd5aUFnMEpMSWJt?= =?utf-8?B?aFFYVWVJT01ZUDVkQllDRDVpWEJPTVNUVk94OVpBWjk2aS9SR0F6MzdpSFZ6?= =?utf-8?B?T2RrengxbGI0Wk9DS1ZiT0FQbVhHTFpEME9OdDZBTTZhUVFLUEpzeUozb0lH?= =?utf-8?B?eCtZd0EvOHA0L3h3ZXNleEtlbkRCQlhuZlRMRXFvNm5KSTFGR2d0SlJYeGNF?= =?utf-8?B?YVBwUXd2aEFuUjJyNEtCeElDZisyTGdab01JV3R2YmZITVYvRG84YnZYT01r?= =?utf-8?B?ellGQW90ZDJDY0ZEZGt3dHRVWTJLcVRObDFIdGh1UDV1MXNUcDV1ZGQzbitB?= =?utf-8?B?UDlwUmxJT3JDck5LRE1ROXlqdys0WjRGTXdwSjZSV2Z4LzIvUkUxMHNnbkhZ?= =?utf-8?B?Mnp0YmFjSXZyWG01TGQ2UHVtV1RSYTZoMXR0V0ZlSWx4RkZ0SERRdkdFUW9p?= =?utf-8?B?dTEwZy9HcXltRHRZWTFWWFJFUTQ3R0V0ck8rcXp6NndTZXdDeWRQZmZWbmJi?= =?utf-8?B?ZXVEV2YvZWtIaFRVT2dEZ21kVzluTTd4a2E3enFhRlVpSnNVbjU1aHdRUHk1?= =?utf-8?B?YWxqZU5jVjdXaEdaVHBsNEdGSGNNRWxVeDBIdkFSQ014WkFSeUVTYWNESlJE?= =?utf-8?B?VGZzOGRrZ2Q4UFdqc2k3a1VBZThPa0VQSUo1dUw5WXdPTFBOejhNR2hzTXNP?= =?utf-8?B?eEdLdnhsRVBkblFhSkN5VFl5b1RnMmQrZEI5VldBZ2c1eVBDMkhPRksxWktr?= =?utf-8?B?VFVhY2lrTDRCa0VHM2FzNUYyOWVnVVpVdFhNenRsUlBsc0dpVzF6MzhwWDBy?= =?utf-8?B?dDdaM2xsQ3VLcUt5UTZtM2JTTS9ieEgvVklWMnh1aWEwWnlYRHc0NXpKRXRw?= =?utf-8?B?WVZtOXJSMWg0b2Q1ODF3UVpHUk1UNWVuOGVITTBlWVcrckxKTGttdHlQWlBs?= =?utf-8?B?Rm5mc1ZMWDh5d0ZZM2VMMkdOMG5VcmhZak1LL2swaGVRZEVqdS8vdVM0eHZp?= =?utf-8?B?SkxjTkZtNmFGVDBFVVA1NDRIYklIRTFPaW5TV240cCtPbEczMHNPRktRQWNh?= =?utf-8?B?NzFNaEc0SS9qMEhHK2QxbjU0ZDJ5SkNSRVFFZFZxWXhDTnZXVXM3WHhFZTEr?= =?utf-8?B?TC9rYitlWVBHUGlyWjhHY0NoZ0swL01LdWl6WGYrUXNlaUEyQXhzNXoxalY2?= =?utf-8?B?SEczdjMwTDBzVU1OUjlKZjB2dXVCZHhxcm94NUpNWmVpQnBtRmFqREZUaWtl?= =?utf-8?Q?ehbMnW88OfTi7ANg3UPExyRld?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e493113-f248-45c0-dd3c-08da63430ba4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 13:41:23.7065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VnqVCTwEkj/uYkNY1WPOp4vGD04VF0wRZwC+KMOdgAYR3k0V/phML+6V1LbqEEp8uQeYoFMV35kYKWjRuZ3MNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4066 On 08.07.2022 17:39, Luca Fancellu wrote: >> On 24 Jun 2022, at 17:04, Anthony PERARD wrote: >> @@ -87,21 +89,21 @@ roms.inc: $(ROMS) >> >> ifneq ($(ROMBIOS_ROM),) >> echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new >> - sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new >> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new >> echo "#endif" >> $@.new >> endif >> >> ifneq ($(STDVGA_ROM),) >> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new >> - sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new >> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new >> echo "#endif" >> $@.new >> endif >> ifneq ($(CIRRUSVGA_ROM),) >> echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new >> - sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new >> + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new >> echo "#endif" >> $@.new >> endif >> - mv $@.new $@ >> + mv -f $@.new $@ > > Here, instead of -f, is it safer -u? What’s your opinion on that? The patch looks good to me. Would -u be an option to use in the first place? It's not a standard option to mv, afaict. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 13:53:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 13:53:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365147.595234 (Exim 4.92) (envelope-from ) id 1oAtqK-0008O1-23; Mon, 11 Jul 2022 13:52:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365147.595234; Mon, 11 Jul 2022 13:52:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtqJ-0008Nu-Ul; Mon, 11 Jul 2022 13:52:55 +0000 Received: by outflank-mailman (input) for mailman id 365147; Mon, 11 Jul 2022 13:52:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAtqJ-0008No-38 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 13:52:55 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2070.outbound.protection.outlook.com [40.107.21.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c291d26e-0120-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 15:52:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB5960.eurprd04.prod.outlook.com (2603:10a6:20b:93::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 13:52:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 13:52:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c291d26e-0120-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b2vbf51GgSwR1vFbFNYUNRL4CDUxclBmV6Bdd9Czt6CNTV3XXqj/A3kQ5KjTZW4mYpGIiag3UZD3dIW682On/712CkqhT9z/rWinNtO/Ee0gop4u9Lb9Q9SVXnVsWCghkwpyQGwNdc5WYEqyGnHZIgKNa/O7rEmzh4rWubn8p3L6SXA1W7ehcqE5Z6haWbL+T5BXGYEbvK5yuf+iaQVYuMkDRsB6eTL0gKseeC3YmhQEHiEP9UGb0ck1MiUVft3oRR2B1DqMX+E9oTBDOriuBV7AC9F4knuthPvfzuzM+UOj6vCPUXjvNsUs1Jlxt8br38cgs7QuGymZwdrQuMJRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y6EKOgwVToWdE6HACoeHmgjyhRvxRppQiVPhunog6wE=; b=Nra79n2A//zkBX9/1mby7+KmO3Fkn1ftDLNmN6J7VII8EldyDvr4laJ5fgy6Wz9yImBrIuenKIDQXTigLuJG4qp1F2OoIpppe2uAL1DakZrOv77gwDxTkpPyRu75JFePtbjsXQ0z+KrphmFKN8tks3bNVKAXz//gjDhji+RLvXRU08NZnKrVaZvOPuS8odiKLjIu+2vBM7J74O+byXv40Pns/Zr7+gASVW6mZfodN3MD4WKn+ZpZTGe1CxOMafXmbyB0Sg13+pdddJc/4SzXMzL0qS8oxJixJH2rJAnp/8aoXfyRkAtX0sQoeqhqPZJIf4bM7J5kbiXCZ7x/shXV+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y6EKOgwVToWdE6HACoeHmgjyhRvxRppQiVPhunog6wE=; b=coYJtgvWX0GUy6Q++ZINTj6iCPXbs/29pNvaCEv7eI2/DmtbTvmarMb9UkOy3j9y9RlenEyROz+AWX17BNcWpmB1zEHyd3po7qL/pcvmI6EeDSR/c6trYu+AH33xMVzv2FRuO5ppBVRQAplfmSjZ1qviz9cm7BH9EYlf0u5L7OTpfoSCVOPESw1hCUWGR+RnAUOWWi7zuN5XukYJ7Jy5Gq3v+f6+HMaHNuIiPj8UGdwtw1O1iOB3w1161/YSMQaWl+j+Kti18aldyA1UaLTBGVjggrCSVN9u6dj/6RC4EYy07oFUCAih+HzuuVWfVR9mHPexE5Kx9yOb0NZRvlZ5aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76605880-bf6c-afd0-8fbb-a15bfccc1eed@suse.com> Date: Mon, 11 Jul 2022 15:52:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20220624160422.53457-5-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d3144538-88cd-4afe-623d-08da6344a5d6 X-MS-TrafficTypeDiagnostic: AM6PR04MB5960:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: d6vsPROurpHnuN9kG3lgSycBrBLVOQh14YLSoDkC3njHP5ap3giRdGqJ8wWXKlhwVjKZ2AU9/QqbVRTzbCYjOItfAeJaFP5PZRfAwTZIQeOeWpBAs7Y2hyT8PJ6LQL8jh72vVlBc/4U1xakj1J3rX/8Yq7LvCvphibz4POhWZlHewH7vsImFwiivGuRSl/IelR1llcTMxrw5qpFI+WMS5RU8SjSDEGnIUT/qWfLmEOCykkMlxynjeuKBsYJ4LCCQSxuZnZV3ONtcbBq3CekD8IMlP2Pbr5p5FIOQz65rT9Sas3w6fhD+VDR0ojjNQJg8aXo1SnEySY39ZWt4o8xEPfOYW6QvY8OrfTlWKmm3x1uYuX/AcpUE0eu7i/pzb0JZ7l/7qOgB57mLQzDrfNd1iUTyS2XSYsan/QpgrAWXuD1n3mjXib+1PehsTPkLj7eGYaAuuICp+U//hOZTPSKG2u7OJvXZmB9D7wtJgfvMxe0hn+M42zKA9LBNMuuxQOb3gdt9B/j50RMEHlfDSG2wmO2um8PHgCe3g9bDLjVEtQux8nbH/qUk41NkEQD94S29HvcoAUX4wHRTMpeEEZ8zFVaEszzEE26PBnK/L3fXwvAGuCj3v+gA7Np/dc8N9Nkkqw+/FScTEXYsrbJ9AOlFK1vD4ZmeKJQSDA7DyyDiUxqW3kMI9Rgb4KWOZKyaGrV13A1qgKUqggR281XZdQbmrbcO0Sof0EeGjh5O5G0ft3JuV2uG5PPHRgDqEj/prlJQxFk/94Etciw4IIQRptKvnFGX/Qeb/AHCcDPAKCNxKlEBA3ohbTeNDI+vCZzShFHi7lc5Cyo0BSBD3wEiLgir7jRHgSduVlklmqRfHmPmR0E= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(396003)(376002)(136003)(38100700002)(31696002)(86362001)(8936002)(478600001)(316002)(2906002)(5660300002)(41300700001)(66476007)(6916009)(54906003)(66946007)(66556008)(6486002)(186003)(8676002)(6512007)(2616005)(26005)(53546011)(36756003)(31686004)(83380400001)(4326008)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWZEUTNreXoyU1Jmbytoa216YnVDRzhoSUhRMmtQb1Q1a3owNDBRdVo0elUx?= =?utf-8?B?RGZQUTRsZEwwQ2JlM2U3NlFVcFNORnN2a0FmWm9sd2Y2TGkwVzNHR2lCWE5X?= =?utf-8?B?V1Jyd0wvRGZMbHBJZ2RkTDZTMXlBcjlSaGZqYW81dzg4cUZhamt3aWJDZTd6?= =?utf-8?B?dHhXYytIUVlPOFBEUlFFcXU5U3RJcFYvRUN1RnpyNUM3ci9yZ3JWZzZ0SmVy?= =?utf-8?B?RHFUdmMzenNqTFJkQXJJNE9IRXFRZGVXdFBxbi9YaWpuUmg0VHl5STBMY2F3?= =?utf-8?B?N09YR3VoQkFBMkFJVjBNTDRCY0dLa0VRTXJLb0Q3NUJjN3A0VVN0a3FzM0dS?= =?utf-8?B?dGtLakhoZ1pOSVhUdFQvSGRkbHVtNjk1M2JTV3JCUCt1bDByNTIvbEk4cVZH?= =?utf-8?B?Q2hlUExyV0p5YjVUYXZDbXhCUmdiUGgzUFQ5TXlwTnhlTXN4dGdKT2V5aDJl?= =?utf-8?B?Z0VHYUJuOTd3bTBNTi9wKzA4ZXRwUWVtTWhTQ3g0YXlEcmpXc2xJYWljS0or?= =?utf-8?B?a09UN1ozbzVEUUkzbkF6T3diQjhyQlppcjJ2d2djenllUXMrajJIMURpQnNi?= =?utf-8?B?eCtpbTcwWFhzVkRtbXQ4RXRsMXJlRFhROElha3NXdFIzeGNQbkRhTUpVcVFr?= =?utf-8?B?eWN6dkFEdGZNdkJtbDJ2aWhQOGt6bEJOaFRwWHV4cnJ5SU9tNUlwOW5Wd24z?= =?utf-8?B?YXJJaWQxdFRhaWtTQUtGMysraGRmY211UE1sL2xtOWM2bWx5bXZiWHR0VStt?= =?utf-8?B?ekhjNE5lMEhsbTRWUkNsd1ZDRkxUZ0VNWTBEblJpZ1Ivc3JVZ01lQTRsYjMz?= =?utf-8?B?Vy9kUmNnVUdHemVjQlFwUG9uNy9nSGE2Uk5MdVNuU1NNT2lmTzhSMGtzSDMw?= =?utf-8?B?YlNqRHo0SkdyeER2UXRZZDhQd1lUQThnbms1QXNGY3JzVVJ0aC9VWWMyNWl2?= =?utf-8?B?YXBsNmNrZ2JnK2NLVFE0K3R3QWZmUG9XM3ozY0JPTHkwRUtpZlZHMjhKd1lq?= =?utf-8?B?VElzR1NHc3JRV0o2dVd5cm1WVGUxZE5OUUZSMXNrQ1AwQ3ZTN011Z3Y2cmtS?= =?utf-8?B?b1lEOURhM3NHeWFvb2NzRGFYUUtnZmliNWxMMHIwRVdFbEVZSnhzcG4vQXBR?= =?utf-8?B?RnV2bnhuNU5BOHBXdG1LeERtWlROVEZoMjNqY08vdFdjNEQyWE1ya0dTZFVS?= =?utf-8?B?TFVQaTlHMVJvTHpUWjBCb2xTUmY3TEFxOFpmd1JNKzNMcG0zUzBETGo5eFly?= =?utf-8?B?ZHJkZGVGeVdoSVhtUUtVblQzQ2dnMzVFbTVKOHZXWHd0aGxxODhmNTUrMHNy?= =?utf-8?B?NFRVU3BrdEZyeEgxSGJVT1E1WGRKTUhYR3VZalkvcVVIVzl5SEVlbkNySFN1?= =?utf-8?B?d0FVcGRWMkR1eWFvWlZyMC9XMjF6VE5QLzMzS3VSVTRLUkE0bWp0VXU2T0p5?= =?utf-8?B?ZW5CZkY4SUVGV0Vxb0puaUtZV1RHUVZrTUJmRThqNlJsRjByVHhlY1c2eldI?= =?utf-8?B?UzA1aW9uQ1JYWnFjZmppMGlWY3k1Z0Z6NmpyWVZybUg5VTJFQmcwMlNMSWh0?= =?utf-8?B?RUw2SmNIWnRONkxGUk1iMjZiYnR5TGdHVGFyUVNPdzJzOEdpdHhnYlppWExl?= =?utf-8?B?K1YvSW5YY1NXZE5XUzBIVHdNZUNBSHI1djRaZU9yY0dkK2tLdnpXcmZ0WUc1?= =?utf-8?B?dGFKZGVkdGpKSllPV0ZJWU9BcHFobnUxR0dQTmJlaDg3eXZQazJMMThyQi9H?= =?utf-8?B?ZFB5OWVnZGNRMnpaR0RlU094QkVOdmdqUG94akgvTjllUEZBYTZZc1d6aXZm?= =?utf-8?B?c3Z6dEQzcWtocFpnRmlvUFY2endUMy9DQi9OcVJ1elRuREdqM0wxU3FSWElw?= =?utf-8?B?TVVpWVdjTnpyZE1XWlJxUWk4aWVsaGJHWlRCSWZOK2hDdUNzNUU3VFYrNVdu?= =?utf-8?B?SFFpck1wMWVsaVV5d1ZCTUFtZm0vSWNyZmxKNFFBeDhLYVcwZ0hYTnZ4ZWha?= =?utf-8?B?eWJVZ0svTWdGNEdUSzdDeGxWMVUxK2Z1TmJIaFRRQTVZYmNxL2ZNYXNsSnZl?= =?utf-8?B?am9sY0YwKzd2a1BBelN2ZFlzUmIzU0MvMXJ1cFAvaWhtY2N6cUdoaEQ2Y3h5?= =?utf-8?Q?wtzSkgYAjYF9ytgAqpowhiSac?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d3144538-88cd-4afe-623d-08da6344a5d6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 13:52:52.0219 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uNc9CEUcQb4X7H7NV6V07zuHoWEJyxDZTD1YCLq+M7jsuOiMRmIuSm5OHvmAo0/JhpREZBXdr13bL7d+j/GMAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5960 On 24.06.2022 18:04, Anthony PERARD wrote: > Setup proper dependencies with libacpi so we don't need to run "make > hvmloader" in the "all" target. ("build.o" new prerequisite isn't > exactly proper but a side effect of building the $(DSDT_FILES) is to > generate the "ssdt_*.h" needed by "build.o".) Maybe leave a brief comment there? > Make use if "-iquote" instead of a plain "-I". > > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use > full path to "mkhex" instead of a relative one. Lastly, add "-f" flag > to "mv", in case the target already exist. Hmm - according to my understanding -f isn't needed just because the file may already exist. It would be needed if a pre-existing file isn't writable. (I don't mind the addition of the flag, but I think what you say can end up misleading.) Jan > Signed-off-by: Anthony PERARD > --- > tools/firmware/hvmloader/Makefile | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-) > > diff --git a/tools/firmware/hvmloader/Makefile b/tools/firmware/hvmloader/Makefile > index b754220839..fc20932110 100644 > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefile > @@ -60,8 +60,7 @@ ROMS += $(ROMBIOS_ROM) $(STDVGA_ROM) $(CIRRUSVGA_ROM) > endif > > .PHONY: all > -all: acpi > - $(MAKE) hvmloader > +all: hvmloader > > .PHONY: acpi > acpi: > @@ -73,12 +72,15 @@ smbios.o: CFLAGS += -D__SMBIOS_DATE__="\"$(SMBIOS_REL_DATE)\"" > ACPI_PATH = ../../libacpi > DSDT_FILES = dsdt_anycpu.c dsdt_15cpu.c dsdt_anycpu_qemu_xen.c > ACPI_OBJS = $(patsubst %.c,%.o,$(DSDT_FILES)) build.o static_tables.o > -$(ACPI_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\" > +$(ACPI_OBJS): CFLAGS += -iquote . -DLIBACPI_STDUTILS=\"$(CURDIR)/util.h\" > CFLAGS += -I$(ACPI_PATH) > vpath build.c $(ACPI_PATH) > vpath static_tables.c $(ACPI_PATH) > OBJS += $(ACPI_OBJS) > > +$(DSDT_FILES): acpi > +build.o: $(DSDT_FILES) > + > hvmloader: $(OBJS) hvmloader.lds > $(LD) $(LDFLAGS_DIRECT) -N -T hvmloader.lds -o $@ $(OBJS) > > @@ -87,21 +89,21 @@ roms.inc: $(ROMS) > > ifneq ($(ROMBIOS_ROM),) > echo "#ifdef ROM_INCLUDE_ROMBIOS" >> $@.new > - sh ../../misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex rombios $(ROMBIOS_ROM) >> $@.new > echo "#endif" >> $@.new > endif > > ifneq ($(STDVGA_ROM),) > echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new > - sh ../../misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_stdvga $(STDVGA_ROM) >> $@.new > echo "#endif" >> $@.new > endif > ifneq ($(CIRRUSVGA_ROM),) > echo "#ifdef ROM_INCLUDE_VGABIOS" >> $@.new > - sh ../../misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new > + $(SHELL) $(XEN_ROOT)/tools/misc/mkhex vgabios_cirrusvga $(CIRRUSVGA_ROM) >> $@.new > echo "#endif" >> $@.new > endif > - mv $@.new $@ > + mv -f $@.new $@ > > .PHONY: clean > clean: From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:09:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:09:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365153.595245 (Exim 4.92) (envelope-from ) id 1oAu5r-0001o3-E2; Mon, 11 Jul 2022 14:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365153.595245; Mon, 11 Jul 2022 14:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAu5r-0001nw-9X; Mon, 11 Jul 2022 14:08:59 +0000 Received: by outflank-mailman (input) for mailman id 365153; Mon, 11 Jul 2022 14:08:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAu5p-0001nq-VP for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 14:08:57 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00078.outbound.protection.outlook.com [40.107.0.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0097d3fa-0123-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 16:08:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8042.eurprd04.prod.outlook.com (2603:10a6:10:1e3::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 11 Jul 2022 14:08:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 14:08:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0097d3fa-0123-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T52cG7fu2tQeZdAXimk5K275jLyaF6WcXgm4ImqUKS9OoiUYsk1qNm4AEs+5EKW8aDk6lUveXvBcFwyOW7IPRaKTc05GFCtcWecrcrkbM0WzpEe0uNUAx8gub9W6xFy+yM0fnx3f0OtN5YAv3dsjyCq6qCMfgajukjF/rPcPC37v65ppE9wcUwlQXRMzGBaUIFu/RYvRE3fPVNfrhQWgfrxF4ZWyuxxqCj7FDMXyYIuhxOwQ8aMPEEEzu6iJ5HIjUom8KiikKTQQjZAuXpq7BNBBaVJivV6Tsrsk3qvrcuWTr6rbLOUv+mk6fomiRoYX4sGyKIC5U29iiOTKC/rQcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sj9oFkingfdtvKPcRBxSTLyW6PnodPV3R8KwLJ0PWeA=; b=CUHWLTxAYaXVyLxu3yPAep03LiRaPT+i8nEhxlZOEio/gFN9rf2i7/YDI4W8GWetY8r9QmZWR9bDtFqCnLo8nQvsnRgSUraMGczUA2VGlsBj5BQuzPA/Sh8IXDe4BjWwF/GNxdaWHya7ITPdrW/ZqTbzBa243kNI6EmOJzKcJ9jcf7Td3Z5BTx8sfM7IhHGrrHXZeLRUdV0zjMiTQqYECzMzRWlVIUvSf2NQYMgyvPhvnm8iXuRHYtzLDP0GAMsWeU/yrlDcLFfwikYcRkfnXZVSDuTZwfNtyTswvqxZuwxzJ/ZknIFXp1PLSwy8SEDZS9xdSPp4cuihGfRA0DsTKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sj9oFkingfdtvKPcRBxSTLyW6PnodPV3R8KwLJ0PWeA=; b=MYOGaJ8E4xBl1GrzCioD8JKGLtGneOCEuVx8UEC0o6Y0NhDnoSw49sAxaj6Agol5gWDOJGOSpIKwGUD/hFKmpiJxA8QWOczsKb7VOKxh8Q4bGhDZSS4eReA0umcHKF0Y//aELjxMjT4e53sF0U5PtaakwoEmyJJZp6OkNwdgBmMvkfPQqxmsuqqUuPdj2jXPKYy6/vS4HtRLIAvT0j9xfb0vbuVhVOALXleenQQrZBLO4YJsKY54Gk+x+AoIHp+iRvZfuX1HzWa4CNk2lQTiFnBhCzyRsxKr+tzw7ISbMlmHPu3U/OyzAlFj3v5KLoq6Zyb5FkAGX1ElUFHt+42nWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 16:08:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH v3 06/25] tools/fuzz/x86_instruction_emulator: rework makefile Content-Language: en-US To: Anthony PERARD Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-7-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20220624160422.53457-7-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0038.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a5f5ed12-c9b0-4c7f-23dc-08da6346e3cb X-MS-TrafficTypeDiagnostic: DBBPR04MB8042:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PrHKhPfDGyixuuqvbGlnF3COynMzrgVmkTc5qdjquLdjFiVZRu63wF9czYk66nQTq1382oPXMPubQgj7VvLkmlqARmAPqoBYWYwO8P7Pat1M+m2YxmYycE//BonNOgZcMjYnhpx9gENb5PcVKyu/pvwkQWPBYgclP6NHBV4iA/RQqBLZb29/9N24tPlzSsVVhEyFFWPYbnpUr+mTwpKgu+1dTG2ejmjxg07jPA48/qkkw02HFkkTA4MdlVoCGzQkQEFreuqdSLakvEhdIi34JB9Ev4KwK4/uIhHX8RgUye5alzBJB3a9w4YW80HAcrqOHxz9dPgYwRGkLgMkuGqkV+Mahd/SqWEvTlTvLa6JZQA3TG6jKGKfFmiwnmcDUGjbFmcUAv0Lj7PLSj6u7/0R5EOJITZPz/pihV8Xw2Wx6eODTvnwrScpgC67VZvbmrrUAgSo3GdJLoFJDP1mdIFAbh9TQnJ0S3DRrR4njdMmQFWTfWmid5tvo7x7YvQfvyVfi6X/Gi0x1o+aN3eYdeTNLApHyh0e8g5YSZCDN9J3PxZNLH+0nhJK8FqImn4Y14s77K3YjotuQktMX0MhcVAcyiFJXZVZhNYmLLJGpLSUWoNNB01Lwu/9ddvvS1ObjS9jSoZnjsG/FzOq+v34JJt1Ny5wRdyUMF1Y3kwlcT5pd/g5PWIzeu6Ivxd5y722/633uq9+KJn6pX+T/kHs2PGPv/5V4PpnTvHP2Bz2tPj5+gKJ9Ypj61MHfvX9Xps/kyEoNgWMdtbjLQe12OPDImApJPSvi7dMSPIRko1L0YitdjlgVnIrg1AreOc6sFJEEn15TsW85zv9O99YYIkCN+hFAhzQS/46BcJJRepm1MODY4U= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(396003)(136003)(366004)(2906002)(5660300002)(6506007)(53546011)(8936002)(6512007)(83380400001)(31686004)(478600001)(6486002)(4326008)(66946007)(66556008)(186003)(8676002)(6916009)(316002)(2616005)(66476007)(41300700001)(31696002)(36756003)(54906003)(26005)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZUpSZG5nRERGVnE1VTJ5cHlKckJTcllnNXJQWENjelJqZGw4YlBBaVFvZmlJ?= =?utf-8?B?K0hvTFlPL1RlMStpS1AwbGx5T3FOQWpGWElWMHh4a0dkQW9xWlBadVhOKzd1?= =?utf-8?B?Yk4wMVdtTm0yQ1ByekFVNjNyTXJUTVpEaHlzUFJaZHkxU0h4UDNaL2FXWGtQ?= =?utf-8?B?TWVwaUlkdGtpaFNtNWlyQ0kzVFllOWV0K3libS82bEdrckRKcFlFSHJSdXE4?= =?utf-8?B?eHIyd0lIeGZCd3RjbXlNZ1JrRHhoeXg1b1dHN1BpYU5zem90MHR6bVZpVTVO?= =?utf-8?B?VHZjcHF6T1RpTTZoTlF3VGtyckZnWVROOGNaMmY0RHlBSHJxRERHaFBRZ1NL?= =?utf-8?B?UTR4YXQybzNCVzgxcnlkM24xMTZGU1dMYnRXOE0vQXZpZVdydHVIZmZpdXRP?= =?utf-8?B?cXhZRUVnWFM4cXZ5cHNJV0dMZGE0cHFNdUxsNWNyTEJsc2VEZUw2YzlGcysy?= =?utf-8?B?VTFJbTdPbFptNTJiaXpMMXBIYTc3ZUpua2taVElGVTFLUTBHU0dWR1Ftb0kv?= =?utf-8?B?dUV3RGFLWHd2RXFQSlBHdUdjYUV3aXRiT25zSGtqYnNmOWhXVUI2eDZsbmNG?= =?utf-8?B?bDVJb1FVVUJSc3dmcDQxbVZiaGNMZEFRREYvMUpRRzkwb3BKbkI4VStrVFgz?= =?utf-8?B?Y1VmTStGZ2poRERyM1p2b0liRFlqKzdnQWVFOFFZSGxKNndneGgxNStpZXkw?= =?utf-8?B?NVFIbzllcDVYVGdoOHQyN3IwMlFtL2FBdFJEWm95dUttaEJIWjNxQkZ2Sy91?= =?utf-8?B?VUJEajZOblRYUS8wTFVvVk5vMVQwb09CeUptUGIrUVdRMnplYlhCbXdYTmQr?= =?utf-8?B?YlB0MVpEUFpWNWpFZEtSK0N6cWQvWjJkTDF5bmJFanR2Rmc4OGZrUlNwN0R0?= =?utf-8?B?OU5seXlGbC9EMFAwY2xWMnRQa3FqYlZCRi92MFYyM0xYSlh6RHZUaTVNN3lD?= =?utf-8?B?S21RNkdYVGEvaFVZWFZybWprNHpJZjdvTFRJR1AwOVNtWHBRajNaQlF1Qlpz?= =?utf-8?B?bTUyNHdyVHM1ZStJOWprZldqbmhpb2hVZWFncnR0cU9pd0Q2cXBUaVFBYjRz?= =?utf-8?B?R25JdkNrR0d4eURJQkFZZE03dWNPekFOKzZZVFp5QUxCM09oZFIxWUl5VkFW?= =?utf-8?B?WHA5VitPTk44aVFGSkVpcFE1TjYxczJhNExnMGlCWWpWNXBZYitCTHFxaDN1?= =?utf-8?B?WTN4RStKTUJCV1ROeFpvM3I2U0FjK3dxWHVZamxxSG53WTFIaGFCQVRkclZi?= =?utf-8?B?MSsraGhORHFQMGQyWGtvd0YzQW0yZW5HejdCbytjckpKNWRNU3lsTUhLL2po?= =?utf-8?B?RW9sQlhNTmtmdzI3YmhHSkh4OHFtY3lmVzduNTRUcG1obVBMZnAwK25zZ1Rw?= =?utf-8?B?YTFMK2ZpVGJqY3hlMk50NEYzcDNoOVJLeURweVhCcnVkMjdnYjg3TUEzWkR1?= =?utf-8?B?OXRmZ3VKNUJ5L3VFUFN5Zm5WMnFuRzRrZDNXU1p0RE54OTVqNlluQmg5VTRn?= =?utf-8?B?MlgzRm9ROFNheU9sV1RxazFtS1BoVEV5NmgrRnpMSVhRUEZCUFF3RW1seU8z?= =?utf-8?B?eGFpb0FqR1Z2N0tudXJHa0lqalhhemlHcUdoWlEyL2JKamxpV3RKVVAraUhE?= =?utf-8?B?eWJPUzRVRVBpN0gyL2ZzRlh3VzcxVWZlc1Rvak9rb2xiNnVJQ3ZUVksvL1ZC?= =?utf-8?B?ZDFwSVZJYTQ5L2RaY290YXMyMXNWd2JSZDZ4OEdCdWZxdmQybG5PR0R3Z2Mr?= =?utf-8?B?N3JJdVQ4Q212OUUrelVGd3Z1SHVtYzlDVWNOOWkwald5Vkw4YTVsL25Da0tO?= =?utf-8?B?bldTaFkwMlFnRmt4WGhMaVF2RWE3UGxIcGtXRUkzUmk3TVdiTExmZXhVT1hr?= =?utf-8?B?dTl3VFJEb1ZpK0VTZ0UyRHUvL1gxS0owYmM1N2xZc0xDVnppd2dwT1FRSkp4?= =?utf-8?B?c2U1bEhoZkgrWmZqTGQ1NUlPK1BoVzBST0NPYlNMTzk4MUV0YkNjM2lsNGVS?= =?utf-8?B?M0Zla0lTZWV2dlJkbUdpWVFSRU45dUwzT2NqMlpzVHJLVmRZK2pGUGxEMTZW?= =?utf-8?B?ZVFWTFJDNVVPWDlEc2lFYnV5RUR4VldIZGMycng2RGJPV3hyWWtYSjNRSE5q?= =?utf-8?Q?iCW3xOBguM955IaMtgQDynvbO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a5f5ed12-c9b0-4c7f-23dc-08da6346e3cb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 14:08:54.8354 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 18JWPt9a4JXZExYRp/eCkU/dRQwOfqwqIWxz74gqaGXVWJHONZYufnbPvj9PYH8DkojzECWKHuBj94me/d0/ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8042 On 24.06.2022 18:04, Anthony PERARD wrote: > --- a/tools/fuzz/x86_instruction_emulator/Makefile > +++ b/tools/fuzz/x86_instruction_emulator/Makefile > @@ -8,33 +8,27 @@ else > x86-insn-fuzz-all: > endif > > -# Add libx86 to the build > -vpath %.c $(XEN_ROOT)/xen/lib/x86 > +cpuid.c: %: $(XEN_ROOT)/xen/lib/x86/% FORCE > + ln -nsf $< $@ I guess the idea with the original construct was to allow using further source files from libx86 with as little code churn as possible. Your change now requires two more lines to be touched. As long as we avoid name collisions in the various directories (wrapper.c and a few more files come from yet somewhere else), couldn't this rule simply be %.c: $(XEN_ROOT)/xen/lib/x86/%.c FORCE ln -nsf $< $@ ? > -x86_emulate: > - [ -L $@ ] || ln -sf $(XEN_ROOT)/xen/arch/x86/$@ > +x86_emulate: FORCE > + ln -nsf $(XEN_ROOT)/xen/arch/x86/$@ > > x86_emulate/%: x86_emulate ; > > -x86-emulate.c x86-emulate.h wrappers.c: %: > - [ -L $* ] || ln -sf $(XEN_ROOT)/tools/tests/x86_emulator/$* > +x86-emulate.c x86-emulate.h wrappers.c: %: $(XEN_ROOT)/tools/tests/x86_emulator/% FORCE > + ln -nsf $< $@ And similarly %.c: $(XEN_ROOT)/tools/tests/x86_emulator/%.c FORCE ln -nsf $< $@ %.h: $(XEN_ROOT)/tools/tests/x86_emulator/%.h FORCE ln -nsf $< $@ here? (I'm hesitant to suggest plain %, i.e. without the filename suffixes, as that would likely be at least confusing for Makefile.) > @@ -67,3 +61,5 @@ afl: afl-harness > > .PHONY: afl-cov > afl-cov: afl-harness-cov > + > +-include $(DEPS_INCLUDE) I would expect doing so was avoided for some reason. Albeit it may well be that too much cloning of tests/x86_emulator was done here, and it's all fine this way. Can you confirm things to work when building locally in just this subdir, e.g. via make -sC .../tools/fuzz/x86_instruction_emulator CC=/build/afl/2.52b-base/afl-gcc ? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365158.595256 (Exim 4.92) (envelope-from ) id 1oAuEw-0003Mn-7J; Mon, 11 Jul 2022 14:18:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365158.595256; Mon, 11 Jul 2022 14:18:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEw-0003Mg-4g; Mon, 11 Jul 2022 14:18:22 +0000 Received: by outflank-mailman (input) for mailman id 365158; Mon, 11 Jul 2022 14:18:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEv-0003MW-0O; Mon, 11 Jul 2022 14:18:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEu-0000xA-HG; Mon, 11 Jul 2022 14:18:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEu-0006pP-60; Mon, 11 Jul 2022 14:18:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAuEu-0008OL-5Z; Mon, 11 Jul 2022 14:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=gXdlBOciUy6WVGndcLcG5IYkUVt9jytuoMAki4Mn480=; b=4gNPEMHwnj6DyVggwH/CjfwS8p ybDuVuNw1tdk6cDngzZA38bfK71/J5xDulQSc3Bd6MJ2lOIGATX6BY79im/BPFSx1cedswJ2hovsP /coy6rLLyqEqX4Zh8CUm5CwRIBRVn1zhSFe9C4q55xe6CkGQTvI4pGWrFZPEJfJqiHkA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171582: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2ce11ce249a3981bac50914c6a90f681ad7a4222 X-Osstest-Versions-That: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 From: osstest service owner Date: Mon, 11 Jul 2022 14:18:20 +0000 flight 171582 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171582/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 2ce11ce249a3981bac50914c6a90f681ad7a4222 baseline version: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 Last test of basis 171557 2022-07-08 08:03:14 Z 3 days Testing same since 171582 2022-07-11 11:01:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Christian Lindig Dario Faggioli Jan Beulich Jane Malalane Juergen Gross Julien Grall Michal Orzel Téo Couprie Diaz jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 980bfb1ac9..2ce11ce249 2ce11ce249a3981bac50914c6a90f681ad7a4222 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:18:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:18:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365161.595266 (Exim 4.92) (envelope-from ) id 1oAuEy-0003cv-FQ; Mon, 11 Jul 2022 14:18:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365161.595266; Mon, 11 Jul 2022 14:18:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEy-0003co-CX; Mon, 11 Jul 2022 14:18:24 +0000 Received: by outflank-mailman (input) for mailman id 365161; Mon, 11 Jul 2022 14:18:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuEv-0003MV-My for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 14:18:22 +0000 Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4ed2f871-0124-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 16:18:19 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Mon, 11 Jul 2022 14:18:16 +0000 Received: by hermes--production-ne1-7864dcfd54-8q7fk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 393f9d76813cf2fb95aa8646fdc67e8e; Mon, 11 Jul 2022 14:18:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4ed2f871-0124-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657549096; bh=R/XMnj1qIU9tgCHkr7IC0xOtwixzIp8+uQb/ugngDu4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=OMwACxHT0Brt4IwXkS2dQ8yifnA9WdjEkO44sGRfNkXY+E+Rf04exnhE9EsWQd6Ox/wyLPW3916HQIP1ej5LUNmFoqE9EfmVRjYV2dAOgb81wPWeAkBmzOxArC+2LoZdSKCCyxrazEflZESRH+5jM4UM5sH1IJpPm9Mps3wMaEqtNAV0sK2J9x1+iiloBShMyS6DDOV6zA0jkUi6Xf2/XcvIjyXz1j9iP6o6u9KeWL09cLsSNP4GDvJvjM8t/jBMN5nYWWYqKsxb19uiknusJgffFwntdXdh8BfNkzUGd6G0rOUIdwryfgaohH3TIXF7wX5w23zuZ63k7c5d3blWVQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657549096; bh=ZdXLxkl/Eo6HEtCnr/qRivqI9jPbOdRlWFPqnEqhM+4=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Tn2PQwU/alVRwy+mqt8F0wefvrQ3Hmy9m7bOiylRRahz9nNIdPpPsANTYl3V/mFoHpG5lNMoEAPyrRlefbjRWGXCjt/jQYG9OHy/DtowN/dL8QtXKpD3DGhblrSDUcRi9dwSRG+e6G0yKZGPH1XvrSP2XRM1ytXTNhXIBjTd+hos3h8pOWOKkxP/oyYKZkjzImjJk9DlUsAAwnzWjaKGBXmw+kVIW2fLAfWyI8NvPGC6+147YDVSSWgdCqCdAFD2mR++kiFFTSsP6klx1JwQTjg3rUX85NcBkkgZnEtnoYaj2A5AAjIkHs1mkYUY7O1Uyjf5oKilTlnSYUdRT34dQg== X-YMail-OSG: 8V.DSTEVM1mrc4lotEROYeiaCxEjKspywy8V9Kld6BBifq53SFVi7nBgOAc0xnJ jB2Q6XgvUJxY1Ft5S0fc.7qXuepA6sozMwzEn1SZeGT_pqvy1uICE.b7PbBt.UpUf2P7386Ky5Rn Csae4Ub8odZl3EuNzB9lzFsZfZVOKVIajWMw0QnKtqEyzZcuC.OqmDxNxeGmnUFZoH4nHKFwYf7P wA9jWZMbaPWpSx0niM2diIzV0nN3bgKmj.VthVCeyNai9qbOHo8i1WCsLAjJ46im9qN2Nn6riol3 S3nUDB13GbhWCCizO7htDWUz4gU8duJQInBun.j4_MvNdcz.txVKVj0egSDpm6jgueGXd2T_kT.B E3pekACI5Ifpy9wmYVB48j7vGwPMhnYX0YTMT8LE_KNHdyx4UippxXOt6Z3j4OTQzXTJsihe9P9b zQcORHpUYSonBBsFSYDO8qrNzICyFFXfuR3XHfMatly7pVXs5uHEshZ0_FzNCYTRN8liCq72ieeD c0B8mxrOc4OpK.5e9rKzqUXAmsjB3mBa5BpXgAbMxY3kJuxPMEEgu9yGqFKUEQgQoE4mA7TwWJs7 s5GcX8x3zdYD_id_D74CppAWc.ZfAEnIho2ULkjVrGkUUfoSHKeuZwI54MUpbiBnJrOH6.rwb01V 40jaxzN0E.FG9LIqQA0Kem0QvqCcxKXR36T7TFAmQt8W.fxpGdROfAgkzNSOKjh6FsSl7YtvzaG_ sakTHfLIg9CKJehfZajePzJl6BqslFmjYkpRFsQL1XdS9adTfA7dRqchSw5m87A_fcjRdKrazt4B RgOsADWZ8LIAQhwjTS_iHQdu_wg1F6nhZnzGgvWEFLPWxkSIhIq2HYyevDDDob3H1OPxeWDZzkga i9vVxw.pI8pUZmfNDDqiOv0P0998DZZsAoR0Az85ntu4VJUSaRfK873sFgiHPENKXgGS5rRpdTw3 8Rm_1FUWv.IX4znaO5NbcNIsHlXOghrniWaS.guPu0LX7R8Z7bK7D3YZrglSZcn6oWZKwsON3Qlm 0hJLrlsgE.xPP2x6IxJv5qxYaInzZTeIfb4bFdl6.mmeAWPV5ZjGmP2l12EBUso2XrzrUBQdRFb5 n2iVeYKKhnbUS6g68yhRljBh9sXthC0hk4W_3qZlVFkrjdNDEcerlpZhU0o.FR0u6LbHJ8oVm7jT ZaCC1t4lcuPXP._xoGwYb.A_MtpY8vIjYZQQoIuSxtbjE.X_022DTjIWreGPhdJFX58P5izmQiF3 LQyq0ozBhv3RsdddChTY3DnVsJkiCpkxPQ5asWEVCCyGljfcrUyDREugRrE6jBkXn_e7LxSdU_yo 6TIPr0IObbKVAFBmL9fSgVZOlUfSU4P_5cooJ1EMKgVXmsRdLOAL0PhC0mpci0sCjPG9N4IujYkH .gLbELb5Y_OUc1rSIzEx7I1Km65448ACNkydL6L37pDMe1SUJcBayn0n6R93IkiuUAC1_33InfOV JPIgHV3oOz07RCnUcu906v8UdEP5WUBt_xkRCZA94lLEmxo5LX0AYeZvaixh2xMBEIE1ars_V2Ie 6Uh81AiHw_Ou7gKYongCMWEYAp8aBDK2qdypHRa06_u08ALCAtjgP4ZWB_3bn9BhvWqymqdwf2h4 OR4Bxlb9tS0fb.RRZ.tc.dd5Vcl9a5xe10B6932xh5WGeF_DFaiUV1iCKkjxL8MbCH4YBMbzI_uq k39XP4olWl5p4GgKyRWLtWZrVx39UbdaiF5_K_c_OkM1gqhfzIoJO6wOvUZDIGk4CjpS7MKDjxtI Asv9XnlX8F8M6yCuT.IQSS84V8UlSx.nHQuoC39gPB5.WgjOp7zL7UXbzI3y2Ic2M.dw_x89kDi7 sxyvMgyO4FyBz9jzqmCrA27OGCOKii55sFtHK32QAkFnjtKURRqOEzmlsBHcVArpZdoOnvDymPi1 I7vmn2BlqrfgNLnyi7ZVQBGiC8kmfOtVsJOf.JPa7CupAWVCOWDyHPWvcixnNzP1DOxk0UAhrZSo 4PHQt7LIm209G_bTxJXuKLAwvOmjazal4b_M.u935ITTjkMk4gIsJPvSSBABy_c5pJ3WrUXvW5pR xRcBipqsGnJUi8d99R5iNtRTMHOj_Zf3oBH8H4npttulelXOtp_SwGesRyjWVykutleOKEI5iUHn IWmif0M4Ze8OmjjI_X8gfAjD0mSwATatwOzXcyT05Z.uNjtHED_x2S761fSIiEmm2U.yvHUdl4cy LvpknkcsYhNa4WtndJ9wKUQ-- X-Sonic-MF: Message-ID: <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> Date: Mon, 11 Jul 2022 10:18:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3985 On 7/5/22 12:14 PM, Borislav Petkov wrote: > On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: > > Re-using pat_disabled like you do in your suggestion below won't > > work, because mtrr_bp_init() calls pat_disable() when MTRRs > > appear to be disabled (from the kernel's view). The goal is to > > honor "nopat" without honoring any other calls to pat_disable(). > > Actually, the current goal is to adjust Xen dom0 because: > > 1. it uses the PAT code > > 2. but then it does something special and hides the MTRRs > > which is not something real hardware does. > > So this one-off thing should be prominent, visible and not get in the > way. Hello, I have spent a fair amount of time this past weekend investigating this regression and what might have caused it and I also have done several tests on my Xen workstation that exhibits the regression to verify my understanding of the problem and also raise other problematic points. I think, in addition to immediately fixing the regression by fixing the now five-year-old commit that is the root cause of the recently exposed regression, as discussed in my earlier message which proposes a simple patch to fix that five-year-old broken commit, https://lore.kernel.org/lkml/63583497-152f-5880-4c8f-d47e2a81f5a6@netscape.net/ there needs to be a decision about how best to deal with this very aptly described "one-off Xen thing" in the future. One problem in x86/mm/pat/memtype.c is the fact that there exist two functions, pat_init(), and init_cache_modes(), that do more or less the same thing, so that when one of those functions needs to be updated, the other also needs to be updated. In the past, when changes to the pat_enable and pat_disable functions and variables were made, all too often, the change was only applied to pat_init() and not to init_cache_modes() and the one-off Xen case was simply not addressed and dealt with properly. So I propose the following: 1) Identify those things that always need to be done in either pat_init() or init_cache_modes() and try to combine those things into a single function so that changes will be applied for both cases. We sort of have that now with __init_cache_modes(), but it is not really good enough to prevent the regressions we sometimes get in Xen PV domains such as the current regression we have with Xen Dom0 and certain particular Intel graphics devices. 2) If it is not possible to do what is proposed in 1), at least re-factor the code to make it very clear that whenever either pat_init() needs to be adjusted or init_cache_modes() needs to be adjusted, care must be taken to ensure that all cases are properly dealt with, including the one-off Xen case of enabling PAT with MTRR disabled, Currently, AIUI, all one really needs to know is that init_cached_modes() handles two special cases: First, when PAT is disabled for any reason, including when the "nopat" boot option is set, and second, the one-off Xen case of MTRR being disabled but PAT being enabled. I am trying to do number 2 with a patch series I am working on. It is up to the experts to decide if it is possible or even desirable to improve the code so that any changes to the caching configuration are more likely to be properly implemented for all supported platforms by successfully combining the two functions pat_init() and init_cache_modes() into a single function. The new function would probably need to be renamed and include bits from mtrr_bp_enabled, etc. for it to function properly. If anyone wants to argue that it is not desirable to try combine pat_init() and init_cache_modes() into a single function, I think the burden of proof rests on that person to demonstrate why it is good and clean coding practice to continue to have them separate and independent from each other in the code when they both essentially do the same thing in the end, which is call __init_cache_modes() and determine the PAT state, and also probably the MTRR state. Best Regards, Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:27:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:27:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365191.595294 (Exim 4.92) (envelope-from ) id 1oAuNL-0005mu-Kj; Mon, 11 Jul 2022 14:27:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365191.595294; Mon, 11 Jul 2022 14:27:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuNL-0005mn-Gw; Mon, 11 Jul 2022 14:27:03 +0000 Received: by outflank-mailman (input) for mailman id 365191; Mon, 11 Jul 2022 14:27:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuNK-0005mh-4L for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 14:27:02 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 85ae4f93-0125-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 16:27:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85ae4f93-0125-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657549620; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=MY570fFK4YsmxDWYZjD5dBJlRpHK/oRe5S8X0AvzdIY=; b=XXLKy7qYUiqTV1C/CMvONyjskHApG5jNTT/jRgPnN33N5zY3xPv44v3m mB2KaYOd6514Nc9RrziO64dwQltidaFZtzf0vhg1Q/7G+IilIgpe5X+Oj GVUozsiGbDyR0sW0M3NLascN70+z2R+MBnmqFAEwxvqxrcXJa/XzBwpxM w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: None X-MesageID: 74830718 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:nArWqK9VDryxEi3Fnm0GDrUDN3yTJUtcMsCJ2f8bNWPcYEJGY0x3y zYZUWuObqyOYmanfdB1YYjioUsFsMWByNE3SFc4/iA8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5DnZ74f5fs7Rh2NQw3oHgW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaWPGQNuApHoo85eaghGDDB+OpxF1qCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFIoZpnFnyyCfFfs8SIrPa67L+cVZzHE7gcUm8fP2O JZJMmIwNUSojxtnGlkaNr0FpueUnnjPcxpqlV+xqolsyj2GpOB2+P23WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4cEhoNTnOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4gyPwkuF4S4USgDxhAIKNi+pFLgDolgJ8VeE= IronPort-HdrOrdr: A9a23:bF2DHKxYrFmJTa/Z1t9VKrPwLr1zdoMgy1knxilNoRw8SK2lfu SV7ZMmPH7P+VIssR4b9exoVJPufZqYz+8S3WBzB8bGYOCFghrKEGgK1+KLqFeMJ8S9zJ8+6U 4JSdkGNDSaNzhHZKjBjjWFLw== X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="74830718" Date: Mon, 11 Jul 2022 15:26:44 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom Message-ID: References: <20220624092806.27700-1-jgross@suse.com> <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> On Thu, Jul 07, 2022 at 05:01:38PM +0200, Juergen Gross wrote: > On 07.07.22 16:45, Anthony PERARD wrote: > > On Fri, Jun 24, 2022 at 11:28:06AM +0200, Juergen Gross wrote: > > > In case of maxmem != memsize the E820 map of the PVH stubdom is wrong, > > > as it is missing the RAM above memsize. > > > > > > Additionally the MMIO area should only cover the HVM special pages. > > > > > > Signed-off-by: Juergen Gross > > > --- > > > tools/helpers/init-xenstore-domain.c | 16 ++++++++++------ > > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > > > diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c > > > index b4f3c65a8a..dad8e43c42 100644 > > > --- a/tools/helpers/init-xenstore-domain.c > > > +++ b/tools/helpers/init-xenstore-domain.c > > > @@ -157,21 +158,24 @@ static int build(xc_interface *xch) > > > config.flags |= XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap; > > > config.arch.emulation_flags = XEN_X86_EMU_LAPIC; > > > dom->target_pages = mem_size >> XC_PAGE_SHIFT; > > > - dom->mmio_size = GB(4) - LAPIC_BASE_ADDRESS; > > > + dom->mmio_size = X86_HVM_NR_SPECIAL_PAGES << XC_PAGE_SHIFT; > > > dom->lowmem_end = (mem_size > LAPIC_BASE_ADDRESS) ? > > > LAPIC_BASE_ADDRESS : mem_size; > > > dom->highmem_end = (mem_size > LAPIC_BASE_ADDRESS) ? > > > GB(4) + mem_size - LAPIC_BASE_ADDRESS : 0; > > > - dom->mmio_start = LAPIC_BASE_ADDRESS; > > > + dom->mmio_start = (X86_HVM_END_SPECIAL_REGION - > > > + X86_HVM_NR_SPECIAL_PAGES) << XC_PAGE_SHIFT; > > > dom->max_vcpus = 1; > > > e820[0].addr = 0; > > > - e820[0].size = dom->lowmem_end; > > > + e820[0].size = (max_size > LAPIC_BASE_ADDRESS) ? > > > + LAPIC_BASE_ADDRESS : max_size; > > > e820[0].type = E820_RAM; > > > - e820[1].addr = LAPIC_BASE_ADDRESS; > > > + e820[1].addr = dom->mmio_start; > > > > > > So, it isn't expected to have an entry covering the LAPIC addresses, > > right? I guess not as seen in df1ca1dfe20. > > > > But based on that same commit info, shouldn't the LAPIC address part of > > `dom->mmio_start, dom->mmio_size`? (I don't know how dom->mmio_start is > > used, yet, but maybe it's used by Xen or xen libraries to avoid > > allocations in the wrong places) > > In my understanding this is the purpose of lowmem_end. It looks like dom->mmio_start is used in libxenguest.meminit_hvm() to check if a super page can be allocated, but lowmem_end would probably prevent the check from been done in the first place. So I guess mmio_start value doesn't matter in this case. There is another use of mmio_start, it's in module_init_one(), which I think is used to blobs to the guest like the firmware or the acpi tables. It's an other check to be sure the new "module" doesn't overlap with the mmio region. So based on that, I kind of think that mmio_start should include the LAPIC. But on the other end, I don't think "init-xenstore-domain" have any "module", so again, the value of mmio_start probably doesn't matter at this point. But maybe we should keep LAPIC in [mmio_start,mmio_size] just in case it matter later. > OTOH I can modify the patch to be along the lines of df1ca1dfe20. > > > Juergen -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:31:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:31:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365197.595305 (Exim 4.92) (envelope-from ) id 1oAuRS-0007BK-5m; Mon, 11 Jul 2022 14:31:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365197.595305; Mon, 11 Jul 2022 14:31:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuRS-0007BD-1y; Mon, 11 Jul 2022 14:31:18 +0000 Received: by outflank-mailman (input) for mailman id 365197; Mon, 11 Jul 2022 14:31:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuRQ-0007B7-IS for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 14:31:16 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e4a120a-0126-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 16:31:14 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 7C51E20367; Mon, 11 Jul 2022 14:31:14 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3A8DA13524; Mon, 11 Jul 2022 14:31:14 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id HLWWDDI0zGL3SgAAMHmgww (envelope-from ); Mon, 11 Jul 2022 14:31:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e4a120a-0126-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657549874; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i+qsif4a0a2Bz2k2mGqpG6eHPsih8lkLo27Ye6x0uTs=; b=iTT60rhfjlwmrL0KE4s1q2tC6sdwBH63vKFPt+QHFbLQAICBTI2B189vzZ8+JDnduTaA7V OCvDDH3+2maqh8o23sS3LsRal0ecHM2CLU9KXytbWVO8OivVRdzL0KF5fJobT4QqSBYQFS zhLVgJr6f/66tO4GjRmk/wLFg0iexuQ= Message-ID: Date: Mon, 11 Jul 2022 16:31:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> From: Juergen Gross Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen In-Reply-To: <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------cf3SVQy8ZQnR0sTTfnNEDYPc" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------cf3SVQy8ZQnR0sTTfnNEDYPc Content-Type: multipart/mixed; boundary="------------ArVzvAwFKmBEQK8rBKibEYfU"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Message-ID: Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> In-Reply-To: <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> --------------ArVzvAwFKmBEQK8rBKibEYfU Content-Type: multipart/mixed; boundary="------------JKySDGkx4Peknf3GblYXzjxN" --------------JKySDGkx4Peknf3GblYXzjxN Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTY6MTgsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IE9uIDcvNS8y MiAxMjoxNCBQTSwgQm9yaXNsYXYgUGV0a292IHdyb3RlOg0KPj4gT24gVHVlLCBKdWwgMDUs IDIwMjIgYXQgMDU6NTY6MzZQTSArMDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+Pj4gUmUt dXNpbmcgcGF0X2Rpc2FibGVkIGxpa2UgeW91IGRvIGluIHlvdXIgc3VnZ2VzdGlvbiBiZWxv dyB3b24ndA0KPj4+IHdvcmssIGJlY2F1c2UgbXRycl9icF9pbml0KCkgY2FsbHMgcGF0X2Rp c2FibGUoKSB3aGVuIE1UUlJzDQo+Pj4gYXBwZWFyIHRvIGJlIGRpc2FibGVkIChmcm9tIHRo ZSBrZXJuZWwncyB2aWV3KS4gVGhlIGdvYWwgaXMgdG8NCj4+PiBob25vciAibm9wYXQiIHdp dGhvdXQgaG9ub3JpbmcgYW55IG90aGVyIGNhbGxzIHRvIHBhdF9kaXNhYmxlKCkuDQo+Pg0K Pj4gQWN0dWFsbHksIHRoZSBjdXJyZW50IGdvYWwgaXMgdG8gYWRqdXN0IFhlbiBkb20wIGJl Y2F1c2U6DQo+Pg0KPj4gMS4gaXQgdXNlcyB0aGUgUEFUIGNvZGUNCj4+DQo+PiAyLiBidXQg dGhlbiBpdCBkb2VzIHNvbWV0aGluZyBzcGVjaWFsIGFuZCBoaWRlcyB0aGUgTVRSUnMNCj4+ DQo+PiB3aGljaCBpcyBub3Qgc29tZXRoaW5nIHJlYWwgaGFyZHdhcmUgZG9lcy4NCj4+DQo+ PiBTbyB0aGlzIG9uZS1vZmYgdGhpbmcgc2hvdWxkIGJlIHByb21pbmVudCwgdmlzaWJsZSBh bmQgbm90IGdldCBpbiB0aGUNCj4+IHdheS4NCj4gDQo+IEhlbGxvLA0KPiANCj4gSSBoYXZl IHNwZW50IGEgZmFpciBhbW91bnQgb2YgdGltZSB0aGlzIHBhc3Qgd2Vla2VuZA0KPiBpbnZl c3RpZ2F0aW5nIHRoaXMgcmVncmVzc2lvbiBhbmQgd2hhdCBtaWdodCBoYXZlIGNhdXNlZA0K PiBpdCBhbmQgSSBhbHNvIGhhdmUgZG9uZSBzZXZlcmFsIHRlc3RzIG9uIG15IFhlbiB3b3Jr c3RhdGlvbg0KPiB0aGF0IGV4aGliaXRzIHRoZSByZWdyZXNzaW9uIHRvIHZlcmlmeSBteSB1 bmRlcnN0YW5kaW5nDQo+IG9mIHRoZSBwcm9ibGVtIGFuZCBhbHNvIHJhaXNlIG90aGVyIHBy b2JsZW1hdGljIHBvaW50cy4NCj4gDQo+IEkgdGhpbmssIGluIGFkZGl0aW9uIHRvIGltbWVk aWF0ZWx5IGZpeGluZyB0aGUgcmVncmVzc2lvbiBieQ0KPiBmaXhpbmcgdGhlIG5vdyBmaXZl LXllYXItb2xkIGNvbW1pdCB0aGF0IGlzIHRoZSByb290IGNhdXNlDQo+IG9mIHRoZSByZWNl bnRseSBleHBvc2VkIHJlZ3Jlc3Npb24sIGFzIGRpc2N1c3NlZCBpbiBteQ0KPiBlYXJsaWVy IG1lc3NhZ2Ugd2hpY2ggcHJvcG9zZXMgYSBzaW1wbGUgcGF0Y2ggdG8gZml4IHRoYXQNCj4g Zml2ZS15ZWFyLW9sZCBicm9rZW4gY29tbWl0LA0KPiANCj4gaHR0cHM6Ly9sb3JlLmtlcm5l bC5vcmcvbGttbC82MzU4MzQ5Ny0xNTJmLTU4ODAtNGM4Zi1kNDdlMmE4MWY1YTZAbmV0c2Nh cGUubmV0Lw0KPiANCj4gdGhlcmUgbmVlZHMgdG8gYmUgYSBkZWNpc2lvbiBhYm91dCBob3cg YmVzdCB0byBkZWFsIHdpdGgNCj4gdGhpcyB2ZXJ5IGFwdGx5IGRlc2NyaWJlZCAib25lLW9m ZiBYZW4gdGhpbmciIGluIHRoZSBmdXR1cmUuDQo+IA0KPiBPbmUgcHJvYmxlbSBpbiB4ODYv bW0vcGF0L21lbXR5cGUuYyBpcyB0aGUgZmFjdCB0aGF0IHRoZXJlDQo+IGV4aXN0IHR3byBm dW5jdGlvbnMsIHBhdF9pbml0KCksIGFuZCBpbml0X2NhY2hlX21vZGVzKCksIHRoYXQNCj4g ZG8gbW9yZSBvciBsZXNzIHRoZSBzYW1lIHRoaW5nLCBzbyB0aGF0IHdoZW4gb25lIG9mIHRo b3NlDQo+IGZ1bmN0aW9ucyBuZWVkcyB0byBiZSB1cGRhdGVkLCB0aGUgb3RoZXIgYWxzbyBu ZWVkcyB0bw0KPiBiZSB1cGRhdGVkLiBJbiB0aGUgcGFzdCwgd2hlbiBjaGFuZ2VzIHRvIHRo ZSBwYXRfZW5hYmxlDQo+IGFuZCBwYXRfZGlzYWJsZSBmdW5jdGlvbnMgYW5kIHZhcmlhYmxl cyB3ZXJlIG1hZGUsIGFsbA0KPiB0b28gb2Z0ZW4sIHRoZSBjaGFuZ2Ugd2FzIG9ubHkgYXBw bGllZCB0byBwYXRfaW5pdCgpIGFuZCBub3QNCj4gdG8gaW5pdF9jYWNoZV9tb2RlcygpIGFu ZCB0aGUgb25lLW9mZiBYZW4gY2FzZSB3YXMgc2ltcGx5DQo+IG5vdCBhZGRyZXNzZWQgYW5k IGRlYWx0IHdpdGggcHJvcGVybHkuDQo+IA0KPiBTbyBJIHByb3Bvc2UgdGhlIGZvbGxvd2lu ZzoNCj4gDQo+IDEpIElkZW50aWZ5IHRob3NlIHRoaW5ncyB0aGF0IGFsd2F5cyBuZWVkIHRv IGJlIGRvbmUgaW4NCj4gZWl0aGVyIHBhdF9pbml0KCkgb3IgaW5pdF9jYWNoZV9tb2Rlcygp IGFuZCB0cnkgdG8gY29tYmluZQ0KPiB0aG9zZSB0aGluZ3MgaW50byBhIHNpbmdsZSBmdW5j dGlvbiBzbyB0aGF0IGNoYW5nZXMgd2lsbA0KPiBiZSBhcHBsaWVkIGZvciBib3RoIGNhc2Vz LiBXZSBzb3J0IG9mIGhhdmUgdGhhdCBub3cgd2l0aA0KPiBfX2luaXRfY2FjaGVfbW9kZXMo KSwgYnV0IGl0IGlzIG5vdCByZWFsbHkgZ29vZCBlbm91Z2ggdG8NCj4gcHJldmVudCB0aGUg cmVncmVzc2lvbnMgd2Ugc29tZXRpbWVzIGdldCBpbiBYZW4gUFYNCj4gZG9tYWlucyBzdWNo IGFzIHRoZSBjdXJyZW50IHJlZ3Jlc3Npb24gd2UgaGF2ZSB3aXRoDQo+IFhlbiBEb20wIGFu ZCBjZXJ0YWluIHBhcnRpY3VsYXIgSW50ZWwgZ3JhcGhpY3MgZGV2aWNlcy4NCj4gDQo+IDIp IElmIGl0IGlzIG5vdCBwb3NzaWJsZSB0byBkbyB3aGF0IGlzIHByb3Bvc2VkIGluIDEpLCBh dCBsZWFzdA0KPiByZS1mYWN0b3IgdGhlIGNvZGUgdG8gbWFrZSBpdCB2ZXJ5IGNsZWFyIHRo YXQgd2hlbmV2ZXINCj4gZWl0aGVyIHBhdF9pbml0KCkgbmVlZHMgdG8gYmUgYWRqdXN0ZWQg b3IgaW5pdF9jYWNoZV9tb2RlcygpDQo+IG5lZWRzIHRvIGJlIGFkanVzdGVkLCBjYXJlIG11 c3QgYmUgdGFrZW4gdG8gZW5zdXJlIHRoYXQNCj4gYWxsIGNhc2VzIGFyZSBwcm9wZXJseSBk ZWFsdCB3aXRoLCBpbmNsdWRpbmcgdGhlDQo+IG9uZS1vZmYgWGVuIGNhc2Ugb2YgZW5hYmxp bmcgUEFUIHdpdGggTVRSUiBkaXNhYmxlZCwNCj4gQ3VycmVudGx5LCBBSVVJLCBhbGwgb25l IHJlYWxseSBuZWVkcyB0byBrbm93IGlzIHRoYXQNCj4gaW5pdF9jYWNoZWRfbW9kZXMoKSBo YW5kbGVzIHR3byBzcGVjaWFsIGNhc2VzOg0KPiBGaXJzdCwgd2hlbiBQQVQgaXMgZGlzYWJs ZWQgZm9yIGFueSByZWFzb24sIGluY2x1ZGluZyB3aGVuDQo+IHRoZSAibm9wYXQiIGJvb3Qg b3B0aW9uIGlzIHNldCwgYW5kIHNlY29uZCwgdGhlIG9uZS1vZmYNCj4gWGVuIGNhc2Ugb2Yg TVRSUiBiZWluZyBkaXNhYmxlZCBidXQgUEFUIGJlaW5nIGVuYWJsZWQuDQo+IA0KPiBJIGFt IHRyeWluZyB0byBkbyBudW1iZXIgMiB3aXRoIGEgcGF0Y2ggc2VyaWVzIEkgYW0NCj4gd29y a2luZyBvbi4gSXQgaXMgdXAgdG8gdGhlIGV4cGVydHMgdG8gZGVjaWRlIGlmIGl0DQo+IGlz IHBvc3NpYmxlIG9yIGV2ZW4gZGVzaXJhYmxlIHRvIGltcHJvdmUgdGhlIGNvZGUgc28NCj4g dGhhdCBhbnkgY2hhbmdlcyB0byB0aGUgY2FjaGluZyBjb25maWd1cmF0aW9uIGFyZSBtb3Jl DQo+IGxpa2VseSB0byBiZSBwcm9wZXJseSBpbXBsZW1lbnRlZCBmb3IgYWxsIHN1cHBvcnRl ZCBwbGF0Zm9ybXMNCj4gYnkgc3VjY2Vzc2Z1bGx5IGNvbWJpbmluZyB0aGUgdHdvIGZ1bmN0 aW9ucyBwYXRfaW5pdCgpIGFuZA0KPiBpbml0X2NhY2hlX21vZGVzKCkgaW50byBhIHNpbmds ZSBmdW5jdGlvbi4gVGhlIG5ldyBmdW5jdGlvbg0KPiB3b3VsZCBwcm9iYWJseSBuZWVkIHRv IGJlIHJlbmFtZWQgYW5kIGluY2x1ZGUgYml0cyBmcm9tDQo+IG10cnJfYnBfZW5hYmxlZCwg ZXRjLiBmb3IgaXQgdG8gZnVuY3Rpb24gcHJvcGVybHkuDQo+IA0KPiBJZiBhbnlvbmUgd2Fu dHMgdG8gYXJndWUgdGhhdCBpdCBpcyBub3QgZGVzaXJhYmxlIHRvIHRyeQ0KPiBjb21iaW5l IHBhdF9pbml0KCkgYW5kIGluaXRfY2FjaGVfbW9kZXMoKSBpbnRvIGEgc2luZ2xlDQo+IGZ1 bmN0aW9uLCBJIHRoaW5rIHRoZSBidXJkZW4gb2YgcHJvb2YgcmVzdHMgb24gdGhhdA0KPiBw ZXJzb24gdG8gZGVtb25zdHJhdGUgd2h5IGl0IGlzIGdvb2QgYW5kIGNsZWFuDQo+IGNvZGlu ZyBwcmFjdGljZSB0byBjb250aW51ZSB0byBoYXZlIHRoZW0gc2VwYXJhdGUNCj4gYW5kIGlu ZGVwZW5kZW50IGZyb20gZWFjaCBvdGhlciBpbiB0aGUgY29kZSB3aGVuDQo+IHRoZXkgYm90 aCBlc3NlbnRpYWxseSBkbyB0aGUgc2FtZSB0aGluZyBpbiB0aGUgZW5kLCB3aGljaA0KPiBp cyBjYWxsIF9faW5pdF9jYWNoZV9tb2RlcygpIGFuZCBkZXRlcm1pbmUgdGhlIFBBVA0KPiBz dGF0ZSwgYW5kIGFsc28gcHJvYmFibHkgdGhlIE1UUlIgc3RhdGUuDQoNCkkgdGhpbmsgdGhl IHByb3BlciBzb2x1dGlvbiB3b3VsZCBiZSB0byBtYWtlIFBBVCBhbmQgTVRSUiBpbmRlcGVu ZGVudA0KZnJvbSBlYWNoIG90aGVyIHdpdGggc29tZSBhZGRpdGlvbmFsIHJlc3RydWN0dXJp bmcgb24gdGhlIFBBVCBzaWRlOg0KDQpUb2RheSBQQVQgY2FuJ3QgYmUgdXNlZCB3aXRob3V0 IE1UUlIgYmVpbmcgYXZhaWxhYmxlLCB1bmxlc3MgTVRSUiBpcyBhdA0KbGVhc3QgY29uZmln dXJlZCB2aWEgQ09ORklHX01UUlIgYW5kIHRoZSBzeXN0ZW0gaXMgcnVubmluZyBhcyBYZW4g UFYNCmd1ZXN0LiBJbiB0aGlzIGNhc2UgUEFUIGlzIGF1dG9tYXRpY2FsbHkgYXZhaWxhYmxl IHZpYSB0aGUgaHlwZXJ2aXNvciwNCmJ1dCB0aGUgUEFUIE1TUiBjYW4ndCBiZSBtb2RpZmll ZCBieSB0aGUga2VybmVsIGFuZCBNVFJSIGlzIGRpc2FibGVkLg0KDQpBcyBhbiBhZGRpdGlv bmFsIGNvbXBsZXhpdHkgdGhlIGF2YWlsYWJpbGl0eSBvZiBQQVQgY2FuJ3QgYmUgcXVlcmll ZA0KdmlhIHBhdF9lbmFibGVkKCkgaW4gdGhlIFhlbiBQViBjYXNlLCBhcyB0aGUgbGFjayBv ZiBNVFJSIHdpbGwgc2V0IFBBVA0KdG8gYmUgZGlzYWJsZWQuIFRoaXMgbGVhZHMgdG8gc29t ZSBkcml2ZXJzIGJlbGlldmluZyB0aGF0IG5vdCBhbGwgY2FjaGUNCm1vZGVzIGFyZSBhdmFp bGFibGUsIHJlc3VsdGluZyBpbiBmYWlsdXJlcyBvciBkZWdyYWRlZCBmdW5jdGlvbmFsaXR5 DQoodGhlIGN1cnJlbnQgcmVncmVzc2lvbikuDQoNClRoZSBzYW1lIGFwcGxpZXMgdG8gYSBr ZXJuZWwgYnVpbHQgd2l0aCBubyBNVFJSIHN1cHBvcnQ6IGl0IHdvbid0DQphbGxvdyB0byB1 c2UgdGhlIFBBVCBNU1IsIGV2ZW4gaWYgdGhlcmUgaXMgbm8gdGVjaG5pY2FsIHJlYXNvbiBm b3INCnRoYXQsIG90aGVyIHRoYW4gc2V0dGluZyB1cCBQQVQgb24gYWxsIGNwdXMgdGhlIHNh bWUgd2F5ICh3aGljaCBpcyBhDQpyZXF1aXJlbWVudCBvZiB0aGUgcHJvY2Vzc29yJ3MgY2Fj aGUgbWFuYWdlbWVudCkgaXMgcmVseWluZyBvbiBzb21lDQpNVFJSIHNwZWNpZmljIGNvZGUu DQoNCkFsbCBvZiB0aGF0IHNob3VsZCBiZSBmaXhhYmxlIGJ5Og0KDQotIG1vdmluZyB0aGUg ZnVuY3Rpb24gbmVlZGVkIGJ5IFBBVCBmcm9tIE1UUlIgc3BlY2lmaWMgY29kZSBvbmUgbGV2 ZWwNCiAgIHVwDQotIGFkZGluZyBhIFBBVCBpbmRpcmVjdGlvbiBsYXllciBzdXBwb3J0aW5n IHRoZSAzIGNhc2VzICJubyBvciBkaXNhYmxlZA0KICAgUEFUIiwgIlBBVCB1bmRlciBrZXJu ZWwgY29udHJvbCIsIGFuZCAiUEFUIHVuZGVyIFhlbiBjb250cm9sIg0KLSByZW1vdmluZyB0 aGUgZGVwZW5kZW5jeSBvZiBQQVQgb24gTVRSUg0KDQpJJ2QgYmUgdXAgZm9yIHRyeWluZyB0 aGlzLCBidXQgcmlnaHQgbm93IEkgaGF2ZW4ndCBnb3QgdGhlIHRpbWUgdG8gZG8NCml0LiBJ IG1pZ2h0IGJlIGFibGUgdG8gc3RhcnQgd29ya2luZyBvbiB0aGF0IGluIFNlcHRlbWJlci4N Cg0KTWVhbndoaWxlIEkgdGhpbmsgZWl0aGVyIEphbidzIHBhdGNoIG9yIHRoZSBzaW1wbGUg b25lIG9mIENodWNrDQpzaG91bGQgYmUgYXBwbGllZC4NCg0KDQpKdWVyZ2VuDQo= --------------JKySDGkx4Peknf3GblYXzjxN Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JKySDGkx4Peknf3GblYXzjxN-- --------------ArVzvAwFKmBEQK8rBKibEYfU-- --------------cf3SVQy8ZQnR0sTTfnNEDYPc Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLMNDEFAwAAAAAACgkQsN6d1ii/Ey8I rAgAgA89Z5IbV68cr1LqOpVTqysh6Ubo0tBLRolmEvKvz57b8Sdck4+z4mqP3z94GAHD61WJPKc+ hVvgrgs1EVVzO66qqNX6qVUwZAouGgu/VNy4W+iPtv7JjK6HYk2ctJllcAjE0XT+BwL82yL/DXLn 08oMWiPY6q8WC5sgvVom1Q78Wq+zTExFpGkhx9ZyNuUpDdSSCMhXg3tPMI+r/htZtMKV37q/Tg3l 5sn5tk2GUfnd69xgbOeGizsmcr+ne9i+Wp2Z3aO7bVXyFBsiMrG+Cg9FkiBTuhKWjQfeAk4v3y3O jf6sKcZv+cmf65R7UbFudZGnXyZAlvJ/iO2Qp/pbiQ== =iQaR -----END PGP SIGNATURE----- --------------cf3SVQy8ZQnR0sTTfnNEDYPc-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 14:32:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 14:32:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365203.595315 (Exim 4.92) (envelope-from ) id 1oAuSU-0007jS-FW; Mon, 11 Jul 2022 14:32:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365203.595315; Mon, 11 Jul 2022 14:32:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuSU-0007jL-Ch; Mon, 11 Jul 2022 14:32:22 +0000 Received: by outflank-mailman (input) for mailman id 365203; Mon, 11 Jul 2022 14:32:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuST-0007jB-3Y for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 14:32:21 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60057.outbound.protection.outlook.com [40.107.6.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 44d9061a-0126-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 16:32:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8658.eurprd04.prod.outlook.com (2603:10a6:20b:429::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 14:32:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 14:32:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44d9061a-0126-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lZ1avI9fmZ7GD0zK5pxgQBGLMYojyK/OE8aH8KPpFk0a0b/7cte6bWR6yVu8NlEadl4q3GoGetC1CF/2NVUH+IoD50cFAaOvy4VEm5WHzy3b4vVgxR2ZLQ8Sjei7F6hQKiz9Qg4EA4OlUvl190r3+dyjOIJQ3qsuWLcCsvFrH4BmJJoV3hB96XXUjkkquOTMeLxGC40rbJY5DkdvjVFcBnf4c/UqLD09fwl77JSOakHEDzzj7emERNWOkommme+FMPJ8HD3vyuvVKi2cDfIlOz25X1I/p+G4wL0Kpluy3mXZHzX2msgrtKKI/MGlp+mN6+otXjfJNQGHUyaDCpqUzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y5ilYfVvTdvnaDfIBOkumYXWZCHNCtVKRfl1EGELMhY=; b=m+T8FbnJ690pqM8XBtWALBOC1bOvdGNEqujRCv9drMq+W15TE39tv5ItmqN5tHkbMJbRHFgLtPiT/0TISF6FkkbvwH5QpyhT5faHbQyFzpbY3C/sAugcjtF+ChyQVyR0RSShDc+XLQ9AN8PzuiYQ4ydwtZQ+Qa8rxfL6TidFtlghyRcVNe1rSvjymhc4Z04IfULdz25UQ6CRLp4JQJjFm7Xu7mYXO3gIS9JXot53/7r+2DRfnbGuhub8Te0PEs4VHQzbCgRTTOnvHuCINKbRjodXLHWyeQL871f6cUdJZouRIby8T+p3Eh4B4PHqEx8kkV5Wsi85R9+8pRguyD0flA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y5ilYfVvTdvnaDfIBOkumYXWZCHNCtVKRfl1EGELMhY=; b=swWYlYRB4gMwzJnFJ6k7T010AQyzmidwEq0f3B774eSFq8JKiCxCvBrDcnOm7MTVatUJf9ed6N6W//nvVzU/V67ZSuXtR7N/0D2goxJkSdfc5zN9jjI8Egd9lpOOvSMYp0xVj+JJI9zEY+xkS01tk7zaRwxaRkB8SXaOuY5vHpXrq8NemOW1u5r+WZ4iIGaX+7RnWvGRJGHsn4oedMrUwCPZm4eD2qkYc3gbz9vs5LzXBhM73JVFCq7OI+ku6QdDGCBJGIrFkYEL0SOwIQ/h8nQt6UuhK8Iz+kvYT5JHOm25l3CbjJs4utqk+QAQlTXEeMev+KpYFn3nQ1fpWRaYEw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <04b5e393-e7ad-956c-dbea-8203b6846726@suse.com> Date: Mon, 11 Jul 2022 16:32:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis From: Jan Beulich Subject: Arm64's xen.efi vs GNU binutils (and alike) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52a9c03a-2764-46db-3e4d-08da634a27fe X-MS-TrafficTypeDiagnostic: AS8PR04MB8658:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: evMCP5eFuc6tok0h2OiuipOmKIVJmWcEl0LVrwb6+UMPiqNy+eU3wdJxRWaT56VShtyfYmODJhoa+WZhBMBx6Kv1zX4hpDqyg93k4wu0zqSkPSFooK31dFQl6fw9NJwozSKgGuVPfnZytCsN52tBp96E+6ZSZTVyeV92rnqnJ11R0tT2qCqLQ4jHaO+3EqCtcdDpS9O7FgOmcHg8XPT1BaEbejGeN1mvO8/c6WkTsrLOklu0tYFJbfIOdMgH1a4yOZAcKQz93I/t5VZWAmxN1eelWi4D6eEicPwlw/oKMd+CnFdutKsigR5iH6x58VKXK/dSgjalIxoyvAoo2lFZT4b0HqAdlhxoOJm1KjAazBXFCnIJwDid0ut/2TuCdrigOjuPUsfb68B7tnCbQgs9qlxd8CZdS1JBt5DiRLubg/b/Mv+/+3FffgZYPdFFQzkP4OUUUR1IVU6q9KNSJNpWvyDUaGdWQmZHpNN0GjIcq3SwVfeogJ4YV6qQbQmscO2LjEmEyxT2h2gfz+M3B4CaOLXv67NpOKO9YKlwyntZR0daZbTq+BdpMfGyV9K70WF20DFGTwZxW8ahbpXK4yyX1eZa1k9JoZkoz5voKq9NYJ+DEhNp5qDa2RexoE+3sGtSqbw1xLnp+VjKwirAqGXaMKdOQMZ+7pC1wqB5vn81YSEX7Mg4ZoR0szi/18ARzDEFODnwtr/Y//k2tI9eP+10W5PbL59VgfYuHl9NfFTvFsy0+aya//w+15YuDqOe4Wl87+PLv3gjL6n1kw62KAmaS3QGRwi4bTWniolAJmKxe/H8ES6GVfTNT5uoUXek6RE7lddNhR8HM1ccz0EycTuiCa/x5PbqAmaz8zziXDXtYQA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(376002)(366004)(396003)(6486002)(2906002)(316002)(6916009)(6512007)(26005)(6506007)(54906003)(8936002)(31696002)(5660300002)(36756003)(4326008)(8676002)(86362001)(31686004)(41300700001)(186003)(38100700002)(66946007)(66476007)(66556008)(478600001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXFsdDJwblFaY0ZFNUU1aVg0dGdFUEMzSmNJZW1RRGExd2FYeVFtZnFLamJD?= =?utf-8?B?ZUdrNGh5bTlDc1R0dVpYQ2tWZ3Z0S1hpV3c3aWUxdUIxaEJPTWZpWTJpNUhU?= =?utf-8?B?cVYzaWpZUFRScUpBRlZPR3lUb0VlQUVCQ0ZyaXdaQ0wzTm5ZSER2akRPalM4?= =?utf-8?B?cHUyYXVHQnZHc3Jmb3lUaGdQRDcxYWs2WWVlWEJXTkM0WU15bGJpcXFLTnd4?= =?utf-8?B?MFlKVkNxUnRkVXMrRlFJeUY4U09MVEppaS9Od0g1bDM4Tnc3ZGppVnBMa3dN?= =?utf-8?B?OXVBUkFUL3lLUWxzZis1aGg5NXVjN3RxSUhVWkZ3aHp1blBMVzZ4cVpjcWcx?= =?utf-8?B?S0ZRU1dwRzVxN3Y0enlrZzlBQ09BSHo2L05aK3ZSUlhDNkViMWttUHAvWWJ4?= =?utf-8?B?ZW1qNy9FSkhBWGIvanVvUWhnNDRVZE9sRzRJaUNGY2lZSFNDaVFmdnJuVWJh?= =?utf-8?B?ZDZzNXZ4cWZmR3MwWGFmMHVpeitnSk9yczNtSUxzUzU4OUorZXZmcHhMY2RO?= =?utf-8?B?UVVCQWFQQmlhcUNtalZJWXNuaFBpWFFscVM2Zk8ybGU4Y3htQmdIdTNTWjdz?= =?utf-8?B?NGZranc3TnJ3REZFYXhONFdNclN5OEhEK1IvcittU1RYZTNuaDJLcW9RbUxw?= =?utf-8?B?aStlbEtNUU9NRDhCcldCY2ZJaGEweGlHUTdJNExzaHRMRDJ4dmRyU29ldDlC?= =?utf-8?B?QWdRV3FOTWNRLzdHU1VtcjgvMjBlQnYrYXlwOGlwTklzem43dVAyWWhld3RI?= =?utf-8?B?Q2VGVzJLUTkyY0RSNzJtbXQ4WmdiSG9EQWRiNk55L0lxdFFhMVQxaXVlVER5?= =?utf-8?B?bDlmRGlISzJkWmc1T1JpOTROakZ0bjl5aFR4QzJoWVlGOEphcm4ybmF2MHhj?= =?utf-8?B?Q3gxak5pbnhBdUx4TnJIeVNUZy93YzhTdmkzMkpUckdIUXdsYkZid1VQWkds?= =?utf-8?B?VnlKS2l4eThVOW1nbWdyOEdzMFFvbEdaZmxqNWtpTU5JNGtJSEUxTkVsS2Ro?= =?utf-8?B?OXpvazJMN0t5eFRBYUxDYU1nS0t3SWtVM3hXV2Z5UU5WcDBJZXdWbUQyNDJF?= =?utf-8?B?Yjh6Z2o4R29Kd3ZleG1QRnJrWmluUklmSmRIWFFtZ2NpWXBvTEQ2UFpFb2w4?= =?utf-8?B?RHQyL1AvWGNKeDdqNmUrMlFwTndWV3BEZXVoUjI3RU1HT2hsWGs5MEpXTU90?= =?utf-8?B?YVc3TTFFR1Fxb1lscFhFQXJ6TzhZbmwyMTNic0Q0NkNUbCttMWNCb3Q0UUFj?= =?utf-8?B?aXhOTXc5Yk9ubkozQ3NlRGRGaDZqcmlPS2YzT3RmSklGTS8xKzFvd2p5Nzlr?= =?utf-8?B?RTg5NUx5YkNuTmhUcXRPU2w4L0RkZDRQZUtadWxVbVN0VnQrdXFMTFFWblBM?= =?utf-8?B?a1pXYjZHWjJPMzNKcE1EWVRTZnB0U2w5eEVka1k4cFMzNmhFU2t5dzZ3enJQ?= =?utf-8?B?dE83NzhPdURvQnYzOFNwRHR4QS9Fc0ZINm90b3ZPbmtiRUZlMjdtQ21ESDBp?= =?utf-8?B?b3hUWG9FOXpMVlJNRmx4NWVYTVBsd0ZIV0lsK0JrT0pRYmZQU2J2OWNiS0dZ?= =?utf-8?B?UFZwOVVIeit2bDJ5ei9TNEVKT0d2WXFMZDRnblRoTWVhdkRTcDN1YmZXeWRH?= =?utf-8?B?bFZpQ1FIc3pLY0pmR0Zhb2FCTDgrYmpubWdHOXRpS0ZJZE5SZ01Ma1BNU1M1?= =?utf-8?B?S1FqamZ6dnFhL0s3TmUydTVCZ3dHMGNmcFRNM3dFVmxkSlpCQ3RySXYydWNK?= =?utf-8?B?emNEY3pvSFVSWGVIS2xZdmdNM3lYUmFRNFNsaCsyalZob1JTdU80RlZnZXdm?= =?utf-8?B?SlhmMUFmcWFEeUJ5eVdMRWovTHREOWhDMi9yOWJzNDNzTzdyL3JENjdUZGJp?= =?utf-8?B?UXpXNDhyQzF0b2FuYjRQSXZhcUxVbzBzRzUyQzM2U1grK003N0R1RkhZbzVF?= =?utf-8?B?TFJRTlowL1lhYVV0b3RjRjdNTW1EQWgwdG95NXM0czVBYTZUamZteGZuSDlv?= =?utf-8?B?emZMRWdsYVRiR20yZ0RKQzNadVY5QjE3Ly9ja1AwcmQ2N0JYMzl4aUVxemVC?= =?utf-8?B?RXhzdXJuSHhvZjVjeVdndE1DM1p6VFdkRnUrNFRXL3dMZVNhZWI1V1ZJblpH?= =?utf-8?Q?RdKIftJrv6UiYXeGqzFoOq/bZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52a9c03a-2764-46db-3e4d-08da634a27fe X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 14:32:17.7455 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fb9ZB32t/onUT1T/OHVmMF7OXV/FocU3q0dDLbxQTXUczXj0EBOrA1g4ytumAz4O0DZVlYYfkwQm8mubxVRd5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8658 Hello, the other day I wanted to look at the basic structure of xen.efi. First I used my own dumping tool, which didn't work. Then I used objdump, which appeared to work. I decided that I should look into what they do different, and whether I could make mine work as well, or whether instead objdump is broken and shouldn't work on this sort of binary. While I'm not fully certain yet, I'm leaning to the latter. This is supported by GNU objcopy corrupting the binary (I assume this is known and considered okay-ish). Many problems boil down to the (ab)use of the DOS executable header fields, yielding an invalid header. The first 8 bytes are instructions, with the first carefully chosen to produce 'MZ' in its low half. (Oddly enough Xen and Linux use different insns there.) This doesn't play well with the meaning of the respective fields in the DOS header. Subsequently there are a number of .quad-s, some of which again yield an invalid DOS header. I'm therefore inclined to submit a patch to make objdump properly fail on this binary. But of course with both Xen and Linux (and who knows who else) using this hairy approach, it may end up necessary to continue to "support" this special case, which is why I'm seeking your input here first. Furthermore the fake .reloc section overlaps the file header. The section is zero size (i.e. empty), but a reasonable PE loader might still object to its RVA being zero. As to objcopy: It shrinks the binary significantly in size, removes the dummy .reloc section, re-writes fair parts of the DOS header, and extends the NT header resulting in the file position of .text changing. The size reduction and possibly the movement of .text may be okay as long as the resulting binary is to only be used with UEFI (as it's due to zapping of the embedded DTB and the unnecessary zero- filling of .bss, afaict), but my understanding is that the other adjustments are all fatal to the usability of the binary even on UEFI. I may easily have forgotten further anomalies. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 15:00:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 15:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365221.595330 (Exim 4.92) (envelope-from ) id 1oAuth-00031y-R1; Mon, 11 Jul 2022 15:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365221.595330; Mon, 11 Jul 2022 15:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAuth-00031r-ON; Mon, 11 Jul 2022 15:00:29 +0000 Received: by outflank-mailman (input) for mailman id 365221; Mon, 11 Jul 2022 15:00:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAutg-00031l-QO for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 15:00:29 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31c0c22d-012a-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 17:00:25 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 25E052290A; Mon, 11 Jul 2022 15:00:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0822513322; Mon, 11 Jul 2022 15:00:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qfxlAAk7zGJ8VwAAMHmgww (envelope-from ); Mon, 11 Jul 2022 15:00:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31c0c22d-012a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657551625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=d0Z1JkHrguLco+8+ty/we+2irNYLKfPVb+Y5yghHYsc=; b=sMVURUtimO1dxdr7T1PHvRykBnKGm+qKXctBtyfmWiPbX66+sKaoLSSnlawHMdgL3VfoyB op97TEoHm+md7UzATRv6T6M+U8dnnW7mqQ+135k6anJI0B4ETxckciwgv3+KLisGSIW20W 2Olf2BfdfFO5Dd7Q7z8BHms1PqMV1As= Message-ID: <58b2eece-ecb3-76b4-ffa3-f58c571af308@suse.com> Date: Mon, 11 Jul 2022 17:00:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom Content-Language: en-US To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu References: <20220624092806.27700-1-jgross@suse.com> <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rCUIbmLcLfCR2XjE0Jv7iHRg" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rCUIbmLcLfCR2XjE0Jv7iHRg Content-Type: multipart/mixed; boundary="------------8KNVHbP50tb5XEVIKxg1b48K"; protected-headers="v1" From: Juergen Gross To: Anthony PERARD Cc: xen-devel@lists.xenproject.org, Wei Liu Message-ID: <58b2eece-ecb3-76b4-ffa3-f58c571af308@suse.com> Subject: Re: [PATCH] tools/init-xenstore-domain: fix memory map for PVH stubdom References: <20220624092806.27700-1-jgross@suse.com> <165f61ae-3eae-d595-308a-d60e76cbe130@suse.com> In-Reply-To: --------------8KNVHbP50tb5XEVIKxg1b48K Content-Type: multipart/mixed; boundary="------------1VkUtf5eBA0T6yKdW50nsMhn" --------------1VkUtf5eBA0T6yKdW50nsMhn Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTY6MjYsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPiBPbiBUaHUsIEp1 bCAwNywgMjAyMiBhdCAwNTowMTozOFBNICswMjAwLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K Pj4gT24gMDcuMDcuMjIgMTY6NDUsIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4+IE9uIEZy aSwgSnVuIDI0LCAyMDIyIGF0IDExOjI4OjA2QU0gKzAyMDAsIEp1ZXJnZW4gR3Jvc3Mgd3Jv dGU6DQo+Pj4+IEluIGNhc2Ugb2YgbWF4bWVtICE9IG1lbXNpemUgdGhlIEU4MjAgbWFwIG9m IHRoZSBQVkggc3R1YmRvbSBpcyB3cm9uZywNCj4+Pj4gYXMgaXQgaXMgbWlzc2luZyB0aGUg UkFNIGFib3ZlIG1lbXNpemUuDQo+Pj4+DQo+Pj4+IEFkZGl0aW9uYWxseSB0aGUgTU1JTyBh cmVhIHNob3VsZCBvbmx5IGNvdmVyIHRoZSBIVk0gc3BlY2lhbCBwYWdlcy4NCj4+Pj4NCj4+ Pj4gU2lnbmVkLW9mZi1ieTogSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1c2UuY29tPg0KPj4+ PiAtLS0NCj4+Pj4gICAgdG9vbHMvaGVscGVycy9pbml0LXhlbnN0b3JlLWRvbWFpbi5jIHwg MTYgKysrKysrKysrKy0tLS0tLQ0KPj4+PiAgICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkNCj4+Pj4NCj4+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xz L2hlbHBlcnMvaW5pdC14ZW5zdG9yZS1kb21haW4uYyBiL3Rvb2xzL2hlbHBlcnMvaW5pdC14 ZW5zdG9yZS1kb21haW4uYw0KPj4+PiBpbmRleCBiNGYzYzY1YThhLi5kYWQ4ZTQzYzQyIDEw MDY0NA0KPj4+PiAtLS0gYS90b29scy9oZWxwZXJzL2luaXQteGVuc3RvcmUtZG9tYWluLmMN Cj4+Pj4gKysrIGIvdG9vbHMvaGVscGVycy9pbml0LXhlbnN0b3JlLWRvbWFpbi5jDQo+Pj4+ IEBAIC0xNTcsMjEgKzE1OCwyNCBAQCBzdGF0aWMgaW50IGJ1aWxkKHhjX2ludGVyZmFjZSAq eGNoKQ0KPj4+PiAgICAgICAgICAgIGNvbmZpZy5mbGFncyB8PSBYRU5fRE9NQ1RMX0NERl9o dm0gfCBYRU5fRE9NQ1RMX0NERl9oYXA7DQo+Pj4+ICAgICAgICAgICAgY29uZmlnLmFyY2gu ZW11bGF0aW9uX2ZsYWdzID0gWEVOX1g4Nl9FTVVfTEFQSUM7DQo+Pj4+ICAgICAgICAgICAg ZG9tLT50YXJnZXRfcGFnZXMgPSBtZW1fc2l6ZSA+PiBYQ19QQUdFX1NISUZUOw0KPj4+PiAt ICAgICAgICBkb20tPm1taW9fc2l6ZSA9IEdCKDQpIC0gTEFQSUNfQkFTRV9BRERSRVNTOw0K Pj4+PiArICAgICAgICBkb20tPm1taW9fc2l6ZSA9IFg4Nl9IVk1fTlJfU1BFQ0lBTF9QQUdF UyA8PCBYQ19QQUdFX1NISUZUOw0KPj4+PiAgICAgICAgICAgIGRvbS0+bG93bWVtX2VuZCA9 IChtZW1fc2l6ZSA+IExBUElDX0JBU0VfQUREUkVTUykgPw0KPj4+PiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIExBUElDX0JBU0VfQUREUkVTUyA6IG1lbV9zaXplOw0KPj4+PiAg ICAgICAgICAgIGRvbS0+aGlnaG1lbV9lbmQgPSAobWVtX3NpemUgPiBMQVBJQ19CQVNFX0FE RFJFU1MpID8NCj4+Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgR0IoNCkgKyBt ZW1fc2l6ZSAtIExBUElDX0JBU0VfQUREUkVTUyA6IDA7DQo+Pj4+IC0gICAgICAgIGRvbS0+ bW1pb19zdGFydCA9IExBUElDX0JBU0VfQUREUkVTUzsNCj4+Pj4gKyAgICAgICAgZG9tLT5t bWlvX3N0YXJ0ID0gKFg4Nl9IVk1fRU5EX1NQRUNJQUxfUkVHSU9OIC0NCj4+Pj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgIFg4Nl9IVk1fTlJfU1BFQ0lBTF9QQUdFUykgPDwgWENf UEFHRV9TSElGVDsNCj4+Pj4gICAgICAgICAgICBkb20tPm1heF92Y3B1cyA9IDE7DQo+Pj4+ ICAgICAgICAgICAgZTgyMFswXS5hZGRyID0gMDsNCj4+Pj4gLSAgICAgICAgZTgyMFswXS5z aXplID0gZG9tLT5sb3dtZW1fZW5kOw0KPj4+PiArICAgICAgICBlODIwWzBdLnNpemUgPSAo bWF4X3NpemUgPiBMQVBJQ19CQVNFX0FERFJFU1MpID8NCj4+Pj4gKyAgICAgICAgICAgICAg ICAgICAgICAgTEFQSUNfQkFTRV9BRERSRVNTIDogbWF4X3NpemU7DQo+Pj4+ICAgICAgICAg ICAgZTgyMFswXS50eXBlID0gRTgyMF9SQU07DQo+Pj4+IC0gICAgICAgIGU4MjBbMV0uYWRk ciA9IExBUElDX0JBU0VfQUREUkVTUzsNCj4+Pj4gKyAgICAgICAgZTgyMFsxXS5hZGRyID0g ZG9tLT5tbWlvX3N0YXJ0Ow0KPj4+DQo+Pj4NCj4+PiBTbywgaXQgaXNuJ3QgZXhwZWN0ZWQg dG8gaGF2ZSBhbiBlbnRyeSBjb3ZlcmluZyB0aGUgTEFQSUMgYWRkcmVzc2VzLA0KPj4+IHJp Z2h0PyBJIGd1ZXNzIG5vdCBhcyBzZWVuIGluIGRmMWNhMWRmZTIwLg0KPj4+DQo+Pj4gQnV0 IGJhc2VkIG9uIHRoYXQgc2FtZSBjb21taXQgaW5mbywgc2hvdWxkbid0IHRoZSBMQVBJQyBh ZGRyZXNzIHBhcnQgb2YNCj4+PiBgZG9tLT5tbWlvX3N0YXJ0LCBkb20tPm1taW9fc2l6ZWA/ IChJIGRvbid0IGtub3cgaG93IGRvbS0+bW1pb19zdGFydCBpcw0KPj4+IHVzZWQsIHlldCwg YnV0IG1heWJlIGl0J3MgdXNlZCBieSBYZW4gb3IgeGVuIGxpYnJhcmllcyB0byBhdm9pZA0K Pj4+IGFsbG9jYXRpb25zIGluIHRoZSB3cm9uZyBwbGFjZXMpDQo+Pg0KPj4gSW4gbXkgdW5k ZXJzdGFuZGluZyB0aGlzIGlzIHRoZSBwdXJwb3NlIG9mIGxvd21lbV9lbmQuDQo+IA0KPiBJ dCBsb29rcyBsaWtlIGRvbS0+bW1pb19zdGFydCBpcyB1c2VkIGluIGxpYnhlbmd1ZXN0Lm1l bWluaXRfaHZtKCkgdG8NCj4gY2hlY2sgaWYgYSBzdXBlciBwYWdlIGNhbiBiZSBhbGxvY2F0 ZWQsIGJ1dCBsb3dtZW1fZW5kIHdvdWxkIHByb2JhYmx5DQo+IHByZXZlbnQgdGhlIGNoZWNr IGZyb20gYmVlbiBkb25lIGluIHRoZSBmaXJzdCBwbGFjZS4gU28gSSBndWVzcw0KPiBtbWlv X3N0YXJ0IHZhbHVlIGRvZXNuJ3QgbWF0dGVyIGluIHRoaXMgY2FzZS4NCj4gDQo+IFRoZXJl IGlzIGFub3RoZXIgdXNlIG9mIG1taW9fc3RhcnQsIGl0J3MgaW4gbW9kdWxlX2luaXRfb25l KCksIHdoaWNoIEkNCj4gdGhpbmsgaXMgdXNlZCB0byBibG9icyB0byB0aGUgZ3Vlc3QgbGlr ZSB0aGUgZmlybXdhcmUgb3IgdGhlIGFjcGkNCj4gdGFibGVzLiBJdCdzIGFuIG90aGVyIGNo ZWNrIHRvIGJlIHN1cmUgdGhlIG5ldyAibW9kdWxlIiBkb2Vzbid0IG92ZXJsYXANCj4gd2l0 aCB0aGUgbW1pbyByZWdpb24uIFNvIGJhc2VkIG9uIHRoYXQsIEkga2luZCBvZiB0aGluayB0 aGF0IG1taW9fc3RhcnQNCj4gc2hvdWxkIGluY2x1ZGUgdGhlIExBUElDLiBCdXQgb24gdGhl IG90aGVyIGVuZCwgSSBkb24ndCB0aGluaw0KPiAiaW5pdC14ZW5zdG9yZS1kb21haW4iIGhh dmUgYW55ICJtb2R1bGUiLCBzbyBhZ2FpbiwgdGhlIHZhbHVlIG9mDQo+IG1taW9fc3RhcnQg cHJvYmFibHkgZG9lc24ndCBtYXR0ZXIgYXQgdGhpcyBwb2ludC4NCj4gDQo+IEJ1dCBtYXli ZSB3ZSBzaG91bGQga2VlcCBMQVBJQyBpbiBbbW1pb19zdGFydCxtbWlvX3NpemVdIGp1c3Qg aW4gY2FzZSBpdA0KPiBtYXR0ZXIgbGF0ZXIuDQoNCk9rYXksIHdpbGwgc2VuZCBhbiB1cGRh dGVkIHBhdGNoIHZlcnNpb24uDQoNCg0KSnVlcmdlbg0K --------------1VkUtf5eBA0T6yKdW50nsMhn Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------1VkUtf5eBA0T6yKdW50nsMhn-- --------------8KNVHbP50tb5XEVIKxg1b48K-- --------------rCUIbmLcLfCR2XjE0Jv7iHRg Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLMOwgFAwAAAAAACgkQsN6d1ii/Ey/L pQf/fJo8NIT8iwpEakRnHmDW9Shi7PH64FqQGhu3Yd3RlOA4vBr1xeA7UadMDgtqawzmpUQZy1pL 656KXMbfF54PUD1mmHbs3ygCxQQMoZiByx4xJj/0lO7lxOcJ1LKgV1uSOd5zN0yDCLVgpCaC4xsa m5RsqvizoYPMi3gnNJJI+u6mBeuF89jdHkG9KhnhynAOlUTBJ8F703bPBjp9+bJ0avbLO+cuh06B d3hU0cEpbNCcuFSVJZcUHya8Cm/3zowny1v8tmREbPqUq6W/vfAKzOdWMeMUIhDg5wHTTuPigXp+ JMj1O8N1uqXLAwpznW9nnAZ67GL/DZEBJJR2CGgr6g== =CYpf -----END PGP SIGNATURE----- --------------rCUIbmLcLfCR2XjE0Jv7iHRg-- From xen-devel-bounces@lists.xenproject.org Mon Jul 11 15:23:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 15:23:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365242.595349 (Exim 4.92) (envelope-from ) id 1oAvFk-0005ke-Q1; Mon, 11 Jul 2022 15:23:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365242.595349; Mon, 11 Jul 2022 15:23:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvFk-0005kX-Mw; Mon, 11 Jul 2022 15:23:16 +0000 Received: by outflank-mailman (input) for mailman id 365242; Mon, 11 Jul 2022 15:23:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvFj-0005kR-SE for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 15:23:15 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60327879-012d-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 17:23:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60327879-012d-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657552993; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=pZGb0cAgf2x8v4lEYbVef+sU13jY0Ld25ol2N9KqxBE=; b=NZAJZNUIVnlBL0eM4G6EEf/3099Gesy05W9UCTmsuNJII/1I3UbgY/yk E9UAZA+/rC6b3TY3c+7HvFtBqPT4tIaLM2T9du1+Zs99NaxYWZXhLlmE7 rAurOk4hcsol2d/ZocVb88PG4h14pOHnpw+T5Dax9+lTh2PjlUqI4wL56 4=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75346842 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qL/hcak6oBccjp5pBgR02zvo5gzmIURdPkR7XQ2eYbSJt1+Wr1Gzt xJNCzrUMvqCMDH1KYh2YYqx/U4EsZXczN9iTARrryw1HyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8kk/vgqoPUUIYoAAgoLeNfYHpn2EgLd9IR2NYy24DmWlrV4 7senuWEULOb828sWo4rw/rrRCNH5JwebxtB4zTSzdgS1LPvvyF94KA3fMldHFOhKmVgJcaoR v6r8V2M1jixEyHBqD+Suu2TnkUiGtY+NOUV45Zcc/DKbhNq/kTe3kunXRa1hIg+ZzihxrhMJ NtxWZOYQg0xMaeSiPYmXxRKTAEiBKkew5HbGC3q2SCT5xWun3rExvxvCAc9PJEC+/YxCmZLn RAaAGlTNFbZ3bvwme/lDLk37iggBJCD0Ic3mHhmwHf8BPIvRZnFTo3B5MNC3Sd2jcdLdRrbT 5VEMmYxPEiaC/FJEg8VOb4Mw9uvv0DidiFpuUCn5o1w4kGGmWSd15CyaYGIK7RmX/59m0aVt 2TL1238CwMdMpqTxFKt9XahhfTGmy/hb54DD72z9vNsg1q7y3QaDVsdUl7TieKilke0VtZbK koV0ikjt64/8AqsVNaVdx+3unmfpTYHRsFdVeY97Wml2qfSpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWeTnac8PGXrDW9ESkTMWIGIyQDSGMt4dPuvYUyhRLnVct4Hei+ididMSGgn RiJoTI4irFVitQEv42n8lTXqzatoIXVVAkz5xWRUm/Nxgl+fo++IYuz9ULc8+1DPa6eVFCKu HVCkM+bhMgKDJeQhGmOTf8LEbWB+fmIKnvfjERpEp1n8C6ik1amfIZf5xlkKUtpO9pCcjjsC GfToQp59o5PO2HsZqhyC6q9Atoni6jpE8/oUNjQb9xTct5wchOK+GdlYkv492r1uEEokKw5a dGXfK6R4W0yUPo9imDsHqFEjOFtlntWKX7vqY7TxB6/3rDAdGyuRboXb3vSV+Rh142YmVCAm zpADPdm2ymzQcWnPHSIqtZJcAlTRZQoLcuo8pIKL4ZvNiIjQTh8UKGJnNvNbqQ/x8xoevH0E mZRs6Oy4H72njX5JAqDcRiPg5u/DM8k/RrX0cHBVGtEOkTPgq71tc/zj7NtIdEaGBVLlJaYt cUtdcSaGehoQT/a4TkbZpSVhNU8KUv32lLXYHb0OmRXk3tcq+vho4WMQ+cS3HNWUnrfWTUW+ dVMKT83sbJcHl8/Xa46mdqkzk+rvGh1pd+eq3Dge4EJEG21qdACA3Wo0pcffpBXQT2el2Ty6 upjKUpBzQU7i9RtoIehaGHth9rBLtaS6WIATjOEtufmb3OAlodhqKcZONu1kfnmfDuc0M2fi S99lJkQ7NVvcI52jrdB IronPort-HdrOrdr: A9a23:MJzeIaq7dYPlArvywvnORXsaV5oneYIsimQD101hICG8cqSj+f xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ uIHZIQNDSJNykZsfrH X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="75346842" From: Jane Malalane To: LKML CC: Jane Malalane , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , "Jan Beulich" , Colin Ian King , Subject: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Date: Mon, 11 Jul 2022 16:22:30 +0100 Message-ID: <20220711152230.17749-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Implement support for the HVMOP_set_evtchn_upcall_vector hypercall in order to set the per-vCPU event channel vector callback on Linux and use it in preference of HVM_PARAM_CALLBACK_IRQ. If the per-VCPU vector setup is successful on BSP, use this method for the APs. If not, fallback to the global vector-type callback. Also register callback_irq at per-vCPU event channel setup to trick toolstack to think the domain is enlightened. Suggested-by: "Roger Pau Monné" Signed-off-by: Jane Malalane --- CC: Juergen Gross CC: Boris Ostrovsky CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: x86@kernel.org CC: "H. Peter Anvin" CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: Jane Malalane CC: Maximilian Heyne CC: Jan Beulich CC: Colin Ian King CC: xen-devel@lists.xenproject.org --- arch/x86/include/asm/xen/cpuid.h | 2 ++ arch/x86/include/asm/xen/events.h | 1 + arch/x86/xen/enlighten_hvm.c | 19 +++++++++++++++++-- arch/x86/xen/suspend_hvm.c | 20 +++++++++++++++++++- drivers/xen/events/events_base.c | 32 ++++++++++++++++++++++++++++---- include/xen/interface/hvm/hvm_op.h | 15 +++++++++++++++ 6 files changed, 82 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 78e667a31d6c..6daa9b0c8d11 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -107,6 +107,8 @@ * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* Per-vCPU event channel upcalls */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) diff --git a/arch/x86/include/asm/xen/events.h b/arch/x86/include/asm/xen/events.h index 068d9b067c83..b2d86c761bf8 100644 --- a/arch/x86/include/asm/xen/events.h +++ b/arch/x86/include/asm/xen/events.h @@ -34,4 +34,5 @@ static inline bool xen_support_evtchn_rebind(void) return (!xen_hvm_domain() || xen_have_vector_callback); } +extern bool xen_ack_upcall; #endif /* _ASM_X86_XEN_EVENTS_H */ diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 8b71b1dd7639..847d1da46ff7 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -7,6 +7,7 @@ #include #include +#include #include #include @@ -30,6 +31,9 @@ static unsigned long shared_info_pfn; +__ro_after_init bool xen_ack_upcall; +EXPORT_SYMBOL_GPL(xen_ack_upcall); + void xen_hvm_init_shared_info(void) { struct xen_add_to_physmap xatp; @@ -125,6 +129,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) { struct pt_regs *old_regs = set_irq_regs(regs); + if (xen_ack_upcall) + ack_APIC_irq(); + inc_irq_stat(irq_hv_callback_count); xen_hvm_evtchn_do_upcall(); @@ -168,6 +175,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) if (!xen_have_vector_callback) return 0; + if (xen_ack_upcall) { + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, cpu), + }; + + BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op)); + } + if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); @@ -211,8 +227,7 @@ static void __init xen_hvm_guest_init(void) xen_panic_handler_init(); - if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) - xen_have_vector_callback = 1; + xen_have_vector_callback = !no_vector_callback; xen_hvm_smp_init(); WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c index 9d548b0c772f..be66e027ef28 100644 --- a/arch/x86/xen/suspend_hvm.c +++ b/arch/x86/xen/suspend_hvm.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "xen-ops.h" @@ -14,6 +15,23 @@ void xen_hvm_post_suspend(int suspend_cancelled) xen_hvm_init_shared_info(); xen_vcpu_restore(); } - xen_setup_callback_vector(); + if (xen_ack_upcall) { + unsigned int cpu; + + for_each_online_cpu(cpu) { + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, cpu), + }; + + BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, + &op)); + /* Trick toolstack to think we are enlightened. */ + if (!cpu) + BUG_ON(xen_set_callback_via(1)); + } + } else { + xen_setup_callback_vector(); + } xen_unplug_emulated_devices(); } diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 46d9295d9a6e..a2420b66e735 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -48,6 +48,7 @@ #include #endif #include +#include #include #include #include @@ -2200,6 +2201,29 @@ void xen_setup_callback_vector(void) } } +/* Setup per-vCPU vector-type callbacks and trick toolstack to think + * we are enlightened. If this setup is unavailable, fallback to the + * global vector-type callback. */ +static __init void xen_setup_upcall_vector(void) +{ + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, 0), + }; + + if (!xen_have_vector_callback) + return; + + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && + !HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op) && + !xen_set_callback_via(1)) + xen_ack_upcall = true; + else if (xen_feature(XENFEAT_hvm_callback_vector)) + xen_setup_callback_vector(); + else + xen_have_vector_callback = 0; +} + static __init void xen_alloc_callback_vector(void) { if (!xen_have_vector_callback) @@ -2210,6 +2234,7 @@ static __init void xen_alloc_callback_vector(void) } #else void xen_setup_callback_vector(void) {} +static inline void xen_setup_upcall_vector(void) {} static inline void xen_alloc_callback_vector(void) {} #endif @@ -2271,10 +2296,9 @@ void __init xen_init_IRQ(void) if (xen_initial_domain()) pci_xen_initial_domain(); } - if (xen_feature(XENFEAT_hvm_callback_vector)) { - xen_setup_callback_vector(); - xen_alloc_callback_vector(); - } + xen_setup_upcall_vector(); + xen_alloc_callback_vector(); + if (xen_hvm_domain()) { native_init_IRQ(); diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h index f3097e79bb03..e714d8b6ef89 100644 --- a/include/xen/interface/hvm/hvm_op.h +++ b/include/xen/interface/hvm/hvm_op.h @@ -46,4 +46,19 @@ struct xen_hvm_get_mem_type { }; DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type); +/* + * HVMOP_set_evtchn_upcall_vector: Set a that should be used for event + * channel upcalls on the specified . If set, + * this vector will be used in preference to the + * domain global callback via (see + * HVM_PARAM_CALLBACK_IRQ). + */ +#define HVMOP_set_evtchn_upcall_vector 23 +struct xen_hvm_evtchn_upcall_vector { + uint32_t vcpu; + uint8_t vector; +}; +typedef struct xen_hvm_evtchn_upcall_vector xen_hvm_evtchn_upcall_vector_t; +DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_evtchn_upcall_vector_t); + #endif /* __XEN_PUBLIC_HVM_HVM_OP_H__ */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 11 15:29:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 15:29:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365250.595360 (Exim 4.92) (envelope-from ) id 1oAvLO-0006VS-EC; Mon, 11 Jul 2022 15:29:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365250.595360; Mon, 11 Jul 2022 15:29:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvLO-0006VL-B0; Mon, 11 Jul 2022 15:29:06 +0000 Received: by outflank-mailman (input) for mailman id 365250; Mon, 11 Jul 2022 15:29:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvLM-0006VD-VM for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 15:29:05 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31bf6f44-012e-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 17:29:03 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id fd6so6705697edb.5 for ; Mon, 11 Jul 2022 08:29:03 -0700 (PDT) Received: from [192.168.1.8] (adsl-142.37.6.26.tellas.gr. [37.6.26.142]) by smtp.googlemail.com with ESMTPSA id l17-20020a1709063d3100b0072b1c21ce65sm2756516ejf.150.2022.07.11.08.29.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Jul 2022 08:29:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31bf6f44-012e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Fz3JaKBVLQvZvuwmbq+mibOy8m/9O2czJ4UY+vpkuVQ=; b=A0wNy6oUAPjtVwtjN6iSjyg3EMPnyRD4bTeIsSdQwG0k7kfyDm0O41qsRtN16gO8Va yQ2OIHORlLLItGb9dQLH4tuKtEawjK57tAGvG1VC7FxPS3NDdydr7yMgPayPkV9S7cl+ zL6jotM95XkxtgRIdUSiJFrPViyS+n0Qk5gjqkIMGiQlv7/u3onWVJFQhe6nPlzViS9B NIELcOfNR43hqygr8KnIVMpLeLXuXgqdS8ijMO+5tsOO4F8R+/gx9oClNXYvs1xsHRPM 9GOQ7wQRcGvLBvN4x32WZj3JicHNfOX3FDwWHj9J36+xOCV3EaRJwBG+DifmJPhQ1IbO O6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Fz3JaKBVLQvZvuwmbq+mibOy8m/9O2czJ4UY+vpkuVQ=; b=cztVnwZecBKSE5DiM5xLIEYNDi0dJYKACx4BkYKMYYHpHOQSvNd+MWKrAXRq1YvC83 ALJwu69GbmK0m1G4pDtOTc02F5NNp6FJgrmvq3I+wF+LNf35d2nCVvJn3lVaGWge5h2s EYBqW0LNDPq2RF0yy05i/rcIkRqRHqeuHig6irdZ2HWiqdDNO0jre3+hBswvtxjuTcRx /v9VdEN4f66TTtVONsSMYvu9H6/K6LeTxPf/80eOFB9ajJyQ5afWBTmuYEuZfHljnVVB XTvMgc2+oDPMr+88hG+3OwSRKJbDYsODMiLg4V17AZT1KRZkhlEXpnxHhoxSWaimJCTg F1zg== X-Gm-Message-State: AJIora/V7239tgRUys87q3V/jcoZVyYFB01ihCc7TkDDl2jhM5Uy8vTD 3rRIJZ5CaTTaCCbL39yttoUw4Lw2piM= X-Google-Smtp-Source: AGRyM1tDajnJ2RFUeYzMoF4MjKl3CKf8B9j0UQx4/ndxKMPZmcsqZMBlhhizzopjhlyHneZj/mHS3w== X-Received: by 2002:aa7:c2d3:0:b0:43a:707a:72c5 with SMTP id m19-20020aa7c2d3000000b0043a707a72c5mr25684152edp.54.1657553342942; Mon, 11 Jul 2022 08:29:02 -0700 (PDT) Message-ID: <69c1e0e4-f83d-527b-050b-d0760562b3b3@gmail.com> Date: Mon, 11 Jul 2022 18:29:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Content-Language: en-US To: Penny Zheng , Stefano Stabellini , Julien Grall Cc: "xen-devel@lists.xenproject.org" , Doug Goldstein References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 11/7/22 12:02, Penny Zheng wrote: > Hi Xenia > >> -----Original Message----- >> From: Xen-devel On Behalf Of >> Xenia Ragiadakou >> Sent: Friday, July 8, 2022 5:54 PM >> To: Stefano Stabellini ; Julien Grall >> Cc: xen-devel@lists.xenproject.org; Doug Goldstein >> Subject: Re: [PATCH 2/2] automation: arm64: Create a test job for testing >> static allocation on qemu >> >> Hi Stefano, >> >> On 7/8/22 02:05, Stefano Stabellini wrote: >>> On Thu, 7 Jul 2022, Julien Grall wrote: >>>> Hi Xenia, >>>> >>>> On 07/07/2022 21:38, Xenia Ragiadakou wrote: >>>>> Add an arm subdirectory under automation/configs for the arm >>>>> specific configs and add a config that enables static allocation. >>>>> >>>>> Modify the build script to search for configs also in this >>>>> subdirectory and to keep the generated xen binary, suffixed with the >>>>> config file name, as artifact. >>>>> >>>>> Create a test job that >>>>> - boots xen on qemu with a single direct mapped dom0less guest >>>>> configured with statically allocated memory > > Although you said booting a single direct mapped dom0less guest > configured with statically allocated memory here, later in code, you are > only enabling statically allocated memory in the ImageBuilder script, > missing the direct-map property. > >>>>> - verifies that the memory ranges reported in the guest's logs are >>>>> the same with the provided static memory regions >>>>> >>>>> For guest kernel, use the 5.9.9 kernel from the tests-artifacts containers. >>>>> Use busybox-static package, to create the guest ramdisk. >>>>> To generate the u-boot script, use ImageBuilder. >>>>> Use the qemu from the tests-artifacts containers. >>>>> >>>>> Signed-off-by: Xenia Ragiadakou >>>>> --- >>>>> automation/configs/arm/static_mem | 3 + >>>>> automation/gitlab-ci/test.yaml | 24 +++++ >>>>> automation/scripts/build | 4 + >>>>> automation/scripts/qemu-staticmem-arm64.sh | 114 >> +++++++++++++++++++++ >>>>> 4 files changed, 145 insertions(+) >>>>> create mode 100644 automation/configs/arm/static_mem >>>>> create mode 100755 automation/scripts/qemu-staticmem-arm64.sh >>>>> >>>>> diff --git a/automation/configs/arm/static_mem >>>>> b/automation/configs/arm/static_mem >>>>> new file mode 100644 >>>>> index 0000000000..84675ddf4e >>>>> --- /dev/null >>>>> +++ b/automation/configs/arm/static_mem >>>>> @@ -0,0 +1,3 @@ >>>>> +CONFIG_EXPERT=y >>>>> +CONFIG_UNSUPPORTED=y >>>>> +CONFIG_STATIC_MEMORY=y >>>>> \ No newline at end of file >>>> >>>> Any particular reason to build a new Xen rather enable >>>> CONFIG_STATIC_MEMORY in the existing build? >>>> >>>>> diff --git a/automation/scripts/build b/automation/scripts/build >>>>> index 21b3bc57c8..9c6196d9bd 100755 >>>>> --- a/automation/scripts/build >>>>> +++ b/automation/scripts/build >>>>> @@ -83,6 +83,7 @@ fi >>>>> # Build all the configs we care about >>>>> case ${XEN_TARGET_ARCH} in >>>>> x86_64) arch=x86 ;; >>>>> + arm64) arch=arm ;; >>>>> *) exit 0 ;; >>>>> esac >>>>> @@ -93,4 +94,7 @@ for cfg in `ls ${cfg_dir}`; do >>>>> rm -f xen/.config >>>>> make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig >>>>> make -j$(nproc) -C xen >>>>> + if [[ ${arch} == "arm" ]]; then >>>>> + cp xen/xen binaries/xen-${cfg} >>>>> + fi >>>> >>>> This feels a bit of a hack to be arm only. Can you explain why this >>>> is not enabled for x86 (other than this is not yet used)? >>>> >>>>> done >>>>> diff --git a/automation/scripts/qemu-staticmem-arm64.sh >>>>> b/automation/scripts/qemu-staticmem-arm64.sh >>>>> new file mode 100755 >>>>> index 0000000000..5b89a151aa >>>>> --- /dev/null >>>>> +++ b/automation/scripts/qemu-staticmem-arm64.sh >>>>> @@ -0,0 +1,114 @@ >>>>> +#!/bin/bash >>>>> + >>>>> +base=(0x50000000 0x100000000) >>>>> +size=(0x10000000 0x10000000) >>>> >>>> From the name, it is not clear what the base and size refers too. >>>> Looking a bit below, it seems to be referring to the domain memory. >>>> If so, I would suggest to comment and rename to "domu_{base, size}". >>>> >>>>> + >>>>> +set -ex >>>>> + >>>>> +apt-get -qy update >>>>> +apt-get -qy install --no-install-recommends u-boot-qemu \ >>>>> + u-boot-tools \ >>>>> + device-tree-compiler \ >>>>> + cpio \ >>>>> + curl \ >>>>> + busybox-static >>>>> + >>>>> +# DomU Busybox >>>>> +cd binaries >>>>> +mkdir -p initrd >>>>> +mkdir -p initrd/bin >>>>> +mkdir -p initrd/sbin >>>>> +mkdir -p initrd/etc >>>>> +mkdir -p initrd/dev >>>>> +mkdir -p initrd/proc >>>>> +mkdir -p initrd/sys >>>>> +mkdir -p initrd/lib >>>>> +mkdir -p initrd/var >>>>> +mkdir -p initrd/mnt >>>>> +cp /bin/busybox initrd/bin/busybox >>>>> +initrd/bin/busybox --install initrd/bin echo "#!/bin/sh >>>>> + >>>>> +mount -t proc proc /proc >>>>> +mount -t sysfs sysfs /sys >>>>> +mount -t devtmpfs devtmpfs /dev >>>>> +/bin/sh" > initrd/init >>>>> +chmod +x initrd/init >>>>> +cd initrd >>>>> +find . | cpio --create --format='newc' | gzip > ../initrd.cpio.gz >>>>> +cd ../.. >>>>> + >>>>> +# XXX QEMU looks for "efi-virtio.rom" even if it is unneeded curl >>>>> +-fsSLO >>>>> +https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom >>>>> + >>>>> +./binaries/qemu-system-aarch64 -nographic \ >>>>> + -M virtualization=true \ >>>>> + -M virt \ >>>>> + -M virt,gic-version=2 \ >>>>> + -cpu cortex-a57 \ >>>>> + -smp 2 \ >>>>> + -m 8G \ >>>>> + -M dumpdtb=binaries/virt-gicv2.dtb >>>>> + >>>>> +#dtc -I dtb -O dts binaries/virt-gicv2.dtb > >>>>> +binaries/virt-gicv2.dts >>>>> + >>>>> +# ImageBuilder >>>>> +rm -rf imagebuilder >>>>> +git clone https://gitlab.com/ViryaOS/imagebuilder >>>>> + >>>>> +echo "MEMORY_START=\"0x40000000\" >>>>> +MEMORY_END=\"0x0200000000\" >>>>> + >>>>> +DEVICE_TREE=\"virt-gicv2.dtb\" >>>>> + >>>>> +XEN=\"xen-static_mem\" >>>>> +XEN_CMD=\"console=dtuart earlyprintk xsm=dummy\" >>>> >>>> AFAIK, earlyprintk is not an option for Xen on Arm (at least). It is >>>> also not clear why you need to pass xsm=dummy. >>>> >>>>> + >>>>> +NUM_DOMUS=1 >>>>> +DOMU_MEM[0]=512 >>>>> +DOMU_VCPUS[0]=1 >>>>> +DOMU_KERNEL[0]=\"Image\" >>>>> +DOMU_RAMDISK[0]=\"initrd.cpio.gz\" >>>>> +DOMU_CMD[0]=\"earlyprintk console=ttyAMA0\" >>>>> +DOMU_STATIC_MEM[0]=\"${base[0]} ${size[0]} ${base[1]} ${size[1]}\" >>>>> + > > You would like to add DOMU_DIRECT_MAP[0] = 1 to enable direct-map. The imagebuilder configuration option DOMU_DIRECT_MAP defaults to 1. But I could add DOMU_DIRECT_MAP[0]=1 in the script to make it clearer. >>>>> +UBOOT_SOURCE=\"boot.source\" >>>>> +UBOOT_SCRIPT=\"boot.scr\"" > binaries/imagebuilder_config >>>>> + >>>>> +bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c >>>>> binaries/imagebuilder_config >>>>> + >>>>> +# Run the test >>>>> +rm -f qemu-staticmem.serial >>>>> +set +e >>>>> +echo " virtio scan; dhcp; tftpb 0x40000000 boot.scr; source >>>>> +0x40000000"| \ timeout -k 1 60 ./binaries/qemu-system-aarch64 - >> nographic \ >>>>> + -M virtualization=true \ >>>>> + -M virt \ >>>>> + -M virt,gic-version=2 \ >>>>> + -cpu cortex-a57 \ >>>>> + -smp 2 \ >>>>> + -m 8G \ >>>>> + -no-reboot \ >>>>> + -device virtio-net-pci,netdev=vnet0 -netdev >>>>> +user,id=vnet0,tftp=binaries >>>>> \ >>>>> + -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin \ >>>>> + -dtb ./binaries/virt-gicv2.dtb \ >>>>> + |& tee qemu-staticmem.serial >>>>> + >>>>> +set -e >>>> >>>> A lot of the code above is duplicated from qemu-smoke-arm64.sh. I >>>> think it would be better to consolidate in a single script. Looking >>>> briefly throught the existing scripts, it looks like it is possible >>>> to pass arguments (see qemu-smoke-x86-64.sh). >>> >>> One idea would be to make the script common and "source" a second >>> script or config file with just the ImageBuilder configuration because >>> it looks like it is the only thing different. >>> >>> >>>>> + >>>>> +(grep -q "Xen dom0less mode detected" qemu-staticmem.serial) || >>>>> +exit 1 >>>>> + >>>>> +for ((i=0; i<${#base[@]}; i++)) >>>>> +do >>>>> + start="$(printf "0x%016x" ${base[$i]})" >>>>> + end="$(printf "0x%016x" $((${base[$i]} + ${size[$i]} - 1)))" >>>>> + grep -q "node 0: \[mem ${start}-${end}\]" qemu-staticmem.serial >>>>> + if test $? -eq 1 >>>>> + then >>>>> + exit 1 >>>>> + fi >>>>> +done >>>> >>>> Please add a comment on top to explain what this is meant to do. >>>> However, I think we should avoid relying on output that we have >>>> written ourself. IOW, relying on Xen/Linux to always write the same >>>> message is risky because they can change at any time. >>> >>> Especially if we make the script common, then we could just rely on >>> the existing check to see if the guest started correctly (no special >>> check for static memory). >> >> In this case, how the test will verify that the static memory configuration has >> been taken into account and has not just been ignored? >> > > If only statically allocated memory is enabled, guest memory address will still be mapped > to GUEST_RAM_BASE(0x40000000) > >>>>> + >>>>> +(grep -q "BusyBox" qemu-staticmem.serial) || exit 1 >>> >> >> -- >> Xenia > > --- > Cheers, > Penny Zheng > > > > From xen-devel-bounces@lists.xenproject.org Mon Jul 11 15:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 15:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365256.595370 (Exim 4.92) (envelope-from ) id 1oAvSD-00080C-5f; Mon, 11 Jul 2022 15:36:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365256.595370; Mon, 11 Jul 2022 15:36:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvSD-000805-2p; Mon, 11 Jul 2022 15:36:09 +0000 Received: by outflank-mailman (input) for mailman id 365256; Mon, 11 Jul 2022 15:36:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvSB-0007zx-7m for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 15:36:07 +0000 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d9dd9c4-012f-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 17:36:06 +0200 (CEST) Received: by mail-ed1-f51.google.com with SMTP id fd6so6731983edb.5 for ; Mon, 11 Jul 2022 08:36:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d9dd9c4-012f-11ed-924f-1f966e50362f X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jm527PWGKrFyLtMs1rIk0OXlRvMiCuSZcQb4xJE6qXc=; b=Vpm8MaCD5r16iKvWOa1vIaQpARNyf7MLE+JaOGVltw22G5ZrH/aydCgHIT9Yst6z6i GqBT7hA5vuAS2HoEwqTK1W6oWh4JXrPsGeXLZUxfrlCHo2kPu008/msawoujWNTLHr+A ZBLennmZfqsYQTONyEc8942xFPjVCOvHsm17ixZIJQ2Lx01ZrLPEX5yTV3fsuHLMVAiO UP3AVbXLnvDXY4CKXqpeqRhPTdEtuzHkOoG1wXEoKQFqS2UIHfXH1jtuBPjK0mK3beUL L+1lKTG4S1mAV8L95ZsUd+HAT9oq4oXNbR+3CqGAHAaN2iQLlC4QpdUurHOw3kWOC7u/ Fc/Q== X-Gm-Message-State: AJIora9SdNki3Uh/UZW6H5o6RMv5ZGBkrVfs3pB7SqWHMZkCVvxFfrl2 6fl1LU9Qd4mgIkRHoNGCGMBI905fV1vJSiIvvXA= X-Google-Smtp-Source: AGRyM1vQgo4AKLh0jeJiN9pSgDVPwuQD7wnhTSDPFEHLMrkL04nkUAEyNSN7LccUu9dkurwFm1Y5kRiIk1RjpHzQF2k= X-Received: by 2002:a05:6402:11d1:b0:43a:8c33:f549 with SMTP id j17-20020a05640211d100b0043a8c33f549mr25800419edw.354.1657553765546; Mon, 11 Jul 2022 08:36:05 -0700 (PDT) MIME-Version: 1.0 References: <20220711103847.21276-1-anthony.perard@citrix.com> <490ef2d3-98e3-42f9-84e9-cf2122b14472@suse.com> In-Reply-To: <490ef2d3-98e3-42f9-84e9-cf2122b14472@suse.com> From: "G.R." Date: Mon, 11 Jul 2022 23:35:53 +0800 Message-ID: Subject: Re: [XEN PATCH] libxl: Check return value of libxl__xs_directory in name2bdf To: Juergen Gross Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Wei Liu Content-Type: text/plain; charset="UTF-8" On Mon, Jul 11, 2022 at 7:03 PM Juergen Gross wrote: > > On 11.07.22 12:38, Anthony PERARD wrote: > > libxl__xs_directory() can potentially return NULL without setting `n`. > > As `n` isn't initialised, we need to check libxl__xs_directory() > > return value before checking `n`. Otherwise, `n` might be non-zero > > with `bdfs` NULL which would lead to a segv. > > > > Reported-by: "G.R." > > Fixes: 57bff091f4 ("libxl: add 'name' field to 'libxl_device_pci' in the IDL...") > > Signed-off-by: Anthony PERARD > > Reviewed-by: Juergen Gross Hi Anthony, I can confirm that the change fixed the segment fault issue I observed on 4.16.1 release. However, the behavior is still not entirely clean after the fix. But that's probably a separate issue. I have two devices assigned to pckback through kernel command-line. When I attempted to use pci-assignable-remove on the SSD that caused me a lot of trouble, it fails on the first attempt but works fine later... root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 root@gaia:~# xl pci-assignable-remove 05:00.0 libxl: error: libxl_pci.c:906:libxl__device_pci_assignable_remove: failed to de-quarantine 0000:05:00.0 root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 root@gaia:~# xl pci-assignable-add 05:00.0 libxl: warning: libxl_pci.c:802:libxl__device_pci_assignable_add: 0000:05:00.0 already assigned to pciback root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 root@gaia:~# xl pci-assignable-remove 05:00.0 root@gaia:~# xl pci-assignable-list 0000:00:17.0 root@gaia:~# xl pci-assignable-add 05:00.0 libxl: warning: libxl_pci.c:822:libxl__device_pci_assignable_add: 0000:05:00.0 not bound to a driver, will not be rebound. root@gaia:~# xl pci-assignable-list 0000:00:17.0 0000:05:00.0 I'm no longer in a debug environment, so cannot collect more debug info right now. Thanks, G.R. From xen-devel-bounces@lists.xenproject.org Mon Jul 11 15:44:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 15:44:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365266.595382 (Exim 4.92) (envelope-from ) id 1oAvaF-00018S-0P; Mon, 11 Jul 2022 15:44:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365266.595382; Mon, 11 Jul 2022 15:44:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvaE-00018L-TV; Mon, 11 Jul 2022 15:44:26 +0000 Received: by outflank-mailman (input) for mailman id 365266; Mon, 11 Jul 2022 15:44:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvaD-00018F-Gx for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 15:44:25 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 566e40f1-0130-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 17:44:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8100.eurprd04.prod.outlook.com (2603:10a6:20b:3e3::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 15:44:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 15:44:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 566e40f1-0130-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cDg2RFjTn5CapAmR5LdY/oYORaO1gbs3118uGW9iwR/Zf8hDY2gpxfVvWIVUluEX35kWnwrb6nP4nHJDopA/ma/VsHugBNDR7g/59pZzAirkBt6Z1KULkbIijPeTUUC2cgacsIyC+f5iv5BapLiWW5u0gMPf7ebNAuKtw8v3MOxB2vAafBg2bamV4FmtCIbdFbG6OetO055WwD2q8mtpfJJxJ7ll9oab5n+4jE55RBx6e+PH9zGuQlanzzZRZTJGuUvBgoUeCf7ur3R2Xz3rPY7YZYfNrSJWzzyIY2HTT618QxMnVhdVqfvMFs+v6JNwjHR21P0yDDedgWhGNd5/Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QM+CLaN+xAkrTVHpV+K7R3DHHG8+aOMrHq0gIAWw6+Y=; b=mX15mLTwyf4x8l5OvfH/DRRBBdbln+xvgzDNQfUIWEHGqzNHwiXb9HZvzbJ02G+Bh52k1ihWzYC87TrUnuFsdCfbz3lDH5WPWh7G43ULZzc5lU84BuelJL2GCvpMRdokTU1mO66vkL9dP8YtY0iW0CD9LUpUpyL7U5RCFud03Ka8sZKCRnacEzjbSUz1s53fLrbooiULQ0OvDcWbKg+GmK2QWx5NKdNh1waMz0BJyUxOMWV7u9H4b/1oqlyL1Ns3sp3P3SsfEy7WdJ9dzCEIYLl/JkBwA7zdBZt/nGlQE5Xt9r73287tTT4KkJTfsKIdDMYkL4GJHxEsTew34NM/xA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QM+CLaN+xAkrTVHpV+K7R3DHHG8+aOMrHq0gIAWw6+Y=; b=QvuIbAum1VGAraPJtHIc02TNl4ktxE2C5oelJ0sdKgbSiX3Ao+YSclrSjzIe6fYkCuQtoXgxyXFSc8nUsJVsLhKCyO5b0yng3n27xElKcKDgstvInnMqUvkqcfaoE7Xs557p7UMXoq2XAz5/Tg/qkkyM/84tj6BF9hFclFFJzvOWyQpj1DOfFFgbexwgCyoTWN3zbI17++6yALG/FvDXiJtp6POZ/oEEPisP7J/157FcIpX+pSmMqlYljrchdTtKFs3gLbKMINPmanIu1UFvhKra+a8u+XgmqBQHyZ6pFcdG3lM612YWaTPx7JIk5uwlRS5AtOrlrycG9RVk1G7xRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 11 Jul 2022 17:44:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH] libxl: Check return value of libxl__xs_directory in name2bdf Content-Language: en-US To: "G.R." Cc: Anthony PERARD , xen-devel@lists.xenproject.org, Wei Liu , Juergen Gross References: <20220711103847.21276-1-anthony.perard@citrix.com> <490ef2d3-98e3-42f9-84e9-cf2122b14472@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0100.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1659802-9c3a-4db9-0916-08da6354392e X-MS-TrafficTypeDiagnostic: AM9PR04MB8100:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8oVGrHhJQ4QwjU2SI8fA4vm3XRadIw780+4uoeDyOn+Kj549pfDCxkBp3Vgm/1A6t+o+GCJmVIZ7KvEYHwYA/OmGbWzYwxqwqhAjUGslhrJnsdTaAkNVJJhuqwUJ2FEGleBGRydIB5m+0I3Mk4fp5k4STE8MWRhHzKJalEU00Iyb3ZHtjTaEebChaO5LM1wNirYYxZlim3Jx4XyEWYePRzaBlgC9cK9HnZWfJ4ZprDOx0vfNc2L7q/pgfeN6aS1r0rRoQPL+xmEwse+MQUtd26iP21mLXrvzelmn8S9tJf3vfjZihsAQWm4mVagJdH3TiYuI0rsIDBfLYXvFzb9G4Rz3/DZL2C/vvORUAxmkX877PrG4pyYexgeVEXuLbep1e2we3LARs7/lBjcP90j9hE+BD5o1N8DNcBLXuR6pXQ9m2KyQVOeVwvH2ewjM31KN2eQ/yky7v5NcOP8npoqN+n+nsYF9v/J3g6YXRQdn7PT3amME4dPH0pjiDKYCJNj1IeiK+5pN5aYxoqv26b3qWAgCo67nkqBAv2ZT9c+UMdjEC0GYnV6k4x8TVbs0QYqwgOKYE79l4mqa3eDwgoaBdxhCYs9+Hy2TM8JvsXokBD+SSRsRonNBO6jH7eJozq/1CNjyK/BUFbENoV7gWLRjtSGWK+lPgmXPjM/bz5FBGSgjGVMND0NPeE2483BItwEmPFh9M1vwRbRn3AujVVCtACgvGS2ZzRbh66RmUTVMmX3sS7zwFGwmdvntATUZy5kPTykW7KNcfhhDm/v2s3aJE636k8R5NiHTMK739Z+HC51exM6QP4DiMs7M6KgcZDMdUKyUOwXkeZKatgFx+bYLdmWKF4M2WhvnvQ8fFmclc/gzKuVzzrDG4Ot6dWk6qQAX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(136003)(396003)(346002)(39860400002)(186003)(107886003)(83380400001)(38100700002)(66946007)(66476007)(2616005)(66556008)(478600001)(6916009)(54906003)(316002)(53546011)(26005)(2906002)(6486002)(6512007)(4744005)(6506007)(36756003)(8936002)(31696002)(5660300002)(31686004)(4326008)(86362001)(41300700001)(8676002)(101420200003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2o2VXdBNFRaKy90TzlwV2gza0pUL0FHVlRTLytaS0hWenFCMXZWYXVyakdy?= =?utf-8?B?UHJGbnpla0pXR2UwcXdjYXhKY2FTektrTllKNUJwd212bythK281blJ4N1Nk?= =?utf-8?B?TmtaQVlKKzFGbXU3cDFVV1JSY0h1UlpFZjN1Y3piV3E5S3hRUUIrbytvNjFv?= =?utf-8?B?UTNkRnQ5MlhvdGlMTm1vOU1PK04wTnZnMWFud2FKa1Y4cEQ0RkRmT3hiZHNw?= =?utf-8?B?ZEErWS9MWURXa1Z4OTB2OXpzeC9MRW04UUhoZUVMZU5RZkhibVg5cy9VL0Zz?= =?utf-8?B?Sk55dDcrMC9CcllTckI2cjV5VVZQQUlwcWV1RXpyMTUyVlBCWHhqQmwyN1lD?= =?utf-8?B?Mjh5aFZkcDdpYnVVYUtSNTF0aEd4Rm9lS0JwdlV4RTUzMU9YRG9LaXBYanVC?= =?utf-8?B?TEg4MFNWWTNuYjhHU25PK2c4a0FwTjl6Q3VrM2xjeXNJV3dWVjlaanR0alps?= =?utf-8?B?N002VVhtQ09EMXIzVnM1UmhiTGtIa2p6eHM5NThKTkJWUldEWCtuWXhSZFk1?= =?utf-8?B?eSt1ZTZYS1cyOFNPalVydDFoUnEza2l3cHU1NjA4VU1qRytJdDAveTUxdWZj?= =?utf-8?B?UHlQUzllY1dJQ3pzSVJZQXd0cGV1WjB6T3NkNGluQ01KTis5VERpa3RJaDRi?= =?utf-8?B?NDQ0dkZES3RDcXpsVjB1Q2J5SVRoaDJ4UWxYZXh0eDBYUnlwanBJenNucjFa?= =?utf-8?B?amROT2Nudm1WVDRyblFyejZpa2RsZ1RZVElBMkdjb09UakwvY1JhdE9FRUt1?= =?utf-8?B?RHpyeEVZU3M1NjRpM3JhNFoyTTlGMHViWWlCbWZ3RXp0REordExpbHVDQ2l6?= =?utf-8?B?OUowUnZJNE01Z2JuYUlkcUZ0UlRvSGZLcHIxMGZteWx5bXFqSWIyaTVBK01w?= =?utf-8?B?WXJ0aDhaMkZQK3h2cm9TQnJZMjV0T1hQaGphNENUNjRVcUxwMWpqNWxnb0Ir?= =?utf-8?B?SUJySUloczZJS2dFQnNJZ2RZOTF6bTYyY2JYakdJckliRDE4bXhlWHlESU5G?= =?utf-8?B?a29ySEFoRlhVdlFIZnlDbTQweS9PZjVwckprMXFDaTNVOXBBOERkK0IzcXEy?= =?utf-8?B?eDNwbjVBaVluK1ZJN1A1QmpOOVlpTEFkcTdtaGdkWHQzWGRYSVk2QldkTGlH?= =?utf-8?B?Qk1OTEZEd0VpbzFFNlFxUk9RZHlDM1p0LzAzUjZsS3BQcXF1dGhScEJQVXBP?= =?utf-8?B?Wjdsbi9ac291cTB0N2J6aThtNzFSMFZsdGkwcGx4M2E4TUpBVDB5Q1NNTE1L?= =?utf-8?B?VnlSRTZKOWU1bmcyQWtsNndaMGFvbUtOODEyemFLN29iZnZob0hYb0tuT0FP?= =?utf-8?B?ZnVNZVNYSjcvVGEwMzU5dHJFa0dPQW1VZ2ZsZGx5eGg2QWU3TTFoRUFycldE?= =?utf-8?B?LzNFc2lhZE45dkRRYVZSa0tmQWlZaFZCeWg5L1pkaUtyOGNRVXNwTGhZd1RF?= =?utf-8?B?QlNZNEJtN2xzWnlEYUk2d2UzVjdOVTIwQnB6OXo1bWhnT1BTSlpIejZZbWhn?= =?utf-8?B?NTJtZlJJcExuSXp4eUpiU1FBVnM2U0dlVzR4dnBZRmNkc0dQREszVHdwLzU3?= =?utf-8?B?RHRTWWdDbWN0VkhRNlFTRnFsejEwdGtCTEtMT082TnR1OHRxWFJuS1BDNkY5?= =?utf-8?B?NDZlU1pZS1NsSXI3UGFmUjVxOXZnT0x5OW9HZTgvMVFOR3BnZHRHdFp3eUJs?= =?utf-8?B?STdkdDM0SDhqeDBwdzJvTlo4dllpcEFjdVpmRUhJZnRhRlZYY0hRVmhJV0R6?= =?utf-8?B?eURwejZOanM4U2tiRm1vQk1TMXhscjJmWEQ3dEtGWEhaTDd2SVdlMWtUeUpB?= =?utf-8?B?cGhiV3RJMk0vVzZPZFBMaE94cVNVR29PTVRyYS9qZlNBeFAyNzN5ZStVQVk1?= =?utf-8?B?SFlkQldNME9WTXluQTBPWG1zeU40TnFidzZBUjdYNU9HTElydTd4bWxvQUxy?= =?utf-8?B?MWZzSHFXSmFGcTFjOFB5cU5PR0oxMDRwdWZJWHAzYzJmalYzUEgrOHhJMUpu?= =?utf-8?B?dEFURXhRdEZyeVdBRGRoOHF5TVI2czM0QkoweFp0dGY3RmJpUUJWdlVKRUxD?= =?utf-8?B?RUEzNDhRK3pwT0IyeG5PTVhudTFPa2RDRDdBdWxqelRiT1VyUG42SGY4SUM5?= =?utf-8?Q?eAUPiI0QZpjXRuB8V6piRY/AP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a1659802-9c3a-4db9-0916-08da6354392e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 15:44:21.5629 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vaQh1mVy/m4Da/tlKSYTZnZJllriF/IFZYkpz2t9p/W4WtejEamh6Th+yj5pigeVYg3zn1bZcI/7qoxcZEauJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8100 On 11.07.2022 17:35, G.R. wrote: > On Mon, Jul 11, 2022 at 7:03 PM Juergen Gross wrote: >> >> On 11.07.22 12:38, Anthony PERARD wrote: >>> libxl__xs_directory() can potentially return NULL without setting `n`. >>> As `n` isn't initialised, we need to check libxl__xs_directory() >>> return value before checking `n`. Otherwise, `n` might be non-zero >>> with `bdfs` NULL which would lead to a segv. >>> >>> Reported-by: "G.R." >>> Fixes: 57bff091f4 ("libxl: add 'name' field to 'libxl_device_pci' in the IDL...") >>> Signed-off-by: Anthony PERARD >> >> Reviewed-by: Juergen Gross > > I can confirm that the change fixed the segment fault issue I observed > on 4.16.1 release. I'll take the liberty and transform this into a Tested-by:. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 11 16:06:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 16:06:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365281.595397 (Exim 4.92) (envelope-from ) id 1oAvur-0004Ld-R3; Mon, 11 Jul 2022 16:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365281.595397; Mon, 11 Jul 2022 16:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvur-0004LW-Nu; Mon, 11 Jul 2022 16:05:45 +0000 Received: by outflank-mailman (input) for mailman id 365281; Mon, 11 Jul 2022 16:05:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvuq-0004Jt-5m for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 16:05:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4eb9d2cc-0133-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 18:05:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6075.eurprd04.prod.outlook.com (2603:10a6:10:c4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Mon, 11 Jul 2022 16:05:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 16:05:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eb9d2cc-0133-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bAAiIl+H7j1q1RrlEQjZqOKo+5bISIuJH7vQQRkTTyYeSizDT8C+vi8Ri5oBknFkUiVMrIdWajPmqK4U4LAsFIyt+WjxELubE3bb3iiLgawT98zguKw52eSMBlYRUSpAnuGNcOM7UAXDOrUOLMCUfdlGFWmpW9zw+olJlp0xtncAEm2bSVFc28pPNkafF742q1qlW9VfFTZQTqabX8w/ckVhmmi9XSi/L/sujChVSdYaf8kXz7qTbkgbwOsTCnHbu6Let2p1HJ4wjUwcuf6HVmzJIhdbQ1G8VYJveJXjUF53ij9XDCQSDsvZDKPt0XyXYNCipOggB9fQH3UCOwjzrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NZJhi/0JPagQhzQIH3E3WVG24pojUvNPKRJ4yJJhDuk=; b=YBYpM8WKHV87TRKIkUM0d+gjFbw9L4VDbnF2WQYNMlUkl+Scd2Ipby4HIXuJ7huydcbktK4DG2WmqJ43k1etr/k3yV3M/XbRxfZfIy5v1YNJ4GFlOPp5GE89iK8Gxp4GdE1VXOKPUOOvZl7upZzOKw3uXckcXxoIAQvuR3S1pfVqkdGA+8a/AYy9QI986psmg1/Kdr5H43ubnTuYpQ9/58PcoowgctRv4G+yePTFl1VsJCr/A9O9F7JImd82QSOw6etJLIpsyzNViszXlkdMdtZ+84dTkYXSeeWGot+TRSTj4qp4vRhPtrMX1y+x/eENu9aFl1Mm0sJR1iHNX4jcZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NZJhi/0JPagQhzQIH3E3WVG24pojUvNPKRJ4yJJhDuk=; b=0tJzclq24JGhQWaZwM4H1xvZQ/IeXrWBkbjrqSjBIILSoHfDNc1RJa+A4unp0yL2Cy5jDyGJWz17RRDcgdPqgcdY7ncMwvtc+F26GxjeM41iea6WlV8W7hl8f0bBT/6xlCsa1hP441MeR3wiusHKg7UcdmH21H082BZws8Bs/Bs9lFGnpT+nE1OEIefuHw8iakUOOV8InLUJBjUrAUCq9xwK7vJXW9Mclz4nZcuGVfmoNXenwH+WSLTSjdvBuWFXlvmr08UAwUBCBIyWhmD5dcYKUzfX6AA8XFpakT3Fn+LFdrcVcNzt6O+5AAdf/xGVmLoT3I5ELIrUBOgnIvgVMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0a2da2ea-bc8e-05be-2c4a-5f9b0841f0d3@suse.com> Date: Mon, 11 Jul 2022 18:05:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: [PATCH v2] EFI: strip xen.efi when putting it on the EFI partition To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0125.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30f634fd-6504-4ed2-4d8c-08da635732a5 X-MS-TrafficTypeDiagnostic: DBBPR04MB6075:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kl+D2EWBFobHriHWwaSAnrRRBowpSNBu3S0/o0xH3c1XhtDlBjocuEps3qwWRDbYeKDtBDc6PI0P+AKb3AjQCrGhEpmTjeGWKhKp40yDfwuF9Nx+aEyiBFz0zkZST6o91JTIzFTAfPwyiGnwa/Irsz+y/Uc52XaUCX3rIuESllUDGrRPZK4H39+S22mJ8lL1SPShNdno5whEq34wo3mz/yIP22+skPvKaMJTohfBtYZkZPieckNl5bj1KmLfqtCSOJb6ZhGieE7gbDfGUtiJ6Scd8xeCo8aUrL2mY3Khg4lUtUknk3W4qXuq6lHZ9BDRtfQnG3wi49c7ZfPEun0fC+GS36VN8b2PN5/QkGA2ysi98xP4gzOUFBkTt0RUbSYAPIjtRDO1XOxKgVwzvtVzTBC5i4RMBi8FPqy1fwKLaD6lw/CGOg4mM4xA3eNsIfiZCNLnhDvtJxKAlS7NNIwWI8ojg0CVOs5CSqyq+bxBH6KfGRilc3Nyoy4P0tIO4dtcu07XroxSp3tCBmJImUfwrPr/BTpYUCJQWLIUoKA5ZQYkSMXM1f6izLelfJLB7uHf2TmwFnJOq4kna5XlcDNjnpEwq0m1BXD9EHQoMt28IeVm79FRxhsPe6Ch+YLSwT3BcnxKj5eRqT58LB0q9K2S3yRJMNTAAfAliuty0vcQu3js/ad2GKfKOfIY2AlEXCRTmJMVHmZWjWqjkiafiOOM2FreGrn7SJ66CGYaIP4JmZW0WhtO2w4kNMiwQx708PS0I9QvgrDuXqhW7ExuHxfpcAXbDuntGBC763fd5LYhmxlq/GGnuofS7LpeK/iOz1mTyHjyhwLGxo+EdS0ZQ5PtUDXEqcgakGs+7GoMq/bGpE0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(346002)(136003)(366004)(376002)(2906002)(6486002)(478600001)(186003)(83380400001)(31686004)(36756003)(5660300002)(31696002)(316002)(8676002)(86362001)(66946007)(8936002)(66476007)(4326008)(54906003)(66556008)(6916009)(41300700001)(38100700002)(6506007)(6512007)(26005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WC8zMVV6REFpdWRDd3J0UXp3dWdkVzlxQXNYY1Z3QlNWMW1OQW9vc1pzTUFu?= =?utf-8?B?TTlrZmtPUWVqcy8zT0RmSlJFeXNXV3kwcDFsU3dJV1hMb0ptYTREU3JpUkI0?= =?utf-8?B?U0pkcjJMYTVaTG1RYW16K0xvNDIxWmY4UXQzVmdjZ1BJbUZ1N0pEVTJCMUlR?= =?utf-8?B?aWM0Z0c0OG9ITkU0KzllS1NRSWw1Tmc0aktQdHRMMkVzTnoyRUMwYUo0bFNp?= =?utf-8?B?Ry83VTl5UTBkTUpldTQ0cGlTUjl6Z1FLWUFwY2pHNklWTGJ3WVFXdlpDOGI2?= =?utf-8?B?R0dVdzZBWTlGbFZtWEZsWVAwcFJjVFNieXI5Q0lCVEg2RDBGcDJRUDE3SGlF?= =?utf-8?B?dS83UnNzcEdESU95NUliaTdjT2Fnb3NUcmx6Vkx5WGlYV016WVBOZDQ0RGZD?= =?utf-8?B?aE11SFhodkRDWmxVU2IxTjBKNHducWpQU3JZVi9MTmlGSlY0UGhndVJEQi9x?= =?utf-8?B?Z1Y2NXhrcHFxV3Bhcllib0Zic1MyRGJIczVJUzE0UGhsaTV3eGFuc2tIMTBR?= =?utf-8?B?S0hZMnBQVmlvdUdXaUZXZ2FVd0ZKdTJySU5EN2pWenJnNWRSUlgyWW8wZDVB?= =?utf-8?B?OHI2b0xDZTNEWXZzLzQ1TzE4YStMekcxUjA2UytYZThEeElwblhBaXBoeVhn?= =?utf-8?B?VmJKa2FtQ1ZZR0NzMSszdi9nTEZVNDBCS2lQRHMzK1VoUXBqV0RyV3Y5a3dK?= =?utf-8?B?R0dRWldIMGFySjJaalFrOGlSbzNnNjkwb3JrSVQ1anBLTEFLWVhuMzJ0NGQw?= =?utf-8?B?K2VReEJ5MEZ6REMxK0dmV2xZWi91TmZhdlhVUklSMXdYRFNzSTYwano4ajdm?= =?utf-8?B?ejRwUzJXaEpERGlsVUlRUGhBUTZTVnFHR2NIOFBQOHdYVXFHSTR5anJyM29P?= =?utf-8?B?NzNUK2o0WVNtTW1uSzcwRXdiZ1BTQzBPMi9LSXFmeWxFMDEzMlBBYnlxWk1V?= =?utf-8?B?WGIrZU1EeXY1aUw4dHoxZC96bEFzVWlyTHNUVjRiNy9XZnJZSWZmNVg3SzdH?= =?utf-8?B?bnlKT3RtOHVRdThwWTh4TFJXUklrZTEyNzcwV1NDMTRhN0JyVlRUaldFTHhN?= =?utf-8?B?V2dhNkxvZ0YzZnNXWDNuTmJsbDVha0dETVhRQjFTT3ZuQU1ldVluSW9CTjB4?= =?utf-8?B?cSt2Tk11OVZpVjM0YVFLN3pVb3lmZXlvZEk2RTBnVGNLNXN2WStIb2gva1ov?= =?utf-8?B?bVlObDBKelBOVXNrdER5a3FyZlltVjg0cERSa2VqLytMZGorMk5WTmVFWU1i?= =?utf-8?B?TVVyZGxNLzNuMDczUFMvRTA5KzB4eEwva2VXNytiV0tTbjhxZkgySUQyTHFp?= =?utf-8?B?Um5nUTBVb1VaSWZaUFcwT29rZkJSekFiQTJoR1Z0Y0NIK2hFS2w1YTZqUGJL?= =?utf-8?B?T0xVbmZQN2t4VU5rR3ZYTm5aWUJPajkxM0VDRGEvUU9BLzI4eWZTVUN4dHA1?= =?utf-8?B?RUlidDlOeGFwWXhvMUIvSTd2Tk9vbmFnMzNveWRPWmJLMlNRbDFGWE5Hd2JJ?= =?utf-8?B?Z2dGQ0cxU1Q3TXBNam44YnVxODFmS1JMRmlla1Q1ZjhiYlMrMWZ3RTYycGZ5?= =?utf-8?B?eStmQiswQTAzNVlWdnRPanhRcEQwbjhLVmlwUU9wVm1mQWRDakNZWWNKUjJj?= =?utf-8?B?eS8yd0dPa1pjZFZQVzdoYU9FK0txR0NJUmRndlhzK2Q2Z29ITEJxQ3R3bFZs?= =?utf-8?B?VlhSdkZrbS9ubUNrQnFXdnlBeTBtRkZkQXNZa3g2WjJvY2E4ZTA2b0RzUWJo?= =?utf-8?B?N0ZrMDdBTkx6K2dreWU3ZFdCSFhmdi8wbEk3OUt0SlVXa1pCM0VVbElmajNM?= =?utf-8?B?ODdMb1pHMjBFUVUzdDBzQWdFaWc1cUI4THI2SU1BMG8reVk4d2ZVZ1NydGl4?= =?utf-8?B?T3cwK1RlcG0xQy9PNDdJb2t4UUl2ZWYrRG5IOHhzZFppK3R4aEdraWltZnpV?= =?utf-8?B?MFdDam5VWjM2elNRTnBPNy94ZmdLWVdrK2lMS0oycTFzT1JBdWJSZ0VOVlRk?= =?utf-8?B?MGpCMTlkRFEyeThzcDhYSUxwTUVwVW1taGcwVmVtWXFpcHBsL2ZCbm9talRl?= =?utf-8?B?amw1Yzh4c2pFZXB4a1ZyZkZ2SElNb0tOUnNqZ3UweXU0WWNVak9vV1h1WlB3?= =?utf-8?Q?iXCvxFi4c8a3jOWzVeNC1rLH+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30f634fd-6504-4ed2-4d8c-08da635732a5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 16:05:39.0751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9IsJ3MbOnIzKwA4IEB6YeB8kYtIDD2GaCuOZQsB/XIR+QKLPq2P7X4EFockPozIJkr44oXluvAKLonzubLC0AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6075 With debug info retained, xen.efi can be quite large. Unlike for xen.gz there's no intermediate step (mkelf32 there) involved which would strip debug info kind of as a side effect. While the installing of xen.efi on the EFI partition is an optional step (intended to be a courtesy to the developer), adjust it also for the purpose of documenting what distros would be expected to do during boot loader configuration (which is what would normally put xen.efi into the EFI partition). Model the control over stripping after Linux'es module installation, except that the stripped executable is constructed in the build area instead of in the destination location. This is to conserve on space used there - EFI partitions tend to be only a few hundred Mb in size. Signed-off-by: Jan Beulich Tested-by: Henry Wang Tested-by: Wei Chen # arm --- GNU strip 2.38 appears to have issues when acting on a PE binary: - file name symbols are also stripped; while there is a separate --keep-file-symbols option (which I would have thought to be on by default anyway), its use so far makes no difference, - the string table grows in size, when one would expect it to retain its size (or shrink), - linker version is changed in and timestamp zapped from the header. Older GNU strip (observed with 2.35.1) doesn't work at all ("Data Directory size (1c) exceeds space left in section (8)"). Future GNU strip is going to honor --keep-file-symbols (and will also have the other issues fixed). --- v2: Remove stripped intermediate file during "make clean". Use --keep-file-symbols by default. Add doc. --- a/docs/misc/efi.pandoc +++ b/docs/misc/efi.pandoc @@ -20,9 +20,13 @@ Xen to load the configuration file even Once built, `make install-xen` will place the resulting binary directly into the EFI boot partition, provided `EFI_VENDOR` is set in the environment (and `EFI_MOUNTPOINT` is overridden as needed, should the default of `/boot/efi` not -match your system). The xen.efi binary will also be installed in -`/usr/lib64/efi/`, unless `EFI_DIR` is set in the environment to override this -default. +match your system). When built with debug info, the binary can be quite large. +Setting `INSTALL_EFI_STRIP=1` in the environment will cause it to be stripped +of debug info in the process of installing. `INSTALL_EFI_STRIP` can also be set +to any combination of options suitable to pass to `strip`, in case the default +ones don't do. The xen.efi binary will also be installed in `/usr/lib64/efi/`, +unless `EFI_DIR` is set in the environment to override this default. This +binary will not be stripped in the process. The binary itself will require a configuration file (names with the `.efi` extension of the binary's name replaced by `.cfg`, and - until an existing --- a/xen/Makefile +++ b/xen/Makefile @@ -464,6 +464,22 @@ endif .PHONY: _build _build: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX) +# Strip +# +# INSTALL_EFI_STRIP, if defined, will cause xen.efi to be stripped before it +# is installed. If INSTALL_EFI_STRIP is '1', then the default option(s) below +# will be used. Otherwise, INSTALL_EFI_STRIP value will be used as the +# option(s) to the strip command. +ifdef INSTALL_EFI_STRIP + +ifeq ($(INSTALL_EFI_STRIP),1) +efi-strip-opt := --strip-debug --keep-file-symbols +else +efi-strip-opt := $(INSTALL_EFI_STRIP) +endif + +endif + .PHONY: _install _install: D=$(DESTDIR) _install: T=$(notdir $(TARGET)) @@ -488,6 +504,9 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_ ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi; \ ln -sf $(T)-$(XEN_FULLVERSION).efi $(D)$(EFI_DIR)/$(T).efi; \ if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \ + $(if $(efi-strip-opt), \ + $(STRIP) $(efi-strip-opt) -p -o $(TARGET).efi.stripped $(TARGET).efi && \ + $(INSTALL_DATA) $(TARGET).efi.stripped $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi ||) \ $(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \ elif [ "$(D)" = "$(patsubst $(shell cd $(XEN_ROOT) && pwd)/%,%,$(D))" ]; then \ echo 'EFI installation only partially done (EFI_VENDOR not set)' >&2; \ @@ -544,7 +563,8 @@ _clean: -o -name ".*.o.tmp" -o -name "*~" -o -name "core" \ -o -name '*.lex.c' -o -name '*.tab.[ch]' -o -name '*.c.cppcheck' \ -o -name "*.gcno" -o -name ".*.cmd" -o -name "lib.a" \) -exec rm -f {} \; - rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET).efi $(TARGET).efi.map $(TARGET)-syms $(TARGET)-syms.map + rm -f include/asm $(TARGET) $(TARGET).gz $(TARGET)-syms $(TARGET)-syms.map + rm -f $(TARGET).efi $(TARGET).efi.map $(TARGET).efi.stripped rm -f asm-offsets.s arch/*/include/asm/asm-offsets.h rm -f .banner .allconfig.tmp include/xen/compile.h rm -f cppcheck-misra.* xen-cppcheck.xml From xen-devel-bounces@lists.xenproject.org Mon Jul 11 16:08:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 16:08:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365287.595408 (Exim 4.92) (envelope-from ) id 1oAvxm-000578-CV; Mon, 11 Jul 2022 16:08:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365287.595408; Mon, 11 Jul 2022 16:08:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvxm-000571-9U; Mon, 11 Jul 2022 16:08:46 +0000 Received: by outflank-mailman (input) for mailman id 365287; Mon, 11 Jul 2022 16:08:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAvxk-00056v-Nu for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 16:08:44 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bba62cec-0133-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 18:08:42 +0200 (CEST) Received: from AS9PR06CA0398.eurprd06.prod.outlook.com (2603:10a6:20b:461::17) by AM0PR08MB4098.eurprd08.prod.outlook.com (2603:10a6:208:12f::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Mon, 11 Jul 2022 16:08:40 +0000 Received: from AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::92) by AS9PR06CA0398.outlook.office365.com (2603:10a6:20b:461::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 16:08:40 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT018.mail.protection.outlook.com (10.152.16.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Mon, 11 Jul 2022 16:08:39 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Mon, 11 Jul 2022 16:08:39 +0000 Received: from 1fea33954d32.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9E108DE4-510B-4EAE-A927-24BB5D557F82.1; Mon, 11 Jul 2022 16:08:32 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1fea33954d32.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 11 Jul 2022 16:08:32 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM0PR08MB4962.eurprd08.prod.outlook.com (2603:10a6:208:15a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Mon, 11 Jul 2022 16:08:30 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5417.025; Mon, 11 Jul 2022 16:08:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bba62cec-0133-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=VlHGYKAJpib6ti0VaWExV4kr3wrt4lgB7Enc4P3PBi7qxk1CO7sM1jGiKoVoJpbGwLoar97Xq3R/QAEGuJMV+I8oBxegSC+/kKWrnDOoqEgS88SsO7Da0+B4Ws2VddK7Czyyg+JQsBxirwUNppYA4e6skpkMzFGm2zylKZz7dyetOUZ0cKQ03pg0fpQNmyBHkKT6tShlPg6Kv0tXESUqszzI5LNh/80PHestAew32N3yeIXg5q09lvOwwnbDC20Zx34MoIh8MrFc07bsx4iVOd2VXBbCxBT+gXDJgooG7KU3myTmvMK/v8JBRu1cKUseGoWS+VqoTTC39wtjYOrtiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzzUzxRym5wX6T3toMxMnQRrUl504ic1G+KMhuIVNTM=; b=QxPA9a+e4e1kZzoNdqusUgYD8Kg8kwMlSr1DXQjhzN0kRhXEfz2suWYtKubnT7Jn/7r4fhwDA9FwQJEBI3nDeOHM44HXMF6wW6cuAjBMFU5fiwPJFf2/H/NYODrNLtWutpcRZHuTN+VhshY8u/bUfoSTXqquKxzT+WszB5JGB0crJ+Lnvq2wUp8ToRfjmXpTBsbEPqh7JaRxyF+9/mjVz/MgZgUtty3AZt64qKKkmBR78pjYVgUP2bcDYPOzdIjH77HCa7o0/HBphWrqO41arFis6xNT6GQ891+VZDQbtj5mfRFOA6EpZIVjamdtka8KEUEq2RK9Rez5bqeg9Xr9cA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzzUzxRym5wX6T3toMxMnQRrUl504ic1G+KMhuIVNTM=; b=siarQlXbtLbnPFRqv+sWlAZCXZ3ogLGjJbogFRjAZvLnrnWZU7Sh94vlGq8aPeofPMJN5cdKn3giiGYiyIvR6sB3DLMllpMAOvdB30ch1cjjkleFslNtflXt8xEYHXZ5niCCCCqqkMZAhMzouUcElSTBRs8skcYyZ2dNdXDw738= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 152f774723ba7bf8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HtOGEMRQCzOS0PXfl9iyn9MJo6LJWBSsXAKLY0op1vmTalW+3C/2+TNvR0AmZQJuxOCvZu4Mp0Fb95rNhyalDSs+7EXfdcGGy4YiNEwhCFpo6/P6v3n+lcudAPxLboxU6vVY/7JU4XNG38zkjTJGkeI8VjCDkKvswHee44Qfo5JFytknQCAG+JPa6NEoyKvad8CEswTaRaacovb4aC5q89ccnjRDM8jYCw52IDPdD+ftcgC4KS0ZvLIEnU7eqBHm39cGFJvjX6s49CHLTx/9mwFka86Vfc6GVMeJ5Tfw6LgzCVYd5IfSgyMpSdKjUuRPtgAg4Z7m9EScsnjFEA8QgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kzzUzxRym5wX6T3toMxMnQRrUl504ic1G+KMhuIVNTM=; b=acR/QPViUO4yKg24s8LzM0Ss3zQvVbHunfn1f5jezNd8i2tlypBwsNbAvBR9IKiLxeZmOdhC2dbyucAlveGYd2dOM+++VzBfwk4mtYNYoxFMZNR9fTN2CvrDt9qq5W8GuvAvOWudEUbTfroHjxylUMR58xaX5C+5eGo6NaeyMld3qhGt3dL/WjfEZKAruMWsjWuSqUNaFRxYHVU1IHs3JJf96x7nC7J5oUy9kZvzCSuvIOpe/Dvzp/2c0CEnIPoirfN9n6TMb6kpzBSSPbfzxO6MNPEVX2rb4AlsfWU/v9iUaNzpzeqCTP0t+lciIeKMwGcMu0dXFTV3uUP1RhutBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kzzUzxRym5wX6T3toMxMnQRrUl504ic1G+KMhuIVNTM=; b=siarQlXbtLbnPFRqv+sWlAZCXZ3ogLGjJbogFRjAZvLnrnWZU7Sh94vlGq8aPeofPMJN5cdKn3giiGYiyIvR6sB3DLMllpMAOvdB30ch1cjjkleFslNtflXt8xEYHXZ5niCCCCqqkMZAhMzouUcElSTBRs8skcYyZ2dNdXDw738= From: Rahul Singh To: Julien Grall CC: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuAA= Date: Mon, 11 Jul 2022 16:08:30 +0000 Message-ID: <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> In-Reply-To: <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e57d70c2-7ec9-4666-0b11-08da63579e92 x-ms-traffictypediagnostic: AM0PR08MB4962:EE_|AM5EUR03FT018:EE_|AM0PR08MB4098:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ROIqf/uGonm426edlyxZxFkPWvi0DRszZ9Ka6lP0YpmLcAUuy9dOSUTwHrg3Xgm7xj9fJqvh1ly3iifdrlHsrr4taafwukFa/DigZ4zYbSMzlJ9ZWPdqQ2WrDoFg4xVjnbz4JlDsAjSnOmIQ38EG4PMwzYQdvCZPbfn317ukbXqapjQhIRWT5HiBqKvPChnButL0HDJErA6Y7eBRyvG/eItOHmbh6eDd+CNBK2DNj67mPfepwtBd41uQGLt3Ja5aqbxRTXyIY345iIPgfzOtDOfVurYO0UhVdmIijmhqafaxEg1kZBFjHa31Hh0fTkREFWSqyVaxOZk0+jp2A1iAzF5PkuahDrgjBaLV1ASmMiqopR7EUBGyCyQCjt4n8nSmejMDF6iW5kS8KNb6Hgid1KmFE1VdyzsHt6ny+kHkMwOUiKwU87NpPOB3UIhOcvT34285XqbKTw6hTi+Ltn0+OPqh/S5qc15mTx6DlVqRvwxEt3+Kiz0M756u1BgC/GB/8v+vmYcuXw2StLQ+z0WW8Mxb4719IajWnBHOU1ELll6eGCSeedMlEgBTwp/XdWQW1+vTEMalRFl5eeVv7wmUmxywwgxib4oiu+yLDqgb5nQu2DcO2JJZ+BIZsb8yF0jBbA+G8XGOx8jQCUf/WQqaTDJtvCmprou2E6Fy8tEQMnLSDnpFwoDtMHVWLJJ6KHpb2WAiPbnXnEkh/3vaWFdlazy2P63EQgOwrmpXIemshvwmJdaO9LB0vS/UVjuzR/D9LFrK+PKSpzf63PcjvdA6dZfyx767r+HBihq02CwEDw2QNBrG5tzFD5Vv6rDxnCIMp7CJYrJ/GUS9yN6WOYLfmN9+E9ZWDDjzNAlKolkiGw7Nl2upi0953OTKblZEceqN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(346002)(376002)(396003)(136003)(39860400002)(54906003)(66556008)(64756008)(8936002)(5660300002)(6916009)(66446008)(4326008)(66476007)(8676002)(86362001)(91956017)(38100700002)(2616005)(66946007)(53546011)(41300700001)(6512007)(316002)(76116006)(71200400001)(6506007)(966005)(33656002)(478600001)(122000001)(2906002)(6486002)(36756003)(186003)(38070700005)(26005)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4962 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d18da76f-6787-4951-e741-08da635798e3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jNpc71WzSymopoDujKCZqf9GwjKsX0TR98Ud5gF7LJrudu1rXncPK7MvUS7/hZv3KhtRM719ALFIZOw+PC9RVW4+I2LZsMNLz4yLR9b2t2tYfdlYp9B3Kx7azYsDdZkQGXB4W3hTsbhUMRxsmrL+vpy1+gUMo3Rp0naPTnocC1KQeYZbXMuT0SQDEAIkPchvAPgIscPpChStcMHhebJZikxJ3L1I0DkR4RjZ32pfFAFs+NMSi8u8MHD3xiaFtybYRMEWy7sotmh6uK3eWOg5J8D4VcKk1eB37zEHx/X/R2pXPn6+sHiRHEYA0cnyobQpI/wfGFI5wAqDmzJuGpte/oJgS1r5xpOOF5/nWN7bYnyjwMUssCmRUIJPUaFCQeKgWDTZ3LV03NBgjTpMwU5z4OayI9kBNaRbhYyLM9ggfFs5XZ284etESiLXQvAvMfBJ03AoWGefyf7lm3vNZ12CT8ScWrhRJZUu1klfBq1BoclvuPteTmgbRUGIjhYlDOEp8UZQSO8zId6lCCJyXu3Qq7F80PwXTxMypizs1gZKKtJ3kR9wMrnYE/9ysQfoibBbZqDiWgc8Zg85ZkjpWq9aY7jJ7OYmPvA3RKIXj8vSzttWQqibqtTuPJklb/7MWOndO/9U014po07RRK6kvWI2z+pv5BCkkxAZBujV5GMNgDe7MXvIqsMq1crzvhUHUNchxEzmWF1wsyHqzGlaY739KXqqUhLtrHn3B5U5X1CMfrZD6Udt46m//hO8//cmDbwzJF/AZQtkX+DS8LL3gZSHjY4f4MKvAPGbP+NdXDshsy+gfJRw65TcVWmc0WQ2Y8cmWacb4Luton7u7ZIIC768cGnuRTxeaFFWuXkLrcfV5MM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(47076005)(33656002)(26005)(186003)(53546011)(70586007)(2616005)(8936002)(6512007)(2906002)(336012)(82740400003)(81166007)(6506007)(40460700003)(356005)(86362001)(40480700001)(82310400005)(36860700001)(54906003)(6486002)(6862004)(5660300002)(478600001)(41300700001)(316002)(4326008)(83380400001)(966005)(36756003)(70206006)(8676002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 16:08:39.9397 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e57d70c2-7ec9-4666-0b11-08da63579e92 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4098 SGkgSnVsaWVuLA0KDQo+IE9uIDIyIEp1biAyMDIyLCBhdCAzOjUxIHBtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpLA0KPiANCj4gT24gMjIvMDYvMjAyMiAx NTozNywgUmFodWwgU2luZ2ggd3JvdGU6DQo+PiBldnRjaG5fYWxsb2NfdW5ib3VuZCgpIGFsd2F5 cyBhbGxvY2F0ZXMgdGhlIG5leHQgYXZhaWxhYmxlIHBvcnQuIFN0YXRpYw0KPj4gZXZlbnQgY2hh bm5lbCBzdXBwb3J0IGZvciBkb20wbGVzcyBkb21haW5zIHJlcXVpcmVzIGFsbG9jYXRpbmcgYQ0K Pj4gc3BlY2lmaWVkIHBvcnQuDQo+PiBNb2RpZnkgdGhlIGV2dGNobl9hbGxvY191bmJvdW5kKCkg dG8gYWNjZXB0IHRoZSBwb3J0IG51bWJlciBhcyBhbg0KPj4gYXJndW1lbnQgYW5kIGFsbG9jYXRl IHRoZSBzcGVjaWZpZWQgcG9ydCBpZiBhdmFpbGFibGUuIElmIHRoZSBwb3J0DQo+PiBudW1iZXIg YXJndW1lbnQgaXMgemVybywgdGhlIG5leHQgYXZhaWxhYmxlIHBvcnQgd2lsbCBiZSBhbGxvY2F0 ZWQuDQo+IA0KPiBJIGhhdmVuJ3QgeWV0IGZ1bGx5IHJldmlld2VkIHRoaXMgc2VyaWVzLiBCdXQg SSB3b3VsZCBsaWtlIHRvIHBvaW50IG91dCB0aGF0IHRoaXMgb3BlbmluZyBhIHNlY3VyaXR5IGhv bGUgKHdoaWNoIEkgdGhvdWdodCBJIGhhZCBtZW50aW9uIGJlZm9yZSkgdGhhdCBjb3VsZCBiZSBl eHBsb2l0ZWQgYnkgYSBndWVzdCBhdCBydW50aW1lLg0KPiANCj4gWW91IHdvdWxkIG5lZWQgWzFd IG9yIHNpbWlsYXIgaW4gb3JkZXIgdG8gZml4IHRoZSBpc3N1ZS4gSSBhbSB3cm90ZSAic2ltaWxh ciIgYmVjYXVzZSB0aGUgcGF0Y2ggY291bGQgcG90ZW50aWFsbHkgYmUgYSBwcm9ibGVtIGlmIHlv dSBhbGxvdyBhIGd1ZXN0IHRvIHVzZSBGSUZPICh5b3UgbWF5IG5lZWQgdG8gYWxsb2NhdGUgYSBs b3Qgb2YgbWVtb3J5IHRvIGZpbGwgdGhlIGhvbGUpLg0KPiANCj4gQ2hlZXJzLA0KPiANCj4gWzFd IGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdHdlYi8/cD1wZW9wbGUvanVsaWVuZy94ZW4tdW5z dGFibGUuZ2l0O2E9Y29tbWl0O2g9MmQ4OTQ4NmZjZjExMjE2MzMxZTU4YTIxYjM2N2I4YTliZTFh ZjcyNQ0KDQpUaGFua3MgZm9yIHNoYXJpbmcgdGhlIHBhdGNoLiAgSWYgeW91IGFyZSBva2F5IEkg Y2FuIHVzZSB0aGlzIHBhdGNoIGluIG5leHQgdmVyc2lvbiB0byBmaXggdGhlIHNlY3VyaXR5IGhv bGUuDQoNCkZvciB0aGUgRklGTyBpc3N1ZSwgd2UgY2FuIGludHJvZHVjZSB0aGUgbmV3IGNvbmZp ZyBvcHRpb24gdG8gcmVzdHJpY3QgdGhlIG1heGltdW0gbnVtYmVyIG9mIHN0YXRpYw0KcG9ydCBz dXBwb3J0ZWQgaW4gWGVuLiBXZSBjYW4gY2hlY2sgdGhlIHVzZXItZGVmaW5lZCBzdGF0aWMgcG9y dCB3aGVuIHdlIHBhcnNlIHRoZSBkZXZpY2UgdHJlZSBhbmQgaWYNCmEgdXNlci1kZWZpbmVkIHN0 YXRpYyBwb3J0IGlzIGdyZWF0ZXIgdGhhbiB0aGUgbWF4aW11bSBhbGxvd2VkIHN0YXRpYyBwb3J0 IHdpbGwgcmV0dXJuIGFuIGVycm9yIHRvIHRoZSB1c2VyLg0KSW4gdGhpcyB3YXksIHdlIGNhbiBh dm9pZCBhbGxvY2F0aW5nIGEgbG90IG9mIG1lbW9yeSB0byBmaWxsIHRoZSBob2xlLg0KDQpMZXQg bWUga25vdyB5b3VyIHZpZXcgb24gdGhpcy4NCg0KY29uZmlnIE1BWF9TVEFUSUNfUE9SVA0KICAg IGludCAiTWF4aW11bSBudW1iZXIgb2Ygc3RhdGljIHBvcnRz4oCdDQogICAgcmFuZ2UgMSA0MDk1 DQogICAgaGVscCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIA0KICAgICAgIENvbnRyb2xzIHRoZSBidWlsZC10aW1l IG1heGltdW0gbnVtYmVyIG9mIHN0YXRpYyBwb3J0IHN1cHBvcnRlZC4NCg0KUmVnYXJkcywNClJh aHVsDQoNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 11 16:21:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 16:21:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365298.595418 (Exim 4.92) (envelope-from ) id 1oAwAF-0007XK-Iz; Mon, 11 Jul 2022 16:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365298.595418; Mon, 11 Jul 2022 16:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwAF-0007XD-G9; Mon, 11 Jul 2022 16:21:39 +0000 Received: by outflank-mailman (input) for mailman id 365298; Mon, 11 Jul 2022 16:21:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwAE-0007X7-3W for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 16:21:38 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 87a6008e-0135-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 18:21:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87a6008e-0135-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657556496; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4/cPvRGCHv91OABlMjjXd4S9LvIBx6YhWn+u3h66+IA=; b=LLDN0g/M3dFFRKGFs0Z93B1aY0JxAeuXwSDp3weNls2zhoFgREh11rdB rbG4kzyztvSsRQvLUSDatECnBgeMLbUEGs9FLbztwxAct9axWrG6mRDqz 0oo3CYT7MgFrV/+YCBM81haaIQ3hNbz4kireKtmafrMkAxuUhIDiNaCOT k=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75530228 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:aL9PSK563xOzrJ2vC/ZHVQxRtGjHchMFZxGqfqrLsTDasY5as4F+v jccUGDXOqyPYmuhfI0kOY/j90IEv5fdnNNqGQM5qi5jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YfgWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSgaR1qJvTik903dDZTTBFBL+5C25rIdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKsWvG1gyjfIS+4rW5nZT43B5MNC3Sd2jcdLdRrbT 5VENGE3Nk6QC/FJEm42A7sfxtymvXjieAF4rU+kiekvoGeGmWSd15CyaYGIK7RmX/59gUKwt m/AuWPjDXkyJNGZjDaI7H+oruvOhj/gHpIfEqWi8fxni0HVwXYcYDUUX1ampfiyimalRslSb UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MS+CGXibKNzQ2gLE8rRWFxV85lsOwTSml/v rOWpO8FFQCDoZXMFy/Cre/O8GrrUcQGBTRcPHFZFGPp9/Gm+dhu1UyXE76PBYbv1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vh6b/PuREEXCBsZ59wH+xFzFtR kQslcmE9/wpBpqQjiGLS+hlNOj3uqnZb22F3gI+RcVJG9GRF5mLJNo43d2DDB0xbpZslcHBO ic/Rj+9FLcMZSD3PMebkqq6CtgwzLiIKOkJosv8N4IUCrAoLVfv1Hg3OSa4gjG2+GBxwP5XB HtuWZv1ZZrsIf8/nGTeqiZ0+eJD+x3SMkuKGMqrnkT5gerDDJNXIJ9cWGazgikCxPvsiG3oH xx3baNmFz03vDXCXxTq IronPort-HdrOrdr: A9a23:ozisTK30oLanUogeguacdgqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="75530228" Date: Mon, 11 Jul 2022 17:21:25 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [PATCH] xl: relax freemem()'s retry calculation Message-ID: References: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> On Fri, Jul 08, 2022 at 03:39:38PM +0200, Jan Beulich wrote: > While in principle possible also under other conditions as long as other > parallel operations potentially consuming memory aren't "locked out", in > particular with IOMMU large page mappings used in Dom0 (for PV when in > strict mode; for PVH when not sharing page tables with HAP) ballooning > out of individual pages can actually lead to less free memory available > afterwards. This is because to split a large page, one or more page > table pages are necessary (one per level that is split). > > When rebooting a guest I've observed freemem() to fail: A single page > was required to be ballooned out (presumably because of heap > fragmentation in the hypervisor). This ballooning out of a single page > of course went fast, but freemem() then found that it would require to > balloon out another page. This repeating just another time leads to the > function to signal failure to the caller - without having come anywhere > near the designated 30s that the whole process is allowed to not make > any progress at all. > > Convert from a simple retry count to actually calculating elapsed time, > subtracting from an initial credit of 30s. Don't go as far as limiting > the "wait_secs" value passed to libxl_wait_for_memory_target(), though. > While this leads to the overall process now possibly taking longer (if > the previous iteration ended very close to the intended 30s), this > compensates to some degree for the value passed really meaning "allowed > to run for this long without making progress". > > Signed-off-by: Jan Beulich > --- > I further wonder whether the "credit expired" loop exit wouldn't better > be moved to the middle of the loop, immediately after "return true". > That way having reached the goal on the last iteration would be reported > as success to the caller, rather than as "timed out". That would sound like a good improvement to the patch. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 16:37:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 16:37:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365308.595434 (Exim 4.92) (envelope-from ) id 1oAwP8-0000pF-1E; Mon, 11 Jul 2022 16:37:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365308.595434; Mon, 11 Jul 2022 16:37:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwP7-0000p8-Sq; Mon, 11 Jul 2022 16:37:01 +0000 Received: by outflank-mailman (input) for mailman id 365308; Mon, 11 Jul 2022 16:37:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwP6-0000ou-If for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 16:37:00 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad45da98-0137-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 18:36:58 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad45da98-0137-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657557418; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=i8VLoWg1z9FnUM9x+aYhPQLcf56zWhlC8YjEQsF46EU=; b=XOZbBdHhG3xmndKiQ+QNMLhUQHrRlWQ19KsOp/5iOcJAQtkXnCdDjkQY pQOXN53qs1VTXTVqUY39qCX+yvaKDqoP+j5oc6SZNIw7PeqNWMxeGhywL KnJpxuXqt7OqxGg9LmCQ3Dr6cCbqQtLV1TlsC5UyrMb0Ju1nK+QYpMm1l Y=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75960082 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:AakqIatFUZPA/2IJwxb1nqE5B+fnVF1eMUV32f8akzHdYApBsoF/q tZmKW+AOPmMZmuhfIp2aNni8xwBu8eGn9U2QQNorS1kH3tA+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zU4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8JLJTJlMohFCVnGiBsYJdA/bjAGSKg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUyPUqYO00VUrsRILIbjsCn12TfSR9BhFuKnIkt0U//8gMkhdABN/KKI4fXFK25hH2wp H/C/mn/KgEXMpqY0zXt2mm3mubFkCf/WYQTPL617PhnhBuU3GN7IAISfUu2p7++kEHWc9BQM UsP4QI1sLM/skesS7HVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQkvsIrQT0h1 neSgsjkQzdotdWopWm1r+nO62noYG5McDFENXRsoRY5D8fLgJMKix7hcpFfL6e0nIDPHzT3x AjQs31r71kMtvLnx5lX7Hie3W/z/cCTE1dsjunEdjn7t10kPeZJc6TtsAGGtqgYce51W3Hb5 BA5d96iAPfi5H1nvAiEW60zEb6g/J5p2xWM0Ac0T/HNG9lAkkNPnLy8AxkkfS+Fyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27C6+IMYoXPcQgLlPvEMRSiam4hjqFraTRuftnZ cfznTiEVx729piLPBLpHrxAgNfHNwg1xH/JRICT8ilLJYG2PSbPIZ9caQPmRrlgsMus/VSOm /4CZpTi9vmqeLCnCsUh2dVLfQ5iwLlSLc2elvG7gcbaf1A2STF/W6+MqV7jEqQ895loei7z1 inVcidlJJDX3BUr9S3ihqhfVY7S IronPort-HdrOrdr: A9a23:8ih1Z62hphZust2bf9kAPQqjBLAkLtp133Aq2lEZdPRUGvb4qy mLpoV96faUskd0ZJhOo7y90cW7Lk80sKQFh7X5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOceEYZmIbsS+V2meFL+o= X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="75960082" Date: Mon, 11 Jul 2022 17:36:45 +0100 From: Anthony PERARD To: Juergen Gross CC: , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: Re: [PATCH] xen/build: remove unneeded enumeration in clean-files Message-ID: References: <20220711105840.10533-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220711105840.10533-1-jgross@suse.com> On Mon, Jul 11, 2022 at 12:58:40PM +0200, Juergen Gross wrote: > Enumerating a file from $(targets) in $(clean-files) isn't needed. > > Remove xen/include/xen/hypercall-defs.h from $(clean-files). > > Reported-by: Jan Beulich > Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") > Signed-off-by: Juergen Gross > --- > xen/include/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/include/Makefile b/xen/include/Makefile > index 39d9f5556c..fa0d454ab7 100644 > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -225,4 +225,4 @@ all: lib-x86-all > endif > > clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h > -clean-files += xen/hypercall-defs.h hypercall-defs.i > +clean-files += hypercall-defs.i The patch title is a bit too broad and only correct a recent patch. It doesn't really matter I think if `rm -f` tries to remove the same file twice, but maybe this patch should actually do what it is explained in the description ;-). There is also "headers*.chk" that is listed in both $(targets) and $(clean-files) which could be unlisted from the latter as well. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 17:02:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 17:02:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365331.595449 (Exim 4.92) (envelope-from ) id 1oAwnW-0004Vy-Vh; Mon, 11 Jul 2022 17:02:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365331.595449; Mon, 11 Jul 2022 17:02:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwnW-0004Vr-Sx; Mon, 11 Jul 2022 17:02:14 +0000 Received: by outflank-mailman (input) for mailman id 365331; Mon, 11 Jul 2022 17:02:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAwnV-0004Vl-W9 for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 17:02:14 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 342dd00d-013b-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 19:02:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 342dd00d-013b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657558932; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gNmpfx9ATpOVkWL0AY17AFe15NpE1SUxAGwUweyAUf8=; b=eE+YZSG+iuPyPQ0wwvhO2D0gu/3b1gd2W8W9LYfl6P671xLGb+qiPER8 BNOxBcGgquw12fniINiyuf46Hg6ZxSbgfOTjYuPx1UXFbrVdxn5mMrk5K 3UXW3s8EcPTHvCPdT4A9iGvCFZs8qkiyTE8zwVxqll2xSLyNM1F5CPba1 E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 74844172 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5+LtTKtQWtwMIeeMa2Yi42NJ5OfnVAZeMUV32f8akzHdYApBsoF/q tZmKT2AbvuNMDPyKYpyO4Xg/BwBv5HXytRkSgJt+SEwRnka+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQywYbVvqYy2YLjW1zU4 IuoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi8ZBJfTgMlGViBqEiN3MoxU24TheWOg5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllpyy3ZCvA3B4jOWazQ6fdT3Ssqh9AIFvHbD yYcQWUzPEicOkIVUrsRIM07wPvzvSPQShxdpXW2jLgK31mU7RMkhdABN/KKI4fXFK25hH2wt m/Aumj0HBweHNie0iaetGKhgPfVmiH2U55UE6e3ntZ1hHWDy2pVDwcZPXO5q/Skjk+1W/pEN lcZvCEpqMAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l+pDu/B60XW09fD9DYdMHpuwNY2Qxy Qrc9z/2PgCDoIF5WFrEqOrL9mvoZHFMRYMRTXRaFFVYurEPtKl210uSFYg7TcZZm/WvQVnNL ya2QD/Sbln5peoCzO2F8F/OmFpATbCZH1dutm07so9Ihz6VhbJJhKTysDA3Fd4acO6koqCp5 RDoYfS24uEUFo2qnyeQWugLF7zBz6/bbWKA3g42QMVwrWjFF5ufkWd4uWsWGauUGpxcJW+Bj LH742u9G6O/zFP1NPQqMupd+uwhzLT6FMSNa804muFmO8ArHCfepXkGTRfJgwjFzRl3+Ylia MjzTCpZJStDYUiR5GHuF7l1PH5C7n1W+F4/sriikk73gOrANC7IIVrHWXPXBt0EAGq/iF292 75i2wGikH2zjMWWjvHrzLMu IronPort-HdrOrdr: A9a23:UH5KR627HTHLbmNtk+RMggqjBLIkLtp133Aq2lEZdPRUGvb3qy mLpoV+6faUskd1ZJhOo7290cW7LU80sKQFhrX5Xo3SPjUO2lHJEGgK1+KLqFfd8m/Fh41gPM 9bAs5D4bbLbGSS4/yU3DWF X-IronPort-AV: E=Sophos;i="5.92,263,1650945600"; d="scan'208";a="74844172" Date: Mon, 11 Jul 2022 18:01:48 +0100 From: Anthony PERARD To: Jan Beulich CC: Andrew Cooper , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Wei Liu , Subject: Re: [XEN PATCH v3 04/25] tools/firmware/hvmloader: rework Makefile Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-5-anthony.perard@citrix.com> <76605880-bf6c-afd0-8fbb-a15bfccc1eed@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <76605880-bf6c-afd0-8fbb-a15bfccc1eed@suse.com> On Mon, Jul 11, 2022 at 03:52:52PM +0200, Jan Beulich wrote: > On 24.06.2022 18:04, Anthony PERARD wrote: > > Setup proper dependencies with libacpi so we don't need to run "make > > hvmloader" in the "all" target. ("build.o" new prerequisite isn't > > exactly proper but a side effect of building the $(DSDT_FILES) is to > > generate the "ssdt_*.h" needed by "build.o".) > > Maybe leave a brief comment there? Sounds good. > > Make use if "-iquote" instead of a plain "-I". > > > > For "roms.inc" target, use "$(SHELL)" instead of plain "sh". And use > > full path to "mkhex" instead of a relative one. Lastly, add "-f" flag > > to "mv", in case the target already exist. > > Hmm - according to my understanding -f isn't needed just because the > file may already exist. It would be needed if a pre-existing file > isn't writable. (I don't mind the addition of the flag, but I think > what you say can end up misleading.) Yes. After reading the posix doc about `mv`, the following would be better: Lastly, add "-f" flag to "mv" to avoid a prompt in case the target already exist and we don't have write permission. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 11 17:52:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 17:52:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365338.595460 (Exim 4.92) (envelope-from ) id 1oAxZy-0001jD-U1; Mon, 11 Jul 2022 17:52:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365338.595460; Mon, 11 Jul 2022 17:52:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAxZy-0001j6-Qn; Mon, 11 Jul 2022 17:52:18 +0000 Received: by outflank-mailman (input) for mailman id 365338; Mon, 11 Jul 2022 17:52:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAxZw-0001j0-SQ for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 17:52:17 +0000 Received: from sonic308-55.consmr.mail.gq1.yahoo.com (sonic308-55.consmr.mail.gq1.yahoo.com [98.137.68.31]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30c8f83b-0142-11ed-bd2d-47488cf2e6aa; Mon, 11 Jul 2022 19:52:13 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Mon, 11 Jul 2022 17:52:10 +0000 Received: by hermes--production-ne1-7864dcfd54-q5j27 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c836adb02e8ba905612c5d0278c92b3a; Mon, 11 Jul 2022 17:41:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30c8f83b-0142-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657561930; bh=6Z9kuwBxngD86iqFVMf/+x91pDL1RDTsT23U8EQLlTc=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=U9hCPXcKpaCB4NwotPxkvBZB2YF5RJNFSpWaTH+Ac02vf9LUEzGT6HPnz5D/+VOtCT/I5HqY1OKPx4CSzXT4KkqVOkpJHuru8fLUh4LdLb29zmGQBefCEGeMjSgajqGFjA95XvP+74c/5uVzDpV7GsBcoM8quY3SW+mm/aohTEpTlN9KWJnX4qiXB0U/ZRLLGGRid7cU8h6s9/QP27o0JvZdnPQZHcON7RPZszWcW6OTAhUi64Ws/pOHkgtC2aNFzVNZzcgoBRFKuzaTJouZuInXwukkHh4Y65v0fnZFlxUG3+c2OiwTueho8Vo0d6jYWtUdGtqULGdD/YLtVy1COg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657561930; bh=R5xXVcFnf26EslfNOBCgb+r4tS9SZFZED0W0or3eXBZ=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=gIapt2NaRMzJGVQ3qBH/1HtOLi7UX1+2Fx/VF1H8a97FTUCyZuFDCwnNaMVwm3xAIChaHdK2uz2edATUXMbwt0rd81vdBBY/7zcB3zxY5gqhFxblZV2UyknU6ql+P1JWGT/FJU6vhwJyQRno05UatJFybHuPakDRhmsS/OeqOueHjmxc4izbiyRKYOif3+LzetcEBzjJWrftZ15RinPDKteHMFy62N3gG0cTB6owoH4j19yvRo/R73M3B1ByzlXfc2MFaDHKIp5m0eWmaNDm0RlkAMImsIEA9+13BClh+PWR4zAq89+9eJA3ViCs24R2S1A1q1JGu/kYiYmuvhCV3Q== X-YMail-OSG: FGXviiwVM1nf8oOLvlcrlqzdgLJFo0AxndR7o3x4KndnObuus5vChjVnx7NhCv1 KofFLuzNf2hRJmHQQdjaIkUxdVTA5igTBKzWgMZj77Mg22nF0DIm_Y2wtaEZWyYn5Ydwl9r7l58Y FEUDO8tzOWBU5TpUrb_5nQQWZbRTvcarGVscxl2VS4zS.mQ4P8OPpHUcXZg9OaTzAyW74LRJFxP7 y_AoWxGQoJ47alFrYu0Nt18JmpkY3qAtgIP7ljw1gn9Pc5z0wnD6ZenIIXIt3C8iLzfOMbdazavU UpaoeEQXom3GAjusJW_Fc1NMX77x22ajD_xMVgmJd_gFPt10LRQvy7xvnhfkcFr4mYw1S4DNMzJ8 HzG5ksBxCqkNO0x3sMMCUZhV.Trav.b1cmCArbVv6cHQgDFR5DTXbcoPQ1w_56qk7aA6LlBAj5oV 2.GPc41nmDGEIDNkddIckZ1sRl6e_GYS1bPgzNUS7csEWNKt8YcYhoEL1lmzggV7xI0RdkVR7Khb WA_BWEG05Y7uSel_8Hs5JIbaDEgkFNas1OG9GB_RV37lMvbEYCYH2kq6IC_ZLvnMO.Ai90dmkatc f.l_7LpjQI_PcyfWPF4TWImCl4GDpA4o113NLnyCqY92BIbKBTHzJRRFfSLefybGQ72XfTqXfRTS 2CSXDEi9ljftxhU5XmEr8AbpXrp4MBcwsgbPiEJq51Vu3QYKHlKV9YBMgp7O0UoOEOytE7GKHH7X II07LMQzabajbTvZT68qE7cf4XL8cVLwznp1qiDUCpJmRt8nMlzD3VXkF4x0spGYtGeAEzRnw6mr cwTMjiUFHbS.tL3iCOW3CBA0uqQfoSDCONULh1WSvn4uotp.SIPaGqt.AFVK6nncnM8YipE7n3l7 sI_AnnYVzYKRIZuczHlvXXYZ3NfHxdJy_SQmEMA96fGHY8sCUsvKdE5g1CsRMM64FzYa8VLPAOj. aoGuhR11z7xwIGpp1i2LWU9cHx5PG4Swr.ydX2VW5Ap1g1CYtvfm7BuofIakpQyjVdR8Xq5Wp239 Aaxeio8Z8A7pQcKcVjcxyXEJt3fPXR7y2jXAOyHyz0r0dZRCZZxuu5D5lIWFk_HtxLzY_DeZh7dM 0CJWlTka0Uyrc0SomRiHamrvlu6c2hiz8BUJjTMc17Zd8pjqEnccyx6KqnLoG2ZsnUjUI2YawOEd om5W60oxSljZyI8dJ1mLAcJuR4a_uUc3Em500TK61Gzg9QSWRBRLun1p995ps6ajQz2yHZ8Is3vr Qdwh10ziZJ__eRKXQv4cPmQMBxk0jgC2DXexUHfmsSvuNUMlPuazx1Z.2Jf.D9mVJV20wq6bb6QT FBDggjwvA1qYr_Wmu6spvmeLr06_n.s4KigQp3PncATVuFiy2sr5tu6SLLmvvIRx_E0x2ZuWfqmv L.nRzGWX30t3kl5UNkvyLMVzWjy8nQzXE_LKRdjbYtX2K3E0WhaWad7tg21Igt.ySDp3iK5.IVlE amG5WOGZqmAZR7QsOvVx8il1GdxBvQyUBsSPdSczmXet2tT3fOpjHfDWDtuVBHLLgyWD4WDbBUGg Vw8KWPNII9lHZq5J2TVqFHAaxMk7nyuTEF2wkTsoE5g.IT.csMcqRfCB3j79wE0Q9etfWOrfAMG_ JQywfDG2kTnhCNwMVOT7uC4fpTpFRV70ss48gvr_ZB7zcttuBwOIlVXBUV95E3_RvD19VccjNjFI Jo88lMeKMQthdJEFzsvvYTbUfyM94pfBJ9H23PeMuBHoqWuq15LHqorgqaw9jdV16F8AwmVjPCLE Pg5Eia4_2UWwjcD3JZsVxxqgY5N1YxLAjIP6pdiDqBme13PMZITiSivbSWL8oYeZYrAzrWU1etgV .bFqzRwDZFM3V8a.VIqwtEVJnKhxf6IFaNUvrpH3OntCu6ie4PLl2CDM5prihjEviCaHcTwjW841 P3wwMItyMHi6uZwu0IAgEOP0gWIQlu9hPzB9QOSMscE9C0ppcMDpksZ0mSzv3_7HtO0NhOofXXJ1 KTbSfB7Ohc1S6fJqaFQoB1OpgzvUp6UJQ0fP7Vf3G_HDh_phwChGXVHWbrch2D_0grbf3ncSlhq8 ZkBl6Gviat1K2VDOBZpM8IPMU3qhk0ZXiraql9Xcylu3JEFdVD34OISCKRoKRe.XeQG6OzvUQnOd rXiPW_AvB22K_jzZ4Fj1XjZ9vPtZm20lwiOKAfELSmpilANqRlpbCgogy.4Oa0kdXxCftAhpVi7h vooNCbR7rTkN05hjaOkF9 X-Sonic-MF: Message-ID: Date: Mon, 11 Jul 2022 13:41:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen To: Juergen Gross , Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20381 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 14146 On 7/11/2022 10:31 AM, Juergen Gross wrote: > On 11.07.22 16:18, Chuck Zmudzinski wrote: > > On 7/5/22 12:14 PM, Borislav Petkov wrote: > >> On Tue, Jul 05, 2022 at 05:56:36PM +0200, Jan Beulich wrote: > >>> Re-using pat_disabled like you do in your suggestion below won't > >>> work, because mtrr_bp_init() calls pat_disable() when MTRRs > >>> appear to be disabled (from the kernel's view). The goal is to > >>> honor "nopat" without honoring any other calls to pat_disable(). > >> > >> Actually, the current goal is to adjust Xen dom0 because: > >> > >> 1. it uses the PAT code > >> > >> 2. but then it does something special and hides the MTRRs > >> > >> which is not something real hardware does. > >> > >> So this one-off thing should be prominent, visible and not get in the > >> way. > > > > Hello, > > > > I have spent a fair amount of time this past weekend > > investigating this regression and what might have caused > > it and I also have done several tests on my Xen workstation > > that exhibits the regression to verify my understanding > > of the problem and also raise other problematic points. > > > > I think, in addition to immediately fixing the regression by > > fixing the now five-year-old commit that is the root cause > > of the recently exposed regression, as discussed in my > > earlier message which proposes a simple patch to fix that > > five-year-old broken commit, > > > > https://lore.kernel.org/lkml/63583497-152f-5880-4c8f-d47e2a81f5a6@netscape.net/ > > > > there needs to be a decision about how best to deal with > > this very aptly described "one-off Xen thing" in the future. > > > > One problem in x86/mm/pat/memtype.c is the fact that there > > exist two functions, pat_init(), and init_cache_modes(), that > > do more or less the same thing, so that when one of those > > functions needs to be updated, the other also needs to > > be updated. In the past, when changes to the pat_enable > > and pat_disable functions and variables were made, all > > too often, the change was only applied to pat_init() and not > > to init_cache_modes() and the one-off Xen case was simply > > not addressed and dealt with properly. > > > > So I propose the following: > > > > 1) Identify those things that always need to be done in > > either pat_init() or init_cache_modes() and try to combine > > those things into a single function so that changes will > > be applied for both cases. We sort of have that now with > > __init_cache_modes(), but it is not really good enough to > > prevent the regressions we sometimes get in Xen PV > > domains such as the current regression we have with > > Xen Dom0 and certain particular Intel graphics devices. > > > > 2) If it is not possible to do what is proposed in 1), at least > > re-factor the code to make it very clear that whenever > > either pat_init() needs to be adjusted or init_cache_modes() > > needs to be adjusted, care must be taken to ensure that > > all cases are properly dealt with, including the > > one-off Xen case of enabling PAT with MTRR disabled, > > Currently, AIUI, all one really needs to know is that > > init_cached_modes() handles two special cases: > > First, when PAT is disabled for any reason, including when > > the "nopat" boot option is set, and second, the one-off > > Xen case of MTRR being disabled but PAT being enabled. > > > > I am trying to do number 2 with a patch series I am > > working on. It is up to the experts to decide if it > > is possible or even desirable to improve the code so > > that any changes to the caching configuration are more > > likely to be properly implemented for all supported platforms > > by successfully combining the two functions pat_init() and > > init_cache_modes() into a single function. The new function > > would probably need to be renamed and include bits from > > mtrr_bp_enabled, etc. for it to function properly. > > > > If anyone wants to argue that it is not desirable to try > > combine pat_init() and init_cache_modes() into a single > > function, I think the burden of proof rests on that > > person to demonstrate why it is good and clean > > coding practice to continue to have them separate > > and independent from each other in the code when > > they both essentially do the same thing in the end, which > > is call __init_cache_modes() and determine the PAT > > state, and also probably the MTRR state. > > I think the proper solution would be to make PAT and MTRR independent > from each other with some additional restructuring on the PAT side: > > Today PAT can't be used without MTRR being available, unless MTRR is at > least configured via CONFIG_MTRR and the system is running as Xen PV > guest. In this case PAT is automatically available via the hypervisor, > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > As an additional complexity the availability of PAT can't be queried > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > to be disabled. My testing indicates your presumption is not correct, or at least my testing on my Xen workstation makes me doubt that your assertion that PAT can't be queried vi pat_enabled() in the Xen PV case is true. Let me begin a discussion by posing a question about the following code in init_cache_modes(), a function implemented in arch/x86/mm/pat/memtypes.c, and which is called from arch/x86/kernel/setup.c but only effective if pat_cm_initialized has not already been set by pat_init(), as is obvious from the immediate return if pat_cm_initialized has already been set. Now in the Xen PV case, pat_cm_initialized is not set because pat_init(), where it is normally set, was skipped due to the fact that MTRRs are disabled in Xen PV domains. I verified that init_cache_modes() is activated in the Xen PV Dom0 case by my testing. So, I ask, why cannot the code that is present here in init_cache_modes() be used to test for PAT in the Xen PV Dom0 environment and if the test is positive, why cannot pat_bp_enabled be set which will cause pat_enabled() to return true in the Xen PV environment? In fact, I used the additional 'else if' block to set pat_bp_enabled to true in the Xen PV environment for the case when boot_cpu_has(X86_FEATURE_PAT) is true and PAT MSR does not return 0, that, is, when pat !=0 after calling rdmsrl(MSR_IA32_CR_PAT, pat) for the boot CPU. All the existing comments in this function indicate this is a valid way to test for the existence of PAT in the Xen PV Dom0 environment. Moreover... (please move to the bottom of the code snippet for more information about my tests in the Xen PV environment...) void init_cache_modes(void) {     u64 pat = 0;     if (pat_cm_initialized)         return;     if (boot_cpu_has(X86_FEATURE_PAT)) {         /*          * CPU supports PAT. Set PAT table to be consistent with          * PAT MSR. This case supports "nopat" boot option, and          * virtual machine environments which support PAT without          * MTRRs. In specific, Xen has unique setup to PAT MSR.          *          * If PAT MSR returns 0, it is considered invalid and emulates          * as No PAT.          */         rdmsrl(MSR_IA32_CR_PAT, pat);     }     if (!pat) {         /*          * No PAT. Emulate the PAT table that corresponds to the two          * cache bits, PWT (Write Through) and PCD (Cache Disable).          * This setup is also the same as the BIOS default setup.          *          * PTE encoding:          *          *       PCD          *       |PWT  PAT          *       ||    slot          *       00    0    WB : _PAGE_CACHE_MODE_WB          *       01    1    WT : _PAGE_CACHE_MODE_WT          *       10    2    UC-: _PAGE_CACHE_MODE_UC_MINUS          *       11    3    UC : _PAGE_CACHE_MODE_UC          *          * NOTE: When WC or WP is used, it is redirected to UC- per          * the default setup in __cachemode2pte_tbl[].          */         pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) |               PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);     }     else if (!pat_bp_enabled) {         /*          * In some environments, specifically Xen PV, PAT          * initialization is skipped because MTRRs are          * disabled even though PAT is available. In such          * environments, set PAT to initialized and enabled to          * correctly indicate to callers of pat_enabled() that          * PAT is available and prevent PAT from being disabled.          */         pat_bp_enabled = true;         pr_info("x86/PAT: PAT enabled by init_cache_modes\n");     }     __init_cache_modes(pat); } This function, patched with the extra 'else if' block, fixes the regression on my Xen worksatation, and the pr_info message "x86/PAT: PAT enabled by init_cache_modes" appears in the logs when running this patched kernel in my Xen Dom0. This means that in the Xen PV environment on my Xen Dom0 workstation, rdmsrl(MSR_IA32_CR_PAT, pat) successfully tested for the presence of PAT on the virtual CPU that Xen exposed to the Linux kernel on my Xen Dom0 workstation. At least that is what I think my tests prove. So why is this not a valid way to test for the existence of PAT in the Xen PV environment? Are the existing comments in init_cache_modes() about supporting both the case when the "nopat" boot option is set and the specific case of Xen and MTRR disabled wrong? My testing confirms those comments are correct. > This leads to some drivers believing that not all cache > modes are available, resulting in failures or degraded functionality > (the current regression). I also did some tests to try to verify that fast WC caching mode was used as requested by the i915 Intel graphics driver on my Xen Dom0 workstation and so far I cannot prove that the WC caching mode was not used, and I have some custom logs from the Linux kernel i915 driver that indicates my Linux Xen Dom0 is able to use the fast WC caching mode, so long as the bug that causes pat_enabled() to return a false negative is fixed. So my testing seems to contradict rather than confirm your claim that "the availability of PAT can't be queried via pat_enabled() in the Xen PV case." I think my patch successfully does what you claim cannot be done, and I also think the existing comments in init_cache_modes() indicates that my patch is successfully testing for PAT in the Xen PV case. > > The same applies to a kernel built with no MTRR support: it won't > allow to use the PAT MSR, even if there is no technical reason for > that, other than setting up PAT on all cpus the same way (which is a > requirement of the processor's cache management) is relying on some > MTRR specific code. After reading the code extensively, I am curious about testing and even successfully compiling a kernel with options like CONFIG_MTRR and CONFIG_PAT disabled. But my testing indicates such problems could be debugged and fixed if they manifest using the current code which, AFAICT, appears to be mostly designed and tested for the case when both PAT and MTRR are enabled on modern x86 hardware. I would expect many bugs for configurations that deviate too far from that paradigm on Linux. This is the problem with Xen's unique configuration that enables PAT but disables MTRR. I think the problem can be solved, it is just that there is not enough care taken to ensure that these outlier cases will work as well as the common configuration that Linux supports well, which is with both MTRR and PAT enabled on x86. > > All of that should be fixable by: > > - moving the function needed by PAT from MTRR specific code one level > up > - adding a PAT indirection layer supporting the 3 cases "no or disabled > PAT", "PAT under kernel control", and "PAT under Xen control" I am not sure the right way to divide the cases is "PAT under kernel control" and "PAT under Xen control." I also looked at the code in the Xen hypervisor and it does allow for Dom0 to use a Xen hypercall provided by the xenctrl library to enable PAT WC caching mode, and I ran some tests for evidence that my Xen Dom0 was making such hypercalls to support the WC caching mode, but I have not yet been able to verify that the WC caching mode is enabled by a hypercall from Dom0 to Xen, although by reading the code in the hypervisor and xenctrl it seems to be possible. I just don't think the i915 Linux kernel driver uses such hypercalls, and I am not sure that my Xen Dom0 could be using the fast WC caching mode because "PAT is under Xen control" instead of "under kernel control" unless the kernel is relying on Xen to provide PAT via Xen hypercalls. The successful call of my Xen Dom0 to rdmsrl which obtained a valid configuration of PAT for the virtual boot CPU exposed by Xen to the kernel indicates at least that the kernel can detect, if not control, what the supported PAT caching modes are. Of course you are absolutely correct that the kernel cannot directly control the PAT caching modes in the Xen PV environment, at least not without possibly resorting to some Xen hypercalls that are most likely not currently in use by the kernel. I would have to do much more testing to really determine what is happening and how my Xen Dom0 is really configuring the PAT caching modes and specifically, if it is actually using the fast WC caching mode as requested by the i915 Intel graphics driver. > - removing the dependency of PAT on MTRR > > I'd be up for trying this, but right now I haven't got the time to do > it. I might be able to start working on that in September. Please let me know if/when you start on it, I would be interested to try out what you come up with on my Xen Dom0. > > Meanwhile I think either Jan's patch or the simple one of Chuck > should be applied. I agree. Best Regards, Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 11 18:36:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 18:36:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365347.595474 (Exim 4.92) (envelope-from ) id 1oAyH2-0006dj-BQ; Mon, 11 Jul 2022 18:36:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365347.595474; Mon, 11 Jul 2022 18:36:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAyH2-0006dc-7q; Mon, 11 Jul 2022 18:36:48 +0000 Received: by outflank-mailman (input) for mailman id 365347; Mon, 11 Jul 2022 18:36:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAyH1-0006dS-An; Mon, 11 Jul 2022 18:36:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAyH1-0006jM-3c; Mon, 11 Jul 2022 18:36:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAyH0-0000pT-8s; Mon, 11 Jul 2022 18:36:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oAyH0-0005Jb-8L; Mon, 11 Jul 2022 18:36:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=11369peDMNyPK4WO6SY5Hx9Zs1QvrTPg46MErhVXRqI=; b=u7H2dWRATxOBALyx8tUsegEE7O 3Xmgelvo+fSgKPyAK6hJ5Z/h3Sf30iU+2fzLnjSrf99cKM+AvO0LITQdTFkTE1+wrnXeRj5roYjJ1 O/Qd+KrBVn6C4MPQ4+ms+jwwajKkdik912EOFyxR6hkRBcgOf9RFLpyO3a/SISD+40rs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171584: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=27357c394ba6e1571a89105b840ce1c6f026485c X-Osstest-Versions-That: xen=2ce11ce249a3981bac50914c6a90f681ad7a4222 From: osstest service owner Date: Mon, 11 Jul 2022 18:36:46 +0000 flight 171584 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171584/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 27357c394ba6e1571a89105b840ce1c6f026485c baseline version: xen 2ce11ce249a3981bac50914c6a90f681ad7a4222 Last test of basis 171582 2022-07-11 11:01:45 Z 0 days Testing same since 171584 2022-07-11 15:01:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2ce11ce249..27357c394b 27357c394ba6e1571a89105b840ce1c6f026485c -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 11 23:15:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 23:15:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365382.595489 (Exim 4.92) (envelope-from ) id 1oB2cp-0001eT-CX; Mon, 11 Jul 2022 23:15:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365382.595489; Mon, 11 Jul 2022 23:15:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2cp-0001eM-9H; Mon, 11 Jul 2022 23:15:35 +0000 Received: by outflank-mailman (input) for mailman id 365382; Mon, 11 Jul 2022 23:15:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2cn-0001eG-Mf for xen-devel@lists.xenproject.org; Mon, 11 Jul 2022 23:15:34 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59750d7d-016f-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 01:15:30 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id CFD185C00F0; Mon, 11 Jul 2022 19:15:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 11 Jul 2022 19:15:26 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 11 Jul 2022 19:15:26 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59750d7d-016f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t= 1657581326; x=1657667726; bh=VpHo1/elHYA7pJhT0LGGpTpuB/rOsacRE8E VAl/NgDw=; b=aOYEeXkIZ4f7Rv/tI6ziCccK4tcxceynoNcXwPuqphsg/WWl62l k72UVgfUo7wGbiITZD/aqx+afvns0B6hgp+DD1VlBwa5PvcZcXM65Qa9bGniEX1X G9TcTAEW2zGZtPnMDTfB9LAlpIYh1SjbDQQ35rKCHhRDAjXBWIfTmowiIc7mS6U9 kVb9C7eY6Qk+vxrSGEYk3fa+jpMgn7yW8cfeivOIFpd2w4/gZKGPxBICb8oB/Dg0 +X/2nvb0q8X8AcjWhhSHn2Qz1ITnhVXZeNC3ZvsRR03lhje720tQ7SKsB3WEFPHi nu++SPSB2KW3i+SjrbfyzHjvYuD0LDzV7/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1657581326; x=1657667726; bh=VpHo1/elHYA7p JhT0LGGpTpuB/rOsacRE8EVAl/NgDw=; b=KYieoxvrOLkWPMs1ehK7zEl4YWfur oFpTgMlcnqRG1MvdQTRXiRpfLMT/6Jm0nWu/3+WAMj5DEdT5G7+T8+d6AzAL8Z+0 uLOFFE8KKJtxv3FwV4LemQzozTZzyLKZk7gqy+yGJr3+G3PNiR/e+yquZUK1qIlx os0TT73FUHOzQhutEhlOs1j43nqZrq77jmTtct6X/u19HmUUYJdbTna3cn7TuMi8 wE1PrVBCKaS+ECJjar/2Ud/js6l0iXF4l3/lxCWLuC9KFly2FiY4daMRfIiaAUXp M0GhAJA+8N7MbK4PIO7HSpsk28xHBhHwfTO4upl06ou7Z1/70LVcHH1NA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudejgedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeekieeljeeutefgieejfffglefhieet veffleefudefjeegleejvdelvdefueffveenucffohhmrghinhepkhgvrhhnvghlrdhorh hgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepuggv mhhisehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Xen developer discussion Cc: Demi Marie Obenour , Jan Beulich , Luca Fancellu Subject: [PATCH v10] Preserve the EFI System Resource Table for dom0 Date: Mon, 11 Jul 2022 19:14:59 -0400 Message-Id: <5090ce79650583050b2245ee02d8987e65667c23.1657580511.git.demi@invisiblethingslab.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The EFI System Resource Table (ESRT) is necessary for fwupd to identify firmware updates to install. According to the UEFI specification §23.4, the ESRT shall be stored in memory of type EfiBootServicesData. However, memory of type EfiBootServicesData is considered general-purpose memory by Xen, so the ESRT needs to be moved somewhere where Xen will not overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, which Xen will not reuse. dom0 can use the ESRT if (and only if) it is in memory of type EfiRuntimeServicesData. Earlier versions of this patch reserved the memory in which the ESRT was located. This created awkward alignment problems, and required either splitting the E820 table or wasting memory. It also would have required a new platform op for dom0 to use to indicate if the ESRT is reserved. By copying the ESRT into EfiRuntimeServicesData memory, the E820 table does not need to be modified, and dom0 can just check the type of the memory region containing the ESRT. The copy is only done if the ESRT is not already in EfiRuntimeServicesData memory, avoiding memory leaks on repeated kexec. See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ for details. Signed-off-by: Demi Marie Obenour Tested-by: Luca Fancellu --- Tested using qemu-system-x86_64 and xen.efi. Changes since v9: - Fix style nit (brace on separate line) - Add Luca Fancellu's Tested-by Changes since v8: - Fix incomplete refactoring that caused boot to fail on all EFI systems. --- xen/common/efi/boot.c | 135 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 135 insertions(+) diff --git a/xen/common/efi/boot.c b/xen/common/efi/boot.c index a25e1d29f1..a5b2d6ddb8 100644 --- a/xen/common/efi/boot.c +++ b/xen/common/efi/boot.c @@ -39,6 +39,26 @@ { 0x605dab50, 0xe046, 0x4300, {0xab, 0xb6, 0x3d, 0xd8, 0x10, 0xdd, 0x8b, 0x23} } #define APPLE_PROPERTIES_PROTOCOL_GUID \ { 0x91bd12fe, 0xf6c3, 0x44fb, { 0xa5, 0xb7, 0x51, 0x22, 0xab, 0x30, 0x3a, 0xe0} } +#define EFI_SYSTEM_RESOURCE_TABLE_GUID \ + { 0xb122a263, 0x3661, 0x4f68, {0x99, 0x29, 0x78, 0xf8, 0xb0, 0xd6, 0x21, 0x80} } +#define EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION 1 + +typedef struct { + EFI_GUID FwClass; + UINT32 FwType; + UINT32 FwVersion; + UINT32 LowestSupportedFwVersion; + UINT32 CapsuleFlags; + UINT32 LastAttemptVersion; + UINT32 LastAttemptStatus; +} EFI_SYSTEM_RESOURCE_ENTRY; + +typedef struct { + UINT32 FwResourceCount; + UINT32 FwResourceCountMax; + UINT64 FwResourceVersion; + EFI_SYSTEM_RESOURCE_ENTRY Entries[]; +} EFI_SYSTEM_RESOURCE_TABLE; typedef EFI_STATUS (/* _not_ EFIAPI */ *EFI_SHIM_LOCK_VERIFY) ( @@ -567,6 +587,41 @@ static int __init efi_check_dt_boot(const EFI_LOADED_IMAGE *loaded_image) } #endif +static UINTN __initdata esrt = EFI_INVALID_TABLE_ADDR; + +static size_t __init get_esrt_size(const EFI_MEMORY_DESCRIPTOR *desc) +{ + size_t available_len, len; + const UINTN physical_start = desc->PhysicalStart; + const EFI_SYSTEM_RESOURCE_TABLE *esrt_ptr; + + len = desc->NumberOfPages << EFI_PAGE_SHIFT; + if ( esrt == EFI_INVALID_TABLE_ADDR ) + return 0; + if ( physical_start > esrt || esrt - physical_start >= len ) + return 0; + /* + * The specification requires EfiBootServicesData, but accept + * EfiRuntimeServicesData, which is a more logical choice. + */ + if ( (desc->Type != EfiRuntimeServicesData) && + (desc->Type != EfiBootServicesData) ) + return 0; + available_len = len - (esrt - physical_start); + if ( available_len <= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries) ) + return 0; + available_len -= offsetof(EFI_SYSTEM_RESOURCE_TABLE, Entries); + esrt_ptr = (const EFI_SYSTEM_RESOURCE_TABLE *)esrt; + if ( (esrt_ptr->FwResourceVersion != + EFI_SYSTEM_RESOURCE_TABLE_FIRMWARE_RESOURCE_VERSION) || + !esrt_ptr->FwResourceCount ) + return 0; + if ( esrt_ptr->FwResourceCount > available_len / sizeof(esrt_ptr->Entries[0]) ) + return 0; + + return esrt_ptr->FwResourceCount * sizeof(esrt_ptr->Entries[0]); +} + /* * Include architecture specific implementation here, which references the * static globals defined above. @@ -845,6 +900,8 @@ static UINTN __init efi_find_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, return gop_mode; } +static EFI_GUID __initdata esrt_guid = EFI_SYSTEM_RESOURCE_TABLE_GUID; + static void __init efi_tables(void) { unsigned int i; @@ -868,6 +925,8 @@ static void __init efi_tables(void) efi.smbios = (unsigned long)efi_ct[i].VendorTable; if ( match_guid(&smbios3_guid, &efi_ct[i].VendorGuid) ) efi.smbios3 = (unsigned long)efi_ct[i].VendorTable; + if ( match_guid(&esrt_guid, &efi_ct[i].VendorGuid) ) + esrt = (UINTN)efi_ct[i].VendorTable; } #ifndef CONFIG_ARM /* TODO - disabled until implemented on ARM */ @@ -1051,6 +1110,71 @@ static void __init efi_set_gop_mode(EFI_GRAPHICS_OUTPUT_PROTOCOL *gop, UINTN gop #define INVALID_VIRTUAL_ADDRESS (0xBAAADUL << \ (EFI_PAGE_SHIFT + BITS_PER_LONG - 32)) +static void __init efi_relocate_esrt(EFI_SYSTEM_TABLE *SystemTable) +{ + EFI_STATUS status; + UINTN info_size = 0, map_key, mdesc_size; + void *memory_map = NULL; + UINT32 ver; + unsigned int i; + + for ( ; ; ) + { + status = efi_bs->GetMemoryMap(&info_size, memory_map, &map_key, + &mdesc_size, &ver); + if ( status == EFI_SUCCESS && memory_map != NULL ) + break; + if ( status == EFI_BUFFER_TOO_SMALL || memory_map == NULL ) + { + info_size += 8 * mdesc_size; + if ( memory_map != NULL ) + efi_bs->FreePool(memory_map); + memory_map = NULL; + status = efi_bs->AllocatePool(EfiLoaderData, info_size, &memory_map); + if ( status == EFI_SUCCESS ) + continue; + PrintErr(L"Cannot allocate memory to relocate ESRT\r\n"); + } + else + PrintErr(L"Cannot obtain memory map to relocate ESRT\r\n"); + return; + } + + /* Try to obtain the ESRT. Errors are not fatal. */ + for ( i = 0; i < info_size; i += mdesc_size ) + { + /* + * ESRT needs to be moved to memory of type EfiRuntimeServicesData + * so that the memory it is in will not be used for other purposes. + */ + void *new_esrt = NULL; + size_t esrt_size = get_esrt_size(memory_map + i); + + if ( !esrt_size ) + continue; + if ( ((EFI_MEMORY_DESCRIPTOR *)(memory_map + i))->Type == + EfiRuntimeServicesData ) + break; /* ESRT already safe from reuse */ + status = efi_bs->AllocatePool(EfiRuntimeServicesData, esrt_size, + &new_esrt); + if ( status == EFI_SUCCESS && new_esrt ) + { + memcpy(new_esrt, (void *)esrt, esrt_size); + status = efi_bs->InstallConfigurationTable(&esrt_guid, new_esrt); + if ( status != EFI_SUCCESS ) + { + PrintErr(L"Cannot install new ESRT\r\n"); + efi_bs->FreePool(new_esrt); + } + } + else + PrintErr(L"Cannot allocate memory for ESRT\r\n"); + break; + } + + efi_bs->FreePool(memory_map); +} + static void __init efi_exit_boot(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) { EFI_STATUS status; @@ -1413,6 +1537,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE *SystemTable) if ( gop ) efi_set_gop_mode(gop, gop_mode); + efi_relocate_esrt(SystemTable); + efi_exit_boot(ImageHandle, SystemTable); efi_arch_post_exit_boot(); /* Doesn't return. */ @@ -1753,3 +1879,12 @@ void __init efi_init_memory(void) unmap_domain_page(efi_l4t); } #endif + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 11 23:36:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 23:36:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365402.595547 (Exim 4.92) (envelope-from ) id 1oB2wi-0004sa-WA; Mon, 11 Jul 2022 23:36:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365402.595547; Mon, 11 Jul 2022 23:36:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2wi-0004sT-TN; Mon, 11 Jul 2022 23:36:08 +0000 Received: by outflank-mailman (input) for mailman id 365402; Mon, 11 Jul 2022 23:36:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2wh-0004sJ-6f; Mon, 11 Jul 2022 23:36:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2wh-0004VS-4E; Mon, 11 Jul 2022 23:36:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB2wg-0006BE-Kl; Mon, 11 Jul 2022 23:36:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oB2wg-0004iJ-KK; Mon, 11 Jul 2022 23:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4wpph2sxTB6SGlxxbnU0lT5ZBunCMN0xqf5+YVQuh7E=; b=iDubdFAk6CUWcwB4oqDyUez+7W vDkbOzTa3edoSCZW3Ni55UDVjW8i7TY6D5s1/uV8bgWiuZs2xZHLRl92dwpz1Kthik/ZHNjZXrZnd LAF2lnNeexi5QjeEfrZb7EWgiKSnJEuFZlw8zwSUpIGsYTt+2RbKEV855iHfgPariyhs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171583: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=2ce11ce249a3981bac50914c6a90f681ad7a4222 X-Osstest-Versions-That: xen=980bfb1ac9247e95790e283dbc03e231e02cced9 From: osstest service owner Date: Mon, 11 Jul 2022 23:36:06 +0000 flight 171583 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171583/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 171578 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171578 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171578 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171578 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171578 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171578 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171578 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171578 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171578 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171578 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171578 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171578 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171578 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 2ce11ce249a3981bac50914c6a90f681ad7a4222 baseline version: xen 980bfb1ac9247e95790e283dbc03e231e02cced9 Last test of basis 171578 2022-07-11 01:53:21 Z 0 days Testing same since 171583 2022-07-11 14:37:01 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Christian Lindig Dario Faggioli Jan Beulich Jane Malalane Juergen Gross Julien Grall Michal Orzel Téo Couprie Diaz jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 980bfb1ac9..2ce11ce249 2ce11ce249a3981bac50914c6a90f681ad7a4222 -> master From xen-devel-bounces@lists.xenproject.org Mon Jul 11 23:43:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 11 Jul 2022 23:43:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365411.595559 (Exim 4.92) (envelope-from ) id 1oB34G-0006QT-Pg; Mon, 11 Jul 2022 23:43:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365411.595559; Mon, 11 Jul 2022 23:43:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB34G-0006QM-Mt; Mon, 11 Jul 2022 23:43:56 +0000 Received: by outflank-mailman (input) for mailman id 365411; Mon, 11 Jul 2022 23:43:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB34E-0006QC-UY; Mon, 11 Jul 2022 23:43:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB34E-0004kL-R6; Mon, 11 Jul 2022 23:43:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB34E-0006LT-A7; Mon, 11 Jul 2022 23:43:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oB34E-0004Wx-9d; Mon, 11 Jul 2022 23:43:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GaXnYK6XetoRerq8NqPZYRk7bbgMrLRSy+ImW0DcwMc=; b=S3piarZ9jDP4EnITwxzv5JVFcl VqBu/lL6t3ZzzZauYbDxB937dPZxIjBSCzsZLiDh58RuCywTif2655YxqWK7OyYBGJBMY9MB8fT05 3ucQ0/QJ77uP9wggQLWcpFnkQLK098C3cVZ5sbCQTok+JENhbyCId7BovScEtsOMUUGM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171585: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=816e51dfb5ba47e4f989af656c956a8c0cc686c0 X-Osstest-Versions-That: linux=32346491ddf24599decca06190ebca03ff9de7f8 From: osstest service owner Date: Mon, 11 Jul 2022 23:43:54 +0000 flight 171585 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171585/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171577 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171577 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171577 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171577 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171577 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171577 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171577 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171577 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 816e51dfb5ba47e4f989af656c956a8c0cc686c0 baseline version: linux 32346491ddf24599decca06190ebca03ff9de7f8 Last test of basis 171577 2022-07-11 00:12:06 Z 0 days Testing same since 171585 2022-07-11 17:41:38 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Williamson Jason Gunthorpe Linus Torvalds Oleg Nesterov Xiang Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 32346491ddf2..816e51dfb5ba 816e51dfb5ba47e4f989af656c956a8c0cc686c0 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Jul 12 01:31:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 01:31:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365420.595570 (Exim 4.92) (envelope-from ) id 1oB4k3-0008VY-9v; Tue, 12 Jul 2022 01:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365420.595570; Tue, 12 Jul 2022 01:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4k3-0008VR-4S; Tue, 12 Jul 2022 01:31:11 +0000 Received: by outflank-mailman (input) for mailman id 365420; Tue, 12 Jul 2022 01:31:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4k1-0008VL-Ew for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 01:31:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2063.outbound.protection.outlook.com [40.107.22.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48be38bd-0182-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 03:31:02 +0200 (CEST) Received: from AS8PR04CA0177.eurprd04.prod.outlook.com (2603:10a6:20b:331::32) by AM0PR08MB3953.eurprd08.prod.outlook.com (2603:10a6:208:125::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Tue, 12 Jul 2022 01:30:57 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::a3) by AS8PR04CA0177.outlook.office365.com (2603:10a6:20b:331::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Tue, 12 Jul 2022 01:30:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 01:30:56 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Tue, 12 Jul 2022 01:30:56 +0000 Received: from bac5efc7466e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 02FCC95A-28A5-44B5-A2B7-090401E43518.1; Tue, 12 Jul 2022 01:30:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bac5efc7466e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 01:30:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB6PR08MB2840.eurprd08.prod.outlook.com (2603:10a6:6:1d::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Tue, 12 Jul 2022 01:30:48 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 01:30:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48be38bd-0182-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=eZaP8kAM6XmXHjF4xuIEczFHCGVLBKWsk63tlHAjx18EhbKM5wtEKfM01fK+zsrlnQM/oP2yxkbwQPQf5lmjhEVYgWw6VUyc0GUb0GLh6ZsRHLekwazLmsI9KadAUbvwp/LawyDTI5wU2QBzagAAE+elyMd9mPY0D85XA9tIhGTzVuNetwnqLWyJ1O30Hntxhh5gJ5Fj8HrnU5knwDrVDsGEcSeYepfQkk1EJmxg7Ziez9TQoe1sO+TOMpXWnScMe8bpme5V/TpobIdb0ZIF/8XRNWMl5zbVOZN1V3VvBPcxeZmn8lnKMLySNO6cHSsUdZwmqE55p/d6BfZgKHrD3w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZm4P0pKM5l8ZCssCdLz88CROqVho728ZmqjUw+NHf8=; b=L8ZsvcTQ1NmOBunSqJzYhFpUI82FMZtR/eBIv9Qg/NJ8aVt6IXbIslpv8J8LDl8ulPnyrWITRPCO31sg0zg8eoaLbnSJ2rjOHj2YupTRhYajLOZVSP7BXEllDxmrKK9e82AcyVRqioD1B6xM0Iq/U1uVVtoW5yY3Q212Ma+ErBTHPQkS2smnZ8JXmhs8PYy3VKgr0VTtRx3m7TbudgMPe1AsDn7SktViWSfzNh+5rAAPdZO/eb354CkTsaz6eevQ2w2GXvsE488/QOEyTsyy2VOwVJcUnEsmwtAxBWhbnOHUTB1LyF+1XAJHDhHVmMgQ/Mi5aoOQwWXWC2w7vtI7oA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZm4P0pKM5l8ZCssCdLz88CROqVho728ZmqjUw+NHf8=; b=dTci7TBnqJV2UPTIGfmPPMq+57y5w32FduPaKkHl6joHL3OWt7mLADIxsqQr9GqXjfbpqOZ43uhmWpxAzULGvfotHrfdESbLMHcEvvDg0lXADTTgDSeLeEQbmvh/RpDxeXJiyvjGl3nApxu0rJq3OGH/zh2uap02OxUnfEfEfU0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aqRVMAW0HlSc7R9WuoEBgdO6r+t1BUeh3ZJpW8rrn+HQVxgd4RzK2NlbU6p8aCEsI6IQbY2eqnqJrQJAzNkqg+7dGehIhV08xWOKcgjI4rPd+BB9hCp6lj9eKx/UQZGrZwstqMeTUYsKBU9MONGkQul89kZMJbVdQk6q0YRrF3jt92ia9tw1lmGTlkFHePC1NddEzDqWDC63eRTgoI2J+SJWpeVYd2TZxPtdUEzMN6p7scaSqrZJq1sFuE28gA8W8B0yLpv+Uj9wlV3CbzLyrtH/j9+14EgUrJFxrsiwW3Qo/599qWrJOctIBLIz6as5b2x5qSsXSh0jTuiArqg5XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qZm4P0pKM5l8ZCssCdLz88CROqVho728ZmqjUw+NHf8=; b=ZXZNlj2KKVjU9TKcTTTh1mPY4BKUTo7pI/M+MoT2lwzqEMLuR3CMYB3yhMdEzJrkfjMdn5IxGFrp0Y2LRHbEh0Q9yuCibIJZ19Ip8M1JNoTYl0dFtuWJvZCwBcSHPTk9m3xFV8hMThPQWcl6a6wlZ98ZQtPkl7e6grH504HdNt64tpw2RHmCQGhwI/LccDEseaQIYMA+Ke/iwJL6h/HRq8+Rf37DbO/1dkhtK9FtbI9Fq1UbvufcINtHsWh4g9K0LZ/thcykFoItOxDFCuf+07EoSKJMsoK0iS3OiB4LL0tvIhUNer9fQCc9l59EiyiIrNe/4IPpXnSlI0Do7nJQuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qZm4P0pKM5l8ZCssCdLz88CROqVho728ZmqjUw+NHf8=; b=dTci7TBnqJV2UPTIGfmPPMq+57y5w32FduPaKkHl6joHL3OWt7mLADIxsqQr9GqXjfbpqOZ43uhmWpxAzULGvfotHrfdESbLMHcEvvDg0lXADTTgDSeLeEQbmvh/RpDxeXJiyvjGl3nApxu0rJq3OGH/zh2uap02OxUnfEfEfU0= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Daniel De Graaf , "Daniel P. Smith" , Wei Liu Subject: RE: [XEN PATCH v3 14/25] tools/flask/utils: list build targets in $(TARGETS) Thread-Topic: [XEN PATCH v3 14/25] tools/flask/utils: list build targets in $(TARGETS) Thread-Index: AQHYh+TN8UAfR3xALEOagCOUzkkyT616DePg Date: Tue, 12 Jul 2022 01:30:47 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-15-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-15-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C52C8E0B40C1F645B9BDF649B8F995BE.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 914ac633-5c5c-462d-fad7-08da63a62b05 x-ms-traffictypediagnostic: DB6PR08MB2840:EE_|AM5EUR03FT047:EE_|AM0PR08MB3953:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 3UyoFeUm6fSlZcZtbIze8MRccIaKjDdTS0djnew6Y8aLOAl2/c0tLmjzz0TpvuM3jxJklGgJH+nPoda1dFKeLIltCsp+Ae3qCdti+ftNWLg73JHSlcHOAViqir4TwXUQOopgk6+OdjaGObT4GLV4wjSWRc6Q1aQFkiwnfxzgV8K3LLnW30J5gBapeFkTpH8kl2Bq1pTwC1MAvryg4E2yNVLtnDOxDucqUuzf7SiZPIokeY57M2GHilihPCBk96ksy7wmuMwz5MuzSpaUjwYYA/08e7dqAhKF0j+SY7fPOMcAWShn7sRnBj0mari/SXj1E99yus77dKrpJZjAiggT4ihy3DToANEBBXCDDxOat0MNqQK172yDTRoKdiNU6LEaX8eVCAdXjMPZ16ccWzl0i9TKaB3/pkFLpcN9EJ9PnhbfDCaLqI2msqhLe1c7MtKSYrWFIURY0qpLN199nphmVcVj22HemKNj41AgUdRxRnlSQp41FD6lYU7ra8pl0MzDq0F2oFVLCZagrX65/8BAkcvbReWD60aaRjuc7PDCrqVvpnd+gBM/2hFbwhryeKchuP3rTtLnxIVP/7r0pblX94JxojWzc0AaBla5FRzfzcsDQdEp6hFZx4C5goaprf57wYB1YCrynS/G0kL0RK998Sj8pGkiwnJopyNxlBaMGTycPIMoXJsHs3cBZFy1q1ttApJxsTnqksVhzQUZJEKcjzPaXB0CnjF25/+8a5fTB/kJP8rRb+3gTws9rKqcRa7jjPVxUYfeOJXI7ohu+1NQuX8yTfKUUpG9KdwGNQxqm2GMKgUWkdrg7BjC1qkKRwtzz0KWis0FDb8cLAGHeAROqNm19/EdxmjpL+f7jlPcmpk7Brd8jA8m1LRT7RI+8q90 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(366004)(396003)(346002)(38100700002)(55016003)(186003)(122000001)(33656002)(4326008)(316002)(9686003)(64756008)(66476007)(76116006)(110136005)(5660300002)(66946007)(71200400001)(66556008)(8676002)(66446008)(83380400001)(41300700001)(6506007)(52536014)(86362001)(26005)(478600001)(7696005)(8936002)(2906002)(54906003)(38070700005)(4744005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2840 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3ed62c41-f535-40da-e084-08da63a62600 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Xg1UoDGDMyx4QSX1PbP2xI4mENjGqhvopv3YRrinMqMxL/TmmxnkD4I4OI7Gmg3x/wX3I8QBhHVRfkNMJxGfBxhd44b8FMkuS+JaS6ohrKL32CQcWPHWaD7dq6hiFKyONV82n6N+LzJmrUXUINGOyI2gpWW/eNZjRM0zEisOiYcgNA/gFr+JMNrXT4SNN9Nx0LtGC2n5Tq7w6L/SUbz48OJqv2c2/IE5S8iAJ+8welNvaPWlkAyi5ETrqJkX4k9AxBUQHK38Np331uz/4OlaCv6+PsEPRVLIlQRu6BCKMKbGApLndeC1HFkhY0X5/KbUuU1wHI80NrR2hASejROjBSRLUglZ3Hc37q8ViFkk29YWJG/lLanxXF/MF8iA2VluFwrxwVY3p8SkcUgY9ia582WGUXjyraQLxtyhszghd0QGbQwAfH+WlrIQuaRfJiHd/07soR2PmIa0FSsv3Vv4JJPSKiyA3vny7Mm9tEKGXIqKxj2BW4Gg8eHRji5VZdv7wqvee/8HzQNCkxGc5Jgdo84O8LGIQGYgk7y0qKNxTZdvhLya1naizJJ7yqGr6ysx7NNyy++Sv+Mqb7W5Afl77GfI6+T1pQC4F+KwoWUDwKdxijb+QJtgUhcjqZ1n+O6/b8I60ODKh8YvPsEM5xr0HEzfT13h4/o9i0Ih4OPuWK/oWOfHS3DyFJDfCzQGohIq7EApav6F7+oZUNZlEoaOHh9IGeWR/U+JNXehCDZQ3XWtHT9MSq5ueh2tZIS82A+bqkFYExp9i2qbLTswXe7MtyWCenZL3KFkZothEUYGQtNjV9UXzePgvbSORW0WtXRq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(346002)(376002)(46966006)(36840700001)(40470700004)(70206006)(8676002)(70586007)(4326008)(86362001)(478600001)(41300700001)(26005)(8936002)(7696005)(5660300002)(356005)(81166007)(82740400003)(9686003)(110136005)(52536014)(316002)(54906003)(33656002)(36860700001)(2906002)(47076005)(40460700003)(336012)(55016003)(40480700001)(83380400001)(186003)(4744005)(6506007)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 01:30:56.3254 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 914ac633-5c5c-462d-fad7-08da63a62b05 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3953 Hi Anthony, > -----Original Message----- > Subject: [XEN PATCH v3 14/25] tools/flask/utils: list build targets in > $(TARGETS) >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Henry Wang Kind regards, Henry > --- > tools/flask/utils/Makefile | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) From xen-devel-bounces@lists.xenproject.org Tue Jul 12 01:32:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 01:32:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365423.595581 (Exim 4.92) (envelope-from ) id 1oB4kz-0000ax-KZ; Tue, 12 Jul 2022 01:32:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365423.595581; Tue, 12 Jul 2022 01:32:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4kz-0000aq-FP; Tue, 12 Jul 2022 01:32:09 +0000 Received: by outflank-mailman (input) for mailman id 365423; Tue, 12 Jul 2022 01:32:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4ky-0000Vk-9E for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 01:32:08 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2070.outbound.protection.outlook.com [40.107.104.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71050352-0182-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 03:32:07 +0200 (CEST) Received: from AM6P192CA0077.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:8d::18) by DB7PR08MB3659.eurprd08.prod.outlook.com (2603:10a6:10:4a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Tue, 12 Jul 2022 01:32:04 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8d:cafe::35) by AM6P192CA0077.outlook.office365.com (2603:10a6:209:8d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 01:32:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 01:32:03 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Tue, 12 Jul 2022 01:32:03 +0000 Received: from 19b741affa19.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 43CCB285-CD40-45AB-B39E-D90B95F0C5BA.1; Tue, 12 Jul 2022 01:31:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 19b741affa19.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 01:31:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VE1PR08MB5040.eurprd08.prod.outlook.com (2603:10a6:803:114::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Tue, 12 Jul 2022 01:31:55 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 01:31:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71050352-0182-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nd0dtO0X+jpma8hKdUz1irZYJ1tNF9paWx4HPMKCOPIW5TQh19qzgD1Aw9F6nEkNk2uNNtUdGnuRavVf9p5VJyxCAncbaJj81xTNabPv3MLitZ7cA1Ooch/LilcNeExqO/aO+UsGB9n+MHCAQSm8OArLF9WdMSc87ZZFsyleS68bMy+4xFJb7O/spfE+G9r9eBUKzVf2t7MJ7NFxL71VkAb8JBpCrbsTVvwQe0bnl4te28PZTmH6deGxs4zRpZUOqfttyXjKbHykU3+GbvboORCjk4kPYIj9XbNfcEe1Hp1/m1MEE/Dx7uqJdBN4TpYpnJim/V6+M2448An9qwjX1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pLbnfL+Gz9SPmEBz9QaoaqJdo6noPN1TKLPKQ7V4kI=; b=jmc3Q1kGlKuWYhVFkYTxcZxv14y1o8SA1G74TyvU92+oLAOHgE0q42J8Qe5vyVyveNis8zOVMJ5X7fw6IRoc7getGSBBTGb1ToRbW+GjcSFtFWywm2ZrStCENo8iPZ9Ty79D9yS/OfWJYtlPYxVFEHseE9UAwujzuNWh4C3iPvULmQovG1Sqmg2qo0MGAHNQNcW7TbNX/hO+3SyYF1NXiwVNKfE49k/GUKIHz8la5UCVjnMPwFDirmQM9k7QT63Rt9DtAz8RvxQGQo0Mz/3xchnPsE+vDi/Ud8o+A121MvDFrAVFMwxN7hdnPmiraQgjSQ0TJkJAdWxv5UyreDt6jQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pLbnfL+Gz9SPmEBz9QaoaqJdo6noPN1TKLPKQ7V4kI=; b=98CHtEmTd6Nq40CDyiL+GDgU3+dV2rqkY5Cw+YN5GnS+jQx/XRNlJHXx/VS9zOzH2Mv2R/7B0uQ8PZuhnsGSoug6E0G4J53c1QaSswpc95e93vdufGmjK6wCNghiS+4Ew051EjcGgfyzBAtudf+0+FlOzTIOQAjG+ouEvGx5A/c= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fxtSGsfSU9uiguPvfvbcs7N1QfZTNTIlJETAE2WnfFawyg2pvRx/o5eU4G3Hzw94GG7ZN3tQq864izmxBqP8EN5nr0PIPHpP253pZNykQxpGiF1bPPVCgr9JSq6xA+RdzcTVYz+TB+4HtB/sj5uAVedMEwEh8uNHeCcTw6D80UCFXWa5ndfNekANB4s/w/xysduolFv+/7B8zFcA31MZudXobu6SpAt8dww1737ij4f7at25NfBluUpbPWRpsjVqOD44GvE9lUzzWKD99MPI+J2cTIlIh8c0EzK5juVYCwv2ig78byRQdEiRZuJSSLUz6XKQeQ/h3FIPMRqysWPMfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pLbnfL+Gz9SPmEBz9QaoaqJdo6noPN1TKLPKQ7V4kI=; b=GOicARoFCtieSmYqeZh8qYWWMLE4Ce+DamYjxVnNfrRgH+xkV7L52o7dxnuIPwrqBPv39OwTPVjBUQ2iAAztOPX+hRramcZL2yDbUzR09Q1KGgtzLD1jfAF73ZFDLogGLbY5fWyCr3f1Epu90+xt4TPGR3ySfwzThFNWc4AL8/ICbWX1ZaKqxqae74r/XYrtooI2YfHO5OTRGjX/D+5qZsuef1BldZMSPVKiUb04C7TQDpGvyBssazFU6qcgeG91ptaP5jNB8Z+zG4q4nr/Kn17yaOpduGpNfNWOCJ/QgbzfB7eZjDkI1Hq5VRos4sSoMY6KFpxxWaSJWvOddb7s5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pLbnfL+Gz9SPmEBz9QaoaqJdo6noPN1TKLPKQ7V4kI=; b=98CHtEmTd6Nq40CDyiL+GDgU3+dV2rqkY5Cw+YN5GnS+jQx/XRNlJHXx/VS9zOzH2Mv2R/7B0uQ8PZuhnsGSoug6E0G4J53c1QaSswpc95e93vdufGmjK6wCNghiS+4Ew051EjcGgfyzBAtudf+0+FlOzTIOQAjG+ouEvGx5A/c= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Wei Liu Subject: RE: [XEN PATCH v3 23/25] tools/helpers: Fix build of xen-init-dom0 with -Werror Thread-Topic: [XEN PATCH v3 23/25] tools/helpers: Fix build of xen-init-dom0 with -Werror Thread-Index: AQHYh+TiIM174Jj4iU+QhvgrADwspK16Dl7Q Date: Tue, 12 Jul 2022 01:31:55 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-24-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-24-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 7B376912EE31D94D8E84D8533FEAE039.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 920b0f5b-4800-43b4-964a-08da63a652e7 x-ms-traffictypediagnostic: VE1PR08MB5040:EE_|VE1EUR03FT027:EE_|DB7PR08MB3659:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FdxuZDDOr9uGIGmtVsxRgJvCoj5d0lgihmm0qgk7DBTAcYr0Ru/tqnKSJ4M3o/l5PU6JFvlWGrb5B/+AX8bRsZ40MRdZFahSttvxIHpi9hCtY7YbqtcCnKPOqBmHQOtHpgzwpfOFb5dVaN5kkMjJOHN7UvUno0ehZ90PKKSwRAr2IDMpGoPi6QzFDL9EnHiDQHb7oYPnmfvA9ZxCfJPOoz5fSaJCCycsR71ubblIUnIJKx+1/aDl/aQmUo3sn7BNbZYDbIXw5vM1yUCgfvq2iqCZjCy+HC/5GfUKiYqkHixrD1QkSQLlGSEbDUzJVOUwicPi3pcjB2KTnFzfzBzONM/vgASF5naGm4+4ThBLxk5zsI3UIX18xPgjBvjRfk7clTAvbUMYPIJI3+F5GhvbTpd3vx5CEt3t7I0H7P1Jb6v5VW3FlT19FKN1lpMG4xdU5ReeUPfublsPu5drSm0XTcYf9jYUKfiMtl7Wd8NJPHw1ssszwMS1zCMUuMB6YjJZ6xuq1TiMv2KyRZOP5wAsGcBiiWZT+JN5FYZ8WGqxsHlOfL8RTRlawgueyYLTFS0IfTG1UnOGC7QW46dkduDotU03+mK0xg4NHFn0L5o1u3QXqutmEzElfojiRGeob9YbptJ7V94ZzLnbkVXDr5XKVKLzf+fdOCoQZYDAr/H7V2F7DduSPnQmkCtpyhn08MEK6CaCelTv3/WxiK52/540AZWpJvmVrHog2Y0xqsE7tb/pWxRGYnWTz0YkFk1gKgK+C+lMQkDkvGKDzLhLGrMngbmtihcLwrhf7nB0oa4lxLlG0HPlY3OGRukLMrXGNFGA X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(38100700002)(41300700001)(2906002)(122000001)(5660300002)(4744005)(33656002)(6506007)(38070700005)(86362001)(7696005)(478600001)(8936002)(66946007)(52536014)(186003)(66446008)(55016003)(66476007)(71200400001)(110136005)(8676002)(4326008)(26005)(9686003)(83380400001)(64756008)(76116006)(316002)(66556008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5040 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 34db3638-0857-49b5-3d85-08da63a64e02 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mefvf8APbG/N6HTeMXfM2uRbDtaiSPP4uxxTannrKNlzbb5MndKvFohJcjeRV+uHx8GE9+IZIE1/IUoh7P+8G/n9Ifky689znmOEEyhE761D7SBi7TDvJww7Y3jpN7QlIlyq6Y74unaqA5Vi4ve4pof8nAyDoa+cVTXKHnVGEgw3gnhkrKziNEblaqJHeGilvzCC0WBSEzzM9G/99D+jBbIc35Ka8b0MPx4paW4AD9AGmsDaARu3GPpMilcf6ELYz3/gAlY33hT6gEji3xb9kEr5EtUiyWVv+vS6tx6SJTzcxmKif6jNfgSM7IvnqAumLTBJkGmkIdLyU28ZxUBCbKOW5pSwxUSzGbHBYyn/h3zgibsmuVL7lkCFo+gcbzFz9nefU56f9xBNoLJrczTkSl7JH7aQ+tzU1jJifi6cOQw2toZgJ3gMmu3bVVp/dpjzCrgRPdA5XPKiBM6MY4mTpBNDPuf3mDAeSWZuMlgY0uQs5kCME98nfh4FVdhpNnK//iObTu0sYysPgwMpledUqiekHEV23jNrEm2JPplfXrrxIFge4Uyur9eoy+s+fCN8pn8wqq/NMrhujCZV50cELA8Hb3LxSLY7zY7rTsqiWilI8EdBNdEKs6M3+WBr5Wgs8YFFvj8xvFN7M91WRZCYwdyJwAnnBclbLoNGeTcWTkWhbDK7+GSPKGrZLi5y4o3iD3BMYOVjCmJU+cGcgL9uCO5Ch1CrHeZ9W27adUNggs6+q4ZN5Bh8FenpLcFA+MF1imrmV3hxdHkbkAiMoTPFyC0xth86GEqbOFiZllxMHoZMfbfOmzN0RN1NqnL96l0J X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(346002)(136003)(36840700001)(46966006)(40470700004)(82740400003)(81166007)(83380400001)(4744005)(356005)(36860700001)(40460700003)(5660300002)(52536014)(8936002)(47076005)(41300700001)(336012)(186003)(82310400005)(55016003)(40480700001)(2906002)(478600001)(70586007)(7696005)(6506007)(26005)(9686003)(70206006)(316002)(86362001)(8676002)(110136005)(4326008)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 01:32:03.1882 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 920b0f5b-4800-43b4-964a-08da63a652e7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3659 Hi Anthony, > -----Original Message----- > Subject: [XEN PATCH v3 23/25] tools/helpers: Fix build of xen-init-dom0 w= ith > -Werror >=20 > Missing prototype of asprintf() without _GNU_SOURCE. >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Henry Wang Kind regards, Henry > --- > tools/helpers/xen-init-dom0.c | 2 ++ > 1 file changed, 2 insertions(+) From xen-devel-bounces@lists.xenproject.org Tue Jul 12 01:41:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 01:41:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365433.595592 (Exim 4.92) (envelope-from ) id 1oB4tk-0002FV-Hv; Tue, 12 Jul 2022 01:41:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365433.595592; Tue, 12 Jul 2022 01:41:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4tk-0002FF-CT; Tue, 12 Jul 2022 01:41:12 +0000 Received: by outflank-mailman (input) for mailman id 365433; Tue, 12 Jul 2022 01:41:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4tj-0002F9-3T for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 01:41:11 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2084.outbound.protection.outlook.com [40.107.20.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b3ff7abc-0183-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 03:41:09 +0200 (CEST) Received: from AM5PR0301CA0029.eurprd03.prod.outlook.com (2603:10a6:206:14::42) by PA4PR08MB6096.eurprd08.prod.outlook.com (2603:10a6:102:eb::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 01:41:06 +0000 Received: from VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::9) by AM5PR0301CA0029.outlook.office365.com (2603:10a6:206:14::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Tue, 12 Jul 2022 01:41:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT015.mail.protection.outlook.com (10.152.18.176) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 01:41:04 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Tue, 12 Jul 2022 01:41:04 +0000 Received: from ec2e6dd7fafc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 070DAB9D-01A4-4675-8DDE-E74EDE146D33.1; Tue, 12 Jul 2022 01:40:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ec2e6dd7fafc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 01:40:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by AM6PR08MB3703.eurprd08.prod.outlook.com (2603:10a6:20b:83::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Tue, 12 Jul 2022 01:40:56 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 01:40:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3ff7abc-0183-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Xsl/UstWMds+D/XkwvfnKCv53zQlxJ5AjlPSd2y6ZgnbaZNsxy6R+Zee16bkeE0pNyP3OR7wz5hLHwq1CLNliXzGlMvKXlTgea4QVQpp+HG8btJi9XFE9r0E9ajyo/6vJpDfks0sOu/cxisxYI3wUgY++chEiEhGOpQHWFIAAuUG4wf+cZiHo9Kqd71KMP1zdshV4QpVVDbjOWBRqakaCtbICUUSfABLf61IbsZvVMVsPRcjrfz2LAnsNjl4VXelgErspsad/rExNyXZbUFKQ6LsWRr8YOphdZfSTvlFqUh613Z+0HbHixRWw/alJ7oQrWANeK1aSNtihGGKz9zerA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4EVgc0I8vrHt/l3xKDeulj8wo44gRll98CWbAr/wB0=; b=Q7yuqMVXJIVkNobGPgS84V80QGcEGLZZxYmg5im1gvDDId4xUe4NzEkz2WoAq0D1TsVhakChaDbt3NPVkG1ACu/jIankVChyQBfnWlm1GK/F63O7oU0nhsgqbCPL/J2O+xJc6mMbU3L9MEAwJ3uvRAF6D0P1SeBeGI12OjZTgNSU8+S5syYlQyNT3rByDKKSbuufSKSAl3uuLS0jT+rW6Dc6yRKcx3fK9p2ecX+XqgLqKWSj9J6t38QLpkFRhNfVievE86grD86UWMedEmDsQQXe3DMtjrtjrQ8TC1iShEspZkLzkQj3w62HOo8txGKyAN/1DeT82tGsISTZ8SzPxQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4EVgc0I8vrHt/l3xKDeulj8wo44gRll98CWbAr/wB0=; b=TVv/FIwDFhOJIRiajQf2tipWAuPXeJ+zRbwLmqQEf0i4Vhtmdzy137JrtYhi9CWL1pyp3EI+bRPUe5ZN3TYcEFYz1oOTnKuRT9Qzw15ERsMCAwyiF7zK7G8wskIdfZaa8ot/AkpP2+JKRUKqBpMPU+BpyAMpScRdgfdHMBa4LuM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SahODHvnr4Nr+YnkrSWC4/djNeR29I1i3aZKLWuFoOd1/T8m8PGx1mLsJT+zLGnnVZzbMKmv0l4NahYnOB6DFeByUwSaUqFO7qiJb4GETysZEmvFjKYTxbeU3KSw/dRUtWpd802l+M/dk6KsDBlsRvP7PlmQgO01Q/vFb5fMcun69l3wXauaYj8lGlqiibAgwWnJRDZWrGS4dZN0WsESdJD4WCgdMPG2W7M02QsXK+RedVYgFIYozGCuUJI5uKJopL+MdZQWigDLpJg8JlvwubGAFC+E57vv/WMmZmUPS4mWH2cnBrlaHamI0ShNam538ANtrphlyD0Tm3PVvF+/zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L4EVgc0I8vrHt/l3xKDeulj8wo44gRll98CWbAr/wB0=; b=PaDPd3+OYGeuyAZgqQ3ITFjfiWn5Dkc17HqePHfbT/DKjZy2GrsQuKcypTIjB6WlHkBNc5OhwFz4yxil4O9uhGe9nD9PpQv0KzaoqE2Bz0GVm2WnCrSrsrNq5o/L90uYAE00V6LCsru+th+WjacomEG+/JDkzohTP8RWTDm3bBJ+jOs9cYbbkyap1jHCs2MATdLBM3BDBe1xJhQBPtEp36K7mLTV29zqW/zjBAxQuzpmKLdmNpvSNI7X2j3Hxiz1IKHO7N/SXHlvvpoz5FCxxPKjofXpuCeYfD7HnFAV9NZHV3WzE3jXJt99HTJedgCj31gOaQ90ys90YNVCH6Kbng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L4EVgc0I8vrHt/l3xKDeulj8wo44gRll98CWbAr/wB0=; b=TVv/FIwDFhOJIRiajQf2tipWAuPXeJ+zRbwLmqQEf0i4Vhtmdzy137JrtYhi9CWL1pyp3EI+bRPUe5ZN3TYcEFYz1oOTnKuRT9Qzw15ERsMCAwyiF7zK7G8wskIdfZaa8ot/AkpP2+JKRUKqBpMPU+BpyAMpScRdgfdHMBa4LuM= From: Henry Wang To: Anthony PERARD , "xen-devel@lists.xenproject.org" CC: Wei Liu , Nick Rosbrook Subject: RE: [XEN PATCH v3 20/25] tools: Introduce $(xenlibs-ldflags, ) macro Thread-Topic: [XEN PATCH v3 20/25] tools: Introduce $(xenlibs-ldflags, ) macro Thread-Index: AQHYh+TOfU5dsFm/sEOUOCdWz1aYvK16EN1A Date: Tue, 12 Jul 2022 01:40:56 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-21-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-21-anthony.perard@citrix.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4DAB08760A148645A0A36438A1616838.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 26756e56-73c3-4171-7e2f-08da63a795bf x-ms-traffictypediagnostic: AM6PR08MB3703:EE_|VE1EUR03FT015:EE_|PA4PR08MB6096:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 8vomCpHkWRp77cjQY4NMWIEoJQ+AeDtsKKy3jl72b09PMWo485FIzjACI27kayHMjNmXLzoy4jGtiSPhqF+eui6saL8MsUpQUo4fn5Cf9kp3W2itIdxQClDHhzlpxzvuwADZYo+RLQpgI5vLEtUZfFenkJwiHh7WRhPkrKmSMU32gq2g52d7bVnasONsqzV5+78ss40DNKudAm8YX5IAfMWHECNqIA2k4WxjGGysPYRS6rCXHFruBzHLc5o0RS3M8HbMAdG1D9r3eu++pBzmmpVjgClSdqJbCZLrqO4l0aGXDMVRDGRbeIy/NzPNrOrUd2i5oAPyzGOVQOJ2DjCi/2qfl+E9qEUVljWAQA75YCTYact+dQaTQYweU6n1FWGprHIELBBgB5xlFlE3PMDoevdKj78xJjco7bCr9tNLeSfOOXtAyVMVlWH7eurCyQ+72uQqWhyw74ITJaDViS+VawSjYr2Q1CpQBXae8tVbmiD5kSi3A2ftGlYjy2gf0gmm6WCbfgTOdnGd+3VTyDUH/7ooJ6BevnlrjyxPbcTKAXpZ5LJexWGDZidwMBktyVBx5vTHlp0xz0u4G7fNRh+4xSJRU4XYW5ZQgMr78ChsYj4TOxipHm+mj1fKG0LsGSmMbJ4dxcQ0AUuySaYZMuqyNpRJ4m2H2e37boAw/wCvf7PbF8YpzToLebf+dY5v9QFwp2dXAUc3gBxPhQPy2tKq1Hwt5Mdd4oPmkIIRaq0eIqAl+wkB3ueTScFqJFyzYJdDUIgyxWToIV6vFSuHU6jmZqzBNvZ/36fulR8pQtjUarSOX/YDtaVmX/qIXCofjDUi X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(366004)(346002)(39860400002)(396003)(38070700005)(52536014)(33656002)(86362001)(122000001)(55016003)(26005)(7696005)(9686003)(38100700002)(66946007)(8676002)(478600001)(110136005)(54906003)(66476007)(66556008)(186003)(41300700001)(4326008)(66446008)(71200400001)(76116006)(64756008)(4744005)(8936002)(2906002)(6506007)(5660300002)(316002)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3703 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a5eacc6-a98f-4393-d965-08da63a790e2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8+ABfBB0lxhr4U4Cwkd8td3EDCJGhy41CPIrFbxkLsg6L5sIbvDMF5iTesptlbZj23kiezr7YN0IIKytV4SeilTD0svdfH9BS5AvSRUtEdsVjAwCTbfvkaBaWzero8NEmEzLa2X+fqwf2ba2uKJbQKVVDPzuHYCdNs18/cDXHv/X3f6kkfxwnL4TurSaVxZcfzny8+1x62Ym7ddKvCtVdeOGnvELhYzKF6zKbQ216rohHRX/tyaY8OxJt18SnUhztD4iovEeNF1Lr/ziSBr6bJn3xCm29PUcvCzQaKI3d+KjeB1HzxdbjirCNjeKut0IooCjmmawumQTSiFPAehvkmfPBcu0VqqFbAO3Bk/VFcIs3zZ7unNT9IxndnjSuhbEu6NnQJvJrzLgVV+uhbxKv5SbGffit8DqxnCduG0iRbNDfL7jckkkt12l4dnwU9Iuwkkx1Bl71XWYViy4i0zmWjqnIxWe0sJppyDadBuWbxFLl7BFufsVsy8n41F4ME1kbLt14APR2CNCQrlCWJSA1vJ6KXe69IMFY6DLYdtbR7yM64zULLJsoQZJy2mOoYLP0ergkfsUim6E5WqITmm8W0z/TMcEgLr5Vft7wAESU0d5AX4Ghl2XO/RW1WnEFlkexqPdCGbxezuOLqhOaUqFb+XIqHZfVOLJMc7tSvps7ytchCKQLEbZTlxwP5Ll3s2PfWCrYdCiAFLgU0z6qMmpT9InOHFeN0fKH9YRd99aFpxymSC2eGhHeK3PrWu/D2sOKez4vtbpx03ua/iw3a5OAJqDElraLU+wBoAEwYm/N9owYZyNaoRE5tK63KWRrRu1 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(396003)(46966006)(36840700001)(40470700004)(33656002)(52536014)(55016003)(4744005)(186003)(107886003)(54906003)(36860700001)(478600001)(81166007)(8936002)(40480700001)(82740400003)(26005)(336012)(47076005)(5660300002)(356005)(40460700003)(8676002)(86362001)(6506007)(2906002)(7696005)(41300700001)(70586007)(70206006)(83380400001)(82310400005)(4326008)(110136005)(316002)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 01:41:04.8295 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 26756e56-73c3-4171-7e2f-08da63a795bf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6096 Hi Anthony, > -----Original Message----- > Subject: [XEN PATCH v3 20/25] tools: Introduce $(xenlibs-ldflags, ) macro >=20 > This avoid the need to open-coding the list of flags needed to link > with an in-tree Xen library when using -lxen*. >=20 > Signed-off-by: Anthony PERARD Reviewed-by: Henry Wang Kind regards, Henry > --- > tools/golang/xenlight/Makefile | 2 +- > tools/Rules.mk | 8 ++++++++ From xen-devel-bounces@lists.xenproject.org Tue Jul 12 01:43:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 01:43:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365440.595603 (Exim 4.92) (envelope-from ) id 1oB4w8-0002tG-0f; Tue, 12 Jul 2022 01:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365440.595603; Tue, 12 Jul 2022 01:43:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4w7-0002t9-TZ; Tue, 12 Jul 2022 01:43:39 +0000 Received: by outflank-mailman (input) for mailman id 365440; Tue, 12 Jul 2022 01:43:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB4w5-0002t3-V2 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 01:43:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70083.outbound.protection.outlook.com [40.107.7.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bb75094-0184-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 03:43:36 +0200 (CEST) Received: from AS8PR04CA0202.eurprd04.prod.outlook.com (2603:10a6:20b:2f3::27) by AS8PR08MB7012.eurprd08.prod.outlook.com (2603:10a6:20b:34f::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Tue, 12 Jul 2022 01:43:33 +0000 Received: from AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:2f3:cafe::a) by AS8PR04CA0202.outlook.office365.com (2603:10a6:20b:2f3::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Tue, 12 Jul 2022 01:43:33 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT022.mail.protection.outlook.com (10.152.16.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 01:43:32 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Tue, 12 Jul 2022 01:43:32 +0000 Received: from f49caaf6e81a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6A6EC749-4D8D-47EB-9663-DEAC5891E158.1; Tue, 12 Jul 2022 01:43:26 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f49caaf6e81a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 01:43:26 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AS8PR08MB6646.eurprd08.prod.outlook.com (2603:10a6:20b:350::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 01:43:19 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 01:43:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bb75094-0184-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hUZhH407C34sfqikBofl5uiVDtFcThlKBJG/0I0SgCOrJQ4jwM+Yz/GnysC6euYmYOGRnFL17Y3pM4iKvtAnfMBgy7WQjLplw6+t7gp+zVNOGF500d2CJ7GdnBkH2baoiQnAP/TXA7mwtSXPJ45vHncCJRmLXNmT8SCJUl0T6jaEHPTTwa8jnLCPvWaxL5wOCdSmyo8j79taUih0Tc8spoyozRZSo7rdIZet+5YOkiVGaZA4RkzhsJLfnYkV9kXw9QwA1YQwH4ccgPYGcwTsNtDx9I3YyuSMOO+5l8XXeI8HqE2D1ZS6thKobeqryQkwcbEEBujF5HVa3M9lXWlK2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SB9F1ZZRgZdEPktXpqTNvwz1ZSbqBj/WF4JFNlD/V4E=; b=YTdxVBTUmS8F9m9Fd3oUvl0Ie9mFOnpQazCb/mZAwDxR5P9+d6s3oD4+ihTlz3wHdr6wtLFrckQLNg7Hj1jq4wafbF5K/Zz3wZZkK/3CvBvPuuwrfRO2ubL7Ls5ot1MMbbaNoKdceRPXf4BWeoK1o1WYYPh87fWuudBx5cg1RRNr2d/tVgez3h/wS5zSdFHTYZm55tEE8k9GT7fyzCwEPxhA8fKSbPzi/vRS9pzKRN5oHWw+xG80+E2W6w5jTDGSCm+OAvtrpyRfYpnCeTlpXIzfLQmvgvwfrUoat/m6aGiNQni9vEjsvtQbq2z5l3uVdc3ulTotRtcuk8A1JHQflQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SB9F1ZZRgZdEPktXpqTNvwz1ZSbqBj/WF4JFNlD/V4E=; b=dDOAbNFXYV8W7br2tLe7TRZepRj4gqv4DmTK/j63pC7dkEqF9cxAQKXBAu7UWVAclPIwGogzzp73+69NIqkBEApKyVCeF8XezvLcMGRzLrba6Beaats4KHQ373KnlQGEpT3ps2KEZjf1ai6qEUh7iU6D+qUrRIVupUpriSxkQ84= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrN7/IUcV9v1TVJBTAE7zolGx2DvUVfIbr0JxOZ4kfqD6SF24/5bRitodRnyrQbIhNHVXvCH9a3mp687MCDrE/4inGTWMnix2CEiUrQm3PQrJVdqHezfB01Q/JSQTWOIRc9W0kd6U5H+nf/SB0ERpIT7wjzIcSBZMxsas2Tok3LMyJNhMYiSuK6zHSC5W7wZuBCKFf8b48/8lkhPyec4BRw1Xr1GMljwpOVoj537dxj62dgLABSvjBPbe+WgxWc//yRghtKwnJDm7XmevwWjIw2PRzL8zNigzDjp394jSS9gv/AmQGXacq5yEfhN+k4wvNbI47eS0Sj3e7TP97ZUkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SB9F1ZZRgZdEPktXpqTNvwz1ZSbqBj/WF4JFNlD/V4E=; b=R9LfNWR5edCwJi6tKHjjrRvthtefFHeC+UNL0yE7xh/xzhdmYirbmpOLwdpxoQxbt+fOSzdtgISOKGZbSKKhvPGMVOvPR24f7gaygT4j5adRKSIhSDaRBkWxBpphhLmdt/ShsvxFQ1JQOgbmo7XCmXB+A1rOpQtIAkHXlyjz+e8gt7NssKP3K3Fosl3BGlpRpriu9nNVtcQDteVKk63wl0G/b5wGyCu9o7KlF7a/dP10Gsle2XyavW78oAX9bBXBREp/DNcKl+1b3jUT9/9tG2U89ug/cj7gA1XAWA7co71UWUJowFkrGbUUkb6uDAQxMIhg/rr2dww2zgqnvgCXaQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SB9F1ZZRgZdEPktXpqTNvwz1ZSbqBj/WF4JFNlD/V4E=; b=dDOAbNFXYV8W7br2tLe7TRZepRj4gqv4DmTK/j63pC7dkEqF9cxAQKXBAu7UWVAclPIwGogzzp73+69NIqkBEApKyVCeF8XezvLcMGRzLrba6Beaats4KHQ373KnlQGEpT3ps2KEZjf1ai6qEUh7iU6D+qUrRIVupUpriSxkQ84= From: Penny Zheng To: Xenia Ragiadakou , Stefano Stabellini , Julien Grall CC: "xen-devel@lists.xenproject.org" , Doug Goldstein Subject: RE: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Topic: [PATCH 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Index: AQHYkrCrc+1tnxXJvUu1rbw6AP/wja142SUQgAB3XACAAKrgcA== Date: Tue, 12 Jul 2022 01:43:19 +0000 Message-ID: References: <20220707203803.798317-1-burzalodowa@gmail.com> <20220707203803.798317-3-burzalodowa@gmail.com> <259c9042-4a40-ddd3-5e3c-7a1698df74c4@xen.org> <69c1e0e4-f83d-527b-050b-d0760562b3b3@gmail.com> In-Reply-To: <69c1e0e4-f83d-527b-050b-d0760562b3b3@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 57BACB9EDA670747837DFB65374FA36C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9b0b82d5-62ea-423f-ded4-08da63a7edfc x-ms-traffictypediagnostic: AS8PR08MB6646:EE_|AM5EUR03FT022:EE_|AS8PR08MB7012:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?Sjcxa0xHVXpLZHVXc3NpV3c1OW9seUhTMVdubmtJN1cyZTdMdG5HMzdzYmZv?= =?utf-8?B?ZUUyamlNUFl6ZWw4bkZnNkFyNlZHSTN4Z2VaQzFqRmtwMjF3UE9aZmpwbCtW?= =?utf-8?B?QW4za0V0SXJYZUkxNkc4aW5PQlF3K3Evc3NOb3BPNGJwUTNCSWNyVXVJUStY?= =?utf-8?B?aHFURE9JTXRDMS9pdm5jMTlkNEpMYjM1NGVUNnJ1VzNQL0UzSVI4VXZReXd4?= =?utf-8?B?RExDUktXaHh4Y0E3MHFpbUxvRi9DbVFrdDFsUHE0UFRzTWRrY3ZMMnVOTGRz?= =?utf-8?B?cmlvMWY1KzFuNGRpSlR5aVczdWxYWHNkRi82MktBWFZJN3FDOVZnVlViNEJk?= =?utf-8?B?TnFiQTVXM0EzcDNWTTZqenlOeFllTm1aWTR5SDVJMmtNRUpGWFFwSG5VY044?= =?utf-8?B?TUt0Ym1vNkMzWllZV0gwejY5OHBMZGptdTdldktmeENGOXNycW5ZQkRWbGZj?= =?utf-8?B?bEdGNFJlZ1pRck1NeVp2ZS9QaEdTS080SFpzUjdTSktIWHlra0laZk1XeFVm?= =?utf-8?B?TW0rRTR5QU1ZZS9tOENxaXJjYTRwemJwL2gvelBnamJVVSt5cDBHbC8vb0Fk?= =?utf-8?B?enlvRkh1TGF2Ynl3NWlhbUVnaktaV0ZVVjV5dGRqWUZheDROVklIOXp0enV1?= =?utf-8?B?bHNqckRDbGIyQ2JUOFByZ2pLeWJwYXRQOHg4OCtFN3ZzRVVmWkEyWmo0MCtG?= =?utf-8?B?SmplNFZmdUhCVXQ0SjRkaXdsTkhJLzM0Q2hISHkyaWczOHBCUHRvaEREK0Jw?= =?utf-8?B?UEdLVmhJZ0pJVmZwaDMxVkdNdXE2bW55bnZTS0owM0RuaTAyRzlVRWw0UmpB?= =?utf-8?B?MHZlTUNvS2E0VHhpTTdrV0pHSFJLTkVQMTJrZEo4WVdGWHVlV0VtTURnM01X?= =?utf-8?B?Smc4dnBnZnpBZXVVSnd1Ui9yMDN6cU5KU09UZWh2SU5jaFM1a2RDcjRrR0Jw?= =?utf-8?B?Y3NGZC8zQ0lOWFVkcVRYNW1SN3R4bHJiY0ZraWYyREN3ZUhVSlB3LzlKNC9i?= =?utf-8?B?ZTBDTis4Smc0KzJyRWpSdElzU2Rlam9uTW1ENzJCdHBVejJ6N0dLVUhoN3RC?= =?utf-8?B?Tk9uZlU1Q00zTHdYTGhKd3FFelh6NWRYVE0rU2t1a3RHRVFjVEtySmJycEl1?= =?utf-8?B?Y0hVbWdkcjN1VkpWM3ZTdSsrU3lYRzZhUllRTDNqU0kwRmhBVXhQaU9TZzRO?= =?utf-8?B?VGxxZTl0c3poNk1CSXVPckFScDZ1dGN3a2EydnhhQ3JNV1dxc3dXZXNzeTBM?= =?utf-8?Q?9SwB0nDGxXsm2hP?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(316002)(66946007)(38100700002)(76116006)(186003)(64756008)(54906003)(4326008)(55016003)(83380400001)(66556008)(66446008)(66476007)(71200400001)(110136005)(122000001)(478600001)(33656002)(86362001)(6506007)(41300700001)(26005)(966005)(5660300002)(8936002)(2906002)(53546011)(38070700005)(9686003)(52536014)(7696005)(8676002)(21314003)(139555002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6646 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 03af8e79-0e52-490b-1ac3-08da63a7e61c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EzvhUT/7ywQLy2+Wq8/GuYs89YpH9yGu6Tr/2S1Ega+ebE6mFkdBKxnmEWlU7Ukbq6rEjsk06XsWe4DYaA9LnL9483YfJSS+OvxPpsWi2nO9EpuN8CtGIZYhpWXAc+dDpF0b/eWZIkw30PlDEHIVaBrHuhJ6yvzQt2QgnnHFI1e3XuFIIOnoNXrMTVzWyzUvpkyNBxXXiK16juHhHgTyx9onV55YGBiDQR8qnZiaeXlBZFNsjTCIe4OSja+Q3A80h4IqJWZZt3EIDDsfyA8zqM7XmNsq09nG0mj32mk3XHiHR9Y6YyKoUGO7ltiqJw9TSx1GEI7G+pEATOMqWtH8lc087ShPPw+5VxaRDQ3w5UL/ZuyQvtRBh+5FXzaGumnjAEtvNg9Of8kgGVWxqKx6fZBZ0HB0Pi9WPM8d2GfwVLYb58CavnEhC73t5fxj6wk+Sqo7YFgArE6XU3qspv0U8Zm7/f+m+fUTTocrmBnyQO1enbJcJLFNm199AlyLz6VerlNVedHrLcHMQZIFi8Ekt0UFXzF+UDdcCGwGLDFkwkMCMWEXvFyhaDY0Gw6+w87lYtorzeXXZzgeLh96l204h64g3o6MaqiLCfBAmETzh6lTF7xBa6DYXQxdkMwBML+PaWs9fk+qiM1rzj3J3yxMk1+aytIPOF3iU1XjeVSmw3BYaT+YnYBHlOAIsUwgR7ntInEcjJESOC1G4lKBVX1wO2TnMazwgfQLrW3H2AoRk4jtmKuprl6x7T/5AYHjaNfo8yx5e5HEtk92k5PaQ8v1czs0L25rEVfVJwRqAEUt7mGFEWQ5rgQgL+hsCz71z6xFXdrpRkTkvoTClkY/48YGAeShpfywq3IYjTdHrZol4vKxmDZI1/FRbcKAfhkQMdOruXW8wJPcMtlVgSD/Sjk3xiTs6Tovj1aJ9tKRU6QH6+tWpQEOI+1dFl5MppsSgnlm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(54906003)(110136005)(47076005)(336012)(83380400001)(316002)(8676002)(966005)(70586007)(107886003)(33656002)(70206006)(186003)(86362001)(4326008)(82740400003)(53546011)(26005)(52536014)(30864003)(5660300002)(9686003)(356005)(41300700001)(8936002)(6506007)(40460700003)(82310400005)(55016003)(7696005)(478600001)(40480700001)(81166007)(2906002)(36860700001)(21314003)(139555002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 01:43:32.9025 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b0b82d5-62ea-423f-ded4-08da63a7edfc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7012 SGkgWGVuaWENCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBYZW5pYSBS YWdpYWRha291IDxidXJ6YWxvZG93YUBnbWFpbC5jb20+DQo+IFNlbnQ6IE1vbmRheSwgSnVseSAx MSwgMjAyMiAxMToyOSBQTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+ OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4g R3JhbGwgPGp1bGllbkB4ZW4ub3JnPg0KPiBDYzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnOyBEb3VnIEdvbGRzdGVpbiA8Y2FyZG9lQGNhcmRvZS5jb20+DQo+IFN1YmplY3Q6IFJlOiBb UEFUQ0ggMi8yXSBhdXRvbWF0aW9uOiBhcm02NDogQ3JlYXRlIGEgdGVzdCBqb2IgZm9yIHRlc3Rp bmcNCj4gc3RhdGljIGFsbG9jYXRpb24gb24gcWVtdQ0KPiANCj4gSGkgUGVubnksDQo+IA0KPiBP biAxMS83LzIyIDEyOjAyLCBQZW5ueSBaaGVuZyB3cm90ZToNCj4gPiBIaSBYZW5pYQ0KPiA+DQo+ ID4+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+IEZyb206IFhlbi1kZXZlbCA8eGVu LWRldmVsLWJvdW5jZXNAbGlzdHMueGVucHJvamVjdC5vcmc+IE9uIEJlaGFsZiBPZg0KPiA+PiBY ZW5pYSBSYWdpYWRha291DQo+ID4+IFNlbnQ6IEZyaWRheSwgSnVseSA4LCAyMDIyIDU6NTQgUE0N Cj4gPj4gVG86IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47IEp1 bGllbiBHcmFsbA0KPiA+PiA8anVsaWVuQHhlbi5vcmc+DQo+ID4+IENjOiB4ZW4tZGV2ZWxAbGlz dHMueGVucHJvamVjdC5vcmc7IERvdWcgR29sZHN0ZWluDQo+ID4+IDxjYXJkb2VAY2FyZG9lLmNv bT4NCj4gPj4gU3ViamVjdDogUmU6IFtQQVRDSCAyLzJdIGF1dG9tYXRpb246IGFybTY0OiBDcmVh dGUgYSB0ZXN0IGpvYiBmb3INCj4gPj4gdGVzdGluZyBzdGF0aWMgYWxsb2NhdGlvbiBvbiBxZW11 DQo+ID4+DQo+ID4+IEhpIFN0ZWZhbm8sDQo+ID4+DQo+ID4+IE9uIDcvOC8yMiAwMjowNSwgU3Rl ZmFubyBTdGFiZWxsaW5pIHdyb3RlOg0KPiA+Pj4gT24gVGh1LCA3IEp1bCAyMDIyLCBKdWxpZW4g R3JhbGwgd3JvdGU6DQo+ID4+Pj4gSGkgWGVuaWEsDQo+ID4+Pj4NCj4gPj4+PiBPbiAwNy8wNy8y MDIyIDIxOjM4LCBYZW5pYSBSYWdpYWRha291IHdyb3RlOg0KPiA+Pj4+PiBBZGQgYW4gYXJtIHN1 YmRpcmVjdG9yeSB1bmRlciBhdXRvbWF0aW9uL2NvbmZpZ3MgZm9yIHRoZSBhcm0NCj4gPj4+Pj4g c3BlY2lmaWMgY29uZmlncyBhbmQgYWRkIGEgY29uZmlnIHRoYXQgZW5hYmxlcyBzdGF0aWMgYWxs b2NhdGlvbi4NCj4gPj4+Pj4NCj4gPj4+Pj4gTW9kaWZ5IHRoZSBidWlsZCBzY3JpcHQgdG8gc2Vh cmNoIGZvciBjb25maWdzIGFsc28gaW4gdGhpcw0KPiA+Pj4+PiBzdWJkaXJlY3RvcnkgYW5kIHRv IGtlZXAgdGhlIGdlbmVyYXRlZCB4ZW4gYmluYXJ5LCBzdWZmaXhlZCB3aXRoDQo+ID4+Pj4+IHRo ZSBjb25maWcgZmlsZSBuYW1lLCBhcyBhcnRpZmFjdC4NCj4gPj4+Pj4NCj4gPj4+Pj4gQ3JlYXRl IGEgdGVzdCBqb2IgdGhhdA0KPiA+Pj4+PiAtIGJvb3RzIHhlbiBvbiBxZW11IHdpdGggYSBzaW5n bGUgZGlyZWN0IG1hcHBlZCBkb20wbGVzcyBndWVzdA0KPiA+Pj4+PiBjb25maWd1cmVkIHdpdGgg c3RhdGljYWxseSBhbGxvY2F0ZWQgbWVtb3J5DQo+ID4NCj4gPiBBbHRob3VnaCB5b3Ugc2FpZCBi b290aW5nIGEgc2luZ2xlIGRpcmVjdCBtYXBwZWQgZG9tMGxlc3MgZ3Vlc3QNCj4gPiBjb25maWd1 cmVkIHdpdGggc3RhdGljYWxseSBhbGxvY2F0ZWQgbWVtb3J5IGhlcmUsIGxhdGVyIGluIGNvZGUs IHlvdQ0KPiA+IGFyZSBvbmx5IGVuYWJsaW5nIHN0YXRpY2FsbHkgYWxsb2NhdGVkIG1lbW9yeSBp biB0aGUgSW1hZ2VCdWlsZGVyDQo+ID4gc2NyaXB0LCBtaXNzaW5nIHRoZSBkaXJlY3QtbWFwIHBy b3BlcnR5Lg0KPiA+DQo+ID4+Pj4+IC0gdmVyaWZpZXMgdGhhdCB0aGUgbWVtb3J5IHJhbmdlcyBy ZXBvcnRlZCBpbiB0aGUgZ3Vlc3QncyBsb2dzIGFyZQ0KPiA+Pj4+PiB0aGUgc2FtZSB3aXRoIHRo ZSBwcm92aWRlZCBzdGF0aWMgbWVtb3J5IHJlZ2lvbnMNCj4gPj4+Pj4NCj4gPj4+Pj4gRm9yIGd1 ZXN0IGtlcm5lbCwgdXNlIHRoZSA1LjkuOSBrZXJuZWwgZnJvbSB0aGUgdGVzdHMtYXJ0aWZhY3Rz DQo+IGNvbnRhaW5lcnMuDQo+ID4+Pj4+IFVzZSBidXN5Ym94LXN0YXRpYyBwYWNrYWdlLCB0byBj cmVhdGUgdGhlIGd1ZXN0IHJhbWRpc2suDQo+ID4+Pj4+IFRvIGdlbmVyYXRlIHRoZSB1LWJvb3Qg c2NyaXB0LCB1c2UgSW1hZ2VCdWlsZGVyLg0KPiA+Pj4+PiBVc2UgdGhlIHFlbXUgZnJvbSB0aGUg dGVzdHMtYXJ0aWZhY3RzIGNvbnRhaW5lcnMuDQo+ID4+Pj4+DQo+ID4+Pj4+IFNpZ25lZC1vZmYt Ynk6IFhlbmlhIFJhZ2lhZGFrb3UgPGJ1cnphbG9kb3dhQGdtYWlsLmNvbT4NCj4gPj4+Pj4gLS0t DQo+ID4+Pj4+ICAgICBhdXRvbWF0aW9uL2NvbmZpZ3MvYXJtL3N0YXRpY19tZW0gICAgICAgICAg fCAgIDMgKw0KPiA+Pj4+PiAgICAgYXV0b21hdGlvbi9naXRsYWItY2kvdGVzdC55YW1sICAgICAg ICAgICAgIHwgIDI0ICsrKysrDQo+ID4+Pj4+ICAgICBhdXRvbWF0aW9uL3NjcmlwdHMvYnVpbGQg ICAgICAgICAgICAgICAgICAgfCAgIDQgKw0KPiA+Pj4+PiAgICAgYXV0b21hdGlvbi9zY3JpcHRz L3FlbXUtc3RhdGljbWVtLWFybTY0LnNoIHwgMTE0DQo+ID4+ICsrKysrKysrKysrKysrKysrKysr Kw0KPiA+Pj4+PiAgICAgNCBmaWxlcyBjaGFuZ2VkLCAxNDUgaW5zZXJ0aW9ucygrKQ0KPiA+Pj4+ PiAgICAgY3JlYXRlIG1vZGUgMTAwNjQ0IGF1dG9tYXRpb24vY29uZmlncy9hcm0vc3RhdGljX21l bQ0KPiA+Pj4+PiAgICAgY3JlYXRlIG1vZGUgMTAwNzU1IGF1dG9tYXRpb24vc2NyaXB0cy9xZW11 LXN0YXRpY21lbS1hcm02NC5zaA0KPiA+Pj4+Pg0KPiA+Pj4+PiBkaWZmIC0tZ2l0IGEvYXV0b21h dGlvbi9jb25maWdzL2FybS9zdGF0aWNfbWVtDQo+ID4+Pj4+IGIvYXV0b21hdGlvbi9jb25maWdz L2FybS9zdGF0aWNfbWVtDQo+ID4+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNjQ0DQo+ID4+Pj4+IGlu ZGV4IDAwMDAwMDAwMDAuLjg0Njc1ZGRmNGUNCj4gPj4+Pj4gLS0tIC9kZXYvbnVsbA0KPiA+Pj4+ PiArKysgYi9hdXRvbWF0aW9uL2NvbmZpZ3MvYXJtL3N0YXRpY19tZW0NCj4gPj4+Pj4gQEAgLTAs MCArMSwzIEBADQo+ID4+Pj4+ICtDT05GSUdfRVhQRVJUPXkNCj4gPj4+Pj4gK0NPTkZJR19VTlNV UFBPUlRFRD15DQo+ID4+Pj4+ICtDT05GSUdfU1RBVElDX01FTU9SWT15DQo+ID4+Pj4+IFwgTm8g bmV3bGluZSBhdCBlbmQgb2YgZmlsZQ0KPiA+Pj4+DQo+ID4+Pj4gQW55IHBhcnRpY3VsYXIgcmVh c29uIHRvIGJ1aWxkIGEgbmV3IFhlbiByYXRoZXIgZW5hYmxlDQo+ID4+Pj4gQ09ORklHX1NUQVRJ Q19NRU1PUlkgaW4gdGhlIGV4aXN0aW5nIGJ1aWxkPw0KPiA+Pj4+DQo+ID4+Pj4+IGRpZmYgLS1n aXQgYS9hdXRvbWF0aW9uL3NjcmlwdHMvYnVpbGQgYi9hdXRvbWF0aW9uL3NjcmlwdHMvYnVpbGQN Cj4gPj4+Pj4gaW5kZXggMjFiM2JjNTdjOC4uOWM2MTk2ZDliZCAxMDA3NTUNCj4gPj4+Pj4gLS0t IGEvYXV0b21hdGlvbi9zY3JpcHRzL2J1aWxkDQo+ID4+Pj4+ICsrKyBiL2F1dG9tYXRpb24vc2Ny aXB0cy9idWlsZA0KPiA+Pj4+PiBAQCAtODMsNiArODMsNyBAQCBmaQ0KPiA+Pj4+PiAgICAgIyBC dWlsZCBhbGwgdGhlIGNvbmZpZ3Mgd2UgY2FyZSBhYm91dA0KPiA+Pj4+PiAgICAgY2FzZSAke1hF Tl9UQVJHRVRfQVJDSH0gaW4NCj4gPj4+Pj4gICAgICAgICB4ODZfNjQpIGFyY2g9eDg2IDs7DQo+ ID4+Pj4+ICsgICAgYXJtNjQpIGFyY2g9YXJtIDs7DQo+ID4+Pj4+ICAgICAgICAgKikgZXhpdCAw IDs7DQo+ID4+Pj4+ICAgICBlc2FjDQo+ID4+Pj4+ICAgICBAQCAtOTMsNCArOTQsNyBAQCBmb3Ig Y2ZnIGluIGBscyAke2NmZ19kaXJ9YDsgZG8NCj4gPj4+Pj4gICAgICAgICBybSAtZiB4ZW4vLmNv bmZpZw0KPiA+Pj4+PiAgICAgICAgIG1ha2UgLUMgeGVuIEtCVUlMRF9ERUZDT05GSUc9Li4vLi4v Li4vLi4vJHtjZmdfZGlyfS8ke2NmZ30NCj4gZGVmY29uZmlnDQo+ID4+Pj4+ICAgICAgICAgbWFr ZSAtaiQobnByb2MpIC1DIHhlbg0KPiA+Pj4+PiArICAgIGlmIFtbICR7YXJjaH0gPT0gImFybSIg XV07IHRoZW4NCj4gPj4+Pj4gKyAgICAgICAgY3AgeGVuL3hlbiBiaW5hcmllcy94ZW4tJHtjZmd9 DQo+ID4+Pj4+ICsgICAgZmkNCj4gPj4+Pg0KPiA+Pj4+IFRoaXMgZmVlbHMgYSBiaXQgb2YgYSBo YWNrIHRvIGJlIGFybSBvbmx5LiBDYW4geW91IGV4cGxhaW4gd2h5IHRoaXMNCj4gPj4+PiBpcyBu b3QgZW5hYmxlZCBmb3IgeDg2IChvdGhlciB0aGFuIHRoaXMgaXMgbm90IHlldCB1c2VkKT8NCj4g Pj4+Pg0KPiA+Pj4+PiAgICAgZG9uZQ0KPiA+Pj4+PiBkaWZmIC0tZ2l0IGEvYXV0b21hdGlvbi9z Y3JpcHRzL3FlbXUtc3RhdGljbWVtLWFybTY0LnNoDQo+ID4+Pj4+IGIvYXV0b21hdGlvbi9zY3Jp cHRzL3FlbXUtc3RhdGljbWVtLWFybTY0LnNoDQo+ID4+Pj4+IG5ldyBmaWxlIG1vZGUgMTAwNzU1 DQo+ID4+Pj4+IGluZGV4IDAwMDAwMDAwMDAuLjViODlhMTUxYWENCj4gPj4+Pj4gLS0tIC9kZXYv bnVsbA0KPiA+Pj4+PiArKysgYi9hdXRvbWF0aW9uL3NjcmlwdHMvcWVtdS1zdGF0aWNtZW0tYXJt NjQuc2gNCj4gPj4+Pj4gQEAgLTAsMCArMSwxMTQgQEANCj4gPj4+Pj4gKyMhL2Jpbi9iYXNoDQo+ ID4+Pj4+ICsNCj4gPj4+Pj4gK2Jhc2U9KDB4NTAwMDAwMDAgMHgxMDAwMDAwMDApDQo+ID4+Pj4+ ICtzaXplPSgweDEwMDAwMDAwIDB4MTAwMDAwMDApDQo+ID4+Pj4NCj4gPj4+PiAgIEZyb20gdGhl IG5hbWUsIGl0IGlzIG5vdCBjbGVhciB3aGF0IHRoZSBiYXNlIGFuZCBzaXplIHJlZmVycyB0b28u DQo+ID4+Pj4gTG9va2luZyBhIGJpdCBiZWxvdywgaXQgc2VlbXMgdG8gYmUgcmVmZXJyaW5nIHRv IHRoZSBkb21haW4gbWVtb3J5Lg0KPiA+Pj4+IElmIHNvLCBJIHdvdWxkIHN1Z2dlc3QgdG8gY29t bWVudCBhbmQgcmVuYW1lIHRvICJkb211X3tiYXNlLCBzaXplfSIuDQo+ID4+Pj4NCj4gPj4+Pj4g Kw0KPiA+Pj4+PiArc2V0IC1leA0KPiA+Pj4+PiArDQo+ID4+Pj4+ICthcHQtZ2V0IC1xeSB1cGRh dGUNCj4gPj4+Pj4gK2FwdC1nZXQgLXF5IGluc3RhbGwgLS1uby1pbnN0YWxsLXJlY29tbWVuZHMg dS1ib290LXFlbXUgXA0KPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB1LWJvb3QtdG9vbHMgXA0KPiA+Pj4+PiArICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBkZXZpY2UtdHJlZS1jb21waWxlciBcDQo+ID4+Pj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNwaW8gXA0KPiA+Pj4+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjdXJsIFwNCj4g Pj4+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgYnVzeWJv eC1zdGF0aWMNCj4gPj4+Pj4gKw0KPiA+Pj4+PiArIyBEb21VIEJ1c3lib3gNCj4gPj4+Pj4gK2Nk IGJpbmFyaWVzDQo+ID4+Pj4+ICtta2RpciAtcCBpbml0cmQNCj4gPj4+Pj4gK21rZGlyIC1wIGlu aXRyZC9iaW4NCj4gPj4+Pj4gK21rZGlyIC1wIGluaXRyZC9zYmluDQo+ID4+Pj4+ICtta2RpciAt cCBpbml0cmQvZXRjDQo+ID4+Pj4+ICtta2RpciAtcCBpbml0cmQvZGV2DQo+ID4+Pj4+ICtta2Rp ciAtcCBpbml0cmQvcHJvYw0KPiA+Pj4+PiArbWtkaXIgLXAgaW5pdHJkL3N5cw0KPiA+Pj4+PiAr bWtkaXIgLXAgaW5pdHJkL2xpYg0KPiA+Pj4+PiArbWtkaXIgLXAgaW5pdHJkL3Zhcg0KPiA+Pj4+ PiArbWtkaXIgLXAgaW5pdHJkL21udA0KPiA+Pj4+PiArY3AgL2Jpbi9idXN5Ym94IGluaXRyZC9i aW4vYnVzeWJveCBpbml0cmQvYmluL2J1c3lib3ggLS1pbnN0YWxsDQo+ID4+Pj4+ICtpbml0cmQv YmluIGVjaG8gIiMhL2Jpbi9zaA0KPiA+Pj4+PiArDQo+ID4+Pj4+ICttb3VudCAtdCBwcm9jIHBy b2MgL3Byb2MNCj4gPj4+Pj4gK21vdW50IC10IHN5c2ZzIHN5c2ZzIC9zeXMNCj4gPj4+Pj4gK21v dW50IC10IGRldnRtcGZzIGRldnRtcGZzIC9kZXYNCj4gPj4+Pj4gKy9iaW4vc2giID4gaW5pdHJk L2luaXQNCj4gPj4+Pj4gK2NobW9kICt4IGluaXRyZC9pbml0DQo+ID4+Pj4+ICtjZCBpbml0cmQN Cj4gPj4+Pj4gK2ZpbmQgLiB8IGNwaW8gLS1jcmVhdGUgLS1mb3JtYXQ9J25ld2MnIHwgZ3ppcCA+ IC4uL2luaXRyZC5jcGlvLmd6DQo+ID4+Pj4+ICtjZCAuLi8uLg0KPiA+Pj4+PiArDQo+ID4+Pj4+ ICsjIFhYWCBRRU1VIGxvb2tzIGZvciAiZWZpLXZpcnRpby5yb20iIGV2ZW4gaWYgaXQgaXMgdW5u ZWVkZWQgY3VybA0KPiA+Pj4+PiArLWZzU0xPDQo+ID4+Pj4+ICtodHRwczovL2dpdGh1Yi5jb20v cWVtdS9xZW11L3Jhdy92NS4yLjAvcGMtYmlvcy9lZmktdmlydGlvLnJvbQ0KPiA+Pj4+PiArDQo+ ID4+Pj4+ICsuL2JpbmFyaWVzL3FlbXUtc3lzdGVtLWFhcmNoNjQgLW5vZ3JhcGhpYyBcDQo+ID4+ Pj4+ICsgICAgLU0gdmlydHVhbGl6YXRpb249dHJ1ZSBcDQo+ID4+Pj4+ICsgICAgLU0gdmlydCBc DQo+ID4+Pj4+ICsgICAgLU0gdmlydCxnaWMtdmVyc2lvbj0yIFwNCj4gPj4+Pj4gKyAgICAtY3B1 IGNvcnRleC1hNTcgXA0KPiA+Pj4+PiArICAgIC1zbXAgMiBcDQo+ID4+Pj4+ICsgICAgLW0gOEcg XA0KPiA+Pj4+PiArICAgIC1NIGR1bXBkdGI9YmluYXJpZXMvdmlydC1naWN2Mi5kdGINCj4gPj4+ Pj4gKw0KPiA+Pj4+PiArI2R0YyAtSSBkdGIgLU8gZHRzIGJpbmFyaWVzL3ZpcnQtZ2ljdjIuZHRi ID4NCj4gPj4+Pj4gK2JpbmFyaWVzL3ZpcnQtZ2ljdjIuZHRzDQo+ID4+Pj4+ICsNCj4gPj4+Pj4g KyMgSW1hZ2VCdWlsZGVyDQo+ID4+Pj4+ICtybSAtcmYgaW1hZ2VidWlsZGVyDQo+ID4+Pj4+ICtn aXQgY2xvbmUgaHR0cHM6Ly9naXRsYWIuY29tL1ZpcnlhT1MvaW1hZ2VidWlsZGVyDQo+ID4+Pj4+ ICsNCj4gPj4+Pj4gK2VjaG8gIk1FTU9SWV9TVEFSVD1cIjB4NDAwMDAwMDBcIg0KPiA+Pj4+PiAr TUVNT1JZX0VORD1cIjB4MDIwMDAwMDAwMFwiDQo+ID4+Pj4+ICsNCj4gPj4+Pj4gK0RFVklDRV9U UkVFPVwidmlydC1naWN2Mi5kdGJcIg0KPiA+Pj4+PiArDQo+ID4+Pj4+ICtYRU49XCJ4ZW4tc3Rh dGljX21lbVwiDQo+ID4+Pj4+ICtYRU5fQ01EPVwiY29uc29sZT1kdHVhcnQgZWFybHlwcmludGsg eHNtPWR1bW15XCINCj4gPj4+Pg0KPiA+Pj4+IEFGQUlLLCBlYXJseXByaW50ayBpcyBub3QgYW4g b3B0aW9uIGZvciBYZW4gb24gQXJtIChhdCBsZWFzdCkuIEl0DQo+ID4+Pj4gaXMgYWxzbyBub3Qg Y2xlYXIgd2h5IHlvdSBuZWVkIHRvIHBhc3MgeHNtPWR1bW15Lg0KPiA+Pj4+DQo+ID4+Pj4+ICsN Cj4gPj4+Pj4gK05VTV9ET01VUz0xDQo+ID4+Pj4+ICtET01VX01FTVswXT01MTINCj4gPj4+Pj4g K0RPTVVfVkNQVVNbMF09MQ0KPiA+Pj4+PiArRE9NVV9LRVJORUxbMF09XCJJbWFnZVwiDQo+ID4+ Pj4+ICtET01VX1JBTURJU0tbMF09XCJpbml0cmQuY3Bpby5nelwiDQo+ID4+Pj4+ICtET01VX0NN RFswXT1cImVhcmx5cHJpbnRrIGNvbnNvbGU9dHR5QU1BMFwiDQo+ID4+Pj4+ICtET01VX1NUQVRJ Q19NRU1bMF09XCIke2Jhc2VbMF19ICR7c2l6ZVswXX0gJHtiYXNlWzFdfQ0KPiAke3NpemVbMV19 XCINCj4gPj4+Pj4gKw0KPiA+DQo+ID4gWW91IHdvdWxkIGxpa2UgdG8gYWRkICBET01VX0RJUkVD VF9NQVBbMF0gPSAxIHRvIGVuYWJsZSBkaXJlY3QtbWFwLg0KPiANCj4gVGhlIGltYWdlYnVpbGRl ciBjb25maWd1cmF0aW9uIG9wdGlvbiBET01VX0RJUkVDVF9NQVAgZGVmYXVsdHMgdG8gMS4NCj4g DQo+IEJ1dCBJIGNvdWxkIGFkZCBET01VX0RJUkVDVF9NQVBbMF09MSBpbiB0aGUgc2NyaXB0IHRv IG1ha2UgaXQgY2xlYXJlci4NCj4gDQoNCk9oLCBzb3JyeSBhYm91dCB0aGF0LiBUaGVuIGV2ZXJ5 dGhpbmcgaXMgc2V0IGNsZWFybHkgZm9yIG1lfn5+DQoNCj4gPj4+Pj4gK1VCT09UX1NPVVJDRT1c ImJvb3Quc291cmNlXCINCj4gPj4+Pj4gK1VCT09UX1NDUklQVD1cImJvb3Quc2NyXCIiID4gYmlu YXJpZXMvaW1hZ2VidWlsZGVyX2NvbmZpZw0KPiA+Pj4+PiArDQo+ID4+Pj4+ICtiYXNoIGltYWdl YnVpbGRlci9zY3JpcHRzL3Vib290LXNjcmlwdC1nZW4gLXQgdGZ0cCAtZCBiaW5hcmllcy8NCj4g Pj4+Pj4gKy1jDQo+ID4+Pj4+IGJpbmFyaWVzL2ltYWdlYnVpbGRlcl9jb25maWcNCj4gPj4+Pj4g Kw0KPiA+Pj4+PiArIyBSdW4gdGhlIHRlc3QNCj4gPj4+Pj4gK3JtIC1mIHFlbXUtc3RhdGljbWVt LnNlcmlhbA0KPiA+Pj4+PiArc2V0ICtlDQo+ID4+Pj4+ICtlY2hvICIgIHZpcnRpbyBzY2FuOyBk aGNwOyB0ZnRwYiAweDQwMDAwMDAwIGJvb3Quc2NyOyBzb3VyY2UNCj4gPj4+Pj4gKzB4NDAwMDAw MDAifCBcIHRpbWVvdXQgLWsgMSA2MCAuL2JpbmFyaWVzL3FlbXUtc3lzdGVtLWFhcmNoNjQgLQ0K PiA+PiBub2dyYXBoaWMgXA0KPiA+Pj4+PiArICAgIC1NIHZpcnR1YWxpemF0aW9uPXRydWUgXA0K PiA+Pj4+PiArICAgIC1NIHZpcnQgXA0KPiA+Pj4+PiArICAgIC1NIHZpcnQsZ2ljLXZlcnNpb249 MiBcDQo+ID4+Pj4+ICsgICAgLWNwdSBjb3J0ZXgtYTU3IFwNCj4gPj4+Pj4gKyAgICAtc21wIDIg XA0KPiA+Pj4+PiArICAgIC1tIDhHIFwNCj4gPj4+Pj4gKyAgICAtbm8tcmVib290IFwNCj4gPj4+ Pj4gKyAgICAtZGV2aWNlIHZpcnRpby1uZXQtcGNpLG5ldGRldj12bmV0MCAtbmV0ZGV2DQo+ID4+ Pj4+ICt1c2VyLGlkPXZuZXQwLHRmdHA9YmluYXJpZXMNCj4gPj4+Pj4gXA0KPiA+Pj4+PiArICAg IC1iaW9zIC91c3IvbGliL3UtYm9vdC9xZW11X2FybTY0L3UtYm9vdC5iaW4gXA0KPiA+Pj4+PiAr ICAgIC1kdGIgLi9iaW5hcmllcy92aXJ0LWdpY3YyLmR0YiBcDQo+ID4+Pj4+ICsgICAgfCYgdGVl IHFlbXUtc3RhdGljbWVtLnNlcmlhbA0KPiA+Pj4+PiArDQo+ID4+Pj4+ICtzZXQgLWUNCj4gPj4+ Pg0KPiA+Pj4+IEEgbG90IG9mIHRoZSBjb2RlIGFib3ZlIGlzIGR1cGxpY2F0ZWQgZnJvbSBxZW11 LXNtb2tlLWFybTY0LnNoLiBJDQo+ID4+Pj4gdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIGNv bnNvbGlkYXRlIGluIGEgc2luZ2xlIHNjcmlwdC4gTG9va2luZw0KPiA+Pj4+IGJyaWVmbHkgdGhy b3VnaHQgdGhlIGV4aXN0aW5nIHNjcmlwdHMsIGl0IGxvb2tzIGxpa2UgaXQgaXMgcG9zc2libGUN Cj4gPj4+PiB0byBwYXNzIGFyZ3VtZW50cyAoc2VlIHFlbXUtc21va2UteDg2LTY0LnNoKS4NCj4g Pj4+DQo+ID4+PiBPbmUgaWRlYSB3b3VsZCBiZSB0byBtYWtlIHRoZSBzY3JpcHQgY29tbW9uIGFu ZCAic291cmNlIiBhIHNlY29uZA0KPiA+Pj4gc2NyaXB0IG9yIGNvbmZpZyBmaWxlIHdpdGgganVz dCB0aGUgSW1hZ2VCdWlsZGVyIGNvbmZpZ3VyYXRpb24NCj4gPj4+IGJlY2F1c2UgaXQgbG9va3Mg bGlrZSBpdCBpcyB0aGUgb25seSB0aGluZyBkaWZmZXJlbnQuDQo+ID4+Pg0KPiA+Pj4NCj4gPj4+ Pj4gKw0KPiA+Pj4+PiArKGdyZXAgLXEgIlhlbiBkb20wbGVzcyBtb2RlIGRldGVjdGVkIiBxZW11 LXN0YXRpY21lbS5zZXJpYWwpIHx8DQo+ID4+Pj4+ICtleGl0IDENCj4gPj4+Pj4gKw0KPiA+Pj4+ PiArZm9yICgoaT0wOyBpPCR7I2Jhc2VbQF19OyBpKyspKQ0KPiA+Pj4+PiArZG8NCj4gPj4+Pj4g KyAgICBzdGFydD0iJChwcmludGYgIjB4JTAxNngiICR7YmFzZVskaV19KSINCj4gPj4+Pj4gKyAg ICBlbmQ9IiQocHJpbnRmICIweCUwMTZ4IiAkKCgke2Jhc2VbJGldfSArICR7c2l6ZVskaV19IC0g MSkpKSINCj4gPj4+Pj4gKyAgICBncmVwIC1xICJub2RlICAgMDogXFttZW0gJHtzdGFydH0tJHtl bmR9XF0iIHFlbXUtc3RhdGljbWVtLnNlcmlhbA0KPiA+Pj4+PiArICAgIGlmIHRlc3QgJD8gLWVx IDENCj4gPj4+Pj4gKyAgICB0aGVuDQo+ID4+Pj4+ICsgICAgICAgIGV4aXQgMQ0KPiA+Pj4+PiAr ICAgIGZpDQo+ID4+Pj4+ICtkb25lDQo+ID4+Pj4NCj4gPj4+PiBQbGVhc2UgYWRkIGEgY29tbWVu dCBvbiB0b3AgdG8gZXhwbGFpbiB3aGF0IHRoaXMgaXMgbWVhbnQgdG8gZG8uDQo+ID4+Pj4gSG93 ZXZlciwgSSB0aGluayB3ZSBzaG91bGQgYXZvaWQgcmVseWluZyBvbiBvdXRwdXQgdGhhdCB3ZSBo YXZlDQo+ID4+Pj4gd3JpdHRlbiBvdXJzZWxmLiBJT1csIHJlbHlpbmcgb24gWGVuL0xpbnV4IHRv IGFsd2F5cyB3cml0ZSB0aGUgc2FtZQ0KPiA+Pj4+IG1lc3NhZ2UgaXMgcmlza3kgYmVjYXVzZSB0 aGV5IGNhbiBjaGFuZ2UgYXQgYW55IHRpbWUuDQo+ID4+Pg0KPiA+Pj4gRXNwZWNpYWxseSBpZiB3 ZSBtYWtlIHRoZSBzY3JpcHQgY29tbW9uLCB0aGVuIHdlIGNvdWxkIGp1c3QgcmVseSBvbg0KPiA+ Pj4gdGhlIGV4aXN0aW5nIGNoZWNrIHRvIHNlZSBpZiB0aGUgZ3Vlc3Qgc3RhcnRlZCBjb3JyZWN0 bHkgKG5vIHNwZWNpYWwNCj4gPj4+IGNoZWNrIGZvciBzdGF0aWMgbWVtb3J5KS4NCj4gPj4NCj4g Pj4gSW4gdGhpcyBjYXNlLCBob3cgdGhlIHRlc3Qgd2lsbCB2ZXJpZnkgdGhhdCB0aGUgc3RhdGlj IG1lbW9yeQ0KPiA+PiBjb25maWd1cmF0aW9uIGhhcyBiZWVuIHRha2VuIGludG8gYWNjb3VudCBh bmQgaGFzIG5vdCBqdXN0IGJlZW4gaWdub3JlZD8NCj4gPj4NCj4gPg0KPiA+IElmIG9ubHkgc3Rh dGljYWxseSBhbGxvY2F0ZWQgbWVtb3J5IGlzIGVuYWJsZWQsIGd1ZXN0IG1lbW9yeSBhZGRyZXNz DQo+ID4gd2lsbCBzdGlsbCBiZSBtYXBwZWQgdG8gR1VFU1RfUkFNX0JBU0UoMHg0MDAwMDAwMCkN Cj4gPg0KPiA+Pj4+PiArDQo+ID4+Pj4+ICsoZ3JlcCAtcSAiQnVzeUJveCIgcWVtdS1zdGF0aWNt ZW0uc2VyaWFsKSB8fCBleGl0IDENCj4gPj4+DQo+ID4+DQo+ID4+IC0tDQo+ID4+IFhlbmlhDQo+ ID4NCj4gPiAtLS0NCj4gPiBDaGVlcnMsDQo+ID4gUGVubnkgWmhlbmcNCj4gPg0KPiA+DQo+ID4N Cj4gPg0KDQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 12 04:04:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 04:04:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365353.595618 (Exim 4.92) (envelope-from ) id 1oB77s-0001ER-W2; Tue, 12 Jul 2022 04:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365353.595618; Tue, 12 Jul 2022 04:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB77s-0001EK-T3; Tue, 12 Jul 2022 04:03:56 +0000 Received: by outflank-mailman (input) for mailman id 365353; Mon, 11 Jul 2022 18:38:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oAyIY-0007Bg-47 for xen-devel@lists.xen.org; Mon, 11 Jul 2022 18:38:22 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a02e9be4-0148-11ed-924f-1f966e50362f; Mon, 11 Jul 2022 20:38:16 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id sz17so10282307ejc.9 for ; Mon, 11 Jul 2022 11:38:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a02e9be4-0148-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=awSft2fCUC2N8A6hETTYVWbslJCuFnmGc/IyfvOZRQ0=; b=JuTyK++NxpvVf3h0eMBYWMrlTpZdcFwAuff2pyxM6VOXNvMfEVObE/TKkwDuv2DikH A7dPYu9L0Lb6QqXml2J9e2xCEJtJsBnYg4XLwaxfwICvmCs6rLBOZOKDDIv/kf4qgPrj ssI4o8+VZlDSqondqysWHC358xU5efQK7IJhICSdEtnzN0zh6UT4r7P+D1VqEiWtZg0G iZmNGtafNGPVVgfdL4SeXncyKFVX5gmRBID3IMQwo1YFCS0hKlv9sd8L/nlq56SFCXbJ Tpyup8L5tF1RpdRrwjtgGD9aDp9D+ikTvsCNrHIiN4klOHjmRzJP4J4FuQLaf2aTuiug ijbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=awSft2fCUC2N8A6hETTYVWbslJCuFnmGc/IyfvOZRQ0=; b=kUTbwX/EoET5lZ/n98LxZuBzLlT68Uqx1qw2mGVJSjFfNgLIxhc1dGIHgWUzqUMZEh Dwbt7pebvY/IBszZvoGnrx6ZyRTz9NlvhNPfJUDuKaY8ZWzcW307Tck6gEslHQTV9V6d ZL/yF0hudYrHt1cZ78axB3ChAvNNaSElCerIPH02Pgart/BkRWAmJglhITsnPQI07iK4 5ZqCqsVRC8HBntwZbGPLHUu+GPJe6JiLRCgHGmduAsKr7t4vtPUD7kvi+bQN2oKKTK/Y DrQWFO+9IMpmjSUMyWrSIfi0BMKuRUkWgmYTPTbhzC6Ttord8NJB8VmIR0sZX1sayjpA Rorg== X-Gm-Message-State: AJIora+uyJUpet/Hl3wXTJFVcrWrTI7r4mzmSSzqC0Y4Gk5ccI9Zt1C4 uP6imNAk0NTBmEo7PYDG+PCECaBNnjqvJNsjnLk+ZObmcpB0yw== X-Google-Smtp-Source: AGRyM1uIyW97guWFVdSCcgK6dXn9gOzgA/ph67B/PAUsBjhJFvoEbx7aMN17mgkA5/mnvtPZKAdfUG9yI0baoLnPCAE= X-Received: by 2002:a17:907:2d8a:b0:722:e35b:695 with SMTP id gt10-20020a1709072d8a00b00722e35b0695mr20491714ejc.470.1657564693524; Mon, 11 Jul 2022 11:38:13 -0700 (PDT) MIME-Version: 1.0 From: Brad Churchwell Date: Mon, 11 Jul 2022 13:38:02 -0500 Message-ID: Subject: Xen on rk3399 To: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000c00fc105e38bdacc" --000000000000c00fc105e38bdacc Content-Type: text/plain; charset="UTF-8" Hello, I've been trying to get Xen to boot dom0 with my kernel for weeks on an rk3399 based board and thought I'd reach out for help. It looks like either Xen is not properly recreating the device tree or the interrupt controller is just failing. The hypervisor boots but falls to initramfs because it cannot find the root device (nvme on pcie). Any help would be greatly appreciated. Here is the complete boot log DDR Version 1.20 20190314 In soft reset SRX channel 0 CS = 0 MR0=0x98 MR4=0x2 MR5=0xFF MR8=0x10 MR12=0x72 MR14=0x72 MR18=0x0 MR19=0x0 MR24=0x8 MR25=0x0 channel 1 CS = 0 MR0=0x98 MR4=0x2 MR5=0xFF MR8=0x10 MR12=0x72 MR14=0x72 MR18=0x0 MR19=0x0 MR24=0x8 MR25=0x0 channel 0 training pass! channel 1 training pass! change freq to 400MHz 0,1 channel 0 CS = 0 MR0=0x98 MR4=0x2 MR5=0xFF MR8=0x10 MR12=0x72 MR14=0x72 MR18=0x0 MR19=0x0 MR24=0x8 MR25=0x0 channel 1 CS = 0 MR0=0x98 MR4=0x2 MR5=0xFF MR8=0x10 MR12=0x72 MR14=0x72 MR18=0x0 MR19=0x0 MR24=0x8 MR25=0x0 channel 0 training pass! channel 1 training pass! change freq to 800MHz 1,0 Channel 0: LPDDR4,800MHz Bus Width=32 Col=10 Bank=8 Row=16 CS=1 Die Bus-Width=16 Size=2048MB Channel 1: LPDDR4,800MHz Bus Width=32 Col=10 Bank=8 Row=16 CS=1 Die Bus-Width=16 Size=2048MB 256B stride ch 0 ddrconfig = 0x101, ddrsize = 0x40 ch 1 ddrconfig = 0x101, ddrsize = 0x40 pmugrf_os_reg[2] = 0x32C1F2C1, stride = 0xD OUT Boot1: 2018-06-26, version: 1.14 CPUId = 0x0 ChipType = 0x10, 280 Spi_ChipId = ef6017 SpiBootInit:0 mmc0:cmd8,32 mmc0:cmd5,32 mmc0:cmd55,32 mmc0:cmd1,32 mmc0:cmd8,32 mmc0:cmd5,32 mmc0:cmd55,32 mmc0:cmd1,32 mmc0:cmd8,32 mmc0:cmd5,32 mmc0:cmd55,32 mmc0:cmd1,32 SdmmcInit=0 1 StorageInit ok = 23477 SecureMode = 0 SecureInit ret = 0, SecureMode = 0 GPT vendor signature is wrong LoadTrust Addr:0x1800 No find bl30.bin No find bl32.bin Load uboot, ReadLba = 1000 Load OK, addr=0x200000, size=0xc3140 RunBL31 0x10000 NOTICE: BL31: v1.3(debug):0e7a845 NOTICE: BL31: Built : 16:13:46, Apr 17 2019 NOTICE: BL31: Rockchip release version: v1.1 INFO: GICv3 with legacy support detected. ARM GICV3 driver initialized in EL3 INFO: Using opteed sec cpu_context! INFO: boot cpu mask: 0 INFO: plat_rockchip_pmu_init(1181): pd status 3e INFO: BL31: Initializing runtime services WARNING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE initialization. SMC`s destined for OPTEE will return SMC_UNK ERROR: Error initializing runtime service opteed_fast INFO: BL31: Preparing for EL3 exit to normal world INFO: Entry point address = 0x200000 INFO: SPSR = 0x3c9 U-Boot 2021.10 (Jul 11 2022 - 11:32:57 -0500) SoC: Rockchip rk3399 Reset cause: RST Model: Vamrs RK3399 ZAKU DRAM: 3.9 GiB PMIC: RK808 MMC: mmc@fe310000: 3, mmc@fe330000: 0 Loading Environment from FAT... In: serial Out: serial Err: serial Model: Vamrs RK3399 ZAKU Net: No ethernet found. Hit any key to stop autoboot: 0 zaku => zaku => run boot_pci_enum; run nvme_init; fatload nvme 0:1 0x02000000 xen-uImage; fatload nvme 0:1 0x01f00000 rk3399-zaku.dtb; 1114184 bytes read in 8 ms (132.8 MiB/s) 57153 bytes read in 5 ms (10.9 MiB/s) zaku => fatload nvme 0:1 0x03F80000 Image;fatload nvme 0:1 0x06000000 initrd.img-5.15.16-1-rockchip-g359ffc4bc727;bootm 0x02000000 - 0x00 27885576 bytes read in 75 ms (354.6 MiB/s) 8674182 bytes read in 28 ms (295.4 MiB/s) ## Booting kernel from Legacy Image at 02000000 ... Image Name: Image Type: AArch64 Linux Kernel Image (uncompressed) Data Size: 1114120 Bytes = 1.1 MiB Load Address: 02000000 Entry Point: 02000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 01f00000 Booting using the fdt blob at 0x1f00000 Loading Kernel Image Loading Device Tree to 00000000f1efd000, end 00000000f1f0df40 ... OK Starting kernel ... Xen 4.17-unstable (XEN) Xen version 4.17-unstable (root@) (aarch64-linux-gnu-gcc (Linaro GCC 7.3-2018.05) 7.3.1 20180425 [linaro-7.3-2018.05 revision d2912 (XEN) Latest ChangeSet: (XEN) build-id: aaba62ac5bc435965722c47224a16d44f95847b9 (XEN) Processor: 00000000410fd034: "ARM Limited", variant: 0x0, part 0xd03,rev 0x4 (XEN) 64-bit Execution: (XEN) Processor Features: 0000000001002222 0000000000000000 (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32 (XEN) Extensions: FloatingPoint AdvancedSIMD GICv3-SysReg (XEN) Debug Features: 0000000010305106 0000000000000000 (XEN) Auxiliary Features: 0000000000000000 0000000000000000 (XEN) Memory Model Features: 0000000000001122 0000000000000000 (XEN) ISA Features: 0000000000011120 0000000000000000 (XEN) 32-bit Execution: (XEN) Processor Features: 0000000000000131:0000000010011011 (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle (XEN) Extensions: GenericTimer Security (XEN) Debug Features: 0000000003010066 (XEN) Auxiliary Features: 0000000000000000 (XEN) Memory Model Features: 0000000010201105 0000000040000000 (XEN) 0000000001260000 0000000002102211 (XEN) ISA Features: 0000000002101110 0000000013112111 0000000021232042 (XEN) 0000000001112131 0000000000011142 0000000000011121 (XEN) Using SMC Calling Convention v1.0 (XEN) Using PSCI v1.0 (XEN) SMP: Allowing 6 CPUs (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 24000 KHz (XEN) GICv3 initialization: (XEN) gic_dist_addr=0x000000fee00000 (XEN) gic_maintenance_irq=25 (XEN) gic_rdist_stride=0 (XEN) gic_rdist_regions=1 (XEN) redistributor regions: (XEN) - region 0: 0x000000fef00000 - 0x000000fefc0000 (XEN) GICv3 compatible with GICv2 cbase 0x000000fff00000 vbase 0x000000fff20000 (XEN) GICv3: 288 lines, (IID 0001143b). (XEN) GICv3: CPU0: Found redistributor in region 0 @000000004001c000 (XEN) XSM Framework v1.0.1 initialized (XEN) Initialising XSM SILO mode (XEN) Using scheduler: SMP Credit Scheduler rev2 (credit2) (XEN) Initializing Credit2 scheduler (XEN) load_precision_shift: 18 (XEN) load_window_shift: 30 (XEN) underload_balance_tolerance: 0 (XEN) overload_balance_tolerance: -3 (XEN) runqueues arrangement: socket (XEN) cap enforcement granularity: 10ms (XEN) load tracking window length 1073741824 ns (XEN) Allocated console ring of 64 KiB. (XEN) CPU0: Guest atomics will try 2 times before pausing the domain (XEN) Bringing up CPU1 (XEN) GICv3: CPU1: Found redistributor in region 0 @000000004003c000 (XEN) CPU1: Guest atomics will try 3 times before pausing the domain (XEN) CPU 1 booted. (XEN) Bringing up CPU2 (XEN) GICv3: CPU2: Found redistributor in region 0 @000000004005c000 (XEN) CPU2: Guest atomics will try 3 times before pausing the domain (XEN) CPU 2 booted. (XEN) Bringing up CPU3 (XEN) GICv3: CPU3: Found redistributor in region 0 @000000004007c000 (XEN) CPU3: Guest atomics will try 3 times before pausing the domain (XEN) CPU 3 booted. (XEN) Bringing up CPU4 (XEN) CPU4 MIDR (0x00000000410fd082) does not match boot CPU MIDR (0x00000000410fd034), (XEN) hmp-unsafe turned on so tainting Xen and keep core on!! (XEN) SANITY DIF: aa64mmfr0 0x1122 -> 0x1124 (XEN) SANITY DIF: ctr 0x84448004 -> 0x8444c004 (XEN) GICv3: CPU4: Found redistributor in region 0 @000000004009c000 (XEN) CPU4: Guest atomics will try 1 times before pausing the domain (XEN) enabled workaround for: ARM erratum 1319537 (XEN) CPU 4 booted. (XEN) Bringing up CPU5 (XEN) CPU5 MIDR (0x00000000410fd082) does not match boot CPU MIDR (0x00000000410fd034), (XEN) hmp-unsafe turned on so tainting Xen and keep core on!! (XEN) SANITY DIF: aa64mmfr0 0x1122 -> 0x1124 (XEN) SANITY DIF: ctr 0x84448004 -> 0x8444c004 (XEN) GICv3: CPU5: Found redistributor in region 0 @00000000400bc000 (XEN) CPU5: Guest atomics will try 1 times before pausing the domain (XEN) Brought up 6 CPUs (XEN) CPU 5 booted. (XEN) I/O virtualisation disabled (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID (XEN) P2M: 3 levels with order-1 root, VTCR 0x0000000080023558 (XEN) Scheduling granularity: cpu, 1 CPU per sched-resource (XEN) Initializing Credit2 scheduler (XEN) load_precision_shift: 18 (XEN) load_window_shift: 30 (XEN) underload_balance_tolerance: 0 (XEN) overload_balance_tolerance: -3 (XEN) runqueues arrangement: socket (XEN) cap enforcement granularity: 10ms (XEN) load tracking window length 1073741824 ns (XEN) Adding cpu 0 to runqueue 0 (XEN) First cpu on runqueue, activating (XEN) Adding cpu 1 to runqueue 0 (XEN) Adding cpu 2 to runqueue 0 (XEN) Adding cpu 3 to runqueue 0 (XEN) Adding cpu 4 to runqueue 0 (XEN) Adding cpu 5 to runqueue 0 (XEN) alternatives: Patching with alt table 00000000002e5388 -> 00000000002e5e74 (XEN) **** No support for ARM_SMCCC_ARCH_WORKAROUND_1. **** (XEN) **** Please update your firmware. **** (XEN) *** LOADING DOMAIN 0 *** (XEN) Loading d0 kernel from boot module @ 0000000003f80000 (XEN) Loading ramdisk from boot module @ 0000000006000000 (XEN) Allocating 1:1 mappings totalling 512MB for dom0: (XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB) (XEN) Grant table range: 0x00000002000000-0x00000002040000 (XEN) /pinctrl/pcie: Missing device_type (XEN) /pinctrl/pcie: Missing device_type (XEN) /pinctrl/pcie: Missing device_type (XEN) Allocating PPI 16 for event channel interrupt (XEN) d0: extended region 0: 0x2200000->0x20000000 (XEN) d0: extended region 1: 0x40000000->0xf8000000 (XEN) Loading zImage from 0000000003f80000 to 0000000020000000-0000000021aa8008 (XEN) Loading d0 initrd from 0000000006000000 to 0x0000000028200000-0x000000002a200000 (XEN) Loading d0 DTB to 0x0000000028000000-0x000000002800d5fb (XEN) Initial low memory virq threshold set at 0x4000 pages. (XEN) Scrubbing Free RAM in background (XEN) Std. Loglevel: All (XEN) Guest Loglevel: All (XEN) *************************************************** (XEN) WARNING: HMP COMPUTING HAS BEEN ENABLED. (XEN) It has implications on the security and stability of the system, (XEN) unless the cpu affinity of all domains is specified. (XEN) *************************************************** (XEN) PLEASE SPECIFY dom0_mem PARAMETER - USING 512M FOR NOW (XEN) *************************************************** (XEN) 3... 2... 1... (XEN) *** Serial input to DOM0 (type 'CTRL-a' three times to switch input) (XEN) Freed 356kB init memory. (XEN) d0v0 Unhandled SMC/HVC: 0x84000050 (XEN) d0v0 Unhandled SMC/HVC: 0x8600ff01 (XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER4 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER8 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER12 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER16 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER20 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER24 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER28 (XEN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER32 (XEN) d0v0: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 (XEN) d0v0 Unhandled SMC/HVC: 0x82000008 [ 0.000000] Booting Linux on physical CPU 0x0000000000 [0x410fd034] [ 0.000000] Linux version 5.15.16-1-rockchip-g359ffc4bc727 (root@brad-ThinkCentre-M82) (aarch64-linux-gnu-gcc (Linaro GCC 7.3-2018.052 [ 0.000000] Machine model: Vamrs RK3399 ZAKU [ 0.000000] printk: debug: ignoring loglevel setting. [ 0.000000] Xen 4.17 support found [ 0.000000] Zone ranges: [ 0.000000] DMA [mem 0x0000000020000000-0x000000003fffffff] [ 0.000000] DMA32 empty [ 0.000000] Normal empty [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x0000000020000000-0x000000003fffffff] [ 0.000000] Initmem setup node 0 [mem 0x0000000020000000-0x000000003fffffff] [ 0.000000] psci: probing for conduit method from DT. [ 0.000000] psci: PSCIv1.1 detected in firmware. [ 0.000000] psci: Using standard PSCI v0.2 function IDs [ 0.000000] psci: Trusted OS migration not required [ 0.000000] psci: SMC Calling Convention v1.1 [ 0.000000] percpu: Embedded 27 pages/cpu s69672 r8192 d32728 u110592 [ 0.000000] pcpu-alloc: s69672 r8192 d32728 u110592 alloc=27*4096 [ 0.000000] pcpu-alloc: [0] 0 [0] 1 [0] 2 [0] 3 [0] 4 [0] 5 [ 0.000000] Detected VIPT I-cache on CPU0 [ 0.000000] CPU features: detected: GIC system register CPU interface [ 0.000000] CPU features: detected: ARM erratum 845719 [ 0.000000] Built 1 zonelists, mobility grouping on. Total pages: 129024 [ 0.000000] Kernel command line: console=hvc0 earlyprintk=xen clk_ignore_unused root=/dev/nvme0n1p2 rw init=/sbin/init rootwait rootfl [ 0.000000] Unknown kernel command line parameters "earlyprintk=xen", will be passed to user space. [ 0.000000] Dentry cache hash table entries: 65536 (order: 7, 524288 bytes, linear) [ 0.000000] Inode-cache hash table entries: 32768 (order: 6, 262144 bytes, linear) [ 0.000000] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.000000] Memory: 452668K/524288K available (14016K kernel code, 2720K rwdata, 4856K rodata, 5504K init, 553K bss, 71620K reserved,) [ 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=6, Nodes=1 [ 0.000000] ftrace: allocating 54793 entries in 215 pages [ 0.000000] ftrace: allocated 215 pages with 6 groups [ 0.000000] trace event string verifier disabled [ 0.000000] rcu: Hierarchical RCU implementation. [ 0.000000] rcu: RCU event tracing is enabled. [ 0.000000] rcu: RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=6. [ 0.000000] Rude variant of Tasks RCU enabled. [ 0.000000] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. [ 0.000000] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=6 [ 0.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0 [ 0.000000] GICv3: 256 SPIs implemented [ 0.000000] GICv3: 0 Extended SPIs implemented [ 0.000000] GICv3: Distributor has no Range Selector support [ 0.000000] Root IRQ handler: gic_handle_irq [ 0.000000] GICv3: 16 PPIs implemented [ 0.000000] GICv3: CPU0: found redistributor 0 region 0:0x00000000fef00000 [ 0.000000] random: get_random_bytes called from start_kernel+0x44c/0x6bc with crng_init=0 [ 0.000000] arch_timer: cp15 timer(s) running at 24.00MHz (virt). [ 0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0x588fe9dc0, max_idle_ns: 440795202592 ns [ 0.000003] sched_clock: 56 bits at 24MHz, resolution 41ns, wraps every 4398046511097ns [ 0.004184] Console: colour dummy device 80x25 [ 0.010034] printk: console [hvc0] enabled [ 0.010272] Calibrating delay loop (skipped), value calculated using timer frequency.. 48.00 BogoMIPS (lpj=96000) [ 0.010509] pid_max: default: 32768 minimum: 301 [ 0.011188] LSM: Security Framework initializing [ 0.011384] Yama: becoming mindful. [ 0.011799] Mount-cache hash table entries: 1024 (order: 1, 8192 bytes, linear) [ 0.012105] Mountpoint-cache hash table entries: 1024 (order: 1, 8192 bytes, linear) [ 0.027498] xen:grant_table: Grant tables using version 1 layout [ 0.027843] Grant table initialized [ 0.028195] xen:events: Using FIFO-based ABI [ 0.028613] Xen: initializing cpu0 [ 0.029559] rcu: Hierarchical SRCU implementation. [ 0.038337] smp: Bringing up secondary CPUs ... (XEN) d0v1: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 (XEN) d0v2: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 (XEN) d0v3: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 (XEN) d0v4: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 (XEN) d0v5: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0 [ 0.042396] Detected VIPT I-cache on CPU1 [ 0.042606] GICv3: CPU1: found redistributor 1 region 0:0x00000000fef20000 [ 0.043215] Xen: initializing cpu1 [ 0.043511] CPU1: Booted secondary processor 0x0000000001 [0x410fd034] [ 0.047957] Detected VIPT I-cache on CPU2 [ 0.048177] GICv3: CPU2: found redistributor 2 region 0:0x00000000fef40000 [ 0.048778] Xen: initializing cpu2 [ 0.049066] CPU2: Booted secondary processor 0x0000000002 [0x410fd034] [ 0.052901] Detected VIPT I-cache on CPU3 [ 0.053120] GICv3: CPU3: found redistributor 3 region 0:0x00000000fef60000 [ 0.053626] Xen: initializing cpu3 [ 0.053907] CPU3: Booted secondary processor 0x0000000003 [0x410fd034] [ 0.062107] CPU features: detected: Spectre-v2 [ 0.063039] CPU features: detected: Spectre-v4 [ 0.063673] CPU features: detected: ARM errata 1165522, 1319367, or 1530923 [ 0.067132] Detected PIPT I-cache on CPU4 [ 0.072165] GICv3: CPU4: found redistributor 4 region 0:0x00000000fef80000 [ 0.081044] Xen: initializing cpu4 [ 0.086534] CPU4: Booted secondary processor 0x0000000004 [0x410fd082] [ 0.111175] Detected PIPT I-cache on CPU5 [ 0.116450] GICv3: CPU5: found redistributor 5 region 0:0x00000000fefa0000 [ 0.125174] Xen: initializing cpu5 [ 0.130645] CPU5: Booted secondary processor 0x0000000005 [0x410fd082] [ 0.141980] smp: Brought up 1 node, 6 CPUs [ 0.144637] SMP: Total of 6 processors activated. [ 0.144881] CPU features: detected: 32-bit EL0 Support [ 0.145127] CPU features: detected: CRC32 instructions [ 0.151947] CPU: All CPU(s) started at EL1 [ 0.155749] alternatives: patching kernel code [ 0.163024] devtmpfs: initialized [ 0.235277] Registered cp15_barrier emulation handler [ 0.238449] Registered setend emulation handler [ 0.239670] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [ 0.240040] futex hash table entries: 2048 (order: 5, 131072 bytes, linear) [ 0.241754] pinctrl core: initialized pinctrl subsystem [ 0.243287] regulator-dummy: no parameters, enabled [ 0.246947] NET: Registered PF_NETLINK/PF_ROUTE protocol family [ 0.260401] DMA: preallocated 128 KiB GFP_KERNEL pool for atomic allocations [ 0.260878] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA pool for atomic allocations [ 0.261294] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA32 pool for atomic allocations [ 0.261822] audit: initializing netlink subsys (disabled) [ 0.268125] audit: type=2000 audit(0.256:1): state=initialized audit_enabled=0 res=1 [ 0.278540] thermal_sys: Registered thermal governor 'fair_share' [ 0.278731] thermal_sys: Registered thermal governor 'step_wise' [ 0.279675] OF: /thermal-zones/cpu-thermal/cooling-maps/map0: could not find phandle 6 [ 0.280151] thermal_sys: Add a cooling_device property with at least one device [ 0.280307] thermal_sys: failed to build thermal zone cpu-thermal: -2 [ 0.283478] hw-breakpoint: found 6 breakpoint and 4 watchpoint registers. [ 0.299995] ASID allocator initialised with 65536 entries [ 0.300424] xen:swiotlb_xen: Warning: only able to allocate 4 MB for software IO TLB [ 0.303971] software IO TLB: mapped [mem 0x0000000022800000-0x0000000022c00000] (4MB) [ 0.310583] ------------[ cut here ]------------ [ 0.310855] WARNING: CPU: 0 PID: 1 at drivers/irqchip/irq-gic-v3.c:1533 gic_irq_domain_select+0x70/0x12c [ 0.311156] Modules linked in: [ 0.311317] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.15.16-1-rockchip-g359ffc4bc727 #1 [ 0.311536] Hardware name: Vamrs RK3399 ZAKU (DT) [ 0.311673] pstate: 20000005 (nzCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 0.311890] pc : gic_irq_domain_select+0x70/0x12c [ 0.312063] lr : gic_irq_domain_select+0x6c/0x12c [ 0.312273] sp : ffffffc011b5b8c0 [ 0.312385] x29: ffffffc011b5b8c0 x28: ffffff8021e37a80 x27: ffffff8021e37a00 [ 0.312634] x26: ffffff803feb92b0 x25: 0000000000000000 x24: ffffffc011b5b9f8 [ 0.312871] x23: ffffff8021c0c400 x22: ffffffc01120a000 x21: ffffffc0118f6000 [ 0.313111] x20: ffffffc011b5b9f8 x19: ffffff8021c0c400 x18: 000000000000000a [ 0.313350] x17: ffffffffffffffff x16: ffffffffffffffff x15: ffffffffffffffff [ 0.313568] x14: ffffffffffffffff x13: ffffffffffffffff x12: ffffffffffffffff [ 0.313805] x11: 0000000000000038 x10: 0101010101010101 x9 : ffffffffffffffff [ 0.314042] x8 : 7f7f7f7f7f7f7f7f x7 : ff71646b6b6e7173 x6 : 0000000000000080 [ 0.314278] x5 : 0000000000000000 x4 : 0000000000000000 x3 : ffffffc011b5b90c [ 0.314515] x2 : ffffffc011b5b910 x1 : 00000000a110c8ee x0 : 00000000ffffffea [ 0.314752] Call trace: [ 0.314853] gic_irq_domain_select+0x70/0x12c [ 0.315004] irq_find_matching_fwspec+0x78/0xf4 [ 0.315307] irq_create_fwspec_mapping+0x4c/0x2d4 [ 0.315476] irq_create_of_mapping+0x6c/0xa4 [ 0.315656] of_irq_get+0x64/0xa4 [ 0.315801] of_irq_to_resource+0x48/0xfc [ 0.315953] of_irq_to_resource_table+0x54/0x68 [ 0.316166] of_device_alloc+0x108/0x1b0 [ 0.316316] of_platform_device_create_pdata+0x7c/0xdc [ 0.316506] of_platform_bus_create+0x3a0/0x468 [ 0.316665] of_platform_populate+0x100/0x118 [ 0.316808] of_platform_default_populate+0x40/0x50 [ 0.316959] of_platform_default_populate_init+0x7c/0xb4 [ 0.317149] do_one_initcall+0x94/0x1c4 [ 0.317299] kernel_init_freeable+0x2b0/0x2b8 [ 0.317494] kernel_init+0x28/0x120 [ 0.317628] ret_from_fork+0x10/0x20 [ 0.317804] ---[ end trace 85c6a508ffafc11e ]--- [ 0.318293] irq: no irq domain found for interrupt-controller ! [ 0.390494] irq: type mismatch, failed to map hwirq-32 for interrupt-controller! [ 0.401389] irq: type mismatch, failed to map hwirq-32 for interrupt-controller! [ 0.403373] irq: type mismatch, failed to map hwirq-32 for interrupt-controller! [ 0.413685] platform ff770000.syscon:phy@f780: Fixing up cyclic dependency with fe330000.mmc [ 0.439170] platform ff940000.hdmi: Fixing up cyclic dependency with ff8f0000.vop [ 0.440132] platform ff940000.hdmi: Fixing up cyclic dependency with ff900000.vop [ 0.442114] irq: type mismatch, failed to map hwirq-32 for interrupt-controller! [ 0.479376] rockchip-gpio ff720000.gpio0: probed /pinctrl/gpio0@ff720000 [ 0.484466] rockchip-gpio ff730000.gpio1: probed /pinctrl/gpio1@ff730000 [ 0.489044] rockchip-gpio ff780000.gpio2: probed /pinctrl/gpio2@ff780000 [ 0.493295] rockchip-gpio ff788000.gpio3: probed /pinctrl/gpio3@ff788000 [ 0.497205] rockchip-gpio ff790000.gpio4: probed /pinctrl/gpio4@ff790000 [ 0.601234] HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages [ 0.602111] HugeTLB registered 32.0 MiB page size, pre-allocated 0 pages [ 0.602269] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages [ 0.602440] HugeTLB registered 64.0 KiB page size, pre-allocated 0 pages [ 0.732446] cryptd: max_cpu_qlen set to 1000 [ 0.965984] raid6: neonx8 gen() 343 MB/s [ 1.037514] raid6: neonx8 xor() 265 MB/s [ 1.108822] raid6: neonx4 gen() 358 MB/s [ 1.180595] raid6: neonx4 xor() 264 MB/s [ 1.251750] raid6: neonx2 gen() 332 MB/s [ 1.322968] raid6: neonx2 xor() 242 MB/s [ 1.394615] raid6: neonx1 gen() 289 MB/s [ 1.465958] raid6: neonx1 xor() 199 MB/s [ 1.537820] raid6: int64x8 gen() 87 MB/s [ 1.609578] raid6: int64x8 xor() 51 MB/s [ 1.681302] raid6: int64x4 gen() 107 MB/s [ 1.753475] raid6: int64x4 xor() 56 MB/s [ 1.824651] raid6: int64x2 gen() 182 MB/s [ 1.895619] raid6: int64x2 xor() 100 MB/s [ 1.966829] raid6: int64x1 gen() 136 MB/s [ 2.038152] raid6: int64x1 xor() 62 MB/s [ 2.038278] raid6: using algorithm neonx4 gen() 358 MB/s [ 2.038388] raid6: .... xor() 264 MB/s, rmw enabled [ 2.038485] raid6: using neon recovery algorithm [ 2.039515] xen:balloon: Initialising balloon driver [ 2.043846] vcc12v_dcin: 12000 mV, enabled [ 2.044876] reg-fixed-voltage vcc12v-dcin: vcc12v_dcin supplying 12000000uV [ 2.045966] vcc1v8_s0: 1800 mV, enabled [ 2.046981] reg-fixed-voltage vcc1v8-s0: vcc1v8_s0 supplying 1800000uV [ 2.047907] vcc5v0_sys: will resolve supply early: vin [ 2.048079] reg-fixed-voltage vcc5v0-sys: Looking up vin-supply from device tree [ 2.048293] vcc5v0_sys: supplied by vcc12v_dcin [ 2.048447] vcc12v_dcin: could not add device link regulator.3: -ENOENT [ 2.048990] vcc5v0_sys: 5000 mV, enabled [ 2.049877] reg-fixed-voltage vcc5v0-sys: vcc5v0_sys supplying 5000000uV [ 2.051218] vcc_phy: no parameters, enabled [ 2.052029] reg-fixed-voltage vcc-phy-regulator: vcc_phy supplying 0uV [ 2.052969] vcc3v3_sys: will resolve supply early: vin [ 2.053173] reg-fixed-voltage vcc3v3-sys: Looking up vin-supply from device tree [ 2.053379] vcc3v3_sys: supplied by vcc5v0_sys [ 2.053545] vcc5v0_sys: could not add device link regulator.5: -ENOENT [ 2.053932] vcc3v3_sys: 3300 mV, enabled [ 2.054924] reg-fixed-voltage vcc3v3-sys: vcc3v3_sys supplying 3300000uV [ 2.055842] rockchip-pinctrl pinctrl: unsupported driver strength 20 [ 2.056049] rockchip-pinctrl pinctrl: pin_config_set op failed for pin 146 [ 2.056203] reg-fixed-voltage vcc3v3-pcie-regulator: Error applying setting, reverse things back [ 2.057192] vcc3v3_pcie: will resolve supply early: vin [ 2.057379] reg-fixed-voltage vcc3v3-pcie-regulator: Looking up vin-supply from device tree [ 2.057575] vcc3v3_pcie: supplied by vcc3v3_sys [ 2.057760] vcc3v3_sys: could not add device link regulator.6: -ENOENT [ 2.058267] vcc3v3_pcie: 3300 mV, enabled [ 2.059496] reg-fixed-voltage vcc3v3-pcie-regulator: vcc3v3_pcie supplying 3300000uV [ 2.061208] vcc5v0_usb: will resolve supply early: vin [ 2.061375] reg-fixed-voltage vcc5v0-usb-regulator: Looking up vin-supply from device tree [ 2.061595] vcc5v0_usb: supplied by vcc5v0_sys [ 2.061736] vcc5v0_sys: could not add device link regulator.7: -ENOENT [ 2.062164] vcc5v0_usb: 5000 mV, enabled [ 2.063312] reg-fixed-voltage vcc5v0-usb-regulator: vcc5v0_usb supplying 5000000uV [ 2.064318] vcc_0v9: will resolve supply early: vin [ 2.064511] reg-fixed-voltage vcc-0v9: Looking up vin-supply from device tree [ 2.064705] vcc_0v9: supplied by vcc3v3_sys [ 2.064902] vcc3v3_sys: could not add device link regulator.8: -ENOENT [ 2.065383] vcc_0v9: 900 mV, enabled [ 2.066280] reg-fixed-voltage vcc-0v9: vcc_0v9 supplying 900000uV [ 2.071921] iommu: Default domain type: Translated [ 2.072285] iommu: DMA domain TLB invalidation policy: strict mode [ 2.089090] SCSI subsystem initialized [ 2.097346] libata version 3.00 loaded. [ 2.098501] usbcore: registered new interface driver usbfs [ 2.098931] usbcore: registered new interface driver hub [ 2.099344] usbcore: registered new device driver usb [ 2.100020] mc: Linux media interface: v0.10 [ 2.100319] videodev: Linux video capture interface: v2.00 [ 2.100991] pps_core: LinuxPPS API ver. 1 registered [ 2.101145] pps_core: Software ver. 5.3.6 - Copyright 2005-2007 Rodolfo Giometti [ 2.101402] PTP clock support registered [ 2.107595] Advanced Linux Sound Architecture Driver Initialized. [ 2.111011] Bluetooth: Core ver 2.22 [ 2.111358] NET: Registered PF_BLUETOOTH protocol family [ 2.111517] Bluetooth: HCI device and connection manager initialized [ 2.111680] Bluetooth: HCI socket layer initialized [ 2.111857] Bluetooth: L2CAP socket layer initialized [ 2.112069] Bluetooth: SCO socket layer initialized [ 2.112296] NetLabel: Initializing [ 2.112402] NetLabel: domain hash size = 128 [ 2.112517] NetLabel: protocols = UNLABELED CIPSOv4 CALIPSO [ 2.113111] NetLabel: unlabeled traffic allowed by default [ 2.122030] clocksource: Switched to clocksource arch_sys_counter [ 2.413055] VFS: Disk quotas dquot_6.6.0 [ 2.414148] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes) [ 2.475712] NET: Registered PF_INET protocol family [ 2.476923] IP idents hash table entries: 8192 (order: 4, 65536 bytes, linear) [ 2.482548] tcp_listen_portaddr_hash hash table entries: 256 (order: 1, 10240 bytes, linear) [ 2.483081] TCP established hash table entries: 4096 (order: 3, 32768 bytes, linear) [ 2.483542] TCP bind hash table entries: 4096 (order: 5, 131072 bytes, linear) [ 2.484397] TCP: Hash tables configured (established 4096 bind 4096) [ 2.485284] UDP hash table entries: 256 (order: 2, 24576 bytes, linear) [ 2.485892] UDP-Lite hash table entries: 256 (order: 2, 24576 bytes, linear) [ 2.487194] NET: Registered PF_UNIX/PF_LOCAL protocol family [ 2.487492] PCI: CLS 0 bytes, default 64 [ 2.490694] Trying to unpack rootfs image as initramfs... [ 3.097632] rootfs image is not initramfs (Decoding failed); looks like an initrd [ 3.477246] Freeing initrd memory: 32768K [ 3.816771] Initialise system trusted keyrings [ 3.828487] workingset: timestamp_bits=46 max_order=17 bucket_order=0 [ 4.594980] squashfs: version 4.0 (2009/01/31) Phillip Lougher [ 4.639877] fuse: init (API version 7.34) [ 4.692812] JFS: nTxBlock = 3790, nTxLock = 30323 [ 4.875022] SGI XFS with ACLs, security attributes, realtime, verbose warnings, quota, no debug enabled [ 10.116665] NET: Registered PF_ALG protocol family [ 10.117252] xor: measuring software checksum speed [ 10.145130] 8regs : 361 MB/sec [ 10.165698] 32regs : 482 MB/sec [ 10.191437] arm64_neon : 384 MB/sec [ 10.191569] xor: using function: 32regs (482 MB/sec) [ 10.192042] Key type asymmetric registered [ 10.192188] Asymmetric key parser 'x509' registered [ 10.194224] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 246) [ 10.200293] io scheduler mq-deadline registered [ 10.200447] io scheduler kyber registered [ 10.213640] phy phy-ff770000.syscon:phy@f780.0: Looking up phy-supply from device tree [ 10.213957] phy phy-ff770000.syscon:phy@f780.0: Looking up phy-supply property in node /syscon@ff770000/phy@f780 failed [ 10.222938] phy phy-ff770000.syscon:usb2phy@e450.1: Looking up phy-supply from device tree [ 10.223420] vcc5v0_usb: could not add device link phy-ff770000.syscon:usb2phy@e450.1: -ENOENT [ 10.228300] phy phy-ff770000.syscon:usb2phy@e450.2: Looking up phy-supply from device tree [ 10.228648] phy phy-ff770000.syscon:usb2phy@e450.2: Looking up phy-supply property in node /syscon@ff770000/usb2phy@e450/otg-port faid [ 10.237376] phy phy-ff770000.syscon:usb2phy@e460.3: Looking up phy-supply from device tree [ 10.238041] vcc5v0_usb: could not add device link phy-ff770000.syscon:usb2phy@e460.3: -ENOENT [ 10.242605] phy phy-ff770000.syscon:usb2phy@e460.4: Looking up phy-supply from device tree [ 10.242946] phy phy-ff770000.syscon:usb2phy@e460.4: Looking up phy-supply property in node /syscon@ff770000/usb2phy@e460/otg-port faid [ 10.247126] phy phy-ff770000.syscon:pcie-phy.5: Looking up phy-supply from device tree [ 10.247400] phy phy-ff770000.syscon:pcie-phy.5: Looking up phy-supply property in node /syscon@ff770000/pcie-phy failed [ 10.248209] phy phy-ff770000.syscon:pcie-phy.6: Looking up phy-supply from device tree [ 10.248426] phy phy-ff770000.syscon:pcie-phy.6: Looking up phy-supply property in node /syscon@ff770000/pcie-phy failed [ 10.249176] phy phy-ff770000.syscon:pcie-phy.7: Looking up phy-supply from device tree [ 10.249393] phy phy-ff770000.syscon:pcie-phy.7: Looking up phy-supply property in node /syscon@ff770000/pcie-phy failed [ 10.250343] phy phy-ff770000.syscon:pcie-phy.8: Looking up phy-supply from device tree [ 10.250775] phy phy-ff770000.syscon:pcie-phy.8: Looking up phy-supply property in node /syscon@ff770000/pcie-phy failed [ 10.254471] phy phy-ff7c0000.phy.9: Looking up phy-supply from device tree [ 10.254748] phy phy-ff7c0000.phy.9: Looking up phy-supply property in node /phy@ff7c0000/dp-port failed [ 10.255670] phy phy-ff7c0000.phy.10: Looking up phy-supply from device tree [ 10.255872] phy phy-ff7c0000.phy.10: Looking up phy-supply property in node /phy@ff7c0000/usb3-port failed [ 10.258831] phy phy-ff800000.phy.11: Looking up phy-supply from device tree [ 10.259081] phy phy-ff800000.phy.11: Looking up phy-supply property in node /phy@ff800000/dp-port failed [ 10.259972] phy phy-ff800000.phy.12: Looking up phy-supply from device tree [ 10.260151] phy phy-ff800000.phy.12: Looking up phy-supply property in node /phy@ff800000/usb3-port failed [ 10.282297] dma-pl330 ff6d0000.dma-controller: Loaded driver for PL330 DMAC-241330 [ 10.282779] dma-pl330 ff6d0000.dma-controller: DBUFF-32x8bytes Num_Chans-6 Num_Peri-12 Num_Events-12 [ 10.291532] dma-pl330 ff6e0000.dma-controller: Loaded driver for PL330 DMAC-241330 [ 10.291829] dma-pl330 ff6e0000.dma-controller: DBUFF-128x8bytes Num_Chans-8 Num_Peri-20 Num_Events-16 [ 10.300189] xen:xen_evtchn: Event-channel device installed [ 10.318364] Serial: 8250/16550 driver, 5 ports, IRQ sharing disabled [ 10.335497] rockchip-vop ff8f0000.vop: Adding to iommu group 2 [ 10.340200] rockchip-vop ff900000.vop: Adding to iommu group 3 [ 10.367059] rockchip-drm display-subsystem: bound ff8f0000.vop (ops 0xffffffc010e887e8) [ 10.367999] [drm] unsupported AFBC format[3231564e] [ 10.371622] rockchip-drm display-subsystem: bound ff900000.vop (ops 0xffffffc010e887e8) [ 10.394857] cacheinfo: Unable to detect cache hierarchy for CPU 0 [ 10.400560] brd: module loaded [ 10.444804] loop: module loaded [ 10.448040] lkdtm: No crash points registered, enable through debugfs [ 10.481318] libphy: Fixed MDIO Bus: probed [ 10.482042] CAN device driver interface [ 10.484479] usbcore: registered new interface driver cdc_ether [ 10.484987] usbcore: registered new interface driver rndis_host [ 10.528254] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 10.528704] ehci-pci: EHCI PCI platform driver [ 10.529176] ehci-platform: EHCI generic platform driver [ 10.533146] ehci-platform fe380000.usb: EHCI Host Controller [ 10.534559] ehci-platform fe380000.usb: new USB bus registered, assigned bus number 1 [ 10.535808] ehci-platform fe380000.usb: irq 19, io mem 0xfe380000 [ 10.549833] ehci-platform fe380000.usb: USB 2.0 started, EHCI 1.00 [ 10.551250] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.15 [ 10.551441] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.551591] usb usb1: Product: EHCI Host Controller [ 10.551705] usb usb1: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 ehci_hcd [ 10.551860] usb usb1: SerialNumber: fe380000.usb [ 10.555156] hub 1-0:1.0: USB hub found [ 10.555443] hub 1-0:1.0: 1 port detected [ 10.561186] ehci-platform fe3c0000.usb: EHCI Host Controller [ 10.562763] ehci-platform fe3c0000.usb: new USB bus registered, assigned bus number 2 [ 10.563759] ehci-platform fe3c0000.usb: irq 21, io mem 0xfe3c0000 [ 10.577817] ehci-platform fe3c0000.usb: USB 2.0 started, EHCI 1.00 [ 10.579010] usb usb2: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.15 [ 10.579200] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.579353] usb usb2: Product: EHCI Host Controller [ 10.579467] usb usb2: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 ehci_hcd [ 10.579619] usb usb2: SerialNumber: fe3c0000.usb [ 10.582596] hub 2-0:1.0: USB hub found [ 10.582872] hub 2-0:1.0: 1 port detected [ 10.586210] ohci_hcd: USB 1.1 'Open' Host Controller (OHCI) Driver [ 10.586524] ohci-platform: OHCI generic platform driver [ 10.587848] ohci-platform fe3a0000.usb: Generic Platform OHCI controller [ 10.589672] ohci-platform fe3a0000.usb: new USB bus registered, assigned bus number 3 [ 10.590708] ohci-platform fe3a0000.usb: irq 20, io mem 0xfe3a0000 [ 10.654476] usb usb3: New USB device found, idVendor=1d6b, idProduct=0001, bcdDevice= 5.15 [ 10.654689] usb usb3: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.654841] usb usb3: Product: Generic Platform OHCI controller [ 10.654973] usb usb3: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 ohci_hcd [ 10.655120] usb usb3: SerialNumber: fe3a0000.usb [ 10.658033] hub 3-0:1.0: USB hub found [ 10.658329] hub 3-0:1.0: 1 port detected [ 10.661656] ohci-platform fe3e0000.usb: Generic Platform OHCI controller [ 10.663217] ohci-platform fe3e0000.usb: new USB bus registered, assigned bus number 4 [ 10.664185] ohci-platform fe3e0000.usb: irq 22, io mem 0xfe3e0000 [ 10.726670] usb usb4: New USB device found, idVendor=1d6b, idProduct=0001, bcdDevice= 5.15 [ 10.726886] usb usb4: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.727049] usb usb4: Product: Generic Platform OHCI controller [ 10.727181] usb usb4: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 ohci_hcd [ 10.727329] usb usb4: SerialNumber: fe3e0000.usb [ 10.730270] hub 4-0:1.0: USB hub found [ 10.730545] hub 4-0:1.0: 1 port detected [ 10.737209] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller [ 10.739611] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 5 [ 10.740395] xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe64 hci version 0x110 quirks 0x0000000002010010 [ 10.740805] xhci-hcd xhci-hcd.0.auto: irq 53, io mem 0xfe800000 [ 10.742883] usb usb5: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.15 [ 10.743094] usb usb5: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.743246] usb usb5: Product: xHCI Host Controller [ 10.743359] usb usb5: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd [ 10.743512] usb usb5: SerialNumber: xhci-hcd.0.auto [ 10.746576] hub 5-0:1.0: USB hub found [ 10.746865] hub 5-0:1.0: 1 port detected [ 10.749054] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller [ 10.750454] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number 6 [ 10.750677] xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed [ 10.751167] usb usb6: We don't know the algorithms for LPM for this host, disabling LPM. [ 10.752007] usb usb6: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.15 [ 10.752187] usb usb6: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.752337] usb usb6: Product: xHCI Host Controller [ 10.752451] usb usb6: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd [ 10.752592] usb usb6: SerialNumber: xhci-hcd.0.auto [ 10.755365] hub 6-0:1.0: USB hub found [ 10.755669] hub 6-0:1.0: 1 port detected [ 10.758922] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller [ 10.760343] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 7 [ 10.761128] xhci-hcd xhci-hcd.1.auto: hcc params 0x0220fe64 hci version 0x110 quirks 0x0000000002010010 [ 10.762039] xhci-hcd xhci-hcd.1.auto: irq 54, io mem 0xfe900000 [ 10.763994] usb usb7: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.15 [ 10.764191] usb usb7: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.764342] usb usb7: Product: xHCI Host Controller [ 10.764455] usb usb7: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd [ 10.764601] usb usb7: SerialNumber: xhci-hcd.1.auto [ 10.767411] hub 7-0:1.0: USB hub found [ 10.767696] hub 7-0:1.0: 1 port detected [ 10.769982] xhci-hcd xhci-hcd.1.auto: xHCI Host Controller [ 10.771168] xhci-hcd xhci-hcd.1.auto: new USB bus registered, assigned bus number 8 [ 10.771384] xhci-hcd xhci-hcd.1.auto: Host supports USB 3.0 SuperSpeed [ 10.771912] usb usb8: We don't know the algorithms for LPM for this host, disabling LPM. [ 10.772717] usb usb8: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.15 [ 10.772896] usb usb8: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 10.773046] usb usb8: Product: xHCI Host Controller [ 10.773160] usb usb8: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd [ 10.773302] usb usb8: SerialNumber: xhci-hcd.1.auto [ 10.776389] hub 8-0:1.0: USB hub found [ 10.776678] hub 8-0:1.0: 1 port detected [ 10.784427] usbcore: registered new interface driver uas [ 10.785747] usbcore: registered new interface driver usb-storage [ 10.786109] usbcore: registered new interface driver ums-alauda [ 10.786423] usbcore: registered new interface driver ums-cypress [ 10.786758] usbcore: registered new interface driver ums-datafab [ 10.787095] usbcore: registered new interface driver ums_eneub6250 [ 10.787409] usbcore: registered new interface driver ums-freecom [ 10.787719] usbcore: registered new interface driver ums-isd200 [ 10.788017] usbcore: registered new interface driver ums-jumpshot [ 10.788326] usbcore: registered new interface driver ums-karma [ 10.788625] usbcore: registered new interface driver ums-onetouch [ 10.789023] usbcore: registered new interface driver ums-realtek [ 10.789333] usbcore: registered new interface driver ums-sddr09 [ 10.789756] usbcore: registered new interface driver ums-sddr55 [ 10.790070] usbcore: registered new interface driver ums-usbat [ 10.792802] usbcore: registered new interface driver iforce [ 10.793352] usbcore: registered new interface driver xpad [ 10.794485] usbcore: registered new interface driver usbtouchscreen [ 10.797315] i2c_dev: i2c /dev entries driver [ 10.816490] fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected! [ 10.818456] vdd_cpu_b: will resolve supply early: vin [ 10.818614] fan53555-regulator 0-0040: Looking up vin-supply from device tree [ 10.818799] vdd_cpu_b: supplied by vcc5v0_sys [ 10.818944] vcc5v0_sys: could not add device link regulator.9: -ENOENT [ 10.822253] vdd_cpu_b: 712 <--> 1500 mV at 1000 mV, enabled [ 10.827044] fan53555-regulator 0-0041: FAN53555 Option[8] Rev[1] Detected! [ 10.828780] vdd_gpu: will resolve supply early: vin [ 10.828939] fan53555-regulator 0-0041: Looking up vin-supply from device tree [ 10.829117] vdd_gpu: supplied by vcc5v0_sys [ 10.829230] vcc5v0_sys: could not add device link regulator.10: -ENOENT [ 10.832556] vdd_gpu: 712 <--> 1500 mV at 1000 mV, enabled [ 10.841882] rk808 0-001b: chip id: 0x0 [ 10.862081] rk808-regulator rk808-regulator: there is no dvs0 gpio [ 10.862548] rk808-regulator rk808-regulator: there is no dvs1 gpio [ 10.864173] vdd_center: will resolve supply early: vcc1 [ 10.864337] rk808 0-001b: Looking up vcc1-supply from device tree [ 10.864503] vdd_center: supplied by vcc5v0_sys [ 10.864631] vcc5v0_sys: could not add device link regulator.11: -ENOENT [ 10.866313] vdd_center: 750 <--> 1350 mV at 900 mV, enabled [ 10.868084] vdd_cpu_l: will resolve supply early: vcc2 [ 10.868241] rk808 0-001b: Looking up vcc2-supply from device tree [ 10.868402] vdd_cpu_l: supplied by vcc5v0_sys [ 10.868524] vcc5v0_sys: could not add device link regulator.12: -ENOENT [ 10.868888] vdd_cpu_l: 750 <--> 1350 mV at 900 mV, enabled [ 10.870335] vcc_ddr: will resolve supply early: vcc3 [ 10.870485] rk808 0-001b: Looking up vcc3-supply from device tree [ 10.870646] vcc_ddr: supplied by vcc5v0_sys [ 10.870761] vcc5v0_sys: could not add device link regulator.13: -ENOENT [ 10.871149] vcc_ddr: at 5000 mV, enabled [ 10.873225] vcc_1v8: will resolve supply early: vcc4 [ 10.873379] rk808 0-001b: Looking up vcc4-supply from device tree [ 10.873816] vcc_1v8: supplied by vcc5v0_sys [ 10.873940] vcc5v0_sys: could not add device link regulator.14: -ENOENT [ 10.874308] vcc_1v8: 1800 mV, enabled [ 10.876864] vcc1v8_dvp: will resolve supply early: vcc6 [ 10.877025] rk808 0-001b: Looking up vcc6-supply from device tree [ 10.877180] vcc1v8_dvp: supplied by vcc5v0_sys [ 10.877300] vcc5v0_sys: could not add device link regulator.15: -ENOENT [ 10.878934] vcc1v8_dvp: 1800 mV, enabled [ 10.881114] vcca1v8_hdmi: will resolve supply early: vcc6 [ 10.881268] rk808 0-001b: Looking up vcc6-supply from device tree [ 10.881721] vcca1v8_hdmi: supplied by vcc5v0_sys [ 10.881858] vcc5v0_sys: could not add device link regulator.16: -ENOENT [ 10.882897] vcca1v8_hdmi: 1800 mV, enabled [ 10.885121] vcca_1v8: will resolve supply early: vcc7 [ 10.885284] rk808 0-001b: Looking up vcc7-supply from device tree [ 10.885610] vcca_1v8: supplied by vcc5v0_sys [ 10.885752] vcc5v0_sys: could not add device link regulator.17: -ENOENT [ 10.886785] vcca_1v8: 1800 mV, enabled [ 10.888911] vcc_sd: will resolve supply early: vcc9 [ 10.889073] rk808 0-001b: Looking up vcc9-supply from device tree [ 10.889227] vcc_sd: supplied by vcc5v0_sys [ 10.889337] vcc5v0_sys: could not add device link regulator.18: -ENOENT [ 10.890587] vcc_sd: 1800 <--> 3300 mV at 3000 mV, enabled [ 10.892799] vcc3v0_sd: will resolve supply early: vcc9 [ 10.892957] rk808 0-001b: Looking up vcc9-supply from device tree [ 10.893116] vcc3v0_sd: supplied by vcc5v0_sys [ 10.893261] vcc5v0_sys: could not add device link regulator.19: -ENOENT [ 10.894528] vcc3v0_sd: 3000 mV, enabled [ 10.896651] vcc_1v5: will resolve supply early: vcc10 [ 10.896806] rk808 0-001b: Looking up vcc10-supply from device tree [ 10.896961] vcc_1v5: supplied by vcc5v0_sys [ 10.897073] vcc5v0_sys: could not add device link regulator.20: -ENOENT [ 10.898331] vcc_1v5: 1500 mV, enabled [ 10.900480] vcca0v9_hdmi: will resolve supply early: vcc7 [ 10.900633] rk808 0-001b: Looking up vcc7-supply from device tree [ 10.900789] vcca0v9_hdmi: supplied by vcc5v0_sys [ 10.900910] vcc5v0_sys: could not add device link regulator.21: -ENOENT [ 10.901947] vcca0v9_hdmi: 900 mV, enabled [ 10.904130] vcc_3v0: will resolve supply early: vcc11 [ 10.904283] rk808 0-001b: Looking up vcc11-supply from device tree [ 10.904440] vcc_3v0: supplied by vcc5v0_sys [ 10.904551] vcc5v0_sys: could not add device link regulator.22: -ENOENT [ 10.905603] vcc_3v0: 3000 mV, enabled [ 10.906825] vcc3v3_s3: will resolve supply early: vcc8 [ 10.907071] rk808 0-001b: Looking up vcc8-supply from device tree [ 10.907238] vcc3v3_s3: supplied by vcc3v3_sys [ 10.907358] vcc3v3_sys: could not add device link regulator.23: -ENOENT [ 10.907702] vcc3v3_s3: at 3300 mV, enabled [ 10.908814] vcc3v3_s0: will resolve supply early: vcc12 [ 10.908951] rk808 0-001b: Looking up vcc12-supply from device tree [ 10.909117] vcc3v3_s0: supplied by vcc3v3_sys [ 10.909238] vcc3v3_sys: could not add device link regulator.24: -ENOENT [ 10.909966] vcc3v3_s0: at 3300 mV, enabled [ 10.923748] rk808-rtc rk808-rtc: registered as rtc0 [ 10.925890] rk808-rtc rk808-rtc: setting system clock to 2013-01-18T08:54:34 UTC (1358499274) [ 10.937312] rockchip-rga ff680000.rga: HW Version: 0x03.02 [ 10.938723] rockchip-rga: probe of ff680000.rga failed with error -12 [ 10.940550] usbcore: registered new interface driver uvcvideo [ 10.947281] rockchip-thermal ff260000.tsadc: failed to register sensor 0: -517 [ 10.947553] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error = -517 [ 10.951347] dw_wdt ff848000.watchdog: No valid TOPs array specified [ 10.957666] device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) initialised: dm-devel@redhat.com [ 10.958918] Bluetooth: HCI UART driver ver 2.3 [ 10.959059] Bluetooth: HCI UART protocol H4 registered [ 10.959172] Bluetooth: HCI UART protocol ATH3K registered [ 10.959600] usbcore: registered new interface driver bfusb [ 10.960069] usbcore: registered new interface driver btusb [ 10.960865] cpu cpu0: OPP table can't be empty [ 10.963410] sdhci: Secure Digital Host Controller Interface driver [ 10.963573] sdhci: Copyright(c) Pierre Ossman [ 10.963674] Synopsys Designware Multimedia Card Interface Driver [ 10.966723] sdhci-pltfm: SDHCI platform and OF driver helper [ 10.969834] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit address mode. [ 10.970158] dwmmc_rockchip fe310000.mmc: Using internal DMA controller. [ 10.970317] dwmmc_rockchip fe310000.mmc: Version ID is 270a [ 10.971055] dwmmc_rockchip fe310000.mmc: DW MMC controller at irq 17,32 bit host data width,256 deep fifo [ 10.972116] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree [ 10.972318] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply property in node /mmc@fe310000 failed [ 10.972647] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply from device tree [ 10.972823] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /mmc@fe310000 failed [ 10.989783] ledtrig-cpu: registered to indicate activity on CPUs [ 10.990632] hid: raw HID events driver (C) Jiri Kosina [ 11.018314] usbcore: registered new interface driver usbhid [ 11.018612] usbhid: USB HID core driver [ 11.020835] rkvdec ff660000.video-codec: Adding to iommu group 1 [ 11.068158] hantro-vpu ff650000.video-codec: Adding to iommu group 0 [ 11.072492] irq: type mismatch, failed to map hwirq-32 for interrupt-controller! [ 11.072712] hantro-vpu ff650000.video-codec: IRQ vdpu not found [ 11.074844] Zoran MJPEG board driver version 0.10.1 [ 11.075255] Linux video codec intermediate layer: v0.2 [ 11.075418] saa7146: register extension 'av7110' [ 11.083859] sdhci-arasan fe330000.mmc: Looking up vmmc-supply from device tree [ 11.091432] usbcore: registered new interface driver snd-usb-audio [ 11.099500] sdhci-arasan fe330000.mmc: Looking up vmmc-supply property in node /mmc@fe330000 failed [ 11.112425] u32 classifier [ 11.112499] sdhci-arasan fe330000.mmc: Looking up vqmmc-supply from device tree [ 11.113020] input device check on [ 11.114266] Initializing XFRM netlink socket [ 11.120358] sdhci-arasan fe330000.mmc: Looking up vqmmc-supply property in node /mmc@fe330000 failed [ 11.121602] NET: Registered PF_INET6 protocol family [ 11.123037] usb 8-1: new SuperSpeed USB device number 2 using xhci-hcd [ 11.134670] Segment Routing with IPv6 [ 11.135294] In-situ OAM (IOAM) with IPv6 [ 11.135867] NET: Registered PF_PACKET protocol family [ 11.136112] NET: Registered PF_KEY protocol family [ 11.136230] mmc2: CQHCI version 5.10 [ 11.136568] Bridge firewalling registered [ 11.136633] can: controller area network core [ 11.138034] NET: Registered PF_CAN protocol family [ 11.141093] Bluetooth: RFCOMM socket layer initialized [ 11.141809] Bluetooth: RFCOMM ver 1.11 [ 11.142039] Bluetooth: HIDP (Human Interface Emulation) ver 1.2 [ 11.142209] Bluetooth: HIDP socket layer initialized [ 11.142338] 8021q: 802.1Q VLAN Support v1.8 [ 11.142653] Key type dns_resolver registered [ 11.149920] registered taskstats version 1 [ 11.150671] Loading compiled-in X.509 certificates [ 11.151208] random: fast init done [ 11.155983] usb 8-1: New USB device found, idVendor=152d, idProduct=0561, bcdDevice= 0.01 [ 11.156263] usb 8-1: New USB device strings: Mfr=1, Product=2, SerialNumber=5 [ 11.156439] usb 8-1: Product: JMS56x Series [ 11.156545] usb 8-1: Manufacturer: JMicron [ 11.156646] usb 8-1: SerialNumber: RANDOM__A0840143833E [ 11.168652] usb-storage 8-1:1.0: USB Mass Storage device detected [ 11.178360] scsi host0: usb-storage 8-1:1.0 [ 11.196406] Btrfs loaded, crc32c=crc32c-generic, integrity-checker=on, zoned=no, fsverity=no [ 11.197865] BTRFS: selftest: sectorsize: 4096 nodesize: 4096 [ 11.198037] BTRFS: selftest: running btrfs free space cache tests [ 11.198203] BTRFS: selftest: running extent only tests [ 11.198401] BTRFS: selftest: running bitmap only tests [ 11.198583] BTRFS: selftest: running bitmap and extent tests [ 11.198850] BTRFS: selftest: running space stealing from bitmap to extent tests [ 11.202503] mmc2: SDHCI controller on fe330000.mmc [fe330000.mmc] using ADMA [ 11.206911] BTRFS: selftest: running extent buffer operation tests [ 11.207131] BTRFS: selftest: running btrfs_split_item tests [ 11.207469] BTRFS: selftest: running extent I/O tests [ 11.207579] BTRFS: selftest: running find delalloc tests [ 13.247196] BTRFS: selftest: running find_first_clear_extent_bit test [ 13.247996] BTRFS: selftest: running extent buffer bitmap tests [ 13.436326] BTRFS: selftest: running inode tests [ 13.436468] BTRFS: selftest: running btrfs_get_extent tests [ 13.437811] BTRFS: selftest: running hole first btrfs_get_extent test [ 13.438152] BTRFS: selftest: running outstanding_extents tests [ 13.438630] BTRFS: selftest: running qgroup tests [ 13.438747] BTRFS: selftest: running qgroup add/remove tests [ 13.439210] BTRFS: selftest: running qgroup multiple refs test [ 13.440099] BTRFS: selftest: running free space tree tests [ 13.880122] BTRFS: selftest: sectorsize: 4096 nodesize: 8192 [ 13.880446] BTRFS: selftest: running btrfs free space cache tests [ 13.880648] BTRFS: selftest: running extent only tests [ 13.880883] BTRFS: selftest: running bitmap only tests [ 13.881123] BTRFS: selftest: running bitmap and extent tests [ 13.881545] BTRFS: selftest: running space stealing from bitmap to extent tests [ 13.889765] BTRFS: selftest: running extent buffer operation tests [ 13.889923] BTRFS: selftest: running btrfs_split_item tests [ 13.890241] BTRFS: selftest: running extent I/O tests [ 13.890369] BTRFS: selftest: running find delalloc tests [ 15.931291] BTRFS: selftest: running find_first_clear_extent_bit test [ 15.932162] BTRFS: selftest: running extent buffer bitmap tests [ 16.532870] BTRFS: selftest: running inode tests [ 16.533138] BTRFS: selftest: running btrfs_get_extent tests [ 16.534815] BTRFS: selftest: running hole first btrfs_get_extent test [ 16.535219] BTRFS: selftest: running outstanding_extents tests [ 16.535736] BTRFS: selftest: running qgroup tests [ 16.535846] BTRFS: selftest: running qgroup add/remove tests [ 16.536300] BTRFS: selftest: running qgroup multiple refs test [ 16.537056] BTRFS: selftest: running free space tree tests [ 16.977337] BTRFS: selftest: sectorsize: 4096 nodesize: 16384 [ 16.977814] BTRFS: selftest: running btrfs free space cache tests [ 16.978018] BTRFS: selftest: running extent only tests [ 16.978279] BTRFS: selftest: running bitmap only tests [ 16.978513] BTRFS: selftest: running bitmap and extent tests [ 16.978842] BTRFS: selftest: running space stealing from bitmap to extent tests [ 16.987056] BTRFS: selftest: running extent buffer operation tests [ 16.987214] BTRFS: selftest: running btrfs_split_item tests [ 16.987541] BTRFS: selftest: running extent I/O tests [ 16.987667] BTRFS: selftest: running find delalloc tests [ 19.025223] BTRFS: selftest: running find_first_clear_extent_bit test [ 19.026172] BTRFS: selftest: running extent buffer bitmap tests [ 20.225626] BTRFS: selftest: running inode tests [ 20.225841] BTRFS: selftest: running btrfs_get_extent tests [ 20.227444] BTRFS: selftest: running hole first btrfs_get_extent test [ 20.227818] BTRFS: selftest: running outstanding_extents tests [ 20.228276] BTRFS: selftest: running qgroup tests [ 20.228399] BTRFS: selftest: running qgroup add/remove tests [ 20.228834] BTRFS: selftest: running qgroup multiple refs test [ 20.229952] BTRFS: selftest: running free space tree tests [ 20.669501] BTRFS: selftest: sectorsize: 4096 nodesize: 32768 [ 20.669747] BTRFS: selftest: running btrfs free space cache tests [ 20.669903] BTRFS: selftest: running extent only tests [ 20.670123] BTRFS: selftest: running bitmap only tests [ 20.670366] BTRFS: selftest: running bitmap and extent tests [ 20.670625] BTRFS: selftest: running space stealing from bitmap to extent tests [ 20.678498] BTRFS: selftest: running extent buffer operation tests [ 20.678644] BTRFS: selftest: running btrfs_split_item tests [ 20.678971] BTRFS: selftest: running extent I/O tests [ 20.679083] BTRFS: selftest: running find delalloc tests [ 22.716824] BTRFS: selftest: running find_first_clear_extent_bit test [ 22.717705] BTRFS: selftest: running extent buffer bitmap tests [ 25.119619] BTRFS: selftest: running inode tests [ 25.119942] BTRFS: selftest: running btrfs_get_extent tests [ 25.121224] BTRFS: selftest: running hole first btrfs_get_extent test [ 25.121825] BTRFS: selftest: running outstanding_extents tests [ 25.122316] BTRFS: selftest: running qgroup tests [ 25.122425] BTRFS: selftest: running qgroup add/remove tests [ 25.122860] BTRFS: selftest: running qgroup multiple refs test [ 25.123715] BTRFS: selftest: running free space tree tests [ 25.564237] BTRFS: selftest: sectorsize: 4096 nodesize: 65536 [ 25.564448] BTRFS: selftest: running btrfs free space cache tests [ 25.564600] BTRFS: selftest: running extent only tests [ 25.564762] BTRFS: selftest: running bitmap only tests [ 25.564946] BTRFS: selftest: running bitmap and extent tests [ 25.565204] BTRFS: selftest: running space stealing from bitmap to extent tests [ 25.573041] BTRFS: selftest: running extent buffer operation tests [ 25.573167] BTRFS: selftest: running btrfs_split_item tests [ 25.573626] BTRFS: selftest: running extent I/O tests [ 25.573739] BTRFS: selftest: running find delalloc tests [ 27.608826] BTRFS: selftest: running find_first_clear_extent_bit test [ 27.609668] BTRFS: selftest: running extent buffer bitmap tests [ 32.430665] BTRFS: selftest: running inode tests [ 32.431202] BTRFS: selftest: running btrfs_get_extent tests [ 32.432886] BTRFS: selftest: running hole first btrfs_get_extent test [ 32.433377] BTRFS: selftest: running outstanding_extents tests [ 32.434257] BTRFS: selftest: running qgroup tests [ 32.434373] BTRFS: selftest: running qgroup add/remove tests [ 32.434818] BTRFS: selftest: running qgroup multiple refs test [ 32.435655] BTRFS: selftest: running free space tree tests [ 32.877773] BTRFS: selftest: running extent_map tests [ 32.878137] BTRFS: selftest: running rmap tests [ 33.072074] rockchip-pcie f8000000.pcie: host bridge /pcie@f8000000 ranges: [ 33.073026] rockchip-pcie f8000000.pcie: MEM 0x00fa000000..0x00fbdfffff -> 0x00fa000000 [ 33.073259] rockchip-pcie f8000000.pcie: IO 0x00fbe00000..0x00fbefffff -> 0x00fbe00000 [ 33.077844] rockchip-pcie f8000000.pcie: Looking up vpcie12v-supply from device tree [ 33.078083] rockchip-pcie f8000000.pcie: Looking up vpcie12v-supply property in node /pcie@f8000000 failed [ 33.078823] rockchip-pcie f8000000.pcie: no vpcie12v regulator found [ 33.079068] rockchip-pcie f8000000.pcie: Looking up vpcie3v3-supply from device tree [ 33.080295] rockchip-pcie f8000000.pcie: Looking up vpcie1v8-supply from device tree [ 33.081188] rockchip-pcie f8000000.pcie: Looking up vpcie0v9-supply from device tree [ 33.122020] genirq: Setting trigger mode 2 for irq 15 failed (gic_set_type+0x0/0x138) [ 33.122820] irq: no irq domain found for interrupt-controller ! [ 33.122995] rockchip-pcie f8000000.pcie: IRQ client not found [ 33.132257] rockchip-iodomain ff320000.syscon:io-domains: Looking up pmu1830-supply from device tree [ 33.135488] rockchip-iodomain ff770000.syscon:io-domains: Looking up bt656-supply from device tree [ 33.136399] rockchip-iodomain ff770000.syscon:io-domains: Looking up audio-supply from device tree [ 33.136825] rockchip-iodomain ff770000.syscon:io-domains: Looking up sdmmc-supply from device tree [ 33.138130] rockchip-iodomain ff770000.syscon:io-domains: Looking up gpio1830-supply from device tree [ 33.154798] rockchip-drm display-subsystem: bound ff8f0000.vop (ops 0xffffffc010e887e8) [ 33.159530] rockchip-drm display-subsystem: bound ff900000.vop (ops 0xffffffc010e887e8) [ 33.161342] dwhdmi-rockchip ff940000.hdmi: Detected HDMI TX controller v2.11a with HDCP (DWC HDMI 2.0 TX PHY) [ 33.171366] rockchip-drm display-subsystem: bound ff940000.hdmi (ops 0xffffffc010e8c6c0) [ 33.180852] [drm] Initialized rockchip 1.0.0 20140818 for display-subsystem on minor 0 [ 33.183921] mali ff9a0000.gpu: No IRQ resource at index 1 [ 33.184155] mali ff9a0000.gpu: IRQ search failed [ 33.184644] mali: probe of ff9a0000.gpu failed with error -2 [ 33.190550] rockchip-thermal ff260000.tsadc: failed to register sensor 0: -517 [ 33.190882] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error = -517 [ 33.200478] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit address mode. [ 33.201294] dwmmc_rockchip fe310000.mmc: Using internal DMA controller. [ 33.201673] dwmmc_rockchip fe310000.mmc: Version ID is 270a [ 33.202201] dwmmc_rockchip fe310000.mmc: DW MMC controller at irq 17,32 bit host data width,256 deep fifo [ 33.203308] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree [ 33.203527] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply property in node /mmc@fe310000 failed [ 33.204253] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply from device tree [ 33.204424] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /mmc@fe310000 failed [ 33.216884] rockchip-thermal ff260000.tsadc: failed to register sensor 0: -517 [ 33.217686] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error = -517 [ 33.226865] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit address mode. [ 33.227549] dwmmc_rockchip fe310000.mmc: Using internal DMA controller. [ 33.227708] dwmmc_rockchip fe310000.mmc: Version ID is 270a [ 33.228322] dwmmc_rockchip fe310000.mmc: DW MMC controller at irq 17,32 bit host data width,256 deep fifo [ 33.229879] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree [ 33.230089] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply property in node /mmc@fe310000 failed [ 33.230767] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply from device tree [ 33.230963] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /mmc@fe310000 failed [ 33.268761] rockchip-thermal ff260000.tsadc: failed to register sensor 0: -517 [ 33.274833] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error = -517 [ 33.299373] clk: Not disabling unused clocks [ 33.300367] ALSA device list: [ 33.300487] #0: hdmi-sound [ 33.325969] Freeing unused kernel memory: 5504K [ 33.334276] Run /init as init process [ 33.334455] with arguments: [ 33.334569] /init [ 33.334643] with environment: [ 33.334724] HOME=/ [ 33.334796] TERM=linux [ 33.334872] earlyprintk=xen Loading, please wait... Starting version 245.4-4ubuntu3 [ 39.458844] rk_gmac-dwmac fe300000.ethernet: IRQ eth_wake_irq not found [ 39.459243] rk_gmac-dwmac fe300000.ethernet: IRQ eth_lpi not found [ 39.460311] rk_gmac-dwmac fe300000.ethernet: PTP uses main clock [ 39.460560] rk_gmac-dwmac fe300000.ethernet: Looking up phy-supply from device tree [ 39.462867] rk_gmac-dwmac fe300000.ethernet: clock input or output? (input). [ 39.463089] rk_gmac-dwmac fe300000.ethernet: TX delay(0x28). [ 39.463224] rk_gmac-dwmac fe300000.ethernet: RX delay(0x11). [ 39.463365] rk_gmac-dwmac fe300000.ethernet: integrated PHY? (no). [ 39.463717] rk_gmac-dwmac fe300000.ethernet: cannot get clock clk_mac_speed [ 39.463995] rk_gmac-dwmac fe300000.ethernet: clock input from PHY [ 39.469266] rk_gmac-dwmac fe300000.ethernet: init for RGMII [ 39.531375] rk_gmac-dwmac fe300000.ethernet: User ID: 0x10, Synopsys ID: 0x35 [ 39.540951] rk_gmac-dwmac fe300000.ethernet: DWMAC1000 [ 39.543024] rk_gmac-dwmac fe300000.ethernet: DMA HW capability register supported [ 39.543220] rk_gmac-dwmac fe300000.ethernet: RX Checksum Offload Engine supported [ 39.543358] rk_gmac-dwmac fe300000.ethernet: COE Type 2 [ 39.543476] rk_gmac-dwmac fe300000.ethernet: TX Checksum insertion supported [ 39.543614] rk_gmac-dwmac fe300000.ethernet: Wake-Up On Lan supported [ 39.544622] rk_gmac-dwmac fe300000.ethernet: Normal descriptors [ 39.545001] rk_gmac-dwmac fe300000.ethernet: Ring mode enabled [ 39.545138] rk_gmac-dwmac fe300000.ethernet: Enable RX Mitigation via HW Watchdog Timer [ 39.545312] rk_gmac-dwmac fe300000.ethernet: device MAC address 6e:d0:b3:b7:fc:57 [ 40.095457] libphy: stmmac: probed [ 40.096018] mdio_bus stmmac-0:00: attached PHY driver [unbound] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) [ 40.096233] mdio_bus stmmac-0:01: attached PHY driver [unbound] (mii_bus:phy_addr=stmmac-0:01, irq=POLL) [ 40.338726] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit address mode. [ 40.339251] dwmmc_rockchip fe310000.mmc: Using internal DMA controller. [ 40.339415] dwmmc_rockchip fe310000.mmc: Version ID is 270a [ 40.339902] dwmmc_rockchip fe310000.mmc: DW MMC controller at irq 17,32 bit host data width,256 deep fifo [ 40.344800] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree [ 40.345102] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply property in node /mmc@fe310000 failed [ 40.345849] rockchip-thermal ff260000.tsadc: failed to register sensor 0: -517 [ 40.345897] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply from device tree [ 40.346034] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error = -517 [ 40.346160] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /mmc@fe310000 failed Begin: Loading essential drivers ... done. Begin: Running /scripts/init-premount ... done. Begin: Mounting root file system ... Begin: Running /scripts/local-top ... done. Begin: Running /scripts/local-premount ... done. [ 64.586284] vcc3v3_pcie: disabling Begin: Waiting for root file system ... Begin: Running /scripts/local-block ... done. done. Gave up waiting for root file system device. Common problems: - Boot args (cat /proc/cmdline) - Check rootdelay= (did the system wait long enough?) - Missing modules (cat /proc/modules; ls /dev) ALERT! /dev/nvme0n1p2 does not exist. Dropping to a shell! BusyBox v1.30.1 (Ubuntu 1:1.30.1-4ubuntu6) built-in shell (ash) Enter 'help' for a list of built-in commands. (initramfs) - Brad --000000000000c00fc105e38bdacc Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

I've been trying to get Xen = to boot dom0 with my kernel for weeks on an rk3399 based board and thought = I'd reach out for help. It looks like either Xen is not properly recrea= ting the device tree or the interrupt controller is just failing. The hyper= visor boots but falls to initramfs because it cannot find the root device (= nvme on pcie). Any help would be greatly appreciated. Here is the complete = boot log

DDR Version 1.20 20190314
In
soft r= eset
SRX
channel 0
CS =3D 0
MR0=3D0x98
MR4=3D0x2
MR5=3D0x= FF
MR8=3D0x10
MR12=3D0x72
MR14=3D0x72
MR18=3D0x0
MR19=3D0x0<= br>MR24=3D0x8
MR25=3D0x0
channel 1
CS =3D 0
MR0=3D0x98
MR4= =3D0x2
MR5=3D0xFF
MR8=3D0x10
MR12=3D0x72
MR14=3D0x72
MR18=3D= 0x0
MR19=3D0x0
MR24=3D0x8
MR25=3D0x0
channel 0 training pass!channel 1 training pass!
change freq to 400MHz 0,1
channel 0
CS = =3D 0
MR0=3D0x98
MR4=3D0x2
MR5=3D0xFF
MR8=3D0x10
MR12=3D0x72=
MR14=3D0x72
MR18=3D0x0
MR19=3D0x0
MR24=3D0x8
MR25=3D0x0
= channel 1
CS =3D 0
MR0=3D0x98
MR4=3D0x2
MR5=3D0xFF
MR8=3D0x1= 0
MR12=3D0x72
MR14=3D0x72
MR18=3D0x0
MR19=3D0x0
MR24=3D0x8MR25=3D0x0
channel 0 training pass!
channel 1 training pass!
cha= nge freq to 800MHz 1,0
Channel 0: LPDDR4,800MHz
Bus Width=3D32 Col=3D= 10 Bank=3D8 Row=3D16 CS=3D1 Die Bus-Width=3D16 Size=3D2048MB
Channel 1: = LPDDR4,800MHz
Bus Width=3D32 Col=3D10 Bank=3D8 Row=3D16 CS=3D1 Die Bus-W= idth=3D16 Size=3D2048MB
256B stride
ch 0 ddrconfig =3D 0x101, ddrsize= =3D 0x40
ch 1 ddrconfig =3D 0x101, ddrsize =3D 0x40
pmugrf_os_reg[2]= =3D 0x32C1F2C1, stride =3D 0xD
OUT
Boot1: 2018-06-26, version: 1.14<= br>CPUId =3D 0x0
ChipType =3D 0x10, 280
Spi_ChipId =3D ef6017
SpiB= ootInit:0
mmc0:cmd8,32
mmc0:cmd5,32
mmc0:cmd55,32
mmc0:cmd1,32<= br>mmc0:cmd8,32
mmc0:cmd5,32
mmc0:cmd55,32
mmc0:cmd1,32
mmc0:cm= d8,32
mmc0:cmd5,32
mmc0:cmd55,32
mmc0:cmd1,32
SdmmcInit=3D0 1StorageInit ok =3D 23477
SecureMode =3D 0
SecureInit ret =3D 0, Sec= ureMode =3D 0
GPT vendor signature is wrong
LoadTrust Addr:0x1800
= No find bl30.bin
No find bl32.bin
Load uboot, ReadLba =3D 1000
Loa= d OK, addr=3D0x200000, size=3D0xc3140
RunBL31 0x10000
NOTICE: =C2=A0B= L31: v1.3(debug):0e7a845
NOTICE: =C2=A0BL31: Built : 16:13:46, Apr 17 20= 19
NOTICE: =C2=A0BL31: Rockchip release version: v1.1
INFO: =C2=A0 = =C2=A0GICv3 with legacy support detected. ARM GICV3 driver initialized in E= L3
INFO: =C2=A0 =C2=A0Using opteed sec cpu_context!
INFO: =C2=A0 =C2= =A0boot cpu mask: 0
INFO: =C2=A0 =C2=A0plat_rockchip_pmu_init(1181): pd = status 3e
INFO: =C2=A0 =C2=A0BL31: Initializing runtime services
WARN= ING: No OPTEE provided by BL2 boot loader, Booting device without OPTEE ini= tialization. SMC`s destined for OPTEE will return SMC_UNK
ERROR: =C2=A0 = Error initializing runtime service opteed_fast
INFO: =C2=A0 =C2=A0BL31: = Preparing for EL3 exit to normal world
INFO: =C2=A0 =C2=A0Entry point ad= dress =3D 0x200000
INFO: =C2=A0 =C2=A0SPSR =3D 0x3c9


U-Boot 2= 021.10 (Jul 11 2022 - 11:32:57 -0500)

SoC: Rockchip rk3399
Reset = cause: RST
Model: Vamrs RK3399 ZAKU
DRAM: =C2=A03.9 GiB
PMIC: =C2= =A0RK808
MMC: =C2=A0 mmc@fe310000: 3, mmc@fe330000: 0
Loading Enviro= nment from FAT... In: =C2=A0 =C2=A0serial
Out: =C2=A0 serial
Err: =C2= =A0 serial
Model: Vamrs RK3399 ZAKU
Net: =C2=A0 No ethernet found.Hit any key to stop autoboot: =C2=A00
zaku =3D>
zaku =3D> run= boot_pci_enum; run nvme_init; fatload nvme 0:1 0x02000000 xen-uImage; fatl= oad nvme 0:1 0x01f00000 rk3399-zaku.dtb;
1114184 bytes read in 8 ms (132= .8 MiB/s)
57153 bytes read in 5 ms (10.9 MiB/s)
zaku =3D> fatload = nvme 0:1 0x03F80000 Image;fatload nvme 0:1 0x06000000 initrd.img-5.15.16-1-= rockchip-g359ffc4bc727;bootm 0x02000000 - 0x00
27885576 bytes read in 75= ms (354.6 MiB/s)
8674182 bytes read in 28 ms (295.4 MiB/s)
## Bootin= g kernel from Legacy Image at 02000000 ...
=C2=A0 =C2=A0Image Name: =C2= =A0
=C2=A0 =C2=A0Image Type: =C2=A0 AArch64 Linux Kernel Image (uncompr= essed)
=C2=A0 =C2=A0Data Size: =C2=A0 =C2=A01114120 Bytes =3D 1.1 MiB=C2=A0 =C2=A0Load Address: 02000000
=C2=A0 =C2=A0Entry Point: =C2=A0020= 00000
=C2=A0 =C2=A0Verifying Checksum ... OK
## Flattened Device Tree= blob at 01f00000
=C2=A0 =C2=A0Booting using the fdt blob at 0x1f00000=C2=A0 =C2=A0Loading Kernel Image
=C2=A0 =C2=A0Loading Device Tree to = 00000000f1efd000, end 00000000f1f0df40 ... OK

Starting kernel ...
=C2=A0Xen 4.17-unstable
(XEN) Xen version 4.17-unstable (root@) (aa= rch64-linux-gnu-gcc (Linaro GCC 7.3-2018.05) 7.3.1 20180425 [linaro-7.3-201= 8.05 revision d2912
(XEN) Latest ChangeSet:
(XEN) build-id: aaba62ac= 5bc435965722c47224a16d44f95847b9
(XEN) Processor: 00000000410fd034: &quo= t;ARM Limited", variant: 0x0, part 0xd03,rev 0x4
(XEN) 64-bit Execu= tion:
(XEN) =C2=A0 Processor Features: 0000000001002222 0000000000000000=
(XEN) =C2=A0 =C2=A0 Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0= :64+32
(XEN) =C2=A0 =C2=A0 Extensions: FloatingPoint AdvancedSIMD GICv3-= SysReg
(XEN) =C2=A0 Debug Features: 0000000010305106 0000000000000000(XEN) =C2=A0 Auxiliary Features: 0000000000000000 0000000000000000
(XEN= ) =C2=A0 Memory Model Features: 0000000000001122 0000000000000000
(XEN) = =C2=A0 ISA Features: =C2=A00000000000011120 0000000000000000
(XEN) 32-bi= t Execution:
(XEN) =C2=A0 Processor Features: 0000000000000131:000000001= 0011011
(XEN) =C2=A0 =C2=A0 Instruction Sets: AArch32 A32 Thumb Thumb-2 = Jazelle
(XEN) =C2=A0 =C2=A0 Extensions: GenericTimer Security
(XEN) = =C2=A0 Debug Features: 0000000003010066
(XEN) =C2=A0 Auxiliary Features:= 0000000000000000
(XEN) =C2=A0 Memory Model Features: 0000000010201105 0= 000000040000000
(XEN) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A00000000001260000 0000000002102211<= br>(XEN) =C2=A0 ISA Features: 0000000002101110 0000000013112111 00000000212= 32042
(XEN) =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 0000= 000001112131 0000000000011142 0000000000011121
(XEN) Using SMC Calling C= onvention v1.0
(XEN) Using PSCI v1.0
(XEN) SMP: Allowing 6 CPUs
(X= EN) Generic Timer IRQ: phys=3D30 hyp=3D26 virt=3D27 Freq: 24000 KHz
(XEN= ) GICv3 initialization:
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_dist_addr=3D0x000= 000fee00000
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_maintenance_irq=3D25
(XEN)= =C2=A0 =C2=A0 =C2=A0 gic_rdist_stride=3D0
(XEN) =C2=A0 =C2=A0 =C2=A0 gi= c_rdist_regions=3D1
(XEN) =C2=A0 =C2=A0 =C2=A0 redistributor regions:(XEN) =C2=A0 =C2=A0 =C2=A0 =C2=A0 - region 0: 0x000000fef00000 - 0x000000f= efc0000
(XEN) GICv3 compatible with GICv2 cbase 0x000000fff00000 vbase 0= x000000fff20000
(XEN) GICv3: 288 lines, (IID 0001143b).
(XEN) GICv3: = CPU0: Found redistributor in region 0 @000000004001c000
(XEN) XSM Framew= ork v1.0.1 initialized
(XEN) Initialising XSM SILO mode
(XEN) Using s= cheduler: SMP Credit Scheduler rev2 (credit2)
(XEN) Initializing Credit2= scheduler
(XEN) =C2=A0load_precision_shift: 18
(XEN) =C2=A0load_wind= ow_shift: 30
(XEN) =C2=A0underload_balance_tolerance: 0
(XEN) =C2=A0o= verload_balance_tolerance: -3
(XEN) =C2=A0runqueues arrangement: socket<= br>(XEN) =C2=A0cap enforcement granularity: 10ms
(XEN) load tracking win= dow length 1073741824 ns
(XEN) Allocated console ring of 64 KiB.
(XEN= ) CPU0: Guest atomics will try 2 times before pausing the domain
(XEN) B= ringing up CPU1
(XEN) GICv3: CPU1: Found redistributor in region 0 @0000= 00004003c000
(XEN) CPU1: Guest atomics will try 3 times before pausing t= he domain
(XEN) CPU 1 booted.
(XEN) Bringing up CPU2
(XEN) GICv3: = CPU2: Found redistributor in region 0 @000000004005c000
(XEN) CPU2: Gues= t atomics will try 3 times before pausing the domain
(XEN) CPU 2 booted.=
(XEN) Bringing up CPU3
(XEN) GICv3: CPU3: Found redistributor in reg= ion 0 @000000004007c000
(XEN) CPU3: Guest atomics will try 3 times befor= e pausing the domain
(XEN) CPU 3 booted.
(XEN) Bringing up CPU4
(X= EN) CPU4 MIDR (0x00000000410fd082) does not match boot CPU MIDR (0x00000000= 410fd034),
(XEN) hmp-unsafe turned on so tainting Xen and keep core on!!=
(XEN) SANITY DIF: aa64mmfr0 0x1122 -> 0x1124
(XEN) SANITY DIF: ct= r 0x84448004 -> 0x8444c004
(XEN) GICv3: CPU4: Found redistributor in = region 0 @000000004009c000
(XEN) CPU4: Guest atomics will try 1 times be= fore pausing the domain
(XEN) enabled workaround for: ARM erratum 131953= 7
(XEN) CPU 4 booted.
(XEN) Bringing up CPU5
(XEN) CPU5 MIDR (0x00= 000000410fd082) does not match boot CPU MIDR (0x00000000410fd034),
(XEN)= hmp-unsafe turned on so tainting Xen and keep core on!!
(XEN) SANITY DI= F: aa64mmfr0 0x1122 -> 0x1124
(XEN) SANITY DIF: ctr 0x84448004 -> = 0x8444c004
(XEN) GICv3: CPU5: Found redistributor in region 0 @000000004= 00bc000
(XEN) CPU5: Guest atomics will try 1 times before pausing the do= main
(XEN) Brought up 6 CPUs
(XEN) CPU 5 booted.
(XEN) I/O virtual= isation disabled
(XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID
= (XEN) P2M: 3 levels with order-1 root, VTCR 0x0000000080023558
(XEN) Sch= eduling granularity: cpu, 1 CPU per sched-resource
(XEN) Initializing Cr= edit2 scheduler
(XEN) =C2=A0load_precision_shift: 18
(XEN) =C2=A0load= _window_shift: 30
(XEN) =C2=A0underload_balance_tolerance: 0
(XEN) = =C2=A0overload_balance_tolerance: -3
(XEN) =C2=A0runqueues arrangement: = socket
(XEN) =C2=A0cap enforcement granularity: 10ms
(XEN) load track= ing window length 1073741824 ns
(XEN) Adding cpu 0 to runqueue 0
(XEN= ) =C2=A0First cpu on runqueue, activating
(XEN) Adding cpu 1 to runqueue= 0
(XEN) Adding cpu 2 to runqueue 0
(XEN) Adding cpu 3 to runqueue 0<= br>(XEN) Adding cpu 4 to runqueue 0
(XEN) Adding cpu 5 to runqueue 0
= (XEN) alternatives: Patching with alt table 00000000002e5388 -> 00000000= 002e5e74
(XEN) **** No support for ARM_SMCCC_ARCH_WORKAROUND_1. ****
= (XEN) **** Please update your firmware. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0****
(XEN) *** LOADING DOMAIN 0 ***
(XEN) Loading= d0 kernel from boot module @ 0000000003f80000
(XEN) Loading ramdisk fro= m boot module @ 0000000006000000
(XEN) Allocating 1:1 mappings totalling= 512MB for dom0:
(XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB)=
(XEN) Grant table range: 0x00000002000000-0x00000002040000
(XEN) /pi= nctrl/pcie: Missing device_type
(XEN) /pinctrl/pcie: Missing device_type=
(XEN) /pinctrl/pcie: Missing device_type
(XEN) Allocating PPI 16 for= event channel interrupt
(XEN) d0: extended region 0: 0x2200000->0x20= 000000
(XEN) d0: extended region 1: 0x40000000->0xf8000000
(XEN) L= oading zImage from 0000000003f80000 to 0000000020000000-0000000021aa8008(XEN) Loading d0 initrd from 0000000006000000 to 0x0000000028200000-0x0000= 00002a200000
(XEN) Loading d0 DTB to 0x0000000028000000-0x000000002800d5= fb
(XEN) Initial low memory virq threshold set at 0x4000 pages.
(XEN)= Scrubbing Free RAM in background
(XEN) Std. Loglevel: All
(XEN) Gues= t Loglevel: All
(XEN) **************************************************= *
(XEN) WARNING: HMP COMPUTING HAS BEEN ENABLED.
(XEN) It has implica= tions on the security and stability of the system,
(XEN) unless the cpu = affinity of all domains is specified.
(XEN) ****************************= ***********************
(XEN) PLEASE SPECIFY dom0_mem PARAMETER - USING = 512M FOR NOW
(XEN) ***************************************************(XEN) 3... 2... 1...
(XEN) *** Serial input to DOM0 (type 'CTRL-a= ' three times to switch input)
(XEN) Freed 356kB init memory.
(XE= N) d0v0 Unhandled SMC/HVC: 0x84000050
(XEN) d0v0 Unhandled SMC/HVC: 0x86= 00ff01
(XEN) d0v0: vGICD: RAZ on reserved register offset 0x00000c
(X= EN) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER4
(XE= N) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER8
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER12
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER16
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER20
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER24
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER28
(XEN= ) d0v0: vGICD: unhandled word write 0x000000ffffffff to ICACTIVER32
(XEN= ) d0v0: vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0
= (XEN) d0v0 Unhandled SMC/HVC: 0x82000008
[ =C2=A0 =C2=A00.000000] Bootin= g Linux on physical CPU 0x0000000000 [0x410fd034]
[ =C2=A0 =C2=A00.00000= 0] Linux version 5.15.16-1-rockchip-g359ffc4bc727 (root@brad-ThinkCentre-M8= 2) (aarch64-linux-gnu-gcc (Linaro GCC 7.3-2018.052
[ =C2=A0 =C2=A00.0000= 00] Machine model: Vamrs RK3399 ZAKU
[ =C2=A0 =C2=A00.000000] printk: de= bug: ignoring loglevel setting.
[ =C2=A0 =C2=A00.000000] Xen 4.17 suppor= t found
[ =C2=A0 =C2=A00.000000] Zone ranges:
[ =C2=A0 =C2=A00.000000= ] =C2=A0 DMA =C2=A0 =C2=A0 =C2=A0[mem 0x0000000020000000-0x000000003fffffff= ]
[ =C2=A0 =C2=A00.000000] =C2=A0 DMA32 =C2=A0 =C2=A0empty
[ =C2=A0 = =C2=A00.000000] =C2=A0 Normal =C2=A0 empty
[ =C2=A0 =C2=A00.000000] Mova= ble zone start for each node
[ =C2=A0 =C2=A00.000000] Early memory node = ranges
[ =C2=A0 =C2=A00.000000] =C2=A0 node =C2=A0 0: [mem 0x00000000200= 00000-0x000000003fffffff]
[ =C2=A0 =C2=A00.000000] Initmem setup node 0 = [mem 0x0000000020000000-0x000000003fffffff]
[ =C2=A0 =C2=A00.000000] psc= i: probing for conduit method from DT.
[ =C2=A0 =C2=A00.000000] psci: PS= CIv1.1 detected in firmware.
[ =C2=A0 =C2=A00.000000] psci: Using standa= rd PSCI v0.2 function IDs
[ =C2=A0 =C2=A00.000000] psci: Trusted OS migr= ation not required
[ =C2=A0 =C2=A00.000000] psci: SMC Calling Convention= v1.1
[ =C2=A0 =C2=A00.000000] percpu: Embedded 27 pages/cpu s69672 r819= 2 d32728 u110592
[ =C2=A0 =C2=A00.000000] pcpu-alloc: s69672 r8192 d3272= 8 u110592 alloc=3D27*4096
[ =C2=A0 =C2=A00.000000] pcpu-alloc: [0] 0 [0]= 1 [0] 2 [0] 3 [0] 4 [0] 5
[ =C2=A0 =C2=A00.000000] Detected VIPT I-cac= he on CPU0
[ =C2=A0 =C2=A00.000000] CPU features: detected: GIC system r= egister CPU interface
[ =C2=A0 =C2=A00.000000] CPU features: detected: A= RM erratum 845719
[ =C2=A0 =C2=A00.000000] Built 1 zonelists, mobility g= rouping on.=C2=A0 Total pages: 129024
[ =C2=A0 =C2=A00.000000] Kernel co= mmand line: console=3Dhvc0 earlyprintk=3Dxen clk_ignore_unused root=3D/dev/= nvme0n1p2 rw init=3D/sbin/init rootwait rootfl
[ =C2=A0 =C2=A00.000000] = Unknown kernel command line parameters "earlyprintk=3Dxen", will = be passed to user space.
[ =C2=A0 =C2=A00.000000] Dentry cache hash tabl= e entries: 65536 (order: 7, 524288 bytes, linear)
[ =C2=A0 =C2=A00.00000= 0] Inode-cache hash table entries: 32768 (order: 6, 262144 bytes, linear)[ =C2=A0 =C2=A00.000000] mem auto-init: stack:off, heap alloc:off, heap f= ree:off
[ =C2=A0 =C2=A00.000000] Memory: 452668K/524288K available (1401= 6K kernel code, 2720K rwdata, 4856K rodata, 5504K init, 553K bss, 71620K re= served,)
[ =C2=A0 =C2=A00.000000] SLUB: HWalign=3D64, Order=3D0-3, MinOb= jects=3D0, CPUs=3D6, Nodes=3D1
[ =C2=A0 =C2=A00.000000] ftrace: allocati= ng 54793 entries in 215 pages
[ =C2=A0 =C2=A00.000000] ftrace: allocated= 215 pages with 6 groups
[ =C2=A0 =C2=A00.000000] trace event string ver= ifier disabled
[ =C2=A0 =C2=A00.000000] rcu: Hierarchical RCU implementa= tion.
[ =C2=A0 =C2=A00.000000] rcu: =C2=A0 =C2=A0 RCU event tracing is e= nabled.
[ =C2=A0 =C2=A00.000000] rcu: =C2=A0 =C2=A0 RCU restricting CPUs= from NR_CPUS=3D8 to nr_cpu_ids=3D6.
[ =C2=A0 =C2=A00.000000] =C2=A0Rude= variant of Tasks RCU enabled.
[ =C2=A0 =C2=A00.000000] rcu: RCU calcula= ted value of scheduler-enlistment delay is 25 jiffies.
[ =C2=A0 =C2=A00.= 000000] rcu: Adjusting geometry for rcu_fanout_leaf=3D16, nr_cpu_ids=3D6[ =C2=A0 =C2=A00.000000] NR_IRQS: 64, nr_irqs: 64, preallocated irqs: 0[ =C2=A0 =C2=A00.000000] GICv3: 256 SPIs implemented
[ =C2=A0 =C2=A00.0= 00000] GICv3: 0 Extended SPIs implemented
[ =C2=A0 =C2=A00.000000] GICv3= : Distributor has no Range Selector support
[ =C2=A0 =C2=A00.000000] Roo= t IRQ handler: gic_handle_irq
[ =C2=A0 =C2=A00.000000] GICv3: 16 PPIs im= plemented
[ =C2=A0 =C2=A00.000000] GICv3: CPU0: found redistributor 0 re= gion 0:0x00000000fef00000
[ =C2=A0 =C2=A00.000000] random: get_random_by= tes called from start_kernel+0x44c/0x6bc with crng_init=3D0
[ =C2=A0 =C2= =A00.000000] arch_timer: cp15 timer(s) running at 24.00MHz (virt).
[ =C2= =A0 =C2=A00.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff m= ax_cycles: 0x588fe9dc0, max_idle_ns: 440795202592 ns
[ =C2=A0 =C2=A00.00= 0003] sched_clock: 56 bits at 24MHz, resolution 41ns, wraps every 439804651= 1097ns
[ =C2=A0 =C2=A00.004184] Console: colour dummy device 80x25
[ = =C2=A0 =C2=A00.010034] printk: console [hvc0] enabled
[ =C2=A0 =C2=A00.0= 10272] Calibrating delay loop (skipped), value calculated using timer frequ= ency.. 48.00 BogoMIPS (lpj=3D96000)
[ =C2=A0 =C2=A00.010509] pid_max: de= fault: 32768 minimum: 301
[ =C2=A0 =C2=A00.011188] LSM: Security Framewo= rk initializing
[ =C2=A0 =C2=A00.011384] Yama: becoming mindful.
[ = =C2=A0 =C2=A00.011799] Mount-cache hash table entries: 1024 (order: 1, 8192= bytes, linear)
[ =C2=A0 =C2=A00.012105] Mountpoint-cache hash table ent= ries: 1024 (order: 1, 8192 bytes, linear)
[ =C2=A0 =C2=A00.027498] xen:g= rant_table: Grant tables using version 1 layout
[ =C2=A0 =C2=A00.027843]= Grant table initialized
[ =C2=A0 =C2=A00.028195] xen:events: Using FIFO= -based ABI
[ =C2=A0 =C2=A00.028613] Xen: initializing cpu0
[ =C2=A0 = =C2=A00.029559] rcu: Hierarchical SRCU implementation.
[ =C2=A0 =C2=A00.= 038337] smp: Bringing up secondary CPUs ...
(XEN) d0v1: vGICR: SGI: unha= ndled word write 0x000000ffffffff to ICACTIVER0
(XEN) d0v2: vGICR: SGI: = unhandled word write 0x000000ffffffff to ICACTIVER0
(XEN) d0v3: vGICR: S= GI: unhandled word write 0x000000ffffffff to ICACTIVER0
(XEN) d0v4: vGIC= R: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0
(XEN) d0v5: = vGICR: SGI: unhandled word write 0x000000ffffffff to ICACTIVER0
[ =C2=A0= =C2=A00.042396] Detected VIPT I-cache on CPU1
[ =C2=A0 =C2=A00.042606] = GICv3: CPU1: found redistributor 1 region 0:0x00000000fef20000
[ =C2=A0 = =C2=A00.043215] Xen: initializing cpu1
[ =C2=A0 =C2=A00.043511] CPU1: Bo= oted secondary processor 0x0000000001 [0x410fd034]
[ =C2=A0 =C2=A00.0479= 57] Detected VIPT I-cache on CPU2
[ =C2=A0 =C2=A00.048177] GICv3: CPU2: = found redistributor 2 region 0:0x00000000fef40000
[ =C2=A0 =C2=A00.04877= 8] Xen: initializing cpu2
[ =C2=A0 =C2=A00.049066] CPU2: Booted secondar= y processor 0x0000000002 [0x410fd034]
[ =C2=A0 =C2=A00.052901] Detected = VIPT I-cache on CPU3
[ =C2=A0 =C2=A00.053120] GICv3: CPU3: found redistr= ibutor 3 region 0:0x00000000fef60000
[ =C2=A0 =C2=A00.053626] Xen: initi= alizing cpu3
[ =C2=A0 =C2=A00.053907] CPU3: Booted secondary processor 0= x0000000003 [0x410fd034]
[ =C2=A0 =C2=A00.062107] CPU features: detected= : Spectre-v2
[ =C2=A0 =C2=A00.063039] CPU features: detected: Spectre-v4=
[ =C2=A0 =C2=A00.063673] CPU features: detected: ARM errata 1165522, 13= 19367, or 1530923
[ =C2=A0 =C2=A00.067132] Detected PIPT I-cache on CPU4=
[ =C2=A0 =C2=A00.072165] GICv3: CPU4: found redistributor 4 region 0:0x= 00000000fef80000
[ =C2=A0 =C2=A00.081044] Xen: initializing cpu4
[ = =C2=A0 =C2=A00.086534] CPU4: Booted secondary processor 0x0000000004 [0x410= fd082]
[ =C2=A0 =C2=A00.111175] Detected PIPT I-cache on CPU5
[ =C2= =A0 =C2=A00.116450] GICv3: CPU5: found redistributor 5 region 0:0x00000000f= efa0000
[ =C2=A0 =C2=A00.125174] Xen: initializing cpu5
[ =C2=A0 =C2= =A00.130645] CPU5: Booted secondary processor 0x0000000005 [0x410fd082]
= [ =C2=A0 =C2=A00.141980] smp: Brought up 1 node, 6 CPUs
[ =C2=A0 =C2=A00= .144637] SMP: Total of 6 processors activated.
[ =C2=A0 =C2=A00.144881] = CPU features: detected: 32-bit EL0 Support
[ =C2=A0 =C2=A00.145127] CPU = features: detected: CRC32 instructions
[ =C2=A0 =C2=A00.151947] CPU: All= CPU(s) started at EL1
[ =C2=A0 =C2=A00.155749] alternatives: patching k= ernel code
[ =C2=A0 =C2=A00.163024] devtmpfs: initialized
[ =C2=A0 = =C2=A00.235277] Registered cp15_barrier emulation handler
[ =C2=A0 =C2= =A00.238449] Registered setend emulation handler
[ =C2=A0 =C2=A00.239670= ] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_n= s: 7645041785100000 ns
[ =C2=A0 =C2=A00.240040] futex hash table entries= : 2048 (order: 5, 131072 bytes, linear)
[ =C2=A0 =C2=A00.241754] pinctrl= core: initialized pinctrl subsystem
[ =C2=A0 =C2=A00.243287] regulator-= dummy: no parameters, enabled
[ =C2=A0 =C2=A00.246947] NET: Registered P= F_NETLINK/PF_ROUTE protocol family
[ =C2=A0 =C2=A00.260401] DMA: preallo= cated 128 KiB GFP_KERNEL pool for atomic allocations
[ =C2=A0 =C2=A00.26= 0878] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DMA pool for atomic allocati= ons
[ =C2=A0 =C2=A00.261294] DMA: preallocated 128 KiB GFP_KERNEL|GFP_DM= A32 pool for atomic allocations
[ =C2=A0 =C2=A00.261822] audit: initiali= zing netlink subsys (disabled)
[ =C2=A0 =C2=A00.268125] audit: type=3D20= 00 audit(0.256:1): state=3Dinitialized audit_enabled=3D0 res=3D1
[ =C2= =A0 =C2=A00.278540] thermal_sys: Registered thermal governor 'fair_shar= e'
[ =C2=A0 =C2=A00.278731] thermal_sys: Registered thermal governor= 'step_wise'
[ =C2=A0 =C2=A00.279675] OF: /thermal-zones/cpu-the= rmal/cooling-maps/map0: could not find phandle 6
[ =C2=A0 =C2=A00.280151= ] thermal_sys: Add a cooling_device property with at least one device
[ = =C2=A0 =C2=A00.280307] thermal_sys: failed to build thermal zone cpu-therma= l: -2
[ =C2=A0 =C2=A00.283478] hw-breakpoint: found 6 breakpoint and 4 w= atchpoint registers.
[ =C2=A0 =C2=A00.299995] ASID allocator initialised= with 65536 entries
[ =C2=A0 =C2=A00.300424] xen:swiotlb_xen: Warning: o= nly able to allocate 4 MB for software IO TLB
[ =C2=A0 =C2=A00.303971] s= oftware IO TLB: mapped [mem 0x0000000022800000-0x0000000022c00000] (4MB)[ =C2=A0 =C2=A00.310583] ------------[ cut here ]------------
[ =C2=A0 = =C2=A00.310855] WARNING: CPU: 0 PID: 1 at drivers/irqchip/irq-gic-v3.c:1533= gic_irq_domain_select+0x70/0x12c
[ =C2=A0 =C2=A00.311156] Modules linke= d in:
[ =C2=A0 =C2=A00.311317] CPU: 0 PID: 1 Comm: swapper/0 Not tainted= 5.15.16-1-rockchip-g359ffc4bc727 #1
[ =C2=A0 =C2=A00.311536] Hardware n= ame: Vamrs RK3399 ZAKU (DT)
[ =C2=A0 =C2=A00.311673] pstate: 20000005 (n= zCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=3D--)
[ =C2=A0 =C2=A00.311890] = pc : gic_irq_domain_select+0x70/0x12c
[ =C2=A0 =C2=A00.312063] lr : gic_= irq_domain_select+0x6c/0x12c
[ =C2=A0 =C2=A00.312273] sp : ffffffc011b5b= 8c0
[ =C2=A0 =C2=A00.312385] x29: ffffffc011b5b8c0 x28: ffffff8021e37a80= x27: ffffff8021e37a00
[ =C2=A0 =C2=A00.312634] x26: ffffff803feb92b0 x2= 5: 0000000000000000 x24: ffffffc011b5b9f8
[ =C2=A0 =C2=A00.312871] x23: = ffffff8021c0c400 x22: ffffffc01120a000 x21: ffffffc0118f6000
[ =C2=A0 = =C2=A00.313111] x20: ffffffc011b5b9f8 x19: ffffff8021c0c400 x18: 0000000000= 00000a
[ =C2=A0 =C2=A00.313350] x17: ffffffffffffffff x16: fffffffffffff= fff x15: ffffffffffffffff
[ =C2=A0 =C2=A00.313568] x14: ffffffffffffffff= x13: ffffffffffffffff x12: ffffffffffffffff
[ =C2=A0 =C2=A00.313805] x1= 1: 0000000000000038 x10: 0101010101010101 x9 : ffffffffffffffff
[ =C2=A0= =C2=A00.314042] x8 : 7f7f7f7f7f7f7f7f x7 : ff71646b6b6e7173 x6 : 000000000= 0000080
[ =C2=A0 =C2=A00.314278] x5 : 0000000000000000 x4 : 000000000000= 0000 x3 : ffffffc011b5b90c
[ =C2=A0 =C2=A00.314515] x2 : ffffffc011b5b91= 0 x1 : 00000000a110c8ee x0 : 00000000ffffffea
[ =C2=A0 =C2=A00.314752] C= all trace:
[ =C2=A0 =C2=A00.314853] =C2=A0gic_irq_domain_select+0x70/0x1= 2c
[ =C2=A0 =C2=A00.315004] =C2=A0irq_find_matching_fwspec+0x78/0xf4
= [ =C2=A0 =C2=A00.315307] =C2=A0irq_create_fwspec_mapping+0x4c/0x2d4
[ = =C2=A0 =C2=A00.315476] =C2=A0irq_create_of_mapping+0x6c/0xa4
[ =C2=A0 = =C2=A00.315656] =C2=A0of_irq_get+0x64/0xa4
[ =C2=A0 =C2=A00.315801] =C2= =A0of_irq_to_resource+0x48/0xfc
[ =C2=A0 =C2=A00.315953] =C2=A0of_irq_to= _resource_table+0x54/0x68
[ =C2=A0 =C2=A00.316166] =C2=A0of_device_alloc= +0x108/0x1b0
[ =C2=A0 =C2=A00.316316] =C2=A0of_platform_device_create_pd= ata+0x7c/0xdc
[ =C2=A0 =C2=A00.316506] =C2=A0of_platform_bus_create+0x3a= 0/0x468
[ =C2=A0 =C2=A00.316665] =C2=A0of_platform_populate+0x100/0x118<= br>[ =C2=A0 =C2=A00.316808] =C2=A0of_platform_default_populate+0x40/0x50[ =C2=A0 =C2=A00.316959] =C2=A0of_platform_default_populate_init+0x7c/0xb4=
[ =C2=A0 =C2=A00.317149] =C2=A0do_one_initcall+0x94/0x1c4
[ =C2=A0 = =C2=A00.317299] =C2=A0kernel_init_freeable+0x2b0/0x2b8
[ =C2=A0 =C2=A00.= 317494] =C2=A0kernel_init+0x28/0x120
[ =C2=A0 =C2=A00.317628] =C2=A0ret_= from_fork+0x10/0x20
[ =C2=A0 =C2=A00.317804] ---[ end trace 85c6a508ffaf= c11e ]---
[ =C2=A0 =C2=A00.318293] irq: no irq domain found for interrup= t-controller !
[ =C2=A0 =C2=A00.390494] irq: type mismatch, failed to ma= p hwirq-32 for interrupt-controller!
[ =C2=A0 =C2=A00.401389] irq: type = mismatch, failed to map hwirq-32 for interrupt-controller!
[ =C2=A0 =C2= =A00.403373] irq: type mismatch, failed to map hwirq-32 for interrupt-contr= oller!
[ =C2=A0 =C2=A00.413685] platform ff770000.syscon:phy@f780: Fixin= g up cyclic dependency with fe330000.mmc
[ =C2=A0 =C2=A00.439170] platfo= rm ff940000.hdmi: Fixing up cyclic dependency with ff8f0000.vop
[ =C2=A0= =C2=A00.440132] platform ff940000.hdmi: Fixing up cyclic dependency with f= f900000.vop
[ =C2=A0 =C2=A00.442114] irq: type mismatch, failed to map h= wirq-32 for interrupt-controller!
[ =C2=A0 =C2=A00.479376] rockchip-gpio= ff720000.gpio0: probed /pinctrl/gpio0@ff720000
[ =C2=A0 =C2=A00.484466]= rockchip-gpio ff730000.gpio1: probed /pinctrl/gpio1@ff730000
[ =C2=A0 = =C2=A00.489044] rockchip-gpio ff780000.gpio2: probed /pinctrl/gpio2@ff78000= 0
[ =C2=A0 =C2=A00.493295] rockchip-gpio ff788000.gpio3: probed /pinctrl= /gpio3@ff788000
[ =C2=A0 =C2=A00.497205] rockchip-gpio ff790000.gpio4: p= robed /pinctrl/gpio4@ff790000
[ =C2=A0 =C2=A00.601234] HugeTLB registere= d 1.00 GiB page size, pre-allocated 0 pages
[ =C2=A0 =C2=A00.602111] Hug= eTLB registered 32.0 MiB page size, pre-allocated 0 pages
[ =C2=A0 =C2= =A00.602269] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages[ =C2=A0 =C2=A00.602440] HugeTLB registered 64.0 KiB page size, pre-alloc= ated 0 pages
[ =C2=A0 =C2=A00.732446] cryptd: max_cpu_qlen set to 1000[ =C2=A0 =C2=A00.965984] raid6: neonx8 =C2=A0 gen() =C2=A0 343 MB/s
[ = =C2=A0 =C2=A01.037514] raid6: neonx8 =C2=A0 xor() =C2=A0 265 MB/s
[ =C2= =A0 =C2=A01.108822] raid6: neonx4 =C2=A0 gen() =C2=A0 358 MB/s
[ =C2=A0 = =C2=A01.180595] raid6: neonx4 =C2=A0 xor() =C2=A0 264 MB/s
[ =C2=A0 =C2= =A01.251750] raid6: neonx2 =C2=A0 gen() =C2=A0 332 MB/s
[ =C2=A0 =C2=A01= .322968] raid6: neonx2 =C2=A0 xor() =C2=A0 242 MB/s
[ =C2=A0 =C2=A01.394= 615] raid6: neonx1 =C2=A0 gen() =C2=A0 289 MB/s
[ =C2=A0 =C2=A01.465958]= raid6: neonx1 =C2=A0 xor() =C2=A0 199 MB/s
[ =C2=A0 =C2=A01.537820] rai= d6: int64x8 =C2=A0gen() =C2=A0 =C2=A087 MB/s
[ =C2=A0 =C2=A01.609578] ra= id6: int64x8 =C2=A0xor() =C2=A0 =C2=A051 MB/s
[ =C2=A0 =C2=A01.681302] r= aid6: int64x4 =C2=A0gen() =C2=A0 107 MB/s
[ =C2=A0 =C2=A01.753475] raid6= : int64x4 =C2=A0xor() =C2=A0 =C2=A056 MB/s
[ =C2=A0 =C2=A01.824651] raid= 6: int64x2 =C2=A0gen() =C2=A0 182 MB/s
[ =C2=A0 =C2=A01.895619] raid6: i= nt64x2 =C2=A0xor() =C2=A0 100 MB/s
[ =C2=A0 =C2=A01.966829] raid6: int64= x1 =C2=A0gen() =C2=A0 136 MB/s
[ =C2=A0 =C2=A02.038152] raid6: int64x1 = =C2=A0xor() =C2=A0 =C2=A062 MB/s
[ =C2=A0 =C2=A02.038278] raid6: using a= lgorithm neonx4 gen() 358 MB/s
[ =C2=A0 =C2=A02.038388] raid6: .... xor(= ) 264 MB/s, rmw enabled
[ =C2=A0 =C2=A02.038485] raid6: using neon recov= ery algorithm
[ =C2=A0 =C2=A02.039515] xen:balloon: Initialising balloon= driver
[ =C2=A0 =C2=A02.043846] vcc12v_dcin: 12000 mV, enabled
[ =C2= =A0 =C2=A02.044876] reg-fixed-voltage vcc12v-dcin: vcc12v_dcin supplying 12= 000000uV
[ =C2=A0 =C2=A02.045966] vcc1v8_s0: 1800 mV, enabled
[ =C2= =A0 =C2=A02.046981] reg-fixed-voltage vcc1v8-s0: vcc1v8_s0 supplying 180000= 0uV
[ =C2=A0 =C2=A02.047907] vcc5v0_sys: will resolve supply early: vin<= br>[ =C2=A0 =C2=A02.048079] reg-fixed-voltage vcc5v0-sys: Looking up vin-su= pply from device tree
[ =C2=A0 =C2=A02.048293] vcc5v0_sys: supplied by v= cc12v_dcin
[ =C2=A0 =C2=A02.048447] vcc12v_dcin: could not add device li= nk regulator.3: -ENOENT
[ =C2=A0 =C2=A02.048990] vcc5v0_sys: 5000 mV, en= abled
[ =C2=A0 =C2=A02.049877] reg-fixed-voltage vcc5v0-sys: vcc5v0_sys = supplying 5000000uV
[ =C2=A0 =C2=A02.051218] vcc_phy: no parameters, ena= bled
[ =C2=A0 =C2=A02.052029] reg-fixed-voltage vcc-phy-regulator: vcc_p= hy supplying 0uV
[ =C2=A0 =C2=A02.052969] vcc3v3_sys: will resolve suppl= y early: vin
[ =C2=A0 =C2=A02.053173] reg-fixed-voltage vcc3v3-sys: Look= ing up vin-supply from device tree
[ =C2=A0 =C2=A02.053379] vcc3v3_sys: = supplied by vcc5v0_sys
[ =C2=A0 =C2=A02.053545] vcc5v0_sys: could not ad= d device link regulator.5: -ENOENT
[ =C2=A0 =C2=A02.053932] vcc3v3_sys: = 3300 mV, enabled
[ =C2=A0 =C2=A02.054924] reg-fixed-voltage vcc3v3-sys: = vcc3v3_sys supplying 3300000uV
[ =C2=A0 =C2=A02.055842] rockchip-pinctrl= pinctrl: unsupported driver strength 20
[ =C2=A0 =C2=A02.056049] rockch= ip-pinctrl pinctrl: pin_config_set op failed for pin 146
[ =C2=A0 =C2=A0= 2.056203] reg-fixed-voltage vcc3v3-pcie-regulator: Error applying setting, = reverse things back
[ =C2=A0 =C2=A02.057192] vcc3v3_pcie: will resolve s= upply early: vin
[ =C2=A0 =C2=A02.057379] reg-fixed-voltage vcc3v3-pcie-= regulator: Looking up vin-supply from device tree
[ =C2=A0 =C2=A02.05757= 5] vcc3v3_pcie: supplied by vcc3v3_sys
[ =C2=A0 =C2=A02.057760] vcc3v3_s= ys: could not add device link regulator.6: -ENOENT
[ =C2=A0 =C2=A02.0582= 67] vcc3v3_pcie: 3300 mV, enabled
[ =C2=A0 =C2=A02.059496] reg-fixed-vol= tage vcc3v3-pcie-regulator: vcc3v3_pcie supplying 3300000uV
[ =C2=A0 =C2= =A02.061208] vcc5v0_usb: will resolve supply early: vin
[ =C2=A0 =C2=A02= .061375] reg-fixed-voltage vcc5v0-usb-regulator: Looking up vin-supply from= device tree
[ =C2=A0 =C2=A02.061595] vcc5v0_usb: supplied by vcc5v0_sys=
[ =C2=A0 =C2=A02.061736] vcc5v0_sys: could not add device link regulato= r.7: -ENOENT
[ =C2=A0 =C2=A02.062164] vcc5v0_usb: 5000 mV, enabled
[ = =C2=A0 =C2=A02.063312] reg-fixed-voltage vcc5v0-usb-regulator: vcc5v0_usb s= upplying 5000000uV
[ =C2=A0 =C2=A02.064318] vcc_0v9: will resolve supply= early: vin
[ =C2=A0 =C2=A02.064511] reg-fixed-voltage vcc-0v9: Looking = up vin-supply from device tree
[ =C2=A0 =C2=A02.064705] vcc_0v9: supplie= d by vcc3v3_sys
[ =C2=A0 =C2=A02.064902] vcc3v3_sys: could not add devic= e link regulator.8: -ENOENT
[ =C2=A0 =C2=A02.065383] vcc_0v9: 900 mV, en= abled
[ =C2=A0 =C2=A02.066280] reg-fixed-voltage vcc-0v9: vcc_0v9 supply= ing 900000uV
[ =C2=A0 =C2=A02.071921] iommu: Default domain type: Transl= ated
[ =C2=A0 =C2=A02.072285] iommu: DMA domain TLB invalidation policy= : strict mode
[ =C2=A0 =C2=A02.089090] SCSI subsystem initialized
[ = =C2=A0 =C2=A02.097346] libata version 3.00 loaded.
[ =C2=A0 =C2=A02.0985= 01] usbcore: registered new interface driver usbfs
[ =C2=A0 =C2=A02.0989= 31] usbcore: registered new interface driver hub
[ =C2=A0 =C2=A02.099344= ] usbcore: registered new device driver usb
[ =C2=A0 =C2=A02.100020] mc:= Linux media interface: v0.10
[ =C2=A0 =C2=A02.100319] videodev: Linux v= ideo capture interface: v2.00
[ =C2=A0 =C2=A02.100991] pps_core: LinuxPP= S API ver. 1 registered
[ =C2=A0 =C2=A02.101145] pps_core: Software ver.= 5.3.6 - Copyright 2005-2007 Rodolfo Giometti <giometti@linux.it>
[ =C2=A0 =C2=A02.101402] PTP clock= support registered
[ =C2=A0 =C2=A02.107595] Advanced Linux Sound Archit= ecture Driver Initialized.
[ =C2=A0 =C2=A02.111011] Bluetooth: Core ver = 2.22
[ =C2=A0 =C2=A02.111358] NET: Registered PF_BLUETOOTH protocol fami= ly
[ =C2=A0 =C2=A02.111517] Bluetooth: HCI device and connection manager= initialized
[ =C2=A0 =C2=A02.111680] Bluetooth: HCI socket layer initia= lized
[ =C2=A0 =C2=A02.111857] Bluetooth: L2CAP socket layer initialized=
[ =C2=A0 =C2=A02.112069] Bluetooth: SCO socket layer initialized
[ = =C2=A0 =C2=A02.112296] NetLabel: Initializing
[ =C2=A0 =C2=A02.112402] N= etLabel: =C2=A0domain hash size =3D 128
[ =C2=A0 =C2=A02.112517] NetLabe= l: =C2=A0protocols =3D UNLABELED CIPSOv4 CALIPSO
[ =C2=A0 =C2=A02.113111= ] NetLabel: =C2=A0unlabeled traffic allowed by default
[ =C2=A0 =C2=A02.= 122030] clocksource: Switched to clocksource arch_sys_counter
[ =C2=A0 = =C2=A02.413055] VFS: Disk quotas dquot_6.6.0
[ =C2=A0 =C2=A02.414148] VF= S: Dquot-cache hash table entries: 512 (order 0, 4096 bytes)
[ =C2=A0 = =C2=A02.475712] NET: Registered PF_INET protocol family
[ =C2=A0 =C2=A02= .476923] IP idents hash table entries: 8192 (order: 4, 65536 bytes, linear)=
[ =C2=A0 =C2=A02.482548] tcp_listen_portaddr_hash hash table entries: 2= 56 (order: 1, 10240 bytes, linear)
[ =C2=A0 =C2=A02.483081] TCP establis= hed hash table entries: 4096 (order: 3, 32768 bytes, linear)
[ =C2=A0 = =C2=A02.483542] TCP bind hash table entries: 4096 (order: 5, 131072 bytes, = linear)
[ =C2=A0 =C2=A02.484397] TCP: Hash tables configured (establishe= d 4096 bind 4096)
[ =C2=A0 =C2=A02.485284] UDP hash table entries: 256 (= order: 2, 24576 bytes, linear)
[ =C2=A0 =C2=A02.485892] UDP-Lite hash ta= ble entries: 256 (order: 2, 24576 bytes, linear)
[ =C2=A0 =C2=A02.487194= ] NET: Registered PF_UNIX/PF_LOCAL protocol family
[ =C2=A0 =C2=A02.4874= 92] PCI: CLS 0 bytes, default 64
[ =C2=A0 =C2=A02.490694] Trying to unpa= ck rootfs image as initramfs...
[ =C2=A0 =C2=A03.097632] rootfs image is= not initramfs (Decoding failed); looks like an initrd
[ =C2=A0 =C2=A03.= 477246] Freeing initrd memory: 32768K
[ =C2=A0 =C2=A03.816771] Initialis= e system trusted keyrings
[ =C2=A0 =C2=A03.828487] workingset: timestamp= _bits=3D46 max_order=3D17 bucket_order=3D0
[ =C2=A0 =C2=A04.594980] squa= shfs: version 4.0 (2009/01/31) Phillip Lougher
[ =C2=A0 =C2=A04.639877] = fuse: init (API version 7.34)
[ =C2=A0 =C2=A04.692812] JFS: nTxBlock =3D= 3790, nTxLock =3D 30323
[ =C2=A0 =C2=A04.875022] SGI XFS with ACLs, sec= urity attributes, realtime, verbose warnings, quota, no debug enabled
[ = =C2=A0 10.116665] NET: Registered PF_ALG protocol family
[ =C2=A0 10.117= 252] xor: measuring software checksum speed
[ =C2=A0 10.145130] =C2=A0 = =C2=A08regs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 : =C2=A0 361 MB/sec
[ =C2= =A0 10.165698] =C2=A0 =C2=A032regs =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0: =C2= =A0 482 MB/sec
[ =C2=A0 10.191437] =C2=A0 =C2=A0arm64_neon =C2=A0 =C2=A0= =C2=A0: =C2=A0 384 MB/sec
[ =C2=A0 10.191569] xor: using function: 32re= gs (482 MB/sec)
[ =C2=A0 10.192042] Key type asymmetric registered
[ = =C2=A0 10.192188] Asymmetric key parser 'x509' registered
[ =C2= =A0 10.194224] Block layer SCSI generic (bsg) driver version 0.4 loaded (ma= jor 246)
[ =C2=A0 10.200293] io scheduler mq-deadline registered
[ = =C2=A0 10.200447] io scheduler kyber registered
[ =C2=A0 10.213640] phy = phy-ff770000.syscon:phy@f780.0: Looking up phy-supply from device tree
[= =C2=A0 10.213957] phy phy-ff770000.syscon:phy@f780.0: Looking up phy-suppl= y property in node /syscon@ff770000/phy@f780 failed
[ =C2=A0 10.222938] = phy phy-ff770000.syscon:usb2phy@e450.1: Looking up phy-supply from device t= ree
[ =C2=A0 10.223420] vcc5v0_usb: could not add device link phy-ff7700= 00.syscon:usb2phy@e450.1: -ENOENT
[ =C2=A0 10.228300] phy phy-ff770000.s= yscon:usb2phy@e450.2: Looking up phy-supply from device tree
[ =C2=A0 10= .228648] phy phy-ff770000.syscon:usb2phy@e450.2: Looking up phy-supply prop= erty in node /syscon@ff770000/usb2phy@e450/otg-port faid
[ =C2=A0 10.237= 376] phy phy-ff770000.syscon:usb2phy@e460.3: Looking up phy-supply from dev= ice tree
[ =C2=A0 10.238041] vcc5v0_usb: could not add device link phy-f= f770000.syscon:usb2phy@e460.3: -ENOENT
[ =C2=A0 10.242605] phy phy-ff770= 000.syscon:usb2phy@e460.4: Looking up phy-supply from device tree
[ =C2= =A0 10.242946] phy phy-ff770000.syscon:usb2phy@e460.4: Looking up phy-suppl= y property in node /syscon@ff770000/usb2phy@e460/otg-port faid
[ =C2=A0 = 10.247126] phy phy-ff770000.syscon:pcie-phy.5: Looking up phy-supply from d= evice tree
[ =C2=A0 10.247400] phy phy-ff770000.syscon:pcie-phy.5: Looki= ng up phy-supply property in node /syscon@ff770000/pcie-phy failed
[ =C2= =A0 10.248209] phy phy-ff770000.syscon:pcie-phy.6: Looking up phy-supply fr= om device tree
[ =C2=A0 10.248426] phy phy-ff770000.syscon:pcie-phy.6: L= ooking up phy-supply property in node /syscon@ff770000/pcie-phy failed
[= =C2=A0 10.249176] phy phy-ff770000.syscon:pcie-phy.7: Looking up phy-suppl= y from device tree
[ =C2=A0 10.249393] phy phy-ff770000.syscon:pcie-phy.= 7: Looking up phy-supply property in node /syscon@ff770000/pcie-phy failed<= br>[ =C2=A0 10.250343] phy phy-ff770000.syscon:pcie-phy.8: Looking up phy-s= upply from device tree
[ =C2=A0 10.250775] phy phy-ff770000.syscon:pcie-= phy.8: Looking up phy-supply property in node /syscon@ff770000/pcie-phy fai= led
[ =C2=A0 10.254471] phy phy-ff7c0000.phy.9: Looking up phy-supply fr= om device tree
[ =C2=A0 10.254748] phy phy-ff7c0000.phy.9: Looking up ph= y-supply property in node /phy@ff7c0000/dp-port failed
[ =C2=A0 10.25567= 0] phy phy-ff7c0000.phy.10: Looking up phy-supply from device tree
[ =C2= =A0 10.255872] phy phy-ff7c0000.phy.10: Looking up phy-supply property in n= ode /phy@ff7c0000/usb3-port failed
[ =C2=A0 10.258831] phy phy-ff800000.= phy.11: Looking up phy-supply from device tree
[ =C2=A0 10.259081] phy p= hy-ff800000.phy.11: Looking up phy-supply property in node /phy@ff800000/dp= -port failed
[ =C2=A0 10.259972] phy phy-ff800000.phy.12: Looking up phy= -supply from device tree
[ =C2=A0 10.260151] phy phy-ff800000.phy.12: Lo= oking up phy-supply property in node /phy@ff800000/usb3-port failed
[ = =C2=A0 10.282297] dma-pl330 ff6d0000.dma-controller: Loaded driver for PL33= 0 DMAC-241330
[ =C2=A0 10.282779] dma-pl330 ff6d0000.dma-controller: =C2= =A0 =C2=A0 =C2=A0 DBUFF-32x8bytes Num_Chans-6 Num_Peri-12 Num_Events-12
= [ =C2=A0 10.291532] dma-pl330 ff6e0000.dma-controller: Loaded driver for PL= 330 DMAC-241330
[ =C2=A0 10.291829] dma-pl330 ff6e0000.dma-controller: = =C2=A0 =C2=A0 =C2=A0 DBUFF-128x8bytes Num_Chans-8 Num_Peri-20 Num_Events-16=
[ =C2=A0 10.300189] xen:xen_evtchn: Event-channel device installed
[= =C2=A0 10.318364] Serial: 8250/16550 driver, 5 ports, IRQ sharing disabled=
[ =C2=A0 10.335497] rockchip-vop ff8f0000.vop: Adding to iommu group 2<= br>[ =C2=A0 10.340200] rockchip-vop ff900000.vop: Adding to iommu group 3[ =C2=A0 10.367059] rockchip-drm display-subsystem: bound ff8f0000.vop (o= ps 0xffffffc010e887e8)
[ =C2=A0 10.367999] [drm] unsupported AFBC format= [3231564e]
[ =C2=A0 10.371622] rockchip-drm display-subsystem: bound ff9= 00000.vop (ops 0xffffffc010e887e8)
[ =C2=A0 10.394857] cacheinfo: Unable= to detect cache hierarchy for CPU 0
[ =C2=A0 10.400560] brd: module loa= ded
[ =C2=A0 10.444804] loop: module loaded
[ =C2=A0 10.448040] lkdtm= : No crash points registered, enable through debugfs
[ =C2=A0 10.481318]= libphy: Fixed MDIO Bus: probed
[ =C2=A0 10.482042] CAN device driver in= terface
[ =C2=A0 10.484479] usbcore: registered new interface driver cdc= _ether
[ =C2=A0 10.484987] usbcore: registered new interface driver rndi= s_host
[ =C2=A0 10.528254] ehci_hcd: USB 2.0 'Enhanced' Host Con= troller (EHCI) Driver
[ =C2=A0 10.528704] ehci-pci: EHCI PCI platform dr= iver
[ =C2=A0 10.529176] ehci-platform: EHCI generic platform driver
= [ =C2=A0 10.533146] ehci-platform fe380000.usb: EHCI Host Controller
[ = =C2=A0 10.534559] ehci-platform fe380000.usb: new USB bus registered, assig= ned bus number 1
[ =C2=A0 10.535808] ehci-platform fe380000.usb: irq 19,= io mem 0xfe380000
[ =C2=A0 10.549833] ehci-platform fe380000.usb: USB 2= .0 started, EHCI 1.00
[ =C2=A0 10.551250] usb usb1: New USB device found= , idVendor=3D1d6b, idProduct=3D0002, bcdDevice=3D 5.15
[ =C2=A0 10.55144= 1] usb usb1: New USB device strings: Mfr=3D3, Product=3D2, SerialNumber=3D1=
[ =C2=A0 10.551591] usb usb1: Product: EHCI Host Controller
[ =C2=A0= 10.551705] usb usb1: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 = ehci_hcd
[ =C2=A0 10.551860] usb usb1: SerialNumber: fe380000.usb
[ = =C2=A0 10.555156] hub 1-0:1.0: USB hub found
[ =C2=A0 10.555443] hub 1-0= :1.0: 1 port detected
[ =C2=A0 10.561186] ehci-platform fe3c0000.usb: EH= CI Host Controller
[ =C2=A0 10.562763] ehci-platform fe3c0000.usb: new U= SB bus registered, assigned bus number 2
[ =C2=A0 10.563759] ehci-platfo= rm fe3c0000.usb: irq 21, io mem 0xfe3c0000
[ =C2=A0 10.577817] ehci-plat= form fe3c0000.usb: USB 2.0 started, EHCI 1.00
[ =C2=A0 10.579010] usb us= b2: New USB device found, idVendor=3D1d6b, idProduct=3D0002, bcdDevice=3D 5= .15
[ =C2=A0 10.579200] usb usb2: New USB device strings: Mfr=3D3, Produ= ct=3D2, SerialNumber=3D1
[ =C2=A0 10.579353] usb usb2: Product: EHCI Hos= t Controller
[ =C2=A0 10.579467] usb usb2: Manufacturer: Linux 5.15.16-1= -rockchip-g359ffc4bc727 ehci_hcd
[ =C2=A0 10.579619] usb usb2: SerialNum= ber: fe3c0000.usb
[ =C2=A0 10.582596] hub 2-0:1.0: USB hub found
[ = =C2=A0 10.582872] hub 2-0:1.0: 1 port detected
[ =C2=A0 10.586210] ohci_= hcd: USB 1.1 'Open' Host Controller (OHCI) Driver
[ =C2=A0 10.58= 6524] ohci-platform: OHCI generic platform driver
[ =C2=A0 10.587848] oh= ci-platform fe3a0000.usb: Generic Platform OHCI controller
[ =C2=A0 10.5= 89672] ohci-platform fe3a0000.usb: new USB bus registered, assigned bus num= ber 3
[ =C2=A0 10.590708] ohci-platform fe3a0000.usb: irq 20, io mem 0xf= e3a0000
[ =C2=A0 10.654476] usb usb3: New USB device found, idVendor=3D1= d6b, idProduct=3D0001, bcdDevice=3D 5.15
[ =C2=A0 10.654689] usb usb3: N= ew USB device strings: Mfr=3D3, Product=3D2, SerialNumber=3D1
[ =C2=A0 1= 0.654841] usb usb3: Product: Generic Platform OHCI controller
[ =C2=A0 1= 0.654973] usb usb3: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 oh= ci_hcd
[ =C2=A0 10.655120] usb usb3: SerialNumber: fe3a0000.usb
[ =C2= =A0 10.658033] hub 3-0:1.0: USB hub found
[ =C2=A0 10.658329] hub 3-0:1.= 0: 1 port detected
[ =C2=A0 10.661656] ohci-platform fe3e0000.usb: Gener= ic Platform OHCI controller
[ =C2=A0 10.663217] ohci-platform fe3e0000.u= sb: new USB bus registered, assigned bus number 4
[ =C2=A0 10.664185] oh= ci-platform fe3e0000.usb: irq 22, io mem 0xfe3e0000
[ =C2=A0 10.726670] = usb usb4: New USB device found, idVendor=3D1d6b, idProduct=3D0001, bcdDevic= e=3D 5.15
[ =C2=A0 10.726886] usb usb4: New USB device strings: Mfr=3D3,= Product=3D2, SerialNumber=3D1
[ =C2=A0 10.727049] usb usb4: Product: Ge= neric Platform OHCI controller
[ =C2=A0 10.727181] usb usb4: Manufacture= r: Linux 5.15.16-1-rockchip-g359ffc4bc727 ohci_hcd
[ =C2=A0 10.727329] u= sb usb4: SerialNumber: fe3e0000.usb
[ =C2=A0 10.730270] hub 4-0:1.0: USB= hub found
[ =C2=A0 10.730545] hub 4-0:1.0: 1 port detected
[ =C2=A0 = 10.737209] xhci-hcd xhci-hcd.0.auto: xHCI Host Controller
[ =C2=A0 10.73= 9611] xhci-hcd xhci-hcd.0.auto: new USB bus registered, assigned bus number= 5
[ =C2=A0 10.740395] xhci-hcd xhci-hcd.0.auto: hcc params 0x0220fe64 h= ci version 0x110 quirks 0x0000000002010010
[ =C2=A0 10.740805] xhci-hcd = xhci-hcd.0.auto: irq 53, io mem 0xfe800000
[ =C2=A0 10.742883] usb usb5:= New USB device found, idVendor=3D1d6b, idProduct=3D0002, bcdDevice=3D 5.15=
[ =C2=A0 10.743094] usb usb5: New USB device strings: Mfr=3D3, Product= =3D2, SerialNumber=3D1
[ =C2=A0 10.743246] usb usb5: Product: xHCI Host = Controller
[ =C2=A0 10.743359] usb usb5: Manufacturer: Linux 5.15.16-1-r= ockchip-g359ffc4bc727 xhci-hcd
[ =C2=A0 10.743512] usb usb5: SerialNumbe= r: xhci-hcd.0.auto
[ =C2=A0 10.746576] hub 5-0:1.0: USB hub found
[ = =C2=A0 10.746865] hub 5-0:1.0: 1 port detected
[ =C2=A0 10.749054] xhci-= hcd xhci-hcd.0.auto: xHCI Host Controller
[ =C2=A0 10.750454] xhci-hcd x= hci-hcd.0.auto: new USB bus registered, assigned bus number 6
[ =C2=A0 1= 0.750677] xhci-hcd xhci-hcd.0.auto: Host supports USB 3.0 SuperSpeed
[ = =C2=A0 10.751167] usb usb6: We don't know the algorithms for LPM for th= is host, disabling LPM.
[ =C2=A0 10.752007] usb usb6: New USB device fou= nd, idVendor=3D1d6b, idProduct=3D0003, bcdDevice=3D 5.15
[ =C2=A0 10.752= 187] usb usb6: New USB device strings: Mfr=3D3, Product=3D2, SerialNumber= =3D1
[ =C2=A0 10.752337] usb usb6: Product: xHCI Host Controller
[ = =C2=A0 10.752451] usb usb6: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4= bc727 xhci-hcd
[ =C2=A0 10.752592] usb usb6: SerialNumber: xhci-hcd.0.au= to
[ =C2=A0 10.755365] hub 6-0:1.0: USB hub found
[ =C2=A0 10.755669]= hub 6-0:1.0: 1 port detected
[ =C2=A0 10.758922] xhci-hcd xhci-hcd.1.au= to: xHCI Host Controller
[ =C2=A0 10.760343] xhci-hcd xhci-hcd.1.auto: n= ew USB bus registered, assigned bus number 7
[ =C2=A0 10.761128] xhci-hc= d xhci-hcd.1.auto: hcc params 0x0220fe64 hci version 0x110 quirks 0x0000000= 002010010
[ =C2=A0 10.762039] xhci-hcd xhci-hcd.1.auto: irq 54, io mem 0= xfe900000
[ =C2=A0 10.763994] usb usb7: New USB device found, idVendor= =3D1d6b, idProduct=3D0002, bcdDevice=3D 5.15
[ =C2=A0 10.764191] usb usb= 7: New USB device strings: Mfr=3D3, Product=3D2, SerialNumber=3D1
[ =C2= =A0 10.764342] usb usb7: Product: xHCI Host Controller
[ =C2=A0 10.76445= 5] usb usb7: Manufacturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd<= br>[ =C2=A0 10.764601] usb usb7: SerialNumber: xhci-hcd.1.auto
[ =C2=A0 = 10.767411] hub 7-0:1.0: USB hub found
[ =C2=A0 10.767696] hub 7-0:1.0: 1= port detected
[ =C2=A0 10.769982] xhci-hcd xhci-hcd.1.auto: xHCI Host C= ontroller
[ =C2=A0 10.771168] xhci-hcd xhci-hcd.1.auto: new USB bus regi= stered, assigned bus number 8
[ =C2=A0 10.771384] xhci-hcd xhci-hcd.1.au= to: Host supports USB 3.0 SuperSpeed
[ =C2=A0 10.771912] usb usb8: We do= n't know the algorithms for LPM for this host, disabling LPM.
[ =C2= =A0 10.772717] usb usb8: New USB device found, idVendor=3D1d6b, idProduct= =3D0003, bcdDevice=3D 5.15
[ =C2=A0 10.772896] usb usb8: New USB device = strings: Mfr=3D3, Product=3D2, SerialNumber=3D1
[ =C2=A0 10.773046] usb = usb8: Product: xHCI Host Controller
[ =C2=A0 10.773160] usb usb8: Manufa= cturer: Linux 5.15.16-1-rockchip-g359ffc4bc727 xhci-hcd
[ =C2=A0 10.7733= 02] usb usb8: SerialNumber: xhci-hcd.1.auto
[ =C2=A0 10.776389] hub 8-0:= 1.0: USB hub found
[ =C2=A0 10.776678] hub 8-0:1.0: 1 port detected
[= =C2=A0 10.784427] usbcore: registered new interface driver uas
[ =C2=A0= 10.785747] usbcore: registered new interface driver usb-storage
[ =C2= =A0 10.786109] usbcore: registered new interface driver ums-alauda
[ =C2= =A0 10.786423] usbcore: registered new interface driver ums-cypress
[ = =C2=A0 10.786758] usbcore: registered new interface driver ums-datafab
[= =C2=A0 10.787095] usbcore: registered new interface driver ums_eneub6250[ =C2=A0 10.787409] usbcore: registered new interface driver ums-freecom<= br>[ =C2=A0 10.787719] usbcore: registered new interface driver ums-isd200<= br>[ =C2=A0 10.788017] usbcore: registered new interface driver ums-jumpsho= t
[ =C2=A0 10.788326] usbcore: registered new interface driver ums-karma=
[ =C2=A0 10.788625] usbcore: registered new interface driver ums-onetou= ch
[ =C2=A0 10.789023] usbcore: registered new interface driver ums-real= tek
[ =C2=A0 10.789333] usbcore: registered new interface driver ums-sdd= r09
[ =C2=A0 10.789756] usbcore: registered new interface driver ums-sdd= r55
[ =C2=A0 10.790070] usbcore: registered new interface driver ums-usb= at
[ =C2=A0 10.792802] usbcore: registered new interface driver iforce[ =C2=A0 10.793352] usbcore: registered new interface driver xpad
[ = =C2=A0 10.794485] usbcore: registered new interface driver usbtouchscreen[ =C2=A0 10.797315] i2c_dev: i2c /dev entries driver
[ =C2=A0 10.81649= 0] fan53555-regulator 0-0040: FAN53555 Option[8] Rev[1] Detected!
[ =C2= =A0 10.818456] vdd_cpu_b: will resolve supply early: vin
[ =C2=A0 10.818= 614] fan53555-regulator 0-0040: Looking up vin-supply from device tree
[= =C2=A0 10.818799] vdd_cpu_b: supplied by vcc5v0_sys
[ =C2=A0 10.818944]= vcc5v0_sys: could not add device link regulator.9: -ENOENT
[ =C2=A0 10.= 822253] vdd_cpu_b: 712 <--> 1500 mV at 1000 mV, enabled
[ =C2=A0 1= 0.827044] fan53555-regulator 0-0041: FAN53555 Option[8] Rev[1] Detected![ =C2=A0 10.828780] vdd_gpu: will resolve supply early: vin
[ =C2=A0 10= .828939] fan53555-regulator 0-0041: Looking up vin-supply from device tree<= br>[ =C2=A0 10.829117] vdd_gpu: supplied by vcc5v0_sys
[ =C2=A0 10.82923= 0] vcc5v0_sys: could not add device link regulator.10: -ENOENT
[ =C2=A0 = 10.832556] vdd_gpu: 712 <--> 1500 mV at 1000 mV, enabled
[ =C2=A0 = 10.841882] rk808 0-001b: chip id: 0x0
[ =C2=A0 10.862081] rk808-regulato= r rk808-regulator: there is no dvs0 gpio
[ =C2=A0 10.862548] rk808-regul= ator rk808-regulator: there is no dvs1 gpio
[ =C2=A0 10.864173] vdd_cent= er: will resolve supply early: vcc1
[ =C2=A0 10.864337] rk808 0-001b: Lo= oking up vcc1-supply from device tree
[ =C2=A0 10.864503] vdd_center: su= pplied by vcc5v0_sys
[ =C2=A0 10.864631] vcc5v0_sys: could not add devic= e link regulator.11: -ENOENT
[ =C2=A0 10.866313] vdd_center: 750 <--&= gt; 1350 mV at 900 mV, enabled
[ =C2=A0 10.868084] vdd_cpu_l: will resol= ve supply early: vcc2
[ =C2=A0 10.868241] rk808 0-001b: Looking up vcc2-= supply from device tree
[ =C2=A0 10.868402] vdd_cpu_l: supplied by vcc5v= 0_sys
[ =C2=A0 10.868524] vcc5v0_sys: could not add device link regulato= r.12: -ENOENT
[ =C2=A0 10.868888] vdd_cpu_l: 750 <--> 1350 mV at 9= 00 mV, enabled
[ =C2=A0 10.870335] vcc_ddr: will resolve supply early: v= cc3
[ =C2=A0 10.870485] rk808 0-001b: Looking up vcc3-supply from device= tree
[ =C2=A0 10.870646] vcc_ddr: supplied by vcc5v0_sys
[ =C2=A0 10= .870761] vcc5v0_sys: could not add device link regulator.13: -ENOENT
[ = =C2=A0 10.871149] vcc_ddr: at 5000 mV, enabled
[ =C2=A0 10.873225] vcc_1= v8: will resolve supply early: vcc4
[ =C2=A0 10.873379] rk808 0-001b: Lo= oking up vcc4-supply from device tree
[ =C2=A0 10.873816] vcc_1v8: suppl= ied by vcc5v0_sys
[ =C2=A0 10.873940] vcc5v0_sys: could not add device l= ink regulator.14: -ENOENT
[ =C2=A0 10.874308] vcc_1v8: 1800 mV, enabled<= br>[ =C2=A0 10.876864] vcc1v8_dvp: will resolve supply early: vcc6
[ =C2= =A0 10.877025] rk808 0-001b: Looking up vcc6-supply from device tree
[ = =C2=A0 10.877180] vcc1v8_dvp: supplied by vcc5v0_sys
[ =C2=A0 10.877300]= vcc5v0_sys: could not add device link regulator.15: -ENOENT
[ =C2=A0 10= .878934] vcc1v8_dvp: 1800 mV, enabled
[ =C2=A0 10.881114] vcca1v8_hdmi: = will resolve supply early: vcc6
[ =C2=A0 10.881268] rk808 0-001b: Lookin= g up vcc6-supply from device tree
[ =C2=A0 10.881721] vcca1v8_hdmi: supp= lied by vcc5v0_sys
[ =C2=A0 10.881858] vcc5v0_sys: could not add device = link regulator.16: -ENOENT
[ =C2=A0 10.882897] vcca1v8_hdmi: 1800 mV, en= abled
[ =C2=A0 10.885121] vcca_1v8: will resolve supply early: vcc7
[= =C2=A0 10.885284] rk808 0-001b: Looking up vcc7-supply from device tree[ =C2=A0 10.885610] vcca_1v8: supplied by vcc5v0_sys
[ =C2=A0 10.885752= ] vcc5v0_sys: could not add device link regulator.17: -ENOENT
[ =C2=A0 1= 0.886785] vcca_1v8: 1800 mV, enabled
[ =C2=A0 10.888911] vcc_sd: will re= solve supply early: vcc9
[ =C2=A0 10.889073] rk808 0-001b: Looking up vc= c9-supply from device tree
[ =C2=A0 10.889227] vcc_sd: supplied by vcc5v= 0_sys
[ =C2=A0 10.889337] vcc5v0_sys: could not add device link regulato= r.18: -ENOENT
[ =C2=A0 10.890587] vcc_sd: 1800 <--> 3300 mV at 300= 0 mV, enabled
[ =C2=A0 10.892799] vcc3v0_sd: will resolve supply early: = vcc9
[ =C2=A0 10.892957] rk808 0-001b: Looking up vcc9-supply from devic= e tree
[ =C2=A0 10.893116] vcc3v0_sd: supplied by vcc5v0_sys
[ =C2=A0= 10.893261] vcc5v0_sys: could not add device link regulator.19: -ENOENT
= [ =C2=A0 10.894528] vcc3v0_sd: 3000 mV, enabled
[ =C2=A0 10.896651] vcc_= 1v5: will resolve supply early: vcc10
[ =C2=A0 10.896806] rk808 0-001b: = Looking up vcc10-supply from device tree
[ =C2=A0 10.896961] vcc_1v5: su= pplied by vcc5v0_sys
[ =C2=A0 10.897073] vcc5v0_sys: could not add devic= e link regulator.20: -ENOENT
[ =C2=A0 10.898331] vcc_1v5: 1500 mV, enabl= ed
[ =C2=A0 10.900480] vcca0v9_hdmi: will resolve supply early: vcc7
= [ =C2=A0 10.900633] rk808 0-001b: Looking up vcc7-supply from device tree[ =C2=A0 10.900789] vcca0v9_hdmi: supplied by vcc5v0_sys
[ =C2=A0 10.9= 00910] vcc5v0_sys: could not add device link regulator.21: -ENOENT
[ =C2= =A0 10.901947] vcca0v9_hdmi: 900 mV, enabled
[ =C2=A0 10.904130] vcc_3v0= : will resolve supply early: vcc11
[ =C2=A0 10.904283] rk808 0-001b: Loo= king up vcc11-supply from device tree
[ =C2=A0 10.904440] vcc_3v0: suppl= ied by vcc5v0_sys
[ =C2=A0 10.904551] vcc5v0_sys: could not add device l= ink regulator.22: -ENOENT
[ =C2=A0 10.905603] vcc_3v0: 3000 mV, enabled<= br>[ =C2=A0 10.906825] vcc3v3_s3: will resolve supply early: vcc8
[ =C2= =A0 10.907071] rk808 0-001b: Looking up vcc8-supply from device tree
[ = =C2=A0 10.907238] vcc3v3_s3: supplied by vcc3v3_sys
[ =C2=A0 10.907358] = vcc3v3_sys: could not add device link regulator.23: -ENOENT
[ =C2=A0 10.= 907702] vcc3v3_s3: at 3300 mV, enabled
[ =C2=A0 10.908814] vcc3v3_s0: wi= ll resolve supply early: vcc12
[ =C2=A0 10.908951] rk808 0-001b: Looking= up vcc12-supply from device tree
[ =C2=A0 10.909117] vcc3v3_s0: supplie= d by vcc3v3_sys
[ =C2=A0 10.909238] vcc3v3_sys: could not add device lin= k regulator.24: -ENOENT
[ =C2=A0 10.909966] vcc3v3_s0: at 3300 mV, enabl= ed
[ =C2=A0 10.923748] rk808-rtc rk808-rtc: registered as rtc0
[ =C2= =A0 10.925890] rk808-rtc rk808-rtc: setting system clock to 2013-01-18T08:5= 4:34 UTC (1358499274)
[ =C2=A0 10.937312] rockchip-rga ff680000.rga: HW = Version: 0x03.02
[ =C2=A0 10.938723] rockchip-rga: probe of ff680000.rga= failed with error -12
[ =C2=A0 10.940550] usbcore: registered new inter= face driver uvcvideo
[ =C2=A0 10.947281] rockchip-thermal ff260000.tsadc= : failed to register sensor 0: -517
[ =C2=A0 10.947553] rockchip-thermal= ff260000.tsadc: failed to register sensor[0] : error =3D -517
[ =C2=A0 = 10.951347] dw_wdt ff848000.watchdog: No valid TOPs array specified
[ =C2= =A0 10.957666] device-mapper: ioctl: 4.45.0-ioctl (2021-03-22) initialised:= dm-devel@redhat.com
[ =C2=A0= 10.958918] Bluetooth: HCI UART driver ver 2.3
[ =C2=A0 10.959059] Bluet= ooth: HCI UART protocol H4 registered
[ =C2=A0 10.959172] Bluetooth: HCI= UART protocol ATH3K registered
[ =C2=A0 10.959600] usbcore: registered = new interface driver bfusb
[ =C2=A0 10.960069] usbcore: registered new i= nterface driver btusb
[ =C2=A0 10.960865] cpu cpu0: OPP table can't = be empty
[ =C2=A0 10.963410] sdhci: Secure Digital Host Controller Inter= face driver
[ =C2=A0 10.963573] sdhci: Copyright(c) Pierre Ossman
[ = =C2=A0 10.963674] Synopsys Designware Multimedia Card Interface Driver
[= =C2=A0 10.966723] sdhci-pltfm: SDHCI platform and OF driver helper
[ = =C2=A0 10.969834] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit addres= s mode.
[ =C2=A0 10.970158] dwmmc_rockchip fe310000.mmc: Using internal = DMA controller.
[ =C2=A0 10.970317] dwmmc_rockchip fe310000.mmc: Version= ID is 270a
[ =C2=A0 10.971055] dwmmc_rockchip fe310000.mmc: DW MMC cont= roller at irq 17,32 bit host data width,256 deep fifo
[ =C2=A0 10.972116= ] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree
[= =C2=A0 10.972318] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply prop= erty in node /mmc@fe310000 failed
[ =C2=A0 10.972647] dwmmc_rockchip fe3= 10000.mmc: Looking up vqmmc-supply from device tree
[ =C2=A0 10.972823] = dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /mmc@= fe310000 failed
[ =C2=A0 10.989783] ledtrig-cpu: registered to indicate = activity on CPUs
[ =C2=A0 10.990632] hid: raw HID events driver (C) Jiri= Kosina
[ =C2=A0 11.018314] usbcore: registered new interface driver usb= hid
[ =C2=A0 11.018612] usbhid: USB HID core driver
[ =C2=A0 11.02083= 5] rkvdec ff660000.video-codec: Adding to iommu group 1
[ =C2=A0 11.0681= 58] hantro-vpu ff650000.video-codec: Adding to iommu group 0
[ =C2=A0 11= .072492] irq: type mismatch, failed to map hwirq-32 for interrupt-controlle= r!
[ =C2=A0 11.072712] hantro-vpu ff650000.video-codec: IRQ vdpu not fou= nd
[ =C2=A0 11.074844] Zoran MJPEG board driver version 0.10.1
[ =C2= =A0 11.075255] Linux video codec intermediate layer: v0.2
[ =C2=A0 11.07= 5418] saa7146: register extension 'av7110'
[ =C2=A0 11.083859] s= dhci-arasan fe330000.mmc: Looking up vmmc-supply from device tree
[ =C2= =A0 11.091432] usbcore: registered new interface driver snd-usb-audio
[ = =C2=A0 11.099500] sdhci-arasan fe330000.mmc: Looking up vmmc-supply propert= y in node /mmc@fe330000 failed
[ =C2=A0 11.112425] u32 classifier
[ = =C2=A0 11.112499] sdhci-arasan fe330000.mmc: Looking up vqmmc-supply from d= evice tree
[ =C2=A0 11.113020] =C2=A0 =C2=A0 input device check on
[ = =C2=A0 11.114266] Initializing XFRM netlink socket
[ =C2=A0 11.120358] s= dhci-arasan fe330000.mmc: Looking up vqmmc-supply property in node /mmc@fe3= 30000 failed
[ =C2=A0 11.121602] NET: Registered PF_INET6 protocol famil= y
[ =C2=A0 11.123037] usb 8-1: new SuperSpeed USB device number 2 using = xhci-hcd
[ =C2=A0 11.134670] Segment Routing with IPv6
[ =C2=A0 11.13= 5294] In-situ OAM (IOAM) with IPv6
[ =C2=A0 11.135867] NET: Registered P= F_PACKET protocol family
[ =C2=A0 11.136112] NET: Registered PF_KEY prot= ocol family
[ =C2=A0 11.136230] mmc2: CQHCI version 5.10
[ =C2=A0 11.= 136568] Bridge firewalling registered
[ =C2=A0 11.136633] can: controlle= r area network core
[ =C2=A0 11.138034] NET: Registered PF_CAN protocol = family
[ =C2=A0 11.141093] Bluetooth: RFCOMM socket layer initialized[ =C2=A0 11.141809] Bluetooth: RFCOMM ver 1.11
[ =C2=A0 11.142039] Blue= tooth: HIDP (Human Interface Emulation) ver 1.2
[ =C2=A0 11.142209] Blue= tooth: HIDP socket layer initialized
[ =C2=A0 11.142338] 8021q: 802.1Q V= LAN Support v1.8
[ =C2=A0 11.142653] Key type dns_resolver registered[ =C2=A0 11.149920] registered taskstats version 1
[ =C2=A0 11.150671] = Loading compiled-in X.509 certificates
[ =C2=A0 11.151208] random: fast = init done
[ =C2=A0 11.155983] usb 8-1: New USB device found, idVendor=3D= 152d, idProduct=3D0561, bcdDevice=3D 0.01
[ =C2=A0 11.156263] usb 8-1: N= ew USB device strings: Mfr=3D1, Product=3D2, SerialNumber=3D5
[ =C2=A0 1= 1.156439] usb 8-1: Product: JMS56x Series
[ =C2=A0 11.156545] usb 8-1: M= anufacturer: JMicron
[ =C2=A0 11.156646] usb 8-1: SerialNumber: RANDOM__= A0840143833E
[ =C2=A0 11.168652] usb-storage 8-1:1.0: USB Mass Storage d= evice detected
[ =C2=A0 11.178360] scsi host0: usb-storage 8-1:1.0
[ = =C2=A0 11.196406] Btrfs loaded, crc32c=3Dcrc32c-generic, integrity-checker= =3Don, zoned=3Dno, fsverity=3Dno
[ =C2=A0 11.197865] BTRFS: selftest: se= ctorsize: 4096 =C2=A0nodesize: 4096
[ =C2=A0 11.198037] BTRFS: selftest:= running btrfs free space cache tests
[ =C2=A0 11.198203] BTRFS: selftes= t: running extent only tests
[ =C2=A0 11.198401] BTRFS: selftest: runnin= g bitmap only tests
[ =C2=A0 11.198583] BTRFS: selftest: running bitmap = and extent tests
[ =C2=A0 11.198850] BTRFS: selftest: running space stea= ling from bitmap to extent tests
[ =C2=A0 11.202503] mmc2: SDHCI control= ler on fe330000.mmc [fe330000.mmc] using ADMA
[ =C2=A0 11.206911] BTRFS:= selftest: running extent buffer operation tests
[ =C2=A0 11.207131] BTR= FS: selftest: running btrfs_split_item tests
[ =C2=A0 11.207469] BTRFS: = selftest: running extent I/O tests
[ =C2=A0 11.207579] BTRFS: selftest: = running find delalloc tests
[ =C2=A0 13.247196] BTRFS: selftest: running= find_first_clear_extent_bit test
[ =C2=A0 13.247996] BTRFS: selftest: r= unning extent buffer bitmap tests
[ =C2=A0 13.436326] BTRFS: selftest: r= unning inode tests
[ =C2=A0 13.436468] BTRFS: selftest: running btrfs_ge= t_extent tests
[ =C2=A0 13.437811] BTRFS: selftest: running hole first b= trfs_get_extent test
[ =C2=A0 13.438152] BTRFS: selftest: running outsta= nding_extents tests
[ =C2=A0 13.438630] BTRFS: selftest: running qgroup = tests
[ =C2=A0 13.438747] BTRFS: selftest: running qgroup add/remove tes= ts
[ =C2=A0 13.439210] BTRFS: selftest: running qgroup multiple refs tes= t
[ =C2=A0 13.440099] BTRFS: selftest: running free space tree tests
= [ =C2=A0 13.880122] BTRFS: selftest: sectorsize: 4096 =C2=A0nodesize: 8192<= br>[ =C2=A0 13.880446] BTRFS: selftest: running btrfs free space cache test= s
[ =C2=A0 13.880648] BTRFS: selftest: running extent only tests
[ = =C2=A0 13.880883] BTRFS: selftest: running bitmap only tests
[ =C2=A0 13= .881123] BTRFS: selftest: running bitmap and extent tests
[ =C2=A0 13.88= 1545] BTRFS: selftest: running space stealing from bitmap to extent tests[ =C2=A0 13.889765] BTRFS: selftest: running extent buffer operation test= s
[ =C2=A0 13.889923] BTRFS: selftest: running btrfs_split_item tests[ =C2=A0 13.890241] BTRFS: selftest: running extent I/O tests
[ =C2=A0 = 13.890369] BTRFS: selftest: running find delalloc tests
[ =C2=A0 15.9312= 91] BTRFS: selftest: running find_first_clear_extent_bit test
[ =C2=A0 1= 5.932162] BTRFS: selftest: running extent buffer bitmap tests
[ =C2=A0 1= 6.532870] BTRFS: selftest: running inode tests
[ =C2=A0 16.533138] BTRFS= : selftest: running btrfs_get_extent tests
[ =C2=A0 16.534815] BTRFS: se= lftest: running hole first btrfs_get_extent test
[ =C2=A0 16.535219] BTR= FS: selftest: running outstanding_extents tests
[ =C2=A0 16.535736] BTRF= S: selftest: running qgroup tests
[ =C2=A0 16.535846] BTRFS: selftest: r= unning qgroup add/remove tests
[ =C2=A0 16.536300] BTRFS: selftest: runn= ing qgroup multiple refs test
[ =C2=A0 16.537056] BTRFS: selftest: runni= ng free space tree tests
[ =C2=A0 16.977337] BTRFS: selftest: sectorsize= : 4096 =C2=A0nodesize: 16384
[ =C2=A0 16.977814] BTRFS: selftest: runnin= g btrfs free space cache tests
[ =C2=A0 16.978018] BTRFS: selftest: runn= ing extent only tests
[ =C2=A0 16.978279] BTRFS: selftest: running bitma= p only tests
[ =C2=A0 16.978513] BTRFS: selftest: running bitmap and ext= ent tests
[ =C2=A0 16.978842] BTRFS: selftest: running space stealing fr= om bitmap to extent tests
[ =C2=A0 16.987056] BTRFS: selftest: running e= xtent buffer operation tests
[ =C2=A0 16.987214] BTRFS: selftest: runnin= g btrfs_split_item tests
[ =C2=A0 16.987541] BTRFS: selftest: running ex= tent I/O tests
[ =C2=A0 16.987667] BTRFS: selftest: running find delallo= c tests
[ =C2=A0 19.025223] BTRFS: selftest: running find_first_clear_ex= tent_bit test
[ =C2=A0 19.026172] BTRFS: selftest: running extent buffer= bitmap tests
[ =C2=A0 20.225626] BTRFS: selftest: running inode tests[ =C2=A0 20.225841] BTRFS: selftest: running btrfs_get_extent tests
[ = =C2=A0 20.227444] BTRFS: selftest: running hole first btrfs_get_extent test=
[ =C2=A0 20.227818] BTRFS: selftest: running outstanding_extents tests<= br>[ =C2=A0 20.228276] BTRFS: selftest: running qgroup tests
[ =C2=A0 20= .228399] BTRFS: selftest: running qgroup add/remove tests
[ =C2=A0 20.22= 8834] BTRFS: selftest: running qgroup multiple refs test
[ =C2=A0 20.229= 952] BTRFS: selftest: running free space tree tests
[ =C2=A0 20.669501] = BTRFS: selftest: sectorsize: 4096 =C2=A0nodesize: 32768
[ =C2=A0 20.6697= 47] BTRFS: selftest: running btrfs free space cache tests
[ =C2=A0 20.66= 9903] BTRFS: selftest: running extent only tests
[ =C2=A0 20.670123] BTR= FS: selftest: running bitmap only tests
[ =C2=A0 20.670366] BTRFS: selft= est: running bitmap and extent tests
[ =C2=A0 20.670625] BTRFS: selftest= : running space stealing from bitmap to extent tests
[ =C2=A0 20.678498]= BTRFS: selftest: running extent buffer operation tests
[ =C2=A0 20.6786= 44] BTRFS: selftest: running btrfs_split_item tests
[ =C2=A0 20.678971] = BTRFS: selftest: running extent I/O tests
[ =C2=A0 20.679083] BTRFS: sel= ftest: running find delalloc tests
[ =C2=A0 22.716824] BTRFS: selftest: = running find_first_clear_extent_bit test
[ =C2=A0 22.717705] BTRFS: self= test: running extent buffer bitmap tests
[ =C2=A0 25.119619] BTRFS: self= test: running inode tests
[ =C2=A0 25.119942] BTRFS: selftest: running b= trfs_get_extent tests
[ =C2=A0 25.121224] BTRFS: selftest: running hole = first btrfs_get_extent test
[ =C2=A0 25.121825] BTRFS: selftest: running= outstanding_extents tests
[ =C2=A0 25.122316] BTRFS: selftest: running = qgroup tests
[ =C2=A0 25.122425] BTRFS: selftest: running qgroup add/rem= ove tests
[ =C2=A0 25.122860] BTRFS: selftest: running qgroup multiple r= efs test
[ =C2=A0 25.123715] BTRFS: selftest: running free space tree te= sts
[ =C2=A0 25.564237] BTRFS: selftest: sectorsize: 4096 =C2=A0nodesize= : 65536
[ =C2=A0 25.564448] BTRFS: selftest: running btrfs free space ca= che tests
[ =C2=A0 25.564600] BTRFS: selftest: running extent only tests=
[ =C2=A0 25.564762] BTRFS: selftest: running bitmap only tests
[ =C2= =A0 25.564946] BTRFS: selftest: running bitmap and extent tests
[ =C2=A0= 25.565204] BTRFS: selftest: running space stealing from bitmap to extent t= ests
[ =C2=A0 25.573041] BTRFS: selftest: running extent buffer operatio= n tests
[ =C2=A0 25.573167] BTRFS: selftest: running btrfs_split_item te= sts
[ =C2=A0 25.573626] BTRFS: selftest: running extent I/O tests
[ = =C2=A0 25.573739] BTRFS: selftest: running find delalloc tests
[ =C2=A0 = 27.608826] BTRFS: selftest: running find_first_clear_extent_bit test
[ = =C2=A0 27.609668] BTRFS: selftest: running extent buffer bitmap tests
[ = =C2=A0 32.430665] BTRFS: selftest: running inode tests
[ =C2=A0 32.43120= 2] BTRFS: selftest: running btrfs_get_extent tests
[ =C2=A0 32.432886] B= TRFS: selftest: running hole first btrfs_get_extent test
[ =C2=A0 32.433= 377] BTRFS: selftest: running outstanding_extents tests
[ =C2=A0 32.4342= 57] BTRFS: selftest: running qgroup tests
[ =C2=A0 32.434373] BTRFS: sel= ftest: running qgroup add/remove tests
[ =C2=A0 32.434818] BTRFS: selfte= st: running qgroup multiple refs test
[ =C2=A0 32.435655] BTRFS: selftes= t: running free space tree tests
[ =C2=A0 32.877773] BTRFS: selftest: ru= nning extent_map tests
[ =C2=A0 32.878137] BTRFS: selftest: running rmap= tests
[ =C2=A0 33.072074] rockchip-pcie f8000000.pcie: host bridge /pci= e@f8000000 ranges:
[ =C2=A0 33.073026] rockchip-pcie f8000000.pcie: =C2= =A0 =C2=A0 =C2=A0MEM 0x00fa000000..0x00fbdfffff -> 0x00fa000000
[ =C2= =A0 33.073259] rockchip-pcie f8000000.pcie: =C2=A0 =C2=A0 =C2=A0 IO 0x00fbe= 00000..0x00fbefffff -> 0x00fbe00000
[ =C2=A0 33.077844] rockchip-pcie= f8000000.pcie: Looking up vpcie12v-supply from device tree
[ =C2=A0 33.= 078083] rockchip-pcie f8000000.pcie: Looking up vpcie12v-supply property in= node /pcie@f8000000 failed
[ =C2=A0 33.078823] rockchip-pcie f8000000.p= cie: no vpcie12v regulator found
[ =C2=A0 33.079068] rockchip-pcie f8000= 000.pcie: Looking up vpcie3v3-supply from device tree
[ =C2=A0 33.080295= ] rockchip-pcie f8000000.pcie: Looking up vpcie1v8-supply from device tree<= br>[ =C2=A0 33.081188] rockchip-pcie f8000000.pcie: Looking up vpcie0v9-sup= ply from device tree
[ =C2=A0 33.122020] genirq: Setting trigger mode 2 = for irq 15 failed (gic_set_type+0x0/0x138)
[ =C2=A0 33.122820] irq: no i= rq domain found for interrupt-controller !
[ =C2=A0 33.122995] rockchip-= pcie f8000000.pcie: IRQ client not found
[ =C2=A0 33.132257] rockchip-io= domain ff320000.syscon:io-domains: Looking up pmu1830-supply from device tr= ee
[ =C2=A0 33.135488] rockchip-iodomain ff770000.syscon:io-domains: Loo= king up bt656-supply from device tree
[ =C2=A0 33.136399] rockchip-iodom= ain ff770000.syscon:io-domains: Looking up audio-supply from device tree[ =C2=A0 33.136825] rockchip-iodomain ff770000.syscon:io-domains: Looking = up sdmmc-supply from device tree
[ =C2=A0 33.138130] rockchip-iodomain f= f770000.syscon:io-domains: Looking up gpio1830-supply from device tree
[= =C2=A0 33.154798] rockchip-drm display-subsystem: bound ff8f0000.vop (ops = 0xffffffc010e887e8)
[ =C2=A0 33.159530] rockchip-drm display-subsystem: = bound ff900000.vop (ops 0xffffffc010e887e8)
[ =C2=A0 33.161342] dwhdmi-r= ockchip ff940000.hdmi: Detected HDMI TX controller v2.11a with HDCP (DWC HD= MI 2.0 TX PHY)
[ =C2=A0 33.171366] rockchip-drm display-subsystem: bound= ff940000.hdmi (ops 0xffffffc010e8c6c0)
[ =C2=A0 33.180852] [drm] Initia= lized rockchip 1.0.0 20140818 for display-subsystem on minor 0
[ =C2=A0 = 33.183921] mali ff9a0000.gpu: No IRQ resource at index 1
[ =C2=A0 33.184= 155] mali ff9a0000.gpu: IRQ search failed
[ =C2=A0 33.184644] mali: prob= e of ff9a0000.gpu failed with error -2
[ =C2=A0 33.190550] rockchip-ther= mal ff260000.tsadc: failed to register sensor 0: -517
[ =C2=A0 33.190882= ] rockchip-thermal ff260000.tsadc: failed to register sensor[0] : error =3D= -517
[ =C2=A0 33.200478] dwmmc_rockchip fe310000.mmc: IDMAC supports 32= -bit address mode.
[ =C2=A0 33.201294] dwmmc_rockchip fe310000.mmc: Usin= g internal DMA controller.
[ =C2=A0 33.201673] dwmmc_rockchip fe310000.m= mc: Version ID is 270a
[ =C2=A0 33.202201] dwmmc_rockchip fe310000.mmc: = DW MMC controller at irq 17,32 bit host data width,256 deep fifo
[ =C2= =A0 33.203308] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from dev= ice tree
[ =C2=A0 33.203527] dwmmc_rockchip fe310000.mmc: Looking up vmm= c-supply property in node /mmc@fe310000 failed
[ =C2=A0 33.204253] dwmmc= _rockchip fe310000.mmc: Looking up vqmmc-supply from device tree
[ =C2= =A0 33.204424] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply propert= y in node /mmc@fe310000 failed
[ =C2=A0 33.216884] rockchip-thermal ff26= 0000.tsadc: failed to register sensor 0: -517
[ =C2=A0 33.217686] rockch= ip-thermal ff260000.tsadc: failed to register sensor[0] : error =3D -517[ =C2=A0 33.226865] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit add= ress mode.
[ =C2=A0 33.227549] dwmmc_rockchip fe310000.mmc: Using intern= al DMA controller.
[ =C2=A0 33.227708] dwmmc_rockchip fe310000.mmc: Vers= ion ID is 270a
[ =C2=A0 33.228322] dwmmc_rockchip fe310000.mmc: DW MMC c= ontroller at irq 17,32 bit host data width,256 deep fifo
[ =C2=A0 33.229= 879] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree[ =C2=A0 33.230089] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply p= roperty in node /mmc@fe310000 failed
[ =C2=A0 33.230767] dwmmc_rockchip = fe310000.mmc: Looking up vqmmc-supply from device tree
[ =C2=A0 33.23096= 3] dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply property in node /m= mc@fe310000 failed
[ =C2=A0 33.268761] rockchip-thermal ff260000.tsadc: = failed to register sensor 0: -517
[ =C2=A0 33.274833] rockchip-thermal f= f260000.tsadc: failed to register sensor[0] : error =3D -517
[ =C2=A0 33= .299373] clk: Not disabling unused clocks
[ =C2=A0 33.300367] ALSA devic= e list:
[ =C2=A0 33.300487] =C2=A0 #0: hdmi-sound
[ =C2=A0 33.325969]= Freeing unused kernel memory: 5504K
[ =C2=A0 33.334276] Run /init as in= it process
[ =C2=A0 33.334455] =C2=A0 with arguments:
[ =C2=A0 33.334= 569] =C2=A0 =C2=A0 /init
[ =C2=A0 33.334643] =C2=A0 with environment:[ =C2=A0 33.334724] =C2=A0 =C2=A0 HOME=3D/
[ =C2=A0 33.334796] =C2=A0 = =C2=A0 TERM=3Dlinux
[ =C2=A0 33.334872] =C2=A0 =C2=A0 earlyprintk=3Dxen<= br>Loading, please wait...
Starting version 245.4-4ubuntu3
[ =C2=A0 3= 9.458844] rk_gmac-dwmac fe300000.ethernet: IRQ eth_wake_irq not found
[ = =C2=A0 39.459243] rk_gmac-dwmac fe300000.ethernet: IRQ eth_lpi not found[ =C2=A0 39.460311] rk_gmac-dwmac fe300000.ethernet: PTP uses main clock[ =C2=A0 39.460560] rk_gmac-dwmac fe300000.ethernet: Looking up phy-suppl= y from device tree
[ =C2=A0 39.462867] rk_gmac-dwmac fe300000.ethernet: = clock input or output? (input).
[ =C2=A0 39.463089] rk_gmac-dwmac fe3000= 00.ethernet: TX delay(0x28).
[ =C2=A0 39.463224] rk_gmac-dwmac fe300000.= ethernet: RX delay(0x11).
[ =C2=A0 39.463365] rk_gmac-dwmac fe300000.eth= ernet: integrated PHY? (no).
[ =C2=A0 39.463717] rk_gmac-dwmac fe300000.= ethernet: cannot get clock clk_mac_speed
[ =C2=A0 39.463995] rk_gmac-dwm= ac fe300000.ethernet: clock input from PHY
[ =C2=A0 39.469266] rk_gmac-d= wmac fe300000.ethernet: init for RGMII
[ =C2=A0 39.531375] rk_gmac-dwmac= fe300000.ethernet: User ID: 0x10, Synopsys ID: 0x35
[ =C2=A0 39.540951]= rk_gmac-dwmac fe300000.ethernet: =C2=A0 =C2=A0 =C2=A0 =C2=A0 DWMAC1000
= [ =C2=A0 39.543024] rk_gmac-dwmac fe300000.ethernet: DMA HW capability regi= ster supported
[ =C2=A0 39.543220] rk_gmac-dwmac fe300000.ethernet: RX C= hecksum Offload Engine supported
[ =C2=A0 39.543358] rk_gmac-dwmac fe300= 000.ethernet: COE Type 2
[ =C2=A0 39.543476] rk_gmac-dwmac fe300000.ethe= rnet: TX Checksum insertion supported
[ =C2=A0 39.543614] rk_gmac-dwmac = fe300000.ethernet: Wake-Up On Lan supported
[ =C2=A0 39.544622] rk_gmac-= dwmac fe300000.ethernet: Normal descriptors
[ =C2=A0 39.545001] rk_gmac-= dwmac fe300000.ethernet: Ring mode enabled
[ =C2=A0 39.545138] rk_gmac-d= wmac fe300000.ethernet: Enable RX Mitigation via HW Watchdog Timer
[ =C2= =A0 39.545312] rk_gmac-dwmac fe300000.ethernet: device MAC address 6e:d0:b3= :b7:fc:57
[ =C2=A0 40.095457] libphy: stmmac: probed
[ =C2=A0 40.0960= 18] mdio_bus stmmac-0:00: attached PHY driver [unbound] (mii_bus:phy_addr= =3Dstmmac-0:00, irq=3DPOLL)
[ =C2=A0 40.096233] mdio_bus stmmac-0:01: at= tached PHY driver [unbound] (mii_bus:phy_addr=3Dstmmac-0:01, irq=3DPOLL)[ =C2=A0 40.338726] dwmmc_rockchip fe310000.mmc: IDMAC supports 32-bit add= ress mode.
[ =C2=A0 40.339251] dwmmc_rockchip fe310000.mmc: Using intern= al DMA controller.
[ =C2=A0 40.339415] dwmmc_rockchip fe310000.mmc: Vers= ion ID is 270a
[ =C2=A0 40.339902] dwmmc_rockchip fe310000.mmc: DW MMC c= ontroller at irq 17,32 bit host data width,256 deep fifo
[ =C2=A0 40.344= 800] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply from device tree[ =C2=A0 40.345102] dwmmc_rockchip fe310000.mmc: Looking up vmmc-supply p= roperty in node /mmc@fe310000 failed
[ =C2=A0 40.345849] rockchip-therma= l ff260000.tsadc: failed to register sensor 0: -517
[ =C2=A0 40.345897] = dwmmc_rockchip fe310000.mmc: Looking up vqmmc-supply from device tree
[ = =C2=A0 40.346034] rockchip-thermal ff260000.tsadc: failed to register senso= r[0] : error =3D -517
[ =C2=A0 40.346160] dwmmc_rockchip fe310000.mmc: L= ooking up vqmmc-supply property in node /mmc@fe310000 failed

Begin: = Loading essential drivers ... done.
Begin: Running /scripts/init-premoun= t ... done.
Begin: Mounting root file system ... Begin: Running /scripts= /local-top ... done.
Begin: Running /scripts/local-premount ...
done= .
[ =C2=A0 64.586284] vcc3v3_pcie: disabling
Begin: Waiting for root = file system ... Begin: Running /scripts/local-block ... done.
done.
G= ave up waiting for root file system device.=C2=A0 Common problems:
=C2= =A0- Boot args (cat /proc/cmdline)
=C2=A0 =C2=A0- Check rootdelay=3D (di= d the system wait long enough?)
=C2=A0- Missing modules (cat /proc/modul= es; ls /dev)
ALERT! =C2=A0/dev/nvme0n1p2 does not exist.=C2=A0 Dropping = to a shell!


BusyBox v1.30.1 (Ubuntu 1:1.30.1-4ubuntu6) built-in = shell (ash)
Enter 'help' for a list of built-in commands.
(initramfs)=C2=A0



- Brad=C2=A0
--000000000000c00fc105e38bdacc-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 05:49:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 05:49:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365466.595629 (Exim 4.92) (envelope-from ) id 1oB8m2-00046g-Vw; Tue, 12 Jul 2022 05:49:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365466.595629; Tue, 12 Jul 2022 05:49:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB8m2-00046Z-T0; Tue, 12 Jul 2022 05:49:30 +0000 Received: by outflank-mailman (input) for mailman id 365466; Tue, 12 Jul 2022 05:49:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB8m1-00046T-De for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 05:49:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 63816636-01a6-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 07:49:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 04F551FD87; Tue, 12 Jul 2022 05:49:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B553E13638; Tue, 12 Jul 2022 05:49:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id IR/rKmULzWKVbAAAMHmgww (envelope-from ); Tue, 12 Jul 2022 05:49:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63816636-01a6-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657604966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jh321WAMx55wXrILggPbAdouvM2JL6wJeNOyshHwZ14=; b=VomoYy10oJjNfyOXAt6iBPIATUIXB8l7airFCCCZDsk6cqwjtx4BcGjexdJ0W9IyE229E9 bhDLCQU5sjH19Znf/QWa+Rfl59JZwVOuX+ZkejY7aEjV/R+wzmVDb+Ng6AiCwF75Tgmj2v nrOfBZ0P7+o/wLiAKIe9UAr++DBtWSQ= Message-ID: <47bd7e63-501b-28a2-97f4-723d73cf0c53@suse.com> Date: Tue, 12 Jul 2022 07:49:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> From: Juergen Gross Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WB1PRtPTXCrE1BDOQ07lS05K" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WB1PRtPTXCrE1BDOQ07lS05K Content-Type: multipart/mixed; boundary="------------LNP0HlPGENkZfT2Jy80tGIeh"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , Borislav Petkov , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" Message-ID: <47bd7e63-501b-28a2-97f4-723d73cf0c53@suse.com> Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> In-Reply-To: --------------LNP0HlPGENkZfT2Jy80tGIeh Content-Type: multipart/mixed; boundary="------------ZBVFmxhu7YV85S0jxSbESRaX" --------------ZBVFmxhu7YV85S0jxSbESRaX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMTk6NDEsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IE9uIDcvMTEv MjAyMiAxMDozMSBBTSwgSnVlcmdlbiBHcm9zcyB3cm90ZToNCj4+IE9uIDExLjA3LjIyIDE2 OjE4LCBDaHVjayBabXVkemluc2tpIHdyb3RlOg0KPj4+IE9uIDcvNS8yMiAxMjoxNCBQTSwg Qm9yaXNsYXYgUGV0a292IHdyb3RlOg0KPj4+PiBPbiBUdWUsIEp1bCAwNSwgMjAyMiBhdCAw NTo1NjozNlBNICswMjAwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+IFJlLXVzaW5nIHBh dF9kaXNhYmxlZCBsaWtlIHlvdSBkbyBpbiB5b3VyIHN1Z2dlc3Rpb24gYmVsb3cgd29uJ3QN Cj4+Pj4+IHdvcmssIGJlY2F1c2UgbXRycl9icF9pbml0KCkgY2FsbHMgcGF0X2Rpc2FibGUo KSB3aGVuIE1UUlJzDQo+Pj4+PiBhcHBlYXIgdG8gYmUgZGlzYWJsZWQgKGZyb20gdGhlIGtl cm5lbCdzIHZpZXcpLiBUaGUgZ29hbCBpcyB0bw0KPj4+Pj4gaG9ub3IgIm5vcGF0IiB3aXRo b3V0IGhvbm9yaW5nIGFueSBvdGhlciBjYWxscyB0byBwYXRfZGlzYWJsZSgpLg0KPj4+Pg0K Pj4+PiBBY3R1YWxseSwgdGhlIGN1cnJlbnQgZ29hbCBpcyB0byBhZGp1c3QgWGVuIGRvbTAg YmVjYXVzZToNCj4+Pj4NCj4+Pj4gMS4gaXQgdXNlcyB0aGUgUEFUIGNvZGUNCj4+Pj4NCj4+ Pj4gMi4gYnV0IHRoZW4gaXQgZG9lcyBzb21ldGhpbmcgc3BlY2lhbCBhbmQgaGlkZXMgdGhl IE1UUlJzDQo+Pj4+DQo+Pj4+IHdoaWNoIGlzIG5vdCBzb21ldGhpbmcgcmVhbCBoYXJkd2Fy ZSBkb2VzLg0KPj4+Pg0KPj4+PiBTbyB0aGlzIG9uZS1vZmYgdGhpbmcgc2hvdWxkIGJlIHBy b21pbmVudCwgdmlzaWJsZSBhbmQgbm90IGdldCBpbiB0aGUNCj4+Pj4gd2F5Lg0KPj4+DQo+ Pj4gSGVsbG8sDQo+Pj4NCj4+PiBJIGhhdmUgc3BlbnQgYSBmYWlyIGFtb3VudCBvZiB0aW1l IHRoaXMgcGFzdCB3ZWVrZW5kDQo+Pj4gaW52ZXN0aWdhdGluZyB0aGlzIHJlZ3Jlc3Npb24g YW5kIHdoYXQgbWlnaHQgaGF2ZSBjYXVzZWQNCj4+PiBpdCBhbmQgSSBhbHNvIGhhdmUgZG9u ZSBzZXZlcmFsIHRlc3RzIG9uIG15IFhlbiB3b3Jrc3RhdGlvbg0KPj4+IHRoYXQgZXhoaWJp dHMgdGhlIHJlZ3Jlc3Npb24gdG8gdmVyaWZ5IG15IHVuZGVyc3RhbmRpbmcNCj4+PiBvZiB0 aGUgcHJvYmxlbSBhbmQgYWxzbyByYWlzZSBvdGhlciBwcm9ibGVtYXRpYyBwb2ludHMuDQo+ Pj4NCj4+PiBJIHRoaW5rLCBpbiBhZGRpdGlvbiB0byBpbW1lZGlhdGVseSBmaXhpbmcgdGhl IHJlZ3Jlc3Npb24gYnkNCj4+PiBmaXhpbmcgdGhlIG5vdyBmaXZlLXllYXItb2xkIGNvbW1p dCB0aGF0IGlzIHRoZSByb290IGNhdXNlDQo+Pj4gb2YgdGhlIHJlY2VudGx5IGV4cG9zZWQg cmVncmVzc2lvbiwgYXMgZGlzY3Vzc2VkIGluIG15DQo+Pj4gZWFybGllciBtZXNzYWdlIHdo aWNoIHByb3Bvc2VzIGEgc2ltcGxlIHBhdGNoIHRvIGZpeCB0aGF0DQo+Pj4gZml2ZS15ZWFy LW9sZCBicm9rZW4gY29tbWl0LA0KPj4+DQo+Pj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcv bGttbC82MzU4MzQ5Ny0xNTJmLTU4ODAtNGM4Zi1kNDdlMmE4MWY1YTZAbmV0c2NhcGUubmV0 Lw0KPj4+DQo+Pj4gdGhlcmUgbmVlZHMgdG8gYmUgYSBkZWNpc2lvbiBhYm91dCBob3cgYmVz dCB0byBkZWFsIHdpdGgNCj4+PiB0aGlzIHZlcnkgYXB0bHkgZGVzY3JpYmVkICJvbmUtb2Zm IFhlbiB0aGluZyIgaW4gdGhlIGZ1dHVyZS4NCj4+Pg0KPj4+IE9uZSBwcm9ibGVtIGluIHg4 Ni9tbS9wYXQvbWVtdHlwZS5jIGlzIHRoZSBmYWN0IHRoYXQgdGhlcmUNCj4+PiBleGlzdCB0 d28gZnVuY3Rpb25zLCBwYXRfaW5pdCgpLCBhbmQgaW5pdF9jYWNoZV9tb2RlcygpLCB0aGF0 DQo+Pj4gZG8gbW9yZSBvciBsZXNzIHRoZSBzYW1lIHRoaW5nLCBzbyB0aGF0IHdoZW4gb25l IG9mIHRob3NlDQo+Pj4gZnVuY3Rpb25zIG5lZWRzIHRvIGJlIHVwZGF0ZWQsIHRoZSBvdGhl ciBhbHNvIG5lZWRzIHRvDQo+Pj4gYmUgdXBkYXRlZC4gSW4gdGhlIHBhc3QsIHdoZW4gY2hh bmdlcyB0byB0aGUgcGF0X2VuYWJsZQ0KPj4+IGFuZCBwYXRfZGlzYWJsZSBmdW5jdGlvbnMg YW5kIHZhcmlhYmxlcyB3ZXJlIG1hZGUsIGFsbA0KPj4+IHRvbyBvZnRlbiwgdGhlIGNoYW5n ZSB3YXMgb25seSBhcHBsaWVkIHRvIHBhdF9pbml0KCkgYW5kIG5vdA0KPj4+IHRvIGluaXRf Y2FjaGVfbW9kZXMoKSBhbmQgdGhlIG9uZS1vZmYgWGVuIGNhc2Ugd2FzIHNpbXBseQ0KPj4+ IG5vdCBhZGRyZXNzZWQgYW5kIGRlYWx0IHdpdGggcHJvcGVybHkuDQo+Pj4NCj4+PiBTbyBJ IHByb3Bvc2UgdGhlIGZvbGxvd2luZzoNCj4+Pg0KPj4+IDEpIElkZW50aWZ5IHRob3NlIHRo aW5ncyB0aGF0IGFsd2F5cyBuZWVkIHRvIGJlIGRvbmUgaW4NCj4+PiBlaXRoZXIgcGF0X2lu aXQoKSBvciBpbml0X2NhY2hlX21vZGVzKCkgYW5kIHRyeSB0byBjb21iaW5lDQo+Pj4gdGhv c2UgdGhpbmdzIGludG8gYSBzaW5nbGUgZnVuY3Rpb24gc28gdGhhdCBjaGFuZ2VzIHdpbGwN Cj4+PiBiZSBhcHBsaWVkIGZvciBib3RoIGNhc2VzLiBXZSBzb3J0IG9mIGhhdmUgdGhhdCBu b3cgd2l0aA0KPj4+IF9faW5pdF9jYWNoZV9tb2RlcygpLCBidXQgaXQgaXMgbm90IHJlYWxs eSBnb29kIGVub3VnaCB0bw0KPj4+IHByZXZlbnQgdGhlIHJlZ3Jlc3Npb25zIHdlIHNvbWV0 aW1lcyBnZXQgaW4gWGVuIFBWDQo+Pj4gZG9tYWlucyBzdWNoIGFzIHRoZSBjdXJyZW50IHJl Z3Jlc3Npb24gd2UgaGF2ZSB3aXRoDQo+Pj4gWGVuIERvbTAgYW5kIGNlcnRhaW4gcGFydGlj dWxhciBJbnRlbCBncmFwaGljcyBkZXZpY2VzLg0KPj4+DQo+Pj4gMikgSWYgaXQgaXMgbm90 IHBvc3NpYmxlIHRvIGRvIHdoYXQgaXMgcHJvcG9zZWQgaW4gMSksIGF0IGxlYXN0DQo+Pj4g cmUtZmFjdG9yIHRoZSBjb2RlIHRvIG1ha2UgaXQgdmVyeSBjbGVhciB0aGF0IHdoZW5ldmVy DQo+Pj4gZWl0aGVyIHBhdF9pbml0KCkgbmVlZHMgdG8gYmUgYWRqdXN0ZWQgb3IgaW5pdF9j YWNoZV9tb2RlcygpDQo+Pj4gbmVlZHMgdG8gYmUgYWRqdXN0ZWQsIGNhcmUgbXVzdCBiZSB0 YWtlbiB0byBlbnN1cmUgdGhhdA0KPj4+IGFsbCBjYXNlcyBhcmUgcHJvcGVybHkgZGVhbHQg d2l0aCwgaW5jbHVkaW5nIHRoZQ0KPj4+IG9uZS1vZmYgWGVuIGNhc2Ugb2YgZW5hYmxpbmcg UEFUIHdpdGggTVRSUiBkaXNhYmxlZCwNCj4+PiBDdXJyZW50bHksIEFJVUksIGFsbCBvbmUg cmVhbGx5IG5lZWRzIHRvIGtub3cgaXMgdGhhdA0KPj4+IGluaXRfY2FjaGVkX21vZGVzKCkg aGFuZGxlcyB0d28gc3BlY2lhbCBjYXNlczoNCj4+PiBGaXJzdCwgd2hlbiBQQVQgaXMgZGlz YWJsZWQgZm9yIGFueSByZWFzb24sIGluY2x1ZGluZyB3aGVuDQo+Pj4gdGhlICJub3BhdCIg Ym9vdCBvcHRpb24gaXMgc2V0LCBhbmQgc2Vjb25kLCB0aGUgb25lLW9mZg0KPj4+IFhlbiBj YXNlIG9mIE1UUlIgYmVpbmcgZGlzYWJsZWQgYnV0IFBBVCBiZWluZyBlbmFibGVkLg0KPj4+ DQo+Pj4gSSBhbSB0cnlpbmcgdG8gZG8gbnVtYmVyIDIgd2l0aCBhIHBhdGNoIHNlcmllcyBJ IGFtDQo+Pj4gd29ya2luZyBvbi4gSXQgaXMgdXAgdG8gdGhlIGV4cGVydHMgdG8gZGVjaWRl IGlmIGl0DQo+Pj4gaXMgcG9zc2libGUgb3IgZXZlbiBkZXNpcmFibGUgdG8gaW1wcm92ZSB0 aGUgY29kZSBzbw0KPj4+IHRoYXQgYW55IGNoYW5nZXMgdG8gdGhlIGNhY2hpbmcgY29uZmln dXJhdGlvbiBhcmUgbW9yZQ0KPj4+IGxpa2VseSB0byBiZSBwcm9wZXJseSBpbXBsZW1lbnRl ZCBmb3IgYWxsIHN1cHBvcnRlZCBwbGF0Zm9ybXMNCj4+PiBieSBzdWNjZXNzZnVsbHkgY29t YmluaW5nIHRoZSB0d28gZnVuY3Rpb25zIHBhdF9pbml0KCkgYW5kDQo+Pj4gaW5pdF9jYWNo ZV9tb2RlcygpIGludG8gYSBzaW5nbGUgZnVuY3Rpb24uIFRoZSBuZXcgZnVuY3Rpb24NCj4+ PiB3b3VsZCBwcm9iYWJseSBuZWVkIHRvIGJlIHJlbmFtZWQgYW5kIGluY2x1ZGUgYml0cyBm cm9tDQo+Pj4gbXRycl9icF9lbmFibGVkLCBldGMuIGZvciBpdCB0byBmdW5jdGlvbiBwcm9w ZXJseS4NCj4+Pg0KPj4+IElmIGFueW9uZSB3YW50cyB0byBhcmd1ZSB0aGF0IGl0IGlzIG5v dCBkZXNpcmFibGUgdG8gdHJ5DQo+Pj4gY29tYmluZSBwYXRfaW5pdCgpIGFuZCBpbml0X2Nh Y2hlX21vZGVzKCkgaW50byBhIHNpbmdsZQ0KPj4+IGZ1bmN0aW9uLCBJIHRoaW5rIHRoZSBi dXJkZW4gb2YgcHJvb2YgcmVzdHMgb24gdGhhdA0KPj4+IHBlcnNvbiB0byBkZW1vbnN0cmF0 ZSB3aHkgaXQgaXMgZ29vZCBhbmQgY2xlYW4NCj4+PiBjb2RpbmcgcHJhY3RpY2UgdG8gY29u dGludWUgdG8gaGF2ZSB0aGVtIHNlcGFyYXRlDQo+Pj4gYW5kIGluZGVwZW5kZW50IGZyb20g ZWFjaCBvdGhlciBpbiB0aGUgY29kZSB3aGVuDQo+Pj4gdGhleSBib3RoIGVzc2VudGlhbGx5 IGRvIHRoZSBzYW1lIHRoaW5nIGluIHRoZSBlbmQsIHdoaWNoDQo+Pj4gaXMgY2FsbCBfX2lu aXRfY2FjaGVfbW9kZXMoKSBhbmQgZGV0ZXJtaW5lIHRoZSBQQVQNCj4+PiBzdGF0ZSwgYW5k IGFsc28gcHJvYmFibHkgdGhlIE1UUlIgc3RhdGUuDQo+Pg0KPj4gSSB0aGluayB0aGUgcHJv cGVyIHNvbHV0aW9uIHdvdWxkIGJlIHRvIG1ha2UgUEFUIGFuZCBNVFJSIGluZGVwZW5kZW50 DQo+PiBmcm9tIGVhY2ggb3RoZXIgd2l0aCBzb21lIGFkZGl0aW9uYWwgcmVzdHJ1Y3R1cmlu ZyBvbiB0aGUgUEFUIHNpZGU6DQo+Pg0KPj4gVG9kYXkgUEFUIGNhbid0IGJlIHVzZWQgd2l0 aG91dCBNVFJSIGJlaW5nIGF2YWlsYWJsZSwgdW5sZXNzIE1UUlIgaXMgYXQNCj4+IGxlYXN0 IGNvbmZpZ3VyZWQgdmlhIENPTkZJR19NVFJSIGFuZCB0aGUgc3lzdGVtIGlzIHJ1bm5pbmcg YXMgWGVuIFBWDQo+PiBndWVzdC4gSW4gdGhpcyBjYXNlIFBBVCBpcyBhdXRvbWF0aWNhbGx5 IGF2YWlsYWJsZSB2aWEgdGhlIGh5cGVydmlzb3IsDQo+PiBidXQgdGhlIFBBVCBNU1IgY2Fu J3QgYmUgbW9kaWZpZWQgYnkgdGhlIGtlcm5lbCBhbmQgTVRSUiBpcyBkaXNhYmxlZC4NCj4+ DQo+PiBBcyBhbiBhZGRpdGlvbmFsIGNvbXBsZXhpdHkgdGhlIGF2YWlsYWJpbGl0eSBvZiBQ QVQgY2FuJ3QgYmUgcXVlcmllZA0KPj4gdmlhIHBhdF9lbmFibGVkKCkgaW4gdGhlIFhlbiBQ ViBjYXNlLCBhcyB0aGUgbGFjayBvZiBNVFJSIHdpbGwgc2V0IFBBVA0KPj4gdG8gYmUgZGlz YWJsZWQuDQo+IA0KPiBNeSB0ZXN0aW5nIGluZGljYXRlcyB5b3VyIHByZXN1bXB0aW9uIGlz IG5vdCBjb3JyZWN0LCBvciBhdCBsZWFzdCBteQ0KPiB0ZXN0aW5nIG9uIG15IFhlbiB3b3Jr c3RhdGlvbiBtYWtlcyBtZSBkb3VidCB0aGF0IHlvdXIgYXNzZXJ0aW9uIHRoYXQNCj4gUEFU IGNhbid0IGJlIHF1ZXJpZWQgdmkgcGF0X2VuYWJsZWQoKSBpbiB0aGUgWGVuIFBWIGNhc2Ug aXMgdHJ1ZS4NCg0KSSB3YXMgcmVmZXJyaW5nIHRvIHRoZSBjdXJyZW50IChyZWdyZXNzZWQp IHN0YXRlLg0KDQo+IA0KPiBMZXQgbWUgYmVnaW4gYSBkaXNjdXNzaW9uIGJ5IHBvc2luZyBh IHF1ZXN0aW9uIGFib3V0IHRoZSBmb2xsb3dpbmcNCj4gY29kZSBpbiBpbml0X2NhY2hlX21v ZGVzKCksIGEgZnVuY3Rpb24gaW1wbGVtZW50ZWQgaW4NCj4gYXJjaC94ODYvbW0vcGF0L21l bXR5cGVzLmMsIGFuZCB3aGljaCBpcyBjYWxsZWQgZnJvbQ0KPiBhcmNoL3g4Ni9rZXJuZWwv c2V0dXAuYyBidXQgb25seSBlZmZlY3RpdmUgaWYgcGF0X2NtX2luaXRpYWxpemVkDQo+IGhh cyBub3QgYWxyZWFkeSBiZWVuIHNldCBieSBwYXRfaW5pdCgpLCBhcyBpcyBvYnZpb3VzIGZy b20gdGhlDQo+IGltbWVkaWF0ZSByZXR1cm4gaWYgcGF0X2NtX2luaXRpYWxpemVkIGhhcyBh bHJlYWR5IGJlZW4gc2V0Lg0KPiANCj4gTm93IGluIHRoZSBYZW4gUFYgY2FzZSwgcGF0X2Nt X2luaXRpYWxpemVkIGlzIG5vdCBzZXQgYmVjYXVzZQ0KPiBwYXRfaW5pdCgpLCB3aGVyZSBp dCBpcyBub3JtYWxseSBzZXQsIHdhcyBza2lwcGVkIGR1ZSB0byB0aGUgZmFjdA0KPiB0aGF0 IE1UUlJzIGFyZSBkaXNhYmxlZCBpbiBYZW4gUFYgZG9tYWlucy4gSSB2ZXJpZmllZCB0aGF0 DQo+IGluaXRfY2FjaGVfbW9kZXMoKSBpcyBhY3RpdmF0ZWQgaW4gdGhlIFhlbiBQViBEb20w IGNhc2UgYnkgbXkNCj4gdGVzdGluZy4gU28sIEkgYXNrLCB3aHkgY2Fubm90IHRoZSBjb2Rl IHRoYXQgaXMgcHJlc2VudCBoZXJlIGluDQo+IGluaXRfY2FjaGVfbW9kZXMoKSBiZSB1c2Vk IHRvIHRlc3QgZm9yIFBBVCBpbiB0aGUgWGVuIFBWIERvbTANCj4gZW52aXJvbm1lbnQgYW5k IGlmIHRoZSB0ZXN0IGlzIHBvc2l0aXZlLCB3aHkgY2Fubm90IHBhdF9icF9lbmFibGVkDQo+ IGJlIHNldCB3aGljaCB3aWxsIGNhdXNlIHBhdF9lbmFibGVkKCkgdG8gcmV0dXJuIHRydWUg aW4gdGhlIFhlbg0KPiBQViBlbnZpcm9ubWVudD8gSW4gZmFjdCwgSSB1c2VkIHRoZSBhZGRp dGlvbmFsICdlbHNlIGlmJyBibG9jayB0bw0KPiBzZXQgcGF0X2JwX2VuYWJsZWQgdG8gdHJ1 ZSBpbiB0aGUgWGVuIFBWIGVudmlyb25tZW50IGZvciB0aGUNCj4gY2FzZSB3aGVuIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9QQVQpIGlzIHRydWUgYW5kIFBBVA0KPiBNU1IgZG9lcyBu b3QgcmV0dXJuIDAsIHRoYXQsIGlzLCB3aGVuIHBhdCAhPTAgYWZ0ZXIgY2FsbGluZw0KPiBy ZG1zcmwoTVNSX0lBMzJfQ1JfUEFULCBwYXQpIGZvciB0aGUgYm9vdCBDUFUuIEFsbCB0aGUg ZXhpc3RpbmcNCj4gY29tbWVudHMgaW4gdGhpcyBmdW5jdGlvbiBpbmRpY2F0ZSB0aGlzIGlz IGEgdmFsaWQgd2F5IHRvIHRlc3QNCj4gZm9yIHRoZSBleGlzdGVuY2Ugb2YgUEFUIGluIHRo ZSBYZW4gUFYgRG9tMCBlbnZpcm9ubWVudC4NCg0KSSBhZ3JlZSB0aGlzIGlzIGEgcG9zc2li aWxpdHkgdG8gZml4IHRoZSByZWdyZXNzaW9uLg0KDQpJbiB0aGUgbG9uZyBydW4gSSBzdGls bCB0aGluayB0aGF0IG15IGlkZWEgaXMgdGhlIGJldHRlciBvbmUsIGFzIGl0DQphbGxvd3Mg dG8gcnVuIHdpdGhvdXQgQ09ORklHX01UUlIgZXZlbiBvbiBiYXJlIG1ldGFsIHdpdGhvdXQg bG9zaW5nDQp0aGUgUEFUIGZ1bmN0aW9uYWxpdHkuDQoNCj4gDQo+IE1vcmVvdmVyLi4uIChw bGVhc2UgbW92ZSB0byB0aGUgYm90dG9tIG9mIHRoZSBjb2RlIHNuaXBwZXQNCj4gZm9yIG1v cmUgaW5mb3JtYXRpb24gYWJvdXQgbXkgdGVzdHMgaW4gdGhlIFhlbiBQViBlbnZpcm9ubWVu dC4uLikNCj4gDQo+IHZvaWQgaW5pdF9jYWNoZV9tb2Rlcyh2b2lkKQ0KPiB7DQo+ICDCoMKg IMKgdTY0IHBhdCA9IDA7DQo+IA0KPiAgwqDCoCDCoGlmIChwYXRfY21faW5pdGlhbGl6ZWQp DQo+ICDCoMKgIMKgwqDCoMKgIHJldHVybjsNCj4gDQo+ICDCoMKgIMKgaWYgKGJvb3RfY3B1 X2hhcyhYODZfRkVBVFVSRV9QQVQpKSB7DQo+ICDCoMKgIMKgwqDCoMKgIC8qDQo+ICDCoMKg IMKgwqDCoMKgIMKgKiBDUFUgc3VwcG9ydHMgUEFULiBTZXQgUEFUIHRhYmxlIHRvIGJlIGNv bnNpc3RlbnQgd2l0aA0KPiAgwqDCoCDCoMKgwqDCoCDCoCogUEFUIE1TUi4gVGhpcyBjYXNl IHN1cHBvcnRzICJub3BhdCIgYm9vdCBvcHRpb24sIGFuZA0KPiAgwqDCoCDCoMKgwqDCoCDC oCogdmlydHVhbCBtYWNoaW5lIGVudmlyb25tZW50cyB3aGljaCBzdXBwb3J0IFBBVCB3aXRo b3V0DQo+ICDCoMKgIMKgwqDCoMKgIMKgKiBNVFJScy4gSW4gc3BlY2lmaWMsIFhlbiBoYXMg dW5pcXVlIHNldHVwIHRvIFBBVCBNU1IuDQo+ICDCoMKgIMKgwqDCoMKgIMKgKg0KPiAgwqDC oCDCoMKgwqDCoCDCoCogSWYgUEFUIE1TUiByZXR1cm5zIDAsIGl0IGlzIGNvbnNpZGVyZWQg aW52YWxpZCBhbmQgZW11bGF0ZXMNCj4gIMKgwqAgwqDCoMKgwqAgwqAqIGFzIE5vIFBBVC4N Cj4gIMKgwqAgwqDCoMKgwqAgwqAqLw0KPiAgwqDCoCDCoMKgwqDCoCByZG1zcmwoTVNSX0lB MzJfQ1JfUEFULCBwYXQpOw0KPiAgwqDCoCDCoH0NCj4gDQo+ICDCoMKgIMKgaWYgKCFwYXQp IHsNCj4gIMKgwqAgwqDCoMKgwqAgLyoNCj4gIMKgwqAgwqDCoMKgwqAgwqAqIE5vIFBBVC4g RW11bGF0ZSB0aGUgUEFUIHRhYmxlIHRoYXQgY29ycmVzcG9uZHMgdG8gdGhlIHR3bw0KPiAg wqDCoCDCoMKgwqDCoCDCoCogY2FjaGUgYml0cywgUFdUIChXcml0ZSBUaHJvdWdoKSBhbmQg UENEIChDYWNoZSBEaXNhYmxlKS4NCj4gIMKgwqAgwqDCoMKgwqAgwqAqIFRoaXMgc2V0dXAg aXMgYWxzbyB0aGUgc2FtZSBhcyB0aGUgQklPUyBkZWZhdWx0IHNldHVwLg0KPiAgwqDCoCDC oMKgwqDCoCDCoCoNCj4gIMKgwqAgwqDCoMKgwqAgwqAqIFBURSBlbmNvZGluZzoNCj4gIMKg wqAgwqDCoMKgwqAgwqAqDQo+ICDCoMKgIMKgwqDCoMKgIMKgKsKgwqDCoMKgwqDCoCBQQ0QN Cj4gIMKgwqAgwqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKgIHxQV1TCoCBQQVQNCj4gIMKgwqAg wqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKgIHx8wqDCoMKgIHNsb3QNCj4gIMKgwqAgwqDCoMKg wqAgwqAqwqDCoMKgwqDCoMKgIDAwwqDCoMKgIDDCoMKgwqAgV0IgOiBfUEFHRV9DQUNIRV9N T0RFX1dCDQo+ICDCoMKgIMKgwqDCoMKgIMKgKsKgwqDCoMKgwqDCoCAwMcKgwqDCoCAxwqDC oMKgIFdUIDogX1BBR0VfQ0FDSEVfTU9ERV9XVA0KPiAgwqDCoCDCoMKgwqDCoCDCoCrCoMKg wqDCoMKgwqAgMTDCoMKgwqAgMsKgwqDCoCBVQy06IF9QQUdFX0NBQ0hFX01PREVfVUNfTUlO VVMNCj4gIMKgwqAgwqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKgIDExwqDCoMKgIDPCoMKgwqAg VUMgOiBfUEFHRV9DQUNIRV9NT0RFX1VDDQo+ICDCoMKgIMKgwqDCoMKgIMKgKg0KPiAgwqDC oCDCoMKgwqDCoCDCoCogTk9URTogV2hlbiBXQyBvciBXUCBpcyB1c2VkLCBpdCBpcyByZWRp cmVjdGVkIHRvIFVDLSBwZXINCj4gIMKgwqAgwqDCoMKgwqAgwqAqIHRoZSBkZWZhdWx0IHNl dHVwIGluIF9fY2FjaGVtb2RlMnB0ZV90YmxbXS4NCj4gIMKgwqAgwqDCoMKgwqAgwqAqLw0K PiAgwqDCoCDCoMKgwqDCoCBwYXQgPSBQQVQoMCwgV0IpIHwgUEFUKDEsIFdUKSB8IFBBVCgy LCBVQ19NSU5VUykgfCBQQVQoMywgVUMpIHwNCj4gIMKgwqAgwqDCoMKgwqAgwqDCoMKgwqDC oCBQQVQoNCwgV0IpIHwgUEFUKDUsIFdUKSB8IFBBVCg2LCBVQ19NSU5VUykgfCBQQVQoNywg VUMpOw0KPiAgwqDCoCDCoH0NCj4gDQo+ICDCoMKgIMKgZWxzZSBpZiAoIXBhdF9icF9lbmFi bGVkKSB7DQo+ICDCoMKgIMKgwqDCoMKgIC8qDQo+ICDCoMKgIMKgwqDCoMKgIMKgKiBJbiBz b21lIGVudmlyb25tZW50cywgc3BlY2lmaWNhbGx5IFhlbiBQViwgUEFUDQo+ICDCoMKgIMKg wqDCoMKgIMKgKiBpbml0aWFsaXphdGlvbiBpcyBza2lwcGVkIGJlY2F1c2UgTVRSUnMgYXJl DQo+ICDCoMKgIMKgwqDCoMKgIMKgKiBkaXNhYmxlZCBldmVuIHRob3VnaCBQQVQgaXMgYXZh aWxhYmxlLiBJbiBzdWNoDQo+ICDCoMKgIMKgwqDCoMKgIMKgKiBlbnZpcm9ubWVudHMsIHNl dCBQQVQgdG8gaW5pdGlhbGl6ZWQgYW5kIGVuYWJsZWQgdG8NCj4gIMKgwqAgwqDCoMKgwqAg wqAqIGNvcnJlY3RseSBpbmRpY2F0ZSB0byBjYWxsZXJzIG9mIHBhdF9lbmFibGVkKCkgdGhh dA0KPiAgwqDCoCDCoMKgwqDCoCDCoCogUEFUIGlzIGF2YWlsYWJsZSBhbmQgcHJldmVudCBQ QVQgZnJvbSBiZWluZyBkaXNhYmxlZC4NCj4gIMKgwqAgwqDCoMKgwqAgwqAqLw0KPiAgwqDC oCDCoMKgwqDCoCBwYXRfYnBfZW5hYmxlZCA9IHRydWU7DQo+ICDCoMKgIMKgwqDCoMKgIHBy X2luZm8oIng4Ni9QQVQ6IFBBVCBlbmFibGVkIGJ5IGluaXRfY2FjaGVfbW9kZXNcbiIpOw0K PiAgwqDCoCDCoH0NCj4gDQo+ICDCoMKgIMKgX19pbml0X2NhY2hlX21vZGVzKHBhdCk7DQo+ IH0NCj4gDQo+IFRoaXMgZnVuY3Rpb24sIHBhdGNoZWQgd2l0aCB0aGUgZXh0cmEgJ2Vsc2Ug aWYnIGJsb2NrLCBmaXhlcyB0aGUNCj4gcmVncmVzc2lvbiBvbiBteSBYZW4gd29ya3NhdGF0 aW9uLCBhbmQgdGhlIHByX2luZm8gbWVzc2FnZQ0KPiAieDg2L1BBVDogUEFUIGVuYWJsZWQg YnkgaW5pdF9jYWNoZV9tb2RlcyIgYXBwZWFycyBpbiB0aGUgbG9ncw0KPiB3aGVuIHJ1bm5p bmcgdGhpcyBwYXRjaGVkIGtlcm5lbCBpbiBteSBYZW4gRG9tMC4gVGhpcyBtZWFucw0KPiB0 aGF0IGluIHRoZSBYZW4gUFYgZW52aXJvbm1lbnQgb24gbXkgWGVuIERvbTAgd29ya3N0YXRp b24sDQo+IHJkbXNybChNU1JfSUEzMl9DUl9QQVQsIHBhdCkgc3VjY2Vzc2Z1bGx5IHRlc3Rl ZCBmb3IgdGhlIHByZXNlbmNlDQo+IG9mIFBBVCBvbiB0aGUgdmlydHVhbCBDUFUgdGhhdCBY ZW4gZXhwb3NlZCB0byB0aGUgTGludXgga2VybmVsIG9uIG15DQo+IFhlbiBEb20wIHdvcmtz dGF0aW9uLiBBdCBsZWFzdCB0aGF0IGlzIHdoYXQgSSB0aGluayBteSB0ZXN0cyBwcm92ZS4N Cg0KWWVzLCB5b3VyIGZpeCBpcyBjb3JyZWN0IEFGQUlDUy4NCg0KPiBTbyB3aHkgaXMgdGhp cyBub3QgYSB2YWxpZCB3YXkgdG8gdGVzdCBmb3IgdGhlIGV4aXN0ZW5jZSBvZg0KPiBQQVQg aW4gdGhlIFhlbiBQViBlbnZpcm9ubWVudD8gQXJlIHRoZSBleGlzdGluZyBjb21tZW50cw0K PiBpbiBpbml0X2NhY2hlX21vZGVzKCkgYWJvdXQgc3VwcG9ydGluZyBib3RoIHRoZSBjYXNl IHdoZW4NCj4gdGhlICJub3BhdCIgYm9vdCBvcHRpb24gaXMgc2V0IGFuZCB0aGUgc3BlY2lm aWMgY2FzZSBvZiBYZW4gYW5kDQo+IE1UUlIgZGlzYWJsZWQgd3Jvbmc/IE15IHRlc3Rpbmcg Y29uZmlybXMgdGhvc2UgY29tbWVudHMgYXJlDQo+IGNvcnJlY3QuDQo+IA0KPj4gVGhpcyBs ZWFkcyB0byBzb21lIGRyaXZlcnMgYmVsaWV2aW5nIHRoYXQgbm90IGFsbCBjYWNoZQ0KPj4g bW9kZXMgYXJlIGF2YWlsYWJsZSwgcmVzdWx0aW5nIGluIGZhaWx1cmVzIG9yIGRlZ3JhZGVk IGZ1bmN0aW9uYWxpdHkNCj4+ICh0aGUgY3VycmVudCByZWdyZXNzaW9uKS4NCj4gDQo+IEkg YWxzbyBkaWQgc29tZSB0ZXN0cyB0byB0cnkgdG8gdmVyaWZ5IHRoYXQgZmFzdCBXQyBjYWNo aW5nIG1vZGUNCj4gd2FzIHVzZWQgYXMgcmVxdWVzdGVkIGJ5IHRoZSBpOTE1IEludGVsIGdy YXBoaWNzIGRyaXZlciBvbiBteQ0KPiBYZW4gRG9tMCB3b3Jrc3RhdGlvbiBhbmQgc28gZmFy IEkgY2Fubm90IHByb3ZlIHRoYXQgdGhlIFdDIGNhY2hpbmcNCj4gbW9kZSB3YXMgbm90IHVz ZWQsIGFuZCBJIGhhdmUgc29tZSBjdXN0b20gbG9ncyBmcm9tIHRoZQ0KPiBMaW51eCBrZXJu ZWwgaTkxNSBkcml2ZXIgdGhhdCBpbmRpY2F0ZXMgbXkgTGludXggWGVuIERvbTAgaXMgYWJs ZSB0bw0KPiB1c2UgdGhlIGZhc3QgV0MgY2FjaGluZyBtb2RlLCBzbyBsb25nIGFzIHRoZSBi dWcgdGhhdCBjYXVzZXMNCj4gcGF0X2VuYWJsZWQoKSB0byByZXR1cm4gYSBmYWxzZSBuZWdh dGl2ZSBpcyBmaXhlZC4NCj4gDQo+IFNvIG15IHRlc3Rpbmcgc2VlbXMgdG8gY29udHJhZGlj dCByYXRoZXIgdGhhbiBjb25maXJtIHlvdXIgY2xhaW0NCj4gdGhhdCAidGhlIGF2YWlsYWJp bGl0eSBvZiBQQVQgY2FuJ3QgYmUgcXVlcmllZCB2aWEgcGF0X2VuYWJsZWQoKSBpbg0KPiB0 aGUgWGVuIFBWIGNhc2UuIiBJIHRoaW5rIG15IHBhdGNoIHN1Y2Nlc3NmdWxseSBkb2VzIHdo YXQgeW91DQo+IGNsYWltIGNhbm5vdCBiZSBkb25lLCBhbmQgSSBhbHNvIHRoaW5rIHRoZSBl eGlzdGluZyBjb21tZW50cyBpbg0KPiBpbml0X2NhY2hlX21vZGVzKCkgaW5kaWNhdGVzIHRo YXQgbXkgcGF0Y2ggaXMgc3VjY2Vzc2Z1bGx5IHRlc3RpbmcNCj4gZm9yIFBBVCBpbiB0aGUg WGVuIFBWIGNhc2UuDQo+IA0KPj4NCj4+IFRoZSBzYW1lIGFwcGxpZXMgdG8gYSBrZXJuZWwg YnVpbHQgd2l0aCBubyBNVFJSIHN1cHBvcnQ6IGl0IHdvbid0DQo+PiBhbGxvdyB0byB1c2Ug dGhlIFBBVCBNU1IsIGV2ZW4gaWYgdGhlcmUgaXMgbm8gdGVjaG5pY2FsIHJlYXNvbiBmb3IN Cj4+IHRoYXQsIG90aGVyIHRoYW4gc2V0dGluZyB1cCBQQVQgb24gYWxsIGNwdXMgdGhlIHNh bWUgd2F5ICh3aGljaCBpcyBhDQo+PiByZXF1aXJlbWVudCBvZiB0aGUgcHJvY2Vzc29yJ3Mg Y2FjaGUgbWFuYWdlbWVudCkgaXMgcmVseWluZyBvbiBzb21lDQo+PiBNVFJSIHNwZWNpZmlj IGNvZGUuDQo+IA0KPiBBZnRlciByZWFkaW5nIHRoZSBjb2RlIGV4dGVuc2l2ZWx5LCBJIGFt IGN1cmlvdXMgYWJvdXQgdGVzdGluZw0KPiBhbmQgZXZlbiBzdWNjZXNzZnVsbHkgY29tcGls aW5nIGEga2VybmVsIHdpdGggb3B0aW9ucyBsaWtlDQo+IENPTkZJR19NVFJSIGFuZCBDT05G SUdfUEFUIGRpc2FibGVkLiBCdXQgbXkgdGVzdGluZyBpbmRpY2F0ZXMNCj4gc3VjaCBwcm9i bGVtcyBjb3VsZCBiZSBkZWJ1Z2dlZCBhbmQgZml4ZWQgaWYgdGhleSBtYW5pZmVzdA0KPiB1 c2luZyB0aGUgY3VycmVudCBjb2RlIHdoaWNoLCBBRkFJQ1QsIGFwcGVhcnMgdG8gYmUgbW9z dGx5DQo+IGRlc2lnbmVkIGFuZCB0ZXN0ZWQgZm9yIHRoZSBjYXNlIHdoZW4gYm90aCBQQVQg YW5kIE1UUlINCj4gYXJlIGVuYWJsZWQgb24gbW9kZXJuIHg4NiBoYXJkd2FyZS4gSSB3b3Vs ZCBleHBlY3QgbWFueQ0KPiBidWdzIGZvciBjb25maWd1cmF0aW9ucyB0aGF0IGRldmlhdGUg dG9vIGZhciBmcm9tIHRoYXQgcGFyYWRpZ20NCj4gb24gTGludXguIFRoaXMgaXMgdGhlIHBy b2JsZW0gd2l0aCBYZW4ncyB1bmlxdWUgY29uZmlndXJhdGlvbg0KPiB0aGF0IGVuYWJsZXMg UEFUIGJ1dCBkaXNhYmxlcyBNVFJSLiBJIHRoaW5rIHRoZSBwcm9ibGVtIGNhbg0KPiBiZSBz b2x2ZWQsIGl0IGlzIGp1c3QgdGhhdCB0aGVyZSBpcyBub3QgZW5vdWdoIGNhcmUgdGFrZW4g dG8NCj4gZW5zdXJlIHRoYXQgdGhlc2Ugb3V0bGllciBjYXNlcyB3aWxsIHdvcmsgYXMgd2Vs bCBhcyB0aGUgY29tbW9uDQo+IGNvbmZpZ3VyYXRpb24gdGhhdCBMaW51eCBzdXBwb3J0cyB3 ZWxsLCB3aGljaCBpcyB3aXRoIGJvdGgNCj4gTVRSUiBhbmQgUEFUIGVuYWJsZWQgb24geDg2 Lg0KDQpPbiBiYXJlIG1ldGFsIFBBVCBjYW4ndCB3b3JrIHdpdGhvdXQgQ09ORklHX01UUlIs IGFzIHNldHRpbmcgdGhlIFBBVA0KTVNSIHVuaWZvcm1seSBhY3Jvc3MgY3B1cyBjYW4ndCBi ZSBkb25lICh0aGUgY29kZSBpcyBub3QgYXZhaWxhYmxlDQp3aXRob3V0IENPTkZJR19NVFJS KS4NCg0KPiANCj4+DQo+PiBBbGwgb2YgdGhhdCBzaG91bGQgYmUgZml4YWJsZSBieToNCj4+ DQo+PiAtIG1vdmluZyB0aGUgZnVuY3Rpb24gbmVlZGVkIGJ5IFBBVCBmcm9tIE1UUlIgc3Bl Y2lmaWMgY29kZSBvbmUgbGV2ZWwNCj4+ICAgICB1cA0KPj4gLSBhZGRpbmcgYSBQQVQgaW5k aXJlY3Rpb24gbGF5ZXIgc3VwcG9ydGluZyB0aGUgMyBjYXNlcyAibm8gb3IgZGlzYWJsZWQN Cj4+ICAgICBQQVQiLCAiUEFUIHVuZGVyIGtlcm5lbCBjb250cm9sIiwgYW5kICJQQVQgdW5k ZXIgWGVuIGNvbnRyb2wiDQo+IA0KPiBJIGFtIG5vdCBzdXJlIHRoZSByaWdodCB3YXkgdG8g ZGl2aWRlIHRoZSBjYXNlcyBpcyAiUEFUIHVuZGVyDQo+IGtlcm5lbCBjb250cm9sIiBhbmQg IlBBVCB1bmRlciBYZW4gY29udHJvbC4iIEkgYWxzbyBsb29rZWQgYXQNCj4gdGhlIGNvZGUg aW4gdGhlIFhlbiBoeXBlcnZpc29yIGFuZCBpdCBkb2VzIGFsbG93IGZvciBEb20wDQo+IHRv IHVzZSBhIFhlbiBoeXBlcmNhbGwgcHJvdmlkZWQgYnkgdGhlIHhlbmN0cmwgbGlicmFyeSB0 byBlbmFibGUNCj4gUEFUIFdDIGNhY2hpbmcgbW9kZSwgYW5kIEkgcmFuIHNvbWUgdGVzdHMg Zm9yIGV2aWRlbmNlIHRoYXQNCg0KSSBndWVzcyB5b3UgbWVhbiBYRU5fRE1PUF9waW5fbWVt b3J5X2NhY2hlYXR0ci4gVGhpcyBpcyBtZWFudCB0bw0KYmUgdXNlZCBmb3IgZGV2aWNlIGVt dWxhdGlvbi4NCg0KPiBteSBYZW4gRG9tMCB3YXMgbWFraW5nIHN1Y2ggaHlwZXJjYWxscyB0 byBzdXBwb3J0IHRoZSBXQw0KPiBjYWNoaW5nIG1vZGUsIGJ1dCBJIGhhdmUgbm90IHlldCBi ZWVuIGFibGUgdG8gdmVyaWZ5IHRoYXQgdGhlDQo+IFdDIGNhY2hpbmcgbW9kZSBpcyBlbmFi bGVkIGJ5IGEgaHlwZXJjYWxsIGZyb20gRG9tMCB0byBYZW4sDQo+IGFsdGhvdWdoIGJ5IHJl YWRpbmcgdGhlIGNvZGUgaW4gdGhlIGh5cGVydmlzb3IgYW5kIHhlbmN0cmwgaXQNCj4gc2Vl bXMgdG8gYmUgcG9zc2libGUuIEkganVzdCBkb24ndCB0aGluayB0aGUgaTkxNSBMaW51eCBr ZXJuZWwNCj4gZHJpdmVyIHVzZXMgc3VjaCBoeXBlcmNhbGxzLCBhbmQgSSBhbSBub3Qgc3Vy ZSB0aGF0IG15IFhlbg0KPiBEb20wIGNvdWxkIGJlIHVzaW5nIHRoZSBmYXN0IFdDIGNhY2hp bmcgbW9kZSBiZWNhdXNlDQo+ICJQQVQgaXMgdW5kZXIgWGVuIGNvbnRyb2wiIGluc3RlYWQg b2YgInVuZGVyIGtlcm5lbCBjb250cm9sIg0KPiB1bmxlc3MgdGhlIGtlcm5lbCBpcyByZWx5 aW5nIG9uIFhlbiB0byBwcm92aWRlIFBBVCB2aWEgWGVuDQo+IGh5cGVyY2FsbHMuIFRoZSBz dWNjZXNzZnVsIGNhbGwgb2YgbXkgWGVuIERvbTAgdG8gcmRtc3JsDQoNClRoZSBQQVQgTVNS IGlzIHNldHVwIGJ5IHRoZSBoeXBlcnZpc29yIHRvIHN1cHBvcnQgYWxsIHBvc3NpYmxlDQpj YWNoaW5nIG1vZGVzLiBEb20wIGp1c3QgbmVlZHMgdG8gc2V0IHRoZSBjb3JyZWN0IGJpdHMg aW4gYQ0KcGFnZSB0YWJsZSBlbnRyeSB0byBzZWxlY3QgdGhlIHdhbnRlZCBjYWNoaW5nIG1v ZGUuDQoNClRoZSByZWFzb24gd2h5IHRoZXJlIGlzIG5vIGh5cGVyY2FsbCB0byBtb2RpZnkg dGhlIFBBVCBNU1IgaXMsDQp0aGF0IGl0IGlzIHJlcXVpcmVkIHRoYXQgdGhlIE1TUiBoYXMg dGhlIHNhbWUgdmFsdWUgYWNyb3NzIGFsbA0KY3B1cyBvbiB0aGUgc3lzdGVtLiBUaGlzIHBy ZWNsdWRlcyB0aGUgcG9zc2liaWxpdHkgdGhhdCBhbnkNCmd1ZXN0IGNvdWxkIGNoYW5nZSBp dCwgYXMgdGhpcyB3b3VsZCBjaGFuZ2UgaXQgZm9yIGFsbCBndWVzdHMuDQpUaGlzIGFsbCBp cyB0cnVlIG9ubHkgZm9yIFBWIGd1ZXN0cywgb2YgY291cnNlLCBhcyBIVk0gb3IgUFZIDQpn dWVzdHMgZ2V0IGEgdmlydHVhbGl6ZWQgUEFUIE1TUiB2aWEgdGhlIGhhcmR3YXJlIHZpcnR1 YWxpemF0aW9uDQpmZWF0dXJlLg0KDQo+IHdoaWNoIG9idGFpbmVkIGEgdmFsaWQgY29uZmln dXJhdGlvbiBvZiBQQVQgZm9yIHRoZSB2aXJ0dWFsDQo+IGJvb3QgQ1BVIGV4cG9zZWQgYnkg WGVuIHRvIHRoZSBrZXJuZWwgaW5kaWNhdGVzIGF0IGxlYXN0IHRoYXQNCj4gdGhlIGtlcm5l bCBjYW4gZGV0ZWN0LCBpZiBub3QgY29udHJvbCwgd2hhdCB0aGUgc3VwcG9ydGVkIFBBVA0K PiBjYWNoaW5nIG1vZGVzIGFyZS4gT2YgY291cnNlIHlvdSBhcmUgYWJzb2x1dGVseSBjb3Jy ZWN0IHRoYXQNCj4gdGhlIGtlcm5lbCBjYW5ub3QgZGlyZWN0bHkgY29udHJvbCB0aGUgUEFU IGNhY2hpbmcgbW9kZXMgaW4gdGhlDQo+IFhlbiBQViBlbnZpcm9ubWVudCwgYXQgbGVhc3Qg bm90IHdpdGhvdXQgcG9zc2libHkgcmVzb3J0aW5nIHRvDQo+IHNvbWUgWGVuIGh5cGVyY2Fs bHMgdGhhdCBhcmUgbW9zdCBsaWtlbHkgbm90IGN1cnJlbnRseSBpbiB1c2UNCj4gYnkgdGhl IGtlcm5lbC4NCg0KVGhlcmUgaXMgc3VjaCBoeXBlcmNhbGwuIFRoZSBoeXBlcmNhbGwgeW91 IGFyZSB0aGlua2luZyBvZiBpcw0Kb25seSBjaGFuZ2luZyB0aGUgY2FjaGluZyBtb2RlIGZv ciBhIHNwZWNpZmljIHNldCBvZiBwYWdlcyBieQ0KbW9kaWZ5aW5nIHRoZSByZWxhdGVkIEVQ VC9OUFQgZW50cmllcy4NCg0KPiBJIHdvdWxkIGhhdmUgdG8gZG8gbXVjaCBtb3JlIHRlc3Rp bmcgdG8gcmVhbGx5IGRldGVybWluZQ0KPiB3aGF0IGlzIGhhcHBlbmluZyBhbmQgaG93IG15 IFhlbiBEb20wIGlzIHJlYWxseQ0KPiBjb25maWd1cmluZyB0aGUgUEFUIGNhY2hpbmcgbW9k ZXMgYW5kIHNwZWNpZmljYWxseSwgaWYNCj4gaXQgaXMgYWN0dWFsbHkgdXNpbmcgdGhlIGZh c3QgV0MgY2FjaGluZyBtb2RlIGFzIHJlcXVlc3RlZA0KPiBieSB0aGUgaTkxNSBJbnRlbCBn cmFwaGljcyBkcml2ZXIuDQoNCkEgUFYgZG9tMCBjYW4gb25seSBhZGFwdCBpdHNlbGYgdG8g dGhlIFBBVCBzZXR0aW5nIHRoZSBYZW4NCmh5cGVydmlzb3IgaGFzIGRvbmUuDQoNCj4gDQo+ PiAtIHJlbW92aW5nIHRoZSBkZXBlbmRlbmN5IG9mIFBBVCBvbiBNVFJSDQo+Pg0KPj4gSSdk IGJlIHVwIGZvciB0cnlpbmcgdGhpcywgYnV0IHJpZ2h0IG5vdyBJIGhhdmVuJ3QgZ290IHRo ZSB0aW1lIHRvIGRvDQo+PiBpdC4gSSBtaWdodCBiZSBhYmxlIHRvIHN0YXJ0IHdvcmtpbmcg b24gdGhhdCBpbiBTZXB0ZW1iZXIuDQo+IA0KPiBQbGVhc2UgbGV0IG1lIGtub3cgaWYvd2hl biB5b3Ugc3RhcnQgb24gaXQsIEkgd291bGQgYmUgaW50ZXJlc3RlZA0KPiB0byB0cnkgb3V0 IHdoYXQgeW91IGNvbWUgdXAgd2l0aCBvbiBteSBYZW4gRG9tMC4NCg0KV2lsbCBkbyB0aGF0 Lg0KDQo+IA0KPj4NCj4+IE1lYW53aGlsZSBJIHRoaW5rIGVpdGhlciBKYW4ncyBwYXRjaCBv ciB0aGUgc2ltcGxlIG9uZSBvZiBDaHVjaw0KPj4gc2hvdWxkIGJlIGFwcGxpZWQuDQo+IA0K PiBJIGFncmVlLg0KDQpIYXBweSB0byBoZWFyIHRoYXQuIDotKQ0KDQoNCkp1ZXJnZW4NCg== --------------ZBVFmxhu7YV85S0jxSbESRaX Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------ZBVFmxhu7YV85S0jxSbESRaX-- --------------LNP0HlPGENkZfT2Jy80tGIeh-- --------------WB1PRtPTXCrE1BDOQ07lS05K Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB4BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLNC2UFAwAAAAAACgkQsN6d1ii/Ey9Y mgf4/lcB6KGRhOP3SXFtRNTXrEGbB5lHThaM6Qq+QgGzljlPnuyi9XS4bj/aZCtQqevHoyZiWjLZ VL+pp9vByBC8z+BqUYOQcQTCFA1GBvn7KypHdj/MfRL85OzEMVlvEGncQRIkt/t/VUP4gU2YAXuv Rv6HJz/Xbv2sc9Rm+UaxiBqIUp95P4FRCt8osGBUeUh/rRAYaYJZmcnUoCH9wYkCOy3qQkRGN0vi S5Ik/lx86JrG2VkwzTGV8ih4qHRWU1wv+iQ8IBn8XBUesUMVfvNyXaOKs5taZvRFmVFqNOrCfrub i0lBlmXR3CDycFKGe+ZCxUoBB4j1t7xVnTHnbToW =C2h7 -----END PGP SIGNATURE----- --------------WB1PRtPTXCrE1BDOQ07lS05K-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 06:04:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 06:04:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365475.595640 (Exim 4.92) (envelope-from ) id 1oB90u-0006es-Dh; Tue, 12 Jul 2022 06:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365475.595640; Tue, 12 Jul 2022 06:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB90u-0006el-Av; Tue, 12 Jul 2022 06:04:52 +0000 Received: by outflank-mailman (input) for mailman id 365475; Tue, 12 Jul 2022 06:04:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB90t-0006ef-7E for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 06:04:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60068.outbound.protection.outlook.com [40.107.6.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89b0216a-01a8-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 08:04:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4119.eurprd04.prod.outlook.com (2603:10a6:209:4e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 06:04:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 06:04:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89b0216a-01a8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I++Xyg6+BwPg5Tfe8YLy4t0HgdexwFFJEWPLEbf2TJm8a7OdHzdg4cleV1Pcp5pWsP83D/PIBQD+k0cPP7fnYPU3/CyfD1OxHtZ35gf5rI4JH8NuShPpcw0lGrHVa9nSkbwiLqRUzOaT/Ieg1a4ALoR9x7nHbPyANk/m3TM5KnVU+tyWE63x9DUdFQYKMOz0IyuFrKFx2JFGs6TbHkbMhiQErrvuXX/4i1gI9FkPUMi+5/qwSWZjJp8Gc3YQviPMLqCuQqvYSyNCFoEu6r3uJN9Qwyi7yiM2wJUc1DfJqzZamdbYO8fk375dpJZuwhEI+ywNU+VDiGHGHRK6b6khjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PL3iUGSj/s59UmAxr8hbUAo5ntSKbpo9xVkBUbU8SHc=; b=avMKQAWacWZiaVWhbf7OzztWi33KE/cv/m7gzE7mkFaJMPbcDsAWy3gLgtac00ZC4IzJDaYUw2pb9aKYEs47tqH8yXjM4XV0bdD9gTbz2vuhSN0u1ywgZTS+j4erA3NjhP+xNvzZrZ4vNcQZWWt2YVqU+kktI2EwFDuzGgZED+usUSWAEW+UO6lkICF2f4mn4lRk8vr+N/0GmfE/Zn7qdbhT07DdRJ4hl2zeCU2C3c7layHjqBQO0nYLHmWVLjKz/6SxYBWjB88xXLw5rqjuDRP06LJJZNrWhxOmcIpgckREAXYhobf45jAgh3t9loqfRTpqyk61pSI74CACgHbCsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PL3iUGSj/s59UmAxr8hbUAo5ntSKbpo9xVkBUbU8SHc=; b=Pder4MAL9fGA6u0+5fL1d3ODCOfeqHCRBkRO+holtB8tS0PlwjcjjoTUsbdd/btkUnVJJOoDdS++Yg5O7WUjvUM8ewhD5y0bPW8LN3NZ5CX1A6PdIIHJrFI3Tv5GDnT+gRA6xI6Mxz7TdXQJg7YfMa6bPsTiI+aZSmTJ997iy3Gbixbl5V5vZ98Jg+puxE+rqbexLB+1QvEoogjjcAzTtfMw+OMEovi47qS1Me/tccKwMm4Q3xbRDNZYkz0RpQboa/j2nGtvA70HfAE3yM+uikl/o2/gCgmI1sbJkSdO3acq7QhNZyCqLlkcRm24ZZR4y1ORaywoi+Etn/DxG3P2cQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> Date: Tue, 12 Jul 2022 08:04:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Chuck Zmudzinski Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Juergen Gross , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR04CA0057.eurprd04.prod.outlook.com (2603:10a6:20b:f0::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02286521-e32c-4bfd-bbce-08da63cc6cc4 X-MS-TrafficTypeDiagnostic: AM6PR04MB4119:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rLgObuDKR5FWru0xMTyLnFa7D2hTN1Ho2GhgoplxseAi0v6BGiWVgwzj26vA6Z22/19sbtc1XXDuJiEkoLupwTuG8RCTnPA3CBKU3OoA++dWBwX4Hss3DIF8FTnK2t80VrUl11PzHyu93dW4zanU1kZTYtjHkB43+BJtKHjE9kLSPdwWzWbgUp2d1mNHQpViANcC/+43YcOMbmcr1rS9/YvS+gtSCFU2JNHkM1Q7iDcEIHwAnw7k7IDDag4tLSTM6nACVsFsWQTvgX++eu5zC/VZtSsS+S3I2Y09YUgXhUXQYq7sDddneOcXh9M2iy/rtxKnT47nCoRm1GEmH1SB75Yk63CZDUP/Kwz7iWVut/e6sSShJVGVzwNzuWnuD0jtPCu9IBdu3hE6f/Uh/Gw/xMrZiaa+IR0+DS4G+B+tIIDOCMs+Pmppam8SYq8+pHK+2rlAo/Xe9E7S7K/4RrPkYEXKupLayGvXOduAPU4kVk4bFICShhwo/GJTrXvUbMj31jdrPQNPgRrx/DBIw0fY3DySpAvW2CDGgptxS59jWOfWqnkwHjOGoxLa21sLjz0xuBu1tkI5c+oU2ZpXv1WaB4r1hja4J+a9RpsBHLghR9lGuOEpoXdXdIBU1SmNyso/blvuLOuPp4fs/N6ha05reMdKZDAy7QbiR2sanaiF6j60xqHoM20fB4iRHAuDTIgI1BO4JrPGnlByLUp8cI26nq4rc66qAjdhbylOQ/uMUd6yf9iMGAi5CNMalaKmGs5fsjLyP+XkOYoCmpZW2Q5hPmbKN0eJQY+AVR9EfPnKnhKgYtfL6rOyCKP7zKOa8WjeqTOXDuDFWhO6NWEN9egQXlPW+fueaatSTeh1WLIrxBQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(366004)(376002)(136003)(36756003)(2616005)(31686004)(38100700002)(83380400001)(26005)(86362001)(6512007)(186003)(31696002)(6486002)(6916009)(2906002)(316002)(54906003)(41300700001)(478600001)(6506007)(53546011)(8936002)(5660300002)(8676002)(4326008)(66946007)(66476007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MmdsL3I1WkhNMFFkU2ZxS1FjSFQxcVp5eUlYcGVGR2JCOGJuemNZTDVIaFhQ?= =?utf-8?B?Q2lHcXRXa2lEeVRud3VoelpERWFaSmxuZGlTVzNYZHRuaTVGZWRGckx0QVgy?= =?utf-8?B?NnBWcFcvZVdMUTRxSVgvZDlaZXBiRjhxK1JlS0svRVNML21LKzZjTjZVTnFu?= =?utf-8?B?eVdEOGVnSXVQL054RkZOcjZXYzlKWlkzV0I5ZEdkQXRLUCsvVVlGS0tTdkpS?= =?utf-8?B?c3ZtR2pHUWE0cm5BeS85dlNlV1JiY1RXSTc0aWNzSjY4TW5CUXV3OHBZbHor?= =?utf-8?B?eDBZNlFNc0R6YzFJdGxPd3ZjdnNkaVVPbXd6TStJckREbzZsV3RoNUFOQ2Fr?= =?utf-8?B?akU5dVllUlltWGxyOEpGVjVQbmJhQ2RpWjN2L1Uyam9SdzFZK2gyai9TYUto?= =?utf-8?B?WHZpMmdFQ0NSTncvR051bmhNa1p2dWNWMXU2aDUyS1NZVlNKNHZzUU9kbWIr?= =?utf-8?B?YnQyNEtTb1A1YnZNRjByQzhMcEQxQ1dqNVZ5cEV6SUJOanNjMXluY1ByZG1Y?= =?utf-8?B?NzU0NFlKK3Awcm5aMjB0VnliR3FocUYvTEZRVUJyRzI5ZFNkSUtUTW5tQVNC?= =?utf-8?B?VmZvRC9DL2tHbHRhOUVXUmVXdzhYbGtobVVMcERtd0UvR25Yb1B1T090cXFk?= =?utf-8?B?M0dzVlgyQzErendhdUNINFh5cExaNlNQWjgzKzdLZS8rdG8vbHFzUlluVVdh?= =?utf-8?B?KzR4K2VZMVpyKzBjOUw2b3IyZWc0clNkVEZhd1JCVVdUMjRPWHhkdzdza3Rt?= =?utf-8?B?L3pJenIyMFFlZitXb1gydUJXZ0lsaERYaCtyb1N0OFNLQnBSZnBqY1JlWVJo?= =?utf-8?B?T3hkZXZxUlc1YmpvZzY1d2VRTGVIc1hLNEgxdDlTV3dQWGx6VFFxMHNQcXVh?= =?utf-8?B?QmJva1RMSXJvUGV2a3hkMmdVRDBabHVCaXY5Yi9pUGtwUHZZVURRcStxWUVP?= =?utf-8?B?OWEwUzhzUEhDclRFMlozNDZGUjB6S2ROMXJhMGlTVWJkWGJzSzFYY3RuTzc2?= =?utf-8?B?Qy85dVcxZUV0SWVMOE5MYWV5VkhORVBjbkN2blpCSUd0OUdyMXJxOFRoVVQ3?= =?utf-8?B?cDFxcVBNRUdsNEdpMjRtbTg4cE5neVVjNXB4bkNUNmlPb3AwVGRLMmE4OHBt?= =?utf-8?B?VUlmV2g3aEhUcXZ4Y1FEUmtyYlNRUDVGdU1YT0J5NWY3eEJmQ0J1QWp5TDNO?= =?utf-8?B?QTlJUE1FYXFUYTlFWGpEaXk5WFdZVFZUUTZVeG5USDFGanl3OTN1TDRndmdS?= =?utf-8?B?TkVkSlAyZGw4My9IdW4xd3EzQlJjdGdlaUNlUHg0TFZCYS9nbGJhZVk1ZTlm?= =?utf-8?B?em1xbHA2cURva0d4S3BDR0hOY3RUOUZ2T0ZYRkZ0Z3Z3RURtSk9pVnk2WFAx?= =?utf-8?B?R1MxWGk2Wk1MeTRmaWFiMUpoRzYwcTBhYjNHdFJ6Rm1VZ0lzbFJlVnN6MDBK?= =?utf-8?B?WEoyb3JkSTdWOUZUYVZsTjVNMVBpRWxxTGlRb0s1V0pYbnJNcUdhREcxb0VW?= =?utf-8?B?WjlXd0lnSE9zZ2JGdW5FaTZHZVdCRlNwdEFIbjkwYk90TWdLN2VQd1p1emhq?= =?utf-8?B?VTF1SzF0K1RZMnZlT1lLOTZqcDlDYXdEbnBiSnlJVFN1Sy95eGd0bUw2OFVo?= =?utf-8?B?K0RWRDVDZEYzQUJSeXlOc1FoQlRwMkUxZXdRRzh2azAzOFF3RG9xSEFCdDVR?= =?utf-8?B?V2Q2UU81Y3NRUkJQWXFFb3JXMHV6YXpyWVl4aXRKb2xDVnd5bFZqbjltZzFJ?= =?utf-8?B?NXJOLzN5TUtNZ1JlWWI1eCtnZi9KSFpuS1hMMC9EK1NnNTFTdWRCYkE3V210?= =?utf-8?B?WW45Ti9XeFJyc213MzhvenZUZDZORmtjNkNQTVNsdVVsbHhDbXR1bXpsaGxr?= =?utf-8?B?L3VNYmVXQWMzODVOSm5NcnpSa0MvbjYya2NGSFIvUzE5T1h0Qkl1TUJpcVRV?= =?utf-8?B?UmN6Zk9LSWlaV0tGSHNYaUFYblhRbWZpZU9lWTNnbjdON2FodEpoNkdEV3R3?= =?utf-8?B?QjFZdTVlN2FYejB6eXBNV29LYnNoYlJRYmNzU242WmNZZGUwL25OeERlV29T?= =?utf-8?B?d0d3cGVqUlJIQzNiVGhwTnc3VVN6ZE9mUEJwRm9mckJnUG0rd0RVaTN5alBU?= =?utf-8?Q?Wu6LPl5I/qf7ly6OV211GuCv1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02286521-e32c-4bfd-bbce-08da63cc6cc4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 06:04:47.7532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BIQAQcdZOXTDYTHyW9CW4Dc1c7FgAIl4oMbfWayZxdhmAJ2vwUXfh0e04meSaSxF/eMs3Rywq21vHQorQm9ukA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4119 On 11.07.2022 19:41, Chuck Zmudzinski wrote: > Moreover... (please move to the bottom of the code snippet > for more information about my tests in the Xen PV environment...) > > void init_cache_modes(void) > { >     u64 pat = 0; > >     if (pat_cm_initialized) >         return; > >     if (boot_cpu_has(X86_FEATURE_PAT)) { >         /* >          * CPU supports PAT. Set PAT table to be consistent with >          * PAT MSR. This case supports "nopat" boot option, and >          * virtual machine environments which support PAT without >          * MTRRs. In specific, Xen has unique setup to PAT MSR. >          * >          * If PAT MSR returns 0, it is considered invalid and emulates >          * as No PAT. >          */ >         rdmsrl(MSR_IA32_CR_PAT, pat); >     } > >     if (!pat) { >         /* >          * No PAT. Emulate the PAT table that corresponds to the two >          * cache bits, PWT (Write Through) and PCD (Cache Disable). >          * This setup is also the same as the BIOS default setup. >          * >          * PTE encoding: >          * >          *       PCD >          *       |PWT  PAT >          *       ||    slot >          *       00    0    WB : _PAGE_CACHE_MODE_WB >          *       01    1    WT : _PAGE_CACHE_MODE_WT >          *       10    2    UC-: _PAGE_CACHE_MODE_UC_MINUS >          *       11    3    UC : _PAGE_CACHE_MODE_UC >          * >          * NOTE: When WC or WP is used, it is redirected to UC- per >          * the default setup in __cachemode2pte_tbl[]. >          */ >         pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | >               PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); >     } > >     else if (!pat_bp_enabled) { >         /* >          * In some environments, specifically Xen PV, PAT >          * initialization is skipped because MTRRs are >          * disabled even though PAT is available. In such >          * environments, set PAT to initialized and enabled to >          * correctly indicate to callers of pat_enabled() that >          * PAT is available and prevent PAT from being disabled. >          */ >         pat_bp_enabled = true; >         pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); >     } > >     __init_cache_modes(pat); > } > > This function, patched with the extra 'else if' block, fixes the > regression on my Xen worksatation, and the pr_info message > "x86/PAT: PAT enabled by init_cache_modes" appears in the logs > when running this patched kernel in my Xen Dom0. This means > that in the Xen PV environment on my Xen Dom0 workstation, > rdmsrl(MSR_IA32_CR_PAT, pat) successfully tested for the presence > of PAT on the virtual CPU that Xen exposed to the Linux kernel on my > Xen Dom0 workstation. At least that is what I think my tests prove. > > So why is this not a valid way to test for the existence of > PAT in the Xen PV environment? Are the existing comments > in init_cache_modes() about supporting both the case when > the "nopat" boot option is set and the specific case of Xen and > MTRR disabled wrong? My testing confirms those comments are > correct. At the very least this ignores the possible "nopat" an admin may have passed to the kernel. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 06:18:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 06:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365481.595651 (Exim 4.92) (envelope-from ) id 1oB9EA-0008PN-Ki; Tue, 12 Jul 2022 06:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365481.595651; Tue, 12 Jul 2022 06:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9EA-0008PG-Hl; Tue, 12 Jul 2022 06:18:34 +0000 Received: by outflank-mailman (input) for mailman id 365481; Tue, 12 Jul 2022 06:18:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9E9-0008PA-H1 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 06:18:33 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73ec27f5-01aa-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 08:18:32 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A21B4223FD; Tue, 12 Jul 2022 06:18:31 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7981A13A94; Tue, 12 Jul 2022 06:18:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id w2RIHDcSzWL7dQAAMHmgww (envelope-from ); Tue, 12 Jul 2022 06:18:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73ec27f5-01aa-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657606711; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=etVadWMEcaCmHQolsuZnIQPLKMBgj6AO3enT5B9eJ14=; b=SV9AxBqjGnW7jPyyRN2MIPBldiftwFiA8LPhlTIS6S8WeywkFTOT5WSGOMV/j8tUriDXXK UgHOosw1XJRCKiFerjjFLiHPLnFXzyHFvzCthgGo7e4TMSEei+ktD63+BxLqu3kPxGOV0T 1FewGqHWxqnOf9iOw/12vIjm/UHSu5Q= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH v2] tools/init-xenstore-domain: fix memory map for PVH stubdom Date: Tue, 12 Jul 2022 08:18:30 +0200 Message-Id: <20220712061830.20208-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In case of maxmem != memsize the E820 map of the PVH stubdom is wrong, as it is missing the RAM above memsize. Additionally the memory map should only specify the Xen special pages as reserved. Signed-off-by: Juergen Gross --- V2: - don't change mmio area settings (Anthony Perard) --- tools/helpers/init-xenstore-domain.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/helpers/init-xenstore-domain.c b/tools/helpers/init-xenstore-domain.c index b4f3c65a8a..2d9ab6f1c5 100644 --- a/tools/helpers/init-xenstore-domain.c +++ b/tools/helpers/init-xenstore-domain.c @@ -71,8 +71,9 @@ static int build(xc_interface *xch) char cmdline[512]; int rv, xs_fd; struct xc_dom_image *dom = NULL; - int limit_kb = (maxmem ? : (memory + 1)) * 1024; + int limit_kb = (maxmem ? : memory) * 1024 + X86_HVM_NR_SPECIAL_PAGES * 4; uint64_t mem_size = MB(memory); + uint64_t max_size = MB(maxmem ? : memory); struct e820entry e820[3]; struct xen_domctl_createdomain config = { .ssidref = SECINITSID_DOMU, @@ -165,13 +166,16 @@ static int build(xc_interface *xch) dom->mmio_start = LAPIC_BASE_ADDRESS; dom->max_vcpus = 1; e820[0].addr = 0; - e820[0].size = dom->lowmem_end; + e820[0].size = (max_size > LAPIC_BASE_ADDRESS) ? + LAPIC_BASE_ADDRESS : max_size; e820[0].type = E820_RAM; - e820[1].addr = LAPIC_BASE_ADDRESS; - e820[1].size = dom->mmio_size; + e820[1].addr = (X86_HVM_END_SPECIAL_REGION - + X86_HVM_NR_SPECIAL_PAGES) << XC_PAGE_SHIFT; + e820[1].size = X86_HVM_NR_SPECIAL_PAGES << XC_PAGE_SHIFT; e820[1].type = E820_RESERVED; e820[2].addr = GB(4); - e820[2].size = dom->highmem_end - GB(4); + e820[2].size = (max_size > LAPIC_BASE_ADDRESS) ? + max_size - LAPIC_BASE_ADDRESS : 0; e820[2].type = E820_RAM; } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Jul 12 06:27:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 06:27:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365488.595662 (Exim 4.92) (envelope-from ) id 1oB9Ml-0001ZB-Fi; Tue, 12 Jul 2022 06:27:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365488.595662; Tue, 12 Jul 2022 06:27:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9Ml-0001Z4-CF; Tue, 12 Jul 2022 06:27:27 +0000 Received: by outflank-mailman (input) for mailman id 365488; Tue, 12 Jul 2022 06:27:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9Mk-0001Yy-9b for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 06:27:26 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20081.outbound.protection.outlook.com [40.107.2.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b15d4cc2-01ab-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 08:27:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB2998.eurprd04.prod.outlook.com (2603:10a6:6:4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Tue, 12 Jul 2022 06:27:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 06:27:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b15d4cc2-01ab-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YC1D6UDHyGPHANCMl8UiXTwjHP+OvdlaKXhq52fJVWACfzGzUEEnZfLakBaoXMoA5JZs/+HFDBQjsZTAC0pNOqT0VV98ueKADfD9l1vvVd2We0IXbVWyy4A+b6xHg3rVabL8NKeapQIuqWpTchUrOHo7YWo5sdb43KuSxqO6I389qyqjImEWOO2w5SUUPQb1y4VNYaqpGqY7TRzte1QpmXX/BpVAQ5GbcgX7XB5cU4SoWCXI8d0GZXdf73V561TwNmSEQACCBuOgkz5RIAIsCHeIjkkAtExuteQdv+B4X/kigN7J69fAWvsKb3RNwHEWLe/4fBhlp9VHmICmlEDYMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YTM6Yuci/8dO9XMPQ/YUVd5RdN14qjz3f39xN0tMDxM=; b=A2rf6rp2Oc2BkmrlDmy1YHb8mznM/jKLkzD+lAjm6cw+nkGkhIt+2eSO+QZxQuMrpKnOsDfKzn63yfdzVh0fH0niWdYFK884QnS+LrJflbMxtIyDE6aRv3MGXSdfanrQvrrdWYqc6Jvhe5yy3h8ik1gM4ruU6aV3AYDaFyZEXdoDE9TqpdiV7u/rsO5oKbu7Mw+nSk872o0Y8OuPVX3oKqV5LVaZWjrnxGkDIF8G6OuvmnqZ/zIof/FIEaF3IUVxQe1e+/mDeccmTN/XTRRxI4BUlI1h5z4YdDJVJsBesfnKrdyxtlQlktZsanLG4BuAt8LPkjho6yC/SifotPRnVw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YTM6Yuci/8dO9XMPQ/YUVd5RdN14qjz3f39xN0tMDxM=; b=vMVFTagueTK0EBkVL/oIZWRrwB7sEnJPTFOdaMPmIvP8hQ/XvH2N3rI7iixp4ruVk6m/HL19wcOPzRd2yloN2u/V9Hs6mJO97SGa0PD/IknzD+EhCbQIPPlnyGV+35UwRVxlgYAg/TnyBsRUW/vTe1cF2zSJ+RnCtH7856SEsRZqhhfQ16DxToC/BlA1rvkaFmtzuriHQedroM+a8NrG4gB4HcayHujLwHmpHYDc6iYlX+r9VOQREX3Z8hHmP4YGtFp/BJEL54Qbbt7DS2xImSOMiYhosErEYR9fn7Paty2xyZR104VykN9GtX0rXKNgJR/N1qe6fFW3SNzyFsGm0w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <46b6f5fb-92d6-336d-fe92-ba28a4ef5add@suse.com> Date: Tue, 12 Jul 2022 08:27:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v10] Preserve the EFI System Resource Table for dom0 Content-Language: en-US To: Demi Marie Obenour Cc: Luca Fancellu , Xen developer discussion References: <5090ce79650583050b2245ee02d8987e65667c23.1657580511.git.demi@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <5090ce79650583050b2245ee02d8987e65667c23.1657580511.git.demi@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cbc9652d-c7a6-43e8-5bbe-08da63cf9406 X-MS-TrafficTypeDiagnostic: DB6PR04MB2998:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L8v7l5dDJHsvIxyxAZ+tiX/ZtOjGxgX9rJuO6Fk8zBtsAVMHJacNzHs6+9BfhLbeO8k9daVTrgl2WlylXQw+DGUQlHUgiqllJeSN/7YtuGa+HBeR1xJ2wOhn18XsaWhSK1smCa/l36nJvU/GJ/3wCYpK3scuLjy2SrKdKH8Hz12M6iyiTT5qik2jDqV96fluErlG/Jc+ej52+18h17xAJn9KDnkB93jc4X6cFJ5323W26Tudm1ehfyFY7CThPRFmR0s8Mpm7P55Tz/nyte2b+nvVeHjZ9hrkL4IE+VriMOTZuTapPoC5zKYDSpea3zBW1KVIAm/Q3LGT8fRXT2ybc1dcK6PEG3vfgOQxy1gLcgEFwF2PFlnQHXbNkAVL4b+in9GOzJ57/0WqlhKZWNGadedSjTkBamJYb2Ptlx0q5B4+WCL8JWQXqNmrkDh48WDZ/ajLb2qo1Q6N0njwwKBOKCpqE6MLfcKsHs66CWe/Z1w1PKED1pW11Wz4psm8FWhEKA0ig2HUEz/5/XprLLpuwxPoqgpvXiYnGPRNxGDAUYSFmDtBOt0d89SbkE1srKckuvT0uckWnqErqChgDpRH/pJ33YSBLYL/LxJmkeH6mpXhmO2f8uWWkfMy/0n5nQzTvf8mPsWvB1UsN2XUBiHqqi7xLc+kAafBOcwfUHKWSSd/s0WoIYNgyZYN5tdFyZXA8ECoy9nD+1UPeIxR2vTS6XLkuyOQUD+inUto1upB3Pgf6Opb7NjzcUImkRaRa0tgxeK+YnrE+PFRePJWceD55ntaK42W7P1zXaeOfynxNFHeg4L1B35vQJh2+EzQPmIr/jy3r46mGfuhE6kVGs8ft6C/fTMeP+x66HcPKzUOoxFRUduliG1fxY0isuCWMQNR X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(396003)(376002)(346002)(136003)(66476007)(4326008)(53546011)(66946007)(8676002)(6512007)(86362001)(478600001)(5660300002)(26005)(8936002)(31696002)(66556008)(41300700001)(2616005)(54906003)(316002)(6916009)(38100700002)(966005)(2906002)(31686004)(83380400001)(6506007)(186003)(36756003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1E4WS9VTEE4OEJDWFUxd3N4d0E1elhVQjJtenpLV2NCdDY0c1pUNGpqMk1N?= =?utf-8?B?RkNQUWlDZHoxSW1nczhWRTUxVHpUL2tVdHM3TjhlNDV3b05KRkxvQXNjQXoz?= =?utf-8?B?MDg2ZlNoZHVHdGNzWXpqN2FFTTJwQjg1UGJ6YWNkRkhuTU5FTXVRUjkwVk5V?= =?utf-8?B?WEExbGpQSG9hRkx2Ukg2Z0tZeGkwem5ueHVidGdTOXBlTEZ6ai9GanY3NGtL?= =?utf-8?B?TllSUHVIcytmUXdqbmlUWkkyS3V1RHVuQmVOOFhiVnUzczZodnl4R0swV3NI?= =?utf-8?B?U2ZsbGxUUXlpTCtHV25nRHRNYmlZc0h5Qi9iQWxZYVVzNlBYVE10MmNsa2RS?= =?utf-8?B?dUVqZFFndFlWQy9lOStaRW50bmhBNEJxUzhUT1hDM2x6NjVWamtuSmVyRlEw?= =?utf-8?B?YXltbkJLR3dacDBOYm94REJHYUFnT3k2ci9zeDU1Zmc3RXVpVThWMGNhNWtm?= =?utf-8?B?bGNMVldLQm5rR3YzQUpFa1cyZW5LWlFYSUdrbnVoT3FxWG9ZSHRta1YrZkJu?= =?utf-8?B?RjJ6anZ1dTQzZVVyTXkwNzg0OWlCWUZ6ZnkyeUlNTWdhUVpzdnV1QXd2RnVO?= =?utf-8?B?T3lLQlltN0dZNmFDckdvdGNLZC81cnE5N2NWMzMzY0RCZTFzNm05QkNxd0Nh?= =?utf-8?B?Njh3c0V0enI4SS9KN3FlNFc5R0xheG4vdlk0OEdXUlZTNHQxdmU3Y1ZIeFRH?= =?utf-8?B?ZUJYS2dtNy9OaHUyVDUrTmhiL0xNZjkxL0dnTjBwZXBxZitPdHhBY2F4eS9W?= =?utf-8?B?TlN0WVN6eFhPcVlhL3hSZ21jQlR1aEhCKy9QMkNoUkkzdTNISTZIZEJFVzR2?= =?utf-8?B?RjJKL1FyWWVQcWhpa0pObGlreHBSUkNhS05vRlZLUlV0L3BNUjlLcksyc0hM?= =?utf-8?B?eFY5RWM1VUZoeFdOaHZqb1pLKzF4UVh5NzliNG1FUzhYaGp0SUR2L1Ewd2lM?= =?utf-8?B?cWZocHAxQXBhOCtlSmxTWk05RmJIUkNoSGV1c3V2UGFjOTRncy9VTHdsY1pE?= =?utf-8?B?b3VFR3l3dHVKNSt1R3hLL1N4MUFwMzAwZ0kwcTl2RHZzYW1zZXM0S2ZrYXha?= =?utf-8?B?SndPZUh5bm9obkd2YUplT1E1bmJTL3JOUG1Demd1dTFPajVTTk52cXNlMXZC?= =?utf-8?B?ekVWK0xIRU5Lcy9hbld2VktldFdkRmx5KzZnM1U5RExiTjZFU1FuVTk4TlFU?= =?utf-8?B?WG5WdVRPSURaRllSbnFZeHpjeFY0QXpoV2dtTWNPNk1rc3JVbG51TzVycGJJ?= =?utf-8?B?ZlphUklEVDJ1SU10dURiUWdYbGgvcTRyUG1nNTJ1YjBSSVI2M0htOFVtTnhI?= =?utf-8?B?bUdEM3gyNG9vcHFpbkxDZElOalV3YmFoMEVoS3JnM2l3N1R3THhHbEJpOVl0?= =?utf-8?B?dUF4YmxsS1VpQmpaWTVpUEY0NExMbVd1V0IxNDdSY2ROSWd0WmVuVEprZEhl?= =?utf-8?B?cVdwWE5MNEJqUTkxNUl3UVFZaVp5ZFNxcHZid0prMDQ2c2xtUHJxb0UwTmxn?= =?utf-8?B?VGlEem85QU5SczdqWnBEbEk4UkhhampUbWcwc3J4TktyUEJZQzh0SFY1cTNI?= =?utf-8?B?OEdwTC9ac2hCSmNCeVdzRjgrQlRjWGIrMXFKTnFWZzN6eFFic3BPbmlOQllL?= =?utf-8?B?V3NzWXRRbGRtdktNUzd6d0FoeVdzMWxSTXJYOVBOcExZbGlmS0l4RmZJcUs1?= =?utf-8?B?VU1oQUFLcFBmNFUza3NIektWbE16QmJpMDNBWU5RVXcwOEJmT0lVQ3AwK0tx?= =?utf-8?B?eUpGcEFiam4zNmJQTkdyVWdEaVhnOFZZL0tJc1dHZm5hWmFnNlJHSThseEQ4?= =?utf-8?B?VGVrc0UzdndOOG1LVm94NSs3RzFnblU2RjlDNzMrRXg4eW8ybXpzSTJZamFH?= =?utf-8?B?NXpidk9ObjZsVVJnb3UxVk1ibEExOEJSQVdIOWlma0I1UnR3VTZnOWtNRW9T?= =?utf-8?B?T2Jqd1ErbGU5Tm1zRnU4VnBmeC9Rd1JCc1VWZlFzcUFOajZLbzhndWp5VHEr?= =?utf-8?B?OGprd3pIWnljZlhWMmFxcytlOW56WEVLNDBOVUUxdnBpZ3ZDTERKZE12T2Vx?= =?utf-8?B?cVVXVWZuVDZVb3FQSElYOUNLcTNkOTZzQUttRU9XdjQ4TUR1cXhYVmg2Wi9P?= =?utf-8?Q?yEsODoIMJH0fXF9saFebRTxGt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cbc9652d-c7a6-43e8-5bbe-08da63cf9406 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 06:27:22.0264 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ciqk720FzWtiIzP8CEki46Z4m8DOlI/0G9d72OTNJhSGmvzs4SGdatoXHog8b3fdvE5V3CxK+ErB9KcTB0Cvcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2998 On 12.07.2022 01:14, Demi Marie Obenour wrote: > The EFI System Resource Table (ESRT) is necessary for fwupd to identify > firmware updates to install. According to the UEFI specification §23.4, > the ESRT shall be stored in memory of type EfiBootServicesData. However, > memory of type EfiBootServicesData is considered general-purpose memory > by Xen, so the ESRT needs to be moved somewhere where Xen will not > overwrite it. Copy the ESRT to memory of type EfiRuntimeServicesData, > which Xen will not reuse. dom0 can use the ESRT if (and only if) it is > in memory of type EfiRuntimeServicesData. > > Earlier versions of this patch reserved the memory in which the ESRT was > located. This created awkward alignment problems, and required either > splitting the E820 table or wasting memory. It also would have required > a new platform op for dom0 to use to indicate if the ESRT is reserved. > By copying the ESRT into EfiRuntimeServicesData memory, the E820 table > does not need to be modified, and dom0 can just check the type of the > memory region containing the ESRT. The copy is only done if the ESRT is > not already in EfiRuntimeServicesData memory, avoiding memory leaks on > repeated kexec. > > See https://lore.kernel.org/xen-devel/20200818184018.GN1679@mail-itl/T/ > for details. > > Signed-off-by: Demi Marie Obenour > Tested-by: Luca Fancellu Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 12 06:46:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 06:46:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365499.595689 (Exim 4.92) (envelope-from ) id 1oB9fO-0004LS-8D; Tue, 12 Jul 2022 06:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365499.595689; Tue, 12 Jul 2022 06:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9fO-0004LL-5b; Tue, 12 Jul 2022 06:46:42 +0000 Received: by outflank-mailman (input) for mailman id 365499; Tue, 12 Jul 2022 06:46:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9fM-0004LF-Tf for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 06:46:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 61e8413e-01ae-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 08:46:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5C1FB21FFF; Tue, 12 Jul 2022 06:46:39 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2FF6813A94; Tue, 12 Jul 2022 06:46:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id d/p8Cs8YzWIzAQAAMHmgww (envelope-from ); Tue, 12 Jul 2022 06:46:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 61e8413e-01ae-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657608399; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6llmww4ReNfnv3TctnPNAp5VowplEtyGScA5o5Kuix4=; b=P+Wsb10ZnqXlETzoeOz1lndqv33SGyoRL0PLO6rDqia6XrHcTeTR28zPHOhwBvuGMDfPbG EDTleFUHBM63v72/Zn505zLHaaD8GilWQV6dxHXmGW3t4NIin54NX4lZXdcAHwR34oiKgA jJx5s7k2h78ocaZ7/6MrC8CRbuIE5XY= Message-ID: Date: Tue, 12 Jul 2022 08:46:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE Content-Language: en-US To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220710230522.1563-1-demi@invisiblethingslab.com> From: Juergen Gross In-Reply-To: <20220710230522.1563-1-demi@invisiblethingslab.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------wifTR62gzPVUhQi2UogD5woE" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------wifTR62gzPVUhQi2UogD5woE Content-Type: multipart/mixed; boundary="------------kfkGZI8k0UwMZ3vwC43xvL7H"; protected-headers="v1" From: Juergen Gross To: Demi Marie Obenour , Stefano Stabellini , Oleksandr Tyshchenko Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: Subject: Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE References: <20220710230522.1563-1-demi@invisiblethingslab.com> In-Reply-To: <20220710230522.1563-1-demi@invisiblethingslab.com> --------------kfkGZI8k0UwMZ3vwC43xvL7H Content-Type: multipart/mixed; boundary="------------JEyKwfzYNs6fvV87d2Sbxhbx" --------------JEyKwfzYNs6fvV87d2Sbxhbx Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTEuMDcuMjIgMDE6MDUsIERlbWkgTWFyaWUgT2Jlbm91ciB3cm90ZToNCj4gVGhlIGVy cm9yIHBhdGhzIG9mIGdudGRldl9tbWFwKCkgY2FuIGNhbGwgdW5tYXBfZ3JhbnRfcGFnZXMo KSBldmVuDQo+IHRob3VnaCBub3QgYWxsIG9mIHRoZSBwYWdlcyBoYXZlIGJlZW4gc3VjY2Vz c2Z1bGx5IG1hcHBlZC4gIFRoaXMgd2lsbA0KPiB0cmlnZ2VyIHRoZSBXQVJOX09OKClzIGlu IF9fdW5tYXBfZ3JhbnRfcGFnZXNfZG9uZSgpLiAgVGhlIG51bWJlciBvZg0KPiB3YXJuaW5n cyBjYW4gYmUgdmVyeSBsYXJnZTsgSSBoYXZlIG9ic2VydmVkIHRob3VzYW5kcyBvZiBsaW5l cyBvZg0KPiB3YXJuaW5ncyBpbiB0aGUgc3lzdGVtZCBqb3VybmFsLg0KPiANCj4gQXZvaWQg dGhpcyBwcm9ibGVtIGJ5IG9ubHkgd2FybmluZyBvbiB1bm1hcHBpbmcgZmFpbHVyZSBpZiB0 aGUgaGFuZGxlDQo+IGJlaW5nIHVubWFwcGVkIGlzIG5vdCBJTlZBTElEX0dSQU5UX0hBTkRM RS4gIFRoZSBoYW5kbGUgZmllbGQgb2YgYW55DQo+IHBhZ2UgdGhhdCB3YXMgbm90IHN1Y2Nl c3NmdWxseSBtYXBwZWQgd2lsbCBiZSBJTlZBTElEX0dSQU5UX0hBTkRMRSwgc28NCj4gdGhp cyBjYXRjaGVzIGFsbCBjYXNlcyB3aGVyZSB1bm1hcHBpbmcgY2FuIGxlZ2l0aW1hdGVseSBm YWlsLg0KPiANCj4gU3VnZ2VzdGVkLWJ5OiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5j b20+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IERl bWkgTWFyaWUgT2Jlbm91ciA8ZGVtaUBpbnZpc2libGV0aGluZ3NsYWIuY29tPg0KPiBGaXhl czogZGJlOTdjZmY3ZGQ5ICgieGVuL2dudGRldjogQXZvaWQgYmxvY2tpbmcgaW4gdW5tYXBf Z3JhbnRfcGFnZXMoKSIpDQoNClB1c2hlZCB0byB4ZW4vdGlwLmdpdCBmb3ItbGludXMtNS4x OWENCg0KDQpKdWVyZ2VuDQo= --------------JEyKwfzYNs6fvV87d2Sbxhbx Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------JEyKwfzYNs6fvV87d2Sbxhbx-- --------------kfkGZI8k0UwMZ3vwC43xvL7H-- --------------wifTR62gzPVUhQi2UogD5woE Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLNGM4FAwAAAAAACgkQsN6d1ii/Ey/9 awgAjPkSH4ydXd8sKoSaXVtvu2fheMlVekQO0C1FDPNv6jWjcwDcRW1f3J6eVmn+rgjqKMpG6X9e UvlI0Oa2WXl/QVL8VXgALpvGN+EZeC3IHQwKcDoHFRyu+dff9wR7SkSNJ1U45sMGg1iXqfxIzFXw 4nTQcU8CoRK5okI8pPHmzmYIQixrikHPFPIZanI7dtH8aIoGHegUMkB4CQ7T4/RDomaKhJ+HxRdB Ee0poL4AYWDT/Mqj/CnB/HUyPjhXxy6RDV21bcA0Z443z4qzZl2VCZmZ0DLJnsjhKadmF1N2vP91 5VSwaHzlojO0bsnij0D0w9pxMc2lIZtNLu1W1UeL8Q== =4Fpt -----END PGP SIGNATURE----- --------------wifTR62gzPVUhQi2UogD5woE-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 07:02:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 07:02:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365506.595700 (Exim 4.92) (envelope-from ) id 1oB9u8-0006rk-QK; Tue, 12 Jul 2022 07:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365506.595700; Tue, 12 Jul 2022 07:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9u8-0006rd-NP; Tue, 12 Jul 2022 07:01:56 +0000 Received: by outflank-mailman (input) for mailman id 365506; Tue, 12 Jul 2022 07:01:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oB9u7-0006rX-Ct for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 07:01:55 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60069.outbound.protection.outlook.com [40.107.6.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8258c6fd-01b0-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 09:01:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9564.eurprd04.prod.outlook.com (2603:10a6:10:316::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 07:01:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 07:01:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8258c6fd-01b0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GfN4CAKOARs90oSxDV8MgnWsv2Q7CzAZ6OOiw+OXVgpCEtdrW29vuBy60Otvsi4W4v9wr23TBgbmZolfK5LWUa4BNK7mVob8kCWWFfYu8mvMIogcg8VzE4zkeOM1LYzjuADZdZBt/IjmFV0isSSxYF8niu9IZmy+0oRUY7TyEH8VC2YiSVoyXZnyzo2h8AYWJ3Kq+M775uP4YfOcsVHwfXHuaAQ2wLv1Q/Qbt15UfR3UN/k5fLLgNVbJV8W3PO7Fl81ahTX1Gd6sl/AZgIBxCST7LmZOkZ6QB6Fzbi3DOUBJ4WMCRQgXzpHjA+pQrlSFAgGrLSJgsEGY4nHJvGGfMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CbCJuwscgh3wdpQ0BtHFHbXJt0mR/kDzS6u9A7szgQw=; b=kSpospmGtZfbPxfdEh30zIBZL8j9Maj+6MIazFNqRt0v0FBBcC5VD2O5EmGSCkLgS93NOvRHDtIqMSBN0N7DSjOgaPEHSJNbYBAt3eK4kbPO21JuRCJ50EewuQl9y9IG1/xgUn2SxsUQ+vA6NvpvVxT3Ihv0wTnsFSx8SUiiG+HQyX6hfEZtQMHHz7iVjW9T+2kV6V3cFwjbBuowbhnhHpvkgThI1a34DxeyZNyFkvYGgTDloqxrLi+J9KLBPZgkaydtfllKFpoNv0yfjrIRtqyd2PlzalafbaFTQcM8qkyb5c8JH77CxhDoAP62akKVGFKhJ8/DOV+ESiEt50OxwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CbCJuwscgh3wdpQ0BtHFHbXJt0mR/kDzS6u9A7szgQw=; b=GzocPFqMUrdnD98GtmcaQNTMeFXvubaDdyReF8M+/RUV0jL+YJdyaCmyBeVeyUlOiXuTNtjNsogEl08PvMsbVw6os5j02APkyZ5m3EkS0oq7iAbJAKGeQqejoguHSVTfSvkBNUIWG2c0QqBONVMC1Ir63eUZ9/fy5C8UG9bBKEg1WRKxfjIuipyUWRxEOH3VyyLYMb64zELiQaUt48/YowGQQXQKqljZTy8cFjphJKYP3tMcxGSO893LuBO48XBlE7PSARDqLARsVH91AwVr4yL9yiqutUeYSgDS3m/PevdYOFDlSCDiDIFwbwsngn5y/o6f+1vIRV+bZlcmvyIgJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2b06e97e-1c39-9889-8d04-f1a063b403d6@suse.com> Date: Tue, 12 Jul 2022 09:01:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xl: relax freemem()'s retry calculation Content-Language: en-US To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Wei Liu References: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1971894a-47a3-4c6d-f98b-08da63d46519 X-MS-TrafficTypeDiagnostic: DU0PR04MB9564:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VJ5HDq9YzLR3K5I2pfBgOxieC9BOwJShfrWZimMRdUgMGtggaIt4h6Co6wpvNkpdYhkJWj2mNTadDTeDxScIaCaBWZRCQJN2F3o/l2W6DIhhdwptOJFLy+O7pHENUyHHoQLArlibvUx0XdO2dgVu/76ak11qOvHYnpzoaiI9VxPBF/J+Mn7fkPRrsi0LwJpM0Ow6R8C1FpiLC5lzGnIppxs+o5B9JecW06gOKNdHG96KuD7Lmvya/BPD4LUf/f2YN+QjrhzNokEIXsV/rCjqY0v8U52QP2N9nq6tQy+g/Nj5KpgNAgNf8h6Pd7J2Vx+MDCHUgk6T8pUw1eUebbpHhNPJyszOZVmYlSUFbbb1L7C+a3nSwzzGDYI1Dwx9d7QUlKAH/w6H9hpYg/FTenxgGwGL7CbN/y/s3swBzEDxyRpgkeEZduprnBHH3JYEtDyERyl06vSXuFAdhiEifMjjhIwET0kuccmDnGEUbXeN9S15h49voXU/m5lLk78OBrfc7oHmK5B+veZSyX2jk03QQ+rr20SRIAegG6zbZ+//BOOlsEIT49SEd5U/+QFuuk9PDNjsi+xE0/Wy9t6rrUITkhKsDFVlSQLXvv/Ldl9coyVFZc3UBMToFWzwZLP/EaHBAg+U06Ms1G2ybJSy6A0mVCNCpBnLHNpHkl5K7xQByfAvyHF/1PYTTbrX2bboaycRaptGwGO0zT+8fYGa/Pt3bKapKAW0313qbMVEVar1hZMwomyxKFflCiegrO3tXvSvok99bfeNrvVnoBjdFwoQN7ULV8+jyjEbWgIGkxUMnpDEdd0FKiCV9Dkt4lQvdoQhwaSaR9Kqa73F5XU7rbBgSRDSC2bkdbL+k5ZybOmFicQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(39860400002)(346002)(376002)(366004)(38100700002)(478600001)(6486002)(53546011)(86362001)(26005)(31696002)(31686004)(36756003)(6506007)(66556008)(6916009)(4326008)(66946007)(2616005)(54906003)(316002)(8676002)(66476007)(186003)(2906002)(8936002)(41300700001)(5660300002)(6512007)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?akZ3R0luQzJRdk96VklhSVNEdzlRanovSDVZejJoelhrQ3Z4ZU8ybDVFcW1R?= =?utf-8?B?M1F4TVgyOHZrditpU2todis1R2hHazlpNjd5NHY2d0NkSzFIbWFOVFRjbTFq?= =?utf-8?B?YlV4ZXZCdkg4ZlhPNmdYY1p3YmRzVS9CdTBTVFBCRFlWUm9DU0x3SlVSbXJx?= =?utf-8?B?Rkt4bTM3Q3M2NU1GeUpydVMxWjUrYThUMmVEaGFENm9ER1hMZlJienRHTjRR?= =?utf-8?B?MS9iSnNwOExzT0FRblRyQU5rQU4vS1cxTXdNdVk1N1pyemlwZDM1U1ovN0Vl?= =?utf-8?B?SnY3UCtucE9GSTBsQVBqV3U3aHpTZzYraFg2Ti9WcW1OT2E1aGVQMWJVZ21S?= =?utf-8?B?Y1VudzdLeVpYVk1mS3BsaExra1BMS2FNY0QwZnU5djMvTHV4aXhoa2RWWExU?= =?utf-8?B?cGpmeEc3R2I3TjJvRnl6VldIUGVqRWZSMEpodFBOaGM1WXB2YW5xdk9oWFN1?= =?utf-8?B?eUtBNXkwZ1RHKzZ4WVQ1WXFuYWE0NkFHYzB1b0VXNXpqRjMzZ3c3ZDhpSXNS?= =?utf-8?B?QTZDR0RxMHJUUGlIWTQybXRmNGRzMGREakhlMFlWcTYrRUZ1bS9vNjk0akFl?= =?utf-8?B?VFRuVFowazJ5cWltZFlBVngyMVpEeTc5VTFIdGU0MC9TWENBY1J4RWI0QmRp?= =?utf-8?B?bmUzL0wxQ1JEUy9ucWxuTTJvd29kQ3F4b1hQcWYvN1ZsTlBORUNlS1FkMGZU?= =?utf-8?B?a3VQaWlGUitnZDZCT2lsOXZIWWpXd1Y3L00wZWpnTWx5dGlqT01aSUV0cWxJ?= =?utf-8?B?VlNmaHZhRTR3QjFPU3hlai9Rd3RlTWYzQ2NXVnFybklZK0hoOGZ1YlEzRVlX?= =?utf-8?B?VE1UN0VORWhqYXhScUMzWGc4RTI5dUhOaEcreTNlRFlYczFNakV2OGhVcmNY?= =?utf-8?B?cUVvV0pqQUZWSnRRanJSOE1VYmp6VjlWcW5kVGRiTG5wbHdaN1U0bktzK29m?= =?utf-8?B?UW03TzFRdjB6ZnlCaHQzRENzczNWK01mM05KaXBiMzdMcE0zM3ZxRCs3TVQ1?= =?utf-8?B?UC9vaURlTnhwY0VSWU9wNlpZSzIwWG5ERkpXRHl5b0EwMjd6TTA0TG1nUDBR?= =?utf-8?B?c1VkY3ZoQi9meDMrNld5d3ViQURGWWpYa2Y0SVVya3UyWWpQTUpDWXViWE5o?= =?utf-8?B?TW45YjVCR3lpNDdTSE1UcXIydVd0L3Qyd1ZMNzZtdUJTVlFHMnFFRUpnZHNH?= =?utf-8?B?TVhvNGJaaXdRNWxXa3djczBmaUtGenBzclhtWlFnWXI4RWtjZm50NXZyWEZt?= =?utf-8?B?RWpVNTNZalBrTHB5ZDRlcUtTcjRvL3FSUFhkdEx5SGw2b3diMWVIMmtSd3I0?= =?utf-8?B?MUhEbUJXRE0ybVAvVTlrQ3hseGQ1d0h0RFdYSDJqVkhrMU5wSVlkbmFsVXR3?= =?utf-8?B?dE0wb3Zjd1N0S1ZtWUtxRno5cURMOEE4bVZFTTJ3NTdpZm9LblJyK1Z0bUNW?= =?utf-8?B?dTVnVlhoMGVBdlZXS2p0OHpWSVZ0UHJGelUyNWpMTzNWejR0R1ArS211S0tZ?= =?utf-8?B?VGYxL3NwbUwvYlBNV2xlVUp4dkxnRlhmcy9wMDhnUzZGSTBpM1ZvZzk1WWg5?= =?utf-8?B?b1ZuME5GOEZPdGtnYWxJbkpQeXZlL05kV3RkQ2U3VG0yd2FXK0t3ZTJQS3NG?= =?utf-8?B?ZS9IN1NiY3hhY1lOdlJoU016WEM3MVF6MUJqeTRYUlkyeXh6dGE4K2RWTmdY?= =?utf-8?B?M2RMOGNhUWpBK3ppR0N1ZlNXb2JBMGFPNUJ0YkdIVlVydnlDU0pwR0hzU0cy?= =?utf-8?B?M0w1Y2hxL1l1eUV1QytvLy9ZSUt4ZlZ4T2E3SW1SQTBBdW9JSjlJTUdUQmJj?= =?utf-8?B?aXRXaUJHRmNZdGk3ZFFqOXFlcUFQaDNWM0tVMTlPV291bU5zTHhsU0VFc3VJ?= =?utf-8?B?d2NjaTBEYW1yemtWdnVJM3JEY1FlNkIyRFo4c2NRZE1Ya2V6b0c2WUdHSFl2?= =?utf-8?B?bGxxY1VoaEdVbjBGV2tadGpIbnplUkwxeHBGUGFhN1F4SG5vdXppeHF4RjdK?= =?utf-8?B?RnN2WjVacDU3NTc2NHRSSk10aW51MHZ5Z0txRFZBWVVMd3cwOU9wRG85elgy?= =?utf-8?B?TXBjZjh5MkM4TDlkWTBiZmNWRTNqbmJncGNhSFExbnZ1ZnJmNjNEc2xtWVZy?= =?utf-8?Q?5bO0b8I4nGgVVC3MadQy9upe2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1971894a-47a3-4c6d-f98b-08da63d46519 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:01:50.7545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0YphiOw4b0evBDxC9hv7K93ib9JNEnjgaa7gWWpSknYogCTduohDGyVusirVJsZ9v4sIlxVGjLvxTeE2WCf+Ow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9564 On 11.07.2022 18:21, Anthony PERARD wrote: > On Fri, Jul 08, 2022 at 03:39:38PM +0200, Jan Beulich wrote: >> While in principle possible also under other conditions as long as other >> parallel operations potentially consuming memory aren't "locked out", in >> particular with IOMMU large page mappings used in Dom0 (for PV when in >> strict mode; for PVH when not sharing page tables with HAP) ballooning >> out of individual pages can actually lead to less free memory available >> afterwards. This is because to split a large page, one or more page >> table pages are necessary (one per level that is split). >> >> When rebooting a guest I've observed freemem() to fail: A single page >> was required to be ballooned out (presumably because of heap >> fragmentation in the hypervisor). This ballooning out of a single page >> of course went fast, but freemem() then found that it would require to >> balloon out another page. This repeating just another time leads to the >> function to signal failure to the caller - without having come anywhere >> near the designated 30s that the whole process is allowed to not make >> any progress at all. >> >> Convert from a simple retry count to actually calculating elapsed time, >> subtracting from an initial credit of 30s. Don't go as far as limiting >> the "wait_secs" value passed to libxl_wait_for_memory_target(), though. >> While this leads to the overall process now possibly taking longer (if >> the previous iteration ended very close to the intended 30s), this >> compensates to some degree for the value passed really meaning "allowed >> to run for this long without making progress". >> >> Signed-off-by: Jan Beulich >> --- >> I further wonder whether the "credit expired" loop exit wouldn't better >> be moved to the middle of the loop, immediately after "return true". >> That way having reached the goal on the last iteration would be reported >> as success to the caller, rather than as "timed out". > > That would sound like a good improvement to the patch. Oh. I would have made it a separate one, if deemed sensible. Order shouldn't matter as I'd consider both backporting candidates. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 07:13:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 07:13:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365511.595711 (Exim 4.92) (envelope-from ) id 1oBA50-0008Rq-RF; Tue, 12 Jul 2022 07:13:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365511.595711; Tue, 12 Jul 2022 07:13:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBA50-0008Rj-OE; Tue, 12 Jul 2022 07:13:10 +0000 Received: by outflank-mailman (input) for mailman id 365511; Tue, 12 Jul 2022 07:13:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBA4z-0008Rd-1f for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 07:13:09 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80050.outbound.protection.outlook.com [40.107.8.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13be7d2d-01b2-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 09:13:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4190.eurprd04.prod.outlook.com (2603:10a6:803:4b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 07:13:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 07:13:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13be7d2d-01b2-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mb3HT/krS0fky7nKCS20tEzpbz0DmQgvJpFQwOEOSc4sV1eldQcuRnacja6wt/n69yi9Np619MNp9juHOGnDAfo8Zoq61D/n0tDYLoTDhDCbQks4Z0z/N3uQl+pLbQyWm89PEzA/ZAc88TrMjN1O4A76tQNOwMmd0ghuAsGpJa1CdmUfQmrtuhf+VFBVW9fQdNnmHTpARzOfzQzS4wKEFcH6fa51uP1jF+Zo5B5/XdEPVMC3VLCGHq0RlI+aXOVzSTh1uh+zt2R7zYw8yHjAZArPFjudQ/ZPRk+yrKuFK6wRfR09958Y9fntGh1YKXjOX9i8rnvaj2m6Nbp1k5ljjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8McykcUCx+s9xCR2wAzSKd9o9NIkFb6FJOtPF3Smhk=; b=kMGUYeglPcSseN6+BATuVw7LlCnhAaGcpo/QGe+MS31Wequ2ZJLFL5QBf1diaVwzuLC6ClNdNeSCzG3wLia6Mtnppp53wIe9d90H9w0mzrK81zuRbVvfAtBwb5se+hyhXf1693BjnvO0j1vtYvNUDyBGYRrI1VRNp8w6SX6I0+wfqd2/e87QFCb6oaXiheyKrsKXqhJA3UNBuZMzIW1k4TpSiyOZYVbpQ/4M4eY+jXmKsLXTKXbH8/5NPVmkTFJBEtL4J/GMleH8g776oUIbf1PYlRuSbozn+EGNvpFwgVs0r5Am0YdytPtKT/+e/lTJ4YNwOXD7D6pOn/CjV9THZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T8McykcUCx+s9xCR2wAzSKd9o9NIkFb6FJOtPF3Smhk=; b=vZK/C3k6zagR52RmI8mwakDRaPM9GVSBcyoIIyF79spdE0e0k446gqG6s10dtoWeV42OsO/Mw5cVbYwv2ZwSjAGmqFX+ASeHybPYgYF8GctGhcQcDr6O9CUxJ7ai01+oKOpuYgznxZFpe+/9IJAVIs8hNMb9ygfndt6NwPS98iStqLYersb5EwLxeTSdAcsIXfUV4HMMjoIiUmcrkMUGaA6g9g9ESUr04Sdi/z81JfC7DU6jpUpo32n4cVusl722LwPgSsml+ON57JBwE5DKWp6xWpV77JQ6QVnZf+OJ8fp0lkArh2WV/yanf/+7P9xv/lDWN9r5lmGIj7Lb338fXA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 09:13:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xl: relax freemem()'s retry calculation Content-Language: en-US From: Jan Beulich To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Wei Liu References: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> <2b06e97e-1c39-9889-8d04-f1a063b403d6@suse.com> In-Reply-To: <2b06e97e-1c39-9889-8d04-f1a063b403d6@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0101CA0031.eurprd01.prod.exchangelabs.com (2603:10a6:206:16::44) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 551202c4-c48a-4b44-05f6-08da63d5f6bf X-MS-TrafficTypeDiagnostic: VI1PR04MB4190:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DArazlXR1ArIMI5pfi2vf175aQ6vjDRin0DqpBFxTgKhCS2V/0dHipvOhyR1qhppkziLB6dATqGoJYjKGW4I3HdTv+qxNTgxoYq10mBln9+WzbUuqzf39sJuPcUZs1sJJpRYbGkEvXCGbVlDXCpxHLkHit7p7YNVEW69Td5JnnfDr7gVKg6HuSPxMWNHu3pkvk1ZWQsEBVLwlyJCXGpI0cbguKnGM6aKJzjW7eevHq39OKzBilrbtvctF8lsDMPFFG2tZrFMIVN+lyZjgZyGXzhQStMFo2yQI0H4nP1+xCNrQgzv4Dkf3I5CY4ScCCffOIAa8xTxMzFRVLhcCuTTy6PfUHPzsowcDyTWW9l2wBWL2uwBrB/o/YMQL6+eS3revBB/lZbfY3yMN/JGNFim+f0ixUZy9QMzL2mlXYIG99018Bkj6fiV/b2JNM4rha8/oMnInQKyLBBGGMHhvl4dlV3Hiiq2RYcXspJu2EamRWwWlE4mFLwCrUJRB4PJmX4zLML/npPrwohT+3wNf1h/qetzgliVXVmJUgyZnpreryAOSiGHrH6M4jVVvCDBObNn+IdGYXOW357rUUIosoBfYkhylElI89lMSbk9XGLZOfMpexvBLkhYRwGPOhZMdBuSwAbRm6a5Fc2FdmL7555N5FXo4wZJ8qQFstFr22keYKfinXvtvpmmL80yIGPKzn+kTFBf6IDOi78VG49f/zZ4xxXNYhb6trwul7v2mtWoYk3AvHQ+NGhVpVGbPj4XI80CI5niRuNOBe9pYd5PlzIImuLrlAKsQeozbVKiuJK1OrTscNMKktEqOYWt/qC19cS3FNkNP5q4NAxM1OIz8cneqWqBMPiW7Nt74OulcwhKlMs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(396003)(39860400002)(376002)(478600001)(83380400001)(86362001)(6506007)(2616005)(6486002)(316002)(31696002)(6666004)(41300700001)(53546011)(6916009)(5660300002)(26005)(6512007)(66946007)(66556008)(31686004)(66476007)(36756003)(8936002)(186003)(38100700002)(54906003)(2906002)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1ptV2tmck40UGdZQmxzdmI3azZOWWdZc3FUOTdjSXQ1a204RjFQRlV1RW51?= =?utf-8?B?QlRPV0E0REZTdEVwTEsyRTByRS9xUGcvVjJVNWo5dStuTjVUQVB3RGxuc2tl?= =?utf-8?B?cUpmRmVpUlFvSFJBZXJYWjl6MFh2cUtUbVNkOUtrOEFYdkpHcjZYa1hxN2Rr?= =?utf-8?B?VTNxUyt4UWRTR0hRcG9qUktNKzUyaWh4RjdUVGdFYjJrbmh0cUF2YzhMTjRq?= =?utf-8?B?YldwaDF0eVQ1RW9nR2c3bWhodkQzK2JadzlVaUVXVHNncklIaVRwLy9ablQ1?= =?utf-8?B?YlA2NW5zcThkRENqYlpuSGRudTVpLzBmNThaTnJKVm0vSy9XTElmZEtwSUFN?= =?utf-8?B?QjRPZENOek8yaUZRYlp3MnJSQ25sMmM2K3JOZFdqZ1RxU3lJZ29Rc2h3N1Bq?= =?utf-8?B?ZjY4L0xKU0lUMnJrdXgyVmpoWnFNQmNNbmlZV1RkSU5nVHZPY05MSXY1aXRu?= =?utf-8?B?NWdDU29nSkF5MFFFUS9MNVNWUXlreEhjV3VBUWhYMkkzWiswejN5RmZ6NEZl?= =?utf-8?B?S1ZGSW1PQ3JlY3dIYzBTUTJNL2JjNlpXSnZ4dGRKcUpxcGJrZnBkWEZWaXY4?= =?utf-8?B?UU9CK0hONXFodGdzTWRlTEw5dk9GeFR3aStyS25CUEFzQ2hPRW5pYlhGd01K?= =?utf-8?B?K3FIbU1lcVdSTDlwQlNvWlBPQ0ZOR2sxWmEvVFhoanlNaCtFZVFOUmk1cUtW?= =?utf-8?B?QXFPU3cxTlVZVUdlMW1IOXh6M0t2TnhHaWlUNzg0NWdWNXhlSVF0eVdlZDgv?= =?utf-8?B?OG1CeDhuN2FoOGc0dFJZSjBOeExKbFltUE9naXE1aWtmMFdJSjRGTEo2VGQr?= =?utf-8?B?UDdtMmlka0xUTElHYUhzV3NWRkRuZW9ocmlPck1kSkErT0VpKzZRcmJWWTM4?= =?utf-8?B?dS9jalFTL2pPaTE1SVJHc2x6cDNWb1QxdzBiTThheVhZeFlRYk9iL2k1eG9V?= =?utf-8?B?eWpNbStEVDM1UnpxbDFma3ZKRHByRG9QNHRlTFErN1hDS3BDaldiWklXbDFL?= =?utf-8?B?WEJ2RVNkOHR6NXhYUUxxOWhsazh0U0Q3NWJzdFRPUHQ0dmxMbysvc1RYWGRq?= =?utf-8?B?a2RuTWw0Y3hoNWp2bUs2YkRuN1NWZjVJL1laaW1zTXNtdXNSQk5NOEtTRjA1?= =?utf-8?B?UDVZSkV0Umh3T0pWTkhSWC9PV2FkL1pKb1RyZjNEWGFzYXNTN0p2YnF3VWNz?= =?utf-8?B?UWpaS0Z2dVJPQXBzUGNHVE5hOUtQVXdUcWhlRG9ZWk5hdVkyRUFvVXpnZkI0?= =?utf-8?B?cW8yTlJrNzYyZzJlRDM1d2RWRUdSUmI3SHBjeDJITzhFMUxsbXhtaDA2eTRi?= =?utf-8?B?d3lIMnVjTUZnc2l5c3c3cGcyUkE0Z00vTFNjSHBVRWdMQ1J6NUk1YUZNMGZa?= =?utf-8?B?L3p4RmNSNElWaW5SOGNqZ3U4aU9TTXBzNGg1bXA3QmIwMXFNcmFmaUx0a0Nw?= =?utf-8?B?c0dnTmJxaGRiVlFqMjlIcUpPaGFJUklGOWc2TVNIWTJMK3V1OGVPc2QzU0lM?= =?utf-8?B?aUpvTGgrL1YwTzhrdk9lTzBsSFoxckFiOHZmcG8wc29mRXFQVHVDcnMrUUpB?= =?utf-8?B?cmRpWC9UaDY2aWVxL0F6K2VVYUYzQWoxNzBmSlI3S2cvcnpDeEdQRy9QWml2?= =?utf-8?B?VEU2RGY0MXBIOXdQdTRBOW5jbGd1VjNOMUJZNk9EUS85MzBhQ3FGbXQ4Qk5w?= =?utf-8?B?aUl1SFRieFVDMG1VY3ZieENJdHlXR1FMWE5DWEt2YzBzS0tqaDMvZjJKWUlm?= =?utf-8?B?KzNmcTVjaWV5VEFiTWZHSzVjcVRSN1p5YlB0ZEMvaWwzNmluUHpFUlZPMmhm?= =?utf-8?B?TDhITEJpY3VuTE9rbVpYZGNDa0RLQnhvVE5PT1hPLzNqNGNld3JGVXVpNjkv?= =?utf-8?B?NGRKUzY4ZmZMOTRaQmpoa2xpTFdEVjF0OXVoUFpmWnhNOUZrZHp4MUtveFhK?= =?utf-8?B?eXBrcEwvN3Q3WEFZT0ZjdjhLcXZjREJtekZrYnl2VzhlOVFxVm1rbEs5MGMy?= =?utf-8?B?cXlBOXVNMzB1SHNYaHNVaEl3cUtPOFEwbEwrT3d0elBaM0NVUTNlY0pZbGcw?= =?utf-8?B?VkxxZzMvVnBoQ28rcGY2K0dzWnVTVzhkSHpRU1pYU0xCM2ZaSzNyTzg0blZK?= =?utf-8?Q?ObumOa6LVdWo2MCtJesbIfjKV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 551202c4-c48a-4b44-05f6-08da63d5f6bf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:13:04.6494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: le3QpFve2glb6qltgFTP2NPiPnQvJ4pFtDSnUCjM6h50NN28QCUJgjBObog6WtPBv1oO/jNwa2em/4eDit5d6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4190 On 12.07.2022 09:01, Jan Beulich wrote: > On 11.07.2022 18:21, Anthony PERARD wrote: >> On Fri, Jul 08, 2022 at 03:39:38PM +0200, Jan Beulich wrote: >>> While in principle possible also under other conditions as long as other >>> parallel operations potentially consuming memory aren't "locked out", in >>> particular with IOMMU large page mappings used in Dom0 (for PV when in >>> strict mode; for PVH when not sharing page tables with HAP) ballooning >>> out of individual pages can actually lead to less free memory available >>> afterwards. This is because to split a large page, one or more page >>> table pages are necessary (one per level that is split). >>> >>> When rebooting a guest I've observed freemem() to fail: A single page >>> was required to be ballooned out (presumably because of heap >>> fragmentation in the hypervisor). This ballooning out of a single page >>> of course went fast, but freemem() then found that it would require to >>> balloon out another page. This repeating just another time leads to the >>> function to signal failure to the caller - without having come anywhere >>> near the designated 30s that the whole process is allowed to not make >>> any progress at all. >>> >>> Convert from a simple retry count to actually calculating elapsed time, >>> subtracting from an initial credit of 30s. Don't go as far as limiting >>> the "wait_secs" value passed to libxl_wait_for_memory_target(), though. >>> While this leads to the overall process now possibly taking longer (if >>> the previous iteration ended very close to the intended 30s), this >>> compensates to some degree for the value passed really meaning "allowed >>> to run for this long without making progress". >>> >>> Signed-off-by: Jan Beulich >>> --- >>> I further wonder whether the "credit expired" loop exit wouldn't better >>> be moved to the middle of the loop, immediately after "return true". >>> That way having reached the goal on the last iteration would be reported >>> as success to the caller, rather than as "timed out". >> >> That would sound like a good improvement to the patch. > > Oh. I would have made it a separate one, if deemed sensible. Order > shouldn't matter as I'd consider both backporting candidates. Except, of course, if the change here is controversial or needs a lot of further refinement, in which case the other one may better go first. Please let me know ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 07:20:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 07:20:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365517.595722 (Exim 4.92) (envelope-from ) id 1oBACO-0001bK-Jb; Tue, 12 Jul 2022 07:20:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365517.595722; Tue, 12 Jul 2022 07:20:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBACO-0001bD-Gj; Tue, 12 Jul 2022 07:20:48 +0000 Received: by outflank-mailman (input) for mailman id 365517; Tue, 12 Jul 2022 07:20:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBACN-0001b7-79 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 07:20:47 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50056.outbound.protection.outlook.com [40.107.5.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 255c04ca-01b3-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 09:20:46 +0200 (CEST) Received: from AS9P194CA0023.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::24) by DB9PR08MB6990.eurprd08.prod.outlook.com (2603:10a6:10:2c4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 07:20:44 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46d:cafe::82) by AS9P194CA0023.outlook.office365.com (2603:10a6:20b:46d::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17 via Frontend Transport; Tue, 12 Jul 2022 07:20:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 07:20:42 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Tue, 12 Jul 2022 07:20:35 +0000 Received: from 96fd081d33ed.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1A154E87-8789-461B-A934-9C23A7BA2C39.1; Tue, 12 Jul 2022 07:20:25 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96fd081d33ed.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 07:20:25 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VE1PR08MB5807.eurprd08.prod.outlook.com (2603:10a6:800:1b2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Tue, 12 Jul 2022 07:20:23 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 07:20:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 255c04ca-01b3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SQDq87JVkJ+zTgLrUBlAfZagO/A5LCmO3XxR0onyZToInh1EAsToL+N3O+eSHWZOv6V1kMRpr3nloXwyZo08/UKBR7W/mBU0cppI905GYS4jWinsf9vckZh7edJ8Np68/RkkduEKwEzYHCwhdE3Bp4baeAXbIr6XoEp3SfK9EEx7QvCOUuT7ujc8Uh0JltoVu0zSSEFZ1rwDyWw8hmHWXbmwH2bUp49iH0ZxZulUsMQARoL+6Wn6hkah0zpLfwVX1sQM0MLIW7tRLV8xk0pIdmXqWdoYNiP0L7ZOzxNCL0Vw4ir0TNAbEG/7IbZopSnM75uGXh9KZRjFSbQNXqfRFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMXwU/OwbKgIu/WSNNo2xHANK0CcAR8RrXbJ/2VMpE4=; b=CpbUyarP1Vt62EL2L7k+JzJWn+2b6okoUjZEvJ2/Y/Fowkbkakd0FX0+CUOu9CmPb3CZ4wmnq/ygHr6RN3JqGZmnct0XQ7E1EaDTcayguiJqMmdv03mej7dMmaAfQhO2NW0JZiPOg//aQBBdGSinlaZVDtQJGsQdSO+bujI7pumr7wb9k8sVr1Z5Ubpve35KhAev1P/knsBXG3YQMFDzouT35sgNGICFDgZvGXR+BaVySaaa9w2NN38sXP5HgvUzeLc5/lGt29vh68Jzb6mP4zwJxJJMrENGygL0hscmUxUUCCbU8bbOR64MhruX0QZAnAz48dbBUqMr6HBaX5fKbA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMXwU/OwbKgIu/WSNNo2xHANK0CcAR8RrXbJ/2VMpE4=; b=JdYayICJ0bVztV5+K2vFmbf/h5lFnJ7aT84WnCMo4w/Ieg/jC8aZXEYB9bw93eJLTrtJ0kHPiiKqrPBEiL/RPz9jd2yTBPz0RNkmgkeQw0/P52AbBok5kFWrvWY0bNb3kif9oVlUE4sDKFrnAAJeQu7hr4uhaFvKirQaoy0uhD8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LHe1FU2Yno3bIBWBAlBFWrVl3bslBDNHijK2UqcawXHI5nz3QrpooiCeA6MP7wjdJb+WJmBwN0HzV0j+cbNWrEsnfm51GnyAk3WFTEIuxTWm95dCthlVQiaFWDZRoqcj45Lv/1GYzzCYBu44gUzcfJQnOp3z1EMXOsxMuwKXJ7O3Qa2srDliJhY6Oq8LCqG3SMm6CgJXWDJrcQT/67pWB5OIggpwphV38yOBhq190Hl9PcpYXVZ/1SEDmJIgGV0ayM3kOlBOzlqmdfRnEosHC3NXTMMo8WJoldqiqWrgsf9w1MSGJ8op3YAbID6hKO6b0kX+Io530TFHePxsLw5fRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dMXwU/OwbKgIu/WSNNo2xHANK0CcAR8RrXbJ/2VMpE4=; b=ZPjaFQx3eqnUbzPxbYqO6xI+eMO3GRJQmWuhvAhSHJ2lvr8i4gobwstzDq0KTomKLktpoA8zV1O9ydcxjrSjwd/Tsp8IotMJOiJBtbqTCJvQp8QL2SV2jlacDh/aamwGXaWOy6Bq8vGDmRry9EnPCACayWuqTpSZnm6rvfS3wV40cdElG3JREwkiC21MbXFp/MLXioVuXm1dnW4fzcFX2dpsBcbaJA3Uv0ODNrH85ujRUN4Q7LjW61oqQ6BUamE5AL5LF76pUkKZL3zwhqugRuAT4bfKQUyw2Jf5iR7UwvuWWZwIzaTkwfSvVXTiNhzjxf8l6dETXXrA1Y1C1zI6Ug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dMXwU/OwbKgIu/WSNNo2xHANK0CcAR8RrXbJ/2VMpE4=; b=JdYayICJ0bVztV5+K2vFmbf/h5lFnJ7aT84WnCMo4w/Ieg/jC8aZXEYB9bw93eJLTrtJ0kHPiiKqrPBEiL/RPz9jd2yTBPz0RNkmgkeQw0/P52AbBok5kFWrvWY0bNb3kif9oVlUE4sDKFrnAAJeQu7hr4uhaFvKirQaoy0uhD8= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Thread-Topic: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Thread-Index: AQHYktq/lgTeemGHCUuLgTuwCRELQK14uj+AgAGe/lA= Date: Tue, 12 Jul 2022 07:20:22 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-5-wei.chen@arm.com> <6b1b2694-d46a-7713-6109-99c98fdf6b8e@suse.com> In-Reply-To: <6b1b2694-d46a-7713-6109-99c98fdf6b8e@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F186957D68891548BCFB0D29EE440AB8.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 322976bd-692a-4892-2894-08da63d707c1 x-ms-traffictypediagnostic: VE1PR08MB5807:EE_|AM5EUR03FT014:EE_|DB9PR08MB6990:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YOrxtkU+zB37/pQp5qDMZjJeYax51/FmTUo9shUU4v0cIi1dkhGnr6zghuC+myZY1UkMz26J5rxXVEsEXAtYdjA2m2bgitc4i58ZmECs852V+fF//prTKV7jP1RzsC0lZG2p6DXfNWDaf8+PROY8kNyhybBEhn4d0pYYXikSg9F1q4Z7qRrgSBm5n/HOimiobRsTMF/PrKVYJH9Gdxg/6WepRVfkOwvRzRez7O26DXiLFivlpxWiwYVBP9KMULrjH4yk4DYSyUi0w1vd9Bis0GPPzHYpwlBeV7kAoxW5J3d7ZRVPBZ0LoEHaOhsr1ymjir1WCt5K5rAuh+aJVzzdW0lIS3L+Bsq+Cug9MwD8DeQO7C3hjx7HIElFUpbA37N91dN4hkpL/AOqUJPnlPaE7aMzS8QYTJCo+CGn0qeQXX9/mpgrza3/dpINu02/ArlilkVhME0ODODJXMeWjQebSWO/oM3MoiD7/RKwf+opBFae69tOfPHGmqr1jvTVKk7cgtwBtJOLbqDdMx33I7KCVfHvPtcIbvgOgmr8MT7PmWp1kJ3jqi0pHmvlq7SMLForeEvDzwuw7hRVuEMdsfAxk1TCal8+x6liMLTdpIURp4Ny0XoLkyi8paNBV5/ismUFwMKzR7TY7DCsSbuq3OgNhHlugGPiHFPDFSk45zjYLAgAiqCFyK+5makIzKvEO540a65iUfbW4EERLI0DjRZA8hnE1bzyHPdeWLiAHa6yPN6AcvR6tbcDTrsS3qSXuS5n8bmuwYpvyqNcRSGCH+8hgz+XEC6zRUpiH1B9mOsFN/OBmWx3DH4P2SbM6JUIsR9n X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(366004)(39860400002)(26005)(53546011)(5660300002)(7696005)(6506007)(38070700005)(71200400001)(9686003)(41300700001)(478600001)(33656002)(54906003)(316002)(6916009)(86362001)(8676002)(83380400001)(122000001)(66476007)(66946007)(66556008)(4326008)(186003)(64756008)(66446008)(76116006)(52536014)(38100700002)(2906002)(55016003)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5807 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 64b08803-c45d-4ea8-8b2b-08da63d6fb9b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KJC5wCTJ3NXAZ5t2NL5eUMynLchUov3IPimxjOG3WhbrKAefkPbuZ5E7UyWkcoYyCBq2TpU7x/bOzGTEYAJodEG5Py+p0SaBStsXH8wytZcBOFoUIdVyLpSLpW7Qh0BdMknZHx44XSH8fIe/X4v0dDp6HhgQWBu1nmGNJ/FCrshMnEoEjlj80hOlxyRsogd1K9YhjlfilPTEl934XfqTEG0DwoTVFI28uou2WE7ZEdgLyUtYsmcaBgn8YTBXt24Ed6oc3/i8ST4vC3i3CofWPXl44HfmyiBb9i1FL2qU6ncVeozMT0NoS5bP/KUIzNG9VkHeqYvuFXP7YBymMGHbah8atVgz55Me+coAyDpPIvKHDdz78ohJhGCXKvpw/Mpyn8foqIOqHufHDj7WkFHSD+TfZRrMlE/wPJ+8ohDPoYa/M55ZgytYEkTRqc3NTdC9R9Bva9hqNapSEBfFLZqrijDOPWAcr/iGazFAmrHLui5S0hBpItJJDfUCUgvC6xNEY572Rqzc/pK0fBVeZWPi/uAOZOdxOjnrzY1qL2Y0ItsUIw0snVNmOXVbj9IJ2N+/92fQGyI3QvTZaQ8R9wVeQl3obUgF3BjFL1kdS6/N75tCv+vSGpJTojIuSkKybcppto7ujl9BhrqCKQbjbfM+XU5FrZDZ8ytl+vZY5eFS3lh8hToXMuw00NlNWt2Q69zhNXhi2YpQgXerXVsIU5XHBhlE0VUzMCkhvL/oTklkRWcQidaTGkXzwa2CUoY7QRUwq27BbKCKsTULJnG0kEtBAlB7TOdzdXRwxaxwYOTamVi0u3G3LTQrGjIViTBmst8+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39860400002)(46966006)(40470700004)(36840700001)(2906002)(478600001)(82310400005)(81166007)(336012)(356005)(86362001)(82740400003)(7696005)(83380400001)(40480700001)(40460700003)(47076005)(6506007)(53546011)(41300700001)(26005)(6862004)(8936002)(186003)(33656002)(5660300002)(70206006)(316002)(55016003)(70586007)(4326008)(9686003)(54906003)(52536014)(8676002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:20:42.4001 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 322976bd-692a-4892-2894-08da63d707c1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6990 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMeaXpSAxNDozMg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UNCj4gRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgV2Vp IExpdSA8d2xAeGVuLm9yZz47IEppYW1laSBYaWUNCj4gPEppYW1laS5YaWVAYXJtLmNvbT47IHhl bi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHYyIDQv OV0geGVuL3g4NjogVXNlIEFTU0VSVCBpbnN0ZWFkIG9mIFZJUlRVQUxfQlVHX09ODQo+IGZvciBw aHlzX3RvX25pZA0KPiANCj4gT24gMDguMDcuMjAyMiAxNjo1NCwgV2VpIENoZW4gd3JvdGU6DQo+ ID4gVklSVFVBTF9CVUdfT04gaXMgYW4gZW1wdHkgbWFjcm8gdXNlZCBpbiBwaHlzX3RvX25pZC4g VGhpcw0KPiA+IHJlc3VsdHMgaW4gdHdvIGxpbmVzIG9mIGVycm9yLWNoZWNraW5nIGNvZGUgaW4g cGh5c190b19uaWQNCj4gPiB0aGF0IGlzIG5vdCBhY3R1YWxseSB3b3JraW5nIGFuZCBjYXVzaW5n IHR3byBjb21waWxhdGlvbg0KPiA+IGVycm9yczoNCj4gPiAxLiBlcnJvcjogIk1BWF9OVU1OT0RF UyIgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pLg0KPiA+ICAgIFRoaXMg aXMgYmVjYXVzZSBpbiB0aGUgY29tbW9uIGhlYWRlciBmaWxlLCAiTUFYX05VTU5PREVTIiBpcw0K PiA+ICAgIGRlZmluZWQgYWZ0ZXIgdGhlIGNvbW1vbiBoZWFkZXIgZmlsZSBpbmNsdWRlcyB0aGUg QVJDSCBoZWFkZXINCj4gPiAgICBmaWxlLCB3aGVyZSBwaHlzX3RvX25pZCBoYXMgYXR0ZW1wdGVk IHRvIHVzZSAiTUFYX05VTU5PREVTIi4NCj4gPiAgICBUaGlzIGVycm9yIHdhcyByZXNvbHZlZCBh ZnRlciB3ZSBtb3ZlZCB0aGUgcGh5c190b19uaWQgZnJvbQ0KPiA+ICAgIHg4NiBBUkNIIGhlYWRl ciBmaWxlIHRvIGNvbW1vbiBoZWFkZXIgZmlsZS4NCj4gPiAyLiBlcnJvcjogd3JvbmcgdHlwZSBh cmd1bWVudCB0byB1bmFyeSBleGNsYW1hdGlvbiBtYXJrLg0KPiA+ICAgIFRoaXMgaXMgYmVjYXVz ZSwgdGhlIGVycm9yLWNoZWNraW5nIGNvZGUgY29udGFpbnMgIW5vZGVfZGF0YVtuaWRdLg0KPiA+ ICAgIEJ1dCBub2RlX2RhdGEgaXMgYSBkYXRhIHN0cnVjdHVyZSB2YXJpYWJsZSwgaXQncyBub3Qg YSBwb2ludGVyLg0KPiA+DQo+ID4gU28sIGluIHRoaXMgcGF0Y2gsIHdlIHVzZSBBU1NFUlQgaW5z dGVhZCBvZiBWSVJUVUFMX0JVR19PTiB0bw0KPiA+IGVuYWJsZSB0aGUgdHdvIGxpbmVzIG9mIGVy cm9yLWNoZWNraW5nIGNvZGUuIEFuZCBmaXggdGhlIGxlZnQNCj4gPiBjb21waWxhdGlvbiBlcnJv cnMgYnkgcmVwbGFjaW5nICFub2RlX2RhdGFbbmlkXSB0bw0KPiA+ICFub2RlX2RhdGFbbmlkXS5u b2RlX3NwYW5uZWRfcGFnZXMuIEFsdGhvdWdoIE5VTUEgYWxsb3dzIG9uZSBub2RlDQo+ID4gY2Fu IG9ubHkgaGF2ZSBDUFVzIGJ1dCB3aXRob3V0IGFueSBtZW1vcnkuIEFuZCBub2RlIHdpdGggMCBi eXRlcw0KPiA+IG9mIG1lbW9yeSBtaWdodCBoYXZlIGFuIGVudHJ5IGluIG1lbW5vZGVtYXBbXSB0 aGVvcmV0aWNhbGx5LiBCdXQNCj4gPiB0aGF0IGRvZXNuJ3QgbWVhbiBwaHlzX3RvX25pZCBjYW4g ZmluZCBhbnkgdmFsaWQgYWRkcmVzcyBmcm9tIGENCj4gPiBub2RlIHdpdGggMCBieXRlcyBtZW1v cnkuDQo+ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4N Cj4gPiBUZXN0ZWQtYnk6IEppYW1laSBYaWUgPGppYW1laS54aWVAYXJtLmNvbT4NCj4gPiAtLS0N Cj4gPiB2MSAtPiB2MjoNCj4gPiAxLiBNb3ZlIGZyb20gcGFydCMxIHRvIHBhcnQjMi4gKENvbW1l bnQgZnJvbSBOVU1BIHBhcnQxIHNlcmllcykNCj4gPiAyLiBSZWZpbmUgdGhlIGp1c3RpZmljYXRp b24gb2YgdXNpbmcNCj4gPiAgICAhbm9kZV9kYXRhW25pZF0ubm9kZV9zcGFubmVkX3BhZ2VzLiAo RnJvbSBOVU1BIHBhcnQxIHNlcmllcykNCj4gPiAzLiBVc2UgQVNTRVJUIHRvIHJlcGxhY2UgVklS VFVBTF9CVUdfT04gaW4gcGh5c190b19uaWQuDQo+ID4gNC4gQWRqdXN0IHRoZSBjb25kaXRpb25h bCBleHByZXNzIGZvciBBU1NFUlQuDQo+ID4gNS4gTW92ZSBNQVhfTlVNTk9ERVMgZnJvbSB4ZW4v bnVtYS5oIHRvIGFzbS9udW1hLmggZm9yIHg4Ni4NCj4gPiA2LiBVc2UgY29uZGl0aW9uYWwgbWFj cm8gdG8gZ2F0ZSBNQVhfTlVNTk9ERVMgZm9yIG90aGVyIGFyY2hpdGVjdHVyZXMuDQo+IA0KPiBU aGUgY2hhbmdlIGxvb2tzIG9rYXksIGJ1dCBjYW4geW91IHBsZWFzZSBjbGFyaWZ5IHdoYXQgdGhl c2UgbGFzdCB0d28NCj4gcG9pbnRzIGRlc2NyaWJlPyBUaGV5IGRvbid0IHNlZW0gdG8gbWF0Y2gg YW55IGNoYW5nZSAuLi4NCj4gDQoNCkkgbW92ZWQgdGhpcyBwYXRjaCBmb3JtIFBhcnQjMSB0byBQ YXJ0IzIsIGJ1dCBmb3Jnb3QgdG8gcmVtb3ZlIHRoZXNlDQp0d28gY2hhbmdlIGxvZ3MuIEluIFBh cnQjMSwgd2UgZG8gdGhvc2UgY2hhbmdlcywgYnV0IGFmdGVyIHdlIG1vdmVkDQp0aGlzIHBhdGNo IHRvIFBhcnQjMiwgdGhvc2UgY2hhbmdlcyBhcmUgdW5uZWNlc3NhcnkuIEkgd2lsbCByZW1vdmUN CnRoZXNlIHR3byBsaW5lcyBvZiBjaGFuZ2UgbG9ncy4gU29ycnkgZm9yIHRoZSBjb25mdXNpb24h DQoNCkNoZWVycywNCldlaSBDaGVuDQoNCj4gPiAtLS0gYS94ZW4vaW5jbHVkZS94ZW4vbnVtYS5o DQo+ID4gKysrIGIveGVuL2luY2x1ZGUveGVuL251bWEuaA0KPiA+IEBAIC0zNiw4ICszNiw2IEBA IHN0cnVjdCBub2RlIHsNCj4gPiAgZXh0ZXJuIGludCBjb21wdXRlX2hhc2hfc2hpZnQoc3RydWN0 IG5vZGUgKm5vZGVzLCBpbnQgbnVtbm9kZXMsDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIG5vZGVpZF90ICpub2RlaWRzKTsNCj4gPg0KPiA+IC0jZGVmaW5lIFZJUlRVQUxfQlVH X09OKHgpDQo+ID4gLQ0KPiA+ICAvKiBFbnVtZXJhdGlvbnMgZm9yIE5VTUEgc3RhdHVzLiAqLw0K PiA+ICBlbnVtIG51bWFfbW9kZSB7DQo+ID4gICAgICBudW1hX29uID0gMCwNCj4gPiBAQCAtNzcs OSArNzUsOSBAQCBleHRlcm4gc3RydWN0IG5vZGVfZGF0YSBub2RlX2RhdGFbXTsNCj4gPiAgc3Rh dGljIGlubGluZSBfX2F0dHJpYnV0ZV9fKChwdXJlKSkgbm9kZWlkX3QgcGh5c190b19uaWQocGFk ZHJfdCBhZGRyKQ0KPiA+ICB7DQo+ID4gICAgICBub2RlaWRfdCBuaWQ7DQo+ID4gLSAgICBWSVJU VUFMX0JVR19PTigocGFkZHJfdG9fcGR4KGFkZHIpID4+IG1lbW5vZGVfc2hpZnQpID49DQo+IG1l bW5vZGVtYXBzaXplKTsNCj4gPiArICAgIEFTU0VSVCgocGFkZHJfdG9fcGR4KGFkZHIpID4+IG1l bW5vZGVfc2hpZnQpIDwgbWVtbm9kZW1hcHNpemUpOw0KPiA+ICAgICAgbmlkID0gbWVtbm9kZW1h cFtwYWRkcl90b19wZHgoYWRkcikgPj4gbWVtbm9kZV9zaGlmdF07DQo+ID4gLSAgICBWSVJUVUFM X0JVR19PTihuaWQgPj0gTUFYX05VTU5PREVTIHx8ICFub2RlX2RhdGFbbmlkXSk7DQo+ID4gKyAg ICBBU1NFUlQobmlkIDwgTUFYX05VTU5PREVTICYmIG5vZGVfZGF0YVtuaWRdLm5vZGVfc3Bhbm5l ZF9wYWdlcyk7DQo+ID4gICAgICByZXR1cm4gbmlkOw0KPiA+ICB9DQo+ID4NCj4gDQo+IC4uLiBp biB0aGUgZW50aXJlIHBhdGNoLg0KPiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 12 07:36:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 07:36:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365525.595733 (Exim 4.92) (envelope-from ) id 1oBARe-0003LX-1y; Tue, 12 Jul 2022 07:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365525.595733; Tue, 12 Jul 2022 07:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBARd-0003LQ-Uo; Tue, 12 Jul 2022 07:36:33 +0000 Received: by outflank-mailman (input) for mailman id 365525; Tue, 12 Jul 2022 07:36:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBARc-0003L8-FC for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 07:36:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5831cd09-01b5-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 09:36:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB8032.eurprd04.prod.outlook.com (2603:10a6:102:ba::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 07:36:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 07:36:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5831cd09-01b5-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cxmX1bxI3IaZgjFtkGduimZkZ0wId5BpO3mONWfNw7v1+/xlKiXWpmw4qw9NiX+qkwcHeQdUACeOGt17sSmtsMk8OUeTP3Xset5iZefSl5jCU+Os6vfmFkuEHv80NRryb8PkLyHy0Jfco4xsMNbcgIkKn0NowFZ1scmOoTWuQxzbtH7E1tIUyMjTcxif0Bwg7pIEkBMvR+N2OCc2pJk7kJ/5Vwo6sdsVV0sdujVaFZQmp2aAYM+neSmEOsmEfwdCJp8UMtohAnLUgAFnDtgmRrmg465+A4332yB6OlOuxxrIPpJRSjVvNA3i2M8mqTdwbu4EfqyG/xOKl6TIarso4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eeW4D99XxL+J2gzoYvCyHrctwFrA60QYPh0z2yOz78c=; b=EouPwDPDSuIv4CNwIiBhKhM0r0S+UlnDgIeqruqxOA8WCEzgzusQRodqDZdSaq/KXMTD+xO+k338PwUnALosJodi0WcYPFVXIcDdEbAArhh5HPR/Uzmi3j6AAFBLwbfUKucek9qTZRrPuIaVVITHjLdnne00GPEgQfSWDqPubCpc7tG54QI8pxM22vCWxpWxF///z/UaBvInQn62G08PDG0EdXZNAlUxNt8zdKwhxLNU35hikZ/yZa7al2FtXxvOPsWAt2TBHzm7Kya2iY1OKbBaajyxwF42zpOP12dYAjHBqYF2hbyP8ZgzKqyLfuW5CxuM9O+A/6aR2ynTQn29BA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eeW4D99XxL+J2gzoYvCyHrctwFrA60QYPh0z2yOz78c=; b=MDqCmFt/AwGIVd7ArXJV3RDNIWBlC8xb22y6h2/ICIbR+1yULiPoU8c6EnIS9hl+981tGfQj1eRrAiTd+ZpnCLRZIZFfa/9Ag23Qt9qi5q9vuL0TE1ytcVKd00y6YBToQGGAvSd4DHV3fljgyUGrNCX9ts7/zCBPx2lIs+aH/6xUzRK3xoieZjmrkey8WwwpNHzQLoG5tYpORFy6eZTJZxW53OzdH+k0GgQeNtckSZwNPRN3/inW95PNHQGP+yMbA7BVoXY1q3Wd816+3/fTxlaX4fXnW42GLqkAGI+DnY2Yr8M/U05Mr0vnupfRpWVww19q3fSIUf69j/jjQlm78g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4b4f7eb9-3a9d-e4f9-809d-7c21726f77cc@suse.com> Date: Tue, 12 Jul 2022 09:36:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON for phys_to_nid Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Jiamei Xie , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-5-wei.chen@arm.com> <6b1b2694-d46a-7713-6109-99c98fdf6b8e@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0014.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2fc9b095-0502-4bd8-4839-08da63d93bbf X-MS-TrafficTypeDiagnostic: PA4PR04MB8032:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fVvvf33qh+Y114qKk+sG+/zJZ9U2U8+4uXoQ9uzTFohdmvqvuhKJL8mpMGuUq++GWmOBoc7axPxF/rJzV/a/GyXdqEeYwqGhoxy/p7KFn1QcIJlk28unjt+VuHO6fyEO7BFNNj82scJ0LyQ+1fCrwgi3oaiFN4JWm+wq/9Ql0Hpn23k6+i1LonDwqggGSRGDeaKF3lWX0r6iDa4X6qzNJc+QwFCuXQjSY/x7EQoN3BQAu0NkAWXw6VcyY4BCa157Kc3VeDyh88bwMQz0yv1FtKSKg7NAxNACJJ/zBJiSGGcS8HO5o5EHsOl/IvEQ0vkigZvZ+iisaVHBjTtcMg2+v7pRnUnFwMyU9tMZ4SjLOvrnZgC/aEfFMzQ3BvjxKp8vgewR/WqX49wSO3+RDE7eDQa60mKySsBaMRB0xE1yGsqh1M4/7PpnJoGE0K3AIoRbAxI0DXQvrAV78Ivy+IsUiWEfo6jvkJku1aRILq4HmOj6ymfH/PJtPxIEybatnwYcElC7T9/ufYUq86or04QPaICsHR7chUAWkL73RSbwaijFr9u/j+fgSlk4U8V6n4o28ydF+HwAL9x+vkUpqa/wkKtnM9gKVqLWjVEYvX7ydidfSMzM0sauilnRfrjFa9XdAx+2YGR8M+I9kdxOCE1Yx7WlZcoSL74jwnPPa61hKgbfuAYE7HPaFd5e5F3yfQvt6071kyytZCxr72Rpt86La0Kgrx0ADx6dHv4V7oTTppy0kSMmnrjGfkXj9mGmTjhwR2K8nSLhPQqoI089S9zfVN7wvZyIcqg6p7zOQLvURn+5YdACnogJ4wfDvVA7Rm2yW3QqMM3X+AnlB1gweh2JvszqclKXmwGiEdVRiCMpOl8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(396003)(376002)(346002)(136003)(186003)(86362001)(83380400001)(478600001)(66946007)(2616005)(38100700002)(66476007)(66556008)(6666004)(26005)(4326008)(316002)(41300700001)(6512007)(6486002)(2906002)(54906003)(31686004)(53546011)(5660300002)(8936002)(6862004)(36756003)(31696002)(6506007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjJyYmhCWmhSdElpYjdHVWNQKy9xaEdOalg5UVMyWG5LM3IvMEgzYWpLcWNW?= =?utf-8?B?dXFVWGNQM0gvSW53SUtoQno4Y0U2VjFoaVByWHg1MjAzTGhWNHZDdVhDUHpn?= =?utf-8?B?dElSS0FEalRCd2puT0RVN0EycGdvRGxVSFQwcmZlc0N5Zityb0MvWVlWZ0RF?= =?utf-8?B?L2o1YnFTVVBZNUNaMUpUY01Vc3VlZktuU254cHpCWkxyZzN0N2o5TjMwQjUr?= =?utf-8?B?RmpLSlVESzhkZWdSeXdwQmZneW5JWTBiZGp3Mmd6UnlVMXVBcFE1WnJsZm0z?= =?utf-8?B?S29QbmkvZU5SQnNjeWtHa0M0Z09adEVoMGUrc09tVG9VeFZQaU1VaHIvWldJ?= =?utf-8?B?RFFhNHlCYlI1TzA1Qzh0elQvQ0ZpQVJiNUFiNXFPSTU0Mjc0MzVlL2E2VVlO?= =?utf-8?B?c1QxeDhMREJsaWhvUkZvZUo1MER1QWhMVGFWV3NrQzczallxUStBb29VMUZp?= =?utf-8?B?MkxXMFRnR2prVzdHamRwbTROMDhHaHhQREF0MEY2M05UUXVXK21SSmdYSWcz?= =?utf-8?B?QTBUb3BVVmVzczdZZ3NDZmJhNzgzU2VXNTlob2NUendUZktKZ0F1MFB1bklV?= =?utf-8?B?anFIcU9HczN5QURsRzMzeENkdUlIYXMxdmI4Sk9MZjJmdFByWTY2NS93dTBX?= =?utf-8?B?dlh3ZWFtTk82MjRNRVFrSVJjMzZ6aW1oek1FMHBPeTZrSk9LaW5CODM5L0g4?= =?utf-8?B?dW8ydkp5cnU3MitDWlVXNXc3UHdXejVhU1ppOU80eEpSYlVXSHBhWUpSTFVM?= =?utf-8?B?VTBHeUppUW5UazNXdUp5U2lpbWFZZVFzc1BuWHdQSXV1ODlFTFh0RmxlYnB0?= =?utf-8?B?enRXQmozM3FVK0VRUWtxcUZMMVpJNTVXN0h3dkpTaFlwOGdCUklKY3VObE0y?= =?utf-8?B?RE5OQklqZVM5ZlZtcXhLNmZZMGJmMEd2WWdDNUJraFk4MzBveTZIUlltVFNi?= =?utf-8?B?WW44MWNtTGE4RHg1L0Vkb2VQbHlFSzNEZmh0b1VuWENOQkFlREZacDRjbW93?= =?utf-8?B?dGZtRmFCUlltOUNXM3Fnc01JaHNjdFRSUkZPM3hrTzRTTitvVFdsWDZGbU9C?= =?utf-8?B?cmVIR1hncXpPV1NMVmZYOFBUcFFkdUxrZ0o3djNUeHFSOHdGeFBPWSs2Z2pU?= =?utf-8?B?SWhmcVBMNFJ5RFd4NFVGbWN3K1lwZ3FKdytiTVg5eDJGQzhtQlF1V2xtaTBL?= =?utf-8?B?WS9XWHV6UWRKOWF5d0VZY21GSkMwUEFTZE9ZVDdEVVY2dzA3cGZ0UUdGVVNu?= =?utf-8?B?Mkg4ajhiN1VNd1I3NW9qT0pYNkpkMGVmSk5HNzRocVdhRTl1bDhJaElQMFBa?= =?utf-8?B?a0lmZFc1aTlHM25TTU4zSWwvR3dQTDFCSlNWRmp4SDJzc3Y4aythNFRlYjlB?= =?utf-8?B?ZWZBeGJGRTBEOWg0WVM3a3ZmejhEb1Y4ZVFKS25STDNiL0VsSlFydW9GN0VT?= =?utf-8?B?bTF0RzhRZmpnOVpoeXVPN0NsNG81RFRSR3U5ZHRsczJkY1JtMTdTSU9nNlQ3?= =?utf-8?B?WmtKTFZCNERSa1RoaThYZFNEYkJ3VmhxM0hNY0ZIWG1SMm9memRiN1EvRHZC?= =?utf-8?B?TzhQb1pDOTFUNWVKL0pwUnk1RmE4WTBFMzZDU2JUR00rcjV1Ky91bkovWktD?= =?utf-8?B?TEhlb290TUpHZ0hwd2VuYTFlMmJQaHZ6WFR3RFRrd0hyY012aEd3SjdkUEdC?= =?utf-8?B?WmZZSFpqN2FRbTJKSjh3NDZpeG5EU2JtaHNQUSsxRzZmL0NUZFB2VHVRa3Fp?= =?utf-8?B?MnQvWkZ4WlhNbFIwT21sTVdrcEFsSGRxNnJjYThNUGRsVWliYU1XOWRGbW9I?= =?utf-8?B?MDlWd3dBQ2dldmlja3dxQS93Ymc2YkJYV25yQXVLMWxVYkYySDdseFNMeUF3?= =?utf-8?B?RVl3RHkwOTdGVDZmM2dGUnBCL2o1U3EyajZ3VXNPTUxLVnVoVFpkVGNUQUxB?= =?utf-8?B?c3h5aWNFT2lHQmJoTzZWeUMzMDlCVy9pZ2tNQUt3QkNCRU5pK2NsVEVBd3lE?= =?utf-8?B?M2U4NUtwTGlqMWtJeElBVWJJR1JEdDdGZ0JKK3BFR0xTbXNxQ0hWZy80am5z?= =?utf-8?B?VEJqQTJCL1puZDJHaUtManowUDJQMWZhWVdUalFjazZYMnBtY280ZUc5OUlZ?= =?utf-8?Q?FU3ponAjhykumOx1j3LpYjMWt?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc9b095-0502-4bd8-4839-08da63d93bbf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 07:36:28.8884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pANDJntjUGEkZuiKXCYQcKvXCE6LJuGaby9jiLeq+yPD65aV0W0PZSaW5xzlMZC8i7/liRYwkGv+oLriGum5GA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB8032 On 12.07.2022 09:20, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月11日 14:32 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; George >> Dunlap ; Julien Grall ; Stefano >> Stabellini ; Wei Liu ; Jiamei Xie >> ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v2 4/9] xen/x86: Use ASSERT instead of VIRTUAL_BUG_ON >> for phys_to_nid >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> VIRTUAL_BUG_ON is an empty macro used in phys_to_nid. This >>> results in two lines of error-checking code in phys_to_nid >>> that is not actually working and causing two compilation >>> errors: >>> 1. error: "MAX_NUMNODES" undeclared (first use in this function). >>> This is because in the common header file, "MAX_NUMNODES" is >>> defined after the common header file includes the ARCH header >>> file, where phys_to_nid has attempted to use "MAX_NUMNODES". >>> This error was resolved after we moved the phys_to_nid from >>> x86 ARCH header file to common header file. >>> 2. error: wrong type argument to unary exclamation mark. >>> This is because, the error-checking code contains !node_data[nid]. >>> But node_data is a data structure variable, it's not a pointer. >>> >>> So, in this patch, we use ASSERT instead of VIRTUAL_BUG_ON to >>> enable the two lines of error-checking code. And fix the left >>> compilation errors by replacing !node_data[nid] to >>> !node_data[nid].node_spanned_pages. Although NUMA allows one node >>> can only have CPUs but without any memory. And node with 0 bytes >>> of memory might have an entry in memnodemap[] theoretically. But >>> that doesn't mean phys_to_nid can find any valid address from a >>> node with 0 bytes memory. >>> >>> Signed-off-by: Wei Chen >>> Tested-by: Jiamei Xie >>> --- >>> v1 -> v2: >>> 1. Move from part#1 to part#2. (Comment from NUMA part1 series) >>> 2. Refine the justification of using >>> !node_data[nid].node_spanned_pages. (From NUMA part1 series) >>> 3. Use ASSERT to replace VIRTUAL_BUG_ON in phys_to_nid. >>> 4. Adjust the conditional express for ASSERT. >>> 5. Move MAX_NUMNODES from xen/numa.h to asm/numa.h for x86. >>> 6. Use conditional macro to gate MAX_NUMNODES for other architectures. >> >> The change looks okay, but can you please clarify what these last two >> points describe? They don't seem to match any change ... >> > > I moved this patch form Part#1 to Part#2, but forgot to remove these > two change logs. In Part#1, we do those changes, but after we moved > this patch to Part#2, those changes are unnecessary. I will remove > these two lines of change logs. Sorry for the confusion! With this clarified Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 08:53:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 08:53:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365558.595748 (Exim 4.92) (envelope-from ) id 1oBBde-0004Mm-1M; Tue, 12 Jul 2022 08:53:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365558.595748; Tue, 12 Jul 2022 08:53:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBdd-0004Mf-Sg; Tue, 12 Jul 2022 08:53:01 +0000 Received: by outflank-mailman (input) for mailman id 365558; Tue, 12 Jul 2022 08:53:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBdc-0004MU-Gy; Tue, 12 Jul 2022 08:53:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBdc-00006l-DM; Tue, 12 Jul 2022 08:53:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBdb-0002Es-W1; Tue, 12 Jul 2022 08:53:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBBdb-0000NB-VW; Tue, 12 Jul 2022 08:52:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qsaR/zx8WZHPfVDzaH0sUzsTG7sN9oCdLkxM53T3Yg8=; b=27INTHb6BbknXtQJ2thd5OH4+R SnVSH8HwiX5CaQMszrQsT0NI6HaGnVsLW0NzTuJO9LB+PZZftGlJ3ZIll4pQLvu2kY7UKywYqM71m gtav+Ejb1p5f5Su5GqDIREVFlLdE7ee934SiyyaGMddOt/tICo9KtbmXMJQi/H2PhfVg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171586: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-shadow:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=27357c394ba6e1571a89105b840ce1c6f026485c X-Osstest-Versions-That: xen=2ce11ce249a3981bac50914c6a90f681ad7a4222 From: osstest service owner Date: Tue, 12 Jul 2022 08:52:59 +0000 flight 171586 xen-unstable real [real] flight 171591 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171586/ http://logs.test-lab.xenproject.org/osstest/logs/171591/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 171591-retest test-amd64-amd64-xl-shadow 20 guest-localmigrate/x10 fail pass in 171591-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171583 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171583 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171583 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171583 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171583 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171583 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171583 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171583 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171583 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171583 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171583 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171583 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 27357c394ba6e1571a89105b840ce1c6f026485c baseline version: xen 2ce11ce249a3981bac50914c6a90f681ad7a4222 Last test of basis 171583 2022-07-11 14:37:01 Z 0 days Testing same since 171586 2022-07-12 00:08:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow fail test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2ce11ce249..27357c394b 27357c394ba6e1571a89105b840ce1c6f026485c -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 12 09:08:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 09:08:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365572.595771 (Exim 4.92) (envelope-from ) id 1oBBs9-0006Ot-Pw; Tue, 12 Jul 2022 09:08:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365572.595771; Tue, 12 Jul 2022 09:08:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBs9-0006Om-Mx; Tue, 12 Jul 2022 09:08:01 +0000 Received: by outflank-mailman (input) for mailman id 365572; Tue, 12 Jul 2022 09:08:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBs8-0006Oc-Sw; Tue, 12 Jul 2022 09:08:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBs8-0000P2-OI; Tue, 12 Jul 2022 09:08:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBs7-0002cI-TM; Tue, 12 Jul 2022 09:08:00 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBBs7-0002jn-St; Tue, 12 Jul 2022 09:07:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k9wti8tVAx8gkwDd75NuHbRxbHuk8jCYsbOZviwe8Ck=; b=AA5wTJn4n9/LGXqLyuzlG2gFKc 8yAlckRydSzZbLSfpA49a3Jt0irqldLkFriZh6psOVmKKVOa0xe4LBhlbOu8ZjVVq1UHMOGrXI9Zx aG+45zTnY0U6UezG8d1sbiOyvundr4jrWI/ynyPNHRZGl4+GftPJFQU/9cWlsJ1DbcdQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171587: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d X-Osstest-Versions-That: linux=816e51dfb5ba47e4f989af656c956a8c0cc686c0 From: osstest service owner Date: Tue, 12 Jul 2022 09:07:59 +0000 flight 171587 linux-linus real [real] flight 171592 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171587/ http://logs.test-lab.xenproject.org/osstest/logs/171592/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 171592-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171585 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171585 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171585 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171585 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171585 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171585 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171585 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171585 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d baseline version: linux 816e51dfb5ba47e4f989af656c956a8c0cc686c0 Last test of basis 171585 2022-07-11 17:41:38 Z 0 days Testing same since 171587 2022-07-12 00:10:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Tomlin Adrian Hunter Alexander Gordeev Alexey Gladkov Alistair Popple Andrew Morton Axel Rasmussen Bagas Sanjaya Baolin Wang Christoph Hellwig Christophe Leroy David Hildenbrand David Sterba Dominique MARTINET Eric W. Biederman Filipe Manana Geert Uytterhoeven Gowans, James Ira Weiny James Gowans Jonathan Cameron Linus Torvalds Linus Torvalds Luis Chamberlain Masahiro Yamada Mike Kravetz Muchun Song Naohiro Aota Peter Xu Peter Zijlstra (Intel) Ryusuke Konishi Sven Schnelle Yanteng Si YueHaibing jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 816e51dfb5ba..5a29232d870d 5a29232d870d9e63fe5ff30b081be6ea7cc2465d -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Jul 12 09:10:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 09:10:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365579.595782 (Exim 4.92) (envelope-from ) id 1oBBuH-0007k7-8g; Tue, 12 Jul 2022 09:10:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365579.595782; Tue, 12 Jul 2022 09:10:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBuH-0007k0-4C; Tue, 12 Jul 2022 09:10:13 +0000 Received: by outflank-mailman (input) for mailman id 365579; Tue, 12 Jul 2022 09:10:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBBuG-0007js-0u for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 09:10:12 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e9c0ab8-01c2-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 11:10:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D2BD522606; Tue, 12 Jul 2022 09:10:09 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 93BE513A94; Tue, 12 Jul 2022 09:10:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TVSFInE6zWIkRwAAMHmgww (envelope-from ); Tue, 12 Jul 2022 09:10:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e9c0ab8-01c2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657617009; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=wO3BxdMkCLrjkHXmHzYdPQLBB2Xlr4RLHiKYMmMx3TE=; b=tl3u5V2enh1PRdYkfPSQXyEAa4iX7VAKhdTKpsWzvi4BQ5ynVo7cC4W2zNtX89gJft7qNi AnN+t3sog4ytg5Y4ffuWYEDs6J4Zv3vH0EXLU7Hn0h3+Wh+1mbP5KSkjGj+cBW8aNOw3nO Vf1UEp/c/rxfx5IeGE7aKofOB9keFsU= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v2] xen/build: remove unneeded enumeration in clean-files of xen/include/Makefile Date: Tue, 12 Jul 2022 11:10:07 +0200 Message-Id: <20220712091007.13595-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enumerating a file from $(targets) in $(clean-files) isn't needed. Remove hypercall-defs.h and headers*.chk from $(clean-files) in xen/include/Makefile. Reported-by: Jan Beulich Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") Signed-off-by: Juergen Gross --- V2: - remove headers*.chk from clean-files, too (Anthony Perard) --- xen/include/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen/include/Makefile b/xen/include/Makefile index 39d9f5556c..65d61fc7f4 100644 --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -224,5 +224,5 @@ lib-x86-all: all: lib-x86-all endif -clean-files := compat config generated headers*.chk xen/lib/x86/cpuid-autogen.h -clean-files += xen/hypercall-defs.h hypercall-defs.i +clean-files := compat config generated xen/lib/x86/cpuid-autogen.h +clean-files += hypercall-defs.i -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Tue Jul 12 11:54:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 11:54:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365627.595892 (Exim 4.92) (envelope-from ) id 1oBESm-0000bY-2Z; Tue, 12 Jul 2022 11:54:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365627.595892; Tue, 12 Jul 2022 11:54:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBESl-0000bR-W9; Tue, 12 Jul 2022 11:53:59 +0000 Received: by outflank-mailman (input) for mailman id 365627; Tue, 12 Jul 2022 11:53:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBESk-0000bL-KU for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 11:53:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80081.outbound.protection.outlook.com [40.107.8.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f11b256-01d9-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 13:53:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5499.eurprd04.prod.outlook.com (2603:10a6:10:8b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 11:53:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 11:53:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f11b256-01d9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OPbfYdhxewTuzkcdm0w6HkfOIS8+QyUMXppQ0w1mviK3M+oGQI5bEasNDtQBTeVEQTsq0rCfiyL8WY000jQVaEOzpsXvNGXT1atGI88IJ6OBGBJ5ugJfTqpV2vwHGc2QRRkYG1CRghKu/6Kb+i0foXWsuA543d8LAIurXKzzJgfqs/WZpaEdrgyXx2QuFAPuocEojEm6DuA2YV2eOgnsNNS6t+Ea/QlNGPvI8kJWhn73pUiwBSC0fyxibAGTYthKm063B4EjsyILiWOJizziVP726Kcp0h1BESOkUhVpE/uAkmykDnriGeJMSbFovA03fQNG0Pg2iFWtME4R8i+zpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJ9M9gmzl8bQZRaKWfY14i6pKfIwrPi7ep9GBp2G5d4=; b=jXbBQo3Q44r92YX1Zxapie07meZO8/JXZF+x5BB0CWkc+kI2RZggGZsXmqAS0GfY/VZOR6s2pv47J7vVRZkZdiFdhiLc4wJpunU7AhzyOljUtYmrl/ESyePEf6XA4PedKnBTlDi5buRq6/25yNJQzohqFDVAQx9NYSE6URZJuAdry+Ptn7QGA9FcoFVe9KBq0xieJnf3elcsgnbEVwp38dAxjOydorY1AK/mUV6BH1W1dSMPkQ32tXp9dUCiMthkCzDshLAYbDtrZjqc10xJneyO35A4WwQ6fDgFFyi0Rh93jF9JsfGVHR+74BnVbgcXpwer0HJy5OKERia9JXMDwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJ9M9gmzl8bQZRaKWfY14i6pKfIwrPi7ep9GBp2G5d4=; b=VoOygXDENzLUvFY8F8La2GeamyH7ukqDHCBE6vrlnDskmcKjU8h57gJi4dGikf3WUs+o2Js/1NtTtThwoUTE89jTqSsxcMhHiEM4HmsNYvjDtEARQzYvt634dF89QpFjQbAfUAmOHHSMuOupmm32tjizF4M6jMQtR9FAaCmeG/Mp19DlX9UZkKn1WLjPaxrTYAPn1eE9clwwwHHBm0dEhCWN/S8WaK5GkXMo7vz0koWsDzMIE3UpdLdMZjoYWAD2keS09ejN32NPqZ6oFopxYj3EqS9uefaYwP51xPGPFR4Uokwyu6I8ieRqpLwrISZzzqhSujHYxjZ8MsnYG1Dn5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> Date: Tue, 12 Jul 2022 13:53:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-2-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-2-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05de8486-76d3-4c01-e5ee-08da63fd31ce X-MS-TrafficTypeDiagnostic: DB7PR04MB5499:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zJC3l63rHNRhTRKL4/obSFgQax6QkHQKChQ7hJ4lcVAm/eZHgyWLdj/nNzoVObk/y4qb8dGtrBAfi2hJa8SVhmC2VdQZbexAHUqlcz4b/V4GLdEfnBhaHD2pUNCqt109EPMZ3z/yA4t36iTlQwS/qiIadZ1VjFCJ8V6pFFbrnv3kmFDS+Anr3n24pmfWlxYu0sTrBd8v+IcKelGDsWq00JDvzPLH6KU5gwwrPggNaWZHqkh4YXizfDO+x1A6ApnFD0Ywq5rMYFptsPrvcTxskO1xFA5iEmvGiaylv9aBNuuH4sG0IqMQUS6cGPpYW4IPh099W8JfJeDtexuMzZy+KAZmf05/CzXJqPKTNBdk0/n2/8gEgvmDdRDNklLzUPzRrfrluGZ6JhUeD75kNr3bUemXESEzXzjJ8nAfacy1MMdwcJr++vSq2tJVP77P2o+LERhPxQJ/QmNvV2sPpZiVdVDY6wL8tRXSr4V3PWpBWr4BoFArpV/elD4QarE0k3YtfHBj1NmR4vW4hY7tmXHKGyXrWaZKqrw+b3TkGoqBugs6EWU1/gJnUgnaOQJ4tVvpoSFuzG2b2Ly0eh2bTOW7iptuS4D8tRtjudzh6rEHFCPLbi+ELlJ0bexxJ/XDN5GWa+9m8UcN6aPEP1J3jCmD8+APLa/wu0n/VtJrHVFNzRrhHoqo5GkdebA+zTf0s74yXH59escqPJF6jg3uO+9wmi561Slvmni2iYLFcDZZ5hw4c4l8ojK1KfURBZlQxPMd/08Db2i8q+u7q4fvkUPjmvdA5WDB3FQgnZ/RRIbx+Unz6jK8t+kQG4WaZ/v/s8OL7d01msTMqCQvmlxcPGQnTMfR/nKRJ68Jrra9UmPijyE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(396003)(39860400002)(346002)(478600001)(83380400001)(36756003)(31696002)(316002)(86362001)(6486002)(54906003)(2616005)(41300700001)(53546011)(6506007)(66946007)(31686004)(4326008)(6512007)(6916009)(66476007)(15650500001)(66556008)(8936002)(8676002)(2906002)(38100700002)(186003)(5660300002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXFTZ1N5RXRtSWNNdEtob3dFdndEbEE3QysvNWdMZXdZUEpuOUwza0FDZUZr?= =?utf-8?B?UEFlYnZNQm1Qdnc2MnBhcmNaWWlYR1MyaWd6OUNYaEhKREZpMmp5ZU1hTGkv?= =?utf-8?B?MGlubmZlcHJON1NzeENZaTArdDFFM3FwSDY1QW11cGZVbE5GbUJKb3JyN0VY?= =?utf-8?B?bXRwcVBEWmhLTmRZMUFCMHYvNTZCbU9Ra1JSNnZxbjZQOXprTFVmeElOa090?= =?utf-8?B?aVVVTE01WURNdjlvdXNRTzNIMlpxUERxL3BDalJEanFISW1GQjYwNXE2RUlj?= =?utf-8?B?MFhsT20rTW0vVFMxL2xTZ0ZLN0NlOU9QTDc0K2xsUWlHYS9hVEZaeDhiODdX?= =?utf-8?B?YTduVzNsa3o4THVnV3gwcW92MU4zclViV3Y4UUVKRFh6U2NNeVVqelFRMDlR?= =?utf-8?B?L0tPRmJaNVBQQkNPUzRkbTA2UHIzUkpZWmZOa3B6RFcrQnJDR0FVU0NUK1Zm?= =?utf-8?B?SzRsazcyL3dZYWJ6cjRXNVArUVQrU253STc1SmxwL3czWEJTVWVrTGJWMThO?= =?utf-8?B?YTdZTHFqNkxGTlR6Qk1WWU1TNUFIcEpiOWZSeGQwU3dRMldBbWd6UDEzNGZW?= =?utf-8?B?TWlranpBUWpscllBb1V0dmZLd1dxbGtFSzZwQjNFQ1kxOTVweC9CbzJpSllq?= =?utf-8?B?VTFtS1IrZkRqV1ZxNEJiUHB0TFRiTWlGUTJGd2hiNXZWTSt2WDhweHh4czhh?= =?utf-8?B?N2crb0ZhOEcxZVFYRko5QiswUzkxK1hSS3AyZXlPZWFhbWltWDRUWVM1aDQr?= =?utf-8?B?anVZRHdodTYyRWdvb1N5NlVDaGozVWRKU3VKRXBBaGRmREl2QWVvMEV2WjFO?= =?utf-8?B?SUhGS2xEb1MzQTVXbnV5TWtPVmFLZERMbU8rM3FPbHg5T3hoVjFlcndFZTB5?= =?utf-8?B?Sk42K0pRbzhRL05MMmJrQzR3RnB1WjBjRlV6YU00SVF6Wmt1L0QzRHBIYkMx?= =?utf-8?B?bkpOQnJYMDJGT3FRRDdTUDVNZmtaQTVzdHdmbEtScDZDMnltTmZNOXY1VFkr?= =?utf-8?B?RzZlOVpvcHBxZjN5bmdZbnFZV1VqVmdlQXprc09rK1lVUnZqS1laU3c1WnVV?= =?utf-8?B?QXdtd1pEK3RYVzQvbzNtK2NNcEVHOGE0UnYvWWVBcktrcU1OQUZqckZwSVdY?= =?utf-8?B?NmVwT0ZxMFVqVStLTVIrWmpDMDMyZHhRcWdaakFidVd6bURsRWFkSktORyt6?= =?utf-8?B?dDhrbklzeHZKYklFQnp0VW0wUXluSTZuQnFNS0dKYTMwMWs2dHRQclJORk80?= =?utf-8?B?SmVKdzRYa2R4OU9SYXR1SENWamEybm8ySllCcFRVS25nUzQ1VEVLYkovWGR1?= =?utf-8?B?Y0pNS3lHc1F3OG5wS3htTFZuWnNVclRvclNEd2ZFeFRpVzJFK3BkT0JyeVBh?= =?utf-8?B?RGtRMXJwMDRqbStkeUlKVEVGRytRQ3c3RXpqMUd2UHdqNVBmaHBLY29DUjJ6?= =?utf-8?B?Y3NwajV2MzV6MEdiOXRhQUZtTVEzRk50Z05IOS9rVnQvRTNLYXZGMXE3QklW?= =?utf-8?B?d3pFSVdxczRjd0hqbW5QSzhwKzVlRDhlTFMwcVZVemZTZ3pDUjgyMWh2Sm1N?= =?utf-8?B?SkdJWjRZY1VGV29wZ2lXRFVOUmhEQS9BMUtKeXRzcy9kbERwU3R2bU94MGg1?= =?utf-8?B?bk8wTzlOOUd0bERybWpTdTNYT2EwcXNSTXVDcmQxYzloVXRqN0VQUHArOVdB?= =?utf-8?B?RExnQXMvVTk2WkFOdTFHZGVOTnU2Z0cwQUhCY0pnTmRPMjd0a09FMzZiQnE1?= =?utf-8?B?aFJZVjVrR1BiQ2RXQmpsWGw1eVRVYk4vZDhFMWZKWUx6bm1zOUE0QWd1QVoy?= =?utf-8?B?YXZlcWRiNWxiN05IUzMrSGtRRWJqRnpwVm83UStleHVqbWR4Y2tHYnZnVytw?= =?utf-8?B?NXB5MUdzaFhCSWM2a2QxeVZESmM0UTJQcHNseFhSa2duZ3RaM21md29lc2E4?= =?utf-8?B?K29YQTNrc0hYOWdnVFdMdTJ0K2dYQjh6eWxYYjJNMThBbUdHVis4bmNyZWJO?= =?utf-8?B?Zk1OR3J3NU1ETVJqa1Nsa24zRE43bkM1bjZ5OWsydlZwTTVWUkppL29YSFFL?= =?utf-8?B?ZXRmd0ZrWE1tZkRDL3hYUnZSUE11ZloxbkNrcGZSdlBWdFhOLzJXWHM4WWox?= =?utf-8?Q?aBB7I0X5pJ6aoPJZhHxWn/pk0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05de8486-76d3-4c01-e5ee-08da63fd31ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 11:53:54.1271 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z/rrVJKBNw1MnAWASaYSN6F7YPRERCVI/1cmSnzn5EoqYOovQ4Tt1JTi7a5xUH8ES9X+xiW+Hf3OAQ9o9WvorQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5499 On 08.07.2022 16:54, Wei Chen wrote: > x86 provides a mem_hotplug variable to maintain the memory hotplug > end address. We want to move some codes from x86 to common, so that > it can be reused by other architectures. But not all architectures > have supported memory hotplug. So in this patch, we introduce this > helper to replace mem_hotplug direct access in these codes. This > will give the ability of stubbing this helper to those architectures > without memory hotplug support. What remains unclear to me is why Arm can't simply gain the necessary variable. Sooner or later you'll want to support hotplug there anyway, I suppose. Mechanically the change is fine. Albeit maybe "top" instead of "boundary", and maybe also pass "node" even if x86 doesn't need it? Jan > Signed-off-by: Wei Chen > --- > v1 -> v2: > 1. Refine the commit message. > 2. Merge v1 patch#9,10 into one patch. Introduce the new functions > in the same patch that this patch will be used first time. > 3. Fold if ( end > mem_hotplug ) to mem_hotplug_update_boundary, > in this case, we can drop mem_hotplug_boundary. > --- > xen/arch/x86/include/asm/mm.h | 6 ++++++ > xen/arch/x86/srat.c | 3 +-- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/xen/arch/x86/include/asm/mm.h b/xen/arch/x86/include/asm/mm.h > index 07b59c982b..b3dfbdb52b 100644 > --- a/xen/arch/x86/include/asm/mm.h > +++ b/xen/arch/x86/include/asm/mm.h > @@ -476,6 +476,12 @@ static inline int get_page_and_type(struct page_info *page, > > extern paddr_t mem_hotplug; > > +static inline void mem_hotplug_update_boundary(paddr_t end) > +{ > + if ( end > mem_hotplug ) > + mem_hotplug = end; > +} > + > /****************************************************************************** > * With shadow pagetables, the different kinds of address start > * to get get confusing. > diff --git a/xen/arch/x86/srat.c b/xen/arch/x86/srat.c > index b62a152911..f53431f5e8 100644 > --- a/xen/arch/x86/srat.c > +++ b/xen/arch/x86/srat.c > @@ -418,8 +418,7 @@ acpi_numa_memory_affinity_init(const struct acpi_srat_mem_affinity *ma) > memblk_nodeid[num_node_memblks] = node; > if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) { > __set_bit(num_node_memblks, memblk_hotplug); > - if (end > mem_hotplug) > - mem_hotplug = end; > + mem_hotplug_update_boundary(end); > } > num_node_memblks++; > } From xen-devel-bounces@lists.xenproject.org Tue Jul 12 11:55:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 11:55:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365633.595904 (Exim 4.92) (envelope-from ) id 1oBEUB-0001Cw-J1; Tue, 12 Jul 2022 11:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365633.595904; Tue, 12 Jul 2022 11:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBEUB-0001Cp-FG; Tue, 12 Jul 2022 11:55:27 +0000 Received: by outflank-mailman (input) for mailman id 365633; Tue, 12 Jul 2022 11:55:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBEU9-0001Cf-Pd; Tue, 12 Jul 2022 11:55:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBEU9-00044T-KP; Tue, 12 Jul 2022 11:55:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBEU8-0002yv-UN; Tue, 12 Jul 2022 11:55:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBEU8-0002Jn-Tt; Tue, 12 Jul 2022 11:55:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ewNzbL5vB+hIpdmGRjli/YCuD42pUS6UjzkMiC11XrU=; b=b59frD2Z0P+BQbgnNxF3ZP5Z8k WZkcX2Jshy2RCSRnxC88cCeg44+DFnOWcta1UzX9vdGErXivjvwAJwU7L/rPXapBbipW0eDrnQIZk MngD3CKQ3A6vjAbWe12nKwqZZ/Y5ArJeNu3eTvp8M8LtU2Pyn8Uc/7R4Yt7TWEDXXUbo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171589: regressions - FAIL X-Osstest-Failures: libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=7cd8f51b97d38ddf7039d64c371cc3dd8c605bc1 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 12 Jul 2022 11:55:24 +0000 flight 171589 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171589/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 7cd8f51b97d38ddf7039d64c371cc3dd8c605bc1 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 732 days Failing since 151818 2020-07-11 04:18:52 Z 731 days 713 attempts Testing same since 171589 2022-07-12 04:20:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115578 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 12 12:30:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 12:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365650.595914 (Exim 4.92) (envelope-from ) id 1oBF2K-0005wt-Hi; Tue, 12 Jul 2022 12:30:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365650.595914; Tue, 12 Jul 2022 12:30:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBF2K-0005wm-EQ; Tue, 12 Jul 2022 12:30:44 +0000 Received: by outflank-mailman (input) for mailman id 365650; Tue, 12 Jul 2022 12:30:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBF2J-0005vq-NS; Tue, 12 Jul 2022 12:30:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBF2J-0004pC-ME; Tue, 12 Jul 2022 12:30:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBF2J-0004iG-2Y; Tue, 12 Jul 2022 12:30:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBF2I-0001qO-W9; Tue, 12 Jul 2022 12:30:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=t188d9qqxpbbDYnIL6A2q8Qv029TcEGLIpWwjn68y2w=; b=WjYV6PZagSdeMcchEMjzB7dbjE OxjhUB37DLRtSMWP/Tnny+v+gXL3y0zhiGWHkcvBQjVTZFmzaRxF7ihwxPU9Eb9mfTH+U6UpZo6Zi 8LsT2EuApdJFWh+Q1toKFexVcmBACU7qCr3VD/WL1r33+MrxvwUD2OmX38dqptxUH3BY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171590: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=dc7da0874ba4e8fab4c5783055755938ef19fc37 X-Osstest-Versions-That: xen=27357c394ba6e1571a89105b840ce1c6f026485c From: osstest service owner Date: Tue, 12 Jul 2022 12:30:42 +0000 flight 171590 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171590/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen dc7da0874ba4e8fab4c5783055755938ef19fc37 baseline version: xen 27357c394ba6e1571a89105b840ce1c6f026485c Last test of basis 171584 2022-07-11 15:01:38 Z 0 days Testing same since 171590 2022-07-12 07:01:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "G.R." Anthony PERARD Demi Marie Obenour Luca Fancellu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 27357c394b..dc7da0874b dc7da0874ba4e8fab4c5783055755938ef19fc37 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 12 12:49:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 12:49:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365659.595925 (Exim 4.92) (envelope-from ) id 1oBFKI-0007ob-2o; Tue, 12 Jul 2022 12:49:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365659.595925; Tue, 12 Jul 2022 12:49:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFKH-0007oU-WA; Tue, 12 Jul 2022 12:49:17 +0000 Received: by outflank-mailman (input) for mailman id 365659; Tue, 12 Jul 2022 12:49:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFKH-0007oO-5Q for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 12:49:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70078.outbound.protection.outlook.com [40.107.7.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09518cd3-01e1-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 14:49:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5071.eurprd04.prod.outlook.com (2603:10a6:803:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 12:49:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 12:49:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09518cd3-01e1-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlexC6lYarPcz3BJF9iWkIso2e3d7sxQEb30RDVO13s2SDA6jZbqRvX/A4oqx11HiUypBBKWOOFL8ErQqYv1gsLFJu5UH6A2hE7g6zENz6AJQCndsGUYvLxCZAbbEG1Ik0HC+sNyAGcYiL6rNbVTMzAnK+5Wz18/Jdn3qN7S+GZl+ciTNtBj44XAuDWjcrAbQLJGZIW/ug4k1GjP1DHNkf/lOCuEie6n6uY331G1l9b6Q+9x6cftYH+8h0xGCD8f7RyE/dnM1T8gnf8byVaWPBP/ow2JXy9QF/uqso1oXfNcJ9muIGzk1vH/GVTyQLIPknrel3fyIKGSnXm8ckkhvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/RXziFGEDE5KmXCAwkKSJTIL1pSi9NrvrEVWZQIQVE=; b=Vv2JX4agEYdJTmcEUbvR6QLRrb0ttSa0W3gx0uYVNbZUdL7ah0C8tZCaDHtRf8ER5tE9OqASf2VWSmA7na0e1V5Fubwd82hfVBL0cYry3tivBwRoxTLMvTwK/y0MHTO/6Bwa+XbdDFnOj8JV5hCi2JPfBjyhrKfEClDz+efb6IpRetztUH+lvmOcGxxuE85lOuoUBpfg18wiyLJzi88p2adoxKErChraXZUtg7okLnIABml7qDEefpY+9rqnnxrxFQT6c2HVXqrcbZe2k1YyqGCqcnTw/XSXqnAFBt9lOgMdRQRujyADnwNmg04p85iHrhcNTaqA1CiQ+wruMNT47g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/RXziFGEDE5KmXCAwkKSJTIL1pSi9NrvrEVWZQIQVE=; b=FB8OxuMgV2KQewMTK9VBdtokpXdVTWvupG+HfLpJHPFp6aqBNF+kDy4n4LatfFEG+ICisG1b2/RiT7UGFdtqbfRLZgxMYXm1gm8H/LlYgqxZ98bXsX0xR5WcjcGYp/xSLlJxYjn/ORpugtopcVXgi8fctjn5sK/pLmpYvqB9ix3dWkxpoz8WOoE8DazJ0oUuJkkX/LN2lyBLZzUymTX5LZjV1tgDH/RXxzd9q2odZW4oNjVhJJUdgqYlWEoigYwMyDsUsAK1OgGwJF4/NFI32jNX4rFq54rFFXH0TlFfrYVoJb03TBgUUjL1vL3pKpxwR2hmTpsb59aaDqJiKuJJkQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 14:49:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-3-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0081.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0a553eb0-f1cd-4ea2-0f88-08da6404ec98 X-MS-TrafficTypeDiagnostic: VI1PR04MB5071:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zBuuLf10ukSwjzZVvihslLKW7/Dt+x7jU44omHJX46RVH3tp8kV03GvBt15t6f2SIFjjfF5dQNRJc202B7/G3t6i015tWKSIgfTBvJVhvol3YXIBSKY1N0samlBglC9cH5CrWFQh4kIUHK+07cFl0aSBIQhxy5bf0gPczGa/dmLWjdFHzoAfGuxIJfcMkbr4/jYSqVK+EHz+t7++GT0oPxJ3jLojldVusdnmMvvNNds65GUbAokUcTC6qS5twyFY0rWcyLqt54QXLBZg1vo/cMnMqal9p7JrLP9JxTy9hxCRXVe4JzCehBXCunXsIQQ7/jYLQkrtvXj0LoMcT1LEitdSoBwJCUAKu0J4JbJcO90ujcvwP+VrgEBwlpTsQcKlg4svITJfTJ1sUAj/1M8NCk/rLgMN4D4ENyRSMzxUC3mZ3ZvOM2qf5KYKJWvc68nlGTi/a+Fgb7c5lXev/obL7Amkkxm5dXVhvZQbdam5e5q5TINPW780yqxOrHgMhPrTErwYPd8Ip4zTx8ubFeHTKxSfVOhSyjfaRW/4MS9gTb/9F4NE7rrG+6SpuyzSqg1KJuWiTj4xJZDcdujlEOsrhf8exnVRz+Ib2arx5RVXiu8Yzsn6Gq3WSEcaWQdMGhlSOcoZQctsufdEPtjTAyQ/8LfZE6eaXqI5k/jNCy0W8m8SCIi0OXTXQ/xCBZ1z2QQB9mAeauW2qOPAWv2k8nSh7QdyopSH9y2rVh103fAAPrQOZTU5pnz1Lu4tB9vxT2J6QH5a98eWrd97YLygopfJnpPTwbM6DbedOsvS1V+I0bhmcAF0YwbTFtf0rL4HQ8X1A0VsnQPv1AAxQnUf9re4KbKrbP77Ss7w7Wz9ldF7Jkk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(396003)(39860400002)(366004)(6512007)(86362001)(186003)(478600001)(53546011)(83380400001)(66946007)(6486002)(26005)(54906003)(31696002)(2616005)(31686004)(6916009)(6506007)(8936002)(36756003)(38100700002)(316002)(66556008)(4326008)(66476007)(8676002)(2906002)(5660300002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UXp5TjlBb2YydGlVVjExVnRLUkZMenBnNFpBb00zUnU3eXNIQ2lsMGVOanZZ?= =?utf-8?B?UTZvWmo5bEJJbXFRMmJGNnpNNi9QTUtPOGdIYkJGUk5OUENKRElQOTA0ejk5?= =?utf-8?B?bFkraTVNWjA2WWV0YWFHL1doN3RKdUlVbVk4V1E4dldwMFNZL3BPZGk2ZFd5?= =?utf-8?B?dUhJcGM5cmZPNlRjcld6K1prbEs0U1RyeFRiT3pVOTVnMHpWRUpvUkpDWEx3?= =?utf-8?B?aUVhMVcwUUsvQUJvTDJIcHpFc1JPOXhCZEtLdG84OG5FYk5CUWJKUURySy9u?= =?utf-8?B?a1pPd0k0VlFDYWNJNDNnVFdESmhEakxYRW8zM3N4cm04ckRQclBkYmF5RHZZ?= =?utf-8?B?RGpFR1pwOXZ6cVJBL0UraGVhSzAxbk9JZ3NYUjNvRVo5R3dKOURBY3hQV0w1?= =?utf-8?B?RDlMdjFmdHJBQlhpU3BBR1loeEFBKytlRERsMllsUEIwdWxBYWRpOXFNSkVR?= =?utf-8?B?ZkNMUTF4SWhvZnpoQ1FSYytzOC9KWUxWcnFhRmZFcElqNHN2OWJLK29JeEJ1?= =?utf-8?B?Qjc5SUFiTjhqK2Fqek4xMG9FSXZrSE1hZUZSK01uTzdxbnFyNVVsWHRQSDRk?= =?utf-8?B?SVJvSUZnRjA5cSszbDhDTTZsSCtadm5WZ1lyS2YzNjU4ZmJCdk9HSXZCUDYw?= =?utf-8?B?NGNpMTloWmlOTXVIeUlrYmhXUVFqL2Z0QW9IWDN3WGZ3RDNDdkF3SDU2aEU0?= =?utf-8?B?MjFaSTV0MlJtVGZ1ZEQwd1BwY3J2TlJicWxSRG5NWEhmL0FtdnhNMFdyQVhS?= =?utf-8?B?cWRXdHJTUGFIaUNqUGhZUmt2WTdRR25HUDRhR1I4bjhtUUFiTmZRTEJCSmlS?= =?utf-8?B?cGY5TzBGU3lob2FNeUxwemFBYkVrWkJoT2d4Y3hKd0dZazdrZUhQVDd6YVl6?= =?utf-8?B?RVhybTBvalh1am96aUVjTVBiNzJzbHRHbS94MmRWTG9mZXU2OGhYa3hZR1RE?= =?utf-8?B?ckVuZzJFVjNaNXIxYmM3T05TSHJxbm1SVjVJVjM1UGRha2dDQys3RnJ4a1hU?= =?utf-8?B?UmpDa3dYemJ3d2hwb2VpaXV6NmQzTzh3TVEzQjA3YmNFTmc2TkYrbGxRTTZI?= =?utf-8?B?RG9tWkQxbDJ1ejhzbWhoeERtbjZEamZ5cjJvdy85eUxlSURyTStnQ0U3dmkz?= =?utf-8?B?ZXd0WjJ6MWlXRGpCdkJ6Zi8xVGRCUDhXTVYvSGhIb2RyRXVPelNQNDZ6dy9T?= =?utf-8?B?VTVvbEVrMlJ2KytZMVl1ZDA5VFZiekM4UnNUY0hWYTYvdnlMU0JpcUlrY0Rs?= =?utf-8?B?aTlaRTBOcGQremNCRDl1S0JrWm1hYWQrWENlenNtaStma1FTUVRVcGltUTZa?= =?utf-8?B?ME5uY2IrbWhJTmE4dnJiQzlDcDFZRnh2THVmZUd1bEpzZkxOUk1BTGFtVUxC?= =?utf-8?B?WTFjZXVWeVM0Nnl4RkJBS215NHBDWkZKaFhYckRzNTlOTHAwbG1kU1liVkJq?= =?utf-8?B?YTFaSzBBck1yYkt5QjRXZXdkekJ4TmxFaGIvKzFmbSt2cDBqenkrc3F4THh0?= =?utf-8?B?WmE2OWMzcHo2S3pxeFZUTDI3UStqSXBNcHZndFZqN2VCVU9Uellia3h0WTZF?= =?utf-8?B?dFlSZUtQRERrbHpFRUMwWkRCbExBTjk0UzgvS1VtV21XQ2diL2xrb1RWakRh?= =?utf-8?B?VHpBbHhEVHBQOFZrSmp3cFV6NC9yL1YrZWw3cXpzbWlWall4MThZeDZHKzV1?= =?utf-8?B?YXhaYjhraVR5Mko4c2xKRFFWUzArdmdSb0hrUjVnTnFPdk4vd2pjbjlhZDFY?= =?utf-8?B?TXpxUURWZDB5a1hmMHYzYjRGUmFhWU5FSW9sbDNDN2o2ZUc1S0dJQmpmaEdh?= =?utf-8?B?dnI0UU1hMEF4U2FObVl3cnRNWERzUlNlcW44Ync0VDhTNHQ0VE9GU2N2eWhz?= =?utf-8?B?aElHbEhqcGZNS215bGY1Z1cyUHg1V1RJWkwwTUtXTURPRmlRSXVBU1R4c3E0?= =?utf-8?B?R3M1WjFEMGdYMUlHS3B5RVFTNkRkVWhPdkx2UGxvQmN0SFhjeDlRN3h5WjNN?= =?utf-8?B?ZWFCdmNyb2ZsZGQ5Q0p1ak5hNlYrTUdRNVFWOHNFblQzSEJiTGsvT1R3ekJ2?= =?utf-8?B?L2l1QlY1clhLN1RteVVQaTc4V1FsdnlLbkJjbGU3Y3NaY1Z6R3IzM2NvbXpJ?= =?utf-8?Q?QImUz7EuwkYNua/TqVoH+nmCK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a553eb0-f1cd-4ea2-0f88-08da6404ec98 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 12:49:13.9787 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BdtoGMDj7tHMCBhwFcHJzGrtjka2aX3lnjHqMUBGUf2iyCFWBT3FcLjotXJuOM67PRYwNfni/FzOZn7F5cl0BQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5071 On 08.07.2022 16:54, Wei Chen wrote: > In current code, x86 is using two variables, numa_off and acpi_numa, > to indicate the NUMA status. This is because NUMA is not coupled with > ACPI, and ACPI still can work without NUMA on x86. With these two > variables' combinations, x86 can have several NUMA status: > NUMA swith on, > NUMA swith off, > NUMA swith on with NUMA emulation, > NUMA swith on with no-ACPI, > NUMA swith on with ACPI. Hmm, with both this and the actual change I'm not able to convince myself that you've expressed the prior combinations correctly. May I suggest that you make table representing the 6 (I think) combinations of original states with their mapping to the new enumerators? (It doesn't need to be 6 different enumerators, but all 6 existing states need a [proper] representation in the new model.) As an aside - I think you mean "switched" in all five of these lines. > --- a/xen/arch/x86/include/asm/numa.h > +++ b/xen/arch/x86/include/asm/numa.h > @@ -28,12 +28,22 @@ extern nodeid_t pxm_to_node(unsigned int pxm); > #define ZONE_ALIGN (1UL << (MAX_ORDER+PAGE_SHIFT)) > #define VIRTUAL_BUG_ON(x) > > +/* Enumerations for NUMA status. */ > +enum numa_mode { > + numa_on = 0, > + numa_off, May I suggest to switch these two around, such that "off" becomes the meaning of 0, potentially allowing ! to be used in a boolean- like fashion here or there? And please omit the "= 0" part - it's only non-zero first values which actually need spelling out. > + /* NUMA turns on, but ACPI table is bad or disabled. */ > + numa_no_acpi, > + /* NUMA turns on, and ACPI table works well. */ > + numa_acpi, As to the names of these: In the description you already say that you want to re-use the code for non-ACPI cases. Wouldn't you better avoid "acpi" in the names then (rather than perhaps renaming these another time later on)? I'd also like to understand what useful state "numa_no_acpi" is. I realize this was a state expressable by the two original variables, but does it make sense? > @@ -528,7 +528,8 @@ int __init acpi_scan_nodes(paddr_t start, paddr_t end) > for (i = 0; i < MAX_NUMNODES; i++) > cutoff_node(i, start, end); > > - if (acpi_numa <= 0) > + /* Only when numa_on with good firmware, we can do numa scan nodes. */ > + if (!numa_enabled_with_firmware()) > return -1; Nit: Perhaps drop "do numa" from the comment? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 12:49:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 12:49:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365661.595936 (Exim 4.92) (envelope-from ) id 1oBFKQ-00086Y-AD; Tue, 12 Jul 2022 12:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365661.595936; Tue, 12 Jul 2022 12:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFKQ-00086O-7N; Tue, 12 Jul 2022 12:49:26 +0000 Received: by outflank-mailman (input) for mailman id 365661; Tue, 12 Jul 2022 12:49:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFKO-00085X-W3 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 12:49:25 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cbf7487-01e1-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 14:49:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cbf7487-01e1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657630163; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=97VMy++h5+CgzdPEaunLqaxYHyKe++R8HABn1HeQKXY=; b=APgNo77V6D3orD0/83Jblo2CaT2FzCWs5NQl9PZJ1cOt/MKDWl5VqIkp lBNPEjRfGVnvh//ADyEuELXrelimNMY9wRp8QR02vvYmpI+Yr2kJWBACJ IsdZBTwMpaVrV1EUlhqsLSanPlRLEFXOWfbjZQGO94LthZ3wvfyeBOzJ3 c=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 76027588 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:XeZG8qDWQauGJRVW/yHjw5YqxClBgxIJ4kV8jS/XYbTApDsghjZVz GYaCGmFOKvZZWOmL9t0Po2290kDu57QndFqQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgH2eIdA970Ug5w7Fg2NYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPh+y M9GloyQdj4nP6SXveUPbARSEwhhaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8QRayBO ppJAdZpRBKab01hFF47MqIvl+66pEn1Xh5nqE3A8MLb5ECMlVcsgdABKuH9eMGORMhTtlaVo CTB5WuRKgoBKNWVxD6B83StruzChyX2XMQVDrLQ3uFuqE2ewCoUEhJ+fVm0u/6ikWalRslSb UcT/0IGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0 ze0c8jBXGI19ufPEDTEq+nS/Wja1TUpwXEqai8eRigVw+baroA61TfOXOl+Gq6ckYigcd3v+ AxmvBTSlp1K05NUivTjoAmf696/jsOXF1Bov207Skrgt1okP9D9OuRE/HCBtZ59wJClok5tV ZTus+yX96gwAJ6Ej0Rhq81dTejyt55p3NAx6GOD/qXNFBz3ohZPhagKvFlDyL5Ba67ogwPBb k7Joh9275ROJnasZqIfS9vvVpt3k/S+TY67Bqm8gj9yjn9ZLVXvwc2TTRTIgzCFfLYEy8nTx qt3ge7zVC1HWMyLPRK9RvsH0K9D+x3SMVj7HMihpzz+iOL2TCfMFd8tbQrVBshkvfzsnekg2 4sGXyd8404HALOWj+i+2dN7EG3m2lBmXc6r8pwKLbXrz8gPMDhJNsI9CIgJI+RN95m5XM+Rl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:f/+UF6hSX5FwgbWJGbspwTMQI3BQXtoji2hC6mlwRA09TySZ// rBoB0+726RtN9xYgBEpTnuAsS9qB/nmaKdpLNhWotKPzOW2ldATrsD0WKK+VSJcEfDH6xmpM RdmsBFebvN5DNB7PoSjjPWL+od X-IronPort-AV: E=Sophos;i="5.92,265,1650945600"; d="scan'208";a="76027588" Date: Tue, 12 Jul 2022 13:49:15 +0100 From: Anthony PERARD To: Juergen Gross CC: , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: Re: [PATCH v2] xen/build: remove unneeded enumeration in clean-files of xen/include/Makefile Message-ID: References: <20220712091007.13595-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220712091007.13595-1-jgross@suse.com> On Tue, Jul 12, 2022 at 11:10:07AM +0200, Juergen Gross wrote: > Enumerating a file from $(targets) in $(clean-files) isn't needed. > > Remove hypercall-defs.h and headers*.chk from $(clean-files) in > xen/include/Makefile. > > Reported-by: Jan Beulich > Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") > Signed-off-by: Juergen Gross > --- > V2: > - remove headers*.chk from clean-files, too (Anthony Perard) Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 12 12:53:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 12:53:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365670.595948 (Exim 4.92) (envelope-from ) id 1oBFO7-0001Mk-Qz; Tue, 12 Jul 2022 12:53:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365670.595948; Tue, 12 Jul 2022 12:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFO7-0001Md-O9; Tue, 12 Jul 2022 12:53:15 +0000 Received: by outflank-mailman (input) for mailman id 365670; Tue, 12 Jul 2022 12:53:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFO5-0001MR-Uo for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 12:53:13 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9566eb03-01e1-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 14:53:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9566eb03-01e1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657630392; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=+7+0MkKoUlDJCX2tZSGG8HIgEkJ52SeoJidLeuN49SU=; b=igUsLeFkcHLnr1aYIDYfsMDau4AhArfPbCl4ddXvTj84Ik0cvmCHipRd ypEHZQ6VI3sUoCrI1IIqHrVY99Y5xVC7WNVapZJtren5RkS4efiO2CtgM 4D6N/wOhh11UMhQkOTLvdxuqSC4qLgMqbcKubQg6bMGP4RNffBldBO9hb I=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 78167216 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Gv9e1KAzW3WzmxVW/37jw5YqxClBgxIJ4kV8jS/XYbTApDMnhDZUz WcYXWDQO/vZNDCmctkkbN7j/B5X78fXytNhQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YgH2eIdA970Ug5w7Fg2NYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhTw ulqsafpVzsWL6aLos4aUAdHUChXaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwqKtXrO4UO/Glt1zjDAd4tQIzZQrWM7thdtNs1rp8eRKiBP ZNHAdZpRD7HRCxrZF4yMZ8Z38iFoyLNeBxbjHvA8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRyXYUEwY+TkagrL+yjUvWZj5EA xVKoGx09/F0rRH1CImmN/GlnJKaljwWZ/1UKLQk1D6cwe3uyQGaGHdHRxcUPbTKq/QKqSwWO k6hxo20WmE+6ODMERpx5Z/P82rsZHF9wXsqIHZdEFBbu4SLTJQb1Eqnczp1LEKiYjQZ8xnUy ivCkiUxjq57YSUjh/TipgCvb95BS/H0ou8JCub/BDvNAvtRPtLNWmBRwQGzAQx8BIiYVEKdm 3MPhtKT6usDZbnUynHSHbtRQunzuabcWNE5vbKIN8B7nwlBBlb5JdwAiN2ADB0B3jk4lc/BP xaI5FI5CG57N3q2d65nC7+M5zAR5fG4T7zND6mMBvIXO8QZXFLWp0lGOB/Pt10BZWBxyMnTz 7/AKZbyZZvbYIw6pAeLqxA1jOd1m3lumDiILX05pjz+uYejiLeuYe9tGDOzgioRtstofC29H w5jCva3 IronPort-HdrOrdr: A9a23:DzQoZaB63Eg9iX7lHems55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG/c5rsCMc5wx9ZJhNo7y90ey7MBThHP1OkOss1NWZPDUO0VHAROoJ0WKh+UyCJ8SXzJ866U 4KSclD4bPLYmRHsQ== X-IronPort-AV: E=Sophos;i="5.92,265,1650945600"; d="scan'208";a="78167216" Date: Tue, 12 Jul 2022 13:52:54 +0100 From: Anthony PERARD To: Juergen Gross CC: , Wei Liu Subject: Re: [PATCH v2] tools/init-xenstore-domain: fix memory map for PVH stubdom Message-ID: References: <20220712061830.20208-1-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220712061830.20208-1-jgross@suse.com> On Tue, Jul 12, 2022 at 08:18:30AM +0200, Juergen Gross wrote: > In case of maxmem != memsize the E820 map of the PVH stubdom is wrong, > as it is missing the RAM above memsize. > > Additionally the memory map should only specify the Xen special pages > as reserved. > > Signed-off-by: Juergen Gross > --- > V2: > - don't change mmio area settings (Anthony Perard) Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 12 12:55:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 12:55:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365678.595958 (Exim 4.92) (envelope-from ) id 1oBFPy-0001wo-62; Tue, 12 Jul 2022 12:55:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365678.595958; Tue, 12 Jul 2022 12:55:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFPy-0001wh-3D; Tue, 12 Jul 2022 12:55:10 +0000 Received: by outflank-mailman (input) for mailman id 365678; Tue, 12 Jul 2022 12:55:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFPx-0001wb-IU for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 12:55:09 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da0f2cd1-01e1-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 14:55:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da0f2cd1-01e1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657630507; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1wovSHjrqFB2rjLds3cXLKK5APzoYNGb9+u096JWxrw=; b=DkA3fZZndt94nfMG+I46nqinR2CmeXM+OfqdvsezhXTj+eP478a9pSjH NW6qCbSJ2qX2QIbHeRgrezx74SdCT0Nn1SLMpnz674is5CI3xTbMxgglu zIU1mcuD3qEw5GQakld3JAbmNhZLj87BqGMGXBMHO+EuDtUH0MbanlI/7 4=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75598299 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:6lb21aqhqANQTdUcKC6KMdhXx1heBmJJZRIvgKrLsJaIsI4StFCzt garIBmFPv3fYDPye9pxbIi+8U5T75CAyt9kGgI9pSAwQ3hDoJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefQAOCU5NfsYkidfyc9IMsaoU8lyrRRbrJA24DjWVvS4 Imq+qUzBXf+s9JKGjNMg068gEsHUMTa4Fv0aXRnOJinFHeH/5UkJMp3yZOZdhMUcaENdgKOf M7RzanRw4/s10xF5uVJMFrMWhZirrb6ZWBig5fNMkSoqkAqSicais7XOBeAAKv+Zvrgc91Zk b1wWZKMpQgBZbTVuOkYd15jISwvIIQX17D+cSekiJnGp6HGWyOEL/RGCUg3OcsT+/ptAHEI/ vsdQNwPRknd3aTsmuv9E7QywJR4RCXoFNp3VnVIxDfFDfEgUNbbTr/D/9Nw1zYsnMFeW/3ZY qL1bBIwMUmRM0ceaz/7DroPutmTukncIgRaqWzWq5Rs8zOU7ydYhe2F3N39JYXRGJQ9clyjj n3C13T0BFcdLtP34SqI9Degi/HCmQv/WZkOD/uo+/hymlqRy2cPThoMWjOTo/O0l0q/UNJ3M FEP92wlqq1ayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4vHN+iaUA0xDdQxMOcEP5eA5fGx1z WbcyrsFGgdTXK2ppWO1r+nJ8m7jYXVMdQfudgdfE1JbvoCLTJUby0uWE409SPPdYsjdQ2mY/ tyckMQpa1z/Z+Yv3r7zw13IiinESnPhHl9svVW/so5IA2pEiG+Zi2+AswGzAQ5odtrxc7V4l CFsdzKixO4PF4qRsyeGXf8AGrqkj97cbmCD3AAzQcF7qWT0k5JGQWy3yGgkTHqFz+5eIWO5C KMtkVk5CGBv0IuCMvYsPtPZ5zUCxqn8D9X1Ps3pgi51SsEpLmevpXg2DWbJhjyFuBV9yskXZ MbEGftA+F5HUMyLOhLtH7dDuVLqrwhjrV7uqWfTkkz5jOPOOSXOIVrHWXPXBt0EAGq/iF292 75i2wGikX2zjMWWjvHrzLMu IronPort-HdrOrdr: A9a23:72e/4KER8mpSrgrppLqE6MeALOsnbusQ8zAXP0AYc3Jom+ij5q STdZUgpHrJYVkqNU3I9ertBEDEewK6yXcX2/hyAV7BZmnbUQKTRekIh7cKgQeQeBEWntQts5 uIGJIeNDSfNzdHsfo= X-IronPort-AV: E=Sophos;i="5.92,265,1650945600"; d="scan'208";a="75598299" Date: Tue, 12 Jul 2022 13:55:02 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [PATCH] xl: relax freemem()'s retry calculation Message-ID: References: <55556c13-dbaa-3eb7-9f3a-9e448a0324aa@suse.com> <2b06e97e-1c39-9889-8d04-f1a063b403d6@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <2b06e97e-1c39-9889-8d04-f1a063b403d6@suse.com> On Tue, Jul 12, 2022 at 09:01:48AM +0200, Jan Beulich wrote: > On 11.07.2022 18:21, Anthony PERARD wrote: > > On Fri, Jul 08, 2022 at 03:39:38PM +0200, Jan Beulich wrote: > >> While in principle possible also under other conditions as long as other > >> parallel operations potentially consuming memory aren't "locked out", in > >> particular with IOMMU large page mappings used in Dom0 (for PV when in > >> strict mode; for PVH when not sharing page tables with HAP) ballooning > >> out of individual pages can actually lead to less free memory available > >> afterwards. This is because to split a large page, one or more page > >> table pages are necessary (one per level that is split). > >> > >> When rebooting a guest I've observed freemem() to fail: A single page > >> was required to be ballooned out (presumably because of heap > >> fragmentation in the hypervisor). This ballooning out of a single page > >> of course went fast, but freemem() then found that it would require to > >> balloon out another page. This repeating just another time leads to the > >> function to signal failure to the caller - without having come anywhere > >> near the designated 30s that the whole process is allowed to not make > >> any progress at all. > >> > >> Convert from a simple retry count to actually calculating elapsed time, > >> subtracting from an initial credit of 30s. Don't go as far as limiting > >> the "wait_secs" value passed to libxl_wait_for_memory_target(), though. > >> While this leads to the overall process now possibly taking longer (if > >> the previous iteration ended very close to the intended 30s), this > >> compensates to some degree for the value passed really meaning "allowed > >> to run for this long without making progress". > >> > >> Signed-off-by: Jan Beulich > >> --- > >> I further wonder whether the "credit expired" loop exit wouldn't better > >> be moved to the middle of the loop, immediately after "return true". > >> That way having reached the goal on the last iteration would be reported > >> as success to the caller, rather than as "timed out". > > > > That would sound like a good improvement to the patch. > > Oh. I would have made it a separate one, if deemed sensible. Order > shouldn't matter as I'd consider both backporting candidates. OK. For this patch: Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Tue Jul 12 13:04:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 13:04:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365688.595969 (Exim 4.92) (envelope-from ) id 1oBFZ0-0003eB-65; Tue, 12 Jul 2022 13:04:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365688.595969; Tue, 12 Jul 2022 13:04:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFZ0-0003e4-22; Tue, 12 Jul 2022 13:04:30 +0000 Received: by outflank-mailman (input) for mailman id 365688; Tue, 12 Jul 2022 13:04:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFYz-0003du-GE; Tue, 12 Jul 2022 13:04:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFYz-0005bS-DO; Tue, 12 Jul 2022 13:04:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFYy-0006mJ-Uf; Tue, 12 Jul 2022 13:04:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBFYy-0006md-UE; Tue, 12 Jul 2022 13:04:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T0IZN7NSO+9xDIyS3s6IYoFrFNbkXy569T6e3nAeVEM=; b=s0y2FzQRUiZv7RSYmFX1x+cx60 SF29WuNPMstdNeDocDd7yk2EKlxZyXmUWYEyxW4BCAXjGVxsDu8hgmj9yIRb8mIKEYYap3TR2XOrA vEWEr3QjSfqE4/N7QlyKtIsEtAZzIlCp+8cNEyXXBPqVVHIXqesowvbfT3K0/Vx93JQw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171588: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-arm64-arm64-xl-vhd:xen-boot:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9fed1bca6bc643ce91b6117f4974421aaede4751 X-Osstest-Versions-That: qemuu=63b38f6c85acd312c2cab68554abf33adf4ee2b3 From: osstest service owner Date: Tue, 12 Jul 2022 13:04:28 +0000 flight 171588 qemu-mainline real [real] flight 171596 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171588/ http://logs.test-lab.xenproject.org/osstest/logs/171596/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 171559 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 8 xen-boot fail pass in 171596-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 171596-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 171596 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 171596 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171559 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171559 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171559 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171559 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171559 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171559 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171559 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171559 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 9fed1bca6bc643ce91b6117f4974421aaede4751 baseline version: qemuu 63b38f6c85acd312c2cab68554abf33adf4ee2b3 Last test of basis 171559 2022-07-08 10:32:52 Z 4 days Testing same since 171588 2022-07-12 02:38:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 682 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 12 13:13:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 13:13:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365697.595981 (Exim 4.92) (envelope-from ) id 1oBFhP-0005Eq-2x; Tue, 12 Jul 2022 13:13:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365697.595981; Tue, 12 Jul 2022 13:13:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFhO-0005Ej-VU; Tue, 12 Jul 2022 13:13:10 +0000 Received: by outflank-mailman (input) for mailman id 365697; Tue, 12 Jul 2022 13:13:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFhN-0005Ed-VS for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 13:13:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f3258bd-01e4-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 15:13:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0401MB2479.eurprd04.prod.outlook.com (2603:10a6:800:53::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 13:13:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 13:13:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f3258bd-01e4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ychrbz4pRLxrp/F1ZpQLghX4tARWe1GgqsH44HE5uRAUnUOZta+a3VoQh4FVKwYLjg/YkU36THOG/PlMMPTVEre5k15d3cxi7sDZxI0z3N9SMx+1ibABCvBqZ23irLqeMun19bXOR7pyJ+idDjN1ABReLAKK9YywVfNbn72z9LRCnXjtRcuKrfc2bZ52g6BOlNkscmLiYnfUgHtCgKWFUGKYgPTYuItucHF4vde6mQVdsvNmBArkS7CncePL4CeMu1HYnwoMrzNFQYRfn2C5JWaarV5mpGR++m/GHmU9nPvm1vYoh6qb69TuIPg55z/R7OC4bXit85J8jO0hSso4bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ylGWmcAhIhFVUisaiNsJWg9JoeiMyxWeNyKTWs6XXZI=; b=PyHeaBuWERj/NvqxmRLhbPeQlSHGRBaHy5R/TrdHC3E3lQI6n0CLpIBcQimesgzwZWX5E/d1FuVK8ObKZH5FO7zkxDYweQMizCrbjpBnN35yW1uAsnCpT9zDKSfM9T0Szyd/L9uXI2ybGerkHyojqqTUrG+otDfglCzvTU9iQsFCY+s7cV87GKGQO4TMQwuSiLQmWOAfDlToOBgJzv7sHe1YiAj5dvK/SfhJWDchPlVLuvIHbycVAe1IHdFbaIVDqF/rsGGCw9sWk385RosRIk176hgfbdRHL9lSNSZrZPLd6L1VvH/e/39UmBMFNreYVJ4pBICQsmyv3P3PxxC9uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ylGWmcAhIhFVUisaiNsJWg9JoeiMyxWeNyKTWs6XXZI=; b=jxWM22cUga7L+bb0bQ1IIRpTYAoxTQSMSYKk6xaIEJLQEEHbRjFgOqk/f/t0kpktNQh6sfybUxDKLJ6gjmt2QFOJff+JMZ26e9R2JC1Q4om4sF0X8oNFxfcLrW1p4z4/azhA9vdADe4uujRs+7XDNmw69+lC3lrT9hmrlXgAxvti/P4Q6OEJcGabK83t6IB0bv3AQkujDmGA+LmRex0BagXdCR93zx/ZCPtBzaVnSLhuDCy3RyxOTEOdoE1whpikHAhPLgCptIcj6B73BIyfSDR/ZvxWnHia9TYEAtRjwGfte0e565srUNmq8v7OtxnKQvoqfHsqWbUN2CtV0FJw5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <444a540a-bf0f-f743-3b01-b65210b49361@suse.com> Date: Tue, 12 Jul 2022 15:13:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/9] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-4-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-4-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e022b0f0-03b5-4ea6-dfcc-08da6408420c X-MS-TrafficTypeDiagnostic: VI1PR0401MB2479:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ij2dbgQYqBmADOHjaY1LUZttrH6C9MdJLhZbEIMGhg/myto6Oq4pTJ21svQk+ViIeL4a8qKjjIJk91y2qULAuXBVNKy9sVh7i0xfxmwwrW5mqJEH5fX8jm/ZEH3t67y8DFlf6q/YIkRRYSOE55+3XBdmaK4jXZ6a96FHzB06CdJcz3EktgaAfBJaGJji5br2xq7VtdzakzcjX3ehuuzUe3mzvcadeIQKXqdlM4vl9d5VFrtkLl8GswUCu4TH/qo03Ub1Vr4QkZDWhqLXnCEOZX9wndb/XQQ+Rk41MWFcbvhkmkM+aLq3sMDKgAphZErxYzU+3UaLCK0znNR1vq+zgvPOgmQG5cs5AeWmQ030IEfHhnx1kOEKN5ML+CDjTujkrGMLKwlFwdLWxaDAqFjWSdYN4FpCRX1D6tmkWwRi5JuACxe9TrAWwsRSq//esSWiZ+Xim6IH7IwbbSaocWdYXlenzaqk09pXVnoP58pSm1nvZLmNihwz4FD3AY0eN0bwslbKbdHeXdUjZAGlkDo/pK9ktrs6UmD6xnTff4Bt2JwTCJtJM+P2WRgiGbXZXqHxxBKRmACmbvuldgI+RwlN6P8UI4/NVA9Ag2z8cLVaUolTsYpYNOrcNzUYHqghqOb15TftMiOSpW2VDFKeHCqNKliM6p+zXeQgIsFiZ+rSQez/HYqffhFU2N8AB0iFweXm0uFxt3z09eNPy4h16Aeh5vwhN9Elu3FCdwCSuoandMo4OSsWyQLj7vdCoQ9TvSJC/AVUMsb2gSq24S2v7sNclP82grVdMzz0mlmkOKJHI4MQFP9GXdXegG6F8+F916Gh6WWGiBrtWcpMfBWYpE/L3aR+Vb+nd8hrgGOFG8czKf0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(39860400002)(136003)(366004)(396003)(6486002)(31686004)(478600001)(66476007)(8676002)(83380400001)(2906002)(36756003)(4326008)(316002)(8936002)(41300700001)(54906003)(5660300002)(6916009)(186003)(26005)(53546011)(6506007)(2616005)(6512007)(86362001)(31696002)(66946007)(66556008)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1lHOGVmT0FzZWZEcUF0UHA0by9lVFhXSU5mQjZPV3F1cHE5VXh4SDJseTls?= =?utf-8?B?OGZiYWlseWNsVi9YQ0JSZ1hFb2pmWVVyMXMyZVJmaEViOVB6WFoybFhRSjMw?= =?utf-8?B?VmFwKzF6K0h4ZHRVNTlrRUZCWXVyRWVnQlQ3cFRBbTRWSjVCUDBIbUNXVGlw?= =?utf-8?B?NnM5WHN5WllZeEFhcmRCNDJNNXJQNDBkWXBnSmIyMnVic1pMbC9yOXk4Tlg5?= =?utf-8?B?UUxkQ3NWZzNyYzh1V1NMNGc2QXlTOTB2Wlh3QzJrRXoxOFZ5Z2taSCs5Rk9u?= =?utf-8?B?VG9XTnlsNnk5NEpnYTN2QTVlYmltaGxBcmtFZnQ5ZFViRC9uY3J2QzlvWmF0?= =?utf-8?B?UVJJb2RhSS9xaWU1MnJFOTZzKy8xcHNFYitwS1F5Vm9xRnpxWUJta0E5a1g0?= =?utf-8?B?ckd1WjlqWnN3dWhxVi9xOHhTQWFkNU5ralJHc3FQTmxNc09xNHFXMGhWRmdT?= =?utf-8?B?b25STS9oU2UwWnpHK2NhZldBYkhTNlJZbVJZcHhIai81dG5UTzExRGhHMi9k?= =?utf-8?B?cXJrY1MzYUdncitiNEVhMndqcVVFLzhqYVU4eTExQVJ5Y3laTHVsVE9NZEFt?= =?utf-8?B?UDVRZStGeVN5Y29YUFV3cTU2djVQRkUrRzZ3VFZsazNoV3pIR2NZZDduWUUr?= =?utf-8?B?TVBqWnVNMmNaM2w0eG5MQWlZODJBRWtEbEllME5ITUtmZjF1SjFsK2VBWnZK?= =?utf-8?B?dlRnNWN2ZWxwRzRGd2ZkSzBGWlAyZE9sYnpQeWQwN0h2TnVtQi9nUHNLMjZW?= =?utf-8?B?T2haeGY5eGJZQ0V3cnVITVhEa01WNW1FZ3dDVk44Q2hjMlR6NkpLRTljcU55?= =?utf-8?B?bS9QSlpQM3laRUZwL2E0NitObFRmaHZQSjNqdXpONGpvK3VUN09IUUpzc2Uv?= =?utf-8?B?eW0wdHJrMEhlbWkzMzFkaXN6Ymw2M25UanExbkVkSDN0NlZpcTA3eThiUmJU?= =?utf-8?B?MzlCZkN5N1l5emJjVXhXZXVSVncvZExOTVpRU3hYcFU5dS9vNGVWT09BWDRI?= =?utf-8?B?YWtFYVFZM0piRVBtYTg5Wlo2V3pEZWswQVkyYjE5bFppN3VONXB4emZiYVBD?= =?utf-8?B?WW1iYURMa2tDeUJPRmFYRDNKQkU5OEY3VzRYZjRRSmF4WFlaYjVkTVpjZHNz?= =?utf-8?B?a2g3Qzc2VFNRWkR0RGxaOWQzekR0NXlhWmtjTXRKcEIvRk40WjR0cW9RdG1S?= =?utf-8?B?WFVDZ2Y5allMY2gwZHM0dlUxZFJuL2ZqNDVPQ3lkY214V3BCU3ZGSktvSnJZ?= =?utf-8?B?N0wyYW52Um8xRExJRFJORWVGVEJNWUFCSzl1bHJRQW5HVk1ZNi85UGE4bzk2?= =?utf-8?B?c2xvL3I0RU4rV2VGeVZsNVlCRERaVGdZTjVhdTIxazJBZzNZL1U1eUVJbU4z?= =?utf-8?B?Y1lnU1ZNalJsMGNRVmxRSkJ4bE92WkkvaDBpRGIwZEJMRUtsZDEwR2dpVEht?= =?utf-8?B?QkIvNHRNUi91OGd2RjdVYk05VEMwSFNpMkd4enhQWVZHWXJCeEtNMklTMHBM?= =?utf-8?B?YWhvRUpSUEthZDY0dGtGMlZycldtS1ZPY1dQNk5LQ3JkK2dLZlJjWWMreWtm?= =?utf-8?B?bmZIN3h3MVpJVXZRL1ZENlpJZUlTbkVlcU5KQ2IvMHRBajAyQ1ZsN2s5ZGYy?= =?utf-8?B?d1NYUTZEenVMUWtKWmI2LzVDb2VuUDlYN2FLMUhUbDdMalJkT25idU5Sd012?= =?utf-8?B?VG12WEVBYmNhcjRwaEs4djBvd2N6OFdXaWl5VTcxbDkvTWtIRGUwYVhDR0NW?= =?utf-8?B?eU9SN2l1MkZLeVovcDNEVnV1eDJzeHEyMmhKUStKSWh3OG1wVXNMa2dqQ3c2?= =?utf-8?B?VzBhYjNGZnExVXh5Q3JRUzRJRmdiWXo3NUZlajN6K1pGeGhPTWNsSVFRbVF1?= =?utf-8?B?Z0xXTW5ZcXpHSTZEZTYyOWhEYW5jMVNTcExqVmVKcDh0MU9aZFZianFzZjlK?= =?utf-8?B?SURwSkJ2M1F1b2l3MmdHa2JkL201QmNiZk5yM1gvSVhyV1B0d3A4eUVINkZI?= =?utf-8?B?Z0pUbjFrcHJpQWlmNVBxMUY2SnU2bFdsVFVPWXJUYnhHWnJBeWRjeUZGempk?= =?utf-8?B?cnIwRG1sbHQwaVM4TytvQUhFNER5QWlpWnpOQXVxNjdrS1B0M1NUOWNqNE5m?= =?utf-8?Q?M8lQTCqFIpjVRIuV6aw0ZHzZJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e022b0f0-03b5-4ea6-dfcc-08da6408420c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 13:13:05.8252 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q0PFsUxn9h0MHJx7lreQ2DCq11pNBapxIp0vWevqCrZjH45j7ST/EGwSbWgIy34CZUwy8Y0ibhdjN78R5i3bZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2479 On 08.07.2022 16:54, Wei Chen wrote: > --- /dev/null > +++ b/xen/common/numa.c > @@ -0,0 +1,439 @@ > +/* > + * Generic VM initialization for NUMA setups. > + * Copyright 2002,2003 Andi Kleen, SuSE Labs. > + * Adapted for Xen: Ryan Harper > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Isn't the goal for the now common code to not be dependent upon ACPI? > +struct node_data node_data[MAX_NUMNODES]; > + > +/* Mapping from pdx to node id */ > +int memnode_shift; > +static typeof(*memnodemap) _memnodemap[64]; > +unsigned long memnodemapsize; > +u8 *memnodemap; For code moved, please switch to (in this case) uint8_t. I'm on the edge of asking to go further and - also use __read_mostly for some / all of these, - make memnode_shift unsigned int (sadly this looks to require more adjustments, even if negative shift counts are meaningless), - convert from plain int to unsigned int elsewhere as appropriate, - add const where appropriate / possible. > +nodeid_t cpu_to_node[NR_CPUS] __read_mostly = { > + [0 ... NR_CPUS-1] = NUMA_NO_NODE > +}; > + > +cpumask_t node_to_cpumask[MAX_NUMNODES] __read_mostly; For these two please put __read_mostly into its more conventional place (right after the type). > +nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; > + > +enum numa_mode numa_status; This should probably have been __read_mostly already in the earlier patch introducing it. > +#ifdef CONFIG_NUMA_EMU > +static int numa_fake __initdata = 0; The __initdata again wants to move, and the initializer can be omitted. > +/* [numa=off] */ > +static int __init cf_check numa_setup(const char *opt) > +{ > + if ( !strncmp(opt,"off",3) ) As you're correcting style violations elsewhere, please also insert the missing spaces here and below. > --- a/xen/include/xen/numa.h > +++ b/xen/include/xen/numa.h > @@ -18,4 +18,78 @@ > (((d)->vcpu != NULL && (d)->vcpu[0] != NULL) \ > ? vcpu_to_node((d)->vcpu[0]) : NUMA_NO_NODE) > > +/* The following content can be used when NUMA feature is enabled */ > +#ifdef CONFIG_NUMA > + > +extern nodeid_t cpu_to_node[NR_CPUS]; > +extern cpumask_t node_to_cpumask[]; > + > +#define cpu_to_node(cpu) (cpu_to_node[cpu]) > +#define parent_node(node) (node) > +#define node_to_first_cpu(node) (__ffs(node_to_cpumask[node])) > +#define node_to_cpumask(node) (node_to_cpumask[node]) > + > +struct node { > + paddr_t start, end; > +}; > + > +extern int compute_hash_shift(struct node *nodes, int numnodes, > + nodeid_t *nodeids); > + > +#define VIRTUAL_BUG_ON(x) > + > +/* Enumerations for NUMA status. */ > +enum numa_mode { > + numa_on = 0, > + numa_off, > + /* NUMA turns on, but ACPI table is bad or disabled. */ > + numa_no_acpi, > + /* NUMA turns on, and ACPI table works well. */ > + numa_acpi, > +}; > + > +extern void numa_add_cpu(int cpu); > +extern void numa_init_array(void); > +extern void numa_initmem_init(unsigned long start_pfn, unsigned long end_pfn); > +extern bool numa_enabled_with_firmware(void); > +extern enum numa_mode numa_status; > + > +extern void numa_set_node(int cpu, nodeid_t node); > +extern void setup_node_bootmem(nodeid_t nodeid, paddr_t start, paddr_t end); > + > +static inline void clear_node_cpumask(int cpu) > +{ > + cpumask_clear_cpu(cpu, &node_to_cpumask[cpu_to_node(cpu)]); > +} > + > +/* Simple perfect hash to map pdx to node numbers */ > +extern int memnode_shift; > +extern unsigned long memnodemapsize; > +extern u8 *memnodemap; > + > +struct node_data { > + unsigned long node_start_pfn; > + unsigned long node_spanned_pages; > +}; > + > +extern struct node_data node_data[]; > + > +static inline __attribute__((pure)) nodeid_t phys_to_nid(paddr_t addr) Please use __attribute_pure__. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 13:22:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 13:22:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365706.595995 (Exim 4.92) (envelope-from ) id 1oBFqW-0006uE-3x; Tue, 12 Jul 2022 13:22:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365706.595995; Tue, 12 Jul 2022 13:22:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFqW-0006u7-0r; Tue, 12 Jul 2022 13:22:36 +0000 Received: by outflank-mailman (input) for mailman id 365706; Tue, 12 Jul 2022 13:22:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBFqT-0006u0-QI for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 13:22:34 +0000 Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ad6cb6de-01e5-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 15:22:31 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 13:22:28 +0000 Received: by hermes--production-ne1-7864dcfd54-hcklt (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0acdc84b3b441651254eb93653e367b2; Tue, 12 Jul 2022 13:22:23 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ad6cb6de-01e5-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657632148; bh=xJ9Sz+y9USDgbyuOjTjsV8ceUXxOwGkS0zUBwjj6SsA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=LWhmvy+Zc8nU+HFfil/PAT6rBbwGh5tiTFG9m6zxb4Qwi42br+xJ9gDl80Ue+4FJTrJEbsJJoNrlNKDPAENMIJpXVBErt0sQQtSUuOhMCk4c/gc8iH9F/AS5x3AYdMJtQKhDaIsS2ikZ9y50UjERFMGZgj7eOR7Nuxp1SpnFlsLiw8+mkErRuc5cYwK7iiaZ94T53an6dQb0HCS/xI4JGpj6CL4tqFKMx1MH/VSJz6Ff5Djy8m0lNONJbLhHWYX0/yd7bxUxLKACntKQIJfnQgYLMAkZTgu+fxsd1aHsVHDOGQynO0465Rg2tSkX/lQZmOhJwP1uF4cQpt8VoY+wCg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657632148; bh=nyuhStRwJvNRCLIVsXYVTfe3U6CzGzAAY+XfayCyvK0=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=R5vyqjTR/YlCaaJzHfA5HVtqHRHhSuBJKuoNdy7wsGPMSlrxQocfFIa1tbYlqMwyZkwFFfH8CzR1YMZn4psKgs/l4ai71o8D7Mo7kt4c+Z5WI/l80C3cC+9dh93k2Ri3vCUyKZm26DcJcTJxbcH7xfXcEfe2CbZm9SrtX/i0A7HmAefGbMFYeMC2un2Aj3BC7CvKxnU97fF6Y55KI4ahmxxNA/nYPPaqyWXdqUOpfBbWg9Laj1nf+ppdt6owumSxwMiao6RinFM2rvl6ev2ABZj/TqJvxzZlRvWQrDipwOhyJ+nktnBnkL1hqIFOz2/95Sy88I/xnQKVlvGq8XLzaw== X-YMail-OSG: A9CSTc8VM1la8yPPD6h918B78emmpPO3796POtupixScIxrK8Jg1kT.1JwjHQIq mf9c5mDUph3UkBHfYQJjal9NOkVqXozoIRVzyw7g1_EE739ZQN9UbmKn4jGVbW0g0BshZX6W8nex i6wH5SUUY8AM2J7Rk4DScsfepXyidvRmqGLHzQemXdDvLHagSLIkgO7V_HHlGSWyeVHYLUUTIcL8 M2pfEuXpsQxDf4a0_jn1O3a_XJcaQ1g8pJk2wRydZWDwiyf29TMK7twax32y1BpH6vnSBcjfXwHC L72pl2G5Nm.f6Nf8wbNNJLNSh5BYkat9T9X.a3po3d02N3RKWpg9aMNkqP63FMVKXZ77ZSZ8RCyC bf_stfpr6ub5jPdV5LV65TCptl1cr9__kJ.cHCURCfTmUrTcI0ZMuAA9P879HRNJAI1L8lBVg7ye Y.v9nh9_5wy52BRPEL62sUCXpU0h9tG7uCSy7XGNpP3KXEbw1b.fCsQPL8_YhNbWhk7yYkLOfYJ. ZQCt493i_WwsO9LAgujug9xojEy0Vd5YK2hV0d3hTwphWt9Kn7cWrBPB_wqTzlSIS0VuNQV5SHm6 tcKZQnFTeRQ5WQ6MfVRf008uPg4ulzaWp3oqZEjNqK8GoQ7YpAoPzs6GLhtbiSOBiIHRjqnZtTZk iEj4sIQeNERCdMn2XTnFVc1bPs0_SerYYRn7qrryTUVLw0oZRgOruij2ZVxrINjsApCUeoRHA2M7 OwHUUWGsgl_Z8LKIWAu2JhSo9vNZdCN1eF9sjTQEtook7pTgsdEaaULjhfRjOykADCLWAA1HkzUG ii5DXnXgqn4B4RW_jJlQejGg8lm34OMiRAEfxq95YOJA7XCtfm7bLaR1OpkAm3QCFUvNGNRYn1ib PxKErqn_vWr.w7k3C5U_tv5G4kKAda_Rz7fsDV1WZnYq.l4ZcYmAROrPv_f6T4vDw_f.7LseY2vO mTMrm7idkLj3ZMHYWshLBfpr2gE5w26qaTf8Wpdf13sh2CKC6EQEo.M7q2HDnFaV7flHdlGVpbaX 2CxREPKjq425Crqx25IYCOZviCBcsNv9eFRy0Ozf908FbOyP9g7bNAjSZYwWrfJABKpgXR4.coTs ixuyun9ImbQqA.RbhJGr.lKmyTahc3etbfPOHw6hrmhbuXnvh0GNfh.tvFvfcVmg8F9t02JLULeJ TtL9cjDQngPj6aQUv3.u4RL.zpts9zKVPNz1qxvO7ZNypZ3_X9Brnm4kdiChoT.cYSyz4Q22tpeT 45STrU0_Z_xYRMFVPlCM21EpLhxwBxWLFWMpG7ZqFRZ9HKNlRWq2bWVI9dssq8DvGf4X6wUuKPAy _WbUaLv1PVuodRpHtbnkR7ZWHcvBpOlm5APPbq5V_ZA8oBifgAI.Aiw4o8Lb10s3rAfzg_5Sr_0P ozmfzOX8Xui1L.bNEjTkbsMpl4W3A4jdrlxalaBubdVIQFaHQPr9D2UIwP70PVXetah982UBuvdP mjZaO0NCx1ym2LrO6guHOZdSR7KmYpJyokL63YPBS069B.cbrugmmncDF728SddgFg8meiLFnQLb 8S4TiEjfdVD6CP2.nY8V63uRpWt4A8NFHFd4T169Tu_yMQmiwX_ieny9WX4EHUNqBU9_sTqxTWwc 5DJedIQiM_TlAQgW__42T4naUe7njtLNd.NsytgvmpTXHPENtcrzekEsNms0TL5IhX7HIfIKDwPS uR85l2q7HhGvxamSJXzaJ5LemWIahqtsTESshNXOg981OtTZwDD4n9KdofZ2gs6svtyNzT9Blzvq 4GLenke97D003tDZFVC9pctYSO3f7zx.TuFQdMDUasmOIp_oKgSh2E2oiO5fC.ODMhNkNqepZA.9 p60qEL_fN.02r3WurZLVmf8gETF1gFhDWiTlHdcdv5r6Txp0reuvUmffiUwRfo8TUpiaNZVrf87U mM7.zgjoIecaIWaW0zQqYbx4v1isFWPFq1xmB1iu2dIYqnxmjPUOWSeveeF9hKom25OHLqfykKAz iLvpYFkGBTT8dYs_aLv9yolJC.Mg2bpjuAZH10V9JEMAzEi2jL4OgqEAQsd7WvkhwLlO.fUVidLN l8HEdkyKMbWyEpRBLc9DuuD2yMsp0foCXuySjUg65gvYCM1C9fXUXy70HquI03RMIoAoiq5Bfsmt LiYjW7lYGYRrCuRFwZDulNQbHdvOQ.3gtR5YUboFBwCTxSXYGAy3bABlABpBwG4hKMLLEs1oYit. Y6FAfWvz_H..6zQ-- X-Sonic-MF: Message-ID: <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> Date: Tue, 12 Jul 2022 09:22:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Juergen Gross , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> From: Chuck Zmudzinski In-Reply-To: <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5605 On 7/12/2022 2:04 AM, Jan Beulich wrote: > On 11.07.2022 19:41, Chuck Zmudzinski wrote: > > Moreover... (please move to the bottom of the code snippet > > for more information about my tests in the Xen PV environment...) > > > > void init_cache_modes(void) > > { > >     u64 pat = 0; > > > >     if (pat_cm_initialized) > >         return; > > > >     if (boot_cpu_has(X86_FEATURE_PAT)) { > >         /* > >          * CPU supports PAT. Set PAT table to be consistent with > >          * PAT MSR. This case supports "nopat" boot option, and > >          * virtual machine environments which support PAT without > >          * MTRRs. In specific, Xen has unique setup to PAT MSR. > >          * > >          * If PAT MSR returns 0, it is considered invalid and emulates > >          * as No PAT. > >          */ > >         rdmsrl(MSR_IA32_CR_PAT, pat); > >     } > > > >     if (!pat) { > >         /* > >          * No PAT. Emulate the PAT table that corresponds to the two > >          * cache bits, PWT (Write Through) and PCD (Cache Disable). > >          * This setup is also the same as the BIOS default setup. > >          * > >          * PTE encoding: > >          * > >          *       PCD > >          *       |PWT  PAT > >          *       ||    slot > >          *       00    0    WB : _PAGE_CACHE_MODE_WB > >          *       01    1    WT : _PAGE_CACHE_MODE_WT > >          *       10    2    UC-: _PAGE_CACHE_MODE_UC_MINUS > >          *       11    3    UC : _PAGE_CACHE_MODE_UC > >          * > >          * NOTE: When WC or WP is used, it is redirected to UC- per > >          * the default setup in __cachemode2pte_tbl[]. > >          */ > >         pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >               PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >     } > > > >     else if (!pat_bp_enabled) { > >         /* > >          * In some environments, specifically Xen PV, PAT > >          * initialization is skipped because MTRRs are > >          * disabled even though PAT is available. In such > >          * environments, set PAT to initialized and enabled to > >          * correctly indicate to callers of pat_enabled() that > >          * PAT is available and prevent PAT from being disabled. > >          */ > >         pat_bp_enabled = true; > >         pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > >     } > > > >     __init_cache_modes(pat); > > } > > > > This function, patched with the extra 'else if' block, fixes the > > regression on my Xen worksatation, and the pr_info message > > "x86/PAT: PAT enabled by init_cache_modes" appears in the logs > > when running this patched kernel in my Xen Dom0. This means > > that in the Xen PV environment on my Xen Dom0 workstation, > > rdmsrl(MSR_IA32_CR_PAT, pat) successfully tested for the presence > > of PAT on the virtual CPU that Xen exposed to the Linux kernel on my > > Xen Dom0 workstation. At least that is what I think my tests prove. > > > > So why is this not a valid way to test for the existence of > > PAT in the Xen PV environment? Are the existing comments > > in init_cache_modes() about supporting both the case when > > the "nopat" boot option is set and the specific case of Xen and > > MTRR disabled wrong? My testing confirms those comments are > > correct. > > At the very least this ignores the possible "nopat" an admin may > have passed to the kernel. I realize that. The patch I proposed here only fixes the regression. It would be easy to also modify the patch to also observe the 'nopat" setting. I think your patch had a force_pat_disable local variable that is set if pat is disabled by the administrator with "nopat." With that variable available, modifying the patch so in init_cache_modes we have:      if (!pat || force_pat_disable) {          /*           * No PAT. Emulate the PAT table that corresponds to the two Instead of:      if (!pat) {          /*           * No PAT. Emulate the PAT table that corresponds to the two would cause the kernel to respect the "nopat" setting by the administrator in the Xen PV Dom0 environment. I agree this needs to be fixed up, because currently the code is very confusing and the current variable names and function names do not always accurately describe what they actually do in the code. That is why I am working on a patch to do some re-factoring, which only consists of function and variable name changes and comment changes to fix the places where the comments in the code are misleading or incomplete. I think perhaps the most misnamed variable here is the  local variable pat_disabled in memtypes.c and the most misnamed function is the pat_disable function in memtypes.c. They should be named pat_init_disabled and pat_init_disable, respectively, because they do not really disable PAT in the code but only prevent execution of the pat_init function. That leaves open the possibility for PAT to be enabled by init_cache_modes, which actually occurs in the current code in the Xen PV Dom0 environment, but the current code neglects to set pat_bp_enabled to true in that case. So we need a patch to fix that in order to fix the regression. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 13:32:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 13:32:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365713.596006 (Exim 4.92) (envelope-from ) id 1oBG0J-0008WE-1j; Tue, 12 Jul 2022 13:32:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365713.596006; Tue, 12 Jul 2022 13:32:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBG0I-0008W7-UD; Tue, 12 Jul 2022 13:32:42 +0000 Received: by outflank-mailman (input) for mailman id 365713; Tue, 12 Jul 2022 13:32:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBG0G-0008Vz-JD for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 13:32:40 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 191dd439-01e7-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 15:32:39 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8511022DC3; Tue, 12 Jul 2022 13:32:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 43D2513A94; Tue, 12 Jul 2022 13:32:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9yavDvZ3zWI9RgAAMHmgww (envelope-from ); Tue, 12 Jul 2022 13:32:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 191dd439-01e7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657632758; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2XsGBbxyNSX2WkHwSgKDNm6sf7LFWFkHBdhoK1F0MUA=; b=h5nunqLhBHNkBuPLaV17VUp9LNZu/ZN4qDoZYhP5RMyC/tkQ2Kc5ZcCqIKAAGM1o3r5GuN D7uRttJT0pKS8G6zDda5ABZqtUJiqTAlg76BCTKi38Q4jSMzS0Lmlq8uCRvQQBhg65MEsp R80DjI3i83ESStjmq6ncdQPg7Du5HBU= Message-ID: <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> Date: Tue, 12 Jul 2022 15:32:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> From: Juergen Gross Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen In-Reply-To: <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------BMygs5DS03pxlw5GpFihyWpe" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------BMygs5DS03pxlw5GpFihyWpe Content-Type: multipart/mixed; boundary="------------qUq0m33xBxWW0oopzVEN4rd5"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov Message-ID: <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> In-Reply-To: <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> --------------qUq0m33xBxWW0oopzVEN4rd5 Content-Type: multipart/mixed; boundary="------------VgW9HN3nCc3re0erqMuhpFcc" --------------VgW9HN3nCc3re0erqMuhpFcc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDcuMjIgMTU6MjIsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IE9uIDcvMTIv MjAyMiAyOjA0IEFNLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+IE9uIDExLjA3LjIwMjIgMTk6 NDEsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4gTW9yZW92ZXIuLi4gKHBsZWFzZSBt b3ZlIHRvIHRoZSBib3R0b20gb2YgdGhlIGNvZGUgc25pcHBldA0KPj4+IGZvciBtb3JlIGlu Zm9ybWF0aW9uIGFib3V0IG15IHRlc3RzIGluIHRoZSBYZW4gUFYgZW52aXJvbm1lbnQuLi4p DQo+Pj4NCj4+PiB2b2lkIGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4+PiB7DQo+Pj4gIMKg wqAgwqB1NjQgcGF0ID0gMDsNCj4+Pg0KPj4+ICDCoMKgIMKgaWYgKHBhdF9jbV9pbml0aWFs aXplZCkNCj4+PiAgwqDCoCDCoMKgwqDCoCByZXR1cm47DQo+Pj4NCj4+PiAgwqDCoCDCoGlm IChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfUEFUKSkgew0KPj4+ICDCoMKgIMKgwqDCoMKg IC8qDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIENQVSBzdXBwb3J0cyBQQVQuIFNldCBQQVQg dGFibGUgdG8gYmUgY29uc2lzdGVudCB3aXRoDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIFBB VCBNU1IuIFRoaXMgY2FzZSBzdXBwb3J0cyAibm9wYXQiIGJvb3Qgb3B0aW9uLCBhbmQNCj4+ PiAgwqDCoCDCoMKgwqDCoCDCoCogdmlydHVhbCBtYWNoaW5lIGVudmlyb25tZW50cyB3aGlj aCBzdXBwb3J0IFBBVCB3aXRob3V0DQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIE1UUlJzLiBJ biBzcGVjaWZpYywgWGVuIGhhcyB1bmlxdWUgc2V0dXAgdG8gUEFUIE1TUi4NCj4+PiAgwqDC oCDCoMKgwqDCoCDCoCoNCj4+PiAgwqDCoCDCoMKgwqDCoCDCoCogSWYgUEFUIE1TUiByZXR1 cm5zIDAsIGl0IGlzIGNvbnNpZGVyZWQgaW52YWxpZCBhbmQgZW11bGF0ZXMNCj4+PiAgwqDC oCDCoMKgwqDCoCDCoCogYXMgTm8gUEFULg0KPj4+ICDCoMKgIMKgwqDCoMKgIMKgKi8NCj4+ PiAgwqDCoCDCoMKgwqDCoCByZG1zcmwoTVNSX0lBMzJfQ1JfUEFULCBwYXQpOw0KPj4+ICDC oMKgIMKgfQ0KPj4+DQo+Pj4gIMKgwqAgwqBpZiAoIXBhdCkgew0KPj4+ICDCoMKgIMKgwqDC oMKgIC8qDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIE5vIFBBVC4gRW11bGF0ZSB0aGUgUEFU IHRhYmxlIHRoYXQgY29ycmVzcG9uZHMgdG8gdGhlIHR3bw0KPj4+ICDCoMKgIMKgwqDCoMKg IMKgKiBjYWNoZSBiaXRzLCBQV1QgKFdyaXRlIFRocm91Z2gpIGFuZCBQQ0QgKENhY2hlIERp c2FibGUpLg0KPj4+ICDCoMKgIMKgwqDCoMKgIMKgKiBUaGlzIHNldHVwIGlzIGFsc28gdGhl IHNhbWUgYXMgdGhlIEJJT1MgZGVmYXVsdCBzZXR1cC4NCj4+PiAgwqDCoCDCoMKgwqDCoCDC oCoNCj4+PiAgwqDCoCDCoMKgwqDCoCDCoCogUFRFIGVuY29kaW5nOg0KPj4+ICDCoMKgIMKg wqDCoMKgIMKgKg0KPj4+ICDCoMKgIMKgwqDCoMKgIMKgKsKgwqDCoMKgwqDCoCBQQ0QNCj4+ PiAgwqDCoCDCoMKgwqDCoCDCoCrCoMKgwqDCoMKgwqAgfFBXVMKgIFBBVA0KPj4+ICDCoMKg IMKgwqDCoMKgIMKgKsKgwqDCoMKgwqDCoCB8fMKgwqDCoCBzbG90DQo+Pj4gIMKgwqAgwqDC oMKgwqAgwqAqwqDCoMKgwqDCoMKgIDAwwqDCoMKgIDDCoMKgwqAgV0IgOiBfUEFHRV9DQUNI RV9NT0RFX1dCDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKgIDAxwqDCoMKg IDHCoMKgwqAgV1QgOiBfUEFHRV9DQUNIRV9NT0RFX1dUDQo+Pj4gIMKgwqAgwqDCoMKgwqAg wqAqwqDCoMKgwqDCoMKgIDEwwqDCoMKgIDLCoMKgwqAgVUMtOiBfUEFHRV9DQUNIRV9NT0RF X1VDX01JTlVTDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKgIDExwqDCoMKg IDPCoMKgwqAgVUMgOiBfUEFHRV9DQUNIRV9NT0RFX1VDDQo+Pj4gIMKgwqAgwqDCoMKgwqAg wqAqDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIE5PVEU6IFdoZW4gV0Mgb3IgV1AgaXMgdXNl ZCwgaXQgaXMgcmVkaXJlY3RlZCB0byBVQy0gcGVyDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAq IHRoZSBkZWZhdWx0IHNldHVwIGluIF9fY2FjaGVtb2RlMnB0ZV90YmxbXS4NCj4+PiAgwqDC oCDCoMKgwqDCoCDCoCovDQo+Pj4gIMKgwqAgwqDCoMKgwqAgcGF0ID0gUEFUKDAsIFdCKSB8 IFBBVCgxLCBXVCkgfCBQQVQoMiwgVUNfTUlOVVMpIHwgUEFUKDMsIFVDKSB8DQo+Pj4gIMKg wqAgwqDCoMKgwqAgwqDCoMKgwqDCoCBQQVQoNCwgV0IpIHwgUEFUKDUsIFdUKSB8IFBBVCg2 LCBVQ19NSU5VUykgfCBQQVQoNywgVUMpOw0KPj4+ICDCoMKgIMKgfQ0KPj4+DQo+Pj4gIMKg wqAgwqBlbHNlIGlmICghcGF0X2JwX2VuYWJsZWQpIHsNCj4+PiAgwqDCoCDCoMKgwqDCoCAv Kg0KPj4+ICDCoMKgIMKgwqDCoMKgIMKgKiBJbiBzb21lIGVudmlyb25tZW50cywgc3BlY2lm aWNhbGx5IFhlbiBQViwgUEFUDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqIGluaXRpYWxpemF0 aW9uIGlzIHNraXBwZWQgYmVjYXVzZSBNVFJScyBhcmUNCj4+PiAgwqDCoCDCoMKgwqDCoCDC oCogZGlzYWJsZWQgZXZlbiB0aG91Z2ggUEFUIGlzIGF2YWlsYWJsZS4gSW4gc3VjaA0KPj4+ ICDCoMKgIMKgwqDCoMKgIMKgKiBlbnZpcm9ubWVudHMsIHNldCBQQVQgdG8gaW5pdGlhbGl6 ZWQgYW5kIGVuYWJsZWQgdG8NCj4+PiAgwqDCoCDCoMKgwqDCoCDCoCogY29ycmVjdGx5IGlu ZGljYXRlIHRvIGNhbGxlcnMgb2YgcGF0X2VuYWJsZWQoKSB0aGF0DQo+Pj4gIMKgwqAgwqDC oMKgwqAgwqAqIFBBVCBpcyBhdmFpbGFibGUgYW5kIHByZXZlbnQgUEFUIGZyb20gYmVpbmcg ZGlzYWJsZWQuDQo+Pj4gIMKgwqAgwqDCoMKgwqAgwqAqLw0KPj4+ICDCoMKgIMKgwqDCoMKg IHBhdF9icF9lbmFibGVkID0gdHJ1ZTsNCj4+PiAgwqDCoCDCoMKgwqDCoCBwcl9pbmZvKCJ4 ODYvUEFUOiBQQVQgZW5hYmxlZCBieSBpbml0X2NhY2hlX21vZGVzXG4iKTsNCj4+PiAgwqDC oCDCoH0NCj4+Pg0KPj4+ICDCoMKgIMKgX19pbml0X2NhY2hlX21vZGVzKHBhdCk7DQo+Pj4g fQ0KPj4+DQo+Pj4gVGhpcyBmdW5jdGlvbiwgcGF0Y2hlZCB3aXRoIHRoZSBleHRyYSAnZWxz ZSBpZicgYmxvY2ssIGZpeGVzIHRoZQ0KPj4+IHJlZ3Jlc3Npb24gb24gbXkgWGVuIHdvcmtz YXRhdGlvbiwgYW5kIHRoZSBwcl9pbmZvIG1lc3NhZ2UNCj4+PiAieDg2L1BBVDogUEFUIGVu YWJsZWQgYnkgaW5pdF9jYWNoZV9tb2RlcyIgYXBwZWFycyBpbiB0aGUgbG9ncw0KPj4+IHdo ZW4gcnVubmluZyB0aGlzIHBhdGNoZWQga2VybmVsIGluIG15IFhlbiBEb20wLiBUaGlzIG1l YW5zDQo+Pj4gdGhhdCBpbiB0aGUgWGVuIFBWIGVudmlyb25tZW50IG9uIG15IFhlbiBEb20w IHdvcmtzdGF0aW9uLA0KPj4+IHJkbXNybChNU1JfSUEzMl9DUl9QQVQsIHBhdCkgc3VjY2Vz c2Z1bGx5IHRlc3RlZCBmb3IgdGhlIHByZXNlbmNlDQo+Pj4gb2YgUEFUIG9uIHRoZSB2aXJ0 dWFsIENQVSB0aGF0IFhlbiBleHBvc2VkIHRvIHRoZSBMaW51eCBrZXJuZWwgb24gbXkNCj4+ PiBYZW4gRG9tMCB3b3Jrc3RhdGlvbi4gQXQgbGVhc3QgdGhhdCBpcyB3aGF0IEkgdGhpbmsg bXkgdGVzdHMgcHJvdmUuDQo+Pj4NCj4+PiBTbyB3aHkgaXMgdGhpcyBub3QgYSB2YWxpZCB3 YXkgdG8gdGVzdCBmb3IgdGhlIGV4aXN0ZW5jZSBvZg0KPj4+IFBBVCBpbiB0aGUgWGVuIFBW IGVudmlyb25tZW50PyBBcmUgdGhlIGV4aXN0aW5nIGNvbW1lbnRzDQo+Pj4gaW4gaW5pdF9j YWNoZV9tb2RlcygpIGFib3V0IHN1cHBvcnRpbmcgYm90aCB0aGUgY2FzZSB3aGVuDQo+Pj4g dGhlICJub3BhdCIgYm9vdCBvcHRpb24gaXMgc2V0IGFuZCB0aGUgc3BlY2lmaWMgY2FzZSBv ZiBYZW4gYW5kDQo+Pj4gTVRSUiBkaXNhYmxlZCB3cm9uZz8gTXkgdGVzdGluZyBjb25maXJt cyB0aG9zZSBjb21tZW50cyBhcmUNCj4+PiBjb3JyZWN0Lg0KPj4NCj4+IEF0IHRoZSB2ZXJ5 IGxlYXN0IHRoaXMgaWdub3JlcyB0aGUgcG9zc2libGUgIm5vcGF0IiBhbiBhZG1pbiBtYXkN Cj4+IGhhdmUgcGFzc2VkIHRvIHRoZSBrZXJuZWwuDQo+IA0KPiBJIHJlYWxpemUgdGhhdC4g VGhlIHBhdGNoIEkgcHJvcG9zZWQgaGVyZSBvbmx5IGZpeGVzIHRoZSByZWdyZXNzaW9uLiBJ dA0KPiB3b3VsZCBiZSBlYXN5IHRvIGFsc28gbW9kaWZ5IHRoZSBwYXRjaCB0byBhbHNvIG9i c2VydmUgdGhlICdub3BhdCINCj4gc2V0dGluZy4gSSB0aGluayB5b3VyIHBhdGNoIGhhZCBh IGZvcmNlX3BhdF9kaXNhYmxlIGxvY2FsIHZhcmlhYmxlIHRoYXQNCj4gaXMgc2V0IGlmIHBh dCBpcyBkaXNhYmxlZCBieSB0aGUgYWRtaW5pc3RyYXRvciB3aXRoICJub3BhdC4iIFdpdGgg dGhhdA0KPiB2YXJpYWJsZSBhdmFpbGFibGUsIG1vZGlmeWluZyB0aGUgcGF0Y2ggc28gaW4g aW5pdF9jYWNoZV9tb2RlcyB3ZSBoYXZlOg0KPiANCj4gIMKgwqDCoMKgIGlmICghcGF0IHx8 IGZvcmNlX3BhdF9kaXNhYmxlKSB7DQo+ICDCoMKgwqDCoMKgwqDCoMKgIC8qDQo+ICDCoMKg wqDCoMKgwqDCoMKgwqAgKiBObyBQQVQuIEVtdWxhdGUgdGhlIFBBVCB0YWJsZSB0aGF0IGNv cnJlc3BvbmRzIHRvIHRoZSB0d28NCj4gDQo+IEluc3RlYWQgb2Y6DQo+IA0KPiAgwqDCoMKg wqAgaWYgKCFwYXQpIHsNCj4gIMKgwqDCoMKgwqDCoMKgwqAgLyoNCj4gIMKgwqDCoMKgwqDC oMKgwqDCoCAqIE5vIFBBVC4gRW11bGF0ZSB0aGUgUEFUIHRhYmxlIHRoYXQgY29ycmVzcG9u ZHMgdG8gdGhlIHR3bw0KPiANCj4gd291bGQgY2F1c2UgdGhlIGtlcm5lbCB0byByZXNwZWN0 IHRoZSAibm9wYXQiIHNldHRpbmcgYnkgdGhlIGFkbWluaXN0cmF0b3INCj4gaW4gdGhlIFhl biBQViBEb20wIGVudmlyb25tZW50Lg0KDQpDaHVjaywgY291bGQgeW91IHBsZWFzZSBzZW5k IG91dCBhIHByb3BlciBwYXRjaCB3aXRoIHlvdXIgaW5pdGlhbCBmaXgNCihzZXR0aW5nIHBh dF9icF9lbmFibGVkKSBhbmQgdGhlIGZpeCBhYm92ZT8NCg0KSSd2ZSBjaGF0dGVkIHdpdGgg Qm9yaXMgUGV0a292IG9uIElSQyBhbmQgaGUgaXMgZmluZSB3aXRoIHRoYXQuDQoNCj4gSSBh Z3JlZSB0aGlzIG5lZWRzIHRvIGJlIGZpeGVkIHVwLCBiZWNhdXNlIGN1cnJlbnRseSB0aGUg Y29kZSBpcyB2ZXJ5DQo+IGNvbmZ1c2luZyBhbmQgdGhlIGN1cnJlbnQgdmFyaWFibGUgbmFt ZXMgYW5kIGZ1bmN0aW9uIG5hbWVzIGRvIG5vdA0KPiBhbHdheXMgYWNjdXJhdGVseSBkZXNj cmliZSB3aGF0IHRoZXkgYWN0dWFsbHkgZG8gaW4gdGhlIGNvZGUuIFRoYXQgaXMNCj4gd2h5 IEkgYW0gd29ya2luZyBvbiBhIHBhdGNoIHRvIGRvIHNvbWUgcmUtZmFjdG9yaW5nLCB3aGlj aCBvbmx5IGNvbnNpc3RzDQo+IG9mIGZ1bmN0aW9uIGFuZCB2YXJpYWJsZSBuYW1lIGNoYW5n ZXMgYW5kIGNvbW1lbnQgY2hhbmdlcyB0byBmaXgNCj4gdGhlIHBsYWNlcyB3aGVyZSB0aGUg Y29tbWVudHMgaW4gdGhlIGNvZGUgYXJlIG1pc2xlYWRpbmcgb3IgaW5jb21wbGV0ZS4NCg0K Qm9yaXMgYW5kIEkgYWdyZWVkIHRvIHB1cnN1ZSBteSBhcHByb2FjaCBmdXJ0aGVyIGJ5IHJl bW92aW5nIHRoZQ0KZGVwZW5kZW5jeSBiZXR3ZWVuIFBBVCBhbmQgTVRSUiBhbmQgdG8gbWFr ZSB0aGlzIHdob2xlIG1lc3MgbW9yZQ0KY2xlYXIuDQoNCkkgd2lsbCBzdGFydCB0byB3b3Jr IG9uIHRoaXMgYXMgc29vbiBhcyBwb3NzaWJsZSwgd2hpY2ggd2lsbA0KcHJvYmFibHkgYmUg c29tZSB0aW1lIGluIFNlcHRlbWJlci4NCg0KPiBJIHRoaW5rIHBlcmhhcHMgdGhlIG1vc3Qg bWlzbmFtZWQgdmFyaWFibGUgaGVyZSBpcyB0aGXCoCBsb2NhbA0KPiB2YXJpYWJsZSBwYXRf ZGlzYWJsZWQgaW4gbWVtdHlwZXMuYyBhbmQgdGhlIG1vc3QgbWlzbmFtZWQgZnVuY3Rpb24g aXMgdGhlDQo+IHBhdF9kaXNhYmxlIGZ1bmN0aW9uIGluIG1lbXR5cGVzLmMuIFRoZXkgc2hv dWxkIGJlIG5hbWVkIHBhdF9pbml0X2Rpc2FibGVkDQo+IGFuZCBwYXRfaW5pdF9kaXNhYmxl LCByZXNwZWN0aXZlbHksIGJlY2F1c2UgdGhleSBkbyBub3QgcmVhbGx5IGRpc2FibGUNCj4g UEFUIGluDQo+IHRoZSBjb2RlIGJ1dCBvbmx5IHByZXZlbnQgZXhlY3V0aW9uIG9mIHRoZSBw YXRfaW5pdCBmdW5jdGlvbi4gVGhhdA0KPiBsZWF2ZXMgb3Blbg0KPiB0aGUgcG9zc2liaWxp dHkgZm9yIFBBVCB0byBiZSBlbmFibGVkIGJ5IGluaXRfY2FjaGVfbW9kZXMsIHdoaWNoIGFj dHVhbGx5DQo+IG9jY3VycyBpbiB0aGUgY3VycmVudCBjb2RlIGluIHRoZSBYZW4gUFYgRG9t MCBlbnZpcm9ubWVudCwgYnV0IHRoZSBjdXJyZW50DQo+IGNvZGUgbmVnbGVjdHMgdG8gc2V0 IHBhdF9icF9lbmFibGVkIHRvIHRydWUgaW4gdGhhdCBjYXNlLiBTbyB3ZSBuZWVkIGEgcGF0 Y2gNCj4gdG8gZml4IHRoYXQgaW4gb3JkZXIgdG8gZml4IHRoZSByZWdyZXNzaW9uLg0KDQpJ biBwcmluY2lwbGUgSSBhZ3JlZSwgYnV0IHlvdSBzaG91bGQgYmUgYXdhcmUgb2YgbXkgcmVm YWN0b3JpbmcgcGxhbnMuDQoNCg0KSnVlcmdlbg0KDQo= --------------VgW9HN3nCc3re0erqMuhpFcc Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------VgW9HN3nCc3re0erqMuhpFcc-- --------------qUq0m33xBxWW0oopzVEN4rd5-- --------------BMygs5DS03pxlw5GpFihyWpe Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLNd/UFAwAAAAAACgkQsN6d1ii/Ey/X Jgf+LjLb8OGQorltvt/l2MrjmUzcCLfgjzsdlE4OfYFdyw3PKQ+Fyvfr1W4G9qLFInX8AZGgoaor YaewHZgAfAlE6eGZw+6Fpavo6jBopOgA+RFAi2HIFXlFETxaKgRe2G7AAbVa71ztnlfXv0BOCLgi I/+gLKoT7mWes9f+BRkfhUOfQrvdOdh/ia4paZn5iqK9YpuUoz6BmuNA3NWYktXEmctpL/x6CkPE F449pjVw5sFAKmpRbrRc7B0I5gw+n0uzlqtjcoXYA1szzMCZHFTVSD+9DjFO0VQynNMfRx9sbcdM 4kfxRv4d7kP1I+uIlwBEIb26truy6KIp3rCamq79UA== =VZLZ -----END PGP SIGNATURE----- --------------BMygs5DS03pxlw5GpFihyWpe-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 13:40:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 13:40:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365724.596033 (Exim 4.92) (envelope-from ) id 1oBG7m-0001rS-VI; Tue, 12 Jul 2022 13:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365724.596033; Tue, 12 Jul 2022 13:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBG7m-0001rL-Se; Tue, 12 Jul 2022 13:40:26 +0000 Received: by outflank-mailman (input) for mailman id 365724; Tue, 12 Jul 2022 13:40:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBG7l-0001rF-Mh for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 13:40:25 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e75ce4e-01e8-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 15:40:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3839.eurprd04.prod.outlook.com (2603:10a6:803:21::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 13:40:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 13:40:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e75ce4e-01e8-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IjoF6xf/Dh+y7H5HGxJkzkjB9lw4bxWO4igEmGVw3HSqP49ZMDw0eds7cBLJGSjiF7rBzeT4U12b0n3YGjlp6bj4+SB5i2dfId6Gm/44iwdtSF5xPm+n4Pnk+p/W2ETi698RWWyzdvx9+xxYtIUehrbRZWr8Ce7CNzagsxNZ5W0yQBaV9dec5e4RjAVKnwwohQowiNp9eQvfJa0BB7W9dytmLsn/53XIESHKo4jtpq8ZkT3iq42kEZNdIV82BQRmvqxW5FJ01NjyrVYEWfSK3xvQNvd/v/nsPeHu2Q0pQL/ZChjL4smattW2/m79LaTpIjzhGWtjF9dNJfGnEnNoaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yckDpB+CZaEaxjaTr9UPPIv53wpyUD1nhmp+fMCR2Jw=; b=C1uryHjtDJw0x0mlgq2X2GcOD2nkjOsExw7vz/+Nito0KMbQkAXfYP1WVmQyc3qx9ca9X6s55rk6KKDXJ1lr8jdmblVTc+vPnHlSPDsLJ3h9q3ujX3QdbicheYG82I0Zu+F5dSBE57+XfG3+WL1ONE6orEbD9k164fbpuf8DEqwtCkcCz9Elq0/nfPlaNzIaiAmGivDROrNedT0nXcuc49Jm28IMC0EBVPp8b21fulvA8G9fp49AbU6zM8CD5hhbzFcHyLKGo0z5qIfss66QgXH5Bw4d4vKNIx2rcFWNMrEfbWxSTzclPm5cRYyCMKWA3TFJbgrW5KOpTbTAgGZvxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yckDpB+CZaEaxjaTr9UPPIv53wpyUD1nhmp+fMCR2Jw=; b=WjkF0rIefRPVexpPrpDwm3Budfhq1+hYyIu+a9bCh8WnOzBBMDWWqrvIIOZMO6H41tLbnEXimsTEiVJTZWdxJJmd65sGMXWSp3xuH00Q4ZbWUErLxrv8SkXXChydTWBXuLZN0+kz+U5g6IeXnoM2ZcpKEZxfbSMGvpPTZ/5mjQWQy+YWG8cZPVPT7bJV2RKhefqSkq78vnoTJMsnafwrheGOAin3XhMz1ND/O+rzXoKAFplJqa5zFSKNa0Nk7UeSrXbb3xgpFMToRxFv8O3VT4Iboe+Vr6EBRXFi8kGA6GdvsCn5kSBs5l3oMiyGzMWD/IjGSJbrhWlVUa9oF1eyJg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 15:40:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-6-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0321.eurprd06.prod.outlook.com (2603:10a6:20b:45b::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36856c2c-d9f3-446d-c7b9-08da640c119a X-MS-TrafficTypeDiagnostic: VI1PR0402MB3839:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BwA+iRsN3ZUeMvlS3fHKR5kQdCqaihQxlxN4h4EVVUeeC4mWhHew1YGYDAhUkRKWKmE9CvdGeW5YMt6WnRGRKFBTXQi3MH5fFZJPSadm51UVACvW6PxklKjk0Ak7R7c7F6Mt+hLn+TDjKVojdFdYYFaNTvvITyYbgQ3hOKdz2uJCZucNlMGbCrBpE8ZtG3TVwFM/COiWX+Q6lbWyI9xEStzmjy+UlVgxK05L08RoUSpCnbV+uggQA7k2G446kosRD2IdRGD3Hh9S0DBxSZSDu4bZhG4l8DMJi9ay6RrkVncHFydAsX/O6GMRJrV8qvlZjxU2SBkxqnl/GYC+RcO9SZC+UdniKQMRUkD/eenjfd78OFdkLKte3a+3JpxInnEiTD/ggmg3+F7LYzh6k4CdOfbr28Y+uEIE4MiSkw3EvU+ENhmtOO6PDpI22RX7VzfJ2YrDDB3VKw3dJnDV+pjJ+JsFCTaMM/letULIxrG0SkVLkMeXqnnSz04z/WqTYodxqfkPVoFD8t0FeBNisPta0SuYOGP1M4nPRZ7AztAtvPipEO2+DO66nHQ38+SvTQD/ckfXoOe3Iob1omBCjo2ZGxblC/uX5YWrbGUGAK17ZCCb3Lde1FFxa6kINCg0rJoh8I8x2DI6WrXPN8LMg55CATSlceowcMrb2zrOUJFpWcIn8zubpn2M2FKbP1hVz/FX8LWpczc8ixMt/710P+SM5mSVWxNaqqJOEfzxAtammJA6hoKKNjKFBvHwcV1BtFeznFfN4D+X4Pl/lHIP8IzgUVXHKgfsWYnsGivXN25OGIbTTUP4wf/uhCoM/lgQleo29KouckPPmwRpuftK35BWzq3CuiLLUS9elFPe9Dwdbvo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(39860400002)(396003)(136003)(376002)(36756003)(6916009)(4326008)(66946007)(31686004)(54906003)(8676002)(66556008)(66476007)(38100700002)(316002)(53546011)(5660300002)(478600001)(186003)(6506007)(41300700001)(2616005)(2906002)(31696002)(6486002)(86362001)(26005)(6512007)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SUVCVEwvbW1XK1VMbVNsSFhCMkRPcGFvZmw5NHFVNUg5ZCtIM0xQcGN0aWtC?= =?utf-8?B?QXlTYjFjdU9XZ3ZCOEJuQ3dFUE8rY2RQeWxGYkZJd3ptSHVKMGVZdmR6ZnBN?= =?utf-8?B?SUJjUm1QSGtlVUFwTmNhL2Uzb1NQVEE3Z3hDTjlja3dvTzdsWmZ6a01lamhy?= =?utf-8?B?WEs0YkFPYTR1bU9lcE1RV3Q4MSsyNWpIRGhyYkZHWnNSM0RZMUVvQjRRSjNu?= =?utf-8?B?eHJlMTg2Kzl2Rm1jQ0gwRWdaRFVlOFREbS84NFE4T2hrSDRSWnkwVzNvcnM5?= =?utf-8?B?cytlU2U1bHd0SElhMTBMMkF1cHU1QmxkakVoMWtESzVmSzE3b0xzbVJoNGtY?= =?utf-8?B?VzBpSWR1YUJjM0F4Q2xldXB6cmpmdmFnRkdVcW9DaWc0NGpkMThYelJtcndn?= =?utf-8?B?cEpnVk9jU1k2Rm84c2lHWXRVRXpVZHZpUzV1d09GeWc1NU50V3JFUm1ZNzJG?= =?utf-8?B?ZHpNOHNkUmlzR0pYWjFOWU1xVnhRUitscVVncWZGWkNWK0hDaFIvbC9JOWdS?= =?utf-8?B?Q3BOUVJOWE5HOU9BTW51L1VBaG5vYTVvTXZoNFNodGw3dkpHTGVLb2pXQlhL?= =?utf-8?B?cXl4dFVSV3poMU11Qm1MR2VtVGg4YjVVV2wycXNVRjBNRGJnVEN5dVRzb2Jl?= =?utf-8?B?blFXdWZzajcrbmh1RWl0VnRIZDZEVVpsSnJTbDJqK0FWbmJkamZZcUhwTjFp?= =?utf-8?B?bGYrcE1iRlhaa25BRGw5V2RGZVlEZUVIbWhCbEZiUVZiMjZldTFCbHNwSk91?= =?utf-8?B?ZjNiWjFXMVFvZGtIME9GQ05QaFpBdVQvcFBEZjIvcmFZOEZiS3JxVHl5dEZF?= =?utf-8?B?NUEwNmZrZHNneW9SdmlObXBnMDdtSmtCazJYd2c0UkJTQ2l4cVMweGNvR3BF?= =?utf-8?B?bERFaHNpWFl3K0RSN0JkbUxRaUZJT24xY09ZdHZ1Vnl0b3VEVUVoaXNNUnA4?= =?utf-8?B?MVhiL2pMbHl1WG1wUHprSFJBaFoxaGZVWmdNQms3U0hoeWl0UnFudjd6TkVH?= =?utf-8?B?YTl6bW13M3FpdmhvOGpiVElzMEFid0FGeS8xU3V3dlA3TDFsQ0xobThkekhX?= =?utf-8?B?K2xlWHIyWk9jNjZNNnpVS1kxaXpTbnE3S3lCZG0yWURGNEozSE9FVFNNdjZN?= =?utf-8?B?c3ovK0IxTE43MUVsZWJNVGU4NDFrKzZHaS83eWZIU0lCK21xaUtSQzBTVGNL?= =?utf-8?B?Vmo4VkNZMDZmUFBXQXV2ZWJsaThFMEkvMTY0UFd4T25Wbjdlb2hpaFF5SFQ3?= =?utf-8?B?dnRpQUlaRzA3N2NjU0txVXcwRGpDaXZxbCtaNlNJS2tFWWw0YU9CNE81WFpH?= =?utf-8?B?clFPcERkSFY3dk15VS9rd29XbGpjNjA3cVFxdHpLdkZrVDViNC9hM0VrbGZx?= =?utf-8?B?cDJVMFlMVTNlN0dmbFk0NzJRaytSVXJ4UmJwNXZaNGEyc1NaZ3VWOW85TlBu?= =?utf-8?B?bjNKQWtadXI2LzR1NklGaFdtUEVmNjd1VzNsVm9DR01LTUZHU2hWNU1QR1JC?= =?utf-8?B?NUgwZFdrZmVmMUFyMHN2Y0srUlMzQTYwQ1E3NUNDYXhNdnJSbGpPT2ZWUEtB?= =?utf-8?B?cFptdzYwUk1LL3E1TjJWRjdlem5KcXRJUyt0T3UwVGNENWNQc2U5OC92WFE4?= =?utf-8?B?Q3Z0bVRxbnVQcU9PNkJkcnA1ZUFCV2RkS3JzTy9IcEZrblRTN3Q3MVZEKzY2?= =?utf-8?B?S29pN2U0K2QwSmZZczJJbVBqaXZLa3FtK2JIQktMV3U2S285NVd0U2syOGFG?= =?utf-8?B?WWtvYzdKTnBsaU1YUVp3R2ExVWRFeWhkSXdLVlc5WVNDMzJ6VFlzeTNXNXFG?= =?utf-8?B?WDBaYmx0Wm81b3FBbmpML2pENERrQVdMQ3ZaaEo5Sm16QmpHQ05DYks0dFVQ?= =?utf-8?B?cDNjNzE5dVVRaUowQ2FEZ1YxZlpNQjJxazZkVmVtaEtRRkpiT3h4M0g3RVpo?= =?utf-8?B?VURVUlZxUm83ZEN5S2E0QW5kRk00TU9lWEgrc2g5RE1wMmtXRXdEdVpFTks3?= =?utf-8?B?ZTRtWDBkSE5tMlhENjBvT2p2VVJzN3diVTZ2MFVobFVUcnN1VlJlMFduR3ZO?= =?utf-8?B?M2s1dGlIOHhBTUpVa281Mzkza2k2S1l6NlVFcHZOU0h2eC9TeU1zVGFyc2VI?= =?utf-8?Q?F850LXQkDlc8ZdBtcE5QthTae?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36856c2c-d9f3-446d-c7b9-08da640c119a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 13:40:22.5181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o7L9UH3bNdoqk0w9vyLCsSt/mvPKPQ+PVyBo91G0iFYuA67rYcVDUvgjPaJuKqudzs243Fj/aW7/uaVJf0Ukdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3839 On 08.07.2022 16:54, Wei Chen wrote: > @@ -82,3 +83,25 @@ unsigned int __init arch_get_dma_bitsize(void) > flsl(node_start_pfn(node) + node_spanned_pages(node) / 4 - 1) > + PAGE_SHIFT, 32); > } > + > +/* > + * This function provides the ability for caller to get one RAM entry > + * from architectural memory map by index. > + * > + * This function will return zero if it can return a proper RAM entry. > + * otherwise it will return -ENODEV for out of scope index, or return > + * -EINVAL for non-RAM type memory entry. > + */ I think the comment also wants to spell out that the range is exclusive at the end (assuming that's suitable for Arm; else now would perhaps be the time to change it). > +int __init arch_get_memory_map(unsigned int idx, paddr_t *start, paddr_t *end) > +{ > + if ( idx >= e820.nr_map ) > + return -ENODEV; Perhaps better -ENOENT? > + if ( e820.map[idx].type != E820_RAM ) > + return -EINVAL; I'm sorry, this should have occurred to me already when commenting on v1: "get_memory_map" doesn't really fit this "RAM only" restriction. Maybe arch_get_ram_range()? Or maybe others have some good naming suggestion? > + *start = e820.map[idx].addr; > + *end = e820.map[idx].addr + e820.map[idx].size; Nit: Would be shorter to read if you (re)used *start. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:08:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365735.596043 (Exim 4.92) (envelope-from ) id 1oBGYo-0004v2-83; Tue, 12 Jul 2022 14:08:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365735.596043; Tue, 12 Jul 2022 14:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGYo-0004uv-5C; Tue, 12 Jul 2022 14:08:22 +0000 Received: by outflank-mailman (input) for mailman id 365735; Tue, 12 Jul 2022 14:08:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGYm-0004up-DH for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:08:20 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20051.outbound.protection.outlook.com [40.107.2.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 11b7cbef-01ec-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 16:08:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2565.eurprd04.prod.outlook.com (2603:10a6:4:36::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 14:08:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 14:08:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11b7cbef-01ec-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vs82eWsh1zv1WvGq+ozhg8iqLxuv3u/CgtN/VGY87qTPzI+cxdbZVdA8WZDWgCkLFWH6uLiJZozssjO+RBWo3Iq0QKRh6CKaGJAe8ZsC/DyORSoIQBHboe8xp3m3eOKFDPvNvnD1sQJ4sUrGDDWXgL9+AKGIVOmZxknG8i06+ls35J/M6LM+/QUj10MnI0KF1lTqs5frsF3mq6TuYxbDpQD8nFMUX3zsT+erNhBR8vwmaaDBlwMWxHT7IEEwG0ktTAxIPHdjj5WrOo9IPM6/4uV90Ku51LceutHniK8w1FmGfs27n2QjTwwgujeoLM7+kJA77twWMtvuuRnr+hSpNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TRbyhNYHEVlPFuK/oWbifwn8qoUX0JXA1pqeJcMgsQ4=; b=d1OLKd9rxDmPoHqTYXD6+cdapJ+p4NWeKZ8gYJiTQyt1zUiwIp1BztS57aNnApEikRQn08saYo8y+P0yh0UZzya9vqVneIK+Z3aZ2XSTzQ4PmitqmHlpvJCtLTG3R3K64XIwVAqbS/BTwq7P8XymNuUbF2+iZ3yxTXGQRe5haUg5Uwvd3DxElQz3mQ+GjaLUDLoFzc8ZNopolpbAPTnkKCORC/AennKwNYfP1cxFtzAUgOu4Bm6xpv/cab3PU1/AyD8vZtmbMyByoXWdbtUS8aV8qNqlbWW6OIT93jf4yhpJJ/DzFvnRIPwM0B1VP2prRnIEX4e/IqEPyu+YOF1CDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TRbyhNYHEVlPFuK/oWbifwn8qoUX0JXA1pqeJcMgsQ4=; b=SHXNW+nmrZl1CUdArr0kVkOkZKKvWtiT1ak1Q1q96q/h/Ab/K6kxvKtbUjdNtshxN3dnpQhoOrrFtpL2HRvaeUneP+0+D3zw7Y+I6PHZDwxklTyTjRO6nX4Y0EV8nSX1kdBxdNPPwecavIE82vn7fNxOG/7RGvFvyWPMMp6NySPzsIOL98UDO1gK7BYZ+VUroOVLyFAa2KhF5bIyulf8JiyfGwFUBhambi3Uv+LsmcAHr5lQvp0CdLIqHNOfdefQQ7Y/rZANzCiPvI6E/VlJwZRKfihY190NL4JOdUjGwgGDTabmwnubf81wmDPlxQIJxKTUrH0bEZCQ2LrNixOXBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 16:08:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: [PATCH] xl: move freemem()'s "credit expired" loop exit To: "xen-devel@lists.xenproject.org" Cc: Anthony Perard , Wei Liu Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5480c1fb-c3d2-48d5-f4ec-08da640ff617 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2565:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QRNjzUaQlM8yS9k6f3u0qCgHzIeNRuNr0WuMooB9PJDfv/Zp4SATaFIOwINYxs2aLhxD28SmyD/bd8JgRmTwW7DI7wv9Y3MB0DMN2Xnz3YpSbqkHPlKjQjJyRJQRbGWVMdI7TFDg4ai0jLP8LjdVRf/CONsPZ1mL1UMRLVLT2GzVyQiLLakwVwljGHwB3uISmNMH0UJ2xiMBb27LfH/XDjoCfan8w5mVpuPsrG4tIkdDkefBfx9NEH5a+vjN84bsgYVw5juLiO4rIdUdPK01ch0f7KcIhKc/lhm6LqYwvWswIlhVRsUeBrHSnFS6RRUdZ/W64lEklaoGXj/avuKnrfRp1AmdUQP3O8WSU8gEmhsDSMUlQ3eN21byX6c5hHThS+Ox0F4GNU8RUUuElZX7jNBMmv8PlG5YiEQFwGWbO73zWISLdhvoGsUfYCsytynZ9VMmlxgm+GmtMIB8HtRlsKWMGNQHxFGrEt6IcxKqKnyKHNdcceLKNaRINIbfz/JBdsQQmgwXcxNV/Ybl/RDmzl9Bb38sblgkaZjUiXqVwCH9WktbAUqsnbnYXXu24Lmo9FzIloDU2wFfwIEtHmnTriEEompFkumgw8A/mKwxSqlgq9W2tR6WGWf8lb4fDaF5YtFvosahLyZuf6laqIrbQiyF3XEPYFSl0v5SbJG0+0bJpdR1Py6ppTxkW5xD27dG9dkZHsg4epZQddEadR+ERMj9F1kJvGlrEwbUgI0MP6uE87QvIrA0KtZl/oxTODOukO3lDUJcgHiXZ3nvZcuItAbBTlXnsD2Hsr1Jiz+lG19Tj9FLpWoEal3Nf6r1bxsfkQh0C/0duVN5gRC/O6g47DoAT+UtkeAmgE5U40Y0sm0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(366004)(346002)(376002)(6916009)(66476007)(38100700002)(36756003)(8676002)(6486002)(478600001)(66946007)(6506007)(31686004)(6512007)(41300700001)(26005)(86362001)(4326008)(316002)(66556008)(2616005)(186003)(54906003)(31696002)(8936002)(5660300002)(2906002)(83380400001)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXBTNDEySjY1MVEwL0tLcXFFbXBkTzNGR0hXdHhEeG90a0hhdXhOVjZSMG14?= =?utf-8?B?K2hjYnBYWTFrM28zYTFCc1VCc0FPOXJPU1FEUCtmbVdRVUkzU3RzWXRjUk03?= =?utf-8?B?ZTQzbzdRRUNZMnk2a0crNC93SjJtK1hIVkxaNkhaeC9nWk8wMHFpL2RvK3pZ?= =?utf-8?B?d3lPVmxyMm1PRElTR0U5aVZ2NjlmaktoYjg2TXlXKzFNY3kwRDl4a0JOVmk5?= =?utf-8?B?R05JVlhPWFhaclBNd0d3V0ErRGU4bVdONDFYb2JHai91eExIUUhvM3o0eWJo?= =?utf-8?B?UGtMa0FjSGFzdDhibE45cmVUNXk2YzZSajMxd05BdG5RelB0QlZwbFZiVU44?= =?utf-8?B?RTlGM1U3NGhvdjBjdytMY1FQdjhQMnpnZ1VCUFAvWkdyL1NhNFk4eitqeHE5?= =?utf-8?B?QXlkb01xRzQ4S25VVkREYm43WlFVVWNCNE9rT3ptc0tqRW56dkU2VTFRQzY0?= =?utf-8?B?WUk3TXAxUTl0SHdPdFJrWHhkUlhTWmtaTFhXM0p1Mnc0d1pza0tkTlJUQzJk?= =?utf-8?B?azNVSmFma0ViM3JTMGlQTEZpR09CeURMWWlsSGgvZkM5VzJyL1N1SFE4SUFa?= =?utf-8?B?dzlKYktYSDJmdERQbUR0Ni9ibW03STVkWGJPdG5WK1VhRHZYb1kyeUJJSnBK?= =?utf-8?B?RnhyZlArR0N0WkhuNHhidlFZYWUwRzJ0cVdVaVFKUnNUdXVUQk5FTlgzQzQ3?= =?utf-8?B?eGk2YzJrMGUrQ1hveE9OQWtUMXhIc29HV0JiVGMyQXpWWGprUHA3V3dCOFh6?= =?utf-8?B?bUtpc1BxaVlMUVlaaHVkSjdZaDJvZWtta1NIU1FKTnZpK2xZOVdiNXhrVklO?= =?utf-8?B?Yi9ablpuL2FqRHRDNUpiMFkvTmJ4Z1ZveHo5WWNINy91WEhWai8xc0pNZjlR?= =?utf-8?B?Wk1CMzlqUWpjZVdZeHE0cW5NM1JJSjkrcWZLUlZRa3lBb0Y3dldhUTFudG1F?= =?utf-8?B?aXloQUZqTmJPaVJMYWRhZHNrbGVaQ2k2eVNvOVlQTnJ4Rks0b3ZLcCtETlZM?= =?utf-8?B?ekRIZGRNQklhWjdDQndKbHZFZWw4MTJMSCs1QVZkb3F3cXNHMDQ2SXZQR1hv?= =?utf-8?B?NU9CUG1rRTBRZUpZanJ3d0VDdkw0YTVEKzI1UzhxZysyaWpwTkJRRlI4dkZn?= =?utf-8?B?RU9CWitDdWszSWNQU0xvMUluSVE1Y1M2V3lSaHdRWExWTFd1ZW9mbnlJTVJZ?= =?utf-8?B?SW9ZNDRTMURxamE1TDhaRW1TWmhYSDJSTWFod01nRXUwTllsTEZxQXF2Y3F0?= =?utf-8?B?ZTdIMW4wb3F2NEw1a3dEUHNIaE5IeWtJYjFyTVpBOTk0OW50L0FVcHRNcVY1?= =?utf-8?B?UzhPSFJqL1Q4emZqWUR0UWxKWnE4aTRVQzYvcDdGd0ZNaGU1a0ordkhwNllt?= =?utf-8?B?WWplaWQ4NVdmdWU1YVB4WnVBbHpuYzNtM3Jla0hmalkxZEw0Y2dqdVJtODYz?= =?utf-8?B?bVJoNURqZE40SHdpOFFxdG12VFVPWVU1SjIrdVBGV3c4b1YycFc3OWM2UzVn?= =?utf-8?B?dFV0dXdJbzB4K0ZwcElhRk1NZUhhWTUwQlBrcmhaWVR2dE4xbE1rK0NXb2pl?= =?utf-8?B?VU5wcVJLaHQ3YVVIcG94TXdPZXlvSmJzRXdPNWdhZ3BQZFBrUVdBZVRrZXAx?= =?utf-8?B?WFdPR056VFJoRjBLZE9zSTUxYWg1TTFUR2loMG1xMFVQS0xVajFkTW4wVms3?= =?utf-8?B?YUxYN1lwU1pTQVBwVlFnTG80NVJzeUFOZ2djeEdIV3pRbVdIeTBhUk1PY2Y4?= =?utf-8?B?bUs3WW5jOFJ5MDB0OHg0eCtTRWtQUXlXYmJlUUVPZmJWU2ZUbFBxRFBNRC9C?= =?utf-8?B?L2hpT045dmVPQUZxblRoVUtTRUZZTDFJQU9yWGRpMk5WTW5IWGpSdENlZ2M0?= =?utf-8?B?a21xZzFEejJhMDNhejJFcGc3OFRpRkU3VEdSTTR6VmhwTUl4VGVWZ040SXhJ?= =?utf-8?B?NWM3aHdVYWNvZ3Zrem1MejIwa1dreXZlM2FuUjZpOGxJV3hkcXdweDlSWWdP?= =?utf-8?B?dzlZdFpIeFhJbS92QitwOXk5VWhiR0ZnTmhrTm00dFNKcU4zQ2JXa3UzZTho?= =?utf-8?B?Y0YyZzRXTWJKUDhremFzdFRHU1lyY2IvenhuakFHT2FmMzNGQmNobGE5bUtQ?= =?utf-8?Q?NGpoiSc8c5oYhmAIPrFAbOOpR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5480c1fb-c3d2-48d5-f4ec-08da640ff617 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:08:14.4586 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +jgGI1/AlS/VXQcDa9kLGFUuMM+FinvOGJVzzvR9TO5qYvOacjn2rbZ+uN7pnoEWAgnuq5MVMBzytD69WjR9vQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2565 Move the "credit expired" loop exit to the middle of the loop, immediately after "return true". This way having reached the goal on the last iteration would be reported as success to the caller, rather than as "timed out". Signed-off-by: Jan Beulich --- a/tools/xl/xl_vmcontrol.c +++ b/tools/xl/xl_vmcontrol.c @@ -332,7 +332,7 @@ static bool freemem(uint32_t domid, libx if (rc < 0) return false; - do { + for (;;) { time_t start; rc = libxl_get_free_memory(ctx, &free_memkb); @@ -342,6 +342,9 @@ static bool freemem(uint32_t domid, libx if (free_memkb >= need_memkb) return true; + if (credit <= 0) + return false; + rc = libxl_set_memory_target(ctx, 0, free_memkb - need_memkb, 1, 0); if (rc < 0) return false; @@ -354,9 +357,7 @@ static bool freemem(uint32_t domid, libx return false; credit -= difftime(time(NULL), start); - } while (credit > 0); - - return false; + } } static void reload_domain_config(uint32_t domid, From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:21:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:21:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365742.596055 (Exim 4.92) (envelope-from ) id 1oBGlO-0007KL-Cf; Tue, 12 Jul 2022 14:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365742.596055; Tue, 12 Jul 2022 14:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGlO-0007KE-8x; Tue, 12 Jul 2022 14:21:22 +0000 Received: by outflank-mailman (input) for mailman id 365742; Tue, 12 Jul 2022 14:21:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGlM-0007K8-6H for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:21:20 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2089.outbound.protection.outlook.com [40.107.21.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4f58bcb-01ed-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 16:21:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7631.eurprd04.prod.outlook.com (2603:10a6:102:e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 14:21:15 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 14:21:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4f58bcb-01ed-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oW//iuQdFdLV/jOEQMAgz8ZubMTSF0ORg1qSKiVF8zqHUk3N2vXYQ7NlntYfroMtZQDEw/y8efzsH3vlmLLDNBwW8wRBb9of1FwmQmhjZE68RtPqGJ9fYZQHJkSAOYPxOWf+K8UlhqrmmI+7xHlgPpH1tdem8jCb9qWZkfDsPT0on+bRpyQUJ32U/ttoDyPg5pI/gZt3H8AkVgzXY8RZ/ThBg0vtVv7w+WYOuB3+86Osq2erPpTWjnZcGBhOQH5K/h/Xa70wom24CM1Baz2C6ggaQMUBZggpDc13XdmtvIedV5NjQfBcTU1fVTtgIARDkmZdwA0IyuVyybhgoUsQnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vyKXg2fyjphDhUQcXUDk7sZjrbmSx91MUx61taDhrW4=; b=HAtJnFT2xZu/FZ9VOfUVKEUFsLK9k1Tw6XXA2agFXQHMKGIS1jH1e517W5aAP+PyCCePwzPCnYCcWhchr3wvaBZ6zPH1kBjbpfqNSXRWXI8oqpsISmKj5v4+ssbcxosMDFAQUGbBjb5d4vkmapD8qb/9BYOBabDRil5hLNxOWChhGcqPqQ3SaEPQR16TSqUGfpEwKZ/8gu1SMCuXBvAUc8bvvZ6cVL7WDDPp14IL6mO0GyacWWofh3o1LskpYyQoEA89ldCTjsij5Nign/VQssoDSiuz8RdUxbzCHx0n7H5njsZw0wBejvUdV8o4b04k9Kpoytp5GwQX1x67bArBzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vyKXg2fyjphDhUQcXUDk7sZjrbmSx91MUx61taDhrW4=; b=guPuhE2OjsKjcg3GeQoZAv9HVqUbQubtvYaRNeSgnQ3aJw0P5HqGjEotJ4Un63e/Xu+gpjwV+xPKqsVv1E4X0yKsdJ3tSKl2a86Ni44xxsGwYt5kJnrmvFI5FZ7Con/SADftblq87tFVDtdyr4AImrdKGaDEujCdx9S5eKMTTvO2VCDC5i96pBJawkTAXqGU6vM3xQPuS3sWT6k6cf1+VegJ3L9yxAXjKIof3r34QZsMN6N6Vg4E6YsgPoQa9BQp3hGDRE57FZTatxruEEKCavgiDgwIDsnK8pL/DgohYmltkM6McxtIJAQsUS7cTAGkZfdOqivjmZ3Ae8Dw07sJng== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <357fc6ee-3014-4be9-9bf4-60669a4ca914@suse.com> Date: Tue, 12 Jul 2022 16:21:13 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-7-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-7-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0339.eurprd06.prod.outlook.com (2603:10a6:20b:466::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0ab8d19-702a-443b-2eed-08da6411c7c3 X-MS-TrafficTypeDiagnostic: PA4PR04MB7631:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H4eLxqWFnLV/c5mdBvQe14ATarsRR8XcN6fwYJoiKDrglrK64oAxUj5H1BU+Iv7/tQP2WJhPtGMxRVEuqYxryB+qM2V2nrjMhgAqsuGY6IHVyQMemPGgWUgwBCJqJcrvKR4+cFSgC36cXoIYEopPph39UNVUNggE0mlqK7wakiGefN8K3oNbsuDvX56m32RVcbfqMYx/BAy75DAw5LQUduKN+x/5/cMgGKN5zidKwDvKC8Yq4tlOJCp2//TcuyRHEZZG9FMAho/dhwyqqr3bK7j0NsmVFGicRkihTCSYlW29SiSU8/j/6/ZzJpey0Vagt/zerS3NZ58vgaBKfXr30/Y25+gBux48707cOOOaDaeBSoKKy92a9tgZYdCg6TDa41KW320BRj6eK0sZQ6nHRMq2pQaHtG7oAs/r38A2OqghmQzdVqeBUfTYDjB2RlEGUQAwmdCLKmTwzL4PUqqdpgNK5el2LC1FDXborz9z+1n2vZYhu1C0dqd/laywzVOO5RfGTs5KT0vKIdaakF2E+GNTqRz+RlnumC/4lqYvrwdP9nfX/wH6LLd/rJoEHZsWEhzrYv8KBRnsFpCuUBgw+cSkJLaQukoOa4o7oWpaYlTG/ObZIxXstTHO8DfhelJfBHNBTeBEAXgXxVg9luh02EYGiGO2rVh/mYADd1CJrGN+EUIgzvq2AWMWhXUt0IpWBosHC96RGCBDlL5yLZFk655KAFobZIB4IhLRZcx6YSYxSdpt24nuv2MCor2aWHbd6y9FaSm/tsacs0LH+9qNLHrdLqzlA1AydUjvOjbVabrP42edy6mRuDe2WaSgEYFrbLhEcOMqpTR1Z3TPfvoAf2d3MoYJbcqIlg66jdSZQEI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(136003)(39860400002)(346002)(38100700002)(5660300002)(26005)(2616005)(186003)(53546011)(2906002)(41300700001)(6512007)(86362001)(6506007)(31696002)(8676002)(66946007)(8936002)(54906003)(6916009)(316002)(478600001)(66476007)(66556008)(4326008)(83380400001)(6486002)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGxUZHZscW5hSDdURUJNS3JHKzNCK3YyOHR6dXV6bHNuMEd5Zy9DdERLM1NH?= =?utf-8?B?TkVxWlQyeXNyNW9qb0d6VGZvbHRpZVA4Uk44UXd3NEFDbWZraTRnR3NWOERH?= =?utf-8?B?cHBtU3N3eDF4ZTF3a1FvblU1cHMvdjl4NGlvL1U3UU5hR3RkTkZya2YwcXBs?= =?utf-8?B?SW91RTQydEZLTkRwR1VUMWlFZnJqVkE0RENMazJ1OVhqRU1DeFF5cGgyS28v?= =?utf-8?B?eWYrbThaby9LcVZKV0cvK0ZsMGsvTEcwNy9vZzk1QXNNbHRNcFRXY2RpUUJJ?= =?utf-8?B?bEd1RGkwK2pmRlNxSWRxNEZyL3NyRjdnOEJHajBEQmEwZ3NoUndkVGw2ZUND?= =?utf-8?B?MEhLR2V6bHNBYkhGQnBUQW5JZnRVQVVDNVJSVGR5OUZ5NkZoRDVmeW1qQkts?= =?utf-8?B?TkhqMU9mWm9Eai93dXpRVTQxZU5JMlVrODVFak9Ua0Q1MHdydnR6N3NvdDIy?= =?utf-8?B?SWlBUXhGYi9UblFUY3B6RWNhd3ZQdjMram1ieVBSUVc5MWpCM1hETC81VzZX?= =?utf-8?B?RHdDL0JKU2NDMjFna3hLc0daWkt3blFoSkNyWlc4S3Y3V3AvNEkwTGZrejM0?= =?utf-8?B?OWVheGJsaGtMSnBobDNHNFJxV3VQY1VaYk9Fc1JIUFpYVDQ1M0l1cmYzckt6?= =?utf-8?B?enlpbDZ0WmNyN1BocmFwc0xTak5IQmpKTGN0NFBNM2RpbXRuZXZVaUd3WW92?= =?utf-8?B?cklqUXIvK1VKVHFpV2VuckRPMmhlL0s5MEVpRFFnSW1jeGw1bGd5dFNnYW9V?= =?utf-8?B?UkMrdjl2di9UMnBvWkpwanJzbWlHTGVoSDJNaStDNGJoN1orT1NCYldCeHN4?= =?utf-8?B?citGUnQ1U2ozWWdkbExDUEs1dnQ3TERITlBpNjIxNHNiN21tNUtFejIyT0kv?= =?utf-8?B?U0ZzNkFFVmg0VzNoZ08ybW9sRklsTitKUXJXNDJOOFg2OGYwQ1BJeHB1M2E1?= =?utf-8?B?ejQ0eUFrMFV1UTNvbFFKMDVuVk1rM3ExNE5aS3V6NnhrRnJCQ0R3Tk5RTGZF?= =?utf-8?B?Nit2ZXBPYUlQcFBRU2wrdlZscW5UQXNuZnF2UUdaeGdsMyt6bnpPSXNvcGNM?= =?utf-8?B?cVhRNjc4WC9Dbi9oTlEwUVZRMnFFZUswOTk4YkZqaHc0MFhEbzc5Sk85cHBZ?= =?utf-8?B?UmoxZWVLSTBhMWFXMExTUGZRZUR0bWwvVmNZOEZkQXF5VVZxU3pxZm9MdGt0?= =?utf-8?B?Z2dOSVVWanJiUTh3V01SbnVJQXg0anh5VVJtTkk0TWgxNXNRUXZkenlzSVZ2?= =?utf-8?B?eTZOT2IyMHRycE42NFhvNmFRUHY4eGViSHBvZ25WeTMyQlBrVWJtR1RsRFRo?= =?utf-8?B?aHVFcko5N3FmMHVGN3ArNXREOVFnTWRXUHNSSEh6YXQrdGlDQTZtWXZtL0Mw?= =?utf-8?B?eTc2WnBwTUdaZWlJYUgwN0k1b3EvQzQyKzB5N042YzRqM0RWNHQrQ0VBM21F?= =?utf-8?B?NENKbktiMU4zdXppTmR0c3ZEWXZ4S0xLeGtyNGQ1TXJQQWJqODNBWG1QdjJk?= =?utf-8?B?UVZCUEFsR09IZ1BjakhVMTVLMFNUUDg4dHNQSHZwWE0xRHk2RnJGNm13bUZQ?= =?utf-8?B?alErcGFtRHVCRVpUeW5HTnVhaXJuK25GcnhveEZSdEdyNUczNlZNUk1uSWhT?= =?utf-8?B?V290dkpWZ2VoL0lUVGI1VUtoNEU4T1NRR05VYXVhTTBSSFltcE0zQS9MZUR1?= =?utf-8?B?bHB2UGI1QXZDRS9tV25MUjVTVllUWkVQSXpzLzRlTnNWTEkyc0FBemtzZ1dh?= =?utf-8?B?REtPZUhscDdnaHNUR1drbXZueE1oT20zR3FSbnFCd0RvazRGNVJUeFhnSVVW?= =?utf-8?B?eG1jeTJUUDN0SWVVYjZYM2s3ZUxXQk5sZU9TVm1YQlhaZUVuMnFaektTbGZn?= =?utf-8?B?d3YxaHhTNmpVRFl2TVF3UVo1UlpZSEdKRVZSQnRDT3c1Zjh0RElzMURUVVFv?= =?utf-8?B?VDNOR09IRWJtM1gvQ2ZDYUhaWjJabVlzTk53QngvMis3bGFiTGdhUDZqVXBY?= =?utf-8?B?c0kzNDdKdGtvU1FLeU5nSkU2RW5Fa0tTcituVFpvcUJEWjdTRkdrNUtiNDk0?= =?utf-8?B?azR3WUdLSU5nU0QzdkhwTE5JbVUyWFBmT2ZHTFRjT0ZOVEN2MGZVc2p3aXlD?= =?utf-8?Q?RjqQhhRy3kz3olZOp6g8H+njX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0ab8d19-702a-443b-2eed-08da6411c7c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:21:15.5963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gyF6N+bPyVmpWaxjAIQYuM6FdCoLjTFiShwESjWrQ21bvRPtFHkC9YPw1HPwLcbyx77nIUNDs2pwMzkJCxgnlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7631 On 08.07.2022 16:54, Wei Chen wrote: > x86 has implemented a set of codes to scan NUMA nodes. These > codes will parse NUMA memory and processor information from > ACPI SRAT table. But except some ACPI specific codes, most > of the scan codes like memory blocks validation, node memory > range updates and some sanity check can be reused by other > NUMA implementation. > > So in this patch, we move some variables and related functions > for NUMA memory and processor to common code. At the same time, > numa_set_processor_nodes_parsed has been introduced for ACPI > specific code to update processor parsing results. With this > helper, we can move most of NUMA memory affinity init code from > ACPI. And bad_srat and node_to_pxm functions have been exported > for common code to do architectural fallback and node to proximity > converting. I consider it wrong for generic (ACPI-independent) code to use terms like "srat" or "pxm". This wants abstracting in some way, albeit I have to admit I lack a good idea for a suggestion right now. > For those NUMA implementations haven't supported > proximity domain to node map. A simple 1-1 mapping helper can help > us to avoid the modification of some very valuable print messages. I don't think a simple 1:1 mapping can do. Surely firmware represents nodes by some identifiers everywhere. And I don't consider it very likely that we would want to blindly re-use such numbering inside Xen. > --- a/xen/common/numa.c > +++ b/xen/common/numa.c > @@ -14,6 +14,21 @@ > #include > #include > > +static nodemask_t __initdata processor_nodes_parsed; > +static nodemask_t __initdata memory_nodes_parsed; > +static struct node __initdata nodes[MAX_NUMNODES]; > + > +static int num_node_memblks; > +static struct node node_memblk_range[NR_NODE_MEMBLKS]; > +static nodeid_t memblk_nodeid[NR_NODE_MEMBLKS]; Some (all) of these likely want to become __read_mostly again, at this occasion. > @@ -32,6 +47,298 @@ nodemask_t __read_mostly node_online_map = { { [0] = 1UL } }; > > enum numa_mode numa_status; > > +void __init numa_set_processor_nodes_parsed(nodeid_t node) > +{ > + node_set(node, processor_nodes_parsed); > +} > + > +int valid_numa_range(paddr_t start, paddr_t end, nodeid_t node) > +{ > + int i; unsigned int? Then matching e.g. ... > +static > +enum conflicts __init conflicting_memblks(nodeid_t nid, paddr_t start, > + paddr_t end, paddr_t nd_start, > + paddr_t nd_end, unsigned int *mblkid) > +{ > + unsigned int i; ... this. But perhaps also elsewhere. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:25:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:25:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365749.596066 (Exim 4.92) (envelope-from ) id 1oBGpX-0007vq-V6; Tue, 12 Jul 2022 14:25:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365749.596066; Tue, 12 Jul 2022 14:25:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGpX-0007vj-RB; Tue, 12 Jul 2022 14:25:39 +0000 Received: by outflank-mailman (input) for mailman id 365749; Tue, 12 Jul 2022 14:25:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGpV-0007vc-Ng for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:25:37 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60052.outbound.protection.outlook.com [40.107.6.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7efa81b2-01ee-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 16:25:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8884.eurprd04.prod.outlook.com (2603:10a6:20b:42f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 14:25:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 14:25:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7efa81b2-01ee-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=blc8Qvcg1AHbe72T+m+trXu8MLQuWys2dmHnyAXohS9rfkmUsv4ZoXw6C7eV169wL2aPDx1Sv4lqvFTt20UeU6TjBYene6Z8+82oEtMg3mZjHA4kqPhAtLrW43XJNxTg92tmTUYNEn7q2DqewW52aAhpi2SpztyQh715qWrrNGVuRqJ1RyeiDFgq+vFFpnAFLUB640pRJlTJEdIx4tWac/J9pHF7grZuyZnZptudAvDAU1NwX1kkl9pLs+U24Pk6Bcrwqt+mlnRaS2uQa4EXRbUJfag3mOg9MK+xFWhe+i3paDoqWEJRUeVBGdWpu2zpR/k1cDs9PPi0Hn5bVuGtkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JnGDZCiSKW2A8fPt4iaXqGq0kr2RHdUx6hd/eh7V5I4=; b=fqL3e38sfoOxwGnq+Q5jnsQQMZvVObJ+NgnpDjvGW2Hg6I5xN52HamSDWiJUcM2pi4wo6CbhRjzL0zLjNssC3Ge/WOBPdD8k2B1dvCX0euinPmFWLdYu20I3e1W1XLMbWV/u/QCYZIuhKhT6w5iFmRovLxom8M/rbQWN1XRgEaDILT+I7R2doWR7ylf0fOS57r8n1yZYky1eQIFu9Dh9/2xG6Mw9tdMvJ2vYVL4ZylDwtY8NoK35IQ+0DFTnQucVBNo+p/ZFJtE/+lPEZhEu5Re7jhM3XrFXYGQqwY9y3cs6wd57OftMDddXaR3zbopllIBl8EJKd9t1dkqAcFaZ+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JnGDZCiSKW2A8fPt4iaXqGq0kr2RHdUx6hd/eh7V5I4=; b=SZfAJonm3Q+j7OisAFXicCmjYlnAmS5n9Obc+hu5ZVmzWn6hBs/CczaARwFO8IO4HmlOBm1VJ7me2yfWcI1QhZv2XEPna0T3fcQfPo53qsvQbulAVdW/U1Cm21/JENdP7aYUEmZVCAhBzl3A4/Pq+knI4cRt37K1IsBaWF6KGokjx/EJfsHIloBbDPZlF1Fz+daZmPYjAI63Z0AZlimfiFo9kkVtTl/NHu99MIHns2bEWxB49XkAOvhNo/v1sWQ8fh1FnInhr6xbLc4eHCvtQqS9wloZiZ+SQHAHxBXtcDaUl1Cd0kA0zyArYZx6V1p6WH+mWbkHW8SIedNRTOoFrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 16:25:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-8-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-8-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8b4d2ddb-9260-4efa-decb-08da641261cf X-MS-TrafficTypeDiagnostic: AS8PR04MB8884:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tuoduSuV2TVQM38fkhxmlBRv2qM2x0eNpsadRqnfG5Q8mEbfsCTT3ZIxJfxGaVeIv3H8zx5YyNeTydWGPpIUKXayfErIz6lGznmXlcke4zRqJ08zjotPJ8XTRo2033fzH96RB2M2dU9hM7AAXCGCTgYs+a7Q0rjeyhZ1kVqUcYTG5RsLNeulD7OZBe6lR58pnQHfayyuI8rc0q8J1BDKxa6DFK9dDEt3i9x3UMHW2CKLVZhzziBLe1peOs+0GYg6uuoEKCP/sZdLDd8PDdmeYZzWOTm71Z6hygvh4LgTGw9u5WVU5RrpUwZvVUmmJu+6p0Pjk3hmpeeDos18lV6LThUDG3psOGZSvYsD6GQhv3AoHDawyulzbTLQUdBqXJJcUSowUAAXYmlaV1rVPtiRDIuLknxczq4CFOLFpGU56/FMohPCLz+Vov7TYTgHtwHphwF81X+Gz/SlprByj+XPVAJMEwbSxsyTTPk31TylElurxpRFcyAgGUcVuwjRgTcG2uXeHcFWfu+YYeSh6XHxlD2ayVFSoj7AK6wsaAcrCn6Ha/Ol1ZxEm6+UnvegtRrsr7srUqswlRJpKmGgqnmOQsTKl3h+sMZusU1eyTbEQ9ljZ887oNFjyPkfIgsVxaP5/leao1K1WUPxlPw3L9MENFm6+k9k0AaSCPCAQbd2aaCEV9Vyc8TAULrtmaCCsfrTTaJVmEnJ+rCvpxmxBYWKUMcHX0jWPistDpXbP5RY2iQ/684jf7VdKlLM7f2wXxNpkU+aF1RBWJ1zKxFGC2AVPZYN58o2VjMOpAZWSBb/Kx/SY9kXpSTnaySe8scpRWwjcomegiYKwWOuozzGxUjU6wzQbsPkOq8IQgDKTcv8pV4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(136003)(376002)(366004)(4744005)(31686004)(66476007)(66946007)(66556008)(6512007)(4326008)(6916009)(26005)(38100700002)(2906002)(186003)(36756003)(5660300002)(8676002)(8936002)(54906003)(31696002)(478600001)(6486002)(53546011)(6506007)(316002)(86362001)(41300700001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S2xnSE42dEN0aS9haFZRbVNrY2l4d2VIKy9VUDl5bHczNnB3MnBxWTdka0Fu?= =?utf-8?B?elRtc3FwaEtadHFJMkJZZGhZMDgzTDRhcVljQUYrWnpjc2tHbjg4ejZ2SDV1?= =?utf-8?B?NVBlY1NFUXIrZ0ZzTXBDZ0tZbnJ5YjRoNlI3S1BQN2czOGVKZm9NVENhQzBZ?= =?utf-8?B?QmF4Yk9BZW5TdXVpMi9oWCtoM1hBSytoUUVuV2N6K1ZoQkhmcW9BclpWZ1dK?= =?utf-8?B?ZGc5MGpnY2pidE5hbStpKzBkOTBHeUl6MlE0YXNpcG5JcXArN0wvSi9mVS8r?= =?utf-8?B?RnV4V0F0Q3ZYUW9iZUVIZnN4T2dpcjl3bzRPQThvT1gyMVZCd0tscTdhcTJy?= =?utf-8?B?ck9TL2tzQS9jcjlrdG9MdU1vdnJ0U1B0YW9WWGlCRkJoWVJQUi80eW5odWlj?= =?utf-8?B?SG4vT0x5Sm1nYmIzcUJFL3lMUTZRczNMRGlwRFBjVzJKeTQ0d0hScDZLNkhZ?= =?utf-8?B?Si93NU1sSzRFV2VFUDNyaWpmRzh0Y2tNQUlLdG5xays0Z3EralRSMld2b0ZD?= =?utf-8?B?aTJhZWQ3Ykd4dVBwTUwxSnBaRS9FblFaRldSdUMrMWlnWUpwelRnblJ6VDQ1?= =?utf-8?B?Ly9sb3pXbndWNVRMRVhhNW5McjBSa1JDa1JIdUFHNkZYUENPN1lYTVFIOU82?= =?utf-8?B?dnl3Skd1VnZUZkpibkthTHE3bmNVbFd4aTY3eDBIWGV4c1hqK0ZHUERWeU1o?= =?utf-8?B?a2Y0MWhnZHkrVWdRWnlOYmNaOTdFRFVGZmltaDZldS9udjF3cDlHdFBudG9h?= =?utf-8?B?K0UwY0VWV3MvM3VaSWlEL2I2cmJ0T0puUERuU283REkzSUZpc1NZUnF4LzY4?= =?utf-8?B?Y3dLQlJhWjIza284cEgwVlZaUTJGSnMwRmkrbFdaZU5vZi9CY0txQWhXT2Ir?= =?utf-8?B?YTNOVjVMS0FmNUxZNWFkMmJFektlMzBsNUNyMHU0S0k2ODRNNDhYQzFMTTRF?= =?utf-8?B?WDZpNEhxZFJmNzVMcGQ0MkF2enVtd0xNMk9FQ05SRTNMeXladGlXeG4vM1ZQ?= =?utf-8?B?UHlzU2pneE4ycmNoTFUyc2FzL2FoSkZnb1ZZK1l3TDlLRWNDbTVNdHJKL1RF?= =?utf-8?B?UFh1ajcvaE9WTkk3Vjc3Vll1andBdlV3b0x4RTBOM2FrTFIzVm96NDF4R3VY?= =?utf-8?B?S2ZBSERXa1hDbVI5QXlNODVQVlNsVVUxVTR4cENJcGZnNmdxdXVkUFg3ZVBx?= =?utf-8?B?blBEclFqWWx6bmxHYWdsWDJyRVJRNFBVZ2JSdVZkWE1Rc0d3dUxWRURrYStD?= =?utf-8?B?aCtkQnBWYUpsb0VCSXU4c2dYMitZK2pkTnVyQlRyN0UzRXdvY1FRcEZxWEFp?= =?utf-8?B?VDVBaFpMTnhUMENjdmhlZXcxSHR2Y0FhRHQ2WTl4Q0syRTJJbnVzYWVCWWs0?= =?utf-8?B?SjlUZWFibnJ4RXFDTkR3a0ppMlBJUnpKVGJQUjcrSTErS3ErQ2FYUEp6cDUr?= =?utf-8?B?T1dDaitEUlMwbzBxOUs3OVRZOEhRQUVJRGpBSlB1OFNndGFJQkVPNzE1SzZ5?= =?utf-8?B?NE5aS2tCcnlDVGZGbWlnN2t0Ymc2MEVzQktjWXVCMms5RzBYRDJnTzZQVVFn?= =?utf-8?B?cDFiWER0NGtObnlSV0NxTHVKSE9WKzNoSS81NmlYb0R3YWc4bHY2QnR2WTR3?= =?utf-8?B?dU13WDRIU2FPMzVxaUZTVW5laE1nTGNPck1GSUpyT1JvQm1iZ3gzRjBIZ0pY?= =?utf-8?B?dSt2cXdkVTg1YlFUYVUvaE1adUVid1gxWi9xQUZmeG1mZTE3aHBEcFFjUjdj?= =?utf-8?B?QzR5UW9HQ3NyY2lsRThSSTBYMGZ2VkpRL0tISzZIK2wzNXNVdFJMZ2RsbkEx?= =?utf-8?B?VUM0SUFSK0preW5uYlJUSGtMcVdXek9GQUtMNlFRM0VGM2lFVXRaa2c2NHVo?= =?utf-8?B?NWsra3VNb0tqWVh5SWxINTA0Q0ZOWTZBZE0weU9QaUxGWkFMZUZnQ09aWVdy?= =?utf-8?B?MFY1WDlqamJuaE1vRlZpaHg0aHo1ZEI0dTk5TXgxblZvMW1LYlVORmlpalRa?= =?utf-8?B?M29vc2g4VitJOW1kRWxKbTd4YXNXYXZpaXJDazEzK3BYVlZPK2FrbzVnZWt0?= =?utf-8?B?N1ZXcEQ3R0ZzVDhBTUIzUzF4U1BRUi9EYXVQbHhJc2tpbnU0MGJ5UGo3Y1h6?= =?utf-8?Q?NxbcJ0jp1z6Cs0wHbiMoPM/J2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8b4d2ddb-9260-4efa-decb-08da641261cf X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:25:34.0329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V/24w1cLQdL2hTXSHND3KRvqVIGDJcxmBEkO4XFsOJVskeF9vfVVKcZ+90tT2Iz8edYNthvL8P1Be7rUf9yi6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8884 On 08.07.2022 16:54, Wei Chen wrote: > When NUMA initialization code is failed in scanning SRAT. It will > call bad_srat to set disable NUMA and clear relate data. But this > name is ACPI specific, we have moved generically usable NUMA codes > to common, bad_srat has came with these codes to common code. But > it's not reasonable for other NUMA implementations to implement a > fall back function named bad_srat. So in this patch, we rename > bad_srat to numa_bad. > > Signed-off-by: Wei Chen > --- > v1 -> v2: > 1. New in v2. I think this wants to come before moving to common code. And I'd also like you to consider using e.g. numa_fw_bad() or numa_firmware_bad() to better reflect the original purpose. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:27:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:27:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365756.596077 (Exim 4.92) (envelope-from ) id 1oBGrG-0000IK-Dq; Tue, 12 Jul 2022 14:27:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365756.596077; Tue, 12 Jul 2022 14:27:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGrG-0000I8-Al; Tue, 12 Jul 2022 14:27:26 +0000 Received: by outflank-mailman (input) for mailman id 365756; Tue, 12 Jul 2022 14:27:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGrF-0000Hr-38 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:27:25 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bd8e136e-01ee-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 16:27:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8884.eurprd04.prod.outlook.com (2603:10a6:20b:42f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 14:27:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 14:27:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bd8e136e-01ee-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gs/bs227FQ14hfUtXrV8N8iNuGg75fTFRJsPiuGt9Atjz4P7aYGiFEuLMlu4c3RlIVYJa5MWFsjf3llL1m5V1YM4wrSfoyQWMgarj0itI7iqMXxS+G3ahLeCg9/BtXT4oq1UqAfPpxXyLxqfGvOQUUDdj8hU9+Ifv5OJ31+HzuOMtp6+DtI36hZ9WHQKS8GCqH3XajK5LYlqL6+a0lp8d5y1r3b69PP0PxARGVvNIwEOtDCkTMwntFYwtJ2ME7eJ+iVYx9SHOj+FaCq0Yrk1O7fGp8vKxsUe415ievgG5/jmqNzD3sOm1FHGzeCt2ZUFVl0ez+eIq+G06+e+0NwDmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PkNar+i0BpWC0Ww2/+zw8Zqy/THrhxdiPYwaY3yLI8w=; b=HlePwfV4bjKpy/iLbsk4WFjj0FT+5U3oeO6uXjj9UylGz9qcLQ+TGajpp0lZlALxq/o70uU+99AUaspQMXRFxez61CJHkYAo6gttujSc9BOEMQPDKjdh0YDUVHAWOTLw2G0f69xazAPMtIecaJbFYk5xSv+VKqZAYsSfTBXww+Nb38uRpgg8JuMG+ZI7PaDzop9RD64n5ROaNERgn10m4dCYBhDZQj3Xl3YWpaZ8fi29tJb78Q6ieIPWBiyEZB6akmXm+9r/5RE1uk9kBADAf4nVO7Sspa7Jy/JMvscFK5c3w/TZSvDDv3NDGWr/6g3dr2U8ahisETHpjCz7XyhuKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PkNar+i0BpWC0Ww2/+zw8Zqy/THrhxdiPYwaY3yLI8w=; b=UneweFkQH5VImgVSsI1z3J+2TAIRtB3EszjWdfXj1cyCBBTm7883TyrKOhfDFpQh/4SKrmJQTgjTi4OZtmf/cx1m2QWoporhvVoYYR+baxUCHn3Cc73MIyBYeF8oISBvH7KOKcL99ORHmiA5htGSo4Um7TWI0lrTjGL8VKY+lm5Uk5KKfWnmrtHVV1AKriZ1KFk+VuLe8kSaC85odhoJNHI6+FTITJAJ3BAJNFTiXwc6GcxhDhTJ4qevKdJVQUNQOJBsIPVMnMyAw8icVIKTafv/BFSHeUhsxYeuOQaQGvuog56GPjxcA5xmQYrydlpO6vB/BHEUsLXVc/T8QgsM7A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1796ff82-6c48-8eb5-9c68-1e84de51bb2a@suse.com> Date: Tue, 12 Jul 2022 16:27:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 8/9] xen: rename acpi_scan_nodes to numa_scan_nodes Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-9-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-9-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0059.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2e231da1-b2ba-4107-710f-08da6412a292 X-MS-TrafficTypeDiagnostic: AS8PR04MB8884:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cUp/lxhlH9qB9LnXtbQmwCb8mmjw/SErUkqyFrQnrGafJ9LjNV7Aju0nBCWsPZ7q7qTkdMuS9kjXwBK+rJtmI5XMrQkihngD5p3h6QHKHrUvaeW0GKH5EIn0zd/8Fe2d6dYqwHkVNn7W+empzNqYy3f/5gVBnf2jtKHQPFAGCVhbZc5ue8iguTHncAZ+w1fEjOWtcDFyLpod3gwSQ2mcq1yjYomtdIE5913HtE4Z5MknfE2WobQ7C3elG5Qesd+ldFS+rOtSJxjmDFrB6VqtBIVeewAi47f9dsCYGiF76Fmfz3fRW+TVMnOS6CXtcEb23jNfPHsAvausHn09b8nsDdqUHyGRI8wv/q+5Zu+AREZFXiefQWAMbyikvBcSiG40qifFg3fy8bJXgfO2iXk2d/3O09aiEsUilxpWBF//7tg5GgTmVzz12XLknLsjeGZOdLufQZhRax2tWzPyQnSeAZjFgr09SVQJ12sXmN4727rhZm6NgwFO18lBwu29dVhPM68SIfEe5zAzt1kmpQlqNOA4B7pu5KWiplcQkI+H733wKYbmEeL9PCRGLINAR6RE0CsCJGxOBaOWYh1jWEEy1J8uBEVoZBIa3EuDzF7+A90Kb1oRYn4h/L77Z/QZNTt3C3Wdot+yg27lw601ZK0uGvzaR/r51tp0GiIBkCklmB+2VMLn8pXGyTI5iYBRTiIHSY6LR0nzioZOcPkYIl2rFKOxz+U5ozsxjO3jOUTmmE/eK1IKjQqIrzCJ74hRnAS7j6pewkV4Q4GyKFW1qvC1EMwffSYfinQEXBuNyDT9/f/4HPOLXdYd6NacJArd9EG/nCCv/SrTFQks1JK/kPVMPfQAv8TRjD5j4s20p3yaxSM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(346002)(396003)(39860400002)(478600001)(83380400001)(54906003)(31696002)(86362001)(316002)(41300700001)(2616005)(6486002)(53546011)(6506007)(66556008)(6512007)(4326008)(26005)(6916009)(66946007)(4744005)(66476007)(31686004)(8936002)(5660300002)(8676002)(2906002)(38100700002)(36756003)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFh2cUVYdHBzUkkwTUw2V3hZS2NOTXNSYWgzWThkbTYwaUlic3BITVJGb2pq?= =?utf-8?B?MmdNM3BJSVVoMFJ4KzkrRzNwWS9vVFZNS21peitBeGJsYkMrT3laWFFuYTBR?= =?utf-8?B?UUdvakg4UCtHeVU5enVZRWZwNGY1U0JVV2lwaytRMWluWFlPSzdnSTdqTE4z?= =?utf-8?B?ajdORklBMEtFVjNqRVREd2dGTFcxdVJZQnJGei81a0VxWno0eVRUMVZ5Z2RD?= =?utf-8?B?OVBWTmVNbm9ZTDRJcWFVRi9yTVk3cWJlY3JueE5CSTN5V3ZHcFNYZ0MyODhi?= =?utf-8?B?TWhSTTI2NC8rQ1BkVS9JaHVNekVGNVp5N2pyNEFFU2JZVThmQzRnSDNXVWh4?= =?utf-8?B?Vi9pSnNhcDZWb3k1bktibTQwU2l2djV1OWhRRlJydjF4TEVCcVZ4WEtBdjlz?= =?utf-8?B?Z0lVTWM0d2RjYzMvSmcvN1hYbEV3dDZTOGVZb2tpU1RQMVFOOHBjOTdHeUox?= =?utf-8?B?ZTNSRThjbTRldXYvc1liZFhqdlRxYzNHbkVQVEdoMU93OFpMa09ZVVM3Q3RW?= =?utf-8?B?dWt6QjQ2V28wZFRtYkszdUpHK0k1QjBOYm8rWTBVQjEzRThmTDl2ankwcUxj?= =?utf-8?B?bXVjdEo4R2poV1dJMXBmNnRuUUlSbzBZbWV5NlcvQ0ZUeGhsQmZtRStXTUJ6?= =?utf-8?B?M2YrYW9VeHIzODRqQjV1VWF1bEY1N3hEa1RsZnZCVWVDUjJWSUNWZHRkWTNP?= =?utf-8?B?M0pnOVJZaUNqUzFaeXhEdUw2a2o1S1BzZGdtOW5GdU43QnltMVVIQy81K0M0?= =?utf-8?B?SUZuRDcvZ1dtam5RQTljYXFzTFA3Y0NNOHBCdFZOekNEaGo5OS9IYXpxVnVL?= =?utf-8?B?cjFpRnhxVWgvaGZpZ2pHaDk5cG1haDVHNDY2c3diZmVkUzR3a0JsdGNzYXFw?= =?utf-8?B?SXdWbmtUdUxzenFHOEMzc2llNjVUS1RpaWJ4ajJPS0l2YTB4ck43UUZ4R3FW?= =?utf-8?B?c2JlM251eFlBM3R6WHFGaXl4OVJFLytyeGNhYkRjK3h3L1A0azlKeGNpOHhR?= =?utf-8?B?UUdRdFFuVDZCQmhsNFp6YWNISWFvbUlmVS84UDZoVWlxcENNQUlUYk5TY1BO?= =?utf-8?B?cE85d3BlejEzTlpndWR4UGd5ZWg4MDFOU1IvTmdWY05aTVcwc3ZtaTVidjMx?= =?utf-8?B?L3RZbktxTk1hUkExeDBmMHJHLzUyYWVBUk0rYTArZXBJMGxlWU1YRHJUbGFi?= =?utf-8?B?WGE3NDV5TDUxajBram81eDlLN3U3eW84ZEdEOW15YzNyY1d6YkhJT2VzL1g1?= =?utf-8?B?NVpDdG5pQjByelZNMTIwNWZhcFZWM2dKVVlIYjQyT0JEWHV0VXFQSzZGZ3J2?= =?utf-8?B?ZlFqV0dWdU03bit5N1N4LzNZMTlKd0dQV1RUN2hMQWJQSy9OcmtUTG50SkRG?= =?utf-8?B?M2FqalFKM0s5RThsM1grVjkyUFVpb2pjRU5TaDMrWlFOb2lPZlYyRE81MGxh?= =?utf-8?B?dVNvRWhUT25xcWdObndNdnNwYVFsMFVBWGhqRUoyQ2Fsc1Y4WSsvaWc2dVhI?= =?utf-8?B?Wk9sNGZnQmgvWFJab0hXT2hteWJCZmwzSzNpeUdDOVY3NnF0aGxYYm80M0Q3?= =?utf-8?B?d3A3Q00wSDhkdmFJbnY3NEF0WVBOcXdnL0lTMG5aWnRNNUhpbXMySTBUTno0?= =?utf-8?B?RTVsZFkyUVUwQ2lTV2xnR0MzMlBNaTlTRGNVMC9PcDdNUkVYR0N0MS9GRlBR?= =?utf-8?B?MEM2SThNKzVIeHE2UG53ZHJuVlVrWW1ScFd6ci9JTmdEZlI5ZFFucjRlUFZ2?= =?utf-8?B?aVlKNWljNUEwL0hSeUd0eFZsdFI5YjdoN0hxbWlCM3RWUXlCY2VlT0YxQ01k?= =?utf-8?B?TzFtQmRHUWhzTnJrK2pXaVV1MXBNYk5zK1VyMFBTYUQrc3k0RFgrMkh3R25W?= =?utf-8?B?a3hOS29LNXhWd2JJa21EaVg3Q0tFZkxwcldjbjN0QWFLaFczUExtWTRuejVK?= =?utf-8?B?bG1rcExCUEtrNkR1Q0xmK2xEN0VPd05zbTRQTFBGb0dsbVVFVFQ3bFBTRzB6?= =?utf-8?B?TWlJQUtFb2M2bVUvRzJqa0RucHhsM3k2ZE5yUmRNNEh6ZWJHS1NXQ3JBeDFa?= =?utf-8?B?RDlwNm8waldhcTN3cGplNU9RQTdzYzlnMWh5UkgrSmNrUmxPYTBpLzhxL2ZJ?= =?utf-8?Q?BfaPMCjqkMHKZMtnbDbGl/CUr?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e231da1-b2ba-4107-710f-08da6412a292 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:27:22.7604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ulOC2J3oL6UnnQ7PKJBtPpWmIOlxYJvRlxqPSyoJTZyCO+jowjebkjPiTiWftPqiP5hIdms7R5YOxiJNQz6nbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8884 On 08.07.2022 16:54, Wei Chen wrote: > We have moved acpi_scan_nodes from x86 to common. Because of > of our previous work, this function no longer has many ACPI > characteristics, except some "SRAT" words in print messages. > So we rename acpi_scan_nodes to a more generic name > numa_scan_nodes, and replace "SRAT" words in print messages. Once again I think the rename should happen before the moving to common code. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:34:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:34:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365764.596087 (Exim 4.92) (envelope-from ) id 1oBGy4-0001k1-5D; Tue, 12 Jul 2022 14:34:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365764.596087; Tue, 12 Jul 2022 14:34:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGy4-0001ju-2V; Tue, 12 Jul 2022 14:34:28 +0000 Received: by outflank-mailman (input) for mailman id 365764; Tue, 12 Jul 2022 14:34:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBGy2-0001jo-U0 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:34:26 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50056.outbound.protection.outlook.com [40.107.5.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b8d1baab-01ef-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 16:34:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3049.eurprd04.prod.outlook.com (2603:10a6:7:18::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 14:34:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 14:34:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b8d1baab-01ef-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lHvRRJ6reAYX61sG4F8u8llbd1VSS4/uljXaaiaXxtoeu9FOJxHRy2jfodwebqraH1Z/bWiOz8PwREOZ+7CikCoDaG3z69HeluWXJNQUH/4UFrOvvj4iCEY58mQu+zbdZqm3q+aKI7W5paXei/AuaEBqZ7pDmlqO9OfG2TGaC7nStch51TPtZAp586q/HlCuFsPJXM7fCHkRozrZ/ju9I9v1zp86m9jpEqxhSo84ctVdzcANN6RgH+Os1NklzSqvtx2GYf2jg5ggjR5DBfNLsCEm6pLk1iy2AfLwWDvRUPSoDRra0oSfmCoXp/VFSfpTnF9JMQnPp+jo9yYwzmHqRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1UQmCyms89YdEei4/5r4TKQHX9dwAudCy+K65B1AbcM=; b=EqGoLlKbItvTf+1sIBOPMBXwkO4SkMvVsJFgRanHK+bE3A/aHEISi0En8nUq64prB7XyE2nULJi1daftZ+4Kd1jYIdIVV5jOFzfkVd3QW98wWSCPBw6FRBE0385mxXF8aB/yQ8NOp8iqpDSt70y1l4HwSLHh1RPT+a1vracVb10LOBTlNVvGrvliUKwSrgelptBuqd3MawbDQWHlgMzxUukrQZ1nbgY3L41Gl2A8EKbSNitOPn7NnFaAczmiidbf3RHl/1U5kGO2JBVOJ5ctTkcyzJcaUh5oaF0rdHi33d5XXYeT20g6eO+HyuTpHFZLc6Ybt+kgDib+q8q1YkuzbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1UQmCyms89YdEei4/5r4TKQHX9dwAudCy+K65B1AbcM=; b=qo2pAcYrHVScbrkoiIrD0PO8+dh4JIJLjZ2zCv1dSVcO2U8Xg6fDExSGqsosFESmu/LsCLmIQ0OHE/u7iCPG134c7E6VQOscWb/RZTCJKLNCLWfie4sXelwDcbgGj+PKrhPXxjNJ1UCSBEiQUnmsOOdJkN20TBuM0XN5bqK34jc4iD2iu/Pxuj9gbJyIYq6Vo5R4QVylkdBXDE3+SYbEg0NPwNTxvvoBZCMSzU9/fYXmFDHPotjkbusuiwOe7KCQfenQgrkf0htTwn2uOVq+POTqRwM/ovHpTTwZy/0ST+/LXATBS203/qUCqKK37erXHyLfZd6c/uk6NCscdD4CNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 16:34:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Content-Language: en-US To: Wei Chen Cc: nd@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> From: Jan Beulich In-Reply-To: <20220708145424.1848572-10-wei.chen@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68430275-24de-4d65-a86a-08da64139ce7 X-MS-TrafficTypeDiagnostic: HE1PR04MB3049:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gb3UnUD59GsiwMbreUkqvR2lT+QSvw+tyTvxiT/UTjrsLtFjQE1AxNHw8hBC+fm5F0gWF0HL08WAhvjzxY8lHASvJtdFInEUaZrYgejrVUd4i4R6vW5i2PDvkq9MF9zspUtm+kkNwHshcHrQWYWBDLWP70B9w2cASciH7KOrQfSdGbkugIdU3sE+twwYUFvZMJHIZjdPNS7WmsLx4zQmrsK+V4tf9VFYBUL6aloPxbvhGk5QsE2qUgVUcb0fvFZwokcZ9kckRnLv5xTTlmZ7RzL8x3AkOU01ASMWlK3Ekxt+r7Ai1khYmno69mXOBr5DtY6UUTtm9wLY/q9Oe/xXifkC+BV6Dm4DHaHrBKTgyHH/29GZFFps6CL81xigGOe1JNXEMEtz/2eINRtlwQyFkEAVQFIKIsMYX9mqeye5m1DIVp3It3T1pDi/bhSe77NrDmDKNuPfjcSpK8k/kPbVh8DXPomyVfqKhooBC0yhSL5Trfk5+BBpnWJOwPYBjbjrjV9D71PqTFpBcVf9o0ofUIp4FK3HTJfONROh7T3GL+eRWom0ByTaT8QyqYecybHuO0sliMEE8MxQVJjsyktxYceX73l4AkPPiCwwWySmpAg9kTg4xW1TrFg5ga3pFN/KnAdR5ZDdBPR94CiOdkarZRzcwndXkzCyFQT7CH9KSAdYTXsrv0YiV5WOY4QtK4xOrEJOG0VUo5RSUafWvhChLRPDKz6fqfag9uwJgC+xkeZqK0Yz0IOqMchy2wHtky6V70PEy2etRPMDup/2mr2uC+n61qXSYuaXQKOji/G1GaImRJOPeSjVyaeDC5kLnBkaRTS6e568IMJXVsaK8bBB9puuLHJqIZU41bKRra3wx6k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(39860400002)(346002)(396003)(6506007)(86362001)(38100700002)(6512007)(41300700001)(66946007)(4326008)(8676002)(31696002)(36756003)(31686004)(66476007)(2906002)(66556008)(316002)(478600001)(186003)(26005)(54906003)(8936002)(6916009)(53546011)(5660300002)(2616005)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGY1b1UyZjZNeGpWMU5SM1QxeE5NMFVEQXhEMzJWZVUyT2dQM0xlWU0vZUYw?= =?utf-8?B?Z0R0TXRGOUQ4VVBqUWY5VG1FcWJWK0x1K3hGbzdRTFV4RmtuRUdrcHc2UlQ5?= =?utf-8?B?TFlNaXNTODN0dXUxdytIaDFrZmlXUFBaSEs2NnBHNkRYUEkxMHAweW1JR0ts?= =?utf-8?B?NkttQ0h2TWFZM1d5eEVMbEZLZ3FhVTRrR2I3VmV0WU5nVi85UHl4M0sxMms0?= =?utf-8?B?S2l2bTNhbFphL3V3cnh6WlBFdnVjYmNCbTFOWEpuVGFUL0FmVFlNdFpEdndH?= =?utf-8?B?eHFXbUhMcHhPZlJ2bExKaTZNRGZJYnBoQUZvQlV5NE83VCtlbnRwVXlNdk9k?= =?utf-8?B?M1AzRzlDUThLWmIwaitmMUNtZ3JMbEpsQWlyODU5dzIzVlYwNlhsU0E0cDJY?= =?utf-8?B?enhscUxIZ2hFNW1JbEVMZFJFazl3Mkw1R0F4WmZ5bVZXaFpyVStmUkhGUEtB?= =?utf-8?B?L05EbitDWVEyRnFJeHQzd1o5RDI4ZlVZeG9aOEt5aE9wZXViNEU5SWZCMWRE?= =?utf-8?B?UndiZDRyeFJ4QVh2R2hSQ01BeDlxdFlFUHZmVWRNSG1RVjdWQ0o2aHNQVnZU?= =?utf-8?B?aEczVmFLOTYyRkxOamlrUHI4cGNhTnFlWmd6YjJyeW5yZ3FaejdYdFNESlNy?= =?utf-8?B?VUZlNkQ0Q3dUWU5sbUJpZi9pcm1ET0Z0MWg0QW1MVWJHTWJMMFZrc1lwdkg2?= =?utf-8?B?WFAwYVg2U1RZM0tRbWM2T2NmYUtRejkxZVozdkx1WUV1eXBNNXlDdFB5MXBH?= =?utf-8?B?QXJkWFJ2aFl1QXdLVnhHV0lvRURSQk5EalUwVTA1bW1YS2FaWkthczZBQ2Nj?= =?utf-8?B?VnJMSGIyby9pY0pIS2lGVXNMUEhoVjhZMWZ1cVJpOXB2ZzZRTDNvUERDQWNz?= =?utf-8?B?bGdaaERIUkpaUFJDN3RxTnQ1NWZJUFpXSXlUeWVOS1FSb1RIUmIvS2lkYSsz?= =?utf-8?B?SG1KakZxZ29UVklGSUZCaWVCaGcxK2oyRXd1UmJEL25MVk1kV1B2K056Tm1v?= =?utf-8?B?dml5VHZaTEdhU0xWQkx0ekVZaFh5WG9ZOStaQzZYNmd2bEpKSWtydnZPRGZz?= =?utf-8?B?L3orWC9KUTNKU1dLK2M4M0hqYmFKSjVsTWNDUTI0UnVNbmUraWIyVGNYcWNH?= =?utf-8?B?alAyVzIrcEgrUEUvSWFrWmg1d1NvYkZ4ZGFHZ2tYZmZ0RGI1NXRJemFMa250?= =?utf-8?B?Si9FeWlzdzZ2WkYzOU1FaFBCSWg3U0FIMUxtSUFXaWI1K3pnRzRiS1FGeWRz?= =?utf-8?B?ZWdJRVdPK2tadzkvcTR3NzU2dm1CNmFoU05BVmd6dnNHS2E0S0lVeXpBZHVz?= =?utf-8?B?eFFoV0Zpc3VNZ2hYanI3YVkwcHp6R0s0b3pBUFV1KzE0eUhKOEFOQkhZVGN2?= =?utf-8?B?VTd4dDc3OVRLdVYydDFPNzF3MTRhc3V5cDk5M2dmZWhCWWNJZmJCVjNWNGVW?= =?utf-8?B?RTFGMW5naGlwejlZY3BqcVVTaVZoU2NldlhZL00vTnlvOVo3S3kvOW8xZGd3?= =?utf-8?B?T0NuQ3pCVWcyOVRUdTY0NDMwU2pLWVVmZEVmM0RBN3lOb01yMUxJeTJ1V0Nt?= =?utf-8?B?UEV5eE5MZTJYRlhDMUdhc3Yxa2ZINkdlNTR6Y0Vpa3RSTFg1bE5qb3BrVzFP?= =?utf-8?B?eUZOS0NJd0NGYzBpcCtEVERaZkZMWGZndVpreFhBcnc0dWp6VmY4QkNFYTBG?= =?utf-8?B?VmdGdXZ1cUZ2b29RYXVrTXRLblQ0REMyclJNMWFNQXBidlhuejN0U1ZIVFhs?= =?utf-8?B?L0w0L2ZtVmdmZG50cjlpMVNJdEpjMkhKbDczV25sdEFxVHhxVlN3RXp3Z29y?= =?utf-8?B?TS9kcmdJSTIrUFladnNVV1U4bjh4QzdiNXJEaUxqZmoxczhSYkxDd1Y0TFlV?= =?utf-8?B?dWw1TWNUcnMyK0xINFhzTW81c1QzeENQNkF2UW9odk9RZWY0SGRodUx4UVpI?= =?utf-8?B?VGtpZVJmTW1lV3V4N0xtaERCZU1LVWxnZ3gzbzh4OWlHVWlOQVR3bVNjZ25J?= =?utf-8?B?REFRa2w2cTBubm5sdjVXN2lGdlNVNmhJS2lNdDE1TjdBalErSmw4OGwxQXFD?= =?utf-8?B?VCtVdGFKdTd2dG1Ebk5qcnJrNkdTVWpSSTZpVWFEdERyTmtFSXBjSHZQcnVi?= =?utf-8?Q?CZ1hqMA5fxvGTdwaOR3L5Ngo5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68430275-24de-4d65-a86a-08da64139ce7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:34:22.7336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mQazVShEXzXhmWoyRcFusnEufw9CSgkr8UExHP4ltDhkwbLagF0wwrf5cgdMHadK1EYlkzaImyTgfCfiVOXu8A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3049 On 08.07.2022 16:54, Wei Chen wrote: > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,14 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_NUMA_NODES > + int "Maximum number of NUMA nodes supported" > + range 1 255 > + default "64" > + depends on NUMA Does 1 make sense? That's not going to be NUMA then, I would say. Does the value being (perhaps far) larger than NR_CPUS make sense? Why does the range end at a not-power-of-2 value? (I was actually going to suggest to have a shift value specified here, until spotting that NODES_SHIFT isn't used anywhere else, and hence you're rightfully deleting it.) > + help > + Controls the build-time size of various arrays and bitmaps > + associated with multiple-nodes management. It is the upper bound of > + the number of NUMA nodes that the scheduler, memory allocation and > + other NUMA-aware components can handle. Nit: indentation. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 14:42:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 14:42:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365771.596099 (Exim 4.92) (envelope-from ) id 1oBH5a-0003Jk-Te; Tue, 12 Jul 2022 14:42:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365771.596099; Tue, 12 Jul 2022 14:42:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBH5a-0003Jd-Qp; Tue, 12 Jul 2022 14:42:14 +0000 Received: by outflank-mailman (input) for mailman id 365771; Tue, 12 Jul 2022 14:42:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBH5Z-0003JX-50 for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 14:42:13 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id d0158e91-01f0-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 16:42:11 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5C8321596; Tue, 12 Jul 2022 07:42:11 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E0BFB3F73D; Tue, 12 Jul 2022 07:42:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0158e91-01f0-11ed-bd2d-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] automation: Remove build-* from gitignore Date: Tue, 12 Jul 2022 15:41:55 +0100 Message-Id: <199cc377eb38606bfa4b33942f0ed688080cf535.1657636714.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ...because there are some scripts in automation corresponding to the entry (build-test.sh and build-each-commit.sh) Signed-off-by: Bertrand Marquis --- .gitignore | 1 - 1 file changed, 1 deletion(-) diff --git a/.gitignore b/.gitignore index 4729911c51..f731975713 100644 --- a/.gitignore +++ b/.gitignore @@ -44,7 +44,6 @@ config.cache config/Toplevel.mk config/Paths.mk -build-* dist/* docs/tmp.* docs/html/ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 12 15:05:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 15:05:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365789.596110 (Exim 4.92) (envelope-from ) id 1oBHRj-0005zn-OY; Tue, 12 Jul 2022 15:05:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365789.596110; Tue, 12 Jul 2022 15:05:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHRj-0005zg-LC; Tue, 12 Jul 2022 15:05:07 +0000 Received: by outflank-mailman (input) for mailman id 365789; Tue, 12 Jul 2022 15:05:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHRh-0005za-OB for xen-devel@lists.xen.org; Tue, 12 Jul 2022 15:05:05 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2086.outbound.protection.outlook.com [40.107.20.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 01e35394-01f4-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 17:05:04 +0200 (CEST) Received: from DB6PR0501CA0016.eurprd05.prod.outlook.com (2603:10a6:4:8f::26) by AM9PR08MB6274.eurprd08.prod.outlook.com (2603:10a6:20b:2d5::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 15:05:02 +0000 Received: from DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:8f:cafe::18) by DB6PR0501CA0016.outlook.office365.com (2603:10a6:4:8f::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Tue, 12 Jul 2022 15:05:02 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT011.mail.protection.outlook.com (100.127.142.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 15:05:01 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Tue, 12 Jul 2022 15:05:01 +0000 Received: from 04a161cd6d06.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A20091A4-D056-4D26-BCBD-30C72CA6D3BB.1; Tue, 12 Jul 2022 15:04:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04a161cd6d06.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 15:04:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AS4PR08MB7685.eurprd08.prod.outlook.com (2603:10a6:20b:504::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 15:04:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 15:04:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 01e35394-01f4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EM4jsYTa4fAtObO3nP+1N4slUotK4aZR9Wh8gzQpfwYHdwMwjVQ4+fTL8yhuOSDfWYg+iIrtPa7EXP0WDoTMcZTjlQY0j1wjFgKN1vUrjvU4064sZWcYeDav0aLOvi+HkjhqZBIxRr1QZt1tWXiP32gS6P0UJK5fGjDiDj9ZlQX7JwMZskzlnvxgrDbGEynQTuQeUIWlUeEG4xHTVaPXslz3TfeP2IEWtdKu2OYkrIfl5Iy2FL3CvcoLgYe+GW1zXmYi44KY8mzj3qGQC658UgNNCz5LskbXdI9GVq5QDZP+Y2NaVbM5fZ1Al9AVPAFOAQ6rcnUy/DEjo791I+A5NA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+9liIFvnm5JvJc01YVF9kvSNd20f56p6JPxUl8CAK8=; b=OqljYgeHxPO90id8mBWMFdz6Ssj95sJHDkVzvG4BfWubxDWwf2tislVl3vqZMWGCKp1SnEFQWl47PeQU5ljSBrZwxh2/CbVxE7hXkBDyaelv5fx31UAlneeUCTCf2hCHWNpwZh42qbT7F5RiLS9lpx8JCGixTdPyWDbT3SMo/HvwR+bume394UGvF+XTes1Kd+hnmfEMWB51NXoFFcj0zXMzLGEh9taoVNMr68jzAWuDkphCz2HpO+RoPRP98h2B3co64ee1AcEKEBSYRk/GpwYPgvHx8/cMzTTVy7pbPpNOqwI8CdyLxbkYgZFiGvl2PnQdT1IXM3QTJMj9iN6plg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+9liIFvnm5JvJc01YVF9kvSNd20f56p6JPxUl8CAK8=; b=gYkYdJr2GfMoMfxparCpVNhtY591abSHUnfbN+XEyPAywWpqdoAwcyIi4OYdFCDWBur73Z1o0FkGVLsBfGxhpTfspZRA84vZibcQ5n/ksFUhTYcmRUmReVXMreX9S/e2GY+5Ffq5Gq7azn9cYIO/s8NiYqC71FfydUjCqwrS9Ck= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 79107023e992212a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DMdkJXcDBh9MHsYjNh0cICfE5k7KmWWrOkvoTbFMbWoyfPn8iujSN7xZJF1U56zsbu5xXvNEMPt30AR33G8fu0TbqSWVDW5mtjWvQLVy0z3/+YlL9sSPFmFaXd3uewcJg03OXIz31X8MdiUod86tdboo5fvgfxY6bognjJ+aRdaPOuCKwwpuQXg2ALi+cnPheeE9Ptb1jeUOP4zqkxqFCLWjXZ46RFlfrIpdbS0aU5zQpTsnnz7HRLTVL7ea7yOfI4fsJV6X04K0jrfw9rIXh2XifDtz+dImOZ8//EjTEG58sCTeyMr4VuUWdcuOV08R2v9AuXTjewrqcd+23pJxAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+9liIFvnm5JvJc01YVF9kvSNd20f56p6JPxUl8CAK8=; b=BkLBpD5h9zJjDyd8WpFllLIUJpjGufkTWThzcJB7SZaizaPN/Ih2P5bV3DSRr/JA3Z6je1GA5bYQ6hkFNeVoPnDtcwkdkXVi0M2Rejzns2+cSj6ttMdvE9QH08cc09oveTip343yNDf+TLAQCYCl17RrZa7mEA+yretseq+Hi23xbcbr89w3sV2P+Rkt/wpvDZLSGe6C0mplEhQg3u+d8PuY8vu2/nmMryt3oCCtNT1USkFT1Ga/WX/WEJzPX/2FJNNXi+MLoQFSlIreO8Lwun0mW9dLkqXtg5asuT01/tkr41lBnxBb/98wtWMXyPTtfBIRiCv9G5gPpRtKJkfFlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+9liIFvnm5JvJc01YVF9kvSNd20f56p6JPxUl8CAK8=; b=gYkYdJr2GfMoMfxparCpVNhtY591abSHUnfbN+XEyPAywWpqdoAwcyIi4OYdFCDWBur73Z1o0FkGVLsBfGxhpTfspZRA84vZibcQ5n/ksFUhTYcmRUmReVXMreX9S/e2GY+5Ffq5Gq7azn9cYIO/s8NiYqC71FfydUjCqwrS9Ck= From: Bertrand Marquis To: Brad Churchwell CC: "xen-devel@lists.xen.org" Subject: Re: Xen on rk3399 Thread-Topic: Xen on rk3399 Thread-Index: AQHYlaRzw0VI/DSwq0Ot3R+564rcea161i+A Date: Tue, 12 Jul 2022 15:04:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2c930733-8576-4777-94b7-08da6417e500 x-ms-traffictypediagnostic: AS4PR08MB7685:EE_|DBAEUR03FT011:EE_|AM9PR08MB6274:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: G+pnuKsr3k6qk3a6vKYdG5/jFcPocfXiH3hZ6SvPsboyxK+wnCZ2P/KJdR03o8Q1/a74qR2o2MN/2pZpb7v8J/eA2tNheqG5mNnW+5MDExfxvm1rKW8YFUKGgmExfQd54mIqNa0splcxFikbqSoBsvdUpTmmHO4ZV5vTbr9T+IX3A7S85Gb6qnMjFuqntdGdtNwyzzDr0WZmazXLSdqOl0GO2Mmo8N56f6MklxcXPHR4m1nf2mqFK7LRf9nQYhZOffRd1D4b3FHIEEE8izU8TlWYQiK2x3QJxOTlnu+pG+V9mz+ihaEjAH5CO+2TNPdx4QCbWq5x3y9Ms2mkqfFCVUv2GCQ7Dsnhxpf0Tp6OZK5LBj2kfS2dbZA+DYrHk5SnzCH4AtnVTErojdv4Idt+NyzLlNmcAWfO8V/tGvXqeHUls6zeasSvDL+QV/Y9Rgc04UYDNIKislpcAdAnZMPAaUtNxCzkoKjH4ADuZD952SCy4Dp2z5XMSh1vtoeQZsUNXjpcZ1k9AQVclrOqy3GEA1p/1AALw4iBckGJsZN/TlIHCJgtmaa3z4SniUAv7YxeTHSbaBG0hitkNVUoMsacJZ6YTmQlLxo8Z1JjYKtrxjDnYtjeTYPG8IEPhtc9/Dgl8LZft5SLMIm5rgOPW8H6E4XDKNQeD/jVNaPjf/+ysgdluwNGRuABTfECy/4mzwYikPO8UxM3N+Z7s32/Y70heBATVb770NZfO0SNdlcWTatQUqr+vtpG/oJUIhk88uF1O9NPznixRJiLmh0CWUuHB2sgKc4zGEiLb/4ess04GZpxNthyH7vsRLPjYqpxRIhk4e6GYyq3TBUyAq5DmgmmJXxzQgeXjAJwhZCISmZ+viQ= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(136003)(396003)(376002)(7116003)(6506007)(91956017)(86362001)(478600001)(8936002)(26005)(33656002)(6512007)(41300700001)(316002)(53546011)(6916009)(2906002)(6486002)(38070700005)(2616005)(66556008)(186003)(38100700002)(83380400001)(122000001)(66476007)(76116006)(8676002)(64756008)(66446008)(71200400001)(4326008)(36756003)(5660300002)(66946007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <8E601FA3264D4B4CBE8B994F9FE9F98A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7685 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c4e3f92f-e68a-47ee-8b03-08da6417df71 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r7fS1I79J53vdWiZLvt2EV67ljJvF4al2CZcOlQonz4jhD4cADfaueK5g3JSWHw6siExgH1vOz2YV76HAQh3sAQqRfe9am2CkKBWbbyEncMDZJ6lVAOxptRftYQ5BEx7GLMAyIDbKDD5bJN23OdyuybBMRsWm++e0t+KZ+bVYbvf9g50osZs/KGeqisirDTxXujrfH1QR58ye9zONsMnNLrb/BKn4Q+DdF7F+q2PpamyhLYhCMotgDU3qxPwqnsC6s6Ek0qqmwfbajTz1y3BxgirzWT9qfn6+RptH8+orr9HCGk9IJsbso714maaM5KXPZZnFutx04heHddIp4i/7kVQf/oX6r10A71yOfiGz67csccwsSFDUiqIJ44UsXgcvAFspxKwcG/OJYF/nigDfDpSZrJ0tIuJkxFWNEJAbjj/m331y/No6Y6vHq5SzBpRdWIfAjKx8zQj57kzVuY7wObzoHVIr52pubPUbnsyavIpf69oCOr85i4/AG+4a3AHfQFT5lwzN/cP90Va5LuEtqLNP9EBOsD3EFoApyJ6j94MtB7xGzxka0IYFURojEKoM/XgixtEzjiSqFTiFzZeJe7JlmhIexEsyzzR0V28y+/wGqrhgx1fHgaLFiShGTOu8B9708Vo+6AC35Cy/vBK1tjhK0IIvC8KpHhZOm54QHTEXXK2afptSZsucQ24xG/y0s3hSzKD8amULtKf2MqA5suwHtVg0Rv6YtGxL7Giy5gsyqeJP8nLg2VoTNDIOgs63liYc2oAp6rCaYaxOcKESvyBCu6x9lKAruKa3Ji15h9NBjyDqdoy2iGOYudikgf0 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(40470700004)(46966006)(36840700001)(6512007)(41300700001)(82310400005)(2906002)(26005)(6486002)(336012)(47076005)(2616005)(186003)(86362001)(53546011)(82740400003)(6506007)(356005)(36860700001)(4326008)(316002)(40460700003)(8936002)(70206006)(8676002)(81166007)(40480700001)(33656002)(36756003)(7116003)(70586007)(6862004)(83380400001)(478600001)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 15:05:01.5236 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c930733-8576-4777-94b7-08da6417e500 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT011.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6274 Hi Brad, > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > Hello, > > I've been trying to get Xen to boot dom0 with my kernel for weeks on an r= k3399 based board and thought I'd reach out for help. It looks like either = Xen is not properly recreating the device tree or the interrupt controller = is just failing. The hypervisor boots but falls to initramfs because it can= not find the root device (nvme on pcie). Any help would be greatly apprecia= ted. Here is the complete boot log >From the logs you have an issue with the interrupt controller and the fact = that your NVME is behind PCIE and as such depends on ITS is probably not he= lping. I would suggest to try to boot on usb as root fs for a try. Also it could be useful to compare the device tree on xen and without xen t= o understand what is going on (using /proc/device-tree). Xen seems to be ok but Linux is not happy with interrupts and is showing se= veral issues around this area on your logs. Could you show us an extract of your device tree around the gic declaration= ? Cheers Bertrand IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. From xen-devel-bounces@lists.xenproject.org Tue Jul 12 15:11:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 15:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365798.596121 (Exim 4.92) (envelope-from ) id 1oBHXR-0007cU-KB; Tue, 12 Jul 2022 15:11:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365798.596121; Tue, 12 Jul 2022 15:11:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHXR-0007cN-HA; Tue, 12 Jul 2022 15:11:01 +0000 Received: by outflank-mailman (input) for mailman id 365798; Tue, 12 Jul 2022 15:11:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHXP-0007cH-TC for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 15:11:00 +0000 Received: from sonic301-21.consmr.mail.gq1.yahoo.com (sonic301-21.consmr.mail.gq1.yahoo.com [98.137.64.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d13f03cc-01f4-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 17:10:52 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 15:10:53 +0000 Received: by hermes--production-bf1-58957fb66f-p6kcj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e0593cb1e20b98e2a34ab7885caed5d9; Tue, 12 Jul 2022 15:10:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d13f03cc-01f4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657638653; bh=bOVx7YrJAuUMpkgDTYAHEYSe4MaLEA3DCPkIu6cmXSQ=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=lwJaZA9F7lQIKd1z2jh+I1393ECUv1G6a18GunLQOybb81a1+7PZ2kFN02SpvKJd/hx1SXIUzK+N69UziEaX3HoMZqh8fbF5EjmwpWX2PtYwkLUS8tu8DyZr7G/+W2OyuhkFw3YSTIZz2CNLOVIlqc0ftvchKIdUDe13txhMYYaPukoqiSEQZCg0vUaCaeHEGgXA4VVjXkHgixuFRq8qGHuV0jDaF2kZML3QVpPhhJUYyI/NaP3Bj3+rCcLCZ+/UFcvHImPKztANDU3oive31cimoF1eo0+citUomiB50lEOdx3tibsRQPL6UXHtLfGboxGSto2VsnegXTnnykaGow== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657638653; bh=FfZVB0AtytDJFrI2r2Op342mDi9hyzYHrQ+lzrBJvzI=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=eUulBIhmrYpxeMz6bPnOEDof4xyRuDffvsaml9R6RRPzpCZSHjKeeEuPpxicINZqsH3b36QX93cmanSC9bqCu8WeeGhoIWIsxxX3U+A3o9EvXvm7FnAwQiMhW2+r1VEMSQPjuxT/z0VZ480mcUmZo0QSPHSpQhVImb9wJhDn+/UKzmB2BN1TrfVSVYhhb2ezl1YJv0mqQah/PiWDqeu7d8JMGMLD93kRVFz6j3Sg614ww9vcfsUrfyw7UzmSPt+qVWdj1glNRBf3w4vwi+r0Y9lYscGnGeCgW7CenstfbB6/Zb3/Wqg5vR/1fu8dJBZzQuPu4WsBqD8I0zFf52xSiw== X-YMail-OSG: hicEidYVM1nv_OxWru_4Fj6z1kYd_Rf2mLCS5854cpF9Cw5lGoVInjCa0CmdF6g t71Q1bnWA3wvQqTyPPKP_X2jhNUYn5xfNZ4w9EhkQqpT54GTtdkNQ4Uj75HsFomj1nsqRDtHoUfa 0nZ6MDQF1h7Ma_9_6n71Y0ZTARx3d3ZSv26NPe0dS6IqYy4OvNhxtyK90nLYeZc02elfGHrp4MMq VLJB4kxWReK6nX5lcyOQ3Bls0QuLZreqWgF_Q99kMi.7eAvpCRDIuu88ilg.33rWPGeYI0gfXgK9 deJZue19u9uWKEMCKuym1bkwtJdkCy07voDmKhHOEois.2Mi7jVb78_PmOkT73vL4eG5RYppwxDA _6Ng2T5iPUH6.IDi4YGhT49xaFfHhYnbp5Glp7IP_KQbVMnDJ0o1pbgf80CkyqJUSMsIXheIWV8x 2FrTKZQnzOO3BeSPaK5lFvw9yGtS0_kn3ImKjG_8dGqRtOsGHOnn18QhI3c6nj_qz71sLEsYKQdb GweFZjFXwPFAE9it_xc_I23UEXE69nCaj0jkHVfHgbuTG6GAnz1oAf2hpOqYiNdPtk7ukObwzfBB x8d6UNlmigKIlDNzzk8y9gKyu5UCY4LMGiXfQLPOUqD_v_UUTvFG5qhYQnP6_WybenZbFyH.lfn7 K6zQoKk6qrKAsl8VeN_bdNx8K8UNxLrNvaoq0o_6Vo5.tgJU7M_Cp9UkRQKERpsWlWpscax5iwm0 Thv.c._SVJ8BX2qTBWwFiOg_.J5J5ZYmjSyrqAzpfBcObsql0H42h5dwKwBy0W4a2wlw60ApU4ma I1JFIVfVdQM9CNftmi9q0gbQYdJyATyQb2cVrKutkkho14EXHzsMkQ5YW8mxOoeBQzhE7KyeG3J_ Vq_65w8UmzDO6iBtfkO16lUTl2P8IX6h8VOQu4Mkh7CsZ3CLYLbeLlbFWcxM4iG81z.vvvBN6cTI oi1TVQF5KkpLcmpsY2WMqeRqpZGYl_gKAqhb0NVg5zHKqkWAOrjehbT80v6dFkvgiM.lckIGI8f9 gDevs27JCfQCbtia9A8uMqVKPvlM9b0UvKoivz78y9mN.6krQjqcaHCDqnGbi3OHjrTd5YamwFxo HQzuLI2nMizzf_aeelaXbsGrjsQbgPKhjigF1lq0bEWFpE4apIoDv3UPKp8ZLRKNqdQylPi5bv6k 5NSmj.3wtK41RfkG4y7ValKUdJKni5HOWkmYBQWO7X4QHn6grmUVoLSUsiOOM4Au9FZan0arrQ4f Ga2VL1eYTU9o8KoRP7cxnXksYBKtskOKh6MIn825.LvOGiDJAu8REgdR3Q_rXq5WqxCI5.3o.DB8 y3wQP8m9MoqGDfkYZNUTMDQ4WJA.J.vp6qPQlOBbjrlVPGphQC6V_06sK9tL2cv.MvecaDN3I1KU .bGsr0KONhCfh._2xUjcp8WXoBUendH0wF6l0KzNwtLwnzscr1AP0FaPbqq1HLY1igFUNlT_h807 VUdeln.DsYmMTCxVKqGOOEG9RRT9YYmEWb7zs1TUHSoymnJ4T3iv6X5tzvImJZ1Kvj5_5qfamAXU qMRsR3cDKpzbT2aclkUqrgKPY5fLGDE81lVBSEzOEIBBYvhBAcuWqiT085Nlyfntxq4D8Xn9wN1E OkXxTUI879yWyVqRLomYQl3SBfXDWGGb.W1q5g9f2MjNKAarYuyV.WuARcyXC81SY9y.G.D2jHvB Gi3KNrgCIje_EUAcFRgIY_dAQhf5mXQC5do.qA4tudRowk7zMB5JGlLKJI4o3idmQGLKPbXcjGCJ 7tErUBo44gy2WyrJhoxId0uk6ogYI2kAO9sfrOEB0zbI9Xr3nSXZBvgR2QJvyCUkzVJ9w2rNM_W1 Krqz.oX3_LglZVA4pXlhV5jEZ4XA3N00W0AZJ3l1kWSNFx9kW6zR0jngucXZNcRGVkwlNkpwvaQM vsmXMdwLD4WM6NEjKWLjPZkxWSJ5jE.PA9PjhTi7J.vE- X-Sonic-MF: Message-ID: <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> Date: Tue, 12 Jul 2022 11:09:59 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Juergen Gross , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> From: Chuck Zmudzinski In-Reply-To: <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7162 On 7/12/2022 9:32 AM, Juergen Gross wrote: > On 12.07.22 15:22, Chuck Zmudzinski wrote: > > On 7/12/2022 2:04 AM, Jan Beulich wrote: > >> On 11.07.2022 19:41, Chuck Zmudzinski wrote: > >>> Moreover... (please move to the bottom of the code snippet > >>> for more information about my tests in the Xen PV environment...) > >>> > >>> void init_cache_modes(void) > >>> { > >>>     u64 pat = 0; > >>> > >>>     if (pat_cm_initialized) > >>>         return; > >>> > >>>     if (boot_cpu_has(X86_FEATURE_PAT)) { > >>>         /* > >>>          * CPU supports PAT. Set PAT table to be consistent with > >>>          * PAT MSR. This case supports "nopat" boot option, and > >>>          * virtual machine environments which support PAT without > >>>          * MTRRs. In specific, Xen has unique setup to PAT MSR. > >>>          * > >>>          * If PAT MSR returns 0, it is considered invalid and emulates > >>>          * as No PAT. > >>>          */ > >>>         rdmsrl(MSR_IA32_CR_PAT, pat); > >>>     } > >>> > >>>     if (!pat) { > >>>         /* > >>>          * No PAT. Emulate the PAT table that corresponds to the two > >>>          * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>          * This setup is also the same as the BIOS default setup. > >>>          * > >>>          * PTE encoding: > >>>          * > >>>          *       PCD > >>>          *       |PWT  PAT > >>>          *       ||    slot > >>>          *       00    0    WB : _PAGE_CACHE_MODE_WB > >>>          *       01    1    WT : _PAGE_CACHE_MODE_WT > >>>          *       10    2    UC-: _PAGE_CACHE_MODE_UC_MINUS > >>>          *       11    3    UC : _PAGE_CACHE_MODE_UC > >>>          * > >>>          * NOTE: When WC or WP is used, it is redirected to UC- per > >>>          * the default setup in __cachemode2pte_tbl[]. > >>>          */ > >>>         pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>               PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>     } > >>> > >>>     else if (!pat_bp_enabled) { > >>>         /* > >>>          * In some environments, specifically Xen PV, PAT > >>>          * initialization is skipped because MTRRs are > >>>          * disabled even though PAT is available. In such > >>>          * environments, set PAT to initialized and enabled to > >>>          * correctly indicate to callers of pat_enabled() that > >>>          * PAT is available and prevent PAT from being disabled. > >>>          */ > >>>         pat_bp_enabled = true; > >>>         pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > >>>     } > >>> > >>>     __init_cache_modes(pat); > >>> } > >>> > >>> This function, patched with the extra 'else if' block, fixes the > >>> regression on my Xen worksatation, and the pr_info message > >>> "x86/PAT: PAT enabled by init_cache_modes" appears in the logs > >>> when running this patched kernel in my Xen Dom0. This means > >>> that in the Xen PV environment on my Xen Dom0 workstation, > >>> rdmsrl(MSR_IA32_CR_PAT, pat) successfully tested for the presence > >>> of PAT on the virtual CPU that Xen exposed to the Linux kernel on my > >>> Xen Dom0 workstation. At least that is what I think my tests prove. > >>> > >>> So why is this not a valid way to test for the existence of > >>> PAT in the Xen PV environment? Are the existing comments > >>> in init_cache_modes() about supporting both the case when > >>> the "nopat" boot option is set and the specific case of Xen and > >>> MTRR disabled wrong? My testing confirms those comments are > >>> correct. > >> > >> At the very least this ignores the possible "nopat" an admin may > >> have passed to the kernel. > > > > I realize that. The patch I proposed here only fixes the regression. It > > would be easy to also modify the patch to also observe the 'nopat" > > setting. I think your patch had a force_pat_disable local variable that > > is set if pat is disabled by the administrator with "nopat." With that > > variable available, modifying the patch so in init_cache_modes we have: > > > >      if (!pat || force_pat_disable) { > >          /* > >           * No PAT. Emulate the PAT table that corresponds to the two > > > > Instead of: > > > >      if (!pat) { > >          /* > >           * No PAT. Emulate the PAT table that corresponds to the two > > > > would cause the kernel to respect the "nopat" setting by the administrator > > in the Xen PV Dom0 environment. > > Chuck, could you please send out a proper patch with your initial fix > (setting pat_bp_enabled) and the fix above? > > I've chatted with Boris Petkov on IRC and he is fine with that. That's great, I will submit a formal patch later today. > > > I agree this needs to be fixed up, because currently the code is very > > confusing and the current variable names and function names do not > > always accurately describe what they actually do in the code. That is > > why I am working on a patch to do some re-factoring, which only consists > > of function and variable name changes and comment changes to fix > > the places where the comments in the code are misleading or incomplete. > > Boris and I agreed to pursue my approach further by removing the > dependency between PAT and MTRR and to make this whole mess more > clear. > > I will start to work on this as soon as possible, which will > probably be some time in September. Good, I will look for your patches and try them out. > > > I think perhaps the most misnamed variable here is the  local > > variable pat_disabled in memtypes.c and the most misnamed function is the > > pat_disable function in memtypes.c. They should be named pat_init_disabled > > and pat_init_disable, respectively, because they do not really disable > > PAT in > > the code but only prevent execution of the pat_init function. That > > leaves open > > the possibility for PAT to be enabled by init_cache_modes, which actually > > occurs in the current code in the Xen PV Dom0 environment, but the current > > code neglects to set pat_bp_enabled to true in that case. So we need a patch > > to fix that in order to fix the regression. > > In principle I agree, but you should be aware of my refactoring plans. I will defer to you and stop working on this re-factoring effort, but I will prepare a formal patch to fix the regression later today. I do think Jan's point about respecting the administrator's "nopat" setting should also be considered. AFAICT, the "nopat" option in current code is also not being respected on the bare metal, and the patch to init_cache_modes with a force_no_pat variable is also needed to ensure "nopat" is respected on the bare metal, AFAICT. Best Regards, Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 15:30:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 15:30:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365806.596132 (Exim 4.92) (envelope-from ) id 1oBHpv-0001mE-98; Tue, 12 Jul 2022 15:30:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365806.596132; Tue, 12 Jul 2022 15:30:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHpv-0001m7-5X; Tue, 12 Jul 2022 15:30:07 +0000 Received: by outflank-mailman (input) for mailman id 365806; Tue, 12 Jul 2022 15:30:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBHpt-0001Vs-Ma for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 15:30:05 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ffa63e8-01f7-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 17:30:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 10BEA20376; Tue, 12 Jul 2022 15:30:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B8BDC13A94; Tue, 12 Jul 2022 15:30:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 2iUXK3qTzWKPegAAMHmgww (envelope-from ); Tue, 12 Jul 2022 15:30:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ffa63e8-01f7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657639803; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HZcOzATguMN201yo0KEpufnUqjbpa5VOh3F5suHdSu8=; b=UkrlMDDv5wJFt3k78mzNlxZALnxMFko2xQiHSMW2U6POuS3yj5Rafp60Pvt6iApYtBKAF7 AjoMDq0XGz9zt7q1ZU0lUNV2JW5CbQMQnDznpAMRyTvnMmlNWd4ODvkOJdslAIFQQXGOTe vW60dtKI3snCfy7SFBkMQXoTh9fDjQ4= Message-ID: <7ff738f2-716f-f42a-2f92-3a7d94722d33@suse.com> Date: Tue, 12 Jul 2022 17:30:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> From: Juergen Gross Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen In-Reply-To: <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------0qcVuYOeBgyocpe774tTP9C3" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------0qcVuYOeBgyocpe774tTP9C3 Content-Type: multipart/mixed; boundary="------------bp5CP2emjMCpBr8uvIZiCwkL"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov Message-ID: <7ff738f2-716f-f42a-2f92-3a7d94722d33@suse.com> Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> In-Reply-To: <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> --------------bp5CP2emjMCpBr8uvIZiCwkL Content-Type: multipart/mixed; boundary="------------hVsn0s000J25FiXUpIB0Bzg6" --------------hVsn0s000J25FiXUpIB0Bzg6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDcuMjIgMTc6MDksIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IE9uIDcvMTIv MjAyMiA5OjMyIEFNLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTIuMDcuMjIgMTU6 MjIsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4gT24gNy8xMi8yMDIyIDI6MDQgQU0s IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAxMS4wNy4yMDIyIDE5OjQxLCBDaHVjayBa bXVkemluc2tpIHdyb3RlOg0KPj4+Pj4gTW9yZW92ZXIuLi4gKHBsZWFzZSBtb3ZlIHRvIHRo ZSBib3R0b20gb2YgdGhlIGNvZGUgc25pcHBldA0KPj4+Pj4gZm9yIG1vcmUgaW5mb3JtYXRp b24gYWJvdXQgbXkgdGVzdHMgaW4gdGhlIFhlbiBQViBlbnZpcm9ubWVudC4uLikNCj4+Pj4+ DQo+Pj4+PiB2b2lkIGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4+Pj4+IHsNCj4+Pj4+ICAg wqDCoCDCoHU2NCBwYXQgPSAwOw0KPj4+Pj4NCj4+Pj4+ICAgwqDCoCDCoGlmIChwYXRfY21f aW5pdGlhbGl6ZWQpDQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgcmV0dXJuOw0KPj4+Pj4NCj4+ Pj4+ICAgwqDCoCDCoGlmIChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfUEFUKSkgew0KPj4+ Pj4gICDCoMKgIMKgwqDCoMKgIC8qDQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgwqAqIENQVSBz dXBwb3J0cyBQQVQuIFNldCBQQVQgdGFibGUgdG8gYmUgY29uc2lzdGVudCB3aXRoDQo+Pj4+ PiAgIMKgwqAgwqDCoMKgwqAgwqAqIFBBVCBNU1IuIFRoaXMgY2FzZSBzdXBwb3J0cyAibm9w YXQiIGJvb3Qgb3B0aW9uLCBhbmQNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCogdmlydHVh bCBtYWNoaW5lIGVudmlyb25tZW50cyB3aGljaCBzdXBwb3J0IFBBVCB3aXRob3V0DQo+Pj4+ PiAgIMKgwqAgwqDCoMKgwqAgwqAqIE1UUlJzLiBJbiBzcGVjaWZpYywgWGVuIGhhcyB1bmlx dWUgc2V0dXAgdG8gUEFUIE1TUi4NCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCoNCj4+Pj4+ ICAgwqDCoCDCoMKgwqDCoCDCoCogSWYgUEFUIE1TUiByZXR1cm5zIDAsIGl0IGlzIGNvbnNp ZGVyZWQgaW52YWxpZCBhbmQgZW11bGF0ZXMNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCog YXMgTm8gUEFULg0KPj4+Pj4gICDCoMKgIMKgwqDCoMKgIMKgKi8NCj4+Pj4+ICAgwqDCoCDC oMKgwqDCoCByZG1zcmwoTVNSX0lBMzJfQ1JfUEFULCBwYXQpOw0KPj4+Pj4gICDCoMKgIMKg fQ0KPj4+Pj4NCj4+Pj4+ICAgwqDCoCDCoGlmICghcGF0KSB7DQo+Pj4+PiAgIMKgwqAgwqDC oMKgwqAgLyoNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCogTm8gUEFULiBFbXVsYXRlIHRo ZSBQQVQgdGFibGUgdGhhdCBjb3JyZXNwb25kcyB0byB0aGUgdHdvDQo+Pj4+PiAgIMKgwqAg wqDCoMKgwqAgwqAqIGNhY2hlIGJpdHMsIFBXVCAoV3JpdGUgVGhyb3VnaCkgYW5kIFBDRCAo Q2FjaGUgRGlzYWJsZSkuDQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgwqAqIFRoaXMgc2V0dXAg aXMgYWxzbyB0aGUgc2FtZSBhcyB0aGUgQklPUyBkZWZhdWx0IHNldHVwLg0KPj4+Pj4gICDC oMKgIMKgwqDCoMKgIMKgKg0KPj4+Pj4gICDCoMKgIMKgwqDCoMKgIMKgKiBQVEUgZW5jb2Rp bmc6DQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgwqAqDQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAg wqAqwqDCoMKgwqDCoMKgIFBDRA0KPj4+Pj4gICDCoMKgIMKgwqDCoMKgIMKgKsKgwqDCoMKg wqDCoCB8UFdUwqAgUEFUDQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgwqAqwqDCoMKgwqDCoMKg IHx8wqDCoMKgIHNsb3QNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCrCoMKgwqDCoMKgwqAg MDDCoMKgwqAgMMKgwqDCoCBXQiA6IF9QQUdFX0NBQ0hFX01PREVfV0INCj4+Pj4+ICAgwqDC oCDCoMKgwqDCoCDCoCrCoMKgwqDCoMKgwqAgMDHCoMKgwqAgMcKgwqDCoCBXVCA6IF9QQUdF X0NBQ0hFX01PREVfV1QNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCrCoMKgwqDCoMKgwqAg MTDCoMKgwqAgMsKgwqDCoCBVQy06IF9QQUdFX0NBQ0hFX01PREVfVUNfTUlOVVMNCj4+Pj4+ ICAgwqDCoCDCoMKgwqDCoCDCoCrCoMKgwqDCoMKgwqAgMTHCoMKgwqAgM8KgwqDCoCBVQyA6 IF9QQUdFX0NBQ0hFX01PREVfVUMNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCoNCj4+Pj4+ ICAgwqDCoCDCoMKgwqDCoCDCoCogTk9URTogV2hlbiBXQyBvciBXUCBpcyB1c2VkLCBpdCBp cyByZWRpcmVjdGVkIHRvIFVDLSBwZXINCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCogdGhl IGRlZmF1bHQgc2V0dXAgaW4gX19jYWNoZW1vZGUycHRlX3RibFtdLg0KPj4+Pj4gICDCoMKg IMKgwqDCoMKgIMKgKi8NCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCBwYXQgPSBQQVQoMCwgV0Ip IHwgUEFUKDEsIFdUKSB8IFBBVCgyLCBVQ19NSU5VUykgfCBQQVQoMywgVUMpIHwNCj4+Pj4+ ICAgwqDCoCDCoMKgwqDCoCDCoMKgwqDCoMKgIFBBVCg0LCBXQikgfCBQQVQoNSwgV1QpIHwg UEFUKDYsIFVDX01JTlVTKSB8IFBBVCg3LCBVQyk7DQo+Pj4+PiAgIMKgwqAgwqB9DQo+Pj4+ Pg0KPj4+Pj4gICDCoMKgIMKgZWxzZSBpZiAoIXBhdF9icF9lbmFibGVkKSB7DQo+Pj4+PiAg IMKgwqAgwqDCoMKgwqAgLyoNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCogSW4gc29tZSBl bnZpcm9ubWVudHMsIHNwZWNpZmljYWxseSBYZW4gUFYsIFBBVA0KPj4+Pj4gICDCoMKgIMKg wqDCoMKgIMKgKiBpbml0aWFsaXphdGlvbiBpcyBza2lwcGVkIGJlY2F1c2UgTVRSUnMgYXJl DQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgwqAqIGRpc2FibGVkIGV2ZW4gdGhvdWdoIFBBVCBp cyBhdmFpbGFibGUuIEluIHN1Y2gNCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCDCoCogZW52aXJv bm1lbnRzLCBzZXQgUEFUIHRvIGluaXRpYWxpemVkIGFuZCBlbmFibGVkIHRvDQo+Pj4+PiAg IMKgwqAgwqDCoMKgwqAgwqAqIGNvcnJlY3RseSBpbmRpY2F0ZSB0byBjYWxsZXJzIG9mIHBh dF9lbmFibGVkKCkgdGhhdA0KPj4+Pj4gICDCoMKgIMKgwqDCoMKgIMKgKiBQQVQgaXMgYXZh aWxhYmxlIGFuZCBwcmV2ZW50IFBBVCBmcm9tIGJlaW5nIGRpc2FibGVkLg0KPj4+Pj4gICDC oMKgIMKgwqDCoMKgIMKgKi8NCj4+Pj4+ICAgwqDCoCDCoMKgwqDCoCBwYXRfYnBfZW5hYmxl ZCA9IHRydWU7DQo+Pj4+PiAgIMKgwqAgwqDCoMKgwqAgcHJfaW5mbygieDg2L1BBVDogUEFU IGVuYWJsZWQgYnkgaW5pdF9jYWNoZV9tb2Rlc1xuIik7DQo+Pj4+PiAgIMKgwqAgwqB9DQo+ Pj4+Pg0KPj4+Pj4gICDCoMKgIMKgX19pbml0X2NhY2hlX21vZGVzKHBhdCk7DQo+Pj4+PiB9 DQo+Pj4+Pg0KPj4+Pj4gVGhpcyBmdW5jdGlvbiwgcGF0Y2hlZCB3aXRoIHRoZSBleHRyYSAn ZWxzZSBpZicgYmxvY2ssIGZpeGVzIHRoZQ0KPj4+Pj4gcmVncmVzc2lvbiBvbiBteSBYZW4g d29ya3NhdGF0aW9uLCBhbmQgdGhlIHByX2luZm8gbWVzc2FnZQ0KPj4+Pj4gIng4Ni9QQVQ6 IFBBVCBlbmFibGVkIGJ5IGluaXRfY2FjaGVfbW9kZXMiIGFwcGVhcnMgaW4gdGhlIGxvZ3MN Cj4+Pj4+IHdoZW4gcnVubmluZyB0aGlzIHBhdGNoZWQga2VybmVsIGluIG15IFhlbiBEb20w LiBUaGlzIG1lYW5zDQo+Pj4+PiB0aGF0IGluIHRoZSBYZW4gUFYgZW52aXJvbm1lbnQgb24g bXkgWGVuIERvbTAgd29ya3N0YXRpb24sDQo+Pj4+PiByZG1zcmwoTVNSX0lBMzJfQ1JfUEFU LCBwYXQpIHN1Y2Nlc3NmdWxseSB0ZXN0ZWQgZm9yIHRoZSBwcmVzZW5jZQ0KPj4+Pj4gb2Yg UEFUIG9uIHRoZSB2aXJ0dWFsIENQVSB0aGF0IFhlbiBleHBvc2VkIHRvIHRoZSBMaW51eCBr ZXJuZWwgb24gbXkNCj4+Pj4+IFhlbiBEb20wIHdvcmtzdGF0aW9uLiBBdCBsZWFzdCB0aGF0 IGlzIHdoYXQgSSB0aGluayBteSB0ZXN0cyBwcm92ZS4NCj4+Pj4+DQo+Pj4+PiBTbyB3aHkg aXMgdGhpcyBub3QgYSB2YWxpZCB3YXkgdG8gdGVzdCBmb3IgdGhlIGV4aXN0ZW5jZSBvZg0K Pj4+Pj4gUEFUIGluIHRoZSBYZW4gUFYgZW52aXJvbm1lbnQ/IEFyZSB0aGUgZXhpc3Rpbmcg Y29tbWVudHMNCj4+Pj4+IGluIGluaXRfY2FjaGVfbW9kZXMoKSBhYm91dCBzdXBwb3J0aW5n IGJvdGggdGhlIGNhc2Ugd2hlbg0KPj4+Pj4gdGhlICJub3BhdCIgYm9vdCBvcHRpb24gaXMg c2V0IGFuZCB0aGUgc3BlY2lmaWMgY2FzZSBvZiBYZW4gYW5kDQo+Pj4+PiBNVFJSIGRpc2Fi bGVkIHdyb25nPyBNeSB0ZXN0aW5nIGNvbmZpcm1zIHRob3NlIGNvbW1lbnRzIGFyZQ0KPj4+ Pj4gY29ycmVjdC4NCj4+Pj4NCj4+Pj4gQXQgdGhlIHZlcnkgbGVhc3QgdGhpcyBpZ25vcmVz IHRoZSBwb3NzaWJsZSAibm9wYXQiIGFuIGFkbWluIG1heQ0KPj4+PiBoYXZlIHBhc3NlZCB0 byB0aGUga2VybmVsLg0KPj4+DQo+Pj4gSSByZWFsaXplIHRoYXQuIFRoZSBwYXRjaCBJIHBy b3Bvc2VkIGhlcmUgb25seSBmaXhlcyB0aGUgcmVncmVzc2lvbi4gSXQNCj4+PiB3b3VsZCBi ZSBlYXN5IHRvIGFsc28gbW9kaWZ5IHRoZSBwYXRjaCB0byBhbHNvIG9ic2VydmUgdGhlICdu b3BhdCINCj4+PiBzZXR0aW5nLiBJIHRoaW5rIHlvdXIgcGF0Y2ggaGFkIGEgZm9yY2VfcGF0 X2Rpc2FibGUgbG9jYWwgdmFyaWFibGUgdGhhdA0KPj4+IGlzIHNldCBpZiBwYXQgaXMgZGlz YWJsZWQgYnkgdGhlIGFkbWluaXN0cmF0b3Igd2l0aCAibm9wYXQuIiBXaXRoIHRoYXQNCj4+ PiB2YXJpYWJsZSBhdmFpbGFibGUsIG1vZGlmeWluZyB0aGUgcGF0Y2ggc28gaW4gaW5pdF9j YWNoZV9tb2RlcyB3ZSBoYXZlOg0KPj4+DQo+Pj4gICDCoMKgwqDCoCBpZiAoIXBhdCB8fCBm b3JjZV9wYXRfZGlzYWJsZSkgew0KPj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAvKg0KPj4+ICAg wqDCoMKgwqDCoMKgwqDCoMKgICogTm8gUEFULiBFbXVsYXRlIHRoZSBQQVQgdGFibGUgdGhh dCBjb3JyZXNwb25kcyB0byB0aGUgdHdvDQo+Pj4NCj4+PiBJbnN0ZWFkIG9mOg0KPj4+DQo+ Pj4gICDCoMKgwqDCoCBpZiAoIXBhdCkgew0KPj4+ICAgwqDCoMKgwqDCoMKgwqDCoCAvKg0K Pj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgICogTm8gUEFULiBFbXVsYXRlIHRoZSBQQVQgdGFi bGUgdGhhdCBjb3JyZXNwb25kcyB0byB0aGUgdHdvDQo+Pj4NCj4+PiB3b3VsZCBjYXVzZSB0 aGUga2VybmVsIHRvIHJlc3BlY3QgdGhlICJub3BhdCIgc2V0dGluZyBieSB0aGUgYWRtaW5p c3RyYXRvcg0KPj4+IGluIHRoZSBYZW4gUFYgRG9tMCBlbnZpcm9ubWVudC4NCj4+DQo+PiBD aHVjaywgY291bGQgeW91IHBsZWFzZSBzZW5kIG91dCBhIHByb3BlciBwYXRjaCB3aXRoIHlv dXIgaW5pdGlhbCBmaXgNCj4+IChzZXR0aW5nIHBhdF9icF9lbmFibGVkKSBhbmQgdGhlIGZp eCBhYm92ZT8NCj4+DQo+PiBJJ3ZlIGNoYXR0ZWQgd2l0aCBCb3JpcyBQZXRrb3Ygb24gSVJD IGFuZCBoZSBpcyBmaW5lIHdpdGggdGhhdC4NCj4gDQo+IFRoYXQncyBncmVhdCwgSSB3aWxs IHN1Ym1pdCBhIGZvcm1hbCBwYXRjaCBsYXRlciB0b2RheS4NCj4gDQo+Pg0KPj4+IEkgYWdy ZWUgdGhpcyBuZWVkcyB0byBiZSBmaXhlZCB1cCwgYmVjYXVzZSBjdXJyZW50bHkgdGhlIGNv ZGUgaXMgdmVyeQ0KPj4+IGNvbmZ1c2luZyBhbmQgdGhlIGN1cnJlbnQgdmFyaWFibGUgbmFt ZXMgYW5kIGZ1bmN0aW9uIG5hbWVzIGRvIG5vdA0KPj4+IGFsd2F5cyBhY2N1cmF0ZWx5IGRl c2NyaWJlIHdoYXQgdGhleSBhY3R1YWxseSBkbyBpbiB0aGUgY29kZS4gVGhhdCBpcw0KPj4+ IHdoeSBJIGFtIHdvcmtpbmcgb24gYSBwYXRjaCB0byBkbyBzb21lIHJlLWZhY3RvcmluZywg d2hpY2ggb25seSBjb25zaXN0cw0KPj4+IG9mIGZ1bmN0aW9uIGFuZCB2YXJpYWJsZSBuYW1l IGNoYW5nZXMgYW5kIGNvbW1lbnQgY2hhbmdlcyB0byBmaXgNCj4+PiB0aGUgcGxhY2VzIHdo ZXJlIHRoZSBjb21tZW50cyBpbiB0aGUgY29kZSBhcmUgbWlzbGVhZGluZyBvciBpbmNvbXBs ZXRlLg0KPj4NCj4+IEJvcmlzIGFuZCBJIGFncmVlZCB0byBwdXJzdWUgbXkgYXBwcm9hY2gg ZnVydGhlciBieSByZW1vdmluZyB0aGUNCj4+IGRlcGVuZGVuY3kgYmV0d2VlbiBQQVQgYW5k IE1UUlIgYW5kIHRvIG1ha2UgdGhpcyB3aG9sZSBtZXNzIG1vcmUNCj4+IGNsZWFyLg0KPj4N Cj4+IEkgd2lsbCBzdGFydCB0byB3b3JrIG9uIHRoaXMgYXMgc29vbiBhcyBwb3NzaWJsZSwg d2hpY2ggd2lsbA0KPj4gcHJvYmFibHkgYmUgc29tZSB0aW1lIGluIFNlcHRlbWJlci4NCj4g DQo+IEdvb2QsIEkgd2lsbCBsb29rIGZvciB5b3VyIHBhdGNoZXMgYW5kIHRyeSB0aGVtIG91 dC4NCj4gDQo+Pg0KPj4+IEkgdGhpbmsgcGVyaGFwcyB0aGUgbW9zdCBtaXNuYW1lZCB2YXJp YWJsZSBoZXJlIGlzIHRoZcKgIGxvY2FsDQo+Pj4gdmFyaWFibGUgcGF0X2Rpc2FibGVkIGlu IG1lbXR5cGVzLmMgYW5kIHRoZSBtb3N0IG1pc25hbWVkIGZ1bmN0aW9uIGlzIHRoZQ0KPj4+ IHBhdF9kaXNhYmxlIGZ1bmN0aW9uIGluIG1lbXR5cGVzLmMuIFRoZXkgc2hvdWxkIGJlIG5h bWVkIHBhdF9pbml0X2Rpc2FibGVkDQo+Pj4gYW5kIHBhdF9pbml0X2Rpc2FibGUsIHJlc3Bl Y3RpdmVseSwgYmVjYXVzZSB0aGV5IGRvIG5vdCByZWFsbHkgZGlzYWJsZQ0KPj4+IFBBVCBp bg0KPj4+IHRoZSBjb2RlIGJ1dCBvbmx5IHByZXZlbnQgZXhlY3V0aW9uIG9mIHRoZSBwYXRf aW5pdCBmdW5jdGlvbi4gVGhhdA0KPj4+IGxlYXZlcyBvcGVuDQo+Pj4gdGhlIHBvc3NpYmls aXR5IGZvciBQQVQgdG8gYmUgZW5hYmxlZCBieSBpbml0X2NhY2hlX21vZGVzLCB3aGljaCBh Y3R1YWxseQ0KPj4+IG9jY3VycyBpbiB0aGUgY3VycmVudCBjb2RlIGluIHRoZSBYZW4gUFYg RG9tMCBlbnZpcm9ubWVudCwgYnV0IHRoZSBjdXJyZW50DQo+Pj4gY29kZSBuZWdsZWN0cyB0 byBzZXQgcGF0X2JwX2VuYWJsZWQgdG8gdHJ1ZSBpbiB0aGF0IGNhc2UuIFNvIHdlIG5lZWQg YSBwYXRjaA0KPj4+IHRvIGZpeCB0aGF0IGluIG9yZGVyIHRvIGZpeCB0aGUgcmVncmVzc2lv bi4NCj4+DQo+PiBJbiBwcmluY2lwbGUgSSBhZ3JlZSwgYnV0IHlvdSBzaG91bGQgYmUgYXdh cmUgb2YgbXkgcmVmYWN0b3JpbmcgcGxhbnMuDQo+IA0KPiBJIHdpbGwgZGVmZXIgdG8geW91 IGFuZCBzdG9wIHdvcmtpbmcgb24gdGhpcyByZS1mYWN0b3JpbmcgZWZmb3J0LCBidXQgSQ0K PiB3aWxsIHByZXBhcmUgYSBmb3JtYWwgcGF0Y2ggdG8gZml4IHRoZSByZWdyZXNzaW9uIGxh dGVyIHRvZGF5Lg0KPiANCj4gSSBkbyB0aGluayBKYW4ncyBwb2ludCBhYm91dCByZXNwZWN0 aW5nIHRoZSBhZG1pbmlzdHJhdG9yJ3MgIm5vcGF0IiBzZXR0aW5nDQo+IHNob3VsZCBhbHNv IGJlIGNvbnNpZGVyZWQuIEFGQUlDVCwgdGhlICJub3BhdCIgb3B0aW9uIGluIGN1cnJlbnQg Y29kZQ0KDQpZZXMsIHBsZWFzZSBhZGQgdGhhdCwgdG9vLiBUaGlzIHdhcyB3aGF0IEkgbWVh bnQgd2l0aCAidGhlIGZpeCBhYm92ZSIuDQoNCj4gaXMgYWxzbyBub3QgYmVpbmcgcmVzcGVj dGVkIG9uIHRoZSBiYXJlIG1ldGFsLCBhbmQgdGhlIHBhdGNoIHRvDQo+IGluaXRfY2FjaGVf bW9kZXMgd2l0aCBhIGZvcmNlX25vX3BhdCB2YXJpYWJsZSBpcyBhbHNvIG5lZWRlZCB0bw0K PiBlbnN1cmUgIm5vcGF0IiBpcyByZXNwZWN0ZWQgb24gdGhlIGJhcmUgbWV0YWwsIEFGQUlD VC4NCg0KSG1tLCBJIGRvbid0IHNlZSBob3cgdGhlIFBBVCBNU1Igd2lsbCBiZSB3cml0dGVu IG9uIGJhcmUgbWV0YWwgd2hlbiAibm9wYXQiDQpoYXMgYmVlbiBzcGVjaWZpZWQuDQoNCkkg anVzdCB0cmllZCBpdCB3aXRoIGEgNS4xOSBrZXJuZWwgYW5kIGl0IGJvb3RlZCB3aXRoIHRo ZSBjb3JyZWN0IFBBVA0Kc2V0dGluZ3M6DQoNClsgICAgMC4wMDAwMDBdIHg4Ni9QQVQ6IFBB VCBzdXBwb3J0IGRpc2FibGVkIHZpYSBib290IG9wdGlvbi4NClsgICAgMC4wMDA5ODZdIHg4 Ni9QQVQ6IENvbmZpZ3VyYXRpb24gWzAtN106IFdCICBXVCAgVUMtIFVDICBXQiAgV1QgIFVD LSBVQw0KDQoNCkp1ZXJnZW4NCg== --------------hVsn0s000J25FiXUpIB0Bzg6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------hVsn0s000J25FiXUpIB0Bzg6-- --------------bp5CP2emjMCpBr8uvIZiCwkL-- --------------0qcVuYOeBgyocpe774tTP9C3 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLNk3oFAwAAAAAACgkQsN6d1ii/Ey+5 3Qf/ZqJUOehzN/hZi7dtx2aMUa11580pqFAiPtLTcv8wMfAoicVI2MxOpa6Gq14qhKwvSKOLyZte QvCTmTsUm3KPU8UGTJ196gIBJeI3EclGOkY0hoKj1eQ79mlzJ9JeXHWzx9Hux3aDfU6ngTcDLZEb E0f0nUM4GEyTNWm+sYKAbrZO1KHQZTKuCqxEz3Sw1h0m6LoCH25XMTgYGDCZG1Mo9l5pLrSgktje IWAdrbtcf82kzTzRjh3DUKVxQ/oOt7/LlTzUwStqFPjwZDJGdu0Tiz86AxNSeERYnkgv+dyMqYkq 1Js6SrMu3ATdm81cWVUQosxb6a6s4Rq/zjNIokuxbQ== =2nyO -----END PGP SIGNATURE----- --------------0qcVuYOeBgyocpe774tTP9C3-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:00:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:00:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365817.596143 (Exim 4.92) (envelope-from ) id 1oBIIm-0004kq-QS; Tue, 12 Jul 2022 15:59:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365817.596143; Tue, 12 Jul 2022 15:59:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIIm-0004kj-NU; Tue, 12 Jul 2022 15:59:56 +0000 Received: by outflank-mailman (input) for mailman id 365817; Tue, 12 Jul 2022 15:59:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIIl-0004kb-M8 for xen-devel@lists.xen.org; Tue, 12 Jul 2022 15:59:56 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aaf180bd-01fb-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 17:59:53 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id k30so10685115edk.8 for ; Tue, 12 Jul 2022 08:59:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf180bd-01fb-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EHbL74lI6W7LMVgt8i3KkYlRuQ9ZKvV6xgX1unhHuOU=; b=ZMoiyb5TrJ4j4wjO/MNa8dlJKtd65ZXPKOVB9HAgoOO9fDYFeqT8K/Dx3MNRLgxcN0 4T6OtP8/twCaxGTYd1JeU0C0xiKmMsNtNmAbRVgIJfX2yeaZDZSAXm4gRdGrDe9Y6cEx D0RSivZgwZttmHwCc3/U/bIaAj4TmWpUhRV/TTi1d1sdrDXZhCmn8s9u997Gurqn9xT5 iXJaWe3D2rjY8xt8gsGOcV18xuspBo26hhW57Hb9Q4BAp1Cut93ChbFgBB7r6paj0FCD tiOzxfo+xtgNn5yRXBs9aGyFEMA7aOVeuugHgRDdGmmzcnsQONj964buxaKUhjM+VyLI KmZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EHbL74lI6W7LMVgt8i3KkYlRuQ9ZKvV6xgX1unhHuOU=; b=s+OYUTOUpW+RPgV2me6VxSylkgeHAxqwTla7u9cwYAXM+A/Yr2CsuOypvzA1AJYecV JEHBQOXMxdvY4KDjomlPqBjU/UeF9OZ7PRtJBh2cjmB7jSBM7uoCkZWrNhfXCwVcyAbq rK+6xZAMHqFNlhi3nT/mEXNI8GEI+33ynpr/L8qVTPlICu/VaX388u//wB0cltfi3X+j vCNB4CnasdojoaJP6mMJ6D40zd4DT6zGSGittftVH4gIlWhp7lhQm7Qs6aJwxp/7OhxE MLHLntAZfFd4SIPgTmbXTI9BoIP+2bZ0h6wy88SwTfpl3moG6oXVkWTv/YYUlePB3Sni Gzxg== X-Gm-Message-State: AJIora/ItLpEQCbQHFaqXQstvto4Q6bMH24aujRfbu/1830wXvh9EfP8 Rj7Mj4hzMEilqE2uUU0EONiDfvlh+8rGKykW3V63KfZ5lpmCpA== X-Google-Smtp-Source: AGRyM1sCyZF7OtQL/aYMuRcX0LPiqwXVSGTRopZfSLruJB2bgbAKbwYsx0H77kTE6PlcNa9vebPRypyRCkfXBLz1wWI= X-Received: by 2002:a05:6402:d57:b0:43a:f611:fe40 with SMTP id ec23-20020a0564020d5700b0043af611fe40mr2094999edb.392.1657641593178; Tue, 12 Jul 2022 08:59:53 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Brad Churchwell Date: Tue, 12 Jul 2022 10:59:41 -0500 Message-ID: Subject: Re: Xen on rk3399 To: Bertrand Marquis Cc: "xen-devel@lists.xen.org" Content-Type: multipart/mixed; boundary="00000000000053c7ca05e39dc2f5" --00000000000053c7ca05e39dc2f5 Content-Type: multipart/alternative; boundary="00000000000053c7c805e39dc2f3" --00000000000053c7c805e39dc2f3 Content-Type: text/plain; charset="UTF-8" Hi Bertrand, Thanks so much for the quick response! I should have mentioned previously that this device tree and kernel Image (5.15.16) does boot properly with the rootfs without XEN. The interrupt errors are only present when booting with XEN. These are custom boards and they do have usb c, however we are unable to boot from usb as it doesn't receive power. We currently only use the usb to flash u-boot to spi which requires us to use a separate power adapter. These boards get power and networking through a custom backplane and interface with the backplane via a sata style justice (I'm not sure what the proper terminology would be here). Since I cannot boot to rootfs with XEN, I'm unable to show the device tree there. The only bit that I added to accommodate XEN is this bit here: chosen { stdout-path = "serial2:1500000n8"; bootargs = "hmp-unsafe=true"; xen,dom0-bootargs = "console=hvc0 earlyprintk=xen clk_ignore_unused root=/dev/nvme0n1p2 rw init=/sbin/init rootwait rootfstype=ext4 ignore_loglevel"; modules { #address-cells = <2>; #size-cells = <2>; module@1 { compatible = "xen,linux-zimage", "xen,multiboot-module"; reg = <0x0 0x03F80000 0x0 0x01aa8008>; }; module@2 { compatible = "xen,linux-initrd", "xen,multiboot-module"; reg = <0x0 0x06000000 0x0 0x02000000>; }; }; }; The gic declaration is in the vanilla rk3399.dtsi file and hasn't been modified: gic: interrupt-controller@fee00000 { compatible = "arm,gic-v3"; #interrupt-cells = <4>; #address-cells = <2>; #size-cells = <2>; ranges; interrupt-controller; reg = <0x0 0xfee00000 0 0x10000>, /* GICD */ <0x0 0xfef00000 0 0xc0000>, /* GICR */ <0x0 0xfff00000 0 0x10000>, /* GICC */ <0x0 0xfff10000 0 0x10000>, /* GICH */ <0x0 0xfff20000 0 0x10000>; /* GICV */ interrupts = ; its: interrupt-controller@fee20000 { compatible = "arm,gic-v3-its"; msi-controller; #msi-cells = <1>; reg = <0x0 0xfee20000 0x0 0x20000>; }; ppi-partitions { ppi_cluster0: interrupt-partition-0 { affinity = <&cpu_l0 &cpu_l1 &cpu_l2 &cpu_l3>; }; ppi_cluster1: interrupt-partition-1 { affinity = <&cpu_b0 &cpu_b1>; }; }; }; I've attached the device tree and include files just in case you'd like to take a look at those. Thanks so much for your help! I've been at this for weeks with very little progress. Cheers, Brad On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis wrote: > Hi Brad, > > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > > > Hello, > > > > I've been trying to get Xen to boot dom0 with my kernel for weeks on an > rk3399 based board and thought I'd reach out for help. It looks like either > Xen is not properly recreating the device tree or the interrupt controller > is just failing. The hypervisor boots but falls to initramfs because it > cannot find the root device (nvme on pcie). Any help would be greatly > appreciated. Here is the complete boot log > > From the logs you have an issue with the interrupt controller and the fact > that your NVME is behind PCIE and as such depends on ITS is probably not > helping. > > I would suggest to try to boot on usb as root fs for a try. > > Also it could be useful to compare the device tree on xen and without xen > to understand what is going on (using /proc/device-tree). > > Xen seems to be ok but Linux is not happy with interrupts and is showing > several issues around this area on your logs. > Could you show us an extract of your device tree around the gic > declaration ? > > Cheers > Bertrand > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > --00000000000053c7c805e39dc2f3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bertrand,

Thanks so much for the qui= ck response!=C2=A0

I should have mentioned previou= sly that this device tree and kernel Image (5.15.16) does boot properly wit= h the rootfs without XEN. The interrupt errors are only present when bootin= g with XEN.

These are custom boards and they do ha= ve usb c, however we are unable to boot from usb as it doesn't receive = power.=C2=A0 We currently only use the usb to flash u-boot to spi which req= uires us to use a separate power adapter. These boards get power and networ= king through a custom backplane and interface with the backplane via a sata= style justice (I'm not sure what the proper terminology would be here)= .=C2=A0

Since I cannot boot to rootfs with XEN, I&= #39;m unable to show the device tree there. The only bit that I added to ac= commodate=C2=A0XEN is this bit here:

chosen {
= =C2=A0 =C2=A0 stdout-path =3D "serial2:1500000n8";
=C2=A0 =C2= =A0 bootargs =3D "hmp-unsafe=3Dtrue";
=C2=A0 =C2=A0 xen,dom0-b= ootargs =3D "console=3Dhvc0 earlyprintk=3Dxen clk_ignore_unused root= =3D/dev/nvme0n1p2 rw init=3D/sbin/init rootwait rootfstype=3Dext4 ignore_lo= glevel";
=C2=A0 =C2=A0 modules {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 #ad= dress-cells =3D <2>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 #size-cells =3D &= lt;2>;

=C2=A0 =C2=A0 =C2=A0 =C2=A0 module@1 {
=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 compatible =3D "xen,linux-zimage", &q= uot;xen,multiboot-module";
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 reg =3D <0x0 0x03F80000 0x0 0x01aa8008>;
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 module@2 {
=C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 compatible =3D "xen,linux-initrd", "xe= n,multiboot-module";
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 reg = =3D <0x0 0x06000000 0x0 0x02000000>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }= ;
=C2=A0 =C2=A0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0
};

The gic declaration is in the v= anilla rk3399.dtsi file and hasn't been modified:

<= div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 gic: interrupt-controller@fee00000 {
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 compatible =3D "a= rm,gic-v3";
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= #interrupt-cells =3D <4>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 #address-cells =3D <2>;
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 #size-cells =3D <2>;
=C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ranges;
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 interrupt-controller;

=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 reg =3D <0x0 0xfee00000 0 = 0x10000>, /* GICD */
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 <0x0 0xfef00000 0 0xc0000>, /* GICR */=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 <0x0 0xfff00000 0 0x10000>, /* GICC */
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <0x0 0xfff10000 = 0 0x10000>, /* GICH */
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <0x0 0xfff20000 0 0x10000>; /* GICV *= /
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 interrupts =3D= <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 its: interrupt-controller@fee20000 {
=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 compatible =3D "arm,gic-v3-its";
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 msi-controller;=
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 #msi-cells =3D <1>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 reg =3D <0x0 0xfee2= 0000 0x0 0x20000>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 };

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 pp= i-partitions {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 ppi_cluster0: interrupt-partition-0 {
=C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 affinity =3D <&cpu_l0 &cpu_l1 &a= mp;cpu_l2 &cpu_l3>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 };

=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 ppi_cluster1: i= nterrupt-partition-1 {
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 affinity =3D= <&cpu_b0 &cpu_b1>;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 };
=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 };
=C2=A0 =C2=A0 =C2=A0 =C2=A0 };
=

I've attached the device tree and include fil= es just in case you'd like to take a look at those.

Thanks so much for your help! I've been at this for weeks with ve= ry little progress.

Cheers,
Brad
=C2=A0

On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis &l= t;Bertrand.Marquis@arm.com&= gt; wrote:
Hi Br= ad,

> On 11 Jul 2022, at 19:38, Brad Churchwell <brad@cachengo.com> wrote:
>
> Hello,
>
> I've been trying to get Xen to boot dom0 with my kernel for weeks = on an rk3399 based board and thought I'd reach out for help. It looks l= ike either Xen is not properly recreating the device tree or the interrupt = controller is just failing. The hypervisor boots but falls to initramfs bec= ause it cannot find the root device (nvme on pcie). Any help would be great= ly appreciated. Here is the complete boot log

>From the logs you have an issue with the interrupt controller and the fact = that your NVME is behind PCIE and as such depends on ITS is probably not he= lping.

I would suggest to try to boot on usb as root fs for a try.

Also it could be useful to compare the device tree on xen and without xen t= o understand what is going on (using /proc/device-tree).

Xen seems to be ok but Linux is not happy with interrupts and is showing se= veral issues around this area on your logs.
Could you show us an extract of your device tree around the gic declaration= ?

Cheers
Bertrand


IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.
--00000000000053c7c805e39dc2f3-- --00000000000053c7ca05e39dc2f5 Content-Type: audio/vnd.dts; name="rk3399-zaku.dts" Content-Disposition: attachment; filename="rk3399-zaku.dts" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5iczs940 Ly8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wKyBPUiBNSVQpCi8qCiAqIENvcHly aWdodCAoYykgMjAxOCBMaW5hcm8gTHRkLgogKi8KCi9kdHMtdjEvOwojaW5jbHVkZSAicmszMzk5 LXpha3UuZHRzaSIKCi8gewoJbW9kZWwgPSAiVmFtcnMgUkszMzk5IFpBS1UiOwoJY29tcGF0aWJs ZSA9ICJ2YW1ycyxyb2NrOTYwIiwgInJvY2tjaGlwLHJrMzM5OSI7CgoJY2hvc2VuIHsKCQlzdGRv dXQtcGF0aCA9ICJzZXJpYWwyOjE1MDAwMDBuOCI7CgkJYm9vdGFyZ3MgPSAiaG1wLXVuc2FmZT10 cnVlIjsKICAgICAgICAgICAgICAgIHhlbixkb20wLWJvb3RhcmdzID0gImNvbnNvbGU9aHZjMCBl YXJseXByaW50az14ZW4gY2xrX2lnbm9yZV91bnVzZWQgcm9vdD0vZGV2L252bWUwbjFwMiBydyBp bml0PS9zYmluL2luaXQgcm9vdHdhaXQgcm9vdGZzdHlwZT1leHQ0IGlnbm9yZV9sb2dsZXZlbCI7 CgkJbW9kdWxlcyB7CgkJCSNhZGRyZXNzLWNlbGxzID0gPDI+OwoJCQkjc2l6ZS1jZWxscyA9IDwy PjsKCgkJCW1vZHVsZUAxIHsKCQkJCWNvbXBhdGlibGUgPSAieGVuLGxpbnV4LXppbWFnZSIsICJ4 ZW4sbXVsdGlib290LW1vZHVsZSI7CgkJCQlyZWcgPSA8MHgwIDB4MDNGODAwMDAgMHgwIDB4MDFh YTgwMDg+OwoJCQl9OwogICAgICAgICAgICAgICAgICAgICAgICBtb2R1bGVAMiB7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ4ZW4sbGludXgtaW5pdHJkIiwg InhlbixtdWx0aWJvb3QtbW9kdWxlIjsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZWcgPSA8MHgwIDB4MDYwMDAwMDAgMHgwIDB4MDIwMDAwMDA+OwogICAgICAgICAgICAgICAgICAg ICAgICB9OwogICAgICAgICAgICAgICAgfTsKICAgICAgICAgICAgICAgIAoJfTsKCQoJbGVkcyB7 CgkJY29tcGF0aWJsZSA9ICJncGlvLWxlZHMiOwoJCXN0YXR1cyA9ICJva2F5IjsKCgkJd29yay1s ZWQgewoJCQlsYWJlbCA9ICJ6YWt1OndvcmsiOwoJCQlncGlvcyA9IDwmZ3BpbzQgUktfUEQ2IEdQ SU9fQUNUSVZFX0hJR0g+OwoJCQlsaW51eCxkZWZhdWx0LXRyaWdnZXIgPSAiaGVhcnRiZWF0IjsK CQkJZGVmYXVsdC1zdGF0ZSA9ICJvbiI7CgkJfTsKCX07CgoKfTsKCiZjcHVfYWxlcnQwIHsKCXRl bXBlcmF0dXJlID0gPDY1MDAwPjsKfTsKCiZjcHVfdGhlcm1hbCB7CglzdXN0YWluYWJsZS1wb3dl ciA9IDwxNTUwPjsKCgljb29saW5nLW1hcHMgewoJCW1hcDAgewoJCQl0cmlwID0gPCZjcHVfYWxl cnQxPjsKCQl9OwoJfTsKfTsKCiZwY2llMCB7CgllcC1ncGlvcyA9IDwmZ3BpbzIgUktfUEQ0IEdQ SU9fQUNUSVZFX0hJR0g+Owp9OwoKJnBpbmN0cmwgewoKCWdtYWMgewoJCXJnbWlpX3NsZWVwX3Bp bnM6IHJnbWlpLXNsZWVwLXBpbnMgewoJCQlyb2NrY2hpcCxwaW5zID0KCQkJCTwzIFJLX1BCNyBS S19GVU5DX0dQSU8gJnBjZmdfb3V0cHV0X2xvdz47CgkJfTsKCX07CgoJbGVkcyB7CgkJdXNlcl9s ZWQxX3BpbjogdXNlci1sZWQxLXBpbiB7CgkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJPDQgUktfUEMy IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+OwoJCX07CgoJCXVzZXJfbGVkMl9waW46IHVz ZXItbGVkMi1waW4gewoJCQlyb2NrY2hpcCxwaW5zID0KCQkJCTw0IFJLX1BDNiBSS19GVU5DX0dQ SU8gJnBjZmdfcHVsbF9ub25lPjsKCQl9OwoKCQl1c2VyX2xlZDNfcGluOiB1c2VyLWxlZDMtcGlu IHsKCQkJcm9ja2NoaXAscGlucyA9CgkJCQk8NCBSS19QRDAgUktfRlVOQ19HUElPICZwY2ZnX3B1 bGxfbm9uZT47CgkJfTsKCgkJdXNlcl9sZWQ0X3BpbjogdXNlci1sZWQ0LXBpbiB7CgkJCXJvY2tj aGlwLHBpbnMgPQoJCQkJPDQgUktfUEQ0IFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+OwoJ CX07CgoJCXdsYW5fbGVkX3Bpbjogd2xhbi1sZWQtcGluIHsKCQkJcm9ja2NoaXAscGlucyA9CgkJ CQk8NCBSS19QRDUgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47CgkJfTsKCgkJYnRfbGVk X3BpbjogYnQtbGVkLXBpbiB7CgkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJPDQgUktfUEQ2IFJLX0ZV TkNfR1BJTyAmcGNmZ19wdWxsX25vbmU+OwoJCX07Cgl9OwoKCXBjaWUgewoJCXBjaWVfZHJ2OiBw Y2llLWRydiB7CgkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJPDQgUktfUEMyIFJLX0ZVTkNfR1BJTyAm cGNmZ19wdWxsX3VwXzIwbWE+OwoJCQl9OwoJfTsKCgl1c2IyIHsKCQlzYXRhX3B3cl9vbjogc2F0 YV9wd3Jfb24gewoJCQlyb2NrY2hpcCxwaW5zID0KCQkJCTw0IFJLX1BEMyBSS19GVU5DX0dQSU8g JnBjZmdfcHVsbF9ub25lPjsKCQl9OwoJfTsKfTsKCiZ1c2JkcmRfZHdjM18wIHsKCWRyX21vZGUg PSAib3RnIjsKfTsKCiZ1c2JkcmRfZHdjM18xIHsKCWRyX21vZGUgPSAiaG9zdCI7Cn07Ci8qIENo YW5nZWQgUGluICovCiZ2Y2MzdjNfcGNpZSB7CglncGlvID0gPCZncGlvNCAxOCBHUElPX0FDVElW RV9ISUdIPjsKfTsKLyogQ2hhbmdlZCBQaW4gYW5kIGxhYmVsICovCiZ2Y2M1djBfdXNiIHsKCWdw aW8gPSA8JmdwaW80IDI3IEdQSU9fQUNUSVZFX0hJR0g+Owp9OwoK --00000000000053c7ca05e39dc2f5 Content-Type: application/octet-stream; name="rk3399-zaku.dtsi" Content-Disposition: attachment; filename="rk3399-zaku.dtsi" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5iczs9v2 Ly8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wKyBPUiBNSVQpCi8qCiAqIENvcHly aWdodCAoYykgMjAxOCBDb2xsYWJvcmEgTHRkLgogKiBDb3B5cmlnaHQgKGMpIDIwMTggRnV6aG91 IFJvY2tjaGlwIEVsZWN0cm9uaWNzIENvLiwgTHRkLgogKiBDb3B5cmlnaHQgKGMpIDIwMTggTGlu YXJvIEx0ZC4KICovCgojaW5jbHVkZSAicmszMzk5LmR0c2kiCiNpbmNsdWRlICJyazMzOTktb3Bw LmR0c2kiCgovIHsKCWFsaWFzZXMgewoJCW1tYzAgPSAmc2RpbzA7CgkJbW1jMSA9ICZzZG1tYzsK CQltbWMyID0gJnNkaGNpOwoJfTsKCglzZGlvX3B3cnNlcTogc2Rpby1wd3JzZXEgewoJCXN0YXR1 cyA9ICJkaXNhYmxlZCI7CgkJY29tcGF0aWJsZSA9ICJtbWMtcHdyc2VxLXNpbXBsZSI7CgkJY2xv Y2tzID0gPCZyazgwOCAxPjsKCQljbG9jay1uYW1lcyA9ICJleHRfY2xvY2siOwoJCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7CgkJcGluY3RybC0wID0gPCZ3aWZpX2VuYWJsZV9oPjsKCQlyZXNl dC1ncGlvcyA9IDwmZ3BpbzAgUktfUEIyIEdQSU9fQUNUSVZFX0xPVz47Cgl9OwoKCXZjYzEydl9k Y2luOiB2Y2MxMnYtZGNpbiB7CgkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwoJCXJl Z3VsYXRvci1uYW1lID0gInZjYzEydl9kY2luIjsKCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9 IDwxMjAwMDAwMD47CgkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTIwMDAwMDA+OwoJCXJl Z3VsYXRvci1hbHdheXMtb247CgkJcmVndWxhdG9yLWJvb3Qtb247Cgl9OwoKCXZjYzF2OF9zMDog dmNjMXY4LXMwIHsKCQljb21wYXRpYmxlID0gInJlZ3VsYXRvci1maXhlZCI7CgkJcmVndWxhdG9y LW5hbWUgPSAidmNjMXY4X3MwIjsKCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwxODAwMDAw PjsKCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsKCQlyZWd1bGF0b3ItYWx3 YXlzLW9uOwoJfTsKCgl2Y2M1djBfc3lzOiB2Y2M1djAtc3lzIHsKCQljb21wYXRpYmxlID0gInJl Z3VsYXRvci1maXhlZCI7CgkJcmVndWxhdG9yLW5hbWUgPSAidmNjNXYwX3N5cyI7CgkJcmVndWxh dG9yLW1pbi1taWNyb3ZvbHQgPSA8NTAwMDAwMD47CgkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQg PSA8NTAwMDAwMD47CgkJcmVndWxhdG9yLWFsd2F5cy1vbjsKCQl2aW4tc3VwcGx5ID0gPCZ2Y2Mx MnZfZGNpbj47Cgl9OwoKCWNsa2luX2dtYWM6IGV4dGVybmFsLWdtYWMtY2xvY2sgewoJCWNvbXBh dGlibGUgPSAiZml4ZWQtY2xvY2siOwoJCWNsb2NrLWZyZXF1ZW5jeSA9IDwxMjUwMDAwMDA+OwoJ CWNsb2NrLW91dHB1dC1uYW1lcyA9ICJjbGtpbl9nbWFjIjsKCQkjY2xvY2stY2VsbHMgPSA8MD47 Cgl9OwoKCXZjY19waHk6IHZjYy1waHktcmVndWxhdG9yIHsKCQljb21wYXRpYmxlID0gInJlZ3Vs YXRvci1maXhlZCI7CgkJcmVndWxhdG9yLW5hbWUgPSAidmNjX3BoeSI7CgkJcmVndWxhdG9yLWFs d2F5cy1vbjsKCQlyZWd1bGF0b3ItYm9vdC1vbjsKCX07CgoJdmNjM3YzX3N5czogdmNjM3YzLXN5 cyB7CgkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwoJCXJlZ3VsYXRvci1uYW1lID0g InZjYzN2M19zeXMiOwoJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDMzMDAwMDA+OwoJCXJl Z3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+OwoJCXJlZ3VsYXRvci1hbHdheXMtb247 CgkJdmluLXN1cHBseSA9IDwmdmNjNXYwX3N5cz47Cgl9OwoKCXZjYzN2M19wY2llOiB2Y2MzdjMt cGNpZS1yZWd1bGF0b3IgewoJCWNvbXBhdGlibGUgPSAicmVndWxhdG9yLWZpeGVkIjsKCQllbmFi bGUtYWN0aXZlLWhpZ2g7CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAg PSA8JnBjaWVfZHJ2PjsKCQlyZWd1bGF0b3ItYm9vdC1vbjsKCQlyZWd1bGF0b3ItbmFtZSA9ICJ2 Y2MzdjNfcGNpZSI7CgkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8MzMwMDAwMD47CgkJcmVn dWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MzMwMDAwMD47CgkJdmluLXN1cHBseSA9IDwmdmNjM3Yz X3N5cz47Cgl9OwoKCXZjYzV2MF91c2I6IHZjYzV2MC11c2ItcmVndWxhdG9yIHsKCQljb21wYXRp YmxlID0gInJlZ3VsYXRvci1maXhlZCI7CgkJZW5hYmxlLWFjdGl2ZS1oaWdoOwoJCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7CgkJcGluY3RybC0wID0gPCZzYXRhX3B3cl9vbj47CgkJcmVndWxh dG9yLW5hbWUgPSAidmNjNXYwX3VzYiI7CgkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8NTAw MDAwMD47CgkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8NTAwMDAwMD47CgkJcmVndWxhdG9y LWFsd2F5cy1vbjsKCQl2aW4tc3VwcGx5ID0gPCZ2Y2M1djBfc3lzPjsKCX07CgoJdmNjXzB2OTog dmNjLTB2OSB7CgkJY29tcGF0aWJsZSA9ICJyZWd1bGF0b3ItZml4ZWQiOwoJCXJlZ3VsYXRvci1u YW1lID0gInZjY18wdjkiOwoJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJcmVndWxhdG9yLW1pbi1t aWNyb3ZvbHQgPSA8OTAwMDAwPjsKCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDw5MDAwMDA+ OwoJCXZpbi1zdXBwbHkgPSA8JnZjYzN2M19zeXM+OwoJfTsKCgp9OwoKJmNwdV9sMCB7CgljcHUt c3VwcGx5ID0gPCZ2ZGRfY3B1X2w+Owp9OwoKJmNwdV9sMSB7CgljcHUtc3VwcGx5ID0gPCZ2ZGRf Y3B1X2w+Owp9OwoKJmNwdV9sMiB7CgljcHUtc3VwcGx5ID0gPCZ2ZGRfY3B1X2w+Owp9OwoKJmNw dV9sMyB7CgljcHUtc3VwcGx5ID0gPCZ2ZGRfY3B1X2w+Owp9OwoKJmNwdV9iMCB7CgljcHUtc3Vw cGx5ID0gPCZ2ZGRfY3B1X2I+Owp9OwoKJmNwdV9iMSB7CgljcHUtc3VwcGx5ID0gPCZ2ZGRfY3B1 X2I+Owp9OwoKJmVtbWNfcGh5IHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZnbWFjIHsKCXBoeS1z dXBwbHkgPSA8JnZjY19waHk+OwoJcGh5LW1vZGUgPSAicmdtaWkiOwoJY2xvY2tfaW5fb3V0ID0g ImlucHV0IjsKCXNucHMscmVzZXQtZ3BpbyA9IDwmZ3BpbzMgMTUgR1BJT19BQ1RJVkVfTE9XPjsK CXNucHMscmVzZXQtYWN0aXZlLWxvdzsKCXNucHMscmVzZXQtZGVsYXlzLXVzID0gPDAgMTAwMDAg NTAwMDA+OwoJYXNzaWduZWQtY2xvY2tzID0gPCZjcnUgU0NMS19STUlJX1NSQz47Cglhc3NpZ25l ZC1jbG9jay1wYXJlbnRzID0gPCZjbGtpbl9nbWFjPjsKCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVs dCIsICJzbGVlcCI7CglwaW5jdHJsLTAgPSA8JnJnbWlpX3BpbnM+OwoJcGluY3RybC0xID0gPCZy Z21paV9zbGVlcF9waW5zPjsKCXR4X2RlbGF5ID0gPDB4Mjg+OwoJcnhfZGVsYXkgPSA8MHgxMT47 CglzdGF0dXMgPSAib2theSI7Cn07CgomZ3B1IHsKCW1hbGktc3VwcGx5ID0gPCZ2ZGRfZ3B1PjsK CXN0YXR1cyA9ICJva2F5IjsKfTsKCiZoZG1pIHsKCWRkYy1pMmMtYnVzID0gPCZpMmMzPjsKCXBp bmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7CglwaW5jdHJsLTAgPSA8JmhkbWlfY2VjPjsKCXN0YXR1 cyA9ICJva2F5IjsKfTsKCiZoZG1pX3NvdW5kIHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZpMmMw IHsKCWNsb2NrLWZyZXF1ZW5jeSA9IDw0MDAwMDA+OwoJaTJjLXNjbC1yaXNpbmctdGltZS1ucyA9 IDwxNjg+OwoJaTJjLXNjbC1mYWxsaW5nLXRpbWUtbnMgPSA8ND47CglzdGF0dXMgPSAib2theSI7 CgoJdmRkX2NwdV9iOiByZWd1bGF0b3JANDAgewoJCWNvbXBhdGlibGUgPSAic2lsZXJneSxzeXI4 MjciOwoJCXJlZyA9IDwweDQwPjsKCQlmY3Msc3VzcGVuZC12b2x0YWdlLXNlbGVjdG9yID0gPDE+ OwoJCXJlZ3VsYXRvci1uYW1lID0gInZkZF9jcHVfYiI7CgkJcmVndWxhdG9yLW1pbi1taWNyb3Zv bHQgPSA8NzEyNTAwPjsKCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwxNTAwMDAwPjsKCQly ZWd1bGF0b3ItcmFtcC1kZWxheSA9IDwxMDAwPjsKCQlyZWd1bGF0b3ItYWx3YXlzLW9uOwoJCXJl Z3VsYXRvci1ib290LW9uOwoJCXZpbi1zdXBwbHkgPSA8JnZjYzV2MF9zeXM+OwoJCXN0YXR1cyA9 ICJva2F5IjsKCgkJcmVndWxhdG9yLXN0YXRlLW1lbSB7CgkJCXJlZ3VsYXRvci1vZmYtaW4tc3Vz cGVuZDsKCQl9OwoJfTsKCgl2ZGRfZ3B1OiByZWd1bGF0b3JANDEgewoJCWNvbXBhdGlibGUgPSAi c2lsZXJneSxzeXI4MjgiOwoJCXJlZyA9IDwweDQxPjsKCQlmY3Msc3VzcGVuZC12b2x0YWdlLXNl bGVjdG9yID0gPDE+OwoJCXJlZ3VsYXRvci1uYW1lID0gInZkZF9ncHUiOwoJCXJlZ3VsYXRvci1t aW4tbWljcm92b2x0ID0gPDcxMjUwMD47CgkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTUw MDAwMD47CgkJcmVndWxhdG9yLXJhbXAtZGVsYXkgPSA8MTAwMD47CgkJcmVndWxhdG9yLWFsd2F5 cy1vbjsKCQlyZWd1bGF0b3ItYm9vdC1vbjsKCQl2aW4tc3VwcGx5ID0gPCZ2Y2M1djBfc3lzPjsK CQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKCQkJcmVndWxhdG9yLW9mZi1pbi1zdXNwZW5kOwoJCX07 Cgl9OwoKCXJrODA4OiBwbWljQDFiIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrODA4IjsK CQlyZWcgPSA8MHgxYj47CgkJaW50ZXJydXB0LXBhcmVudCA9IDwmZ3BpbzE+OwoJCWludGVycnVw dHMgPSA8MjEgSVJRX1RZUEVfTEVWRUxfTE9XPjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi OwoJCXBpbmN0cmwtMCA9IDwmcG1pY19pbnRfbD47CgkJcm9ja2NoaXAsc3lzdGVtLXBvd2VyLWNv bnRyb2xsZXI7CgkJd2FrZXVwLXNvdXJjZTsKCQkjY2xvY2stY2VsbHMgPSA8MT47CgkJY2xvY2st b3V0cHV0LW5hbWVzID0gInhpbjMyayIsICJyazgwOC1jbGtvdXQyIjsKCgkJdmNjMS1zdXBwbHkg PSA8JnZjYzV2MF9zeXM+OwoJCXZjYzItc3VwcGx5ID0gPCZ2Y2M1djBfc3lzPjsKCQl2Y2MzLXN1 cHBseSA9IDwmdmNjNXYwX3N5cz47CgkJdmNjNC1zdXBwbHkgPSA8JnZjYzV2MF9zeXM+OwoJCXZj YzYtc3VwcGx5ID0gPCZ2Y2M1djBfc3lzPjsKCQl2Y2M3LXN1cHBseSA9IDwmdmNjNXYwX3N5cz47 CgkJdmNjOC1zdXBwbHkgPSA8JnZjYzN2M19zeXM+OwoJCXZjYzktc3VwcGx5ID0gPCZ2Y2M1djBf c3lzPjsKCQl2Y2MxMC1zdXBwbHkgPSA8JnZjYzV2MF9zeXM+OwoJCXZjYzExLXN1cHBseSA9IDwm dmNjNXYwX3N5cz47CgkJdmNjMTItc3VwcGx5ID0gPCZ2Y2MzdjNfc3lzPjsKCQl2ZGRpby1zdXBw bHkgPSA8JnZjY18xdjg+OwoKCQlyZWd1bGF0b3JzIHsKCQkJdmRkX2NlbnRlcjogRENEQ19SRUcx IHsKCQkJCXJlZ3VsYXRvci1uYW1lID0gInZkZF9jZW50ZXIiOwoJCQkJcmVndWxhdG9yLW1pbi1t aWNyb3ZvbHQgPSA8NzUwMDAwPjsKCQkJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDEzNTAw MDA+OwoJCQkJcmVndWxhdG9yLWFsd2F5cy1vbjsKCQkJCXJlZ3VsYXRvci1ib290LW9uOwoJCQkJ cmVndWxhdG9yLXN0YXRlLW1lbSB7CgkJCQkJcmVndWxhdG9yLW9mZi1pbi1zdXNwZW5kOwoJCQkJ fTsKCQkJfTsKCgkJCXZkZF9jcHVfbDogRENEQ19SRUcyIHsKCQkJCXJlZ3VsYXRvci1uYW1lID0g InZkZF9jcHVfbCI7CgkJCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDw3NTAwMDA+OwoJCQkJ cmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTM1MDAwMD47CgkJCQlyZWd1bGF0b3ItYWx3YXlz LW9uOwoJCQkJcmVndWxhdG9yLWJvb3Qtb247CgkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKCQkJ CQlyZWd1bGF0b3Itb2ZmLWluLXN1c3BlbmQ7CgkJCQl9OwoJCQl9OwoKCQkJdmNjX2RkcjogRENE Q19SRUczIHsKCQkJCXJlZ3VsYXRvci1uYW1lID0gInZjY19kZHIiOwoJCQkJcmVndWxhdG9yLWFs d2F5cy1vbjsKCQkJCXJlZ3VsYXRvci1ib290LW9uOwoJCQkJcmVndWxhdG9yLXN0YXRlLW1lbSB7 CgkJCQkJcmVndWxhdG9yLW9uLWluLXN1c3BlbmQ7CgkJCQl9OwoJCQl9OwoKCQkJdmNjXzF2ODog RENEQ19SRUc0IHsKCQkJCXJlZ3VsYXRvci1uYW1lID0gInZjY18xdjgiOwoJCQkJcmVndWxhdG9y LW1pbi1taWNyb3ZvbHQgPSA8MTgwMDAwMD47CgkJCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9 IDwxODAwMDAwPjsKCQkJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJCQlyZWd1bGF0b3ItYm9vdC1v bjsKCQkJCXJlZ3VsYXRvci1zdGF0ZS1tZW0gewoJCQkJCXJlZ3VsYXRvci1vbi1pbi1zdXNwZW5k OwoJCQkJCXJlZ3VsYXRvci1zdXNwZW5kLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsKCQkJCX07CgkJ CX07CgoJCQl2Y2MxdjhfZHZwOiBMRE9fUkVHMSB7CgkJCQlyZWd1bGF0b3ItbmFtZSA9ICJ2Y2Mx djhfZHZwIjsKCQkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDE4MDAwMDA+OwoJCQkJcmVn dWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MTgwMDAwMD47CgkJCQlyZWd1bGF0b3ItYWx3YXlzLW9u OwoJCQkJcmVndWxhdG9yLWJvb3Qtb247CgkJCQlyZWd1bGF0b3Itc3RhdGUtbWVtIHsKCQkJCQly ZWd1bGF0b3Itb24taW4tc3VzcGVuZDsKCQkJCQlyZWd1bGF0b3Itc3VzcGVuZC1taWNyb3ZvbHQg PSA8MTgwMDAwMD47CgkJCQl9OwoJCQl9OwoKCQkJdmNjYTF2OF9oZG1pOiBMRE9fUkVHMiB7CgkJ CQlyZWd1bGF0b3ItbmFtZSA9ICJ2Y2NhMXY4X2hkbWkiOwoJCQkJcmVndWxhdG9yLW1pbi1taWNy b3ZvbHQgPSA8MTgwMDAwMD47CgkJCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDwxODAwMDAw PjsKCQkJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJCQlyZWd1bGF0b3ItYm9vdC1vbjsKCQkJCXJl Z3VsYXRvci1zdGF0ZS1tZW0gewoJCQkJCXJlZ3VsYXRvci1vbi1pbi1zdXNwZW5kOwoJCQkJCXJl Z3VsYXRvci1zdXNwZW5kLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsKCQkJCX07CgkJCX07CgoJCQl2 Y2NhXzF2ODogTERPX1JFRzMgewoJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjYV8xdjgiOwoJCQkJ cmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8MTgwMDAwMD47CgkJCQlyZWd1bGF0b3ItbWF4LW1p Y3Jvdm9sdCA9IDwxODAwMDAwPjsKCQkJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJCQlyZWd1bGF0 b3ItYm9vdC1vbjsKCQkJCXJlZ3VsYXRvci1zdGF0ZS1tZW0gewoJCQkJCXJlZ3VsYXRvci1vbi1p bi1zdXNwZW5kOwoJCQkJCXJlZ3VsYXRvci1zdXNwZW5kLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsK CQkJCX07CgkJCX07CgoJCQl2Y2Nfc2Q6IExET19SRUc0IHsKCQkJCXJlZ3VsYXRvci1uYW1lID0g InZjY19zZCI7CgkJCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9IDwxODAwMDAwPjsKCQkJCXJl Z3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMzMDAwMDA+OwoJCQkJcmVndWxhdG9yLWFsd2F5cy1v bjsKCQkJCXJlZ3VsYXRvci1ib290LW9uOwoJCQkJcmVndWxhdG9yLXN0YXRlLW1lbSB7CgkJCQkJ cmVndWxhdG9yLW9uLWluLXN1c3BlbmQ7CgkJCQkJcmVndWxhdG9yLXN1c3BlbmQtbWljcm92b2x0 ID0gPDMzMDAwMDA+OwoJCQkJfTsKCQkJfTsKCgkJCXZjYzN2MF9zZDogTERPX1JFRzUgewoJCQkJ cmVndWxhdG9yLW5hbWUgPSAidmNjM3YwX3NkIjsKCQkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0 ID0gPDMwMDAwMDA+OwoJCQkJcmVndWxhdG9yLW1heC1taWNyb3ZvbHQgPSA8MzAwMDAwMD47CgkJ CQlyZWd1bGF0b3ItYWx3YXlzLW9uOwoJCQkJcmVndWxhdG9yLWJvb3Qtb247CgkJCQlyZWd1bGF0 b3Itc3RhdGUtbWVtIHsKCQkJCQlyZWd1bGF0b3Itb24taW4tc3VzcGVuZDsKCQkJCQlyZWd1bGF0 b3Itc3VzcGVuZC1taWNyb3ZvbHQgPSA8MzAwMDAwMD47CgkJCQl9OwoJCQl9OwoKCQkJdmNjXzF2 NTogTERPX1JFRzYgewoJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjXzF2NSI7CgkJCQlyZWd1bGF0 b3ItbWluLW1pY3Jvdm9sdCA9IDwxNTAwMDAwPjsKCQkJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0 ID0gPDE1MDAwMDA+OwoJCQkJcmVndWxhdG9yLWFsd2F5cy1vbjsKCQkJCXJlZ3VsYXRvci1ib290 LW9uOwoJCQkJcmVndWxhdG9yLXN0YXRlLW1lbSB7CgkJCQkJcmVndWxhdG9yLW9uLWluLXN1c3Bl bmQ7CgkJCQkJcmVndWxhdG9yLXN1c3BlbmQtbWljcm92b2x0ID0gPDE1MDAwMDA+OwoJCQkJfTsK CQkJfTsKCgkJCXZjY2EwdjlfaGRtaTogTERPX1JFRzcgewoJCQkJcmVndWxhdG9yLW5hbWUgPSAi dmNjYTB2OV9oZG1pIjsKCQkJCXJlZ3VsYXRvci1taW4tbWljcm92b2x0ID0gPDkwMDAwMD47CgkJ CQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDw5MDAwMDA+OwoJCQkJcmVndWxhdG9yLWFsd2F5 cy1vbjsKCQkJCXJlZ3VsYXRvci1ib290LW9uOwoJCQkJcmVndWxhdG9yLXN0YXRlLW1lbSB7CgkJ CQkJcmVndWxhdG9yLW9uLWluLXN1c3BlbmQ7CgkJCQkJcmVndWxhdG9yLXN1c3BlbmQtbWljcm92 b2x0ID0gPDkwMDAwMD47CgkJCQl9OwoJCQl9OwoKCQkJdmNjXzN2MDogTERPX1JFRzggewoJCQkJ cmVndWxhdG9yLW5hbWUgPSAidmNjXzN2MCI7CgkJCQlyZWd1bGF0b3ItbWluLW1pY3Jvdm9sdCA9 IDwzMDAwMDAwPjsKCQkJCXJlZ3VsYXRvci1tYXgtbWljcm92b2x0ID0gPDMwMDAwMDA+OwoJCQkJ cmVndWxhdG9yLWFsd2F5cy1vbjsKCQkJCXJlZ3VsYXRvci1ib290LW9uOwoJCQkJcmVndWxhdG9y LXN0YXRlLW1lbSB7CgkJCQkJcmVndWxhdG9yLW9uLWluLXN1c3BlbmQ7CgkJCQkJcmVndWxhdG9y LXN1c3BlbmQtbWljcm92b2x0ID0gPDMwMDAwMDA+OwoJCQkJfTsKCQkJfTsKCgkJCXZjYzN2M19z MzogU1dJVENIX1JFRzEgewoJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjM3YzX3MzIjsKCQkJCXJl Z3VsYXRvci1hbHdheXMtb247CgkJCQlyZWd1bGF0b3ItYm9vdC1vbjsKCQkJCXJlZ3VsYXRvci1z dGF0ZS1tZW0gewoJCQkJCXJlZ3VsYXRvci1vbi1pbi1zdXNwZW5kOwoJCQkJfTsKCQkJfTsKCgkJ CXZjYzN2M19zMDogU1dJVENIX1JFRzIgewoJCQkJcmVndWxhdG9yLW5hbWUgPSAidmNjM3YzX3Mw IjsKCQkJCXJlZ3VsYXRvci1hbHdheXMtb247CgkJCQlyZWd1bGF0b3ItYm9vdC1vbjsKCQkJCXJl Z3VsYXRvci1zdGF0ZS1tZW0gewoJCQkJCXJlZ3VsYXRvci1vbi1pbi1zdXNwZW5kOwoJCQkJfTsK CQkJfTsKCQl9OwoJfTsKfTsKCiZpMmMxIHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZpMmMyIHsK CXN0YXR1cyA9ICJva2F5IjsKfTsKCiZpMmMzIHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZpMmM0 IHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZpMnMyIHsKICAgICAgICBzdGF0dXMgPSAib2theSI7 Cn07CgomaW9fZG9tYWlucyB7CglidDY1Ni1zdXBwbHkgPSA8JnZjYzF2OF9zMD47IC8qIGJ0NjU2 X2dwaW8yYWJfbXMgKi8KCWF1ZGlvLXN1cHBseSA9IDwmdmNjMXY4X3MwPjsgLyogYXVkaW9fZ3Bp bzNkNGFfbXMgKi8KCXNkbW1jLXN1cHBseSA9IDwmdmNjX3NkPjsgLyogc2RtbWNfZ3BpbzRiX21z ICovCglncGlvMTgzMC1zdXBwbHkgPSA8JnZjY18zdjA+OyAvKiBncGlvMTgzM19ncGlvNGNkX21z ICovCglzdGF0dXMgPSAib2theSI7Cn07CgomcGNpZV9waHkgewoJc3RhdHVzID0gIm9rYXkiOwp9 OwoKJnBjaWUwIHsKCW51bS1sYW5lcyA9IDw0PjsKCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7 CglwaW5jdHJsLTAgPSA8JnBjaWVfY2xrcmVxbl9jcG0+OwoJdnBjaWUwdjktc3VwcGx5ID0gPCZ2 Y2NfMHY5PjsKCXZwY2llMXY4LXN1cHBseSA9IDwmdmNjYV8xdjg+OwoJdnBjaWUzdjMtc3VwcGx5 ID0gPCZ2Y2MzdjNfcGNpZT47CglzdGF0dXMgPSAib2theSI7Cn07CgomcG11X2lvX2RvbWFpbnMg ewoJcG11MTgzMC1zdXBwbHkgPSA8JnZjY18xdjg+OwoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnBp bmN0cmwgewoJYnQgewoJCWJ0X2VuYWJsZV9oOiBidC1lbmFibGUtaCB7CgkJCXJvY2tjaGlwLHBp bnMgPSA8MCBSS19QQjEgUktfRlVOQ19HUElPICZwY2ZnX3B1bGxfbm9uZT47CgkJfTsKCgkJYnRf aG9zdF93YWtlX2w6IGJ0LWhvc3Qtd2FrZS1sIHsKCQkJcm9ja2NoaXAscGlucyA9IDwwIFJLX1BB NCBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKCQl9OwoKCQlidF93YWtlX2w6IGJ0LXdh a2UtbCB7CgkJCXJvY2tjaGlwLHBpbnMgPSA8MiBSS19QRDMgUktfRlVOQ19HUElPICZwY2ZnX3B1 bGxfbm9uZT47CgkJfTsKCX07CgoJc2RtbWMgewoJCXNkbW1jX2J1czE6IHNkbW1jLWJ1czEgewoJ CQlyb2NrY2hpcCxwaW5zID0KCQkJCTw0IFJLX1BCMCAxICZwY2ZnX3B1bGxfdXBfOG1hPjsKCQl9 OwoKCQlzZG1tY19idXM0OiBzZG1tYy1idXM0IHsKCQkJcm9ja2NoaXAscGlucyA9CgkJCQk8NCBS S19QQjAgMSAmcGNmZ19wdWxsX3VwXzhtYT4sCgkJCQk8NCBSS19QQjEgMSAmcGNmZ19wdWxsX3Vw XzhtYT4sCgkJCQk8NCBSS19QQjIgMSAmcGNmZ19wdWxsX3VwXzhtYT4sCgkJCQk8NCBSS19QQjMg MSAmcGNmZ19wdWxsX3VwXzhtYT47CgkJfTsKCgkJc2RtbWNfY2xrOiBzZG1tYy1jbGsgewoJCQly b2NrY2hpcCxwaW5zID0KCQkJCTw0IFJLX1BCNCAxICZwY2ZnX3B1bGxfbm9uZV8xOG1hPjsKCQl9 OwoKCQlzZG1tY19jbWQ6IHNkbW1jLWNtZCB7CgkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJPDQgUktf UEI1IDEgJnBjZmdfcHVsbF91cF84bWE+OwoJCX07Cgl9OwoKCXNkaW8wIHsKCQlzZGlvMF9idXM0 OiBzZGlvMC1idXM0IHsKCQkJcm9ja2NoaXAscGlucyA9CgkJCQk8MiBSS19QQzQgMSAmcGNmZ19w dWxsX3VwXzIwbWE+LAoJCQkJPDIgUktfUEM1IDEgJnBjZmdfcHVsbF91cF8yMG1hPiwKCQkJCTwy IFJLX1BDNiAxICZwY2ZnX3B1bGxfdXBfMjBtYT4sCgkJCQk8MiBSS19QQzcgMSAmcGNmZ19wdWxs X3VwXzIwbWE+OwoJCX07CgoJCXNkaW8wX2NtZDogc2RpbzAtY21kIHsKCQkJcm9ja2NoaXAscGlu cyA9CgkJCQk8MiBSS19QRDAgMSAmcGNmZ19wdWxsX3VwXzIwbWE+OwoJCX07CgoJCXNkaW8wX2Ns azogc2RpbzAtY2xrIHsKCQkJcm9ja2NoaXAscGlucyA9CgkJCQk8MiBSS19QRDEgMSAmcGNmZ19w dWxsX25vbmVfMjBtYT47CgkJfTsKCX07CgoJcG1pYyB7CgkJcG1pY19pbnRfbDogcG1pYy1pbnQt bCB7CgkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJPDEgUktfUEM1IFJLX0ZVTkNfR1BJTyAmcGNmZ19w dWxsX3VwPjsKCQl9OwoKCQl2c2VsMV9waW46IHZzZWwxLXBpbiB7CgkJCXJvY2tjaGlwLHBpbnMg PQoJCQkJPDEgUktfUEMxIFJLX0ZVTkNfR1BJTyAmcGNmZ19wdWxsX2Rvd24+OwoJCX07CgoJCXZz ZWwyX3BpbjogdnNlbDItcGluIHsKCQkJcm9ja2NoaXAscGlucyA9CgkJCQk8MSBSS19QQjYgUktf RlVOQ19HUElPICZwY2ZnX3B1bGxfZG93bj47CgkJfTsKCX07CgoJc2Rpby1wd3JzZXEgewoJCXdp ZmlfZW5hYmxlX2g6IHdpZmktZW5hYmxlLWggewoJCQlyb2NrY2hpcCxwaW5zID0KCQkJCTwwIFJL X1BCMiBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKCQl9OwoJfTsKCgl3aWZpIHsKCQl3 aWZpX2hvc3Rfd2FrZV9sOiB3aWZpLWhvc3Qtd2FrZS1sIHsKCQkJcm9ja2NoaXAscGlucyA9IDww IFJLX1BBMyBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKCQl9OwoJfTsKCQoJa2V5IHsK CQlwd3JidG46IHB3cmJ0biB7CgkJCXJvY2tjaGlwLHBpbnMgPSA8MCBSS19QQjEgUktfRlVOQ19H UElPICZwY2ZnX3B1bGxfdXA+OwoJCX07Cgl9Owp9OwoKJnB3bTIgewoJc3RhdHVzID0gIm9rYXki Owp9OwoKJnB3bTMgewoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnNkaW8wIHsKCWJ1cy13aWR0aCA9 IDw0PjsKCWNsb2NrLWZyZXF1ZW5jeSA9IDw1MDAwMDAwMD47CgljYXAtc2Rpby1pcnE7CgljYXAt c2QtaGlnaHNwZWVkOwoJa2VlcC1wb3dlci1pbi1zdXNwZW5kOwoJbW1jLXB3cnNlcSA9IDwmc2Rp b19wd3JzZXE+OwoJbm9uLXJlbW92YWJsZTsKCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7Cglw aW5jdHJsLTAgPSA8JnNkaW8wX2J1czQgJnNkaW8wX2NtZCAmc2RpbzBfY2xrPjsKCXNkLXVocy1z ZHIxMDQ7CgkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCSNzaXplLWNlbGxzID0gPDA+OwoJc3RhdHVz ID0gIm9rYXkiOwoKCWJyY21mOiB3aWZpQDEgewoJCWNvbXBhdGlibGUgPSAiYnJjbSxiY200MzI5 LWZtYWMiOwoJCXJlZyA9IDwxPjsKCQlpbnRlcnJ1cHQtcGFyZW50ID0gPCZncGlvMD47CgkJaW50 ZXJydXB0cyA9IDxSS19QQTMgR1BJT19BQ1RJVkVfSElHSD47CgkJaW50ZXJydXB0LW5hbWVzID0g Imhvc3Qtd2FrZSI7CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8 JndpZmlfaG9zdF93YWtlX2w+OwoJfTsKfTsKCiZzZGhjaSB7CglidXMtd2lkdGggPSA8OD47Cglt bWMtaHM0MDAtMV84djsKCW1tYy1oczQwMC1lbmhhbmNlZC1zdHJvYmU7Cglub24tcmVtb3ZhYmxl OwoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnNkbW1jIHsKCWJ1cy13aWR0aCA9IDw0PjsKCWNhcC1t bWMtaGlnaHNwZWVkOwoJY2FwLXNkLWhpZ2hzcGVlZDsKCWNsb2NrLWZyZXF1ZW5jeSA9IDwxMDAw MDAwMDA+OwoJbWF4LWZyZXF1ZW5jeSA9IDwxMDAwMDAwMDA+OwoJY2QtZ3Bpb3MgPSA8JmdwaW8w IDcgR1BJT19BQ1RJVkVfTE9XPjsKCWRpc2FibGUtd3A7CglzZC11aHMtc2RyMTA0OwoJdnFtbWMt c3VwcGx5ID0gPCZ2Y2Nfc2Q+OwoJY2FyZC1kZXRlY3QtZGVsYXkgPSA8ODAwPjsKCXBpbmN0cmwt bmFtZXMgPSAiZGVmYXVsdCI7CglwaW5jdHJsLTAgPSA8JnNkbW1jX2NsayAmc2RtbWNfY21kICZz ZG1tY19jZCAmc2RtbWNfYnVzND47CglzdGF0dXMgPSAiZGlzYWJsZWQiOwp9OwoKJnRzYWRjIHsK CXJvY2tjaGlwLGh3LXRzaHV0LW1vZGUgPSA8MT47Cglyb2NrY2hpcCxody10c2h1dC1wb2xhcml0 eSA9IDwxPjsKCXJvY2tjaGlwLGh3LXRzaHV0LXRlbXAgPSA8MTEwMDAwPjsKCXN0YXR1cyA9ICJv a2F5IjsKfTsKCiZ1YXJ0MCB7CglwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJcGluY3RybC0w ID0gPCZ1YXJ0MF94ZmVyICZ1YXJ0MF9jdHMgJnVhcnQwX3J0cz47CglzdGF0dXMgPSAiZGlzYWJs ZWQiOwoKCWJsdWV0b290aCB7CgkJY29tcGF0aWJsZSA9ICJicmNtLGJjbTQzNDM4LWJ0IjsKCQlj bG9ja3MgPSA8JnJrODA4IDE+OwoJCWNsb2NrLW5hbWVzID0gImV4dF9jbG9jayI7CgkJZGV2aWNl LXdha2V1cC1ncGlvcyA9IDwmZ3BpbzIgUktfUEQzIEdQSU9fQUNUSVZFX0hJR0g+OwoJCWhvc3Qt d2FrZXVwLWdwaW9zID0gPCZncGlvMCBSS19QQTQgR1BJT19BQ1RJVkVfSElHSD47CgkJc2h1dGRv d24tZ3Bpb3MgPSA8JmdwaW8wIFJLX1BCMSBHUElPX0FDVElWRV9ISUdIPjsKCQlwaW5jdHJsLW5h bWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmYnRfaG9zdF93YWtlX2wgJmJ0X3dha2Vf bCAmYnRfZW5hYmxlX2g+OwoJfTsKfTsKCiZ1YXJ0MiB7CglzdGF0dXMgPSAib2theSI7Cn07Cgom dGNwaHkwIHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZ0Y3BoeTEgewoJc3RhdHVzID0gIm9rYXki Owp9OwoKJnUycGh5MCB7CglzdGF0dXMgPSAib2theSI7CgllbmFibGUtYWN0aXZlLWhpZ2g7Cgkv KiBvdGctdmJ1cy1ncGlvcyA9IDwmZ3BpbzEgMyBHUElPX0FDVElWRV9ISUdIPjsqLwoJZ3BpbyA9 IDwmZ3BpbzEgMyBHUElPX0FDVElWRV9ISUdIPjsKfTsKCiZ1MnBoeTEgewoJc3RhdHVzID0gIm9r YXkiOwp9OwoKJnUycGh5MF9ob3N0IHsKCXBoeS1zdXBwbHkgPSA8JnZjYzV2MF91c2I+OwoJc3Rh dHVzID0gIm9rYXkiOwp9OwoKJnUycGh5MV9ob3N0IHsKCXBoeS1zdXBwbHkgPSA8JnZjYzV2MF91 c2I+OwoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnUycGh5MF9vdGcgewoJc3RhdHVzID0gIm9rYXki Owp9OwoKJnUycGh5MV9vdGcgewoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnVzYl9ob3N0MF9laGNp IHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZ1c2JfaG9zdDBfb2hjaSB7CglzdGF0dXMgPSAib2th eSI7Cn07CgomdXNiX2hvc3QxX2VoY2kgewoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnVzYl9ob3N0 MV9vaGNpIHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCiZ1c2JkcmQzXzAgewoJZXh0Y29uID0gPCZ1 MnBoeTA+OwoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnVzYmRyZF9kd2MzXzAgewoJc3RhdHVzID0g Im9rYXkiOwp9OwoKJnVzYmRyZDNfMSB7CglzdGF0dXMgPSAib2theSI7Cn07CgomdXNiZHJkX2R3 YzNfMSB7CglzdGF0dXMgPSAib2theSI7Cn07Cgomdm9wYiB7CglzdGF0dXMgPSAib2theSI7Cn07 Cgomdm9wYl9tbXUgewoJc3RhdHVzID0gIm9rYXkiOwp9OwoKJnZvcGwgewoJc3RhdHVzID0gIm9r YXkiOwp9OwoKJnZvcGxfbW11IHsKCXN0YXR1cyA9ICJva2F5IjsKfTsKCg== --00000000000053c7ca05e39dc2f5 Content-Type: application/octet-stream; name="rk3399.dtsi" Content-Disposition: attachment; filename="rk3399.dtsi" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l5iczs9u1 Ly8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwtMi4wKyBPUiBNSVQpCi8qCiAqIENvcHly aWdodCAoYykgMjAxNiBGdXpob3UgUm9ja2NoaXAgRWxlY3Ryb25pY3MgQ28uLCBMdGQKICovCgoj aW5jbHVkZSA8ZHQtYmluZGluZ3MvY2xvY2svcmszMzk5LWNydS5oPgojaW5jbHVkZSA8ZHQtYmlu ZGluZ3MvZ3Bpby9ncGlvLmg+CiNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJv bGxlci9hcm0tZ2ljLmg+CiNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxl ci9pcnEuaD4KI2luY2x1ZGUgPGR0LWJpbmRpbmdzL3BpbmN0cmwvcm9ja2NoaXAuaD4KI2luY2x1 ZGUgPGR0LWJpbmRpbmdzL3Bvd2VyL3JrMzM5OS1wb3dlci5oPgojaW5jbHVkZSA8ZHQtYmluZGlu Z3MvdGhlcm1hbC90aGVybWFsLmg+CgovIHsKCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5 IjsKCglpbnRlcnJ1cHQtcGFyZW50ID0gPCZnaWM+OwoJI2FkZHJlc3MtY2VsbHMgPSA8Mj47Cgkj c2l6ZS1jZWxscyA9IDwyPjsKCglhbGlhc2VzIHsKCQlldGhlcm5ldDAgPSAmZ21hYzsKCQlpMmMw ID0gJmkyYzA7CgkJaTJjMSA9ICZpMmMxOwoJCWkyYzIgPSAmaTJjMjsKCQlpMmMzID0gJmkyYzM7 CgkJaTJjNCA9ICZpMmM0OwoJCWkyYzUgPSAmaTJjNTsKCQlpMmM2ID0gJmkyYzY7CgkJaTJjNyA9 ICZpMmM3OwoJCWkyYzggPSAmaTJjODsKCQlzZXJpYWwwID0gJnVhcnQwOwoJCXNlcmlhbDEgPSAm dWFydDE7CgkJc2VyaWFsMiA9ICZ1YXJ0MjsKCQlzZXJpYWwzID0gJnVhcnQzOwoJCXNlcmlhbDQg PSAmdWFydDQ7Cgl9OwoKCWNwdXMgewoJCSNhZGRyZXNzLWNlbGxzID0gPDI+OwoJCSNzaXplLWNl bGxzID0gPDA+OwoKCQljcHUtbWFwIHsKCQkJY2x1c3RlcjAgewoJCQkJY29yZTAgewoJCQkJCWNw dSA9IDwmY3B1X2wwPjsKCQkJCX07CgkJCQljb3JlMSB7CgkJCQkJY3B1ID0gPCZjcHVfbDE+OwoJ CQkJfTsKCQkJCWNvcmUyIHsKCQkJCQljcHUgPSA8JmNwdV9sMj47CgkJCQl9OwoJCQkJY29yZTMg ewoJCQkJCWNwdSA9IDwmY3B1X2wzPjsKCQkJCX07CgkJCX07CgoJCQljbHVzdGVyMSB7CgkJCQlj b3JlMCB7CgkJCQkJY3B1ID0gPCZjcHVfYjA+OwoJCQkJfTsKCQkJCWNvcmUxIHsKCQkJCQljcHUg PSA8JmNwdV9iMT47CgkJCQl9OwoJCQl9OwoJCX07CgoJCWNwdV9sMDogY3B1QDAgewoJCQlkZXZp Y2VfdHlwZSA9ICJjcHUiOwoJCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTUzIjsKCQkJcmVn ID0gPDB4MCAweDA+OwoJCQllbmFibGUtbWV0aG9kID0gInBzY2kiOwoJCQljYXBhY2l0eS1kbWlw cy1taHogPSA8NDg1PjsKCQkJY2xvY2tzID0gPCZjcnUgQVJNQ0xLTD47CgkJCSNjb29saW5nLWNl bGxzID0gPDI+OyAvKiBtaW4gZm9sbG93ZWQgYnkgbWF4ICovCgkJCWR5bmFtaWMtcG93ZXItY29l ZmZpY2llbnQgPSA8MTAwPjsKCQkJY3B1LWlkbGUtc3RhdGVzID0gPCZDUFVfU0xFRVAgJkNMVVNU RVJfU0xFRVA+OwoJCX07CgoJCWNwdV9sMTogY3B1QDEgewoJCQlkZXZpY2VfdHlwZSA9ICJjcHUi OwoJCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTUzIjsKCQkJcmVnID0gPDB4MCAweDE+OwoJ CQllbmFibGUtbWV0aG9kID0gInBzY2kiOwoJCQljYXBhY2l0eS1kbWlwcy1taHogPSA8NDg1PjsK CQkJY2xvY2tzID0gPCZjcnUgQVJNQ0xLTD47CgkJCSNjb29saW5nLWNlbGxzID0gPDI+OyAvKiBt aW4gZm9sbG93ZWQgYnkgbWF4ICovCgkJCWR5bmFtaWMtcG93ZXItY29lZmZpY2llbnQgPSA8MTAw PjsKCQkJY3B1LWlkbGUtc3RhdGVzID0gPCZDUFVfU0xFRVAgJkNMVVNURVJfU0xFRVA+OwoJCX07 CgoJCWNwdV9sMjogY3B1QDIgewoJCQlkZXZpY2VfdHlwZSA9ICJjcHUiOwoJCQljb21wYXRpYmxl ID0gImFybSxjb3J0ZXgtYTUzIjsKCQkJcmVnID0gPDB4MCAweDI+OwoJCQllbmFibGUtbWV0aG9k ID0gInBzY2kiOwoJCQljYXBhY2l0eS1kbWlwcy1taHogPSA8NDg1PjsKCQkJY2xvY2tzID0gPCZj cnUgQVJNQ0xLTD47CgkJCSNjb29saW5nLWNlbGxzID0gPDI+OyAvKiBtaW4gZm9sbG93ZWQgYnkg bWF4ICovCgkJCWR5bmFtaWMtcG93ZXItY29lZmZpY2llbnQgPSA8MTAwPjsKCQkJY3B1LWlkbGUt c3RhdGVzID0gPCZDUFVfU0xFRVAgJkNMVVNURVJfU0xFRVA+OwoJCX07CgoJCWNwdV9sMzogY3B1 QDMgewoJCQlkZXZpY2VfdHlwZSA9ICJjcHUiOwoJCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgt YTUzIjsKCQkJcmVnID0gPDB4MCAweDM+OwoJCQllbmFibGUtbWV0aG9kID0gInBzY2kiOwoJCQlj YXBhY2l0eS1kbWlwcy1taHogPSA8NDg1PjsKCQkJY2xvY2tzID0gPCZjcnUgQVJNQ0xLTD47CgkJ CSNjb29saW5nLWNlbGxzID0gPDI+OyAvKiBtaW4gZm9sbG93ZWQgYnkgbWF4ICovCgkJCWR5bmFt aWMtcG93ZXItY29lZmZpY2llbnQgPSA8MTAwPjsKCQkJY3B1LWlkbGUtc3RhdGVzID0gPCZDUFVf U0xFRVAgJkNMVVNURVJfU0xFRVA+OwoJCX07CgoJCWNwdV9iMDogY3B1QDEwMCB7CgkJCWRldmlj ZV90eXBlID0gImNwdSI7CgkJCWNvbXBhdGlibGUgPSAiYXJtLGNvcnRleC1hNzIiOwoJCQlyZWcg PSA8MHgwIDB4MTAwPjsKCQkJZW5hYmxlLW1ldGhvZCA9ICJwc2NpIjsKCQkJY2FwYWNpdHktZG1p cHMtbWh6ID0gPDEwMjQ+OwoJCQljbG9ja3MgPSA8JmNydSBBUk1DTEtCPjsKCQkJI2Nvb2xpbmct Y2VsbHMgPSA8Mj47IC8qIG1pbiBmb2xsb3dlZCBieSBtYXggKi8KCQkJZHluYW1pYy1wb3dlci1j b2VmZmljaWVudCA9IDw0MzY+OwoJCQljcHUtaWRsZS1zdGF0ZXMgPSA8JkNQVV9TTEVFUCAmQ0xV U1RFUl9TTEVFUD47CgkJfTsKCgkJY3B1X2IxOiBjcHVAMTAxIHsKCQkJZGV2aWNlX3R5cGUgPSAi Y3B1IjsKCQkJY29tcGF0aWJsZSA9ICJhcm0sY29ydGV4LWE3MiI7CgkJCXJlZyA9IDwweDAgMHgx MDE+OwoJCQllbmFibGUtbWV0aG9kID0gInBzY2kiOwoJCQljYXBhY2l0eS1kbWlwcy1taHogPSA8 MTAyND47CgkJCWNsb2NrcyA9IDwmY3J1IEFSTUNMS0I+OwoJCQkjY29vbGluZy1jZWxscyA9IDwy PjsgLyogbWluIGZvbGxvd2VkIGJ5IG1heCAqLwoJCQlkeW5hbWljLXBvd2VyLWNvZWZmaWNpZW50 ID0gPDQzNj47CgkJCWNwdS1pZGxlLXN0YXRlcyA9IDwmQ1BVX1NMRUVQICZDTFVTVEVSX1NMRUVQ PjsKCQl9OwoKCQlpZGxlLXN0YXRlcyB7CgkJCWVudHJ5LW1ldGhvZCA9ICJwc2NpIjsKCgkJCUNQ VV9TTEVFUDogY3B1LXNsZWVwIHsKCQkJCWNvbXBhdGlibGUgPSAiYXJtLGlkbGUtc3RhdGUiOwoJ CQkJbG9jYWwtdGltZXItc3RvcDsKCQkJCWFybSxwc2NpLXN1c3BlbmQtcGFyYW0gPSA8MHgwMDEw MDAwPjsKCQkJCWVudHJ5LWxhdGVuY3ktdXMgPSA8MTIwPjsKCQkJCWV4aXQtbGF0ZW5jeS11cyA9 IDwyNTA+OwoJCQkJbWluLXJlc2lkZW5jeS11cyA9IDw5MDA+OwoJCQl9OwoKCQkJQ0xVU1RFUl9T TEVFUDogY2x1c3Rlci1zbGVlcCB7CgkJCQljb21wYXRpYmxlID0gImFybSxpZGxlLXN0YXRlIjsK CQkJCWxvY2FsLXRpbWVyLXN0b3A7CgkJCQlhcm0scHNjaS1zdXNwZW5kLXBhcmFtID0gPDB4MTAx MDAwMD47CgkJCQllbnRyeS1sYXRlbmN5LXVzID0gPDQwMD47CgkJCQlleGl0LWxhdGVuY3ktdXMg PSA8NTAwPjsKCQkJCW1pbi1yZXNpZGVuY3ktdXMgPSA8MjAwMD47CgkJCX07CgkJfTsKCX07CgoJ ZGlzcGxheS1zdWJzeXN0ZW0gewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAsZGlzcGxheS1zdWJz eXN0ZW0iOwoJCXBvcnRzID0gPCZ2b3BsX291dD4sIDwmdm9wYl9vdXQ+OwoJfTsKCglwbXVfYTUz IHsKCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTUzLXBtdSI7CgkJaW50ZXJydXB0cyA9IDxH SUNfUFBJIDcgSVJRX1RZUEVfTEVWRUxfTE9XICZwcGlfY2x1c3RlcjA+OwoJfTsKCglwbXVfYTcy IHsKCQljb21wYXRpYmxlID0gImFybSxjb3J0ZXgtYTcyLXBtdSI7CgkJaW50ZXJydXB0cyA9IDxH SUNfUFBJIDcgSVJRX1RZUEVfTEVWRUxfTE9XICZwcGlfY2x1c3RlcjE+OwoJfTsKCglwc2NpIHsK CQljb21wYXRpYmxlID0gImFybSxwc2NpLTEuMCI7CgkJbWV0aG9kID0gInNtYyI7Cgl9OwoKCXRp bWVyIHsKCQljb21wYXRpYmxlID0gImFybSxhcm12OC10aW1lciI7CgkJaW50ZXJydXB0cyA9IDxH SUNfUFBJIDEzIElSUV9UWVBFX0xFVkVMX0xPVyAwPiwKCQkJICAgICA8R0lDX1BQSSAxNCBJUlFf VFlQRV9MRVZFTF9MT1cgMD4sCgkJCSAgICAgPEdJQ19QUEkgMTEgSVJRX1RZUEVfTEVWRUxfTE9X IDA+LAoJCQkgICAgIDxHSUNfUFBJIDEwIElSUV9UWVBFX0xFVkVMX0xPVyAwPjsKCQlhcm0sbm8t dGljay1pbi1zdXNwZW5kOwoJfTsKCgl4aW4yNG06IHhpbjI0bSB7CgkJY29tcGF0aWJsZSA9ICJm aXhlZC1jbG9jayI7CgkJY2xvY2stZnJlcXVlbmN5ID0gPDI0MDAwMDAwPjsKCQljbG9jay1vdXRw dXQtbmFtZXMgPSAieGluMjRtIjsKCQkjY2xvY2stY2VsbHMgPSA8MD47Cgl9OwoKCXBjaWUwOiBw Y2llQGY4MDAwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1wY2llIjsKCQly ZWcgPSA8MHgwIDB4ZjgwMDAwMDAgMHgwIDB4MjAwMDAwMD4sCgkJICAgICAgPDB4MCAweGZkMDAw MDAwIDB4MCAweDEwMDAwMDA+OwoJCXJlZy1uYW1lcyA9ICJheGktYmFzZSIsICJhcGItYmFzZSI7 CgkJZGV2aWNlX3R5cGUgPSAicGNpIjsKCQkjYWRkcmVzcy1jZWxscyA9IDwzPjsKCQkjc2l6ZS1j ZWxscyA9IDwyPjsKCQkjaW50ZXJydXB0LWNlbGxzID0gPDE+OwoJCWFzcG0tbm8tbDBzOwoJCWJ1 cy1yYW5nZSA9IDwweDAgMHgxZj47CgkJY2xvY2tzID0gPCZjcnUgQUNMS19QQ0lFPiwgPCZjcnUg QUNMS19QRVJGX1BDSUU+LAoJCQkgPCZjcnUgUENMS19QQ0lFPiwgPCZjcnUgU0NMS19QQ0lFX1BN PjsKCQljbG9jay1uYW1lcyA9ICJhY2xrIiwgImFjbGstcGVyZiIsCgkJCSAgICAgICJoY2xrIiwg InBtIjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgNDkgSVJRX1RZUEVfTEVWRUxfSElHSCAwPiwK CQkJICAgICA8R0lDX1NQSSA1MCBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+LAoJCQkgICAgIDxHSUNf U1BJIDUxIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJaW50ZXJydXB0LW5hbWVzID0gInN5cyIs ICJsZWdhY3kiLCAiY2xpZW50IjsKCQlpbnRlcnJ1cHQtbWFwLW1hc2sgPSA8MCAwIDAgNz47CgkJ aW50ZXJydXB0LW1hcCA9IDwwIDAgMCAxICZwY2llMF9pbnRjIDA+LAoJCQkJPDAgMCAwIDIgJnBj aWUwX2ludGMgMT4sCgkJCQk8MCAwIDAgMyAmcGNpZTBfaW50YyAyPiwKCQkJCTwwIDAgMCA0ICZw Y2llMF9pbnRjIDM+OwoJCW1heC1saW5rLXNwZWVkID0gPDE+OwoJCW1zaS1tYXAgPSA8MHgwICZp dHMgMHgwIDB4MTAwMD47CgkJcGh5cyA9IDwmcGNpZV9waHkgMD4sIDwmcGNpZV9waHkgMT4sCgkJ ICAgICAgIDwmcGNpZV9waHkgMj4sIDwmcGNpZV9waHkgMz47CgkJcGh5LW5hbWVzID0gInBjaWUt cGh5LTAiLCAicGNpZS1waHktMSIsCgkJCSAgICAicGNpZS1waHktMiIsICJwY2llLXBoeS0zIjsK CQlyYW5nZXMgPSA8MHg4MjAwMDAwMCAweDAgMHhmYTAwMDAwMCAweDAgMHhmYTAwMDAwMCAweDAg MHgxZTAwMDAwPiwKCQkJIDwweDgxMDAwMDAwIDB4MCAweGZiZTAwMDAwIDB4MCAweGZiZTAwMDAw IDB4MCAweDEwMDAwMD47CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9QQ0lFX0NPUkU+LCA8JmNydSBT UlNUX1BDSUVfTUdNVD4sCgkJCSA8JmNydSBTUlNUX1BDSUVfTUdNVF9TVElDS1k+LCA8JmNydSBT UlNUX1BDSUVfUElQRT4sCgkJCSA8JmNydSBTUlNUX1BDSUVfUE0+LCA8JmNydSBTUlNUX1BfUENJ RT4sCgkJCSA8JmNydSBTUlNUX0FfUENJRT47CgkJcmVzZXQtbmFtZXMgPSAiY29yZSIsICJtZ210 IiwgIm1nbXQtc3RpY2t5IiwgInBpcGUiLAoJCQkgICAgICAicG0iLCAicGNsayIsICJhY2xrIjsK CQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoKCQlwY2llMF9pbnRjOiBpbnRlcnJ1cHQtY29udHJvbGxl ciB7CgkJCWludGVycnVwdC1jb250cm9sbGVyOwoJCQkjYWRkcmVzcy1jZWxscyA9IDwwPjsKCQkJ I2ludGVycnVwdC1jZWxscyA9IDwxPjsKCQl9OwoJfTsKCglnbWFjOiBldGhlcm5ldEBmZTMwMDAw MCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktZ21hYyI7CgkJcmVnID0gPDB4MCAw eGZlMzAwMDAwIDB4MCAweDEwMDAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTIgSVJRX1RZ UEVfTEVWRUxfSElHSCAwPjsKCQlpbnRlcnJ1cHQtbmFtZXMgPSAibWFjaXJxIjsKCQljbG9ja3Mg PSA8JmNydSBTQ0xLX01BQz4sIDwmY3J1IFNDTEtfTUFDX1JYPiwKCQkJIDwmY3J1IFNDTEtfTUFD X1RYPiwgPCZjcnUgU0NMS19NQUNSRUY+LAoJCQkgPCZjcnUgU0NMS19NQUNSRUZfT1VUPiwgPCZj cnUgQUNMS19HTUFDPiwKCQkJIDwmY3J1IFBDTEtfR01BQz47CgkJY2xvY2stbmFtZXMgPSAic3Rt bWFjZXRoIiwgIm1hY19jbGtfcngiLAoJCQkgICAgICAibWFjX2Nsa190eCIsICJjbGtfbWFjX3Jl ZiIsCgkJCSAgICAgICJjbGtfbWFjX3JlZm91dCIsICJhY2xrX21hYyIsCgkJCSAgICAgICJwY2xr X21hYyI7CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX0dNQUM+OwoJCXJlc2V0 cyA9IDwmY3J1IFNSU1RfQV9HTUFDPjsKCQlyZXNldC1uYW1lcyA9ICJzdG1tYWNldGgiOwoJCXJv Y2tjaGlwLGdyZiA9IDwmZ3JmPjsKCQlzbnBzLHR4cGJsID0gPDB4ND47CgkJc3RhdHVzID0gImRp c2FibGVkIjsKCX07CgoJc2RpbzA6IG1tY0BmZTMxMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2Nr Y2hpcCxyazMzOTktZHctbXNoYyIsCgkJCSAgICAgInJvY2tjaGlwLHJrMzI4OC1kdy1tc2hjIjsK CQlyZWcgPSA8MHgwIDB4ZmUzMTAwMDAgMHgwIDB4NDAwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNf U1BJIDY0IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJbWF4LWZyZXF1ZW5jeSA9IDwxNTAwMDAw MDA+OwoJCWNsb2NrcyA9IDwmY3J1IEhDTEtfU0RJTz4sIDwmY3J1IFNDTEtfU0RJTz4sCgkJCSA8 JmNydSBTQ0xLX1NESU9fRFJWPiwgPCZjcnUgU0NMS19TRElPX1NBTVBMRT47CgkJY2xvY2stbmFt ZXMgPSAiYml1IiwgImNpdSIsICJjaXUtZHJpdmUiLCAiY2l1LXNhbXBsZSI7CgkJZmlmby1kZXB0 aCA9IDwweDEwMD47CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX1NESU9BVURJ Tz47CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9TRElPMD47CgkJcmVzZXQtbmFtZXMgPSAicmVzZXQi OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCXNkbW1jOiBtbWNAZmUzMjAwMDAgewoJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LWR3LW1zaGMiLAoJCQkgICAgICJyb2NrY2hpcCxy azMyODgtZHctbXNoYyI7CgkJcmVnID0gPDB4MCAweGZlMzIwMDAwIDB4MCAweDQwMDA+OwoJCWlu dGVycnVwdHMgPSA8R0lDX1NQSSA2NSBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJCW1heC1mcmVx dWVuY3kgPSA8MTUwMDAwMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBIQ0xLX1NEPjsK CQlhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDwyMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmY3J1IEhD TEtfU0RNTUM+LCA8JmNydSBTQ0xLX1NETU1DPiwKCQkJIDwmY3J1IFNDTEtfU0RNTUNfRFJWPiwg PCZjcnUgU0NMS19TRE1NQ19TQU1QTEU+OwoJCWNsb2NrLW5hbWVzID0gImJpdSIsICJjaXUiLCAi Y2l1LWRyaXZlIiwgImNpdS1zYW1wbGUiOwoJCWZpZm8tZGVwdGggPSA8MHgxMDA+OwoJCXBvd2Vy LWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9TRD47CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9T RE1NQz47CgkJcmVzZXQtbmFtZXMgPSAicmVzZXQiOwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9 OwoKCXNkaGNpOiBtbWNAZmUzMzAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5 LXNkaGNpLTUuMSIsICJhcmFzYW4sc2RoY2ktNS4xIjsKCQlyZWcgPSA8MHgwIDB4ZmUzMzAwMDAg MHgwIDB4MTAwMDA+OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMSBJUlFfVFlQRV9MRVZFTF9I SUdIIDA+OwoJCWFyYXNhbixzb2MtY3RsLXN5c2NvbiA9IDwmZ3JmPjsKCQlhc3NpZ25lZC1jbG9j a3MgPSA8JmNydSBTQ0xLX0VNTUM+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIwMDAwMDAw MD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19FTU1DPiwgPCZjcnUgQUNMS19FTU1DPjsKCQljbG9j ay1uYW1lcyA9ICJjbGtfeGluIiwgImNsa19haGIiOwoJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJl bW1jX2NhcmRjbG9jayI7CgkJI2Nsb2NrLWNlbGxzID0gPDA+OwoJCXBoeXMgPSA8JmVtbWNfcGh5 PjsKCQlwaHktbmFtZXMgPSAicGh5X2FyYXNhbiI7CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIg UkszMzk5X1BEX0VNTUM+OwoJCWRpc2FibGUtY3FlLWRjbWQ7CgkJc3RhdHVzID0gImRpc2FibGVk IjsKCX07CgoJdXNiX2hvc3QwX2VoY2k6IHVzYkBmZTM4MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJn ZW5lcmljLWVoY2kiOwoJCXJlZyA9IDwweDAgMHhmZTM4MDAwMCAweDAgMHgyMDAwMD47CgkJaW50 ZXJydXB0cyA9IDxHSUNfU1BJIDI2IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJY2xvY2tzID0g PCZjcnUgSENMS19IT1NUMD4sIDwmY3J1IEhDTEtfSE9TVDBfQVJCPiwKCQkJIDwmdTJwaHkwPjsK CQlwaHlzID0gPCZ1MnBoeTBfaG9zdD47CgkJcGh5LW5hbWVzID0gInVzYiI7CgkJc3RhdHVzID0g ImRpc2FibGVkIjsKCX07CgoJdXNiX2hvc3QwX29oY2k6IHVzYkBmZTNhMDAwMCB7CgkJY29tcGF0 aWJsZSA9ICJnZW5lcmljLW9oY2kiOwoJCXJlZyA9IDwweDAgMHhmZTNhMDAwMCAweDAgMHgyMDAw MD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDI4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJ Y2xvY2tzID0gPCZjcnUgSENMS19IT1NUMD4sIDwmY3J1IEhDTEtfSE9TVDBfQVJCPiwKCQkJIDwm dTJwaHkwPjsKCQlwaHlzID0gPCZ1MnBoeTBfaG9zdD47CgkJcGh5LW5hbWVzID0gInVzYiI7CgkJ c3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJdXNiX2hvc3QxX2VoY2k6IHVzYkBmZTNjMDAwMCB7 CgkJY29tcGF0aWJsZSA9ICJnZW5lcmljLWVoY2kiOwoJCXJlZyA9IDwweDAgMHhmZTNjMDAwMCAw eDAgMHgyMDAwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDMwIElSUV9UWVBFX0xFVkVMX0hJ R0ggMD47CgkJY2xvY2tzID0gPCZjcnUgSENMS19IT1NUMT4sIDwmY3J1IEhDTEtfSE9TVDFfQVJC PiwKCQkJIDwmdTJwaHkxPjsKCQlwaHlzID0gPCZ1MnBoeTFfaG9zdD47CgkJcGh5LW5hbWVzID0g InVzYiI7CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJdXNiX2hvc3QxX29oY2k6IHVzYkBm ZTNlMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJnZW5lcmljLW9oY2kiOwoJCXJlZyA9IDwweDAgMHhm ZTNlMDAwMCAweDAgMHgyMDAwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDMyIElSUV9UWVBF X0xFVkVMX0hJR0ggMD47CgkJY2xvY2tzID0gPCZjcnUgSENMS19IT1NUMT4sIDwmY3J1IEhDTEtf SE9TVDFfQVJCPiwKCQkJIDwmdTJwaHkxPjsKCQlwaHlzID0gPCZ1MnBoeTFfaG9zdD47CgkJcGh5 LW5hbWVzID0gInVzYiI7CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJdXNiZHJkM18wOiB1 c2JAZmU4MDAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LWR3YzMiOwoJCSNh ZGRyZXNzLWNlbGxzID0gPDI+OwoJCSNzaXplLWNlbGxzID0gPDI+OwoJCXJhbmdlczsKCQljbG9j a3MgPSA8JmNydSBTQ0xLX1VTQjNPVEcwX1JFRj4sIDwmY3J1IFNDTEtfVVNCM09URzBfU1VTUEVO RD4sCgkJCSA8JmNydSBBQ0xLX1VTQjNPVEcwPiwgPCZjcnUgQUNMS19VU0IzX1JLU09DX0FYSV9Q RVJGPiwKCQkJIDwmY3J1IEFDTEtfVVNCMz4sIDwmY3J1IEFDTEtfVVNCM19HUkY+OwoJCWNsb2Nr LW5hbWVzID0gInJlZl9jbGsiLCAic3VzcGVuZF9jbGsiLAoJCQkgICAgICAiYnVzX2NsayIsICJh Y2xrX3VzYjNfcmtzb2NfYXhpX3BlcmYiLAoJCQkgICAgICAiYWNsa191c2IzIiwgImdyZl9jbGsi OwoJCXJlc2V0cyA9IDwmY3J1IFNSU1RfQV9VU0IzX09URzA+OwoJCXJlc2V0LW5hbWVzID0gInVz YjMtb3RnIjsKCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoKCQl1c2JkcmRfZHdjM18wOiB1c2JAZmU4 MDAwMDAgewoJCQljb21wYXRpYmxlID0gInNucHMsZHdjMyI7CgkJCXJlZyA9IDwweDAgMHhmZTgw MDAwMCAweDAgMHgxMDAwMDA+OwoJCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTA1IElSUV9UWVBF X0xFVkVMX0hJR0ggMD47CgkJCWNsb2NrcyA9IDwmY3J1IFNDTEtfVVNCM09URzBfUkVGPiwgPCZj cnUgQUNMS19VU0IzT1RHMD4sCgkJCQkgPCZjcnUgU0NMS19VU0IzT1RHMF9TVVNQRU5EPjsKCQkJ Y2xvY2stbmFtZXMgPSAicmVmIiwgImJ1c19lYXJseSIsICJzdXNwZW5kIjsKCQkJZHJfbW9kZSA9 ICJvdGciOwoJCQlwaHlzID0gPCZ1MnBoeTBfb3RnPiwgPCZ0Y3BoeTBfdXNiMz47CgkJCXBoeS1u YW1lcyA9ICJ1c2IyLXBoeSIsICJ1c2IzLXBoeSI7CgkJCXBoeV90eXBlID0gInV0bWlfd2lkZSI7 CgkJCXNucHMsZGlzX2VuYmxzbHBtX3F1aXJrOwoJCQlzbnBzLGRpcy11Mi1mcmVlY2xrLWV4aXN0 cy1xdWlyazsKCQkJc25wcyxkaXNfdTJfc3VzcGh5X3F1aXJrOwoJCQlzbnBzLGRpcy1kZWwtcGh5 LXBvd2VyLWNoZy1xdWlyazsKCQkJc25wcyxkaXMtdHgtaXBnYXAtbGluZWNoZWNrLXF1aXJrOwoJ CQlwb3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfVVNCMz47CgkJCXN0YXR1cyA9ICJk aXNhYmxlZCI7CgkJfTsKCX07CgoJdXNiZHJkM18xOiB1c2JAZmU5MDAwMDAgewoJCWNvbXBhdGli bGUgPSAicm9ja2NoaXAscmszMzk5LWR3YzMiOwoJCSNhZGRyZXNzLWNlbGxzID0gPDI+OwoJCSNz aXplLWNlbGxzID0gPDI+OwoJCXJhbmdlczsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VTQjNPVEcx X1JFRj4sIDwmY3J1IFNDTEtfVVNCM09URzFfU1VTUEVORD4sCgkJCSA8JmNydSBBQ0xLX1VTQjNP VEcxPiwgPCZjcnUgQUNMS19VU0IzX1JLU09DX0FYSV9QRVJGPiwKCQkJIDwmY3J1IEFDTEtfVVNC Mz4sIDwmY3J1IEFDTEtfVVNCM19HUkY+OwoJCWNsb2NrLW5hbWVzID0gInJlZl9jbGsiLCAic3Vz cGVuZF9jbGsiLAoJCQkgICAgICAiYnVzX2NsayIsICJhY2xrX3VzYjNfcmtzb2NfYXhpX3BlcmYi LAoJCQkgICAgICAiYWNsa191c2IzIiwgImdyZl9jbGsiOwoJCXJlc2V0cyA9IDwmY3J1IFNSU1Rf QV9VU0IzX09URzE+OwoJCXJlc2V0LW5hbWVzID0gInVzYjMtb3RnIjsKCQlzdGF0dXMgPSAiZGlz YWJsZWQiOwoKCQl1c2JkcmRfZHdjM18xOiB1c2JAZmU5MDAwMDAgewoJCQljb21wYXRpYmxlID0g InNucHMsZHdjMyI7CgkJCXJlZyA9IDwweDAgMHhmZTkwMDAwMCAweDAgMHgxMDAwMDA+OwoJCQlp bnRlcnJ1cHRzID0gPEdJQ19TUEkgMTEwIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJCWNsb2Nr cyA9IDwmY3J1IFNDTEtfVVNCM09URzFfUkVGPiwgPCZjcnUgQUNMS19VU0IzT1RHMT4sCgkJCQkg PCZjcnUgU0NMS19VU0IzT1RHMV9TVVNQRU5EPjsKCQkJY2xvY2stbmFtZXMgPSAicmVmIiwgImJ1 c19lYXJseSIsICJzdXNwZW5kIjsKCQkJZHJfbW9kZSA9ICJvdGciOwoJCQlwaHlzID0gPCZ1MnBo eTFfb3RnPiwgPCZ0Y3BoeTFfdXNiMz47CgkJCXBoeS1uYW1lcyA9ICJ1c2IyLXBoeSIsICJ1c2Iz LXBoeSI7CgkJCXBoeV90eXBlID0gInV0bWlfd2lkZSI7CgkJCXNucHMsZGlzX2VuYmxzbHBtX3F1 aXJrOwoJCQlzbnBzLGRpcy11Mi1mcmVlY2xrLWV4aXN0cy1xdWlyazsKCQkJc25wcyxkaXNfdTJf c3VzcGh5X3F1aXJrOwoJCQlzbnBzLGRpcy1kZWwtcGh5LXBvd2VyLWNoZy1xdWlyazsKCQkJc25w cyxkaXMtdHgtaXBnYXAtbGluZWNoZWNrLXF1aXJrOwoJCQlwb3dlci1kb21haW5zID0gPCZwb3dl ciBSSzMzOTlfUERfVVNCMz47CgkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgkJfTsKCX07CgoJY2Ru X2RwOiBkcEBmZWMwMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktY2RuLWRw IjsKCQlyZWcgPSA8MHgwIDB4ZmVjMDAwMDAgMHgwIDB4MTAwMDAwPjsKCQlpbnRlcnJ1cHRzID0g PEdJQ19TUEkgOSBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJCWFzc2lnbmVkLWNsb2NrcyA9IDwm Y3J1IFNDTEtfRFBfQ09SRT4sIDwmY3J1IFNDTEtfU1BESUZfUkVDX0RQVFg+OwoJCWFzc2lnbmVk LWNsb2NrLXJhdGVzID0gPDEwMDAwMDAwMD4sIDwyMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmY3J1 IFNDTEtfRFBfQ09SRT4sIDwmY3J1IFBDTEtfRFBfQ1RSTD4sCgkJCSA8JmNydSBTQ0xLX1NQRElG X1JFQ19EUFRYPiwgPCZjcnUgUENMS19WSU9fR1JGPjsKCQljbG9jay1uYW1lcyA9ICJjb3JlLWNs ayIsICJwY2xrIiwgInNwZGlmIiwgImdyZiI7CgkJcGh5cyA9IDwmdGNwaHkwX2RwPiwgPCZ0Y3Bo eTFfZHA+OwoJCXBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9IRENQPjsKCQlyZXNl dHMgPSA8JmNydSBTUlNUX0RQVFhfU1BESUZfUkVDPiwgPCZjcnUgU1JTVF9QX1VQSFkwX0RQVFg+ LAoJCQkgPCZjcnUgU1JTVF9QX1VQSFkwX0FQQj4sIDwmY3J1IFNSU1RfRFBfQ09SRT47CgkJcmVz ZXQtbmFtZXMgPSAic3BkaWYiLCAiZHB0eCIsICJhcGIiLCAiY29yZSI7CgkJcm9ja2NoaXAsZ3Jm ID0gPCZncmY+OwoJCSNzb3VuZC1kYWktY2VsbHMgPSA8MT47CgkJc3RhdHVzID0gImRpc2FibGVk IjsKCgkJcG9ydHMgewoJCQlkcF9pbjogcG9ydCB7CgkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsK CQkJCSNzaXplLWNlbGxzID0gPDA+OwoKCQkJCWRwX2luX3ZvcGI6IGVuZHBvaW50QDAgewoJCQkJ CXJlZyA9IDwwPjsKCQkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8JnZvcGJfb3V0X2RwPjsKCQkJCX07 CgoJCQkJZHBfaW5fdm9wbDogZW5kcG9pbnRAMSB7CgkJCQkJcmVnID0gPDE+OwoJCQkJCXJlbW90 ZS1lbmRwb2ludCA9IDwmdm9wbF9vdXRfZHA+OwoJCQkJfTsKCQkJfTsKCQl9OwoJfTsKCglnaWM6 IGludGVycnVwdC1jb250cm9sbGVyQGZlZTAwMDAwIHsKCQljb21wYXRpYmxlID0gImFybSxnaWMt djMiOwoJCSNpbnRlcnJ1cHQtY2VsbHMgPSA8ND47CgkJI2FkZHJlc3MtY2VsbHMgPSA8Mj47CgkJ I3NpemUtY2VsbHMgPSA8Mj47CgkJcmFuZ2VzOwoJCWludGVycnVwdC1jb250cm9sbGVyOwoKCQly ZWcgPSA8MHgwIDB4ZmVlMDAwMDAgMCAweDEwMDAwPiwgLyogR0lDRCAqLwoJCSAgICAgIDwweDAg MHhmZWYwMDAwMCAwIDB4YzAwMDA+LCAvKiBHSUNSICovCgkJICAgICAgPDB4MCAweGZmZjAwMDAw IDAgMHgxMDAwMD4sIC8qIEdJQ0MgKi8KCQkgICAgICA8MHgwIDB4ZmZmMTAwMDAgMCAweDEwMDAw PiwgLyogR0lDSCAqLwoJCSAgICAgIDwweDAgMHhmZmYyMDAwMCAwIDB4MTAwMDA+OyAvKiBHSUNW ICovCgkJaW50ZXJydXB0cyA9IDxHSUNfUFBJIDkgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlp dHM6IGludGVycnVwdC1jb250cm9sbGVyQGZlZTIwMDAwIHsKCQkJY29tcGF0aWJsZSA9ICJhcm0s Z2ljLXYzLWl0cyI7CgkJCW1zaS1jb250cm9sbGVyOwoJCQkjbXNpLWNlbGxzID0gPDE+OwoJCQly ZWcgPSA8MHgwIDB4ZmVlMjAwMDAgMHgwIDB4MjAwMDA+OwoJCX07CgoJCXBwaS1wYXJ0aXRpb25z IHsKCQkJcHBpX2NsdXN0ZXIwOiBpbnRlcnJ1cHQtcGFydGl0aW9uLTAgewoJCQkJYWZmaW5pdHkg PSA8JmNwdV9sMCAmY3B1X2wxICZjcHVfbDIgJmNwdV9sMz47CgkJCX07CgoJCQlwcGlfY2x1c3Rl cjE6IGludGVycnVwdC1wYXJ0aXRpb24tMSB7CgkJCQlhZmZpbml0eSA9IDwmY3B1X2IwICZjcHVf YjE+OwoJCQl9OwoJCX07Cgl9OwoKCXNhcmFkYzogc2FyYWRjQGZmMTAwMDAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLHJrMzM5OS1zYXJhZGMiOwoJCXJlZyA9IDwweDAgMHhmZjEwMDAwMCAw eDAgMHgxMDA+OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSA2MiBJUlFfVFlQRV9MRVZFTF9ISUdI IDA+OwoJCSNpby1jaGFubmVsLWNlbGxzID0gPDE+OwoJCWNsb2NrcyA9IDwmY3J1IFNDTEtfU0FS QURDPiwgPCZjcnUgUENMS19TQVJBREM+OwoJCWNsb2NrLW5hbWVzID0gInNhcmFkYyIsICJhcGJf cGNsayI7CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9QX1NBUkFEQz47CgkJcmVzZXQtbmFtZXMgPSAi c2FyYWRjLWFwYiI7CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjMTogaTJjQGZmMTEw MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAg MHhmZjExMDAwMCAweDAgMHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0ky QzE+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIwMDAwMDAwMD47CgkJY2xvY2tzID0gPCZj cnUgU0NMS19JMkMxPiwgPCZjcnUgUENMS19JMkMxPjsKCQljbG9jay1uYW1lcyA9ICJpMmMiLCAi cGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU5IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47 CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzFfeGZlcj47 CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0g ImRpc2FibGVkIjsKCX07CgoJaTJjMjogaTJjQGZmMTIwMDAwIHsKCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjEyMDAwMCAweDAgMHgxMDAwPjsK CQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0kyQzI+OwoJCWFzc2lnbmVkLWNsb2NrLXJh dGVzID0gPDIwMDAwMDAwMD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19JMkMyPiwgPCZjcnUgUENM S19JMkMyPjsKCQljbG9jay1uYW1lcyA9ICJpMmMiLCAicGNsayI7CgkJaW50ZXJydXB0cyA9IDxH SUNfU1BJIDM1IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZh dWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzJfeGZlcj47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47 CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjMzog aTJjQGZmMTMwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJl ZyA9IDwweDAgMHhmZjEzMDAwMCAweDAgMHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNy dSBTQ0xLX0kyQzM+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIwMDAwMDAwMD47CgkJY2xv Y2tzID0gPCZjcnUgU0NMS19JMkMzPiwgPCZjcnUgUENMS19JMkMzPjsKCQljbG9jay1uYW1lcyA9 ICJpMmMiLCAicGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDM0IElSUV9UWVBFX0xFVkVM X0hJR0ggMD47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8Jmky YzNfeGZlcj47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJ c3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjNTogaTJjQGZmMTQwMDAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjE0MDAwMCAweDAg MHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0kyQzU+OwoJCWFzc2lnbmVk LWNsb2NrLXJhdGVzID0gPDIwMDAwMDAwMD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19JMkM1Piwg PCZjcnUgUENMS19JMkM1PjsKCQljbG9jay1uYW1lcyA9ICJpMmMiLCAicGNsayI7CgkJaW50ZXJy dXB0cyA9IDxHSUNfU1BJIDM4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcGluY3RybC1uYW1l cyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzVfeGZlcj47CgkJI2FkZHJlc3MtY2Vs bHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07 CgoJaTJjNjogaTJjQGZmMTUwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1p MmMiOwoJCXJlZyA9IDwweDAgMHhmZjE1MDAwMCAweDAgMHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9j a3MgPSA8JmNydSBTQ0xLX0kyQzY+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIwMDAwMDAw MD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19JMkM2PiwgPCZjcnUgUENMS19JMkM2PjsKCQljbG9j ay1uYW1lcyA9ICJpMmMiLCAicGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDM3IElSUV9U WVBFX0xFVkVMX0hJR0ggMD47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJs LTAgPSA8JmkyYzZfeGZlcj47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMg PSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjNzogaTJjQGZmMTYwMDAwIHsK CQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjE2 MDAwMCAweDAgMHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JmNydSBTQ0xLX0kyQzc+OwoJ CWFzc2lnbmVkLWNsb2NrLXJhdGVzID0gPDIwMDAwMDAwMD47CgkJY2xvY2tzID0gPCZjcnUgU0NM S19JMkM3PiwgPCZjcnUgUENMS19JMkM3PjsKCQljbG9jay1uYW1lcyA9ICJpMmMiLCAicGNsayI7 CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDM2IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcGlu Y3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzdfeGZlcj47CgkJI2Fk ZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0gImRpc2Fi bGVkIjsKCX07CgoJdWFydDA6IHNlcmlhbEBmZjE4MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2Nr Y2hpcCxyazMzOTktdWFydCIsICJzbnBzLGR3LWFwYi11YXJ0IjsKCQlyZWcgPSA8MHgwIDB4ZmYx ODAwMDAgMHgwIDB4MTAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VBUlQwPiwgPCZjcnUgUENM S19VQVJUMD47CgkJY2xvY2stbmFtZXMgPSAiYmF1ZGNsayIsICJhcGJfcGNsayI7CgkJaW50ZXJy dXB0cyA9IDxHSUNfU1BJIDk5IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcmVnLXNoaWZ0ID0g PDI+OwoJCXJlZy1pby13aWR0aCA9IDw0PjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJ CXBpbmN0cmwtMCA9IDwmdWFydDBfeGZlcj47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJ dWFydDE6IHNlcmlhbEBmZjE5MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTkt dWFydCIsICJzbnBzLGR3LWFwYi11YXJ0IjsKCQlyZWcgPSA8MHgwIDB4ZmYxOTAwMDAgMHgwIDB4 MTAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VBUlQxPiwgPCZjcnUgUENMS19VQVJUMT47CgkJ Y2xvY2stbmFtZXMgPSAiYmF1ZGNsayIsICJhcGJfcGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNf U1BJIDk4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcmVnLXNoaWZ0ID0gPDI+OwoJCXJlZy1p by13aWR0aCA9IDw0PjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9 IDwmdWFydDFfeGZlcj47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJdWFydDI6IHNlcmlh bEBmZjFhMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktdWFydCIsICJzbnBz LGR3LWFwYi11YXJ0IjsKCQlyZWcgPSA8MHgwIDB4ZmYxYTAwMDAgMHgwIDB4MTAwPjsKCQljbG9j a3MgPSA8JmNydSBTQ0xLX1VBUlQyPiwgPCZjcnUgUENMS19VQVJUMj47CgkJY2xvY2stbmFtZXMg PSAiYmF1ZGNsayIsICJhcGJfcGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDEwMCBJUlFf VFlQRV9MRVZFTF9ISUdIIDA+OwoJCXJlZy1zaGlmdCA9IDwyPjsKCQlyZWctaW8td2lkdGggPSA8 ND47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JnVhcnQyY194 ZmVyPjsKCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoJfTsKCgl1YXJ0Mzogc2VyaWFsQGZmMWIwMDAw IHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS11YXJ0IiwgInNucHMsZHctYXBiLXVh cnQiOwoJCXJlZyA9IDwweDAgMHhmZjFiMDAwMCAweDAgMHgxMDA+OwoJCWNsb2NrcyA9IDwmY3J1 IFNDTEtfVUFSVDM+LCA8JmNydSBQQ0xLX1VBUlQzPjsKCQljbG9jay1uYW1lcyA9ICJiYXVkY2xr IiwgImFwYl9wY2xrIjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTAxIElSUV9UWVBFX0xFVkVM X0hJR0ggMD47CgkJcmVnLXNoaWZ0ID0gPDI+OwoJCXJlZy1pby13aWR0aCA9IDw0PjsKCQlwaW5j dHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmdWFydDNfeGZlcj47CgkJc3Rh dHVzID0gImRpc2FibGVkIjsKCX07CgoJc3BpMDogc3BpQGZmMWMwMDAwIHsKCQljb21wYXRpYmxl ID0gInJvY2tjaGlwLHJrMzM5OS1zcGkiLCAicm9ja2NoaXAscmszMDY2LXNwaSI7CgkJcmVnID0g PDB4MCAweGZmMWMwMDAwIDB4MCAweDEwMDA+OwoJCWNsb2NrcyA9IDwmY3J1IFNDTEtfU1BJMD4s IDwmY3J1IFBDTEtfU1BJMD47CgkJY2xvY2stbmFtZXMgPSAic3BpY2xrIiwgImFwYl9wY2xrIjsK CQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgNjggSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlkbWFz ID0gPCZkbWFjX3BlcmkgMTA+LCA8JmRtYWNfcGVyaSAxMT47CgkJZG1hLW5hbWVzID0gInR4Iiwg InJ4IjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmc3BpMF9j bGsgJnNwaTBfdHggJnNwaTBfcnggJnNwaTBfY3MwPjsKCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsK CQkjc2l6ZS1jZWxscyA9IDwwPjsKCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoJfTsKCglzcGkxOiBz cGlAZmYxZDAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXNwaSIsICJyb2Nr Y2hpcCxyazMwNjYtc3BpIjsKCQlyZWcgPSA8MHgwIDB4ZmYxZDAwMDAgMHgwIDB4MTAwMD47CgkJ Y2xvY2tzID0gPCZjcnUgU0NMS19TUEkxPiwgPCZjcnUgUENMS19TUEkxPjsKCQljbG9jay1uYW1l cyA9ICJzcGljbGsiLCAiYXBiX3BjbGsiOwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSA1MyBJUlFf VFlQRV9MRVZFTF9ISUdIIDA+OwoJCWRtYXMgPSA8JmRtYWNfcGVyaSAxMj4sIDwmZG1hY19wZXJp IDEzPjsKCQlkbWEtbmFtZXMgPSAidHgiLCAicngiOwoJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVs dCI7CgkJcGluY3RybC0wID0gPCZzcGkxX2NsayAmc3BpMV90eCAmc3BpMV9yeCAmc3BpMV9jczA+ OwoJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCSNzaXplLWNlbGxzID0gPDA+OwoJCXN0YXR1cyA9 ICJkaXNhYmxlZCI7Cgl9OwoKCXNwaTI6IHNwaUBmZjFlMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJy b2NrY2hpcCxyazMzOTktc3BpIiwgInJvY2tjaGlwLHJrMzA2Ni1zcGkiOwoJCXJlZyA9IDwweDAg MHhmZjFlMDAwMCAweDAgMHgxMDAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1NQSTI+LCA8JmNy dSBQQ0xLX1NQSTI+OwoJCWNsb2NrLW5hbWVzID0gInNwaWNsayIsICJhcGJfcGNsayI7CgkJaW50 ZXJydXB0cyA9IDxHSUNfU1BJIDUyIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJZG1hcyA9IDwm ZG1hY19wZXJpIDE0PiwgPCZkbWFjX3BlcmkgMTU+OwoJCWRtYS1uYW1lcyA9ICJ0eCIsICJyeCI7 CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JnNwaTJfY2xrICZz cGkyX3R4ICZzcGkyX3J4ICZzcGkyX2NzMD47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3Np emUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJc3BpNDogc3BpQGZm MWYwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1zcGkiLCAicm9ja2NoaXAs cmszMDY2LXNwaSI7CgkJcmVnID0gPDB4MCAweGZmMWYwMDAwIDB4MCAweDEwMDA+OwoJCWNsb2Nr cyA9IDwmY3J1IFNDTEtfU1BJND4sIDwmY3J1IFBDTEtfU1BJND47CgkJY2xvY2stbmFtZXMgPSAi c3BpY2xrIiwgImFwYl9wY2xrIjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgNjcgSVJRX1RZUEVf TEVWRUxfSElHSCAwPjsKCQlkbWFzID0gPCZkbWFjX3BlcmkgMTg+LCA8JmRtYWNfcGVyaSAxOT47 CgkJZG1hLW5hbWVzID0gInR4IiwgInJ4IjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJ CXBpbmN0cmwtMCA9IDwmc3BpNF9jbGsgJnNwaTRfdHggJnNwaTRfcnggJnNwaTRfY3MwPjsKCQkj YWRkcmVzcy1jZWxscyA9IDwxPjsKCQkjc2l6ZS1jZWxscyA9IDwwPjsKCQlzdGF0dXMgPSAiZGlz YWJsZWQiOwoJfTsKCglzcGk1OiBzcGlAZmYyMDAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2No aXAscmszMzk5LXNwaSIsICJyb2NrY2hpcCxyazMwNjYtc3BpIjsKCQlyZWcgPSA8MHgwIDB4ZmYy MDAwMDAgMHgwIDB4MTAwMD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19TUEk1PiwgPCZjcnUgUENM S19TUEk1PjsKCQljbG9jay1uYW1lcyA9ICJzcGljbGsiLCAiYXBiX3BjbGsiOwoJCWludGVycnVw dHMgPSA8R0lDX1NQSSAxMzIgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlkbWFzID0gPCZkbWFj X2J1cyA4PiwgPCZkbWFjX2J1cyA5PjsKCQlkbWEtbmFtZXMgPSAidHgiLCAicngiOwoJCXBpbmN0 cmwtbmFtZXMgPSAiZGVmYXVsdCI7CgkJcGluY3RybC0wID0gPCZzcGk1X2NsayAmc3BpNV90eCAm c3BpNV9yeCAmc3BpNV9jczA+OwoJCXBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9T RElPQVVESU8+OwoJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCSNzaXplLWNlbGxzID0gPDA+OwoJ CXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCXRoZXJtYWxfem9uZXM6IHRoZXJtYWwtem9uZXMg ewoJCWNwdV90aGVybWFsOiBjcHUtdGhlcm1hbCB7CgkJCXBvbGxpbmctZGVsYXktcGFzc2l2ZSA9 IDwxMDA+OwoJCQlwb2xsaW5nLWRlbGF5ID0gPDEwMDA+OwoKCQkJdGhlcm1hbC1zZW5zb3JzID0g PCZ0c2FkYyAwPjsKCgkJCXRyaXBzIHsKCQkJCWNwdV9hbGVydDA6IGNwdV9hbGVydDAgewoJCQkJ CXRlbXBlcmF0dXJlID0gPDcwMDAwPjsKCQkJCQloeXN0ZXJlc2lzID0gPDIwMDA+OwoJCQkJCXR5 cGUgPSAicGFzc2l2ZSI7CgkJCQl9OwoJCQkJY3B1X2FsZXJ0MTogY3B1X2FsZXJ0MSB7CgkJCQkJ dGVtcGVyYXR1cmUgPSA8NzUwMDA+OwoJCQkJCWh5c3RlcmVzaXMgPSA8MjAwMD47CgkJCQkJdHlw ZSA9ICJwYXNzaXZlIjsKCQkJCX07CgkJCQljcHVfY3JpdDogY3B1X2NyaXQgewoJCQkJCXRlbXBl cmF0dXJlID0gPDk1MDAwPjsKCQkJCQloeXN0ZXJlc2lzID0gPDIwMDA+OwoJCQkJCXR5cGUgPSAi Y3JpdGljYWwiOwoJCQkJfTsKCQkJfTsKCgkJCWNvb2xpbmctbWFwcyB7CgkJCQltYXAwIHsKCQkJ CQl0cmlwID0gPCZjcHVfYWxlcnQwPjsKCQkJCQljb29saW5nLWRldmljZSA9CgkJCQkJCTwmY3B1 X2IwIFRIRVJNQUxfTk9fTElNSVQgVEhFUk1BTF9OT19MSU1JVD4sCgkJCQkJCTwmY3B1X2IxIFRI RVJNQUxfTk9fTElNSVQgVEhFUk1BTF9OT19MSU1JVD47CgkJCQl9OwoJCQkJbWFwMSB7CgkJCQkJ dHJpcCA9IDwmY3B1X2FsZXJ0MT47CgkJCQkJY29vbGluZy1kZXZpY2UgPQoJCQkJCQk8JmNwdV9s MCBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElNSVQ+LAoJCQkJCQk8JmNwdV9sMSBUSEVS TUFMX05PX0xJTUlUIFRIRVJNQUxfTk9fTElNSVQ+LAoJCQkJCQk8JmNwdV9sMiBUSEVSTUFMX05P X0xJTUlUIFRIRVJNQUxfTk9fTElNSVQ+LAoJCQkJCQk8JmNwdV9sMyBUSEVSTUFMX05PX0xJTUlU IFRIRVJNQUxfTk9fTElNSVQ+LAoJCQkJCQk8JmNwdV9iMCBUSEVSTUFMX05PX0xJTUlUIFRIRVJN QUxfTk9fTElNSVQ+LAoJCQkJCQk8JmNwdV9iMSBUSEVSTUFMX05PX0xJTUlUIFRIRVJNQUxfTk9f TElNSVQ+OwoJCQkJfTsKCQkJfTsKCQl9OwoKCQlncHVfdGhlcm1hbDogZ3B1LXRoZXJtYWwgewoJ CQlwb2xsaW5nLWRlbGF5LXBhc3NpdmUgPSA8MTAwPjsKCQkJcG9sbGluZy1kZWxheSA9IDwxMDAw PjsKCgkJCXRoZXJtYWwtc2Vuc29ycyA9IDwmdHNhZGMgMT47CgoJCQl0cmlwcyB7CgkJCQlncHVf YWxlcnQwOiBncHVfYWxlcnQwIHsKCQkJCQl0ZW1wZXJhdHVyZSA9IDw3NTAwMD47CgkJCQkJaHlz dGVyZXNpcyA9IDwyMDAwPjsKCQkJCQl0eXBlID0gInBhc3NpdmUiOwoJCQkJfTsKCQkJCWdwdV9j cml0OiBncHVfY3JpdCB7CgkJCQkJdGVtcGVyYXR1cmUgPSA8OTUwMDA+OwoJCQkJCWh5c3RlcmVz aXMgPSA8MjAwMD47CgkJCQkJdHlwZSA9ICJjcml0aWNhbCI7CgkJCQl9OwoJCQl9OwoKCQkJY29v bGluZy1tYXBzIHsKCQkJCW1hcDAgewoJCQkJCXRyaXAgPSA8JmdwdV9hbGVydDA+OwoJCQkJCWNv b2xpbmctZGV2aWNlID0KCQkJCQkJPCZncHUgVEhFUk1BTF9OT19MSU1JVCBUSEVSTUFMX05PX0xJ TUlUPjsKCQkJCX07CgkJCX07CgkJfTsKCX07CgoJdHNhZGM6IHRzYWRjQGZmMjYwMDAwIHsKCQlj b21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS10c2FkYyI7CgkJcmVnID0gPDB4MCAweGZmMjYw MDAwIDB4MCAweDEwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDk3IElSUV9UWVBFX0xFVkVM X0hJR0ggMD47CgkJYXNzaWduZWQtY2xvY2tzID0gPCZjcnUgU0NMS19UU0FEQz47CgkJYXNzaWdu ZWQtY2xvY2stcmF0ZXMgPSA8NzUwMDAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1RTQURDPiwg PCZjcnUgUENMS19UU0FEQz47CgkJY2xvY2stbmFtZXMgPSAidHNhZGMiLCAiYXBiX3BjbGsiOwoJ CXJlc2V0cyA9IDwmY3J1IFNSU1RfVFNBREM+OwoJCXJlc2V0LW5hbWVzID0gInRzYWRjLWFwYiI7 CgkJcm9ja2NoaXAsZ3JmID0gPCZncmY+OwoJCXJvY2tjaGlwLGh3LXRzaHV0LXRlbXAgPSA8OTUw MDA+OwoJCXBpbmN0cmwtbmFtZXMgPSAiaW5pdCIsICJkZWZhdWx0IiwgInNsZWVwIjsKCQlwaW5j dHJsLTAgPSA8Jm90cF9waW4+OwoJCXBpbmN0cmwtMSA9IDwmb3RwX291dD47CgkJcGluY3RybC0y ID0gPCZvdHBfcGluPjsKCQkjdGhlcm1hbC1zZW5zb3ItY2VsbHMgPSA8MT47CgkJc3RhdHVzID0g ImRpc2FibGVkIjsKCX07CgoJcW9zX2VtbWM6IHFvc0BmZmE1ODAwMCB7CgkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVnID0gPDB4MCAweGZmYTU4MDAw IDB4MCAweDIwPjsKCX07CgoJcW9zX2dtYWM6IHFvc0BmZmE1YzAwMCB7CgkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVnID0gPDB4MCAweGZmYTVjMDAw IDB4MCAweDIwPjsKCX07CgoJcW9zX3BjaWU6IHFvc0BmZmE2MDA4MCB7CgkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVnID0gPDB4MCAweGZmYTYwMDgw IDB4MCAweDIwPjsKCX07CgoJcW9zX3VzYl9ob3N0MDogcW9zQGZmYTYwMTAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZh NjAxMDAgMHgwIDB4MjA+OwoJfTsKCglxb3NfdXNiX2hvc3QxOiBxb3NAZmZhNjAxODAgewoJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXFvcyIsICJzeXNjb24iOwoJCXJlZyA9IDwweDAg MHhmZmE2MDE4MCAweDAgMHgyMD47Cgl9OwoKCXFvc191c2Jfb3RnMDogcW9zQGZmYTcwMDAwIHsK CQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsKCQlyZWcgPSA8 MHgwIDB4ZmZhNzAwMDAgMHgwIDB4MjA+OwoJfTsKCglxb3NfdXNiX290ZzE6IHFvc0BmZmE3MDA4 MCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVn ID0gPDB4MCAweGZmYTcwMDgwIDB4MCAweDIwPjsKCX07CgoJcW9zX3NkOiBxb3NAZmZhNzQwMDAg ewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXFvcyIsICJzeXNjb24iOwoJCXJlZyA9 IDwweDAgMHhmZmE3NDAwMCAweDAgMHgyMD47Cgl9OwoKCXFvc19zZGlvYXVkaW86IHFvc0BmZmE3 NjAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJ cmVnID0gPDB4MCAweGZmYTc2MDAwIDB4MCAweDIwPjsKCX07CgoJcW9zX2hkY3A6IHFvc0BmZmE5 MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJ cmVnID0gPDB4MCAweGZmYTkwMDAwIDB4MCAweDIwPjsKCX07CgoJcW9zX2llcDogcW9zQGZmYTk4 MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsKCQly ZWcgPSA8MHgwIDB4ZmZhOTgwMDAgMHgwIDB4MjA+OwoJfTsKCglxb3NfaXNwMF9tMDogcW9zQGZm YWEwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsK CQlyZWcgPSA8MHgwIDB4ZmZhYTAwMDAgMHgwIDB4MjA+OwoJfTsKCglxb3NfaXNwMF9tMTogcW9z QGZmYWEwMDgwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29u IjsKCQlyZWcgPSA8MHgwIDB4ZmZhYTAwODAgMHgwIDB4MjA+OwoJfTsKCglxb3NfaXNwMV9tMDog cW9zQGZmYWE4MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lz Y29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZhYTgwMDAgMHgwIDB4MjA+OwoJfTsKCglxb3NfaXNwMV9t MTogcW9zQGZmYWE4MDgwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAi c3lzY29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZhYTgwODAgMHgwIDB4MjA+OwoJfTsKCglxb3Nfcmdh X3I6IHFvc0BmZmFiMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwg InN5c2NvbiI7CgkJcmVnID0gPDB4MCAweGZmYWIwMDAwIDB4MCAweDIwPjsKCX07CgoJcW9zX3Jn YV93OiBxb3NAZmZhYjAwODAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXFvcyIs ICJzeXNjb24iOwoJCXJlZyA9IDwweDAgMHhmZmFiMDA4MCAweDAgMHgyMD47Cgl9OwoKCXFvc192 aWRlb19tMDogcW9zQGZmYWI4MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1x b3MiLCAic3lzY29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZhYjgwMDAgMHgwIDB4MjA+OwoJfTsKCglx b3NfdmlkZW9fbTFfcjogcW9zQGZmYWMwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJr MzM5OS1xb3MiLCAic3lzY29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZhYzAwMDAgMHgwIDB4MjA+OwoJ fTsKCglxb3NfdmlkZW9fbTFfdzogcW9zQGZmYWMwMDgwIHsKCQljb21wYXRpYmxlID0gInJvY2tj aGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsKCQlyZWcgPSA8MHgwIDB4ZmZhYzAwODAgMHgwIDB4 MjA+OwoJfTsKCglxb3Nfdm9wX2JpZ19yOiBxb3NAZmZhYzgwMDAgewoJCWNvbXBhdGlibGUgPSAi cm9ja2NoaXAscmszMzk5LXFvcyIsICJzeXNjb24iOwoJCXJlZyA9IDwweDAgMHhmZmFjODAwMCAw eDAgMHgyMD47Cgl9OwoKCXFvc192b3BfYmlnX3c6IHFvc0BmZmFjODA4MCB7CgkJY29tcGF0aWJs ZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVnID0gPDB4MCAweGZmYWM4 MDgwIDB4MCAweDIwPjsKCX07CgoJcW9zX3ZvcF9saXR0bGU6IHFvc0BmZmFkMDAwMCB7CgkJY29t cGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcW9zIiwgInN5c2NvbiI7CgkJcmVnID0gPDB4MCAw eGZmYWQwMDAwIDB4MCAweDIwPjsKCX07CgoJcW9zX3BlcmlocDogcW9zQGZmYWQ4MDgwIHsKCQlj b21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1xb3MiLCAic3lzY29uIjsKCQlyZWcgPSA8MHgw IDB4ZmZhZDgwODAgMHgwIDB4MjA+OwoJfTsKCglxb3NfZ3B1OiBxb3NAZmZhZTAwMDAgewoJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXFvcyIsICJzeXNjb24iOwoJCXJlZyA9IDwweDAg MHhmZmFlMDAwMCAweDAgMHgyMD47Cgl9OwoKCXBtdTogcG93ZXItbWFuYWdlbWVudEBmZjMxMDAw MCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcG11IiwgInN5c2NvbiIsICJzaW1w bGUtbWZkIjsKCQlyZWcgPSA8MHgwIDB4ZmYzMTAwMDAgMHgwIDB4MTAwMD47CgoJCS8qCgkJICog Tm90ZTogUkszMzk5IHN1cHBvcnRzIDYgdm9sdGFnZSBkb21haW5zIGluY2x1ZGluZyBWRF9DT1JF X0wsCgkJICogVkRfQ09SRV9CLCBWRF9DRU5URVIsIFZEX0dQVSwgVkRfTE9HSUMgYW5kIFZEX1BN VS4KCQkgKiBTb21lIG9mIHRoZSBwb3dlciBkb21haW5zIGFyZSBncm91cGVkIHRvZ2V0aGVyIGZv ciBldmVyeQoJCSAqIHZvbHRhZ2UgZG9tYWluLgoJCSAqIFRoZSBkZXRhaWwgY29udGVudHMgYXMg YmVsb3cuCgkJICovCgkJcG93ZXI6IHBvd2VyLWNvbnRyb2xsZXIgewoJCQljb21wYXRpYmxlID0g InJvY2tjaGlwLHJrMzM5OS1wb3dlci1jb250cm9sbGVyIjsKCQkJI3Bvd2VyLWRvbWFpbi1jZWxs cyA9IDwxPjsKCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJCSNzaXplLWNlbGxzID0gPDA+OwoK CQkJLyogVGhlc2UgcG93ZXIgZG9tYWlucyBhcmUgZ3JvdXBlZCBieSBWRF9DRU5URVIgKi8KCQkJ cG93ZXItZG9tYWluQFJLMzM5OV9QRF9JRVAgewoJCQkJcmVnID0gPFJLMzM5OV9QRF9JRVA+OwoJ CQkJY2xvY2tzID0gPCZjcnUgQUNMS19JRVA+LAoJCQkJCSA8JmNydSBIQ0xLX0lFUD47CgkJCQlw bV9xb3MgPSA8JnFvc19pZXA+OwoJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwwPjsKCQkJfTsK CQkJcG93ZXItZG9tYWluQFJLMzM5OV9QRF9SR0EgewoJCQkJcmVnID0gPFJLMzM5OV9QRF9SR0E+ OwoJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19SR0E+LAoJCQkJCSA8JmNydSBIQ0xLX1JHQT47CgkJ CQlwbV9xb3MgPSA8JnFvc19yZ2Ffcj4sCgkJCQkJIDwmcW9zX3JnYV93PjsKCQkJCSNwb3dlci1k b21haW4tY2VsbHMgPSA8MD47CgkJCX07CgkJCXBvd2VyLWRvbWFpbkBSSzMzOTlfUERfVkNPREVD IHsKCQkJCXJlZyA9IDxSSzMzOTlfUERfVkNPREVDPjsKCQkJCWNsb2NrcyA9IDwmY3J1IEFDTEtf VkNPREVDPiwKCQkJCQkgPCZjcnUgSENMS19WQ09ERUM+OwoJCQkJcG1fcW9zID0gPCZxb3Nfdmlk ZW9fbTA+OwoJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwwPjsKCQkJfTsKCQkJcG93ZXItZG9t YWluQFJLMzM5OV9QRF9WRFUgewoJCQkJcmVnID0gPFJLMzM5OV9QRF9WRFU+OwoJCQkJY2xvY2tz ID0gPCZjcnUgQUNMS19WRFU+LAoJCQkJCSA8JmNydSBIQ0xLX1ZEVT47CgkJCQlwbV9xb3MgPSA8 JnFvc192aWRlb19tMV9yPiwKCQkJCQkgPCZxb3NfdmlkZW9fbTFfdz47CgkJCQkjcG93ZXItZG9t YWluLWNlbGxzID0gPDA+OwoJCQl9OwoKCQkJLyogVGhlc2UgcG93ZXIgZG9tYWlucyBhcmUgZ3Jv dXBlZCBieSBWRF9HUFUgKi8KCQkJcG93ZXItZG9tYWluQFJLMzM5OV9QRF9HUFUgewoJCQkJcmVn ID0gPFJLMzM5OV9QRF9HUFU+OwoJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19HUFU+OwoJCQkJcG1f cW9zID0gPCZxb3NfZ3B1PjsKCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47CgkJCX07CgoJ CQkvKiBUaGVzZSBwb3dlciBkb21haW5zIGFyZSBncm91cGVkIGJ5IFZEX0xPR0lDICovCgkJCXBv d2VyLWRvbWFpbkBSSzMzOTlfUERfRURQIHsKCQkJCXJlZyA9IDxSSzMzOTlfUERfRURQPjsKCQkJ CWNsb2NrcyA9IDwmY3J1IFBDTEtfRURQX0NUUkw+OwoJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9 IDwwPjsKCQkJfTsKCQkJcG93ZXItZG9tYWluQFJLMzM5OV9QRF9FTU1DIHsKCQkJCXJlZyA9IDxS SzMzOTlfUERfRU1NQz47CgkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX0VNTUM+OwoJCQkJcG1fcW9z ID0gPCZxb3NfZW1tYz47CgkJCQkjcG93ZXItZG9tYWluLWNlbGxzID0gPDA+OwoJCQl9OwoJCQlw b3dlci1kb21haW5AUkszMzk5X1BEX0dNQUMgewoJCQkJcmVnID0gPFJLMzM5OV9QRF9HTUFDPjsK CQkJCWNsb2NrcyA9IDwmY3J1IEFDTEtfR01BQz4sCgkJCQkJIDwmY3J1IFBDTEtfR01BQz47CgkJ CQlwbV9xb3MgPSA8JnFvc19nbWFjPjsKCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47CgkJ CX07CgkJCXBvd2VyLWRvbWFpbkBSSzMzOTlfUERfU0QgewoJCQkJcmVnID0gPFJLMzM5OV9QRF9T RD47CgkJCQljbG9ja3MgPSA8JmNydSBIQ0xLX1NETU1DPiwKCQkJCQkgPCZjcnUgU0NMS19TRE1N Qz47CgkJCQlwbV9xb3MgPSA8JnFvc19zZD47CgkJCQkjcG93ZXItZG9tYWluLWNlbGxzID0gPDA+ OwoJCQl9OwoJCQlwb3dlci1kb21haW5AUkszMzk5X1BEX1NESU9BVURJTyB7CgkJCQlyZWcgPSA8 UkszMzk5X1BEX1NESU9BVURJTz47CgkJCQljbG9ja3MgPSA8JmNydSBIQ0xLX1NESU8+OwoJCQkJ cG1fcW9zID0gPCZxb3Nfc2Rpb2F1ZGlvPjsKCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47 CgkJCX07CgkJCXBvd2VyLWRvbWFpbkBSSzMzOTlfUERfVENQRDAgewoJCQkJcmVnID0gPFJLMzM5 OV9QRF9UQ1BEMD47CgkJCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VQSFkwX1RDUERDT1JFPiwKCQkJ CQkgPCZjcnUgU0NMS19VUEhZMF9UQ1BEUEhZX1JFRj47CgkJCQkjcG93ZXItZG9tYWluLWNlbGxz ID0gPDA+OwoJCQl9OwoJCQlwb3dlci1kb21haW5AUkszMzk5X1BEX1RDUEQxIHsKCQkJCXJlZyA9 IDxSSzMzOTlfUERfVENQRDE+OwoJCQkJY2xvY2tzID0gPCZjcnUgU0NMS19VUEhZMV9UQ1BEQ09S RT4sCgkJCQkJIDwmY3J1IFNDTEtfVVBIWTFfVENQRFBIWV9SRUY+OwoJCQkJI3Bvd2VyLWRvbWFp bi1jZWxscyA9IDwwPjsKCQkJfTsKCQkJcG93ZXItZG9tYWluQFJLMzM5OV9QRF9VU0IzIHsKCQkJ CXJlZyA9IDxSSzMzOTlfUERfVVNCMz47CgkJCQljbG9ja3MgPSA8JmNydSBBQ0xLX1VTQjM+OwoJ CQkJcG1fcW9zID0gPCZxb3NfdXNiX290ZzA+LAoJCQkJCSA8JnFvc191c2Jfb3RnMT47CgkJCQkj cG93ZXItZG9tYWluLWNlbGxzID0gPDA+OwoJCQl9OwoJCQlwb3dlci1kb21haW5AUkszMzk5X1BE X1ZJTyB7CgkJCQlyZWcgPSA8UkszMzk5X1BEX1ZJTz47CgkJCQkjcG93ZXItZG9tYWluLWNlbGxz ID0gPDE+OwoJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJCQkjc2l6ZS1jZWxscyA9IDwwPjsK CgkJCQlwb3dlci1kb21haW5AUkszMzk5X1BEX0hEQ1AgewoJCQkJCXJlZyA9IDxSSzMzOTlfUERf SERDUD47CgkJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19IRENQPiwKCQkJCQkJIDwmY3J1IEhDTEtf SERDUD4sCgkJCQkJCSA8JmNydSBQQ0xLX0hEQ1A+OwoJCQkJCXBtX3FvcyA9IDwmcW9zX2hkY3A+ OwoJCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MD47CgkJCQl9OwoJCQkJcG93ZXItZG9tYWlu QFJLMzM5OV9QRF9JU1AwIHsKCQkJCQlyZWcgPSA8UkszMzk5X1BEX0lTUDA+OwoJCQkJCWNsb2Nr cyA9IDwmY3J1IEFDTEtfSVNQMD4sCgkJCQkJCSA8JmNydSBIQ0xLX0lTUDA+OwoJCQkJCXBtX3Fv cyA9IDwmcW9zX2lzcDBfbTA+LAoJCQkJCQkgPCZxb3NfaXNwMF9tMT47CgkJCQkJI3Bvd2VyLWRv bWFpbi1jZWxscyA9IDwwPjsKCQkJCX07CgkJCQlwb3dlci1kb21haW5AUkszMzk5X1BEX0lTUDEg ewoJCQkJCXJlZyA9IDxSSzMzOTlfUERfSVNQMT47CgkJCQkJY2xvY2tzID0gPCZjcnUgQUNMS19J U1AxPiwKCQkJCQkJIDwmY3J1IEhDTEtfSVNQMT47CgkJCQkJcG1fcW9zID0gPCZxb3NfaXNwMV9t MD4sCgkJCQkJCSA8JnFvc19pc3AxX20xPjsKCQkJCQkjcG93ZXItZG9tYWluLWNlbGxzID0gPDA+ OwoJCQkJfTsKCQkJCXBvd2VyLWRvbWFpbkBSSzMzOTlfUERfVk8gewoJCQkJCXJlZyA9IDxSSzMz OTlfUERfVk8+OwoJCQkJCSNwb3dlci1kb21haW4tY2VsbHMgPSA8MT47CgkJCQkJI2FkZHJlc3Mt Y2VsbHMgPSA8MT47CgkJCQkJI3NpemUtY2VsbHMgPSA8MD47CgoJCQkJCXBvd2VyLWRvbWFpbkBS SzMzOTlfUERfVk9QQiB7CgkJCQkJCXJlZyA9IDxSSzMzOTlfUERfVk9QQj47CgkJCQkJCWNsb2Nr cyA9IDwmY3J1IEFDTEtfVk9QMD4sCgkJCQkJCQkgPCZjcnUgSENMS19WT1AwPjsKCQkJCQkJcG1f cW9zID0gPCZxb3Nfdm9wX2JpZ19yPiwKCQkJCQkJCSA8JnFvc192b3BfYmlnX3c+OwoJCQkJCQkj cG93ZXItZG9tYWluLWNlbGxzID0gPDA+OwoJCQkJCX07CgkJCQkJcG93ZXItZG9tYWluQFJLMzM5 OV9QRF9WT1BMIHsKCQkJCQkJcmVnID0gPFJLMzM5OV9QRF9WT1BMPjsKCQkJCQkJY2xvY2tzID0g PCZjcnUgQUNMS19WT1AxPiwKCQkJCQkJCSA8JmNydSBIQ0xLX1ZPUDE+OwoJCQkJCQlwbV9xb3Mg PSA8JnFvc192b3BfbGl0dGxlPjsKCQkJCQkJI3Bvd2VyLWRvbWFpbi1jZWxscyA9IDwwPjsKCQkJ CQl9OwoJCQkJfTsKCQkJfTsKCQl9OwoJfTsKCglwbXVncmY6IHN5c2NvbkBmZjMyMDAwMCB7CgkJ Y29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcG11Z3JmIiwgInN5c2NvbiIsICJzaW1wbGUt bWZkIjsKCQlyZWcgPSA8MHgwIDB4ZmYzMjAwMDAgMHgwIDB4MTAwMD47CgoJCXBtdV9pb19kb21h aW5zOiBpby1kb21haW5zIHsKCQkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcG11LWlv LXZvbHRhZ2UtZG9tYWluIjsKCQkJc3RhdHVzID0gImRpc2FibGVkIjsKCQl9OwoJfTsKCglzcGkz OiBzcGlAZmYzNTAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXNwaSIsICJy b2NrY2hpcCxyazMwNjYtc3BpIjsKCQlyZWcgPSA8MHgwIDB4ZmYzNTAwMDAgMHgwIDB4MTAwMD47 CgkJY2xvY2tzID0gPCZwbXVjcnUgU0NMS19TUEkzX1BNVT4sIDwmcG11Y3J1IFBDTEtfU1BJM19Q TVU+OwoJCWNsb2NrLW5hbWVzID0gInNwaWNsayIsICJhcGJfcGNsayI7CgkJaW50ZXJydXB0cyA9 IDxHSUNfU1BJIDYwIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJcGluY3RybC1uYW1lcyA9ICJk ZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JnNwaTNfY2xrICZzcGkzX3R4ICZzcGkzX3J4ICZzcGkz X2NzMD47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3Rh dHVzID0gImRpc2FibGVkIjsKCX07CgoJdWFydDQ6IHNlcmlhbEBmZjM3MDAwMCB7CgkJY29tcGF0 aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktdWFydCIsICJzbnBzLGR3LWFwYi11YXJ0IjsKCQlyZWcg PSA8MHgwIDB4ZmYzNzAwMDAgMHgwIDB4MTAwPjsKCQljbG9ja3MgPSA8JnBtdWNydSBTQ0xLX1VB UlQ0X1BNVT4sIDwmcG11Y3J1IFBDTEtfVUFSVDRfUE1VPjsKCQljbG9jay1uYW1lcyA9ICJiYXVk Y2xrIiwgImFwYl9wY2xrIjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTAyIElSUV9UWVBFX0xF VkVMX0hJR0ggMD47CgkJcmVnLXNoaWZ0ID0gPDI+OwoJCXJlZy1pby13aWR0aCA9IDw0PjsKCQlw aW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmdWFydDRfeGZlcj47CgkJ c3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjMDogaTJjQGZmM2MwMDAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjNjMDAwMCAweDAg MHgxMDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JnBtdWNydSBTQ0xLX0kyQzBfUE1VPjsKCQlh c3NpZ25lZC1jbG9jay1yYXRlcyA9IDwyMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmcG11Y3J1IFND TEtfSTJDMF9QTVU+LCA8JnBtdWNydSBQQ0xLX0kyQzBfUE1VPjsKCQljbG9jay1uYW1lcyA9ICJp MmMiLCAicGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU3IElSUV9UWVBFX0xFVkVMX0hJ R0ggMD47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzBf eGZlcj47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3Rh dHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJjNDogaTJjQGZmM2QwMDAwIHsKCQljb21wYXRpYmxl ID0gInJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjNkMDAwMCAweDAgMHgx MDAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JnBtdWNydSBTQ0xLX0kyQzRfUE1VPjsKCQlhc3Np Z25lZC1jbG9jay1yYXRlcyA9IDwyMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmcG11Y3J1IFNDTEtf STJDNF9QTVU+LCA8JnBtdWNydSBQQ0xLX0kyQzRfUE1VPjsKCQljbG9jay1uYW1lcyA9ICJpMmMi LCAicGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU2IElSUV9UWVBFX0xFVkVMX0hJR0gg MD47CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzRfeGZl cj47CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVz ID0gImRpc2FibGVkIjsKCX07CgoJaTJjODogaTJjQGZmM2UwMDAwIHsKCQljb21wYXRpYmxlID0g InJvY2tjaGlwLHJrMzM5OS1pMmMiOwoJCXJlZyA9IDwweDAgMHhmZjNlMDAwMCAweDAgMHgxMDAw PjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JnBtdWNydSBTQ0xLX0kyQzhfUE1VPjsKCQlhc3NpZ25l ZC1jbG9jay1yYXRlcyA9IDwyMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmcG11Y3J1IFNDTEtfSTJD OF9QTVU+LCA8JnBtdWNydSBQQ0xLX0kyQzhfUE1VPjsKCQljbG9jay1uYW1lcyA9ICJpMmMiLCAi cGNsayI7CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDU4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47 CgkJcGluY3RybC1uYW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JmkyYzhfeGZlcj47 CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0g ImRpc2FibGVkIjsKCX07CgoJcHdtMDogcHdtQGZmNDIwMDAwIHsKCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS1wd20iLCAicm9ja2NoaXAscmszMjg4LXB3bSI7CgkJcmVnID0gPDB4MCAw eGZmNDIwMDAwIDB4MCAweDEwPjsKCQkjcHdtLWNlbGxzID0gPDM+OwoJCXBpbmN0cmwtbmFtZXMg PSAiZGVmYXVsdCI7CgkJcGluY3RybC0wID0gPCZwd20wX3Bpbj47CgkJY2xvY2tzID0gPCZwbXVj cnUgUENMS19SS1BXTV9QTVU+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCXB3bTE6IHB3 bUBmZjQyMDAxMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcHdtIiwgInJvY2tj aGlwLHJrMzI4OC1wd20iOwoJCXJlZyA9IDwweDAgMHhmZjQyMDAxMCAweDAgMHgxMD47CgkJI3B3 bS1jZWxscyA9IDwzPjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9 IDwmcHdtMV9waW4+OwoJCWNsb2NrcyA9IDwmcG11Y3J1IFBDTEtfUktQV01fUE1VPjsKCQlzdGF0 dXMgPSAiZGlzYWJsZWQiOwoJfTsKCglwd20yOiBwd21AZmY0MjAwMjAgewoJCWNvbXBhdGlibGUg PSAicm9ja2NoaXAscmszMzk5LXB3bSIsICJyb2NrY2hpcCxyazMyODgtcHdtIjsKCQlyZWcgPSA8 MHgwIDB4ZmY0MjAwMjAgMHgwIDB4MTA+OwoJCSNwd20tY2VsbHMgPSA8Mz47CgkJcGluY3RybC1u YW1lcyA9ICJkZWZhdWx0IjsKCQlwaW5jdHJsLTAgPSA8JnB3bTJfcGluPjsKCQljbG9ja3MgPSA8 JnBtdWNydSBQQ0xLX1JLUFdNX1BNVT47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJcHdt MzogcHdtQGZmNDIwMDMwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1wd20iLCAi cm9ja2NoaXAscmszMjg4LXB3bSI7CgkJcmVnID0gPDB4MCAweGZmNDIwMDMwIDB4MCAweDEwPjsK CQkjcHdtLWNlbGxzID0gPDM+OwoJCXBpbmN0cmwtbmFtZXMgPSAiZGVmYXVsdCI7CgkJcGluY3Ry bC0wID0gPCZwd20zYV9waW4+OwoJCWNsb2NrcyA9IDwmcG11Y3J1IFBDTEtfUktQV01fUE1VPjsK CQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoJfTsKCgl2cHU6IHZpZGVvLWNvZGVjQGZmNjUwMDAwIHsK CQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS12cHUiOwoJCXJlZyA9IDwweDAgMHhmZjY1 MDAwMCAweDAgMHg4MDA+OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMTQgSVJRX1RZUEVfTEVW RUxfSElHSCAwPiwKCQkJICAgICA8R0lDX1NQSSAxMTMgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsK CQlpbnRlcnJ1cHQtbmFtZXMgPSAidmVwdSIsICJ2ZHB1IjsKCQljbG9ja3MgPSA8JmNydSBBQ0xL X1ZDT0RFQz4sIDwmY3J1IEhDTEtfVkNPREVDPjsKCQljbG9jay1uYW1lcyA9ICJhY2xrIiwgImhj bGsiOwoJCWlvbW11cyA9IDwmdnB1X21tdT47CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUksz Mzk5X1BEX1ZDT0RFQz47Cgl9OwoKCXZwdV9tbXU6IGlvbW11QGZmNjUwODAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLGlvbW11IjsKCQlyZWcgPSA8MHgwIDB4ZmY2NTA4MDAgMHgwIDB4NDA+ OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMTUgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlp bnRlcnJ1cHQtbmFtZXMgPSAidnB1X21tdSI7CgkJY2xvY2tzID0gPCZjcnUgQUNMS19WQ09ERUM+ LCA8JmNydSBIQ0xLX1ZDT0RFQz47CgkJY2xvY2stbmFtZXMgPSAiYWNsayIsICJpZmFjZSI7CgkJ I2lvbW11LWNlbGxzID0gPDA+OwoJCXBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9W Q09ERUM+OwoJfTsKCgl2ZGVjOiB2aWRlby1jb2RlY0BmZjY2MDAwMCB7CgkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktdmRlYyI7CgkJcmVnID0gPDB4MCAweGZmNjYwMDAwIDB4MCAweDQw MD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDExNiBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJ CWNsb2NrcyA9IDwmY3J1IEFDTEtfVkRVPiwgPCZjcnUgSENMS19WRFU+LAoJCQkgPCZjcnUgU0NM S19WRFVfQ0E+LCA8JmNydSBTQ0xLX1ZEVV9DT1JFPjsKCQljbG9jay1uYW1lcyA9ICJheGkiLCAi YWhiIiwgImNhYmFjIiwgImNvcmUiOwoJCWlvbW11cyA9IDwmdmRlY19tbXU+OwoJCXBvd2VyLWRv bWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9WRFU+OwoJfTsKCgl2ZGVjX21tdTogaW9tbXVAZmY2 NjA0ODAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAsaW9tbXUiOwoJCXJlZyA9IDwweDAgMHhm ZjY2MDQ4MCAweDAgMHg0MD4sIDwweDAgMHhmZjY2MDRjMCAweDAgMHg0MD47CgkJaW50ZXJydXB0 cyA9IDxHSUNfU1BJIDExNyBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJCWludGVycnVwdC1uYW1l cyA9ICJ2ZGVjX21tdSI7CgkJY2xvY2tzID0gPCZjcnUgQUNMS19WRFU+LCA8JmNydSBIQ0xLX1ZE VT47CgkJY2xvY2stbmFtZXMgPSAiYWNsayIsICJpZmFjZSI7CgkJcG93ZXItZG9tYWlucyA9IDwm cG93ZXIgUkszMzk5X1BEX1ZEVT47CgkJI2lvbW11LWNlbGxzID0gPDA+OwoJfTsKCglpZXBfbW11 OiBpb21tdUBmZjY3MDgwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxpb21tdSI7CgkJcmVn ID0gPDB4MCAweGZmNjcwODAwIDB4MCAweDQwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgNDIg SVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlpbnRlcnJ1cHQtbmFtZXMgPSAiaWVwX21tdSI7CgkJ Y2xvY2tzID0gPCZjcnUgQUNMS19JRVA+LCA8JmNydSBIQ0xLX0lFUD47CgkJY2xvY2stbmFtZXMg PSAiYWNsayIsICJpZmFjZSI7CgkJI2lvbW11LWNlbGxzID0gPDA+OwoJCXN0YXR1cyA9ICJkaXNh YmxlZCI7Cgl9OwoKCXJnYTogcmdhQGZmNjgwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlw LHJrMzM5OS1yZ2EiOwoJCXJlZyA9IDwweDAgMHhmZjY4MDAwMCAweDAgMHgxMDAwMD47CgkJaW50 ZXJydXB0cyA9IDxHSUNfU1BJIDU1IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJY2xvY2tzID0g PCZjcnUgQUNMS19SR0E+LCA8JmNydSBIQ0xLX1JHQT4sIDwmY3J1IFNDTEtfUkdBX0NPUkU+OwoJ CWNsb2NrLW5hbWVzID0gImFjbGsiLCAiaGNsayIsICJzY2xrIjsKCQlyZXNldHMgPSA8JmNydSBT UlNUX1JHQV9DT1JFPiwgPCZjcnUgU1JTVF9BX1JHQT4sIDwmY3J1IFNSU1RfSF9SR0E+OwoJCXJl c2V0LW5hbWVzID0gImNvcmUiLCAiYXhpIiwgImFoYiI7CgkJcG93ZXItZG9tYWlucyA9IDwmcG93 ZXIgUkszMzk5X1BEX1JHQT47Cgl9OwoKCWVmdXNlMDogZWZ1c2VAZmY2OTAwMDAgewoJCWNvbXBh dGlibGUgPSAicm9ja2NoaXAscmszMzk5LWVmdXNlIjsKCQlyZWcgPSA8MHgwIDB4ZmY2OTAwMDAg MHgwIDB4ODA+OwoJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCSNzaXplLWNlbGxzID0gPDE+OwoJ CWNsb2NrcyA9IDwmY3J1IFBDTEtfRUZVU0UxMDI0TlM+OwoJCWNsb2NrLW5hbWVzID0gInBjbGtf ZWZ1c2UiOwoKCQkvKiBEYXRhIGNlbGxzICovCgkJY3B1X2lkOiBjcHUtaWRANyB7CgkJCXJlZyA9 IDwweDA3IDB4MTA+OwoJCX07CgkJY3B1Yl9sZWFrYWdlOiBjcHUtbGVha2FnZUAxNyB7CgkJCXJl ZyA9IDwweDE3IDB4MT47CgkJfTsKCQlncHVfbGVha2FnZTogZ3B1LWxlYWthZ2VAMTggewoJCQly ZWcgPSA8MHgxOCAweDE+OwoJCX07CgkJY2VudGVyX2xlYWthZ2U6IGNlbnRlci1sZWFrYWdlQDE5 IHsKCQkJcmVnID0gPDB4MTkgMHgxPjsKCQl9OwoJCWNwdWxfbGVha2FnZTogY3B1LWxlYWthZ2VA MWEgewoJCQlyZWcgPSA8MHgxYSAweDE+OwoJCX07CgkJbG9naWNfbGVha2FnZTogbG9naWMtbGVh a2FnZUAxYiB7CgkJCXJlZyA9IDwweDFiIDB4MT47CgkJfTsKCQl3YWZlcl9pbmZvOiB3YWZlci1p bmZvQDFjIHsKCQkJcmVnID0gPDB4MWMgMHgxPjsKCQl9OwoJfTsKCglkbWFjX2J1czogZG1hLWNv bnRyb2xsZXJAZmY2ZDAwMDAgewoJCWNvbXBhdGlibGUgPSAiYXJtLHBsMzMwIiwgImFybSxwcmlt ZWNlbGwiOwoJCXJlZyA9IDwweDAgMHhmZjZkMDAwMCAweDAgMHg0MDAwPjsKCQlpbnRlcnJ1cHRz ID0gPEdJQ19TUEkgNSBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+LAoJCQkgICAgIDxHSUNfU1BJIDYg SVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQkjZG1hLWNlbGxzID0gPDE+OwoJCWFybSxwbDMzMC1w ZXJpcGgtYnVyc3Q7CgkJY2xvY2tzID0gPCZjcnUgQUNMS19ETUFDMF9QRVJJTFA+OwoJCWNsb2Nr LW5hbWVzID0gImFwYl9wY2xrIjsKCX07CgoJZG1hY19wZXJpOiBkbWEtY29udHJvbGxlckBmZjZl MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJhcm0scGwzMzAiLCAiYXJtLHByaW1lY2VsbCI7CgkJcmVn ID0gPDB4MCAweGZmNmUwMDAwIDB4MCAweDQwMDA+OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSA3 IElSUV9UWVBFX0xFVkVMX0hJR0ggMD4sCgkJCSAgICAgPEdJQ19TUEkgOCBJUlFfVFlQRV9MRVZF TF9ISUdIIDA+OwoJCSNkbWEtY2VsbHMgPSA8MT47CgkJYXJtLHBsMzMwLXBlcmlwaC1idXJzdDsK CQljbG9ja3MgPSA8JmNydSBBQ0xLX0RNQUMxX1BFUklMUD47CgkJY2xvY2stbmFtZXMgPSAiYXBi X3BjbGsiOwoJfTsKCglwbXVjcnU6IHBtdS1jbG9jay1jb250cm9sbGVyQGZmNzUwMDAwIHsKCQlj b21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1wbXVjcnUiOwoJCXJlZyA9IDwweDAgMHhmZjc1 MDAwMCAweDAgMHgxMDAwPjsKCQlyb2NrY2hpcCxncmYgPSA8JnBtdWdyZj47CgkJI2Nsb2NrLWNl bGxzID0gPDE+OwoJCSNyZXNldC1jZWxscyA9IDwxPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8JnBt dWNydSBQTExfUFBMTD47CgkJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8Njc2MDAwMDAwPjsKCX07 CgoJY3J1OiBjbG9jay1jb250cm9sbGVyQGZmNzYwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tj aGlwLHJrMzM5OS1jcnUiOwoJCXJlZyA9IDwweDAgMHhmZjc2MDAwMCAweDAgMHgxMDAwPjsKCQly b2NrY2hpcCxncmYgPSA8JmdyZj47CgkJI2Nsb2NrLWNlbGxzID0gPDE+OwoJCSNyZXNldC1jZWxs cyA9IDwxPjsKCQlhc3NpZ25lZC1jbG9ja3MgPQoJCQk8JmNydSBQTExfR1BMTD4sIDwmY3J1IFBM TF9DUExMPiwKCQkJPCZjcnUgUExMX05QTEw+LAoJCQk8JmNydSBBQ0xLX1BFUklIUD4sIDwmY3J1 IEhDTEtfUEVSSUhQPiwKCQkJPCZjcnUgUENMS19QRVJJSFA+LAoJCQk8JmNydSBBQ0xLX1BFUklM UDA+LCA8JmNydSBIQ0xLX1BFUklMUDA+LAoJCQk8JmNydSBQQ0xLX1BFUklMUDA+LCA8JmNydSBB Q0xLX0NDST4sCgkJCTwmY3J1IEhDTEtfUEVSSUxQMT4sIDwmY3J1IFBDTEtfUEVSSUxQMT4sCgkJ CTwmY3J1IEFDTEtfVklPPiwgPCZjcnUgQUNMS19IRENQPiwKCQkJPCZjcnUgQUNMS19HSUNfUFJF PiwKCQkJPCZjcnUgUENMS19ERFI+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVzID0KCQkJIDw1OTQw MDAwMDA+LCAgPDgwMDAwMDAwMD4sCgkJCTwxMDAwMDAwMDAwPiwKCQkJIDwxNTAwMDAwMDA+LCAg IDw3NTAwMDAwMD4sCgkJCSAgPDM3NTAwMDAwPiwKCQkJIDwxMDAwMDAwMDA+LCAgPDEwMDAwMDAw MD4sCgkJCSAgPDUwMDAwMDAwPiwgPDYwMDAwMDAwMD4sCgkJCSA8MTAwMDAwMDAwPiwgICA8NTAw MDAwMDA+LAoJCQkgPDQwMDAwMDAwMD4sIDw0MDAwMDAwMDA+LAoJCQkgPDIwMDAwMDAwMD4sCgkJ CSA8MjAwMDAwMDAwPjsKCX07CgoJZ3JmOiBzeXNjb25AZmY3NzAwMDAgewoJCWNvbXBhdGlibGUg PSAicm9ja2NoaXAscmszMzk5LWdyZiIsICJzeXNjb24iLCAic2ltcGxlLW1mZCI7CgkJcmVnID0g PDB4MCAweGZmNzcwMDAwIDB4MCAweDEwMDAwPjsKCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkj c2l6ZS1jZWxscyA9IDwxPjsKCgkJaW9fZG9tYWluczogaW8tZG9tYWlucyB7CgkJCWNvbXBhdGli bGUgPSAicm9ja2NoaXAscmszMzk5LWlvLXZvbHRhZ2UtZG9tYWluIjsKCQkJc3RhdHVzID0gImRp c2FibGVkIjsKCQl9OwoKCQltaXBpX2RwaHlfcngwOiBtaXBpLWRwaHktcngwIHsKCQkJY29tcGF0 aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktbWlwaS1kcGh5LXJ4MCI7CgkJCWNsb2NrcyA9IDwmY3J1 IFNDTEtfTUlQSURQSFlfUkVGPiwKCQkJCSA8JmNydSBTQ0xLX0RQSFlfUlgwX0NGRz4sCgkJCQkg PCZjcnUgUENMS19WSU9fR1JGPjsKCQkJY2xvY2stbmFtZXMgPSAiZHBoeS1yZWYiLCAiZHBoeS1j ZmciLCAiZ3JmIjsKCQkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX1ZJTz47CgkJ CSNwaHktY2VsbHMgPSA8MD47CgkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgkJfTsKCgkJdTJwaHkw OiB1c2IycGh5QGU0NTAgewoJCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS11c2IycGh5 IjsKCQkJcmVnID0gPDB4ZTQ1MCAweDEwPjsKCQkJY2xvY2tzID0gPCZjcnUgU0NMS19VU0IyUEhZ MF9SRUY+OwoJCQljbG9jay1uYW1lcyA9ICJwaHljbGsiOwoJCQkjY2xvY2stY2VsbHMgPSA8MD47 CgkJCWNsb2NrLW91dHB1dC1uYW1lcyA9ICJjbGtfdXNicGh5MF80ODBtIjsKCQkJc3RhdHVzID0g ImRpc2FibGVkIjsKCgkJCXUycGh5MF9ob3N0OiBob3N0LXBvcnQgewoJCQkJI3BoeS1jZWxscyA9 IDwwPjsKCQkJCWludGVycnVwdHMgPSA8R0lDX1NQSSAyNyBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+ OwoJCQkJaW50ZXJydXB0LW5hbWVzID0gImxpbmVzdGF0ZSI7CgkJCQlzdGF0dXMgPSAiZGlzYWJs ZWQiOwoJCQl9OwoKCQkJdTJwaHkwX290Zzogb3RnLXBvcnQgewoJCQkJI3BoeS1jZWxscyA9IDww PjsKCQkJCWludGVycnVwdHMgPSA8R0lDX1NQSSAxMDMgSVJRX1RZUEVfTEVWRUxfSElHSCAwPiwK CQkJCQkgICAgIDxHSUNfU1BJIDEwNCBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+LAoJCQkJCSAgICAg PEdJQ19TUEkgMTA2IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJCQlpbnRlcnJ1cHQtbmFtZXMg PSAib3RnLWJ2YWxpZCIsICJvdGctaWQiLAoJCQkJCQkgICJsaW5lc3RhdGUiOwoJCQkJc3RhdHVz ID0gImRpc2FibGVkIjsKCQkJfTsKCQl9OwoKCQl1MnBoeTE6IHVzYjJwaHlAZTQ2MCB7CgkJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXVzYjJwaHkiOwoJCQlyZWcgPSA8MHhlNDYwIDB4 MTA+OwoJCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VTQjJQSFkxX1JFRj47CgkJCWNsb2NrLW5hbWVz ID0gInBoeWNsayI7CgkJCSNjbG9jay1jZWxscyA9IDwwPjsKCQkJY2xvY2stb3V0cHV0LW5hbWVz ID0gImNsa191c2JwaHkxXzQ4MG0iOwoJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoKCQkJdTJwaHkx X2hvc3Q6IGhvc3QtcG9ydCB7CgkJCQkjcGh5LWNlbGxzID0gPDA+OwoJCQkJaW50ZXJydXB0cyA9 IDxHSUNfU1BJIDMxIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJCQlpbnRlcnJ1cHQtbmFtZXMg PSAibGluZXN0YXRlIjsKCQkJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgkJCX07CgoJCQl1MnBoeTFf b3RnOiBvdGctcG9ydCB7CgkJCQkjcGh5LWNlbGxzID0gPDA+OwoJCQkJaW50ZXJydXB0cyA9IDxH SUNfU1BJIDEwOCBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+LAoJCQkJCSAgICAgPEdJQ19TUEkgMTA5 IElSUV9UWVBFX0xFVkVMX0hJR0ggMD4sCgkJCQkJICAgICA8R0lDX1NQSSAxMTEgSVJRX1RZUEVf TEVWRUxfSElHSCAwPjsKCQkJCWludGVycnVwdC1uYW1lcyA9ICJvdGctYnZhbGlkIiwgIm90Zy1p ZCIsCgkJCQkJCSAgImxpbmVzdGF0ZSI7CgkJCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoJCQl9OwoJ CX07CgoJCWVtbWNfcGh5OiBwaHlAZjc4MCB7CgkJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmsz Mzk5LWVtbWMtcGh5IjsKCQkJcmVnID0gPDB4Zjc4MCAweDI0PjsKCQkJY2xvY2tzID0gPCZzZGhj aT47CgkJCWNsb2NrLW5hbWVzID0gImVtbWNjbGsiOwoJCQkjcGh5LWNlbGxzID0gPDA+OwoJCQlz dGF0dXMgPSAiZGlzYWJsZWQiOwoJCX07CgoJCXBjaWVfcGh5OiBwY2llLXBoeSB7CgkJCWNvbXBh dGlibGUgPSAicm9ja2NoaXAscmszMzk5LXBjaWUtcGh5IjsKCQkJY2xvY2tzID0gPCZjcnUgU0NM S19QQ0lFUEhZX1JFRj47CgkJCWNsb2NrLW5hbWVzID0gInJlZmNsayI7CgkJCSNwaHktY2VsbHMg PSA8MT47CgkJCXJlc2V0cyA9IDwmY3J1IFNSU1RfUENJRVBIWT47CgkJCWRyaXZlLWltcGVkYW5j ZS1vaG0gPSA8NTA+OwoJCQlyZXNldC1uYW1lcyA9ICJwaHkiOwoJCQlzdGF0dXMgPSAiZGlzYWJs ZWQiOwoJCX07Cgl9OwoKCXRjcGh5MDogcGh5QGZmN2MwMDAwIHsKCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS10eXBlYy1waHkiOwoJCXJlZyA9IDwweDAgMHhmZjdjMDAwMCAweDAgMHg0 MDAwMD47CgkJY2xvY2tzID0gPCZjcnUgU0NMS19VUEhZMF9UQ1BEQ09SRT4sCgkJCSA8JmNydSBT Q0xLX1VQSFkwX1RDUERQSFlfUkVGPjsKCQljbG9jay1uYW1lcyA9ICJ0Y3BkY29yZSIsICJ0Y3Bk cGh5LXJlZiI7CgkJYXNzaWduZWQtY2xvY2tzID0gPCZjcnUgU0NMS19VUEhZMF9UQ1BEQ09SRT47 CgkJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8NTAwMDAwMDA+OwoJCXBvd2VyLWRvbWFpbnMgPSA8 JnBvd2VyIFJLMzM5OV9QRF9UQ1BEMD47CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9VUEhZMD4sCgkJ CSA8JmNydSBTUlNUX1VQSFkwX1BJUEVfTDAwPiwKCQkJIDwmY3J1IFNSU1RfUF9VUEhZMF9UQ1BI WT47CgkJcmVzZXQtbmFtZXMgPSAidXBoeSIsICJ1cGh5LXBpcGUiLCAidXBoeS10Y3BoeSI7CgkJ cm9ja2NoaXAsZ3JmID0gPCZncmY+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgoJCXRjcGh5MF9k cDogZHAtcG9ydCB7CgkJCSNwaHktY2VsbHMgPSA8MD47CgkJfTsKCgkJdGNwaHkwX3VzYjM6IHVz YjMtcG9ydCB7CgkJCSNwaHktY2VsbHMgPSA8MD47CgkJfTsKCX07CgoJdGNwaHkxOiBwaHlAZmY4 MDAwMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LXR5cGVjLXBoeSI7CgkJcmVn ID0gPDB4MCAweGZmODAwMDAwIDB4MCAweDQwMDAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX1VQ SFkxX1RDUERDT1JFPiwKCQkJIDwmY3J1IFNDTEtfVVBIWTFfVENQRFBIWV9SRUY+OwoJCWNsb2Nr LW5hbWVzID0gInRjcGRjb3JlIiwgInRjcGRwaHktcmVmIjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8 JmNydSBTQ0xLX1VQSFkxX1RDUERDT1JFPjsKCQlhc3NpZ25lZC1jbG9jay1yYXRlcyA9IDw1MDAw MDAwMD47CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX1RDUEQxPjsKCQlyZXNl dHMgPSA8JmNydSBTUlNUX1VQSFkxPiwKCQkJIDwmY3J1IFNSU1RfVVBIWTFfUElQRV9MMDA+LAoJ CQkgPCZjcnUgU1JTVF9QX1VQSFkxX1RDUEhZPjsKCQlyZXNldC1uYW1lcyA9ICJ1cGh5IiwgInVw aHktcGlwZSIsICJ1cGh5LXRjcGh5IjsKCQlyb2NrY2hpcCxncmYgPSA8JmdyZj47CgkJc3RhdHVz ID0gImRpc2FibGVkIjsKCgkJdGNwaHkxX2RwOiBkcC1wb3J0IHsKCQkJI3BoeS1jZWxscyA9IDww PjsKCQl9OwoKCQl0Y3BoeTFfdXNiMzogdXNiMy1wb3J0IHsKCQkJI3BoeS1jZWxscyA9IDwwPjsK CQl9OwoJfTsKCgl3YXRjaGRvZ0BmZjg0ODAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxy azMzOTktd2R0IiwgInNucHMsZHctd2R0IjsKCQlyZWcgPSA8MHgwIDB4ZmY4NDgwMDAgMHgwIDB4 MTAwPjsKCQljbG9ja3MgPSA8JmNydSBQQ0xLX1dEVD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJ IDEyMCBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJfTsKCglya3RpbWVyOiBya3RpbWVyQGZmODUw MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS10aW1lciI7CgkJcmVnID0gPDB4 MCAweGZmODUwMDAwIDB4MCAweDEwMDA+OwoJCWludGVycnVwdHMgPSA8R0lDX1NQSSA4MSBJUlFf VFlQRV9MRVZFTF9ISUdIIDA+OwoJCWNsb2NrcyA9IDwmY3J1IFBDTEtfVElNRVIwPiwgPCZjcnUg U0NMS19USU1FUjAwPjsKCQljbG9jay1uYW1lcyA9ICJwY2xrIiwgInRpbWVyIjsKCX07CgoJc3Bk aWY6IHNwZGlmQGZmODcwMDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1zcGRp ZiI7CgkJcmVnID0gPDB4MCAweGZmODcwMDAwIDB4MCAweDEwMDA+OwoJCWludGVycnVwdHMgPSA8 R0lDX1NQSSA2NiBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoJCWRtYXMgPSA8JmRtYWNfYnVzIDc+ OwoJCWRtYS1uYW1lcyA9ICJ0eCI7CgkJY2xvY2stbmFtZXMgPSAibWNsayIsICJoY2xrIjsKCQlj bG9ja3MgPSA8JmNydSBTQ0xLX1NQRElGXzhDSD4sIDwmY3J1IEhDTEtfU1BESUY+OwoJCXBpbmN0 cmwtbmFtZXMgPSAiZGVmYXVsdCI7CgkJcGluY3RybC0wID0gPCZzcGRpZl9idXM+OwoJCXBvd2Vy LWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9TRElPQVVESU8+OwoJCSNzb3VuZC1kYWktY2Vs bHMgPSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJaTJzMDogaTJzQGZmODgwMDAw IHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1pMnMiLCAicm9ja2NoaXAscmszMDY2 LWkycyI7CgkJcmVnID0gPDB4MCAweGZmODgwMDAwIDB4MCAweDEwMDA+OwoJCXJvY2tjaGlwLGdy ZiA9IDwmZ3JmPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMzkgSVJRX1RZUEVfTEVWRUxfSElH SCAwPjsKCQlkbWFzID0gPCZkbWFjX2J1cyAwPiwgPCZkbWFjX2J1cyAxPjsKCQlkbWEtbmFtZXMg PSAidHgiLCAicngiOwoJCWNsb2NrLW5hbWVzID0gImkyc19jbGsiLCAiaTJzX2hjbGsiOwoJCWNs b2NrcyA9IDwmY3J1IFNDTEtfSTJTMF84Q0g+LCA8JmNydSBIQ0xLX0kyUzBfOENIPjsKCQlwaW5j dHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmaTJzMF84Y2hfYnVzPjsKCQlw b3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfU0RJT0FVRElPPjsKCQkjc291bmQtZGFp LWNlbGxzID0gPDA+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCWkyczE6IGkyc0BmZjg5 MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktaTJzIiwgInJvY2tjaGlwLHJr MzA2Ni1pMnMiOwoJCXJlZyA9IDwweDAgMHhmZjg5MDAwMCAweDAgMHgxMDAwPjsKCQlpbnRlcnJ1 cHRzID0gPEdJQ19TUEkgNDAgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlkbWFzID0gPCZkbWFj X2J1cyAyPiwgPCZkbWFjX2J1cyAzPjsKCQlkbWEtbmFtZXMgPSAidHgiLCAicngiOwoJCWNsb2Nr LW5hbWVzID0gImkyc19jbGsiLCAiaTJzX2hjbGsiOwoJCWNsb2NrcyA9IDwmY3J1IFNDTEtfSTJT MV84Q0g+LCA8JmNydSBIQ0xLX0kyUzFfOENIPjsKCQlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQi OwoJCXBpbmN0cmwtMCA9IDwmaTJzMV8yY2hfYnVzPjsKCQlwb3dlci1kb21haW5zID0gPCZwb3dl ciBSSzMzOTlfUERfU0RJT0FVRElPPjsKCQkjc291bmQtZGFpLWNlbGxzID0gPDA+OwoJCXN0YXR1 cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCWkyczI6IGkyc0BmZjhhMDAwMCB7CgkJY29tcGF0aWJsZSA9 ICJyb2NrY2hpcCxyazMzOTktaTJzIiwgInJvY2tjaGlwLHJrMzA2Ni1pMnMiOwoJCXJlZyA9IDww eDAgMHhmZjhhMDAwMCAweDAgMHgxMDAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgNDEgSVJR X1RZUEVfTEVWRUxfSElHSCAwPjsKCQlkbWFzID0gPCZkbWFjX2J1cyA0PiwgPCZkbWFjX2J1cyA1 PjsKCQlkbWEtbmFtZXMgPSAidHgiLCAicngiOwoJCWNsb2NrLW5hbWVzID0gImkyc19jbGsiLCAi aTJzX2hjbGsiOwoJCWNsb2NrcyA9IDwmY3J1IFNDTEtfSTJTMl84Q0g+LCA8JmNydSBIQ0xLX0ky UzJfOENIPjsKCQlwb3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfU0RJT0FVRElPPjsK CQkjc291bmQtZGFpLWNlbGxzID0gPDA+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7Cgl9OwoKCXZv cGw6IHZvcEBmZjhmMDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktdm9wLWxp dCI7CgkJcmVnID0gPDB4MCAweGZmOGYwMDAwIDB4MCAweDNlZmM+OwoJCWludGVycnVwdHMgPSA8 R0lDX1NQSSAxMTkgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlhc3NpZ25lZC1jbG9ja3MgPSA8 JmNydSBBQ0xLX1ZPUDE+LCA8JmNydSBIQ0xLX1ZPUDE+OwoJCWFzc2lnbmVkLWNsb2NrLXJhdGVz ID0gPDQwMDAwMDAwMD4sIDwxMDAwMDAwMDA+OwoJCWNsb2NrcyA9IDwmY3J1IEFDTEtfVk9QMT4s IDwmY3J1IERDTEtfVk9QMT4sIDwmY3J1IEhDTEtfVk9QMT47CgkJY2xvY2stbmFtZXMgPSAiYWNs a192b3AiLCAiZGNsa192b3AiLCAiaGNsa192b3AiOwoJCWlvbW11cyA9IDwmdm9wbF9tbXU+OwoJ CXBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9WT1BMPjsKCQlyZXNldHMgPSA8JmNy dSBTUlNUX0FfVk9QMT4sIDwmY3J1IFNSU1RfSF9WT1AxPiwgPCZjcnUgU1JTVF9EX1ZPUDE+OwoJ CXJlc2V0LW5hbWVzID0gImF4aSIsICJhaGIiLCAiZGNsayI7CgkJc3RhdHVzID0gImRpc2FibGVk IjsKCgkJdm9wbF9vdXQ6IHBvcnQgewoJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkJI3NpemUt Y2VsbHMgPSA8MD47CgoJCQl2b3BsX291dF9taXBpOiBlbmRwb2ludEAwIHsKCQkJCXJlZyA9IDww PjsKCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmbWlwaV9pbl92b3BsPjsKCQkJfTsKCgkJCXZvcGxf b3V0X2VkcDogZW5kcG9pbnRAMSB7CgkJCQlyZWcgPSA8MT47CgkJCQlyZW1vdGUtZW5kcG9pbnQg PSA8JmVkcF9pbl92b3BsPjsKCQkJfTsKCgkJCXZvcGxfb3V0X2hkbWk6IGVuZHBvaW50QDIgewoJ CQkJcmVnID0gPDI+OwoJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZoZG1pX2luX3ZvcGw+OwoJCQl9 OwoKCQkJdm9wbF9vdXRfbWlwaTE6IGVuZHBvaW50QDMgewoJCQkJcmVnID0gPDM+OwoJCQkJcmVt b3RlLWVuZHBvaW50ID0gPCZtaXBpMV9pbl92b3BsPjsKCQkJfTsKCgkJCXZvcGxfb3V0X2RwOiBl bmRwb2ludEA0IHsKCQkJCXJlZyA9IDw0PjsKCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmZHBfaW5f dm9wbD47CgkJCX07CgkJfTsKCX07CgoJdm9wbF9tbXU6IGlvbW11QGZmOGYzZjAwIHsKCQljb21w YXRpYmxlID0gInJvY2tjaGlwLGlvbW11IjsKCQlyZWcgPSA8MHgwIDB4ZmY4ZjNmMDAgMHgwIDB4 MTAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTE5IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47 CgkJaW50ZXJydXB0LW5hbWVzID0gInZvcGxfbW11IjsKCQljbG9ja3MgPSA8JmNydSBBQ0xLX1ZP UDE+LCA8JmNydSBIQ0xLX1ZPUDE+OwoJCWNsb2NrLW5hbWVzID0gImFjbGsiLCAiaWZhY2UiOwoJ CXBvd2VyLWRvbWFpbnMgPSA8JnBvd2VyIFJLMzM5OV9QRF9WT1BMPjsKCQkjaW9tbXUtY2VsbHMg PSA8MD47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJdm9wYjogdm9wQGZmOTAwMDAwIHsK CQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS12b3AtYmlnIjsKCQlyZWcgPSA8MHgwIDB4 ZmY5MDAwMDAgMHgwIDB4M2VmYz47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDExOCBJUlFfVFlQ RV9MRVZFTF9ISUdIIDA+OwoJCWFzc2lnbmVkLWNsb2NrcyA9IDwmY3J1IEFDTEtfVk9QMD4sIDwm Y3J1IEhDTEtfVk9QMD47CgkJYXNzaWduZWQtY2xvY2stcmF0ZXMgPSA8NDAwMDAwMDAwPiwgPDEw MDAwMDAwMD47CgkJY2xvY2tzID0gPCZjcnUgQUNMS19WT1AwPiwgPCZjcnUgRENMS19WT1AwPiwg PCZjcnUgSENMS19WT1AwPjsKCQljbG9jay1uYW1lcyA9ICJhY2xrX3ZvcCIsICJkY2xrX3ZvcCIs ICJoY2xrX3ZvcCI7CgkJaW9tbXVzID0gPCZ2b3BiX21tdT47CgkJcG93ZXItZG9tYWlucyA9IDwm cG93ZXIgUkszMzk5X1BEX1ZPUEI+OwoJCXJlc2V0cyA9IDwmY3J1IFNSU1RfQV9WT1AwPiwgPCZj cnUgU1JTVF9IX1ZPUDA+LCA8JmNydSBTUlNUX0RfVk9QMD47CgkJcmVzZXQtbmFtZXMgPSAiYXhp IiwgImFoYiIsICJkY2xrIjsKCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoKCQl2b3BiX291dDogcG9y dCB7CgkJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkjc2l6ZS1jZWxscyA9IDwwPjsKCgkJCXZv cGJfb3V0X2VkcDogZW5kcG9pbnRAMCB7CgkJCQlyZWcgPSA8MD47CgkJCQlyZW1vdGUtZW5kcG9p bnQgPSA8JmVkcF9pbl92b3BiPjsKCQkJfTsKCgkJCXZvcGJfb3V0X21pcGk6IGVuZHBvaW50QDEg ewoJCQkJcmVnID0gPDE+OwoJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZtaXBpX2luX3ZvcGI+OwoJ CQl9OwoKCQkJdm9wYl9vdXRfaGRtaTogZW5kcG9pbnRAMiB7CgkJCQlyZWcgPSA8Mj47CgkJCQly ZW1vdGUtZW5kcG9pbnQgPSA8JmhkbWlfaW5fdm9wYj47CgkJCX07CgoJCQl2b3BiX291dF9taXBp MTogZW5kcG9pbnRAMyB7CgkJCQlyZWcgPSA8Mz47CgkJCQlyZW1vdGUtZW5kcG9pbnQgPSA8Jm1p cGkxX2luX3ZvcGI+OwoJCQl9OwoKCQkJdm9wYl9vdXRfZHA6IGVuZHBvaW50QDQgewoJCQkJcmVn ID0gPDQ+OwoJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZkcF9pbl92b3BiPjsKCQkJfTsKCQl9OwoJ fTsKCgl2b3BiX21tdTogaW9tbXVAZmY5MDNmMDAgewoJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAs aW9tbXUiOwoJCXJlZyA9IDwweDAgMHhmZjkwM2YwMCAweDAgMHgxMDA+OwoJCWludGVycnVwdHMg PSA8R0lDX1NQSSAxMTggSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlpbnRlcnJ1cHQtbmFtZXMg PSAidm9wYl9tbXUiOwoJCWNsb2NrcyA9IDwmY3J1IEFDTEtfVk9QMD4sIDwmY3J1IEhDTEtfVk9Q MD47CgkJY2xvY2stbmFtZXMgPSAiYWNsayIsICJpZmFjZSI7CgkJcG93ZXItZG9tYWlucyA9IDwm cG93ZXIgUkszMzk5X1BEX1ZPUEI+OwoJCSNpb21tdS1jZWxscyA9IDwwPjsKCQlzdGF0dXMgPSAi ZGlzYWJsZWQiOwoJfTsKCglpc3AwOiBpc3AwQGZmOTEwMDAwIHsKCQljb21wYXRpYmxlID0gInJv Y2tjaGlwLHJrMzM5OS1jaWYtaXNwIjsKCQlyZWcgPSA8MHgwIDB4ZmY5MTAwMDAgMHgwIDB4NDAw MD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDQzIElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJ Y2xvY2tzID0gPCZjcnUgU0NMS19JU1AwPiwKCQkJIDwmY3J1IEFDTEtfSVNQMF9XUkFQUEVSPiwK CQkJIDwmY3J1IEhDTEtfSVNQMF9XUkFQUEVSPjsKCQljbG9jay1uYW1lcyA9ICJpc3AiLCAiYWNs ayIsICJoY2xrIjsKCQlpb21tdXMgPSA8JmlzcDBfbW11PjsKCQlwaHlzID0gPCZtaXBpX2RwaHlf cngwPjsKCQlwaHktbmFtZXMgPSAiZHBoeSI7CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUksz Mzk5X1BEX0lTUDA+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgoJCXBvcnRzIHsKCQkJI2FkZHJl c3MtY2VsbHMgPSA8MT47CgkJCSNzaXplLWNlbGxzID0gPDA+OwoKCQkJcG9ydEAwIHsKCQkJCXJl ZyA9IDwwPjsKCQkJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkJI3NpemUtY2VsbHMgPSA8MD47 CgkJCX07CgkJfTsKCX07CgoJaXNwMF9tbXU6IGlvbW11QGZmOTE0MDAwIHsKCQljb21wYXRpYmxl ID0gInJvY2tjaGlwLGlvbW11IjsKCQlyZWcgPSA8MHgwIDB4ZmY5MTQwMDAgMHgwIDB4MTAwPiwg PDB4MCAweGZmOTE1MDAwIDB4MCAweDEwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDQzIElS UV9UWVBFX0xFVkVMX0hJR0ggMD47CgkJaW50ZXJydXB0LW5hbWVzID0gImlzcDBfbW11IjsKCQlj bG9ja3MgPSA8JmNydSBBQ0xLX0lTUDBfV1JBUFBFUj4sIDwmY3J1IEhDTEtfSVNQMF9XUkFQUEVS PjsKCQljbG9jay1uYW1lcyA9ICJhY2xrIiwgImlmYWNlIjsKCQkjaW9tbXUtY2VsbHMgPSA8MD47 CgkJcG93ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX0lTUDA+OwoJCXJvY2tjaGlwLGRp c2FibGUtbW11LXJlc2V0OwoJfTsKCglpc3AxX21tdTogaW9tbXVAZmY5MjQwMDAgewoJCWNvbXBh dGlibGUgPSAicm9ja2NoaXAsaW9tbXUiOwoJCXJlZyA9IDwweDAgMHhmZjkyNDAwMCAweDAgMHgx MDA+LCA8MHgwIDB4ZmY5MjUwMDAgMHgwIDB4MTAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkg NDQgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQlpbnRlcnJ1cHQtbmFtZXMgPSAiaXNwMV9tbXUi OwoJCWNsb2NrcyA9IDwmY3J1IEFDTEtfSVNQMV9XUkFQUEVSPiwgPCZjcnUgSENMS19JU1AxX1dS QVBQRVI+OwoJCWNsb2NrLW5hbWVzID0gImFjbGsiLCAiaWZhY2UiOwoJCSNpb21tdS1jZWxscyA9 IDwwPjsKCQlwb3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfSVNQMT47CgkJcm9ja2No aXAsZGlzYWJsZS1tbXUtcmVzZXQ7Cgl9OwoKCWhkbWlfc291bmQ6IGhkbWktc291bmQgewoJCWNv bXBhdGlibGUgPSAic2ltcGxlLWF1ZGlvLWNhcmQiOwoJCXNpbXBsZS1hdWRpby1jYXJkLGZvcm1h dCA9ICJpMnMiOwoJCXNpbXBsZS1hdWRpby1jYXJkLG1jbGstZnMgPSA8MjU2PjsKCQlzaW1wbGUt YXVkaW8tY2FyZCxuYW1lID0gImhkbWktc291bmQiOwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgoJ CXNpbXBsZS1hdWRpby1jYXJkLGNwdSB7CgkJCXNvdW5kLWRhaSA9IDwmaTJzMj47CgkJfTsKCQlz aW1wbGUtYXVkaW8tY2FyZCxjb2RlYyB7CgkJCXNvdW5kLWRhaSA9IDwmaGRtaT47CgkJfTsKCX07 CgoJaGRtaTogaGRtaUBmZjk0MDAwMCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTkt ZHctaGRtaSI7CgkJcmVnID0gPDB4MCAweGZmOTQwMDAwIDB4MCAweDIwMDAwPjsKCQlpbnRlcnJ1 cHRzID0gPEdJQ19TUEkgMjMgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQljbG9ja3MgPSA8JmNy dSBQQ0xLX0hETUlfQ1RSTD4sCgkJCSA8JmNydSBTQ0xLX0hETUlfU0ZSPiwKCQkJIDwmY3J1IFBM TF9WUExMPiwKCQkJIDwmY3J1IFBDTEtfVklPX0dSRj4sCgkJCSA8JmNydSBTQ0xLX0hETUlfQ0VD PjsKCQljbG9jay1uYW1lcyA9ICJpYWhiIiwgImlzZnIiLCAidnBsbCIsICJncmYiLCAiY2VjIjsK CQlwb3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfSERDUD47CgkJcmVnLWlvLXdpZHRo ID0gPDQ+OwoJCXJvY2tjaGlwLGdyZiA9IDwmZ3JmPjsKCQkjc291bmQtZGFpLWNlbGxzID0gPDA+ OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgoJCXBvcnRzIHsKCQkJaGRtaV9pbjogcG9ydCB7CgkJ CQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkJCSNzaXplLWNlbGxzID0gPDA+OwoKCQkJCWhkbWlf aW5fdm9wYjogZW5kcG9pbnRAMCB7CgkJCQkJcmVnID0gPDA+OwoJCQkJCXJlbW90ZS1lbmRwb2lu dCA9IDwmdm9wYl9vdXRfaGRtaT47CgkJCQl9OwoJCQkJaGRtaV9pbl92b3BsOiBlbmRwb2ludEAx IHsKCQkJCQlyZWcgPSA8MT47CgkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZ2b3BsX291dF9oZG1p PjsKCQkJCX07CgkJCX07CgkJfTsKCX07CgoJbWlwaV9kc2k6IG1pcGlAZmY5NjAwMDAgewoJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LW1pcGktZHNpIiwgInNucHMsZHctbWlwaS1kc2ki OwoJCXJlZyA9IDwweDAgMHhmZjk2MDAwMCAweDAgMHg4MDAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJ Q19TUEkgNDUgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCQljbG9ja3MgPSA8JmNydSBTQ0xLX0RQ SFlfUExMPiwgPCZjcnUgUENMS19NSVBJX0RTSTA+LAoJCQkgPCZjcnUgU0NMS19EUEhZX1RYMF9D Rkc+LCA8JmNydSBQQ0xLX1ZJT19HUkY+OwoJCWNsb2NrLW5hbWVzID0gInJlZiIsICJwY2xrIiwg InBoeV9jZmciLCAiZ3JmIjsKCQlwb3dlci1kb21haW5zID0gPCZwb3dlciBSSzMzOTlfUERfVklP PjsKCQlyZXNldHMgPSA8JmNydSBTUlNUX1BfTUlQSV9EU0kwPjsKCQlyZXNldC1uYW1lcyA9ICJh cGIiOwoJCXJvY2tjaGlwLGdyZiA9IDwmZ3JmPjsKCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkj c2l6ZS1jZWxscyA9IDwwPjsKCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwoKCQlwb3J0cyB7CgkJCSNh ZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkjc2l6ZS1jZWxscyA9IDwwPjsKCgkJCW1pcGlfaW46IHBv cnRAMCB7CgkJCQlyZWcgPSA8MD47CgkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkJCSNzaXpl LWNlbGxzID0gPDA+OwoKCQkJCW1pcGlfaW5fdm9wYjogZW5kcG9pbnRAMCB7CgkJCQkJcmVnID0g PDA+OwoJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmdm9wYl9vdXRfbWlwaT47CgkJCQl9OwoJCQkJ bWlwaV9pbl92b3BsOiBlbmRwb2ludEAxIHsKCQkJCQlyZWcgPSA8MT47CgkJCQkJcmVtb3RlLWVu ZHBvaW50ID0gPCZ2b3BsX291dF9taXBpPjsKCQkJCX07CgkJCX07CgkJfTsKCX07CgoJbWlwaV9k c2kxOiBtaXBpQGZmOTY4MDAwIHsKCQljb21wYXRpYmxlID0gInJvY2tjaGlwLHJrMzM5OS1taXBp LWRzaSIsICJzbnBzLGR3LW1pcGktZHNpIjsKCQlyZWcgPSA8MHgwIDB4ZmY5NjgwMDAgMHgwIDB4 ODAwMD47CgkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDQ2IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47 CgkJY2xvY2tzID0gPCZjcnUgU0NMS19EUEhZX1BMTD4sIDwmY3J1IFBDTEtfTUlQSV9EU0kxPiwK CQkJIDwmY3J1IFNDTEtfRFBIWV9UWDFSWDFfQ0ZHPiwgPCZjcnUgUENMS19WSU9fR1JGPjsKCQlj bG9jay1uYW1lcyA9ICJyZWYiLCAicGNsayIsICJwaHlfY2ZnIiwgImdyZiI7CgkJcG93ZXItZG9t YWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX1ZJTz47CgkJcmVzZXRzID0gPCZjcnUgU1JTVF9QX01J UElfRFNJMT47CgkJcmVzZXQtbmFtZXMgPSAiYXBiIjsKCQlyb2NrY2hpcCxncmYgPSA8JmdyZj47 CgkJI2FkZHJlc3MtY2VsbHMgPSA8MT47CgkJI3NpemUtY2VsbHMgPSA8MD47CgkJc3RhdHVzID0g ImRpc2FibGVkIjsKCgkJcG9ydHMgewoJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkJI3NpemUt Y2VsbHMgPSA8MD47CgoJCQltaXBpMV9pbjogcG9ydEAwIHsKCQkJCXJlZyA9IDwwPjsKCQkJCSNh ZGRyZXNzLWNlbGxzID0gPDE+OwoJCQkJI3NpemUtY2VsbHMgPSA8MD47CgoJCQkJbWlwaTFfaW5f dm9wYjogZW5kcG9pbnRAMCB7CgkJCQkJcmVnID0gPDA+OwoJCQkJCXJlbW90ZS1lbmRwb2ludCA9 IDwmdm9wYl9vdXRfbWlwaTE+OwoJCQkJfTsKCgkJCQltaXBpMV9pbl92b3BsOiBlbmRwb2ludEAx IHsKCQkJCQlyZWcgPSA8MT47CgkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZ2b3BsX291dF9taXBp MT47CgkJCQl9OwoJCQl9OwoJCX07Cgl9OwoKCWVkcDogZWRwQGZmOTcwMDAwIHsKCQljb21wYXRp YmxlID0gInJvY2tjaGlwLHJrMzM5OS1lZHAiOwoJCXJlZyA9IDwweDAgMHhmZjk3MDAwMCAweDAg MHg4MDAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTAgSVJRX1RZUEVfTEVWRUxfSElHSCAw PjsKCQljbG9ja3MgPSA8JmNydSBQQ0xLX0VEUD4sIDwmY3J1IFBDTEtfRURQX0NUUkw+LCA8JmNy dSBQQ0xLX1ZJT19HUkY+OwoJCWNsb2NrLW5hbWVzID0gImRwIiwgInBjbGsiLCAiZ3JmIjsKCQlw aW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwoJCXBpbmN0cmwtMCA9IDwmZWRwX2hwZD47CgkJcG93 ZXItZG9tYWlucyA9IDwmcG93ZXIgUkszMzk5X1BEX0VEUD47CgkJcmVzZXRzID0gPCZjcnUgU1JT VF9QX0VEUF9DVFJMPjsKCQlyZXNldC1uYW1lcyA9ICJkcCI7CgkJcm9ja2NoaXAsZ3JmID0gPCZn cmY+OwoJCXN0YXR1cyA9ICJkaXNhYmxlZCI7CgoJCXBvcnRzIHsKCQkJI2FkZHJlc3MtY2VsbHMg PSA8MT47CgkJCSNzaXplLWNlbGxzID0gPDA+OwoJCQllZHBfaW46IHBvcnRAMCB7CgkJCQlyZWcg PSA8MD47CgkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKCQkJCSNzaXplLWNlbGxzID0gPDA+OwoK CQkJCWVkcF9pbl92b3BiOiBlbmRwb2ludEAwIHsKCQkJCQlyZWcgPSA8MD47CgkJCQkJcmVtb3Rl LWVuZHBvaW50ID0gPCZ2b3BiX291dF9lZHA+OwoJCQkJfTsKCgkJCQllZHBfaW5fdm9wbDogZW5k cG9pbnRAMSB7CgkJCQkJcmVnID0gPDE+OwoJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmdm9wbF9v dXRfZWRwPjsKCQkJCX07CgkJCX07CgkJfTsKCX07CgoJZ3B1OiBncHVAZmY5YTAwMDAgewoJCWNv bXBhdGlibGUgPSAicm9ja2NoaXAscmszMzk5LW1hbGkiLCAiYXJtLG1hbGktbWlkZ2FyZCI7CgkJ cmVnID0gPDB4MCAweGZmOWEwMDAwIDB4MCAweDEwMDAwPjsKCQlpbnRlcnJ1cHRzID0gPEdJQ19T UEkgMjAgSVJRX1RZUEVfTEVWRUxfSElHSCAwPiwKCQkJICAgICA8R0lDX1NQSSAyMSBJUlFfVFlQ RV9MRVZFTF9ISUdIIDA+LAoJCQkgICAgIDxHSUNfU1BJIDE5IElSUV9UWVBFX0xFVkVMX0hJR0gg MD47CgkJaW50ZXJydXB0LW5hbWVzID0gImpvYiIsICJtbXUiLCAiZ3B1IjsKCQljbG9ja3MgPSA8 JmNydSBBQ0xLX0dQVT47CgkJI2Nvb2xpbmctY2VsbHMgPSA8Mj47CgkJcG93ZXItZG9tYWlucyA9 IDwmcG93ZXIgUkszMzk5X1BEX0dQVT47CgkJc3RhdHVzID0gImRpc2FibGVkIjsKCX07CgoJcGlu Y3RybDogcGluY3RybCB7CgkJY29tcGF0aWJsZSA9ICJyb2NrY2hpcCxyazMzOTktcGluY3RybCI7 CgkJcm9ja2NoaXAsZ3JmID0gPCZncmY+OwoJCXJvY2tjaGlwLHBtdSA9IDwmcG11Z3JmPjsKCQkj YWRkcmVzcy1jZWxscyA9IDwyPjsKCQkjc2l6ZS1jZWxscyA9IDwyPjsKCQlyYW5nZXM7CgoJCWdw aW8wOiBncGlvMEBmZjcyMDAwMCB7CgkJCWNvbXBhdGlibGUgPSAicm9ja2NoaXAsZ3Bpby1iYW5r IjsKCQkJcmVnID0gPDB4MCAweGZmNzIwMDAwIDB4MCAweDEwMD47CgkJCWNsb2NrcyA9IDwmcG11 Y3J1IFBDTEtfR1BJTzBfUE1VPjsKCQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJIDE0IElSUV9UWVBF X0xFVkVMX0hJR0ggMD47CgoJCQlncGlvLWNvbnRyb2xsZXI7CgkJCSNncGlvLWNlbGxzID0gPDB4 Mj47CgoJCQlpbnRlcnJ1cHQtY29udHJvbGxlcjsKCQkJI2ludGVycnVwdC1jZWxscyA9IDwweDI+ OwoJCX07CgoJCWdwaW8xOiBncGlvMUBmZjczMDAwMCB7CgkJCWNvbXBhdGlibGUgPSAicm9ja2No aXAsZ3Bpby1iYW5rIjsKCQkJcmVnID0gPDB4MCAweGZmNzMwMDAwIDB4MCAweDEwMD47CgkJCWNs b2NrcyA9IDwmcG11Y3J1IFBDTEtfR1BJTzFfUE1VPjsKCQkJaW50ZXJydXB0cyA9IDxHSUNfU1BJ IDE1IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgoJCQlncGlvLWNvbnRyb2xsZXI7CgkJCSNncGlv LWNlbGxzID0gPDB4Mj47CgoJCQlpbnRlcnJ1cHQtY29udHJvbGxlcjsKCQkJI2ludGVycnVwdC1j ZWxscyA9IDwweDI+OwoJCX07CgoJCWdwaW8yOiBncGlvMkBmZjc4MDAwMCB7CgkJCWNvbXBhdGli bGUgPSAicm9ja2NoaXAsZ3Bpby1iYW5rIjsKCQkJcmVnID0gPDB4MCAweGZmNzgwMDAwIDB4MCAw eDEwMD47CgkJCWNsb2NrcyA9IDwmY3J1IFBDTEtfR1BJTzI+OwoJCQlpbnRlcnJ1cHRzID0gPEdJ Q19TUEkgMTYgSVJRX1RZUEVfTEVWRUxfSElHSCAwPjsKCgkJCWdwaW8tY29udHJvbGxlcjsKCQkJ I2dwaW8tY2VsbHMgPSA8MHgyPjsKCgkJCWludGVycnVwdC1jb250cm9sbGVyOwoJCQkjaW50ZXJy dXB0LWNlbGxzID0gPDB4Mj47CgkJfTsKCgkJZ3BpbzM6IGdwaW8zQGZmNzg4MDAwIHsKCQkJY29t cGF0aWJsZSA9ICJyb2NrY2hpcCxncGlvLWJhbmsiOwoJCQlyZWcgPSA8MHgwIDB4ZmY3ODgwMDAg MHgwIDB4MTAwPjsKCQkJY2xvY2tzID0gPCZjcnUgUENMS19HUElPMz47CgkJCWludGVycnVwdHMg PSA8R0lDX1NQSSAxNyBJUlFfVFlQRV9MRVZFTF9ISUdIIDA+OwoKCQkJZ3Bpby1jb250cm9sbGVy OwoJCQkjZ3Bpby1jZWxscyA9IDwweDI+OwoKCQkJaW50ZXJydXB0LWNvbnRyb2xsZXI7CgkJCSNp bnRlcnJ1cHQtY2VsbHMgPSA8MHgyPjsKCQl9OwoKCQlncGlvNDogZ3BpbzRAZmY3OTAwMDAgewoJ CQljb21wYXRpYmxlID0gInJvY2tjaGlwLGdwaW8tYmFuayI7CgkJCXJlZyA9IDwweDAgMHhmZjc5 MDAwMCAweDAgMHgxMDA+OwoJCQljbG9ja3MgPSA8JmNydSBQQ0xLX0dQSU80PjsKCQkJaW50ZXJy dXB0cyA9IDxHSUNfU1BJIDE4IElSUV9UWVBFX0xFVkVMX0hJR0ggMD47CgoJCQlncGlvLWNvbnRy b2xsZXI7CgkJCSNncGlvLWNlbGxzID0gPDB4Mj47CgoJCQlpbnRlcnJ1cHQtY29udHJvbGxlcjsK CQkJI2ludGVycnVwdC1jZWxscyA9IDwweDI+OwoJCX07CgoJCXBjZmdfcHVsbF91cDogcGNmZy1w dWxsLXVwIHsKCQkJYmlhcy1wdWxsLXVwOwoJCX07CgoJCXBjZmdfcHVsbF9kb3duOiBwY2ZnLXB1 bGwtZG93biB7CgkJCWJpYXMtcHVsbC1kb3duOwoJCX07CgoJCXBjZmdfcHVsbF9ub25lOiBwY2Zn LXB1bGwtbm9uZSB7CgkJCWJpYXMtZGlzYWJsZTsKCQl9OwoKCQlwY2ZnX3B1bGxfbm9uZV8xMm1h OiBwY2ZnLXB1bGwtbm9uZS0xMm1hIHsKCQkJYmlhcy1kaXNhYmxlOwoJCQlkcml2ZS1zdHJlbmd0 aCA9IDwxMj47CgkJfTsKCgkJcGNmZ19wdWxsX25vbmVfMTNtYTogcGNmZy1wdWxsLW5vbmUtMTNt YSB7CgkJCWJpYXMtZGlzYWJsZTsKCQkJZHJpdmUtc3RyZW5ndGggPSA8MTM+OwoJCX07CgoJCXBj ZmdfcHVsbF9ub25lXzE4bWE6IHBjZmctcHVsbC1ub25lLTE4bWEgewoJCQliaWFzLWRpc2FibGU7 CgkJCWRyaXZlLXN0cmVuZ3RoID0gPDE4PjsKCQl9OwoKCQlwY2ZnX3B1bGxfbm9uZV8yMG1hOiBw Y2ZnLXB1bGwtbm9uZS0yMG1hIHsKCQkJYmlhcy1kaXNhYmxlOwoJCQlkcml2ZS1zdHJlbmd0aCA9 IDwyMD47CgkJfTsKCgkJcGNmZ19wdWxsX3VwXzJtYTogcGNmZy1wdWxsLXVwLTJtYSB7CgkJCWJp YXMtcHVsbC11cDsKCQkJZHJpdmUtc3RyZW5ndGggPSA8Mj47CgkJfTsKCgkJcGNmZ19wdWxsX3Vw XzhtYTogcGNmZy1wdWxsLXVwLThtYSB7CgkJCWJpYXMtcHVsbC11cDsKCQkJZHJpdmUtc3RyZW5n dGggPSA8OD47CgkJfTsKCgkJcGNmZ19wdWxsX3VwXzE4bWE6IHBjZmctcHVsbC11cC0xOG1hIHsK CQkJYmlhcy1wdWxsLXVwOwoJCQlkcml2ZS1zdHJlbmd0aCA9IDwxOD47CgkJfTsKCgkJcGNmZ19w dWxsX3VwXzIwbWE6IHBjZmctcHVsbC11cC0yMG1hIHsKCQkJYmlhcy1wdWxsLXVwOwoJCQlkcml2 ZS1zdHJlbmd0aCA9IDwyMD47CgkJfTsKCgkJcGNmZ19wdWxsX2Rvd25fNG1hOiBwY2ZnLXB1bGwt ZG93bi00bWEgewoJCQliaWFzLXB1bGwtZG93bjsKCQkJZHJpdmUtc3RyZW5ndGggPSA8ND47CgkJ fTsKCgkJcGNmZ19wdWxsX2Rvd25fOG1hOiBwY2ZnLXB1bGwtZG93bi04bWEgewoJCQliaWFzLXB1 bGwtZG93bjsKCQkJZHJpdmUtc3RyZW5ndGggPSA8OD47CgkJfTsKCgkJcGNmZ19wdWxsX2Rvd25f MTJtYTogcGNmZy1wdWxsLWRvd24tMTJtYSB7CgkJCWJpYXMtcHVsbC1kb3duOwoJCQlkcml2ZS1z dHJlbmd0aCA9IDwxMj47CgkJfTsKCgkJcGNmZ19wdWxsX2Rvd25fMThtYTogcGNmZy1wdWxsLWRv d24tMThtYSB7CgkJCWJpYXMtcHVsbC1kb3duOwoJCQlkcml2ZS1zdHJlbmd0aCA9IDwxOD47CgkJ fTsKCgkJcGNmZ19wdWxsX2Rvd25fMjBtYTogcGNmZy1wdWxsLWRvd24tMjBtYSB7CgkJCWJpYXMt cHVsbC1kb3duOwoJCQlkcml2ZS1zdHJlbmd0aCA9IDwyMD47CgkJfTsKCgkJcGNmZ19vdXRwdXRf aGlnaDogcGNmZy1vdXRwdXQtaGlnaCB7CgkJCW91dHB1dC1oaWdoOwoJCX07CgoJCXBjZmdfb3V0 cHV0X2xvdzogcGNmZy1vdXRwdXQtbG93IHsKCQkJb3V0cHV0LWxvdzsKCQl9OwoKCQljbG9jayB7 CgkJCWNsa18zMms6IGNsay0zMmsgewoJCQkJcm9ja2NoaXAscGlucyA9IDwwIFJLX1BBMCAyICZw Y2ZnX3B1bGxfbm9uZT47CgkJCX07CgkJfTsKCgkJZWRwIHsKCQkJZWRwX2hwZDogZWRwLWhwZCB7 CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8NCBSS19QQzcgMiAmcGNmZ19wdWxsX25vbmU+OwoJ CQl9OwoJCX07CgoJCWdtYWMgewoJCQlyZ21paV9waW5zOiByZ21paS1waW5zIHsKCQkJCXJvY2tj aGlwLHBpbnMgPQoJCQkJCS8qIG1hY190eGNsayAqLwoJCQkJCTwzIFJLX1BDMSAxICZwY2ZnX3B1 bGxfbm9uZV8xM21hPiwKCQkJCQkvKiBtYWNfcnhjbGsgKi8KCQkJCQk8MyBSS19QQjYgMSAmcGNm Z19wdWxsX25vbmU+LAoJCQkJCS8qIG1hY19tZGlvICovCgkJCQkJPDMgUktfUEI1IDEgJnBjZmdf cHVsbF9ub25lPiwKCQkJCQkvKiBtYWNfdHhlbiAqLwoJCQkJCTwzIFJLX1BCNCAxICZwY2ZnX3B1 bGxfbm9uZV8xM21hPiwKCQkJCQkvKiBtYWNfY2xrICovCgkJCQkJPDMgUktfUEIzIDEgJnBjZmdf cHVsbF9ub25lPiwKCQkJCQkvKiBtYWNfcnhkdiAqLwoJCQkJCTwzIFJLX1BCMSAxICZwY2ZnX3B1 bGxfbm9uZT4sCgkJCQkJLyogbWFjX21kYyAqLwoJCQkJCTwzIFJLX1BCMCAxICZwY2ZnX3B1bGxf bm9uZT4sCgkJCQkJLyogbWFjX3J4ZDEgKi8KCQkJCQk8MyBSS19QQTcgMSAmcGNmZ19wdWxsX25v bmU+LAoJCQkJCS8qIG1hY19yeGQwICovCgkJCQkJPDMgUktfUEE2IDEgJnBjZmdfcHVsbF9ub25l PiwKCQkJCQkvKiBtYWNfdHhkMSAqLwoJCQkJCTwzIFJLX1BBNSAxICZwY2ZnX3B1bGxfbm9uZV8x M21hPiwKCQkJCQkvKiBtYWNfdHhkMCAqLwoJCQkJCTwzIFJLX1BBNCAxICZwY2ZnX3B1bGxfbm9u ZV8xM21hPiwKCQkJCQkvKiBtYWNfcnhkMyAqLwoJCQkJCTwzIFJLX1BBMyAxICZwY2ZnX3B1bGxf bm9uZT4sCgkJCQkJLyogbWFjX3J4ZDIgKi8KCQkJCQk8MyBSS19QQTIgMSAmcGNmZ19wdWxsX25v bmU+LAoJCQkJCS8qIG1hY190eGQzICovCgkJCQkJPDMgUktfUEExIDEgJnBjZmdfcHVsbF9ub25l XzEzbWE+LAoJCQkJCS8qIG1hY190eGQyICovCgkJCQkJPDMgUktfUEEwIDEgJnBjZmdfcHVsbF9u b25lXzEzbWE+OwoJCQl9OwoKCQkJcm1paV9waW5zOiBybWlpLXBpbnMgewoJCQkJcm9ja2NoaXAs cGlucyA9CgkJCQkJLyogbWFjX21kaW8gKi8KCQkJCQk8MyBSS19QQjUgMSAmcGNmZ19wdWxsX25v bmU+LAoJCQkJCS8qIG1hY190eGVuICovCgkJCQkJPDMgUktfUEI0IDEgJnBjZmdfcHVsbF9ub25l XzEzbWE+LAoJCQkJCS8qIG1hY19jbGsgKi8KCQkJCQk8MyBSS19QQjMgMSAmcGNmZ19wdWxsX25v bmU+LAoJCQkJCS8qIG1hY19yeGVyICovCgkJCQkJPDMgUktfUEIyIDEgJnBjZmdfcHVsbF9ub25l PiwKCQkJCQkvKiBtYWNfcnhkdiAqLwoJCQkJCTwzIFJLX1BCMSAxICZwY2ZnX3B1bGxfbm9uZT4s CgkJCQkJLyogbWFjX21kYyAqLwoJCQkJCTwzIFJLX1BCMCAxICZwY2ZnX3B1bGxfbm9uZT4sCgkJ CQkJLyogbWFjX3J4ZDEgKi8KCQkJCQk8MyBSS19QQTcgMSAmcGNmZ19wdWxsX25vbmU+LAoJCQkJ CS8qIG1hY19yeGQwICovCgkJCQkJPDMgUktfUEE2IDEgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQkv KiBtYWNfdHhkMSAqLwoJCQkJCTwzIFJLX1BBNSAxICZwY2ZnX3B1bGxfbm9uZV8xM21hPiwKCQkJ CQkvKiBtYWNfdHhkMCAqLwoJCQkJCTwzIFJLX1BBNCAxICZwY2ZnX3B1bGxfbm9uZV8xM21hPjsK CQkJfTsKCQl9OwoKCQlpMmMwIHsKCQkJaTJjMF94ZmVyOiBpMmMwLXhmZXIgewoJCQkJcm9ja2No aXAscGlucyA9CgkJCQkJPDEgUktfUEI3IDIgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8MSBSS19Q QzAgMiAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoJCX07CgoJCWkyYzEgewoJCQlpMmMxX3hmZXI6 IGkyYzEteGZlciB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8NCBSS19QQTIgMSAmcGNmZ19w dWxsX25vbmU+LAoJCQkJCTw0IFJLX1BBMSAxICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgkJfTsK CgkJaTJjMiB7CgkJCWkyYzJfeGZlcjogaTJjMi14ZmVyIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJ CQkJCTwyIFJLX1BBMSAyICZwY2ZnX3B1bGxfbm9uZV8xMm1hPiwKCQkJCQk8MiBSS19QQTAgMiAm cGNmZ19wdWxsX25vbmVfMTJtYT47CgkJCX07CgkJfTsKCgkJaTJjMyB7CgkJCWkyYzNfeGZlcjog aTJjMy14ZmVyIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTw0IFJLX1BDMSAxICZwY2ZnX3B1 bGxfbm9uZT4sCgkJCQkJPDQgUktfUEMwIDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9OwoK CQlpMmM0IHsKCQkJaTJjNF94ZmVyOiBpMmM0LXhmZXIgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJ CQkJPDEgUktfUEI0IDEgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8MSBSS19QQjMgMSAmcGNmZ19w dWxsX25vbmU+OwoJCQl9OwoJCX07CgoJCWkyYzUgewoJCQlpMmM1X3hmZXI6IGkyYzUteGZlciB7 CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19QQjMgMiAmcGNmZ19wdWxsX25vbmU+LAoJ CQkJCTwzIFJLX1BCMiAyICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgkJfTsKCgkJaTJjNiB7CgkJ CWkyYzZfeGZlcjogaTJjNi14ZmVyIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJLX1BC MiAyICZwY2ZnX3B1bGxfbm9uZT4sCgkJCQkJPDIgUktfUEIxIDIgJnBjZmdfcHVsbF9ub25lPjsK CQkJfTsKCQl9OwoKCQlpMmM3IHsKCQkJaTJjN194ZmVyOiBpMmM3LXhmZXIgewoJCQkJcm9ja2No aXAscGlucyA9CgkJCQkJPDIgUktfUEIwIDIgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8MiBSS19Q QTcgMiAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoJCX07CgoJCWkyYzggewoJCQlpMmM4X3hmZXI6 IGkyYzgteGZlciB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MSBSS19QQzUgMSAmcGNmZ19w dWxsX25vbmU+LAoJCQkJCTwxIFJLX1BDNCAxICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgkJfTsK CgkJaTJzMCB7CgkJCWkyczBfMmNoX2J1czogaTJzMC0yY2gtYnVzIHsKCQkJCXJvY2tjaGlwLHBp bnMgPQoJCQkJCTwzIFJLX1BEMCAxICZwY2ZnX3B1bGxfbm9uZT4sCgkJCQkJPDMgUktfUEQxIDEg JnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8MyBSS19QRDIgMSAmcGNmZ19wdWxsX25vbmU+LAoJCQkJ CTwzIFJLX1BEMyAxICZwY2ZnX3B1bGxfbm9uZT4sCgkJCQkJPDMgUktfUEQ3IDEgJnBjZmdfcHVs bF9ub25lPiwKCQkJCQk8NCBSS19QQTAgMSAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoKCQkJaTJz MF84Y2hfYnVzOiBpMnMwLThjaC1idXMgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDMgUktf UEQwIDEgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8MyBSS19QRDEgMSAmcGNmZ19wdWxsX25vbmU+ LAoJCQkJCTwzIFJLX1BEMiAxICZwY2ZnX3B1bGxfbm9uZT4sCgkJCQkJPDMgUktfUEQzIDEgJnBj ZmdfcHVsbF9ub25lPiwKCQkJCQk8MyBSS19QRDQgMSAmcGNmZ19wdWxsX25vbmU+LAoJCQkJCTwz IFJLX1BENSAxICZwY2ZnX3B1bGxfbm9uZT4sCgkJCQkJPDMgUktfUEQ2IDEgJnBjZmdfcHVsbF9u b25lPiwKCQkJCQk8MyBSS19QRDcgMSAmcGNmZ19wdWxsX25vbmU+LAoJCQkJCTw0IFJLX1BBMCAx ICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgkJfTsKCgkJaTJzMSB7CgkJCWkyczFfMmNoX2J1czog aTJzMS0yY2gtYnVzIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTw0IFJLX1BBMyAxICZwY2Zn X3B1bGxfbm9uZT4sCgkJCQkJPDQgUktfUEE0IDEgJnBjZmdfcHVsbF9ub25lPiwKCQkJCQk8NCBS S19QQTUgMSAmcGNmZ19wdWxsX25vbmU+LAoJCQkJCTw0IFJLX1BBNiAxICZwY2ZnX3B1bGxfbm9u ZT4sCgkJCQkJPDQgUktfUEE3IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9OwoKCQlzZGlv MCB7CgkJCXNkaW8wX2J1czE6IHNkaW8wLWJ1czEgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJ PDIgUktfUEM0IDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgoJCQlzZGlvMF9idXM0OiBzZGlvMC1i dXM0IHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJLX1BDNCAxICZwY2ZnX3B1bGxfdXA+ LAoJCQkJCTwyIFJLX1BDNSAxICZwY2ZnX3B1bGxfdXA+LAoJCQkJCTwyIFJLX1BDNiAxICZwY2Zn X3B1bGxfdXA+LAoJCQkJCTwyIFJLX1BDNyAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoKCQkJc2Rp bzBfY21kOiBzZGlvMC1jbWQgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEQwIDEg JnBjZmdfcHVsbF91cD47CgkJCX07CgoJCQlzZGlvMF9jbGs6IHNkaW8wLWNsayB7CgkJCQlyb2Nr Y2hpcCxwaW5zID0KCQkJCQk8MiBSS19QRDEgMSAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoKCQkJ c2RpbzBfY2Q6IHNkaW8wLWNkIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJLX1BEMiAx ICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoKCQkJc2RpbzBfcHdyOiBzZGlvMC1wd3IgewoJCQkJcm9j a2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEQzIDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgoJCQlz ZGlvMF9ia3B3cjogc2RpbzAtYmtwd3IgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktf UEQ0IDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgoJCQlzZGlvMF93cDogc2RpbzAtd3AgewoJCQkJ cm9ja2NoaXAscGlucyA9CgkJCQkJPDAgUktfUEEzIDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgoJ CQlzZGlvMF9pbnQ6IHNkaW8wLWludCB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MCBSS19Q QTQgMSAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQl9OwoKCQlzZG1tYyB7CgkJCXNkbW1jX2J1czE6 IHNkbW1jLWJ1czEgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEIwIDEgJnBjZmdf cHVsbF91cD47CgkJCX07CgoJCQlzZG1tY19idXM0OiBzZG1tYy1idXM0IHsKCQkJCXJvY2tjaGlw LHBpbnMgPQoJCQkJCTw0IFJLX1BCMCAxICZwY2ZnX3B1bGxfdXA+LAoJCQkJCTw0IFJLX1BCMSAx ICZwY2ZnX3B1bGxfdXA+LAoJCQkJCTw0IFJLX1BCMiAxICZwY2ZnX3B1bGxfdXA+LAoJCQkJCTw0 IFJLX1BCMyAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoKCQkJc2RtbWNfY2xrOiBzZG1tYy1jbGsg ewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEI0IDEgJnBjZmdfcHVsbF9ub25lPjsK CQkJfTsKCgkJCXNkbW1jX2NtZDogc2RtbWMtY21kIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJ CTw0IFJLX1BCNSAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoKCQkJc2RtbWNfY2Q6IHNkbW1jLWNk IHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwwIFJLX1BBNyAxICZwY2ZnX3B1bGxfdXA+OwoJ CQl9OwoKCQkJc2RtbWNfd3A6IHNkbW1jLXdwIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTww IFJLX1BCMCAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCX07CgoJCXN1c3BlbmQgewoJCQlhcF9w d3JvZmY6IGFwLXB3cm9mZiB7CgkJCQlyb2NrY2hpcCxwaW5zID0gPDEgUktfUEE1IDEgJnBjZmdf cHVsbF9ub25lPjsKCQkJfTsKCgkJCWRkcmlvX3B3cm9mZjogZGRyaW8tcHdyb2ZmIHsKCQkJCXJv Y2tjaGlwLHBpbnMgPSA8MCBSS19QQTEgMSAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoJCX07CgoJ CXNwZGlmIHsKCQkJc3BkaWZfYnVzOiBzcGRpZi1idXMgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJ CQkJPDQgUktfUEM1IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCgkJCXNwZGlmX2J1c18xOiBz cGRpZi1idXMtMSB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19QQzAgMyAmcGNmZ19w dWxsX25vbmU+OwoJCQl9OwoJCX07CgoJCXNwaTAgewoJCQlzcGkwX2Nsazogc3BpMC1jbGsgewoJ CQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDMgUktfUEE2IDIgJnBjZmdfcHVsbF91cD47CgkJCX07 CgkJCXNwaTBfY3MwOiBzcGkwLWNzMCB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19Q QTcgMiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQkJc3BpMF9jczE6IHNwaTAtY3MxIHsKCQkJCXJv Y2tjaGlwLHBpbnMgPQoJCQkJCTwzIFJLX1BCMCAyICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCQlz cGkwX3R4OiBzcGkwLXR4IHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwzIFJLX1BBNSAyICZw Y2ZnX3B1bGxfdXA+OwoJCQl9OwoJCQlzcGkwX3J4OiBzcGkwLXJ4IHsKCQkJCXJvY2tjaGlwLHBp bnMgPQoJCQkJCTwzIFJLX1BBNCAyICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCX07CgoJCXNwaTEg ewoJCQlzcGkxX2Nsazogc3BpMS1jbGsgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDEgUktf UEIxIDIgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJCXNwaTFfY3MwOiBzcGkxLWNzMCB7CgkJCQly b2NrY2hpcCxwaW5zID0KCQkJCQk8MSBSS19QQjIgMiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQkJ c3BpMV9yeDogc3BpMS1yeCB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MSBSS19QQTcgMiAm cGNmZ19wdWxsX3VwPjsKCQkJfTsKCQkJc3BpMV90eDogc3BpMS10eCB7CgkJCQlyb2NrY2hpcCxw aW5zID0KCQkJCQk8MSBSS19QQjAgMiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQl9OwoKCQlzcGky IHsKCQkJc3BpMl9jbGs6IHNwaTItY2xrIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJL X1BCMyAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCQlzcGkyX2NzMDogc3BpMi1jczAgewoJCQkJ cm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEI0IDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJ CXNwaTJfcng6IHNwaTItcnggewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEIxIDEg JnBjZmdfcHVsbF91cD47CgkJCX07CgkJCXNwaTJfdHg6IHNwaTItdHggewoJCQkJcm9ja2NoaXAs cGlucyA9CgkJCQkJPDIgUktfUEIyIDEgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJfTsKCgkJc3Bp MyB7CgkJCXNwaTNfY2xrOiBzcGkzLWNsayB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MSBS S19QQzEgMSAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQkJc3BpM19jczA6IHNwaTMtY3MwIHsKCQkJ CXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwxIFJLX1BDMiAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJ CQlzcGkzX3J4OiBzcGkzLXJ4IHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwxIFJLX1BCNyAx ICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCQlzcGkzX3R4OiBzcGkzLXR4IHsKCQkJCXJvY2tjaGlw LHBpbnMgPQoJCQkJCTwxIFJLX1BDMCAxICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCX07CgoJCXNw aTQgewoJCQlzcGk0X2Nsazogc3BpNC1jbGsgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDMg UktfUEEyIDIgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJCXNwaTRfY3MwOiBzcGk0LWNzMCB7CgkJ CQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19QQTMgMiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsK CQkJc3BpNF9yeDogc3BpNC1yeCB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19QQTAg MiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQkJc3BpNF90eDogc3BpNC10eCB7CgkJCQlyb2NrY2hp cCxwaW5zID0KCQkJCQk8MyBSS19QQTEgMiAmcGNmZ19wdWxsX3VwPjsKCQkJfTsKCQl9OwoKCQlz cGk1IHsKCQkJc3BpNV9jbGs6IHNwaTUtY2xrIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwy IFJLX1BDNiAyICZwY2ZnX3B1bGxfdXA+OwoJCQl9OwoJCQlzcGk1X2NzMDogc3BpNS1jczAgewoJ CQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEM3IDIgJnBjZmdfcHVsbF91cD47CgkJCX07 CgkJCXNwaTVfcng6IHNwaTUtcnggewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDIgUktfUEM0 IDIgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJCXNwaTVfdHg6IHNwaTUtdHggewoJCQkJcm9ja2No aXAscGlucyA9CgkJCQkJPDIgUktfUEM1IDIgJnBjZmdfcHVsbF91cD47CgkJCX07CgkJfTsKCgkJ dGVzdGNsayB7CgkJCXRlc3RfY2xrb3V0MDogdGVzdC1jbGtvdXQwIHsKCQkJCXJvY2tjaGlwLHBp bnMgPQoJCQkJCTwwIFJLX1BBMCAxICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgoJCQl0ZXN0X2Ns a291dDE6IHRlc3QtY2xrb3V0MSB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MiBSS19QRDEg MiAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoKCQkJdGVzdF9jbGtvdXQyOiB0ZXN0LWNsa291dDIg ewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDAgUktfUEIwIDMgJnBjZmdfcHVsbF9ub25lPjsK CQkJfTsKCQl9OwoKCQl0c2FkYyB7CgkJCW90cF9waW46IG90cC1waW4gewoJCQkJcm9ja2NoaXAs cGlucyA9IDwxIFJLX1BBNiBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCgkJ CW90cF9vdXQ6IG90cC1vdXQgewoJCQkJcm9ja2NoaXAscGlucyA9IDwxIFJLX1BBNiAxICZwY2Zn X3B1bGxfbm9uZT47CgkJCX07CgkJfTsKCgkJdWFydDAgewoJCQl1YXJ0MF94ZmVyOiB1YXJ0MC14 ZmVyIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJLX1BDMCAxICZwY2ZnX3B1bGxfdXA+ LAoJCQkJCTwyIFJLX1BDMSAxICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgoJCQl1YXJ0MF9jdHM6 IHVhcnQwLWN0cyB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MiBSS19QQzIgMSAmcGNmZ19w dWxsX25vbmU+OwoJCQl9OwoKCQkJdWFydDBfcnRzOiB1YXJ0MC1ydHMgewoJCQkJcm9ja2NoaXAs cGlucyA9CgkJCQkJPDIgUktfUEMzIDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9OwoKCQl1 YXJ0MSB7CgkJCXVhcnQxX3hmZXI6IHVhcnQxLXhmZXIgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJ CQkJPDMgUktfUEI0IDIgJnBjZmdfcHVsbF91cD4sCgkJCQkJPDMgUktfUEI1IDIgJnBjZmdfcHVs bF9ub25lPjsKCQkJfTsKCQl9OwoKCQl1YXJ0MmEgewoJCQl1YXJ0MmFfeGZlcjogdWFydDJhLXhm ZXIgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEIwIDIgJnBjZmdfcHVsbF91cD4s CgkJCQkJPDQgUktfUEIxIDIgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9OwoKCQl1YXJ0MmIg ewoJCQl1YXJ0MmJfeGZlcjogdWFydDJiLXhmZXIgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJ PDQgUktfUEMwIDIgJnBjZmdfcHVsbF91cD4sCgkJCQkJPDQgUktfUEMxIDIgJnBjZmdfcHVsbF9u b25lPjsKCQkJfTsKCQl9OwoKCQl1YXJ0MmMgewoJCQl1YXJ0MmNfeGZlcjogdWFydDJjLXhmZXIg ewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEMzIDEgJnBjZmdfcHVsbF91cD4sCgkJ CQkJPDQgUktfUEM0IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9OwoKCQl1YXJ0MyB7CgkJ CXVhcnQzX3hmZXI6IHVhcnQzLXhmZXIgewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDMgUktf UEI2IDIgJnBjZmdfcHVsbF91cD4sCgkJCQkJPDMgUktfUEI3IDIgJnBjZmdfcHVsbF9ub25lPjsK CQkJfTsKCgkJCXVhcnQzX2N0czogdWFydDMtY3RzIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJ CTwzIFJLX1BDMCAyICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgoJCQl1YXJ0M19ydHM6IHVhcnQz LXJ0cyB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MyBSS19QQzEgMiAmcGNmZ19wdWxsX25v bmU+OwoJCQl9OwoJCX07CgoJCXVhcnQ0IHsKCQkJdWFydDRfeGZlcjogdWFydDQteGZlciB7CgkJ CQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MSBSS19QQTcgMSAmcGNmZ19wdWxsX3VwPiwKCQkJCQk8 MSBSS19QQjAgMSAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoJCX07CgoJCXVhcnRoZGNwIHsKCQkJ dWFydGhkY3BfeGZlcjogdWFydGhkY3AteGZlciB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8 NCBSS19QQzUgMiAmcGNmZ19wdWxsX3VwPiwKCQkJCQk8NCBSS19QQzYgMiAmcGNmZ19wdWxsX25v bmU+OwoJCQl9OwoJCX07CgoJCXB3bTAgewoJCQlwd20wX3BpbjogcHdtMC1waW4gewoJCQkJcm9j a2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEMyIDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCgkJ CXB3bTBfcGluX3B1bGxfZG93bjogcHdtMC1waW4tcHVsbC1kb3duIHsKCQkJCXJvY2tjaGlwLHBp bnMgPQoJCQkJCTw0IFJLX1BDMiAxICZwY2ZnX3B1bGxfZG93bj47CgkJCX07CgoJCQl2b3AwX3B3 bV9waW46IHZvcDAtcHdtLXBpbiB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8NCBSS19QQzIg MiAmcGNmZ19wdWxsX25vbmU+OwoJCQl9OwoKCQkJdm9wMV9wd21fcGluOiB2b3AxLXB3bS1waW4g ewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEMyIDMgJnBjZmdfcHVsbF9ub25lPjsK CQkJfTsKCQl9OwoKCQlwd20xIHsKCQkJcHdtMV9waW46IHB3bTEtcGluIHsKCQkJCXJvY2tjaGlw LHBpbnMgPQoJCQkJCTw0IFJLX1BDNiAxICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgoJCQlwd20x X3Bpbl9wdWxsX2Rvd246IHB3bTEtcGluLXB1bGwtZG93biB7CgkJCQlyb2NrY2hpcCxwaW5zID0K CQkJCQk8NCBSS19QQzYgMSAmcGNmZ19wdWxsX2Rvd24+OwoJCQl9OwoJCX07CgoJCXB3bTIgewoJ CQlwd20yX3BpbjogcHdtMi1waW4gewoJCQkJcm9ja2NoaXAscGlucyA9CgkJCQkJPDEgUktfUEMz IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCgkJCXB3bTJfcGluX3B1bGxfZG93bjogcHdtMi1w aW4tcHVsbC1kb3duIHsKCQkJCXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwxIFJLX1BDMyAxICZwY2Zn X3B1bGxfZG93bj47CgkJCX07CgkJfTsKCgkJcHdtM2EgewoJCQlwd20zYV9waW46IHB3bTNhLXBp biB7CgkJCQlyb2NrY2hpcCxwaW5zID0KCQkJCQk8MCBSS19QQTYgMSAmcGNmZ19wdWxsX25vbmU+ OwoJCQl9OwoJCX07CgoJCXB3bTNiIHsKCQkJcHdtM2JfcGluOiBwd20zYi1waW4gewoJCQkJcm9j a2NoaXAscGlucyA9CgkJCQkJPDEgUktfUEI2IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsKCQl9 OwoKCQloZG1pIHsKCQkJaGRtaV9pMmNfeGZlcjogaGRtaS1pMmMteGZlciB7CgkJCQlyb2NrY2hp cCxwaW5zID0KCQkJCQk8NCBSS19QQzEgMyAmcGNmZ19wdWxsX25vbmU+LAoJCQkJCTw0IFJLX1BD MCAzICZwY2ZnX3B1bGxfbm9uZT47CgkJCX07CgoJCQloZG1pX2NlYzogaGRtaS1jZWMgewoJCQkJ cm9ja2NoaXAscGlucyA9CgkJCQkJPDQgUktfUEM3IDEgJnBjZmdfcHVsbF9ub25lPjsKCQkJfTsK CQl9OwoKCQlwY2llIHsKCQkJcGNpZV9jbGtyZXFuX2NwbTogcGNpLWNsa3JlcW4tY3BtIHsKCQkJ CXJvY2tjaGlwLHBpbnMgPQoJCQkJCTwyIFJLX1BEMiBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9u b25lPjsKCQkJfTsKCgkJCXBjaWVfY2xrcmVxbmJfY3BtOiBwY2ktY2xrcmVxbmItY3BtIHsKCQkJ CXJvY2tjaGlwLHBpbnMgPQoJCQkJCTw0IFJLX1BEMCBSS19GVU5DX0dQSU8gJnBjZmdfcHVsbF9u b25lPjsKCQkJfTsKCQl9OwoKCX07Cn07Cg== --00000000000053c7ca05e39dc2f5-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:01:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:01:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365821.596154 (Exim 4.92) (envelope-from ) id 1oBIK2-0006gV-9f; Tue, 12 Jul 2022 16:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365821.596154; Tue, 12 Jul 2022 16:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIK2-0006gO-5W; Tue, 12 Jul 2022 16:01:14 +0000 Received: by outflank-mailman (input) for mailman id 365821; Tue, 12 Jul 2022 16:01:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIK1-0006gD-6R for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 16:01:13 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d94973d6-01fb-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:01:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5307.eurprd04.prod.outlook.com (2603:10a6:10:1e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5373.18; Tue, 12 Jul 2022 15:59:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 15:59:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d94973d6-01fb-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnS64xHVpTAul5sAVwjCsNnt5lDjlPdW+mV/UNMc+YRG0pjVe9SwQHZAYH4XQrref5jVJGxkNmvW26SxTSct+4yq4WjC1A+hRzHGC7RU3TiuP0CgAD0yl8xaiKrf6eaBD5ov+Hz+9tENSsxZIItJblT1Sw/vx9sYrx/7Z753o60zqOfFpbrLMxzisamnMuVELBfXNdkEnP5JFSj7XaHzcQdmsQJBXEkqa4QLAi54V1I68UA+7KqNOx9b4mFBqYNUoN8O55dPGiFiEXGyLJl90eUk5gsyL55JZ3AXNc2QFKBcPGtBTJdglv+RP+gVyGvLyivlgsu9P4knAUdWH0yWYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4wj8tH/MkcC//oMymMAko5DXtK5jIHlMBTrH3qemSKE=; b=A7deI0cbAvN/tUrEsM4uM8uL/5xMYzMiCNsi/8uKeJKZ+JIPfvj9YpXsIkb7rbj18qZsUSSTg/WISMjEeJalAtXEqzrgPbw9w3iEuCzu07vcseuSN5vOLpN8dUL8P/ZgIEjaBVzoSMOQ0eUH98He8BOl9558XIa19NiFOaQTxLVVHLcp9xNV2zFj3IbsoH6/x8EApUS2hy2VWgdi903g5RVYKIo/RAosnaQlw6e2QlLKkxc35jrKZXuHWPHgJKsNBB/NPQBBAZ8HcR/lrXBO21Uusjz9iCwvD0iHIyC9InAu2GQm9s2VkvD59CTolzAA3oX2kH+oQvqWBqqLMlSAKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4wj8tH/MkcC//oMymMAko5DXtK5jIHlMBTrH3qemSKE=; b=JNNl95/VQCHzPiPNQdlnE6FZCA7pjlkwpdxcDK5s3+tGJhIMgOd3Spi3AYtpjwimlIenKqV1Hs+hkrHMinPt/a3We01lFmpFw2h+/lG7iubZUX8cD6VCgWbtYQHl/GCAzGVzbUQH+20SEq6KX758V7ih2LJ6Ugi3Gj56eRAT2VAE5xbO7XqO67dIxPL7eXaVnrJSTKu3RXpQXLNbvDxwRebJXB24sPJeBioBYnEymTswwL7C8Y9CEftoULe6Ro3YZoSOpe5qev0J7fCGR2PsapOHc1GsZREreLP7frUQn0qWdJkxOI36u6KmeLKI1sWgoN0QahjT0XfXODUugzsNyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5a283b4d-8d1a-52cf-d863-350e2ff39566@suse.com> Date: Tue, 12 Jul 2022 17:59:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0148.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b0ececa-9569-49ab-5884-08da641f8f38 X-MS-TrafficTypeDiagnostic: DB7PR04MB5307:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3XundPErXqffta4YEKGXRAbQgPj8i3mgQtMFU3w+YQ4RaeeOuNCyrCVtLnv9LM6rnGLCmDChgnBhawsj7UpM+cKt0hUUCb10Oav/ibEY2nzQ08l+AyyUbw5ao6o79yZvhbGUHhhs8jdThjZUPXzvZeVhU6pMPP3ruQfeZ3j7bQX1onJxcjZoyXcFUDNU4MK1IbHKQoWIGQNdMVykkbSNOzq3K43QIrfoe2mn8Nxd2FNuo7onoGYY39w1qzmB1+H6CaeIbSEy73n9fqkAVlx+GENwTQKa9z6g/bCHBE6O/hwWAqUCok22kL1CdbTWqrKmE1yk7UyBgkOFPf1YgDtvYkNuaXYcUNt1Rb+wpQB+d7j3riCoCN0m4wN4csLYY5lHnNe8tIoh6qXif0TAzRCUBaZr2WEf4uHlK5m7zRHR2U7ukxricopVsm+F3A48sLgYq5/8iiGueMKIyfXQQhNFaBNh5ZuoMNGnk+jhL66EsNy4sfZjVtYXDRKLVPeaT7Bjib+K5FNRfIYIH4y5YRN7bxHcmvLVi+ik/fjNC7pGqXc0gxZYHMQvuJkGnb+R7enq9gwuBEKMKf/JP6r6Eqt9J5XSri/+gYOzRhuboFJvDCQDm0ciSt2piG2NliIjU0FFNjsXvvA8jk5HdKzvX53lBzGdXqeIdDylwoI9YdH8rAdKgoq11Mx0D5JUuxAlqfLBziCXKnGv80umtoz/EOtgUP360sYPHsJJYrCJuc27bMwd5+w/0CmdhOZZLGtXsJPc+qNqg6YJF+piPterqFKRBv1uMc9EPfLAWzF9CQZBpvdqWUvr3072Pffdk+DeuLDR2SuP/FOQnR0mskRpMh9zZazoSSWtwUrzqEfL4VpTcQx2dRZzTu6BsvBQW6pfITPcu1KiyTtakNd+4t4vmaYpOw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(346002)(376002)(366004)(39860400002)(83380400001)(316002)(41300700001)(2616005)(2906002)(186003)(31686004)(8676002)(66574015)(8936002)(6506007)(66946007)(26005)(53546011)(66556008)(66476007)(6486002)(36756003)(38100700002)(5660300002)(86362001)(54906003)(6512007)(31696002)(6916009)(478600001)(4326008)(2004002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkVLWllFWXhZS0hFOTN1L2gzMGk5UTJJN1RtdnkzUGQ0cGlnMEV5K3lLbHdi?= =?utf-8?B?R2RFN3RIL2lOTWdDZm5VSnFWZVNHamdWT3VuLzVwZVI1aDFHekp2MzJGUi9Q?= =?utf-8?B?bU14VzF5Q2JyMXpGcVlBcUR3UDVmVWhVcUhZL1l1TFBSVDcxQzRPNWNUMmxa?= =?utf-8?B?Yms5ZThKbE54emcyWjBtSGxnZVJhT0d3VzM4cjNPRzVERVRCbHY4Y0JkclQ0?= =?utf-8?B?dTRMdzVkK3RXQ0JOb2dITFhrSlZ3NjJnQUpZbTJRUzJRejk3bkd1djRPYWFZ?= =?utf-8?B?Sk9DOEMvaWt0aFhXTysvbWdLNUpzbmY0cjZ3RVdDN0xudzBZSHRUdkVpY2V0?= =?utf-8?B?NzBPeU9RZWtiYk5VNXIwV0JxM2JKNWlzd3dVNVJoWm5IWFZIOUtBckFXQ1R5?= =?utf-8?B?Um55Z2NrR2FaVXM0K2RwWmVMc1owUjJzNTVjVW5qTDZXeG50cWpjNmhscDNU?= =?utf-8?B?U0IyR2RhclhwUlpQenVNWnRCMkpIUEpHOVU1YmxXRVE3dnVBdm1HUm51dStR?= =?utf-8?B?RzM1YUFteEIvZ0VMRXkza3ZWdkRCcVJISzQyY1hKNnZQSVhCdStabVg3V3RF?= =?utf-8?B?M2V1VGE1Q0R0SGJoVmFsczh3Y0lVUW1HR0ZlWTdOYW5iczQyZnhyR3prNnVO?= =?utf-8?B?Y2Z0ZVNsbTA2WTBJUVljWFcvSGZQYytraVRmN0hrelRWb0JUTWRNUGxYY00w?= =?utf-8?B?bVpaV2Y0WmhpbW81L3Z3UThlTm9iTDdUb3QwRTc4M1F1elJac1NGdjdGUHF0?= =?utf-8?B?RmxsMEtwYWFMaEZyVS9uanJnV2I1Y2NWNUtjMHh2d0xJSCsrWHRldWowVnJF?= =?utf-8?B?eGkyU1d3MHhsbDdZZVN5Y3hWY3VkSU1GUTJ4Z01IaW1EWW0vL2tJQ3NtVGdr?= =?utf-8?B?UDhlT3ZxZUYwL1J3Q3ZXdlJBTjRkNkRJNktLalJ2RGZFZDEvbTBsWHNYZUJU?= =?utf-8?B?eUx3ZTNJSUU5RGR2V1hzQnBCNG9iVkRaUlJ3NW53bG5ZWlkrK3o3M1ZiT0tF?= =?utf-8?B?RTNtTXJlUUhwYzZ6bGNWWGk2ODJCN3dGMHlteHlvYXplTFdJWTJPVldSZ2Ev?= =?utf-8?B?NERLMUhSNTlQb0NBR3MyOWdjdjkxemxsMEZrRnZtTnRkMlVGSlczckNaOVhr?= =?utf-8?B?bHNoWkd2aXAxblFsRnJ2VTNrL3czVTRXMGhPSnorOFFVWk1RVFNRQlNtNUJZ?= =?utf-8?B?OU1kZXk3ZDRVWlRabVlHK2x1MFVSeGdxZThLV01ZcFVFRWhXZlMyVmNrc005?= =?utf-8?B?b1AxNDl0WXl4YjgzUWc2bFhFV3EwdDZEN0dkK0x2dVNqb3Q1ODZDRXZiekhM?= =?utf-8?B?dFlETXk2aUVxUG1oWVMrWWdZaWpRS05vMUJzWDJGeVlFWW1pU2dISWtCNGxX?= =?utf-8?B?ZXA0U0lUSUh2UWdER0lONmtJV282ZlJ3Y0VwU0U5NXpNVTZXZHBiaDFMeDRB?= =?utf-8?B?V1B1dnZ5WDJrcjUrczNYdHAvbndRb2FDR2xVSG1LdFpDNnJLaVpWL2hOMng3?= =?utf-8?B?R1lkLzBOd3ppbTZxaFEzTlFxOHZOaVNvS3phcTJGYmdyb1lpNVllbzNNdzBK?= =?utf-8?B?aWYxZ2ZScHR6bzZlZzZFdEc1cUFEdUZFSWIrSWhPdUVQb1EyZU1aU0h1QmNG?= =?utf-8?B?aW5VMTB4aWhtb2NucldpN0R6LzhWV1o4cEoxSlFFMXl4WjRsMnkwTmFCS1Zv?= =?utf-8?B?ZGkzR0RQTXIzTGNlL1NPQnhBTk9ZR3JlalVoMThRNVJ1R1p2Rmg1YUtHM2N4?= =?utf-8?B?WVY5azQvemdGd1F5TTMxY2pPVmxxWWN2K2NCTHFEUHdKN1JEQjZlK1pKb2ti?= =?utf-8?B?TVBKU3lyRmNYaU5iS3htK1hjTkFZN2txTC9xRTZqNjd2d05ERTQ4SEFzeEpZ?= =?utf-8?B?MU02TE5nWjZVeFNCNHVvWkNsMHBjN3RhK3NxQjJoTWltMlVnYklnS3dVYm1Y?= =?utf-8?B?d0hkb3F6ZVJRSmxNZ0xtcHNjeFhwNXBPWjAxMEgwWmRiTENrSEFZWTZPaks0?= =?utf-8?B?WmdBVmlEMnVBZWxVcjgyNStITkZmUVJDRXZCMkw3OGdwTlJzbjB5SUlmZTJw?= =?utf-8?B?Z1pmbi9udkN4UC9hdUlEcTdxODdmdDFxNzhlQ1h4ZnpFeDJpNjNwZzlKZ2Jj?= =?utf-8?Q?/9H+Cnu14S5S6JzFvJbkxfvhW?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b0ececa-9569-49ab-5884-08da641f8f38 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 15:59:53.7194 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZePU9c2z2pzE/fu3eTh92kFzHcNpcD5tOF2Ke2Opp1/3ME+KY6cIW15B397YgOtPaG94uvbhg6VkWsbiQr6H+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5307 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > --- a/docs/misc/xen-command-line.pandoc > +++ b/docs/misc/xen-command-line.pandoc > @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: > > ### dbgp > > `= ehci[ | @pci:. ]` > +> `= xue` > > Specify the USB controller to use, either by instance number (when going > over the PCI busses sequentially) or by PCI device (must be on segment 0). > > +Use `ehci` for EHCI debug port, use `xue` for XHCI debug capability. > +Xue driver will wait indefinitely for the debug host to connect - make sure the > +cable is connected. Especially without it being clear what "xue" stands for, I wonder whether "xhci" would be the better (more commonly known) token to use here. > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -946,6 +946,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) > ns16550.irq = 3; > ns16550_init(1, &ns16550); > ehci_dbgp_init(); > +#ifdef CONFIG_HAS_XHCI > + xue_uart_init(); > +#endif Can you make an empty inline stub to avoid the #ifdef here? > --- a/xen/drivers/char/Kconfig > +++ b/xen/drivers/char/Kconfig > @@ -74,3 +74,12 @@ config HAS_EHCI > help > This selects the USB based EHCI debug port to be used as a UART. If > you have an x86 based system with USB, say Y. > + > +config HAS_XHCI > + bool "XHCI DbC UART driver" I'm afraid I consider most of the other options here wrong in starting with HAS_: Such named options should have no prompt, and be exclusively engaged by "select". Hence I'd like to ask to drop the HAS_ here. > + depends on X86 > + help > + This selects the USB based XHCI debug capability to be used as a UART. s/used/usable/? > --- /dev/null > +++ b/xen/drivers/char/xue.c > @@ -0,0 +1,933 @@ > +/* > + * drivers/char/xue.c > + * > + * Xen port for the xue debugger > + * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; If not, see . > + * > + * Copyright (c) 2019 Assured Information Security. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include Please sort xen/ before asm/ and alphabetically within each group. > +/* uncomment to have xue_uart_dump() debug function */ > +/* #define XUE_DEBUG 1 */ > + > +#define XUE_POLL_INTERVAL 100 /* us */ > + > +#define XUE_PAGE_SIZE 4096ULL I think I had asked before - why this odd suffix? > +static void xue_sys_pause(void) > +{ > + asm volatile("pause" ::: "memory"); > +} I wonder whether the open-coded inline assembly is really needed here: Can't you use cpu_relax()? If not, style nit: Several blanks missing. > +static bool __init xue_init_xhc(struct xue *xue) > +{ > + uint32_t bar0; > + uint64_t bar1; > + uint64_t devfn; > + > + /* > + * Search PCI bus 0 for the xHC. All the host controllers supported so far > + * are part of the chipset and are on bus 0. > + */ > + for ( devfn = 0; devfn < 256; devfn++ ) > + { > + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); > + uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); > + > + if ( hdr == 0 || hdr == 0x80 ) > + { > + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) > + { > + xue->sbdf = sbdf; > + break; > + } > + } > + } > + > + if ( !xue->sbdf.sbdf ) > + { > + xue_error("Compatible xHC not found on bus 0\n"); > + return false; > + } > + > + /* ...we found it, so parse the BAR and map the registers */ > + bar0 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0); > + bar1 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_1); > + > + /* IO BARs not allowed; BAR must be 64-bit */ > + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY || > + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) != PCI_BASE_ADDRESS_MEM_TYPE_64 ) > + return false; > + > + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); > + xue->xhc_mmio_size = ~(pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0) & 0xFFFFFFF0) + 1; > + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, bar0); Why is a 64-bit BAR required when you size only the low 32 bits? Also you need to disable memory decoding around this (and somewhere you also need to explicitly enable it, assuming here you would afterwards restore the original value of the command register). Further you're still open-coding PCI_BASE_ADDRESS_MEM_MASK here. > +/** > + * The first register of the debug capability is found by traversing the > + * host controller's capability list (xcap) until a capability > + * with ID = 0xA is found. The xHCI capability list begins at address > + * mmio + (HCCPARAMS1[31:16] << 2) > + */ > +static struct xue_dbc_reg *xue_find_dbc(struct xue *xue) > +{ > + uint32_t *xcap; > + uint32_t next; > + uint32_t id; > + uint8_t *mmio = (uint8_t *)xue->xhc_mmio; > + uint32_t *hccp1 = (uint32_t *)(mmio + 0x10); > + const uint32_t DBC_ID = 0xA; > + > + /** > + * Paranoid check against a zero value. The spec mandates that > + * at least one "supported protocol" capability must be implemented, > + * so this should always be false. > + */ > + if ( (*hccp1 & 0xFFFF0000) == 0 ) > + return NULL; > + > + xcap = (uint32_t *)(mmio + (((*hccp1 & 0xFFFF0000) >> 16) << 2)); Why not either xcap = (uint32_t *)(mmio + ((*hccp1 >> 16) << 2)); or xcap = (uint32_t *)(mmio + ((*hccp1 & 0xFFFF0000) >> 14)); ? > + next = (*xcap & 0xFF00) >> 8; > + id = *xcap & 0xFF; > + > + /** > + * Table 7-1 states that 'next' is relative to > + * the current value of xcap and is a dword offset. > + */ > + while ( id != DBC_ID && next ) { Nit: Brace placement. > + xcap += next; > + id = *xcap & 0xFF; > + next = (*xcap & 0xFF00) >> 8; > + } Is this loop guaranteed to terminate? See drivers/pci/pci.c where circular chains are being dealt with in a similar situation. > +/* Initialize the DbC info with USB string descriptor addresses */ > +static void xue_init_strings(struct xue *xue, uint32_t *info) > +{ > + uint64_t *sda; > + > + /* clang-format off */ What's this? > + const char strings[] = { static? > + 6, 3, 9, 0, 4, 0, > + 8, 3, 'A', 0, 'I', 0, 'S', 0, > + 30, 3, 'X', 0, 'u', 0, 'e', 0, ' ', 0, > + 'D', 0, 'b', 0, 'C', 0, ' ', 0, > + 'D', 0, 'e', 0, 'v', 0, 'i', 0, 'c', 0, 'e', 0, > + 4, 3, '0', 0 > + }; > + /* clang-format on */ > + > + memcpy(xue->dbc_str, strings, sizeof(strings)); Can't you simply assign to xue->dbc_str? I don't see this being used elsewhere, so it might even be possible to omit the field altogether (and with it the str_buf static variable consuming an entire page). > + sda = (uint64_t *)&info[0]; > + sda[0] = virt_to_maddr(xue->dbc_str); > + sda[1] = sda[0] + 6; > + sda[2] = sda[0] + 6 + 8; > + sda[3] = sda[0] + 6 + 8 + 30; > + info[8] = (4 << 24) | (30 << 16) | (8 << 8) | 6; Wow, magic numbers. And, apparently, some used several times. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:06:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:06:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365831.596164 (Exim 4.92) (envelope-from ) id 1oBIPA-0007TR-S4; Tue, 12 Jul 2022 16:06:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365831.596164; Tue, 12 Jul 2022 16:06:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIPA-0007TK-PR; Tue, 12 Jul 2022 16:06:32 +0000 Received: by outflank-mailman (input) for mailman id 365831; Tue, 12 Jul 2022 16:06:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIP9-0007PE-JN for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 16:06:31 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97457bbe-01fc-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:06:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5312.eurprd04.prod.outlook.com (2603:10a6:803:54::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Tue, 12 Jul 2022 16:06:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Tue, 12 Jul 2022 16:06:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97457bbe-01fc-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e0MN7PLS2AmEUQyyfCfJ8K1kq43lsXZXzjP51VHcKZXe1OqdYkZy2vxAuwniwXCHj4U01RTfAh1P+HoLdhTf9JVnTA/2yWk3bq7FCupLZyu4nNDX62irPp7IzchuTR84w50OsjAq6ybAif6BR7Ri2EaGSaNFnA0LSiTMYkZA05cowEmGI/xJjAXdkmpGXH1YmPaT5vLE8vzim4fEhMasiThkkaUItPakIbTUxPiGmdLy8N+Z8Nlvskvb+p8mxnSBVdRYnXksIGpXN4JR9CTXq/uSoCkWpgFLMlIKBYMbP0J9BLymnlZzc/qJpaC7JMQuXoCViEaaJ6Q9fapxByKsRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZP6fa15XvoEgGF6rY28POJi8BYMre1S+CRD4KJ5VnmQ=; b=CXT56dJ6UtWqa1cyuYzOu/qYPilD3ZdoNjAZ+HGJNaK8pfARB+shZnJyHzLGK0ED34H6qC79LaksjABBlKIV8YOiwql41fMrAZE2e5qrFxNMH5unONNPaxe/oco12WxG2s7KC94oYKnuwmN1XczZhwEejXw+iJoG/PO1Al3xn53t+3k3HrrTmGuFQKfGDHIGyjDF4ECsyvW8k4epV/vr52KuweFf1jztfvKSjK/h+4FkW/fkdk09cPfqVeqxlaz8ub1AtAMNC2JCxoDFUQVggJNsUg12uBJ4dFo/ef7gmnq9EFMybhn4Uxkrua6K5XozNFk/A1nN2SRAFTQ/IH09UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZP6fa15XvoEgGF6rY28POJi8BYMre1S+CRD4KJ5VnmQ=; b=hJRWmDTzZ3QfskTqQlQgUO455Bp3IxLbFxbDJwg6c9itbJRgphuiTTKTGb0KBM0it0/kADCCoMI4fMuiiu1I33g3ShnpGHhPkaEh9wWZ/KeCZNyUhUcn63Z+eNLvljFQDECeVS+bbxErnAkiTfpvetlAZsqb2eTvT8gt653aSCaEzb/10IrHf4tJpNg8u5gPFiU47TdAKPaB486nqd5j/rWGRx26olGlhwZTn/bEov2GBRY4Cot7g1GDvWXLa3S/b1dG2+yJYMfA/GqvitlqDv9C2OajUTPo+qbZRAxkfDto1wJYPzRumKWpQodYKzfipNENSMFVw1iOi0NZMXk99w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 12 Jul 2022 18:06:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Connor Davis , "xen-devel@lists.xenproject.org" References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9P194CA0013.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6b44fe5-c127-4d70-d3a2-08da64207a3b X-MS-TrafficTypeDiagnostic: VI1PR04MB5312:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B8e/GYklWWiwvKTia6oBPhJDKNBUMh1j1VSVyIxiu5NgH3l7msq5twhZGNKBWnArJa9GlLkQDZOoGJiXLQ3hzFHRxj1nvl1I0bt3DlGA7LV78Lzz4Xcr386I9QjAdbQzdDZgpZKfCVEL8e77vRpTlEvXVVW8DZtMTyxChadmtgRR5twGjLq3ZuGRtAvgobnQjqpopYUFnosr5VLvftGnOMcxJglx5KIBQXRoKrpQqQu/k5hcquCCH3SJPb22+pJo1pwoNQONP5yvmFvvDAnG2w8E6Qml9+Nn2qYtffKsfl16SjCpVKV+wuegFMGd8r6msboGSVbCfaSN1Baz702EJz/KoB9jlXeNLl46nF9tfecRj9JFDbnfPBsJTn/7ATirGB8g6AGoSmiWSIWkzQew4nKh4F2XS3Vm01GmVPB04zXRNexCCpb12QjvOKYNB9CqKhFiEW/H/scwYGtdcMkIM9N51FV5v7tZRuSzlcsWN5MAiBLCWWwlUw7lRxD9RGZFic77foyF1E8E5f6hfNwYddoUa5LMusDQe1AKmkC/ZRHcZohzBqq+k8iwtTSS/X9aqo4SK1AwtTpGRtZj4yN0YqhUonxg65UDZir0DlKsmA2pYRU26hYRHi7jqseioJzrLbeoFoOWVng8/RLhtR52CLtBHG0kG+K27GppKjNREG8apUM1UfTxKSYgYBQr8EpPCaS5ZjSGnBu7IgSjuhZcrYjKFMKTSYamcds97QzVkWuaxuD5Ih/m6N94VMTebhjq9W7O8zbJJ5gKD3C1gX1mYThJuPtb7ZI9JV5hMXoDOL7SG+6+kI5RQ2h8ZhUJEdsNJAhzvVsH7Dym27dSgyxipOWuP6HlVayBbfYhay3TkotTH9O2z8zQpDwrFiY94WXd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(39860400002)(136003)(366004)(376002)(66574015)(66946007)(186003)(6506007)(2616005)(66476007)(66556008)(4326008)(6512007)(31686004)(8676002)(83380400001)(36756003)(54906003)(53546011)(6666004)(6916009)(26005)(31696002)(86362001)(316002)(966005)(5660300002)(6486002)(41300700001)(38100700002)(478600001)(8936002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWNBOUNuUXAvZFJCR1pMdkF3UEEwRm92SXJPdXluYkU4TFpwem5HYkV0VnZa?= =?utf-8?B?bHp0eFFQYm1QZFhpbHRPcEZtU0hHUnhPc0VQRFFkbHV6T0lrVGlac0xKL3VS?= =?utf-8?B?UCt6SmhzaVR2NjMrQWpuaXhzYmV0NjErMWEyRHhQTW9UWHlndmRTd0xQN3I4?= =?utf-8?B?bjJORzc5MWQ4YTE4Y3ViOE9ia2N2a0M2eXlQMzRCOE5ZTXpnd21NTnR2VzIw?= =?utf-8?B?K3lXd1laUm0xaDFiTktMaUFlZFR0QWM0QjZLUW0zdGdZYkxWSW9zeFZucm5I?= =?utf-8?B?Q3pBZ01WMUx4MDdvaEwyS2Q2eXE1RmpJQjNlQW1BNWJkVFgwdGNERnZWRGdk?= =?utf-8?B?Z0YvVTFnNHF3UGJVSlNCV3F5azdiTE1wMWZaeTJMYzBISm5ranQrYVB4Y3hr?= =?utf-8?B?WmkyRGszRGxKZHJzSXIyZDY5MURKTUp3NEFId1k3MlJ4OUl2OFg5ayt0RWND?= =?utf-8?B?MFl4bzJublRCNmZ1NHFYTjhpVFB2Tlg2OExkWU5EVDVuTEJqUmpuQkNJeExR?= =?utf-8?B?UWIrY2FULzFUbC9YTjVmVWMrSzVCeVoyYUxPMWhkSG9GSWpXOGFNV3lMS2Fz?= =?utf-8?B?TWxxQVovNVJYaC9ybmRoTG00NnR4RXRpajFteDNkTU41ektZSlRQRVA4eW9a?= =?utf-8?B?NUZacTFlRmpBTEdwdW5aMllnWTRPVkpIWkg1cHJkZUJXczZQdWdWMGlkWllD?= =?utf-8?B?S0c5bHpSenc5aVNjOFZzWnZWVWNreGJCdUpZaEprdGZ5Qm1FdkloRGJybFBG?= =?utf-8?B?THdjN3lxTE90ZVhvN1ZhNTNKK24vc2hpSVhwQkxTNVhwTEVPcS96MGtsc2lj?= =?utf-8?B?VlJnU0orWjNtQW1obm4rUzBTOFEvTWNKbXZ0RDdVRkR1cTFHeU40TWZLNXdH?= =?utf-8?B?cXBFWi9IY0hqejlHMWdPdy9ROVU5bUxIZ1ppS0VES2FVU054alBOMjJTZFVQ?= =?utf-8?B?S21VL3ZYWXBDenZhazJnZXgxWlVJRFZZc2dQaWlqdHR2ZXpvVm5UV3JYTUZH?= =?utf-8?B?NVM4K3RKbFE1WHRNZmsyTTRjaTRtVXJuMFUvNVZTUUpUYlhJUWNWek9panQ2?= =?utf-8?B?V0MzZHBsS0lFQnhVK21pMFRRNDI0TUM1ZFlIQ2M0UnFEL2VPUDJBdS9BVVhM?= =?utf-8?B?M2h0MlZRVDVtaTFTWW4vWmpRSXdWWHVibms0R2xxRHpTTHZkM0QrY0FNQ2tG?= =?utf-8?B?WXhZTnhBcng2NXQybHhFZHlVU2xXMzFNazlmSUxyNHJYMVNPaXNLK2QzS0ho?= =?utf-8?B?bCtFaE9ObnZUbXJBR3BORTlwWWQ5cGYydFRxWU9aUFRvK1ptVm5GNFVaRXNF?= =?utf-8?B?MlZPMk05QlVFdWV4RFR2TE9sV0l5NjdsOGx2TnFzeEVTMCtzbUxPa0JaMWlP?= =?utf-8?B?NE1TcW55WkNEWFBtNkpENm5FUWUra0Q3K0d2U2VMSlpaRXIyL21pTUhobXA3?= =?utf-8?B?WXphc1VWYUpxalJKTkdZSmdPYmFvK0hCK3hybVg5SldsZno1VzZ2RWFraWp6?= =?utf-8?B?UVIwNkFjRmdFcFRsazZvVEF0TDl3aVdQT2NXakNjVjJmbVFhU1JhY202STRD?= =?utf-8?B?cERFbjY2akxSZ0ZLZkkxMm0zQzgwSHV1UnhBdE94VGtmOHFNRUlnOEY5VTJs?= =?utf-8?B?WnlUNmlWSTdLKy9UTjlvT0xTdm9hMEUzN3plU0dGK2pqS0ZKZmFNdFYvVSsx?= =?utf-8?B?eFgzczJSKy8xV2JtUndQcEZSQzlJSUpoL0tNL2xvaXk1YjJtQjFwdmYvam8x?= =?utf-8?B?N3FnNTM4OFM3YlNnaUs3QXR2dnBZYWxaeTd3RzFmYzliNzBRVTM3NHNtYXN6?= =?utf-8?B?R2JISDRRbEpmV1YyM2lrQ0dUVXV6bktqQ2xGeXZCdWRBTnJYWE9qNkxYTnR3?= =?utf-8?B?aXlVQXhib1RCT0NUS3RoNjRDaVhNajFNY2RWYjVob2s4MHNUYzdqbXZyVlVW?= =?utf-8?B?VGdwZmhkZU1aVkc4a09LL3Nzc3dDQ053Q3JNSnVFMHpzbXppL3Zic3g1VFQ3?= =?utf-8?B?c1VHRldVZ0xITGR4SDN6RmdrQXlQbHVaOWU1QmNEbFhDVHdYSmZlazc3QkRV?= =?utf-8?B?MjFNanpLNjExKzJVVWtBL2I5U3Q4SXowY1BDWFMyamxiZ21RUUlGLy96L2ti?= =?utf-8?Q?UBH68Hy4cCosWD3+3T6P12Y6A?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6b44fe5-c127-4d70-d3a2-08da64207a3b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 16:06:28.0068 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bnj2K6cte+KfdFr2EWwhOuyhxyyNXVskZD2g1qjWUxHtV4ccHZ+m0o03WYsXsnGBJF2zBsMsPhacr+XA1J0TDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5312 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > From: Connor Davis > > [Connor] > Xue is a cross-platform USB 3 debugger that drives the Debug > Capability (DbC) of xHCI-compliant host controllers. This patch > implements the operations needed for xue to initialize the host > controller's DbC and communicate with it. It also implements a struct > uart_driver that uses xue as a backend. Note that only target -> host > communication is supported for now. To use Xue as a console, add > 'console=dbgp dbgp=xue' to the command line. > > [Marek] > The Xue driver is taken from https://github.com/connojd/xue and heavily > refactored to fit into Xen code base. Major changes include: > - drop support for non-Xen systems > - drop xue_ops abstraction > - use Xen's native helper functions for PCI access > - move all the code to xue.c, drop "inline" > - build for x86 only > - annotate functions with cf_check > - adjust for Xen's code style > > At this stage, only the first xHCI is considered. Later patch adds > support for choosing specific one. > The driver is initiallized before memory allocator works, so all the > transfer buffers (about 2MB of them) are allocated statically and will > use memory even if XUE console is not selected. The driver can be > disabled build time to reclaim this memory. > > Signed-off-by: Connor Davis Btw - iirc this email address has already been bouncing for me when replying to v1 patches. Interestingly enough you did Cc the cover letter to Connor Davis (which I'm using in replacement for the other address in this reply). And I can only assume that the address did bounce for you as well when sending both v1 and v2 ... Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:12:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365839.596175 (Exim 4.92) (envelope-from ) id 1oBIUR-0000WE-FZ; Tue, 12 Jul 2022 16:11:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365839.596175; Tue, 12 Jul 2022 16:11:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIUR-0000W7-Cc; Tue, 12 Jul 2022 16:11:59 +0000 Received: by outflank-mailman (input) for mailman id 365839; Tue, 12 Jul 2022 16:11:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIUP-0000Vy-AY for xen-devel@lists.xen.org; Tue, 12 Jul 2022 16:11:57 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30075.outbound.protection.outlook.com [40.107.3.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59091a44-01fd-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:11:55 +0200 (CEST) Received: from FR3P281CA0097.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::15) by PR3PR08MB5658.eurprd08.prod.outlook.com (2603:10a6:102:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Tue, 12 Jul 2022 16:11:51 +0000 Received: from VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a1:cafe::fc) by FR3P281CA0097.outlook.office365.com (2603:10a6:d10:a1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.5 via Frontend Transport; Tue, 12 Jul 2022 16:11:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT059.mail.protection.outlook.com (10.152.19.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Tue, 12 Jul 2022 16:11:50 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Tue, 12 Jul 2022 16:11:50 +0000 Received: from 6b56f019d017.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4468AEDE-C3CB-4B57-A6C5-66ADC7E96EF2.1; Tue, 12 Jul 2022 16:11:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6b56f019d017.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 12 Jul 2022 16:11:43 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB4333.eurprd08.prod.outlook.com (2603:10a6:803:101::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 16:11:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 16:11:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59091a44-01fd-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Vau/Au6jZD1XtPxe0NEvqKgwooZDT9dBK9+D1KYQ4de4v/ormMIfAW4qhfUVr1qmVNH8Xj6dQV4qjyFW4IGlRx/fi6nvAYKRkgDTHdOmWKh4QspODT6I4f0M8VA08PQ2U/36g6psiYXHALQeTn2bQGg9km9Hf+UUjK46grsKCG1TOUoew6PM286Z6I115quBiFYzKHosUkv4e+IDpncePmC+of1u9TUemZErqKzoxDY1NjA9o7pZG54UtZw40QFu8WL9CkFbS6N3RwyCbns/rNd7FGjKdurv6cEOvqWPCNPH3rHVhQmHUfP+4x3xkJpgsv9fA3uPkklgHKCUEQYpKg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CES0Gwh0Er6rznp0kvGhD+XyPAeLoOzzuhOllBhqAhw=; b=KUVWRXK7PDu4E/LV2XDAKW1D1b+UDeht+J5n2oyK5/VxWJTzeppFkx3lv18pSfBHx74s0rM3WQPsArx3sehFKJxRX6lQqCIZSo7qchE3fpJd8ZoSuW0YZ1GehKzpRry+3Pzucd5K0aLpHsLoX1w/QGfY3VMo9tmhc9tpd32FbFmWLsUMZBIC8FUo0CRcJQYQj/WKRXimUeTDZjcftVg6Wbc87bibDZxDQO/WcxhaXF2C1SiuIpDNhjbton0af+DbOlc9YZHj7r/BaRqnQVB9yPecCih6ahjUED1DpMXPLkckAhhO8eCeHHDHVqISINP+Lv3wqu3tlmcwgZtBJ9WtYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CES0Gwh0Er6rznp0kvGhD+XyPAeLoOzzuhOllBhqAhw=; b=3gxWEPHKklxFKIvcijSAq/FpC81oe5vQqo2iXTWEup1WZIvew4hM18Ae4ZSGUcLfWrxthw8gWnonP0niZwCOlkuFRic4lGFlKe852wpC9MOQOBgPg2mvJEyMfaXol7ea59qgm220exfBbAR4mXq2+6FMUyHlNL40INI4Pe5piuc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c4d3c120439d3d93 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MGgPOjuG/xKqG3MgiDul6KuMcl3oUvEIsd95b4cqlDh4lXQKo79abLNejIGsZNZrhHIu+BNajGFdCNqxQ1IU0N61l2+eKDqF0p3o2ndYMWVJKrzy2YwKGijEmF29Zpi7QkUBWjD5oF3sCpUp7TAVDieV8DMg4g1fcQFFaHnV0Va+WxHObXdo50hHeCPYG8ARCl4wnlfwULCgKA3BfQBJiIDzaL2uyp+wOtDMZCL6f9cI9yfe5CQuX2oTJUjiK0Z7nM28mncWW7EOchj5/vn9wJLjmLI8H9QNHR6R5Wy8nMXYvsNkv+D6ltFzOF5W1CL7JxUQg2BYGAX8v8JaQA8nvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CES0Gwh0Er6rznp0kvGhD+XyPAeLoOzzuhOllBhqAhw=; b=g1H6lDrJYhA/T1FMJea5pOkkrx8aaI7O/0zB22OuaL/NUAdLcsq90Gz9lg/dU7MpK6VGP5wz2Ycm9C8Jpf3lGVF2mQZoGRIBazhocnybqEICcLlplU/WUCuBTbCl8v1YBm8242sMJoGe68oX0lq5b3L5oT0zBFR5KLSXCOsqM06sIA9aP1BHpA0U797n6AOC+RXuJf1QYtjBTF0O8eD7NkxuytIn1GqgidM46/MuE37emQMr+NKLvcZy9EwBMH+jnkVAyZ9C01Qqry83JvWLHwwWz1Z+RmlN/SMoqjn+cF5WmWLA3WryR3PXQFgBCXDbGY0ic03tDBW93i6dOdjSbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CES0Gwh0Er6rznp0kvGhD+XyPAeLoOzzuhOllBhqAhw=; b=3gxWEPHKklxFKIvcijSAq/FpC81oe5vQqo2iXTWEup1WZIvew4hM18Ae4ZSGUcLfWrxthw8gWnonP0niZwCOlkuFRic4lGFlKe852wpC9MOQOBgPg2mvJEyMfaXol7ea59qgm220exfBbAR4mXq2+6FMUyHlNL40INI4Pe5piuc= From: Bertrand Marquis To: Brad Churchwell CC: "xen-devel@lists.xen.org" Subject: Re: Xen on rk3399 Thread-Topic: Xen on rk3399 Thread-Index: AQHYlaRzw0VI/DSwq0Ot3R+564rcea161i+AgAAPUoCAAANZAA== Date: Tue, 12 Jul 2022 16:11:41 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 500458ca-3549-4549-f0bb-08da64213ac1 x-ms-traffictypediagnostic: VI1PR08MB4333:EE_|VE1EUR03FT059:EE_|PR3PR08MB5658:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mC6M7xsyDIeIEpUQ3Ca6XRjo4WpdlyA95mtgE5KHP417wNH58S1z4P5Dymoq/zzscVmUluGdot3WkHCUHL1Kz1JYOujg39S7MsWO7b5dMrt4D2od+KiBD0PgvoSVnMTNPCwaRTFvRN3CM9VXwbPP9BWztlz4n6wHPeb9s05d1ggCPreSeYFJQJgrQGsNUVF846OvhuL/gWJihZpSnnzC8ncxXxDEer+p0T/L0XI1csZGAKq4F1BEX8dSDnC5lQMvFeSN13yMG7yIXTBtaQFni7s/lQ9FGl3wBCfeBzP/FD5y6DN99/mdwQ1uo5UzrS5rF6Uh4zipeHl3JItfAdkJtTC5T+gT/NrGuqudM9H+E+uTuXNC6kq4cdv2W3Cp9OolHi1EgYV/PEmELRSlZOBRU2pWhu3uowaiWaODSbZRfa0S/teDEIViLEH2hpF/g26SAaAKH7Or/6dDTnz9U3KFE47dWv14GJjo+fwEY0VMqMYKweG/t05VYuwdC4JGy9RZGALPVkWVhC1t3qUzdBjhqct6LVsz71iiNcHmzDR2jnt8iDz4BeyQeg6RUbzrymb1bWWM4TyzqUNBaqA/YcFSFlnJqo6TP3nR6OIjZGFgYjmhFGB70GUMcK20S+TzqKYMty61MovoXgiiHuSSUzxckyeSDFN2kMBzxOTTZZ1RPElpylpxPzCQx0gaFD+5AkSf3Jce9FRcbdwqAPlWpeTfznYtddBQoklnBwgIQtjKK+WD1WtzbrOGD6Pn6QsoG665DH2S/FsRjCkTmWIXcD55NIxt5D0a82ydJyqHNMdhcfWK80cHClXcVQ/4UrRHa0ZuGfSEWIqtWDUmBRGsMfy0Gq11XB5esat17CQqzkzdFgY= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(136003)(366004)(76116006)(8936002)(2906002)(316002)(4326008)(6916009)(86362001)(83380400001)(7116003)(66446008)(66556008)(66476007)(91956017)(66946007)(8676002)(64756008)(5660300002)(6506007)(38070700005)(186003)(26005)(36756003)(6512007)(2616005)(71200400001)(6486002)(122000001)(38100700002)(33656002)(478600001)(41300700001)(53546011)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <0BEB69D6D0B0AF4A8503B22AC1213E1C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4333 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ab755a7f-d747-4365-c75a-08da64213521 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8i8RSaUXZXfON2F8yWiLiXO94ios5/zlm2fqFFa12vQr1m6flQ6sOtMoUGL1EHLjqKHWU7QvjoQQ04nA06nTsTSZzKtQY3/US9/PyJXADkGm/Pp6S0BU4yqieZ0oGfnH9fZDMD4a2EGhVKt1i7xWBcpkeuXghChkHiiaFHpsmHXoUxe3bXptMh2F9rKX59ThcYAo+HLS10ZUIbJlcMsUG/J3/vW9kkspt8mHuhre5KHj1gOCg1RCoPSAap7BabUlXux5GJWUZgN8v62VfXRocQmQbO6tAu7QD858kyDTNEbv5LWyenxEoKgZsoZ/YP9KxXoCxOIKLwznnDlRnlqsmNLeGGghSDaBqQ3qFFb0KosnTAMUBLl1E3GEib4DgIK4YR6a6p5KeoQ1Aa6exn8DWcDhxsde2tGbzKJdCFzcRtvXPL1VXtlIJ04VtzlgI+DJaZLJeGBrR7lMc9AC1oXUtDcz5xlyyZDsAxRkOXWOaRlhzq20dzKZjlbY6YMhnjPPJ3ViQMZQnFv3qHGf253oliEOq4Ofv7dosKM1Mxv6+v+NaC+9/Kqu+v9mnBvGLQ3Iosoht8djexIH1rdhFdJgNIAn9p0wjZ0IvrVPM5H+L9HeXe4hhlI1qnbYpR9LPlkwVROde36QTV4RsumMAwd1E7NYCJDkx3uiUsS+S1TPjK7XDs/FrNc3vHgF3ZN7DbSOs34P0lqtAOFeZWxH2cQUWPzySVtInD4T/RVuGou6C4KdoYKR/HAPIK66rezkRGTuryfQhcyrrUM8p3KKOn2s6nxtAZPo39tZ7HWd34zoYQqCXVF39fjpSayR+zuR4qSp X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966006)(36840700001)(40470700004)(8676002)(86362001)(40480700001)(316002)(478600001)(81166007)(82310400005)(36756003)(186003)(53546011)(6862004)(7116003)(2616005)(36860700001)(70206006)(33656002)(6506007)(4326008)(40460700003)(5660300002)(6486002)(356005)(47076005)(8936002)(336012)(2906002)(82740400003)(70586007)(6512007)(41300700001)(26005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 16:11:50.7271 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 500458ca-3549-4549-f0bb-08da64213ac1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT059.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5658 Hi Brad, > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: > > Hi Bertrand, > > Thanks so much for the quick response! > > I should have mentioned previously that this device tree and kernel Image= (5.15.16) does boot properly with the rootfs without XEN. The interrupt er= rors are only present when booting with XEN. > > These are custom boards and they do have usb c, however we are unable to = boot from usb as it doesn't receive power. We currently only use the usb t= o flash u-boot to spi which requires us to use a separate power adapter. Th= ese boards get power and networking through a custom backplane and interfac= e with the backplane via a sata style justice (I'm not sure what the proper= terminology would be here). > > Since I cannot boot to rootfs with XEN, I'm unable to show the device tre= e there. The only bit that I added to accommodate XEN is this bit here: > > chosen { > stdout-path =3D "serial2:1500000n8"; > bootargs =3D "hmp-unsafe=3Dtrue"; > xen,dom0-bootargs =3D "console=3Dhvc0 earlyprintk=3Dxen clk_ignore_un= used root=3D/dev/nvme0n1p2 rw init=3D/sbin/init rootwait rootfstype=3Dext4 = ignore_loglevel"; > modules { > #address-cells =3D <2>; > #size-cells =3D <2>; > > module@1 { > compatible =3D "xen,linux-zimage", "xen,multiboot-module"; > reg =3D <0x0 0x03F80000 0x0 0x01aa8008>; > }; > module@2 { > compatible =3D "xen,linux-initrd", "xen,multiboot-module"; > reg =3D <0x0 0x06000000 0x0 0x02000000>; > }; > }; > > }; > > The gic declaration is in the vanilla rk3399.dtsi file and hasn't been mo= dified: > > gic: interrupt-controller@fee00000 { > compatible =3D "arm,gic-v3"; > #interrupt-cells =3D <4>; > #address-cells =3D <2>; > #size-cells =3D <2>; > ranges; > interrupt-controller; > > reg =3D <0x0 0xfee00000 0 0x10000>, /* GICD */ > <0x0 0xfef00000 0 0xc0000>, /* GICR */ > <0x0 0xfff00000 0 0x10000>, /* GICC */ > <0x0 0xfff10000 0 0x10000>, /* GICH */ > <0x0 0xfff20000 0 0x10000>; /* GICV */ > interrupts =3D ; > its: interrupt-controller@fee20000 { > compatible =3D "arm,gic-v3-its"; > msi-controller; > #msi-cells =3D <1>; > reg =3D <0x0 0xfee20000 0x0 0x20000>; > }; > > ppi-partitions { > ppi_cluster0: interrupt-partition-0 { > affinity =3D <&cpu_l0 &cpu_l1 &cpu_l2 &cp= u_l3>; > }; > > ppi_cluster1: interrupt-partition-1 { > affinity =3D <&cpu_b0 &cpu_b1>; > }; > }; Xen is not supporting PPI partitions. I also saw that your booting using SMP unsafe so all core are enabled by Xe= n. Right now big/little is not supported by Xen and here you might have some i= nterrupts in your system which can only occur on some specific cores. I would suggest to try the following: - only boot enable in your dtb the cores with the same type than the boot c= ore - check in your device tree which devices are assign to the ppi_cluster not= available and disable them This kind of configuration will be tricky to handle so it will depend on wh= ich devices have interrupts that can only be fired on one cluster type. Sorry but I cannot right now check in the device tree and do those checks m= yself but if you do get the idea send back a mail :-) Cheers Bertrand > }; > > I've attached the device tree and include files just in case you'd like t= o take a look at those. > > Thanks so much for your help! I've been at this for weeks with very littl= e progress. > > Cheers, > Brad > > > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis wrote: > Hi Brad, > > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > > > Hello, > > > > I've been trying to get Xen to boot dom0 with my kernel for weeks on an= rk3399 based board and thought I'd reach out for help. It looks like eithe= r Xen is not properly recreating the device tree or the interrupt controlle= r is just failing. The hypervisor boots but falls to initramfs because it c= annot find the root device (nvme on pcie). Any help would be greatly apprec= iated. Here is the complete boot log > > From the logs you have an issue with the interrupt controller and the fac= t that your NVME is behind PCIE and as such depends on ITS is probably not = helping. > > I would suggest to try to boot on usb as root fs for a try. > > Also it could be useful to compare the device tree on xen and without xen= to understand what is going on (using /proc/device-tree). > > Xen seems to be ok but Linux is not happy with interrupts and is showing = several issues around this area on your logs. > Could you show us an extract of your device tree around the gic declarati= on ? > > Cheers > Bertrand > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. > IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:24:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:24:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365846.596187 (Exim 4.92) (envelope-from ) id 1oBIgS-0002CO-Mw; Tue, 12 Jul 2022 16:24:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365846.596187; Tue, 12 Jul 2022 16:24:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIgS-0002CH-KL; Tue, 12 Jul 2022 16:24:24 +0000 Received: by outflank-mailman (input) for mailman id 365846; Tue, 12 Jul 2022 16:24:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIgR-0002CB-Hj for xen-devel@lists.xen.org; Tue, 12 Jul 2022 16:24:23 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15f17105-01ff-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:24:21 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id os14so15261909ejb.4 for ; Tue, 12 Jul 2022 09:24:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15f17105-01ff-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AiJHgP4SktI6IFUN/kbFU1k/R7pEHyYR+prIGIb4Npc=; b=CJY7dbh7T3nSEVWsM7bNQRU5AtEkI6xMJ4Bg4xdnuOtYlga2AUKdkenCUW9LNHLrVc OjXX48wT6FUrKwYgzDfhb+xtB+UL2e3Z7JXO+sNKZ1KO74pylLSvUDJd6b371l7lp3f7 cjlSN/dJsKPIxnpxbcqShO7FnX8hGZ1IsFUxj3w1jz6to0+qPKsjqnui/+WMbGbcuM1L cfPrIfJI2EZgNUbIX81xDaWjrsBpWTQuRW4RfTY6OmjR38RPDfql65i6FGWFLTiNSvH7 LSotuL0iitNTEXGQ+nUq5SyYVmxPcGSXJ+fnOQYJzrunsklQ22L7iD/QhrUMlfRl//dh duow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AiJHgP4SktI6IFUN/kbFU1k/R7pEHyYR+prIGIb4Npc=; b=CsA/Y3q2FKDzvvr20l6U0sxSiOQ9285bZOfrl4wh9yCj/vwcWtIRcHtRZ83kjueIcJ kBjv7mEVhPh9thNXm5MAx2qeqO1NS/ozb5aSHrM17kDzzdz4ngmYDhYbFA3aUrkm8mZ3 9k00J5SbE3KTsWPQCjJLwPrIHIInPvaJ3ijyQRMTwxXu+uuUGOdNdIkJfF2dW0Ajzwuw j8xPFrBwyLndHpbkpMC8cm73Wr52ekvT9YhP3tAtWb2wQlgPvjiNqn3uq0k/TFO8zeli rjYUb2FlwJcublrL0yAh3OOwSaGt+Wb9dXde9OcBaNsAukjTqDb7oH1gLFkCICIt4CjO 61pA== X-Gm-Message-State: AJIora9RG88zN4z0fYn+60NlCmyHYpjDOHK1x/E2IG+7/wrxLKd8Ct0o OHXuoCuEu33/F1YuCfCOaOrdAW/Kt5/UGsW+sSaKdg== X-Google-Smtp-Source: AGRyM1t3Xf70OpvmxqYXd2aPfh3ujeha70hYNlzCE63cSwc2Os2yq3Ua++h3pGdHoPzx68zfghZjEGt+BOG/aSnomnw= X-Received: by 2002:a17:907:2d8a:b0:722:e35b:695 with SMTP id gt10-20020a1709072d8a00b00722e35b0695mr25508088ejc.470.1657643061166; Tue, 12 Jul 2022 09:24:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Brad Churchwell Date: Tue, 12 Jul 2022 11:24:10 -0500 Message-ID: Subject: Re: Xen on rk3399 To: Bertrand Marquis Cc: "xen-devel@lists.xen.org" Content-Type: multipart/alternative; boundary="000000000000d362ef05e39e1951" --000000000000d362ef05e39e1951 Content-Type: text/plain; charset="UTF-8" Hi Bertrand, I believe I understand, but just to clarify, should I leave the ppi-partitions block in rk3399.dtsi as is and disable the little cores, or should I also modify that block? Brad On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis wrote: > Hi Brad, > > > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: > > > > Hi Bertrand, > > > > Thanks so much for the quick response! > > > > I should have mentioned previously that this device tree and kernel > Image (5.15.16) does boot properly with the rootfs without XEN. The > interrupt errors are only present when booting with XEN. > > > > These are custom boards and they do have usb c, however we are unable to > boot from usb as it doesn't receive power. We currently only use the usb > to flash u-boot to spi which requires us to use a separate power adapter. > These boards get power and networking through a custom backplane and > interface with the backplane via a sata style justice (I'm not sure what > the proper terminology would be here). > > > > Since I cannot boot to rootfs with XEN, I'm unable to show the device > tree there. The only bit that I added to accommodate XEN is this bit here: > > > > chosen { > > stdout-path = "serial2:1500000n8"; > > bootargs = "hmp-unsafe=true"; > > xen,dom0-bootargs = "console=hvc0 earlyprintk=xen clk_ignore_unused > root=/dev/nvme0n1p2 rw init=/sbin/init rootwait rootfstype=ext4 > ignore_loglevel"; > > modules { > > #address-cells = <2>; > > #size-cells = <2>; > > > > module@1 { > > compatible = "xen,linux-zimage", "xen,multiboot-module"; > > reg = <0x0 0x03F80000 0x0 0x01aa8008>; > > }; > > module@2 { > > compatible = "xen,linux-initrd", "xen,multiboot-module"; > > reg = <0x0 0x06000000 0x0 0x02000000>; > > }; > > }; > > > > }; > > > > The gic declaration is in the vanilla rk3399.dtsi file and hasn't been > modified: > > > > gic: interrupt-controller@fee00000 { > > compatible = "arm,gic-v3"; > > #interrupt-cells = <4>; > > #address-cells = <2>; > > #size-cells = <2>; > > ranges; > > interrupt-controller; > > > > reg = <0x0 0xfee00000 0 0x10000>, /* GICD */ > > <0x0 0xfef00000 0 0xc0000>, /* GICR */ > > <0x0 0xfff00000 0 0x10000>, /* GICC */ > > <0x0 0xfff10000 0 0x10000>, /* GICH */ > > <0x0 0xfff20000 0 0x10000>; /* GICV */ > > interrupts = ; > > its: interrupt-controller@fee20000 { > > compatible = "arm,gic-v3-its"; > > msi-controller; > > #msi-cells = <1>; > > reg = <0x0 0xfee20000 0x0 0x20000>; > > }; > > > > ppi-partitions { > > ppi_cluster0: interrupt-partition-0 { > > affinity = <&cpu_l0 &cpu_l1 &cpu_l2 > &cpu_l3>; > > }; > > > > ppi_cluster1: interrupt-partition-1 { > > affinity = <&cpu_b0 &cpu_b1>; > > }; > > }; > > Xen is not supporting PPI partitions. > I also saw that your booting using SMP unsafe so all core are enabled by > Xen. > > Right now big/little is not supported by Xen and here you might have some > interrupts in your system which can only occur on some specific cores. > I would suggest to try the following: > - only boot enable in your dtb the cores with the same type than the boot > core > - check in your device tree which devices are assign to the ppi_cluster > not available and disable them > > This kind of configuration will be tricky to handle so it will depend on > which devices have interrupts that can only be fired on one cluster type. > > Sorry but I cannot right now check in the device tree and do those checks > myself but if you do get the idea send back a mail :-) > > Cheers > Bertrand > > > }; > > > > I've attached the device tree and include files just in case you'd like > to take a look at those. > > > > Thanks so much for your help! I've been at this for weeks with very > little progress. > > > > Cheers, > > Brad > > > > > > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis < > Bertrand.Marquis@arm.com> wrote: > > Hi Brad, > > > > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > > > > > Hello, > > > > > > I've been trying to get Xen to boot dom0 with my kernel for weeks on > an rk3399 based board and thought I'd reach out for help. It looks like > either Xen is not properly recreating the device tree or the interrupt > controller is just failing. The hypervisor boots but falls to initramfs > because it cannot find the root device (nvme on pcie). Any help would be > greatly appreciated. Here is the complete boot log > > > > From the logs you have an issue with the interrupt controller and the > fact that your NVME is behind PCIE and as such depends on ITS is probably > not helping. > > > > I would suggest to try to boot on usb as root fs for a try. > > > > Also it could be useful to compare the device tree on xen and without > xen to understand what is going on (using /proc/device-tree). > > > > Xen seems to be ok but Linux is not happy with interrupts and is showing > several issues around this area on your logs. > > Could you show us an extract of your device tree around the gic > declaration ? > > > > Cheers > > Bertrand > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > --000000000000d362ef05e39e1951 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bertrand,

I believe I understand, bu= t just to clarify, should I leave the ppi-partitions block in rk3399.dtsi a= s is and disable the little cores, or should I also modify that block?

Brad

On Tue, Jul 12, 2022 at 11:11 AM Bertrand Ma= rquis <Bertrand.Marquis@arm.= com> wrote:
Hi Brad,

> On 12 Jul 2022, at 16:59, Brad Churchwell <brad@cachengo.com> wrote:
>
> Hi Bertrand,
>
> Thanks so much for the quick response!
>
> I should have mentioned previously that this device tree and kernel Im= age (5.15.16) does boot properly with the rootfs without XEN. The interrupt= errors are only present when booting with XEN.
>
> These are custom boards and they do have usb c, however we are unable = to boot from usb as it doesn't receive power.=C2=A0 We currently only u= se the usb to flash u-boot to spi which requires us to use a separate power= adapter. These boards get power and networking through a custom backplane = and interface with the backplane via a sata style justice (I'm not sure= what the proper terminology would be here).
>
> Since I cannot boot to rootfs with XEN, I'm unable to show the dev= ice tree there. The only bit that I added to accommodate XEN is this bit he= re:
>
> chosen {
>=C2=A0 =C2=A0 =C2=A0stdout-path =3D "serial2:1500000n8";
>=C2=A0 =C2=A0 =C2=A0bootargs =3D "hmp-unsafe=3Dtrue";
>=C2=A0 =C2=A0 =C2=A0xen,dom0-bootargs =3D "console=3Dhvc0 earlypri= ntk=3Dxen clk_ignore_unused root=3D/dev/nvme0n1p2 rw init=3D/sbin/init root= wait rootfstype=3Dext4 ignore_loglevel";
>=C2=A0 =C2=A0 =C2=A0modules {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D <2>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D <2>;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@1 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D "xe= n,linux-zimage", "xen,multiboot-module";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x03F80= 000 0x0 0x01aa8008>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@2 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D "xe= n,linux-initrd", "xen,multiboot-module";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x06000= 000 0x0 0x02000000>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
>=C2=A0 =C2=A0 =C2=A0};
>
> };
>
> The gic declaration is in the vanilla rk3399.dtsi file and hasn't = been modified:
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gic: interrupt-controller@fee00000 {<= br> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatibl= e =3D "arm,gic-v3";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#interrup= t-cells =3D <4>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-= cells =3D <2>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cel= ls =3D <2>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ranges; >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0interrupt= -controller;
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D &= lt;0x0 0xfee00000 0 0x10000>, /* GICD */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0<0x0 0xfef00000 0 0xc0000>, /* GICR */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0<0x0 0xfff00000 0 0x10000>, /* GICC */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0<0x0 0xfff10000 0 0x10000>, /* GICH */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0<0x0 0xfff20000 0 0x10000>; /* GICV */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0interrupt= s =3D <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0its: inte= rrupt-controller@fee20000 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0compatible =3D "arm,gic-v3-its";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0msi-controller;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0#msi-cells =3D <1>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0xfee20000 0x0 0x20000>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ppi-parti= tions {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0ppi_cluster0: interrupt-partition-0 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&cpu_l= 0 &cpu_l1 &cpu_l2 &cpu_l3>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0};
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0ppi_cluster1: interrupt-partition-1 {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&cpu_b= 0 &cpu_b1>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0};
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};

Xen is not supporting PPI partitions.
I also saw that your booting using SMP unsafe so all core are enabled by Xe= n.

Right now big/little is not supported by Xen and here you might have some i= nterrupts in your system which can only occur on some specific cores.
I would suggest to try the following:
- only boot enable in your dtb the cores with the same type than the boot c= ore
- check in your device tree which devices are assign to the ppi_cluster not= available and disable them

This kind of configuration will be tricky to handle so it will depend on wh= ich devices have interrupts that can only be fired on one cluster type.

Sorry but I cannot right now check in the device tree and do those checks m= yself but if you do get the idea send back a mail :-)

Cheers
Bertrand

>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
>
> I've attached the device tree and include files just in case you&#= 39;d like to take a look at those.
>
> Thanks so much for your help! I've been at this for weeks with ver= y little progress.
>
> Cheers,
> Brad
>
>
> On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis <Bertrand.Marquis@arm.com&= gt; wrote:
> Hi Brad,
>
> > On 11 Jul 2022, at 19:38, Brad Churchwell <brad@cachengo.com> wrote:
> >
> > Hello,
> >
> > I've been trying to get Xen to boot dom0 with my kernel for w= eeks on an rk3399 based board and thought I'd reach out for help. It lo= oks like either Xen is not properly recreating the device tree or the inter= rupt controller is just failing. The hypervisor boots but falls to initramf= s because it cannot find the root device (nvme on pcie). Any help would be = greatly appreciated. Here is the complete boot log
>
> From the logs you have an issue with the interrupt controller and the = fact that your NVME is behind PCIE and as such depends on ITS is probably n= ot helping.
>
> I would suggest to try to boot on usb as root fs for a try.
>
> Also it could be useful to compare the device tree on xen and without = xen to understand what is going on (using /proc/device-tree).
>
> Xen seems to be ok but Linux is not happy with interrupts and is showi= ng several issues around this area on your logs.
> Could you show us an extract of your device tree around the gic declar= ation ?
>
> Cheers
> Bertrand
>
>
> IMPORTANT NOTICE: The contents of this email and any attachments are c= onfidential and may also be privileged. If you are not the intended recipie= nt, please notify the sender immediately and do not disclose the contents t= o any other person, use it for any purpose, or store or copy the informatio= n in any medium. Thank you.
> <rk3399-zaku.dts><rk3399-zaku.dtsi><rk3399.dtsi>

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.
--000000000000d362ef05e39e1951-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:34:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:34:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365857.596198 (Exim 4.92) (envelope-from ) id 1oBIqO-0003nn-NL; Tue, 12 Jul 2022 16:34:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365857.596198; Tue, 12 Jul 2022 16:34:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIqO-0003ng-IF; Tue, 12 Jul 2022 16:34:40 +0000 Received: by outflank-mailman (input) for mailman id 365857; Tue, 12 Jul 2022 16:34:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIqM-0003nY-Hh for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 16:34:39 +0000 Received: from sonic316-54.consmr.mail.gq1.yahoo.com (sonic316-54.consmr.mail.gq1.yahoo.com [98.137.69.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8341a92d-0200-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 18:34:36 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 16:34:33 +0000 Received: by hermes--production-bf1-58957fb66f-88chf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 692ae7703da13e268bead15e283ae6fb; Tue, 12 Jul 2022 16:34:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8341a92d-0200-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657643673; bh=9IPvrhsDCI1C7tNIqLBIkt5VSUNjrL3qx3hjUwV1AVc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=mkQn2ruLTkVnkaYhPKMI8A1lymmgrtP3aERlUAE5AfykX9IB4aVdLdozjGH/jXZ60eYNMa8ubOKn8kukli/tfeoJRvZbESUxZClkAFHldkc/7+GfUHkWU0kFwWaE+Sk/sTklS5ARwMZ3q3v2Mp91aKVKnZltz9jBaW2FUd1Rf8k4B61Ye4sCnkXfe21XWK6k1ZDTdRM+SMdc+L1pwWDMtCQCd6zWcWIj8B6rU5nVsPd4WKmJ8AguhM3YFlz/NPYsICLWLUQ63GzMwx6WsfGY2kRuWP25RlIBG+8VlUayCrklhsvbpL6lJp/2X9Mjd5KeEZS+6EFiesKRmZAvp0OP4w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657643673; bh=wKSWEjne/d5RFVv8EG+JgkENbFezPjdV65OY/2OPOwa=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=GCJjBW+1cz0+qw690ie/dsV3VntOKOmkoSlraIq+83Tuyx3j/5nCuGLFykvuYUpH+wUpBJFfsOgNN4TcAWy41tQRFvt+Qelmf0e3cCpZgOCPb3YOvxSTiJvVqvEg4gW74AKPsUXUo9S5u7xyJs/H1vT7lNIQcmDnPv/8rvEZA6XGJeqHS8nXPdLHjZRKAQWgX0iNeRHdrX6NRoCWeoi+HT8usweFV1XbHTOOxrDPCTWr+7JlQXi5N4k5KwpHRo8mzvIRuMfDR8nXF3RzUyNIna1+nAEwV8up7GGnDLWyHiJk4n7pscqYoBiQhlGxhmUW5ojkhzPkMWAHpUgmmVVEZA== X-YMail-OSG: 0UPu97wVM1muZrI_X_I3OFm.UHdm2L8gFk9nuSipTX6bcrrKj4JP6Eaff37VDcS tIkeCtA1MEboyz2x4S4q4X9T31UvZQBn2foYA7U.in3RoJofqjIL2KS0XPkMavz124tniTumj.lA HjWk3ck7blLCxbNSUSadsAPUbiYhGP5Gb4Itd52ePYftyMYssvkobshcjJdJqR_WVsZWogQFZQwd tzMMF8ka.q0gCvWtydEqnVH_t4aRA8sApHZrq3ElufWCaygI9KTA39hdAd4BHbUI35ompFFkKuHA 098uFwpDVxDz_HihwVnhapQIgRbgdkAwWc.0dBOa7xfCuachjBndOYjTqzwm82zgr9h_hggYghv0 DEE5NlUTTZm..RJGtcuQyO71ZLN0VA5nW2VjiyejvtibsNylIWpScu7yJOVkwqhS15UlP1mIkM.s XY9r7PadGcICC6MocUMYwDQGVKO8usnc.7igW4MVg_84P7wW5L7RFW2GR7o08O.wcI8rcill67qH 8t6Vx2Q6OZXLA9RyxU0ItBR5rUpsEiZ2e2sFDtO2ukaM7ETL7TO9YgjOAe5K3MD6.txTeaDEGbK8 hx2v_l3.REgFU7tEhquvg9rEGzFDRRyu1AwDD8BlQDIcCXwo3NbRFgUhW2pvLRSvoOS1dWRTjE1J w6BXuWlkfFnt_eupyimFCL_V.2MRbIMOxUQM1XZQtKHFwbiSW8YmFnmWz4PJcNPIeNrOwO44KHwm lGk_9mfMfIFwCvMp9OYuhlHTa2BM0_T56Vze5PN8sBzRo633rgFLuXlgCdxbgLTgxwmQs1h2UVXM q4ZCCvWbmg851J5MpofSLBkCUNHk7mK3HFh7qjCdqJlKS22t8ArgNjIL59iRgisc3VcvKD48ES7a 7ICfi4ikrNgnY7fbnrHFSM44e2z5ITAvY.vMm8ntCRY40mLxuWogJhQhdukIGlp70m2JSQtag3r4 dyMLo1X_OYW28WlFA0w1V_MCVfDUmEIl2sotInHefhSjmw5Jihwl9h9e6QELF1jw_79anVoOhfrV 0w7hyXPhYOVbaM0CowtInk1XaRqlamepdMBaeHybCl64sdXqSv5RPcUhLxKYyjgR_NvjWrFj9yiG 2QiYmg_5gbeDXrJHAcQW7kc4CbS8CBXtqLV8dholK0WWmR7QSiPkp5U6UVkh0SNECJ4GnJFEhab5 s7fo1W4CqenR398nJRTSRDEI0gAzBxLB9F6ZOnLr96Elu1XAtZxRh_nVRnu8zhzkSWLAqpBveH5e 9.GX2_zdQkBWSM6UjJ6msOYlcJuiO6DKlB_q3_MGMrQjwlpxPElOECd_h9pu1KwkiOMfNaDb8TGY wM5yPmUZrVvZMqo35d.1rzaNtqNnb5y3oguulw9JW.VlLaXXhxHZ4CxOYsyTopcUuFMMoWZC5Z9D X.7qTzRooyvR8FQqH__68jT3FvD91rhls9T0f4Vy8QWuAhCK4oCK7FTBdIZz8FXH8JDRuUEXYThA hHQgyB961gfVi0icoChz3YAUW2CQa.bTntGEtYhS3ShENdFzaG_k5sWpk2p6sSyFl2iE.gHWEv.K nU_Vpk_Avjpf1PS7Vy7aNZuE0kTeC1SCDxDPC25yMFz3VbrPG5kqYA0B6FG68_HLFnZpx_WQJSCK bAvVUB6Lmy_T0M.ELUUId4EA0iWlP2XbO07GBcJYdZLKhIkZF66GcoeK0WCw2PpiyMArCXU7VH2y 4TwHmZgB.pk2zmubg2CbRCb.nrabOGYvgNvhMdirkK9m1ea_dcRUDHCrJ.9u6dRVlQSpawZec6wa AxLgy.B1mxRb8ZqhZlZwHfhwJKj8bxkwPcUsRiNyrZlCgOaXNZ8X65MbOtHwe8skFjghodag_k.P RE0nlhbOKRetMu3TDD0VVMlfv2VpAbZTWqw1waZ6tfjIySLC832YNe1o4qhtvDh5lH3_pmG321c4 s5uZN9FHvrWA7m71jSs9bMiig7WYhI.eukhSpFn1KDIHSaorPVjRf.qPWRB4gx61f5JXEPjEVMR5 iyHgs2dAXJRb0vMQKAE4wdIVdz4baYONpth7tonr.LaumuSFG8uM4oMNNzqVQandIgbpOjSInaZs vW2bt_NwDVVCxZX_Ra2L3.OMiEookM0TFc_ip6dE.YnP5cgKj9v9dRWRe5KflhB_hPiIsK8jk16s .U_7bV6dH_aXAaPoWLWHhY7m4J8sLTu55dtXoUo6FEQI2xEYCJ179Svj63I1.F_8rWSwUgVdcLoO x74jLDWAwhrZ9 X-Sonic-MF: Message-ID: <08691a7e-8af6-00d8-4bd3-41b8c44536e1@netscape.net> Date: Tue, 12 Jul 2022 12:34:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US To: Jan Beulich Cc: Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , lkml , "xen-devel@lists.xenproject.org" , Borislav Petkov References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <016d281b-7e40-f1bd-66ee-c19c3cc56efe@suse.com> <4e099e2d-e429-252b-ceeb-678066d85e61@netscape.net> <6afa42fd-469d-5b08-1688-5af8a3c9d8fa@suse.com> <8011dff1-6551-898f-7e37-38ede106e2f4@netscape.net> <45fd7ade-61fe-18fa-aacc-ed80fdf3fb8d@suse.com> <3b228e55-53b6-beb8-7822-af03e65a078b@netscape.net> <7ff738f2-716f-f42a-2f92-3a7d94722d33@suse.com> From: Chuck Zmudzinski In-Reply-To: <7ff738f2-716f-f42a-2f92-3a7d94722d33@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8347 On 7/12/22 11:30 AM, Juergen Gross wrote: > On 12.07.22 17:09, Chuck Zmudzinski wrote: > > On 7/12/2022 9:32 AM, Juergen Gross wrote: > >> On 12.07.22 15:22, Chuck Zmudzinski wrote: > >>> On 7/12/2022 2:04 AM, Jan Beulich wrote: > >>>> On 11.07.2022 19:41, Chuck Zmudzinski wrote: > >>>>> Moreover... (please move to the bottom of the code snippet > >>>>> for more information about my tests in the Xen PV environment...) > >>>>> > >>>>> void init_cache_modes(void) > >>>>> { > >>>>>     u64 pat = 0; > >>>>> > >>>>>     if (pat_cm_initialized) > >>>>>         return; > >>>>> > >>>>>     if (boot_cpu_has(X86_FEATURE_PAT)) { > >>>>>         /* > >>>>>          * CPU supports PAT. Set PAT table to be consistent with > >>>>>          * PAT MSR. This case supports "nopat" boot option, and > >>>>>          * virtual machine environments which support PAT without > >>>>>          * MTRRs. In specific, Xen has unique setup to PAT MSR. > >>>>>          * > >>>>>          * If PAT MSR returns 0, it is considered invalid and emulates > >>>>>          * as No PAT. > >>>>>          */ > >>>>>         rdmsrl(MSR_IA32_CR_PAT, pat); > >>>>>     } > >>>>> > >>>>>     if (!pat) { > >>>>>         /* > >>>>>          * No PAT. Emulate the PAT table that corresponds to the two > >>>>>          * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>>>          * This setup is also the same as the BIOS default setup. > >>>>>          * > >>>>>          * PTE encoding: > >>>>>          * > >>>>>          *       PCD > >>>>>          *       |PWT  PAT > >>>>>          *       ||    slot > >>>>>          *       00    0    WB : _PAGE_CACHE_MODE_WB > >>>>>          *       01    1    WT : _PAGE_CACHE_MODE_WT > >>>>>          *       10    2    UC-: _PAGE_CACHE_MODE_UC_MINUS > >>>>>          *       11    3    UC : _PAGE_CACHE_MODE_UC > >>>>>          * > >>>>>          * NOTE: When WC or WP is used, it is redirected to UC- per > >>>>>          * the default setup in __cachemode2pte_tbl[]. > >>>>>          */ > >>>>>         pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>>>               PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>>>     } > >>>>> > >>>>>     else if (!pat_bp_enabled) { > >>>>>         /* > >>>>>          * In some environments, specifically Xen PV, PAT > >>>>>          * initialization is skipped because MTRRs are > >>>>>          * disabled even though PAT is available. In such > >>>>>          * environments, set PAT to initialized and enabled to > >>>>>          * correctly indicate to callers of pat_enabled() that > >>>>>          * PAT is available and prevent PAT from being disabled. > >>>>>          */ > >>>>>         pat_bp_enabled = true; > >>>>>         pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > >>>>>     } > >>>>> > >>>>>     __init_cache_modes(pat); > >>>>> } > >>>>> > >>>>> This function, patched with the extra 'else if' block, fixes the > >>>>> regression on my Xen worksatation, and the pr_info message > >>>>> "x86/PAT: PAT enabled by init_cache_modes" appears in the logs > >>>>> when running this patched kernel in my Xen Dom0. This means > >>>>> that in the Xen PV environment on my Xen Dom0 workstation, > >>>>> rdmsrl(MSR_IA32_CR_PAT, pat) successfully tested for the presence > >>>>> of PAT on the virtual CPU that Xen exposed to the Linux kernel on my > >>>>> Xen Dom0 workstation. At least that is what I think my tests prove. > >>>>> > >>>>> So why is this not a valid way to test for the existence of > >>>>> PAT in the Xen PV environment? Are the existing comments > >>>>> in init_cache_modes() about supporting both the case when > >>>>> the "nopat" boot option is set and the specific case of Xen and > >>>>> MTRR disabled wrong? My testing confirms those comments are > >>>>> correct. > >>>> > >>>> At the very least this ignores the possible "nopat" an admin may > >>>> have passed to the kernel. > >>> > >>> I realize that. The patch I proposed here only fixes the regression. It > >>> would be easy to also modify the patch to also observe the 'nopat" > >>> setting. I think your patch had a force_pat_disable local variable that > >>> is set if pat is disabled by the administrator with "nopat." With that > >>> variable available, modifying the patch so in init_cache_modes we have: > >>> > >>>      if (!pat || force_pat_disable) { > >>>          /* > >>>           * No PAT. Emulate the PAT table that corresponds to the two > >>> > >>> Instead of: > >>> > >>>      if (!pat) { > >>>          /* > >>>           * No PAT. Emulate the PAT table that corresponds to the two > >>> > >>> would cause the kernel to respect the "nopat" setting by the administrator > >>> in the Xen PV Dom0 environment. > >> > >> Chuck, could you please send out a proper patch with your initial fix > >> (setting pat_bp_enabled) and the fix above? > >> > >> I've chatted with Boris Petkov on IRC and he is fine with that. > > > > That's great, I will submit a formal patch later today. > > > >> > >>> I agree this needs to be fixed up, because currently the code is very > >>> confusing and the current variable names and function names do not > >>> always accurately describe what they actually do in the code. That is > >>> why I am working on a patch to do some re-factoring, which only consists > >>> of function and variable name changes and comment changes to fix > >>> the places where the comments in the code are misleading or incomplete. > >> > >> Boris and I agreed to pursue my approach further by removing the > >> dependency between PAT and MTRR and to make this whole mess more > >> clear. > >> > >> I will start to work on this as soon as possible, which will > >> probably be some time in September. > > > > Good, I will look for your patches and try them out. > > > >> > >>> I think perhaps the most misnamed variable here is the  local > >>> variable pat_disabled in memtypes.c and the most misnamed function is the > >>> pat_disable function in memtypes.c. They should be named pat_init_disabled > >>> and pat_init_disable, respectively, because they do not really disable > >>> PAT in > >>> the code but only prevent execution of the pat_init function. That > >>> leaves open > >>> the possibility for PAT to be enabled by init_cache_modes, which actually > >>> occurs in the current code in the Xen PV Dom0 environment, but the current > >>> code neglects to set pat_bp_enabled to true in that case. So we need a patch > >>> to fix that in order to fix the regression. > >> > >> In principle I agree, but you should be aware of my refactoring plans. > > > > I will defer to you and stop working on this re-factoring effort, but I > > will prepare a formal patch to fix the regression later today. > > > > I do think Jan's point about respecting the administrator's "nopat" setting > > should also be considered. AFAICT, the "nopat" option in current code > > Yes, please add that, too. This was what I meant with "the fix above". > > > is also not being respected on the bare metal, and the patch to > > init_cache_modes with a force_no_pat variable is also needed to > > ensure "nopat" is respected on the bare metal, AFAICT. > > Hmm, I don't see how the PAT MSR will be written on bare metal when "nopat" > has been specified. > > I just tried it with a 5.19 kernel and it booted with the correct PAT > settings: > > [ 0.000000] x86/PAT: PAT support disabled via boot option. > [ 0.000986] x86/PAT: Configuration [0-7]: WB WT UC- UC WB WT UC- UC > > > Juergen OK, I understand. In init_cache_modes, if on Xen we read the PAT MSR to pick up the configuration Xen did, so on bare metal we will just read the configuration with PAT disabled. So "nopat" does work on bare metal. I do think Jan is correct that "nopat" does not work on Xen, though. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:36:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:36:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365865.596212 (Exim 4.92) (envelope-from ) id 1oBIsD-0004YY-E1; Tue, 12 Jul 2022 16:36:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365865.596212; Tue, 12 Jul 2022 16:36:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIsD-0004YR-9y; Tue, 12 Jul 2022 16:36:33 +0000 Received: by outflank-mailman (input) for mailman id 365865; Tue, 12 Jul 2022 16:36:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIsA-0004SJ-JF for xen-devel@lists.xen.org; Tue, 12 Jul 2022 16:36:31 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c46b52a1-0200-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:36:26 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIrq-0002mG-FT; Tue, 12 Jul 2022 16:36:10 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBIrq-0007mF-D5; Tue, 12 Jul 2022 16:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c46b52a1-0200-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=Fa3s5dAtrlN+DLV20CJW2zbDMvSCli1lAzcTpOYy9zs=; b=dXp0U1tlIJoxknA09+rPtVtcrH 2hbnWl1rBPGMaBG5Rtr/9pEOA9Z8nHdrZYv3sbANrLlui6dubT8TX1mY7syhGU4+UxBGK1ZpXwajs wS5o4j4HTCj3ajZqixaZ8V1KNCag+8nq5KOxUp4jxvEi7vAh3YU1lcXW5xWyZ6zOJqb4=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 407 v1 (CVE-2022-23816,CVE-2022-23825,CVE-2022-29900) - Retbleed - arbitrary speculative code execution with return instructions Message-Id: Date: Tue, 12 Jul 2022 16:36:10 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-23816,CVE-2022-23825,CVE-2022-29900 / XSA-407 Retbleed - arbitrary speculative code execution with return instructions ISSUE DESCRIPTION ================= Researchers at ETH Zurich have discovered Retbleed, allowing for arbitrary speculative execution in a victim context. For more details, see: https://comsec.ethz.ch/retbleed ETH Zurich have allocated CVE-2022-29900 for AMD and CVE-2022-29901 for Intel. Despite the similar preconditions, these are very different microarchitectural behaviours between vendors. On AMD CPUs, Retbleed is one specific instance of a more general microarchitectural behaviour called Branch Type Confusion. AMD have assigned CVE-2022-23816 (Retbleed) and CVE-2022-23825 (Branch Type Confusion). For more details, see: https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1037 On Intel CPUs, Retbleed is not a new vulnerability; it is only applicable to software which did not follow Intel's original Spectre-v2 guidance. Intel are using the ETH Zurich allocated CVE-2022-29901. For more details, see: https://www.intel.com/content/www/us/en/security-center/advisory/intel-sa-00702.html https://www.intel.com/content/www/us/en/developer/articles/technical/software-security-guidance/advisory-guidance/return-stack-buffer-underflow.html ARM have indicated existing guidance on Spectre-v2 is sufficient. IMPACT ====== An attacker might be able to infer the contents of arbitrary host memory, including memory assigned to other guests. VULNERABLE SYSTEMS ================== Systems running all versions of Xen are affected. Whether a CPU is potentially vulnerable depends on its microarchitecture. Consult your hardware vendor. For ARM and Intel CPUs, Xen implemented the vendor-recommended defaults in XSA-254 and follow-on fixes. Therefore, the Xen Security Team believes there are no further changes necessary on these CPUs. Administrators who deviated from the default mitigations are potentially affected and should re-evaluate their threat model. For AMD, CPUs from the Zen2 microarchitecture and earlier are potentially vulnerable. Zen3 and later CPUs are not believed to be vulnerable. The patches for Xen implement the IBPB-at-entry mitigation. This depends on the IBPB microcode distributed by AMD in 2018 as part of the original Spectre/Meltdown work. Consult your dom0 OS vendor. In addition to IBPB, "cross thread" safety is necessary. On Zen2 CPUs, Xen uses STIBP by default. On Zen1 CPUs, SMT needs disabling either in the firmware, or by passing `smt=0` on Xen's command line. On Fam15h CPUs, Cluster Multi-Threading needs disabling in firmware. Due to performance concerns, dom0 is excluded from IBPB-on-entry protections by default. This is because PV dom0 is trusted in most deployments. If your threat model model doesn't allow for dom0 to be treated specially, boot with `spec-ctrl=ibpb-entry` which will cause IBPB-on-entry protections to be applied to dom0 too. MITIGATION ========== There are no mitigations. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. For the 4.15 and 4.16 branches in particular, these patches depend on: - x86/spec-ctrl: Only adjust MSR_SPEC_CTRL for idle with legacy IBRS - x86/spec-ctrl: Knobs for STIBP and PSFD, and follow hardware STIBP hint - xen/cmdline: Extend parse_boolean() to signal a name match - x86/spec-ctrl: Add fine-grained cmdline suboptions for primitives which have been recently backported. xsa407/xsa407-?.patch xen-unstable xsa407/xsa407-4.16-*.patch Xen 4.16.x xsa407/xsa407-4.15-*.patch Xen 4.15.x xsa407/xsa407-4.14-*.patch Xen 4.14.x xsa407/xsa407-4.13-*.patch Xen 4.13.x $ sha256sum xsa407* xsa407*/* 0a6dea915dd760afc73c3f50f432422d2e853eecaf99e3cdeb2d6e0fb3ee71b1 xsa407.meta 8894b0dc8e8c0900560366bde766826bf357c8aec3233ed6147f2094633a3cbc xsa407/xsa407-1.patch 5955614d73b34ebeab45386dbc9dbe5d96c54f7945d22d5de6c645a5b7796a2f xsa407/xsa407-2.patch 1f901df3a382a547dda6ef4ef088a5cf60a2d2b0382be451b148bf166cf43013 xsa407/xsa407-3.patch 8f75a9eee8ee2a563bc90e493ba1e4ac29335f677a3d2049ec27e138b7e3021e xsa407/xsa407-4.13-01.patch fbe3dca8f170dabf61c620ad1dde12898d52521ede59822971f461549323f946 xsa407/xsa407-4.13-02.patch 9a392bca751a6d6b9489b536ffd7e14722f22e44d266631898ec024b1b258e27 xsa407/xsa407-4.13-03.patch 1eae8ece87fc06ca883fc7510b80ced195c3ec44a589fcf464ead076de4d1afd xsa407/xsa407-4.13-04.patch 016b1a682aa292a380a4fd9c49c65ade0fa7d19ef2f636611d7883d6adb38008 xsa407/xsa407-4.13-05.patch cc3435e7bf2331a61c6e6731d8c0c4edd10ac49c85c9702e3d790309e1bb494a xsa407/xsa407-4.13-06.patch 46f7b3d8a4ae39fa325dda2d77091b0768367a3d2cf6a341996042e511e46b93 xsa407/xsa407-4.13-07.patch cb31c3104890c83fad719c8a2c7b0ae242625132a1e9d6afbf6310af10a8c14a xsa407/xsa407-4.13-08.patch 55241ce45fb11825f7867ae188d73007c38c63d4a8489d990a8c869e000669dc xsa407/xsa407-4.13-09.patch f2d8a64f8446890a055e084f195a9f7c8982915556cefb48dd12b0e798b30a0f xsa407/xsa407-4.13-10.patch aa0ed6a1126c4d9d5fc94c00a51ddf27f4357c4a1cb258f72f0c17ac4ce0d191 xsa407/xsa407-4.13-11.patch e91f244180bd92c111e1c653c22644b8144f3610717dd00347b7f21df75830bf xsa407/xsa407-4.13-12.patch 59c604f50e0cedac2d5011fdb580aab4d719dbe73d9c50096faae70324864927 xsa407/xsa407-4.13-13.patch ca1f04eaacf86ac21a4656b8f1ad9ff0b06d5f295bba5ee21e0bbb4698b165c0 xsa407/xsa407-4.13-14.patch d3ee52d4144b5bb375c1fb7e484b68190632da22e654ab480b73745fe2f23af1 xsa407/xsa407-4.13-15.patch af4ec1eed3d10ce6795e96216676db581e19e4e65d19ee48679a1230a6c37a2f xsa407/xsa407-4.13-16.patch 8ee57395139261e09e387775d7f5c36a1fa53f75caff89302167727230250501 xsa407/xsa407-4.13-17.patch 1495ffd28238737bd9ad346e5667065f5acaa82adc86aeceb358be3d3b1469f9 xsa407/xsa407-4.13-18.patch a02fd749eb761b93fe7b2e5977a9aa493af13044165b71de9e7625c0237c2fde xsa407/xsa407-4.13-19.patch cf127677913b8127c9a71b1c9b3badf9f2c2064d1ed2602d236ba610f7335c8a xsa407/xsa407-4.13-20.patch 0289eb4a9098ab806f5b847e5f55652817b9bb8c9ebc98e28fe8ac626c77f77c xsa407/xsa407-4.13-21.patch fde8cafcd3207329a7582a18a333f95e82e5edc54e93e4d7603c62dc262942a4 xsa407/xsa407-4.14-01.patch e2e7aaf633c2638f4a81eca9e627110b4ad087760b9f4880965093f874b138a2 xsa407/xsa407-4.14-02.patch 69938e6c1293040aff921f2cd6bf2ad850caa682745f0d6be8bc2aabb3802edf xsa407/xsa407-4.14-03.patch 47d67a565d3077688a43937d7cb6cc79d43a8d5e8563711a1476924c696a9759 xsa407/xsa407-4.14-04.patch 14d15b20e053c7dec2e9dd9cbd108284b0ac2069dac2e5c4e76ab4c78637fbe8 xsa407/xsa407-4.14-05.patch cd38bb072a8e99760a80464482d645aba1531fdb4f4d04eabd7c48e2db00c8e1 xsa407/xsa407-4.14-06.patch 85b79e26fce7b649ae860f9860925060867004ea1940c1110f5e22354891b66a xsa407/xsa407-4.14-07.patch 0c292123259319cf110df43ccad50ac5f1396de234d457ed1fbd60462da40d82 xsa407/xsa407-4.14-08.patch 1161d0378a63d79461bfdfdc082bb6e49418f6b356a85048a33f268031a11abd xsa407/xsa407-4.14-09.patch 4b4c652481abaf49d1531ed5c6b6f91b17ab8ae71fcbb085f4557b661fa74d5d xsa407/xsa407-4.14-10.patch 074c16f104563ca665ee3af5144b9d3ec5131eea6eb9c5859ba5e2a33051bd55 xsa407/xsa407-4.14-11.patch e816ea5ea372e4e1429e7191721df9203ee8759a337c91e57d176f2d6a636949 xsa407/xsa407-4.14-12.patch 61382cd7985ac5b3d265a08188cbebdd6916fd150413bb77e5ad452fa98e254a xsa407/xsa407-4.15-1.patch cd38bb072a8e99760a80464482d645aba1531fdb4f4d04eabd7c48e2db00c8e1 xsa407/xsa407-4.15-2.patch 03d8a0e18b4e1ffbac268cfc159341b4d641d0322ea77efd22c43e4a4318d511 xsa407/xsa407-4.15-3.patch ae8e8f220a708401a68535e88a3092b35c3db0a20bd3e3a27cdcc7e88d1ff600 xsa407/xsa407-4.15-4.patch aba615483add2199ad2912557e0b9024d6efd6573fa8009590502d483a78e63a xsa407/xsa407-4.15-5.patch 55e58ce88ff7126c314c7e24f75a700a3263388137ecd725d2e459e21c018f64 xsa407/xsa407-4.15-6.patch a3b146ba37e183d9aec813e66e00a6647835246270d2a9a649724f2570c96c17 xsa407/xsa407-4.15-7.patch ac33b676c2fc5fdee565701baadddd627e492e85f9ca481d12a510c5fc3ff7ab xsa407/xsa407-4.15-8.patch 3a3cec31ebb8f0fb41e3804f03318becc2a978d71831cf086f77c7eff89de9fe xsa407/xsa407-4.16-1.patch b936a9a36c336d1dcf05923f9a07728522f6a6d1474006ec179981a4787a4522 xsa407/xsa407-4.16-2.patch 825a683f37964186ab669468c517c342dc55b1e86898a75c86f8ff0de47e1b76 xsa407/xsa407-4.16-3.patch 402795d0cb418503c3e90b65f3bf546493a7411d14208ac718ba8639f67d1860 xsa407/xsa407-4.16-4.patch ec6009b2ddaa74099725844bf4343efb8510015fb851d3ccc26913f877db0bdf xsa407/xsa407-4.16-5.patch 4fa9c65ee0bdf8650b0cd483c205a305352d918408b91d4adf83c84d1b269b2e xsa407/xsa407-4.16-6.patch 1c01c1508103de49cc1895a60babe9d33feaa27da8d2bd89c6895c0173e280d7 xsa407/xsa407-4.16-7.patch d2a4e06959dff5a9772b13d921332804fbaf81f012c0b9cf85f8b9dd008c61de xsa407/xsa407-4.16-8.patch c178e43d3f569086aee66ffaf28f22156bdb22144bdff7ffe4f7c20242abe73c xsa407/xsa407-4.patch eb9985afa38b1d2bffd6a48772a429fc0f88375cd3fc0b977f9a8a0981ab87b4 xsa407/xsa407-5.patch aea9fb436a1f3dc38a874b8b3e4d0f1a82fb14c5e50c579a978aee1a83bfdb72 xsa407/xsa407-6.patch cf1e9796dbaaedf1e3ba7efb830fe99dea8f09125d7ec7bd2a16b11cfc131aa6 xsa407/xsa407-7.patch cc46f1da318dfa72b87bbc069bf448eed3d1b264281e3a7d9a6bad8f6519e8c3 xsa407/xsa407-8.patch $ NOTE CONCERNING LACK OF EMBARGO =============================== The disclosers did not authorise us to predisclose. -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLNotoMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZeiUH/jZsXrd1X9mzVrBaoQQckCtYtrM+9rYS1JbupDZx Ca6P0zwKaX1uaDi/De/UCAbt4fCpE/xqqy9X5wMX0XUFJEhr74GKXDh/evzH7C/i WxwNmoTio0Un5jw+aLlKGza7oSNYVKPgYjDim7iTMmWdzWauS6Ock3HQn2jkG0JL nTarKFX2JjC2INiu6YssDS81nI6cPJAz+AB4FzzU6u/2loPZv5hxpYnrUsWlRaH1 87pAiGhi7gc9yhv9FTi3C/paBG/kioqQi/ahV5S/l2nlIR1xo97ewfStcdAsT5sl XgFq0sKLamMti0Ens3tydrXVNeyfHq9ABlN2eOnufZNT8Kc= =CEa6 -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa407.meta" Content-Disposition: attachment; filename="xsa407.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MDcsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI4 N2ZmMTEzNTRmMGRjMGQ2ZTc3ZTE2OTVlNmMxZTE0YWExMzgyY2RjIiwKICAg ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTQwNy94c2E0MDctNC4xMy0qLnBhdGNoIgogICAg ICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0Ijog ewogICAgICAiUmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAg ICAgIlN0YWJsZVJlZiI6ICJjNWY3NzRlYWVlY2ExOTVlZjg1YjQ3NzEzZjBi MjEyMjBjNGI0MWU2IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAg ICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQwNy94c2E0MDct NC4xNC0qLnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQog ICAgfSwKICAgICI0LjE1IjogewogICAgICAiUmVjaXBlcyI6IHsKICAgICAg ICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICI1MDU3NzFiYjFk ZmZkZjZmNzYzZmFkMThlZTQ5YTkxM2I5OGFiZmVhIiwKICAgICAgICAgICJQ cmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsKICAgICAgICAg ICAgInhzYTQwNy94c2E0MDctNC4xNS0qLnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE2IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICI3NDRhY2NhZDFiNzMyMjNiMzI2MWUzZTY3OGUxNmUwMzBkODNi MTc5IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQwNy94c2E0MDctNC4xNi0qLnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAg ICJtYXN0ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4i OiB7CiAgICAgICAgICAiU3RhYmxlUmVmIjogImRjN2RhMDg3NGJhNGU4ZmFi NGM1NzgzMDU1NzU1OTM4ZWYxOWZjMzciLAogICAgICAgICAgIlByZXJlcXMi OiBbXSwKICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNh NDA3L3hzYTQwNy0/LnBhdGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAg ICAgfQogICAgfQogIH0KfQ== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-1.patch" Content-Disposition: attachment; filename="xsa407/xsa407-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIHNwZWNfY3RybF9m bGFncyBjb250ZXh0IHN3aXRjaGluZwoKV2UgYXJlIHNob3J0bHkgZ29pbmcg dG8gbmVlZCB0byBjb250ZXh0IHN3aXRjaCBuZXcgYml0cyBpbiBib3RoIHRo ZSB2Y3B1IGFuZApTMyBwYXRocy4gIEludHJvZHVjZSBTQ0ZfSVNUX01BU0sg YW5kIFNDRl9ET01fTUFTSywgYW5kIHJld29yayBkLT5hcmNoLnZlcncKaW50 byBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyB0byBhY2NvbW1vZGF0ZS4KCk5v IGZ1bmN0aW9uYWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9hY3Bp L3Bvd2VyLmMgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCmluZGV4IGM0 ZTdlODY5ODkyMC4uMWJiNGQ3ODM5MmM0IDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvYWNwaS9wb3dlci5jCisrKyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bv d2VyLmMKQEAgLTI0OCw4ICsyNDgsOCBAQCBzdGF0aWMgaW50IGVudGVyX3N0 YXRlKHUzMiBzdGF0ZSkKICAgICAgICAgZXJyb3IgPSAwOwogCiAgICAgY2kg PSBnZXRfY3B1X2luZm8oKTsKLSAgICAvKiBBdm9pZCBOTUkvI01DIHVzaW5n IE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQgbWljcm9jb2Rl LiAqLwotICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflNDRl9pc3Rfd3Jt c3I7CisgICAgLyogQXZvaWQgTk1JLyNNQyB1c2luZyB1bnNhZmUgTVNScyB1 bnRpbCB3ZSd2ZSByZWxvYWRlZCBtaWNyb2NvZGUuICovCisgICAgY2ktPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX0lTVF9NQVNLOwogCiAgICAgQUNQSV9G TFVTSF9DUFVfQ0FDSEUoKTsKIApAQCAtMjkyLDggKzI5Miw4IEBAIHN0YXRp YyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgIGlmICggIXJlY2hl Y2tfY3B1X2ZlYXR1cmVzKDApICkKICAgICAgICAgcGFuaWMoIk1pc3Npbmcg cHJldmlvdXNseSBhdmFpbGFibGUgZmVhdHVyZShzKVxuIik7CiAKLSAgICAv KiBSZS1lbmFibGVkIGRlZmF1bHQgTk1JLyNNQyB1c2Ugb2YgTVNSX1NQRUNf Q1RSTC4gKi8KLSAgICBjaS0+c3BlY19jdHJsX2ZsYWdzIHw9IChkZWZhdWx0 X3NwZWNfY3RybF9mbGFncyAmIFNDRl9pc3Rfd3Jtc3IpOworICAgIC8qIFJl LWVuYWJsZWQgZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JzIG5vdyBtaWNy b2NvZGUgaXMgbG9hZGVkLiAqLworICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gKGRlZmF1bHRfc3BlY19jdHJsX2ZsYWdzICYgU0NGX0lTVF9NQVNLKTsK IAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSB8 fCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykgKQogICAgIHsKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4 Ni9kb21haW4uYwppbmRleCA0MDhlZTI4NGVkM2YuLjIxZGJmN2I4MjJmYyAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9h cmNoL3g4Ni9kb21haW4uYwpAQCAtMjEyMywxMCArMjEyMywxMCBAQCB2b2lk IGNvbnRleHRfc3dpdGNoKHN0cnVjdCB2Y3B1ICpwcmV2LCBzdHJ1Y3QgdmNw dSAqbmV4dCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAg IC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIHdpdGggdGhlIFZF UlcgZGlzcG9zaXRpb24uICovCi0gICAgICAgIGluZm8tPnNwZWNfY3RybF9m bGFncyAmPSB+U0NGX3Zlcnc7Ci0gICAgICAgIGlmICggbmV4dGQtPmFyY2gu dmVydyApCi0gICAgICAgICAgICBpbmZvLT5zcGVjX2N0cmxfZmxhZ3MgfD0g U0NGX3Zlcnc7CisgICAgICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNr IGJsb2NrIHdpdGggdGhlIG5ldyBzcGVjX2N0cmwgc2V0dGluZ3MuICovCisg ICAgICAgIGluZm8tPnNwZWNfY3RybF9mbGFncyA9CisgICAgICAgICAgICAo aW5mby0+c3BlY19jdHJsX2ZsYWdzICAgICAgICYgflNDRl9ET01fTUFTSykg fAorICAgICAgICAgICAgKG5leHRkLT5hcmNoLnNwZWNfY3RybF9mbGFncyAm ICBTQ0ZfRE9NX01BU0spOwogICAgIH0KIAogICAgIHNjaGVkX2NvbnRleHRf c3dpdGNoZWQocHJldiwgbmV4dCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvaW5jbHVkZS9hc20vZG9tYWluLmggYi94ZW4vYXJjaC94ODYvaW5jbHVk ZS9hc20vZG9tYWluLmgKaW5kZXggYWQwMWVlNjhlMTJjLi40ZTU5Y2E4YzRl MTQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9kb21h aW4uaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vZG9tYWluLmgK QEAgLTMyNCw4ICszMjQsNyBAQCBzdHJ1Y3QgYXJjaF9kb21haW4KICAgICB1 aW50MzJfdCBwY2lfY2Y4OwogICAgIHVpbnQ4X3QgY21vc19pZHg7CiAKLSAg ICAvKiBVc2UgVkVSVyBvbiByZXR1cm4tdG8tZ3Vlc3QgZm9yIGl0cyBmbHVz aGluZyBzaWRlIGVmZmVjdC4gKi8KLSAgICBib29sIHZlcnc7CisgICAgdWlu dDhfdCBzcGVjX2N0cmxfZmxhZ3M7IC8qIFNlZSBTQ0ZfRE9NX01BU0sgKi8K IAogICAgIHVuaW9uIHsKICAgICAgICAgc3RydWN0IHB2X2RvbWFpbiBwdjsK ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0 cmwuaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmwuaApp bmRleCA3ZTgzZTAxNzlmYjkuLjNjZDcyZTQwMzA1ZiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCisrKyBiL3hl bi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmwuaApAQCAtMjAsMTIg KzIwLDQwIEBACiAjaWZuZGVmIF9fWDg2X1NQRUNfQ1RSTF9IX18KICNkZWZp bmUgX19YODZfU1BFQ19DVFJMX0hfXwogCi0vKiBFbmNvZGluZyBvZiBjcHVp bmZvLnNwZWNfY3RybF9mbGFncyAqLworLyoKKyAqIEVuY29kaW5nIG9mOgor ICogICBjcHVpbmZvLnNwZWNfY3RybF9mbGFncworICogICBkZWZhdWx0X3Nw ZWNfY3RybF9mbGFncworICogICBkb21haW4uc3BlY19jdHJsX2ZsYWdzCisg KgorICogTGl2ZSBzZXR0aW5ncyBhcmUgaW4gdGhlIHRvcC1vZi1zdGFjayBi bG9jaywgYmVjYXVzZSB0aGV5IG5lZWQgdG8gYmUKKyAqIGFjY2Vzc2FibGUg d2hlbiBYUFRJIGlzIGFjdGl2ZS4gIFNvbWUgc2V0dGluZ3MgYXJlIGZpeGVk IGZyb20gYm9vdCwgc29tZQorICogY29udGV4dCBzd2l0Y2hlZCBwZXIgZG9t YWluLCBhbmQgc29tZSBpbmhpYml0ZWQgaW4gdGhlIFMzIHBhdGguCisgKi8K ICNkZWZpbmUgU0NGX3VzZV9zaGFkb3cgKDEgPDwgMCkKICNkZWZpbmUgU0NG X2lzdF93cm1zciAgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAg KDEgPDwgMikKICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKIAor LyoKKyAqIFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNhbiBpbnRlcnJ1cHQg YW55IGFyYml0cmFyeSBjb250ZXh0LiAgU29tZQorICogZnVuY3Rpb25hbGl0 eSByZXF1aXJlcyB1cGRhdGVkIG1pY3JvY29kZSB0byB3b3JrLgorICoKKyAq IE9uIGJvb3QsIHRoaXMgaXMgZWFzeTsgd2UgbG9hZCBtaWNyb2NvZGUgYmVm b3JlIGZpZ3VyaW5nIG91dCB3aGljaAorICogc3BlY3VsYXRpdmUgcHJvdGVj dGlvbnMgdG8gYXBwbHkuICBIb3dldmVyLCBvbiB0aGUgUzMgcmVzdW1lIHBh dGgsIHdlIG11c3QKKyAqIGJlIGFibGUgdG8gZGlzYWJsZSB0aGUgY29uZmln dXJlZCBtaXRpZ2F0aW9ucyB1bnRpbCBtaWNyb2NvZGUgaXMgcmVsb2FkZWQu CisgKgorICogVGhlc2UgYXJlIHRoZSBjb250cm9scyB0byBpbmhpYml0IG9u IHRoZSBTMyByZXN1bWUgcGF0aCB1bnRpbCBtaWNyb2NvZGUgaGFzCisgKiBi ZWVuIHJlbG9hZGVkLgorICovCisjZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NG X2lzdF93cm1zcikKKworLyoKKyAqIFNvbWUgc3BlY3VsYXRpdmUgcHJvdGVj dGlvbnMgYXJlIHBlci1kb21haW4uICBUaGVzZSBzZXR0aW5ncyBhcmUgbWVy Z2VkCisgKiBpbnRvIHRoZSB0b3Atb2Ytc3RhY2sgYmxvY2sgaW4gdGhlIGNv bnRleHQgc3dpdGNoIHBhdGguCisgKi8KKyNkZWZpbmUgU0NGX0RPTV9NQVNL IChTQ0ZfdmVydykKKwogI2lmbmRlZiBfX0FTU0VNQkxZX18KIAogI2luY2x1 ZGUgPGFzbS9hbHRlcm5hdGl2ZS5oPgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybF9hc20uaCBiL3hlbi9hcmNoL3g4 Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNtLmgKaW5kZXggNWE1OTBiYWM0 NGFhLi42NmIwMGQ1MTFmYzYgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNtLmgKKysrIGIveGVuL2FyY2gveDg2 L2luY2x1ZGUvYXNtL3NwZWNfY3RybF9hc20uaApAQCAtMjQ4LDkgKzI0OCw2 IEBACiAKIC8qCiAgKiBVc2UgaW4gSVNUIGludGVycnVwdC9leGNlcHRpb24g Y29udGV4dC4gIE1heSBpbnRlcnJ1cHQgWGVuIG9yIFBWIGNvbnRleHQuCi0g KiBGaW5lIGdyYWluIGNvbnRyb2wgb2YgU0NGX2lzdF93cm1zciBpcyBuZWVk ZWQgZm9yIHNhZmV0eSBpbiB0aGUgUzMgcmVzdW1lCi0gKiBwYXRoIHRvIGF2 b2lkIHVzaW5nIE1TUl9TUEVDX0NUUkwgYmVmb3JlIHRoZSBtaWNyb2NvZGUg aW50cm9kdWNpbmcgaXQgaGFzCi0gKiBiZWVuIHJlbG9hZGVkLgogICovCiAu bWFjcm8gU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QKIC8qCmRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMKaW5kZXggMzI4ODYyYmRmNTQ5Li45N2IwMjcyZWNj ZjcgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTEwMTEsOSArMTAxMSwx MiBAQCB2b2lkIHNwZWNfY3RybF9pbml0X2RvbWFpbihzdHJ1Y3QgZG9tYWlu ICpkKQogewogICAgIGJvb2wgcHYgPSBpc19wdl9kb21haW4oZCk7CiAKLSAg ICBkLT5hcmNoLnZlcncgPQotICAgICAgICAocHYgPyBvcHRfbWRfY2xlYXJf cHYgOiBvcHRfbWRfY2xlYXJfaHZtKSB8fAotICAgICAgICAob3B0X2ZiX2Ns ZWFyX21taW8gJiYgaXNfaW9tbXVfZW5hYmxlZChkKSk7CisgICAgYm9vbCB2 ZXJ3ID0gKChwdiA/IG9wdF9tZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9o dm0pIHx8CisgICAgICAgICAgICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAm JiBpc19pb21tdV9lbmFibGVkKGQpKSk7CisKKyAgICBkLT5hcmNoLnNwZWNf Y3RybF9mbGFncyA9CisgICAgICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAg ICAgIDogMCkgfAorICAgICAgICAwOwogfQogCiB2b2lkIF9faW5pdCBpbml0 X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-2.patch" Content-Disposition: attachment; filename="xsa407/xsa407-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIFNDRl9pc3Rfd3Jt c3IgdG8gU0NGX2lzdF9zY19tc3IKCldlIGFyZSBhYm91dCB0byBpbnRyb2R1 Y2UgU0NGX2lzdF9pYnBiLCBhdCB3aGljaCBwb2ludCBTQ0ZfaXN0X3dybXNy IGJlY29tZXMKYW1iaWd1b3VzLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCgpU aGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oIGIv eGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCmluZGV4IDNj ZDcyZTQwMzA1Zi4uZjhmMGFjNDdlNzU5IDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvaW5jbHVkZS9hc20vc3BlY19jdHJsLmgKKysrIGIveGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCkBAIC0zMSw3ICszMSw3IEBA CiAgKiBjb250ZXh0IHN3aXRjaGVkIHBlciBkb21haW4sIGFuZCBzb21lIGlu aGliaXRlZCBpbiB0aGUgUzMgcGF0aC4KICAqLwogI2RlZmluZSBTQ0ZfdXNl X3NoYWRvdyAoMSA8PCAwKQotI2RlZmluZSBTQ0ZfaXN0X3dybXNyICAoMSA8 PCAxKQorI2RlZmluZSBTQ0ZfaXN0X3NjX21zciAoMSA8PCAxKQogI2RlZmlu ZSBTQ0ZfaXN0X3JzYiAgICAoMSA8PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAg ICAgICAoMSA8PCAzKQogCkBAIC00Niw3ICs0Niw3IEBACiAgKiBUaGVzZSBh cmUgdGhlIGNvbnRyb2xzIHRvIGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBw YXRoIHVudGlsIG1pY3JvY29kZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAg Ki8KLSNkZWZpbmUgU0NGX0lTVF9NQVNLIChTQ0ZfaXN0X3dybXNyKQorI2Rl ZmluZSBTQ0ZfSVNUX01BU0sgKFNDRl9pc3Rfc2NfbXNyKQogCiAvKgogICog U29tZSBzcGVjdWxhdGl2ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4g IFRoZXNlIHNldHRpbmdzIGFyZSBtZXJnZWQKZGlmZiAtLWdpdCBhL3hlbi9h cmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNtLmggYi94ZW4vYXJj aC94ODYvaW5jbHVkZS9hc20vc3BlY19jdHJsX2FzbS5oCmluZGV4IDY2YjAw ZDUxMWZjNi4uMGZmMWIxMThmODgyIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94 ODYvaW5jbHVkZS9hc20vc3BlY19jdHJsX2FzbS5oCisrKyBiL3hlbi9hcmNo L3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNtLmgKQEAgLTI2Niw4ICsy NjYsOCBAQAogCiAuTFxAX3NraXBfcnNiOgogCi0gICAgdGVzdCAkU0NGX2lz dF93cm1zciwgJWFsCi0gICAganogLkxcQF9za2lwX3dybXNyCisgICAgdGVz dCAkU0NGX2lzdF9zY19tc3IsICVhbAorICAgIGp6IC5MXEBfc2tpcF9tc3Jf c3BlY19jdHJsCiAKICAgICB4b3IgJWVkeCwgJWVkeAogICAgIHRlc3RiICQz LCBVUkVHU19jcyglcnNwKQpAQCAtMjkwLDcgKzI5MCw3IEBAIFVOTElLRUxZ X0RJU1BBVENIX0xBQkVMKFxAX3NlcmlhbGlzZSk6CiAgICAgICogdG8gc3Bl Y3VsYXRlIGFyb3VuZCB0aGUgV1JNU1IuICBBcyBhIHJlc3VsdCwgd2UgbmVl ZCBhIGRpc3BhdGNoCiAgICAgICogc2VyaWFsaXNpbmcgaW5zdHJ1Y3Rpb24g aW4gdGhlIGVsc2UgY2xhdXNlLgogICAgICAqLwotLkxcQF9za2lwX3dybXNy OgorLkxcQF9za2lwX21zcl9zcGVjX2N0cmw6CiAgICAgbGZlbmNlCiAgICAg VU5MSUtFTFlfRU5EKFxAX3NlcmlhbGlzZSkKIC5lbmRtCkBAIC0zMDEsNyAr MzAxLDcgQEAgVU5MSUtFTFlfRElTUEFUQ0hfTEFCRUwoXEBfc2VyaWFsaXNl KToKICAqIFJlcXVpcmVzICVyYng9c3RhY2tfZW5kCiAgKiBDbG9iYmVycyAl cmF4LCAlcmN4LCAlcmR4CiAgKi8KLSAgICB0ZXN0YiAkU0NGX2lzdF93cm1z ciwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyYngp CisgICAgdGVzdGIgJFNDRl9pc3Rfc2NfbXNyLCBTVEFDS19DUFVJTkZPX0ZJ RUxEKHNwZWNfY3RybF9mbGFncykoJXJieCkKICAgICBqeiAuTFxAX3NraXAK IAogICAgIERPX1NQRUNfQ1RSTF9FWElUX1RPX1hFTgpkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCmluZGV4IDk3YjAyNzJlY2NmNy4uMGVmNDZlZTE3NTMzIDEwMDY0 NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIveGVuL2Fy Y2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMTE2LDcgKzExMTYsNyBAQCB2b2lk IF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAg ICAgewogICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAgICAgICB7 Ci0gICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8PSBTQ0Zf aXN0X3dybXNyOworICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxfZmxh Z3MgfD0gU0NGX2lzdF9zY19tc3I7CiAgICAgICAgICAgICBzZXR1cF9mb3Jj ZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01TUl9QVik7CiAgICAgICAgIH0K IApAQCAtMTEyNyw3ICsxMTI3LDcgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVj dWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICAgICAgICogWGVu J3MgdmFsdWUgaXMgbm90IHJlc3RvcmVkIGF0b21pY2FsbHkuICBBbiBlYXJs eSBOTUkgaGl0dGluZwogICAgICAgICAgICAgICogdGhlIFZNRXhpdCBwYXRo IG5lZWRzIHRvIHJlc3RvcmUgWGVuJ3MgdmFsdWUgZm9yIHNhZmV0eS4KICAg ICAgICAgICAgICAqLwotICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxf ZmxhZ3MgfD0gU0NGX2lzdF93cm1zcjsKKyAgICAgICAgICAgIGRlZmF1bHRf c3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfc2NfbXNyOwogICAgICAgICAg ICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19NU1JfSFZN KTsKICAgICAgICAgfQogICAgIH0KQEAgLTExNDAsNyArMTE0MCw3IEBAIHZv aWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnModm9pZCkK ICAgICAgICAgICogb24gcmVhbCBoYXJkd2FyZSBtYXRjaGVzIHRoZSBhdmFp bGFiaWxpdHkgb2YgTVNSX1NQRUNfQ1RSTCBpbiB0aGUKICAgICAgICAgICog Zmlyc3QgcGxhY2UuCiAgICAgICAgICAqCi0gICAgICAgICAqIE5vIG5lZWQg Zm9yIFNDRl9pc3Rfd3Jtc3IgYmVjYXVzZSBYZW4ncyB2YWx1ZSBpcyByZXN0 b3JlZAorICAgICAgICAgKiBObyBuZWVkIGZvciBTQ0ZfaXN0X3NjX21zciBi ZWNhdXNlIFhlbidzIHZhbHVlIGlzIHJlc3RvcmVkCiAgICAgICAgICAqIGF0 b21pY2FsbHkgV1JUIE5NSXMgaW4gdGhlIFZNRXhpdCBwYXRoLgogICAgICAg ICAgKgogICAgICAgICAgKiBUT0RPOiBBZGp1c3QgY3B1X2hhc19zdm1fc3Bl Y19jdHJsIHRvIGJlIHVzYWJsZSBlYXJsaWVyIG9uIGJvb3QuCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-3.patch" Content-Disposition: attachment; filename="xsa407/xsa407-3.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIG9wdF9pYnBiIHRv IG9wdF9pYnBiX2N0eHRfc3dpdGNoCgpXZSBhcmUgYWJvdXQgdG8gaW50cm9k dWNlIHRoZSB1c2Ugb2YgSUJQQiBhdCBkaWZmZXJlbnQgcG9pbnRzIGluIFhl biwgbWFraW5nCm9wdF9pYnBiIGFtYmlndW91cy4gIFJlbmFtZSBpdCB0byBv cHRfaWJwYl9jdHh0X3N3aXRjaC4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoK U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKaW5kZXggMjFkYmY3YjgyMmZj Li41MzJiODdlOGFmNTYgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9kb21h aW4uYworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTIwOTUsNyAr MjA5NSw3IEBAIHZvaWQgY29udGV4dF9zd2l0Y2goc3RydWN0IHZjcHUgKnBy ZXYsIHN0cnVjdCB2Y3B1ICpuZXh0KQogCiAgICAgICAgIGN0eHRfc3dpdGNo X2xldmVsbGluZyhuZXh0KTsKIAotICAgICAgICBpZiAoIG9wdF9pYnBiICYm ICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQorICAgICAgICBpZiAoIG9wdF9p YnBiX2N0eHRfc3dpdGNoICYmICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQog ICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWMgREVGSU5FX1BFUl9DUFUo dW5zaWduZWQgaW50LCBsYXN0KTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCAqbGFzdF9pZCA9ICZ0aGlzX2NwdShsYXN0KTsKZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmwuaCBiL3hlbi9hcmNo L3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmwuaAppbmRleCBmOGYwYWM0N2U3 NTkuLmZiNDM2NTU3NTYyMCAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL3NwZWNfY3RybC5oCisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNs dWRlL2FzbS9zcGVjX2N0cmwuaApAQCAtNjMsNyArNjMsNyBAQAogdm9pZCBp bml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVj X2N0cmxfaW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVy biBib29sIG9wdF9pYnBiOworZXh0ZXJuIGJvb2wgb3B0X2licGJfY3R4dF9z d2l0Y2g7CiBleHRlcm4gYm9vbCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qg b3B0X2VhZ2VyX2ZwdTsKIGV4dGVybiBpbnQ4X3Qgb3B0X2wxZF9mbHVzaDsK ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCAwZWY0NmVlMTc1MzMuLmVkZTBh MjdjMGZlYSAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5j CisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtNTQsNyArNTQs NyBAQCBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKIGJvb2wg X19yb19hZnRlcl9pbml0IG9wdF9zc2JkOwogaW50OF90IF9faW5pdGRhdGEg b3B0X3BzZmQgPSAtMTsKIAotYm9vbCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBi ID0gdHJ1ZTsKK2Jvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYl9jdHh0X3N3 aXRjaCA9IHRydWU7CiBpbnQ4X3QgX19yZWFkX21vc3RseSBvcHRfZWFnZXJf ZnB1ID0gLTE7CiBpbnQ4X3QgX19yZWFkX21vc3RseSBvcHRfbDFkX2ZsdXNo ID0gLTE7CiBzdGF0aWMgYm9vbCBfX2luaXRkYXRhIG9wdF9icmFuY2hfaGFy ZGVuID0gdHJ1ZTsKQEAgLTExNyw3ICsxMTcsNyBAQCBzdGF0aWMgaW50IF9f aW5pdCBjZl9jaGVjayBwYXJzZV9zcGVjX2N0cmwoY29uc3QgY2hhciAqcykK IAogICAgICAgICAgICAgb3B0X3RodW5rID0gVEhVTktfSk1QOwogICAgICAg ICAgICAgb3B0X2licnMgPSAwOwotICAgICAgICAgICAgb3B0X2licGIgPSBm YWxzZTsKKyAgICAgICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gZmFs c2U7CiAgICAgICAgICAgICBvcHRfc3NiZCA9IGZhbHNlOwogICAgICAgICAg ICAgb3B0X2wxZF9mbHVzaCA9IDA7CiAgICAgICAgICAgICBvcHRfYnJhbmNo X2hhcmRlbiA9IGZhbHNlOwpAQCAtMjM4LDcgKzIzOCw3IEBAIHN0YXRpYyBp bnQgX19pbml0IGNmX2NoZWNrIHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFy ICpzKQogCiAgICAgICAgIC8qIE1pc2Mgc2V0dGluZ3MuICovCiAgICAgICAg IGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaWJwYiIsIHMsIHNz KSkgPj0gMCApCi0gICAgICAgICAgICBvcHRfaWJwYiA9IHZhbDsKKyAgICAg ICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gdmFsOwogICAgICAgICBl bHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImVhZ2VyLWZwdSIsIHMs IHNzKSkgPj0gMCApCiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1ID0gdmFs OwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImwx ZC1mbHVzaCIsIHMsIHNzKSkgPj0gMCApCkBAIC00NTgsNyArNDU4LDcgQEAg c3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1 bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChvcHRfdHN4 ICYgMSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBUU1grIiA6 ICIgVFNYLSIsCiAgICAgICAgICAgICFjcHVfaGFzX3NyYmRzX2N0cmwgICAg ICAgICAgICAgICAgICAgICAgID8gIiIgOgogICAgICAgICAgICBvcHRfc3Ji X2xvY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgU1JCX0xP Q0srIiA6ICIgU1JCX0xPQ0stIiwKLSAgICAgICAgICAgb3B0X2licGIgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUEIiICA6ICIi LAorICAgICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCAgICAgICAgICAg ICAgICAgICAgICA/ICIgSUJQQi1jdHh0IiA6ICIiLAogICAgICAgICAgICBv cHRfbDFkX2ZsdXNoICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIg TDFEX0ZMVVNIIiA6ICIiLAogICAgICAgICAgICBvcHRfbWRfY2xlYXJfcHYg fHwgb3B0X21kX2NsZWFyX2h2bSB8fAogICAgICAgICAgICBvcHRfZmJfY2xl YXJfbW1pbyAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVkVSVyIgIDog IiIsCkBAIC0xMjQxLDcgKzEyNDEsNyBAQCB2b2lkIF9faW5pdCBpbml0X3Nw ZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAKICAgICAvKiBDaGVjayB3 ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNpbmcgaXQu Li4gKi8KICAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJS U0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikgKQotICAg ICAgICBvcHRfaWJwYiA9IGZhbHNlOworICAgICAgICBvcHRfaWJwYl9jdHh0 X3N3aXRjaCA9IGZhbHNlOwogCiAgICAgLyogQ2hlY2sgd2hldGhlciBFYWdl ciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdC4gKi8KICAgICBp ZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-01.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-01.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRHJvcCBTUEVDX0NUUkxfe0VO VFJZX0ZST00sRVhJVF9UT31fSFZNCgpUaGVzZSB3ZXJlIHdyaXR0ZW4gYmVm b3JlIFNwZWN0cmUvTWVsdGRvd24gd2VudCBwdWJsaWMsIGFuZCB0aGVyZSB3 YXMgbGFyZ2UKdW5jZXJ0YWludHkgaW4gaG93IHRoZSBwcm90ZWN0aW9ucyB3 b3VsZCBldm9sdmUuICBBcyBpdCB0dXJucyBvdXQsIHRoZXkncmUKdmVyeSBz cGVjaWZpYyB0byBJbnRlbCBoYXJkd2FyZSwgYW5kIG5vdCB2ZXJ5IHN1aXRh YmxlIGZvciBBTUQuCgpEcm9wIHRoZSBtYWNyb3MsIG9wZW5jb2RpbmcgdGhl IHJlbGV2YW50IHN1YnNldCBvZiBmdW5jdGlvbmFsaXR5LCBhbmQgbGVhdmlu ZwpncmVwLWZvZGRlciB0byBsb2NhdGUgdGhlIGxvZ2ljLiAgTm8gY2hhbmdl IGF0IGFsbCBmb3IgVlQteC4KCkZvciBBTUQsIHRoZSBvbmx5IHJlbGV2YW50 IHBpZWNlIG9mIGZ1bmN0aW9uYWxpdHkgaXMgRE9fT1ZFUldSSVRFX1JTQiwK YWx0aG91Z2ggd2Ugd2lsbCBzb29uIGJlIGFkZGluZyAoZGlmZmVyZW50KSBs b2dpYyB0byBoYW5kbGUgTVNSX1NQRUNfQ1RSTC4KClRoaXMgaGFzIGEgbWFy Z2luYWwgaW1wcm92ZW1lbnQgb2YgcmVtb3ZpbmcgYW4gdW5jb25kaXRpb25h bCBwaWxlIG9mIGxvbmctbm9wcwpmcm9tIHRoZSB2bWVudHJ5L2V4aXQgcGF0 aC4KClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOp IDxyb2dlci5wYXVAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQgZnJvbSBj b21taXQgOTViMTNmYTQzZTA3NTNiNzUxNGJlZjEzYWJlMjgyNTNlODYxNGY2 MikKW0ZvcndhcmQgcG9ydCBvdmVyIFhTQS00MDRdCgpkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L2h2bS9zdm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9o dm0vc3ZtL2VudHJ5LlMKaW5kZXggZTk1NGQ4ZTAyMTEwLi4wNjg0ZDI5MDUw YTUgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMK KysrIGIveGVuL2FyY2gveDg2L2h2bS9zdm0vZW50cnkuUwpAQCAtNjMsNyAr NjMsNyBAQCBfX1VOTElLRUxZX0VORChuc3ZtX2hhcCkKICAgICAgICAgbW92 IFZDUFVNU1Jfc3BlY19jdHJsX3JhdyglcmF4KSwgJWVheAogCiAgICAgICAg IC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qgc2Fm ZSBiZXlvbmQgdGhpcyBwb2ludC4gKi8KLSAgICAgICAgU1BFQ19DVFJMX0VY SVRfVE9fSFZNICAgLyogUmVxOiBhPXNwZWNfY3RybCAlcnNwPXJlZ3MvY3B1 aW5mbywgQ2xvYjogY2QgKi8KKyAgICAgICAgLyogU1BFQ19DVFJMX0VYSVRf VE9fU1ZNICAgKG5vdGhpbmcgY3VycmVudGx5KSAqLwogCiAgICAgICAgIHBv cCAgJXIxNQogICAgICAgICBwb3AgICVyMTQKQEAgLTkwLDcgKzkwLDggQEAg X19VTkxJS0VMWV9FTkQobnN2bV9oYXApCiAKICAgICAgICAgR0VUX0NVUlJF TlQoYngpCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSFZNICAg IC8qIFJlcTogYj1jdXJyICVyc3A9cmVncy9jcHVpbmZvLCBDbG9iOiBhY2Qg Ki8KKyAgICAgICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJl cTogYj1jdXJyICVyc3A9cmVncy9jcHVpbmZvLCBDbG9iOiBhYyAgKi8KKyAg ICAgICAgQUxURVJOQVRJVkUgIiIsIERPX09WRVJXUklURV9SU0IsIFg4Nl9G RUFUVVJFX1NDX1JTQl9IVk0KICAgICAgICAgLyogV0FSTklORyEgYHJldGAs IGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50 LiAqLwogCiAgICAgICAgIFNUR0kKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni9odm0vdm14L2VudHJ5LlMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC9lbnRy eS5TCmluZGV4IDYyZWQwZDg1NGRmMS4uZGIzYWY1NzFjOTEzIDEwMDY0NAot LS0gYS94ZW4vYXJjaC94ODYvaHZtL3ZteC9lbnRyeS5TCisrKyBiL3hlbi9h cmNoL3g4Ni9odm0vdm14L2VudHJ5LlMKQEAgLTMzLDcgKzMzLDkgQEAgRU5U Ulkodm14X2FzbV92bWV4aXRfaGFuZGxlcikKICAgICAgICAgbW92YiAkMSxW Q1BVX3ZteF9sYXVuY2hlZCglcmJ4KQogICAgICAgICBtb3YgICVyYXgsVkNQ VV9odm1fZ3Vlc3RfY3IyKCVyYngpCiAKLSAgICAgICAgU1BFQ19DVFJMX0VO VFJZX0ZST01fSFZNICAgIC8qIFJlcTogYj1jdXJyICVyc3A9cmVncy9jcHVp bmZvLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgLyogU1BFQ19DVFJMX0VOVFJZ X0ZST01fVk1YICAgIFJlcTogYj1jdXJyICVyc3A9cmVncy9jcHVpbmZvLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgQUxURVJOQVRJVkUgIiIsIERPX09WRVJX UklURV9SU0IsIFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0KKyAgICAgICAgQUxU RVJOQVRJVkUgIiIsIERPX1NQRUNfQ1RSTF9FTlRSWV9GUk9NX0hWTSwgWDg2 X0ZFQVRVUkVfU0NfTVNSX0hWTQogICAgICAgICAvKiBXQVJOSU5HISBgcmV0 YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3JlIHRoaXMgcG9p bnQuICovCiAKICAgICAgICAgLyogSGFyZHdhcmUgY2xlYXJzIE1TUl9ERUJV R0NUTCBvbiBWTUV4aXQuICBSZWluc3RhdGUgaXQgaWYgZGVidWdnaW5nIFhl bi4gKi8KQEAgLTgwLDcgKzgyLDggQEAgVU5MSUtFTFlfRU5EKHJlYWxtb2Rl KQogICAgICAgICBtb3YgVkNQVU1TUl9zcGVjX2N0cmxfcmF3KCVyYXgpLCAl ZWF4CiAKICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBg am1wICpgIG5vdCBzYWZlIGJleW9uZCB0aGlzIHBvaW50LiAqLwotICAgICAg ICBTUEVDX0NUUkxfRVhJVF9UT19IVk0gICAvKiBSZXE6IGE9c3BlY19jdHJs ICVyc3A9cmVncy9jcHVpbmZvLCBDbG9iOiBjZCAqLworICAgICAgICAvKiBT UEVDX0NUUkxfRVhJVF9UT19WTVggICBSZXE6IGE9c3BlY19jdHJsICVyc3A9 cmVncy9jcHVpbmZvLCBDbG9iOiBjZCAqLworICAgICAgICBBTFRFUk5BVElW RSAiIiwgRE9fU1BFQ19DVFJMX0VYSVRfVE9fR1VFU1QsIFg4Nl9GRUFUVVJF X1NDX01TUl9IVk0KICAgICAgICAgRE9fU1BFQ19DVFJMX0NPTkRfVkVSVwog CiAgICAgICAgIG1vdiAgVkNQVV9odm1fZ3Vlc3RfY3IyKCVyYngpLCVyYXgK ZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2Fz bS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxfYXNtLmgKaW5k ZXggNGEzNzc3Y2M1MjI3Li5mZTkwYzgwYWMzOWMgMTAwNjQ0Ci0tLSBhL3hl bi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCisrKyBiL3hlbi9p bmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCkBAIC02OCwxNCArNjgs MTYgQEAKICAqCiAgKiBUaGUgZm9sbG93aW5nIEFTTSBmcmFnbWVudHMgaW1w bGVtZW50IHRoaXMgYWxnb3JpdGhtLiAgU2VlIHRoZWlyIGxvY2FsCiAgKiBj b21tZW50cyBmb3IgZnVydGhlciBkZXRhaWxzLgotICogIC0gU1BFQ19DVFJM X0VOVFJZX0ZST01fSFZNCiAgKiAgLSBTUEVDX0NUUkxfRU5UUllfRlJPTV9Q VgogICogIC0gU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUgogICogIC0gU1BF Q19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QKICAqICAtIFNQRUNfQ1RSTF9F WElUX1RPX1hFTl9JU1QKICAqICAtIFNQRUNfQ1RSTF9FWElUX1RPX1hFTgog ICogIC0gU1BFQ19DVFJMX0VYSVRfVE9fUFYKLSAqICAtIFNQRUNfQ1RSTF9F WElUX1RPX0hWTQorICoKKyAqIEFkZGl0aW9uYWxseSwgdGhlIGZvbGxvd2lu ZyBncmVwLWZvZGRlciBleGlzdHMgdG8gZmluZCB0aGUgSFZNIGxvZ2ljLgor ICogIC0gU1BFQ19DVFJMX0VOVFJZX0ZST01fe1NWTSxWTVh9CisgKiAgLSBT UEVDX0NUUkxfRVhJVF9UT197U1ZNLFZNWH0KICAqLwogCiAubWFjcm8gRE9f T1ZFUldSSVRFX1JTQiB0bXA9cmF4CkBAIC0yMjgsMTIgKzIzMCw2IEBACiAg ICAgd3Jtc3IKIC5lbmRtCiAKLS8qIFVzZSBhZnRlciBhIFZNRVhJVCBmcm9t IGFuIEhWTSBndWVzdC4gKi8KLSNkZWZpbmUgU1BFQ19DVFJMX0VOVFJZX0ZS T01fSFZNICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFwKLSAgICBBTFRFUk5BVElWRSAiIiwgRE9fT1ZFUldSSVRFX1JTQiwgWDg2 X0ZFQVRVUkVfU0NfUlNCX0hWTTsgICAgICAgICAgIFwKLSAgICBBTFRFUk5B VElWRSAiIiwgRE9fU1BFQ19DVFJMX0VOVFJZX0ZST01fSFZNLCAgICAgICAg ICAgICAgICAgICAgICAgIFwKLSAgICAgICAgWDg2X0ZFQVRVUkVfU0NfTVNS X0hWTQotCiAvKiBVc2UgYWZ0ZXIgYW4gZW50cnkgZnJvbSBQViBjb250ZXh0 IChzeXNjYWxsL3N5c2VudGVyL2ludDgwL2ludDgyL2V0YykuICovCiAjZGVm aW5lIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgQUxURVJOQVRJVkUgIiIs IERPX09WRVJXUklURV9SU0IsIFg4Nl9GRUFUVVJFX1NDX1JTQl9QVjsgICAg ICAgICAgICBcCkBAIC0yNTcsMTEgKzI1Myw2IEBACiAgICAgICAgIERPX1NQ RUNfQ1RSTF9FWElUX1RPX0dVRVNULCBYODZfRkVBVFVSRV9TQ19NU1JfUFY7 ICAgICAgICAgICAgICBcCiAgICAgRE9fU1BFQ19DVFJMX0NPTkRfVkVSVwog Ci0vKiBVc2Ugd2hlbiBleGl0aW5nIHRvIEhWTSBndWVzdCBjb250ZXh0LiAq LwotI2RlZmluZSBTUEVDX0NUUkxfRVhJVF9UT19IVk0gICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAotICAgIEFMVEVSTkFU SVZFICIiLCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgXAotICAgICAgICBET19TUEVDX0NUUkxfRVhJVF9U T19HVUVTVCwgWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTTsgICAgICAgICAgICAg XAotCiAvKgogICogVXNlIGluIElTVCBpbnRlcnJ1cHQvZXhjZXB0aW9uIGNv bnRleHQuICBNYXkgaW50ZXJydXB0IFhlbiBvciBQViBjb250ZXh0LgogICog RmluZSBncmFpbiBjb250cm9sIG9mIFNDRl9pc3Rfd3Jtc3IgaXMgbmVlZGVk IGZvciBzYWZldHkgaW4gdGhlIFMzIHJlc3VtZQo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-02.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-02.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3BsaXQgdGhlICJIYXJkd2Fy ZSBmZWF0dXJlcyIgZGlhZ25vc3RpYyBsaW5lCgpTZXBhcmF0ZSB0aGUgcmVh ZC1vbmx5IGhpbnRzIGZyb20gdGhlIGZlYXR1cmVzIHJlcXVpcmluZyBhY3Rp dmUgYWN0aW9ucyBvbgpYZW4ncyBiZWhhbGYuCgpBbHNvIHRha2UgdGhlIG9w cG9ydHVuaXR5IHNwbGl0IHRoZSBJQlJTL0lCUEIgYW5kIElCUEIgbWVzcy4g IE1vcmUgZmVhdHVyZXMKd2l0aCBvdmVybGFwcGluZyBlbnVtZXJhdGlvbiBh cmUgb24gdGhlIHdheSwgYW5kIGFuZCBpdCBpcyBub3QgdXNlZnVsIHRvIHNw bGl0CnRoZW0gbGlrZSB0aGlzLgoKTm8gcHJhY3RpY2FsIGNoYW5nZS4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IDU2NWViY2Rh OTc2YzA1YjBjNjE5MTUxMGQ1ZTMyYjYyMWEyYjE4NjcpCltGb3J3YXJkIHBv cnRlZCBvdmVyIFhTQS00MDRdCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCmluZGV4 IDNiMzRjYTcwNWNjNi4uZmVjMTQ1YTdiOWUxIDEwMDY0NAotLS0gYS94ZW4v YXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCkBAIC0zMjIsMjggKzMyMiwzNSBAQCBzdGF0aWMgdm9pZCBfX2lu aXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywgdWludDY0 X3QgY2FwcykKIAogICAgIHByaW50aygiU3BlY3VsYXRpdmUgbWl0aWdhdGlv biBmYWNpbGl0aWVzOlxuIik7CiAKLSAgICAvKiBIYXJkd2FyZSBmZWF0dXJl cyB3aGljaCBwZXJ0YWluIHRvIHNwZWN1bGF0aXZlIG1pdGlnYXRpb25zLiAq LwotICAgIHByaW50aygiICBIYXJkd2FyZSBmZWF0dXJlczolcyVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLAotICAgICAgICAg ICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTQikpID8g IiBJQlJTL0lCUEIiIDogIiIsCi0gICAgICAgICAgIChfN2QwICYgY3B1ZmVh dF9tYXNrKFg4Nl9GRUFUVVJFX1NUSUJQKSkgPyAiIFNUSUJQIiAgICAgOiAi IiwKLSAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfTDFEX0ZMVVNIKSkgPyAiIEwxRF9GTFVTSCIgOiAiIiwKLSAgICAgICAg ICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfU1NCRCkpICA/ ICIgU1NCRCIgICAgICA6ICIiLAotICAgICAgICAgICAoXzdkMCAmIGNwdWZl YXRfbWFzayhYODZfRkVBVFVSRV9NRF9DTEVBUikpID8gIiBNRF9DTEVBUiIg OiAiIiwKLSAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfU1JCRFNfQ1RSTCkpID8gIiBTUkJEU19DVFJMIiA6ICIiLAotICAg ICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlBC KSkgID8gIiBJQlBCIiAgICAgIDogIiIsCi0gICAgICAgICAgIChjYXBzICYg QVJDSF9DQVBTX0lCUlNfQUxMKSAgICAgICAgICAgICAgPyAiIElCUlNfQUxM IiAgOiAiIiwKLSAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUkRDTF9O TykgICAgICAgICAgICAgICA/ICIgUkRDTF9OTyIgICA6ICIiLAotICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19SU0JBKSAgICAgICAgICAgICAgICAg ID8gIiBSU0JBIiAgICAgIDogIiIsCi0gICAgICAgICAgIChjYXBzICYgQVJD SF9DQVBTX1NLSVBfTDFERkwpICAgICAgICAgICAgPyAiIFNLSVBfTDFERkwi OiAiIiwKLSAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfU1NCX05PKSAg ICAgICAgICAgICAgICA/ICIgU1NCX05PIiAgICA6ICIiLAotICAgICAgICAg ICAoY2FwcyAmIEFSQ0hfQ0FQU19NRFNfTk8pICAgICAgICAgICAgICAgID8g IiBNRFNfTk8iICAgIDogIiIsCi0gICAgICAgICAgIChjYXBzICYgQVJDSF9D QVBTX1RTWF9DVFJMKSAgICAgICAgICAgICAgPyAiIFRTWF9DVFJMIiAgOiAi IiwKLSAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfVEFBX05PKSAgICAg ICAgICAgICAgICA/ICIgVEFBX05PIiAgICA6ICIiLAotICAgICAgICAgICAo Y2FwcyAmIEFSQ0hfQ0FQU19TQkRSX1NTRFBfTk8pICAgICAgICAgID8gIiBT QkRSX1NTRFBfTk8iIDogIiIsCi0gICAgICAgICAgIChjYXBzICYgQVJDSF9D QVBTX0ZCU0RQX05PKSAgICAgICAgICAgICAgPyAiIEZCU0RQX05PIiAgOiAi IiwKLSAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUFNEUF9OTykgICAg ICAgICAgICAgICA/ICIgUFNEUF9OTyIgICA6ICIiLAotICAgICAgICAgICAo Y2FwcyAmIEFSQ0hfQ0FQU19GQl9DTEVBUikgICAgICAgICAgICAgID8gIiBG Ql9DTEVBUiIgIDogIiIsCi0gICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X0ZCX0NMRUFSX0NUUkwpICAgICAgICAgPyAiIEZCX0NMRUFSX0NUUkwiIDog IiIpOworICAgIC8qCisgICAgICogSGFyZHdhcmUgcmVhZC1vbmx5IGluZm9y bWF0aW9uLCBzdGF0aW5nIGltbXVuaXR5IHRvIGNlcnRhaW4gaXNzdWVzLCBv cgorICAgICAqIHN1Z2dlc3Rpb25zIG9mIHdoaWNoIG1pdGlnYXRpb24gdG8g dXNlLgorICAgICAqLworICAgIHByaW50aygiICBIYXJkd2FyZSBoaW50czol cyVzJXMlcyVzJXMlcyVzJXMlc1xuIiwKKyAgICAgICAgICAgKGNhcHMgJiBB UkNIX0NBUFNfUkRDTF9OTykgICAgICAgICAgICAgICAgICAgICAgICA/ICIg UkRDTF9OTyIgICAgICAgIDogIiIsCisgICAgICAgICAgIChjYXBzICYgQVJD SF9DQVBTX0lCUlNfQUxMKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIElC UlNfQUxMIiAgICAgICA6ICIiLAorICAgICAgICAgICAoY2FwcyAmIEFSQ0hf Q0FQU19SU0JBKSAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBSU0JB IiAgICAgICAgICAgOiAiIiwKKyAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NB UFNfU0tJUF9MMURGTCkgICAgICAgICAgICAgICAgICAgICA/ICIgU0tJUF9M MURGTCIgICAgIDogIiIsCisgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBT X1NTQl9OTykgICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFNTQl9OTyIg ICAgICAgICA6ICIiLAorICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19N RFNfTk8pICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBNRFNfTk8iICAg ICAgICAgOiAiIiwKKyAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfVEFB X05PKSAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVEFBX05PIiAgICAg ICAgIDogIiIsCisgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1NCRFJf U1NEUF9OTykgICAgICAgICAgICAgICAgICAgPyAiIFNCRFJfU1NEUF9OTyIg ICA6ICIiLAorICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19GQlNEUF9O TykgICAgICAgICAgICAgICAgICAgICAgID8gIiBGQlNEUF9OTyIgICAgICAg OiAiIiwKKyAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUFNEUF9OTykg ICAgICAgICAgICAgICAgICAgICAgICA/ICIgUFNEUF9OTyIgICAgICAgIDog IiIpOworCisgICAgLyogSGFyZHdhcmUgZmVhdHVyZXMgd2hpY2ggbmVlZCBk cml2aW5nIHRvIG1pdGlnYXRlIGlzc3Vlcy4gKi8KKyAgICBwcmludGsoIiAg SGFyZHdhcmUgZmVhdHVyZXM6JXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCisg ICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lC UEIpKSB8fAorICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTQikpICAgICAgICAgID8gIiBJQlBCIiAgICAgICAgICAg OiAiIiwKKyAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU0IpKSAgICAgICAgICA/ICIgSUJSUyIgICAgICAgICAgIDog IiIsCisgICAgICAgICAgIChfN2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX1NUSUJQKSkgICAgICAgICAgPyAiIFNUSUJQIiAgICAgICAgICA6ICIi LAorICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVS RV9TU0JEKSkgICAgICAgICAgID8gIiBTU0JEIiAgICAgICAgICAgOiAiIiwK KyAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVf TDFEX0ZMVVNIKSkgICAgICA/ICIgTDFEX0ZMVVNIIiAgICAgIDogIiIsCisg ICAgICAgICAgIChfN2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX01E X0NMRUFSKSkgICAgICAgPyAiIE1EX0NMRUFSIiAgICAgICA6ICIiLAorICAg ICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9TUkJE U19DVFJMKSkgICAgID8gIiBTUkJEU19DVFJMIiAgICAgOiAiIiwKKyAgICAg ICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfVFNYX0NUUkwpICAgICAgICAgICAg ICAgICAgICAgICA/ICIgVFNYX0NUUkwiICAgICAgIDogIiIsCisgICAgICAg ICAgIChjYXBzICYgQVJDSF9DQVBTX0ZCX0NMRUFSKSAgICAgICAgICAgICAg ICAgICAgICAgPyAiIEZCX0NMRUFSIiAgICAgICA6ICIiLAorICAgICAgICAg ICAoY2FwcyAmIEFSQ0hfQ0FQU19GQl9DTEVBUl9DVFJMKSAgICAgICAgICAg ICAgICAgID8gIiBGQl9DTEVBUl9DVFJMIiAgOiAiIik7CiAKICAgICAvKiBD b21waWxlZC1pbiBzdXBwb3J0IHdoaWNoIHBlcnRhaW5zIHRvIG1pdGlnYXRp b25zLiAqLwogICAgIGlmICggSVNfRU5BQkxFRChDT05GSUdfSU5ESVJFQ1Rf VEhVTkspIHx8IElTX0VOQUJMRUQoQ09ORklHX1NIQURPV19QQUdJTkcpICkK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-03.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-03.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2FtZDogRW51bWVyYXRpb24gZm9yIHNwZWN1bGF0 aXZlIGZlYXR1cmVzL2hpbnRzCgpUaGVyZSBpcyBhIHN0ZXAgY2hhbmdlIGlu IHNwZWN1bGF0aW9uIHByb3RlY3Rpb25zIGJldHdlZW4gdGhlIFplbjEgYW5k IFplbjIKbWljcm9hcmNoaXRlY3R1cmVzLgoKWmVuMSBhbmQgb2xkZXIgaGF2 ZSBubyBzcGVjaWFsIHN1cHBvcnQuICBDb250cm9sIGJpdHMgaW4gbm9uLWFy Y2hpdGVjdHVyYWwKTVNScyBhcmUgdXNlZCB0byBtYWtlIGxmZW5jZSBiZSBk aXNwYXRjaC1zZXJpYWxpc2luZyAoU3BlY3RyZSB2MSksIGFuZCB0bwpkaXNh YmxlIE1lbW9yeSBEaXNhbWJpZ3VhdGlvbiAoU3BlY3VsYXRpdmUgU3RvcmUg QnlwYXNzKS4gIElCUEIgd2FzCnJldHJvZml0dGVkIGluIGEgbWljcm9jb2Rl IHVwZGF0ZSwgYW5kIHNvZnR3YXJlIG1ldGhvZHMgYXJlIHJlcXVpcmVkIGZv cgpTcGVjdHJlIHYyIHByb3RlY3Rpb25zLgoKQmVjYXVzZSB0aGUgYml0IGNv bnRyb2xsaW5nIE1lbW9yeSBEaXNhbWJpZ3VhdGlvbiBpcyBtb2RlbCBzcGVj aWZpYywKaHlwZXJ2aXNvcnMgYXJlIGV4cGVjdGVkIHRvIGV4cG9zZSBhIE1T Ul9WSVJUX1NQRUNfQ1RSTCBpbnRlcmZhY2Ugd2hpY2gKYWJzdHJhY3RzIHRo ZSBtb2RlbCBzcGVjaWZpYyBkZXRhaWxzLgoKWmVuMiBhbmQgbGF0ZXIgaW1w bGVtZW50IHRoZSBNU1JfU1BFQ19DVFJMIGludGVyZmFjZSBpbiBoYXJkd2Fy ZSwgYW5kCnZpcnR1YWxpc2UgdGhlIGludGVyZmFjZSBmb3IgSFZNIGd1ZXN0 cyB0byB1c2UuICBBIG51bWJlciBvZiBoaW50IGJpdHMgYXJlCnNwZWNpZmll ZCB0b28gdG8gaGVscCBndWlkZSBPUyBzb2Z0d2FyZSB0byB0aGUgbW9zdCBl ZmZpY2llbnQgbWl0aWdhdGlvbgpzdHJhdGVneS4KClplbjMgaW50cm9kdWNl ZCBhIG5ldyBmZWF0dXJlLCBQcmVkaWN0aXZlIFN0b3JlIEZvcndhcmRpbmcs IGFsb25nIHdpdGggYQpjb250cm9sIHRvIGRpc2FibGUgaXQgaW4gc2Vuc2l0 aXZlIGNvZGUuCgpBZGQgQ1BVSUQgYW5kIFZNQ0IgZGV0YWlscyBmb3IgYWxs IHRoZSBuZXcgZnVuY3Rpb25hbGl0eS4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CihjaGVycnkg cGlja2VkIGZyb20gY29tbWl0IDc0NzQyNGM2NjRiYjE2NGEwNGU3YTlmMmZm YmYwMmQ0YTE2MzBkN2QpCgpkaWZmIC0tZ2l0IGEvdG9vbHMvbGlieGwvbGli eGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlkLmMKaW5kZXgg MDgzODY5ZGNmNGE3Li45NzdhNDM3N2JmMWIgMTAwNjQ0Ci0tLSBhL3Rvb2xz L2xpYnhsL2xpYnhsX2NwdWlkLmMKKysrIGIvdG9vbHMvbGlieGwvbGlieGxf Y3B1aWQuYwpAQCAtMjY0LDYgKzI2NCwxNiBAQCBpbnQgbGlieGxfY3B1aWRf cGFyc2VfY29uZmlnKGxpYnhsX2NwdWlkX3BvbGljeV9saXN0ICpjcHVpZCwg Y29uc3QgY2hhciogc3RyKQogICAgICAgICB7InJzdHItZnAtZXJyLXB0cnMi LCAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VCWCwgMiwgMX0sCiAgICAg ICAgIHsid2Jub2ludmQiLCAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JF R19FQlgsICA5LCAgMX0sCiAgICAgICAgIHsiaWJwYiIsICAgICAgICAgMHg4 MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDEyLCAgMX0sCisgICAgICAg IHsiaWJycyIsICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19F QlgsIDE0LCAgMX0sCisgICAgICAgIHsiYW1kLXN0aWJwIiwgICAgMHg4MDAw MDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDE1LCAgMX0sCisgICAgICAgIHsi aWJycy1hbHdheXMiLCAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgs IDE2LCAgMX0sCisgICAgICAgIHsic3RpYnAtYWx3YXlzIiwgMHg4MDAwMDAw OCwgTkEsIENQVUlEX1JFR19FQlgsIDE3LCAgMX0sCisgICAgICAgIHsiaWJy cy1mYXN0IiwgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDE4 LCAgMX0sCisgICAgICAgIHsiaWJycy1zYW1lLW1vZGUiLCAweDgwMDAwMDA4 LCBOQSwgQ1BVSURfUkVHX0VCWCwgMTksICAxfSwKKyAgICAgICAgeyJhbWQt c3NiZCIsICAgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VCWCwgMjQs ICAxfSwKKyAgICAgICAgeyJ2aXJ0LXNzYmQiLCAgICAweDgwMDAwMDA4LCBO QSwgQ1BVSURfUkVHX0VCWCwgMjUsICAxfSwKKyAgICAgICAgeyJzc2Itbm8i LCAgICAgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VCWCwgMjYsICAx fSwKKyAgICAgICAgeyJwc2ZkIiwgICAgICAgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VCWCwgMjgsICAxfSwKIAogICAgICAgICB7Im5jIiwgICAg ICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUNYLCAgMCwgIDh9 LAogICAgICAgICB7ImFwaWNpZHNpemUiLCAgIDB4ODAwMDAwMDgsIE5BLCBD UFVJRF9SRUdfRUNYLCAxMiwgIDR9LApkaWZmIC0tZ2l0IGEvdG9vbHMvbWlz Yy94ZW4tY3B1aWQuYyBiL3Rvb2xzL21pc2MveGVuLWNwdWlkLmMKaW5kZXgg YTA5NDQwODEzYjlkLi5mZjE2Nzc3OWRmMzEgMTAwNjQ0Ci0tLSBhL3Rvb2xz L21pc2MveGVuLWNwdWlkLmMKKysrIGIvdG9vbHMvbWlzYy94ZW4tY3B1aWQu YwpAQCAtMTQ3LDkgKzE0NywxNiBAQCBzdGF0aWMgY29uc3QgY2hhciAqY29u c3Qgc3RyX2U4YlszMl0gPQogICAgIFsgMF0gPSAiY2x6ZXJvIiwKICAgICBb IDJdID0gInJzdHItZnAtZXJyLXB0cnMiLAogCi0gICAgLyogWyA4XSAqLyAg ICAgICAgICAgIFsgOV0gPSAid2Jub2ludmQiLAorICAgIC8qIFsgOF0gKi8g ICAgICAgICAgICAgICAgIFsgOV0gPSAid2Jub2ludmQiLAogCiAgICAgWzEy XSA9ICJpYnBiIiwKKyAgICBbMTRdID0gImlicnMiLCAgICAgICAgICAgICBb MTVdID0gImFtZC1zdGlicCIsCisgICAgWzE2XSA9ICJpYnJzLWFsd2F5cyIs ICAgICAgWzE3XSA9ICJzdGlicC1hbHdheXMiLAorICAgIFsxOF0gPSAiaWJy cy1mYXN0IiwgICAgICAgIFsxOV0gPSAiaWJycy1zYW1lLW1vZGUiLAorCisg ICAgWzI0XSA9ICJhbWQtc3NiZCIsICAgICAgICAgWzI1XSA9ICJ2aXJ0LXNz YmQiLAorICAgIFsyNl0gPSAic3NiLW5vIiwKKyAgICBbMjhdID0gInBzZmQi LAogfTsKIAogc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl83ZDBbMzJd ID0KZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jIGIv eGVuL2FyY2gveDg2L2h2bS9zdm0vc3ZtLmMKaW5kZXggYTZkZTljY2I4ZmRj Li5jOTczNDExMDE5YzQgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9odm0v c3ZtL3N2bS5jCisrKyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL3N2bS5jCkBA IC0xNjU3LDYgKzE2NTcsNyBAQCBjb25zdCBzdHJ1Y3QgaHZtX2Z1bmN0aW9u X3RhYmxlICogX19pbml0IHN0YXJ0X3N2bSh2b2lkKQogICAgIFAoY3B1X2hh c19wYXVzZV9maWx0ZXIsICJQYXVzZS1JbnRlcmNlcHQgRmlsdGVyIik7CiAg ICAgUChjcHVfaGFzX3BhdXNlX3RocmVzaCwgIlBhdXNlLUludGVyY2VwdCBG aWx0ZXIgVGhyZXNob2xkIik7CiAgICAgUChjcHVfaGFzX3RzY19yYXRpbywg IlRTQyBSYXRlIE1TUiIpOworICAgIFAoY3B1X2hhc19zdm1fc3BlY19jdHJs LCAiTVNSX1NQRUNfQ1RSTCB2aXJ0dWFsaXNhdGlvbiIpOwogI3VuZGVmIFAK IAogICAgIGlmICggIXByaW50ZWQgKQpkaWZmIC0tZ2l0IGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlLmggYi94ZW4vaW5jbHVkZS9hc20teDg2 L2NwdWZlYXR1cmUuaAppbmRleCAwMGQyMmNhYWM3NGMuLjY0MTliNGQyYzVl NCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJl LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlLmgKQEAg LTEyNCw2ICsxMjQsMTEgQEAKIC8qIENQVUlEIGxldmVsIDB4ODAwMDAwMDcu ZWR4ICovCiAjZGVmaW5lIGNwdV9oYXNfaXRzYyAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JVFNDKQogCisvKiBDUFVJRCBsZXZlbCAw eDgwMDAwMDA4LmVieCAqLworI2RlZmluZSBjcHVfaGFzX2FtZF9zc2JkICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NTQkQpCisjZGVm aW5lIGNwdV9oYXNfdmlydF9zc2JkICAgICAgIGJvb3RfY3B1X2hhcyhYODZf RkVBVFVSRV9WSVJUX1NTQkQpCisjZGVmaW5lIGNwdV9oYXNfc3NiX25vICAg ICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TU0JfTk8pCisKIC8q IENQVUlEIGxldmVsIDB4MDAwMDAwMDc6MC5lZHggKi8KICNkZWZpbmUgY3B1 X2hhc19hdng1MTJfNHZubml3ICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJF X0FWWDUxMl80Vk5OSVcpCiAjZGVmaW5lIGNwdV9oYXNfYXZ4NTEyXzRmbWFw cyAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9BVlg1MTJfNEZNQVBTKQpk aWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3N2bS5o IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3N2bS5oCmluZGV4IDUy NzUyZmU1YWI5Yy4uMmI1MjJlZTc5YjE3IDEwMDY0NAotLS0gYS94ZW4vaW5j bHVkZS9hc20teDg2L2h2bS9zdm0vc3ZtLmgKKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9odm0vc3ZtL3N2bS5oCkBAIC03NCw2ICs3NCw3IEBAIGV4dGVy biB1MzIgc3ZtX2ZlYXR1cmVfZmxhZ3M7CiAjZGVmaW5lIFNWTV9GRUFUVVJF X1BBVVNFVEhSRVNIICAgMTIgLyogUGF1c2UgaW50ZXJjZXB0IGZpbHRlciBz dXBwb3J0ICovCiAjZGVmaW5lIFNWTV9GRUFUVVJFX1ZMT0FEU0FWRSAgICAg MTUgLyogdmlydHVhbCB2bWxvYWQvdm1zYXZlICovCiAjZGVmaW5lIFNWTV9G RUFUVVJFX1ZHSUYgICAgICAgICAgMTYgLyogVmlydHVhbCBHSUYgKi8KKyNk ZWZpbmUgU1ZNX0ZFQVRVUkVfU1BFQ19DVFJMICAgICAyMCAvKiBNU1JfU1BF Q19DVFJMIHZpcnR1YWxpc2F0aW9uICovCiAKICNkZWZpbmUgY3B1X2hhc19z dm1fZmVhdHVyZShmKSAoc3ZtX2ZlYXR1cmVfZmxhZ3MgJiAoMXUgPDwgKGYp KSkKICNkZWZpbmUgY3B1X2hhc19zdm1fbnB0ICAgICAgIGNwdV9oYXNfc3Zt X2ZlYXR1cmUoU1ZNX0ZFQVRVUkVfTlBUKQpAQCAtODcsNiArODgsNyBAQCBl eHRlcm4gdTMyIHN2bV9mZWF0dXJlX2ZsYWdzOwogI2RlZmluZSBjcHVfaGFz X3BhdXNlX3RocmVzaCAgY3B1X2hhc19zdm1fZmVhdHVyZShTVk1fRkVBVFVS RV9QQVVTRVRIUkVTSCkKICNkZWZpbmUgY3B1X2hhc190c2NfcmF0aW8gICAg IGNwdV9oYXNfc3ZtX2ZlYXR1cmUoU1ZNX0ZFQVRVUkVfVFNDUkFURU1TUikK ICNkZWZpbmUgY3B1X2hhc19zdm1fdmxvYWRzYXZlIGNwdV9oYXNfc3ZtX2Zl YXR1cmUoU1ZNX0ZFQVRVUkVfVkxPQURTQVZFKQorI2RlZmluZSBjcHVfaGFz X3N2bV9zcGVjX2N0cmwgY3B1X2hhc19zdm1fZmVhdHVyZShTVk1fRkVBVFVS RV9TUEVDX0NUUkwpCiAKICNkZWZpbmUgU1ZNX1BBVVNFRklMVEVSX0lOSVQg ICAgNDAwMAogI2RlZmluZSBTVk1fUEFVU0VUSFJFU0hfSU5JVCAgICAxMDAw CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0vdm1j Yi5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3ZtY2IuaAppbmRl eCAxMGI1MWM2NGJiM2IuLjU2MGRiYjI4NzM2ZiAxMDA2NDQKLS0tIGEveGVu L2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3ZtY2IuaAorKysgYi94ZW4vaW5j bHVkZS9hc20teDg2L2h2bS9zdm0vdm1jYi5oCkBAIC00OTQsNyArNDk0LDkg QEAgc3RydWN0IHZtY2Jfc3RydWN0IHsKICAgICB1NjQgX2xhc3RicmFuY2h0 b2lwOyAgICAgICAgLyogY2xlYW5iaXQgMTAgKi8KICAgICB1NjQgX2xhc3Rp bnRmcm9taXA7ICAgICAgICAgLyogY2xlYW5iaXQgMTAgKi8KICAgICB1NjQg X2xhc3RpbnR0b2lwOyAgICAgICAgICAgLyogY2xlYW5iaXQgMTAgKi8KLSAg ICB1NjQgcmVzMTdbMzAxXTsKKyAgICB1NjQgcmVzMTdbOV07CisgICAgdTY0 IHNwZWNfY3RybDsKKyAgICB1NjQgcmVzMThbMjkxXTsKIH07CiAKIHN0cnVj dCBzdm1fZG9tYWluIHsKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14 ODYvbXNyLWluZGV4LmggYi94ZW4vaW5jbHVkZS9hc20teDg2L21zci1pbmRl eC5oCmluZGV4IDJhODA2NjBkODQ5ZC4uMjA2NTNiZDY2MDFlIDEwMDY0NAot LS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L21zci1pbmRleC5oCisrKyBiL3hl bi9pbmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmgKQEAgLTQxLDYgKzQxLDcg QEAKICNkZWZpbmUgU1BFQ19DVFJMX0lCUlMJCQkoX0FDKDEsIFVMTCkgPDwg MCkKICNkZWZpbmUgU1BFQ19DVFJMX1NUSUJQCQkJKF9BQygxLCBVTEwpIDw8 IDEpCiAjZGVmaW5lIFNQRUNfQ1RSTF9TU0JECQkJKF9BQygxLCBVTEwpIDw8 IDIpCisjZGVmaW5lIFNQRUNfQ1RSTF9QU0ZECQkJKF9BQygxLCBVTEwpIDw8 IDcpCiAKICNkZWZpbmUgTVNSX1BSRURfQ01ECQkJMHgwMDAwMDA0OQogI2Rl ZmluZSBQUkVEX0NNRF9JQlBCCQkJKF9BQygxLCBVTEwpIDw8IDApCkBAIC0y NzIsNiArMjczLDcgQEAKICNkZWZpbmUgTVNSX0s4X0VOQUJMRV9DMUUJCTB4 YzAwMTAwNTUKICNkZWZpbmUgTVNSX0s4X1ZNX0NSCQkJMHhjMDAxMDExNAog I2RlZmluZSBNU1JfSzhfVk1fSFNBVkVfUEEJCTB4YzAwMTAxMTcKKyNkZWZp bmUgTVNSX1ZJUlRfU1BFQ19DVFJMCQkweGMwMDEwMTFmIC8qIExheW91dCBt YXRjaGVzIE1TUl9TUEVDX0NUUkwgKi8KIAogI2RlZmluZSBNU1JfRjE1SF9D VV9QT1dFUgkJMHhjMDAxMDA3YQogI2RlZmluZSBNU1JfRjE1SF9DVV9NQVhf UE9XRVIJCTB4YzAwMTAwN2IKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1 YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IGExZDE2MTk2 NDNlMy4uNjA4NGUwNTY5ZGU0IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9pbmNs dWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI0OCw2 ICsyNDgsMTYgQEAgWEVOX0NQVUZFQVRVUkUoQ0xaRVJPLCAgICAgICAgOCoz MisgMCkgLypBICBDTFpFUk8gaW5zdHJ1Y3Rpb24gKi8KIFhFTl9DUFVGRUFU VVJFKFJTVFJfRlBfRVJSX1BUUlMsIDgqMzIrIDIpIC8qQSAgKEYpWHtTQVZF LFJTVE9SfSBhbHdheXMgc2F2ZXMvcmVzdG9yZXMgRlBVIEVycm9yIHBvaW50 ZXJzICovCiBYRU5fQ1BVRkVBVFVSRShXQk5PSU5WRCwgICAgICA4KjMyKyA5 KSAvKiAgIFdCTk9JTlZEIGluc3RydWN0aW9uICovCiBYRU5fQ1BVRkVBVFVS RShJQlBCLCAgICAgICAgICA4KjMyKzEyKSAvKkEgIElCUEIgc3VwcG9ydCBv bmx5IChubyBJQlJTLCB1c2VkIGJ5IEFNRCkgKi8KK1hFTl9DUFVGRUFUVVJF KElCUlMsICAgICAgICAgIDgqMzIrMTQpIC8qICAgTVNSX1NQRUNfQ1RSTC5J QlJTICovCitYRU5fQ1BVRkVBVFVSRShBTURfU1RJQlAsICAgICA4KjMyKzE1 KSAvKiAgIE1TUl9TUEVDX0NUUkwuU1RJQlAgKi8KK1hFTl9DUFVGRUFUVVJF KElCUlNfQUxXQVlTLCAgIDgqMzIrMTYpIC8qICAgSUJSUyBwcmVmZXJyZWQg YWx3YXlzIG9uICovCitYRU5fQ1BVRkVBVFVSRShTVElCUF9BTFdBWVMsICA4 KjMyKzE3KSAvKiAgIFNUSUJQIHByZWZlcnJlZCBhbHdheXMgb24gKi8KK1hF Tl9DUFVGRUFUVVJFKElCUlNfRkFTVCwgICAgIDgqMzIrMTgpIC8qICAgSUJS UyBwcmVmZXJyZWQgb3ZlciBzb2Z0d2FyZSBvcHRpb25zICovCitYRU5fQ1BV RkVBVFVSRShJQlJTX1NBTUVfTU9ERSwgOCozMisxOSkgLyogICBJQlJTIHBy b3ZpZGVzIHNhbWUtbW9kZSBwcm90ZWN0aW9uICovCitYRU5fQ1BVRkVBVFVS RShBTURfU1NCRCwgICAgICA4KjMyKzI0KSAvKiAgIE1TUl9TUEVDX0NUUkwu U1NCRCBhdmFpbGFibGUgKi8KK1hFTl9DUFVGRUFUVVJFKFZJUlRfU1NCRCwg ICAgIDgqMzIrMjUpIC8qICAgTVNSX1ZJUlRfU1BFQ19DVFJMLlNTQkQgKi8K K1hFTl9DUFVGRUFUVVJFKFNTQl9OTywgICAgICAgIDgqMzIrMjYpIC8qICAg SGFyZHdhcmUgbm90IHZ1bG5lcmFibGUgdG8gU1NCICovCitYRU5fQ1BVRkVB VFVSRShQU0ZELCAgICAgICAgICA4KjMyKzI4KSAvKiAgIE1TUl9TUEVDX0NU UkwuUFNGRCAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0dXJlcywg Q1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICovCiBYRU5f Q1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEgIEFWWDUx MiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-04.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-04.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2FtZDogVXNlIG5ld2VyIFNTQkQgbWVjaGFuaXNt cyBpZiB0aGV5IGV4aXN0CgpUaGUgb3BlbmNvZGVkIGxlZ2FjeSBNZW1vcnkg RGlzYW1iaWd1YXRpb24gbG9naWMgaW4gaW5pdF9hbWQoKSBuZWdsZWN0ZWQK RmFtMTloIGZvciB0aGUgWmVuMyBtaWNyb2FyY2hpdGVjdHVyZS4gIEZ1cnRo ZXIgbW9yZSwgYWxsIFplbjIgYmFzZWQgc3lzdGVtCmhhdmUgdGhlIGFyY2hp dGVjdHVyYWwgTVNSX1NQRUNfQ1RSTCBhbmQgdGhlIFNTQkQgYml0IHdpdGhp biBpdCwgc28gc2hvdWxkbid0CmJlIHVzaW5nIE1TUl9BTUQ2NF9MU19DRkcu CgpJbXBsZW1lbnQgdGhlIGFsZ29yaXRobSBnaXZlbiBpbiBBTUQncyBTU0JE IHdoaXRlcGFwZXIsIGFuZCBsZWF2ZSBhCnByaW50a19vbmNlKCkgYmVoaW5k IGluIHRoZSBjYXNlIHRoYXQgbm8gY29udHJvbHMgY2FuIGJlIGZvdW5kLgoK VGhpcyBub3cgbWVhbnMgdGhhdCBhIHVzZXIgZXhwbGljaXRseSBjaG9vc2lu ZyBgc3BlYy1jdHJsPXNzYmRgIHdpbGwgcHJvcGVybHkKdHVybiBvZmYgTWVt b3J5IERpc2FtYmlndWF0aW9uIG9uIEZhbTE5aC9aZW4zIHN5c3RlbXMuCgpU aGlzIHN0aWxsIHJlbWFpbnMgYSBzaW5nbGUgc3lzdGVtLXdpZGUgc2V0dGlu ZyAoZm9yIG5vdyksIGFuZCBpcyBub3QgY29udGV4dApzd2l0Y2hlZCBiZXR3 ZWVuIHZDUFVzLiAgQXMgc3VjaCwgaXQgZG9lc24ndCBpbnRlcmFjdCB3aXRo IEludGVsJ3MgdXNlIG9mCk1TUl9TUEVDX0NUUkwgYW5kIGRlZmF1bHRfeGVu X3NwZWNfY3RybCAoeWV0KS4KClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29w ZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBK YW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CihjaGVycnkgcGlja2Vk IGZyb20gY29tbWl0IDJhNGU2YzRlNGJlYTJlMGJiNzIwNDE4YzMzMWVlMjhm ZjljNzYzMmUpCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9hbWQu YyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKaW5kZXggYWExYjlkMGRkYTZi Li5kZTAzODk4MTBiMjUgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMKKysrIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpAQCAtNTQwLDYg KzU0MCw1NiBAQCB2b2lkIGVhcmx5X2luaXRfYW1kKHN0cnVjdCBjcHVpbmZv X3g4NiAqYykKIAljdHh0X3N3aXRjaF9sZXZlbGxpbmcoTlVMTCk7CiB9CiAK Ky8qCisgKiBSZWZlciB0byB0aGUgQU1EIFNwZWN1bGF0aXZlIFN0b3JlIEJ5 cGFzcyB3aGl0ZXBhcGVyOgorICogaHR0cHM6Ly9kZXZlbG9wZXIuYW1kLmNv bS93cC1jb250ZW50L3Jlc291cmNlcy8xMjQ0NDFfQU1ENjRfU3BlY3VsYXRp dmVTdG9yZUJ5cGFzc0Rpc2FibGVfV2hpdGVwYXBlcl9maW5hbC5wZGYKKyAq Lwordm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVjdCBjcHVpbmZvX3g4 NiAqYykKK3sKKwlpbnQgYml0ID0gLTE7CisKKwlpZiAoY3B1X2hhc19zc2Jf bm8pCisJCXJldHVybjsKKworCWlmIChjcHVfaGFzX2FtZF9zc2JkKSB7CisJ CXdybXNybChNU1JfU1BFQ19DVFJMLCBvcHRfc3NiZCA/IFNQRUNfQ1RSTF9T U0JEIDogMCk7CisJCXJldHVybjsKKwl9CisKKwlpZiAoY3B1X2hhc192aXJ0 X3NzYmQpIHsKKwkJd3Jtc3JsKE1TUl9WSVJUX1NQRUNfQ1RSTCwgb3B0X3Nz YmQgPyBTUEVDX0NUUkxfU1NCRCA6IDApOworCQlyZXR1cm47CisJfQorCisJ c3dpdGNoIChjLT54ODYpIHsKKwljYXNlIDB4MTU6IGJpdCA9IDU0OyBicmVh azsKKwljYXNlIDB4MTY6IGJpdCA9IDMzOyBicmVhazsKKwljYXNlIDB4MTc6 CisJY2FzZSAweDE4OiBiaXQgPSAxMDsgYnJlYWs7CisJfQorCisJaWYgKGJp dCA+PSAwKSB7CisJCXVpbnQ2NF90IHZhbCwgbWFzayA9IDF1bGwgPDwgYml0 OworCisJCWlmIChyZG1zcl9zYWZlKE1TUl9BTUQ2NF9MU19DRkcsIHZhbCkg fHwKKwkJICAgICh7CisJCQkgICAgdmFsICY9IH5tYXNrOworCQkJICAgIGlm IChvcHRfc3NiZCkKKwkJCQkgICAgdmFsIHw9IG1hc2s7CisJCQkgICAgZmFs c2U7CisJCSAgICB9KSB8fAorCQkgICAgd3Jtc3Jfc2FmZShNU1JfQU1ENjRf TFNfQ0ZHLCB2YWwpIHx8CisJCSAgICAoeworCQkJICAgIHJkbXNybChNU1Jf QU1ENjRfTFNfQ0ZHLCB2YWwpOworCQkJICAgICh2YWwgJiBtYXNrKSAhPSAo b3B0X3NzYmQgKiBtYXNrKTsKKwkJICAgIH0pKQorCQkJYml0ID0gLTE7CisJ fQorCisJaWYgKGJpdCA8IDApCisJCXByaW50a19vbmNlKFhFTkxPR19FUlIg Ik5vIFNTQkQgY29udHJvbHMgYXZhaWxhYmxlXG4iKTsKK30KKwogc3RhdGlj IHZvaWQgaW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKQogewogCXUz MiBsLCBoOwpAQCAtNjE2LDI0ICs2NjYsNyBAQCBzdGF0aWMgdm9pZCBpbml0 X2FtZChzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAJCQkJICBjLT54ODZfY2Fw YWJpbGl0eSk7CiAJfQogCi0JLyoKLQkgKiBJZiB0aGUgdXNlciBoYXMgZXhw bGljaXRseSBjaG9zZW4gdG8gZGlzYWJsZSBNZW1vcnkgRGlzYW1iaWd1YXRp b24KLQkgKiB0byBtaXRpZ2lhdGUgU3BlY3VsYXRpdmUgU3RvcmUgQnlwYXNz LCBwb2tlIHRoZSBhcHByb3ByaWF0ZSBNU1IuCi0JICovCi0JaWYgKG9wdF9z c2JkKSB7Ci0JCWludCBiaXQgPSAtMTsKLQotCQlzd2l0Y2ggKGMtPng4Nikg ewotCQljYXNlIDB4MTU6IGJpdCA9IDU0OyBicmVhazsKLQkJY2FzZSAweDE2 OiBiaXQgPSAzMzsgYnJlYWs7Ci0JCWNhc2UgMHgxNzogYml0ID0gMTA7IGJy ZWFrOwotCQl9Ci0KLQkJaWYgKGJpdCA+PSAwICYmICFyZG1zcl9zYWZlKE1T Ul9BTUQ2NF9MU19DRkcsIHZhbHVlKSkgewotCQkJdmFsdWUgfD0gMXVsbCA8 PCBiaXQ7Ci0JCQl3cm1zcl9zYWZlKE1TUl9BTUQ2NF9MU19DRkcsIHZhbHVl KTsKLQkJfQotCX0KKwlhbWRfaW5pdF9zc2JkKGMpOwogCiAJLyogTUZFTkNF IHN0b3BzIFJEVFNDIHNwZWN1bGF0aW9uICovCiAJaWYgKCFjcHVfaGFzX2xm ZW5jZV9kaXNwYXRjaCkKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv Y3B1LmggYi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCmluZGV4IGMyZjRkOWEw NmFlNS4uMjNjY2Q2NjExNTY1IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2NwdS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvY3B1LmgKQEAgLTE5 LDMgKzE5LDQgQEAgZXh0ZXJuIHZvaWQgZGV0ZWN0X2h0KHN0cnVjdCBjcHVp bmZvX3g4NiAqYyk7CiBleHRlcm4gYm9vbCBkZXRlY3RfZXh0ZW5kZWRfdG9w b2xvZ3koc3RydWN0IGNwdWluZm9feDg2ICpjKTsKIAogdm9pZCBlYXJseV9p bml0X2FtZChzdHJ1Y3QgY3B1aW5mb194ODYgKmMpOwordm9pZCBhbWRfaW5p dF9zc2JkKGNvbnN0IHN0cnVjdCBjcHVpbmZvX3g4NiAqYyk7CmRpZmYgLS1n aXQgYS94ZW4vYXJjaC94ODYvY3B1L2h5Z29uLmMgYi94ZW4vYXJjaC94ODYv Y3B1L2h5Z29uLmMKaW5kZXggOWFiN2FhODYyMmU3Li5iNzY5ZThhZDkwNjIg MTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYworKysgYi94 ZW4vYXJjaC94ODYvY3B1L2h5Z29uLmMKQEAgLTU5LDE0ICs1OSw3IEBAIHN0 YXRpYyB2b2lkIGluaXRfaHlnb24oc3RydWN0IGNwdWluZm9feDg2ICpjKQog CQlfX3NldF9iaXQoWDg2X0ZFQVRVUkVfTEZFTkNFX0RJU1BBVENILAogCQkJ ICBjLT54ODZfY2FwYWJpbGl0eSk7CiAKLQkvKgotCSAqIElmIHRoZSB1c2Vy IGhhcyBleHBsaWNpdGx5IGNob3NlbiB0byBkaXNhYmxlIE1lbW9yeSBEaXNh bWJpZ3VhdGlvbgotCSAqIHRvIG1pdGlnaWF0ZSBTcGVjdWxhdGl2ZSBTdG9y ZSBCeXBhc3MsIHBva2UgdGhlIGFwcHJvcHJpYXRlIE1TUi4KLQkgKi8KLQlp ZiAob3B0X3NzYmQgJiYgIXJkbXNyX3NhZmUoTVNSX0FNRDY0X0xTX0NGRywg dmFsdWUpKSB7Ci0JCXZhbHVlIHw9IDF1bGwgPDwgMTA7Ci0JCXdybXNyX3Nh ZmUoTVNSX0FNRDY0X0xTX0NGRywgdmFsdWUpOwotCX0KKwlhbWRfaW5pdF9z c2JkKGMpOwogCiAJLyogTUZFTkNFIHN0b3BzIFJEVFNDIHNwZWN1bGF0aW9u ICovCiAJaWYgKCFjcHVfaGFzX2xmZW5jZV9kaXNwYXRjaCkKZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9z cGVjX2N0cmwuYwppbmRleCBmZWMxNDVhN2I5ZTEuLmJlMzUyOGMyOGViYiAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtMzMxLDYgKzMzMSw3IEBAIHN0 YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxzKGVudW0gaW5kX3RodW5r IHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAgICAgICAoY2FwcyAmIEFS Q0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAgICAgICAgICAgID8gIiBJ QlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNI X0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUlNC QSIgICAgICAgICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9D QVBTX1NLSVBfTDFERkwpICAgICAgICAgICAgICAgICAgICAgPyAiIFNLSVBf TDFERkwiICAgICA6ICIiLAorICAgICAgICAgICAoZThiICAmIGNwdWZlYXRf bWFzayhYODZfRkVBVFVSRV9TU0JfTk8pKSB8fAogICAgICAgICAgICAoY2Fw cyAmIEFSQ0hfQ0FQU19TU0JfTk8pICAgICAgICAgICAgICAgICAgICAgICAg ID8gIiBTU0JfTk8iICAgICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMg JiBBUkNIX0NBUFNfTURTX05PKSAgICAgICAgICAgICAgICAgICAgICAgICA/ ICIgTURTX05PIiAgICAgICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYg QVJDSF9DQVBTX1RBQV9OTykgICAgICAgICAgICAgICAgICAgICAgICAgPyAi IFRBQV9OTyIgICAgICAgICA6ICIiLApAQCAtMzM5LDE1ICszNDAsMTcgQEAg c3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1 bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChjYXBzICYg QVJDSF9DQVBTX1BTRFBfTk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAi IFBTRFBfTk8iICAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZl YXR1cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMu ICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVz JXMlcyVzJXMlcyVzXG4iLAorICAgIHByaW50aygiICBIYXJkd2FyZSBmZWF0 dXJlczolcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLAogICAgICAgICAgICAo ZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlBCKSkgfHwKICAg ICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJS U0IpKSAgICAgICAgICA/ICIgSUJQQiIgICAgICAgICAgIDogIiIsCiAgICAg ICAgICAgIChfN2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNC KSkgICAgICAgICAgPyAiIElCUlMiICAgICAgICAgICA6ICIiLAogICAgICAg ICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9TVElCUCkp ICAgICAgICAgID8gIiBTVElCUCIgICAgICAgICAgOiAiIiwKKyAgICAgICAg ICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQU1EX1NTQkQp KSB8fAogICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVB VFVSRV9TU0JEKSkgICAgICAgICAgID8gIiBTU0JEIiAgICAgICAgICAgOiAi IiwKICAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfTDFEX0ZMVVNIKSkgICAgICA/ICIgTDFEX0ZMVVNIIiAgICAgIDogIiIs CiAgICAgICAgICAgIChfN2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJF X01EX0NMRUFSKSkgICAgICAgPyAiIE1EX0NMRUFSIiAgICAgICA6ICIiLAog ICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9T UkJEU19DVFJMKSkgICAgID8gIiBTUkJEU19DVFJMIiAgICAgOiAiIiwKKyAg ICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfVklS VF9TU0JEKSkgICAgICA/ICIgVklSVF9TU0JEIiAgICAgIDogIiIsCiAgICAg ICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1RTWF9DVFJMKSAgICAgICAgICAg ICAgICAgICAgICAgPyAiIFRTWF9DVFJMIiAgICAgICA6ICIiLAogICAgICAg ICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19GQl9DTEVBUikgICAgICAgICAgICAg ICAgICAgICAgID8gIiBGQl9DTEVBUiIgICAgICAgOiAiIiwKICAgICAgICAg ICAgKGNhcHMgJiBBUkNIX0NBUFNfRkJfQ0xFQVJfQ1RSTCkgICAgICAgICAg ICAgICAgICA/ICIgRkJfQ0xFQVJfQ1RSTCIgIDogIiIpOwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-05.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-05.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUHJpbnQgYWxsIEFNRCBzcGVj dWxhdGl2ZSBoaW50cy9mZWF0dXJlcwoKV2UgYWxyZWFkeSBwcmludCBJbnRl bCBmZWF0dXJlcyB0aGF0IGFyZW4ndCB5ZXQgaW1wbGVtZW50ZWQvdXNlZCwg c28gYmUKY29uc2lzdGVudCBvbiBBTUQgdG9vLgoKU2lnbmVkLW9mZi1ieTog QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KUmV2 aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KKGNo ZXJyeSBwaWNrZWQgZnJvbSBjb21taXQgM2QxODlmMTZhMTFkNWEyMDlmYjQ3 ZmEzNjM1ODQ3NjA4ZDQzNzQ1YykKW0ZvcndhcmQgcG9ydCBvdmVyIFhTQS0z OThdCgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCmluZGV4IGJlMzUyOGMyOGViYi4u MGNjOWIzZmVkNTJjIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKKysrIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0zMjYs NyArMzI2LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMo ZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICog SGFyZHdhcmUgcmVhZC1vbmx5IGluZm9ybWF0aW9uLCBzdGF0aW5nIGltbXVu aXR5IHRvIGNlcnRhaW4gaXNzdWVzLCBvcgogICAgICAqIHN1Z2dlc3Rpb25z IG9mIHdoaWNoIG1pdGlnYXRpb24gdG8gdXNlLgogICAgICAqLwotICAgIHBy aW50aygiICBIYXJkd2FyZSBoaW50czolcyVzJXMlcyVzJXMlcyVzJXMlc1xu IiwKKyAgICBwcmludGsoIiAgSGFyZHdhcmUgaGludHM6JXMlcyVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNI X0NBUFNfUkRDTF9OTykgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUkRD TF9OTyIgICAgICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9D QVBTX0lCUlNfQUxMKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUlNf QUxMIiAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQ U19SU0JBKSAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBSU0JBIiAg ICAgICAgICAgOiAiIiwKQEAgLTMzNywxNiArMzM3LDIzIEBAIHN0YXRpYyB2 b2lkIF9faW5pdCBwcmludF9kZXRhaWxzKGVudW0gaW5kX3RodW5rIHRodW5r LCB1aW50NjRfdCBjYXBzKQogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQ U19UQUFfTk8pICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBUQUFfTk8i ICAgICAgICAgOiAiIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNf U0JEUl9TU0RQX05PKSAgICAgICAgICAgICAgICAgICA/ICIgU0JEUl9TU0RQ X05PIiAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBTX0ZC U0RQX05PKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIEZCU0RQX05PIiAg ICAgICA6ICIiLAotICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19QU0RQ X05PKSAgICAgICAgICAgICAgICAgICAgICAgID8gIiBQU0RQX05PIiAgICAg ICAgOiAiIik7CisgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBTX1BTRFBf Tk8pICAgICAgICAgICAgICAgICAgICAgICAgPyAiIFBTRFBfTk8iICAgICAg ICA6ICIiLAorICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX0FMV0FZUykpICAgID8gIiBJQlJTX0FMV0FZUyIgICAg OiAiIiwKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfU1RJQlBfQUxXQVlTKSkgICA/ICIgU1RJQlBfQUxXQVlTIiAgIDog IiIsCisgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX0lCUlNfRkFTVCkpICAgICAgPyAiIElCUlNfRkFTVCIgICAgICA6ICIi LAorICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVS RV9JQlJTX1NBTUVfTU9ERSkpID8gIiBJQlJTX1NBTUVfTU9ERSIgOiAiIik7 CiAKICAgICAvKiBIYXJkd2FyZSBmZWF0dXJlcyB3aGljaCBuZWVkIGRyaXZp bmcgdG8gbWl0aWdhdGUgaXNzdWVzLiAqLwotICAgIHByaW50aygiICBIYXJk d2FyZSBmZWF0dXJlczolcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLAorICAg IHByaW50aygiICBIYXJkd2FyZSBmZWF0dXJlczolcyVzJXMlcyVzJXMlcyVz JXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNr KFg4Nl9GRUFUVVJFX0lCUEIpKSB8fAogICAgICAgICAgICAoXzdkMCAmIGNw dWZlYXRfbWFzayhYODZfRkVBVFVSRV9JQlJTQikpICAgICAgICAgID8gIiBJ QlBCIiAgICAgICAgICAgOiAiIiwKKyAgICAgICAgICAgKGU4YiAgJiBjcHVm ZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSUykpIHx8CiAgICAgICAgICAgIChf N2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNCKSkgICAgICAg ICAgPyAiIElCUlMiICAgICAgICAgICA6ICIiLAorICAgICAgICAgICAoZThi ICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9BTURfU1RJQlApKSB8fAog ICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9T VElCUCkpICAgICAgICAgID8gIiBTVElCUCIgICAgICAgICAgOiAiIiwKICAg ICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQU1E X1NTQkQpKSB8fAogICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhY ODZfRkVBVFVSRV9TU0JEKSkgICAgICAgICAgID8gIiBTU0JEIiAgICAgICAg ICAgOiAiIiwKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2 X0ZFQVRVUkVfUFNGRCkpICAgICAgICAgICA/ICIgUFNGRCIgICAgICAgICAg IDogIiIsCiAgICAgICAgICAgIChfN2QwICYgY3B1ZmVhdF9tYXNrKFg4Nl9G RUFUVVJFX0wxRF9GTFVTSCkpICAgICAgPyAiIEwxRF9GTFVTSCIgICAgICA6 ICIiLAogICAgICAgICAgICAoXzdkMCAmIGNwdWZlYXRfbWFzayhYODZfRkVB VFVSRV9NRF9DTEVBUikpICAgICAgID8gIiBNRF9DTEVBUiIgICAgICAgOiAi IiwKICAgICAgICAgICAgKF83ZDAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRV UkVfU1JCRFNfQ1RSTCkpICAgICA/ICIgU1JCRFNfQ1RSTCIgICAgIDogIiIs CkBAIC0zNjcsMTQgKzM3NCwxOSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgcHJp bnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywgdWludDY0X3QgY2Fw cykKICAgICAgICAgICAgICAgICJcbiIpOwogCiAgICAgLyogU2V0dGluZ3Mg Zm9yIFhlbidzIHByb3RlY3Rpb24sIGlycmVzcGVjdGl2ZSBvZiBndWVzdHMu ICovCi0gICAgcHJpbnRrKCIgIFhlbiBzZXR0aW5nczogQlRJLVRodW5rICVz LCBTUEVDX0NUUkw6ICVzJXMlcywgT3RoZXI6JXMlcyVzJXMlc1xuIiwKKyAg ICBwcmludGsoIiAgWGVuIHNldHRpbmdzOiBCVEktVGh1bmsgJXMsIFNQRUNf Q1RSTDogJXMlcyVzJXMsIE90aGVyOiVzJXMlcyVzJXNcbiIsCiAgICAgICAg ICAgIHRodW5rID09IFRIVU5LX05PTkUgICAgICA/ICJOL0EiIDoKICAgICAg ICAgICAgdGh1bmsgPT0gVEhVTktfUkVUUE9MSU5FID8gIlJFVFBPTElORSIg OgogICAgICAgICAgICB0aHVuayA9PSBUSFVOS19MRkVOQ0UgICAgPyAiTEZF TkNFIiA6CiAgICAgICAgICAgIHRodW5rID09IFRIVU5LX0pNUCAgICAgICA/ ICJKTVAiIDogIj8iLAotICAgICAgICAgICAhYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0lCUlNCKSAgICAgICAgICA/ICJObyIgOgorICAgICAgICAgICAo IWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikgJiYKKyAgICAgICAg ICAgICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykpICAgICAgICAg PyAiTm8iIDoKICAgICAgICAgICAgKGRlZmF1bHRfeGVuX3NwZWNfY3RybCAm IFNQRUNfQ1RSTF9JQlJTKSAgPyAiSUJSUysiIDogICJJQlJTLSIsCi0gICAg ICAgICAgICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU1NCRCkgICAgICAg ICAgID8gIiIgOgorICAgICAgICAgICAoIWJvb3RfY3B1X2hhcyhYODZfRkVB VFVSRV9TVElCUCkgJiYKKyAgICAgICAgICAgICFib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfQU1EX1NUSUJQKSkgICAgPyAiIiA6CisgICAgICAgICAgIChk ZWZhdWx0X3hlbl9zcGVjX2N0cmwgJiBTUEVDX0NUUkxfU1RJQlApID8gIiBT VElCUCsiIDogIiBTVElCUC0iLAorICAgICAgICAgICAoIWJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9TU0JEKSAmJgorICAgICAgICAgICAgIWJvb3RfY3B1 X2hhcyhYODZfRkVBVFVSRV9BTURfU1NCRCkpICAgICA/ICIiIDoKICAgICAg ICAgICAgKGRlZmF1bHRfeGVuX3NwZWNfY3RybCAmIFNQRUNfQ1RSTF9TU0JE KSAgPyAiIFNTQkQrIiA6ICIgU1NCRC0iLAogICAgICAgICAgICAhKGNhcHMg JiBBUkNIX0NBUFNfVFNYX0NUUkwpICAgICAgICAgICAgICA/ICIiIDoKICAg ICAgICAgICAgKG9wdF90c3ggJiAxKSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgPyAiIFRTWCsiIDogIiBUU1gtIiwK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-06.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-06.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRHJvcCB1c2Vfc3BlY19jdHJs IGJvb2xlYW4KClNldmVyYWwgYnVnZml4ZXMgaGF2ZSByZWR1Y2VkIHRoZSB1 dGlsaXR5IG9mIHRoaXMgdmFyaWFibGUgZnJvbSBpdCdzIG9yaWdpbmFsCnB1 cnBvc2UsIGFuZCBub3cgYWxsIGl0IGRvZXMgaXMgYWlkIGluIHRoZSBzZXR1 cCBvZiBTQ0ZfaXN0X3dybXNyLgoKU2ltcGxpZnkgdGhlIGxvZ2ljIGJ5IGRy b3AgdGhlIHZhcmlhYmxlLCBhbmQgZG91YmxpbmcgdXAgdGhlIHNldHRpbmcg b2YKU0NGX2lzdF93cm1zciBmb3IgdGhlIFBWIGFuZCBIVk0gYmxvY2tzLCB3 aGljaCB3aWxsIG1ha2UgdGhlIEFNRCBTUEVDX0NUUkwKc3VwcG9ydCBlYXNp ZXIgdG8gZm9sbG93LiAgTGVhdmUgYSBjb21tZW50IGV4cGxhaW5pbmcgd2h5 IFNDRl9pc3Rfd3Jtc3IgaXMKc3RpbGwgbmVjZXNzYXJ5IGZvciB0aGUgVk1F eGl0IGNhc2UuCgpObyBmdW5jdGlvbmFsIGNoYW5nZS4KClNpZ25lZC1vZmYt Ynk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IGVjMDgzYmY1NTJjMzVlMTAz NDc0NDllMjE4MDlmNDc4MGY4MTU1ZDIpCgpkaWZmIC0tZ2l0IGEveGVuL2Fy Y2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5j CmluZGV4IDBjYzliM2ZlZDUyYy4uYTA3MmVjOTg3NzkzIDEwMDY0NAotLS0g YS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jCkBAIC05MjMsNyArOTIzLDcgQEAgdm9pZCBzcGVjX2N0 cmxfaW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCkKIHZvaWQgX19pbml0 IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnModm9pZCkKIHsKICAgICBl bnVtIGluZF90aHVuayB0aHVuayA9IFRIVU5LX0RFRkFVTFQ7Ci0gICAgYm9v bCB1c2Vfc3BlY19jdHJsID0gZmFsc2UsIGlicnMgPSBmYWxzZSwgaHdfc210 X2VuYWJsZWQ7CisgICAgYm9vbCBpYnJzID0gZmFsc2UsIGh3X3NtdF9lbmFi bGVkOwogICAgIGJvb2wgY3B1X2hhc19idWdfdGFhOwogICAgIHVpbnQ2NF90 IGNhcHMgPSAwOwogCkBAIC05OTgsMTkgKzk5OCwyMSBAQCB2b2lkIF9faW5p dCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAgICAgewog ICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAgICAgICB7Ci0gICAg ICAgICAgICB1c2Vfc3BlY19jdHJsID0gdHJ1ZTsKKyAgICAgICAgICAgIGRl ZmF1bHRfc3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfd3Jtc3I7CiAgICAg ICAgICAgICBzZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01T Ul9QVik7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAoIG9wdF9tc3Jfc2Nf aHZtICkKICAgICAgICAgewotICAgICAgICAgICAgdXNlX3NwZWNfY3RybCA9 IHRydWU7CisgICAgICAgICAgICAvKgorICAgICAgICAgICAgICogV2hpbGUg dGhlIGd1ZXN0IE1TUl9TUEVDX0NUUkwgdmFsdWUgaXMgbG9hZGVkL3NhdmVk IGF0b21pY2FsbHksCisgICAgICAgICAgICAgKiBYZW4ncyB2YWx1ZSBpcyBu b3QgcmVzdG9yZWQgYXRvbWljYWxseS4gIEFuIGVhcmx5IE5NSSBoaXR0aW5n CisgICAgICAgICAgICAgKiB0aGUgVk1FeGl0IHBhdGggbmVlZHMgdG8gcmVz dG9yZSBYZW4ncyB2YWx1ZSBmb3Igc2FmZXR5LgorICAgICAgICAgICAgICov CisgICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8PSBTQ0Zf aXN0X3dybXNyOwogICAgICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChY ODZfRkVBVFVSRV9TQ19NU1JfSFZNKTsKICAgICAgICAgfQogCi0gICAgICAg IGlmICggdXNlX3NwZWNfY3RybCApCi0gICAgICAgICAgICBkZWZhdWx0X3Nw ZWNfY3RybF9mbGFncyB8PSBTQ0ZfaXN0X3dybXNyOwotCiAgICAgICAgIGlm ICggaWJycyApCiAgICAgICAgICAgICBkZWZhdWx0X3hlbl9zcGVjX2N0cmwg fD0gU1BFQ19DVFJMX0lCUlM7CiAgICAgfQo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-07.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-07.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogSW50cm9kdWNlIG5ldyBoYXNf c3BlY19jdHJsIGJvb2xlYW4KCk1vc3QgTVNSX1NQRUNfQ1RSTCBzZXR1cCB3 aWxsIGJlIGNvbW1vbiBiZXR3ZWVuIEludGVsIGFuZCBBTUQuICBJbnN0ZWFk IG9mCm9wZW5jb2RpbmcgYW4gT1Igb2YgdHdvIGZlYXR1cmVzIGV2ZXJ5d2hl cmUsIGludHJvZHVjZSBoYXNfc3BlY19jdHJsIGluc3RlYWQuCgpSZXdvcmQg dGhlIGNvbW1lbnQgYWJvdmUgdGhlIEludGVsIHNwZWNpZmljIGFsdGVybmF0 aXZlcyBibG9jayB0byBoaWdobGlnaHQKdGhhdCBpdCBpcyBJbnRlbCBzcGVj aWZpYywgYW5kIHB1bGwgdGhlIHNldHRpbmcgb2YgZGVmYXVsdF94ZW5fc3Bl Y19jdHJsLklCUlMKb3V0IGJlY2F1c2UgaXQgd2lsbCB3YW50IHRvIGJlIGNv bW1vbi4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoKU2lnbmVkLW9mZi1ieTog QW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KUmV2 aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KKGNo ZXJyeSBwaWNrZWQgZnJvbSBjb21taXQgNWQ5ZWZmM2EzMTI3NjNkODg5Y2Zi ZjNjODQ2OGI2ZGZiM2FiNDkwYykKCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggYTA3MmVjOTg3NzkzLi40MjI3MTRmM2EyMTEgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTkyMyw3ICs5MjMsNyBAQCB2b2lkIHNwZWNfY3RybF9p bml0X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkKQogdm9pZCBfX2luaXQgaW5p dF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogewogICAgIGVudW0g aW5kX3RodW5rIHRodW5rID0gVEhVTktfREVGQVVMVDsKLSAgICBib29sIGli cnMgPSBmYWxzZSwgaHdfc210X2VuYWJsZWQ7CisgICAgYm9vbCBoYXNfc3Bl Y19jdHJsLCBpYnJzID0gZmFsc2UsIGh3X3NtdF9lbmFibGVkOwogICAgIGJv b2wgY3B1X2hhc19idWdfdGFhOwogICAgIHVpbnQ2NF90IGNhcHMgPSAwOwog CkBAIC05MzIsNiArOTMyLDggQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxh dGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogCiAgICAgaHdfc210X2VuYWJsZWQg PSBjaGVja19zbXRfZW5hYmxlZCgpOwogCisgICAgaGFzX3NwZWNfY3RybCA9 IGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQik7CisKICAgICAvKgog ICAgICAqIEhhcyB0aGUgdXNlciBzcGVjaWZpZWQgYW55IGN1c3RvbSBCVEkg bWl0aWdhdGlvbnM/ICBJZiBzbywgZm9sbG93IHRoZWlyCiAgICAgICogaW5z dHJ1Y3Rpb25zIGV4YWN0bHkgYW5kIGRpc2FibGUgYWxsIGhldXJpc3RpY3Mu CkBAIC05NTUsMTEgKzk1NywxMSBAQCB2b2lkIF9faW5pdCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAgICAgICAgICAgICAgKi8KICAg ICAgICAgICAgIGlmICggcmV0cG9saW5lX3NhZmUoY2FwcykgKQogICAgICAg ICAgICAgICAgIHRodW5rID0gVEhVTktfUkVUUE9MSU5FOwotICAgICAgICAg ICAgZWxzZSBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikg KQorICAgICAgICAgICAgZWxzZSBpZiAoIGhhc19zcGVjX2N0cmwgKQogICAg ICAgICAgICAgICAgIGlicnMgPSB0cnVlOwogICAgICAgICB9CiAgICAgICAg IC8qIFdpdGhvdXQgY29tcGlsZXIgdGh1bmsgc3VwcG9ydCwgdXNlIElCUlMg aWYgYXZhaWxhYmxlLiAqLwotICAgICAgICBlbHNlIGlmICggYm9vdF9jcHVf aGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSApCisgICAgICAgIGVsc2UgaWYgKCBo YXNfc3BlY19jdHJsICkKICAgICAgICAgICAgIGlicnMgPSB0cnVlOwogICAg IH0KIApAQCAtOTkwLDEwICs5OTIsNyBAQCB2b2lkIF9faW5pdCBpbml0X3Nw ZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAgICAgZWxzZSBpZiAoIHRo dW5rID09IFRIVU5LX0pNUCApCiAgICAgICAgIHNldHVwX2ZvcmNlX2NwdV9j YXAoWDg2X0ZFQVRVUkVfSU5EX1RIVU5LX0pNUCk7CiAKLSAgICAvKgotICAg ICAqIElmIHdlIGFyZSBvbiBoYXJkd2FyZSBzdXBwb3J0aW5nIE1TUl9TUEVD X0NUUkwsIHNlZSBhYm91dCBzZXR0aW5nIHVwCi0gICAgICogdGhlIGFsdGVy bmF0aXZlcyBibG9ja3Mgc28gd2UgY2FuIHZpcnR1YWxpc2Ugc3VwcG9ydCBm b3IgZ3Vlc3RzLgotICAgICAqLworICAgIC8qIEludGVsIGhhcmR3YXJlOiBN U1JfU1BFQ19DVFJMIGFsdGVybmF0aXZlcyBzZXR1cC4gKi8KICAgICBpZiAo IGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikgKQogICAgIHsKICAg ICAgICAgaWYgKCBvcHRfbXNyX3NjX3B2ICkKQEAgLTEwMTIsMTEgKzEwMTEs MTIgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9u cyh2b2lkKQogICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxfZmxhZ3Mg fD0gU0NGX2lzdF93cm1zcjsKICAgICAgICAgICAgIHNldHVwX2ZvcmNlX2Nw dV9jYXAoWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTSk7CiAgICAgICAgIH0KLQot ICAgICAgICBpZiAoIGlicnMgKQotICAgICAgICAgICAgZGVmYXVsdF94ZW5f c3BlY19jdHJsIHw9IFNQRUNfQ1RSTF9JQlJTOwogICAgIH0KIAorICAgIC8q IElmIHdlIGhhdmUgSUJSUyBhdmFpbGFibGUsIHNlZSB3aGV0aGVyIHdlIHNo b3VsZCB1c2UgaXQuICovCisgICAgaWYgKCBoYXNfc3BlY19jdHJsICYmIGli cnMgKQorICAgICAgICBkZWZhdWx0X3hlbl9zcGVjX2N0cmwgfD0gU1BFQ19D VFJMX0lCUlM7CisKICAgICAvKiBJZiB3ZSBoYXZlIFNTQkQgYXZhaWxhYmxl LCBzZWUgd2hldGhlciB3ZSBzaG91bGQgdXNlIGl0LiAqLwogICAgIGlmICgg Ym9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NTQkQpICYmIG9wdF9zc2JkICkK ICAgICAgICAgZGVmYXVsdF94ZW5fc3BlY19jdHJsIHw9IFNQRUNfQ1RSTF9T U0JEOwpAQCAtMTI1MCw3ICsxMjUwLDcgQEAgdm9pZCBfX2luaXQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAqIGJvb3Qgd29u J3QgaGF2ZSBhbnkgb3RoZXIgY29kZSBydW5uaW5nIGluIGEgcG9zaXRpb24g dG8gbW91bnQgYW4KICAgICAgKiBhdHRhY2suCiAgICAgICovCi0gICAgaWYg KCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSU0IpICkKKyAgICBpZiAo IGhhc19zcGVjX2N0cmwgKQogICAgIHsKICAgICAgICAgYnNwX2RlbGF5X3Nw ZWNfY3RybCA9ICFjcHVfaGFzX2h5cGVydmlzb3IgJiYgZGVmYXVsdF94ZW5f c3BlY19jdHJsOwogCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-08.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-08.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRG9uJ3QgdXNlIHNwZWNfY3Ry bF97ZW50ZXIsZXhpdH1faWRsZSgpIGZvciBTMwoKJ2lkbGUnIGhlcmUgcmVm ZXJzIHRvIGhsdC9td2FpdC4gIFRoZSBTMyBwYXRoIGlzbid0IGFuIGlkbGUg cGF0aCAtIGl0IGlzIGEKcGxhdGZvcm0gcmVzZXQuCgpXZSBuZWVkIHRvIGxv YWQgZGVmYXVsdF94ZW5fc3BlY19jdHJsIHVuaWxhdGVyYWxseSBvbiB0aGUg d2F5IGJhY2sgdXAuCkN1cnJlbnRseSBpdCBoYXBwZW5zIGFzIGEgc2lkZSBl ZmZlY3Qgb2YgWDg2X0ZFQVRVUkVfU0NfTVNSX0lETEUgb3IgdGhlIG5leHQK cmV0dXJuLXRvLWd1ZXN0LCBidXQgdGhhdCdzIGZyYWdpbGUgYmVoYXZpb3Vy LgoKQ29udmVyc2VseSwgdGhlcmUgaXMgbm8gbmVlZCB0byBjbGVhciBJQlJT IGFuZCBmbHVzaCB0aGUgc3RvcmUgYnVmZmVycyBvbiB0aGUKd2F5IGRvd247 IHdlJ3JlIG1pY3Jvc2Vjb25kcyBhd2F5IGZyb20gY3V0dGluZyBwb3dlci4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IDcxZmFj NDAyZTA1YWRlN2IwYWYyYzM0Zjc3NTE3NDQ5ZjZmN2UyYzEpCgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L2FjcGkvcG93ZXIuYyBiL3hlbi9hcmNoL3g4 Ni9hY3BpL3Bvd2VyLmMKaW5kZXggMTliMDRhZWQyMjA4Li42NDI0YTkwMjEy OTMgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9hY3BpL3Bvd2VyLmMKKysr IGIveGVuL2FyY2gveDg2L2FjcGkvcG93ZXIuYwpAQCAtMjQ1LDcgKzI0NSw2 IEBAIHN0YXRpYyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgICAg ICBlcnJvciA9IDA7CiAKICAgICBjaSA9IGdldF9jcHVfaW5mbygpOwotICAg IHNwZWNfY3RybF9lbnRlcl9pZGxlKGNpKTsKICAgICAvKiBBdm9pZCBOTUkv I01DIHVzaW5nIE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQg bWljcm9jb2RlLiAqLwogICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflND Rl9pc3Rfd3Jtc3I7CiAKQEAgLTI5NSw3ICsyOTQsOSBAQCBzdGF0aWMgaW50 IGVudGVyX3N0YXRlKHUzMiBzdGF0ZSkKIAogICAgIC8qIFJlLWVuYWJsZWQg ZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JfU1BFQ19DVFJMLiAqLwogICAg IGNpLT5zcGVjX2N0cmxfZmxhZ3MgfD0gKGRlZmF1bHRfc3BlY19jdHJsX2Zs YWdzICYgU0NGX2lzdF93cm1zcik7Ci0gICAgc3BlY19jdHJsX2V4aXRfaWRs ZShjaSk7CisKKyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9J QlJTQikgKQorICAgICAgICB3cm1zcmwoTVNSX1NQRUNfQ1RSTCwgZGVmYXVs dF94ZW5fc3BlY19jdHJsKTsKIAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX1NSQkRTX0NUUkwpICkKICAgICAgICAgd3Jtc3JsKE1TUl9N Q1VfT1BUX0NUUkwsIGRlZmF1bHRfeGVuX21jdV9vcHRfY3RybCk7Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-09.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-09.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogVXNlIGNvbW1vbiBNU1JfU1BF Q19DVFJMIGxvZ2ljIGZvciBBTUQKCkN1cnJlbnRseSwgYW1kX2luaXRfc3Ni ZCgpIHdvcmtzIGJ5IGJlaW5nIHRoZSBvbmx5IHdyaXRlIHRvIE1TUl9TUEVD X0NUUkwgaW4KdGhlIHN5c3RlbS4gIFRoaXMgY2Vhc2VzIHRvIGJlIHRydWUg d2hlbiB1c2luZyB0aGUgY29tbW9uIGxvZ2ljLgoKSW5jbHVkZSBBTUQgTVNS X1NQRUNfQ1RSTCBpbiBoYXNfc3BlY19jdHJsIHRvIGFjdGl2YXRlIHRoZSBj b21tb24gcGF0aHMsIGFuZAppbnRyb2R1Y2UgYW4gQU1EIHNwZWNpZmljIGJs b2NrIHRvIGNvbnRyb2wgYWx0ZXJuYXRpdmVzLiAgQWxzbyB1cGRhdGUgdGhl CmJvb3QvcmVzdW1lIHBhdGhzIHRvIGNvbmZpZ3VyZSBkZWZhdWx0X3hlbl9z cGVjX2N0cmwuCgpzdm0uaCBuZWVkcyBhbiBhZGp1c3RtZW50IHRvIHJlbW92 ZSBhIGRlcGVuZGVuY3kgb24gaW5jbHVkZSBvcmRlci4KCkZvciBub3csIG9u bHkgYWN0aXZlIGFsdGVybmF0aXZlcyBmb3IgSFZNIC0gUFYgd2lsbCByZXF1 aXJlIG1vcmUgd29yay4gIE5vCmZ1bmN0aW9uYWwgY2hhbmdlLCBhcyBubyBh bHRlcm5hdGl2ZXMgYXJlIGRlZmluZWQgeWV0IGZvciBIVk0geWV0LgoKU2ln bmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBz dXNlLmNvbT4KKGNoZXJyeSBwaWNrZWQgZnJvbSBjb21taXQgMzc4ZjJlNmRm MzE0NDIzOTZmMGFmZGExOTc5NGM1YzYwOTFkOTZmOSkKCmRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jIGIveGVuL2FyY2gveDg2L2Fj cGkvcG93ZXIuYwppbmRleCA2NDI0YTkwMjEyOTMuLmRmNzdiMmNhNWNmYiAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2FjcGkvcG93ZXIuYworKysgYi94 ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCkBAIC0yOTUsNyArMjk1LDcgQEAg c3RhdGljIGludCBlbnRlcl9zdGF0ZSh1MzIgc3RhdGUpCiAgICAgLyogUmUt ZW5hYmxlZCBkZWZhdWx0IE5NSS8jTUMgdXNlIG9mIE1TUl9TUEVDX0NUUkwu ICovCiAgICAgY2ktPnNwZWNfY3RybF9mbGFncyB8PSAoZGVmYXVsdF9zcGVj X2N0cmxfZmxhZ3MgJiBTQ0ZfaXN0X3dybXNyKTsKIAotICAgIGlmICggYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSApCisgICAgaWYgKCBib290 X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSU0IpIHx8IGJvb3RfY3B1X2hhcyhY ODZfRkVBVFVSRV9JQlJTKSApCiAgICAgICAgIHdybXNybChNU1JfU1BFQ19D VFJMLCBkZWZhdWx0X3hlbl9zcGVjX2N0cmwpOwogCiAgICAgaWYgKCBib290 X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU1JCRFNfQ1RSTCkgKQpkaWZmIC0tZ2l0 IGEveGVuL2FyY2gveDg2L2NwdS9hbWQuYyBiL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMKaW5kZXggZGUwMzg5ODEwYjI1Li5kNWRlY2UzN2NkZWIgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKKysrIGIveGVuL2FyY2gv eDg2L2NwdS9hbWQuYwpAQCAtNTUyLDcgKzU1Miw3IEBAIHZvaWQgYW1kX2lu aXRfc3NiZChjb25zdCBzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAJCXJldHVy bjsKIAogCWlmIChjcHVfaGFzX2FtZF9zc2JkKSB7Ci0JCXdybXNybChNU1Jf U1BFQ19DVFJMLCBvcHRfc3NiZCA/IFNQRUNfQ1RSTF9TU0JEIDogMCk7CisJ CS8qIEhhbmRsZWQgYnkgY29tbW9uIE1TUl9TUEVDX0NUUkwgbG9naWMgKi8K IAkJcmV0dXJuOwogCX0KIApkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3Nt cGJvb3QuYyBiL3hlbi9hcmNoL3g4Ni9zbXBib290LmMKaW5kZXggMmQ1MjVj OGIyYzljLi45MWUyYWU2MjYzMDAgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4 Ni9zbXBib290LmMKKysrIGIveGVuL2FyY2gveDg2L3NtcGJvb3QuYwpAQCAt MzY1LDcgKzM2NSw3IEBAIHZvaWQgc3RhcnRfc2Vjb25kYXJ5KHZvaWQgKnVu dXNlZCkKICAgICAgKiBzZXR0aW5ncy4gIE5vdGU6IFRoZXNlIE1TUnMgbWF5 IG9ubHkgYmVjb21lIGF2YWlsYWJsZSBhZnRlciBsb2FkaW5nCiAgICAgICog bWljcm9jb2RlLgogICAgICAqLwotICAgIGlmICggYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX0lCUlNCKSApCisgICAgaWYgKCBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJSU0IpIHx8IGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9J QlJTKSApCiAgICAgICAgIHdybXNybChNU1JfU1BFQ19DVFJMLCBkZWZhdWx0 X3hlbl9zcGVjX2N0cmwpOwogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NSQkRTX0NUUkwpICkKICAgICAgICAgd3Jtc3JsKE1TUl9NQ1Vf T1BUX0NUUkwsIGRlZmF1bHRfeGVuX21jdV9vcHRfY3RybCk7CmRpZmYgLS1n aXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKaW5kZXggNDIyNzE0ZjNhMjExLi5hNzY4YzU3YjQ1ZTAg MTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTIxLDYgKzIxLDcgQEAKICNp bmNsdWRlIDx4ZW4vbGliLmg+CiAjaW5jbHVkZSA8eGVuL3dhcm5pbmcuaD4K IAorI2luY2x1ZGUgPGFzbS9odm0vc3ZtL3N2bS5oPgogI2luY2x1ZGUgPGFz bS9taWNyb2NvZGUuaD4KICNpbmNsdWRlIDxhc20vbXNyLmg+CiAjaW5jbHVk ZSA8YXNtL3Byb2Nlc3Nvci5oPgpAQCAtOTMyLDcgKzkzMyw4IEBAIHZvaWQg X19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnModm9pZCkKIAog ICAgIGh3X3NtdF9lbmFibGVkID0gY2hlY2tfc210X2VuYWJsZWQoKTsKIAot ICAgIGhhc19zcGVjX2N0cmwgPSBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVf SUJSU0IpOworICAgIGhhc19zcGVjX2N0cmwgPSAoYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX0lCUlNCKSB8fAorICAgICAgICAgICAgICAgICAgICAgYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlMpKTsKIAogICAgIC8qCiAgICAg ICogSGFzIHRoZSB1c2VyIHNwZWNpZmllZCBhbnkgY3VzdG9tIEJUSSBtaXRp Z2F0aW9ucz8gIElmIHNvLCBmb2xsb3cgdGhlaXIKQEAgLTEwMTMsMTIgKzEw MTUsMzIgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQogICAgICAgICB9CiAgICAgfQogCisgICAgLyogQU1EIGhh cmR3YXJlOiBNU1JfU1BFQ19DVFJMIGFsdGVybmF0aXZlcyBzZXR1cC4gKi8K KyAgICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTKSApCisg ICAgeworICAgICAgICAvKgorICAgICAgICAgKiBWaXJ0dWFsaXNpbmcgTVNS X1NQRUNfQ1RSTCBmb3IgZ3Vlc3RzIGRlcGVuZHMgb24gU1ZNIHN1cHBvcnQs IHdoaWNoCisgICAgICAgICAqIG9uIHJlYWwgaGFyZHdhcmUgbWF0Y2hlcyB0 aGUgYXZhaWxhYmlsaXR5IG9mIE1TUl9TUEVDX0NUUkwgaW4gdGhlCisgICAg ICAgICAqIGZpcnN0IHBsYWNlLgorICAgICAgICAgKgorICAgICAgICAgKiBO byBuZWVkIGZvciBTQ0ZfaXN0X3dybXNyIGJlY2F1c2UgWGVuJ3MgdmFsdWUg aXMgcmVzdG9yZWQKKyAgICAgICAgICogYXRvbWljYWxseSBXUlQgTk1JcyBp biB0aGUgVk1FeGl0IHBhdGguCisgICAgICAgICAqCisgICAgICAgICAqIFRP RE86IEFkanVzdCBjcHVfaGFzX3N2bV9zcGVjX2N0cmwgdG8gYmUgdXNhYmxl IGVhcmxpZXIgb24gYm9vdC4KKyAgICAgICAgICovCisgICAgICAgIGlmICgg b3B0X21zcl9zY19odm0gJiYKKyAgICAgICAgICAgICAoYm9vdF9jcHVfZGF0 YS5leHRlbmRlZF9jcHVpZF9sZXZlbCA+PSAweDgwMDAwMDBhKSAmJgorICAg ICAgICAgICAgIChjcHVpZF9lZHgoMHg4MDAwMDAwYSkgJiAoMXUgPDwgU1ZN X0ZFQVRVUkVfU1BFQ19DVFJMKSkgKQorICAgICAgICAgICAgc2V0dXBfZm9y Y2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19NU1JfSFZNKTsKKyAgICB9CisK ICAgICAvKiBJZiB3ZSBoYXZlIElCUlMgYXZhaWxhYmxlLCBzZWUgd2hldGhl ciB3ZSBzaG91bGQgdXNlIGl0LiAqLwogICAgIGlmICggaGFzX3NwZWNfY3Ry bCAmJiBpYnJzICkKICAgICAgICAgZGVmYXVsdF94ZW5fc3BlY19jdHJsIHw9 IFNQRUNfQ1RSTF9JQlJTOwogCiAgICAgLyogSWYgd2UgaGF2ZSBTU0JEIGF2 YWlsYWJsZSwgc2VlIHdoZXRoZXIgd2Ugc2hvdWxkIHVzZSBpdC4gKi8KLSAg ICBpZiAoIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TU0JEKSAmJiBvcHRf c3NiZCApCisgICAgaWYgKCBvcHRfc3NiZCAmJiAoYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX1NTQkQpIHx8CisgICAgICAgICAgICAgICAgICAgICAgYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0FNRF9TU0JEKSkgKQogICAgICAgICBk ZWZhdWx0X3hlbl9zcGVjX2N0cmwgfD0gU1BFQ19DVFJMX1NTQkQ7CiAKICAg ICAvKgpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3Zt L3N2bS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3N2bS5oCmlu ZGV4IDJiNTIyZWU3OWIxNy4uZjI4YjQwOTk2Y2EwIDEwMDY0NAotLS0gYS94 ZW4vaW5jbHVkZS9hc20teDg2L2h2bS9zdm0vc3ZtLmgKKysrIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9odm0vc3ZtL3N2bS5oCkBAIC00NSw2ICs0NSw5IEBA IHN0YXRpYyBpbmxpbmUgdm9pZCBzdm1faW52bHBnYSh1bnNpZ25lZCBsb25n IGxpbmVhciwgdWludDMyX3QgYXNpZCkKICAgICAgICAgImEiIChsaW5lYXIp LCAiYyIgKGFzaWQpKTsKIH0KIAorc3RydWN0IGNwdV91c2VyX3JlZ3M7Citz dHJ1Y3QgdmNwdTsKKwogdW5zaWduZWQgbG9uZyAqc3ZtX21zcmJpdCh1bnNp Z25lZCBsb25nICptc3JfYml0bWFwLCB1aW50MzJfdCBtc3IpOwogdm9pZCBf X3VwZGF0ZV9ndWVzdF9laXAoc3RydWN0IGNwdV91c2VyX3JlZ3MgKnJlZ3Ms IHVuc2lnbmVkIGludCBpbnN0X2xlbik7CiB2b2lkIHN2bV91cGRhdGVfZ3Vl c3RfY3Ioc3RydWN0IHZjcHUgKiwgdW5zaWduZWQgaW50IGNyLCB1bnNpZ25l ZCBpbnQgZmxhZ3MpOwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-10.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-10.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogT25seSBhZGp1c3QgTVNSX1NQ RUNfQ1RSTCBmb3IgaWRsZSB3aXRoIGxlZ2FjeSBJQlJTCgpCYWNrIGF0IHRo ZSB0aW1lIG9mIHRoZSBvcmlnaW5hbCBTcGVjdHJlLXYyIGZpeGVzLCBpdCB3 YXMgcmVjb21tZW5kZWQgdG8gY2xlYXIKTVNSX1NQRUNfQ1RSTCB3aGVuIGdv aW5nIGlkbGUuICBUaGlzIGlzIGJlY2F1c2Ugb2YgdGhlIHNpZGUgZWZmZWN0 cyBvbiB0aGUKc2libGluZyB0aHJlYWQgY2F1c2VkIGJ5IHRoZSBtaWNyb2Nv ZGUgSUJSUyBhbmQgU1RJQlAgaW1wbGVtZW50YXRpb25zIHdoaWNoCndlcmUg cmV0cm9maXR0ZWQgdG8gZXhpc3RpbmcgQ1BVcy4KCkhvd2V2ZXIsIHRoZXJl IGFyZSBubyByZWxldmFudCBjcm9zcy10aHJlYWQgaW1wYWN0cyBmb3IgdGhl IGhhcmR3YXJlCklCUlMvU1RJQlAgaW1wbGVtZW50YXRpb25zLCBzbyB0aGlz IGxvZ2ljIHNob3VsZCBub3QgYmUgdXNlZCBvbiBJbnRlbCBDUFVzCnN1cHBv cnRpbmcgZUlCUlMsIG9yIGFueSBBTUQgQ1BVczsgZG9pbmcgc28gb25seSBh ZGRzIHVubmVjZXNzYXJ5IGxhdGVuY3kgdG8KdGhlIGlkbGUgcGF0aC4KCkZ1 cnRoZXJtb3JlLCB0aGVyZSdzIG5vIHBvaW50IHBsYXlpbmcgd2l0aCBNU1Jf U1BFQ19DVFJMIGluIHRoZSBpZGxlIHBhdGhzIGlmClNNVCBpcyBkaXNhYmxl ZCBmb3Igb3RoZXIgcmVhc29ucy4KCkZpeGVzOiA4ZDAzMDgwZDJhMzMgKCJ4 ODYvc3BlYy1jdHJsOiBDZWFzZSB1c2luZyB0aHVuaz1sZmVuY2Ugb24gQU1E IikKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPgooY2hlcnJ5IHBpY2tlZCBmcm9tIGNv bW1pdCBmZmM3Njk0ZTBjOTllZWExNThjMzJhYTE2NGI3ZDFlMWJiMWRjNDZi KQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCBhNzY4YzU3YjQ1ZTAuLmUw MzdlOWI1MmVhMiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3Ry bC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtMTA4MCw4 ICsxMDgwLDE0IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0 aWdhdGlvbnModm9pZCkKICAgICAvKiAoUmUpaW5pdCBCU1Agc3RhdGUgbm93 IHRoYXQgZGVmYXVsdF9zcGVjX2N0cmxfZmxhZ3MgaGFzIGJlZW4gY2FsY3Vs YXRlZC4gKi8KICAgICBpbml0X3NoYWRvd19zcGVjX2N0cmxfc3RhdGUoKTsK IAotICAgIC8qIElmIFhlbiBpcyB1c2luZyBhbnkgTVNSX1NQRUNfQ1RSTCBz ZXR0aW5ncywgYWRqdXN0IHRoZSBpZGxlIHBhdGguICovCi0gICAgaWYgKCBk ZWZhdWx0X3hlbl9zcGVjX2N0cmwgKQorICAgIC8qCisgICAgICogRm9yIG1p Y3JvY29kZWQgSUJSUyBvbmx5IChpLmUuIEludGVsLCBwcmUgZUlCUlMpLCBp dCBpcyByZWNvbW1lbmRlZCB0bworICAgICAqIGNsZWFyIE1TUl9TUEVDX0NU UkwgYmVmb3JlIGdvaW5nIGlkbGUsIHRvIGF2b2lkIGltcGFjdGluZyBzaWJs aW5nCisgICAgICogdGhyZWFkcy4gIEFjdGl2YXRlIHRoaXMgaWYgU01UIGlz IGVuYWJsZWQsIGFuZCBYZW4gaXMgdXNpbmcgYSBub24temVybworICAgICAq IE1TUl9TUEVDX0NUUkwgc2V0dGluZy4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikgJiYgIShjYXBzICYgQVJD SF9DQVBTX0lCUlNfQUxMKSAmJgorICAgICAgICAgaHdfc210X2VuYWJsZWQg JiYgZGVmYXVsdF94ZW5fc3BlY19jdHJsICkKICAgICAgICAgc2V0dXBfZm9y Y2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19NU1JfSURMRSk7CiAKICAgICB4 cHRpX2luaXRfZGVmYXVsdChjYXBzKTsKZGlmZiAtLWdpdCBhL3hlbi9pbmNs dWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaCBiL3hlbi9pbmNsdWRlL2FzbS14 ODYvY3B1ZmVhdHVyZXMuaAppbmRleCBiY2JhOTI2YmRhNDEuLmZjNTRjMjRh MzRlZiAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0 dXJlcy5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMu aApAQCAtMzMsNyArMzMsNyBAQCBYRU5fQ1BVRkVBVFVSRShTQ19NU1JfSFZN LCAgICAgICAgWDg2X1NZTlRIKDE3KSkgLyogTVNSX1NQRUNfQ1RSTCB1c2Vk IGJ5IFhlbiBmbwogWEVOX0NQVUZFQVRVUkUoU0NfUlNCX1BWLCAgICAgICAg IFg4Nl9TWU5USCgxOCkpIC8qIFJTQiBvdmVyd3JpdGUgbmVlZGVkIGZvciBQ ViAqLwogWEVOX0NQVUZFQVRVUkUoU0NfUlNCX0hWTSwgICAgICAgIFg4Nl9T WU5USCgxOSkpIC8qIFJTQiBvdmVyd3JpdGUgbmVlZGVkIGZvciBIVk0gKi8K IFhFTl9DUFVGRUFUVVJFKFhFTl9TRUxGU05PT1AsICAgICBYODZfU1lOVEgo MjApKSAvKiBTRUxGU05PT1AgZ2V0cyB1c2VkIGJ5IFhlbiBpdHNlbGYgKi8K LVhFTl9DUFVGRUFUVVJFKFNDX01TUl9JRExFLCAgICAgICBYODZfU1lOVEgo MjEpKSAvKiAoU0NfTVNSX1BWIHx8IFNDX01TUl9IVk0pICYmIGRlZmF1bHRf eGVuX3NwZWNfY3RybCAqLworWEVOX0NQVUZFQVRVUkUoU0NfTVNSX0lETEUs ICAgICAgIFg4Nl9TWU5USCgyMSkpIC8qIENsZWFyIE1TUl9TUEVDX0NUUkwg b24gaWRsZSAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX0xCUiwgICAgICAgICAg IFg4Nl9TWU5USCgyMikpIC8qIFhlbiB1c2VzIE1TUl9ERUJVR0NUTC5MQlIg Ki8KIC8qIEJpdHMgMjMsMjQgdW51c2VkLiAqLwogWEVOX0NQVUZFQVRVUkUo U0NfVkVSV19JRExFLCAgICAgIFg4Nl9TWU5USCgyNSkpIC8qIFZFUlcgdXNl ZCBieSBYZW4gZm9yIGlkbGUgKi8KZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybC5oCmluZGV4IDE1N2EyYzY3ZDg5Yy4uZmZjMDU0OTc1ZWUzIDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oCisr KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKQEAgLTgwLDcg KzgwLDggQEAgc3RhdGljIGFsd2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxf ZW50ZXJfaWRsZShzdHJ1Y3QgY3B1X2luZm8gKmluZm8pCiAgICAgdWludDMy X3QgdmFsID0gMDsKIAogICAgIC8qCi0gICAgICogQnJhbmNoIFRhcmdldCBJ bmplY3Rpb246CisgICAgICogSXQgaXMgcmVjb21tZW5kZWQgaW4gc29tZSBj YXNlcyB0byBjbGVhciBNU1JfU1BFQ19DVFJMIHdoZW4gZ29pbmcgaWRsZSwK KyAgICAgKiB0byBhdm9pZCBpbXBhY3Rpbmcgc2libGluZyB0aHJlYWRzLgog ICAgICAqCiAgICAgICogTGF0Y2ggdGhlIG5ldyBzaGFkb3cgdmFsdWUsIHRo ZW4gZW5hYmxlIHNoYWRvd2luZywgdGhlbiB1cGRhdGUgdGhlIE1TUi4KICAg ICAgKiBUaGVyZSBhcmUgbm8gU01QIGlzc3VlcyBoZXJlOyBvbmx5IGxvY2Fs IHByb2Nlc3NvciBvcmRlcmluZyBjb25jZXJucy4KQEAgLTExNiw3ICsxMTcs NyBAQCBzdGF0aWMgYWx3YXlzX2lubGluZSB2b2lkIHNwZWNfY3RybF9leGl0 X2lkbGUoc3RydWN0IGNwdV9pbmZvICppbmZvKQogICAgIHVpbnQzMl90IHZh bCA9IGluZm8tPnhlbl9zcGVjX2N0cmw7CiAKICAgICAvKgotICAgICAqIEJy YW5jaCBUYXJnZXQgSW5qZWN0aW9uOgorICAgICAqIFJlc3RvcmUgTVNSX1NQ RUNfQ1RSTCBvbiBleGl0IGZyb20gaWRsZS4KICAgICAgKgogICAgICAqIERp c2FibGUgc2hhZG93aW5nIGJlZm9yZSB1cGRhdGluZyB0aGUgTVNSLiAgVGhl cmUgYXJlIG5vIFNNUCBpc3N1ZXMKICAgICAgKiBoZXJlOyBvbmx5IGxvY2Fs IHByb2Nlc3NvciBvcmRlcmluZyBjb25jZXJucy4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-11.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-11.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogS25vYnMgZm9yIFNUSUJQIGFu ZCBQU0ZELCBhbmQgZm9sbG93IGhhcmR3YXJlIFNUSUJQCiBoaW50CgpTVElC UCBhbmQgUFNGRCBhcmUgc2xpZ2h0bHkgd2VpcmQgYml0cywgYmVjYXVzZSB0 aGV5J3JlIGJvdGggaW1wbGllZCBieSBvdGhlcgpiaXRzIGluIE1TUl9TUEVD X0NUUkwuICBBZGQgZmluZSBncmFpbiBjb250cm9scyBmb3IgdGhlbSwgYW5k IHRha2UgdGhlCmltcGxpY2F0aW9ucyBpbnRvIGFjY291bnQgd2hlbiBzZXR0 aW5nIElCUlMvU1NCRC4KClJlYXJyYW5nZSB0aGUgSUJQQiB0ZXh0L3Zhcmlh Ymxlcy9sb2dpYyB0byBrZWVwIGFsbCB0aGUgTVNSX1NQRUNfQ1RSTCBiaXRz CnRvZ2V0aGVyLCBmb3IgY29uc2lzdGVuY3kuCgpIb3dldmVyLCBBTUQgaGF2 ZSBhIGhhcmR3YXJlIGhpbnQgQ1BVSUQgYml0IHJlY29tbWVuZGluZyB0aGF0 IFNUSUJQIGJlIHNldAp1bmlsYXRlcmFsbHkuICBUaGlzIGlzIGFkdmVydGlz ZWQgb24gWmVuMywgc28gZm9sbG93IHRoZSByZWNvbW1lbmRhdGlvbi4KRnVy dGhlcm1vcmUsIGluIHN1Y2ggY2FzZXMsIHNldCBTVElCUCBiZWhpbmQgdGhl IGd1ZXN0J3MgYmFjayBmb3Igbm93LgoKU2lnbmVkLW9mZi1ieTogQW5kcmV3 IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4KUmV2aWV3ZWQt Ynk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQt Ynk6IFJvZ2VyIFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPgoo Y2hlcnJ5IHBpY2tlZCBmcm9tIGNvbW1pdCBmZWYyNDRiMTc5YzA2ZmNkZmE1 ODFmN2Q1N2ZhNmU1NzhjNDlmZjUwKQpbQWRqdXN0IGZvciBhYnNlbmNlIG9m IElOVEVMX1BTRkRdCgpkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL3hlbi1jb21t YW5kLWxpbmUucGFuZG9jIGIvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUu cGFuZG9jCmluZGV4IDAyMmNiMDFkYTc2Mi4uYTk5ODQxODU4NWJkIDEwMDY0 NAotLS0gYS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MKKysr IGIvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCkBAIC0yMDM0 LDggKzIwMzQsOSBAQCBCeSBkZWZhdWx0IFNTQkQgd2lsbCBiZSBtaXRpZ2F0 ZWQgYXQgcnVudGltZSAoaS5lIGBzc2JkPXJ1bnRpbWVgKS4KIAogIyMjIHNw ZWMtY3RybCAoeDg2KQogPiBgPSBMaXN0IG9mIFsgPGJvb2w+LCB4ZW49PGJv b2w+LCB7cHYsaHZtLG1zci1zYyxyc2IsbWQtY2xlYXJ9PTxib29sPiwKLT4g ICAgICAgICAgICAgIGJ0aS10aHVuaz1yZXRwb2xpbmV8bGZlbmNlfGptcCwg e2licnMsaWJwYixzc2JkLGVhZ2VyLWZwdSwKLT4gICAgICAgICAgICAgIGwx ZC1mbHVzaCxicmFuY2gtaGFyZGVuLHNyYi1sb2NrLHVucHJpdi1tbWlvfT08 Ym9vbD4gXWAKKz4gICAgICAgICAgICAgIGJ0aS10aHVuaz1yZXRwb2xpbmV8 bGZlbmNlfGptcCwge2licnMsaWJwYixzc2JkLHBzZmQsCis+ICAgICAgICAg ICAgICBlYWdlci1mcHUsbDFkLWZsdXNoLGJyYW5jaC1oYXJkZW4sc3JiLWxv Y2ssCis+ICAgICAgICAgICAgICB1bnByaXYtbW1pb309PGJvb2w+IF1gCiAK IENvbnRyb2xzIGZvciBzcGVjdWxhdGl2ZSBleGVjdXRpb24gc2lkZWNoYW5u ZWwgbWl0aWdhdGlvbnMuICBCeSBkZWZhdWx0LCBYZW4KIHdpbGwgcGljayB0 aGUgbW9zdCBhcHByb3ByaWF0ZSBtaXRpZ2F0aW9ucyBiYXNlZCBvbiBjb21w aWxlZCBpbiBzdXBwb3J0LApAQCAtMjA4NSw5ICsyMDg2LDEwIEBAIE9uIGhh cmR3YXJlIHN1cHBvcnRpbmcgSUJSUyAoSW5kaXJlY3QgQnJhbmNoIFJlc3Ry aWN0ZWQgU3BlY3VsYXRpb24pLCB0aGUKIElmIFhlbiBpcyBub3QgdXNpbmcg SUJSUyBpdHNlbGYsIGZ1bmN0aW9uYWxpdHkgaXMgc3RpbGwgc2V0IHVwIHNv IElCUlMgY2FuIGJlCiB2aXJ0dWFsaXNlZCBmb3IgZ3Vlc3RzLgogCi1PbiBo YXJkd2FyZSBzdXBwb3J0aW5nIElCUEIgKEluZGlyZWN0IEJyYW5jaCBQcmVk aWN0aW9uIEJhcnJpZXIpLCB0aGUgYGlicGI9YAotb3B0aW9uIGNhbiBiZSB1 c2VkIHRvIGZvcmNlICh0aGUgZGVmYXVsdCkgb3IgcHJldmVudCBYZW4gZnJv bSBpc3N1aW5nIGJyYW5jaAotcHJlZGljdGlvbiBiYXJyaWVycyBvbiB2Y3B1 IGNvbnRleHQgc3dpdGNoZXMuCitPbiBoYXJkd2FyZSBzdXBwb3J0aW5nIFNU SUJQIChTaW5nbGUgVGhyZWFkIEluZGlyZWN0IEJyYW5jaCBQcmVkaWN0b3Jz KSwgdGhlCitgc3RpYnA9YCBvcHRpb24gY2FuIGJlIHVzZWQgdG8gZm9yY2Ug b3IgcHJldmVudCBYZW4gdXNpbmcgdGhlIGZlYXR1cmUgaXRzZWxmLgorQnkg ZGVmYXVsdCwgWGVuIHdpbGwgdXNlIFNUSUJQIHdoZW4gSUJSUyBpcyBpbiB1 c2UgKElCUlMgaW1wbGllcyBTVElCUCksIGFuZAord2hlbiBoYXJkd2FyZSBo aW50cyByZWNvbW1lbmQgdXNpbmcgaXQgYXMgYSBibGFua2V0IHNldHRpbmcu CiAKIE9uIGhhcmR3YXJlIHN1cHBvcnRpbmcgU1NCRCAoU3BlY3VsYXRpdmUg U3RvcmUgQnlwYXNzIERpc2FibGUpLCB0aGUgYHNzYmQ9YAogb3B0aW9uIGNh biBiZSB1c2VkIHRvIGZvcmNlIG9yIHByZXZlbnQgWGVuIHVzaW5nIHRoZSBm ZWF0dXJlIGl0c2VsZi4gIE9uIEFNRApAQCAtMjA5NSw2ICsyMDk3LDE1IEBA IGhhcmR3YXJlLCB0aGlzIGlzIGEgZ2xvYmFsIG9wdGlvbiBhcHBsaWVkIGF0 IGJvb3QsIGFuZCBub3QgdmlydHVhbGlzZWQgZm9yCiBndWVzdCB1c2UuICBP biBJbnRlbCBoYXJkd2FyZSwgdGhlIGZlYXR1cmUgaXMgdmlydHVhbGlzZWQg Zm9yIGd1ZXN0cywKIGluZGVwZW5kZW50bHkgb2YgWGVuJ3MgY2hvaWNlIG9m IHNldHRpbmcuCiAKK09uIGhhcmR3YXJlIHN1cHBvcnRpbmcgUFNGRCAoUHJl ZGljdGl2ZSBTdG9yZSBGb3J3YXJkaW5nIERpc2FibGUpLCB0aGUgYHBzZmQ9 YAorb3B0aW9uIGNhbiBiZSB1c2VkIHRvIGZvcmNlIG9yIHByZXZlbnQgWGVu IHVzaW5nIHRoZSBmZWF0dXJlIGl0c2VsZi4gIEJ5CitkZWZhdWx0LCBYZW4g d2lsbCBub3QgdXNlIFBTRkQuICBQU0ZEIGlzIGltcGxpZWQgYnkgU1NCRCwg YW5kIFNTQkQgaXMgb2ZmIGJ5CitkZWZhdWx0LgorCitPbiBoYXJkd2FyZSBz dXBwb3J0aW5nIElCUEIgKEluZGlyZWN0IEJyYW5jaCBQcmVkaWN0aW9uIEJh cnJpZXIpLCB0aGUgYGlicGI9YAorb3B0aW9uIGNhbiBiZSB1c2VkIHRvIGZv cmNlICh0aGUgZGVmYXVsdCkgb3IgcHJldmVudCBYZW4gZnJvbSBpc3N1aW5n IGJyYW5jaAorcHJlZGljdGlvbiBiYXJyaWVycyBvbiB2Y3B1IGNvbnRleHQg c3dpdGNoZXMuCisKIE9uIGFsbCBoYXJkd2FyZSwgdGhlIGBlYWdlci1mcHU9 YCBvcHRpb24gY2FuIGJlIHVzZWQgdG8gZm9yY2Ugb3IgcHJldmVudCBYZW4K IGZyb20gdXNpbmcgZnVsbHkgZWFnZXIgRlBVIGNvbnRleHQgc3dpdGNoZXMu ICBUaGlzIGlzIGN1cnJlbnRseSBpbXBsZW1lbnRlZCBhcwogYSBnbG9iYWwg Y29udHJvbC4gIEJ5IGRlZmF1bHQsIFhlbiB3aWxsIGNob29zZSB0byB1c2Ug ZnVsbHkgZWFnZXIgY29udGV4dApkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCmluZGV4 IGUwMzdlOWI1MmVhMi4uYTQxMjFlMjVjYzYzIDEwMDY0NAotLS0gYS94ZW4v YXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIveGVuL2FyY2gveDg2L3NwZWNf Y3RybC5jCkBAIC00OCw5ICs0OCwxMyBAQCBzdGF0aWMgZW51bSBpbmRfdGh1 bmsgewogICAgIFRIVU5LX0xGRU5DRSwKICAgICBUSFVOS19KTVAsCiB9IG9w dF90aHVuayBfX2luaXRkYXRhID0gVEhVTktfREVGQVVMVDsKKwogc3RhdGlj IGludDhfdCBfX2luaXRkYXRhIG9wdF9pYnJzID0gLTE7CitpbnQ4X3QgX19p bml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKK2Jvb2wgX19yZWFkX21vc3RseSBv cHRfc3NiZDsKK2ludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0gLTE7CisK IGJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYiA9IHRydWU7Ci1ib29sIF9f cmVhZF9tb3N0bHkgb3B0X3NzYmQgPSBmYWxzZTsKIGludDhfdCBfX3JlYWRf bW9zdGx5IG9wdF9lYWdlcl9mcHUgPSAtMTsKIGludDhfdCBfX3JlYWRfbW9z dGx5IG9wdF9sMWRfZmx1c2ggPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBv cHRfYnJhbmNoX2hhcmRlbiA9IHRydWU7CkBAIC0xNzQsMTIgKzE3OCwyMCBA QCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwoY29uc3QgY2hh ciAqcykKICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICByYyA9 IC1FSU5WQUw7CiAgICAgICAgIH0KKworICAgICAgICAvKiBCaXRzIGluIE1T Ul9TUEVDX0NUUkwuICovCiAgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFy c2VfYm9vbGVhbigiaWJycyIsIHMsIHNzKSkgPj0gMCApCiAgICAgICAgICAg ICBvcHRfaWJycyA9IHZhbDsKLSAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBw YXJzZV9ib29sZWFuKCJpYnBiIiwgcywgc3MpKSA+PSAwICkKLSAgICAgICAg ICAgIG9wdF9pYnBiID0gdmFsOworICAgICAgICBlbHNlIGlmICggKHZhbCA9 IHBhcnNlX2Jvb2xlYW4oInN0aWJwIiwgcywgc3MpKSA+PSAwICkKKyAgICAg ICAgICAgIG9wdF9zdGlicCA9IHZhbDsKICAgICAgICAgZWxzZSBpZiAoICh2 YWwgPSBwYXJzZV9ib29sZWFuKCJzc2JkIiwgcywgc3MpKSA+PSAwICkKICAg ICAgICAgICAgIG9wdF9zc2JkID0gdmFsOworICAgICAgICBlbHNlIGlmICgg KHZhbCA9IHBhcnNlX2Jvb2xlYW4oInBzZmQiLCBzLCBzcykpID49IDAgKQor ICAgICAgICAgICAgb3B0X3BzZmQgPSB2YWw7CisKKyAgICAgICAgLyogTWlz YyBzZXR0aW5ncy4gKi8KKyAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJz ZV9ib29sZWFuKCJpYnBiIiwgcywgc3MpKSA+PSAwICkKKyAgICAgICAgICAg IG9wdF9pYnBiID0gdmFsOwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBh cnNlX2Jvb2xlYW4oImVhZ2VyLWZwdSIsIHMsIHNzKSkgPj0gMCApCiAgICAg ICAgICAgICBvcHRfZWFnZXJfZnB1ID0gdmFsOwogICAgICAgICBlbHNlIGlm ICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImwxZC1mbHVzaCIsIHMsIHNzKSkg Pj0gMCApCkBAIC0zNzUsNyArMzg3LDcgQEAgc3RhdGljIHZvaWQgX19pbml0 IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90 IGNhcHMpCiAgICAgICAgICAgICAgICAiXG4iKTsKIAogICAgIC8qIFNldHRp bmdzIGZvciBYZW4ncyBwcm90ZWN0aW9uLCBpcnJlc3BlY3RpdmUgb2YgZ3Vl c3RzLiAqLwotICAgIHByaW50aygiICBYZW4gc2V0dGluZ3M6IEJUSS1UaHVu ayAlcywgU1BFQ19DVFJMOiAlcyVzJXMlcywgT3RoZXI6JXMlcyVzJXMlc1xu IiwKKyAgICBwcmludGsoIiAgWGVuIHNldHRpbmdzOiBCVEktVGh1bmsgJXMs IFNQRUNfQ1RSTDogJXMlcyVzJXMlcywgT3RoZXI6JXMlcyVzJXMlc1xuIiwK ICAgICAgICAgICAgdGh1bmsgPT0gVEhVTktfTk9ORSAgICAgID8gIk4vQSIg OgogICAgICAgICAgICB0aHVuayA9PSBUSFVOS19SRVRQT0xJTkUgPyAiUkVU UE9MSU5FIiA6CiAgICAgICAgICAgIHRodW5rID09IFRIVU5LX0xGRU5DRSAg ICA/ICJMRkVOQ0UiIDoKQEAgLTM4OSw2ICs0MDEsOCBAQCBzdGF0aWMgdm9p ZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywg dWludDY0X3QgY2FwcykKICAgICAgICAgICAgKCFib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfU1NCRCkgJiYKICAgICAgICAgICAgICFib290X2NwdV9oYXMo WDg2X0ZFQVRVUkVfQU1EX1NTQkQpKSAgICAgPyAiIiA6CiAgICAgICAgICAg IChkZWZhdWx0X3hlbl9zcGVjX2N0cmwgJiBTUEVDX0NUUkxfU1NCRCkgID8g IiBTU0JEKyIgOiAiIFNTQkQtIiwKKyAgICAgICAgICAgIWJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9QU0ZEKSAmJgorICAgICAgICAgICAoZGVmYXVsdF94 ZW5fc3BlY19jdHJsICYgU1BFQ19DVFJMX1BTRkQpICA/ICIgUFNGRCsiIDog IiBQU0ZELSIsCiAgICAgICAgICAgICEoY2FwcyAmIEFSQ0hfQ0FQU19UU1hf Q1RSTCkgICAgICAgICAgICAgID8gIiIgOgogICAgICAgICAgICAob3B0X3Rz eCAmIDEpICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVFNYKyIg OiAiIFRTWC0iLAogICAgICAgICAgICAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX1NSQkRTX0NUUkwpICAgICA/ICIiIDoKQEAgLTEwMzQsMTQgKzEwNDgs NDggQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9u cyh2b2lkKQogICAgICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZf RkVBVFVSRV9TQ19NU1JfSFZNKTsKICAgICB9CiAKLSAgICAvKiBJZiB3ZSBo YXZlIElCUlMgYXZhaWxhYmxlLCBzZWUgd2hldGhlciB3ZSBzaG91bGQgdXNl IGl0LiAqLworICAgIC8qIEZpZ3VyZSBvdXQgZGVmYXVsdF94ZW5fc3BlY19j dHJsLiAqLwogICAgIGlmICggaGFzX3NwZWNfY3RybCAmJiBpYnJzICkKKyAg ICB7CisgICAgICAgIC8qIElCUlMgaW1wbGllcyBTVElCUC4gICovCisgICAg ICAgIGlmICggb3B0X3N0aWJwID09IC0xICkKKyAgICAgICAgICAgIG9wdF9z dGlicCA9IDE7CisKICAgICAgICAgZGVmYXVsdF94ZW5fc3BlY19jdHJsIHw9 IFNQRUNfQ1RSTF9JQlJTOworICAgIH0KKworICAgIC8qCisgICAgICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgaWYgdGhlIGhhcmR3YXJlIGhpbnQgaXMgc2V0 LiAgT3RoZXJ3aXNlLCBsZWF2ZSBpdAorICAgICAqIG9mZiBhcyBpdCBhIHNl dmVyZSBwZXJmb3JtYW5jZSBwZW50YWx0eSBvbiBwcmUtZUlCUlMgSW50ZWwg aGFyZHdhcmUKKyAgICAgKiB3aGVyZSBpdCB3YXMgcmV0cm9maXR0ZWQgaW4g bWljcm9jb2RlLgorICAgICAqLworICAgIGlmICggb3B0X3N0aWJwID09IC0x ICkKKyAgICAgICAgb3B0X3N0aWJwID0gISFib290X2NwdV9oYXMoWDg2X0ZF QVRVUkVfU1RJQlBfQUxXQVlTKTsKKworICAgIGlmICggb3B0X3N0aWJwICYm IChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU1RJQlApIHx8CisgICAgICAg ICAgICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9BTURf U1RJQlApKSApCisgICAgICAgIGRlZmF1bHRfeGVuX3NwZWNfY3RybCB8PSBT UEVDX0NUUkxfU1RJQlA7CiAKLSAgICAvKiBJZiB3ZSBoYXZlIFNTQkQgYXZh aWxhYmxlLCBzZWUgd2hldGhlciB3ZSBzaG91bGQgdXNlIGl0LiAqLwogICAg IGlmICggb3B0X3NzYmQgJiYgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9T U0JEKSB8fAogICAgICAgICAgICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhY ODZfRkVBVFVSRV9BTURfU1NCRCkpICkKKyAgICB7CisgICAgICAgIC8qIFNT QkQgaW1wbGllcyBQU0ZEICovCisgICAgICAgIGlmICggb3B0X3BzZmQgPT0g LTEgKQorICAgICAgICAgICAgb3B0X3BzZmQgPSAxOworCiAgICAgICAgIGRl ZmF1bHRfeGVuX3NwZWNfY3RybCB8PSBTUEVDX0NUUkxfU1NCRDsKKyAgICB9 CisKKyAgICAvKgorICAgICAqIERvbid0IHVzZSBQU0ZEIGJ5IGRlZmF1bHQu ICBBTUQgZGVzaWduZWQgdGhlIHByZWRpY3RvciB0bworICAgICAqIGF1dG8t Y2xlYXIgb24gcHJpdmlsZWdlIGNoYW5nZS4gIFBTRkQgaXMgaW1wbGllZCBi eSBTU0JELCB3aGljaCBpcworICAgICAqIG9mZiBieSBkZWZhdWx0LgorICAg ICAqLworICAgIGlmICggb3B0X3BzZmQgPT0gLTEgKQorICAgICAgICBvcHRf cHNmZCA9IDA7CisKKyAgICBpZiAoIG9wdF9wc2ZkICYmIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9QU0ZEKSApCisgICAgICAgIGRlZmF1bHRfeGVuX3Nw ZWNfY3RybCB8PSBTUEVDX0NUUkxfUFNGRDsKIAogICAgIC8qCiAgICAgICog UFYgZ3Vlc3RzIGNhbiBwb2lzb24gdGhlIFJTQiB0byBhbnkgdmlydHVhbCBh ZGRyZXNzIGZyb20gd2hpY2gK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-12.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-12.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeGVuL2NtZGxpbmU6IEV4dGVuZCBwYXJzZV9ib29sZWFu KCkgdG8gc2lnbmFsIGEgbmFtZSBtYXRjaAoKVGhpcyB3aWxsIGhlbHAgcGFy c2luZyBhIHN1Yi1vcHRpb24gd2hpY2ggaGFzIGJvb2xlYW4gYW5kIG5vbi1i b29sZWFuIG9wdGlvbnMKYXZhaWxhYmxlLgoKRmlyc3QsIHJld29yayAnaW50 IHZhbCcgaW50byAnYm9vbCBoYXNfbmVnX3ByZWZpeCcuICBUaGlzIGludmVy dHMgaXQncyB2YWx1ZSwKYnV0IHRoZSByZXN1bHRpbmcgbG9naWMgaXMgZmFy IGVhc2llciB0byBmb2xsb3cuCgpTZWNvbmQsIHJlamVjdCBhbnl0aGluZyBv ZiB0aGUgZm9ybSAnbm8tJEZPTz0nIHdoaWNoIGV4Y2x1ZGVzIGFtYmlndW91 cwpjb25zdHJ1Y3RzIHN1Y2ggYXMgJ25vLSRmb289eWVzJyB3aGljaCBoYXZl IG5ldmVyIGJlZW4gdmFsaWQuCgpUaGlzIGp1c3QgbGVhdmVzIHRoZSBjYXNl IHdoZXJlIGV2ZXJ5dGhpbmcgaXMgb3RoZXJ3aXNlIGZpbmUsIGJ1dCBwYXJz ZV9ib29sKCkKY2FuJ3QgaW50ZXJwcmV0IHRoZSBwcm92aWRlZCBzdHJpbmcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgooY2hlcnJ5IHBpY2tlZCBmcm9tIGNvbW1pdCAzODIz MjZjYWM1MjhkZDFlYjBkMDRlZmQ1YzA1MzYzYzQ1M2UyOWY0KQoKZGlmZiAt LWdpdCBhL3hlbi9jb21tb24va2VybmVsLmMgYi94ZW4vY29tbW9uL2tlcm5l bC5jCmluZGV4IGRlMmZkMWUzMzRkMi4uN2JhMDdlYWFhNmQxIDEwMDY0NAot LS0gYS94ZW4vY29tbW9uL2tlcm5lbC5jCisrKyBiL3hlbi9jb21tb24va2Vy bmVsLmMKQEAgLTI3NSw5ICsyNzUsOSBAQCBpbnQgcGFyc2VfYm9vbChjb25z dCBjaGFyICpzLCBjb25zdCBjaGFyICplKQogaW50IHBhcnNlX2Jvb2xlYW4o Y29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAqcywgY29uc3QgY2hhciAq ZSkKIHsKICAgICBzaXplX3Qgc2xlbiwgbmxlbjsKLSAgICBpbnQgdmFsID0g ISFzdHJuY21wKHMsICJuby0iLCAzKTsKKyAgICBib29sIGhhc19uZWdfcHJl Zml4ID0gIXN0cm5jbXAocywgIm5vLSIsIDMpOwogCi0gICAgaWYgKCAhdmFs ICkKKyAgICBpZiAoIGhhc19uZWdfcHJlZml4ICkKICAgICAgICAgcyArPSAz OwogCiAgICAgc2xlbiA9IGUgPyAoeyBBU1NFUlQoZSA+PSBzKTsgZSAtIHM7 IH0pIDogc3RybGVuKHMpOwpAQCAtMjg5LDExICsyODksMjMgQEAgaW50IHBh cnNlX2Jvb2xlYW4oY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAqcywg Y29uc3QgY2hhciAqZSkKIAogICAgIC8qIEV4YWN0LCB1bmFkb3JuZWQgbmFt ZT8gIFJlc3VsdCBkZXBlbmRzIG9uIHRoZSAnbm8tJyBwcmVmaXguICovCiAg ICAgaWYgKCBzbGVuID09IG5sZW4gKQotICAgICAgICByZXR1cm4gdmFsOwor ICAgICAgICByZXR1cm4gIWhhc19uZWdfcHJlZml4OworCisgICAgLyogSW5l eGFjdCBtYXRjaCB3aXRoIGEgJ25vLScgcHJlZml4PyAgTm90IHZhbGlkLiAq LworICAgIGlmICggaGFzX25lZ19wcmVmaXggKQorICAgICAgICByZXR1cm4g LTE7CiAKICAgICAvKiA9JFNPTUVUSElORz8gIERlZmVyIHRvIHRoZSByZWd1 bGFyIGJvb2xlYW4gcGFyc2luZy4gKi8KICAgICBpZiAoIHNbbmxlbl0gPT0g Jz0nICkKLSAgICAgICAgcmV0dXJuIHBhcnNlX2Jvb2woJnNbbmxlbiArIDFd LCBlKTsKKyAgICB7CisgICAgICAgIGludCBiID0gcGFyc2VfYm9vbCgmc1tu bGVuICsgMV0sIGUpOworCisgICAgICAgIGlmICggYiA+PSAwICkKKyAgICAg ICAgICAgIHJldHVybiBiOworCisgICAgICAgIC8qIE5vdCBhIGJvb2xlYW4s IGJ1dCB0aGUgbmFtZSBtYXRjaGVkLiAgU2lnbmFsIHNwZWNpYWxseS4gKi8K KyAgICAgICAgcmV0dXJuIC0yOworICAgIH0KIAogICAgIC8qIFVucmVjb2du aXNlZC4gIEdpdmUgdXAuICovCiAgICAgcmV0dXJuIC0xOwpkaWZmIC0tZ2l0 IGEveGVuL2luY2x1ZGUveGVuL2xpYi5oIGIveGVuL2luY2x1ZGUveGVuL2xp Yi5oCmluZGV4IDNjMjdiYTkwMmRlMC4uZTBhMjM0MzAwYTFlIDEwMDY0NAot LS0gYS94ZW4vaW5jbHVkZS94ZW4vbGliLmgKKysrIGIveGVuL2luY2x1ZGUv eGVuL2xpYi5oCkBAIC03OSw3ICs3OSw4IEBAIGludCBwYXJzZV9ib29sKGNv bnN0IGNoYXIgKnMsIGNvbnN0IGNoYXIgKmUpOwogLyoqCiAgKiBHaXZlbiBh IHNwZWNpZmljIG5hbWUsIHBhcnNlcyBhIHN0cmluZyBvZiB0aGUgZm9ybToK ICAqICAgW25vLV0kTkFNRVs9Li4uXQotICogcmV0dXJuaW5nIDAgb3IgMSBm b3IgYSByZWNvZ25pc2VkIGJvb2xlYW4sIG9yIC0xIGZvciBhbiBlcnJvci4K KyAqIHJldHVybmluZyAwIG9yIDEgZm9yIGEgcmVjb2duaXNlZCBib29sZWFu LiAgUmV0dXJucyAtMSBmb3IgZ2VuZXJhbCBlcnJvcnMsCisgKiBhbmQgLTIg Zm9yICJub3QgYSBib29sZWFuLCBidXQgJE5BTUU9IG1hdGNoZXMiLgogICov CiBpbnQgcGFyc2VfYm9vbGVhbihjb25zdCBjaGFyICpuYW1lLCBjb25zdCBj aGFyICpzLCBjb25zdCBjaGFyICplKTsKIAo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-13.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-13.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogQWRkIGZpbmUtZ3JhaW5lZCBj bWRsaW5lIHN1Ym9wdGlvbnMgZm9yIHByaW1pdGl2ZXMKClN1cHBvcnQgY29u dHJvbGluZyB0aGUgUFYvSFZNIHN1Ym9wdGlvbiBvZiBtc3Itc2MvcnNiL21k LWNsZWFyLCB3aGljaApwcmV2aW91c2x5IHdhc24ndCBwb3NzaWJsZS4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IDI3MzU3YzM5 NGJhNmUxNTcxYTg5MTA1Yjg0MGNlMWM2ZjAyNjQ4NWMpCgpkaWZmIC0tZ2l0 IGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jIGIvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCmluZGV4IGE5OTg0MTg1ODVi ZC4uMzU5ODU5YjUxODA4IDEwMDY0NAotLS0gYS9kb2NzL21pc2MveGVuLWNv bW1hbmQtbGluZS5wYW5kb2MKKysrIGIvZG9jcy9taXNjL3hlbi1jb21tYW5k LWxpbmUucGFuZG9jCkBAIC0yMDMzLDcgKzIwMzMsOCBAQCBub3QgYmUgYWJs ZSB0byBjb250cm9sIHRoZSBzdGF0ZSBvZiB0aGUgbWl0aWdhdGlvbi4KIEJ5 IGRlZmF1bHQgU1NCRCB3aWxsIGJlIG1pdGlnYXRlZCBhdCBydW50aW1lIChp LmUgYHNzYmQ9cnVudGltZWApLgogCiAjIyMgc3BlYy1jdHJsICh4ODYpCi0+ IGA9IExpc3Qgb2YgWyA8Ym9vbD4sIHhlbj08Ym9vbD4sIHtwdixodm0sbXNy LXNjLHJzYixtZC1jbGVhcn09PGJvb2w+LAorPiBgPSBMaXN0IG9mIFsgPGJv b2w+LCB4ZW49PGJvb2w+LCB7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAg ICAgICB7bXNyLXNjLHJzYixtZC1jbGVhcn09PGJvb2w+fHtwdixodm19PTxi b29sPiwKID4gICAgICAgICAgICAgIGJ0aS10aHVuaz1yZXRwb2xpbmV8bGZl bmNlfGptcCwge2licnMsaWJwYixzc2JkLHBzZmQsCiA+ICAgICAgICAgICAg ICBlYWdlci1mcHUsbDFkLWZsdXNoLGJyYW5jaC1oYXJkZW4sc3JiLWxvY2ss CiA+ICAgICAgICAgICAgICB1bnByaXYtbW1pb309PGJvb2w+IF1gCkBAIC0y MDU4LDEyICsyMDU5LDE3IEBAIGluIHBsYWNlIGZvciBndWVzdHMgdG8gdXNl LgogCiBVc2Ugb2YgYSBwb3NpdGl2ZSBib29sZWFuIHZhbHVlIGZvciBlaXRo ZXIgb2YgdGhlc2Ugb3B0aW9ucyBpcyBpbnZhbGlkLgogCi1UaGUgYm9vbGVh bnMgYHB2PWAsIGBodm09YCwgYG1zci1zYz1gLCBgcnNiPWAgYW5kIGBtZC1j bGVhcj1gIG9mZmVyIGZpbmUKK1RoZSBgcHY9YCwgYGh2bT1gLCBgbXNyLXNj PWAsIGByc2I9YCBhbmQgYG1kLWNsZWFyPWAgb3B0aW9ucyBvZmZlciBmaW5l CiBncmFpbmVkIGNvbnRyb2wgb3ZlciB0aGUgcHJpbWl0aXZlcyBieSBYZW4u ICBUaGVzZSBpbXBhY3QgWGVuJ3MgYWJpbGl0eSB0bwotcHJvdGVjdCBpdHNl bGYsIGFuZCBYZW4ncyBhYmlsaXR5IHRvIHZpcnR1YWxpc2Ugc3VwcG9ydCBm b3IgZ3Vlc3RzIHRvIHVzZS4KK3Byb3RlY3QgaXRzZWxmLCBhbmQvb3IgWGVu J3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNlIHN1cHBvcnQgZm9yIGd1ZXN0cyB0 byB1c2UuCiAKICogYHB2PWAgYW5kIGBodm09YCBvZmZlciBjb250cm9sIG92 ZXIgYWxsIHN1Ym9wdGlvbnMgZm9yIFBWIGFuZCBIVk0gZ3Vlc3RzCiAgIHJl c3BlY3RpdmVseS4KKyogRWFjaCBvdGhlciBvcHRpb24gY2FuIGJlIHVzZWQg ZWl0aGVyIGFzIGEgcGxhaW4gYm9vbGVhbgorICAoZS5nLiBgc3BlYy1jdHJs PXJzYmAgdG8gY29udHJvbCBib3RoIHRoZSBQViBhbmQgSFZNIHN1Yi1vcHRp b25zKSwgb3Igd2l0aAorICBgcHY9YCBvciBgaHZtPWAgc3Vic3Vib3B0aW9u cyAoZS5nLiBgc3BlYy1jdHJsPXJzYj1uby1odm1gIHRvIGRpc2FibGUgSFZN CisgIFJTQiBvbmx5KS4KKwogKiBgbXNyLXNjPWAgb2ZmZXJzIGNvbnRyb2wg b3ZlciBYZW4ncyBzdXBwb3J0IGZvciBtYW5pcHVsYXRpbmcgYE1TUl9TUEVD X0NUUkxgCiAgIG9uIGVudHJ5IGFuZCBleGl0LiAgVGhlc2UgYmxvY2tzIGFy ZSBuZWNlc3NhcnkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgogICBndWVz dHMgYW5kIGlmIGRpc2FibGVkLCBndWVzdHMgd2lsbCBiZSB1bmFibGUgdG8g dXNlIElCUlMvU1RJQlAvU1NCRC9ldGMuCmRpZmYgLS1naXQgYS94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMK aW5kZXggYTQxMjFlMjVjYzYzLi41OGFmOGEyODM4NmEgMTAwNjQ0Ci0tLSBh L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKQEAgLTE0OCwyMCArMTQ4LDY4IEBAIHN0YXRpYyBpbnQg X19pbml0IHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFyICpzKQogICAgICAg ICAgICAgb3B0X3JzYl9odm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfbWRf Y2xlYXJfaHZtID0gdmFsOwogICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYg KCAodmFsID0gcGFyc2VfYm9vbGVhbigibXNyLXNjIiwgcywgc3MpKSA+PSAw ICkKKyAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJt c3Itc2MiLCBzLCBzcykpICE9IC0xICkKICAgICAgICAgewotICAgICAgICAg ICAgb3B0X21zcl9zY19wdiA9IHZhbDsKLSAgICAgICAgICAgIG9wdF9tc3Jf c2NfaHZtID0gdmFsOworICAgICAgICAgICAgc3dpdGNoICggdmFsICkKKyAg ICAgICAgICAgIHsKKyAgICAgICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAg IGNhc2UgMToKKyAgICAgICAgICAgICAgICBvcHRfbXNyX3NjX3B2ID0gb3B0 X21zcl9zY19odm0gPSB2YWw7CisgICAgICAgICAgICAgICAgYnJlYWs7CisK KyAgICAgICAgICAgIGNhc2UgLTI6CisgICAgICAgICAgICAgICAgcyArPSBz dHJsZW4oIm1zci1zYz0iKTsKKyAgICAgICAgICAgICAgICBpZiAoICh2YWwg PSBwYXJzZV9ib29sZWFuKCJwdiIsIHMsIHNzKSkgPj0gMCApCisgICAgICAg ICAgICAgICAgICAgIG9wdF9tc3Jfc2NfcHYgPSB2YWw7CisgICAgICAgICAg ICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJodm0iLCBz LCBzcykpID49IDAgKQorICAgICAgICAgICAgICAgICAgICBvcHRfbXNyX3Nj X2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAg ICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAgICByYyA9IC1FSU5WQUw7 CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CiAgICAg ICAgIH0KLSAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFu KCJyc2IiLCBzLCBzcykpID49IDAgKQorICAgICAgICBlbHNlIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oInJzYiIsIHMsIHNzKSkgIT0gLTEgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBvcHRfcnNiX3B2ID0gdmFsOwotICAgICAg ICAgICAgb3B0X3JzYl9odm0gPSB2YWw7CisgICAgICAgICAgICBzd2l0Y2gg KCB2YWwgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgY2FzZSAwOgor ICAgICAgICAgICAgY2FzZSAxOgorICAgICAgICAgICAgICAgIG9wdF9yc2Jf cHYgPSBvcHRfcnNiX2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBicmVh azsKKworICAgICAgICAgICAgY2FzZSAtMjoKKyAgICAgICAgICAgICAgICBz ICs9IHN0cmxlbigicnNiPSIpOworICAgICAgICAgICAgICAgIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oInB2Iiwgcywgc3MpKSA+PSAwICkKKyAgICAg ICAgICAgICAgICAgICAgb3B0X3JzYl9wdiA9IHZhbDsKKyAgICAgICAgICAg ICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImh2bSIsIHMs IHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAgIG9wdF9yc2JfaHZt ID0gdmFsOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGRl ZmF1bHQ6CisgICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsKKyAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQotICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oIm1k LWNsZWFyIiwgcywgc3MpKSA+PSAwICkKKyAgICAgICAgZWxzZSBpZiAoICh2 YWwgPSBwYXJzZV9ib29sZWFuKCJtZC1jbGVhciIsIHMsIHNzKSkgIT0gLTEg KQogICAgICAgICB7Ci0gICAgICAgICAgICBvcHRfbWRfY2xlYXJfcHYgPSB2 YWw7Ci0gICAgICAgICAgICBvcHRfbWRfY2xlYXJfaHZtID0gdmFsOworICAg ICAgICAgICAgc3dpdGNoICggdmFsICkKKyAgICAgICAgICAgIHsKKyAgICAg ICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAgIGNhc2UgMToKKyAgICAgICAg ICAgICAgICBvcHRfbWRfY2xlYXJfcHYgPSBvcHRfbWRfY2xlYXJfaHZtID0g dmFsOworICAgICAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgICAgICBj YXNlIC0yOgorICAgICAgICAgICAgICAgIHMgKz0gc3RybGVuKCJtZC1jbGVh cj0iKTsKKyAgICAgICAgICAgICAgICBpZiAoICh2YWwgPSBwYXJzZV9ib29s ZWFuKCJwdiIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAg IG9wdF9tZF9jbGVhcl9wdiA9IHZhbDsKKyAgICAgICAgICAgICAgICBlbHNl IGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImh2bSIsIHMsIHNzKSkgPj0g MCApCisgICAgICAgICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0gPSB2 YWw7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgZGVmYXVs dDoKKyAgICAgICAgICAgICAgICAgICAgcmMgPSAtRUlOVkFMOworICAgICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQogICAgICAgICB9CiAK ICAgICAgICAgLyogWGVuJ3Mgc3BlY3VsYXRpdmUgc2lkZWNoYW5uZWwgbWl0 aWdhdGlvbiBzZXR0aW5ncy4gKi8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-14.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-14.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIHNwZWNfY3RybF9m bGFncyBjb250ZXh0IHN3aXRjaGluZwoKV2UgYXJlIHNob3J0bHkgZ29pbmcg dG8gbmVlZCB0byBjb250ZXh0IHN3aXRjaCBuZXcgYml0cyBpbiBib3RoIHRo ZSB2Y3B1IGFuZApTMyBwYXRocy4gIEludHJvZHVjZSBTQ0ZfSVNUX01BU0sg YW5kIFNDRl9ET01fTUFTSywgYW5kIHJld29yayBkLT5hcmNoLnZlcncKaW50 byBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyB0byBhY2NvbW1vZGF0ZS4KCk5v IGZ1bmN0aW9uYWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9hY3Bp L3Bvd2VyLmMgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCmluZGV4IGRm NzdiMmNhNWNmYi4uZjFkYmJmN2ZjOTIwIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvYWNwaS9wb3dlci5jCisrKyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bv d2VyLmMKQEAgLTI0NSw4ICsyNDUsOCBAQCBzdGF0aWMgaW50IGVudGVyX3N0 YXRlKHUzMiBzdGF0ZSkKICAgICAgICAgZXJyb3IgPSAwOwogCiAgICAgY2kg PSBnZXRfY3B1X2luZm8oKTsKLSAgICAvKiBBdm9pZCBOTUkvI01DIHVzaW5n IE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQgbWljcm9jb2Rl LiAqLwotICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflNDRl9pc3Rfd3Jt c3I7CisgICAgLyogQXZvaWQgTk1JLyNNQyB1c2luZyB1bnNhZmUgTVNScyB1 bnRpbCB3ZSd2ZSByZWxvYWRlZCBtaWNyb2NvZGUuICovCisgICAgY2ktPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX0lTVF9NQVNLOwogCiAgICAgQUNQSV9G TFVTSF9DUFVfQ0FDSEUoKTsKIApAQCAtMjkyLDggKzI5Miw4IEBAIHN0YXRp YyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgIGlmICggIXJlY2hl Y2tfY3B1X2ZlYXR1cmVzKDApICkKICAgICAgICAgcGFuaWMoIk1pc3Npbmcg cHJldmlvdXNseSBhdmFpbGFibGUgZmVhdHVyZShzKVxuIik7CiAKLSAgICAv KiBSZS1lbmFibGVkIGRlZmF1bHQgTk1JLyNNQyB1c2Ugb2YgTVNSX1NQRUNf Q1RSTC4gKi8KLSAgICBjaS0+c3BlY19jdHJsX2ZsYWdzIHw9IChkZWZhdWx0 X3NwZWNfY3RybF9mbGFncyAmIFNDRl9pc3Rfd3Jtc3IpOworICAgIC8qIFJl LWVuYWJsZWQgZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JzIG5vdyBtaWNy b2NvZGUgaXMgbG9hZGVkLiAqLworICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gKGRlZmF1bHRfc3BlY19jdHJsX2ZsYWdzICYgU0NGX0lTVF9NQVNLKTsK IAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSB8 fCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykgKQogICAgICAgICB3 cm1zcmwoTVNSX1NQRUNfQ1RSTCwgZGVmYXVsdF94ZW5fc3BlY19jdHJsKTsK ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNo L3g4Ni9kb21haW4uYwppbmRleCBmZTk1YjI1YTAzNGUuLjBmOTQyNzAyNTRh NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hl bi9hcmNoL3g4Ni9kb21haW4uYwpAQCAtMTgyMCwxMCArMTgyMCwxMCBAQCB2 b2lkIGNvbnRleHRfc3dpdGNoKHN0cnVjdCB2Y3B1ICpwcmV2LCBzdHJ1Y3Qg dmNwdSAqbmV4dCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAg ICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIHdpdGggdGhl IFZFUlcgZGlzcG9zaXRpb24uICovCi0gICAgICAgIGluZm8tPnNwZWNfY3Ry bF9mbGFncyAmPSB+U0NGX3Zlcnc7Ci0gICAgICAgIGlmICggbmV4dGQtPmFy Y2gudmVydyApCi0gICAgICAgICAgICBpbmZvLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gU0NGX3Zlcnc7CisgICAgICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0 YWNrIGJsb2NrIHdpdGggdGhlIG5ldyBzcGVjX2N0cmwgc2V0dGluZ3MuICov CisgICAgICAgIGluZm8tPnNwZWNfY3RybF9mbGFncyA9CisgICAgICAgICAg ICAoaW5mby0+c3BlY19jdHJsX2ZsYWdzICAgICAgICYgflNDRl9ET01fTUFT SykgfAorICAgICAgICAgICAgKG5leHRkLT5hcmNoLnNwZWNfY3RybF9mbGFn cyAmICBTQ0ZfRE9NX01BU0spOwogICAgIH0KIAogICAgIHNjaGVkX2NvbnRl eHRfc3dpdGNoZWQocHJldiwgbmV4dCk7CmRpZmYgLS1naXQgYS94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMK aW5kZXggNThhZjhhMjgzODZhLi4zMDMwNDAwYTcyZTMgMTAwNjQ0Ci0tLSBh L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKQEAgLTk3OCw5ICs5NzgsMTIgQEAgdm9pZCBzcGVjX2N0 cmxfaW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCkKIHsKICAgICBib29s IHB2ID0gaXNfcHZfZG9tYWluKGQpOwogCi0gICAgZC0+YXJjaC52ZXJ3ID0K LSAgICAgICAgKHB2ID8gb3B0X21kX2NsZWFyX3B2IDogb3B0X21kX2NsZWFy X2h2bSkgfHwKLSAgICAgICAgKG9wdF9mYl9jbGVhcl9tbWlvICYmIGlzX2lv bW11X2VuYWJsZWQoZCkpOworICAgIGJvb2wgdmVydyA9ICgocHYgPyBvcHRf bWRfY2xlYXJfcHYgOiBvcHRfbWRfY2xlYXJfaHZtKSB8fAorICAgICAgICAg ICAgICAgICAob3B0X2ZiX2NsZWFyX21taW8gJiYgaXNfaW9tbXVfZW5hYmxl ZChkKSkpOworCisgICAgZC0+YXJjaC5zcGVjX2N0cmxfZmxhZ3MgPQorICAg ICAgICAodmVydyAgID8gU0NGX3ZlcncgICAgICAgICA6IDApIHwKKyAgICAg ICAgMDsKIH0KIAogdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRp Z2F0aW9ucyh2b2lkKQpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4 Ni9kb21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvZG9tYWluLmgKaW5k ZXggNzFkMWNhMjQzYjMyLi4wNTI3NjI2YTI2NmYgMTAwNjQ0Ci0tLSBhL3hl bi9pbmNsdWRlL2FzbS14ODYvZG9tYWluLmgKKysrIGIveGVuL2luY2x1ZGUv YXNtLXg4Ni9kb21haW4uaApAQCAtMjk1LDggKzI5NSw3IEBAIHN0cnVjdCBh cmNoX2RvbWFpbgogICAgIHVpbnQzMl90IHBjaV9jZjg7CiAgICAgdWludDhf dCBjbW9zX2lkeDsKIAotICAgIC8qIFVzZSBWRVJXIG9uIHJldHVybi10by1n dWVzdCBmb3IgaXRzIGZsdXNoaW5nIHNpZGUgZWZmZWN0LiAqLwotICAgIGJv b2wgdmVydzsKKyAgICB1aW50OF90IHNwZWNfY3RybF9mbGFnczsgLyogU2Vl IFNDRl9ET01fTUFTSyAqLwogCiAgICAgdW5pb24gewogICAgICAgICBzdHJ1 Y3QgcHZfZG9tYWluIHB2OwpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKaW5kZXggZmZjMDU0OTc1ZWUzLi5hN2IxYjhmNTkwODQgMTAwNjQ0 Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaApAQCAtMjAsMTIgKzIw LDQwIEBACiAjaWZuZGVmIF9fWDg2X1NQRUNfQ1RSTF9IX18KICNkZWZpbmUg X19YODZfU1BFQ19DVFJMX0hfXwogCi0vKiBFbmNvZGluZyBvZiBjcHVpbmZv LnNwZWNfY3RybF9mbGFncyAqLworLyoKKyAqIEVuY29kaW5nIG9mOgorICog ICBjcHVpbmZvLnNwZWNfY3RybF9mbGFncworICogICBkZWZhdWx0X3NwZWNf Y3RybF9mbGFncworICogICBkb21haW4uc3BlY19jdHJsX2ZsYWdzCisgKgor ICogTGl2ZSBzZXR0aW5ncyBhcmUgaW4gdGhlIHRvcC1vZi1zdGFjayBibG9j aywgYmVjYXVzZSB0aGV5IG5lZWQgdG8gYmUKKyAqIGFjY2Vzc2FibGUgd2hl biBYUFRJIGlzIGFjdGl2ZS4gIFNvbWUgc2V0dGluZ3MgYXJlIGZpeGVkIGZy b20gYm9vdCwgc29tZQorICogY29udGV4dCBzd2l0Y2hlZCBwZXIgZG9tYWlu LCBhbmQgc29tZSBpbmhpYml0ZWQgaW4gdGhlIFMzIHBhdGguCisgKi8KICNk ZWZpbmUgU0NGX3VzZV9zaGFkb3cgKDEgPDwgMCkKICNkZWZpbmUgU0NGX2lz dF93cm1zciAgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAgKDEg PDwgMikKICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKIAorLyoK KyAqIFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNhbiBpbnRlcnJ1cHQgYW55 IGFyYml0cmFyeSBjb250ZXh0LiAgU29tZQorICogZnVuY3Rpb25hbGl0eSBy ZXF1aXJlcyB1cGRhdGVkIG1pY3JvY29kZSB0byB3b3JrLgorICoKKyAqIE9u IGJvb3QsIHRoaXMgaXMgZWFzeTsgd2UgbG9hZCBtaWNyb2NvZGUgYmVmb3Jl IGZpZ3VyaW5nIG91dCB3aGljaAorICogc3BlY3VsYXRpdmUgcHJvdGVjdGlv bnMgdG8gYXBwbHkuICBIb3dldmVyLCBvbiB0aGUgUzMgcmVzdW1lIHBhdGgs IHdlIG11c3QKKyAqIGJlIGFibGUgdG8gZGlzYWJsZSB0aGUgY29uZmlndXJl ZCBtaXRpZ2F0aW9ucyB1bnRpbCBtaWNyb2NvZGUgaXMgcmVsb2FkZWQuCisg KgorICogVGhlc2UgYXJlIHRoZSBjb250cm9scyB0byBpbmhpYml0IG9uIHRo ZSBTMyByZXN1bWUgcGF0aCB1bnRpbCBtaWNyb2NvZGUgaGFzCisgKiBiZWVu IHJlbG9hZGVkLgorICovCisjZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NGX2lz dF93cm1zcikKKworLyoKKyAqIFNvbWUgc3BlY3VsYXRpdmUgcHJvdGVjdGlv bnMgYXJlIHBlci1kb21haW4uICBUaGVzZSBzZXR0aW5ncyBhcmUgbWVyZ2Vk CisgKiBpbnRvIHRoZSB0b3Atb2Ytc3RhY2sgYmxvY2sgaW4gdGhlIGNvbnRl eHQgc3dpdGNoIHBhdGguCisgKi8KKyNkZWZpbmUgU0NGX0RPTV9NQVNLIChT Q0ZfdmVydykKKwogI2lmbmRlZiBfX0FTU0VNQkxZX18KIAogI2luY2x1ZGUg PGFzbS9hbHRlcm5hdGl2ZS5oPgpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmxfYXNtLmggYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybF9hc20uaAppbmRleCBmZTkwYzgwYWMzOWMuLjEyYjMxMTFl YmRjMCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxf YXNtLmgKQEAgLTI1NSw5ICsyNTUsNiBAQAogCiAvKgogICogVXNlIGluIElT VCBpbnRlcnJ1cHQvZXhjZXB0aW9uIGNvbnRleHQuICBNYXkgaW50ZXJydXB0 IFhlbiBvciBQViBjb250ZXh0LgotICogRmluZSBncmFpbiBjb250cm9sIG9m IFNDRl9pc3Rfd3Jtc3IgaXMgbmVlZGVkIGZvciBzYWZldHkgaW4gdGhlIFMz IHJlc3VtZQotICogcGF0aCB0byBhdm9pZCB1c2luZyBNU1JfU1BFQ19DVFJM IGJlZm9yZSB0aGUgbWljcm9jb2RlIGludHJvZHVjaW5nIGl0IGhhcwotICog YmVlbiByZWxvYWRlZC4KICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9G Uk9NX0lOVFJfSVNUCiAvKgo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-15.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-15.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIFNDRl9pc3Rfd3Jt c3IgdG8gU0NGX2lzdF9zY19tc3IKCldlIGFyZSBhYm91dCB0byBpbnRyb2R1 Y2UgU0NGX2lzdF9pYnBiLCBhdCB3aGljaCBwb2ludCBTQ0ZfaXN0X3dybXNy IGJlY29tZXMKYW1iaWd1b3VzLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCgpU aGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jCmluZGV4IDMwMzA0MDBhNzJlMy4uZGVhYjVkOTkwYzlm IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMDY0LDcgKzEwNjQsNyBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgewogICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8 PSBTQ0ZfaXN0X3dybXNyOworICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0 cmxfZmxhZ3MgfD0gU0NGX2lzdF9zY19tc3I7CiAgICAgICAgICAgICBzZXR1 cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01TUl9QVik7CiAgICAg ICAgIH0KIApAQCAtMTA3NSw3ICsxMDc1LDcgQEAgdm9pZCBfX2luaXQgaW5p dF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICAgICAg ICogWGVuJ3MgdmFsdWUgaXMgbm90IHJlc3RvcmVkIGF0b21pY2FsbHkuICBB biBlYXJseSBOTUkgaGl0dGluZwogICAgICAgICAgICAgICogdGhlIFZNRXhp dCBwYXRoIG5lZWRzIHRvIHJlc3RvcmUgWGVuJ3MgdmFsdWUgZm9yIHNhZmV0 eS4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgZGVmYXVsdF9zcGVj X2N0cmxfZmxhZ3MgfD0gU0NGX2lzdF93cm1zcjsKKyAgICAgICAgICAgIGRl ZmF1bHRfc3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfc2NfbXNyOwogICAg ICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19N U1JfSFZNKTsKICAgICAgICAgfQogICAgIH0KQEAgLTEwODgsNyArMTA4OCw3 IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnMo dm9pZCkKICAgICAgICAgICogb24gcmVhbCBoYXJkd2FyZSBtYXRjaGVzIHRo ZSBhdmFpbGFiaWxpdHkgb2YgTVNSX1NQRUNfQ1RSTCBpbiB0aGUKICAgICAg ICAgICogZmlyc3QgcGxhY2UuCiAgICAgICAgICAqCi0gICAgICAgICAqIE5v IG5lZWQgZm9yIFNDRl9pc3Rfd3Jtc3IgYmVjYXVzZSBYZW4ncyB2YWx1ZSBp cyByZXN0b3JlZAorICAgICAgICAgKiBObyBuZWVkIGZvciBTQ0ZfaXN0X3Nj X21zciBiZWNhdXNlIFhlbidzIHZhbHVlIGlzIHJlc3RvcmVkCiAgICAgICAg ICAqIGF0b21pY2FsbHkgV1JUIE5NSXMgaW4gdGhlIFZNRXhpdCBwYXRoLgog ICAgICAgICAgKgogICAgICAgICAgKiBUT0RPOiBBZGp1c3QgY3B1X2hhc19z dm1fc3BlY19jdHJsIHRvIGJlIHVzYWJsZSBlYXJsaWVyIG9uIGJvb3QuCmRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCBhN2IxYjhm NTkwODQuLjNiMmNkNDI0MTMyZSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCkBAIC0zMSw3ICszMSw3IEBACiAgKiBjb250ZXh0IHN3 aXRjaGVkIHBlciBkb21haW4sIGFuZCBzb21lIGluaGliaXRlZCBpbiB0aGUg UzMgcGF0aC4KICAqLwogI2RlZmluZSBTQ0ZfdXNlX3NoYWRvdyAoMSA8PCAw KQotI2RlZmluZSBTQ0ZfaXN0X3dybXNyICAoMSA8PCAxKQorI2RlZmluZSBT Q0ZfaXN0X3NjX21zciAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAg ICAoMSA8PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQog CkBAIC00Niw3ICs0Niw3IEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xz IHRvIGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3Jv Y29kZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NG X0lTVF9NQVNLIChTQ0ZfaXN0X3dybXNyKQorI2RlZmluZSBTQ0ZfSVNUX01B U0sgKFNDRl9pc3Rfc2NfbXNyKQogCiAvKgogICogU29tZSBzcGVjdWxhdGl2 ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4gIFRoZXNlIHNldHRpbmdz IGFyZSBtZXJnZWQKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKaW5kZXggMTJiMzExMWViZGMwLi4zZTlkNmJkMTE0MjAgMTAw NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5o CisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCkBA IC0yNzMsOCArMjczLDggQEAKIAogLkxcQF9za2lwX3JzYjoKIAotICAgIHRl c3QgJFNDRl9pc3Rfd3Jtc3IsICVhbAotICAgIGp6IC5MXEBfc2tpcF93cm1z cgorICAgIHRlc3QgJFNDRl9pc3Rfc2NfbXNyLCAlYWwKKyAgICBqeiAuTFxA X3NraXBfbXNyX3NwZWNfY3RybAogCiAgICAgeG9yICVlZHgsICVlZHgKICAg ICB0ZXN0YiAkMywgVVJFR1NfY3MoJXJzcCkKQEAgLTI5Nyw3ICsyOTcsNyBA QCBVTkxJS0VMWV9ESVNQQVRDSF9MQUJFTChcQF9zZXJpYWxpc2UpOgogICAg ICAqIHRvIHNwZWN1bGF0ZSBhcm91bmQgdGhlIFdSTVNSLiAgQXMgYSByZXN1 bHQsIHdlIG5lZWQgYSBkaXNwYXRjaAogICAgICAqIHNlcmlhbGlzaW5nIGlu c3RydWN0aW9uIGluIHRoZSBlbHNlIGNsYXVzZS4KICAgICAgKi8KLS5MXEBf c2tpcF93cm1zcjoKKy5MXEBfc2tpcF9tc3Jfc3BlY19jdHJsOgogICAgIGxm ZW5jZQogICAgIFVOTElLRUxZX0VORChcQF9zZXJpYWxpc2UpCiAuZW5kbQpA QCAtMzA4LDcgKzMwOCw3IEBAIFVOTElLRUxZX0RJU1BBVENIX0xBQkVMKFxA X3NlcmlhbGlzZSk6CiAgKiBSZXF1aXJlcyAlcmJ4PXN0YWNrX2VuZAogICog Q2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAogICovCi0gICAgdGVzdGIgJFND Rl9pc3Rfd3Jtc3IsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19jdHJsX2Zs YWdzKSglcmJ4KQorICAgIHRlc3RiICRTQ0ZfaXN0X3NjX21zciwgU1RBQ0tf Q1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyYngpCiAgICAganog LkxcQF9za2lwCiAKICAgICBET19TUEVDX0NUUkxfRVhJVF9UT19YRU4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-16.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-16.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIG9wdF9pYnBiIHRv IG9wdF9pYnBiX2N0eHRfc3dpdGNoCgpXZSBhcmUgYWJvdXQgdG8gaW50cm9k dWNlIHRoZSB1c2Ugb2YgSUJQQiBhdCBkaWZmZXJlbnQgcG9pbnRzIGluIFhl biwgbWFraW5nCm9wdF9pYnBiIGFtYmlndW91cy4gIFJlbmFtZSBpdCB0byBv cHRfaWJwYl9jdHh0X3N3aXRjaC4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoK U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKaW5kZXggMGY5NDI3MDI1NGE2 Li42MTk5ZjM2NTE0NTcgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9kb21h aW4uYworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTE3OTIsNyAr MTc5Miw3IEBAIHZvaWQgY29udGV4dF9zd2l0Y2goc3RydWN0IHZjcHUgKnBy ZXYsIHN0cnVjdCB2Y3B1ICpuZXh0KQogCiAgICAgICAgIGN0eHRfc3dpdGNo X2xldmVsbGluZyhuZXh0KTsKIAotICAgICAgICBpZiAoIG9wdF9pYnBiICYm ICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQorICAgICAgICBpZiAoIG9wdF9p YnBiX2N0eHRfc3dpdGNoICYmICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQog ICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWMgREVGSU5FX1BFUl9DUFUo dW5zaWduZWQgaW50LCBsYXN0KTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCAqbGFzdF9pZCA9ICZ0aGlzX2NwdShsYXN0KTsKZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0 cmwuYwppbmRleCBkZWFiNWQ5OTBjOWYuLjQ1MTczMzllYTY2OSAxMDA2NDQK LS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9zcGVjX2N0cmwuYwpAQCAtNTQsNyArNTQsNyBAQCBpbnQ4X3QgX19p bml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBv cHRfc3NiZDsKIGludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0gLTE7CiAK LWJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYiA9IHRydWU7Citib29sIF9f cmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSB0cnVlOwogaW50 OF90IF9fcmVhZF9tb3N0bHkgb3B0X2VhZ2VyX2ZwdSA9IC0xOwogaW50OF90 IF9fcmVhZF9tb3N0bHkgb3B0X2wxZF9mbHVzaCA9IC0xOwogYm9vbCBfX3Jl YWRfbW9zdGx5IG9wdF9icmFuY2hfaGFyZGVuID0gdHJ1ZTsKQEAgLTExOCw3 ICsxMTgsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKIAogICAgICAgICAgICAgb3B0X3RodW5rID0gVEhV TktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMgPSAwOwotICAgICAgICAg ICAgb3B0X2licGIgPSBmYWxzZTsKKyAgICAgICAgICAgIG9wdF9pYnBiX2N0 eHRfc3dpdGNoID0gZmFsc2U7CiAgICAgICAgICAgICBvcHRfc3NiZCA9IGZh bHNlOwogICAgICAgICAgICAgb3B0X2wxZF9mbHVzaCA9IDA7CiAgICAgICAg ICAgICBvcHRfYnJhbmNoX2hhcmRlbiA9IGZhbHNlOwpAQCAtMjM5LDcgKzIz OSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX3NwZWNfY3RybChjb25z dCBjaGFyICpzKQogCiAgICAgICAgIC8qIE1pc2Mgc2V0dGluZ3MuICovCiAg ICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaWJwYiIs IHMsIHNzKSkgPj0gMCApCi0gICAgICAgICAgICBvcHRfaWJwYiA9IHZhbDsK KyAgICAgICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gdmFsOwogICAg ICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImVhZ2VyLWZw dSIsIHMsIHNzKSkgPj0gMCApCiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1 ID0gdmFsOwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImwxZC1mbHVzaCIsIHMsIHNzKSkgPj0gMCApCkBAIC00NTUsNyArNDU1 LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBp bmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChv cHRfdHN4ICYgMSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBU U1grIiA6ICIgVFNYLSIsCiAgICAgICAgICAgICFib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfU1JCRFNfQ1RSTCkgICAgID8gIiIgOgogICAgICAgICAgICBv cHRfc3JiX2xvY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIg U1JCX0xPQ0srIiA6ICIgU1JCX0xPQ0stIiwKLSAgICAgICAgICAgb3B0X2li cGIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUEIi ICA6ICIiLAorICAgICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCAgICAg ICAgICAgICAgICAgICAgICA/ICIgSUJQQi1jdHh0IiA6ICIiLAogICAgICAg ICAgICBvcHRfbDFkX2ZsdXNoICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA/ICIgTDFEX0ZMVVNIIiA6ICIiLAogICAgICAgICAgICBvcHRfbWRfY2xl YXJfcHYgfHwgb3B0X21kX2NsZWFyX2h2bSB8fAogICAgICAgICAgICBvcHRf ZmJfY2xlYXJfbW1pbyAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVkVS VyIgIDogIiIsCkBAIC0xMTcwLDcgKzExNzAsNyBAQCB2b2lkIF9faW5pdCBp bml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAKICAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KICAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQotICAgICAgICBvcHRfaWJwYiA9IGZhbHNlOworICAgICAgICBvcHRfaWJw Yl9jdHh0X3N3aXRjaCA9IGZhbHNlOwogCiAgICAgLyogQ2hlY2sgd2hldGhl ciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdC4gKi8K ICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggM2IyY2Q0MjQxMzJlLi40OTUy NjBkNmI2ZmMgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3Bl Y19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwu aApAQCAtNjMsNyArNjMsNyBAQAogdm9pZCBpbml0X3NwZWN1bGF0aW9uX21p dGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5pdF9kb21haW4o c3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9wdF9pYnBiOwor ZXh0ZXJuIGJvb2wgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9v bCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsKIGV4 dGVybiBpbnQ4X3Qgb3B0X2wxZF9mbHVzaDsK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-17.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-17.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFJfSVNUCgpXZSBhcmUgc2hvcnRseSBnb2luZyB0byBh ZGQgYSBjb25kaXRpb25hbCBJQlBCIGluIHRoaXMgcGF0aC4KClRoZXJlZm9y ZSwgd2UgY2Fubm90IGhvbGQgc3BlY19jdHJsX2ZsYWdzIGluICVlYXgsIGFu ZCByZWx5IG9uIG9ubHkgY2xvYmJlcmluZwppdCBhZnRlciB3ZSdyZSBkb25l IHdpdGggaXRzIGNvbnRlbnRzLiAgJXJieCBpcyBhdmFpbGFibGUgZm9yIHVz ZSwgYW5kIHRoZQptb3JlIG5vcm1hbCByZWdpc3RlciB0byBob2xkIHByZXNl cnZlZCBpbmZvcm1hdGlvbiBpbi4KCldpdGggJXJheCBmcmVlZCB1cCwgdXNl IGl0IGluc3RlYWQgb2YgJXJkeCBmb3IgdGhlIFJTQiB0bXAgcmVnaXN0ZXIs IGFuZCBmb3IKdGhlIGFkanVzdG1lbnQgdG8gc3BlY19jdHJsX2ZsYWdzLgoK VGhpcyBsZWF2ZXMgbm8gdXNlIG9mICVyZHgsIGV4Y2VwdCBhcyAwIGZvciB0 aGUgdXBwZXIgaGFsZiBvZiBXUk1TUi4gIEluCnByYWN0aWNlLCAlcmR4IGlz IDAgZnJvbSBTQVZFX0FMTCBvbiBhbGwgcGF0aHMgYW5kIGlzbid0IGxpa2Vs eSB0byBjaGFuZ2UgaW4KdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSwgc28gdXBk YXRlIHRoZSBtYWNybyBlbnRyeSByZXF1aXJlbWVudHMgdG8gc3RhdGUgdGhp cwpkZXBlbmRlbmN5LiAgVGhpcyBtYXJnaW5hbCBvcHRpbWlzYXRpb24gY2Fu IGJlIHJldmlzaXRlZCBpZiBjaXJjdW1zdGFuY2VzCmNoYW5nZS4KCk5vIHBy YWN0aWNhbCBjaGFuZ2UuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IDZh NWY4YWFlYzNkOS4uNDgxMTEwZmI5MzYwIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9lbnRyeS5TCkBAIC04MDUsNyArODA1LDcgQEAgRU5UUlkoZG91YmxlX2Zh dWx0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAKLSAgICAgICAg U1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJl Z3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyYngKQEAgLTgzOCw3ICs4MzgsNyBA QCBoYW5kbGVfaXN0X2V4Y2VwdGlvbjoKIAogICAgICAgICBHRVRfU1RBQ0tf RU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJf SVNUIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICov CisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJfSVNUIC8qIFJl cTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhYmNkICov CiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAq YCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBt b3YgICBTVEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4 CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCmlu ZGV4IDNlOWQ2YmQxMTQyMC4uM2VjNjgwYjU4NzBiIDEwMDY0NAotLS0gYS94 ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaAorKysgYi94ZW4v aW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaApAQCAtMjU4LDM0ICsy NTgsMzMgQEAKICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lO VFJfSVNUCiAvKgotICogUmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNr X2VuZAotICogQ2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAorICogUmVxdWly ZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNrX2VuZCwgJXJkeD0wCisgKiBDbG9i YmVycyAlcmF4LCAlcmJ4LCAlcmN4LCAlcmR4CiAgKgogICogVGhpcyBpcyBs b2dpY2FsIG1lcmdlIG9mIERPX09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNf Q1RSTF9FTlRSWQogICogbWF5YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9u YWxzIHJhdGhlciB0aGFuIGFsdGVybmF0aXZlcy4KICAqLwotICAgIG1vdnpi bCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCks ICVlYXgKKyAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0 cmxfZmxhZ3MpKCVyMTQpLCAlZWJ4CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3Jz YiwgJWFsCisgICAgdGVzdCAkU0NGX2lzdF9yc2IsICVibAogICAgIGp6IC5M XEBfc2tpcF9yc2IKIAotICAgIERPX09WRVJXUklURV9SU0IgdG1wPXJkeCAv KiBDbG9iYmVycyAlcmN4LyVyZHggKi8KKyAgICBET19PVkVSV1JJVEVfUlNC ICAgICAgICAgLyogQ2xvYmJlcnMgJXJheC8lcmN4ICovCiAKIC5MXEBfc2tp cF9yc2I6CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3NjX21zciwgJWFsCisgICAg dGVzdCAkU0NGX2lzdF9zY19tc3IsICVibAogICAgIGp6IC5MXEBfc2tpcF9t c3Jfc3BlY19jdHJsCiAKLSAgICB4b3IgJWVkeCwgJWVkeAorICAgIHhvciAl ZWF4LCAlZWF4CiAgICAgdGVzdGIgJDMsIFVSRUdTX2NzKCVyc3ApCi0gICAg c2V0bnogJWRsCi0gICAgbm90ICVlZHgKLSAgICBhbmQgJWRsLCBTVEFDS19D UFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICBzZXRu eiAlYWwKKyAgICBub3QgJWVheAorICAgIGFuZCAlYWwsIFNUQUNLX0NQVUlO Rk9fRklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KQogCiAgICAgLyogTG9h ZCBYZW4ncyBpbnRlbmRlZCB2YWx1ZS4gKi8KICAgICBtb3YgJE1TUl9TUEVD X0NUUkwsICVlY3gKICAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4 ZW5fc3BlY19jdHJsKSglcjE0KSwgJWVheAotICAgIHhvciAlZWR4LCAlZWR4 CiAgICAgd3Jtc3IKIAogICAgIC8qIE9wZW5jb2RlZCBVTkxJS0VMWV9TVEFS VCgpIHdpdGggbm8gY29uZGl0aW9uLiAqLwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-18.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-18.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3VwcG9ydCBJQlBCLW9uLWVu dHJ5CgpXZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGlzIHRvIG1pdGlnYXRlIEJy YW5jaCBUeXBlIENvbmZ1c2lvbiBvbiBBTUQvSHlnb24gQ1BVcywKYnV0IGFz IHdlJ3ZlIHRhbGtlZCBhYm91dCB1c2luZyBpdCBpbiBvdGhlciBjYXNlcyB0 b28sIGFycmFuZ2UgdG8gc3VwcG9ydCBpdApnZW5lcmFsbHkuICBIb3dldmVy LCB0aGlzIGlzIGFsc28gdmVyeSBleHBlbnNpdmUgaW4gc29tZSBjYXNlcywg c28gd2UncmUgZ29pbmcKdG8gd2FudCBwZXItZG9tYWluIGNvbnRyb2xzLgoK SW50cm9kdWNlIFNDRl9pc3RfaWJwYiBhbmQgU0NGX2VudHJ5X2licGIgY29u dHJvbHMsIGFkZGluZyB0aGVtIHRvIHRoZSBJU1QgYW5kCkRPTSBtYXNrcyBh cyBhcHByb3ByaWF0ZS4gIEFsc28gaW50cm9kdWNlIFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfe1BWLEhWTX0gdG8KdG8gcGF0Y2ggdGhlIGNvZGUgYmxvY2tz LgoKRm9yIFNWTSwgdGhlIFNUR0kgaXMgc2VyaWFsaXNpbmcgZW5vdWdoIHRv IHByb3RlY3QgYWdhaW5zdCBTcGVjdHJlLXYxIGF0dGFja3MsCnNvIG5vICJl bHNlIGxmZW5jZSIgaXMgbmVjZXNzYXJ5LiAgVlQteCB3aWxsIHVzZSB1c2Ug dGhlIE1TUiBob3N0IGxvYWQgbGlzdCwKc28gZG9lc24ndCBuZWVkIGFueSBj b2RlIGluIHRoZSBWTUV4aXQgcGF0aC4KCkZvciB0aGUgSVNUIHBhdGgsIHdl IGNhbid0IHNhZmVseSBjaGVjayBDUEw9PTAgdG8gc2tpcCBhIGZsdXNoLCBh cyB3ZSBtaWdodApoYXZlIGhpdCBhbiBlbnRyeSBwYXRoIGJlZm9yZSBpdCdz IElCUEIuICBBcyBJU1QgaGl0dGluZyBYZW4gaXMgcmFyZSwgZmx1c2gKaXJy ZXNwZWN0aXZlIG9mIENQTC4gIEEgbGF0ZXIgcGF0aCwgU0NGX2lzdF9zY19t c3IsIHByb3ZpZGVzIFNwZWN0cmUtdjEKc2FmZXR5LgoKRm9yIHRoZSBQViBw YXRocywgd2Uga25vdyB3ZSdyZSBpbnRlcnJ1cHRpbmcgQ1BMPjAsIHdoaWxl IGZvciB0aGUgSU5UUiBwYXRocywKd2UgY2FuIHNhZmVseSBjaGVjayBDUEw9 PTAuICBPbmx5IGZsdXNoIHdoZW4gaW50ZXJydXB0aW5nIGd1ZXN0IGNvbnRl eHQuCgpBbiAiZWxzZSBsZmVuY2UiIGlzIG5lZWRlZCBmb3Igc2FmZXR5LCBi dXQgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHNraXAgaXQgb24KdW5hZmZlY3Rl ZCBDUFVzLCBzbyB0aGUgYmxvY2sgd2FudHMgdG8gYmUgYW4gYWx0ZXJuYXRp dmUsIHdoaWNoIG1lYW5zIHRoZQpsZmVuY2UgaGFzIHRvIGJlIGlubGluZSBy YXRoZXIgdGhhbiBVTkxJS0VMWSgpICh0aGUgcmVwbGFjZW1lbnQgYmxvY2sg ZG9lc24ndApoYXZlIGRpc3BsYWNlbWVudHMgZml4ZWQgdXAgZm9yIGFueXRo aW5nIG90aGVyIHRoYW4gdGhlIGZpcnN0IGluc3RydWN0aW9uKS4KCkFzIHdp dGggU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QsICVyZHggaXMgMCBv biBlbnRyeSBzbyByZWx5IG9uIHRoaXMgdG8Kc2hyaW5rIHRoZSBsb2dpYyBt YXJnaW5hbGx5LiAgVXBkYXRlIHRoZSBjb21tZW50cyB0byBzcGVjaWZ5IHRo aXMgbmV3CmRlcGVuZGVuY3kuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9z dm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKaW5k ZXggMDY4NGQyOTA1MGE1Li5kN2M4NWZkZmM2MWIgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L2h2bS9zdm0vZW50cnkuUwpAQCAtOTAsMTAgKzkwLDI2IEBAIF9fVU5MSUtF TFlfRU5EKG5zdm1faGFwKQogCiAgICAgICAgIEdFVF9DVVJSRU5UKGJ4KQog Ci0gICAgICAgIC8qIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1NWTSAgICBSZXE6 IGI9Y3VyciAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjogYWMgICovCisgICAg ICAgIC8qIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1NWTSAgICBSZXE6ICVyc3A9 cmVncy9jcHVpbmZvLCAlcmR4PTAgQ2xvYjogYWMgICovCisKKyAgICAgICAg Lm1hY3JvIHN2bV92bWV4aXRfY29uZF9pYnBiCisgICAgICAgICAgICB0ZXN0 YiAgJFNDRl9lbnRyeV9pYnBiLCBDUFVJTkZPX3hlbl9zcGVjX2N0cmwoJXJz cCkKKyAgICAgICAgICAgIGp6ICAgICAuTF9za2lwX2licGIKKworICAgICAg ICAgICAgbW92ICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAgICAgICAgICAg IG1vdiAgICAkUFJFRF9DTURfSUJQQiwgJWVheAorICAgICAgICAgICAgd3Jt c3IKKy5MX3NraXBfaWJwYjoKKwkuZW5kbQorICAgICAgICBBTFRFUk5BVElW RSAiIiwgc3ZtX3ZtZXhpdF9jb25kX2licGIsIFg4Nl9GRUFUVVJFX0lCUEJf RU5UUllfSFZNCisKICAgICAgICAgQUxURVJOQVRJVkUgIiIsIERPX09WRVJX UklURV9SU0IsIFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0KICAgICAgICAgLyog V0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJl Zm9yZSB0aGlzIHBvaW50LiAqLwogCisgICAgICAgIC8qCisgICAgICAgICAq IFNUR0kgaXMgZXhlY3V0ZWQgdW5jb25kaXRpb25hbGx5LCBhbmQgaXMgc3Vm ZmljaWVudGx5IHNlcmlhbGlzaW5nCisgICAgICAgICAqIHRvIHNhZmVseSBy ZXNvbHZlIGFueSBTcGVjdHJlLXYxIGNvbmNlcm5zIGluIHRoZSBhYm92ZSBs b2dpYy4KKyAgICAgICAgICovCiAgICAgICAgIFNUR0kKIEdMT0JBTChzdm1f c3RnaV9sYWJlbCkKICAgICAgICAgbW92ICAlcnNwLCVyZGkKZGlmZiAtLWdp dCBhL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYyBiL3hlbi9hcmNoL3g4 Ni9odm0vdm14L3ZtY3MuYwppbmRleCBmM2JkN2Y5YmVlOTQuLjQ0N2Y1ODNl MDdjNCAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2h2bS92bXgvdm1jcy5j CisrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYwpAQCAtMTMxMiw2 ICsxMzEyLDEwIEBAIHN0YXRpYyBpbnQgY29uc3RydWN0X3ZtY3Moc3RydWN0 IHZjcHUgKnYpCiAgICAgICAgIHJjID0gdm14X2FkZF9tc3IodiwgTVNSX0ZM VVNIX0NNRCwgRkxVU0hfQ01EX0wxRCwKICAgICAgICAgICAgICAgICAgICAg ICAgICBWTVhfTVNSX0dVRVNUX0xPQURPTkxZKTsKIAorICAgIGlmICggIXJj ICYmIChkLT5hcmNoLnNwZWNfY3RybF9mbGFncyAmIFNDRl9lbnRyeV9pYnBi KSApCisgICAgICAgIHJjID0gdm14X2FkZF9tc3IodiwgTVNSX1BSRURfQ01E LCBQUkVEX0NNRF9JQlBCLAorICAgICAgICAgICAgICAgICAgICAgICAgIFZN WF9NU1JfSE9TVCk7CisKICBvdXQ6CiAgICAgdm14X3ZtY3NfZXhpdCh2KTsK IApkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9jb21wYXQvZW50 cnkuUyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvY29tcGF0L2VudHJ5LlMKaW5k ZXggOTA1OWMyZWY2ZTQzLi42ZDJlMDQyNjc3MWUgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni94ODZfNjQvY29tcGF0L2VudHJ5LlMKKysrIGIveGVuL2Fy Y2gveDg2L3g4Nl82NC9jb21wYXQvZW50cnkuUwpAQCAtMTcsNyArMTcsNyBA QCBFTlRSWShlbnRyeV9pbnQ4MikKICAgICAgICAgbW92bCAgJEhZUEVSQ0FM TF9WRUNUT1IsIDQoJXJzcCkKICAgICAgICAgU0FWRV9BTEwgY29tcGF0PTEg LyogRFBMMSBnYXRlLCByZXN0cmljdGVkIHRvIDMyYml0IFBWIGd1ZXN0cyBv bmx5LiAqLwogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8q IFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6IGFjZCAqLworICAgICAg ICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9j cHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAgICAgICAvKiBXQVJO SU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3Jl IHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgQ1I0X1BWMzJfUkVTVE9SRQpA QCAtMjA4LDcgKzIwOCw3IEBAIEVOVFJZKGNzdGFyX2VudGVyKQogICAgICAg ICBtb3ZsICAkVFJBUF9zeXNjYWxsLCA0KCVyc3ApCiAgICAgICAgIFNBVkVf QUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYgLyogUmVx OiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjogYWNkICovCisgICAgICAgIFNQ RUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWlu Zm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAgICAgICAgIC8qIFdBUk5JTkch IGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhp cyBwb2ludC4gKi8KIAogICAgICAgICBHRVRfU1RBQ0tfRU5EKGJ4KQpkaWZm IC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TIGIveGVuL2Fy Y2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IDQ4MTExMGZiOTM2MC4uOWZk NGNlZjMwZjczIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYveDg2XzY0L2Vu dHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCkBAIC0y MzUsNyArMjM1LDcgQEAgRU5UUlkobHN0YXJfZW50ZXIpCiAgICAgICAgIG1v dmwgICRUUkFQX3N5c2NhbGwsIDQoJXJzcCkKICAgICAgICAgU0FWRV9BTEwK IAotICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVy c3A9cmVncy9jcHVpbmZvLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19D VFJMX0VOVFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywg JXJkeD0wLCBDbG9iOiBhY2QgKi8KICAgICAgICAgLyogV0FSTklORyEgYHJl dGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBv aW50LiAqLwogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoYngpCkBAIC0yNzAs NyArMjcwLDcgQEAgR0xPQkFMKHN5c2VudGVyX2VmbGFnc19zYXZlZCkKICAg ICAgICAgbW92bCAgJFRSQVBfc3lzY2FsbCwgNCglcnNwKQogICAgICAgICBT QVZFX0FMTAogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8q IFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6IGFjZCAqLworICAgICAg ICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9j cHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAgICAgICAvKiBXQVJO SU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3Jl IHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgR0VUX1NUQUNLX0VORChieCkK QEAgLTMyMSw3ICszMjEsNyBAQCBFTlRSWShpbnQ4MF9kaXJlY3RfdHJhcCkK ICAgICAgICAgbW92bCAgJDB4ODAsIDQoJXJzcCkKICAgICAgICAgU0FWRV9B TEwKIAotICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBSZXE6 ICVyc3A9cmVncy9jcHVpbmZvLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BF Q19DVFJMX0VOVFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5m bywgJXJkeD0wLCBDbG9iOiBhY2QgKi8KICAgICAgICAgLyogV0FSTklORyEg YHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlz IHBvaW50LiAqLwogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoYngpCkBAIC01 ODEsNyArNTgxLDcgQEAgRU5UUlkoY29tbW9uX2ludGVycnVwdCkKIAogICAg ICAgICBHRVRfU1RBQ0tfRU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFIgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9ZW5kLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5U UiAvKiBSZXE6ICVyc3A9cmVncywgJXIxND1lbmQsICVyZHg9MCwgQ2xvYjog YWNkICovCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwg YGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAg ICAgICBtb3YgICBTVEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQp LCAlcmN4CkBAIC02MTMsNyArNjEzLDcgQEAgR0xPQkFMKGhhbmRsZV9leGNl cHRpb24pCiAKICAgICAgICAgR0VUX1NUQUNLX0VORCgxNCkKIAotICAgICAg ICBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJzcD1yZWdz LCAlcjE0PWVuZCwgQ2xvYjogYWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFIgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9ZW5kLCAl cmR4PTAsIENsb2I6IGFjZCAqLwogICAgICAgICAvKiBXQVJOSU5HISBgcmV0 YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3JlIHRoaXMgcG9p bnQuICovCiAKICAgICAgICAgbW92ICAgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4 ZW5fY3IzKSglcjE0KSwgJXJjeApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9j cHVmZWF0dXJlcy5oCmluZGV4IGZjNTRjMjRhMzRlZi4uYzYxMzZjYTRhMDMx IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L2NwdWZlYXR1cmVz LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCkBA IC0zNyw2ICszNyw4IEBAIFhFTl9DUFVGRUFUVVJFKFNDX01TUl9JRExFLCAg ICAgICBYODZfU1lOVEgoMjEpKSAvKiBDbGVhciBNU1JfU1BFQ19DVFJMIG9u IGlkbGUKIFhFTl9DUFVGRUFUVVJFKFhFTl9MQlIsICAgICAgICAgICBYODZf U1lOVEgoMjIpKSAvKiBYZW4gdXNlcyBNU1JfREVCVUdDVEwuTEJSICovCiAv KiBCaXRzIDIzLDI0IHVudXNlZC4gKi8KIFhFTl9DUFVGRUFUVVJFKFNDX1ZF UldfSURMRSwgICAgICBYODZfU1lOVEgoMjUpKSAvKiBWRVJXIHVzZWQgYnkg WGVuIGZvciBpZGxlICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX0VOVFJZX1BW LCAgICAgWDg2X1NZTlRIKDI2KSkgLyogTVNSX1BSRURfQ01EIHVzZWQgYnkg WGVuIGZvciBQViAqLworWEVOX0NQVUZFQVRVUkUoSUJQQl9FTlRSWV9IVk0s ICAgIFg4Nl9TWU5USCgyNykpIC8qIE1TUl9QUkVEX0NNRCB1c2VkIGJ5IFhl biBmb3IgSFZNICovCiAKIC8qIEJ1ZyB3b3JkcyBmb2xsb3cgdGhlIHN5bnRo ZXRpYyB3b3Jkcy4gKi8KICNkZWZpbmUgWDg2X05SX0JVRyAxCmRpZmYgLS1n aXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIveGVuL2lu Y2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCA0OTUyNjBkNmI2ZmMu LjhiNjlhODE5MTc1YSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNf Y3RybC5oCkBAIC0zNCw2ICszNCw4IEBACiAjZGVmaW5lIFNDRl9pc3Rfc2Nf bXNyICgxIDw8IDEpCiAjZGVmaW5lIFNDRl9pc3RfcnNiICAgICgxIDw8IDIp CiAjZGVmaW5lIFNDRl92ZXJ3ICAgICAgICgxIDw8IDMpCisjZGVmaW5lIFND Rl9pc3RfaWJwYiAgICgxIDw8IDQpCisjZGVmaW5lIFNDRl9lbnRyeV9pYnBi ICgxIDw8IDUpCiAKIC8qCiAgKiBUaGUgSVNUIHBhdGhzIChOTUkvI01DKSBj YW4gaW50ZXJydXB0IGFueSBhcmJpdHJhcnkgY29udGV4dC4gIFNvbWUKQEAg LTQ2LDEzICs0OCwxMyBAQAogICogVGhlc2UgYXJlIHRoZSBjb250cm9scyB0 byBpbmhpYml0IG9uIHRoZSBTMyByZXN1bWUgcGF0aCB1bnRpbCBtaWNyb2Nv ZGUgaGFzCiAgKiBiZWVuIHJlbG9hZGVkLgogICovCi0jZGVmaW5lIFNDRl9J U1RfTUFTSyAoU0NGX2lzdF9zY19tc3IpCisjZGVmaW5lIFNDRl9JU1RfTUFT SyAoU0NGX2lzdF9zY19tc3IgfCBTQ0ZfaXN0X2licGIpCiAKIC8qCiAgKiBT b21lIHNwZWN1bGF0aXZlIHByb3RlY3Rpb25zIGFyZSBwZXItZG9tYWluLiAg VGhlc2Ugc2V0dGluZ3MgYXJlIG1lcmdlZAogICogaW50byB0aGUgdG9wLW9m LXN0YWNrIGJsb2NrIGluIHRoZSBjb250ZXh0IHN3aXRjaCBwYXRoLgogICov Ci0jZGVmaW5lIFNDRl9ET01fTUFTSyAoU0NGX3ZlcncpCisjZGVmaW5lIFND Rl9ET01fTUFTSyAoU0NGX3ZlcncgfCBTQ0ZfZW50cnlfaWJwYikKIAogI2lm bmRlZiBfX0FTU0VNQkxZX18KIApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmxfYXNtLmggYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybF9hc20uaAppbmRleCAzZWM2ODBiNTg3MGIuLjU3NTZmM2Yx YTgzZCAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxf YXNtLmgKQEAgLTgwLDYgKzgwLDM1IEBACiAgKiAgLSBTUEVDX0NUUkxfRVhJ VF9UT197U1ZNLFZNWH0KICAqLwogCisubWFjcm8gRE9fU1BFQ19DVFJMX0NP TkRfSUJQQiBtYXliZXhlbjpyZXEKKy8qCisgKiBSZXF1aXJlcyAlcnNwPXJl Z3MgKGFsc28gY3B1aW5mbyBpZiAhbWF5YmV4ZW4pCisgKiBSZXF1aXJlcyAl cjE0PXN0YWNrX2VuZCAoaWYgbWF5YmV4ZW4pLCAlcmR4PTAKKyAqIENsb2Ji ZXJzICVyYXgsICVyY3gsICVyZHgKKyAqCisgKiBDb25kaXRpb25hbGx5IGlz c3VlIElCUEIgaWYgU0NGX2VudHJ5X2licGIgaXMgYWN0aXZlLiAgSW4gdGhl IG1heWJleGVuCisgKiBjYXNlLCB3ZSBjYW4gc2FmZWx5IGxvb2sgYXQgVVJF R1NfY3MgdG8gc2tpcCB0YWtpbmcgdGhlIGhpdCB3aGVuCisgKiBpbnRlcnJ1 cHRpbmcgWGVuLgorICovCisgICAgLmlmIFxtYXliZXhlbgorICAgICAgICB0 ZXN0YiAgJFNDRl9lbnRyeV9pYnBiLCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNw ZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICAgICAganogICAgIC5MXEBfc2tp cAorICAgICAgICB0ZXN0YiAgJDMsIFVSRUdTX2NzKCVyc3ApCisgICAgLmVs c2UKKyAgICAgICAgdGVzdGIgICRTQ0ZfZW50cnlfaWJwYiwgQ1BVSU5GT194 ZW5fc3BlY19jdHJsKCVyc3ApCisgICAgLmVuZGlmCisgICAganogICAgIC5M XEBfc2tpcAorCisgICAgbW92ICAgICAkTVNSX1BSRURfQ01ELCAlZWN4Cisg ICAgbW92ICAgICAkUFJFRF9DTURfSUJQQiwgJWVheAorICAgIHdybXNyCisg ICAgam1wICAgICAuTFxAX2RvbmUKKworLkxcQF9za2lwOgorICAgIGxmZW5j ZQorLkxcQF9kb25lOgorLmVuZG0KKwogLm1hY3JvIERPX09WRVJXUklURV9S U0IgdG1wPXJheAogLyoKICAqIFJlcXVpcmVzIG5vdGhpbmcKQEAgLTIzMiwx MiArMjYxLDE2IEBACiAKIC8qIFVzZSBhZnRlciBhbiBlbnRyeSBmcm9tIFBW IGNvbnRleHQgKHN5c2NhbGwvc3lzZW50ZXIvaW50ODAvaW50ODIvZXRjKS4g Ki8KICNkZWZpbmUgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICBBTFRFUk5B VElWRSAiIiwgX19zdHJpbmdpZnkoRE9fU1BFQ19DVFJMX0NPTkRfSUJQQiBt YXliZXhlbj0wKSwgICAgIFwKKyAgICAgICAgWDg2X0ZFQVRVUkVfSUJQQl9F TlRSWV9QVjsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFwKICAgICBBTFRFUk5BVElWRSAiIiwgRE9fT1ZFUldSSVRFX1JTQiwgWDg2 X0ZFQVRVUkVfU0NfUlNCX1BWOyAgICAgICAgICAgIFwKICAgICBBTFRFUk5B VElWRSAiIiwgX19zdHJpbmdpZnkoRE9fU1BFQ19DVFJMX0VOVFJZIG1heWJl eGVuPTApLCAgICAgICAgIFwKICAgICAgICAgWDg2X0ZFQVRVUkVfU0NfTVNS X1BWCiAKIC8qIFVzZSBpbiBpbnRlcnJ1cHQvZXhjZXB0aW9uIGNvbnRleHQu ICBNYXkgaW50ZXJydXB0IFhlbiBvciBQViBjb250ZXh0LiAqLwogI2RlZmlu ZSBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgXAorICAgIEFMVEVSTkFUSVZFICIiLCBf X3N0cmluZ2lmeShET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1heWJleGVuPTEp LCAgICAgXAorICAgICAgICBYODZfRkVBVFVSRV9JQlBCX0VOVFJZX1BWOyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAogICAgIEFM VEVSTkFUSVZFICIiLCBET19PVkVSV1JJVEVfUlNCLCBYODZfRkVBVFVSRV9T Q19SU0JfUFY7ICAgICAgICAgICAgXAogICAgIEFMVEVSTkFUSVZFICIiLCBf X3N0cmluZ2lmeShET19TUEVDX0NUUkxfRU5UUlkgbWF5YmV4ZW49MSksICAg ICAgICAgXAogICAgICAgICBYODZfRkVBVFVSRV9TQ19NU1JfUFYKQEAgLTI2 MSwxMSArMjk0LDIzIEBACiAgKiBSZXF1aXJlcyAlcnNwPXJlZ3MsICVyMTQ9 c3RhY2tfZW5kLCAlcmR4PTAKICAqIENsb2JiZXJzICVyYXgsICVyYngsICVy Y3gsICVyZHgKICAqCi0gKiBUaGlzIGlzIGxvZ2ljYWwgbWVyZ2Ugb2YgRE9f T1ZFUldSSVRFX1JTQiBhbmQgRE9fU1BFQ19DVFJMX0VOVFJZCi0gKiBtYXli ZXhlbj0xLCBidXQgd2l0aCBjb25kaXRpb25hbHMgcmF0aGVyIHRoYW4gYWx0 ZXJuYXRpdmVzLgorICogVGhpcyBpcyBsb2dpY2FsIG1lcmdlIG9mOgorICog ICAgRE9fU1BFQ19DVFJMX0NPTkRfSUJQQiBtYXliZXhlbj0wCisgKiAgICBE T19PVkVSV1JJVEVfUlNCCisgKiAgICBET19TUEVDX0NUUkxfRU5UUlkgbWF5 YmV4ZW49MQorICogYnV0IHdpdGggY29uZGl0aW9uYWxzIHJhdGhlciB0aGFu IGFsdGVybmF0aXZlcy4KICAqLwogICAgIG1vdnpibCBTVEFDS19DUFVJTkZP X0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCksICVlYngKIAorICAgIHRl c3QgICAgJFNDRl9pc3RfaWJwYiwgJWJsCisgICAganogICAgICAuTFxAX3Nr aXBfaWJwYgorCisgICAgbW92ICAgICAkTVNSX1BSRURfQ01ELCAlZWN4Cisg ICAgbW92ICAgICAkUFJFRF9DTURfSUJQQiwgJWVheAorICAgIHdybXNyCisK Ky5MXEBfc2tpcF9pYnBiOgorCiAgICAgdGVzdCAkU0NGX2lzdF9yc2IsICVi bAogICAgIGp6IC5MXEBfc2tpcF9yc2IKIAo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-19.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-19.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2NwdWlkOiBFbnVtZXJhdGlvbiBmb3IgQlRDX05P CgpCVENfTk8gaW5kaWNhdGVzIHRoYXQgaGFyZHdhcmUgaXMgbm90IHN1Y2Nl cHRhYmxlIHRvIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KClplbjMgQ1BVcyBk b24ndCBzdWZmZXIgQlRDLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcuCgpT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2Nw dWlkLmMgYi90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCmluZGV4IDk3N2E0 Mzc3YmYxYi4uMTFiNDM4MDdlOTY1IDEwMDY0NAotLS0gYS90b29scy9saWJ4 bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlk LmMKQEAgLTI3NCw2ICsyNzQsNyBAQCBpbnQgbGlieGxfY3B1aWRfcGFyc2Vf Y29uZmlnKGxpYnhsX2NwdWlkX3BvbGljeV9saXN0ICpjcHVpZCwgY29uc3Qg Y2hhciogc3RyKQogICAgICAgICB7InZpcnQtc3NiZCIsICAgIDB4ODAwMDAw MDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyNSwgIDF9LAogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAorICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAogCiAgICAgICAgIHsibmMiLCAgICAgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQ1gsICAwLCAgOH0sCiAgICAgICAgIHsiYXBpY2lk c2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsIDEyLCAg NH0sCmRpZmYgLS1naXQgYS90b29scy9taXNjL3hlbi1jcHVpZC5jIGIvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYwppbmRleCBmZjE2Nzc3OWRmMzEuLjUyZjUw NTlkOGY3YyAxMDA2NDQKLS0tIGEvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwor KysgYi90b29scy9taXNjL3hlbi1jcHVpZC5jCkBAIC0xNTYsNyArMTU2LDcg QEAgc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl9lOGJbMzJdID0KIAog ICAgIFsyNF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1z c2JkIiwKICAgICBbMjZdID0gInNzYi1ubyIsCi0gICAgWzI4XSA9ICJwc2Zk IiwKKyAgICBbMjhdID0gInBzZmQiLCAgICAgICAgICAgICBbMjldID0gImJ0 Yy1ubyIsCiB9OwogCiBzdGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyXzdk MFszMl0gPQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9hbWQuYyBi L3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKaW5kZXggZDVkZWNlMzdjZGViLi5h MjA0MWU1MTM4YTIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvYW1k LmMKKysrIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpAQCAtNzA3LDYgKzcw NywxNiBAQCBzdGF0aWMgdm9pZCBpbml0X2FtZChzdHJ1Y3QgY3B1aW5mb194 ODYgKmMpCiAJCQl3YXJuaW5nX2FkZCh0ZXh0KTsKIAkJfQogCQlicmVhazsK KworCWNhc2UgMHgxOToKKwkJLyoKKwkJICogWmVuMyAoRmFtMTloIG1vZGVs IDwgMHgxMCkgcGFydHMgYXJlIG5vdCBzdXNjZXB0aWJsZSB0bworCQkgKiBC cmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBwcmVkYXRlIHRoZSBhbGxvY2F0 aW9uIG9mIHRoZQorCQkgKiBCVENfTk8gYml0LiAgRmlsbCBpdCBiYWNrIGlu IGlmIHdlJ3JlIG5vdCB2aXJ0dWFsaXNlZC4KKwkJICovCisJCWlmICghY3B1 X2hhc19oeXBlcnZpc29yICYmICFjcHVfaGFzKGMsIFg4Nl9GRUFUVVJFX0JU Q19OTykpCisJCQlfX3NldF9iaXQoWDg2X0ZFQVRVUkVfQlRDX05PLCBjLT54 ODZfY2FwYWJpbGl0eSk7CisJCWJyZWFrOwogCX0KIAogCWRpc3BsYXlfY2Fj aGVpbmZvKGMpOwpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3Ry bC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCmluZGV4IDQ1MTczMzll YTY2OS4uNGZkYzZlOTNhZGQ0IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKKysrIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBA IC0zODcsNyArMzg3LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2Rl dGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAg ICAgICogSGFyZHdhcmUgcmVhZC1vbmx5IGluZm9ybWF0aW9uLCBzdGF0aW5n IGltbXVuaXR5IHRvIGNlcnRhaW4gaXNzdWVzLCBvcgogICAgICAqIHN1Z2dl c3Rpb25zIG9mIHdoaWNoIG1pdGlnYXRpb24gdG8gdXNlLgogICAgICAqLwot ICAgIHByaW50aygiICBIYXJkd2FyZSBoaW50czolcyVzJXMlcyVzJXMlcyVz JXMlcyVzJXMlcyVzXG4iLAorICAgIHByaW50aygiICBIYXJkd2FyZSBoaW50 czolcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAgICAg ICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAgICAg ICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAgICAg ICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAgICAg ICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAgICAg KGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAgICAg ICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MDIsNyArNDAy LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBp bmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChl OGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNfQUxXQVlTKSkg ICAgPyAiIElCUlNfQUxXQVlTIiAgICA6ICIiLAogICAgICAgICAgICAoZThi ICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9TVElCUF9BTFdBWVMpKSAg ID8gIiBTVElCUF9BTFdBWVMiICAgOiAiIiwKICAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19GQVNUKSkgICAgICA/ ICIgSUJSU19GQVNUIiAgICAgIDogIiIsCi0gICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNfU0FNRV9NT0RFKSkgPyAi IElCUlNfU0FNRV9NT0RFIiA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAgJiBj cHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIg SUJSU19TQU1FX01PREUiIDogIiIsCisgICAgICAgICAgIChlOGIgICYgY3B1 ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJU Q19OTyIgICAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZlYXR1 cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICov CiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMl cyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1 YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IDYwODRlMDU2 OWRlNC4uNDRiM2JhMzMxZmI3IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9pbmNs dWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI1OCw2 ICsyNTgsNyBAQCBYRU5fQ1BVRkVBVFVSRShBTURfU1NCRCwgICAgICA4KjMy KzI0KSAvKiAgIE1TUl9TUEVDX0NUUkwuU1NCRCBhdmFpbGFibGUgKi8KIFhF Tl9DUFVGRUFUVVJFKFZJUlRfU1NCRCwgICAgIDgqMzIrMjUpIC8qICAgTVNS X1ZJUlRfU1BFQ19DVFJMLlNTQkQgKi8KIFhFTl9DUFVGRUFUVVJFKFNTQl9O TywgICAgICAgIDgqMzIrMjYpIC8qICAgSGFyZHdhcmUgbm90IHZ1bG5lcmFi bGUgdG8gU1NCICovCiBYRU5fQ1BVRkVBVFVSRShQU0ZELCAgICAgICAgICA4 KjMyKzI4KSAvKiAgIE1TUl9TUEVDX0NUUkwuUFNGRCAqLworWEVOX0NQVUZF QVRVUkUoQlRDX05PLCAgICAgICAgOCozMisyOSkgLypBICBIYXJkd2FyZSBu b3QgdnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24gKi8KIAog LyogSW50ZWwtZGVmaW5lZCBDUFUgZmVhdHVyZXMsIENQVUlEIGxldmVsIDB4 MDAwMDAwMDc6MC5lZHgsIHdvcmQgOSAqLwogWEVOX0NQVUZFQVRVUkUoQVZY NTEyXzRWTk5JVywgOSozMisgMikgLypBICBBVlg1MTIgTmV1cmFsIE5ldHdv cmsgSW5zdHJ1Y3Rpb25zICovCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-20.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-20.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW5hYmxlIFplbjIgY2hpY2tl bmJpdAoKLi4uIGFzIGluc3RydWN0ZWQgaW4gdGhlIEJyYW5jaCBUeXBlIENv bmZ1c2lvbiB3aGl0ZXBhcGVyLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2FtZC5jCmluZGV4IGEyMDQxZTUx MzhhMi4uZTk1MzBkNTgxYjExIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKQEAgLTU5 MCw2ICs1OTAsMzEgQEAgdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYykKIAkJcHJpbnRrX29uY2UoWEVOTE9HX0VSUiAi Tm8gU1NCRCBjb250cm9scyBhdmFpbGFibGVcbiIpOwogfQogCisvKgorICog T24gWmVuMiB3ZSBvZmZlciB0aGlzIGNoaWNrZW4gKGJpdCkgb24gdGhlIGFs dGFyIG9mIFNwZWN1bGF0aW9uLgorICoKKyAqIFJlZmVyIHRvIHRoZSBBTUQg QnJhbmNoIFR5cGUgQ29uZnVzaW9uIHdoaXRlcGFwZXI6CisgKiBodHRwczov L1hYWAorICoKKyAqIFNldHRpbmcgdGhpcyB1bm5hbWVkIGJpdCBzdXBwb3Nl ZGx5IGNhdXNlcyBwcmVkaWN0aW9uIGluZm9ybWF0aW9uIG9uCisgKiBub24t YnJhbmNoIGluc3RydWN0aW9ucyB0byBiZSBpZ25vcmVkLiAgSXQgaXMgdG8g YmUgc2V0IHVuaWxhdGVyYWxseSBpbgorICogbmV3ZXIgbWljcm9jb2RlLgor ICoKKyAqIFRoaXMgY2hpY2tlbmJpdCBpcyBzb21ldGhpbmcgdW5yZWxhdGVk IG9uIFplbjEsIGFuZCBaZW4xIHZzIFplbjIgaXNuJ3QgYQorICogc2ltcGxl IG1vZGVsIG51bWJlciBjb21wYXJpc29uLCBzbyB1c2UgU1RJQlAgYXMgYSBo ZXVyaXN0aWMgdG8gc2VwYXJhdGUgdGhlCisgKiB0d28gdWFyY2hlcyBpbiBG YW0xN2goQU1EKS8xOGgoSHlnb24pLgorICovCit2b2lkIGFtZF9pbml0X3Nw ZWN0cmFsX2NoaWNrZW4odm9pZCkKK3sKKwl1aW50NjRfdCB2YWwsIGNoaWNr ZW5iaXQgPSAxIDw8IDE7CisKKwlpZiAoY3B1X2hhc19oeXBlcnZpc29yIHx8 ICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkKKwkJcmV0 dXJuOworCisJaWYgKHJkbXNyX3NhZmUoTVNSX0FNRDY0X0RFX0NGRzIsIHZh bCkgPT0gMCAmJiAhKHZhbCAmIGNoaWNrZW5iaXQpKQorCQl3cm1zcl9zYWZl KE1TUl9BTUQ2NF9ERV9DRkcyLCB2YWwgfCBjaGlja2VuYml0KTsKK30KKwog c3RhdGljIHZvaWQgaW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKQog ewogCXUzMiBsLCBoOwpAQCAtNjY4LDYgKzY5Myw5IEBAIHN0YXRpYyB2b2lk IGluaXRfYW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAogCWFtZF9pbml0 X3NzYmQoYyk7CiAKKwlpZiAoYy0+eDg2ID09IDB4MTcpCisJCWFtZF9pbml0 X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwogCS8qIE1GRU5DRSBzdG9wcyBSRFRT QyBzcGVjdWxhdGlvbiAqLwogCWlmICghY3B1X2hhc19sZmVuY2VfZGlzcGF0 Y2gpCiAJCV9fc2V0X2JpdChYODZfRkVBVFVSRV9NRkVOQ0VfUkRUU0MsIGMt Png4Nl9jYXBhYmlsaXR5KTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvY3B1LmggYi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCmluZGV4IDIzY2Nk NjYxMTU2NS4uNjgwYjUxNWIzYzkyIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94 ODYvY3B1L2NwdS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvY3B1LmgKQEAg LTIwLDMgKzIwLDQgQEAgZXh0ZXJuIGJvb2wgZGV0ZWN0X2V4dGVuZGVkX3Rv cG9sb2d5KHN0cnVjdCBjcHVpbmZvX3g4NiAqYyk7CiAKIHZvaWQgZWFybHlf aW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKTsKIHZvaWQgYW1kX2lu aXRfc3NiZChjb25zdCBzdHJ1Y3QgY3B1aW5mb194ODYgKmMpOwordm9pZCBh bWRfaW5pdF9zcGVjdHJhbF9jaGlja2VuKHZvaWQpOwpkaWZmIC0tZ2l0IGEv eGVuL2FyY2gveDg2L2NwdS9oeWdvbi5jIGIveGVuL2FyY2gveDg2L2NwdS9o eWdvbi5jCmluZGV4IGI3NjllOGFkOTA2Mi4uYzUwMDQ4NWRkZTNmIDEwMDY0 NAotLS0gYS94ZW4vYXJjaC94ODYvY3B1L2h5Z29uLmMKKysrIGIveGVuL2Fy Y2gveDg2L2NwdS9oeWdvbi5jCkBAIC02MSw2ICs2MSwxMiBAQCBzdGF0aWMg dm9pZCBpbml0X2h5Z29uKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAogCWFt ZF9pbml0X3NzYmQoYyk7CiAKKwkvKgorCSAqIFRPRE86IENoZWNrIGhldXJp c3RpYyBzYWZldHkgd2l0aCBIeWdvbiBmaXJzdAorCWlmIChjLT54ODYgPT0g MHgxOCkKKwkJYW1kX2luaXRfc3BlY3RyYWxfY2hpY2tlbigpOworCSAqLwor CiAJLyogTUZFTkNFIHN0b3BzIFJEVFNDIHNwZWN1bGF0aW9uICovCiAJaWYg KCFjcHVfaGFzX2xmZW5jZV9kaXNwYXRjaCkKIAkJX19zZXRfYml0KFg4Nl9G RUFUVVJFX01GRU5DRV9SRFRTQywgYy0+eDg2X2NhcGFiaWxpdHkpOwpkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9tc3ItaW5kZXguaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmgKaW5kZXggMjA2NTNiZDY2 MDFlLi43YjhhOWMyOTUxYWEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvbXNyLWluZGV4LmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9t c3ItaW5kZXguaApAQCAtMzExLDYgKzMxMSw3IEBACiAjZGVmaW5lIE1TUl9B TUQ2NF9EQ19DRkcJCTB4YzAwMTEwMjIKICNkZWZpbmUgTVNSX0FNRDY0X0RF X0NGRwkJMHhjMDAxMTAyOQogI2RlZmluZSBBTUQ2NF9ERV9DRkdfTEZFTkNF X1NFUklBTElTRQkoX0FDKDEsIFVMTCkgPDwgMSkKKyNkZWZpbmUgTVNSX0FN RDY0X0RFX0NGRzIJCTB4YzAwMTEwZTMKIAogI2RlZmluZSBNU1JfQU1ENjRf RFIwX0FERFJFU1NfTUFTSwkweGMwMDExMDI3CiAjZGVmaW5lIE1TUl9BTUQ2 NF9EUjFfQUREUkVTU19NQVNLCTB4YzAwMTEwMTkK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.13-21.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.13-21.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQnJhbmNoIFR5 cGUgQ29uZnVzaW9uIHdoZW4gcG9zc2libGUKCkJyYW5jaCBUeXBlIENvbmZ1 c2lvbiBhZmZlY3RzIEFNRC9IeWdvbiBDUFVzIG9uIFplbjIgYW5kIGVhcmxp ZXIuICBUbwptaXRpZ2F0ZSwgd2UgcmVxdWlyZSBTTVQgc2FmZXR5IChTVElC UCBvbiBaZW4yLCBuby1TTVQgb24gWmVuMSksIGFuZCB0byBpc3N1ZQphbiBJ QlBCIG9uIGVhY2ggZW50cnkgdG8gWGVuLCB0byBmbHVzaCB0aGUgQlRCLgoK RHVlIHRvIHBlcmZvcm1hbmNlIGNvbmNlcm5zLCBkb20wICh3aGljaCBpcyB0 cnVzdGVkIGluIG1vc3QgY29uZmlndXJhdGlvbnMpIGlzCmV4Y2x1ZGVkIGZy b20gcHJvdGVjdGlvbnMgYnkgZGVmYXVsdC4KClRoZXJlZm9yZToKICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgb24gWmVuMiB0b28sIHdoaWNoIG5vdyBtZWFu cyB3ZSB3YW50IGl0IG9uIGJ5IGRlZmF1bHQKICAgb24gYWxsIGhhcmR3YXJl IHN1cHBvcnRpbmcgU1RJQlAuCiAqIEJyZWFrIHRoZSBjdXJyZW50IElCUEIg bG9naWMgb3V0IGludG8gYSBuZXcgZnVuY3Rpb24sIGV4dGVuZGluZyBpdCB3 aXRoCiAgIElCUEItYXQtZW50cnkgbG9naWMuCiAqIENoYW5nZSB0aGUgZXhp c3RpbmcgSUJQQi1hdC1jdHh0LXN3aXRjaCBib29sZWFuIHRvIGJlIHRyaXN0 YXRlLCBhbmQgZGlzYWJsZQogICBpdCBieSBkZWZhdWx0IHdoZW4gSUJQQi1h dC1lbnRyeSBpcyBwcm92aWRpbmcgc3VmZmljaWVudCBzYWZldHkuCgpJZiBh bGwgUFYgZ3Vlc3RzIG9uIHRoZSBzeXN0ZW0gYXJlIHRydXN0ZWQsIHRoZW4g aXQgaXMgcmVjb21tZW5kZWQgdG8gYm9vdAp3aXRoIGBzcGVjLWN0cmw9aWJw Yi1lbnRyeT1uby1wdmAsIGFzIHRoaXMgd2lsbCBwcm92aWRlIGFuIGFkZGl0 aW9uYWwgbWFyZ2luYWwKcGVyZiBpbXByb3ZlbWVudC4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDA3IC8gQ1ZFLTIwMjItMjM4MjUuCgpTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoK ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRv YyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYwppbmRleCAz NTk4NTliNTE4MDguLjk1NmVjZDVhMzU5MSAxMDA2NDQKLS0tIGEvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCisrKyBiL2RvY3MvbWlzYy94 ZW4tY29tbWFuZC1saW5lLnBhbmRvYwpAQCAtMjAzNCw3ICsyMDM0LDcgQEAg QnkgZGVmYXVsdCBTU0JEIHdpbGwgYmUgbWl0aWdhdGVkIGF0IHJ1bnRpbWUg KGkuZSBgc3NiZD1ydW50aW1lYCkuCiAKICMjIyBzcGVjLWN0cmwgKHg4NikK ID4gYD0gTGlzdCBvZiBbIDxib29sPiwgeGVuPTxib29sPiwge3B2LGh2bX09 PGJvb2w+LAotPiAgICAgICAgICAgICAge21zci1zYyxyc2IsbWQtY2xlYXJ9 PTxib29sPnx7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAgICAgICB7bXNy LXNjLHJzYixtZC1jbGVhcixpYnBiLWVudHJ5fT08Ym9vbD58e3B2LGh2bX09 PGJvb2w+LAogPiAgICAgICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxs ZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQscHNmZCwKID4gICAgICAgICAg ICAgIGVhZ2VyLWZwdSxsMWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9j aywKID4gICAgICAgICAgICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKQEAg LTIwNTksOSArMjA1OSwxMCBAQCBpbiBwbGFjZSBmb3IgZ3Vlc3RzIHRvIHVz ZS4KIAogVXNlIG9mIGEgcG9zaXRpdmUgYm9vbGVhbiB2YWx1ZSBmb3IgZWl0 aGVyIG9mIHRoZXNlIG9wdGlvbnMgaXMgaW52YWxpZC4KIAotVGhlIGBwdj1g LCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gIGFuZCBgbWQtY2xlYXI9YCBv cHRpb25zIG9mZmVyIGZpbmUKLWdyYWluZWQgY29udHJvbCBvdmVyIHRoZSBw cmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGltcGFjdCBYZW4ncyBhYmlsaXR5 IHRvCi1wcm90ZWN0IGl0c2VsZiwgYW5kL29yIFhlbidzIGFiaWxpdHkgdG8g dmlydHVhbGlzZSBzdXBwb3J0IGZvciBndWVzdHMgdG8gdXNlLgorVGhlIGBw dj1gLCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gLCBgbWQtY2xlYXI9YCBh bmQgYGlicGItZW50cnk9YCBvcHRpb25zCitvZmZlciBmaW5lIGdyYWluZWQg Y29udHJvbCBvdmVyIHRoZSBwcmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGlt cGFjdCBYZW4ncworYWJpbGl0eSB0byBwcm90ZWN0IGl0c2VsZiwgYW5kL29y IFhlbidzIGFiaWxpdHkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgorZ3Vl c3RzIHRvIHVzZS4KIAogKiBgcHY9YCBhbmQgYGh2bT1gIG9mZmVyIGNvbnRy b2wgb3ZlciBhbGwgc3Vib3B0aW9ucyBmb3IgUFYgYW5kIEhWTSBndWVzdHMK ICAgcmVzcGVjdGl2ZWx5LgpAQCAtMjA4MCw2ICsyMDgxLDExIEBAIHByb3Rl Y3QgaXRzZWxmLCBhbmQvb3IgWGVuJ3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNl IHN1cHBvcnQgZm9yIGd1ZXN0cyB0byB1c2UuCiAgIGNvbXBhdGliaWxpdHkg d2l0aCBkZXZlbG9wbWVudCB2ZXJzaW9ucyBvZiB0aGlzIGZpeCwgYG1kcz1g IGlzIGFsc28gYWNjZXB0ZWQKICAgb24gWGVuIDQuMTIgYW5kIGVhcmxpZXIg YXMgYW4gYWxpYXMuICBDb25zdWx0IHZlbmRvciBkb2N1bWVudGF0aW9uIGlu CiAgIHByZWZlcmVuY2UgdG8gaGVyZS4qCisqIGBpYnBiLWVudHJ5PWAgb2Zm ZXJzIGNvbnRyb2wgb3ZlciB3aGV0aGVyIElCUEIgKEluZGlyZWN0IEJyYW5j aCBQcmVkaWN0aW9uCisgIEJhcnJpZXIpIGlzIHVzZWQgb24gZW50cnkgdG8g WGVuLiAgVGhpcyBpcyB1c2VkIGJ5IGRlZmF1bHQgb24gaGFyZHdhcmUKKyAg dnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucywgZG9tMCBpcworICB1bnByb3RlY3RlZCBi eSBkZWZhdWx0LiAgSWYgaXQgbmVjZXNzYXJ5IHRvIHByb3RlY3QgZG9tMCB0 b28sIGJvb3Qgd2l0aAorICBgc3BlYy1jdHJsPWlicGItZW50cnlgLgogCiBJ ZiBYZW4gd2FzIGNvbXBpbGVkIHdpdGggSU5ESVJFQ1RfVEhVTksgc3VwcG9y dCwgYGJ0aS10aHVuaz1gIGNhbiBiZSB1c2VkIHRvCiBzZWxlY3Qgd2hpY2gg b2YgdGhlIHRodW5rcyBnZXRzIHBhdGNoZWQgaW50byB0aGUgYF9feDg2X2lu ZGlyZWN0X3RodW5rXyVyZWdgCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXgg NGZkYzZlOTNhZGQ0Li5iZmE1ZDI3ZTAwZjUgMTAwNjQ0Ci0tLSBhL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKQEAgLTM5LDYgKzM5LDEwIEBAIHN0YXRpYyBib29sIF9faW5pdGRh dGEgb3B0X3JzYl9odm0gPSB0cnVlOwogc3RhdGljIGludDhfdCBfX3JlYWRf bW9zdGx5IG9wdF9tZF9jbGVhcl9wdiA9IC0xOwogc3RhdGljIGludDhfdCBf X3JlYWRfbW9zdGx5IG9wdF9tZF9jbGVhcl9odm0gPSAtMTsKIAorc3RhdGlj IGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBiX2VudHJ5X3B2ID0gLTE7 CitzdGF0aWMgaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJfZW50cnlf aHZtID0gLTE7CitzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBi X2VudHJ5X2RvbTA7CisKIC8qIENtZGxpbmUgY29udHJvbHMgZm9yIFhlbidz IHNwZWN1bGF0aXZlIHNldHRpbmdzLiAqLwogc3RhdGljIGVudW0gaW5kX3Ro dW5rIHsKICAgICBUSFVOS19ERUZBVUxULCAvKiBEZWNpZGUgd2hpY2ggdGh1 bmsgdG8gdXNlIGF0IGJvb3QgdGltZS4gKi8KQEAgLTU0LDcgKzU4LDcgQEAg aW50OF90IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7CiBib29sIF9fcmVh ZF9tb3N0bHkgb3B0X3NzYmQ7CiBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfcHNm ZCA9IC0xOwogCi1ib29sIF9fcmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9z d2l0Y2ggPSB0cnVlOworaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJf Y3R4dF9zd2l0Y2ggPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9l YWdlcl9mcHUgPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9sMWRf Zmx1c2ggPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBvcHRfYnJhbmNoX2hh cmRlbiA9IHRydWU7CkBAIC0xMTUsNiArMTE5LDkgQEAgc3RhdGljIGludCBf X2luaXQgcGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAg ICAgICBvcHRfcnNiX2h2bSA9IGZhbHNlOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX3B2ID0gMDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0g PSAwOworICAgICAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAwOworICAg ICAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gMDsKKyAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKIAogICAgICAgICAgICAg b3B0X3RodW5rID0gVEhVTktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMg PSAwOwpAQCAtMTQxLDEyICsxNDgsMTQgQEAgc3RhdGljIGludCBfX2luaXQg cGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAgICAgICBv cHRfbXNyX3NjX3B2ID0gdmFsOwogICAgICAgICAgICAgb3B0X3JzYl9wdiA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9wdiA9IHZhbDsKKyAg ICAgICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gdmFsOwogICAgICAgICB9 CiAgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaHZt Iiwgcywgc3MpKSA+PSAwICkKICAgICAgICAgewogICAgICAgICAgICAgb3B0 X21zcl9zY19odm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfcnNiX2h2bSA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0gPSB2YWw7Cisg ICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9odm0gPSB2YWw7CiAgICAgICAg IH0KICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJt c3Itc2MiLCBzLCBzcykpICE9IC0xICkKICAgICAgICAgewpAQCAtMjExLDYg KzIyMCwyOCBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQorICAgICAgICBlbHNlIGlmICggKHZhbCA9 IHBhcnNlX2Jvb2xlYW4oImlicGItZW50cnkiLCBzLCBzcykpICE9IC0xICkK KyAgICAgICAgeworICAgICAgICAgICAgc3dpdGNoICggdmFsICkKKyAgICAg ICAgICAgIHsKKyAgICAgICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAgIGNh c2UgMToKKyAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IG9w dF9pYnBiX2VudHJ5X2h2bSA9CisgICAgICAgICAgICAgICAgICAgIG9wdF9p YnBiX2VudHJ5X2RvbTAgPSB2YWw7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisKKyAgICAgICAgICAgIGNhc2UgLTI6CisgICAgICAgICAgICAgICAgcyAr PSBzdHJsZW4oImlicGItZW50cnk9Iik7CisgICAgICAgICAgICAgICAgaWYg KCAodmFsID0gcGFyc2VfYm9vbGVhbigicHYiLCBzLCBzcykpID49IDAgKQor ICAgICAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IHZhbDsK KyAgICAgICAgICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImh2bSIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAg ICByYyA9IC1FSU5WQUw7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB9CisgICAgICAgIH0KIAogICAgICAgICAvKiBYZW4ncyBzcGVj dWxhdGl2ZSBzaWRlY2hhbm5lbCBtaXRpZ2F0aW9uIHNldHRpbmdzLiAqLwog ICAgICAgICBlbHNlIGlmICggIXN0cm5jbXAocywgImJ0aS10aHVuaz0iLCAx MCkgKQpAQCAtNDc0LDI3ICs1MDUsMzEgQEAgc3RhdGljIHZvaWQgX19pbml0 IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90 IGNhcHMpCiAgICAgICogbWl0aWdhdGlvbiBzdXBwb3J0IGZvciBndWVzdHMu CiAgICAgICovCiAjaWZkZWYgQ09ORklHX0hWTQotICAgIHByaW50aygiICBT dXBwb3J0IGZvciBIVk0gVk1zOiVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRr KCIgIFN1cHBvcnQgZm9yIEhWTSBWTXM6JXMlcyVzJXMlcyVzXG4iLAogICAg ICAgICAgICAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9IVk0p IHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0Nf UlNCX0hWTSkgfHwKICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVB VFVSRV9NRF9DTEVBUikgICB8fAorICAgICAgICAgICAgYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfSFZNKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTSkgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9IVk0pICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICNlbmRpZgogI2lmZGVmIENPTkZJR19QVgotICAgIHByaW50 aygiICBTdXBwb3J0IGZvciBQViBWTXM6JXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgU3VwcG9ydCBmb3IgUFYgVk1zOiVzJXMlcyVzJXMlc1xuIiwK ICAgICAgICAgICAgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19NU1Jf UFYpIHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVf U0NfUlNCX1BWKSB8fAogICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX01EX0NMRUFSKSAgfHwKKyAgICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9JQlBCX0VOVFJZX1BWKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX1BWKSAgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9QVikgICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9QVikgICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICAgICBwcmludGsoIiAgWFBUSSAoNjQtYml0IFBWIG9ubHkp OiBEb20wICVzLCBEb21VICVzICh3aXRoJXMgUENJRClcbiIsCiAgICAgICAg ICAgIG9wdF94cHRpX2h3ZG9tID8gImVuYWJsZWQiIDogImRpc2FibGVkIiwK QEAgLTcyNyw2ICs3NjIsNTUgQEAgc3RhdGljIGJvb2wgX19pbml0IHNob3Vs ZF91c2VfZWFnZXJfZnB1KHZvaWQpCiAgICAgfQogfQogCitzdGF0aWMgdm9p ZCBfX2luaXQgaWJwYl9jYWxjdWxhdGlvbnModm9pZCkKK3sKKyAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KKyAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQorICAgIHsKKyAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gb3B0X2li cGJfZW50cnlfcHYgPSBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9IDA7CisgICAg ICAgIG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworICAgIC8qCisgICAgICogSUJQQi1vbi1lbnRyeSBt aXRpZ2F0aW9ucyBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgorICAgICAq CisgICAgICogSUJQQiAmJiAhQlRDX05PIHNlbGVjdHMgYWxsIEFNRC9IeWdv biBoYXJkd2FyZSwgbm90IGtub3duIHRvIGJlIHNhZmUsCisgICAgICogdGhh dCB3ZSBjYW4gcHJvdmlkZSBzb21lIGZvcm0gb2YgbWl0aWdhdGlvbiBvbi4K KyAgICAgKi8KKyAgICBpZiAoIG9wdF9pYnBiX2VudHJ5X3B2ID09IC0xICkK KyAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAoSVNfRU5BQkxFRChDT05G SUdfUFYpICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0JUQ19O TykpOworICAgIGlmICggb3B0X2licGJfZW50cnlfaHZtID09IC0xICkKKyAg ICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gKElTX0VOQUJMRUQoQ09ORklH X0hWTSkgJiYKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9CVENf Tk8pKTsKKworICAgIGlmICggb3B0X2licGJfZW50cnlfcHYgKQorICAgIHsK KyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9JQlBC X0VOVFJZX1BWKTsKKworICAgICAgICAvKgorICAgICAgICAgKiBXZSBvbmx5 IG5lZWQgdG8gZmx1c2ggaW4gSVNUIGNvbnRleHQgaWYgd2UncmUgcHJvdGVj dGluZyBhZ2FpbnN0IFBWCisgICAgICAgICAqIGd1ZXN0cy4gIEhWTSBJQlBC LW9uLWVudHJ5IHByb3RlY3Rpb25zIGFyZSBib3RoIGF0b21pYyB3aXRoCisg ICAgICAgICAqIE5NSS8jTUMsIHNvIGNhbid0IGludGVycnVwdCBYZW4gYWhl YWQgb2YgaGF2aW5nIGFscmVhZHkgZmx1c2hlZCB0aGUKKyAgICAgICAgICog QlRCLgorICAgICAgICAgKi8KKyAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxf ZmxhZ3MgfD0gU0NGX2lzdF9pYnBiOworICAgIH0KKyAgICBpZiAoIG9wdF9p YnBiX2VudHJ5X2h2bSApCisgICAgICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAo WDg2X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pOworCisgICAgLyoKKyAgICAg KiBJZiB3ZSdyZSB1c2luZyBJQlBCLW9uLWVudHJ5IHRvIHByb3RlY3QgYWdh aW5zdCBQViBhbmQgSFZNIGd1ZXN0cworICAgICAqIChpZ25vcmluZyBkb20w IGlmIHRydXN0ZWQpLCB0aGVuIHRoZXJlJ3Mgbm8gbmVlZCB0byBhbHNvIGlz c3VlIElCUEIgb24KKyAgICAgKiBjb250ZXh0IHN3aXRjaCB0b28uCisgICAg ICovCisgICAgaWYgKCBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9PSAtMSApCisg ICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gIShvcHRfaWJwYl9lbnRy eV9odm0gJiYgb3B0X2licGJfZW50cnlfcHYpOworfQorCiAvKiBDYWxjdWxh dGUgd2hldGhlciB0aGlzIENQVSBpcyB2dWxuZXJhYmxlIHRvIEwxVEYuICov CiBzdGF0aWMgX19pbml0IHZvaWQgbDF0Zl9jYWxjdWxhdGlvbnModWludDY0 X3QgY2FwcykKIHsKQEAgLTk4Miw4ICsxMDY2LDEyIEBAIHZvaWQgc3BlY19j dHJsX2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpCiAgICAgYm9vbCB2 ZXJ3ID0gKChwdiA/IG9wdF9tZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9o dm0pIHx8CiAgICAgICAgICAgICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAm JiBpc19pb21tdV9lbmFibGVkKGQpKSk7CiAKKyAgICBib29sIGlicGIgPSAo KHB2ID8gb3B0X2licGJfZW50cnlfcHYgOiBvcHRfaWJwYl9lbnRyeV9odm0p ICYmCisgICAgICAgICAgICAgICAgIChkLT5kb21haW5faWQgIT0gMCB8fCBv cHRfaWJwYl9lbnRyeV9kb20wKSk7CisKICAgICBkLT5hcmNoLnNwZWNfY3Ry bF9mbGFncyA9CiAgICAgICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAgICAg IDogMCkgfAorICAgICAgICAoaWJwYiAgID8gU0NGX2VudHJ5X2licGIgICA6 IDApIHwKICAgICAgICAgMDsKIH0KIApAQCAtMTExMSwxMiArMTE5OSwxNSBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgfQogCiAgICAgLyoKLSAgICAgKiBVc2UgU1RJQlAgYnkgZGVm YXVsdCBpZiB0aGUgaGFyZHdhcmUgaGludCBpcyBzZXQuICBPdGhlcndpc2Us IGxlYXZlIGl0Ci0gICAgICogb2ZmIGFzIGl0IGEgc2V2ZXJlIHBlcmZvcm1h bmNlIHBlbnRhbHR5IG9uIHByZS1lSUJSUyBJbnRlbCBoYXJkd2FyZQotICAg ICAqIHdoZXJlIGl0IHdhcyByZXRyb2ZpdHRlZCBpbiBtaWNyb2NvZGUuCisg ICAgICogVXNlIFNUSUJQIGJ5IGRlZmF1bHQgb24gYWxsIEFNRCBzeXN0ZW1z LiAgWmVuMyBhbmQgbGF0ZXIgZW51bWVyYXRlCisgICAgICogU1RJQlBfQUxX QVlTLCBidXQgU1RJQlAgaXMgbmVlZGVkIG9uIFplbjIgYXMgcGFydCBvZiB0 aGUgbWl0aWdhdGlvbnMKKyAgICAgKiBmb3IgQnJhbmNoIFR5cGUgQ29uZnVz aW9uLgorICAgICAqCisgICAgICogTGVhdmUgU1RJQlAgb2ZmIGJ5IGRlZmF1 bHQgb24gSW50ZWwuICBQcmUtZUlCUlMgc3lzdGVtcyBzdWZmZXIgYQorICAg ICAqIHN1YnN0YW50aWFsIHBlcmYgaGl0IHdoZW4gaXQgd2FzIGltcGxlbWVu dGVkIGluIG1pY3JvY29kZS4KICAgICAgKi8KICAgICBpZiAoIG9wdF9zdGli cCA9PSAtMSApCi0gICAgICAgIG9wdF9zdGlicCA9ICEhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUyk7CisgICAgICAgIG9wdF9zdGli cCA9ICEhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0FNRF9TVElCUCk7CiAK ICAgICBpZiAoIG9wdF9zdGlicCAmJiAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX1NUSUJQKSB8fAogICAgICAgICAgICAgICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkgKQpAQCAtMTE2OSw5ICsx MjYwLDcgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQogICAgIGlmICggb3B0X3JzYl9odm0gKQogICAgICAgICBz ZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0pOwog Ci0gICAgLyogQ2hlY2sgd2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQg YmVmb3JlIHVzaW5nIGl0Li4uICovCi0gICAgaWYgKCAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX0lCUEIpICkKLSAgICAgICAgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSBm YWxzZTsKKyAgICBpYnBiX2NhbGN1bGF0aW9ucygpOwogCiAgICAgLyogQ2hl Y2sgd2hldGhlciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVm YXVsdC4gKi8KICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggOGI2OWE4MTkx NzVhLi4yZjE1YWU5ODE0OTUgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9z cGVjX2N0cmwuaApAQCAtNjUsNyArNjUsNyBAQAogdm9pZCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5p dF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9w dF9pYnBiX2N0eHRfc3dpdGNoOworZXh0ZXJuIGludDhfdCBvcHRfaWJwYl9j dHh0X3N3aXRjaDsKIGV4dGVybiBib29sIG9wdF9zc2JkOwogZXh0ZXJuIGlu dDhfdCBvcHRfZWFnZXJfZnB1OwogZXh0ZXJuIGludDhfdCBvcHRfbDFkX2Zs dXNoOwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-01.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-01.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogT25seSBhZGp1c3QgTVNSX1NQ RUNfQ1RSTCBmb3IgaWRsZSB3aXRoIGxlZ2FjeSBJQlJTCgpCYWNrIGF0IHRo ZSB0aW1lIG9mIHRoZSBvcmlnaW5hbCBTcGVjdHJlLXYyIGZpeGVzLCBpdCB3 YXMgcmVjb21tZW5kZWQgdG8gY2xlYXIKTVNSX1NQRUNfQ1RSTCB3aGVuIGdv aW5nIGlkbGUuICBUaGlzIGlzIGJlY2F1c2Ugb2YgdGhlIHNpZGUgZWZmZWN0 cyBvbiB0aGUKc2libGluZyB0aHJlYWQgY2F1c2VkIGJ5IHRoZSBtaWNyb2Nv ZGUgSUJSUyBhbmQgU1RJQlAgaW1wbGVtZW50YXRpb25zIHdoaWNoCndlcmUg cmV0cm9maXR0ZWQgdG8gZXhpc3RpbmcgQ1BVcy4KCkhvd2V2ZXIsIHRoZXJl IGFyZSBubyByZWxldmFudCBjcm9zcy10aHJlYWQgaW1wYWN0cyBmb3IgdGhl IGhhcmR3YXJlCklCUlMvU1RJQlAgaW1wbGVtZW50YXRpb25zLCBzbyB0aGlz IGxvZ2ljIHNob3VsZCBub3QgYmUgdXNlZCBvbiBJbnRlbCBDUFVzCnN1cHBv cnRpbmcgZUlCUlMsIG9yIGFueSBBTUQgQ1BVczsgZG9pbmcgc28gb25seSBh ZGRzIHVubmVjZXNzYXJ5IGxhdGVuY3kgdG8KdGhlIGlkbGUgcGF0aC4KCkZ1 cnRoZXJtb3JlLCB0aGVyZSdzIG5vIHBvaW50IHBsYXlpbmcgd2l0aCBNU1Jf U1BFQ19DVFJMIGluIHRoZSBpZGxlIHBhdGhzIGlmClNNVCBpcyBkaXNhYmxl ZCBmb3Igb3RoZXIgcmVhc29ucy4KCkZpeGVzOiA4ZDAzMDgwZDJhMzMgKCJ4 ODYvc3BlYy1jdHJsOiBDZWFzZSB1c2luZyB0aHVuaz1sZmVuY2Ugb24gQU1E IikKU2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3Bl cjNAY2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IFJvZ2VyIFBhdSBNb25uw6kg PHJvZ2VyLnBhdUBjaXRyaXguY29tPgooY2hlcnJ5IHBpY2tlZCBmcm9tIGNv bW1pdCBmZmM3Njk0ZTBjOTllZWExNThjMzJhYTE2NGI3ZDFlMWJiMWRjNDZi KQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCA1OGEyNzk3ZGZlYTEuLmQ3 Zjc2N2IwNzM5YyAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3Ry bC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtMTEwNCw4 ICsxMTA0LDE0IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0 aWdhdGlvbnModm9pZCkKICAgICAvKiAoUmUpaW5pdCBCU1Agc3RhdGUgbm93 IHRoYXQgZGVmYXVsdF9zcGVjX2N0cmxfZmxhZ3MgaGFzIGJlZW4gY2FsY3Vs YXRlZC4gKi8KICAgICBpbml0X3NoYWRvd19zcGVjX2N0cmxfc3RhdGUoKTsK IAotICAgIC8qIElmIFhlbiBpcyB1c2luZyBhbnkgTVNSX1NQRUNfQ1RSTCBz ZXR0aW5ncywgYWRqdXN0IHRoZSBpZGxlIHBhdGguICovCi0gICAgaWYgKCBk ZWZhdWx0X3hlbl9zcGVjX2N0cmwgKQorICAgIC8qCisgICAgICogRm9yIG1p Y3JvY29kZWQgSUJSUyBvbmx5IChpLmUuIEludGVsLCBwcmUgZUlCUlMpLCBp dCBpcyByZWNvbW1lbmRlZCB0bworICAgICAqIGNsZWFyIE1TUl9TUEVDX0NU UkwgYmVmb3JlIGdvaW5nIGlkbGUsIHRvIGF2b2lkIGltcGFjdGluZyBzaWJs aW5nCisgICAgICogdGhyZWFkcy4gIEFjdGl2YXRlIHRoaXMgaWYgU01UIGlz IGVuYWJsZWQsIGFuZCBYZW4gaXMgdXNpbmcgYSBub24temVybworICAgICAq IE1TUl9TUEVDX0NUUkwgc2V0dGluZy4KKyAgICAgKi8KKyAgICBpZiAoIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikgJiYgIShjYXBzICYgQVJD SF9DQVBTX0lCUlNfQUxMKSAmJgorICAgICAgICAgaHdfc210X2VuYWJsZWQg JiYgZGVmYXVsdF94ZW5fc3BlY19jdHJsICkKICAgICAgICAgc2V0dXBfZm9y Y2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19NU1JfSURMRSk7CiAKICAgICB4 cHRpX2luaXRfZGVmYXVsdChjYXBzKTsKZGlmZiAtLWdpdCBhL3hlbi9pbmNs dWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaCBiL3hlbi9pbmNsdWRlL2FzbS14 ODYvY3B1ZmVhdHVyZXMuaAppbmRleCA5ZWFhYjdhMmExZmEuLmY3NDg4ZDNj Y2JmYSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0 dXJlcy5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMu aApAQCAtMzMsNyArMzMsNyBAQCBYRU5fQ1BVRkVBVFVSRShTQ19NU1JfSFZN LCAgICAgICAgWDg2X1NZTlRIKDE3KSkgLyogTVNSX1NQRUNfQ1RSTCB1c2Vk IGJ5IFhlbiBmbwogWEVOX0NQVUZFQVRVUkUoU0NfUlNCX1BWLCAgICAgICAg IFg4Nl9TWU5USCgxOCkpIC8qIFJTQiBvdmVyd3JpdGUgbmVlZGVkIGZvciBQ ViAqLwogWEVOX0NQVUZFQVRVUkUoU0NfUlNCX0hWTSwgICAgICAgIFg4Nl9T WU5USCgxOSkpIC8qIFJTQiBvdmVyd3JpdGUgbmVlZGVkIGZvciBIVk0gKi8K IFhFTl9DUFVGRUFUVVJFKFhFTl9TRUxGU05PT1AsICAgICBYODZfU1lOVEgo MjApKSAvKiBTRUxGU05PT1AgZ2V0cyB1c2VkIGJ5IFhlbiBpdHNlbGYgKi8K LVhFTl9DUFVGRUFUVVJFKFNDX01TUl9JRExFLCAgICAgICBYODZfU1lOVEgo MjEpKSAvKiAoU0NfTVNSX1BWIHx8IFNDX01TUl9IVk0pICYmIGRlZmF1bHRf eGVuX3NwZWNfY3RybCAqLworWEVOX0NQVUZFQVRVUkUoU0NfTVNSX0lETEUs ICAgICAgIFg4Nl9TWU5USCgyMSkpIC8qIENsZWFyIE1TUl9TUEVDX0NUUkwg b24gaWRsZSAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX0xCUiwgICAgICAgICAg IFg4Nl9TWU5USCgyMikpIC8qIFhlbiB1c2VzIE1TUl9ERUJVR0NUTC5MQlIg Ki8KIC8qIEJpdHMgMjMsMjQgdW51c2VkLiAqLwogWEVOX0NQVUZFQVRVUkUo U0NfVkVSV19JRExFLCAgICAgIFg4Nl9TWU5USCgyNSkpIC8qIFZFUlcgdXNl ZCBieSBYZW4gZm9yIGlkbGUgKi8KZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybC5oCmluZGV4IDY4ZjZjNDZjNDcwYy4uMTIyODM1NzNjZGQ1IDEw MDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oCisr KyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKQEAgLTc4LDcg Kzc4LDggQEAgc3RhdGljIGFsd2F5c19pbmxpbmUgdm9pZCBzcGVjX2N0cmxf ZW50ZXJfaWRsZShzdHJ1Y3QgY3B1X2luZm8gKmluZm8pCiAgICAgdWludDMy X3QgdmFsID0gMDsKIAogICAgIC8qCi0gICAgICogQnJhbmNoIFRhcmdldCBJ bmplY3Rpb246CisgICAgICogSXQgaXMgcmVjb21tZW5kZWQgaW4gc29tZSBj YXNlcyB0byBjbGVhciBNU1JfU1BFQ19DVFJMIHdoZW4gZ29pbmcgaWRsZSwK KyAgICAgKiB0byBhdm9pZCBpbXBhY3Rpbmcgc2libGluZyB0aHJlYWRzLgog ICAgICAqCiAgICAgICogTGF0Y2ggdGhlIG5ldyBzaGFkb3cgdmFsdWUsIHRo ZW4gZW5hYmxlIHNoYWRvd2luZywgdGhlbiB1cGRhdGUgdGhlIE1TUi4KICAg ICAgKiBUaGVyZSBhcmUgbm8gU01QIGlzc3VlcyBoZXJlOyBvbmx5IGxvY2Fs IHByb2Nlc3NvciBvcmRlcmluZyBjb25jZXJucy4KQEAgLTExNCw3ICsxMTUs NyBAQCBzdGF0aWMgYWx3YXlzX2lubGluZSB2b2lkIHNwZWNfY3RybF9leGl0 X2lkbGUoc3RydWN0IGNwdV9pbmZvICppbmZvKQogICAgIHVpbnQzMl90IHZh bCA9IGluZm8tPnhlbl9zcGVjX2N0cmw7CiAKICAgICAvKgotICAgICAqIEJy YW5jaCBUYXJnZXQgSW5qZWN0aW9uOgorICAgICAqIFJlc3RvcmUgTVNSX1NQ RUNfQ1RSTCBvbiBleGl0IGZyb20gaWRsZS4KICAgICAgKgogICAgICAqIERp c2FibGUgc2hhZG93aW5nIGJlZm9yZSB1cGRhdGluZyB0aGUgTVNSLiAgVGhl cmUgYXJlIG5vIFNNUCBpc3N1ZXMKICAgICAgKiBoZXJlOyBvbmx5IGxvY2Fs IHByb2Nlc3NvciBvcmRlcmluZyBjb25jZXJucy4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-02.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-02.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogS25vYnMgZm9yIFNUSUJQIGFu ZCBQU0ZELCBhbmQgZm9sbG93IGhhcmR3YXJlIFNUSUJQCiBoaW50CgpTVElC UCBhbmQgUFNGRCBhcmUgc2xpZ2h0bHkgd2VpcmQgYml0cywgYmVjYXVzZSB0 aGV5J3JlIGJvdGggaW1wbGllZCBieSBvdGhlcgpiaXRzIGluIE1TUl9TUEVD X0NUUkwuICBBZGQgZmluZSBncmFpbiBjb250cm9scyBmb3IgdGhlbSwgYW5k IHRha2UgdGhlCmltcGxpY2F0aW9ucyBpbnRvIGFjY291bnQgd2hlbiBzZXR0 aW5nIElCUlMvU1NCRC4KClJlYXJyYW5nZSB0aGUgSUJQQiB0ZXh0L3Zhcmlh Ymxlcy9sb2dpYyB0byBrZWVwIGFsbCB0aGUgTVNSX1NQRUNfQ1RSTCBiaXRz CnRvZ2V0aGVyLCBmb3IgY29uc2lzdGVuY3kuCgpIb3dldmVyLCBBTUQgaGF2 ZSBhIGhhcmR3YXJlIGhpbnQgQ1BVSUQgYml0IHJlY29tbWVuZGluZyB0aGF0 IFNUSUJQIGJlIHNldAp1bmlsYXRlcmFsbHkuICBUaGlzIGlzIGFkdmVydGlz ZWQgb24gWmVuMywgc28gZm9sbG93IHRoZSByZWNvbW1lbmRhdGlvbi4KRnVy dGhlcm1vcmUsIGluIHN1Y2ggY2FzZXMsIHNldCBTVElCUCBiZWhpbmQgdGhl IGd1ZXN0J3MgYmFjayBmb3Igbm93LiAgVGhpcwpoYXMgbmVnbGlnaWJsZSBv dmVyaGVhZCBmb3IgdGhlIGd1ZXN0LCBidXQgc2F2ZXMgYSBXUk1TUiBvbiB2 bWVudHJ5LiAgVGhpcyBpcwp0aGUgb25seSBkZWZhdWx0IGNoYW5nZS4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+ClJldmlld2VkLWJ5OiBSb2dlciBQYXUgTW9ubsOpIDxyb2dl ci5wYXVAY2l0cml4LmNvbT4KKGNoZXJyeSBwaWNrZWQgZnJvbSBjb21taXQg ZmVmMjQ0YjE3OWMwNmZjZGZhNTgxZjdkNTdmYTZlNTc4YzQ5ZmY1MCkKCmRp ZmYgLS1naXQgYS9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2Mg Yi9kb2NzL21pc2MveGVuLWNvbW1hbmQtbGluZS5wYW5kb2MKaW5kZXggZDFk NTg1MmNkZDg0Li4yMzAyY2VjOTFmZWEgMTAwNjQ0Ci0tLSBhL2RvY3MvbWlz Yy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYworKysgYi9kb2NzL21pc2MveGVu LWNvbW1hbmQtbGluZS5wYW5kb2MKQEAgLTIxMDUsOCArMjEwNSw5IEBAIEJ5 IGRlZmF1bHQgU1NCRCB3aWxsIGJlIG1pdGlnYXRlZCBhdCBydW50aW1lIChp LmUgYHNzYmQ9cnVudGltZWApLgogCiAjIyMgc3BlYy1jdHJsICh4ODYpCiA+ IGA9IExpc3Qgb2YgWyA8Ym9vbD4sIHhlbj08Ym9vbD4sIHtwdixodm0sbXNy LXNjLHJzYixtZC1jbGVhcn09PGJvb2w+LAotPiAgICAgICAgICAgICAgYnRp LXRodW5rPXJldHBvbGluZXxsZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQs ZWFnZXItZnB1LAotPiAgICAgICAgICAgICAgbDFkLWZsdXNoLGJyYW5jaC1o YXJkZW4sc3JiLWxvY2ssdW5wcml2LW1taW99PTxib29sPiBdYAorPiAgICAg ICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxsZmVuY2V8am1wLCB7aWJy cyxpYnBiLHNzYmQscHNmZCwKKz4gICAgICAgICAgICAgIGVhZ2VyLWZwdSxs MWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9jaywKKz4gICAgICAgICAg ICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKIAogQ29udHJvbHMgZm9yIHNw ZWN1bGF0aXZlIGV4ZWN1dGlvbiBzaWRlY2hhbm5lbCBtaXRpZ2F0aW9ucy4g IEJ5IGRlZmF1bHQsIFhlbgogd2lsbCBwaWNrIHRoZSBtb3N0IGFwcHJvcHJp YXRlIG1pdGlnYXRpb25zIGJhc2VkIG9uIGNvbXBpbGVkIGluIHN1cHBvcnQs CkBAIC0yMTU2LDkgKzIxNTcsMTAgQEAgT24gaGFyZHdhcmUgc3VwcG9ydGlu ZyBJQlJTIChJbmRpcmVjdCBCcmFuY2ggUmVzdHJpY3RlZCBTcGVjdWxhdGlv biksIHRoZQogSWYgWGVuIGlzIG5vdCB1c2luZyBJQlJTIGl0c2VsZiwgZnVu Y3Rpb25hbGl0eSBpcyBzdGlsbCBzZXQgdXAgc28gSUJSUyBjYW4gYmUKIHZp cnR1YWxpc2VkIGZvciBndWVzdHMuCiAKLU9uIGhhcmR3YXJlIHN1cHBvcnRp bmcgSUJQQiAoSW5kaXJlY3QgQnJhbmNoIFByZWRpY3Rpb24gQmFycmllciks IHRoZSBgaWJwYj1gCi1vcHRpb24gY2FuIGJlIHVzZWQgdG8gZm9yY2UgKHRo ZSBkZWZhdWx0KSBvciBwcmV2ZW50IFhlbiBmcm9tIGlzc3VpbmcgYnJhbmNo Ci1wcmVkaWN0aW9uIGJhcnJpZXJzIG9uIHZjcHUgY29udGV4dCBzd2l0Y2hl cy4KK09uIGhhcmR3YXJlIHN1cHBvcnRpbmcgU1RJQlAgKFNpbmdsZSBUaHJl YWQgSW5kaXJlY3QgQnJhbmNoIFByZWRpY3RvcnMpLCB0aGUKK2BzdGlicD1g IG9wdGlvbiBjYW4gYmUgdXNlZCB0byBmb3JjZSBvciBwcmV2ZW50IFhlbiB1 c2luZyB0aGUgZmVhdHVyZSBpdHNlbGYuCitCeSBkZWZhdWx0LCBYZW4gd2ls bCB1c2UgU1RJQlAgd2hlbiBJQlJTIGlzIGluIHVzZSAoSUJSUyBpbXBsaWVz IFNUSUJQKSwgYW5kCit3aGVuIGhhcmR3YXJlIGhpbnRzIHJlY29tbWVuZCB1 c2luZyBpdCBhcyBhIGJsYW5rZXQgc2V0dGluZy4KIAogT24gaGFyZHdhcmUg c3VwcG9ydGluZyBTU0JEIChTcGVjdWxhdGl2ZSBTdG9yZSBCeXBhc3MgRGlz YWJsZSksIHRoZSBgc3NiZD1gCiBvcHRpb24gY2FuIGJlIHVzZWQgdG8gZm9y Y2Ugb3IgcHJldmVudCBYZW4gdXNpbmcgdGhlIGZlYXR1cmUgaXRzZWxmLiAg T24gQU1ECkBAIC0yMTY2LDYgKzIxNjgsMTUgQEAgaGFyZHdhcmUsIHRoaXMg aXMgYSBnbG9iYWwgb3B0aW9uIGFwcGxpZWQgYXQgYm9vdCwgYW5kIG5vdCB2 aXJ0dWFsaXNlZCBmb3IKIGd1ZXN0IHVzZS4gIE9uIEludGVsIGhhcmR3YXJl LCB0aGUgZmVhdHVyZSBpcyB2aXJ0dWFsaXNlZCBmb3IgZ3Vlc3RzLAogaW5k ZXBlbmRlbnRseSBvZiBYZW4ncyBjaG9pY2Ugb2Ygc2V0dGluZy4KIAorT24g aGFyZHdhcmUgc3VwcG9ydGluZyBQU0ZEIChQcmVkaWN0aXZlIFN0b3JlIEZv cndhcmRpbmcgRGlzYWJsZSksIHRoZSBgcHNmZD1gCitvcHRpb24gY2FuIGJl IHVzZWQgdG8gZm9yY2Ugb3IgcHJldmVudCBYZW4gdXNpbmcgdGhlIGZlYXR1 cmUgaXRzZWxmLiAgQnkKK2RlZmF1bHQsIFhlbiB3aWxsIG5vdCB1c2UgUFNG RC4gIFBTRkQgaXMgaW1wbGllZCBieSBTU0JELCBhbmQgU1NCRCBpcyBvZmYg YnkKK2RlZmF1bHQuCisKK09uIGhhcmR3YXJlIHN1cHBvcnRpbmcgSUJQQiAo SW5kaXJlY3QgQnJhbmNoIFByZWRpY3Rpb24gQmFycmllciksIHRoZSBgaWJw Yj1gCitvcHRpb24gY2FuIGJlIHVzZWQgdG8gZm9yY2UgKHRoZSBkZWZhdWx0 KSBvciBwcmV2ZW50IFhlbiBmcm9tIGlzc3VpbmcgYnJhbmNoCitwcmVkaWN0 aW9uIGJhcnJpZXJzIG9uIHZjcHUgY29udGV4dCBzd2l0Y2hlcy4KKwogT24g YWxsIGhhcmR3YXJlLCB0aGUgYGVhZ2VyLWZwdT1gIG9wdGlvbiBjYW4gYmUg dXNlZCB0byBmb3JjZSBvciBwcmV2ZW50IFhlbgogZnJvbSB1c2luZyBmdWxs eSBlYWdlciBGUFUgY29udGV4dCBzd2l0Y2hlcy4gIFRoaXMgaXMgY3VycmVu dGx5IGltcGxlbWVudGVkIGFzCiBhIGdsb2JhbCBjb250cm9sLiAgQnkgZGVm YXVsdCwgWGVuIHdpbGwgY2hvb3NlIHRvIHVzZSBmdWxseSBlYWdlciBjb250 ZXh0CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3N2bS92bWNiLmMg Yi94ZW4vYXJjaC94ODYvaHZtL3N2bS92bWNiLmMKaW5kZXggNTVkYTkzMDJl NWQ3Li5hMGJmOWY0ZTA1NmEgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9o dm0vc3ZtL3ZtY2IuYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3N2bS92bWNi LmMKQEAgLTI5LDYgKzI5LDcgQEAKICNpbmNsdWRlIDxhc20vaHZtL3N1cHBv cnQuaD4KICNpbmNsdWRlIDxhc20vaHZtL3N2bS9zdm0uaD4KICNpbmNsdWRl IDxhc20vaHZtL3N2bS9zdm1kZWJ1Zy5oPgorI2luY2x1ZGUgPGFzbS9zcGVj X2N0cmwuaD4KIAogc3RydWN0IHZtY2Jfc3RydWN0ICphbGxvY192bWNiKHZv aWQpCiB7CkBAIC0xNzUsNiArMTc2LDE0IEBAIHN0YXRpYyBpbnQgY29uc3Ry dWN0X3ZtY2Ioc3RydWN0IHZjcHUgKnYpCiAgICAgICAgICAgICB2bWNiLT5f cGF1c2VfZmlsdGVyX3RocmVzaCA9IFNWTV9QQVVTRVRIUkVTSF9JTklUOwog ICAgIH0KIAorICAgIC8qCisgICAgICogV2hlbiBkZWZhdWx0X3hlbl9zcGVj X2N0cmwgc2ltcGx5IFNQRUNfQ1RSTF9TVElCUCwgZGVmYXVsdCB0aGlzIGJl aGluZAorICAgICAqIHRoZSBiYWNrIG9mIHRoZSBWTSB0b28uICBPdXIgU01U IHRvcG9sb2d5IGlzbid0IGFjY3VyYXRlLCB0aGUgb3ZlcmhlYWQKKyAgICAg KiBpcyBuZWdsZWdhYmxlLCBhbmQgZG9pbmcgdGhpcyBzYXZlcyBhIFdSTVNS IG9uIHRoZSB2bWVudHJ5IHBhdGguCisgICAgICovCisgICAgaWYgKCBkZWZh dWx0X3hlbl9zcGVjX2N0cmwgPT0gU1BFQ19DVFJMX1NUSUJQICkKKyAgICAg ICAgdi0+YXJjaC5tc3JzLT5zcGVjX2N0cmwucmF3ID0gU1BFQ19DVFJMX1NU SUJQOworCiAgICAgcmV0dXJuIDA7CiB9CiAKZGlmZiAtLWdpdCBhL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwu YwppbmRleCBkN2Y3NjdiMDczOWMuLjA2NzkwODk3ZTQ5NiAxMDA2NDQKLS0t IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hlbi9hcmNoL3g4 Ni9zcGVjX2N0cmwuYwpAQCAtNDgsOSArNDgsMTMgQEAgc3RhdGljIGVudW0g aW5kX3RodW5rIHsKICAgICBUSFVOS19MRkVOQ0UsCiAgICAgVEhVTktfSk1Q LAogfSBvcHRfdGh1bmsgX19pbml0ZGF0YSA9IFRIVU5LX0RFRkFVTFQ7CisK IHN0YXRpYyBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfaWJycyA9IC0xOworaW50 OF90IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7Citib29sIF9fcmVhZF9t b3N0bHkgb3B0X3NzYmQ7CitpbnQ4X3QgX19pbml0ZGF0YSBvcHRfcHNmZCA9 IC0xOworCiBib29sIF9fcmVhZF9tb3N0bHkgb3B0X2licGIgPSB0cnVlOwot Ym9vbCBfX3JlYWRfbW9zdGx5IG9wdF9zc2JkID0gZmFsc2U7CiBpbnQ4X3Qg X19yZWFkX21vc3RseSBvcHRfZWFnZXJfZnB1ID0gLTE7CiBpbnQ4X3QgX19y ZWFkX21vc3RseSBvcHRfbDFkX2ZsdXNoID0gLTE7CiBib29sIF9fcmVhZF9t b3N0bHkgb3B0X2JyYW5jaF9oYXJkZW4gPSB0cnVlOwpAQCAtMTczLDEyICsx NzcsMjAgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2Vfc3BlY19jdHJsKGNv bnN0IGNoYXIgKnMpCiAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAgICAg ICAgcmMgPSAtRUlOVkFMOwogICAgICAgICB9CisKKyAgICAgICAgLyogQml0 cyBpbiBNU1JfU1BFQ19DVFJMLiAqLwogICAgICAgICBlbHNlIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oImlicnMiLCBzLCBzcykpID49IDAgKQogICAg ICAgICAgICAgb3B0X2licnMgPSB2YWw7Ci0gICAgICAgIGVsc2UgaWYgKCAo dmFsID0gcGFyc2VfYm9vbGVhbigiaWJwYiIsIHMsIHNzKSkgPj0gMCApCi0g ICAgICAgICAgICBvcHRfaWJwYiA9IHZhbDsKKyAgICAgICAgZWxzZSBpZiAo ICh2YWwgPSBwYXJzZV9ib29sZWFuKCJzdGlicCIsIHMsIHNzKSkgPj0gMCAp CisgICAgICAgICAgICBvcHRfc3RpYnAgPSB2YWw7CiAgICAgICAgIGVsc2Ug aWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigic3NiZCIsIHMsIHNzKSkgPj0g MCApCiAgICAgICAgICAgICBvcHRfc3NiZCA9IHZhbDsKKyAgICAgICAgZWxz ZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJwc2ZkIiwgcywgc3MpKSA+ PSAwICkKKyAgICAgICAgICAgIG9wdF9wc2ZkID0gdmFsOworCisgICAgICAg IC8qIE1pc2Mgc2V0dGluZ3MuICovCisgICAgICAgIGVsc2UgaWYgKCAodmFs ID0gcGFyc2VfYm9vbGVhbigiaWJwYiIsIHMsIHNzKSkgPj0gMCApCisgICAg ICAgICAgICBvcHRfaWJwYiA9IHZhbDsKICAgICAgICAgZWxzZSBpZiAoICh2 YWwgPSBwYXJzZV9ib29sZWFuKCJlYWdlci1mcHUiLCBzLCBzcykpID49IDAg KQogICAgICAgICAgICAgb3B0X2VhZ2VyX2ZwdSA9IHZhbDsKICAgICAgICAg ZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJsMWQtZmx1c2giLCBz LCBzcykpID49IDAgKQpAQCAtMzc3LDcgKzM4OSw3IEBAIHN0YXRpYyB2b2lk IF9faW5pdCBwcmludF9kZXRhaWxzKGVudW0gaW5kX3RodW5rIHRodW5rLCB1 aW50NjRfdCBjYXBzKQogICAgICAgICAgICAgICAgIlxuIik7CiAKICAgICAv KiBTZXR0aW5ncyBmb3IgWGVuJ3MgcHJvdGVjdGlvbiwgaXJyZXNwZWN0aXZl IG9mIGd1ZXN0cy4gKi8KLSAgICBwcmludGsoIiAgWGVuIHNldHRpbmdzOiBC VEktVGh1bmsgJXMsIFNQRUNfQ1RSTDogJXMlcyVzJXMsIE90aGVyOiVzJXMl cyVzJXNcbiIsCisgICAgcHJpbnRrKCIgIFhlbiBzZXR0aW5nczogQlRJLVRo dW5rICVzLCBTUEVDX0NUUkw6ICVzJXMlcyVzJXMsIE90aGVyOiVzJXMlcyVz JXNcbiIsCiAgICAgICAgICAgIHRodW5rID09IFRIVU5LX05PTkUgICAgICA/ ICJOL0EiIDoKICAgICAgICAgICAgdGh1bmsgPT0gVEhVTktfUkVUUE9MSU5F ID8gIlJFVFBPTElORSIgOgogICAgICAgICAgICB0aHVuayA9PSBUSFVOS19M RkVOQ0UgICAgPyAiTEZFTkNFIiA6CkBAIC0zOTEsNiArNDAzLDkgQEAgc3Rh dGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsg dGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgICghYm9vdF9jcHVf aGFzKFg4Nl9GRUFUVVJFX1NTQkQpICYmCiAgICAgICAgICAgICAhYm9vdF9j cHVfaGFzKFg4Nl9GRUFUVVJFX0FNRF9TU0JEKSkgICAgID8gIiIgOgogICAg ICAgICAgICAoZGVmYXVsdF94ZW5fc3BlY19jdHJsICYgU1BFQ19DVFJMX1NT QkQpICA/ICIgU1NCRCsiIDogIiBTU0JELSIsCisgICAgICAgICAgICghYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1BTRkQpICYmCisgICAgICAgICAgICAh Ym9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lOVEVMX1BTRkQpKSAgID8gIiIg OgorICAgICAgICAgICAoZGVmYXVsdF94ZW5fc3BlY19jdHJsICYgU1BFQ19D VFJMX1BTRkQpICA/ICIgUFNGRCsiIDogIiBQU0ZELSIsCiAgICAgICAgICAg ICEoY2FwcyAmIEFSQ0hfQ0FQU19UU1hfQ1RSTCkgICAgICAgICAgICAgID8g IiIgOgogICAgICAgICAgICAob3B0X3RzeCAmIDEpICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA/ICIgVFNYKyIgOiAiIFRTWC0iLAogICAgICAgICAg ICAhY3B1X2hhc19zcmJkc19jdHJsICAgICAgICAgICAgICAgICAgICAgICA/ ICIiIDoKQEAgLTk1MSwxMCArOTY2LDcgQEAgdm9pZCBfX2luaXQgaW5pdF9z cGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICBpZiAoICFo YXNfc3BlY19jdHJsICkKICAgICAgICAgICAgIHByaW50ayhYRU5MT0dfV0FS TklORyAiPyE/IENFVCBhY3RpdmUsIGJ1dCBubyBNU1JfU1BFQ19DVFJMP1xu Iik7CiAgICAgICAgIGVsc2UgaWYgKCBvcHRfaWJycyA9PSAtMSApCi0gICAg ICAgIHsKICAgICAgICAgICAgIG9wdF9pYnJzID0gaWJycyA9IHRydWU7Ci0g ICAgICAgICAgICBkZWZhdWx0X3hlbl9zcGVjX2N0cmwgfD0gU1BFQ19DVFJM X0lCUlMgfCBTUEVDX0NUUkxfU1RJQlA7Ci0gICAgICAgIH0KIAogICAgICAg ICBpZiAoIG9wdF90aHVuayA9PSBUSFVOS19ERUZBVUxUIHx8IG9wdF90aHVu ayA9PSBUSFVOS19SRVRQT0xJTkUgKQogICAgICAgICAgICAgdGh1bmsgPSBU SFVOS19KTVA7CkBAIC0xMDU4LDE0ICsxMDcwLDQ5IEBAIHZvaWQgX19pbml0 IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnModm9pZCkKICAgICAgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0ZFQVRVUkVfU0NfTVNSX0hW TSk7CiAgICAgfQogCi0gICAgLyogSWYgd2UgaGF2ZSBJQlJTIGF2YWlsYWJs ZSwgc2VlIHdoZXRoZXIgd2Ugc2hvdWxkIHVzZSBpdC4gKi8KKyAgICAvKiBG aWd1cmUgb3V0IGRlZmF1bHRfeGVuX3NwZWNfY3RybC4gKi8KICAgICBpZiAo IGhhc19zcGVjX2N0cmwgJiYgaWJycyApCisgICAgeworICAgICAgICAvKiBJ QlJTIGltcGxpZXMgU1RJQlAuICAqLworICAgICAgICBpZiAoIG9wdF9zdGli cCA9PSAtMSApCisgICAgICAgICAgICBvcHRfc3RpYnAgPSAxOworCiAgICAg ICAgIGRlZmF1bHRfeGVuX3NwZWNfY3RybCB8PSBTUEVDX0NUUkxfSUJSUzsK KyAgICB9CisKKyAgICAvKgorICAgICAqIFVzZSBTVElCUCBieSBkZWZhdWx0 IGlmIHRoZSBoYXJkd2FyZSBoaW50IGlzIHNldC4gIE90aGVyd2lzZSwgbGVh dmUgaXQKKyAgICAgKiBvZmYgYXMgaXQgYSBzZXZlcmUgcGVyZm9ybWFuY2Ug cGVudGFsdHkgb24gcHJlLWVJQlJTIEludGVsIGhhcmR3YXJlCisgICAgICog d2hlcmUgaXQgd2FzIHJldHJvZml0dGVkIGluIG1pY3JvY29kZS4KKyAgICAg Ki8KKyAgICBpZiAoIG9wdF9zdGlicCA9PSAtMSApCisgICAgICAgIG9wdF9z dGlicCA9ICEhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZ Uyk7CisKKyAgICBpZiAoIG9wdF9zdGlicCAmJiAoYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX1NUSUJQKSB8fAorICAgICAgICAgICAgICAgICAgICAgICBi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkgKQorICAgICAg ICBkZWZhdWx0X3hlbl9zcGVjX2N0cmwgfD0gU1BFQ19DVFJMX1NUSUJQOwog Ci0gICAgLyogSWYgd2UgaGF2ZSBTU0JEIGF2YWlsYWJsZSwgc2VlIHdoZXRo ZXIgd2Ugc2hvdWxkIHVzZSBpdC4gKi8KICAgICBpZiAoIG9wdF9zc2JkICYm IChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU1NCRCkgfHwKICAgICAgICAg ICAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NT QkQpKSApCisgICAgeworICAgICAgICAvKiBTU0JEIGltcGxpZXMgUFNGRCAq LworICAgICAgICBpZiAoIG9wdF9wc2ZkID09IC0xICkKKyAgICAgICAgICAg IG9wdF9wc2ZkID0gMTsKKwogICAgICAgICBkZWZhdWx0X3hlbl9zcGVjX2N0 cmwgfD0gU1BFQ19DVFJMX1NTQkQ7CisgICAgfQorCisgICAgLyoKKyAgICAg KiBEb24ndCB1c2UgUFNGRCBieSBkZWZhdWx0LiAgQU1EIGRlc2lnbmVkIHRo ZSBwcmVkaWN0b3IgdG8KKyAgICAgKiBhdXRvLWNsZWFyIG9uIHByaXZpbGVn ZSBjaGFuZ2UuICBQU0ZEIGlzIGltcGxpZWQgYnkgU1NCRCwgd2hpY2ggaXMK KyAgICAgKiBvZmYgYnkgZGVmYXVsdC4KKyAgICAgKi8KKyAgICBpZiAoIG9w dF9wc2ZkID09IC0xICkKKyAgICAgICAgb3B0X3BzZmQgPSAwOworCisgICAg aWYgKCBvcHRfcHNmZCAmJiAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1BT RkQpIHx8CisgICAgICAgICAgICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4 Nl9GRUFUVVJFX0lOVEVMX1BTRkQpKSApCisgICAgICAgIGRlZmF1bHRfeGVu X3NwZWNfY3RybCB8PSBTUEVDX0NUUkxfUFNGRDsKIAogICAgIC8qCiAgICAg ICogUFYgZ3Vlc3RzIGNhbiBwb2lzb24gdGhlIFJTQiB0byBhbnkgdmlydHVh bCBhZGRyZXNzIGZyb20gd2hpY2gK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-03.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-03.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeGVuL2NtZGxpbmU6IEV4dGVuZCBwYXJzZV9ib29sZWFu KCkgdG8gc2lnbmFsIGEgbmFtZSBtYXRjaAoKVGhpcyB3aWxsIGhlbHAgcGFy c2luZyBhIHN1Yi1vcHRpb24gd2hpY2ggaGFzIGJvb2xlYW4gYW5kIG5vbi1i b29sZWFuIG9wdGlvbnMKYXZhaWxhYmxlLgoKRmlyc3QsIHJld29yayAnaW50 IHZhbCcgaW50byAnYm9vbCBoYXNfbmVnX3ByZWZpeCcuICBUaGlzIGludmVy dHMgaXQncyB2YWx1ZSwKYnV0IHRoZSByZXN1bHRpbmcgbG9naWMgaXMgZmFy IGVhc2llciB0byBmb2xsb3cuCgpTZWNvbmQsIHJlamVjdCBhbnl0aGluZyBv ZiB0aGUgZm9ybSAnbm8tJEZPTz0nIHdoaWNoIGV4Y2x1ZGVzIGFtYmlndW91 cwpjb25zdHJ1Y3RzIHN1Y2ggYXMgJ25vLSRmb289eWVzJyB3aGljaCBoYXZl IG5ldmVyIGJlZW4gdmFsaWQuCgpUaGlzIGp1c3QgbGVhdmVzIHRoZSBjYXNl IHdoZXJlIGV2ZXJ5dGhpbmcgaXMgb3RoZXJ3aXNlIGZpbmUsIGJ1dCBwYXJz ZV9ib29sKCkKY2FuJ3QgaW50ZXJwcmV0IHRoZSBwcm92aWRlZCBzdHJpbmcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSnVlcmdlbiBHcm9zcyA8amdy b3NzQHN1c2UuY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgooY2hlcnJ5IHBpY2tlZCBmcm9tIGNvbW1pdCAzODIz MjZjYWM1MjhkZDFlYjBkMDRlZmQ1YzA1MzYzYzQ1M2UyOWY0KQoKZGlmZiAt LWdpdCBhL3hlbi9jb21tb24va2VybmVsLmMgYi94ZW4vY29tbW9uL2tlcm5l bC5jCmluZGV4IGMzYTk0M2YwNzc2NS4uZjA3ZmY0MWQ4ODFlIDEwMDY0NAot LS0gYS94ZW4vY29tbW9uL2tlcm5lbC5jCisrKyBiL3hlbi9jb21tb24va2Vy bmVsLmMKQEAgLTI3Miw5ICsyNzIsOSBAQCBpbnQgcGFyc2VfYm9vbChjb25z dCBjaGFyICpzLCBjb25zdCBjaGFyICplKQogaW50IHBhcnNlX2Jvb2xlYW4o Y29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAqcywgY29uc3QgY2hhciAq ZSkKIHsKICAgICBzaXplX3Qgc2xlbiwgbmxlbjsKLSAgICBpbnQgdmFsID0g ISFzdHJuY21wKHMsICJuby0iLCAzKTsKKyAgICBib29sIGhhc19uZWdfcHJl Zml4ID0gIXN0cm5jbXAocywgIm5vLSIsIDMpOwogCi0gICAgaWYgKCAhdmFs ICkKKyAgICBpZiAoIGhhc19uZWdfcHJlZml4ICkKICAgICAgICAgcyArPSAz OwogCiAgICAgc2xlbiA9IGUgPyAoeyBBU1NFUlQoZSA+PSBzKTsgZSAtIHM7 IH0pIDogc3RybGVuKHMpOwpAQCAtMjg2LDExICsyODYsMjMgQEAgaW50IHBh cnNlX2Jvb2xlYW4oY29uc3QgY2hhciAqbmFtZSwgY29uc3QgY2hhciAqcywg Y29uc3QgY2hhciAqZSkKIAogICAgIC8qIEV4YWN0LCB1bmFkb3JuZWQgbmFt ZT8gIFJlc3VsdCBkZXBlbmRzIG9uIHRoZSAnbm8tJyBwcmVmaXguICovCiAg ICAgaWYgKCBzbGVuID09IG5sZW4gKQotICAgICAgICByZXR1cm4gdmFsOwor ICAgICAgICByZXR1cm4gIWhhc19uZWdfcHJlZml4OworCisgICAgLyogSW5l eGFjdCBtYXRjaCB3aXRoIGEgJ25vLScgcHJlZml4PyAgTm90IHZhbGlkLiAq LworICAgIGlmICggaGFzX25lZ19wcmVmaXggKQorICAgICAgICByZXR1cm4g LTE7CiAKICAgICAvKiA9JFNPTUVUSElORz8gIERlZmVyIHRvIHRoZSByZWd1 bGFyIGJvb2xlYW4gcGFyc2luZy4gKi8KICAgICBpZiAoIHNbbmxlbl0gPT0g Jz0nICkKLSAgICAgICAgcmV0dXJuIHBhcnNlX2Jvb2woJnNbbmxlbiArIDFd LCBlKTsKKyAgICB7CisgICAgICAgIGludCBiID0gcGFyc2VfYm9vbCgmc1tu bGVuICsgMV0sIGUpOworCisgICAgICAgIGlmICggYiA+PSAwICkKKyAgICAg ICAgICAgIHJldHVybiBiOworCisgICAgICAgIC8qIE5vdCBhIGJvb2xlYW4s IGJ1dCB0aGUgbmFtZSBtYXRjaGVkLiAgU2lnbmFsIHNwZWNpYWxseS4gKi8K KyAgICAgICAgcmV0dXJuIC0yOworICAgIH0KIAogICAgIC8qIFVucmVjb2du aXNlZC4gIEdpdmUgdXAuICovCiAgICAgcmV0dXJuIC0xOwpkaWZmIC0tZ2l0 IGEveGVuL2luY2x1ZGUveGVuL2xpYi5oIGIveGVuL2luY2x1ZGUveGVuL2xp Yi5oCmluZGV4IDA3NmJjZmI2N2RiYi4uOTAwYzBjZTNlNDY2IDEwMDY0NAot LS0gYS94ZW4vaW5jbHVkZS94ZW4vbGliLmgKKysrIGIveGVuL2luY2x1ZGUv eGVuL2xpYi5oCkBAIC04Miw3ICs4Miw4IEBAIGludCBwYXJzZV9ib29sKGNv bnN0IGNoYXIgKnMsIGNvbnN0IGNoYXIgKmUpOwogLyoqCiAgKiBHaXZlbiBh IHNwZWNpZmljIG5hbWUsIHBhcnNlcyBhIHN0cmluZyBvZiB0aGUgZm9ybToK ICAqICAgW25vLV0kTkFNRVs9Li4uXQotICogcmV0dXJuaW5nIDAgb3IgMSBm b3IgYSByZWNvZ25pc2VkIGJvb2xlYW4sIG9yIC0xIGZvciBhbiBlcnJvci4K KyAqIHJldHVybmluZyAwIG9yIDEgZm9yIGEgcmVjb2duaXNlZCBib29sZWFu LiAgUmV0dXJucyAtMSBmb3IgZ2VuZXJhbCBlcnJvcnMsCisgKiBhbmQgLTIg Zm9yICJub3QgYSBib29sZWFuLCBidXQgJE5BTUU9IG1hdGNoZXMiLgogICov CiBpbnQgcGFyc2VfYm9vbGVhbihjb25zdCBjaGFyICpuYW1lLCBjb25zdCBj aGFyICpzLCBjb25zdCBjaGFyICplKTsKIAo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-04.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-04.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogQWRkIGZpbmUtZ3JhaW5lZCBj bWRsaW5lIHN1Ym9wdGlvbnMgZm9yIHByaW1pdGl2ZXMKClN1cHBvcnQgY29u dHJvbGluZyB0aGUgUFYvSFZNIHN1Ym9wdGlvbiBvZiBtc3Itc2MvcnNiL21k LWNsZWFyLCB3aGljaApwcmV2aW91c2x5IHdhc24ndCBwb3NzaWJsZS4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CihjaGVycnkgcGlja2VkIGZyb20gY29tbWl0IDI3MzU3YzM5 NGJhNmUxNTcxYTg5MTA1Yjg0MGNlMWM2ZjAyNjQ4NWMpCgpkaWZmIC0tZ2l0 IGEvZG9jcy9taXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jIGIvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCmluZGV4IDIzMDJjZWM5MWZl YS4uYTg0ZjVjMTkyMThkIDEwMDY0NAotLS0gYS9kb2NzL21pc2MveGVuLWNv bW1hbmQtbGluZS5wYW5kb2MKKysrIGIvZG9jcy9taXNjL3hlbi1jb21tYW5k LWxpbmUucGFuZG9jCkBAIC0yMTA0LDcgKzIxMDQsOCBAQCBub3QgYmUgYWJs ZSB0byBjb250cm9sIHRoZSBzdGF0ZSBvZiB0aGUgbWl0aWdhdGlvbi4KIEJ5 IGRlZmF1bHQgU1NCRCB3aWxsIGJlIG1pdGlnYXRlZCBhdCBydW50aW1lIChp LmUgYHNzYmQ9cnVudGltZWApLgogCiAjIyMgc3BlYy1jdHJsICh4ODYpCi0+ IGA9IExpc3Qgb2YgWyA8Ym9vbD4sIHhlbj08Ym9vbD4sIHtwdixodm0sbXNy LXNjLHJzYixtZC1jbGVhcn09PGJvb2w+LAorPiBgPSBMaXN0IG9mIFsgPGJv b2w+LCB4ZW49PGJvb2w+LCB7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAg ICAgICB7bXNyLXNjLHJzYixtZC1jbGVhcn09PGJvb2w+fHtwdixodm19PTxi b29sPiwKID4gICAgICAgICAgICAgIGJ0aS10aHVuaz1yZXRwb2xpbmV8bGZl bmNlfGptcCwge2licnMsaWJwYixzc2JkLHBzZmQsCiA+ICAgICAgICAgICAg ICBlYWdlci1mcHUsbDFkLWZsdXNoLGJyYW5jaC1oYXJkZW4sc3JiLWxvY2ss CiA+ICAgICAgICAgICAgICB1bnByaXYtbW1pb309PGJvb2w+IF1gCkBAIC0y MTI5LDEyICsyMTMwLDE3IEBAIGluIHBsYWNlIGZvciBndWVzdHMgdG8gdXNl LgogCiBVc2Ugb2YgYSBwb3NpdGl2ZSBib29sZWFuIHZhbHVlIGZvciBlaXRo ZXIgb2YgdGhlc2Ugb3B0aW9ucyBpcyBpbnZhbGlkLgogCi1UaGUgYm9vbGVh bnMgYHB2PWAsIGBodm09YCwgYG1zci1zYz1gLCBgcnNiPWAgYW5kIGBtZC1j bGVhcj1gIG9mZmVyIGZpbmUKK1RoZSBgcHY9YCwgYGh2bT1gLCBgbXNyLXNj PWAsIGByc2I9YCBhbmQgYG1kLWNsZWFyPWAgb3B0aW9ucyBvZmZlciBmaW5l CiBncmFpbmVkIGNvbnRyb2wgb3ZlciB0aGUgcHJpbWl0aXZlcyBieSBYZW4u ICBUaGVzZSBpbXBhY3QgWGVuJ3MgYWJpbGl0eSB0bwotcHJvdGVjdCBpdHNl bGYsIGFuZCBYZW4ncyBhYmlsaXR5IHRvIHZpcnR1YWxpc2Ugc3VwcG9ydCBm b3IgZ3Vlc3RzIHRvIHVzZS4KK3Byb3RlY3QgaXRzZWxmLCBhbmQvb3IgWGVu J3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNlIHN1cHBvcnQgZm9yIGd1ZXN0cyB0 byB1c2UuCiAKICogYHB2PWAgYW5kIGBodm09YCBvZmZlciBjb250cm9sIG92 ZXIgYWxsIHN1Ym9wdGlvbnMgZm9yIFBWIGFuZCBIVk0gZ3Vlc3RzCiAgIHJl c3BlY3RpdmVseS4KKyogRWFjaCBvdGhlciBvcHRpb24gY2FuIGJlIHVzZWQg ZWl0aGVyIGFzIGEgcGxhaW4gYm9vbGVhbgorICAoZS5nLiBgc3BlYy1jdHJs PXJzYmAgdG8gY29udHJvbCBib3RoIHRoZSBQViBhbmQgSFZNIHN1Yi1vcHRp b25zKSwgb3Igd2l0aAorICBgcHY9YCBvciBgaHZtPWAgc3Vic3Vib3B0aW9u cyAoZS5nLiBgc3BlYy1jdHJsPXJzYj1uby1odm1gIHRvIGRpc2FibGUgSFZN CisgIFJTQiBvbmx5KS4KKwogKiBgbXNyLXNjPWAgb2ZmZXJzIGNvbnRyb2wg b3ZlciBYZW4ncyBzdXBwb3J0IGZvciBtYW5pcHVsYXRpbmcgYE1TUl9TUEVD X0NUUkxgCiAgIG9uIGVudHJ5IGFuZCBleGl0LiAgVGhlc2UgYmxvY2tzIGFy ZSBuZWNlc3NhcnkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgogICBndWVz dHMgYW5kIGlmIGRpc2FibGVkLCBndWVzdHMgd2lsbCBiZSB1bmFibGUgdG8g dXNlIElCUlMvU1RJQlAvU1NCRC9ldGMuCmRpZmYgLS1naXQgYS94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMK aW5kZXggMDY3OTA4OTdlNDk2Li4yMjVmZTA4MjU5YjMgMTAwNjQ0Ci0tLSBh L3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKQEAgLTE0NywyMCArMTQ3LDY4IEBAIHN0YXRpYyBpbnQg X19pbml0IHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFyICpzKQogICAgICAg ICAgICAgb3B0X3JzYl9odm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfbWRf Y2xlYXJfaHZtID0gdmFsOwogICAgICAgICB9Ci0gICAgICAgIGVsc2UgaWYg KCAodmFsID0gcGFyc2VfYm9vbGVhbigibXNyLXNjIiwgcywgc3MpKSA+PSAw ICkKKyAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJt c3Itc2MiLCBzLCBzcykpICE9IC0xICkKICAgICAgICAgewotICAgICAgICAg ICAgb3B0X21zcl9zY19wdiA9IHZhbDsKLSAgICAgICAgICAgIG9wdF9tc3Jf c2NfaHZtID0gdmFsOworICAgICAgICAgICAgc3dpdGNoICggdmFsICkKKyAg ICAgICAgICAgIHsKKyAgICAgICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAg IGNhc2UgMToKKyAgICAgICAgICAgICAgICBvcHRfbXNyX3NjX3B2ID0gb3B0 X21zcl9zY19odm0gPSB2YWw7CisgICAgICAgICAgICAgICAgYnJlYWs7CisK KyAgICAgICAgICAgIGNhc2UgLTI6CisgICAgICAgICAgICAgICAgcyArPSBz dHJsZW4oIm1zci1zYz0iKTsKKyAgICAgICAgICAgICAgICBpZiAoICh2YWwg PSBwYXJzZV9ib29sZWFuKCJwdiIsIHMsIHNzKSkgPj0gMCApCisgICAgICAg ICAgICAgICAgICAgIG9wdF9tc3Jfc2NfcHYgPSB2YWw7CisgICAgICAgICAg ICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJodm0iLCBz LCBzcykpID49IDAgKQorICAgICAgICAgICAgICAgICAgICBvcHRfbXNyX3Nj X2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAg ICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAgICByYyA9IC1FSU5WQUw7 CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICB9CiAgICAg ICAgIH0KLSAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFu KCJyc2IiLCBzLCBzcykpID49IDAgKQorICAgICAgICBlbHNlIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oInJzYiIsIHMsIHNzKSkgIT0gLTEgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBvcHRfcnNiX3B2ID0gdmFsOwotICAgICAg ICAgICAgb3B0X3JzYl9odm0gPSB2YWw7CisgICAgICAgICAgICBzd2l0Y2gg KCB2YWwgKQorICAgICAgICAgICAgeworICAgICAgICAgICAgY2FzZSAwOgor ICAgICAgICAgICAgY2FzZSAxOgorICAgICAgICAgICAgICAgIG9wdF9yc2Jf cHYgPSBvcHRfcnNiX2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBicmVh azsKKworICAgICAgICAgICAgY2FzZSAtMjoKKyAgICAgICAgICAgICAgICBz ICs9IHN0cmxlbigicnNiPSIpOworICAgICAgICAgICAgICAgIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oInB2Iiwgcywgc3MpKSA+PSAwICkKKyAgICAg ICAgICAgICAgICAgICAgb3B0X3JzYl9wdiA9IHZhbDsKKyAgICAgICAgICAg ICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImh2bSIsIHMs IHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAgIG9wdF9yc2JfaHZt ID0gdmFsOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGRl ZmF1bHQ6CisgICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsKKyAg ICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KICAgICAgICAg fQotICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oIm1k LWNsZWFyIiwgcywgc3MpKSA+PSAwICkKKyAgICAgICAgZWxzZSBpZiAoICh2 YWwgPSBwYXJzZV9ib29sZWFuKCJtZC1jbGVhciIsIHMsIHNzKSkgIT0gLTEg KQogICAgICAgICB7Ci0gICAgICAgICAgICBvcHRfbWRfY2xlYXJfcHYgPSB2 YWw7Ci0gICAgICAgICAgICBvcHRfbWRfY2xlYXJfaHZtID0gdmFsOworICAg ICAgICAgICAgc3dpdGNoICggdmFsICkKKyAgICAgICAgICAgIHsKKyAgICAg ICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAgIGNhc2UgMToKKyAgICAgICAg ICAgICAgICBvcHRfbWRfY2xlYXJfcHYgPSBvcHRfbWRfY2xlYXJfaHZtID0g dmFsOworICAgICAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgICAgICBj YXNlIC0yOgorICAgICAgICAgICAgICAgIHMgKz0gc3RybGVuKCJtZC1jbGVh cj0iKTsKKyAgICAgICAgICAgICAgICBpZiAoICh2YWwgPSBwYXJzZV9ib29s ZWFuKCJwdiIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAg IG9wdF9tZF9jbGVhcl9wdiA9IHZhbDsKKyAgICAgICAgICAgICAgICBlbHNl IGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImh2bSIsIHMsIHNzKSkgPj0g MCApCisgICAgICAgICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0gPSB2 YWw7CisgICAgICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgZGVmYXVs dDoKKyAgICAgICAgICAgICAgICAgICAgcmMgPSAtRUlOVkFMOworICAgICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQogICAgICAgICB9CiAK ICAgICAgICAgLyogWGVuJ3Mgc3BlY3VsYXRpdmUgc2lkZWNoYW5uZWwgbWl0 aWdhdGlvbiBzZXR0aW5ncy4gKi8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-05.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-05.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIHNwZWNfY3RybF9m bGFncyBjb250ZXh0IHN3aXRjaGluZwoKV2UgYXJlIHNob3J0bHkgZ29pbmcg dG8gbmVlZCB0byBjb250ZXh0IHN3aXRjaCBuZXcgYml0cyBpbiBib3RoIHRo ZSB2Y3B1IGFuZApTMyBwYXRocy4gIEludHJvZHVjZSBTQ0ZfSVNUX01BU0sg YW5kIFNDRl9ET01fTUFTSywgYW5kIHJld29yayBkLT5hcmNoLnZlcncKaW50 byBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyB0byBhY2NvbW1vZGF0ZS4KCk5v IGZ1bmN0aW9uYWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9hY3Bp L3Bvd2VyLmMgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCmluZGV4IDc3 NGUwZmNkMzVkNy4uMDZmM2UwZTlmM2UwIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvYWNwaS9wb3dlci5jCisrKyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bv d2VyLmMKQEAgLTI0Niw4ICsyNDYsOCBAQCBzdGF0aWMgaW50IGVudGVyX3N0 YXRlKHUzMiBzdGF0ZSkKICAgICAgICAgZXJyb3IgPSAwOwogCiAgICAgY2kg PSBnZXRfY3B1X2luZm8oKTsKLSAgICAvKiBBdm9pZCBOTUkvI01DIHVzaW5n IE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQgbWljcm9jb2Rl LiAqLwotICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflNDRl9pc3Rfd3Jt c3I7CisgICAgLyogQXZvaWQgTk1JLyNNQyB1c2luZyB1bnNhZmUgTVNScyB1 bnRpbCB3ZSd2ZSByZWxvYWRlZCBtaWNyb2NvZGUuICovCisgICAgY2ktPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX0lTVF9NQVNLOwogCiAgICAgQUNQSV9G TFVTSF9DUFVfQ0FDSEUoKTsKIApAQCAtMjkwLDggKzI5MCw4IEBAIHN0YXRp YyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgIGlmICggIXJlY2hl Y2tfY3B1X2ZlYXR1cmVzKDApICkKICAgICAgICAgcGFuaWMoIk1pc3Npbmcg cHJldmlvdXNseSBhdmFpbGFibGUgZmVhdHVyZShzKVxuIik7CiAKLSAgICAv KiBSZS1lbmFibGVkIGRlZmF1bHQgTk1JLyNNQyB1c2Ugb2YgTVNSX1NQRUNf Q1RSTC4gKi8KLSAgICBjaS0+c3BlY19jdHJsX2ZsYWdzIHw9IChkZWZhdWx0 X3NwZWNfY3RybF9mbGFncyAmIFNDRl9pc3Rfd3Jtc3IpOworICAgIC8qIFJl LWVuYWJsZWQgZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JzIG5vdyBtaWNy b2NvZGUgaXMgbG9hZGVkLiAqLworICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gKGRlZmF1bHRfc3BlY19jdHJsX2ZsYWdzICYgU0NGX0lTVF9NQVNLKTsK IAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSB8 fCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykgKQogICAgIHsKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4 Ni9kb21haW4uYwppbmRleCA1ZWE1ZWY2YmEwMzcuLjMwNWE2M2I2N2UyZCAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9h cmNoL3g4Ni9kb21haW4uYwpAQCAtMTgzOCwxMCArMTgzOCwxMCBAQCB2b2lk IGNvbnRleHRfc3dpdGNoKHN0cnVjdCB2Y3B1ICpwcmV2LCBzdHJ1Y3QgdmNw dSAqbmV4dCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAg IC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIHdpdGggdGhlIFZF UlcgZGlzcG9zaXRpb24uICovCi0gICAgICAgIGluZm8tPnNwZWNfY3RybF9m bGFncyAmPSB+U0NGX3Zlcnc7Ci0gICAgICAgIGlmICggbmV4dGQtPmFyY2gu dmVydyApCi0gICAgICAgICAgICBpbmZvLT5zcGVjX2N0cmxfZmxhZ3MgfD0g U0NGX3Zlcnc7CisgICAgICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNr IGJsb2NrIHdpdGggdGhlIG5ldyBzcGVjX2N0cmwgc2V0dGluZ3MuICovCisg ICAgICAgIGluZm8tPnNwZWNfY3RybF9mbGFncyA9CisgICAgICAgICAgICAo aW5mby0+c3BlY19jdHJsX2ZsYWdzICAgICAgICYgflNDRl9ET01fTUFTSykg fAorICAgICAgICAgICAgKG5leHRkLT5hcmNoLnNwZWNfY3RybF9mbGFncyAm ICBTQ0ZfRE9NX01BU0spOwogICAgIH0KIAogICAgIHNjaGVkX2NvbnRleHRf c3dpdGNoZWQocHJldiwgbmV4dCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggMjI1ZmUwODI1OWIzLi4wZmFiZmJlMmE5ZjQgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTk4MSw5ICs5ODEsMTIgQEAgdm9pZCBzcGVjX2N0cmxf aW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCkKIHsKICAgICBib29sIHB2 ID0gaXNfcHZfZG9tYWluKGQpOwogCi0gICAgZC0+YXJjaC52ZXJ3ID0KLSAg ICAgICAgKHB2ID8gb3B0X21kX2NsZWFyX3B2IDogb3B0X21kX2NsZWFyX2h2 bSkgfHwKLSAgICAgICAgKG9wdF9mYl9jbGVhcl9tbWlvICYmIGlzX2lvbW11 X2VuYWJsZWQoZCkpOworICAgIGJvb2wgdmVydyA9ICgocHYgPyBvcHRfbWRf Y2xlYXJfcHYgOiBvcHRfbWRfY2xlYXJfaHZtKSB8fAorICAgICAgICAgICAg ICAgICAob3B0X2ZiX2NsZWFyX21taW8gJiYgaXNfaW9tbXVfZW5hYmxlZChk KSkpOworCisgICAgZC0+YXJjaC5zcGVjX2N0cmxfZmxhZ3MgPQorICAgICAg ICAodmVydyAgID8gU0NGX3ZlcncgICAgICAgICA6IDApIHwKKyAgICAgICAg MDsKIH0KIAogdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9k b21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvZG9tYWluLmgKaW5kZXgg NGVlNzZiYmE0NWRhLi41M2Q1YTQzZWMwY2UgMTAwNjQ0Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvZG9tYWluLmgKKysrIGIveGVuL2luY2x1ZGUvYXNt LXg4Ni9kb21haW4uaApAQCAtMzA4LDggKzMwOCw3IEBAIHN0cnVjdCBhcmNo X2RvbWFpbgogICAgIHVpbnQzMl90IHBjaV9jZjg7CiAgICAgdWludDhfdCBj bW9zX2lkeDsKIAotICAgIC8qIFVzZSBWRVJXIG9uIHJldHVybi10by1ndWVz dCBmb3IgaXRzIGZsdXNoaW5nIHNpZGUgZWZmZWN0LiAqLwotICAgIGJvb2wg dmVydzsKKyAgICB1aW50OF90IHNwZWNfY3RybF9mbGFnczsgLyogU2VlIFND Rl9ET01fTUFTSyAqLwogCiAgICAgdW5pb24gewogICAgICAgICBzdHJ1Y3Qg cHZfZG9tYWluIHB2OwpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJs LmgKaW5kZXggMTIyODM1NzNjZGQ1Li42MGQ2ZDJkYzk0MDcgMTAwNjQ0Ci0t LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaApAQCAtMjAsMTIgKzIwLDQw IEBACiAjaWZuZGVmIF9fWDg2X1NQRUNfQ1RSTF9IX18KICNkZWZpbmUgX19Y ODZfU1BFQ19DVFJMX0hfXwogCi0vKiBFbmNvZGluZyBvZiBjcHVpbmZvLnNw ZWNfY3RybF9mbGFncyAqLworLyoKKyAqIEVuY29kaW5nIG9mOgorICogICBj cHVpbmZvLnNwZWNfY3RybF9mbGFncworICogICBkZWZhdWx0X3NwZWNfY3Ry bF9mbGFncworICogICBkb21haW4uc3BlY19jdHJsX2ZsYWdzCisgKgorICog TGl2ZSBzZXR0aW5ncyBhcmUgaW4gdGhlIHRvcC1vZi1zdGFjayBibG9jaywg YmVjYXVzZSB0aGV5IG5lZWQgdG8gYmUKKyAqIGFjY2Vzc2FibGUgd2hlbiBY UFRJIGlzIGFjdGl2ZS4gIFNvbWUgc2V0dGluZ3MgYXJlIGZpeGVkIGZyb20g Ym9vdCwgc29tZQorICogY29udGV4dCBzd2l0Y2hlZCBwZXIgZG9tYWluLCBh bmQgc29tZSBpbmhpYml0ZWQgaW4gdGhlIFMzIHBhdGguCisgKi8KICNkZWZp bmUgU0NGX3VzZV9zaGFkb3cgKDEgPDwgMCkKICNkZWZpbmUgU0NGX2lzdF93 cm1zciAgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAgKDEgPDwg MikKICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKIAorLyoKKyAq IFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNhbiBpbnRlcnJ1cHQgYW55IGFy Yml0cmFyeSBjb250ZXh0LiAgU29tZQorICogZnVuY3Rpb25hbGl0eSByZXF1 aXJlcyB1cGRhdGVkIG1pY3JvY29kZSB0byB3b3JrLgorICoKKyAqIE9uIGJv b3QsIHRoaXMgaXMgZWFzeTsgd2UgbG9hZCBtaWNyb2NvZGUgYmVmb3JlIGZp Z3VyaW5nIG91dCB3aGljaAorICogc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMg dG8gYXBwbHkuICBIb3dldmVyLCBvbiB0aGUgUzMgcmVzdW1lIHBhdGgsIHdl IG11c3QKKyAqIGJlIGFibGUgdG8gZGlzYWJsZSB0aGUgY29uZmlndXJlZCBt aXRpZ2F0aW9ucyB1bnRpbCBtaWNyb2NvZGUgaXMgcmVsb2FkZWQuCisgKgor ICogVGhlc2UgYXJlIHRoZSBjb250cm9scyB0byBpbmhpYml0IG9uIHRoZSBT MyByZXN1bWUgcGF0aCB1bnRpbCBtaWNyb2NvZGUgaGFzCisgKiBiZWVuIHJl bG9hZGVkLgorICovCisjZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NGX2lzdF93 cm1zcikKKworLyoKKyAqIFNvbWUgc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMg YXJlIHBlci1kb21haW4uICBUaGVzZSBzZXR0aW5ncyBhcmUgbWVyZ2VkCisg KiBpbnRvIHRoZSB0b3Atb2Ytc3RhY2sgYmxvY2sgaW4gdGhlIGNvbnRleHQg c3dpdGNoIHBhdGguCisgKi8KKyNkZWZpbmUgU0NGX0RPTV9NQVNLIChTQ0Zf dmVydykKKwogI2lmbmRlZiBfX0FTU0VNQkxZX18KIAogI2luY2x1ZGUgPGFz bS9hbHRlcm5hdGl2ZS5oPgpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9zcGVjX2N0cmxfYXNtLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybF9hc20uaAppbmRleCA1YTU5MGJhYzQ0YWEuLjY2YjAwZDUxMWZj NiAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxf YXNtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxfYXNt LmgKQEAgLTI0OCw5ICsyNDgsNiBAQAogCiAvKgogICogVXNlIGluIElTVCBp bnRlcnJ1cHQvZXhjZXB0aW9uIGNvbnRleHQuICBNYXkgaW50ZXJydXB0IFhl biBvciBQViBjb250ZXh0LgotICogRmluZSBncmFpbiBjb250cm9sIG9mIFND Rl9pc3Rfd3Jtc3IgaXMgbmVlZGVkIGZvciBzYWZldHkgaW4gdGhlIFMzIHJl c3VtZQotICogcGF0aCB0byBhdm9pZCB1c2luZyBNU1JfU1BFQ19DVFJMIGJl Zm9yZSB0aGUgbWljcm9jb2RlIGludHJvZHVjaW5nIGl0IGhhcwotICogYmVl biByZWxvYWRlZC4KICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9N X0lOVFJfSVNUCiAvKgo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-06.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-06.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIFNDRl9pc3Rfd3Jt c3IgdG8gU0NGX2lzdF9zY19tc3IKCldlIGFyZSBhYm91dCB0byBpbnRyb2R1 Y2UgU0NGX2lzdF9pYnBiLCBhdCB3aGljaCBwb2ludCBTQ0ZfaXN0X3dybXNy IGJlY29tZXMKYW1iaWd1b3VzLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCgpU aGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jCmluZGV4IDBmYWJmYmUyYTlmNC4uYTZkZWY0NzA2MWU4 IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMDg2LDcgKzEwODYsNyBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgewogICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8 PSBTQ0ZfaXN0X3dybXNyOworICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0 cmxfZmxhZ3MgfD0gU0NGX2lzdF9zY19tc3I7CiAgICAgICAgICAgICBzZXR1 cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01TUl9QVik7CiAgICAg ICAgIH0KIApAQCAtMTA5Nyw3ICsxMDk3LDcgQEAgdm9pZCBfX2luaXQgaW5p dF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICAgICAg ICogWGVuJ3MgdmFsdWUgaXMgbm90IHJlc3RvcmVkIGF0b21pY2FsbHkuICBB biBlYXJseSBOTUkgaGl0dGluZwogICAgICAgICAgICAgICogdGhlIFZNRXhp dCBwYXRoIG5lZWRzIHRvIHJlc3RvcmUgWGVuJ3MgdmFsdWUgZm9yIHNhZmV0 eS4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgZGVmYXVsdF9zcGVj X2N0cmxfZmxhZ3MgfD0gU0NGX2lzdF93cm1zcjsKKyAgICAgICAgICAgIGRl ZmF1bHRfc3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfc2NfbXNyOwogICAg ICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19N U1JfSFZNKTsKICAgICAgICAgfQogICAgIH0KQEAgLTExMTAsNyArMTExMCw3 IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnMo dm9pZCkKICAgICAgICAgICogb24gcmVhbCBoYXJkd2FyZSBtYXRjaGVzIHRo ZSBhdmFpbGFiaWxpdHkgb2YgTVNSX1NQRUNfQ1RSTCBpbiB0aGUKICAgICAg ICAgICogZmlyc3QgcGxhY2UuCiAgICAgICAgICAqCi0gICAgICAgICAqIE5v IG5lZWQgZm9yIFNDRl9pc3Rfd3Jtc3IgYmVjYXVzZSBYZW4ncyB2YWx1ZSBp cyByZXN0b3JlZAorICAgICAgICAgKiBObyBuZWVkIGZvciBTQ0ZfaXN0X3Nj X21zciBiZWNhdXNlIFhlbidzIHZhbHVlIGlzIHJlc3RvcmVkCiAgICAgICAg ICAqIGF0b21pY2FsbHkgV1JUIE5NSXMgaW4gdGhlIFZNRXhpdCBwYXRoLgog ICAgICAgICAgKgogICAgICAgICAgKiBUT0RPOiBBZGp1c3QgY3B1X2hhc19z dm1fc3BlY19jdHJsIHRvIGJlIHVzYWJsZSBlYXJsaWVyIG9uIGJvb3QuCmRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCA2MGQ2ZDJk Yzk0MDcuLjZmOGIwZTA5MzQ4ZSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCkBAIC0zMSw3ICszMSw3IEBACiAgKiBjb250ZXh0IHN3 aXRjaGVkIHBlciBkb21haW4sIGFuZCBzb21lIGluaGliaXRlZCBpbiB0aGUg UzMgcGF0aC4KICAqLwogI2RlZmluZSBTQ0ZfdXNlX3NoYWRvdyAoMSA8PCAw KQotI2RlZmluZSBTQ0ZfaXN0X3dybXNyICAoMSA8PCAxKQorI2RlZmluZSBT Q0ZfaXN0X3NjX21zciAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAg ICAoMSA8PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQog CkBAIC00Niw3ICs0Niw3IEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xz IHRvIGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3Jv Y29kZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NG X0lTVF9NQVNLIChTQ0ZfaXN0X3dybXNyKQorI2RlZmluZSBTQ0ZfSVNUX01B U0sgKFNDRl9pc3Rfc2NfbXNyKQogCiAvKgogICogU29tZSBzcGVjdWxhdGl2 ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4gIFRoZXNlIHNldHRpbmdz IGFyZSBtZXJnZWQKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKaW5kZXggNjZiMDBkNTExZmM2Li4wZmYxYjExOGY4ODIgMTAw NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5o CisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCkBA IC0yNjYsOCArMjY2LDggQEAKIAogLkxcQF9za2lwX3JzYjoKIAotICAgIHRl c3QgJFNDRl9pc3Rfd3Jtc3IsICVhbAotICAgIGp6IC5MXEBfc2tpcF93cm1z cgorICAgIHRlc3QgJFNDRl9pc3Rfc2NfbXNyLCAlYWwKKyAgICBqeiAuTFxA X3NraXBfbXNyX3NwZWNfY3RybAogCiAgICAgeG9yICVlZHgsICVlZHgKICAg ICB0ZXN0YiAkMywgVVJFR1NfY3MoJXJzcCkKQEAgLTI5MCw3ICsyOTAsNyBA QCBVTkxJS0VMWV9ESVNQQVRDSF9MQUJFTChcQF9zZXJpYWxpc2UpOgogICAg ICAqIHRvIHNwZWN1bGF0ZSBhcm91bmQgdGhlIFdSTVNSLiAgQXMgYSByZXN1 bHQsIHdlIG5lZWQgYSBkaXNwYXRjaAogICAgICAqIHNlcmlhbGlzaW5nIGlu c3RydWN0aW9uIGluIHRoZSBlbHNlIGNsYXVzZS4KICAgICAgKi8KLS5MXEBf c2tpcF93cm1zcjoKKy5MXEBfc2tpcF9tc3Jfc3BlY19jdHJsOgogICAgIGxm ZW5jZQogICAgIFVOTElLRUxZX0VORChcQF9zZXJpYWxpc2UpCiAuZW5kbQpA QCAtMzAxLDcgKzMwMSw3IEBAIFVOTElLRUxZX0RJU1BBVENIX0xBQkVMKFxA X3NlcmlhbGlzZSk6CiAgKiBSZXF1aXJlcyAlcmJ4PXN0YWNrX2VuZAogICog Q2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAogICovCi0gICAgdGVzdGIgJFND Rl9pc3Rfd3Jtc3IsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19jdHJsX2Zs YWdzKSglcmJ4KQorICAgIHRlc3RiICRTQ0ZfaXN0X3NjX21zciwgU1RBQ0tf Q1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyYngpCiAgICAganog LkxcQF9za2lwCiAKICAgICBET19TUEVDX0NUUkxfRVhJVF9UT19YRU4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-07.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-07.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIG9wdF9pYnBiIHRv IG9wdF9pYnBiX2N0eHRfc3dpdGNoCgpXZSBhcmUgYWJvdXQgdG8gaW50cm9k dWNlIHRoZSB1c2Ugb2YgSUJQQiBhdCBkaWZmZXJlbnQgcG9pbnRzIGluIFhl biwgbWFraW5nCm9wdF9pYnBiIGFtYmlndW91cy4gIFJlbmFtZSBpdCB0byBv cHRfaWJwYl9jdHh0X3N3aXRjaC4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoK U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKaW5kZXggMzA1YTYzYjY3ZTJk Li4zNjU4ZTUwZDU2YzcgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9kb21h aW4uYworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTE4MTAsNyAr MTgxMCw3IEBAIHZvaWQgY29udGV4dF9zd2l0Y2goc3RydWN0IHZjcHUgKnBy ZXYsIHN0cnVjdCB2Y3B1ICpuZXh0KQogCiAgICAgICAgIGN0eHRfc3dpdGNo X2xldmVsbGluZyhuZXh0KTsKIAotICAgICAgICBpZiAoIG9wdF9pYnBiICYm ICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQorICAgICAgICBpZiAoIG9wdF9p YnBiX2N0eHRfc3dpdGNoICYmICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQog ICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWMgREVGSU5FX1BFUl9DUFUo dW5zaWduZWQgaW50LCBsYXN0KTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCAqbGFzdF9pZCA9ICZ0aGlzX2NwdShsYXN0KTsKZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0 cmwuYwppbmRleCBhNmRlZjQ3MDYxZTguLmNlZDBmOGMyYWVhNiAxMDA2NDQK LS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9zcGVjX2N0cmwuYwpAQCAtNTQsNyArNTQsNyBAQCBpbnQ4X3QgX19p bml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBv cHRfc3NiZDsKIGludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0gLTE7CiAK LWJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYiA9IHRydWU7Citib29sIF9f cmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSB0cnVlOwogaW50 OF90IF9fcmVhZF9tb3N0bHkgb3B0X2VhZ2VyX2ZwdSA9IC0xOwogaW50OF90 IF9fcmVhZF9tb3N0bHkgb3B0X2wxZF9mbHVzaCA9IC0xOwogYm9vbCBfX3Jl YWRfbW9zdGx5IG9wdF9icmFuY2hfaGFyZGVuID0gdHJ1ZTsKQEAgLTExNyw3 ICsxMTcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKIAogICAgICAgICAgICAgb3B0X3RodW5rID0gVEhV TktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMgPSAwOwotICAgICAgICAg ICAgb3B0X2licGIgPSBmYWxzZTsKKyAgICAgICAgICAgIG9wdF9pYnBiX2N0 eHRfc3dpdGNoID0gZmFsc2U7CiAgICAgICAgICAgICBvcHRfc3NiZCA9IGZh bHNlOwogICAgICAgICAgICAgb3B0X2wxZF9mbHVzaCA9IDA7CiAgICAgICAg ICAgICBvcHRfYnJhbmNoX2hhcmRlbiA9IGZhbHNlOwpAQCAtMjM4LDcgKzIz OCw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX3NwZWNfY3RybChjb25z dCBjaGFyICpzKQogCiAgICAgICAgIC8qIE1pc2Mgc2V0dGluZ3MuICovCiAg ICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaWJwYiIs IHMsIHNzKSkgPj0gMCApCi0gICAgICAgICAgICBvcHRfaWJwYiA9IHZhbDsK KyAgICAgICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gdmFsOwogICAg ICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImVhZ2VyLWZw dSIsIHMsIHNzKSkgPj0gMCApCiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1 ID0gdmFsOwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImwxZC1mbHVzaCIsIHMsIHNzKSkgPj0gMCApCkBAIC00NTgsNyArNDU4 LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBp bmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChv cHRfdHN4ICYgMSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBU U1grIiA6ICIgVFNYLSIsCiAgICAgICAgICAgICFjcHVfaGFzX3NyYmRzX2N0 cmwgICAgICAgICAgICAgICAgICAgICAgID8gIiIgOgogICAgICAgICAgICBv cHRfc3JiX2xvY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIg U1JCX0xPQ0srIiA6ICIgU1JCX0xPQ0stIiwKLSAgICAgICAgICAgb3B0X2li cGIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUEIi ICA6ICIiLAorICAgICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCAgICAg ICAgICAgICAgICAgICAgICA/ICIgSUJQQi1jdHh0IiA6ICIiLAogICAgICAg ICAgICBvcHRfbDFkX2ZsdXNoICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA/ICIgTDFEX0ZMVVNIIiA6ICIiLAogICAgICAgICAgICBvcHRfbWRfY2xl YXJfcHYgfHwgb3B0X21kX2NsZWFyX2h2bSB8fAogICAgICAgICAgICBvcHRf ZmJfY2xlYXJfbW1pbyAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVkVS VyIgIDogIiIsCkBAIC0xMTkzLDcgKzExOTMsNyBAQCB2b2lkIF9faW5pdCBp bml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAKICAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KICAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQotICAgICAgICBvcHRfaWJwYiA9IGZhbHNlOworICAgICAgICBvcHRfaWJw Yl9jdHh0X3N3aXRjaCA9IGZhbHNlOwogCiAgICAgLyogQ2hlY2sgd2hldGhl ciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdC4gKi8K ICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggNmY4YjBlMDkzNDhlLi5mZDgx NjJjYTlhYjkgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3Bl Y19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwu aApAQCAtNjMsNyArNjMsNyBAQAogdm9pZCBpbml0X3NwZWN1bGF0aW9uX21p dGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5pdF9kb21haW4o c3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9wdF9pYnBiOwor ZXh0ZXJuIGJvb2wgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9v bCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsKIGV4 dGVybiBpbnQ4X3Qgb3B0X2wxZF9mbHVzaDsK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-08.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-08.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFJfSVNUCgpXZSBhcmUgc2hvcnRseSBnb2luZyB0byBh ZGQgYSBjb25kaXRpb25hbCBJQlBCIGluIHRoaXMgcGF0aC4KClRoZXJlZm9y ZSwgd2UgY2Fubm90IGhvbGQgc3BlY19jdHJsX2ZsYWdzIGluICVlYXgsIGFu ZCByZWx5IG9uIG9ubHkgY2xvYmJlcmluZwppdCBhZnRlciB3ZSdyZSBkb25l IHdpdGggaXRzIGNvbnRlbnRzLiAgJXJieCBpcyBhdmFpbGFibGUgZm9yIHVz ZSwgYW5kIHRoZQptb3JlIG5vcm1hbCByZWdpc3RlciB0byBob2xkIHByZXNl cnZlZCBpbmZvcm1hdGlvbiBpbi4KCldpdGggJXJheCBmcmVlZCB1cCwgdXNl IGl0IGluc3RlYWQgb2YgJXJkeCBmb3IgdGhlIFJTQiB0bXAgcmVnaXN0ZXIs IGFuZCBmb3IKdGhlIGFkanVzdG1lbnQgdG8gc3BlY19jdHJsX2ZsYWdzLgoK VGhpcyBsZWF2ZXMgbm8gdXNlIG9mICVyZHgsIGV4Y2VwdCBhcyAwIGZvciB0 aGUgdXBwZXIgaGFsZiBvZiBXUk1TUi4gIEluCnByYWN0aWNlLCAlcmR4IGlz IDAgZnJvbSBTQVZFX0FMTCBvbiBhbGwgcGF0aHMgYW5kIGlzbid0IGxpa2Vs eSB0byBjaGFuZ2UgaW4KdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSwgc28gdXBk YXRlIHRoZSBtYWNybyBlbnRyeSByZXF1aXJlbWVudHMgdG8gc3RhdGUgdGhp cwpkZXBlbmRlbmN5LiAgVGhpcyBtYXJnaW5hbCBvcHRpbWlzYXRpb24gY2Fu IGJlIHJldmlzaXRlZCBpZiBjaXJjdW1zdGFuY2VzCmNoYW5nZS4KCk5vIHBy YWN0aWNhbCBjaGFuZ2UuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IGNi ZjMzMmU3NTJhOC4uODdiZjljYjY5NDJiIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9lbnRyeS5TCkBAIC04NTQsNyArODU0LDcgQEAgRU5UUlkoZG91YmxlX2Zh dWx0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAKLSAgICAgICAg U1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJl Z3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyYngKQEAgLTg4OSw3ICs4ODksNyBA QCBoYW5kbGVfaXN0X2V4Y2VwdGlvbjoKIAogICAgICAgICBHRVRfU1RBQ0tf RU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJf SVNUIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICov CisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJfSVNUIC8qIFJl cTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhYmNkICov CiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAq YCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBt b3YgICBTVEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4 CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCmlu ZGV4IDBmZjFiMTE4Zjg4Mi4uMTVlMjRjZGUwMGQxIDEwMDY0NAotLS0gYS94 ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaAorKysgYi94ZW4v aW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaApAQCAtMjUxLDM0ICsy NTEsMzMgQEAKICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lO VFJfSVNUCiAvKgotICogUmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNr X2VuZAotICogQ2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAorICogUmVxdWly ZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNrX2VuZCwgJXJkeD0wCisgKiBDbG9i YmVycyAlcmF4LCAlcmJ4LCAlcmN4LCAlcmR4CiAgKgogICogVGhpcyBpcyBs b2dpY2FsIG1lcmdlIG9mIERPX09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNf Q1RSTF9FTlRSWQogICogbWF5YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9u YWxzIHJhdGhlciB0aGFuIGFsdGVybmF0aXZlcy4KICAqLwotICAgIG1vdnpi bCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCks ICVlYXgKKyAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0 cmxfZmxhZ3MpKCVyMTQpLCAlZWJ4CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3Jz YiwgJWFsCisgICAgdGVzdCAkU0NGX2lzdF9yc2IsICVibAogICAgIGp6IC5M XEBfc2tpcF9yc2IKIAotICAgIERPX09WRVJXUklURV9SU0IgdG1wPXJkeCAv KiBDbG9iYmVycyAlcmN4LyVyZHggKi8KKyAgICBET19PVkVSV1JJVEVfUlNC ICAgICAgICAgLyogQ2xvYmJlcnMgJXJheC8lcmN4ICovCiAKIC5MXEBfc2tp cF9yc2I6CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3NjX21zciwgJWFsCisgICAg dGVzdCAkU0NGX2lzdF9zY19tc3IsICVibAogICAgIGp6IC5MXEBfc2tpcF9t c3Jfc3BlY19jdHJsCiAKLSAgICB4b3IgJWVkeCwgJWVkeAorICAgIHhvciAl ZWF4LCAlZWF4CiAgICAgdGVzdGIgJDMsIFVSRUdTX2NzKCVyc3ApCi0gICAg c2V0bnogJWRsCi0gICAgbm90ICVlZHgKLSAgICBhbmQgJWRsLCBTVEFDS19D UFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICBzZXRu eiAlYWwKKyAgICBub3QgJWVheAorICAgIGFuZCAlYWwsIFNUQUNLX0NQVUlO Rk9fRklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KQogCiAgICAgLyogTG9h ZCBYZW4ncyBpbnRlbmRlZCB2YWx1ZS4gKi8KICAgICBtb3YgJE1TUl9TUEVD X0NUUkwsICVlY3gKICAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4 ZW5fc3BlY19jdHJsKSglcjE0KSwgJWVheAotICAgIHhvciAlZWR4LCAlZWR4 CiAgICAgd3Jtc3IKIAogICAgIC8qIE9wZW5jb2RlZCBVTkxJS0VMWV9TVEFS VCgpIHdpdGggbm8gY29uZGl0aW9uLiAqLwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-09.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-09.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3VwcG9ydCBJQlBCLW9uLWVu dHJ5CgpXZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGlzIHRvIG1pdGlnYXRlIEJy YW5jaCBUeXBlIENvbmZ1c2lvbiBvbiBBTUQvSHlnb24gQ1BVcywKYnV0IGFz IHdlJ3ZlIHRhbGtlZCBhYm91dCB1c2luZyBpdCBpbiBvdGhlciBjYXNlcyB0 b28sIGFycmFuZ2UgdG8gc3VwcG9ydCBpdApnZW5lcmFsbHkuICBIb3dldmVy LCB0aGlzIGlzIGFsc28gdmVyeSBleHBlbnNpdmUgaW4gc29tZSBjYXNlcywg c28gd2UncmUgZ29pbmcKdG8gd2FudCBwZXItZG9tYWluIGNvbnRyb2xzLgoK SW50cm9kdWNlIFNDRl9pc3RfaWJwYiBhbmQgU0NGX2VudHJ5X2licGIgY29u dHJvbHMsIGFkZGluZyB0aGVtIHRvIHRoZSBJU1QgYW5kCkRPTSBtYXNrcyBh cyBhcHByb3ByaWF0ZS4gIEFsc28gaW50cm9kdWNlIFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfe1BWLEhWTX0gdG8KdG8gcGF0Y2ggdGhlIGNvZGUgYmxvY2tz LgoKRm9yIFNWTSwgdGhlIFNUR0kgaXMgc2VyaWFsaXNpbmcgZW5vdWdoIHRv IHByb3RlY3QgYWdhaW5zdCBTcGVjdHJlLXYxIGF0dGFja3MsCnNvIG5vICJl bHNlIGxmZW5jZSIgaXMgbmVjZXNzYXJ5LiAgVlQteCB3aWxsIHVzZSB1c2Ug dGhlIE1TUiBob3N0IGxvYWQgbGlzdCwKc28gZG9lc24ndCBuZWVkIGFueSBj b2RlIGluIHRoZSBWTUV4aXQgcGF0aC4KCkZvciB0aGUgSVNUIHBhdGgsIHdl IGNhbid0IHNhZmVseSBjaGVjayBDUEw9PTAgdG8gc2tpcCBhIGZsdXNoLCBh cyB3ZSBtaWdodApoYXZlIGhpdCBhbiBlbnRyeSBwYXRoIGJlZm9yZSBpdCdz IElCUEIuICBBcyBJU1QgaGl0dGluZyBYZW4gaXMgcmFyZSwgZmx1c2gKaXJy ZXNwZWN0aXZlIG9mIENQTC4gIEEgbGF0ZXIgcGF0aCwgU0NGX2lzdF9zY19t c3IsIHByb3ZpZGVzIFNwZWN0cmUtdjEKc2FmZXR5LgoKRm9yIHRoZSBQViBw YXRocywgd2Uga25vdyB3ZSdyZSBpbnRlcnJ1cHRpbmcgQ1BMPjAsIHdoaWxl IGZvciB0aGUgSU5UUiBwYXRocywKd2UgY2FuIHNhZmVseSBjaGVjayBDUEw9 PTAuICBPbmx5IGZsdXNoIHdoZW4gaW50ZXJydXB0aW5nIGd1ZXN0IGNvbnRl eHQuCgpBbiAiZWxzZSBsZmVuY2UiIGlzIG5lZWRlZCBmb3Igc2FmZXR5LCBi dXQgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHNraXAgaXQgb24KdW5hZmZlY3Rl ZCBDUFVzLCBzbyB0aGUgYmxvY2sgd2FudHMgdG8gYmUgYW4gYWx0ZXJuYXRp dmUsIHdoaWNoIG1lYW5zIHRoZQpsZmVuY2UgaGFzIHRvIGJlIGlubGluZSBy YXRoZXIgdGhhbiBVTkxJS0VMWSgpICh0aGUgcmVwbGFjZW1lbnQgYmxvY2sg ZG9lc24ndApoYXZlIGRpc3BsYWNlbWVudHMgZml4ZWQgdXAgZm9yIGFueXRo aW5nIG90aGVyIHRoYW4gdGhlIGZpcnN0IGluc3RydWN0aW9uKS4KCkFzIHdp dGggU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QsICVyZHggaXMgMCBv biBlbnRyeSBzbyByZWx5IG9uIHRoaXMgdG8Kc2hyaW5rIHRoZSBsb2dpYyBt YXJnaW5hbGx5LiAgVXBkYXRlIHRoZSBjb21tZW50cyB0byBzcGVjaWZ5IHRo aXMgbmV3CmRlcGVuZGVuY3kuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9z dm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKaW5k ZXggMDU1ZTZmNDU2NGM2Li43YWFiNjc4OTliZWEgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L2h2bS9zdm0vZW50cnkuUwpAQCAtMTAxLDcgKzEwMSwxOSBAQCBfX1VOTElL RUxZX0VORChuc3ZtX2hhcCkKIAogICAgICAgICBHRVRfQ1VSUkVOVChieCkK IAotICAgICAgICAvKiBTUEVDX0NUUkxfRU5UUllfRlJPTV9TVk0gICAgUmVx OiAlcnNwPXJlZ3MvY3B1aW5mbyAgICAgICAgIENsb2I6IGFjZCAqLworICAg ICAgICAvKiBTUEVDX0NUUkxfRU5UUllfRlJPTV9TVk0gICAgUmVxOiAlcnNw PXJlZ3MvY3B1aW5mbywgJXJkeD0wIENsb2I6IGFjZCAqLworCisgICAgICAg IC5tYWNybyBzdm1fdm1leGl0X2NvbmRfaWJwYgorICAgICAgICAgICAgdGVz dGIgICRTQ0ZfZW50cnlfaWJwYiwgQ1BVSU5GT194ZW5fc3BlY19jdHJsKCVy c3ApCisgICAgICAgICAgICBqeiAgICAgLkxfc2tpcF9pYnBiCisKKyAgICAg ICAgICAgIG1vdiAgICAkTVNSX1BSRURfQ01ELCAlZWN4CisgICAgICAgICAg ICBtb3YgICAgJFBSRURfQ01EX0lCUEIsICVlYXgKKyAgICAgICAgICAgIHdy bXNyCisuTF9za2lwX2licGI6CisJLmVuZG0KKyAgICAgICAgQUxURVJOQVRJ VkUgIiIsIHN2bV92bWV4aXRfY29uZF9pYnBiLCBYODZfRkVBVFVSRV9JQlBC X0VOVFJZX0hWTQorCiAgICAgICAgIEFMVEVSTkFUSVZFICIiLCBET19PVkVS V1JJVEVfUlNCLCBYODZfRkVBVFVSRV9TQ19SU0JfSFZNCiAKICAgICAgICAg Lm1hY3JvIHN2bV92bWV4aXRfc3BlY19jdHJsCkBAIC0xMTgsNiArMTMwLDEw IEBAIF9fVU5MSUtFTFlfRU5EKG5zdm1faGFwKQogICAgICAgICBBTFRFUk5B VElWRSAiIiwgc3ZtX3ZtZXhpdF9zcGVjX2N0cmwsIFg4Nl9GRUFUVVJFX1ND X01TUl9IVk0KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpg LCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCisg ICAgICAgIC8qCisgICAgICAgICAqIFNUR0kgaXMgZXhlY3V0ZWQgdW5jb25k aXRpb25hbGx5LCBhbmQgaXMgc3VmZmljaWVudGx5IHNlcmlhbGlzaW5nCisg ICAgICAgICAqIHRvIHNhZmVseSByZXNvbHZlIGFueSBTcGVjdHJlLXYxIGNv bmNlcm5zIGluIHRoZSBhYm92ZSBsb2dpYy4KKyAgICAgICAgICovCiAgICAg ICAgIFNUR0kKIEdMT0JBTChzdm1fc3RnaV9sYWJlbCkKICAgICAgICAgbW92 ICAlcnNwLCVyZGkKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9odm0vdm14 L3ZtY3MuYyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZtY3MuYwppbmRleCAx NDY2MDY0ZDBjYzkuLjNkMjcxMTc4ZThiYiAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gveDg2L2h2bS92bXgvdm1jcy5jCisrKyBiL3hlbi9hcmNoL3g4Ni9odm0v dm14L3ZtY3MuYwpAQCAtMTMzMiw2ICsxMzMyLDEwIEBAIHN0YXRpYyBpbnQg Y29uc3RydWN0X3ZtY3Moc3RydWN0IHZjcHUgKnYpCiAgICAgICAgIHJjID0g dm14X2FkZF9tc3IodiwgTVNSX0ZMVVNIX0NNRCwgRkxVU0hfQ01EX0wxRCwK ICAgICAgICAgICAgICAgICAgICAgICAgICBWTVhfTVNSX0dVRVNUX0xPQURP TkxZKTsKIAorICAgIGlmICggIXJjICYmIChkLT5hcmNoLnNwZWNfY3RybF9m bGFncyAmIFNDRl9lbnRyeV9pYnBiKSApCisgICAgICAgIHJjID0gdm14X2Fk ZF9tc3IodiwgTVNSX1BSRURfQ01ELCBQUkVEX0NNRF9JQlBCLAorICAgICAg ICAgICAgICAgICAgICAgICAgIFZNWF9NU1JfSE9TVCk7CisKICBvdXQ6CiAg ICAgdm14X3ZtY3NfZXhpdCh2KTsKIApkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L3g4Nl82NC9jb21wYXQvZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni94ODZf NjQvY29tcGF0L2VudHJ5LlMKaW5kZXggYjY3NDY4ZjdjOTM0Li4zMDI1MzBl NjVlMGIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni94ODZfNjQvY29tcGF0 L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82NC9jb21wYXQvZW50 cnkuUwpAQCAtMTgsNyArMTgsNyBAQCBFTlRSWShlbnRyeV9pbnQ4MikKICAg ICAgICAgbW92bCAgJEhZUEVSQ0FMTF9WRUNUT1IsIDQoJXJzcCkKICAgICAg ICAgU0FWRV9BTEwgY29tcGF0PTEgLyogRFBMMSBnYXRlLCByZXN0cmljdGVk IHRvIDMyYml0IFBWIGd1ZXN0cyBvbmx5LiAqLwogCi0gICAgICAgIFNQRUNf Q1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8s IENsb2I6IGFjZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9Q ViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFj ZCAqLwogICAgICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBq bXAgKmAgbm90IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAg ICAgQ1I0X1BWMzJfUkVTVE9SRQpAQCAtMjEyLDcgKzIxMiw3IEBAIEVOVFJZ KGNzdGFyX2VudGVyKQogICAgICAgICBtb3ZsICAkVFJBUF9zeXNjYWxsLCA0 KCVyc3ApCiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xv YjogYWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8q IFJlcTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICov CiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAq YCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBH RVRfU1RBQ0tfRU5EKGJ4KQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4 Nl82NC9lbnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmlu ZGV4IDg3YmY5Y2I2OTQyYi4uMTUzZTg5ZTI0Njk0IDEwMDY0NAotLS0gYS94 ZW4vYXJjaC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L3g4Nl82NC9lbnRyeS5TCkBAIC0yNDgsNyArMjQ4LDcgQEAgRU5UUlkobHN0 YXJfZW50ZXIpCiAgICAgICAgIG1vdmwgICRUUkFQX3N5c2NhbGwsIDQoJXJz cCkKICAgICAgICAgU0FWRV9BTEwKIAotICAgICAgICBTUEVDX0NUUkxfRU5U UllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBDbG9iOiBh Y2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYgLyogUmVx OiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2QgKi8KICAg ICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5v dCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAgIEdFVF9T VEFDS19FTkQoYngpCkBAIC0yODcsNyArMjg3LDcgQEAgR0xPQkFMKHN5c2Vu dGVyX2VmbGFnc19zYXZlZCkKICAgICAgICAgbW92bCAgJFRSQVBfc3lzY2Fs bCwgNCglcnNwKQogICAgICAgICBTQVZFX0FMTAogCi0gICAgICAgIFNQRUNf Q1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8s IENsb2I6IGFjZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9Q ViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFj ZCAqLwogICAgICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBq bXAgKmAgbm90IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAg ICAgR0VUX1NUQUNLX0VORChieCkKQEAgLTMzOSw3ICszMzksNyBAQCBFTlRS WShpbnQ4MF9kaXJlY3RfdHJhcCkKICAgICAgICAgbW92bCAgJDB4ODAsIDQo JXJzcCkKICAgICAgICAgU0FWRV9BTEwKIAotICAgICAgICBTUEVDX0NUUkxf RU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBDbG9i OiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYgLyog UmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2QgKi8K ICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpg IG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAgIEdF VF9TVEFDS19FTkQoYngpCkBAIC02MDAsNyArNjAwLDcgQEAgRU5UUlkoY29t bW9uX2ludGVycnVwdCkKIAogICAgICAgICBHRVRfU1RBQ0tfRU5EKDE0KQog Ci0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFIgLyogUmVxOiAl cnNwPXJlZ3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BF Q19DVFJMX0VOVFJZX0ZST01fSU5UUiAvKiBSZXE6ICVyc3A9cmVncywgJXIx ND1lbmQsICVyZHg9MCwgQ2xvYjogYWNkICovCiAgICAgICAgIC8qIFdBUk5J TkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qgc2FmZSBiZWZvcmUg dGhpcyBwb2ludC4gKi8KIAogICAgICAgICBtb3YgICBTVEFDS19DUFVJTkZP X0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4CkBAIC02MzMsNyArNjMzLDcg QEAgR0xPQkFMKGhhbmRsZV9leGNlcHRpb24pCiAKICAgICAgICAgR0VUX1NU QUNLX0VORCgxNCkKIAotICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9J TlRSIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICov CisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFIgLyogUmVxOiAl cnNwPXJlZ3MsICVyMTQ9ZW5kLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAg ICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90 IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgbW92ICAg U1RBQ0tfQ1BVSU5GT19GSUVMRCh4ZW5fY3IzKSglcjE0KSwgJXJjeApkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9jcHVmZWF0dXJlcy5oCmluZGV4IGY3NDg4 ZDNjY2JmYS4uYjIzM2U1ODM1ZmI1IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVk ZS9hc20teDg2L2NwdWZlYXR1cmVzLmgKKysrIGIveGVuL2luY2x1ZGUvYXNt LXg4Ni9jcHVmZWF0dXJlcy5oCkBAIC0zOSw2ICszOSw4IEBAIFhFTl9DUFVG RUFUVVJFKFhFTl9MQlIsICAgICAgICAgICBYODZfU1lOVEgoMjIpKSAvKiBY ZW4gdXNlcyBNU1JfREVCVUdDVEwuTEJSICovCiBYRU5fQ1BVRkVBVFVSRShT Q19WRVJXX0lETEUsICAgICAgWDg2X1NZTlRIKDI1KSkgLyogVkVSVyB1c2Vk IGJ5IFhlbiBmb3IgaWRsZSAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX1NIU1RL LCAgICAgICAgIFg4Nl9TWU5USCgyNikpIC8qIFhlbiB1c2VzIENFVCBTaGFk b3cgU3RhY2tzICovCiBYRU5fQ1BVRkVBVFVSRShYRU5fSUJULCAgICAgICAg ICAgWDg2X1NZTlRIKDI3KSkgLyogWGVuIHVzZXMgQ0VUIEluZGlyZWN0IEJy YW5jaCBUcmFja2luZyAqLworWEVOX0NQVUZFQVRVUkUoSUJQQl9FTlRSWV9Q ViwgICAgIFg4Nl9TWU5USCgyOCkpIC8qIE1TUl9QUkVEX0NNRCB1c2VkIGJ5 IFhlbiBmb3IgUFYgKi8KK1hFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZN LCAgICBYODZfU1lOVEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBY ZW4gZm9yIEhWTSAqLwogCiAvKiBCdWcgd29yZHMgZm9sbG93IHRoZSBzeW50 aGV0aWMgd29yZHMuICovCiAjZGVmaW5lIFg4Nl9OUl9CVUcgMQpkaWZmIC0t Z2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9p bmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggZmQ4MTYyY2E5YWI5 Li4xMGNkMGNkMjUxOGYgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14 ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVj X2N0cmwuaApAQCAtMzQsNiArMzQsOCBAQAogI2RlZmluZSBTQ0ZfaXN0X3Nj X21zciAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAgICAoMSA8PCAy KQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQorI2RlZmluZSBT Q0ZfaXN0X2licGIgICAoMSA8PCA0KQorI2RlZmluZSBTQ0ZfZW50cnlfaWJw YiAoMSA8PCA1KQogCiAvKgogICogVGhlIElTVCBwYXRocyAoTk1JLyNNQykg Y2FuIGludGVycnVwdCBhbnkgYXJiaXRyYXJ5IGNvbnRleHQuICBTb21lCkBA IC00NiwxMyArNDgsMTMgQEAKICAqIFRoZXNlIGFyZSB0aGUgY29udHJvbHMg dG8gaW5oaWJpdCBvbiB0aGUgUzMgcmVzdW1lIHBhdGggdW50aWwgbWljcm9j b2RlIGhhcwogICogYmVlbiByZWxvYWRlZC4KICAqLwotI2RlZmluZSBTQ0Zf SVNUX01BU0sgKFNDRl9pc3Rfc2NfbXNyKQorI2RlZmluZSBTQ0ZfSVNUX01B U0sgKFNDRl9pc3Rfc2NfbXNyIHwgU0NGX2lzdF9pYnBiKQogCiAvKgogICog U29tZSBzcGVjdWxhdGl2ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4g IFRoZXNlIHNldHRpbmdzIGFyZSBtZXJnZWQKICAqIGludG8gdGhlIHRvcC1v Zi1zdGFjayBibG9jayBpbiB0aGUgY29udGV4dCBzd2l0Y2ggcGF0aC4KICAq LwotI2RlZmluZSBTQ0ZfRE9NX01BU0sgKFNDRl92ZXJ3KQorI2RlZmluZSBT Q0ZfRE9NX01BU0sgKFNDRl92ZXJ3IHwgU0NGX2VudHJ5X2licGIpCiAKICNp Zm5kZWYgX19BU1NFTUJMWV9fCiAKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsX2FzbS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmxfYXNtLmgKaW5kZXggMTVlMjRjZGUwMGQxLi45ZWI0YWQ5 YWI3MWQgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsX2FzbS5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJs X2FzbS5oCkBAIC04OCw2ICs4OCwzNSBAQAogICogIC0gU1BFQ19DVFJMX0VY SVRfVE9fe1NWTSxWTVh9CiAgKi8KIAorLm1hY3JvIERPX1NQRUNfQ1RSTF9D T05EX0lCUEIgbWF5YmV4ZW46cmVxCisvKgorICogUmVxdWlyZXMgJXJzcD1y ZWdzIChhbHNvIGNwdWluZm8gaWYgIW1heWJleGVuKQorICogUmVxdWlyZXMg JXIxND1zdGFja19lbmQgKGlmIG1heWJleGVuKSwgJXJkeD0wCisgKiBDbG9i YmVycyAlcmF4LCAlcmN4LCAlcmR4CisgKgorICogQ29uZGl0aW9uYWxseSBp c3N1ZSBJQlBCIGlmIFNDRl9lbnRyeV9pYnBiIGlzIGFjdGl2ZS4gIEluIHRo ZSBtYXliZXhlbgorICogY2FzZSwgd2UgY2FuIHNhZmVseSBsb29rIGF0IFVS RUdTX2NzIHRvIHNraXAgdGFraW5nIHRoZSBoaXQgd2hlbgorICogaW50ZXJy dXB0aW5nIFhlbi4KKyAqLworICAgIC5pZiBcbWF5YmV4ZW4KKyAgICAgICAg dGVzdGIgICRTQ0ZfZW50cnlfaWJwYiwgU1RBQ0tfQ1BVSU5GT19GSUVMRChz cGVjX2N0cmxfZmxhZ3MpKCVyMTQpCisgICAgICAgIGp6ICAgICAuTFxAX3Nr aXAKKyAgICAgICAgdGVzdGIgICQzLCBVUkVHU19jcyglcnNwKQorICAgIC5l bHNlCisgICAgICAgIHRlc3RiICAkU0NGX2VudHJ5X2licGIsIENQVUlORk9f eGVuX3NwZWNfY3RybCglcnNwKQorICAgIC5lbmRpZgorICAgIGp6ICAgICAu TFxAX3NraXAKKworICAgIG1vdiAgICAgJE1TUl9QUkVEX0NNRCwgJWVjeAor ICAgIG1vdiAgICAgJFBSRURfQ01EX0lCUEIsICVlYXgKKyAgICB3cm1zcgor ICAgIGptcCAgICAgLkxcQF9kb25lCisKKy5MXEBfc2tpcDoKKyAgICBsZmVu Y2UKKy5MXEBfZG9uZToKKy5lbmRtCisKIC5tYWNybyBET19PVkVSV1JJVEVf UlNCIHRtcD1yYXgKIC8qCiAgKiBSZXF1aXJlcyBub3RoaW5nCkBAIC0yMjUs MTIgKzI1NCwxNiBAQAogCiAvKiBVc2UgYWZ0ZXIgYW4gZW50cnkgZnJvbSBQ ViBjb250ZXh0IChzeXNjYWxsL3N5c2VudGVyL2ludDgwL2ludDgyL2V0Yyku ICovCiAjZGVmaW5lIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCisgICAgQUxURVJO QVRJVkUgIiIsIF9fc3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9DT05EX0lCUEIg bWF5YmV4ZW49MCksICAgICBcCisgICAgICAgIFg4Nl9GRUFUVVJFX0lCUEJf RU5UUllfUFY7ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBcCiAgICAgQUxURVJOQVRJVkUgIiIsIERPX09WRVJXUklURV9SU0IsIFg4 Nl9GRUFUVVJFX1NDX1JTQl9QVjsgICAgICAgICAgICBcCiAgICAgQUxURVJO QVRJVkUgIiIsIF9fc3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9FTlRSWSBtYXli ZXhlbj0wKSwgICAgICAgICBcCiAgICAgICAgIFg4Nl9GRUFUVVJFX1NDX01T Ul9QVgogCiAvKiBVc2UgaW4gaW50ZXJydXB0L2V4Y2VwdGlvbiBjb250ZXh0 LiAgTWF5IGludGVycnVwdCBYZW4gb3IgUFYgY29udGV4dC4gKi8KICNkZWZp bmUgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFwKKyAgICBBTFRFUk5BVElWRSAiIiwg X19zdHJpbmdpZnkoRE9fU1BFQ19DVFJMX0NPTkRfSUJQQiBtYXliZXhlbj0x KSwgICAgIFwKKyAgICAgICAgWDg2X0ZFQVRVUkVfSUJQQl9FTlRSWV9QVjsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwKICAgICBB TFRFUk5BVElWRSAiIiwgRE9fT1ZFUldSSVRFX1JTQiwgWDg2X0ZFQVRVUkVf U0NfUlNCX1BWOyAgICAgICAgICAgIFwKICAgICBBTFRFUk5BVElWRSAiIiwg X19zdHJpbmdpZnkoRE9fU1BFQ19DVFJMX0VOVFJZIG1heWJleGVuPTEpLCAg ICAgICAgIFwKICAgICAgICAgWDg2X0ZFQVRVUkVfU0NfTVNSX1BWCkBAIC0y NTQsMTEgKzI4NywyMyBAQAogICogUmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0 PXN0YWNrX2VuZCwgJXJkeD0wCiAgKiBDbG9iYmVycyAlcmF4LCAlcmJ4LCAl cmN4LCAlcmR4CiAgKgotICogVGhpcyBpcyBsb2dpY2FsIG1lcmdlIG9mIERP X09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNfQ1RSTF9FTlRSWQotICogbWF5 YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9uYWxzIHJhdGhlciB0aGFuIGFs dGVybmF0aXZlcy4KKyAqIFRoaXMgaXMgbG9naWNhbCBtZXJnZSBvZjoKKyAq ICAgIERPX1NQRUNfQ1RSTF9DT05EX0lCUEIgbWF5YmV4ZW49MAorICogICAg RE9fT1ZFUldSSVRFX1JTQgorICogICAgRE9fU1BFQ19DVFJMX0VOVFJZIG1h eWJleGVuPTEKKyAqIGJ1dCB3aXRoIGNvbmRpdGlvbmFscyByYXRoZXIgdGhh biBhbHRlcm5hdGl2ZXMuCiAgKi8KICAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5G T19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyMTQpLCAlZWJ4CiAKKyAgICB0 ZXN0ICAgICRTQ0ZfaXN0X2licGIsICVibAorICAgIGp6ICAgICAgLkxcQF9z a2lwX2licGIKKworICAgIG1vdiAgICAgJE1TUl9QUkVEX0NNRCwgJWVjeAor ICAgIG1vdiAgICAgJFBSRURfQ01EX0lCUEIsICVlYXgKKyAgICB3cm1zcgor CisuTFxAX3NraXBfaWJwYjoKKwogICAgIHRlc3QgJFNDRl9pc3RfcnNiLCAl YmwKICAgICBqeiAuTFxAX3NraXBfcnNiCiAK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-10.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-10.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2NwdWlkOiBFbnVtZXJhdGlvbiBmb3IgQlRDX05P CgpCVENfTk8gaW5kaWNhdGVzIHRoYXQgaGFyZHdhcmUgaXMgbm90IHN1Y2Nl cHRhYmxlIHRvIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KClplbjMgQ1BVcyBk b24ndCBzdWZmZXIgQlRDLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcuCgpT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnhsL2xpYnhsX2Nw dWlkLmMgYi90b29scy9saWJ4bC9saWJ4bF9jcHVpZC5jCmluZGV4IDg2Yzhk MjE1NTViYS4uMjU1NzZiNGQ5OTJkIDEwMDY0NAotLS0gYS90b29scy9saWJ4 bC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX2NwdWlk LmMKQEAgLTI4MCw2ICsyODAsNyBAQCBpbnQgbGlieGxfY3B1aWRfcGFyc2Vf Y29uZmlnKGxpYnhsX2NwdWlkX3BvbGljeV9saXN0ICpjcHVpZCwgY29uc3Qg Y2hhciogc3RyKQogICAgICAgICB7InZpcnQtc3NiZCIsICAgIDB4ODAwMDAw MDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyNSwgIDF9LAogICAgICAgICB7InNz Yi1ubyIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAy NiwgIDF9LAogICAgICAgICB7InBzZmQiLCAgICAgICAgIDB4ODAwMDAwMDgs IE5BLCBDUFVJRF9SRUdfRUJYLCAyOCwgIDF9LAorICAgICAgICB7ImJ0Yy1u byIsICAgICAgIDB4ODAwMDAwMDgsIE5BLCBDUFVJRF9SRUdfRUJYLCAyOSwg IDF9LAogCiAgICAgICAgIHsibmMiLCAgICAgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQ1gsICAwLCAgOH0sCiAgICAgICAgIHsiYXBpY2lk c2l6ZSIsICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQ1gsIDEyLCAg NH0sCmRpZmYgLS1naXQgYS90b29scy9taXNjL3hlbi1jcHVpZC5jIGIvdG9v bHMvbWlzYy94ZW4tY3B1aWQuYwppbmRleCA3ZWJmNTIwYTcxNzEuLmU1MjA4 Y2ZhNDUzOCAxMDA2NDQKLS0tIGEvdG9vbHMvbWlzYy94ZW4tY3B1aWQuYwor KysgYi90b29scy9taXNjL3hlbi1jcHVpZC5jCkBAIC0xNTcsNyArMTU3LDcg QEAgc3RhdGljIGNvbnN0IGNoYXIgKmNvbnN0IHN0cl9lOGJbMzJdID0KICAg ICAvKiBbMjJdICovICAgICAgICAgICAgICAgICBbMjNdID0gInBwaW4iLAog ICAgIFsyNF0gPSAiYW1kLXNzYmQiLCAgICAgICAgIFsyNV0gPSAidmlydC1z c2JkIiwKICAgICBbMjZdID0gInNzYi1ubyIsCi0gICAgWzI4XSA9ICJwc2Zk IiwKKyAgICBbMjhdID0gInBzZmQiLCAgICAgICAgICAgICBbMjldID0gImJ0 Yy1ubyIsCiB9OwogCiBzdGF0aWMgY29uc3QgY2hhciAqY29uc3Qgc3RyXzdk MFszMl0gPQpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2NwdS9hbWQuYyBi L3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKaW5kZXggMTQyZjM0YWY1ZjcwLi43 NDA5YWY5OGY2MzMgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9jcHUvYW1k LmMKKysrIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpAQCAtODIyLDYgKzgy MiwxNiBAQCBzdGF0aWMgdm9pZCBpbml0X2FtZChzdHJ1Y3QgY3B1aW5mb194 ODYgKmMpCiAJCQl3YXJuaW5nX2FkZCh0ZXh0KTsKIAkJfQogCQlicmVhazsK KworCWNhc2UgMHgxOToKKwkJLyoKKwkJICogWmVuMyAoRmFtMTloIG1vZGVs IDwgMHgxMCkgcGFydHMgYXJlIG5vdCBzdXNjZXB0aWJsZSB0bworCQkgKiBC cmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBwcmVkYXRlIHRoZSBhbGxvY2F0 aW9uIG9mIHRoZQorCQkgKiBCVENfTk8gYml0LiAgRmlsbCBpdCBiYWNrIGlu IGlmIHdlJ3JlIG5vdCB2aXJ0dWFsaXNlZC4KKwkJICovCisJCWlmICghY3B1 X2hhc19oeXBlcnZpc29yICYmICFjcHVfaGFzKGMsIFg4Nl9GRUFUVVJFX0JU Q19OTykpCisJCQlfX3NldF9iaXQoWDg2X0ZFQVRVUkVfQlRDX05PLCBjLT54 ODZfY2FwYWJpbGl0eSk7CisJCWJyZWFrOwogCX0KIAogCWRpc3BsYXlfY2Fj aGVpbmZvKGMpOwpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3Ry bC5jIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCmluZGV4IGNlZDBmOGMy YWVhNi4uOWY2NmM3MTU1MTZjIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMKKysrIGIveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBA IC0zODgsNyArMzg4LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2Rl dGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAg ICAgICogSGFyZHdhcmUgcmVhZC1vbmx5IGluZm9ybWF0aW9uLCBzdGF0aW5n IGltbXVuaXR5IHRvIGNlcnRhaW4gaXNzdWVzLCBvcgogICAgICAqIHN1Z2dl c3Rpb25zIG9mIHdoaWNoIG1pdGlnYXRpb24gdG8gdXNlLgogICAgICAqLwot ICAgIHByaW50aygiICBIYXJkd2FyZSBoaW50czolcyVzJXMlcyVzJXMlcyVz JXMlcyVzJXMlcyVzXG4iLAorICAgIHByaW50aygiICBIYXJkd2FyZSBoaW50 czolcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCiAgICAgICAg ICAgIChjYXBzICYgQVJDSF9DQVBTX1JEQ0xfTk8pICAgICAgICAgICAgICAg ICAgICAgICAgPyAiIFJEQ0xfTk8iICAgICAgICA6ICIiLAogICAgICAgICAg ICAoY2FwcyAmIEFSQ0hfQ0FQU19JQlJTX0FMTCkgICAgICAgICAgICAgICAg ICAgICAgID8gIiBJQlJTX0FMTCIgICAgICAgOiAiIiwKICAgICAgICAgICAg KGNhcHMgJiBBUkNIX0NBUFNfUlNCQSkgICAgICAgICAgICAgICAgICAgICAg ICAgICA/ICIgUlNCQSIgICAgICAgICAgIDogIiIsCkBAIC00MDMsNyArNDAz LDggQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBp bmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChl OGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNfQUxXQVlTKSkg ICAgPyAiIElCUlNfQUxXQVlTIiAgICA6ICIiLAogICAgICAgICAgICAoZThi ICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9TVElCUF9BTFdBWVMpKSAg ID8gIiBTVElCUF9BTFdBWVMiICAgOiAiIiwKICAgICAgICAgICAgKGU4YiAg JiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19GQVNUKSkgICAgICA/ ICIgSUJSU19GQVNUIiAgICAgIDogIiIsCi0gICAgICAgICAgIChlOGIgICYg Y3B1ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0lCUlNfU0FNRV9NT0RFKSkgPyAi IElCUlNfU0FNRV9NT0RFIiA6ICIiKTsKKyAgICAgICAgICAgKGU4YiAgJiBj cHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIg SUJSU19TQU1FX01PREUiIDogIiIsCisgICAgICAgICAgIChlOGIgICYgY3B1 ZmVhdF9tYXNrKFg4Nl9GRUFUVVJFX0JUQ19OTykpICAgICAgICAgPyAiIEJU Q19OTyIgICAgICAgICA6ICIiKTsKIAogICAgIC8qIEhhcmR3YXJlIGZlYXR1 cmVzIHdoaWNoIG5lZWQgZHJpdmluZyB0byBtaXRpZ2F0ZSBpc3N1ZXMuICov CiAgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGZlYXR1cmVzOiVzJXMlcyVzJXMl cyVzJXMlcyVzJXMlc1xuIiwKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL3B1 YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmggYi94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCmluZGV4IGM1YWY2ZjAz Y2ZmNi4uNzQ2YTc1MjAwYWI4IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9w dWJsaWMvYXJjaC14ODYvY3B1ZmVhdHVyZXNldC5oCisrKyBiL3hlbi9pbmNs dWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJlc2V0LmgKQEAgLTI2NCw2 ICsyNjQsNyBAQCBYRU5fQ1BVRkVBVFVSRShBTURfU1NCRCwgICAgICA4KjMy KzI0KSAvKlMgIE1TUl9TUEVDX0NUUkwuU1NCRCBhdmFpbGFibGUgKi8KIFhF Tl9DUFVGRUFUVVJFKFZJUlRfU1NCRCwgICAgIDgqMzIrMjUpIC8qICAgTVNS X1ZJUlRfU1BFQ19DVFJMLlNTQkQgKi8KIFhFTl9DUFVGRUFUVVJFKFNTQl9O TywgICAgICAgIDgqMzIrMjYpIC8qQSAgSGFyZHdhcmUgbm90IHZ1bG5lcmFi bGUgdG8gU1NCICovCiBYRU5fQ1BVRkVBVFVSRShQU0ZELCAgICAgICAgICA4 KjMyKzI4KSAvKlMgIE1TUl9TUEVDX0NUUkwuUFNGRCAqLworWEVOX0NQVUZF QVRVUkUoQlRDX05PLCAgICAgICAgOCozMisyOSkgLypBICBIYXJkd2FyZSBu b3QgdnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24gKi8KIAog LyogSW50ZWwtZGVmaW5lZCBDUFUgZmVhdHVyZXMsIENQVUlEIGxldmVsIDB4 MDAwMDAwMDc6MC5lZHgsIHdvcmQgOSAqLwogWEVOX0NQVUZFQVRVUkUoQVZY NTEyXzRWTk5JVywgOSozMisgMikgLypBICBBVlg1MTIgTmV1cmFsIE5ldHdv cmsgSW5zdHJ1Y3Rpb25zICovCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-11.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-11.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW5hYmxlIFplbjIgY2hpY2tl bmJpdAoKLi4uIGFzIGluc3RydWN0ZWQgaW4gdGhlIEJyYW5jaCBUeXBlIENv bmZ1c2lvbiB3aGl0ZXBhcGVyLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2FtZC5jCmluZGV4IDc0MDlhZjk4 ZjYzMy4uZjUwZjkxZjgxZWI5IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKQEAgLTcz MSw2ICs3MzEsMzEgQEAgdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYykKIAkJcHJpbnRrX29uY2UoWEVOTE9HX0VSUiAi Tm8gU1NCRCBjb250cm9scyBhdmFpbGFibGVcbiIpOwogfQogCisvKgorICog T24gWmVuMiB3ZSBvZmZlciB0aGlzIGNoaWNrZW4gKGJpdCkgb24gdGhlIGFs dGFyIG9mIFNwZWN1bGF0aW9uLgorICoKKyAqIFJlZmVyIHRvIHRoZSBBTUQg QnJhbmNoIFR5cGUgQ29uZnVzaW9uIHdoaXRlcGFwZXI6CisgKiBodHRwczov L1hYWAorICoKKyAqIFNldHRpbmcgdGhpcyB1bm5hbWVkIGJpdCBzdXBwb3Nl ZGx5IGNhdXNlcyBwcmVkaWN0aW9uIGluZm9ybWF0aW9uIG9uCisgKiBub24t YnJhbmNoIGluc3RydWN0aW9ucyB0byBiZSBpZ25vcmVkLiAgSXQgaXMgdG8g YmUgc2V0IHVuaWxhdGVyYWxseSBpbgorICogbmV3ZXIgbWljcm9jb2RlLgor ICoKKyAqIFRoaXMgY2hpY2tlbmJpdCBpcyBzb21ldGhpbmcgdW5yZWxhdGVk IG9uIFplbjEsIGFuZCBaZW4xIHZzIFplbjIgaXNuJ3QgYQorICogc2ltcGxl IG1vZGVsIG51bWJlciBjb21wYXJpc29uLCBzbyB1c2UgU1RJQlAgYXMgYSBo ZXVyaXN0aWMgdG8gc2VwYXJhdGUgdGhlCisgKiB0d28gdWFyY2hlcyBpbiBG YW0xN2goQU1EKS8xOGgoSHlnb24pLgorICovCit2b2lkIGFtZF9pbml0X3Nw ZWN0cmFsX2NoaWNrZW4odm9pZCkKK3sKKwl1aW50NjRfdCB2YWwsIGNoaWNr ZW5iaXQgPSAxIDw8IDE7CisKKwlpZiAoY3B1X2hhc19oeXBlcnZpc29yIHx8 ICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkKKwkJcmV0 dXJuOworCisJaWYgKHJkbXNyX3NhZmUoTVNSX0FNRDY0X0RFX0NGRzIsIHZh bCkgPT0gMCAmJiAhKHZhbCAmIGNoaWNrZW5iaXQpKQorCQl3cm1zcl9zYWZl KE1TUl9BTUQ2NF9ERV9DRkcyLCB2YWwgfCBjaGlja2VuYml0KTsKK30KKwog c3RhdGljIHZvaWQgaW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKQog ewogCXUzMiBsLCBoOwpAQCAtNzgzLDYgKzgwOCw5IEBAIHN0YXRpYyB2b2lk IGluaXRfYW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAogCWFtZF9pbml0 X3NzYmQoYyk7CiAKKwlpZiAoYy0+eDg2ID09IDB4MTcpCisJCWFtZF9pbml0 X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwogCS8qIE1GRU5DRSBzdG9wcyBSRFRT QyBzcGVjdWxhdGlvbiAqLwogCWlmICghY3B1X2hhc19sZmVuY2VfZGlzcGF0 Y2gpCiAJCV9fc2V0X2JpdChYODZfRkVBVFVSRV9NRkVOQ0VfUkRUU0MsIGMt Png4Nl9jYXBhYmlsaXR5KTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvY3B1LmggYi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCmluZGV4IDFhNWIz OTE4YjM3ZS4uZTc2YWI1Y2UxYWUyIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94 ODYvY3B1L2NwdS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvY3B1LmgKQEAg LTIyLDMgKzIyLDQgQEAgdm9pZCBlYXJseV9pbml0X2FtZChzdHJ1Y3QgY3B1 aW5mb194ODYgKmMpOwogdm9pZCBhbWRfbG9nX2ZyZXEoY29uc3Qgc3RydWN0 IGNwdWluZm9feDg2ICpjKTsKIHZvaWQgYW1kX2luaXRfbGZlbmNlKHN0cnVj dCBjcHVpbmZvX3g4NiAqYyk7CiB2b2lkIGFtZF9pbml0X3NzYmQoY29uc3Qg c3RydWN0IGNwdWluZm9feDg2ICpjKTsKK3ZvaWQgYW1kX2luaXRfc3BlY3Ry YWxfY2hpY2tlbih2b2lkKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvaHlnb24uYyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYwppbmRleCAz ODQ1ZTBjZjBlODkuLjBjYjBlN2Q1NWU2MSAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gveDg2L2NwdS9oeWdvbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHln b24uYwpAQCAtMzYsNiArMzYsMTIgQEAgc3RhdGljIHZvaWQgaW5pdF9oeWdv bihzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAKIAlhbWRfaW5pdF9zc2JkKGMp OwogCisJLyoKKwkgKiBUT0RPOiBDaGVjayBoZXVyaXN0aWMgc2FmZXR5IHdp dGggSHlnb24gZmlyc3QKKwlpZiAoYy0+eDg2ID09IDB4MTgpCisJCWFtZF9p bml0X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwkgKi8KKwogCS8qIE1GRU5DRSBz dG9wcyBSRFRTQyBzcGVjdWxhdGlvbiAqLwogCWlmICghY3B1X2hhc19sZmVu Y2VfZGlzcGF0Y2gpCiAJCV9fc2V0X2JpdChYODZfRkVBVFVSRV9NRkVOQ0Vf UkRUU0MsIGMtPng4Nl9jYXBhYmlsaXR5KTsKZGlmZiAtLWdpdCBhL3hlbi9p bmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmggYi94ZW4vaW5jbHVkZS9hc20t eDg2L21zci1pbmRleC5oCmluZGV4IGM4NjcwZWFiOGVmNS4uNGMxY2JhNTg5 ZDA4IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L21zci1pbmRl eC5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmgKQEAg LTM1OSw2ICszNTksNyBAQAogI2RlZmluZSBNU1JfQU1ENjRfRENfQ0ZHCQkw eGMwMDExMDIyCiAjZGVmaW5lIE1TUl9BTUQ2NF9ERV9DRkcJCTB4YzAwMTEw MjkKICNkZWZpbmUgQU1ENjRfREVfQ0ZHX0xGRU5DRV9TRVJJQUxJU0UJKF9B QygxLCBVTEwpIDw8IDEpCisjZGVmaW5lIE1TUl9BTUQ2NF9ERV9DRkcyCQkw eGMwMDExMGUzCiAKICNkZWZpbmUgTVNSX0FNRDY0X0RSMF9BRERSRVNTX01B U0sJMHhjMDAxMTAyNwogI2RlZmluZSBNU1JfQU1ENjRfRFIxX0FERFJFU1Nf TUFTSwkweGMwMDExMDE5Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.14-12.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.14-12.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQnJhbmNoIFR5 cGUgQ29uZnVzaW9uIHdoZW4gcG9zc2libGUKCkJyYW5jaCBUeXBlIENvbmZ1 c2lvbiBhZmZlY3RzIEFNRC9IeWdvbiBDUFVzIG9uIFplbjIgYW5kIGVhcmxp ZXIuICBUbwptaXRpZ2F0ZSwgd2UgcmVxdWlyZSBTTVQgc2FmZXR5IChTVElC UCBvbiBaZW4yLCBuby1TTVQgb24gWmVuMSksIGFuZCB0byBpc3N1ZQphbiBJ QlBCIG9uIGVhY2ggZW50cnkgdG8gWGVuLCB0byBmbHVzaCB0aGUgQlRCLgoK RHVlIHRvIHBlcmZvcm1hbmNlIGNvbmNlcm5zLCBkb20wICh3aGljaCBpcyB0 cnVzdGVkIGluIG1vc3QgY29uZmlndXJhdGlvbnMpIGlzCmV4Y2x1ZGVkIGZy b20gcHJvdGVjdGlvbnMgYnkgZGVmYXVsdC4KClRoZXJlZm9yZToKICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgb24gWmVuMiB0b28sIHdoaWNoIG5vdyBtZWFu cyB3ZSB3YW50IGl0IG9uIGJ5IGRlZmF1bHQKICAgb24gYWxsIGhhcmR3YXJl IHN1cHBvcnRpbmcgU1RJQlAuCiAqIEJyZWFrIHRoZSBjdXJyZW50IElCUEIg bG9naWMgb3V0IGludG8gYSBuZXcgZnVuY3Rpb24sIGV4dGVuZGluZyBpdCB3 aXRoCiAgIElCUEItYXQtZW50cnkgbG9naWMuCiAqIENoYW5nZSB0aGUgZXhp c3RpbmcgSUJQQi1hdC1jdHh0LXN3aXRjaCBib29sZWFuIHRvIGJlIHRyaXN0 YXRlLCBhbmQgZGlzYWJsZQogICBpdCBieSBkZWZhdWx0IHdoZW4gSUJQQi1h dC1lbnRyeSBpcyBwcm92aWRpbmcgc3VmZmljaWVudCBzYWZldHkuCgpJZiBh bGwgUFYgZ3Vlc3RzIG9uIHRoZSBzeXN0ZW0gYXJlIHRydXN0ZWQsIHRoZW4g aXQgaXMgcmVjb21tZW5kZWQgdG8gYm9vdAp3aXRoIGBzcGVjLWN0cmw9aWJw Yi1lbnRyeT1uby1wdmAsIGFzIHRoaXMgd2lsbCBwcm92aWRlIGFuIGFkZGl0 aW9uYWwgbWFyZ2luYWwKcGVyZiBpbXByb3ZlbWVudC4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDA3IC8gQ1ZFLTIwMjItMjM4MjUuCgpTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoK ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRv YyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYwppbmRleCBh ODRmNWMxOTIxOGQuLmYxMzMwNGVmNGViMSAxMDA2NDQKLS0tIGEvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCisrKyBiL2RvY3MvbWlzYy94 ZW4tY29tbWFuZC1saW5lLnBhbmRvYwpAQCAtMjEwNSw3ICsyMTA1LDcgQEAg QnkgZGVmYXVsdCBTU0JEIHdpbGwgYmUgbWl0aWdhdGVkIGF0IHJ1bnRpbWUg KGkuZSBgc3NiZD1ydW50aW1lYCkuCiAKICMjIyBzcGVjLWN0cmwgKHg4NikK ID4gYD0gTGlzdCBvZiBbIDxib29sPiwgeGVuPTxib29sPiwge3B2LGh2bX09 PGJvb2w+LAotPiAgICAgICAgICAgICAge21zci1zYyxyc2IsbWQtY2xlYXJ9 PTxib29sPnx7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAgICAgICB7bXNy LXNjLHJzYixtZC1jbGVhcixpYnBiLWVudHJ5fT08Ym9vbD58e3B2LGh2bX09 PGJvb2w+LAogPiAgICAgICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxs ZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQscHNmZCwKID4gICAgICAgICAg ICAgIGVhZ2VyLWZwdSxsMWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9j aywKID4gICAgICAgICAgICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKQEAg LTIxMzAsOSArMjEzMCwxMCBAQCBpbiBwbGFjZSBmb3IgZ3Vlc3RzIHRvIHVz ZS4KIAogVXNlIG9mIGEgcG9zaXRpdmUgYm9vbGVhbiB2YWx1ZSBmb3IgZWl0 aGVyIG9mIHRoZXNlIG9wdGlvbnMgaXMgaW52YWxpZC4KIAotVGhlIGBwdj1g LCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gIGFuZCBgbWQtY2xlYXI9YCBv cHRpb25zIG9mZmVyIGZpbmUKLWdyYWluZWQgY29udHJvbCBvdmVyIHRoZSBw cmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGltcGFjdCBYZW4ncyBhYmlsaXR5 IHRvCi1wcm90ZWN0IGl0c2VsZiwgYW5kL29yIFhlbidzIGFiaWxpdHkgdG8g dmlydHVhbGlzZSBzdXBwb3J0IGZvciBndWVzdHMgdG8gdXNlLgorVGhlIGBw dj1gLCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gLCBgbWQtY2xlYXI9YCBh bmQgYGlicGItZW50cnk9YCBvcHRpb25zCitvZmZlciBmaW5lIGdyYWluZWQg Y29udHJvbCBvdmVyIHRoZSBwcmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGlt cGFjdCBYZW4ncworYWJpbGl0eSB0byBwcm90ZWN0IGl0c2VsZiwgYW5kL29y IFhlbidzIGFiaWxpdHkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgorZ3Vl c3RzIHRvIHVzZS4KIAogKiBgcHY9YCBhbmQgYGh2bT1gIG9mZmVyIGNvbnRy b2wgb3ZlciBhbGwgc3Vib3B0aW9ucyBmb3IgUFYgYW5kIEhWTSBndWVzdHMK ICAgcmVzcGVjdGl2ZWx5LgpAQCAtMjE1MSw2ICsyMTUyLDExIEBAIHByb3Rl Y3QgaXRzZWxmLCBhbmQvb3IgWGVuJ3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNl IHN1cHBvcnQgZm9yIGd1ZXN0cyB0byB1c2UuCiAgIGNvbXBhdGliaWxpdHkg d2l0aCBkZXZlbG9wbWVudCB2ZXJzaW9ucyBvZiB0aGlzIGZpeCwgYG1kcz1g IGlzIGFsc28gYWNjZXB0ZWQKICAgb24gWGVuIDQuMTIgYW5kIGVhcmxpZXIg YXMgYW4gYWxpYXMuICBDb25zdWx0IHZlbmRvciBkb2N1bWVudGF0aW9uIGlu CiAgIHByZWZlcmVuY2UgdG8gaGVyZS4qCisqIGBpYnBiLWVudHJ5PWAgb2Zm ZXJzIGNvbnRyb2wgb3ZlciB3aGV0aGVyIElCUEIgKEluZGlyZWN0IEJyYW5j aCBQcmVkaWN0aW9uCisgIEJhcnJpZXIpIGlzIHVzZWQgb24gZW50cnkgdG8g WGVuLiAgVGhpcyBpcyB1c2VkIGJ5IGRlZmF1bHQgb24gaGFyZHdhcmUKKyAg dnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucywgZG9tMCBpcworICB1bnByb3RlY3RlZCBi eSBkZWZhdWx0LiAgSWYgaXQgbmVjZXNzYXJ5IHRvIHByb3RlY3QgZG9tMCB0 b28sIGJvb3Qgd2l0aAorICBgc3BlYy1jdHJsPWlicGItZW50cnlgLgogCiBJ ZiBYZW4gd2FzIGNvbXBpbGVkIHdpdGggSU5ESVJFQ1RfVEhVTksgc3VwcG9y dCwgYGJ0aS10aHVuaz1gIGNhbiBiZSB1c2VkIHRvCiBzZWxlY3Qgd2hpY2gg b2YgdGhlIHRodW5rcyBnZXRzIHBhdGNoZWQgaW50byB0aGUgYF9feDg2X2lu ZGlyZWN0X3RodW5rXyVyZWdgCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXgg OWY2NmM3MTU1MTZjLi41NjM1MTljZTBlMzEgMTAwNjQ0Ci0tLSBhL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKQEAgLTM5LDYgKzM5LDEwIEBAIHN0YXRpYyBib29sIF9faW5pdGRh dGEgb3B0X3JzYl9odm0gPSB0cnVlOwogc3RhdGljIGludDhfdCBfX3JlYWRf bW9zdGx5IG9wdF9tZF9jbGVhcl9wdiA9IC0xOwogc3RhdGljIGludDhfdCBf X3JlYWRfbW9zdGx5IG9wdF9tZF9jbGVhcl9odm0gPSAtMTsKIAorc3RhdGlj IGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBiX2VudHJ5X3B2ID0gLTE7 CitzdGF0aWMgaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJfZW50cnlf aHZtID0gLTE7CitzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBi X2VudHJ5X2RvbTA7CisKIC8qIENtZGxpbmUgY29udHJvbHMgZm9yIFhlbidz IHNwZWN1bGF0aXZlIHNldHRpbmdzLiAqLwogc3RhdGljIGVudW0gaW5kX3Ro dW5rIHsKICAgICBUSFVOS19ERUZBVUxULCAvKiBEZWNpZGUgd2hpY2ggdGh1 bmsgdG8gdXNlIGF0IGJvb3QgdGltZS4gKi8KQEAgLTU0LDcgKzU4LDcgQEAg aW50OF90IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7CiBib29sIF9fcmVh ZF9tb3N0bHkgb3B0X3NzYmQ7CiBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfcHNm ZCA9IC0xOwogCi1ib29sIF9fcmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9z d2l0Y2ggPSB0cnVlOworaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJf Y3R4dF9zd2l0Y2ggPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9l YWdlcl9mcHUgPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9sMWRf Zmx1c2ggPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBvcHRfYnJhbmNoX2hh cmRlbiA9IHRydWU7CkBAIC0xMTQsNiArMTE4LDkgQEAgc3RhdGljIGludCBf X2luaXQgcGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAg ICAgICBvcHRfcnNiX2h2bSA9IGZhbHNlOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX3B2ID0gMDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0g PSAwOworICAgICAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAwOworICAg ICAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gMDsKKyAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKIAogICAgICAgICAgICAg b3B0X3RodW5rID0gVEhVTktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMg PSAwOwpAQCAtMTQwLDEyICsxNDcsMTQgQEAgc3RhdGljIGludCBfX2luaXQg cGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAgICAgICBv cHRfbXNyX3NjX3B2ID0gdmFsOwogICAgICAgICAgICAgb3B0X3JzYl9wdiA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9wdiA9IHZhbDsKKyAg ICAgICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gdmFsOwogICAgICAgICB9 CiAgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaHZt Iiwgcywgc3MpKSA+PSAwICkKICAgICAgICAgewogICAgICAgICAgICAgb3B0 X21zcl9zY19odm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfcnNiX2h2bSA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0gPSB2YWw7Cisg ICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9odm0gPSB2YWw7CiAgICAgICAg IH0KICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJt c3Itc2MiLCBzLCBzcykpICE9IC0xICkKICAgICAgICAgewpAQCAtMjEwLDYg KzIxOSwyOCBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQorICAgICAgICBlbHNlIGlmICggKHZhbCA9 IHBhcnNlX2Jvb2xlYW4oImlicGItZW50cnkiLCBzLCBzcykpICE9IC0xICkK KyAgICAgICAgeworICAgICAgICAgICAgc3dpdGNoICggdmFsICkKKyAgICAg ICAgICAgIHsKKyAgICAgICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAgIGNh c2UgMToKKyAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IG9w dF9pYnBiX2VudHJ5X2h2bSA9CisgICAgICAgICAgICAgICAgICAgIG9wdF9p YnBiX2VudHJ5X2RvbTAgPSB2YWw7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisKKyAgICAgICAgICAgIGNhc2UgLTI6CisgICAgICAgICAgICAgICAgcyAr PSBzdHJsZW4oImlicGItZW50cnk9Iik7CisgICAgICAgICAgICAgICAgaWYg KCAodmFsID0gcGFyc2VfYm9vbGVhbigicHYiLCBzLCBzcykpID49IDAgKQor ICAgICAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IHZhbDsK KyAgICAgICAgICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImh2bSIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAg ICByYyA9IC1FSU5WQUw7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB9CisgICAgICAgIH0KIAogICAgICAgICAvKiBYZW4ncyBzcGVj dWxhdGl2ZSBzaWRlY2hhbm5lbCBtaXRpZ2F0aW9uIHNldHRpbmdzLiAqLwog ICAgICAgICBlbHNlIGlmICggIXN0cm5jbXAocywgImJ0aS10aHVuaz0iLCAx MCkgKQpAQCAtNDc3LDI3ICs1MDgsMzEgQEAgc3RhdGljIHZvaWQgX19pbml0 IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90 IGNhcHMpCiAgICAgICogbWl0aWdhdGlvbiBzdXBwb3J0IGZvciBndWVzdHMu CiAgICAgICovCiAjaWZkZWYgQ09ORklHX0hWTQotICAgIHByaW50aygiICBT dXBwb3J0IGZvciBIVk0gVk1zOiVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRr KCIgIFN1cHBvcnQgZm9yIEhWTSBWTXM6JXMlcyVzJXMlcyVzXG4iLAogICAg ICAgICAgICAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9IVk0p IHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0Nf UlNCX0hWTSkgfHwKICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVB VFVSRV9NRF9DTEVBUikgICB8fAorICAgICAgICAgICAgYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfSFZNKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTSkgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9IVk0pICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICNlbmRpZgogI2lmZGVmIENPTkZJR19QVgotICAgIHByaW50 aygiICBTdXBwb3J0IGZvciBQViBWTXM6JXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgU3VwcG9ydCBmb3IgUFYgVk1zOiVzJXMlcyVzJXMlc1xuIiwK ICAgICAgICAgICAgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19NU1Jf UFYpIHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVf U0NfUlNCX1BWKSB8fAogICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX01EX0NMRUFSKSAgfHwKKyAgICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9JQlBCX0VOVFJZX1BWKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX1BWKSAgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9QVikgICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9QVikgICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICAgICBwcmludGsoIiAgWFBUSSAoNjQtYml0IFBWIG9ubHkp OiBEb20wICVzLCBEb21VICVzICh3aXRoJXMgUENJRClcbiIsCiAgICAgICAg ICAgIG9wdF94cHRpX2h3ZG9tID8gImVuYWJsZWQiIDogImRpc2FibGVkIiwK QEAgLTczMCw2ICs3NjUsNTUgQEAgc3RhdGljIGJvb2wgX19pbml0IHNob3Vs ZF91c2VfZWFnZXJfZnB1KHZvaWQpCiAgICAgfQogfQogCitzdGF0aWMgdm9p ZCBfX2luaXQgaWJwYl9jYWxjdWxhdGlvbnModm9pZCkKK3sKKyAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KKyAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQorICAgIHsKKyAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gb3B0X2li cGJfZW50cnlfcHYgPSBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9IDA7CisgICAg ICAgIG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworICAgIC8qCisgICAgICogSUJQQi1vbi1lbnRyeSBt aXRpZ2F0aW9ucyBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgorICAgICAq CisgICAgICogSUJQQiAmJiAhQlRDX05PIHNlbGVjdHMgYWxsIEFNRC9IeWdv biBoYXJkd2FyZSwgbm90IGtub3duIHRvIGJlIHNhZmUsCisgICAgICogdGhh dCB3ZSBjYW4gcHJvdmlkZSBzb21lIGZvcm0gb2YgbWl0aWdhdGlvbiBvbi4K KyAgICAgKi8KKyAgICBpZiAoIG9wdF9pYnBiX2VudHJ5X3B2ID09IC0xICkK KyAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAoSVNfRU5BQkxFRChDT05G SUdfUFYpICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0JUQ19O TykpOworICAgIGlmICggb3B0X2licGJfZW50cnlfaHZtID09IC0xICkKKyAg ICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gKElTX0VOQUJMRUQoQ09ORklH X0hWTSkgJiYKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9CVENf Tk8pKTsKKworICAgIGlmICggb3B0X2licGJfZW50cnlfcHYgKQorICAgIHsK KyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9JQlBC X0VOVFJZX1BWKTsKKworICAgICAgICAvKgorICAgICAgICAgKiBXZSBvbmx5 IG5lZWQgdG8gZmx1c2ggaW4gSVNUIGNvbnRleHQgaWYgd2UncmUgcHJvdGVj dGluZyBhZ2FpbnN0IFBWCisgICAgICAgICAqIGd1ZXN0cy4gIEhWTSBJQlBC LW9uLWVudHJ5IHByb3RlY3Rpb25zIGFyZSBib3RoIGF0b21pYyB3aXRoCisg ICAgICAgICAqIE5NSS8jTUMsIHNvIGNhbid0IGludGVycnVwdCBYZW4gYWhl YWQgb2YgaGF2aW5nIGFscmVhZHkgZmx1c2hlZCB0aGUKKyAgICAgICAgICog QlRCLgorICAgICAgICAgKi8KKyAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxf ZmxhZ3MgfD0gU0NGX2lzdF9pYnBiOworICAgIH0KKyAgICBpZiAoIG9wdF9p YnBiX2VudHJ5X2h2bSApCisgICAgICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAo WDg2X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pOworCisgICAgLyoKKyAgICAg KiBJZiB3ZSdyZSB1c2luZyBJQlBCLW9uLWVudHJ5IHRvIHByb3RlY3QgYWdh aW5zdCBQViBhbmQgSFZNIGd1ZXN0cworICAgICAqIChpZ25vcmluZyBkb20w IGlmIHRydXN0ZWQpLCB0aGVuIHRoZXJlJ3Mgbm8gbmVlZCB0byBhbHNvIGlz c3VlIElCUEIgb24KKyAgICAgKiBjb250ZXh0IHN3aXRjaCB0b28uCisgICAg ICovCisgICAgaWYgKCBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9PSAtMSApCisg ICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gIShvcHRfaWJwYl9lbnRy eV9odm0gJiYgb3B0X2licGJfZW50cnlfcHYpOworfQorCiAvKiBDYWxjdWxh dGUgd2hldGhlciB0aGlzIENQVSBpcyB2dWxuZXJhYmxlIHRvIEwxVEYuICov CiBzdGF0aWMgX19pbml0IHZvaWQgbDF0Zl9jYWxjdWxhdGlvbnModWludDY0 X3QgY2FwcykKIHsKQEAgLTk4NSw4ICsxMDY5LDEyIEBAIHZvaWQgc3BlY19j dHJsX2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpCiAgICAgYm9vbCB2 ZXJ3ID0gKChwdiA/IG9wdF9tZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9o dm0pIHx8CiAgICAgICAgICAgICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAm JiBpc19pb21tdV9lbmFibGVkKGQpKSk7CiAKKyAgICBib29sIGlicGIgPSAo KHB2ID8gb3B0X2licGJfZW50cnlfcHYgOiBvcHRfaWJwYl9lbnRyeV9odm0p ICYmCisgICAgICAgICAgICAgICAgIChkLT5kb21haW5faWQgIT0gMCB8fCBv cHRfaWJwYl9lbnRyeV9kb20wKSk7CisKICAgICBkLT5hcmNoLnNwZWNfY3Ry bF9mbGFncyA9CiAgICAgICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAgICAg IDogMCkgfAorICAgICAgICAoaWJwYiAgID8gU0NGX2VudHJ5X2licGIgICA6 IDApIHwKICAgICAgICAgMDsKIH0KIApAQCAtMTEzMywxMiArMTIyMSwxNSBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgfQogCiAgICAgLyoKLSAgICAgKiBVc2UgU1RJQlAgYnkgZGVm YXVsdCBpZiB0aGUgaGFyZHdhcmUgaGludCBpcyBzZXQuICBPdGhlcndpc2Us IGxlYXZlIGl0Ci0gICAgICogb2ZmIGFzIGl0IGEgc2V2ZXJlIHBlcmZvcm1h bmNlIHBlbnRhbHR5IG9uIHByZS1lSUJSUyBJbnRlbCBoYXJkd2FyZQotICAg ICAqIHdoZXJlIGl0IHdhcyByZXRyb2ZpdHRlZCBpbiBtaWNyb2NvZGUuCisg ICAgICogVXNlIFNUSUJQIGJ5IGRlZmF1bHQgb24gYWxsIEFNRCBzeXN0ZW1z LiAgWmVuMyBhbmQgbGF0ZXIgZW51bWVyYXRlCisgICAgICogU1RJQlBfQUxX QVlTLCBidXQgU1RJQlAgaXMgbmVlZGVkIG9uIFplbjIgYXMgcGFydCBvZiB0 aGUgbWl0aWdhdGlvbnMKKyAgICAgKiBmb3IgQnJhbmNoIFR5cGUgQ29uZnVz aW9uLgorICAgICAqCisgICAgICogTGVhdmUgU1RJQlAgb2ZmIGJ5IGRlZmF1 bHQgb24gSW50ZWwuICBQcmUtZUlCUlMgc3lzdGVtcyBzdWZmZXIgYQorICAg ICAqIHN1YnN0YW50aWFsIHBlcmYgaGl0IHdoZW4gaXQgd2FzIGltcGxlbWVu dGVkIGluIG1pY3JvY29kZS4KICAgICAgKi8KICAgICBpZiAoIG9wdF9zdGli cCA9PSAtMSApCi0gICAgICAgIG9wdF9zdGlicCA9ICEhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUyk7CisgICAgICAgIG9wdF9zdGli cCA9ICEhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0FNRF9TVElCUCk7CiAK ICAgICBpZiAoIG9wdF9zdGlicCAmJiAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX1NUSUJQKSB8fAogICAgICAgICAgICAgICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkgKQpAQCAtMTE5Miw5ICsx MjgzLDcgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQogICAgIGlmICggb3B0X3JzYl9odm0gKQogICAgICAgICBz ZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0pOwog Ci0gICAgLyogQ2hlY2sgd2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQg YmVmb3JlIHVzaW5nIGl0Li4uICovCi0gICAgaWYgKCAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX0lCUEIpICkKLSAgICAgICAgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSBm YWxzZTsKKyAgICBpYnBiX2NhbGN1bGF0aW9ucygpOwogCiAgICAgLyogQ2hl Y2sgd2hldGhlciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVm YXVsdC4gKi8KICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMTBjZDBjZDI1 MThmLi4zM2U4NDU5OTFiMGEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9z cGVjX2N0cmwuaApAQCAtNjUsNyArNjUsNyBAQAogdm9pZCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5p dF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9w dF9pYnBiX2N0eHRfc3dpdGNoOworZXh0ZXJuIGludDhfdCBvcHRfaWJwYl9j dHh0X3N3aXRjaDsKIGV4dGVybiBib29sIG9wdF9zc2JkOwogZXh0ZXJuIGlu dDhfdCBvcHRfZWFnZXJfZnB1OwogZXh0ZXJuIGludDhfdCBvcHRfbDFkX2Zs dXNoOwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-1.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIHNwZWNfY3RybF9m bGFncyBjb250ZXh0IHN3aXRjaGluZwoKV2UgYXJlIHNob3J0bHkgZ29pbmcg dG8gbmVlZCB0byBjb250ZXh0IHN3aXRjaCBuZXcgYml0cyBpbiBib3RoIHRo ZSB2Y3B1IGFuZApTMyBwYXRocy4gIEludHJvZHVjZSBTQ0ZfSVNUX01BU0sg YW5kIFNDRl9ET01fTUFTSywgYW5kIHJld29yayBkLT5hcmNoLnZlcncKaW50 byBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyB0byBhY2NvbW1vZGF0ZS4KCk5v IGZ1bmN0aW9uYWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9hY3Bp L3Bvd2VyLmMgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCmluZGV4IDVl YWE3N2Y2NmEyOC4uZGQzOTdmNzEzMDY3IDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvYWNwaS9wb3dlci5jCisrKyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bv d2VyLmMKQEAgLTI0OCw4ICsyNDgsOCBAQCBzdGF0aWMgaW50IGVudGVyX3N0 YXRlKHUzMiBzdGF0ZSkKICAgICAgICAgZXJyb3IgPSAwOwogCiAgICAgY2kg PSBnZXRfY3B1X2luZm8oKTsKLSAgICAvKiBBdm9pZCBOTUkvI01DIHVzaW5n IE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQgbWljcm9jb2Rl LiAqLwotICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflNDRl9pc3Rfd3Jt c3I7CisgICAgLyogQXZvaWQgTk1JLyNNQyB1c2luZyB1bnNhZmUgTVNScyB1 bnRpbCB3ZSd2ZSByZWxvYWRlZCBtaWNyb2NvZGUuICovCisgICAgY2ktPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX0lTVF9NQVNLOwogCiAgICAgQUNQSV9G TFVTSF9DUFVfQ0FDSEUoKTsKIApAQCAtMjkyLDggKzI5Miw4IEBAIHN0YXRp YyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgIGlmICggIXJlY2hl Y2tfY3B1X2ZlYXR1cmVzKDApICkKICAgICAgICAgcGFuaWMoIk1pc3Npbmcg cHJldmlvdXNseSBhdmFpbGFibGUgZmVhdHVyZShzKVxuIik7CiAKLSAgICAv KiBSZS1lbmFibGVkIGRlZmF1bHQgTk1JLyNNQyB1c2Ugb2YgTVNSX1NQRUNf Q1RSTC4gKi8KLSAgICBjaS0+c3BlY19jdHJsX2ZsYWdzIHw9IChkZWZhdWx0 X3NwZWNfY3RybF9mbGFncyAmIFNDRl9pc3Rfd3Jtc3IpOworICAgIC8qIFJl LWVuYWJsZWQgZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JzIG5vdyBtaWNy b2NvZGUgaXMgbG9hZGVkLiAqLworICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gKGRlZmF1bHRfc3BlY19jdHJsX2ZsYWdzICYgU0NGX0lTVF9NQVNLKTsK IAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSB8 fCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykgKQogICAgIHsKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4 Ni9kb21haW4uYwppbmRleCA0YTYxZTk1MWZhY2YuLjc5ZjJjNmFiMTliOCAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9h cmNoL3g4Ni9kb21haW4uYwpAQCAtMjA2OSwxMCArMjA2OSwxMCBAQCB2b2lk IGNvbnRleHRfc3dpdGNoKHN0cnVjdCB2Y3B1ICpwcmV2LCBzdHJ1Y3QgdmNw dSAqbmV4dCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAg IC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIHdpdGggdGhlIFZF UlcgZGlzcG9zaXRpb24uICovCi0gICAgICAgIGluZm8tPnNwZWNfY3RybF9m bGFncyAmPSB+U0NGX3Zlcnc7Ci0gICAgICAgIGlmICggbmV4dGQtPmFyY2gu dmVydyApCi0gICAgICAgICAgICBpbmZvLT5zcGVjX2N0cmxfZmxhZ3MgfD0g U0NGX3Zlcnc7CisgICAgICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNr IGJsb2NrIHdpdGggdGhlIG5ldyBzcGVjX2N0cmwgc2V0dGluZ3MuICovCisg ICAgICAgIGluZm8tPnNwZWNfY3RybF9mbGFncyA9CisgICAgICAgICAgICAo aW5mby0+c3BlY19jdHJsX2ZsYWdzICAgICAgICYgflNDRl9ET01fTUFTSykg fAorICAgICAgICAgICAgKG5leHRkLT5hcmNoLnNwZWNfY3RybF9mbGFncyAm ICBTQ0ZfRE9NX01BU0spOwogICAgIH0KIAogICAgIHNjaGVkX2NvbnRleHRf c3dpdGNoZWQocHJldiwgbmV4dCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggMjI1ZmUwODI1OWIzLi4wZmFiZmJlMmE5ZjQgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTk4MSw5ICs5ODEsMTIgQEAgdm9pZCBzcGVjX2N0cmxf aW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCkKIHsKICAgICBib29sIHB2 ID0gaXNfcHZfZG9tYWluKGQpOwogCi0gICAgZC0+YXJjaC52ZXJ3ID0KLSAg ICAgICAgKHB2ID8gb3B0X21kX2NsZWFyX3B2IDogb3B0X21kX2NsZWFyX2h2 bSkgfHwKLSAgICAgICAgKG9wdF9mYl9jbGVhcl9tbWlvICYmIGlzX2lvbW11 X2VuYWJsZWQoZCkpOworICAgIGJvb2wgdmVydyA9ICgocHYgPyBvcHRfbWRf Y2xlYXJfcHYgOiBvcHRfbWRfY2xlYXJfaHZtKSB8fAorICAgICAgICAgICAg ICAgICAob3B0X2ZiX2NsZWFyX21taW8gJiYgaXNfaW9tbXVfZW5hYmxlZChk KSkpOworCisgICAgZC0+YXJjaC5zcGVjX2N0cmxfZmxhZ3MgPQorICAgICAg ICAodmVydyAgID8gU0NGX3ZlcncgICAgICAgICA6IDApIHwKKyAgICAgICAg MDsKIH0KIAogdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9k b21haW4uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvZG9tYWluLmgKaW5kZXgg ZDBkZjdmODNhYTBjLi43ZDY0ODNmMjFiYjEgMTAwNjQ0Ci0tLSBhL3hlbi9p bmNsdWRlL2FzbS14ODYvZG9tYWluLmgKKysrIGIveGVuL2luY2x1ZGUvYXNt LXg4Ni9kb21haW4uaApAQCAtMzE5LDggKzMxOSw3IEBAIHN0cnVjdCBhcmNo X2RvbWFpbgogICAgIHVpbnQzMl90IHBjaV9jZjg7CiAgICAgdWludDhfdCBj bW9zX2lkeDsKIAotICAgIC8qIFVzZSBWRVJXIG9uIHJldHVybi10by1ndWVz dCBmb3IgaXRzIGZsdXNoaW5nIHNpZGUgZWZmZWN0LiAqLwotICAgIGJvb2wg dmVydzsKKyAgICB1aW50OF90IHNwZWNfY3RybF9mbGFnczsgLyogU2VlIFND Rl9ET01fTUFTSyAqLwogCiAgICAgdW5pb24gewogICAgICAgICBzdHJ1Y3Qg cHZfZG9tYWluIHB2OwpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4 Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJs LmgKaW5kZXggMTIyODM1NzNjZGQ1Li42MGQ2ZDJkYzk0MDcgMTAwNjQ0Ci0t LSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVu L2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaApAQCAtMjAsMTIgKzIwLDQw IEBACiAjaWZuZGVmIF9fWDg2X1NQRUNfQ1RSTF9IX18KICNkZWZpbmUgX19Y ODZfU1BFQ19DVFJMX0hfXwogCi0vKiBFbmNvZGluZyBvZiBjcHVpbmZvLnNw ZWNfY3RybF9mbGFncyAqLworLyoKKyAqIEVuY29kaW5nIG9mOgorICogICBj cHVpbmZvLnNwZWNfY3RybF9mbGFncworICogICBkZWZhdWx0X3NwZWNfY3Ry bF9mbGFncworICogICBkb21haW4uc3BlY19jdHJsX2ZsYWdzCisgKgorICog TGl2ZSBzZXR0aW5ncyBhcmUgaW4gdGhlIHRvcC1vZi1zdGFjayBibG9jaywg YmVjYXVzZSB0aGV5IG5lZWQgdG8gYmUKKyAqIGFjY2Vzc2FibGUgd2hlbiBY UFRJIGlzIGFjdGl2ZS4gIFNvbWUgc2V0dGluZ3MgYXJlIGZpeGVkIGZyb20g Ym9vdCwgc29tZQorICogY29udGV4dCBzd2l0Y2hlZCBwZXIgZG9tYWluLCBh bmQgc29tZSBpbmhpYml0ZWQgaW4gdGhlIFMzIHBhdGguCisgKi8KICNkZWZp bmUgU0NGX3VzZV9zaGFkb3cgKDEgPDwgMCkKICNkZWZpbmUgU0NGX2lzdF93 cm1zciAgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAgKDEgPDwg MikKICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKIAorLyoKKyAq IFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNhbiBpbnRlcnJ1cHQgYW55IGFy Yml0cmFyeSBjb250ZXh0LiAgU29tZQorICogZnVuY3Rpb25hbGl0eSByZXF1 aXJlcyB1cGRhdGVkIG1pY3JvY29kZSB0byB3b3JrLgorICoKKyAqIE9uIGJv b3QsIHRoaXMgaXMgZWFzeTsgd2UgbG9hZCBtaWNyb2NvZGUgYmVmb3JlIGZp Z3VyaW5nIG91dCB3aGljaAorICogc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMg dG8gYXBwbHkuICBIb3dldmVyLCBvbiB0aGUgUzMgcmVzdW1lIHBhdGgsIHdl IG11c3QKKyAqIGJlIGFibGUgdG8gZGlzYWJsZSB0aGUgY29uZmlndXJlZCBt aXRpZ2F0aW9ucyB1bnRpbCBtaWNyb2NvZGUgaXMgcmVsb2FkZWQuCisgKgor ICogVGhlc2UgYXJlIHRoZSBjb250cm9scyB0byBpbmhpYml0IG9uIHRoZSBT MyByZXN1bWUgcGF0aCB1bnRpbCBtaWNyb2NvZGUgaGFzCisgKiBiZWVuIHJl bG9hZGVkLgorICovCisjZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NGX2lzdF93 cm1zcikKKworLyoKKyAqIFNvbWUgc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMg YXJlIHBlci1kb21haW4uICBUaGVzZSBzZXR0aW5ncyBhcmUgbWVyZ2VkCisg KiBpbnRvIHRoZSB0b3Atb2Ytc3RhY2sgYmxvY2sgaW4gdGhlIGNvbnRleHQg c3dpdGNoIHBhdGguCisgKi8KKyNkZWZpbmUgU0NGX0RPTV9NQVNLIChTQ0Zf dmVydykKKwogI2lmbmRlZiBfX0FTU0VNQkxZX18KIAogI2luY2x1ZGUgPGFz bS9hbHRlcm5hdGl2ZS5oPgpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNt LXg4Ni9zcGVjX2N0cmxfYXNtLmggYi94ZW4vaW5jbHVkZS9hc20teDg2L3Nw ZWNfY3RybF9hc20uaAppbmRleCA1YTU5MGJhYzQ0YWEuLjY2YjAwZDUxMWZj NiAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxf YXNtLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmxfYXNt LmgKQEAgLTI0OCw5ICsyNDgsNiBAQAogCiAvKgogICogVXNlIGluIElTVCBp bnRlcnJ1cHQvZXhjZXB0aW9uIGNvbnRleHQuICBNYXkgaW50ZXJydXB0IFhl biBvciBQViBjb250ZXh0LgotICogRmluZSBncmFpbiBjb250cm9sIG9mIFND Rl9pc3Rfd3Jtc3IgaXMgbmVlZGVkIGZvciBzYWZldHkgaW4gdGhlIFMzIHJl c3VtZQotICogcGF0aCB0byBhdm9pZCB1c2luZyBNU1JfU1BFQ19DVFJMIGJl Zm9yZSB0aGUgbWljcm9jb2RlIGludHJvZHVjaW5nIGl0IGhhcwotICogYmVl biByZWxvYWRlZC4KICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9N X0lOVFJfSVNUCiAvKgo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-2.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIFNDRl9pc3Rfd3Jt c3IgdG8gU0NGX2lzdF9zY19tc3IKCldlIGFyZSBhYm91dCB0byBpbnRyb2R1 Y2UgU0NGX2lzdF9pYnBiLCBhdCB3aGljaCBwb2ludCBTQ0ZfaXN0X3dybXNy IGJlY29tZXMKYW1iaWd1b3VzLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCgpU aGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jCmluZGV4IDBmYWJmYmUyYTlmNC4uYTZkZWY0NzA2MWU4 IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMDg2LDcgKzEwODYsNyBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgewogICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8 PSBTQ0ZfaXN0X3dybXNyOworICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0 cmxfZmxhZ3MgfD0gU0NGX2lzdF9zY19tc3I7CiAgICAgICAgICAgICBzZXR1 cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01TUl9QVik7CiAgICAg ICAgIH0KIApAQCAtMTA5Nyw3ICsxMDk3LDcgQEAgdm9pZCBfX2luaXQgaW5p dF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICAgICAg ICogWGVuJ3MgdmFsdWUgaXMgbm90IHJlc3RvcmVkIGF0b21pY2FsbHkuICBB biBlYXJseSBOTUkgaGl0dGluZwogICAgICAgICAgICAgICogdGhlIFZNRXhp dCBwYXRoIG5lZWRzIHRvIHJlc3RvcmUgWGVuJ3MgdmFsdWUgZm9yIHNhZmV0 eS4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgZGVmYXVsdF9zcGVj X2N0cmxfZmxhZ3MgfD0gU0NGX2lzdF93cm1zcjsKKyAgICAgICAgICAgIGRl ZmF1bHRfc3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfc2NfbXNyOwogICAg ICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19N U1JfSFZNKTsKICAgICAgICAgfQogICAgIH0KQEAgLTExMTAsNyArMTExMCw3 IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnMo dm9pZCkKICAgICAgICAgICogb24gcmVhbCBoYXJkd2FyZSBtYXRjaGVzIHRo ZSBhdmFpbGFiaWxpdHkgb2YgTVNSX1NQRUNfQ1RSTCBpbiB0aGUKICAgICAg ICAgICogZmlyc3QgcGxhY2UuCiAgICAgICAgICAqCi0gICAgICAgICAqIE5v IG5lZWQgZm9yIFNDRl9pc3Rfd3Jtc3IgYmVjYXVzZSBYZW4ncyB2YWx1ZSBp cyByZXN0b3JlZAorICAgICAgICAgKiBObyBuZWVkIGZvciBTQ0ZfaXN0X3Nj X21zciBiZWNhdXNlIFhlbidzIHZhbHVlIGlzIHJlc3RvcmVkCiAgICAgICAg ICAqIGF0b21pY2FsbHkgV1JUIE5NSXMgaW4gdGhlIFZNRXhpdCBwYXRoLgog ICAgICAgICAgKgogICAgICAgICAgKiBUT0RPOiBBZGp1c3QgY3B1X2hhc19z dm1fc3BlY19jdHJsIHRvIGJlIHVzYWJsZSBlYXJsaWVyIG9uIGJvb3QuCmRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCA2MGQ2ZDJk Yzk0MDcuLjZmOGIwZTA5MzQ4ZSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCkBAIC0zMSw3ICszMSw3IEBACiAgKiBjb250ZXh0IHN3 aXRjaGVkIHBlciBkb21haW4sIGFuZCBzb21lIGluaGliaXRlZCBpbiB0aGUg UzMgcGF0aC4KICAqLwogI2RlZmluZSBTQ0ZfdXNlX3NoYWRvdyAoMSA8PCAw KQotI2RlZmluZSBTQ0ZfaXN0X3dybXNyICAoMSA8PCAxKQorI2RlZmluZSBT Q0ZfaXN0X3NjX21zciAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAg ICAoMSA8PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQog CkBAIC00Niw3ICs0Niw3IEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xz IHRvIGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3Jv Y29kZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NG X0lTVF9NQVNLIChTQ0ZfaXN0X3dybXNyKQorI2RlZmluZSBTQ0ZfSVNUX01B U0sgKFNDRl9pc3Rfc2NfbXNyKQogCiAvKgogICogU29tZSBzcGVjdWxhdGl2 ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4gIFRoZXNlIHNldHRpbmdz IGFyZSBtZXJnZWQKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKaW5kZXggNjZiMDBkNTExZmM2Li4wZmYxYjExOGY4ODIgMTAw NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5o CisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCkBA IC0yNjYsOCArMjY2LDggQEAKIAogLkxcQF9za2lwX3JzYjoKIAotICAgIHRl c3QgJFNDRl9pc3Rfd3Jtc3IsICVhbAotICAgIGp6IC5MXEBfc2tpcF93cm1z cgorICAgIHRlc3QgJFNDRl9pc3Rfc2NfbXNyLCAlYWwKKyAgICBqeiAuTFxA X3NraXBfbXNyX3NwZWNfY3RybAogCiAgICAgeG9yICVlZHgsICVlZHgKICAg ICB0ZXN0YiAkMywgVVJFR1NfY3MoJXJzcCkKQEAgLTI5MCw3ICsyOTAsNyBA QCBVTkxJS0VMWV9ESVNQQVRDSF9MQUJFTChcQF9zZXJpYWxpc2UpOgogICAg ICAqIHRvIHNwZWN1bGF0ZSBhcm91bmQgdGhlIFdSTVNSLiAgQXMgYSByZXN1 bHQsIHdlIG5lZWQgYSBkaXNwYXRjaAogICAgICAqIHNlcmlhbGlzaW5nIGlu c3RydWN0aW9uIGluIHRoZSBlbHNlIGNsYXVzZS4KICAgICAgKi8KLS5MXEBf c2tpcF93cm1zcjoKKy5MXEBfc2tpcF9tc3Jfc3BlY19jdHJsOgogICAgIGxm ZW5jZQogICAgIFVOTElLRUxZX0VORChcQF9zZXJpYWxpc2UpCiAuZW5kbQpA QCAtMzAxLDcgKzMwMSw3IEBAIFVOTElLRUxZX0RJU1BBVENIX0xBQkVMKFxA X3NlcmlhbGlzZSk6CiAgKiBSZXF1aXJlcyAlcmJ4PXN0YWNrX2VuZAogICog Q2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAogICovCi0gICAgdGVzdGIgJFND Rl9pc3Rfd3Jtc3IsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19jdHJsX2Zs YWdzKSglcmJ4KQorICAgIHRlc3RiICRTQ0ZfaXN0X3NjX21zciwgU1RBQ0tf Q1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyYngpCiAgICAganog LkxcQF9za2lwCiAKICAgICBET19TUEVDX0NUUkxfRVhJVF9UT19YRU4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-3.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-3.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIG9wdF9pYnBiIHRv IG9wdF9pYnBiX2N0eHRfc3dpdGNoCgpXZSBhcmUgYWJvdXQgdG8gaW50cm9k dWNlIHRoZSB1c2Ugb2YgSUJQQiBhdCBkaWZmZXJlbnQgcG9pbnRzIGluIFhl biwgbWFraW5nCm9wdF9pYnBiIGFtYmlndW91cy4gIFJlbmFtZSBpdCB0byBv cHRfaWJwYl9jdHh0X3N3aXRjaC4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoK U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKaW5kZXggNzlmMmM2YWIxOWI4 Li4yODM4Zjk3NmQ3MjkgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9kb21h aW4uYworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTIwNDEsNyAr MjA0MSw3IEBAIHZvaWQgY29udGV4dF9zd2l0Y2goc3RydWN0IHZjcHUgKnBy ZXYsIHN0cnVjdCB2Y3B1ICpuZXh0KQogCiAgICAgICAgIGN0eHRfc3dpdGNo X2xldmVsbGluZyhuZXh0KTsKIAotICAgICAgICBpZiAoIG9wdF9pYnBiICYm ICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQorICAgICAgICBpZiAoIG9wdF9p YnBiX2N0eHRfc3dpdGNoICYmICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQog ICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWMgREVGSU5FX1BFUl9DUFUo dW5zaWduZWQgaW50LCBsYXN0KTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCAqbGFzdF9pZCA9ICZ0aGlzX2NwdShsYXN0KTsKZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0 cmwuYwppbmRleCBhNmRlZjQ3MDYxZTguLmNlZDBmOGMyYWVhNiAxMDA2NDQK LS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9zcGVjX2N0cmwuYwpAQCAtNTQsNyArNTQsNyBAQCBpbnQ4X3QgX19p bml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBv cHRfc3NiZDsKIGludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0gLTE7CiAK LWJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYiA9IHRydWU7Citib29sIF9f cmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSB0cnVlOwogaW50 OF90IF9fcmVhZF9tb3N0bHkgb3B0X2VhZ2VyX2ZwdSA9IC0xOwogaW50OF90 IF9fcmVhZF9tb3N0bHkgb3B0X2wxZF9mbHVzaCA9IC0xOwogYm9vbCBfX3Jl YWRfbW9zdGx5IG9wdF9icmFuY2hfaGFyZGVuID0gdHJ1ZTsKQEAgLTExNyw3 ICsxMTcsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKIAogICAgICAgICAgICAgb3B0X3RodW5rID0gVEhV TktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMgPSAwOwotICAgICAgICAg ICAgb3B0X2licGIgPSBmYWxzZTsKKyAgICAgICAgICAgIG9wdF9pYnBiX2N0 eHRfc3dpdGNoID0gZmFsc2U7CiAgICAgICAgICAgICBvcHRfc3NiZCA9IGZh bHNlOwogICAgICAgICAgICAgb3B0X2wxZF9mbHVzaCA9IDA7CiAgICAgICAg ICAgICBvcHRfYnJhbmNoX2hhcmRlbiA9IGZhbHNlOwpAQCAtMjM4LDcgKzIz OCw3IEBAIHN0YXRpYyBpbnQgX19pbml0IHBhcnNlX3NwZWNfY3RybChjb25z dCBjaGFyICpzKQogCiAgICAgICAgIC8qIE1pc2Mgc2V0dGluZ3MuICovCiAg ICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaWJwYiIs IHMsIHNzKSkgPj0gMCApCi0gICAgICAgICAgICBvcHRfaWJwYiA9IHZhbDsK KyAgICAgICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gdmFsOwogICAg ICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImVhZ2VyLWZw dSIsIHMsIHNzKSkgPj0gMCApCiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1 ID0gdmFsOwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImwxZC1mbHVzaCIsIHMsIHNzKSkgPj0gMCApCkBAIC00NTgsNyArNDU4 LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHByaW50X2RldGFpbHMoZW51bSBp bmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90IGNhcHMpCiAgICAgICAgICAgIChv cHRfdHN4ICYgMSkgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBU U1grIiA6ICIgVFNYLSIsCiAgICAgICAgICAgICFjcHVfaGFzX3NyYmRzX2N0 cmwgICAgICAgICAgICAgICAgICAgICAgID8gIiIgOgogICAgICAgICAgICBv cHRfc3JiX2xvY2sgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIg U1JCX0xPQ0srIiA6ICIgU1JCX0xPQ0stIiwKLSAgICAgICAgICAgb3B0X2li cGIgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUEIi ICA6ICIiLAorICAgICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCAgICAg ICAgICAgICAgICAgICAgICA/ICIgSUJQQi1jdHh0IiA6ICIiLAogICAgICAg ICAgICBvcHRfbDFkX2ZsdXNoICAgICAgICAgICAgICAgICAgICAgICAgICAg ICA/ICIgTDFEX0ZMVVNIIiA6ICIiLAogICAgICAgICAgICBvcHRfbWRfY2xl YXJfcHYgfHwgb3B0X21kX2NsZWFyX2h2bSB8fAogICAgICAgICAgICBvcHRf ZmJfY2xlYXJfbW1pbyAgICAgICAgICAgICAgICAgICAgICAgICA/ICIgVkVS VyIgIDogIiIsCkBAIC0xMTkzLDcgKzExOTMsNyBAQCB2b2lkIF9faW5pdCBp bml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAKICAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KICAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQotICAgICAgICBvcHRfaWJwYiA9IGZhbHNlOworICAgICAgICBvcHRfaWJw Yl9jdHh0X3N3aXRjaCA9IGZhbHNlOwogCiAgICAgLyogQ2hlY2sgd2hldGhl ciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdC4gKi8K ICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hlbi9pbmNsdWRl L2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggNmY4YjBlMDkzNDhlLi5mZDgx NjJjYTlhYjkgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3Bl Y19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwu aApAQCAtNjMsNyArNjMsNyBAQAogdm9pZCBpbml0X3NwZWN1bGF0aW9uX21p dGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5pdF9kb21haW4o c3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9wdF9pYnBiOwor ZXh0ZXJuIGJvb2wgb3B0X2licGJfY3R4dF9zd2l0Y2g7CiBleHRlcm4gYm9v bCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4X3Qgb3B0X2VhZ2VyX2ZwdTsKIGV4 dGVybiBpbnQ4X3Qgb3B0X2wxZF9mbHVzaDsK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-4.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-4.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFJfSVNUCgpXZSBhcmUgc2hvcnRseSBnb2luZyB0byBh ZGQgYSBjb25kaXRpb25hbCBJQlBCIGluIHRoaXMgcGF0aC4KClRoZXJlZm9y ZSwgd2UgY2Fubm90IGhvbGQgc3BlY19jdHJsX2ZsYWdzIGluICVlYXgsIGFu ZCByZWx5IG9uIG9ubHkgY2xvYmJlcmluZwppdCBhZnRlciB3ZSdyZSBkb25l IHdpdGggaXRzIGNvbnRlbnRzLiAgJXJieCBpcyBhdmFpbGFibGUgZm9yIHVz ZSwgYW5kIHRoZQptb3JlIG5vcm1hbCByZWdpc3RlciB0byBob2xkIHByZXNl cnZlZCBpbmZvcm1hdGlvbiBpbi4KCldpdGggJXJheCBmcmVlZCB1cCwgdXNl IGl0IGluc3RlYWQgb2YgJXJkeCBmb3IgdGhlIFJTQiB0bXAgcmVnaXN0ZXIs IGFuZCBmb3IKdGhlIGFkanVzdG1lbnQgdG8gc3BlY19jdHJsX2ZsYWdzLgoK VGhpcyBsZWF2ZXMgbm8gdXNlIG9mICVyZHgsIGV4Y2VwdCBhcyAwIGZvciB0 aGUgdXBwZXIgaGFsZiBvZiBXUk1TUi4gIEluCnByYWN0aWNlLCAlcmR4IGlz IDAgZnJvbSBTQVZFX0FMTCBvbiBhbGwgcGF0aHMgYW5kIGlzbid0IGxpa2Vs eSB0byBjaGFuZ2UgaW4KdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSwgc28gdXBk YXRlIHRoZSBtYWNybyBlbnRyeSByZXF1aXJlbWVudHMgdG8gc3RhdGUgdGhp cwpkZXBlbmRlbmN5LiAgVGhpcyBtYXJnaW5hbCBvcHRpbWlzYXRpb24gY2Fu IGJlIHJldmlzaXRlZCBpZiBjaXJjdW1zdGFuY2VzCmNoYW5nZS4KCk5vIHBy YWN0aWNhbCBjaGFuZ2UuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IDJm M2Y0OGZmMjdjMy4uOWJmYzU5NjRhOTExIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9lbnRyeS5TCkBAIC04NzQsNyArODc0LDcgQEAgRU5UUlkoZG91YmxlX2Zh dWx0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAKLSAgICAgICAg U1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJl Z3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyYngKQEAgLTkxMCw3ICs5MTAsNyBA QCBoYW5kbGVfaXN0X2V4Y2VwdGlvbjoKIAogICAgICAgICBHRVRfU1RBQ0tf RU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJf SVNUIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICov CisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJfSVNUIC8qIFJl cTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhYmNkICov CiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAq YCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBt b3YgICBTVEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4 CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCmlu ZGV4IDBmZjFiMTE4Zjg4Mi4uMTVlMjRjZGUwMGQxIDEwMDY0NAotLS0gYS94 ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaAorKysgYi94ZW4v aW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaApAQCAtMjUxLDM0ICsy NTEsMzMgQEAKICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lO VFJfSVNUCiAvKgotICogUmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNr X2VuZAotICogQ2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAorICogUmVxdWly ZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNrX2VuZCwgJXJkeD0wCisgKiBDbG9i YmVycyAlcmF4LCAlcmJ4LCAlcmN4LCAlcmR4CiAgKgogICogVGhpcyBpcyBs b2dpY2FsIG1lcmdlIG9mIERPX09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNf Q1RSTF9FTlRSWQogICogbWF5YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9u YWxzIHJhdGhlciB0aGFuIGFsdGVybmF0aXZlcy4KICAqLwotICAgIG1vdnpi bCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCks ICVlYXgKKyAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0 cmxfZmxhZ3MpKCVyMTQpLCAlZWJ4CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3Jz YiwgJWFsCisgICAgdGVzdCAkU0NGX2lzdF9yc2IsICVibAogICAgIGp6IC5M XEBfc2tpcF9yc2IKIAotICAgIERPX09WRVJXUklURV9SU0IgdG1wPXJkeCAv KiBDbG9iYmVycyAlcmN4LyVyZHggKi8KKyAgICBET19PVkVSV1JJVEVfUlNC ICAgICAgICAgLyogQ2xvYmJlcnMgJXJheC8lcmN4ICovCiAKIC5MXEBfc2tp cF9yc2I6CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3NjX21zciwgJWFsCisgICAg dGVzdCAkU0NGX2lzdF9zY19tc3IsICVibAogICAgIGp6IC5MXEBfc2tpcF9t c3Jfc3BlY19jdHJsCiAKLSAgICB4b3IgJWVkeCwgJWVkeAorICAgIHhvciAl ZWF4LCAlZWF4CiAgICAgdGVzdGIgJDMsIFVSRUdTX2NzKCVyc3ApCi0gICAg c2V0bnogJWRsCi0gICAgbm90ICVlZHgKLSAgICBhbmQgJWRsLCBTVEFDS19D UFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICBzZXRu eiAlYWwKKyAgICBub3QgJWVheAorICAgIGFuZCAlYWwsIFNUQUNLX0NQVUlO Rk9fRklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KQogCiAgICAgLyogTG9h ZCBYZW4ncyBpbnRlbmRlZCB2YWx1ZS4gKi8KICAgICBtb3YgJE1TUl9TUEVD X0NUUkwsICVlY3gKICAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4 ZW5fc3BlY19jdHJsKSglcjE0KSwgJWVheAotICAgIHhvciAlZWR4LCAlZWR4 CiAgICAgd3Jtc3IKIAogICAgIC8qIE9wZW5jb2RlZCBVTkxJS0VMWV9TVEFS VCgpIHdpdGggbm8gY29uZGl0aW9uLiAqLwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-5.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-5.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3VwcG9ydCBJQlBCLW9uLWVu dHJ5CgpXZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGlzIHRvIG1pdGlnYXRlIEJy YW5jaCBUeXBlIENvbmZ1c2lvbiBvbiBBTUQvSHlnb24gQ1BVcywKYnV0IGFz IHdlJ3ZlIHRhbGtlZCBhYm91dCB1c2luZyBpdCBpbiBvdGhlciBjYXNlcyB0 b28sIGFycmFuZ2UgdG8gc3VwcG9ydCBpdApnZW5lcmFsbHkuICBIb3dldmVy LCB0aGlzIGlzIGFsc28gdmVyeSBleHBlbnNpdmUgaW4gc29tZSBjYXNlcywg c28gd2UncmUgZ29pbmcKdG8gd2FudCBwZXItZG9tYWluIGNvbnRyb2xzLgoK SW50cm9kdWNlIFNDRl9pc3RfaWJwYiBhbmQgU0NGX2VudHJ5X2licGIgY29u dHJvbHMsIGFkZGluZyB0aGVtIHRvIHRoZSBJU1QgYW5kCkRPTSBtYXNrcyBh cyBhcHByb3ByaWF0ZS4gIEFsc28gaW50cm9kdWNlIFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfe1BWLEhWTX0gdG8KdG8gcGF0Y2ggdGhlIGNvZGUgYmxvY2tz LgoKRm9yIFNWTSwgdGhlIFNUR0kgaXMgc2VyaWFsaXNpbmcgZW5vdWdoIHRv IHByb3RlY3QgYWdhaW5zdCBTcGVjdHJlLXYxIGF0dGFja3MsCnNvIG5vICJl bHNlIGxmZW5jZSIgaXMgbmVjZXNzYXJ5LiAgVlQteCB3aWxsIHVzZSB1c2Ug dGhlIE1TUiBob3N0IGxvYWQgbGlzdCwKc28gZG9lc24ndCBuZWVkIGFueSBj b2RlIGluIHRoZSBWTUV4aXQgcGF0aC4KCkZvciB0aGUgSVNUIHBhdGgsIHdl IGNhbid0IHNhZmVseSBjaGVjayBDUEw9PTAgdG8gc2tpcCBhIGZsdXNoLCBh cyB3ZSBtaWdodApoYXZlIGhpdCBhbiBlbnRyeSBwYXRoIGJlZm9yZSBpdCdz IElCUEIuICBBcyBJU1QgaGl0dGluZyBYZW4gaXMgcmFyZSwgZmx1c2gKaXJy ZXNwZWN0aXZlIG9mIENQTC4gIEEgbGF0ZXIgcGF0aCwgU0NGX2lzdF9zY19t c3IsIHByb3ZpZGVzIFNwZWN0cmUtdjEKc2FmZXR5LgoKRm9yIHRoZSBQViBw YXRocywgd2Uga25vdyB3ZSdyZSBpbnRlcnJ1cHRpbmcgQ1BMPjAsIHdoaWxl IGZvciB0aGUgSU5UUiBwYXRocywKd2UgY2FuIHNhZmVseSBjaGVjayBDUEw9 PTAuICBPbmx5IGZsdXNoIHdoZW4gaW50ZXJydXB0aW5nIGd1ZXN0IGNvbnRl eHQuCgpBbiAiZWxzZSBsZmVuY2UiIGlzIG5lZWRlZCBmb3Igc2FmZXR5LCBi dXQgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHNraXAgaXQgb24KdW5hZmZlY3Rl ZCBDUFVzLCBzbyB0aGUgYmxvY2sgd2FudHMgdG8gYmUgYW4gYWx0ZXJuYXRp dmUsIHdoaWNoIG1lYW5zIHRoZQpsZmVuY2UgaGFzIHRvIGJlIGlubGluZSBy YXRoZXIgdGhhbiBVTkxJS0VMWSgpICh0aGUgcmVwbGFjZW1lbnQgYmxvY2sg ZG9lc24ndApoYXZlIGRpc3BsYWNlbWVudHMgZml4ZWQgdXAgZm9yIGFueXRo aW5nIG90aGVyIHRoYW4gdGhlIGZpcnN0IGluc3RydWN0aW9uKS4KCkFzIHdp dGggU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QsICVyZHggaXMgMCBv biBlbnRyeSBzbyByZWx5IG9uIHRoaXMgdG8Kc2hyaW5rIHRoZSBsb2dpYyBt YXJnaW5hbGx5LiAgVXBkYXRlIHRoZSBjb21tZW50cyB0byBzcGVjaWZ5IHRo aXMgbmV3CmRlcGVuZGVuY3kuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9z dm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKaW5k ZXggNGFlNTVhMmVmNjA1Li4wZmY0MDA4MDYwZmEgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L2h2bS9zdm0vZW50cnkuUwpAQCAtOTcsNyArOTcsMTkgQEAgX19VTkxJS0VM WV9FTkQobnN2bV9oYXApCiAKICAgICAgICAgR0VUX0NVUlJFTlQoYngpCiAK LSAgICAgICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTog JXJzcD1yZWdzL2NwdWluZm8gICAgICAgICBDbG9iOiBhY2QgKi8KKyAgICAg ICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTogJXJzcD1y ZWdzL2NwdWluZm8sICVyZHg9MCBDbG9iOiBhY2QgKi8KKworICAgICAgICAu bWFjcm8gc3ZtX3ZtZXhpdF9jb25kX2licGIKKyAgICAgICAgICAgIHRlc3Ri ICAkU0NGX2VudHJ5X2licGIsIENQVUlORk9feGVuX3NwZWNfY3RybCglcnNw KQorICAgICAgICAgICAganogICAgIC5MX3NraXBfaWJwYgorCisgICAgICAg ICAgICBtb3YgICAgJE1TUl9QUkVEX0NNRCwgJWVjeAorICAgICAgICAgICAg bW92ICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgICAgICAgICB3cm1z cgorLkxfc2tpcF9pYnBiOgorCS5lbmRtCisgICAgICAgIEFMVEVSTkFUSVZF ICIiLCBzdm1fdm1leGl0X2NvbmRfaWJwYiwgWDg2X0ZFQVRVUkVfSUJQQl9F TlRSWV9IVk0KKwogICAgICAgICBBTFRFUk5BVElWRSAiIiwgRE9fT1ZFUldS SVRFX1JTQiwgWDg2X0ZFQVRVUkVfU0NfUlNCX0hWTQogCiAgICAgICAgIC5t YWNybyBzdm1fdm1leGl0X3NwZWNfY3RybApAQCAtMTE0LDYgKzEyNiwxMCBA QCBfX1VOTElLRUxZX0VORChuc3ZtX2hhcCkKICAgICAgICAgQUxURVJOQVRJ VkUgIiIsIHN2bV92bWV4aXRfc3BlY19jdHJsLCBYODZfRkVBVFVSRV9TQ19N U1JfSFZNCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwg YGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAorICAg ICAgICAvKgorICAgICAgICAgKiBTVEdJIGlzIGV4ZWN1dGVkIHVuY29uZGl0 aW9uYWxseSwgYW5kIGlzIHN1ZmZpY2llbnRseSBzZXJpYWxpc2luZworICAg ICAgICAgKiB0byBzYWZlbHkgcmVzb2x2ZSBhbnkgU3BlY3RyZS12MSBjb25j ZXJucyBpbiB0aGUgYWJvdmUgbG9naWMuCisgICAgICAgICAqLwogICAgICAg ICBzdGdpCiBHTE9CQUwoc3ZtX3N0Z2lfbGFiZWwpCiAgICAgICAgIG1vdiAg JXJzcCwlcmRpCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92 bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMKaW5kZXggZjlm OWJjMThjZGJjLi5kZDgxN2NlZTRlNjkgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNo L3g4Ni9odm0vdm14L3ZtY3MuYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3Zt eC92bWNzLmMKQEAgLTEzNDUsNiArMTM0NSwxMCBAQCBzdGF0aWMgaW50IGNv bnN0cnVjdF92bWNzKHN0cnVjdCB2Y3B1ICp2KQogICAgICAgICByYyA9IHZt eF9hZGRfbXNyKHYsIE1TUl9GTFVTSF9DTUQsIEZMVVNIX0NNRF9MMUQsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgVk1YX01TUl9HVUVTVF9MT0FET05M WSk7CiAKKyAgICBpZiAoICFyYyAmJiAoZC0+YXJjaC5zcGVjX2N0cmxfZmxh Z3MgJiBTQ0ZfZW50cnlfaWJwYikgKQorICAgICAgICByYyA9IHZteF9hZGRf bXNyKHYsIE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICBWTVhfTVNSX0hPU1QpOworCiAgb3V0OgogICAg IHZteF92bWNzX2V4aXQodik7CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni94ODZfNjQvY29tcGF0L2VudHJ5LlMgYi94ZW4vYXJjaC94ODYveDg2XzY0 L2NvbXBhdC9lbnRyeS5TCmluZGV4IDBjZmU5NTMxNDI0OS4uNWM5OTkyNzFl NjE3IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYveDg2XzY0L2NvbXBhdC9l bnRyeS5TCisrKyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvY29tcGF0L2VudHJ5 LlMKQEAgLTIwLDcgKzIwLDcgQEAgRU5UUlkoZW50cnlfaW50ODIpCiAgICAg ICAgIG1vdmwgICRIWVBFUkNBTExfVkVDVE9SLCA0KCVyc3ApCiAgICAgICAg IFNBVkVfQUxMIGNvbXBhdD0xIC8qIERQTDEgZ2F0ZSwgcmVzdHJpY3RlZCB0 byAzMmJpdCBQViBndWVzdHMgb25seS4gKi8KIAotICAgICAgICBTUEVDX0NU UkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYg LyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2Qg Ki8KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1w ICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAg IENSNF9QVjMyX1JFU1RPUkUKQEAgLTIxNiw3ICsyMTYsNyBAQCBFTlRSWShj c3Rhcl9lbnRlcikKICAgICAgICAgbW92bCAgJFRSQVBfc3lzY2FsbCwgNCgl cnNwKQogICAgICAgICBTQVZFX0FMTAogCi0gICAgICAgIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6 IGFjZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBS ZXE6ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwog ICAgICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAg bm90IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgR0VU X1NUQUNLX0VORChieCkKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni94ODZf NjQvZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvZW50cnkuUwppbmRl eCA5YmZjNTk2NGE5MTEuLjNjODU5MzMyNTYwNiAxMDA2NDQKLS0tIGEveGVu L2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCisrKyBiL3hlbi9hcmNoL3g4Ni94 ODZfNjQvZW50cnkuUwpAQCAtMjYwLDcgKzI2MCw3IEBAIEVOVFJZKGxzdGFy X2VudGVyKQogICAgICAgICBtb3ZsICAkVFJBUF9zeXNjYWxsLCA0KCVyc3Ap CiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZ X0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjogYWNk ICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJlcTog JXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAgICAg ICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qg c2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBHRVRfU1RB Q0tfRU5EKGJ4KQpAQCAtMjk5LDcgKzI5OSw3IEBAIEdMT0JBTChzeXNlbnRl cl9lZmxhZ3Nfc2F2ZWQpCiAgICAgICAgIG1vdmwgICRUUkFQX3N5c2NhbGws IDQoJXJzcCkKICAgICAgICAgU0FWRV9BTEwKIAotICAgICAgICBTUEVDX0NU UkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYg LyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2Qg Ki8KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1w ICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAg IEdFVF9TVEFDS19FTkQoYngpCkBAIC0zNTEsNyArMzUxLDcgQEAgRU5UUlko aW50ODBfZGlyZWN0X3RyYXApCiAgICAgICAgIG1vdmwgICQweDgwLCA0KCVy c3ApCiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VO VFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjog YWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJl cTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAg ICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBu b3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBHRVRf U1RBQ0tfRU5EKGJ4KQpAQCAtNjE4LDcgKzYxOCw3IEBAIEVOVFJZKGNvbW1v bl9pbnRlcnJ1cHQpCiAKICAgICAgICAgR0VUX1NUQUNLX0VORCgxNCkKIAot ICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJz cD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICovCisgICAgICAgIFNQRUNf Q1RSTF9FTlRSWV9GUk9NX0lOVFIgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAgICAgICAvKiBXQVJOSU5H ISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3JlIHRo aXMgcG9pbnQuICovCiAKICAgICAgICAgbW92ICAgU1RBQ0tfQ1BVSU5GT19G SUVMRCh4ZW5fY3IzKSglcjE0KSwgJXJjeApAQCAtNjUyLDcgKzY1Miw3IEBA IEdMT0JBTChoYW5kbGVfZXhjZXB0aW9uKQogCiAgICAgICAgIEdFVF9TVEFD S19FTkQoMTQpCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5U UiAvKiBSZXE6ICVyc3A9cmVncywgJXIxND1lbmQsIENsb2I6IGFjZCAqLwor ICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJz cD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhY2QgKi8KICAgICAg ICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBz YWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNU QUNLX0NQVUlORk9fRklFTEQoeGVuX2NyMykoJXIxNCksICVyY3gKZGlmZiAt LWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaAppbmRleCBmNzQ4OGQz Y2NiZmEuLmIyMzNlNTgzNWZiNSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9jcHVmZWF0dXJlcy5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14 ODYvY3B1ZmVhdHVyZXMuaApAQCAtMzksNiArMzksOCBAQCBYRU5fQ1BVRkVB VFVSRShYRU5fTEJSLCAgICAgICAgICAgWDg2X1NZTlRIKDIyKSkgLyogWGVu IHVzZXMgTVNSX0RFQlVHQ1RMLkxCUiAqLwogWEVOX0NQVUZFQVRVUkUoU0Nf VkVSV19JRExFLCAgICAgIFg4Nl9TWU5USCgyNSkpIC8qIFZFUlcgdXNlZCBi eSBYZW4gZm9yIGlkbGUgKi8KIFhFTl9DUFVGRUFUVVJFKFhFTl9TSFNUSywg ICAgICAgICBYODZfU1lOVEgoMjYpKSAvKiBYZW4gdXNlcyBDRVQgU2hhZG93 IFN0YWNrcyAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX0lCVCwgICAgICAgICAg IFg4Nl9TWU5USCgyNykpIC8qIFhlbiB1c2VzIENFVCBJbmRpcmVjdCBCcmFu Y2ggVHJhY2tpbmcgKi8KK1hFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfUFYs ICAgICBYODZfU1lOVEgoMjgpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBY ZW4gZm9yIFBWICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX0VOVFJZX0hWTSwg ICAgWDg2X1NZTlRIKDI5KSkgLyogTVNSX1BSRURfQ01EIHVzZWQgYnkgWGVu IGZvciBIVk0gKi8KIAogLyogQnVnIHdvcmRzIGZvbGxvdyB0aGUgc3ludGhl dGljIHdvcmRzLiAqLwogI2RlZmluZSBYODZfTlJfQlVHIDEKZGlmZiAtLWdp dCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmggYi94ZW4vaW5j bHVkZS9hc20teDg2L3NwZWNfY3RybC5oCmluZGV4IGZkODE2MmNhOWFiOS4u MTBjZDBjZDI1MThmIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKQEAgLTM0LDYgKzM0LDggQEAKICNkZWZpbmUgU0NGX2lzdF9zY19t c3IgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAgKDEgPDwgMikK ICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKKyNkZWZpbmUgU0NG X2lzdF9pYnBiICAgKDEgPDwgNCkKKyNkZWZpbmUgU0NGX2VudHJ5X2licGIg KDEgPDwgNSkKIAogLyoKICAqIFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNh biBpbnRlcnJ1cHQgYW55IGFyYml0cmFyeSBjb250ZXh0LiAgU29tZQpAQCAt NDYsMTMgKzQ4LDEzIEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xzIHRv IGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3JvY29k ZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NGX0lT VF9NQVNLIChTQ0ZfaXN0X3NjX21zcikKKyNkZWZpbmUgU0NGX0lTVF9NQVNL IChTQ0ZfaXN0X3NjX21zciB8IFNDRl9pc3RfaWJwYikKIAogLyoKICAqIFNv bWUgc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMgYXJlIHBlci1kb21haW4uICBU aGVzZSBzZXR0aW5ncyBhcmUgbWVyZ2VkCiAgKiBpbnRvIHRoZSB0b3Atb2Yt c3RhY2sgYmxvY2sgaW4gdGhlIGNvbnRleHQgc3dpdGNoIHBhdGguCiAgKi8K LSNkZWZpbmUgU0NGX0RPTV9NQVNLIChTQ0ZfdmVydykKKyNkZWZpbmUgU0NG X0RPTV9NQVNLIChTQ0ZfdmVydyB8IFNDRl9lbnRyeV9pYnBiKQogCiAjaWZu ZGVmIF9fQVNTRU1CTFlfXwogCmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9h c20teDg2L3NwZWNfY3RybF9hc20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oCmluZGV4IDE1ZTI0Y2RlMDBkMS4uOWViNGFkOWFi NzFkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3Ry bF9hc20uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaApAQCAtODgsNiArODgsMzUgQEAKICAqICAtIFNQRUNfQ1RSTF9FWElU X1RPX3tTVk0sVk1YfQogICovCiAKKy5tYWNybyBET19TUEVDX0NUUkxfQ09O RF9JQlBCIG1heWJleGVuOnJlcQorLyoKKyAqIFJlcXVpcmVzICVyc3A9cmVn cyAoYWxzbyBjcHVpbmZvIGlmICFtYXliZXhlbikKKyAqIFJlcXVpcmVzICVy MTQ9c3RhY2tfZW5kIChpZiBtYXliZXhlbiksICVyZHg9MAorICogQ2xvYmJl cnMgJXJheCwgJXJjeCwgJXJkeAorICoKKyAqIENvbmRpdGlvbmFsbHkgaXNz dWUgSUJQQiBpZiBTQ0ZfZW50cnlfaWJwYiBpcyBhY3RpdmUuICBJbiB0aGUg bWF5YmV4ZW4KKyAqIGNhc2UsIHdlIGNhbiBzYWZlbHkgbG9vayBhdCBVUkVH U19jcyB0byBza2lwIHRha2luZyB0aGUgaGl0IHdoZW4KKyAqIGludGVycnVw dGluZyBYZW4uCisgKi8KKyAgICAuaWYgXG1heWJleGVuCisgICAgICAgIHRl c3RiICAkU0NGX2VudHJ5X2licGIsIFNUQUNLX0NQVUlORk9fRklFTEQoc3Bl Y19jdHJsX2ZsYWdzKSglcjE0KQorICAgICAgICBqeiAgICAgLkxcQF9za2lw CisgICAgICAgIHRlc3RiICAkMywgVVJFR1NfY3MoJXJzcCkKKyAgICAuZWxz ZQorICAgICAgICB0ZXN0YiAgJFNDRl9lbnRyeV9pYnBiLCBDUFVJTkZPX3hl bl9zcGVjX2N0cmwoJXJzcCkKKyAgICAuZW5kaWYKKyAgICBqeiAgICAgLkxc QF9za2lwCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAg ICBtb3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKyAg ICBqbXAgICAgIC5MXEBfZG9uZQorCisuTFxAX3NraXA6CisgICAgbGZlbmNl CisuTFxAX2RvbmU6CisuZW5kbQorCiAubWFjcm8gRE9fT1ZFUldSSVRFX1JT QiB0bXA9cmF4CiAvKgogICogUmVxdWlyZXMgbm90aGluZwpAQCAtMjI1LDEy ICsyNTQsMTYgQEAKIAogLyogVXNlIGFmdGVyIGFuIGVudHJ5IGZyb20gUFYg Y29udGV4dCAoc3lzY2FsbC9zeXNlbnRlci9pbnQ4MC9pbnQ4Mi9ldGMpLiAq LwogI2RlZmluZSBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgIEFMVEVSTkFU SVZFICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1h eWJleGVuPTApLCAgICAgXAorICAgICAgICBYODZfRkVBVFVSRV9JQlBCX0VO VFJZX1BWOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAogICAgIEFMVEVSTkFUSVZFICIiLCBET19PVkVSV1JJVEVfUlNCLCBYODZf RkVBVFVSRV9TQ19SU0JfUFY7ICAgICAgICAgICAgXAogICAgIEFMVEVSTkFU SVZFICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfRU5UUlkgbWF5YmV4 ZW49MCksICAgICAgICAgXAogICAgICAgICBYODZfRkVBVFVSRV9TQ19NU1Jf UFYKIAogLyogVXNlIGluIGludGVycnVwdC9leGNlcHRpb24gY29udGV4dC4g IE1heSBpbnRlcnJ1cHQgWGVuIG9yIFBWIGNvbnRleHQuICovCiAjZGVmaW5l IFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFIgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcCisgICAgQUxURVJOQVRJVkUgIiIsIF9f c3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9DT05EX0lCUEIgbWF5YmV4ZW49MSks ICAgICBcCisgICAgICAgIFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfUFY7ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgQUxU RVJOQVRJVkUgIiIsIERPX09WRVJXUklURV9SU0IsIFg4Nl9GRUFUVVJFX1ND X1JTQl9QVjsgICAgICAgICAgICBcCiAgICAgQUxURVJOQVRJVkUgIiIsIF9f c3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9FTlRSWSBtYXliZXhlbj0xKSwgICAg ICAgICBcCiAgICAgICAgIFg4Nl9GRUFUVVJFX1NDX01TUl9QVgpAQCAtMjU0 LDExICsyODcsMjMgQEAKICAqIFJlcXVpcmVzICVyc3A9cmVncywgJXIxND1z dGFja19lbmQsICVyZHg9MAogICogQ2xvYmJlcnMgJXJheCwgJXJieCwgJXJj eCwgJXJkeAogICoKLSAqIFRoaXMgaXMgbG9naWNhbCBtZXJnZSBvZiBET19P VkVSV1JJVEVfUlNCIGFuZCBET19TUEVDX0NUUkxfRU5UUlkKLSAqIG1heWJl eGVuPTEsIGJ1dCB3aXRoIGNvbmRpdGlvbmFscyByYXRoZXIgdGhhbiBhbHRl cm5hdGl2ZXMuCisgKiBUaGlzIGlzIGxvZ2ljYWwgbWVyZ2Ugb2Y6CisgKiAg ICBET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1heWJleGVuPTAKKyAqICAgIERP X09WRVJXUklURV9SU0IKKyAqICAgIERPX1NQRUNfQ1RSTF9FTlRSWSBtYXli ZXhlbj0xCisgKiBidXQgd2l0aCBjb25kaXRpb25hbHMgcmF0aGVyIHRoYW4g YWx0ZXJuYXRpdmVzLgogICovCiAgICAgbW92emJsIFNUQUNLX0NQVUlORk9f RklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KSwgJWVieAogCisgICAgdGVz dCAgICAkU0NGX2lzdF9pYnBiLCAlYmwKKyAgICBqeiAgICAgIC5MXEBfc2tp cF9pYnBiCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAg ICBtb3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKwor LkxcQF9za2lwX2licGI6CisKICAgICB0ZXN0ICRTQ0ZfaXN0X3JzYiwgJWJs CiAgICAganogLkxcQF9za2lwX3JzYgogCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-6.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-6.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2NwdWlkOiBFbnVtZXJhdGlvbiBmb3IgQlRDX05P CgpCVENfTk8gaW5kaWNhdGVzIHRoYXQgaGFyZHdhcmUgaXMgbm90IHN1Y2Nl cHRhYmxlIHRvIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KClplbjMgQ1BVcyBk b24ndCBzdWZmZXIgQlRDLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcuCgpT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpp bmRleCA5YTRlYjgwMTVhNDMuLjI2MzJlZmM2YWRiMCAxMDA2NDQKLS0tIGEv dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfY3B1aWQuYwpAQCAtMjgzLDYgKzI4Myw3IEBAIGlu dCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25maWcobGlieGxfY3B1aWRfcG9saWN5 X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFyKiBzdHIpCiAgICAgICAgIHsidmly dC1zc2JkIiwgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI1 LCAgMX0sCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCisgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCiAKICAgICAgICAgeyJuYyIsICAg ICAgICAgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgIDAsICA4 fSwKICAgICAgICAgeyJhcGljaWRzaXplIiwgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgMTIsICA0fSwKZGlmZiAtLWdpdCBhL3Rvb2xzL21p c2MveGVuLWNwdWlkLmMgYi90b29scy9taXNjL3hlbi1jcHVpZC5jCmluZGV4 IDEyMTExZmUxMmQxNi4uZTgzYmM0NzkzZDZlIDEwMDY0NAotLS0gYS90b29s cy9taXNjL3hlbi1jcHVpZC5jCisrKyBiL3Rvb2xzL21pc2MveGVuLWNwdWlk LmMKQEAgLTE1Nyw3ICsxNTcsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqY29u c3Qgc3RyX2U4YlszMl0gPQogICAgIC8qIFsyMl0gKi8gICAgICAgICAgICAg ICAgIFsyM10gPSAicHBpbiIsCiAgICAgWzI0XSA9ICJhbWQtc3NiZCIsICAg ICAgICAgWzI1XSA9ICJ2aXJ0LXNzYmQiLAogICAgIFsyNl0gPSAic3NiLW5v IiwKLSAgICBbMjhdID0gInBzZmQiLAorICAgIFsyOF0gPSAicHNmZCIsICAg ICAgICAgICAgIFsyOV0gPSAiYnRjLW5vIiwKIH07CiAKIHN0YXRpYyBjb25z dCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvY3B1L2FtZC5jIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpp bmRleCA5ODY2NzJhMDcyYjcuLjY3NWI4NzdmMTkzYyAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2NwdS9hbWQuYworKysgYi94ZW4vYXJjaC94ODYvY3B1 L2FtZC5jCkBAIC04MjIsNiArODIyLDE2IEBAIHN0YXRpYyB2b2lkIGluaXRf YW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAkJCXdhcm5pbmdfYWRkKHRl eHQpOwogCQl9CiAJCWJyZWFrOworCisJY2FzZSAweDE5OgorCQkvKgorCQkg KiBaZW4zIChGYW0xOWggbW9kZWwgPCAweDEwKSBwYXJ0cyBhcmUgbm90IHN1 c2NlcHRpYmxlIHRvCisJCSAqIEJyYW5jaCBUeXBlIENvbmZ1c2lvbiwgYnV0 IHByZWRhdGUgdGhlIGFsbG9jYXRpb24gb2YgdGhlCisJCSAqIEJUQ19OTyBi aXQuICBGaWxsIGl0IGJhY2sgaW4gaWYgd2UncmUgbm90IHZpcnR1YWxpc2Vk LgorCQkgKi8KKwkJaWYgKCFjcHVfaGFzX2h5cGVydmlzb3IgJiYgIWNwdV9o YXMoYywgWDg2X0ZFQVRVUkVfQlRDX05PKSkKKwkJCV9fc2V0X2JpdChYODZf RkVBVFVSRV9CVENfTk8sIGMtPng4Nl9jYXBhYmlsaXR5KTsKKwkJYnJlYWs7 CiAJfQogCiAJZGlzcGxheV9jYWNoZWluZm8oYyk7CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggY2VkMGY4YzJhZWE2Li45ZjY2YzcxNTUxNmMgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTM4OCw3ICszODgsNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCisgICAgcHJp bnRrKCIgIEhhcmR3YXJlIGhpbnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlc1xuIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUkRD TF9OTykgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUkRDTF9OTyIgICAg ICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBTX0lCUlNf QUxMKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUlNfQUxMIiAgICAg ICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19SU0JBKSAg ICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBSU0JBIiAgICAgICAgICAg OiAiIiwKQEAgLTQwMyw3ICs0MDMsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQg cHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywgdWludDY0X3Qg Y2FwcykKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19BTFdBWVMpKSAgICA/ICIgSUJSU19BTFdBWVMiICAgIDog IiIsCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIi LAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVS RV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwK LSAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVf SUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIpOwor ICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9J QlJTX1NBTUVfTU9ERSkpID8gIiBJQlJTX1NBTUVfTU9ERSIgOiAiIiwKKyAg ICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRD X05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIpOwogCiAg ICAgLyogSGFyZHdhcmUgZmVhdHVyZXMgd2hpY2ggbmVlZCBkcml2aW5nIHRv IG1pdGlnYXRlIGlzc3Vlcy4gKi8KICAgICBwcmludGsoIiAgSGFyZHdhcmUg ZmVhdHVyZXM6JXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLApkaWZmIC0t Z2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVz ZXQuaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJl c2V0LmgKaW5kZXggOTY4NmM4MmVkNzVjLi4xYmJjN2RhNGI1M2MgMTAwNjQ0 Ci0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJl c2V0LmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZl YXR1cmVzZXQuaApAQCAtMjY1LDYgKzI2NSw3IEBAIFhFTl9DUFVGRUFUVVJF KEFNRF9TU0JELCAgICAgIDgqMzIrMjQpIC8qUyAgTVNSX1NQRUNfQ1RSTC5T U0JEIGF2YWlsYWJsZSAqLwogWEVOX0NQVUZFQVRVUkUoVklSVF9TU0JELCAg ICAgOCozMisyNSkgLyogICBNU1JfVklSVF9TUEVDX0NUUkwuU1NCRCAqLwog WEVOX0NQVUZFQVRVUkUoU1NCX05PLCAgICAgICAgOCozMisyNikgLypBICBI YXJkd2FyZSBub3QgdnVsbmVyYWJsZSB0byBTU0IgKi8KIFhFTl9DUFVGRUFU VVJFKFBTRkQsICAgICAgICAgIDgqMzIrMjgpIC8qUyAgTVNSX1NQRUNfQ1RS TC5QU0ZEICovCitYRU5fQ1BVRkVBVFVSRShCVENfTk8sICAgICAgICA4KjMy KzI5KSAvKkEgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIEJyYW5jaCBU eXBlIENvbmZ1c2lvbiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-7.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-7.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW5hYmxlIFplbjIgY2hpY2tl bmJpdAoKLi4uIGFzIGluc3RydWN0ZWQgaW4gdGhlIEJyYW5jaCBUeXBlIENv bmZ1c2lvbiB3aGl0ZXBhcGVyLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2FtZC5jCmluZGV4IDY3NWI4Nzdm MTkzYy4uNjBkYmU2MWE2MWNhIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKQEAgLTcz MSw2ICs3MzEsMzEgQEAgdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYykKIAkJcHJpbnRrX29uY2UoWEVOTE9HX0VSUiAi Tm8gU1NCRCBjb250cm9scyBhdmFpbGFibGVcbiIpOwogfQogCisvKgorICog T24gWmVuMiB3ZSBvZmZlciB0aGlzIGNoaWNrZW4gKGJpdCkgb24gdGhlIGFs dGFyIG9mIFNwZWN1bGF0aW9uLgorICoKKyAqIFJlZmVyIHRvIHRoZSBBTUQg QnJhbmNoIFR5cGUgQ29uZnVzaW9uIHdoaXRlcGFwZXI6CisgKiBodHRwczov L1hYWAorICoKKyAqIFNldHRpbmcgdGhpcyB1bm5hbWVkIGJpdCBzdXBwb3Nl ZGx5IGNhdXNlcyBwcmVkaWN0aW9uIGluZm9ybWF0aW9uIG9uCisgKiBub24t YnJhbmNoIGluc3RydWN0aW9ucyB0byBiZSBpZ25vcmVkLiAgSXQgaXMgdG8g YmUgc2V0IHVuaWxhdGVyYWxseSBpbgorICogbmV3ZXIgbWljcm9jb2RlLgor ICoKKyAqIFRoaXMgY2hpY2tlbmJpdCBpcyBzb21ldGhpbmcgdW5yZWxhdGVk IG9uIFplbjEsIGFuZCBaZW4xIHZzIFplbjIgaXNuJ3QgYQorICogc2ltcGxl IG1vZGVsIG51bWJlciBjb21wYXJpc29uLCBzbyB1c2UgU1RJQlAgYXMgYSBo ZXVyaXN0aWMgdG8gc2VwYXJhdGUgdGhlCisgKiB0d28gdWFyY2hlcyBpbiBG YW0xN2goQU1EKS8xOGgoSHlnb24pLgorICovCit2b2lkIGFtZF9pbml0X3Nw ZWN0cmFsX2NoaWNrZW4odm9pZCkKK3sKKwl1aW50NjRfdCB2YWwsIGNoaWNr ZW5iaXQgPSAxIDw8IDE7CisKKwlpZiAoY3B1X2hhc19oeXBlcnZpc29yIHx8 ICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkKKwkJcmV0 dXJuOworCisJaWYgKHJkbXNyX3NhZmUoTVNSX0FNRDY0X0RFX0NGRzIsIHZh bCkgPT0gMCAmJiAhKHZhbCAmIGNoaWNrZW5iaXQpKQorCQl3cm1zcl9zYWZl KE1TUl9BTUQ2NF9ERV9DRkcyLCB2YWwgfCBjaGlja2VuYml0KTsKK30KKwog c3RhdGljIHZvaWQgaW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKQog ewogCXUzMiBsLCBoOwpAQCAtNzgzLDYgKzgwOCw5IEBAIHN0YXRpYyB2b2lk IGluaXRfYW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAogCWFtZF9pbml0 X3NzYmQoYyk7CiAKKwlpZiAoYy0+eDg2ID09IDB4MTcpCisJCWFtZF9pbml0 X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwogCS8qIE1GRU5DRSBzdG9wcyBSRFRT QyBzcGVjdWxhdGlvbiAqLwogCWlmICghY3B1X2hhc19sZmVuY2VfZGlzcGF0 Y2gpCiAJCV9fc2V0X2JpdChYODZfRkVBVFVSRV9NRkVOQ0VfUkRUU0MsIGMt Png4Nl9jYXBhYmlsaXR5KTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvY3B1LmggYi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCmluZGV4IDFhNWIz OTE4YjM3ZS4uZTc2YWI1Y2UxYWUyIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94 ODYvY3B1L2NwdS5oCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvY3B1LmgKQEAg LTIyLDMgKzIyLDQgQEAgdm9pZCBlYXJseV9pbml0X2FtZChzdHJ1Y3QgY3B1 aW5mb194ODYgKmMpOwogdm9pZCBhbWRfbG9nX2ZyZXEoY29uc3Qgc3RydWN0 IGNwdWluZm9feDg2ICpjKTsKIHZvaWQgYW1kX2luaXRfbGZlbmNlKHN0cnVj dCBjcHVpbmZvX3g4NiAqYyk7CiB2b2lkIGFtZF9pbml0X3NzYmQoY29uc3Qg c3RydWN0IGNwdWluZm9feDg2ICpjKTsKK3ZvaWQgYW1kX2luaXRfc3BlY3Ry YWxfY2hpY2tlbih2b2lkKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvaHlnb24uYyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYwppbmRleCAz ODQ1ZTBjZjBlODkuLjBjYjBlN2Q1NWU2MSAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gveDg2L2NwdS9oeWdvbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHln b24uYwpAQCAtMzYsNiArMzYsMTIgQEAgc3RhdGljIHZvaWQgaW5pdF9oeWdv bihzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAKIAlhbWRfaW5pdF9zc2JkKGMp OwogCisJLyoKKwkgKiBUT0RPOiBDaGVjayBoZXVyaXN0aWMgc2FmZXR5IHdp dGggSHlnb24gZmlyc3QKKwlpZiAoYy0+eDg2ID09IDB4MTgpCisJCWFtZF9p bml0X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwkgKi8KKwogCS8qIE1GRU5DRSBz dG9wcyBSRFRTQyBzcGVjdWxhdGlvbiAqLwogCWlmICghY3B1X2hhc19sZmVu Y2VfZGlzcGF0Y2gpCiAJCV9fc2V0X2JpdChYODZfRkVBVFVSRV9NRkVOQ0Vf UkRUU0MsIGMtPng4Nl9jYXBhYmlsaXR5KTsKZGlmZiAtLWdpdCBhL3hlbi9p bmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmggYi94ZW4vaW5jbHVkZS9hc20t eDg2L21zci1pbmRleC5oCmluZGV4IDFlNzQzNDYxZTkxZC4uYjRhMzYwNzIz YjE0IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L21zci1pbmRl eC5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvbXNyLWluZGV4LmgKQEAg LTM1OSw2ICszNTksNyBAQAogI2RlZmluZSBNU1JfQU1ENjRfREVfQ0ZHCQkw eGMwMDExMDI5CiAjZGVmaW5lIEFNRDY0X0RFX0NGR19MRkVOQ0VfU0VSSUFM SVNFCShfQUMoMSwgVUxMKSA8PCAxKQogI2RlZmluZSBNU1JfQU1ENjRfRVhf Q0ZHCQkweGMwMDExMDJjCisjZGVmaW5lIE1TUl9BTUQ2NF9ERV9DRkcyCQkw eGMwMDExMGUzCiAKICNkZWZpbmUgTVNSX0FNRDY0X0RSMF9BRERSRVNTX01B U0sJMHhjMDAxMTAyNwogI2RlZmluZSBNU1JfQU1ENjRfRFIxX0FERFJFU1Nf TUFTSwkweGMwMDExMDE5Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.15-8.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.15-8.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQnJhbmNoIFR5 cGUgQ29uZnVzaW9uIHdoZW4gcG9zc2libGUKCkJyYW5jaCBUeXBlIENvbmZ1 c2lvbiBhZmZlY3RzIEFNRC9IeWdvbiBDUFVzIG9uIFplbjIgYW5kIGVhcmxp ZXIuICBUbwptaXRpZ2F0ZSwgd2UgcmVxdWlyZSBTTVQgc2FmZXR5IChTVElC UCBvbiBaZW4yLCBuby1TTVQgb24gWmVuMSksIGFuZCB0byBpc3N1ZQphbiBJ QlBCIG9uIGVhY2ggZW50cnkgdG8gWGVuLCB0byBmbHVzaCB0aGUgQlRCLgoK RHVlIHRvIHBlcmZvcm1hbmNlIGNvbmNlcm5zLCBkb20wICh3aGljaCBpcyB0 cnVzdGVkIGluIG1vc3QgY29uZmlndXJhdGlvbnMpIGlzCmV4Y2x1ZGVkIGZy b20gcHJvdGVjdGlvbnMgYnkgZGVmYXVsdC4KClRoZXJlZm9yZToKICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgb24gWmVuMiB0b28sIHdoaWNoIG5vdyBtZWFu cyB3ZSB3YW50IGl0IG9uIGJ5IGRlZmF1bHQKICAgb24gYWxsIGhhcmR3YXJl IHN1cHBvcnRpbmcgU1RJQlAuCiAqIEJyZWFrIHRoZSBjdXJyZW50IElCUEIg bG9naWMgb3V0IGludG8gYSBuZXcgZnVuY3Rpb24sIGV4dGVuZGluZyBpdCB3 aXRoCiAgIElCUEItYXQtZW50cnkgbG9naWMuCiAqIENoYW5nZSB0aGUgZXhp c3RpbmcgSUJQQi1hdC1jdHh0LXN3aXRjaCBib29sZWFuIHRvIGJlIHRyaXN0 YXRlLCBhbmQgZGlzYWJsZQogICBpdCBieSBkZWZhdWx0IHdoZW4gSUJQQi1h dC1lbnRyeSBpcyBwcm92aWRpbmcgc3VmZmljaWVudCBzYWZldHkuCgpJZiBh bGwgUFYgZ3Vlc3RzIG9uIHRoZSBzeXN0ZW0gYXJlIHRydXN0ZWQsIHRoZW4g aXQgaXMgcmVjb21tZW5kZWQgdG8gYm9vdAp3aXRoIGBzcGVjLWN0cmw9aWJw Yi1lbnRyeT1uby1wdmAsIGFzIHRoaXMgd2lsbCBwcm92aWRlIGFuIGFkZGl0 aW9uYWwgbWFyZ2luYWwKcGVyZiBpbXByb3ZlbWVudC4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDA3IC8gQ1ZFLTIwMjItMjM4MjUuCgpTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoK ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRv YyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYwppbmRleCBi MDZkYjVmNjU0ZTUuLmI3M2M0YTYwNTAxMSAxMDA2NDQKLS0tIGEvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCisrKyBiL2RvY3MvbWlzYy94 ZW4tY29tbWFuZC1saW5lLnBhbmRvYwpAQCAtMjE3MCw3ICsyMTcwLDcgQEAg QnkgZGVmYXVsdCBTU0JEIHdpbGwgYmUgbWl0aWdhdGVkIGF0IHJ1bnRpbWUg KGkuZSBgc3NiZD1ydW50aW1lYCkuCiAKICMjIyBzcGVjLWN0cmwgKHg4NikK ID4gYD0gTGlzdCBvZiBbIDxib29sPiwgeGVuPTxib29sPiwge3B2LGh2bX09 PGJvb2w+LAotPiAgICAgICAgICAgICAge21zci1zYyxyc2IsbWQtY2xlYXJ9 PTxib29sPnx7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAgICAgICB7bXNy LXNjLHJzYixtZC1jbGVhcixpYnBiLWVudHJ5fT08Ym9vbD58e3B2LGh2bX09 PGJvb2w+LAogPiAgICAgICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxs ZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQscHNmZCwKID4gICAgICAgICAg ICAgIGVhZ2VyLWZwdSxsMWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9j aywKID4gICAgICAgICAgICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKQEAg LTIxOTUsOSArMjE5NSwxMCBAQCBpbiBwbGFjZSBmb3IgZ3Vlc3RzIHRvIHVz ZS4KIAogVXNlIG9mIGEgcG9zaXRpdmUgYm9vbGVhbiB2YWx1ZSBmb3IgZWl0 aGVyIG9mIHRoZXNlIG9wdGlvbnMgaXMgaW52YWxpZC4KIAotVGhlIGBwdj1g LCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gIGFuZCBgbWQtY2xlYXI9YCBv cHRpb25zIG9mZmVyIGZpbmUKLWdyYWluZWQgY29udHJvbCBvdmVyIHRoZSBw cmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGltcGFjdCBYZW4ncyBhYmlsaXR5 IHRvCi1wcm90ZWN0IGl0c2VsZiwgYW5kL29yIFhlbidzIGFiaWxpdHkgdG8g dmlydHVhbGlzZSBzdXBwb3J0IGZvciBndWVzdHMgdG8gdXNlLgorVGhlIGBw dj1gLCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gLCBgbWQtY2xlYXI9YCBh bmQgYGlicGItZW50cnk9YCBvcHRpb25zCitvZmZlciBmaW5lIGdyYWluZWQg Y29udHJvbCBvdmVyIHRoZSBwcmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGlt cGFjdCBYZW4ncworYWJpbGl0eSB0byBwcm90ZWN0IGl0c2VsZiwgYW5kL29y IFhlbidzIGFiaWxpdHkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgorZ3Vl c3RzIHRvIHVzZS4KIAogKiBgcHY9YCBhbmQgYGh2bT1gIG9mZmVyIGNvbnRy b2wgb3ZlciBhbGwgc3Vib3B0aW9ucyBmb3IgUFYgYW5kIEhWTSBndWVzdHMK ICAgcmVzcGVjdGl2ZWx5LgpAQCAtMjIxNiw2ICsyMjE3LDExIEBAIHByb3Rl Y3QgaXRzZWxmLCBhbmQvb3IgWGVuJ3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNl IHN1cHBvcnQgZm9yIGd1ZXN0cyB0byB1c2UuCiAgIGNvbXBhdGliaWxpdHkg d2l0aCBkZXZlbG9wbWVudCB2ZXJzaW9ucyBvZiB0aGlzIGZpeCwgYG1kcz1g IGlzIGFsc28gYWNjZXB0ZWQKICAgb24gWGVuIDQuMTIgYW5kIGVhcmxpZXIg YXMgYW4gYWxpYXMuICBDb25zdWx0IHZlbmRvciBkb2N1bWVudGF0aW9uIGlu CiAgIHByZWZlcmVuY2UgdG8gaGVyZS4qCisqIGBpYnBiLWVudHJ5PWAgb2Zm ZXJzIGNvbnRyb2wgb3ZlciB3aGV0aGVyIElCUEIgKEluZGlyZWN0IEJyYW5j aCBQcmVkaWN0aW9uCisgIEJhcnJpZXIpIGlzIHVzZWQgb24gZW50cnkgdG8g WGVuLiAgVGhpcyBpcyB1c2VkIGJ5IGRlZmF1bHQgb24gaGFyZHdhcmUKKyAg dnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucywgZG9tMCBpcworICB1bnByb3RlY3RlZCBi eSBkZWZhdWx0LiAgSWYgaXQgbmVjZXNzYXJ5IHRvIHByb3RlY3QgZG9tMCB0 b28sIGJvb3Qgd2l0aAorICBgc3BlYy1jdHJsPWlicGItZW50cnlgLgogCiBJ ZiBYZW4gd2FzIGNvbXBpbGVkIHdpdGggSU5ESVJFQ1RfVEhVTksgc3VwcG9y dCwgYGJ0aS10aHVuaz1gIGNhbiBiZSB1c2VkIHRvCiBzZWxlY3Qgd2hpY2gg b2YgdGhlIHRodW5rcyBnZXRzIHBhdGNoZWQgaW50byB0aGUgYF9feDg2X2lu ZGlyZWN0X3RodW5rXyVyZWdgCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXgg OWY2NmM3MTU1MTZjLi41NjM1MTljZTBlMzEgMTAwNjQ0Ci0tLSBhL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKQEAgLTM5LDYgKzM5LDEwIEBAIHN0YXRpYyBib29sIF9faW5pdGRh dGEgb3B0X3JzYl9odm0gPSB0cnVlOwogc3RhdGljIGludDhfdCBfX3JlYWRf bW9zdGx5IG9wdF9tZF9jbGVhcl9wdiA9IC0xOwogc3RhdGljIGludDhfdCBf X3JlYWRfbW9zdGx5IG9wdF9tZF9jbGVhcl9odm0gPSAtMTsKIAorc3RhdGlj IGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBiX2VudHJ5X3B2ID0gLTE7 CitzdGF0aWMgaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJfZW50cnlf aHZtID0gLTE7CitzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBi X2VudHJ5X2RvbTA7CisKIC8qIENtZGxpbmUgY29udHJvbHMgZm9yIFhlbidz IHNwZWN1bGF0aXZlIHNldHRpbmdzLiAqLwogc3RhdGljIGVudW0gaW5kX3Ro dW5rIHsKICAgICBUSFVOS19ERUZBVUxULCAvKiBEZWNpZGUgd2hpY2ggdGh1 bmsgdG8gdXNlIGF0IGJvb3QgdGltZS4gKi8KQEAgLTU0LDcgKzU4LDcgQEAg aW50OF90IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7CiBib29sIF9fcmVh ZF9tb3N0bHkgb3B0X3NzYmQ7CiBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfcHNm ZCA9IC0xOwogCi1ib29sIF9fcmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9z d2l0Y2ggPSB0cnVlOworaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJf Y3R4dF9zd2l0Y2ggPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9l YWdlcl9mcHUgPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9sMWRf Zmx1c2ggPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBvcHRfYnJhbmNoX2hh cmRlbiA9IHRydWU7CkBAIC0xMTQsNiArMTE4LDkgQEAgc3RhdGljIGludCBf X2luaXQgcGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAg ICAgICBvcHRfcnNiX2h2bSA9IGZhbHNlOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX3B2ID0gMDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0g PSAwOworICAgICAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAwOworICAg ICAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gMDsKKyAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKIAogICAgICAgICAgICAg b3B0X3RodW5rID0gVEhVTktfSk1QOwogICAgICAgICAgICAgb3B0X2licnMg PSAwOwpAQCAtMTQwLDEyICsxNDcsMTQgQEAgc3RhdGljIGludCBfX2luaXQg cGFyc2Vfc3BlY19jdHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAgICAgICBv cHRfbXNyX3NjX3B2ID0gdmFsOwogICAgICAgICAgICAgb3B0X3JzYl9wdiA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9wdiA9IHZhbDsKKyAg ICAgICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gdmFsOwogICAgICAgICB9 CiAgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaHZt Iiwgcywgc3MpKSA+PSAwICkKICAgICAgICAgewogICAgICAgICAgICAgb3B0 X21zcl9zY19odm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfcnNiX2h2bSA9 IHZhbDsKICAgICAgICAgICAgIG9wdF9tZF9jbGVhcl9odm0gPSB2YWw7Cisg ICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9odm0gPSB2YWw7CiAgICAgICAg IH0KICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJt c3Itc2MiLCBzLCBzcykpICE9IC0xICkKICAgICAgICAgewpAQCAtMjEwLDYg KzIxOSwyOCBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQorICAgICAgICBlbHNlIGlmICggKHZhbCA9 IHBhcnNlX2Jvb2xlYW4oImlicGItZW50cnkiLCBzLCBzcykpICE9IC0xICkK KyAgICAgICAgeworICAgICAgICAgICAgc3dpdGNoICggdmFsICkKKyAgICAg ICAgICAgIHsKKyAgICAgICAgICAgIGNhc2UgMDoKKyAgICAgICAgICAgIGNh c2UgMToKKyAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IG9w dF9pYnBiX2VudHJ5X2h2bSA9CisgICAgICAgICAgICAgICAgICAgIG9wdF9p YnBiX2VudHJ5X2RvbTAgPSB2YWw7CisgICAgICAgICAgICAgICAgYnJlYWs7 CisKKyAgICAgICAgICAgIGNhc2UgLTI6CisgICAgICAgICAgICAgICAgcyAr PSBzdHJsZW4oImlicGItZW50cnk9Iik7CisgICAgICAgICAgICAgICAgaWYg KCAodmFsID0gcGFyc2VfYm9vbGVhbigicHYiLCBzLCBzcykpID49IDAgKQor ICAgICAgICAgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IHZhbDsK KyAgICAgICAgICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xl YW4oImh2bSIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAgICAg IG9wdF9pYnBiX2VudHJ5X2h2bSA9IHZhbDsKKyAgICAgICAgICAgICAgICBl bHNlCisgICAgICAgICAgICBkZWZhdWx0OgorICAgICAgICAgICAgICAgICAg ICByYyA9IC1FSU5WQUw7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB9CisgICAgICAgIH0KIAogICAgICAgICAvKiBYZW4ncyBzcGVj dWxhdGl2ZSBzaWRlY2hhbm5lbCBtaXRpZ2F0aW9uIHNldHRpbmdzLiAqLwog ICAgICAgICBlbHNlIGlmICggIXN0cm5jbXAocywgImJ0aS10aHVuaz0iLCAx MCkgKQpAQCAtNDc3LDI3ICs1MDgsMzEgQEAgc3RhdGljIHZvaWQgX19pbml0 IHByaW50X2RldGFpbHMoZW51bSBpbmRfdGh1bmsgdGh1bmssIHVpbnQ2NF90 IGNhcHMpCiAgICAgICogbWl0aWdhdGlvbiBzdXBwb3J0IGZvciBndWVzdHMu CiAgICAgICovCiAjaWZkZWYgQ09ORklHX0hWTQotICAgIHByaW50aygiICBT dXBwb3J0IGZvciBIVk0gVk1zOiVzJXMlcyVzJXNcbiIsCisgICAgcHJpbnRr KCIgIFN1cHBvcnQgZm9yIEhWTSBWTXM6JXMlcyVzJXMlcyVzXG4iLAogICAg ICAgICAgICAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9IVk0p IHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0Nf UlNCX0hWTSkgfHwKICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVB VFVSRV9NRF9DTEVBUikgICB8fAorICAgICAgICAgICAgYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfSFZNKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTSkgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9IVk0pICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICNlbmRpZgogI2lmZGVmIENPTkZJR19QVgotICAgIHByaW50 aygiICBTdXBwb3J0IGZvciBQViBWTXM6JXMlcyVzJXMlc1xuIiwKKyAgICBw cmludGsoIiAgU3VwcG9ydCBmb3IgUFYgVk1zOiVzJXMlcyVzJXMlc1xuIiwK ICAgICAgICAgICAgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19NU1Jf UFYpIHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVf U0NfUlNCX1BWKSB8fAogICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX01EX0NMRUFSKSAgfHwKKyAgICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9JQlBCX0VOVFJZX1BWKSB8fAogICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSkgICAgICAgICAgICAgICAgICAgICAgICAgICA/ICIi ICAgICAgICAgICAgICAgOiAiIE5vbmUiLAogICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX1BWKSAgICAgICA/ICIgTVNSX1NQ RUNfQ1RSTCIgOiAiIiwKICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX1NDX1JTQl9QVikgICAgICAgPyAiIFJTQiIgICAgICAgICAgIDog IiIsCiAgICAgICAgICAgIG9wdF9lYWdlcl9mcHUgICAgICAgICAgICAgICAg ICAgICAgICAgICAgID8gIiBFQUdFUl9GUFUiICAgICA6ICIiLAotICAgICAg ICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAg ICA/ICIgTURfQ0xFQVIiICAgICAgOiAiIik7CisgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9D TEVBUiIgICAgICA6ICIiLAorICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQl9FTlRSWV9QVikgICA/ICIgSUJQQi1lbnRyeSIgICAg OiAiIik7CiAKICAgICBwcmludGsoIiAgWFBUSSAoNjQtYml0IFBWIG9ubHkp OiBEb20wICVzLCBEb21VICVzICh3aXRoJXMgUENJRClcbiIsCiAgICAgICAg ICAgIG9wdF94cHRpX2h3ZG9tID8gImVuYWJsZWQiIDogImRpc2FibGVkIiwK QEAgLTczMCw2ICs3NjUsNTUgQEAgc3RhdGljIGJvb2wgX19pbml0IHNob3Vs ZF91c2VfZWFnZXJfZnB1KHZvaWQpCiAgICAgfQogfQogCitzdGF0aWMgdm9p ZCBfX2luaXQgaWJwYl9jYWxjdWxhdGlvbnModm9pZCkKK3sKKyAgICAvKiBD aGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3VwcG9ydCBiZWZvcmUgdXNp bmcgaXQuLi4gKi8KKyAgICBpZiAoICFib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikg KQorICAgIHsKKyAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gb3B0X2li cGJfZW50cnlfcHYgPSBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9IDA7CisgICAg ICAgIG9wdF9pYnBiX2VudHJ5X2RvbTAgPSBmYWxzZTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KKworICAgIC8qCisgICAgICogSUJQQi1vbi1lbnRyeSBt aXRpZ2F0aW9ucyBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgorICAgICAq CisgICAgICogSUJQQiAmJiAhQlRDX05PIHNlbGVjdHMgYWxsIEFNRC9IeWdv biBoYXJkd2FyZSwgbm90IGtub3duIHRvIGJlIHNhZmUsCisgICAgICogdGhh dCB3ZSBjYW4gcHJvdmlkZSBzb21lIGZvcm0gb2YgbWl0aWdhdGlvbiBvbi4K KyAgICAgKi8KKyAgICBpZiAoIG9wdF9pYnBiX2VudHJ5X3B2ID09IC0xICkK KyAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSAoSVNfRU5BQkxFRChDT05G SUdfUFYpICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0JUQ19O TykpOworICAgIGlmICggb3B0X2licGJfZW50cnlfaHZtID09IC0xICkKKyAg ICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gKElTX0VOQUJMRUQoQ09ORklH X0hWTSkgJiYKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb3Rf Y3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSAmJgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9CVENf Tk8pKTsKKworICAgIGlmICggb3B0X2licGJfZW50cnlfcHYgKQorICAgIHsK KyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9JQlBC X0VOVFJZX1BWKTsKKworICAgICAgICAvKgorICAgICAgICAgKiBXZSBvbmx5 IG5lZWQgdG8gZmx1c2ggaW4gSVNUIGNvbnRleHQgaWYgd2UncmUgcHJvdGVj dGluZyBhZ2FpbnN0IFBWCisgICAgICAgICAqIGd1ZXN0cy4gIEhWTSBJQlBC LW9uLWVudHJ5IHByb3RlY3Rpb25zIGFyZSBib3RoIGF0b21pYyB3aXRoCisg ICAgICAgICAqIE5NSS8jTUMsIHNvIGNhbid0IGludGVycnVwdCBYZW4gYWhl YWQgb2YgaGF2aW5nIGFscmVhZHkgZmx1c2hlZCB0aGUKKyAgICAgICAgICog QlRCLgorICAgICAgICAgKi8KKyAgICAgICAgZGVmYXVsdF9zcGVjX2N0cmxf ZmxhZ3MgfD0gU0NGX2lzdF9pYnBiOworICAgIH0KKyAgICBpZiAoIG9wdF9p YnBiX2VudHJ5X2h2bSApCisgICAgICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAo WDg2X0ZFQVRVUkVfSUJQQl9FTlRSWV9IVk0pOworCisgICAgLyoKKyAgICAg KiBJZiB3ZSdyZSB1c2luZyBJQlBCLW9uLWVudHJ5IHRvIHByb3RlY3QgYWdh aW5zdCBQViBhbmQgSFZNIGd1ZXN0cworICAgICAqIChpZ25vcmluZyBkb20w IGlmIHRydXN0ZWQpLCB0aGVuIHRoZXJlJ3Mgbm8gbmVlZCB0byBhbHNvIGlz c3VlIElCUEIgb24KKyAgICAgKiBjb250ZXh0IHN3aXRjaCB0b28uCisgICAg ICovCisgICAgaWYgKCBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9PSAtMSApCisg ICAgICAgIG9wdF9pYnBiX2N0eHRfc3dpdGNoID0gIShvcHRfaWJwYl9lbnRy eV9odm0gJiYgb3B0X2licGJfZW50cnlfcHYpOworfQorCiAvKiBDYWxjdWxh dGUgd2hldGhlciB0aGlzIENQVSBpcyB2dWxuZXJhYmxlIHRvIEwxVEYuICov CiBzdGF0aWMgX19pbml0IHZvaWQgbDF0Zl9jYWxjdWxhdGlvbnModWludDY0 X3QgY2FwcykKIHsKQEAgLTk4NSw4ICsxMDY5LDEyIEBAIHZvaWQgc3BlY19j dHJsX2luaXRfZG9tYWluKHN0cnVjdCBkb21haW4gKmQpCiAgICAgYm9vbCB2 ZXJ3ID0gKChwdiA/IG9wdF9tZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9o dm0pIHx8CiAgICAgICAgICAgICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAm JiBpc19pb21tdV9lbmFibGVkKGQpKSk7CiAKKyAgICBib29sIGlicGIgPSAo KHB2ID8gb3B0X2licGJfZW50cnlfcHYgOiBvcHRfaWJwYl9lbnRyeV9odm0p ICYmCisgICAgICAgICAgICAgICAgIChkLT5kb21haW5faWQgIT0gMCB8fCBv cHRfaWJwYl9lbnRyeV9kb20wKSk7CisKICAgICBkLT5hcmNoLnNwZWNfY3Ry bF9mbGFncyA9CiAgICAgICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAgICAg IDogMCkgfAorICAgICAgICAoaWJwYiAgID8gU0NGX2VudHJ5X2licGIgICA6 IDApIHwKICAgICAgICAgMDsKIH0KIApAQCAtMTEzMywxMiArMTIyMSwxNSBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgfQogCiAgICAgLyoKLSAgICAgKiBVc2UgU1RJQlAgYnkgZGVm YXVsdCBpZiB0aGUgaGFyZHdhcmUgaGludCBpcyBzZXQuICBPdGhlcndpc2Us IGxlYXZlIGl0Ci0gICAgICogb2ZmIGFzIGl0IGEgc2V2ZXJlIHBlcmZvcm1h bmNlIHBlbnRhbHR5IG9uIHByZS1lSUJSUyBJbnRlbCBoYXJkd2FyZQotICAg ICAqIHdoZXJlIGl0IHdhcyByZXRyb2ZpdHRlZCBpbiBtaWNyb2NvZGUuCisg ICAgICogVXNlIFNUSUJQIGJ5IGRlZmF1bHQgb24gYWxsIEFNRCBzeXN0ZW1z LiAgWmVuMyBhbmQgbGF0ZXIgZW51bWVyYXRlCisgICAgICogU1RJQlBfQUxX QVlTLCBidXQgU1RJQlAgaXMgbmVlZGVkIG9uIFplbjIgYXMgcGFydCBvZiB0 aGUgbWl0aWdhdGlvbnMKKyAgICAgKiBmb3IgQnJhbmNoIFR5cGUgQ29uZnVz aW9uLgorICAgICAqCisgICAgICogTGVhdmUgU1RJQlAgb2ZmIGJ5IGRlZmF1 bHQgb24gSW50ZWwuICBQcmUtZUlCUlMgc3lzdGVtcyBzdWZmZXIgYQorICAg ICAqIHN1YnN0YW50aWFsIHBlcmYgaGl0IHdoZW4gaXQgd2FzIGltcGxlbWVu dGVkIGluIG1pY3JvY29kZS4KICAgICAgKi8KICAgICBpZiAoIG9wdF9zdGli cCA9PSAtMSApCi0gICAgICAgIG9wdF9zdGlicCA9ICEhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUyk7CisgICAgICAgIG9wdF9zdGli cCA9ICEhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0FNRF9TVElCUCk7CiAK ICAgICBpZiAoIG9wdF9zdGlicCAmJiAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX1NUSUJQKSB8fAogICAgICAgICAgICAgICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkgKQpAQCAtMTE5Miw5ICsx MjgzLDcgQEAgdm9pZCBfX2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0 aW9ucyh2b2lkKQogICAgIGlmICggb3B0X3JzYl9odm0gKQogICAgICAgICBz ZXR1cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0pOwog Ci0gICAgLyogQ2hlY2sgd2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQg YmVmb3JlIHVzaW5nIGl0Li4uICovCi0gICAgaWYgKCAhYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX0lCUEIpICkKLSAgICAgICAgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSBm YWxzZTsKKyAgICBpYnBiX2NhbGN1bGF0aW9ucygpOwogCiAgICAgLyogQ2hl Y2sgd2hldGhlciBFYWdlciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVm YXVsdC4gKi8KICAgICBpZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQpkaWZm IC0tZ2l0IGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmgKaW5kZXggMTBjZDBjZDI1 MThmLi4zM2U4NDU5OTFiMGEgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2Fz bS14ODYvc3BlY19jdHJsLmgKKysrIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9z cGVjX2N0cmwuaApAQCAtNjUsNyArNjUsNyBAQAogdm9pZCBpbml0X3NwZWN1 bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpOwogdm9pZCBzcGVjX2N0cmxfaW5p dF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCk7CiAKLWV4dGVybiBib29sIG9w dF9pYnBiX2N0eHRfc3dpdGNoOworZXh0ZXJuIGludDhfdCBvcHRfaWJwYl9j dHh0X3N3aXRjaDsKIGV4dGVybiBib29sIG9wdF9zc2JkOwogZXh0ZXJuIGlu dDhfdCBvcHRfZWFnZXJfZnB1OwogZXh0ZXJuIGludDhfdCBvcHRfbDFkX2Zs dXNoOwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-1.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-1.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIHNwZWNfY3RybF9m bGFncyBjb250ZXh0IHN3aXRjaGluZwoKV2UgYXJlIHNob3J0bHkgZ29pbmcg dG8gbmVlZCB0byBjb250ZXh0IHN3aXRjaCBuZXcgYml0cyBpbiBib3RoIHRo ZSB2Y3B1IGFuZApTMyBwYXRocy4gIEludHJvZHVjZSBTQ0ZfSVNUX01BU0sg YW5kIFNDRl9ET01fTUFTSywgYW5kIHJld29yayBkLT5hcmNoLnZlcncKaW50 byBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyB0byBhY2NvbW1vZGF0ZS4KCk5v IGZ1bmN0aW9uYWwgY2hhbmdlLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVs aWNoQHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9hY3Bp L3Bvd2VyLmMgYi94ZW4vYXJjaC94ODYvYWNwaS9wb3dlci5jCmluZGV4IDVl YWE3N2Y2NmEyOC4uZGQzOTdmNzEzMDY3IDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvYWNwaS9wb3dlci5jCisrKyBiL3hlbi9hcmNoL3g4Ni9hY3BpL3Bv d2VyLmMKQEAgLTI0OCw4ICsyNDgsOCBAQCBzdGF0aWMgaW50IGVudGVyX3N0 YXRlKHUzMiBzdGF0ZSkKICAgICAgICAgZXJyb3IgPSAwOwogCiAgICAgY2kg PSBnZXRfY3B1X2luZm8oKTsKLSAgICAvKiBBdm9pZCBOTUkvI01DIHVzaW5n IE1TUl9TUEVDX0NUUkwgdW50aWwgd2UndmUgcmVsb2FkZWQgbWljcm9jb2Rl LiAqLwotICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3MgJj0gflNDRl9pc3Rfd3Jt c3I7CisgICAgLyogQXZvaWQgTk1JLyNNQyB1c2luZyB1bnNhZmUgTVNScyB1 bnRpbCB3ZSd2ZSByZWxvYWRlZCBtaWNyb2NvZGUuICovCisgICAgY2ktPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX0lTVF9NQVNLOwogCiAgICAgQUNQSV9G TFVTSF9DUFVfQ0FDSEUoKTsKIApAQCAtMjkyLDggKzI5Miw4IEBAIHN0YXRp YyBpbnQgZW50ZXJfc3RhdGUodTMyIHN0YXRlKQogICAgIGlmICggIXJlY2hl Y2tfY3B1X2ZlYXR1cmVzKDApICkKICAgICAgICAgcGFuaWMoIk1pc3Npbmcg cHJldmlvdXNseSBhdmFpbGFibGUgZmVhdHVyZShzKVxuIik7CiAKLSAgICAv KiBSZS1lbmFibGVkIGRlZmF1bHQgTk1JLyNNQyB1c2Ugb2YgTVNSX1NQRUNf Q1RSTC4gKi8KLSAgICBjaS0+c3BlY19jdHJsX2ZsYWdzIHw9IChkZWZhdWx0 X3NwZWNfY3RybF9mbGFncyAmIFNDRl9pc3Rfd3Jtc3IpOworICAgIC8qIFJl LWVuYWJsZWQgZGVmYXVsdCBOTUkvI01DIHVzZSBvZiBNU1JzIG5vdyBtaWNy b2NvZGUgaXMgbG9hZGVkLiAqLworICAgIGNpLT5zcGVjX2N0cmxfZmxhZ3Mg fD0gKGRlZmF1bHRfc3BlY19jdHJsX2ZsYWdzICYgU0NGX0lTVF9NQVNLKTsK IAogICAgIGlmICggYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUlNCKSB8 fCBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJSUykgKQogICAgIHsKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9kb21haW4uYyBiL3hlbi9hcmNoL3g4 Ni9kb21haW4uYwppbmRleCAxZmU2NjQ0YTcxYWUuLjgyYTBiNzNjZjZlZiAx MDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2RvbWFpbi5jCisrKyBiL3hlbi9h cmNoL3g4Ni9kb21haW4uYwpAQCAtMjA5MiwxMCArMjA5MiwxMCBAQCB2b2lk IGNvbnRleHRfc3dpdGNoKHN0cnVjdCB2Y3B1ICpwcmV2LCBzdHJ1Y3QgdmNw dSAqbmV4dCkKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAg IC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIHdpdGggdGhlIFZF UlcgZGlzcG9zaXRpb24uICovCi0gICAgICAgIGluZm8tPnNwZWNfY3RybF9m bGFncyAmPSB+U0NGX3Zlcnc7Ci0gICAgICAgIGlmICggbmV4dGQtPmFyY2gu dmVydyApCi0gICAgICAgICAgICBpbmZvLT5zcGVjX2N0cmxfZmxhZ3MgfD0g U0NGX3Zlcnc7CisgICAgICAgIC8qIFVwZGF0ZSB0aGUgdG9wLW9mLXN0YWNr IGJsb2NrIHdpdGggdGhlIG5ldyBzcGVjX2N0cmwgc2V0dGluZ3MuICovCisg ICAgICAgIGluZm8tPnNwZWNfY3RybF9mbGFncyA9CisgICAgICAgICAgICAo aW5mby0+c3BlY19jdHJsX2ZsYWdzICAgICAgICYgflNDRl9ET01fTUFTSykg fAorICAgICAgICAgICAgKG5leHRkLT5hcmNoLnNwZWNfY3RybF9mbGFncyAm ICBTQ0ZfRE9NX01BU0spOwogICAgIH0KIAogICAgIHNjaGVkX2NvbnRleHRf c3dpdGNoZWQocHJldiwgbmV4dCk7CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5k ZXggOTUwN2U1ZGE2MGE5Li43ZTY0NjY4MGYxYzcgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3Bl Y19jdHJsLmMKQEAgLTEwMTAsOSArMTAxMCwxMiBAQCB2b2lkIHNwZWNfY3Ry bF9pbml0X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkKQogewogICAgIGJvb2wg cHYgPSBpc19wdl9kb21haW4oZCk7CiAKLSAgICBkLT5hcmNoLnZlcncgPQot ICAgICAgICAocHYgPyBvcHRfbWRfY2xlYXJfcHYgOiBvcHRfbWRfY2xlYXJf aHZtKSB8fAotICAgICAgICAob3B0X2ZiX2NsZWFyX21taW8gJiYgaXNfaW9t bXVfZW5hYmxlZChkKSk7CisgICAgYm9vbCB2ZXJ3ID0gKChwdiA/IG9wdF9t ZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9odm0pIHx8CisgICAgICAgICAg ICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAmJiBpc19pb21tdV9lbmFibGVk KGQpKSk7CisKKyAgICBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyA9CisgICAg ICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAgICAgIDogMCkgfAorICAgICAg ICAwOwogfQogCiB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGln YXRpb25zKHZvaWQpCmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2 L2RvbWFpbi5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9kb21haW4uaAppbmRl eCAyMzk4YTFkOTlkYTkuLmU0YzA5OTI2MmNiNyAxMDA2NDQKLS0tIGEveGVu L2luY2x1ZGUvYXNtLXg4Ni9kb21haW4uaAorKysgYi94ZW4vaW5jbHVkZS9h c20teDg2L2RvbWFpbi5oCkBAIC0zMTksOCArMzE5LDcgQEAgc3RydWN0IGFy Y2hfZG9tYWluCiAgICAgdWludDMyX3QgcGNpX2NmODsKICAgICB1aW50OF90 IGNtb3NfaWR4OwogCi0gICAgLyogVXNlIFZFUlcgb24gcmV0dXJuLXRvLWd1 ZXN0IGZvciBpdHMgZmx1c2hpbmcgc2lkZSBlZmZlY3QuICovCi0gICAgYm9v bCB2ZXJ3OworICAgIHVpbnQ4X3Qgc3BlY19jdHJsX2ZsYWdzOyAvKiBTZWUg U0NGX0RPTV9NQVNLICovCiAKICAgICB1bmlvbiB7CiAgICAgICAgIHN0cnVj dCBwdl9kb21haW4gcHY7CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20t eDg2L3NwZWNfY3RybC5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmwuaAppbmRleCA3ZTgzZTAxNzlmYjkuLjNjZDcyZTQwMzA1ZiAxMDA2NDQK LS0tIGEveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94 ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oCkBAIC0yMCwxMiArMjAs NDAgQEAKICNpZm5kZWYgX19YODZfU1BFQ19DVFJMX0hfXwogI2RlZmluZSBf X1g4Nl9TUEVDX0NUUkxfSF9fCiAKLS8qIEVuY29kaW5nIG9mIGNwdWluZm8u c3BlY19jdHJsX2ZsYWdzICovCisvKgorICogRW5jb2Rpbmcgb2Y6CisgKiAg IGNwdWluZm8uc3BlY19jdHJsX2ZsYWdzCisgKiAgIGRlZmF1bHRfc3BlY19j dHJsX2ZsYWdzCisgKiAgIGRvbWFpbi5zcGVjX2N0cmxfZmxhZ3MKKyAqCisg KiBMaXZlIHNldHRpbmdzIGFyZSBpbiB0aGUgdG9wLW9mLXN0YWNrIGJsb2Nr LCBiZWNhdXNlIHRoZXkgbmVlZCB0byBiZQorICogYWNjZXNzYWJsZSB3aGVu IFhQVEkgaXMgYWN0aXZlLiAgU29tZSBzZXR0aW5ncyBhcmUgZml4ZWQgZnJv bSBib290LCBzb21lCisgKiBjb250ZXh0IHN3aXRjaGVkIHBlciBkb21haW4s IGFuZCBzb21lIGluaGliaXRlZCBpbiB0aGUgUzMgcGF0aC4KKyAqLwogI2Rl ZmluZSBTQ0ZfdXNlX3NoYWRvdyAoMSA8PCAwKQogI2RlZmluZSBTQ0ZfaXN0 X3dybXNyICAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAgICAoMSA8 PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQogCisvKgor ICogVGhlIElTVCBwYXRocyAoTk1JLyNNQykgY2FuIGludGVycnVwdCBhbnkg YXJiaXRyYXJ5IGNvbnRleHQuICBTb21lCisgKiBmdW5jdGlvbmFsaXR5IHJl cXVpcmVzIHVwZGF0ZWQgbWljcm9jb2RlIHRvIHdvcmsuCisgKgorICogT24g Ym9vdCwgdGhpcyBpcyBlYXN5OyB3ZSBsb2FkIG1pY3JvY29kZSBiZWZvcmUg ZmlndXJpbmcgb3V0IHdoaWNoCisgKiBzcGVjdWxhdGl2ZSBwcm90ZWN0aW9u cyB0byBhcHBseS4gIEhvd2V2ZXIsIG9uIHRoZSBTMyByZXN1bWUgcGF0aCwg d2UgbXVzdAorICogYmUgYWJsZSB0byBkaXNhYmxlIHRoZSBjb25maWd1cmVk IG1pdGlnYXRpb25zIHVudGlsIG1pY3JvY29kZSBpcyByZWxvYWRlZC4KKyAq CisgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xzIHRvIGluaGliaXQgb24gdGhl IFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3JvY29kZSBoYXMKKyAqIGJlZW4g cmVsb2FkZWQuCisgKi8KKyNkZWZpbmUgU0NGX0lTVF9NQVNLIChTQ0ZfaXN0 X3dybXNyKQorCisvKgorICogU29tZSBzcGVjdWxhdGl2ZSBwcm90ZWN0aW9u cyBhcmUgcGVyLWRvbWFpbi4gIFRoZXNlIHNldHRpbmdzIGFyZSBtZXJnZWQK KyAqIGludG8gdGhlIHRvcC1vZi1zdGFjayBibG9jayBpbiB0aGUgY29udGV4 dCBzd2l0Y2ggcGF0aC4KKyAqLworI2RlZmluZSBTQ0ZfRE9NX01BU0sgKFND Rl92ZXJ3KQorCiAjaWZuZGVmIF9fQVNTRU1CTFlfXwogCiAjaW5jbHVkZSA8 YXNtL2FsdGVybmF0aXZlLmg+CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9h c20teDg2L3NwZWNfY3RybF9hc20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oCmluZGV4IDVhNTkwYmFjNDRhYS4uNjZiMDBkNTEx ZmM2IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3Ry bF9hc20uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaApAQCAtMjQ4LDkgKzI0OCw2IEBACiAKIC8qCiAgKiBVc2UgaW4gSVNU IGludGVycnVwdC9leGNlcHRpb24gY29udGV4dC4gIE1heSBpbnRlcnJ1cHQg WGVuIG9yIFBWIGNvbnRleHQuCi0gKiBGaW5lIGdyYWluIGNvbnRyb2wgb2Yg U0NGX2lzdF93cm1zciBpcyBuZWVkZWQgZm9yIHNhZmV0eSBpbiB0aGUgUzMg cmVzdW1lCi0gKiBwYXRoIHRvIGF2b2lkIHVzaW5nIE1TUl9TUEVDX0NUUkwg YmVmb3JlIHRoZSBtaWNyb2NvZGUgaW50cm9kdWNpbmcgaXQgaGFzCi0gKiBi ZWVuIHJlbG9hZGVkLgogICovCiAubWFjcm8gU1BFQ19DVFJMX0VOVFJZX0ZS T01fSU5UUl9JU1QKIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-2.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-2.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIFNDRl9pc3Rfd3Jt c3IgdG8gU0NGX2lzdF9zY19tc3IKCldlIGFyZSBhYm91dCB0byBpbnRyb2R1 Y2UgU0NGX2lzdF9pYnBiLCBhdCB3aGljaCBwb2ludCBTQ0ZfaXN0X3dybXNy IGJlY29tZXMKYW1iaWd1b3VzLgoKTm8gZnVuY3Rpb25hbCBjaGFuZ2UuCgpU aGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNpZ25lZC1vZmYtYnk6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+ClJldmlld2Vk LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+CgpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jIGIveGVuL2FyY2gveDg2 L3NwZWNfY3RybC5jCmluZGV4IDdlNjQ2NjgwZjFjNy4uODlmOTVjMDgzZTFi IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKKysrIGIv eGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCkBAIC0xMTE1LDcgKzExMTUsNyBA QCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZv aWQpCiAgICAgewogICAgICAgICBpZiAoIG9wdF9tc3Jfc2NfcHYgKQogICAg ICAgICB7Ci0gICAgICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8 PSBTQ0ZfaXN0X3dybXNyOworICAgICAgICAgICAgZGVmYXVsdF9zcGVjX2N0 cmxfZmxhZ3MgfD0gU0NGX2lzdF9zY19tc3I7CiAgICAgICAgICAgICBzZXR1 cF9mb3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX1NDX01TUl9QVik7CiAgICAg ICAgIH0KIApAQCAtMTEyNiw3ICsxMTI2LDcgQEAgdm9pZCBfX2luaXQgaW5p dF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAgICAgICAgICAg ICogWGVuJ3MgdmFsdWUgaXMgbm90IHJlc3RvcmVkIGF0b21pY2FsbHkuICBB biBlYXJseSBOTUkgaGl0dGluZwogICAgICAgICAgICAgICogdGhlIFZNRXhp dCBwYXRoIG5lZWRzIHRvIHJlc3RvcmUgWGVuJ3MgdmFsdWUgZm9yIHNhZmV0 eS4KICAgICAgICAgICAgICAqLwotICAgICAgICAgICAgZGVmYXVsdF9zcGVj X2N0cmxfZmxhZ3MgfD0gU0NGX2lzdF93cm1zcjsKKyAgICAgICAgICAgIGRl ZmF1bHRfc3BlY19jdHJsX2ZsYWdzIHw9IFNDRl9pc3Rfc2NfbXNyOwogICAg ICAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9TQ19N U1JfSFZNKTsKICAgICAgICAgfQogICAgIH0KQEAgLTExMzksNyArMTEzOSw3 IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlvbnMo dm9pZCkKICAgICAgICAgICogb24gcmVhbCBoYXJkd2FyZSBtYXRjaGVzIHRo ZSBhdmFpbGFiaWxpdHkgb2YgTVNSX1NQRUNfQ1RSTCBpbiB0aGUKICAgICAg ICAgICogZmlyc3QgcGxhY2UuCiAgICAgICAgICAqCi0gICAgICAgICAqIE5v IG5lZWQgZm9yIFNDRl9pc3Rfd3Jtc3IgYmVjYXVzZSBYZW4ncyB2YWx1ZSBp cyByZXN0b3JlZAorICAgICAgICAgKiBObyBuZWVkIGZvciBTQ0ZfaXN0X3Nj X21zciBiZWNhdXNlIFhlbidzIHZhbHVlIGlzIHJlc3RvcmVkCiAgICAgICAg ICAqIGF0b21pY2FsbHkgV1JUIE5NSXMgaW4gdGhlIFZNRXhpdCBwYXRoLgog ICAgICAgICAgKgogICAgICAgICAgKiBUT0RPOiBBZGp1c3QgY3B1X2hhc19z dm1fc3BlY19jdHJsIHRvIGJlIHVzYWJsZSBlYXJsaWVyIG9uIGJvb3QuCmRp ZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5oIGIv eGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCAzY2Q3MmU0 MDMwNWYuLmY4ZjBhYzQ3ZTc1OSAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCkBAIC0zMSw3ICszMSw3IEBACiAgKiBjb250ZXh0IHN3 aXRjaGVkIHBlciBkb21haW4sIGFuZCBzb21lIGluaGliaXRlZCBpbiB0aGUg UzMgcGF0aC4KICAqLwogI2RlZmluZSBTQ0ZfdXNlX3NoYWRvdyAoMSA8PCAw KQotI2RlZmluZSBTQ0ZfaXN0X3dybXNyICAoMSA8PCAxKQorI2RlZmluZSBT Q0ZfaXN0X3NjX21zciAoMSA8PCAxKQogI2RlZmluZSBTQ0ZfaXN0X3JzYiAg ICAoMSA8PCAyKQogI2RlZmluZSBTQ0ZfdmVydyAgICAgICAoMSA8PCAzKQog CkBAIC00Niw3ICs0Niw3IEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xz IHRvIGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3Jv Y29kZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NG X0lTVF9NQVNLIChTQ0ZfaXN0X3dybXNyKQorI2RlZmluZSBTQ0ZfSVNUX01B U0sgKFNDRl9pc3Rfc2NfbXNyKQogCiAvKgogICogU29tZSBzcGVjdWxhdGl2 ZSBwcm90ZWN0aW9ucyBhcmUgcGVyLWRvbWFpbi4gIFRoZXNlIHNldHRpbmdz IGFyZSBtZXJnZWQKZGlmZiAtLWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oIGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0 cmxfYXNtLmgKaW5kZXggNjZiMDBkNTExZmM2Li4wZmYxYjExOGY4ODIgMTAw NjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5o CisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCkBA IC0yNjYsOCArMjY2LDggQEAKIAogLkxcQF9za2lwX3JzYjoKIAotICAgIHRl c3QgJFNDRl9pc3Rfd3Jtc3IsICVhbAotICAgIGp6IC5MXEBfc2tpcF93cm1z cgorICAgIHRlc3QgJFNDRl9pc3Rfc2NfbXNyLCAlYWwKKyAgICBqeiAuTFxA X3NraXBfbXNyX3NwZWNfY3RybAogCiAgICAgeG9yICVlZHgsICVlZHgKICAg ICB0ZXN0YiAkMywgVVJFR1NfY3MoJXJzcCkKQEAgLTI5MCw3ICsyOTAsNyBA QCBVTkxJS0VMWV9ESVNQQVRDSF9MQUJFTChcQF9zZXJpYWxpc2UpOgogICAg ICAqIHRvIHNwZWN1bGF0ZSBhcm91bmQgdGhlIFdSTVNSLiAgQXMgYSByZXN1 bHQsIHdlIG5lZWQgYSBkaXNwYXRjaAogICAgICAqIHNlcmlhbGlzaW5nIGlu c3RydWN0aW9uIGluIHRoZSBlbHNlIGNsYXVzZS4KICAgICAgKi8KLS5MXEBf c2tpcF93cm1zcjoKKy5MXEBfc2tpcF9tc3Jfc3BlY19jdHJsOgogICAgIGxm ZW5jZQogICAgIFVOTElLRUxZX0VORChcQF9zZXJpYWxpc2UpCiAuZW5kbQpA QCAtMzAxLDcgKzMwMSw3IEBAIFVOTElLRUxZX0RJU1BBVENIX0xBQkVMKFxA X3NlcmlhbGlzZSk6CiAgKiBSZXF1aXJlcyAlcmJ4PXN0YWNrX2VuZAogICog Q2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAogICovCi0gICAgdGVzdGIgJFND Rl9pc3Rfd3Jtc3IsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19jdHJsX2Zs YWdzKSglcmJ4KQorICAgIHRlc3RiICRTQ0ZfaXN0X3NjX21zciwgU1RBQ0tf Q1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyYngpCiAgICAganog LkxcQF9za2lwCiAKICAgICBET19TUEVDX0NUUkxfRVhJVF9UT19YRU4K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-3.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-3.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmVuYW1lIG9wdF9pYnBiIHRv IG9wdF9pYnBiX2N0eHRfc3dpdGNoCgpXZSBhcmUgYWJvdXQgdG8gaW50cm9k dWNlIHRoZSB1c2Ugb2YgSUJQQiBhdCBkaWZmZXJlbnQgcG9pbnRzIGluIFhl biwgbWFraW5nCm9wdF9pYnBiIGFtYmlndW91cy4gIFJlbmFtZSBpdCB0byBv cHRfaWJwYl9jdHh0X3N3aXRjaC4KCk5vIGZ1bmN0aW9uYWwgY2hhbmdlLgoK U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT4KUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGlj aEBzdXNlLmNvbT4KCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvZG9tYWlu LmMgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKaW5kZXggODJhMGI3M2NmNmVm Li4wZDM5OTgxNTUwY2EgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9kb21h aW4uYworKysgYi94ZW4vYXJjaC94ODYvZG9tYWluLmMKQEAgLTIwNjQsNyAr MjA2NCw3IEBAIHZvaWQgY29udGV4dF9zd2l0Y2goc3RydWN0IHZjcHUgKnBy ZXYsIHN0cnVjdCB2Y3B1ICpuZXh0KQogCiAgICAgICAgIGN0eHRfc3dpdGNo X2xldmVsbGluZyhuZXh0KTsKIAotICAgICAgICBpZiAoIG9wdF9pYnBiICYm ICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQorICAgICAgICBpZiAoIG9wdF9p YnBiX2N0eHRfc3dpdGNoICYmICFpc19pZGxlX2RvbWFpbihuZXh0ZCkgKQog ICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWMgREVGSU5FX1BFUl9DUFUo dW5zaWduZWQgaW50LCBsYXN0KTsKICAgICAgICAgICAgIHVuc2lnbmVkIGlu dCAqbGFzdF9pZCA9ICZ0aGlzX2NwdShsYXN0KTsKZGlmZiAtLWdpdCBhL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0 cmwuYwppbmRleCA4OWY5NWMwODNlMWIuLmY0YWUzNmVhZTJkMCAxMDA2NDQK LS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3RybC5jCisrKyBiL3hlbi9hcmNo L3g4Ni9zcGVjX2N0cmwuYwpAQCAtNTQsNyArNTQsNyBAQCBpbnQ4X3QgX19p bml0ZGF0YSBvcHRfc3RpYnAgPSAtMTsKIGJvb2wgX19yZWFkX21vc3RseSBv cHRfc3NiZDsKIGludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0gLTE7CiAK LWJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYiA9IHRydWU7Citib29sIF9f cmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSB0cnVlOwogaW50 OF90IF9fcmVhZF9tb3N0bHkgb3B0X2VhZ2VyX2ZwdSA9IC0xOwogaW50OF90 IF9fcmVhZF9tb3N0bHkgb3B0X2wxZF9mbHVzaCA9IC0xOwogc3RhdGljIGJv b2wgX19pbml0ZGF0YSBvcHRfYnJhbmNoX2hhcmRlbiA9IHRydWU7CkBAIC0x MTcsNyArMTE3LDcgQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2Vfc3BlY19j dHJsKGNvbnN0IGNoYXIgKnMpCiAKICAgICAgICAgICAgIG9wdF90aHVuayA9 IFRIVU5LX0pNUDsKICAgICAgICAgICAgIG9wdF9pYnJzID0gMDsKLSAgICAg ICAgICAgIG9wdF9pYnBiID0gZmFsc2U7CisgICAgICAgICAgICBvcHRfaWJw Yl9jdHh0X3N3aXRjaCA9IGZhbHNlOwogICAgICAgICAgICAgb3B0X3NzYmQg PSBmYWxzZTsKICAgICAgICAgICAgIG9wdF9sMWRfZmx1c2ggPSAwOwogICAg ICAgICAgICAgb3B0X2JyYW5jaF9oYXJkZW4gPSBmYWxzZTsKQEAgLTIzOCw3 ICsyMzgsNyBAQCBzdGF0aWMgaW50IF9faW5pdCBwYXJzZV9zcGVjX2N0cmwo Y29uc3QgY2hhciAqcykKIAogICAgICAgICAvKiBNaXNjIHNldHRpbmdzLiAq LwogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oImli cGIiLCBzLCBzcykpID49IDAgKQotICAgICAgICAgICAgb3B0X2licGIgPSB2 YWw7CisgICAgICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9IHZhbDsK ICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9ib29sZWFuKCJlYWdl ci1mcHUiLCBzLCBzcykpID49IDAgKQogICAgICAgICAgICAgb3B0X2VhZ2Vy X2ZwdSA9IHZhbDsKICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9i b29sZWFuKCJsMWQtZmx1c2giLCBzLCBzcykpID49IDAgKQpAQCAtNDU4LDcg KzQ1OCw3IEBAIHN0YXRpYyB2b2lkIF9faW5pdCBwcmludF9kZXRhaWxzKGVu dW0gaW5kX3RodW5rIHRodW5rLCB1aW50NjRfdCBjYXBzKQogICAgICAgICAg ICAob3B0X3RzeCAmIDEpICAgICAgICAgICAgICAgICAgICAgICAgICAgICA/ ICIgVFNYKyIgOiAiIFRTWC0iLAogICAgICAgICAgICAhY3B1X2hhc19zcmJk c19jdHJsICAgICAgICAgICAgICAgICAgICAgICA/ICIiIDoKICAgICAgICAg ICAgb3B0X3NyYl9sb2NrICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg PyAiIFNSQl9MT0NLKyIgOiAiIFNSQl9MT0NLLSIsCi0gICAgICAgICAgIG9w dF9pYnBiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBJ QlBCIiAgOiAiIiwKKyAgICAgICAgICAgb3B0X2licGJfY3R4dF9zd2l0Y2gg ICAgICAgICAgICAgICAgICAgICAgPyAiIElCUEItY3R4dCIgOiAiIiwKICAg ICAgICAgICAgb3B0X2wxZF9mbHVzaCAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgPyAiIEwxRF9GTFVTSCIgOiAiIiwKICAgICAgICAgICAgb3B0X21k X2NsZWFyX3B2IHx8IG9wdF9tZF9jbGVhcl9odm0gfHwKICAgICAgICAgICAg b3B0X2ZiX2NsZWFyX21taW8gICAgICAgICAgICAgICAgICAgICAgICAgPyAi IFZFUlciICA6ICIiLApAQCAtMTI0MCw3ICsxMjQwLDcgQEAgdm9pZCBfX2lu aXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogCiAgICAg LyogQ2hlY2sgd2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQgYmVmb3Jl IHVzaW5nIGl0Li4uICovCiAgICAgaWYgKCAhYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0lCUlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lC UEIpICkKLSAgICAgICAgb3B0X2licGIgPSBmYWxzZTsKKyAgICAgICAgb3B0 X2licGJfY3R4dF9zd2l0Y2ggPSBmYWxzZTsKIAogICAgIC8qIENoZWNrIHdo ZXRoZXIgRWFnZXIgRlBVIHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQu ICovCiAgICAgaWYgKCBvcHRfZWFnZXJfZnB1ID09IC0xICkKZGlmZiAtLWdp dCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmggYi94ZW4vaW5j bHVkZS9hc20teDg2L3NwZWNfY3RybC5oCmluZGV4IGY4ZjBhYzQ3ZTc1OS4u ZmI0MzY1NTc1NjIwIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKQEAgLTYzLDcgKzYzLDcgQEAKIHZvaWQgaW5pdF9zcGVjdWxhdGlv bl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJsX2luaXRfZG9t YWluKHN0cnVjdCBkb21haW4gKmQpOwogCi1leHRlcm4gYm9vbCBvcHRfaWJw YjsKK2V4dGVybiBib29sIG9wdF9pYnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJu IGJvb2wgb3B0X3NzYmQ7CiBleHRlcm4gaW50OF90IG9wdF9lYWdlcl9mcHU7 CiBleHRlcm4gaW50OF90IG9wdF9sMWRfZmx1c2g7Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-4.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-4.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFJfSVNUCgpXZSBhcmUgc2hvcnRseSBnb2luZyB0byBh ZGQgYSBjb25kaXRpb25hbCBJQlBCIGluIHRoaXMgcGF0aC4KClRoZXJlZm9y ZSwgd2UgY2Fubm90IGhvbGQgc3BlY19jdHJsX2ZsYWdzIGluICVlYXgsIGFu ZCByZWx5IG9uIG9ubHkgY2xvYmJlcmluZwppdCBhZnRlciB3ZSdyZSBkb25l IHdpdGggaXRzIGNvbnRlbnRzLiAgJXJieCBpcyBhdmFpbGFibGUgZm9yIHVz ZSwgYW5kIHRoZQptb3JlIG5vcm1hbCByZWdpc3RlciB0byBob2xkIHByZXNl cnZlZCBpbmZvcm1hdGlvbiBpbi4KCldpdGggJXJheCBmcmVlZCB1cCwgdXNl IGl0IGluc3RlYWQgb2YgJXJkeCBmb3IgdGhlIFJTQiB0bXAgcmVnaXN0ZXIs IGFuZCBmb3IKdGhlIGFkanVzdG1lbnQgdG8gc3BlY19jdHJsX2ZsYWdzLgoK VGhpcyBsZWF2ZXMgbm8gdXNlIG9mICVyZHgsIGV4Y2VwdCBhcyAwIGZvciB0 aGUgdXBwZXIgaGFsZiBvZiBXUk1TUi4gIEluCnByYWN0aWNlLCAlcmR4IGlz IDAgZnJvbSBTQVZFX0FMTCBvbiBhbGwgcGF0aHMgYW5kIGlzbid0IGxpa2Vs eSB0byBjaGFuZ2UgaW4KdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSwgc28gdXBk YXRlIHRoZSBtYWNybyBlbnRyeSByZXF1aXJlbWVudHMgdG8gc3RhdGUgdGhp cwpkZXBlbmRlbmN5LiAgVGhpcyBtYXJnaW5hbCBvcHRpbWlzYXRpb24gY2Fu IGJlIHJldmlzaXRlZCBpZiBjaXJjdW1zdGFuY2VzCmNoYW5nZS4KCk5vIHBy YWN0aWNhbCBjaGFuZ2UuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IDJh ODY5MzhmMWYzMi4uYTE4MTBiZjRkMzExIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9lbnRyeS5TCkBAIC05MzIsNyArOTMyLDcgQEAgRU5UUlkoZG91YmxlX2Zh dWx0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAKLSAgICAgICAg U1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJl Z3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyYngKQEAgLTk2OCw3ICs5NjgsNyBA QCBoYW5kbGVfaXN0X2V4Y2VwdGlvbjoKIAogICAgICAgICBHRVRfU1RBQ0tf RU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJf SVNUIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICov CisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJfSVNUIC8qIFJl cTogJXJzcD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhYmNkICov CiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAq YCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBt b3YgICBTVEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4 CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsX2FzbS5oCmlu ZGV4IDBmZjFiMTE4Zjg4Mi4uMTVlMjRjZGUwMGQxIDEwMDY0NAotLS0gYS94 ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaAorKysgYi94ZW4v aW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9hc20uaApAQCAtMjUxLDM0ICsy NTEsMzMgQEAKICAqLwogLm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lO VFJfSVNUCiAvKgotICogUmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNr X2VuZAotICogQ2xvYmJlcnMgJXJheCwgJXJjeCwgJXJkeAorICogUmVxdWly ZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNrX2VuZCwgJXJkeD0wCisgKiBDbG9i YmVycyAlcmF4LCAlcmJ4LCAlcmN4LCAlcmR4CiAgKgogICogVGhpcyBpcyBs b2dpY2FsIG1lcmdlIG9mIERPX09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNf Q1RSTF9FTlRSWQogICogbWF5YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9u YWxzIHJhdGhlciB0aGFuIGFsdGVybmF0aXZlcy4KICAqLwotICAgIG1vdnpi bCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCks ICVlYXgKKyAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0 cmxfZmxhZ3MpKCVyMTQpLCAlZWJ4CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3Jz YiwgJWFsCisgICAgdGVzdCAkU0NGX2lzdF9yc2IsICVibAogICAgIGp6IC5M XEBfc2tpcF9yc2IKIAotICAgIERPX09WRVJXUklURV9SU0IgdG1wPXJkeCAv KiBDbG9iYmVycyAlcmN4LyVyZHggKi8KKyAgICBET19PVkVSV1JJVEVfUlNC ICAgICAgICAgLyogQ2xvYmJlcnMgJXJheC8lcmN4ICovCiAKIC5MXEBfc2tp cF9yc2I6CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3NjX21zciwgJWFsCisgICAg dGVzdCAkU0NGX2lzdF9zY19tc3IsICVibAogICAgIGp6IC5MXEBfc2tpcF9t c3Jfc3BlY19jdHJsCiAKLSAgICB4b3IgJWVkeCwgJWVkeAorICAgIHhvciAl ZWF4LCAlZWF4CiAgICAgdGVzdGIgJDMsIFVSRUdTX2NzKCVyc3ApCi0gICAg c2V0bnogJWRsCi0gICAgbm90ICVlZHgKLSAgICBhbmQgJWRsLCBTVEFDS19D UFVJTkZPX0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICBzZXRu eiAlYWwKKyAgICBub3QgJWVheAorICAgIGFuZCAlYWwsIFNUQUNLX0NQVUlO Rk9fRklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KQogCiAgICAgLyogTG9h ZCBYZW4ncyBpbnRlbmRlZCB2YWx1ZS4gKi8KICAgICBtb3YgJE1TUl9TUEVD X0NUUkwsICVlY3gKICAgICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4 ZW5fc3BlY19jdHJsKSglcjE0KSwgJWVheAotICAgIHhvciAlZWR4LCAlZWR4 CiAgICAgd3Jtc3IKIAogICAgIC8qIE9wZW5jb2RlZCBVTkxJS0VMWV9TVEFS VCgpIHdpdGggbm8gY29uZGl0aW9uLiAqLwo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-5.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-5.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3VwcG9ydCBJQlBCLW9uLWVu dHJ5CgpXZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGlzIHRvIG1pdGlnYXRlIEJy YW5jaCBUeXBlIENvbmZ1c2lvbiBvbiBBTUQvSHlnb24gQ1BVcywKYnV0IGFz IHdlJ3ZlIHRhbGtlZCBhYm91dCB1c2luZyBpdCBpbiBvdGhlciBjYXNlcyB0 b28sIGFycmFuZ2UgdG8gc3VwcG9ydCBpdApnZW5lcmFsbHkuICBIb3dldmVy LCB0aGlzIGlzIGFsc28gdmVyeSBleHBlbnNpdmUgaW4gc29tZSBjYXNlcywg c28gd2UncmUgZ29pbmcKdG8gd2FudCBwZXItZG9tYWluIGNvbnRyb2xzLgoK SW50cm9kdWNlIFNDRl9pc3RfaWJwYiBhbmQgU0NGX2VudHJ5X2licGIgY29u dHJvbHMsIGFkZGluZyB0aGVtIHRvIHRoZSBJU1QgYW5kCkRPTSBtYXNrcyBh cyBhcHByb3ByaWF0ZS4gIEFsc28gaW50cm9kdWNlIFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfe1BWLEhWTX0gdG8KdG8gcGF0Y2ggdGhlIGNvZGUgYmxvY2tz LgoKRm9yIFNWTSwgdGhlIFNUR0kgaXMgc2VyaWFsaXNpbmcgZW5vdWdoIHRv IHByb3RlY3QgYWdhaW5zdCBTcGVjdHJlLXYxIGF0dGFja3MsCnNvIG5vICJl bHNlIGxmZW5jZSIgaXMgbmVjZXNzYXJ5LiAgVlQteCB3aWxsIHVzZSB1c2Ug dGhlIE1TUiBob3N0IGxvYWQgbGlzdCwKc28gZG9lc24ndCBuZWVkIGFueSBj b2RlIGluIHRoZSBWTUV4aXQgcGF0aC4KCkZvciB0aGUgSVNUIHBhdGgsIHdl IGNhbid0IHNhZmVseSBjaGVjayBDUEw9PTAgdG8gc2tpcCBhIGZsdXNoLCBh cyB3ZSBtaWdodApoYXZlIGhpdCBhbiBlbnRyeSBwYXRoIGJlZm9yZSBpdCdz IElCUEIuICBBcyBJU1QgaGl0dGluZyBYZW4gaXMgcmFyZSwgZmx1c2gKaXJy ZXNwZWN0aXZlIG9mIENQTC4gIEEgbGF0ZXIgcGF0aCwgU0NGX2lzdF9zY19t c3IsIHByb3ZpZGVzIFNwZWN0cmUtdjEKc2FmZXR5LgoKRm9yIHRoZSBQViBw YXRocywgd2Uga25vdyB3ZSdyZSBpbnRlcnJ1cHRpbmcgQ1BMPjAsIHdoaWxl IGZvciB0aGUgSU5UUiBwYXRocywKd2UgY2FuIHNhZmVseSBjaGVjayBDUEw9 PTAuICBPbmx5IGZsdXNoIHdoZW4gaW50ZXJydXB0aW5nIGd1ZXN0IGNvbnRl eHQuCgpBbiAiZWxzZSBsZmVuY2UiIGlzIG5lZWRlZCBmb3Igc2FmZXR5LCBi dXQgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHNraXAgaXQgb24KdW5hZmZlY3Rl ZCBDUFVzLCBzbyB0aGUgYmxvY2sgd2FudHMgdG8gYmUgYW4gYWx0ZXJuYXRp dmUsIHdoaWNoIG1lYW5zIHRoZQpsZmVuY2UgaGFzIHRvIGJlIGlubGluZSBy YXRoZXIgdGhhbiBVTkxJS0VMWSgpICh0aGUgcmVwbGFjZW1lbnQgYmxvY2sg ZG9lc24ndApoYXZlIGRpc3BsYWNlbWVudHMgZml4ZWQgdXAgZm9yIGFueXRo aW5nIG90aGVyIHRoYW4gdGhlIGZpcnN0IGluc3RydWN0aW9uKS4KCkFzIHdp dGggU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QsICVyZHggaXMgMCBv biBlbnRyeSBzbyByZWx5IG9uIHRoaXMgdG8Kc2hyaW5rIHRoZSBsb2dpYyBt YXJnaW5hbGx5LiAgVXBkYXRlIHRoZSBjb21tZW50cyB0byBzcGVjaWZ5IHRo aXMgbmV3CmRlcGVuZGVuY3kuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9z dm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKaW5k ZXggNGFlNTVhMmVmNjA1Li4wZmY0MDA4MDYwZmEgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L2h2bS9zdm0vZW50cnkuUwpAQCAtOTcsNyArOTcsMTkgQEAgX19VTkxJS0VM WV9FTkQobnN2bV9oYXApCiAKICAgICAgICAgR0VUX0NVUlJFTlQoYngpCiAK LSAgICAgICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTog JXJzcD1yZWdzL2NwdWluZm8gICAgICAgICBDbG9iOiBhY2QgKi8KKyAgICAg ICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTogJXJzcD1y ZWdzL2NwdWluZm8sICVyZHg9MCBDbG9iOiBhY2QgKi8KKworICAgICAgICAu bWFjcm8gc3ZtX3ZtZXhpdF9jb25kX2licGIKKyAgICAgICAgICAgIHRlc3Ri ICAkU0NGX2VudHJ5X2licGIsIENQVUlORk9feGVuX3NwZWNfY3RybCglcnNw KQorICAgICAgICAgICAganogICAgIC5MX3NraXBfaWJwYgorCisgICAgICAg ICAgICBtb3YgICAgJE1TUl9QUkVEX0NNRCwgJWVjeAorICAgICAgICAgICAg bW92ICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgICAgICAgICB3cm1z cgorLkxfc2tpcF9pYnBiOgorCS5lbmRtCisgICAgICAgIEFMVEVSTkFUSVZF ICIiLCBzdm1fdm1leGl0X2NvbmRfaWJwYiwgWDg2X0ZFQVRVUkVfSUJQQl9F TlRSWV9IVk0KKwogICAgICAgICBBTFRFUk5BVElWRSAiIiwgRE9fT1ZFUldS SVRFX1JTQiwgWDg2X0ZFQVRVUkVfU0NfUlNCX0hWTQogCiAgICAgICAgIC5t YWNybyBzdm1fdm1leGl0X3NwZWNfY3RybApAQCAtMTE0LDYgKzEyNiwxMCBA QCBfX1VOTElLRUxZX0VORChuc3ZtX2hhcCkKICAgICAgICAgQUxURVJOQVRJ VkUgIiIsIHN2bV92bWV4aXRfc3BlY19jdHJsLCBYODZfRkVBVFVSRV9TQ19N U1JfSFZNCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwg YGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAorICAg ICAgICAvKgorICAgICAgICAgKiBTVEdJIGlzIGV4ZWN1dGVkIHVuY29uZGl0 aW9uYWxseSwgYW5kIGlzIHN1ZmZpY2llbnRseSBzZXJpYWxpc2luZworICAg ICAgICAgKiB0byBzYWZlbHkgcmVzb2x2ZSBhbnkgU3BlY3RyZS12MSBjb25j ZXJucyBpbiB0aGUgYWJvdmUgbG9naWMuCisgICAgICAgICAqLwogICAgICAg ICBzdGdpCiBHTE9CQUwoc3ZtX3N0Z2lfbGFiZWwpCiAgICAgICAgIG1vdiAg JXJzcCwlcmRpCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92 bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMKaW5kZXggZjlm OWJjMThjZGJjLi5kZDgxN2NlZTRlNjkgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNo L3g4Ni9odm0vdm14L3ZtY3MuYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3Zt eC92bWNzLmMKQEAgLTEzNDUsNiArMTM0NSwxMCBAQCBzdGF0aWMgaW50IGNv bnN0cnVjdF92bWNzKHN0cnVjdCB2Y3B1ICp2KQogICAgICAgICByYyA9IHZt eF9hZGRfbXNyKHYsIE1TUl9GTFVTSF9DTUQsIEZMVVNIX0NNRF9MMUQsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgVk1YX01TUl9HVUVTVF9MT0FET05M WSk7CiAKKyAgICBpZiAoICFyYyAmJiAoZC0+YXJjaC5zcGVjX2N0cmxfZmxh Z3MgJiBTQ0ZfZW50cnlfaWJwYikgKQorICAgICAgICByYyA9IHZteF9hZGRf bXNyKHYsIE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICBWTVhfTVNSX0hPU1QpOworCiAgb3V0OgogICAg IHZteF92bWNzX2V4aXQodik7CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni94ODZfNjQvY29tcGF0L2VudHJ5LlMgYi94ZW4vYXJjaC94ODYveDg2XzY0 L2NvbXBhdC9lbnRyeS5TCmluZGV4IDVmZDZkYmJkNDUxMy4uYjg2ZDM4ZDFj NTBkIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYveDg2XzY0L2NvbXBhdC9l bnRyeS5TCisrKyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvY29tcGF0L2VudHJ5 LlMKQEAgLTE4LDcgKzE4LDcgQEAgRU5UUlkoZW50cnlfaW50ODIpCiAgICAg ICAgIG1vdmwgICRIWVBFUkNBTExfVkVDVE9SLCA0KCVyc3ApCiAgICAgICAg IFNBVkVfQUxMIGNvbXBhdD0xIC8qIERQTDEgZ2F0ZSwgcmVzdHJpY3RlZCB0 byAzMmJpdCBQViBndWVzdHMgb25seS4gKi8KIAotICAgICAgICBTUEVDX0NU UkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYg LyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2Qg Ki8KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1w ICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAg IENSNF9QVjMyX1JFU1RPUkUKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni94 ODZfNjQvZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni94ODZfNjQvZW50cnkuUwpp bmRleCBhMTgxMGJmNGQzMTEuLmZiYThhZTQ5OGY3NCAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCisrKyBiL3hlbi9hcmNoL3g4 Ni94ODZfNjQvZW50cnkuUwpAQCAtMjYwLDcgKzI2MCw3IEBAIEVOVFJZKGxz dGFyX2VudGVyKQogICAgICAgICBtb3ZsICAkVFJBUF9zeXNjYWxsLCA0KCVy c3ApCiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VO VFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjog YWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJl cTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAg ICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBu b3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBHRVRf U1RBQ0tfRU5EKGJ4KQpAQCAtMjk4LDcgKzI5OCw3IEBAIEVOVFJZKGNzdGFy X2VudGVyKQogICAgICAgICBtb3ZsICAkVFJBUF9zeXNjYWxsLCA0KCVyc3Ap CiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZ X0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjogYWNk ICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJlcTog JXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAgICAg ICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qg c2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBHRVRfU1RB Q0tfRU5EKGJ4KQpAQCAtMzM4LDcgKzMzOCw3IEBAIEdMT0JBTChzeXNlbnRl cl9lZmxhZ3Nfc2F2ZWQpCiAgICAgICAgIG1vdmwgICRUUkFQX3N5c2NhbGws IDQoJXJzcCkKICAgICAgICAgU0FWRV9BTEwKIAotICAgICAgICBTUEVDX0NU UkxfRU5UUllfRlJPTV9QViAvKiBSZXE6ICVyc3A9cmVncy9jcHVpbmZvLCBD bG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fUFYg LyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgJXJkeD0wLCBDbG9iOiBhY2Qg Ki8KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1w ICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAg IEdFVF9TVEFDS19FTkQoYngpCkBAIC0zOTIsNyArMzkyLDcgQEAgRU5UUlko aW50ODBfZGlyZWN0X3RyYXApCiAgICAgICAgIG1vdmwgICQweDgwLCA0KCVy c3ApCiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19DVFJMX0VO VFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywgQ2xvYjog YWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BWIC8qIFJl cTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNkICovCiAg ICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBu b3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBHRVRf U1RBQ0tfRU5EKGJ4KQpAQCAtNjc0LDcgKzY3NCw3IEBAIEVOVFJZKGNvbW1v bl9pbnRlcnJ1cHQpCiAKICAgICAgICAgR0VUX1NUQUNLX0VORCgxNCkKIAot ICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJz cD1yZWdzLCAlcjE0PWVuZCwgQ2xvYjogYWNkICovCisgICAgICAgIFNQRUNf Q1RSTF9FTlRSWV9GUk9NX0lOVFIgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAgICAgICAvKiBXQVJOSU5H ISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90IHNhZmUgYmVmb3JlIHRo aXMgcG9pbnQuICovCiAKICAgICAgICAgbW92ICAgU1RBQ0tfQ1BVSU5GT19G SUVMRCh4ZW5fY3IzKSglcjE0KSwgJXJjeApAQCAtNzA4LDcgKzcwOCw3IEBA IEdMT0JBTChoYW5kbGVfZXhjZXB0aW9uKQogCiAgICAgICAgIEdFVF9TVEFD S19FTkQoMTQpCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5U UiAvKiBSZXE6ICVyc3A9cmVncywgJXIxND1lbmQsIENsb2I6IGFjZCAqLwor ICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJz cD1yZWdzLCAlcjE0PWVuZCwgJXJkeD0wLCBDbG9iOiBhY2QgKi8KICAgICAg ICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBz YWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNU QUNLX0NQVUlORk9fRklFTEQoeGVuX2NyMykoJXIxNCksICVyY3gKZGlmZiAt LWdpdCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaCBiL3hl bi9pbmNsdWRlL2FzbS14ODYvY3B1ZmVhdHVyZXMuaAppbmRleCA0OTNkMzM4 YTA4NWUuLjY3MmM5ZWUyMmJhMiAxMDA2NDQKLS0tIGEveGVuL2luY2x1ZGUv YXNtLXg4Ni9jcHVmZWF0dXJlcy5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14 ODYvY3B1ZmVhdHVyZXMuaApAQCAtMzksNiArMzksOCBAQCBYRU5fQ1BVRkVB VFVSRShYRU5fTEJSLCAgICAgICAgICAgWDg2X1NZTlRIKDIyKSkgLyogWGVu IHVzZXMgTVNSX0RFQlVHQ1RMLkxCUiAqLwogWEVOX0NQVUZFQVRVUkUoU0Nf VkVSV19JRExFLCAgICAgIFg4Nl9TWU5USCgyNSkpIC8qIFZFUlcgdXNlZCBi eSBYZW4gZm9yIGlkbGUgKi8KIFhFTl9DUFVGRUFUVVJFKFhFTl9TSFNUSywg ICAgICAgICBYODZfU1lOVEgoMjYpKSAvKiBYZW4gdXNlcyBDRVQgU2hhZG93 IFN0YWNrcyAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX0lCVCwgICAgICAgICAg IFg4Nl9TWU5USCgyNykpIC8qIFhlbiB1c2VzIENFVCBJbmRpcmVjdCBCcmFu Y2ggVHJhY2tpbmcgKi8KK1hFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfUFYs ICAgICBYODZfU1lOVEgoMjgpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBY ZW4gZm9yIFBWICovCitYRU5fQ1BVRkVBVFVSRShJQlBCX0VOVFJZX0hWTSwg ICAgWDg2X1NZTlRIKDI5KSkgLyogTVNSX1BSRURfQ01EIHVzZWQgYnkgWGVu IGZvciBIVk0gKi8KIAogLyogQnVnIHdvcmRzIGZvbGxvdyB0aGUgc3ludGhl dGljIHdvcmRzLiAqLwogI2RlZmluZSBYODZfTlJfQlVHIDEKZGlmZiAtLWdp dCBhL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19jdHJsLmggYi94ZW4vaW5j bHVkZS9hc20teDg2L3NwZWNfY3RybC5oCmluZGV4IGZiNDM2NTU3NTYyMC4u M2ZjNTk5YTgxN2M0IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2 L3NwZWNfY3RybC5oCisrKyBiL3hlbi9pbmNsdWRlL2FzbS14ODYvc3BlY19j dHJsLmgKQEAgLTM0LDYgKzM0LDggQEAKICNkZWZpbmUgU0NGX2lzdF9zY19t c3IgKDEgPDwgMSkKICNkZWZpbmUgU0NGX2lzdF9yc2IgICAgKDEgPDwgMikK ICNkZWZpbmUgU0NGX3ZlcncgICAgICAgKDEgPDwgMykKKyNkZWZpbmUgU0NG X2lzdF9pYnBiICAgKDEgPDwgNCkKKyNkZWZpbmUgU0NGX2VudHJ5X2licGIg KDEgPDwgNSkKIAogLyoKICAqIFRoZSBJU1QgcGF0aHMgKE5NSS8jTUMpIGNh biBpbnRlcnJ1cHQgYW55IGFyYml0cmFyeSBjb250ZXh0LiAgU29tZQpAQCAt NDYsMTMgKzQ4LDEzIEBACiAgKiBUaGVzZSBhcmUgdGhlIGNvbnRyb2xzIHRv IGluaGliaXQgb24gdGhlIFMzIHJlc3VtZSBwYXRoIHVudGlsIG1pY3JvY29k ZSBoYXMKICAqIGJlZW4gcmVsb2FkZWQuCiAgKi8KLSNkZWZpbmUgU0NGX0lT VF9NQVNLIChTQ0ZfaXN0X3NjX21zcikKKyNkZWZpbmUgU0NGX0lTVF9NQVNL IChTQ0ZfaXN0X3NjX21zciB8IFNDRl9pc3RfaWJwYikKIAogLyoKICAqIFNv bWUgc3BlY3VsYXRpdmUgcHJvdGVjdGlvbnMgYXJlIHBlci1kb21haW4uICBU aGVzZSBzZXR0aW5ncyBhcmUgbWVyZ2VkCiAgKiBpbnRvIHRoZSB0b3Atb2Yt c3RhY2sgYmxvY2sgaW4gdGhlIGNvbnRleHQgc3dpdGNoIHBhdGguCiAgKi8K LSNkZWZpbmUgU0NGX0RPTV9NQVNLIChTQ0ZfdmVydykKKyNkZWZpbmUgU0NG X0RPTV9NQVNLIChTQ0ZfdmVydyB8IFNDRl9lbnRyeV9pYnBiKQogCiAjaWZu ZGVmIF9fQVNTRU1CTFlfXwogCmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9h c20teDg2L3NwZWNfY3RybF9hc20uaCBiL3hlbi9pbmNsdWRlL2FzbS14ODYv c3BlY19jdHJsX2FzbS5oCmluZGV4IDE1ZTI0Y2RlMDBkMS4uOWViNGFkOWFi NzFkIDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3Ry bF9hc20uaAorKysgYi94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybF9h c20uaApAQCAtODgsNiArODgsMzUgQEAKICAqICAtIFNQRUNfQ1RSTF9FWElU X1RPX3tTVk0sVk1YfQogICovCiAKKy5tYWNybyBET19TUEVDX0NUUkxfQ09O RF9JQlBCIG1heWJleGVuOnJlcQorLyoKKyAqIFJlcXVpcmVzICVyc3A9cmVn cyAoYWxzbyBjcHVpbmZvIGlmICFtYXliZXhlbikKKyAqIFJlcXVpcmVzICVy MTQ9c3RhY2tfZW5kIChpZiBtYXliZXhlbiksICVyZHg9MAorICogQ2xvYmJl cnMgJXJheCwgJXJjeCwgJXJkeAorICoKKyAqIENvbmRpdGlvbmFsbHkgaXNz dWUgSUJQQiBpZiBTQ0ZfZW50cnlfaWJwYiBpcyBhY3RpdmUuICBJbiB0aGUg bWF5YmV4ZW4KKyAqIGNhc2UsIHdlIGNhbiBzYWZlbHkgbG9vayBhdCBVUkVH U19jcyB0byBza2lwIHRha2luZyB0aGUgaGl0IHdoZW4KKyAqIGludGVycnVw dGluZyBYZW4uCisgKi8KKyAgICAuaWYgXG1heWJleGVuCisgICAgICAgIHRl c3RiICAkU0NGX2VudHJ5X2licGIsIFNUQUNLX0NQVUlORk9fRklFTEQoc3Bl Y19jdHJsX2ZsYWdzKSglcjE0KQorICAgICAgICBqeiAgICAgLkxcQF9za2lw CisgICAgICAgIHRlc3RiICAkMywgVVJFR1NfY3MoJXJzcCkKKyAgICAuZWxz ZQorICAgICAgICB0ZXN0YiAgJFNDRl9lbnRyeV9pYnBiLCBDUFVJTkZPX3hl bl9zcGVjX2N0cmwoJXJzcCkKKyAgICAuZW5kaWYKKyAgICBqeiAgICAgLkxc QF9za2lwCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAg ICBtb3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKyAg ICBqbXAgICAgIC5MXEBfZG9uZQorCisuTFxAX3NraXA6CisgICAgbGZlbmNl CisuTFxAX2RvbmU6CisuZW5kbQorCiAubWFjcm8gRE9fT1ZFUldSSVRFX1JT QiB0bXA9cmF4CiAvKgogICogUmVxdWlyZXMgbm90aGluZwpAQCAtMjI1LDEy ICsyNTQsMTYgQEAKIAogLyogVXNlIGFmdGVyIGFuIGVudHJ5IGZyb20gUFYg Y29udGV4dCAoc3lzY2FsbC9zeXNlbnRlci9pbnQ4MC9pbnQ4Mi9ldGMpLiAq LwogI2RlZmluZSBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgIEFMVEVSTkFU SVZFICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1h eWJleGVuPTApLCAgICAgXAorICAgICAgICBYODZfRkVBVFVSRV9JQlBCX0VO VFJZX1BWOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XAogICAgIEFMVEVSTkFUSVZFICIiLCBET19PVkVSV1JJVEVfUlNCLCBYODZf RkVBVFVSRV9TQ19SU0JfUFY7ICAgICAgICAgICAgXAogICAgIEFMVEVSTkFU SVZFICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfRU5UUlkgbWF5YmV4 ZW49MCksICAgICAgICAgXAogICAgICAgICBYODZfRkVBVFVSRV9TQ19NU1Jf UFYKIAogLyogVXNlIGluIGludGVycnVwdC9leGNlcHRpb24gY29udGV4dC4g IE1heSBpbnRlcnJ1cHQgWGVuIG9yIFBWIGNvbnRleHQuICovCiAjZGVmaW5l IFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFIgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcCisgICAgQUxURVJOQVRJVkUgIiIsIF9f c3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9DT05EX0lCUEIgbWF5YmV4ZW49MSks ICAgICBcCisgICAgICAgIFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfUFY7ICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgQUxU RVJOQVRJVkUgIiIsIERPX09WRVJXUklURV9SU0IsIFg4Nl9GRUFUVVJFX1ND X1JTQl9QVjsgICAgICAgICAgICBcCiAgICAgQUxURVJOQVRJVkUgIiIsIF9f c3RyaW5naWZ5KERPX1NQRUNfQ1RSTF9FTlRSWSBtYXliZXhlbj0xKSwgICAg ICAgICBcCiAgICAgICAgIFg4Nl9GRUFUVVJFX1NDX01TUl9QVgpAQCAtMjU0 LDExICsyODcsMjMgQEAKICAqIFJlcXVpcmVzICVyc3A9cmVncywgJXIxND1z dGFja19lbmQsICVyZHg9MAogICogQ2xvYmJlcnMgJXJheCwgJXJieCwgJXJj eCwgJXJkeAogICoKLSAqIFRoaXMgaXMgbG9naWNhbCBtZXJnZSBvZiBET19P VkVSV1JJVEVfUlNCIGFuZCBET19TUEVDX0NUUkxfRU5UUlkKLSAqIG1heWJl eGVuPTEsIGJ1dCB3aXRoIGNvbmRpdGlvbmFscyByYXRoZXIgdGhhbiBhbHRl cm5hdGl2ZXMuCisgKiBUaGlzIGlzIGxvZ2ljYWwgbWVyZ2Ugb2Y6CisgKiAg ICBET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1heWJleGVuPTAKKyAqICAgIERP X09WRVJXUklURV9SU0IKKyAqICAgIERPX1NQRUNfQ1RSTF9FTlRSWSBtYXli ZXhlbj0xCisgKiBidXQgd2l0aCBjb25kaXRpb25hbHMgcmF0aGVyIHRoYW4g YWx0ZXJuYXRpdmVzLgogICovCiAgICAgbW92emJsIFNUQUNLX0NQVUlORk9f RklFTEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KSwgJWVieAogCisgICAgdGVz dCAgICAkU0NGX2lzdF9pYnBiLCAlYmwKKyAgICBqeiAgICAgIC5MXEBfc2tp cF9pYnBiCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAg ICBtb3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKwor LkxcQF9za2lwX2licGI6CisKICAgICB0ZXN0ICRTQ0ZfaXN0X3JzYiwgJWJs CiAgICAganogLkxcQF9za2lwX3JzYgogCg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-6.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-6.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2NwdWlkOiBFbnVtZXJhdGlvbiBmb3IgQlRDX05P CgpCVENfTk8gaW5kaWNhdGVzIHRoYXQgaGFyZHdhcmUgaXMgbm90IHN1Y2Nl cHRhYmxlIHRvIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KClplbjMgQ1BVcyBk b24ndCBzdWZmZXIgQlRDLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcuCgpT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpp bmRleCBkNDYyZjllNDIxZWQuLmJmNmZkZWUzNjBhOSAxMDA2NDQKLS0tIGEv dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfY3B1aWQuYwpAQCAtMjg4LDYgKzI4OCw3IEBAIGlu dCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25maWcobGlieGxfY3B1aWRfcG9saWN5 X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFyKiBzdHIpCiAgICAgICAgIHsidmly dC1zc2JkIiwgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI1 LCAgMX0sCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCisgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCiAKICAgICAgICAgeyJuYyIsICAg ICAgICAgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgIDAsICA4 fSwKICAgICAgICAgeyJhcGljaWRzaXplIiwgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgMTIsICA0fSwKZGlmZiAtLWdpdCBhL3Rvb2xzL21p c2MveGVuLWNwdWlkLmMgYi90b29scy9taXNjL3hlbi1jcHVpZC5jCmluZGV4 IGJjN2RjZjU1NzU3YS4uZmUyMmY1ZjViNjhiIDEwMDY0NAotLS0gYS90b29s cy9taXNjL3hlbi1jcHVpZC5jCisrKyBiL3Rvb2xzL21pc2MveGVuLWNwdWlk LmMKQEAgLTE1OCw3ICsxNTgsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqY29u c3Qgc3RyX2U4YlszMl0gPQogICAgIC8qIFsyMl0gKi8gICAgICAgICAgICAg ICAgIFsyM10gPSAicHBpbiIsCiAgICAgWzI0XSA9ICJhbWQtc3NiZCIsICAg ICAgICAgWzI1XSA9ICJ2aXJ0LXNzYmQiLAogICAgIFsyNl0gPSAic3NiLW5v IiwKLSAgICBbMjhdID0gInBzZmQiLAorICAgIFsyOF0gPSAicHNmZCIsICAg ICAgICAgICAgIFsyOV0gPSAiYnRjLW5vIiwKIH07CiAKIHN0YXRpYyBjb25z dCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvY3B1L2FtZC5jIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpp bmRleCBiM2I5YTBkZjVmZWQuLmIxNThlM2FjYjVjNyAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2NwdS9hbWQuYworKysgYi94ZW4vYXJjaC94ODYvY3B1 L2FtZC5jCkBAIC04NDcsNiArODQ3LDE2IEBAIHN0YXRpYyB2b2lkIGluaXRf YW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAkJCXdhcm5pbmdfYWRkKHRl eHQpOwogCQl9CiAJCWJyZWFrOworCisJY2FzZSAweDE5OgorCQkvKgorCQkg KiBaZW4zIChGYW0xOWggbW9kZWwgPCAweDEwKSBwYXJ0cyBhcmUgbm90IHN1 c2NlcHRpYmxlIHRvCisJCSAqIEJyYW5jaCBUeXBlIENvbmZ1c2lvbiwgYnV0 IHByZWRhdGUgdGhlIGFsbG9jYXRpb24gb2YgdGhlCisJCSAqIEJUQ19OTyBi aXQuICBGaWxsIGl0IGJhY2sgaW4gaWYgd2UncmUgbm90IHZpcnR1YWxpc2Vk LgorCQkgKi8KKwkJaWYgKCFjcHVfaGFzX2h5cGVydmlzb3IgJiYgIWNwdV9o YXMoYywgWDg2X0ZFQVRVUkVfQlRDX05PKSkKKwkJCV9fc2V0X2JpdChYODZf RkVBVFVSRV9CVENfTk8sIGMtPng4Nl9jYXBhYmlsaXR5KTsKKwkJYnJlYWs7 CiAJfQogCiAJZGlzcGxheV9jYWNoZWluZm8oYyk7CmRpZmYgLS1naXQgYS94 ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKaW5kZXggZjRhZTM2ZWFlMmQwLi4wZjEwMWMwNTdmM2UgMTAwNjQ0 Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJj aC94ODYvc3BlY19jdHJsLmMKQEAgLTM4OCw3ICszODgsNyBAQCBzdGF0aWMg dm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVu aywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSByZWFkLW9ubHkg aW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2VydGFpbiBpc3N1 ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2ggbWl0aWdhdGlv biB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhp bnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIsCisgICAgcHJp bnRrKCIgIEhhcmR3YXJlIGhpbnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMl cyVzJXMlc1xuIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNIX0NBUFNfUkRD TF9OTykgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUkRDTF9OTyIgICAg ICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9DQVBTX0lCUlNf QUxMKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUlNfQUxMIiAgICAg ICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQU19SU0JBKSAg ICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBSU0JBIiAgICAgICAgICAg OiAiIiwKQEAgLTQwMyw3ICs0MDMsOCBAQCBzdGF0aWMgdm9pZCBfX2luaXQg cHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywgdWludDY0X3Qg Y2FwcykKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfSUJSU19BTFdBWVMpKSAgICA/ICIgSUJSU19BTFdBWVMiICAgIDog IiIsCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNrKFg4Nl9GRUFU VVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZUyIgICA6ICIi LAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVS RV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAgICAgOiAiIiwK LSAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVf SUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUiIDogIiIpOwor ICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZfRkVBVFVSRV9J QlJTX1NBTUVfTU9ERSkpID8gIiBJQlJTX1NBTUVfTU9ERSIgOiAiIiwKKyAg ICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZFQVRVUkVfQlRD X05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDogIiIpOwogCiAg ICAgLyogSGFyZHdhcmUgZmVhdHVyZXMgd2hpY2ggbmVlZCBkcml2aW5nIHRv IG1pdGlnYXRlIGlzc3Vlcy4gKi8KICAgICBwcmludGsoIiAgSGFyZHdhcmUg ZmVhdHVyZXM6JXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4iLApkaWZmIC0t Z2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZlYXR1cmVz ZXQuaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJl c2V0LmgKaW5kZXggNzQzYjg1N2RjZDVjLi5lN2I4MTY3ODAwYTIgMTAwNjQ0 Ci0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9jcHVmZWF0dXJl c2V0LmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2NwdWZl YXR1cmVzZXQuaApAQCAtMjY2LDYgKzI2Niw3IEBAIFhFTl9DUFVGRUFUVVJF KEFNRF9TU0JELCAgICAgIDgqMzIrMjQpIC8qUyAgTVNSX1NQRUNfQ1RSTC5T U0JEIGF2YWlsYWJsZSAqLwogWEVOX0NQVUZFQVRVUkUoVklSVF9TU0JELCAg ICAgOCozMisyNSkgLyogICBNU1JfVklSVF9TUEVDX0NUUkwuU1NCRCAqLwog WEVOX0NQVUZFQVRVUkUoU1NCX05PLCAgICAgICAgOCozMisyNikgLypBICBI YXJkd2FyZSBub3QgdnVsbmVyYWJsZSB0byBTU0IgKi8KIFhFTl9DUFVGRUFU VVJFKFBTRkQsICAgICAgICAgIDgqMzIrMjgpIC8qUyAgTVNSX1NQRUNfQ1RS TC5QU0ZEICovCitYRU5fQ1BVRkVBVFVSRShCVENfTk8sICAgICAgICA4KjMy KzI5KSAvKkEgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRvIEJyYW5jaCBU eXBlIENvbmZ1c2lvbiAqLwogCiAvKiBJbnRlbC1kZWZpbmVkIENQVSBmZWF0 dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwgd29yZCA5ICov CiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMyKyAyKSAvKkEg IEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMgKi8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-7.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-7.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW5hYmxlIFplbjIgY2hpY2tl bmJpdAoKLi4uIGFzIGluc3RydWN0ZWQgaW4gdGhlIEJyYW5jaCBUeXBlIENv bmZ1c2lvbiB3aGl0ZXBhcGVyLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2FtZC5jCmluZGV4IGIxNThlM2Fj YjVjNy4uMzdhYzg0ZGRkNzRkIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKQEAgLTcz MSw2ICs3MzEsMzEgQEAgdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYykKIAkJcHJpbnRrX29uY2UoWEVOTE9HX0VSUiAi Tm8gU1NCRCBjb250cm9scyBhdmFpbGFibGVcbiIpOwogfQogCisvKgorICog T24gWmVuMiB3ZSBvZmZlciB0aGlzIGNoaWNrZW4gKGJpdCkgb24gdGhlIGFs dGFyIG9mIFNwZWN1bGF0aW9uLgorICoKKyAqIFJlZmVyIHRvIHRoZSBBTUQg QnJhbmNoIFR5cGUgQ29uZnVzaW9uIHdoaXRlcGFwZXI6CisgKiBodHRwczov L1hYWAorICoKKyAqIFNldHRpbmcgdGhpcyB1bm5hbWVkIGJpdCBzdXBwb3Nl ZGx5IGNhdXNlcyBwcmVkaWN0aW9uIGluZm9ybWF0aW9uIG9uCisgKiBub24t YnJhbmNoIGluc3RydWN0aW9ucyB0byBiZSBpZ25vcmVkLiAgSXQgaXMgdG8g YmUgc2V0IHVuaWxhdGVyYWxseSBpbgorICogbmV3ZXIgbWljcm9jb2RlLgor ICoKKyAqIFRoaXMgY2hpY2tlbmJpdCBpcyBzb21ldGhpbmcgdW5yZWxhdGVk IG9uIFplbjEsIGFuZCBaZW4xIHZzIFplbjIgaXNuJ3QgYQorICogc2ltcGxl IG1vZGVsIG51bWJlciBjb21wYXJpc29uLCBzbyB1c2UgU1RJQlAgYXMgYSBo ZXVyaXN0aWMgdG8gc2VwYXJhdGUgdGhlCisgKiB0d28gdWFyY2hlcyBpbiBG YW0xN2goQU1EKS8xOGgoSHlnb24pLgorICovCit2b2lkIGFtZF9pbml0X3Nw ZWN0cmFsX2NoaWNrZW4odm9pZCkKK3sKKwl1aW50NjRfdCB2YWwsIGNoaWNr ZW5iaXQgPSAxIDw8IDE7CisKKwlpZiAoY3B1X2hhc19oeXBlcnZpc29yIHx8 ICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkKKwkJcmV0 dXJuOworCisJaWYgKHJkbXNyX3NhZmUoTVNSX0FNRDY0X0RFX0NGRzIsIHZh bCkgPT0gMCAmJiAhKHZhbCAmIGNoaWNrZW5iaXQpKQorCQl3cm1zcl9zYWZl KE1TUl9BTUQ2NF9ERV9DRkcyLCB2YWwgfCBjaGlja2VuYml0KTsKK30KKwog dm9pZCBfX2luaXQgZGV0ZWN0X3plbjJfbnVsbF9zZWdfYmVoYXZpb3VyKHZv aWQpCiB7CiAJdWludDY0X3QgYmFzZTsKQEAgLTc5Niw2ICs4MjEsOSBAQCBz dGF0aWMgdm9pZCBpbml0X2FtZChzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAK IAlhbWRfaW5pdF9zc2JkKGMpOwogCisJaWYgKGMtPng4NiA9PSAweDE3KQor CQlhbWRfaW5pdF9zcGVjdHJhbF9jaGlja2VuKCk7CisKIAkvKiBQcm9iZSBm b3IgTlNDQiBvbiBaZW4yIENQVXMgd2hlbiBub3QgdmlydHVhbGlzZWQgKi8K IAlpZiAoIWNwdV9oYXNfaHlwZXJ2aXNvciAmJiAhY3B1X2hhc19uc2NiICYm IGMgPT0gJmJvb3RfY3B1X2RhdGEgJiYKIAkgICAgYy0+eDg2ID09IDB4MTcp CmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvY3B1L2NwdS5oIGIveGVuL2Fy Y2gveDg2L2NwdS9jcHUuaAppbmRleCBiNTkzYmQ4NWYwNGYuLjE0NWJjNTE1 NmE4NiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2NwdS9jcHUuaAorKysg Yi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCkBAIC0yMiw0ICsyMiw1IEBAIHZv aWQgZWFybHlfaW5pdF9hbWQoc3RydWN0IGNwdWluZm9feDg2ICpjKTsKIHZv aWQgYW1kX2xvZ19mcmVxKGNvbnN0IHN0cnVjdCBjcHVpbmZvX3g4NiAqYyk7 CiB2b2lkIGFtZF9pbml0X2xmZW5jZShzdHJ1Y3QgY3B1aW5mb194ODYgKmMp Owogdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVjdCBjcHVpbmZvX3g4 NiAqYyk7Cit2b2lkIGFtZF9pbml0X3NwZWN0cmFsX2NoaWNrZW4odm9pZCk7 CiB2b2lkIGRldGVjdF96ZW4yX251bGxfc2VnX2JlaGF2aW91cih2b2lkKTsK ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYyBiL3hlbi9h cmNoL3g4Ni9jcHUvaHlnb24uYwppbmRleCBjZGM5NDEzMGRkMmUuLjZmOGQ0 OTEyOTdlOCAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2NwdS9oeWdvbi5j CisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYwpAQCAtNDEsNiArNDEs MTIgQEAgc3RhdGljIHZvaWQgaW5pdF9oeWdvbihzdHJ1Y3QgY3B1aW5mb194 ODYgKmMpCiAJCWRldGVjdF96ZW4yX251bGxfc2VnX2JlaGF2aW91cigpOwog CiAJLyoKKwkgKiBUT0RPOiBDaGVjayBoZXVyaXN0aWMgc2FmZXR5IHdpdGgg SHlnb24gZmlyc3QKKwlpZiAoYy0+eDg2ID09IDB4MTgpCisJCWFtZF9pbml0 X3NwZWN0cmFsX2NoaWNrZW4oKTsKKwkgKi8KKworCS8qCiAJICogSHlnb24g Q1BVcyBiZWZvcmUgWmVuMiBkb24ndCBjbGVhciBzZWdtZW50IGJhc2VzL2xp bWl0cyB3aGVuCiAJICogbG9hZGluZyBhIE5VTEwgc2VsZWN0b3IuCiAJICov CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L21zci1pbmRleC5o IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9tc3ItaW5kZXguaAppbmRleCA3MmJj MzJiYTA0ZmYuLmQzNzM1ZTQ5OWUwZiAxMDA2NDQKLS0tIGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9tc3ItaW5kZXguaAorKysgYi94ZW4vaW5jbHVkZS9hc20t eDg2L21zci1pbmRleC5oCkBAIC0zNjEsNiArMzYxLDcgQEAKICNkZWZpbmUg TVNSX0FNRDY0X0RFX0NGRwkJMHhjMDAxMTAyOQogI2RlZmluZSBBTUQ2NF9E RV9DRkdfTEZFTkNFX1NFUklBTElTRQkoX0FDKDEsIFVMTCkgPDwgMSkKICNk ZWZpbmUgTVNSX0FNRDY0X0VYX0NGRwkJMHhjMDAxMTAyYworI2RlZmluZSBN U1JfQU1ENjRfREVfQ0ZHMgkJMHhjMDAxMTBlMwogCiAjZGVmaW5lIE1TUl9B TUQ2NF9EUjBfQUREUkVTU19NQVNLCTB4YzAwMTEwMjcKICNkZWZpbmUgTVNS X0FNRDY0X0RSMV9BRERSRVNTX01BU0sJMHhjMDAxMTAxOQo= --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.16-8.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.16-8.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQnJhbmNoIFR5 cGUgQ29uZnVzaW9uIHdoZW4gcG9zc2libGUKCkJyYW5jaCBUeXBlIENvbmZ1 c2lvbiBhZmZlY3RzIEFNRC9IeWdvbiBDUFVzIG9uIFplbjIgYW5kIGVhcmxp ZXIuICBUbwptaXRpZ2F0ZSwgd2UgcmVxdWlyZSBTTVQgc2FmZXR5IChTVElC UCBvbiBaZW4yLCBuby1TTVQgb24gWmVuMSksIGFuZCB0byBpc3N1ZQphbiBJ QlBCIG9uIGVhY2ggZW50cnkgdG8gWGVuLCB0byBmbHVzaCB0aGUgQlRCLgoK RHVlIHRvIHBlcmZvcm1hbmNlIGNvbmNlcm5zLCBkb20wICh3aGljaCBpcyB0 cnVzdGVkIGluIG1vc3QgY29uZmlndXJhdGlvbnMpIGlzCmV4Y2x1ZGVkIGZy b20gcHJvdGVjdGlvbnMgYnkgZGVmYXVsdC4KClRoZXJlZm9yZToKICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgb24gWmVuMiB0b28sIHdoaWNoIG5vdyBtZWFu cyB3ZSB3YW50IGl0IG9uIGJ5IGRlZmF1bHQKICAgb24gYWxsIGhhcmR3YXJl IHN1cHBvcnRpbmcgU1RJQlAuCiAqIEJyZWFrIHRoZSBjdXJyZW50IElCUEIg bG9naWMgb3V0IGludG8gYSBuZXcgZnVuY3Rpb24sIGV4dGVuZGluZyBpdCB3 aXRoCiAgIElCUEItYXQtZW50cnkgbG9naWMuCiAqIENoYW5nZSB0aGUgZXhp c3RpbmcgSUJQQi1hdC1jdHh0LXN3aXRjaCBib29sZWFuIHRvIGJlIHRyaXN0 YXRlLCBhbmQgZGlzYWJsZQogICBpdCBieSBkZWZhdWx0IHdoZW4gSUJQQi1h dC1lbnRyeSBpcyBwcm92aWRpbmcgc3VmZmljaWVudCBzYWZldHkuCgpJZiBh bGwgUFYgZ3Vlc3RzIG9uIHRoZSBzeXN0ZW0gYXJlIHRydXN0ZWQsIHRoZW4g aXQgaXMgcmVjb21tZW5kZWQgdG8gYm9vdAp3aXRoIGBzcGVjLWN0cmw9aWJw Yi1lbnRyeT1uby1wdmAsIGFzIHRoaXMgd2lsbCBwcm92aWRlIGFuIGFkZGl0 aW9uYWwgbWFyZ2luYWwKcGVyZiBpbXByb3ZlbWVudC4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDA3IC8gQ1ZFLTIwMjItMjM4MjUuCgpTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoK ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRv YyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYwppbmRleCAx YmJkYjU1MTI5Y2MuLmJkNjgyNmQwYWUwNSAxMDA2NDQKLS0tIGEvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCisrKyBiL2RvY3MvbWlzYy94 ZW4tY29tbWFuZC1saW5lLnBhbmRvYwpAQCAtMjIzNCw3ICsyMjM0LDcgQEAg QnkgZGVmYXVsdCBTU0JEIHdpbGwgYmUgbWl0aWdhdGVkIGF0IHJ1bnRpbWUg KGkuZSBgc3NiZD1ydW50aW1lYCkuCiAKICMjIyBzcGVjLWN0cmwgKHg4NikK ID4gYD0gTGlzdCBvZiBbIDxib29sPiwgeGVuPTxib29sPiwge3B2LGh2bX09 PGJvb2w+LAotPiAgICAgICAgICAgICAge21zci1zYyxyc2IsbWQtY2xlYXJ9 PTxib29sPnx7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAgICAgICB7bXNy LXNjLHJzYixtZC1jbGVhcixpYnBiLWVudHJ5fT08Ym9vbD58e3B2LGh2bX09 PGJvb2w+LAogPiAgICAgICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxs ZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQscHNmZCwKID4gICAgICAgICAg ICAgIGVhZ2VyLWZwdSxsMWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9j aywKID4gICAgICAgICAgICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKQEAg LTIyNTksOSArMjI1OSwxMCBAQCBpbiBwbGFjZSBmb3IgZ3Vlc3RzIHRvIHVz ZS4KIAogVXNlIG9mIGEgcG9zaXRpdmUgYm9vbGVhbiB2YWx1ZSBmb3IgZWl0 aGVyIG9mIHRoZXNlIG9wdGlvbnMgaXMgaW52YWxpZC4KIAotVGhlIGBwdj1g LCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gIGFuZCBgbWQtY2xlYXI9YCBv cHRpb25zIG9mZmVyIGZpbmUKLWdyYWluZWQgY29udHJvbCBvdmVyIHRoZSBw cmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGltcGFjdCBYZW4ncyBhYmlsaXR5 IHRvCi1wcm90ZWN0IGl0c2VsZiwgYW5kL29yIFhlbidzIGFiaWxpdHkgdG8g dmlydHVhbGlzZSBzdXBwb3J0IGZvciBndWVzdHMgdG8gdXNlLgorVGhlIGBw dj1gLCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gLCBgbWQtY2xlYXI9YCBh bmQgYGlicGItZW50cnk9YCBvcHRpb25zCitvZmZlciBmaW5lIGdyYWluZWQg Y29udHJvbCBvdmVyIHRoZSBwcmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGlt cGFjdCBYZW4ncworYWJpbGl0eSB0byBwcm90ZWN0IGl0c2VsZiwgYW5kL29y IFhlbidzIGFiaWxpdHkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgorZ3Vl c3RzIHRvIHVzZS4KIAogKiBgcHY9YCBhbmQgYGh2bT1gIG9mZmVyIGNvbnRy b2wgb3ZlciBhbGwgc3Vib3B0aW9ucyBmb3IgUFYgYW5kIEhWTSBndWVzdHMK ICAgcmVzcGVjdGl2ZWx5LgpAQCAtMjI4MCw2ICsyMjgxLDExIEBAIHByb3Rl Y3QgaXRzZWxmLCBhbmQvb3IgWGVuJ3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNl IHN1cHBvcnQgZm9yIGd1ZXN0cyB0byB1c2UuCiAgIGNvbXBhdGliaWxpdHkg d2l0aCBkZXZlbG9wbWVudCB2ZXJzaW9ucyBvZiB0aGlzIGZpeCwgYG1kcz1g IGlzIGFsc28gYWNjZXB0ZWQKICAgb24gWGVuIDQuMTIgYW5kIGVhcmxpZXIg YXMgYW4gYWxpYXMuICBDb25zdWx0IHZlbmRvciBkb2N1bWVudGF0aW9uIGlu CiAgIHByZWZlcmVuY2UgdG8gaGVyZS4qCisqIGBpYnBiLWVudHJ5PWAgb2Zm ZXJzIGNvbnRyb2wgb3ZlciB3aGV0aGVyIElCUEIgKEluZGlyZWN0IEJyYW5j aCBQcmVkaWN0aW9uCisgIEJhcnJpZXIpIGlzIHVzZWQgb24gZW50cnkgdG8g WGVuLiAgVGhpcyBpcyB1c2VkIGJ5IGRlZmF1bHQgb24gaGFyZHdhcmUKKyAg dnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucywgZG9tMCBpcworICB1bnByb3RlY3RlZCBi eSBkZWZhdWx0LiAgSWYgaXQgbmVjZXNzYXJ5IHRvIHByb3RlY3QgZG9tMCB0 b28sIGJvb3Qgd2l0aAorICBgc3BlYy1jdHJsPWlicGItZW50cnlgLgogCiBJ ZiBYZW4gd2FzIGNvbXBpbGVkIHdpdGggSU5ESVJFQ1RfVEhVTksgc3VwcG9y dCwgYGJ0aS10aHVuaz1gIGNhbiBiZSB1c2VkIHRvCiBzZWxlY3Qgd2hpY2gg b2YgdGhlIHRodW5rcyBnZXRzIHBhdGNoZWQgaW50byB0aGUgYF9feDg2X2lu ZGlyZWN0X3RodW5rXyVyZWdgCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv c3BlY19jdHJsLmMgYi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKaW5kZXgg MGYxMDFjMDU3ZjNlLi4xZDk3OTZjMzRkNzEgMTAwNjQ0Ci0tLSBhL3hlbi9h cmNoL3g4Ni9zcGVjX2N0cmwuYworKysgYi94ZW4vYXJjaC94ODYvc3BlY19j dHJsLmMKQEAgLTM5LDYgKzM5LDEwIEBAIHN0YXRpYyBib29sIF9faW5pdGRh dGEgb3B0X3JzYl9odm0gPSB0cnVlOwogc3RhdGljIGludDhfdCBfX3JlYWRf bW9zdGx5IG9wdF9tZF9jbGVhcl9wdiA9IC0xOwogc3RhdGljIGludDhfdCBf X3JlYWRfbW9zdGx5IG9wdF9tZF9jbGVhcl9odm0gPSAtMTsKIAorc3RhdGlj IGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBiX2VudHJ5X3B2ID0gLTE7 CitzdGF0aWMgaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJfZW50cnlf aHZtID0gLTE7CitzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IG9wdF9pYnBi X2VudHJ5X2RvbTA7CisKIC8qIENtZGxpbmUgY29udHJvbHMgZm9yIFhlbidz IHNwZWN1bGF0aXZlIHNldHRpbmdzLiAqLwogc3RhdGljIGVudW0gaW5kX3Ro dW5rIHsKICAgICBUSFVOS19ERUZBVUxULCAvKiBEZWNpZGUgd2hpY2ggdGh1 bmsgdG8gdXNlIGF0IGJvb3QgdGltZS4gKi8KQEAgLTU0LDcgKzU4LDcgQEAg aW50OF90IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7CiBib29sIF9fcmVh ZF9tb3N0bHkgb3B0X3NzYmQ7CiBpbnQ4X3QgX19pbml0ZGF0YSBvcHRfcHNm ZCA9IC0xOwogCi1ib29sIF9fcmVhZF9tb3N0bHkgb3B0X2licGJfY3R4dF9z d2l0Y2ggPSB0cnVlOworaW50OF90IF9fcmVhZF9tb3N0bHkgb3B0X2licGJf Y3R4dF9zd2l0Y2ggPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9l YWdlcl9mcHUgPSAtMTsKIGludDhfdCBfX3JlYWRfbW9zdGx5IG9wdF9sMWRf Zmx1c2ggPSAtMTsKIHN0YXRpYyBib29sIF9faW5pdGRhdGEgb3B0X2JyYW5j aF9oYXJkZW4gPSB0cnVlOwpAQCAtMTE0LDYgKzExOCw5IEBAIHN0YXRpYyBp bnQgX19pbml0IHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFyICpzKQogICAg ICAgICAgICAgb3B0X3JzYl9odm0gPSBmYWxzZTsKICAgICAgICAgICAgIG9w dF9tZF9jbGVhcl9wdiA9IDA7CiAgICAgICAgICAgICBvcHRfbWRfY2xlYXJf aHZtID0gMDsKKyAgICAgICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gMDsK KyAgICAgICAgICAgIG9wdF9pYnBiX2VudHJ5X2h2bSA9IDA7CisgICAgICAg ICAgICBvcHRfaWJwYl9lbnRyeV9kb20wID0gZmFsc2U7CiAKICAgICAgICAg ICAgIG9wdF90aHVuayA9IFRIVU5LX0pNUDsKICAgICAgICAgICAgIG9wdF9p YnJzID0gMDsKQEAgLTE0MCwxMiArMTQ3LDE0IEBAIHN0YXRpYyBpbnQgX19p bml0IHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFyICpzKQogICAgICAgICAg ICAgb3B0X21zcl9zY19wdiA9IHZhbDsKICAgICAgICAgICAgIG9wdF9yc2Jf cHYgPSB2YWw7CiAgICAgICAgICAgICBvcHRfbWRfY2xlYXJfcHYgPSB2YWw7 CisgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9wdiA9IHZhbDsKICAgICAg ICAgfQogICAgICAgICBlbHNlIGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4o Imh2bSIsIHMsIHNzKSkgPj0gMCApCiAgICAgICAgIHsKICAgICAgICAgICAg IG9wdF9tc3Jfc2NfaHZtID0gdmFsOwogICAgICAgICAgICAgb3B0X3JzYl9o dm0gPSB2YWw7CiAgICAgICAgICAgICBvcHRfbWRfY2xlYXJfaHZtID0gdmFs OworICAgICAgICAgICAgb3B0X2licGJfZW50cnlfaHZtID0gdmFsOwogICAg ICAgICB9CiAgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVh bigibXNyLXNjIiwgcywgc3MpKSAhPSAtMSApCiAgICAgICAgIHsKQEAgLTIx MCw2ICsyMTksMjggQEAgc3RhdGljIGludCBfX2luaXQgcGFyc2Vfc3BlY19j dHJsKGNvbnN0IGNoYXIgKnMpCiAgICAgICAgICAgICAgICAgYnJlYWs7CiAg ICAgICAgICAgICB9CiAgICAgICAgIH0KKyAgICAgICAgZWxzZSBpZiAoICh2 YWwgPSBwYXJzZV9ib29sZWFuKCJpYnBiLWVudHJ5Iiwgcywgc3MpKSAhPSAt MSApCisgICAgICAgIHsKKyAgICAgICAgICAgIHN3aXRjaCAoIHZhbCApCisg ICAgICAgICAgICB7CisgICAgICAgICAgICBjYXNlIDA6CisgICAgICAgICAg ICBjYXNlIDE6CisgICAgICAgICAgICAgICAgb3B0X2licGJfZW50cnlfcHYg PSBvcHRfaWJwYl9lbnRyeV9odm0gPQorICAgICAgICAgICAgICAgICAgICBv cHRfaWJwYl9lbnRyeV9kb20wID0gdmFsOworICAgICAgICAgICAgICAgIGJy ZWFrOworCisgICAgICAgICAgICBjYXNlIC0yOgorICAgICAgICAgICAgICAg IHMgKz0gc3RybGVuKCJpYnBiLWVudHJ5PSIpOworICAgICAgICAgICAgICAg IGlmICggKHZhbCA9IHBhcnNlX2Jvb2xlYW4oInB2Iiwgcywgc3MpKSA+PSAw ICkKKyAgICAgICAgICAgICAgICAgICAgb3B0X2licGJfZW50cnlfcHYgPSB2 YWw7CisgICAgICAgICAgICAgICAgZWxzZSBpZiAoICh2YWwgPSBwYXJzZV9i b29sZWFuKCJodm0iLCBzLCBzcykpID49IDAgKQorICAgICAgICAgICAgICAg ICAgICBvcHRfaWJwYl9lbnRyeV9odm0gPSB2YWw7CisgICAgICAgICAgICAg ICAgZWxzZQorICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAg ICAgICAgcmMgPSAtRUlOVkFMOworICAgICAgICAgICAgICAgIGJyZWFrOwor ICAgICAgICAgICAgfQorICAgICAgICB9CiAKICAgICAgICAgLyogWGVuJ3Mg c3BlY3VsYXRpdmUgc2lkZWNoYW5uZWwgbWl0aWdhdGlvbiBzZXR0aW5ncy4g Ki8KICAgICAgICAgZWxzZSBpZiAoICFzdHJuY21wKHMsICJidGktdGh1bms9 IiwgMTApICkKQEAgLTQ3NywyNyArNTA4LDMxIEBAIHN0YXRpYyB2b2lkIF9f aW5pdCBwcmludF9kZXRhaWxzKGVudW0gaW5kX3RodW5rIHRodW5rLCB1aW50 NjRfdCBjYXBzKQogICAgICAqIG1pdGlnYXRpb24gc3VwcG9ydCBmb3IgZ3Vl c3RzLgogICAgICAqLwogI2lmZGVmIENPTkZJR19IVk0KLSAgICBwcmludGso IiAgU3VwcG9ydCBmb3IgSFZNIFZNczolcyVzJXMlcyVzXG4iLAorICAgIHBy aW50aygiICBTdXBwb3J0IGZvciBIVk0gVk1zOiVzJXMlcyVzJXMlc1xuIiwK ICAgICAgICAgICAgKGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19NU1Jf SFZNKSB8fAogICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJF X1NDX1JTQl9IVk0pIHx8CiAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfTURfQ0xFQVIpICAgfHwKKyAgICAgICAgICAgIGJvb3RfY3B1 X2hhcyhYODZfRkVBVFVSRV9JQlBCX0VOVFJZX0hWTSkgfHwKICAgICAgICAg ICAgIG9wdF9lYWdlcl9mcHUpICAgICAgICAgICAgICAgICAgICAgICAgICAg PyAiIiAgICAgICAgICAgICAgIDogIiBOb25lIiwKICAgICAgICAgICAgYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9IVk0pICAgICAgPyAiIE1T Ul9TUEVDX0NUUkwiIDogIiIsCiAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhY ODZfRkVBVFVSRV9TQ19SU0JfSFZNKSAgICAgID8gIiBSU0IiICAgICAgICAg ICA6ICIiLAogICAgICAgICAgICBvcHRfZWFnZXJfZnB1ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA/ICIgRUFHRVJfRlBVIiAgICAgOiAiIiwKLSAg ICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX01EX0NMRUFSKSAg ICAgICAgPyAiIE1EX0NMRUFSIiAgICAgIDogIiIpOworICAgICAgICAgICBi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAgICA/ICIg TURfQ0xFQVIiICAgICAgOiAiIiwKKyAgICAgICAgICAgYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfSFZNKSAgPyAiIElCUEItZW50cnki ICAgIDogIiIpOwogCiAjZW5kaWYKICNpZmRlZiBDT05GSUdfUFYKLSAgICBw cmludGsoIiAgU3VwcG9ydCBmb3IgUFYgVk1zOiVzJXMlcyVzJXNcbiIsCisg ICAgcHJpbnRrKCIgIFN1cHBvcnQgZm9yIFBWIFZNczolcyVzJXMlcyVzJXNc biIsCiAgICAgICAgICAgIChib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0Nf TVNSX1BWKSB8fAogICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX1NDX1JTQl9QVikgfHwKICAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhY ODZfRkVBVFVSRV9NRF9DTEVBUikgIHx8CisgICAgICAgICAgICBib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfSUJQQl9FTlRSWV9QVikgfHwKICAgICAgICAg ICAgIG9wdF9lYWdlcl9mcHUpICAgICAgICAgICAgICAgICAgICAgICAgICAg PyAiIiAgICAgICAgICAgICAgIDogIiBOb25lIiwKICAgICAgICAgICAgYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9QVikgICAgICAgPyAiIE1T Ul9TUEVDX0NUUkwiIDogIiIsCiAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhY ODZfRkVBVFVSRV9TQ19SU0JfUFYpICAgICAgID8gIiBSU0IiICAgICAgICAg ICA6ICIiLAogICAgICAgICAgICBvcHRfZWFnZXJfZnB1ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA/ICIgRUFHRVJfRlBVIiAgICAgOiAiIiwKLSAg ICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX01EX0NMRUFSKSAg ICAgICAgPyAiIE1EX0NMRUFSIiAgICAgIDogIiIpOworICAgICAgICAgICBi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIpICAgICAgICA/ICIg TURfQ0xFQVIiICAgICAgOiAiIiwKKyAgICAgICAgICAgYm9vdF9jcHVfaGFz KFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfUFYpICAgPyAiIElCUEItZW50cnki ICAgIDogIiIpOwogCiAgICAgcHJpbnRrKCIgIFhQVEkgKDY0LWJpdCBQViBv bmx5KTogRG9tMCAlcywgRG9tVSAlcyAod2l0aCVzIFBDSUQpXG4iLAogICAg ICAgICAgICBvcHRfeHB0aV9od2RvbSA/ICJlbmFibGVkIiA6ICJkaXNhYmxl ZCIsCkBAIC03NTksNiArNzk0LDU1IEBAIHN0YXRpYyBib29sIF9faW5pdCBz aG91bGRfdXNlX2VhZ2VyX2ZwdSh2b2lkKQogICAgIH0KIH0KIAorc3RhdGlj IHZvaWQgX19pbml0IGlicGJfY2FsY3VsYXRpb25zKHZvaWQpCit7CisgICAg LyogQ2hlY2sgd2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQgYmVmb3Jl IHVzaW5nIGl0Li4uICovCisgICAgaWYgKCAhYm9vdF9jcHVfaGFzKFg4Nl9G RUFUVVJFX0lCUlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lC UEIpICkKKyAgICB7CisgICAgICAgIG9wdF9pYnBiX2VudHJ5X2h2bSA9IG9w dF9pYnBiX2VudHJ5X3B2ID0gb3B0X2licGJfY3R4dF9zd2l0Y2ggPSAwOwor ICAgICAgICBvcHRfaWJwYl9lbnRyeV9kb20wID0gZmFsc2U7CisgICAgICAg IHJldHVybjsKKyAgICB9CisKKyAgICAvKgorICAgICAqIElCUEItb24tZW50 cnkgbWl0aWdhdGlvbnMgZm9yIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KKyAg ICAgKgorICAgICAqIElCUEIgJiYgIUJUQ19OTyBzZWxlY3RzIGFsbCBBTUQv SHlnb24gaGFyZHdhcmUsIG5vdCBrbm93biB0byBiZSBzYWZlLAorICAgICAq IHRoYXQgd2UgY2FuIHByb3ZpZGUgc29tZSBmb3JtIG9mIG1pdGlnYXRpb24g b24uCisgICAgICovCisgICAgaWYgKCBvcHRfaWJwYl9lbnRyeV9wdiA9PSAt MSApCisgICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gKElTX0VOQUJMRUQo Q09ORklHX1BWKSAmJgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikgJiYKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9C VENfTk8pKTsKKyAgICBpZiAoIG9wdF9pYnBiX2VudHJ5X2h2bSA9PSAtMSAp CisgICAgICAgIG9wdF9pYnBiX2VudHJ5X2h2bSA9IChJU19FTkFCTEVEKENP TkZJR19IVk0pICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQQikgJiYKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVf QlRDX05PKSk7CisKKyAgICBpZiAoIG9wdF9pYnBiX2VudHJ5X3B2ICkKKyAg ICB7CisgICAgICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0ZFQVRVUkVf SUJQQl9FTlRSWV9QVik7CisKKyAgICAgICAgLyoKKyAgICAgICAgICogV2Ug b25seSBuZWVkIHRvIGZsdXNoIGluIElTVCBjb250ZXh0IGlmIHdlJ3JlIHBy b3RlY3RpbmcgYWdhaW5zdCBQVgorICAgICAgICAgKiBndWVzdHMuICBIVk0g SUJQQi1vbi1lbnRyeSBwcm90ZWN0aW9ucyBhcmUgYm90aCBhdG9taWMgd2l0 aAorICAgICAgICAgKiBOTUkvI01DLCBzbyBjYW4ndCBpbnRlcnJ1cHQgWGVu IGFoZWFkIG9mIGhhdmluZyBhbHJlYWR5IGZsdXNoZWQgdGhlCisgICAgICAg ICAqIEJUQi4KKyAgICAgICAgICovCisgICAgICAgIGRlZmF1bHRfc3BlY19j dHJsX2ZsYWdzIHw9IFNDRl9pc3RfaWJwYjsKKyAgICB9CisgICAgaWYgKCBv cHRfaWJwYl9lbnRyeV9odm0gKQorICAgICAgICBzZXR1cF9mb3JjZV9jcHVf Y2FwKFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfSFZNKTsKKworICAgIC8qCisg ICAgICogSWYgd2UncmUgdXNpbmcgSUJQQi1vbi1lbnRyeSB0byBwcm90ZWN0 IGFnYWluc3QgUFYgYW5kIEhWTSBndWVzdHMKKyAgICAgKiAoaWdub3Jpbmcg ZG9tMCBpZiB0cnVzdGVkKSwgdGhlbiB0aGVyZSdzIG5vIG5lZWQgdG8gYWxz byBpc3N1ZSBJQlBCIG9uCisgICAgICogY29udGV4dCBzd2l0Y2ggdG9vLgor ICAgICAqLworICAgIGlmICggb3B0X2licGJfY3R4dF9zd2l0Y2ggPT0gLTEg KQorICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRjaCA9ICEob3B0X2licGJf ZW50cnlfaHZtICYmIG9wdF9pYnBiX2VudHJ5X3B2KTsKK30KKwogLyogQ2Fs Y3VsYXRlIHdoZXRoZXIgdGhpcyBDUFUgaXMgdnVsbmVyYWJsZSB0byBMMVRG LiAqLwogc3RhdGljIF9faW5pdCB2b2lkIGwxdGZfY2FsY3VsYXRpb25zKHVp bnQ2NF90IGNhcHMpCiB7CkBAIC0xMDE0LDggKzEwOTgsMTIgQEAgdm9pZCBz cGVjX2N0cmxfaW5pdF9kb21haW4oc3RydWN0IGRvbWFpbiAqZCkKICAgICBi b29sIHZlcncgPSAoKHB2ID8gb3B0X21kX2NsZWFyX3B2IDogb3B0X21kX2Ns ZWFyX2h2bSkgfHwKICAgICAgICAgICAgICAgICAgKG9wdF9mYl9jbGVhcl9t bWlvICYmIGlzX2lvbW11X2VuYWJsZWQoZCkpKTsKIAorICAgIGJvb2wgaWJw YiA9ICgocHYgPyBvcHRfaWJwYl9lbnRyeV9wdiA6IG9wdF9pYnBiX2VudHJ5 X2h2bSkgJiYKKyAgICAgICAgICAgICAgICAgKGQtPmRvbWFpbl9pZCAhPSAw IHx8IG9wdF9pYnBiX2VudHJ5X2RvbTApKTsKKwogICAgIGQtPmFyY2guc3Bl Y19jdHJsX2ZsYWdzID0KICAgICAgICAgKHZlcncgICA/IFNDRl92ZXJ3ICAg ICAgICAgOiAwKSB8CisgICAgICAgIChpYnBiICAgPyBTQ0ZfZW50cnlfaWJw YiAgIDogMCkgfAogICAgICAgICAwOwogfQogCkBAIC0xMTYyLDEyICsxMjUw LDE1IEBAIHZvaWQgX19pbml0IGluaXRfc3BlY3VsYXRpb25fbWl0aWdhdGlv bnModm9pZCkKICAgICB9CiAKICAgICAvKgotICAgICAqIFVzZSBTVElCUCBi eSBkZWZhdWx0IGlmIHRoZSBoYXJkd2FyZSBoaW50IGlzIHNldC4gIE90aGVy d2lzZSwgbGVhdmUgaXQKLSAgICAgKiBvZmYgYXMgaXQgYSBzZXZlcmUgcGVy Zm9ybWFuY2UgcGVudGFsdHkgb24gcHJlLWVJQlJTIEludGVsIGhhcmR3YXJl Ci0gICAgICogd2hlcmUgaXQgd2FzIHJldHJvZml0dGVkIGluIG1pY3JvY29k ZS4KKyAgICAgKiBVc2UgU1RJQlAgYnkgZGVmYXVsdCBvbiBhbGwgQU1EIHN5 c3RlbXMuICBaZW4zIGFuZCBsYXRlciBlbnVtZXJhdGUKKyAgICAgKiBTVElC UF9BTFdBWVMsIGJ1dCBTVElCUCBpcyBuZWVkZWQgb24gWmVuMiBhcyBwYXJ0 IG9mIHRoZSBtaXRpZ2F0aW9ucworICAgICAqIGZvciBCcmFuY2ggVHlwZSBD b25mdXNpb24uCisgICAgICoKKyAgICAgKiBMZWF2ZSBTVElCUCBvZmYgYnkg ZGVmYXVsdCBvbiBJbnRlbC4gIFByZS1lSUJSUyBzeXN0ZW1zIHN1ZmZlciBh CisgICAgICogc3Vic3RhbnRpYWwgcGVyZiBoaXQgd2hlbiBpdCB3YXMgaW1w bGVtZW50ZWQgaW4gbWljcm9jb2RlLgogICAgICAqLwogICAgIGlmICggb3B0 X3N0aWJwID09IC0xICkKLSAgICAgICAgb3B0X3N0aWJwID0gISFib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU1RJQlBfQUxXQVlTKTsKKyAgICAgICAgb3B0 X3N0aWJwID0gISFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQ KTsKIAogICAgIGlmICggb3B0X3N0aWJwICYmIChib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfU1RJQlApIHx8CiAgICAgICAgICAgICAgICAgICAgICAgIGJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9BTURfU1RJQlApKSApCkBAIC0xMjM5 LDkgKzEzMzAsNyBAQCB2b2lkIF9faW5pdCBpbml0X3NwZWN1bGF0aW9uX21p dGlnYXRpb25zKHZvaWQpCiAgICAgaWYgKCBvcHRfcnNiX2h2bSApCiAgICAg ICAgIHNldHVwX2ZvcmNlX2NwdV9jYXAoWDg2X0ZFQVRVUkVfU0NfUlNCX0hW TSk7CiAKLSAgICAvKiBDaGVjayB3ZSBoYXZlIGhhcmR3YXJlIElCUEIgc3Vw cG9ydCBiZWZvcmUgdXNpbmcgaXQuLi4gKi8KLSAgICBpZiAoICFib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfSUJSU0IpICYmICFib290X2NwdV9oYXMoWDg2 X0ZFQVRVUkVfSUJQQikgKQotICAgICAgICBvcHRfaWJwYl9jdHh0X3N3aXRj aCA9IGZhbHNlOworICAgIGlicGJfY2FsY3VsYXRpb25zKCk7CiAKICAgICAv KiBDaGVjayB3aGV0aGVyIEVhZ2VyIEZQVSBzaG91bGQgYmUgZW5hYmxlZCBi eSBkZWZhdWx0LiAqLwogICAgIGlmICggb3B0X2VhZ2VyX2ZwdSA9PSAtMSAp CmRpZmYgLS1naXQgYS94ZW4vaW5jbHVkZS9hc20teDg2L3NwZWNfY3RybC5o IGIveGVuL2luY2x1ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAppbmRleCAzZmM1 OTlhODE3YzQuLjk0MDNiODFkYzdhZiAxMDA2NDQKLS0tIGEveGVuL2luY2x1 ZGUvYXNtLXg4Ni9zcGVjX2N0cmwuaAorKysgYi94ZW4vaW5jbHVkZS9hc20t eDg2L3NwZWNfY3RybC5oCkBAIC02NSw3ICs2NSw3IEBACiB2b2lkIGluaXRf c3BlY3VsYXRpb25fbWl0aWdhdGlvbnModm9pZCk7CiB2b2lkIHNwZWNfY3Ry bF9pbml0X2RvbWFpbihzdHJ1Y3QgZG9tYWluICpkKTsKIAotZXh0ZXJuIGJv b2wgb3B0X2licGJfY3R4dF9zd2l0Y2g7CitleHRlcm4gaW50OF90IG9wdF9p YnBiX2N0eHRfc3dpdGNoOwogZXh0ZXJuIGJvb2wgb3B0X3NzYmQ7CiBleHRl cm4gaW50OF90IG9wdF9lYWdlcl9mcHU7CiBleHRlcm4gaW50OF90IG9wdF9s MWRfZmx1c2g7Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-4.patch" Content-Disposition: attachment; filename="xsa407/xsa407-4.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogUmV3b3JrIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX0lOVFJfSVNUCgpXZSBhcmUgc2hvcnRseSBnb2luZyB0byBh ZGQgYSBjb25kaXRpb25hbCBJQlBCIGluIHRoaXMgcGF0aC4KClRoZXJlZm9y ZSwgd2UgY2Fubm90IGhvbGQgc3BlY19jdHJsX2ZsYWdzIGluICVlYXgsIGFu ZCByZWx5IG9uIG9ubHkgY2xvYmJlcmluZwppdCBhZnRlciB3ZSdyZSBkb25l IHdpdGggaXRzIGNvbnRlbnRzLiAgJXJieCBpcyBhdmFpbGFibGUgZm9yIHVz ZSwgYW5kIHRoZQptb3JlIG5vcm1hbCByZWdpc3RlciB0byBob2xkIHByZXNl cnZlZCBpbmZvcm1hdGlvbiBpbi4KCldpdGggJXJheCBmcmVlZCB1cCwgdXNl IGl0IGluc3RlYWQgb2YgJXJkeCBmb3IgdGhlIFJTQiB0bXAgcmVnaXN0ZXIs IGFuZCBmb3IKdGhlIGFkanVzdG1lbnQgdG8gc3BlY19jdHJsX2ZsYWdzLgoK VGhpcyBsZWF2ZXMgbm8gdXNlIG9mICVyZHgsIGV4Y2VwdCBhcyAwIGZvciB0 aGUgdXBwZXIgaGFsZiBvZiBXUk1TUi4gIEluCnByYWN0aWNlLCAlcmR4IGlz IDAgZnJvbSBTQVZFX0FMTCBvbiBhbGwgcGF0aHMgYW5kIGlzbid0IGxpa2Vs eSB0byBjaGFuZ2UgaW4KdGhlIGZvcmVzZWVhYmxlIGZ1dHVyZSwgc28gdXBk YXRlIHRoZSBtYWNybyBlbnRyeSByZXF1aXJlbWVudHMgdG8gc3RhdGUgdGhp cwpkZXBlbmRlbmN5LiAgVGhpcyBtYXJnaW5hbCBvcHRpbWlzYXRpb24gY2Fu IGJlIHJldmlzaXRlZCBpZiBjaXJjdW1zdGFuY2VzCmNoYW5nZS4KCk5vIHBy YWN0aWNhbCBjaGFuZ2UuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4KClNp Z25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNp dHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hA c3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUv YXNtL3NwZWNfY3RybF9hc20uaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2Fz bS9zcGVjX2N0cmxfYXNtLmgKaW5kZXggMGZmMWIxMThmODgyLi4xNWUyNGNk ZTAwZDEgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9z cGVjX2N0cmxfYXNtLmgKKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNt L3NwZWNfY3RybF9hc20uaApAQCAtMjUxLDM0ICsyNTEsMzMgQEAKICAqLwog Lm1hY3JvIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFJfSVNUCiAvKgotICog UmVxdWlyZXMgJXJzcD1yZWdzLCAlcjE0PXN0YWNrX2VuZAotICogQ2xvYmJl cnMgJXJheCwgJXJjeCwgJXJkeAorICogUmVxdWlyZXMgJXJzcD1yZWdzLCAl cjE0PXN0YWNrX2VuZCwgJXJkeD0wCisgKiBDbG9iYmVycyAlcmF4LCAlcmJ4 LCAlcmN4LCAlcmR4CiAgKgogICogVGhpcyBpcyBsb2dpY2FsIG1lcmdlIG9m IERPX09WRVJXUklURV9SU0IgYW5kIERPX1NQRUNfQ1RSTF9FTlRSWQogICog bWF5YmV4ZW49MSwgYnV0IHdpdGggY29uZGl0aW9uYWxzIHJhdGhlciB0aGFu IGFsdGVybmF0aXZlcy4KICAqLwotICAgIG1vdnpibCBTVEFDS19DUFVJTkZP X0ZJRUxEKHNwZWNfY3RybF9mbGFncykoJXIxNCksICVlYXgKKyAgICBtb3Z6 YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRChzcGVjX2N0cmxfZmxhZ3MpKCVyMTQp LCAlZWJ4CiAKLSAgICB0ZXN0ICRTQ0ZfaXN0X3JzYiwgJWFsCisgICAgdGVz dCAkU0NGX2lzdF9yc2IsICVibAogICAgIGp6IC5MXEBfc2tpcF9yc2IKIAot ICAgIERPX09WRVJXUklURV9SU0IgdG1wPXJkeCAvKiBDbG9iYmVycyAlcmN4 LyVyZHggKi8KKyAgICBET19PVkVSV1JJVEVfUlNCICAgICAgICAgLyogQ2xv YmJlcnMgJXJheC8lcmN4ICovCiAKIC5MXEBfc2tpcF9yc2I6CiAKLSAgICB0 ZXN0ICRTQ0ZfaXN0X3NjX21zciwgJWFsCisgICAgdGVzdCAkU0NGX2lzdF9z Y19tc3IsICVibAogICAgIGp6IC5MXEBfc2tpcF9tc3Jfc3BlY19jdHJsCiAK LSAgICB4b3IgJWVkeCwgJWVkeAorICAgIHhvciAlZWF4LCAlZWF4CiAgICAg dGVzdGIgJDMsIFVSRUdTX2NzKCVyc3ApCi0gICAgc2V0bnogJWRsCi0gICAg bm90ICVlZHgKLSAgICBhbmQgJWRsLCBTVEFDS19DUFVJTkZPX0ZJRUxEKHNw ZWNfY3RybF9mbGFncykoJXIxNCkKKyAgICBzZXRueiAlYWwKKyAgICBub3Qg JWVheAorICAgIGFuZCAlYWwsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19j dHJsX2ZsYWdzKSglcjE0KQogCiAgICAgLyogTG9hZCBYZW4ncyBpbnRlbmRl ZCB2YWx1ZS4gKi8KICAgICBtb3YgJE1TUl9TUEVDX0NUUkwsICVlY3gKICAg ICBtb3Z6YmwgU1RBQ0tfQ1BVSU5GT19GSUVMRCh4ZW5fc3BlY19jdHJsKSgl cjE0KSwgJWVheAotICAgIHhvciAlZWR4LCAlZWR4CiAgICAgd3Jtc3IKIAog ICAgIC8qIE9wZW5jb2RlZCBVTkxJS0VMWV9TVEFSVCgpIHdpdGggbm8gY29u ZGl0aW9uLiAqLwpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L3g4Nl82NC9l bnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82NC9lbnRyeS5TCmluZGV4IGVh NmYwYWZiYzJiNC4uNWFkNWMzNjEyOGFhIDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYveDg2XzY0L2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9lbnRyeS5TCkBAIC05NjYsNyArOTY2LDcgQEAgRU5UUlkoZG91YmxlX2Zh dWx0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAKLSAgICAgICAg U1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJl Z3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8KKyAgICAgICAgU1BFQ19DVFJM X0VOVFJZX0ZST01fSU5UUl9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9 ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyYngKQEAgLTEwMDIsNyArMTAwMiw3 IEBAIGhhbmRsZV9pc3RfZXhjZXB0aW9uOgogCiAgICAgICAgIEdFVF9TVEFD S19FTkQoMTQpCiAKLSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5U Ul9JU1QgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2Qg Ki8KKyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QgLyog UmVxOiAlcnNwPXJlZ3MsICVyMTQ9ZW5kLCAlcmR4PTAsIENsb2I6IGFiY2Qg Ki8KICAgICAgICAgLyogV0FSTklORyEgYHJldGAsIGBjYWxsICpgLCBgam1w ICpgIG5vdCBzYWZlIGJlZm9yZSB0aGlzIHBvaW50LiAqLwogCiAgICAgICAg IG1vdiAgIFNUQUNLX0NQVUlORk9fRklFTEQoeGVuX2NyMykoJXIxNCksICVy Y3gK --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-5.patch" Content-Disposition: attachment; filename="xsa407/xsa407-5.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogU3VwcG9ydCBJQlBCLW9uLWVu dHJ5CgpXZSBhcmUgZ29pbmcgdG8gbmVlZCB0aGlzIHRvIG1pdGlnYXRlIEJy YW5jaCBUeXBlIENvbmZ1c2lvbiBvbiBBTUQvSHlnb24gQ1BVcywKYnV0IGFz IHdlJ3ZlIHRhbGtlZCBhYm91dCB1c2luZyBpdCBpbiBvdGhlciBjYXNlcyB0 b28sIGFycmFuZ2UgdG8gc3VwcG9ydCBpdApnZW5lcmFsbHkuICBIb3dldmVy LCB0aGlzIGlzIGFsc28gdmVyeSBleHBlbnNpdmUgaW4gc29tZSBjYXNlcywg c28gd2UncmUgZ29pbmcKdG8gd2FudCBwZXItZG9tYWluIGNvbnRyb2xzLgoK SW50cm9kdWNlIFNDRl9pc3RfaWJwYiBhbmQgU0NGX2VudHJ5X2licGIgY29u dHJvbHMsIGFkZGluZyB0aGVtIHRvIHRoZSBJU1QgYW5kCkRPTSBtYXNrcyBh cyBhcHByb3ByaWF0ZS4gIEFsc28gaW50cm9kdWNlIFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfe1BWLEhWTX0gdG8KdG8gcGF0Y2ggdGhlIGNvZGUgYmxvY2tz LgoKRm9yIFNWTSwgdGhlIFNUR0kgaXMgc2VyaWFsaXNpbmcgZW5vdWdoIHRv IHByb3RlY3QgYWdhaW5zdCBTcGVjdHJlLXYxIGF0dGFja3MsCnNvIG5vICJl bHNlIGxmZW5jZSIgaXMgbmVjZXNzYXJ5LiAgVlQteCB3aWxsIHVzZSB1c2Ug dGhlIE1TUiBob3N0IGxvYWQgbGlzdCwKc28gZG9lc24ndCBuZWVkIGFueSBj b2RlIGluIHRoZSBWTUV4aXQgcGF0aC4KCkZvciB0aGUgSVNUIHBhdGgsIHdl IGNhbid0IHNhZmVseSBjaGVjayBDUEw9PTAgdG8gc2tpcCBhIGZsdXNoLCBh cyB3ZSBtaWdodApoYXZlIGhpdCBhbiBlbnRyeSBwYXRoIGJlZm9yZSBpdCdz IElCUEIuICBBcyBJU1QgaGl0dGluZyBYZW4gaXMgcmFyZSwgZmx1c2gKaXJy ZXNwZWN0aXZlIG9mIENQTC4gIEEgbGF0ZXIgcGF0aCwgU0NGX2lzdF9zY19t c3IsIHByb3ZpZGVzIFNwZWN0cmUtdjEKc2FmZXR5LgoKRm9yIHRoZSBQViBw YXRocywgd2Uga25vdyB3ZSdyZSBpbnRlcnJ1cHRpbmcgQ1BMPjAsIHdoaWxl IGZvciB0aGUgSU5UUiBwYXRocywKd2UgY2FuIHNhZmVseSBjaGVjayBDUEw9 PTAuICBPbmx5IGZsdXNoIHdoZW4gaW50ZXJydXB0aW5nIGd1ZXN0IGNvbnRl eHQuCgpBbiAiZWxzZSBsZmVuY2UiIGlzIG5lZWRlZCBmb3Igc2FmZXR5LCBi dXQgd2Ugd2FudCB0byBiZSBhYmxlIHRvIHNraXAgaXQgb24KdW5hZmZlY3Rl ZCBDUFVzLCBzbyB0aGUgYmxvY2sgd2FudHMgdG8gYmUgYW4gYWx0ZXJuYXRp dmUsIHdoaWNoIG1lYW5zIHRoZQpsZmVuY2UgaGFzIHRvIGJlIGlubGluZSBy YXRoZXIgdGhhbiBVTkxJS0VMWSgpICh0aGUgcmVwbGFjZW1lbnQgYmxvY2sg ZG9lc24ndApoYXZlIGRpc3BsYWNlbWVudHMgZml4ZWQgdXAgZm9yIGFueXRo aW5nIG90aGVyIHRoYW4gdGhlIGZpcnN0IGluc3RydWN0aW9uKS4KCkFzIHdp dGggU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUl9JU1QsICVyZHggaXMgMCBv biBlbnRyeSBzbyByZWx5IG9uIHRoaXMgdG8Kc2hyaW5rIHRoZSBsb2dpYyBt YXJnaW5hbGx5LiAgVXBkYXRlIHRoZSBjb21tZW50cyB0byBzcGVjaWZ5IHRo aXMgbmV3CmRlcGVuZGVuY3kuCgpUaGlzIGlzIHBhcnQgb2YgWFNBLTQwNy4K ClNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+ClJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+CgpkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9z dm0vZW50cnkuUyBiL3hlbi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKaW5k ZXggNGFlNTVhMmVmNjA1Li4wZmY0MDA4MDYwZmEgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL3g4Ni9odm0vc3ZtL2VudHJ5LlMKKysrIGIveGVuL2FyY2gveDg2 L2h2bS9zdm0vZW50cnkuUwpAQCAtOTcsNyArOTcsMTkgQEAgX19VTkxJS0VM WV9FTkQobnN2bV9oYXApCiAKICAgICAgICAgR0VUX0NVUlJFTlQoYngpCiAK LSAgICAgICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTog JXJzcD1yZWdzL2NwdWluZm8gICAgICAgICBDbG9iOiBhY2QgKi8KKyAgICAg ICAgLyogU1BFQ19DVFJMX0VOVFJZX0ZST01fU1ZNICAgIFJlcTogJXJzcD1y ZWdzL2NwdWluZm8sICVyZHg9MCBDbG9iOiBhY2QgKi8KKworICAgICAgICAu bWFjcm8gc3ZtX3ZtZXhpdF9jb25kX2licGIKKyAgICAgICAgICAgIHRlc3Ri ICAkU0NGX2VudHJ5X2licGIsIENQVUlORk9feGVuX3NwZWNfY3RybCglcnNw KQorICAgICAgICAgICAganogICAgIC5MX3NraXBfaWJwYgorCisgICAgICAg ICAgICBtb3YgICAgJE1TUl9QUkVEX0NNRCwgJWVjeAorICAgICAgICAgICAg bW92ICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgICAgICAgICB3cm1z cgorLkxfc2tpcF9pYnBiOgorCS5lbmRtCisgICAgICAgIEFMVEVSTkFUSVZF ICIiLCBzdm1fdm1leGl0X2NvbmRfaWJwYiwgWDg2X0ZFQVRVUkVfSUJQQl9F TlRSWV9IVk0KKwogICAgICAgICBBTFRFUk5BVElWRSAiIiwgRE9fT1ZFUldS SVRFX1JTQiwgWDg2X0ZFQVRVUkVfU0NfUlNCX0hWTQogCiAgICAgICAgIC5t YWNybyBzdm1fdm1leGl0X3NwZWNfY3RybApAQCAtMTE0LDYgKzEyNiwxMCBA QCBfX1VOTElLRUxZX0VORChuc3ZtX2hhcCkKICAgICAgICAgQUxURVJOQVRJ VkUgIiIsIHN2bV92bWV4aXRfc3BlY19jdHJsLCBYODZfRkVBVFVSRV9TQ19N U1JfSFZNCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwg YGptcCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAorICAg ICAgICAvKgorICAgICAgICAgKiBTVEdJIGlzIGV4ZWN1dGVkIHVuY29uZGl0 aW9uYWxseSwgYW5kIGlzIHN1ZmZpY2llbnRseSBzZXJpYWxpc2luZworICAg ICAgICAgKiB0byBzYWZlbHkgcmVzb2x2ZSBhbnkgU3BlY3RyZS12MSBjb25j ZXJucyBpbiB0aGUgYWJvdmUgbG9naWMuCisgICAgICAgICAqLwogICAgICAg ICBzdGdpCiBHTE9CQUwoc3ZtX3N0Z2lfbGFiZWwpCiAgICAgICAgIG1vdiAg JXJzcCwlcmRpCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaHZtL3ZteC92 bWNzLmMgYi94ZW4vYXJjaC94ODYvaHZtL3ZteC92bWNzLmMKaW5kZXggNjgz YzY1MGQ3N2IxLi40ZjEyZmEwNmFjM2UgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNo L3g4Ni9odm0vdm14L3ZtY3MuYworKysgYi94ZW4vYXJjaC94ODYvaHZtL3Zt eC92bWNzLmMKQEAgLTEzMzUsNiArMTMzNSwxMCBAQCBzdGF0aWMgaW50IGNv bnN0cnVjdF92bWNzKHN0cnVjdCB2Y3B1ICp2KQogICAgICAgICByYyA9IHZt eF9hZGRfbXNyKHYsIE1TUl9GTFVTSF9DTUQsIEZMVVNIX0NNRF9MMUQsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgVk1YX01TUl9HVUVTVF9MT0FET05M WSk7CiAKKyAgICBpZiAoICFyYyAmJiAoZC0+YXJjaC5zcGVjX2N0cmxfZmxh Z3MgJiBTQ0ZfZW50cnlfaWJwYikgKQorICAgICAgICByYyA9IHZteF9hZGRf bXNyKHYsIE1TUl9QUkVEX0NNRCwgUFJFRF9DTURfSUJQQiwKKyAgICAgICAg ICAgICAgICAgICAgICAgICBWTVhfTVNSX0hPU1QpOworCiAgb3V0OgogICAg IHZteF92bWNzX2V4aXQodik7CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4 Ni9pbmNsdWRlL2FzbS9jcHVmZWF0dXJlcy5oIGIveGVuL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL2NwdWZlYXR1cmVzLmgKaW5kZXggNDkzZDMzOGEwODVlLi42 NzJjOWVlMjJiYTIgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRl L2FzbS9jcHVmZWF0dXJlcy5oCisrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRl L2FzbS9jcHVmZWF0dXJlcy5oCkBAIC0zOSw2ICszOSw4IEBAIFhFTl9DUFVG RUFUVVJFKFhFTl9MQlIsICAgICAgICAgICBYODZfU1lOVEgoMjIpKSAvKiBY ZW4gdXNlcyBNU1JfREVCVUdDVEwuTEJSICovCiBYRU5fQ1BVRkVBVFVSRShT Q19WRVJXX0lETEUsICAgICAgWDg2X1NZTlRIKDI1KSkgLyogVkVSVyB1c2Vk IGJ5IFhlbiBmb3IgaWRsZSAqLwogWEVOX0NQVUZFQVRVUkUoWEVOX1NIU1RL LCAgICAgICAgIFg4Nl9TWU5USCgyNikpIC8qIFhlbiB1c2VzIENFVCBTaGFk b3cgU3RhY2tzICovCiBYRU5fQ1BVRkVBVFVSRShYRU5fSUJULCAgICAgICAg ICAgWDg2X1NZTlRIKDI3KSkgLyogWGVuIHVzZXMgQ0VUIEluZGlyZWN0IEJy YW5jaCBUcmFja2luZyAqLworWEVOX0NQVUZFQVRVUkUoSUJQQl9FTlRSWV9Q ViwgICAgIFg4Nl9TWU5USCgyOCkpIC8qIE1TUl9QUkVEX0NNRCB1c2VkIGJ5 IFhlbiBmb3IgUFYgKi8KK1hFTl9DUFVGRUFUVVJFKElCUEJfRU5UUllfSFZN LCAgICBYODZfU1lOVEgoMjkpKSAvKiBNU1JfUFJFRF9DTUQgdXNlZCBieSBY ZW4gZm9yIEhWTSAqLwogCiAvKiBCdWcgd29yZHMgZm9sbG93IHRoZSBzeW50 aGV0aWMgd29yZHMuICovCiAjZGVmaW5lIFg4Nl9OUl9CVUcgMQpkaWZmIC0t Z2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oIGIv eGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCmluZGV4IGZi NDM2NTU3NTYyMC4uM2ZjNTk5YTgxN2M0IDEwMDY0NAotLS0gYS94ZW4vYXJj aC94ODYvaW5jbHVkZS9hc20vc3BlY19jdHJsLmgKKysrIGIveGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybC5oCkBAIC0zNCw2ICszNCw4IEBA CiAjZGVmaW5lIFNDRl9pc3Rfc2NfbXNyICgxIDw8IDEpCiAjZGVmaW5lIFND Rl9pc3RfcnNiICAgICgxIDw8IDIpCiAjZGVmaW5lIFNDRl92ZXJ3ICAgICAg ICgxIDw8IDMpCisjZGVmaW5lIFNDRl9pc3RfaWJwYiAgICgxIDw8IDQpCisj ZGVmaW5lIFNDRl9lbnRyeV9pYnBiICgxIDw8IDUpCiAKIC8qCiAgKiBUaGUg SVNUIHBhdGhzIChOTUkvI01DKSBjYW4gaW50ZXJydXB0IGFueSBhcmJpdHJh cnkgY29udGV4dC4gIFNvbWUKQEAgLTQ2LDEzICs0OCwxMyBAQAogICogVGhl c2UgYXJlIHRoZSBjb250cm9scyB0byBpbmhpYml0IG9uIHRoZSBTMyByZXN1 bWUgcGF0aCB1bnRpbCBtaWNyb2NvZGUgaGFzCiAgKiBiZWVuIHJlbG9hZGVk LgogICovCi0jZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NGX2lzdF9zY19tc3Ip CisjZGVmaW5lIFNDRl9JU1RfTUFTSyAoU0NGX2lzdF9zY19tc3IgfCBTQ0Zf aXN0X2licGIpCiAKIC8qCiAgKiBTb21lIHNwZWN1bGF0aXZlIHByb3RlY3Rp b25zIGFyZSBwZXItZG9tYWluLiAgVGhlc2Ugc2V0dGluZ3MgYXJlIG1lcmdl ZAogICogaW50byB0aGUgdG9wLW9mLXN0YWNrIGJsb2NrIGluIHRoZSBjb250 ZXh0IHN3aXRjaCBwYXRoLgogICovCi0jZGVmaW5lIFNDRl9ET01fTUFTSyAo U0NGX3ZlcncpCisjZGVmaW5lIFNDRl9ET01fTUFTSyAoU0NGX3ZlcncgfCBT Q0ZfZW50cnlfaWJwYikKIAogI2lmbmRlZiBfX0FTU0VNQkxZX18KIApkaWZm IC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybF9h c20uaCBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNt LmgKaW5kZXggMTVlMjRjZGUwMGQxLi45ZWI0YWQ5YWI3MWQgMTAwNjQ0Ci0t LSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9zcGVjX2N0cmxfYXNtLmgK KysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL3NwZWNfY3RybF9hc20u aApAQCAtODgsNiArODgsMzUgQEAKICAqICAtIFNQRUNfQ1RSTF9FWElUX1RP X3tTVk0sVk1YfQogICovCiAKKy5tYWNybyBET19TUEVDX0NUUkxfQ09ORF9J QlBCIG1heWJleGVuOnJlcQorLyoKKyAqIFJlcXVpcmVzICVyc3A9cmVncyAo YWxzbyBjcHVpbmZvIGlmICFtYXliZXhlbikKKyAqIFJlcXVpcmVzICVyMTQ9 c3RhY2tfZW5kIChpZiBtYXliZXhlbiksICVyZHg9MAorICogQ2xvYmJlcnMg JXJheCwgJXJjeCwgJXJkeAorICoKKyAqIENvbmRpdGlvbmFsbHkgaXNzdWUg SUJQQiBpZiBTQ0ZfZW50cnlfaWJwYiBpcyBhY3RpdmUuICBJbiB0aGUgbWF5 YmV4ZW4KKyAqIGNhc2UsIHdlIGNhbiBzYWZlbHkgbG9vayBhdCBVUkVHU19j cyB0byBza2lwIHRha2luZyB0aGUgaGl0IHdoZW4KKyAqIGludGVycnVwdGlu ZyBYZW4uCisgKi8KKyAgICAuaWYgXG1heWJleGVuCisgICAgICAgIHRlc3Ri ICAkU0NGX2VudHJ5X2licGIsIFNUQUNLX0NQVUlORk9fRklFTEQoc3BlY19j dHJsX2ZsYWdzKSglcjE0KQorICAgICAgICBqeiAgICAgLkxcQF9za2lwCisg ICAgICAgIHRlc3RiICAkMywgVVJFR1NfY3MoJXJzcCkKKyAgICAuZWxzZQor ICAgICAgICB0ZXN0YiAgJFNDRl9lbnRyeV9pYnBiLCBDUFVJTkZPX3hlbl9z cGVjX2N0cmwoJXJzcCkKKyAgICAuZW5kaWYKKyAgICBqeiAgICAgLkxcQF9z a2lwCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAgICBt b3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKyAgICBq bXAgICAgIC5MXEBfZG9uZQorCisuTFxAX3NraXA6CisgICAgbGZlbmNlCisu TFxAX2RvbmU6CisuZW5kbQorCiAubWFjcm8gRE9fT1ZFUldSSVRFX1JTQiB0 bXA9cmF4CiAvKgogICogUmVxdWlyZXMgbm90aGluZwpAQCAtMjI1LDEyICsy NTQsMTYgQEAKIAogLyogVXNlIGFmdGVyIGFuIGVudHJ5IGZyb20gUFYgY29u dGV4dCAoc3lzY2FsbC9zeXNlbnRlci9pbnQ4MC9pbnQ4Mi9ldGMpLiAqLwog I2RlZmluZSBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgXAorICAgIEFMVEVSTkFUSVZF ICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfQ09ORF9JQlBCIG1heWJl eGVuPTApLCAgICAgXAorICAgICAgICBYODZfRkVBVFVSRV9JQlBCX0VOVFJZ X1BWOyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXAog ICAgIEFMVEVSTkFUSVZFICIiLCBET19PVkVSV1JJVEVfUlNCLCBYODZfRkVB VFVSRV9TQ19SU0JfUFY7ICAgICAgICAgICAgXAogICAgIEFMVEVSTkFUSVZF ICIiLCBfX3N0cmluZ2lmeShET19TUEVDX0NUUkxfRU5UUlkgbWF5YmV4ZW49 MCksICAgICAgICAgXAogICAgICAgICBYODZfRkVBVFVSRV9TQ19NU1JfUFYK IAogLyogVXNlIGluIGludGVycnVwdC9leGNlcHRpb24gY29udGV4dC4gIE1h eSBpbnRlcnJ1cHQgWGVuIG9yIFBWIGNvbnRleHQuICovCiAjZGVmaW5lIFNQ RUNfQ1RSTF9FTlRSWV9GUk9NX0lOVFIgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBcCisgICAgQUxURVJOQVRJVkUgIiIsIF9fc3Ry aW5naWZ5KERPX1NQRUNfQ1RSTF9DT05EX0lCUEIgbWF5YmV4ZW49MSksICAg ICBcCisgICAgICAgIFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfUFY7ICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcCiAgICAgQUxURVJO QVRJVkUgIiIsIERPX09WRVJXUklURV9SU0IsIFg4Nl9GRUFUVVJFX1NDX1JT Ql9QVjsgICAgICAgICAgICBcCiAgICAgQUxURVJOQVRJVkUgIiIsIF9fc3Ry aW5naWZ5KERPX1NQRUNfQ1RSTF9FTlRSWSBtYXliZXhlbj0xKSwgICAgICAg ICBcCiAgICAgICAgIFg4Nl9GRUFUVVJFX1NDX01TUl9QVgpAQCAtMjU0LDEx ICsyODcsMjMgQEAKICAqIFJlcXVpcmVzICVyc3A9cmVncywgJXIxND1zdGFj a19lbmQsICVyZHg9MAogICogQ2xvYmJlcnMgJXJheCwgJXJieCwgJXJjeCwg JXJkeAogICoKLSAqIFRoaXMgaXMgbG9naWNhbCBtZXJnZSBvZiBET19PVkVS V1JJVEVfUlNCIGFuZCBET19TUEVDX0NUUkxfRU5UUlkKLSAqIG1heWJleGVu PTEsIGJ1dCB3aXRoIGNvbmRpdGlvbmFscyByYXRoZXIgdGhhbiBhbHRlcm5h dGl2ZXMuCisgKiBUaGlzIGlzIGxvZ2ljYWwgbWVyZ2Ugb2Y6CisgKiAgICBE T19TUEVDX0NUUkxfQ09ORF9JQlBCIG1heWJleGVuPTAKKyAqICAgIERPX09W RVJXUklURV9SU0IKKyAqICAgIERPX1NQRUNfQ1RSTF9FTlRSWSBtYXliZXhl bj0xCisgKiBidXQgd2l0aCBjb25kaXRpb25hbHMgcmF0aGVyIHRoYW4gYWx0 ZXJuYXRpdmVzLgogICovCiAgICAgbW92emJsIFNUQUNLX0NQVUlORk9fRklF TEQoc3BlY19jdHJsX2ZsYWdzKSglcjE0KSwgJWVieAogCisgICAgdGVzdCAg ICAkU0NGX2lzdF9pYnBiLCAlYmwKKyAgICBqeiAgICAgIC5MXEBfc2tpcF9p YnBiCisKKyAgICBtb3YgICAgICRNU1JfUFJFRF9DTUQsICVlY3gKKyAgICBt b3YgICAgICRQUkVEX0NNRF9JQlBCLCAlZWF4CisgICAgd3Jtc3IKKworLkxc QF9za2lwX2licGI6CisKICAgICB0ZXN0ICRTQ0ZfaXN0X3JzYiwgJWJsCiAg ICAganogLkxcQF9za2lwX3JzYgogCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94 ODYveDg2XzY0L2NvbXBhdC9lbnRyeS5TIGIveGVuL2FyY2gveDg2L3g4Nl82 NC9jb21wYXQvZW50cnkuUwppbmRleCA1ZmQ2ZGJiZDQ1MTMuLmI4NmQzOGQx YzUwZCAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3g4Nl82NC9jb21wYXQv ZW50cnkuUworKysgYi94ZW4vYXJjaC94ODYveDg2XzY0L2NvbXBhdC9lbnRy eS5TCkBAIC0xOCw3ICsxOCw3IEBAIEVOVFJZKGVudHJ5X2ludDgyKQogICAg ICAgICBtb3ZsICAkSFlQRVJDQUxMX1ZFQ1RPUiwgNCglcnNwKQogICAgICAg ICBTQVZFX0FMTCBjb21wYXQ9MSAvKiBEUEwxIGdhdGUsIHJlc3RyaWN0ZWQg dG8gMzJiaXQgUFYgZ3Vlc3RzIG9ubHkuICovCiAKLSAgICAgICAgU1BFQ19D VFJMX0VOVFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywg Q2xvYjogYWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BW IC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNk ICovCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGpt cCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAg ICBDUjRfUFYzMl9SRVNUT1JFCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv eDg2XzY0L2VudHJ5LlMgYi94ZW4vYXJjaC94ODYveDg2XzY0L2VudHJ5LlMK aW5kZXggNWFkNWMzNjEyOGFhLi4yNmJmMmYxOTQxZjggMTAwNjQ0Ci0tLSBh L3hlbi9hcmNoL3g4Ni94ODZfNjQvZW50cnkuUworKysgYi94ZW4vYXJjaC94 ODYveDg2XzY0L2VudHJ5LlMKQEAgLTI2MCw3ICsyNjAsNyBAQCBFTlRSWShs c3Rhcl9lbnRlcikKICAgICAgICAgbW92bCAgJFRSQVBfc3lzY2FsbCwgNCgl cnNwKQogICAgICAgICBTQVZFX0FMTAogCi0gICAgICAgIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6 IGFjZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBS ZXE6ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwog ICAgICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAg bm90IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgR0VU X1NUQUNLX0VORChieCkKQEAgLTI5OCw3ICsyOTgsNyBAQCBFTlRSWShjc3Rh cl9lbnRlcikKICAgICAgICAgbW92bCAgJFRSQVBfc3lzY2FsbCwgNCglcnNw KQogICAgICAgICBTQVZFX0FMTAogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRS WV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6IGFj ZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBSZXE6 ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwogICAg ICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAgbm90 IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgR0VUX1NU QUNLX0VORChieCkKQEAgLTMzOCw3ICszMzgsNyBAQCBHTE9CQUwoc3lzZW50 ZXJfZWZsYWdzX3NhdmVkKQogICAgICAgICBtb3ZsICAkVFJBUF9zeXNjYWxs LCA0KCVyc3ApCiAgICAgICAgIFNBVkVfQUxMCiAKLSAgICAgICAgU1BFQ19D VFJMX0VOVFJZX0ZST01fUFYgLyogUmVxOiAlcnNwPXJlZ3MvY3B1aW5mbywg Q2xvYjogYWNkICovCisgICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX1BW IC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sICVyZHg9MCwgQ2xvYjogYWNk ICovCiAgICAgICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGpt cCAqYCBub3Qgc2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAg ICBHRVRfU1RBQ0tfRU5EKGJ4KQpAQCAtMzkyLDcgKzM5Miw3IEBAIEVOVFJZ KGludDgwX2RpcmVjdF90cmFwKQogICAgICAgICBtb3ZsICAkMHg4MCwgNCgl cnNwKQogICAgICAgICBTQVZFX0FMTAogCi0gICAgICAgIFNQRUNfQ1RSTF9F TlRSWV9GUk9NX1BWIC8qIFJlcTogJXJzcD1yZWdzL2NwdWluZm8sIENsb2I6 IGFjZCAqLworICAgICAgICBTUEVDX0NUUkxfRU5UUllfRlJPTV9QViAvKiBS ZXE6ICVyc3A9cmVncy9jcHVpbmZvLCAlcmR4PTAsIENsb2I6IGFjZCAqLwog ICAgICAgICAvKiBXQVJOSU5HISBgcmV0YCwgYGNhbGwgKmAsIGBqbXAgKmAg bm90IHNhZmUgYmVmb3JlIHRoaXMgcG9pbnQuICovCiAKICAgICAgICAgR0VU X1NUQUNLX0VORChieCkKQEAgLTY3NCw3ICs2NzQsNyBAQCBFTlRSWShjb21t b25faW50ZXJydXB0KQogCiAgICAgICAgIEdFVF9TVEFDS19FTkQoMTQpCiAK LSAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUiAvKiBSZXE6ICVy c3A9cmVncywgJXIxND1lbmQsIENsb2I6IGFjZCAqLworICAgICAgICBTUEVD X0NUUkxfRU5UUllfRlJPTV9JTlRSIC8qIFJlcTogJXJzcD1yZWdzLCAlcjE0 PWVuZCwgJXJkeD0wLCBDbG9iOiBhY2QgKi8KICAgICAgICAgLyogV0FSTklO RyEgYHJldGAsIGBjYWxsICpgLCBgam1wICpgIG5vdCBzYWZlIGJlZm9yZSB0 aGlzIHBvaW50LiAqLwogCiAgICAgICAgIG1vdiAgIFNUQUNLX0NQVUlORk9f RklFTEQoeGVuX2NyMykoJXIxNCksICVyY3gKQEAgLTcwOCw3ICs3MDgsNyBA QCBHTE9CQUwoaGFuZGxlX2V4Y2VwdGlvbikKIAogICAgICAgICBHRVRfU1RB Q0tfRU5EKDE0KQogCi0gICAgICAgIFNQRUNfQ1RSTF9FTlRSWV9GUk9NX0lO VFIgLyogUmVxOiAlcnNwPXJlZ3MsICVyMTQ9ZW5kLCBDbG9iOiBhY2QgKi8K KyAgICAgICAgU1BFQ19DVFJMX0VOVFJZX0ZST01fSU5UUiAvKiBSZXE6ICVy c3A9cmVncywgJXIxND1lbmQsICVyZHg9MCwgQ2xvYjogYWNkICovCiAgICAg ICAgIC8qIFdBUk5JTkchIGByZXRgLCBgY2FsbCAqYCwgYGptcCAqYCBub3Qg c2FmZSBiZWZvcmUgdGhpcyBwb2ludC4gKi8KIAogICAgICAgICBtb3YgICBT VEFDS19DUFVJTkZPX0ZJRUxEKHhlbl9jcjMpKCVyMTQpLCAlcmN4Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-6.patch" Content-Disposition: attachment; filename="xsa407/xsa407-6.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L2NwdWlkOiBFbnVtZXJhdGlvbiBmb3IgQlRDX05P CgpCVENfTk8gaW5kaWNhdGVzIHRoYXQgaGFyZHdhcmUgaXMgbm90IHN1Y2Nl cHRhYmxlIHRvIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4KClplbjMgQ1BVcyBk b24ndCBzdWZmZXIgQlRDLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcuCgpT aWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0Bj aXRyaXguY29tPgpSZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPgoKZGlmZiAtLWdpdCBhL3Rvb2xzL2xpYnMvbGlnaHQvbGli eGxfY3B1aWQuYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfY3B1aWQuYwpp bmRleCA2N2JhNzJkZDg0NzUuLmY0NzM1YjFjMTNhYiAxMDA2NDQKLS0tIGEv dG9vbHMvbGlicy9saWdodC9saWJ4bF9jcHVpZC5jCisrKyBiL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfY3B1aWQuYwpAQCAtMjg5LDYgKzI4OSw3IEBAIGlu dCBsaWJ4bF9jcHVpZF9wYXJzZV9jb25maWcobGlieGxfY3B1aWRfcG9saWN5 X2xpc3QgKmNwdWlkLCBjb25zdCBjaGFyKiBzdHIpCiAgICAgICAgIHsidmly dC1zc2JkIiwgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI1 LCAgMX0sCiAgICAgICAgIHsic3NiLW5vIiwgICAgICAgMHg4MDAwMDAwOCwg TkEsIENQVUlEX1JFR19FQlgsIDI2LCAgMX0sCiAgICAgICAgIHsicHNmZCIs ICAgICAgICAgMHg4MDAwMDAwOCwgTkEsIENQVUlEX1JFR19FQlgsIDI4LCAg MX0sCisgICAgICAgIHsiYnRjLW5vIiwgICAgICAgMHg4MDAwMDAwOCwgTkEs IENQVUlEX1JFR19FQlgsIDI5LCAgMX0sCiAKICAgICAgICAgeyJuYyIsICAg ICAgICAgICAweDgwMDAwMDA4LCBOQSwgQ1BVSURfUkVHX0VDWCwgIDAsICA4 fSwKICAgICAgICAgeyJhcGljaWRzaXplIiwgICAweDgwMDAwMDA4LCBOQSwg Q1BVSURfUkVHX0VDWCwgMTIsICA0fSwKZGlmZiAtLWdpdCBhL3Rvb2xzL21p c2MveGVuLWNwdWlkLmMgYi90b29scy9taXNjL3hlbi1jcHVpZC5jCmluZGV4 IGE5ZTBmYjVkMTdlNS4uMWU2YjA3N2JhNGRhIDEwMDY0NAotLS0gYS90b29s cy9taXNjL3hlbi1jcHVpZC5jCisrKyBiL3Rvb2xzL21pc2MveGVuLWNwdWlk LmMKQEAgLTE2MCw3ICsxNjAsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqY29u c3Qgc3RyX2U4YlszMl0gPQogICAgIC8qIFsyMl0gKi8gICAgICAgICAgICAg ICAgIFsyM10gPSAicHBpbiIsCiAgICAgWzI0XSA9ICJhbWQtc3NiZCIsICAg ICAgICAgWzI1XSA9ICJ2aXJ0LXNzYmQiLAogICAgIFsyNl0gPSAic3NiLW5v IiwKLSAgICBbMjhdID0gInBzZmQiLAorICAgIFsyOF0gPSAicHNmZCIsICAg ICAgICAgICAgIFsyOV0gPSAiYnRjLW5vIiwKIH07CiAKIHN0YXRpYyBjb25z dCBjaGFyICpjb25zdCBzdHJfN2QwWzMyXSA9CmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvY3B1L2FtZC5jIGIveGVuL2FyY2gveDg2L2NwdS9hbWQuYwpp bmRleCBmMWQxMWExY2I3MzQuLjYxOGM3ZDViMmE0NiAxMDA2NDQKLS0tIGEv eGVuL2FyY2gveDg2L2NwdS9hbWQuYworKysgYi94ZW4vYXJjaC94ODYvY3B1 L2FtZC5jCkBAIC04NDcsNiArODQ3LDE2IEBAIHN0YXRpYyB2b2lkIGNmX2No ZWNrIGluaXRfYW1kKHN0cnVjdCBjcHVpbmZvX3g4NiAqYykKIAkJCXdhcm5p bmdfYWRkKHRleHQpOwogCQl9CiAJCWJyZWFrOworCisJY2FzZSAweDE5Ogor CQkvKgorCQkgKiBaZW4zIChGYW0xOWggbW9kZWwgPCAweDEwKSBwYXJ0cyBh cmUgbm90IHN1c2NlcHRpYmxlIHRvCisJCSAqIEJyYW5jaCBUeXBlIENvbmZ1 c2lvbiwgYnV0IHByZWRhdGUgdGhlIGFsbG9jYXRpb24gb2YgdGhlCisJCSAq IEJUQ19OTyBiaXQuICBGaWxsIGl0IGJhY2sgaW4gaWYgd2UncmUgbm90IHZp cnR1YWxpc2VkLgorCQkgKi8KKwkJaWYgKCFjcHVfaGFzX2h5cGVydmlzb3Ig JiYgIWNwdV9oYXMoYywgWDg2X0ZFQVRVUkVfQlRDX05PKSkKKwkJCV9fc2V0 X2JpdChYODZfRkVBVFVSRV9CVENfTk8sIGMtPng4Nl9jYXBhYmlsaXR5KTsK KwkJYnJlYWs7CiAJfQogCiAJZGlzcGxheV9jYWNoZWluZm8oYyk7CmRpZmYg LS1naXQgYS94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMgYi94ZW4vYXJjaC94 ODYvc3BlY19jdHJsLmMKaW5kZXggZWRlMGEyN2MwZmVhLi5lNWVhMmM1YzZj OTMgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYworKysg Yi94ZW4vYXJjaC94ODYvc3BlY19jdHJsLmMKQEAgLTM4OCw3ICszODgsNyBA QCBzdGF0aWMgdm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90 aHVuayB0aHVuaywgdWludDY0X3QgY2FwcykKICAgICAgKiBIYXJkd2FyZSBy ZWFkLW9ubHkgaW5mb3JtYXRpb24sIHN0YXRpbmcgaW1tdW5pdHkgdG8gY2Vy dGFpbiBpc3N1ZXMsIG9yCiAgICAgICogc3VnZ2VzdGlvbnMgb2Ygd2hpY2gg bWl0aWdhdGlvbiB0byB1c2UuCiAgICAgICovCi0gICAgcHJpbnRrKCIgIEhh cmR3YXJlIGhpbnRzOiVzJXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzJXNcbiIs CisgICAgcHJpbnRrKCIgIEhhcmR3YXJlIGhpbnRzOiVzJXMlcyVzJXMlcyVz JXMlcyVzJXMlcyVzJXMlc1xuIiwKICAgICAgICAgICAgKGNhcHMgJiBBUkNI X0NBUFNfUkRDTF9OTykgICAgICAgICAgICAgICAgICAgICAgICA/ICIgUkRD TF9OTyIgICAgICAgIDogIiIsCiAgICAgICAgICAgIChjYXBzICYgQVJDSF9D QVBTX0lCUlNfQUxMKSAgICAgICAgICAgICAgICAgICAgICAgPyAiIElCUlNf QUxMIiAgICAgICA6ICIiLAogICAgICAgICAgICAoY2FwcyAmIEFSQ0hfQ0FQ U19SU0JBKSAgICAgICAgICAgICAgICAgICAgICAgICAgID8gIiBSU0JBIiAg ICAgICAgICAgOiAiIiwKQEAgLTQwMyw3ICs0MDMsOCBAQCBzdGF0aWMgdm9p ZCBfX2luaXQgcHJpbnRfZGV0YWlscyhlbnVtIGluZF90aHVuayB0aHVuaywg dWludDY0X3QgY2FwcykKICAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21h c2soWDg2X0ZFQVRVUkVfSUJSU19BTFdBWVMpKSAgICA/ICIgSUJSU19BTFdB WVMiICAgIDogIiIsCiAgICAgICAgICAgIChlOGIgICYgY3B1ZmVhdF9tYXNr KFg4Nl9GRUFUVVJFX1NUSUJQX0FMV0FZUykpICAgPyAiIFNUSUJQX0FMV0FZ UyIgICA6ICIiLAogICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhY ODZfRkVBVFVSRV9JQlJTX0ZBU1QpKSAgICAgID8gIiBJQlJTX0ZBU1QiICAg ICAgOiAiIiwKLSAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2 X0ZFQVRVUkVfSUJSU19TQU1FX01PREUpKSA/ICIgSUJSU19TQU1FX01PREUi IDogIiIpOworICAgICAgICAgICAoZThiICAmIGNwdWZlYXRfbWFzayhYODZf RkVBVFVSRV9JQlJTX1NBTUVfTU9ERSkpID8gIiBJQlJTX1NBTUVfTU9ERSIg OiAiIiwKKyAgICAgICAgICAgKGU4YiAgJiBjcHVmZWF0X21hc2soWDg2X0ZF QVRVUkVfQlRDX05PKSkgICAgICAgICA/ICIgQlRDX05PIiAgICAgICAgIDog IiIpOwogCiAgICAgLyogSGFyZHdhcmUgZmVhdHVyZXMgd2hpY2ggbmVlZCBk cml2aW5nIHRvIG1pdGlnYXRlIGlzc3Vlcy4gKi8KICAgICBwcmludGsoIiAg SGFyZHdhcmUgZmVhdHVyZXM6JXMlcyVzJXMlcyVzJXMlcyVzJXMlcyVzXG4i LApkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUvcHVibGljL2FyY2gteDg2L2Nw dWZlYXR1cmVzZXQuaCBiL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKaW5kZXggMTAxNjk4OTQxMDc0Li5jOWM0NjgzNTU3 ZmYgMTAwNjQ0Ci0tLSBhL3hlbi9pbmNsdWRlL3B1YmxpYy9hcmNoLXg4Ni9j cHVmZWF0dXJlc2V0LmgKKysrIGIveGVuL2luY2x1ZGUvcHVibGljL2FyY2gt eDg2L2NwdWZlYXR1cmVzZXQuaApAQCAtMjY4LDYgKzI2OCw3IEBAIFhFTl9D UFVGRUFUVVJFKEFNRF9TU0JELCAgICAgIDgqMzIrMjQpIC8qUyAgTVNSX1NQ RUNfQ1RSTC5TU0JEIGF2YWlsYWJsZSAqLwogWEVOX0NQVUZFQVRVUkUoVklS VF9TU0JELCAgICAgOCozMisyNSkgLyogICBNU1JfVklSVF9TUEVDX0NUUkwu U1NCRCAqLwogWEVOX0NQVUZFQVRVUkUoU1NCX05PLCAgICAgICAgOCozMisy NikgLypBICBIYXJkd2FyZSBub3QgdnVsbmVyYWJsZSB0byBTU0IgKi8KIFhF Tl9DUFVGRUFUVVJFKFBTRkQsICAgICAgICAgIDgqMzIrMjgpIC8qUyAgTVNS X1NQRUNfQ1RSTC5QU0ZEICovCitYRU5fQ1BVRkVBVFVSRShCVENfTk8sICAg ICAgICA4KjMyKzI5KSAvKkEgIEhhcmR3YXJlIG5vdCB2dWxuZXJhYmxlIHRv IEJyYW5jaCBUeXBlIENvbmZ1c2lvbiAqLwogCiAvKiBJbnRlbC1kZWZpbmVk IENQVSBmZWF0dXJlcywgQ1BVSUQgbGV2ZWwgMHgwMDAwMDAwNzowLmVkeCwg d29yZCA5ICovCiBYRU5fQ1BVRkVBVFVSRShBVlg1MTJfNFZOTklXLCA5KjMy KyAyKSAvKkEgIEFWWDUxMiBOZXVyYWwgTmV0d29yayBJbnN0cnVjdGlvbnMg Ki8K --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-7.patch" Content-Disposition: attachment; filename="xsa407/xsa407-7.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogRW5hYmxlIFplbjIgY2hpY2tl bmJpdAoKLi4uIGFzIGluc3RydWN0ZWQgaW4gdGhlIEJyYW5jaCBUeXBlIENv bmZ1c2lvbiB3aGl0ZXBhcGVyLgoKVGhpcyBpcyBwYXJ0IG9mIFhTQS00MDcu CgpTaWduZWQtb2ZmLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPgoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9jcHUv YW1kLmMgYi94ZW4vYXJjaC94ODYvY3B1L2FtZC5jCmluZGV4IDYxOGM3ZDVi MmE0Ni4uMjljNTliY2JhNDA5IDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYv Y3B1L2FtZC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvYW1kLmMKQEAgLTcz MSw2ICs3MzEsMzEgQEAgdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYykKIAkJcHJpbnRrX29uY2UoWEVOTE9HX0VSUiAi Tm8gU1NCRCBjb250cm9scyBhdmFpbGFibGVcbiIpOwogfQogCisvKgorICog T24gWmVuMiB3ZSBvZmZlciB0aGlzIGNoaWNrZW4gKGJpdCkgb24gdGhlIGFs dGFyIG9mIFNwZWN1bGF0aW9uLgorICoKKyAqIFJlZmVyIHRvIHRoZSBBTUQg QnJhbmNoIFR5cGUgQ29uZnVzaW9uIHdoaXRlcGFwZXI6CisgKiBodHRwczov L1hYWAorICoKKyAqIFNldHRpbmcgdGhpcyB1bm5hbWVkIGJpdCBzdXBwb3Nl ZGx5IGNhdXNlcyBwcmVkaWN0aW9uIGluZm9ybWF0aW9uIG9uCisgKiBub24t YnJhbmNoIGluc3RydWN0aW9ucyB0byBiZSBpZ25vcmVkLiAgSXQgaXMgdG8g YmUgc2V0IHVuaWxhdGVyYWxseSBpbgorICogbmV3ZXIgbWljcm9jb2RlLgor ICoKKyAqIFRoaXMgY2hpY2tlbmJpdCBpcyBzb21ldGhpbmcgdW5yZWxhdGVk IG9uIFplbjEsIGFuZCBaZW4xIHZzIFplbjIgaXNuJ3QgYQorICogc2ltcGxl IG1vZGVsIG51bWJlciBjb21wYXJpc29uLCBzbyB1c2UgU1RJQlAgYXMgYSBo ZXVyaXN0aWMgdG8gc2VwYXJhdGUgdGhlCisgKiB0d28gdWFyY2hlcyBpbiBG YW0xN2goQU1EKS8xOGgoSHlnb24pLgorICovCit2b2lkIGFtZF9pbml0X3Nw ZWN0cmFsX2NoaWNrZW4odm9pZCkKK3sKKwl1aW50NjRfdCB2YWwsIGNoaWNr ZW5iaXQgPSAxIDw8IDE7CisKKwlpZiAoY3B1X2hhc19oeXBlcnZpc29yIHx8 ICFib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQU1EX1NUSUJQKSkKKwkJcmV0 dXJuOworCisJaWYgKHJkbXNyX3NhZmUoTVNSX0FNRDY0X0RFX0NGRzIsIHZh bCkgPT0gMCAmJiAhKHZhbCAmIGNoaWNrZW5iaXQpKQorCQl3cm1zcl9zYWZl KE1TUl9BTUQ2NF9ERV9DRkcyLCB2YWwgfCBjaGlja2VuYml0KTsKK30KKwog dm9pZCBfX2luaXQgZGV0ZWN0X3plbjJfbnVsbF9zZWdfYmVoYXZpb3VyKHZv aWQpCiB7CiAJdWludDY0X3QgYmFzZTsKQEAgLTc5Niw2ICs4MjEsOSBAQCBz dGF0aWMgdm9pZCBjZl9jaGVjayBpbml0X2FtZChzdHJ1Y3QgY3B1aW5mb194 ODYgKmMpCiAKIAlhbWRfaW5pdF9zc2JkKGMpOwogCisJaWYgKGMtPng4NiA9 PSAweDE3KQorCQlhbWRfaW5pdF9zcGVjdHJhbF9jaGlja2VuKCk7CisKIAkv KiBQcm9iZSBmb3IgTlNDQiBvbiBaZW4yIENQVXMgd2hlbiBub3QgdmlydHVh bGlzZWQgKi8KIAlpZiAoIWNwdV9oYXNfaHlwZXJ2aXNvciAmJiAhY3B1X2hh c19uc2NiICYmIGMgPT0gJmJvb3RfY3B1X2RhdGEgJiYKIAkgICAgYy0+eDg2 ID09IDB4MTcpCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvY3B1L2NwdS5o IGIveGVuL2FyY2gveDg2L2NwdS9jcHUuaAppbmRleCBhMjI4MDg3ZjkxNTcu Ljg1YTY3NzcxZjdiNyAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L2NwdS9j cHUuaAorKysgYi94ZW4vYXJjaC94ODYvY3B1L2NwdS5oCkBAIC0yMiw0ICsy Miw1IEBAIHZvaWQgY2ZfY2hlY2sgZWFybHlfaW5pdF9hbWQoc3RydWN0IGNw dWluZm9feDg2ICpjKTsKIHZvaWQgYW1kX2xvZ19mcmVxKGNvbnN0IHN0cnVj dCBjcHVpbmZvX3g4NiAqYyk7CiB2b2lkIGFtZF9pbml0X2xmZW5jZShzdHJ1 Y3QgY3B1aW5mb194ODYgKmMpOwogdm9pZCBhbWRfaW5pdF9zc2JkKGNvbnN0 IHN0cnVjdCBjcHVpbmZvX3g4NiAqYyk7Cit2b2lkIGFtZF9pbml0X3NwZWN0 cmFsX2NoaWNrZW4odm9pZCk7CiB2b2lkIGRldGVjdF96ZW4yX251bGxfc2Vn X2JlaGF2aW91cih2b2lkKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9j cHUvaHlnb24uYyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHlnb24uYwppbmRleCAz Yzg1MTZlMDE0YzMuLjM2MWViNmZkNDExYiAxMDA2NDQKLS0tIGEveGVuL2Fy Y2gveDg2L2NwdS9oeWdvbi5jCisrKyBiL3hlbi9hcmNoL3g4Ni9jcHUvaHln b24uYwpAQCAtNDEsNiArNDEsMTIgQEAgc3RhdGljIHZvaWQgY2ZfY2hlY2sg aW5pdF9oeWdvbihzdHJ1Y3QgY3B1aW5mb194ODYgKmMpCiAJCWRldGVjdF96 ZW4yX251bGxfc2VnX2JlaGF2aW91cigpOwogCiAJLyoKKwkgKiBUT0RPOiBD aGVjayBoZXVyaXN0aWMgc2FmZXR5IHdpdGggSHlnb24gZmlyc3QKKwlpZiAo Yy0+eDg2ID09IDB4MTgpCisJCWFtZF9pbml0X3NwZWN0cmFsX2NoaWNrZW4o KTsKKwkgKi8KKworCS8qCiAJICogSHlnb24gQ1BVcyBiZWZvcmUgWmVuMiBk b24ndCBjbGVhciBzZWdtZW50IGJhc2VzL2xpbWl0cyB3aGVuCiAJICogbG9h ZGluZyBhIE5VTEwgc2VsZWN0b3IuCiAJICovCmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYvaW5jbHVkZS9hc20vbXNyLWluZGV4LmggYi94ZW4vYXJjaC94 ODYvaW5jbHVkZS9hc20vbXNyLWluZGV4LmgKaW5kZXggYmNiNDI0YTMyMDI2 Li44Y2FiODczNmQ4YTUgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNs dWRlL2FzbS9tc3ItaW5kZXguaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVk ZS9hc20vbXNyLWluZGV4LmgKQEAgLTM3Nyw2ICszNzcsNyBAQAogI2RlZmlu ZSBNU1JfQU1ENjRfREVfQ0ZHCQkweGMwMDExMDI5CiAjZGVmaW5lIEFNRDY0 X0RFX0NGR19MRkVOQ0VfU0VSSUFMSVNFCShfQUMoMSwgVUxMKSA8PCAxKQog I2RlZmluZSBNU1JfQU1ENjRfRVhfQ0ZHCQkweGMwMDExMDJjCisjZGVmaW5l IE1TUl9BTUQ2NF9ERV9DRkcyCQkweGMwMDExMGUzCiAKICNkZWZpbmUgTVNS X0FNRDY0X0RSMF9BRERSRVNTX01BU0sJMHhjMDAxMTAyNwogI2RlZmluZSBN U1JfQU1ENjRfRFIxX0FERFJFU1NfTUFTSwkweGMwMDExMDE5Cg== --=separator Content-Type: application/octet-stream; name="xsa407/xsa407-8.patch" Content-Disposition: attachment; filename="xsa407/xsa407-8.patch" Content-Transfer-Encoding: base64 RnJvbTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4KU3ViamVjdDogeDg2L3NwZWMtY3RybDogTWl0aWdhdGUgQnJhbmNoIFR5 cGUgQ29uZnVzaW9uIHdoZW4gcG9zc2libGUKCkJyYW5jaCBUeXBlIENvbmZ1 c2lvbiBhZmZlY3RzIEFNRC9IeWdvbiBDUFVzIG9uIFplbjIgYW5kIGVhcmxp ZXIuICBUbwptaXRpZ2F0ZSwgd2UgcmVxdWlyZSBTTVQgc2FmZXR5IChTVElC UCBvbiBaZW4yLCBuby1TTVQgb24gWmVuMSksIGFuZCB0byBpc3N1ZQphbiBJ QlBCIG9uIGVhY2ggZW50cnkgdG8gWGVuLCB0byBmbHVzaCB0aGUgQlRCLgoK RHVlIHRvIHBlcmZvcm1hbmNlIGNvbmNlcm5zLCBkb20wICh3aGljaCBpcyB0 cnVzdGVkIGluIG1vc3QgY29uZmlndXJhdGlvbnMpIGlzCmV4Y2x1ZGVkIGZy b20gcHJvdGVjdGlvbnMgYnkgZGVmYXVsdC4KClRoZXJlZm9yZToKICogVXNl IFNUSUJQIGJ5IGRlZmF1bHQgb24gWmVuMiB0b28sIHdoaWNoIG5vdyBtZWFu cyB3ZSB3YW50IGl0IG9uIGJ5IGRlZmF1bHQKICAgb24gYWxsIGhhcmR3YXJl IHN1cHBvcnRpbmcgU1RJQlAuCiAqIEJyZWFrIHRoZSBjdXJyZW50IElCUEIg bG9naWMgb3V0IGludG8gYSBuZXcgZnVuY3Rpb24sIGV4dGVuZGluZyBpdCB3 aXRoCiAgIElCUEItYXQtZW50cnkgbG9naWMuCiAqIENoYW5nZSB0aGUgZXhp c3RpbmcgSUJQQi1hdC1jdHh0LXN3aXRjaCBib29sZWFuIHRvIGJlIHRyaXN0 YXRlLCBhbmQgZGlzYWJsZQogICBpdCBieSBkZWZhdWx0IHdoZW4gSUJQQi1h dC1lbnRyeSBpcyBwcm92aWRpbmcgc3VmZmljaWVudCBzYWZldHkuCgpJZiBh bGwgUFYgZ3Vlc3RzIG9uIHRoZSBzeXN0ZW0gYXJlIHRydXN0ZWQsIHRoZW4g aXQgaXMgcmVjb21tZW5kZWQgdG8gYm9vdAp3aXRoIGBzcGVjLWN0cmw9aWJw Yi1lbnRyeT1uby1wdmAsIGFzIHRoaXMgd2lsbCBwcm92aWRlIGFuIGFkZGl0 aW9uYWwgbWFyZ2luYWwKcGVyZiBpbXByb3ZlbWVudC4KClRoaXMgaXMgcGFy dCBvZiBYU0EtNDA3IC8gQ1ZFLTIwMjItMjM4MjUuCgpTaWduZWQtb2ZmLWJ5 OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgpS ZXZpZXdlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgoK ZGlmZiAtLWdpdCBhL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRv YyBiL2RvY3MvbWlzYy94ZW4tY29tbWFuZC1saW5lLnBhbmRvYwppbmRleCBk ZTMzY2NjMDA1ZmMuLjk3MWY0N2E3N2U5NCAxMDA2NDQKLS0tIGEvZG9jcy9t aXNjL3hlbi1jb21tYW5kLWxpbmUucGFuZG9jCisrKyBiL2RvY3MvbWlzYy94 ZW4tY29tbWFuZC1saW5lLnBhbmRvYwpAQCAtMjI1OCw3ICsyMjU4LDcgQEAg QnkgZGVmYXVsdCBTU0JEIHdpbGwgYmUgbWl0aWdhdGVkIGF0IHJ1bnRpbWUg KGkuZSBgc3NiZD1ydW50aW1lYCkuCiAKICMjIyBzcGVjLWN0cmwgKHg4NikK ID4gYD0gTGlzdCBvZiBbIDxib29sPiwgeGVuPTxib29sPiwge3B2LGh2bX09 PGJvb2w+LAotPiAgICAgICAgICAgICAge21zci1zYyxyc2IsbWQtY2xlYXJ9 PTxib29sPnx7cHYsaHZtfT08Ym9vbD4sCis+ICAgICAgICAgICAgICB7bXNy LXNjLHJzYixtZC1jbGVhcixpYnBiLWVudHJ5fT08Ym9vbD58e3B2LGh2bX09 PGJvb2w+LAogPiAgICAgICAgICAgICAgYnRpLXRodW5rPXJldHBvbGluZXxs ZmVuY2V8am1wLCB7aWJycyxpYnBiLHNzYmQscHNmZCwKID4gICAgICAgICAg ICAgIGVhZ2VyLWZwdSxsMWQtZmx1c2gsYnJhbmNoLWhhcmRlbixzcmItbG9j aywKID4gICAgICAgICAgICAgIHVucHJpdi1tbWlvfT08Ym9vbD4gXWAKQEAg LTIyODMsOSArMjI4MywxMCBAQCBpbiBwbGFjZSBmb3IgZ3Vlc3RzIHRvIHVz ZS4KIAogVXNlIG9mIGEgcG9zaXRpdmUgYm9vbGVhbiB2YWx1ZSBmb3IgZWl0 aGVyIG9mIHRoZXNlIG9wdGlvbnMgaXMgaW52YWxpZC4KIAotVGhlIGBwdj1g LCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gIGFuZCBgbWQtY2xlYXI9YCBv cHRpb25zIG9mZmVyIGZpbmUKLWdyYWluZWQgY29udHJvbCBvdmVyIHRoZSBw cmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGltcGFjdCBYZW4ncyBhYmlsaXR5 IHRvCi1wcm90ZWN0IGl0c2VsZiwgYW5kL29yIFhlbidzIGFiaWxpdHkgdG8g dmlydHVhbGlzZSBzdXBwb3J0IGZvciBndWVzdHMgdG8gdXNlLgorVGhlIGBw dj1gLCBgaHZtPWAsIGBtc3Itc2M9YCwgYHJzYj1gLCBgbWQtY2xlYXI9YCBh bmQgYGlicGItZW50cnk9YCBvcHRpb25zCitvZmZlciBmaW5lIGdyYWluZWQg Y29udHJvbCBvdmVyIHRoZSBwcmltaXRpdmVzIGJ5IFhlbi4gIFRoZXNlIGlt cGFjdCBYZW4ncworYWJpbGl0eSB0byBwcm90ZWN0IGl0c2VsZiwgYW5kL29y IFhlbidzIGFiaWxpdHkgdG8gdmlydHVhbGlzZSBzdXBwb3J0IGZvcgorZ3Vl c3RzIHRvIHVzZS4KIAogKiBgcHY9YCBhbmQgYGh2bT1gIG9mZmVyIGNvbnRy b2wgb3ZlciBhbGwgc3Vib3B0aW9ucyBmb3IgUFYgYW5kIEhWTSBndWVzdHMK ICAgcmVzcGVjdGl2ZWx5LgpAQCAtMjMwNCw2ICsyMzA1LDExIEBAIHByb3Rl Y3QgaXRzZWxmLCBhbmQvb3IgWGVuJ3MgYWJpbGl0eSB0byB2aXJ0dWFsaXNl IHN1cHBvcnQgZm9yIGd1ZXN0cyB0byB1c2UuCiAgIGNvbXBhdGliaWxpdHkg d2l0aCBkZXZlbG9wbWVudCB2ZXJzaW9ucyBvZiB0aGlzIGZpeCwgYG1kcz1g IGlzIGFsc28gYWNjZXB0ZWQKICAgb24gWGVuIDQuMTIgYW5kIGVhcmxpZXIg YXMgYW4gYWxpYXMuICBDb25zdWx0IHZlbmRvciBkb2N1bWVudGF0aW9uIGlu CiAgIHByZWZlcmVuY2UgdG8gaGVyZS4qCisqIGBpYnBiLWVudHJ5PWAgb2Zm ZXJzIGNvbnRyb2wgb3ZlciB3aGV0aGVyIElCUEIgKEluZGlyZWN0IEJyYW5j aCBQcmVkaWN0aW9uCisgIEJhcnJpZXIpIGlzIHVzZWQgb24gZW50cnkgdG8g WGVuLiAgVGhpcyBpcyB1c2VkIGJ5IGRlZmF1bHQgb24gaGFyZHdhcmUKKyAg dnVsbmVyYWJsZSB0byBCcmFuY2ggVHlwZSBDb25mdXNpb24sIGJ1dCBmb3Ig cGVyZm9ybWFuY2UgcmVhc29ucywgZG9tMCBpcworICB1bnByb3RlY3RlZCBi eSBkZWZhdWx0LiAgSWYgaXQgbmVjZXNzYXJ5IHRvIHByb3RlY3QgZG9tMCB0 b28sIGJvb3Qgd2l0aAorICBgc3BlYy1jdHJsPWlicGItZW50cnlgLgogCiBJ ZiBYZW4gd2FzIGNvbXBpbGVkIHdpdGggSU5ESVJFQ1RfVEhVTksgc3VwcG9y dCwgYGJ0aS10aHVuaz1gIGNhbiBiZSB1c2VkIHRvCiBzZWxlY3Qgd2hpY2gg b2YgdGhlIHRodW5rcyBnZXRzIHBhdGNoZWQgaW50byB0aGUgYF9feDg2X2lu ZGlyZWN0X3RodW5rXyVyZWdgCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv aW5jbHVkZS9hc20vc3BlY19jdHJsLmggYi94ZW4vYXJjaC94ODYvaW5jbHVk ZS9hc20vc3BlY19jdHJsLmgKaW5kZXggM2ZjNTk5YTgxN2M0Li45NDAzYjgx ZGM3YWYgMTAwNjQ0Ci0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9z cGVjX2N0cmwuaAorKysgYi94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vc3Bl Y19jdHJsLmgKQEAgLTY1LDcgKzY1LDcgQEAKIHZvaWQgaW5pdF9zcGVjdWxh dGlvbl9taXRpZ2F0aW9ucyh2b2lkKTsKIHZvaWQgc3BlY19jdHJsX2luaXRf ZG9tYWluKHN0cnVjdCBkb21haW4gKmQpOwogCi1leHRlcm4gYm9vbCBvcHRf aWJwYl9jdHh0X3N3aXRjaDsKK2V4dGVybiBpbnQ4X3Qgb3B0X2licGJfY3R4 dF9zd2l0Y2g7CiBleHRlcm4gYm9vbCBvcHRfc3NiZDsKIGV4dGVybiBpbnQ4 X3Qgb3B0X2VhZ2VyX2ZwdTsKIGV4dGVybiBpbnQ4X3Qgb3B0X2wxZF9mbHVz aDsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYyBiL3hl bi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwppbmRleCBlNWVhMmM1YzZjOTMuLjlk ZDRkODQ2ZjU1NSAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2L3NwZWNfY3Ry bC5jCisrKyBiL3hlbi9hcmNoL3g4Ni9zcGVjX2N0cmwuYwpAQCAtMzksNiAr MzksMTAgQEAgc3RhdGljIGJvb2wgX19pbml0ZGF0YSBvcHRfcnNiX2h2bSA9 IHRydWU7CiBzdGF0aWMgaW50OF90IF9fcm9fYWZ0ZXJfaW5pdCBvcHRfbWRf Y2xlYXJfcHYgPSAtMTsKIHN0YXRpYyBpbnQ4X3QgX19yb19hZnRlcl9pbml0 IG9wdF9tZF9jbGVhcl9odm0gPSAtMTsKIAorc3RhdGljIGludDhfdCBfX3Jv X2FmdGVyX2luaXQgb3B0X2licGJfZW50cnlfcHYgPSAtMTsKK3N0YXRpYyBp bnQ4X3QgX19yb19hZnRlcl9pbml0IG9wdF9pYnBiX2VudHJ5X2h2bSA9IC0x Oworc3RhdGljIGJvb2wgX19yb19hZnRlcl9pbml0IG9wdF9pYnBiX2VudHJ5 X2RvbTA7CisKIC8qIENtZGxpbmUgY29udHJvbHMgZm9yIFhlbidzIHNwZWN1 bGF0aXZlIHNldHRpbmdzLiAqLwogc3RhdGljIGVudW0gaW5kX3RodW5rIHsK ICAgICBUSFVOS19ERUZBVUxULCAvKiBEZWNpZGUgd2hpY2ggdGh1bmsgdG8g dXNlIGF0IGJvb3QgdGltZS4gKi8KQEAgLTU0LDcgKzU4LDcgQEAgaW50OF90 IF9faW5pdGRhdGEgb3B0X3N0aWJwID0gLTE7CiBib29sIF9fcm9fYWZ0ZXJf aW5pdCBvcHRfc3NiZDsKIGludDhfdCBfX2luaXRkYXRhIG9wdF9wc2ZkID0g LTE7CiAKLWJvb2wgX19yZWFkX21vc3RseSBvcHRfaWJwYl9jdHh0X3N3aXRj aCA9IHRydWU7CitpbnQ4X3QgX19yb19hZnRlcl9pbml0IG9wdF9pYnBiX2N0 eHRfc3dpdGNoID0gLTE7CiBpbnQ4X3QgX19yZWFkX21vc3RseSBvcHRfZWFn ZXJfZnB1ID0gLTE7CiBpbnQ4X3QgX19yZWFkX21vc3RseSBvcHRfbDFkX2Zs dXNoID0gLTE7CiBzdGF0aWMgYm9vbCBfX2luaXRkYXRhIG9wdF9icmFuY2hf aGFyZGVuID0gdHJ1ZTsKQEAgLTExNCw2ICsxMTgsOSBAQCBzdGF0aWMgaW50 IF9faW5pdCBjZl9jaGVjayBwYXJzZV9zcGVjX2N0cmwoY29uc3QgY2hhciAq cykKICAgICAgICAgICAgIG9wdF9yc2JfaHZtID0gZmFsc2U7CiAgICAgICAg ICAgICBvcHRfbWRfY2xlYXJfcHYgPSAwOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX2h2bSA9IDA7CisgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9w diA9IDA7CisgICAgICAgICAgICBvcHRfaWJwYl9lbnRyeV9odm0gPSAwOwor ICAgICAgICAgICAgb3B0X2licGJfZW50cnlfZG9tMCA9IGZhbHNlOwogCiAg ICAgICAgICAgICBvcHRfdGh1bmsgPSBUSFVOS19KTVA7CiAgICAgICAgICAg ICBvcHRfaWJycyA9IDA7CkBAIC0xNDAsMTIgKzE0NywxNCBAQCBzdGF0aWMg aW50IF9faW5pdCBjZl9jaGVjayBwYXJzZV9zcGVjX2N0cmwoY29uc3QgY2hh ciAqcykKICAgICAgICAgICAgIG9wdF9tc3Jfc2NfcHYgPSB2YWw7CiAgICAg ICAgICAgICBvcHRfcnNiX3B2ID0gdmFsOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX3B2ID0gdmFsOworICAgICAgICAgICAgb3B0X2licGJfZW50cnlf cHYgPSB2YWw7CiAgICAgICAgIH0KICAgICAgICAgZWxzZSBpZiAoICh2YWwg PSBwYXJzZV9ib29sZWFuKCJodm0iLCBzLCBzcykpID49IDAgKQogICAgICAg ICB7CiAgICAgICAgICAgICBvcHRfbXNyX3NjX2h2bSA9IHZhbDsKICAgICAg ICAgICAgIG9wdF9yc2JfaHZtID0gdmFsOwogICAgICAgICAgICAgb3B0X21k X2NsZWFyX2h2bSA9IHZhbDsKKyAgICAgICAgICAgIG9wdF9pYnBiX2VudHJ5 X2h2bSA9IHZhbDsKICAgICAgICAgfQogICAgICAgICBlbHNlIGlmICggKHZh bCA9IHBhcnNlX2Jvb2xlYW4oIm1zci1zYyIsIHMsIHNzKSkgIT0gLTEgKQog ICAgICAgICB7CkBAIC0yMTAsNiArMjE5LDI4IEBAIHN0YXRpYyBpbnQgX19p bml0IGNmX2NoZWNrIHBhcnNlX3NwZWNfY3RybChjb25zdCBjaGFyICpzKQog ICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICAgICAgfQogICAgICAg ICB9CisgICAgICAgIGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigi aWJwYi1lbnRyeSIsIHMsIHNzKSkgIT0gLTEgKQorICAgICAgICB7CisgICAg ICAgICAgICBzd2l0Y2ggKCB2YWwgKQorICAgICAgICAgICAgeworICAgICAg ICAgICAgY2FzZSAwOgorICAgICAgICAgICAgY2FzZSAxOgorICAgICAgICAg ICAgICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gb3B0X2licGJfZW50cnlfaHZt ID0KKyAgICAgICAgICAgICAgICAgICAgb3B0X2licGJfZW50cnlfZG9tMCA9 IHZhbDsKKyAgICAgICAgICAgICAgICBicmVhazsKKworICAgICAgICAgICAg Y2FzZSAtMjoKKyAgICAgICAgICAgICAgICBzICs9IHN0cmxlbigiaWJwYi1l bnRyeT0iKTsKKyAgICAgICAgICAgICAgICBpZiAoICh2YWwgPSBwYXJzZV9i b29sZWFuKCJwdiIsIHMsIHNzKSkgPj0gMCApCisgICAgICAgICAgICAgICAg ICAgIG9wdF9pYnBiX2VudHJ5X3B2ID0gdmFsOworICAgICAgICAgICAgICAg IGVsc2UgaWYgKCAodmFsID0gcGFyc2VfYm9vbGVhbigiaHZtIiwgcywgc3Mp KSA+PSAwICkKKyAgICAgICAgICAgICAgICAgICAgb3B0X2licGJfZW50cnlf aHZtID0gdmFsOworICAgICAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAg IGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgICAgIHJjID0gLUVJTlZBTDsK KyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAg ICAgfQogCiAgICAgICAgIC8qIFhlbidzIHNwZWN1bGF0aXZlIHNpZGVjaGFu bmVsIG1pdGlnYXRpb24gc2V0dGluZ3MuICovCiAgICAgICAgIGVsc2UgaWYg KCAhc3RybmNtcChzLCAiYnRpLXRodW5rPSIsIDEwKSApCkBAIC00NzcsMjcg KzUwOCwzMSBAQCBzdGF0aWMgdm9pZCBfX2luaXQgcHJpbnRfZGV0YWlscyhl bnVtIGluZF90aHVuayB0aHVuaywgdWludDY0X3QgY2FwcykKICAgICAgKiBt aXRpZ2F0aW9uIHN1cHBvcnQgZm9yIGd1ZXN0cy4KICAgICAgKi8KICNpZmRl ZiBDT05GSUdfSFZNCi0gICAgcHJpbnRrKCIgIFN1cHBvcnQgZm9yIEhWTSBW TXM6JXMlcyVzJXMlc1xuIiwKKyAgICBwcmludGsoIiAgU3VwcG9ydCBmb3Ig SFZNIFZNczolcyVzJXMlcyVzJXNcbiIsCiAgICAgICAgICAgIChib290X2Nw dV9oYXMoWDg2X0ZFQVRVUkVfU0NfTVNSX0hWTSkgfHwKICAgICAgICAgICAg IGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19SU0JfSFZNKSB8fAogICAg ICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX01EX0NMRUFSKSAg IHx8CisgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfSUJQ Ql9FTlRSWV9IVk0pIHx8CiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1KSAg ICAgICAgICAgICAgICAgICAgICAgICAgID8gIiIgICAgICAgICAgICAgICA6 ICIgTm9uZSIsCiAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVS RV9TQ19NU1JfSFZNKSAgICAgID8gIiBNU1JfU1BFQ19DVFJMIiA6ICIiLAog ICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0NfUlNCX0hW TSkgICAgICA/ICIgUlNCIiAgICAgICAgICAgOiAiIiwKICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAi IEVBR0VSX0ZQVSIgICAgIDogIiIsCi0gICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9DTEVBUiIg ICAgICA6ICIiKTsKKyAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX01EX0NMRUFSKSAgICAgICAgPyAiIE1EX0NMRUFSIiAgICAgIDogIiIs CisgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCX0VO VFJZX0hWTSkgID8gIiBJQlBCLWVudHJ5IiAgICA6ICIiKTsKIAogI2VuZGlm CiAjaWZkZWYgQ09ORklHX1BWCi0gICAgcHJpbnRrKCIgIFN1cHBvcnQgZm9y IFBWIFZNczolcyVzJXMlcyVzXG4iLAorICAgIHByaW50aygiICBTdXBwb3J0 IGZvciBQViBWTXM6JXMlcyVzJXMlcyVzXG4iLAogICAgICAgICAgICAoYm9v dF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NDX01TUl9QVikgfHwKICAgICAgICAg ICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9TQ19SU0JfUFYpIHx8CiAg ICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfTURfQ0xFQVIp ICB8fAorICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lC UEJfRU5UUllfUFYpIHx8CiAgICAgICAgICAgICBvcHRfZWFnZXJfZnB1KSAg ICAgICAgICAgICAgICAgICAgICAgICAgID8gIiIgICAgICAgICAgICAgICA6 ICIgTm9uZSIsCiAgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVS RV9TQ19NU1JfUFYpICAgICAgID8gIiBNU1JfU1BFQ19DVFJMIiA6ICIiLAog ICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfU0NfUlNCX1BW KSAgICAgICA/ICIgUlNCIiAgICAgICAgICAgOiAiIiwKICAgICAgICAgICAg b3B0X2VhZ2VyX2ZwdSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPyAi IEVBR0VSX0ZQVSIgICAgIDogIiIsCi0gICAgICAgICAgIGJvb3RfY3B1X2hh cyhYODZfRkVBVFVSRV9NRF9DTEVBUikgICAgICAgID8gIiBNRF9DTEVBUiIg ICAgICA6ICIiKTsKKyAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX01EX0NMRUFSKSAgICAgICAgPyAiIE1EX0NMRUFSIiAgICAgIDogIiIs CisgICAgICAgICAgIGJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCX0VO VFJZX1BWKSAgID8gIiBJQlBCLWVudHJ5IiAgICA6ICIiKTsKIAogICAgIHBy aW50aygiICBYUFRJICg2NC1iaXQgUFYgb25seSk6IERvbTAgJXMsIERvbVUg JXMgKHdpdGglcyBQQ0lEKVxuIiwKICAgICAgICAgICAgb3B0X3hwdGlfaHdk b20gPyAiZW5hYmxlZCIgOiAiZGlzYWJsZWQiLApAQCAtNzYwLDYgKzc5NSw1 NSBAQCBzdGF0aWMgYm9vbCBfX2luaXQgc2hvdWxkX3VzZV9lYWdlcl9mcHUo dm9pZCkKICAgICB9CiB9CiAKK3N0YXRpYyB2b2lkIF9faW5pdCBpYnBiX2Nh bGN1bGF0aW9ucyh2b2lkKQoreworICAgIC8qIENoZWNrIHdlIGhhdmUgaGFy ZHdhcmUgSUJQQiBzdXBwb3J0IGJlZm9yZSB1c2luZyBpdC4uLiAqLworICAg IGlmICggIWJvb3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlJTQikgJiYgIWJv b3RfY3B1X2hhcyhYODZfRkVBVFVSRV9JQlBCKSApCisgICAgeworICAgICAg ICBvcHRfaWJwYl9lbnRyeV9odm0gPSBvcHRfaWJwYl9lbnRyeV9wdiA9IG9w dF9pYnBiX2N0eHRfc3dpdGNoID0gMDsKKyAgICAgICAgb3B0X2licGJfZW50 cnlfZG9tMCA9IGZhbHNlOworICAgICAgICByZXR1cm47CisgICAgfQorCisg ICAgLyoKKyAgICAgKiBJQlBCLW9uLWVudHJ5IG1pdGlnYXRpb25zIGZvciBC cmFuY2ggVHlwZSBDb25mdXNpb24uCisgICAgICoKKyAgICAgKiBJQlBCICYm ICFCVENfTk8gc2VsZWN0cyBhbGwgQU1EL0h5Z29uIGhhcmR3YXJlLCBub3Qg a25vd24gdG8gYmUgc2FmZSwKKyAgICAgKiB0aGF0IHdlIGNhbiBwcm92aWRl IHNvbWUgZm9ybSBvZiBtaXRpZ2F0aW9uIG9uLgorICAgICAqLworICAgIGlm ICggb3B0X2licGJfZW50cnlfcHYgPT0gLTEgKQorICAgICAgICBvcHRfaWJw Yl9lbnRyeV9wdiA9IChJU19FTkFCTEVEKENPTkZJR19QVikgJiYKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX0lCUEIpICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICFi b290X2NwdV9oYXMoWDg2X0ZFQVRVUkVfQlRDX05PKSk7CisgICAgaWYgKCBv cHRfaWJwYl9lbnRyeV9odm0gPT0gLTEgKQorICAgICAgICBvcHRfaWJwYl9l bnRyeV9odm0gPSAoSVNfRU5BQkxFRChDT05GSUdfSFZNKSAmJgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgYm9vdF9jcHVfaGFzKFg4Nl9GRUFU VVJFX0lCUEIpICYmCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAh Ym9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0JUQ19OTykpOworCisgICAgaWYg KCBvcHRfaWJwYl9lbnRyeV9wdiApCisgICAgeworICAgICAgICBzZXR1cF9m b3JjZV9jcHVfY2FwKFg4Nl9GRUFUVVJFX0lCUEJfRU5UUllfUFYpOworCisg ICAgICAgIC8qCisgICAgICAgICAqIFdlIG9ubHkgbmVlZCB0byBmbHVzaCBp biBJU1QgY29udGV4dCBpZiB3ZSdyZSBwcm90ZWN0aW5nIGFnYWluc3QgUFYK KyAgICAgICAgICogZ3Vlc3RzLiAgSFZNIElCUEItb24tZW50cnkgcHJvdGVj dGlvbnMgYXJlIGJvdGggYXRvbWljIHdpdGgKKyAgICAgICAgICogTk1JLyNN Qywgc28gY2FuJ3QgaW50ZXJydXB0IFhlbiBhaGVhZCBvZiBoYXZpbmcgYWxy ZWFkeSBmbHVzaGVkIHRoZQorICAgICAgICAgKiBCVEIuCisgICAgICAgICAq LworICAgICAgICBkZWZhdWx0X3NwZWNfY3RybF9mbGFncyB8PSBTQ0ZfaXN0 X2licGI7CisgICAgfQorICAgIGlmICggb3B0X2licGJfZW50cnlfaHZtICkK KyAgICAgICAgc2V0dXBfZm9yY2VfY3B1X2NhcChYODZfRkVBVFVSRV9JQlBC X0VOVFJZX0hWTSk7CisKKyAgICAvKgorICAgICAqIElmIHdlJ3JlIHVzaW5n IElCUEItb24tZW50cnkgdG8gcHJvdGVjdCBhZ2FpbnN0IFBWIGFuZCBIVk0g Z3Vlc3RzCisgICAgICogKGlnbm9yaW5nIGRvbTAgaWYgdHJ1c3RlZCksIHRo ZW4gdGhlcmUncyBubyBuZWVkIHRvIGFsc28gaXNzdWUgSUJQQiBvbgorICAg ICAqIGNvbnRleHQgc3dpdGNoIHRvby4KKyAgICAgKi8KKyAgICBpZiAoIG9w dF9pYnBiX2N0eHRfc3dpdGNoID09IC0xICkKKyAgICAgICAgb3B0X2licGJf Y3R4dF9zd2l0Y2ggPSAhKG9wdF9pYnBiX2VudHJ5X2h2bSAmJiBvcHRfaWJw Yl9lbnRyeV9wdik7Cit9CisKIC8qIENhbGN1bGF0ZSB3aGV0aGVyIHRoaXMg Q1BVIGlzIHZ1bG5lcmFibGUgdG8gTDFURi4gKi8KIHN0YXRpYyBfX2luaXQg dm9pZCBsMXRmX2NhbGN1bGF0aW9ucyh1aW50NjRfdCBjYXBzKQogewpAQCAt MTAxNSw4ICsxMDk5LDEyIEBAIHZvaWQgc3BlY19jdHJsX2luaXRfZG9tYWlu KHN0cnVjdCBkb21haW4gKmQpCiAgICAgYm9vbCB2ZXJ3ID0gKChwdiA/IG9w dF9tZF9jbGVhcl9wdiA6IG9wdF9tZF9jbGVhcl9odm0pIHx8CiAgICAgICAg ICAgICAgICAgIChvcHRfZmJfY2xlYXJfbW1pbyAmJiBpc19pb21tdV9lbmFi bGVkKGQpKSk7CiAKKyAgICBib29sIGlicGIgPSAoKHB2ID8gb3B0X2licGJf ZW50cnlfcHYgOiBvcHRfaWJwYl9lbnRyeV9odm0pICYmCisgICAgICAgICAg ICAgICAgIChkLT5kb21haW5faWQgIT0gMCB8fCBvcHRfaWJwYl9lbnRyeV9k b20wKSk7CisKICAgICBkLT5hcmNoLnNwZWNfY3RybF9mbGFncyA9CiAgICAg ICAgICh2ZXJ3ICAgPyBTQ0ZfdmVydyAgICAgICAgIDogMCkgfAorICAgICAg ICAoaWJwYiAgID8gU0NGX2VudHJ5X2licGIgICA6IDApIHwKICAgICAgICAg MDsKIH0KIApAQCAtMTE2MywxMiArMTI1MSwxNSBAQCB2b2lkIF9faW5pdCBp bml0X3NwZWN1bGF0aW9uX21pdGlnYXRpb25zKHZvaWQpCiAgICAgfQogCiAg ICAgLyoKLSAgICAgKiBVc2UgU1RJQlAgYnkgZGVmYXVsdCBpZiB0aGUgaGFy ZHdhcmUgaGludCBpcyBzZXQuICBPdGhlcndpc2UsIGxlYXZlIGl0Ci0gICAg ICogb2ZmIGFzIGl0IGEgc2V2ZXJlIHBlcmZvcm1hbmNlIHBlbnRhbHR5IG9u IHByZS1lSUJSUyBJbnRlbCBoYXJkd2FyZQotICAgICAqIHdoZXJlIGl0IHdh cyByZXRyb2ZpdHRlZCBpbiBtaWNyb2NvZGUuCisgICAgICogVXNlIFNUSUJQ IGJ5IGRlZmF1bHQgb24gYWxsIEFNRCBzeXN0ZW1zLiAgWmVuMyBhbmQgbGF0 ZXIgZW51bWVyYXRlCisgICAgICogU1RJQlBfQUxXQVlTLCBidXQgU1RJQlAg aXMgbmVlZGVkIG9uIFplbjIgYXMgcGFydCBvZiB0aGUgbWl0aWdhdGlvbnMK KyAgICAgKiBmb3IgQnJhbmNoIFR5cGUgQ29uZnVzaW9uLgorICAgICAqCisg ICAgICogTGVhdmUgU1RJQlAgb2ZmIGJ5IGRlZmF1bHQgb24gSW50ZWwuICBQ cmUtZUlCUlMgc3lzdGVtcyBzdWZmZXIgYQorICAgICAqIHN1YnN0YW50aWFs IHBlcmYgaGl0IHdoZW4gaXQgd2FzIGltcGxlbWVudGVkIGluIG1pY3JvY29k ZS4KICAgICAgKi8KICAgICBpZiAoIG9wdF9zdGlicCA9PSAtMSApCi0gICAg ICAgIG9wdF9zdGlicCA9ICEhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NU SUJQX0FMV0FZUyk7CisgICAgICAgIG9wdF9zdGlicCA9ICEhYm9vdF9jcHVf aGFzKFg4Nl9GRUFUVVJFX0FNRF9TVElCUCk7CiAKICAgICBpZiAoIG9wdF9z dGlicCAmJiAoYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1NUSUJQKSB8fAog ICAgICAgICAgICAgICAgICAgICAgICBib290X2NwdV9oYXMoWDg2X0ZFQVRV UkVfQU1EX1NUSUJQKSkgKQpAQCAtMTI0MCw5ICsxMzMxLDcgQEAgdm9pZCBf X2luaXQgaW5pdF9zcGVjdWxhdGlvbl9taXRpZ2F0aW9ucyh2b2lkKQogICAg IGlmICggb3B0X3JzYl9odm0gKQogICAgICAgICBzZXR1cF9mb3JjZV9jcHVf Y2FwKFg4Nl9GRUFUVVJFX1NDX1JTQl9IVk0pOwogCi0gICAgLyogQ2hlY2sg d2UgaGF2ZSBoYXJkd2FyZSBJQlBCIHN1cHBvcnQgYmVmb3JlIHVzaW5nIGl0 Li4uICovCi0gICAgaWYgKCAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lC UlNCKSAmJiAhYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX0lCUEIpICkKLSAg ICAgICAgb3B0X2licGJfY3R4dF9zd2l0Y2ggPSBmYWxzZTsKKyAgICBpYnBi X2NhbGN1bGF0aW9ucygpOwogCiAgICAgLyogQ2hlY2sgd2hldGhlciBFYWdl ciBGUFUgc2hvdWxkIGJlIGVuYWJsZWQgYnkgZGVmYXVsdC4gKi8KICAgICBp ZiAoIG9wdF9lYWdlcl9mcHUgPT0gLTEgKQo= --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:38:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:38:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365877.596223 (Exim 4.92) (envelope-from ) id 1oBIuS-0005KH-Jt; Tue, 12 Jul 2022 16:38:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365877.596223; Tue, 12 Jul 2022 16:38:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIuS-0005KA-Gw; Tue, 12 Jul 2022 16:38:52 +0000 Received: by outflank-mailman (input) for mailman id 365877; Tue, 12 Jul 2022 16:38:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBIuR-0005K0-1V for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 16:38:51 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1adfddf9-0201-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 18:38:49 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 37D6D6192F; Tue, 12 Jul 2022 16:38:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 002E6C3411C; Tue, 12 Jul 2022 16:38:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1adfddf9-0201-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657643927; bh=4BDfSSRpMaIphCs/51FX5hBMkKL+h2V39A32PoeENKE=; h=Date:From:To:Cc:Subject:From; b=VszbvoOQ32Y5tUUOu1X5m/qZVrA8i8HEwF6OfAI3/1iEY8WzgXQYawQzWhkcEHNI1 zb7w8lqauDh19oVhcNZgsh2p101mFkKJXH45mNi5sZfjBIZjIfjXX0qJk2ixP1XNaA 1zzD/p9+2gIbYSLAfE5mJBzY40yFlUhhIcHqvp4k= Date: Tue, 12 Jul 2022 18:38:44 +0200 From: Greg KH To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi all, I'm seeing the following build warning: arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction in the 5.15.y and 5.10.y retbleed backports. I don't know why just this one hypercall is being called out by objtool, and this warning isn't in 5.18 and Linus's tree due to I think commit 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. But, is this a ret call that we "forgot" here? It's a "real" ret in Linus's branch: .pushsection .noinstr.text, "ax" .balign PAGE_SIZE SYM_CODE_START(hypercall_page) .rept (PAGE_SIZE / 32) UNWIND_HINT_FUNC ANNOTATE_NOENDBR ANNOTATE_UNRET_SAFE ret /* * Xen will write the hypercall page, and sort out ENDBR. */ .skip 31, 0xcc .endr while 5.15.y and older has: .pushsection .text .balign PAGE_SIZE SYM_CODE_START(hypercall_page) .rept (PAGE_SIZE / 32) UNWIND_HINT_FUNC .skip 31, 0x90 ANNOTATE_UNRET_SAFE RET .endr So should the "ret" remain or be turned into "RET" in mainline right now? thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Tue Jul 12 16:52:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 16:52:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365942.596438 (Exim 4.92) (envelope-from ) id 1oBJ7o-0001jQ-IG; Tue, 12 Jul 2022 16:52:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365942.596438; Tue, 12 Jul 2022 16:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJ7o-0001jJ-FQ; Tue, 12 Jul 2022 16:52:40 +0000 Received: by outflank-mailman (input) for mailman id 365942; Tue, 12 Jul 2022 16:52:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJ7n-0001j7-54; Tue, 12 Jul 2022 16:52:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJ7n-0003Ie-41; Tue, 12 Jul 2022 16:52:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJ7m-0005TR-KE; Tue, 12 Jul 2022 16:52:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBJ7m-0007Qe-JX; Tue, 12 Jul 2022 16:52:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YzHWmIOTH4Wt/xFaM53bhFHQyh7Xor+M6xtliUIgaTA=; b=AJmVxxA+057DOzNTMvUwuC42j2 fcfnDnOabD/S6PBYpr82Nho9gdoBW962oQRwsSWh/yuAoV0gPxmhpgSzHn7gZrFcjIgYcWSagB0k+ aQVTbP2EtOsdDLCh4OT+QpxGpwsVxhN2FTqhSfP1KFH/3J7YPAnawnRshaTtVLuahjho=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171599: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=033ae6f88be198b8f56043f94b7076b79b5e447e X-Osstest-Versions-That: xen=dc7da0874ba4e8fab4c5783055755938ef19fc37 From: osstest service owner Date: Tue, 12 Jul 2022 16:52:38 +0000 flight 171599 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171599/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 033ae6f88be198b8f56043f94b7076b79b5e447e baseline version: xen dc7da0874ba4e8fab4c5783055755938ef19fc37 Last test of basis 171590 2022-07-12 07:01:45 Z 0 days Testing same since 171599 2022-07-12 14:00:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jan Beulich Juergen Gross Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git dc7da0874b..033ae6f88b 033ae6f88be198b8f56043f94b7076b79b5e447e -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 12 17:06:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 17:06:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365963.596481 (Exim 4.92) (envelope-from ) id 1oBJKs-0003od-6T; Tue, 12 Jul 2022 17:06:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365963.596481; Tue, 12 Jul 2022 17:06:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJKs-0003oW-3k; Tue, 12 Jul 2022 17:06:10 +0000 Received: by outflank-mailman (input) for mailman id 365963; Tue, 12 Jul 2022 17:06:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJKq-0003oQ-RF for xen-devel@lists.xen.org; Tue, 12 Jul 2022 17:06:09 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e826cb67-0204-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 19:06:01 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id y4so10924047edc.4 for ; Tue, 12 Jul 2022 10:06:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e826cb67-0204-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mPvlCY0D7q1NbpG5A6luYlqO1cYR+DoRmnFAVONJxk8=; b=L9p5XwJo/qqd3+L1Cd/plS2N+fPmv1w9dcPWmZQgsp2LkZadY0N9DBxTujQNJbXFgB 6g4XLcNb7/ddmvwOgVoy+Er7+8X23MO0wFzOTltwPWVjnYPhY8dUj3c0BA+egaXMzfHt 8GGAE0yapjLLT6TCxhdbbKjwdsLqMm4uGZVwY4Ge2cdNgRBIm7zjcUonnpGX9SAz4u1f WSsjThULfmQ6HgHrN/xhhvqHZ0fkGhY/RnEGs4WKhQyG8LJyh+Gs6Bq/ZoohJXyNCL+2 Log5+MwAFcxJSeH+mobGQoo//Hl4r+voaGzWDLGgB5XUKXUGK1NpPMr7cVGZBDjBrPRn ldsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mPvlCY0D7q1NbpG5A6luYlqO1cYR+DoRmnFAVONJxk8=; b=y2buHOS3nTAmcI2IPkySwdLaai+aRsPy/xMwGIrV6JKXdiuyUYleejIyj8LTRcvDWv ZiHWdADVkWeCx46QWKtJm0qzocQmi+CYqeE6u8E9wSWw9tpKGePWkjns90o9WUxkrD0S pmCp1PqBeL5zlPububvh8TrGRMCDRZ2lcwdEm6ia/UoQMqh+qFdrN72z5L5X16n50RAD 8ntUyVgSFeYEUATvLjKn00hKY8C7Nur7C//Hcb9evkR/fE9xAFNLUtB+theeN3aGVeky e5nU55xd6+55bzghbVgLSRWnsZqMRUO0zlsuBMhKpy+eN6kC10G3Rcz9E7P+v86WT7eb FuIg== X-Gm-Message-State: AJIora+xegvca0E2OSzGtqE7MfQrXZZy/Tszl2GxUPtfXs6V53hAjIFs kwjC9fqCYV/8Qmbr4odlBDME8Zi0XlOezYItzdxlTizeQBWXDw== X-Google-Smtp-Source: AGRyM1t8Lla/OAFCqEYh5HJzjWSZKrDNn9YiDIMSNAhLolPJN3zmZJYx1bpHLz/0oiauHgQaodcuK76NcOyS05g2qWQ= X-Received: by 2002:a05:6402:3290:b0:43a:86c4:af70 with SMTP id f16-20020a056402329000b0043a86c4af70mr32747857eda.313.1657645561263; Tue, 12 Jul 2022 10:06:01 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Brad Churchwell Date: Tue, 12 Jul 2022 12:05:50 -0500 Message-ID: Subject: Re: Xen on rk3399 To: Bertrand Marquis Cc: "xen-devel@lists.xen.org" Content-Type: multipart/alternative; boundary="000000000000d7c92805e39eae08" --000000000000d7c92805e39eae08 Content-Type: text/plain; charset="UTF-8" Sorry for all of the emails, but here is /proc/device-tree with XEN and without XEN: with Xen: With XEN qos@ffa60080 interrupt-parent qos@ffa90000 qos@ffaa8080 pmu-clock-controller@ff750000 watchdog@ff848000 pwm@ff420030 serial@ff1b0000 vcc5v0-usb-regulator qos@ffa76000 mmc@fe310000 iommu@ff903f00 i2c@ff110000 #size-cells spdif@ff870000 qos@ffab0080 interrupt-controller qos@ffae0000 serial@ff370000 spi@ff200000 qos@ffac8080 xin24m name hypervisor vop@ff8f0000 psci vcc12v-dcin vcc-0v9 clock-controller@ff760000 leds qos@ffab8000 qos@ffaa0000 qos@ffa60100 iommu@ff914000 qos@ffac0000 model i2c@ff3d0000 vcc5v0-sys cpus video-codec@ff650000 mipi@ff968000 thermal-zones isp0@ff910000 i2s@ff890000 external-gmac-clock rga@ff680000 dma-controller@ff6d0000 spi@ff1e0000 spi@ff1c0000 iommu@ff670800 qos@ffa5c000 dp@fec00000 iommu@ff650800 opp-table0 serial@ff190000 display-subsystem vop@ff900000 qos@ffa98000 chosen i2c@ff160000 i2c@ff140000 qos@ffa70080 edp@ff970000 efuse@ff690000 opp-table1 syscon@ff770000 i2s@ff8a0000 hdmi-sound usb@fe3c0000 mmc@fe320000 qos@ffa60180 qos@ffa58000 usb@fe800000 i2c@ff120000 qos@ffac0080 usb@fe3e0000 aliases qos@ffad8080 vcc3v3-pcie-regulator saradc@ff100000 qos@ffaa8000 usb@fe3a0000 phy@ff800000 opp-table2 hdmi@ff940000 qos@ffac8000 qos@ffab0000 qos@ffaa0080 i2c@ff3c0000 rktimer@ff850000 iommu@ff924000 qos@ffad0000 compatible pcie@f8000000 sdio-pwrseq i2c@ff3e0000 video-codec@ff660000 memory@20000000 timer gpu@ff9a0000 iommu@ff8f3f00 qos@ffa74000 mipi@ff960000 #address-cells syscon@ff320000 power-management@ff310000 spi@ff1f0000 pinctrl vcc3v3-sys pwm@ff420000 vcc-phy-regulator vcc1v8-s0 spi@ff350000 i2s@ff880000 ethernet@fe300000 dma-controller@ff6e0000 usb@fe380000 spi@ff1d0000 serial@ff180000 iommu@ff660480 usb@fe900000 pwm@ff420010 tsadc@ff260000 phy@ff7c0000 mmc@fe330000 pwm@ff420020 i2c@ff130000 i2c@ff150000 qos@ffa70000 Without Xen root@zaku:/home/.cachengo# ls /proc/device-tree '#address-cells' qos@ffa5c000 '#size-cells' qos@ffa60080 aliases qos@ffa60100 chosen qos@ffa60180 clock-controller@ff760000 qos@ffa70000 compatible qos@ffa70080 cpus qos@ffa74000 display-subsystem qos@ffa76000 dma-controller@ff6d0000 qos@ffa90000 dma-controller@ff6e0000 qos@ffa98000 dp@fec00000 qos@ffaa0000 edp@ff970000 qos@ffaa0080 efuse@ff690000 qos@ffaa8000 ethernet@fe300000 qos@ffaa8080 external-gmac-clock qos@ffab0000 gpu@ff9a0000 qos@ffab0080 hdmi-sound qos@ffab8000 hdmi@ff940000 qos@ffac0000 i2c@ff110000 qos@ffac0080 i2c@ff120000 qos@ffac8000 i2c@ff130000 qos@ffac8080 i2c@ff140000 qos@ffad0000 i2c@ff150000 qos@ffad8080 i2c@ff160000 qos@ffae0000 i2c@ff3c0000 rga@ff680000 i2c@ff3d0000 rktimer@ff850000 i2c@ff3e0000 saradc@ff100000 i2s@ff880000 sdio-pwrseq i2s@ff890000 serial@ff180000 i2s@ff8a0000 serial@ff190000 interrupt-controller@fee00000 serial@ff1a0000 interrupt-parent serial@ff1b0000 iommu@ff650800 serial@ff370000 iommu@ff660480 spdif@ff870000 iommu@ff670800 spi@ff1c0000 iommu@ff8f3f00 spi@ff1d0000 iommu@ff903f00 spi@ff1e0000 iommu@ff914000 spi@ff1f0000 iommu@ff924000 spi@ff200000 isp0@ff910000 spi@ff350000 leds syscon@ff320000 memory syscon@ff770000 mipi@ff960000 thermal-zones mipi@ff968000 timer mmc@fe310000 tsadc@ff260000 mmc@fe320000 usb@fe380000 mmc@fe330000 usb@fe3a0000 model usb@fe3c0000 name usb@fe3e0000 opp-table0 usb@fe800000 opp-table1 usb@fe900000 opp-table2 vcc-0v9 pcie@f8000000 vcc-phy-regulator phy@ff7c0000 vcc12v-dcin phy@ff800000 vcc1v8-s0 pinctrl vcc3v3-pcie-regulator pmu-clock-controller@ff750000 vcc3v3-sys pmu_a53 vcc5v0-sys pmu_a72 vcc5v0-usb-regulator power-management@ff310000 video-codec@ff650000 psci video-codec@ff660000 pwm@ff420000 vop@ff8f0000 pwm@ff420010 vop@ff900000 pwm@ff420020 watchdog@ff848000 pwm@ff420030 xin24m qos@ffa58000 With XEN qos@ffa60080 interrupt-parent qos@ffa90000 qos@ffaa8080 pmu-clock-controller@ff750000 watchdog@ff848000 pwm@ff420030 serial@ff1b0000 vcc5v0-usb-regulator qos@ffa76000 mmc@fe310000 iommu@ff903f00 i2c@ff110000 #size-cells spdif@ff870000 qos@ffab0080 interrupt-controller qos@ffae0000 serial@ff370000 spi@ff200000 qos@ffac8080 xin24m name hypervisor vop@ff8f0000 psci vcc12v-dcin vcc-0v9 clock-controller@ff760000 leds qos@ffab8000 qos@ffaa0000 qos@ffa60100 iommu@ff914000 qos@ffac0000 model i2c@ff3d0000 vcc5v0-sys cpus video-codec@ff650000 mipi@ff968000 thermal-zones isp0@ff910000 i2s@ff890000 external-gmac-clock rga@ff680000 dma-controller@ff6d0000 spi@ff1e0000 spi@ff1c0000 iommu@ff670800 qos@ffa5c000 dp@fec00000 iommu@ff650800 opp-table0 serial@ff190000 display-subsystem vop@ff900000 qos@ffa98000 chosen i2c@ff160000 i2c@ff140000 qos@ffa70080 edp@ff970000 efuse@ff690000 opp-table1 syscon@ff770000 i2s@ff8a0000 hdmi-sound usb@fe3c0000 mmc@fe320000 qos@ffa60180 qos@ffa58000 usb@fe800000 i2c@ff120000 qos@ffac0080 usb@fe3e0000 aliases qos@ffad8080 vcc3v3-pcie-regulator saradc@ff100000 qos@ffaa8000 usb@fe3a0000 phy@ff800000 opp-table2 hdmi@ff940000 qos@ffac8000 qos@ffab0000 qos@ffaa0080 i2c@ff3c0000 rktimer@ff850000 iommu@ff924000 qos@ffad0000 compatible pcie@f8000000 sdio-pwrseq i2c@ff3e0000 video-codec@ff660000 memory@20000000 timer gpu@ff9a0000 iommu@ff8f3f00 qos@ffa74000 mipi@ff960000 #address-cells syscon@ff320000 power-management@ff310000 spi@ff1f0000 pinctrl vcc3v3-sys pwm@ff420000 vcc-phy-regulator vcc1v8-s0 spi@ff350000 i2s@ff880000 ethernet@fe300000 dma-controller@ff6e0000 usb@fe380000 spi@ff1d0000 serial@ff180000 iommu@ff660480 usb@fe900000 pwm@ff420010 tsadc@ff260000 phy@ff7c0000 mmc@fe330000 pwm@ff420020 i2c@ff130000 i2c@ff150000 qos@ffa70000 Without Xen root@zaku:/home/.cachengo# ls /proc/device-tree '#address-cells' qos@ffa5c000 '#size-cells' qos@ffa60080 aliases qos@ffa60100 chosen qos@ffa60180 clock-controller@ff760000 qos@ffa70000 compatible qos@ffa70080 cpus qos@ffa74000 display-subsystem qos@ffa76000 dma-controller@ff6d0000 qos@ffa90000 dma-controller@ff6e0000 qos@ffa98000 dp@fec00000 qos@ffaa0000 edp@ff970000 qos@ffaa0080 efuse@ff690000 qos@ffaa8000 ethernet@fe300000 qos@ffaa8080 external-gmac-clock qos@ffab0000 gpu@ff9a0000 qos@ffab0080 hdmi-sound qos@ffab8000 hdmi@ff940000 qos@ffac0000 i2c@ff110000 qos@ffac0080 i2c@ff120000 qos@ffac8000 i2c@ff130000 qos@ffac8080 i2c@ff140000 qos@ffad0000 i2c@ff150000 qos@ffad8080 i2c@ff160000 qos@ffae0000 i2c@ff3c0000 rga@ff680000 i2c@ff3d0000 rktimer@ff850000 i2c@ff3e0000 saradc@ff100000 i2s@ff880000 sdio-pwrseq i2s@ff890000 serial@ff180000 i2s@ff8a0000 serial@ff190000 interrupt-controller@fee00000 serial@ff1a0000 interrupt-parent serial@ff1b0000 iommu@ff650800 serial@ff370000 iommu@ff660480 spdif@ff870000 iommu@ff670800 spi@ff1c0000 iommu@ff8f3f00 spi@ff1d0000 iommu@ff903f00 spi@ff1e0000 iommu@ff914000 spi@ff1f0000 iommu@ff924000 spi@ff200000 isp0@ff910000 spi@ff350000 leds syscon@ff320000 memory syscon@ff770000 mipi@ff960000 thermal-zones mipi@ff968000 timer mmc@fe310000 tsadc@ff260000 mmc@fe320000 usb@fe380000 mmc@fe330000 usb@fe3a0000 model usb@fe3c0000 name usb@fe3e0000 opp-table0 usb@fe800000 opp-table1 usb@fe900000 opp-table2 vcc-0v9 pcie@f8000000 vcc-phy-regulator phy@ff7c0000 vcc12v-dcin phy@ff800000 vcc1v8-s0 pinctrl vcc3v3-pcie-regulator pmu-clock-controller@ff750000 vcc3v3-sys pmu_a53 vcc5v0-sys pmu_a72 vcc5v0-usb-regulator power-management@ff310000 video-codec@ff650000 psci video-codec@ff660000 pwm@ff420000 vop@ff8f0000 pwm@ff420010 vop@ff900000 pwm@ff420020 watchdog@ff848000 pwm@ff420030 xin24m qos@ffa58000 On Tue, Jul 12, 2022 at 11:24 AM Brad Churchwell wrote: > Hi Bertrand, > > I believe I understand, but just to clarify, should I leave the > ppi-partitions block in rk3399.dtsi as is and disable the little cores, or > should I also modify that block? > > Brad > > On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis < > Bertrand.Marquis@arm.com> wrote: > >> Hi Brad, >> >> > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: >> > >> > Hi Bertrand, >> > >> > Thanks so much for the quick response! >> > >> > I should have mentioned previously that this device tree and kernel >> Image (5.15.16) does boot properly with the rootfs without XEN. The >> interrupt errors are only present when booting with XEN. >> > >> > These are custom boards and they do have usb c, however we are unable >> to boot from usb as it doesn't receive power. We currently only use the >> usb to flash u-boot to spi which requires us to use a separate power >> adapter. These boards get power and networking through a custom backplane >> and interface with the backplane via a sata style justice (I'm not sure >> what the proper terminology would be here). >> > >> > Since I cannot boot to rootfs with XEN, I'm unable to show the device >> tree there. The only bit that I added to accommodate XEN is this bit here: >> > >> > chosen { >> > stdout-path = "serial2:1500000n8"; >> > bootargs = "hmp-unsafe=true"; >> > xen,dom0-bootargs = "console=hvc0 earlyprintk=xen clk_ignore_unused >> root=/dev/nvme0n1p2 rw init=/sbin/init rootwait rootfstype=ext4 >> ignore_loglevel"; >> > modules { >> > #address-cells = <2>; >> > #size-cells = <2>; >> > >> > module@1 { >> > compatible = "xen,linux-zimage", "xen,multiboot-module"; >> > reg = <0x0 0x03F80000 0x0 0x01aa8008>; >> > }; >> > module@2 { >> > compatible = "xen,linux-initrd", "xen,multiboot-module"; >> > reg = <0x0 0x06000000 0x0 0x02000000>; >> > }; >> > }; >> > >> > }; >> > >> > The gic declaration is in the vanilla rk3399.dtsi file and hasn't been >> modified: >> > >> > gic: interrupt-controller@fee00000 { >> > compatible = "arm,gic-v3"; >> > #interrupt-cells = <4>; >> > #address-cells = <2>; >> > #size-cells = <2>; >> > ranges; >> > interrupt-controller; >> > >> > reg = <0x0 0xfee00000 0 0x10000>, /* GICD */ >> > <0x0 0xfef00000 0 0xc0000>, /* GICR */ >> > <0x0 0xfff00000 0 0x10000>, /* GICC */ >> > <0x0 0xfff10000 0 0x10000>, /* GICH */ >> > <0x0 0xfff20000 0 0x10000>; /* GICV */ >> > interrupts = ; >> > its: interrupt-controller@fee20000 { >> > compatible = "arm,gic-v3-its"; >> > msi-controller; >> > #msi-cells = <1>; >> > reg = <0x0 0xfee20000 0x0 0x20000>; >> > }; >> > >> > ppi-partitions { >> > ppi_cluster0: interrupt-partition-0 { >> > affinity = <&cpu_l0 &cpu_l1 &cpu_l2 >> &cpu_l3>; >> > }; >> > >> > ppi_cluster1: interrupt-partition-1 { >> > affinity = <&cpu_b0 &cpu_b1>; >> > }; >> > }; >> >> Xen is not supporting PPI partitions. >> I also saw that your booting using SMP unsafe so all core are enabled by >> Xen. >> >> Right now big/little is not supported by Xen and here you might have some >> interrupts in your system which can only occur on some specific cores. >> I would suggest to try the following: >> - only boot enable in your dtb the cores with the same type than the boot >> core >> - check in your device tree which devices are assign to the ppi_cluster >> not available and disable them >> >> This kind of configuration will be tricky to handle so it will depend on >> which devices have interrupts that can only be fired on one cluster type. >> >> Sorry but I cannot right now check in the device tree and do those checks >> myself but if you do get the idea send back a mail :-) >> >> Cheers >> Bertrand >> >> > }; >> > >> > I've attached the device tree and include files just in case you'd like >> to take a look at those. >> > >> > Thanks so much for your help! I've been at this for weeks with very >> little progress. >> > >> > Cheers, >> > Brad >> > >> > >> > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis < >> Bertrand.Marquis@arm.com> wrote: >> > Hi Brad, >> > >> > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: >> > > >> > > Hello, >> > > >> > > I've been trying to get Xen to boot dom0 with my kernel for weeks on >> an rk3399 based board and thought I'd reach out for help. It looks like >> either Xen is not properly recreating the device tree or the interrupt >> controller is just failing. The hypervisor boots but falls to initramfs >> because it cannot find the root device (nvme on pcie). Any help would be >> greatly appreciated. Here is the complete boot log >> > >> > From the logs you have an issue with the interrupt controller and the >> fact that your NVME is behind PCIE and as such depends on ITS is probably >> not helping. >> > >> > I would suggest to try to boot on usb as root fs for a try. >> > >> > Also it could be useful to compare the device tree on xen and without >> xen to understand what is going on (using /proc/device-tree). >> > >> > Xen seems to be ok but Linux is not happy with interrupts and is >> showing several issues around this area on your logs. >> > Could you show us an extract of your device tree around the gic >> declaration ? >> > >> > Cheers >> > Bertrand >> > >> > >> > IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> > >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> > --000000000000d7c92805e39eae08 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+U29ycnkgZm9yIGFsbCBvZiB0aGUgZW1haWxzLCBidXQgaGVyZSBpcyAv cHJvYy9kZXZpY2UtdHJlZSB3aXRoIFhFTiBhbmQgd2l0aG91dCBYRU46PGRpdj48YnI+PC9kaXY+ PGRpdj53aXRoIFhlbjo8L2Rpdj48ZGl2Pjxicj48L2Rpdj48ZGl2PldpdGggWEVOPGJyPjxicj5x b3NAZmZhNjAwODAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaW50ZXJydXB0LXBhcmVudDxi cj5xb3NAZmZhOTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYWE4MDgwPGJy PnBtdS1jbG9jay1jb250cm9sbGVyQGZmNzUwMDAwIMKgd2F0Y2hkb2dAZmY4NDgwMDA8YnI+cHdt QGZmNDIwMDMwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHNlcmlhbEBmZjFiMDAwMDxicj52 Y2M1djAtdXNiLXJlZ3VsYXRvciDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhNzYwMDA8YnI+bW1jQGZl MzEwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGlvbW11QGZmOTAzZjAwPGJyPmkyY0Bm ZjExMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCAjc2l6ZS1jZWxsczxicj5zcGRpZkBm Zjg3MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhYjAwODA8YnI+aW50ZXJydXB0 LWNvbnRyb2xsZXIgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYWUwMDAwPGJyPnNlcmlhbEBmZjM3MDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNwaUBmZjIwMDAwMDxicj5xb3NAZmZhYzgwODAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgeGluMjRtPGJyPm5hbWUgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgaHlwZXJ2aXNvcjxicj52b3BAZmY4ZjAwMDAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgcHNjaTxicj52Y2MxMnYtZGNpbiDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoHZjYy0wdjk8YnI+Y2xvY2stY29udHJvbGxlckBmZjc2MDAwMCDCoCDCoCDCoGxl ZHM8YnI+cW9zQGZmYWI4MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmFhMDAw MDxicj5xb3NAZmZhNjAxMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaW9tbXVAZmY5MTQw MDA8YnI+cW9zQGZmYWMwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIG1vZGVsPGJyPmky Y0BmZjNkMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB2Y2M1djAtc3lzPGJyPmNwdXMg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdmlkZW8tY29kZWNAZmY2NTAw MDA8YnI+bWlwaUBmZjk2ODAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHRoZXJtYWwtem9u ZXM8YnI+aXNwMEBmZjkxMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGkyc0BmZjg5MDAw MDxicj5leHRlcm5hbC1nbWFjLWNsb2NrIMKgIMKgIMKgIMKgIMKgIMKgcmdhQGZmNjgwMDAwPGJy PmRtYS1jb250cm9sbGVyQGZmNmQwMDAwIMKgIMKgIMKgIMKgc3BpQGZmMWUwMDAwPGJyPnNwaUBm ZjFjMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpb21tdUBmZjY3MDgwMDxicj5xb3NA ZmZhNWMwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZHBAZmVjMDAwMDA8YnI+aW9tbXVA ZmY2NTA4MDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgb3BwLXRhYmxlMDxicj5zZXJpYWxAZmYx OTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBkaXNwbGF5LXN1YnN5c3RlbTxicj52b3BAZmY5 MDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTk4MDAwPGJyPmNob3NlbiDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpMmNAZmYxNjAwMDA8YnI+aTJjQGZm MTQwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmE3MDA4MDxicj5lZHBAZmY5 NzAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgZWZ1c2VAZmY2OTAwMDA8YnI+b3BwLXRh YmxlMSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzeXNjb25AZmY3NzAwMDA8YnI+aTJz QGZmOGEwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGhkbWktc291bmQ8YnI+dXNiQGZl M2MwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIG1tY0BmZTMyMDAwMDxicj5xb3NAZmZh NjAxODAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTU4MDAwPGJyPnVzYkBmZTgw MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpMmNAZmYxMjAwMDA8YnI+cW9zQGZmYWMw MDgwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHVzYkBmZTNlMDAwMDxicj5hbGlhc2VzIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYWQ4MDgwPGJyPnZjYzN2My1w Y2llLXJlZ3VsYXRvciDCoCDCoCDCoCDCoCDCoHNhcmFkY0BmZjEwMDAwMDxicj5xb3NAZmZhYTgw MDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdXNiQGZlM2EwMDAwPGJyPnBoeUBmZjgwMDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBvcHAtdGFibGUyPGJyPmhkbWlAZmY5NDAwMDAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhYzgwMDA8YnI+cW9zQGZmYWIwMDAwIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmFhMDA4MDxicj5pMmNAZmYzYzAwMDAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcmt0aW1lckBmZjg1MDAwMDxicj5pb21tdUBmZjkyNDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhZDAwMDA8YnI+Y29tcGF0aWJsZSDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwY2llQGY4MDAwMDAwPGJyPnNkaW8tcHdyc2VxIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgaTJjQGZmM2UwMDAwPGJyPnZpZGVvLWNvZGVjQGZm NjYwMDAwIMKgIMKgIMKgIMKgIMKgIG1lbW9yeUAyMDAwMDAwMDxicj50aW1lciDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGdwdUBmZjlhMDAwMDxicj5pb21tdUBmZjhmM2Yw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhNzQwMDA8YnI+bWlwaUBmZjk2MDAwMCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCNhZGRyZXNzLWNlbGxzPGJyPnN5c2NvbkBmZjMyMDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHBvd2VyLW1hbmFnZW1lbnRAZmYzMTAwMDA8YnI+c3Bp QGZmMWYwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHBpbmN0cmw8YnI+dmNjM3YzLXN5 cyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwd21AZmY0MjAwMDA8YnI+dmNjLXBoeS1y ZWd1bGF0b3IgwqAgwqAgwqAgwqAgwqAgwqAgwqB2Y2MxdjgtczA8YnI+c3BpQGZmMzUwMDAwIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGkyc0BmZjg4MDAwMDxicj5ldGhlcm5ldEBmZTMwMDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoGRtYS1jb250cm9sbGVyQGZmNmUwMDAwPGJyPnVzYkBmZTM4 MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzcGlAZmYxZDAwMDA8YnI+c2VyaWFsQGZm MTgwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgaW9tbXVAZmY2NjA0ODA8YnI+dXNiQGZlOTAw MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHB3bUBmZjQyMDAxMDxicj50c2FkY0BmZjI2 MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwaHlAZmY3YzAwMDA8YnI+bW1jQGZlMzMwMDAw IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHB3bUBmZjQyMDAyMDxicj5pMmNAZmYxMzAwMDAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaTJjQGZmMTUwMDAwPGJyPnFvc0BmZmE3MDAwMDxi cj48YnI+V2l0aG91dCBYZW48YnI+PGJyPnJvb3RAemFrdTovaG9tZS8uY2FjaGVuZ28jIGxzIC9w cm9jL2RldmljZS10cmVlPGJyPiYjMzk7I2FkZHJlc3MtY2VsbHMmIzM5OyDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCBxb3NAZmZhNWMwMDA8YnI+JiMzOTsjc2l6ZS1jZWxscyYjMzk7IMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYTYwMDgwPGJyPsKgYWxpYXNlcyDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhNjAxMDA8YnI+wqBjaG9zZW4gwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhNjAxODA8YnI+wqBjbG9jay1j b250cm9sbGVyQGZmNzYwMDAwIMKgIMKgIMKgIHFvc0BmZmE3MDAwMDxicj7CoGNvbXBhdGlibGUg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhNzAwODA8YnI+wqBjcHVzIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYTc0MDAwPGJyPsKg ZGlzcGxheS1zdWJzeXN0ZW0gwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTc2MDAwPGJyPsKg ZG1hLWNvbnRyb2xsZXJAZmY2ZDAwMDAgwqAgwqAgwqAgwqAgcW9zQGZmYTkwMDAwPGJyPsKgZG1h LWNvbnRyb2xsZXJAZmY2ZTAwMDAgwqAgwqAgwqAgwqAgcW9zQGZmYTk4MDAwPGJyPsKgZHBAZmVj MDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYWEwMDAwPGJyPsKgZWRw QGZmOTcwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYWEwMDgwPGJyPsKg ZWZ1c2VAZmY2OTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhYTgwMDA8YnI+ wqBldGhlcm5ldEBmZTMwMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhYTgwODA8YnI+ wqBleHRlcm5hbC1nbWFjLWNsb2NrIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmFiMDAwMDxicj7C oGdwdUBmZjlhMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFvc0BmZmFiMDA4MDxi cj7CoGhkbWktc291bmQgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhYjgw MDA8YnI+wqBoZG1pQGZmOTQwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmFj MDAwMDxicj7CoGkyY0BmZjExMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFvc0Bm ZmFjMDA4MDxicj7CoGkyY0BmZjEyMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFv c0BmZmFjODAwMDxicj7CoGkyY0BmZjEzMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oHFvc0BmZmFjODA4MDxicj7CoGkyY0BmZjE0MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoHFvc0BmZmFkMDAwMDxicj7CoGkyY0BmZjE1MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoHFvc0BmZmFkODA4MDxicj7CoGkyY0BmZjE2MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoHFvc0BmZmFlMDAwMDxicj7CoGkyY0BmZjNjMDAwMCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoHJnYUBmZjY4MDAwMDxicj7CoGkyY0BmZjNkMDAwMCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoHJrdGltZXJAZmY4NTAwMDA8YnI+wqBpMmNAZmYzZTAwMDAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzYXJhZGNAZmYxMDAwMDA8YnI+wqBpMnNAZmY4ODAwMDAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzZGlvLXB3cnNlcTxicj7CoGkyc0BmZjg5MDAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNlcmlhbEBmZjE4MDAwMDxicj7CoGkyc0Bm ZjhhMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNlcmlhbEBmZjE5MDAwMDxicj7C oGludGVycnVwdC1jb250cm9sbGVyQGZlZTAwMDAwIMKgIHNlcmlhbEBmZjFhMDAwMDxicj7CoGlu dGVycnVwdC1wYXJlbnQgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzZXJpYWxAZmYxYjAwMDA8YnI+ wqBpb21tdUBmZjY1MDgwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNlcmlhbEBmZjM3MDAw MDxicj7CoGlvbW11QGZmNjYwNDgwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgc3BkaWZAZmY4 NzAwMDA8YnI+wqBpb21tdUBmZjY3MDgwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHNwaUBm ZjFjMDAwMDxicj7CoGlvbW11QGZmOGYzZjAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgc3Bp QGZmMWQwMDAwPGJyPsKgaW9tbXVAZmY5MDNmMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBz cGlAZmYxZTAwMDA8YnI+wqBpb21tdUBmZjkxNDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oHNwaUBmZjFmMDAwMDxicj7CoGlvbW11QGZmOTI0MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgc3BpQGZmMjAwMDAwPGJyPsKgaXNwMEBmZjkxMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBzcGlAZmYzNTAwMDA8YnI+wqBsZWRzIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgc3lzY29uQGZmMzIwMDAwPGJyPsKgbWVtb3J5IMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgc3lzY29uQGZmNzcwMDAwPGJyPsKgbWlwaUBmZjk2MDAwMCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB0aGVybWFsLXpvbmVzPGJyPsKgbWlwaUBmZjk2ODAw MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB0aW1lcjxicj7CoG1tY0BmZTMxMDAwMCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHRzYWRjQGZmMjYwMDAwPGJyPsKgbW1jQGZlMzIwMDAw IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdXNiQGZlMzgwMDAwPGJyPsKgbW1jQGZlMzMw MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdXNiQGZlM2EwMDAwPGJyPsKgbW9kZWwg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdXNiQGZlM2MwMDAwPGJyPsKg bmFtZSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHVzYkBmZTNlMDAw MDxicj7CoG9wcC10YWJsZTAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB1c2JAZmU4 MDAwMDA8YnI+wqBvcHAtdGFibGUxIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdXNi QGZlOTAwMDAwPGJyPsKgb3BwLXRhYmxlMiDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oHZjYy0wdjk8YnI+wqBwY2llQGY4MDAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHZj Yy1waHktcmVndWxhdG9yPGJyPsKgcGh5QGZmN2MwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgdmNjMTJ2LWRjaW48YnI+wqBwaHlAZmY4MDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqB2Y2MxdjgtczA8YnI+wqBwaW5jdHJsIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIHZjYzN2My1wY2llLXJlZ3VsYXRvcjxicj7CoHBtdS1jbG9jay1jb250cm9sbGVy QGZmNzUwMDAwIMKgIHZjYzN2My1zeXM8YnI+wqBwbXVfYTUzIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIHZjYzV2MC1zeXM8YnI+wqBwbXVfYTcyIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIHZjYzV2MC11c2ItcmVndWxhdG9yPGJyPsKgcG93ZXItbWFuYWdl bWVudEBmZjMxMDAwMCDCoCDCoCDCoCB2aWRlby1jb2RlY0BmZjY1MDAwMDxicj7CoHBzY2kgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB2aWRlby1jb2RlY0BmZjY2MDAw MDxicj7CoHB3bUBmZjQyMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHZvcEBmZjhm MDAwMDxicj7CoHB3bUBmZjQyMDAxMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHZvcEBm ZjkwMDAwMDxicj7CoHB3bUBmZjQyMDAyMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHdh dGNoZG9nQGZmODQ4MDAwPGJyPsKgcHdtQGZmNDIwMDMwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgeGluMjRtPGJyPsKgcW9zQGZmYTU4MDAwPC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5X aXRoIFhFTjxicj48YnI+cW9zQGZmYTYwMDgwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGlu dGVycnVwdC1wYXJlbnQ8YnI+cW9zQGZmYTkwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IHFvc0BmZmFhODA4MDxicj5wbXUtY2xvY2stY29udHJvbGxlckBmZjc1MDAwMCDCoHdhdGNoZG9n QGZmODQ4MDAwPGJyPnB3bUBmZjQyMDAzMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBzZXJp YWxAZmYxYjAwMDA8YnI+dmNjNXYwLXVzYi1yZWd1bGF0b3IgwqAgwqAgwqAgwqAgwqAgcW9zQGZm YTc2MDAwPGJyPm1tY0BmZTMxMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpb21tdUBm ZjkwM2YwMDxicj5pMmNAZmYxMTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgI3NpemUt Y2VsbHM8YnI+c3BkaWZAZmY4NzAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYWIw MDgwPGJyPmludGVycnVwdC1jb250cm9sbGVyIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmFlMDAwMDxi cj5zZXJpYWxAZmYzNzAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzcGlAZmYyMDAwMDA8YnI+ cW9zQGZmYWM4MDgwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHhpbjI0bTxicj5uYW1lIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGh5cGVydmlzb3I8YnI+dm9wQGZm OGYwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHBzY2k8YnI+dmNjMTJ2LWRjaW4gwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB2Y2MtMHY5PGJyPmNsb2NrLWNvbnRyb2xsZXJAZmY3 NjAwMDAgwqAgwqAgwqBsZWRzPGJyPnFvc0BmZmFiODAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBxb3NAZmZhYTAwMDA8YnI+cW9zQGZmYTYwMTAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIGlvbW11QGZmOTE0MDAwPGJyPnFvc0BmZmFjMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCBtb2RlbDxicj5pMmNAZmYzZDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdmNj NXYwLXN5czxicj5jcHVzIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHZp ZGVvLWNvZGVjQGZmNjUwMDAwPGJyPm1pcGlAZmY5NjgwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqB0aGVybWFsLXpvbmVzPGJyPmlzcDBAZmY5MTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqBpMnNAZmY4OTAwMDA8YnI+ZXh0ZXJuYWwtZ21hYy1jbG9jayDCoCDCoCDCoCDCoCDCoCDC oHJnYUBmZjY4MDAwMDxicj5kbWEtY29udHJvbGxlckBmZjZkMDAwMCDCoCDCoCDCoCDCoHNwaUBm ZjFlMDAwMDxicj5zcGlAZmYxYzAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaW9tbXVA ZmY2NzA4MDA8YnI+cW9zQGZmYTVjMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGRwQGZl YzAwMDAwPGJyPmlvbW11QGZmNjUwODAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIG9wcC10YWJs ZTA8YnI+c2VyaWFsQGZmMTkwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgZGlzcGxheS1zdWJz eXN0ZW08YnI+dm9wQGZmOTAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmE5 ODAwMDxicj5jaG9zZW4gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaTJjQGZm MTYwMDAwPGJyPmkyY0BmZjE0MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZh NzAwODA8YnI+ZWRwQGZmOTcwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGVmdXNlQGZm NjkwMDAwPGJyPm9wcC10YWJsZTEgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgc3lzY29u QGZmNzcwMDAwPGJyPmkyc0BmZjhhMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBoZG1p LXNvdW5kPGJyPnVzYkBmZTNjMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBtbWNAZmUz MjAwMDA8YnI+cW9zQGZmYTYwMTgwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0BmZmE1 ODAwMDxicj51c2JAZmU4MDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgaTJjQGZmMTIw MDAwPGJyPnFvc0BmZmFjMDA4MCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB1c2JAZmUzZTAw MDA8YnI+YWxpYXNlcyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFvc0BmZmFk ODA4MDxicj52Y2MzdjMtcGNpZS1yZWd1bGF0b3IgwqAgwqAgwqAgwqAgwqBzYXJhZGNAZmYxMDAw MDA8YnI+cW9zQGZmYWE4MDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHVzYkBmZTNhMDAw MDxicj5waHlAZmY4MDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgb3BwLXRhYmxlMjxi cj5oZG1pQGZmOTQwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYWM4MDAwPGJy PnFvc0BmZmFiMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBxb3NAZmZhYTAwODA8YnI+ aTJjQGZmM2MwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHJrdGltZXJAZmY4NTAwMDA8 YnI+aW9tbXVAZmY5MjQwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYWQwMDAwPGJy PmNvbXBhdGlibGUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcGNpZUBmODAwMDAwMDxi cj5zZGlvLXB3cnNlcSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGkyY0BmZjNlMDAwMDxi cj52aWRlby1jb2RlY0BmZjY2MDAwMCDCoCDCoCDCoCDCoCDCoCBtZW1vcnlAMjAwMDAwMDA8YnI+ dGltZXIgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBncHVAZmY5YTAwMDA8 YnI+aW9tbXVAZmY4ZjNmMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTc0MDAwPGJy Pm1pcGlAZmY5NjAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAjYWRkcmVzcy1jZWxsczxi cj5zeXNjb25AZmYzMjAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBwb3dlci1tYW5hZ2VtZW50 QGZmMzEwMDAwPGJyPnNwaUBmZjFmMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwaW5j dHJsPGJyPnZjYzN2My1zeXMgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcHdtQGZmNDIw MDAwPGJyPnZjYy1waHktcmVndWxhdG9yIMKgIMKgIMKgIMKgIMKgIMKgIMKgdmNjMXY4LXMwPGJy PnNwaUBmZjM1MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBpMnNAZmY4ODAwMDA8YnI+ ZXRoZXJuZXRAZmUzMDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqBkbWEtY29udHJvbGxlckBmZjZl MDAwMDxicj51c2JAZmUzODAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgc3BpQGZmMWQw MDAwPGJyPnNlcmlhbEBmZjE4MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGlvbW11QGZmNjYw NDgwPGJyPnVzYkBmZTkwMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwd21AZmY0MjAw MTA8YnI+dHNhZGNAZmYyNjAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcGh5QGZmN2MwMDAw PGJyPm1tY0BmZTMzMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBwd21AZmY0MjAwMjA8 YnI+aTJjQGZmMTMwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIGkyY0BmZjE1MDAwMDxi cj5xb3NAZmZhNzAwMDA8YnI+PGJyPldpdGhvdXQgWGVuPGJyPjxicj5yb290QHpha3U6L2hvbWUv LmNhY2hlbmdvIyBscyAvcHJvYy9kZXZpY2UtdHJlZTxicj4mIzM5OyNhZGRyZXNzLWNlbGxzJiMz OTsgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTVjMDAwPGJyPiYjMzk7I3NpemUtY2Vs bHMmIzM5OyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFvc0BmZmE2MDA4MDxicj7CoGFs aWFzZXMgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgcW9zQGZmYTYwMTAwPGJy PsKgY2hvc2VuIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYTYw MTgwPGJyPsKgY2xvY2stY29udHJvbGxlckBmZjc2MDAwMCDCoCDCoCDCoCBxb3NAZmZhNzAwMDA8 YnI+wqBjb21wYXRpYmxlIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcW9zQGZmYTcw MDgwPGJyPsKgY3B1cyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFv c0BmZmE3NDAwMDxicj7CoGRpc3BsYXktc3Vic3lzdGVtIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFv c0BmZmE3NjAwMDxicj7CoGRtYS1jb250cm9sbGVyQGZmNmQwMDAwIMKgIMKgIMKgIMKgIHFvc0Bm ZmE5MDAwMDxicj7CoGRtYS1jb250cm9sbGVyQGZmNmUwMDAwIMKgIMKgIMKgIMKgIHFvc0BmZmE5 ODAwMDxicj7CoGRwQGZlYzAwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHFvc0Bm ZmFhMDAwMDxicj7CoGVkcEBmZjk3MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHFv c0BmZmFhMDA4MDxicj7CoGVmdXNlQGZmNjkwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg cW9zQGZmYWE4MDAwPGJyPsKgZXRoZXJuZXRAZmUzMDAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg cW9zQGZmYWE4MDgwPGJyPsKgZXh0ZXJuYWwtZ21hYy1jbG9jayDCoCDCoCDCoCDCoCDCoCDCoCBx b3NAZmZhYjAwMDA8YnI+wqBncHVAZmY5YTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBxb3NAZmZhYjAwODA8YnI+wqBoZG1pLXNvdW5kIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgcW9zQGZmYWI4MDAwPGJyPsKgaGRtaUBmZjk0MDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCBxb3NAZmZhYzAwMDA8YnI+wqBpMmNAZmYxMTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqBxb3NAZmZhYzAwODA8YnI+wqBpMmNAZmYxMjAwMDAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqBxb3NAZmZhYzgwMDA8YnI+wqBpMmNAZmYxMzAwMDAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhYzgwODA8YnI+wqBpMmNAZmYxNDAwMDAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhZDAwMDA8YnI+wqBpMmNAZmYxNTAwMDAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhZDgwODA8YnI+wqBpMmNAZmYxNjAwMDAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBxb3NAZmZhZTAwMDA8YnI+wqBpMmNAZmYzYzAwMDAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqByZ2FAZmY2ODAwMDA8YnI+wqBpMmNAZmYzZDAw MDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBya3RpbWVyQGZmODUwMDAwPGJyPsKgaTJj QGZmM2UwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgc2FyYWRjQGZmMTAwMDAwPGJy PsKgaTJzQGZmODgwMDAwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgc2Rpby1wd3JzZXE8 YnI+wqBpMnNAZmY4OTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzZXJpYWxAZmYx ODAwMDA8YnI+wqBpMnNAZmY4YTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBzZXJp YWxAZmYxOTAwMDA8YnI+wqBpbnRlcnJ1cHQtY29udHJvbGxlckBmZWUwMDAwMCDCoCBzZXJpYWxA ZmYxYTAwMDA8YnI+wqBpbnRlcnJ1cHQtcGFyZW50IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgc2Vy aWFsQGZmMWIwMDAwPGJyPsKgaW9tbXVAZmY2NTA4MDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBzZXJpYWxAZmYzNzAwMDA8YnI+wqBpb21tdUBmZjY2MDQ4MCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoHNwZGlmQGZmODcwMDAwPGJyPsKgaW9tbXVAZmY2NzA4MDAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqBzcGlAZmYxYzAwMDA8YnI+wqBpb21tdUBmZjhmM2YwMCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoHNwaUBmZjFkMDAwMDxicj7CoGlvbW11QGZmOTAzZjAwIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgc3BpQGZmMWUwMDAwPGJyPsKgaW9tbXVAZmY5MTQwMDAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqBzcGlAZmYxZjAwMDA8YnI+wqBpb21tdUBmZjkyNDAwMCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoHNwaUBmZjIwMDAwMDxicj7CoGlzcDBAZmY5MTAwMDAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgc3BpQGZmMzUwMDAwPGJyPsKgbGVkcyDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHN5c2NvbkBmZjMyMDAwMDxicj7CoG1lbW9yeSDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHN5c2NvbkBmZjc3MDAwMDxicj7C oG1pcGlAZmY5NjAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdGhlcm1hbC16b25lczxi cj7CoG1pcGlAZmY5NjgwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgdGltZXI8YnI+wqBt bWNAZmUzMTAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB0c2FkY0BmZjI2MDAwMDxi cj7CoG1tY0BmZTMyMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHVzYkBmZTM4MDAw MDxicj7CoG1tY0BmZTMzMDAwMCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoHVzYkBmZTNh MDAwMDxicj7CoG1vZGVsIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIHVz YkBmZTNjMDAwMDxicj7CoG5hbWUgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqB1c2JAZmUzZTAwMDA8YnI+wqBvcHAtdGFibGUwIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgdXNiQGZlODAwMDAwPGJyPsKgb3BwLXRhYmxlMSDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoHVzYkBmZTkwMDAwMDxicj7CoG9wcC10YWJsZTIgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqB2Y2MtMHY5PGJyPsKgcGNpZUBmODAwMDAwMCDCoCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCB2Y2MtcGh5LXJlZ3VsYXRvcjxicj7CoHBoeUBmZjdjMDAwMCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoHZjYzEydi1kY2luPGJyPsKgcGh5QGZmODAwMDAwIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdmNjMXY4LXMwPGJyPsKgcGluY3RybCDCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB2Y2MzdjMtcGNpZS1yZWd1bGF0b3I8YnI+wqBwbXUt Y2xvY2stY29udHJvbGxlckBmZjc1MDAwMCDCoCB2Y2MzdjMtc3lzPGJyPsKgcG11X2E1MyDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB2Y2M1djAtc3lzPGJyPsKgcG11X2E3MiDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCB2Y2M1djAtdXNiLXJlZ3VsYXRvcjxi cj7CoHBvd2VyLW1hbmFnZW1lbnRAZmYzMTAwMDAgwqAgwqAgwqAgdmlkZW8tY29kZWNAZmY2NTAw MDA8YnI+wqBwc2NpIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgdmlk ZW8tY29kZWNAZmY2NjAwMDA8YnI+wqBwd21AZmY0MjAwMDAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqB2b3BAZmY4ZjAwMDA8YnI+wqBwd21AZmY0MjAwMTAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqB2b3BAZmY5MDAwMDA8YnI+wqBwd21AZmY0MjAwMjAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqB3YXRjaGRvZ0BmZjg0ODAwMDxicj7CoHB3bUBmZjQyMDAzMCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoHhpbjI0bTxicj7CoHFvc0BmZmE1ODAwMDxicj48L2Rpdj48 L2Rpdj48YnI+PGRpdiBjbGFzcz0iZ21haWxfcXVvdGUiPjxkaXYgZGlyPSJsdHIiIGNsYXNzPSJn bWFpbF9hdHRyIj5PbiBUdWUsIEp1bCAxMiwgMjAyMiBhdCAxMToyNCBBTSBCcmFkIENodXJjaHdl bGwgJmx0OzxhIGhyZWY9Im1haWx0bzpicmFkQGNhY2hlbmdvLmNvbSI+YnJhZEBjYWNoZW5nby5j b208L2E+Jmd0OyB3cm90ZTo8YnI+PC9kaXY+PGJsb2NrcXVvdGUgY2xhc3M9ImdtYWlsX3F1b3Rl IiBzdHlsZT0ibWFyZ2luOjBweCAwcHggMHB4IDAuOGV4O2JvcmRlci1sZWZ0OjFweCBzb2xpZCBy Z2IoMjA0LDIwNCwyMDQpO3BhZGRpbmctbGVmdDoxZXgiPjxkaXYgZGlyPSJsdHIiPkhpIEJlcnRy YW5kLDxkaXY+PGJyPjwvZGl2PjxkaXY+SSBiZWxpZXZlIEkgdW5kZXJzdGFuZCwgYnV0IGp1c3Qg dG8gY2xhcmlmeSwgc2hvdWxkIEkgbGVhdmUgdGhlIHBwaS1wYXJ0aXRpb25zIGJsb2NrIGluIHJr MzM5OS5kdHNpIGFzIGlzIGFuZCBkaXNhYmxlIHRoZSBsaXR0bGUgY29yZXMsIG9yIHNob3VsZCBJ IGFsc28gbW9kaWZ5IHRoYXQgYmxvY2s/PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj5CcmFkPC9k aXY+PC9kaXY+PGJyPjxkaXYgY2xhc3M9ImdtYWlsX3F1b3RlIj48ZGl2IGRpcj0ibHRyIiBjbGFz cz0iZ21haWxfYXR0ciI+T24gVHVlLCBKdWwgMTIsIDIwMjIgYXQgMTE6MTEgQU0gQmVydHJhbmQg TWFycXVpcyAmbHQ7PGEgaHJlZj0ibWFpbHRvOkJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbSIgdGFy Z2V0PSJfYmxhbmsiPkJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbTwvYT4mZ3Q7IHdyb3RlOjxicj48 L2Rpdj48YmxvY2txdW90ZSBjbGFzcz0iZ21haWxfcXVvdGUiIHN0eWxlPSJtYXJnaW46MHB4IDBw eCAwcHggMC44ZXg7Ym9yZGVyLWxlZnQ6MXB4IHNvbGlkIHJnYigyMDQsMjA0LDIwNCk7cGFkZGlu Zy1sZWZ0OjFleCI+SGkgQnJhZCw8YnI+DQo8YnI+DQomZ3Q7IE9uIDEyIEp1bCAyMDIyLCBhdCAx Njo1OSwgQnJhZCBDaHVyY2h3ZWxsICZsdDs8YSBocmVmPSJtYWlsdG86YnJhZEBjYWNoZW5nby5j b20iIHRhcmdldD0iX2JsYW5rIj5icmFkQGNhY2hlbmdvLmNvbTwvYT4mZ3Q7IHdyb3RlOjxicj4N CiZndDs8YnI+DQomZ3Q7IEhpIEJlcnRyYW5kLDxicj4NCiZndDs8YnI+DQomZ3Q7IFRoYW5rcyBz byBtdWNoIGZvciB0aGUgcXVpY2sgcmVzcG9uc2UhPGJyPg0KJmd0Ozxicj4NCiZndDsgSSBzaG91 bGQgaGF2ZSBtZW50aW9uZWQgcHJldmlvdXNseSB0aGF0IHRoaXMgZGV2aWNlIHRyZWUgYW5kIGtl cm5lbCBJbWFnZSAoNS4xNS4xNikgZG9lcyBib290IHByb3Blcmx5IHdpdGggdGhlIHJvb3RmcyB3 aXRob3V0IFhFTi4gVGhlIGludGVycnVwdCBlcnJvcnMgYXJlIG9ubHkgcHJlc2VudCB3aGVuIGJv b3Rpbmcgd2l0aCBYRU4uPGJyPg0KJmd0Ozxicj4NCiZndDsgVGhlc2UgYXJlIGN1c3RvbSBib2Fy ZHMgYW5kIHRoZXkgZG8gaGF2ZSB1c2IgYywgaG93ZXZlciB3ZSBhcmUgdW5hYmxlIHRvIGJvb3Qg ZnJvbSB1c2IgYXMgaXQgZG9lc24mIzM5O3QgcmVjZWl2ZSBwb3dlci7CoCBXZSBjdXJyZW50bHkg b25seSB1c2UgdGhlIHVzYiB0byBmbGFzaCB1LWJvb3QgdG8gc3BpIHdoaWNoIHJlcXVpcmVzIHVz IHRvIHVzZSBhIHNlcGFyYXRlIHBvd2VyIGFkYXB0ZXIuIFRoZXNlIGJvYXJkcyBnZXQgcG93ZXIg YW5kIG5ldHdvcmtpbmcgdGhyb3VnaCBhIGN1c3RvbSBiYWNrcGxhbmUgYW5kIGludGVyZmFjZSB3 aXRoIHRoZSBiYWNrcGxhbmUgdmlhIGEgc2F0YSBzdHlsZSBqdXN0aWNlIChJJiMzOTttIG5vdCBz dXJlIHdoYXQgdGhlIHByb3BlciB0ZXJtaW5vbG9neSB3b3VsZCBiZSBoZXJlKS48YnI+DQomZ3Q7 PGJyPg0KJmd0OyBTaW5jZSBJIGNhbm5vdCBib290IHRvIHJvb3RmcyB3aXRoIFhFTiwgSSYjMzk7 bSB1bmFibGUgdG8gc2hvdyB0aGUgZGV2aWNlIHRyZWUgdGhlcmUuIFRoZSBvbmx5IGJpdCB0aGF0 IEkgYWRkZWQgdG8gYWNjb21tb2RhdGUgWEVOIGlzIHRoaXMgYml0IGhlcmU6PGJyPg0KJmd0Ozxi cj4NCiZndDsgY2hvc2VuIHs8YnI+DQomZ3Q7wqAgwqAgwqBzdGRvdXQtcGF0aCA9ICZxdW90O3Nl cmlhbDI6MTUwMDAwMG44JnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoGJvb3RhcmdzID0gJnF1b3Q7 aG1wLXVuc2FmZT10cnVlJnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoHhlbixkb20wLWJvb3Rhcmdz ID0gJnF1b3Q7Y29uc29sZT1odmMwIGVhcmx5cHJpbnRrPXhlbiBjbGtfaWdub3JlX3VudXNlZCBy b290PS9kZXYvbnZtZTBuMXAyIHJ3IGluaXQ9L3NiaW4vaW5pdCByb290d2FpdCByb290ZnN0eXBl PWV4dDQgaWdub3JlX2xvZ2xldmVsJnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoG1vZHVsZXMgezxi cj4NCiZndDvCoCDCoCDCoCDCoCDCoCNhZGRyZXNzLWNlbGxzID0gJmx0OzImZ3Q7Ozxicj4NCiZn dDvCoCDCoCDCoCDCoCDCoCNzaXplLWNlbGxzID0gJmx0OzImZ3Q7Ozxicj4NCiZndDs8YnI+DQom Z3Q7wqAgwqAgwqAgwqAgwqBtb2R1bGVAMSB7PGJyPg0KJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg Y29tcGF0aWJsZSA9ICZxdW90O3hlbixsaW51eC16aW1hZ2UmcXVvdDssICZxdW90O3hlbixtdWx0 aWJvb3QtbW9kdWxlJnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoHJlZyA9ICZs dDsweDAgMHgwM0Y4MDAwMCAweDAgMHgwMWFhODAwOCZndDs7PGJyPg0KJmd0O8KgIMKgIMKgIMKg IMKgfTs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqBtb2R1bGVAMiB7PGJyPg0KJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgY29tcGF0aWJsZSA9ICZxdW90O3hlbixsaW51eC1pbml0cmQmcXVvdDssICZx dW90O3hlbixtdWx0aWJvb3QtbW9kdWxlJnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDC oCDCoHJlZyA9ICZsdDsweDAgMHgwNjAwMDAwMCAweDAgMHgwMjAwMDAwMCZndDs7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgIMKgfTs8YnI+DQomZ3Q7wqAgwqAgwqB9Ozxicj4NCiZndDs8YnI+DQomZ3Q7 IH07PGJyPg0KJmd0Ozxicj4NCiZndDsgVGhlIGdpYyBkZWNsYXJhdGlvbiBpcyBpbiB0aGUgdmFu aWxsYSByazMzOTkuZHRzaSBmaWxlIGFuZCBoYXNuJiMzOTt0IGJlZW4gbW9kaWZpZWQ6PGJyPg0K Jmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoGdpYzogaW50ZXJydXB0LWNvbnRyb2xsZXJAZmVl MDAwMDAgezxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoGNvbXBhdGlibGUgPSAm cXVvdDthcm0sZ2ljLXYzJnF1b3Q7Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCNpbnRlcnJ1cHQtY2VsbHMgPSAmbHQ7NCZndDs7PGJyPg0KJmd0O8KgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgI2FkZHJlc3MtY2VsbHMgPSAmbHQ7MiZndDs7PGJyPg0KJmd0O8KgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgI3NpemUtY2VsbHMgPSAmbHQ7MiZndDs7PGJyPg0KJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgcmFuZ2VzOzxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoGludGVycnVwdC1jb250cm9sbGVyOzxicj4NCiZndDs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqByZWcgPSAmbHQ7MHgwIDB4ZmVlMDAwMDAgMCAweDEwMDAwJmd0OywgLyog R0lDRCAqLzxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCZsdDsw eDAgMHhmZWYwMDAwMCAwIDB4YzAwMDAmZ3Q7LCAvKiBHSUNSICovPGJyPg0KJmd0O8KgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgJmx0OzB4MCAweGZmZjAwMDAwIDAgMHgxMDAwMCZn dDssIC8qIEdJQ0MgKi88YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAmbHQ7MHgwIDB4ZmZmMTAwMDAgMCAweDEwMDAwJmd0OywgLyogR0lDSCAqLzxicj4NCiZndDvC oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCZsdDsweDAgMHhmZmYyMDAwMCAwIDB4 MTAwMDAmZ3Q7OyAvKiBHSUNWICovPGJyPg0KJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg aW50ZXJydXB0cyA9ICZsdDtHSUNfUFBJIDkgSVJRX1RZUEVfTEVWRUxfSElHSCAwJmd0Ozs8YnI+ DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBpdHM6IGludGVycnVwdC1jb250cm9sbGVy QGZlZTIwMDAwIHs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqBjb21wYXRpYmxlID0gJnF1b3Q7YXJtLGdpYy12My1pdHMmcXVvdDs7PGJyPg0KJmd0O8KgIMKg IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgbXNpLWNvbnRyb2xsZXI7PGJyPg0KJmd0 O8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgI21zaS1jZWxscyA9ICZsdDsx Jmd0Ozs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqByZWcg PSAmbHQ7MHgwIDB4ZmVlMjAwMDAgMHgwIDB4MjAwMDAmZ3Q7Ozxicj4NCiZndDvCoCDCoCDCoCDC oCDCoCDCoCDCoCDCoCDCoH07PGJyPg0KJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDC oCDCoCDCoHBwaS1wYXJ0aXRpb25zIHs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAg wqAgwqAgwqAgwqAgwqBwcGlfY2x1c3RlcjA6IGludGVycnVwdC1wYXJ0aXRpb24tMCB7PGJyPg0K Jmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgYWZm aW5pdHkgPSAmbHQ7JmFtcDtjcHVfbDAgJmFtcDtjcHVfbDEgJmFtcDtjcHVfbDIgJmFtcDtjcHVf bDMmZ3Q7Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoH07 PGJyPg0KJmd0Ozxicj4NCiZndDvCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC oHBwaV9jbHVzdGVyMTogaW50ZXJydXB0LXBhcnRpdGlvbi0xIHs8YnI+DQomZ3Q7wqAgwqAgwqAg wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqBhZmZpbml0eSA9ICZsdDsm YW1wO2NwdV9iMCAmYW1wO2NwdV9iMSZndDs7PGJyPg0KJmd0O8KgIMKgIMKgIMKgIMKgIMKgIMKg IMKgIMKgIMKgIMKgIMKgIMKgfTs8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqB9 Ozxicj4NCjxicj4NClhlbiBpcyBub3Qgc3VwcG9ydGluZyBQUEkgcGFydGl0aW9ucy48YnI+DQpJ IGFsc28gc2F3IHRoYXQgeW91ciBib290aW5nIHVzaW5nIFNNUCB1bnNhZmUgc28gYWxsIGNvcmUg YXJlIGVuYWJsZWQgYnkgWGVuLjxicj4NCjxicj4NClJpZ2h0IG5vdyBiaWcvbGl0dGxlIGlzIG5v dCBzdXBwb3J0ZWQgYnkgWGVuIGFuZCBoZXJlIHlvdSBtaWdodCBoYXZlIHNvbWUgaW50ZXJydXB0 cyBpbiB5b3VyIHN5c3RlbSB3aGljaCBjYW4gb25seSBvY2N1ciBvbiBzb21lIHNwZWNpZmljIGNv cmVzLjxicj4NCkkgd291bGQgc3VnZ2VzdCB0byB0cnkgdGhlIGZvbGxvd2luZzo8YnI+DQotIG9u bHkgYm9vdCBlbmFibGUgaW4geW91ciBkdGIgdGhlIGNvcmVzIHdpdGggdGhlIHNhbWUgdHlwZSB0 aGFuIHRoZSBib290IGNvcmU8YnI+DQotIGNoZWNrIGluIHlvdXIgZGV2aWNlIHRyZWUgd2hpY2gg ZGV2aWNlcyBhcmUgYXNzaWduIHRvIHRoZSBwcGlfY2x1c3RlciBub3QgYXZhaWxhYmxlIGFuZCBk aXNhYmxlIHRoZW08YnI+DQo8YnI+DQpUaGlzIGtpbmQgb2YgY29uZmlndXJhdGlvbiB3aWxsIGJl IHRyaWNreSB0byBoYW5kbGUgc28gaXQgd2lsbCBkZXBlbmQgb24gd2hpY2ggZGV2aWNlcyBoYXZl IGludGVycnVwdHMgdGhhdCBjYW4gb25seSBiZSBmaXJlZCBvbiBvbmUgY2x1c3RlciB0eXBlLjxi cj4NCjxicj4NClNvcnJ5IGJ1dCBJIGNhbm5vdCByaWdodCBub3cgY2hlY2sgaW4gdGhlIGRldmlj ZSB0cmVlIGFuZCBkbyB0aG9zZSBjaGVja3MgbXlzZWxmIGJ1dCBpZiB5b3UgZG8gZ2V0IHRoZSBp ZGVhIHNlbmQgYmFjayBhIG1haWwgOi0pPGJyPg0KPGJyPg0KQ2hlZXJzPGJyPg0KQmVydHJhbmQ8 YnI+DQo8YnI+DQomZ3Q7wqAgwqAgwqAgwqAgwqB9Ozxicj4NCiZndDs8YnI+DQomZ3Q7IEkmIzM5 O3ZlIGF0dGFjaGVkIHRoZSBkZXZpY2UgdHJlZSBhbmQgaW5jbHVkZSBmaWxlcyBqdXN0IGluIGNh c2UgeW91JiMzOTtkIGxpa2UgdG8gdGFrZSBhIGxvb2sgYXQgdGhvc2UuPGJyPg0KJmd0Ozxicj4N CiZndDsgVGhhbmtzIHNvIG11Y2ggZm9yIHlvdXIgaGVscCEgSSYjMzk7dmUgYmVlbiBhdCB0aGlz IGZvciB3ZWVrcyB3aXRoIHZlcnkgbGl0dGxlIHByb2dyZXNzLjxicj4NCiZndDs8YnI+DQomZ3Q7 IENoZWVycyw8YnI+DQomZ3Q7IEJyYWQ8YnI+DQomZ3Q7PGJyPg0KJmd0Ozxicj4NCiZndDsgT24g VHVlLCBKdWwgMTIsIDIwMjIgYXQgMTA6MDUgQU0gQmVydHJhbmQgTWFycXVpcyAmbHQ7PGEgaHJl Zj0ibWFpbHRvOkJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbSIgdGFyZ2V0PSJfYmxhbmsiPkJlcnRy YW5kLk1hcnF1aXNAYXJtLmNvbTwvYT4mZ3Q7IHdyb3RlOjxicj4NCiZndDsgSGkgQnJhZCw8YnI+ DQomZ3Q7PGJyPg0KJmd0OyAmZ3Q7IE9uIDExIEp1bCAyMDIyLCBhdCAxOTozOCwgQnJhZCBDaHVy Y2h3ZWxsICZsdDs8YSBocmVmPSJtYWlsdG86YnJhZEBjYWNoZW5nby5jb20iIHRhcmdldD0iX2Js YW5rIj5icmFkQGNhY2hlbmdvLmNvbTwvYT4mZ3Q7IHdyb3RlOjxicj4NCiZndDsgJmd0Ozxicj4N CiZndDsgJmd0OyBIZWxsbyw8YnI+DQomZ3Q7ICZndDs8YnI+DQomZ3Q7ICZndDsgSSYjMzk7dmUg YmVlbiB0cnlpbmcgdG8gZ2V0IFhlbiB0byBib290IGRvbTAgd2l0aCBteSBrZXJuZWwgZm9yIHdl ZWtzIG9uIGFuIHJrMzM5OSBiYXNlZCBib2FyZCBhbmQgdGhvdWdodCBJJiMzOTtkIHJlYWNoIG91 dCBmb3IgaGVscC4gSXQgbG9va3MgbGlrZSBlaXRoZXIgWGVuIGlzIG5vdCBwcm9wZXJseSByZWNy ZWF0aW5nIHRoZSBkZXZpY2UgdHJlZSBvciB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgaXMganVz dCBmYWlsaW5nLiBUaGUgaHlwZXJ2aXNvciBib290cyBidXQgZmFsbHMgdG8gaW5pdHJhbWZzIGJl Y2F1c2UgaXQgY2Fubm90IGZpbmQgdGhlIHJvb3QgZGV2aWNlIChudm1lIG9uIHBjaWUpLiBBbnkg aGVscCB3b3VsZCBiZSBncmVhdGx5IGFwcHJlY2lhdGVkLiBIZXJlIGlzIHRoZSBjb21wbGV0ZSBi b290IGxvZzxicj4NCiZndDs8YnI+DQomZ3Q7IEZyb20gdGhlIGxvZ3MgeW91IGhhdmUgYW4gaXNz dWUgd2l0aCB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXIgYW5kIHRoZSBmYWN0IHRoYXQgeW91ciBO Vk1FIGlzIGJlaGluZCBQQ0lFIGFuZCBhcyBzdWNoIGRlcGVuZHMgb24gSVRTIGlzIHByb2JhYmx5 IG5vdCBoZWxwaW5nLjxicj4NCiZndDs8YnI+DQomZ3Q7IEkgd291bGQgc3VnZ2VzdCB0byB0cnkg dG8gYm9vdCBvbiB1c2IgYXMgcm9vdCBmcyBmb3IgYSB0cnkuPGJyPg0KJmd0Ozxicj4NCiZndDsg QWxzbyBpdCBjb3VsZCBiZSB1c2VmdWwgdG8gY29tcGFyZSB0aGUgZGV2aWNlIHRyZWUgb24geGVu IGFuZCB3aXRob3V0IHhlbiB0byB1bmRlcnN0YW5kIHdoYXQgaXMgZ29pbmcgb24gKHVzaW5nIC9w cm9jL2RldmljZS10cmVlKS48YnI+DQomZ3Q7PGJyPg0KJmd0OyBYZW4gc2VlbXMgdG8gYmUgb2sg YnV0IExpbnV4IGlzIG5vdCBoYXBweSB3aXRoIGludGVycnVwdHMgYW5kIGlzIHNob3dpbmcgc2V2 ZXJhbCBpc3N1ZXMgYXJvdW5kIHRoaXMgYXJlYSBvbiB5b3VyIGxvZ3MuPGJyPg0KJmd0OyBDb3Vs ZCB5b3Ugc2hvdyB1cyBhbiBleHRyYWN0IG9mIHlvdXIgZGV2aWNlIHRyZWUgYXJvdW5kIHRoZSBn aWMgZGVjbGFyYXRpb24gPzxicj4NCiZndDs8YnI+DQomZ3Q7IENoZWVyczxicj4NCiZndDsgQmVy dHJhbmQ8YnI+DQomZ3Q7PGJyPg0KJmd0Ozxicj4NCiZndDsgSU1QT1JUQU5UIE5PVElDRTogVGhl IGNvbnRlbnRzIG9mIHRoaXMgZW1haWwgYW5kIGFueSBhdHRhY2htZW50cyBhcmUgY29uZmlkZW50 aWFsIGFuZCBtYXkgYWxzbyBiZSBwcml2aWxlZ2VkLiBJZiB5b3UgYXJlIG5vdCB0aGUgaW50ZW5k ZWQgcmVjaXBpZW50LCBwbGVhc2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRpYXRlbHkgYW5kIGRv IG5vdCBkaXNjbG9zZSB0aGUgY29udGVudHMgdG8gYW55IG90aGVyIHBlcnNvbiwgdXNlIGl0IGZv ciBhbnkgcHVycG9zZSwgb3Igc3RvcmUgb3IgY29weSB0aGUgaW5mb3JtYXRpb24gaW4gYW55IG1l ZGl1bS4gVGhhbmsgeW91Ljxicj4NCiZndDsgJmx0O3JrMzM5OS16YWt1LmR0cyZndDsmbHQ7cmsz Mzk5LXpha3UuZHRzaSZndDsmbHQ7cmszMzk5LmR0c2kmZ3Q7PGJyPg0KPGJyPg0KSU1QT1JUQU5U IE5PVElDRTogVGhlIGNvbnRlbnRzIG9mIHRoaXMgZW1haWwgYW5kIGFueSBhdHRhY2htZW50cyBh cmUgY29uZmlkZW50aWFsIGFuZCBtYXkgYWxzbyBiZSBwcml2aWxlZ2VkLiBJZiB5b3UgYXJlIG5v dCB0aGUgaW50ZW5kZWQgcmVjaXBpZW50LCBwbGVhc2Ugbm90aWZ5IHRoZSBzZW5kZXIgaW1tZWRp YXRlbHkgYW5kIGRvIG5vdCBkaXNjbG9zZSB0aGUgY29udGVudHMgdG8gYW55IG90aGVyIHBlcnNv biwgdXNlIGl0IGZvciBhbnkgcHVycG9zZSwgb3Igc3RvcmUgb3IgY29weSB0aGUgaW5mb3JtYXRp b24gaW4gYW55IG1lZGl1bS4gVGhhbmsgeW91Ljxicj4NCjwvYmxvY2txdW90ZT48L2Rpdj4NCjwv YmxvY2txdW90ZT48L2Rpdj4NCg== --000000000000d7c92805e39eae08-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 17:29:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 17:29:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365971.596492 (Exim 4.92) (envelope-from ) id 1oBJgk-0006d6-4n; Tue, 12 Jul 2022 17:28:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365971.596492; Tue, 12 Jul 2022 17:28:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJgk-0006cz-1E; Tue, 12 Jul 2022 17:28:46 +0000 Received: by outflank-mailman (input) for mailman id 365971; Tue, 12 Jul 2022 17:28:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJgi-0006ct-KK for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 17:28:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJgi-00044c-6X; Tue, 12 Jul 2022 17:28:44 +0000 Received: from [54.239.6.187] (helo=[192.168.9.20]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBJgh-0000lB-Ve; Tue, 12 Jul 2022 17:28:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=e2HEhEiGMUhE8eMHuzNGcK/l3cgZlCvrEZV4JUy+p/U=; b=D+LcnBQTyrlBJP0IEArU9BLCCH 8h9EWHIISYfF9hMYGh13WJkMUtDw2RqZTu+M8zbDnrh88QXMtMlapqk+B71bM8TFmfRSKjMlFMsKw RNBAJE2DwUux+zt7xpOw6PjaGCe8Hx+zpFzVwUA+W9nOHJAZ4CG25cij1eutaloheJBY=; Message-ID: Date: Tue, 12 Jul 2022 18:28:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> From: Julien Grall In-Reply-To: <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/07/2022 17:08, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 22 Jun 2022, at 3:51 pm, Julien Grall wrote: >> >> Hi, >> >> On 22/06/2022 15:37, Rahul Singh wrote: >>> evtchn_alloc_unbound() always allocates the next available port. Static >>> event channel support for dom0less domains requires allocating a >>> specified port. >>> Modify the evtchn_alloc_unbound() to accept the port number as an >>> argument and allocate the specified port if available. If the port >>> number argument is zero, the next available port will be allocated. >> >> I haven't yet fully reviewed this series. But I would like to point out that this opening a security hole (which I thought I had mention before) that could be exploited by a guest at runtime. >> >> You would need [1] or similar in order to fix the issue. I am wrote "similar" because the patch could potentially be a problem if you allow a guest to use FIFO (you may need to allocate a lot of memory to fill the hole). >> >> Cheers, >> >> [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=commit;h=2d89486fcf11216331e58a21b367b8a9be1af725 > > Thanks for sharing the patch. If you are okay I can use this patch in next version to fix the security hole. I am fine with that. > > For the FIFO issue, we can introduce the new config option to restrict the maximum number of static > port supported in Xen. We can check the user-defined static port when we parse the device tree and if > a user-defined static port is greater than the maximum allowed static port will return an error to the user. > In this way, we can avoid allocating a lot of memory to fill the hole. > > Let me know your view on this. > > config MAX_STATIC_PORT > int "Maximum number of static ports” > range 1 4095 > help > Controls the build-time maximum number of static port supported The problem is not exclusive to the static event channel. So I don't think this is right to introduce MAX_STATIC_PORT to mitigate the issue (even though this is the only user today). A few of alternative solutions: 1) Handle preemption in alloc_evtchn_bucket() 2) Allocate all the buckets when the domain is created (the max numbers event channel is known). We may need to think about preemption 3) Tweak is_port_valid() to check if the bucket is valid. This would introduce a couple of extra memory access (might be OK as the bucket would be accessed afterwards) and we would need to update some users. At the moment, 3) is appealing me the most. I would be interested to have an opionions from the other maintainers. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 12 17:29:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 17:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365976.596502 (Exim 4.92) (envelope-from ) id 1oBJhn-0007AE-Cx; Tue, 12 Jul 2022 17:29:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365976.596502; Tue, 12 Jul 2022 17:29:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJhn-0007A7-AE; Tue, 12 Jul 2022 17:29:51 +0000 Received: by outflank-mailman (input) for mailman id 365976; Tue, 12 Jul 2022 17:29:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJhl-00079f-Ry; Tue, 12 Jul 2022 17:29:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJhl-00045X-PS; Tue, 12 Jul 2022 17:29:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBJhl-0007oG-3v; Tue, 12 Jul 2022 17:29:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBJhl-0005y4-3M; Tue, 12 Jul 2022 17:29:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2LhCsZvUzHc/2cy7Lq4d3bvBvQFhf16I0aUf3r/DT1s=; b=Xa5TFua0ak34w+wnzL7Wx9f7ou qs1beXUQIoaNgXoSTqongQcQpdPPebsJdN80rHhExs3R8rE3e9j3s7E4VFxoXgC8hR3Izm38YIZSq noRWuPTBIvftDvSRmo9JWysh5PhTnnjIoID6uTfuWEFdYWaoyjYV/cbx7vmM39F9itXc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171593: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=27357c394ba6e1571a89105b840ce1c6f026485c X-Osstest-Versions-That: xen=27357c394ba6e1571a89105b840ce1c6f026485c From: osstest service owner Date: Tue, 12 Jul 2022 17:29:49 +0000 flight 171593 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171593/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171586 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171586 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171586 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171586 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171586 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171586 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171586 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171586 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171586 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171586 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171586 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171586 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 27357c394ba6e1571a89105b840ce1c6f026485c baseline version: xen 27357c394ba6e1571a89105b840ce1c6f026485c Last test of basis 171593 2022-07-12 08:56:27 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jul 12 18:21:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 18:21:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365985.596514 (Exim 4.92) (envelope-from ) id 1oBKVJ-0005KZ-4U; Tue, 12 Jul 2022 18:21:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365985.596514; Tue, 12 Jul 2022 18:21:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKVJ-0005KS-1i; Tue, 12 Jul 2022 18:21:01 +0000 Received: by outflank-mailman (input) for mailman id 365985; Tue, 12 Jul 2022 18:20:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKVH-0005KM-Ng for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 18:20:59 +0000 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f206cee-020f-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 20:20:57 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 18:20:55 +0000 Received: by hermes--production-bf1-58957fb66f-p6kcj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b90d8ba9e0f4f18b61bda02035f72ec5; Tue, 12 Jul 2022 18:20:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f206cee-020f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1657650055; bh=CKwnEohSEzLCt0euoMPaexML+KON7/bDHVVi6FBe4pI=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=j1UCI128UC/XdFVIk8BLV40tyhM2thxOLZH7jtvTEo/A8IUpSPaP461IU1bcGCYaneClzexEZECahX9lGBNFlFtATxmGtC1JimPj8U11JSg7iCl7fJma81s4m5R6SViYqBTJVxCJo7iTBRgRCcUSZRBrPTAu8HUNQCFyYu5uvJGh8M5fb9wtvCpchF1Hn2G1IbM6wUJNdMDEr162EbzVnwNTtWl9tKcPjyV06px5uY4jCL4yI5GAlMpnVnJkvBcy1SOibG8/IWQ/+aZgthwfC2VYWy1XT690LtufKYDuoCza4551OKny8fyIgNnFYsgETQtj5u4j+XzZ1lIJmePNfQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657650055; bh=dwvF5IXFxheLGtHJwEBV8hj410W9zZhbiJkuKyvC/7E=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=JpDTgTFsAq45depS6oNm5+uGftDdlQ1MAnIOPRJfPCpTOaL70KC6u3qrb6vAOgnyF2g6HQLieKKj2mkRh4eXrecDBi5vhH4xsst2m+nGBPCZjVvgtFuLgr58krI5AaDKGpbmMbmNvaSzt93NusCylNGdLe0JU1V4x7U+6Hnmg22NJcsMIge6F2GYYz9ndIVcmXFg1HhuGMWs2O0C5efYu26JVpIQ9f02gZJarqnm7wgSLXtCPXeduftahmTxc6YwSh9br954TO/HSjm5CsNW8zrexLYBkt2HJFgxT6sKrTi7tc6lvTJNSFMcUA6TLJZwRXxa3V6f9FQ0JyGb728c/A== X-YMail-OSG: 4PXjc.QVM1mipgaiULtM_pFdsG.GKyXFDyGWQ6WZpiXOqchOGYZe3LVFRAJJ5Au M7WSoPI0ftFeNZOaO.qOL2WZrudPyJTWhvrJ8FQNAaMkRh6IDe.htE1abegSF2MneaqOLulPvP7K xK7A_y1KDO0Yz3UeMcQAp_E3t1hCH7EnbsUB3viEsvTvg9eKSBBy_f1YUOfazpf6R_207MtRa281 8rYxHw0mpKtlndifhSTjrlFARXstuXiGDqvSdXa6QFPlESG7RyyRchng4hZZnOrevyyUlyt5JxMl T3eU7MW4SvEfJMZTStdgOP3OPYqFM4AXj0KBh5iUBpBEzeHwfCtgRY3dk8hJ06QhCe28qIfaiIp1 aP53Zpfk_1VR20YVdVWJqH.WyUEXO3JXkXgBaj27V5lkH2MbLMdvkJGfHIa18IY35zMFhcmMxwEV YW52Ma9mwWCv112wLrmB9N0jGYrFSGphgqNiG30Imbl013S6hHd.UZ1_XcTt67TxWrohn2EkNkgD 4AoISVkssX.LykGlAnzGJQlejtCbbwrA.4HI8gPhZd4lmosE5UD9royQm7zT8HYXEemgITYQz9.V 0ha8klw.HogjJQf5E_3z9_3UEx3X6blIYTIUzzo9A091sSo9.u1nIpH_qOY8qxbN0enVXuzEyeYC .ca_tqXT0fak4cL79g6MRfo3hHfvLbjqmxiKfGvsi6aWs0fE2j.g3ruFWWihvNC9.4epgdWt3GDm p9qz75nJqE9LlZm0LRmGFxFFmoOy2xLeiHKFDLztYLtQAxDvrFUUb8Qo4ls1yooKzQyAdAGdJ7aT H6ObQd2u7RdtGkZxdip7CrwQCwC9u98WdA23I9jQdQUwwzMPDhkv1C1aC7.CV8xoKJFW2BwhkczL 8iJr1p1t.mE4kOPhYX8OhqjMAiDcVSIwQRoDkdDKGcdT6LCigwKLwzChaq1.UGcfwAH.LTT7LbQp K5lsOCAn8xQt2dD7V093vL7FSnwY8OeyyiNbdBcc24x.f2E35QEMzyQZ0YGo77vPn5AzKJxA1XuN aW84bCs.0FCNKJiDK8umMt5pLndJ5kW4UMxg1S.uF8yn_qBh393ZXcwoeG5izlcxxFiMkqqZksYc d.vk6SmEkSZJs_Jv9mYHrSC4WaXmWeM0gjO00RKp16URn8fzU.JME7xaQkX3jEmQwyJP3y8zR3XD AvEqTso7ZY.0VSHvsaWO8plmO_aggfG73jPGUarylDnD5VsOmjEQW5A3in8VA33d1pwDv6daDVth 7PIgiAYyaD4A_ETwvByhGp2FiUHMvTe4sX.L975Yvs4MuGHFDIQ8CO6bn8OnkVSOEHE6aeE42mlp FGDQIcmsENOMWIucS4Frt29Li.0E2WbEAIF3AddWAQX2xUYsBOg59vHsO4FG5lxXQ3iiug6s0jSC u2uXIdZd5v9d2mEw7RC134lk0hSfhoNRl3KgHcOLQG2XPoNqluGVz3VScNg0I7sqZAFd49OhIG29 3QBIlJLNt0wk.hvJDjO2OenTHdWzQZCgVlHdKRvTCUbzF.t6sVr3SWBzsdHpzrloeRbUsD9Dni4l rJRmL1GSYxgKjzpqNpJALMAU1Pl_.iVjRB6e5zJlW7x9zY3TOdvNuZ6D3JHAnq6uNLHh8ay4zODl .WwFq5AEVOj6lJnFjtd6DU1MjGGfc6GLH.S2RVdde7I9B0sI.Waj42QasW_qfQsba2UgX5YP8uaW gFWATVUB6DM1v7GYv4tS8vc9M9lMLQSSKm1QP3bNRqD0N_7vUaXMNHhjHr0ztUcBxenm3vL9XAM9 J0_NVBt3uYWKZv.5e1TxFxFZBTiqSWRcIgSOxvDmPTZHSxdm41PcTJLsb2QUCqQRksy2WyXl0xI1 mDP0rlgb2z2BkJ225w9RSf0fOyVT9JmLGQ9JMPzJrn6G02z7Vx2MdGmNVSzFPKKp2XVtQYWHnyWF vkBg.etAfGynfqY8gFj_cGJ5vBw9aV1WeIzL_v2XE4zLnKMY94vRMr2awllqmFtjcgqxeOP9odek hA4.2yScXvibWlywqxulO7XgjKuaACLwX2b8f5iwYiyZjHhPF68kSSbdMs_ZYEu81CEjH9SX_zYK _ly11ilPlwOp.p4MHov174fjcKRbU4bFe4n_HKEL07RO6g3SHKSMPulBl6M0bJLRUvYssct26gJG Metr3ZueWBmwPTof1NejlDcpLXA7kZFhzKHXP55up2u2RnDTh.7tkyO0hR4gh X-Sonic-MF: From: Chuck Zmudzinski To: linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Date: Tue, 12 Jul 2022 14:20:37 -0400 Message-Id: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> Content-Length: 2162 The commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") incorrectly failed to account for the case in init_cache_modes() when CPUs do support PAT and falsely reported PAT to be disabled when in fact PAT is enabled. In some environments, notably in Xen PV domains, MTRR is disabled but PAT is still enabled, and that is the case that the aforementioned commit failed to account for. As an unfortunate consequnce, the pat_enabled() function currently does not correctly report that PAT is enabled in such environments. The fix is implemented in init_cache_modes() by setting pat_bp_enabled to true in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed to account for. This patch fixes a regression that some users are experiencing with Linux as a Xen Dom0 driving particular Intel graphics devices by correctly reporting to the Intel i915 driver that PAT is enabled where previously it was falsely reporting that PAT is disabled. Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") Cc: stable@vger.kernel.org Signed-off-by: Chuck Zmudzinski --- Reminder: This patch is a regression fix that is needed on stable versions 5.17 and later. arch/x86/mm/pat/memtype.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index d5ef64ddd35e..0f2417bd1b40 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -315,6 +315,18 @@ void init_cache_modes(void) PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); } + else if (!pat_bp_enabled) { + /* + * In some environments, specifically Xen PV, PAT + * initialization is skipped because MTRRs are disabled even + * though PAT is available. In such environments, set PAT to + * enabled to correctly indicate to callers of pat_enabled() + * that CPU support for PAT is available. + */ + pat_bp_enabled = true; + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); + } + __init_cache_modes(pat); } -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 12 18:27:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 18:27:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365992.596525 (Exim 4.92) (envelope-from ) id 1oBKbi-0006AH-V7; Tue, 12 Jul 2022 18:27:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365992.596525; Tue, 12 Jul 2022 18:27:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKbi-0006AA-Rc; Tue, 12 Jul 2022 18:27:38 +0000 Received: by outflank-mailman (input) for mailman id 365992; Tue, 12 Jul 2022 18:27:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKbg-0006A4-IB for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 18:27:36 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c82b155-0210-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 20:27:34 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 324913376B; Tue, 12 Jul 2022 18:27:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8FE1B13A94; Tue, 12 Jul 2022 18:27:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qDa5IRW9zWJgNwAAMHmgww (envelope-from ); Tue, 12 Jul 2022 18:27:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c82b155-0210-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657650454; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5C+zhs67eGnswPkmR6QS9MECAPZ3zsyGdrODr+C721s=; b=MGlzmUDUgLB0WsB1rDV8evCwxWZkhdoPehiJVuhPNsfLXMuHdi06fWoBXdMOyvhswDSG7/ ofZFNlbySW4Wqt2un2NOFRhLzvPCTatTjDpbxiXS9s83XoKuM+3Q7zluaD2cclF7dC6XXT PnYU2FTXRXSAWZuL0QwAnjVoNt3wcaQ= Message-ID: <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> Date: Tue, 12 Jul 2022 20:27:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> From: Juergen Gross In-Reply-To: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------04Oo5TMKjVTiQc4OF90eNV23" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------04Oo5TMKjVTiQc4OF90eNV23 Content-Type: multipart/mixed; boundary="------------bxhhG9y434fe6T0S1sMDm3IO"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org Message-ID: <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> In-Reply-To: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> --------------bxhhG9y434fe6T0S1sMDm3IO Content-Type: multipart/mixed; boundary="------------5ccNWA1r061yaQTfvzb4hlaA" --------------5ccNWA1r061yaQTfvzb4hlaA Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTIuMDcuMjIgMjA6MjAsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IFRoZSBjb21t aXQgOTljMTNiOGM4ODk2ZDdiY2I5Mjc1M2JmDQo+ICgieDg2L21tL3BhdDogRG9uJ3QgcmVw b3J0IFBBVCBvbiBDUFVzIHRoYXQgZG9uJ3Qgc3VwcG9ydCBpdCIpDQo+IGluY29ycmVjdGx5 IGZhaWxlZCB0byBhY2NvdW50IGZvciB0aGUgY2FzZSBpbiBpbml0X2NhY2hlX21vZGVzKCkg d2hlbg0KPiBDUFVzIGRvIHN1cHBvcnQgUEFUIGFuZCBmYWxzZWx5IHJlcG9ydGVkIFBBVCB0 byBiZSBkaXNhYmxlZCB3aGVuIGluDQo+IGZhY3QgUEFUIGlzIGVuYWJsZWQuIEluIHNvbWUg ZW52aXJvbm1lbnRzLCBub3RhYmx5IGluIFhlbiBQViBkb21haW5zLA0KPiBNVFJSIGlzIGRp c2FibGVkIGJ1dCBQQVQgaXMgc3RpbGwgZW5hYmxlZCwgYW5kIHRoYXQgaXMgdGhlIGNhc2UN Cj4gdGhhdCB0aGUgYWZvcmVtZW50aW9uZWQgY29tbWl0IGZhaWxlZCB0byBhY2NvdW50IGZv ci4NCj4gDQo+IEFzIGFuIHVuZm9ydHVuYXRlIGNvbnNlcXVuY2UsIHRoZSBwYXRfZW5hYmxl ZCgpIGZ1bmN0aW9uIGN1cnJlbnRseSBkb2VzDQo+IG5vdCBjb3JyZWN0bHkgcmVwb3J0IHRo YXQgUEFUIGlzIGVuYWJsZWQgaW4gc3VjaCBlbnZpcm9ubWVudHMuIFRoZSBmaXgNCj4gaXMg aW1wbGVtZW50ZWQgaW4gaW5pdF9jYWNoZV9tb2RlcygpIGJ5IHNldHRpbmcgcGF0X2JwX2Vu YWJsZWQgdG8gdHJ1ZQ0KPiBpbiBpbml0X2NhY2hlX21vZGVzKCkgZm9yIHRoZSBjYXNlIHRo YXQgY29tbWl0IDk5YzEzYjhjODg5NmQ3YmNiOTI3NTNiZg0KPiAoIng4Ni9tbS9wYXQ6IERv bid0IHJlcG9ydCBQQVQgb24gQ1BVcyB0aGF0IGRvbid0IHN1cHBvcnQgaXQiKSBmYWlsZWQN Cj4gdG8gYWNjb3VudCBmb3IuDQo+IA0KPiBUaGlzIHBhdGNoIGZpeGVzIGEgcmVncmVzc2lv biB0aGF0IHNvbWUgdXNlcnMgYXJlIGV4cGVyaWVuY2luZyB3aXRoDQo+IExpbnV4IGFzIGEg WGVuIERvbTAgZHJpdmluZyBwYXJ0aWN1bGFyIEludGVsIGdyYXBoaWNzIGRldmljZXMgYnkN Cj4gY29ycmVjdGx5IHJlcG9ydGluZyB0byB0aGUgSW50ZWwgaTkxNSBkcml2ZXIgdGhhdCBQ QVQgaXMgZW5hYmxlZCB3aGVyZQ0KPiBwcmV2aW91c2x5IGl0IHdhcyBmYWxzZWx5IHJlcG9y dGluZyB0aGF0IFBBVCBpcyBkaXNhYmxlZC4NCj4gDQo+IEZpeGVzOiA5OWMxM2I4Yzg4OTZk N2JjYjkyNzUzYmYgKCJ4ODYvbW0vcGF0OiBEb24ndCByZXBvcnQgUEFUIG9uIENQVXMgdGhh dCBkb24ndCBzdXBwb3J0IGl0IikNCj4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcNCj4g U2lnbmVkLW9mZi1ieTogQ2h1Y2sgWm11ZHppbnNraSA8YnJjaHVja3pAYW9sLmNvbT4NCj4g LS0tDQo+IFJlbWluZGVyOiBUaGlzIHBhdGNoIGlzIGEgcmVncmVzc2lvbiBmaXggdGhhdCBp cyBuZWVkZWQgb24gc3RhYmxlDQo+IHZlcnNpb25zIDUuMTcgYW5kIGxhdGVyLg0KPiANCj4g ICBhcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5jIHwgMTIgKysrKysrKysrKysrDQo+ICAgMSBm aWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMoKykNCj4gDQo+IGRpZmYgLS1naXQgYS9hcmNo L3g4Ni9tbS9wYXQvbWVtdHlwZS5jIGIvYXJjaC94ODYvbW0vcGF0L21lbXR5cGUuYw0KPiBp bmRleCBkNWVmNjRkZGQzNWUuLjBmMjQxN2JkMWI0MCAxMDA2NDQNCj4gLS0tIGEvYXJjaC94 ODYvbW0vcGF0L21lbXR5cGUuYw0KPiArKysgYi9hcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5j DQo+IEBAIC0zMTUsNiArMzE1LDE4IEBAIHZvaWQgaW5pdF9jYWNoZV9tb2Rlcyh2b2lkKQ0K PiAgIAkJICAgICAgUEFUKDQsIFdCKSB8IFBBVCg1LCBXVCkgfCBQQVQoNiwgVUNfTUlOVVMp IHwgUEFUKDcsIFVDKTsNCj4gICAJfQ0KPiAgIA0KPiArCWVsc2UgaWYgKCFwYXRfYnBfZW5h YmxlZCkgew0KDQpQbGVhc2UgcHV0IHRoZSAiZWxzZSBpZiB7IiBpbnRvIHRoZSBzYW1lIGxp bmUgYXMgdGhlICJ9IiBhYm92ZS4NCg0KPiArCS8qDQo+ICsJICogSW4gc29tZSBlbnZpcm9u bWVudHMsIHNwZWNpZmljYWxseSBYZW4gUFYsIFBBVA0KPiArCSAqIGluaXRpYWxpemF0aW9u IGlzIHNraXBwZWQgYmVjYXVzZSBNVFJScyBhcmUgZGlzYWJsZWQgZXZlbg0KPiArCSAqIHRo b3VnaCBQQVQgaXMgYXZhaWxhYmxlLiBJbiBzdWNoIGVudmlyb25tZW50cywgc2V0IFBBVCB0 bw0KPiArCSAqIGVuYWJsZWQgdG8gY29ycmVjdGx5IGluZGljYXRlIHRvIGNhbGxlcnMgb2Yg cGF0X2VuYWJsZWQoKQ0KPiArCSAqIHRoYXQgQ1BVIHN1cHBvcnQgZm9yIFBBVCBpcyBhdmFp bGFibGUuDQo+ICsJICovDQo+ICsJcGF0X2JwX2VuYWJsZWQgPSB0cnVlOw0KPiArCXByX2lu Zm8oIng4Ni9QQVQ6IFBBVCBlbmFibGVkIGJ5IGluaXRfY2FjaGVfbW9kZXNcbiIpOw0KDQpX cm9uZyBpbmRlbnRhdGlvbi4NCg0KPiArCX0NCj4gKw0KPiAgIAlfX2luaXRfY2FjaGVfbW9k ZXMocGF0KTsNCj4gICB9DQo+ICAgDQoNCkFueSByZWFzb24geW91IGRpZG4ndCBmaXggdGhl ICJub3BhdCIgaXNzdWUgSmFuIG1lbnRpb25lZD8NCg0KSSBhc2tlZCB5b3UgdHdpY2UgdG8g YWRkIHRoaXMgZml4Lg0KDQoNCkp1ZXJnZW4NCg== --------------5ccNWA1r061yaQTfvzb4hlaA Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------5ccNWA1r061yaQTfvzb4hlaA-- --------------bxhhG9y434fe6T0S1sMDm3IO-- --------------04Oo5TMKjVTiQc4OF90eNV23 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLNvRUFAwAAAAAACgkQsN6d1ii/Ey+V 1Qf/Zx2aBQJ9I7nw2PrZ3zt1A1l9KdzIGgiptzSiicbDBd3GxgVCoqWd+aq28UWu2SKmpDl/f3YQ t6ulweXG1CltXL3rFWCyvUyYyGvlt4vmb9EhNst4a2rUrB4FV0/yP5tviQOD3WfjIysbKEm92qqk z4u6WYyvD5jWdG9ud4QfN04bbpXNUFeK+/iME3E9Z1rA6xYxBwoEA71LIuNb1iNrBWRkkiUqO7aK wh6M0gxTQrlA8PEKl6Ha5Xm0keXSL+ijrCCZlCyu+VEgXpSS5CJhwD0XiJpKYUpACY8zbIWAxzAP yNffZig+IE2kH4I1n99evY3qKOaRLcLMfFvq2Ptwyw== =lpyI -----END PGP SIGNATURE----- --------------04Oo5TMKjVTiQc4OF90eNV23-- From xen-devel-bounces@lists.xenproject.org Tue Jul 12 18:36:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 18:36:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.365998.596536 (Exim 4.92) (envelope-from ) id 1oBKkQ-0007kL-R6; Tue, 12 Jul 2022 18:36:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 365998.596536; Tue, 12 Jul 2022 18:36:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKkQ-0007kE-N9; Tue, 12 Jul 2022 18:36:38 +0000 Received: by outflank-mailman (input) for mailman id 365998; Tue, 12 Jul 2022 18:36:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBKkP-0007k8-Ng for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 18:36:37 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ef6af70-0211-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 20:36:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C1381B81BB4; Tue, 12 Jul 2022 18:36:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0C44CC3411C; Tue, 12 Jul 2022 18:36:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ef6af70-0211-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657650993; bh=nAOi1MXsyoVA0q9gtRNUyy6hltF+AMdxpRWiXfWBYeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C0vW8IXumz/ivLT3cERCSGYAWs6tdTRL1wCt9BWjxzmdxi1SLyExGyUVx+/BrYGW7 3CVGWTBENx5dyBMuX+ieXSL+TOud9FcNOdGHmaJJ3paXHZ7ugefk9DeDyQDecm/odG bN9CdSEj/FjZs1q7+EcHAjdilv39IfeOFUFGswE4= Date: Tue, 12 Jul 2022 20:36:30 +0200 From: Greg KH To: Chuck Zmudzinski Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Message-ID: References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > The commit 99c13b8c8896d7bcb92753bf > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > incorrectly failed to account for the case in init_cache_modes() when > CPUs do support PAT and falsely reported PAT to be disabled when in > fact PAT is enabled. In some environments, notably in Xen PV domains, > MTRR is disabled but PAT is still enabled, and that is the case > that the aforementioned commit failed to account for. > > As an unfortunate consequnce, the pat_enabled() function currently does > not correctly report that PAT is enabled in such environments. The fix > is implemented in init_cache_modes() by setting pat_bp_enabled to true > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > to account for. > > This patch fixes a regression that some users are experiencing with > Linux as a Xen Dom0 driving particular Intel graphics devices by > correctly reporting to the Intel i915 driver that PAT is enabled where > previously it was falsely reporting that PAT is disabled. > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > Cc: stable@vger.kernel.org > Signed-off-by: Chuck Zmudzinski > --- > Reminder: This patch is a regression fix that is needed on stable > versions 5.17 and later. Then why are you saying it fixes a commit that is in 4.4.y and newer? confused, greg k-h From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:16:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:16:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366004.596547 (Exim 4.92) (envelope-from ) id 1oBLMo-0003s9-Pa; Tue, 12 Jul 2022 19:16:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366004.596547; Tue, 12 Jul 2022 19:16:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLMo-0003s2-Mp; Tue, 12 Jul 2022 19:16:18 +0000 Received: by outflank-mailman (input) for mailman id 366004; Tue, 12 Jul 2022 19:16:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLMm-0003rw-Ri for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:16:17 +0000 Received: from sonic304-25.consmr.mail.gq1.yahoo.com (sonic304-25.consmr.mail.gq1.yahoo.com [98.137.68.206]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16f4bafb-0217-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 21:16:13 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 19:16:10 +0000 Received: by hermes--production-bf1-58957fb66f-h8ftj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID fc41fbffd72b8c63f02a9fec28369f25; Tue, 12 Jul 2022 19:16:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f4bafb-0217-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657653370; bh=LqsIYiuRO/rQshDsBrwWzPJZc3QmrOrPF5Mlw0dTQhI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=CGAjtpR5+C4HS4XQ2OvTYQ7qRlySax9XYLbliqAR29CfvkgIwl1RdUv2Gq/5w7tCk/YEPyImtAySVW2fLavPN7ALOFePf9c38I0R55eo7I9kTe9pgvAbK/7gWzEOQlF+/KkUZ7h8y40SM8wa/sErYdC7KL9HqsFtDlm5AukXsIAY2pxJFuWy5k/oSXssEd/YimB1E5mnEJUYdRHAYyRx38O68t2D7OeONT3dzW+35L5RAKK1NjACcVieKIQrmO/9eDxUggdb/1PAS6kio0CsqzsUflQITVZJLIZwhehNkPBRNjNj/Veyb9BG5A+qnPdZQ4vcppzYBq72sInOkUenJQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657653370; bh=vzUhklzVTkk5kQMXp8RwJ4d116VwwqOH3IvqSm/1z/S=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=ZOxnEwzj99oX1FcCZKrIzFRVyzGKSo/eTTbzAlzhMluX+rosfpIIfAjsApnxXVs7loFbHvnSOI+bEWb02AGXfviau7YgwHQBykvurQX/gfE6qoEnNpOrW2vLUWHtj2m2G+JuuSFgyYZjBr0q27k3HVaJFHAOnMgDGB65hM5HCJ3gAKDRAqQWsq5Z6Bi8ZxHiLAyibPxRQLRY2koYnr/FvVOxEBmUvnBnVv4nQM+XA4A7q2pRXgGyuFiViCaSr8wsZwLG6FLowYfG22OAXx2/hViRR9p+mdz3F6L83ITwrZ6jdWtuByP3xozWI+VIBP8E3n60R08bh5eQ69/x4Y8KKg== X-YMail-OSG: zNFCnf0VM1mAICJ7S6iq30JGBNQGhtyv7Q_U.DPJjW6i5EJGwBBaz8vDAkB6f1n Lf.hiaTiHFLgYwqxKlUAmYERr9tr3YRBL6Z0YUQf5By1TTWCw88Nqq2ztmwOsnCWrKrBEWNjdYHK kJgodWMEDJjmuknTFFRpFILt0Bn7O7lnrfkJ_5x7dLDXAb9_16ZZWglvHrPQyGOZuHB0bpwcQa0y Ui40DpYlaPc6IeXObZCbcSl8jsG6PsTFV6a18LIbXZi4KjlHySHd7ufy8Rzb21xFAmTfjpJoNwEI jhL6wP88QJIMBB.qrptyLG1uEGmuTPtD37h86EpX5JUJNJYxitGLSxIvimFaqvDtYC6buK5ybCWr hr1p.XUc7deApGm9mbyy9q_KkLFkP3RulYPtsisukvNfX4eVWCdSRDuf_9zIrWjA4WaxV.XDjBCw P0KETDQWsOkrL11asuS35IMR696QvRmTHkyCD7c5nvHYYYjEAiaaWS74NTHGaJpdjzU_irGdCeSW UgRkTjRPjmFlOa86_QVICDJm23q2kDtzhYqYbelNC9zW6sVg6chuMLDFfclzg6.QIoD7AfoMlIkd wUyODmebdn9_l3wuYL4.FccIUNduFuy_MgcHqQ5xIcAC6RBufP1XCqFYwO8QW8LD8NvzJ8qFChT2 eATnYUufnI4LzaMmZulgPxqzQr514avDyQ_rzIm1R1YYIe8Qoaf9cTF1QLP4cc5e5UIV8o.DTNVw PhHTi6F7lsb2LppiySSYhFEp8iYXlc.EGKbiDPmaRCEEUvjW1bV7iPi8ZJHWkYdue5Eogy_gRohV AU.Y1jfVNPOJlzGwyD4qurXCyTGuZ_uHfiM6sAxqjP7uTmbN05qM_YG3wZgF.ZIAmd7r.GkjHN.W CCiqZ9z0RpLlkWM5akEt1FTBnx7KFa9Def3FvMaMoPMeFem_apdwdpEY0uiKte9Wcxdr2HonTqEy o6gY4R3sy09WJvKKNwRCGDUDNwJeGf61UWZqGFYALsnaJ_i.XN842IrqFTPKcA1PcywNc2M8aqca EBPI2aMI9LZeMVIUA57qmdySR41ZnoDYcGSTBtApAnb3PL2GJjdYvag8WhRH7Ya.Hv8powYvZQo8 KSt5fnMlFScQAs.__hjgna2HVJ5PuQ5Y4Y3UyqEG4lOwp_QEYO7W5Z8e3cpgabuqC0orQ75Mxh4c e66Ajx6kR_ZU1emqoa.nCo5r1ufnaD0_h9nLTXEGRhfin1OjKqwB355qcTDNSSpRAu0yqURFPzy8 QJBWgQajGuLwCccNVPeW4eqrJgzxM9vPAF3wXwqC81TTOuHsm7zH9Q6lYKGHMdfDYHJYl7.Q5Fk4 wpMuZ43o6OgPev8a_wpdG1yUgxcVMIVkCztLPudUSbmqTYhrJ5KJ8ROuKjKyhT4UG.pjrcPYeoNP yUcQ6elGOLSvzqDSY8EmxdDfPW5nP6NLs7nwhuL4st298TxyVBXEdZVsAHKYs33M12SMx4qXL2BT SZPliQpq1sOZ9a9HxB8JjZMu_m3giUGr8pmCCQ6iWJfVrZKIaNJZYGQ2hgXz_UpElnXIrs2.bjoy OdYL.tBFOB7YGLETRhjjo3gg7zVjR1H6mPAe6ehmTnff6IgrPDAqagfg9OSdPjafoshfGMQ4VgXI oHo4Am.FX.ggDWvxnm.yC5OeIkP8p7xZGBrxavYWQKSl6z84dpyllgj2fh9bJT0sIxqZIfFPrEmo uWZPeWfncD8LubnMtRdbj6ZrOWanPZ178BKHsylxYYe6Tq787O_uKcC6sUG_lQ92ItKss7opjBUy MueB6yp_NbmnbnEqGwcKy6uC6yuKytq7XMvTChBZeMJEn61dVyYQKYGCRivtlywqTO3y1zaMbgWV hwfFx.lzoVaNsodAorcUhlPFcIYRgcjzhZmtQ8Tq8._tGZFfk8JRWLJ_1xYknOwdGIuARmvTn3Do UOidztSktYXqOyHBvX2HeDSw6_1BxB1NE4_6iG85nGVCJ_A3_E4sMPw8EuKyRDzfMmRDDikyzhZu wXQUa4_XpJh.9rwfToWo2zbFb2oVaLFog7.BlWfMXzwt3YUcH03KetFvmqT8XhLFThUD4No.tidY FmLjC96V9CDOhuT8msHkOO0fjH2tGKa8ONrEaFV3TvGUu109DhOdkbA9IzA1iRtAlZM0MB8MsUMn lNG62gV6G.7TuHImInynmdwpcf1zjH.viwLTL1CmCBF3SKDVM8swISGTG8Se8BV72p.uktB3m4Jq 5_8hW15w- X-Sonic-MF: Message-ID: Date: Tue, 12 Jul 2022 15:16:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Greg KH Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2207 On 7/12/22 2:36 PM, Greg KH wrote: > On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > > The commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > incorrectly failed to account for the case in init_cache_modes() when > > CPUs do support PAT and falsely reported PAT to be disabled when in > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > MTRR is disabled but PAT is still enabled, and that is the case > > that the aforementioned commit failed to account for. > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > not correctly report that PAT is enabled in such environments. The fix > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > to account for. > > > > This patch fixes a regression that some users are experiencing with > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > correctly reporting to the Intel i915 driver that PAT is enabled where > > previously it was falsely reporting that PAT is disabled. > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > Cc: stable@vger.kernel.org > > Signed-off-by: Chuck Zmudzinski > > --- > > Reminder: This patch is a regression fix that is needed on stable > > versions 5.17 and later. > > Then why are you saying it fixes a commit that is in 4.4.y and newer? > > confused, > > greg k-h It is true the erroneous reporting of PAT goes back to 4.4.y. But it was not until 5.17.y when the i915 driver was patched with a commit that started using pat_enabled() instead of boot_cpu_has(X86_FEATURE_PAT) and that is when a regression that started annoying users appeared in the kernel. I presume that we only backport patches to stable that fix regressions that are really bothering users, so even though the problem dates to 4.4.y, there is no need to backport before 5.17.y which is when the problem manifested in a way that started bothering users. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:18:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366009.596558 (Exim 4.92) (envelope-from ) id 1oBLOj-0004Zo-61; Tue, 12 Jul 2022 19:18:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366009.596558; Tue, 12 Jul 2022 19:18:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLOj-0004Zh-33; Tue, 12 Jul 2022 19:18:17 +0000 Received: by outflank-mailman (input) for mailman id 366009; Tue, 12 Jul 2022 19:18:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLOh-0004ZV-KD for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:18:15 +0000 Received: from sonic305-20.consmr.mail.gq1.yahoo.com (sonic305-20.consmr.mail.gq1.yahoo.com [98.137.64.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5e51d169-0217-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 21:18:12 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 19:18:10 +0000 Received: by hermes--production-bf1-58957fb66f-hznx2 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 1f77b89044160acfa604b1a362430e8b; Tue, 12 Jul 2022 19:18:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e51d169-0217-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657653490; bh=on6J7csCU3PcwxCxXr0iZWS/WY1846nNUPISliedjE0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=FQHPbLPJ33tHYchaTw08ToyCPILhtoV6HxbTwP9Wyk1J3fMbImmh84W606a0h3lei+847d+RgLa5yB2ZgHH12B27lbA9mbTzEm4eJtrQhkk1uCheZj5bfn9yUQt5v3bjXK7Fse3PoXbV2BGRFgtCRGB/gnNVA/grMuik7+/TZNdYE7fwVyqiSl+L080f3Jm8PAmwuikXOvxuZjvEExLdCSCeR2A2noeBUPJ3quvfiU7LpbYy8W67QP51wfnakJbPg+bk73KAOp2AzgkLtlW9LignEm5UsMZq9QvNiND4M4qIwcqJq5R3ld6GL7RJcgkneTailaDjtBb5541M7uQpyw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657653490; bh=PL+4xfOMQnU+wxM7A5UDt/OlMtG69yUxOWd+m3+vF0c=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=Zd/LOoBB4jdEgIET55uod5LFgfErz2/FjoWI6zoLnMJ2bqICCLJHf8AsDUofinqTMdkxtejM2A2UBhYjAUVSa0Uc5GDMacN6/NYr4QFdt8foAVHJMXUsGPhTPaBTVhpnhp0/iNHlP58bCPD0TGyd8eMGwOgpsuiilGeQkIzAcvIZMyYVONOBGUyLfD5F2AxSfdeZeVSdlxZXYnRcqa4TEvYvJO8T8j2WE8tHtAN6iTLcUjPU/L3oyuwt2TPgCnYcX98BZQi4ZvTo36nk6Ll0y+Dabu+degoyFjRbSwgSK2UVMMgAETkuULOCYA/bMRrd4zkU+eQGdxliKmFQKMjZLg== X-YMail-OSG: 6uRzXoEVM1ktpBqV3wppqty5gdSRKu0q0pxT.ZTSrG6UTmg48JCt46.bH2t67rt bUtJyP_jQfLlVqIpjowOUcOILv31G5LGY70QiIYX_rIaD6AvueBgV7jAtmsOnXw5vhe_2A0.HSsG EnJSL7j.FwYBXbrnScGO9EO.KOi0Zm6Uzp9oSnG0zvjSuADpDyCp4Q6r56BBjW0tDYc3RwuDWx1n IygOyeWC_CHQdWyICh9vorcCWdboPzEUgWdA1ScuNES06biqCInfPr7VOX.PYBUU5rK5fx7iRkFB RZVyuqz9tVY3qD1s5Gb9csRlsbs745Gf3EoCV77xTt0uHW836jbCRspCljDEVJEOpzahOGPYj9D0 V3sK5pr_X6zsXtqEvULmYElu7hyKv_LLO3XidvIyzt8v9QSjjVZht.smPWeLt3_rwpOtUggOWuFC hwkJ5NKM6o1Kr.vryGVczN61euXm77Yelm6OXrdLJRX.M5Yd4vSWIXTNgM5_Vs_GvYTBfuY7Dtq0 HqaK4lTOm2sNoTw2XnWN0u4t7Rd1c2FSwK2Wz.m2s8qmSmqvltm8ivr4DmBE1k4oG4zqs3z5Ysou .BfRlyjmphB.oS_OCww2kVNcJnRSStMdHV.JSfWMkzbyB5IwkUR.MEsZ32fn.3RZIISM6359lJDY eprFMneLgYzV.DR7ShnebbB3gcFbaCO2I3gUlpnMSAZVwCy3g3sMyHlV44LYs2VxQXfEfeyaqJ6G YSNs7LP.7_RNFf_h5g8LSLbUIN9XCs9LN8d1fKGieq9QuJus4U9bj7ssx5czLk5dgBtEFmlRCqsL yVTIRNW.EKN3gxjZjqb.arGLqBmfuqJOb3jIw2ELer3qIsZk5Ws6Xa1q8S_SqJ9G1OcYUj91YSas GtNwF9fjQiql_FqrEeAxQoAcXw2hD1_fExlsH3XZ33HHlImvj_UER2.N.oJMMH5JxjXx8c5TllDK eWNfE64MRoeC5lBdXCBPnfTF12kmFKv3DvcWKSdz2PcQeD58SMJFuppAdntSarsC1xNYGwRSTH4v 9ZUiJNKaMwFDu.xqeAsUuAZ2pNwLSgUgulnX3zRAilRO2jqgUM_z6zhJl4u3b8q9oe2arhueCPpM iJkQQKoBJ_r7WWZ_YadGIbMmu7yJ63ZiTCUGCLZeQfjtRtkTGZUx.bYZXfCbVzVCwn.NtxXoERbw tUcP.X6WabKMovZWJfqhm3kMwmDh_c9c6UKm60PZTYcUFHLy.fB4el9XGfPfYxBSfJfmu8RUGe6L oXpSKnWABoTU6bHyaK8Syx26dYzLx_iDtWyUBgU6gd5Q9AKOgH5ob5wxENOi83UD2s3fB4IZeWhM d_JT0cdEOZYs8vioy40Su4VUBwoDZXLrG6LnGSgpusJJrhPyHBcXa.pWCGlaL202V4HkPg8AGlVV IikE2_jFcCsKl46S2gri43PmOav3xeLt6KBqJKYntpT.kx2xzvDF6RUs6VyQjw6ORdSgi2pnJQBf EGotPFji14gv9uR2tVVKu4WZj2d_dLris2pPSnyPKkSOh1bpbhpWH0fD__m8AiwZuyPtoO9f.JAC ikrTiIrLvh8QUGqzrHnlfK.WW6cXXzdbE5iSvZAsSi9dI3k5cSGFhmKOg3pHhGW1r.54iEecu4gE 9Ed98ZTFGaDYTL33KsUY2S6.vvt2KdIfVZRmV9VwfC5UtOdkb6APQGTII6nuemi1vuGvvFsKUSIb _DfFsIpPCM9zwSOhx3tLsnAVEQ0EDbCff_Q1PbF6ZqUIPjDhRGvJSSI2gNOu1CMctFSf7rB8jhUn xmeIeybuDo9px2nkSAVvpQmzJjpaGlSYMoyKhuezaDwXhNT4OXZFe7bIDEQrMq1sT2tjj2wKVN9z 0YmSoAzBy8ykrSKyeHAgxVKBcE2LY.t0llAka.WyCtF4aYTOACL.0Ps7.iU1E2HOm6i19w3qkfee J35VAsLO2h6jS3HxQrsouujsWfQodPXAfekI._1WzHZpl8gwWJhAakjsNuBWLNxzIWxI.ijFIlmg TCYMMT9JLTyqRtbi0y_oiyfVzGUMnI9J9lXHQ4g8Qxd9AtpTWE6vhFUgIdmIviFMWDWbyssifBC_ RrNeAT1B9mqxl6RYFG2isMxCcrBRzGCe6z.VucfwHCj1I6Mlhepo6x0APTHD0HYKm8QB.xcPe5Bh njJ1jKAB1E3kep8wG7JLLaV_Y7JIi.5smdDOt9AZWyOhCKEHkE866LeNCxJH5BC_cP1tMZTgBxDt RMw-- X-Sonic-MF: Message-ID: Date: Tue, 12 Jul 2022 15:18:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Juergen Gross , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> From: Chuck Zmudzinski In-Reply-To: <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2791 On 7/12/22 2:27 PM, Juergen Gross wrote: > On 12.07.22 20:20, Chuck Zmudzinski wrote: > > The commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > incorrectly failed to account for the case in init_cache_modes() when > > CPUs do support PAT and falsely reported PAT to be disabled when in > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > MTRR is disabled but PAT is still enabled, and that is the case > > that the aforementioned commit failed to account for. > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > not correctly report that PAT is enabled in such environments. The fix > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > to account for. > > > > This patch fixes a regression that some users are experiencing with > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > correctly reporting to the Intel i915 driver that PAT is enabled where > > previously it was falsely reporting that PAT is disabled. > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > Cc: stable@vger.kernel.org > > Signed-off-by: Chuck Zmudzinski > > --- > > Reminder: This patch is a regression fix that is needed on stable > > versions 5.17 and later. > > > > arch/x86/mm/pat/memtype.c | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > index d5ef64ddd35e..0f2417bd1b40 100644 > > --- a/arch/x86/mm/pat/memtype.c > > +++ b/arch/x86/mm/pat/memtype.c > > @@ -315,6 +315,18 @@ void init_cache_modes(void) > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > } > > > > + else if (!pat_bp_enabled) { > > Please put the "else if {" into the same line as the "}" above. > > > + /* > > + * In some environments, specifically Xen PV, PAT > > + * initialization is skipped because MTRRs are disabled even > > + * though PAT is available. In such environments, set PAT to > > + * enabled to correctly indicate to callers of pat_enabled() > > + * that CPU support for PAT is available. > > + */ > > + pat_bp_enabled = true; > > + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > > Wrong indentation. > > > + } > > + > > __init_cache_modes(pat); > > } > > > > Any reason you didn't fix the "nopat" issue Jan mentioned? > > I asked you twice to add this fix. > > > Juergen Sorry, I did not see your request. I will resend with the fix for "nopat" and the other style issues you mentioned. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:20:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:20:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366015.596569 (Exim 4.92) (envelope-from ) id 1oBLQc-0005zq-O8; Tue, 12 Jul 2022 19:20:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366015.596569; Tue, 12 Jul 2022 19:20:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLQc-0005zj-KF; Tue, 12 Jul 2022 19:20:14 +0000 Received: by outflank-mailman (input) for mailman id 366015; Tue, 12 Jul 2022 19:20:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLQa-0005zX-2w for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:20:12 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a4c213f3-0217-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 21:20:10 +0200 (CEST) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26CIdQ1f031069; Tue, 12 Jul 2022 19:19:47 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71rfyy0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 19:19:46 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26CJADdG021677; Tue, 12 Jul 2022 19:19:46 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3h70445qs1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 19:19:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BY5PR10MB4177.namprd10.prod.outlook.com (2603:10b6:a03:205::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 19:19:43 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%4]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 19:19:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4c213f3-0217-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=iD85MsUZ8TPR4rd4PbP1LyBxIUKYZGUtgDJrOvDl/+8=; b=MYUiYlMHFFzmlDgaHt6zHsHfCqHaSkbzUOf4DpJ5FSDrCv+AnJpPFVwBgnZZ8E4bWFTF /hhkVOHIOUxQMNxJw6gCFAE9y+/HyFdRwlOrj4RE6XCz8i+AQj3qlu5bowf0aj8lTKmM XYeEYNZAE3vMgszxp191E3XiiMVxKOdkOZjpWBSCgiC96611k9uXzD6a8xyheSU/h2u5 76/K4q0wXAeNcZFBYMWREoZnPFbPgn7D/hCBG+yyJHPK5/PUknb09p0ehi1aeK3ZliA7 g02VPhz5iQhkZK+vbW5SBBGHNJ3xytgn0y7SM0lq5bJCVKMq84qzNj8T/OWOddoUyfbC wQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bzSgiaA6JrYRhxiKKU4rxKoOJqNFdtgLY3+EUHGVKi21zgUwCdGri+Unrj/g5OfcYf5igdWUNLgYfAfN8GFLlaHTlWNZfcxw0aMxQQpeyH2aJy8dyRhjVFd8hNdl7kcrzRGOXaH2RzKMI+6akXHrPW6ilhyQ6Jv2UNQgnymxXDXAwJ329My/7zWF7koU1mhYV7xIhemQN5uw/H89a/rsEwJn3arGR3XuzV82OIcfyDwOmz+ZWZd18tK9zMhN9jmj4fTeD3WMkvcWqRVELllXojYsnCgQH5/B8zF0du9FOYMoY6RxgupROCAzt0EDGSO1TigbGxezKhUTiR/aaBtAgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iD85MsUZ8TPR4rd4PbP1LyBxIUKYZGUtgDJrOvDl/+8=; b=OsZrueX6TCiRIRhP59UqAiSPet5cm5h5ly3U3IGjPSqjnbpc4ea0AW1Nmj532RFDTnK/U43VX8SKUkjmTUWtWqVSHtwPzCWy2uvUN8qASTMQpj9qg/51ukeDF9G+jSlQdzOBKip6izKW09GyQLl9hyCEO1Ud8IT7clcbQu3hSAMUiUaF0HvMn8NpuLcpkuXeHRvH0ypwEIhaZAGQtxVxQcYHseYd/XOh+uF01zQia9d3mC4ijJgJNJxguE0K7ZTheIfRuKXHFYMOmttAQBTiHTV43WTgqRM4Kf3jGLaPmr9GtnYz+fOBF6FaflyTPPNvbeg5HSM8zmWMPhZqxFiISg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iD85MsUZ8TPR4rd4PbP1LyBxIUKYZGUtgDJrOvDl/+8=; b=FcYd/jSBCgK/1iu2JGd04EKQXtwOmJ9KpPMvBN3FaxmrhJigfejaoWJbkVZO7AS0cJkXX/AiHNs4u4I0CWrfxsOOC9i1XqIKDwGK+7gU/RxcmpDGhRAnlfPwIFzqtpBdIHGyw8DtlBJwBwefb6H5gUQGT8RKrxiy2kGPbDlnZ4A= Message-ID: Date: Tue, 12 Jul 2022 15:19:39 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Content-Language: en-US To: Greg KH , Juergen Gross , Stefano Stabellini Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA1PR03CA0018.namprd03.prod.outlook.com (2603:10b6:806:2d3::29) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a514469f-3d1d-47a0-6330-08da643b79ce X-MS-TrafficTypeDiagnostic: BY5PR10MB4177:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YSrWJ3aM2Bi0FRjqIYfs2tB8FKDhjSVvITymp1OUfmLEA/KXR3cOouT9lOTMODZbIPsOVEDDsF+AJyWxqohEJ28cBQ80ApUg7rYlpns8bl5mX+PHBo0ytou9B00lvfzhlvRWxGpVUDXW8a3DHWDkCHAhmSyRN+Wf8L1v1DUs4xxiAUPPHp/Yca9AVIyHz0HUi1skVrCkak9s70L0Vvbi8eBxahSlBO3tlHZjl0vIAyw4J67b5NZ4GxFgVAgFztELaLSSOS/Rg/apii7KouosHl+YUoniUMyR1urro5SbyfRmg6nDE92SL/n3y7DcJyCaJA5JhNZIazLeuP5YQSqsq+CVCZVRwhT0+akF1mj+H2qN+desn2cFWOqAQbEXlDGcj8L5sp7Y5g3+ilByGGKMQLJ7DoFot8GWQdCRmaQWVSDLiEQkpx8y0P0KE6BzJTkQ9IhJ/0QKaPhbC/nD/4PNWMBCOdfzfvhEsyeK5e9TMd6xjsxWoPL0HU9JT/XQnKmLWQJgw/5RcnPfWkznyEWxnU2QFfxWn0eRfPeSxUMIwIo2O4KOWhJG8yiE+aHF0Ff/MV7HvzA3VaU/SgjRw0KRSRfI/YjMeSjqlxvgStV+2u509+5fEzTyJtNuuyv3qiueCppbj+TlAKIEp3jVjaah2IvscIdxo899y1xYs7CNoLHfh7dIxAYeWBjoEeBaI8FTMlRAvesW2Tzx9LDcUEzDw/KInm4iP+jNz4TKbzDCjhRQYvw0KSiwMMYwwgAfhW/WFcfm7ThEv257B2CmiIpWUshUSFozp94jHBGUd++pMMWO7NzhwOW4lomlSs9QVg+LRDT6AqVcASFplF0s1OPcTuWB0CWfi2NB/vajOSAH5A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(366004)(396003)(6486002)(53546011)(38100700002)(478600001)(31696002)(86362001)(26005)(110136005)(6506007)(36756003)(8676002)(66556008)(54906003)(31686004)(316002)(66476007)(2616005)(4326008)(66946007)(186003)(41300700001)(6666004)(2906002)(8936002)(6512007)(44832011)(7416002)(5660300002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEQ3OUE3M2xYOWs3UkczWWVkQUlRbDFZUk9STEJjNmtJTmwrUGVid2tRRlBH?= =?utf-8?B?cnUzZjA3dGZscEs4VzBOZ2dmY2swODNJNWVVTkFObnRnazZES1kxRGtYeHJJ?= =?utf-8?B?TEYyMXNYQmlpRTc0eURPYXhhZGc1TStLSkJwSVZVRGF0cGhxQmpVczEwUjdU?= =?utf-8?B?VGlaNWg2VWRWODc3ejVnbGU3emRtcThaR2FOTG9ocFZKajZsS0gyMm4xdWFs?= =?utf-8?B?YmFWTUJmVUlwYm9kdTJwUnNIRmJQcUd1N0l0dDJxZzcyYjR0dHdseGlaMnhn?= =?utf-8?B?blBPbkw0YUNyaGhUVjNCS2NlM1lKdWFRZWZRcHB6VzBocndrK2J4Lyt0SVdo?= =?utf-8?B?OHc2OXBvYmt0RjZYbHpxUmNIdk9xV1ZxTXlQNENTVUNPdVNEYmVYNmhvUHpa?= =?utf-8?B?UXEwM0x3UG1tUFFUd3o1NG41YTJnMHFMZXEwVFQ4VjR6ZWlrZ2Jsd3JYOHpF?= =?utf-8?B?MVZNSGRzejBmbFVXbm5ic1QwVm1YcjhGMUI5SUZoKzlBNFpONnQ4cDJCV01q?= =?utf-8?B?MzgwWnl5K2NTd2grSTd6TFhkbUkxZFZOY0dJdkcvcDVLamY2MVE5OEVBZVZs?= =?utf-8?B?YVpxL0xtWEZhbFVabzRYVEpxbmtEZWNjdGh0WmM0bW4zb1ZKVG5SWWlabG1p?= =?utf-8?B?SzU2N25Mc3QvMXFySHBMcnF3UDZpRzNUY2JYTUZwU0hvd2FKVnVYREhwMEcz?= =?utf-8?B?bkVEdGEweDFrSEdocTRGOGFCMTVoalpjQkZrSEpFS3RkVzlCNEtMUXhMZWlm?= =?utf-8?B?aEhSZlFZcFVVVGN3QkhzbGpzMTdzNWoyZjFsQm5yV2VRNS9CZGtQUi84bWc4?= =?utf-8?B?ZDBzNWZFajRGdUVTdk5jL2lnYkFtNW9GQTdtbHNGcEhyZlhqa2VvZXNPTEdW?= =?utf-8?B?cTdER1Y1bzZQdFdlN1llK3lIVTJNcGV1ZDNiL1RrR1lXY2JaR0xXbTR2WU1w?= =?utf-8?B?THh1TnR3NWpOVXB6QWZXT21neHdZVXRtZDdXcHJJL29LaEJoOCs0NURaT2pr?= =?utf-8?B?UlhiWVliMjJRSUExaGlDMCs4R05VZ2pRU1VDait6d09WY0tCVzRXQ2lyVjVT?= =?utf-8?B?eVVnSHROdUVORlE4aHA3NktHWCtqNjhtVk92eElzSnVSeGRaMUJsNHZVdm1y?= =?utf-8?B?U3M2Vlp2YS85UlllQnFmWHgxQWxnSVFoMjZHc05tM1pReG1GVHFmY2l2T29K?= =?utf-8?B?UXRtUzJOdndQYUxuQkJmMmsxZjl4aWNDYzhzU2ErMDdXVVFPS2RyVmZRdFVj?= =?utf-8?B?T1ZiUlVnQUh3NEZZcDlFSHJNMlc4R1BnS1hJdjBVeTd4QisyOE9XWlhWOXBx?= =?utf-8?B?SGxFZTFvYW1MaWVHWWJFaFNReTdwdStqN3ZpOVBNWE5tWUtoYWJPaW9qbkhC?= =?utf-8?B?RFRvWUI4OXlYYWNzQTFKVy95WHR3UzhoS1o2T2dDM3ZvWVM5Y2t4N2xmcUdV?= =?utf-8?B?MlFuaHpJbk1LUUd5NVAvUE5QTDJhTHBMaUhKSWNtdFdyTCtIbUdlOE5HbE9C?= =?utf-8?B?SFJTSnF4clJDTmlwK1FWNkd3cnRER0g0UVBtaU5PcmtReERBUFVDMnIrZXZm?= =?utf-8?B?SnhVQVZZaWVoQnRJWGxLRVpQQjRSdFNVdEl1bG85ZGtkald4UE5sWTVlaUEx?= =?utf-8?B?cHdCSlZ5a2pDN0pDdjVqVy9mMU5YQ21OVWw2SVhVYUt2YkR5NmVUNlpzeXk4?= =?utf-8?B?M29iVjNuMkVUMXkxbjBLb09pUTBDdzQvY0RRRXNoMzRRM1Y2cjJBZFlUcy9j?= =?utf-8?B?Y0RXWEtoYkxsZTJGRWs0ZGhoL1J3cUlpVC9keFlxUDlSRmJ4ZXBic01pQkVp?= =?utf-8?B?ZXQrZmtJM2ViakllMXBQZE9uc1RxQlZDT1I1TlRKZXhCYmJweDFwQzhyRkoy?= =?utf-8?B?SDBQNTNtcVIxbUJWaStIejZmUThTaVhmeEZUUTlZVnlFMWlBc0tuYmt6Sllk?= =?utf-8?B?QXFoUk1MRTFsZjhFOW5FeEt2U293WGFYbnVidFphT0xGL1Nva3BxRStWZHZE?= =?utf-8?B?RnErOGdXckRJcy9tazJTU3pCSFRJVFdINlpZV2xobWpBelI2eGVCZ2VWSEFn?= =?utf-8?B?a1piYitJN0tBSGQwQlFYL24zNDZOY3d4cytPV0VzZGN2UU5vSm5pY1FtT1Bx?= =?utf-8?B?NXp2S2wzYlhyamJ6OTVVSFN5cEJQMFMyTFVYLzVUcnRHUThaeDhNMmhkVHo2?= =?utf-8?B?dHc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a514469f-3d1d-47a0-6330-08da643b79ce X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 19:19:43.7950 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HQJM1K9sNLgGnSc+KfmMDVuavnqpn33RnDHqw40ta7hbJYnXiGUk4ygyUzZF4SLrgrBM6FrFroAtoG4ZcDInMoCrM1epNkHvxvvFt5Tjvm4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4177 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-12_12:2022-07-12,2022-07-12 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207120078 X-Proofpoint-GUID: 90l5qejajIJQaoY7LC9GUmnpRHoQle1s X-Proofpoint-ORIG-GUID: 90l5qejajIJQaoY7LC9GUmnpRHoQle1s On 7/12/22 12:38 PM, Greg KH wrote: > Hi all, > > I'm seeing the following build warning: > arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction > in the 5.15.y and 5.10.y retbleed backports. > > I don't know why just this one hypercall is being called out by objtool, > and this warning isn't in 5.18 and Linus's tree due to I think commit > 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. > > But, is this a ret call that we "forgot" here? It's a "real" ret in > Linus's branch: > > .pushsection .noinstr.text, "ax" > .balign PAGE_SIZE > SYM_CODE_START(hypercall_page) > .rept (PAGE_SIZE / 32) > UNWIND_HINT_FUNC > ANNOTATE_NOENDBR > ANNOTATE_UNRET_SAFE > ret > /* > * Xen will write the hypercall page, and sort out ENDBR. > */ > .skip 31, 0xcc > .endr > > while 5.15.y and older has: > .pushsection .text > .balign PAGE_SIZE > SYM_CODE_START(hypercall_page) > .rept (PAGE_SIZE / 32) > UNWIND_HINT_FUNC > .skip 31, 0x90 > ANNOTATE_UNRET_SAFE > RET > .endr > > So should the "ret" remain or be turned into "RET" in mainline right > now? It doesn't matter --- this is overwritten by the hypervisor during initialization when Xen fills in actual hypercall code. So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes. The latter was not really necessary but harmless. So it can be 'ret', RET, or anything else that tools don't complain about. It will not be executed. -boris From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:26:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:26:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366024.596580 (Exim 4.92) (envelope-from ) id 1oBLWU-0006gF-EI; Tue, 12 Jul 2022 19:26:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366024.596580; Tue, 12 Jul 2022 19:26:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLWU-0006g8-As; Tue, 12 Jul 2022 19:26:18 +0000 Received: by outflank-mailman (input) for mailman id 366024; Tue, 12 Jul 2022 19:26:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLWT-0006g2-6t for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:26:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f540be1-0218-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 21:26:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11D04B81B96; Tue, 12 Jul 2022 19:26:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1CA9DC3411C; Tue, 12 Jul 2022 19:26:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f540be1-0218-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657653973; bh=KofZy0gS7enXRLvK5w5s70pOuM52suAS0d4+pv9phsg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=C+JpUI7Hlc73b9zL/pC97stcYKxyVPA2NzaJTw5CDhNHAWTdGQPl4eSAY2DrMC4yZ 4w5E3PHJwulm6Ys1IlHBPmCC+2Opm/xQnuZWr6p5ofmoxTUPqlxmpimVKTnLXUxJwp P0Ur70+AdZXROv+Az3KlC8DmWNqTme9x8yRZX0c4= Date: Tue, 12 Jul 2022 21:26:10 +0200 From: Greg KH To: Chuck Zmudzinski Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Message-ID: References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 12, 2022 at 03:16:01PM -0400, Chuck Zmudzinski wrote: > On 7/12/22 2:36 PM, Greg KH wrote: > > On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > > > The commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > incorrectly failed to account for the case in init_cache_modes() when > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > MTRR is disabled but PAT is still enabled, and that is the case > > > that the aforementioned commit failed to account for. > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > not correctly report that PAT is enabled in such environments. The fix > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > to account for. > > > > > > This patch fixes a regression that some users are experiencing with > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > previously it was falsely reporting that PAT is disabled. > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Chuck Zmudzinski > > > --- > > > Reminder: This patch is a regression fix that is needed on stable > > > versions 5.17 and later. > > > > Then why are you saying it fixes a commit that is in 4.4.y and newer? > > > > confused, > > > > greg k-h > > It is true the erroneous reporting of PAT goes back to 4.4.y. But it > was not until 5.17.y when the i915 driver was patched with a commit > that started using pat_enabled() instead of boot_cpu_has(X86_FEATURE_PAT) > and that is when a regression that started annoying users appeared > in the kernel. I presume that we only backport patches to stable that > fix regressions that are really bothering users, so even though the > problem dates to 4.4.y, there is no need to backport before 5.17.y > which is when the problem manifested in a way that started > bothering users. If it needs to go back to 4.9.y or so, let's take it all the way back to be consistent everywhere. thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:27:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:27:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366030.596591 (Exim 4.92) (envelope-from ) id 1oBLXK-0007MJ-O7; Tue, 12 Jul 2022 19:27:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366030.596591; Tue, 12 Jul 2022 19:27:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLXK-0007MC-Kq; Tue, 12 Jul 2022 19:27:10 +0000 Received: by outflank-mailman (input) for mailman id 366030; Tue, 12 Jul 2022 19:27:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLXJ-0007Lm-PD for xen-devel@lists.xen.org; Tue, 12 Jul 2022 19:27:09 +0000 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [2a00:1450:4864:20::52a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9ecf03bf-0218-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 21:27:08 +0200 (CEST) Received: by mail-ed1-x52a.google.com with SMTP id g1so11369769edb.12; Tue, 12 Jul 2022 12:27:08 -0700 (PDT) Received: from eldamar (c-82-192-242-114.customer.ggaweb.ch. [82.192.242.114]) by smtp.gmail.com with ESMTPSA id fy6-20020a170906b7c600b0072aed3b2158sm4117961ejb.45.2022.07.12.12.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 12:27:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 9ecf03bf-0218-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=z9G0wguDrAjcjW75nvr7+pGpjBAR/f3spr6nVa+W/E8=; b=hdS47UsIc8Fwz4zPSqtXitJJWQN1LCuo4FKPRv16FEUdcOd+jNhAGXk6U/TMsne7CY OWPbw7WcL1VYfnvV4p5u8jGRr1SAcNuC3JB/tUIXNd6rga6qu546Urpw38vlw6VCRppW xE/eOuxFIUG8W8kJhuH7U2LAWumu7eXZgS2QXB7z15N22+sMxDnTcLWXqP4yW5a2bWWD EeB5DzMFNIBX43mfFkybVmzucuCMjWFT2edBJfecKXTc1UQgfJ4ixOR2aMAUxt5Hdbpt v+UpC9bB0E+zZ5sVw+pSYlrKo4lWRgG4KJJljjPsKwSAeRAlmX8GmNDoabxxTevf+1kw C97w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=z9G0wguDrAjcjW75nvr7+pGpjBAR/f3spr6nVa+W/E8=; b=DbEa8mmiVeQ5C4zIP1Q4atF8Rvp/BWrLsren0Oup4NULQX/yXCCbB7bnijNmHgIEMP QYw9UBrO2EKUNoNNp0xpnqLWOaLsWyNgzuYbW8ElxxpzaSSn9VTodDwoFcczHRbCHg0r K6oqAVn3aQprs+2NxgKN1CTzVqfW0IigjIlYWbjF5ZchkBaFc1vYy58sWAkoRJO4SoQq 3AKto7Fp1NX1Zi6hLFxll1ZUCPzEUmaEoJtfEjjRxv5YCxb5c2enSxNxSTAtiqe60B4T UkE8vcE1HnNU3sAldn9v15/Xka3NS9QcvTJA+0rwxPrmEMio/PxuiDM3xXq6zdsX1JFX DNVw== X-Gm-Message-State: AJIora8cjgE77HD2oGuYyYUkNqFt/+p4TXMiqXCogOPamtvr/WjCeZDp D5QkBTIOvaUDZzz9zMpdfMU= X-Google-Smtp-Source: AGRyM1v8019adYsp3ny2RyVvIYKz2DtuN+HXhP1DCr3GueiOWQEx9YpzP62n3PtvTXXlbH7Gs0vgYg== X-Received: by 2002:a05:6402:cba:b0:43a:6b17:f6b5 with SMTP id cn26-20020a0564020cba00b0043a6b17f6b5mr34455445edb.330.1657654028245; Tue, 12 Jul 2022 12:27:08 -0700 (PDT) Sender: Salvatore Bonaccorso Date: Tue, 12 Jul 2022 21:27:07 +0200 From: Salvatore Bonaccorso To: oss-security@lists.openwall.com Cc: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, "Xen.org security team" Subject: Re: [oss-security] Xen Security Advisory 407 v1 (CVE-2022-23816,CVE-2022-23825,CVE-2022-29900) - Retbleed - arbitrary speculative code execution with return instructions Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, On Tue, Jul 12, 2022 at 04:36:10PM +0000, Xen.org security team wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > Xen Security Advisory CVE-2022-23816,CVE-2022-23825,CVE-2022-29900 / XSA-407 > > Retbleed - arbitrary speculative code execution with return instructions > > ISSUE DESCRIPTION > ================= > > Researchers at ETH Zurich have discovered Retbleed, allowing for > arbitrary speculative execution in a victim context. > > For more details, see: > https://comsec.ethz.ch/retbleed > > ETH Zurich have allocated CVE-2022-29900 for AMD and CVE-2022-29901 for > Intel. > > Despite the similar preconditions, these are very different > microarchitectural behaviours between vendors. > > On AMD CPUs, Retbleed is one specific instance of a more general > microarchitectural behaviour called Branch Type Confusion. AMD have > assigned CVE-2022-23816 (Retbleed) and CVE-2022-23825 (Branch Type > Confusion). > > For more details, see: > https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1037 Is it confirmed that AMD is not using CVE-2022-29900? The above amd-sb-1037 references as well both CVE-2022-23825 (Branch Type Confusion) and CVE-2022-29900 (RETbleed), so I assume they agreed to use CVE-2022-29900 for retbleed? So should the Xen advisory as well use CVE-2022-23825,CVE-2022-29900 and CVE-2022-29901? Regards, Salvatore From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:32:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:32:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366042.596601 (Exim 4.92) (envelope-from ) id 1oBLbv-0000O8-E4; Tue, 12 Jul 2022 19:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366042.596601; Tue, 12 Jul 2022 19:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLbv-0000O1-BR; Tue, 12 Jul 2022 19:31:55 +0000 Received: by outflank-mailman (input) for mailman id 366042; Tue, 12 Jul 2022 19:31:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLbu-0000Nv-Al for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:31:54 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47acffc9-0219-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 21:31:52 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 75E9E61947; Tue, 12 Jul 2022 19:31:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 58C5FC341C0; Tue, 12 Jul 2022 19:31:50 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47acffc9-0219-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657654310; bh=O5l3DDkCL1GLC1cLcZh7E/j88FiYHXorbNoNPs9qYjU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Y7mlHgNgtuET3TxAjKenZBXszlKL5EWencfe+7pE6MvAfl5dII94BZePOvH7Y9v+9 aeQwJTYBa1Q8k/ixcCtlq5Qx/t/S6QtFtd1Qt0KqzhyG2/tPiR+MxMsBb4qiolssHp FNhjcDS/z85gj8K/4anC04dMYLqVoHhrA8C7EI5M= Date: Tue, 12 Jul 2022 21:31:47 +0200 From: Greg KH To: Boris Ostrovsky Cc: Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote: > > On 7/12/22 12:38 PM, Greg KH wrote: > > Hi all, > > > > I'm seeing the following build warning: > > arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction > > in the 5.15.y and 5.10.y retbleed backports. > > > > I don't know why just this one hypercall is being called out by objtool, > > and this warning isn't in 5.18 and Linus's tree due to I think commit > > 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. > > > > But, is this a ret call that we "forgot" here? It's a "real" ret in > > Linus's branch: > > > > .pushsection .noinstr.text, "ax" > > .balign PAGE_SIZE > > SYM_CODE_START(hypercall_page) > > .rept (PAGE_SIZE / 32) > > UNWIND_HINT_FUNC > > ANNOTATE_NOENDBR > > ANNOTATE_UNRET_SAFE > > ret > > /* > > * Xen will write the hypercall page, and sort out ENDBR. > > */ > > .skip 31, 0xcc > > .endr > > > > while 5.15.y and older has: > > .pushsection .text > > .balign PAGE_SIZE > > SYM_CODE_START(hypercall_page) > > .rept (PAGE_SIZE / 32) > > UNWIND_HINT_FUNC > > .skip 31, 0x90 > > ANNOTATE_UNRET_SAFE > > RET > > .endr > > > > So should the "ret" remain or be turned into "RET" in mainline right > > now? > > > It doesn't matter --- this is overwritten by the hypervisor during initialization when Xen fills in actual hypercall code. > > > So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes. The latter was not really necessary but harmless. > > > So it can be 'ret', RET, or anything else that tools don't complain about. It will not be executed. Cool, thanks. But what about the objtool warning that I now see? Is that "real"? I don't run any Xen systems, so I can't test any of this myself. thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:34:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366051.596612 (Exim 4.92) (envelope-from ) id 1oBLeW-0000zl-W1; Tue, 12 Jul 2022 19:34:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366051.596612; Tue, 12 Jul 2022 19:34:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLeW-0000zY-Sn; Tue, 12 Jul 2022 19:34:36 +0000 Received: by outflank-mailman (input) for mailman id 366051; Tue, 12 Jul 2022 19:34:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLeU-0000yq-O0 for xen-devel@lists.xen.org; Tue, 12 Jul 2022 19:34:34 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6fe1df7-0219-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 21:34:31 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id j22so16147413ejs.2; Tue, 12 Jul 2022 12:34:31 -0700 (PDT) Received: from eldamar (c-82-192-242-114.customer.ggaweb.ch. [82.192.242.114]) by smtp.gmail.com with ESMTPSA id l1-20020aa7c301000000b0043ab5939ecbsm6522136edq.59.2022.07.12.12.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 12:34:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: a6fe1df7-0219-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=cUibCSxMoDeR+V4rKvezXaJVFqRh4BDSNyqzyGJ45Gw=; b=p8OpUHIOiSngRVmkadDU59ENA5YE1Vjf/ta6crjLkw2cIEsXcHQfAIepCdgvM24fb5 /hv2mxkNHj4jlc6+22Xm3l4+diOCMNc4W9l7YwXdEELS5JMfd9b4LvKYVFftAIDCesE0 9QR0ThnYp5JjEhw0QCf4LfHuE1I+n3eZwJAOAuCfjMlNwTB5wknD56wXdl/hlf7i0Npk wFD1Kx/G7Z9zERMfokbwJEUOgdgQqReOXm/8ChRsnVgJ89rOeG0jj/yCEU0Y2eJfkQqU s++OUtmVhAV/dvUwxUPkaPKYM1bs7a7ULMv2V5DLyxQal+a7IsbsKGwM63UUdbBwybSM I94A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=cUibCSxMoDeR+V4rKvezXaJVFqRh4BDSNyqzyGJ45Gw=; b=FP62xSJO0P5kY71PevlKl+5dcOidyg8Um1RE6y0p0sEBY8mwL3vuZGNZvRT5ACIbGS nyiUeC+2piVYO37aSLIPgo8lPIt9ri7RLPxJgE2367ecu+mt5Aa712N5VokTWKIuiZjQ i79x2UpGruQE+p/WleD5O8rm5+kYNXEfkPbJkNe8NYqcsDc8Vw+teeC8x3u4Or5NcDfV JRvpxA9lALCF1KSD/Gcm8x0C1NLzeAh24NrcbvWKm04qwevYr0x+62IYGZrTIiilSQv5 JKl8DlzGNOjEXd94liKSmZFpTrW3El3usnUb2qskrV5dE5lbv3gP5AaGGBNB5jsK6sQ8 R4kQ== X-Gm-Message-State: AJIora+NbdEd/pqsqK/NsLJkJWdnHir4AUKdoyOofCWvBi3ikO/Q2iu4 UVJpkkaqWi3+TGTDJN/5UATZEN2zchQP/w== X-Google-Smtp-Source: AGRyM1tEKkn1bdaPUb7b1bLudzPimOOYGYcxvbrVbouCSR2q/lPhvsXhcnPVC+v9w+hQWUzSox3ywA== X-Received: by 2002:a17:907:2718:b0:72b:6b65:37dc with SMTP id w24-20020a170907271800b0072b6b6537dcmr8356123ejk.425.1657654471466; Tue, 12 Jul 2022 12:34:31 -0700 (PDT) Sender: Salvatore Bonaccorso Date: Tue, 12 Jul 2022 21:34:30 +0200 From: Salvatore Bonaccorso To: oss-security@lists.openwall.com Cc: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, "Xen.org security team" Subject: Re: [oss-security] Xen Security Advisory 407 v1 (CVE-2022-23816,CVE-2022-23825,CVE-2022-29900) - Retbleed - arbitrary speculative code execution with return instructions Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi, On Tue, Jul 12, 2022 at 09:27:07PM +0200, Salvatore Bonaccorso wrote: > Hi, > > On Tue, Jul 12, 2022 at 04:36:10PM +0000, Xen.org security team wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA256 > > > > Xen Security Advisory CVE-2022-23816,CVE-2022-23825,CVE-2022-29900 / XSA-407 > > > > Retbleed - arbitrary speculative code execution with return instructions > > > > ISSUE DESCRIPTION > > ================= > > > > Researchers at ETH Zurich have discovered Retbleed, allowing for > > arbitrary speculative execution in a victim context. > > > > For more details, see: > > https://comsec.ethz.ch/retbleed > > > > ETH Zurich have allocated CVE-2022-29900 for AMD and CVE-2022-29901 for > > Intel. > > > > Despite the similar preconditions, these are very different > > microarchitectural behaviours between vendors. > > > > On AMD CPUs, Retbleed is one specific instance of a more general > > microarchitectural behaviour called Branch Type Confusion. AMD have > > assigned CVE-2022-23816 (Retbleed) and CVE-2022-23825 (Branch Type > > Confusion). > > > > For more details, see: > > https://www.amd.com/en/corporate/product-security/bulletin/amd-sb-1037 > > Is it confirmed that AMD is not using CVE-2022-29900? The above > amd-sb-1037 references as well both CVE-2022-23825 (Branch Type > Confusion) and CVE-2022-29900 (RETbleed), so I assume they agreed to > use CVE-2022-29900 for retbleed? > > So should the Xen advisory as well use CVE-2022-23825,CVE-2022-29900 > and CVE-2022-29901? Nevermind, I missunderstood the wording and the advisory just mentions all the related CVEs correctly and made a thinko. It might turn out that CVE-2022-23816 will not be used, but then the title would read only as Xen Security Advisory CVE-2022-23825,CVE-2022-29900 / XSA-407 So please disregard the question above. Salvatore From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:41:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:41:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366061.596627 (Exim 4.92) (envelope-from ) id 1oBLkU-0002f1-Rq; Tue, 12 Jul 2022 19:40:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366061.596627; Tue, 12 Jul 2022 19:40:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLkU-0002eu-NZ; Tue, 12 Jul 2022 19:40:46 +0000 Received: by outflank-mailman (input) for mailman id 366061; Tue, 12 Jul 2022 19:40:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLkT-0002ek-Es; Tue, 12 Jul 2022 19:40:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLkT-000747-Du; Tue, 12 Jul 2022 19:40:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLkS-0007tP-Sp; Tue, 12 Jul 2022 19:40:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBLkS-00071v-SH; Tue, 12 Jul 2022 19:40:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xEgzwFyJ1h97J4cHBj/Ln0Y7cXsp2KVSxz/PY0L43Q8=; b=2zXrfSmaE8RrwXEkDC16LoVtt0 mhwWCbM8jf7f6qqy4DJ8mVJewxgDg5/ZSJjO7G3Z0Hf1PqRk7kOe+XkMN/mzJZaGo0ml7elK35FCG GmWkZ2429GQRa6BUqIgB/vDopI7s+E8ThT71ELha6MOjp/A+00L8pEQaVngee1bWNZhk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171602: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe X-Osstest-Versions-That: xen=033ae6f88be198b8f56043f94b7076b79b5e447e From: osstest service owner Date: Tue, 12 Jul 2022 19:40:44 +0000 flight 171602 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171602/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d8cb7e0f069e0f106d24941355b59b45a731eabe baseline version: xen 033ae6f88be198b8f56043f94b7076b79b5e447e Last test of basis 171599 2022-07-12 14:00:30 Z 0 days Testing same since 171602 2022-07-12 17:03:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 033ae6f88b..d8cb7e0f06 d8cb7e0f069e0f106d24941355b59b45a731eabe -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:48:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:48:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366070.596637 (Exim 4.92) (envelope-from ) id 1oBLs6-0003Sp-K5; Tue, 12 Jul 2022 19:48:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366070.596637; Tue, 12 Jul 2022 19:48:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLs6-0003Si-HV; Tue, 12 Jul 2022 19:48:38 +0000 Received: by outflank-mailman (input) for mailman id 366070; Tue, 12 Jul 2022 19:48:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBLs5-0003Sc-4G for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:48:37 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9b679076-021b-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 21:48:34 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 19:48:30 +0000 Received: by hermes--production-bf1-58957fb66f-fvhff (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 971ea9941bc8ae4c927179b995a77a93; Tue, 12 Jul 2022 19:48:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b679076-021b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657655310; bh=pgrpjNqb385gEEgRLF0Q/rt+9pomAz4bgE3sZ8LNtkM=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=cGK1XAumi8ewsF02TDfEwvDxKjXEE/9dyYBYKSwydfPHvLpmv8AXuXlWouC0txtVox6a4tuf1/ZEbNeprbOdN+MpnPWHSKsPYE/tpoM28eGUdjY3ncxa/bzZ8sMq5o+dWSvZJUP/jGYd0S/+TZhfmjWlgZWJVb55iBqtty3fD9nmfsWhp1HpoDnN2TdrQ7FY9bzAb2myFGBkPzucdxIHKcXwsfEvbQjC+nr2qS6D7ct5pS/pKLdWW/hlrgyZ8vO32M7qBJNQD9K4n9KRi++dS42Z+KvuweDe/fmNU2/KkzFwIXybY0uOsmJ2kD5Obl/+4bUEadN4MNT+7HbbDUBJyA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657655310; bh=h/lH+nNJqzfnjk2ZuaQqpRQOd5bw1El5erq2VjEJbzC=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=iPoSOZtBsKACXCciYie15Rq8Perhe6oJ9HL/fN+KRuNjcGdFPEcN+EoXh3BzdpvtY0ScMF6y4RLSKBZDrvsJ9zfzGvPWURZ/b4kUhDA2mDukGb+6SBLyANhSjXNWK3MlowYA+9XOL/IjiulZ7RiAZzj8U8nMGQom5V+SLO+UWV8qdv11xFnmJPBFWdflBDbDTKICnyASpNHt4Gws3kk6HW9p4phG8ZE5MSQRmKzCHJuBAtIoheYusTbPh7afmKfo7o7pEFL/t351W5lrjVqwsyrwkiLN2wSRw1kYiJ+azATUSQJJHmohC/2SZ87bey1aMP5Cb87Vi9TvwnBmyKh/cQ== X-YMail-OSG: f0kMs3UVM1nloicb8jexJ_OKjrYz7NLzq7Mukf1rrF8mhZWIkQCqPlJdj4i0JKh AMAlWciZnf_KHh1uRKHdBbMokQcd4tFlOuJg.l65dnPLR0KUgrcIVzjWorOdJ6kJKI8AXML91uRm 45oG2eXHRcibvH4vEbZqrU2mY8c7z8RFCk5TPn1A_RZy5mDvsofRlX9AYOdhI9fIo7z9fwpYQdFN YOKlXLEKpbYmFPqG6RbMKC0dw97_IhoI0W7gZJmHc.3Mie6RSEQcMh7NVZmH8WQ0PY31ysm0yGeo vTFemmChWd0LrAnPsfBnkyZ3sPGYpQU3LXcbQy2IcSTVTQGcVMlLr3tjxE4Uqj7e2vqo.wqpyO7s nuGiIfeXv7Qk3ZFIzdSb4u1U5tlIxVj4Og6C1TeUlZV7U8adjXgsmbAz7TwZ7VbQ4r.bxRDGyFzw bMwogHOS7KfGXMWUK3X3qs0EGYNw5vLxagG0q8Asqj6I4CTTUkJHiTIg5k_8iTpPNjCUYfKbUJlM dD3TRvPlq1e_xTaxFnwY36M0dHAMnW3vqyrrMCjfe3vNKU3WwIeHwR.5_OXu.X5mJp.Vfxe74kay D6F9wY7C25HRAAwqkOnCysejo3cnJ5dIMARt4uWQHzxaX7769MICz.zqi8JUQhTKnYtTu_Cs9wFZ a45o90eHUYtGK43u1hnDQjI_r_IjZj6TIHotzI6J5n8XvPm3g7PzHi3s4rFYezL.pm46nKCvDs5g o60ItcLaxA9LhN1UnsaEGZgb.U_2iE5qutFYBvDzTSeWlP4moO1wFOG0bZE1iQYg9rbC5ReuN3de _1.ehlOZjUvgkRwHA3i531N_ULmhK8itT5OIxzWDpjFkafTuKO6Qi3WzNdclTsVyC7JhjYCy6qqN FVkBtPge0IPtFiwJ9NRaXy2AR24lOEqGpZgqcQwz_Sm_QL7n7tEGooTSbUAknIGX77Usl7fMIZlu z_H2qW.SooXOMW9FCd1RtdT5Iz2sAildSVwLc0gow6.sRw_bjM2c2G.2O08TfhiCTgnRx7LAsACL z4NZSj4xnJs84hcZtsZzYR7AQSE_Ei48EilayTo9V1HU.5evMR6TA2HFbgJ4DUS7GqCTCMzQYbos TR8sBMFABKtxhV_NkprZM7D7k.XTtYEu37JR5xcBpO54tWu.UjBdKOxRAWZ8.0RFdDoTjqygsJtr POa6jvslWrRoQ8QiFJxKqUYcVia20_y49p4I51eDiY..LKD5ZhqicoJFiyHqbJK1EthG1agLC850 25m0gKFZ86CJrP1T8oBwyXnc95KSFt2xVMpAomwCutUjVk38qdhUfLiTtH831Hz8ima0NJfO1hZX EU1WaPHpEVLpV9N_p88VO1HMeK_gwqfImVi.HdIfRp2KTzOVBZKB_GRj9bqJYUG6xMJJ5VnLIscU pGR3QT9a_vs.aOInnjOEYK.S2v3uL0MjFuPCEWS1QL58lubW0aDr2I7wHwagr1UEySspAFPUyO.I T8p_OvXKHGvoSjF6lXujTAITwdwY8oaPkRmbXEaGrm7Gwm0eUtozmp8LM3KM6i294.1TQeS76952 Wbd4VpkZMBBbCsc2IH08bjEE_h8EWmZRdZ8HpuCQjMRoQNMeJIcg7.Mc2_MVl9NB65SrobDbuMo3 2K8s99RpsUpDGDm3.Bp.YcpAW8i3tCM5MrE8fjAjQnZGSMyKb7fdPl027JxFlFEHZ8ECRsVWEdrp JQwFz7OajkuTtY.f0JBydVLtdRR0R8emJGqOVeQ_6u9ZBhi4fEk9jJV0imkWQOrgCXim83E.uy4i MhwWiXLjexdrDqvOjv2PnsiNvAHd6VLk239OS4LGpc02FNN.lRx8xXH0OtxROc1qL.MZRQG6_Uf7 FzNS_YDwA5pjPXlpQ8l9CMRf3.9Ts2chwfpgHgXJVfyk2yGriwuJr3G9Gi9ssjxcGETZeNmWMDW. ciGrTJhCsKi6UEzWPyI7iw9aFENrCz5yYRaMMsvbZmN9WrSX7v60cCFDZgJlsK02Q_ZU.9mg61LK I5OOLbc2Z9Acbpa2HvOdjpfw_vQeRNKPtt1ZVcyGKc_IgR9r2ATBxZzja5OWj4YHmV2OQqKAKqNC QY5Ft157jRfoxt7zcyunB6CMYsNrMWbT1rcwEmLxyk6vWikvw51aJkMJGv.cIStEKBAycwJGhrg2 0PWzfs3PpPrwATELsM9EQaS9YbkfOJscmdXyussGcSV5vPXbJ7bIp.lg6XjZHhBHA92SwAGX4ZSm SwmY- X-Sonic-MF: Message-ID: <32c86239-c434-369d-b6a7-f6f88cf5430a@netscape.net> Date: Tue, 12 Jul 2022 15:48:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , linux-kernel@vger.kernel.org, Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3305 On 7/12/22 3:18 PM, Chuck Zmudzinski wrote: > On 7/12/22 2:27 PM, Juergen Gross wrote: > > On 12.07.22 20:20, Chuck Zmudzinski wrote: > > > The commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > incorrectly failed to account for the case in init_cache_modes() when > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > MTRR is disabled but PAT is still enabled, and that is the case > > > that the aforementioned commit failed to account for. > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > not correctly report that PAT is enabled in such environments. The fix > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > to account for. > > > > > > This patch fixes a regression that some users are experiencing with > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > previously it was falsely reporting that PAT is disabled. > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Chuck Zmudzinski > > > --- > > > Reminder: This patch is a regression fix that is needed on stable > > > versions 5.17 and later. > > > > > > arch/x86/mm/pat/memtype.c | 12 ++++++++++++ > > > 1 file changed, 12 insertions(+) > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > index d5ef64ddd35e..0f2417bd1b40 100644 > > > --- a/arch/x86/mm/pat/memtype.c > > > +++ b/arch/x86/mm/pat/memtype.c > > > @@ -315,6 +315,18 @@ void init_cache_modes(void) > > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > > } > > > > > > + else if (!pat_bp_enabled) { > > > > Please put the "else if {" into the same line as the "}" above. > > > > > + /* > > > + * In some environments, specifically Xen PV, PAT > > > + * initialization is skipped because MTRRs are disabled even > > > + * though PAT is available. In such environments, set PAT to > > > + * enabled to correctly indicate to callers of pat_enabled() > > > + * that CPU support for PAT is available. > > > + */ > > > + pat_bp_enabled = true; > > > + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > > > > Wrong indentation. > > > > > + } > > > + > > > __init_cache_modes(pat); > > > } > > > > > > > Any reason you didn't fix the "nopat" issue Jan mentioned? > > > > I asked you twice to add this fix. > > > > > > Juergen > > Sorry, I did not see your request. I will resend with the fix > for "nopat" and the other style issues you mentioned. > > Chuck I will also re-compile and test the new patch before sending v2 and unless Jan objects, I should acknowledge Jan as co-author of the patch since I will be using parts of his proposed patch to fix the "nopat" issue, so I also need to get his sign-off before sending v2. Jan, how should I obtain your sign-off? Chuck Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 19:58:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 19:58:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366078.596649 (Exim 4.92) (envelope-from ) id 1oBM15-00054M-EJ; Tue, 12 Jul 2022 19:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366078.596649; Tue, 12 Jul 2022 19:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBM15-00054F-Bl; Tue, 12 Jul 2022 19:57:55 +0000 Received: by outflank-mailman (input) for mailman id 366078; Tue, 12 Jul 2022 19:57:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBM14-000549-9O for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 19:57:54 +0000 Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e924be19-021c-11ed-924f-1f966e50362f; Tue, 12 Jul 2022 21:57:53 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Tue, 12 Jul 2022 19:57:50 +0000 Received: by hermes--production-bf1-58957fb66f-c5dsp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d650e0fd81500940b6eca43bb599a29c; Tue, 12 Jul 2022 19:57:47 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e924be19-021c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657655870; bh=gVNIDnB0rwg0U52jp8XQ0N1+sFJsTQLMngaDbXUXbMc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=kVhI3kveFTbqCZCXcm5KMuGkeSj49gYXQgkACEx7MdQKIiDicrsy7FQOyHbz/ZC+cfjNmlgekM6pGmU6CHx+uTcIBJXhvLHi9J09UcMBiRhX8nyYD7ZuPOflZU/qwvvk16G3gKd0OkCS/s8oDEjtUJe/SobaVSKkLRVb8dcvfLSj5y1+TOFP8kfoyMy+2clfDJmYs3lQcqg92a77xLzuIlnnlZ4WeIQlIrxzV5F4EfWb/Bu2+vFkSk2NLezjg7lRgFrIHVmqLvUNnBxKK03wGK5StOtNS9dtXM6y+u4j5Tm2w2dFWSC/4KWllYRrM1pBk9oeKvo0E0N/xBE3AdmGoA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657655870; bh=IiioFCTJVjJjhIygn2ZBqdTmcjLz4leAoJuVtgdQfQy=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=XvwyZwISFXfE170G+U12KE+WRqio3bvNPKbWeYzzrKooZmFYTTO4haY/dlZIrGGdH0+z+RQDd14uRU5wTzQQvI0Yt9/9LBnyLl4vPbZpUBMByfCsg+HUb6qDWpxt3ZjQa/3eqlLaTtX7MAYnO/egHngK44GzjFwIUS3jcpZ/Zwvl4Dpm4gjyTvBgcD36oatrbYgYk3dQtGYBOrIyMWwOBz6rrdZ2Qulm5+qisikGuBksp1Glx1plHzrVwYxAfzzlcckV3WcOQ3gmNJO0oTalVp1df4TrIPuG6X2C3aYeO7vIF6IibbA3W0+ZNXoLLHMcTVfvjGM0xIojVeF/F1YIGg== X-YMail-OSG: Gp6QV24VM1keOGlwbdklQrOy4xcanvYpcd4oO0yfIlFrKzTDqN6x4kI4wGVkqG0 DyRz9VE2ZpDXWWvD0_mET1e570_5.NsxDx6jBC2YSrm8LYSPC3NqkymDg3qmxkPYnkx4MWYeRhT7 oEgNfe7ti3IbW.ZwzZdAxWN9rWdmBgvkZhi6xTnqV5Fhtvr_nYoc6.vAYml4jZ0KfLkbeRQVdr5g mYZHWPgXRkKuTeBXNMd8nWIGy0eKPRhBJ3EdqnyN4WWe5NoqoakfsUftnsmB6HYd65Y9h2QTiT_b fSD.wj5mUXU_NKfOAOi_FjWXTF6bGNstZYj8TM79BsG19gywlusTiclyxZTjSun8gnVNE4dXZryw LC5HEucVM2fZaKmj9uVEcmyTfjIdRFq3O5V2xdkyOvaorhSbgmgROyTJnQtyI3Nfz4yKqRaH_GlW D96eIAWIFWrDfQ4NUfQhrA2r5rvHWkzuF2pbepkF._c5cMBQDe_iIN2LtLknKuroRKxfqESK8W4q N3uVBAeJMtsfPeKUGMwVXqhCY09r8bAp_xrHtVUDNFT_Ai35Urk2KXoXrvlozqxgBpnH.DYLCXK0 .2kvBpFwCoibAF3zsgFS8FvvJLiWIhCXrg35dNc9h.56HIxa8iGtMa80h8jtDW0_XG8c8wrDmvOX SAPCza08JYQWPCnPDx33yGhxEoiyN9lkJQvwsfQlCIWkZCUiBJaAPHfRV6Y58wwmIi4OY9ImioFH WUA04Z0wHAKazk.LL5CT37ZeSsIT2b5.88wryZC0XDjO8Al6RjAusST4cXlhz5GDClOq9LRM2DuO 8H2zCMYoyR5R1OUt4As5k.kk_qWCYbW2JuqHhk5WGLLtUF6DejjjClM9E1mvkdmpfzSeeheeQoaN 9uj4eqfUsHobpNOD.c36jVglUPM8Wdbyztj0knaWh3bf7zdL5JD1MDz_Bemzt5HZeUItScolniu9 eLx7BizyTIPm6IilClF1FK.nv2wE_iX3UYYFXgeVlYKz_MV3jDWMaFE_apcqTjYqAbPu5BX4xVn2 XAg3ZC4LeXQUAD5ikg36aDnLz5b3dsI4as7Y98hzU7rKkp7CWs4IrJN2qhdZzLxnQIYczJYen7Jx Qm2Krsbsz7JMsptS4EtjhqCOAGc6f8o416SVgVFaN1rhsQGYP_EM1stBgL3R9NrZ2h_ImpjUvF2c dDQZdVubjdc6C3Ae0s90ZCxgyJDXz6.7OO4g6smW4IS2_En8Zwo6zMopMAjMhO3cjwqs4tc7gQhJ WWHyKJ9tGQ0ifXKkSqNXbAj6naP6LMF.2kzBcW_NuhFpy01S7.nB1UuyA4uPzO4YFGrN8vI9VaMe gQoAD_G_KCiC2qu457uYKTXcL6ztzxmFkiU.A5pysFpxdByAr7jUZpsOliC3n8_b3dfAth8Z4htx w9fuqyfONy7Yvftqt.rE_87KFHLI1ricTVo1YjrMMvEXBOh5CiW11OW8K9StLnoFFXzX2E6U56VN 7ID_2vBccfhOi2YafF1kXPJ9mv4EhBaHgihwA62GUy.gRsFkRhnLqRd.Jj0Ad4V.n1TQzsk3UHxm 72Tuv0.DUPJoAcdTOrFv15srf5aOML.sG59a1uY.ZBMa_2QMb3znZ2zshTUdCkTYVR9bEBomTtpJ DkpJSkZB7SeNrlrx7Kmc5fEuubKmVX5UglDGzxKsmJosybGFXlCC7P0O4dNgAIcWM9ZcnNYBUSxC Cd3tULROZQorHjxaC_C2WhvwnPjCgPp.lqb7Qb_x99yVz5ufuKsEuW26GUa4Q4O7NNGW.75z7tTB arLvwCeBaGutJuf3fLXUNxgLzCKzmpmZyZ5NdWr4iIieKHVCwu3IKjj8mItOO69gTqCvn39137kZ D0CeE4r3x7of6a.A0htBZPDVEGH9xLxP1yUjy4EGti1R7MCu_APBJBkVQjvqsUVC5KHdayk0Sf8g ..Ych4o6h1LhF17OgYCOQeWa8_7C9Sqem.F6mPg0_zRlHgxx9ZbvBEU2LQV4kmzHGqQbHDMExW9P pdbpaOY6.lvKJLrDGj6hW4t3IYfr0XIPlagDM2UjcEm9do44QvD31xjq9cRDQCQf_DrLJhv_QzVZ VvskVNIUzJBvo8WYKztL4e3utwl.4UXT8o6KC.Ncc8asv0iQTuJdkSw1XBoigwRS1NRWVaG.Zyxt nU4PttDIqE5wgfuYr2YEz2zz1veAwKM7Vq_0CVWZtNqhQw54S4ICop6__BAv9yrzFAFscU2qExaR VViEnHESDsg-- X-Sonic-MF: Message-ID: <008ff24c-d059-8d39-5e57-6f5e9de0dcbf@netscape.net> Date: Tue, 12 Jul 2022 15:57:45 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Greg KH Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2934 On 7/12/22 3:26 PM, Greg KH wrote: > On Tue, Jul 12, 2022 at 03:16:01PM -0400, Chuck Zmudzinski wrote: > > On 7/12/22 2:36 PM, Greg KH wrote: > > > On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > > > > The commit 99c13b8c8896d7bcb92753bf > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > incorrectly failed to account for the case in init_cache_modes() when > > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > > MTRR is disabled but PAT is still enabled, and that is the case > > > > that the aforementioned commit failed to account for. > > > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > > not correctly report that PAT is enabled in such environments. The fix > > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > > to account for. > > > > > > > > This patch fixes a regression that some users are experiencing with > > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > > previously it was falsely reporting that PAT is disabled. > > > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Chuck Zmudzinski > > > > --- > > > > Reminder: This patch is a regression fix that is needed on stable > > > > versions 5.17 and later. > > > > > > Then why are you saying it fixes a commit that is in 4.4.y and newer? > > > > > > confused, > > > > > > greg k-h > > > > It is true the erroneous reporting of PAT goes back to 4.4.y. But it > > was not until 5.17.y when the i915 driver was patched with a commit > > that started using pat_enabled() instead of boot_cpu_has(X86_FEATURE_PAT) > > and that is when a regression that started annoying users appeared > > in the kernel. I presume that we only backport patches to stable that > > fix regressions that are really bothering users, so even though the > > problem dates to 4.4.y, there is no need to backport before 5.17.y > > which is when the problem manifested in a way that started > > bothering users. > > If it needs to go back to 4.9.y or so, let's take it all the way back to > be consistent everywhere. > > thanks, > > greg k-h I presume you want me to prepare the backport patches, or at least the ones that need the patch to be significantly modified to apply to those branches. I expect older versions will need the patch to be significantly modified to apply. If not, please let me know. Is 4.9.y the oldest version we are still supporting? Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 12 20:24:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 20:24:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366085.596660 (Exim 4.92) (envelope-from ) id 1oBMQS-0000AN-GR; Tue, 12 Jul 2022 20:24:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366085.596660; Tue, 12 Jul 2022 20:24:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBMQS-0000AG-Dh; Tue, 12 Jul 2022 20:24:08 +0000 Received: by outflank-mailman (input) for mailman id 366085; Tue, 12 Jul 2022 20:24:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBMQQ-0000AA-HE for xen-devel@lists.xenproject.org; Tue, 12 Jul 2022 20:24:06 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 91c36cd7-0220-11ed-bd2d-47488cf2e6aa; Tue, 12 Jul 2022 22:24:03 +0200 (CEST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26CJXoOn004672; Tue, 12 Jul 2022 20:22:49 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71xrg7kp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 20:22:49 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26CKAbxp017395; Tue, 12 Jul 2022 20:22:48 GMT Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11lp2173.outbound.protection.outlook.com [104.47.56.173]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h7043j3fh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Jul 2022 20:22:48 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DM4PR10MB6015.namprd10.prod.outlook.com (2603:10b6:8:ac::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Tue, 12 Jul 2022 20:22:46 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%4]) with mapi id 15.20.5417.026; Tue, 12 Jul 2022 20:22:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 91c36cd7-0220-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=NJwkzDuOXR0dqbj5lwa/yTDUgZF+ahp8tDICCrXCnH4=; b=PthT9Wd/EtfEN22RNTPOCUPQBYIvnAfi7yOwztGS03OIwXP5jvcSSlhYBgJA5RoeaVvO we+hf2+YChTogfiR3cTPUrFt8/GA0fCtH2hWexQ0vzlGeU/MwyjOQNPtNMTjllsaxyDs IamTRGTbpqY6ZKNvD0CckXTYxgxXpI/k6bHrLRknqLhSE649Db92KhVaE15TIJyMwvWA whY4RssHC6rS3Z428nfVRTDBbCWz90ssja5ujM+svV62bJjq+PG4QgA0bYn2PZmIm8bx XikNziJfqjjN6s4SrwfjIlpo79Shpy2+FdiOVSeXBEDMbOP5Q4WRusai73JkQ9Rkct36 1Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vmd5jYL4QWpEttAyeK3G5py7CsLFjZb0ZNbO536mo3ceUCWLtwgqtc7CbrapG/AK499oQf866A6UIXt9jDSdtnhFIg16Nl6phPs/iXtKkEUJ4IK9Fcto3WxJh554VVik34oiW5vbEE+jkhcCF/ZOTZE/j6hEBj4mCljKhL2fT5tPfyjgbhFtdS14Irj48+k+RSkL+pJblHabSLsw9s7S0JSPHLjIs7OV/yLBF1IYg9BQGfeZwGsjkb37Z9sGmn8o2kaZAhpLGp22nLzUffRsVSVEidiDiBeCuhsiATSpu/NVa8Q9Adlb45FoGJp+SkYUwfH+sAC762O++J/yO0lO5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NJwkzDuOXR0dqbj5lwa/yTDUgZF+ahp8tDICCrXCnH4=; b=klWw+xw4rZhL/oT9iMZf98/R4zIO7IGRccCytgD449CidMH0VKfIAiZXx73uf6iHGoftqhjLCuZIH1yBc0y6NNwPPsVg0brO65gaOZ0UGshp8PHuHJUsADqeFeRO+GRFZKGxvZ4IZZ1NebCneofWGfF7krgVOJzRXNn4D/gX4UeDRHTJud3wKt/wCSqQyVrjS4ElvlXq4+EmV581KY9mV4aJyobkXEFqLJ10eiJnrb4DjTFpWjyjZRxq4GCSgQCymQgHtrjNh0xJpFE74YMtPl8f06swSMJHl3cgut+9f7PCTRWjqbAMdQGJE+nm8EVsTDmcFRhTGLGe2XGhmpaxfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NJwkzDuOXR0dqbj5lwa/yTDUgZF+ahp8tDICCrXCnH4=; b=a1hvGbV9gtdH21eiX0FLbwzYSiekvyDzZqW14WXk4YG8K1IECzWNIh5g4crVDEnNrbx01868trQyF2SU4c9KdWZNZBiy0S+mLUYVLsK4V4ts7i+cEBy+wY80FdDFfF4G9lX/0eJWEAGMeOxYtJU4uke3H2tq1WC5ofh+opp5B9w= Message-ID: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> Date: Tue, 12 Jul 2022 16:22:41 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Content-Language: en-US To: Greg KH Cc: Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com References: From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SN6PR08CA0029.namprd08.prod.outlook.com (2603:10b6:805:66::42) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8573936b-b736-4edb-5149-08da6444488e X-MS-TrafficTypeDiagnostic: DM4PR10MB6015:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4CF55cBR0c1mUt1KYTGfT+59S9oPfDNaOkdXLyjI2prgTX+mt9gKdTQX9mUYUppgcBecgmVfJ4HeaiUiCFTT7JwrK9pYinUxaveGR6wyeg4blZQmSi594D7FfNKokcsn1il1axztRgj+pDals+Pj6oVUM3ZWV9AwrJn54ZBJGKKkwtRbsxnEaJPRY2y/m78IvKupf1s6R7tjGkwF1WrJOJC415qFEubprxCajpUsd9sBjUBlhuMXdyDoouu7thwGsOYtbwOBo95PymTuPYKqaDDEHoQyfazyJ0yGbl6yX+f4U/5z0MApVPpMdLT3F+XsVuISRpyr5c4vZYyYQxEDIvhL9qw0Rm42nMGbpnO7PVkgGEdyCBubE53+ilcv+NISgiNurZByA9JLIVuNEYiLtbkRJ8zomCKlKctB0KXJ4rEwrbFZpkS5WczSu+qJ/d4xlRG8tvzMDszCr+8OchghCYVE5005UYfRknypXDB3Uh1uLksxZmZ1UC3yJuDsimA//ApzOoGN+LAVrkkzV+8ZHvtiKIODL6V9whL+nyiUzhI/otoOkcMi83/mnJ5r6PMWCG8ONXRzzderUwX32UJQy36xpgiJZOh7idNlEZKoO4NkVCTC/n6HIgeTX9xibfIK5CJYddXGh9RE7asC57fUDS8yfF3vE8dqf0sRQ3qw0QbknNcZvINeXQKnzf4FBRfBLg1/MnJl+J8pg1koogN5D/1OfrXJ0d8k0IybrmitqnxfPCT1gBeHZABD9hmrM9UydFVlIKB9SUSvy1yIPSeg/KUiBp7/whCkJx7FfpRDMzkk+h9qegk3kaHfDNrKFDLeTSOFhllIvV3uAbtzesK5RwENnb7r6CgFbevGEYt0KQg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(39860400002)(136003)(346002)(366004)(54906003)(26005)(38100700002)(6506007)(6512007)(5660300002)(6666004)(31696002)(31686004)(53546011)(41300700001)(8936002)(2906002)(86362001)(44832011)(7416002)(478600001)(66556008)(6486002)(66946007)(83380400001)(8676002)(4326008)(66476007)(186003)(2616005)(6916009)(36756003)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0hiWnVZYmpScnZ2RCt0aGNpQzR0Ti9vOEg4OCtBbzNia1h4ZFNJc1Q3a1hQ?= =?utf-8?B?OWN5MmFvcjYzNTZZVG5mMGZiNHNHbnJxVE1Ba3lZY2kvM01oZ2FIa1h0Qmdp?= =?utf-8?B?MnJZakFZUGhHc2ZyRlVpckZVL1BZN3d4eTZoSllXT0hvQkR4aWVOTU1zNmM2?= =?utf-8?B?cnVoWEI2a0ViaDhpY3hIVUgrMTI3SkNubkxsK1FPRzR5YzN2THlpeXEwbG5j?= =?utf-8?B?N3Y0V0RCbWNibURHK3Y3Uyt1bTJjZnhZdG1IbFVnU1l6S2VOT2M5U3FTS0Yv?= =?utf-8?B?ZkN4aDdSd3VXUmliRVIxNWdwL1hUNGZ6OGZOekVqTnFhekExSGwxWnl0UEFk?= =?utf-8?B?VUFLbkJxZU1sdkEzdW43a2dYZ1hUQnR3RFNXTkNCQm1udTNIenUzb0JPODVX?= =?utf-8?B?bVhVaXAvclRxYWk1KzcyNHdXR3Q4Mnd2bDg5N3hlQVhFSkVXZTFMK1JFOE1h?= =?utf-8?B?ZE94dE9penE5eXFBU1F2NEdib1VMc0Z1MEdhSjdNaE83TDRWUldrck9WZThM?= =?utf-8?B?b0F6Wng0ek5SQlZ2Ykp4WlZOaVFwczgvTTN4cVAydlhyamJHVlJsY3hLS2Zs?= =?utf-8?B?SFdBWkRlNDB4OWh2M2NkazlPeUlMQnNhYlI0MG1pOG9xZWptZVMyUUhWU2Fr?= =?utf-8?B?T2hBUnVGdlROUmwwUTJDV2RsaTVsWFZobXFjN1lKY3l3dlQrL3FDWXZrT3dZ?= =?utf-8?B?bDlhY1cvOGVJcFdubUt2bnhtbEpFTFNwK24vZXpiQk9kRURZWmc5K1NuNmZ6?= =?utf-8?B?ZFJGSTFzQUVoblZxejN1YnZtZjJrNW42RU52eW8xb0pESFRQc2d4aE81RFJG?= =?utf-8?B?eVVkRlFwb0xxN3BGZWNXeEQ0cjFwVWZ3RmU5QUNWZWdwRjV5cEk3cXFnbVNj?= =?utf-8?B?NnZTUXkwMGo3MUR6aU0ra0VOdzQxTFA5eFBweVZ6YVBjUVM4eFgyZ1hGeG5i?= =?utf-8?B?OVpIWlR2ditPNElLNVhVdThtR05uc1BrVUd1SWIzWllhYVNyY3V6S3NzUzJz?= =?utf-8?B?UmhzMjF6WjJTQ3l0Nmd4VFdSTTJNZmRhYWUrdEJENHo3T3RnNWFRU2l2Q2tj?= =?utf-8?B?eHpIQ25ZRkszSFBUYTM2Q0ZjU09NMkNVZnVBN3g2SmlFTnFEUkhobnowRlRF?= =?utf-8?B?MXVEYVB4SlRtbHRQOGQ4SzcxSlVqaTVhajhod09FUVo0RGZzU2ErdVQvd2l1?= =?utf-8?B?Ykt4dEVhN3NuOWJEcERnSWRncDAzcVhiaFpwem1TTjNQUGlaWjF5enJnZjZQ?= =?utf-8?B?Vi92S3g5K05jcmRDVms3UW1JVnZLclJOcVN4cm9OdHkvRU10VFZwMSsxQ2VK?= =?utf-8?B?Sm9WcDR0T3h1OFFOTHFlQXpBcGpTZXZRL0RqaUhtbGE0dTluTUFvZlhZb2RV?= =?utf-8?B?cE9ycGY0bU1uOWdxdjFYR3hFdXZrMXVucklFRUsySFVqVXpTUWYrbzdhZ1g0?= =?utf-8?B?UVVyUnVWUTlUU3VHYlg2ZmpMbnFiMU54MEt5VDVTUXd3a0lyd3lITk15Tk96?= =?utf-8?B?eGZMUW5FTGVqdXREVzZzdE9vRHB5Zlp3V0NQZDlIbGdKNDJRbEt5TGlWVUFq?= =?utf-8?B?Mmo5OUVuVXc5czJPaFVyeDFER1cvSHR6SVVHcnNMQ0JLa1Q0T0R2MkQraUF0?= =?utf-8?B?WDgrcTF0N2wwQUozSS94akdtMjNHaXhjbGJvY1c1NDdJSng3TTVzQmRSZDdn?= =?utf-8?B?Y0dLbFpueTBxL25GRVg0Snc2TERGUktnOVE5c1VlUWlnenZyTUM5cW4rUVRD?= =?utf-8?B?MTBDTnhzRW5uU0VJVEgranFlYnJYQTFxS1hkMzZGS0JtY1BValgrbEE3cTg5?= =?utf-8?B?a003NVBMNUw2d1YrYWtFdVd0c1dqNTltQWJJd0RKTmRSTUJUMHNkd1NyU3M3?= =?utf-8?B?OHpJRGRKd0hDZjE4VDVkNGRNTHF0b0cyamFwaTN4ZVFDRitYVWpXZ3Q0WHFT?= =?utf-8?B?ek5lWU5rKzExKzZmQUg5ZUdmbElsK2o2d2VCd1V5SGh2TzJwRUVrRzU3TUFo?= =?utf-8?B?THJhbzEwKzBrdTUvVi92ZXEzMnEwMEh3cUJXUkNYMkRJQUNuaFlYZHZ5Y01P?= =?utf-8?B?UXZVbWZaRm04c0ZzUCtpa3JjWHJGVWNlRkJvaENObVc4NVpKK0t4U29XR2E0?= =?utf-8?B?Vy9XeDl3Z1BsZVAyWUhOa1ZjNW56LzZHU2xxNHVqbmJCU1kzMmNFT3Q3Wnhu?= =?utf-8?B?QUE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8573936b-b736-4edb-5149-08da6444488e X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 20:22:46.6060 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 656axEEXAeyLOEk+YMiZk89YjxRKy+kaKtsqtxRksRUBtR4KeQ8VeZj5Gh4lfc3AxfYOsg7T/KptqS5Yot+G6R3qi825bEugh33R1BF9TeQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6015 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-12_12:2022-07-12,2022-07-12 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207120082 X-Proofpoint-GUID: yObhBEWzazCxw6dW4yliL8UZRyKPGEcQ X-Proofpoint-ORIG-GUID: yObhBEWzazCxw6dW4yliL8UZRyKPGEcQ On 7/12/22 3:31 PM, Greg KH wrote: > On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote: >> >> On 7/12/22 12:38 PM, Greg KH wrote: >>> Hi all, >>> >>> I'm seeing the following build warning: >>> arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction >>> in the 5.15.y and 5.10.y retbleed backports. >>> >>> I don't know why just this one hypercall is being called out by objtool, >>> and this warning isn't in 5.18 and Linus's tree due to I think commit >>> 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. >>> >>> But, is this a ret call that we "forgot" here? It's a "real" ret in >>> Linus's branch: >>> >>> .pushsection .noinstr.text, "ax" >>> .balign PAGE_SIZE >>> SYM_CODE_START(hypercall_page) >>> .rept (PAGE_SIZE / 32) >>> UNWIND_HINT_FUNC >>> ANNOTATE_NOENDBR >>> ANNOTATE_UNRET_SAFE >>> ret >>> /* >>> * Xen will write the hypercall page, and sort out ENDBR. >>> */ >>> .skip 31, 0xcc >>> .endr >>> >>> while 5.15.y and older has: >>> .pushsection .text >>> .balign PAGE_SIZE >>> SYM_CODE_START(hypercall_page) >>> .rept (PAGE_SIZE / 32) >>> UNWIND_HINT_FUNC >>> .skip 31, 0x90 >>> ANNOTATE_UNRET_SAFE >>> RET >>> .endr >>> >>> So should the "ret" remain or be turned into "RET" in mainline right >>> now? >> >> >> It doesn't matter --- this is overwritten by the hypervisor during initialization when Xen fills in actual hypercall code. >> >> >> So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes. The latter was not really necessary but harmless. >> >> >> So it can be 'ret', RET, or anything else that tools don't complain about. It will not be executed. > > Cool, thanks. > > But what about the objtool warning that I now see? Is that "real"? It's not real in the sense that the code there is not real, it will be overwritten. (Originally the whole page was 'nop's) I am getting a different error BTW: arch/x86/kernel/head_64.o: warning: objtool: .text+0x5: unreachable instruction > > I don't run any Xen systems, so I can't test any of this myself. You can't test any changes to that code --- it is rewritten when Xen guest is running. We probably do want to shut up objtool. Josh, any suggestions? -boris From xen-devel-bounces@lists.xenproject.org Tue Jul 12 23:01:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 12 Jul 2022 23:01:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366104.596714 (Exim 4.92) (envelope-from ) id 1oBOsB-00010P-1J; Tue, 12 Jul 2022 23:00:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366104.596714; Tue, 12 Jul 2022 23:00:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBOsA-00010I-Ux; Tue, 12 Jul 2022 23:00:54 +0000 Received: by outflank-mailman (input) for mailman id 366104; Tue, 12 Jul 2022 23:00:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBOsA-000108-2K; Tue, 12 Jul 2022 23:00:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBOs9-0003Ik-Ui; Tue, 12 Jul 2022 23:00:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBOs9-0004ci-Iz; Tue, 12 Jul 2022 23:00:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBOs9-000166-GV; Tue, 12 Jul 2022 23:00:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nXUHByB8DmhiSEN0BIgGnFJFYZF5KI5pCIh6r4ffSbI=; b=Y2vCj9Vg531dgKg+RLucxLyToG st6/6clR/9slpPGS9CQu28epURkw8QQKG+L5r1+osCYIzlYIyeT5IaO2+hbQbWrCPSIcbqkfz3U8H 6CyORIuqmopuq3ogwPz14fm1hwZ8PV+OhL3ZIovl+lPDgUtbXQdCjv/6ieU0N4lrjDYE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171595: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.16-testing:test-amd64-i386-xl-vhd:xen-install:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=744accad1b73223b3261e3e678e16e030d83b179 X-Osstest-Versions-That: xen=2e82446cb252f6c8ac697e81f4155872c69afde4 From: osstest service owner Date: Tue, 12 Jul 2022 23:00:53 +0000 flight 171595 xen-4.16-testing real [real] flight 171606 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171595/ http://logs.test-lab.xenproject.org/osstest/logs/171606/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171606-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-vhd 7 xen-install fail like 171207 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171207 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171207 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171207 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171207 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171207 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171207 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171207 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171207 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171207 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171207 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171207 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171207 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 744accad1b73223b3261e3e678e16e030d83b179 baseline version: xen 2e82446cb252f6c8ac697e81f4155872c69afde4 Last test of basis 171207 2022-06-16 13:08:03 Z 26 days Testing same since 171595 2022-07-12 09:37:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "G.R." Andrew Cooper Anthony PERARD Charles Arnold Jan Beulich Julien Grall Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 2e82446cb2..744accad1b 744accad1b73223b3261e3e678e16e030d83b179 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 00:01:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 00:01:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366122.596762 (Exim 4.92) (envelope-from ) id 1oBPom-0000Kb-2O; Wed, 13 Jul 2022 00:01:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366122.596762; Wed, 13 Jul 2022 00:01:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPol-0000KU-Up; Wed, 13 Jul 2022 00:01:27 +0000 Received: by outflank-mailman (input) for mailman id 366122; Wed, 13 Jul 2022 00:01:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPok-0000Jj-Mo for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 00:01:27 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eccd233b-023e-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 02:01:23 +0200 (CEST) Received: from mail-bn1nam07lp2047.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.47]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jul 2022 20:01:17 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by DM6PR03MB4988.namprd03.prod.outlook.com (2603:10b6:5:1e2::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 13 Jul 2022 00:01:14 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 00:01:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eccd233b-023e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657670483; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=VWV9f7tdlhMaiR06iI4EqaoHuqpClHZLxVZBWEgf6AI=; b=K07YEs24XwRzccxyFrt5Yuot2yh4A2NWmEO+RjqcOHpMuaNMbIzl4uM/ TRUYKoFjN5tSmiJO6feUkey/X58VYdfk5RV0pyexiU/QG+V9hUfz3dPtD 9+nXiY2l/mPNvBmvR8QVSry7Fy5wSzGtoiH2oi3xWgrBVBTgBP4sE33PD I=; X-IronPort-RemoteIP: 104.47.51.47 X-IronPort-MID: 75648911 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:R1/e9qsud2tqsI9oEh7mTqDxRefnVFpeMUV32f8akzHdYApBs4E2e 1ou7Vv2eabdPDOxPpsjdtz1pnqyiubUmoQ1SQJtrSg9RSpDopDMVN7IcBiobn6cJMfPEUw+s p9GZoCecJllRHWF/RnwaOTr/XQlifyFG+qkWb6ZYit9LeMIpF/NrDo68wJuqtI40bBVej+wh O4eg/EzGXephmEpajtJ5v/co04/7fmo52hF5A03OKwXtgaOxylIUcNDKfm9IUWjT9gPFIZWZ QpiIJJVXI/9101wYj9wuu+jKiXmepaLYU7WzCA+t5GK2nCunARrukoAHKdaOB0/ZwmhxYgrk o0S7MboE2/FA4WX8Agje0gAe81BFfUuFI/veRBTZuTKkiUq21O1qxlfJBle0b8wo46bMkkXn RAsExgfbwjrug6D6OnTpt+AJCgUBJKD0Is34hmMxNxCZBosacirr67ivbe00Nqs7yzn8Dm3i 8cxMFJSgBr8jxJnJ3FPGNVuuNmRliOkYSBAlH28tbI+yj2GpOBx+OCF3Nv9XPWvHZ8QtGDB4 2XM8iL+Hw0QM8GZxXyd6HWwi+TTnCT9HoUPCLm/8f0si1qWroARIEROCR3n/r/k0wjiBLqzK GRNksYqhYc/81akQ5/RQhu8qWastR8AQdtAVeY97Wlhz4KLvljFVjldF1atbvQ368w6Hy4z7 WW2vOuqLjJr65nOaECCo+L8QTSafHJ9wXU5TSgAQAge/8j4oKk8ixvOSpBoF6vdpt/6Azbr2 BiRsTMzwb4UiKYjx6i9uFzKnT+ojpzIVRIuoBXaWHq/6QF0b5LjYJangXDc6ftDN4+fQkO2o Gkfm8Oe4eYNCrmAjCWIBu4KGdmB+PKtIDDax1l1EPEJ7TO28WSkeoNWyD57LUZtdM0DfFfBe 1TPsAlc4JtSOnqCbqJtZY+1TcMwwsDIF8nhV/3SRspDZN52bgDv1B9pYUmczmX8in8GmKs0O YqYWcu0BHNcAqNipBK8Sv0By7YtymY7zHnKWJHg5x291PyVY3v9dFseGF6Hb+R85qXdpgzQq 4lbL5HSl0oZV/DiaC7K94JVNUoNMXUwGZHxrYpQa/KHJQ1lXmomDpc93I8cRmCspIwN/s+gw 513chUwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:VQq3p6vueFtbbGl+SQD5ngoG7skCwIMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKdkrNhR4tKPTOW8ldASbsP0WKM+UyGJ8STzI9gPO JbAtBD4b7LfBVHZKTBkW+F+r8bqbHpnpxAx92utkuFJjsaCZ2Imj0JbjpzZXcGITWua6BYKL Osou584xawc3Ueacq2QlMfWfLYmtHNnJX6JTYbGh8O8mC1/HyVwY+/NyLd8gYVUjtJz7tn23 PCiRbF6qKqtOz+4gPA1lXU849dlLLau5V+7Y23+4kowwfX+0WVjbdaKv+/VfcO0aSSAWMR4Z nxStEbToBOAj3qDyaISFDWqnTdOX4VmgPfIBmj8DfeSIXCNUwHItsEioRDfhTD7U08+Nl6za JQxmqc84FaFBXagU3GlpH1v4EDrDvKnZMOq59ls5Vka/ppVJZB6YgEuE9FGpYJGyz3rIghDe l1FcnZoPJba0mTYXzVtnRmhIXEZAV5Ij6WBkwZ/sCF2Tlfm350i0Me2cwEh38FsJYwUYNN6e jIOrlh0LtOUsgVZ6RgA/ppe7r+NkXdBRbXdG6CK1XuE68Kf3rLtp7s+b0woPqnfZQZpaFC7K gpkGkowFLaV3ieefFmhqc7gywlaF/NLgjF24VZ+4VzvKH6Sf7iLTCDIWpe4fednw== X-IronPort-AV: E=Sophos;i="5.92,266,1650945600"; d="asc'?scan'208,217";a="75648911" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OktGPvDC/s1/ayT7yqrb/pFTn9MC2Qlx1NgzI2QT1rauAab9NUuBA/uTDqsxYLds4Sn2MRpEiOz0dzxCxhulSUPbu32qcpOBHspK/mnx8opP7pk5ubcLZkuD66Rqd+Qy6zO0WQo/Ac8UnWKZetTTBuvZ76X+dTMrzI5dtJg6Rr/Ev12Yb+MEIbPQiwXZx8O1+1zTsh0n0PjlIV2H7ldAxSjSP8nlbTPEIW/pdXV9awAODByc+0PIloVzat9/1o+zIHc7BqL09u1iYgJTasWyL+8A6teEDqhc4cUC5U8wTVgag8fI8hrTdQtS/GhuKDv2KvPZAID/6/f2okHqXZ8Bxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9w9DfuIotNNjTdgeTIyTRaLbgdwlv2YuodbvsWR+3E8=; b=a3UxRN8E1kWfMJ+Y36Gu0ObCFV4LHeBxXm74XOChVh8FMBcj69fhX8hdhlTcciDgVDbTQBC1rCNlT1bj4yadXGnssbHY4yzFC5mWLOJyRb5yLWjnIezeNFuSEdYoU21wPM+eInPRckKA4649Xbg5f8AVDlZsmzJG/lHx6+HQDqRA+6g4tTEMLYa3W7nIsUbYma88dhCNBvhYfnmLUTm14kTSU2GhcPteHBa46sc9eCk3Bglfu4ClszTy4o5GeNWgSdrTur6xXagR8XLAz4NtjYAV4thg/SFy9JI5SC73cUrFH9sw+TXrvTipCvsaXgZKHi3JOVtg7ClWKdkOiPmFVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9w9DfuIotNNjTdgeTIyTRaLbgdwlv2YuodbvsWR+3E8=; b=f7nuSpHqh41RVhLqDvcchLC4bJwZlNm9rISVJcdOG8n6TxsWgXs24MgQ0o9yZSaorkosgciv/8He2g28bRmqghU4J7eNS493mQvTB39M139J7c5QnDpKuzIVFdP+W0lOTlF9azL1Yteammg51L+cDEgciM6albn7/WV053TsIBE= From: George Dunlap To: Oleksandr CC: Anthony Perard , Juergen Gross , xen-devel , Oleksandr Tyshchenko , Wei Liu , Nick Rosbrook , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYf1BHHIj+DWvN90eGeepJ4klT4a1QiHQAgAAkCwCAAwIpgIAAEjOAgAALK4CACsnDgIABrEYAgAe2TICAE6BDgA== Date: Wed, 13 Jul 2022 00:01:14 +0000 Message-ID: References: <62903b8e-6c20-600e-8283-5a3e3b853a18@gmail.com> <1655482471-16850-1-git-send-email-olekstysh@gmail.com> <9A36692A-8095-4C76-A69B-FBAB221A365C@citrix.com> <02648046-7781-61e5-de93-77342e4d6c16@gmail.com> <36d4c786-9fb7-4b30-1a4d-171f92cc84d7@gmail.com> In-Reply-To: <36d4c786-9fb7-4b30-1a4d-171f92cc84d7@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2dc68ab-7c61-4a0f-ddf0-08da6462cd8b x-ms-traffictypediagnostic: DM6PR03MB4988:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yW4Jgw0CFJkuoYOQjuFvApT7HQlwpXA+8EPon5drA64rynu1PSMcbuyTqNxeClOj8rut4Gpn2csAleN9G3vzG4vNtgyRGBiFmS1KZWhskiDId9dQpOm9Wnv99Wrh5dP1LmjuWvjCjWeNwZOMZpGjiCWQHwyEzu6EBdpSRQjuirClf5xqKhtYBHpaWpgXMt54kVPaWXlPN0xoTxCleICMeV2rzw5ROt6FA0FP5nAt2dJXzChrNN5N3MBqoFUR43GYvE7mQScM0RSlPEfcR9R5M6kuK4IIq35wm8QjPWVM57od7x2qlOtWYo73nTOmSeFgVvYTnAKgKgWDZKJG4H73aWhSuiZvkbX7H4ctcftPYJla9Tg/oTyrTiNnvy8cOOE8jTWpyvxfI8u+D/56QLwsDJgSuB+rA1QG9uSOB9BWiW/UnL+bd6Eqw3N/+uQKtfd77TZglf9BxWFbGkxKYs7oWMkp3vWr/Ho4+byvoci/htqYHxL/hnGztibpHw9UCRpfswLXR4FrjBEg+QrpMedXRaL0vrxg84HkJhZx8YSxwDUixUc3LH+U+8AOs0XIAZ25MnWVVQeZyMzbCHbqitVi+x43XpgZl5wxin6Ulg+y0mzq9pgCWBDKvquT7fupb/Azs6xSy0vUi1NQ8EW21TVoLP9ryGzOY/YMdoiz4QjQSFei8hDe+imk2H67iw31UMhfnhIFZTpMqqKu3FlRigTr0xZw/xbkjRx+j7aRIzlzeBjbPYi7bOJI0pPpdKvn0pacBgN6FIgS5Ik86zbKKjTHSnLievFGCukOEa/n/UDmD3QxrrHgRC5ugFhC6dOGihihhVdfBYsrPVbWLaYX6vfu0Gs/wp2u1IQlOQSG9lrDlTo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(346002)(366004)(136003)(6512007)(83380400001)(38100700002)(33656002)(2616005)(186003)(53546011)(2906002)(26005)(41300700001)(36756003)(478600001)(6506007)(316002)(5660300002)(54906003)(6916009)(122000001)(7416002)(8936002)(38070700005)(91956017)(6486002)(4326008)(66556008)(71200400001)(76116006)(86362001)(66946007)(82960400001)(66446008)(8676002)(99936003)(64756008)(66476007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WXpiM3E2L2JtdjJheWMxSG94cVcreUZ4RkxhVTJsL3RnZURJZHhQWnI2SlM2?= =?utf-8?B?dW15T1lhWkhzeGo5Z2hCQkJYaFFkRm1KU0hEcWd3VTRBY0thUGpXM29uMy9n?= =?utf-8?B?djNCT0g3azBURm54aFBsT0JnNndYQ2x1WTg2UnNweTk4QTBSOHVxQTVMKzVU?= =?utf-8?B?cVkwamRPYmc3SkVDQjF3RWVrUEVobjFEc3lFY0ZLMjRNZnFGV3JQZndORWx6?= =?utf-8?B?eVVCNzNCcWRxQ2Z3TVdXTHRkbnUwbUZ4RXV0a0s4K1h6TlF0MERoY1M3aXZn?= =?utf-8?B?T0VTSm5sbVN1ck12N0xTNlZ2eUE3eUR2empwWjMrOVFpOWhGV2lLWG00OVMr?= =?utf-8?B?c1FGamR5dzRBakllMGF1OE0xc0Jkb3ZHNDFHTHZnR0pGNjZPbFp4MXg4MVR5?= =?utf-8?B?Wk0vZ1pXNmFzdHpkbHB0aDcrbTQ2ZW9ENTdod2VJbVJETEk5NkU0TmVmUTli?= =?utf-8?B?SUhURHpEZnVWZXUwdkp5aDhOK2w5K3JjcjI0YzQ5RXoxSW94a21qZ1kzV3dL?= =?utf-8?B?UFFxTFJHT2Y4Mk5NU0hBNzlZcmhaSjNzK1JWTStBNWp6UFdXU2NQeUsrUWRG?= =?utf-8?B?L1NyckJZNSs3SnJTazZTZTFJd0RFblV5WGRrQ3VTbFN6emhEUVluQUhHUkdN?= =?utf-8?B?dTI4R1lldnpGdTZ2eXNUdnJtU2JRbDBOMUwrVithTGEzZjhXeTBaM3A0WkJE?= =?utf-8?B?TjJrSHdlVFlvL0l1N3A2MTBIZXYyYzlEc3RGMDdKRWxqbzgyNnVieDdQQStZ?= =?utf-8?B?d0FXeHpUdFFuRTVmZFNWOHpxN3BnOStPUHBDYmhKQVdiQTJjaHFvOVc2QXl3?= =?utf-8?B?WG1qaHpreGhwVEpwSUtQVFhjaGQrRmdrQUtYeWZGUlVRYXJ1Y3kwbWtsM0J2?= =?utf-8?B?YzUzQjE5YzRmUGV5WTY5d3pwQktMOVlzOGZvT2hna085UTZ6MmtJZENXTitD?= =?utf-8?B?a2orTGdtM2U0MWRGL1JOdnVSaitPK1l4R2JDdkxSZ0FydGVjdmtheDFKd3ZD?= =?utf-8?B?UjR1S1lsRmo4b0tTUmZ1eEYxYS9TNmJTa0ZxRTV4cnBWZWd0OVcreHpuVXJJ?= =?utf-8?B?ZWhrcWN4cUJkemphbm1xUFJyUVEzdEltb3hHdTBTelZKOVFMV0tQaVVhZUV4?= =?utf-8?B?SVV4OVFTQW5rdVFqUEIzYjlYMjlweGg2SmlKVW51NE56ZTZzV2RhK1R1by9I?= =?utf-8?B?UnRHenV3TzlWdERta09rZHJtenRhWVFFQUVod2plaURyWHQ5OWxwWGsrazVn?= =?utf-8?B?UGNDamY2c2svdkVaeDhkYit1WkFXbVM0dVpmN2g1OGtsVWMzQ051aTBPUUVC?= =?utf-8?B?NTV0WnJ3MG5FZmd4MytCQjUyS0FqUkhyZ2dweVViWGFrVWRwNklXcHVsN2Np?= =?utf-8?B?SEw2blJPSHV3aUpZMk1veW5USGxYMUJlK1FMUW1jcEJRd3Z2QjBSdkV4Nk1R?= =?utf-8?B?b0ROdWpJc2FYeTRVKzB1WkIwY2ZVRVVaMGlMT0ZSNzl6ejFBdHd2dGx1empT?= =?utf-8?B?QWo3NXpWaFZ3WEZwaHhXZkNMci9KL0RTMUZlMU1UVStpQTZWc1RrNmQ4cHN3?= =?utf-8?B?cmVFTE5td3hvUm5kZGNkZGVIdCtWSDNuRlh1ZUZWYXF5b2dTeFhDdGJrbU5D?= =?utf-8?B?cjZrazFRRWZ4NUlSbUtjVUVWNWxCa1ZTMCtFYjgrZ0NiYlYwbGlMVHlwYUFq?= =?utf-8?B?NklNR3Q1ZWRZYWZVKzNiWVYyN3hiM2ZUWXdCcjZHeldYOHZqSjVsUEZoUnV0?= =?utf-8?B?Q2JnL0o1RThGR2JJa1IrY1NxSDRJYVYxeVY2SVgxZkRnai9mYi9wT1hLNTlK?= =?utf-8?B?YWFuNHlrSUpBdkhPRlVsK3VVUXhNYzZjR1VVTU5mRmRTUit4cEZwMVVXWFdl?= =?utf-8?B?emEyWmEwTU9iS0VKdjZueVZ5N2tYbVN1eU45VlJPR0NJOFJlRmJlenV5dFhZ?= =?utf-8?B?SzFNVkJGSEFjQWZNdFNWUjBqY0ZUMWVWTXZzS2ZMeWNCa3lQdldQcjRNR3Fv?= =?utf-8?B?L0lYekpSZk5ZRVNXT01SVUhBQXVlMEdENXcxdUxLSlEzbWNtdVpGeUdjQkVu?= =?utf-8?B?RG5NcVREcERQNnZaN3RJNlBrdFZZY3QzeS9KZUF2aVk1K0F2SkRMS2VlMUlz?= =?utf-8?B?L1I5QkdLNlRrQjNmR3d3Z1FsNXFjc3BwMkt3MlE1MEMyMlpTTXladUd6c2NR?= =?utf-8?B?TVE9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_BEBE3246-5124-4F53-BD3F-2AA083BAADE7"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2dc68ab-7c61-4a0f-ddf0-08da6462cd8b X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 00:01:14.4258 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EmoELV9WQX5Cs6eMvia7dB0wDgo2jSMga0hCa6AE+F7bVrHIR+WSuDGXeLd/zWh6i2hDRveRkydXcNq47fUg0tJfC8mq0reX1Um5bfRcNbA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB4988 --Apple-Mail=_BEBE3246-5124-4F53-BD3F-2AA083BAADE7 Content-Type: multipart/alternative; boundary="Apple-Mail=_D93ABC06-56D5-4D59-B30A-D6D360D2C149" --Apple-Mail=_D93ABC06-56D5-4D59-B30A-D6D360D2C149 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 30 Jun 2022, at 22:18, Oleksandr wrote: >=20 >=20 > Dear all. >=20 >=20 > On 25.06.22 17:32, Oleksandr wrote: >>=20 >> On 24.06.22 15:59, George Dunlap wrote: >>=20 >> Hello George >>=20 >>>=20 >>>> On 17 Jun 2022, at 17:14, Oleksandr Tyshchenko = wrote: >>>>=20 >>>> From: Oleksandr Tyshchenko >>>>=20 >>>> This patch adds basic support for configuring and assisting = virtio-mmio >>>> based virtio-disk backend (emulator) which is intended to run out = of >>>> Qemu and could be run in any domain. >>>> Although the Virtio block device is quite different from = traditional >>>> Xen PV block device (vbd) from the toolstack's point of view: >>>> - as the frontend is virtio-blk which is not a Xenbus driver, = nothing >>>> written to Xenstore are fetched by the frontend currently ("vdev" >>>> is not passed to the frontend). But this might need to be revised >>>> in future, so frontend data might be written to Xenstore in order = to >>>> support hotplugging virtio devices or passing the backend domain id >>>> on arch where the device-tree is not available. >>>> - the ring-ref/event-channel are not used for the = backend<->frontend >>>> communication, the proposed IPC for Virtio is IOREQ/DM >>>> it is still a "block device" and ought to be integrated in existing >>>> "disk" handling. So, re-use (and adapt) "disk" = parsing/configuration >>>> logic to deal with Virtio devices as well. >>>>=20 >>>> For the immediate purpose and an ability to extend that support for >>>> other use-cases in future (Qemu, virtio-pci, etc) perform the = following >>>> actions: >>>> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect >>>> that in the configuration >>>> - Introduce new disk "specification" and "transport" fields to = struct >>>> libxl_device_disk. Both are written to the Xenstore. The transport >>>> field is only used for the specification "virtio" and it assumes >>>> only "mmio" value for now. >>>> - Introduce new "specification" option with "xen" communication >>>> protocol being default value. >>>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current >>>> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model >>>>=20 >>>> An example of domain configuration for Virtio disk: >>>> disk =3D [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=3Dother, = specification=3Dvirtio'] >>>>=20 >>>> Nothing has changed for default Xen disk configuration. >>>>=20 >>>> Please note, this patch is not enough for virtio-disk to work >>>> on Xen (Arm), as for every Virtio device (including disk) we need >>>> to allocate Virtio MMIO params (IRQ and memory region) and pass >>>> them to the backend, also update Guest device-tree. The subsequent >>>> patch will add these missing bits. For the current patch, >>>> the default "irq" and "base" are just written to the Xenstore. >>>> This is not an ideal splitting, but this way we avoid breaking >>>> the bisectability. >>>>=20 >>>> Signed-off-by: Oleksandr Tyshchenko >>> OK, I am *really* sorry for coming in here at the last minute and = quibbling about things. >>=20 >>=20 >> no problem >>=20 >>=20 >>> But this introduces a public interface which looks really wrong to = me. I=E2=80=99ve replied to the mail from December where Juergen = proposed the =E2=80=9COther=E2=80=9D protocol. >>>=20 >>> Hopefully this will be a simple matter of finding a better name than = =E2=80=9Cother=E2=80=9D. (Or you guys convincing me that =E2=80=9Cother=E2= =80=9D is really the best name for this value; or even Anthony asserting = his right as a maintainer to overrule my objection if he thinks I=E2=80=99= m out of line.) >>=20 >>=20 >> I saw your reply to V6 and Juergen's answer. I share Juergen's = opinion as well as I understand your concern. I think, this is exactly = the situation when finding a perfect name (obvious, short, etc) for the = backendtype (in our particular case) is really difficult. >>=20 >> Personally I tend to leave "other", because there is no better = alternative from my PoV. Also I might be completely wrong here, but I = don't think we will have to extend the "backendtype" for supporting = other possible virtio backend implementations in the foreseeable future: >>=20 >> - when Qemu gains the required support we will choose qdisk: = backendtype qdisk specification virtio >> - for the possible virtio alternative of the blkback we will choose = phy: backendtype phy specification virtio >>=20 >> If there will be a need to keep various implementation, we will be = able to describe that by using "transport" (mmio, pci, xenbus, argo, = whatever). >> Actually this is why we also introduced "specification" and = "transport". >>=20 >> IIRC, there were other (suggested?) names except "other" which are = "external" and "daemon". If you think that one of them is better than = "other", I will happy to use it. >=20 >=20 > Could we please make a decision on this? >=20 > If "other" is not unambiguous, then maybe we could choose "daemon" to = describe arbitrary user-level backends, any thought? Unfortunately I didn=E2=80=99t have time to dig into this; I=E2=80=99m = just going to have to withdraw my objection, and let you & Juergen = decide what to call it. Re the golang changes: Acked-by: George Dunlap > --Apple-Mail=_D93ABC06-56D5-4D59-B30A-D6D360D2C149 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 30 Jun 2022, at 22:18, Oleksandr <olekstysh@gmail.com>= wrote:


Dear all.


On 25.06.22 17:32, Oleksandr wrote:

On 24.06.22 15:59, George Dunlap wrote:

Hello George


On 17 Jun 2022, at 17:14, Oleksandr Tyshchenko <olekstysh@gmail.com>= wrote:

From: Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>

This patch adds basic support for configuring and assisting = virtio-mmio
based virtio-disk backend (emulator) which is = intended to run out of
Qemu and could be run in any = domain.
Although the Virtio block device is quite = different from traditional
Xen PV block device (vbd) from = the toolstack's point of view:
- as the frontend is = virtio-blk which is not a Xenbus driver, nothing
written = to Xenstore are fetched by the frontend currently ("vdev"
is= not passed to the frontend). But this might need to be revised
in future, so frontend data might be written to Xenstore in = order to
support hotplugging virtio devices or passing the = backend domain id
on arch where the device-tree is not = available.
- the ring-ref/event-channel are not used for = the backend<->frontend
communication, the proposed = IPC for Virtio is IOREQ/DM
it is still a "block device" = and ought to be integrated in existing
"disk" handling. = So, re-use (and adapt) "disk" parsing/configuration
logic = to deal with Virtio devices as well.

For = the immediate purpose and an ability to extend that support for
other use-cases in future (Qemu, virtio-pci, etc) perform the = following
actions:
- Add new disk backend = type (LIBXL_DISK_BACKEND_OTHER) and reflect
that in the = configuration
- Introduce new disk "specification" and = "transport" fields to struct
libxl_device_disk. Both are = written to the Xenstore. The transport
field is only used = for the specification "virtio" and it assumes
only "mmio" = value for now.
- Introduce new "specification" option with = "xen" communication
protocol being default value.
- Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as = current
one (LIBXL__DEVICE_KIND_VBD) doesn't fit into = Virtio disk model

An example of domain = configuration for Virtio disk:
disk =3D [ = 'phy:/dev/mmcblk0p3, xvda1, backendtype=3Dother, = specification=3Dvirtio']

Nothing has = changed for default Xen disk configuration.

Please note, this patch is not enough for virtio-disk to = work
on Xen (Arm), as for every Virtio device (including = disk) we need
to allocate Virtio MMIO params (IRQ and = memory region) and pass
them to the backend, also update = Guest device-tree. The subsequent
patch will add these = missing bits. For the current patch,
the default "irq" and = "base" are just written to the Xenstore.
This is not an = ideal splitting, but this way we avoid breaking
the = bisectability.

Signed-off-by: Oleksandr = Tyshchenko <oleksandr_tyshchenko@epam.com>
OK, I am *really* sorry for coming in here at = the last minute and quibbling about things.

no problem


But this introduces a = public interface which looks really wrong to me.  I=E2=80=99ve = replied to the mail from December where Juergen proposed the =E2=80=9COthe= r=E2=80=9D protocol.

Hopefully this will be = a simple matter of finding a better name than =E2=80=9Cother=E2=80=9D. = (Or you guys convincing me that =E2=80=9Cother=E2=80=9D is really the = best name for this value; or even Anthony asserting his right as a = maintainer to overrule my objection if he thinks I=E2=80=99m out of = line.)


I saw = your reply to V6 and Juergen's answer. I share Juergen's opinion as well = as I understand your concern. I think, this is exactly the situation = when finding a perfect name (obvious, short, etc) for the backendtype = (in our particular case) is really difficult.

Personally I tend to leave "other", because there is no = better alternative from my PoV. Also I might be completely wrong here, = but I don't think we will have to extend the "backendtype" for = supporting other possible virtio backend implementations in the = foreseeable future:

- when Qemu gains the = required support we will choose qdisk: backendtype qdisk specification = virtio
- for the possible virtio alternative of the = blkback we will choose phy: backendtype phy specification virtio

If there will be a need to keep various = implementation, we will be able to describe that by using "transport" = (mmio, pci, xenbus, argo, whatever).
Actually this is why = we also introduced "specification" and "transport".

IIRC, there were other (suggested?) names except "other" = which are "external" and "daemon". If you think that one of them is = better than "other", I will happy to use it.


Could we please make a decision on this?

If "other" is not unambiguous, then maybe we could choose = "daemon" to describe arbitrary user-level backends, any = thought?

Unfortunately I didn=E2=80=99t have time to dig = into this; I=E2=80=99m just going to have to withdraw my objection, and = let you & Juergen decide what to call it.

Re the golang changes:

Acked-by: George Dunlap <george.dunlap@citrix.com>

= --Apple-Mail=_D93ABC06-56D5-4D59-B30A-D6D360D2C149-- --Apple-Mail=_BEBE3246-5124-4F53-BD3F-2AA083BAADE7 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLOCzcACgkQshXHp8eE G+01oQf+N+ypnqT0QZDWSI7lT0kF2pTSfcab7+xUj17XPsEKhXu4nOW+IYeNqYYo M4v/oNQQXHI2nzBMSOxi4lD4DmLqzhUpKfKsGHRa8l55AYNdbmpzx/augUNb9v40 K4TXwnK1Fv65ZV2j41T56279jeOGeHugHeKYd7hQ36yIFstCDo1WXThvClbkxIek HaEONut2wLk/n5qZYp2+Tw+ddPnzsPcRt7aprUl828WtMFGiFB7OmbnZLVve5A+s RXj25SPkASJBfvqA9iXLaeE+K2CWcSTGP5ARvRBjd2W+vdWjharHfNE8Ds12v+WH 8ZvJH0DjquG/b+NcUTuwHUdh4T1qNQ== =yOpa -----END PGP SIGNATURE----- --Apple-Mail=_BEBE3246-5124-4F53-BD3F-2AA083BAADE7-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 00:02:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 00:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366133.596789 (Exim 4.92) (envelope-from ) id 1oBPqC-00018Q-MS; Wed, 13 Jul 2022 00:02:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366133.596789; Wed, 13 Jul 2022 00:02:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPqC-00018J-Id; Wed, 13 Jul 2022 00:02:56 +0000 Received: by outflank-mailman (input) for mailman id 366133; Wed, 13 Jul 2022 00:02:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPqA-000183-On; Wed, 13 Jul 2022 00:02:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPqA-0005Bs-Ly; Wed, 13 Jul 2022 00:02:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBPqA-0001Ct-8l; Wed, 13 Jul 2022 00:02:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBPqA-0008On-7x; Wed, 13 Jul 2022 00:02:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=LcnAEtxG7AMC65nk6+S9C/tHUoHszulFWG6FWXYxjR8=; b=kzfrlF5X0VnNVH+IV7h71oAu5e VTiq46w3uPubtIdaZsBE4QoA4aaxtCB0YSaafiYoHL8H4RKDpLXLcZsDwB6Hfd/388vq7+f0vk8U2 qq560QAy8OttgyOX3+5NWv6skPvulD6AjjuTIDPDkl/wB/r6k93QLc0Us5d0Ath2uUl0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 171594: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-armhf-armhf-xl-vhd:leak-check/check:fail:heisenbug xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=505771bb1dffdf6f763fad18ee49a913b98abfea X-Osstest-Versions-That: xen=cc3329fbfbb5af1c4fdb8a7a4e3a87c12264661c From: osstest service owner Date: Wed, 13 Jul 2022 00:02:54 +0000 flight 171594 xen-4.15-testing real [real] flight 171607 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171594/ http://logs.test-lab.xenproject.org/osstest/logs/171607/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-vhd 20 leak-check/check fail pass in 171607-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171375 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171375 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171375 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171375 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171375 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171375 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171375 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171375 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171375 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171375 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171375 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171375 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 505771bb1dffdf6f763fad18ee49a913b98abfea baseline version: xen cc3329fbfbb5af1c4fdb8a7a4e3a87c12264661c Last test of basis 171375 2022-06-27 20:39:26 Z 15 days Testing same since 171594 2022-07-12 09:37:57 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "G.R." Andrew Cooper Anthony PERARD Charles Arnold Jan Beulich Julien Grall Marek Marczykowski-Górecki Roger Pau Monné jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git cc3329fbfb..505771bb1d 505771bb1dffdf6f763fad18ee49a913b98abfea -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 00:28:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 00:28:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366143.596800 (Exim 4.92) (envelope-from ) id 1oBQEw-000424-Ps; Wed, 13 Jul 2022 00:28:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366143.596800; Wed, 13 Jul 2022 00:28:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBQEw-00041x-M2; Wed, 13 Jul 2022 00:28:30 +0000 Received: by outflank-mailman (input) for mailman id 366143; Wed, 13 Jul 2022 00:28:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBQEv-00041m-5N for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 00:28:29 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4824a98-0242-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 02:28:26 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 12 Jul 2022 20:27:57 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by PH0PR03MB6333.namprd03.prod.outlook.com (2603:10b6:510:be::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 13 Jul 2022 00:27:54 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 00:27:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4824a98-0242-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657672106; h=from:to:cc:subject:date:message-id:mime-version; bh=uAyNUMVHftUc+d7/0/6tUiwuKAiLPbScm4HjQHcTlLQ=; b=JVwEZiYtPjXz1geb1u9pjh/x79oAc0wvdH7dnjeYey2wuKwEBelySuD5 jifuvIvcnF4ApXpWj6ra3eKX83CJM08Qe/1CIxnQjEM3CXVQUrFNPy9hS XyiPzLVbJJAkTmyzkj23rKtyke7KNskxgEqjzF7s7DldKgnK2LT4yxtsC k=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 78222362 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:f8vAK6N7AvZap7fvrR1KlsFynXyQoLVcMsEvi/8bNLWB5Y4Qp3Zem TxOHSzEb+HbITHFz+oGYYTl9B8Hu8eGn9IwQQY4/ng8ECtAopfLVIXCcB+uZ3PJcJCSEEw35 p0TYNCac58/RCXRqh6gObOw/HQm3q3SSNIQZAK81gVZHGeIHw992UILd5cFv7NVbfiF7yKl6 Ymt+JCHMQao1jUrOT5PsKvSohgy4qX74WlHswMzOaga4FOGm3crV59OfqvZw1kU42V38kxWY 86ZkdlVK0uAp09F5uuNy+q9KgtQKlLrFVDmZkB+AsBOuTAf4H1oukoHHKBEMx0P1GzTx4oZJ Ohl7vRcdy94ZsUgp8xFO/VoO3kW0XpuoeKvzdCX6KR//mWeG5fe66wG4HIeZOX0zt1fE2BWn cH0HRhWBvy1a0Ba95rgIgVkrpxLwMAGp+rzsFk4pd3SJa5OrZwu38wmTDKXtds9rpkmIBrQW yYWQSRESEqHPEFwAWsOLopkpuPvtl76LAQN/Tp5pYJvi4TS5CpY9eG0dfDzKpmNT8gTmVuEr GXb+Wi/GgsdKNGU1TuC9DSrm/PLmiT4HokVEdVU9NYz2AHVmjNVVU1QDAXqyRW6ohfWt9Z3B EET4CUj64Qv8kiiVvH2XgGioW7CtRkZMzZVO7JqslvXkfSOi+qfLnUYX29gNIM2iJYdYTYP6 U2Jk4LyIxU65dV5TlrYrN94twiaKSUTaGMPeyIAZQ8E+MX45pE+iArVSdRuG7Lzicf6cRngz jbPpS44gKgVhsMj06Sg4UuBkz+qvoLOTAM++kPQRG3N0+9iTIusZojt416L6/9Fdd+dVgPY4 ilCnNWC5ucTC53LjDaKXOgGALCu4bCCLSHYhllsWZIm8lxB5kKeQGyZ2xkmTG8BDyrOUWaxC KMPkWu9PKNuAUY= IronPort-HdrOrdr: A9a23:XB/wiaMxaUd+9MBcT3v155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8Qr4WBkb6LO90dq7MAvhHP9OkMEs1NKZMDUO11HYS72KgbGC/9SCIVy0ygc+79 YHT0EWMrSZYjZHZK3BkWuF+qMbsb26GdeT9ILjJhlWLT1CWuVF1UNUGwybGkp5SE1tHpwiDq eR4cJBun6JZWkXRt7TPAhJY8Hz4/nw0L72ax8PABAqrCOUiymz1bL8Gx+Emj8DTjJ0x6s4+2 StqX202kzjiYD19vbv7R6T031koqqg9jKFPr3OtiEhEESjtu9vXvUiZ1TNhkFxnAjl0idQrD CFmWZbAy000QKaQoj9m2qQ5yDwlDkp8HPs0lmenD/qptH4XiszD45biZteaQax0TtWgDntuJ g7ol5xmqAneC8oph6Nk+TgRlVvjA65sHAimekcgzhWVpYfcqZYqcga8FlOGJkNESrm4MR/ed MeRf309bJTaxeXfnrZtm5gzJilWWkyBA6PRgwHttaO2zZbkXhlxw8TxdAZnH0H6JUhIqM0kd jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbWPGebMT3cZdM60rL22u3KCZkOlZ+XkcYzveQPcb z6ISJlnH93fV7yAsuT25AO+gzRQQyGLETQ9v0= X-IronPort-AV: E=Sophos;i="5.92,266,1650945600"; d="asc'?scan'208";a="78222362" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TgqOowrpsVcC/TnyPCUUh271TjNlsAZGwFhQMe0cDyk0Q3yHtPLZ8dqBZFs3T+n72sysZCbGLeWoLBsJDwQTW3t2beYq0D56OyINW3eFAME5+lbMZKS2MOVKrG8h3cnAn8WQcWtaZ85PPnnJ83N8Gb03JNlwUaf2Imj71lHtEYga3SEgb2KhAaRnpwYk0U+yu8zDbGAb3oWIArZ2usu5d0PVUetqLpBReZBp2r4FDcsju1rvs6vYuF0C494ysaucLbOo+m/jdio2sMcL3e1PQbgx+astKO7knRQcpTVNI336H9w/smM8eL86egtxNAlMUFnPWsjoopvcrMSm3AFFhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UqtKOWf75Qn5JjiMtGGLMmWQh+CjnlwKwdqu27Yfmu8=; b=b97S9mFmTyZN45ehHTTQEHNHbVz1Lq6feTZbPSlE0zdxp7VUX+8hA4zD1AKUTeF9Dm7LTHl0xlv+syfs1cKSlPHOhWWkGwnrouUPxldm3jqpDkU1BUQGa8ONdL7dIf7M2b9laFDZx3MLE6GRauWx9EXyJC7eNOPEvUs6STsf0KlsoLo1zoUxB8lq+u2c87nsMxkpXyH/kGqUkn4BXwWBYM5Xj8cN2kzaJU1aH2VUsTBjx8dlUfZhy5wGwqOn0mFtNxVhiCbdR/F2PKlhRmntOJqhIJ3RzQgt7LjT/8c5/bHIEYkZDI4wj8ZN+rzpf6AvNJXAdfLoSOq1+ie8ZIo7fA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UqtKOWf75Qn5JjiMtGGLMmWQh+CjnlwKwdqu27Yfmu8=; b=InWUK4/O7Ysu1ZCBkCNA8lu9sosYJ1YF8fhwMdBBQNyJ//i+0tzEpdiTCSxY4T3GyqDVWLYrkKJg6ayvLN2Zml4nbSOBqlcty2QNEiLTiv3RT1AUwK5XvIh5vVKKdiBlxRcc9OxiQhdyCSVY7E30KA+31cHK8nY118NQiOsbE24= From: George Dunlap To: Xen-devel CC: "xen-announce@lists.xenproject.org" Subject: Xen Summit Registration is now open! Thread-Topic: Xen Summit Registration is now open! Thread-Index: AQHYlk9kgYu4qIX7+ESUDN56VeqUxQ== Date: Wed, 13 Jul 2022 00:27:53 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d64397c1-13de-470b-f0d2-08da646686e2 x-ms-traffictypediagnostic: PH0PR03MB6333:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GxPVnoGbJXfoTH/5ZbdyeK8u4Dk496nu7u4gXZ0OV/VBAYkZ3XsrsELVcJArM+kMsAtppLzjZ4p2WF8Wzccbp3beHNKzfJEJKo47fyXPJAb6rCP2WhqwIvfLHZih/Mt0I3/4pIs9if3p1c+BlOOFq9MxSKQkLTRMcj9qAfqCHYnWKOHub/NjZkcn9CwheKStGxLvQ83jbmA8cTNOZynS8E9kyG4ulDlFBLcHjonTVVntadyeV/fTZXLDEGkFvE5uWn7p0AFRdGq7yxqzyuaw3nG1sj3YmwRXlED/j5G8VlW5D3G75uSxey8dCDs0Xl1jSvdZecRYxN7x90WQLs52uTkuvY436fYg/3MqQSwGFsEMhjr5mUizxFNnMfII+GJB1dQTJsDGIfvIlbPysqu/sVZmdTowSijZDnEg3bNUlmtZDOtRorZmLVM0UPr3SzoqP74kDFdRcPKSi9xoa+qC517ZBbmlVfIJZOhV6tvzvtcxjHhSWzbmizCUaZkQsXgUrB3HmnrhU/CiDIt0+JLSNQ1UW8iOPgycJtb5hKrITxueVca8O3RGkx/1/Mim+T8aw5TqFZMsN3dWali4wQyUFpotJP551L6EkCfCqOxMR/U9jH9KJwY9MRQwwbWU6La5nNAZKUzsGVS+n0RLve32kBxgR3moMQuxbl5fSrtbSVvTNLVtKhu5SaDfZq6A7G/4CIREb+KOy7/KM9qjXAllBJBhPSYPO2tgJS9QIEXaaXJ4Q0Jm/aevtHVnxcGAgaUVukahyfT59wpQjNzqTxUGpz2cdYYFkaoMZKmngsXxLTJOR1ZyMl3+XfO3S7F34Ol/1Dwz5ODAPbBbxFAzHjU2kdv+dxXnXNg2YCfl2XERZ3xeGERW4aIdX7uf82uKETe8 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(136003)(376002)(346002)(91956017)(8676002)(4326008)(5660300002)(450100002)(76116006)(316002)(36756003)(8936002)(64756008)(66476007)(33656002)(66556008)(66446008)(99936003)(2906002)(66946007)(82960400001)(38100700002)(2616005)(41300700001)(38070700005)(86362001)(966005)(186003)(6512007)(4744005)(478600001)(6506007)(6916009)(122000001)(6486002)(26005)(71200400001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XmkNWxSnMoZDOWjwGQKm7TwVaJoOMTgh08B6oBZZgIEM8nV0QMLIRRJeKKTS?= =?us-ascii?Q?QckTvxe8/3NLLkxgY3SWpGRLiS7Ti7afV8BWkfFrKEbo2wIbKLOwHHRHbGvY?= =?us-ascii?Q?lDR7RY+N/X8G1cQDgGa36MibxXS8LFZr4NahbNIY1R5vk2ijC8Sy48BHXcL9?= =?us-ascii?Q?jWg9jGwQkvo8uq2ErrTTZ7Y0RpZrAc4f6pDXMtDbYVo0izvEnIGDuM01hbRj?= =?us-ascii?Q?3p3a3UnUqIaXpsXj2K4sfZbuoIVFukTBgoV1x0fYOMNFVXLeMrDn4vbnKiIY?= =?us-ascii?Q?FX8ZBTfVbs+f/PKmJn9OVFnj9UT5j4t3DX60nAd2JSdA2bGstzHj+jmXxv/m?= =?us-ascii?Q?Rp1WnmUa+50rLviyVe8FDKu8KntnbRsctB+SpmQ0VUwKl4NrJP40rYZlL0RM?= =?us-ascii?Q?kGimEf+0UHqFxpTc1uRDcDJn3QSIYW2uPB/m+z7VptniXFsBu+EBBuSDRbuY?= =?us-ascii?Q?N9shroSaH2NfZdkOOrlqr7uRLKXPB1/xrX5f7wWmJVV/vozJlIZhwUFzMObu?= =?us-ascii?Q?u/tUYw7g0XsobNZMyc8PH6W21BCaV39zDS/1yI2Ss/Dqb+uV/PyDidMLkCRz?= =?us-ascii?Q?AiTjGU1f4jvwCepp7/eLBjzO2w4JiCQP/QgCWuF2MADQJnVOmcugwx9b87a6?= =?us-ascii?Q?EmGT4mP7NAEh/d0jwvOc13UTvldcNZ/9b9/Q1o7fKcZjc8FkcfD04hOmQ32Q?= =?us-ascii?Q?nXJB+Vre61gE7WctFr1axpDtlRh/GYa8CLRfTPqDLOLhKJsyZOITNvXQZWQ9?= =?us-ascii?Q?evFx76Q6TGy0IIeLQ3xL//77F9waLNfliFFBcoqclDmoPZ8QZIvd4XS/Tw/F?= =?us-ascii?Q?vhnKppB5ucErQRfzJOjOYbzF6/i12w0tJdXv2Vggr5NfAYRonIemK6qIeW0Z?= =?us-ascii?Q?IWz3mWSZ/Euea8Qow4ObX8WMZRSQ3L09HXd469zQkIKM5Sjh4EOg/EPugn9z?= =?us-ascii?Q?w+qW5yI8O+HpRQTkqx2gBWQpT97Htpw/iQI8Eyk8Xt6yE+cP6qnouF8Eol40?= =?us-ascii?Q?MJH3Aq7mY80tf1+cbZpSO5/3JeDTSKhqahqqK6Or//vYYDPJ4DTXzq3joqef?= =?us-ascii?Q?wTgq8S3mrqR+OLGL4g9VPRT7b7OlydI5Qirakz+zGg3RobUMfzuD8SLAPOes?= =?us-ascii?Q?XMJQ2GvybooBt9bIoBNuwlIsMZkrzsNzjllVO3vQmdICP7TyDUrTTGnzkUf5?= =?us-ascii?Q?KIwIRrKIwoOJZoqMkE0uzN6oJcVCYUASP1x6DHnCCcGaH9fdQalB9tfehC+Z?= =?us-ascii?Q?Keo1G8NeFatXfY4YlZWHWnWfA6ZkNk1escW6/jlx6S3R3iPX6DijV7hpsu9q?= =?us-ascii?Q?TOiS3iDTKhyahKDse/Z5R44cyDdMVmllJSszDIiJRgomgxVZ2JKHm0Qs6pE4?= =?us-ascii?Q?sGN+lQNNMtJGZKBt1qxDyoqP6NEtwQJF1vjrCD8M9VhCXWbODaKhEtX0BEHb?= =?us-ascii?Q?lqWb7UV16Go88UbRBMDEI+Dp/1ADYCIa3wTH3ZyZYBJNXDgaSoZyQkg8wYiG?= =?us-ascii?Q?/rJQogSxXjBhXaYTpr/me1i+O1eL/EbEl9fFxOAXFpvr5cefxiwjfFfJPTc1?= =?us-ascii?Q?3+RzmShJlZf5VrATukuu3iv8R0uMLa7qtJ0tzgkqyjZ5mzIVrOdyv7+tlPrS?= =?us-ascii?Q?mA=3D=3D?= Content-Type: multipart/signed; boundary="Apple-Mail=_584CEC3B-EA5B-4A8E-B360-A49F6F4EDC17"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d64397c1-13de-470b-f0d2-08da646686e2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 00:27:53.8339 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +xpO1rG8HZxyiSRjbtpRBSgkQSPlUyTvD78m72c0vnjkWx6Npa8/OSBsbNZOkA3ascjuH2Lno2MBt6TM/85Rfwss48Xp/lzxbaa39MnN0W4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6333 --Apple-Mail=_584CEC3B-EA5B-4A8E-B360-A49F6F4EDC17 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Registration is open! Virtual attendance is open to everyone; due to = space constraints, physical attendance will be priority-based: Those not = on the "priority list" will be put on a waiting list until 2 September, = at which point slots will be first-come-first-served. https://events.linuxfoundation.org/xen-summit/register/ -George --Apple-Mail=_584CEC3B-EA5B-4A8E-B360-A49F6F4EDC17 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLOEYgACgkQshXHp8eE G+1EewgAoy+rfjK3qw6deFM1bwFa8WxfGrzE6NLrPpVwD8Yx/3kOIUkV1/xzR/NZ l8oqG/3iKOjs3/Q+BOLvKk6Xsk+BzSn4FnGpOdBztd4pJDT6JTWdwewNlwF1Ouhv VOeAFlOFkT9IsgJMCuxb6uGL0BlGqgpf3FzkjXD0bz06qagmT0swB9z3um+jtEzL BYs2FPAP9CWUYbrB2G0AjXM3nRXjw1s2uKiHyr2JSk+pHMfjGjrpg+sHHASxiWNz jCK4IiWsqzMMGuIBSsYIPEly+/3H/1+oih+ipAsPsyhjtHrTp7LYxHiHrBqOKFLg mIGL1WyUmHjtJ5fuKe0Fl91QJbN/hQ== =ZbXM -----END PGP SIGNATURE----- --Apple-Mail=_584CEC3B-EA5B-4A8E-B360-A49F6F4EDC17-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 01:37:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 01:37:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366154.596811 (Exim 4.92) (envelope-from ) id 1oBRIy-0001hz-TV; Wed, 13 Jul 2022 01:36:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366154.596811; Wed, 13 Jul 2022 01:36:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBRIy-0001hq-OR; Wed, 13 Jul 2022 01:36:44 +0000 Received: by outflank-mailman (input) for mailman id 366154; Wed, 13 Jul 2022 01:36:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBRIx-0001hk-5T for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 01:36:43 +0000 Received: from sonic307-8.consmr.mail.gq1.yahoo.com (sonic307-8.consmr.mail.gq1.yahoo.com [98.137.64.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3c38da1b-024c-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 03:36:39 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 01:36:36 +0000 Received: by hermes--production-ne1-7864dcfd54-jt2sh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 103a284e887da164b6a51a28e1ee36f6; Wed, 13 Jul 2022 01:36:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c38da1b-024c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1657676196; bh=ilQ63Qlh/pxWEmqxuxayijK2KJ9t+TQhVpcbdyvIRRY=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=PCONkz1sV3u1EryJ5YBSI/Vg3MtWr6jEa9qOBNKYeqP/Pu6ltZV6+rChsMyx2fJ0XNHhav48mVNbeMzN2giGWwr+L1ybbfbkWPwYQcyWgKV3jZHBEEDo6+j9k+Qx0uP/h4TIw2yb876mthUEMZiFnB1mVhLAVEid1wCr7BlYoeVoZ8SOMWaJwnJab8YfxRZdb3lfqDKdQ6ApQOVEc2QaxkV6HxRjRtlzjzKWri1C63iYeC0DZm3gZ+5lXCT1+6VBF7a1Agox/psCN8YXf2DWtq67jCV00N2BvL4BtXzU2Y9P7f+eHK53Kucx0Hdosg2tCpiFqZnZ4MLBz7NjzKJTfA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657676196; bh=CfK7C2itV8VfkLP5ECLS/mYB/CEjf8Zzcx3VvW/HYW9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=tgZea/8XuqvZi2f1BW+Srlk2njPyiMDabqbEwXkgH0gX6YGvIpBueBL3stkKGhgDn7D0bNNQvjlyl8uJSInpr5AN/9dPEyXlksyOwCwE5BD0DJjwoBzvUzaVCVamanpTe3xea8CJRLEhyRvPO3Msj4I0cx876o1GiM2L9dKw/ZTGUjzVGwG9fahmE+9qUSXxVgg/tgDsYxoCjBE9uBZTYs4GstjDlRN8A9aEsXmEy7E5IHgdIhRbIwlgTnocHEFm4cctb/0i9vMDONq5m+dkBPYJfEppqnnY9BAQ6T1mQsiz0/vh6P7Zm3/rofVHmpZDcInIQMbvXQrawdDZd7v0AQ== X-YMail-OSG: wumnrFAVM1nJcpCj0FRu7OkeKPNBfKyNn3Z3Xi7QLjW.NGYqi6U1HzPu3JduYmS M08rb_OnmfwSrtLELFpb2Vg_BaA3lskWK9BQbt_OE0hAQuOHqVF1CW.2wjcgkuxnIbx0mQgZJ3vF gcIw84.JIufPAuJP6FwCP3MN467DUrjpjvdYuX4m9mwb7ZbFHUYIYxHi1dpzsfCMmGO0dRo0.Thg DkSvAAIUeGCGvsVR0MA17XtODtkZ03ZaFOUrh2vxV_mzBhNG2lXuiA1_FqpFLRECexBLZbEK472_ oTcTejAsPR_D5leIh4fzHHJ_.q6LVK6GHWc3ynEyeuv4J0GT8TBT_NwbuUODDpJE41cUfl_ecbq2 lDIz0WLKfPNZH0VhsGbteMKmhjEzU.J38Aa1lrnOMAncw0zT4ipL1MLzKRwLu3j2aAnbkzjjAm8I GpzjzCw5Y3AQCQcvnsrRGWaWIgXPoe25qnwcQojKGXgQTcXXnh4P47FZGGrvHZndLvfRmScTYtz6 jiKIPBuxEcX2ybGjXcKWVBiw3dvSFm1GpyLGe9ifV40G47pjXUAzjYBWU_aof7qMCxJXX7EuFOmH 3j7stKBYQ4GEQ2MNBwooPucjzeNZPH9Mm9Vjc48uCju0WSRYTHfdRNRyFieoZX50hm8eiPAEjAmY 8MvIT1EJ0Zhsb_32VWnn98jqlUO0GFiKiZtuRNE6COb4QHzNAYv3aMuU6xEcZXMCGbuUAyK8HdEf _i9HqQ9.Rt78Wav9FK7FnZwVi6FNJ6urdS1IiWxCbEelvhJbAgoHIuwkwLN1cKrOtUjPMsEByu5Q tIn.ZoLx4gu2eoz_y5ZvUxKhE2rEu1wHveInW7IesHyldbHbUJqCEbFBG1AZBdUCIefG0Vaynt8B qZI85nCdssUT96AwufSzKvkTxeb2OFJubJHRHAjO_yz2.taV0HvCuTfmWNWMANKMOv_vevgD7HAj kIqTL05wZoHGlUVnE.OMqzeVbNAU7KqoVYLJ1tR6SBaThKwunBBo4kFqMsfjuOVJYidwMRSrLp35 dCXUCr8KG.wJG24o6I6zh84zxvcOjTbLPkpdSfZOVLRPcoA8NfR80kTIaS9U1t97ZcOSivJp1UzL uJqiFSu4ydh.OzVFxi45.2iG6L593Sy2QTJg6vmMxWNmoS24QzIbwgScbhETPchGdvCM2Fe.IjvT 06RvN8kaIHooA8VebWoErAWlN3yMEUzhbTjBQizIlF3A4zU4ZsI3.0AOnKBGaUpmBz_PBSCgglnT kgdawGYS1C4x9fPLEH4DZ1pZ6wGPZORHVCwZw3mAEcJgQ..5BPXHJd2.CEvNOO52bKuvwjCiMf_h LjNa3m2fwVbLiLio0uo9oypoUjOubL5F34v4qlvx9fjnryCzMKne9em_d5sfAxghrmuOX3N21FEU RtR_soeO4aSbO2ppt0cXdiq8wtdc2xhSJeec4bvKzRLDmEojX5slrdyJPJDwL3eNMhnJePcVynfi cwLqIFqlvtA8zE4oN_e6k0YTcu6GEZrpaxPIFVzIzY5_VALY4NztEI2h8EwiLT.f2Mh6e_.bZSUk .j1w6ikSRiEehXxzA.uSQJsKAuj9VmEheZEo4GWe0AHY.7_nXbz4CE3F1DevEgmefKoX2NBLAl1p Jm5p173vfBI2_Ad8LOOcVOPEVJzYo5rfQQeYNN.svewXFyEvIC1c_ARsrDAnMb_0IWn4H293rCs5 BY7GewJHlVZ60golVgZkdTef5wTbxNYtGxPYqPzqma2TlPO_RdydxbgUYVycpF0hX3pGokxJUpf0 m2QtoVvyLID.ifyCGyGP7Cl7EaJ9Kz5vjSqVq2l2mS8sctELhiKgxlPpIlgPoNs2W_1HkONFJ4OO PFIFV9b2NXnkH5mQqlbX.SN1awwekaNX0NlA0aJpycsTrDYkW9BZVWnxPtFw1MM.ykkNXzzOzubJ VBP5UVpFTo_v9T7RB_TcwQpbf98RJyb8Ezp8yeV2sp7YuF0wlCbzAcpK8dBtDijt0LBsA9U0sgZa Xni.JVxiN2Q37LtsDV2MVZuyA7wzHjxifbyic.ti_T3kZbCpevWuQEWrCc8ji6OtoR0mWx1Kyi_a CgMVcvzynmRKHXdP5qxuUj9JHf.XXfqNGJUdugXIdYXnIOOd475oNRctSulgNDDRTMnH5RlC4yZB _LzGgqoISOPb7rz807J2Zeb2lDc2MgByXghDseqr6KhO51QP8KJnCsPup.oM8svNsHg-- X-Sonic-MF: From: Chuck Zmudzinski To: linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Date: Tue, 12 Jul 2022 21:36:12 -0400 Message-Id: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> Content-Length: 5230 The commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") incorrectly failed to account for the case in init_cache_modes() when CPUs do support PAT and falsely reported PAT to be disabled when in fact PAT is enabled. In some environments, notably in Xen PV domains, MTRR is disabled but PAT is still enabled, and that is the case that the aforementioned commit failed to account for. As an unfortunate consequnce, the pat_enabled() function currently does not correctly report that PAT is enabled in such environments. The fix is implemented in init_cache_modes() by setting pat_bp_enabled to true in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed to account for. This approach arranges for pat_enabled() to return true in the Xen PV environment without undermining the rest of PAT MSR management logic that considers PAT to be disabled: Specifically, no writes to the PAT MSR should occur. This patch fixes a regression that some users are experiencing with Linux as a Xen Dom0 driving particular Intel graphics devices by correctly reporting to the Intel i915 driver that PAT is enabled where previously it was falsely reporting that PAT is disabled. Some users are experiencing system hangs in Xen PV Dom0 and all users on Xen PV Dom0 are experiencing reduced graphics performance because the keying of the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular graphics frame buffer accesses are quite a bit less performant than possible without this patch. Also, with the current code, in the Xen PV environment, PAT will not be disabled if the administrator sets the "nopat" boot option. Introduce a new boolean variable, pat_force_disable, to forcibly disable PAT when the administrator sets the "nopat" option to override the default behavior of using the PAT configuration that Xen has provided. For the new boolean to live in .init.data, init_cache_modes() also needs moving to .init.text (where it could/should have lived already before). Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") Co-developed-by: Jan Beulich Cc: stable@vger.kernel.org Signed-off-by: Chuck Zmudzinski --- v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) *Add the necessary code to incorporate the "nopat" fix *void init_cache_modes(void) -> void __init init_cache_modes(void) *Add Jan Beulich as Co-developer (Jan has not signed off yet) *Expand the commit message to include relevant parts of the commit message of Jan Beulich's proposed patch for this problem *Fix 'else if ... {' placement and indentation *Remove indication the backport to stable branches is only back to 5.17.y I think these changes address all the comments on the original patch I added Jan Beulich as a Co-developer because Juergen Gross asked me to include Jan's idea for fixing "nopat" that was missing from the first version of the patch. The patch has been tested, it works as expected with and without nopat in the Xen PV Dom0 environment. That is, "nopat" causes the system to exhibit the effects and problems that lack of PAT support causes. arch/x86/mm/pat/memtype.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index d5ef64ddd35e..10a37d309d23 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -62,6 +62,7 @@ static bool __read_mostly pat_bp_initialized; static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); static bool __read_mostly pat_bp_enabled; static bool __read_mostly pat_cm_initialized; @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) static int __init nopat(char *str) { pat_disable("PAT support disabled via boot option."); + pat_force_disabled = true; return 0; } early_param("nopat", nopat); @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) wrmsrl(MSR_IA32_CR_PAT, pat); } -void init_cache_modes(void) +void __init init_cache_modes(void) { u64 pat = 0; @@ -292,7 +294,7 @@ void init_cache_modes(void) rdmsrl(MSR_IA32_CR_PAT, pat); } - if (!pat) { + if (!pat || pat_force_disabled) { /* * No PAT. Emulate the PAT table that corresponds to the two * cache bits, PWT (Write Through) and PCD (Cache Disable). @@ -313,6 +315,16 @@ void init_cache_modes(void) */ pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); + } else if (!pat_bp_enabled) { + /* + * In some environments, specifically Xen PV, PAT + * initialization is skipped because MTRRs are disabled even + * though PAT is available. In such environments, set PAT to + * enabled to correctly indicate to callers of pat_enabled() + * that CPU support for PAT is available. + */ + pat_bp_enabled = true; + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); } __init_cache_modes(pat); -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 02:42:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 02:42:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366161.596822 (Exim 4.92) (envelope-from ) id 1oBSKY-0001Fl-Ll; Wed, 13 Jul 2022 02:42:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366161.596822; Wed, 13 Jul 2022 02:42:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBSKY-0001Fe-Ip; Wed, 13 Jul 2022 02:42:26 +0000 Received: by outflank-mailman (input) for mailman id 366161; Wed, 13 Jul 2022 02:42:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBSKX-0001FY-AA for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 02:42:25 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6a6d83bf-0255-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 04:42:22 +0200 (CEST) Received: from AS9PR06CA0376.eurprd06.prod.outlook.com (2603:10a6:20b:460::14) by AS8PR08MB6630.eurprd08.prod.outlook.com (2603:10a6:20b:337::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Wed, 13 Jul 2022 02:42:17 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::79) by AS9PR06CA0376.outlook.office365.com (2603:10a6:20b:460::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20 via Frontend Transport; Wed, 13 Jul 2022 02:42:17 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 02:42:16 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Wed, 13 Jul 2022 02:42:16 +0000 Received: from da93b92bf064.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D8CC7A81-48D4-4FF9-B86C-0E5661F3A6FA.1; Wed, 13 Jul 2022 02:42:10 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id da93b92bf064.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 02:42:10 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AS8PR08MB8159.eurprd08.prod.outlook.com (2603:10a6:20b:560::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 02:42:00 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 02:42:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6a6d83bf-0255-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=e8cmxMDa254VLRB+36V9DWIal9JFHrIGoFbmD2SoKBmLui1MmZhcBIuPlfi3jDKESJwoWrMIsQ/roRpjOKVNIl9ZrjMm59bi83/5bquhMsNNuZlXJeO/NioBf5kGboztwBl0Rqby3kRjwRZNl0wMXf2E12rkDBIvxQsxO8TsDbp5Nu8n+/kgcuQguQtlUAzakLlAcaxdMniIj+NO1R354nsIYH0uccw/HpeCYljKoZdbsDIi1NVFc/7NhUjXnRca/oadG3lnM8XeQbqJJd2B1AuyfXjCqaQFUUulOpBGjhT8yn285wq3sWZ7RgrM1GxPUPIrs9b/0kWLinGTchNtvQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pzNI4diC0sXRof6JLCyc3g6ztWYqp7CAXlXODf2eFQ=; b=JL4EiIt+jYw9FRecAs3iqov8XQ0nPG70kLL0teVfGgPt6w7z1BRIfuejo+Es4ZGHZTnstfLj5aLQpB0FTnjJIJX/lFzgPOi2pbw7SFaXEuIpF5KJi+6KMgjWdZYJInWyX9CTnzsY+vbL4Kzdj8wrMMtjpP2Az3gfb5uKd1kr87N3TsZftei9YAo3JI5r+iioB5dyxh7UZXjq0iIy0wru/KczCuMjBsuBE2fQQNgdIriHyVCTodDSdEUxBg1fYOSyjwED3Ai2Qny+YiTRbLTc1mnD3jipoTOWmKPid7kf+N7TNHmep3wBSGLkshsNyJcM+drzpPdD+Nn7fRBpptYFOA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pzNI4diC0sXRof6JLCyc3g6ztWYqp7CAXlXODf2eFQ=; b=3ULOKXhMwXKnsWtYSocgELrOMQP2WqYaqf6DAUph4awvvVNFXXbAOq/mZfWU/5M8U1Spp/8OhPntkG6FIYO99HHTYoqdItTEtG+zsdWr64bxuUYjkm+MRx7Z9iGd2rjkaori9Ihpqx+GIf+yDo5lwjAizPA8IQ+MTH04ez9bmFk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BVxe1OYyYpOp0rYpfDb0P0j454m/v+qAuuSNjNgK6Tvwz1t8R5KP06tgp+KkL4h6FUvWROEdsPDZHOCR+ELTXtq8m6py9mTXvhpiYe7vPjRv+97AYXWc/+KOgcx+HvuJb0BiZeVYxbHZs5gNa3WRBYcO6BeASC96kqFICu78oqB3GU3I/2/01sD8SCpaC13q/6tfa4x+0wyv6PSh5H9CxqwReOb9HvhRgMlhhn0k8V8TMyEIyFmaTyvfcgRosn5K2UZfr69rTyJ4TtRjGerYoMfel7vymaXT5lgnHCxwvAnV0t8olFGsSngNQaUH34igqzYXiaa5bKPlpIBod8z9qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3pzNI4diC0sXRof6JLCyc3g6ztWYqp7CAXlXODf2eFQ=; b=RAfJZ96fuqDro/Fh0jKYH+JiEOlKa0jVqCp/hmPHax/ALVL1IL8pwH7zR1mj0GvOFUOYF5nTe8E7fEAua9aVaCpHbLHu9b2f5N8ZYB8PtPPuLJFrKupDeTNHgqeFH3gbMAoLkOZ5FANLz9VJLv6kbxfW3+W/KJuSfh/8HGCeJ4+Y1HrvQ122QxYiD9Z+Sz6p580zz0/D15Fua5Im0pnBN6nqNIaug6BFHTkGDW/gvOLgOVxTxSNQlgt9buB9FkkVw9oZTfNc94PolCI4xaQ37YcihltbEU4e5ZgbTkvDmJk4XXdRVmRSEOkyT2o6/bxbrNdxkrOfUM1wsDgPsesSnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3pzNI4diC0sXRof6JLCyc3g6ztWYqp7CAXlXODf2eFQ=; b=3ULOKXhMwXKnsWtYSocgELrOMQP2WqYaqf6DAUph4awvvVNFXXbAOq/mZfWU/5M8U1Spp/8OhPntkG6FIYO99HHTYoqdItTEtG+zsdWr64bxuUYjkm+MRx7Z9iGd2rjkaori9Ihpqx+GIf+yDo5lwjAizPA8IQ+MTH04ez9bmFk= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 1/8] xen/arm: introduce static shared memory Thread-Topic: [PATCH v5 1/8] xen/arm: introduce static shared memory Thread-Index: AQHYhGRAIMWAAZoglEyYz3pT8Ubq/a1e3kuAgAboQaCAAHOqgIAVfzCA Date: Wed, 13 Jul 2022 02:42:00 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-2-Penny.Zheng@arm.com> <45a41132-1520-a894-a9eb-6688c79a660d@xen.org> <9172fc95-0939-3680-94cf-b991c46d0918@xen.org> In-Reply-To: <9172fc95-0939-3680-94cf-b991c46d0918@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BD4689873E813B4CA9CF3B19C67F6AC2.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8f02daa1-eb29-41e9-e94e-08da64794cb0 x-ms-traffictypediagnostic: AS8PR08MB8159:EE_|VE1EUR03FT044:EE_|AS8PR08MB6630:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ecgGcmq6CmCn2Rwlx4MvcbbE5TJP+GWLdJz6IDCgA8xpPuAsBPeizExLsJc+a8H+8MlLrqmpKyZS13dEN9IiWHxbcyJlny6SniUSWYGUaWuUg5kzUY1EeRzFRA/le671hB5mBYYuQHEXCqTwFdaR/3sZLHdrunu3sDwhzsnzqEDIZ1jJtIthFawA9f/WfJ7Ehg/MHnCG63GHl7i+ASYH1fgMPSi+tLUwlqPHrKpYJpaq8ho4TAWb3ldE241XJQmwBJFbz5wqjmXWVYI/BqgPtJVLbyajI07xd/USjyST7lxSV+ilf3r1qSaYooNN+lDGNyXe84KzhZHcRQ/briZ4ZK5wz4Y+GboACel3LOu2jTqcQAqrs/j/ZmooQtgUbm63iKaqacAPMoIP0gErXOaPkIlteQrIe5O/cl0MyLyk6kRbDNagJ4An55DMSMpEvGf3Ax4Z3avojgYXJ4CLCDMwQTrN+qsVvEbdgYf12IzpphUIvN2EqXjoGckn2pqmziX/pSAQYlPdexG8g/aKvtCdfBMcSVigetPVGK72XMnR+JJ52BtSFAkIGFhDSDf4Sjxu0I+sAnqYtKk1uVWVNunaqM1CSwVWxi20CZh8a0Yqnv+EqQyyTxhdltbT1Lg7hYW+HJjaQdbDQRfgatUQBaSsZfy8rLaXzJjKpThrCC4ThhoEQT3kMuTtwElx0Z1lMiYhwvvstUcM0nSOIIcifeKSLxRVHXWgbbdGhJNNcOMUWSPUh0wV69NshrmrV0Flq544nSvJ9+Qdrqxb1lTRWrMqSJaGgBHgWAnsJQ8kavJJMNdOsjKjo/II1ShuQavKR2KZ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(122000001)(7696005)(6506007)(9686003)(41300700001)(26005)(53546011)(478600001)(8936002)(5660300002)(38070700005)(71200400001)(52536014)(38100700002)(8676002)(66446008)(4326008)(64756008)(76116006)(66946007)(66556008)(83380400001)(316002)(110136005)(54906003)(186003)(2906002)(66476007)(55016003)(86362001)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB8159 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ea3db521-7eae-4e14-785e-08da647942e5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i7sWpZWKFqrXWUe1Nktoe45GJGIjvYWhJHtIwRz4IA8LI9giwSxYTZtOYQOMgFot4KiRrhYx/tWfokuQRPHUOzlsF40j3gsY+lC8qKKCqnXiH4zwROjKpU+FYbexYTp/11J0qwpK7X/NLPLBpmAlwB/QUKpAU2oaIq4dU/4se16owZ1w6y8f4XaiegibGuCrPqBZ6RYiBzBdJ8DG5h93yYE+NvbzWfdaVNv4j8QSIoXmPrbQ8XBhB/268SGHyg7gW4wQ24waG7v3VhC1EyEwIp1qSynV1Goe7cSY8iac9xr7011EtSW6okaMfAcu8r9GPcJ1RPex+ZaBAVtoO7pImu+LS3izPiqdXeNI3b7YoSYoT1e/2QvKf1vdUEM7jDYTVtWFcG9NdyNEro9efseevrRpji9hS6YSMkg7LbKSRC9pM07k6Gf9w8L1QmKeA/xzAlfA1etDD/N7XeUMipIZU8idH58WFgE4XWFtfO/7y0FCzD2rhjWSCgnRD+Hsbh4FUSaZuzewkOPpVB+JJjLJStHT01BV3JrU+8QfpbHS1isnIDdgBCxTycyAeIDwvrrJT5mx/Xlj6UXvGEvo5buZbyFTdtzT0eoR7HpqYBiGHAgAezuyJpmLXZ0hhIO53GD755/uD8Gcm9q3wd9Aoo7pGAdvQwvTEpPe91Edq/HcyLRLNeV3iNBqCtTUIISlOO+5+wu5qQ8fMUrCXdqrMeZpb9Z85Oi0VOh4reU4nZc9i57cS02ZRNRftGlSPMJQ5KPIFTWX8WyxCtWIrYO//qz+Fe6qQ24Ir4jlSn4Et3yNSbMwiSC+0LqzEbnI8YO8nGP9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(55016003)(2906002)(186003)(478600001)(41300700001)(336012)(40480700001)(82310400005)(70206006)(86362001)(110136005)(316002)(9686003)(33656002)(8676002)(4326008)(26005)(54906003)(6506007)(53546011)(70586007)(7696005)(83380400001)(52536014)(82740400003)(81166007)(5660300002)(36860700001)(47076005)(107886003)(8936002)(356005)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 02:42:16.5423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8f02daa1-eb29-41e9-e94e-08da64794cb0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6630 SGkgSnVsaWVuDQoNCkJlZm9yZSBzdWJtaXR0aW5nIHRoZSB2NiBwYXRjaCBzZXJpZXMsIEkgd291 bGQgbGlrZSB0byBkb3VibGUgY29uZmlybSB0aGF0IC4uLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVz c2FnZS0tLS0tDQo+IEZyb206IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFNlbnQ6 IFdlZG5lc2RheSwgSnVuZSAyOSwgMjAyMiA2OjE4IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVu bnkuWmhlbmdAYXJtLmNvbT47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiBDYzog V2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0cmFuZC5NYXJxdWlzQGFy bS5jb20+Ow0KPiBWb2xvZHlteXIgQmFiY2h1ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+ DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjUgMS84XSB4ZW4vYXJtOiBpbnRyb2R1Y2Ugc3RhdGlj IHNoYXJlZCBtZW1vcnkNCj4gDQo+IA0KPiANCj4gT24gMjkvMDYvMjAyMiAwNjozOCwgUGVubnkg Wmhlbmcgd3JvdGU6DQo+ID4gSGkgSnVsaWVuDQo+IA0KPiBIaSBQZW5ueSwNCj4gDQo+ID4NCj4g Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPj4gRnJvbTogSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4NCj4gPj4gU2VudDogU2F0dXJkYXksIEp1bmUgMjUsIDIwMjIgMTo1NSBB TQ0KPiA+PiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tDQo+IGRl dmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4+IENjOiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJt LmNvbT47IFN0ZWZhbm8gU3RhYmVsbGluaQ0KPiA+PiA8c3N0YWJlbGxpbmlAa2VybmVsLm9yZz47 IEJlcnRyYW5kIE1hcnF1aXMNCj4gPj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9k eW15ciBCYWJjaHVrDQo+ID4+IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4NCj4gPj4gU3Vi amVjdDogUmU6IFtQQVRDSCB2NSAxLzhdIHhlbi9hcm06IGludHJvZHVjZSBzdGF0aWMgc2hhcmVk IG1lbW9yeQ0KPiA+Pg0KPiA+PiBIaSBQZW5ueSwNCj4gPj4NCj4gPj4gT24gMjAvMDYvMjAyMiAw NjoxMSwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4+PiBGcm9tOiBQZW5ueSBaaGVuZyA8cGVubnku emhlbmdAYXJtLmNvbT4NCj4gPj4+DQo+ID4+PiBUaGlzIHBhdGNoIHNlcmllIGludHJvZHVjZXMg YSBuZXcgZmVhdHVyZTogc2V0dGluZyB1cCBzdGF0aWMNCj4gPj4NCj4gPj4gVHlwbzogcy9zZXJp ZS9zZXJpZXMvDQo+ID4+DQo+ID4+PiBzaGFyZWQgbWVtb3J5IG9uIGEgZG9tMGxlc3Mgc3lzdGVt LCB0aHJvdWdoIGRldmljZSB0cmVlIGNvbmZpZ3VyYXRpb24uDQo+ID4+Pg0KPiA+Pj4gVGhpcyBj b21taXQgcGFyc2VzIHNoYXJlZCBtZW1vcnkgbm9kZSBhdCBib290LXRpbWUsIGFuZCByZXNlcnZl IGl0DQo+ID4+PiBpbiBib290aW5mby5yZXNlcnZlZF9tZW0gdG8gYXZvaWQgb3RoZXIgdXNlLg0K PiA+Pj4NCj4gPj4+IFRoaXMgY29tbWl0cyBwcm9wb3NlcyBhIG5ldyBLY29uZmlnIENPTkZJR19T VEFUSUNfU0hNIHRvIHdyYXANCj4gPj4+IHN0YXRpYy1zaG0tcmVsYXRlZCBjb2RlcywgYW5kIHRo aXMgb3B0aW9uIGRlcGVuZHMgb24gc3RhdGljIG1lbW9yeSgNCj4gPj4+IENPTkZJR19TVEFUSUNf TUVNT1JZKS4gVGhhdCdzIGJlY2F1c2UgdGhhdCBsYXRlciB3ZSB3YW50IHRvIHJldXNlIGENCj4g Pj4+IGZldyBoZWxwZXJzLCBndWFyZGVkIHdpdGggQ09ORklHX1NUQVRJQ19NRU1PUlksIGxpa2UN Cj4gPj4+IGFjcXVpcmVfc3RhdGljbWVtX3BhZ2VzLCBldGMsIG9uIHN0YXRpYyBzaGFyZWQgbWVt b3J5Lg0KPiA+Pj4NCj4gPj4+IFNpZ25lZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVu Z0Bhcm0uY29tPg0KPiA+Pj4gUmV2aWV3ZWQtYnk6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJl bGxpbmlAa2VybmVsLm9yZz4NCj4gPj4+IC0tLQ0KPiA+Pj4gdjUgY2hhbmdlOg0KPiA+Pj4gLSBu byBjaGFuZ2UNCj4gPj4+IC0tLQ0KPiA+Pj4gdjQgY2hhbmdlOg0KPiA+Pj4gLSBuaXQgZml4IG9u IGRvYw0KPiA+Pj4gLS0tDQo+ID4+PiB2MyBjaGFuZ2U6DQo+ID4+PiAtIG1ha2UgbnJfc2htX2Rv bWFpbiB1bnNpZ25lZCBpbnQNCj4gPj4+IC0tLQ0KPiA+Pj4gdjIgY2hhbmdlOg0KPiA+Pj4gLSBk b2N1bWVudCByZWZpbmVtZW50DQo+ID4+PiAtIHJlbW92ZSBiaXRtYXAgYW5kIHVzZSB0aGUgaXRl cmF0aW9uIHRvIGNoZWNrDQo+ID4+PiAtIGFkZCBhIG5ldyBmaWVsZCBucl9zaG1fZG9tYWluIHRv IGtlZXAgdGhlIG51bWJlciBvZiBzaGFyZWQgZG9tYWluDQo+ID4+PiAtLS0NCj4gPj4+ICAgIGRv Y3MvbWlzYy9hcm0vZGV2aWNlLXRyZWUvYm9vdGluZy50eHQgfCAxMjANCj4gPj4gKysrKysrKysr KysrKysrKysrKysrKysrKysNCj4gPj4+ICAgIHhlbi9hcmNoL2FybS9LY29uZmlnICAgICAgICAg ICAgICAgICAgfCAgIDYgKysNCj4gPj4+ICAgIHhlbi9hcmNoL2FybS9ib290ZmR0LmMgICAgICAg ICAgICAgICAgfCAgNjggKysrKysrKysrKysrKysrDQo+ID4+PiAgICB4ZW4vYXJjaC9hcm0vaW5j bHVkZS9hc20vc2V0dXAuaCAgICAgIHwgICAzICsNCj4gPj4+ICAgIDQgZmlsZXMgY2hhbmdlZCwg MTk3IGluc2VydGlvbnMoKykNCj4gPj4+DQo+ID4+PiBkaWZmIC0tZ2l0IGEvZG9jcy9taXNjL2Fy bS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPiA+Pj4gYi9kb2NzL21pc2MvYXJtL2RldmljZS10 cmVlL2Jvb3RpbmcudHh0DQo+ID4+PiBpbmRleCA5ODI1MzQxNGI4Li42NDY3YmM1YTI4IDEwMDY0 NA0KPiA+Pj4gLS0tIGEvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPiA+ Pj4gKysrIGIvZG9jcy9taXNjL2FybS9kZXZpY2UtdHJlZS9ib290aW5nLnR4dA0KPiA+Pj4gQEAg LTM3OCwzICszNzgsMTIzIEBAIGRldmljZS10cmVlOg0KPiA+Pj4NCj4gPj4+ICAgIFRoaXMgd2ls bCByZXNlcnZlIGEgNTEyTUIgcmVnaW9uIHN0YXJ0aW5nIGF0IHRoZSBob3N0IHBoeXNpY2FsIGFk ZHJlc3MNCj4gPj4+ICAgIDB4MzAwMDAwMDAgdG8gYmUgZXhjbHVzaXZlbHkgdXNlZCBieSBEb21V MS4NCj4gPj4+ICsNCj4gPj4+ICtTdGF0aWMgU2hhcmVkIE1lbW9yeQ0KPiA+Pj4gKz09PT09PT09 PT09PT09PT09PT09DQo+ID4+PiArDQo+ID4+PiArVGhlIHN0YXRpYyBzaGFyZWQgbWVtb3J5IGRl dmljZSB0cmVlIG5vZGVzIGFsbG93IHVzZXJzIHRvDQo+ID4+PiArc3RhdGljYWxseSBzZXQgdXAg c2hhcmVkIG1lbW9yeSBvbiBkb20wbGVzcyBzeXN0ZW0sIGVuYWJsaW5nDQo+ID4+PiArZG9tYWlu cyB0byBkbyBzaG0tYmFzZWQgY29tbXVuaWNhdGlvbi4NCj4gPj4+ICsNCj4gPj4+ICstIGNvbXBh dGlibGUNCj4gPj4+ICsNCj4gPj4+ICsgICAgInhlbixkb21haW4tc2hhcmVkLW1lbW9yeS12MSIN Cj4gPj4+ICsNCj4gPj4+ICstIHhlbixzaG0taWQNCj4gPj4+ICsNCj4gPj4+ICsgICAgQW4gOC1i aXQgaW50ZWdlciB0aGF0IHJlcHJlc2VudHMgdGhlIHVuaXF1ZSBpZGVudGlmaWVyIG9mIHRoZQ0K PiA+Pj4gKyBzaGFyZWQNCj4gPj4gbWVtb3J5DQo+ID4+PiArICAgIHJlZ2lvbi4gVGhlIG1heGlt dW0gaWRlbnRpZmllciBzaGFsbCBiZSAieGVuLHNobS1pZCA9IDwweGZmPiIuDQo+ID4+PiArDQo+ ID4+PiArLSB4ZW4sc2hhcmVkLW1lbQ0KPiA+Pj4gKw0KPiA+Pj4gKyAgICBBbiBhcnJheSB0YWtl cyBhIHBoeXNpY2FsIGFkZHJlc3MsIHdoaWNoIGlzIHRoZSBiYXNlIGFkZHJlc3Mgb2YgdGhlDQo+ ID4+PiArICAgIHNoYXJlZCBtZW1vcnkgcmVnaW9uIGluIGhvc3QgcGh5c2ljYWwgYWRkcmVzcyBz cGFjZSwgYSBzaXplLA0KPiA+Pj4gKyBhbmQgYQ0KPiA+PiBndWVzdA0KPiA+Pj4gKyAgICBwaHlz aWNhbCBhZGRyZXNzLCBhcyB0aGUgdGFyZ2V0IGFkZHJlc3Mgb2YgdGhlIG1hcHBpbmcuIFRoZQ0K PiA+Pj4gKyBudW1iZXIgb2YNCj4gPj4gY2VsbHMNCj4gPj4+ICsgICAgZm9yIHRoZSBob3N0IGFk ZHJlc3MgKGFuZCBzaXplKSBpcyB0aGUgc2FtZSBhcyB0aGUgZ3Vlc3QgcHNldWRvLQ0KPiBwaHlz aWNhbA0KPiA+Pj4gKyAgICBhZGRyZXNzIGFuZCB0aGV5IGFyZSBpbmhlcml0ZWQgZnJvbSB0aGUg cGFyZW50IG5vZGUuDQo+ID4+DQo+ID4+IFNvcnJ5IGZvciBqdW1wIGluIHRoZSBkaXNjdXNzaW9u IGxhdGUuIEJ1dCBhcyB0aGlzIGlzIGdvaW5nIHRvIGJlIGENCj4gPj4gc3RhYmxlIEFCSSwgSSB3 b3VsZCB0byBtYWtlIHN1cmUgdGhlIGludGVyZmFjZSBpcyBnb2luZyB0byBiZSBlYXNpbHkNCj4g ZXh0ZW5kYWJsZS4NCj4gPj4NCj4gPj4gQUZBSVUsIHdpdGggeW91ciBwcm9wb3NhbCB0aGUgaG9z dCBwaHlzaWNhbCBhZGRyZXNzIGlzIG1hbmRhdG9yeS4gSQ0KPiA+PiB3b3VsZCBleHBlY3QgdGhh dCBzb21lIHVzZXIgbWF5IHdhbnQgdG8gc2hhcmUgbWVtb3J5IGJ1dCBkb24ndCBjYXJlDQo+ID4+ IGFib3V0IHRoZSBleGFjdCBsb2NhdGlvbiBpbiBtZW1vcnkuIFNvIEkgdGhpbmsgaXQgd291bGQg YmUgZ29vZCB0bw0KPiA+PiBtYWtlIGl0IG9wdGlvbmFsIGluIHRoZSBiaW5kaW5nLg0KPiA+Pg0K PiA+PiBJIHRoaW5rIHRoaXMgd2FudHMgdG8gYmUgZG9uZSBub3cgYmVjYXVzZSBpdCB3b3VsZCBi ZSBkaWZmaWN1bHQgdG8NCj4gPj4gY2hhbmdlIHRoZSBiaW5kaW5nIGFmdGVyd2FyZHMgKHRoZSBo b3N0IHBoeXNpY2FsIGFkZHJlc3MgaXMgdGhlIGZpcnN0IHNldCBvZg0KPiBjZWxscykuDQo+ID4+ DQo+ID4+IFRoZSBYZW4gZG9lc24ndCBuZWVkIHRvIGhhbmRsZSB0aGUgb3B0aW9uYWwgY2FzZS4N Cj4gPj4NCg0KLi4uIHdoYXQgeW91IHN1Z2dlc3RlZCBoZXJlIGlzIHRoYXQgZHVyaW5nICJ4ZW4s c2hhcmVkLW1lbSIgZGV2aWNlIHRyZWUgcHJvcGVydHkNCnBhcnNpbmcgcHJvY2VzcywgaWYgd2Ug ZmluZCB0aGF0IHVzZXIgZG9lc24ndCBwcm92aWRlIHBoeXNpY2FsIGFkZHJlc3MsIHdlIHdpbGwg b3V0cHV0DQphbiBlcnJvciwgc2F5aW5nIHRoYXQgaXQgaXMgbm90IHN1cHBvcnRlZCBhdCB0aGUg bW9tZW50LCByaWdodD8NCg0KPiA+DQo+ID4gU3VyZSwgSSdsbCBtYWtlICJ0aGUgaG9zdCBwaHlz aWNhbCBhZGRyZXNzIiBvcHRpb25hbCBoZXJlLCBhbmQgcmlnaHQNCj4gPiBub3csIHdpdGggbm8g YWN0dWFsIGNvZGUgaW1wbGVtZW50YXRpb24uIEknbGwgbWFrZSB1cCBpdCBsYXRlciBpbiBmcmVl DQo+ID4gdGltZX4NCj4gPg0KPiA+IFRoZSB1c2VyIGNhc2UgeW91IG1lbnRpb25lZCBoZXJlIGlz IHRoYXQgd2UgbGV0IHhlbiB0byBhbGxvY2F0ZSBhbg0KPiA+IGFyYml0cmFyeSBzdGF0aWMgc2hh cmVkIG1lbW9yeSByZWdpb24sIHNvIHNpemUgYW5kIGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3MNCj4g YXJlIHN0aWxsIG1hbmRhdG9yeSwgcmlnaHQ/DQo+IA0KPiBUaGF0J3MgY29ycmVjdC4NCj4gDQo+ IENoZWVycywNCj4gDQo+IC0tDQo+IEp1bGllbiBHcmFsbA0K From xen-devel-bounces@lists.xenproject.org Wed Jul 13 04:12:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 04:12:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366168.596833 (Exim 4.92) (envelope-from ) id 1oBTjL-0002tN-TH; Wed, 13 Jul 2022 04:12:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366168.596833; Wed, 13 Jul 2022 04:12:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBTjL-0002tG-QV; Wed, 13 Jul 2022 04:12:07 +0000 Received: by outflank-mailman (input) for mailman id 366168; Wed, 13 Jul 2022 04:12:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBTjJ-0002tA-W3 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 04:12:06 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f32c5cef-0261-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 06:12:03 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0E0D0339CE; Wed, 13 Jul 2022 04:12:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5C15C13754; Wed, 13 Jul 2022 04:12:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id BTVgFBJGzmIrXQAAMHmgww (envelope-from ); Wed, 13 Jul 2022 04:12:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f32c5cef-0261-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657685523; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=iyWYPbpylJGOKlEX5X9yWX8NaU7kqmnI8rc17bkFUxQ=; b=dGBUErlfIX6CEf2AWtf4SMC+NFpFjAmjKJOXZMzHOjH5z88QDh/BHZNz4FHtRbwSNbhgYW pSXMBGqsF2p2Q4O4ZS+LSMlZTchfpA6XowxRcQDsBwn/NZ7GtDHe/tjJpf9RN1Jyt/DMAg e8DFymeAA6saMkJPN8zaAmhHm+sZCus= Message-ID: Date: Wed, 13 Jul 2022 06:12:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Juergen Gross In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------YY2eSglKxMQZzJilSEwbwsWi" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------YY2eSglKxMQZzJilSEwbwsWi Content-Type: multipart/mixed; boundary="------------JJ0idYU9PXoqFAqKQe0kItgC"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> --------------JJ0idYU9PXoqFAqKQe0kItgC Content-Type: multipart/mixed; boundary="------------6i4tEvXDX4ICZGgoY5V4imS5" --------------6i4tEvXDX4ICZGgoY5V4imS5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDcuMjIgMDM6MzYsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IFRoZSBjb21t aXQgOTljMTNiOGM4ODk2ZDdiY2I5Mjc1M2JmDQo+ICgieDg2L21tL3BhdDogRG9uJ3QgcmVw b3J0IFBBVCBvbiBDUFVzIHRoYXQgZG9uJ3Qgc3VwcG9ydCBpdCIpDQo+IGluY29ycmVjdGx5 IGZhaWxlZCB0byBhY2NvdW50IGZvciB0aGUgY2FzZSBpbiBpbml0X2NhY2hlX21vZGVzKCkg d2hlbg0KPiBDUFVzIGRvIHN1cHBvcnQgUEFUIGFuZCBmYWxzZWx5IHJlcG9ydGVkIFBBVCB0 byBiZSBkaXNhYmxlZCB3aGVuIGluDQo+IGZhY3QgUEFUIGlzIGVuYWJsZWQuIEluIHNvbWUg ZW52aXJvbm1lbnRzLCBub3RhYmx5IGluIFhlbiBQViBkb21haW5zLA0KPiBNVFJSIGlzIGRp c2FibGVkIGJ1dCBQQVQgaXMgc3RpbGwgZW5hYmxlZCwgYW5kIHRoYXQgaXMgdGhlIGNhc2UN Cj4gdGhhdCB0aGUgYWZvcmVtZW50aW9uZWQgY29tbWl0IGZhaWxlZCB0byBhY2NvdW50IGZv ci4NCj4gDQo+IEFzIGFuIHVuZm9ydHVuYXRlIGNvbnNlcXVuY2UsIHRoZSBwYXRfZW5hYmxl ZCgpIGZ1bmN0aW9uIGN1cnJlbnRseSBkb2VzDQo+IG5vdCBjb3JyZWN0bHkgcmVwb3J0IHRo YXQgUEFUIGlzIGVuYWJsZWQgaW4gc3VjaCBlbnZpcm9ubWVudHMuIFRoZSBmaXgNCj4gaXMg aW1wbGVtZW50ZWQgaW4gaW5pdF9jYWNoZV9tb2RlcygpIGJ5IHNldHRpbmcgcGF0X2JwX2Vu YWJsZWQgdG8gdHJ1ZQ0KPiBpbiBpbml0X2NhY2hlX21vZGVzKCkgZm9yIHRoZSBjYXNlIHRo YXQgY29tbWl0IDk5YzEzYjhjODg5NmQ3YmNiOTI3NTNiZg0KPiAoIng4Ni9tbS9wYXQ6IERv bid0IHJlcG9ydCBQQVQgb24gQ1BVcyB0aGF0IGRvbid0IHN1cHBvcnQgaXQiKSBmYWlsZWQN Cj4gdG8gYWNjb3VudCBmb3IuDQo+IA0KPiBUaGlzIGFwcHJvYWNoIGFycmFuZ2VzIGZvciBw YXRfZW5hYmxlZCgpIHRvIHJldHVybiB0cnVlIGluIHRoZSBYZW4gUFYNCj4gZW52aXJvbm1l bnQgd2l0aG91dCB1bmRlcm1pbmluZyB0aGUgcmVzdCBvZiBQQVQgTVNSIG1hbmFnZW1lbnQg bG9naWMNCj4gdGhhdCBjb25zaWRlcnMgUEFUIHRvIGJlIGRpc2FibGVkOiBTcGVjaWZpY2Fs bHksIG5vIHdyaXRlcyB0byB0aGUgUEFUDQo+IE1TUiBzaG91bGQgb2NjdXIuDQo+IA0KPiBU aGlzIHBhdGNoIGZpeGVzIGEgcmVncmVzc2lvbiB0aGF0IHNvbWUgdXNlcnMgYXJlIGV4cGVy aWVuY2luZyB3aXRoDQo+IExpbnV4IGFzIGEgWGVuIERvbTAgZHJpdmluZyBwYXJ0aWN1bGFy IEludGVsIGdyYXBoaWNzIGRldmljZXMgYnkNCj4gY29ycmVjdGx5IHJlcG9ydGluZyB0byB0 aGUgSW50ZWwgaTkxNSBkcml2ZXIgdGhhdCBQQVQgaXMgZW5hYmxlZCB3aGVyZQ0KPiBwcmV2 aW91c2x5IGl0IHdhcyBmYWxzZWx5IHJlcG9ydGluZyB0aGF0IFBBVCBpcyBkaXNhYmxlZC4g U29tZSB1c2Vycw0KPiBhcmUgZXhwZXJpZW5jaW5nIHN5c3RlbSBoYW5ncyBpbiBYZW4gUFYg RG9tMCBhbmQgYWxsIHVzZXJzIG9uIFhlbiBQVg0KPiBEb20wIGFyZSBleHBlcmllbmNpbmcg cmVkdWNlZCBncmFwaGljcyBwZXJmb3JtYW5jZSBiZWNhdXNlIHRoZSBrZXlpbmcgb2YNCj4g dGhlIHVzZSBvZiBXQyBtYXBwaW5ncyB0byBwYXRfZW5hYmxlZCgpIChzZWUgYXJjaF9jYW5f cGNpX21tYXBfd2MoKSkNCj4gbWVhbnMgdGhhdCBpbiBwYXJ0aWN1bGFyIGdyYXBoaWNzIGZy YW1lIGJ1ZmZlciBhY2Nlc3NlcyBhcmUgcXVpdGUgYSBiaXQNCj4gbGVzcyBwZXJmb3JtYW50 IHRoYW4gcG9zc2libGUgd2l0aG91dCB0aGlzIHBhdGNoLg0KPiANCj4gQWxzbywgd2l0aCB0 aGUgY3VycmVudCBjb2RlLCBpbiB0aGUgWGVuIFBWIGVudmlyb25tZW50LCBQQVQgd2lsbCBu b3QgYmUNCj4gZGlzYWJsZWQgaWYgdGhlIGFkbWluaXN0cmF0b3Igc2V0cyB0aGUgIm5vcGF0 IiBib290IG9wdGlvbi4gSW50cm9kdWNlDQo+IGEgbmV3IGJvb2xlYW4gdmFyaWFibGUsIHBh dF9mb3JjZV9kaXNhYmxlLCB0byBmb3JjaWJseSBkaXNhYmxlIFBBVA0KPiB3aGVuIHRoZSBh ZG1pbmlzdHJhdG9yIHNldHMgdGhlICJub3BhdCIgb3B0aW9uIHRvIG92ZXJyaWRlIHRoZSBk ZWZhdWx0DQo+IGJlaGF2aW9yIG9mIHVzaW5nIHRoZSBQQVQgY29uZmlndXJhdGlvbiB0aGF0 IFhlbiBoYXMgcHJvdmlkZWQuDQo+IA0KPiBGb3IgdGhlIG5ldyBib29sZWFuIHRvIGxpdmUg aW4gLmluaXQuZGF0YSwgaW5pdF9jYWNoZV9tb2RlcygpIGFsc28gbmVlZHMNCj4gbW92aW5n IHRvIC5pbml0LnRleHQgKHdoZXJlIGl0IGNvdWxkL3Nob3VsZCBoYXZlIGxpdmVkIGFscmVh ZHkgYmVmb3JlKS4NCj4gDQo+IEZpeGVzOiA5OWMxM2I4Yzg4OTZkN2JjYjkyNzUzYmYgKCJ4 ODYvbW0vcGF0OiBEb24ndCByZXBvcnQgUEFUIG9uIENQVXMgdGhhdCBkb24ndCBzdXBwb3J0 IGl0IikNCj4gQ28tZGV2ZWxvcGVkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IENo dWNrIFptdWR6aW5za2kgPGJyY2h1Y2t6QGFvbC5jb20+DQoNClJldmlld2VkLWJ5OiBKdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQoNCg0KSnVlcmdlbg0K --------------6i4tEvXDX4ICZGgoY5V4imS5 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------6i4tEvXDX4ICZGgoY5V4imS5-- --------------JJ0idYU9PXoqFAqKQe0kItgC-- --------------YY2eSglKxMQZzJilSEwbwsWi Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLORhEFAwAAAAAACgkQsN6d1ii/Ey/h rQf/S/Ui31Ud7GWGhjh1Kl1P60FaXqDpFMwbIYzJzsav9ireUo5hKaBrou4tPdxCoBlYEklo5Lr7 A2ATEigiDJkyovq/1XEtmle3qKF9G5DDZH25x1r56OgzQYpkGVqRqQZgoEh1AXsBygNj1psuakIY /EbL5sD2EAMVeK9IBePjSOD/Q5FZNkxvQR+bEcA68ia7pOOT9VqSPAL2DlbRvraSXSTz/dgxEbYl yu1W3j0e6fiA7CDdL+aJX1RRRwCrRB/h87tTpAONS025Si8mtGT2xq4sPqfP6KcWoqmmS3+d+66g Ji0eBV8EgJmZ8V+MAzb3T0jIinO2r95AnwPSsl1JwQ== =cxEJ -----END PGP SIGNATURE----- --------------YY2eSglKxMQZzJilSEwbwsWi-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 04:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 04:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366174.596844 (Exim 4.92) (envelope-from ) id 1oBU2Y-0005gh-IN; Wed, 13 Jul 2022 04:31:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366174.596844; Wed, 13 Jul 2022 04:31:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBU2Y-0005ga-F2; Wed, 13 Jul 2022 04:31:58 +0000 Received: by outflank-mailman (input) for mailman id 366174; Wed, 13 Jul 2022 04:31:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBU2X-0005g7-AF; Wed, 13 Jul 2022 04:31:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBU2X-0001A3-6u; Wed, 13 Jul 2022 04:31:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBU2W-0003qq-S2; Wed, 13 Jul 2022 04:31:56 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBU2W-0003go-Pi; Wed, 13 Jul 2022 04:31:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=z6pBsxYC7dVmMezkRZwCsMXlcaIPxHzeTv4u0Iz5CSY=; b=O8BOxTXB0814s9kB0G43FubTAf WMTcqVpVRyRBTHC6fOS1KoXHVTjQDHAYHzSoYpawjIPjUgIPOVO4bC32DSh5du5coSIeviCi8klM2 J+sDHIZOXiPYwdRhlLQwE85AzPxX7+qZsGWGzzPRQtCUf+SaBUp3NppUOGG1OVYSdrEQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171597: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9548cbeffffd4253e38570d29b8cff0bf77c998f X-Osstest-Versions-That: qemuu=63b38f6c85acd312c2cab68554abf33adf4ee2b3 From: osstest service owner Date: Wed, 13 Jul 2022 04:31:56 +0000 flight 171597 qemu-mainline real [real] flight 171610 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171597/ http://logs.test-lab.xenproject.org/osstest/logs/171610/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 171610-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171559 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171559 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171559 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171559 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171559 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171559 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171559 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171559 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: qemuu 9548cbeffffd4253e38570d29b8cff0bf77c998f baseline version: qemuu 63b38f6c85acd312c2cab68554abf33adf4ee2b3 Last test of basis 171559 2022-07-08 10:32:52 Z 4 days Failing since 171588 2022-07-12 02:38:42 Z 1 days 2 attempts Testing same since 171597 2022-07-12 13:11:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ilya Leoshkevich Peter Maydell Richard Henderson Shaobo Song Thomas Huth Vladimir Sementsov-Ogievskiy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 63b38f6c85..9548cbefff 9548cbeffffd4253e38570d29b8cff0bf77c998f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 13 05:35:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 05:35:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366185.596855 (Exim 4.92) (envelope-from ) id 1oBV1m-0004UR-BV; Wed, 13 Jul 2022 05:35:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366185.596855; Wed, 13 Jul 2022 05:35:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBV1m-0004UK-7n; Wed, 13 Jul 2022 05:35:14 +0000 Received: by outflank-mailman (input) for mailman id 366185; Wed, 13 Jul 2022 05:35:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBV1k-0004UE-HU for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 05:35:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8f6e88a5-026d-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 07:35:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1F3A5B81CB0; Wed, 13 Jul 2022 05:35:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D31EC3411E; Wed, 13 Jul 2022 05:35:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f6e88a5-026d-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657690507; bh=C6Qvmu8YGI/7zZ+PW9nfbi7sR3QFFcB/JWTbSIlVJFg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XqpAoqynsEuoTHKPzK+XyGdIWKe+7LwOpsOoLz0GOmgpMQt0yAIdlRHvR1/dz0gpL f1wM4YPqOe8Q45XvOqaqsBLBLObiEYHaMn3MGzSN6Anu69/mnWCc1y+6OwF0hxgOsi asY0eSNZbsKov8qKtbpNnfhOgwkmycFbKcbnl7ew= Date: Wed, 13 Jul 2022 07:35:02 +0200 From: Greg KH To: Chuck Zmudzinski Cc: linux-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Brijesh Singh , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Message-ID: References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> <008ff24c-d059-8d39-5e57-6f5e9de0dcbf@netscape.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <008ff24c-d059-8d39-5e57-6f5e9de0dcbf@netscape.net> On Tue, Jul 12, 2022 at 03:57:45PM -0400, Chuck Zmudzinski wrote: > On 7/12/22 3:26 PM, Greg KH wrote: > > On Tue, Jul 12, 2022 at 03:16:01PM -0400, Chuck Zmudzinski wrote: > > > On 7/12/22 2:36 PM, Greg KH wrote: > > > > On Tue, Jul 12, 2022 at 02:20:37PM -0400, Chuck Zmudzinski wrote: > > > > > The commit 99c13b8c8896d7bcb92753bf > > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > > incorrectly failed to account for the case in init_cache_modes() when > > > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > > > MTRR is disabled but PAT is still enabled, and that is the case > > > > > that the aforementioned commit failed to account for. > > > > > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > > > not correctly report that PAT is enabled in such environments. The fix > > > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > > > to account for. > > > > > > > > > > This patch fixes a regression that some users are experiencing with > > > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > > > previously it was falsely reporting that PAT is disabled. > > > > > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > > Cc: stable@vger.kernel.org > > > > > Signed-off-by: Chuck Zmudzinski > > > > > --- > > > > > Reminder: This patch is a regression fix that is needed on stable > > > > > versions 5.17 and later. > > > > > > > > Then why are you saying it fixes a commit that is in 4.4.y and newer? > > > > > > > > confused, > > > > > > > > greg k-h > > > > > > It is true the erroneous reporting of PAT goes back to 4.4.y. But it > > > was not until 5.17.y when the i915 driver was patched with a commit > > > that started using pat_enabled() instead of boot_cpu_has(X86_FEATURE_PAT) > > > and that is when a regression that started annoying users appeared > > > in the kernel. I presume that we only backport patches to stable that > > > fix regressions that are really bothering users, so even though the > > > problem dates to 4.4.y, there is no need to backport before 5.17.y > > > which is when the problem manifested in a way that started > > > bothering users. > > > > If it needs to go back to 4.9.y or so, let's take it all the way back to > > be consistent everywhere. > > > > thanks, > > > > greg k-h > > I presume you want me to prepare the backport patches, or at > least the ones that need the patch to be significantly modified to > apply to those branches. I expect older versions will need the > patch to be significantly modified to apply. If not, please let me know. I will not know until it hits Linus's tree and the patch is backported then. If there are problems, you will get an email at that point in time. > Is 4.9.y the oldest version we are still supporting? Yes, the front page of kernel.org lists the active kernel versions. thanks, greg k-h From xen-devel-bounces@lists.xenproject.org Wed Jul 13 05:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 05:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366192.596866 (Exim 4.92) (envelope-from ) id 1oBVL7-00078D-T8; Wed, 13 Jul 2022 05:55:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366192.596866; Wed, 13 Jul 2022 05:55:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVL7-000786-QG; Wed, 13 Jul 2022 05:55:13 +0000 Received: by outflank-mailman (input) for mailman id 366192; Wed, 13 Jul 2022 05:55:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVL5-000780-HB for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 05:55:11 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00048.outbound.protection.outlook.com [40.107.0.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a511f8d-0270-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 07:55:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7400.eurprd04.prod.outlook.com (2603:10a6:10:1b3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 05:55:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 05:55:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a511f8d-0270-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoS+54FbeIPf2qJJrm7LvEpABt+PFJNzxKA8QrbzTWubfcbLosCXxONdP7fEdqRlvSwY95n34t9Mg6xU39oh1KlXYN1sy4XkxLiWoN/yM09FMZ4gQYhuQsfFZ0sBj508Gq4bPMX+WfupQI6AfU3RfEnZtYxVZvEx9+JUKUrn+4UOw3X4OZob/ZXmIDUR5UozKxqWQyPLRjNbt1nI9OBJQB5Fd65EWvVFAlyYXiKBsgTNCmmicymbHRDBfL31mpog+luYU/JOAVWdr3JgknQTb809ot3RruDfCm1Wsm9iJaQDOYk1s3fVCPvxw/juGephJmjUYsbq6BkXE7ZuiyfXyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9GwnI4wc2WVXTeskyFFlqhlCn8IDGfaU7tHz9iiq03Q=; b=NHLcxWA6F94/OB8T+PORQza1HWl1YfOgesJAK/tRkKN5CR5kwTFPl7z8WnRKSnr540mbiGCLUHaKYfB4E/pLK1MvcIvs9FJG3EQj3Ll42aWvKJkvHryqzjchx+aNYPxJCjY8/j9jM/+8tAoRW3U0+4o1TV1cHNnz1UjKgl0psqN/7Aq66iYLgMCNcUBXcWNgQOgDokVSSyJ26PEi2fdEMf8+gkcRhUzdwMbW8itjQtZFnEX5dCbm3skYMx9zZBEMP3TwkYHmwidOC9ospC6FcpBkubWGMOUC+dlcXcQOYmsncOsO/AJk7gerfZeqsQzNPqYUjxHSKE8PvrXz6bJXQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9GwnI4wc2WVXTeskyFFlqhlCn8IDGfaU7tHz9iiq03Q=; b=hKsD6bQE9xDjwp0nBCXZBl0JgunXyLRc7RJpzgBOKU6fJoxOytLv55D8GQDyCa34iX0dqp5gbz5I/nFFApSqONhr9sujfkobpWh/PXM9OmZhSt52aAjpcNifnwUZSnANtnkzIp5AqVdzXhkYmH+hNoBbxTTGS6ZmI7Gqy9eSE89siWWqJvuSeA3B9bHzTANoWr6JvqD7JX14EFtHv1sBMUiUUhwsNTFLdb3Wbd0GJdXElqS6Mk+TaG32JY0oM0LM37WASrLJQgQUM2bWwUHUL6AdNN/iaG1AVteWQq0lto6f6PYChWsmzea7GOjaVW96wrs6OnczKl2+4MzTeKViCw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <09fee965-9cf2-110c-4484-d00bddb6b782@suse.com> Date: Wed, 13 Jul 2022 07:55:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, Juergen Gross , linux-kernel@vger.kernel.org References: <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz.ref@aol.com> <2885cdcaccffd287ef69c7509056ddf183a38a0e.1657647656.git.brchuckz@aol.com> <388a3838-1681-dba4-dabd-a7f27817bf34@suse.com> <32c86239-c434-369d-b6a7-f6f88cf5430a@netscape.net> From: Jan Beulich In-Reply-To: <32c86239-c434-369d-b6a7-f6f88cf5430a@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8065d7aa-3b7a-43d7-1e99-08da64943c07 X-MS-TrafficTypeDiagnostic: DBAPR04MB7400:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cp08Lt8J2tdFYcBkx8QHfJCYxbTWu0QHcFemdGWT9xXQ4BkT9p8+my6vXZZizTMOmyOAGZXk8vJaFqQR0EVbrJVgEkpTq1bjuEdFCXIp0H9jMvrS0A9tO61WL0WesHda9fX1yhwNeJhRkBfdYJKxu7lBkj9IA9B9PNAEe+CwQn+tb+BaTckihgrZ47Aaqk6mMjaAiKOzNmnJ5EMBD+4U3dIQwAZJ5noNToHdvmyhUjaWr54D9tAY4DLEUTYvzzVVYy2fMscvwW4oPJABVIti2XUkLCggz8zjOZ5ZQaLAIqUmh36oxp0q0BmiMXAi5CmXFZ8PbFGuh2rlUwJ5yqrQ6Z944kjwezUhLNF7Gl2G6lu8AhOpoF0wJdQb1qqTyNsCoTTdZ3CG+2xBW4i7ic3H0x2ocjqCnhY5np3Bexp1SamksGuxHHspO357N+jhIEfKr1iyHWYGDwU1c2IKFXr47JctATGPG/QuI3QGr1XBDfD6I+8KHVv9HpxOgHpPBwJBSdH6+J8r96n6poMDkjpFmAHACofnhsHLgok5/VoMfJWTEB4QhvkMV7IrtT0VomKvusHEt4FqkGVOAfXCq8ZdXJReZM0F1rgDWYMS3Oy+szwrDK+gPE67WP4QrUNXZV8v0wXDuhNpXfQD2I/vo1PZHq83vv7NnyNoDQx9QEtht3G4J1/TrPAWAx4Z1IwTF9CJqnNXd4N2dtNqxCkaKNNDiF2KPVQhVJDfUV1EdePOaVeXFqWU3gXdQ4I6M4pe8fott9ojOpsJHWoPyx05lVVQfohDcn82OrM9vUuju1K8gJ1PHejkSYVEQ6tOLmQ+D60WZEks1LRRD+6MyLp+8ItvWJOl+mzvqUMD6PRKKQfIr6w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(396003)(346002)(376002)(136003)(186003)(66556008)(478600001)(2616005)(66476007)(66946007)(38100700002)(316002)(31686004)(54906003)(8936002)(26005)(53546011)(2906002)(6486002)(41300700001)(6512007)(6916009)(4744005)(4326008)(7416002)(6506007)(36756003)(5660300002)(31696002)(86362001)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NUZhZlZybndiRE1jOFVWaTRPeE5teDRjWmNSeU1NUFZXN1NEcm5rdUZadUla?= =?utf-8?B?U1pDN1p0VVFRT2ZwWUZhR3RTak9nT1YxbjN2cmtKT2pMR3o1K1N4eUhtVVJK?= =?utf-8?B?SkRLcnRsZU1zRWJBTnBKV0lJOThsK21ZYXNVS1ptMXJibFZsU2FpSzNybDZw?= =?utf-8?B?My9tTjlKWDVuMGR6anZ6U04rUTZGK2tXYjZPUklZRnNwUHAvdVI2TnBUaTh0?= =?utf-8?B?MWoxTXZuUHdWQmJ5LzFxYUhkTmVmVGZ0THlGRDkycEFtb2pZMFdXQmJPY081?= =?utf-8?B?aDJkVVJIMmY2NEl3Uy83SFdvcXdtbktQbVJsQm1QbFFJenV5MlcrdjlnbS9w?= =?utf-8?B?V25QeWdVTlZhMzMvV2hQSDJBclJqbHlKTlh3ZVd4TjdwQ1NQRVBLQzNoSmR4?= =?utf-8?B?RmFpYXBRdys1SzhmUE1DekRLZ054Wk9KSGEzOEFOV0VKcWZ4RkhyVHdPYmVR?= =?utf-8?B?QlNmbE1KckxzdjJyOHRXdE0rRzZOMHNzSXJFOTVpeGJiRHQrTnBuN3E0QnJs?= =?utf-8?B?U1JwNHF5Yk53UHYxVlBDaVJ4eVF2V3pFL2VFbW01bUFEY3M5MzVyd3VJb3kw?= =?utf-8?B?QTl5M0N1VkFtU0xXMnFNNEs5NlZaN3BHV3VPdDliM01yQkdUYWp0Z0l0WGRx?= =?utf-8?B?M213OHNJY09oY0JJRXh1VGprTjN3bS9maTlseTU3Rk0zL2ZmQUNmYURGck05?= =?utf-8?B?UE9RWnB5N0xNQW9IeTFtU1lYcEU5eHhwVmRoZittWXQ2ZXVvNTZkWEhEUXNO?= =?utf-8?B?MnZKSjlpaWRteUZDemx2MVc1RDJLemhKRTM3UW91L1diTFpoM2hjeU1CZGRx?= =?utf-8?B?ZkMyQzVOZ01hN3g4TGs3cWxwZXRBallrdE41QjV5Q0txVHB5WENYeWpnMG42?= =?utf-8?B?dW1PUjNZaDRXWndrRnhodmlRYVhieXBXTzJkeUsyNDQwS1FhdXpFRVh0Smla?= =?utf-8?B?bmRwRmdTZDJaTk80T0R2ZTNvOVlJaFNESHlZZWxGN1lyNGtpdTl4aVVWQUJw?= =?utf-8?B?Sit6THlGWlExTzExQ1dlbHlZU0xLN0g3eG8vQ1Bka0FBbDY1aE42M2phK0g1?= =?utf-8?B?MndCbi9OSGVIbXA3ZnBxSlF2S2VNS2tRS3NaQ0hLWFUxbjZTazZMNDFkd2lM?= =?utf-8?B?dzhrU3FGRlp5SEltNHNwaGNnSHY3ZjVNb0s0Mm1SRzBIRm1oOHNPMkZTSDAr?= =?utf-8?B?NDg4UXJGbEsycVlTR2FBNW5MRHY0bUd0M0NlSlp5aUd2R2tQS2pGamFBUml3?= =?utf-8?B?RVJ4UW5ZMTZoMlYxUkhpR0doSzExY01HaEdtNS9FbVNHRnRwK2o1RkJaNDZ4?= =?utf-8?B?TlltbS9ZNUVZSGZNS3B4T2RUbzZSOWh4QmFTeXZmLzF3MEFqOVVOM25hNzRm?= =?utf-8?B?RVdWUzVyY01FWnFla3RuNmhTbVIxT0pmVm9PczdlZWFwanBpdjkyK3J2a3R2?= =?utf-8?B?ZWxxa1JvQ1E3d2FtMGM5TVdHWVcrWkNqSk9MWVd4Smc1bC96ejBKMm5xd3dV?= =?utf-8?B?dElzaVl4U0RUVjBMRlBTK2FXaEcySEpRcGRDWUVCYjQxMWJPQ2x6b0FyOGNI?= =?utf-8?B?Z0pSUFhXT3RyRGU3V3gyMTNremk2ckZWcVJSd0ZvTlZCWGFFYzIwVjlFS1J3?= =?utf-8?B?L1YzNG5pWFNpWW1pNUkycXRFVnVTc2UrWlI4aXl6ay9oek5yc2duSmpZeHFZ?= =?utf-8?B?SlBVWTNKTXlDUmk3ZTZoQVRyVWZwSXVBOU0yejB1aXhiSVBQT3BqK3V1MEZB?= =?utf-8?B?TE5BZldLNytHL3AxOFlLZTNsdk56N1E3bWw2RVRnV3NreGxJSUVvaUFUcGJY?= =?utf-8?B?QWFpZmM1cG51MWhpWG9nN3BHQ3YxSC9kRENQN0NDTFgxcndpa1ljSGJpcjBW?= =?utf-8?B?SVpFejFSTHkxd1BjbXpPeUNGNXQwRHBremdnajF1YW1sdW03Q0tSak5JRzEy?= =?utf-8?B?YnZHTVNIekRTQ3dLNEJHYmNBR21pSlBtN3Vya0hNaGJXRVhCTGZtMWhwZ1Rm?= =?utf-8?B?M2JSdUhWaThsQW5ZdW5rWXYxK0ZEaWxtR0s4dkF6eVBvWVVXU0JaZlVoWUdo?= =?utf-8?B?UzI4RVFoNXlVWHo0MFpMSUt4ajFDRDRGUVhnbGdYMXNXcTFJQmNZdWlrVG9a?= =?utf-8?Q?DmHU2OWWzOTVjyg6SW3mjMKOB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8065d7aa-3b7a-43d7-1e99-08da64943c07 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 05:55:05.3570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vwj0U9lBPQ0NNCqtj8Vf+PE70k9YrqKqPpJFwHrOEpce17dN1j+iWBRFLGYy3pkdSixEbesVBHetumQ8gPR5sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7400 On 12.07.2022 21:48, Chuck Zmudzinski wrote: > I will also re-compile and test the new patch before sending > v2 and unless Jan objects, I should acknowledge Jan as co-author > of the patch since I will be using parts of his proposed patch > to fix the "nopat" issue, so I also need to get his sign-off before > sending v2. Jan, how should I obtain your sign-off? If you really re-use any meaningful part, I think you could simply propagate it from the patch I had sent. But I'd expect the pieces to be too minor to actually warrant that. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 06:18:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 06:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366198.596878 (Exim 4.92) (envelope-from ) id 1oBVhN-0001ee-R7; Wed, 13 Jul 2022 06:18:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366198.596878; Wed, 13 Jul 2022 06:18:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVhN-0001eX-MC; Wed, 13 Jul 2022 06:18:13 +0000 Received: by outflank-mailman (input) for mailman id 366198; Wed, 13 Jul 2022 06:18:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVhM-0001eR-7e for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 06:18:12 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150079.outbound.protection.outlook.com [40.107.15.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9194c440-0273-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 08:18:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4892.eurprd04.prod.outlook.com (2603:10a6:10:14::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 06:18:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 06:18:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9194c440-0273-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zx9YaJZvFrwrhnAdf5cj3aZKu10jI9rD/SlIT38tlbaR+cK2FZDksxxfcbZfQnUcBvk0lNNcP27ZI+M3D4iWEe295Qz7ZqVkQxQ4x6pZjIng93OHuohpKTDFeEYkcIEsxywE8VXIOf4R9Iall3ceTcs5FgL7H8RLURyjXVAJ8N7KSNMeSmnOyX2Mxsurf+rpQJDLQhPi+K8ELknqjHt443OYTX2OwC+c9OxjYEjMnyXYtR7RynIuMyw8NrLllPhdezLEL2MndZ6wiMlR4TjbWhYHia81nc0cqW5w+WNALbf6SsFU5DcmJDS4d/k9sE3paDhFIjdmvDZRaTFh6hvWPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mGf2VtS2XfS4FW9gt7nfASnSt8IWDWM5M09W0hzIawE=; b=lFaPlFz00w3zuDrfbzDlfdTagPvkktBzA1FSEt2DW3l1MonLRMJZ7NS/XEg1/GR1yr48V7FJw+mG+z7+A6xhrnOdJtQVGt6i8ZKal5OwzQvOdTyCtriJUWwYRGRu756UEkYfLkg9sUcmQOg9z8G1R52eleTbJoz2+ODizoH40VMlsoD3GjB3ojbusfgJVAKZTnS+ar9EKe2twwTsMQzrteD+P70V0EnShxdzf6loohHox3RggGsqU38kH2d0rpentI2bqCHD81OUnRfwvUFIwUJIZu6DKGoYsT16xrbzSqp3Zf5go4fzPN70mZ736AV8fmcP2/vXN1Belw1CIhtlNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mGf2VtS2XfS4FW9gt7nfASnSt8IWDWM5M09W0hzIawE=; b=JOj1rsHWPVHDkKitNZMyH+HQB7ejBjwS4bLp0Mu99WDnxZ41VH5CDkaHq6glBjZQh2p6TTtmRsaHfM+vy3QcGiyo3jJYiY7GQsyLBArdJ1eu374SZHCT3tHjljdNOz0cFDM/mJCA5gwRgW5mAgA+YP9/JaQJul0m98PoSs/LbtIN08jlLwsxNUmSylTtyMo1Ir7uJ0qND73cd75nr2YzfiK2I6wSOMUILOsRBWjCmnVolyNv1x0zjUKwOnJmH5/kmohNv/JBUaD2Zk+OeezJZMBR4AXskiw1oI0JkpfQVesEvTrk4x8SPXjp+o9TEMah+9Aa9Q95Gc4gER3fGqGDNw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 08:18:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Jan Beulich In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0653.eurprd06.prod.outlook.com (2603:10a6:20b:46f::33) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: af25e754-b29f-4d9b-e49d-08da64977493 X-MS-TrafficTypeDiagnostic: DB7PR04MB4892:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zEukMHj6TqsgD326RWoDXEaExZKN0mU77UrAXftHhpledUW9smQcu7xlJOd6yT4fTsTbVmJJaGZ+ios05+7sPkQ8A/AoOmjRB5O3UYDq59/iWXBQf8/EKTaIbsfExL3NO679IgzodChsg/qMs9xmn/Qnz1jLRUdCpnzIGCNY4OKzJERhg8gfor4sI0A6Mg06KTZ21m0G3dve4M+hanz/exJvnO0b8MKE9meBa/gBNsysiJRLmBjSzn38pcg1+udTaB/XHkpgcS4utizF0zP1A8UuoK08ini1BoDADGY/p28PXuPwq2MTW0unZSaPUaj/feGuB+yt2pJ1/GkpMkAMcpSY5Vkw3iO2rsYCHcYDof5euHEpsgnItgfLCmyYCGP9USySpE1BGOa3x2KR66rQv9EoZMZLeNcdDAJ/EnwMFhsVivo7snlUf+HK6JXNUjXAaEf2IaE5v6hBY+IeRddJtHoUi1l9ek2cKSpOeg52cA+pynKMgRZM+X42FC04Wp1+82LJQ5zqxLQZEBZYfVc8WVqVPRQTzu3EWmfE08qhiSWxXpWC8bITD9YL1rzyIIMpEPIX3h0EjHhWUd0ElbkepLIwB3ts/NWIHDtmljkwdcDPqqrYpi6ezXpN6MMt2kGUlr3kM/bBeI0T7re99UPLsVIgappUeYAmPglhbaN/P+Ff1h6lxgpFnexQwGAJ/uJNvgSBIlhK3ZNv7u57fDdscn2rpbsl3MeeeSo+mr6WBRpqQxlyJdohgJqrzshBWxIjjihw91rwTBu2yfkkxOTQqMl9aTA1z8k1bv2UxpK30N/+FKiUXKrjxMkqC5N3EwpDUp+idB+MW94EGu3AUm9sCScfQCnsouuegJFIMSOsKmQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(396003)(39860400002)(136003)(376002)(41300700001)(7416002)(6512007)(5660300002)(8936002)(6666004)(31686004)(2906002)(83380400001)(53546011)(4326008)(478600001)(38100700002)(6486002)(36756003)(186003)(2616005)(86362001)(66946007)(8676002)(66556008)(66476007)(6916009)(316002)(6506007)(26005)(31696002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2lsVDA3ZlpiQ202TW45QnkvQlFVMGxUL0pWUExmWFpoQ3I3WkR3QzVTeDF6?= =?utf-8?B?cDRPL0VtcFZpcWl4N0VRL3NlL0lURDh4azY5a25JbHRWMkJsMVZOWGlSa2gy?= =?utf-8?B?bDRzUCtjTDloaWdHdDFWYjFkVC82bEVXOURMVWdlRm8vMm1ZQ3NWS3ByMlN3?= =?utf-8?B?NDlMcXU2bzFrZzdicERVRXd3dnhBRUI3dklqWlkyK2pUaEVyVHdLOFdwd05D?= =?utf-8?B?TWdyTEF4WGtiRzQ5VE1WMjlpaUNpNEFINkkySXcxS1VmRHZJMzA0VjRzelhj?= =?utf-8?B?aWpOQzYyMlVVektLMTBzaitTZnJPc2xzdjVGRmRSaDBWVzllckIzaVRMWG80?= =?utf-8?B?T24xRVJIdUlPVkVNL1VBeTlYY0JEV0Qwc2ZHemxzdnBoeTFEMjl0UTVqNW5O?= =?utf-8?B?UjJDN2dHb3ZkL3dRdmk5RVI5NjlzM0NqU2lpLzYvK2o4N3p5cFlaNmJzYTZr?= =?utf-8?B?b004ZkNkVmdmVGtWd1ZjSmpMMC83YzBMVmFPamI3MUdFeTNrMG9IdTdna3RH?= =?utf-8?B?eWhwdy9YTDI1TGl3bFgzTWhJVVd3aUY5eWFHbjR5d25BYWJIdU42aUFIZE1t?= =?utf-8?B?Q2k2V01UMTJWd2dWNUc5Q09MOXUydXRnUHNVR1J6YzF2ZVVIc0RCM29DdlZ5?= =?utf-8?B?YkhOV0kxUXBTRlVMRWFJcGZKSVc3bXpHR0E4NE0wR1R3Nzd5aG91aEpSUTRv?= =?utf-8?B?WFl0am5RUi9rZ1NHS2xPazZZVnpxMmttd1RJRDkwaTd2TjhhR2UySEQ5emM5?= =?utf-8?B?RUFyYWxscG5uTHNMWktpaW9SWTlPbEhxSTY0UWNtZzZlQnRrOUk1RzV4WFdS?= =?utf-8?B?SC9zYnRtOWpPVUdJQk0vTVZWdlJBUW1hb1NDYWNQUC81VjIxSUJLUmE2WUtO?= =?utf-8?B?czBVVGdQenBjeS8rZW1ZdEpYaGljY1lGVkQybWtYdTRxNE5PcDZUVFpzcUhO?= =?utf-8?B?ckNTN2NyTllWNUhBNFVVWUJpeHc4VThXc3ZURUxYWTRuR2plbGp3MS9nSGc0?= =?utf-8?B?SzhGOUJKTS9NWlVQQjIrbDJ6dTVDWUZ0dEhQMkNHUENQZE9EVjEwR1pZZ081?= =?utf-8?B?WXd5bGJZRzk3VTZKci9jTTNlb012RVpVNUJpVUdEYndPZFFRK1VvT0tVUEd4?= =?utf-8?B?bk5jaW8zQnI2UU8yQUR1c1F2YjA4MFRvMzdXckN0REs2OVRkUTc4OUI1RHRZ?= =?utf-8?B?NXNRdDZCd2wvcTdnaEl5L1JzUE1mZlBzL2Jod3RjU0dZMThQM3c2ZEM0cE5r?= =?utf-8?B?K0VXNWN3QW15VnVSMENNVEVnTnJ5QzdjNHFhQ3MwMDUzdWY4Ynp5clo3OExD?= =?utf-8?B?L0hXc1BCZS9XbllWRUwremhOVjNNeGpaYkgrQ2htNFlzcDJKWE1vdmNQSlN4?= =?utf-8?B?MmhIdlRsNXByYk1sSndFeUhDdS9ZdnRSU01rVkg0OTZyYW5MV1h4UmlzS2pD?= =?utf-8?B?ZU9CV0FjdU1rRkp2Zm5ndWNVRTlFUlRDUFdBSzAra2EzVE9hQ1MzUWdQK2ZJ?= =?utf-8?B?YU5rR05LeXZNYnk2dXlVN2h5K2krNzBiRUJ0NE42RkJyc3ZkT0tmeHZ1SlNY?= =?utf-8?B?M2M4czRlaFVGdTg1ZE0wNS92ZDkwTDl3L2NXcE9SUS8rSDdod056UEFWclQ1?= =?utf-8?B?eHZvanE5Qkw4VG0relBEVlZlOCtNSE40ZlNTNVQzVnBKZGwzMWhCcVg1OXNN?= =?utf-8?B?Nyt5VTgrS1J0TTRtVWJUN2pkdk8rV0tWdUswTmlvc2Q5WEZDTkdEVFo4KzBp?= =?utf-8?B?Mzh1Y2QvenJpL3hSRWxaQ3drZG9UaUV6aUY0UUdjZmpwWSsvYWhUN1A2UG1E?= =?utf-8?B?ZzZQbXRZUUkveGpKbTRGQnM5Q0g4OHdrcFBqanU0TmgrOTJiYk9RSTBwOGdK?= =?utf-8?B?VjFXMjRFeWpWVnBwaEltVDk4b1hQdURScEp1NHFUZXZRYWkrVldpcCtLQS9v?= =?utf-8?B?RDZwclh2cS9rb1kydnlJUFRLSHVIa0N1SExlVmp2djBvNzAwWFI0UW1FYTgx?= =?utf-8?B?Q0x6SkxXUWFEaU44UEFNSW53aTlvQm03RHdWR2NZTTQwbHZWOVVRa0FxbEs3?= =?utf-8?B?MUQwaEtZaGJKU1lLcWs2Z1NoVWQzUlAzYzBEVmZaQnhOOWEvVmxKSWg2WWJh?= =?utf-8?Q?X1xld6PWszTA4VYb1TZk29NGP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: af25e754-b29f-4d9b-e49d-08da64977493 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 06:18:08.6441 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +w/j5yjxr17wQz8KWanpBaKeMFDFLqo+mWLUqLm/BpOV0Xzg5i+k8gC5iTI01a9Rnb2jtAY1b4Vjnd9rACI24A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4892 On 13.07.2022 03:36, Chuck Zmudzinski wrote: > v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > *Add the necessary code to incorporate the "nopat" fix > *void init_cache_modes(void) -> void __init init_cache_modes(void) > *Add Jan Beulich as Co-developer (Jan has not signed off yet) > *Expand the commit message to include relevant parts of the commit > message of Jan Beulich's proposed patch for this problem > *Fix 'else if ... {' placement and indentation > *Remove indication the backport to stable branches is only back to 5.17.y > > I think these changes address all the comments on the original patch > > I added Jan Beulich as a Co-developer because Juergen Gross asked me to > include Jan's idea for fixing "nopat" that was missing from the first > version of the patch. You've sufficiently altered this change to clearly no longer want my S-o-b; unfortunately in fact I think you broke things: > @@ -292,7 +294,7 @@ void init_cache_modes(void) > rdmsrl(MSR_IA32_CR_PAT, pat); > } > > - if (!pat) { > + if (!pat || pat_force_disabled) { By checking the new variable here ... > /* > * No PAT. Emulate the PAT table that corresponds to the two > * cache bits, PWT (Write Through) and PCD (Cache Disable). > @@ -313,6 +315,16 @@ void init_cache_modes(void) > */ > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); ... you put in place a software view which doesn't match hardware. I continue to think that ... > + } else if (!pat_bp_enabled) { ... the variable wants checking here instead (at which point, yes, this comes quite close to simply being a v2 of my original patch). By using !pat_bp_enabled here you actually broaden where the change would take effect. Iirc Boris had asked to narrow things (besides voicing opposition to this approach altogether). Even without that request I wonder whether you aren't going to far with this. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 06:21:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 06:21:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366203.596888 (Exim 4.92) (envelope-from ) id 1oBVkh-00031j-7z; Wed, 13 Jul 2022 06:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366203.596888; Wed, 13 Jul 2022 06:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVkh-00031c-4q; Wed, 13 Jul 2022 06:21:39 +0000 Received: by outflank-mailman (input) for mailman id 366203; Wed, 13 Jul 2022 06:21:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVkg-00031W-3p for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 06:21:38 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2074.outbound.protection.outlook.com [40.107.21.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c71d48f-0274-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 08:21:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4892.eurprd04.prod.outlook.com (2603:10a6:10:14::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 06:21:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 06:21:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c71d48f-0274-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nOCbbF91D/V0UlY5lK8o6shZQNRH7Lnn7vHd4jRlsr5q2wI8VCCSjCZ0/QExZnSjnP2u+Vm10Oram2x38sAEY4YY1tpSwUJtZNfjbtFZA8qFI8Pn0dJH6KvXTsIxiyj72SB9v3V+SMGbEyc4jwC8fBJQJEVZYkWKxCmldlI0ZxAmWOTNzvK9L2imLvitvh7kVHczbwz3hvgMxWLdI7CmfgWu/nrBc+F0tFIMkLXFZRcAQUkZet48uK88UdYFRSxvgBDTGp1WSrsPEwR/q1WrZQcueNDJvXt/8Da0Jd2K8yYlzw9ha6YYWy//m5f7p2wcI87e8ptUSIy+G1MHIGMgxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SEe2o8N71L3Bkw30NpqHygABlyv6r6jVEhL8AhcxjeA=; b=PtqSQST/BNEM14Duk7Fh/aVZuBmFGC8l7b6PYyVWFTFzYX3bl34qLGqCl3HvZMHNsOmCNio6TGsNhSdQCNUqmyYUv9gGvPV2PCHOFW2Jp1dI54Hnb9GVSBcZ4RfhR8fJjhtup2NXMlikGTP7Skaw3+a4h9NdNGylAIdQu7vnmAMdB0m1C7ARIemK13YR0cBKQKuAhKnP5IZ3fk7o/ki6xu+/Clov2IfE9pq/bcl3nKl46W1cR3pKbwFa811uxyY//rmvaryin1DkSO7Ke0VEkNLTtXXxPEF0xjBHLj+SN4wDWPqFKGYBGeUpD2LhqtT9/mVz6de1m7XL/KF73Gddhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SEe2o8N71L3Bkw30NpqHygABlyv6r6jVEhL8AhcxjeA=; b=sycSJo401dobQzyd2TpKm5On+9XhGyMdyKtiAcra7gjjpSENVc5XTG3nc0qW8eUfTMivZKL0VFX6D/eD2mC4VIRsPV9SNHIb252s1HQ2OI5LIDo1GUPKDBB+lWrHsF32GmtB/SHVWTatMTBtmdcZEBLdmXPRIP4wYPEj8+X7gxF8KTCKp6DAcbhWJAwirhSQXvWPe3dgUwitAEy5P6tKT748w1j9H1y4OJT0c5oZ5zdPPh8jxZKtkxZq0zqdb8IlG3R5+HqpJejgLlXhak+68aimU4g4bxsbLWFrphBOlL/ygukTuKjfdzKiIaogvGzL3cSNQW6U9+lhQW4w6g/k9A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 08:21:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Julien Grall , Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 251dfbb1-c6ae-4564-974f-08da6497efb5 X-MS-TrafficTypeDiagnostic: DB7PR04MB4892:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5QLoVgQyXsATJ2kCyCmM0YWLjxLeXK37WvW3wEaNsBBQFi4s9qwpXNTBy6QfKGB39wOYUNorSW66B8su92OkgdrnE9SrieIs9enPxPLcKxyHn2YxVCPl8bi/S3lGNKdkb+PiCmB9qoMOHtl+RSvreQj/QX6/RPbtbu+5H0fHU7LH7W7Q4ZXR9WPqlsQ8VPZxzPY6p3PFCV1GsZBXVJqn8ZsaknuSFpNXy63Jsx5tvsOcfUlvzz3If/0ZBPcWVwjSCUzXjxJOaiekKCffD1IjGSAPgXcXW3rKu/ipA6sLONacHPNGOMI7n0fTgaWcc0sVLbv9/gj1U2BP/9GWmsqm3F1pInHd0+7YcDhSmhIaTsbJZt24xurP9DPTyQ3mzHTVmKWa1cI5WA0P2oJdWL10rvoyrWndnz1aUNFDQLK8GlE+voJKZIRooc7nwWY+MvC5bnPjmkvyQLwpl4ZkjESglZcGoARjvNla9QdGvVpLunKNhPl6FiL0QF8nuaPRhRcTRNPrlXj1XRwMP2lKs1nd2KMM7NlPHaSwl4nCvBTIRLI9zmpNyKuzOX9R6zlxIoehsdTafEP+xWLDmgFe8XKiIRsjncACMLv6yzzH8Erng5TUhimuoquefTIqTDfNvakEyFBP/iW7yeiw9wsGlj0UhZY+cM48t9N/D66yj4bB+fo82P9S0MomK23zI0etqZJg4iJ0sUv/YTY+Yb8ZTv4jF39WgUNDI6DhkDUWyCH57JS6X8KdpeRAOOzbCA9YnwSKh81jLRNZlKBplxl0JSbGWiR6KjKN/AjXDyE1Tq3JhbCMSbULbYNT7VSoC1RingeXUbkOhetBXKUUEOOJrOL5V6GrTV+UGKSefPKagaFIbDfJFGA8FgOjVHJT3lbqqOBx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(396003)(39860400002)(136003)(376002)(41300700001)(6512007)(5660300002)(8936002)(31686004)(2906002)(83380400001)(53546011)(4326008)(478600001)(38100700002)(6486002)(110136005)(36756003)(966005)(186003)(2616005)(86362001)(66946007)(8676002)(66556008)(66476007)(316002)(6506007)(26005)(31696002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUhXU0xSUFdPMUo0cm85Nnp1d0wxbnd2c2hsUUd1bzB5Uk9KdTdFTDQ1NlUr?= =?utf-8?B?OWtDRUtseW94UXJoTnZCS0VWa0trY0RTNERSK0w2S2NTTkJUbmpUdm1aTFh5?= =?utf-8?B?Q05TU3M3dDJIcUFmYWxQSEJhN05CR2swZEw1U2VTUno2UHZQZVdFVW8yUytT?= =?utf-8?B?bDZvWXNWQTJaREtZYmhGZnFFNXErZjh3S25uUUhuM3BWcTkwejFhUmVXTjFK?= =?utf-8?B?VmhZNkdzeTlqaE41ZkxVakZOZU13TGJ4NTR1UFR6b01adkV3Y3NUMW1TcGVE?= =?utf-8?B?cWRQSzZDempEeEFHeFBMazFQWTViOW8wc3ZLVGdjU3NWb2hSNzZVYWZRb3NT?= =?utf-8?B?aXN0NlRLU0tWRGI2SkxoU2o5ckI0MFp5aUo1UGYwZGxZdUJkeTl6S0FGWXRz?= =?utf-8?B?dk9SRUlvQktHR0hFY3Z6cTZZUnhaWG02OHZzckFDbXNWZmpsVnMzczE3V1VB?= =?utf-8?B?ZllvTEp4R0xLM0p4NHlUYisvWXNWc0hIY2xNNHRIVzdyQ0FRMzZZZnNOSXhK?= =?utf-8?B?R09udnBZdEhWWUNaQThTOWRmdjBUdmZoRXVuczhiNzZqbExndzV4TDYranEx?= =?utf-8?B?V0crZXVsTkVzZjFOME5saW5PZDZnS2tIOCtvL0U4T3pTeGtodFJGU3o3ZEs1?= =?utf-8?B?WFNxVXdUbGp0U3RCbngyY3ZicVA5Rll4UlFhcmN0NW1wbzdNM0thNTBORlpz?= =?utf-8?B?OHBVVSs1aE1CMHBYQmpYTkl5ODRMaTZXSFllWlQ5WlY1ZmoybGxvL2dsM1Vr?= =?utf-8?B?MHVhY2orRHF0Mk5Zc0MxTmk3ZUZWRUxlSkR0TVQxaVhwRWxNeUZyU1FqOU94?= =?utf-8?B?SngxSEhnbkRlOHZUcHplRFQvTTdFaWNqR3FLYU9ORTdyVVpxMmx5V29GeG4z?= =?utf-8?B?YTdzOEVsWFlHZ1hmdUtrVXJYS21adEYrcERaMmg0aUZXb1lKcDY1TFNlNkVk?= =?utf-8?B?NENmMXpGVUZTYjdabjc4VXMrcno0dDZRQUNvb0lMejZhRWxpTitHbklFYSs0?= =?utf-8?B?NCtpcFA1cHcvRUl0OHZLUm5LbW0xRU5vdCtreEh3TEJQUkhscHV5Nzk5YlRN?= =?utf-8?B?NVhvS3pTc0N3UXVkeXcyYVVIeFJxdHVQRGpDaFJBTmlzTys0SGVZcVJlWWRP?= =?utf-8?B?eG0xdy85RC9VVHJ0a1QvbmZyeHl0elZSQ0ZnMFBrVWZnQjg5UndTdy9iOE5Z?= =?utf-8?B?WkF6a0d1SDExbVZSbWRRT1RsVVM5SkJ4MXl6eUdodTB6STlXZWV0THM4YnhY?= =?utf-8?B?T0NVU0JFa3lkWHkrb2oxR2hJckFTdlJrcmM1cE9GRGtGV0RhWDBFU1dQWTZt?= =?utf-8?B?NDZucTR6YjBJQ281eDg3UWNOOGZRUktLU2pXMEwzaE5EVW5iSjV6MTZDSnVF?= =?utf-8?B?VTlsS2JzOExONTJrOEt6VFBYZk9ENVRjSjZzc2kyd1FRTkcwNlVpVkxyZDFK?= =?utf-8?B?eWV2a1E1Q2Z6a2JZTVNSVk14aUZ4ck16bnRldlFGaGVIbVdZS2hUVmZiUW43?= =?utf-8?B?K0hHY2VSdzRET0NjNFp2MUFhNWUyTTZFUVl5QlZ0OVh6MTBJV1BxVHAxYW9Q?= =?utf-8?B?U2NnVFpadmIzeFZWV284dENMU0M0R2RlSVAzMkFXL2x1SFZ1L2x4ZHJDZkJQ?= =?utf-8?B?enk5ZDVFenplMm9rNVRNSDNabVVtRk1scHNvNmtxcEJwalFWa3AzdGo3SGU0?= =?utf-8?B?SktZOTN2SGdQYitJeUo2VFpXUjlmcjJDUWt6VTJIdFVzOVRLZFliUkM3dUJr?= =?utf-8?B?WHBzblRUNUdzMGI1c1R0QXFlRzNwS1Vsemdrb252VVkwOGxUclM5dzdXVDZS?= =?utf-8?B?eGVvSDBHVzBQVSszNmxORXJYSGp4S1F3WC84VXgyZFgwYVFkYjUvTXhTazZC?= =?utf-8?B?NlBKVmQ3MXoyT0tleTNxRnAyOWhWaTVlRzV2d210eTYxeHByOCtXUEZFSHQ2?= =?utf-8?B?QUJENm05TitnSkYwVFcwT1ZOWmpacjdSc2pwdUpXL2M1REpEZjYxRnBvQm1k?= =?utf-8?B?UC94V0J3bTl5d1NWTW0wRFpENy9IQUtyeDFlSDBNcU0zdnNmaVJhVDRWUW9n?= =?utf-8?B?c284aE1lU0JCMmd3RGs1RVp4Q0N1d01YczFYajB3Tjl4ZnQxdjFHdmJ2ams0?= =?utf-8?Q?F3kcrN9sdqGRBbBzrLfs3VPfK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 251dfbb1-c6ae-4564-974f-08da6497efb5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 06:21:35.1934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Dj5JaTexwmb6z8cMVnu8hEDMe8dIlukX8ePvKst8EfHB8J228fvHdpnlw5m+Mt2NGMKd6hwMwhAtal5BzyvEA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4892 On 12.07.2022 19:28, Julien Grall wrote: > On 11/07/2022 17:08, Rahul Singh wrote: >>> On 22 Jun 2022, at 3:51 pm, Julien Grall wrote: >>> On 22/06/2022 15:37, Rahul Singh wrote: >>>> evtchn_alloc_unbound() always allocates the next available port. Static >>>> event channel support for dom0less domains requires allocating a >>>> specified port. >>>> Modify the evtchn_alloc_unbound() to accept the port number as an >>>> argument and allocate the specified port if available. If the port >>>> number argument is zero, the next available port will be allocated. >>> >>> I haven't yet fully reviewed this series. But I would like to point out that this opening a security hole (which I thought I had mention before) that could be exploited by a guest at runtime. >>> >>> You would need [1] or similar in order to fix the issue. I am wrote "similar" because the patch could potentially be a problem if you allow a guest to use FIFO (you may need to allocate a lot of memory to fill the hole). >>> >>> Cheers, >>> >>> [1] https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=commit;h=2d89486fcf11216331e58a21b367b8a9be1af725 >> >> Thanks for sharing the patch. If you are okay I can use this patch in next version to fix the security hole. > > I am fine with that. > >> >> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >> In this way, we can avoid allocating a lot of memory to fill the hole. >> >> Let me know your view on this. >> >> config MAX_STATIC_PORT >> int "Maximum number of static ports” >> range 1 4095 >> help >> Controls the build-time maximum number of static port supported > > The problem is not exclusive to the static event channel. So I don't > think this is right to introduce MAX_STATIC_PORT to mitigate the issue > (even though this is the only user today). > > A few of alternative solutions: > 1) Handle preemption in alloc_evtchn_bucket() > 2) Allocate all the buckets when the domain is created (the max > numbers event channel is known). We may need to think about preemption > 3) Tweak is_port_valid() to check if the bucket is valid. This would > introduce a couple of extra memory access (might be OK as the bucket > would be accessed afterwards) and we would need to update some users. > > At the moment, 3) is appealing me the most. I would be interested to > have an opionions from the other maintainers. Fwiw of the named alternatives I would also prefer 3. Whether things really need generalizing at this point I'm not sure, though. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 06:24:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 06:24:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366210.596899 (Exim 4.92) (envelope-from ) id 1oBVmy-0003gn-NZ; Wed, 13 Jul 2022 06:24:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366210.596899; Wed, 13 Jul 2022 06:24:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVmy-0003gg-Ks; Wed, 13 Jul 2022 06:24:00 +0000 Received: by outflank-mailman (input) for mailman id 366210; Wed, 13 Jul 2022 06:23:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVmx-0003gW-1j; Wed, 13 Jul 2022 06:23:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVmw-0003oz-U1; Wed, 13 Jul 2022 06:23:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBVmw-0001lo-A6; Wed, 13 Jul 2022 06:23:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBVmw-0006RY-8r; Wed, 13 Jul 2022 06:23:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CqiSnXQTr+mXVh7vuwlycEF1uwDFDKnNsXTOTrxdXLY=; b=naVw2BAjZ+YWERs+4kkJj+zNO0 TVvL/ZY7lMaHX3OTWJV4UWOD3R2U/kslSN30Z2dK6IAwXmXhAaBt5bF3vRhWpMOks2WDvig4z/Qeq 5fpnjksAK7GYNW6v+xm0sE/qnM33J2dC800zj8HtbTaO4TwYjIGsQpf8LVuVHg9QBLx4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171600: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0ec831fa971d8099e3c4f46093ffb41d044cc10c X-Osstest-Versions-That: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 From: osstest service owner Date: Wed, 13 Jul 2022 06:23:58 +0000 flight 171600 linux-5.4 real [real] flight 171612 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171600/ http://logs.test-lab.xenproject.org/osstest/logs/171612/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171548 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-xsm 8 xen-boot fail pass in 171612-retest test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail pass in 171612-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 171612 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 171612 never pass test-armhf-armhf-xl-credit2 14 guest-start fail like 171548 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 0ec831fa971d8099e3c4f46093ffb41d044cc10c baseline version: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 Last test of basis 171548 2022-07-07 15:41:19 Z 5 days Testing same since 171600 2022-07-12 14:42:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Christoph Lameter Claudiu Beznea Darrick J. Wong David Rientjes David S. Miller Dmitry Osipenko Duoming Zhou Eric Sandeen Florian Fainelli Greg Kroah-Hartman Guenter Roeck Guiling Deng Helge Deller Hsin-Yi Wang Hyeonggon Yoo <42.hyeyoo@gmail.com> Ido Schimmel Jacob Pan Jakub Kicinski Jann Horn Jason A. Donenfeld Jernej Skrabec Jimmy Assarsson Joerg Roedel Jon Hunter Kuniyuki Iwashima Lars-Peter Clausen Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marc Kleine-Budde Miaoqian Lin Michael Ellerman Michael Walle Neil Armstrong Nick Child Oliver Hartkopp Oliver Neukum Paolo Abeni Peter Robinson Peter Ujfalusi Rhett Aultman Rick Lindsley Sabrina Dubroca Sachin Sant Samuel Holland Sasha Levin Satish Nagireddy Shuah Khan Steffen Klassert Vinod Koul Vladimir Oltean Vlastimil Babka Wolfram Sang Yian Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1026 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 13 06:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 06:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366223.596913 (Exim 4.92) (envelope-from ) id 1oBWDH-0007Or-UG; Wed, 13 Jul 2022 06:51:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366223.596913; Wed, 13 Jul 2022 06:51:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWDH-0007Ok-Qu; Wed, 13 Jul 2022 06:51:11 +0000 Received: by outflank-mailman (input) for mailman id 366223; Wed, 13 Jul 2022 06:51:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWDG-0007Oe-O3 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 06:51:10 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30063.outbound.protection.outlook.com [40.107.3.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29eb5a86-0278-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 08:51:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7073.eurprd04.prod.outlook.com (2603:10a6:208:1a0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 06:51:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 06:51:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29eb5a86-0278-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lX6C48tJt5wmRyuSr4zF1nCAXCDwEGozJe8BOWTuyicX5jOU7r2gLjp0n2u0zXdfotUEH74Hvng9CdMnJbhxKSXfZoFVIxvWZ/2rugP0zHRFJcggGs3SP/qKe+4fo28vxwqi3SjaQ5s0jkdLDQ+oCC3PsdjQvP3rthTUOVnZvrhtY1u0NaQ1gQMUngmjInrUork/zNVSN8xVK0gaqNK4rOD1/NQlW7ZT3eIvgWhPwOtDrLMEjTKnZa/IA60Ua9I5WOgFBA7ZxOYzDZScD7l9cLvGaSmr34Qe/u96XfbaJPxcsY60vuLwCiiXyk78o8vmNGP+GBWyhtSiCOPcDy4weQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6NJRqb33foRIlRzv8CIxbgSgEp7TIiD2HG98JRKZKjU=; b=dPf0/si6A36CS/EK32Vzw6DLIjIgqz9aoTGMS097NUZu4I0H9Sn+fc3XDgFkKTvK/NmEQvc2QrueBCTdY51uH0pwjziBQMYQK9kOezuCMObhwnaj67Wfx2w7s8HDEsopF1XqjxOs1eR5Auq56b1kOU55qP1Rwf51vFBGQj3w8d9F+/ky0/Ccs6upnvPVIJrRqli9f8wqELJvitSbm9FVfkNtIKO2MVmy8lJUd3mlcLm+eM1fi6mrYFPwDAHlYRqFUi1JQNtLwDea5CuWbL1jE9B0e+LTqW53vTfrI3oERO4n4sd9B0RxmkXUIsuALngRwDy/QTcMQ32K3Qha6y66dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6NJRqb33foRIlRzv8CIxbgSgEp7TIiD2HG98JRKZKjU=; b=3giUHwTPBLJ4zm8F05VJFR4OyuE/qFR7d5FFHPbtWme0zgIX+lziXKbqmi586ZCENWkoQVNCx5V0HfOXlThuJOr/I808ZTH5CuG4W4nN2VlrD8B3otRFM5aUDhxXzNSQAxz4RmsahSHWEyJCbpS5u0kycgz3TIplSSBXeIh/pdNe+Dctq+x6fUgAfh99eM7OrKA+KoG6yHNmMD7NmI63zhYDoVcToD3pjlekNKlAvonoPXfN25ue3m975zrTzZW2I/0F6sLci7fj73mNLOSX/VLDLQvUZkGJpwNx5KqkcMjuAP5QkvZ5Kfnzkhy5Q9x9HJRZiIhJe6x1QGmDRgCfOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b8c5d7c-ee0c-dad6-8659-5b4b339c2358@suse.com> Date: Wed, 13 Jul 2022 08:51:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: log non-responding CPUs in fatal_trap() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b62455f5-f214-4f44-2a2d-08da649c0cc8 X-MS-TrafficTypeDiagnostic: AM0PR04MB7073:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZY8wOEhsthNuh8M/h8hekKJ3kBxp3iLYb1V1LpU7vBuvmI/BGN+ZSL97vR5W4oCKGEyRlHxFa4Umn/V7i8RNBkK/J3/C95SllG/0W6oA/mTeAwW4u4hF6MPYuxzxCrwMXQ2bZ+3UMZgohhCbsuW4C93Jg1ym3dKKxsOPgj7JV+Qt8sYuacgFvCHqsa44qCg2i9nph/Jy7wWWCNa31Nvxm4VGdb5Gju3AsEXwYXOppFxK7/6R4sm/B8rLAkvaa0iWdQf6f3LKuJbuKqxTok81q1HY8R3pbSwUPZfUpRpT3mvkU94/nP23kkQdFQj2b+zRroVNVMoH+a5GPW0H2ewq8yT/WIYkyz9M2MuRMRPXjxkRE7RZHwO5blC/R/1f1NpGI/dJqcRG/KNjR62DIfX8ebWRpQbFFveytITdnFdGJy12qkScXDnA1L5i2ZXjh2i9CABo0yuX7XZKpkwsQuRhd0O0XmPLT+jlCxQSew/F5oSfLbc3XogsnDTzbhj1H6/WhVhIUy7TX8AfxwFWE+1aogyWB6ikDp4G36EzvS2SWfVTTrqnL/YrOltED7VKAFxjvBZQcen2BjN1R/zRE6Td4S67SZwzMsQA3yUgWSsxpEQtMhqZqTX+B08kDX2Qa5hWM3E+I15ZKu3XBz/iVJlK79Q8M8J0kkMVgnBuUf/H7+R1+wTP1DqF1Yr8tJnbIbKTX5dGEtY6kvQvHWgLkMdK33MUNDiLcK1j33+WI9BDj6q9ycw9c/YFyaFand9Y3vrRXpXZpqquxK1seCN5xMFkKo2isngYtY8YLYVIrlf4KH+3m1cg7f1A//xFYg6RV64sbVdOYvyql553fv4kbOZuQg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(346002)(136003)(376002)(38100700002)(2616005)(5660300002)(31686004)(186003)(8936002)(4744005)(478600001)(6486002)(2906002)(66476007)(8676002)(66556008)(41300700001)(54906003)(4326008)(6506007)(86362001)(36756003)(6512007)(66946007)(26005)(6916009)(31696002)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGRsU3UxNVh6U1k1b0YrYUNxeEQ4T05qR2E2S09PVDZZRzJlNXVhTGdSZ0pV?= =?utf-8?B?MmNBMkI2T2ZSWjRCZUZ3UElyWXBmc25BRjBQbGlOMHVsT1o1MDdiTm5velB3?= =?utf-8?B?MCtxYU1kZUt0TWVlK3pkaW1iRHk1dWNUSmxPajVOODBvNUQ2ejZxSEl5amFU?= =?utf-8?B?M0RqY0djRmUyZUdLeGxLZUlxcmN2cU5oeVRtQ2RycFpHMmFKc0pRd3dmOXN3?= =?utf-8?B?QTI4bEtTb3Z2N1JCdG5sdnFSVk9FRHp5U1ZtWHdzd2ptenNqbWtpa0cwaEt1?= =?utf-8?B?QU9OUEtBQjkydWlleXBkdnhyS0JiSmNPc2NBT21uMjl2a2htRU9iblFhOWtx?= =?utf-8?B?L0gzN05IZGNNL2FlN3Mxa1RnakNXeElJUEZyS2xaZXRWajFHZUNNR1B1MU80?= =?utf-8?B?a2I2aFUvaDNvVlpXdk9wSkh2WDVacTd2UG5nZHAvTU5YeUxaVlhvazVEd0Fr?= =?utf-8?B?d0YyRlAvOXV4dUhpN0piUlhRaGhGcVdGdWRaVjA1am1uSGlEeUVteUNTem1p?= =?utf-8?B?RzI1M21halgrbjVtSkxoM05oWll0WUFRWGFzTUxSNXdVMXlDdk96OU0zdjZC?= =?utf-8?B?SG1QaWwvdEZHOHJGV2NZRTIrMmY3T2FKMzlneU11NXMyV0RFckJoNHNIdUox?= =?utf-8?B?eHYrNVl5K2ZFeldkK2lUd0t5a3prRStyeVduMkZ6bzBrVFNMWTlPdzVHeXJF?= =?utf-8?B?YXlkMm04TGFJSTlLUTd1OWxqL0lMSzFZc00razVnM1JnWVhNVE1BVkR5TVhC?= =?utf-8?B?eVkzeEVJMUdyOHo1WW5odjBLSkJjbmtiVVpqbUVDQndhYVRFT2ZjcjEvQXls?= =?utf-8?B?RVVsV2V3QkJFSmpJbElBazYxZFlGWUJVZGZIdkRoZjhLOWs2cmtxSkxFNDlr?= =?utf-8?B?bmJTekVqY3JpSUNoUzVkOUVYNm52R2F3NE1WWFBJZldVNDRLOEVEekg1TlFL?= =?utf-8?B?QVVmTHlwSEQ0V00wNDZ2N21US292VkdJdUZZVnRqSGVFYWd0R1dpQ1BLWFJp?= =?utf-8?B?eHRqTEVHYTk3U21Rc1pHb3FWNHpQNVVKd0gvWmdLVjBPMSsyVHdwbGI5QVM3?= =?utf-8?B?SDFXSGJFMVFKVUVLbVV2Nkdsb1k2Z0pNczRkQmN6dVNuS0JxUjYvcHpLMmFo?= =?utf-8?B?Y3hKMWJSaTg2YU9NODFueXZuc296U3ZLOGM4ei9nSXp5WDRzSzViOUVudlVK?= =?utf-8?B?NEljdVdHcWRRdjA5b0NKeHNPNHI3S1AzdkNhSFo5Y2xIRG5relpOL0xDbTlU?= =?utf-8?B?UktneEJTVVBld0xlVTNBakhwaFlHU2k3NGRxalR2a25LaHB2VFhZU2RucEFV?= =?utf-8?B?d1J0UVNzOUY0MWlwVkN1aG5aem9KaE5DM2pZMEZwbE4zcjl3Vm5jZ0dnNDZw?= =?utf-8?B?c2xQc2JnRzhhNFZLV1ZnR1E0aVd4M3RMSE1ZQzJxNEdQWVY4QUhFb3dLQ2tw?= =?utf-8?B?QjNraktaRDN0QWVpTHkzSUNDOFA2T0xVVW92dUlMMnBjMjQ3RWlPUmdmMEhH?= =?utf-8?B?bUllb3Zzc3MrTzkyUDNUL0xuT1M4dGh5K3ZmMCt4akRjdmlVYzU2aTg4OW4z?= =?utf-8?B?c0xhOGRHTEdWeFVLNXk5SC9XVTdJaHBvaklpZUI1LzlndVVqNjl3Ync2L2Z0?= =?utf-8?B?M0g0cHF6MkdZcGQ0dytTRFY3WldPNTlVSjJndjBtZVpwU3NaTGlyNmpTNU9W?= =?utf-8?B?ZjJCaEs4dGlqWkdDcncvR0I4eExPV2VJSFdMZWZMVUtDaThxQlZ0SWpzTE1w?= =?utf-8?B?OG40SVB5QnIvNzl3dDZoaWhTOGloMEEvYmZ5VmxFeWRxWGZLL3lsbzVJbUpV?= =?utf-8?B?RHBCd2hoWTRCVE1QLzNxMjBSL3ZRUWNSejNuNlNvZmprU1hOWkpRR2FQS3hL?= =?utf-8?B?UjZpM3U1VWEyNHd4ZFlaME1OTDZldHl2SDVPdkNVRTBFOHIvVjI3NUN1YzVa?= =?utf-8?B?YXRoSzFzVUMzdDlWQ0NHdytET0JDSnhkMGZyQTFvSXdySTRZR1d1OUNvODQv?= =?utf-8?B?ZkVVUm1IdWlMTWg4RkhNMFRKWk9MckV1UFlXK29sYXJRTzhONFFJNEpwazc3?= =?utf-8?B?bUVCcENJMk4wajV6dkhJRUFsbzh5eUNuMDZabldzRzM5TGVJbzFqb3MvZ2ky?= =?utf-8?Q?d30VZFqtk9U3F6uXAaXfql4K9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b62455f5-f214-4f44-2a2d-08da649c0cc8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 06:51:02.0185 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g0rwEPftJjXTSLHZUu6Rpkjb8TLss1reJMdmfrU0M2mZe9mRVlTrqVfDh1g6muBkTUa8Azg/y9HTuCkE1Ns3Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7073 This eases recognizing that something odd is going on. Signed-off-by: Jan Beulich --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -845,6 +845,9 @@ void fatal_trap(const struct cpu_user_re msecs = 10; } } + if ( pending ) + printk("Non-responding CPUs: %*pbl\n", + CPUMASK_PR(&show_state_mask)); } } From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:07:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:07:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366230.596924 (Exim 4.92) (envelope-from ) id 1oBWTF-0000we-C4; Wed, 13 Jul 2022 07:07:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366230.596924; Wed, 13 Jul 2022 07:07:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWTF-0000wX-9I; Wed, 13 Jul 2022 07:07:41 +0000 Received: by outflank-mailman (input) for mailman id 366230; Wed, 13 Jul 2022 07:07:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWTE-0000wN-Df; Wed, 13 Jul 2022 07:07:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWTE-0004gV-B1; Wed, 13 Jul 2022 07:07:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWTD-0004UG-Ta; Wed, 13 Jul 2022 07:07:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBWTD-0005BN-T6; Wed, 13 Jul 2022 07:07:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=D73tI1ji4r/ArW7sG7AijkO5GYOi5DT05G8/V3WREbc=; b=Nqe0SQuo1fb1i0+limjT7HJULI jGLwcD8eOTbiYp5ZB5mfnbjBwi1KftFqquaFjoCOYVVDIRUjMQvwL2I5ye/fLj8HGVtR0S8NkkvqJ 19vZlCx96vdpB18E+pdi6oRtBr60U7O6Pv/r2CdbnYCrg7nccLiAesh+QqbfL+up8CY0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171601: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=72a8e05d4f66b5af7854df4490e3135168694b6b X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Wed, 13 Jul 2022 07:07:39 +0000 flight 171601 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171601/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 72a8e05d4f66b5af7854df4490e3135168694b6b baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 1 days Testing same since 171601 2022-07-12 16:11:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alexandre Chartre Alyssa Rosenzweig Andrew Cooper Borislav Petkov Christian Brauner (Microsoft) Christian Brauner Christian König Daniele Ceraolo Spurio Dave Airlie Dave Hansen Dmitry Osipenko Evan Quan Ezequiel Garcia Hangyu Hua Hans de Goede Heiko Stuebner Javier Martinez Canillas Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Kim Phillips Konrad Rzeszutek Wilk Linus Torvalds Liu Ying Maxime Ripard Miklos Szeredi Neil Armstrong Nick Desaulniers Nirmoy Das Pawan Gupta Peter Zijlstra (Intel) Peter Zijlstra Rodrigo Vivi Steven Price Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Zimmermann xinhui pan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1907 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:19:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:19:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366238.596935 (Exim 4.92) (envelope-from ) id 1oBWeU-0002aB-DL; Wed, 13 Jul 2022 07:19:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366238.596935; Wed, 13 Jul 2022 07:19:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWeU-0002a4-Aj; Wed, 13 Jul 2022 07:19:18 +0000 Received: by outflank-mailman (input) for mailman id 366238; Wed, 13 Jul 2022 07:19:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWeT-0002Zy-Al for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 07:19:17 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2057.outbound.protection.outlook.com [40.107.104.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a177a60-027c-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 09:19:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4971.eurprd04.prod.outlook.com (2603:10a6:10:20::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 07:19:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 07:19:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a177a60-027c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZjegvlmbAsDH2bfr3BCESIHijq4/rysR9DCXaEbQkQAq4UDqd7c+Y9Q82BthVr2pq95yQHo/wPw+M1DxQuYoq3sAp271CnShUuib9MwXAM5/9MoX3VBbCwI8hMmIMc8e76ddzBR8AurkOTl7QY0Ulqb7VGM4QVbha2xoULWMt6PQX2SlHbzcJrlegrN1R9F60Z3dGz9Bg71pY9DbXRe+KXQbi+MypMVPLvR/17pDRzCp5r4ukNqGJ+gH1n2ukmPVmIOtvgAPcegx5WUA19i+Nbd0YeVSco9aQDgZIaGkLZki9JHqQlyT6MhfnxSj484w/vTYY45zga3YiwVAcvMCSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SCQpVhSxAHuSJZxodfCHMWro24FuwsjYLLiWvuR8O4Q=; b=fsGbc2Kix1G1edlHXQPOvBoCXTjCqk7bjyEZ5NPL3UBsPBBGsuIw8K85s9oOf9V0x+clnf/sptZIIAhpuSAOHqI6IQoXIcryujE3TERyeaVbef0lwS/GYkMvhqaIZ6DKL9mTCpv/x8hvnxLbeZusxyF2T9Pi5haABjxZzPuw/aTNdNhvJB4hIDJ4krPesybysagihXa0ytZ1JGCIzC326nNp2R3VwR9kYORxe5Qmh1GnQW6rdFL3cj7k9C3CbvAneLDEfeyOEu2J/7VNWajvzCO6Qk9tTYrkwl7H2JDaY6uCyq9uEjmMrivKOgZT92OC4lsEBmdKrOxyyxUo5KJOcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SCQpVhSxAHuSJZxodfCHMWro24FuwsjYLLiWvuR8O4Q=; b=Pyz1d8SIkR6nT+uRbpughiurDK3lEr9uXaQOIl6uChnlbLyQdy6xiZUFhNsIr9fpwxtlA7oRW9ThiZ/s6SlbhvudSsyqawtzdWBSwq48HcATKVfiXAJYIUUPgx5IX/kJLDyPLmxRY25m2TBWJGk2Dcokty86x7GXHJeLC2RrO6TcnOtvqibjQ+12vqJBkCWY1a9GpM0FYsO1bOrP8D0xAKy8sVVBirUsebpFNMIkAXUQ3an9vuA3ZWDTMbUwDtcypSqcmp0sG2vk5Y2he69eUVp1Y/W+88jbSKMEmipl2yYcbKYTm085P1KtptqSAAWDEu+LBNut3bvbbqrdvVRjKQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 09:19:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xue: reset XHCI ports when initializing dbc Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <4874087c2304034e0d917d649f7cb9d46c149ed6.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <4874087c2304034e0d917d649f7cb9d46c149ed6.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 19c2a3f6-6f88-4a46-8dad-08da649ffa9c X-MS-TrafficTypeDiagnostic: DB7PR04MB4971:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MAooVI8V6FGu+y4X6iKsZdQsGoaMhv/wh1iHu3JJdpWFvvInYlFFPImh9+S2Wdmrs5xEjy6GEFRg8KXFJNzLSu9qVukDIya0xvzNg7i50YxmVLe+peXHeI2BhI3bkvxbUXWtKMsRipL8o33z/4PsqKH1WLnYKjo/lWYCSrh+8XtrgoDw0ExS6kEY8Yn2lnVTps7fVujwuRVmkj58bddiE6ieatoJFws0lU5j9M85EEFeujPdjTBzmv+sriBthsB1qahhgNCnXPPtxSAj9fW9u0qneAA4R7K0sXfj0H9nHqI4umagulSOMr5d15KctprFyngbj3BAMw8SlvABoYKCf7MqX4adeKvn2EBTcuqDBQ0PR6Z7wgbp2thiwKO5e5bcyYXDFRa9JL5no6CFTc5whwmwAhFch2vMBUvHLZPz6St9RC9XrdFRgRcT4jdmr7G0+kCR9pqo5SbvCWB0Ix1lvJmU1uwG20m3FEGprixfZkz14PD0SvcMoPW2ylJUliQDa83XOnYLjgRWDxPsocfSfUlJJShWoqP3ioiXo5fC2HWIfdLnImfJSEQNfdJkmu2EA7pPRVVpfS/xOI5CNiNxW6lWp7mZaU6WYV5o8khXBMd98eMdDNkB8En7dHcwWGh4Fniq99WzwFCctZpnOlmnFsOfj0JSyz/CjuHJ/oOUzaUSHKs6K4IYCff/9SVPhQfGmBgG1k/F1m/9TXzU8dYDeiJsogDlucPY8jpK1teBkDnot46gYFZL+GRFMJtYHqRMBwXHhE1Ky0bM6+VVGcUxRE0TAg2S9OrMTCSKFRgkOTdQhTxm1eAU9dQV+PR/0epkJf4KDoR4WfRQWZdWJCiB9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(366004)(346002)(136003)(396003)(6512007)(8936002)(26005)(5660300002)(6486002)(38100700002)(478600001)(6506007)(31696002)(86362001)(2616005)(2906002)(41300700001)(4744005)(186003)(53546011)(36756003)(31686004)(4326008)(8676002)(66476007)(66556008)(66946007)(316002)(6916009)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VC8veWNoUDBTY241UzBaVTVCOTlRQzJvaEJUbTRHRll3QmRvUmFNWHlnVWVG?= =?utf-8?B?VzhETDBSRFR5L1NkL3N3dEhNOXRmSEcyNGIxMmsxVDBKekdxTk5JYUJERHR0?= =?utf-8?B?TWhxbEtNclRLRE5JWmhiZzVPcGdvbDJ0UTlmQ1pkakhFbUJNcnhZYjhNTi8r?= =?utf-8?B?UDFiMUJxRDhDa3NrZGZjMkVPeS9wSmtja3R0Y0VQblovQnJMZkZKcSt0cHkw?= =?utf-8?B?eDRiNThhSWR5SVNzdWg5OGpHeVlRdkNBd3R1a3Rndml0ZWVsQTZFWGdSSUR5?= =?utf-8?B?Z2pOeWNDT1JIZmRLVDJ4S3duSWpxNFEwbTY4WHJDdlBaTWpsZ2o2Z1BZWGFB?= =?utf-8?B?THJ2clNtYXVCbHcxQnU0b2ludkpHQTM1ckRBZXpTMGI3bFJMYVVDamEwQlJM?= =?utf-8?B?TmFzTkNISy9DR3FHbFBXcVoxbWpvekZ6SGg2WmZsWWFNaWE0QndJN0JHUGVM?= =?utf-8?B?ZFBjZzVEVW1hYjB4c00zYXdhQVh2bnJ6allmUysyQ2V5WGg2d3VsT0xVTXdk?= =?utf-8?B?ZFRjb3NDajg1MnNuQUp4RE9LMHVwak1pbVhOakdEYnFMMUdZTnpEVXl2Y28y?= =?utf-8?B?SGRZT2l2Wkx0LzhvZmZTYTZHejJaTGZ1U0REckJUbHRCcEhHNldsMmFlS0hJ?= =?utf-8?B?K1Q5cVVCaG5EenlkTHpjM3VOY1lRdmtDSWFGTTNKM3pHakh1ZFRDNHRMRkVa?= =?utf-8?B?bjJURnVhTjZpNUxOR3Ava3pWTmhYTFoyTXhiRWN5UlJ5S3ZicDdzL0JFNGtq?= =?utf-8?B?eVlLSGRsSEpqVGV1L2Y3YjlrTUhVdVhENjNGZXU1TnZuN0ZVVk5VRGNVYmlL?= =?utf-8?B?OWlsMUNIbjc0QXcvbEFXbXVzRVBmUXRuem9zL1ZRajMrWTZrSUsvVTIwR3Jl?= =?utf-8?B?ZCtjeXN1blFGNGt6UnNiZU8xelBNR21MbjdWcWFUTGIyZXphZFl2Zlp6WGlV?= =?utf-8?B?Y0REc3RRd3FHZHErclB0d3laK0F4RHQ1ZkdKWGRCbk9XVUF0R1VIYmNhQ0F2?= =?utf-8?B?RDJJZkpDZXozVm9Xc1VTd3lVK3A2a09yNlNpWmYyeWtVdTdzMGgxam1PQTdx?= =?utf-8?B?d0ZUY2lqZXp0WGoyK3ZWT2V6TEVNaEEyVXBjdG9Nc2FDOE5CeitFdzZ0d2VQ?= =?utf-8?B?OG1vMkgrTFAramlvL2VCcEZiZ2tVQ3ZlSytybXhlR1FiNExDaUozUVFQaVdP?= =?utf-8?B?N3hRblJ4VFdtTlBXQ2lFU3E1ak5NRWRQdER6TlZNUUhWRVc3OE1GYW5YR1hU?= =?utf-8?B?cDdKZ0htWXZCNU5mWkkvWHJjVjh5OFJGLzlwemRoTTNwKzJtUUpXN1p3bnl2?= =?utf-8?B?TmVMQ3JxRTFDV2J3VFdnVWlVanBCUW1KSVAwZ3FuVlkxZ1dsN01wWTAvUlNZ?= =?utf-8?B?c0h1RmtxTkd5VUlOQ25Md3Y1WmZMSVZtRFdyc004MGpOa3krODF1ajVYY0U0?= =?utf-8?B?SGpVZzRUNmNHVEY3akpReXh2bXZ1RWxHWE5JYlNxM0ZmY3JHUDVxOWE2U1ds?= =?utf-8?B?MHJnQVRZQ0VNTUFaOHVWSk1vN0Z2ODZXVjRUbFMxcFhJb3AveXhrZUd5cHlG?= =?utf-8?B?Z085VFVnSlRzMU10L3RLYXRWY3FwdGtNSlhGclc4L1J4OGEvL2djalBISk9O?= =?utf-8?B?ZzhmdFFqVXRVekg3Yng5TnBxeDQ1OGdhNmJGUEtGbklnMEpKaG9pRlVuZEZt?= =?utf-8?B?Z21qRHZ2a2FBeWZqVGhTYkNxNXBrR2tQeUNPRmNERlVIWWVLT0VkOCt2L3BN?= =?utf-8?B?TytURmZRcmptQmg2SGpXekUveUxQQWdIOUZZbElLdlZkVnBDdnc5TDJwVEYr?= =?utf-8?B?eE1NN1k1VjRBU1NDKzJxMktYdEhUelliVVE0ZTlqQ2tTZnBNLy9FemR0SmJ4?= =?utf-8?B?QjVhdFkxN25sWDZZL3QyVllycVkxM01PREhJSlZ2NXAydVlQZGdwRTNEbUw2?= =?utf-8?B?bVVzcENiQVlzV3ZRK0RxM08zUit4QWpITmVhSkI2Z1lNbTNZdmRRM1JiZ3RD?= =?utf-8?B?ZlAwTUNoWmh1K0l3M0V0VE5WTVpmdWxrbmxZaEwvZnN1NVJWSlJDc0pNRGhi?= =?utf-8?B?dTRSWlJRVG9OMFhiY2FlV2NkTmlTdjlUV3k0bmFjbitpUUJ1cmVMZzc5cWVj?= =?utf-8?Q?4Anm4tKeGXwjgNt9VJVFBUtVi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19c2a3f6-6f88-4a46-8dad-08da649ffa9c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 07:19:09.4737 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: stPjgIvx47MauXpKoKOJ5pfe5gd9tyHBOUn+3i3QLo5DYXpxVEfKVSL0hxLOOg6mno9DNF2YbtlOmVM/SO3eTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4971 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > Reset ports, to force host system to re-enumerate devices. Otheriwse it > will require the cable to be re-plugged, or will wait in the > "configuring" state indefinitely. > > Trick and code copied from Linux: > drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() > > Signed-off-by: Marek Marczykowski-Górecki Acked-by: Jan Beulich Of course it would be nice to get an actual R-b from someone knowledgable (likely going to apply to subsequent patches as well). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:24:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:24:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366245.596946 (Exim 4.92) (envelope-from ) id 1oBWjo-0003yw-0t; Wed, 13 Jul 2022 07:24:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366245.596946; Wed, 13 Jul 2022 07:24:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWjn-0003yp-UF; Wed, 13 Jul 2022 07:24:47 +0000 Received: by outflank-mailman (input) for mailman id 366245; Wed, 13 Jul 2022 07:24:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBWjm-0003ye-LV for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 07:24:46 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2071.outbound.protection.outlook.com [40.107.104.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id de98de93-027c-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 09:24:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB2965.eurprd04.prod.outlook.com (2603:10a6:6:9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 07:24:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 07:24:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: de98de93-027c-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkNfRFbI1SQIfv8XP44NHJTUIkbl0uO6iNfH/z/z340f6pgw9e3/phFwOW/yEDFR+RwaQ1dtgK+6ch7pAPfcITtWyefyskJtRF7wgvvAKB0PblnMqeWJ+W/+pWXr8gzehV+wlJezh1X8if9QVcaaNF0FjeXlE0e/z7DTnNRIpz0hIBRmeV/pPDL6itNx7HCz3w8U7VSmghPTTVr5K4OMrwdlRsc9hG9hLOdBgaMqXoTuwM/9Rli+gVe5ZpsfymkQrjtqMcW3bMomJRw7G+adH6NdDciEebVEaLzWNkNGD5L3CnHDByr5hUOOY8ckVvyJJ6Nx8iJWVOCDHkT461hfAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NFOt2YU7Jt3Tz3956jw2bIzPeY3CQF7ICcOF63E80+I=; b=FfGE5n9t7W255yi8yLt8ArRh8LyWPTZAEjuq80yiaJsmRVKTgOvN1pb4+wLHon3Yu0WUaakeODsyzKFIi+IbZtSGSiJcanWrRQH3FoF4Jre6r1Uald/wPxEmuAflCGwz1UU9fvgenIgu3Z5jWrNRYfVdcRQnRBK9JR3S66Zhlx1dUfkQPc8bEKCu0VaMtRQWYgPiLUgNuRCEWPxJEEyS3VLHnNxSKRy5tkhDkYE3rB6eP8fyYQ82+ROY7/tFIb3SpU7xb9A7seK/bhpGELl8zQ2RC2VuQ8unWqHugxD+WFnBnsF/oQ6LJA0nMpY80WCldwUUJFLeyN1AkiZDzSCKbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NFOt2YU7Jt3Tz3956jw2bIzPeY3CQF7ICcOF63E80+I=; b=PFU/m9qz4LPKD7AiJuCWusqPbWqKa9Aaghu9iwJOLq8IA8ymOTBvLxchOYp6shybxqjJKNVg+V/C3f/nZt6Hv/P1ekmSbvxMsvgE9HGovyoUK0EcpHdj9TmhGm6Sv72HoAy63S2SnRVIYgOF91AKR3UYFnOB5voiCypEsj4p/FEHjVU7NlG6AhII2TUChs1yK/ycUwDGjn1ukGAFZZNF+NJRv012wNvOfJog/kB+x+MwjwjAl9LbXEzCst07CemgjGF1pJKfe+Y/gpecrap2f0ZCrpBlmr0HAXrZ66g7WQl5tqW63HLlxYR/qLJg0LOl+vDzeOn5de52+fy/cDS2FA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 09:24:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/9] xue: add support for selecting specific xhci Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <399a41db5eb32197364b47a7031c30464803fa76.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <399a41db5eb32197364b47a7031c30464803fa76.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0089.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9c8449b-ffaf-45c9-e388-08da64a0c1e6 X-MS-TrafficTypeDiagnostic: DB6PR04MB2965:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xFaDkOErRIVcJo3ajnrhKBm0ekRx0Dbl7882S4BKI//HtK9bwdWhuQtgF38KIL4p5bM1C+hlNVZIhDIxYt2PrZ0crrGZqWBjBi/uMwFDT5g+SuDX/AXlwUaBOI7pkx1Ko4dgRDZuZ6tZyRoSJPtO3ptWu00BUp0gi2/AYzou/OVYqH5q7M3YuEDucpybRucsJ4nfE1dfF5v9Yf9oZGo2JhlT3u6Vx0aJ08vqAeTttXsImuxVjYvSRUCTagtxnsKHzgT0hAcYiaf/lT/OxNotCadao91A2oMcE0ORaCAnYJMypimh2zWXlBt2ZsbInBFQ7vzA/xwPxK3TcOZ3kY3VDPEz52LWp2zy/Pb7JqNQM4OfP5QOKONWvB7cyrKPvhMIkYdAU9+C9MjHBMORgoExIpfUyTJNIV+omplpkNAL1xi4WASDxHSkO7sHVWOovHeJ5hlEtemww1ZftglQg79vAAXOUp048/KW2bvm5hVMq2ZA/177Qn2TMUnXHE0QE1AKmHLokybPPVKQpLQEl3mXrtMZfcDPBMDrkZbcxyAyhV1X5+XM1rhEMVG2X88RCRLCXRxxk+HtHgSA4h0XXhK7q7IPGc7w6seI7mKYMJdJ67z6sXSRZxd27wQkttvufyVcxTvGz/9tVAruuhcSSGVLsV3wCUIQdKtqSSRTjXVF/LrBWFq+SchHNqra8Rrt9jFfKOjGWwJ3MJFaF+XR4VN9DcgzxiuJhvrp6UrpwaKSElGhbKo8BGkfq4NXnwjZI/fKmytuoHi0Tu1YeN11byi5rRp05KJpvWev2bxFa2+6fB5fBsfdBXzN58sBcy0TKPwjgOkBJsgAjPN6BRdhrHrIq11DGZA9c/McsjVSZSdGIio= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(396003)(346002)(376002)(36756003)(8676002)(316002)(6916009)(53546011)(31686004)(54906003)(66556008)(38100700002)(66476007)(66946007)(86362001)(4326008)(6512007)(6486002)(8936002)(26005)(2616005)(31696002)(41300700001)(186003)(5660300002)(6506007)(2906002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0N1MmhWZTVXZjV0NWN2c1Q5SWhqWVg4ZllVOGZWSnV2ZUlPbFAxMTlGcHdT?= =?utf-8?B?WnphMHVDbG1oQk1JRXRlbTljMlpuSVJXcVJETlFQb1N5WWdJMk5QYU9VRjV2?= =?utf-8?B?S1ZtVnVkM0lrQ1NhK0txMk10a2RveFkvSWNhcUdNNkhaOFlxT2RuZWlWOVcx?= =?utf-8?B?S1dQcjFWcTc0RDFNc1ZMYWg4bzVtb01kT0FmcC84VnA4MTB3NFViUFA2ZHFF?= =?utf-8?B?QjhTdXlxMDg1NTkzc3I2SGtkSUlWVTR0cGFlZ2Z5K0JnZmFGbFdjb081VnlT?= =?utf-8?B?ZjBpRWZueTEydEVWQ013T25udUlueHhDU0JIWnV1UDYrbU9zV1g1WmNaa292?= =?utf-8?B?bnFmL2RnaS8vMTE5NHRyTnZaMDEyT0kxQXlMTFRyZ3Zyb2ZRZzRDV2U5c1ZP?= =?utf-8?B?RzFyeVMvZ21hYlVab2xvbHh3NmlTeGp5RDY2M0xjVC9jOXhyeEc4eHU2QzBx?= =?utf-8?B?U0V3ZWNSaW1JSDFnR3VzTk9lL3k1WHZmYVdKVzl0cS9wN0wyRTE0Tm5MYWc2?= =?utf-8?B?cDltZ0l2S091YzYvekRCNUpjTWcxN0N3TlBwS1BnQjhsNG8zaTJmOUVDdnpX?= =?utf-8?B?dWRxMll4bDdRVzIzekxJYWRlZmd3bEJOZXh6UlE1OEJISFFzVmx4dW51Wmw2?= =?utf-8?B?U0cva3cwL3NBVUNMWjc0MEMzcnJpeFQ5a3k2L3NlQkJoRHZyajNXNXoxVWJy?= =?utf-8?B?N094Y2x3bVgwcW9FWFJFaUZaR0V3UHlPZEhScWVaa0V5RkM0V2c5T2N2czNM?= =?utf-8?B?QnBqaFdVVElESG9HOW1YNXI1OXR4SCsxdklhYXJOMUdyc1M5L2NwdDNxTWtY?= =?utf-8?B?WW40WnNTaUtaL0ZmemFvaTVtaVVhK3BtWlF0dGdsbmp0bndNbFhLK1pabzRi?= =?utf-8?B?Q0FXSzJYUnhqUmdaV0V0UjR1Mm9NejBQL2tBeXovRE10bU4wbWdhWmxxcWFC?= =?utf-8?B?eGNGWTZXbU9pbFpidDJkVHE4WllEZDFNZDlYMlVESzc2RWVlK2pucDlYK1la?= =?utf-8?B?dUZuRFV4cUtMdEM3L1IzdFdsWUhuK0QrazhOckxpTDdIQmpuQTNIRXlDN2VK?= =?utf-8?B?c3REV3MrZVYyWVFsR2MvWmttZ0FrcWtWaHQ4VVcxRE5aV2xERlJJR1F2Qkhk?= =?utf-8?B?bGRJb3o5OFlsdUdCTjlHU3d4VG01ckxyZC9YWFphRVRHdjdZUUV6akRWRDU4?= =?utf-8?B?ODdqSTRMZlJrVkNBbmQyWWg4QXJLQkMvRUg1emR2TkdDbldjR3RaQys5enp4?= =?utf-8?B?M3UzeS9pYWFXTHRiSnNpVVpWVzFDd01wcFd6SmhxbVdQL3kxLzBSTXdOL2Fp?= =?utf-8?B?TEw3T3ZwTzY3NFE1c1U2THZ3UWtEamc4Sy9ON1gxSTdNQWo2emQxU0ZoQ3FI?= =?utf-8?B?Q2RwbzJPemdaNjFXWG5MaFZZcE5VRTVyVk40cXlFVnZGcVovVGZBRlZpYWxh?= =?utf-8?B?c3VtM0ZKSUxDTFhVMnpreGpCcmliTU5UYm5vekxPeDVaSWtlbFJMTElxQUU2?= =?utf-8?B?RVBmYXlHZFRENktVMms3UU96SkI5a3NkY2dqMmF5SXJuc0RZdnFRWmlxNmtZ?= =?utf-8?B?S1FMOWU0U1NJREozWUc0dnhTS1JoTnhTL0p3NGFNdFEwYktTU1hONHk0UHJz?= =?utf-8?B?TVBqSVZHeVpXbUdSYnBHNUd2ZTZBRVFZUnVzNnlJNHlCSm4zNlRtYzZzOGlv?= =?utf-8?B?S3BJR3R5MTVTV3QrbXVTVVRnTW5zc05VV2tKcnBYNjBDaFh2bDVKRmowbmds?= =?utf-8?B?bkM0dmsrQnhZbEpuZmlQa29VMkN6SUJqVGhCUG5GeWZzVk1DTGpBZkY0Q2g2?= =?utf-8?B?SktNZDNJaWRDb1IwcGo1RHhsNUt1MFBma0c5dzZYeXY3UmJUTFNTWmtiZ1VP?= =?utf-8?B?UjhqN0hFVXduZ1BTbmx4RzVvc1VzdXdyb21qUmVPT0kwNC9iV2VudzdlbEFU?= =?utf-8?B?alA4WitWUWM5VzJrd3RVb0RnYkRTcXdVSTVnZVo4aFdDL3B4NXYzVDdubDJD?= =?utf-8?B?ZFcvRVh0SEw2cFQxaWllbFNabXVRWVN3NWpvTE9qVHQyK2VUcUo0LzFPSDJm?= =?utf-8?B?OVkrZUZZeUpUQ0JOZ2d0d3dyc3dnTndaOGJPT0pEOUVzY0Qva0NPZDRSV2pP?= =?utf-8?Q?6uxui7cUoFEI3T4pla+xicoZC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9c8449b-ffaf-45c9-e388-08da64a0c1e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 07:24:43.7963 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ugbt56ZfW9wdGxsa58GyChsWC6m9xwvkc9RMZc21x3TO1O7UiP5qRy4q9Gg+Dn2Xwvna0CZirItJGyEWGzry7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB2965 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > Handle parameters similar to dbgp=ehci. > > Implement this by not resettting xhc_cf8 again in xue_init_xhc(), but > using a value found there if non-zero. Additionally, add xue->xhc_num to > select n-th controller. > > Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich preferably with two adjustments: > @@ -238,24 +239,35 @@ static bool __init xue_init_xhc(struct xue *xue) > uint64_t bar1; > uint64_t devfn; > > - /* > - * Search PCI bus 0 for the xHC. All the host controllers supported so far > - * are part of the chipset and are on bus 0. > - */ > - for ( devfn = 0; devfn < 256; devfn++ ) > + if ( xue->sbdf.sbdf == 0 ) > { > - pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); > - uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); > - > - if ( hdr == 0 || hdr == 0x80 ) > + /* > + * Search PCI bus 0 for the xHC. All the host controllers supported so far > + * are part of the chipset and are on bus 0. > + */ > + for ( devfn = 0; devfn < 256; devfn++ ) > { > - if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) > + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); > + uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); Already in the original code: Why uint32_t? If anything, uint8_t, but according to ./CODING_STYLE unsigned int might be even better. > @@ -955,12 +967,29 @@ void __init xue_uart_init(void) > { > struct xue_uart *uart = &xue_uart; > struct xue *xue = &uart->xue; > + const char *e; > > if ( strncmp(opt_dbgp, "xue", 3) ) > return; > > memset(xue, 0, sizeof(*xue)); > > + if ( isdigit(opt_dbgp[3]) || !opt_dbgp[3] ) I don't think you need the right side here, nor ... > + { > + if ( opt_dbgp[3] ) ... this inner conditional. Jan > + xue->xhc_num = simple_strtoul(opt_dbgp + 3, &e, 10); > + } > + else if ( strncmp(opt_dbgp + 3, "@pci", 4) == 0 ) > + { > + unsigned int bus, slot, func; > + > + e = parse_pci(opt_dbgp + 7, NULL, &bus, &slot, &func); > + if ( !e || *e ) > + return; > + > + xue->sbdf = PCI_SBDF(0, bus, slot, func); > + } > + > xue->dbc_ctx = &ctx; > xue->dbc_erst = &erst; > xue->dbc_ering.trb = evt_trb; From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:48:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366253.596957 (Exim 4.92) (envelope-from ) id 1oBX6l-0006vN-2A; Wed, 13 Jul 2022 07:48:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366253.596957; Wed, 13 Jul 2022 07:48:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBX6k-0006vG-Vl; Wed, 13 Jul 2022 07:48:30 +0000 Received: by outflank-mailman (input) for mailman id 366253; Wed, 13 Jul 2022 07:48:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBX6j-0006vA-11 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 07:48:29 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2e5a5069-0280-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 09:48:27 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 4A5DB1FF64; Wed, 13 Jul 2022 07:48:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id EC05313AAD; Wed, 13 Jul 2022 07:48:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ueYpOMp4zmKUJQAAMHmgww (envelope-from ); Wed, 13 Jul 2022 07:48:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e5a5069-0280-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657698507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0CGUbRqbAXCelWKPuWFUYe6GAN1O07JgHKbKoC7xYHQ=; b=Y3ZpLT2lCpW1dP6yPmM2DmZPeTqeyduPSIW9j7irvcpEF7hscExLoibMTUTOBjlVYa6RAN MAaMEJuj4PpJQ4LNdRt3ptF4g7VnicAhhhBm76Zc3eTHt/e4GiPFYnOVq6BvrNbHoVFjJD 0e6RHrT4QQt2etZ/ByOKjGOcAQDVyeM= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() Date: Wed, 13 Jul 2022 09:48:23 +0200 Message-Id: <20220713074823.5679-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xenvif_rx_next_skb() is expecting the rx queue not being empty, but in case the loop in xenvif_rx_action() is doing multiple iterations, the availability of another skb in the rx queue is not being checked. This can lead to crashes: [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] [40072.537534] PGD 0 P4D 0 [40072.537644] Oops: 0000 [#1] SMP NOPTI [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 [40072.539211] Call Trace: [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] Fix that by stopping the loop in case the rx queue becomes empty. Signed-off-by: Juergen Gross --- drivers/net/xen-netback/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c index dbac4c03d21a..a0335407be42 100644 --- a/drivers/net/xen-netback/rx.c +++ b/drivers/net/xen-netback/rx.c @@ -495,6 +495,7 @@ void xenvif_rx_action(struct xenvif_queue *queue) queue->rx_copy.completed = &completed_skbs; while (xenvif_rx_ring_slots_available(queue) && + !skb_queue_empty(&queue->rx_queue) && work_done < RX_BATCH_SIZE) { xenvif_rx_skb(queue); work_done++; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:52:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:52:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366259.596968 (Exim 4.92) (envelope-from ) id 1oBXAr-0008KL-Jp; Wed, 13 Jul 2022 07:52:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366259.596968; Wed, 13 Jul 2022 07:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXAr-0008KE-Gb; Wed, 13 Jul 2022 07:52:45 +0000 Received: by outflank-mailman (input) for mailman id 366259; Wed, 13 Jul 2022 07:52:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXAr-0008K1-2C for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 07:52:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60075.outbound.protection.outlook.com [40.107.6.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6a79953-0280-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 09:52:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4574.eurprd04.prod.outlook.com (2603:10a6:803:6f::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 07:52:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 07:52:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6a79953-0280-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=idKraY9MTXwsb508N1TMlisKsOzDa2b0VTsx4zA7GZ/2SvMvwLzEdSujBw37KGumCOV+FprrVhpggPKviZ9Ag5K0FUwfep4c5rH9g+eCrqa3sQ+Ham7RHKnsYuONENQubw2fZv/FYoOvBTSjelZT0vVLivzQt2XODObe8YO5XR4lvZbKAaIiexCQOivrJI0WqcSkwTup7/A2mHJhfPneFNETth8jc5gQ92dQZVCzCzND19frecfDwnBXimRmj6oEcXJv7t+BVuwMNIPgI1wnCZaRC4gm306/y/8aAjadOnwoL2YYVrNRb4Rs+FcEdfhVsT04aIiPBh3B1dsO8rF09Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iOiGbfV0z5lZIUjOxHbBoyRhAmtUY9YeW/L9Ese30/k=; b=GZ/VZE7aYcBNWY647LWd8Lo4fvIUmD6w1Fo+/bB+uRKq9+BkpAWSJizZqnL2Lx3kxnGM2ntgtVYdFX73AQITFCf/xZtSNgHfkNp5t0/T/9pSqRBRbthYNVfIR7LIbyS/wbIPYDMOFA8cwCguqFVxnRkPODK6MUw0CZ61EHV8mrdYNkD2Nt+JxC2ZWtYaYEvUKH1+2GRrnn4ecZvSNioEduSia0snmmUjGvbdkoZw+d0OCwt2v5/QvF3zHatSJiN26RT0EvOS9/DUzLY88IhJDzvOrul8Zc2e7q9CPND2xQsbA7yXJ7LZi77exqd76S2eyn5Dwf68z9IAEPdeBVGBEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iOiGbfV0z5lZIUjOxHbBoyRhAmtUY9YeW/L9Ese30/k=; b=s5CRLeWwXAYdKtkcL7wUXU1jSaUH7dFA7i6KdxBbJARImjVU6a7Yh1M0IE2NO2SYlRHT8QmgVxf50eSzB5qQ1aFgc2kym4V6JcUjzcIEKDzI+DVYnH6RS2/m+RyjZxwYGRQtZ1nxeOi8QH03HYveYgmK9EcBqnEhzwZbRIoRUX/VpsAzk4p3jPJHmHYi6BBqTsnO6wk1X4x2J+aE82XvwMUtTGeSwbXQYEF2OHE7ezvTCZROP0S3bHwgAodPYvfLtpKNQXPo6VgGQw35fyCdVn9mmGtKos1F5p5leJup+IJ3WKP3P+3liij1QVfyAssMRw6efQ8SvVCTsPmfjkNlYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 09:52:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86/spec-ctrl: correct per-guest-type reporting of MD_CLEAR Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 116541ca-4daf-43d9-3482-08da64a4a979 X-MS-TrafficTypeDiagnostic: VI1PR04MB4574:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5EIDAZt5GmOJhIMfra9+U7mZ5wtbYOV3Ko7hXqm+fD5YOTmFPHPN67R149OB6+R4+TROtFoVxJYVzlzEeIrNL7AWfjIGGQPdVud8QEY6DQ6R4ZMah1tp4D3eHoW2rw6/QSrWJRWhkl+h3qnmelbvm30nb4D/HiMUeDJ6bm4/9LhlWouBnPp4qKQ9iYTgI+brSSEW0ClB0FRfHSUN+YDc+znnclrWaIiVA6fJAre6GkHkn7XiYfqpe+L4q8i0wZic7ygY36ZbPCOVEb1m2VXOM/ukWjbfxSAGNDIA9rFwv7HWvggOVoRQbXDDsya3dqNB8NSUB/r9wSRRzIFkXG77uD+2JE04KLDFNrrH6nqwannyBIuZx6MkiQq9w3BAFfT/BRcPu/kQk1NtYQ/y0DZwfCW+ljPctyp8OdFlpt93jQEdXYVAmoZDiGZHuFOtGdXLQ+ogtzeAJbhQILtChnVxxhXzUMEctVKVC8E0vXNL2EP0Fl6Y6o9RWGMDDb/exgSkCBFFZH93g0vjqoloEBE/nH37TtWTBm0p9NdhSdJUd+WjOPIKMrh4fx1WiEI8yjr9N427bEHSJP7APbBcDwR79mmbCgvya+7tZ+JI4N62+vygyMdsbk3CcE2wJPtF1BcESTLqVEEaQKI1WGBzaBiBNsPf1XXdZHpL4x0AtRs3WOcht9t0/HhZfacBl7mAtJX/F9clrgiqwSh8Iu/1aeib6x3ceWMTdbZnA5NSLdb2MhnsHvshtMAo+XnojauivvZttzaNISV+yv5jzZv1Xc+/3HD3gK7/5T0Gq1QfOMYIP4mfI0l5K2iSmZ9pCMXef7t8CB87ZRCuU0tlk4o6ACTB/gpijHgEnSMywEc/NaxtmL8XdwCZFFcEVBXutPoOo3r1 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(136003)(346002)(39860400002)(186003)(316002)(6916009)(83380400001)(38100700002)(31686004)(66556008)(66946007)(4326008)(8676002)(36756003)(66476007)(6506007)(2616005)(6486002)(41300700001)(31696002)(86362001)(2906002)(5660300002)(54906003)(26005)(478600001)(6512007)(84970400001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MGFEMnBjaTVnbi9BSTJiQzc3NGFUWXNOT0duKzltNzNHemZSaDJMVGVYTkEr?= =?utf-8?B?L2ZsV2FnWjR5a2lka3JqM3VTM2s5VWV4R2FuVzFacmlYWm9UZEF0WE4zWU9m?= =?utf-8?B?a3pNQThCNHRwK3pxNkExck9Qc2l0MEdXbGgwTkV5QW5CRHlMTGRXMVFEK09i?= =?utf-8?B?Y3Q1Yms5TTVIWWs0eTJUVWtXV1hWcGZoQlVaT0NxeXorME45NjQ3ZXU1b2R5?= =?utf-8?B?NVA0blVpbmlzT1dybTJHbkRHb2dJU2dJNE93Sm5weWRIcUV3dW5wTmhkMG5M?= =?utf-8?B?ZUZUUmxvUWNTa3Y2SzU1eGkxRG84UWc5azBhYnUzYWhQTTlxSHJxV3ZQVzJM?= =?utf-8?B?U2hVSkgvTjJkRmhleEFrWlBocjFaSTh6WEFKUTdZVUJNeFZrNG9ITHcyelNj?= =?utf-8?B?SjRGWm5Vd3BWMUtqVjd6VXZGWUNDT25vaDREL2JSTCtUNmtVazdYUzFjM3hl?= =?utf-8?B?UUZib1BCYTkrT1dTSUVQbG11cklnQVdWdjAzSDF3cndwNytjYzNTQ2JSZGxU?= =?utf-8?B?Mlhob1NHOWpweVcwUnBxN2F6dVhXajJpc2Erb2tlQkZtRFljWlpBSTFValda?= =?utf-8?B?dFJOeDVJLzExalVHRHpIcDJKVURWTDdMMlNzQWxJM3hyZEl3aks4TWxuak01?= =?utf-8?B?VTNwWVNPMVVPWVIvd1hTcVo3MVc4MVlHSTFCRTFaUzB0QmJUaEY5V3FpYWZy?= =?utf-8?B?OW9oTHBEMDdKZVRIejFZSGNkbWZuMUYrTWF6OGQ4ZmU5UjJSbjJTS2NLcXY2?= =?utf-8?B?UU8rMlV4b0thekZCcU54cVRoUmZCSmVaZWNpTUNxaGFYZ293Q2VlbGRoekhu?= =?utf-8?B?MDVOb3JDKy9VWFlzU0tKaHBGSVVMbU9zSmxkMHBaNm1sSFY1TGhhVG1wWnVG?= =?utf-8?B?NnZNK204N1V5d2luK2tMWEpqS2N1YlA3dVVucHljRGppelRkQTAxdG1IUTB1?= =?utf-8?B?eU9NdC9OSlJ6RGpGR1ZhYVZSZGpkWldldlJZV2IwbXhKZ3NhQ0hGdjVPaFBI?= =?utf-8?B?RjFTNSsycm1lZXhHb1RaOGdVRHlOSkowUTZjMkF2NnZNd1owNGUrcE9rbHFw?= =?utf-8?B?eXh4c212Rkgzc3J0eXpGRTdlT0NDSVFteWRKTG9FS2VtcDNJRkhGVVJNZklC?= =?utf-8?B?Uk91VExmbjdmTnRnY1dQMzlIc09jb09vOHN2Rk5VZnlDOUhPenB6TFJFRk1V?= =?utf-8?B?Rzc3RHArdlZSdnRiYlNFOFFzN0JRVFIvQW9iSTEzQ3o0UXdFRXF6Ym5mNEZW?= =?utf-8?B?SXc2NWlma3ZxOGhydkI5UDd1WW5rNjE0Rmo5S0RtVVIrdG45c2F3ckhseVhL?= =?utf-8?B?RzduY1JSRVc4UmZNVkpYZFFBTzhxR0wwLzhoeXRRMkFEd2h4U2NhMjM2K0hk?= =?utf-8?B?Ykt0TGV3L3E2MWR3YlNsUWpTaGQ2QXZydWJUUytpS05yRXNIa1M3RnlrZUZ1?= =?utf-8?B?ak5tL0VUUU5uMUdwWW96cExtUzhDekdFaDFZTHZyTGVieGlxSTg5L3FPYWZQ?= =?utf-8?B?Q1dNMDFMOW1QNTJIVkp0bFpZWERqWkU2WkhmdWpKSG5jZ044M1J3aXRVdjg2?= =?utf-8?B?dUhEV2pLZUFpdEhmaVRtMEdtN1JsQjFZVmlLMWJXVmFDSndvcWI1RkhyeGN2?= =?utf-8?B?blFzZFNyVVNCUytyYk1wN0luTkdValpCWDNiV0JSQm96WVdFZmMyVzdxMFcx?= =?utf-8?B?VXZaZ1RIRkllanlHUmJ4bGxNdFhSbWgyQnNuUDZtSVExbkJIMjVIcm1Ybis0?= =?utf-8?B?SlkwU3FMalVwT3FzbFJPN0NiRE93SStSTTZHZkVNVlYxOGkxNmgrY25rcC9j?= =?utf-8?B?OXhjc2JpbUlRUFhaNnVJemwzMDE2RlRwRVR0YUZNMGFvN01jWkNvWEZRc2pv?= =?utf-8?B?cXRVYzlyUTNGK28vVThzOVdobXNsRHlsS0RNV1BrTHNmdjRqRTZrTk5ZdkdH?= =?utf-8?B?VjAvZk50bHZxeEl3cmlEK0U3UkxJTXZMUytxQ204a1R6UCt6aWtYdDI0WkZ1?= =?utf-8?B?OFVGNC8vTUJ6cHRPTkdpc2RKRzNUdDFZb29Fd2hsT1RUaytIelMyOWFDYkp6?= =?utf-8?B?cDZQZnNJWFRMSmJTR2dabE1WK0tkdUpLUUJIV2NUeTh4ZGVqV2Q2dkJxQVA1?= =?utf-8?Q?uBdtPZKiMUFv4X2wR+ONaUCjh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 116541ca-4daf-43d9-3482-08da64a4a979 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 07:52:40.8303 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /hMB9AoHQEvEM3ZQZMu5At7SrRDgBJOYjtOh3pWTYes+rdAAgNUO25hWaK3wdv+I0LopjtvRjaKkQUGL9KfsOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4574 There are command line controls for this and the default also isn't "always enable when hardware supports it", which logging should take into account. Signed-off-by: Jan Beulich --- unstable.orig/xen/arch/x86/spec_ctrl.c 2022-04-13 14:29:38.000000000 +0200 +++ unstable/xen/arch/x86/spec_ctrl.c 2022-07-13 09:38:44.012913760 +0200 @@ -511,13 +511,12 @@ static void __init print_details(enum in printk(" Support for HVM VMs:%s%s%s%s%s%s\n", (boot_cpu_has(X86_FEATURE_SC_MSR_HVM) || boot_cpu_has(X86_FEATURE_SC_RSB_HVM) || - boot_cpu_has(X86_FEATURE_MD_CLEAR) || boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) || - opt_eager_fpu) ? "" : " None", + opt_eager_fpu || opt_md_clear_hvm) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_HVM) ? " MSR_SPEC_CTRL" : "", boot_cpu_has(X86_FEATURE_SC_RSB_HVM) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", - boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : "", + opt_md_clear_hvm ? " MD_CLEAR" : "", boot_cpu_has(X86_FEATURE_IBPB_ENTRY_HVM) ? " IBPB-entry" : ""); #endif @@ -525,13 +524,12 @@ static void __init print_details(enum in printk(" Support for PV VMs:%s%s%s%s%s%s\n", (boot_cpu_has(X86_FEATURE_SC_MSR_PV) || boot_cpu_has(X86_FEATURE_SC_RSB_PV) || - boot_cpu_has(X86_FEATURE_MD_CLEAR) || boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) || - opt_eager_fpu) ? "" : " None", + opt_eager_fpu || opt_md_clear_pv) ? "" : " None", boot_cpu_has(X86_FEATURE_SC_MSR_PV) ? " MSR_SPEC_CTRL" : "", boot_cpu_has(X86_FEATURE_SC_RSB_PV) ? " RSB" : "", opt_eager_fpu ? " EAGER_FPU" : "", - boot_cpu_has(X86_FEATURE_MD_CLEAR) ? " MD_CLEAR" : "", + opt_md_clear_pv ? " MD_CLEAR" : "", boot_cpu_has(X86_FEATURE_IBPB_ENTRY_PV) ? " IBPB-entry" : ""); printk(" XPTI (64-bit PV only): Dom0 %s, DomU %s (with%s PCID)\n", From xen-devel-bounces@lists.xenproject.org Wed Jul 13 07:59:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 07:59:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366265.596979 (Exim 4.92) (envelope-from ) id 1oBXH9-0000ia-8M; Wed, 13 Jul 2022 07:59:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366265.596979; Wed, 13 Jul 2022 07:59:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXH9-0000iT-5W; Wed, 13 Jul 2022 07:59:15 +0000 Received: by outflank-mailman (input) for mailman id 366265; Wed, 13 Jul 2022 07:59:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXH7-0000iN-QF for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 07:59:13 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2070.outbound.protection.outlook.com [40.107.21.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae9f846d-0281-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 09:59:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3660.eurprd04.prod.outlook.com (2603:10a6:8:c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 07:59:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 07:59:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae9f846d-0281-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iTBGE353DxjsJgC4ruYjqFdX9tzWrDCVhRDA0Ul5Eua1Xo5tD8rqcoLEMuFU6SsJyoDjop5xbPIp/vVcVt0+WgBvKYGPQwqKM0/gurW1Sn7qhLQKLXJq6PexbMa2c2F9H3CQ0Xo7+E8XMo2waxCfRgCeSi7tgN4xC+aevCusJWUWpEiIlboPp01iWQz5Iw3DArAz7wsFYLnoYfxGy+7K1kT+aJtYRJfTsbPetFUtSHc2e8ZNbPLo7i/LTjex1cTUV4rHc5PaM9kOg1KjDkuZpsmn2IKpm3HhOG+90yZA3oQnn0LFRkOAKHV67b8N5jypZdl6FBtvoyLlUN1nceHcYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yLRAfDkq2S4VKeFcHHn+x8ndfKpQQsndJLbLjJfq3sI=; b=WGFd+QhYOSvcTjFs8LxPtsXg+aNkWMj/59obr7SfV2tOjgqGP32OjROaln48ldSLmNvd2uxGLrplLQjC9ZpGsKZ18/RhKaxoZL6KGPQUkhlxfZcECaywXQ2VDAYBiUhnzls+xTGdk3vWB728aVRuihFjxclVj0F1YY5ZA6234l/f9tdu0eR31k2iA3QTNV/dvSO7unGb3xeksoBC7IATtUgjeZz5S1nd2HbdTEznOMZnrNqoK1Lei74tVB5m4FfwsYEBnGhu2xh0jgXADQJwhALyH+9FqL2+snFqNjS8s/o9h2kDjDk7+ajnVcEf4HShY262+8cQweMsgkZINZT1yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yLRAfDkq2S4VKeFcHHn+x8ndfKpQQsndJLbLjJfq3sI=; b=eKqDUiBI0G0HRyPZV30fevHT0Jke7ZPmNmVLQwUPfeydBtiyQgoS3o/KjCZWxv2uUkKb7pU+zJQBs1KBElwRfsHpGm7aIxOx8A/Cpw7x3nAQwWpuI2Ep4mlyvCPFmuQolx7OgjaIXvzPCgxxippDeRYnfdou3ZoPLEdLEk0VSYjSnZdA2h8fbk+zE+IgWpDe34kYOjX4S1dELJ+y7C30WttPLH3IoObkwt/AC20p9PteYvkuWFWCK7KFKMyPiwMTnj9q80kYExlaXO60a3xXB4QQlFAGYyqaj7kx3kPloEgx8fOvCuP+cVRwjXG2a7jz44Up81yD0Nx3qAS0UcvroA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> Date: Wed, 13 Jul 2022 09:59:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220713074823.5679-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220713074823.5679-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR01CA0068.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::45) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4481ae8c-4e45-4ca1-3935-08da64a590e9 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3660:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mV/AP4gTHcsGLmFmUdoq3xK1FTtV5CmMXNksfrJ6XEiwnXsAGIC77pnr19MYw5UpHO1hbkXtrq+d+Zxn4j/yMOS474nRXr8/4Tt+u3R05pkTF5sILba1vI4PtI4zzcqtJYcUJ2nBgvye4QRLqgH6JeQxsDQabBmM/pACEs8or4ZA4M/t79uH8hHwyagKmzs4slg1idbgxSGWX2RwNtgz6DFU5H35WKJPE2El7b89pVNPOz/EWFmyLSP5GHfix3FR10e7tJFtpeCFBplVS30ozfnTe5ZVxm6hMb5mSt1yRGEMFT1v50aPgnmYHTvAdHV73IpoATGi4tGuBuc46O5AzO6ffq697l5eqWUUGLKoDdBIQEtZ3Z1BFhBkz5C7tcTpPNHZ6Sc0iaqrAUPHkRrYDmlUe2pm3zWzp8EL/ycrewijpa7YhtHmFBXy8YTyc6n/2K2bX9eNxAXj6W5ZsSqFt/cC428NdkyYO/o+e6VCay/Cri4kjzeQ8iRCRvJxjHuxu+slIgVZHI+P+FNsj+P3DgahKtTBsjKxnWgyRnm6wK7A4eOFvFKeU+aEzVguxXw2PLpORYNyo7KJCZSBVIpJCoHBiZYJYtsAQudJaOZUCsiv6kuvob/CBF4B18iPlnoODg0XtdZjvOTyH6JWBmtI9YF/vLsWiwjIbR1zeq220PjHiceTIHlHfXcamP30A3GsEcxDxcvcrtMJdcLIu4+EDrEV6lB4FwelNkjAxEfHXoUPbBdzQT8k1qPKcQpCJawTzVm+v7sojj2G1mETMdS/GvVOwV+XXZyW4jLfA4Lb5XE8NweHZcpIniNxB493rQK5wdXYEutBL4EghDE4plp2xAasryumX22mEJIXE/+LyOM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(136003)(39860400002)(396003)(376002)(8936002)(2616005)(4326008)(54906003)(38100700002)(8676002)(86362001)(5660300002)(316002)(186003)(31696002)(66556008)(6862004)(6506007)(6636002)(66946007)(6666004)(37006003)(26005)(53546011)(6512007)(41300700001)(66476007)(6486002)(31686004)(2906002)(478600001)(83380400001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N3R3d1ErRDVubWpwa1J0SWtOWGowVllwTHRvWm9hcTJ3cmQxVWVUWEZnZ09r?= =?utf-8?B?Zzl4Z3FjTTRqb1NFbVZqUHB0VTlNTXB2MWVNMTB6ZG5tS2NkQWRKUndMNEFk?= =?utf-8?B?QW9rSHZobXFuc09pS3RVM21KZFJpT3BUeFFuVEFwU0hpS1J4TkZRc1AzNmFH?= =?utf-8?B?OVdyRmJ3a1FTUklySC9Ca01TT1dZUzhpcVNuN2JGT3ZJWEtlYkp5SmpEZWJt?= =?utf-8?B?UjFqK0pnVHFnK2U3ZTlvRWRYVzVGeC9nZG13b2d3TXpGeVdLZlJTYTN3b1BK?= =?utf-8?B?VzcySkNVeVJ2blp6Tk9oRWtnZ0ZqZ0dzKzB2VGhVY2p3bWN4YVY5S1JBS0pJ?= =?utf-8?B?em5aenJUNWtPSEdhanZQQTAwRU8vcTFEMTRvMUlUSnlrOXhRMEoyWWs0L01Q?= =?utf-8?B?b3BoRmdZelVpNnAyKzE1T1BMNjRKK0dtUnNnS0FXRXNrUm42UVlYeFR6VTNm?= =?utf-8?B?RUhmOUJkcGFqakdPbVlCTHFWcGtjSVVHZkVPSWpGdWh1ZlJTWExhWkdScDdZ?= =?utf-8?B?eE1nWFo5ME1xY3lNQVJCOTJ5SEZLVEgvcWhWN2JmWklEUjdXK0M0Nkp1aHBV?= =?utf-8?B?ZnQ5RDFyRlRCNHVINmxkbHFERkFvQnVKeThwUjgzU005WGw0anh4MjhWc3N6?= =?utf-8?B?MEpQUjVqWlRVNEkzSm5SNHpaR2NJVzhLdEIvOXBWNnhIZVZLZlVHbStxdTZV?= =?utf-8?B?bXJJRWxQbTE4dU1ZNGhaOFVMOThaRGhaK2lSZjE1bmwrK0tSbWVMOGNGb3JZ?= =?utf-8?B?QnJPbFBQdkRwNklSdUxGejlaTXEzYjhrZDZuRHduMUhaRzRFS1NKUmVucnk2?= =?utf-8?B?KzQ5UW9rTGhRRWJmQlZhcWNKcGIyNnBjRTBqWGVSZFh2dUsvd2lNN25YeUhQ?= =?utf-8?B?dHVCRmlZS0ZuWmdoUHlUZGhZa0N2TFYySjBDbnpWcUdBalFSQnB6UmRCaXNk?= =?utf-8?B?WVVZYTFzZWhQYUlvemliUFkrSk5jcXE0cGRPUGp4VFQ4d0xFL1RRb29kTnM5?= =?utf-8?B?K25SWGVWQzdkMUhuQk9DNEllbFR1TXlTcWxaRnkwanJrN0g3dHVCcUFsLytV?= =?utf-8?B?ZzlISHpkSlJOeDgxbmthUjdYTE5RQytISVAxbnBWMHYxdEUzNWpQUk1hcTMr?= =?utf-8?B?Wklibm00dURkdWdST3RIVTVTRHRuYTg1cUtmL21MRTFsWlU5VHcrSXVNWEYz?= =?utf-8?B?Q2RwaWMxcEhWNXQ3MzBHTnRIeXc5UU1ycWNYL3phNWNFU09pa256UnhITGZP?= =?utf-8?B?aGw3M21neXR0K0VZUkk0L3ZDODRLVXpOblFyN3RXWWZtSEI0N3Nxc1QxdDlG?= =?utf-8?B?cjdWZ3BKY2ZIcjhnTGFRRnE2bGtHdHJOdjF0MmJmQTl2MFcyWUM5L2tKQzdm?= =?utf-8?B?Z0s1MW1EYmhsRTU5Q05jbEdsVE9iYnRYQUVDZDBxY1FwTnlvQVFzbnE3ekZQ?= =?utf-8?B?L2dkK0ROMmlSUHZYQ3hpZktqM3pMcTY0bWtqVXJhSkw2cnNQVjBqTFFIeGp4?= =?utf-8?B?K1oxMFlVcnZ3M1RIZHRFNXdrRE4ySHVFL1ZPRUVjZjBIb3k5emhlc0pRYVM3?= =?utf-8?B?WGVoSDN5TWowOEJRMzg4SjROaGNtQUR5cEtMUXgvT0tRd0hKTXFrTFpGVUFq?= =?utf-8?B?NkIya1RJWFRUL293QzlyUUxWdW1iN1Z0TUxUcDV5TnlCRUlURkhDRlh4aHJ0?= =?utf-8?B?WDJTSUgxNUQ0dFhEb1Y5V0JDZ1hhcnUzaVhzeDlxMnZEL1BVbUcxdTZnNXlO?= =?utf-8?B?cUhpNFFJUTFhRTNWTnU0cnRudFI4VEJjbm5IY0JXQTdReStveDV4elhQQVF5?= =?utf-8?B?Y2tzc2hQNFF0TUY1QjYzN2pxZndMZjBGYnluV1lIVkVmUExoRzhMczU4QUVO?= =?utf-8?B?MVI4U0pTMmxrcGFFNkR2VVRpZWwrTGZnTjNURDZuYit0eGhTd2xTUWFmSDd4?= =?utf-8?B?Mk51V3Y0TzAwa2dQRjFWQTNrb2VxOFAvdGJiL05Vak5ONkZGN2pNdGIvaFJr?= =?utf-8?B?UkIvSWNQOWN6NnNZeUM3dlc3QmMrZ3FYTk03TDgxeEpTOHg4NWs3NGNzejEz?= =?utf-8?B?Z0VzSk4vVWp3OWVHcm56YVBvR2g0Wk1reTBxanVtcXZIa1ZGL29Xcm1sK3FO?= =?utf-8?Q?NIuYEOKcAezD7jgzwYIpHlVCZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4481ae8c-4e45-4ca1-3935-08da64a590e9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 07:59:09.1181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nMybfdWFkAqn2CFUjRHyxOozhGT7HZa7uuUKQgsuFuVhHsUPfAB307wtp6oGaE08QMo5WskflLlvE8K4OGwL6w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3660 On 13.07.2022 09:48, Juergen Gross wrote: > xenvif_rx_next_skb() is expecting the rx queue not being empty, but > in case the loop in xenvif_rx_action() is doing multiple iterations, > the availability of another skb in the rx queue is not being checked. > > This can lead to crashes: > > [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 > [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.537534] PGD 0 P4D 0 > [40072.537644] Oops: 0000 [#1] SMP NOPTI > [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 > [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 > [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 > [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 > [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 > [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 > [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 > [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 > [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 > [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 > [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 > [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 > [40072.539211] Call Trace: > [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] > [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] > > Fix that by stopping the loop in case the rx queue becomes empty. > > Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Does this want a Fixes: tag and Cc: to stable@ (not the least since as per above the issue was noticed with 4.12.x)? > --- a/drivers/net/xen-netback/rx.c > +++ b/drivers/net/xen-netback/rx.c > @@ -495,6 +495,7 @@ void xenvif_rx_action(struct xenvif_queue *queue) > queue->rx_copy.completed = &completed_skbs; > > while (xenvif_rx_ring_slots_available(queue) && > + !skb_queue_empty(&queue->rx_queue) && > work_done < RX_BATCH_SIZE) { > xenvif_rx_skb(queue); > work_done++; I have to admit that I find the title a little misleading - you don't deal with the issue _in_ xenvif_rx_next_skb(); you instead avoid entering the function in such a case. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 08:03:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 08:03:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366277.596990 (Exim 4.92) (envelope-from ) id 1oBXLO-0002fx-6Q; Wed, 13 Jul 2022 08:03:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366277.596990; Wed, 13 Jul 2022 08:03:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXLO-0002fq-3H; Wed, 13 Jul 2022 08:03:38 +0000 Received: by outflank-mailman (input) for mailman id 366277; Wed, 13 Jul 2022 08:03:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXLM-0002fk-8q for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 08:03:36 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a24f5ae-0282-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 10:03:34 +0200 (CEST) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26D830BR019236; Wed, 13 Jul 2022 08:03:21 GMT Received: from eur02-am5-obe.outbound.protection.outlook.com (mail-am5eur02lp2056.outbound.protection.outlook.com [104.47.4.56]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3h9f04hftp-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 Jul 2022 08:03:21 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AS8PR03MB6744.eurprd03.prod.outlook.com (2603:10a6:20b:292::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 08:03:17 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 08:03:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a24f5ae-0282-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EjMff4rbKfF4dIIcCZVBMlsUj2th3452paZb3CHHdqfJIdnborxgWM7Z7BOzPuNZV4VudoJwqiHunEBhhAeFzoI+PawdbT/1V0eFNSx+U+GkX1JssOrwRRVA1spp8t/kI5zLnmemOp4i59j5M7Lkp8ZnxmGzM9lDo2h5mCPN9s/lpe3+8zwm3HxabdyFxUukfVQIOUKvyL4BfYvacqFcFKQTNPBVftv6YdkMbMXnZm54kEqujhC/4FiZJwrrgoi85NKngxjfzKf0jkPk/Zgn/RsX/N8DjskLFMqQwnHS4De6pMT5HRR/hfT1yLgqGVQhmIcd0CBbrvcRNbIlrXbMxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cyNgUV/5mVr39DRK6kH9RT7sXF7cYf5nsnGaiX9okSE=; b=ckPCt4NRKtK/+104rGxfW3/kYZvI4O6JGFUmRq9Ow+zkWtwChfTBujWoN3jp/5P5+m4hVdIF72/xL5Vw8p8YXGID4jmQ+MRGfHcO5Nlr7MwJExh5R05G2+JGvj6I+tWhvL2S8QEJ8P3dCi4baiT+rdPFIslSq9K6SA/gumsXCsNoIFygKpeQar2KYowBGxtgH1HmcNXnIzqJ9FRccS715FEDA+J3VxiHX4uyZkjW8G6+I79NzsNmsLhh4Hyo3ffCU7wzJTeRpdpkZV9ErC+tVvBYb0d+Hlg94IYI7J9vTTaFBTwUeD8lDHR2pkb2utXexf/48FV6Km+uQRv1RYDUSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cyNgUV/5mVr39DRK6kH9RT7sXF7cYf5nsnGaiX9okSE=; b=JZLMxypZjt9aM1pxtHQuqZtz7hhHcipebfSunM3fngKjA6BFPerzYFWwsrzWlcUOrqeb6ivqJQ6ChPKNoDlmsmgRHP7DUYdBeo4ZSDnNkQg9ybVHDgT2gN1l6xuRUcB5BcNw7r6spS3awWoRZO1WRRDRgEd/cHQxdtx1wOvOPOzdI+irdjtQwYmSSn2cMvlkXzE2NzMRGTjEgVroeRyLe5M4YFrC/P0ZdREYWmesrW79S9lx40OtjqSug7qUxk+t2W3w+S3cVZlBlfGjoXfhDvbXhauSCNq/LgB8Kw1V2iTwy5B3A3MvRNOhQ9D8N1Kj3NgAaqfAd3G6uz8GTKglAQ== From: Oleksandr Tyshchenko To: George Dunlap , Anthony Perard CC: Juergen Gross , xen-devel , Wei Liu , Nick Rosbrook , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Oleksandr Subject: Re: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYf1A6pQ9CS25xdkGDIpueSgv3zq1QiHQAgAAkCwCAAwIqgIAAEjKAgAALK4CACsnJAIABrEAAgAe2TICAE6BaAIAAhq0A Date: Wed, 13 Jul 2022 08:03:17 +0000 Message-ID: <5fa04098-a3a0-a517-ca8c-19d45ecac63e@epam.com> References: <62903b8e-6c20-600e-8283-5a3e3b853a18@gmail.com> <1655482471-16850-1-git-send-email-olekstysh@gmail.com> <9A36692A-8095-4C76-A69B-FBAB221A365C@citrix.com> <02648046-7781-61e5-de93-77342e4d6c16@gmail.com> <36d4c786-9fb7-4b30-1a4d-171f92cc84d7@gmail.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 644ccc22-4c92-48ca-4db1-08da64a624e5 x-ms-traffictypediagnostic: AS8PR03MB6744:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M8KpPjxyWt5BRmDWa7f3vUiSYRDOxgOx8ZDKbm4RE6gC1mZuLpEb53Q4PJmRZfyzibGt1tjWNgpX6V59ZLsuoX1+6k56vJFbDjvpWaJOvCGzrnxh0M19SvdyEdiL/9NrIJqwqXq9g/hri5waMC4w7mHA3XKi5S3OVM8ySTs+v3PWwaJ5Ri4hmMbLEPgRcz50TEhuFMB/+k6mDn+8uLr6szd21qky4K0CCCLjEkjCi1hfPmzg9JeniH5DbY2GBDZphbUfTKcpXWp8N7XbEr5hQwY4Z8uS1TvzVTboVOuBt0xsvGaq/XA0NdemwWRUiKGUf1PU/ONqmiLQeP2/2FY704Ipikr2nUN46dkwfHLe/T5+33kQgBPVqwSBAmUDfR7zAM4Ijx/WIk+a9g/ciMbYq++mKWYaNSlFyebFrEtsVzUvuvZDdysgCTI+zKcePajUQkTzGJCGtudAMS6dNfNLTdiOq9FEagfFiZwBv3Qp6//K6l8JfpETEXU0Cxn7SMpCd8V8bTkKudhbudyLc3bBMsR6pviQ6w8mKw9ajM4MREix5GSSJd37tKFmxxRgKKKa0tEm8VqOMg9vi9wxg3IDI6ExeLVTA3l2v7hfde0UfpTWARK/AZYSEdfQKcKlEakT3nsfenyh49XivzGylP9/02xFJ5/gy3eqe/zDkW19J2CkxRjhrm4vVMVoQ0fO4nDyHF27ICmrKpOsBjoEKrVi8ei9DYlnxYWylaS8mWSFBpkjbns3FPdxf7yv1kPVcDqGqjGqdiG0Om41W1Iva7nTR60BQJQmykF9LTkfrFA5CnewF9Mr9SWSrlvFtU7QXcLSPXLMEBQmKhv0z+BmJFMoe+8UOaVpe1mBAWYPmoezop0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(366004)(396003)(26005)(41300700001)(55236004)(53546011)(86362001)(186003)(122000001)(2616005)(6506007)(6512007)(38070700005)(38100700002)(31696002)(316002)(7416002)(83380400001)(54906003)(66946007)(8676002)(64756008)(91956017)(71200400001)(2906002)(4326008)(36756003)(66446008)(66556008)(66476007)(6486002)(110136005)(8936002)(5660300002)(76116006)(31686004)(478600001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M1QyemFaMjdxeDB6NE84Rzd2Rno1NVRZcmtSZVo3QUxzNVE1bEpNb2haY2hj?= =?utf-8?B?bi91c21wczd3MU5rUTNLdTJFWElvdmo5M1k3cEVOd0NqdU9RbktQZFFFa0hX?= =?utf-8?B?YUZIVEx1R2ZaNnBZSVc2YWNCUzhPKzlRVENjQkpFYk9SNUJCRHdkQnh1cFNX?= =?utf-8?B?bDB1MkpqN0d2elFTeExtNkNMTkE2R2p1dmM1SnBLdmN5V1pnbE8xU1BkMmNC?= =?utf-8?B?T21TZFY5blROYjdxT1NzY2I2WUk2eVZLQ1VMS3E0anVoSWk2aWh5Q2RYSGlJ?= =?utf-8?B?c0RtWmFZVTR2b3Y2UHNvNzQ1VlRiZi9YbjI4SUlLazR0a1d5M3daaFl3bG9K?= =?utf-8?B?SE82Q3k0cHB3RXpOU0YreUg0Mlk5Ly9aQ3c2TlVncDRFRnpJNXZvTmZzQ205?= =?utf-8?B?anhhNzZOQ0tPRzVtYWJETllNMDArYUNqWHVBODl4ZDZBdEpCdVNBWm9qMkJ6?= =?utf-8?B?UnFBSEl1d1B6akwxSlRZSjJVMmZqNitrcmFndnRsaEx5VG9rOHNjdEEreFBs?= =?utf-8?B?L3lURmtDSEFpNC9UQzdxQXZ2b0lXNVppS2lrcTZ3STB5QncreU96cjBOYXk5?= =?utf-8?B?MklqQU1Rb2pIUCtnTTlUbmVDUEhjOHJiclpMdXRXai83SXRTNm5JWE5uQ3ZT?= =?utf-8?B?ZThkT1hlYzBGamM0T25HWUZRbWJudFhSMi82V2lTdWZDZ3I0RjAzL1RIaDVL?= =?utf-8?B?Ny90THNhcVBpaFc2Q0NUMHZiQytocmhBWU9CNVJaYTR1aEF4c0tVQVJGL2xX?= =?utf-8?B?OG85eWlPRU9wdVdjZTBxdXYwQmlSdkxGNU1remlvQXdVc0hWLzFtdDZQN1ZH?= =?utf-8?B?dEtUeTg4NEtBMGRWRWZtYmtlQ1ptRHBkOHVJdEtVMHV6a3ZXMXVEV0RpQitG?= =?utf-8?B?ZnJqczBOTzAxdUwxN1p1TUhjdWdHN0szdmZzUGpqQk1HWFNhbXVDK1MzVG1h?= =?utf-8?B?ZHVOOXVyeFNNSEpkUU9NSGxjT29aUEdjY0d0VE51Z0hWRlNQYWFNa3Z5TVZq?= =?utf-8?B?a25meXFOd1V2TWN6RXR6ZnJVR2xZSUZpZnVyTXA1SEkrSkhOL3VWOE04NVls?= =?utf-8?B?VmRmMXhIdzZFTjRONnBaVVJNdEpGWm1EYm5YNWNkbDgvRXlncFRwcjB4TVJO?= =?utf-8?B?SkVWYUp4N2tOUWg0Ukd1aUw1bFZCUUZnTE5pTXJ3VkFvK3crajhrMXFsWFhB?= =?utf-8?B?eGFqQmpGUWFYNUNPOEpYblgrWTBYR3Y4WFIyaVF5cldmeFVRY3N6Vlo1Q1B5?= =?utf-8?B?ZTNCVVltYkZMZTIyV2dzYTh0ZDlCakN4U052MXJUWWh2UHpPYzlZQTZEMGcr?= =?utf-8?B?ZjNKeXZ0V2VIcHpQRlpJSEhHc1Q2cFJDNlRBdC9JY3BIUzJWaTFzQTVQZVBk?= =?utf-8?B?eXdYZEV4SkxuZmtDcmN1c2JlRFBIYndweHVCb0ZQaEJSWWJlZTB2RjNYV3p2?= =?utf-8?B?a2VLc0hER2UxOVMrMzB2S1loREY4Vm9neGVSRHlQRjRGRkc0MVUwM2kxbHdQ?= =?utf-8?B?N3gzcjV4UGtob2NMaE9ZanlNRlBBV2FYSUhnODc2djkyZWJ1bFJYRldVOFFm?= =?utf-8?B?MkdBTmVCcVVBVW8wQnJHbXF5V3dJNDBsUDgxdFFyYnp4RlhldHB6MEhNVlNv?= =?utf-8?B?cjRJWlcrZXVCZ25iRGdmeDZSQ3ZqOVB1OVZUVzYxZG83U1A4WnlBWE81R2Jl?= =?utf-8?B?L0xmMWJhT01nUU9mSVZoL0NHSmJiRmtteGRIdTdXbVphOHMvbFNoTU8wdUxh?= =?utf-8?B?djB4TWwwSHVqN3NhcEpDblorclBabkJ3RUxVMWdqTnhQNmVNd1BqR0RrRzc3?= =?utf-8?B?RzNoTTdmZzhsL0VnTzZTNGdVVnhsdHJFVUxubHVwdEhHejkyNVRvTjBpNTNx?= =?utf-8?B?cURlWTJDcUdWaDYvenIzb2VrVFg5SzkvbDVZOWc5YisyQWltNVoxMHU2d0Q4?= =?utf-8?B?Mm50ZENKdFMwY3J4RE1ZUWw3d0d3ZHdXb0kreXFKdjFGc01HaFpacWRTKzV1?= =?utf-8?B?U0hmc1JYNGV2MWNqbnlWNGo5Wk9ndU1aQ0x1ZVBlRGdWM2hFSGl2ZDBHUDlL?= =?utf-8?B?TE94Zmtxd3dLdTFhMGZqWXg4ZWxjbVBYU280cmVEMzdBVVRYUHRYZGc5VVhx?= =?utf-8?B?RDdYd1hwM01wMzJlb0VweUdRTXlBTVNFZ3c0dTFVS3VBQ1Z5b2luTlNXTnRj?= =?utf-8?Q?FpsozvytEhHAtumIcjpTTVI=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 644ccc22-4c92-48ca-4db1-08da64a624e5 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 08:03:17.2233 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IR2rfwDGp65Rg74tyBy3sUU3UKI/ESE70ZtUQ/AMLDd1BoCCn4DHZkKuRkmKn4IotOTz+k3FNiIEmHyF228chGtayENSYFdX1ZUd9zFgyog= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB6744 X-Proofpoint-GUID: xkvqQUUi1xzRXZa_VPGqAvOCPodiuiBS X-Proofpoint-ORIG-GUID: xkvqQUUi1xzRXZa_VPGqAvOCPodiuiBS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-12_14,2022-07-13_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 clxscore=1011 priorityscore=1501 phishscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207130034 DQpPbiAxMy4wNy4yMiAwMzowMSwgR2VvcmdlIER1bmxhcCB3cm90ZToNCg0KSGVsbG8gR2Vvcmdl LCBBbnRob255DQoNCj4NCj4NCj4+IE9uIDMwIEp1biAyMDIyLCBhdCAyMjoxOCwgT2xla3NhbmRy IDxvbGVrc3R5c2hAZ21haWwuY29tPiB3cm90ZToNCj4+DQo+Pg0KPj4gRGVhciBhbGwuDQo+Pg0K Pj4NCj4+IE9uIDI1LjA2LjIyIDE3OjMyLCBPbGVrc2FuZHIgd3JvdGU6DQo+Pj4NCj4+PiBPbiAy NC4wNi4yMiAxNTo1OSwgR2VvcmdlIER1bmxhcCB3cm90ZToNCj4+Pg0KPj4+IEhlbGxvIEdlb3Jn ZQ0KPj4+DQo+Pj4+DQo+Pj4+PiBPbiAxNyBKdW4gMjAyMiwgYXQgMTc6MTQsIE9sZWtzYW5kciBU eXNoY2hlbmtvIA0KPj4+Pj4gPG9sZWtzdHlzaEBnbWFpbC5jb20+IHdyb3RlOg0KPj4+Pj4NCj4+ Pj4+IEZyb206IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFt LmNvbT4NCj4+Pj4+DQo+Pj4+PiBUaGlzIHBhdGNoIGFkZHMgYmFzaWMgc3VwcG9ydCBmb3IgY29u ZmlndXJpbmcgYW5kIGFzc2lzdGluZyANCj4+Pj4+IHZpcnRpby1tbWlvDQo+Pj4+PiBiYXNlZCB2 aXJ0aW8tZGlzayBiYWNrZW5kIChlbXVsYXRvcikgd2hpY2ggaXMgaW50ZW5kZWQgdG8gcnVuIG91 dCBvZg0KPj4+Pj4gUWVtdSBhbmQgY291bGQgYmUgcnVuIGluIGFueSBkb21haW4uDQo+Pj4+PiBB bHRob3VnaCB0aGUgVmlydGlvIGJsb2NrIGRldmljZSBpcyBxdWl0ZSBkaWZmZXJlbnQgZnJvbSB0 cmFkaXRpb25hbA0KPj4+Pj4gWGVuIFBWIGJsb2NrIGRldmljZSAodmJkKSBmcm9tIHRoZSB0b29s c3RhY2sncyBwb2ludCBvZiB2aWV3Og0KPj4+Pj4gLSBhcyB0aGUgZnJvbnRlbmQgaXMgdmlydGlv LWJsayB3aGljaCBpcyBub3QgYSBYZW5idXMgZHJpdmVyLCBub3RoaW5nDQo+Pj4+PiB3cml0dGVu IHRvIFhlbnN0b3JlIGFyZSBmZXRjaGVkIGJ5IHRoZSBmcm9udGVuZCBjdXJyZW50bHkgKCJ2ZGV2 Ig0KPj4+Pj4gaXMgbm90IHBhc3NlZCB0byB0aGUgZnJvbnRlbmQpLiBCdXQgdGhpcyBtaWdodCBu ZWVkIHRvIGJlIHJldmlzZWQNCj4+Pj4+IGluIGZ1dHVyZSwgc28gZnJvbnRlbmQgZGF0YSBtaWdo dCBiZSB3cml0dGVuIHRvIFhlbnN0b3JlIGluIG9yZGVyIHRvDQo+Pj4+PiBzdXBwb3J0IGhvdHBs dWdnaW5nIHZpcnRpbyBkZXZpY2VzIG9yIHBhc3NpbmcgdGhlIGJhY2tlbmQgZG9tYWluIGlkDQo+ Pj4+PiBvbiBhcmNoIHdoZXJlIHRoZSBkZXZpY2UtdHJlZSBpcyBub3QgYXZhaWxhYmxlLg0KPj4+ Pj4gLSB0aGUgcmluZy1yZWYvZXZlbnQtY2hhbm5lbCBhcmUgbm90IHVzZWQgZm9yIHRoZSBiYWNr ZW5kPC0+ZnJvbnRlbmQNCj4+Pj4+IGNvbW11bmljYXRpb24sIHRoZSBwcm9wb3NlZCBJUEMgZm9y IFZpcnRpbyBpcyBJT1JFUS9ETQ0KPj4+Pj4gaXQgaXMgc3RpbGwgYSAiYmxvY2sgZGV2aWNlIiBh bmQgb3VnaHQgdG8gYmUgaW50ZWdyYXRlZCBpbiBleGlzdGluZw0KPj4+Pj4gImRpc2siIGhhbmRs aW5nLiBTbywgcmUtdXNlIChhbmQgYWRhcHQpICJkaXNrIiBwYXJzaW5nL2NvbmZpZ3VyYXRpb24N Cj4+Pj4+IGxvZ2ljIHRvIGRlYWwgd2l0aCBWaXJ0aW8gZGV2aWNlcyBhcyB3ZWxsLg0KPj4+Pj4N Cj4+Pj4+IEZvciB0aGUgaW1tZWRpYXRlIHB1cnBvc2UgYW5kIGFuIGFiaWxpdHkgdG8gZXh0ZW5k IHRoYXQgc3VwcG9ydCBmb3INCj4+Pj4+IG90aGVyIHVzZS1jYXNlcyBpbiBmdXR1cmUgKFFlbXUs IHZpcnRpby1wY2ksIGV0YykgcGVyZm9ybSB0aGUgDQo+Pj4+PiBmb2xsb3dpbmcNCj4+Pj4+IGFj dGlvbnM6DQo+Pj4+PiAtIEFkZCBuZXcgZGlzayBiYWNrZW5kIHR5cGUgKExJQlhMX0RJU0tfQkFD S0VORF9PVEhFUikgYW5kIHJlZmxlY3QNCj4+Pj4+IHRoYXQgaW4gdGhlIGNvbmZpZ3VyYXRpb24N Cj4+Pj4+IC0gSW50cm9kdWNlIG5ldyBkaXNrICJzcGVjaWZpY2F0aW9uIiBhbmQgInRyYW5zcG9y dCIgZmllbGRzIHRvIHN0cnVjdA0KPj4+Pj4gbGlieGxfZGV2aWNlX2Rpc2suIEJvdGggYXJlIHdy aXR0ZW4gdG8gdGhlIFhlbnN0b3JlLiBUaGUgdHJhbnNwb3J0DQo+Pj4+PiBmaWVsZCBpcyBvbmx5 IHVzZWQgZm9yIHRoZSBzcGVjaWZpY2F0aW9uICJ2aXJ0aW8iIGFuZCBpdCBhc3N1bWVzDQo+Pj4+ PiBvbmx5ICJtbWlvIiB2YWx1ZSBmb3Igbm93Lg0KPj4+Pj4gLSBJbnRyb2R1Y2UgbmV3ICJzcGVj aWZpY2F0aW9uIiBvcHRpb24gd2l0aCAieGVuIiBjb21tdW5pY2F0aW9uDQo+Pj4+PiBwcm90b2Nv bCBiZWluZyBkZWZhdWx0IHZhbHVlLg0KPj4+Pj4gLSBBZGQgbmV3IGRldmljZSBraW5kIChMSUJY TF9fREVWSUNFX0tJTkRfVklSVElPX0RJU0spIGFzIGN1cnJlbnQNCj4+Pj4+IG9uZSAoTElCWExf X0RFVklDRV9LSU5EX1ZCRCkgZG9lc24ndCBmaXQgaW50byBWaXJ0aW8gZGlzayBtb2RlbA0KPj4+ Pj4NCj4+Pj4+IEFuIGV4YW1wbGUgb2YgZG9tYWluIGNvbmZpZ3VyYXRpb24gZm9yIFZpcnRpbyBk aXNrOg0KPj4+Pj4gZGlzayA9IFsgJ3BoeTovZGV2L21tY2JsazBwMywgeHZkYTEsIGJhY2tlbmR0 eXBlPW90aGVyLCANCj4+Pj4+IHNwZWNpZmljYXRpb249dmlydGlvJ10NCj4+Pj4+DQo+Pj4+PiBO b3RoaW5nIGhhcyBjaGFuZ2VkIGZvciBkZWZhdWx0IFhlbiBkaXNrIGNvbmZpZ3VyYXRpb24uDQo+ Pj4+Pg0KPj4+Pj4gUGxlYXNlIG5vdGUsIHRoaXMgcGF0Y2ggaXMgbm90IGVub3VnaCBmb3Igdmly dGlvLWRpc2sgdG8gd29yaw0KPj4+Pj4gb24gWGVuIChBcm0pLCBhcyBmb3IgZXZlcnkgVmlydGlv IGRldmljZSAoaW5jbHVkaW5nIGRpc2spIHdlIG5lZWQNCj4+Pj4+IHRvIGFsbG9jYXRlIFZpcnRp byBNTUlPIHBhcmFtcyAoSVJRIGFuZCBtZW1vcnkgcmVnaW9uKSBhbmQgcGFzcw0KPj4+Pj4gdGhl bSB0byB0aGUgYmFja2VuZCwgYWxzbyB1cGRhdGUgR3Vlc3QgZGV2aWNlLXRyZWUuIFRoZSBzdWJz ZXF1ZW50DQo+Pj4+PiBwYXRjaCB3aWxsIGFkZCB0aGVzZSBtaXNzaW5nIGJpdHMuIEZvciB0aGUg Y3VycmVudCBwYXRjaCwNCj4+Pj4+IHRoZSBkZWZhdWx0ICJpcnEiIGFuZCAiYmFzZSIgYXJlIGp1 c3Qgd3JpdHRlbiB0byB0aGUgWGVuc3RvcmUuDQo+Pj4+PiBUaGlzIGlzIG5vdCBhbiBpZGVhbCBz cGxpdHRpbmcsIGJ1dCB0aGlzIHdheSB3ZSBhdm9pZCBicmVha2luZw0KPj4+Pj4gdGhlIGJpc2Vj dGFiaWxpdHkuDQo+Pj4+Pg0KPj4+Pj4gU2lnbmVkLW9mZi1ieTogT2xla3NhbmRyIFR5c2hjaGVu a28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4+PiBPSywgSSBhbSAqcmVhbGx5 KiBzb3JyeSBmb3IgY29taW5nIGluIGhlcmUgYXQgdGhlIGxhc3QgbWludXRlIGFuZCANCj4+Pj4g cXVpYmJsaW5nIGFib3V0IHRoaW5ncy4NCj4+Pg0KPj4+DQo+Pj4gbm8gcHJvYmxlbQ0KPj4+DQo+ Pj4NCj4+Pj4gQnV0IHRoaXMgaW50cm9kdWNlcyBhIHB1YmxpYyBpbnRlcmZhY2Ugd2hpY2ggbG9v a3MgcmVhbGx5IHdyb25nIHRvIA0KPj4+PiBtZS7CoCBJ4oCZdmUgcmVwbGllZCB0byB0aGUgbWFp bCBmcm9tIERlY2VtYmVyIHdoZXJlIEp1ZXJnZW4gcHJvcG9zZWQgDQo+Pj4+IHRoZSDigJxPdGhl cuKAnSBwcm90b2NvbC4NCj4+Pj4NCj4+Pj4gSG9wZWZ1bGx5IHRoaXMgd2lsbCBiZSBhIHNpbXBs ZSBtYXR0ZXIgb2YgZmluZGluZyBhIGJldHRlciBuYW1lIA0KPj4+PiB0aGFuIOKAnG90aGVy4oCd LiAoT3IgeW91IGd1eXMgY29udmluY2luZyBtZSB0aGF0IOKAnG90aGVy4oCdIGlzIHJlYWxseSB0 aGUgDQo+Pj4+IGJlc3QgbmFtZSBmb3IgdGhpcyB2YWx1ZTsgb3IgZXZlbiBBbnRob255IGFzc2Vy dGluZyBoaXMgcmlnaHQgYXMgYSANCj4+Pj4gbWFpbnRhaW5lciB0byBvdmVycnVsZSBteSBvYmpl Y3Rpb24gaWYgaGUgdGhpbmtzIEnigJltIG91dCBvZiBsaW5lLikNCj4+Pg0KPj4+DQo+Pj4gSSBz YXcgeW91ciByZXBseSB0byBWNiBhbmQgSnVlcmdlbidzIGFuc3dlci4gSSBzaGFyZSBKdWVyZ2Vu J3MgDQo+Pj4gb3BpbmlvbiBhcyB3ZWxsIGFzIEkgdW5kZXJzdGFuZCB5b3VyIGNvbmNlcm4uIEkg dGhpbmssIHRoaXMgaXMgDQo+Pj4gZXhhY3RseSB0aGUgc2l0dWF0aW9uIHdoZW4gZmluZGluZyBh IHBlcmZlY3QgbmFtZSAob2J2aW91cywgc2hvcnQsIA0KPj4+IGV0YykgZm9yIHRoZSBiYWNrZW5k dHlwZSAoaW4gb3VyIHBhcnRpY3VsYXIgY2FzZSkgaXMgcmVhbGx5IGRpZmZpY3VsdC4NCj4+Pg0K Pj4+IFBlcnNvbmFsbHkgSSB0ZW5kIHRvIGxlYXZlICJvdGhlciIsIGJlY2F1c2UgdGhlcmUgaXMg bm8gYmV0dGVyIA0KPj4+IGFsdGVybmF0aXZlIGZyb20gbXkgUG9WLiBBbHNvIEkgbWlnaHQgYmUg Y29tcGxldGVseSB3cm9uZyBoZXJlLCBidXQgDQo+Pj4gSSBkb24ndCB0aGluayB3ZSB3aWxsIGhh dmUgdG8gZXh0ZW5kIHRoZSAiYmFja2VuZHR5cGUiIGZvciANCj4+PiBzdXBwb3J0aW5nIG90aGVy IHBvc3NpYmxlIHZpcnRpbyBiYWNrZW5kIGltcGxlbWVudGF0aW9ucyBpbiB0aGUgDQo+Pj4gZm9y ZXNlZWFibGUgZnV0dXJlOg0KPj4+DQo+Pj4gLSB3aGVuIFFlbXUgZ2FpbnMgdGhlIHJlcXVpcmVk IHN1cHBvcnQgd2Ugd2lsbCBjaG9vc2UgcWRpc2s6IA0KPj4+IGJhY2tlbmR0eXBlIHFkaXNrIHNw ZWNpZmljYXRpb24gdmlydGlvDQo+Pj4gLSBmb3IgdGhlIHBvc3NpYmxlIHZpcnRpbyBhbHRlcm5h dGl2ZSBvZiB0aGUgYmxrYmFjayB3ZSB3aWxsIGNob29zZSANCj4+PiBwaHk6IGJhY2tlbmR0eXBl IHBoeSBzcGVjaWZpY2F0aW9uIHZpcnRpbw0KPj4+DQo+Pj4gSWYgdGhlcmUgd2lsbCBiZSBhIG5l ZWQgdG8ga2VlcCB2YXJpb3VzIGltcGxlbWVudGF0aW9uLCB3ZSB3aWxsIGJlIA0KPj4+IGFibGUg dG8gZGVzY3JpYmUgdGhhdCBieSB1c2luZyAidHJhbnNwb3J0IiAobW1pbywgcGNpLCB4ZW5idXMs IGFyZ28sIA0KPj4+IHdoYXRldmVyKS4NCj4+PiBBY3R1YWxseSB0aGlzIGlzIHdoeSB3ZSBhbHNv IGludHJvZHVjZWQgInNwZWNpZmljYXRpb24iIGFuZCAidHJhbnNwb3J0Ii4NCj4+Pg0KPj4+IElJ UkMsIHRoZXJlIHdlcmUgb3RoZXIgKHN1Z2dlc3RlZD8pIG5hbWVzIGV4Y2VwdCAib3RoZXIiIHdo aWNoIGFyZSANCj4+PiAiZXh0ZXJuYWwiIGFuZCAiZGFlbW9uIi4gSWYgeW91IHRoaW5rIHRoYXQg b25lIG9mIHRoZW0gaXMgYmV0dGVyIA0KPj4+IHRoYW4gIm90aGVyIiwgSSB3aWxsIGhhcHB5IHRv IHVzZSBpdC4NCj4+DQo+Pg0KPj4gQ291bGQgd2UgcGxlYXNlIG1ha2UgYSBkZWNpc2lvbiBvbiB0 aGlzPw0KPj4NCj4+IElmICJvdGhlciIgaXMgbm90IHVuYW1iaWd1b3VzLCB0aGVuIG1heWJlIHdl IGNvdWxkIGNob29zZSAiZGFlbW9uIiB0byANCj4+IGRlc2NyaWJlIGFyYml0cmFyeSB1c2VyLWxl dmVsIGJhY2tlbmRzLCBhbnkgdGhvdWdodD8NCj4NCj4gVW5mb3J0dW5hdGVseSBJIGRpZG7igJl0 IGhhdmUgdGltZSB0byBkaWcgaW50byB0aGlzOyBJ4oCZbSBqdXN0IGdvaW5nIHRvIA0KPiBoYXZl IHRvIHdpdGhkcmF3IG15IG9iamVjdGlvbiwgYW5kIGxldCB5b3UgJiBKdWVyZ2VuIGRlY2lkZSB3 aGF0IHRvIA0KPiBjYWxsIGl0Lg0KDQpHZW9yZ2UsIHRoYW5rcyBmb3IgbGV0dGluZyBtZSBrbm93 LiBKdWVyZ2VuIHByb3Bvc2VkIHRvIHVzZSAic3RhbmRhbG9uZSIgDQpmb3IgdGhlIG5ldyBiYWNr ZW5kdHlwZSBuYW1lIHdoaWNoIGlzIGZhciBtb3JlIHNwZWNpZmljLiBJIGFncmVlIHdpdGggdGhh dC4NCg0KDQpBbnRob255LCB3b3VsZCB5b3UgYmUgaGFwcHkgd2l0aCB0aGF0IHJlbmFtaW5nPw0K DQoNCg0KPg0KPiBSZSB0aGUgZ29sYW5nIGNoYW5nZXM6DQo+DQo+IEFja2VkLWJ5OiBHZW9yZ2Ug RHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+DQoNCg0KVGhhbmtzLg0KDQoNCi0tIA0K UmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 13 08:13:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 08:13:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366284.597000 (Exim 4.92) (envelope-from ) id 1oBXUN-0004MJ-4b; Wed, 13 Jul 2022 08:12:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366284.597000; Wed, 13 Jul 2022 08:12:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXUN-0004MC-21; Wed, 13 Jul 2022 08:12:55 +0000 Received: by outflank-mailman (input) for mailman id 366284; Wed, 13 Jul 2022 08:12:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXUM-0004M6-Ib for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 08:12:54 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 97a52da1-0283-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 10:12:52 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id 9-20020a1c0209000000b003a2dfdebe47so742493wmc.3 for ; Wed, 13 Jul 2022 01:12:52 -0700 (PDT) Received: from [10.139.203.5] ([54.239.6.190]) by smtp.gmail.com with ESMTPSA id h4-20020a1c2104000000b00397402ae674sm1414763wmh.11.2022.07.13.01.12.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 01:12:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97a52da1-0283-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0uRDex1sPZB8+kY6pRwjfFra2BxS6+wEYBs3OQaRvL4=; b=czMyWCpWUG776U3vRaa14UMGbkTFNvyvooqLdkooVASOb+MgSYYymDK+xBJAr1+Kfk xKAE/nB6N3vhxDMiOOVIzVNBchQ1IMj6ZVqGzYxjgdHvxuhzZFxdfThrGD55Ha0xag5n xraVDVz10BAO8ieSsWuBun9KxgsaU3Nclb9mh/erBve+sCIF7oC8UXWO64NkMkNlviTt A586Ch9/rYorCbYsqZHCnXi9WzCCc2cECYaHLoyf6dNA5GHJtVhPkmcIFwO0ygEm60Ni NseVUc9g6bW49kel1rQibobW38H9GudctoaUDFzGkrAs3mDQWobIW6dwA2R3nC9e2FfP 8uTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=0uRDex1sPZB8+kY6pRwjfFra2BxS6+wEYBs3OQaRvL4=; b=QgMY32vxd+AI21TqZANUpCBZYtuUdwppobeNkq6pbQ+aRsXZMSyOxbhl3RUpBUu63W m9LXI1+TGh/RBtV4RR2zH4bc5vc2TAf+J6tBjWFncJF901NZf7Jxep0uA+QzVDOahv0k +8t0GulCpCTKIrizk9SjYkwZMs+uDVcO1qulCfKTzIDoh4sMi1Ax7XvGzrGBzJP9pkJh aAFoDFvJMLxodt03pxleu7uMSvDbOTU9VPRuPIg093CDviJ3XkqMO57I66D+OL0/Zzw3 4O/ZTm+4bFOBmZvGpUSqWyulKDE341DMGdehQvNHb6Nlt89IhfWFKvk4vw4kcr8I4uNn 4Jzg== X-Gm-Message-State: AJIora/mQbK9+OSbWN2CR13VT1YopXI9lTZUhS6Ou7vEs2y8PMfJM5rw MLByup4LhARVoCCZUerIxHM= X-Google-Smtp-Source: AGRyM1t2/g2aQx4hW4BD8FkYMRkeZOzwdnkao9wmFSElnULULsGShBJ93EfxE/7iVcV/SZaP2yWAhw== X-Received: by 2002:a05:600c:42d3:b0:3a2:e7b8:8430 with SMTP id j19-20020a05600c42d300b003a2e7b88430mr2281220wme.42.1657699972267; Wed, 13 Jul 2022 01:12:52 -0700 (PDT) Message-ID: <016536af-2ab8-b557-abe6-1c8f2b6d7e91@gmail.com> Date: Wed, 13 Jul 2022 10:12:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20220713074823.5679-1-jgross@suse.com> From: "Durrant, Paul" In-Reply-To: <20220713074823.5679-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/07/2022 09:48, Juergen Gross wrote: > xenvif_rx_next_skb() is expecting the rx queue not being empty, but > in case the loop in xenvif_rx_action() is doing multiple iterations, > the availability of another skb in the rx queue is not being checked. > > This can lead to crashes: > > [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 > [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.537534] PGD 0 P4D 0 > [40072.537644] Oops: 0000 [#1] SMP NOPTI > [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 > [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 > [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 > [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 > [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 > [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 > [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 > [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 > [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 > [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 > [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 > [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 > [40072.539211] Call Trace: > [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] > [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] > > Fix that by stopping the loop in case the rx queue becomes empty. > > Signed-off-by: Juergen Gross Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Wed Jul 13 08:23:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 08:23:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366290.597012 (Exim 4.92) (envelope-from ) id 1oBXeB-0005zf-2a; Wed, 13 Jul 2022 08:23:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366290.597012; Wed, 13 Jul 2022 08:23:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXeA-0005zY-W1; Wed, 13 Jul 2022 08:23:02 +0000 Received: by outflank-mailman (input) for mailman id 366290; Wed, 13 Jul 2022 08:23:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBXe9-0005zS-Om for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 08:23:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 00ece72c-0285-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 10:22:59 +0200 (CEST) Received: from DB6PR07CA0178.eurprd07.prod.outlook.com (2603:10a6:6:43::32) by HE1PR08MB2681.eurprd08.prod.outlook.com (2603:10a6:7:30::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Wed, 13 Jul 2022 08:22:56 +0000 Received: from DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::ff) by DB6PR07CA0178.outlook.office365.com (2603:10a6:6:43::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.5 via Frontend Transport; Wed, 13 Jul 2022 08:22:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT013.mail.protection.outlook.com (100.127.142.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 08:22:56 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Wed, 13 Jul 2022 08:22:56 +0000 Received: from 70c09e9cdd40.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DDACC8E3-84D9-4CCD-B250-52EDF7A08042.1; Wed, 13 Jul 2022 08:22:50 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70c09e9cdd40.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 08:22:50 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB7PR08MB3578.eurprd08.prod.outlook.com (2603:10a6:10:50::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Wed, 13 Jul 2022 08:22:48 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 08:22:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 00ece72c-0285-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=i5JhTUkb0UQaAhX5dAOKJ0OEiUP49QuDt3Dykyo5ftSAoLQJLW2Fd3lv3CpBJ3/HxXg6Uh2a9KsCFNoHxSjRWntkiZs41eOuNTtQMEjBEgyaKPX7syMOeWlGKvgL+xeon9a6cnImAWJ+KVDLpx5bhInJeTTUZyUBvWtTbGDP9d5hqRsEnSbteR8dludhPjNx0qlZ14bPQKhcwBy7jglXNKZr+tD9D+tjtRDGVfePI6P9njQZ4iJb2gVdJ4svB4SrRPnedOxp8MitfCcX9fd8EInCukRm0Kr6zVHf791jocb/atWdyd2MDNWmikyI2gSHwu+fV3uK34pHofopYNi81g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ay3hcF9CeM9SMZQuVZtsHZTUxUiuPcnoG/aF8us2nIU=; b=PX5Pzs3EpghNEmrpCO9sZ3EVtx/XsgXyaTcPDFQ8P0s6QWni/r/QQAvgWaa/a1R/tT7A+OON7uMl8n8LUFdo49kCpgAEtLpFAv7e8OuejwfA8oXsGtGH6Pb2xP0B/JAKz5Y0Yn/obQGQWkfEF+0Z3F6S/6t0MuSvxQ/gzVOPDmghALcKZs8RLM0QgyBdNth9C6XY4bsyiPYQ134tN0iKB0+OlQLIXa09ODm80/Ad8Ly2eptUrL3Mk3+MQ5RJAa6jB2QdsImpCg8RpAdQFpC1rXOkR7R0aJUN6OsbRedbtju/+dJQa/hh97uZgBlnH8zlfplvv45T1wcSwSeZnu2qSg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ay3hcF9CeM9SMZQuVZtsHZTUxUiuPcnoG/aF8us2nIU=; b=z7nHkiJa3n3xBM1S3YATB18/phhINpEEAS4XTQ+nIsCxnwC3LFfD/zVFvjZ0lF2co09MsZYJcqiGqMXtquPAaTaNReGdLB6B6g5WlB1+KBcaJZvODhiOzKfplmLJFtp2dkHm8JI8MF2mZVwb+r9FKoZqI+V6suTqp1Ra7DtMHd0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bEoRNdqFoEgq2Af614FDJPJQVw78tT3r8ZV+Cui8RB9sOikMVIEtcf/MokkTqCD1r/QenMO/tjz3HzDcCFDzz0rKM8ZGcOr8bd/Nuv+VMNPDqKsJI6VhlgwrfqU5XoYIEu7r6aF227XxPi07eu3ABdAazWgP2AapPmLU2NQ5B9WGNTHGXiSoAHrs3Hkn+XbwU9B+TUXFAooUOo9WT6bH2plgy6DJKhkA4J6irdFGEQ15pesfv9mZcdJ1eS6XmalGEHyhzrTOO0fc6I6+vrWxhLW9L/cOYLrVYv7cn7ohGHYRwMpfWyboVP6Q60Bng7BC+K8NPi3lInH2HZHsGmSx9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ay3hcF9CeM9SMZQuVZtsHZTUxUiuPcnoG/aF8us2nIU=; b=QI5duJDvcL/Hiudz/R3QWcLx5GdxJCbkIb6+HetxnC651yYzKFA37KYlP5Wd1vBzG3Tc6iU4d3FKfqi0uTJAkmklOSctZFPqUQA4w42LRPKQ+HXUN9FlsBthiLoV3qnO59zL3ghzjeJo4ZoAA2GXxWUZUI+GErEIQOb4sgKTb6owZDCq573VSqEE2o2BddGXuogosMtVNTSZ+9gOgZhcgkglGOrMucgSRZVjgbErFLbokHxD6XM1WFD3ob0+Q8LpzwwjvJgB7fSkMOj8fQAFxkzSHarClhqjUgd9GHY6yUkT/du9WINIqOD1hQZlsbm+tmZbxLEgBOAowqopCxXSRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ay3hcF9CeM9SMZQuVZtsHZTUxUiuPcnoG/aF8us2nIU=; b=z7nHkiJa3n3xBM1S3YATB18/phhINpEEAS4XTQ+nIsCxnwC3LFfD/zVFvjZ0lF2co09MsZYJcqiGqMXtquPAaTaNReGdLB6B6g5WlB1+KBcaJZvODhiOzKfplmLJFtp2dkHm8JI8MF2mZVwb+r9FKoZqI+V6suTqp1Ra7DtMHd0= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Thread-Topic: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Thread-Index: AQHYktq36ViOQfJ5uUWUa1pA0oRKx616pmYAgAFNx1A= Date: Wed, 13 Jul 2022 08:22:47 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-2-wei.chen@arm.com> <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> In-Reply-To: <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D6B7C1440B77784AA8C1C0B3B5A74605.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 85bc4dba-e0a6-48a1-0c4f-08da64a8e3a4 x-ms-traffictypediagnostic: DB7PR08MB3578:EE_|DBAEUR03FT013:EE_|HE1PR08MB2681:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: FO6BeoP+e0KxrxNRXNl+4P9naztQXsllwdKy8uo66pcyXWDJQtqPv3hsOHjQaM71WtDKdrNaGv+njOYGObKUZdUXRyjsrJ+2HJtLIohlJk7gS+8+CctIvcCoiETwLKdtccM9c7G0XP2TmXTqnCJpnQBYjnIEAu1Nd049TDJzgEUH8/hXnx0ZYoPaN4xo0vTjoVpRaZ7OmTjKaggnh2PKwtpdG3n7IZZ6nwHHpXJWoKj+OZkJZ66j1wDguQHNgf8W7Y3BjXQfJSlzoInh4OHhLx7LaVN6OoaaQ/XipSFMZBE3x1gQaDH/fYQy/JFAU2AhgzeMG0oi6pnoShHvirv0w8VkARSs3aJpI0voxXGsI+axI3S+bHXGjAVNbWxjkAP/koeohRSXGrDSU+QSoFT1XxX7+m/QjYZVzqTN7TF1y+18VARvmbnb3HOC9KsbOBtdiDM9b7RAfOaJXiq2PNAffiZwiWFmOF9iWrk1vmHuoXF62uKN+ttlNrLs2rlC0HqZwfaURaPE7212Nn4T+MjTEo6CbNH+W+L8Ybl7/gEfZHua5iPy0JaowO8vwDKsqnzY7HDJhzNdP0jspYtCoFOfClJaKT/HYYmWOkWqf6Ei853TQjRc7/AiT77Egokiksf3BuEkq73S9BJAsjkK8BRDI7OQXCHHtyzW1+Lxm9iSV0c/A8/f+wqrVlul3cAyxO7VCISVwt55I4bACNcRXVxNnYSEZn4tZzq98TdhmCgfeLzL8i0zSRRZV/12CnKCjNb1kCCCf3slr8Pi9RiK0g8YeTbKJiW/c3W9nOd6Xv0FQarwns/dX0T4D/zumdX2XAM8 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(376002)(39860400002)(396003)(346002)(52536014)(15650500001)(55016003)(54906003)(71200400001)(53546011)(5660300002)(316002)(7696005)(6506007)(6916009)(2906002)(76116006)(38070700005)(478600001)(41300700001)(9686003)(26005)(33656002)(66946007)(122000001)(66476007)(83380400001)(64756008)(66446008)(8676002)(4326008)(38100700002)(8936002)(86362001)(66556008)(186003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3578 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b0c23160-4050-40dc-e0a2-08da64a8de93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JFdqHQXYqdr6gHvZKGM9GMuOVNGiZxa9BRRaCgztpZFmGU82hCB9+tWNtIPRNr63FkQturmhBFSAmF9TcHV1oUDZ0ihIsQDrcHpffVTWbOjw03C4nu3yXjWT8SM9BdNTzHzMotzcX2p14TNbF95AXNZOz3vjzqB8ipCy17ZBJ+xefxV0pdJcOQo5r1ZjBqhbKDtihfjIYnIXqZ/YIapqzBcszEL5ol6q1w/yiud/s7s0xOnaOMuBXobDrrln4seXCycLueRUOsPp6Pi7qPlm3kuA7cIRh+KKdile+4fNiCcnaF4m9ElH3tqlQ1frw8WgcZwm/bBq3OomrXgirSKlQWje5iiVPoFlLfn4A9AltJVyu6fd+h1rsO0yGnE1KQvmzEydDVGs4G+SLYQNeNLaxtU+2A0MKXWy6xTO90L3/xL2CXhizUhiBR1uv7nineEjIR+c95rYSwf1a3XfkDfGAHQ8ht+mHV3BbO2gHb/WYJYp0Z5beu4gKyxkwOMTMXP2Oe90JcyAqoB271j9tpjuLNH4/RPhRXQ5Uewv6niyUxauVfP8Ld2uNOy45WmrrGd8CmUDffnrzx+ISUZCytr1n4kpp8tn6L+h7YbgMgXuLM2+DiGibfmcGnEQq0u5V9BGs6wU8zXcBqNrI34w0FGPsT/iiBecrlnqYH6r5pccoTCzDGb5v7k5BDJeKrQuzVuOelf19zpPO1QnBy54mGU4cg7bte2xrRXtVmsQYiH9rF7LfsjTnP/KHz1DFoJU29rGIAoPksfhgCVX3XZRac8Lk/5H4JS9ssMAzvJ0+Zp1QunbLMGobIh2SRNxkt5iqGSA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(396003)(376002)(40470700004)(36840700001)(46966006)(36860700001)(86362001)(40460700003)(41300700001)(82310400005)(81166007)(2906002)(8936002)(52536014)(82740400003)(6862004)(15650500001)(33656002)(316002)(478600001)(356005)(5660300002)(53546011)(26005)(54906003)(47076005)(40480700001)(336012)(70586007)(186003)(8676002)(4326008)(70206006)(55016003)(83380400001)(6506007)(7696005)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 08:22:56.2652 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85bc4dba-e0a6-48a1-0c4f-08da64a8e3a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR08MB2681 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAxOTo1NA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg MS85XSB4ZW4veDg2OiBpbnRyb2R1Y2UgYSBoZWxwZXIgdG8gdXBkYXRlIG1lbW9yeQ0KPiBob3Rw bHVnIGVuZA0KPiANCj4gT24gMDguMDcuMjAyMiAxNjo1NCwgV2VpIENoZW4gd3JvdGU6DQo+ID4g eDg2IHByb3ZpZGVzIGEgbWVtX2hvdHBsdWcgdmFyaWFibGUgdG8gbWFpbnRhaW4gdGhlIG1lbW9y eSBob3RwbHVnDQo+ID4gZW5kIGFkZHJlc3MuIFdlIHdhbnQgdG8gbW92ZSBzb21lIGNvZGVzIGZy b20geDg2IHRvIGNvbW1vbiwgc28gdGhhdA0KPiA+IGl0IGNhbiBiZSByZXVzZWQgYnkgb3RoZXIg YXJjaGl0ZWN0dXJlcy4gQnV0IG5vdCBhbGwgYXJjaGl0ZWN0dXJlcw0KPiA+IGhhdmUgc3VwcG9y dGVkIG1lbW9yeSBob3RwbHVnLiBTbyBpbiB0aGlzIHBhdGNoLCB3ZSBpbnRyb2R1Y2UgdGhpcw0K PiA+IGhlbHBlciB0byByZXBsYWNlIG1lbV9ob3RwbHVnIGRpcmVjdCBhY2Nlc3MgaW4gdGhlc2Ug Y29kZXMuIFRoaXMNCj4gPiB3aWxsIGdpdmUgdGhlIGFiaWxpdHkgb2Ygc3R1YmJpbmcgdGhpcyBo ZWxwZXIgdG8gdGhvc2UgYXJjaGl0ZWN0dXJlcw0KPiA+IHdpdGhvdXQgbWVtb3J5IGhvdHBsdWcg c3VwcG9ydC4NCj4gDQo+IFdoYXQgcmVtYWlucyB1bmNsZWFyIHRvIG1lIGlzIHdoeSBBcm0gY2Fu J3Qgc2ltcGx5IGdhaW4gdGhlIG5lY2Vzc2FyeQ0KPiB2YXJpYWJsZS4gU29vbmVyIG9yIGxhdGVy IHlvdSdsbCB3YW50IHRvIHN1cHBvcnQgaG90cGx1ZyB0aGVyZSBhbnl3YXksDQoNCkkgYW0gbm90 IHN1cmUgbXkgbGltaXRlZCBtZW1vcnkgaG90cGx1ZyBrbm93bGVkZ2UgY2FuIGFuc3dlciB5b3Vy IHF1ZXN0aW9uDQpvciBub3QuIEFzIG1lbW9yeSBob3RwbHVnIGRlcGVuZHMgb24gaGFyZHdhcmUg YW5kIGZpcm13YXJlIHN1cHBvcnQuIE5vdw0KZm9yIEFybSwgd2Ugb25seSBoYXZlIEFDUEkgZmly bXdhcmUgdGhhdCBjYW4gbm90aWZ5IE9TIHRocm91Z2ggR0VEIGV2ZW50DQoobm90IHZlcnkgc3Vy ZSkuIEJ1dCBBQ1BJIGFuZCBkZXZpY2UgdHJlZSBjb3VsZG4ndCBiZSBlbmFibGVkIGF0IHRoZSBz YW1lDQp0aW1lIGZyb20gT1MgYm9vdGluZy4gSW4gZGV2aWNlIHRyZWUgYmFzZWQgTlVNQSwgd2Ug d2lsbCBlbmFibGUgZGV2aWNlDQp0cmVlLCBBQ1BJIHNlcnZpY2Ugd2lsbCBub3QgYmUgaW5pdGlh bGl6ZWQsIHRoYXQgbWVhbnMgd2UgY2FuIG5vdCBnZXQNCm5vdGlmaWNhdGlvbiBvZiBtZW1vcnkg aG90cGx1ZyBldmVudHMgZnJvbSBBQ1BJIGZpcm13YXJlLiANCg0KT2YgY291cnNlLCBhZGRpbmcg R0VEIGRldmljZSBub2RlcyB0byB0aGUgZGV2aWNlIHRyZWUsIGFuZCBnZXR0aW5nIHRoZXNlDQpl dmVudHMgdGhyb3VnaCBHRUQgaW50ZXJydXB0cyBzaG91bGQgbm90IGJlIGEgYmlnIHRlY2huaWNh bCBwcm9ibGVtLiBCdXQNCnRoZXJlIG1heSBiZSBvdGhlciByZWFzb25zLCBhbmQgbm8gb25lIGlz IHBsYW5uaW5nIHRvIGFkZCBtZW1vcnkgaG90cGx1Zw0Kc3VwcG9ydCB0byB0aGUgZGV2aWNlIHRy ZWUgKHBlcmhhcHMgbmVlZCBhbiBBQ1BJLWxpa2Ugc3BlY2lmaWNhdGlvbiBvciBhDQpmaXJtd2Fy ZSBhYnN0cmFjdGlvbiBpbnRlcmZhY2UpLiBTbyBpZiB3ZSB3YW50IHRvIGltcGxlbWVudCBYZW4g QXJtIG1lbW9yeQ0KaG90cGx1ZywgaXQgc2hvdWxkIGFsc28gc3RhcnQgZnJvbSBBQ1BJLiBTbyBj dXJyZW50bHkgZXZlbiBpZiB3ZSBnYWluIHRoZQ0KdmFyaWFibGUgaW4gQXJtLCBpdCB3aWxsIG5v dCBiZSB1c2VkLiBEZXZpY2UgdHJlZSBkb2VzIG5vdCBoYXZlIHByb3BlcnR5DQp0byBpbmRpY2F0 ZSBhIG1lbW9yeSBibG9jayBjYW4gYmUgaG90cGx1ZyBvciBub3QuDQoNCj4gSSBzdXBwb3NlLiBN ZWNoYW5pY2FsbHkgdGhlIGNoYW5nZSBpcyBmaW5lLiBBbGJlaXQgbWF5YmUgInRvcCIgaW5zdGVh ZA0KPiBvZiAiYm91bmRhcnkiLCBhbmQgbWF5YmUgYWxzbyBwYXNzICJub2RlIiBldmVuIGlmIHg4 NiBkb2Vzbid0IG5lZWQgaXQ/DQo+IA0KDQpTb3JyeSwgSSBhbSBub3QgdmVyeSBjbGVhciBhYm91 dCB0aGVzZSBjb21tZW50czoNCkl0IG1ha2VzIHNlbnNlIHRvIHVzZSBtZW1faG90cGx1Z191cGRh dGVfdG9wIGluc3RlYWQNCm9mIG1lbV9ob3RwbHVnX3VwZGF0ZV9ib3VuZGFyeS4gQnV0IGhvdyBj YW4gSSB1bmRlcnN0YW5kIHBhc3MgIm5vZGUiPw0KZGlkIHlvdSBtZWFuIG1lbV9ob3RwbHVnX3Vw ZGF0ZV90b3Aobm9kZSwgZW5kKT8gQnV0IG1lbV9ob3RwbHVnIGlzDQphIGdsb2JhbCB0b3AgZm9y IG1lbW9yeSBob3RwbHVnIHJhbmdlcy4gSSBkb24ndCB0aGluayBwYXNzICJub2RlIg0KdG8gdGhp cyBmdW5jdGlvbiBjYW4gYmUgdXNlZnVsLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IEphbg0K PiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBXZWkgQ2hlbiA8d2VpLmNoZW5AYXJtLmNvbT4NCj4gPiAt LS0NCj4gPiB2MSAtPiB2MjoNCj4gPiAxLiBSZWZpbmUgdGhlIGNvbW1pdCBtZXNzYWdlLg0KPiA+ IDIuIE1lcmdlIHYxIHBhdGNoIzksMTAgaW50byBvbmUgcGF0Y2guIEludHJvZHVjZSB0aGUgbmV3 IGZ1bmN0aW9ucw0KPiA+ICAgIGluIHRoZSBzYW1lIHBhdGNoIHRoYXQgdGhpcyBwYXRjaCB3aWxs IGJlIHVzZWQgZmlyc3QgdGltZS4NCj4gPiAzLiBGb2xkIGlmICggZW5kID4gbWVtX2hvdHBsdWcg KSB0byBtZW1faG90cGx1Z191cGRhdGVfYm91bmRhcnksDQo+ID4gICAgaW4gdGhpcyBjYXNlLCB3 ZSBjYW4gZHJvcCBtZW1faG90cGx1Z19ib3VuZGFyeS4NCj4gPiAtLS0NCj4gPiAgeGVuL2FyY2gv eDg2L2luY2x1ZGUvYXNtL21tLmggfCA2ICsrKysrKw0KPiA+ICB4ZW4vYXJjaC94ODYvc3JhdC5j ICAgICAgICAgICB8IDMgKy0tDQo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9pbmNs dWRlL2FzbS9tbS5oDQo+IGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL21tLmgNCj4gPiBpbmRl eCAwN2I1OWM5ODJiLi5iM2RmYmRiNTJiIDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL3g4Ni9p bmNsdWRlL2FzbS9tbS5oDQo+ID4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL21tLmgN Cj4gPiBAQCAtNDc2LDYgKzQ3NiwxMiBAQCBzdGF0aWMgaW5saW5lIGludCBnZXRfcGFnZV9hbmRf dHlwZShzdHJ1Y3QNCj4gcGFnZV9pbmZvICpwYWdlLA0KPiA+DQo+ID4gIGV4dGVybiBwYWRkcl90 IG1lbV9ob3RwbHVnOw0KPiA+DQo+ID4gK3N0YXRpYyBpbmxpbmUgdm9pZCBtZW1faG90cGx1Z191 cGRhdGVfYm91bmRhcnkocGFkZHJfdCBlbmQpDQo+ID4gK3sNCj4gPiArICAgIGlmICggZW5kID4g bWVtX2hvdHBsdWcgKQ0KPiA+ICsgICAgICAgIG1lbV9ob3RwbHVnID0gZW5kOw0KPiA+ICt9DQo+ ID4gKw0KPiA+DQo+IC8qKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqDQo+ICoqKioqDQo+ID4gICAqIFdpdGggc2hh ZG93IHBhZ2V0YWJsZXMsIHRoZSBkaWZmZXJlbnQga2luZHMgb2YgYWRkcmVzcyBzdGFydA0KPiA+ ICAgKiB0byBnZXQgZ2V0IGNvbmZ1c2luZy4NCj4gPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2 L3NyYXQuYyBiL3hlbi9hcmNoL3g4Ni9zcmF0LmMNCj4gPiBpbmRleCBiNjJhMTUyOTExLi5mNTM0 MzFmNWU4IDEwMDY0NA0KPiA+IC0tLSBhL3hlbi9hcmNoL3g4Ni9zcmF0LmMNCj4gPiArKysgYi94 ZW4vYXJjaC94ODYvc3JhdC5jDQo+ID4gQEAgLTQxOCw4ICs0MTgsNyBAQCBhY3BpX251bWFfbWVt b3J5X2FmZmluaXR5X2luaXQoY29uc3Qgc3RydWN0DQo+IGFjcGlfc3JhdF9tZW1fYWZmaW5pdHkg Km1hKQ0KPiA+ICAJbWVtYmxrX25vZGVpZFtudW1fbm9kZV9tZW1ibGtzXSA9IG5vZGU7DQo+ID4g IAlpZiAobWEtPmZsYWdzICYgQUNQSV9TUkFUX01FTV9IT1RfUExVR0dBQkxFKSB7DQo+ID4gIAkJ X19zZXRfYml0KG51bV9ub2RlX21lbWJsa3MsIG1lbWJsa19ob3RwbHVnKTsNCj4gPiAtCQlpZiAo ZW5kID4gbWVtX2hvdHBsdWcpDQo+ID4gLQkJCW1lbV9ob3RwbHVnID0gZW5kOw0KPiA+ICsJCW1l bV9ob3RwbHVnX3VwZGF0ZV9ib3VuZGFyeShlbmQpOw0KPiA+ICAJfQ0KPiA+ICAJbnVtX25vZGVf bWVtYmxrcysrOw0KPiA+ICB9DQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 13 08:46:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 08:46:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366297.597022 (Exim 4.92) (envelope-from ) id 1oBY0Y-0000JX-V1; Wed, 13 Jul 2022 08:46:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366297.597022; Wed, 13 Jul 2022 08:46:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBY0Y-0000JQ-Rt; Wed, 13 Jul 2022 08:46:10 +0000 Received: by outflank-mailman (input) for mailman id 366297; Wed, 13 Jul 2022 08:46:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBY0X-0000JK-Gb for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 08:46:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60071.outbound.protection.outlook.com [40.107.6.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3c5728c9-0288-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 10:46:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5169.eurprd04.prod.outlook.com (2603:10a6:208:c4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 08:46:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 08:46:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3c5728c9-0288-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PVBuePYyv8aocHnaBwGsWuGh5RrJ/ZoMf5XmHTrvLkaJ2T7JQfa2odrDQ+i+tO9+GrLS3GvcaNGfrJ6Z0bq6TnvozUHHGYfceYFyR20sgSpI01RDlBnpzDIminlT9frRK2Ju1wYIM7WfLQoDC5QeR1EkPn4BmEprLnfr2CF608Y11EwkMtgfaTpj5PNud141KV3ZfMH43eYRWgmi7dPsvSIL9xcUF23NL1BwMLddLk3OuT5JhRTqVki/P5ZspOJYMJvhkGaHO4iliWRNQVr8CAGsLaYOdlsDzCKsHKIAGE5GoUS7hIP+KcLgvLLpUMh8RmRkL1KSU2iLs8ELQfc40g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Rn3jlhiy3YGmRIPv/ywRR1F7r6dFOFb592jJ/QvfwQ=; b=CNzdvTYiESVrvy4GNJFpQV35BUK4NKTAfEqG4cY1n+lqO6u7x70Rqn43N8pXe8p+HQrL+ImgBnN7wwj874E7zAm03mVw/5MWh15+gwpKWnb9fePsE3SokDVQhCJY4TMuZAq5xcK7VNQR3Clj69fMEkU9pFOoG3qcw/Gut4bF+QlH1lctCy+0cr11scVrjm/FEy9bRjuySezkm+RnbEbnuX9NvX+TeSnmShReEyQpX8Az8uQjDn6mvLokayncdQabY7lUxIeR3kZIfcZMmvdihNSj0+NCvsbbUkMLHLKLVqxZ2bLwvCOZY4H2XIXTAX800Vb2lMekOl0N71gDgliKBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5Rn3jlhiy3YGmRIPv/ywRR1F7r6dFOFb592jJ/QvfwQ=; b=ua5Urw8/yYFZatsbZ3X62En6Eu47DZxYL7I9B5+Q+Tsafp+hmbE/C1s0ghE+k8xwzgOzQrHGuU0C/iNL9uHMet07Kd3QMRhr6pe92kvzkoqaCeFJzfAyXxC3Z+iT5xws3tUVfQd8q/jz6N9kIKkdhEYzYIyrCoDiF++R7UpytesMZ5rkcKprsVLdFk2FThy8bTT2zloyBHAhgc4YdLrCRunQVLLu53xeah2Bl4kLaHsCsEZOXRDJ8J3plZCRAJr3fHGPu04qUzb6I62+Sbpu9HP1snFV+/fJCZVd0PadZmOKv7pZzi21Q07h6ZZkcJ6y9r6mExVSl/LTCo6ITtEdwQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 10:46:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-2-wei.chen@arm.com> <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P191CA0062.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::39) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ded3ab07-8e39-4800-c2fa-08da64ac1f47 X-MS-TrafficTypeDiagnostic: AM0PR04MB5169:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tZC/m1a4ZruhIEBi06ZdwRvVhQF4fsrzrzk2E8x0N+I6Kmw7wqrsWtc0vU40KbTdVkmNH8h1PGfYzwfxWOQcS3PK9Bs8zjT8AHnGn9eJrXO+mSZlyVRw5bJWoXWMUI4KLlp+SEndMxJ6msDqOMnttGJM9ui/fOaBSuPasvRsOCX3Z+YTKFsu9RG1W1u5Jta91KXy3MF0ty7Ttb2lBBlpZxW0jL80J2O6irTwfbv1lxzXAOxW41G2fiXpYkSObrPgCQKJZNFyDyW34efO/ppcm+W0qWh0Exw/b1bSyKOWjh6keEnXt+4HBSOCkRlvGfiYPWmwxhW+2vqt0bewrFsAbonVoCo8zYA6tSv5UPXhC5WskMMETz9+dtPKd8UU17U4Hv83FcwJBelsjNChK5xLKZ6+Y8fCS8Fo7RUENNzqBCB+Eg3/4GqXXUgShOfd/zztKl+HDgXO1gwt1Pc1iBPg/F5Y6sujZJzi3BUZwgt8akm9Row9OR+MWNdueMNm4XXmsleBfd8e2kUlyRoYQR2Xo9wDpyxQzrzrx9MpEcQSeohwEqCRMgD4wYolQsARWsoKJnDMS72eT+0wHNGLKnHiLwZlFx0xPGChsXgM40VyrIXjhokqDYO/LPYZl8aWw80Cy3qZjW+bq7WMJ1v+w4wh1/CQaOwiqAdUACJvi+oWKrxQMgTPTDe855mq5EFH9soRzDAY76QOzTSRsXGenROAZCcYGqtr86Vxi26ftB1FrUCiv+DZCcOxHco8zBB9Ff0i3gi5lmJb85g4e3qqQtSQoYY6uZgyu93u3S0Abe6vxsnGE9AiUEuZyKYn8qpqgzq31+I0272WgbAQtzyhLg/H038m0Z0U5l8GMyIIGYlWTQ4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(136003)(376002)(396003)(6666004)(53546011)(478600001)(8936002)(6512007)(31696002)(2906002)(6486002)(54906003)(6862004)(41300700001)(2616005)(15650500001)(6506007)(86362001)(26005)(83380400001)(38100700002)(316002)(186003)(5660300002)(66556008)(4326008)(8676002)(36756003)(66476007)(66946007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sk5BTS94UVpDK2c3YWZrcDlQQmY5RzVwdUJKRnRDRU8rWTRkbWYxby93aEV1?= =?utf-8?B?YTkwVjVJOXRKM2x4Y3Izd3pvZ040QVlGVXJUeW93TlVQSDRqSHVMOUFVZkFi?= =?utf-8?B?VHl4dlZXb2Nwc3Q5dkplTUF2QVBEbStsN3E4RmVHYm5oUERXUzFQWnorWVk3?= =?utf-8?B?TmdGTGhicGhuL25YeTVTSy9FYktqZTQ5L203U3BmUDR1dk41a09JMUpERmdi?= =?utf-8?B?WjlWa01ZWWhqS04wbmpIYnJod1dJMW52VGc1bFh1WURvVE5HWnhYT2ZsTGNz?= =?utf-8?B?SFl5YXBaOSt5L3BQc2gyaXprbndZRWZTZVcreW9wam9ZbW4rZ3VxaTd2WTdU?= =?utf-8?B?QWJpVVhaZXBzanBlVDBGWExWY2lvSGkwQ3FXZGN2c1dmRVJLV1REM3FnaFFS?= =?utf-8?B?Tnh4V1JDSHY3U2pBV3A0MzRoOEdkNXIwMmxkbVcwNnhrZHlXVVBtK2N2YmQv?= =?utf-8?B?SkFSeEJzS0UraTEwRjFEVzY5UEkzTUpMWXQrSGtocWV3T3JaWGVBQjFNZCtx?= =?utf-8?B?MHRtK0ZRaHFxQWt0M01tM3p6aFdqa0N1bU9ZQi9GellBMHM2a3ZCdHJ0TGVn?= =?utf-8?B?dUJJT3J3Wk9Ic2ZEM1B4Nk5lNkN2dzRKOWRlSEFlSXc4UXIvL2E1bGdTcVRD?= =?utf-8?B?OHkrdmh6R1M5d1l2SkNJRUxndFdCYXJWZ1BrdW9xcVNvUnVQYzFnQmxXNm5n?= =?utf-8?B?SEgxeWdQdTJiNVhBWnU2OTNSV2h1YUV2alhOUXI3cWZKN3lVNjdhS1BwbVVZ?= =?utf-8?B?NzBTVXZhSzN4UlUxb0NMWkRIUmZBRVRxQlZ2Q09uTkR4Y1lXM0VqZnorbk9y?= =?utf-8?B?bVAyVzBSckF6bmN5dDBET3AzMEExcWFHYnJmUERhdDJ4bU1nUXNJTml4Tkwz?= =?utf-8?B?QjBuNHp5c2VPcmZJTkhTdDJHRC9GdlRITE0ydStGS0loTnZJRWg5a2x1VzRh?= =?utf-8?B?UHNxaDg4WG9hRllSOGlQUUdQbHFtL1BQT2JnNmplNUFVRXozdHFMNllQM1l5?= =?utf-8?B?KzNvSGpTcDZoemVxeGJTM2VxZkw4a3pMMmlpbTdCd0dmeXNySFJhT3NvanBo?= =?utf-8?B?OU94Z3ZTRzFRbks3V002VnQ4VXhUaHNRdW5XbzNORlVlUDcyYkNablhkaFQ3?= =?utf-8?B?cW51bTB2dEZ1eitaMkFNalhyaEt5M2tvaTIrbmJ4RExlZ0pNTy9BcnFIc2RE?= =?utf-8?B?NkZmdUh5Q2NEc0ZTMTRlamNxRUd5Nkt1Vi9abkRvZkEzM2ZsRDlqcHlTM29t?= =?utf-8?B?eVFGcUQ1Z2xHKzNLMU1OWlcxNFl3VVVzbnZ2UFNVTmwvOThudGZnek5LeVV6?= =?utf-8?B?bmdKRDRQVlVtNXJudTRUY3JvTzRuRkhxRDR6L1BKWUU5NXRyVjh0U0VTMEZC?= =?utf-8?B?RkJPODNXd2xQOUlGZFFLWEIyZVJQamRmSVFmeW5DM3dxbklwWXcwTUJjOFU3?= =?utf-8?B?dUV2ZGZTVXRsN0FnN1RRSk1vS01VV0NtUWFqdnFTWVJnNnpWZXk4c1lzS3pO?= =?utf-8?B?NmRHTXpqZ3dTYkRQV28wTWpuQnVNRG1BYTM4ZU5UeDlnbHluVS93aTBKd1RK?= =?utf-8?B?MXRjU29mMmNLUmEyT0RXQ2hHSUZZcHpTWVEzdWR4cTh4T2dHM3pnNkhyYnJo?= =?utf-8?B?NUh3SXc3L1VMaVcyVUpDblBsc1V6blBTa3VuZHlpTFhFb1UwMmVEa2Jpb1JF?= =?utf-8?B?VkQyTHFIYWk1TEY2ZTkvd21BaHFNVFhtM20yTmJJS2laWEROdWFVWnJmTWU3?= =?utf-8?B?bm83RkZxR0RPbXBQT2s4RDM3WFpDY1kzZHhtQkNJbFZ2VGdBSXkvdm5POGMr?= =?utf-8?B?dFZsL0hxcWVPbXRWMVF1WkZWZUVabTVVWmMwVUhmWmpNYkFtem9SWWVuTEhO?= =?utf-8?B?YUJVTDVjY1BzcVBsUE93NDBjbzFhKzdTeWdFV1huUS81bjVwd3ZnYWlnWmhH?= =?utf-8?B?a0RMcWVGckNKN3VBWDVoMjM3Q1d6S1JpTkFERWJKQ1pvdktRRXZ4MXR6RTdi?= =?utf-8?B?dXhVS0dodDJtdjZ1L215R3R4Mm5aZE9HbDZtUDJDQTdyMmRwZzlnTmtyY2ZM?= =?utf-8?B?SVAvU2ZCOFY1RnpuZE1uY1RKUVVRMTEwRWx4WGlPKzArL000b0RteEFrM2p2?= =?utf-8?Q?EJ2uK0LtmQbBEGnXkunlbMgQS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ded3ab07-8e39-4800-c2fa-08da64ac1f47 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 08:46:04.9389 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DjgsL3Nrx0wJCiRyj1fqdBVNnxnqSDfFN7UyA3DgU/Oks3SBNF/N7NHCJqYxeHwqzNc4IsCUDMhOPrQpx18xtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5169 On 13.07.2022 10:22, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2022年7月12日 19:54 >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> x86 provides a mem_hotplug variable to maintain the memory hotplug >>> end address. We want to move some codes from x86 to common, so that >>> it can be reused by other architectures. But not all architectures >>> have supported memory hotplug. So in this patch, we introduce this >>> helper to replace mem_hotplug direct access in these codes. This >>> will give the ability of stubbing this helper to those architectures >>> without memory hotplug support. >> >> What remains unclear to me is why Arm can't simply gain the necessary >> variable. Sooner or later you'll want to support hotplug there anyway, > > I am not sure my limited memory hotplug knowledge can answer your question > or not. As memory hotplug depends on hardware and firmware support. Now > for Arm, we only have ACPI firmware that can notify OS through GED event > (not very sure). But ACPI and device tree couldn't be enabled at the same > time from OS booting. In device tree based NUMA, we will enable device > tree, ACPI service will not be initialized, that means we can not get > notification of memory hotplug events from ACPI firmware. > > Of course, adding GED device nodes to the device tree, and getting these > events through GED interrupts should not be a big technical problem. But > there may be other reasons, and no one is planning to add memory hotplug > support to the device tree (perhaps need an ACPI-like specification or a > firmware abstraction interface). So if we want to implement Xen Arm memory > hotplug, it should also start from ACPI. So currently even if we gain the > variable in Arm, it will not be used. Device tree does not have property > to indicate a memory block can be hotplug or not. But ACPI is possible to be enabled for Arm64, and hence hotplug could be made work that way. Therefore I view the variable as potentially useful on Arm as well, and hence introducing the variable might be less trouble than introducing the per-arch helper. >> I suppose. Mechanically the change is fine. Albeit maybe "top" instead >> of "boundary", and maybe also pass "node" even if x86 doesn't need it? >> > > Sorry, I am not very clear about these comments: > It makes sense to use mem_hotplug_update_top instead > of mem_hotplug_update_boundary. But how can I understand pass "node"? > did you mean mem_hotplug_update_top(node, end)? But mem_hotplug is > a global top for memory hotplug ranges. I don't think pass "node" > to this function can be useful. Please separate "current implementation" from "abstract model". In the latter it would seem quite reasonable to me to have per-node upper bounds (or even per-node ranges). Therefore adding node (and, on top of what I did suggest before, region start) to the parameters of the new per-arch hook would seem a good move to me, even if at present only / at most the "end" parameter would actually be used. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 08:51:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 08:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366303.597034 (Exim 4.92) (envelope-from ) id 1oBY63-0001x2-ML; Wed, 13 Jul 2022 08:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366303.597034; Wed, 13 Jul 2022 08:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBY63-0001wv-JY; Wed, 13 Jul 2022 08:51:51 +0000 Received: by outflank-mailman (input) for mailman id 366303; Wed, 13 Jul 2022 08:51:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBY62-0001wn-01 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 08:51:50 +0000 Received: from sonic313-21.consmr.mail.gq1.yahoo.com (sonic313-21.consmr.mail.gq1.yahoo.com [98.137.65.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 067a1e6f-0289-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 10:51:47 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 08:51:45 +0000 Received: by hermes--production-bf1-58957fb66f-hgp8q (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ee28fbef4544e32e715de306ef9fc732; Wed, 13 Jul 2022 08:51:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 067a1e6f-0289-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657702305; bh=po3rx7P0xH4Jlb2d4rjh2HEZfPtZkC0jo6hclr/31Ic=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=pnNhMykCudIQCeG1Ivwma7FjuZI/nYsICueZD0V+SPLbZ0nHMHAnUL02mQXSkVheDTXY3llaAGpMxLh5CiTvC0plnrug3CEAQZW68uIX+zd5Dba/NsThqRpnm/n3o9UF+99jJJXFI509DXX8LFI8pDdP1rjqWNtn2qoxOzhsT82asSY+Q8frRE6bBu8LOYERHxUAFNxFnXi/wc2a/SBigLKp1aJdaEU23wD/k+V8aaQDyeR1EuFG+CkQEE+gdjiTfPdXtGW8gHJA/vp8uDnqH6m9oUbA/6sAMP2Zo8abPQ1roK4vZtBAAS+jz8UcnJjNBIjd0lHvdfOttpmWxp+wPA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657702305; bh=fGPTfMaE5NgiHToEptF5sfYGWt3cD/iaWiWa4l+tKZM=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=E8J+PHRrL5LyYlsRtVX+/vx08U7QWF+pyFTsTq8BaI0L6xLrFy6GRhlmnvnooz2YVl+2VrjRrZ1hsZEntcZcEm3A9jVi/UOXSdQRH9O9rjy7mlSAzqgk7SuIyNCrP5bWIJUntkH4WQdYgpZ5Kj8cSsGkh4UDigRVaD444YTVTpQsdG1iuQNGQ8vYTxTzVI7n8j2Q6KDxfKmSsw/k9CYbzJIgjbodktbsTHwoWtDS/sZrOwLb2KyCSHR82cIGp1/rOjLHfDneB8qOhG9PK6ngSgHek8sXVc6EVrC6Zq9XsC9/wTsrdvv674D5+Ng5PvV0Lrj0xRrxRpJ63CDRwG8efA== X-YMail-OSG: iJ9rad4VM1lLyKmHFAUcS8Po3ixAgb7f4Xmvk6q3hJALY0SSa0T8Q.dHr72lWpv vfb7vkE4pbC7a7JGUdWhdkg3RHU1WWnfz6OuZ8k5.Ivx2Vk46UQJVfydVNI_pz550UekQr1DlmtA oM.4Jpsiqn347yHp4fm2KeG8cp177qsIROeOV2jtOAKKZhZP2suIOT5VuTigqQQovnEZgz2E3OO6 4NK0DkuLPcaQliK0u0i7zPklOBsL2PmLRqd2Ynx1y5TiFlVTAdFEgzPpYFfXXIoJNCt7Nl5GmFrT vbC32MJc8Vp6luZT..3ueD.FULplxLwqc.8_Ubhw2hBmdccITaAWNpoypEEMvjU5Kdwm6MIGi5yh TQRWAy3mfSVfiwMK5rq4ITp2FB6Rd74i3wJerSYhU45emur6fcwFeqxUQfX5PAyD8gktNGmD6X3C PFBxIRhaZHME62ThXBO4YK7I7bQBETb_hlwk8ut6y2IChsLYOj2..zj9LCAyY4mFD2bjBy2YAilW 0srbAWGl1N0CLUdKPvFOmsW537QSN74wUoBiWMfAzLyEUlFRO.kGNy24lfQWROqnZceCi9q6Qwp_ rZ.aZyQcqdQ2ruKockRShLKMEXsP_jAojVnfw8JsSnRkDROyH0geEuFEuEEauzjzGD7hnQgs1vV1 l9O36OXbfjpWgSJNatllmZnka7yKCwcCBnKck0_JmBc6qPZiZIazSdRXWJ157Y_xIZyEQ0jpnuYc IRAG4HcSi7DqGXPU.Tg9K99DJf7kITzrkdGNd9jaIW_W1_gDDnyFm2PY44aXroa4MygwzE6iX6k3 2suczaMjhTN1JywGwZ4_0LhTfmird2sINcBZ6bjbTt5G3mOAB06O5.TsWtpAL4m9gvYBiFWNzU_x K.tcXy7rJVsS4PnXLONP_QUyKdPjxYXLXT_YPjeSzfpieyDYKb4trejzrCfsHC6y7hnEVJGcjL4i myB08ECETL4gNCcqAHweUbDYrrgsTu5RngdNR3Yy5XWNa6Dna8Z4PDt_L.WNCXWWptBln0gPCfcc kaXwcf1OzNEG1xBeWpZJMrK2du0mDknVbeV9xlLuWLsce8iyJRq0fdydPifY5oibSZujq7tr2Fwx hny9PhbYpRJTB7bW3lU0fWmd16F2gi7HvRI6S9O6K153BkArYRX3YiQlpwL8quVAtzHIk6_X_Q85 DwwiuvUl9KEv47yrx5TuN2B.vyl5GRLUlG.Ty2pkkWtclDrIxNIwumn4QrTzweQ7bdR0V73bGcvF lCH7cGv1WG6PMOC1fA1AKAbOccfF6Kn1ueWuh3wpmwC2tJ8pAW4_2CbL03KrdEv4H0ucxeE5KhyQ x8ApAcbBtD.w8KHdYm.Y62hqSBvDL9ojEAOomkZ7FRmAznNDYIik20jso0p2OHqCGpJLYQ6og4Mm 4EvNWTPOWXmS9miaUm3q5dF1GkMtPyzOM_2fn3bce3j..u4ArhFMjLPckH_ks2kLjFiixgNbUO9t k2eqXbtI8O.bAL8fpVAd.BV8B3xJEldHM6jDRfPYfztQv0duj.HggLJwHTCfqm1z3zzSc2AfWJFE ovj5T6OGNjJyHx59xHjOjkDtnvnGKIOasx8v5BQNt6StRp3pny409V._bgZDW5Mh3ZdLrGpNb85A NXGwDH46ymLykow.l6LMIdQzcPGYT268kgD0L0PtxEdLT6fIG0Gb08hccKthqVUiAQ3XRY9x9UCg Iwwf6JvGJv8ZgdcB9g_2_g4JrDo9uvGA1E7iKpYtCFzm4dlNcyPLKwtRSP7KDVOyE8TEWOeXthnJ GBcck1YUSgwQqZMnFidMRaAUFA3fO0Bn.JUkWBGos1ibS.MNJN25SrJcN0gM0vaNQGiSGBf60il9 6aJ.Mz6iNqnUveyrahI6EuJDpxsXXZWXTWKLIXhIiPkuvFnRLYiA18obmIZu6pwcF3uELGPbr_eA zJ62N3.i01Y3LRZqYSWZvTA6dfum6x5DznBFXbsPpvM99fUK_BsbPaEycsn3n5ofnLz46_RbpSV_ fOGavJ42Ey4SmnX381Q3zroWFtaWSR8RK.Ghvl6D7QUSv51GmEt4WCt9FPgPaHrQvHWCZZSVWSHa lPoBPtLGwJw_cHwZRdulQ26FEvexq2tHHE_Dd64qPPvV64sxN7dSrIZSIwPyuYvNk8ydKjcbQf1b BNkYachARiSVeH85htb4EM5o1AWCAQtZ1_0433Ev0AvmSJZUvCEIjSg1tOJCj6DCPVjVMjmGbvGo - X-Sonic-MF: Message-ID: <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> Date: Wed, 13 Jul 2022 04:51:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4423 On 7/13/22 2:18 AM, Jan Beulich wrote: > On 13.07.2022 03:36, Chuck Zmudzinski wrote: > > v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > > *Add the necessary code to incorporate the "nopat" fix > > *void init_cache_modes(void) -> void __init init_cache_modes(void) > > *Add Jan Beulich as Co-developer (Jan has not signed off yet) > > *Expand the commit message to include relevant parts of the commit > > message of Jan Beulich's proposed patch for this problem > > *Fix 'else if ... {' placement and indentation > > *Remove indication the backport to stable branches is only back to 5.17.y > > > > I think these changes address all the comments on the original patch > > > > I added Jan Beulich as a Co-developer because Juergen Gross asked me to > > include Jan's idea for fixing "nopat" that was missing from the first > > version of the patch. > > You've sufficiently altered this change to clearly no longer want my > S-o-b; unfortunately in fact I think you broke things: Well, I hope we can come to an agreement so I have your S-o-b. But that would probably require me to remove Juergen's R-b. > > @@ -292,7 +294,7 @@ void init_cache_modes(void) > > rdmsrl(MSR_IA32_CR_PAT, pat); > > } > > > > - if (!pat) { > > + if (!pat || pat_force_disabled) { > > By checking the new variable here ... > > > /* > > * No PAT. Emulate the PAT table that corresponds to the two > > * cache bits, PWT (Write Through) and PCD (Cache Disable). > > @@ -313,6 +315,16 @@ void init_cache_modes(void) > > */ > > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > ... you put in place a software view which doesn't match hardware. I > continue to think that ... > > > + } else if (!pat_bp_enabled) { > > ... the variable wants checking here instead (at which point, yes, > this comes quite close to simply being a v2 of my original patch). > > By using !pat_bp_enabled here you actually broaden where the change > would take effect. Iirc Boris had asked to narrow things (besides > voicing opposition to this approach altogether). Even without that > request I wonder whether you aren't going to far with this. > > Jan I thought about checking for the administrator's "nopat" setting where you suggest which would limit the effect of "nopat" to not reporting PAT as enabled to device drivers who query for PAT availability using pat_enabled(). The main reason I did not do that is that due to the fact that we cannot write to the PAT MSR, we cannot really disable PAT. But we come closer to respecting the wishes of the administrator by configuring the caching modes as if PAT is actually disabled by the hardware or firmware when in fact it is not. What would you propose logging as a message when we report PAT as disabled via pat_enabled()? The main reason I did not choose to check the new variable in the new 'else if' block is that I could not figure out what to tell the administrator in that case. I think we would have to log something like, "nopat is set, but we cannot disable PAT, doing our best to disable PAT by not reporting PAT as enabled via pat_enabled(), but that does not guarantee that kernel drivers and components cannot use PAT if they query for PAT support using boot_cpu_has(X86_FEATURE_PAT) instead of pat_enabled()." However, I acknowledge WC mappings would still be disabled because arch_can_pci_mmap_wc() will be false if pat_enabled() is false. Perhaps we also need to log something if we keep the check for "nopat" where I placed it. We could say something like: "nopat is set, but we cannot disable hardware/firmware PAT support, so we are emulating as if there is no PAT support which puts in place a software view that does not match hardware." No matter what, because we cannot write to PAT MSR in the Xen PV case, we probably need to log something to explain the problems associated with trying to honor the administrator's request. Also, what log level should it be. Should it be a pr_warn instead of a pr_info? I will agree to implement your approach of checking the new variable where you suggest and limiting the effect of "nopat" to not reporting PAT as enabled via pat_enabled() if there is a consensus about what we should log to the administrator in that case and if Juergen and/or Boris agrees with it. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:09:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:09:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366312.597045 (Exim 4.92) (envelope-from ) id 1oBYMx-0003sX-5W; Wed, 13 Jul 2022 09:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366312.597045; Wed, 13 Jul 2022 09:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYMx-0003sQ-20; Wed, 13 Jul 2022 09:09:19 +0000 Received: by outflank-mailman (input) for mailman id 366312; Wed, 13 Jul 2022 09:09:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYMv-0003sK-U1 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:09:18 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 77921e3b-028b-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 11:09:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6689.eurprd04.prod.outlook.com (2603:10a6:208:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 09:09:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:09:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 77921e3b-028b-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aR4mXd7gjCkKbc4oBA0V5I30QM0FtR91VYDCZMEXzTH5DrgqKdjWGACKIdJVao8+ukH3/1sWGe7YJtrG/7t05r8sJRdLWo7XjWVMJt4CXzh7UegJ5wd3cgT5T2nKl3pcFr6+wxDyA+DmtKvmXQUw2oWy6mIHqoKbNnTN2OxtBUXYD/aGNYwfWshThurROlG24KCJOzFpVsR3FnEITtwQSDFMUMv4QBly+X3Ke64RqaC/RfZ3jvoZQvp1Mi/mrvavwpfE4jny3aQeBVdAogQTFwiPc7sMyhirvrkC0zhMkfgql4gu6ORB+WcFzz5Locd9UJtQtcZ9NaTM7ElXZY6pDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+5BeByCAvhnJPAdbRxFkwRX/efyDeJVoskJ23RlZaM=; b=GdvnY7sb6YtsA87tTfr6D5uA1WaKcMg8Db/NBBksMvd9P8JQfojMaeIpnBxmaQd0VfZpR+ul+ifkXkPRDk3Ut+TsujRFHf1qmfkPI8wksyuvlmL0ySu4xuVd6U6QGhbd5Qp9eGnayJzzaDR1wSMqwdQaFWSp3RO2IXqYbpjTz0Q9a8ksINXGQaXHmC07ZJJ1WmCnulHdn9iYVXRNweHhvI+ceeIU/Zre2vusLy+rrFgvfhRAZZShrVSg2RasBV8HYdvz0nwxJDXoiLaS/j8631U5nUPrkE0hFuGcI4stYmq/bi4qn4pgYTTwwXURSQxGWSMdnv6heydsFcbnl+72zQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+5BeByCAvhnJPAdbRxFkwRX/efyDeJVoskJ23RlZaM=; b=ZDbNagrx7eVbkewDCpUhu9TyVr3ATr3qknrF/utLGGoaza1lNMgSQUFl+dVEQKGys/IFGVFq5QGullTy+JBEmypcgPE3/Dnbd1uAbrrlCw9s3pApU3O/z8iC7cWuR26WSlc1IwUHJ7IkDGSG1Jt5ifiS5JlGd6CitkX+RxKxMEpjqULHN6kLRbroDVidc4GkLRWTinSwE/zxUQYUAfSQ3xN9M4s44+7iPrmyA+k3DY1AfNK8gMCVRMiy8NdlAP1FQnlj988rq7YkSIk9Q5NcXp4AQDObv9Dp8oPePNCOkrWzfAEn729PN3wG0fZv62/LepLz0MdjwtvExXezD3uLtQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 11:09:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> From: Jan Beulich In-Reply-To: <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 08968a7a-700c-4c5e-3fd2-08da64af5a8a X-MS-TrafficTypeDiagnostic: AM0PR04MB6689:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5NkZ3dqTgOMNmIo+wihuvg+M2kx2PCe9f/MD90aUR13CCc0C19rOa4WrP0e6NhR6rSp8rBKarwpAHyItm3+zfN48tGM48rtGlh0bZNjoY+GjCDS4e227NN9JcOcmy9+3aF1fuU01A5WSOk7+SnpUxJXZG8qqW5llBtmO3JsIKoSXP6J/3aKGrpcBL+BUVI+HKOxdbyu0Ngf9nQaBBxzWZGno0r9izrf4u50ZtiIqJIfo27+Wi793u+ZqMxWqJXZCj0+BDzN4pgWoQIavprmD+CqEc8wTwAY9BlyCe0CnLnoct7bGDnrStY6NBqeM9jTZc8tUKjP33xeTqPX2aedXwJagWSvCzqR39GkaFXRyWn1t5TQXkwZsHg2Sk8wlv5k7Msz2l4c5JoE3uckkA/Mr/5O67xFBoaLm/iddCEkChgJjP6nKjE9GhdjnrFTxjBbVLpCXE8hBybhMiWbhdZTUJY0pGX5A4SnLLdcgGxd3svPnUzX2w+QqXwMoZ7/U+FBM23Bud3cJf6YNjDAuaBsPuyrbKc2POnrPbvzE+wjTP0H+UCbvvj2PBuP/A53Jzl3zMin+PWfCbLziATQ8VYgB6LX/8kGqBnS7QOpnZClcIYVFMEKG8KIT70NQL8pgFCaxnWvpLgJSCH41+UjwPzsO3kxIpGyUuhXWrto9Bzb3D50jcjBpzhHcLOgmzStQ6NB0U0UwSAr0baqQUKmLHdH9QpLmgefXQtsQFk7I3nKMMJg04xqzwD86D247XxywtEc1LUVXo0sOt3tWXRfsu32l4WTfzs05zz6aQI7Xa4D2JJR2NPUAf4pGrSXUdN5KW+Wiz8s14ChoPeAN7IyASmGOtNkRVJhPFhunzySsolJRS/I= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(396003)(136003)(366004)(6512007)(2616005)(86362001)(31686004)(7416002)(478600001)(6486002)(31696002)(5660300002)(8936002)(53546011)(6506007)(26005)(41300700001)(2906002)(38100700002)(83380400001)(186003)(66476007)(6916009)(54906003)(66946007)(316002)(66556008)(36756003)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEdqNGpWeVZvbmpJc1ZEV1QxSEFhS2tGWFBxaHVUWGR1QnVsVk93dTBHSnVO?= =?utf-8?B?QUxlME5xY0xQZlpxME9IbVJNY1Y3bEJiYUdmZ1FJM1Vvbi8vWEpQdFF4N3Z0?= =?utf-8?B?amFhc3Y2N0JNZ2srVHdraE1CWXJUalBIeWxxNEtiRWVBN3d1N0xrczF6cnZt?= =?utf-8?B?TTlFeHBRYlUzUDQvUFhPWnFBQ2dkY3NzYmg4T0o2VU9GeVNxMHRIeTZCbUNi?= =?utf-8?B?dHdPUEV6dlpFZGtkWDlHN0NBN0luMnlHdWNRaWRoZG9mamJhangxa3FLSUZr?= =?utf-8?B?dEQzWmduVDZtSFNrbVRwNDh2VnF3VUQxNnlGVXJIWk5tVkVXdlVESnBFTTJS?= =?utf-8?B?ZHRaMmhrUVUwNDREaUJTVEc3TVJoUkpENDNFcE85U0Urd2s3bFpBT3l0bEtY?= =?utf-8?B?TmR5d2JibnQ0REV1MVF6SmZnS21BYUFCMUNENWZtd1NWUmZrUGJ2UUNyeDEz?= =?utf-8?B?VGhaZlNGUWhBZ0R2VzdVc0poTmp2WEtXRzZyU0ZQb3hNM2Q4OTFrbEZCNDlF?= =?utf-8?B?UlZKcTZDM2xralNnaE1xWU90R0JMWC9JN00zQnR1SVlEbGl5ZW01TTRWKzBZ?= =?utf-8?B?ZllHbDdRTFd6c2Z1ME5oOENZQzBEcEhhUVU0VzEzcGlsQ0NZcGt5VmN0dUU4?= =?utf-8?B?d3FiN1Bsb0drRVg0bjhZZS8ySU00b0JZdFdiYUJGcWxFOHNoN3BJeXF2Rk5M?= =?utf-8?B?aTFnRUpwRDlQQjdMUUExbW9ST3hqMC9nb05DVWJLVjlzQVNFZzFGelBrTDJj?= =?utf-8?B?a0YzZTZsTTJOL0pRa2xUS1F6Tno0Ymgvd0FBazkyQ09HVCs3TzgrUUFXTFVF?= =?utf-8?B?OENORmRTKzhhVG5pUWRFZGM4ZGlaYURVRVR5Si9CdEYvME03b1d5ZmhDS0dG?= =?utf-8?B?bmY3ZWRUamVWTzN2MG1MaUM4TXpEZENERGx5Y0lvcmpIN3p4cFd2VG9ZSDRn?= =?utf-8?B?Y3lNa29CVTBmY2liMDhvOHBvQ0x6RHRmTXlITTFnb0w3NDdSV3d1OHFmTXB1?= =?utf-8?B?VjNPT25PSFV0SHhiYWxsOWxDbTJjTlZBQVZVME0xdmhtaDgrL3pRazNtMWlm?= =?utf-8?B?Rzd6anVTT3U0UTdhellLM1M1Sm1IcDlnV2NHWElzQWF0VDNwZnlickxRc0xs?= =?utf-8?B?ZnJwTGVROWtXbDk2TTZTY0U4Tmt1bWNIalJyNTlvWGorck9qOTJFdXhTOHpU?= =?utf-8?B?MVU5cnpZT09lSUxuMGpYQ2IwcWlGY2JjL3FPRWZEZG05bHdGVllNQ2NobklS?= =?utf-8?B?RnM4aExZNE5wWVpMeHhlaHZqaldnT291c2U2bTgxNmNwd3dOTDFqa3JDVU1Z?= =?utf-8?B?TVRNa2N4VGx6K08xaXg5VVYxSW82ME5NZTQ4KzBlNi9DK2hCKzVyQnNjUFMy?= =?utf-8?B?VGRHZU5GT1IrSmhqeUtrUTgxdC9NTURSL29XSHN6dnV0YlpqcU9Bb1JBWTAr?= =?utf-8?B?Mk44RmFnVDJJa3RqVTlULzB1MW9YeWlydmI5K3NyKzdRQ21uZ2dCSmtkMG5E?= =?utf-8?B?MnlLZlhRSlNNbmUvSFhud0RKMWJWWjM3bjcvYURzQmphcXRzV0lqbDNlNzYr?= =?utf-8?B?b2JqZFRyYk1NdDV2aDlNcWVmZjkzaEhoSk1kL2V3eEV5M0JkVHd5UlFsQXYy?= =?utf-8?B?Ynp2R29sM09wYmthYzF3TEZiRktCNVJvakFlU2xZNFhGNHNDQmRxWFpJSWkw?= =?utf-8?B?ZTd0MnpQeGFyQnZMUVEvaDdiRXJnbEZoeGU4Q2hUVE42ZVhaei9ZbGVhSXpR?= =?utf-8?B?SG9pSnp3NWxrQndNdnA5azg4WDg5OGFQQnpCSG5kZlVSRDEwMHNnTlNJZ2tM?= =?utf-8?B?SkUwSjBDVUlOZ1lXSUw5V3JERDlvbDZIQ1dORTRhNzQ2ZE9iTjE4TExsS1Zn?= =?utf-8?B?ZzlRSkNRNzdLdnpaQk1HbW1MY01GNHUvSzdpWkZkbGVkZm9Xd2lxR3VhaFI5?= =?utf-8?B?azRPdVlIZG5Cb25IajNsRHh4Wi9TNzB2ZmhIWVMrYXlXaXZPQUlxWCs4MjJx?= =?utf-8?B?VkUxNCtPa1BiZ0NoSGNXYmpUQ21HRjZPSEZuNklCMlR1NGRYZzBIV3VXUjAw?= =?utf-8?B?VEFJQmJhVDFmRTBDRGVqOEwvZkVhazkrR3FUcWJvTlc1SjNzUjJaMHFKYWlO?= =?utf-8?Q?r/wwJZwS0llaQHUlqUzjYBa8I?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08968a7a-700c-4c5e-3fd2-08da64af5a8a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:09:12.8973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eyEcEkhfyCd6P70l8CSe1eR2tuQhcmr+R5I3uaG+uzWv0LJrRFzx1jhZ8XqFTiU4fbg8BMNkW0eZEuTSHkHHDQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6689 On 13.07.2022 10:51, Chuck Zmudzinski wrote: > On 7/13/22 2:18 AM, Jan Beulich wrote: >> On 13.07.2022 03:36, Chuck Zmudzinski wrote: >>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) >>> *Add the necessary code to incorporate the "nopat" fix >>> *void init_cache_modes(void) -> void __init init_cache_modes(void) >>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) >>> *Expand the commit message to include relevant parts of the commit >>> message of Jan Beulich's proposed patch for this problem >>> *Fix 'else if ... {' placement and indentation >>> *Remove indication the backport to stable branches is only back to 5.17.y >>> >>> I think these changes address all the comments on the original patch >>> >>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to >>> include Jan's idea for fixing "nopat" that was missing from the first >>> version of the patch. >> >> You've sufficiently altered this change to clearly no longer want my >> S-o-b; unfortunately in fact I think you broke things: > > Well, I hope we can come to an agreement so I have > your S-o-b. But that would probably require me to remove > Juergen's R-b. > >>> @@ -292,7 +294,7 @@ void init_cache_modes(void) >>> rdmsrl(MSR_IA32_CR_PAT, pat); >>> } >>> >>> - if (!pat) { >>> + if (!pat || pat_force_disabled) { >> >> By checking the new variable here ... >> >>> /* >>> * No PAT. Emulate the PAT table that corresponds to the two >>> * cache bits, PWT (Write Through) and PCD (Cache Disable). >>> @@ -313,6 +315,16 @@ void init_cache_modes(void) >>> */ >>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | >>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); >> >> ... you put in place a software view which doesn't match hardware. I >> continue to think that ... >> >>> + } else if (!pat_bp_enabled) { >> >> ... the variable wants checking here instead (at which point, yes, >> this comes quite close to simply being a v2 of my original patch). >> >> By using !pat_bp_enabled here you actually broaden where the change >> would take effect. Iirc Boris had asked to narrow things (besides >> voicing opposition to this approach altogether). Even without that >> request I wonder whether you aren't going to far with this. >> >> Jan > > I thought about checking for the administrator's "nopat" > setting where you suggest which would limit the effect > of "nopat" to not reporting PAT as enabled to device > drivers who query for PAT availability using pat_enabled(). > The main reason I did not do that is that due to the fact > that we cannot write to the PAT MSR, we cannot really > disable PAT. But we come closer to respecting the wishes > of the administrator by configuring the caching modes as > if PAT is actually disabled by the hardware or firmware > when in fact it is not. > > What would you propose logging as a message when > we report PAT as disabled via pat_enabled()? The main > reason I did not choose to check the new variable in the > new 'else if' block is that I could not figure out what to > tell the administrator in that case. I think we would have > to log something like, "nopat is set, but we cannot disable > PAT, doing our best to disable PAT by not reporting PAT > as enabled via pat_enabled(), but that does not guarantee > that kernel drivers and components cannot use PAT if they > query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > instead of pat_enabled()." However, I acknowledge WC mappings > would still be disabled because arch_can_pci_mmap_wc() will > be false if pat_enabled() is false. > > Perhaps we also need to log something if we keep the > check for "nopat" where I placed it. We could say something > like: "nopat is set, but we cannot disable hardware/firmware > PAT support, so we are emulating as if there is no PAT support > which puts in place a software view that does not match > hardware." > > No matter what, because we cannot write to PAT MSR in > the Xen PV case, we probably need to log something to > explain the problems associated with trying to honor the > administrator's request. Also, what log level should it be. > Should it be a pr_warn instead of a pr_info? I'm afraid I'm the wrong one to answer logging questions. As you can see from my original patch, I didn't add any new logging (and no addition was requested in the comments that I have got). I also don't think "nopat" has ever meant "disable PAT", as the feature is either there or not. Instead I think it was always seen as "disable fiddling with PAT", which by implication means using whatever is there (if the feature / MSR itself is available). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:09:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:09:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366313.597055 (Exim 4.92) (envelope-from ) id 1oBYNB-0004AP-D6; Wed, 13 Jul 2022 09:09:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366313.597055; Wed, 13 Jul 2022 09:09:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYNB-0004AI-AG; Wed, 13 Jul 2022 09:09:33 +0000 Received: by outflank-mailman (input) for mailman id 366313; Wed, 13 Jul 2022 09:09:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYNA-0004A0-Le for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:09:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYN9-0007yr-T2; Wed, 13 Jul 2022 09:09:31 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBYN9-00073A-N6; Wed, 13 Jul 2022 09:09:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=JBJg4loxW9fQMFNPIoTqiu0K6NxTOmoamH4n3BdPXfw=; b=TzYPpVfKW1a4RLhPs8cMuoXD5n Rq/1NHcvL/oyrcCLmSOp1DBVp9PJss7d7vyTi6NU2pn0fMXhC5EjMxRR7pvTZm7lpvxnT5L+aNfvT z/HSNkl2ZVVdVMbaXhY/Oj7H5aD3sL+vYvaLp/f2cmoIZN2vEJl3ei8GUiMQbEXWUjoQ=; Message-ID: <98f7b0fb-770a-6428-3be3-65f776fc9a0b@xen.org> Date: Wed, 13 Jul 2022 10:09:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 1/8] xen/arm: introduce static shared memory To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-2-Penny.Zheng@arm.com> <45a41132-1520-a894-a9eb-6688c79a660d@xen.org> <9172fc95-0939-3680-94cf-b991c46d0918@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 13/07/2022 03:42, Penny Zheng wrote: >>>> >>>> The Xen doesn't need to handle the optional case. >>>> > > ... what you suggested here is that during "xen,shared-mem" device tree property > parsing process, if we find that user doesn't provide physical address, we will output > an error, saying that it is not supported at the moment, right? You are correct. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:18:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:18:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366324.597067 (Exim 4.92) (envelope-from ) id 1oBYVW-0005w5-7N; Wed, 13 Jul 2022 09:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366324.597067; Wed, 13 Jul 2022 09:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYVW-0005vy-4T; Wed, 13 Jul 2022 09:18:10 +0000 Received: by outflank-mailman (input) for mailman id 366324; Wed, 13 Jul 2022 09:18:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYVV-0005vs-8d for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:18:09 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60062.outbound.protection.outlook.com [40.107.6.62]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b52c7b18-028c-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:18:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6248.eurprd04.prod.outlook.com (2603:10a6:20b:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 09:18:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b52c7b18-028c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d38zqlEnIKpT5DpMO5VlrQsrBj86w8s8H2woRj4je3eLU2oHTIyQu0Aqhqm3YwluBKlMzLpxwNZKKvqf3UbMQukljic+NpLTTYRt6lyiDnqPbi9IniUYcYdH4jVdZyxDhFoGv/r2Jg6rHPF+fJpUuhsFOivxKeHrIohE/JWK93dlY9PFcIJ8HAYSIiDnulVBpXNdK9u/ilhIUnV2pWmZp9esBDdEhG95RxI+EI0GXiVXpZJ+S4QmxV4vN7BatZw1lDUcWYSdq520/HnWlDBX953g0uQlJizw6ndR0xXW4LzxtxiycOu/T8wblCmd9wcVeRqey4Ym+ndHof6OmbQDEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0wiJR8y9d9p8OP3226b9Uqy3841O2K+rwB3kugZg0Xw=; b=nIpF8MH3UF2WuKpdqlB585whcaLYkEQjKepQKS/B27+rVrxRfwGr7OUBJsawPRmpWogQ8YvorMfqcBh5AOtg2/CG6F6MeSYUT/DqGHxzLYL3esTo5nPTCaq+lvymFZ2ULg6jUGHD1Qz75mQ3Yi4SYrrQSdVKTQwJiGfPomvd3ng3T7KbTxnXV2ojKr7pEF0Q4WETqgF414n9yMvgyzdN9ouG0T5bvFy+41SDYaxJzYKr9bHTC29FlNAAEdKTEwrplL5zAVY1RyaeOqlTjo4VOQhRuy0ustl4P4elRCikVtMH7pA6Iw4sDmcfhaYuU5LqgsyMpfRImZsUK8+zdlzpDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0wiJR8y9d9p8OP3226b9Uqy3841O2K+rwB3kugZg0Xw=; b=Qu8NhaXnapa1TaUiDrz7HGWQBZHt6EXMl8LNPad127rcTD+hIvIm2r6EzjBlxjXkCrNPYt5ndFiChJpiyntq0N57tg/h5XRpJEWhnWl4YoCd+KPP6WRMcf2zjrclWdzDWOtpPK+CvPuRv5es1CWLv5rNslzemTK2gIZ1u5HxEHDBYhexsLXSadB0791SLrfpK33VvvkY/vS6KlCo5N/2C34YOJJvSlqPlRRXimO1nTgR3eeabP5XlWGTqqm0+Hd8DOSoMKSJg030aEmdfvXM63LCD0MtQL1+QmnitUPvtnpM4hZjQDbIRh6Gw54Nt9IWRHMqs2/DZJgDe3nWQD92Kw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> Date: Wed, 13 Jul 2022 11:18:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "netdev@vger.kernel.org" , "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko From: Jan Beulich Subject: [PATCH net-next 0/2] xen-netfront: XSA-403 follow-on Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0040.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:458::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef0a73c6-822d-464b-200a-08da64b09809 X-MS-TrafficTypeDiagnostic: AM6PR04MB6248:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xUjMnvxJN13hfPUKFQA5OWNXojBbsQ5iukpZDFdYTODBDGS/gAS84XgTmhDGEAWCJm+sjoauBZ6XwF9KmmFRu7RlDHbplquZUoYW/bMR1XR9Jf8FVDaW9HE73m4NYTr+hwkIiqyahNyX5v7f4eVda6cxPgG8UrqfZdkrcLfkattqIclzWH72ELOPWXC8M54Af3ZVarSyjP59Tbb7g8+WfbLCouzW3SOmiuBuMqiVnV4qcmrk8FiEONo/ldFTezQyM3kpgktPjwmoSzgaG3bPLKjazLyOwVCJERWd//UBtZ3Y36Vm6LwX1FkU36oh5swkruua8IwPxpMcZpqnhvHnXEhX7LFdbtiGuVTp0iMLw+3wz3mbKCf+SgEs1TEflSdtALxo1jDiWulYEZcY3c4lsE70/5bC1t9mbX9sWoIkcd9sihuDG/UR8KI5PdiOn7BBeTlLIh4Grj1RXveXnWEf/sjknosVa6C6PqwTYMm2JVRtQpSJZ07J1EP1dLmWBr/dTu6DxYenKe5pHVceRvOWuPbXoj1MKr9rLac73YkHqC9xXDzM+KM1JCGsc+p/cBIBZamy4GjaLle5AVa8enxnJk8k2vzAZl2FZFYg7nbd2/QHyq7moMY/mM8wtAKCXLgQVuWdqOykvMJMYxxbDMzrBs55xB15hFF9TsY+e+N2QutU2WWl1jcEcYnbm0XLecECX7EJCN5U2U5P6BbKsusnxjZtoIEW/tI5xdkrgD6VQBIvSBHw5BMJe1jsNCqegXuRo4swR3V9M0HTs5PFt2a/K/Gjk4nkCTPNPSIyWLr4VEsU6Suk211+RFvvFivSA8bMX1PmQ7UCTNBbNIvF0jtlWDVbfEmFwe+plnnx7hMxN3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(366004)(136003)(39860400002)(2906002)(5660300002)(8936002)(83380400001)(31686004)(2616005)(38100700002)(558084003)(478600001)(6486002)(86362001)(6506007)(110136005)(8676002)(54906003)(4326008)(31696002)(66476007)(316002)(186003)(66556008)(26005)(6512007)(36756003)(41300700001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm5NbjBVOEF2R0lPTmpuVUhHRmphbUFsQU9aT2gvM2JQREtZYXpVc2ZDd0ht?= =?utf-8?B?MitSY041NnJXTk1hYlJiOUdmRnhuUGc4eUhmWUZBODhvcGoxWmtCWXYzMzRU?= =?utf-8?B?c1p1MUY4Nlp6WGlsTFpJa2gwaWpQcUxjNkQ3NzhWVDUxNnp2UTVXS0FSVzVR?= =?utf-8?B?RTk3ZHA3dkkyYkJaMTVBaW45NWhMZXRTdjNuemZMZlg4WWhCQ2kyUk1ZMUlE?= =?utf-8?B?eFhyVXRIVlBYOXR1aHlZNWgyZWIxdjRVeDQ3NEVxWjJlVXRnVjlMMDdQZ0dw?= =?utf-8?B?dDJhZmRqUGp5cit1MFdIQmRRektQUGNpL1ZuZlBoWjdGQS9JQU5GOXFIYmZO?= =?utf-8?B?cDcxQk1OMVlPWGlGZkRVcHhNQ050eDd0TkpZWkJZTVFuT0JPM08vS3NsaFhW?= =?utf-8?B?TGpxSG42S3R2Z1ZSalpNRDBKL3F4bEw0SytCelpDNU8zZTVSUUg0aGsyeE12?= =?utf-8?B?NUw3eHRQR0hvTnA1NVlYWFpjRGdFY1JyUVo0ZThNY2dOVFRCVWM1T09HdjMx?= =?utf-8?B?MFBibzgwa3VROXRiejdxcUNXR1JRNVhsZEhxbGlhd05WWDdkZ0pQOUdRejZp?= =?utf-8?B?Y0UydkliOUJrd3g1ejR2Mm5pYk5rSk5XTDRHeGdIV29rMnREVWo3eHNtUWZF?= =?utf-8?B?OThVSExLQ0l1dGxJMlNWRDBFU0h2ZEhCK081WTExUDRXYy9paG9TdHJkU2g3?= =?utf-8?B?OC94dFBmVzZlVmRvaHJqOG5XblRjMWJ4NVFlUU5kcUo0OHlkbHZKYUNxN2Zv?= =?utf-8?B?Qm5yaTRiY3dEdDRYZHhLQzJDSkk2b3UrNE1TbTBNQmpiVEM5UlN0alZPRHVu?= =?utf-8?B?UncvejBEVFBKRmxYSkkzU1BRYVRySjZXMks5SW5QMXZYRklXcDhCanMyZTVF?= =?utf-8?B?K1JYYWFCekZLNUN3dVhsNE1ON2ZtRnNKTlFYQ3daOUZxdXd1TjRTK2o1eTBa?= =?utf-8?B?d2EzYlNvYmI0MTg3SitTbzBaNlVsVWNkTitLZG90QkFIeDdXdS9OcHBDQmNt?= =?utf-8?B?OTdhazRWalRSVXR5RGhUTEdOa3hVbXVxSkptT04ydEt3Y3dFRUZqc3JzaGVW?= =?utf-8?B?RGQ3S1czZStEMUZXRkdxTE9lSXVQSkVPUGswU1FHZXlZUXN5RFlKK0R1ZWVa?= =?utf-8?B?YjVYZ3pKMWNmeFlTdjB1Rnh3NWplTjVFOXJyOW5PVnJSSmR5enZURUs0SUE4?= =?utf-8?B?RGZjRnZZUlM3YWlmR1gvVnYzWWZFZTQ3UzRzd0NwSmFIdWNLTGIxbWVldjNr?= =?utf-8?B?QmVLRUpjaFF4WXBLTmE4aGt3Vjk3ajh5dFY1a0RYTE82OTl4b1dGV0FHMGJa?= =?utf-8?B?ZDJveWwrNTZ4OTE1blk1c0dMYmo1ZURkR1NvcjR4MUZ3Y3RzMEltb1dCL3I3?= =?utf-8?B?MDJ3VFNSZVgzOVZ6ZXA5UzJaVS9MNFY2Mi9zajZLNjdsLzFGd20vMXZLV3F0?= =?utf-8?B?d1JubENsZnIrQkQ5SlhTTzliM3N4WDE0M1N2RmlBeHl0WTYrN3IvT2ZpTmNU?= =?utf-8?B?SkV4U29OSi9aT0lKQkdXL01FNmZQNUZsQVhlRWJyakxVWi9SbE1wK09KTW9G?= =?utf-8?B?QUJjYmV3MTcwWDdLTkNhektKOWdCcFBwYWZMa0VVU2owaVBKeUxDazU4Skt6?= =?utf-8?B?alV0R01UT2thRkt1R3BJYTFoZ29GNkMvcUQyNkJtdElVTk1LRE1CRHFsZ3N5?= =?utf-8?B?cXNNOWZhQTBYeVQwYWlUOHE5WmFWV3lBREhHanJrTVdUdmJid2lJWk9LYWZN?= =?utf-8?B?QnFYL3RQWTVUUE9EMmJSb3l1WmJCbVFtZ3pmZCtQS3BXNEdqRlprTDlrRXJh?= =?utf-8?B?THpBd1F0RFRZL0hoWktRcmdYYmVHRXdVbjI2ZmFEUFhwaFcvQjdpMlJzbno2?= =?utf-8?B?NkcrMmJGMTlTcUU1SDNKYmpPcHlaN1laZWpEVldPS0ZPUGt4em0vTVlabG1s?= =?utf-8?B?c05RUDhMc05vc1dQMGtYZEt1ZWlTdmpRc1BWN0p6ZmUrNTRhVXBvK3paVldI?= =?utf-8?B?aVBkUVFKcTBpVnBJUVoyVU9ROHlWTEZWdnRqVnZlUmlOWk5YMTFTNG9CYUEr?= =?utf-8?B?L2xDMHJRNE1mT3pjNzQwaDN5RUJDSU1FUXRwV0RqK0VSVFZkMG14SFVaNXMr?= =?utf-8?Q?+Rh2OXcHSyG1IwI0nwmIyFdB7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef0a73c6-822d-464b-200a-08da64b09809 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:18:05.6602 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GGoBv65J5fF3uHNEJYWuVsevgYOGCBD7L+klwYprUDiF2dCMBGdlpxBfqkOt/t5tywXpnT9ZmRxXWxKkyRP2gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6248 While investigating the XSA, I did notice a few more things. The two patches aren't really dependent on one another. 1: remove leftover call to xennet_tx_buf_gc() 2: re-order error checks in xennet_get_responses() Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:19:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:19:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366329.597078 (Exim 4.92) (envelope-from ) id 1oBYWw-0006h3-M9; Wed, 13 Jul 2022 09:19:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366329.597078; Wed, 13 Jul 2022 09:19:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYWw-0006gw-JE; Wed, 13 Jul 2022 09:19:38 +0000 Received: by outflank-mailman (input) for mailman id 366329; Wed, 13 Jul 2022 09:19:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYWu-0006gq-Ni for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:19:36 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9694e33-028c-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:19:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6248.eurprd04.prod.outlook.com (2603:10a6:20b:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 09:19:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9694e33-028c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z7l51EExKX7zn7yX5mO38bvbT33H6yeap9CwD8cFuFXk4F+R0PoZWruLXjsiUXsJDxrfkYBb3AM4jPkYMmRWx83BWgEMoh2ftiZZLmpU+mGAO/w9+rouVQlQAjLg+k/qNHJulES9/5w+gKsZrjosMgxW0QqeKVhF2apQKvkvfypthObEWurqPCQPsh7tSu06X0d4w4jms1Y0o7yhkX6QOxXNx7oMqJGdzT1fg9ihBnYo7/4ja7T5UgXkO3nPmAdRxlzS20D9iepapxq/dw3Ib4mZQls9erkmvAjHPDT1XuNdVurp/LvBKZQ+tf4nfnGj0t6VzoZJXv55V4F/b5wKVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vhtVsjJvr1mt+FAEVzCyU+1pVcikUQd+0/H1IYoovTs=; b=k/XlSXaAqLCzqbucaxGuFhT/UJ0iZAWI5OgrppXj6cXkw5lGi0ieL5KwBo8cfzc7D/lexkTrEUeMFmPI74ACQAXPUGOqLfCu27Tku0qCrxDWNJ79UIeQKkAmxFH1q+tCbyDltZ8ZgESl5mOcV8wT0nbxHyM/Pv1GV0LKrLrTVbY5ULFBeiM7NeyBrSF1HDTyBVJ8JkuyinC8985PkPMr8K56F0+uoLxchEPKs0pb3DbLl+AiTYotP0RlE0R5OH31EJ8CmkqYCgEGgRwgWaigROrGpvIjLWU89Ek+efHmoV7nsO2BbJKxZ5FQmp9EPDYo0rmhTOBX5ArEwkxvHTKtWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vhtVsjJvr1mt+FAEVzCyU+1pVcikUQd+0/H1IYoovTs=; b=2WW7X5B44yMfeOw+JVSMNqzPdc847jM7sRPVu7qxws8meHC2m2tXL2dErVeKvMbl09HnqAp01RTTSyq72+bHCQrrkCM1zaHFl5h8XBFbphonIfb5Cs16RDEAC6ciOjbAAq4lulkdTSLerdqoC2+65zDU6cxWO1fFZVwZFfSVdmNOFcuNXkNdznVWRypEydJhSDDcT8Il47l9j0Le+xAYX/vvgulcHCQuv30AYTuQp7Ky7lri5c12POiApZxsCGh6yZZk5XdY/swiFh5h2VZ/mIvE9isP45e91TS+Itox2eJhZlgZ91RRtBDntf0ySsJvvn3MHuQy5ZxgAKEMIX3Jcg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <16fea59d-6e61-4554-8198-24973e1300ef@suse.com> Date: Wed, 13 Jul 2022 11:19:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH net-next 1/2] xen-netfront: remove leftover call to xennet_tx_buf_gc() Content-Language: en-US From: Jan Beulich To: "netdev@vger.kernel.org" , "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko References: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> In-Reply-To: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0084.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cd962c2-8f36-4401-9725-08da64b0ccf5 X-MS-TrafficTypeDiagnostic: AM6PR04MB6248:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QjqA5UPNKnvSDeV+Ujj1DPUF6oYp2NHFbLQvMWFwrbcyJX5nvLR4Ye2YQcod31jRrDUZtED29aGZjdUBEa7p0dqAs5bjSwpPuTBZginC8TA6axSRbu2pgGAmU2uBYaA6u2j8sSkjWhbEc+O0BFnw9bIYbjPAdlbK+d4CIaspOpUT/LYROT8jH64Yo5TTNwWABdRoGZgSxwqiWZzwXqUySOYS70ne7FzQQ8ZVCjBdbSM2ssk9bnMeNCBQ3uX5+HvkCV7qNi0D0LyFElh6xo9j5jaZEtRuRs7LfcqisFzeiGG241keI5SvcYpVNhFA9mSK3jBgFilQz8SQtmlvAELWfrlxKX+yj2Af2ILYfQ4WQ50LBxR2VGBTS+qqeaQp4Xp8ZgE6W5UwbhZnBehzayWRY3G6eyHgZQyj+dj2gFNjkmNR3pPzGoN0/qCevGSsFboLJYsi8dsh1HJ/ACyY9GACziIiTiLbzqlxBUOAAmHFhYtONEwOwqOt/8L9gyrS13/oQiPZgwiuiXyrjLxWYqft+Un5fzlmQ5RaqCZE3mqjIhsxbvZIwRQa7aI2eGMkLWRqvCBUK/muU0N2MdJv85SNQVXcf4i2PDDb4NoTzq5YdA6gfkLjrYybfIImQhRkPsV8GEJ7KXDthFdpJOb3Ooi3xOX+/tAoXp788p/7B8kUOg2Xonlltct7ct/vvYzPSpqXvqLjXOeVVCxVuRzkF+TbioOUKIN8BoQKHDUxXDoYVzttHB/84NMQZFsB5GGnpLo6TY0d3SdBO+1Kyg0wp1N+nGHEQp6XPPDpGgVjD/A8DET69D5JQ8DRRDht9jHPoD8MxtXsyFacTipgbjxEEsdMw5Mej6qNWhbul5sMamQ0+DI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(366004)(136003)(39860400002)(2906002)(4744005)(5660300002)(8936002)(83380400001)(31686004)(2616005)(38100700002)(478600001)(6486002)(86362001)(6506007)(110136005)(8676002)(54906003)(4326008)(31696002)(66476007)(316002)(186003)(66556008)(26005)(6512007)(36756003)(41300700001)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGd4RGd0cU5UN2FJSVZITUo4UDF2SlVjL3JFSGRleEtpVmQ3TDBKRFhETm5k?= =?utf-8?B?TUpURWI5bTRiQnlsVmh6cDcrbS9zVEhpRlcyVitiVGZuK3ArMmxNZS80dm5V?= =?utf-8?B?Ymk4eGxHTDYyaHVWWldZeEJ6clYrVVVMd3pwc2tzRlFkR0o0MFFJZzNjcm1Q?= =?utf-8?B?Tk9rL3ZTdHIzeUNwUnBDNXNBdm5FR293MmhjQjl0blBNVG41eGoyV2xJcG91?= =?utf-8?B?M0p1Mmwyais2c0tYdVdKM0hqUGszbnhRRURhckIzM01OUDZpYXA1b2w1L25j?= =?utf-8?B?ejhRb2RweHl4TTVUVHVDOW9mN05YVnhYN21DRmZ0UlNNYnRmWFExS1FDc2I2?= =?utf-8?B?NUJqb2ZKMmhVbVk2VUhpZHM3MjJpYU85V2ZkSzVoSnpNMCs3NWhoYmFleHlR?= =?utf-8?B?bGp1eEYyVWQ5aHMvZ2oyZGhVWDlwNmZYYnk3dTF5bU8yU1RULzdGSmRWR3Ru?= =?utf-8?B?TlVCSjNzR3FtV29uTThob3hUQWIyRzZMRkQ5dGh2K1dvSHBZaHdZSDJxakpv?= =?utf-8?B?WjJXdmtGalJXMkpiSWN2KzRRWFc3QldkZzFhNk9ZNklYaUFkQzZuaWt4WXlS?= =?utf-8?B?MTdjZXl1SU5UM3hCNDJvZE5GdERZNFR6UW0rMjBCbzcwSkZ6dkpqWUh5ZTBJ?= =?utf-8?B?NGxBM0xIVXBmME1kU2k1VXBmWis2ejAwZmxicnpieXR2M1JMcG1xb3ZmRHRl?= =?utf-8?B?VnBreG1EWUJuL012WGNNZVR5RUpzNGNOWFlXWFFSRWxkSXp2eFhrbUZ5cFND?= =?utf-8?B?WFNwL2hhVi9tc3NoNmpBVnQ4OGJzakdOdzJodG5ZQWlKRG92WExyTENaaENQ?= =?utf-8?B?UHgxUU9NQzlaMlArN0hJdmlIWXNDbS91RERhUlovU1dFZDQ2NU1jS1NCZm9X?= =?utf-8?B?TnRRcVdXSmxiaFZSSG5LelJscHc3cDNQS3QvdVRsRVl3M2hGTFlvbzRRZmt5?= =?utf-8?B?UHVLbHl5emxyYXE0cGQ0ZHFzcE5ZSlFNTC9PQTFEdEpOYnAvS25pR1dQaGM1?= =?utf-8?B?RmgzMkNYZzJZZTRlVFBWU2o1d3RSaXg1WngwYlQ0T2NwQitkZnkyaTg2MTFt?= =?utf-8?B?RldMRDFHS3ZKZ1Z2WDh4ZU1QZmcrVnIrZjNrYzFDOHVRYnhxTHhBVldCRWFi?= =?utf-8?B?UXZCZXFtY1phQXlYV1VzQTlueG51RzIzbVI0eU5BanRVQisrZkZ6T2FYR1NY?= =?utf-8?B?elZrYzJaRFpyK3VBdUlSUjgwVFlGdEtPS0c5WTljYTluSUN0aFdwU01zUjhp?= =?utf-8?B?ZDAwZGNXM2lMZGNHZjM5ZWpic0tVVUxDcG1ZK29WQXBwV0REYmxGM250Mlpw?= =?utf-8?B?WU9kbEY5ajkxaVgxazNOQ09id1F1eEx0d3NXdURyYlYyMVBaVFM1YXh2UXp4?= =?utf-8?B?dW0yWjI5bFY4bWZ1TlRNenF1cGNiYk10VjJtZVJKazhHVlE1eGNVUTB3bktP?= =?utf-8?B?RjRHWE82dThWVTRPWXdnNzBUeDF1ak9wUEZyZ2EzbUN5MSszTjJZdnZiRVZs?= =?utf-8?B?OVZvUEJtdEFIZVdrQ0FWc2hscVJhb1dWa1JRS0wyZHpHWElJSElNVzRWOHFm?= =?utf-8?B?WGVYUmhPVno4RWwzZGI0YmEwV2h2bGE4SS9JdXFiOW5Ub2wrczBQR2ZlM1pO?= =?utf-8?B?bE92dzZGZ3AxVkxKRHpQajAwZWJuaUxteFBFWDdvNmtFb3dvOUZjdFNOd3k2?= =?utf-8?B?R0FINVJRZmdUQWR4TnR0L3pzbXkxVVpOelBmUWJtNnVJbHF5QUk5RzJ6NHN2?= =?utf-8?B?WkVCOXg2cklMSnNmQ25VQy9kUi85ZDB2K0o1UTM5d0MzdGxNVEtqdVNGdXkv?= =?utf-8?B?ZHVYWnQxaUlvNHRFY1FubDlkRFFyVjBrTFVPUFFrRTUya2VEVzArc1Z0UUFt?= =?utf-8?B?M2lyQzh0OG5TZVQ3RmtaRUw2RnREdUJrQnhjRHMwcWEzdzYySXNTdVJSWnhJ?= =?utf-8?B?MzdHTDhwWUZaek1wUW9jaFY0MGpvUUZtdFhwNmRjUFZJZ1FWYVRHTXlWSDlH?= =?utf-8?B?OUhwUElNcnpQZVlnSmFUOXNOU0tyT3RSeGhxQmxHSE1uc3dqNXliTEszbHRF?= =?utf-8?B?a3JjVXp2NlU1dVhnckhUNmJBU0lHbFFRQmF1ejgweVV4eEtaeGtRbCtaYjlI?= =?utf-8?Q?tpn2XBcTKVYvDyFj7Mdn0s6tv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd962c2-8f36-4401-9725-08da64b0ccf5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:19:34.3733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Re99TmEfUYuJ690Vobvvi41+hlirjrAU0zWiZCqcX63JSfn/A0SNnlP6DbLkIwTYIlaUEl67GjZ9CtarnZFSSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6248 In talk_to_netback(), called earlier from xennet_connect(), queues and shared rings were just re-initialized, so all this function call could result in is setting ->broken (again) right away in case any unconsumed responses were found. Signed-off-by: Jan Beulich --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -2464,10 +2464,6 @@ static int xennet_connect(struct net_dev if (queue->tx_irq != queue->rx_irq) notify_remote_via_irq(queue->rx_irq); - spin_lock_irq(&queue->tx_lock); - xennet_tx_buf_gc(queue); - spin_unlock_irq(&queue->tx_lock); - spin_lock_bh(&queue->rx_lock); xennet_alloc_rx_buffers(queue); spin_unlock_bh(&queue->rx_lock); From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:20:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:20:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366335.597089 (Exim 4.92) (envelope-from ) id 1oBYXI-00079h-UX; Wed, 13 Jul 2022 09:20:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366335.597089; Wed, 13 Jul 2022 09:20:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYXI-00079a-RY; Wed, 13 Jul 2022 09:20:00 +0000 Received: by outflank-mailman (input) for mailman id 366335; Wed, 13 Jul 2022 09:20:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYXI-0006gq-8a for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:20:00 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60058.outbound.protection.outlook.com [40.107.6.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f76be12b-028c-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:19:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6248.eurprd04.prod.outlook.com (2603:10a6:20b:bf::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 09:19:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:19:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f76be12b-028c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LfqdRDT7Dxfb6znB7xA8Q0dnBLYEs5/Z24Wzr5CH2cpLNzUkPY3kKy+/IH7Qcetr7yq8slPOX10ZSQ962GKcQ7qCqhlyoK3E7NrJBsnM8KR7QjO5ZRm/H4eYDjw53dk2y197Z2bz4OX7uT7heXuqI3Y/+WBpr9uS4Go57Ch5X99wqJ+g23SshoTynoYzD/Zr5bPELvqIeymK507NreiHCzf9W1xsh9dUbGALv42iz7H2YtX6Mf05mNuY9XCKWxGR6EZil72qWk8SOZ7g9DpYrdfJ0ql3GgxNMXc6h+l2L7ws37seAJMD0/7IyymYWcp/xvV7vEMq5hZWKr4tyRN6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WEzlgyoqktpBUwg5qI3Cs3eLw+k3O3PDbgsVFU2rvWw=; b=VgveumqRArUODB/DBd1QI/dmJJczlsXRsvuDwkKS+1kFaqHx6uEXeFtsU4cnW50o/oD8mEYExued+AXLlBAtQjP5kq+sQvpQYvrvq4Q/HDBQZiY8hjQ/Y6rIDNVA7IKLEx20vfethYT5n0ttCQZxV8o6/1wTeuIIabSSa+FqT2Ygg9nQMv3WHge+z6TXAthgTDv+T3d4x+NJMgnLpFdlLgdwQjZj3YnCzy/i3u7aeSzOvkcw3tMN38kMB5bbqqMZDqa5Pu1SxU4o2y2Q9u1RQeEjKcu2Ur2kX8IwY3sewRmPdRNFOK7n4OW8E1a+bipNcGFpCInMRxPlqvq9ZD3HwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WEzlgyoqktpBUwg5qI3Cs3eLw+k3O3PDbgsVFU2rvWw=; b=rsoQ7UM28NSh93C8G5ghGNcO6lpZQDDrvZ3Kmvr3ijZz/cYvQpaj5ch3RlHZxQosRN0d4o8z0tazvNMWaWd7Z75nSRAavJeuoDGI7pT5Uqi4JAxcokDjcH+LlCTDauy0DmkZzwHd7PhlE1/6iywE2lpsz9nsn5jkZAT1vFnuMnacefdPvH21PpMNRyhWCVavCnvRKbZQrZJvO3XVSKTP/46GLMWsZAQL9beGVFCfTU4I5k0XHj1UQsDb7qhaphtPGX6JhetSb0t2CmRP/buG1siv3oPyA7wPAvRs9vhPMuzgRpRLC2tHXD0LqYl+lBr0bdtNXl0pgj1mtwXC1MuwQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <743b3ff3-896c-bfc9-e187-6d50da88f103@suse.com> Date: Wed, 13 Jul 2022 11:19:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH net-next 2/2] xen-netfront: re-order error checks in xennet_get_responses() Content-Language: en-US From: Jan Beulich To: "netdev@vger.kernel.org" , "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko References: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> In-Reply-To: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9b73baaa-af5e-4ce8-baae-08da64b0dac2 X-MS-TrafficTypeDiagnostic: AM6PR04MB6248:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fdppvxoy6fB7RzXwbN/jS/vA8fxOlMEaUpyLP9848ljFdMZBByjfXmbaTRY/ukPv/hFbtq4ZfuAEXZDLkiqdsTgiqQ/LgG+9ADZ732NVIhjCdv8NKgXW42bEGi3NikKxfeRMPoNCACLaLMT6cdkDU6FI/vS1xcZcnAPx39UnXY9GUfJQWQ/FFxAXwBYkyZwzk11Hmeesl4jz+R2kB4QDL73Uxywr6/ujdGAOMecToJwdodPyr+Vq1ioSkX8mKrSPkZ32UJm3qETNBPSJx/3Z7gft5RV0c8ZeOAurSSsOoA0ApigL/eTv/B2ty4uwxa9+FnaDibWqn8HrBPsOSiJjQc6ywQCGGTauAe9fDXA03DS6KejCEXQyGQAXjwips4gz3JC5klyPgZegD+9hNMvgTELTWIdXTfSSN07WOIhnuLPk0iDDYQMUG5zOZX5byu1plaIh+4TmoBnFCrUbnFcl+BwhnQb1T/1nXcAR+mTrUMNWhFONdhK3h8OZvJQH/mVUCuYC6X6T/xU3C59Z2hEKIdI3VA8JRCRDQV+hEbTI19F5up/YCjaJa9b4VBygRZ4JLIivnBzE7pjfiNv7S5G8yb5usPxDxzLUibBnld0yHDK6QCuTcEoSndq/F8JPW7dtRvdXQjd4vldOctuXqeBtdHHDwZIDSBse13jM4UW43f26xedFs7zQ0Tv3TuGzvQU5W7fANQb2J09EHQrFYbPSLfmRKSKBrvuIDtysKw5OJ6pkU/uY3UvvkNB6i1PkkedQzpvjXic3hXtoHyMxNsCAKy7nVuFHVQvIAJz5VPaMB77yqGRgD9KdrIvnaoUwjQfbYQs69NPb7xZgPDi1ZgSx8V+LE5TYvNLnEqAOVSmA9IeMm0ziTwieMt2kzThY4akx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(366004)(136003)(39860400002)(2906002)(5660300002)(8936002)(83380400001)(31686004)(2616005)(38100700002)(478600001)(6486002)(86362001)(6506007)(110136005)(8676002)(54906003)(4326008)(31696002)(66476007)(316002)(186003)(66556008)(26005)(6512007)(36756003)(41300700001)(66946007)(169823001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NTlFa2c4K2V1TmJxV04zbG84Z050WWtWeE1DdUU5TGY0MlN4VURYUXk0TThq?= =?utf-8?B?SlNsL3NUSnMxOTlzMUNldmRpenZjVDY1NDB6U210N210eHBmcXRwYWY2ZFZS?= =?utf-8?B?Ry93NFBvNFZWWVdMMmw4ckhzSzZiUU5tRE5sT25pd2JYNXNzY2tCV255VXI3?= =?utf-8?B?Y0JIUjZsRmZQZ2g0aXRrWnFtQ1R6a041MVRiRUN6bTlrOFBoaHJJZUYwNVAw?= =?utf-8?B?WHZvUngrLzVhNTRJTy9tcW1LSlhSZy9ON1JWaGNiNDdBUDRWaU40eXRLclhC?= =?utf-8?B?S211UmRyUDdtYk1jUU5RTnJSOEJBdHgzTmluTVVUMWh3eHdVVGlkOWxwRzNs?= =?utf-8?B?dHdxUTRUVkpUdnZ1WVBlbUZickQ0Vnh0N0cxTHhSMk1rWmJiaGJhajNlcEll?= =?utf-8?B?WEtEVkpaays5ODE1dk95a211R1NXTGgzeGo2aHlOU0R6d0g3TGwvb2NEVlpr?= =?utf-8?B?V3pUU0plOGF0S2JhTDdUZU1QSmxMejBjWjlmSjhFNGZoZlVUMlVpSDVpamJw?= =?utf-8?B?TnljRXc5SDBpZHZIYTBYeGlZQkNFRjM2UkE0cW1Yb1VHMTZMampIM0xhd3BY?= =?utf-8?B?TnZCSzExUkYzWkZpTXNZdjU5UGhtZjdqSFVJOHFaRlZEenlCekdmQ2RMVmY4?= =?utf-8?B?MjZRenozOFQ5d3dqbXBEdnM3SFAxSTdaT0NnM3ZHU1FaR1VSZUJVeFBNOHh6?= =?utf-8?B?b3RwOUFPZVRJTTB3QVB4QXRwcklINEt5c21ybVZNRVpRMnFKRVNYNzZPbEM3?= =?utf-8?B?L29leWRZblI4RHE3UmFsbW9HalNXQUFJT1NVR2xDcnlGY0JpS2JXL1RkLzVy?= =?utf-8?B?aHIyc2UyT2lzQWRGSkM5bXRGTGJhOWtBOHBnTWY3WXUvYXoyOFBwRitvQU95?= =?utf-8?B?cjA2WCt3V1pZR0ZPbm9qcU14REIxS3MvOWlXK3JiejFIZDRrcEJnVFREQ3VJ?= =?utf-8?B?eG1Ya3o3cEZ2eGFwNVppVzY2a3U3VFM0bHVBSk42NFgwUW1yQnZoZVdUcTlF?= =?utf-8?B?MkJlZE44TW1ySjVNQk1FdVRESUorbk5vY3NSRC9panptUVlEeEFPZFdJVmVC?= =?utf-8?B?NVNSU1hPMnNPMS90NllwNktheTRQRDVNbHU0TmNoa3B2RnJ0UE1qajRmMXB6?= =?utf-8?B?UTFTR3EwbVFYd2RwVHhPeThiQWJrZEQzb3ExRWw4OHhZRG1GYTVrUzhhRzQ3?= =?utf-8?B?c0ZxZnNTYmU4ZnlIU2FLKzdwbmlGdTkyL0Z0cklXQXovYzJJdDZ0OVJwb0Q2?= =?utf-8?B?emtpeXZuOHRmR1lJMWNPamR3TnZkbFc0WGQ3VUw2YzBFSHFSdHhaVWk0dHd2?= =?utf-8?B?U0tFTmJYOHdHalpiNG9wbFpQeWtRU3piZHZxc2dLaE5HSG9tYTRERXZVRVl4?= =?utf-8?B?bVkrZDJvZmlPcnNkKzNoVkRpVzMrQUdOMnE5bStodFVySDd0NkpjS0hBREVr?= =?utf-8?B?SnY5SW5TZ0hPQndzbDFhQnRLN010elpWK2F3TlhJQUIxOVhLN3VUU2NIR00v?= =?utf-8?B?TkorSlhUZ29sblVkb0ZiNExweCtLT1RVTlVXalJJc09jZkNKOW9LWE9tdVdq?= =?utf-8?B?eVBQVzFiTXpLTk5HSVlrb0QrQXJrRG1CTlB6T3FuRnVwMk9TY3BYWmhlL3Qz?= =?utf-8?B?RFkwREZ4MDRiU2FhUDk2MVRkTFpBanVWRUE0Rm5oeGdSWEswQVRZbjVwOGN2?= =?utf-8?B?eHQrdDBGaS9qWDlOWnRaUWxBdjIvNzV5U3NKVDA2cnhrVVlBaDJLVENhRElz?= =?utf-8?B?TEtvTHkxTlkveU1ncVRwTVVwaXUwR0IyVXg1SFkrTStvZ2g4RXVkSHlsNnZ0?= =?utf-8?B?NUhhUy9EZ2ZpeDhQMVpoRXFRZU9RUHJYZnoyUlI4VWNreUNEYTJFUXdBK0No?= =?utf-8?B?eTg4VU5tek9ibmVPMU8yRU9ESlY1ejZ6aEh3eUNKUmZJaHRNWGp5WmV1U2RL?= =?utf-8?B?S2ZzSnVuYzVSZFBHTGxoWENzVmVDd1BQdWIrRjAxYUg0dkdWTmVaR1BpSE5p?= =?utf-8?B?V2x4OFB4L2llNnJseC9UNmF6US9hSFBvbDhRTDBESnRScDBMUHpSR20yV1dk?= =?utf-8?B?dWlDcURLSE81K0FGaUtYbkdUL0FPUWZpME94djVkMVR4RS95eU9sR1JqNVpX?= =?utf-8?Q?FWHWGxOrCvE8TYavwwMRjjIK1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b73baaa-af5e-4ce8-baae-08da64b0dac2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:19:57.4656 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZyFvZzwNx4CpfTdtb6VsaBnE4Vk5+fz5JJsjQ5r1T8WKHaubReph7QJsOd2OppTfJP4qYS1ESOcQFTMjBKChAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6248 Check the retrieved grant reference first; there's no point trying to have xennet_move_rx_slot() move invalid data (and further defer recognition of the issue, likely making diagnosis yet more difficult). Signed-off-by: Jan Beulich --- I question the log message claiming a bad ID (which is how I read its wording): rx->id isn't involved in determining ref. I don't see what else to usefully log, though, yet making the message just "Bad rx response" also doesn't look very useful. --- a/drivers/net/xen-netfront.c +++ b/drivers/net/xen-netfront.c @@ -1043,16 +1043,6 @@ static int xennet_get_responses(struct n } for (;;) { - if (unlikely(rx->status < 0 || - rx->offset + rx->status > XEN_PAGE_SIZE)) { - if (net_ratelimit()) - dev_warn(dev, "rx->offset: %u, size: %d\n", - rx->offset, rx->status); - xennet_move_rx_slot(queue, skb, ref); - err = -EINVAL; - goto next; - } - /* * This definitely indicates a bug, either in this driver or in * the backend driver. In future this should flag the bad @@ -1065,6 +1055,16 @@ static int xennet_get_responses(struct n err = -EINVAL; goto next; } + + if (unlikely(rx->status < 0 || + rx->offset + rx->status > XEN_PAGE_SIZE)) { + if (net_ratelimit()) + dev_warn(dev, "rx->offset: %u, size: %d\n", + rx->offset, rx->status); + xennet_move_rx_slot(queue, skb, ref); + err = -EINVAL; + goto next; + } if (!gnttab_end_foreign_access_ref(ref)) { dev_alert(dev, From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:27:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:27:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366346.597100 (Exim 4.92) (envelope-from ) id 1oBYem-0000X1-Qn; Wed, 13 Jul 2022 09:27:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366346.597100; Wed, 13 Jul 2022 09:27:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYem-0000Wu-Lv; Wed, 13 Jul 2022 09:27:44 +0000 Received: by outflank-mailman (input) for mailman id 366346; Wed, 13 Jul 2022 09:27:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYel-0000Wb-HE for xen-devel@lists.xen.org; Wed, 13 Jul 2022 09:27:43 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09379fc6-028e-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:27:40 +0200 (CEST) Received: from mail-bn7nam10lp2108.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.108]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Jul 2022 05:27:36 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6040.namprd03.prod.outlook.com (2603:10b6:208:316::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 09:27:34 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 09:27:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09379fc6-028e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657704460; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jag+bhiISty7hZB+fsK/uxdv1w8qJWzpYO6bz+oiOVs=; b=NDVTQbMnclSDN4cL5p0QxGTe8T9m3xhN+BGeCqLTUiDTIz5LtozBFc8c Wnoig6UdHm0gHO5ekpnrxj8f5mh90mjhKuf9gs+fNTfsd1xnmhAPxcv3x Uc5AFPREFBVH2PFfdxsHXLxybB32NP8nVtNegsDzYhubCJ19lvmlaRNef o=; X-IronPort-RemoteIP: 104.47.70.108 X-IronPort-MID: 75709914 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:yBfeTa7mFnqANrvdqNwE4wxRtOXGchMFZxGqfqrLsTDasY5as4F+v jAdWW2BaPbYZDGjf91/bdm+pBxX7JOGn4dhSVNuqCowHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw03qPp8Zj2tQy2YfgWFvU0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurTzY1l2B6bvm90yVilAUBN6L4pjpOLYdC3XXcy7lyUqclPK6tA3VAQcG9Jd/ex6R2ZT6 fYfNTYBKAiZgP67y666Te8qgdk/KM7sP8UUvXQIITPxVK56B8ycBfqSo4YAjF/chegXdRraT +MfZSBic1LrZBpXN01MIJk/gP2plj/0dDgwRFe9+vdouzmClVAZPL7FDd7ZI9yqaNRuj22qo VjgoXneIkwVHYnKodaC2jf27gPVpgvwUZgUFbmQ+vNggVSVgGsJB3U+UkCg5OK0gVOkWs5OA 0gV4TY1668q+Uq0R935GRa/pRasrhMaHtNWFeon7gqA4q7V+BqCQHgJSHhGctNOnN87Q3km2 0GEm/vtBCdzq/uFRHTb8a2bxRuiNC5QMHQPfzQsSQoe/8KlsIw1yBXVQb5LC6O+k8f0BSC13 z2DqW07irAZgNQQ/7W2+xbAmT3Em3TSZgs85wGSVGT66Ap8Pdahf9bxsQid6utcJoGESFXHp GIDh8WV8OEJC9eKiTCJR+IOWrqu4p5pLQHhvLKmJLF5nxzFxpJpVdo4DO1WTKuxDvs5RA== IronPort-HdrOrdr: A9a23:dGauAKs7/PrtNSiL/4QBbpEx7skC1YMji2hC6mlwRA09TyXGra 2TdaUgvyMc1gx7ZJh5o6H6BEGBKUmslqKceeEqTPqftXrdyRGVxeZZnMffKlzbamfDH4tmuZ uIHJIOb+EYYWIasS++2njBLz9C+qjJzEnLv5a5854Fd2gDBM9dBkVCe3+m+yZNNWt77O8CZf 6hD7181l+dkBosDviTNz0gZazuttfLnJXpbVotHBg88jSDijuu9frTDwWY9g12aUIP/Z4StU z+1yDp7KSqtP+2jjXG0XXI0phQkNz9jvNeGc23jNQPIDmEsHfpWG0hYczAgNkGmpDr1L8Yqq iJn/7mBbU115rlRBD2nfIq4Xin7N9h0Q669bbSuwqfnSWwfkNHNyMGv/MWTvKR0TtfgDk3up g7oF6xpt5ZCwjNkz/64MWNXxZ2llCsqX5niuILiWdDOLFuIYO5gLZvi3+9Kq1wah7S+cQiCq 1jHcvc7PFZfReTaG3YpHBmxJipUm4oFhmLT0AesojNugIm10xR3g8d3ogSj30A/JUyR91N4P nFKL1hkPVLQtUNZaxwCe8dSY+8C3DLQxjLLGWOSG6XXJ0vKjbIsdr68b817OaldNgBy4Yzgo 3IVBdCuWs7ayvVeLmzNV1wg2XwqUmGLETQI5tllulEU5XHNcnWGDzGTkwymM29pPhaCtHHWp +ISeBrP8M= X-IronPort-AV: E=Sophos;i="5.92,267,1650945600"; d="scan'208";a="75709914" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l7LNRhgFB5N1TXF80HahWsaOthkts1eNt8asdSl7wjZZD+mKCUG6IpaLlJ2ZohSGW8PZ9G9pCBddoeOIkIWrumHUXJtRWkRw5Ogr1GXuLqAesnqIWAlRJkNSL3PnkFWwJdaiuHF5dSCnGTGNjVvOPh7Fkgco2qPiB6OnB17+YE5ym67jYZCu3gr5NTJhEGK+Fe8x7W8mqHhYrijTPsWu/yGSkptuCSoZDSGJJXQaWnkyn1C/1dNd5P8LD+hyezwaAXiMlg7k4BtL1OHKEctlGhuepUi5ESt/vIO6oaE39I3TJHWQrV4MAxBmrq5njt0RcB+WnxY23b8a1vhtOeMUtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jag+bhiISty7hZB+fsK/uxdv1w8qJWzpYO6bz+oiOVs=; b=bOQFThAP+WMP3VOqSF4kNRarSdiLT3Tv2fbc9MABMJpcyOiLomrPBtC/yIW33Cnpg3akK0PlVcHC+wd1BwbSVLRC9Scfg3VCsLplbwjTCZbwQ8g4lbIT7xXrzy57LTEyEVz/YhhKhBbBjIFb4+0rOV8GhQGkwAvuuB714oe0DHunr3E48HpNeNlgkAIGaNOMsB7Cep5xbzPFJqlw8Lr8m/TE/1tbZ8U0gGZNL7JUrGc9CCSmlM/Ce+G7LosswmXb5rzJLyw73cqIF8bK2qhs3EKZIhxrZ1yrorT5sH9kLDliToNotpDRDFwoXy4aYM9gqTSfVE+P5qnDKSpQliEimw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jag+bhiISty7hZB+fsK/uxdv1w8qJWzpYO6bz+oiOVs=; b=R1i1ZITVB10HbyzRHJbHQsKWLcSSN/dmFwd/7WnJb8howkCSOXzVzroTTWz18QPTIE6j8+gwFP2XYVTaDaQqeFTmfE3zy5s/RvAklYCGaciykhlVb/pbKtOi7arvRgQ8S4t8j6ssi1sH6COZTWw8a6IMhIwnosbig3/ULauERXE= From: Andrew Cooper To: Salvatore Bonaccorso , "oss-security@lists.openwall.com" CC: "xen-announce@lists.xen.org" , "xen-devel@lists.xen.org" , "xen-users@lists.xen.org" , Xen.org security team Subject: Re: [oss-security] Xen Security Advisory 407 v1 (CVE-2022-23816,CVE-2022-23825,CVE-2022-29900) - Retbleed - arbitrary speculative code execution with return instructions Thread-Topic: [oss-security] Xen Security Advisory 407 v1 (CVE-2022-23816,CVE-2022-23825,CVE-2022-29900) - Retbleed - arbitrary speculative code execution with return instructions Thread-Index: AQHYlg2ccsX8+KDnKEKtDRtooLJ01a17HqSAgAACEACAAOjBAA== Date: Wed, 13 Jul 2022 09:27:34 +0000 Message-ID: <57b84d81-b689-f05f-d4a8-9967078fdc04@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40f90482-b21d-4f98-1697-08da64b1eb3e x-ms-traffictypediagnostic: BL1PR03MB6040:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VRiHG5EumGCYwOnePtUOYjuej3lAqJ4A9asROr43AiZwMKuNICXTbtkAf2PoSMtR0UihWMLebaZ39gjse5+Hd0UDNDLZpzMd02NXq0jpawkKUQmh6SP7dmp/JuTD2tYrw0vjS9A8l8vkokoGyStsXk09YYXi1APRu20Rck6h03hdDC3EqamPfmgvBONFmrp7vNVd0ezghl1Bgq9JiHmIl76tkdxF2Y3X2tjkWV6ZZBUJntjsi2Nc+JLfppa6Ik0Qgxsg3Bl2KlSPYk44SKOQHYZYK3+PgFen8EC/dted5tOckUqCyqbF4/WrXkQdojWvjilzlE5WSCRHp7eeGpkuhoHPcLG1xp5aZZbOyMYWOYXBUCYM15gTIIsJV+rd9U05hLqz7uHjAFYqOGZ+4ByPjD4emRtLOdnT23IR5PZORDus3AUltwxCONa9R/MPmEjAhGbB4WMjshHnei/S3E2I/KYWjX8fOTxSV4GrgF0Ms3yVBR9hbq+hzd/BzREbLy4PHlB6BHOal/L6Fa/q6XX/MYodvmupJx1FD4I8JgKz5vd7AVtyC2Xzas+2G6WxhiLI0JF9YQHSbpqFaHGkYTkgSy31JsFbqijy17QSeHivSEi5WtfoPD7/2RQKXtOT+O87BuaAJM9HJhjqpBZ6eumdtRKF2DZAEYXTWM3EN+9AR1Vq+UxQ2QWOVWvfIC1Up1d01sBoT3gsMZHnPXTTkn1HAQPll1OYvAoOLtziJ08CEoN06ETT+Ru3bpSaDgTBR9o4jt6qJImAy++qi3eR8L7gSdjOeNd6IaePRdQ06KZa9ebgdqV95AxBcdxV8LLTKs4IkOuNxI8mCmQhBiIFAGHC+59rtHqNZsDGJ17Xs6VW58XmEnh10q0y5wVYpjI2kqV2BwKosKnQ2+ek+n/04bytwTX0r77CbsnSor64ywRV9h8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(366004)(396003)(39860400002)(376002)(186003)(82960400001)(38100700002)(2616005)(38070700005)(31686004)(15650500001)(2906002)(36756003)(5660300002)(8936002)(66446008)(8676002)(66556008)(66946007)(66476007)(71200400001)(41300700001)(122000001)(966005)(26005)(6486002)(6512007)(6506007)(478600001)(53546011)(4326008)(83380400001)(76116006)(86362001)(91956017)(31696002)(110136005)(54906003)(64756008)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OWRQRUd0Y2JBNXFDck9ZVGQvV01jVTN2WjdFSEdxcVNac3VFNUtCN1F6WXlO?= =?utf-8?B?d3ZZREpjTWFGTnRPblZhTTJZZVVSMldQZkpnL1pSNkE3MWk4NlBPSkt0R1F3?= =?utf-8?B?amZlbi93bG9BdzVOYVg2Tkg1b3NuUFJKUlFHc0dZUHdMS1RGOWFEYXRrdGxn?= =?utf-8?B?TUFWSXpQVkdoNGxRR3FmUFpRSnl4OCs5eDdWQWJnREwwQ2didzhqSVB0Z3ll?= =?utf-8?B?ZnVndC9hWTBmTkZFVkdabmtYd2piZGZ3M0pLWW8wRFB5ZUtrU2pzVzlYRzl0?= =?utf-8?B?WmhyeFBQRGhtOWFhcUNEa0hQQkJaYnU3eUJDOHptVG5uZGFtZVJ6ODY1c0pm?= =?utf-8?B?ZjlBK2lDbUtpNHFNdnczdWt2eW4zdHpQV21hOWJPbnBMa2R5cUxRVGpYSFc5?= =?utf-8?B?M2xoZ1NrRHJySHR3V0RzTU5VUHVuMlp5aTJQK0ZzM1BjeXRIQStrME1GVlp3?= =?utf-8?B?T0Rwd1AxYTR3TjQ2Nm9TVnNxNG9NQWZ5MXZ3VUNYdEpTUmJMN0drUVh4TW5q?= =?utf-8?B?dnlaVnhVRGpFWjlQeTR4aVFhdFZKc2xHZ0Y2Y0NlV1MzNktWVlBGUmY5SlFx?= =?utf-8?B?SUdSeXZ1Y1ZtMU9PaHJHY0JQbUxodVJDNTA1TFRCWmsrLzIwQnFSQUxmSGx4?= =?utf-8?B?NHkrM1U4TXRrcE1HWGMrejNSVWtlZFhTME82aHlleHJxT1V3ZzViSjRuMjYr?= =?utf-8?B?ZVRnelMydnEzMmVPTzJxeTF3Q3FCUnlqQkNLMHkxczZIZHo2UnNZTG42UWtV?= =?utf-8?B?K3NpdzBtbzhKRGJKRldaSWcwYnZiWGNGV3ZiY3o2bW1YektLd3FZd0dUUEp1?= =?utf-8?B?OFBrT3JjdXJISzdyWEE0SXVUemc1MDZYdW5HYlV3dVoxZTdOdHBkSUtnc211?= =?utf-8?B?NXl4YmwxR1k4a0xweUNkWVpSbnNUNUdkblR2SWZtSEFYR0dUYWFBT1FMMTlr?= =?utf-8?B?TTEzNS9JSnJKNS9GR2E3NnZZbnlaWnJLSTVJK3I3bGRzRjR6TG1FbVdwdS9Y?= =?utf-8?B?bG1PS2dTMklRQjNSaEVJWnFlNFdaSmZUSzErK0pYdnhPVFoxMU1zcUhhUEZS?= =?utf-8?B?cHlpenRRcXdPRmFrYjNpSGd1RjlqUnBIWjZlWGZkRVFNTkNMMW8zd1JHNk51?= =?utf-8?B?WmYzRlhTbHhvaDVaT2ZkcVhqTWlTdlAwNjZhRXNIZ1g4TW02WDhxWDFrcGxx?= =?utf-8?B?d1BzMzd6SitEOHRCZ3pSQ21mK1hiRWNsRDRha3hCQnEybkNOcDVZQVFTMzJk?= =?utf-8?B?VWpUanNpampvR3ZhK0dicm83cHl3OXFCbWtmS2h5b25DNTJVb2U4T0xIbXVi?= =?utf-8?B?ZWtGbDFXaFVjTkxReXZjTG9RZlh5S2tpeldJenpLMHJwbXNITWcvTlIrTEdj?= =?utf-8?B?NmtRTEZtdUQraHJjZ3EvRUJ6bGRlYVF3aFYzdlgxU1gweWRGd0JLMC8vMkpj?= =?utf-8?B?OWdTV3l3WXhpbEtaUTV2ZVo4OU9aSFBXN1FXYmh5cURzc0xZY3J5QktiMy8r?= =?utf-8?B?eUgxYVBMYlNMK29uRVd6cFpyaHdqQWFCOEY4REdObmNxM2VxcnBPL21VaEhM?= =?utf-8?B?ditRbjJDeDRoVkVvdWdIL0VMN1pab01KbXRRakdObGlWRnBrMlVvRmFZOXhW?= =?utf-8?B?NThocnllU2wrQWhiTERYdk9JV3JQTXJRNmNqQk84ak9NMG5JQkQrcUxPK3Y4?= =?utf-8?B?VENVLyt2ckl1dXpCTDMrRXNXWHlLS3FRMjlkMElXQ05QUjIvVndtNmhOcExE?= =?utf-8?B?Q0JxbGZ3R056N3JTSUt3TUdiUmRXaU9xcjNDbnV4QlU3a3V3eUg2Nlk3ZTZI?= =?utf-8?B?YXJ4SHZYQ0lTWFhCcVdMME1JMFUzSWxuRmZEZjkxQnBpdmY3Zi9jdXRKcjBQ?= =?utf-8?B?bFZaNHFjeHo2Q1grMGJKS1V2R1F2eXFvaHl0VlUwMWVTSldOcjlmNjlLcGJv?= =?utf-8?B?bVBoc2JTYzdXV3dEUFZNajNTblpzRDFLMXNZK2JsY1k2RnNYaWErRDIvbjlJ?= =?utf-8?B?TXkvd2QvTUhBSXFHRUltVlJrU1pFdW9LYkx5eUI0TUdLSFNvWjh1bXgra2xX?= =?utf-8?B?QXE1QXM0YVNHQzMzdWl1WWZQaW8wZ09oVE84QWQ0Y0hUSTZCcnhLc1g1TWxp?= =?utf-8?Q?KvwAZmPfGNty4U+Q+98FwiOrs?= Content-Type: text/plain; charset="utf-8" Content-ID: <1EA07CD1ECC1734594816B8F3F7D4A64@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40f90482-b21d-4f98-1697-08da64b1eb3e X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 09:27:34.4581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SPV8f463YWgdg4abjKjVpd56vzmgdqnKbAjEGeknYrhGTA5dxADVlmhs0ABeZRFd33y8Bdvkjcdlh+B4S9Y4GJ8GAg7S0kxHPI1FPCYBC08= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6040 T24gMTIvMDcvMjAyMiAyMDozNCwgU2FsdmF0b3JlIEJvbmFjY29yc28gd3JvdGU6DQo+IEhpLA0K Pg0KPiBPbiBUdWUsIEp1bCAxMiwgMjAyMiBhdCAwOToyNzowN1BNICswMjAwLCBTYWx2YXRvcmUg Qm9uYWNjb3JzbyB3cm90ZToNCj4+IEhpLA0KPj4NCj4+IE9uIFR1ZSwgSnVsIDEyLCAyMDIyIGF0 IDA0OjM2OjEwUE0gKzAwMDAsIFhlbi5vcmcgc2VjdXJpdHkgdGVhbSB3cm90ZToNCj4+PiAtLS0t LUJFR0lOIFBHUCBTSUdORUQgTUVTU0FHRS0tLS0tDQo+Pj4gSGFzaDogU0hBMjU2DQo+Pj4NCj4+ PiAgWGVuIFNlY3VyaXR5IEFkdmlzb3J5IENWRS0yMDIyLTIzODE2LENWRS0yMDIyLTIzODI1LENW RS0yMDIyLTI5OTAwIC8gWFNBLTQwNw0KPj4+DQo+Pj4gICAgUmV0YmxlZWQgLSBhcmJpdHJhcnkg c3BlY3VsYXRpdmUgY29kZSBleGVjdXRpb24gd2l0aCByZXR1cm4gaW5zdHJ1Y3Rpb25zDQo+Pj4N Cj4+PiBJU1NVRSBERVNDUklQVElPTg0KPj4+ID09PT09PT09PT09PT09PT09DQo+Pj4NCj4+PiBS ZXNlYXJjaGVycyBhdCBFVEggWnVyaWNoIGhhdmUgZGlzY292ZXJlZCBSZXRibGVlZCwgYWxsb3dp bmcgZm9yDQo+Pj4gYXJiaXRyYXJ5IHNwZWN1bGF0aXZlIGV4ZWN1dGlvbiBpbiBhIHZpY3RpbSBj b250ZXh0Lg0KPj4+DQo+Pj4gRm9yIG1vcmUgZGV0YWlscywgc2VlOg0KPj4+ICAgaHR0cHM6Ly9j b21zZWMuZXRoei5jaC9yZXRibGVlZA0KPj4+DQo+Pj4gRVRIIFp1cmljaCBoYXZlIGFsbG9jYXRl ZCBDVkUtMjAyMi0yOTkwMCBmb3IgQU1EIGFuZCBDVkUtMjAyMi0yOTkwMSBmb3INCj4+PiBJbnRl bC4NCj4+Pg0KPj4+IERlc3BpdGUgdGhlIHNpbWlsYXIgcHJlY29uZGl0aW9ucywgdGhlc2UgYXJl IHZlcnkgZGlmZmVyZW50DQo+Pj4gbWljcm9hcmNoaXRlY3R1cmFsIGJlaGF2aW91cnMgYmV0d2Vl biB2ZW5kb3JzLg0KPj4+DQo+Pj4gT24gQU1EIENQVXMsIFJldGJsZWVkIGlzIG9uZSBzcGVjaWZp YyBpbnN0YW5jZSBvZiBhIG1vcmUgZ2VuZXJhbA0KPj4+IG1pY3JvYXJjaGl0ZWN0dXJhbCBiZWhh dmlvdXIgY2FsbGVkIEJyYW5jaCBUeXBlIENvbmZ1c2lvbi4gIEFNRCBoYXZlDQo+Pj4gYXNzaWdu ZWQgQ1ZFLTIwMjItMjM4MTYgKFJldGJsZWVkKSBhbmQgQ1ZFLTIwMjItMjM4MjUgKEJyYW5jaCBU eXBlDQo+Pj4gQ29uZnVzaW9uKS4NCj4+Pg0KPj4+IEZvciBtb3JlIGRldGFpbHMsIHNlZToNCj4+ PiAgIGh0dHBzOi8vd3d3LmFtZC5jb20vZW4vY29ycG9yYXRlL3Byb2R1Y3Qtc2VjdXJpdHkvYnVs bGV0aW4vYW1kLXNiLTEwMzcNCj4+IElzIGl0IGNvbmZpcm1lZCB0aGF0IEFNRCBpcyBub3QgdXNp bmcgQ1ZFLTIwMjItMjk5MDA/IFRoZSBhYm92ZQ0KPj4gYW1kLXNiLTEwMzcgcmVmZXJlbmNlcyBh cyB3ZWxsIGJvdGggQ1ZFLTIwMjItMjM4MjUgKEJyYW5jaCBUeXBlDQo+PiBDb25mdXNpb24pIGFu ZCBDVkUtMjAyMi0yOTkwMCAoUkVUYmxlZWQpLCBzbyBJIGFzc3VtZSB0aGV5IGFncmVlZCB0bw0K Pj4gdXNlIENWRS0yMDIyLTI5OTAwIGZvciByZXRibGVlZD8NCj4+DQo+PiBTbyBzaG91bGQgdGhl IFhlbiBhZHZpc29yeSBhcyB3ZWxsIHVzZSBDVkUtMjAyMi0yMzgyNSxDVkUtMjAyMi0yOTkwMA0K Pj4gYW5kIENWRS0yMDIyLTI5OTAxPw0KPiBOZXZlcm1pbmQsIEkgbWlzc3VuZGVyc3Rvb2QgdGhl IHdvcmRpbmcgYW5kIHRoZSBhZHZpc29yeSBqdXN0IG1lbnRpb25zDQo+IGFsbCB0aGUgcmVsYXRl ZCBDVkVzIGNvcnJlY3RseSBhbmQgbWFkZSBhIHRoaW5rby4gSXQgbWlnaHQgdHVybiBvdXQNCj4g dGhhdCBDVkUtMjAyMi0yMzgxNiB3aWxsIG5vdCBiZSB1c2VkLCBidXQgdGhlbiB0aGUgdGl0bGUg d291bGQgcmVhZA0KPiBvbmx5IGFzIA0KPg0KPiBYZW4gU2VjdXJpdHkgQWR2aXNvcnkgQ1ZFLTIw MjItMjM4MjUsQ1ZFLTIwMjItMjk5MDAgLyBYU0EtNDA3DQo+DQo+IFNvIHBsZWFzZSBkaXNyZWdh cmQgdGhlIHF1ZXN0aW9uIGFib3ZlLg0KDQovc2lnaA0KDQpBTUQgY2hhbmdlZCB0aGUgQ1ZFIGlu IHRoZSBidWxsZXRpbiBiZXR3ZWVuIHRoZSBmaW5hbCBkcmFmdCwgYW5kIHdoYXQNCndlbnQgcHVi bGljLg0KDQpDVkUtMjAyMi0yMzgxNiBoYXMgYmVlbiByZWZlcmVuY2VkIGJ5IG11bHRpcGxlIG90 aGVyIHZlbmRvcnMgdG9vLCBzbyBpcw0KZGVmaW5pdGVseSBvdXQgaW4gdGhlIHdvcmxkLsKgIEhv cGVmdWxseSBNSVRSRSB3aWxsIGNsb3NlIG91dCBvbmUgb2YNCkNWRS0yMDIyLTIzODE2IGFuZCBD VkUtMjAyMi0yOTkwMCBhcyBhIGR1cCBvZiB0aGUgb3RoZXIuDQoNCkZvciBub3csIEkgdGhpbmsg dGhlIGxlYXN0IGNvbmZ1c2luZyBvcHRpb24gaXMgdG8ga2VlcCBib3RoIHJlZmVyZW5jZWQuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:31:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:31:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366374.597129 (Exim 4.92) (envelope-from ) id 1oBYi8-0002xa-Rw; Wed, 13 Jul 2022 09:31:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366374.597129; Wed, 13 Jul 2022 09:31:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYi8-0002xT-Ne; Wed, 13 Jul 2022 09:31:12 +0000 Received: by outflank-mailman (input) for mailman id 366374; Wed, 13 Jul 2022 09:31:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYi6-0002xK-J1 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:31:10 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8648d063-028e-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:31:09 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 97AC52264F; Wed, 13 Jul 2022 09:31:07 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4FB5013AAD; Wed, 13 Jul 2022 09:31:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id b6YCEtuQzmJdVQAAMHmgww (envelope-from ); Wed, 13 Jul 2022 09:31:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8648d063-028e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657704667; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DIxquxVL5zbp2920oTPlSbhhclREtQVqn63Qo4GU0go=; b=X/uclUEeLzLDpRVpyUSDvgdugQY7waFRhQ+H6LpGkNcVa0vuuQIZj9Gf04dLoilykNcdAb 1DzXNi2JkSf3QxZVzbjbQ2ly7IfXrhbZf1a9ATSV7P2JKaKY7FJyNkmdZowuCnnvDDhs2s J3WAyYcB9PwPDzj/MsjHUBlPVFbrPPI= Message-ID: Date: Wed, 13 Jul 2022 11:31:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220713074823.5679-1-jgross@suse.com> <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> From: Juergen Gross Subject: Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() In-Reply-To: <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------WdLJwO96tyF2VuhTG3qIw0Ru" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------WdLJwO96tyF2VuhTG3qIw0Ru Content-Type: multipart/mixed; boundary="------------aDnQdL3LsHraZxZf03Wd7ZQr"; protected-headers="v1" From: Juergen Gross To: Jan Beulich Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() References: <20220713074823.5679-1-jgross@suse.com> <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> In-Reply-To: <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> --------------aDnQdL3LsHraZxZf03Wd7ZQr Content-Type: multipart/mixed; boundary="------------YhKZd05g8gBi6510GVqI0nZj" --------------YhKZd05g8gBi6510GVqI0nZj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDcuMjIgMDk6NTksIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMy4wNy4yMDIy IDA5OjQ4LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4geGVudmlmX3J4X25leHRfc2tiKCkg aXMgZXhwZWN0aW5nIHRoZSByeCBxdWV1ZSBub3QgYmVpbmcgZW1wdHksIGJ1dA0KPj4gaW4g Y2FzZSB0aGUgbG9vcCBpbiB4ZW52aWZfcnhfYWN0aW9uKCkgaXMgZG9pbmcgbXVsdGlwbGUg aXRlcmF0aW9ucywNCj4+IHRoZSBhdmFpbGFiaWxpdHkgb2YgYW5vdGhlciBza2IgaW4gdGhl IHJ4IHF1ZXVlIGlzIG5vdCBiZWluZyBjaGVja2VkLg0KPj4NCj4+IFRoaXMgY2FuIGxlYWQg dG8gY3Jhc2hlczoNCj4+DQo+PiBbNDAwNzIuNTM3MjYxXSBCVUc6IHVuYWJsZSB0byBoYW5k bGUga2VybmVsIE5VTEwgcG9pbnRlciBkZXJlZmVyZW5jZSBhdCAwMDAwMDAwMDAwMDAwMDgw DQo+PiBbNDAwNzIuNTM3NDA3XSBJUDogeGVudmlmX3J4X3NrYisweDIzLzB4NTkwIFt4ZW5f bmV0YmFja10NCj4+IFs0MDA3Mi41Mzc1MzRdIFBHRCAwIFA0RCAwDQo+PiBbNDAwNzIuNTM3 NjQ0XSBPb3BzOiAwMDAwIFsjMV0gU01QIE5PUFRJDQo+PiBbNDAwNzIuNTM3NzQ5XSBDUFU6 IDAgUElEOiAxMjUwNSBDb21tOiB2MS1jNDAyNDctcTItZ3UgTm90IHRhaW50ZWQgNC4xMi4x NC0xMjIuMTIxLWRlZmF1bHQgIzEgU0xFMTItU1A1DQo+PiBbNDAwNzIuNTM3ODY3XSBIYXJk d2FyZSBuYW1lOiBIUCBQcm9MaWFudCBETDU4MCBHZW45L1Byb0xpYW50IERMNTgwIEdlbjks IEJJT1MgVTE3IDExLzIzLzIwMjENCj4+IFs0MDA3Mi41Mzc5OTldIHRhc2s6IGZmZmY4ODA0 MzNiMzgxMDAgdGFzay5zdGFjazogZmZmZmM5MDA0M2Q0MDAwMA0KPj4gWzQwMDcyLjUzODEx Ml0gUklQOiBlMDMwOnhlbnZpZl9yeF9za2IrMHgyMy8weDU5MCBbeGVuX25ldGJhY2tdDQo+ PiBbNDAwNzIuNTM4MjE3XSBSU1A6IGUwMmI6ZmZmZmM5MDA0M2Q0M2RlMCBFRkxBR1M6IDAw MDEwMjQ2DQo+PiBbNDAwNzIuNTM4MzE5XSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiBm ZmZmYzkwMDQzY2Q3Y2QwIFJDWDogMDAwMDAwMDAwMDAwMDBmNw0KPj4gWzQwMDcyLjUzODQz MF0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJTSTogMDAwMDAwMDAwMDAwMDAwNiBSREk6IGZm ZmZjOTAwNDNkNDNkZjgNCj4+IFs0MDA3Mi41Mzg1MzFdIFJCUDogMDAwMDAwMDAwMDAwMDAz ZiBSMDg6IDAwMDA3N2ZmODAwMDAwMDAgUjA5OiAwMDAwMDAwMDAwMDAwMDA4DQo+PiBbNDAw NzIuNTM4NjQ0XSBSMTA6IDAwMDAwMDAwMDAwMDdmZjAgUjExOiAwMDAwMDAwMDAwMDAwOGY2 IFIxMjogZmZmZmM5MDA0M2NlMjcwOA0KPj4gWzQwMDcyLjUzODc0NV0gUjEzOiAwMDAwMDAw MDAwMDAwMDAwIFIxNDogZmZmZmM5MDA0M2Q0M2VkMCBSMTU6IGZmZmY4ODA0M2VhNzQ4YzAN Cj4+IFs0MDA3Mi41Mzg4NjFdIEZTOiAwMDAwMDAwMDAwMDAwMDAwKDAwMDApIEdTOmZmZmY4 ODA0ODQ2MDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMA0KPj4gWzQwMDcyLjUz ODk4OF0gQ1M6IGUwMzMgRFM6IDAwMDAgRVM6IDAwMDAgQ1IwOiAwMDAwMDAwMDgwMDUwMDMz DQo+PiBbNDAwNzIuNTM5MDg4XSBDUjI6IDAwMDAwMDAwMDAwMDAwODAgQ1IzOiAwMDAwMDAw NDA3YWM4MDAwIENSNDogMDAwMDAwMDAwMDA0MDY2MA0KPj4gWzQwMDcyLjUzOTIxMV0gQ2Fs bCBUcmFjZToNCj4+IFs0MDA3Mi41MzkzMTldIHhlbnZpZl9yeF9hY3Rpb24rMHg3MS8weDkw IFt4ZW5fbmV0YmFja10NCj4+IFs0MDA3Mi41Mzk0MjldIHhlbnZpZl9rdGhyZWFkX2d1ZXN0 X3J4KzB4MTRhLzB4MjljIFt4ZW5fbmV0YmFja10NCj4+DQo+PiBGaXggdGhhdCBieSBzdG9w cGluZyB0aGUgbG9vcCBpbiBjYXNlIHRoZSByeCBxdWV1ZSBiZWNvbWVzIGVtcHR5Lg0KPj4N Cj4+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNvbT4NCj4g DQo+IFJldmlld2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IA0K PiBEb2VzIHRoaXMgd2FudCBhIEZpeGVzOiB0YWcgYW5kIENjOiB0byBzdGFibGVAIChub3Qg dGhlIGxlYXN0IHNpbmNlIGFzIHBlcg0KPiBhYm92ZSB0aGUgaXNzdWUgd2FzIG5vdGljZWQg d2l0aCA0LjEyLngpPw0KDQpIbW0sIEkgX3RoaW5rXyB0aGUgaXNzdWUgd2FzIGludHJvZHVj ZWQgd2l0aCBlYjE3MjNhMjliOWEuIERvIHlvdSBhZ3JlZT8NCg0KPiANCj4+IC0tLSBhL2Ry aXZlcnMvbmV0L3hlbi1uZXRiYWNrL3J4LmMNCj4+ICsrKyBiL2RyaXZlcnMvbmV0L3hlbi1u ZXRiYWNrL3J4LmMNCj4+IEBAIC00OTUsNiArNDk1LDcgQEAgdm9pZCB4ZW52aWZfcnhfYWN0 aW9uKHN0cnVjdCB4ZW52aWZfcXVldWUgKnF1ZXVlKQ0KPj4gICAJcXVldWUtPnJ4X2NvcHku Y29tcGxldGVkID0gJmNvbXBsZXRlZF9za2JzOw0KPj4gICANCj4+ICAgCXdoaWxlICh4ZW52 aWZfcnhfcmluZ19zbG90c19hdmFpbGFibGUocXVldWUpICYmDQo+PiArCSAgICAgICAhc2ti X3F1ZXVlX2VtcHR5KCZxdWV1ZS0+cnhfcXVldWUpICYmDQo+PiAgIAkgICAgICAgd29ya19k b25lIDwgUlhfQkFUQ0hfU0laRSkgew0KPj4gICAJCXhlbnZpZl9yeF9za2IocXVldWUpOw0K Pj4gICAJCXdvcmtfZG9uZSsrOw0KPiANCj4gSSBoYXZlIHRvIGFkbWl0IHRoYXQgSSBmaW5k IHRoZSB0aXRsZSBhIGxpdHRsZSBtaXNsZWFkaW5nIC0geW91IGRvbid0DQo+IGRlYWwgd2l0 aCB0aGUgaXNzdWUgX2luXyB4ZW52aWZfcnhfbmV4dF9za2IoKTsgeW91IGluc3RlYWQgYXZv aWQNCj4gZW50ZXJpbmcgdGhlIGZ1bmN0aW9uIGluIHN1Y2ggYSBjYXNlLg0KDQpJJ20gaGFu ZGxpbmcgdGhlIGlzc3VlIHRvIGF2b2lkICJhbiBlbXB0eSByeCBxdWV1ZSBpbiB4ZW52aWZf cnhfbmV4dF9za2IoKSIuDQoNCkkgY2FuIHJlcGhyYXNlIGl0IHRvICJhdm9pZCBlbnRlcmlu ZyB4ZW52aWZfcnhfbmV4dF9za2IoKSB3aXRoIGFuIGVtcHR5IHJ4DQpxdWV1ZSIuDQoNCg0K SnVlcmdlbg0K --------------YhKZd05g8gBi6510GVqI0nZj Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------YhKZd05g8gBi6510GVqI0nZj-- --------------aDnQdL3LsHraZxZf03Wd7ZQr-- --------------WdLJwO96tyF2VuhTG3qIw0Ru Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLOkNoFAwAAAAAACgkQsN6d1ii/Ey/d mAf+JrfpoIGp8Jw5O/VmP+rJvFPQim0YMGfWTtZGuBhBeTWOPmvhPTMCdf3y3p5XmixaJ+tZKist viAVYJAGkRjKiFU/Sul3HYMZ53AdlYFUcfC4kC5+/hWEhniCocH/wXF4yHMqe/JrT2Fcn2cyYE7o 3IR2yV5/HihSOTaR04/BPWHCcdlafXZFqelNa6Ki271zA8r2UKyqprY8KvAYA0rpwrYykDl8gTup 74SJtjkNb9Xx7J65lZzKtm3PXcqrudc3fMaAMAM6QHrF5xXO7Yo1Kq3R8BQOOU/kti0BbTS2ajgQ k0WGn4Etf0lgU6bu4GSdVMQg/JLvCC6RwTOdh2CQnQ== =tTz+ -----END PGP SIGNATURE----- --------------WdLJwO96tyF2VuhTG3qIw0Ru-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:36:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:36:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366390.597139 (Exim 4.92) (envelope-from ) id 1oBYmr-0003gF-DZ; Wed, 13 Jul 2022 09:36:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366390.597139; Wed, 13 Jul 2022 09:36:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYmr-0003g6-Ai; Wed, 13 Jul 2022 09:36:05 +0000 Received: by outflank-mailman (input) for mailman id 366390; Wed, 13 Jul 2022 09:36:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYmq-0003g0-2v for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:36:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYmo-0008SF-2A; Wed, 13 Jul 2022 09:36:02 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBYmn-000053-Qf; Wed, 13 Jul 2022 09:36:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=OiHqk2rfMx9azif91K01KAxc7RB7HIiarkj6RZsbFhk=; b=SYSuC0KfZP+YI9AHL4xaD/LcZR ff3hf1WRnlLZ9olMWwfyyw8DFSYFVbRyc/Dmuk7bP4f8ki+MSU8XNb9sc+HK7V6X1JgVL4EckG0AO txX7hWkuhbjKSN0RFkKUFSRVE9IN3fYFRCm3C2WOkj7QTnChFIevMQrujquk+X0ZBe74=; Message-ID: <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> Date: Wed, 13 Jul 2022 10:35:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Jan Beulich , Rahul Singh Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 13/07/2022 07:21, Jan Beulich wrote: >>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>> In this way, we can avoid allocating a lot of memory to fill the hole. >>> >>> Let me know your view on this. >>> >>> config MAX_STATIC_PORT >>> int "Maximum number of static ports” >>> range 1 4095 >>> help >>> Controls the build-time maximum number of static port supported >> >> The problem is not exclusive to the static event channel. So I don't >> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >> (even though this is the only user today). >> >> A few of alternative solutions: >> 1) Handle preemption in alloc_evtchn_bucket() >> 2) Allocate all the buckets when the domain is created (the max >> numbers event channel is known). We may need to think about preemption >> 3) Tweak is_port_valid() to check if the bucket is valid. This would >> introduce a couple of extra memory access (might be OK as the bucket >> would be accessed afterwards) and we would need to update some users. >> >> At the moment, 3) is appealing me the most. I would be interested to >> have an opionions from the other maintainers. > > Fwiw of the named alternatives I would also prefer 3. Whether things > really need generalizing at this point I'm not sure, though. I am worry that we may end up to forget that we had non-generaic way (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up to mistakenly introduce a security issue. However, my point was less about generalization but more about introducing CONFIG_MAX_STATIC_PORT. It seems strange to let the admin to decide the maximum number of static port supported. If we want to rely on non-generic mechanism, then I think the right way to go is to restrict max_evtchn_port for domUs to 4096 (it is -1 at the moment). If we want to give more flexibility then it should be a per-domain property in the DT. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:39:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:39:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366397.597151 (Exim 4.92) (envelope-from ) id 1oBYpt-0004IQ-TH; Wed, 13 Jul 2022 09:39:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366397.597151; Wed, 13 Jul 2022 09:39:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYpt-0004IJ-PI; Wed, 13 Jul 2022 09:39:13 +0000 Received: by outflank-mailman (input) for mailman id 366397; Wed, 13 Jul 2022 09:39:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYps-0004IA-S4 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:39:12 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20041.outbound.protection.outlook.com [40.107.2.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a66f6f13-028f-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 11:39:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB7076.eurprd04.prod.outlook.com (2603:10a6:208:19a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 09:39:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:39:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a66f6f13-028f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G4ldEDZqcsAo+P+wo+ABUjZEVbTsFaQcBlkmwp/L0iR8ZZ/jdy5f9CsdDilCSlZBV6OrWSn12fEzUnoZSVoW/GsL5tIWAll4wxO9q7ypcZ3s1vokNl3xqAJRM3kIl1AF1X9r9YM0Mx82H2EsVjEk7HY0fO0TDJMgf1yEf43ehKnx0twuvNgRxHud4iSR70AVmAlxxmqVEhVXKVkhAJezantJb0YmhplqpX6ephRuIWKXaO26B+KeZ+ggqCuFTqPG2MIKRIKJYAwnrMQhb8sRmOshvqAMDyqgzotxZ/twWKiknxoLpAwzWNNXNYKkNClQIXnjfiff726yVdVFeidReA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bMXty3YPnN5cNln86v4AQFa7MhRVjtynivzL9avrpPE=; b=DjYUff92kvnt9xdctED2WfTTK/kKWpoRziNy4nMkKasecEfx9hYM6wj8hCuj5ZZZHZNF8lacrP6t2Fe8TbNWAI1A5TTq2WwzbgYZG88sia+EbXaLYqSPkyT83R6+ipyP3AHs5sOISMLqs2D56USX7VkvK0zvqg/YFKu13QYsRfUQDp4c36H2d881Vv3M/TahmtKZsIC2ahq1ioDB9AA7QA5Qacnly7Z7JwKIoMMsOIAzXC1APeu1YX7hO4zCPe3M2Dl0WBXjCPebxi0MTLfSJuFnhk+4U6hID4a5sr+tmWlKT4Uymk+Jhgo3zNMbh6ITYmkWgc7uan0/YYAjItYb+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bMXty3YPnN5cNln86v4AQFa7MhRVjtynivzL9avrpPE=; b=FaTNun/2w53scN0Tf3ZzlMJL7tU9da6ME8Vyo+iEQtLNZRhJheNpm4Ur8N+1Z3V9gt3cY1S+y5g8uHjaJFBdeEFstEoji8PETaBLeaGg0dRYVQv+PJAzpG9GeBFXZ/sGkPXCQEjUk7Q6OONHFUqpfg1uRqCcPs0fnQWlYOs2WrzFCLyBiSqtCWe6nMv5xwJ2WD9Cn9uogTvgUItU7Wd95y9QLGKy3X+N1G/+Du/9pw01IWDJg/dk8y/uWIfgo8jVRw9LVw9KhdlLmc1Ja5PIEcCDNlJ6QBfMSWBRPEwiJPKmxTklaVEGyUdb2pCluqYQYphoCdapC7kep+4jBf3lzg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 11:39:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/9] console: support multiple serial console simultaneously Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 48f5fc1b-3c22-44f3-00c3-08da64b389b5 X-MS-TrafficTypeDiagnostic: AM0PR04MB7076:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eVqAKLtn2NhpFe7wf8bEkOYCHrpYTO6PcgI6+VMBoNANnIVjYF211Xjf6b2E7TCtXYivTjJzrprQxsnDkySbu8TKssM6ueliMTeytfEPVr0WC2MHvsLUY1ISdc6ss9fXnU5B1AvtastyBXvpatVRTLVL4mqKWSMGU+SaRKeTdk61LIpmFdJAulJDrAN5NR47+hseRrPLQQEUM7Dl4lPn6oDdZP2DO/eKkDYQ8jm5jeAC7giLySDs+6CHY9o1IlK49pfN73JbjurSuq6+HeTOq2jFnGxeupldHg5inp7ekjQYe8g7DB5z9X9qsU7G9IJjQ5wbmp9Nq97dPKnZ8czLyQcXixvaLjg3ky/crq9HCOFHReetunzXsjkdnVCpwbP+DOYFkiuENlj1+jvYx38fGUboecl4um2eHwrDwfuFOMofERGzzxXOfd7iU8MN9YjhEHOMjm9YtwQQbytJ4j614GjDIwmXwd3EzaayEdFIDYLE48WPu/frZWdap4KZtG4TArhPE/dJkMOSuiDKoFq767ApwtnF/5OdPg0x4mlfDnrdHGTYUbyEt/smpNsdGLYCYMrPclw9brB9BUvbEplehg8YuWUsRV2T48sSXL+M/oNa0lhiHF/DsTbISNpmVS9zGZN/dMbvioYBCWTjpeOSMbejR5duUPb/v+5hCeL5/EmhDy2kOkTFLBfrrSlU5IHdDVCtm2NVZQ4j3Y0KMlzitt+/Ol/E2qmDFBvVMbNQdPrBthW0zWlr59TPIiCFxc0KYTEvsgFHWRC7bTW9TP5uPPSJhNXXlm2770jyyv2zzJv1kdkVyGRIza0oeXwacmNTQgW/FPgrGAIFAzPXiYqOHg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(396003)(366004)(39860400002)(4326008)(5660300002)(8936002)(2906002)(83380400001)(38100700002)(6486002)(54906003)(478600001)(66476007)(186003)(6916009)(66946007)(6666004)(8676002)(26005)(2616005)(316002)(41300700001)(53546011)(66574015)(6506007)(31686004)(66556008)(86362001)(6512007)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVYzUHE4VTdQdzZlZmlRWU1FTStNM1gyRVZSOU82T1dGNTdnczE1TGU2STRx?= =?utf-8?B?TjhFRklOeHlBYWxYNWtucGI4bzA1eURXRW94bXo0VlRkMlNJUlkzRUZvcTI0?= =?utf-8?B?UTRWQlFRS3l6WjNtemk4OXZRYjdpYnl2L1BzaExkUEtkRVlSOHp5VTZlTmVG?= =?utf-8?B?djhkcDdtSUJtZU55eXBTbGhCUjhnQlRzVE1Gd2c2U3JBSjRtY2lhWE5teC9W?= =?utf-8?B?NmZRbCtRNmlna0F0bTgySWhVbkhmTS9wME1ENUNtakdRV3JzRUlKN2Vrd2FH?= =?utf-8?B?eWlrOWYxanlSdWhobmxhM0Z2eXRGb0JrSDlIYVQrWm0vbi9hRTRVR0llWHd2?= =?utf-8?B?SVpORE5yVE83T0ZBU2xDUUVuWFlmM0FnR0daaFZpZWhVZ2EyZitxc0tjRUlI?= =?utf-8?B?ZEFnbGNsTzJoaE14R0NQa3FEVjgrdnNVRC9OMlg3TU1nS2tQQ1NLOVJGZzhm?= =?utf-8?B?TnZHdThzcENMN08vYmdIbTcwdkFOS1c4VnE5Um5sRkNpcmI4dnVsVEkyM1Nk?= =?utf-8?B?MHdQZkkxclgrellzekFlU2xOWi9CWjhqdlNQWE92cGpHQTVuU0NIVGRVWFcv?= =?utf-8?B?cVVQQ2tZNHVZNVRpcGRsbmlueERFdzJ0Vk0rMmlPQm1aNThKb0pxcWZHS1ha?= =?utf-8?B?cEtiZmY1L245cnN6VzE3cDViOFBHaU5TMzI3N1h4Y2t3Y3pkSCtIQkJ1QUlv?= =?utf-8?B?cHJ1aWI1cTB5UE5wNThobTI0QnRVZmcrcFMrbWtLMTB0SFRaN2RLYlduOFlR?= =?utf-8?B?dllBWXVrdktXdkZHdjdYcDRWalIrbUQzWWh2aHVaUDZBSURHQklSZUVVUzBP?= =?utf-8?B?Y1VqREdVc0NwWW1waVBRQzFxYkQ0SURzOEt1Vy8ydmRDb2FvLy9hbWU2WFZX?= =?utf-8?B?amhBTkpMNTNzTEZ6UEpEREp5bXI5Q2VaQTY0U1RSMW9sYWdocHRocDRhMmhz?= =?utf-8?B?bTJoNW15bDhBbnN6V0h3VE0wOVJSU2drYnljcSt3U3lQb0NwZ0hDbTJqRity?= =?utf-8?B?b1ZudSt5WnFVV3BLUHN3dFlSY1YzKzE0eFFQYTFkTzY3bkRHc3VHaWJVTG1h?= =?utf-8?B?V3lqSkVvQzB0QWVtT2dmZzdiTHJTTFROTnlrWHBoL3lqclNwZHoxK1Y5ZGlk?= =?utf-8?B?OUdtR0hCZTdCTllTN09sSWdvWXBrdWtrM3JUcmlpVTBVaERKcllXUDRZMEM0?= =?utf-8?B?RlNlVGtXeUlvY2p0OFIrTHNsNUsxemxZelNhdk02b1NleHExNnhCQVBMa3Fk?= =?utf-8?B?WnhoenhMTzVYa3Rsa08yZlY0WHdXOG13bnFlc2hGWHpvZmFxaU1rU0VYcE9l?= =?utf-8?B?cXptdTI2WFFIaGhmbnQzTmpOcEFGekUvL0VMcFdTYlo5OEc0OG9qSUMrdlly?= =?utf-8?B?NWFHQ0pFRWFYVk9VYVZha3VTcjRCTHZqeFU2eis3dXJNVDVxRHMveEY5cVBL?= =?utf-8?B?Yk5SSkhlWFhOR3lsZDNhbWRjeTdFblkrWEh0WXpUMWtIQjVpWStrZ042bDZI?= =?utf-8?B?dVFZRXgzZnBoem1GMVlWbW8xL1hZbUdBNVlPdXJzbkY4TWNUWHVFQUxEMHBQ?= =?utf-8?B?Y3UraHNXMmx2WHRjRFM4NGRIQTlsMUNtQUhZYkt6WnNBdzd1Y2t0dFhxQ1Jn?= =?utf-8?B?cHN1R1RhOXpCWHJtMElQNzBnSHk2b0daTCtZVDJQakgyMW5YZVJhTkZveDZX?= =?utf-8?B?QTRjV1JwdmV5cGxhVW9hSEdGYkVsQnFQem83Y2thaWZBaHlSTFQyblZRQ3JB?= =?utf-8?B?T0o1R1dralZ3WDV3U3RTUzc0aTZMeG1BVmJKWnpEeUVoaTRVaGltUXRUNExT?= =?utf-8?B?NWozZkpFTEtOVHhtUUJRc2d5L2YzVTBZRm9VR3I4N2oxdlJYZVFHNSs3cWt6?= =?utf-8?B?bTBJOHFaejhBRnVsQWNKT0lMMDUrM3RiNXQ4bTR2U0ltUlZHc2h4RWpad3dz?= =?utf-8?B?SUJaaTRReXE0cTBHQkFvWHNRYnZJUFU2dVYxSE13Sm5TY243WE1mbU02dU51?= =?utf-8?B?aElTODdzNFpEaEZzY0xGZUVUV1NXeVhrZlZmeENWYVMwSkY5bWlndDIwSXpD?= =?utf-8?B?VjhDRjBwbVhTTWZYTWpSamQxVjR0SWNDM3pjcEZXemp2OFBqcHgyT3JDbE9t?= =?utf-8?Q?VShzbonR7YMXUTflV4GIVW1If?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 48f5fc1b-3c22-44f3-00c3-08da64b389b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:39:09.9704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cDCMxPXgeheVSlhrEw+XIMnI1yeHBZBYlGwIELB9nkdhi9j0Lriw+Z6txl4ix7VAMJChO6zUd4iXcfRBtqq0Hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7076 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > Previously only one serial console was supported at the same time. Using > console=com1,dbgp,vga silently ignored all but last serial console (in > this case: only dbgp and vga were active). > > Fix this by storing not a single sercon_handle, but an array of them, up > to MAX_SERCONS entries. The value of MAX_SERCONS (4) is arbitrary, > inspired by the number of SERHND_IDX values. > > Signed-off-by: Marek Marczykowski-Górecki > --- > xen/drivers/char/console.c | 58 ++++++++++++++++++++++++++++++--------- > 1 file changed, 45 insertions(+), 13 deletions(-) > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > index f9937c5134c0..44b703296487 100644 > --- a/xen/drivers/char/console.c > +++ b/xen/drivers/char/console.c > @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; > static uint32_t __read_mostly conring_size = _CONRING_SIZE; > static uint32_t conringc, conringp; > > -static int __read_mostly sercon_handle = -1; > +#define MAX_SERCONS 4 Might this want to be a Kconfig setting? > +static int __read_mostly sercon_handle[MAX_SERCONS]; > +static int __read_mostly nr_sercon_handle = 0; I would have wanted to ask for __ro_after_init here, but Arm still hasn't enabled support for it. > @@ -395,9 +397,17 @@ static unsigned int serial_rx_cons, serial_rx_prod; > > static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; > > +/* Redirect any console output to *fn*, if *handle* is configured as a console. */ > int console_steal(int handle, void (*fn)(const char *, size_t nr)) > { > - if ( (handle == -1) || (handle != sercon_handle) ) > + int i; unsigned int please (also elsewhere). > + if ( handle == -1 ) > + return 0; > + for ( i = 0; i < nr_sercon_handle; i++ ) > + if ( handle == sercon_handle[i] ) > + break; > + if ( nr_sercon_handle && i == nr_sercon_handle ) > return 0; No need for the left side of the &&, I think. I guess it's actively wrong to be there. > if ( serial_steal_fn != NULL ) I guess you then also want to make serial_steal_fn an array, and no longer return constant 1 from the function. > @@ -977,7 +990,8 @@ void __init console_init_preirq(void) > continue; > else if ( (sh = serial_parse_handle(p)) >= 0 ) > { > - sercon_handle = sh; > + if ( nr_sercon_handle < MAX_SERCONS ) > + sercon_handle[nr_sercon_handle++] = sh; else > @@ -1291,7 +1322,8 @@ static int suspend_steal_id; > > int console_suspend(void) > { > - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); > + if ( nr_sercon_handle ) > + suspend_steal_id = console_steal(sercon_handle[0], suspend_steal_fn); > serial_suspend(); > return 0; > } The commit message gives no explanation why only the first handle would want/need dealing with here. One overall remark: Especially with sync_console latency is going to be yet worse with all output being done sequentially. The help text for "console=" will want to mention this, up and until this would be parallelized. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:49:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:49:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366407.597162 (Exim 4.92) (envelope-from ) id 1oBYzT-0006Dy-V3; Wed, 13 Jul 2022 09:49:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366407.597162; Wed, 13 Jul 2022 09:49:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYzT-0006Dr-Rs; Wed, 13 Jul 2022 09:49:07 +0000 Received: by outflank-mailman (input) for mailman id 366407; Wed, 13 Jul 2022 09:49:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBYzS-0006Dl-F2 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:49:06 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2061.outbound.protection.outlook.com [40.107.21.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07faed02-0291-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:49:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9074.eurprd04.prod.outlook.com (2603:10a6:102:227::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 09:49:01 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:49:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07faed02-0291-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWZMk+o7vMNMJ6ipMVGKzWM8z5G5LKVHvMyE9Sjx+lCq3ExhH9feWu75+JB1PN3VAsIY9mZInnAtcfY6nYw9CWsd2+EItw2QxY4N/puaFIsZHU258+3WY3Ply8+sP7UBIeT94m8RvalpYZxFzYfvV1I7nSsOAgHPW29GqnlEBznf+YwJcR3lNSWO/+vb2phnDRZYgl7uSfQOjNYiD8L50/FRxSCxDg44okejyPiAH+aU4BcjCr0cAnQkJbcWkDMCUPIVAROUdBqTNy9rT3WrjzxCqJiuSnTGZAhXxoziSLXtz0x5y60VNl4yATKJWSorxgGEkn8n1Qy9H1ITBsKT2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQDHYXBSiqGtSfCtEQYakVQSucdfXKK79khOVuSY6Cg=; b=CASWgMXQANUMwAu+CylPIodwbChrlT0WZyhqHl1dv3UpfEtlWfSDrOmUqque+YTeedaX73hXLXkiRDCvfd/C9615LSb6tPQ8pVgbQbY0j2z4q0OlLbf47NchMfzyaSznGbe/mjU0YFtv9Ch3duyXs8PboFvFIkezKjDAZN/Vaovoe/122owHsXG0uI3yy5nhsXhs+l6I78DU4XaGQ5CGKg6oRBkCVShaUZzovsonKIgcpjNp07Be+5X+L6k1Vc/8B2pF6rne75d2QcVwJ1idZGRpQ7iN9mC6TQTqLLeUMcV5pHt6Gg6sfhcw2Ztsd4xHIaQ9A70X8vR0S5vPPWU87g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQDHYXBSiqGtSfCtEQYakVQSucdfXKK79khOVuSY6Cg=; b=AnuRwGnwQJn0szwVbtD3UECOKrQedDN2857U2DI91d32FAPjcEz2GhtgXD5cBh61ZrNjyCIvW6ADx2+2Ll05eWwVseWC6HfajB9DRZDXubzcp718Tc4vkEXrGQZfdqH4enVM0vg1PKXk+a8uBER8VppEKhWUpsgQauHW/wxheUgG301icm7U6SMtMpskCV75j1PFfjnX0TbfUF7JKWrJx356XR4LOTnAk2l+bQP1u225iLLRVI58dsUuaDnTTl6CAHmQW/QIvfbHqEBRdUuFvaFnyWiSndnelb8qAqrWdzDO1fQM+SfcJ1BQBdZL/Z//yyU/NcfGWOFqEOTo6+F6Hg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9a96fc6f-23c5-e2f1-062b-39aa0c7ba724@suse.com> Date: Wed, 13 Jul 2022 11:48:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/netback: handle empty rx queue in xenvif_rx_next_skb() Content-Language: en-US To: Juergen Gross Cc: Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220713074823.5679-1-jgross@suse.com> <0e2772a3-3c3c-b447-ecb5-e2750959b527@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0087.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e77f8f1-e75d-4268-6250-08da64b4ea41 X-MS-TrafficTypeDiagnostic: PAXPR04MB9074:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DhudvRbpZ1Jk4oyzRTNH3i1TLT8yYuIHSMxa7oPZhDmsTiIfrP+xncFLuHxRB6L9BKojZobxtqEVOpkfSy1duKc5E/A1hJIWy8Q4cBlSZaw8HxQkWv7JlfF8Mw7B6C40gzQcodMfikYQxra7t7+pZAbL8pb2EpCojPF/jriVE1AsTlSJRNdUU+JqWdo5P+6QSlCFvN+RvcDOIz2W84uAZGKlII8AWOTmRqA2dFdHIZhCpXMY6LGgTEuOb16W5LiZ4x6EKROLzZpEbLL98eEWNT0oejO3dIuyg5xF62a6REMpsGoDxTVa1y/2L6uPjYLiwAqzDBjhOjyFBuchwXG+HdJtESBwZh3WjF6+8Kz7zU69G/CT6LITTMOMLuVdkQZP8MhcKImlZcfAubzeGTnm8eoxI7wktQcFeIDc69Ow6pnvJzke9kDuc3zyDEjU5YkvB/DPR41JJC/XBV06OjNKzQfuuwD9dYtYt91dWiJrli3PeQ3HLLA+8L4RYWtupPB3+MABgANEdOOMlg0LiYetSwcjQ/5e3mkls+qC0mzt835A5rsnOowwZQma22FZo0fa099OUMi7EjuL/pUM/KbLecV7YO/sp087f/1YqkPUs6hu7cEoWncWAhbEuIEkU0xn+n6Ha3QVfSaA2PnXUa9PjU/ujf5uKMb67cL1H56AYcA0yxitEuRL+CZS84JkvvLkYEtZLYCSeuGzCB1kp+INHUpxZPByt1VH9x4GZKr/0NxyRYwxM4btMQTxzK4a0Dt7TcZ/EXoiGUM54VtE6gfu0Us5Isgs9r3ksyhgedKyvuPHAPOqBWuxP5e3VPW9ozE0Dk1RE4NsjV+65cPBUh2Jenl/tZsubw7uHADH8OQbNH4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(39860400002)(366004)(136003)(396003)(83380400001)(86362001)(6486002)(5660300002)(38100700002)(8936002)(6862004)(31696002)(6636002)(41300700001)(31686004)(4326008)(2616005)(478600001)(36756003)(54906003)(8676002)(53546011)(66556008)(66476007)(66946007)(2906002)(316002)(6512007)(26005)(37006003)(186003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?czRKTEtpWnh1V0F4cDBPb1RZUXlMdHNxZVd5M1hnV01VUUpzOS9qTzJrbldn?= =?utf-8?B?YlFHUnhUNWtZMDZjS05BVUFiaXZqTGhRTFJPdEtuUnV3L2NTRVlJMUtxMlFs?= =?utf-8?B?eXNQQTNMYmdLVW82bVpwRGJGTmd1dU1USi9DRXVFSXRYQzRrT0ZYaHFpM1hy?= =?utf-8?B?d1g1U1ZIRVFISHVZRThmWmZhUGtZSEc2Vm5ZdCtTRWZXeHNvYWNHZ25pdlhR?= =?utf-8?B?bzRabWtWSnNmS2dVSThDZzVOUTdFcXJtUTRGV2QvbWJTTzJiUXJ1MVlUYXlJ?= =?utf-8?B?aGc4VlUzV0t2WmhQTVJmYmJLRGwxRlFLblpMNldpOFF3V1FQT0VOZ0tJVk9i?= =?utf-8?B?RzRlTVBHcUJIUmdkYk9VRXFaODFoOGs1N3VkS2ZIUFlCMkZET2NNT3lMbEFJ?= =?utf-8?B?aSt3VVBPbE5VWVNnc3EwNVYrdHh3aUlBYy9WMEhESU1yVEdWdm13MHd6Z0ZF?= =?utf-8?B?d3hmajg4eXd0ZVhZVFBCeXdtWHJvSDZtTXNRQW4vcTlqVkYwUEFBUjd5Q1FI?= =?utf-8?B?VnRmWFRTTndaN3F0RHllYTlmYjBKc21mQjNQNFcvK21HdlpyeWJZOFViN2po?= =?utf-8?B?T0tWTnBxbU9sRTBNc1I3b0JpeW9lS2VVR2dqSHRBL3BLWlhIN1pUUWV4MFUy?= =?utf-8?B?bVBhMHdGLzd1MmdGRWFRU1R1UEMrYWJ1TWluTEdCUWwweDZla1c5SXhocFRF?= =?utf-8?B?NzE2ZktGRzFhUjA5SlpBeElFcndyQ3hNUm96ZkZIdkF1WlZTK0kzZ2FTbVJz?= =?utf-8?B?dXd0eFhWNnZGWG5uTDZRV3VZUkoxZ3pWK3RXUXNQbDl2N1VCdVIvYXdGOE55?= =?utf-8?B?Y21ySWpxTUo2Y29OL1JwL05BN3BLbnBFOTIvUWthV0EvWEs0WHd3UXAwZkRp?= =?utf-8?B?eWZKWURtS2JHRWFWVlZGdHlQaHVnWEpLVGwyeHdsZk1QM3lwQURGc01XZTds?= =?utf-8?B?LzdZTHVtQnZ5ejMyb0JoYStreXNCclVrb1UvbWc2NEVMY3VySHdVMmFxYWMv?= =?utf-8?B?Tko4Y2FwUmNTbHByTlUvR3NlOXBwUE9sdzhuWVBhOFc1V3JMNklOOEd5NS9R?= =?utf-8?B?dmZzcTBoTVB0RUhoMDdsZS9wTlNlYURXQlI4TDc4MzloVHZJQk9aeG8zUFRV?= =?utf-8?B?OWJlMDJDM0RqdHdqWERYdVBVS0ZnNWRNYU4vUjFOZkJFMWVCNXk4MEpVck5z?= =?utf-8?B?SURYRytoWmFJblpEcXQrODY0T3ZVSnpLdVpDT3JPWGdiR1dGMVhOZmZxb1NJ?= =?utf-8?B?dlFuSnR2MitCUkdSWDMzbzZ5ME5SVFp0ZkNrWkprN2pxQlpFaFJYRnpmSTBq?= =?utf-8?B?ZDE5UXhhREtlOU9DemVGMUpPZjlLL2hUU0Y3ZlJQQm9zYktpZzRJU2RJSWJi?= =?utf-8?B?TGRtYlZZbDhzVEhBTlFUK0ZyVnE1akQ5TG9XQnZuTjI0QkJSRTlvMXBLeE8w?= =?utf-8?B?eE5tMEFSWW1Ia29MV25Db0ZlNVVFT2h4RUJ4S0gwN0xjZEJrNkI5bmg1Uk93?= =?utf-8?B?TENaSGVYdW9sbFZOMno2ZGIycVNnS0dzU3piWXJKTGozYTkwSDJJSitKK2tj?= =?utf-8?B?V2JxbWh4NGRsUTdZcnBvK2ZGd0Q0Qy83cUdRWjVTVmRkN1NMRUdoYnlNem9m?= =?utf-8?B?OTN3M0tSby93UklIK3Y1aHB4Tkh4eDU2NUc2TDF2MStiYVlTR3ZVTUNPYXE0?= =?utf-8?B?Q0I5QzNvS1RsM3dIczdIUVBaWWJ3M1JhQW5idlMreHo4ZmJyWDBNZnVvNFJP?= =?utf-8?B?dUpIaXlzK3FXSFZEVUxlTWQvYmVjUUNMbXRzcnIvS0JrZEtQeVZ5cG8zelJp?= =?utf-8?B?T0pBRTNsQVlITGFIYnZrOGYzdzMxTFNQUGh6OHpVai96ZWRVZWZGbXAwc0Qx?= =?utf-8?B?RXJHanp3UGJkdnJuWkhJamNobUNlc0VNL2tzRUNRUk1vdUdPZTd5OU15QXFE?= =?utf-8?B?dnZmQXd3d2ZPaXh1d0FLOVFDNWhzTHhFcGJ3S1QxYUJpTFkrcEpYSkJIS0c3?= =?utf-8?B?Rkdlak45dmpSVzcybVlHRkVQbUd0cFVUNE04M1FlTVBObWtYZXd4VS90Tkl4?= =?utf-8?B?NE42cGNPcDRqUG45dWpLbG1wSXhBcDM5VGZnWkZBZGdSSnZZeEx0OUNtU1Vi?= =?utf-8?Q?wfzO406qvRqJc4oX5ueY3rCE8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e77f8f1-e75d-4268-6250-08da64b4ea41 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:49:01.4953 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HKbrqYGYiu9sI1+QiLoj4euxAjdtlFONEKpXgyNrMkHxnbnDjn2u5dYFf27TMlwoNirNupvNYHILaTMfWNYTQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9074 On 13.07.2022 11:31, Juergen Gross wrote: > On 13.07.22 09:59, Jan Beulich wrote: >> On 13.07.2022 09:48, Juergen Gross wrote: >>> xenvif_rx_next_skb() is expecting the rx queue not being empty, but >>> in case the loop in xenvif_rx_action() is doing multiple iterations, >>> the availability of another skb in the rx queue is not being checked. >>> >>> This can lead to crashes: >>> >>> [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 >>> [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] >>> [40072.537534] PGD 0 P4D 0 >>> [40072.537644] Oops: 0000 [#1] SMP NOPTI >>> [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 >>> [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 >>> [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 >>> [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] >>> [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 >>> [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 >>> [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 >>> [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 >>> [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 >>> [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 >>> [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 >>> [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 >>> [40072.539211] Call Trace: >>> [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] >>> [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] >>> >>> Fix that by stopping the loop in case the rx queue becomes empty. >>> >>> Signed-off-by: Juergen Gross >> >> Reviewed-by: Jan Beulich >> >> Does this want a Fixes: tag and Cc: to stable@ (not the least since as per >> above the issue was noticed with 4.12.x)? > > Hmm, I _think_ the issue was introduced with eb1723a29b9a. Do you agree? If it was that, then something must have invoked xenvif_rx_action() without there actually being work. I'd rather see 98f6d57ced73 ("xen-netback: process guest rx packets in batches") as the origin. >>> --- a/drivers/net/xen-netback/rx.c >>> +++ b/drivers/net/xen-netback/rx.c >>> @@ -495,6 +495,7 @@ void xenvif_rx_action(struct xenvif_queue *queue) >>> queue->rx_copy.completed = &completed_skbs; >>> >>> while (xenvif_rx_ring_slots_available(queue) && >>> + !skb_queue_empty(&queue->rx_queue) && >>> work_done < RX_BATCH_SIZE) { >>> xenvif_rx_skb(queue); >>> work_done++; >> >> I have to admit that I find the title a little misleading - you don't >> deal with the issue _in_ xenvif_rx_next_skb(); you instead avoid >> entering the function in such a case. > > I'm handling the issue to avoid "an empty rx queue in xenvif_rx_next_skb()". > > I can rephrase it to "avoid entering xenvif_rx_next_skb() with an empty rx > queue". That or simply s/handle/avoid/ in the original title. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:53:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:53:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366413.597172 (Exim 4.92) (envelope-from ) id 1oBZ48-0007cE-HS; Wed, 13 Jul 2022 09:53:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366413.597172; Wed, 13 Jul 2022 09:53:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZ48-0007c7-Ee; Wed, 13 Jul 2022 09:53:56 +0000 Received: by outflank-mailman (input) for mailman id 366413; Wed, 13 Jul 2022 09:53:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZ47-0007c1-4W for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:53:55 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2075.outbound.protection.outlook.com [40.107.20.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b460ae5f-0291-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 11:53:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7460.eurprd04.prod.outlook.com (2603:10a6:20b:1c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.27; Wed, 13 Jul 2022 09:53:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 09:53:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b460ae5f-0291-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJII0yv0sDetlxthXsLaci3Fj9gmJTgPQnF5eeCF3nSLx+4Q6OfBljsoX5bmjLgt5iwMlsEnByZGv05adxezEa2GqiXbvA7rJE2jvFsxS7jgafhAKD6zvfyPbvI6zfc8JUq9ZQ3Ml7lJZ2NOWB+vbfhaM5Js8Wpd4AtQUGzX0JuQSTSYNUcgK86w7J91UjP4QrTfK02ukjYcifz/fEeyYGSadN9NOp740pxKlpsjgn/JWy/4GWi9JsxMW/Gp/9q7M/VQKhco7bpz8i5zEQeCXHe80rUNbzXcLTnEs2NICLBGyX9oWIwwwfGX9mEXbKWYrEGYF3T7wdxvMLwe15+fuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RN0c0/+RBtS0QLG2v7icUhMBY9CevbS6Srs0SCzJnbY=; b=FOcwiHvvTMznyCD+ahM6OpvQNPkZtMYd4socpVrGH8QefdtgF5ikcRsxKed1n09VK7xecNcUJW8CmHeY3XwXtBY3KkFb44Ywc8eaMTtqgjVb1cB6TzjGje9y9IBP5PCU93NuShIFUsDjD3XiXdW7DYJXn8MMN/HPHy7/w5tPHPJiFbBc8vLTE6naP/vieO+sgkJI8JBPIpznmfdc9xwI8x8/AmAimTDejizKD9wXEtB4fW/4tVHbBEobA5TC/sFumqOd8M8oXhU3qkjtTiyRYyoritXwjpT7otLKfCvcK63kW1MtyQT7LrjRoI6QLefX6jV78Txcpmtou2sggt159w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RN0c0/+RBtS0QLG2v7icUhMBY9CevbS6Srs0SCzJnbY=; b=RJryA0TkGckqb5TpNgcJoRRGsMxinevPvTY1OaKilaepA4GI5s9HpAh5CYYcZsQZgzI/dN06HAP2/HcMMWQPJcf/PCffUNV+mlfiMQvAanKxMwNvPEWl5NGDkFPOyPOf6IUT9bU7Wyyzb53OnL66eSa4FPA64kSIazrto96uE78i10Ljd60kxRxnhEzejQNrR3qCTReHoyNVd48nXekqruy6td7vH9VNmcg+XQSubnJ/EgJHqL8wP/Az91fMDMzL77tiYZDj0ThhxvIy/MHTLI30lD59c7B95VBzxmLckhjkSYx3cpsQcpXqP74ZckEo8s1+HINcKqgy6gp9Kx02Ig== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> Date: Wed, 13 Jul 2022 11:53:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Julien Grall Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> From: Jan Beulich In-Reply-To: <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0150.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5ea2047b-7556-4e89-2ff0-08da64b5977d X-MS-TrafficTypeDiagnostic: AM8PR04MB7460:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: POmlmVhD3YjB3pAEmjoysbuu/MEHEd+7hdQQObMiBYnyL5MrEkXZQzAocw2hKCdoFki3GxDGlmJhf99rnd7GdFjZrCcLdelz/4KkiMgtNoeKfO7p8PISOL/QfeVEEuB6XJbw+aCxf605LKxdDcuroIIg+M2vk0tk4dDqnkkTRIqcwNsIdADvTC/PoDt4en4rZmxHpX2WYp6zqI6CMFqV0WXZkruMEDEYPMtaDqlu4t3k3lmVENvuMGQnvnrlWEOpNUr2yDV8tI/NERbsbELF1cqnNmvbQRoRTORNAlC9urc1v8wMdjhIJ1ocDsvrhfvd7xjIXSKFu7o04fh+9OUGTIEd8cVhhZU9tZJHN/yDQe4FA7BBhFyhv3PkVG7jXnm0C+VaO4Pats2dQ3Dm68Ezdm4+S9wuVRV9IcUfF1eOYo0fTK6zmlW+tHM5lrfGrsPP14NgtpQihS7bAUHopDdisEqRUkpQZSjQogn3gLMy4oJnEaPl1peWGZkXLAKLqcOyFHlKx/DkvHwGI73B0uCwJ+w0ul7bLUZF42SCtJ4oYAc27LeyjYR/pfnzJvsp/WvPdKbGC2h6r9IaaTdQbdwLbPSPFkTwXLACTJkXxkjxTJQiTiUBDkmarB21WyhlG0Qw9Drh+lyHbNlMtE7Lk4Xfzc1PHjxHWIdpdd/mUY4eEZg9lKiF+CRep6owdheyxN6W3kkF7p3MkBv78BMBEnrTgLiCbVjhc5u9cJ3g3z73QMWamy2it+533BRuqOs4gLZ2wSdPAeV8gMGxwQmjyFerqsdTybBhY3mbPjFx2pAb8HdhzJjXWIZNI/yolvje61mgJbX3zV9CE11lXinHMMpMP9obp7rmBEl3i0PlzaCSRHs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(6486002)(2616005)(186003)(31686004)(53546011)(41300700001)(26005)(6506007)(4326008)(478600001)(6512007)(66946007)(66476007)(8676002)(66556008)(83380400001)(6916009)(38100700002)(54906003)(316002)(31696002)(86362001)(2906002)(36756003)(5660300002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWV1TFh1YWl5VXMrNDkvSXVGclE0Nit1K0J3WWx3aEU3bHdIbmtQait2a1VT?= =?utf-8?B?a1FLS3k4ZERlNTJBd1VuU0FEb25ERGJZTUltaXR1bzFZRGJubHBsOUVoSDBw?= =?utf-8?B?SmUzNU5abHVQZjRxRnBodUFhYmdQbWFtWUZuK1JsYnJuUUp1QVB3RjB0MzFD?= =?utf-8?B?aElFUk5CZ1hYd3pLQVFFcGhsN0IrNDl6T2lXM2VPVjJyMWo1YmpCQXJ1cDFO?= =?utf-8?B?N0RMRCthcGQ2dHBzN2NtRDhNTkVyN1I2UWRJejRFNmIrRWd2Uk1qTzQ5eU0w?= =?utf-8?B?UHJOWnJCS3VUeTFsNXhSNGVRQ0xIdTBha2NYYWsreFFRWitmcGZUcGZqNCtV?= =?utf-8?B?cldhNzQ4QVNNUlhEdTdBQ2xpMktGOE91cVZMZmhudDB0dTNQY285UHgwSnpG?= =?utf-8?B?bVBaeTFwV2QzV2d6RkVmbDRMWlFHcTBTMHFaZzAzbG9oK2dsWUVocUJkUXhZ?= =?utf-8?B?a1lNcGFHa2R3YTkwRU9vMVVXUEV0aFg5azRiRlNobFUvL2FOellKNkthOXht?= =?utf-8?B?WTV6cnZCSjBYTFpOUHBGT2p2eTVvZHY3VTAwd1lVd3ZlejE0S0U2aWRnUk9h?= =?utf-8?B?NitTQTNlWDNSSnpPTEZCaHppRW9abkpJQkVBblNEbkRFL0ZLRlRxZFRCMitv?= =?utf-8?B?eW5Td0poZzNOeXVvdlFGWFd0UVJFYVZzVmZaenlZTVNLQm8xa3NibjkzNVYr?= =?utf-8?B?c3lTR21WS044aDE3d1orbTVsZEtrQk5NWVFvVHVmTHNRSkp3ZWdVZzZZbUdQ?= =?utf-8?B?QmpreXBxU0F3L2Vwb0NZZlRTMWtKY2pmbTYvOHRnRktFck43OVpEbXM5dHFV?= =?utf-8?B?RnlnYjlTU3BsWXg5V09MYStDdmRGUEVhZDArSlpPMHROMHFwZEhhNmgxQVVt?= =?utf-8?B?YzExS2REd1B0OXVUZ2JRK0ZpTzJHdmsycWhIbFZFVkl2dWE0WlM2R2N3elVx?= =?utf-8?B?M3E4cllBOFNaeDJOVzErTTIwb2toVDZraThVZTJwNmpaQzhJc2ZDcVZ4TTM1?= =?utf-8?B?dk9UTStlVUhJU0FIVEVRM1llVjE0ZEpzODlRN0lDcExoL21DUjNLcS9kVjV1?= =?utf-8?B?THVEcDBkS0xjdmhxcjdLK1JkN1Ewa29LNG1oc1h6WWNmaUVJYWJZdnFmeGNL?= =?utf-8?B?amFvNnUyZ0VJOTd6Y1VkbTR6Zmg0YXBvc1duSDV4Z2ZLaDNHaU5FUVBDS3RG?= =?utf-8?B?RTQvMUp6Y3REMzJYWEExMThzMW1ydmRYU2lLYkFOL2h0S3E5Wkh4VERQak5J?= =?utf-8?B?WDdUVGNTMU5KcWNmMExCY2FxenN1bHFnQW1jRk9IZlU4RDVldU1jVjZ5TG0r?= =?utf-8?B?cUluL2dCaS9XY2VHaENhRWlDakpkazlWVzZFay9VZUJpKytQMTFHazhNQ2V5?= =?utf-8?B?cjBQM2RnTURidC9LSzBBaEd6QXBja05zMHp2NnBtYWlUcTJWYi9jdXdyTjZn?= =?utf-8?B?amRwVVh3amNTQTFjZ2R1bUZMbmJUbFo4cDR2SU5SazN3RUJJeUZuQkczUk55?= =?utf-8?B?OHZXM3lKRkduMWNLLy8wNUYzOW90bksrWW51cDlRS05ZL2gxWkVkVlpMR0gv?= =?utf-8?B?Y3IrTTkrR1NScDVEdWVNclRsNDgvUlpnbGoyYU1rNVplMDdSc2tHUzNUSkNp?= =?utf-8?B?V2dNQmJEYXh3dzJYTUFjaHhSNW9ucjIzZlVLNHhsbWcva0dYSnlWczFuTmMx?= =?utf-8?B?eUFwd05ZNGhaMlJWNVd0S3hldm5KQ2pVRTRGRzUzaGZ2MWxTTEtXVDZGVzJ5?= =?utf-8?B?Z2xmWlB6M1kzQk1MNm0weTh6akpScnAzRUE2TlZCY24xZEcrVTN0bjlGd2hF?= =?utf-8?B?NllOanhEaCtybENETzdibTg5TTZXTnp4ak1hRk5rQlJDVHdsem5ybzIyc0c5?= =?utf-8?B?MzRWWWxJNGlZSGJyNGlmeS85K3Zpd2lsNXJ6Zm5TN0N2RVNxT1lDSThQbnZ5?= =?utf-8?B?dHJSU25oZlFnWEdtUmlEWjNZUm85UVJJNlJsUGZZa3NxLzk5UmpLQWxSVmk5?= =?utf-8?B?OXJWYzRxWnJDcFFaRStJSVdFZlhEYkc5UGRWZzlVV2V1dWFCZG8yU21Ca2p3?= =?utf-8?B?RHAyUzExMDJtc3BjSENodzRCQk5MWVhGazhodFR6YnFuYUY1TW1ZYVc0Z2xr?= =?utf-8?Q?XZxaD5mmBIFnYPMOdpA/SzWPa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ea2047b-7556-4e89-2ff0-08da64b5977d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:53:52.1955 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eLkN8+l3npsD778n3XQCyBhPbvhSMw8+3+tQG5pQiy0iFhK00g/4uSUraf8KXo3lfmLF7kxuzw7zRKs0VTyf3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7460 On 13.07.2022 11:35, Julien Grall wrote: > Hi, > > On 13/07/2022 07:21, Jan Beulich wrote: >>>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>>> In this way, we can avoid allocating a lot of memory to fill the hole. >>>> >>>> Let me know your view on this. >>>> >>>> config MAX_STATIC_PORT >>>> int "Maximum number of static ports” >>>> range 1 4095 >>>> help >>>> Controls the build-time maximum number of static port supported >>> >>> The problem is not exclusive to the static event channel. So I don't >>> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >>> (even though this is the only user today). >>> >>> A few of alternative solutions: >>> 1) Handle preemption in alloc_evtchn_bucket() >>> 2) Allocate all the buckets when the domain is created (the max >>> numbers event channel is known). We may need to think about preemption >>> 3) Tweak is_port_valid() to check if the bucket is valid. This would >>> introduce a couple of extra memory access (might be OK as the bucket >>> would be accessed afterwards) and we would need to update some users. >>> >>> At the moment, 3) is appealing me the most. I would be interested to >>> have an opionions from the other maintainers. >> >> Fwiw of the named alternatives I would also prefer 3. Whether things >> really need generalizing at this point I'm not sure, though. > I am worry that we may end up to forget that we had non-generaic way > (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up > to mistakenly introduce a security issue. > > However, my point was less about generalization but more about > introducing CONFIG_MAX_STATIC_PORT. > > It seems strange to let the admin to decide the maximum number of static > port supported. Why (assuming s/admin/build admin/)? I view both a build time upper bound as well as (alternatively) a command line driven upper bound as reasonable (in the latter case there of course still would want/need to be an upper bound on what is legitimate to specify from the command line). Using static ports after all means there's a static largest port number. Determined across all intended uses of a build such an upper bound can be a feasible mechanism. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 09:55:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 09:55:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366419.597184 (Exim 4.92) (envelope-from ) id 1oBZ5b-0008CQ-Tk; Wed, 13 Jul 2022 09:55:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366419.597184; Wed, 13 Jul 2022 09:55:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZ5b-0008CJ-Qq; Wed, 13 Jul 2022 09:55:27 +0000 Received: by outflank-mailman (input) for mailman id 366419; Wed, 13 Jul 2022 09:55:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZ5a-0008C9-Aj for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 09:55:26 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30079.outbound.protection.outlook.com [40.107.3.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e9ac688a-0291-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 11:55:23 +0200 (CEST) Received: from AS9PR06CA0686.eurprd06.prod.outlook.com (2603:10a6:20b:49c::31) by PA4PR08MB6109.eurprd08.prod.outlook.com (2603:10a6:102:e2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 09:55:12 +0000 Received: from AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49c:cafe::dc) by AS9PR06CA0686.outlook.office365.com (2603:10a6:20b:49c::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13 via Frontend Transport; Wed, 13 Jul 2022 09:55:12 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT054.mail.protection.outlook.com (10.152.16.212) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 09:55:12 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 13 Jul 2022 09:55:12 +0000 Received: from e63c0c5efd1a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 490BC017-0949-4CB1-9AAD-6E86ADEAE12E.1; Wed, 13 Jul 2022 09:55:06 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e63c0c5efd1a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 09:55:06 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DBBPR08MB4508.eurprd08.prod.outlook.com (2603:10a6:10:c6::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Wed, 13 Jul 2022 09:55:02 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 09:55:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e9ac688a-0291-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Bg9UAO2hlHOs0WLs9RkHB1+VLo1uDGr/AgtNxbwdNyFo5dkI5haG8bdXQXU71kqElFNr7PG1KCVSoN4dRbm3UqPjIQ5qRNzQ1q9d3c7PZ61qPhiazbCyQRUO7oBQMGJJZmgPvLF3dwCicb0W/F0qHavYkABrvqaIPJxd2y8oktBpKehEbEvXBgaZN4s0EjY/HucZtg6HWB2jPuJ57gMyraK76mME6LIvGaqgzkbyrCEy9M8Hn4+tWVVGr8lV8gF0OkDquPpxAHPlvm6/kKG2cCXJBgh/6C9DTLeo7y2l+fB76cgcYl8YWPqrXFEtm5fPHjlxKTcgbl7eNia6kv4+Ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J9txsKsPbDZzB2FRkjPadka9vdNHbyuA9a4+baEjCFc=; b=cRciNrOLWjOMyrisM6XG1uIU/Nh9SfvDcPNsmphC9jr92aNrua3JnApfmjQFKHUJX/0tqyLg5/gQ3WDjfJZ+lyvivqO8qagxCzgPhN3DB7LA9fw9eIaqgO7wZFU9Pu9MHMtuD1MRL8eQ72p5omqD/A9R2riX7bRIsgaS9Kb11k5Z/51+ac2mz1bRJsmov4UDjSLCg+6dB9erVELMNLpbwBIIqbbshQPkvp9gkaA8eWWiCSdcgxopBxwsyDAVI2dQCNh7xVo57GRA/5Se8NSChdIK4fhGNx8jvZhs5mCP/R9jUtpkpyM1ItPeDnOEkhkBXGRG24wIA3N3aPBpLCie6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J9txsKsPbDZzB2FRkjPadka9vdNHbyuA9a4+baEjCFc=; b=ip66Oj022UgfY967qO9kqojbc73ivwuTM4XpAuPl+Qa+3d3Q+zJmLPfdkJQY8AV/g8fVNwffNJcRMTEa4w2GVv/QfFyNkBlEg3VNj/CaeilXuLqaDVYa9sSHcYjIytHZvG1j6/AiFV8r4Ivcu1wK6e/W7pvuuf+tRZe2Z+KS7O8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IU2WERTQciHB8cbPTmHzuFNt3ZG4CGr7clKz0/HdqbnAhNSuoLgGZR/ODA4eHYNBIit0xwruK8f5CZw6rb+Svtqch0WRHjd9wH/+In8E7d75yowvBcP1FBYZmuM8ZfqSTbWpR36EsvGzUIc+/T3HKRrkj/AGKWfcpn2tZfWY6MUJVg3y5wZtItGfDCPp7tYJeXGiAGqWauwr9zfCVjDZuOGZnTcfaWOZZAm4egwC0qhQOe4BY+KC4fKFr/U1yaqgMms+agllLsPjF/lIoS1y0FwSIeZjyXy4emJGKF1QLfmytrv39G0fiE6ChfoqAerW8rKyzWa6VTyeU3cOl9HZjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J9txsKsPbDZzB2FRkjPadka9vdNHbyuA9a4+baEjCFc=; b=Gk8uDu78cgKkVCPf/kpzatYLyT0KtK3AQ8qe49tvVfHQfho73+8t8hfgadnKh/eRnh03bMNJsN38KkpaRFd3MTvfjFhsMIKoUwq3HR4M70Eh93Pwoln8FI3ka7LUkeQ065rOP/OlMT185DKHmJ9quaKdK/oGaa219qE0P1PeM/kbfi87LV0TCS7HfbmUY4ZITEzq5r8807InVtN6qPNzy1u8SDA5Nor8wOkt9IUquLAmb4wh+IsCWZ+phUM/czFWSl2ZYIofTxvXKQaLCt6uKR5zXNA8ogoPb4pgzgaTno/8M9vW+/F2eu8a07pr5a0+TJeu9CPLFCEFmxvLftb1uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J9txsKsPbDZzB2FRkjPadka9vdNHbyuA9a4+baEjCFc=; b=ip66Oj022UgfY967qO9kqojbc73ivwuTM4XpAuPl+Qa+3d3Q+zJmLPfdkJQY8AV/g8fVNwffNJcRMTEa4w2GVv/QfFyNkBlEg3VNj/CaeilXuLqaDVYa9sSHcYjIytHZvG1j6/AiFV8r4Ivcu1wK6e/W7pvuuf+tRZe2Z+KS7O8= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Thread-Topic: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Thread-Index: AQHYktq36ViOQfJ5uUWUa1pA0oRKx616pmYAgAFNx1CAABATAIAAEM/w Date: Wed, 13 Jul 2022 09:55:01 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-2-wei.chen@arm.com> <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: BDD7A9C18445CF4EADD7592948317F72.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: dbee3931-4d18-4061-a16e-08da64b5c78c x-ms-traffictypediagnostic: DBBPR08MB4508:EE_|AM5EUR03FT054:EE_|PA4PR08MB6109:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: HV9RwRwBvCJhTccmxGS95hRXTzNqHYrFUvWHLwxm7k7hGN9ya1MHGTcKQ5HNYO+xNQdYuZeRe5gd2LVb60Owa69fQSCiC0u4pPd2WJvMHiZHJX0m5Tn9FAUuPQMtl+Wxvjp5xbr7j5GTzEbD6QOBroHOIkspgGMeYp+wPWzrRF12AhsgGMYXQ21B/cNT6f6aZBrMVotGnYLr7HQ6VO519OjiC1rgLAKTUc6NOK/BRiYZM1+GYRTBE+ZbulizX4zOjxl2xtPzcF2kVmZNYydozgiVWCCuXRRBn6RP8YOlQsxpAicXaufK82iZUt0a6EoX24kDL+Wr1nOkIn3gQah/kriI5Wvw8dsLdc+anbvuPBR5GmZop0Ohu7WbSCXkeFGpdHy5mKd9tahMJAGljVPPbhrFs5iUs4G17SD9IbnJxkFDzeRGB1b5M44orL/BtZlzenK7w0jI8mUsU1v3/BJysGpsV91bIgvy2KfSkMSR76j5Q4lx/1K2gGOB49jLrl8MSTcRmIkUbtWWm+e2mSyo2Ohcg7rIhzhDH4IsXq1N1uVRlsRuu++KuuCAY5xB81fZkcgRGbsoBq/jTAc/0AATWA8W+7s4Jw3MlmlIifeqLawtzM9NHXam/LsBQ41p72K88jbn57m9R665Ek3hu0XKlCDJZj8QwduG0zV8JDzxslentlY2v0YLwrBKD1zon7VUmsqWA9CO7G9AkewhC5oIZaDkOK7dW3rTb5xNK1sS6Nb1k/Qd1lhLwou3ZsAfKWGJMn7enjHoq4ZRwPB0XP25NS2dXSM7qGD6kr8E+dl3B64uql0c73eBePyFhIwTvSoy X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(366004)(376002)(396003)(136003)(7696005)(76116006)(6506007)(53546011)(5660300002)(71200400001)(64756008)(66446008)(66476007)(186003)(66946007)(66556008)(41300700001)(8676002)(33656002)(8936002)(52536014)(86362001)(478600001)(4326008)(9686003)(26005)(2906002)(122000001)(15650500001)(38070700005)(316002)(38100700002)(6916009)(55016003)(54906003)(83380400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4508 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d296b3b5-9c59-4513-90b2-08da64b5c102 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gGNC/8E/nfngWXEwB141jLEJ9ucMkcWsp2r053JeZ9V0kh59+uGsfc709KWT71cSzKTU9AV80N+sVDdy0yuIOdQ6pGoRAyut7rt6KcpJIEtmfnCbRRE/gkAnveHEMM1kV6IggGIm1vjmaZDdlTq2LAVX6hXEKrpq4EuVjiwtJsAKkAiqsgxm4efRllpsrosNl0e/SsWKuGdvgVw8JEWDfZ0uRnn5+M+0Nzh8B3vu0HnP93L+6EIG+XpJER6pNQEIqNQu7CgnLWI0C/tZNa2Sr8eqiV3mlaiO8s+ALz9MkkOnuptO0TU4IKXoNJ1ycKnLf9euWJm3R+uOlU9NceC/2Y18BqdFauZ7GQw54lM2MtKcphG8g611MdDIG86AlCY+zyIlGoVM6cSszyCpvSKwp4nAt1lxellBuISnZMfKe1u18xDf/mqU5rSthicUve20dSLt8RXNLk7+4MZ7/s+cyQ3CDQY+ie4Kj3UepMyv6tqi5JcbjWMT8j5xi4Dpkrlflb51bSHKX5rXd5O9xURfAZSorlPvzwUXIFrV+dWFew8PPId44AvGn+KcQU37j26txtjcg4ekqUkaEgtYLaKPWiYXW60duqR53gCACHTAF63pQLR/H5VeOElyXCJMsRhP6HhVjtTyDgXmhvJknvth9up5dNBMgJCET3vmKai4Rbu36JuKMuWd2GYrlCv2JnkEaJxbq6ddiHOjkGN0ZlDiKF1YSrscXUlRYfT663sU8DQNSVYFiwgIyzLQoYWkEiiEFHI8nx+qbxea0FOnmhJmLQRsdd8jsT59fvZoGhxQxlrh5Kn53f19sh+hyHUSt9oy X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(36840700001)(46966006)(40470700004)(7696005)(41300700001)(26005)(478600001)(53546011)(9686003)(6506007)(40460700003)(70586007)(82310400005)(70206006)(8676002)(86362001)(316002)(54906003)(83380400001)(4326008)(81166007)(36860700001)(336012)(47076005)(186003)(356005)(82740400003)(40480700001)(5660300002)(6862004)(8936002)(52536014)(33656002)(15650500001)(2906002)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:55:12.5328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dbee3931-4d18-4061-a16e-08da64b5c78c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT054.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6109 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxM+aXpSAxNjo0Ng0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg MS85XSB4ZW4veDg2OiBpbnRyb2R1Y2UgYSBoZWxwZXIgdG8gdXBkYXRlIG1lbW9yeQ0KPiBob3Rw bHVnIGVuZA0KPiANCj4gT24gMTMuMDcuMjAyMiAxMDoyMiwgV2VpIENoZW4gd3JvdGU6DQo+ID4+ IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gPj4gU2VudDogMjAyMuW5 tDfmnIgxMuaXpSAxOTo1NA0KPiA+Pg0KPiA+PiBPbiAwOC4wNy4yMDIyIDE2OjU0LCBXZWkgQ2hl biB3cm90ZToNCj4gPj4+IHg4NiBwcm92aWRlcyBhIG1lbV9ob3RwbHVnIHZhcmlhYmxlIHRvIG1h aW50YWluIHRoZSBtZW1vcnkgaG90cGx1Zw0KPiA+Pj4gZW5kIGFkZHJlc3MuIFdlIHdhbnQgdG8g bW92ZSBzb21lIGNvZGVzIGZyb20geDg2IHRvIGNvbW1vbiwgc28gdGhhdA0KPiA+Pj4gaXQgY2Fu IGJlIHJldXNlZCBieSBvdGhlciBhcmNoaXRlY3R1cmVzLiBCdXQgbm90IGFsbCBhcmNoaXRlY3R1 cmVzDQo+ID4+PiBoYXZlIHN1cHBvcnRlZCBtZW1vcnkgaG90cGx1Zy4gU28gaW4gdGhpcyBwYXRj aCwgd2UgaW50cm9kdWNlIHRoaXMNCj4gPj4+IGhlbHBlciB0byByZXBsYWNlIG1lbV9ob3RwbHVn IGRpcmVjdCBhY2Nlc3MgaW4gdGhlc2UgY29kZXMuIFRoaXMNCj4gPj4+IHdpbGwgZ2l2ZSB0aGUg YWJpbGl0eSBvZiBzdHViYmluZyB0aGlzIGhlbHBlciB0byB0aG9zZSBhcmNoaXRlY3R1cmVzDQo+ ID4+PiB3aXRob3V0IG1lbW9yeSBob3RwbHVnIHN1cHBvcnQuDQo+ID4+DQo+ID4+IFdoYXQgcmVt YWlucyB1bmNsZWFyIHRvIG1lIGlzIHdoeSBBcm0gY2FuJ3Qgc2ltcGx5IGdhaW4gdGhlIG5lY2Vz c2FyeQ0KPiA+PiB2YXJpYWJsZS4gU29vbmVyIG9yIGxhdGVyIHlvdSdsbCB3YW50IHRvIHN1cHBv cnQgaG90cGx1ZyB0aGVyZSBhbnl3YXksDQo+ID4NCj4gPiBJIGFtIG5vdCBzdXJlIG15IGxpbWl0 ZWQgbWVtb3J5IGhvdHBsdWcga25vd2xlZGdlIGNhbiBhbnN3ZXIgeW91cg0KPiBxdWVzdGlvbg0K PiA+IG9yIG5vdC4gQXMgbWVtb3J5IGhvdHBsdWcgZGVwZW5kcyBvbiBoYXJkd2FyZSBhbmQgZmly bXdhcmUgc3VwcG9ydC4gTm93DQo+ID4gZm9yIEFybSwgd2Ugb25seSBoYXZlIEFDUEkgZmlybXdh cmUgdGhhdCBjYW4gbm90aWZ5IE9TIHRocm91Z2ggR0VEIGV2ZW50DQo+ID4gKG5vdCB2ZXJ5IHN1 cmUpLiBCdXQgQUNQSSBhbmQgZGV2aWNlIHRyZWUgY291bGRuJ3QgYmUgZW5hYmxlZCBhdCB0aGUN Cj4gc2FtZQ0KPiA+IHRpbWUgZnJvbSBPUyBib290aW5nLiBJbiBkZXZpY2UgdHJlZSBiYXNlZCBO VU1BLCB3ZSB3aWxsIGVuYWJsZSBkZXZpY2UNCj4gPiB0cmVlLCBBQ1BJIHNlcnZpY2Ugd2lsbCBu b3QgYmUgaW5pdGlhbGl6ZWQsIHRoYXQgbWVhbnMgd2UgY2FuIG5vdCBnZXQNCj4gPiBub3RpZmlj YXRpb24gb2YgbWVtb3J5IGhvdHBsdWcgZXZlbnRzIGZyb20gQUNQSSBmaXJtd2FyZS4NCj4gPg0K PiA+IE9mIGNvdXJzZSwgYWRkaW5nIEdFRCBkZXZpY2Ugbm9kZXMgdG8gdGhlIGRldmljZSB0cmVl LCBhbmQgZ2V0dGluZyB0aGVzZQ0KPiA+IGV2ZW50cyB0aHJvdWdoIEdFRCBpbnRlcnJ1cHRzIHNo b3VsZCBub3QgYmUgYSBiaWcgdGVjaG5pY2FsIHByb2JsZW0uIEJ1dA0KPiA+IHRoZXJlIG1heSBi ZSBvdGhlciByZWFzb25zLCBhbmQgbm8gb25lIGlzIHBsYW5uaW5nIHRvIGFkZCBtZW1vcnkgaG90 cGx1Zw0KPiA+IHN1cHBvcnQgdG8gdGhlIGRldmljZSB0cmVlIChwZXJoYXBzIG5lZWQgYW4gQUNQ SS1saWtlIHNwZWNpZmljYXRpb24gb3IgYQ0KPiA+IGZpcm13YXJlIGFic3RyYWN0aW9uIGludGVy ZmFjZSkuIFNvIGlmIHdlIHdhbnQgdG8gaW1wbGVtZW50IFhlbiBBcm0NCj4gbWVtb3J5DQo+ID4g aG90cGx1ZywgaXQgc2hvdWxkIGFsc28gc3RhcnQgZnJvbSBBQ1BJLiBTbyBjdXJyZW50bHkgZXZl biBpZiB3ZSBnYWluDQo+IHRoZQ0KPiA+IHZhcmlhYmxlIGluIEFybSwgaXQgd2lsbCBub3QgYmUg dXNlZC4gRGV2aWNlIHRyZWUgZG9lcyBub3QgaGF2ZSBwcm9wZXJ0eQ0KPiA+IHRvIGluZGljYXRl IGEgbWVtb3J5IGJsb2NrIGNhbiBiZSBob3RwbHVnIG9yIG5vdC4NCj4gDQo+IEJ1dCBBQ1BJIGlz IHBvc3NpYmxlIHRvIGJlIGVuYWJsZWQgZm9yIEFybTY0LCBhbmQgaGVuY2UgaG90cGx1ZyBjb3Vs ZCBiZQ0KPiBtYWRlIHdvcmsgdGhhdCB3YXkuIFRoZXJlZm9yZSBJIHZpZXcgdGhlIHZhcmlhYmxl IGFzIHBvdGVudGlhbGx5IHVzZWZ1bA0KPiBvbiBBcm0gYXMgd2VsbCwgYW5kIGhlbmNlIGludHJv ZHVjaW5nIHRoZSB2YXJpYWJsZSBtaWdodCBiZSBsZXNzIHRyb3VibGUNCj4gdGhhbiBpbnRyb2R1 Y2luZyB0aGUgcGVyLWFyY2ggaGVscGVyLg0KPiANCg0KT2ssIEkgd2lsbCB0cnkgdG8gZXhwb3Nl IG1lbV9ob3RwbHVnIHRvIGNvbW1vbi9tbS5jLiBBcyBib3RoIEFybSBhbmQgeDg2DQpjb2RlIGNh biBhY2Nlc3MgaXQsIHdlIGNhbiBtb3ZlIHJlbGF0ZWQgTlVNQSBjb2RlIHRvIGNvbW1vbiBXaXRo b3V0IHRoaXMNCmhlbHBlci4gQW5kIG1lbV9ob3RwbHVnIHdpbGwgYWx3YXlzIGJlIHplcm8gZm9y IEFybSB1bnRpbCBBcm0gc3VwcG9ydA0KbWVtb3J5IGhvdHBsdWcuIFRoaXMgc2hvdWxkIGJlIGhh cm1sZXNzIGZvciBBcm0uDQoNCj4gPj4gSSBzdXBwb3NlLiBNZWNoYW5pY2FsbHkgdGhlIGNoYW5n ZSBpcyBmaW5lLiBBbGJlaXQgbWF5YmUgInRvcCIgaW5zdGVhZA0KPiA+PiBvZiAiYm91bmRhcnki LCBhbmQgbWF5YmUgYWxzbyBwYXNzICJub2RlIiBldmVuIGlmIHg4NiBkb2Vzbid0IG5lZWQgaXQ/ DQo+ID4+DQo+ID4NCj4gPiBTb3JyeSwgSSBhbSBub3QgdmVyeSBjbGVhciBhYm91dCB0aGVzZSBj b21tZW50czoNCj4gPiBJdCBtYWtlcyBzZW5zZSB0byB1c2UgbWVtX2hvdHBsdWdfdXBkYXRlX3Rv cCBpbnN0ZWFkDQo+ID4gb2YgbWVtX2hvdHBsdWdfdXBkYXRlX2JvdW5kYXJ5LiBCdXQgaG93IGNh biBJIHVuZGVyc3RhbmQgcGFzcyAibm9kZSI/DQo+ID4gZGlkIHlvdSBtZWFuIG1lbV9ob3RwbHVn X3VwZGF0ZV90b3Aobm9kZSwgZW5kKT8gQnV0IG1lbV9ob3RwbHVnIGlzDQo+ID4gYSBnbG9iYWwg dG9wIGZvciBtZW1vcnkgaG90cGx1ZyByYW5nZXMuIEkgZG9uJ3QgdGhpbmsgcGFzcyAibm9kZSIN Cj4gPiB0byB0aGlzIGZ1bmN0aW9uIGNhbiBiZSB1c2VmdWwuDQo+IA0KPiBQbGVhc2Ugc2VwYXJh dGUgImN1cnJlbnQgaW1wbGVtZW50YXRpb24iIGZyb20gImFic3RyYWN0IG1vZGVsIi4gSW4gdGhl DQo+IGxhdHRlciBpdCB3b3VsZCBzZWVtIHF1aXRlIHJlYXNvbmFibGUgdG8gbWUgdG8gaGF2ZSBw ZXItbm9kZSB1cHBlcg0KPiBib3VuZHMgKG9yIGV2ZW4gcGVyLW5vZGUgcmFuZ2VzKS4gVGhlcmVm b3JlIGFkZGluZyBub2RlIChhbmQsIG9uIHRvcA0KPiBvZiB3aGF0IEkgZGlkIHN1Z2dlc3QgYmVm b3JlLCByZWdpb24gc3RhcnQpIHRvIHRoZSBwYXJhbWV0ZXJzIG9mIHRoZQ0KPiBuZXcgcGVyLWFy Y2ggaG9vayB3b3VsZCBzZWVtIGEgZ29vZCBtb3ZlIHRvIG1lLCBldmVuIGlmIGF0IHByZXNlbnQN Cj4gb25seSAvIGF0IG1vc3QgdGhlICJlbmQiIHBhcmFtZXRlciB3b3VsZCBhY3R1YWxseSBiZSB1 c2VkLg0KPiANCg0KQXMgd2Ugd2lsbCBleHBvcnQgbWVtX2hvdHBsdWcgdG8gY29tbW9uLCBJIHRo aW5rIHRoZXNlIGNoYW5nZXMgYXJlDQpub3QgbmVlZGVkIGFueSBtb3JlPw0KDQpDaGVlcnMsDQpX ZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:03:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:03:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366428.597195 (Exim 4.92) (envelope-from ) id 1oBZD7-0001aw-Pe; Wed, 13 Jul 2022 10:03:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366428.597195; Wed, 13 Jul 2022 10:03:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZD7-0001ap-MO; Wed, 13 Jul 2022 10:03:13 +0000 Received: by outflank-mailman (input) for mailman id 366428; Wed, 13 Jul 2022 10:03:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZD5-0001ad-W7 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:03:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130074.outbound.protection.outlook.com [40.107.13.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ff82bb2c-0292-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 12:03:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7460.eurprd04.prod.outlook.com (2603:10a6:20b:1c5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.27; Wed, 13 Jul 2022 10:03:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 10:03:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ff82bb2c-0292-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fsEN+TQfMI8/ljIhkGSrJvsHPNLEHR1Daq+TrDl/x4alfMQiS1SqkKoiOGp0A0iIurQR/xV47xy3jSJD0DCV8qpFwMCS2nTMCPb/9VvN7Kt95cbXAbOAPXSHS4m32kswirnqkYZbj+8TjhvJsUZu8hQ92C25TBccsUPguQoWBsiwNIbimq8OGP3jh6dE+BNRsbeJcJI7qGayngauAgyOGzD+dfBW4MZEUW5T3VtvHiJzvE6eyF47Ja81pxVFxXmz9MN5rYsFQbMGfVPrNVnujgsInHeVmlSVJCOoEt7LDAMwFklx75zgIcU91C+Afu2HgZKtL7MJAiYYeeJkEifxRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fth4OO6y5ab5pQnHrZZLzi5dJ8kW/sbdlMjh3d2qqoc=; b=OjOjNmZJGMtMcOEAmrk6ZrNdMiihCfrXdLtpmlGWc5Z9RrT2Q640qnepHni7STWDGYg1ZKNXRpA+Sh197NvKUz77IHJ3veo9WHPDBi3tskH4D72RPbOtdaBbAOekv6QlGFthxbcs5ery8dGAoZU4Mbo/Fzali5k968VLmTdFpwNTNgG9yQoLlI5TcwZpjsjRP5IDK/MHuL0DPQNUFITbpY3WNPOqf02sbMKCkog0zTeNkQz5TdTlzdQ58plYo/T7CrHQlEjC5vvOCeIDwYVhh7p3afzlOJ8lwOvXYy7Yv9vAs6i9IBStlZowKC8lchAmF/4vPZT6uhZIrZCyNfY9Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fth4OO6y5ab5pQnHrZZLzi5dJ8kW/sbdlMjh3d2qqoc=; b=WxwA59eGxGD8kKbx850ipHeL81fQFct/OpLoRwsKmZjxIKcH2sQ/G7gfgPXfjvuEvGt5GxMaMo4rmqffAWmuGqElyu84DKSyLHeDpUpg1UkLlm9Npx9fOQAAWD3g06vHcmPtkwfmzMmywX56bEQUe75VoyzAqBgYiW+OZPUD/JNMpbXylpsJSsFtZGcVqmXzKzyZJzQgbuq3Tx1OZ8kKCInCq0fbAmuuowxHcOPAwdb/EScSDs1MAcAhauRooptVy8r/pRkVz3y8x1EEibUBYtduJZS3sUKViYV1DxxRtxEYaoUvDMUhR3lDQWV77bI81N0nzjc7pP76fY49Msil3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <460857a8-c2ee-1656-d1c6-4b73e4dd936b@suse.com> Date: Wed, 13 Jul 2022 12:03:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] xen/x86: introduce a helper to update memory hotplug end Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-2-wei.chen@arm.com> <115e36f9-fb73-9692-a6c6-35ad683805bd@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef65bef6-1505-482e-876b-08da64b6e27a X-MS-TrafficTypeDiagnostic: AM8PR04MB7460:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ODpv5eHpVp6qv/EIMm4u6XYCsPuiwVZUAnmdIz8LdhqV1fXAJOOlj0sL25F/sdoYJUJwxT8nyqBUCY54oylQ0pvm+Hrmj6kTGrUqXPLfaJkAUuDfnpZ/d6cKP1xi+jgOy7ZaKGM3tzo1T1SGHGto2n62y+L/3cxaZtXJ/F0bk14mKpuSiqehaboRyfHVQxg3WkTcuMd3WuwQhB43654Y7ySeXAwRgjPbOBejAxWavG9kQXXvUYFLJ5D4IHyLik8apK+TijXTf9Nu115sjwK6c0xgiNIMfdbopnOqj0r6ryMGSml/A/6ifhKLAxtjlNOAWjZiem230CkdjVWtjcUdzCzfcjrYepBimmpA3kJhB7IjgZqoV7XfCcjKGxUeraPL7OnIfBY3XL2aAF3AUYChMISZlSMGMjZgMcThjoBO35RaB25LfB4qsKSEB8yiWgVJ0xPwg5Pa9UxXxWttq6XUjgAmTUUIzE15YF6Zu+dJ71okSwEI8w9q6wPcqNntXeuKrHBE8S6GbI4WkKUOek+KqZZYz9mQYiYDdU2jtMy+cKoq3jPbZICv7zfP8q27LKM9MqJxdPjVZyoolObSKHQtU1PC/s0IM6g0mcNybhDN0GQT53v6w5Yg270V9DSSTypQmFMXof0q5NWdkq8C1VZs7lLnMBL6yfICTmfwHlpqFI9oqz1RSHYokm7SmUB3qzUoX/zYRnvIcX95R3A4bD8Ghq0YhWm51f5nz25QNpluQhb8DANgkbGsZ0Me0DiinaSgkwLT3e+j3YPcJfWHeJiy0LDQnFFw3q/hsr+mP7xQeCbFUR/9Av63Jz9wWxXb1zqMw9Heti4Eum6hLNUiJlUahSJh4HYSiTFJpSYhiIOu+pU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(6486002)(2616005)(186003)(31686004)(53546011)(41300700001)(26005)(6506007)(4326008)(478600001)(6512007)(66946007)(66476007)(8676002)(66556008)(83380400001)(38100700002)(54906003)(316002)(31696002)(86362001)(2906002)(36756003)(5660300002)(6862004)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aSsvSkoxQ2VWZ2piTWFYR3RMMEpkWEFIWFpXMDZvdGh2Zkx4ZllGaFRpVG9P?= =?utf-8?B?a1BRSXZyRkJRRHVubmFNdEgzblprOXRVOURicXRaTnErS01vMFRuaXMxNFZO?= =?utf-8?B?YktyMlF4SHA4L2JjWW9JMGEzVXVLMkpvU3hvMlU0V0xBS2l5eHhtZ2EwVTZa?= =?utf-8?B?ak5Ub290S05uS1lGWWs4V050S3RLak1tZk1EWHBCZjkwS2VEWXh3Tkd2eXE5?= =?utf-8?B?T1Y2dmIzQktjNURpbkJKdm56N1dvRUJTRlVQRDkvc3BnVENYdWxTUVJBaWYr?= =?utf-8?B?TzR6czg0R3hJMDQxajlUL29pYWt1QlBVQmNSR3Q0ME8xNG9MQ2hQWkN1bVRi?= =?utf-8?B?RjhOSmo3ZVdFZkVBeUJTNW9VODk0aFlPZnlTdGhnYWpNTkNtdUNmZ3p6S1ZO?= =?utf-8?B?Sy9yeS9wV0xleFpZVnMxNnhJSmpPVFlKbUtBcUZydjhMbHpZM1VFRlhuVVZy?= =?utf-8?B?SVg3bUx3cW50UjJ5VGUyOStZaFovbVJxL2pSa0pBa1d5SldUUncxVThJdkRP?= =?utf-8?B?Vmp4K3psYjBxamM2QmdzZDNKRUtyYWtHdjdvcVBBUlhaZkNyb0NHZGJiSGx0?= =?utf-8?B?U0FNbEVjeG90K1VwaVplZkJSYWs3emVSYllGV0gyS05heHU4WjVUV21Ma1dD?= =?utf-8?B?amY2bVMrdi9TYnZWNXFYR3FMRFJaK3YyMUVPYS9yeEpnbU40c0N2c25FWFEx?= =?utf-8?B?SUQwU1l2TmtWank5N0s0djljZ3k4anRSQzlNdk1DYXpkTUU2VlVzMkQwc3Np?= =?utf-8?B?NDlpeXk0dmQ4OHczNXUzc0h2TTh4dHhnWVdSdmhHTlRuWkJSYXVVQkIva2c0?= =?utf-8?B?UnZOcXY4MW95am15dGR6cDl1VjRhMDBZclZaOXV0N3F6M2ZvS1N3M0hqaDBs?= =?utf-8?B?aVJENGVFcmpSRTFJU0NZSStDZHlVNjdNRHUyL1VKUDVwZldTWnZtbEQrVzZr?= =?utf-8?B?aXJYS2w5OGNiSDRPcUUzbjQ0TGlxa1hkbkp3QS9nZkhhT0p1N1pYeUNoY254?= =?utf-8?B?Ny9BTlp3bldxdmRQVG9FVktnNThyQllWRmpidUgyL25UT3BoL3h0YVYzYURo?= =?utf-8?B?T1dCZDVnTklza3dKK3NMVThnMkNEM3VYNTNaWVlJY00xeXkwZnBBRXpHSlpO?= =?utf-8?B?OHRsRnpCZ3dZaGhKM0MzcDEybTllNHUrVDh4UUNLRTRodWljSDVjcWZBNWsr?= =?utf-8?B?VW9JbFdmUjViSnd6SFIyWU4zelJQVFJvK1JUS3dDbTN2a2xTMmlGa21WZ3Bk?= =?utf-8?B?cEU3RzIxTUg4NHRUTVFHKzdGS0xWUTZXV0JIRjdJY2dSUTRZWisraHVnbGhu?= =?utf-8?B?UStkNXhNek1wb2pqZTBYeE9jL1ZQV09weTRkZC9HS2FseGJ5NVZIQjI1VGxN?= =?utf-8?B?KzVFdHJqREhHQkpiRHVxNTlzd1YzRS9MN1FZQkN6My9hWk5DaVp1cmxJcHVD?= =?utf-8?B?MWs1UzA5Y1VrYndjc2JnbTM0SlQ4NGpPVWUvckI4QjEyODNaYnVldHl3eTVQ?= =?utf-8?B?eGVrSDdpcWJVWGd6N0hRWGZ1SXF5MWc3cmpLRktmczdRTTllQVN4cmV3cytz?= =?utf-8?B?bmlSNlRZbnZUdjNLRmwwUFVKaXYrcFVjMmNxb2l0cC8wN2liVU5VRG5QaHdo?= =?utf-8?B?WVl6dHQ5MzVlQWdLd3A5NHFscytVcVk2eWFDTEcweUxUNkhRSUhGMnV5Mm9Q?= =?utf-8?B?clhRNzNBamkwNU52Q0xvWFdCbVpFSUJPL2lLcUdhcHZudXJDSzd2UllNQ2RR?= =?utf-8?B?ZWUybWlqdHhoOE1PWHlHc0NNZnFQallYQTZtdldYNHlpcVBQcHVFZS96VnlM?= =?utf-8?B?UkMyNFBFVmFtbm1Pc2R1dzlDV1IwQjB4TG9UbHM5YzRVdWFnd0lya1VLbm5C?= =?utf-8?B?a0FUQkpLZ3VydVN0KzdHZkdYbnUwMklnWjNGc01QRk12SmIwMWRJNFoyK09D?= =?utf-8?B?eDV5RG1ad0R5S00xVDJ4ZXBHTVpNcVE3STJGcC81RjRNaTQxSTJWWUFzb2FC?= =?utf-8?B?Nk5COTBWY1lxajhldU01bVVEY0M3WkQ5RUx5VTUrNUR4RW00cXo4bGNOaTA2?= =?utf-8?B?OE5VZ2VIcnQ1SWdseFdEdXJBVVEzcVpPekdjQXBIYW1PdVlDMnJTOXVyR0Yx?= =?utf-8?Q?FaJdZu53VoO/xSPLd1fKiaWq2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef65bef6-1505-482e-876b-08da64b6e27a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:03:07.4259 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Aa7u9kMX5Y8rjPU0SjdU5h68gcR9YBCIEsnAySgKEUxMkvntLnk/kJEBU9EiZ0rYWfjWCROtVVC9d6VTAU2LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7460 On 13.07.2022 11:55, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2022年7月13日 16:46 >> >> On 13.07.2022 10:22, Wei Chen wrote: >>>> From: Jan Beulich >>>> Sent: 2022年7月12日 19:54 >>>> >>>> Mechanically the change is fine. Albeit maybe "top" instead >>>> of "boundary", and maybe also pass "node" even if x86 doesn't need it? >>>> >>> >>> Sorry, I am not very clear about these comments: >>> It makes sense to use mem_hotplug_update_top instead >>> of mem_hotplug_update_boundary. But how can I understand pass "node"? >>> did you mean mem_hotplug_update_top(node, end)? But mem_hotplug is >>> a global top for memory hotplug ranges. I don't think pass "node" >>> to this function can be useful. >> >> Please separate "current implementation" from "abstract model". In the >> latter it would seem quite reasonable to me to have per-node upper >> bounds (or even per-node ranges). Therefore adding node (and, on top >> of what I did suggest before, region start) to the parameters of the >> new per-arch hook would seem a good move to me, even if at present >> only / at most the "end" parameter would actually be used. >> > > As we will export mem_hotplug to common, I think these changes are > not needed any more? Indeed. I merely wanted to address your question nevertheless, or in case there was still a reason to avoid making the global variable common. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:03:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:03:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366434.597206 (Exim 4.92) (envelope-from ) id 1oBZDr-00027b-24; Wed, 13 Jul 2022 10:03:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366434.597206; Wed, 13 Jul 2022 10:03:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZDq-00027S-VU; Wed, 13 Jul 2022 10:03:58 +0000 Received: by outflank-mailman (input) for mailman id 366434; Wed, 13 Jul 2022 10:03:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZDp-00027F-QT for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:03:57 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2071.outbound.protection.outlook.com [40.107.20.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1b9e0c18-0293-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 12:03:56 +0200 (CEST) Received: from AS9PR06CA0468.eurprd06.prod.outlook.com (2603:10a6:20b:49a::23) by AS8PR08MB6598.eurprd08.prod.outlook.com (2603:10a6:20b:336::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 13 Jul 2022 10:03:54 +0000 Received: from AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::a1) by AS9PR06CA0468.outlook.office365.com (2603:10a6:20b:49a::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13 via Frontend Transport; Wed, 13 Jul 2022 10:03:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT031.mail.protection.outlook.com (10.152.16.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 10:03:54 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 13 Jul 2022 10:03:54 +0000 Received: from 21041da937bd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C05CE81-8CDB-40E6-911D-67DC49393387.1; Wed, 13 Jul 2022 10:03:43 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 21041da937bd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 10:03:43 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM7PR08MB5320.eurprd08.prod.outlook.com (2603:10a6:20b:103::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Wed, 13 Jul 2022 10:03:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 10:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b9e0c18-0293-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Jp7WffnW8spNSMOb0+r58s1lC+f7qIUyHx6lO1EqsTr5aFjqJFzprrwSKitMyce2mrFjDEPw1jDg0zuRnA9cJnR4hRMoPorz7L4hmw8bNXRse4uPw5w7lXUYPTdBQvt4Qc6+BGZXwcsfzey7K6NTNVWg+N0qSxyFmag/QgYJ7q/ZvvYV27EfbrKi3+Jx7jnkUJvNJ+V/ErzRtgjZ6csHIWPHOH3+NGETRFdrJAH0NWSU9hCJRtEViWH92cSOXulMJGc6JOOl1R4o8mbI4E+7st6QXmO20y4HSt6m2wP0geGARGRXAIXNfHOTTb8LxH9RQNVUaFTEy6v2h/e8VBtUZA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jaEAm9/BhIplZC6gvwJvKqYRRevFbyQ55OSYFu6Ak8E=; b=f8oawi4WPStXvlpKFecpFyo1Bsv2Wu/d8y4LmElO0eEjKXQaqXEzySmgOAUWMqohKzlOegeTqLwhUizymDSa51eBqM+HPPwVwqGHGKQ36pO5z8O5GUAGWJG9nu6poFQrRCv4FvjdloYX0uMq4SDHlGhd1JFNl8iZmSNdkk19OUKBetgNHkIDELyOy6YM+eHWLzNfgBV99+ytESbXE7b74IJzMrbEzrMt0KlJRbazB2WeZMLRbSQTJWp0e+fH7OnhBo27z7hnNUDY1r9/oKHXd9p3iDlVGco2n7kqYYdWHm2sjWZkGiRBmllEyqo1rpjoZqTxf23W2khVGoxYkb+3OQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaEAm9/BhIplZC6gvwJvKqYRRevFbyQ55OSYFu6Ak8E=; b=4lzc/1+U/J6bxwos66Ld4+iuvMDSlCXHdm5qEyOG+k08ridCplUeB1PDkYv3OF8S4FcUI/LNpsmNRef5vSCd93wmN9rwbKYuRskCP9lHkKtM5wrIjwO/rXZelvmXTWVEDtrBy9YG2m9yRnaKDUQAj7njPVIC68OBmn7fBL0CFXA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 59d9cd878643eda8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ix767EcqMKZy3Zy1qUS8z1YXcb/YYgdX5U0g4g16ZtSco1lMBb0VXuVaEr4Kb30c840fHlyOJPtHZJF5Qz2hCwnIO5bXbvL7fFNTIq/s5I4DPGSjyFnbesA9LfX9BEPZFf7Bzy7BsQKIBobQ+MzfmV9l3iBLN3QCGEcmxAYx9HK0i0A4w61ZD+KKQJ0awp1Lms606L0JzZGLCSgZCTEyrtSv4ThTJppe/TpvhnuPr6vHmOk29CkkrYdcu0Wcwvn5MM0+cq1TzZFgCUoFNv0+xuANo3aAf96inZk5/HwAs/I5nJr1E9pKaqdxMPxAf77z2SZL6zIo8liwijKMEADSrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jaEAm9/BhIplZC6gvwJvKqYRRevFbyQ55OSYFu6Ak8E=; b=IxnU60SJ3EBSAd44e9QgpItTbOLyBHIXNlZ0i+uw6Mx06RfqIVzoBkTSW4uJO83TXihqaX2GL/4kOLjhdKnMlJaj6EoioMhqulzs9TYGihZD/P+K6HmoEMYz9sDnBxfixQyzeKPSShljeB4KBHHI8FI6VFxVJ/I85+CfyuhKdZLsgdgiV2DsJYk+hmt/qBQeqK5AKdLlLpnXoveMRJLhbkPQRJF+dlkmCHuIZo7PITvIOIyqTW5vfXIvAT230Z0H4uQ+T6fWjNNsAQII2NYiem21dTpB70aWhXOAnjMB0C5zNuQjQuzlrWaaiQNqa2qfxqTJE2N33Ioc7xSdun4PRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jaEAm9/BhIplZC6gvwJvKqYRRevFbyQ55OSYFu6Ak8E=; b=4lzc/1+U/J6bxwos66Ld4+iuvMDSlCXHdm5qEyOG+k08ridCplUeB1PDkYv3OF8S4FcUI/LNpsmNRef5vSCd93wmN9rwbKYuRskCP9lHkKtM5wrIjwO/rXZelvmXTWVEDtrBy9YG2m9yRnaKDUQAj7njPVIC68OBmn7fBL0CFXA= From: Bertrand Marquis To: Jan Beulich CC: Julien Grall , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXakuWoh6IHqUaokStUp728i61bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAAAr+A Date: Wed, 13 Jul 2022 10:03:40 +0000 Message-ID: <11649A86-4CC2-4439-B64D-F1CA11B53B2B@arm.com> References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> In-Reply-To: <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 129a98d2-7f3d-46d4-4ca9-08da64b6feae x-ms-traffictypediagnostic: AM7PR08MB5320:EE_|AM5EUR03FT031:EE_|AS8PR08MB6598:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QBgokeZOgyxClp73L6AZzOi0UnSrq0euY4LJ37yrf2mrUe2F9569vHTg+IkdXFjVDjKwT4oSWmh3dSg5zuXQZdFRMiMe5cW4xFtnlVlcQ0QdsUIIFZW58Jx6jidykBm7Urjn+yJ9laEvnypMAwgW/SJXXjLVQgF2T6QAWEt96HpwM4SUw5D8LEPWs09g+qQxRtrPDrA849OgCJkRC0fg3sR2Z4a8rCN0nGz9EZGJK6KTiZndtTNW29nP3nqREgDEDJI2tWDalJqyNg2+RssNRfKzGTRKnwMY61qDT9kfr0fQ0+rBulSBIZMWroJKTkjXpo3Cy7+hx8uo+USQCzwPqxIvK65fPqpXnxKJFGt6pw3MStHmPtI807YRMDwz8U2z+kmNFaXZswJOyh/j/zoSHue9rsyY7m8qcUM4vrtnbM3E9lgzFgxgxNNHhUfXlD2Y89Qqg7OK4M7hwfeZAScq5Cqvm9ZMYMy7jO/q4dR8vic6WOA5DP/IxkeRcJFsQ6OEMpAaURpu88sFwXualXw0bE8Qt7r1Q52iu0jZv2TKapSOSb+lZVmxfNxFwO79ZGzh4MrqgnAtV4ol5Yws9dC69mSB2fFpZQxS+jUAI0W0HdEhEC3+41N0wzh7xZHRiwV6bQvZZYanTg/HXItxgTqGeSJXoFfeYY3fKmqT31qg+f88wH5jHUnW+eteLJ6ubgkgOl0hu23GfFN0weNssbifbDJeocByEqPzonN7eDBkOW/o8iyWaxeDvDmX3KBIwU6+AXTTlkA4iMbzVgf449vSyyIc490oMFwxE8dcrth8gBd5JTTYcKoRsPMSTzC04nisUzutgtxAzIJRCqeEoJT+2KF2QGVR0avGvooLO/av2Yk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(396003)(346002)(366004)(26005)(186003)(6512007)(8936002)(33656002)(53546011)(2616005)(38100700002)(6506007)(38070700005)(86362001)(122000001)(2906002)(36756003)(316002)(8676002)(478600001)(83380400001)(4326008)(71200400001)(6916009)(54906003)(66446008)(66946007)(64756008)(66556008)(5660300002)(41300700001)(66476007)(76116006)(91956017)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <057CEF34DDEB00448C373C80498E47F4@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5320 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 97aee0f2-e634-47f3-03ac-08da64b6f68b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KzOYC7bYFNIy0AxUX/+NpMdhhM73XbIYl9sbFJpFsLKKj016S4k+j93qyeIT+Tfl7BDay8JnHsWVhM4Os69R5/ucIe4QJfOkLNYfP13uUaHBlLFDhYD6F+/irbo3csbX8709y14ZNqge/a1D3QizLw6qu3BqPsDauC2yqVAVzKYGbkLg9mUkmLgY8qzXjO9QXaRgqWqlanC59BXALufAEqMVmgZR+Bq7CnFUA0sFipkpkBe8bzCdMgDSpCSM4XV/H7jtribj33kz970+QQ6Znr8sD0czToTV1jsR8O7QAtoN5R5tCNi5u9uJ6jmhuJJvyuoIKGyNQIOLF80w8mV5Tp6DJ7LeIJ2pSMIOFhTAmwSMUgKkMrwAFf3mve9KGgLZ/cGGBBXyqlw11jZsfwZRqM6mvlVvD1S1481BT5GhAW2rAFSOAAQA2SyBLtLQx9CXTDJNp2avoIZlmgIbdBvOPX0xDIqjV3KOjtMROUJkxrWmZ3ldyAeHJmV4RX002135GBCZstcZSiIz6IGYkjoWHLy9VgwSvhK41fThtFQXBFXH3gBmfPTN6mxQAARFG8ur3VyyJmH0ECxmRh+fsCg2GNG/XBR6COF295OEYwzqFHw8JQHWJKR938ltQn38N4C3RbICS4k8rga9a99clsfxVZEw9A3QAc9VBK1xDQHbR0hGSXA5lUe+0uxFUHknFTdrQ3oKvUT381SfLM/Wk134mTlYLxSasj8DBRw36nH9ZpUc0JGUYFoJyAvcqLS41KjHJ7nyDrb2cdev4AezGQNpFxQQMkCLQfF+Tov6SSBbz6WklwQJsz7OmA/yOA81gdeq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(376002)(396003)(46966006)(40470700004)(36840700001)(47076005)(40460700003)(8936002)(2616005)(82310400005)(81166007)(478600001)(6486002)(36756003)(356005)(336012)(70206006)(70586007)(4326008)(8676002)(186003)(41300700001)(6862004)(82740400003)(83380400001)(36860700001)(6512007)(26005)(6506007)(5660300002)(2906002)(53546011)(86362001)(316002)(40480700001)(33656002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:03:54.5368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 129a98d2-7f3d-46d4-4ca9-08da64b6feae X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6598 DQoNCj4gT24gMTMgSnVsIDIwMjIsIGF0IDEwOjUzLCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMTMuMDcuMjAyMiAxMTozNSwgSnVsaWVuIEdyYWxsIHdy b3RlOg0KPj4gSGksDQo+PiANCj4+IE9uIDEzLzA3LzIwMjIgMDc6MjEsIEphbiBCZXVsaWNoIHdy b3RlOg0KPj4+Pj4gRm9yIHRoZSBGSUZPIGlzc3VlLCB3ZSBjYW4gaW50cm9kdWNlIHRoZSBuZXcg Y29uZmlnIG9wdGlvbiB0byByZXN0cmljdCB0aGUgbWF4aW11bSBudW1iZXIgb2Ygc3RhdGljDQo+ Pj4+PiBwb3J0IHN1cHBvcnRlZCBpbiBYZW4uIFdlIGNhbiBjaGVjayB0aGUgdXNlci1kZWZpbmVk IHN0YXRpYyBwb3J0IHdoZW4gd2UgcGFyc2UgdGhlIGRldmljZSB0cmVlIGFuZCBpZg0KPj4+Pj4g YSB1c2VyLWRlZmluZWQgc3RhdGljIHBvcnQgaXMgZ3JlYXRlciB0aGFuIHRoZSBtYXhpbXVtIGFs bG93ZWQgc3RhdGljIHBvcnQgd2lsbCByZXR1cm4gYW4gZXJyb3IgdG8gdGhlIHVzZXIuDQo+Pj4+ PiBJbiB0aGlzIHdheSwgd2UgY2FuIGF2b2lkIGFsbG9jYXRpbmcgYSBsb3Qgb2YgbWVtb3J5IHRv IGZpbGwgdGhlIGhvbGUuDQo+Pj4+PiANCj4+Pj4+IExldCBtZSBrbm93IHlvdXIgdmlldyBvbiB0 aGlzLg0KPj4+Pj4gDQo+Pj4+PiBjb25maWcgTUFYX1NUQVRJQ19QT1JUDQo+Pj4+PiBpbnQgIk1h eGltdW0gbnVtYmVyIG9mIHN0YXRpYyBwb3J0c+KAnQ0KPj4+Pj4gcmFuZ2UgMSA0MDk1DQo+Pj4+ PiBoZWxwDQo+Pj4+PiBDb250cm9scyB0aGUgYnVpbGQtdGltZSBtYXhpbXVtIG51bWJlciBvZiBz dGF0aWMgcG9ydCBzdXBwb3J0ZWQNCj4+Pj4gDQo+Pj4+IFRoZSBwcm9ibGVtIGlzIG5vdCBleGNs dXNpdmUgdG8gdGhlIHN0YXRpYyBldmVudCBjaGFubmVsLiBTbyBJIGRvbid0DQo+Pj4+IHRoaW5r IHRoaXMgaXMgcmlnaHQgdG8gaW50cm9kdWNlIE1BWF9TVEFUSUNfUE9SVCB0byBtaXRpZ2F0ZSB0 aGUgaXNzdWUNCj4+Pj4gKGV2ZW4gdGhvdWdoIHRoaXMgaXMgdGhlIG9ubHkgdXNlciB0b2RheSku DQo+Pj4+IA0KPj4+PiBBIGZldyBvZiBhbHRlcm5hdGl2ZSBzb2x1dGlvbnM6DQo+Pj4+IDEpIEhh bmRsZSBwcmVlbXB0aW9uIGluIGFsbG9jX2V2dGNobl9idWNrZXQoKQ0KPj4+PiAyKSBBbGxvY2F0 ZSBhbGwgdGhlIGJ1Y2tldHMgd2hlbiB0aGUgZG9tYWluIGlzIGNyZWF0ZWQgKHRoZSBtYXgNCj4+ Pj4gbnVtYmVycyBldmVudCBjaGFubmVsIGlzIGtub3duKS4gV2UgbWF5IG5lZWQgdG8gdGhpbmsg YWJvdXQgcHJlZW1wdGlvbg0KPj4+PiAzKSBUd2VhayBpc19wb3J0X3ZhbGlkKCkgdG8gY2hlY2sg aWYgdGhlIGJ1Y2tldCBpcyB2YWxpZC4gVGhpcyB3b3VsZA0KPj4+PiBpbnRyb2R1Y2UgYSBjb3Vw bGUgb2YgZXh0cmEgbWVtb3J5IGFjY2VzcyAobWlnaHQgYmUgT0sgYXMgdGhlIGJ1Y2tldA0KPj4+ PiB3b3VsZCBiZSBhY2Nlc3NlZCBhZnRlcndhcmRzKSBhbmQgd2Ugd291bGQgbmVlZCB0byB1cGRh dGUgc29tZSB1c2Vycy4NCj4+Pj4gDQo+Pj4+IEF0IHRoZSBtb21lbnQsIDMpIGlzIGFwcGVhbGlu ZyBtZSB0aGUgbW9zdC4gSSB3b3VsZCBiZSBpbnRlcmVzdGVkIHRvDQo+Pj4+IGhhdmUgYW4gb3Bp b25pb25zIGZyb20gdGhlIG90aGVyIG1haW50YWluZXJzLg0KPj4+IA0KPj4+IEZ3aXcgb2YgdGhl IG5hbWVkIGFsdGVybmF0aXZlcyBJIHdvdWxkIGFsc28gcHJlZmVyIDMuIFdoZXRoZXIgdGhpbmdz DQo+Pj4gcmVhbGx5IG5lZWQgZ2VuZXJhbGl6aW5nIGF0IHRoaXMgcG9pbnQgSSdtIG5vdCBzdXJl LCB0aG91Z2guDQo+PiBJIGFtIHdvcnJ5IHRoYXQgd2UgbWF5IGVuZCB1cCB0byBmb3JnZXQgdGhh dCB3ZSBoYWQgbm9uLWdlbmVyYWljIHdheSANCj4+IChlLmcuIE1BWF9TVEFUSUNfUE9SVCkgdG8g cHJldmVudCB0cmlnZ2VyIHRoZSBpc3N1ZS4gU28gd2UgY291bGQgZW5kIHVwIA0KPj4gdG8gbWlz dGFrZW5seSBpbnRyb2R1Y2UgYSBzZWN1cml0eSBpc3N1ZS4NCj4+IA0KPj4gSG93ZXZlciwgbXkg cG9pbnQgd2FzIGxlc3MgYWJvdXQgZ2VuZXJhbGl6YXRpb24gYnV0IG1vcmUgYWJvdXQgDQo+PiBp bnRyb2R1Y2luZyBDT05GSUdfTUFYX1NUQVRJQ19QT1JULg0KPj4gDQo+PiBJdCBzZWVtcyBzdHJh bmdlIHRvIGxldCB0aGUgYWRtaW4gdG8gZGVjaWRlIHRoZSBtYXhpbXVtIG51bWJlciBvZiBzdGF0 aWMgDQo+PiBwb3J0IHN1cHBvcnRlZC4NCj4gDQo+IFdoeSAoYXNzdW1pbmcgcy9hZG1pbi9idWls ZCBhZG1pbi8pPyBJIHZpZXcgYm90aCBhIGJ1aWxkIHRpbWUgdXBwZXIgYm91bmQNCj4gYXMgd2Vs bCBhcyAoYWx0ZXJuYXRpdmVseSkgYSBjb21tYW5kIGxpbmUgZHJpdmVuIHVwcGVyIGJvdW5kIGFz IHJlYXNvbmFibGUNCj4gKGluIHRoZSBsYXR0ZXIgY2FzZSB0aGVyZSBvZiBjb3Vyc2Ugc3RpbGwg d291bGQgd2FudC9uZWVkIHRvIGJlIGFuIHVwcGVyDQo+IGJvdW5kIG9uIHdoYXQgaXMgbGVnaXRp bWF0ZSB0byBzcGVjaWZ5IGZyb20gdGhlIGNvbW1hbmQgbGluZSkuIFVzaW5nDQo+IHN0YXRpYyBw b3J0cyBhZnRlciBhbGwgbWVhbnMgdGhlcmUncyBhIHN0YXRpYyBsYXJnZXN0IHBvcnQgbnVtYmVy Lg0KPiBEZXRlcm1pbmVkIGFjcm9zcyBhbGwgaW50ZW5kZWQgdXNlcyBvZiBhIGJ1aWxkIHN1Y2gg YW4gdXBwZXIgYm91bmQgY2FuIGJlDQo+IGEgZmVhc2libGUgbWVjaGFuaXNtLg0KDQpJIGFncmVl IHdpdGggdGhpcy4gUmlnaHQgbm93IGFsbCBzdGF0aWMgcG9ydCBtdXN0IGJlIGRlZmluZWQgb24g Ym9vdCBzbyB0aGlzIGlzIGZ1bGx5DQpvayB0byBoYXZlIGEgbWF4aW11bSBjb21waWxhdGlvbiB2 YWx1ZSBvciBzb21ldGhpbmcgdGhhdCBjYW4gYmUgY3VzdG9taXNlZA0Kb24gY29tbWFuZCBsaW5l Lg0KSW4gdGhpcyBjYXNlIHRoZSBhZG1pbiBtdXN0IGJlIGZ1bGx5IGF3YXJlIG9mIHdoYXQgaGUg ZG9lcyBmcm9tIHRoZSBzdGFydC4NCg0KQWxzbyB3aGF0ZXZlciB2YWx1ZSB3ZSBkZWZpbmUgYXMg ZGVmYXVsdCB3aWxsIHByb2JhYmx5IGJlIGZhciBiaWdnZXIgdGhhbiBhbnkNCnJlYWwgdXNlIGNh c2UgSSB0aGluay4NCg0KQmVydHJhbmQNCg0KPiANCj4gSmFuDQoNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:16:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:16:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366446.597216 (Exim 4.92) (envelope-from ) id 1oBZQB-000478-5C; Wed, 13 Jul 2022 10:16:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366446.597216; Wed, 13 Jul 2022 10:16:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZQB-000471-23; Wed, 13 Jul 2022 10:16:43 +0000 Received: by outflank-mailman (input) for mailman id 366446; Wed, 13 Jul 2022 10:16:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZQ9-00046v-NP for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:16:41 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150054.outbound.protection.outlook.com [40.107.15.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e1fa702c-0294-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 12:16:39 +0200 (CEST) Received: from DB9PR02CA0020.eurprd02.prod.outlook.com (2603:10a6:10:1d9::25) by DB6PR08MB2853.eurprd08.prod.outlook.com (2603:10a6:6:1d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Wed, 13 Jul 2022 10:16:36 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:1d9:cafe::41) by DB9PR02CA0020.outlook.office365.com (2603:10a6:10:1d9::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Wed, 13 Jul 2022 10:16:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 10:16:36 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Wed, 13 Jul 2022 10:16:36 +0000 Received: from c6f78b4064e4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D43A93AA-15E9-42B5-89BF-1FB5A954AE94.1; Wed, 13 Jul 2022 10:16:30 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c6f78b4064e4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 10:16:30 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB3656.eurprd08.prod.outlook.com (2603:10a6:20b:51::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Wed, 13 Jul 2022 10:16:28 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 10:16:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e1fa702c-0294-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YWwx3t2kOsv8lcp0+mxOyvq9IehEWLPBqp6gQyTP5WGDbv+JbYroIVeXjBh31DvgWG4uTmlWLJoEQgXZXA6eSW6Q89bc1Udk6Ofo+OxFvd4sRSIP0DChCSiYdCVik6d3kps7SJGtJd0cssDIEMMrHPfso/+ckESe1XYP78Ss63pbrix1ERZCd8CUBTxvdiDHWfJUP0djoB9SzjauU0p7OdMPUN+XklUvSXgNv4IGf2v6ck0FV2q0mKMm3o8Q+eFLN7557lYKu3KnUBsY/cg38izYvI6Y5xhfJQVGsMJzuH8879LRH3WxM6EZ6jHp6+2L0FQlvz0kULCGaKI1lnK1Iw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xb0w0KYqHRAgHMHI5tHJCkEqglPE9kxIQ9fuCXjxuS4=; b=ceyI9jmXSDzHq2xJ4+F1Amnly4+kEjYjzsCPixt59Me30JbgwNDsFxEuIndP4FgiWvxlUTYwoZR/zgoaoAcER6wXOcx0sf0OlgsbwP15+Wp7vYDylkRi3Redb7u7yr7wroinfdsFE/bZO2rwndrhJU548KJz8J8CyJ0FO+sbqodBNbnpQdAbMZzm4llxrJKeWYYj/NUNihwQ2kjEQ9rbSxC/WEvCErk+jYY+3/E3Kefh8wf77BZtK90XELqCx54VD+hzHo2CNIxUY1KyNw5llniyca0aHOpWZgKnYFnhGwrbcBTAYAJj9gMvPrO6Whz1P04YkhvzPC7bP71vhPZL6Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xb0w0KYqHRAgHMHI5tHJCkEqglPE9kxIQ9fuCXjxuS4=; b=hdQtyB2rcTiHSfVKty28zqPJD1CoIyj1wmnYw72UjsXhzjPjtMB+ttSP2FAHaj089fCazguYSlvdO3cb5gyouuEfuOMbcj3Jjg+zqVsP78qpgJ9IPEIagVv58McsvRcwtuLeYMnQV0q29n27IEcjWxjLfsHZsWIGv53ysAmoyaI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yz9ZXHi8+VZqtHP/YGMoEL2E2C9bf7718yrcHLCLs6Y4yCcaN3SGsCObw0TsPc1VXadJHVtve/3YZ0L2bQVO3ECa9Z4u7JR9wTbUC4IGvWnjd1JWWafCTJ/ONVzGLfRRkqX0IlAYGtWJokSkP657LIUh+glXtUMpKpZF8ZQ0WzJcISTjSwY+Ba8BtBBwN0Jd4wWUwKPCfwklVuM4hCRn9Mz1D+goLEaZhleRJvgb2+aEPsZv1zUr86rxwXaDKJA9PyAJKU5f6HBQUT43YpJ6f5eiyzNjMQCYKq8gvAygF2RjMWAOaGwA+jBFKxWHm/eknmrW2YxJVKLQOF+5zeCy3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xb0w0KYqHRAgHMHI5tHJCkEqglPE9kxIQ9fuCXjxuS4=; b=Swt+4fg2DidimDiRCDoqnUXN3Pgxod1tGck3b2+q/7RZbPF3gHUF3wm4XwBYWvbX5m2NHdvM37mef0nY2Evchhkn/ZbUvxjfyhCKzGHHl8xYD/uUrh3oHxW9BBY5CI+fYxMDL0FTfKImLQ+Hb48EgcmhAzOq5Yo0MvuusEvbrrBOT5eHG09FzUr+2rSg2gkg5YsBbxjMEA2DBWbwgoWrY4Nt3abcoSTLVa4TSmQHRH9q19ZkLlpg0s0fTncP0P7VFeN99/jjkEZJ8gNdShlu3D+1v42kBCxdVucgAGrgS5afd5jRxy4nIGsgb1Xcuv2VmJUpxLqtt7rF2uPH0clMww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xb0w0KYqHRAgHMHI5tHJCkEqglPE9kxIQ9fuCXjxuS4=; b=hdQtyB2rcTiHSfVKty28zqPJD1CoIyj1wmnYw72UjsXhzjPjtMB+ttSP2FAHaj089fCazguYSlvdO3cb5gyouuEfuOMbcj3Jjg+zqVsP78qpgJ9IPEIagVv58McsvRcwtuLeYMnQV0q29n27IEcjWxjLfsHZsWIGv53ysAmoyaI= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 3/9] xen/x86: move generically usable NUMA code from x86 to common Thread-Topic: [PATCH v2 3/9] xen/x86: move generically usable NUMA code from x86 to common Thread-Index: AQHYktq7O5jRSbf360ijLU+hFXQsAa16vIcAgAFcEGA= Date: Wed, 13 Jul 2022 10:16:27 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-4-wei.chen@arm.com> <444a540a-bf0f-f743-3b01-b65210b49361@suse.com> In-Reply-To: <444a540a-bf0f-f743-3b01-b65210b49361@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B2602CFA98F64F46BD24D2ABBB9648D6.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d0d327c1-5841-4528-0931-08da64b8c4a4 x-ms-traffictypediagnostic: AM6PR08MB3656:EE_|DBAEUR03FT010:EE_|DB6PR08MB2853:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mMz8V3D5b/coUzOTcxkPq9p+lz6YM0L9ZKvB8+PYjauBBvpxzYjM3wYqJOHadVRu2zOS4L1jqOnCtQSalwuNmEfbY+wbv9aMkkrJRehgxIdGBKrdQuj4x21EFpfQT+4FqIrO9miGLTO3ra4lfo44R9zsJX4OkqtPRbEcjYR6YuRhy/8LkZcwNS6oPF+js5NOCSoei07MKNSrXGRPOwIgxkYbDFleA85AbZf2AZ/fxrHLs9hdOyKVsBRVYAR1r8X2lX8Qvt89h9W0uhFp2cdEaP0kDB5bv2Isey1TiqBGlBa/6bZ45tPrSQ0Spp31Fsmfp4HzuB8zk4EkxNnyiANey+WbynKzxwUm0i5eP4RV+t4gPBLGYvSlA9yikRvDGjqFHv35PtOE+irnfTn3yO7Hvie7mw4SBl87aKIbF40OBXGO9XPJJO+CugcV/pJhdGOODRMymphXNmK7C+ZruNWWLuL3cuCy28/juRMs3GDBa2KR2crI4oBSCL5uy2+9CYdodcQOmtl61Z2lSpHgjysJ/Qbp7D+06EZ5DeXRpYYc0qBdGHxUHL+frwCgTaou+ZKTSAsXBRNdbfJVsyeZAT8TzIPp3lpk40TFK4XPp0N02NMhtsoHeDQxI9W/qcZcKfM4XFEhNWI+Fa/Gv7bR382B8jvEEUmY86kn/fcYuUAuok94230q23p1W5u3OdOUgmW83ms1d6himyqo/l2fMQ1NbgtCt7llG0hBwRbTP0sQ/41VXr/nIrYcMfh9Yt9zp0i6V9vXRDq9o/kd9pHwwtEbaLwDiOLj8L6OQkFm59mVmrVJAtWJO1mZWipxRF2rGqk7 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(396003)(376002)(366004)(38100700002)(5660300002)(64756008)(54906003)(8676002)(66476007)(6506007)(66556008)(4326008)(76116006)(66446008)(66946007)(71200400001)(478600001)(41300700001)(7696005)(53546011)(122000001)(2906002)(316002)(86362001)(83380400001)(186003)(26005)(38070700005)(33656002)(6916009)(8936002)(55016003)(52536014)(9686003);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3656 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 723f42b0-319b-41f5-6d5a-08da64b8bfc3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sxMjy3ED2u4Ag+JMDmSR9aP/sBiLvRbBysVAuX/cw4bd+ylfJ7aBK813B/cX5SvD5urVTd+vwSbw1g9vt5P0zs7f2A9sN3cPpT+sFh2n3uIOkdkvZF59O1Q6cGzU3B8F+UUej/dlv/CdirNhznSlptX+MWJMqAY5pwsWi3yAHU5YVCeAR4Epg1sDDqBDiR/0qNo8QA1dOoE5sd3yyhNjl5PSTlOqAAl4K00kF+vGxeDD2BavgN0+fNhOoxQFwPQr4nes+7EduB8evqxJ7Q4wg91/i/gDI4AyXo81xFdlaESJrK3H5IBSg69buL0hEOdz8S4+LSx8Vrc/hS5MHrntctqwSesapKWmmDHIiEQxeU5JGORqNdXGJrkg4LgO2kyK8UOLpKs7iXF6wyI1zoCgnZqhATvcYdgVxHdtFDeBJ2sGpy7KafrYTzzNUoKn8rPOaHcalcds6fRQgvMdSZ+fm9TAU6Pl/M3XvCOrgqQSz4aFFTIgEg37bcIwHVkmrT+LqJkJ3Q6FoMbZGtC+gRKGOR52jVDf2thlfv6evv+Ux5FQ6PgS4/V9/w2yBKqP6Y0ZgpN41o5j4CAqaxvGDJhwfeMs3mQ23IatbZjrABkVMkLwkksrehjOjSZOwd3S+k21e7cibJoW4NFYNvSz9fiiRzAyfk2BMILqvuHM8xRnU8S8b8Pf1gmO/9iW5oaQchTbFXdxw8SFVrWs/5BYrThKfg2IABc+qmqLSJdV1d7uOryWX42zv0NztDd9l0GDGrjO4HkmARjI30697Xa7o3KauFwgXwAmnmLzT2+8e169zzmelT1qBtXIqYU4IhyC/wIM X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(346002)(136003)(36840700001)(46966006)(40470700004)(82740400003)(478600001)(26005)(8676002)(336012)(47076005)(8936002)(186003)(6506007)(7696005)(70586007)(81166007)(83380400001)(9686003)(70206006)(316002)(2906002)(53546011)(5660300002)(40460700003)(4326008)(356005)(82310400005)(6862004)(33656002)(52536014)(55016003)(86362001)(54906003)(40480700001)(36860700001)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:16:36.0941 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0d327c1-5841-4528-0931-08da64b8c4a4 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2853 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMToxMw0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgMy85XSB4ZW4veDg2OiBtb3ZlIGdlbmVyaWNhbGx5IHVzYWJsZSBOVU1BIGNvZGUNCj4g ZnJvbSB4ODYgdG8gY29tbW9uDQo+IA0KPiBPbiAwOC4wNy4yMDIyIDE2OjU0LCBXZWkgQ2hlbiB3 cm90ZToNCj4gPiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIveGVuL2NvbW1vbi9udW1hLmMNCj4g PiBAQCAtMCwwICsxLDQzOSBAQA0KPiA+ICsvKg0KPiA+ICsgKiBHZW5lcmljIFZNIGluaXRpYWxp emF0aW9uIGZvciBOVU1BIHNldHVwcy4NCj4gPiArICogQ29weXJpZ2h0IDIwMDIsMjAwMyBBbmRp IEtsZWVuLCBTdVNFIExhYnMuDQo+ID4gKyAqIEFkYXB0ZWQgZm9yIFhlbjogUnlhbiBIYXJwZXIg PHJ5YW5oQHVzLmlibS5jb20+DQo+ID4gKyAqLw0KPiA+ICsNCj4gPiArI2luY2x1ZGUgPHhlbi9p bml0Lmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4va2V5aGFuZGxlci5oPg0KPiA+ICsjaW5jbHVkZSA8 eGVuL21tLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vbm9kZW1hc2suaD4NCj4gPiArI2luY2x1ZGUg PHhlbi9udW1hLmg+DQo+ID4gKyNpbmNsdWRlIDx4ZW4vcGFyYW0uaD4NCj4gPiArI2luY2x1ZGUg PHhlbi9zY2hlZC5oPg0KPiA+ICsjaW5jbHVkZSA8eGVuL3NvZnRpcnEuaD4NCj4gPiArI2luY2x1 ZGUgPGFzbS9hY3BpLmg+DQo+IA0KPiBJc24ndCB0aGUgZ29hbCBmb3IgdGhlIG5vdyBjb21tb24g Y29kZSB0byBub3QgYmUgZGVwZW5kZW50IHVwb24gQUNQST8NCj4gDQoNCkFoLCBnb29kIGNhdGNo LCBjdXJyZW50IGNvbW1vbiBjb2RlIHNob3VsZCBiZSBBQ1BJIGRlY291cGxlZC4NCkkgd2lsbCBy ZW1vdmUgIiNpbmNsdWRlIDxhc20vYWNwaS5oPiINCg0KVGhhbmtzLA0KV2VpIENoZW4NCg0KPiA+ ICtzdHJ1Y3Qgbm9kZV9kYXRhIG5vZGVfZGF0YVtNQVhfTlVNTk9ERVNdOw0KPiA+ICsNCj4gPiAr LyogTWFwcGluZyBmcm9tIHBkeCB0byBub2RlIGlkICovDQo+ID4gK2ludCBtZW1ub2RlX3NoaWZ0 Ow0KPiA+ICtzdGF0aWMgdHlwZW9mKCptZW1ub2RlbWFwKSBfbWVtbm9kZW1hcFs2NF07DQo+ID4g K3Vuc2lnbmVkIGxvbmcgbWVtbm9kZW1hcHNpemU7DQo+ID4gK3U4ICptZW1ub2RlbWFwOw0KPiAN Cj4gRm9yIGNvZGUgbW92ZWQsIHBsZWFzZSBzd2l0Y2ggdG8gKGluIHRoaXMgY2FzZSkgdWludDhf dC4gSSdtIG9uIHRoZQ0KPiBlZGdlIG9mIGFza2luZyB0byBnbyBmdXJ0aGVyIGFuZA0KPiAtIGFs c28gdXNlIF9fcmVhZF9tb3N0bHkgZm9yIHNvbWUgLyBhbGwgb2YgdGhlc2UsDQo+IC0gbWFrZSBt ZW1ub2RlX3NoaWZ0IHVuc2lnbmVkIGludCAoc2FkbHkgdGhpcyBsb29rcyB0byByZXF1aXJlIG1v cmUNCj4gICBhZGp1c3RtZW50cywgZXZlbiBpZiBuZWdhdGl2ZSBzaGlmdCBjb3VudHMgYXJlIG1l YW5pbmdsZXNzKSwNCj4gLSBjb252ZXJ0IGZyb20gcGxhaW4gaW50IHRvIHVuc2lnbmVkIGludCBl bHNld2hlcmUgYXMgYXBwcm9wcmlhdGUsDQo+IC0gYWRkIGNvbnN0IHdoZXJlIGFwcHJvcHJpYXRl IC8gcG9zc2libGUuDQo+IA0KDQpPaywgSSB3aWxsIGFkZHJlc3MgdGhlbSBpbiBuZXh0IHZlcnNp b24uDQoNCj4gPiArbm9kZWlkX3QgY3B1X3RvX25vZGVbTlJfQ1BVU10gX19yZWFkX21vc3RseSA9 IHsNCj4gPiArICAgIFswIC4uLiBOUl9DUFVTLTFdID0gTlVNQV9OT19OT0RFDQo+ID4gK307DQo+ ID4gKw0KPiA+ICtjcHVtYXNrX3Qgbm9kZV90b19jcHVtYXNrW01BWF9OVU1OT0RFU10gX19yZWFk X21vc3RseTsNCj4gDQo+IEZvciB0aGVzZSB0d28gcGxlYXNlIHB1dCBfX3JlYWRfbW9zdGx5IGlu dG8gaXRzIG1vcmUgY29udmVudGlvbmFsDQo+IHBsYWNlIChyaWdodCBhZnRlciB0aGUgdHlwZSku DQo+IA0KDQpPay4NCg0KPiA+ICtub2RlbWFza190IF9fcmVhZF9tb3N0bHkgbm9kZV9vbmxpbmVf bWFwID0geyB7IFswXSA9IDFVTCB9IH07DQo+ID4gKw0KPiA+ICtlbnVtIG51bWFfbW9kZSBudW1h X3N0YXR1czsNCj4gDQo+IFRoaXMgc2hvdWxkIHByb2JhYmx5IGhhdmUgYmVlbiBfX3JlYWRfbW9z dGx5IGFscmVhZHkgaW4gdGhlIGVhcmxpZXINCj4gcGF0Y2ggaW50cm9kdWNpbmcgaXQuDQo+IA0K DQpPay4NCg0KPiA+ICsjaWZkZWYgQ09ORklHX05VTUFfRU1VDQo+ID4gK3N0YXRpYyBpbnQgbnVt YV9mYWtlIF9faW5pdGRhdGEgPSAwOw0KPiANCj4gVGhlIF9faW5pdGRhdGEgYWdhaW4gd2FudHMg dG8gbW92ZSwgYW5kIHRoZSBpbml0aWFsaXplciBjYW4gYmUgb21pdHRlZC4NCj4gDQoNCk9rLg0K DQo+ID4gKy8qIFtudW1hPW9mZl0gKi8NCj4gPiArc3RhdGljIGludCBfX2luaXQgY2ZfY2hlY2sg bnVtYV9zZXR1cChjb25zdCBjaGFyICpvcHQpDQo+ID4gK3sNCj4gPiArICAgIGlmICggIXN0cm5j bXAob3B0LCJvZmYiLDMpICkNCj4gDQo+IEFzIHlvdSdyZSBjb3JyZWN0aW5nIHN0eWxlIHZpb2xh dGlvbnMgZWxzZXdoZXJlLCBwbGVhc2UgYWxzbyBpbnNlcnQgdGhlDQo+IG1pc3Npbmcgc3BhY2Vz IGhlcmUgYW5kIGJlbG93Lg0KPiANCg0KQWNrLg0KDQo+ID4gLS0tIGEveGVuL2luY2x1ZGUveGVu L251bWEuaA0KPiA+ICsrKyBiL3hlbi9pbmNsdWRlL3hlbi9udW1hLmgNCj4gPiBAQCAtMTgsNCAr MTgsNzggQEANCj4gPiAgICAoKChkKS0+dmNwdSAhPSBOVUxMICYmIChkKS0+dmNwdVswXSAhPSBO VUxMKSBcDQo+ID4gICAgID8gdmNwdV90b19ub2RlKChkKS0+dmNwdVswXSkgOiBOVU1BX05PX05P REUpDQo+ID4NCj4gPiArLyogVGhlIGZvbGxvd2luZyBjb250ZW50IGNhbiBiZSB1c2VkIHdoZW4g TlVNQSBmZWF0dXJlIGlzIGVuYWJsZWQgKi8NCj4gPiArI2lmZGVmIENPTkZJR19OVU1BDQo+ID4g Kw0KPiA+ICtleHRlcm4gbm9kZWlkX3QgICAgICBjcHVfdG9fbm9kZVtOUl9DUFVTXTsNCj4gPiAr ZXh0ZXJuIGNwdW1hc2tfdCAgICAgbm9kZV90b19jcHVtYXNrW107DQo+ID4gKw0KPiA+ICsjZGVm aW5lIGNwdV90b19ub2RlKGNwdSkgICAgICAgIChjcHVfdG9fbm9kZVtjcHVdKQ0KPiA+ICsjZGVm aW5lIHBhcmVudF9ub2RlKG5vZGUpICAgICAgIChub2RlKQ0KPiA+ICsjZGVmaW5lIG5vZGVfdG9f Zmlyc3RfY3B1KG5vZGUpIChfX2Zmcyhub2RlX3RvX2NwdW1hc2tbbm9kZV0pKQ0KPiA+ICsjZGVm aW5lIG5vZGVfdG9fY3B1bWFzayhub2RlKSAgIChub2RlX3RvX2NwdW1hc2tbbm9kZV0pDQo+ID4g Kw0KPiA+ICtzdHJ1Y3Qgbm9kZSB7DQo+ID4gKyAgICBwYWRkcl90IHN0YXJ0LCBlbmQ7DQo+ID4g K307DQo+ID4gKw0KPiA+ICtleHRlcm4gaW50IGNvbXB1dGVfaGFzaF9zaGlmdChzdHJ1Y3Qgbm9k ZSAqbm9kZXMsIGludCBudW1ub2RlcywNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgbm9kZWlkX3QgKm5vZGVpZHMpOw0KPiA+ICsNCj4gPiArI2RlZmluZSBWSVJUVUFMX0JVR19P Tih4KQ0KPiA+ICsNCj4gPiArLyogRW51bWVyYXRpb25zIGZvciBOVU1BIHN0YXR1cy4gKi8NCj4g PiArZW51bSBudW1hX21vZGUgew0KPiA+ICsgICAgbnVtYV9vbiA9IDAsDQo+ID4gKyAgICBudW1h X29mZiwNCj4gPiArICAgIC8qIE5VTUEgdHVybnMgb24sIGJ1dCBBQ1BJIHRhYmxlIGlzIGJhZCBv ciBkaXNhYmxlZC4gKi8NCj4gPiArICAgIG51bWFfbm9fYWNwaSwNCj4gPiArICAgIC8qIE5VTUEg dHVybnMgb24sIGFuZCBBQ1BJIHRhYmxlIHdvcmtzIHdlbGwuICovDQo+ID4gKyAgICBudW1hX2Fj cGksDQo+ID4gK307DQo+ID4gKw0KPiA+ICtleHRlcm4gdm9pZCBudW1hX2FkZF9jcHUoaW50IGNw dSk7DQo+ID4gK2V4dGVybiB2b2lkIG51bWFfaW5pdF9hcnJheSh2b2lkKTsNCj4gPiArZXh0ZXJu IHZvaWQgbnVtYV9pbml0bWVtX2luaXQodW5zaWduZWQgbG9uZyBzdGFydF9wZm4sIHVuc2lnbmVk IGxvbmcNCj4gZW5kX3Bmbik7DQo+ID4gK2V4dGVybiBib29sIG51bWFfZW5hYmxlZF93aXRoX2Zp cm13YXJlKHZvaWQpOw0KPiA+ICtleHRlcm4gZW51bSBudW1hX21vZGUgbnVtYV9zdGF0dXM7DQo+ ID4gKw0KPiA+ICtleHRlcm4gdm9pZCBudW1hX3NldF9ub2RlKGludCBjcHUsIG5vZGVpZF90IG5v ZGUpOw0KPiA+ICtleHRlcm4gdm9pZCBzZXR1cF9ub2RlX2Jvb3RtZW0obm9kZWlkX3Qgbm9kZWlk LCBwYWRkcl90IHN0YXJ0LCBwYWRkcl90DQo+IGVuZCk7DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5s aW5lIHZvaWQgY2xlYXJfbm9kZV9jcHVtYXNrKGludCBjcHUpDQo+ID4gK3sNCj4gPiArICAgIGNw dW1hc2tfY2xlYXJfY3B1KGNwdSwgJm5vZGVfdG9fY3B1bWFza1tjcHVfdG9fbm9kZShjcHUpXSk7 DQo+ID4gK30NCj4gPiArDQo+ID4gKy8qIFNpbXBsZSBwZXJmZWN0IGhhc2ggdG8gbWFwIHBkeCB0 byBub2RlIG51bWJlcnMgKi8NCj4gPiArZXh0ZXJuIGludCBtZW1ub2RlX3NoaWZ0Ow0KPiA+ICtl eHRlcm4gdW5zaWduZWQgbG9uZyBtZW1ub2RlbWFwc2l6ZTsNCj4gPiArZXh0ZXJuIHU4ICptZW1u b2RlbWFwOw0KPiA+ICsNCj4gPiArc3RydWN0IG5vZGVfZGF0YSB7DQo+ID4gKyAgICB1bnNpZ25l ZCBsb25nIG5vZGVfc3RhcnRfcGZuOw0KPiA+ICsgICAgdW5zaWduZWQgbG9uZyBub2RlX3NwYW5u ZWRfcGFnZXM7DQo+ID4gK307DQo+ID4gKw0KPiA+ICtleHRlcm4gc3RydWN0IG5vZGVfZGF0YSBu b2RlX2RhdGFbXTsNCj4gPiArDQo+ID4gK3N0YXRpYyBpbmxpbmUgX19hdHRyaWJ1dGVfXygocHVy ZSkpIG5vZGVpZF90IHBoeXNfdG9fbmlkKHBhZGRyX3QgYWRkcikNCj4gDQo+IFBsZWFzZSB1c2Ug X19hdHRyaWJ1dGVfcHVyZV9fLg0KPiANCg0KQWNrLg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:18:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:18:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366452.597228 (Exim 4.92) (envelope-from ) id 1oBZS4-0004jr-K4; Wed, 13 Jul 2022 10:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366452.597228; Wed, 13 Jul 2022 10:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZS4-0004jk-HC; Wed, 13 Jul 2022 10:18:40 +0000 Received: by outflank-mailman (input) for mailman id 366452; Wed, 13 Jul 2022 10:18:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZS4-0004je-04 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:18:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZS3-0000q9-8q; Wed, 13 Jul 2022 10:18:39 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBZS3-0002Me-2K; Wed, 13 Jul 2022 10:18:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1Ha9YWI1JgGQ1zqCi0e5QfGq9+Am6SDn1c4rPp2yj1k=; b=QgMLd+on0/nYqyNh8yAkoXAlYM keJLpUQl4wHjwsTG5Gsb711A+hQH09j4SZa0NM50LCh7aCIP35LmH8jDexbgJ3N4TpQikFM8rZB66 FYXYQ8u1n+PH31B4AKzdRJj9MMMJpHvBv0ZIGZ/CccMY9nf3u+bHAoxYpnqgTFoobyTI=; Message-ID: <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> Date: Wed, 13 Jul 2022 11:18:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Jan Beulich Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> From: Julien Grall In-Reply-To: <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jan, On 13/07/2022 10:53, Jan Beulich wrote: > On 13.07.2022 11:35, Julien Grall wrote: >> Hi, >> >> On 13/07/2022 07:21, Jan Beulich wrote: >>>>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>>>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>>>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>>>> In this way, we can avoid allocating a lot of memory to fill the hole. >>>>> >>>>> Let me know your view on this. >>>>> >>>>> config MAX_STATIC_PORT >>>>> int "Maximum number of static ports” >>>>> range 1 4095 >>>>> help >>>>> Controls the build-time maximum number of static port supported >>>> >>>> The problem is not exclusive to the static event channel. So I don't >>>> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >>>> (even though this is the only user today). >>>> >>>> A few of alternative solutions: >>>> 1) Handle preemption in alloc_evtchn_bucket() >>>> 2) Allocate all the buckets when the domain is created (the max >>>> numbers event channel is known). We may need to think about preemption >>>> 3) Tweak is_port_valid() to check if the bucket is valid. This would >>>> introduce a couple of extra memory access (might be OK as the bucket >>>> would be accessed afterwards) and we would need to update some users. >>>> >>>> At the moment, 3) is appealing me the most. I would be interested to >>>> have an opionions from the other maintainers. >>> >>> Fwiw of the named alternatives I would also prefer 3. Whether things >>> really need generalizing at this point I'm not sure, though. >> I am worry that we may end up to forget that we had non-generaic way >> (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up >> to mistakenly introduce a security issue. >> >> However, my point was less about generalization but more about >> introducing CONFIG_MAX_STATIC_PORT. >> >> It seems strange to let the admin to decide the maximum number of static >> port supported. > > Why (assuming s/admin/build admin/)? I view both a build time upper bound > as well as (alternatively) a command line driven upper bound as reasonable > (in the latter case there of course still would want/need to be an upper > bound on what is legitimate to specify from the command line). Using > static ports after all means there's a static largest port number. > Determined across all intended uses of a build such an upper bound can be > a feasible mechanism. AFAICT, the limit is only here to mitigate the risk with the patch I proposed. With a proper fix, the limit would be articial and therefore it is not clear why the admin should be able to configure it (even temporarily). Instead, I think we want to have a limit that apply for both statically and dynamically allocated even channel. This is what d->max_evtchn_port is for. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:33:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:33:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366460.597238 (Exim 4.92) (envelope-from ) id 1oBZg3-0007GB-Rs; Wed, 13 Jul 2022 10:33:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366460.597238; Wed, 13 Jul 2022 10:33:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZg3-0007G4-PD; Wed, 13 Jul 2022 10:33:07 +0000 Received: by outflank-mailman (input) for mailman id 366460; Wed, 13 Jul 2022 10:33:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZg2-0007Fy-9Z for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:33:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZg1-00015f-Df; Wed, 13 Jul 2022 10:33:05 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBZg1-00037v-5M; Wed, 13 Jul 2022 10:33:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=+B74YXf3lThHUWg217vzfZQUqTEEVTZa/5xUjXlm/AU=; b=Qts8NJ6vt1GWjBw+uGASbw+JWh /Lr5g0AgYbRK8Gq3kgF4S5UM5fzbmhTugj3ZvMLsiAEslGYIZhj/+d9d8D7ziMnX/VnhRc1DrgjVo S05JF7nw6e4bN1i6dT/Yg3z3dEUdjY5fRz9cHTcnqkN04e0pdR7tIKB1kU/O0OloXdtw=; Message-ID: <3510ed76-6c2f-f9f7-65a2-dcaf3153a242@xen.org> Date: Wed, 13 Jul 2022 11:33:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Bertrand Marquis , Jan Beulich Cc: xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <11649A86-4CC2-4439-B64D-F1CA11B53B2B@arm.com> From: Julien Grall In-Reply-To: <11649A86-4CC2-4439-B64D-F1CA11B53B2B@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 13/07/2022 11:03, Bertrand Marquis wrote: > > >> On 13 Jul 2022, at 10:53, Jan Beulich wrote: >> >> On 13.07.2022 11:35, Julien Grall wrote: >>> Hi, >>> >>> On 13/07/2022 07:21, Jan Beulich wrote: >>>>>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>>>>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>>>>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>>>>> In this way, we can avoid allocating a lot of memory to fill the hole. >>>>>> >>>>>> Let me know your view on this. >>>>>> >>>>>> config MAX_STATIC_PORT >>>>>> int "Maximum number of static ports” >>>>>> range 1 4095 >>>>>> help >>>>>> Controls the build-time maximum number of static port supported >>>>> >>>>> The problem is not exclusive to the static event channel. So I don't >>>>> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >>>>> (even though this is the only user today). >>>>> >>>>> A few of alternative solutions: >>>>> 1) Handle preemption in alloc_evtchn_bucket() >>>>> 2) Allocate all the buckets when the domain is created (the max >>>>> numbers event channel is known). We may need to think about preemption >>>>> 3) Tweak is_port_valid() to check if the bucket is valid. This would >>>>> introduce a couple of extra memory access (might be OK as the bucket >>>>> would be accessed afterwards) and we would need to update some users. >>>>> >>>>> At the moment, 3) is appealing me the most. I would be interested to >>>>> have an opionions from the other maintainers. >>>> >>>> Fwiw of the named alternatives I would also prefer 3. Whether things >>>> really need generalizing at this point I'm not sure, though. >>> I am worry that we may end up to forget that we had non-generaic way >>> (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up >>> to mistakenly introduce a security issue. >>> >>> However, my point was less about generalization but more about >>> introducing CONFIG_MAX_STATIC_PORT. >>> >>> It seems strange to let the admin to decide the maximum number of static >>> port supported. >> >> Why (assuming s/admin/build admin/)? I view both a build time upper bound >> as well as (alternatively) a command line driven upper bound as reasonable >> (in the latter case there of course still would want/need to be an upper >> bound on what is legitimate to specify from the command line). Using >> static ports after all means there's a static largest port number. >> Determined across all intended uses of a build such an upper bound can be >> a feasible mechanism. > > I agree with this. Right now all static port must be defined on boot so this is fully > ok to have a maximum compilation value or something that can be customised > on command line. > In this case the admin must be fully aware of what he does from the start. Let me start that I think it would be a mistake to introduce a command line option (or Kconfig) that have high chance to disappear or would become moot. Today we already have a per-domain limit for the number of event channels (see d->max_evtchn_port). If we leave aside the issue in the event channel code, it is not clear to me why we need a separate limit for statically allocated event channel. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366465.597250 (Exim 4.92) (envelope-from ) id 1oBZjy-0007sv-C1; Wed, 13 Jul 2022 10:37:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366465.597250; Wed, 13 Jul 2022 10:37:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZjy-0007so-8q; Wed, 13 Jul 2022 10:37:10 +0000 Received: by outflank-mailman (input) for mailman id 366465; Wed, 13 Jul 2022 10:37:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZjw-0007sg-9L for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:37:08 +0000 Received: from sonic308-54.consmr.mail.gq1.yahoo.com (sonic308-54.consmr.mail.gq1.yahoo.com [98.137.68.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bc74d01d-0297-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 12:37:05 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 10:37:03 +0000 Received: by hermes--production-ne1-7864dcfd54-xmlhn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 54bb56f5686ec92203ef9b89a04e8860; Wed, 13 Jul 2022 10:37:00 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bc74d01d-0297-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657708623; bh=TC1YZJRZ1HK+fEyY7YDkLkdLYwW/HtLekVLODCURuoc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=CRq6hwaUkxj1cqg4bN+xsmARZxQn57v3O4MbQk4T/NrjoW1rWoUKNv3VPLhbZS02xI5YT0ImAsXG+IRSlSixQyqMPDe51+zj5bi+A/bDqjryfpLwatNJcJzQDWa77ZRQf0lWYOY0SLwg7R6IS/68q/5MDdY1QzJC7ytl/AaU84n+fgN63mkDcCaF1kqYYyL5gP2qyDJ+CRwN8rWGGkHnzGlK2VdZtK0UVKMi5ZmsE7UazwyTAGLmURX/TZtXyNWd0fTIuMwvjN64Zb+gid7cFby40fw+qQ7FEBeNjYW/c0CfI7OlYUE0KA3ZYT16iJu+CZGRNSqIFk+XCr04KMMDng== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657708623; bh=1aKOJ3rqFl3/Xk516KhFG2RmtNCAOe5ux/yPgO41wBf=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=FceTnK+kUr5uVObmwGpy68/wPTIOPw+h0JrlrMPrvUKTjYqVUCwNvgIJrdwkI/fcGNqfxjhFilSQLmaPO02Rg5qtoV9ftQAFC1TdnUW0z7nkzL3aJVofMg/LDX6ROrhnsY2WRwN57W15KlU4HIJn0+Ez87QfBL+6J+RyJJUkyuAd+1VOeOnxzTx2ORSebheMhjoGw/Yuk3VgPxbXyYJ0cPaiVbKg9lGY9JSLPI8EDb307QMbIPYezl9nWXsZqiD2Lg0Hiq4V5MYwb/gxVoVyu9/sQMu3hPR1jqlOwiCkVsr0Ud+bl+chNz+UEtEahbsGpofSo6kYTeDpqi2UDoY6jA== X-YMail-OSG: Ejjps90VM1lhpOImESIgbi_Y8Kj5j50KHq3kji2wF8n.kpmmQ5ufuj2EAGBzXDA txgPZZUj4zT2vj6aL5SQplr6m6E3urlCLzOXDkgSFZcjBAJyX0OIJkEY8k4_NtvQ0nhwXJvIf8Qa APoAAzKxQZQBjrYZyg7qCXEm4vYflZXO2gedoLWWC7cIUEdbUgAGMxYn3BWI8U5oOsCdmKx8Hi_L YyQnX2_4As0_NJwSmMWbDmSxqIVsZeM9G4y6v1q5yemvb0H3yj1PemCo0F4mcSMwiEfopqcEEA9X ByYDndQG0ZU0xZr9nLd2XgCl3HMquLoa.hP8XRrq2kRkYYZjD3qlZB4qbEZlCy4rCQInEzf1f7r8 hAIGIAAMgz6OUKEcTyGQbIHQ457KBDWN8zUobc_NbWMGo21oA1zv9SC4VMQOdQUf.QaJd_2T8zLo b9DJOnKVWrLPtqSjMatoVW2MdF3kR3qxr8OcLAHKkehbG_ufjPjBoAPrEq.tWi5uShWbXTG.xQwl 9duA9cpvrZJZi_uXVAM5tE04yYpwPTTfsHHPsElcXnf5Yh.b0buikXHQZRJh0vN8ZsArFUfyS_xe GKfPabpbtgEFOOOOzmdhY5uNFU57117STzzeYiOyy0RU8s6lD6f.WLlBUoAiT5JqQMjrt7oIT2XO W5Miej55.W_JcXtWvTV.5l6s3g01DZGNpSLCWnWX1AfEuuqd2sn6SfIigZwscdxxTH4AVCHC27X6 58jLsk_869806ARiOoD9oO3CjVoUU35YK6erD4._CwBpQ_h4ZhRZN77gYTpJ3Bqw1zoUd5Fvkw8M PcbjaYWHIiL5B9rQUsa4_jSsrolNbLSRoAIZD3UfIdvz2uwKNHW.CQ_8ELqxccgr8BF02FEH4UDI uZs_RCKYPOTPfLO7DC7xHVHFcSeslBvYwMIfM5hPro.rG9phfInxLb1uoPoVoAbf0bWMzOUZlZEz nrMCmf4o4o4FvsrY8DDGDWF37PQS3sA9eGrEGh45xrCvVnG27PHECxz8SAjHNmhNaLd__sEPkkct yupoS1I7Zi6IxGgX.WeeEQN5Jg_2lCoqAL8GFBiovIcxc0B3ZhusU3hndfLo1mh7DM3MTApsoail 4WK_dZlqSrUM5aUnptvVDhzqwiQ6duLD9UEqNC8whmEXaxaxBRGYyg7U0LA94yhOtacbI9sunwIh g8sbLZpoY.Qt6zz2aqdnKoIPAIeRq.14Kfm3KFEcuAgKp48yeJtwOm2Ms9aCuvlQgAO60zIUSR0L Tom79xYEhYkNWk_ZGSTQ_tc64A.VWnRcFNG78Mkrym7VeStPiUG8LmhcxPe0GmAkbXu66qy.Zkj9 AYa9L0Vr74uCFv6RpSQSLVC2xtPmq9v5RnE0hxOvzlKiVPRHtra6vxLNDxtbBNdrpjAxdcQUSAm0 qUTUfuJmp0qRkRgRrQoW6mvQE9cmFZW_BNJowz8.FDIzw7YsjIi4M96cRPs_jU5MpIu8jNkYnkKn OtlYbeKpjfRBYZAI1yMmgnGhNx_XVH1hcQT2eZtIMK82BFZz3yXNYS2cZ8NQEDSMBITRk3n31buo qEQQz7fgLnvCPhXf7pj5Txln9KPGWyyIX9Qu7HtVpzFqJVQ6GUY334kDyxES3yHbrNt8YQYkumMP 5cqshiiDp8OJzTq.ubHVu1hrizH.wBWXDU1EBfpvLQchi4m9TN89nSsPJmZquIWYhADwMWEqJriB _wF9P4mTizm5n4IeJV2QwqgXLheb9jqWrSSpk_q0urw6_Nq5jX67k2upvtJcXq_I_dx67SyUdSxy 2EheJtuFYg5Uy6XjPPcupE3G05f4bpKEUv7TEU05F15SFyD0F5KBPO5DplhbGrSnRIAyxccyhWBC xxpt6ebvLQRy6Yp0HPLT7ARL0wz99_XBjYXRXe3bQvmueYXpmeps9Ilp1bdRhJHOlp6VnFwO8P7H SbZ4XmqI.K13yZ9oy4j1Ld2cQXgUCiiwKHIrT5BVYOQ2vmYRKFgrOij_wC27r9no.gq8mYE1XKcQ w06axBiPNx739WWXffTQNR5cnI.6py_lf6FkjciSwre9K_LjjoZ8.3ggKMfupxzy8XwBmLObx53T EkcL5ex_66shSrx0taOjyYeuEcnnq_FncxsjItWfVKnsmP3wVFvsORdZNeXV1gUWEU31jxAlHpOl 1K1tJAv8zq01jetlJUMRk3iEb1tyMSJf9n2ZVH6WebYsyytbzTActYzruGY8ID3Geq_EJ48cRL5g - X-Sonic-MF: Message-ID: <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> Date: Wed, 13 Jul 2022 06:36:58 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5478 On 7/13/2022 5:09 AM, Jan Beulich wrote: > On 13.07.2022 10:51, Chuck Zmudzinski wrote: > > On 7/13/22 2:18 AM, Jan Beulich wrote: > >> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > >>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>> *Add the necessary code to incorporate the "nopat" fix > >>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>> *Expand the commit message to include relevant parts of the commit > >>> message of Jan Beulich's proposed patch for this problem > >>> *Fix 'else if ... {' placement and indentation > >>> *Remove indication the backport to stable branches is only back to 5.17.y > >>> > >>> I think these changes address all the comments on the original patch > >>> > >>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>> include Jan's idea for fixing "nopat" that was missing from the first > >>> version of the patch. > >> > >> You've sufficiently altered this change to clearly no longer want my > >> S-o-b; unfortunately in fact I think you broke things: > > > > Well, I hope we can come to an agreement so I have > > your S-o-b. But that would probably require me to remove > > Juergen's R-b. > > > >>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>> } > >>> > >>> - if (!pat) { > >>> + if (!pat || pat_force_disabled) { > >> > >> By checking the new variable here ... > >> > >>> /* > >>> * No PAT. Emulate the PAT table that corresponds to the two > >>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>> */ > >>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >> > >> ... you put in place a software view which doesn't match hardware. I > >> continue to think that ... > >> > >>> + } else if (!pat_bp_enabled) { > >> > >> ... the variable wants checking here instead (at which point, yes, > >> this comes quite close to simply being a v2 of my original patch). > >> > >> By using !pat_bp_enabled here you actually broaden where the change > >> would take effect. Iirc Boris had asked to narrow things (besides > >> voicing opposition to this approach altogether). Even without that > >> request I wonder whether you aren't going to far with this. > >> > >> Jan > > > > I thought about checking for the administrator's "nopat" > > setting where you suggest which would limit the effect > > of "nopat" to not reporting PAT as enabled to device > > drivers who query for PAT availability using pat_enabled(). > > The main reason I did not do that is that due to the fact > > that we cannot write to the PAT MSR, we cannot really > > disable PAT. But we come closer to respecting the wishes > > of the administrator by configuring the caching modes as > > if PAT is actually disabled by the hardware or firmware > > when in fact it is not. > > > > What would you propose logging as a message when > > we report PAT as disabled via pat_enabled()? The main > > reason I did not choose to check the new variable in the > > new 'else if' block is that I could not figure out what to > > tell the administrator in that case. I think we would have > > to log something like, "nopat is set, but we cannot disable > > PAT, doing our best to disable PAT by not reporting PAT > > as enabled via pat_enabled(), but that does not guarantee > > that kernel drivers and components cannot use PAT if they > > query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > > instead of pat_enabled()." However, I acknowledge WC mappings > > would still be disabled because arch_can_pci_mmap_wc() will > > be false if pat_enabled() is false. > > > > Perhaps we also need to log something if we keep the > > check for "nopat" where I placed it. We could say something > > like: "nopat is set, but we cannot disable hardware/firmware > > PAT support, so we are emulating as if there is no PAT support > > which puts in place a software view that does not match > > hardware." > > > > No matter what, because we cannot write to PAT MSR in > > the Xen PV case, we probably need to log something to > > explain the problems associated with trying to honor the > > administrator's request. Also, what log level should it be. > > Should it be a pr_warn instead of a pr_info? > > I'm afraid I'm the wrong one to answer logging questions. As you > can see from my original patch, I didn't add any new logging (and > no addition was requested in the comments that I have got). I also > don't think "nopat" has ever meant "disable PAT", as the feature > is either there or not. Instead I think it was always seen as > "disable fiddling with PAT", which by implication means using > whatever is there (if the feature / MSR itself is available). IIRC, I do think I mentioned in the comments on your patch that it would be preferable to mention in the commit message that your patch would change the current behavior of "nopat" on Xen. The question is, how much do we want to change the current behavior of "nopat" on Xen. I think if we have to change the current behavior of "nopat" on Xen and if we are going to propagate that change to all current stable branches all the way back to 4.9.y,, we better make a lot of noise about what we are doing here. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:38:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:38:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366470.597260 (Exim 4.92) (envelope-from ) id 1oBZl6-0008RR-Mr; Wed, 13 Jul 2022 10:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366470.597260; Wed, 13 Jul 2022 10:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZl6-0008RK-KJ; Wed, 13 Jul 2022 10:38:20 +0000 Received: by outflank-mailman (input) for mailman id 366470; Wed, 13 Jul 2022 10:38:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBZl5-0008Mh-8O for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:38:19 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2040.outbound.protection.outlook.com [40.107.22.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e877768d-0297-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 12:38:18 +0200 (CEST) Received: from DB8PR06CA0058.eurprd06.prod.outlook.com (2603:10a6:10:120::32) by AM0PR08MB4082.eurprd08.prod.outlook.com (2603:10a6:208:12e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Wed, 13 Jul 2022 10:38:15 +0000 Received: from DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::36) by DB8PR06CA0058.outlook.office365.com (2603:10a6:10:120::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Wed, 13 Jul 2022 10:38:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT028.mail.protection.outlook.com (100.127.142.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 10:38:15 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Wed, 13 Jul 2022 10:38:15 +0000 Received: from 17489f958cb0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F8F8BE0E-56E4-4F81-9967-A730CC0FA0D8.1; Wed, 13 Jul 2022 10:38:08 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 17489f958cb0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 10:38:08 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB6PR0801MB2006.eurprd08.prod.outlook.com (2603:10a6:4:79::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Wed, 13 Jul 2022 10:37:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 10:37:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e877768d-0297-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=V2GKrKUu0hzm2ZK3LYg3dM4t51kJDx1MWxp309skHqJr8FUhBDjpUrN4jbOLqbLVVOA3en1wsIdr9ItVpuVIAK+qZWLHsF0AyLJ/zTdZfEUQrdE1F4GJZJXcVtVucvP3xu0baxHSt18/L8dXy3p4UVHxo9aFNm75JdYhP1k/1sP/SW4uvJ7R594m1s63twxzE8ZNLDv7IHsR1RCjCLGIDTENi4zV/k4DB4nUkJQNVImfo8td7LUULKW5x/bZyziyQnNOgSD2uEk7zFz6Nt8rEV9Z7pp+STLYIVwZCOOQ7izEByZ2am3e0ILGqQjHvFwNjQ8I4J+8j34Y1YMLhDC/KQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uGi+tMeXa0dkMg9eds+7MPut3Nzf9R8DwN4XqsDiXKg=; b=nDVLRUWiIyQR2vRFwXkKUH7HrF1npXzpsEq8w8C4eXoim5MwXlQnS0Xjp/cLM7wFQx98z4I9qZpw2Jh2XYu/kOBs7tFkCrC/TvgXIFUzFaGvv62DPGgJe32dJFYSIhNSnwwaiuCkQMUz5DpvOISzVOQYo10Tf6OiFuOk4ihTKJGc1Fsp+UZzB4I8L16TpHtBIaintT5siHaqcTpg5TBSwIDRg5D/QfECZSWZmCv8EMqVBWUf8NRFg4uSTwMfaBO8f6nfhXCsaaIEG29hzvcRTAlneDF+GgDSIYm8n2k+UPELxJ4FSdNd9LvWOFHUIQEvER+ecx6j3X0NIL8ncPUpJg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGi+tMeXa0dkMg9eds+7MPut3Nzf9R8DwN4XqsDiXKg=; b=Ct8op7rPdxrkJsvvMHqyySwGtYx0d94WBgU8k8Z4uLeX/EH15IJHRuufI2c4J04e62012GFEc3BA8o3jL4omc1u/I3ZZrqQOLpOKicCk+tw65LXfvmvXA/Flj3dwvwB0RvXQ6aV2aGBEFGp7z9u9wHgjCSLlUGtlgq1P3VYU8Sw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kxwyMU6Rf7sUZZeH4wmTM9frYoB7pTOrfWK+tNc9YvnVtUbukYrpjkz0WML+KdcNzu1orTr3ZnvboensTvpPm8Qxaoq124fzfWai+w7GuDHdRealjNguOeBXgN/F7HNGpXKm5JEbGfKtW5LTB3KK85KTkIxtWFPccTAlpFx1Z+Tj08uSFEqxfzSisg7Sje1akSWVjvFAMzmPwsgsJOou3YpOaJaTgDPzICIfBo8Pjozd4Dptl3gJQeCmlaAlfUAaicXuW24SHi8bBVbbUhTsfGURSf7lWlrnvMJpeMPhcbmsYs1pTnJy5sGk9LkuafRytnXyfq9P/XqouXycMHcIqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uGi+tMeXa0dkMg9eds+7MPut3Nzf9R8DwN4XqsDiXKg=; b=JSWRLLXiGJtbFUXY+qFuAwumfdsek4qcSehiZOqzP+hu86y6YVqqWquw4JEgfBgeoL4nkvYzJQ1pIRv0b4fVobp2cnB1oBxo9/TZllR+ywV1N1wajfmyJfLQp3zTRADsV/aYLmF41TJIud3NkMtNdOFo0KwEGUPgHNH2eQ8XHL2GVtO8TFRHOWUQqBaGTMeOu3hOjjbL49kfE4gauXorXBPD/chJUI7FY7aIa6zHUs/NKGX0MDHjSWH/DmPuRjBnvQUglMsp0wD1fOsYdJeLGvcXhV7AHbSXwuSMUCUYxVXNzMWtXpdDOJmuI1IRGcEMCM6orKD9BIZVlItg9IWDjw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uGi+tMeXa0dkMg9eds+7MPut3Nzf9R8DwN4XqsDiXKg=; b=Ct8op7rPdxrkJsvvMHqyySwGtYx0d94WBgU8k8Z4uLeX/EH15IJHRuufI2c4J04e62012GFEc3BA8o3jL4omc1u/I3ZZrqQOLpOKicCk+tw65LXfvmvXA/Flj3dwvwB0RvXQ6aV2aGBEFGp7z9u9wHgjCSLlUGtlgq1P3VYU8Sw= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map Thread-Topic: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map Thread-Index: AQHYktrCVaKtwgivsk2Qg94d9JgqNq16xCUAgAFbxFA= Date: Wed, 13 Jul 2022 10:37:58 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-6-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 06B3638F97521346B9C47B627166F4C1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ce9bcf23-9d7a-40e4-8b1e-08da64bbcadd x-ms-traffictypediagnostic: DB6PR0801MB2006:EE_|DBAEUR03FT028:EE_|AM0PR08MB4082:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1J+wcV23mO0kjOAqqfYQE4CszncYtVBN6M5b/fOf5JSAr3lUFORx6dSXl30PosbKWm3DJk0YrkAdidaL4F6HzE0Bnx6Nf80mEqVRtG4bhFMAO0E3d4ezeKqJmTgE5MB8Ti+qe1bV7CwkFBcft/7IiYidh7cUgVyle0yFjVYXx/s2e68l0AiBQg0/458WdPPJFMJj3Dt36QUNR0HU31F5rd+Bn3yuP/QMUN5DXKzndr6h7/adwDeSWOlhLSo6lPdljwVeZTIJke6YRpuh/B8KZGzbldy2AmhDPsMPeKGJnL7lEINaPV/uQdw8JWPYlF+nYikgKZT7IlnH4hDC3UyrPeq1msREdF+0IUGYofGSyi8lmp6MdaeKk6UYniwtCGxgQU9pla3sGs/i034fX+By0S09RVfrcx+ydx5xRoM+FoHT0Jvt8UqZyFFwdHBIH8rmGns0xZDTr8m5IHqZhwsibBng98bAfAHl2uxDcOKaawdJJRn4Kp6tflGFEqzlK1zpMm/A/chYfDdnMtFF17kYVy+/oomvYK0Le/3wLE/jhHeGGLv7wYBnGbUpzUdVkzCmNNVGF8SkwAGaDq5rb0ncYFeT26AzK6a4Of3kn0bZSrUNzoUK9NcYqg89vG43GF/KxgdVtD1i9bcsNOvClf8LU0J6IeT3Fa8ygkewKEjXQP5cpjExBKOzGQ1AW5vUMD/Kx9VHo7TDVvV+y2nxQcS8lChQilwHZ4sjD8xHvVUSyOsuEk2zj1o2Qu/jzquUD6tFCzYofr+YgWChznkd2KavEGD9ZRxWVVspguLzgHisUrnpTqg2gFeZqepYh1P56sf/ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(136003)(366004)(376002)(41300700001)(316002)(66446008)(38100700002)(83380400001)(5660300002)(52536014)(6916009)(33656002)(2906002)(122000001)(55016003)(9686003)(53546011)(76116006)(64756008)(86362001)(66946007)(66476007)(6506007)(478600001)(66556008)(186003)(8936002)(26005)(54906003)(38070700005)(8676002)(71200400001)(7696005)(4326008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2006 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1d13bf3d-2258-4a96-dcc5-08da64bbc123 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fKluwk27bwjmU8mnHDSV8DLGXaeMwceOU6zBz3sPbegw+94ns1ugStl0loXQi6NOqMfpsHIBp+F1BWDmJFYyuYaZUibDHfUlJLF2CfyNwxpMCcTlzEK7UE7ryXqYDi0cYbn7WJGKZ+XlAGpa1Ab+JdRpmXoTov7NyX58Oh7IMYQU68yowSsyoxog+lZoL5+Qb5w2zS3j0fc9FsLIjEO6NOdPDeAI++mIIO9FMuRpUuwlnTzuHl2icikwrNYCU24Q4DAbUerfCRVXj2IN4EI73jRz+uOwehti/2Gy7/lwI5uVgRymoFhzY5tsJReCMnKaFTkkA5XkOl9F9mLZ+Xt+jAZ5a1MdS3zKKcQvC5fXvbUuAebcu7lXfzjgAxAejRMXjmp7c45Co/62/Jh8oKqj7nMR9DzDaG4CFWtnsyx0yuTHyBnuEzkfxAqVNaxBuo3LUbcA6FOhjX46PTFHj8tIbM5aedVCv3IfaApBsQQSX47pMiAOH0RLfJ1k8astr6RMOy7nlxlieVUglfv75dhDSYcD7vdqZ+ScJyu81hsESseEwjdhLvmu4lGorENylkrq1kIdvoa32L66Wteic9yumEBulyLYGz8d86KHHQWCCtuc4Yj8C7tXqZ+qIdFQ189UZfxhuicvPTToXMC7WwJE91s8e1jCzBkWAJZv4zAMjwEKHN8rX1LR5QRCEqm2xKnTugkjKSPiCnt2Tlo6eMuHeXZauCw5pi+EnxsNsE7Qi+ItH55ulTxOIlqklaKIsOxDMDiyNmA928xLUbGHNHvWel2MvYRC7d1YTCAaHf9g7GsRXvhT3JGU2HQIUO1CjVwW X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(346002)(376002)(40470700004)(46966006)(36840700001)(9686003)(82310400005)(40480700001)(336012)(6862004)(8936002)(47076005)(52536014)(33656002)(478600001)(55016003)(26005)(41300700001)(316002)(86362001)(82740400003)(83380400001)(4326008)(5660300002)(36860700001)(8676002)(70586007)(356005)(53546011)(70206006)(7696005)(40460700003)(6506007)(81166007)(54906003)(2906002)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:38:15.1368 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ce9bcf23-9d7a-40e4-8b1e-08da64bbcadd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4082 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMTo0MA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgNS85XSB4ZW4veDg2OiB1c2UgYXJjaF9nZXRfbWVtb3J5X21hcCB0byBnZXQNCj4gaW5m b3JtYXRpb24gZnJvbSBFODIwIG1hcA0KPiANCj4gT24gMDguMDcuMjAyMiAxNjo1NCwgV2VpIENo ZW4gd3JvdGU6DQo+ID4gQEAgLTgyLDMgKzgzLDI1IEBAIHVuc2lnbmVkIGludCBfX2luaXQgYXJj aF9nZXRfZG1hX2JpdHNpemUodm9pZCkNCj4gPiAgICAgICAgICAgICAgICAgICBmbHNsKG5vZGVf c3RhcnRfcGZuKG5vZGUpICsgbm9kZV9zcGFubmVkX3BhZ2VzKG5vZGUpIC8NCj4gNCAtIDEpDQo+ ID4gICAgICAgICAgICAgICAgICAgKyBQQUdFX1NISUZULCAzMik7DQo+ID4gIH0NCj4gPiArDQo+ ID4gKy8qDQo+ID4gKyAqIFRoaXMgZnVuY3Rpb24gcHJvdmlkZXMgdGhlIGFiaWxpdHkgZm9yIGNh bGxlciB0byBnZXQgb25lIFJBTSBlbnRyeQ0KPiA+ICsgKiBmcm9tIGFyY2hpdGVjdHVyYWwgbWVt b3J5IG1hcCBieSBpbmRleC4NCj4gPiArICoNCj4gPiArICogVGhpcyBmdW5jdGlvbiB3aWxsIHJl dHVybiB6ZXJvIGlmIGl0IGNhbiByZXR1cm4gYSBwcm9wZXIgUkFNIGVudHJ5Lg0KPiA+ICsgKiBv dGhlcndpc2UgaXQgd2lsbCByZXR1cm4gLUVOT0RFViBmb3Igb3V0IG9mIHNjb3BlIGluZGV4LCBv ciByZXR1cm4NCj4gPiArICogLUVJTlZBTCBmb3Igbm9uLVJBTSB0eXBlIG1lbW9yeSBlbnRyeS4N Cj4gPiArICovDQo+IA0KPiBJIHRoaW5rIHRoZSBjb21tZW50IGFsc28gd2FudHMgdG8gc3BlbGwg b3V0IHRoYXQgdGhlIHJhbmdlIGlzDQo+IGV4Y2x1c2l2ZSBhdCB0aGUgZW5kIChhc3N1bWluZyB0 aGF0J3Mgc3VpdGFibGUgZm9yIEFybTsgZWxzZSBub3cNCj4gd291bGQgcGVyaGFwcyBiZSB0aGUg dGltZSB0byBjaGFuZ2UgaXQpLg0KPiANCg0KRGlkIHlvdSBtZWFuIHdlIGhhdmUgdG8gbWVudGlv biB0aGUgcmFuZ2UgaXMgW3N0YXIsIGVuZCk/DQpJZiB5ZXMsIEkgd2lsbCBhZGQgcmVsYXRlZCBj b21tZW50LiBBbmQuLi4NCg0KPiA+ICtpbnQgX19pbml0IGFyY2hfZ2V0X21lbW9yeV9tYXAodW5z aWduZWQgaW50IGlkeCwgcGFkZHJfdCAqc3RhcnQsDQo+IHBhZGRyX3QgKmVuZCkNCj4gPiArew0K PiA+ICsgICAgaWYgKCBpZHggPj0gZTgyMC5ucl9tYXAgKQ0KPiA+ICsgICAgICAgIHJldHVybiAt RU5PREVWOw0KPiANCj4gUGVyaGFwcyBiZXR0ZXIgLUVOT0VOVD8NCj4gDQoNCkFjay4NCg0KPiA+ ICsgICAgaWYgKCBlODIwLm1hcFtpZHhdLnR5cGUgIT0gRTgyMF9SQU0gKQ0KPiA+ICsgICAgICAg IHJldHVybiAtRUlOVkFMOw0KPiANCj4gSSdtIHNvcnJ5LCB0aGlzIHNob3VsZCBoYXZlIG9jY3Vy cmVkIHRvIG1lIGFscmVhZHkgd2hlbiBjb21tZW50aW5nIG9uDQo+IHYxOiAiZ2V0X21lbW9yeV9t YXAiIGRvZXNuJ3QgcmVhbGx5IGZpdCB0aGlzICJSQU0gb25seSIgcmVzdHJpY3Rpb24uDQo+IE1h eWJlIGFyY2hfZ2V0X3JhbV9yYW5nZSgpPyBPciBtYXliZSBvdGhlcnMgaGF2ZSBzb21lIGdvb2Qg bmFtaW5nDQo+IHN1Z2dlc3Rpb24/DQoNCmFyY2hfZ2V0X3JhbV9yYW5nZSBtYWtlcyBzZW5zZSB0 byBtZS4gSSB3aWxsIHVwZGF0ZSBpbiBuZXh0IHZlcnNpb24uDQoNCj4gDQo+ID4gKyAgICAqc3Rh cnQgPSBlODIwLm1hcFtpZHhdLmFkZHI7DQo+ID4gKyAgICAqZW5kID0gZTgyMC5tYXBbaWR4XS5h ZGRyICsgZTgyMC5tYXBbaWR4XS5zaXplOw0KPiANCg0KLi4uSW4gdGhpcyBjYXNlLCBJIHRoaW5r IHdlIGRvbid0IG5lZWQgdG8gYWRqdXN0IHRoaXMgbGluZSB0bzoNCiplbmQgPSBlODIwLm1hcFtp ZHhdLmFkZHIgKyBlODIwLm1hcFtpZHhdLnNpemUgLSAxOw0KQXMgd2UgaGF2ZSBtZW50aW9uZWQg dGhlIHJhbmdlIGlzIFtzdGFydCwgZW5kKS4NCg0KPiBOaXQ6IFdvdWxkIGJlIHNob3J0ZXIgdG8g cmVhZCBpZiB5b3UgKHJlKXVzZWQgKnN0YXJ0Lg0KPiANCg0KQWNrLg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:56:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:56:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366480.597272 (Exim 4.92) (envelope-from ) id 1oBa2N-0002si-6f; Wed, 13 Jul 2022 10:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366480.597272; Wed, 13 Jul 2022 10:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBa2N-0002sb-3d; Wed, 13 Jul 2022 10:56:11 +0000 Received: by outflank-mailman (input) for mailman id 366480; Wed, 13 Jul 2022 10:56:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBa2M-0002sV-Is for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:56:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 66886c81-029a-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 12:56:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU0PR04MB9297.eurprd04.prod.outlook.com (2603:10a6:10:354::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 10:56:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 10:56:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 66886c81-029a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDe7ckSL8yoquC85WXXYFVxnaJ/OkaNFkCz4HssQu/vbA8b4mkgSxJ+mYjL69Mu8/ZvDY+/QsKAXOU1mGIzZ6PIJU7uK+8d+ZeKZylJQPwr66/YO1ejbbWnIgQDz2u0RlG8XmpigFEO7SF3aYPES48tS9h7LxCJZK5JaXKvTVh8tHWMZS+Lp+DcgjDc6/09tZAEnZAq8svCmy/7a5EBlQk2+SEhL3D5XS1siGRIw6w5QFPJYPQDRuHVfcv68wHGTFfqomBqEvbDNblMZOFt0qJYzqsSPLXsgGl6pXl2AEOZDH1sx2c+/5V4MQA3NvI5X3EeBYQ5LIBdKhun6f7/Xrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iBv92jFERIyUUuSdPy5W7MkGC5RJaQFYPDo0M5aO2w8=; b=DnUght/esJmYfwVoCrYVa2UmuhhakGB5ycB4cAgBicf+amKh6VFsfryHt0Fs2NrSEMuzZ8KM9ibgE64OXO/pQ4/rRnO2ba+eIeWN3c9/RSyZYWXSatrsX873qtut3/ijnXO3wATzdGK6Odz6G4dtprexIIjXAS/sCQA1u2LA6VEL3GVm449DQL2sO2twEE4APwI9030bNCAdOt2n1jKGyd1hJTJF0DUlavKYVNdtj+8HWiAsc5UnJM41hxc566Gv3WQJ/GxnYocRFsehLw/hsh5OVpRxVkR22mNJ38bTyOG47Z90mrcGIfjnH1Is6mt/gSTORR7zg6vcuUKvctxIdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iBv92jFERIyUUuSdPy5W7MkGC5RJaQFYPDo0M5aO2w8=; b=kZ8eQ183v2H6QLPsgYh4U0E5F0FxVQimD9EiSjBTUZc0nWcyMXNXeP8HaEATUX2B5tXwsY3jmsvVoNoX6K7RSjt0h85jxJhqy0+yz+nfOhndWFOsjXlqQb/eDbHkxZ+9fWvC1e0C8US3Z67CJPjrRnvUfxW4I/VOwmoiPG7C1YbGlzLdzBCYgzn8/eh9bG2X7WgUWWRlGGiS0ZFQ08jtkjtJ1XwcFlJHCrHBHX+OLaTx5dB9cjjJf8JwRK0DhjB8MOxUkrBOeHTfw1AizGuBJIrWiiTIw27W2MEit6pX43pzaOfTcS6uxQ4eBpVaNI2vpCqRBNp5jgQBm3lIpI9y5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> Date: Wed, 13 Jul 2022 12:56:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Julien Grall Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> From: Jan Beulich In-Reply-To: <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0027.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c69f99b9-bd2e-4b80-a8bb-08da64be49a0 X-MS-TrafficTypeDiagnostic: DU0PR04MB9297:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TiG0vE/afUjrxalCi5PfJXUWlAzUJzs89myhQpVYQs0PUQDTpYul+KI+MQO3JHOvzjTrSgkkpuTcrlOxufkk4nhIxlQFgp4Nis0qcYDh7BMy86Bt4gJ1DyPhr09/CRmUuUydfx4YU1O8LEuBHp1nka0nHi5GXBBlfkKAAP/CI9n8LTV5DLKQv2+HbPrf2SOzgZ0XQkSUtfdWUbRERVPBKviXmbUXAuMRiVU5j1OyFXDrdnBnQo0xp8O7mIexEzGPh1uZsE9gYgtePtkQLTQN0gYZI9B1D06/s4k8Kpc6Vib4XPBxzT7hYWdVyxgJ6qEyBx1nmyt4rEMkTmJxBWeYeY0hZY66AgQxSpNEmijxSmy80Kav5rnEo5jPv2v40SmeUilgTpJ6FV4wrqe8+5BLrcWjS4oYV+YtQMbICewNWlaEwSWMEAT6oscy7I05JupUONvnkrtz/VxDNX477CRjwzMwjb1PR8t6keRno7vDCu29jJ7gw/xHRECzjP5SgNoo4mf3osJxTCJJaIua43GR6BPjCrHi+PkAQgF0wWkWxJIthsjbHczXCwwU+6bCF+vTFabz7d/9XBcNbchpFAd9SfaWvz5WiRu0dRvqRjRBxgMtVw75CgeWQvSBSSCo8q8sAtZ9ubLgJpOVLgcXFqkde7KiE0WdOYO62yejbnUQnrepHeGuLTuKpM6B1jrkGSeyjmuJOU0j4PPAwxP9fPckrdAkxk3V3QCPPkS+5x9V+r0gDR1x9/Vq1YQxv8xUxGj/Y1QhyK9c2MF1K4avah/lgVNvy57ZPC0EHum89y9EexJZBwLiA30OGA22hHfgQvoj4jxtp8fkH+pIF/n6AwMIfxkZxXekEJvmC2IRQh9dbeI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(346002)(39860400002)(366004)(396003)(186003)(38100700002)(2616005)(31686004)(2906002)(36756003)(5660300002)(8936002)(66556008)(66946007)(8676002)(26005)(478600001)(41300700001)(6506007)(6486002)(6512007)(4326008)(83380400001)(66476007)(53546011)(86362001)(31696002)(54906003)(316002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ektMeXg0cTdCMktxc01DL2ZrSk1qdGxORVc0MkxYV2RJVVdpek1iSTFPUjRz?= =?utf-8?B?a2pZWGNoMlFFZTNXZTJUMit0OEdGZjVyR2pLWHlsajlZcW1IQ1loazhTaExF?= =?utf-8?B?eEY0dmxqellGVUt4ay90RGMyMGh1UTFuK0Z2TW5aMWs4M21nVlQreDQ5SWpi?= =?utf-8?B?WVpxS3kyMWEza2JsMGRRaGNnZkJtSExCYjN3Wm9STzNQMkN3ZmlEbjdLVEIz?= =?utf-8?B?dHgyYkQ2S3h0cGZjMmdwWlZHUDRuRjRIaE53N2ZyMU1lRWRIZUkxNnNVZk5m?= =?utf-8?B?YmxCNzExR0JOYUlCSXhSWnpjNENRT25IQmhlS3EwemkwSjdKT1VwNlQrQVkv?= =?utf-8?B?TVBFL0NsUDk2cnBlR1hmS2Q4Snl3bk96SWV3am1YbUQ4UEpoUG5rUXJuT1Z1?= =?utf-8?B?YVA0SEVBS2diVklFaG5nZ0ptZ0d5blhOaGVJRDF6dHlzN1FybDlmNW94Q0JR?= =?utf-8?B?clVQSWdDT2xhdEw4TnViRkFiNVdEY0RXRGtRSktVaHNldTZyWXdSeDN2QXl1?= =?utf-8?B?R1BHRTRhTmorYVV0a3k2MmcwU2Y4OTFjdzFxMjRIbXk1a2RKSXdsUUxndU1r?= =?utf-8?B?bVg5Y2wySVhqdmgxT3IvNERCTzZ1WUU1NTZLUDZmaUdjeTJEOTZwczBmaEhF?= =?utf-8?B?UVB5SlRyYm9kZy9GeFE4b3hyL00vNHk1cGFOb0MrdmtIQ0VuN1RGSU9lZTJZ?= =?utf-8?B?UnZIQXR2Z1llZCtrNmw5M0F5aEhTZFZ3S29uRjJjSXYrUTNEbWkxTDdLUjE0?= =?utf-8?B?dXFDRHNVc2RNNnROWVRyTVl1dzlQRWFDR1hISStwVkwybXBDbEhZWmFEa3RB?= =?utf-8?B?aGdqbkNoa3htQmRaSVh4UWVDZGZwL0EvYU5FY1lpTCs1eEovTE8rSnpMcno4?= =?utf-8?B?S0hRSnI1OXQ5c1dYZnZEZHBVQUxSbktwdXNadTVDMDlodURSNUFlL1Z6TjUw?= =?utf-8?B?ekxSZ3E1TWtDSS8vQ2hOMXhKbEhHQUsvMThiZlYrSUx0eDMxV2JFeGVVMUpL?= =?utf-8?B?cWNYcGVNWmhpeTdaSjlFTkFnbENPRjNuc3JQYVhhZVI0SlFXMXpyV1Q3WW9L?= =?utf-8?B?S0VpbHBnWWNIaTFzemJiSDRpY3BJcVBtTnoyQ01IUUZ5ZU1oRjJpK0NKbUVB?= =?utf-8?B?THdQNGhCdXBhUS8zNkk5MVY2c3k3dnRkREZ3Q2k5V0RNVFlESFdzWGdYS3Rt?= =?utf-8?B?MXpyRm42MGd4ZldCY0RqQXVWQU5od09UT3Q0S05WMXc0NmVldmZCMlA0cjgz?= =?utf-8?B?cGdJYVp4QjN4cW9TeTJ1S3R0RksyRVV2OW5tRmhXNFNPclRKVmJTb1NEUDh5?= =?utf-8?B?YTlzeWZWcDRqYUZxTlhUU01RaFVWbHU4MUt2U1dPeStFVWt2N01PVjlOanpG?= =?utf-8?B?RUFQM05OeE9hTEFydmlQSlpiRDBZSjlNUzdWYUJ0VUVlMC9PcVJETG5vTHZU?= =?utf-8?B?YldYNFpJbzlrZVM3VGJmUkJITG1qMzFMYklaRXdzZkl2ZmJWVzMxUWpDMFk1?= =?utf-8?B?VTUrcStsU2FtSGp2TXVPTThyUXJWNkVvY1lWcWxKY28wL1NkUkdMbVIwd3o4?= =?utf-8?B?aHBudWtvUjI5OVR4cTlHeVRFOGNlME1aWHJJa2lNUytCZ0NyWEZvcXN1RXkz?= =?utf-8?B?aTVjaW13WDZHYVFzZStTd09rVE1KUkJxb3hweDBRQndJYTdsOHVqNFFqR1Fq?= =?utf-8?B?cHB3dHNINEwyRjRCUWc1VWVLcDl2dXdCQ1A0ZzhUMm1jUkcwU0JFakdkSlVW?= =?utf-8?B?QzJNUU44Q3VnRzlWYTUzcitBeko0NE9Za1ZyRzNBK0Uyd3pEVUhiekdrckRM?= =?utf-8?B?S1VyT0xmTmtaTlFUbVR3UVM4SEhoSVVZcTk3dk9IWUYxd1hwOFBEQ0ZESzJl?= =?utf-8?B?b0lhWXAzUTdQZ0dJYmE0bVRZV3l2anY4NmxQNmdWbHB6SE56a3Q4ZWVuZDhW?= =?utf-8?B?bDB0L3FFQmtzYnV0K0RCdXhjNWtRTUFWcHRBZ25tMzZocThNKzZZajRxMXBN?= =?utf-8?B?Y2JCaEFXaU5hL2djbWhNMU92Uy9IYmJLRlZKTHJCODEvQzAzS0kxdzhpMzJr?= =?utf-8?B?M3NLRnlUbitncUVNT2NIUER0RDB1L0dxU1dIVTMvSDZzaUxYNUg0Uno4eEE5?= =?utf-8?Q?1sDbodMwV62PatFbSi2K1QtVR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c69f99b9-bd2e-4b80-a8bb-08da64be49a0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:56:06.9582 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: P4E359YnXzlDqANVEWf6m0k4t4kna1LxRv+ZCQCvhLSbuh3CbldApz6EGW/tZIOeVe6mwBNjpNloXVXwy0zYdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9297 On 13.07.2022 12:18, Julien Grall wrote: > On 13/07/2022 10:53, Jan Beulich wrote: >> On 13.07.2022 11:35, Julien Grall wrote: >>> On 13/07/2022 07:21, Jan Beulich wrote: >>>>>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>>>>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>>>>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>>>>> In this way, we can avoid allocating a lot of memory to fill the hole. >>>>>> >>>>>> Let me know your view on this. >>>>>> >>>>>> config MAX_STATIC_PORT >>>>>> int "Maximum number of static ports” >>>>>> range 1 4095 >>>>>> help >>>>>> Controls the build-time maximum number of static port supported >>>>> >>>>> The problem is not exclusive to the static event channel. So I don't >>>>> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >>>>> (even though this is the only user today). >>>>> >>>>> A few of alternative solutions: >>>>> 1) Handle preemption in alloc_evtchn_bucket() >>>>> 2) Allocate all the buckets when the domain is created (the max >>>>> numbers event channel is known). We may need to think about preemption >>>>> 3) Tweak is_port_valid() to check if the bucket is valid. This would >>>>> introduce a couple of extra memory access (might be OK as the bucket >>>>> would be accessed afterwards) and we would need to update some users. >>>>> >>>>> At the moment, 3) is appealing me the most. I would be interested to >>>>> have an opionions from the other maintainers. >>>> >>>> Fwiw of the named alternatives I would also prefer 3. Whether things >>>> really need generalizing at this point I'm not sure, though. >>> I am worry that we may end up to forget that we had non-generaic way >>> (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up >>> to mistakenly introduce a security issue. >>> >>> However, my point was less about generalization but more about >>> introducing CONFIG_MAX_STATIC_PORT. >>> >>> It seems strange to let the admin to decide the maximum number of static >>> port supported. >> >> Why (assuming s/admin/build admin/)? I view both a build time upper bound >> as well as (alternatively) a command line driven upper bound as reasonable >> (in the latter case there of course still would want/need to be an upper >> bound on what is legitimate to specify from the command line). Using >> static ports after all means there's a static largest port number. >> Determined across all intended uses of a build such an upper bound can be >> a feasible mechanism. > > AFAICT, the limit is only here to mitigate the risk with the patch I > proposed. With a proper fix, the limit would be articial and therefore > it is not clear why the admin should be able to configure it (even > temporarily). The limit would be as artificial as other limits we enforce. I can't see why it would be wrong to have a more tight limit on static ports than on traditional ("dynamic") ones. Even if only to make sure so many dynamic ones are left. That said, ... > Instead, I think we want to have a limit that apply for both statically > and dynamically allocated even channel. This is what d->max_evtchn_port > is for. ... I also have no issue with following your way of thinking. I view both perspectives as valid ones to take. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 10:57:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 10:57:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366486.597283 (Exim 4.92) (envelope-from ) id 1oBa41-0003fe-ID; Wed, 13 Jul 2022 10:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366486.597283; Wed, 13 Jul 2022 10:57:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBa41-0003fX-Eh; Wed, 13 Jul 2022 10:57:53 +0000 Received: by outflank-mailman (input) for mailman id 366486; Wed, 13 Jul 2022 10:57:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBa3z-0003fO-Vs for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 10:57:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70043.outbound.protection.outlook.com [40.107.7.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a27e5de3-029a-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 12:57:49 +0200 (CEST) Received: from DB7PR03CA0096.eurprd03.prod.outlook.com (2603:10a6:10:72::37) by DU0PR08MB7591.eurprd08.prod.outlook.com (2603:10a6:10:31d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 10:57:47 +0000 Received: from DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::72) by DB7PR03CA0096.outlook.office365.com (2603:10a6:10:72::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Wed, 13 Jul 2022 10:57:47 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT022.mail.protection.outlook.com (100.127.142.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 10:57:47 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Wed, 13 Jul 2022 10:57:47 +0000 Received: from 3d49880b7065.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 522FA513-5E9F-4DC7-8C6C-A3B4B05C35CA.1; Wed, 13 Jul 2022 10:57:40 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3d49880b7065.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 10:57:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB6736.eurprd08.prod.outlook.com (2603:10a6:102:13e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 10:57:38 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 10:57:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a27e5de3-029a-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dZfjOlrAjqXnWHFn3sSxZOUUMxOFvfJRrOfOe6ytoaqY7TQWNx01SI2ilHOKL+fSbLxmD4rZmOaS7w/Jzsi8nb75eDcRHdo6c2DBc2z3isHv0kuR23NWV/ALBvz8VlZBu+InzJ7HjhFK8Plnt85PQ7h1cOtmrGtmrFwGDjtqIZ3vOigY4IfVopGrjudn1m5z23tV8yLnEPe8D7yKqMATaBOMX0dAD+wCHyLsiJ3GfGdnJ/xVD/zo84A/HnZw+wJPfSWnTFgmgxWt2q5pN2o9QFv0me6PpZt5xHGmqrByO1uYGXmPlj6I6luxnZ7mQ7qStHUoL/bS2tOQ4eCFJ6NEjA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCmnoGlduf3Wjof3Fd/mchffRshtX3rIq+qGkCBrN+I=; b=IQ8bXkU3j1kKVbBfLcxfHHuBUfEQxqnvUFOcC/jYm0LmnCpBZC4kGz+5sM3oay3n7ddEWi4PhBeXhAu7p5c+VToM9bEvtAbdoJsNKJatjCvYwDTBo1+rFl7nlLpof4gM8N9m5HTKUMmOA/l557kUHtz/ocog5i3/dTRrX9rFUX96GkvDZpKI4QpNN3cnxrGF+k5UmOAlRA82FJcp8cGp7qvcBeMj1PQ6bYBOUPs6PwattXTshKP4fBX7ckzn57np/P00s1G7T+IVNgiEeWD5F5Qv/sc3qobHJoTtDMCV6MCfaSwYVdtr3fifdj14gFBR2zGHpMLdwVnmEuiv/kBmZw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCmnoGlduf3Wjof3Fd/mchffRshtX3rIq+qGkCBrN+I=; b=aRDSq3+USKV3yGgI/m6T5WMLtkPeZ/V1w6twlNkG1Yq/Ufrm3LH1wY4j+XrZ3SMzc6gZaoECkjbWdEzzd6CY7evfTFyeylPP7fFu6gejNnhXCI+WJYncRKEwMb/vjdX4lycdpbd47pstxwYqbdpCHT9WJuCtv20UqSJLRhtY7+Q= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejEKUODl4GirKhx9OB1Au/ONBGyelpu/IZl7Q43x5eLb8ArfgLbFxSPiKdyGE5sTan1aOvzhnLQna5MkxTSzjwb6+Aqw9ss+aqwlsGLt8bdlvpS+woKrMHPDGTNG8Jvj4k7rTAu8vKlvY5gDCwVmOCXFK0PPFBPHs9MybcrqzXgW48b5RcSGH6OpJDhckeW8Rlk4KMacrB5AG2lAybzx7yBywscTofts4WHE5H3uRjJqFQq2lmHrfuVE10FEs+lsft++X6v+TTe38aJYUxctRQpYXBXToD8k8IAMK2S78zuZQuQp1AYyOhx1fUPDSMfKGohu9YGcDpXkWsSEW3Z3ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qCmnoGlduf3Wjof3Fd/mchffRshtX3rIq+qGkCBrN+I=; b=Z+zJwqbLNs00W5dkok7ezqhvetvvXCZ18ufJeM9oI4YHSCLJLPlf3xE8UIMDxa1s+y8NW9eGIIxTfV2vuQNj13KPM6AAdBHvKhOlBaEcwCAqL5yCTdbjhMw+AHeIDKOfMA5PC/0jh/laxNmSQRwlL8aar8rRuDkfgD7I0Jk8Ou1B4685QrHNB4m19c6emZ6boMFoTMMMiwLphxZT3QhnntR7OWcmOX7UvCdA8Yoyih9C/sMfkGkSV/m2TudiN0NQLnYmed2HHW/KlLjK+nodjYXI2sU0y3reG2mUKmkHDN2SA8aq7JeefXuYHETjA6DMHxGoySj2CZgNjCY1Whz/Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qCmnoGlduf3Wjof3Fd/mchffRshtX3rIq+qGkCBrN+I=; b=aRDSq3+USKV3yGgI/m6T5WMLtkPeZ/V1w6twlNkG1Yq/Ufrm3LH1wY4j+XrZ3SMzc6gZaoECkjbWdEzzd6CY7evfTFyeylPP7fFu6gejNnhXCI+WJYncRKEwMb/vjdX4lycdpbd47pstxwYqbdpCHT9WJuCtv20UqSJLRhtY7+Q= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Topic: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 to common Thread-Index: AQHYktrGVPLQPv5uj0Cju/uWI8P+lq16z5KAgAFVoUA= Date: Wed, 13 Jul 2022 10:57:38 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-7-wei.chen@arm.com> <357fc6ee-3014-4be9-9bf4-60669a4ca914@suse.com> In-Reply-To: <357fc6ee-3014-4be9-9bf4-60669a4ca914@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AEA303847BBB0040B77DFB5099FBFDC7.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f0e97da3-5bb9-4e04-96ac-08da64be85bd x-ms-traffictypediagnostic: PAXPR08MB6736:EE_|DBAEUR03FT022:EE_|DU0PR08MB7591:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DNJeCoN9YMsOHyCHvPPH9Y8FcBMnp6CMQXm9DIxYey+amM4EhcJhvsMzmBT4FT3vn/g8qT+D+vEEYdgYwRfHGd5MY32MGI/tVFvPn3uax7c3Zf4mTttJ4GqysslRe8peTib2k350HN988j2kPG1uRPCiPwqU4ryzVn7GnFuB3uWRmVYXdAw+4SOLG5SwoLM+YxU0z0KXt+HMhQaJWDWsHdYD9weDIHqGdjBrCHhf4PqKaRh69nRWZ8leVQKJzA0aHd2QFjcibZEl90kj6YJawRkjVvAjxgErtkL+7RCEoxQ3qUxjD2tSS9QPh+X9JsoDe0c9zGDGPXmUVKU67Z40owhKgklimiHDkDvK3Nwy4YDPtCwXGXhako0RmSBvygeCNF7Qv0/RJn4dm0yML4rvAfQ3Rl4lOYY+8pHM29wSIZan6i4ByQd24cgl1NYMvMzY1H1mI6t2CGakvCoqguzxfqklC4bgx1sJHkTlrIdldZU8UL/IEgsKApYI4cIF014bcS23ier88o5aoO+9mAGxeJ2IPa8M8GLxTCE8AOzkNzrOzmoMxnWJX0YvwUj3J9NNrEA62Or9Dl5m87cC82aK8T9o3KUJVVAPmsmgnurJURCX+R1YlVp/qlx1o2opsVNwVtLmduLcHCHp7aloBcUnhsbAXJagPgMIcB+0rvsOcF6qV3hFv5Sx2+b8u6Fe4IHPW724IEwUmQrorXubIts7JBhgyltnY3ymKu4FovQCLqIv9GuVzB4d1TssKYyiA05HzHnKUz6TubRJF/X6Rex8J7fiNOde4TNKznW3vUF4jGcULEBdRR5OeEDG+9MlPurl X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(4326008)(7696005)(6506007)(8676002)(76116006)(53546011)(26005)(66556008)(66476007)(122000001)(66946007)(64756008)(66446008)(52536014)(186003)(41300700001)(8936002)(9686003)(316002)(38100700002)(38070700005)(5660300002)(6916009)(478600001)(83380400001)(33656002)(54906003)(55016003)(2906002)(86362001)(71200400001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6736 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7318e302-b5b3-4717-e301-08da64be8043 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MLFEiwL/+hdt/g2NNUMvXSf4nP00NymsHL+YTai/CSHpTMfl4nI3vL4tuy5hyg3XE0XoHXiWPUk4NJWN6irCzBhFYiSu/ouxWt0HbcNVi4GWk8XrRn3ByjtLc5Ri8R1cp8NNH0tU6VD6rYK6S7rbFpJZ5v2Zz3conVVJUEdJrGEzmdJ7tugCYZaAPwH1qLq5uzNNKw8h/5Qf2HsGyGVzwEEtT6iv3YaK49lf6Y+mRbOGffhCMSOcF2pBeImYu+Ym8QXI01yINhgYPs085JBYBShbxn1rqZNcz0fzrWoosEUyixabsdelpA3VgAWIKNG6at5SBH2DU1IrAqqrJIDMZuR6EW7j4wSump/giUsQvvXfcBxzhDb9GZCAt1aMQkOMCLNvIAO1G4cklZjyga/j2Rt5J8iaX9BHXXtGjVnsks0xN/qXDL0LTcXb2XHbm0w25vqmv9COcQ24LAPO6662YUGqsBHmM8nIFjuUHlB9VLTmkVEpGt2olYYuIZy2iv1EhyHrK6ZQ1ghjLlG31QDrKAptmLJZPu47JFvHY4/neVdDmlzS+/9KStRxwgj+izU+z+U5SH3NIgpgWErGHxwIkmms0yZGKL1Jz2UGUvC4w+0RBzHPPy0wM8kJfUarnlL/p/IZSwCXuK9mvzkzdFsoXW37g0KGC84EoYrpV/Wl0Q5Fhfy3yCQwHYNLfBbU/XuvhFk1Pl5/3cji9IzfnMYV/hGBkxA22wn+0BxWsyAO4zpeBQ0kEBS2Apjz8P/pvGF+mEB4QRi6D9REj6q5eULGdprSt8dg+oELtA4/O1CgRUi8mnEYXYw7zIfd6OJuyItE X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(346002)(136003)(36840700001)(40470700004)(46966006)(5660300002)(40460700003)(83380400001)(8936002)(186003)(9686003)(40480700001)(55016003)(336012)(82310400005)(356005)(36860700001)(6862004)(52536014)(2906002)(82740400003)(86362001)(70206006)(54906003)(26005)(478600001)(70586007)(33656002)(316002)(4326008)(53546011)(6506007)(8676002)(47076005)(41300700001)(81166007)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 10:57:47.6704 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0e97da3-5bb9-4e04-96ac-08da64be85bd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7591 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMjoyMQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgNi85XSB4ZW4veDg2OiBtb3ZlIE5VTUEgc2NhbiBub2RlcyBjb2RlcyBmcm9tIHg4Ng0K PiB0byBjb21tb24NCj4gDQo+IE9uIDA4LjA3LjIwMjIgMTY6NTQsIFdlaSBDaGVuIHdyb3RlOg0K PiA+IHg4NiBoYXMgaW1wbGVtZW50ZWQgYSBzZXQgb2YgY29kZXMgdG8gc2NhbiBOVU1BIG5vZGVz LiBUaGVzZQ0KPiA+IGNvZGVzIHdpbGwgcGFyc2UgTlVNQSBtZW1vcnkgYW5kIHByb2Nlc3NvciBp bmZvcm1hdGlvbiBmcm9tDQo+ID4gQUNQSSBTUkFUIHRhYmxlLiBCdXQgZXhjZXB0IHNvbWUgQUNQ SSBzcGVjaWZpYyBjb2RlcywgbW9zdA0KPiA+IG9mIHRoZSBzY2FuIGNvZGVzIGxpa2UgbWVtb3J5 IGJsb2NrcyB2YWxpZGF0aW9uLCBub2RlIG1lbW9yeQ0KPiA+IHJhbmdlIHVwZGF0ZXMgYW5kIHNv bWUgc2FuaXR5IGNoZWNrIGNhbiBiZSByZXVzZWQgYnkgb3RoZXINCj4gPiBOVU1BIGltcGxlbWVu dGF0aW9uLg0KPiA+DQo+ID4gU28gaW4gdGhpcyBwYXRjaCwgd2UgbW92ZSBzb21lIHZhcmlhYmxl cyBhbmQgcmVsYXRlZCBmdW5jdGlvbnMNCj4gPiBmb3IgTlVNQSBtZW1vcnkgYW5kIHByb2Nlc3Nv ciB0byBjb21tb24gY29kZS4gQXQgdGhlIHNhbWUgdGltZSwNCj4gPiBudW1hX3NldF9wcm9jZXNz b3Jfbm9kZXNfcGFyc2VkIGhhcyBiZWVuIGludHJvZHVjZWQgZm9yIEFDUEkNCj4gPiBzcGVjaWZp YyBjb2RlIHRvIHVwZGF0ZSBwcm9jZXNzb3IgcGFyc2luZyByZXN1bHRzLiBXaXRoIHRoaXMNCj4g PiBoZWxwZXIsIHdlIGNhbiBtb3ZlIG1vc3Qgb2YgTlVNQSBtZW1vcnkgYWZmaW5pdHkgaW5pdCBj b2RlIGZyb20NCj4gPiBBQ1BJLiBBbmQgYmFkX3NyYXQgYW5kIG5vZGVfdG9fcHhtIGZ1bmN0aW9u cyBoYXZlIGJlZW4gZXhwb3J0ZWQNCj4gPiBmb3IgY29tbW9uIGNvZGUgdG8gZG8gYXJjaGl0ZWN0 dXJhbCBmYWxsYmFjayBhbmQgbm9kZSB0byBwcm94aW1pdHkNCj4gPiBjb252ZXJ0aW5nLg0KPiAN Cj4gSSBjb25zaWRlciBpdCB3cm9uZyBmb3IgZ2VuZXJpYyAoQUNQSS1pbmRlcGVuZGVudCkgY29k ZSB0byB1c2UNCj4gdGVybXMgbGlrZSAic3JhdCIgb3IgInB4bSIuIFRoaXMgd2FudHMgYWJzdHJh Y3RpbmcgaW4gc29tZSB3YXksDQo+IGFsYmVpdCBJIGhhdmUgdG8gYWRtaXQgSSBsYWNrIGEgZ29v ZCBpZGVhIGZvciBhIHN1Z2dlc3Rpb24gcmlnaHQNCj4gbm93Lg0KPiANCg0KTWF5YmUgd2UgY2Fu IHVzZSBmd19yc2NfdGFibGUgb3IgcnNjX3RhYmxlIHRvIHJlcGxhY2Ugc3JhdCwgYmVjYXVzZQ0K c3JhdCBpcyBvbmUga2luZCBvZiBOVU1BIHJlc291cmNlIGRlc2NyaXB0aW9uIHRhYmxlIG9mIEFD UEk/DQpGb3IgUFhNLCBJIGhhZCB0cmllZCB0byBrZWVwIFBYTSBpbiB4ODYgQUNQSSBpbXBsZW1l bnRhdGlvbi4gQnV0IHRoZQ0KY29zdCBpcyB0aGF0LCB3ZSBoYXZlIHRvIG1vdmUgc29tZSBjb21t b24gY29kZSB0byBhcmNoaXRlY3R1cmFsIGNvZGUsDQpiZWNhdXNlIHNvbWUgbWVzc2FnZXMgdXNl IHB4bSBmb3IgaW5mbywgYW5kIHRoZXkgaGF2ZSBkaWZmZXJlbnQgbWVhbmluZ3MNCmZvciBlYWNo IHBsYXRmb3JtLCB3ZSBjYW5ub3Qgc2ltcGx5IHJlbW92ZSB0aGVtLg0KDQo+ID4gRm9yIHRob3Nl IE5VTUEgaW1wbGVtZW50YXRpb25zIGhhdmVuJ3Qgc3VwcG9ydGVkDQo+ID4gcHJveGltaXR5IGRv bWFpbiB0byBub2RlIG1hcC4gQSBzaW1wbGUgMS0xIG1hcHBpbmcgaGVscGVyIGNhbiBoZWxwDQo+ ID4gdXMgdG8gYXZvaWQgdGhlIG1vZGlmaWNhdGlvbiBvZiBzb21lIHZlcnkgdmFsdWFibGUgcHJp bnQgbWVzc2FnZXMuDQo+IA0KPiBJIGRvbid0IHRoaW5rIGEgc2ltcGxlIDE6MSBtYXBwaW5nIGNh biBkby4gU3VyZWx5IGZpcm13YXJlDQo+IHJlcHJlc2VudHMgbm9kZXMgYnkgc29tZSBpZGVudGlm aWVycyBldmVyeXdoZXJlLiBBbmQgSSBkb24ndA0KPiBjb25zaWRlciBpdCB2ZXJ5IGxpa2VseSB0 aGF0IHdlIHdvdWxkIHdhbnQgdG8gYmxpbmRseSByZS11c2UNCj4gc3VjaCBudW1iZXJpbmcgaW5z aWRlIFhlbi4NCj4gDQoNCklmIHdlIGhpZGUgcHhtIHRvIHg4NiBvbmx5IG5vdywgd2UgY2FuIGF2 b2lkIHRoaXMgMToxIG1hcHBpbmcgYmV0d2Vlbg0KTm9kZSBhbmQgUFhNLg0KDQo+ID4gLS0tIGEv eGVuL2NvbW1vbi9udW1hLmMNCj4gPiArKysgYi94ZW4vY29tbW9uL251bWEuYw0KPiA+IEBAIC0x NCw2ICsxNCwyMSBAQA0KPiA+ICAjaW5jbHVkZSA8eGVuL3NvZnRpcnEuaD4NCj4gPiAgI2luY2x1 ZGUgPGFzbS9hY3BpLmg+DQo+ID4NCj4gPiArc3RhdGljIG5vZGVtYXNrX3QgX19pbml0ZGF0YSBw cm9jZXNzb3Jfbm9kZXNfcGFyc2VkOw0KPiA+ICtzdGF0aWMgbm9kZW1hc2tfdCBfX2luaXRkYXRh IG1lbW9yeV9ub2Rlc19wYXJzZWQ7DQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgbm9kZSBfX2luaXRkYXRh IG5vZGVzW01BWF9OVU1OT0RFU107DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW50IG51bV9ub2RlX21l bWJsa3M7DQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgbm9kZSBub2RlX21lbWJsa19yYW5nZVtOUl9OT0RF X01FTUJMS1NdOw0KPiA+ICtzdGF0aWMgbm9kZWlkX3QgbWVtYmxrX25vZGVpZFtOUl9OT0RFX01F TUJMS1NdOw0KPiANCj4gU29tZSAoYWxsKSBvZiB0aGVzZSBsaWtlbHkgd2FudCB0byBiZWNvbWUg X19yZWFkX21vc3RseSBhZ2FpbiwgYXQNCj4gdGhpcyBvY2Nhc2lvbi4NCj4gDQoNCk9rLg0KDQo+ ID4gQEAgLTMyLDYgKzQ3LDI5OCBAQCBub2RlbWFza190IF9fcmVhZF9tb3N0bHkgbm9kZV9vbmxp bmVfbWFwID0geyB7IFswXSA9DQo+IDFVTCB9IH07DQo+ID4NCj4gPiAgZW51bSBudW1hX21vZGUg bnVtYV9zdGF0dXM7DQo+ID4NCj4gPiArdm9pZCBfX2luaXQgbnVtYV9zZXRfcHJvY2Vzc29yX25v ZGVzX3BhcnNlZChub2RlaWRfdCBub2RlKQ0KPiA+ICt7DQo+ID4gKyAgICBub2RlX3NldChub2Rl LCBwcm9jZXNzb3Jfbm9kZXNfcGFyc2VkKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiAraW50IHZhbGlk X251bWFfcmFuZ2UocGFkZHJfdCBzdGFydCwgcGFkZHJfdCBlbmQsIG5vZGVpZF90IG5vZGUpDQo+ ID4gK3sNCj4gPiArICAgIGludCBpOw0KPiANCj4gdW5zaWduZWQgaW50PyBUaGVuIG1hdGNoaW5n IGUuZy4gLi4uDQo+IA0KDQpPay4NCg0KPiA+ICtzdGF0aWMNCj4gPiArZW51bSBjb25mbGljdHMg X19pbml0IGNvbmZsaWN0aW5nX21lbWJsa3Mobm9kZWlkX3QgbmlkLCBwYWRkcl90IHN0YXJ0LA0K PiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwYWRkcl90IGVu ZCwgcGFkZHJfdCBuZF9zdGFydCwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcGFkZHJfdCBuZF9lbmQsIHVuc2lnbmVkIGludA0KPiAqbWJsa2lkKQ0KPiA+ ICt7DQo+ID4gKyAgICB1bnNpZ25lZCBpbnQgaTsNCj4gDQo+IC4uLiB0aGlzLiBCdXQgcGVyaGFw cyBhbHNvIGVsc2V3aGVyZS4NCj4gDQoNCkkgd2lsbCBjaGVjayB0aGUgY29kZSBhbiBmaXggdGhl bS4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 13 11:11:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 11:11:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366494.597293 (Exim 4.92) (envelope-from ) id 1oBaGb-0006HN-RO; Wed, 13 Jul 2022 11:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366494.597293; Wed, 13 Jul 2022 11:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaGb-0006HG-Of; Wed, 13 Jul 2022 11:10:53 +0000 Received: by outflank-mailman (input) for mailman id 366494; Wed, 13 Jul 2022 11:10:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaGZ-0006HA-MD for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 11:10:52 +0000 Received: from sonic316-8.consmr.mail.gq1.yahoo.com (sonic316-8.consmr.mail.gq1.yahoo.com [98.137.69.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7255d36b-029c-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 13:10:49 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 11:10:46 +0000 Received: by hermes--production-ne1-7864dcfd54-xmlhn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 4fa3c1912e1ef88022aac278b4afb76f; Wed, 13 Jul 2022 11:10:43 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7255d36b-029c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657710646; bh=TlDx9+/0Iba5/WcaUGXAstvmAgLHzxw7AUpcCHFdh6w=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=crgIlXcuAdJ1/pl0GYJacy0NIkgAkWAoCtagJ1DwJGqgDa7iY4mztTJwZNuQm9so2EUiSHP/Kwk1MkcGEq6TfrhSEmLfMOgMBDS1t81fRUzy/Bqjd0amQEmPfwhShxwm4+mmXGZxmK0yygmUmTK6Hyed8bUaN0kow3ztL85rqCcgYRhnLo4dPK1FpOu1AP/zoHbuV64b08lj3v1UzNEmfNfS1zEW3V09srgqFwfkJy2sedPccketNK6e/2ysFulJ1F3xLRUznQHWZ7XLaywfYQamAfoVjdaR6UHQPl9Gi1ULyLMN6+l0wgnTV8kkmftr+Uus0FID5zGou5YDoaavSw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657710646; bh=+Z/nMLz7K0U7xHXBrCjQgbdLS2XQac5YLav2vbaoCA/=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=LgYPTSesXtUUGlCFmR4smQD9GCg+cBLkEQjbKeZLBgrvWzcoobk8uAijtfofoLRSht5ZOeTZTBnv1mtq0Lv1a8rhEhHlwkuIYfZLTnZTyh/MGhJx6OAqkIGg8rY8siUlu8WUtmsJJVbQ/v+n5M7O+PKStz6omTtDmd8hYXNzmXViJflqsbkXvbYBVwUF1g5vooS+Q9fEgM2cnex93Srb3jy0x5boh8t37haAdVbBtbX6rYaOxENLPbel7eNCmvC4W+tE5sc7IBiMb+L7zpAQx6k8S/8kes92FwneIfMJQb8AiHuELVBfeUYOM7ILLuvE5VROSqQ/XcgsDApdN5dziQ== X-YMail-OSG: YKABTcAVM1ndxzDKVm1ZW23kpVYI0hp7.vRJng3VaX8dn3DoH7gsBk1Qsx1G_Pa gUqboNLOnZIxv6fDnpV6BUc8_vTO.yUJw4zPcYIXK84gSo8OBdXxsMCD6UjAmqf0dN1U0MCeTELt 3h6GAgMLYnjH_VVtMwPEmHfD3L3zn9xMkrnjBCxLEeTzpqPCiorcCjnIoWsYnBoIgv18exvo.aS4 Lyeou8sHq8DsPIaaG3YcTYZMfS_z2siyfDwV6OQPKk8HnMtdAdO.x9nOZXawSO1vlasrELk..W4. gtG81qIHJUvDoSv_N7RvfilVeKle5UvALDwWnC8MxYy0sTsGy4ftNyfrpIH0.YLC7RweJTcu1Y.4 yJHqOersPl_E4B2bJujPp9u7e4yEZnul9_VOjV0EdQZHQEk0hdiqx399oKX7XcUgRqJd5IousN5S 8.6ztR0AqZTOY3XW0NaRCv7zVqubGUyvMKN504lUe.SpdzijtsF2eS0udw8q2QFX9cT3hwruXGJO 3pJsIVbKQyY6h.XpPffiP_7kAXhWeI_bIEkTTFb1NT97N1Dz2Z9aGG9trSkTnHYrmhBJaMssgTjj EI233U8qBvr3XuZ21PH.gqycVRZ9KUXbOOsAVIqhYsfoIhmGF8INLiSpi_khFfifFOiU7fSzSjSx U1FqNJNyCqTmjqRmGDJz8l1IA9NR9hBzjp.LqcCZ.PuwJMzPXWnsq.b4hbCznuRT8YbiXW89Fs7b xW5oiAosDi0dIvj1pMHbhihcGHaaaoL5TPBqJlronJ2KCvMIrrb_U2xKIaOSjQZv0jVNT.9A6ECn OeqxSxJE616vyLONfs1YkQlAxsxl_UnzcRIJL4RNA5nDhP4Z4v.Nt5YHO.P6U193dKyYhC7yZ1JX S7OAYRJ5NQeqsCslBrrdHlf_5pQPYoLc7BKj_r7Z9VAnZOo58S0XIZPIQGomNmNhODLup7uyJfAq vhVuO9X.4GOZpFuZ85Ik.3WqlstQrTQNkkBKgWCQLDXFO59x18Kgr0Frk13U3NjEIb5KYRvcRndm Q.hTefgUNtyFP9RKpIo1w08JDGeEJd1ThfMjbvXs4fKZpA1yNfM.OVNesuPbCFwkVXM5EhHx7iy2 8hdIBFQ.k0BPbcmHYyGUmHqVUQBB.eZ3aakXlB0piy27sa2FEnY8P0yMBOczqBr5Tgcwxzm7pgiF sF7GRiZp0ZPXMZFj2xE_bWR4UhP2w36CWzefVxiAFt2Bl2KVi7.HJMr.2xRkl0K3upDtYh7h5R3g qBHjCenX4Rz5gHIOKxKb1Cv9uYpJ5GsVcDixqmmqjFDRwoc20im9wQZNbt2q1ud3IF8I76zbBguO mg_AnDC6R03xuSSoXjkenwrwcT.ti71QAi6t5wwK4kaCA9sliFSfixEuC21IFYZNut6E17jajWp9 QkkxTYEcfi1hcKaSLLcotFVyTmGqyW6SMkqYPDIpBjPNVtwB.KdlgsxsCprbCZhWjgucHmM6SKFc sDcyo770iMPVyPXYYUSDuAS4b48wdQx0j2jSG9ogHRmWUUvd5WWkhV30m.4Ikpwt_TCLdbfn.M7K q3ENN3rIAeH4mjJc7ugpOfHlWTHY4_ITnQYsYn86ZYe3P573oJMmVMFVC5MrcsK86Syt0OLJPUxk W47YuXy85XGAUd7MhZ.SidSQYX4NFXT_yzC.HeQbaMH01IaJXe2bvqF0pL8TlCvRm2GjoQ8wjZ0J Nb3jpIMPBjGbCtH_X8CiFDrb.tcsFWXkudn4tJNXpE.SZTYdU8cuSPRz2H7Q0xBvZe_9mZxNWSPZ LPMNV.01BKyxtRNEm13yjvHrHA_4pFZcbFdtr_CpXuvB_muAJWP3wmZHGENkeKB8N1gfDjBGVf.j xjtfkdm3DYn4xE1jvHT7WXqNVZfnrxI713ajEbfa5RcpuSahGYTeVQBM3sML4piEJkx_OAr6naAD 1D1mV1AAR7VM7mSRcyMv5K2FvXDA9lK5X0Ey5D4XkXFGe5fv.zpXLOrgRaOFlinzKeVJqghUa9md d9jOK1LfvsEQQODc4dYlJqmLfrzlyMcDN..UmB0KsViNluWX14Un0m4X_OSSzAaAMiyCJuEcENZU 1xW0C6Yb71.6VoJqgHpX5mMUmFk8mIHqk3khsvZzEgamy25P8tfS7FqsAqIN7zbG7jEGC8dp73SS sJE6AEqE3vbeidCCsEz_a_rCHYYrph4JmQKQ3Ml4QFwtB9PmyKmj8WbToU_GZD4TioLU2xwodsQ_ umLmlD_owKQ-- X-Sonic-MF: Message-ID: Date: Wed, 13 Jul 2022 07:10:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Jan Beulich , Juergen Gross Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> In-Reply-To: <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6345 On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > On 7/13/2022 5:09 AM, Jan Beulich wrote: > > On 13.07.2022 10:51, Chuck Zmudzinski wrote: > > > On 7/13/22 2:18 AM, Jan Beulich wrote: > > >> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > > >>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > > >>> *Add the necessary code to incorporate the "nopat" fix > > >>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > > >>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > > >>> *Expand the commit message to include relevant parts of the commit > > >>> message of Jan Beulich's proposed patch for this problem > > >>> *Fix 'else if ... {' placement and indentation > > >>> *Remove indication the backport to stable branches is only back to 5.17.y > > >>> > > >>> I think these changes address all the comments on the original patch > > >>> > > >>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > > >>> include Jan's idea for fixing "nopat" that was missing from the first > > >>> version of the patch. > > >> > > >> You've sufficiently altered this change to clearly no longer want my > > >> S-o-b; unfortunately in fact I think you broke things: > > > > > > Well, I hope we can come to an agreement so I have > > > your S-o-b. But that would probably require me to remove > > > Juergen's R-b. > > > > > >>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > > >>> rdmsrl(MSR_IA32_CR_PAT, pat); > > >>> } > > >>> > > >>> - if (!pat) { > > >>> + if (!pat || pat_force_disabled) { > > >> > > >> By checking the new variable here ... > > >> > > >>> /* > > >>> * No PAT. Emulate the PAT table that corresponds to the two > > >>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > > >>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > > >>> */ > > >>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > >>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > >> > > >> ... you put in place a software view which doesn't match hardware. I > > >> continue to think that ... > > >> > > >>> + } else if (!pat_bp_enabled) { > > >> > > >> ... the variable wants checking here instead (at which point, yes, > > >> this comes quite close to simply being a v2 of my original patch). > > >> > > >> By using !pat_bp_enabled here you actually broaden where the change > > >> would take effect. Iirc Boris had asked to narrow things (besides > > >> voicing opposition to this approach altogether). Even without that > > >> request I wonder whether you aren't going to far with this. > > >> > > >> Jan > > > > > > I thought about checking for the administrator's "nopat" > > > setting where you suggest which would limit the effect > > > of "nopat" to not reporting PAT as enabled to device > > > drivers who query for PAT availability using pat_enabled(). > > > The main reason I did not do that is that due to the fact > > > that we cannot write to the PAT MSR, we cannot really > > > disable PAT. But we come closer to respecting the wishes > > > of the administrator by configuring the caching modes as > > > if PAT is actually disabled by the hardware or firmware > > > when in fact it is not. > > > > > > What would you propose logging as a message when > > > we report PAT as disabled via pat_enabled()? The main > > > reason I did not choose to check the new variable in the > > > new 'else if' block is that I could not figure out what to > > > tell the administrator in that case. I think we would have > > > to log something like, "nopat is set, but we cannot disable > > > PAT, doing our best to disable PAT by not reporting PAT > > > as enabled via pat_enabled(), but that does not guarantee > > > that kernel drivers and components cannot use PAT if they > > > query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > > > instead of pat_enabled()." However, I acknowledge WC mappings > > > would still be disabled because arch_can_pci_mmap_wc() will > > > be false if pat_enabled() is false. > > > > > > Perhaps we also need to log something if we keep the > > > check for "nopat" where I placed it. We could say something > > > like: "nopat is set, but we cannot disable hardware/firmware > > > PAT support, so we are emulating as if there is no PAT support > > > which puts in place a software view that does not match > > > hardware." > > > > > > No matter what, because we cannot write to PAT MSR in > > > the Xen PV case, we probably need to log something to > > > explain the problems associated with trying to honor the > > > administrator's request. Also, what log level should it be. > > > Should it be a pr_warn instead of a pr_info? > > > > I'm afraid I'm the wrong one to answer logging questions. As you > > can see from my original patch, I didn't add any new logging (and > > no addition was requested in the comments that I have got). I also > > don't think "nopat" has ever meant "disable PAT", as the feature > > is either there or not. Instead I think it was always seen as > > "disable fiddling with PAT", which by implication means using > > whatever is there (if the feature / MSR itself is available). > > IIRC, I do think I mentioned in the comments on your patch that > it would be preferable to mention in the commit message that > your patch would change the current behavior of "nopat" on > Xen. The question is, how much do we want to change the > current behavior of "nopat" on Xen. I think if we have to change > the current behavior of "nopat" on Xen and if we are going > to propagate that change to all current stable branches all > the way back to 4.9.y,, we better make a lot of noise about > what we are doing here. > > Chuck And in addition, if we are going to backport this patch to all current stable branches, we better have a really, really, good reason for changing the behavior of "nopat" on Xen. Does such a reason exist? Or perhaps, Juergen, could you accept a v3 of my patch that does not need to decide how to backport the change to "nopat" to the stable branches that are affected by the current behavior of "nopat" on Xen? To do such a v3, I would just have to fix the style problems with my original patch and not come to an agreement with Jan about how to deal with the "nopat" problem. Chuck Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 11:31:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 11:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366500.597304 (Exim 4.92) (envelope-from ) id 1oBaac-0000fO-Go; Wed, 13 Jul 2022 11:31:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366500.597304; Wed, 13 Jul 2022 11:31:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaac-0000fH-EG; Wed, 13 Jul 2022 11:31:34 +0000 Received: by outflank-mailman (input) for mailman id 366500; Wed, 13 Jul 2022 11:31:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaaa-0000fB-RZ for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 11:31:32 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaaZ-00025j-TA; Wed, 13 Jul 2022 11:31:31 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBaaZ-0006I0-Ly; Wed, 13 Jul 2022 11:31:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=/Jh6qAIUVQDtPAHdvhIU5HtsZW+mEApgxdRAdlZtbCw=; b=Mf/0o55p1QDtMQgDnFRlR07zRo HzRl0Kwc19oXC3FvowVMSIbwhVhLwrAjU5U5v1EJumW8pIreC8nxePIOiDVMNs6Xy3oGR4Eb8yPhu 54zqzDq/0Oyn+QdoiaZwJekW5nWUysmWzbwO931J33UTZYajNOB2KQekeSqeAQOH0WQg=; Message-ID: <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> Date: Wed, 13 Jul 2022 12:31:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Jan Beulich Cc: xen-devel , Bertrand Marquis , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> From: Julien Grall In-Reply-To: <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jan, On 13/07/2022 11:56, Jan Beulich wrote: > On 13.07.2022 12:18, Julien Grall wrote: >> On 13/07/2022 10:53, Jan Beulich wrote: >>> On 13.07.2022 11:35, Julien Grall wrote: >>>> On 13/07/2022 07:21, Jan Beulich wrote: >>>>>>> For the FIFO issue, we can introduce the new config option to restrict the maximum number of static >>>>>>> port supported in Xen. We can check the user-defined static port when we parse the device tree and if >>>>>>> a user-defined static port is greater than the maximum allowed static port will return an error to the user. >>>>>>> In this way, we can avoid allocating a lot of memory to fill the hole. >>>>>>> >>>>>>> Let me know your view on this. >>>>>>> >>>>>>> config MAX_STATIC_PORT >>>>>>> int "Maximum number of static ports” >>>>>>> range 1 4095 >>>>>>> help >>>>>>> Controls the build-time maximum number of static port supported >>>>>> >>>>>> The problem is not exclusive to the static event channel. So I don't >>>>>> think this is right to introduce MAX_STATIC_PORT to mitigate the issue >>>>>> (even though this is the only user today). >>>>>> >>>>>> A few of alternative solutions: >>>>>> 1) Handle preemption in alloc_evtchn_bucket() >>>>>> 2) Allocate all the buckets when the domain is created (the max >>>>>> numbers event channel is known). We may need to think about preemption >>>>>> 3) Tweak is_port_valid() to check if the bucket is valid. This would >>>>>> introduce a couple of extra memory access (might be OK as the bucket >>>>>> would be accessed afterwards) and we would need to update some users. >>>>>> >>>>>> At the moment, 3) is appealing me the most. I would be interested to >>>>>> have an opionions from the other maintainers. >>>>> >>>>> Fwiw of the named alternatives I would also prefer 3. Whether things >>>>> really need generalizing at this point I'm not sure, though. >>>> I am worry that we may end up to forget that we had non-generaic way >>>> (e.g. MAX_STATIC_PORT) to prevent trigger the issue. So we could end up >>>> to mistakenly introduce a security issue. >>>> >>>> However, my point was less about generalization but more about >>>> introducing CONFIG_MAX_STATIC_PORT. >>>> >>>> It seems strange to let the admin to decide the maximum number of static >>>> port supported. >>> >>> Why (assuming s/admin/build admin/)? I view both a build time upper bound >>> as well as (alternatively) a command line driven upper bound as reasonable >>> (in the latter case there of course still would want/need to be an upper >>> bound on what is legitimate to specify from the command line). Using >>> static ports after all means there's a static largest port number. >>> Determined across all intended uses of a build such an upper bound can be >>> a feasible mechanism. >> >> AFAICT, the limit is only here to mitigate the risk with the patch I >> proposed. With a proper fix, the limit would be articial and therefore >> it is not clear why the admin should be able to configure it (even >> temporarily). > > The limit would be as artificial as other limits we enforce. You are right. But we need to be cautious in adding new one that overlaps with existing one. > I can't > see why it would be wrong to have a more tight limit on static ports > than on traditional ("dynamic") ones. Even if only to make sure so > many dynamic ones are left. This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 11:48:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 11:48:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366529.597403 (Exim 4.92) (envelope-from ) id 1oBaqv-0003gh-0f; Wed, 13 Jul 2022 11:48:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366529.597403; Wed, 13 Jul 2022 11:48:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaqu-0003ga-UG; Wed, 13 Jul 2022 11:48:24 +0000 Received: by outflank-mailman (input) for mailman id 366529; Wed, 13 Jul 2022 11:48:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaqt-0003gP-Jq; Wed, 13 Jul 2022 11:48:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaqt-0002QZ-HM; Wed, 13 Jul 2022 11:48:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBaqt-0006kJ-33; Wed, 13 Jul 2022 11:48:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBaqt-0002bp-0Y; Wed, 13 Jul 2022 11:48:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+H3A2cOyR6hq2mKUo9US1kxjjIbiHjuiIGsy46/Eq8I=; b=x1sndPTPXSH/vnX3/P2hKa87DP WU2GgSbhgxP6H7Y23716lSgju/biM9OkGOz9qQjdGYXJ9bl3z2ynKVx6PqQvAhhb/9RnQHDUkWzgA zMmBJ6bkC8Ma2xFT2/hbXd/GJOre+nSsPDnc6wj4GnB+/IDfEs/xio52NY2hvf9VNUzE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 171603: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-amd64-xl-rtds:guest-start/debian.repeat:fail:allowable xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f8614c7153f95dcd1a1320156787dbc5325fd946 X-Osstest-Versions-That: xen=87ff11354f0dc0d6e77e1695e6c1e14aa1382cdc From: osstest service owner Date: Wed, 13 Jul 2022 11:48:23 +0000 flight 171603 xen-4.13-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171603/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 22 guest-start/debian.repeat fail REGR. vs. 171204 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171204 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171204 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171204 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171204 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171204 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171204 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171204 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171204 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171204 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171204 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171204 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171204 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen f8614c7153f95dcd1a1320156787dbc5325fd946 baseline version: xen 87ff11354f0dc0d6e77e1695e6c1e14aa1382cdc Last test of basis 171204 2022-06-16 13:08:04 Z 26 days Testing same since 171603 2022-07-12 17:08:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 87ff11354f..f8614c7153 f8614c7153f95dcd1a1320156787dbc5325fd946 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 12:13:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 12:13:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366545.597415 (Exim 4.92) (envelope-from ) id 1oBbEg-0007MO-5C; Wed, 13 Jul 2022 12:12:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366545.597415; Wed, 13 Jul 2022 12:12:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbEg-0007MH-2G; Wed, 13 Jul 2022 12:12:58 +0000 Received: by outflank-mailman (input) for mailman id 366545; Wed, 13 Jul 2022 12:12:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbEf-0007M7-HH for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 12:12:57 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50075.outbound.protection.outlook.com [40.107.5.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 207fb923-02a5-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 14:12:56 +0200 (CEST) Received: from DU2PR04CA0272.eurprd04.prod.outlook.com (2603:10a6:10:28c::7) by HE1PR0801MB1626.eurprd08.prod.outlook.com (2603:10a6:3:86::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Wed, 13 Jul 2022 12:12:52 +0000 Received: from DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28c:cafe::71) by DU2PR04CA0272.outlook.office365.com (2603:10a6:10:28c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Wed, 13 Jul 2022 12:12:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT036.mail.protection.outlook.com (100.127.142.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 12:12:51 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Wed, 13 Jul 2022 12:12:51 +0000 Received: from 65dfcc48455e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 20F9DB0C-148D-4D96-909F-6ECDFEEC4A64.1; Wed, 13 Jul 2022 12:12:41 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 65dfcc48455e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 12:12:41 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM4PR0802MB2273.eurprd08.prod.outlook.com (2603:10a6:200:65::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 12:12:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 12:12:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 207fb923-02a5-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OvfdW1f9i51/01P97p9Erm0as1hHQjY/StrlVRvuT3zJmipeeVpC304mrz2AhFIyT8aCD7ZGmm9rlSOq9lqfvspCfaMEKLwnjwecbr6xaUoPKoVBft1JORRS3OjZWAQJSi4elndCR4vxmbHYSozV3l19fRDOCtz4OnALPU1nWR/telQ6TxKtdzD02TRdQyq6Fktj3Ht+HwbxqbSF/ECTKRq3iXV0Lojy6G3Jw5rB6g/Ja/j4FiBmShtJ+JNf8oMjFg/xdl6WZwG71pofw3h+Zjs71RqKod7EtUPQqk8i+RfA/7Jp2UOLSGrwUqZ982MnP5woGHjUtieklJYrWDH+Tg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6TvVPSJu0qbecAqI/rMsKorhUTN+8QkI820jjKA+hw8=; b=OsSPaaPxPUYjZLcnLdOlnV+yU7fClpddrO1GBfXVQy5+dXVV9fcmEs3rK6qV39MrlyqP2SNWKl3a5sJ2x/kOInigyXP/HOzixTmHiozXlPgGj4ipPhXlZ6HH+M0klmLrV1Gvronu4ekTePJSwStUvzMg8XLEUJzt5AytqQpo49F3+OWjvQypCDoN2qDpBl/KbO/03ohPJy0RCP2CsZpVDnBTPHtPXSSTQK9lAALRGjgHGyl34QhZ26jIQdLGjnlS2Cm3GKzH9Mv1NvMgwo19AoKh6H1Cu86ujxy6DrTDtqi3Gp7vprn3f9F/iBRaU2BWT7Elzd3qxL6SCu6BxYoVDA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6TvVPSJu0qbecAqI/rMsKorhUTN+8QkI820jjKA+hw8=; b=xsVqgQvZB2HF+/9t7AS57mKhC47KtHttREiE5zEuQEXUwGo5TnprSf9CfAB2UIeeNFJvJD3CuEWA2+/jHswTcDCVuBEh5z9HuriZRyJ2Owzx22KZ0QMKCYe5Ap1/n6gstY9g2ay2XyJ4FXrydnagufa+stSvWX+b+MBLlP3bO5E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f09f25337ef9aa66 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wy/1MrSTSJ1VHPeu5EKlXEeQkbb5OInwjTaEU1iAwFfcC1Mz6p4DJtTMbxR/uwoRWmZ1mYvgVWK/4vzxvn7FkDEa8V7e0VOvs69cl2QqJBR262IwncKoy6YSNMzvpAxUcSlE0zWtjnUmwIb/h8LurZdjCN1ObQtm3Pde6VSCZ+Lzq3onsysGXlJpmM0Q28xuGZ9hH50PC68o0W2k/2e8ME933Wm0ixqGe7yJXVdgkBF+e/UDaRCuwjxKVEKrRMf1ubyPvBgmVer/aIeP3sfSl6cw8jWm2o57kQSSosTRBImcyt5FrTvs62ufvaixf3CCSaWAkmk7/EKvrvSPK28QDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6TvVPSJu0qbecAqI/rMsKorhUTN+8QkI820jjKA+hw8=; b=NExBiG/DeL/w+yo+rSAA3DAcCpMCm+x8AEz2xksg2VckXvRbFCZZgQ8YOb+Vj7wVtSrV4iA/n89C1iueBC4Fycpk9utJfVQGoa1R4CdCPrWXoz8rXkZx/XmERhyVjYpQgBTUZUi9Sok33sSkk9DOe15tlXCClAi0WbKn+q8MsouJBARYLo7Fyum8f3yavAyTJgVYwcrAy3acF9lsj9GGUMRLUZpBQouPRSPRVDbEdgEMlYVGpgsNSOeVu1ia7uYCyj93xSkt7qegUBKrv1/CJV9z0BVAzQEU16myFSXM+Qu6RVaweEyJRJ1IYIneir4L7fsHjKkPjv5Lyhv6Rhi36Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6TvVPSJu0qbecAqI/rMsKorhUTN+8QkI820jjKA+hw8=; b=xsVqgQvZB2HF+/9t7AS57mKhC47KtHttREiE5zEuQEXUwGo5TnprSf9CfAB2UIeeNFJvJD3CuEWA2+/jHswTcDCVuBEh5z9HuriZRyJ2Owzx22KZ0QMKCYe5Ap1/n6gstY9g2ay2XyJ4FXrydnagufa+stSvWX+b+MBLlP3bO5E= From: Bertrand Marquis To: Julien Grall CC: Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXakuWoh6IHqUaokStUp728i61bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AA Date: Wed, 13 Jul 2022 12:12:38 +0000 Message-ID: <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> In-Reply-To: <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d46457ed-e9bd-4762-25c7-08da64c90237 x-ms-traffictypediagnostic: AM4PR0802MB2273:EE_|DBAEUR03FT036:EE_|HE1PR0801MB1626:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kxFejmC3iqL4lLjNMLYXHYuxkzzG+dKtL3EwznNN+s9+5y9dMuifVccXgKj7DHs4SSkqIDc+EgpjdJLwVbDy4dEYHZjEL1AUblUuOVb04rRksaLu5v2wFxxYjPDZBlgPgflhngi0Dohj+2UTerzxDNWjQLr500SFzf+rpqDKiU1XLk0N1LR+aR+5kqgCAKPiCw/cUyg2HEVD9YERLxUluqxXT5dZ/YzPQsLqz1MRRyaJcIOeSlh97d0Zoo4xL4rYVIw1hjm28VFjfzdOk6RcqhZo5MOeQ6JBpmVBkRuY6tfzRrN+SJ3yW54A8ot4ddM0+nP+juGwgFHYfZF7NuMi1NL0VcJfq8TYhXETdYDzVxaAK5T4YOeeccfVuFLU3s4/PM/Xo0Y/lTMzsu28IxrLf/4S1PcNWvv1QX8r0SLrQQDN8s12Qne/scYWaq7ASqFx67B2CXm819A7LTPufMXq3XfixIbRBjGFikTuwFj/rzAUf3246eMdrnrMikSB9rAGolkrmOPoEjULXi1hreRk8DHMnh3c29NWPBSIeKdE1UTA0AEoxLozazCTOa+EtKct0WzjolHqgkt//ruxBeadGKtN4HpThXvxMYCLO1Dl2t3iMckZjK7j9Zpfgf86y3aqnxEjGYgV7BhR54RyE9HiQKPDObuqk+NAZMpv0MK5jGdnN9Slt+8RgrhEXfjVnT+Yv4eMR0ypH79712Yk27VAYHMyAYXBHPAtK/isXXrgALdGYCXyHxBnunjGRmcekrCzJFlFhiG9SgqXAmgeavVgSpkTcJzFshDPr1pXVqdo8ZBR1kSNKyx5Pqq9az0i6KdO2k072dti8rzHooUgom852SsYNCkLUOvShXjqi4Qm3c0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(122000001)(38070700005)(71200400001)(86362001)(54906003)(6916009)(66946007)(76116006)(33656002)(316002)(91956017)(4326008)(8676002)(66556008)(38100700002)(26005)(6512007)(66476007)(478600001)(64756008)(6486002)(2616005)(66446008)(53546011)(6506007)(2906002)(5660300002)(41300700001)(186003)(83380400001)(36756003)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9F426BB6683CE84FAB5A9515EB1ABE12@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0802MB2273 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6983b583-6184-4875-3a95-08da64c8fab3 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WSLRPhaxy+faLLOTE37yAObw2Jj3Xu+l6ocEozQW23EXvmbmb5hTgp1mFTPmU8wNwx5KF3mt4gO6HiSxKwna5shhaiZ7CXCX4/Nr/7xAqmoFXVgRgVWvf3l8zgoaihEkpygj/DYB41FextW4bv7RkYUz73Fhsh9s1S6ovpnDnny2t5Qmk/vgHdzC4Y/C/FRfNmP+6GzR2OqlCTG2xkcIvLmRFLJdQlpt+skLiWdFtu8FVZEMX+xg+ZI9g9j1GUBFJAIFkPR88fyKaPjufCKOcro1vjvrYAvCGGd0RPKOKFvLO26aLtS9ON1Gs2JHWsGYny+yvU/O1m4iql8MC8ZO/QG+9FQats7Uc359rh0dgXkgZm88zsATUU1PQI8VewxxlpvNqVw+q2uPNdtJiz0UsvZovjZmn+OlF+BQ/ee9ukGEnVP28Q6GvzzIH3DIliRmytyN3gumCrSq7GITiPoZiv4nz4evKV13eZyAMtjpOoB3aYhOlW8zzqOKqy70LINr14+a200/YTDglfLDXg0kYZxyp5HQHq7AUK6wOrRvX/coEWLn/mMhgQ4vsGKn0k+wFqf4kE7Qe3XRf6F9ZsLqhN2qT/8W0CD4bFbrR0DYzAJHGIpqh9EAL7whD/NfHYJuJ/pzlCliVQ3IO+7SxZ2ixvy61elvZCFlTM2OGUC2TSRfA/cItmn9inSjI75C50Z5N1GDcUpsO+aoiJX2ZWczmAXIe1VWayrIrKQ9t0zyp2k1H4/skegfAxZYrwu+WHYDdNYDZt12GNAt7puc1kl00eyzyKZaUe1UMHVtzvb9g1Jdluen8DUef5YUVgPtlPvg X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(346002)(136003)(46966006)(36840700001)(40470700004)(6862004)(478600001)(2616005)(86362001)(54906003)(26005)(8936002)(53546011)(4326008)(70586007)(6512007)(8676002)(70206006)(356005)(5660300002)(41300700001)(82740400003)(81166007)(316002)(6486002)(33656002)(47076005)(40460700003)(336012)(2906002)(40480700001)(83380400001)(36860700001)(186003)(82310400005)(6506007)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 12:12:51.4562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d46457ed-e9bd-4762-25c7-08da64c90237 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1626 SGksDQoNCj4gT24gMTMgSnVsIDIwMjIsIGF0IDEyOjMxLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4 ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEhpIEphbiwNCj4gDQo+IE9uIDEzLzA3LzIwMjIgMTE6NTYs IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4gT24gMTMuMDcuMjAyMiAxMjoxOCwgSnVsaWVuIEdyYWxs IHdyb3RlOg0KPj4+IE9uIDEzLzA3LzIwMjIgMTA6NTMsIEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+ PiBPbiAxMy4wNy4yMDIyIDExOjM1LCBKdWxpZW4gR3JhbGwgd3JvdGU6DQo+Pj4+PiBPbiAxMy8w Ny8yMDIyIDA3OjIxLCBKYW4gQmV1bGljaCB3cm90ZToNCj4+Pj4+Pj4+IEZvciB0aGUgRklGTyBp c3N1ZSwgd2UgY2FuIGludHJvZHVjZSB0aGUgbmV3IGNvbmZpZyBvcHRpb24gdG8gcmVzdHJpY3Qg dGhlIG1heGltdW0gbnVtYmVyIG9mIHN0YXRpYw0KPj4+Pj4+Pj4gcG9ydCBzdXBwb3J0ZWQgaW4g WGVuLiBXZSBjYW4gY2hlY2sgdGhlIHVzZXItZGVmaW5lZCBzdGF0aWMgcG9ydCB3aGVuIHdlIHBh cnNlIHRoZSBkZXZpY2UgdHJlZSBhbmQgaWYNCj4+Pj4+Pj4+IGEgdXNlci1kZWZpbmVkIHN0YXRp YyBwb3J0IGlzIGdyZWF0ZXIgdGhhbiB0aGUgbWF4aW11bSBhbGxvd2VkIHN0YXRpYyBwb3J0IHdp bGwgcmV0dXJuIGFuIGVycm9yIHRvIHRoZSB1c2VyLg0KPj4+Pj4+Pj4gSW4gdGhpcyB3YXksIHdl IGNhbiBhdm9pZCBhbGxvY2F0aW5nIGEgbG90IG9mIG1lbW9yeSB0byBmaWxsIHRoZSBob2xlLg0K Pj4+Pj4+Pj4gDQo+Pj4+Pj4+PiBMZXQgbWUga25vdyB5b3VyIHZpZXcgb24gdGhpcy4NCj4+Pj4+ Pj4+IA0KPj4+Pj4+Pj4gY29uZmlnIE1BWF9TVEFUSUNfUE9SVA0KPj4+Pj4+Pj4gaW50ICJNYXhp bXVtIG51bWJlciBvZiBzdGF0aWMgcG9ydHPigJ0NCj4+Pj4+Pj4+IHJhbmdlIDEgNDA5NQ0KPj4+ Pj4+Pj4gaGVscA0KPj4+Pj4+Pj4gQ29udHJvbHMgdGhlIGJ1aWxkLXRpbWUgbWF4aW11bSBudW1i ZXIgb2Ygc3RhdGljIHBvcnQgc3VwcG9ydGVkDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBUaGUgcHJvYmxl bSBpcyBub3QgZXhjbHVzaXZlIHRvIHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbC4gU28gSSBkb24n dA0KPj4+Pj4+PiB0aGluayB0aGlzIGlzIHJpZ2h0IHRvIGludHJvZHVjZSBNQVhfU1RBVElDX1BP UlQgdG8gbWl0aWdhdGUgdGhlIGlzc3VlDQo+Pj4+Pj4+IChldmVuIHRob3VnaCB0aGlzIGlzIHRo ZSBvbmx5IHVzZXIgdG9kYXkpLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gQSBmZXcgb2YgYWx0ZXJuYXRp dmUgc29sdXRpb25zOg0KPj4+Pj4+PiAxKSBIYW5kbGUgcHJlZW1wdGlvbiBpbiBhbGxvY19ldnRj aG5fYnVja2V0KCkNCj4+Pj4+Pj4gMikgQWxsb2NhdGUgYWxsIHRoZSBidWNrZXRzIHdoZW4gdGhl IGRvbWFpbiBpcyBjcmVhdGVkICh0aGUgbWF4DQo+Pj4+Pj4+IG51bWJlcnMgZXZlbnQgY2hhbm5l bCBpcyBrbm93bikuIFdlIG1heSBuZWVkIHRvIHRoaW5rIGFib3V0IHByZWVtcHRpb24NCj4+Pj4+ Pj4gMykgVHdlYWsgaXNfcG9ydF92YWxpZCgpIHRvIGNoZWNrIGlmIHRoZSBidWNrZXQgaXMgdmFs aWQuIFRoaXMgd291bGQNCj4+Pj4+Pj4gaW50cm9kdWNlIGEgY291cGxlIG9mIGV4dHJhIG1lbW9y eSBhY2Nlc3MgKG1pZ2h0IGJlIE9LIGFzIHRoZSBidWNrZXQNCj4+Pj4+Pj4gd291bGQgYmUgYWNj ZXNzZWQgYWZ0ZXJ3YXJkcykgYW5kIHdlIHdvdWxkIG5lZWQgdG8gdXBkYXRlIHNvbWUgdXNlcnMu DQo+Pj4+Pj4+IA0KPj4+Pj4+PiBBdCB0aGUgbW9tZW50LCAzKSBpcyBhcHBlYWxpbmcgbWUgdGhl IG1vc3QuIEkgd291bGQgYmUgaW50ZXJlc3RlZCB0bw0KPj4+Pj4+PiBoYXZlIGFuIG9waW9uaW9u cyBmcm9tIHRoZSBvdGhlciBtYWludGFpbmVycy4NCj4+Pj4+PiANCj4+Pj4+PiBGd2l3IG9mIHRo ZSBuYW1lZCBhbHRlcm5hdGl2ZXMgSSB3b3VsZCBhbHNvIHByZWZlciAzLiBXaGV0aGVyIHRoaW5n cw0KPj4+Pj4+IHJlYWxseSBuZWVkIGdlbmVyYWxpemluZyBhdCB0aGlzIHBvaW50IEknbSBub3Qg c3VyZSwgdGhvdWdoLg0KPj4+Pj4gSSBhbSB3b3JyeSB0aGF0IHdlIG1heSBlbmQgdXAgdG8gZm9y Z2V0IHRoYXQgd2UgaGFkIG5vbi1nZW5lcmFpYyB3YXkNCj4+Pj4+IChlLmcuIE1BWF9TVEFUSUNf UE9SVCkgdG8gcHJldmVudCB0cmlnZ2VyIHRoZSBpc3N1ZS4gU28gd2UgY291bGQgZW5kIHVwDQo+ Pj4+PiB0byBtaXN0YWtlbmx5IGludHJvZHVjZSBhIHNlY3VyaXR5IGlzc3VlLg0KPj4+Pj4gDQo+ Pj4+PiBIb3dldmVyLCBteSBwb2ludCB3YXMgbGVzcyBhYm91dCBnZW5lcmFsaXphdGlvbiBidXQg bW9yZSBhYm91dA0KPj4+Pj4gaW50cm9kdWNpbmcgQ09ORklHX01BWF9TVEFUSUNfUE9SVC4NCj4+ Pj4+IA0KPj4+Pj4gSXQgc2VlbXMgc3RyYW5nZSB0byBsZXQgdGhlIGFkbWluIHRvIGRlY2lkZSB0 aGUgbWF4aW11bSBudW1iZXIgb2Ygc3RhdGljDQo+Pj4+PiBwb3J0IHN1cHBvcnRlZC4NCj4+Pj4g DQo+Pj4+IFdoeSAoYXNzdW1pbmcgcy9hZG1pbi9idWlsZCBhZG1pbi8pPyBJIHZpZXcgYm90aCBh IGJ1aWxkIHRpbWUgdXBwZXIgYm91bmQNCj4+Pj4gYXMgd2VsbCBhcyAoYWx0ZXJuYXRpdmVseSkg YSBjb21tYW5kIGxpbmUgZHJpdmVuIHVwcGVyIGJvdW5kIGFzIHJlYXNvbmFibGUNCj4+Pj4gKGlu IHRoZSBsYXR0ZXIgY2FzZSB0aGVyZSBvZiBjb3Vyc2Ugc3RpbGwgd291bGQgd2FudC9uZWVkIHRv IGJlIGFuIHVwcGVyDQo+Pj4+IGJvdW5kIG9uIHdoYXQgaXMgbGVnaXRpbWF0ZSB0byBzcGVjaWZ5 IGZyb20gdGhlIGNvbW1hbmQgbGluZSkuIFVzaW5nDQo+Pj4+IHN0YXRpYyBwb3J0cyBhZnRlciBh bGwgbWVhbnMgdGhlcmUncyBhIHN0YXRpYyBsYXJnZXN0IHBvcnQgbnVtYmVyLg0KPj4+PiBEZXRl cm1pbmVkIGFjcm9zcyBhbGwgaW50ZW5kZWQgdXNlcyBvZiBhIGJ1aWxkIHN1Y2ggYW4gdXBwZXIg Ym91bmQgY2FuIGJlDQo+Pj4+IGEgZmVhc2libGUgbWVjaGFuaXNtLg0KPj4+IA0KPj4+IEFGQUlD VCwgdGhlIGxpbWl0IGlzIG9ubHkgaGVyZSB0byBtaXRpZ2F0ZSB0aGUgcmlzayB3aXRoIHRoZSBw YXRjaCBJDQo+Pj4gcHJvcG9zZWQuIFdpdGggYSBwcm9wZXIgZml4LCB0aGUgbGltaXQgd291bGQg YmUgYXJ0aWNpYWwgYW5kIHRoZXJlZm9yZQ0KPj4+IGl0IGlzIG5vdCBjbGVhciB3aHkgdGhlIGFk bWluIHNob3VsZCBiZSBhYmxlIHRvIGNvbmZpZ3VyZSBpdCAoZXZlbg0KPj4+IHRlbXBvcmFyaWx5 KS4NCj4+IFRoZSBsaW1pdCB3b3VsZCBiZSBhcyBhcnRpZmljaWFsIGFzIG90aGVyIGxpbWl0cyB3 ZSBlbmZvcmNlLiANCj4gDQo+IFlvdSBhcmUgcmlnaHQuIEJ1dCB3ZSBuZWVkIHRvIGJlIGNhdXRp b3VzIGluIGFkZGluZyBuZXcgb25lIHRoYXQgb3ZlcmxhcHMgd2l0aCBleGlzdGluZyBvbmUuDQo+ IA0KPj4gSSBjYW4ndA0KPj4gc2VlIHdoeSBpdCB3b3VsZCBiZSB3cm9uZyB0byBoYXZlIGEgbW9y ZSB0aWdodCBsaW1pdCBvbiBzdGF0aWMgcG9ydHMNCj4+IHRoYW4gb24gdHJhZGl0aW9uYWwgKCJk eW5hbWljIikgb25lcy4gRXZlbiBpZiBvbmx5IHRvIG1ha2Ugc3VyZSBzbw0KPj4gbWFueSBkeW5h bWljIG9uZXMgYXJlIGxlZnQuDQo+IA0KPiBUaGlzIGlzIHNpbWlsYXIgdG8gWGVuIGZvcmJpZGRp bmcgdG8gY2xvc2UgYSBzdGF0aWMgcG9ydDogaXQgaXMgbm90IHRoZSBoeXBlcnZpc29yIGJ1c2lu ZXNzIHRvIGNoZWNrIHRoYXQgdGhlcmUgYXJlIGVub3VnaCBldmVudCBjaGFubmVsIHBvcnRzIGZy ZWVkIGZvciBkeW5hbWljIGFsbG9jYXRpb24uDQoNCk9uIG90aGVyIHNpZGUgd2UgbmVlZCB0byBi ZSBjYXV0aW91cyBub3QgdG8gYWRkIHRvbyBtdWNoIGNvbXBsZXhpdHkgaW4gdGhlIGNvZGUgYnkg dHJ5aW5nIHRvIG1ha2UgdGhpbmdzIGFsd2F5cyBtYWdpY2FsbHkgd29yay4NCklmIHlvdSB3YW50 IFhlbiB0byBiZSBhY2Nlc3NpYmxlIHRvIG5vbiBleHBlcnQgYnkgbWFnaWNhbGx5IHdvcmtpbmcg YWxsIHRoZSB0aW1lLCB0aGVyZSB3b3VsZCBiZSBhIGxvdCBvZiB3b3JrIHRvIGRvLg0KDQpDaGVl cnMNCkJlcnRyYW5kDQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwN Cg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 13 12:20:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 12:20:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366551.597425 (Exim 4.92) (envelope-from ) id 1oBbLT-0008SE-Uo; Wed, 13 Jul 2022 12:19:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366551.597425; Wed, 13 Jul 2022 12:19:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbLT-0008S7-SB; Wed, 13 Jul 2022 12:19:59 +0000 Received: by outflank-mailman (input) for mailman id 366551; Wed, 13 Jul 2022 12:19:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbLS-0008Rx-FY; Wed, 13 Jul 2022 12:19:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbLS-0002yk-BE; Wed, 13 Jul 2022 12:19:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbLR-0000XW-Ql; Wed, 13 Jul 2022 12:19:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBbLR-0008K3-Q6; Wed, 13 Jul 2022 12:19:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yCA5rl3krfsUg37CxFkqr/smrzIdyJFtqdz7QyWgO/s=; b=gEtmEjiECFTqnhmQnglKvc76lD VxJT4RwfnGLWZDKOoNY6B+k2jRh9yOgYQZW+BOKQ9jGa+XaN510Jco0lOA84VJsK8W9uNDRfhkBNh 2q0HvqsyO2uO6bJE29aiz+7YqPCrHDPwx5CWtdD+lBsnfmwHxdcb+JC4ygSE3fOev9S8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 171604: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-amd64-i386-xl:xen-install:fail:heisenbug xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=87d90d511c87477609cc4b8c88866bfbe997da46 X-Osstest-Versions-That: xen=c5f774eaeeca195ef85b47713f0b21220c4b41e6 From: osstest service owner Date: Wed, 13 Jul 2022 12:19:57 +0000 flight 171604 xen-4.14-testing real [real] flight 171617 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171604/ http://logs.test-lab.xenproject.org/osstest/logs/171617/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl 7 xen-install fail pass in 171617-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171206 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171206 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171206 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171206 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171206 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171206 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171206 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171206 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171206 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171206 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171206 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171206 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 87d90d511c87477609cc4b8c88866bfbe997da46 baseline version: xen c5f774eaeeca195ef85b47713f0b21220c4b41e6 Last test of basis 171206 2022-06-16 13:08:03 Z 26 days Testing same since 171604 2022-07-12 17:08:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl fail test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c5f774eaee..87d90d511c 87d90d511c87477609cc4b8c88866bfbe997da46 -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 12:29:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 12:29:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366574.597489 (Exim 4.92) (envelope-from ) id 1oBbUi-0002Hy-KE; Wed, 13 Jul 2022 12:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366574.597489; Wed, 13 Jul 2022 12:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbUi-0002Hr-HP; Wed, 13 Jul 2022 12:29:32 +0000 Received: by outflank-mailman (input) for mailman id 366574; Wed, 13 Jul 2022 12:29:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbUh-0002Hl-LE for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 12:29:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbUg-0003AF-Pv; Wed, 13 Jul 2022 12:29:30 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBbUg-0000oj-K3; Wed, 13 Jul 2022 12:29:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=YQWbpS5tu8eob4m1aMRegt7MkvEPU2ktawzD6XDmZuM=; b=xnwq13Z+xDbJWwrxCRAtrZurgp opyE3YkTzG/e3bZKeRwhvc8l67DKB/JmFe0rIbFiCyv21w+3IGH4rckduB7E86tNDXqFoaR5Ezka2 z/o0XtGJN8SqM7Tcg0do9SWWy5zLTvjhOqW5YBe9hFmX1XCmSpQsgCnEVZeYnKkFhmik=; Message-ID: Date: Wed, 13 Jul 2022 13:29:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Bertrand Marquis Cc: Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Rahul Singh References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> From: Julien Grall Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port In-Reply-To: <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/07/2022 13:12, Bertrand Marquis wrote: >> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>> I can't >>> see why it would be wrong to have a more tight limit on static ports >>> than on traditional ("dynamic") ones. Even if only to make sure so >>> many dynamic ones are left. >> >> This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. > > On other side we need to be cautious not to add too much complexity in the code by trying to make things always magically work. > If you want Xen to be accessible to non expert by magically working all the time, there would be a lot of work to do. It is not clear to me whether you are referring to a developper or admin here. On the admin side, we need to make sure they have an easy way to configure event channels. One knob is always going to easier than two knobs. On the developper side, this could be resolved by better documentation in the code/interface. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:00:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366581.597500 (Exim 4.92) (envelope-from ) id 1oBbyf-0006jX-3j; Wed, 13 Jul 2022 13:00:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366581.597500; Wed, 13 Jul 2022 13:00:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbye-0006jQ-VY; Wed, 13 Jul 2022 13:00:28 +0000 Received: by outflank-mailman (input) for mailman id 366581; Wed, 13 Jul 2022 13:00:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBbyd-0006jJ-72 for xen-devel@lists.xen.org; Wed, 13 Jul 2022 13:00:27 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130082.outbound.protection.outlook.com [40.107.13.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c2fe97c5-02ab-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 15:00:25 +0200 (CEST) Received: from DB6PR0201CA0039.eurprd02.prod.outlook.com (2603:10a6:4:3f::49) by HE1PR0801MB1756.eurprd08.prod.outlook.com (2603:10a6:3:7e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Wed, 13 Jul 2022 13:00:23 +0000 Received: from DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::7a) by DB6PR0201CA0039.outlook.office365.com (2603:10a6:4:3f::49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26 via Frontend Transport; Wed, 13 Jul 2022 13:00:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT019.mail.protection.outlook.com (100.127.142.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 13:00:22 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Wed, 13 Jul 2022 13:00:22 +0000 Received: from cd6b0393f183.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7BEEA80C-C37C-4A1D-B12E-1DDA9B7B5001.1; Wed, 13 Jul 2022 13:00:16 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cd6b0393f183.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 13:00:16 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB7275.eurprd08.prod.outlook.com (2603:10a6:20b:436::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 13:00:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 13:00:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2fe97c5-02ab-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=OB8/Acq8vsuh5VfuN0GwC9UkCUFWV8f1hDrAQ6NrNFpG9/gQrAbdDeIpLRnncskC467yICEhe0V5EKrzc4EFgeGMnx+gUfZAzTiJzIK+kFUum9op1gvdGZOnwIg39iilIwb5DHj7KsjjlRXD5X1JLMRMKf66H9T4QI43H8Itm+N1CnR59FR652BMf3Zc4oaLkCu11kGoLjckFgEphtyTUBAd+VdlmWpK2NClaTFjlm0wgTvOdJTUVFhkAIGgcgooZbECubzfPE0F/mtOBMVBjtlNZvJtMgNi6+tvBhvkNEA9m3niCZfPYUhRDdWkez7mvWqtlKdnznxG7WAvNGqjWQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SDYo4wOvY6Lrho9y2FyyQCuhgx04M/UiivuhrzPZcVk=; b=QWPNNoxHJ8euIi8BLFJS8lE+ftmNGvCaFDkXgqOxPaFdIAfhK636eLIeZLkcrwOH/NSEUhDLnx9p1h3JuTBRbWAO1kHmlb2pMnWp7fBgyPUJ6ovrLY8xCE76IQybr4FHj3UwR+n4EvE4uck5H+RjqDeUxtCLKW8I7/UZXYY8/HQommutD2YECCPPjF+/ow4Lr9QgAwAJgnWloSIMsGDaYyNZsiV3ptemGxFCRAHYAmNKASjk12ElAWZpkcY2Av0m0GSF0piCaMKI01rUsUW+5OhtweYjSjer1vaKkhUB4ajOztFq9i3uN5tOPu/8t2XWahNhQ1UHz3VeYVUYN7Ktyg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDYo4wOvY6Lrho9y2FyyQCuhgx04M/UiivuhrzPZcVk=; b=vCN3O/QuVRN0klOBMY0XhNC565Ioqu/oRnqOtr7nlQBsG12SROvoYqEK1w07e7CjJd+Qhpo7LAnbXs3sjtDPE1/QQkXr1X+07ioo22f2hip/PH0z3NdHvRJCZbF5I3GOk03ZB2jjgwbqkE71oRJk71Mp5X4uM4P9KGHM/nLmVWs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f23934f19affa843 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cXbildlevOMwwp70cankMXDctG7lV6ClByBTbRLf9H5JNvvM0bDAEdIamERQXUoIgbydzUlCE47Ebso0jodQ0o7i4J4Sqj2Wq70D1zfhVouOlXbJAmlquocENuG/pJ497lyANydt9fbqkyzZ/lmpwOAZFlVfTy0l6jKo4weBDJj/DEFgA6quXVdc/nB6uSuYKIcAb8TrnnJm+fBu1XwQhxCyF06vXKmycdkdbVNWFNxtGQjKQ8m47coP+3Z2iF1W80OXQ9vEwEY1QSAbD7Q1+UA9yZMrEkAhflDC/xgEwOhKPrptlFQp5URMz/6OPPkztXU7iKhXj2kjF55PPtEbkw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SDYo4wOvY6Lrho9y2FyyQCuhgx04M/UiivuhrzPZcVk=; b=UMvtPS7Hs9LbRzKeetAxQW8SlTc9tm6td090xLI+czQNdBd/TixkV6dMJP53suM81A2Htt4o6NFOtaUd/zF7Cc0r0NUkd5DAqW4NM/tV0IIYYeTOAIzmm2DOIvHDPz5sa1q8c9Fk241IuXz7rXZNyQlF+CP9SLeLUgsxB/pJlanjDO6vbUkNrOU6w9TnWzwc3CLG1yBET61VDmVgM2LnjLl0UnnNuAuzPYiADpIDgg5vDSsVy6hz2CQRKiCL41glOkhwnRe70+aJ4kIpKntIkGdnh1bJ/DdQNwrgSTHzd5RgBry3Oqqz9HMmNnNnA/6/kkM0liJJx8HxAyDqUjJgCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SDYo4wOvY6Lrho9y2FyyQCuhgx04M/UiivuhrzPZcVk=; b=vCN3O/QuVRN0klOBMY0XhNC565Ioqu/oRnqOtr7nlQBsG12SROvoYqEK1w07e7CjJd+Qhpo7LAnbXs3sjtDPE1/QQkXr1X+07ioo22f2hip/PH0z3NdHvRJCZbF5I3GOk03ZB2jjgwbqkE71oRJk71Mp5X4uM4P9KGHM/nLmVWs= From: Bertrand Marquis To: Brad Churchwell CC: "xen-devel@lists.xen.org" Subject: Re: Xen on rk3399 Thread-Topic: Xen on rk3399 Thread-Index: AQHYlaRzw0VI/DSwq0Ot3R+564rcea161i+AgAAPUoCAAANZAIAAA34AgAFZWwA= Date: Wed, 13 Jul 2022 13:00:14 +0000 Message-ID: <81265FD0-2D00-48D7-ACBA-0F7A4FF3DCAA@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 11ccdcab-46dd-449d-6d90-08da64cfa592 x-ms-traffictypediagnostic: AM9PR08MB7275:EE_|DBAEUR03FT019:EE_|HE1PR0801MB1756:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: fLxH4rpQffoGFQOwJlTig6vXJ62KGRSqSOqHSn7VnM60ISXoabDJKE/zj1hFzEToU/c1sIWWeOEAPXdtP+lpIpAp5+yiPoQsiy66/F1NHuBsMgignjAY5RfQNm6p4eQ7Dj0+l+zGSdEZdajwNHbp8dNKvjBz3Djd70ClUoFMNCqJtKzJRnZXM7oMGLpbHl78826+ykje0YoyVG7bOp37MUAd5U4PQJFPsAt2yuVd3vomi6iPKXd1kjVyzkuECwKrjKh4pDKFbO1vP/6r7DF1Fz9ToY1snjwYPU9/XO0gaA9eBBeX0960OL8fYVTpnI6bRCEcFqfAYmasltGDF0IM5vzATwG0bT9ODA1piQK0YBx7AtFh/DSb1gaT9TzSw9cBoJL5mAdyaPpseLfhTKL0KWfbuabost+eodhZpXHJshPyxE3Dzf/+LAfH14k2mYbugw/7PiNx/bW47yJUJWkvcj6PC1BoUVn7tQ8N/gw+UjFRs6qbjMWmXqcriyYCgAPY5s8FKKNNaZjZqq2GXOvw/zqmwKs++hq3pOJTaWpDVRnbVNfWUptLsgqPFYTIECUs4dN47GSmBXkSh2QylUAe/Bp44fG0URmVRjOCXXBer9Tla96hUi3KJhmpQjkJy2qusyXYKAmoOHb0LYukkzmlLTOb1n9r4qarMPL12hgu9ecEi5QPQYG6k9LzWeFbj5iIFr7YbBUB9rg+bkcMOQM9lzJ5slpp2B9SuWFMziZ76ctHTuObcg7MajMMExQxYdNlsbi8DJr2Il2BQ9d71i1Qpfo+PIoMxR1xlfVhOMVXKtgPI4h91xvsEN8awif1r13uhTp/ZdudK/ptLQC9CbfKvTZwkeQx3oVnUb2TDVnwif8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(376002)(136003)(396003)(39860400002)(6916009)(186003)(64756008)(2906002)(83380400001)(66946007)(6486002)(66476007)(76116006)(8676002)(4326008)(66556008)(66446008)(316002)(33656002)(86362001)(36756003)(7116003)(2616005)(53546011)(38070700005)(5660300002)(8936002)(478600001)(26005)(6506007)(122000001)(6512007)(41300700001)(91956017)(38100700002)(71200400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1B05A348159B4D44863D8185ECA0D89B@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7275 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 54c9c883-f476-4bde-19ac-08da64cfa0c7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dKBbAeYLPE/SkGPOUysbk+rgt+unS9ecy0CFAZhy6ZLtpUKg0JQBFQHO6K+8vCGWvFoA5U/AaSth/ir9gPJkf7PFWHzMS0BXJNptFBI4dFy3NeaqGrhlbC5JYOimf6xOZ3pbmCZjRMF8AT0lVRxDPsYG9A3S7SZ2CEvcFITIljTh17IyDA9jBzksRcJLldJtiQ7cgFq1RBnKnvcYLdHdQ8b1T3l3WQGgZffbBOTmwVwjGSuWw4SEYPJJ/xmCQDDO9VO/CjVH1W78xw5N6i4B0V+fY7MhbBaXIczSuuxAR98vjSDdwPX0kyXqtbTPs8HDxz/ND0ZMzrx9s+JTLnyoyAlZ8+5Ys41iL6R2OMi9R3N2R1zb/iAyNBes0CwusAKZ2yeEoFwyedHNFAAbdpXtfbIQYOuLZyFRmyL6mFtEySCIfb4BODS0a1WEeUs4bGvjY3ZVltCsXPjP55j/CMtMjXbzD1AGb+Ty8xw2jmtNfRV6ilvyl0eYnwpKRWhtx5x3wWtgcmNC234pH3EvQVnRj4W31EJiGZlx/pSDBNoFvWw1NKYWIe72wmeEHh/CUZ1gxQbv7MQvC/xnr2Th5TvAC+bEYWwEEdfpihWz93TnEgu0AIv7ruNv9Z7/MYPmlFWSCnygXs80o1fc28KuI9fe+6eKXZinw1jj4EGleTTgm8NAbUMoS5PgIGvaqcldKLHEX/+VwMBv6sGIUX5+HZdPRpaDR2Q87YeR08vvg2pxtlIym09bP27oi84Sg7UFrUuPA94Hd0cs5AuxfoyyRZp251lGbcMyg/OytYUaS4ia4QMrDAwVoXH8fIhDViiYUmWQ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(46966006)(36840700001)(40470700004)(5660300002)(40460700003)(53546011)(2906002)(6486002)(6506007)(33656002)(316002)(478600001)(81166007)(26005)(36756003)(41300700001)(82310400005)(6512007)(70206006)(336012)(36860700001)(4326008)(47076005)(8676002)(40480700001)(83380400001)(70586007)(6862004)(86362001)(8936002)(82740400003)(7116003)(356005)(186003)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 13:00:22.5191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11ccdcab-46dd-449d-6d90-08da64cfa592 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1756 Hi Brad > On 12 Jul 2022, at 17:24, Brad Churchwell wrote: > > Hi Bertrand, > > I believe I understand, but just to clarify, should I leave the ppi-parti= tions block in rk3399.dtsi as is and disable the little cores, or should I = also modify that block? Disable the little cores and remove the partitions. Cheers Bertrand > > Brad > > On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis wrote: > Hi Brad, > > > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: > > > > Hi Bertrand, > > > > Thanks so much for the quick response! > > > > I should have mentioned previously that this device tree and kernel Ima= ge (5.15.16) does boot properly with the rootfs without XEN. The interrupt = errors are only present when booting with XEN. > > > > These are custom boards and they do have usb c, however we are unable t= o boot from usb as it doesn't receive power. We currently only use the usb= to flash u-boot to spi which requires us to use a separate power adapter. = These boards get power and networking through a custom backplane and interf= ace with the backplane via a sata style justice (I'm not sure what the prop= er terminology would be here). > > > > Since I cannot boot to rootfs with XEN, I'm unable to show the device t= ree there. The only bit that I added to accommodate XEN is this bit here: > > > > chosen { > > stdout-path =3D "serial2:1500000n8"; > > bootargs =3D "hmp-unsafe=3Dtrue"; > > xen,dom0-bootargs =3D "console=3Dhvc0 earlyprintk=3Dxen clk_ignore_= unused root=3D/dev/nvme0n1p2 rw init=3D/sbin/init rootwait rootfstype=3Dext= 4 ignore_loglevel"; > > modules { > > #address-cells =3D <2>; > > #size-cells =3D <2>; > > > > module@1 { > > compatible =3D "xen,linux-zimage", "xen,multiboot-module"; > > reg =3D <0x0 0x03F80000 0x0 0x01aa8008>; > > }; > > module@2 { > > compatible =3D "xen,linux-initrd", "xen,multiboot-module"; > > reg =3D <0x0 0x06000000 0x0 0x02000000>; > > }; > > }; > > > > }; > > > > The gic declaration is in the vanilla rk3399.dtsi file and hasn't been = modified: > > > > gic: interrupt-controller@fee00000 { > > compatible =3D "arm,gic-v3"; > > #interrupt-cells =3D <4>; > > #address-cells =3D <2>; > > #size-cells =3D <2>; > > ranges; > > interrupt-controller; > > > > reg =3D <0x0 0xfee00000 0 0x10000>, /* GICD */ > > <0x0 0xfef00000 0 0xc0000>, /* GICR */ > > <0x0 0xfff00000 0 0x10000>, /* GICC */ > > <0x0 0xfff10000 0 0x10000>, /* GICH */ > > <0x0 0xfff20000 0 0x10000>; /* GICV */ > > interrupts =3D ; > > its: interrupt-controller@fee20000 { > > compatible =3D "arm,gic-v3-its"; > > msi-controller; > > #msi-cells =3D <1>; > > reg =3D <0x0 0xfee20000 0x0 0x20000>; > > }; > > > > ppi-partitions { > > ppi_cluster0: interrupt-partition-0 { > > affinity =3D <&cpu_l0 &cpu_l1 &cpu_l2 &= cpu_l3>; > > }; > > > > ppi_cluster1: interrupt-partition-1 { > > affinity =3D <&cpu_b0 &cpu_b1>; > > }; > > }; > > Xen is not supporting PPI partitions. > I also saw that your booting using SMP unsafe so all core are enabled by = Xen. > > Right now big/little is not supported by Xen and here you might have some= interrupts in your system which can only occur on some specific cores. > I would suggest to try the following: > - only boot enable in your dtb the cores with the same type than the boot= core > - check in your device tree which devices are assign to the ppi_cluster n= ot available and disable them > > This kind of configuration will be tricky to handle so it will depend on = which devices have interrupts that can only be fired on one cluster type. > > Sorry but I cannot right now check in the device tree and do those checks= myself but if you do get the idea send back a mail :-) > > Cheers > Bertrand > > > }; > > > > I've attached the device tree and include files just in case you'd like= to take a look at those. > > > > Thanks so much for your help! I've been at this for weeks with very lit= tle progress. > > > > Cheers, > > Brad > > > > > > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis wrote: > > Hi Brad, > > > > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > > > > > Hello, > > > > > > I've been trying to get Xen to boot dom0 with my kernel for weeks on = an rk3399 based board and thought I'd reach out for help. It looks like eit= her Xen is not properly recreating the device tree or the interrupt control= ler is just failing. The hypervisor boots but falls to initramfs because it= cannot find the root device (nvme on pcie). Any help would be greatly appr= eciated. Here is the complete boot log > > > > From the logs you have an issue with the interrupt controller and the f= act that your NVME is behind PCIE and as such depends on ITS is probably no= t helping. > > > > I would suggest to try to boot on usb as root fs for a try. > > > > Also it could be useful to compare the device tree on xen and without x= en to understand what is going on (using /proc/device-tree). > > > > Xen seems to be ok but Linux is not happy with interrupts and is showin= g several issues around this area on your logs. > > Could you show us an extract of your device tree around the gic declara= tion ? > > > > Cheers > > Bertrand > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are co= nfidential and may also be privileged. If you are not the intended recipien= t, please notify the sender immediately and do not disclose the contents to= any other person, use it for any purpose, or store or copy the information= in any medium. Thank you. > > > > IMPORTANT NOTICE: The contents of this email and any attachments are conf= idential and may also be privileged. If you are not the intended recipient,= please notify the sender immediately and do not disclose the contents to a= ny other person, use it for any purpose, or store or copy the information i= n any medium. Thank you. IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:32:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366589.597511 (Exim 4.92) (envelope-from ) id 1oBcTT-00021b-Je; Wed, 13 Jul 2022 13:32:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366589.597511; Wed, 13 Jul 2022 13:32:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcTT-00021U-FO; Wed, 13 Jul 2022 13:32:19 +0000 Received: by outflank-mailman (input) for mailman id 366589; Wed, 13 Jul 2022 13:32:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcTR-00021O-Ad for xen-devel@lists.xen.org; Wed, 13 Jul 2022 13:32:17 +0000 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [2a00:1450:4864:20::529]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3530b702-02b0-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 15:32:15 +0200 (CEST) Received: by mail-ed1-x529.google.com with SMTP id e15so14122886edj.2 for ; Wed, 13 Jul 2022 06:32:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3530b702-02b0-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ig3WjwMZfKUi3vc5J65h6U8WT2JkP23SC5xNpqH5mXA=; b=pK2Zd7hNn8yr+kPQGNmEep1zpuqzN61Tdli7XpjlpLe/0Jpkpka/JjN37uncBfRwrT +4vKTY2o0xSt2i71QKlwhxuw9uKCwy5AXhho4O0wKjyX7gPxaHJHiVQFlAO4S7WNnbtH mIcdg7Gv7YhJODWVtyyM34B7ztIdgSJudG9/kHRT4NfgiF1M28ZdijukD5I+tduxi8AM n+sB6krmaxwGxu0TSGWB3kFqruP42wWlc5/zszIcDET5JbHzLhhi5GrRjWCgWznDWhGV yo/uYyECSPjzvJ9yjdWH7lDt2n2fKTSpy9yTswoGGqfvipgj8FcqxmukjXQSGMJ6AZs0 3T2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ig3WjwMZfKUi3vc5J65h6U8WT2JkP23SC5xNpqH5mXA=; b=LfS4Dbgrrir2wr9IO7+SCscF9gKFeP04EDSHIVC9o8FlPaOZXjhE1VCE13KtJXKYob ElyM+m7OsXCFi7N3Wh/FAkEFp9lg8JpIaMKKmGG54CtdqgP+pULPtDgK2GXFxA4KaJGk vui8Z5PZTmPpfJMc89dHm1Lj05n++LcXEVJRSr4bJ3Mh1EeJyb4j+HrjA7QEzmPHpqPH ZSWte3nqqz1Cj0WXM3QwNUgOQHJ4ysV2Bg9k/C3feNd8IClQCU3dkO73nulgXMDdG33a By/x30xQgmyzG1l5j1dop+zRyUmnTD3GswMonCX7tuF566JscZSDObgtRSaKvoZmZsIt jYTg== X-Gm-Message-State: AJIora/VQDtelXt0JgVcktmjwh98WQEiJ10WN42lrMiLc5qh37hTbQDH 7QJaSFlNRe8APs1QEgeKQj++iKjL0LdC/kM+YGhhdSYVVvAn3Q== X-Google-Smtp-Source: AGRyM1vuBWeEfmMXQT/5C1ME06+p3Y6hqjHJnpI2/kHL4gQloy0fSCCbMlr1rr42jCeI2ch5JFOZdMoTweTQ9d0gig0= X-Received: by 2002:a05:6402:3290:b0:43a:86c4:af70 with SMTP id f16-20020a056402329000b0043a86c4af70mr4778668eda.313.1657719134248; Wed, 13 Jul 2022 06:32:14 -0700 (PDT) MIME-Version: 1.0 References: <81265FD0-2D00-48D7-ACBA-0F7A4FF3DCAA@arm.com> In-Reply-To: <81265FD0-2D00-48D7-ACBA-0F7A4FF3DCAA@arm.com> From: Brad Churchwell Date: Wed, 13 Jul 2022 08:32:02 -0500 Message-ID: Subject: Re: Xen on rk3399 To: Bertrand Marquis Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="00000000000022749805e3afd07e" --00000000000022749805e3afd07e Content-Type: text/plain; charset="UTF-8" Hi Bertrand, I did this yesterday and it does indeed silence the warnings saying to disable those cores, however the IRQ errors still remain. I think I made some progress by changing "interrupts = ;" to "interrupts = ;". I noticed when trying to use XEN-4.10 that it said "IRQ only through SPI" and failed to boot XEN where 4.17 unstable boots without this error. Now that I changed GIC_PPI to GIC_SPI, I get the following output: zaku => run boot_pci_enum; run nvme_init; fatload nvme 0:1 0x02000000 xen4.10-uImage; fatload nvme 0:1 0x01f00000 rk3399-zaku.dtb; fatload nvme 0:1 0x03F80000 Image;fatload nvme 0:1 0 885136 bytes read in 5 ms (168.8 MiB/s) 56185 bytes read in 3 ms (17.9 MiB/s) 27885576 bytes read in 65 ms (409.1 MiB/s) 8674182 bytes read in 22 ms (376 MiB/s) ## Booting kernel from Legacy Image at 02000000 ... Image Name: Image Type: AArch64 Linux Kernel Image (uncompressed) Data Size: 885072 Bytes = 864.3 KiB Load Address: 02000000 Entry Point: 02000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 01f00000 Booting using the fdt blob at 0x1f00000 Loading Kernel Image Loading Device Tree to 00000000f1efd000, end 00000000f1f0db78 ... OK Starting kernel ... - UART enabled - - CPU 00000000 booting - - Current EL 00000008 - - Xen starting at EL2 - - Zero BSS - - Setting up control registers - - Turning on paging - - Ready - (XEN) Checking for initrd in /chosen (XEN) RAM: 0000000000200000 - 00000000f7ffffff (XEN) (XEN) MODULE[0]: 00000000f1efd000 - 00000000f1f0b000 Device Tree (XEN) MODULE[1]: 0000000003f80000 - 0000000005a28008 Kernel (XEN) MODULE[2]: 0000000006000000 - 0000000008000000 Ramdisk (XEN) (XEN) Command line: (XEN) Placing Xen at 0x00000000f7e00000-0x00000000f8000000 (XEN) Update BOOTMOD_XEN from 0000000002000000-0000000002120d81 => 00000000f7e00000-00000000f7f20d81 (XEN) Domain heap initialised (XEN) Booting using Device Tree (XEN) Platform: Generic System (XEN) Taking dtuart configuration from /chosen/stdout-path (XEN) Looking for dtuart at "serial2", options "1500000n8" Xen 4.10.1 (XEN) Xen version 4.10.1 (root@) (aarch64-linux-gnu-gcc (Linaro GCC 7.3-2018.05) 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef90065c0eeb7f91977701]) debug=y Tue J2 (XEN) Latest ChangeSet: (XEN) Processor: 410fd034: "ARM Limited", variant: 0x0, part 0xd03, rev 0x4 (XEN) 64-bit Execution: (XEN) Processor Features: 0000000001002222 0000000000000000 (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32 (XEN) Extensions: FloatingPoint AdvancedSIMD GICv3-SysReg (XEN) Debug Features: 0000000010305106 0000000000000000 (XEN) Auxiliary Features: 0000000000000000 0000000000000000 (XEN) Memory Model Features: 0000000000001122 0000000000000000 (XEN) ISA Features: 0000000000011120 0000000000000000 (XEN) 32-bit Execution: (XEN) Processor Features: 00000131:10011011 (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle (XEN) Extensions: GenericTimer Security (XEN) Debug Features: 03010066 (XEN) Auxiliary Features: 00000000 (XEN) Memory Model Features: 10201105 40000000 01260000 02102211 (XEN) ISA Features: 02101110 13112111 21232042 01112131 00011142 00011121 (XEN) Using SMC Calling Convention v1.0 (XEN) Using PSCI v1.0 (XEN) SMP: Allowing 4 CPUs (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 24000 KHz (XEN) GICv3 initialization: (XEN) gic_dist_addr=0x000000fee00000 (XEN) gic_maintenance_irq=41 (XEN) gic_rdist_stride=0 (XEN) gic_rdist_regions=1 (XEN) redistributor regions: (XEN) - region 0: 0x000000fef00000 - 0x000000fefc0000 (XEN) GICv3 compatible with GICv2 cbase 0x000000fff00000 vbase 0x000000fff20000 (XEN) GICv3: 288 lines, (IID 0001143b). (XEN) GICv3: CPU0: Found redistributor in region 0 @000000004001c000 (XEN) Using scheduler: SMP Credit Scheduler (credit) (XEN) Allocated console ring of 32 KiB. (XEN) Bringing up CPU1 - CPU 00000001 booting - - Current EL 00000008 - - Xen starting at EL2 - - Setting up control registers - - Turning on paging - - Ready - (XEN) GICv3: CPU1: Found redistributor in region 0 @000000004003c000 (XEN) CPU 1 booted. (XEN) Bringing up CPU2 - CPU 00000002 booting - - Current EL 00000008 - - Xen starting at EL2 - - Setting up control registers - - Turning on paging - - Ready - (XEN) GICv3: CPU2: Found redistributor in region 0 @000000004005c000 (XEN) CPU 2 booted. (XEN) Bringing up CPU3 - CPU 00000003 booting - - Current EL 00000008 - - Xen starting at EL2 - - Setting up control registers - - Turning on paging - - Ready - (XEN) GICv3: CPU3: Found redistributor in region 0 @000000004007c000 (XEN) CPU 3 booted. (XEN) Brought up 4 CPUs (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID (XEN) P2M: 3 levels with order-1 root, VTCR 0x80023558 (XEN) I/O virtualisation disabled (XEN) build-id: b7279757e82e3e9ea4c4115dabdbfe25d56d762b (XEN) alternatives: Patching with alt table 000000004018fe70 -> 0000000040190350 (XEN) grant_table.c:1731:IDLEv0 Expanding d0 grant table from 0 to 1 frames (XEN) *** LOADING DOMAIN 0 *** (XEN) Loading kernel from boot module @ 0000000003f80000 (XEN) Loading ramdisk from boot module @ 0000000006000000 (XEN) Allocating 1:1 mappings totalling 512MB for dom0: (XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB) (XEN) Grant table range: 0x000000f7e00000-0x000000f7e40000 (XEN) IRQ 41 is already used by Xen (XEN) Unable to map IRQ41 to dom0 (XEN) Device tree generation failed (-16). (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) Could not set up DOM0 guest OS (XEN) **************************************** (XEN) (XEN) Reboot in five seconds... It looks like XEN is now using the interrupt controller but there are conflicts. I was able to get this error to change to "Unable to map IRQ43 to dom0" by changing all instances of "IRQ_TYPE_LEVEL_HIGH " to "IRQ_TYPE_LEVEL_LOW", but I can't get any further. I made sure that there was nothing in the device tree that is obviously using IRQ 43 as well. Any thoughts on this? Cheers, Brad On Wed, Jul 13, 2022, 8:00 AM Bertrand Marquis wrote: > Hi Brad > > > On 12 Jul 2022, at 17:24, Brad Churchwell wrote: > > > > Hi Bertrand, > > > > I believe I understand, but just to clarify, should I leave the > ppi-partitions block in rk3399.dtsi as is and disable the little cores, or > should I also modify that block? > > Disable the little cores and remove the partitions. > > Cheers > Bertrand > > > > > Brad > > > > On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis < > Bertrand.Marquis@arm.com> wrote: > > Hi Brad, > > > > > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: > > > > > > Hi Bertrand, > > > > > > Thanks so much for the quick response! > > > > > > I should have mentioned previously that this device tree and kernel > Image (5.15.16) does boot properly with the rootfs without XEN. The > interrupt errors are only present when booting with XEN. > > > > > > These are custom boards and they do have usb c, however we are unable > to boot from usb as it doesn't receive power. We currently only use the > usb to flash u-boot to spi which requires us to use a separate power > adapter. These boards get power and networking through a custom backplane > and interface with the backplane via a sata style justice (I'm not sure > what the proper terminology would be here). > > > > > > Since I cannot boot to rootfs with XEN, I'm unable to show the device > tree there. The only bit that I added to accommodate XEN is this bit here: > > > > > > chosen { > > > stdout-path = "serial2:1500000n8"; > > > bootargs = "hmp-unsafe=true"; > > > xen,dom0-bootargs = "console=hvc0 earlyprintk=xen > clk_ignore_unused root=/dev/nvme0n1p2 rw init=/sbin/init rootwait > rootfstype=ext4 ignore_loglevel"; > > > modules { > > > #address-cells = <2>; > > > #size-cells = <2>; > > > > > > module@1 { > > > compatible = "xen,linux-zimage", "xen,multiboot-module"; > > > reg = <0x0 0x03F80000 0x0 0x01aa8008>; > > > }; > > > module@2 { > > > compatible = "xen,linux-initrd", "xen,multiboot-module"; > > > reg = <0x0 0x06000000 0x0 0x02000000>; > > > }; > > > }; > > > > > > }; > > > > > > The gic declaration is in the vanilla rk3399.dtsi file and hasn't been > modified: > > > > > > gic: interrupt-controller@fee00000 { > > > compatible = "arm,gic-v3"; > > > #interrupt-cells = <4>; > > > #address-cells = <2>; > > > #size-cells = <2>; > > > ranges; > > > interrupt-controller; > > > > > > reg = <0x0 0xfee00000 0 0x10000>, /* GICD */ > > > <0x0 0xfef00000 0 0xc0000>, /* GICR */ > > > <0x0 0xfff00000 0 0x10000>, /* GICC */ > > > <0x0 0xfff10000 0 0x10000>, /* GICH */ > > > <0x0 0xfff20000 0 0x10000>; /* GICV */ > > > interrupts = ; > > > its: interrupt-controller@fee20000 { > > > compatible = "arm,gic-v3-its"; > > > msi-controller; > > > #msi-cells = <1>; > > > reg = <0x0 0xfee20000 0x0 0x20000>; > > > }; > > > > > > ppi-partitions { > > > ppi_cluster0: interrupt-partition-0 { > > > affinity = <&cpu_l0 &cpu_l1 &cpu_l2 > &cpu_l3>; > > > }; > > > > > > ppi_cluster1: interrupt-partition-1 { > > > affinity = <&cpu_b0 &cpu_b1>; > > > }; > > > }; > > > > Xen is not supporting PPI partitions. > > I also saw that your booting using SMP unsafe so all core are enabled by > Xen. > > > > Right now big/little is not supported by Xen and here you might have > some interrupts in your system which can only occur on some specific cores. > > I would suggest to try the following: > > - only boot enable in your dtb the cores with the same type than the > boot core > > - check in your device tree which devices are assign to the ppi_cluster > not available and disable them > > > > This kind of configuration will be tricky to handle so it will depend on > which devices have interrupts that can only be fired on one cluster type. > > > > Sorry but I cannot right now check in the device tree and do those > checks myself but if you do get the idea send back a mail :-) > > > > Cheers > > Bertrand > > > > > }; > > > > > > I've attached the device tree and include files just in case you'd > like to take a look at those. > > > > > > Thanks so much for your help! I've been at this for weeks with very > little progress. > > > > > > Cheers, > > > Brad > > > > > > > > > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis < > Bertrand.Marquis@arm.com> wrote: > > > Hi Brad, > > > > > > > On 11 Jul 2022, at 19:38, Brad Churchwell wrote: > > > > > > > > Hello, > > > > > > > > I've been trying to get Xen to boot dom0 with my kernel for weeks on > an rk3399 based board and thought I'd reach out for help. It looks like > either Xen is not properly recreating the device tree or the interrupt > controller is just failing. The hypervisor boots but falls to initramfs > because it cannot find the root device (nvme on pcie). Any help would be > greatly appreciated. Here is the complete boot log > > > > > > From the logs you have an issue with the interrupt controller and the > fact that your NVME is behind PCIE and as such depends on ITS is probably > not helping. > > > > > > I would suggest to try to boot on usb as root fs for a try. > > > > > > Also it could be useful to compare the device tree on xen and without > xen to understand what is going on (using /proc/device-tree). > > > > > > Xen seems to be ok but Linux is not happy with interrupts and is > showing several issues around this area on your logs. > > > Could you show us an extract of your device tree around the gic > declaration ? > > > > > > Cheers > > > Bertrand > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > --00000000000022749805e3afd07e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Bertrand,

=
I did this yesterday and it does indeed silence the warni= ngs saying to disable those cores, however the IRQ errors still remain.=C2= =A0

I think I made some = progress by changing "interrupts =3D <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH= 0>;" to "interrupts =3D <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH 0&g= t;;". I noticed when trying to use XEN-4.10 that it said "IRQ onl= y through SPI" and failed to boot XEN where 4.17 unstable=C2=A0boots w= ithout this error. Now that I changed GIC_PPI to GIC_SPI, I get the followi= ng output:
zaku =3D> run boot_pci_enum; run nvme_= init; fatload nvme 0:1 0x02000000 xen4.10-uImage; fatload nvme 0:1 0x01f000= 00 rk3399-zaku.dtb; fatload nvme 0:1 0x03F80000 Image;fatload nvme 0:1 0885136 bytes read in 5 ms (168.8 MiB/s)
56185 bytes read in 3 ms (17.9 = MiB/s)
27885576 bytes read in 65 ms (409.1 MiB/s)
8674182 bytes read = in 22 ms (376 MiB/s)
## Booting kernel from Legacy Image at 02000000 ...=
=C2=A0 =C2=A0Image Name: =C2=A0
=C2=A0 =C2=A0Image Type: =C2=A0 AAr= ch64 Linux Kernel Image (uncompressed)
=C2=A0 =C2=A0Data Size: =C2=A0 = =C2=A0885072 Bytes =3D 864.3 KiB
=C2=A0 =C2=A0Load Address: 02000000
= =C2=A0 =C2=A0Entry Point: =C2=A002000000
=C2=A0 =C2=A0Verifying Checksum= ... OK
## Flattened Device Tree blob at 01f00000
=C2=A0 =C2=A0Bootin= g using the fdt blob at 0x1f00000
=C2=A0 =C2=A0Loading Kernel Image
= =C2=A0 =C2=A0Loading Device Tree to 00000000f1efd000, end 00000000f1f0db78 = ... OK

Starting kernel ...

- UART enabled -
- CPU 00000000= booting -
- Current EL 00000008 -
- Xen starting at EL2 -
- Zero = BSS -
- Setting up control registers -
- Turning on paging -
- Rea= dy -
(XEN) Checking for initrd in /chosen
(XEN) RAM: 0000000000200000= - 00000000f7ffffff
(XEN)
(XEN) MODULE[0]: 00000000f1efd000 - 000000= 00f1f0b000 Device Tree =C2=A0
(XEN) MODULE[1]: 0000000003f80000 - 000000= 0005a28008 Kernel =C2=A0 =C2=A0 =C2=A0
(XEN) MODULE[2]: 000000000600000= 0 - 0000000008000000 Ramdisk =C2=A0 =C2=A0 =C2=A0
(XEN)
(XEN) Comman= d line: <NULL>
(XEN) Placing Xen at 0x00000000f7e00000-0x00000000f= 8000000
(XEN) Update BOOTMOD_XEN from 0000000002000000-0000000002120d81 = =3D> 00000000f7e00000-00000000f7f20d81
(XEN) Domain heap initialised<= br>(XEN) Booting using Device Tree
(XEN) Platform: Generic System
(XE= N) Taking dtuart configuration from /chosen/stdout-path
(XEN) Looking fo= r dtuart at "serial2", options "1500000n8"
=C2=A0Xen= 4.10.1
(XEN) Xen version 4.10.1 (root@) (aarch64-linux-gnu-gcc (Linaro = GCC 7.3-2018.05) 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfb= c167ef90065c0eeb7f91977701]) debug=3Dy =C2=A0Tue J2
(XEN) Latest ChangeS= et:
(XEN) Processor: 410fd034: "ARM Limited", variant: 0x0, p= art 0xd03, rev 0x4
(XEN) 64-bit Execution:
(XEN) =C2=A0 Processor Fea= tures: 0000000001002222 0000000000000000
(XEN) =C2=A0 =C2=A0 Exception L= evels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32
(XEN) =C2=A0 =C2=A0 Exten= sions: FloatingPoint AdvancedSIMD GICv3-SysReg
(XEN) =C2=A0 Debug Featur= es: 0000000010305106 0000000000000000
(XEN) =C2=A0 Auxiliary Features: 0= 000000000000000 0000000000000000
(XEN) =C2=A0 Memory Model Features: 000= 0000000001122 0000000000000000
(XEN) =C2=A0 ISA Features: =C2=A000000000= 00011120 0000000000000000
(XEN) 32-bit Execution:
(XEN) =C2=A0 Proces= sor Features: 00000131:10011011
(XEN) =C2=A0 =C2=A0 Instruction Sets: AA= rch32 A32 Thumb Thumb-2 Jazelle
(XEN) =C2=A0 =C2=A0 Extensions: GenericT= imer Security
(XEN) =C2=A0 Debug Features: 03010066
(XEN) =C2=A0 Auxi= liary Features: 00000000
(XEN) =C2=A0 Memory Model Features: 10201105 40= 000000 01260000 02102211
(XEN) =C2=A0ISA Features: 02101110 13112111 212= 32042 01112131 00011142 00011121
(XEN) Using SMC Calling Convention v1.0=
(XEN) Using PSCI v1.0
(XEN) SMP: Allowing 4 CPUs
(XEN) Generic Ti= mer IRQ: phys=3D30 hyp=3D26 virt=3D27 Freq: 24000 KHz
(XEN) GICv3 initia= lization:
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_dist_addr=3D0x000000fee00000(XEN) =C2=A0 =C2=A0 =C2=A0 gic_maintenance_irq=3D41
(XEN) =C2=A0 =C2=A0= =C2=A0 gic_rdist_stride=3D0
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_rdist_region= s=3D1
(XEN) =C2=A0 =C2=A0 =C2=A0 redistributor regions:
(XEN) =C2=A0 = =C2=A0 =C2=A0 =C2=A0 - region 0: 0x000000fef00000 - 0x000000fefc0000
(XE= N) GICv3 compatible with GICv2 cbase 0x000000fff00000 vbase 0x000000fff2000= 0
(XEN) GICv3: 288 lines, (IID 0001143b).
(XEN) GICv3: CPU0: Found re= distributor in region 0 @000000004001c000
(XEN) Using scheduler: SMP Cre= dit Scheduler (credit)
(XEN) Allocated console ring of 32 KiB.
(XEN) = Bringing up CPU1
- CPU 00000001 booting -
- Current EL 00000008 -
= - Xen starting at EL2 -
- Setting up control registers -
- Turning on= paging -
- Ready -
(XEN) GICv3: CPU1: Found redistributor in region = 0 @000000004003c000
(XEN) CPU 1 booted.
(XEN) Bringing up CPU2
- C= PU 00000002 booting -
- Current EL 00000008 -
- Xen starting at EL2 -=
- Setting up control registers -
- Turning on paging -
- Ready -<= br>(XEN) GICv3: CPU2: Found redistributor in region 0 @000000004005c000
= (XEN) CPU 2 booted.
(XEN) Bringing up CPU3
- CPU 00000003 booting -- Current EL 00000008 -
- Xen starting at EL2 -
- Setting up contro= l registers -
- Turning on paging -
- Ready -
(XEN) GICv3: CPU3: F= ound redistributor in region 0 @000000004007c000
(XEN) CPU 3 booted.
= (XEN) Brought up 4 CPUs
(XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit V= MID
(XEN) P2M: 3 levels with order-1 root, VTCR 0x80023558
(XEN) I/O = virtualisation disabled
(XEN) build-id: b7279757e82e3e9ea4c4115dabdbfe25= d56d762b
(XEN) alternatives: Patching with alt table 000000004018fe70 -&= gt; 0000000040190350
(XEN) grant_table.c:1731:IDLEv0 Expanding d0 grant = table from 0 to 1 frames
(XEN) *** LOADING DOMAIN 0 ***
(XEN) Loading= kernel from boot module @ 0000000003f80000
(XEN) Loading ramdisk from b= oot module @ 0000000006000000
(XEN) Allocating 1:1 mappings totalling 51= 2MB for dom0:
(XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB)(XEN) Grant table range: 0x000000f7e00000-0x000000f7e40000
(XEN) IRQ 41= is already used by Xen
(XEN) Unable to map IRQ41 to dom0
(XEN) Devic= e tree generation failed (-16).
(XEN)
(XEN) ************************= ****************
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 gu= est OS
(XEN) ****************************************
(XEN)
(XEN)= Reboot in five seconds...

It loo= ks like XEN is now using the interrupt controller but there are conflicts. = I was able to get this error to change to "Unable to map IRQ43 to dom0= " by changing all instances of "IRQ_TYPE_LEVEL_HIGH " to &qu= ot;IRQ_TYPE_LEVEL_LOW", but I can't get any further. I made sure t= hat there was nothing in the device tree that is obviously using IRQ 43 as = well.=C2=A0

Any thoughts on this?

Cheers,
Brad
=C2=A0

On= Wed, Jul 13, 2022, 8:00 AM Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:=
Hi Brad

> On 12 Jul 2022, at 17:24, Brad Churchwell <brad@cachengo.com>= wrote:
>
> Hi Bertrand,
>
> I believe I understand, but just to clarify, should I leave the ppi-pa= rtitions block in rk3399.dtsi as is and disable the little cores, or should= I also modify that block?

Disable the little cores and remove the partitions.

Cheers
Bertrand

>
> Brad
>
> On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis <Bertrand.M= arquis@arm.com> wrote:
> Hi Brad,
>
> > On 12 Jul 2022, at 16:59, Brad Churchwell <brad@cachengo.com> wrote:
> >
> > Hi Bertrand,
> >
> > Thanks so much for the quick response!
> >
> > I should have mentioned previously that this device tree and kern= el Image (5.15.16) does boot properly with the rootfs without XEN. The inte= rrupt errors are only present when booting with XEN.
> >
> > These are custom boards and they do have usb c, however we are un= able to boot from usb as it doesn't receive power.=C2=A0 We currently o= nly use the usb to flash u-boot to spi which requires us to use a separate = power adapter. These boards get power and networking through a custom backp= lane and interface with the backplane via a sata style justice (I'm not= sure what the proper terminology would be here).
> >
> > Since I cannot boot to rootfs with XEN, I'm unable to show th= e device tree there. The only bit that I added to accommodate XEN is this b= it here:
> >
> > chosen {
> >=C2=A0 =C2=A0 =C2=A0stdout-path =3D "serial2:1500000n8";=
> >=C2=A0 =C2=A0 =C2=A0bootargs =3D "hmp-unsafe=3Dtrue"; > >=C2=A0 =C2=A0 =C2=A0xen,dom0-bootargs =3D "console=3Dhvc0 ear= lyprintk=3Dxen clk_ignore_unused root=3D/dev/nvme0n1p2 rw init=3D/sbin/init= rootwait rootfstype=3Dext4 ignore_loglevel";
> >=C2=A0 =C2=A0 =C2=A0modules {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D <2>; > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D <2>;
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@1 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &qu= ot;xen,linux-zimage", "xen,multiboot-module";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x= 03F80000 0x0 0x01aa8008>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@2 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &qu= ot;xen,linux-initrd", "xen,multiboot-module";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x= 06000000 0x0 0x02000000>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0};
> >
> > };
> >
> > The gic declaration is in the vanilla rk3399.dtsi file and hasn&#= 39;t been modified:
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gic: interrupt-controller@fee000= 00 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0comp= atible =3D "arm,gic-v3";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#int= errupt-cells =3D <4>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#add= ress-cells =3D <2>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#siz= e-cells =3D <2>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rang= es;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inte= rrupt-controller;
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg = =3D <0x0 0xfee00000 0 0x10000>, /* GICD */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfef00000 0 0xc0000>, /* GICR */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff00000 0 0x10000>, /* GICC */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff10000 0 0x10000>, /* GICH */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff20000 0 0x10000>; /* GICV */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inte= rrupts =3D <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0its:= interrupt-controller@fee20000 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0compatible =3D "arm,gic-v3-its";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0msi-controller;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0#msi-cells =3D <1>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0xfee20000 0x0 0x20000>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}; > >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ppi-= partitions {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0ppi_cluster0: interrupt-partition-0 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&c= pu_l0 &cpu_l1 &cpu_l2 &cpu_l3>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0};
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0ppi_cluster1: interrupt-partition-1 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&c= pu_b0 &cpu_b1>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}; >
> Xen is not supporting PPI partitions.
> I also saw that your booting using SMP unsafe so all core are enabled = by Xen.
>
> Right now big/little is not supported by Xen and here you might have s= ome interrupts in your system which can only occur on some specific cores.<= br> > I would suggest to try the following:
> - only boot enable in your dtb the cores with the same type than the b= oot core
> - check in your device tree which devices are assign to the ppi_cluste= r not available and disable them
>
> This kind of configuration will be tricky to handle so it will depend = on which devices have interrupts that can only be fired on one cluster type= .
>
> Sorry but I cannot right now check in the device tree and do those che= cks myself but if you do get the idea send back a mail :-)
>
> Cheers
> Bertrand
>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >
> > I've attached the device tree and include files just in case = you'd like to take a look at those.
> >
> > Thanks so much for your help! I've been at this for weeks wit= h very little progress.
> >
> > Cheers,
> > Brad
> >
> >
> > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis <Bertr= and.Marquis@arm.com> wrote:
> > Hi Brad,
> >
> > > On 11 Jul 2022, at 19:38, Brad Churchwell <brad@cachengo.c= om> wrote:
> > >
> > > Hello,
> > >
> > > I've been trying to get Xen to boot dom0 with my kernel = for weeks on an rk3399 based board and thought I'd reach out for help. = It looks like either Xen is not properly recreating the device tree or the = interrupt controller is just failing. The hypervisor boots but falls to ini= tramfs because it cannot find the root device (nvme on pcie). Any help woul= d be greatly appreciated. Here is the complete boot log
> >
> > From the logs you have an issue with the interrupt controller and= the fact that your NVME is behind PCIE and as such depends on ITS is proba= bly not helping.
> >
> > I would suggest to try to boot on usb as root fs for a try.
> >
> > Also it could be useful to compare the device tree on xen and wit= hout xen to understand what is going on (using /proc/device-tree).
> >
> > Xen seems to be ok but Linux is not happy with interrupts and is = showing several issues around this area on your logs.
> > Could you show us an extract of your device tree around the gic d= eclaration ?
> >
> > Cheers
> > Bertrand
> >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments = are confidential and may also be privileged. If you are not the intended re= cipient, please notify the sender immediately and do not disclose the conte= nts to any other person, use it for any purpose, or store or copy the infor= mation in any medium. Thank you.
> > <rk3399-zaku.dts><rk3399-zaku.dtsi><rk3399.dtsi>= ;
>
> IMPORTANT NOTICE: The contents of this email and any attachments are c= onfidential and may also be privileged. If you are not the intended recipie= nt, please notify the sender immediately and do not disclose the contents t= o any other person, use it for any purpose, or store or copy the informatio= n in any medium. Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.
--00000000000022749805e3afd07e-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:34:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:34:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366595.597522 (Exim 4.92) (envelope-from ) id 1oBcVS-0002es-2U; Wed, 13 Jul 2022 13:34:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366595.597522; Wed, 13 Jul 2022 13:34:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcVR-0002ei-Vv; Wed, 13 Jul 2022 13:34:21 +0000 Received: by outflank-mailman (input) for mailman id 366595; Wed, 13 Jul 2022 13:34:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcVR-0002ec-Ew for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:34:21 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20052.outbound.protection.outlook.com [40.107.2.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f6dae73-02b0-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 15:34:19 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8383.eurprd04.prod.outlook.com (2603:10a6:20b:3ed::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 13:34:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 13:34:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f6dae73-02b0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDJbUzwl/X+XUxY7eWwDGPatnVdvnW3WtFLtgtgh+Ty4tIuPSfQ9DmR72xU3uj2Rl4kMeLPZl6gLcV7CZK42kUcHB4/BEQZggHuNPqBo4C94kh62ioPI8taUT7o9V19sPMz6uYv6p48ATFH2tVNAP8CA4TINjl9wEt8zoqej/VPkR1+FSaPHCZDr+pwBp3c+J1SWwQo9gqqWLiF9DYJd8M9QRWkaMCUizff1CMVo+GIWoKhdMK/sksHGEvUFEDFHrEQJy5OPJZeHtbXsMAu6NspXE09suMJwUAm2PPdVLzaEUErwfcX1sgXhuLqk19iiNtnHDBA/8g/eW8SKlm4NTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FdSkwSBxSLlF9TLha0Dcz4mHjxZuODbfNcHXKcCCbXE=; b=dcWnchSiju7jCsVSrUoqymnHeylZCcwnwjZdjZMPZQz3bJ/CfewTCL1XWe4LPLsa5Swf3h9qFm1FPvAzqHG4QwTCAYelDepZcKZ+t1Jagzu6qUU1mBc9nzsh2lVNPV06hIktBCw3a58M4o3pOxcXgMF7oMBhAvHfPU1yStRfnhG1CVM104k2xE5eu81VoClSaBREM9GSC9QDXEN05cY/pmgrzKE6Kg64TBeDE8EBZoigGCN7E7lf/jQfFhRBzwNXxfh2Z5Q3zhhjQIM7YHVCIlcVw9zTyjkYJx0bp0nHuHmasyPaFNf4F+rpXIaSanb7R4LTHJvJaT/jH6zv9CbAQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FdSkwSBxSLlF9TLha0Dcz4mHjxZuODbfNcHXKcCCbXE=; b=kQwVxPrYy0/5GEnHsiwN7dZ4WquHf1nLswcN9BsoSdatexXwfgttd4JVla42EF+aTRYcfXQoQejf88qCr/ViPS7d9kqESJMEYXvDvcLLc9K7UUmDZgYgosfipVySgnr7xsKteXyTFg9PpQFPE8fPxM7cBumjPtl1tTt7FJByhzt7i9ScLQI9fQqGWipErW0IaEFwcE+3EoXEwHRgZxFr/ywjQ9ygi0+a3Tt7b4Y3jDJipSkujseomzVIItOGe+9w6yZFm7Re3I3SuI/qpFsolu3N3lreGh5SWUA0KeW+tJzSKp4cibtBMTllj8FMVvOv2il2oCa4zaTKNJnE+IDsrQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> Date: Wed, 13 Jul 2022 15:34:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Juergen Gross , "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1a87adb-7c31-4533-9d9c-08da64d462b0 X-MS-TrafficTypeDiagnostic: AM9PR04MB8383:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UrNm6I3Q1oDa+JN1L6kVetIpsAxDmxMcujNSFoRcG50x5OpRLTS7wOU42sBLcyzMA39FxgntvMPS6b41Ew7gm55ocYSQRi912lf+EYGtTMN01/zat43uEm3/uMSq56FtI4duxJ9t/PyVTDsfM1XNMB7Vjj2LwYqZCHHjKa/zCyStQOzP+ZcBRuZMmNLyHdPUmEU+9sxf+Y7kGhCd0esi00TMAhpfkrlWiAcIesCmidGn9gLwUNQ8fbH29lKTGduW+Hby7W9c0Vu6IYbCFCpC4XVp3ku9U5g++o+QtFJCOKQckbKtwkklgyCM59Ix/BbnDdiAlsJk9YT6/tH1QTBIZu8cHIRwuRUNjIE35hQwBGKsBpRk4gzq71zqK37X6S4/ArHjWzskqQ0FVqkYO/2mCGeg6zej0y4kUxlGiRAQSYNgVZg4pelrZmpiCAJhk21RBoXZg2pHEGH0bX+2lzpPBEkoJ5raE4JL6X3WcZ0gwFLuk8XqJtMz9rrwMLrZYfkomHbdDPjdiSaDhTpVuOymdoJOyCaDLjXU2qp/pNRsAK3HAifTOdLW6eB/bgOvenKpkrNxhdO05avVT0JzzP+gUYTwlufpMCGZgW3J4lo38st8dChGruiIk44w0RDDT7CJBmu7HR88Np+jIU9zYRPkYqkMKqlp0PW1Nv+PI0gIIs6oPRSI8exwxl0erK2mkcICIACkFNno88rQjhdy46PADwaA+VCngMVca3psNFCz4N042d80pyTXJwUg2hLErumg4GsrbNfiRtTRUefgwwLPYQJhDOjitTZ4lEDFsjmpZiGUisEXWjt4usAdcEo8JjdQ1vTi+aF6kExRvWnHp0v9bLjNafvBdPPDRXzdEfs28g4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(136003)(39860400002)(346002)(366004)(83380400001)(31696002)(86362001)(8936002)(5660300002)(478600001)(6486002)(38100700002)(41300700001)(7416002)(6916009)(54906003)(31686004)(316002)(66476007)(4326008)(8676002)(66946007)(66556008)(36756003)(186003)(53546011)(6512007)(2906002)(2616005)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTl3Lyt4R2haQ1psZUJReUlGd0dHYlVDeDhpUnhyM3FMYlYrMTI3WU5QeEt5?= =?utf-8?B?MTZ4d3JvVFVZK0IrclQ2T3JtalZTZVF6a3dPUHpocWxIdDVDT1lLZmszbWF3?= =?utf-8?B?cmppVUtLbG9OWVR3ZmRzbFptTXpwUTJhcmQzZGxPdE9jRUVITFBPOHZKdlY4?= =?utf-8?B?em5FQTh4RkptZmpYN2cxMTNhRitka2VneEptMUNGNE1Vc1hUVkwyNUtyOGZ2?= =?utf-8?B?Y0FHVTBBdGxYcXlvNFVMa2Z0L2dpMjMwWUZjVjFmaSt4VG8vZUF1dUI4V2t2?= =?utf-8?B?VVFTS3NQbUZHY2RsbjhRTnRhS2l0Z0VpUUtTQmx6ZkFQOGN6akEwTk1yTmZI?= =?utf-8?B?aDVxQ2QwNzh5UU10eEkvbmpKbmtPVkgyY3pmeVdtbFdoVUhBL1g0WjBxNUEy?= =?utf-8?B?Vjg1MUoxZHVCQmZjNjNtdVU4cXdsd2pLdDVIQ1M0QnRYZE84RW1aSzRDTjho?= =?utf-8?B?bDVRZlFhZTNzUjNrVjRwdkJIRWoybnoyUEkvR0FSRXMwVHYrVlUrRm51L0g5?= =?utf-8?B?R1paOXBWMk8vNzNtcmpoSkE5UEp4LzB2QnhqclVCWUpCVm11bE5NeEZEWUNU?= =?utf-8?B?czROTnpFMG1rM3ZlUHZkWUNOL2dab29CdHY3QlVKUW5pQ3YrdDZvZ21ROXVm?= =?utf-8?B?Z3RTdUZkRGVjcThIUjBYa043Y1dmQ2k2aHBFeWpLS0RVMTVBUG5JdXFDVlRu?= =?utf-8?B?b1M4c3hjdTNYZDU4Wk5jV2lLN0kxdXcwMTgvUWI0NHNjMzM2Y1lqalQ4aWhj?= =?utf-8?B?RzlkMnFrUzdlbmZtTEpxTVRSc2I0UTkxdmlTbmFFTEhjRi9LZ21jaG42QXJJ?= =?utf-8?B?VW9VaE9YUlVyeVQ3NXBLSlFMRVlMZlVxWTQxMUgxWk1nVEk3cEtxQUl5YSty?= =?utf-8?B?SWhBallnSmxmaTJwamsyMHF0SlZkVTgvKzhzQnFtc1Z5eks5V3d5QUFnSFda?= =?utf-8?B?T3J2R040Q3NLcjZMVERJNVVYY2taRk9pMmt1QmRSL3djTkpkNVo0K0hrS0ZZ?= =?utf-8?B?VndlblJRcUZSdFN5MFMxMGJWdmpodjBxSmhjTXZrcnFTSGE3YnV5YUxzY3U1?= =?utf-8?B?QnQ4elc1RHdSWDdxZjhseS9lSGlKQVdqSjY5WEQ1d3VJR3U5ZjhMYldZNkpq?= =?utf-8?B?eE0vQm5wRkpHWCt1TEV6Q2NOeHIrZG9JalZ2YU5YSVBDWHpUU2RuRkRjWGR2?= =?utf-8?B?cjVlZ3lLemlhSHpnd0kxVGNvY2dwNzNLQkFFcmNyMThFa051a3ZtQndQWDBx?= =?utf-8?B?ODRpdm15RmVUeitsZGxCRmIwNmVuR3BITVRIMDBGZUF0WXY1WlRvUHEzQkc5?= =?utf-8?B?MTZ2NmEyZU00Q1c5ZzVQb3l1MHVzUDZMdTRnS2JmV2wxc21lSlhlclMrN3ND?= =?utf-8?B?UjZjWG1RQzJnWllyM3QwT1F3VGRDUTAwMXpZNGVtbVZFT05BUEhBendqZ1Y5?= =?utf-8?B?VktFMGFYSkFQWGZsaGM5R2MyMm91Yy9jeEx1TWRDb2syQkZmcGFDUU1TRTFy?= =?utf-8?B?U1FjSlV5T0JGZEJoNUt4V2JaU3FOV3NRM05hZzQxK1N5UnA3WmdVUEVYN2hF?= =?utf-8?B?WVF6TDdLMjRDME1UREpIeVB6N0ZLVTFna0creGw0UnhldGlNd2RKM0hzSFNB?= =?utf-8?B?OUNYc0V1TGMzc2lJSjI1VUJqa2JjSStwTlluejd3Y0JyWGZJRkVDVzgxbXh0?= =?utf-8?B?MmR2MzNUWnN0ZmE3VGVOeFNVbVJCZTF3aVhTSWRCc29RbS9qalZ2c2tRMFRj?= =?utf-8?B?VThPOGROYm1FRWoraytiM2ZTUEgyY3dzR3I4MmZYUkxJbm8vZG84b3NqYXZw?= =?utf-8?B?SWI1MGRjSXVaTzViVHFyZGk5RndkSndyVHQ4ZVJacU8xeUlLbDJObDBidWVW?= =?utf-8?B?NlE3Q3NVVkthanB4TUJBQ0JhMjJNN1NnLzg0eVYzejh5bWdvakRFRzdmNDRC?= =?utf-8?B?NjJhakVnR3VwRzhRcTE4SGVhQ0daRk1EdVpmWGIyRzZ1c1pNa3BDeE1ES1pm?= =?utf-8?B?bVRodmdhRU4xZlpuUzdnVmNrbFVzWHZlSFJDbzVVT0JyZWdGSGRreFY2bjdM?= =?utf-8?B?ZUZqU1NZc2EwZmhBenl2dXl3UjNBTU5FUkFsZEk1cUY4Z1R3RldQZlR3aGxO?= =?utf-8?Q?wrSKwD+cvqlRYLrrRyxUQm5XY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1a87adb-7c31-4533-9d9c-08da64d462b0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 13:34:17.9495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7rkSGaHbeh+E1ogjBzKrH8T4ht7u8CaTsp5jkwd4TrDnsY6JbV9T9I6+lBijiq6UF9OUMPXbO8qaXQPhOLgDfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8383 On 13.07.2022 13:10, Chuck Zmudzinski wrote: > On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: >> On 7/13/2022 5:09 AM, Jan Beulich wrote: >>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: >>>> On 7/13/22 2:18 AM, Jan Beulich wrote: >>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: >>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) >>>>>> *Add the necessary code to incorporate the "nopat" fix >>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) >>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) >>>>>> *Expand the commit message to include relevant parts of the commit >>>>>> message of Jan Beulich's proposed patch for this problem >>>>>> *Fix 'else if ... {' placement and indentation >>>>>> *Remove indication the backport to stable branches is only back to 5.17.y >>>>>> >>>>>> I think these changes address all the comments on the original patch >>>>>> >>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to >>>>>> include Jan's idea for fixing "nopat" that was missing from the first >>>>>> version of the patch. >>>>> >>>>> You've sufficiently altered this change to clearly no longer want my >>>>> S-o-b; unfortunately in fact I think you broke things: >>>> >>>> Well, I hope we can come to an agreement so I have >>>> your S-o-b. But that would probably require me to remove >>>> Juergen's R-b. >>>> >>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) >>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); >>>>>> } >>>>>> >>>>>> - if (!pat) { >>>>>> + if (!pat || pat_force_disabled) { >>>>> >>>>> By checking the new variable here ... >>>>> >>>>>> /* >>>>>> * No PAT. Emulate the PAT table that corresponds to the two >>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). >>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) >>>>>> */ >>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | >>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); >>>>> >>>>> ... you put in place a software view which doesn't match hardware. I >>>>> continue to think that ... >>>>> >>>>>> + } else if (!pat_bp_enabled) { >>>>> >>>>> ... the variable wants checking here instead (at which point, yes, >>>>> this comes quite close to simply being a v2 of my original patch). >>>>> >>>>> By using !pat_bp_enabled here you actually broaden where the change >>>>> would take effect. Iirc Boris had asked to narrow things (besides >>>>> voicing opposition to this approach altogether). Even without that >>>>> request I wonder whether you aren't going to far with this. >>>>> >>>>> Jan >>>> >>>> I thought about checking for the administrator's "nopat" >>>> setting where you suggest which would limit the effect >>>> of "nopat" to not reporting PAT as enabled to device >>>> drivers who query for PAT availability using pat_enabled(). >>>> The main reason I did not do that is that due to the fact >>>> that we cannot write to the PAT MSR, we cannot really >>>> disable PAT. But we come closer to respecting the wishes >>>> of the administrator by configuring the caching modes as >>>> if PAT is actually disabled by the hardware or firmware >>>> when in fact it is not. >>>> >>>> What would you propose logging as a message when >>>> we report PAT as disabled via pat_enabled()? The main >>>> reason I did not choose to check the new variable in the >>>> new 'else if' block is that I could not figure out what to >>>> tell the administrator in that case. I think we would have >>>> to log something like, "nopat is set, but we cannot disable >>>> PAT, doing our best to disable PAT by not reporting PAT >>>> as enabled via pat_enabled(), but that does not guarantee >>>> that kernel drivers and components cannot use PAT if they >>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) >>>> instead of pat_enabled()." However, I acknowledge WC mappings >>>> would still be disabled because arch_can_pci_mmap_wc() will >>>> be false if pat_enabled() is false. >>>> >>>> Perhaps we also need to log something if we keep the >>>> check for "nopat" where I placed it. We could say something >>>> like: "nopat is set, but we cannot disable hardware/firmware >>>> PAT support, so we are emulating as if there is no PAT support >>>> which puts in place a software view that does not match >>>> hardware." >>>> >>>> No matter what, because we cannot write to PAT MSR in >>>> the Xen PV case, we probably need to log something to >>>> explain the problems associated with trying to honor the >>>> administrator's request. Also, what log level should it be. >>>> Should it be a pr_warn instead of a pr_info? >>> >>> I'm afraid I'm the wrong one to answer logging questions. As you >>> can see from my original patch, I didn't add any new logging (and >>> no addition was requested in the comments that I have got). I also >>> don't think "nopat" has ever meant "disable PAT", as the feature >>> is either there or not. Instead I think it was always seen as >>> "disable fiddling with PAT", which by implication means using >>> whatever is there (if the feature / MSR itself is available). >> >> IIRC, I do think I mentioned in the comments on your patch that >> it would be preferable to mention in the commit message that >> your patch would change the current behavior of "nopat" on >> Xen. The question is, how much do we want to change the >> current behavior of "nopat" on Xen. I think if we have to change >> the current behavior of "nopat" on Xen and if we are going >> to propagate that change to all current stable branches all >> the way back to 4.9.y,, we better make a lot of noise about >> what we are doing here. >> >> Chuck > > And in addition, if we are going to backport this patch to > all current stable branches, we better have a really, really, > good reason for changing the behavior of "nopat" on Xen. > > Does such a reason exist? Well, the simple reason is: It doesn't work the same way under Xen and non-Xen (in turn because, before my patch or whatever equivalent work, things don't work properly anyway, PAT-wise). Yet it definitely ought to behave the same everywhere, imo. Jan > Or perhaps, Juergen, could you > accept a v3 of my patch that does not need to decide > how to backport the change to "nopat" to the stable branches > that are affected by the current behavior of "nopat" on Xen? > > To do such a v3, I would just have to fix the style problems > with my original patch and not come to an agreement with > Jan about how to deal with the "nopat" problem. > > Chuck > > Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:44:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:44:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366602.597533 (Exim 4.92) (envelope-from ) id 1oBcen-0004H8-WE; Wed, 13 Jul 2022 13:44:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366602.597533; Wed, 13 Jul 2022 13:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcen-0004H1-SI; Wed, 13 Jul 2022 13:44:01 +0000 Received: by outflank-mailman (input) for mailman id 366602; Wed, 13 Jul 2022 13:44:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcen-0004Gv-91 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:44:01 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d95ac7a6-02b1-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 15:44:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5332.eurprd04.prod.outlook.com (2603:10a6:208:61::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 13:43:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 13:43:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d95ac7a6-02b1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HvNwdMZu+hEHKWDwCY+of8IJtECOoUf7e+kOL9mYwjn63PoY1n1csqC/FiX1kbOJiPnfFHE/W/kqKFsTYNSKm3NEsI3RJgHVXgSSMMK0Pa2y4NHzcCb7PKjdYyXfVpT+vPJq7NBX0RYajn5FAka2ed1yNDZ/8Iv0WMIC9IMIDLU9c2i2DYDYvcdjV3EqGvYwMTYn+X0d8vVVGi+GXciStFLm4qo0tyX0yFgO6K70VQASk6YrF1fSyUGNJkQzBgL81TajY2srqBzoSGM/Ktc7KLt8HWlBgvQVUC/eZNuK+bEvjzaJhR1xeCuRXKXx7FAY+vLnMfAjkoL//3w7M/PGww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=apLZ7A4dBGVtT0G2VX81kmlDBasKgsOC2GGKrwnukqQ=; b=OkkZh5Nad95xqb0A+HOZgvLbXJtjplnxYe61C1eHxvALLZxUxWtShou6pnqghyz/8fwQjmkdtadWD84q3OTO8Gvx3wBR9PXBOhJOGqu2FXdljg3tKyRiqQkPBbkEFcgEmjl6stZVQwt3v/mRivSUnRjtk/FUwoHW7IjI+iPBtbAUFLRidFQTT4vn6KmFIiP9WFXPZREW6OUOV64Z3mtLBEJ/DCDMffcFOdDIREp885/vdj4z0EpDno5i3J/OJ67Xd3mV4rIB4KrofHAtabGpm2/WOUd68+bbRm5otQqOTdIw741QTSqLfURFlPWPyWT72++HTALOPGAx7e7k61Du6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=apLZ7A4dBGVtT0G2VX81kmlDBasKgsOC2GGKrwnukqQ=; b=VtS1TRg3dHebjGWTmQ/+/zaIb+XUSuicPG+gkjMWdW5Wu3ZQ2ObxsK+gU5YI6oIIv9hCOANGUGc7bymzOqJb+u9z2Xt9dLyYkGERnm982jUNHEsezCMTpG4JBWg9Bo/L8QGOxVMTVsr3wvoFKQCbfEf/0wg8Vsf57ZD5E4s9AbY2XKQPS5D4b7W5Zdl2z0DLMCQHorAB1dePPekE3EAmN5jFpAAWIxLZMLIF+xNHNgatv516s/DFx/MKPdqexzas/VaHfGMRZT8FYE/K4PA6COJvbFMifkb+zfhNLSvpHa/7s0IRsDXuShalhfB2Fu4Y4dYHa2QWDUt+VWSh3nyGIw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6df15012-bee9-46b1-8583-be193c7330ea@suse.com> Date: Wed, 13 Jul 2022 15:43:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/9] xen/x86: use arch_get_memory_map to get information from E820 map Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-6-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM7PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:20b:100::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9a953256-43b6-4b85-bf4b-08da64d5bc26 X-MS-TrafficTypeDiagnostic: AM0PR04MB5332:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p0AEwKZ1nWWCD0w8qxUxxmk2hYYQJ8Q1NiRAHtpWXsItNgwKJxzbP24sZIuQtlL7wnSdFci73yOtuXr6pQ3pn4QDKfSs/QgUvkYH+HcqEci1yttTDOfg/VabVjw/OgsCffvygBOnPRK9N7Wjudgr3LAcTDsOlTi89hmRmaNt7p2BY8xqQvRiwTib0jNVRBtW9XFdGtJjyfUcWWfI4yRWnXJKX2wsSjykqSSg9gqX4P9JC04Gt4PLGYnZUnhfHTAiYcdB4B5WEkZDMMh1HqqQodTob3dSPDnq7cRd34zcbpQtrK6CaaMjUFIl47hZJ/54kLv+tY3pDlCBswIArDGAvtYAXmFKdSENFy8+dtKeQOfQ5brJB56bjJGeLmP6ssy/tpyo+yAEOL1o3wXoz0EVl8W91FEnJDeuEt5jcZhGHAj5jPzJVqYB+cd1dpfXeCEqPFSlzo71POsRTq4awfMI47bjC+F/yYnIXw2i967xIVqmROhgWPeaSsET9Dav28CRhUjXxENa8jxfnHArk/fZZ7cx6qI8ksweBPEpkt9xkdf0Xuzt1MHH32LGPjKUinLdqu8/FKXNrzX6/+4tqYh4EASwV3ZiEwjlcnTJqjjxf6CoFjQvOo7hTSI/GXPSwXUnbrvx1ezVx5tWGa23ynYAJKXoISQPxo4cmVUqaWwMFULGawc5cNBNaRPJ3DKnhElQF9EO6LyqqSxWTYSL8wKPiXRCocLnk0XA4WAToc7mC0CWmhON44rsWEgSRY34m3qu1WVK2jLPliiuY+IJouRGuTpeymBUYrh6SVBzVdyNig+G2OzbTzWERicfHbggGEg2SGrb/sUf1Hj89Ti/zIAskDtR6ZybBqp2IMobcvMiCFY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(376002)(346002)(366004)(396003)(6506007)(26005)(54906003)(4744005)(6512007)(86362001)(6862004)(41300700001)(2906002)(38100700002)(8936002)(5660300002)(36756003)(8676002)(31686004)(186003)(66556008)(66946007)(478600001)(4326008)(66476007)(316002)(53546011)(6486002)(2616005)(6666004)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzBuM3NDSUttdjM1S2NqNkI2eUsvU05aTjFPQnlTMDgvdEF2VWFrOHBsV3dB?= =?utf-8?B?VGZ1WUdXU0h1aG5rZ3YxSVZQSkYxcXhqUE53Y211Wlh5TURNdjhHeEJPVTZ3?= =?utf-8?B?dC9aTU1GamxPWWI3cDhqckw5R3I5TGdLMG8rSVlZN3ZZb2wxVHlMUlFIUmdv?= =?utf-8?B?MS9lM3ZmNHZ6Q0hpTDNObUdYbkVaREpKSEpYbXJYbU5Eek91czkvRG5razBq?= =?utf-8?B?TmJ2QXhSeEppVlpwbDg3MFEwb1NjaE9Tc0VvTXV3c0xydEJWaWpoc0dXWXFw?= =?utf-8?B?cG54bFRMQ1JXU0xxMWJZR29KRnFKTVBROTB3WTQvZ2lKcTd3ODZKRWpBTncx?= =?utf-8?B?SUtnTzRKTDYyem9vWGdlVXRnY2g3bFNiWTBCZGY3RzFSUEpacFh2SjlwMDFl?= =?utf-8?B?MVJKb2ZSTHluK0hrbG9sTzVhRS9kdUVSSEtBbC9JZFZ3NjFSWjZCOUdNSVVh?= =?utf-8?B?cUErc2ZVMXpHend2N0oxb0xXMjVxcDlBRStrWXh0MUpkZTBjWEFEbGY1MVJV?= =?utf-8?B?RXNtMmk5akU5RXhabCt2WWdEcmlUOXVqVU9mSFdLUlZCUGsyZURrWDBMcjhU?= =?utf-8?B?ZE5IN1F4RWszNThtRlBvNGdrOHR6RmlUVkNuUDFWOTN5MGRkUTlQelVMZ1Nh?= =?utf-8?B?NytiQ2ZnWFpOQkpEWEFBenJueU81UHJjQ20vbGJKcFAva0JHRUY0OTlCYlBN?= =?utf-8?B?dGpLeFNyckJoN1d4RXVqS2kvUlpyME9iUWhFZk93K1FwdUFVWkIxSXNxdGtP?= =?utf-8?B?THlydmdMMUhodStXM21iVVZQOU5lYUlrWUZZN1picGZ0MmE4QkhpL1VIbnpF?= =?utf-8?B?U1RwSnFKSHk1cHl6WUhJYVRjQWFGdGZtUU9ZVVhwdlBkS1Q3Q2FUVElkNE1K?= =?utf-8?B?ZHdTQ2NFUVZ1VWpET2NSUVBSVjlOSDhWR2ZUN2UrTXFLYXJPb1VQY3FtNk1V?= =?utf-8?B?eGM5NnRmVExHMFY5alNZTVNXNFdaY1NDOE1QLzN6T3Q0SjJlTjBsdXR1bURj?= =?utf-8?B?U0JieldBdmxVRTc1T1IvWmRzSU9wZ1E5TmhmVy81OXZPVDErckUxejdwTlhN?= =?utf-8?B?aGhkOFZJWGF4TUNoaUJORWwvZTlPbi95bWIza0hpR2I5cXBoN2hYeW9YUkxt?= =?utf-8?B?R0lJdzl1RGN2QjFucURjclZOZXptdzhnQVZDeHlaTXpBS2xON0ZpcTRoT1BQ?= =?utf-8?B?SW9tNG5JV1BHNE5hSnNEaDF1aThtZHphVlh0UmV5UnBpRTBXUnZESGZHZ3lx?= =?utf-8?B?ZGY2ZTJKL2hha2tqSGp4ZEgvM2l3ajR4ejhzeDFjaVNhcnV2amZJZitmdWha?= =?utf-8?B?WndTMEx1YytnaGhha2ZmQ2pOeGowd2xSU3ZBbWdyVUFHWkFjUHp5RjFKeDhw?= =?utf-8?B?RFRKL2NhcnBDL3NYaGhmSWpXa1ZWdzljNnAzblhQeXBueEw1ZzV1ZkZxR0Fz?= =?utf-8?B?Z2lyNmFnQXVMRG1EazI4ZXprYVU4djNNNkNUYnQ4cjczR05HVTExTndkeFpS?= =?utf-8?B?TGVCQWJiUWZJNTRNYWRVQXFQQjVxZHpDWGw0cVlsVVh5MmxwYnhXcVBJMHRm?= =?utf-8?B?Z1l3SitvQmY5cWVOZzY0Wkw3U0p4enltWlVhY09ZUWRFVSt6UGhLUHArOXp1?= =?utf-8?B?S3JJZlIxL0pRRnNHNmk1WStiM2xlMWtyQ2Y5SnFpUGpVeGdOTWJwU0puM3lG?= =?utf-8?B?N2ljRDRRKzBZd2dxY1kyMm9sQXVoMDcydkNxVStnNFpqK0Z6Q3ppL1NvK3ZJ?= =?utf-8?B?Z21ycWg4YlN0VkxpSkJqeitrMy9OQlU1alNNV1VIS1l4NmVlTVg2RmM0TkFs?= =?utf-8?B?eU1KNjc5aTRqZ2xDR1kvUWlCYVB6MXNNTHB3U1RqcVJMM0NzZ1N4ZS91QnRr?= =?utf-8?B?NlZ5Qkp2UFFQbUhkTzExb2tZTFIrRXpEMTFCSktoZmJVQmlYSXBObG52N2lJ?= =?utf-8?B?OCtzRGJHYjVQV1ZPMXlwY3BheG5kd0pLd1UwR2dHRHhOaTlieGU2aGxMZXBw?= =?utf-8?B?dlkvNjNrc0hhNm9NOC9NNWFyRlVmQldOV2VkUEsyK200TkoyWHFOODhOa0p1?= =?utf-8?B?eWY3d3ZBS01vdjVBREQrbDB0TTRydG1GeE56R3piSkJ4dlE2NW9UYm1WYmVG?= =?utf-8?Q?SrywOCmsgWTkJ7ny9Fj13RMhE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a953256-43b6-4b85-bf4b-08da64d5bc26 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 13:43:57.5532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bPOQ6/UaorEa6oW6jr4qtykKh2HeK2t3lNySY3gO2vGNP3Er6mX6KgEDflp+k5QwTyvUJXFKio0xUl5z4iVpxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5332 On 13.07.2022 12:37, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2022年7月12日 21:40 >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> @@ -82,3 +83,25 @@ unsigned int __init arch_get_dma_bitsize(void) >>> flsl(node_start_pfn(node) + node_spanned_pages(node) / >> 4 - 1) >>> + PAGE_SHIFT, 32); >>> } >>> + >>> +/* >>> + * This function provides the ability for caller to get one RAM entry >>> + * from architectural memory map by index. >>> + * >>> + * This function will return zero if it can return a proper RAM entry. >>> + * otherwise it will return -ENODEV for out of scope index, or return >>> + * -EINVAL for non-RAM type memory entry. >>> + */ >> >> I think the comment also wants to spell out that the range is >> exclusive at the end (assuming that's suitable for Arm; else now >> would perhaps be the time to change it). >> > > Did you mean we have to mention the range is [star, end)? > If yes, I will add related comment. Yes (worded one way or another). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:45:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:45:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366607.597544 (Exim 4.92) (envelope-from ) id 1oBcgb-0004re-Cu; Wed, 13 Jul 2022 13:45:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366607.597544; Wed, 13 Jul 2022 13:45:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcgb-0004rX-AA; Wed, 13 Jul 2022 13:45:53 +0000 Received: by outflank-mailman (input) for mailman id 366607; Wed, 13 Jul 2022 13:45:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcgZ-0004rR-ES for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:45:51 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1afd37f2-02b2-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 15:45:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 83449339BF; Wed, 13 Jul 2022 13:45:49 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E914C13754; Wed, 13 Jul 2022 13:45:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Yt9rN4zMzmKQTQAAMHmgww (envelope-from ); Wed, 13 Jul 2022 13:45:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1afd37f2-02b2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657719949; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DLPq+/BqRirohgnuISi9vglE+Gp1k13nS0xAJRU0hxA=; b=JWViSCZZiYlLXYo9S3PkCap+JaYexGbYwXLA2k8HA9CZghCY8xl4CK9ixCwl0nvVy0izNH w/TelSGNw/UhHTLny2iy5VCqWP8DIqttS+SnlxpkJHeMjNETRe0TBdaluvzS5jCXES+qGP a1L7Dei3QklJbrQUjkP/tq1RIsRJ30U= Message-ID: Date: Wed, 13 Jul 2022 15:45:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich , Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> From: Juergen Gross Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR In-Reply-To: <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------eAnzHIkgnyu5Zz2tML6wHnxq" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------eAnzHIkgnyu5Zz2tML6wHnxq Content-Type: multipart/mixed; boundary="------------yfXlC0JibNNYMYRQRYhySi2z"; protected-headers="v1" From: Juergen Gross To: Jan Beulich , Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" Message-ID: Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> In-Reply-To: <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> --------------yfXlC0JibNNYMYRQRYhySi2z Content-Type: multipart/mixed; boundary="------------fDVm7r2YKWmsXPXC84AR5mO6" --------------fDVm7r2YKWmsXPXC84AR5mO6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDcuMjIgMTU6MzQsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiBPbiAxMy4wNy4yMDIy IDEzOjEwLCBDaHVjayBabXVkemluc2tpIHdyb3RlOg0KPj4gT24gNy8xMy8yMDIyIDY6MzYg QU0sIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4gT24gNy8xMy8yMDIyIDU6MDkgQU0s IEphbiBCZXVsaWNoIHdyb3RlOg0KPj4+PiBPbiAxMy4wNy4yMDIyIDEwOjUxLCBDaHVjayBa bXVkemluc2tpIHdyb3RlOg0KPj4+Pj4gT24gNy8xMy8yMiAyOjE4IEFNLCBKYW4gQmV1bGlj aCB3cm90ZToNCj4+Pj4+PiBPbiAxMy4wNy4yMDIyIDAzOjM2LCBDaHVjayBabXVkemluc2tp IHdyb3RlOg0KPj4+Pj4+PiB2MjogKkFkZCBmb3JjZV9wYXRfZGlzYWJsZWQgdmFyaWFibGUg dG8gZml4ICJub3BhdCIgb24gWGVuIFBWIChKYW4gQmV1bGljaCkNCj4+Pj4+Pj4gICAgICAq QWRkIHRoZSBuZWNlc3NhcnkgY29kZSB0byBpbmNvcnBvcmF0ZSB0aGUgIm5vcGF0IiBmaXgN Cj4+Pj4+Pj4gICAgICAqdm9pZCBpbml0X2NhY2hlX21vZGVzKHZvaWQpIC0+IHZvaWQgX19p bml0IGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4+Pj4+Pj4gICAgICAqQWRkIEphbiBCZXVs aWNoIGFzIENvLWRldmVsb3BlciAoSmFuIGhhcyBub3Qgc2lnbmVkIG9mZiB5ZXQpDQo+Pj4+ Pj4+ICAgICAgKkV4cGFuZCB0aGUgY29tbWl0IG1lc3NhZ2UgdG8gaW5jbHVkZSByZWxldmFu dCBwYXJ0cyBvZiB0aGUgY29tbWl0DQo+Pj4+Pj4+ICAgICAgIG1lc3NhZ2Ugb2YgSmFuIEJl dWxpY2gncyBwcm9wb3NlZCBwYXRjaCBmb3IgdGhpcyBwcm9ibGVtDQo+Pj4+Pj4+ICAgICAg KkZpeCAnZWxzZSBpZiAuLi4geycgcGxhY2VtZW50IGFuZCBpbmRlbnRhdGlvbg0KPj4+Pj4+ PiAgICAgICpSZW1vdmUgaW5kaWNhdGlvbiB0aGUgYmFja3BvcnQgdG8gc3RhYmxlIGJyYW5j aGVzIGlzIG9ubHkgYmFjayB0byA1LjE3LnkNCj4+Pj4+Pj4NCj4+Pj4+Pj4gSSB0aGluayB0 aGVzZSBjaGFuZ2VzIGFkZHJlc3MgYWxsIHRoZSBjb21tZW50cyBvbiB0aGUgb3JpZ2luYWwg cGF0Y2gNCj4+Pj4+Pj4NCj4+Pj4+Pj4gSSBhZGRlZCBKYW4gQmV1bGljaCBhcyBhIENvLWRl dmVsb3BlciBiZWNhdXNlIEp1ZXJnZW4gR3Jvc3MgYXNrZWQgbWUgdG8NCj4+Pj4+Pj4gaW5j bHVkZSBKYW4ncyBpZGVhIGZvciBmaXhpbmcgIm5vcGF0IiB0aGF0IHdhcyBtaXNzaW5nIGZy b20gdGhlIGZpcnN0DQo+Pj4+Pj4+IHZlcnNpb24gb2YgdGhlIHBhdGNoLg0KPj4+Pj4+DQo+ Pj4+Pj4gWW91J3ZlIHN1ZmZpY2llbnRseSBhbHRlcmVkIHRoaXMgY2hhbmdlIHRvIGNsZWFy bHkgbm8gbG9uZ2VyIHdhbnQgbXkNCj4+Pj4+PiBTLW8tYjsgdW5mb3J0dW5hdGVseSBpbiBm YWN0IEkgdGhpbmsgeW91IGJyb2tlIHRoaW5nczoNCj4+Pj4+DQo+Pj4+PiBXZWxsLCBJIGhv cGUgd2UgY2FuIGNvbWUgdG8gYW4gYWdyZWVtZW50IHNvIEkgaGF2ZQ0KPj4+Pj4geW91ciBT LW8tYi4gQnV0IHRoYXQgd291bGQgcHJvYmFibHkgcmVxdWlyZSBtZSB0byByZW1vdmUNCj4+ Pj4+IEp1ZXJnZW4ncyBSLWIuDQo+Pj4+Pg0KPj4+Pj4+PiBAQCAtMjkyLDcgKzI5NCw3IEBA IHZvaWQgaW5pdF9jYWNoZV9tb2Rlcyh2b2lkKQ0KPj4+Pj4+PiAgIAkJcmRtc3JsKE1TUl9J QTMyX0NSX1BBVCwgcGF0KTsNCj4+Pj4+Pj4gICAJfQ0KPj4+Pj4+PiAgIA0KPj4+Pj4+PiAt CWlmICghcGF0KSB7DQo+Pj4+Pj4+ICsJaWYgKCFwYXQgfHwgcGF0X2ZvcmNlX2Rpc2FibGVk KSB7DQo+Pj4+Pj4NCj4+Pj4+PiBCeSBjaGVja2luZyB0aGUgbmV3IHZhcmlhYmxlIGhlcmUg Li4uDQo+Pj4+Pj4NCj4+Pj4+Pj4gICAJCS8qDQo+Pj4+Pj4+ICAgCQkgKiBObyBQQVQuIEVt dWxhdGUgdGhlIFBBVCB0YWJsZSB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSB0d28NCj4+Pj4+ Pj4gICAJCSAqIGNhY2hlIGJpdHMsIFBXVCAoV3JpdGUgVGhyb3VnaCkgYW5kIFBDRCAoQ2Fj aGUgRGlzYWJsZSkuDQo+Pj4+Pj4+IEBAIC0zMTMsNiArMzE1LDE2IEBAIHZvaWQgaW5pdF9j YWNoZV9tb2Rlcyh2b2lkKQ0KPj4+Pj4+PiAgIAkJICovDQo+Pj4+Pj4+ICAgCQlwYXQgPSBQ QVQoMCwgV0IpIHwgUEFUKDEsIFdUKSB8IFBBVCgyLCBVQ19NSU5VUykgfCBQQVQoMywgVUMp IHwNCj4+Pj4+Pj4gICAJCSAgICAgIFBBVCg0LCBXQikgfCBQQVQoNSwgV1QpIHwgUEFUKDYs IFVDX01JTlVTKSB8IFBBVCg3LCBVQyk7DQo+Pj4+Pj4NCj4+Pj4+PiAuLi4geW91IHB1dCBp biBwbGFjZSBhIHNvZnR3YXJlIHZpZXcgd2hpY2ggZG9lc24ndCBtYXRjaCBoYXJkd2FyZS4g SQ0KPj4+Pj4+IGNvbnRpbnVlIHRvIHRoaW5rIHRoYXQgLi4uDQo+Pj4+Pj4NCj4+Pj4+Pj4g Kwl9IGVsc2UgaWYgKCFwYXRfYnBfZW5hYmxlZCkgew0KPj4+Pj4+DQo+Pj4+Pj4gLi4uIHRo ZSB2YXJpYWJsZSB3YW50cyBjaGVja2luZyBoZXJlIGluc3RlYWQgKGF0IHdoaWNoIHBvaW50 LCB5ZXMsDQo+Pj4+Pj4gdGhpcyBjb21lcyBxdWl0ZSBjbG9zZSB0byBzaW1wbHkgYmVpbmcg YSB2MiBvZiBteSBvcmlnaW5hbCBwYXRjaCkuDQo+Pj4+Pj4NCj4+Pj4+PiBCeSB1c2luZyAh cGF0X2JwX2VuYWJsZWQgaGVyZSB5b3UgYWN0dWFsbHkgYnJvYWRlbiB3aGVyZSB0aGUgY2hh bmdlDQo+Pj4+Pj4gd291bGQgdGFrZSBlZmZlY3QuIElpcmMgQm9yaXMgaGFkIGFza2VkIHRv IG5hcnJvdyB0aGluZ3MgKGJlc2lkZXMNCj4+Pj4+PiB2b2ljaW5nIG9wcG9zaXRpb24gdG8g dGhpcyBhcHByb2FjaCBhbHRvZ2V0aGVyKS4gRXZlbiB3aXRob3V0IHRoYXQNCj4+Pj4+PiBy ZXF1ZXN0IEkgd29uZGVyIHdoZXRoZXIgeW91IGFyZW4ndCBnb2luZyB0byBmYXIgd2l0aCB0 aGlzLg0KPj4+Pj4+DQo+Pj4+Pj4gSmFuDQo+Pj4+Pg0KPj4+Pj4gSSB0aG91Z2h0IGFib3V0 IGNoZWNraW5nIGZvciB0aGUgYWRtaW5pc3RyYXRvcidzICJub3BhdCINCj4+Pj4+IHNldHRp bmcgd2hlcmUgeW91IHN1Z2dlc3Qgd2hpY2ggd291bGQgbGltaXQgdGhlIGVmZmVjdA0KPj4+ Pj4gb2YgIm5vcGF0IiB0byBub3QgcmVwb3J0aW5nIFBBVCBhcyBlbmFibGVkIHRvIGRldmlj ZQ0KPj4+Pj4gZHJpdmVycyB3aG8gcXVlcnkgZm9yIFBBVCBhdmFpbGFiaWxpdHkgdXNpbmcg cGF0X2VuYWJsZWQoKS4NCj4+Pj4+IFRoZSBtYWluIHJlYXNvbiBJIGRpZCBub3QgZG8gdGhh dCBpcyB0aGF0IGR1ZSB0byB0aGUgZmFjdA0KPj4+Pj4gdGhhdCB3ZSBjYW5ub3Qgd3JpdGUg dG8gdGhlIFBBVCBNU1IsIHdlIGNhbm5vdCByZWFsbHkNCj4+Pj4+IGRpc2FibGUgUEFULiBC dXQgd2UgY29tZSBjbG9zZXIgdG8gcmVzcGVjdGluZyB0aGUgd2lzaGVzDQo+Pj4+PiBvZiB0 aGUgYWRtaW5pc3RyYXRvciBieSBjb25maWd1cmluZyB0aGUgY2FjaGluZyBtb2RlcyBhcw0K Pj4+Pj4gaWYgUEFUIGlzIGFjdHVhbGx5IGRpc2FibGVkIGJ5IHRoZSBoYXJkd2FyZSBvciBm aXJtd2FyZQ0KPj4+Pj4gd2hlbiBpbiBmYWN0IGl0IGlzIG5vdC4NCj4+Pj4+DQo+Pj4+PiBX aGF0IHdvdWxkIHlvdSBwcm9wb3NlIGxvZ2dpbmcgYXMgYSBtZXNzYWdlIHdoZW4NCj4+Pj4+ IHdlIHJlcG9ydCBQQVQgYXMgZGlzYWJsZWQgdmlhIHBhdF9lbmFibGVkKCk/IFRoZSBtYWlu DQo+Pj4+PiByZWFzb24gSSBkaWQgbm90IGNob29zZSB0byBjaGVjayB0aGUgbmV3IHZhcmlh YmxlIGluIHRoZQ0KPj4+Pj4gbmV3ICdlbHNlIGlmJyBibG9jayBpcyB0aGF0IEkgY291bGQg bm90IGZpZ3VyZSBvdXQgd2hhdCB0bw0KPj4+Pj4gdGVsbCB0aGUgYWRtaW5pc3RyYXRvciBp biB0aGF0IGNhc2UuIEkgdGhpbmsgd2Ugd291bGQgaGF2ZQ0KPj4+Pj4gdG8gbG9nIHNvbWV0 aGluZyBsaWtlLCAibm9wYXQgaXMgc2V0LCBidXQgd2UgY2Fubm90IGRpc2FibGUNCj4+Pj4+ IFBBVCwgZG9pbmcgb3VyIGJlc3QgdG8gZGlzYWJsZSBQQVQgYnkgbm90IHJlcG9ydGluZyBQ QVQNCj4+Pj4+IGFzIGVuYWJsZWQgdmlhIHBhdF9lbmFibGVkKCksIGJ1dCB0aGF0IGRvZXMg bm90IGd1YXJhbnRlZQ0KPj4+Pj4gdGhhdCBrZXJuZWwgZHJpdmVycyBhbmQgY29tcG9uZW50 cyBjYW5ub3QgdXNlIFBBVCBpZiB0aGV5DQo+Pj4+PiBxdWVyeSBmb3IgUEFUIHN1cHBvcnQg dXNpbmcgYm9vdF9jcHVfaGFzKFg4Nl9GRUFUVVJFX1BBVCkNCj4+Pj4+IGluc3RlYWQgb2Yg cGF0X2VuYWJsZWQoKS4iIEhvd2V2ZXIsIEkgYWNrbm93bGVkZ2UgV0MgbWFwcGluZ3MNCj4+ Pj4+IHdvdWxkIHN0aWxsIGJlIGRpc2FibGVkIGJlY2F1c2UgYXJjaF9jYW5fcGNpX21tYXBf d2MoKSB3aWxsDQo+Pj4+PiBiZSBmYWxzZSBpZiBwYXRfZW5hYmxlZCgpIGlzIGZhbHNlLg0K Pj4+Pj4NCj4+Pj4+IFBlcmhhcHMgd2UgYWxzbyBuZWVkIHRvIGxvZyBzb21ldGhpbmcgaWYg d2Uga2VlcCB0aGUNCj4+Pj4+IGNoZWNrIGZvciAibm9wYXQiIHdoZXJlIEkgcGxhY2VkIGl0 LiBXZSBjb3VsZCBzYXkgc29tZXRoaW5nDQo+Pj4+PiBsaWtlOiAibm9wYXQgaXMgc2V0LCBi dXQgd2UgY2Fubm90IGRpc2FibGUgaGFyZHdhcmUvZmlybXdhcmUNCj4+Pj4+IFBBVCBzdXBw b3J0LCBzbyB3ZSBhcmUgZW11bGF0aW5nIGFzIGlmIHRoZXJlIGlzIG5vIFBBVCBzdXBwb3J0 DQo+Pj4+PiB3aGljaCBwdXRzIGluIHBsYWNlIGEgc29mdHdhcmUgdmlldyB0aGF0IGRvZXMg bm90IG1hdGNoDQo+Pj4+PiBoYXJkd2FyZS4iDQo+Pj4+Pg0KPj4+Pj4gTm8gbWF0dGVyIHdo YXQsIGJlY2F1c2Ugd2UgY2Fubm90IHdyaXRlIHRvIFBBVCBNU1IgaW4NCj4+Pj4+IHRoZSBY ZW4gUFYgY2FzZSwgd2UgcHJvYmFibHkgbmVlZCB0byBsb2cgc29tZXRoaW5nIHRvDQo+Pj4+ PiBleHBsYWluIHRoZSBwcm9ibGVtcyBhc3NvY2lhdGVkIHdpdGggdHJ5aW5nIHRvIGhvbm9y IHRoZQ0KPj4+Pj4gYWRtaW5pc3RyYXRvcidzIHJlcXVlc3QuIEFsc28sIHdoYXQgbG9nIGxl dmVsIHNob3VsZCBpdCBiZS4NCj4+Pj4+IFNob3VsZCBpdCBiZSBhIHByX3dhcm4gaW5zdGVh ZCBvZiBhIHByX2luZm8/DQo+Pj4+DQo+Pj4+IEknbSBhZnJhaWQgSSdtIHRoZSB3cm9uZyBv bmUgdG8gYW5zd2VyIGxvZ2dpbmcgcXVlc3Rpb25zLiBBcyB5b3UNCj4+Pj4gY2FuIHNlZSBm cm9tIG15IG9yaWdpbmFsIHBhdGNoLCBJIGRpZG4ndCBhZGQgYW55IG5ldyBsb2dnaW5nIChh bmQNCj4+Pj4gbm8gYWRkaXRpb24gd2FzIHJlcXVlc3RlZCBpbiB0aGUgY29tbWVudHMgdGhh dCBJIGhhdmUgZ290KS4gSSBhbHNvDQo+Pj4+IGRvbid0IHRoaW5rICJub3BhdCIgaGFzIGV2 ZXIgbWVhbnQgImRpc2FibGUgUEFUIiwgYXMgdGhlIGZlYXR1cmUNCj4+Pj4gaXMgZWl0aGVy IHRoZXJlIG9yIG5vdC4gSW5zdGVhZCBJIHRoaW5rIGl0IHdhcyBhbHdheXMgc2VlbiBhcw0K Pj4+PiAiZGlzYWJsZSBmaWRkbGluZyB3aXRoIFBBVCIsIHdoaWNoIGJ5IGltcGxpY2F0aW9u IG1lYW5zIHVzaW5nDQo+Pj4+IHdoYXRldmVyIGlzIHRoZXJlIChpZiB0aGUgZmVhdHVyZSAv IE1TUiBpdHNlbGYgaXMgYXZhaWxhYmxlKS4NCj4+Pg0KPj4+IElJUkMsIEkgZG8gdGhpbmsg SSBtZW50aW9uZWQgaW4gdGhlIGNvbW1lbnRzIG9uIHlvdXIgcGF0Y2ggdGhhdA0KPj4+IGl0 IHdvdWxkIGJlIHByZWZlcmFibGUgdG8gbWVudGlvbiBpbiB0aGUgY29tbWl0IG1lc3NhZ2Ug dGhhdA0KPj4+IHlvdXIgcGF0Y2ggd291bGQgY2hhbmdlIHRoZSBjdXJyZW50IGJlaGF2aW9y IG9mICJub3BhdCIgb24NCj4+PiBYZW4uIFRoZSBxdWVzdGlvbiBpcywgaG93IG11Y2ggZG8g d2Ugd2FudCB0byBjaGFuZ2UgdGhlDQo+Pj4gY3VycmVudCBiZWhhdmlvciBvZiAibm9wYXQi IG9uIFhlbi4gSSB0aGluayBpZiB3ZSBoYXZlIHRvIGNoYW5nZQ0KPj4+IHRoZSBjdXJyZW50 IGJlaGF2aW9yIG9mICJub3BhdCIgb24gWGVuIGFuZCBpZiB3ZSBhcmUgZ29pbmcNCj4+PiB0 byBwcm9wYWdhdGUgdGhhdCBjaGFuZ2UgdG8gYWxsIGN1cnJlbnQgc3RhYmxlIGJyYW5jaGVz IGFsbA0KPj4+IHRoZSB3YXkgYmFjayB0byA0LjkueSwsIHdlIGJldHRlciBtYWtlIGEgbG90 IG9mIG5vaXNlIGFib3V0DQo+Pj4gd2hhdCB3ZSBhcmUgZG9pbmcgaGVyZS4NCj4+Pg0KPj4+ IENodWNrDQo+Pg0KPj4gQW5kIGluIGFkZGl0aW9uLCBpZiB3ZSBhcmUgZ29pbmcgdG8gYmFj a3BvcnQgdGhpcyBwYXRjaCB0bw0KPj4gYWxsIGN1cnJlbnQgc3RhYmxlIGJyYW5jaGVzLCB3 ZSBiZXR0ZXIgaGF2ZSBhIHJlYWxseSwgcmVhbGx5LA0KPj4gZ29vZCByZWFzb24gZm9yIGNo YW5naW5nIHRoZSBiZWhhdmlvciBvZiAibm9wYXQiIG9uIFhlbi4NCj4+DQo+PiBEb2VzIHN1 Y2ggYSByZWFzb24gZXhpc3Q/DQo+IA0KPiBXZWxsLCB0aGUgc2ltcGxlIHJlYXNvbiBpczog SXQgZG9lc24ndCB3b3JrIHRoZSBzYW1lIHdheSB1bmRlciBYZW4NCj4gYW5kIG5vbi1YZW4g KGluIHR1cm4gYmVjYXVzZSwgYmVmb3JlIG15IHBhdGNoIG9yIHdoYXRldmVyIGVxdWl2YWxl bnQNCj4gd29yaywgdGhpbmdzIGRvbid0IHdvcmsgcHJvcGVybHkgYW55d2F5LCBQQVQtd2lz ZSkuIFlldCBpdCBkZWZpbml0ZWx5DQo+IG91Z2h0IHRvIGJlaGF2ZSB0aGUgc2FtZSBldmVy eXdoZXJlLCBpbW8uDQoNClRoZXJlIGlzIERvY3VtZW50YXRpb24veDg2L3BhdC5yc3Qgd2hp Y2ggcmF0aGVyIGNsZWFybHkgc3RhdGVzLCBob3cNCiJub3BhdCIgaXMgbWVhbnQgdG8gd29y ay4gSXQgc2hvdWxkIG5vdCBjaGFuZ2UgdGhlIGNvbnRlbnRzIG9mIHRoZQ0KUEFUIE1TUiBh bmQga2VlcCBpdCBqdXN0IGFzIGl0IHdhcyBzZXQgYXQgYm9vdCB0aW1lICh0aGUgZG9jIHRh bGtzDQphYm91dCB0aGUgIkJJT1MiIHNldHRpbmcgb2YgdGhlIE1TUiwgYW5kIEkgZ3Vlc3Mg aW4gdGhlIFhlbiBjYXNlDQp0aGUgaHlwZXJ2aXNvciBpcyBraW5kIG9mIGFjdGluZyBhcyB0 aGUgQklPUykuDQoNClRoZSBxdWVzdGlvbiBpcywgd2hldGhlciAibm9wYXQiIG5lZWRzIHRv IGJlIHRyYW5zbGF0ZWQgdG8NCnBhdF9lbmFibGVkKCkgcmV0dXJuaW5nICJmYWxzZSIuIEkn dmUgZm91bmQgZXhhY3RseSBvbmUgY2FzZSB3aGVyZQ0KIm5vcGF0IiBzZWVtcyB0byBiZSBy ZXF1aXJlZCBmb3IgYSBkcml2ZXIgdG8gd29yayBjb3JyZWN0bHksIGJ1dA0KdGhpcyBkcml2 ZXIgKGRyaXZlcnMvbWVkaWEvcGNpL2l2dHYvaXZ0dmZiLmMpIHNlZW1zIHRvIHJlbHkgb24N Ck1UUlIgYXZhaWxhYmlsaXR5LCB3aGljaCBpc24ndCBzdXBwb3J0ZWQgaW4gWGVuIFBWIGd1 ZXN0cy4NCg0KT3RoZXIgdGhhbiB0aGF0IHRoZSAibm9wYXQiIG9wdGlvbiBzZWVtcyB0byBi ZSBhIGNoaWNrZW4gYml0IGZyb20NCnRoZSBlYXJseSBkYXlzIG9mIFBBVCB1c2FnZSwgd2hp Y2ggcHJvYmFibHkgaXNuJ3QgcmVhbGx5IG5lZWRlZCBhbnkNCm1vcmUuIFNvIEkgd291bGRu J3QgYmUgd29ycmllZCB0byBkcm9wICJub3BhdCIgaGF2aW5nIGFueSBlZmZlY3QNCm9uIHRo ZSBzeXN0ZW0gaW4gWGVuIFBWIGd1ZXN0cy4NCg0KT24gYmFyZSBtZXRhbCBpdCBzaG91bGQg c3RpbGwgd29yaywgb2YgY291cnNlLCBpZiBvbmx5IGZvciBzYWlkDQpkcml2ZXIuDQoNCj4+ IE9yIHBlcmhhcHMsIEp1ZXJnZW4sIGNvdWxkIHlvdQ0KPj4gYWNjZXB0IGEgdjMgb2YgbXkg cGF0Y2ggdGhhdCBkb2VzIG5vdCBuZWVkIHRvIGRlY2lkZQ0KPj4gaG93IHRvIGJhY2twb3J0 IHRoZSBjaGFuZ2UgdG8gIm5vcGF0IiB0byB0aGUgc3RhYmxlIGJyYW5jaGVzDQo+PiB0aGF0 IGFyZSBhZmZlY3RlZCBieSB0aGUgY3VycmVudCBiZWhhdmlvciBvZiAibm9wYXQiIG9uIFhl bj8NCg0KTm90ZSB0aGF0IGl0IGlzIG5vdCBtZSB0byBhY2NlcHQgc3VjaCBhIHBhdGNoLCB0 aGlzIHdvdWxkIGJlIG9uZQ0Kb2YgdGhlIHg4NiBtYWludGFpbmVycyAoZS5nLiBCb3Jpcyku DQoNCg0KSnVlcmdlbg0K --------------fDVm7r2YKWmsXPXC84AR5mO6 Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------fDVm7r2YKWmsXPXC84AR5mO6-- --------------yfXlC0JibNNYMYRQRYhySi2z-- --------------eAnzHIkgnyu5Zz2tML6wHnxq Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLOzIwFAwAAAAAACgkQsN6d1ii/Ey/D rggAj385VrlW57TfBtu7McoBb3Kj0MU9yBGd+CQrlBSHTJfslyOBhg46flmlyue93FL/Cc7XMUH8 kPTZVTyCWzyTTAeuEc/MQNYEByQ/aYte9Vjrfa2IwScEpm05a87I+wNkbsDSmAyA8Ubbv6bFk3sI TGBg5IYRykS8xkDKPh7aLJwuaDfkVdjeKRHVSF6sR3hrfBRAzoKREPB9hZAInPWIz3XEk6HKr8ne PzTo1GktEIGQmtAOL/iQ+5L3YMr+pBjikAdXmzt9X1+H+xRBczdmfJOSwwEuddmKSf4gji2vd1pZ M0+5uwwNvFi4rOHGLT2HvVBeAMIMBJv6Gmtc6jqICQ== =/Bby -----END PGP SIGNATURE----- --------------eAnzHIkgnyu5Zz2tML6wHnxq-- From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:49:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:49:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366614.597555 (Exim 4.92) (envelope-from ) id 1oBcjy-0005Zg-0a; Wed, 13 Jul 2022 13:49:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366614.597555; Wed, 13 Jul 2022 13:49:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcjx-0005ZZ-U1; Wed, 13 Jul 2022 13:49:21 +0000 Received: by outflank-mailman (input) for mailman id 366614; Wed, 13 Jul 2022 13:49:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcjw-0005ZR-3q for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:49:20 +0000 Received: from sonic312-23.consmr.mail.gq1.yahoo.com (sonic312-23.consmr.mail.gq1.yahoo.com [98.137.69.204]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95b06e24-02b2-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 15:49:17 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 13:49:15 +0000 Received: by hermes--production-bf1-58957fb66f-88chf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 87132f46a4855ed798a0f1c8397b5495; Wed, 13 Jul 2022 13:49:11 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95b06e24-02b2-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657720155; bh=7gN2eO0nhM4u4WQBVoTr1S4htzfsOtgXWS/54zW1CGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=gMnJsCGyPYv9nYZ8E5KGWeRN0Fn7q3an/63OTkVV+Rvt2WnXgvKYHZMPI4ffzrC6eWIbAGEncTP7WyaFPlLZm47CiKh8/DlfRAyp9NCVVmttZ7N139+1T8peRCQhy4FSvvoBF/5NGpPl/nFpMZaplAzFgpbkKrstO0knfefFGaC1LTONJPzjD14jnUCBrYBigziriXm7nhLtKnix5GFN5gpTjGYppZcoMw6zTKDyZGAJhKB8smx3lE60iovKGJrJSNp3FlfupxZGG906VWtTGZ34BDpDbhiZXdLUuwOGHuyhmKcJkbrMJkKQJoP3VD9ssT1B6419fgZUTdCzRiHL0w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657720155; bh=lx/Fltblve9A3NgLKQ1x8D7S21NiR6VyzfPZIw3Ye3S=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=rjNZtnBuSQpVmf2J0Unvc9P4GcQUFb/FvTYbYGYJbya8K8p5EjK7acH5v8mWqpLuCQG2/aabfuNe2IZtoBaYpPG+upX4eBsS6DQhPRnyo9pt2HXJl9mmd0GK6hcy/5y4okXY8t2V+AaOBXhDY1niwc4wfXskN6R9KTiQCq7MCOreRZBhXY0Br6QpkFQxz1ilQjY+5Dj8I4AzS8W6iesXtjcxlS1XtmH5HnxKw7pUcO8gPprlHCGcZKOIIdvqvOUPXpk+OE2Pe+bMLjsIzZ1G8nQX1PMlC1oj9jfFM7LvoTUn0+OyWUg50JnbtCWT9usgHHX+HlilISB3BvoZKZJj+Q== X-YMail-OSG: GtMdftgVM1m1ltD7b2xLPsZ9cFn5Cp8KJrCorLRXNd0NFrsD2VNOU2W9CywnHhT kj5kuT9B6e9Pmeh0Q8BkYQtZxi5NW9geVncsWMP9f3cQS1O_JrKtagNelbPubX2axK.IBCGnvaX0 LuAD5vZbaMvo7oD_e0kFHVBDNzNlWGDPw.Y6G2LIKV3BVpWGJSZsYHyQSofPvcu.tACdoogVmRyb wENEAam8YYpm1TxoORbHbiZROrWZxJW3plCWUYTuRN0YCQE_LaCz0zMY.5fhDiBCpjAZZufHWsh2 K1MqKRxPFXZauUY5HJKG2EtXb3x.RiJ.P.aQ4HeAVC7avgeMeIBIovxc.kPEYyJYhZ1xQQFn_hhd HkTKzuMG9dCPWx65UEehwWI30Abg4ebTCoyEIIJIwpIaC12JRCAF8dTuOuEPB8SRG4g.uz9i3S1W uqsg0Gkg27GP9qwdJBZnNlLMQ1Txp1SNxV75Fq3E.mrj_O9aLeaJnc6AVP0oCZDgLgis3KdzGt1Y LI9ov5BhlmBTG0NCXm81Kp7k4nuH0RjnYTCIIfxSexHjKwKEhI2X.w2KCeO5n9wVOS4tA.LSG_R4 deQyUwDFnRtWo02_XaUbtKtMnisPdcacGH07v1msyX2tUK5M9xTJucxKL9AdCGbRMUr5BrCmBszt Vr3GgNaHJwyPfP54LGa9r84hxwkQ.bW9Vnhz3mC9NISOggtogOrXjP2Xl4wk12jWZvM3Ivybc98n 9Y_78t3RU4LLaGheyTmNcitdjUNl.RQ6K0tDf8I4dBiGiSLOICYvEXAO9E.nQGrNfxfFOuOWzFHL dU7S9Vj1vViIQ4clbeqdXxkU2r9b_eRRQOhJAFtWfZk7l5zA2CkJs5JJjE5skqA_XFOgAfLONkbS Nw_GRVND52TDRb2yvIKXjNHxodK2Bte915rwiToXm5vK4iRjdGFdapuahUmwMj.2i_Rl576LOR8I s3FZzRA_FsPHXGwQYd0Ek4k7B91MAHOkVHZPnKhtNOLhl0opFXUuehVBmVF.DN0_1Gr2FpJ9xEV9 B2Gm1F59x70ZNzN70upvUGAFxaEVWG_jfTsBnyfiHZSSalmojsw35ZNVb6kMFTNnjr9o6MpcvNYn Dkb18snhRfWUnxEZdgLM7oJmqcvKN1cyPQAyL6_IcBZM5lwzine7bJ99gEKsfoH7Hz.mdRa6.kOI x6VbQS1FAid.OaTv89Od169BlBtZfDS3f328HL0PA3HhP8XJDrOtViOpiCLrXl3RXxbU2WRkwaQK sXCuSbKBZR90f_AQgjjDPlMbb7nWuomZ65Q3TTIWBid9NiVYpvVGKugnbL6lSd0Bx1dy.wRuCs5M soA5O_GNb5iDxYvWauCjCRCvZaD6XnYRtPOZNbznqks7XQStulOv4rG7BraPYmYi417rlh1UTPGB cFA2y0DIyTnnZUXP78FuwzEYVuyRU4uSdivkB6q2Le4oOboblXiKgx.EjMr3tjAoS2jFOFDE4.BG kodCK_.XJlOmswrexW5cZvmAUfmL6UjR4axVC9OMdyx0m0GcVdXxw_4easBWPzN4s_VVV8zOlBj9 SVoY3BQ8t_UV4VaSKU1NFymJcQxy9R5PVfrgEiwBF5l_PjH0DYQJuw6.NaZHRAbfhHG18J6Y8TTD XjkWb5C9ol69N.I8003Do7KauWv4Zqo.OE1zbIDdIlWSnYfW6bxAkzXqjAiCQ3RitSdxDeDG10eO Gikdbh.K396qq.hJweDK9zpMTizKiYY3pAYabIjw6YJRd4wzaYSf78tF_Pn1vraNRY2.idOJ413L xa4bv1..PBYw.Dc1fjnZcn90HIW7No1l8nwHNoQI_pQzYVNLXJ1SjiGOBUAzxd.uPWZjYr0ojFbg SNuor3PSDccDcWDrc2Gd7eQpBYgN_mJ.ImmowAkMTmVnneTpMra6oPImWqZpAm0.FXPGmFN1ik3K kbcJYOLr7bdBtbyma.bdW5mbCBvqqQqyxRJMFGIvCA4.RjZkXyZxl6hGhpqn7nI9ZdqrAPqfzNLm X04wnSNDW0B4znuI8bLvobhzUxNNntsvqOn6hcNM39etVS8z_VgSKLtButR6Za654wm8FY7LUaOI DIH.VrDPn7hHlInc.tDnoDII0LGeExQGIjEv6Z52b1Al269wPv4pPCuUtctVQNRbOcTM8cAZXVFU 4XZwHQLS1xT5y6QAVKOL_UFHUCLMTa2SdDDCrnpCD8qnxdKjNSyv0ReL3QI2stEDzKct.u.yKPqq MIMY- X-Sonic-MF: Message-ID: <62e32913-cfcb-e0b0-2bbe-75cc8597951d@netscape.net> Date: Wed, 13 Jul 2022 09:49:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Juergen Gross , "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> From: Chuck Zmudzinski In-Reply-To: <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6824 On 7/13/2022 9:34 AM, Jan Beulich wrote: > On 13.07.2022 13:10, Chuck Zmudzinski wrote: > > On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > >> On 7/13/2022 5:09 AM, Jan Beulich wrote: > >>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: > >>>> On 7/13/22 2:18 AM, Jan Beulich wrote: > >>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > >>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>>>>> *Add the necessary code to incorporate the "nopat" fix > >>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>>>>> *Expand the commit message to include relevant parts of the commit > >>>>>> message of Jan Beulich's proposed patch for this problem > >>>>>> *Fix 'else if ... {' placement and indentation > >>>>>> *Remove indication the backport to stable branches is only back to 5.17.y > >>>>>> > >>>>>> I think these changes address all the comments on the original patch > >>>>>> > >>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>>>>> include Jan's idea for fixing "nopat" that was missing from the first > >>>>>> version of the patch. > >>>>> > >>>>> You've sufficiently altered this change to clearly no longer want my > >>>>> S-o-b; unfortunately in fact I think you broke things: > >>>> > >>>> Well, I hope we can come to an agreement so I have > >>>> your S-o-b. But that would probably require me to remove > >>>> Juergen's R-b. > >>>> > >>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>>>>> } > >>>>>> > >>>>>> - if (!pat) { > >>>>>> + if (!pat || pat_force_disabled) { > >>>>> > >>>>> By checking the new variable here ... > >>>>> > >>>>>> /* > >>>>>> * No PAT. Emulate the PAT table that corresponds to the two > >>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>>>>> */ > >>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>>> > >>>>> ... you put in place a software view which doesn't match hardware. I > >>>>> continue to think that ... > >>>>> > >>>>>> + } else if (!pat_bp_enabled) { > >>>>> > >>>>> ... the variable wants checking here instead (at which point, yes, > >>>>> this comes quite close to simply being a v2 of my original patch). > >>>>> > >>>>> By using !pat_bp_enabled here you actually broaden where the change > >>>>> would take effect. Iirc Boris had asked to narrow things (besides > >>>>> voicing opposition to this approach altogether). Even without that > >>>>> request I wonder whether you aren't going to far with this. > >>>>> > >>>>> Jan > >>>> > >>>> I thought about checking for the administrator's "nopat" > >>>> setting where you suggest which would limit the effect > >>>> of "nopat" to not reporting PAT as enabled to device > >>>> drivers who query for PAT availability using pat_enabled(). > >>>> The main reason I did not do that is that due to the fact > >>>> that we cannot write to the PAT MSR, we cannot really > >>>> disable PAT. But we come closer to respecting the wishes > >>>> of the administrator by configuring the caching modes as > >>>> if PAT is actually disabled by the hardware or firmware > >>>> when in fact it is not. > >>>> > >>>> What would you propose logging as a message when > >>>> we report PAT as disabled via pat_enabled()? The main > >>>> reason I did not choose to check the new variable in the > >>>> new 'else if' block is that I could not figure out what to > >>>> tell the administrator in that case. I think we would have > >>>> to log something like, "nopat is set, but we cannot disable > >>>> PAT, doing our best to disable PAT by not reporting PAT > >>>> as enabled via pat_enabled(), but that does not guarantee > >>>> that kernel drivers and components cannot use PAT if they > >>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > >>>> instead of pat_enabled()." However, I acknowledge WC mappings > >>>> would still be disabled because arch_can_pci_mmap_wc() will > >>>> be false if pat_enabled() is false. > >>>> > >>>> Perhaps we also need to log something if we keep the > >>>> check for "nopat" where I placed it. We could say something > >>>> like: "nopat is set, but we cannot disable hardware/firmware > >>>> PAT support, so we are emulating as if there is no PAT support > >>>> which puts in place a software view that does not match > >>>> hardware." > >>>> > >>>> No matter what, because we cannot write to PAT MSR in > >>>> the Xen PV case, we probably need to log something to > >>>> explain the problems associated with trying to honor the > >>>> administrator's request. Also, what log level should it be. > >>>> Should it be a pr_warn instead of a pr_info? > >>> > >>> I'm afraid I'm the wrong one to answer logging questions. As you > >>> can see from my original patch, I didn't add any new logging (and > >>> no addition was requested in the comments that I have got). I also > >>> don't think "nopat" has ever meant "disable PAT", as the feature > >>> is either there or not. Instead I think it was always seen as > >>> "disable fiddling with PAT", which by implication means using > >>> whatever is there (if the feature / MSR itself is available). > >> > >> IIRC, I do think I mentioned in the comments on your patch that > >> it would be preferable to mention in the commit message that > >> your patch would change the current behavior of "nopat" on > >> Xen. The question is, how much do we want to change the > >> current behavior of "nopat" on Xen. I think if we have to change > >> the current behavior of "nopat" on Xen and if we are going > >> to propagate that change to all current stable branches all > >> the way back to 4.9.y,, we better make a lot of noise about > >> what we are doing here. > >> > >> Chuck > > > > And in addition, if we are going to backport this patch to > > all current stable branches, we better have a really, really, > > good reason for changing the behavior of "nopat" on Xen. > > > > Does such a reason exist? > > Well, the simple reason is: It doesn't work the same way under Xen > and non-Xen (in turn because, before my patch or whatever equivalent > work, things don't work properly anyway, PAT-wise). Yet it definitely > ought to behave the same everywhere, imo. > > Jan IOW, you are saying PAT has been broken on Xen for a long time, and it is necessary to fix it now not only on master, but also on all the stable branches. Why is it necessary to do it on all the stable branches? The only valid reason I can think of is a zero-day exploit that can only be mitigated by really disabling PAT on Xen. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:49:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:49:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366618.597566 (Exim 4.92) (envelope-from ) id 1oBckR-00063u-AD; Wed, 13 Jul 2022 13:49:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366618.597566; Wed, 13 Jul 2022 13:49:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBckR-00063n-6s; Wed, 13 Jul 2022 13:49:51 +0000 Received: by outflank-mailman (input) for mailman id 366618; Wed, 13 Jul 2022 13:49:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBckQ-00063d-Lg for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:49:50 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20074.outbound.protection.outlook.com [40.107.2.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9a2d51d-02b2-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 15:49:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB3296.eurprd04.prod.outlook.com (2603:10a6:802:7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 13:49:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 13:49:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9a2d51d-02b2-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jiU/gbsZiGy8TECf490Y2K0kmGihnR3vtORpQ2h085lCCYriJclyhzIBeUQd53xQVg5sNv2T8vphMx4eerHQ9RkylO98L1eEgJx0gYL322s4cuRtFj7rjtb1cWD1fbrBey+zX7+8qUCAEKOWLBlqw5FPbBmz5cqwcJnWWCbNI5fmeoshUwsGgxXXPQVMaMyAkNR3cXOjFkJ5A2qc6RyBK53kC26c3CwK8cZzx12C7cKNENU/Zm1q6OdZ22ZIAayp7j68Akubn3NICXHI3RTCZaGoUo6XH1SBOkheuneiqlKoSnB2zFUjxzILFrmHHvislE39BVQI0BBJ9eATSxhjWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pt6GCQqUndHrZSAZoPpQIvL3exh5ep4oFxyEKMw/vWE=; b=DUrIcLtPm251Mm91m9L5mqzFn+9TsW+GBoUHlZ5HQsDh+RXsI1sja8umlNft00DmnZMoO+P2jpLVkfO4nxVSp/7GxnqwZYu77xDo8tjLVCj9wVFMiqT4sKlOew4VqjrOcFCKvEK2UkGrERnNwMNY6rAd5fnVRWj9WPsGj4wg5fnoJl9xKsvwrGAmlhwH5D81JmEQNqCClsfbCFnci2MHQUio22xOW1AQIW/8KCj1pB9EMpQYE6vkJalLJABtrtOh5uCrCSFumlK9uzgyCx9Wl82umROO6Uv0WLFZZfgOCq002Nwax6KzLJoS5337zQcXvc3TURKQNXl6wJYdvBlwDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pt6GCQqUndHrZSAZoPpQIvL3exh5ep4oFxyEKMw/vWE=; b=f1iosO5DOeIPAT9x4Yn5CgGvmKVAzthFgHO5Rv/T/nhay4Mi3etU2YAi2O8gNt8EPcYfjnfi2yk5sxcvjqC/lXdKSNOhbeZGRrTdjwkiCiqw/cwuUwwUdsNo2BF2vc/o9KEtiR3blB6rGlkkcMbXPDrlvKwEHrk4dGk3dCxc+w8IL81wvuNSfwaZx9o/3gaAQkdSZyKXLvXQoptcp4igi8/4r3KslSVzJOLoQ9tO7PYyzTmAzjOWLVrYaQXvsDvuEAxN4c6SFA004+g+qtnnyCMs0vTmQUpkHzPFBh64A92D3YwyR+qv3xVwDg7CVdzSUBLpgi8dJjhFZHrI3bGQkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6512f594-e16f-b280-f480-d7b51e32fc74@suse.com> Date: Wed, 13 Jul 2022 15:49:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 to common Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-7-wei.chen@arm.com> <357fc6ee-3014-4be9-9bf4-60669a4ca914@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0045.eurprd06.prod.outlook.com (2603:10a6:20b:463::30) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 92c1ce5d-e340-425a-97d9-08da64d68c98 X-MS-TrafficTypeDiagnostic: VI1PR04MB3296:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xNM3gm2hD1qTHek+lfeevukHJ1WHAJaDKYW99DkZMDGX+rKDdbJX1eQEtl4HQ8t/RGA/rj80bNcQfZn/kiaThSTY7B1RSf4rfYbfiKK1yWFsLeo/tStNaq8wroUZ7fnIZIqRyT3i6uazFZhmQe1ZLXo6IlijGHZLMMxmcVOXj3D4iZP+MsUn1/97mj5njVmqexaJxSEuWGbnP26ROMP9vsCYaG0/d27E5QvI3voiGIzy8hNFNeV51QMeYyCSLGWX/uYsj9ytiNEtIviZ1MBqOK5KFKEXXj4qULncAT6x8i44jkZFcGCbCMhl9udWIKHbBIFAI7z+bANKQPhNMkXHEo93auI3N/yRlR3vljJI69p5e7iBY3fk4wjtnK8CtlwazsoaGeXAs6VN9R9Erw0AhbWy3ZK8ymGomd2QxVNxccGgGHFkyhV1cd8YTQ7jjXvDmRpWamLVeZ7gorII7kTWrtoruWxfK2RpC+G5oFys/iEY3EDYi0V+hECB68AhyApiKozqvP8q5XLgai0HnEE7V06prIOK0tbRTFyxugHC+gAUA1rtwXqukEMM+wJ/SIYzrSfe+4qS00XENIyhvtW9KTrW5ABW8YD/eQSU8pQkkIQcXq1TykhDq8HGKmxUqVzyFex1up2gpzAhucVn4/axd557mJOpToX9hvGzuwCWIY+O7Rehak7iIVBh4jlrPRo6feMsR4De/dz2GfAmtCZkBUDFNZGc6f5bcxcXqcU9hlTdRQP/23z9HCQtjfXO+dJpb9zAiBoMigQXyB7X6C6TWB0S9eRvURyKnuM22QrXJWDatGFpkMehlZI5Rdtt9qZv/QeIcpry1N+G9Dr1L53GWXyKJPDt/MCymNxHJBiq+Ew= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(346002)(376002)(39860400002)(186003)(83380400001)(2616005)(36756003)(54906003)(66556008)(66946007)(316002)(66476007)(4326008)(8676002)(6862004)(8936002)(6512007)(478600001)(31686004)(41300700001)(53546011)(86362001)(6486002)(26005)(5660300002)(31696002)(2906002)(6506007)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0ppK3NhUHVtSFZzeEl3dFc3WitEOFJiVmlsbWM1QTVKVDdwVGpXTlZBV0ls?= =?utf-8?B?MDFuNGF0dG13UExxdXZzcS9EUEY1eGlWdFlSemt2NEhvWFBtMythaXlBbUpE?= =?utf-8?B?VVVKeFJQQkFXd1l4bW1ySDE3NFVycDdHQVVkL3UwZk5DTG1ISm5Nb1hsdDFW?= =?utf-8?B?TWZEalRBaHBWbG11MTJMRmZjd2xkQmZwNVJacmFqNk9INGQ1b1ozclo0d254?= =?utf-8?B?NjVNQVZveFdSTmpMVVpkSVNFUHc3MmxFZGIzUDkxcEhibExPa3VlR2o1MTJl?= =?utf-8?B?ekdSN01lK3N1eWJLMDRXM0JEWS9MSkg5R250VlNWRHZNTS9vcmQ5NXNtdm5k?= =?utf-8?B?VG1sQ1pqbmwrR3JGait5ZnZHc0FLVkZscEJJa0lyeFlRVEhjVTl0YUE2WHg3?= =?utf-8?B?S3hjYmNlcnBMeDlLNWFKU0h0Q3MyWDhJK2I4S0MrdUFhMFFhYXpUTHo3Z0Np?= =?utf-8?B?WGVIM1NRSmR2b0dBNEpxdlhjUDlWMm1heitwZjZJNWwxNk5qNURVYXByVEpU?= =?utf-8?B?TFJqUXMrTVJJOE5nbC9OOEFvYkpzcWdvL00vU0pQU3NnVTkraEh0TktBcm5z?= =?utf-8?B?Q3JYRkNEK1VNLzBUcW5aSVhuSCtvWDQ3Y3I4bWNnOVJGZGFIUmxZMGlXTDlJ?= =?utf-8?B?MXphQXRBdmYrcDFnQnpta01uRWZSeHFWVjlUbnQ4YTJudXlRbWJoZ25oOHJR?= =?utf-8?B?REMrZnhqa1JJYjJKc3BFSmVwMHpMSytLbHRzcHl5Y0NkVjk1bXhQSWdVejlw?= =?utf-8?B?Mnh1aGRsaTFtbHNZUnMvQ1FHZkI1Qkk2TFhjbzN0MVZnNEpCcTNZTUhkN3o3?= =?utf-8?B?eEZCUzl4VDN1VTdNeEUrcWJiNy9ETXBEeWlORFhHdXBhNlJCd2VYUUhEYkJo?= =?utf-8?B?S0Z0cTBvaTIvbnh1eWxNYUNVSVNlWTRmYzg0YVl6bjlObXJqZ0FOMzU1bnlU?= =?utf-8?B?OE5VRk5lZWs5SHRwMFJHeDNMU0FoemF4WVlaUkQxdkF1WG5tQ1FSY0ZFbGNj?= =?utf-8?B?a1BHamw3WnNwczVMSlhPL0xNd0x3LzUrdW83ZHBqeUc3WmpEU1hPWHhlOVU3?= =?utf-8?B?QjJUSXpRRzdLL25qRG8vOGxxckZtSlJmdVRXNjlGSEdoZVluYWtoMmZjcHE5?= =?utf-8?B?OE0wRHVjSWxJb0ZLakZSa2JYOTY1V0NGOGVJRElLYkpLOFpTZGUza0ZKSHRk?= =?utf-8?B?emlsdTNOVUdoeHRwUGtyOStyOU9ySGNiOXpuYWhJNUZRbGMxT0ROYmJUN3JK?= =?utf-8?B?ZTJkd29MekhKV0Y0UDFSZjZoOFBtcDE5WmY3bk5CNWVuNU5nZTZQRFRRTnVK?= =?utf-8?B?VjJGZXlDKzF0K3J0czRabHd0R0d4am9CU0dZQTVLTVd6V0pyS29KanRYT2Jq?= =?utf-8?B?bDNTcm1TNkFwVzM2c2hzODdkcE1LOXF3U3NuR3dBeVRGdEJmcGF3MENFSHlH?= =?utf-8?B?SlVXYXMzTnpJTmsxcjNUd21kWS9zTlNsVXJyeDR4NnpmNWE1TFE0NXBGSkdH?= =?utf-8?B?TUVMQXluMGY3M281YlBpRFlROHREaVBkSkZUOEZRdEoxcmpWZUlwazkxMTlZ?= =?utf-8?B?ZEZWaXdkMitzcUhHSWdyaVBOWmVDZEErYXVQSVc4UnF0M1p2SGlYMUQrZmlR?= =?utf-8?B?UTZMdTlSMVY3VnZrN2tpYXB3NjVvYVRnWU04MmxWNGdwbkMyRndlVGplMUti?= =?utf-8?B?bDhkZGJSVzE5MXJ5M3liaXl4RGp4azkzRDFGMTBVTXcrSFdsZE1xYmYrbVkv?= =?utf-8?B?M05lWFVUL3BINDViMnpUbVhsZlVYaUNBNjA5OUpzTEUxRTVVSmR5WHRicm9C?= =?utf-8?B?aG9qT2E5Q2lOeUs4Um5UejdBUDB0TG1mQi84YVExN2NhZEJERWtOQ0xsL1k5?= =?utf-8?B?ckUycklOb1F0TTZmQTZLcFVvNmIrWUdoVkNYcW5jekJrMEhWWUF0OGxtNFFl?= =?utf-8?B?alZTUnZxM0MvbTJNVGcxaThQRUI2aVE0RE9KalpjTHB1azhiNW9ScVdRUENx?= =?utf-8?B?citsL2x3bytSNGc2VTd2MDVidllicHZRcGhQdEZ6NTNvZVZNdGpZbEtLMzJO?= =?utf-8?B?NHZQcDQveForWGxJbEJDQVpiYmFhWUh4NEZlcElLd3NQS0VMbXN6c3BhQXlR?= =?utf-8?Q?trRH2Wg5cZzl7Z3dAQxcMvBWx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 92c1ce5d-e340-425a-97d9-08da64d68c98 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 13:49:47.2029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vZ1Z6mFebcRMM4SQjd0SvIw0LbfzjDQjgoeb9/RIbGIv+j9SZc141H8CnbCsPXBaGxmf+vkp+wXql6iYY+ihoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3296 On 13.07.2022 12:57, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月12日 22:21 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; George Dunlap >> ; Julien Grall ; Stefano >> Stabellini ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v2 6/9] xen/x86: move NUMA scan nodes codes from x86 >> to common >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> x86 has implemented a set of codes to scan NUMA nodes. These >>> codes will parse NUMA memory and processor information from >>> ACPI SRAT table. But except some ACPI specific codes, most >>> of the scan codes like memory blocks validation, node memory >>> range updates and some sanity check can be reused by other >>> NUMA implementation. >>> >>> So in this patch, we move some variables and related functions >>> for NUMA memory and processor to common code. At the same time, >>> numa_set_processor_nodes_parsed has been introduced for ACPI >>> specific code to update processor parsing results. With this >>> helper, we can move most of NUMA memory affinity init code from >>> ACPI. And bad_srat and node_to_pxm functions have been exported >>> for common code to do architectural fallback and node to proximity >>> converting. >> >> I consider it wrong for generic (ACPI-independent) code to use >> terms like "srat" or "pxm". This wants abstracting in some way, >> albeit I have to admit I lack a good idea for a suggestion right >> now. >> > > Maybe we can use fw_rsc_table or rsc_table to replace srat, because > srat is one kind of NUMA resource description table of ACPI? Is "rsc" meant to stand for "resource"? Would be a somewhat unusual abbreviation. I could see use using e.g. numa_fw_ as a prefix, as in e.g. numa_fw_bad() (replacing bad_srat()). > For PXM, I had tried to keep PXM in x86 ACPI implementation. But the > cost is that, we have to move some common code to architectural code, > because some messages use pxm for info, and they have different meanings > for each platform, we cannot simply remove them. Well, for functions wanting to emit log messages, suitable abstractions can likely be made without needing the retain a lot of per-arch code. E.g. the arch could pass in "PXM" and format strings then would use %s together with it. Similarly the translation (if any is necessary) could likely be abstracted by, in the worst case, passing in a function pointer. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:52:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:52:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366626.597577 (Exim 4.92) (envelope-from ) id 1oBcmf-0007ei-MG; Wed, 13 Jul 2022 13:52:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366626.597577; Wed, 13 Jul 2022 13:52:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcmf-0007eb-JI; Wed, 13 Jul 2022 13:52:09 +0000 Received: by outflank-mailman (input) for mailman id 366626; Wed, 13 Jul 2022 13:52:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcme-0007eT-0C for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:52:08 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2050.outbound.protection.outlook.com [40.107.20.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fb586c06-02b2-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 15:52:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6040.eurprd04.prod.outlook.com (2603:10a6:20b:bb::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 13:52:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 13:52:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb586c06-02b2-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QsgpC7RkIM1A3AKlznaSkFJIGndkEpACUZZVF16voyeaqBVGFAT59IJdk/qcGY3C/bw00gkWrjzTw9gD6czyF5koA0JssQSCDrfdW7Pjr3aXeEpcOnQyOjlCMZS6NLibwGK3L/yanvagHrfNjYOyrLUgd24HAzQxhkM24JFiRmj/KezQCpKgdIwipBF/jkaWi2Nq/behvNlQmlfSBviANLcqxETBuOV5FkycvWAyxoU+aXdUjT7OFjHN6orIWaVqp6x68+Z4MQwXscjnnEjBZIU9l5l7tVdnDDxBfb2eDfDmoP8AK125fz3dzNVOwnRfzlmkvlVaxx1TEdFcwRCSwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yF24IXqYWvWlZbD6zmFf1dRj9zustWalBNss3N4AFag=; b=ELMn2ctXs0dYLWi9MdTwsdB0qebfDWeKlOnFAqLNgn4x3fXu6Rqbvj9NDpRfD+3/g/bzefK5iH/3ltDXs9sMWKIi/zyW9tgv3BPsVvziretaRgBL9OwvSBlDmA1GtP7B5ttBS3PuEYgIpvC7KBqdvWX3T8+ns8DI7+0ug90nxbMimoC7Mi5Pc4M3JB0qpAQ5QWKrUXUSlT8PS4XJzRHB+8PVjnHSeWdv5Ce9VyTJ6Kz9TnKquLGv/zCuoOKtDrGaMFfPD+gLl8MnMU51Mp8SWE8s51mFZSaCQbA00cck8szc9tgHg1pYBHK/Ywpaj7TknzUDsof/jmfmFKgG6Z5zdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yF24IXqYWvWlZbD6zmFf1dRj9zustWalBNss3N4AFag=; b=vQFcNxyYBe3QkvKmKAt8TatLuiUCzZgdrPsQpWdOh3v9PUhTtJ9UafSliwrGuecHrU8fW899Zq7KP8c5zQYA78Sa12GoB5ulzAzKGlVqpsWbpK5HGaIV1fsccRFPRRGXKqU3/N16bucDDdMdTSCqBw/hFrExeN0VOd43rTJ/oYUjdXJYwoYH4DsE7wPv2SVayMYT5yE9l1SHPcU/UFx08UiOFVZB/7wnGqXlDd9Ti+PvGc/6PoyuBUod24RUS2YHnrTXglSjAlhOUVPKAg/s8QTOPcV5GtoLY5hv4Ida8ASdJuXy2ujqB++gQrd/BErhSOe8mIUrR7oNmr6ngKP+Hw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 15:52:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Juergen Gross , "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> <62e32913-cfcb-e0b0-2bbe-75cc8597951d@netscape.net> From: Jan Beulich In-Reply-To: <62e32913-cfcb-e0b0-2bbe-75cc8597951d@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0178.eurprd04.prod.outlook.com (2603:10a6:20b:530::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d43b685f-0701-4c70-cf9c-08da64d6de3f X-MS-TrafficTypeDiagnostic: AM6PR04MB6040:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TA2Bqkv1iGE3wbf8K0Bs/JPizFxpFQTkuyWdv4P+GTbX2LYwoYsOzu23WXuRl8Z1f9zwlTJohfUCkJST1lflUZMrQLyS119W5Gll/3EVUucT2rdFD9M+G5DNNsg3v+RdV9pOA2jgrBTjt890vxoN4VoHFz2tReQJ03lC3lvujtoxqncGN4fClTBGJxohRJNUgK3mI5l5f/k5c04IuDPczQnSr1U6NtQ1fRJr2gVoaLIkTRsasuTaPRnizH1kFIkXYDV6Lquc+OO5gfg+eDWvc2pMN5pSJAgzGs2jzAH3GX3UOLISivKOga/uSoO558qTpJn69sygRjCqIlt/53UsePLf/T8eokrTlJRIpBEzA2CxcXrj4ylNaS1O8Z9Nb9yCDSbYl+dUiSqwGC7vR9rOTirXIXjO0vlR41nZUexla41wzxgA23+thEH8Sj6CTFEk+s7TXQth/0svPduHHbYA8w8po3JhNo0lKugc2zP4SF4lEOW27fNrwLLuDZ+tQlaGV012jVYREPo+Ul5fcQEZgaRJwVtLb5sOA3xt9M5HS2MuXx1C1EYmrIhJDyYOPPFxFSPRh/gfHdSAFTQJlsa6QSMAOy9O0pxgUbUxfRwsl4IV8U9XSgeqDNB1gcMdxmnc/Apt4KlTOcG9gVlRY1cdGHN2xy9tU58bo+ojQeXdmcokIj84bqFBy1/hMsVBHNXpwvOt8S3xPjWCf65KJFhfwc1OP/GUNqpdd1axahIIUv2zzJzBZGsVfACOPzX6KmjIdaT0F1OBy6LUtdEfWit42xAydpYaVTtMoWvLyJgcp1yaOGkif2qcWWLIO05eGaig2PLQiLJEzOPR1uPoWoLaHeXgnVfoMPymol+d8k1Kkbc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(39860400002)(366004)(136003)(83380400001)(5660300002)(66476007)(8676002)(7416002)(31696002)(6916009)(66556008)(316002)(54906003)(66946007)(6486002)(478600001)(86362001)(2616005)(36756003)(4326008)(6506007)(26005)(6666004)(41300700001)(53546011)(6512007)(186003)(8936002)(2906002)(38100700002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YTRFUVNwdEYwSnFic2swMXpnRUdES1hYdFRCemFzaWpsWmRBTmtyTi9FSUhV?= =?utf-8?B?WGlzMzFaVFdkRmVab1VQSXVOYjJpR1hKcjJnV1JkMmltcXVEeUpPMmkxNXg3?= =?utf-8?B?ZTBCUm9VckNqVWc5dGJvQWI2WWt6TTRyQUlHYlJMZWZEK1VnNUR3V0ZhUlBk?= =?utf-8?B?ZzJveVM1dFFlWXdDbWh5SGZaZW5xSENzaEs1NndhWHFQcEV2dFVrSmNoTDRH?= =?utf-8?B?RlFhWW04bDNvYWowMnBCc0JaTUdIclFKZ3BxcS95U3BQTEVwckNUQVZtdHo1?= =?utf-8?B?TkszZFVRL3VkUzNGcFlHS2xnZDNlZGxzOUNhbTZZaGRMUFQ5VGtzSzhxR0VO?= =?utf-8?B?OXRQeDhBamV2MzBDVzdJUEdjaytzZnkrRnJmUFl3b0tiaXhRS2lnRFRibTVj?= =?utf-8?B?U3pSdWVFV2NwN09ZWXhmeVFwbElZbzNzbFhxK00ydFNibml2UEZ6SVUzZDBM?= =?utf-8?B?bjd1NUxaMElzVEFiWVdONURqSVJFVUREZkFGR1Z3bk1ZOHlvUlNoZWZ4Mm95?= =?utf-8?B?WnlIbGhPdDNNaTVNVEZjbTE5Y2dOUkFxelZva2F4WGwwamhVUEtXelNNY2la?= =?utf-8?B?ckRwdExkbWNoRC81d0sxMGwzSDdmTXgzd2xaSlkwdTJ3dWozSk1naFJTMmhY?= =?utf-8?B?TW1meXVFZytXZ1UzMmdZNkwzV1R4OTNUMlRGQVZsVEtnNW03bDd5UnBMd21M?= =?utf-8?B?M2g4c2pvT0R0Rk1sU0pnNVl3ZS91RkVVWUNiQ2RQYTd0eUlwbmF2OUNEWXpB?= =?utf-8?B?YmFOamMxMHV4ZWFwYXAwVVNDbkxVS3JJcGJFaG15bitMWHFRelFpMC9DZDZL?= =?utf-8?B?cmpkRDJ0MzFZWU4yQzEwbi9hTUdFeS9UcmtsTWpFK294ZDFRU25NbXE5Z2JP?= =?utf-8?B?eGJWSHNuODQ2RkQ3aEpURkxXYXFkNEhGdDdKSkJaQWJaYjdhdW9HRVBRYzNs?= =?utf-8?B?eUtxMGJ1K1Z4eHlkMnBIYTFmZ1hyTitXZi9jYXFyU2ExQ0xTTExyMTBsMno1?= =?utf-8?B?NmRrSUNTamZsbFVzWU1wOXNCbmZSQzMveW9yN0E5bTByaExvdG1rSkdIKzcw?= =?utf-8?B?WEdFZDNUMmtRNGJoMDV3clV3bmxoRlhUR2paQkQveGpVS0xQUmVwd1FsMlpG?= =?utf-8?B?eDhaTWxIbFBSRkllMXk1Uk1DS3Q5TzAwQStaRnpDR2huWkZCRk9lY3p2dUIy?= =?utf-8?B?MFVBSmFPbmhUYWh2VXE4ck94eVptQStuR29hOXl4ODI2T3Z2bjB2S3dJV0gw?= =?utf-8?B?cGZMandrRDdkVVUvc0lGUkYrb1l6L0g1SHFNU1RUT3JnNFdNcyt1TFV3RHNW?= =?utf-8?B?S24rRmFLTndyUmc2cEdQaTJiNFZlbHUwa1NjeWd1cklrM2pKZERrNmRJL2dz?= =?utf-8?B?WlU3dC80aDJvL2VpWGkwSEc0ZUZTOGp1SFN3QXZNdkNZMm1TWUowQkk1Tm9G?= =?utf-8?B?N1IzcWpUNFBmbE4yUWFLNW5rc0ZwQjRsclJYSXVYRjFmVkR2UytVeUlmZ0Yv?= =?utf-8?B?Z1o4Nk8zOW5aKzN1R1NLc1FjVGp3R0RvNkRPM1l0VXo0bktkTXc3eU5UN0cv?= =?utf-8?B?MmJUNTdwNGJmMk9wRlEzRkZ3dHJOSmdEcTdXWU8yU0VhMVBOZXdiWkl1Tzdt?= =?utf-8?B?SnN1ajB0M3k3cUxOdW9qbzc0M1FxUk9IQ0UrY1ZjV3hZV0VqL3J6Qk1KYVFU?= =?utf-8?B?Qi8xcnZCSXRwTmhDY1J1WTFOUG92NHFhcmNoTnVuMFdyTEpYTWNzeUQ0Z21z?= =?utf-8?B?TFp0Lzl1OHhQd3VBSnJuckJuMVdpNW5lenkxL25leWRBdEF3YjZUSC9IbzRs?= =?utf-8?B?d0FXVE1GaE1xSVY5aEw2YlU2VURXQXJxc09ySTJjVmo3ZnVnbFg1ZzNkYU8y?= =?utf-8?B?V0E3L1FjTElOK05jbWZEblVhaDJscm1TZW5VV09SVVVzTUxHYjV1RWlEVXl4?= =?utf-8?B?a3JTanRWWUVGL24xbUovS1BVQXBHQVVla2Vmc2hvVm8za29TOGxVQ3RvajUy?= =?utf-8?B?cW52eFNKUDFXZU1xYlNYK0VDOUlwRXpJQW44cmpVcklZbjFlbW0reE93REtF?= =?utf-8?B?bVI4ajdMYjNvNEVEOGNJZ2JNZk9sWWg2WC95ZHBrRVY5N21BYkcrVWdHQ0hE?= =?utf-8?Q?BBXqE6/A2Vz3xlyvZnJDVaqB0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d43b685f-0701-4c70-cf9c-08da64d6de3f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 13:52:04.2255 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NXnMhclZSUYYkdh36X8UyTMVtmJR38FfisCAgS90E/kjqVarrlR7bCje2iFk+cIvh6ICQVnHOV52nCL2aXmE+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6040 On 13.07.2022 15:49, Chuck Zmudzinski wrote: > On 7/13/2022 9:34 AM, Jan Beulich wrote: >> On 13.07.2022 13:10, Chuck Zmudzinski wrote: >>> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: >>>> On 7/13/2022 5:09 AM, Jan Beulich wrote: >>>>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: >>>>>> On 7/13/22 2:18 AM, Jan Beulich wrote: >>>>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: >>>>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) >>>>>>>> *Add the necessary code to incorporate the "nopat" fix >>>>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) >>>>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) >>>>>>>> *Expand the commit message to include relevant parts of the commit >>>>>>>> message of Jan Beulich's proposed patch for this problem >>>>>>>> *Fix 'else if ... {' placement and indentation >>>>>>>> *Remove indication the backport to stable branches is only back to 5.17.y >>>>>>>> >>>>>>>> I think these changes address all the comments on the original patch >>>>>>>> >>>>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to >>>>>>>> include Jan's idea for fixing "nopat" that was missing from the first >>>>>>>> version of the patch. >>>>>>> >>>>>>> You've sufficiently altered this change to clearly no longer want my >>>>>>> S-o-b; unfortunately in fact I think you broke things: >>>>>> >>>>>> Well, I hope we can come to an agreement so I have >>>>>> your S-o-b. But that would probably require me to remove >>>>>> Juergen's R-b. >>>>>> >>>>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) >>>>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); >>>>>>>> } >>>>>>>> >>>>>>>> - if (!pat) { >>>>>>>> + if (!pat || pat_force_disabled) { >>>>>>> >>>>>>> By checking the new variable here ... >>>>>>> >>>>>>>> /* >>>>>>>> * No PAT. Emulate the PAT table that corresponds to the two >>>>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). >>>>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) >>>>>>>> */ >>>>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | >>>>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); >>>>>>> >>>>>>> ... you put in place a software view which doesn't match hardware. I >>>>>>> continue to think that ... >>>>>>> >>>>>>>> + } else if (!pat_bp_enabled) { >>>>>>> >>>>>>> ... the variable wants checking here instead (at which point, yes, >>>>>>> this comes quite close to simply being a v2 of my original patch). >>>>>>> >>>>>>> By using !pat_bp_enabled here you actually broaden where the change >>>>>>> would take effect. Iirc Boris had asked to narrow things (besides >>>>>>> voicing opposition to this approach altogether). Even without that >>>>>>> request I wonder whether you aren't going to far with this. >>>>>>> >>>>>>> Jan >>>>>> >>>>>> I thought about checking for the administrator's "nopat" >>>>>> setting where you suggest which would limit the effect >>>>>> of "nopat" to not reporting PAT as enabled to device >>>>>> drivers who query for PAT availability using pat_enabled(). >>>>>> The main reason I did not do that is that due to the fact >>>>>> that we cannot write to the PAT MSR, we cannot really >>>>>> disable PAT. But we come closer to respecting the wishes >>>>>> of the administrator by configuring the caching modes as >>>>>> if PAT is actually disabled by the hardware or firmware >>>>>> when in fact it is not. >>>>>> >>>>>> What would you propose logging as a message when >>>>>> we report PAT as disabled via pat_enabled()? The main >>>>>> reason I did not choose to check the new variable in the >>>>>> new 'else if' block is that I could not figure out what to >>>>>> tell the administrator in that case. I think we would have >>>>>> to log something like, "nopat is set, but we cannot disable >>>>>> PAT, doing our best to disable PAT by not reporting PAT >>>>>> as enabled via pat_enabled(), but that does not guarantee >>>>>> that kernel drivers and components cannot use PAT if they >>>>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) >>>>>> instead of pat_enabled()." However, I acknowledge WC mappings >>>>>> would still be disabled because arch_can_pci_mmap_wc() will >>>>>> be false if pat_enabled() is false. >>>>>> >>>>>> Perhaps we also need to log something if we keep the >>>>>> check for "nopat" where I placed it. We could say something >>>>>> like: "nopat is set, but we cannot disable hardware/firmware >>>>>> PAT support, so we are emulating as if there is no PAT support >>>>>> which puts in place a software view that does not match >>>>>> hardware." >>>>>> >>>>>> No matter what, because we cannot write to PAT MSR in >>>>>> the Xen PV case, we probably need to log something to >>>>>> explain the problems associated with trying to honor the >>>>>> administrator's request. Also, what log level should it be. >>>>>> Should it be a pr_warn instead of a pr_info? >>>>> >>>>> I'm afraid I'm the wrong one to answer logging questions. As you >>>>> can see from my original patch, I didn't add any new logging (and >>>>> no addition was requested in the comments that I have got). I also >>>>> don't think "nopat" has ever meant "disable PAT", as the feature >>>>> is either there or not. Instead I think it was always seen as >>>>> "disable fiddling with PAT", which by implication means using >>>>> whatever is there (if the feature / MSR itself is available). >>>> >>>> IIRC, I do think I mentioned in the comments on your patch that >>>> it would be preferable to mention in the commit message that >>>> your patch would change the current behavior of "nopat" on >>>> Xen. The question is, how much do we want to change the >>>> current behavior of "nopat" on Xen. I think if we have to change >>>> the current behavior of "nopat" on Xen and if we are going >>>> to propagate that change to all current stable branches all >>>> the way back to 4.9.y,, we better make a lot of noise about >>>> what we are doing here. >>>> >>>> Chuck >>> >>> And in addition, if we are going to backport this patch to >>> all current stable branches, we better have a really, really, >>> good reason for changing the behavior of "nopat" on Xen. >>> >>> Does such a reason exist? >> >> Well, the simple reason is: It doesn't work the same way under Xen >> and non-Xen (in turn because, before my patch or whatever equivalent >> work, things don't work properly anyway, PAT-wise). Yet it definitely >> ought to behave the same everywhere, imo. >> >> Jan > > IOW, you are saying PAT has been broken on Xen for a > long time, and it is necessary to fix it now not only on > master, but also on all the stable branches. > > Why is it necessary to do it on all the stable branches? I'm not saying that's _necessary_ (but I think it would make sense), and I'm not the one to decide whether or how far to backport this. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 13:53:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 13:53:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366634.597587 (Exim 4.92) (envelope-from ) id 1oBcnv-0008J9-4o; Wed, 13 Jul 2022 13:53:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366634.597587; Wed, 13 Jul 2022 13:53:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcnv-0008J2-1l; Wed, 13 Jul 2022 13:53:27 +0000 Received: by outflank-mailman (input) for mailman id 366634; Wed, 13 Jul 2022 13:53:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBcnt-0008Ie-Co for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 13:53:25 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 29ec54e1-02b3-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 15:53:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1C5DF200C2; Wed, 13 Jul 2022 13:53:24 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE89C13754; Wed, 13 Jul 2022 13:53:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9UExLVPOzmLgUAAAMHmgww (envelope-from ); Wed, 13 Jul 2022 13:53:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29ec54e1-02b3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657720404; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=DM39RGb67pC/dQ+Mn9Ekz27AAhpc6Ju3ivYPtP9YBvs=; b=PKsAJZoJfkrCh5hlKucZ3+P2/L0LKquOqhJZlrEKdWTcV8r76nL07sOLRqnsNZGxze5+vi rJmxMeIUwbdEIUKqqBpoKbEhQEJJdbgg9Gi9hF0ii5wA59hsnxdqbot1gMi31AeACQhp7s 9GFsn8IUMy7Qulz/jfF1ExTp7YNuBYM= From: Juergen Gross To: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Juergen Gross , Wei Liu , Paul Durrant , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , stable@vger.kernel.org, Jan Beulich Subject: [PATCH v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue Date: Wed, 13 Jul 2022 15:53:22 +0200 Message-Id: <20220713135322.19616-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit xenvif_rx_next_skb() is expecting the rx queue not being empty, but in case the loop in xenvif_rx_action() is doing multiple iterations, the availability of another skb in the rx queue is not being checked. This can lead to crashes: [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] [40072.537534] PGD 0 P4D 0 [40072.537644] Oops: 0000 [#1] SMP NOPTI [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 [40072.539211] Call Trace: [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] Fix that by stopping the loop in case the rx queue becomes empty. Cc: stable@vger.kernel.org Fixes: 98f6d57ced73 ("xen-netback: process guest rx packets in batches") Signed-off-by: Juergen Gross Reviewed-by: Jan Beulich Reviewed-by: Paul Durrant --- V2: - modified patch title (Jan Beulich) - added Fixes: (Jan Beulich) --- drivers/net/xen-netback/rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/xen-netback/rx.c b/drivers/net/xen-netback/rx.c index dbac4c03d21a..a0335407be42 100644 --- a/drivers/net/xen-netback/rx.c +++ b/drivers/net/xen-netback/rx.c @@ -495,6 +495,7 @@ void xenvif_rx_action(struct xenvif_queue *queue) queue->rx_copy.completed = &completed_skbs; while (xenvif_rx_ring_slots_available(queue) && + !skb_queue_empty(&queue->rx_queue) && work_done < RX_BATCH_SIZE) { xenvif_rx_skb(queue); work_done++; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 14:10:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 14:10:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366642.597599 (Exim 4.92) (envelope-from ) id 1oBd4T-0002XB-IR; Wed, 13 Jul 2022 14:10:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366642.597599; Wed, 13 Jul 2022 14:10:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBd4T-0002X4-F6; Wed, 13 Jul 2022 14:10:33 +0000 Received: by outflank-mailman (input) for mailman id 366642; Wed, 13 Jul 2022 14:10:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBd4R-0002Wx-GB for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 14:10:31 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50042.outbound.protection.outlook.com [40.107.5.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cd2eff7-02b5-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 16:10:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5357.eurprd04.prod.outlook.com (2603:10a6:803:cf::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 14:10:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 14:10:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cd2eff7-02b5-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5lbu11iq/HA+yG4j1F7vgWiuGmQ1Wgk5zM7sUAoUJiDGTu1EHOic4TmT/L123VkSfiy9c0catGluwXQQUs7K8VD/01Rd6EHTWNjDdeEQVdz1/YODm8aMoUKZIGVMq5NYcudL2KfN2AGO15VOstOwZpxxGhsqahI4B8d/ynmt1jn6fgmb/96OEK5UdGey1uY+MFe5hm1qy0iqD+WjffXS1vVz3sCPiJBzuyhnaPMNz4YKuQ4YFQtKVqrzkdya4Hyg5SuQSgDIDmZUfD16mvi97RZx2wk5TKsXTlXTT++6+alzuXV/WMb9fto23XE74ga1Ig7xuFX1CyDnYqRnXd1/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vO51oXF9hvdPBCZcvmnyXvB5mKwtxNhDW77IFfIfZjc=; b=GFpVe5ckDsB1Fo7pVl3UdkOvAAAHU1V30nIN+2MDMTidlgiaDvzH+XIarUh3hMxCUbF3ho0MyRUKkRdaDkwd6MsECQslL1GDF5hPjbp9TV8KFfSVut2GRLkJV4gvu849tTNBKUe2e0F69vLwQ3HlBd9/d9ORf3L7R5LeP7q82T17aE6Sze1n2AdbLAvgrb50DCFynFpH/JZHrr/406U3vBpY1ucDOoFmt/xrumXgY8LgMg7DPUJGiEc9RV+4IoJfAZnHjqoCJN0whSJ0UBEKRzEvii4otW94D55iSEe29Q84Til/1v7Lf1E4kqVZPm8HqI9uLxHrTtBmxrPv5O7FDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vO51oXF9hvdPBCZcvmnyXvB5mKwtxNhDW77IFfIfZjc=; b=pttEn9R1knFKOIkggF4RurBlTW+AlU/AD9yVXXv/0vvgwMrucKYDK2KaF8aSkO3CIIt9tYTiAtHOJCehmZwvqQC23hegaiAR+P/v/c7JgvsoWvvmk0UuFSatefk9Z9lzufzpbTRb/62b+LfTKVqTCLC/e7pYED73N/MD/IzmtvQQ5pkmxRmGsuNtjZgqzSrQq/9WMoOCGq1ZfDTU7wFj+Hy7ewAS2Dlr7LJ9QaNb7ElCtJMzF8GJezkJvqtAsAFpFhsZZnWdUADhm9Wi1NZ/gwTUCufAaKCQzn9HgRg/g8MmM+DDH7qzpD6aZJ1zMlM8A8avz099R0WiJ9o2EJILUQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 13 Jul 2022 16:10:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/9] xen/x86: move generically usable NUMA code from x86 to common Content-Language: en-US From: Jan Beulich To: Wei Chen Cc: nd@arm.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-4-wei.chen@arm.com> <444a540a-bf0f-f743-3b01-b65210b49361@suse.com> In-Reply-To: <444a540a-bf0f-f743-3b01-b65210b49361@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0005.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 55530fc1-8796-4c27-abae-08da64d96f3c X-MS-TrafficTypeDiagnostic: VI1PR04MB5357:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: koMM9rneJTHqQi3zYbbp7VEecAjHfcguhq8HWYNLi/xlFHztTXFykFGZ/euKzNXkzS1Mlcd07VuFCXg9+YE18S+s/aZpYWVjbFl49cQJ+C0dowhGUUWJPOpYbbAzt+ZQWw6+lB36UhqeOxsu/FLUXg/oYs9g7Ewv48xVvkMtJQe3s+Pp9Npif0f72Isth5g2NSt7Dt69BoOTx8djP5x1NiGhOtyCPjk68HUk3pU/gGHV+ZVGKJCsevi+CMU3N9apP5L3I3731h+MASg0d2GP9Jo1u+LFTp4cOxXHWQ9xhlivvFVAvisgtKvnNgXVG+4jDgAEYaf3WNJhyRe286haCkwGainfPImQI5QOlw9y94cfJ5SwZFpmerajHgeZZbvcBmmBB2fL0Gn9pUb6/4MmDddnFVfAQ4DOM/wYEwLCl26KYMZgOia5KagnFnQQh35t+1eFZCxESJ8oTvJFVpxhyBJGBAC0MXbQ04f0vssPzzIROpdy/ngFx1j0yuKL8q2LwB27gYdLAAFc53AmzcwpMTrPJRBL9aR5hAG76N42+UmN2KPAuzknk22BMsB3yL9+zcc4ndHnB5mcFLNji7YHbnn9Hdrg80PSdPE3LEeuFXdhIJ+tVfqjMbkjnN0wOjsf83qp/TYfC8AS76teiuNzJIYcD2h+YIregnY95BfJk8WA10SikUxDs2kj4lRdMRAkHHhIGLJjjtWD6qEFXVF+9YMYf0o04sdrozkj8YEvalB0AxI4D9yzI6CSPJKc2rfC+affYza9XTeYUu3xYeJ78o3HkP5d7qVy2ioyVzuVmT4kNCtwvOmyysAOvjZZBSKUFKRVa9C7HaLE1S/0IIhlY3JFygELwEe3MkZ4yGtkenk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(396003)(366004)(2616005)(8676002)(4326008)(6506007)(53546011)(66476007)(66556008)(31686004)(36756003)(66946007)(186003)(6512007)(41300700001)(8936002)(5660300002)(316002)(38100700002)(26005)(6486002)(478600001)(31696002)(54906003)(2906002)(6916009)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NjNiUktURVJRRDN6YmVtUlY5STZCNmZhNkQxM3hiR0NJbnk0UEVBTE1pcWp3?= =?utf-8?B?KzFpbXlBb3pvZ21hbGt3V0svSWR1UzE0bUVxWm4xaHh6UURFME9zRFUyM0Vx?= =?utf-8?B?a1UyV2NDTnJ0UnAyM1gzNWt1S3NQbFRBSE95V3h4UmJ3NWdLeTc1SEZRNldt?= =?utf-8?B?cGlFVzR4bkF6ZEN2Yk50SWpiMFBjZXFBSVZIUU9EaUo4eU00OE8zaFpCUklL?= =?utf-8?B?OWdGaDZXREkySkpJbXRpZGloNmRVR3MzU0tYekdGQS9ETkIrOXlsT3FSdnRU?= =?utf-8?B?bWoxZ2NSS1RGMjFwSjBMbVFtTzBqMzJNU1pmRTM1cUJpdkVqY1hQRWg0V0Rk?= =?utf-8?B?TUpxMUgrR255WEhpeGFWS08wRDhMTG5mbnpEbm5aMkY0Tnl0R2pMZ2lXa0o1?= =?utf-8?B?c3NqcnVwOWk0d1h6Yzh2OUNLQk1RUUhCeGFsWDk2NjFhVW1zOVVKbzNzRmd6?= =?utf-8?B?UWE0QVRIc3VVYi9nVFZma0dnTVFzZldKLzF6bmFXTEQxeGUrZXc4cTg0bVFL?= =?utf-8?B?QUJWNlNpMjR0blF4S2c5SlZremQ5Mkdwekl2bklEbFRpVTM4Smxnc3grZTBZ?= =?utf-8?B?Zng0OVRnaGVyZjQxZ3N5ZXpHNnRDK3RzK045UjVkUzRoN2pGMmZLTFNLY3h6?= =?utf-8?B?Zm5lZVZBM1N5M3JpUURGVk5oSkFSVTdMc3BSR0V3RmdNUmoreURIY2wvK3Rz?= =?utf-8?B?TWFoNkFIU1B2NWd5Z0RmWENEVmRzNW5rampNS0lKQjNuV1Z5aTFmdjRnaWgz?= =?utf-8?B?QU1zaW1hNnhwQXM3eS9GSWlTbjVTUlZBc2YvcEtoUGRBa3l0eEwvTS9PNEtS?= =?utf-8?B?aE90dUdVUFFRLzU4ZEJMQ05DODRGVFVMK1NYM3NGYmxZOXlmL25wcE1Vdzcy?= =?utf-8?B?RjR5YVU5VWg3U2E2R1M5dS8zVlBUOGZRdS8vMldtdXVkakVsUTJjVXFCWWoy?= =?utf-8?B?Z1BBTGMrZHhoYVQ0UllITTJDdTZSdUptbFFINlVuSGdFRVN3WGM1UDduNktI?= =?utf-8?B?NDhYN1YweFQyZkhXN0tadjlQZUxVU25memkyallUMThvVFhYemVORDhQaFhN?= =?utf-8?B?QTM2WERmZFY3WGZkdVBsekp0bXJWOEliaStTbUQ2dDNZcXdsNUdmUVUydzYr?= =?utf-8?B?WUNnR1hUdTJzU1R0dE04L3ZmNGJiYWQ0c0VSaStxcElic2E2aGZuQzhsaCtZ?= =?utf-8?B?N2ZWTjdub3lQekdlUWNCZHRLaTB2R0NOZ3hOVkFBbldGYTRHdXBpVldCci9R?= =?utf-8?B?WmVGV2dXQUtxczFmT2k4eXRjeFhBQVgzNWQ4Yjl0Q051dmU5T1gxUkRFZ1Fi?= =?utf-8?B?d3ptSFM2bkhtSUlhS1dablhnS0QrNDRuT0QvRVluOHZMSFNUZnBaalVkSjc0?= =?utf-8?B?SWprK3pGRHl5RGpTNmlzYkQvZW1TWHRqblp3ZHBJbDFsRXNEaXlDQU1tcHZM?= =?utf-8?B?b0JIQnZEMTh2MldVaDBVMXZ5VWZaUGZ5ejRQNWVaM3Z1YTRFeTRjOFFPVTRq?= =?utf-8?B?czM0cituRWhrdGcrbWRZWUlRY0p1U3FpNVl5QS8zbDR4d1dmVXpDcWE0VHJF?= =?utf-8?B?bzc4NEZvcjdrTUc4ZFNEbHhvbHVUekxSSjIvZnRHdEtOMEQvZnRPWHA3TElo?= =?utf-8?B?L2g5V2lSeEtRRDd6VXpaUWdOZ05sbmttQklrUUYzU2pxQ3lLMmpYNHcrUTdr?= =?utf-8?B?dDZVcnpCaUdWVEZNaS94cjcrZXJlcWNIRndIL01LcWNIUFJHUGFwZzZqQVNI?= =?utf-8?B?Ky9NZERoRWVvSk9ZbCtWQk5USFJzVkVJUlB6a2lhTXRVZzZiaEI5VXk5bjcr?= =?utf-8?B?bzhjNFQ4RzNlNjBVNzhSSUhRSEY3WEN1bnd4bThaT21janBHZ1QxODZNeVNk?= =?utf-8?B?d2R3QVc1VzRjVjB0UHJ3TE1POFpPQURsblNuM25hYVdYTUpZTEU3bE03TU1o?= =?utf-8?B?NE9yZzVOUElLM1NSNmEycUJ1dnNXeHVnRElIcDBJY3lBU3I3TURBeDBvK3dY?= =?utf-8?B?em1EbUZhcVZNcEVldVRxdXFqbFBJNHEyam9RZmdCN3VPUnQ1S011QU9zb01r?= =?utf-8?B?cE9Hd3MxalZPdEZBbjlNcWxvNGhvdDhvb2NFcHM1OTRrVkh4VFZQV3NSMWFD?= =?utf-8?Q?SeysYJYWj0K+1rmJ3LIOAm17v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55530fc1-8796-4c27-abae-08da64d96f3c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 14:10:26.5461 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +e1TrcupfqkTZbVR4gtWD1jeGCkUqHJpSzMyjtsSiq78TLczDYM+xT6rF8TJJK48Oeno+nzQ3Y2IpZTbi/FU1Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5357 On 12.07.2022 15:13, Jan Beulich wrote: > On 08.07.2022 16:54, Wei Chen wrote: >> --- /dev/null >> +++ b/xen/common/numa.c >> @@ -0,0 +1,439 @@ >> +/* >> + * Generic VM initialization for NUMA setups. >> + * Copyright 2002,2003 Andi Kleen, SuSE Labs. >> + * Adapted for Xen: Ryan Harper >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Isn't the goal for the now common code to not be dependent upon ACPI? > >> +struct node_data node_data[MAX_NUMNODES]; >> + >> +/* Mapping from pdx to node id */ >> +int memnode_shift; >> +static typeof(*memnodemap) _memnodemap[64]; >> +unsigned long memnodemapsize; >> +u8 *memnodemap; > > For code moved, please switch to (in this case) uint8_t. I'm on the > edge of asking to go further and > - also use __read_mostly for some / all of these, Actually where possible please prefer __ro_after_init over __read_mostly. While this isn't properly enabled on Arm yet, it should at least not cause problems, as the result section is covered by .data.* in the linker script. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 14:36:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 14:36:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366648.597609 (Exim 4.92) (envelope-from ) id 1oBdTa-0005Do-Id; Wed, 13 Jul 2022 14:36:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366648.597609; Wed, 13 Jul 2022 14:36:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdTa-0005Dh-Fo; Wed, 13 Jul 2022 14:36:30 +0000 Received: by outflank-mailman (input) for mailman id 366648; Wed, 13 Jul 2022 14:36:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdTZ-0005Db-Lg for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 14:36:30 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30066.outbound.protection.outlook.com [40.107.3.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2db61904-02b9-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 16:36:28 +0200 (CEST) Received: from DB6P195CA0011.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::21) by HE1PR0802MB2506.eurprd08.prod.outlook.com (2603:10a6:3:d6::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 14:36:24 +0000 Received: from DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:cb:cafe::d9) by DB6P195CA0011.outlook.office365.com (2603:10a6:4:cb::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13 via Frontend Transport; Wed, 13 Jul 2022 14:36:23 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT039.mail.protection.outlook.com (100.127.142.225) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Wed, 13 Jul 2022 14:36:23 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Wed, 13 Jul 2022 14:36:23 +0000 Received: from a125e425efbc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DA168172-30F4-464A-A93D-BF06914ABB69.1; Wed, 13 Jul 2022 14:36:17 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a125e425efbc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 13 Jul 2022 14:36:17 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7005.eurprd08.prod.outlook.com (2603:10a6:10:2c5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Wed, 13 Jul 2022 14:36:06 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 14:36:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2db61904-02b9-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=THBJ2n2Chk4K0P43vvwrQQ4ZGomvQ908BhE61HAhMDY2b/FsETLzVBQGu5rsiItKdOxFgKibn/VRJ1fbK0NsQSHocxJxrYTULEXbbM/adM9CZ3VFayOiEhwvJxvoD7Ub+KSIJG5gMw5an94jS+Wmyct3qgd4pu14v7ZGXdCTgH+WmTp4K2xz9xM6qRbMS8d3My/hXTwVnMkk+X1xL+YEx4rfTpYwxzQj36xc6r3LwEkRz2oVVvO2aSBa54y9ekEc+O6pAFsJ++VW2iQV91hzFSRAyiRXwHMp+/+/NJ03kcqtDqk2hXZg6vb7Xq1phpdBItlNDHfTNeJYWtsPLYNGbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ecrtggB2J7oX5XZ5untS6u6b2K5QL5aB+kVEFgZxac=; b=Y9UAkDVH9xdKChxknimecZA+gqxsU3/lB8wgFYxPEAO5stw/C+GBZH7IhK3AjR/Ru90jEQJjMUl88EIIqn8IelqSdMO2pgJ8GZvPLswjnEVq/cfVDzEzwbJO6hlpGDcJzr3GCqATuQ2+j0q1WA20GxjQIswWpvqpmQZekjzI+Vr4P/NQzKby4Gung7CCpFx6YXiB1vufDrlXoQ0HMu2CNBio94igbOBweKHbVjqAww+KH9VqmV8juXmdhaA7OpcJ/+MAqSgGxkuOvkBBuuCBwZDwaCulOLigC/J1R6fZxXYQIbpohsTRm18GPt5UVAKIt9S+pQR6AvUT2rzZ3kp4gw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ecrtggB2J7oX5XZ5untS6u6b2K5QL5aB+kVEFgZxac=; b=x0YwNd4vLQCVq92CV+seJNnUEmq3Xe0bk8NJ33YVNKAvOIzv/rq9Mt4uuZc61Y9xbxlD05RH58DLEwWUboK//cw4uMJEYphntSAjHA3s+bG46SvioOLD9ZkEoWOgOSr7RpoF2ymFJjtRKs0JqZglbrzn2EmVq8x2SCwzmt3UakI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9cf36136ba5b2a2d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tu2bbcXP59uH1o1W5yMJbsUpgKlA/kGi5JTmB21662y/AyH7GIBYm1nCgEekHfIRDroseaRMyTdTPhhdsSzhJJNhimHLvAma/hEY6fhLYV2wPdcK+JEGUmWLZ++rvLrGNP1NIiXQh/FhCpr7owXbEmZBBjxuEtAlJPhBQIJKvyCKuKNOs8fz9yfxBuqqPBOhdwKdazY6xSnvvG8/GomAVEcNHCp305uFSnn49jQZyTr+SgUXktiPv0ZWoX66kiI5fdd6+hbnHecAVB4BKrxuedjzBAEg2Mx6NDaAmfP5O4CSC/ROCuRwai+OyZz7ZX/zEQVY2aMcmcbBkSrRM9hn1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0ecrtggB2J7oX5XZ5untS6u6b2K5QL5aB+kVEFgZxac=; b=G3qj8V9B2niu+e+v96iDKqeFpH4KDgdFPLLq2VaCOyHnNufYfFbvLWywgT36kNsCzSXrlQH1ADiL4TuCLS5lpZrnwYFlm3OUHm5oiv87aE2MTymz2/P4XB6PGFCRuaUeKfPEaF2rQm0X6BgXd2bNIkgtNgjM5KmcFKPGjwunxhY+DngeMD9w5zFiJQLYGqAHoUZzFjkCvXX/QxUhhhBGqIOMPkr0JhFRnsKadIISwU8lvEinuVLk1ctKPKf+jDoUV/HXYcO3bg7dijQFmBdKn5TatbOk/xeHUFgD9Ks5LJ75siqs35Qo9Y2bKiBEQmTgFhKxpGpiGwAq5kcNn2KZDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0ecrtggB2J7oX5XZ5untS6u6b2K5QL5aB+kVEFgZxac=; b=x0YwNd4vLQCVq92CV+seJNnUEmq3Xe0bk8NJ33YVNKAvOIzv/rq9Mt4uuZc61Y9xbxlD05RH58DLEwWUboK//cw4uMJEYphntSAjHA3s+bG46SvioOLD9ZkEoWOgOSr7RpoF2ymFJjtRKs0JqZglbrzn2EmVq8x2SCwzmt3UakI= From: Bertrand Marquis To: Jens Wiklander CC: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator Thread-Topic: [PATCH v4 2/2] xen/arm: add FF-A mediator Thread-Index: AQHYhj32JXXtKHb7m068zMJ/M+86kK18f0kA Date: Wed, 13 Jul 2022 14:36:06 +0000 Message-ID: References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> In-Reply-To: <20220622134219.1596613-3-jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e0bda446-874e-4b23-eb80-08da64dd0f4b x-ms-traffictypediagnostic: DB9PR08MB7005:EE_|DBAEUR03FT039:EE_|HE1PR0802MB2506:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: J811oArzpjZHlzgk//7k2mt+WfbGLR1ejUN3CZK2ZtU7Ynn2285gYs3URuqnoFSfYJJFgLrTPQzWVmhi1F3f7UVyuRjVGr0+emgXX9CxTGegR5zBetaBHbWqobv+0QfOyTimaKmxA/6AJLQHCXsao7168Zc802eV86QW4BgYWU0McXJIofvNdsUWgUf4M378uDIIBeNS9LHfI3axizWv8EMSY46jyF2Qk9uzl0Nkp38TXq6vA6V8d6kDKuuSFVw2+0rV5LN0mlFjUUcOa+m3slWBH91uJJSX6OC48D5VD5OjLrQiWYDczEQqk1HUejgOxrL12x/XMylT0BBXQLz+hSrJaZrxkwvUmDRbIoAFoH72B7rXvdGWp2N3VR555gO2Y7AV67CSxDNIOPfly3ttjXW6kHMWm9GmBzhx9ZFR8cLvwUvl82tpYVFaOVaokRVIUHK3BsDABsXkTI8sst8ORR5rtK0+Dtyc9vw2hJqTfELLmGx1o6Qq1A0d5nTPLeveIFktf2ea89osI8jd75akL2zuuV/9djIXQBcUwZl1oVvtJMDkkapA7/5rcm4CgZezcJBh5bKNteo5yoFQ4AMr8Zr+6OtS6ZnK+2vCXEqNEIMZjeHJbPaqeZEenGmQhmUtG8+9QDvo14Y31T/YqXrx5doc2NvC0u8rfReyUzLsK6OLuMoglzpgSaIFngHKY7Q+Ja7yGoahzGtc6fUFvwpWAr9/CDl3QouJeTMGVhxyJ725n+1j78b7pqvxQNPo21PJkopAqezJsicZcfe435ei7EctYpAo+Wvdh9daIBAgUBQTqt4QoueQH7iWRVD62miJ4TUSXLzYEW41RqKXO1hDasCbzrXKLSRwhQdIEB5y41vn/RzJo438LxmP1+c7qNSg X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(478600001)(6486002)(38100700002)(66946007)(966005)(76116006)(8936002)(2616005)(8676002)(66556008)(41300700001)(91956017)(4326008)(64756008)(186003)(83380400001)(36756003)(66476007)(66446008)(71200400001)(33656002)(86362001)(38070700005)(5660300002)(6506007)(6512007)(316002)(2906002)(26005)(122000001)(53546011)(6916009)(30864003)(54906003)(45980500001)(579004)(559001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7005 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 77a9c828-5b36-4edf-af59-08da64dd0544 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OEpnqYNWPGqyZnDZjeZPmfwxv/lUkdXJMoWbFONlgtChKAAKfWja2eJTiKNpj1gMyNvl1RAsfbchjht9ESXxJGf0WHP0YBjzGaxZY1vf4dszgXoFwUPvW30gnU9DARHAsN+DPx6+zsnQ8nHcKcC001ZUbnnxrCxewEzNCSpxyqiFiYYQ7ABm/oBxTExC1SyRMLPTOpMa7vcT/fdb8nHNfW4wapnU8apNL2aWHE0Lsr100pW9vM0A0HcP2NGnzzgGgTqtFWgtW9wf2rqpCioSjzenSyYR7UuspQdYugXI4pPR+UHanj8aRj+6GzwTQUjpV5+nHoDyhFgKT8twhzf/BJfLrlTCKkxvPvpOzhe5PYpXCRK9U3z76W7j+TkS2aEJ+1WD8FUnr99rUhQyaPpoZH0yxDHSUlT8F4p/C4Qoo4jO9PBmFB8+16IKGtB4aeVF5k2RUPkYqoC3k0Bswae3X3Tp1edqgmvm/UY7Pdo6zq/3GJlsZXSEUmHO8JHqink4nmhBwas94ThOsSZNnwbYz8IPy2vATtemaaohOA1NN2klfAyORlMVClLcUUm4rAGKWySAzNu6edL4akoNpg8lsgGiPD1vvNBg7dgA6kkAYd8FWKli9YZJLwalEFukxNG8k31XVkkO11YLzxhIHWFnm0B8abj9OjsmcRy+wtbO73kUM2UD2bFXf9L1SpzQwzF11DO2gcd5Ye2c8ceWZzrwjREItz8JTVOCGRt6kJFN8eNdHNC1e8iwM+AZKA+j065iE0xqlnU7Sz3jJE2B5rQ5ULHMiZClXIXd7DcAlDq6kVOpSJ1xwntJBHKi5GEq4B9/MKJrUpzLTBJQ+N70gPQ/u6fpYY8limRKTcQ7yZbbc7o= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(136003)(376002)(396003)(36840700001)(46966006)(40470700004)(107886003)(8936002)(82740400003)(81166007)(2616005)(6862004)(478600001)(86362001)(53546011)(186003)(33656002)(6506007)(966005)(6486002)(41300700001)(30864003)(5660300002)(82310400005)(2906002)(83380400001)(6512007)(70206006)(4326008)(36756003)(70586007)(26005)(54906003)(8676002)(316002)(47076005)(336012)(356005)(36860700001)(40460700003)(40480700001)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 14:36:23.3530 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e0bda446-874e-4b23-eb80-08da64dd0f4b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2506 Hi Jens, Just to let you know, I am currently going through the spec in order to pro= perly review your implementation but this might take a bit of time as it is= quite long :-) Cheers Bertrand > On 22 Jun 2022, at 14:42, Jens Wiklander wrot= e: >=20 > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. >=20 > The implementation is the bare minimum to be able to communicate with > OP-TEE running as an SPMC at S-EL1. >=20 > This is loosely based on the TEE mediator framework and the OP-TEE > mediator. >=20 > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander > --- > SUPPORT.md | 7 + > tools/libs/light/libxl_arm.c | 3 + > tools/libs/light/libxl_types.idl | 1 + > tools/xl/xl_parse.c | 3 + > xen/arch/arm/Kconfig | 11 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain.c | 10 + > xen/arch/arm/domain_build.c | 1 + > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/domain.h | 4 + > xen/arch/arm/include/asm/ffa.h | 71 ++ > xen/arch/arm/vsmc.c | 17 +- > xen/include/public/arch-arm.h | 2 + > 13 files changed, 1811 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/ffa.c > create mode 100644 xen/arch/arm/include/asm/ffa.h >=20 > diff --git a/SUPPORT.md b/SUPPORT.md > index 70e98964cbc0..215bb3c9043b 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed throu= gh. >=20 > No support for QEMU backends in a 16K or 64K domain. >=20 > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > + > + Status, Arm64: Tech Preview > + > +There are still some code paths where a vCPU may hog a pCPU longer than > +necessary. The FF-A mediator is not yet implemented for Arm32. > + > ### ARM: Guest Device Tree support >=20 > Status: Supported > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } >=20 > + config->arch.ffa_enabled =3D > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > + > return 0; > } >=20 > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty= pes.idl > index 2a42da2f7d78..bf4544bef399 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -646,6 +646,7 @@ libxl_domain_build_info =3D Struct("domain_build_info= ",[ >=20 > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > + ("ffa_enabled", libxl_defbool), > ])), > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > ])), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); >=20 > parse_vkb_list(config, d_config); >=20 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index be9eff014120..e57e1d3757e2 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -139,6 +139,17 @@ config TEE >=20 > source "arch/arm/tee/Kconfig" >=20 > +config FFA > + bool "Enable FF-A mediator support" if EXPERT > + default n > + depends on ARM_64 > + help > + This option enables a minimal FF-A mediator. The mediator is > + generic as it follows the FF-A specification [1], but it only > + implements a small subset of the specification. > + > + [1] https://developer.arm.com/documentation/den0077/latest > + > endmenu >=20 > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index bb7a6151c13c..af0c69f793d4 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -20,6 +20,7 @@ obj-y +=3D domain_build.init.o > obj-y +=3D domctl.o > obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o > obj-y +=3D efi/ > +obj-$(CONFIG_FFA) +=3D ffa.o > obj-y +=3D gic.o > obj-y +=3D gic-v2.o > obj-$(CONFIG_GICV3) +=3D gic-v3.o > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 8110c1df8638..a3f00e7e234d 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > if ( (rc =3D tee_domain_init(d, config->arch.tee_type)) !=3D 0 ) > goto fail; >=20 > + if ( (rc =3D ffa_domain_init(d, config->arch.ffa_enabled)) !=3D 0 ) > + goto fail; > + > update_domain_wallclock_time(d); >=20 > /* > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struc= t page_list_head *list) > enum { > PROG_pci =3D 1, > PROG_tee, > + PROG_ffa, > PROG_xen, > PROG_page, > PROG_mapping, > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) >=20 > PROGRESS(tee): > ret =3D tee_relinquish_resources(d); > + if ( ret ) > + return ret; > + > + PROGRESS(ffa): > + ret =3D ffa_relinquish_resources(d); > if (ret ) > return ret; >=20 > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7ddd16c26da5..d708f76356f7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > dom0_cfg.arch.tee_type =3D tee_get_type(); > + dom0_cfg.arch.ffa_enabled =3D true; > dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >=20 > if ( iommu_enabled ) > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > new file mode 100644 > index 000000000000..3117ce5cec4d > --- /dev/null > +++ b/xen/arch/arm/ffa.c > @@ -0,0 +1,1683 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > + * > + * Copyright (C) 2022 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +/* Error codes */ > +#define FFA_RET_OK 0 > +#define FFA_RET_NOT_SUPPORTED -1 > +#define FFA_RET_INVALID_PARAMETERS -2 > +#define FFA_RET_NO_MEMORY -3 > +#define FFA_RET_BUSY -4 > +#define FFA_RET_INTERRUPTED -5 > +#define FFA_RET_DENIED -6 > +#define FFA_RET_RETRY -7 > +#define FFA_RET_ABORTED -8 > + > +/* FFA_VERSION helpers */ > +#define FFA_VERSION_MAJOR _AC(1,U) > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > +#define FFA_VERSION_MINOR _AC(1,U) > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > +#define MAKE_FFA_VERSION(major, minor) \ > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > + ((minor) & FFA_VERSION_MINOR_MASK)) > + > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > + FFA_VERSION_MINOR) > + > + > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) > + > +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareab= le */ > +#define FFA_NORMAL_MEM_REG_ATTR _AC(0x2f,U) > + > +/* Memory access permissions: Read-write */ > +#define FFA_MEM_ACC_RW _AC(0x2,U) > + > +/* Clear memory before mapping in receiver */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > +/* Relayer may time slice this operation */ > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > +/* Clear memory after receiver relinquishes it */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > + > +/* Share memory transaction */ > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (_AC(1,U) << 3) > + > +#define FFA_HANDLE_INVALID _AC(0xffffffffffffffff,ULL) > + > +/* Framework direct request/response */ > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > +#define FFA_MSG_TYPE_MASK _AC(0xFF,U); > +#define FFA_MSG_PSCI _AC(0x0,U) > +#define FFA_MSG_SEND_VM_CREATED _AC(0x4,U) > +#define FFA_MSG_RESP_VM_CREATED _AC(0x5,U) > +#define FFA_MSG_SEND_VM_DESTROYED _AC(0x6,U) > +#define FFA_MSG_RESP_VM_DESTROYED _AC(0x7,U) > + > +/* > + * Flags used for the FFA_PARTITION_INFO_GET return message: > + * BIT(0): Supports receipt of direct requests > + * BIT(1): Can send direct requests > + * BIT(2): Can send and receive indirect messages > + * BIT(3): Supports receipt of notifications > + * BIT(4-5): Partition ID is a PE endpoint ID > + */ > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0,U) > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1,U) > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2,U) > +#define FFA_PART_PROP_RECV_NOTIF BIT(3,U) > +#define FFA_PART_PROP_IS_PE_ID (_AC(0,U) << 4) > +#define FFA_PART_PROP_IS_SEPID_INDEP (_AC(1,U) << 4) > +#define FFA_PART_PROP_IS_SEPID_DEP (_AC(2,U) << 4) > +#define FFA_PART_PROP_IS_AUX_ID (_AC(3,U) << 4) > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6,U) > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7,U) > +#define FFA_PART_PROP_AARCH64_STATE BIT(8,U) > + > +/* Function IDs */ > +#define FFA_ERROR _AC(0x84000060,U) > +#define FFA_SUCCESS_32 _AC(0x84000061,U) > +#define FFA_SUCCESS_64 _AC(0xC4000061,U) > +#define FFA_INTERRUPT _AC(0x84000062,U) > +#define FFA_VERSION _AC(0x84000063,U) > +#define FFA_FEATURES _AC(0x84000064,U) > +#define FFA_RX_ACQUIRE _AC(0x84000084,U) > +#define FFA_RX_RELEASE _AC(0x84000065,U) > +#define FFA_RXTX_MAP_32 _AC(0x84000066,U) > +#define FFA_RXTX_MAP_64 _AC(0xC4000066,U) > +#define FFA_RXTX_UNMAP _AC(0x84000067,U) > +#define FFA_PARTITION_INFO_GET _AC(0x84000068,U) > +#define FFA_ID_GET _AC(0x84000069,U) > +#define FFA_SPM_ID_GET _AC(0x84000085,U) > +#define FFA_MSG_WAIT _AC(0x8400006B,U) > +#define FFA_MSG_YIELD _AC(0x8400006C,U) > +#define FFA_MSG_RUN _AC(0x8400006D,U) > +#define FFA_MSG_SEND2 _AC(0x84000086,U) > +#define FFA_MSG_SEND_DIRECT_REQ_32 _AC(0x8400006F,U) > +#define FFA_MSG_SEND_DIRECT_REQ_64 _AC(0xC400006F,U) > +#define FFA_MSG_SEND_DIRECT_RESP_32 _AC(0x84000070,U) > +#define FFA_MSG_SEND_DIRECT_RESP_64 _AC(0xC4000070,U) > +#define FFA_MEM_DONATE_32 _AC(0x84000071,U) > +#define FFA_MEM_DONATE_64 _AC(0xC4000071,U) > +#define FFA_MEM_LEND_32 _AC(0x84000072,U) > +#define FFA_MEM_LEND_64 _AC(0xC4000072,U) > +#define FFA_MEM_SHARE_32 _AC(0x84000073,U) > +#define FFA_MEM_SHARE_64 _AC(0xC4000073,U) > +#define FFA_MEM_RETRIEVE_REQ_32 _AC(0x84000074,U) > +#define FFA_MEM_RETRIEVE_REQ_64 _AC(0xC4000074,U) > +#define FFA_MEM_RETRIEVE_RESP _AC(0x84000075,U) > +#define FFA_MEM_RELINQUISH _AC(0x84000076,U) > +#define FFA_MEM_RECLAIM _AC(0x84000077,U) > +#define FFA_MEM_FRAG_RX _AC(0x8400007A,U) > +#define FFA_MEM_FRAG_TX _AC(0x8400007B,U) > +#define FFA_MSG_SEND _AC(0x8400006E,U) > +#define FFA_MSG_POLL _AC(0x8400006A,U) > + > +/* Partition information descriptor */ > +struct ffa_partition_info_1_0 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > +}; > + > +struct ffa_partition_info_1_1 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > + uint8_t uuid[16]; > +}; > + > +/* Constituent memory region descriptor */ > +struct ffa_address_range { > + uint64_t address; > + uint32_t page_count; > + uint32_t reserved; > +}; > + > +/* Composite memory region descriptor */ > +struct ffa_mem_region { > + uint32_t total_page_count; > + uint32_t address_range_count; > + uint64_t reserved; > + struct ffa_address_range address_range_array[]; > +}; > + > +/* Memory access permissions descriptor */ > +struct ffa_mem_access_perm { > + uint16_t endpoint_id; > + uint8_t perm; > + uint8_t flags; > +}; > + > +/* Endpoint memory access descriptor */ > +struct ffa_mem_access { > + struct ffa_mem_access_perm access_perm; > + uint32_t region_offs; > + uint64_t reserved; > +}; > + > +/* Lend, donate or share memory transaction descriptor */ > +struct ffa_mem_transaction_1_0 { > + uint16_t sender_id; > + uint8_t mem_reg_attr; > + uint8_t reserved0; > + uint32_t flags; > + uint64_t global_handle; > + uint64_t tag; > + uint32_t reserved1; > + uint32_t mem_access_count; > + struct ffa_mem_access mem_access_array[]; > +}; > + > +struct ffa_mem_transaction_1_1 { > + uint16_t sender_id; > + uint16_t mem_reg_attr; > + uint32_t flags; > + uint64_t global_handle; > + uint64_t tag; > + uint32_t mem_access_size; > + uint32_t mem_access_count; > + uint32_t mem_access_offs; > + uint8_t reserved[12]; > +}; > + > +/* > + * The parts needed from struct ffa_mem_transaction_1_0 or struct > + * ffa_mem_transaction_1_1, used to provide an abstraction of difference= in > + * data structures between version 1.0 and 1.1. This is just an internal > + * interface and can be changed without changing any ABI. > + */ > +struct ffa_mem_transaction_x { > + uint16_t sender_id; > + uint8_t mem_reg_attr; > + uint8_t flags; > + uint8_t mem_access_size; > + uint8_t mem_access_count; > + uint16_t mem_access_offs; > + uint64_t global_handle; > + uint64_t tag; > +}; > + > +/* Endpoint RX/TX descriptor */ > +struct ffa_endpoint_rxtx_descriptor_1_0 { > + uint16_t sender_id; > + uint16_t reserved; > + uint32_t rx_range_count; > + uint32_t tx_range_count; > +}; > + > +struct ffa_endpoint_rxtx_descriptor_1_1 { > + uint16_t sender_id; > + uint16_t reserved; > + uint32_t rx_region_offs; > + uint32_t tx_region_offs; > +}; > + > +struct ffa_ctx { > + void *rx; > + void *tx; > + struct page_info *rx_pg; > + struct page_info *tx_pg; > + unsigned int page_count; > + uint32_t guest_vers; > + bool tx_is_mine; > + bool interrupted; > + struct list_head frag_list; > + spinlock_t lock; > +}; > + > +struct ffa_shm_mem { > + struct list_head list; > + uint16_t sender_id; > + uint16_t ep_id; /* endpoint, the one lending */ > + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ > + unsigned int page_count; > + struct page_info *pages[]; > +}; > + > +struct mem_frag_state { > + struct list_head list; > + struct ffa_shm_mem *shm; > + uint32_t range_count; > + unsigned int current_page_idx; > + unsigned int frag_offset; > + unsigned int range_offset; > + uint8_t *buf; > + unsigned int buf_size; > + struct ffa_address_range range; > +}; > + > +/* > + * Our rx/rx buffer shared with the SPMC > + */ > +static uint32_t ffa_version; > +static uint16_t *subsr_vm_created; > +static unsigned int subsr_vm_created_count; > +static uint16_t *subsr_vm_destroyed; > +static unsigned int subsr_vm_destroyed_count; > +static void *ffa_rx; > +static void *ffa_tx; > +static unsigned int ffa_page_count; > +static DEFINE_SPINLOCK(ffa_buffer_lock); > + > +static LIST_HEAD(ffa_mem_list); > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > + > +static uint64_t next_handle =3D FFA_HANDLE_HYP_FLAG; > + > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > +{ > + return (uint64_t)reg0 << 32 | reg1; > +} > + > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > + uint64_t val) > +{ > + *reg0 =3D val >> 32; > + *reg1 =3D val; > +} > + > +static bool ffa_get_version(uint32_t *vers) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_VERSION, .a1 =3D FFA_MY_VERSION, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 =3D=3D FFA_RET_NOT_SUPPORTED ) > + { > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > + return false; > + } > + > + *vers =3D resp.a0; > + return true; > +} > + > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_features(uint32_t id) > +{ > + const struct arm_smccc_1_2_regs arg =3D { .a0 =3D FFA_FEATURES, .a1 = =3D id, }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + return get_ffa_ret_code(&resp); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + uint32_t ret =3D ffa_features(id); > + > + if (ret) > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id)= ; > + return !ret; > +} > + > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > + uint32_t page_count) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > +#ifdef CONFIG_ARM_64 > + .a0 =3D FFA_RXTX_MAP_64, > +#endif > +#ifdef CONFIG_ARM_32 > + .a0 =3D FFA_RXTX_MAP_32, > +#endif > + .a1 =3D tx_addr, .a2 =3D rx_addr, > + .a3 =3D page_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_RXTX_UNMAP, .a1 =3D vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_= t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_PARTITION_INFO_GET, .a1 =3D w1, .a2 =3D w2, .a3 =3D = w3, .a4 =3D w4, > + .a5 =3D w5, > + }; > + struct arm_smccc_1_2_regs resp; > + uint32_t ret; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + ret =3D get_ffa_ret_code(&resp); > + if ( !ret ) > + *count =3D resp.a2; > + > + return ret; > +} > + > +static uint32_t ffa_rx_release(void) > +{ > + const struct arm_smccc_1_2_regs arg =3D { .a0 =3D FFA_RX_RELEASE, }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > + register_t addr, uint32_t pg_count, > + uint64_t *handle) > +{ > + struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_SHARE_32, .a1 =3D tot_len, .a2 =3D frag_len, .a3= =3D addr, > + .a4 =3D pg_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + /* > + * For arm64 we must use 64-bit calling convention if the buffer isn= 't > + * passed in our tx buffer. > + */ > + if (sizeof(addr) > 4 && addr) > + arg.a0 =3D FFA_MEM_SHARE_64; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + *handle =3D reg_pair_to_64(resp.a3, resp.a2); > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + *handle =3D reg_pair_to_64(resp.a2, resp.a1); > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > + uint16_t sender_id) > +{ > + struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_FRAG_TX, .a1 =3D handle & UINT32_MAX, .a2 =3D ha= ndle >> 32, > + .a3 =3D frag_len, .a4 =3D (uint32_t)sender_id << 16, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > + uint32_t flags) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_RECLAIM, .a1 =3D handle_lo, .a2 =3D handle_hi, .= a3 =3D flags, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > + uint8_t msg) > +{ > + uint32_t exp_resp =3D FFA_MSG_FLAG_FRAMEWORK; > + int32_t res; > + > + if ( msg !=3D FFA_MSG_SEND_VM_CREATED && msg !=3DFFA_MSG_SEND_VM_DES= TROYED ) > + return FFA_RET_INVALID_PARAMETERS; > + > + if ( msg =3D=3D FFA_MSG_SEND_VM_CREATED ) > + exp_resp |=3D FFA_MSG_RESP_VM_CREATED; > + else > + exp_resp |=3D FFA_MSG_RESP_VM_DESTROYED; > + > + do { > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MSG_SEND_DIRECT_REQ_32, > + .a1 =3D sp_id, > + .a2 =3D FFA_MSG_FLAG_FRAMEWORK | msg, > + .a5 =3D vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 !=3D FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 !=3D ex= p_resp ) > + { > + /* > + * This is an invalid response, likely due to some error in = the > + * implementation of the ABI. > + */ > + return FFA_RET_INVALID_PARAMETERS; > + } > + res =3D resp.a3; > + } while ( res =3D=3D FFA_RET_INTERRUPTED || res =3D=3D FFA_RET_RETRY= ); > + > + return res; > +} > + > +static u16 get_vm_id(struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register= _t v1, > + register_t v2, register_t v3, register_t v4, regist= er_t v5, > + register_t v6, register_t v7) > +{ > + set_user_reg(regs, 0, v0); > + set_user_reg(regs, 1, v1); > + set_user_reg(regs, 2, v2); > + set_user_reg(regs, 3, v3); > + set_user_reg(regs, 4, v4); > + set_user_reg(regs, 5, v5); > + set_user_reg(regs, 6, v6); > + set_user_reg(regs, 7, v7); > +} > + > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_co= de) > +{ > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > +} > + > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle= _lo, > + uint32_t handle_hi, uint32_t frag_offset, > + uint16_t sender_id) > +{ > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > + (uint32_t)sender_id << 16, 0, 0, 0); > +} > + > +static void handle_version(struct cpu_user_regs *regs) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t vers =3D get_user_reg(regs, 1); > + > + if ( vers < FFA_VERSION_1_1 ) > + vers =3D FFA_VERSION_1_0; > + else > + vers =3D FFA_VERSION_1_1; > + > + ctx->guest_vers =3D vers; > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > +} > + > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > + register_t rx_addr, uint32_t page_count) > +{ > + uint32_t ret =3D FFA_RET_INVALID_PARAMETERS; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + struct page_info *tx_pg; > + struct page_info *rx_pg; > + p2m_type_t t; > + void *rx; > + void *tx; > + > + if ( !smccc_is_conv_64(fid) ) > + { > + tx_addr &=3D UINT32_MAX; > + rx_addr &=3D UINT32_MAX; > + } > + > + /* For now to keep things simple, only deal with a single page */ > + if ( page_count !=3D 1 ) > + return FFA_RET_NOT_SUPPORTED; > + > + /* Already mapped */ > + if ( ctx->rx ) > + return FFA_RET_DENIED; > + > + tx_pg =3D get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC)= ; > + if ( !tx_pg ) > + return FFA_RET_INVALID_PARAMETERS; > + /* Only normal RAM for now */ > + if (t !=3D p2m_ram_rw) > + goto err_put_tx_pg; > + > + rx_pg =3D get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC)= ; > + if ( !tx_pg ) > + goto err_put_tx_pg; > + /* Only normal RAM for now */ > + if ( t !=3D p2m_ram_rw ) > + goto err_put_rx_pg; > + > + tx =3D __map_domain_page_global(tx_pg); > + if ( !tx ) > + goto err_put_rx_pg; > + > + rx =3D __map_domain_page_global(rx_pg); > + if ( !rx ) > + goto err_unmap_tx; > + > + ctx->rx =3D rx; > + ctx->tx =3D tx; > + ctx->rx_pg =3D rx_pg; > + ctx->tx_pg =3D tx_pg; > + ctx->page_count =3D 1; > + ctx->tx_is_mine =3D true; > + return FFA_RET_OK; > + > +err_unmap_tx: > + unmap_domain_page_global(tx); > +err_put_rx_pg: > + put_page(rx_pg); > +err_put_tx_pg: > + put_page(tx_pg); > + return ret; > +} > + > +static uint32_t handle_rxtx_unmap(void) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t ret; > + > + if ( !ctx->rx ) > + return FFA_RET_INVALID_PARAMETERS; > + > + ret =3D ffa_rxtx_unmap(get_vm_id(d)); > + if ( ret ) > + return ret; > + > + unmap_domain_page_global(ctx->rx); > + unmap_domain_page_global(ctx->tx); > + put_page(ctx->rx_pg); > + put_page(ctx->tx_pg); > + ctx->rx =3D NULL; > + ctx->tx =3D NULL; > + ctx->rx_pg =3D NULL; > + ctx->tx_pg =3D NULL; > + ctx->page_count =3D 0; > + ctx->tx_is_mine =3D false; > + > + return FFA_RET_OK; > +} > + > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint= 32_t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + uint32_t ret =3D FFA_RET_DENIED; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + > + if ( !ffa_page_count ) > + return FFA_RET_DENIED; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || !ctx->tx_is_mine ) > + goto out; > + ret =3D ffa_partition_info_get(w1, w2, w3, w4, w5, count); > + if ( ret ) > + goto out; > + if ( ctx->guest_vers =3D=3D FFA_VERSION_1_0 ) > + { > + size_t n; > + struct ffa_partition_info_1_1 *src =3D ffa_rx; > + struct ffa_partition_info_1_0 *dst =3D ctx->rx; > + > + for ( n =3D 0; n < *count; n++ ) > + { > + dst[n].id =3D src[n].id; > + dst[n].execution_context =3D src[n].execution_context; > + dst[n].partition_properties =3D src[n].partition_properties; > + } > + } > + else > + { > + size_t sz =3D *count * sizeof(struct ffa_partition_info_1_1); > + > + memcpy(ctx->rx, ffa_rx, sz); > + } > + ffa_rx_release(); > + ctx->tx_is_mine =3D false; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static uint32_t handle_rx_release(void) > +{ > + uint32_t ret =3D FFA_RET_DENIED; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || ctx->tx_is_mine ) > + goto out; > + ret =3D FFA_RET_OK; > + ctx->tx_is_mine =3D true; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint3= 2_t fid) > +{ > + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; > + struct arm_smccc_1_2_regs resp =3D { }; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t src_dst; > + uint64_t mask; > + > + if ( smccc_is_conv_64(fid) ) > + mask =3D 0xffffffffffffffff; > + else > + mask =3D 0xffffffff; > + > + src_dst =3D get_user_reg(regs, 1); > + if ( (src_dst >> 16) !=3D get_vm_id(d) ) > + { > + resp.a0 =3D FFA_ERROR; > + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + arg.a1 =3D src_dst; > + arg.a2 =3D get_user_reg(regs, 2) & mask; > + arg.a3 =3D get_user_reg(regs, 3) & mask; > + arg.a4 =3D get_user_reg(regs, 4) & mask; > + arg.a5 =3D get_user_reg(regs, 5) & mask; > + arg.a6 =3D get_user_reg(regs, 6) & mask; > + arg.a7 =3D get_user_reg(regs, 7) & mask; > + > + while ( true ) > + { > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_INTERRUPT: > + ctx->interrupted =3D true; > + goto out; > + case FFA_ERROR: > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + case FFA_MSG_SEND_DIRECT_RESP_32: > + case FFA_MSG_SEND_DIRECT_RESP_64: > + goto out; > + default: > + /* Bad fid, report back. */ > + memset(&arg, 0, sizeof(arg)); > + arg.a0 =3D FFA_ERROR; > + arg.a1 =3D src_dst; > + arg.a2 =3D FFA_RET_NOT_SUPPORTED; > + continue; > + } > + } > + > +out: > + set_user_reg(regs, 0, resp.a0); > + set_user_reg(regs, 1, resp.a1 & mask); > + set_user_reg(regs, 2, resp.a2 & mask); > + set_user_reg(regs, 3, resp.a3 & mask); > + set_user_reg(regs, 4, resp.a4 & mask); > + set_user_reg(regs, 5, resp.a5 & mask); > + set_user_reg(regs, 6, resp.a6 & mask); > + set_user_reg(regs, 7, resp.a7 & mask); > +} > + > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > + struct ffa_address_range *range, uint32_t range= _count, > + unsigned int start_page_idx, > + unsigned int *last_page_idx) > +{ > + unsigned int pg_idx =3D start_page_idx; > + unsigned long gfn; > + unsigned int n; > + unsigned int m; > + p2m_type_t t; > + uint64_t addr; > + > + for ( n =3D 0; n < range_count; n++ ) > + { > + for ( m =3D 0; m < range[n].page_count; m++ ) > + { > + if ( pg_idx >=3D shm->page_count ) > + return FFA_RET_INVALID_PARAMETERS; > + > + addr =3D read_atomic(&range[n].address); > + gfn =3D gaddr_to_gfn(addr + m * PAGE_SIZE); > + shm->pages[pg_idx] =3D get_page_from_gfn(d, gfn, &t, P2M_ALL= OC); > + if ( !shm->pages[pg_idx] ) > + return FFA_RET_DENIED; > + pg_idx++; > + /* Only normal RAM for now */ > + if ( t !=3D p2m_ram_rw ) > + return FFA_RET_DENIED; > + } > + } > + > + *last_page_idx =3D pg_idx; > + > + return FFA_RET_OK; > +} > + > +static void put_shm_pages(struct ffa_shm_mem *shm) > +{ > + unsigned int n; > + > + for ( n =3D 0; n < shm->page_count && shm->pages[n]; n++ ) > + { > + put_page(shm->pages[n]); > + shm->pages[n] =3D NULL; > + } > +} > + > +static void init_range(struct ffa_address_range *addr_range, > + paddr_t pa) > +{ > + memset(addr_range, 0, sizeof(*addr_range)); > + addr_range->address =3D pa; > + addr_range->page_count =3D 1; > +} > + > +static int share_shm(struct ffa_shm_mem *shm) > +{ > + uint32_t max_frag_len =3D ffa_page_count * PAGE_SIZE; > + struct ffa_mem_transaction_1_1 *descr =3D ffa_tx; > + struct ffa_mem_access *mem_access_array; > + struct ffa_mem_region *region_descr; > + struct ffa_address_range *addr_range; > + paddr_t pa; > + paddr_t last_pa; > + unsigned int n; > + uint32_t frag_len; > + uint32_t tot_len; > + int ret; > + unsigned int range_count; > + unsigned int range_base; > + bool first; > + > + memset(descr, 0, sizeof(*descr)); > + descr->sender_id =3D shm->sender_id; > + descr->global_handle =3D shm->handle; > + descr->mem_reg_attr =3D FFA_NORMAL_MEM_REG_ATTR; > + descr->mem_access_count =3D 1; > + descr->mem_access_size =3D sizeof(*mem_access_array); > + descr->mem_access_offs =3D sizeof(*descr); > + mem_access_array =3D (void *)(descr + 1); > + region_descr =3D (void *)(mem_access_array + 1); > + > + memset(mem_access_array, 0, sizeof(*mem_access_array)); > + mem_access_array[0].access_perm.endpoint_id =3D shm->ep_id; > + mem_access_array[0].access_perm.perm =3D FFA_MEM_ACC_RW; > + mem_access_array[0].region_offs =3D (vaddr_t)region_descr - (vaddr_t= )ffa_tx; > + > + memset(region_descr, 0, sizeof(*region_descr)); > + region_descr->total_page_count =3D shm->page_count; > + > + region_descr->address_range_count =3D 1; > + last_pa =3D page_to_maddr(shm->pages[0]); > + for ( n =3D 1; n < shm->page_count; last_pa =3D pa, n++ ) > + { > + pa =3D page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE =3D=3D pa ) > + { > + continue; > + } > + region_descr->address_range_count++; > + } > + > + tot_len =3D sizeof(*descr) + sizeof(*mem_access_array) + > + sizeof(*region_descr) + > + region_descr->address_range_count * sizeof(*addr_range); > + > + addr_range =3D region_descr->address_range_array; > + frag_len =3D (vaddr_t)(addr_range + 1) - (vaddr_t)ffa_tx; > + last_pa =3D page_to_maddr(shm->pages[0]); > + init_range(addr_range, last_pa); > + first =3D true; > + range_count =3D 1; > + range_base =3D 0; > + for ( n =3D 1; n < shm->page_count; last_pa =3D pa, n++ ) > + { > + pa =3D page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE =3D=3D pa ) > + { > + addr_range->page_count++; > + continue; > + } > + > + if ( frag_len =3D=3D max_frag_len ) > + { > + if ( first ) > + { > + ret =3D ffa_mem_share(tot_len, frag_len, 0, 0, &shm->han= dle); > + first =3D false; > + } > + else > + { > + ret =3D ffa_mem_frag_tx(shm->handle, frag_len, shm->send= er_id); > + } > + if ( ret <=3D 0) > + return ret; > + range_base =3D range_count; > + range_count =3D 0; > + frag_len =3D sizeof(*addr_range); > + addr_range =3D ffa_tx; > + } > + else > + { > + frag_len +=3D sizeof(*addr_range); > + addr_range++; > + } > + init_range(addr_range, pa); > + range_count++; > + } > + > + if ( first ) > + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > + else > + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > +} > + > +static int read_mem_transaction(uint32_t ffa_vers, void *buf, size_t ble= n, > + struct ffa_mem_transaction_x *trans) > +{ > + uint16_t mem_reg_attr; > + uint32_t flags; > + uint32_t count; > + uint32_t offs; > + uint32_t size; > + > + if ( ffa_vers >=3D FFA_VERSION_1_1 ) > + { > + struct ffa_mem_transaction_1_1 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr =3D buf; > + trans->sender_id =3D read_atomic(&descr->sender_id); > + mem_reg_attr =3D read_atomic(&descr->mem_reg_attr); > + flags =3D read_atomic(&descr->flags); > + trans->global_handle =3D read_atomic(&descr->global_handle); > + trans->tag =3D read_atomic(&descr->tag); > + > + count =3D read_atomic(&descr->mem_access_count); > + size =3D read_atomic(&descr->mem_access_size); > + offs =3D read_atomic(&descr->mem_access_offs); > + } > + else > + { > + struct ffa_mem_transaction_1_0 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr =3D buf; > + trans->sender_id =3D read_atomic(&descr->sender_id); > + mem_reg_attr =3D read_atomic(&descr->mem_reg_attr); > + flags =3D read_atomic(&descr->flags); > + trans->global_handle =3D read_atomic(&descr->global_handle); > + trans->tag =3D read_atomic(&descr->tag); > + > + count =3D read_atomic(&descr->mem_access_count); > + size =3D sizeof(struct ffa_mem_access); > + offs =3D offsetof(struct ffa_mem_transaction_1_0, mem_access_arr= ay); > + } > + > + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_M= AX || > + count > UINT8_MAX || offs > UINT16_MAX ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Check that the endpoint memory access descriptor array fits */ > + if ( size * count + offs > blen ) > + return FFA_RET_INVALID_PARAMETERS; > + > + trans->mem_reg_attr =3D mem_reg_attr; > + trans->flags =3D flags; > + trans->mem_access_size =3D size; > + trans->mem_access_count =3D count; > + trans->mem_access_offs =3D offs; > + return 0; > +} > + > +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int off= s, > + unsigned int frag_len) > +{ > + struct domain *d =3D current->domain; > + unsigned int o =3D offs; > + unsigned int l; > + int ret; > + > + if ( frag_len < o ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Fill up the first struct ffa_address_range */ > + l =3D min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_= offset); > + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); > + s->range_offset +=3D l; > + o +=3D l; > + if ( s->range_offset !=3D sizeof(s->range) ) > + goto out; > + s->range_offset =3D 0; > + > + while ( true ) > + { > + ret =3D get_shm_pages(d, s->shm, &s->range, 1, s->current_page_i= dx, > + &s->current_page_idx); > + if ( ret ) > + return ret; > + if ( s->range_count =3D=3D 1 ) > + return 0; > + s->range_count--; > + if ( frag_len - o < sizeof(s->range) ) > + break; > + memcpy(&s->range, s->buf + o, sizeof(s->range)); > + o +=3D sizeof(s->range); > + } > + > + /* Collect any remaining bytes for the next struct ffa_address_range= */ > + s->range_offset =3D frag_len - o; > + memcpy(&s->range, s->buf + o, frag_len - o); > +out: > + s->frag_offset +=3D frag_len; > + return s->frag_offset; > +} > + > +static void handle_mem_share(struct cpu_user_regs *regs) > +{ > + uint32_t tot_len =3D get_user_reg(regs, 1); > + uint32_t frag_len =3D get_user_reg(regs, 2); > + uint64_t addr =3D get_user_reg(regs, 3); > + uint32_t page_count =3D get_user_reg(regs, 4); > + struct ffa_mem_transaction_x trans; > + struct ffa_mem_access *mem_access; > + struct ffa_mem_region *region_descr; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + struct ffa_shm_mem *shm =3D NULL; > + unsigned int last_page_idx =3D 0; > + uint32_t range_count; > + uint32_t region_offs; > + int ret =3D FFA_RET_DENIED; > + uint32_t handle_hi =3D 0; > + uint32_t handle_lo =3D 0; > + > + /* > + * We're only accepting memory transaction descriptors via the rx/tx > + * buffer. > + */ > + if ( addr ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + /* Check that fragment legnth doesn't exceed total length */ > + if ( frag_len > tot_len ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + spin_lock(&ctx->lock); > + > + if ( frag_len > ctx->page_count * PAGE_SIZE ) > + goto out_unlock; > + > + if ( !ffa_page_count ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out_unlock; > + } > + > + ret =3D read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &tr= ans); > + if ( ret ) > + goto out_unlock; > + > + if ( trans.mem_reg_attr !=3D FFA_NORMAL_MEM_REG_ATTR ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out; > + } > + > + /* Only supports sharing it with one SP for now */ > + if ( trans.mem_access_count !=3D 1 ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + if ( trans.sender_id !=3D get_vm_id(d) ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + /* Check that it fits in the supplied data */ > + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) > + goto out_unlock; > + > + mem_access =3D (void *)((vaddr_t)ctx->tx + trans.mem_access_offs); > + if ( read_atomic(&mem_access->access_perm.perm) !=3D FFA_MEM_ACC_RW = ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_offs =3D read_atomic(&mem_access->region_offs); > + if ( sizeof(*region_descr) + region_offs > frag_len ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_descr =3D (void *)((vaddr_t)ctx->tx + region_offs); > + range_count =3D read_atomic(®ion_descr->address_range_count); > + page_count =3D read_atomic(®ion_descr->total_page_count); > + > + shm =3D xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); > + if ( !shm ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out; > + } > + shm->sender_id =3D trans.sender_id; > + shm->ep_id =3D read_atomic(&mem_access->access_perm.endpoint_id); > + shm->page_count =3D page_count; > + > + if ( frag_len !=3D tot_len ) > + { > + struct mem_frag_state *s =3D xzalloc(struct mem_frag_state); > + > + if ( !s ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out; > + } > + s->shm =3D shm; > + s->range_count =3D range_count; > + s->buf =3D ctx->tx; > + s->buf_size =3D ffa_page_count * PAGE_SIZE; > + ret =3D add_mem_share_frag(s, sizeof(*region_descr) + region_of= fs, > + frag_len); > + if ( ret <=3D 0 ) > + { > + xfree(s); > + if ( ret < 0 ) > + goto out; > + } > + else > + { > + shm->handle =3D next_handle++; > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + list_add_tail(&s->list, &ctx->frag_list); > + } > + goto out_unlock; > + } > + > + /* > + * Check that the Composite memory region descriptor fits. > + */ > + if ( sizeof(*region_descr) + region_offs + > + range_count * sizeof(struct ffa_address_range) > frag_len ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + ret =3D get_shm_pages(d, shm, region_descr->address_range_array, ran= ge_count, > + 0, &last_page_idx); > + if ( ret ) > + goto out; > + if ( last_page_idx !=3D shm->page_count ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + /* Note that share_shm() uses our tx buffer */ > + spin_lock(&ffa_buffer_lock); > + ret =3D share_shm(shm); > + spin_unlock(&ffa_buffer_lock); > + if ( ret ) > + goto out; > + > + spin_lock(&ffa_mem_list_lock); > + list_add_tail(&shm->list, &ffa_mem_list); > + spin_unlock(&ffa_mem_list_lock); > + > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + > +out: > + if ( ret && shm ) > + { > + put_shm_pages(shm); > + xfree(shm); > + } > +out_unlock: > + spin_unlock(&ctx->lock); > + > + if ( ret > 0 ) > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.send= er_id); > + else if ( ret =3D=3D 0) > + set_regs_success(regs, handle_lo, handle_hi); > + else > + set_regs_error(regs, ret); > +} > + > +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, > + uint64_t handle) > +{ > + struct mem_frag_state *s; > + > + list_for_each_entry(s, &ctx->frag_list, list) > + if ( s->shm->handle =3D=3D handle ) > + return s; > + > + return NULL; > +} > + > +static void handle_mem_frag_tx(struct cpu_user_regs *regs) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t frag_len =3D get_user_reg(regs, 3); > + uint32_t handle_lo =3D get_user_reg(regs, 1); > + uint32_t handle_hi =3D get_user_reg(regs, 2); > + uint64_t handle =3D reg_pair_to_64(handle_hi, handle_lo); > + struct mem_frag_state *s; > + uint16_t sender_id =3D 0; > + int ret; > + > + spin_lock(&ctx->lock); > + s =3D find_frag_state(ctx, handle); > + if ( !s ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + sender_id =3D s->shm->sender_id; > + > + if ( frag_len > s->buf_size ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + ret =3D add_mem_share_frag(s, 0, frag_len); > + if ( ret =3D=3D 0 ) > + { > + /* Note that share_shm() uses our tx buffer */ > + spin_lock(&ffa_buffer_lock); > + ret =3D share_shm(s->shm); > + spin_unlock(&ffa_buffer_lock); > + if ( ret =3D=3D 0 ) > + { > + spin_lock(&ffa_mem_list_lock); > + list_add_tail(&s->shm->list, &ffa_mem_list); > + spin_unlock(&ffa_mem_list_lock); > + } > + else > + { > + put_shm_pages(s->shm); > + xfree(s->shm); > + } > + list_del(&s->list); > + xfree(s); > + } > + else if ( ret < 0 ) > + { > + put_shm_pages(s->shm); > + xfree(s->shm); > + list_del(&s->list); > + xfree(s); > + } > +out: > + spin_unlock(&ctx->lock); > + > + if ( ret > 0 ) > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id)= ; > + else if ( ret =3D=3D 0) > + set_regs_success(regs, handle_lo, handle_hi); > + else > + set_regs_error(regs, ret); > +} > + > +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) > +{ > + struct ffa_shm_mem *shm; > + uint32_t handle_hi; > + uint32_t handle_lo; > + int ret; > + > + spin_lock(&ffa_mem_list_lock); > + list_for_each_entry(shm, &ffa_mem_list, list) > + { > + if ( shm->handle =3D=3D handle ) > + goto found_it; > + } > + shm =3D NULL; > +found_it: > + spin_unlock(&ffa_mem_list_lock); > + > + if ( !shm ) > + return FFA_RET_INVALID_PARAMETERS; > + > + reg_pair_from_64(&handle_hi, &handle_lo, handle); > + ret =3D ffa_mem_reclaim(handle_lo, handle_hi, flags); > + if ( ret ) > + return ret; > + > + spin_lock(&ffa_mem_list_lock); > + list_del(&shm->list); > + spin_unlock(&ffa_mem_list_lock); > + > + put_shm_pages(shm); > + xfree(shm); > + > + return ret; > +} > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t count; > + uint32_t e; > + > + if ( !ctx ) > + return false; > + > + switch ( fid ) > + { > + case FFA_VERSION: > + handle_version(regs); > + return true; > + case FFA_ID_GET: > + set_regs_success(regs, get_vm_id(d), 0); > + return true; > + case FFA_RXTX_MAP_32: > +#ifdef CONFIG_ARM_64 > + case FFA_RXTX_MAP_64: > +#endif > + e =3D handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(r= egs, 2), > + get_user_reg(regs, 3)); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_RXTX_UNMAP: > + e =3D handle_rxtx_unmap(); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_PARTITION_INFO_GET: > + e =3D handle_partition_info_get(get_user_reg(regs, 1), > + get_user_reg(regs, 2), > + get_user_reg(regs, 3), > + get_user_reg(regs, 4), > + get_user_reg(regs, 5), &count); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, count, 0); > + return true; > + case FFA_RX_RELEASE: > + e =3D handle_rx_release(); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_MSG_SEND_DIRECT_REQ_32: > +#ifdef CONFIG_ARM_64 > + case FFA_MSG_SEND_DIRECT_REQ_64: > +#endif > + handle_msg_send_direct_req(regs, fid); > + return true; > + case FFA_MEM_SHARE_32: > +#ifdef CONFIG_ARM_64 > + case FFA_MEM_SHARE_64: > +#endif > + handle_mem_share(regs); > + return true; > + case FFA_MEM_RECLAIM: > + e =3D handle_mem_reclaim(reg_pair_to_64(get_user_reg(regs, 2), > + get_user_reg(regs, 1)), > + get_user_reg(regs, 3)); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_MEM_FRAG_TX: > + handle_mem_frag_tx(regs); > + return true; > + > + default: > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > + return false; > + } > +} > + > +int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + struct ffa_ctx *ctx; > + unsigned int n; > + unsigned int m; > + unsigned int c_pos; > + int32_t res; > + > + if ( !ffa_version || !ffa_enabled ) > + return 0; > + > + ctx =3D xzalloc(struct ffa_ctx); > + if ( !ctx ) > + return -ENOMEM; > + > + for ( n =3D 0; n < subsr_vm_created_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subsr_vm_created[n], get_vm_id(d)= , > + FFA_MSG_SEND_VM_CREATED); > + if ( res ) > + { > + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %= u to %u: res %d\n", > + get_vm_id(d), subsr_vm_created[n], res); > + c_pos =3D n; > + goto err; > + } > + } > + > + INIT_LIST_HEAD(&ctx->frag_list); > + > + d->arch.ffa =3D ctx; > + > + return 0; > + > +err: > + /* Undo any already sent vm created messaged */ > + for ( n =3D 0; n < c_pos; n++ ) > + for ( m =3D 0; m < subsr_vm_destroyed_count; m++ ) > + if ( subsr_vm_destroyed[m] =3D=3D subsr_vm_created[n] ) > + ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(= d), > + FFA_MSG_SEND_VM_DESTROYED); > + return -ENOMEM; > +} > + > +int ffa_relinquish_resources(struct domain *d) > +{ > + struct ffa_ctx *ctx =3D d->arch.ffa; > + unsigned int n; > + int32_t res; > + > + if ( !ctx ) > + return 0; > + > + for ( n =3D 0; n < subsr_vm_destroyed_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(= d), > + FFA_MSG_SEND_VM_DESTROYED); > + > + if ( res ) > + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_i= d %u to %u: res %d\n", > + get_vm_id(d), subsr_vm_destroyed[n], res); > + } > + > + XFREE(d->arch.ffa); > + > + return 0; > +} > + > +static bool __init init_subscribers(void) > +{ > + struct ffa_partition_info_1_1 *fpi; > + bool ret =3D false; > + uint32_t count; > + uint32_t e; > + uint32_t n; > + uint32_t c_pos; > + uint32_t d_pos; > + > + if ( ffa_version < FFA_VERSION_1_1 ) > + return true; > + > + e =3D ffa_partition_info_get(0, 0, 0, 0, 1, &count); > + ffa_rx_release(); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", (int)e= ); > + goto out; > + } > + > + fpi =3D ffa_rx; > + subsr_vm_created_count =3D 0; > + subsr_vm_destroyed_count =3D 0; > + for ( n =3D 0; n < count; n++ ) > + { > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) > + subsr_vm_created_count++; > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) > + subsr_vm_destroyed_count++; > + } > + > + if ( subsr_vm_created_count ) > + subsr_vm_created =3D xzalloc_array(uint16_t, subsr_vm_created_co= unt); > + if ( subsr_vm_destroyed_count ) > + subsr_vm_destroyed =3D xzalloc_array(uint16_t, subsr_vm_destroye= d_count); > + if ( (subsr_vm_created_count && !subsr_vm_created) || > + (subsr_vm_destroyed_count && !subsr_vm_destroyed) ) > + { > + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"= ); > + subsr_vm_created_count =3D 0; > + subsr_vm_destroyed_count =3D 0; > + XFREE(subsr_vm_created); > + XFREE(subsr_vm_destroyed); > + goto out; > + } > + > + for ( c_pos =3D 0, d_pos =3D 0, n =3D 0; n < count; n++ ) > + { > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) > + subsr_vm_created[c_pos++] =3D fpi[n].id; > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED= ) > + subsr_vm_destroyed[d_pos++] =3D fpi[n].id; > + } > + > + ret =3D true; > +out: > + ffa_rx_release(); > + return ret; > +} > + > +static int __init ffa_init(void) > +{ > + uint32_t vers; > + uint32_t e; > + unsigned int major_vers; > + unsigned int minor_vers; > + > + /* > + * psci_init_smccc() updates this value with what's reported by EL-3 > + * or secure world. > + */ > + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) > + { > + printk(XENLOG_ERR > + "ffa: unsupported SMCCC version %#x (need at least %#x)\n= ", > + smccc_ver, ARM_SMCCC_VERSION_1_2); > + return 0; > + } > + > + if ( !ffa_get_version(&vers) ) > + return 0; > + > + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) > + { > + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers)= ; > + return 0; > + } > + > + major_vers =3D (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR= _MASK; > + minor_vers =3D vers & FFA_VERSION_MINOR_MASK; > + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", > + FFA_VERSION_MAJOR, FFA_VERSION_MINOR); > + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > + major_vers, minor_vers); > + > + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || > + !check_mandatory_feature(FFA_RX_RELEASE) || > +#ifdef CONFIG_ARM_64 > + !check_mandatory_feature(FFA_RXTX_MAP_64) || > + !check_mandatory_feature(FFA_MEM_SHARE_64) || > +#endif > +#ifdef CONFIG_ARM_32 > + !check_mandatory_feature(FFA_RXTX_MAP_32) || > +#endif > + !check_mandatory_feature(FFA_RXTX_UNMAP) || > + !check_mandatory_feature(FFA_MEM_SHARE_32) || > + !check_mandatory_feature(FFA_MEM_FRAG_TX) || > + !check_mandatory_feature(FFA_MEM_RECLAIM) || > + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > + return 0; > + > + ffa_rx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_rx ) > + return 0; > + > + ffa_tx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_tx ) > + goto err_free_ffa_rx; > + > + e =3D ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", (int)e)= ; > + goto err_free_ffa_tx; > + } > + ffa_page_count =3D 1; > + ffa_version =3D vers; > + > + if ( !init_subscribers() ) > + goto err_free_ffa_tx; > + > + return 0; > + > +err_free_ffa_tx: > + free_xenheap_pages(ffa_tx, 0); > + ffa_tx =3D NULL; > +err_free_ffa_rx: > + free_xenheap_pages(ffa_rx, 0); > + ffa_rx =3D NULL; > + ffa_page_count =3D 0; > + ffa_version =3D 0; > + XFREE(subsr_vm_created); > + subsr_vm_created_count =3D 0; > + XFREE(subsr_vm_destroyed); > + subsr_vm_destroyed_count =3D 0; > + return 0; > +} > + > +__initcall(ffa_init); > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm= /domain.h > index ed63c2b6f91f..b3dee269bced 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -103,6 +103,10 @@ struct arch_domain > void *tee; > #endif >=20 > +#ifdef CONFIG_FFA > + void *ffa; > +#endif > + > bool directmap; > } __cacheline_aligned; >=20 > diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ff= a.h > new file mode 100644 > index 000000000000..4f4a739345bd > --- /dev/null > +++ b/xen/arch/arm/include/asm/ffa.h > @@ -0,0 +1,71 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A(FFA) mediator > + * > + * Copyright (C) 2021 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef __ASM_ARM_FFA_H__ > +#define __ASM_ARM_FFA_H__ > + > +#include > + > +#include > +#include > + > +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) > +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) > + > +static inline bool is_ffa_fid(uint32_t fid) > +{ > + uint32_t fn =3D fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >=3D FFA_FNUM_MIN_VALUE && fn <=3D FFA_FNUM_MAX_VALUE; > +} > + > +#ifdef CONFIG_FFA > +#define FFA_NR_FUNCS 11 > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); > +int ffa_domain_init(struct domain *d, bool ffa_enabled); > +int ffa_relinquish_resources(struct domain *d); > +#else > +#define FFA_NR_FUNCS 0 > + > +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t = fid) > +{ > + return false; > +} > + > +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + return 0; > +} > + > +static inline int ffa_relinquish_resources(struct domain *d) > +{ > + return 0; > +} > +#endif > + > +#endif /*__ASM_ARM_FFA_H__*/ > diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c > index 6f90c08a6304..34586025eff8 100644 > --- a/xen/arch/arm/vsmc.c > +++ b/xen/arch/arm/vsmc.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -32,7 +33,7 @@ > #define XEN_SMCCC_FUNCTION_COUNT 3 >=20 > /* Number of functions currently supported by Standard Service Service Ca= lls. */ > -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) > +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) >=20 > static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) > { > @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_re= gs *regs) > return do_vpsci_0_1_call(regs, fid); > } >=20 > +static bool is_psci_fid(uint32_t fid) > +{ > + uint32_t fn =3D fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >=3D 0 && fn <=3D 0x1fU; > +} > + > /* PSCI 0.2 interface and other Standard Secure Calls */ > static bool handle_sssc(struct cpu_user_regs *regs) > { > uint32_t fid =3D (uint32_t)get_user_reg(regs, 0); >=20 > - if ( do_vpsci_0_2_call(regs, fid) ) > - return true; > + if ( is_psci_fid(fid) ) > + return do_vpsci_0_2_call(regs, fid); > + > + if ( is_ffa_fid(fid) ) > + return ffa_handle_call(regs, fid); >=20 > switch ( fid ) > { > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.= h > index ab05fe12b0de..53f8d44a6a8e 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -318,6 +318,8 @@ struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > /* IN */ > + uint8_t ffa_enabled; > + /* IN */ > uint16_t tee_type; > /* IN */ > uint32_t nr_spis; > --=20 > 2.31.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:02:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:02:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366758.597675 (Exim 4.92) (envelope-from ) id 1oBdsX-0003o5-Ht; Wed, 13 Jul 2022 15:02:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366758.597675; Wed, 13 Jul 2022 15:02:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdsX-0003ny-Dc; Wed, 13 Jul 2022 15:02:17 +0000 Received: by outflank-mailman (input) for mailman id 366758; Wed, 13 Jul 2022 15:02:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdsV-0003ns-Ie for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:02:16 +0000 Received: from sonic314-19.consmr.mail.gq1.yahoo.com (sonic314-19.consmr.mail.gq1.yahoo.com [98.137.69.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c62c817d-02bc-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 17:02:13 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 15:02:11 +0000 Received: by hermes--production-bf1-58957fb66f-m4t8w (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 057c4b2c2f02905ae1f89a35d0a975ca; Wed, 13 Jul 2022 15:02:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c62c817d-02bc-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657724531; bh=2qU4AMVOzVh77LUM46UewjiYNReN14GbnEXIQ1mw9vo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=gclZJ41efqOPK58T/6vj8hjsBOrEKzvbj0HjjwAGeILZZaFVknY3syb4E4nzyOmrhuLQWR7dj0RZecq0wEONUqwsg4Q8hojTb2SLuKjkZtMOy9s0Hof1CSdznLWRxAb2kKDDpkN7EvFXSGp+2PEr+ccqtlsyUCipoB+afPAAD1ChPYeEcRzSqELPc8d38Wld8K47Yrq+CgBhQRP8bnYxfE2AGAsEPhWe1qCHO6qyZkSW87wO464lBOtEkGYVGl82itB3hpxTWJqDE307bn25qSlgqsWsu5i4EA9PHjf7gk6eJAWISoHZiJZb/bonbbe/GTCqrF/yygyiFfSrRLV42Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657724531; bh=moTNlFIVM88uUvO9QiA7OwTnLAbYXJBSXWVEVmIUCe0=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=X/Yd3yNqBTRP3KvTmhK1J5iW0aOGCIxX3ZR7Gh6M9oKudfbSXVi81DCe3ImNOuMPsU1TChIWAkVG2Fr8dBTGCLncTGxm6H1+FshcrcN9dyOY+/Iru/Vo7QEoxirNhQV7Bbjyx3QsQzY8SBidVPWj0AByQi5toNH9bWflZdgoM7gxMkZulkWVIWjQevUGJi+7SbVD+Dpo+xmwf97asxsh5F4mCpo1TmVCopSmiSyc/mgJQmIsRHZsFu+uoDoUI8uk1gwwvIU5qcrmPeb+WDK67UGicobWEQezdsZR6gwPNSOUeyRmG/61S4N7giJ7N+Uhv7j9VsxIUxb5ctFNn04mhg== X-YMail-OSG: qj0zHmYVM1nzHDV.djN2D6d0ziBgk39W6eLdzdBOwV3cBAch2depb_OulmFpDo3 hy9TS3Yi8WzQURpRy2XQF9od9F4IoRdg0BCQ.ZqY1mraIb_Uqu9JVmWz0ruoLcy1Ni8VWfy3LBG5 03qVBkkVB8tfjnmcbzpsqco2DLPOl5UBskIauYm66xKH0v4GPspscRqEAREyD1Kc4jk6.SLuVOAR 8FxUaT5lq5PgxaD62iaXMszSPnJdBObzl4TUAs5k01iIIFCKzrxqS49vD_fxsmFQ.BOjRP7v9f3E ybrZ74jMRIM3Y6AQ3qaPJmCkgzoVjoYj8K2XtWjJU1uzpSQvRzOZm4hfzZLQlKpUZu9z.Rdwmc9s gIDy32YVorkXKRiFqOEyEiIUztkyh4AyzUoiDvOi87mzz6sqPSVT7crwLrOMSlZift8GJSrB5f9C K27JjP9o3d4DnICCW7dWzmAvzH6PfnTl3JyUvAQlLdS_s0EVdMExIH5G22EzYwF8.43KDu473SMg b5mfsyYdcOu_Qy.y9UB3uykYrQ82fourZUoF2HwuBOvheugC4RVOmXQMTOPM.RG3SxvpPZhHwvE8 9IhPpJe.d.NkgW4tCbLAHKxDSqOB_GqKvKrCIP37Gyqga5rqngUtYy6.xiBMlyc7.tKT.utbEDpS 6wLdepQ39MGNZKEkb9FpnL7KAwrZNCPeokG.mG141f8Jr_eQjLWf4UWg2Oh_fpwYQrBeyw0.KqGT E_2maAjib5OJZH93pDv45UEfrZzlTTNQMPX2aBRuptOFbRl70r6mZ_pwD956x1b2dShm1_woHCvy 43lM2EDUKKJasYU7f8Ss9BwCobJAiHKXR9WsaEGPGW7C3viMqyT7EXc1Qzu1CtONLs4r8Cac.XVP akHvtKAWs7d34ad_T_M70PEYfgXYVq724AzLdZ2CWeqJ_XRAKHNc8FAhEA80nUePAyNzYZuOoPEN LJDDLSttPN5ec7OszVGxir0aQUDt8Ct8uAilVXQ6skQk9kcTztP2VuqFhxzPWD7rnvruXEANcfxy e9ZJwu9T53jfiUezyqy1edHFZXRDkrRVbiOP_npOOZe0Ql9ATP_weCPXMF5xP9NBfajUsFmQdUmO 7Y0udarIBFP_Za9P4BeYaKfxEBDMSHbc8RAsdqWejvZpmYlkcswQiraF1UBjaL2hvPtYEbNFR5ZE cjWBkyVfx15rrQ8hqFsh9j7LCc1zQkhKuj25o0GlwBdxuiQFtW80IZPt9vX9erX73_LVe1gXvWz6 ROnIyNMrmg8rx9XKcludYLCW1XPjwzZczdeS7mPpW6TT.jarajIiDo_W5Q_kc5LQnydfh6ExSkfU wpraA1uSJr1DbREEYKmJc8RurkCrHPnM9MoxwDnsTr1aiEy6kNvbha84tgeEuGreaSqZDVPJ5hRM fOR91Xi85AyyEB9aPL8FYbrm6TzF2UHwCCvzWxWzcTrcSXDa.D7inS9Pzefit.4GAMc..ebQW8aW 1TdsNi9vEwMJxJ6magoJeKniuzWqEf7WTUAI_WA3FBErHRLV6X9Hf.RiourXMTC6WiFMJVzR5Kbi N8eBi3QVGpH1BvBQ1_kndts40_tkeXY1PHRiWOVE6vONvR_yknU83_oYqesBkMcg_VeWzCxuXSb8 3epXYC0SphyEitHp00IGQL4toQlXX4lhWiEdpi7F.znFmBcnXWWeaTI6WlcO0qvbGvXRDDhWnzau Y3tsgUs2u9BoDLLbeiL7OkJ9rzyma0jqO4HiMqVGI_ifDkQLY5wlkaDDvN_PnvOI2tKR1jIv8UHQ oQu7TIPMq8wRwAASfsJB9I5mYg4xWiDQcsvvfIA0Rlj5dF6zxUjYOT0FShR2mWEbUz7UVLCrvlRh _ACOiqu.KS114L9T9BlIDv3J_GOPYH8u6GVQdVxezuMdCXSngM7ibb33UWAoOAsR8YyoynZVcO84 MLCLqdiHc1DGtLuIAqCyXsKF5GvYu9IiOI1FcOVHGiCl6Z4g- X-Sonic-MF: Message-ID: Date: Wed, 13 Jul 2022 11:02:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Juergen Gross , "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> <62e32913-cfcb-e0b0-2bbe-75cc8597951d@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7609 On 7/13/2022 9:52 AM, Jan Beulich wrote: > On 13.07.2022 15:49, Chuck Zmudzinski wrote: > > On 7/13/2022 9:34 AM, Jan Beulich wrote: > >> On 13.07.2022 13:10, Chuck Zmudzinski wrote: > >>> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > >>>> On 7/13/2022 5:09 AM, Jan Beulich wrote: > >>>>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: > >>>>>> On 7/13/22 2:18 AM, Jan Beulich wrote: > >>>>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > >>>>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>>>>>>> *Add the necessary code to incorporate the "nopat" fix > >>>>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>>>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>>>>>>> *Expand the commit message to include relevant parts of the commit > >>>>>>>> message of Jan Beulich's proposed patch for this problem > >>>>>>>> *Fix 'else if ... {' placement and indentation > >>>>>>>> *Remove indication the backport to stable branches is only back to 5.17.y > >>>>>>>> > >>>>>>>> I think these changes address all the comments on the original patch > >>>>>>>> > >>>>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>>>>>>> include Jan's idea for fixing "nopat" that was missing from the first > >>>>>>>> version of the patch. > >>>>>>> > >>>>>>> You've sufficiently altered this change to clearly no longer want my > >>>>>>> S-o-b; unfortunately in fact I think you broke things: > >>>>>> > >>>>>> Well, I hope we can come to an agreement so I have > >>>>>> your S-o-b. But that would probably require me to remove > >>>>>> Juergen's R-b. > >>>>>> > >>>>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>>>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>>>>>>> } > >>>>>>>> > >>>>>>>> - if (!pat) { > >>>>>>>> + if (!pat || pat_force_disabled) { > >>>>>>> > >>>>>>> By checking the new variable here ... > >>>>>>> > >>>>>>>> /* > >>>>>>>> * No PAT. Emulate the PAT table that corresponds to the two > >>>>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>>>>>>> */ > >>>>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>>>>> > >>>>>>> ... you put in place a software view which doesn't match hardware. I > >>>>>>> continue to think that ... > >>>>>>> > >>>>>>>> + } else if (!pat_bp_enabled) { > >>>>>>> > >>>>>>> ... the variable wants checking here instead (at which point, yes, > >>>>>>> this comes quite close to simply being a v2 of my original patch). > >>>>>>> > >>>>>>> By using !pat_bp_enabled here you actually broaden where the change > >>>>>>> would take effect. Iirc Boris had asked to narrow things (besides > >>>>>>> voicing opposition to this approach altogether). Even without that > >>>>>>> request I wonder whether you aren't going to far with this. > >>>>>>> > >>>>>>> Jan > >>>>>> > >>>>>> I thought about checking for the administrator's "nopat" > >>>>>> setting where you suggest which would limit the effect > >>>>>> of "nopat" to not reporting PAT as enabled to device > >>>>>> drivers who query for PAT availability using pat_enabled(). > >>>>>> The main reason I did not do that is that due to the fact > >>>>>> that we cannot write to the PAT MSR, we cannot really > >>>>>> disable PAT. But we come closer to respecting the wishes > >>>>>> of the administrator by configuring the caching modes as > >>>>>> if PAT is actually disabled by the hardware or firmware > >>>>>> when in fact it is not. > >>>>>> > >>>>>> What would you propose logging as a message when > >>>>>> we report PAT as disabled via pat_enabled()? The main > >>>>>> reason I did not choose to check the new variable in the > >>>>>> new 'else if' block is that I could not figure out what to > >>>>>> tell the administrator in that case. I think we would have > >>>>>> to log something like, "nopat is set, but we cannot disable > >>>>>> PAT, doing our best to disable PAT by not reporting PAT > >>>>>> as enabled via pat_enabled(), but that does not guarantee > >>>>>> that kernel drivers and components cannot use PAT if they > >>>>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > >>>>>> instead of pat_enabled()." However, I acknowledge WC mappings > >>>>>> would still be disabled because arch_can_pci_mmap_wc() will > >>>>>> be false if pat_enabled() is false. > >>>>>> > >>>>>> Perhaps we also need to log something if we keep the > >>>>>> check for "nopat" where I placed it. We could say something > >>>>>> like: "nopat is set, but we cannot disable hardware/firmware > >>>>>> PAT support, so we are emulating as if there is no PAT support > >>>>>> which puts in place a software view that does not match > >>>>>> hardware." > >>>>>> > >>>>>> No matter what, because we cannot write to PAT MSR in > >>>>>> the Xen PV case, we probably need to log something to > >>>>>> explain the problems associated with trying to honor the > >>>>>> administrator's request. Also, what log level should it be. > >>>>>> Should it be a pr_warn instead of a pr_info? > >>>>> > >>>>> I'm afraid I'm the wrong one to answer logging questions. As you > >>>>> can see from my original patch, I didn't add any new logging (and > >>>>> no addition was requested in the comments that I have got). I also > >>>>> don't think "nopat" has ever meant "disable PAT", as the feature > >>>>> is either there or not. Instead I think it was always seen as > >>>>> "disable fiddling with PAT", which by implication means using > >>>>> whatever is there (if the feature / MSR itself is available). > >>>> > >>>> IIRC, I do think I mentioned in the comments on your patch that > >>>> it would be preferable to mention in the commit message that > >>>> your patch would change the current behavior of "nopat" on > >>>> Xen. The question is, how much do we want to change the > >>>> current behavior of "nopat" on Xen. I think if we have to change > >>>> the current behavior of "nopat" on Xen and if we are going > >>>> to propagate that change to all current stable branches all > >>>> the way back to 4.9.y,, we better make a lot of noise about > >>>> what we are doing here. > >>>> > >>>> Chuck > >>> > >>> And in addition, if we are going to backport this patch to > >>> all current stable branches, we better have a really, really, > >>> good reason for changing the behavior of "nopat" on Xen. > >>> > >>> Does such a reason exist? > >> > >> Well, the simple reason is: It doesn't work the same way under Xen > >> and non-Xen (in turn because, before my patch or whatever equivalent > >> work, things don't work properly anyway, PAT-wise). Yet it definitely > >> ought to behave the same everywhere, imo. > >> > >> Jan > > > > IOW, you are saying PAT has been broken on Xen for a > > long time, and it is necessary to fix it now not only on > > master, but also on all the stable branches. > > > > Why is it necessary to do it on all the stable branches? > > I'm not saying that's _necessary_ (but I think it would make sense), > and I'm not the one to decide whether or how far to backport this. > > Jan What conclusion do you draw from these facts? 1. Linus' regression rule is a high priority in Linux 2. Security concerns are even a higher priority in Linux 3. You and I have been trying to fix a regression for the past two months 4. The ones who can fix the regression have not accepted our patches. 5. I have been asked to help backport my fix to all stable branches. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:03:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366762.597686 (Exim 4.92) (envelope-from ) id 1oBdtW-0004J2-Pk; Wed, 13 Jul 2022 15:03:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366762.597686; Wed, 13 Jul 2022 15:03:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtW-0004Iv-NC; Wed, 13 Jul 2022 15:03:18 +0000 Received: by outflank-mailman (input) for mailman id 366762; Wed, 13 Jul 2022 15:03:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtV-0004Gf-UP for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:03:18 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ece575fb-02bc-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 17:03:17 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id 9-20020a1c0209000000b003a2dfdebe47so1375811wmc.3 for ; Wed, 13 Jul 2022 08:03:17 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id i16-20020a05600c355000b003a2f88b2559sm2288417wmq.44.2022.07.13.08.03.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:03:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ece575fb-02bc-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vUSMEP+N59Z55GI7mKlPURS7RSp1YpBOBZ3Nkl5sGQ=; b=qWzbizZzaZCuU4bwNxUEaI90+O843mo9Bk+jOlJzRfoYY7JaGLjUm7Fn6VS8i4rwag MPfvK38R17bFiIrgZlldz3Y9OIBGc3J1S6+BsQfZKPA4+URFxzvjwxz5+eU33F4BVKox Egi6QF7C+SRR/mDn9R5O4kHqfVH1CTJH1pLJls7Hj0aEBLxI/hBK3EjohojiwTxAmUik yR7XGVMBxU1vidcYbQyjrnz7ye7fBcZch6+2gcbarkesby+Y4F03fhd2w2/UYzUVMNAY ky8HS9Vkd91REJg9o6IKwto9IJlFjLz8sLHHVYZUfywc2XoF0wayGGNQ9q39Fg+1DhzT Sk+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=8vUSMEP+N59Z55GI7mKlPURS7RSp1YpBOBZ3Nkl5sGQ=; b=k5Kq3cs3RE6VAvFnwDlynfov5mTY3M65qp98hukUXckri4q8Ave27OTadt/432wJKv lNeyDXVBEL7sv3eu7hbHYSh5NC7p5sLrGgezpOfazDlN57ZKItwhhPYdLKFbnZhcX24m vSMtiiKe48ADSe9zjQWFwQqP58zjc5ErdiQKTSpUjY1cNas47pDMNuvqYV0ZKjrpy5/Q FW+VsJhMQAAp9LYygz6ckmgc4DFokIeKki0SJcymfjGmdQeIouFk3APfQ0xUTMgFFGYJ fjG65J1YAAH8ijI5Iv6Dv9+xzqiZQ3/XDiS34Dj/DK7jxcHHfeFoRL98Wi45AY9Yc2oS ++gA== X-Gm-Message-State: AJIora+cul3BNG/B9hSNjCrrCY1eNdm0282tZhiwB2lZ/ewXL4Krxnzu QzdDwttwp56E7vpH83uPmNwxZUwij3YEFQ== X-Google-Smtp-Source: AGRyM1uHHcjXL2LmySNrs8AOH3vympeBWqndOIVTpv92oum6l90axYM4OeqrRloeR4TYuHpYMrDO9w== X-Received: by 2002:a05:600c:4c05:b0:3a2:e076:76ec with SMTP id d5-20020a05600c4c0500b003a2e07676ecmr10226834wmp.41.1657724596049; Wed, 13 Jul 2022 08:03:16 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Dmytro Semenets Subject: [PATCH v2 1/4] tools: remove xenstore entries on vchan server closure Date: Wed, 13 Jul 2022 18:03:08 +0300 Message-Id: <20220713150311.4152528-1-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko vchan server creates XenStore entries to advertise its event channel and ring, but those are not removed after the server quits. Add additional cleanup step, so those are removed, so clients do not try to connect to a non-existing server. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets --- tools/include/libxenvchan.h | 5 +++++ tools/libs/vchan/init.c | 24 ++++++++++++++++++++++++ tools/libs/vchan/io.c | 4 ++++ tools/libs/vchan/vchan.h | 31 +++++++++++++++++++++++++++++++ 4 files changed, 64 insertions(+) create mode 100644 tools/libs/vchan/vchan.h diff --git a/tools/include/libxenvchan.h b/tools/include/libxenvchan.h index d6010b145d..30cc73cf97 100644 --- a/tools/include/libxenvchan.h +++ b/tools/include/libxenvchan.h @@ -86,6 +86,11 @@ struct libxenvchan { int blocking:1; /* communication rings */ struct libxenvchan_ring read, write; + /** + * Base xenstore path for storing ring/event data used by the server + * during cleanup. + * */ + char *xs_path; }; /** diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index c8510e6ce9..9195bd3b98 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -46,6 +46,8 @@ #include #include +#include "vchan.h" + #ifndef PAGE_SHIFT #define PAGE_SHIFT 12 #endif @@ -251,6 +253,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base char ref[16]; char* domid_str = NULL; xs_transaction_t xs_trans = XBT_NULL; + + /* store the base path so we can clean up on server closure */ + ctrl->xs_path = strdup(xs_base); + if (!ctrl->xs_path) + return -1; + xs = xs_open(0); if (!xs) goto fail; @@ -298,6 +306,22 @@ retry_transaction: return ret; } +void close_xs_srv(struct libxenvchan *ctrl) +{ + struct xs_handle *xs; + + if (!ctrl->xs_path) + return; + + xs = xs_open(0); + if (xs) { + xs_rm(xs, XBT_NULL, ctrl->xs_path); + xs_close(xs); + } + + free(ctrl->xs_path); +} + static int min_order(size_t siz) { int rv = PAGE_SHIFT; diff --git a/tools/libs/vchan/io.c b/tools/libs/vchan/io.c index da303fbc01..1f201ad554 100644 --- a/tools/libs/vchan/io.c +++ b/tools/libs/vchan/io.c @@ -40,6 +40,8 @@ #include #include +#include "vchan.h" + #ifndef PAGE_SHIFT #define PAGE_SHIFT 12 #endif @@ -384,5 +386,7 @@ void libxenvchan_close(struct libxenvchan *ctrl) if (ctrl->gnttab) xengnttab_close(ctrl->gnttab); } + if (ctrl->is_server) + close_xs_srv(ctrl); free(ctrl); } diff --git a/tools/libs/vchan/vchan.h b/tools/libs/vchan/vchan.h new file mode 100644 index 0000000000..621016ef42 --- /dev/null +++ b/tools/libs/vchan/vchan.h @@ -0,0 +1,31 @@ +/** + * @file + * @section AUTHORS + * + * Copyright (C) 2021 EPAM Systems Inc. + * + * @section LICENSE + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; If not, see . + * + * @section DESCRIPTION + * + * This file contains common libxenvchan declarations. + */ +#ifndef LIBVCHAN_H +#define LIBVCHAN_H + +void close_xs_srv(struct libxenvchan *ctrl); + +#endif /* LIBVCHAN_H */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:03:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:03:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366763.597697 (Exim 4.92) (envelope-from ) id 1oBdtZ-0004ai-0n; Wed, 13 Jul 2022 15:03:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366763.597697; Wed, 13 Jul 2022 15:03:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtY-0004aX-UG; Wed, 13 Jul 2022 15:03:20 +0000 Received: by outflank-mailman (input) for mailman id 366763; Wed, 13 Jul 2022 15:03:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtX-0004E1-Bp for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:03:19 +0000 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [2a00:1450:4864:20::32e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ed9936f4-02bc-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 17:03:18 +0200 (CEST) Received: by mail-wm1-x32e.google.com with SMTP id c131-20020a1c3589000000b003a2cc290135so1385728wma.2 for ; Wed, 13 Jul 2022 08:03:18 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id i16-20020a05600c355000b003a2f88b2559sm2288417wmq.44.2022.07.13.08.03.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:03:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ed9936f4-02bc-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2qTbh4tpMS6j5x7TCTmXIv/EUZ/EAznJ0phLdG3pq58=; b=iqk18XYU09ziI6hvxC/mACUSQu3gtBcBKyI2t28pyOsVmd2qqsOxznhK4mccXncoWH rv3C3bSf7Mr93rAfWraT6UgpfFE4seVkMeQJN2ABtWKlFByaHIik+Xx/1ZAuTBLa3Jko QJf77w4MymJb3eAw7kmwzSvHeBy8jDw19IjR0T3MI9QJouGOjFtx0ssFrJKaygbjkf2y +djwGNhLvL3+kTRyfD66fzcJCGopGI8pSPHfomLU+U3W3jQ4+E/goZphyg1MbBr162zN YjMHq5as1pFBSpOvA4ytXncLbuoWAzR0HaAwWrUnhUMlOsG76sjY+X+w1Rk4PEmVxFfx UwPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2qTbh4tpMS6j5x7TCTmXIv/EUZ/EAznJ0phLdG3pq58=; b=h0ufmis/KeUT/QEryqpabdax9xZNtyRPjgSjVYjJXDPb8dRXsfAdlInUGqdkr1oG+W +8XxXbd27I5F0V5JFI75OIxvzAGC7CWBom0cxVmi3rCNkb5eV1bZVZJ7zTFcpiiJ8WeH LpNN1vrCc+dw+unhyx5P5Gq9DihRG1qLmPYTAT1mxAEFEodycCEaO9pk/YaV6EXG+x+/ R21eh6U3tj1ZRfnYm8DPuvl3W0c4p6z1FAttl/V7Ofo8ES56yy++osAQyR06bqAxBjTB xY0Z3l1RCebC1J+9la3Zuya9btqkFhvt1IuNO64gYI6o1ID4gEqiCXHrgrotxD2ZByJ6 +ckQ== X-Gm-Message-State: AJIora9N7To2k1F2ZrFGSZhsKO8T96m2CWWeq0JTdAuJ6zREwfd28W47 0WhbNjh0SfaySDEmFGc/xRESWUlyz6QrDg== X-Google-Smtp-Source: AGRyM1vrgMedj+a8MCm/bI2NCaPYuCffnBm8rnBSxlOJSk9yQTchuHbf0MAt8Tg2xNi+VEd1gu6NXw== X-Received: by 2002:a7b:cd84:0:b0:3a2:ddbe:220a with SMTP id y4-20020a7bcd84000000b003a2ddbe220amr4043631wmj.128.1657724597397; Wed, 13 Jul 2022 08:03:17 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Dmytro Semenets Subject: [PATCH v2 2/4] tools: allow vchan XenStore paths more then 64 bytes long Date: Wed, 13 Jul 2022 18:03:09 +0300 Message-Id: <20220713150311.4152528-2-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150311.4152528-1-dmitry.semenets@gmail.com> References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Current vchan implementation, while dealing with XenStore paths, allocates 64 bytes buffer on the stack which may not be enough for some use-cases. Make the buffer longer to respect maximum allowed XenStore path of XENSTORE_ABS_PATH_MAX. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Dmytro Semenets --- tools/libs/vchan/init.c | 28 ++++++++++++++++++++++------ 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/tools/libs/vchan/init.c b/tools/libs/vchan/init.c index 9195bd3b98..38658f30af 100644 --- a/tools/libs/vchan/init.c +++ b/tools/libs/vchan/init.c @@ -249,7 +249,7 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base int ret = -1; struct xs_handle *xs; struct xs_permissions perms[2]; - char buf[64]; + char *buf; char ref[16]; char* domid_str = NULL; xs_transaction_t xs_trans = XBT_NULL; @@ -259,6 +259,12 @@ static int init_xs_srv(struct libxenvchan *ctrl, int domain, const char* xs_base if (!ctrl->xs_path) return -1; + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) { + free(ctrl); + return 0; + } + xs = xs_open(0); if (!xs) goto fail; @@ -280,14 +286,14 @@ retry_transaction: goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ring_ref); - snprintf(buf, sizeof buf, "%s/ring-ref", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) goto fail_xs_open; snprintf(ref, sizeof ref, "%d", ctrl->event_port); - snprintf(buf, sizeof buf, "%s/event-channel", xs_base); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_base); if (!xs_write(xs, xs_trans, buf, ref, strlen(ref))) goto fail_xs_open; if (!xs_set_permissions(xs, xs_trans, buf, perms, 2)) @@ -303,6 +309,7 @@ retry_transaction: free(domid_str); xs_close(xs); fail: + free(buf); return ret; } @@ -419,13 +426,20 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, { struct libxenvchan *ctrl = malloc(sizeof(struct libxenvchan)); struct xs_handle *xs = NULL; - char buf[64]; + char *buf; char *ref; int ring_ref; unsigned int len; if (!ctrl) return 0; + + buf = malloc(XENSTORE_ABS_PATH_MAX); + if (!buf) { + free(ctrl); + return 0; + } + ctrl->ring = NULL; ctrl->event = NULL; ctrl->gnttab = NULL; @@ -436,8 +450,9 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, if (!xs) goto fail; + // find xenstore entry - snprintf(buf, sizeof buf, "%s/ring-ref", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/ring-ref", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -445,7 +460,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, free(ref); if (!ring_ref) goto fail; - snprintf(buf, sizeof buf, "%s/event-channel", xs_path); + snprintf(buf, XENSTORE_ABS_PATH_MAX, "%s/event-channel", xs_path); ref = xs_read(xs, 0, buf, &len); if (!ref) goto fail; @@ -475,6 +490,7 @@ struct libxenvchan *libxenvchan_client_init(struct xentoollog_logger *logger, out: if (xs) xs_close(xs); + free(buf); return ctrl; fail: libxenvchan_close(ctrl); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:03:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:03:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366764.597708 (Exim 4.92) (envelope-from ) id 1oBdtb-0004sE-8Y; Wed, 13 Jul 2022 15:03:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366764.597708; Wed, 13 Jul 2022 15:03:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtb-0004s7-5G; Wed, 13 Jul 2022 15:03:23 +0000 Received: by outflank-mailman (input) for mailman id 366764; Wed, 13 Jul 2022 15:03:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtZ-0004E1-Pf for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:03:22 +0000 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [2a00:1450:4864:20::42d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ee9aa0b0-02bc-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 17:03:20 +0200 (CEST) Received: by mail-wr1-x42d.google.com with SMTP id z12so15909197wrq.7 for ; Wed, 13 Jul 2022 08:03:20 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id i16-20020a05600c355000b003a2f88b2559sm2288417wmq.44.2022.07.13.08.03.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:03:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee9aa0b0-02bc-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EsW+L384H9oGADWE+CqepvUkn02l1CCLnWktdqKAGqM=; b=U6YVV2zkKesdwmuQPId5AKNpVp0y12qvB/89GBkocu9Xfdl+OvTe7vjN7UT0+Uisyq qisYEGkQV8e1/dlostnrkky1Z9ZJ20MFAJXGAV/Be3BhZzTrrl7pH8zuEV0JJlCzZVTC MYIozumwF/MjK1CF8OwyPp2J3zxSCUENNFG1jKsElQl3QOFcYHW8E8VKNbpGWA3okoXA dl0Xp4otjYt3+ehzFd28deNcH+Di59wJ5Lh9JgchsswpH+MR45JdY3QhKaV03rv4paAj cShF4xFBCdzXCm8JY12sPaQaEiwADMRpjFaHWmTTwgr24J2HY37ZMN+9YyOKLd0GYzFI r7yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EsW+L384H9oGADWE+CqepvUkn02l1CCLnWktdqKAGqM=; b=Y4HMctkYrmPWef7AW1K9USwZjbRHIRLfbadfvnlgsH0SMMW0DsgxUeepTH1rVrPzAN PyKSvwcju+SYH9PWY97DSGWY1e0QL3+Gz0gLiWMF2247mz4FcYyplw+/rrg91ZfuhTw3 5ML5iUW9kjTrBrpMtta494yjwoiy5kQyNUkEhe1kWNmMpHEKqqaTX3bKxEXmSg9y8D8a 9RDlPDshxSTmcJk7yuLhTzC8EQWlADc9g2aALWBWTHPxWeBjmNRULFoS6WZ5Cgjpr0S2 3pxPGTipkBBe2yzYkgsO+YOFAfZ1cqNfbrqAbWgkgjdBCJPEOzGCbWc/OqS3/YgKN1Ws BIUg== X-Gm-Message-State: AJIora98VL3hKpmKIuT2uoeFGPTHadD3UEXqY8wP9N8X9kj6uJ+qrMKP IVi2aeYzhjktmym7vkT/9aiypfUKCprZKg== X-Google-Smtp-Source: AGRyM1tkzeR+cvAc0+2NYewN61wH7yeWcVf+qbCI8jy+seAxYgbYoJz5CZ/kmfBE7z/zUqbNErguxw== X-Received: by 2002:a05:6000:1141:b0:21d:6ef3:e8c4 with SMTP id d1-20020a056000114100b0021d6ef3e8c4mr3870637wrx.573.1657724598919; Wed, 13 Jul 2022 08:03:18 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Anastasiia Lukianenko , Dmytro Semenets Subject: [PATCH v2 3/4] tools/libs/light: Add vchan support to libxl Date: Wed, 13 Jul 2022 18:03:10 +0300 Message-Id: <20220713150311.4152528-3-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150311.4152528-1-dmitry.semenets@gmail.com> References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add possibility to send commands from libxl and execute them on server side. Libxl vchan adds support for JSON messages processing. The using of libxl vchan is preventing the client from libxl from reading and writing from / to the local sysfs directly.To do this, the libxl vchan was added - instead of working with the read and write functions from / to the sysfs, functionality allows to send requests to the server, then receive and process the response. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko Signed-off-by: Dmytro Semenets --- tools/helpers/Makefile | 4 +- tools/libs/light/Makefile | 7 +- tools/libs/light/libxl_vchan.c | 488 +++++++++++++++++++++++++++++++++ tools/libs/light/libxl_vchan.h | 92 +++++++ tools/xl/Makefile | 3 +- 5 files changed, 588 insertions(+), 6 deletions(-) create mode 100644 tools/libs/light/libxl_vchan.c create mode 100644 tools/libs/light/libxl_vchan.h diff --git a/tools/helpers/Makefile b/tools/helpers/Makefile index 7f6c422440..3240ef2b6e 100644 --- a/tools/helpers/Makefile +++ b/tools/helpers/Makefile @@ -30,10 +30,10 @@ $(INIT_XENSTORE_DOMAIN_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h all: $(PROGS) xen-init-dom0: $(XEN_INIT_DOM0_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XEN_INIT_DOM0_OBJS) $(LDLIBS_libxenctrl) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenlight) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) init-xenstore-domain: $(INIT_XENSTORE_DOMAIN_OBJS) - $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(INIT_XENSTORE_DOMAIN_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenstore) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxenlight) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) .PHONY: install install: all diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index 453bea0067..ea8994af6d 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -77,6 +77,7 @@ SRCS-y += libxl.c SRCS-y += libxl_create.c SRCS-y += libxl_dm.c SRCS-y += libxl_pci.c +SRCS-y += libxl_vchan.c SRCS-y += libxl_dom.c SRCS-y += libxl_exec.c SRCS-y += libxl_xshelp.c @@ -175,7 +176,7 @@ LDUSELIBS-y += $(PTHREAD_LIBS) LDUSELIBS-y += -lyajl LDUSELIBS += $(LDUSELIBS-y) -$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) -include $(XEN_ROOT)/tools/config.h +$(LIB_OBJS) $(PIC_OBJS) $(LIBXL_TEST_OBJS): CFLAGS += $(CFLAGS_LIBXL) $(CFLAGS_libxenevtchn) -include $(XEN_ROOT)/tools/config.h $(ACPI_OBJS) $(ACPI_PIC_OBJS): CFLAGS += -I. -DLIBACPI_STDUTILS=\"$(CURDIR)/libxl_x86_acpi.h\" $(TEST_PROG_OBJS) _libxl.api-for-check: CFLAGS += $(CFLAGS_libxentoollog) $(CFLAGS_libxentoolcore) libxl_dom.o libxl_dom.opic: CFLAGS += -I$(XEN_ROOT)/tools # include libacpi/x86.h @@ -231,13 +232,13 @@ libxenlight_test.so: $(PIC_OBJS) $(LIBXL_TEST_OBJS) $(CC) $(LDFLAGS) -Wl,$(SONAME_LDFLAG) -Wl,libxenlight.so.$(MAJOR) $(SHLIB_LDFLAGS) -o $@ $^ $(LDUSELIBS) $(APPEND_LDFLAGS) test_%: test_%.o test_common.o libxenlight_test.so - $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $^ $(filter-out %libxenlight.so, $(LDLIBS_libxenlight)) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) libxl-save-helper: $(SAVE_HELPER_OBJS) libxenlight.so $(CC) $(LDFLAGS) -o $@ $(SAVE_HELPER_OBJS) $(LDLIBS_libxentoollog) $(LDLIBS_libxenctrl) $(LDLIBS_libxenguest) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) testidl: testidl.o libxenlight.so - $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ testidl.o $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxentoolcore) $(LDLIBS_libxenvchan) $(APPEND_LDFLAGS) install: installlocal $(LIBHEADERS) diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c new file mode 100644 index 0000000000..c87024f00f --- /dev/null +++ b/tools/libs/light/libxl_vchan.c @@ -0,0 +1,488 @@ +/* + * Vchan support for JSON messages processing + * + * Copyright (C) 2021 EPAM Systems Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU Lesser General Public License as published + * by the Free Software Foundation; version 2.1 only. with the special + * exception on linking described in file LICENSE. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Lesser General Public License for more details. + */ + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#define VCHAN_EOM "\r\n" +/* + * http://xenbits.xen.org/docs/unstable/misc/xenstore-paths.html + * 1.4.4 Domain Controlled Paths + * 1.4.4.1 ~/data [w] + * A domain writable path. Available for arbitrary domain use. + */ +#define VCHAN_SRV_DIR "/local/domain" + +struct vchan_state { + struct libxenvchan *ctrl; + + /* Server domain ID. */ + libxl_domid domid; + + /* XenStore path of the server with the ring buffer and event channel. */ + char *xs_path; + + int select_fd; + + /* GC used for state's lifetime allocations, such as rx_buf. */ + libxl__gc *gc; + /* Receive buffer. */ + char *rx_buf; + /* Current allocated size. */ + size_t rx_buf_size; + /* Actual data in the buffer. */ + size_t rx_buf_used; + + /* YAJL generator used to parse and create requests/replies. */ + yajl_gen gen; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen gen, + const char *field, char *val) +{ + libxl__json_object *result; + + libxl__yajl_gen_asciiz(gen, field); + result = libxl__json_object_alloc(gc, JSON_STRING); + result->u.string = val; + return libxl__json_object_to_yajl_gen(gc, gen, result); +} + +static libxl__json_object *libxl__vchan_arg_new(libxl__gc *gc, + libxl__json_node_type type, + libxl__json_object *args, + char *key) +{ + libxl__json_map_node *arg; + libxl__json_object *obj; + + obj = libxl__json_object_alloc(gc, type); + + GCNEW(arg); + + arg->map_key = key; + arg->obj = obj; + + flexarray_append(args->u.map, arg); + + return obj; +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_STRING, args, key); + + obj->u.string = val; +} + +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_BOOL, args, key); + + obj->u.b = val; +} + +static void reset_yajl_generator(struct vchan_state *state) +{ + yajl_gen_clear(state->gen); + yajl_gen_reset(state->gen, NULL); +} + +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf = NULL; + size_t len = 0; + + yajl_gen_get_buf(gen, &buf, &len); + LOG(DEBUG, "%s\n", buf); +} + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state) +{ + vchan_dump_gen(gc, state->gen); +} + +/* + * Find a JSON object and store it in o_r. + * return ERROR_NOTFOUND if no object is found. + */ +static int vchan_get_next_msg(libxl__gc *gc, struct vchan_state *state, + libxl__json_object **o_r) +{ + size_t len; + char *end = NULL; + const size_t eoml = sizeof(VCHAN_EOM) - 1; + libxl__json_object *o = NULL; + + if (!state->rx_buf_used) + return ERROR_NOTFOUND; + + /* Search for the end of a message which is CRLF. */ + end = memmem(state->rx_buf, state->rx_buf_used, VCHAN_EOM, eoml); + if (!end) + return ERROR_NOTFOUND; + + len = (end - state->rx_buf) + eoml; + + LOGD(DEBUG, state->domid, "parsing %zuB: '%.*s'", len, (int)len, + state->rx_buf); + + /* Replace \r by \0 so that libxl__json_parse can use strlen */ + state->rx_buf[len - eoml] = '\0'; + + o = libxl__json_parse(gc, state->rx_buf); + state->rx_buf_used -= len; + if (!o) { + LOGD(ERROR, state->domid, "Parse error"); + /* + * In case of parsing error get back to a known state: + * reset the buffer and continue reading. + */ + return ERROR_INVAL; + } + + memmove(state->rx_buf, state->rx_buf + len, state->rx_buf_used); + + LOGD(DEBUG, state->domid, "JSON object received: %s", JSON(o)); + + *o_r = o; + + return 0; +} + +static int vchan_process_packet(libxl__gc *gc, struct vchan_info *vchan, + libxl__json_object **resp_result) +{ + while (true) { + struct vchan_state *state = vchan->state; + int rc; + ssize_t r; + + if (!libxenvchan_is_open(state->ctrl)) + return ERROR_FAIL; + + /* Check if the buffer still has space or increase its size. */ + if (state->rx_buf_size - state->rx_buf_used < vchan->receive_buf_size) { + size_t newsize = state->rx_buf_size * 2 + vchan->receive_buf_size; + + if (newsize > vchan->max_buf_size) { + LOGD(ERROR, state->domid, + "receive buffer is too big (%zu > %zu)", + newsize, vchan->max_buf_size); + return ERROR_NOMEM; + } + + state->rx_buf_size = newsize; + state->rx_buf = libxl__realloc(state->gc, state->rx_buf, + state->rx_buf_size); + } + + do { + libxl__json_object *msg; + + r = libxenvchan_read(state->ctrl, + state->rx_buf + state->rx_buf_used, + state->rx_buf_size - state->rx_buf_used); + + if (r < 0) { + LOGED(ERROR, state->domid, "error reading"); + return ERROR_FAIL; + } else if (r == 0) + continue; + + LOG(DEBUG, "received %zdB: '%.*s'", r, + (int)r, state->rx_buf + state->rx_buf_used); + + state->rx_buf_used += r; + assert(state->rx_buf_used <= state->rx_buf_size); + + /* parse rx buffer to find one json object */ + rc = vchan_get_next_msg(gc, state, &msg); + if ((rc == ERROR_INVAL) || (rc == ERROR_NOTFOUND)) + continue; + if (rc) + return rc; + + if (resp_result) + return vchan->handle_response(gc, msg, resp_result); + else { + reset_yajl_generator(state); + return vchan->handle_request(gc, state->gen, msg); + } + } while (libxenvchan_data_ready(state->ctrl)); + } + + return 0; +} + +static int vchan_write(libxl__gc *gc, struct vchan_state *state, char *cmd) +{ + size_t len; + int ret; + + len = strlen(cmd); + while (len) { + ret = libxenvchan_write(state->ctrl, cmd, len); + if (ret < 0) { + LOGE(ERROR, "vchan write failed"); + return ERROR_FAIL; + } + cmd += ret; + len -= ret; + } + return 0; +} + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args) +{ + libxl__json_object *result; + char *request; + int ret; + + reset_yajl_generator(vchan->state); + request = vchan->prepare_request(gc, vchan->state->gen, cmd, args); + if (!request) + return NULL; + + ret = vchan_write(gc, vchan->state, request); + if (ret < 0) + return NULL; + + ret = vchan_write(gc, vchan->state, VCHAN_EOM); + if (ret < 0) + return NULL; + + ret = vchan_process_packet(gc, vchan, &result); + if (ret < 0) + return NULL; + + return result; +} + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan) +{ + char *json_str; + int ret; + + ret = vchan_process_packet(gc, vchan, NULL); + if (ret) + return ret; + + json_str = vchan->prepare_response(gc, vchan->state->gen); + if (!json_str) + return ERROR_INVAL; + + ret = vchan_write(gc, vchan->state, json_str); + if (ret) + return ret; + + return vchan_write(gc, vchan->state, VCHAN_EOM); +} + +static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file) +{ + char **domains; + unsigned int i, n; + libxl_domid domid = DOMID_INVALID; + + domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); + if (!n) + goto out; + + for (i = 0; i < n; i++) { + const char *tmp; + int d; + + if (sscanf(domains[i], "%d", &d) != 1) + continue; + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); + /* Found the domain where the server lives. */ + if (tmp) { + domid = d; + break; + } + } + +out: + return domid; +} + +static int vchan_init_client(libxl__gc *gc, struct vchan_state *state, + bool is_server) +{ + if (is_server) { + state->ctrl = libxenvchan_server_init(NULL, state->domid, + state->xs_path, 0, 0); + if (!state->ctrl) { + perror("Couldn't initialize vchan server"); + exit(1); + } + + } else { + state->ctrl = libxenvchan_client_init(CTX->lg, state->domid, + state->xs_path); + if (!state->ctrl) { + LOGE(ERROR, "Couldn't initialize vchan client"); + return ERROR_FAIL; + } + } + + state->ctrl->blocking = 1; + state->select_fd = libxenvchan_fd_for_select(state->ctrl); + if (state->select_fd < 0) { + LOGE(ERROR, "Couldn't read file descriptor for vchan client"); + return ERROR_FAIL; + } + + LOG(DEBUG, "Initialized vchan %s, XenSore at %s", + is_server ? "server" : "client", state->xs_path); + + return 0; +} + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server) +{ + struct vchan_state *state; + yajl_gen gen; + int ret; + + gen = libxl_yajl_gen_alloc(NULL); + if (!gen) { + LOGE(ERROR, "Failed to allocate yajl generator"); + return NULL; + } + +#if HAVE_YAJL_V2 + /* Disable beautify for data */ + yajl_gen_config(gen, yajl_gen_beautify, 0); +#endif + + state = libxl__zalloc(gc, sizeof(*state)); + state->domid = domid; + state->xs_path = vchan_xs_path; + state->gc = gc; + ret = vchan_init_client(gc, state, is_server); + if (ret) { + state = NULL; + yajl_gen_free(gen); + } + + state->gen = gen; + + return state; +} + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name) +{ + return GCSPRINTF(VCHAN_SRV_DIR "/%d/data/%s", domid, srv_name); +} + +/* + * Wait for the server to create the ring and event channel: + * since the moment we create a XS folder to the moment we start + * watching it the server may have already created the ring and + * event channel entries. Thus, we cannot watch reliably here without + * races, so poll for both entries to be created. + */ +static int vchan_wait_server_available(libxl__gc *gc, const char *xs_path) +{ + char *xs_ring, *xs_evt; + int timeout_ms = 5000; + + xs_ring = GCSPRINTF("%s/ring-ref", xs_path); + xs_evt = GCSPRINTF("%s/event-channel", xs_path); + + while (timeout_ms) { + unsigned int len; + void *file; + int entries = 0; + + file = xs_read(CTX->xsh, XBT_NULL, xs_ring, &len); + if (file) { + entries++; + free(file); + } + + file = xs_read(CTX->xsh, XBT_NULL, xs_evt, &len); + if (file) { + entries++; + free(file); + } + + if (entries == 2) + return 0; + + timeout_ms -= 10; + usleep(10000); + } + + return ERROR_TIMEDOUT; +} + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) +{ + libxl_domid domid; + char *xs_path, *vchan_xs_path; + libxl_uuid uuid; + libxl_ctx *ctx = libxl__gc_owner(gc); + + domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name); + if (domid == DOMID_INVALID) { + LOGE(ERROR, "Can't find vchan server"); + return NULL; + } + + xs_path = vchan_get_server_xs_path(gc, domid, srv_name); + LOG(DEBUG, "vchan server at %s\n", xs_path); + + /* Generate unique client id. */ + libxl_uuid_generate(&uuid); + + vchan_xs_path = GCSPRINTF("%s/" LIBXL_UUID_FMT, xs_path, + LIBXL_UUID_BYTES((uuid))); + + if (!xs_mkdir(ctx->xsh, XBT_NULL, vchan_xs_path)) { + LOG(ERROR, "Can't create xs_dir at %s", vchan_xs_path); + return NULL; + } + + if (vchan_wait_server_available(gc, vchan_xs_path)) { + LOG(ERROR, "Failed to wait for the server to come up at %s", + vchan_xs_path); + return NULL; + } + + return vchan_init_new_state(gc, domid, vchan_xs_path, false); +} + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state) +{ + if (!state) + return; + + LOG(DEBUG, "Closing vchan"); + libxenvchan_close(state->ctrl); + + yajl_gen_free(state->gen); +} diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h new file mode 100644 index 0000000000..0968875298 --- /dev/null +++ b/tools/libs/light/libxl_vchan.h @@ -0,0 +1,92 @@ +/* + Common definitions for JSON messages processing by vchan + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef LIBXL_VCHAN_H +#define LIBXL_VCHAN_H + +#include + +struct vchan_state; + +struct vchan_info { + struct vchan_state *state; + + /* Process request and produce the result by adding json-objects to gen .*/ + int (*handle_request)(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request); + /* Convert the prepared response into JSON string. */ + char *(*prepare_response)(libxl__gc *gc, yajl_gen gen); + + /* Prepare request as JSON string which will be sent. */ + char *(*prepare_request)(libxl__gc *gc, yajl_gen gen, char *request, + libxl__json_object *args); + /* Handle response and produce the output suitable for the requester. */ + int (*handle_response)(libxl__gc *gc, const libxl__json_object *response, + libxl__json_object **result); + + /* Handle new client connection on the server side. */ + int (*handle_new_client)(libxl__gc *gc); + + /* Buffer info. */ + size_t receive_buf_size; + size_t max_buf_size; +}; + +int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen hand, + const char *field, char *val); + +static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) +{ + return libxl__json_object_alloc(gc, JSON_MAP); +} + +void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, + char *key, char *val); +void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, + char *key, bool val); + +libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, + char *cmd, libxl__json_object *args); + +void vchan_reset_generator(struct vchan_state *state); + +int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan); + +char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name); + +struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, + char *vchan_xs_path, bool is_server); + +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name); + +void vchan_fini_one(libxl__gc *gc, struct vchan_state *state); + +void vchan_dump_state(libxl__gc *gc, struct vchan_state *state); +void vchan_dump_gen(libxl__gc *gc, yajl_gen gen); + +#endif /* LIBXL_VCHAN_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/xl/Makefile b/tools/xl/Makefile index b7f439121a..5dfff7fc6f 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -15,6 +15,7 @@ LDFLAGS += $(PTHREAD_LDFLAGS) CFLAGS_XL += $(CFLAGS_libxenlight) CFLAGS_XL += $(CFLAGS_libxenutil) CFLAGS_XL += -Wshadow +CFLAGS_XL += $(CFLAGS_libxenvchan) XL_OBJS-$(CONFIG_X86) = xl_psr.o XL_OBJS = xl.o xl_cmdtable.o xl_sxp.o xl_utils.o $(XL_OBJS-y) @@ -33,7 +34,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:03:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:03:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366765.597719 (Exim 4.92) (envelope-from ) id 1oBdtg-0005Ea-PL; Wed, 13 Jul 2022 15:03:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366765.597719; Wed, 13 Jul 2022 15:03:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdtg-0005EP-MC; Wed, 13 Jul 2022 15:03:28 +0000 Received: by outflank-mailman (input) for mailman id 366765; Wed, 13 Jul 2022 15:03:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdte-0004Gf-E1 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:03:27 +0000 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [2a00:1450:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f0b5fa7e-02bc-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 17:03:23 +0200 (CEST) Received: by mail-wr1-x432.google.com with SMTP id d16so15881048wrv.10 for ; Wed, 13 Jul 2022 08:03:23 -0700 (PDT) Received: from localhost.localdomain ([91.219.254.75]) by smtp.gmail.com with ESMTPSA id i16-20020a05600c355000b003a2f88b2559sm2288417wmq.44.2022.07.13.08.03.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Jul 2022 08:03:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0b5fa7e-02bc-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1t/r7Z1a+hfnt9hQpupUQYuausKRlncsenXFzN5C8E=; b=hqvzHvobw2K0zvMnGHhYBZ2g8KIV+Rw1QicGiL2aEeMah+nQ3kmxw+ha2V6jvsnned 2aiU0I37VA14yYZU4IdhtpTJggivdIHmVLKtgE7/D5HUyZE231nytH1KlCp+qIsjJeJw DFOsQ5TRj+ObQDz6aqMrfq9aLHxV8+pCdLGL7VgXUDUtZHP8k1eaAFxewtfmkyXtgvYX WYcL5MvCo92ZzZVzPIv7IoQpgyq2UYLesq5iuULoNnJZrQRtmSF7agitdgXUlndMvhiE b50sfob6MkgU3pdJyKAa5GSXyhqGdYwNW9qSf4oVviRwSg+VuvlcIHQuylN+gW4p/q6r aHLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1t/r7Z1a+hfnt9hQpupUQYuausKRlncsenXFzN5C8E=; b=cK2SeGpYRdqcFWa4vuUITuuuHdGFuHz3xKhifvddiP6ABzQDTqu3luLeRZ1/JXxuni vUrfFdbNusSvzD4Z0me/jKrtw32GoRYrKvIv9KCPPR9ZvuFHy9SA2hT2Z9f9WwXQNFfo FwgFaVmDmvW5WrPRwM3DdJ+lmRXzfdmZEpT0A/QyDNglDc3jLbqWC7yooWrEF5FxTykn OFGLGq0mMpgfD0UcACHqFYoDZvF1YC63GCSYwKH/ruLgMIKbuyFG8aRh1tBEnZXy4HIv GHofYTJ7esclCPcFb9cPpEmKTEg8CJP1ir5mhX5Amux1WcTULaHKrNjOK30lAdIdx7Kw 6gVg== X-Gm-Message-State: AJIora/g5jchvFfbH5QHbNb4PIUGYHUBvxLu0DcbIHLalWf3cZoTRrPX 8hOelpW/0GPkIrbM8K418GdSklWcfN9yCg== X-Google-Smtp-Source: AGRyM1sv5SLDpaxOoKbPuXKYKUZAf/+g96Id+rOp48WGbfbGUTCervFtLcw8Lejraja0h+3etHiyIw== X-Received: by 2002:a5d:5222:0:b0:21d:92a5:2b5d with SMTP id i2-20020a5d5222000000b0021d92a52b5dmr3765518wra.377.1657724600772; Wed, 13 Jul 2022 08:03:20 -0700 (PDT) From: dmitry.semenets@gmail.com To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Wei Liu , Anthony PERARD , Juergen Gross , Dmytro Semenets , Anastasiia Lukianenko , Volodymyr Babchuk Subject: [PATCH v2 4/4] tools/xl: Add pcid daemon to xl Date: Wed, 13 Jul 2022 18:03:11 +0300 Message-Id: <20220713150311.4152528-4-dmitry.semenets@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220713150311.4152528-1-dmitry.semenets@gmail.com> References: <20220713150311.4152528-1-dmitry.semenets@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add pcid daemon (based on vchan-node2) implements pcid protocol. Protocol is OS independed and should work on ane supported OS. Add essential functionality to handle pcid protocol: - define required constants - prepare for handling remote requests - prepare and send an error packet pcid server used if domain has passthrough PCI controller and we wants assign some device to other domain. pcid server should be launched in domain owns the PCI controller and process request from other domains. Message exchange imnplementation based on JSON via libvchan. Supported messages: - make_assignable - revert_assignable - is_device_assigned - resource_list - reset_device - write_bdf Signed-off-by: Dmytro Semenets Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Anastasiia Lukianenko Signed-off-by: Volodymyr Babchuk --- docs/man/xl-pci-configuration.5.pod | 14 + tools/configure | 8 +- tools/configure.ac | 1 + tools/hotplug/FreeBSD/rc.d/xlpcid.in | 75 ++ tools/hotplug/Linux/init.d/xlpcid.in | 76 ++ tools/hotplug/Linux/systemd/Makefile | 1 + .../hotplug/Linux/systemd/xenpcid.service.in | 10 + tools/hotplug/NetBSD/rc.d/xlpcid.in | 75 ++ tools/include/libxl.h | 2 +- tools/include/pcid.h | 228 ++++ tools/libs/light/Makefile | 1 + tools/libs/light/libxl_pci.c | 701 +++++------ tools/libs/light/libxl_pcid.c | 1095 +++++++++++++++++ tools/libs/light/libxl_types.idl | 2 + tools/libs/light/libxl_vchan.c | 64 +- tools/libs/light/libxl_vchan.h | 7 +- tools/libs/util/libxlu_pci.c | 6 +- tools/xl/Makefile | 4 +- tools/xl/xl.h | 1 + tools/xl/xl_cmdtable.c | 7 + tools/xl/xl_parse.c | 1 + tools/xl/xl_pci.c | 4 +- tools/xl/xl_pcid.c | 81 ++ 23 files changed, 2070 insertions(+), 394 deletions(-) create mode 100644 tools/hotplug/FreeBSD/rc.d/xlpcid.in create mode 100644 tools/hotplug/Linux/init.d/xlpcid.in create mode 100644 tools/hotplug/Linux/systemd/xenpcid.service.in create mode 100644 tools/hotplug/NetBSD/rc.d/xlpcid.in create mode 100644 tools/include/pcid.h create mode 100644 tools/libs/light/libxl_pcid.c create mode 100644 tools/xl/xl_pcid.c diff --git a/docs/man/xl-pci-configuration.5.pod b/docs/man/xl-pci-configuration.5.pod index db3360307c..aacbd52c86 100644 --- a/docs/man/xl-pci-configuration.5.pod +++ b/docs/man/xl-pci-configuration.5.pod @@ -215,4 +215,18 @@ required to look up the B in the list of assignable devices. =back +=item B=I + +=over 4 + +=item Description + +This is domain name with pcid daemon running + +=item Default Value + +None. Domain name with pcid daemon selects automatically + +=back + =back diff --git a/tools/configure b/tools/configure index 45db3a5d5c..6124b2ab47 100755 --- a/tools/configure +++ b/tools/configure @@ -2452,7 +2452,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu -ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/xenstored/oxenstored.conf" +ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/FreeBSD/rc.d/xlpcid hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xlpcid hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain hotplug/NetBSD/rc.d/xlpcid ocaml/xenstored/oxenstored.conf" ac_config_headers="$ac_config_headers config.h" @@ -10053,7 +10053,7 @@ fi if test "x$systemd" = "xy"; then : - ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service" + ac_config_files="$ac_config_files hotplug/Linux/systemd/proc-xen.mount hotplug/Linux/systemd/var-lib-xenstored.mount hotplug/Linux/systemd/xen-init-dom0.service hotplug/Linux/systemd/xen-qemu-dom0-disk-backend.service hotplug/Linux/systemd/xen-watchdog.service hotplug/Linux/systemd/xenconsoled.service hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service hotplug/Linux/systemd/xenpcid.service" fi @@ -10917,8 +10917,10 @@ do "../config/Tools.mk") CONFIG_FILES="$CONFIG_FILES ../config/Tools.mk" ;; "hotplug/FreeBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xencommons" ;; "hotplug/FreeBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xendriverdomain" ;; + "hotplug/FreeBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/FreeBSD/rc.d/xlpcid" ;; "hotplug/Linux/init.d/sysconfig.xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xencommons" ;; "hotplug/Linux/init.d/sysconfig.xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/sysconfig.xendomains" ;; + "hotplug/Linux/init.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xlpcid" ;; "hotplug/Linux/init.d/xen-watchdog") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xen-watchdog" ;; "hotplug/Linux/init.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xencommons" ;; "hotplug/Linux/init.d/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/init.d/xendomains" ;; @@ -10929,6 +10931,7 @@ do "hotplug/Linux/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/xendomains" ;; "hotplug/NetBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xencommons" ;; "hotplug/NetBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xendriverdomain" ;; + "hotplug/NetBSD/rc.d/xlpcid") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xlpcid" ;; "ocaml/xenstored/oxenstored.conf") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/oxenstored.conf" ;; "config.h") CONFIG_HEADERS="$CONFIG_HEADERS config.h" ;; "hotplug/Linux/systemd/proc-xen.mount") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/proc-xen.mount" ;; @@ -10940,6 +10943,7 @@ do "hotplug/Linux/systemd/xendomains.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendomains.service" ;; "hotplug/Linux/systemd/xendriverdomain.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xendriverdomain.service" ;; "hotplug/Linux/systemd/xenstored.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenstored.service" ;; + "hotplug/Linux/systemd/xenpcid.service") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/xenpcid.service" ;; *) as_fn_error $? "invalid argument: \`$ac_config_target'" "$LINENO" 5;; esac diff --git a/tools/configure.ac b/tools/configure.ac index f29c319b42..a874e96608 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -477,6 +477,7 @@ AS_IF([test "x$systemd" = "xy"], [ hotplug/Linux/systemd/xendomains.service hotplug/Linux/systemd/xendriverdomain.service hotplug/Linux/systemd/xenstored.service + hotplug/Linux/systemd/xenpcid.service ]) ]) diff --git a/tools/hotplug/FreeBSD/rc.d/xlpcid.in b/tools/hotplug/FreeBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..2817bfaeed --- /dev/null +++ b/tools/hotplug/FreeBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/hotplug/Linux/init.d/xlpcid.in b/tools/hotplug/Linux/init.d/xlpcid.in new file mode 100644 index 0000000000..dce660098c --- /dev/null +++ b/tools/hotplug/Linux/init.d/xlpcid.in @@ -0,0 +1,76 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac + diff --git a/tools/hotplug/Linux/systemd/Makefile b/tools/hotplug/Linux/systemd/Makefile index a5d41d86ef..a3820e5f0a 100644 --- a/tools/hotplug/Linux/systemd/Makefile +++ b/tools/hotplug/Linux/systemd/Makefile @@ -13,6 +13,7 @@ XEN_SYSTEMD_SERVICE += xendomains.service XEN_SYSTEMD_SERVICE += xen-watchdog.service XEN_SYSTEMD_SERVICE += xen-init-dom0.service XEN_SYSTEMD_SERVICE += xendriverdomain.service +XEN_SYSTEMD_SERVICE += xenpcid.service ALL_XEN_SYSTEMD = $(XEN_SYSTEMD_MODULES) \ $(XEN_SYSTEMD_MOUNT) \ diff --git a/tools/hotplug/Linux/systemd/xenpcid.service.in b/tools/hotplug/Linux/systemd/xenpcid.service.in new file mode 100644 index 0000000000..49c57f635a --- /dev/null +++ b/tools/hotplug/Linux/systemd/xenpcid.service.in @@ -0,0 +1,10 @@ +[Unit] +Description=Xen PCI host daemon +ConditionVirtualization=xen + +[Service] +Type=forking +ExecStart=@sbindir@/xl pcid + +[Install] +WantedBy=multi-user.target diff --git a/tools/hotplug/NetBSD/rc.d/xlpcid.in b/tools/hotplug/NetBSD/rc.d/xlpcid.in new file mode 100644 index 0000000000..2817bfaeed --- /dev/null +++ b/tools/hotplug/NetBSD/rc.d/xlpcid.in @@ -0,0 +1,75 @@ +#! /bin/bash +# +# xlpcid +# +# description: Run xlpcid daemon +### BEGIN INIT INFO +# Provides: xlpcid +# Short-Description: Start/stop xlpcid +# Description: Run xlpcid daemon +### END INIT INFO +# + +. @XEN_SCRIPT_DIR@/hotplugpath.sh + +xencommons_config=@CONFIG_DIR@/@CONFIG_LEAF_DIR@ + +test -f $xencommons_config/xencommons && . $xencommons_config/xencommons + +XLPCID_PIDFILE="@XEN_RUN_DIR@/xlpcid.pid" + +# Source function library. +if [ -e /etc/init.d/functions ] ; then + . /etc/init.d/functions +elif [ -e /lib/lsb/init-functions ] ; then + . /lib/lsb/init-functions + success () { + log_success_msg $* + } + failure () { + log_failure_msg $* + } +else + success () { + echo $* + } + failure () { + echo $* + } +fi + +start() { + echo Starting xl pcid... + ${sbindir}/xl pcid --pidfile=$XLPCID_PIDFILE $XLPCID_ARGS +} + +stop() { + echo Stopping xl pcid... + if read 2>/dev/null <$XLPCID_PIDFILE pid; then + kill $pid + while kill -9 $pid >/dev/null 2>&1; do sleep 1; done + rm -f $XLPCID_PIDFILE + fi +} + +case "$1" in + start) + start + ;; + stop) + stop + ;; + restart) + stop + start + ;; + status) + ;; + condrestart) + stop + start + ;; + *) + echo $"Usage: $0 {start|stop|status|restart|condrestart}" + exit 1 +esac diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 310a3468a1..67ba46c78f 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -2465,7 +2465,7 @@ int libxl_device_events_handler(libxl_ctx *ctx, */ int libxl_device_pci_assignable_add(libxl_ctx *ctx, libxl_device_pci *pci, int rebind); int libxl_device_pci_assignable_remove(libxl_ctx *ctx, libxl_device_pci *pci, int rebind); -libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num); +libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num, libxl_domid backend_domid); void libxl_device_pci_assignable_list_free(libxl_device_pci *list, int num); /* CPUID handling */ diff --git a/tools/include/pcid.h b/tools/include/pcid.h new file mode 100644 index 0000000000..2c1bd0727e --- /dev/null +++ b/tools/include/pcid.h @@ -0,0 +1,228 @@ +/* + Common definitions for Xen PCI client-server protocol. + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . +*/ + +#ifndef PCID_H +#define PCID_H + +#define PCID_SRV_NAME "pcid" +#define PCID_XS_TOKEN "pcid-token" + +#define PCI_RECEIVE_BUFFER_SIZE 4096 +#define PCI_MAX_SIZE_RX_BUF MB(1) + +/* + ******************************************************************************* + * Common request and response structures used be the pcid remote protocol are + * described below. + ******************************************************************************* + * Request: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | cmd | string | String identifying the command | + * +-------------+--------------+----------------------------------------------+ + * + * Response: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | resp | string | Command string as in the request | + * +-------------+--------------+----------------------------------------------+ + * | error | string | "okay", "failed" | + * +-------------+--------------+----------------------------------------------+ + * | error_desc | string | Optional error description string | + * +-------------+--------------+----------------------------------------------+ + * + * Notes. + * 1. Every request and response must contain the above mandatory structures. + * 2. In case if a bad packet or an unknown command received by the server side + * a valid reply with the corresponding error code must be sent to the client. + * + * Requests and responses, which require SBDF as part of their payload, must + * use the following convention for encoding SBDF value: + * + * pci_device object: + * +-------------+--------------+----------------------------------------------+ + * | Field | Type | Comment | + * +-------------+--------------+----------------------------------------------+ + * | sbdf | string | SBDF string in form SSSS:BB:DD.F | + * +-------------+--------------+----------------------------------------------+ + */ + +#define PCID_MSG_FIELD_CMD "cmd" + +#define PCID_MSG_FIELD_RESP "resp" +#define PCID_MSG_FIELD_ERR "error" +#define PCID_MSG_FIELD_ERR_DESC "error_desc" + +/* pci_device object fields. */ +#define PCID_MSG_FIELD_SBDF "sbdf" + +#define PCID_MSG_ERR_OK "okay" +#define PCID_MSG_ERR_FAILED "failed" +#define PCID_MSG_ERR_NA "NA" + +#define PCID_SBDF_FMT "%04x:%02x:%02x.%01x" + +/* + ******************************************************************************* + * List assignable devices + * + * This command lists PCI devices that can be passed through to a guest domain. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "list_assignable". + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "list_assignable". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | devices | list | List of of pci_device objects | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_LIST_ASSIGNABLE "list_assignable" +#define PCID_MSG_FIELD_DEVICES "devices" + +/* + ******************************************************************************* + * Make device assignable + * + * This command makes given device assignable by ensuring that OS + * will not try to access it. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "make_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to save original driver name, + * so device later can be rebound back. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "make_assignable". + */ +#define PCID_CMD_MAKE_ASSIGNABLE "make_assignable" +#define PCID_MSG_FIELD_REBIND "rebind" + +/* + ******************************************************************************* + * Revert device from assignable state + * + * This command reverts effect of "make_assignable" command. Basically, + * now device can be used by OS again. + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "revert_assignable". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "rebind" = true if daemon needs to rebind device back to it's + * original driver, which name was saved by "make_assignable" command + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "revert_assignable". + */ +#define PCID_CMD_REVERT_ASSIGNABLE "revert_assignable" + +/* + ******************************************************************************* + * Check is device assigned + * + * This command checks device is assigned + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "is_device_assigned". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "is_device_assigned". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | result | bool | true if device assigned | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_IS_ASSIGNED "is_device_assigned" +#define PCID_MSG_FIELD_RESULT "result" + +/* + ******************************************************************************* + * Get device resources + * + * This command returns resource list of device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "resource_list". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "resource_list". + * Command specific response data: + * +-------------+--------------+----------------------------------------------+ + * | resources | map | key 'iomem' - list of memory regions | + * | | | key 'irqs' - list of irqs | + * +-------------+--------------+----------------------------------------------+ + */ +#define PCID_CMD_RESOURCE_LIST "resource_list" +/* Arguments */ +#define PCID_MSG_FIELD_DOMID "domid" +/* Result */ +#define PCID_MSG_FIELD_RESOURCES "resources" +#define PCID_RESULT_KEY_IOMEM "iomem" +#define PCID_RESULT_KEY_IRQS "irqs" + +/* + ******************************************************************************* + * Write BDF values to the pciback sysfs path + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "write_bdf". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * - "name" name of sysfs file of pciback driver + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "write_bdf". + */ +#define PCID_CMD_WRITE_BDF "write_bdf" +#define PCID_MSG_FIELD_NAME "name" + +/* + ******************************************************************************* + * Reset PCI device + * + * This command resets PCI device + * + * Request (see other mandatory fields above): + * - "cmd" field of the request must be set to "reset_device". + * - "sbdf" SBDF of the device in format defined by PCID_SBDF_FMT. + * + * Response (see other mandatory fields above): + * - "resp" field of the response must be set to "reset_device". + */ +#define PCID_CMD_RESET_DEVICE "reset_device" + +int libxl_pcid_process(libxl_ctx *ctx); + +#endif /* PCID_H */ + +/* + * Local variables: + * mode: C + * c-file-style: "linux" + * indent-tabs-mode: t + * c-basic-offset: 8 + * tab-width: 8 + * End: + */ diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile index ea8994af6d..b64658e72f 100644 --- a/tools/libs/light/Makefile +++ b/tools/libs/light/Makefile @@ -77,6 +77,7 @@ SRCS-y += libxl.c SRCS-y += libxl_create.c SRCS-y += libxl_dm.c SRCS-y += libxl_pci.c +SRCS-y += libxl_pcid.c SRCS-y += libxl_vchan.c SRCS-y += libxl_dom.c SRCS-y += libxl_exec.c diff --git a/tools/libs/light/libxl_pci.c b/tools/libs/light/libxl_pci.c index 4bbbfe9f16..3a2c4d57f7 100644 --- a/tools/libs/light/libxl_pci.c +++ b/tools/libs/light/libxl_pci.c @@ -18,6 +18,10 @@ #include "libxl_internal.h" +#include + +#include "libxl_vchan.h" + #define PCI_BDF "%04x:%02x:%02x.%01x" #define PCI_BDF_SHORT "%02x:%02x.%01x" #define PCI_BDF_VDEVFN "%04x:%02x:%02x.%01x@%02x" @@ -25,6 +29,161 @@ #define PCI_BDF_XSPATH "%04x-%02x-%02x-%01x" #define PCI_PT_QDEV_ID "pci-pt-%02x_%02x.%01x" +static int process_list_assignable(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_DEVICES, + response, JSON_ARRAY); + if (!*result) + return ERROR_INVAL; + + return 0; +} + +static int pci_handle_response(libxl__gc *gc, + const libxl__json_object *response, + libxl__json_object **result) +{ + const libxl__json_object *command_obj; + const libxl__json_object *err_obj; + char *command_name; + int ret = 0; + + *result = NULL; + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_RESP, response, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad response. */ + return 0; + } + + err_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR, response, JSON_STRING); + if (!err_obj) { + /* Bad packet without error code field. */ + return 0; + } + + if (strcmp(err_obj->u.string, PCID_MSG_ERR_OK) != 0) { + const libxl__json_object *err_desc_obj; + + /* The response may contain an optional error string. */ + err_desc_obj = libxl__json_map_get(PCID_MSG_FIELD_ERR_DESC, + response, JSON_STRING); + if (err_desc_obj) + LOG(ERROR, "%s", err_desc_obj->u.string); + else + LOG(ERROR, "%s", err_obj->u.string); + return ERROR_FAIL; + } + + command_name = command_obj->u.string; + LOG(DEBUG, "command: %s", command_name); + + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, response, result); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESULT, + response, JSON_BOOL); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + *result = (libxl__json_object *)libxl__json_map_get(PCID_MSG_FIELD_RESOURCES, + response, JSON_MAP); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + *result = libxl__json_object_alloc(gc, JSON_NULL); + return ret; +} + +#define CONVERT_YAJL_GEN_TO_STATUS(gen) \ + ((gen) == yajl_gen_status_ok ? yajl_status_ok : yajl_status_error) + +static char *pci_prepare_request(libxl__gc *gc, yajl_gen gen, char *cmd, + libxl__json_object *args) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + yajl_status ret; + char *request = NULL; + int rc; + + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_open(gen)); + if (ret != yajl_status_ok) + return NULL; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_CMD, cmd); + if (rc) + return NULL; + + if (args) { + int idx = 0; + libxl__json_map_node *node = NULL; + + assert(args->type == JSON_MAP); + for (idx = 0; idx < args->u.map->count; idx++) { + if (flexarray_get(args->u.map, idx, (void**)&node) != 0) + break; + + ret = CONVERT_YAJL_GEN_TO_STATUS(libxl__yajl_gen_asciiz(gen, node->map_key)); + if (ret != yajl_status_ok) + return NULL; + ret = libxl__json_object_to_yajl_gen(gc, gen, node->obj); + if (ret != yajl_status_ok) + return NULL; + } + } + ret = CONVERT_YAJL_GEN_TO_STATUS(yajl_gen_map_close(gen)); + if (ret != yajl_status_ok) + return NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + return NULL; + + request = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + + return request; +} + +static struct vchan_info *pci_vchan_get_client(libxl__gc *gc, libxl_domid backend_domid) +{ + static struct vchan_info *vchan = NULL; + + if (vchan) { + if (vchan->initialized) + return vchan; + } else { + vchan = libxl__zalloc(gc, sizeof(*vchan)); + } + vchan->state = vchan_new_client(gc, PCID_SRV_NAME, backend_domid); + if (!(vchan->state)) { + vchan = NULL; + goto out; + } + + vchan->handle_response = pci_handle_response; + vchan->prepare_request = pci_prepare_request; + vchan->receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + vchan->max_buf_size = PCI_MAX_SIZE_RX_BUF; + vchan->initialized = true; + +out: + return vchan; +} + +static void pci_vchan_free(libxl__gc *gc, struct vchan_info *vchan) +{ + vchan_fini_one(gc, vchan->state); + vchan->initialized = false; +} + static unsigned int pci_encode_bdf(libxl_device_pci *pci) { unsigned int value; @@ -359,33 +518,6 @@ static bool is_pci_in_array(libxl_device_pci *pcis, int num, return i < num; } -/* Write the standard BDF into the sysfs path given by sysfs_path. */ -static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, - libxl_device_pci *pci) -{ - int rc, fd; - char *buf; - - fd = open(sysfs_path, O_WRONLY); - if (fd < 0) { - LOGE(ERROR, "Couldn't open %s", sysfs_path); - return ERROR_FAIL; - } - - buf = GCSPRINTF(PCI_BDF, pci->domain, pci->bus, - pci->dev, pci->func); - rc = write(fd, buf, strlen(buf)); - /* Annoying to have two if's, but we need the errno */ - if (rc < 0) - LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); - close(fd); - - if (rc < 0) - return ERROR_FAIL; - - return 0; -} - #define PCI_INFO_PATH "/libxl/pci" static char *pci_info_xs_path(libxl__gc *gc, libxl_device_pci *pci, @@ -429,30 +561,33 @@ static void pci_info_xs_remove(libxl__gc *gc, libxl_device_pci *pci, xs_rm(ctx->xsh, XBT_NULL, path); } -libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) +libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num, libxl_domid backend_domid) { GC_INIT(ctx); libxl_device_pci *pcis = NULL, *new; - struct dirent *de; - DIR *dir; + struct vchan_info *vchan; + libxl__json_object *result, *dev_obj; + int i; *num = 0; - dir = opendir(SYSFS_PCIBACK_DRIVER); - if (NULL == dir) { - if (errno == ENOENT) { - LOG(ERROR, "Looks like pciback driver not loaded"); - } else { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER); - } + vchan = pci_vchan_get_client(gc, backend_domid); + if (!vchan) goto out; - } - while((de = readdir(dir))) { + result = vchan_send_command(gc, vchan, PCID_CMD_LIST_ASSIGNABLE, NULL); + if (!result) + goto vchan_free; + + for (i = 0; (dev_obj = libxl__json_array_get(result, i)); i++) { + const char *sbdf_str = libxl__json_object_get_string(dev_obj); unsigned int dom, bus, dev, func; - char *name; + const char *name; - if (sscanf(de->d_name, PCI_BDF, &dom, &bus, &dev, &func) != 4) + if (!sbdf_str) + continue; + + if (sscanf(sbdf_str, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) continue; new = realloc(pcis, ((*num) + 1) * sizeof(*new)); @@ -474,7 +609,9 @@ libxl_device_pci *libxl_device_pci_assignable_list(libxl_ctx *ctx, int *num) (*num)++; } - closedir(dir); +vchan_free: + pci_vchan_free(gc, vchan); + out: GC_FREE; return pcis; @@ -490,44 +627,6 @@ void libxl_device_pci_assignable_list_free(libxl_device_pci *list, int num) free(list); } -/* Unbind device from its current driver, if any. If driver_path is non-NULL, - * store the path to the original driver in it. */ -static int sysfs_dev_unbind(libxl__gc *gc, libxl_device_pci *pci, - char **driver_path) -{ - char * spath, *dp = NULL; - struct stat st; - - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", - pci->domain, - pci->bus, - pci->dev, - pci->func); - if ( !lstat(spath, &st) ) { - /* Find the canonical path to the driver. */ - dp = libxl__zalloc(gc, PATH_MAX); - dp = realpath(spath, dp); - if ( !dp ) { - LOGE(ERROR, "realpath() failed"); - return -1; - } - - LOG(DEBUG, "Driver re-plug path: %s", dp); - - /* Unbind from the old driver */ - spath = GCSPRINTF("%s/unbind", dp); - if ( sysfs_write_bdf(gc, spath, pci) < 0 ) { - LOGE(ERROR, "Couldn't unbind device"); - return -1; - } - } - - if ( driver_path ) - *driver_path = dp; - - return 0; -} - static uint16_t sysfs_dev_get_vendor(libxl__gc *gc, libxl_device_pci *pci) { char *pci_device_vendor_path = @@ -639,116 +738,33 @@ bool libxl__is_igd_vga_passthru(libxl__gc *gc, return false; } -/* - * A brief comment about slots. I don't know what slots are for; however, - * I have by experimentation determined: - * - Before a device can be bound to pciback, its BDF must first be listed - * in pciback/slots - * - The way to get the BDF listed there is to write BDF to - * pciback/new_slot - * - Writing the same BDF to pciback/new_slot is not idempotent; it results - * in two entries of the BDF in pciback/slots - * It's not clear whether having two entries in pciback/slots is a problem - * or not. Just to be safe, this code does the conservative thing, and - * first checks to see if there is a slot, adding one only if one does not - * already exist. - */ - -/* Scan through /sys/.../pciback/slots looking for pci's BDF */ -static int pciback_dev_has_slot(libxl__gc *gc, libxl_device_pci *pci) -{ - FILE *f; - int rc = 0; - unsigned dom, bus, dev, func; - - f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); - - if (f == NULL) { - LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); - return ERROR_FAIL; - } - - while (fscanf(f, "%x:%x:%x.%d\n", &dom, &bus, &dev, &func) == 4) { - if (dom == pci->domain - && bus == pci->bus - && dev == pci->dev - && func == pci->func) { - rc = 1; - goto out; - } - } -out: - fclose(f); - return rc; -} - static int pciback_dev_is_assigned(libxl__gc *gc, libxl_device_pci *pci) { - char * spath; + struct vchan_info *vchan; int rc; - struct stat st; + libxl__json_object *args, *result; - if ( access(SYSFS_PCIBACK_DRIVER, F_OK) < 0 ) { - if ( errno == ENOENT ) { - LOG(ERROR, "Looks like pciback driver is not loaded"); - } else { - LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); - } - return -1; + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, - pci->domain, pci->bus, - pci->dev, pci->func); - rc = lstat(spath, &st); + args = libxl__vchan_start_args(gc); - if( rc == 0 ) - return 1; - if ( rc < 0 && errno == ENOENT ) - return 0; - LOGE(ERROR, "Accessing %s", spath); - return -1; -} - -static int pciback_dev_assign(libxl__gc *gc, libxl_device_pci *pci) -{ - int rc; + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); - if ( (rc = pciback_dev_has_slot(gc, pci)) < 0 ) { - LOGE(ERROR, "Error checking for pciback slot"); - return ERROR_FAIL; - } else if (rc == 0) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - } - - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; - } - return 0; -} - -static int pciback_dev_unassign(libxl__gc *gc, libxl_device_pci *pci) -{ - /* Remove from pciback */ - if ( sysfs_dev_unbind(gc, pci, NULL) < 0 ) { - LOG(ERROR, "Couldn't unbind device!"); - return ERROR_FAIL; + result = vchan_send_command(gc, vchan, PCID_CMD_IS_ASSIGNED, args); + if (!result) { + rc = ERROR_FAIL; } + rc = result->u.b; + pci_vchan_free(gc, vchan); - /* Remove slot if necessary */ - if ( pciback_dev_has_slot(gc, pci) > 0 ) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", - pci) < 0 ) { - LOGE(ERROR, "Couldn't remove pciback slot"); - return ERROR_FAIL; - } - } - return 0; +out: + return rc; } static int libxl__device_pci_assignable_add(libxl__gc *gc, @@ -756,87 +772,29 @@ static int libxl__device_pci_assignable_add(libxl__gc *gc, int rebind) { libxl_ctx *ctx = libxl__gc_owner(gc); - unsigned dom, bus, dev, func; - char *spath, *driver_path = NULL; - const char *name; + struct vchan_info *vchan; int rc; - struct stat st; + libxl__json_object *args, *result; - /* Local copy for convenience */ - dom = pci->domain; - bus = pci->bus; - dev = pci->dev; - func = pci->func; - name = pci->name; - - /* Sanitise any name that is set */ - if (name) { - unsigned int i, n = strlen(name); - - if (n > 64) { /* Reasonable upper bound on name length */ - LOG(ERROR, "Name too long"); - return ERROR_FAIL; - } - - for (i = 0; i < n; i++) { - if (!isgraph(name[i])) { - LOG(ERROR, "Names may only include printable characters"); - return ERROR_FAIL; - } - } - } - - /* See if the device exists */ - spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); - if ( lstat(spath, &st) ) { - LOGE(ERROR, "Couldn't lstat %s", spath); - return ERROR_FAIL; - } - - /* Check to see if it's already assigned to pciback */ - rc = pciback_dev_is_assigned(gc, pci); - if ( rc < 0 ) { - return ERROR_FAIL; - } - if ( rc ) { - LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); - goto name; + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Check to see if there's already a driver that we need to unbind from */ - if ( sysfs_dev_unbind(gc, pci, &driver_path ) ) { - LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", - dom, bus, dev, func); - return ERROR_FAIL; - } + args = libxl__vchan_start_args(gc); - /* Store driver_path for rebinding to dom0 */ - if ( rebind ) { - if ( driver_path ) { - pci_info_xs_write(gc, pci, "driver_path", driver_path); - } else if ( (driver_path = - pci_info_xs_read(gc, pci, "driver_path")) != NULL ) { - LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", - dom, bus, dev, func, driver_path); - } else { - LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", - dom, bus, dev, func); - } - } else { - pci_info_xs_remove(gc, pci, "driver_path"); - } + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_bool(gc, args, PCID_MSG_FIELD_REBIND, rebind); - if ( pciback_dev_assign(gc, pci) ) { - LOG(ERROR, "Couldn't bind device to pciback!"); - return ERROR_FAIL; + result = vchan_send_command(gc, vchan, PCID_CMD_MAKE_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } -name: - if (name) - pci_info_xs_write(gc, pci, "name", name); - else - pci_info_xs_remove(gc, pci, "name"); - /* * DOMID_IO is just a sentinel domain, without any actual mappings, * so always pass XEN_DOMCTL_DEV_RDM_RELAXED to avoid assignment being @@ -844,12 +802,15 @@ name: */ rc = xc_assign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci), XEN_DOMCTL_DEV_RDM_RELAXED); - if ( rc < 0 ) { - LOG(ERROR, "failed to quarantine "PCI_BDF, dom, bus, dev, func); - return ERROR_FAIL; - } + if ( rc < 0 ) + LOG(ERROR, "failed to quarantine "PCI_BDF, pci->domain, pci->bus, + pci->dev, pci->func); - return 0; +vchan_free: + pci_vchan_free(gc, vchan); + +out: + return rc; } static int name2bdf(libxl__gc *gc, libxl_device_pci *pci) @@ -892,13 +853,8 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, { libxl_ctx *ctx = libxl__gc_owner(gc); int rc; - char *driver_path; - - /* If the device is named then we need to look up the BDF */ - if (pci->name) { - rc = name2bdf(gc, pci); - if (rc) return rc; - } + struct vchan_info *vchan; + libxl__json_object *args, *temp_obj, *result; /* De-quarantine */ rc = xc_deassign_device(ctx->xch, DOMID_IO, pci_encode_bdf(pci)); @@ -908,41 +864,43 @@ static int libxl__device_pci_assignable_remove(libxl__gc *gc, return ERROR_FAIL; } - /* Unbind from pciback */ - if ( (rc = pciback_dev_is_assigned(gc, pci)) < 0 ) { - return ERROR_FAIL; - } else if ( rc ) { - pciback_dev_unassign(gc, pci); - } else { - LOG(WARN, "Not bound to pciback"); + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - /* Rebind if necessary */ - driver_path = pci_info_xs_read(gc, pci, "driver_path"); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_STRING); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } + temp_obj->u.string = GCSPRINTF(PCID_SBDF_FMT, pci->domain, pci->bus, + pci->dev, pci->func); + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_SBDF, temp_obj); - if ( driver_path ) { - if ( rebind ) { - LOG(INFO, "Rebinding to driver at %s", driver_path); + args = libxl__json_object_alloc(gc, JSON_MAP); + temp_obj = libxl__json_object_alloc(gc, JSON_BOOL); + if (!temp_obj) { + rc = ERROR_NOMEM; + goto vchan_free; + } - if ( sysfs_write_bdf(gc, - GCSPRINTF("%s/bind", driver_path), - pci) < 0 ) { - LOGE(ERROR, "Couldn't bind device to %s", driver_path); - return -1; - } + temp_obj->u.b = rebind; + flexarray_append_pair(args->u.map, PCID_MSG_FIELD_REBIND, temp_obj); - pci_info_xs_remove(gc, pci, "driver_path"); - } - } else { - if ( rebind ) { - LOG(WARN, - "Couldn't find path for original driver; not rebinding"); - } + result = vchan_send_command(gc, vchan, PCID_CMD_REVERT_ASSIGNABLE, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; } - pci_info_xs_remove(gc, pci, "name"); +vchan_free: + pci_vchan_free(gc, vchan); - return 0; +out: + return rc; } int libxl_device_pci_assignable_add(libxl_ctx *ctx, libxl_device_pci *pci, @@ -1375,6 +1333,36 @@ static bool pci_supp_legacy_irq(void) #endif } +static int pciback_write_bdf(libxl__gc *gc, char *name, libxl_device_pci *pci) +{ + struct vchan_info *vchan; + int rc; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; + } + + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_NAME, name); + + result = vchan_send_command(gc, vchan, PCID_CMD_WRITE_BDF, args); + if (!result) { + rc = ERROR_FAIL; + goto vchan_free; + } +vchan_free: + pci_vchan_free(gc, vchan); +out: + return rc; +} + static void pci_add_dm_done(libxl__egc *egc, pci_add_state *pas, int rc) @@ -1382,41 +1370,51 @@ static void pci_add_dm_done(libxl__egc *egc, STATE_AO_GC(pas->aodev->ao); libxl_ctx *ctx = libxl__gc_owner(gc); libxl_domid domid = pas->pci_domid; - char *sysfs_path; - FILE *f; unsigned long long start, end, flags, size; int irq, i; int r; uint32_t flag = XEN_DOMCTL_DEV_RDM_RELAXED; uint32_t domainid = domid; bool isstubdom = libxl_is_stubdom(ctx, domid, &domainid); + struct vchan_info *vchan; + libxl__json_object *result; + libxl__json_object *args; + const libxl__json_object *value; + libxl__json_object *res_obj; + libxl_device_pci *pci = &pas->pci; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) + goto out; /* Convenience aliases */ bool starting = pas->starting; - libxl_device_pci *pci = &pas->pci; bool hvm = libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM; libxl__ev_qmp_dispose(gc, &pas->qmp); - if (rc) goto out; + args = libxl__vchan_start_args(gc); + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, + pci->bus, pci->dev, pci->func)); + libxl__vchan_arg_add_integer(gc, args, PCID_MSG_FIELD_DOMID, domid); + + result = vchan_send_command(gc, vchan, PCID_CMD_RESOURCE_LIST, args); + pci_vchan_free(gc, vchan); + if (!result) + goto out; + value = libxl__json_map_get(PCID_RESULT_KEY_IOMEM, result, JSON_ARRAY); /* stubdomain is always running by now, even at create time */ if (isstubdom) starting = false; - - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); start = end = flags = size = 0; irq = 0; - - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - rc = ERROR_FAIL; - goto out; - } for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { - if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + if ((res_obj = libxl__json_array_get(value, i)) == NULL) + continue; + const char *iomem_str = libxl__json_object_get_string(res_obj); + if (sscanf(iomem_str, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) continue; size = end - start + 1; if (start) { @@ -1426,7 +1424,6 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_ioport_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1437,29 +1434,21 @@ static void pci_add_dm_done(libxl__egc *egc, LOGED(ERROR, domainid, "xc_domain_iomem_permission 0x%llx/0x%llx (error %d)", start, size, r); - fclose(f); rc = ERROR_FAIL; goto out; } } } } - fclose(f); if (!pci_supp_legacy_irq()) goto out_no_irq; - sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", pci->domain, - pci->bus, pci->dev, pci->func); - f = fopen(sysfs_path, "r"); - if (f == NULL) { - LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); - goto out_no_irq; - } - if ((fscanf(f, "%u", &irq) == 1) && irq) { + value = libxl__json_map_get(PCID_RESULT_KEY_IRQS, result, JSON_ARRAY); + if ((res_obj = libxl__json_array_get(value, i)) && + (irq = libxl__json_object_get_integer(res_obj))) { r = xc_physdev_map_pirq(ctx->xch, domid, irq, &irq); if (r < 0) { LOGED(ERROR, domainid, "xc_physdev_map_pirq irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } @@ -1467,17 +1456,14 @@ static void pci_add_dm_done(libxl__egc *egc, if (r < 0) { LOGED(ERROR, domainid, "xc_domain_irq_permission irq=%d (error=%d)", irq, r); - fclose(f); rc = ERROR_FAIL; goto out; } } - fclose(f); /* Don't restrict writes to the PCI config space from this VM */ if (pci->permissive) { - if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/permissive", - pci) < 0 ) { + if (pciback_write_bdf(gc, "permissive", pci)) { LOGD(ERROR, domainid, "Setting permissive for device"); rc = ERROR_FAIL; goto out; @@ -1510,41 +1496,28 @@ out: pas->callback(egc, pas, rc); } -static int libxl__device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, - unsigned int dev, unsigned int func) -{ - char *reset; - int fd, rc; - - reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); - rc = write(fd, buf, strlen(buf)); - if (rc < 0) - LOGD(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno != ENOENT) - LOGED(ERROR, domain, "Failed to access pciback path %s", reset); - reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); - fd = open(reset, O_WRONLY); - if (fd >= 0) { - rc = write(fd, "1", 1); - if (rc < 0) - LOGED(ERROR, domain, "write to %s returned %d", reset, rc); - close(fd); - return rc < 0 ? rc : 0; - } - if (errno == ENOENT) { - LOGD(ERROR, domain, - "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, - domain, bus, dev, func); - } else { - LOGED(ERROR, domain, "Failed to access reset path %s", reset); +static int libxl__device_pci_reset(libxl__gc *gc, libxl_device_pci *pci) +{ + struct vchan_info *vchan; + int rc = 0; + libxl__json_object *args, *result; + + vchan = pci_vchan_get_client(gc, pci->backend_domid); + if (!vchan) { + rc = ERROR_NOT_READY; + goto out; } - return -1; + args = libxl__vchan_start_args(gc); + + libxl__vchan_arg_add_string(gc, args, PCID_MSG_FIELD_SBDF, + GCSPRINTF(PCID_SBDF_FMT, pci->domain, pci->bus, pci->dev, pci->func)); + result = vchan_send_command(gc, vchan, PCID_CMD_RESET_DEVICE, args); + if (!result) + rc = ERROR_FAIL; + pci_vchan_free(gc, vchan); + + out: + return rc; } int libxl__device_pci_setdefault(libxl__gc *gc, uint32_t domid, @@ -1578,7 +1551,7 @@ static bool libxl_pci_assignable(libxl_ctx *ctx, libxl_device_pci *pci) int num; bool assignable; - pcis = libxl_device_pci_assignable_list(ctx, &num); + pcis = libxl_device_pci_assignable_list(ctx, &num, pci->backend_domid); assignable = is_pci_in_array(pcis, num, pci); libxl_device_pci_assignable_list_free(pcis, num); @@ -1594,6 +1567,12 @@ static void device_pci_add_stubdom_done(libxl__egc *egc, static void device_pci_add_done(libxl__egc *egc, pci_add_state *, int rc); +static void device_pci_get_backend_domd(libxl__gc *gc, libxl_device_pci *pci) +{ + if (pci->backend == NULL || libxl__resolve_domid(gc, pci->backend, &pci->backend_domid)) + pci->backend_domid = DOMID_INVALID; +} + void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, libxl_device_pci *pci, bool starting, libxl__ao_device *aodev) @@ -1620,6 +1599,8 @@ void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, pas->starting = starting; pas->callback = device_pci_add_stubdom_done; + device_pci_get_backend_domd(gc, pci); + if (libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { rc = xc_test_assign_device(ctx->xch, domid, pci_encode_bdf(pci)); if (rc) { @@ -1651,7 +1632,7 @@ void libxl__device_pci_add(libxl__egc *egc, uint32_t domid, rc = pci_info_xs_write(gc, pci, "domid", GCSPRINTF("%u", domid)); if (rc) goto out; - libxl__device_pci_reset(gc, pci->domain, pci->bus, pci->dev, pci->func); + libxl__device_pci_reset(gc, pci); stubdomid = libxl_get_stubdom_id(ctx, domid); if (stubdomid != 0) { @@ -2216,7 +2197,7 @@ static void pci_remove_detached(libxl__egc *egc, /* don't do multiple resets while some functions are still passed through */ if ((pci->vdevfn & 0x7) == 0) { - libxl__device_pci_reset(gc, pci->domain, pci->bus, pci->dev, pci->func); + libxl__device_pci_reset(gc, pci); } if (!isstubdom) { diff --git a/tools/libs/light/libxl_pcid.c b/tools/libs/light/libxl_pcid.c new file mode 100644 index 0000000000..d4a817dc6f --- /dev/null +++ b/tools/libs/light/libxl_pcid.c @@ -0,0 +1,1095 @@ +/* + Utils for xl pcid daemon + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include "libxl_osdeps.h" /* must come before any other headers */ + +#include "libxl_internal.h" +#include "libxl_vchan.h" + +#include +#include + +#include + +#include +#include +#include + +#include +#include + +#define DOM0_ID 0 + +#define PCI_BDF "%04x:%02x:%02x.%01x" + +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func); + +struct vchan_client { + XEN_LIST_ENTRY(struct vchan_client) list; + + /* This is the watch entry fired for this client. */ + char **watch_ret; + /* Length of the watch_ret[XS_WATCH_PATH]. */ + size_t watch_len; + + struct vchan_info info; + + /* + * This context is used by the processing loop to create its own gc + * and use it while processing commands, so we do not get OOM. + */ + libxl_ctx *ctx; + /* This gc holds all allocations made for the client needs itself. */ + libxl__gc gc[1]; + pthread_t run_thread; +}; + +static XEN_LIST_HEAD(clients_list, struct vchan_client) vchan_clients; + +static pthread_mutex_t vchan_client_mutex; + +static int make_error_reply(libxl__gc *gc, yajl_gen gen, char *desc, + char *command_name) +{ + int rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_FAILED); + if (rc) + return rc; + + rc = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR_DESC, desc); + if (rc) + return rc; + + return 0; +} + +static int process_list_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct dirent *de; + DIR *dir = NULL; + + dir = opendir(SYSFS_PCI_DEV); + if (dir == NULL) { + make_error_reply(gc, gen, strerror(errno), command_name); + return ERROR_FAIL; + } + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_DEVICES); + + *response = libxl__json_object_alloc(gc, JSON_ARRAY); + + while ((de = readdir(dir))) { + unsigned int dom, bus, dev, func; + + if (sscanf(de->d_name, PCID_SBDF_FMT, &dom, &bus, &dev, &func) != 4) + continue; + + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + node->u.string = de->d_name; + flexarray_append((*response)->u.array, node); + } + + closedir(dir); + + return 0; +} + +static bool pci_supp_legacy_irq(void) +{ +#ifdef CONFIG_PCI_SUPP_LEGACY_IRQ + return true; +#else + return false; +#endif +} + +static int process_list_resources(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct libxl__json_object *iomem = + libxl__json_object_alloc(gc, JSON_ARRAY); + struct libxl__json_object *irqs = + libxl__json_object_alloc(gc, JSON_ARRAY); + const struct libxl__json_object *json_sdbf; + const struct libxl__json_object *json_domid; + unsigned int dom, bus, dev, func; + libxl_domid domainid; + char *sysfs_path; + FILE *f; + unsigned long long start, end, flags; + int irq, i; + int rc = 0; + libxl__json_map_node *map_node = NULL; + + json_sdbf = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_sdbf) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + if (sscanf(libxl__json_object_get_string(json_sdbf), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_domid = libxl__json_map_get(PCID_MSG_FIELD_DOMID, request, JSON_INTEGER); + if (!json_domid) { + make_error_reply(gc, gen, "No mandatory parameter 'domid'", command_name); + return ERROR_FAIL; + } + domainid = libxl__json_object_get_integer(json_domid); + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESOURCES); + *response = libxl__json_object_alloc(gc, JSON_MAP); + + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/resource", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + start = 0; + irq = 0; + + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + rc = ERROR_FAIL; + goto out; + } + for (i = 0; i < PROC_PCI_NUM_RESOURCES; i++) { + if (fscanf(f, "0x%llx 0x%llx 0x%llx\n", &start, &end, &flags) != 3) + continue; + if (start) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_STRING); + + node->u.string = GCSPRINTF("0x%llx 0x%llx 0x%llx", start, end, flags); + flexarray_append(iomem->u.array, node); + } + } + fclose(f); + if (!pci_supp_legacy_irq()) + goto out_no_irq; + sysfs_path = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/irq", dom, bus, dev, func); + f = fopen(sysfs_path, "r"); + if (f == NULL) { + LOGED(ERROR, domainid, "Couldn't open %s", sysfs_path); + goto out_no_irq; + } + if ((fscanf(f, "%u", &irq) == 1) && irq) { + struct libxl__json_object *node = + libxl__json_object_alloc(gc, JSON_INTEGER); + + node->u.i = irq; + flexarray_append(irqs->u.array, node); + } + fclose(f); + + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IRQS); + map_node->obj = irqs; + flexarray_append((*response)->u.map, map_node); +out_no_irq: + GCNEW(map_node); + map_node->map_key = libxl__strdup(gc, PCID_RESULT_KEY_IOMEM); + map_node->obj = iomem; + flexarray_append((*response)->u.map, map_node); + rc = 0; +out: + return rc; +} + +static int pciback_dev_is_assigned(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + char * spath; + int rc; + struct stat st; + + if (access(SYSFS_PCIBACK_DRIVER, F_OK) < 0) { + if (errno == ENOENT) { + LOG(ERROR, "Looks like pciback driver is not loaded"); + } else { + LOGE(ERROR, "Can't access "SYSFS_PCIBACK_DRIVER); + } + return -1; + } + + spath = GCSPRINTF(SYSFS_PCIBACK_DRIVER"/"PCI_BDF, + domain, bus, dev, func); + rc = lstat(spath, &st); + + if (rc == 0) + return 1; + if (rc < 0 && errno == ENOENT) + return 0; + LOGE(ERROR, "Accessing %s", spath); + return 0; +} + +static int process_pciback_write_bdf(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc = 0; + const char *name; + char *spath; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_NAME, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + name = libxl__json_object_get_string(json_o); + spath = GCSPRINTF("%s/%s", SYSFS_PCIBACK_DRIVER, name); + LOG(WARN, "sysf_write_bdf(%s, %d, %d, %d, %d)", spath, dom, bus, dev,func); + return rc; +} + +#define PCID_INFO_PATH "pcid" +#define PCID_BDF_XSPATH "%04x-%02x-%02x-%01x" + +static char *pcid_info_xs_path(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + return node ? + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH"/%s", + domain, bus, dev, func, node) : + GCSPRINTF(PCID_INFO_PATH"/"PCID_BDF_XSPATH, + domain, bus, dev, func); +} + + +static int pcid_info_xs_write(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node, + const char *val) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + int rc = libxl__xs_printf(gc, XBT_NULL, path, "%s", val); + + if (rc) LOGE(WARN, "Write of %s to node %s failed.", val, path); + + return rc; +} + +static char *pcid_info_xs_read(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + + return libxl__xs_read(gc, XBT_NULL, path); +} + +static void pcid_info_xs_remove(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, const char *node) +{ + char *path = pcid_info_xs_path(gc, domain, bus, dev, func, node); + libxl_ctx *ctx = libxl__gc_owner(gc); + + /* Remove the xenstore entry */ + xs_rm(ctx->xsh, XBT_NULL, path); +} + + +/* Write the standard BDF into the sysfs path given by sysfs_path. */ +static int sysfs_write_bdf(libxl__gc *gc, const char * sysfs_path, + unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + int rc, fd; + char *buf; + + fd = open(sysfs_path, O_WRONLY); + if (fd < 0) { + LOGE(ERROR, "Couldn't open %s", sysfs_path); + return ERROR_FAIL; + } + + buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + /* Annoying to have two if's, but we need the errno */ + if (rc < 0) + LOGE(ERROR, "write to %s returned %d", sysfs_path, rc); + close(fd); + + if (rc < 0) + return ERROR_FAIL; + + return 0; +} + + +/* Unbind device from its current driver, if any. If driver_path is non-NULL, + * store the path to the original driver in it. */ +static int sysfs_dev_unbind(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func, + char **driver_path) +{ + char * spath, *dp = NULL; + struct stat st; + + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF"/driver", + domain, bus, dev, func); + if (!lstat(spath, &st)) { + /* Find the canonical path to the driver. */ + dp = libxl__zalloc(gc, PATH_MAX); + dp = realpath(spath, dp); + if ( !dp ) { + LOGE(ERROR, "realpath() failed"); + return -1; + } + + LOG(DEBUG, "Driver re-plug path: %s", dp); + + /* Unbind from the old driver */ + spath = GCSPRINTF("%s/unbind", dp); + if (sysfs_write_bdf(gc, spath, domain, bus, dev, func) < 0) { + LOGE(ERROR, "Couldn't unbind device"); + return -1; + } + } + + if (driver_path) + *driver_path = dp; + + return 0; +} + +/* + * A brief comment about slots. I don't know what slots are for; however, + * I have by experimentation determined: + * - Before a device can be bound to pciback, its BDF must first be listed + * in pciback/slots + * - The way to get the BDF listed there is to write BDF to + * pciback/new_slot + * - Writing the same BDF to pciback/new_slot is not idempotent; it results + * in two entries of the BDF in pciback/slots + * It's not clear whether having two entries in pciback/slots is a problem + * or not. Just to be safe, this code does the conservative thing, and + * first checks to see if there is a slot, adding one only if one does not + * already exist. + */ + +/* Scan through /sys/.../pciback/slots looking for pci's BDF */ +static int pciback_dev_has_slot(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + FILE *f; + int rc = 0; + unsigned s_domain, s_bus, s_dev, s_func; + + f = fopen(SYSFS_PCIBACK_DRIVER"/slots", "r"); + + if (f == NULL) { + LOGE(ERROR, "Couldn't open %s", SYSFS_PCIBACK_DRIVER"/slots"); + return ERROR_FAIL; + } + + while (fscanf(f, "%x:%x:%x.%d\n", + &s_domain, &s_bus, &s_dev, &s_func) == 4) { + if (s_domain == domain && + s_bus == bus && + s_dev == dev && + s_func == func) { + rc = 1; + goto out; + } + } +out: + fclose(f); + return rc; +} + +static int pciback_dev_assign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + int rc; + + if ( (rc = pciback_dev_has_slot(gc, domain, bus, dev, func)) < 0 ) { + LOGE(ERROR, "Error checking for pciback slot"); + return ERROR_FAIL; + } else if (rc == 0) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/new_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + } + + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/bind", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + return 0; +} + +static int process_pciback_dev_is_assigned(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + libxl__yajl_gen_asciiz(gen, PCID_MSG_FIELD_RESULT); + *response = libxl__json_object_alloc(gc, JSON_BOOL); + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + (*response)->u.b = rc; + return 0; +} + +static int device_pci_reset(libxl__gc *gc, unsigned int domain, unsigned int bus, + unsigned int dev, unsigned int func) +{ + char *reset; + int fd, rc; + + reset = GCSPRINTF("%s/do_flr", SYSFS_PCIBACK_DRIVER); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + char *buf = GCSPRINTF(PCI_BDF, domain, bus, dev, func); + rc = write(fd, buf, strlen(buf)); + if (rc < 0) + LOGD(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno != ENOENT) + LOGED(ERROR, domain, "Failed to access pciback path %s", reset); + reset = GCSPRINTF("%s/"PCI_BDF"/reset", SYSFS_PCI_DEV, domain, bus, dev, func); + fd = open(reset, O_WRONLY); + if (fd >= 0) { + rc = write(fd, "1", 1); + if (rc < 0) + LOGED(ERROR, domain, "write to %s returned %d", reset, rc); + close(fd); + return rc < 0 ? rc : 0; + } + if (errno == ENOENT) { + LOGD(ERROR, domain, + "The kernel doesn't support reset from sysfs for PCI device "PCI_BDF, + domain, bus, dev, func); + } else { + LOGED(ERROR, domain, "Failed to access reset path %s", reset); + } + return -1; +} + +static int process_device_pci_reset(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + rc = device_pci_reset(gc, dom, bus, dev, func); + if (rc < 0) + return ERROR_FAIL; + return rc; +} + +static int process_make_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + struct stat st; + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *spath, *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* See if the device exists */ + spath = GCSPRINTF(SYSFS_PCI_DEV"/"PCI_BDF, dom, bus, dev, func); + if ( lstat(spath, &st) ) { + make_error_reply(gc, gen, strerror(errno), command_name); + LOGE(ERROR, "Couldn't lstat %s", spath); + return ERROR_FAIL; + } + + /* Check to see if it's already assigned to pciback */ + rc = pciback_dev_is_assigned(gc, dom, bus, dev, func); + if (rc < 0) { + make_error_reply(gc, gen, "Can't check if device is assigned", + command_name); + return ERROR_FAIL; + } + if (rc) { + LOG(WARN, PCI_BDF" already assigned to pciback", dom, bus, dev, func); + goto done; + } + + /* Check to see if there's already a driver that we need to unbind from */ + if (sysfs_dev_unbind(gc, dom, bus, dev, func, &driver_path)) { + LOG(ERROR, "Couldn't unbind "PCI_BDF" from driver", + dom, bus, dev, func); + return ERROR_FAIL; + } + + /* Store driver_path for rebinding back */ + if (rebind) { + if (driver_path) { + pcid_info_xs_write(gc, dom, bus, dev, func, "driver_path", + driver_path); + } else if ( (driver_path = + pcid_info_xs_read(gc, dom, bus, dev, func, + "driver_path")) != NULL ) { + LOG(INFO, PCI_BDF" not bound to a driver, will be rebound to %s", + dom, bus, dev, func, driver_path); + } else { + LOG(WARN, PCI_BDF" not bound to a driver, will not be rebound.", + dom, bus, dev, func); + } + } else { + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + + if (pciback_dev_assign(gc, dom, bus, dev, func)) { + LOG(ERROR, "Couldn't bind device to pciback!"); + return ERROR_FAIL; + } + +done: + return 0; +} + +static int pciback_dev_unassign(libxl__gc *gc, unsigned int domain, + unsigned int bus, unsigned int dev, + unsigned int func) +{ + /* Remove from pciback */ + if ( sysfs_dev_unbind(gc, domain, bus, dev, func, NULL) < 0 ) { + LOG(ERROR, "Couldn't unbind device!"); + return ERROR_FAIL; + } + + /* Remove slot if necessary */ + if ( pciback_dev_has_slot(gc, domain, bus, dev, func) > 0 ) { + if ( sysfs_write_bdf(gc, SYSFS_PCIBACK_DRIVER"/remove_slot", + domain, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't remove pciback slot"); + return ERROR_FAIL; + } + } + return 0; +} + +static int process_revert_assignable(libxl__gc *gc, yajl_gen gen, + char *command_name, + const struct libxl__json_object *request, + struct libxl__json_object **response) +{ + const struct libxl__json_object *json_o; + unsigned int dom, bus, dev, func; + int rc; + bool rebind; + char *driver_path = NULL; + + json_o = libxl__json_map_get(PCID_MSG_FIELD_SBDF, request, JSON_STRING); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'sbdf'", command_name); + return ERROR_FAIL; + } + + if (sscanf(libxl__json_object_get_string(json_o), PCID_SBDF_FMT, + &dom, &bus, &dev, &func) != 4) { + make_error_reply(gc, gen, "Can't parse SBDF", command_name); + return ERROR_FAIL; + } + + json_o = libxl__json_map_get(PCID_MSG_FIELD_REBIND, request, JSON_BOOL); + if (!json_o) { + make_error_reply(gc, gen, "No mandatory parameter 'rebind'", command_name); + return ERROR_FAIL; + } + + rebind = libxl__json_object_get_bool(json_o); + + /* Unbind from pciback */ + if ( (rc = pciback_dev_is_assigned(gc, dom, bus, dev, func)) < 0 ) { + make_error_reply(gc, gen, "Can't unbind from pciback", command_name); + return ERROR_FAIL; + } else if ( rc ) { + pciback_dev_unassign(gc, dom, bus, dev, func); + } else { + LOG(WARN, "Not bound to pciback"); + } + + /* Rebind if necessary */ + driver_path = pcid_info_xs_read(gc, dom, bus, dev, func, "driver_path"); + + if ( driver_path ) { + if ( rebind ) { + LOG(INFO, "Rebinding to driver at %s", driver_path); + + if ( sysfs_write_bdf(gc, + GCSPRINTF("%s/bind", driver_path), + dom, bus, dev, func) < 0 ) { + LOGE(ERROR, "Couldn't bind device to %s", driver_path); + return -1; + } + + pcid_info_xs_remove(gc, dom, bus, dev, func, "driver_path"); + } + } else { + if ( rebind ) { + LOG(WARN, + "Couldn't find path for original driver; not rebinding"); + } + } + + return 0; +} + +static int pcid_handle_request(libxl__gc *gc, yajl_gen gen, + const libxl__json_object *request) +{ + const libxl__json_object *command_obj; + libxl__json_object *command_response = NULL; + char *command_name; + int ret = 0; + + yajl_gen_map_open(gen); + + command_obj = libxl__json_map_get(PCID_MSG_FIELD_CMD, request, JSON_STRING); + if (!command_obj) { + /* This is an unsupported or bad request. */ + ret = make_error_reply(gc, gen, "Unsupported request or bad packet", + PCID_MSG_ERR_NA); + goto out; + } + + command_name = command_obj->u.string; + + if (strcmp(command_name, PCID_CMD_LIST_ASSIGNABLE) == 0) + ret = process_list_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_MAKE_ASSIGNABLE) == 0) + ret = process_make_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_REVERT_ASSIGNABLE) == 0) + ret = process_revert_assignable(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_IS_ASSIGNED) == 0) + ret = process_pciback_dev_is_assigned(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESET_DEVICE) == 0) + ret = process_device_pci_reset(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_RESOURCE_LIST) == 0) + ret = process_list_resources(gc, gen, command_name, + request, &command_response); + else if (strcmp(command_name, PCID_CMD_WRITE_BDF) == 0) + ret = process_pciback_write_bdf(gc, gen, command_name, + request, &command_response); + else { + /* + * This is an unsupported command: make a reply and proceed over + * the error path. + */ + ret = make_error_reply(gc, gen, "Unsupported command", + command_name); + if (!ret) + ret = ERROR_NOTFOUND; + } + + if (ret) { + /* + * The command handler on error must provide a valid response, + * so we don't need to add any other field below. + */ + ret = 0; + goto out; + } + + if (command_response) { + ret = libxl__json_object_to_yajl_gen(gc, gen, command_response); + if (ret) + goto out; + } + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_RESP, + command_name); + if (ret) + goto out; + + ret = libxl__vchan_field_add_string(gc, gen, PCID_MSG_FIELD_ERR, + PCID_MSG_ERR_OK); +out: + yajl_gen_map_close(gen); + + vchan_dump_gen(gc, gen); + + return ret; +} + +static char *pcid_prepare_response(libxl__gc *gc, yajl_gen gen) +{ + const unsigned char *buf; + libxl_yajl_length len; + yajl_gen_status sts; + char *reply = NULL; + + sts = yajl_gen_get_buf(gen, &buf, &len); + if (sts != yajl_gen_status_ok) + goto out; + + reply = libxl__sprintf(gc, "%s", buf); + + vchan_dump_gen(gc, gen); + +out: + return reply; +} + +static void server_fini_one(libxl__gc *gc, struct vchan_client *client) +{ + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_REMOVE(client, list); + pthread_mutex_unlock(&vchan_client_mutex); + + GC_FREE; + free(client); +} + +static void *client_thread(void *arg) +{ + struct vchan_client *client = arg; + + while (true) { + int ret; + /* + * libvchan uses garbage collector for processing requests, + * so we create a new one each time we process a packet and + * dispose it right away to prevent OOM. + */ + GC_INIT(client->ctx); + ret = vchan_process_command(gc, &client->info); + GC_FREE; + + if ((ret == ERROR_NOTFOUND) || (ret == ERROR_INVAL)) + continue; + if (ret < 0) + break; + } + vchan_fini_one(client->gc, client->info.state); + server_fini_one(client->gc, client); + return NULL; +} + +#define DEFAULT_THREAD_STACKSIZE (24 * 1024) +/* NetBSD doesn't have PTHREAD_STACK_MIN. */ +#ifndef PTHREAD_STACK_MIN +#define PTHREAD_STACK_MIN 0 +#endif + +#define READ_THREAD_STACKSIZE \ + ((DEFAULT_THREAD_STACKSIZE < PTHREAD_STACK_MIN) ? \ + PTHREAD_STACK_MIN : DEFAULT_THREAD_STACKSIZE) + +static bool init_client_thread(libxl__gc *gc, struct vchan_client *new_client) +{ + + sigset_t set, old_set; + pthread_attr_t attr; + static size_t stack_size; +#ifdef USE_DLSYM + size_t (*getsz)(pthread_attr_t *attr); +#endif + + if (pthread_attr_init(&attr) != 0) + return false; + if (!stack_size) { +#ifdef USE_DLSYM + getsz = dlsym(RTLD_DEFAULT, "__pthread_get_minstack"); + if (getsz) + stack_size = getsz(&attr); +#endif + if (stack_size < READ_THREAD_STACKSIZE) + stack_size = READ_THREAD_STACKSIZE; + } + if (pthread_attr_setstacksize(&attr, stack_size) != 0) { + pthread_attr_destroy(&attr); + return false; + } + + sigfillset(&set); + pthread_sigmask(SIG_SETMASK, &set, &old_set); + + if (pthread_create(&new_client->run_thread, &attr, client_thread, + new_client) != 0) { + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + return false; + } + pthread_sigmask(SIG_SETMASK, &old_set, NULL); + pthread_attr_destroy(&attr); + + return true; +} + +static void init_new_client(libxl_ctx *ctx, libxl__gc *gc, + struct clients_list *list, char **watch_ret) +{ + struct vchan_client *new_client; + char *xs_path = watch_ret[XS_WATCH_PATH]; + + LOG(DEBUG, "New client at \"%s\"", xs_path); + + new_client = malloc(sizeof(*new_client)); + if (!new_client) { + LOGE(ERROR, "Failed to allocate new client at \"%s\"", xs_path); + return; + } + + memset(new_client, 0, sizeof(*new_client)); + + new_client->watch_ret = watch_ret; + new_client->watch_len = strlen(xs_path); + new_client->ctx = ctx; + /* + * Remember the GC of this client, so we can dispose its memory. + * Use it from now on. + */ + LIBXL_INIT_GC(new_client->gc[0], ctx); + + new_client->info.state = vchan_init_new_state(new_client->gc, DOM0_ID, + xs_path, true); + if (!(new_client->info.state)) { + LOGE(ERROR, "Failed to add new client at \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + new_client->info.handle_request = pcid_handle_request; + new_client->info.prepare_response = pcid_prepare_response; + new_client->info.receive_buf_size = PCI_RECEIVE_BUFFER_SIZE; + new_client->info.max_buf_size = PCI_MAX_SIZE_RX_BUF; + + if (!init_client_thread(new_client->gc, new_client)) { + LOGE(ERROR, "Failed to create client's thread for \"%s\"", xs_path); + server_fini_one(new_client->gc, new_client); + return; + } + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_INSERT_HEAD(&vchan_clients, new_client, list); + pthread_mutex_unlock(&vchan_client_mutex); +} + +static void terminate_clients(void) +{ + struct vchan_client *client; + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + pthread_join(client->run_thread, NULL); + } + pthread_mutex_unlock(&vchan_client_mutex); +} + +int libxl_pcid_process(libxl_ctx *ctx) +{ + GC_INIT(ctx); + char *xs_path, *str; + char **watch_ret; + unsigned int watch_num; + libxl_domid domid; + int ret; + + pthread_mutex_init(&vchan_client_mutex, NULL); + + str = xs_read(ctx->xsh, 0, "domid", NULL); + if (!str) { + LOGE(ERROR, "Can't read own domid\n"); + ret = -ENOENT; + goto out; + } + + ret = sscanf(str, "%d", &domid); + free(str); + if (ret != 1) + { + LOGE(ERROR, "Own domid is not an integer\n"); + ret = -EINVAL; + goto out; + } + + xs_path = vchan_get_server_xs_path(gc, domid, PCID_SRV_NAME); + + /* Recreate the base folder: remove all leftovers. */ + ret = libxl__xs_rm_checked(gc, XBT_NULL, xs_path); + if (ret) + goto out; + + if (!xs_mkdir(CTX->xsh, XBT_NULL, xs_path)) + { + LOGE(ERROR, "xenstore mkdir failed: `%s'", xs_path); + ret = ERROR_FAIL; + goto out; + } + + /* Wait for vchan client to create a new UUID under the server's folder. */ + if (!xs_watch(CTX->xsh, xs_path, PCID_XS_TOKEN)) { + LOGE(ERROR, "xs_watch (%s) failed", xs_path); + ret = ERROR_FAIL; + goto out; + } + + while ((watch_ret = xs_read_watch(CTX->xsh, &watch_num))) { + struct vchan_client *client; + size_t len; + bool found; + + /* + * Any change under the base directory will fire an event, so we need + * to filter if this is indeed a new client or it is because vchan + * server creates nodes under its UUID. + * + * Never try to instantiate a vchan server right under xs_path. + */ + if (!strcmp(watch_ret[XS_WATCH_PATH], xs_path)) + continue; + + found = false; + len = strlen(watch_ret[XS_WATCH_PATH]); + + pthread_mutex_lock(&vchan_client_mutex); + XEN_LIST_FOREACH(client, &vchan_clients, list) { + str = client->watch_ret[XS_WATCH_PATH]; + + if (strstr(watch_ret[XS_WATCH_PATH], str)) { + /* + * Base path is a substring of the current path, so it can be: + * - a new node with different name, but starting with str + * - a subnode under str, so it will have '/' after str + * - same string + */ + if (len == client->watch_len) { + found = true; + break; + } + if (len > client->watch_len) { + if (watch_ret[XS_WATCH_PATH][client->watch_len] == '/') { + found = true; + break; + } + } + } + } + pthread_mutex_unlock(&vchan_client_mutex); + + if (!found) + init_new_client(ctx, gc, &vchan_clients, watch_ret); + } + + xs_unwatch(CTX->xsh, xs_path, PCID_XS_TOKEN); + +out: + terminate_clients(); + GC_FREE; + pthread_mutex_destroy(&vchan_client_mutex); + return ret; +} diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index f387d7b8b2..458acc0748 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -802,6 +802,8 @@ libxl_device_pci = Struct("device_pci", [ ("seize", bool), ("rdm_policy", libxl_rdm_reserve_policy), ("name", string), + ("backend", string), + ("backend_domid", libxl_domid), ]) libxl_device_rdm = Struct("device_rdm", [ diff --git a/tools/libs/light/libxl_vchan.c b/tools/libs/light/libxl_vchan.c index c87024f00f..512b6b6641 100644 --- a/tools/libs/light/libxl_vchan.c +++ b/tools/libs/light/libxl_vchan.c @@ -99,6 +99,14 @@ void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, obj->u.b = val; } +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val) +{ + libxl__json_object *obj = libxl__vchan_arg_new(gc, JSON_INTEGER, args, key); + + obj->u.i = val; +} + static void reset_yajl_generator(struct vchan_state *state) { yajl_gen_clear(state->gen); @@ -297,34 +305,41 @@ int vchan_process_command(libxl__gc *gc, struct vchan_info *vchan) return vchan_write(gc, vchan->state, VCHAN_EOM); } -static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file) +static libxl_domid vchan_find_server(libxl__gc *gc, char *xs_dir, char *xs_file, libxl_domid backend_domid) { - char **domains; - unsigned int i, n; - libxl_domid domid = DOMID_INVALID; + const char *tmp; - domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); - if (!n) - goto out; + if (backend_domid == DOMID_INVALID) { + char **domains; + unsigned int i, n; - for (i = 0; i < n; i++) { - const char *tmp; - int d; + domains = libxl__xs_directory(gc, XBT_NULL, xs_dir, &n); + if (!n) + goto out; - if (sscanf(domains[i], "%d", &d) != 1) - continue; + for (i = 0; i < n; i++) { + int d; - tmp = libxl__xs_read(gc, XBT_NULL, - GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); - /* Found the domain where the server lives. */ - if (tmp) { - domid = d; - break; + if (sscanf(domains[i], "%d", &d) != 1) + continue; + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, d, xs_file)); + /* Found the domain where the server lives. */ + if (tmp) { + backend_domid = d; + break; + } } + } else { + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/%d/data/%s", xs_dir, backend_domid, xs_file)); + if (!tmp) + backend_domid = DOMID_INVALID; } out: - return domid; + return backend_domid; } static int vchan_init_client(libxl__gc *gc, struct vchan_state *state, @@ -440,20 +455,19 @@ static int vchan_wait_server_available(libxl__gc *gc, const char *xs_path) return ERROR_TIMEDOUT; } -struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name, libxl_domid backend_domid) { - libxl_domid domid; char *xs_path, *vchan_xs_path; libxl_uuid uuid; libxl_ctx *ctx = libxl__gc_owner(gc); - domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name); - if (domid == DOMID_INVALID) { + backend_domid = vchan_find_server(gc, VCHAN_SRV_DIR, srv_name, backend_domid); + if (backend_domid == DOMID_INVALID) { LOGE(ERROR, "Can't find vchan server"); return NULL; } - xs_path = vchan_get_server_xs_path(gc, domid, srv_name); + xs_path = vchan_get_server_xs_path(gc, backend_domid, srv_name); LOG(DEBUG, "vchan server at %s\n", xs_path); /* Generate unique client id. */ @@ -473,7 +487,7 @@ struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name) return NULL; } - return vchan_init_new_state(gc, domid, vchan_xs_path, false); + return vchan_init_new_state(gc, backend_domid, vchan_xs_path, false); } void vchan_fini_one(libxl__gc *gc, struct vchan_state *state) diff --git a/tools/libs/light/libxl_vchan.h b/tools/libs/light/libxl_vchan.h index 0968875298..e16db7a6ed 100644 --- a/tools/libs/light/libxl_vchan.h +++ b/tools/libs/light/libxl_vchan.h @@ -45,6 +45,7 @@ struct vchan_info { /* Buffer info. */ size_t receive_buf_size; size_t max_buf_size; + bool initialized; }; int libxl__vchan_field_add_string(libxl__gc *gc, yajl_gen hand, @@ -58,7 +59,9 @@ static inline libxl__json_object *libxl__vchan_start_args(libxl__gc *gc) void libxl__vchan_arg_add_string(libxl__gc *gc, libxl__json_object *args, char *key, char *val); void libxl__vchan_arg_add_bool(libxl__gc *gc, libxl__json_object *args, - char *key, bool val); + char *key, bool val); +void libxl__vchan_arg_add_integer(libxl__gc *gc, libxl__json_object *args, + char *key, int val); libxl__json_object *vchan_send_command(libxl__gc *gc, struct vchan_info *vchan, char *cmd, libxl__json_object *args); @@ -72,7 +75,7 @@ char *vchan_get_server_xs_path(libxl__gc *gc, libxl_domid domid, char *srv_name) struct vchan_state *vchan_init_new_state(libxl__gc *gc, libxl_domid domid, char *vchan_xs_path, bool is_server); -struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name); +struct vchan_state *vchan_new_client(libxl__gc *gc, char *srv_name, libxl_domid domid); void vchan_fini_one(libxl__gc *gc, struct vchan_state *state); diff --git a/tools/libs/util/libxlu_pci.c b/tools/libs/util/libxlu_pci.c index 551d8e3aed..7e2e8c6a6f 100644 --- a/tools/libs/util/libxlu_pci.c +++ b/tools/libs/util/libxlu_pci.c @@ -1,6 +1,8 @@ #define _GNU_SOURCE #include +#include +#include #include "libxlu_internal.h" #include "libxlu_disk_l.h" @@ -195,8 +197,10 @@ int xlu_pci_parse_spec_string(XLU_Config *cfg, libxl_device_pci *pci, name_present = true; pci->name = strdup(val); if (!pci->name) ret = ERROR_NOMEM; + } else if (!strcmp(key, "backend")) { + pci->backend = strdup(val); } else { - XLU__PCI_ERR(cfg, "Unknown PCI_SPEC_STRING option: %s", key); + XLU__PCI_ERR(cfg, "Unknown PCI_SPEC_STRING option: '%s'\n", key); ret = ERROR_INVAL; } diff --git a/tools/xl/Makefile b/tools/xl/Makefile index 5dfff7fc6f..0dbbbde17f 100644 --- a/tools/xl/Makefile +++ b/tools/xl/Makefile @@ -22,7 +22,7 @@ XL_OBJS = xl.o xl_cmdtable.o xl_sxp.o xl_utils.o $(XL_OBJS-y) XL_OBJS += xl_parse.o xl_cpupool.o xl_flask.o XL_OBJS += xl_vtpm.o xl_block.o xl_nic.o xl_usb.o XL_OBJS += xl_sched.o xl_pci.o xl_vcpu.o xl_cdrom.o xl_mem.o -XL_OBJS += xl_info.o xl_console.o xl_misc.o +XL_OBJS += xl_info.o xl_console.o xl_misc.o xl_pcid.o XL_OBJS += xl_vmcontrol.o xl_saverestore.o xl_migrate.o XL_OBJS += xl_vdispl.o xl_vsnd.o xl_vkb.o @@ -34,7 +34,7 @@ $(XL_OBJS): CFLAGS += -include $(XEN_ROOT)/tools/config.h # libxl_json.h needs i all: xl xl: $(XL_OBJS) - $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) + $(CC) $(LDFLAGS) -o $@ $(XL_OBJS) $(LDLIBS_libxenstore) $(LDLIBS_libxenutil) $(LDLIBS_libxenlight) $(LDLIBS_libxentoollog) $(LDLIBS_libxenvchan) -lyajl $(APPEND_LDFLAGS) .PHONY: install install: all diff --git a/tools/xl/xl.h b/tools/xl/xl.h index c5c4bedbdd..1419a8c1e4 100644 --- a/tools/xl/xl.h +++ b/tools/xl/xl.h @@ -202,6 +202,7 @@ int main_loadpolicy(int argc, char **argv); int main_remus(int argc, char **argv); #endif int main_devd(int argc, char **argv); +int main_pcid(int argc, char **argv); #if defined(__i386__) || defined(__x86_64__) int main_psr_hwinfo(int argc, char **argv); int main_psr_cmt_attach(int argc, char **argv); diff --git a/tools/xl/xl_cmdtable.c b/tools/xl/xl_cmdtable.c index 661323d488..5fbbe25a43 100644 --- a/tools/xl/xl_cmdtable.c +++ b/tools/xl/xl_cmdtable.c @@ -545,6 +545,13 @@ const struct cmd_spec cmd_table[] = { "-F Run in the foreground.\n" "-p, --pidfile [FILE] Write PID to pidfile when daemonizing.", }, + { "pcid", + &main_pcid, 0, 1, + "Daemon that acts as a server for the client in the libxl PCI", + "[options]", + "-f Run in the foreground.\n" + "-p, --pidfile [FILE] Write PID to pidfile when daemonizing.", + }, #if defined(__i386__) || defined(__x86_64__) { "psr-hwinfo", &main_psr_hwinfo, 0, 1, diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c index c8d2b794e5..5052ad9fe4 100644 --- a/tools/xl/xl_parse.c +++ b/tools/xl/xl_parse.c @@ -1491,6 +1491,7 @@ void parse_config_data(const char *config_source, pci->power_mgmt = pci_power_mgmt; pci->permissive = pci_permissive; pci->seize = pci_seize; + pci->backend = NULL; /* * Like other pci option, the per-device policy always follows * the global policy by default. diff --git a/tools/xl/xl_pci.c b/tools/xl/xl_pci.c index b1c3ae2a72..a1c0bc1e17 100644 --- a/tools/xl/xl_pci.c +++ b/tools/xl/xl_pci.c @@ -13,7 +13,9 @@ */ #include +#include +#include #include #include #include @@ -156,7 +158,7 @@ static void pciassignable_list(bool show_names) libxl_device_pci *pcis; int num, i; - pcis = libxl_device_pci_assignable_list(ctx, &num); + pcis = libxl_device_pci_assignable_list(ctx, &num, DOMID_INVALID); if ( pcis == NULL ) return; diff --git a/tools/xl/xl_pcid.c b/tools/xl/xl_pcid.c new file mode 100644 index 0000000000..a5d38e672f --- /dev/null +++ b/tools/xl/xl_pcid.c @@ -0,0 +1,81 @@ +/* + Pcid daemon that acts as a server for the client in the libxl PCI + + Copyright (C) 2021 EPAM Systems Inc. + + This library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + This library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with this library; If not, see . + */ + +#define _GNU_SOURCE // required for strchrnul() + +#include +#include + +#include "xl.h" +#include "xl_utils.h" +#include "xl_parse.h" + +#include +#include +#include +#include +#include +#include + +#include +#include + +/* + * TODO: Running this code in multi-threaded environment + * Now the code is designed so that only one request to the server + * from the client is made in one domain. In the future, it is necessary + * to take into account cases when from different domains there can be + * several requests from a client at the same time. Therefore, it will be + * necessary to regulate the multithreading of processes for global variables. + */ + +int main_pcid(int argc, char *argv[]) +{ + int opt = 0, daemonize = 1, ret; + const char *pidfile = NULL; + static const struct option opts[] = { + {"pidfile", 1, 0, 'p'}, + COMMON_LONG_OPTS, + {0, 0, 0, 0} + }; + + SWITCH_FOREACH_OPT(opt, "fp:", opts, "pcid", 0) { + case 'f': + daemonize = 0; + break; + case 'p': + pidfile = optarg; + break; + } + + if (daemonize) { + ret = do_daemonize("xlpcid", pidfile); + if (ret) { + ret = (ret == 1) ? 0 : ret; + goto out_daemon; + } + } + + libxl_pcid_process(ctx); + + ret = 0; + +out_daemon: + exit(ret); +} -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 15:05:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 15:05:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366778.597730 (Exim 4.92) (envelope-from ) id 1oBdvM-0006gp-D5; Wed, 13 Jul 2022 15:05:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366778.597730; Wed, 13 Jul 2022 15:05:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdvM-0006gi-AP; Wed, 13 Jul 2022 15:05:12 +0000 Received: by outflank-mailman (input) for mailman id 366778; Wed, 13 Jul 2022 15:05:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBdvK-0006gc-SK for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 15:05:10 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2fde0422-02bd-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 17:05:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6598.eurprd04.prod.outlook.com (2603:10a6:20b:fe::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 15:05:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5417.025; Wed, 13 Jul 2022 15:05:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fde0422-02bd-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWrrf36zn+WGTDn2EtvRflW2F/L+FYKbmI0vdGTKofAhstqtnwLp/Y8gwXpgy2+t4jxBv2IGJXQMmB5gyjUDK1DMVZY/+V9e11XiYNi4OP7fK2SQzG9P5Y4MpVfQVuX4GJH7lcmcCHV2O212GU0xx7Iiyzwox08U7anrIBLO/sIgUbX315W/g+nF4UFCWlBvpasneFqB0LoDNF5NiKx61Bnz+7b8/myvoqVy5uxzal0DJj4t3E4LtMkP5NHza3az1trHL0G+zBQ82rNxFIkPcvWSQTL/5QFeJFNNu7MVvi7DtVeVvXYohtlF5m2AIcGs1CEeCZtov2boWdveqUTM8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0XTmufvoscCX9eQghwm1iURatTZslRInzx94/0oYLM=; b=EK6hfz3P94Aw8pNzo0ab8v5rTJijwF3fhFXnsG0PhnhzvNP/b03wOcndbRKiuzP9ggIoGxWg2DTlJqwgB9qCDaSTCcUi+Prrz/NGvyET69ru+rJl4jLYJnKO7Oo5QmoVPcnRe9XG4IYs5R4NSisNF9MkM7M3fXp7gnqXyjg3jDJ+UMDmN6Kpr89/SRvne/HFgL+gXXIk9lqLrAl2qZBScMft/Sh6mVLXv3JQdL03VovMWmVzjhiTaijkclPCYu6tdEhH6wDbLEnVm+SpaNmTg1IkvEcYi2git0N+5RJxee9zHFHydncVSNUoLQ2W76tREHl7bs7MC9k2+k93skXHew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n0XTmufvoscCX9eQghwm1iURatTZslRInzx94/0oYLM=; b=rBP6zkkFSl+TZcLENW3vNcozVqLRw6VjCIQw9T6039dBaqXaF+uXXFEGk8+KqRw7JsjPvABWsGcZ3TiXtrdNK1scI5Om+gakQJl87lhF4oJftLPTG1UELuPOGvYYNSC3xdHhKoPmFcPQKq/fMDXS4L8mkdaE4bpLZgBr6pm91hE0c9eIvPIdLn9DbuHBsuu52h/+v7RqLPDD141oprVsLTgoZT6+h9xISgBIm6ejaeIcGlML8XmrzasAvIjs0Bn3c14Joj8EB3FLLz6xaYsqQU/sJRI1rPm1uSQxg+rpD76hhdSxp+W4cQqBQ9fh9wmxEKeuUR3LF4NNTMsOe+kQ7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <485a998b-614f-9749-2064-fea30c17d2a7@suse.com> Date: Wed, 13 Jul 2022 17:05:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, Juergen Gross , "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> <62e32913-cfcb-e0b0-2bbe-75cc8597951d@netscape.net> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0072.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 451afe67-d48b-4cd5-2714-08da64e11257 X-MS-TrafficTypeDiagnostic: AM6PR04MB6598:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jHM6yo0ntGF1EJaMFG0f+fhXnFKTOUwPZlwEvd/fYn5sfG1miJFQ7ZvGwTLJ7Ds+1dcWB06VBqOYzjX4E9dc2YsYT/OJwzf7JYnIDL9XgV0Oy490FjpvLRjW2WK0DG+ooQk4CPyTdxMhKN9cUfM7M0mNzAynvuCFCVWLx1n05XT2N1udHtZvoEDiYCS9YFn/ovD6Du3VnAI5I4UiL33D/33iH6HVSz3zjTui7gAQ2bg+NjcxYdO3okWdi9KCP6w2UB83GH6zEx3DSH0f5fXo8WQORbBJ+U28R6bEMqxTmKRlJFBUsZ9s/zGia50scLNxXwDF2/Xhnt1qI+oXurAF60eXlSvqG4SrQF35YYd3wr8c3dJM19VSdoI1id3oIt0gu/tYo52o9biHxa1zHTkDbVsMxvkCNwDMVA1o00QGQVHqrmFr41xi3yPzupi67L1S4iQKXiVNXabLsLoOCgXSy4WzKrVOQNw4bKalVaEEeEmTO11g3Vl/iektk3pVvfv551wMvHwLdY7vKGBQRzbFFJCa3qXgwWqNTmnXAPmwPXAfUYy3lcduod2LHZU/fYy4Kp0u0KedNphVoh9xR4wJhN/IP0caQqE8L6HQYVlkaMMetK0MLXhJ/pkCwQDgeBEbwqq/fQ77EZPwFME6FZeHOa5dQtXYfdpbJHjCku0KML4mji9JFMVAG0PjkYgLbRnCMqydjanv2/wX6FUzf4h3gqS0aoKNKftq+PpsgjH2l5os5CDE4Htdxi95t7s7V92V4vQXXQhYcwgnXyqMfpMWgNDXfMKUnCbZSkEB6rX91WWv3yXuBv8cMCFeHxCRs76fWDkYkcgoeH5YSol6bgm+tLcEy3OoopxfpvZlsGhpedU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(346002)(136003)(39860400002)(366004)(26005)(38100700002)(31696002)(8936002)(4326008)(8676002)(66476007)(66946007)(66556008)(7416002)(5660300002)(86362001)(2616005)(53546011)(6506007)(36756003)(316002)(6486002)(6666004)(558084003)(31686004)(186003)(6916009)(54906003)(2906002)(41300700001)(6512007)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dTNDVzVQbjlzbWlUeFQ3U0xFNUh1bnlJTE1kcE5IZXlPN0ROWnQrdmh6aS9u?= =?utf-8?B?RHJxakhhTEd2SVFtZkVmTmtqbkFuT2s3NWFkR1BLSVB4aUc0Sk1XdmVrRVli?= =?utf-8?B?WXhFVnA1WTdsLzBTVnh0RXVXNUhpSklzaUp0b3luUTRGZDBOM1JCaFZEL2Ez?= =?utf-8?B?bE9mcXhmQkNFRDd0Y0FQUE5RL251R2JNN0hkWkl4aDNFRlozQTBURVBOZk9w?= =?utf-8?B?ZGhCa0ZnNG5hNDRzc0Ywc1NzR1AwZUJaeWxISDFXQWx5MTFOQ3JLdjBOYkhY?= =?utf-8?B?UXRIZ2loa2s4dzQvU1JUR0E3eVF2QVZ4ZXMwbkR3aEVDQjFMcnVQVm9TT1NQ?= =?utf-8?B?cGlaZEE2eUtheVFncnBHWjdFYVpEVEQvK1ZxMWx4bTNMdFBEdHpubWhmSjgx?= =?utf-8?B?ajc2dGd1QUk5cDFVTDJEZUdjWlErb092NHlzV2lCNHhYaWZvMVlVcUZRS3M1?= =?utf-8?B?MGw5YlVlR1JlNFJNdU5oUzYyYnd4RjhkYUtnVjRZV1FuYVFJQVVkUTVNdWxv?= =?utf-8?B?LzIzaGdHc3p4L2FULzVybWxoaWhicmxRL0JBUlNhWnVsWlVUNVlHY2hoQXRT?= =?utf-8?B?RUQxQ0RvbXFRQzZlc0RGSFErVUNwemRiUU9NdFlhZDhxUVUrTFpIak94SmFJ?= =?utf-8?B?MVFrT1BQTVVaSXVTaHpXSm1uY3FsVjBIVk1aMWdPeTB0QU0rOXljSG8xWU9o?= =?utf-8?B?eDJQdE1YQnMzckI5d2hpN2paK2U3ejY2bThKRjl3c2FTRm1Hdk1NVFVzcFh6?= =?utf-8?B?QkJHcU5CWEIzRGdzaEhsUlMrNCtEdTJJVmtaOU5WN0thNyt2ekt4ZkU0Y0dZ?= =?utf-8?B?bW13eEZoMzZpaCtpNmZNTTJFVHhjWExQcXZxdTkzUkxCcklJcHVwWjJJd0I4?= =?utf-8?B?Wlp1NXBPY29mYjZyYXozdU1FQytxeGJ6OTFRT2VYREFwVDN5akZCelRCVlQ4?= =?utf-8?B?dGRZQXo2TzhOUmdvOU9GRE50bFlrZVRacURUY3VZN254ME41UTYrRTdaRkpj?= =?utf-8?B?SVgzSGl2WVNvZ2pOQ2kzS1F5SG9SaTByOVNVdGlUcW16WmlXTVNlU0RYL0hk?= =?utf-8?B?bEExVXo2c2pyOS95Si9vQkZacWJreHJXa0NZaVliMkhjKy92UGlYTHF4MEIx?= =?utf-8?B?eG9rc3lrZjVZdGFNTWdKNjhsS29TOW1Vd2haTEZUSzgxdDV1c1d5ajBOMGJH?= =?utf-8?B?RStuSmVrR1NJVDZRNVZ6anltMWtxMTZoMXQ1b1hYSlp6b1NsQ0xHRlBvZEF0?= =?utf-8?B?V2dVNnE5d3RnUmt1aFVEdFlhMnZSckxNYzZLWGs2bVpxZm1hN2pwUjBZZ3Vs?= =?utf-8?B?OHVvRHhuRHlQNFgxZ205NE9ZV2VZUTFhcXAvTkJiYzk1MVRGRWV6Zkc4dElT?= =?utf-8?B?b2ExdjRORU5CS0J4K3BWSGRDNlpaajZjbUIxVUFraUlkZXRFd05ySzNuV3gr?= =?utf-8?B?cm9JQ0g1VkY0eCszWHFpN2lsUXl4TVVzZUI4d0lGeWxTZStORlZSeUhSVS9m?= =?utf-8?B?Tnd3V2xYZE5oTnZ0TUVyN2NHUm9VeXBYV0FGaU9pNFJWQklDajVQU0JiRU5a?= =?utf-8?B?bzFmU3JrMGQ1NFE5U05XZHdkYXk0a0tsanNwMUlucVVPNEZ2azBGb1FuQU1Y?= =?utf-8?B?dmVaOThsNFRPa0d1MUdURGwweG5tU1RaM3YvZk5HUWM0blVxeFd0eFRYeWtS?= =?utf-8?B?NzdjdE5ienNaSk1zVUVYZG5kelRCS09vMnRMK3dDNWtpWVRPcUxEbVZkMFBS?= =?utf-8?B?U3Rwc0Zva2FycDlmcVJsakJjRFZzVjVodi9OZE1XM2F5d0ppc0dzYzdGTW9R?= =?utf-8?B?SnNaMkttQVByTGR5dlBmbG9OT1VKM1lkL1g5VFZYaUtxL1RkZElyQThRY3Nw?= =?utf-8?B?UnUzMWRVd05DL1hKTnoyQ2VZYkpqZGc5TkZDK1c1RThsWmpzMVc4MWxqQjF1?= =?utf-8?B?UDA4aThNc3RJSVQ1SDEzZnhsaEJac3hhWGtOUUlxNjRONjhUY3AwZ2RuSW5Y?= =?utf-8?B?TGk4aXVaM1VkbldMYmFPNXlqcWI3WGE1N090Zm1XcEZuS2VJbHF4SlBwNXlF?= =?utf-8?B?N0IzQU9CdHQ3MkFYUWVZOThBVGlSNi80TG9PNlRoRGs3dUljUWJvaUczVHcw?= =?utf-8?Q?mHaTf70QIC1lby+4Mz/em3NIx?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 451afe67-d48b-4cd5-2714-08da64e11257 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 15:05:06.9310 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z3MPmRnzJeHg09N7VH8OyG22xUujdyQ4MeoZe0WcwZ2lFqgwMTZV/8cn594Raq9gnRJV2X8cvSpujQ9a1inbJg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6598 On 13.07.2022 17:02, Chuck Zmudzinski wrote: > 5. I have been asked to help backport my fix to all stable branches. Before anything can sensibly be backported, we need maintainer buyoff on a patch. And then they may have an opinion how far this is reasonable to backport. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:21:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:21:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366834.597759 (Exim 4.92) (envelope-from ) id 1oBf6x-0000QA-CA; Wed, 13 Jul 2022 16:21:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366834.597759; Wed, 13 Jul 2022 16:21:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBf6x-0000Q3-7v; Wed, 13 Jul 2022 16:21:15 +0000 Received: by outflank-mailman (input) for mailman id 366834; Wed, 13 Jul 2022 16:21:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBf6v-0000Px-Vf for Xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:21:14 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd43f94b-02c7-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 18:21:10 +0200 (CEST) Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 13 Jul 2022 12:21:06 -0400 Received: from PH0PR03MB6382.namprd03.prod.outlook.com (2603:10b6:510:ab::9) by CO1PR03MB5889.namprd03.prod.outlook.com (2603:10b6:303:6c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 16:21:05 +0000 Received: from PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::64d9:22fb:9c9f:dc62]) by PH0PR03MB6382.namprd03.prod.outlook.com ([fe80::64d9:22fb:9c9f:dc62%5]) with mapi id 15.20.5438.012; Wed, 13 Jul 2022 16:21:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd43f94b-02c7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657729270; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=MrR/C61oTWDkMgmnLyHsNYaRFvwyAix+xmQuRcxwXik=; b=ajYYe9lLioyT5dwldwVbQNw0WXBFsK8ndKC+8A2lPe6ZdKbvC0Lt4wgN fzDCIkBjd0yB3Jw+chqODXObNvdJHnuuqpclkffPX4imLFKwKFTUDnVB6 iDwNVSiihIx4OrBF0b0ELFAHXsB1TdQBfELf7j5pSwgdO4PGEmZk4gAIX o=; X-IronPort-RemoteIP: 104.47.70.101 X-IronPort-MID: 75709168 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8fmR76yEIefQFv/HP7V6t+dAxyrEfRIJ4+MujC+fZmUNrF6WrkUEn TMYXm7QO/+Camf2e9BxbIW/9k8AsZSGzddrHQFoqCAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX1JZS5LwbZj2NY32IPhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Npl7YfsSgcEF7T1nukMQUJ8GWJyL41HweqSSZS/mZT7I0zuVVLJmq0rJmdpeIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtacG+OTvYYwMDQY36iiGd7EY NECLz5mYxnafBRLPn8cCY4knffujX76G9FdgA3I+vJmujaDpOB3+KnTH9X7eYCIecAPtV6Ij HDCrnamBQ5PYbRzzhLAqBpAnNTnhirhUYJUErCn8/dsqFaUw3QOFBAME1yhrpGRukO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM+e8CMU/4QCJj6DSvACQAzFcSiYbMYR/8sgrWTYty 1mF2cvzAiBiu6GUTnTb8aqIqTS1Om4eKmpqiTI4cDbpKuLL+Okb5i8jhP45eEJpprUZwQ3N/ g0= IronPort-HdrOrdr: A9a23:MKZI76DQi2Cc1GzlHelW55DYdb4zR+YMi2TDt3oddfWaSKylfq GV7ZAmPHrP4gr5N0tOpTntAse9qBDnhPtICOsqTNSftWDd0QPFEGgL1+DfKlbbak/DH4BmtJ uJc8JFeaDN5VoRt7eH3OFveexQv+Vu88qT9JnjJ28Gd3AMV0n5hT0JcTpyFCdNNW97LKt8Lr WwzOxdqQGtfHwGB/7LfEXsD4D41qT2fIuNW29/OyIa X-IronPort-AV: E=Sophos;i="5.92,267,1650945600"; d="scan'208";a="75709168" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mVZHEIjpeFN3rfcscHpHH0iAn8Pk4LEkL82eQZ/QYDdxtqQ/Klsy6jCQa3KkhHuKPdWduTP/AuWhcOR1AV5OpcrVFdqYWqv5VwlV5bhreK60vO3l1AOPco6WT/47nSHrnoXaeHC4EJUWK6mlKQ0BmEdZLStUj7GSq3+RF0cVvN+qkI00rzhU8Cttu5aZPflnPNCxLULG5CNbc8eMZRlxjPJLLL5G0L8yVYQ6RGNDaGL4Pe5BPO5DafV/tkwSrdlBj7fqv02yocQq1DjABbq7Q3cRLgb3hU0+NlMvorho5+8IbtOjKq2ku+BnH5jK1aqbYPVcjLr8F7rK1D1Za3ULKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b16pnGuYlnyP0bvSoWfyOoThuqtcPtqTtR4TFmJCzX8=; b=C9pA/mKMtmVIUtkQLhsNicLzeYdjHYn3j4MbM+MQJXV8JJycMTrM5JNAAiIMxnYxF02I3nidGpnrWkXLp/BTqKZoUGjUze4AIXRDMFB7ggSj51Lqqv/4ngZ8V9Yl914J6VgkTGYxx7Z7nS3zLwgskBb33m3V1BaLy3R88nWCn/UQpn8PwE9kA3wH+AYx94Zp7ybAeGGsLLRzYN4f7em9XFmDfV2IWt2ScjqVbXywCK43Fcgrx7VwIsxMF6Kcru+gnKUBo9ZF3PiIpHUoxXXx1Ay2aysWhfCR1fEWIyeeMc4RJrIQPmcboNMZpmuDh5bZWzqU2HMMGPK3bBGe5a6JfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b16pnGuYlnyP0bvSoWfyOoThuqtcPtqTtR4TFmJCzX8=; b=K8UZFnL6IQKirW9xKL+FUe219ZbbuPmAv/n1C14k1Q+otgponlYwqnHAzHV3x0AJglW18ze0QOCn+gC3HfLIhGcmpBJjD2XSKMmkJ+CtxKOKc3jblvae2XCKoTcJDXxtQrebohePfRbaPuhtO+cSvHQsjWwhLNOpGVCsmG64Lx4= From: Ross Lagerwall To: Sarah Newman , "Xen-devel@lists.xenproject.org" Subject: Re: [PATCH] livepatch: create-diff-object: Check that the section has a secsym Thread-Topic: [PATCH] livepatch: create-diff-object: Check that the section has a secsym Thread-Index: AQHYkN7aqV56xqXY6kKAbBDxTuBuP618hun8 Date: Wed, 13 Jul 2022 16:21:04 +0000 Message-ID: References: <20220706021817.20437-1-sarah.newman@computer.org> In-Reply-To: <20220706021817.20437-1-sarah.newman@computer.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 331827fe-d0f7-4d3e-1130-08da64ebaf4c x-ms-traffictypediagnostic: CO1PR03MB5889:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hZavrUWvMfwSxuKBGx+t7FIaoUg6cm4ldqSG/djeRnDsThE/7P3DyU9aG3rtWciWI3r9tSjEw7ptRzh2J6vRWIZwsHjD4Epkff8merBuunQ6K9a4QApS5V2somQ6j4M4DnA25XMednNioSV79Q7UV4O8iIJ8GF83KU42qvK7f7BkmwhRBx2Jf6YD1J6Nn++sxa32EBW9jxMk1Dq8QspjeEWwKfzASBZDbsJNm7MYrIEhee9VDX7tV6k3P0uk+hZOynzNwjRsUWso3Xa6FRJsZkzE9PlPpnW9vmHn3P6KjS2cp9z8oJlpv0X4Wu3WQBFq75Piw8YS3uYvEpGhbwb62AlfvSaV1GWgNdc4/0sgd9wIPMGYzFFzcSJt9kQuTiaV2FRnD+uISjelBhm0hImPCuYaW+cRCvLChWD6g6QPahwhL9H2gV7Wn2oER2uwA/GrsaWaygz7vUBLGLQRQWq2DtLrhabpP2Zq7Z1gGsagRN4NiyzeLZwUW0q8ZDFfTDF3OsnFFXyV8ymrTiZMrri/3EfzbWrBdkVAx3y/njNw/3O8pfuX8GADKm+JKlXP9YsHihoRhq0aD0gbRLf6t0WEvFR+7ABwZ1a/mOVy1ZBv5KfSH3bwAH5fiKiVyIGPKf22GIweABkCCHyk/v+HdGjHJPPuYyCB47LOiAEe55kjJmpBriQ8W1vmaMkv6N33g4zGKnlYrGo5HU/zlkuzmFIjcOdjY5kd0CHmE9FnAm8cKi6esR85gzYn3tP6cgX+o5Wnio42Lh0I8N2Sm7g64ZwwaFkfj64mKYXWyXi4b9R9OwJ9a6xgwJ2oNH4JEWojNZj2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB6382.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(39860400002)(366004)(346002)(33656002)(44832011)(55016003)(4744005)(110136005)(91956017)(478600001)(2906002)(86362001)(71200400001)(82960400001)(66556008)(66446008)(64756008)(66946007)(26005)(66476007)(122000001)(53546011)(76116006)(8676002)(6506007)(7696005)(316002)(38100700002)(5660300002)(38070700005)(52536014)(41300700001)(186003)(9686003)(8936002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?d1OILmsw4nmT5YP6bTgaifGK2KNHNgX8jpsTDfQ3T58qqZPMayhq/bQR3C?= =?iso-8859-1?Q?yjm3XdfHf+JzA5VOFzUgAsJQdv3CE+XwnUXe5uzod4sBNWIAGfXoIZ1qfu?= =?iso-8859-1?Q?l8+Uu9r9HKQJJHZ109S9wj+GJvriSfa4ffQzsZ0WtEfWcEvWoXuYoVsMvT?= =?iso-8859-1?Q?f6Csy32Drbgj4yDn8hg0foSQgaoHnU9Lrsvy++/C/uy9EgVJQC75Lg24BV?= =?iso-8859-1?Q?+o0lqB7ercovctJjRfSC2kvcBfmYcPzLfrNoyUXVRSBUOiB4Re+MkHbEwi?= =?iso-8859-1?Q?WzRyzOiq9OP/KrjrpVx5+oiKYRZgr5pT5rkl74taxqoctaTJKKXxgXcTO/?= =?iso-8859-1?Q?7KVoUfDjOiWJKOFJWc+leLMUfv2SAjifa/SOan2NWUEbUqwk5mET1mlwbU?= =?iso-8859-1?Q?9w8Cl/NEUpumxKBCyyOvcEkR4bvccTvaR4v5b5mBKzXCScOakpFE0Yo4IQ?= =?iso-8859-1?Q?z4NCbqHLSHTI28wX7PbeLHWdKWFUdVZLK0444wacTxxBcClAjjrlTeTOeZ?= =?iso-8859-1?Q?5b2qH6r3nzJ0unCIBuc+22u5PjpKa/BUZkU7oKwDxb1gIk8vh8gFGsx4Ec?= =?iso-8859-1?Q?MAei8CnQGDFcNMX+NZjK7MmRSCSo6a15x0/rxn2FVKZoNh8NfBcJDgBGrl?= =?iso-8859-1?Q?d7S0z39/mMad8kdTsKbvbsA/A4e1Y2seBkteOK7Kz1CeVyuZoYGjfwUIQy?= =?iso-8859-1?Q?oN4PgGAdoSxWVstnbt/mP5PURFnMbjB41aSaD6Z1RgoDdY4+qjKSekOwuu?= =?iso-8859-1?Q?1cSloeB11YXwTMtaV8I2D8CQSPfJ/kqZd9WVj/shqMo0abm4lu6IMDtW1f?= =?iso-8859-1?Q?h3aPU+qiY/vM+oj7Eejr+z19RWJTYTP9xHIKnCN2MOhCVfB+s1kRsh5UPg?= =?iso-8859-1?Q?2zO4o0+RmZy+wV6lY1Wscf59o8lo9HhMMx9i8BvQbEUK0Jkwf+/RQ6FlQr?= =?iso-8859-1?Q?TX4XQtH5tFFsUvOtEiGXUVy65JCVMZvxegGFp5mOfVUNV9VvAioGCKK+wL?= =?iso-8859-1?Q?Vew/l2EBkbVRGxaPWB6gbfBmLpZh7BC2tm3s9jNm/Wbkh5j9h/EDmDAgwK?= =?iso-8859-1?Q?ziS7DdPYnNGXdJLWopbw7HYCs/eMQTh11AtBMzViFUsyHvCJ/Jf/6j7VA+?= =?iso-8859-1?Q?txT33i6XmI9GYx3oS87WW9k3lKMadhS+D7r6jOro3SfUJJ7tj4z/k+RFx8?= =?iso-8859-1?Q?aPYWz8nHSuPZKUzZomqyzv1nEX48Exe6kbJuSjCf/Oxn187iPoFvBsoHTz?= =?iso-8859-1?Q?hhfHO4UQq0BXo7HEyE91615Y4lCquqrssXd233Nsikk4eVodA4Qc7Fe/qJ?= =?iso-8859-1?Q?IeuVKyIMMaHv5CAQbtIXtByg6YPpxB0GcNOjISyKWrZxCTlSE9fNMSGGv6?= =?iso-8859-1?Q?9WDnsPQQ+cwdKfPH0qUgGx2uZ1LGvi0Xyx0ANgAyc543btg4WpKGd5ELMc?= =?iso-8859-1?Q?crxsiSwmFvtWQnizk3oIEUecxngQRdbaj+CIT6oxvRULPPoJizgBQd4P10?= =?iso-8859-1?Q?00iC797S8EbJOqLUZ19PRVKMsXAtfiOxABmqgl7FNLf4ajk5N7ptzndY08?= =?iso-8859-1?Q?Ott4vQoyB4FdjuHT5x9pWBLrrthk1D2r8LqvYW34+a7/329tdiQVJitSDD?= =?iso-8859-1?Q?MJEKewKAHpxtJwxDVaa31XWfN1LLnwMKDz?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB6382.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 331827fe-d0f7-4d3e-1130-08da64ebaf4c X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jul 2022 16:21:04.6811 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: npIOpZpouy23Yb1T/F8RY/UYWTlwLU8W3e8dKDLiCwRpphK0B8LWxwDlhqEtmdFt4hGcLpsXRE/vdovDmNaTFzVQ9tJJSoVyb1Bb6OCY5Rs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5889 > From: Xen-devel on behalf of Sar= ah Newman =0A= > Sent: Wednesday, July 6, 2022 3:18 AM=0A= > To: Xen-devel@lists.xenproject.org =0A= > Cc: Sarah Newman =0A= > Subject: [PATCH] livepatch: create-diff-object: Check that the section ha= s a secsym =0A= > =0A= > A STT_SECTION symbol is not needed if if it is not used as a relocation= =0A= > target. Therefore, a section, in this case a debug section, may not have= =0A= > a secsym associated with it.=0A= > =0A= > This is a livepatch backport of kpatch upstream commit [1]:=0A= > create-diff-object: Check that the section has a secsym ba3defa=0A= > =0A= > Signed-off-by: Sarah Newman =0A= > =0A= =0A= Reviewed-by: Ross Lagerwall = From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366874.597795 (Exim 4.92) (envelope-from ) id 1oBfGg-000391-0D; Wed, 13 Jul 2022 16:31:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366874.597795; Wed, 13 Jul 2022 16:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGf-00038F-Pt; Wed, 13 Jul 2022 16:31:17 +0000 Received: by outflank-mailman (input) for mailman id 366874; Wed, 13 Jul 2022 16:31:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGe-00035D-7H for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:31:16 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2067.outbound.protection.outlook.com [40.107.104.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 36bf0573-02c9-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 18:31:15 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 16:31:12 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991%6]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 16:31:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36bf0573-02c9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdqDrjrPfltX+vj28Yq5YzPy2OIt/4OHk1ktTlhWd0krippHSguVhd8tFktQ0dTO/DCVJtamcahOk+nxWaFVGJlg4BHAlhkjaC07b4ZosAbAvVqQfkfjDbs0cTBz6acN7CCo6DoloSjNQmNcHaeD6IM+l4nHD0eSxlFzDUu/Bm7g6wr87swlyWyCWYnaTl8Bd5HFgFNuAo/QIrgkzr3s6t+HM1wX81a8ve6ANMCRxE7PX5chMJyefonqceMYKzvY3oRg+CSTtvDu50aY0AxywsLo7PS/zPwYp4PqHXz7UYXurOaLGIPXTtQnztkvVFRHoGL56+IKWolPz3d8bm8K5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0p9WID8wCWme7yTVDlS/nHDHlNEKgtykRbLwYbaQeI4=; b=Emulg3+6T4a3SE2tes00OcPcEfuIyQlVJXu9xPOqBCQyJvFXNHqCgVwIqt6vipKj8Zjpc9CxZXIbza+31qx2nNtZtYccHov2wn984eobkcKz7LVFajQUgPqNB+77O9IGLJ6paQ90LBZRnMBqR+EJGWKWTKk0Dhes185hk2FKtTiu+mNiz/EqPqnOP4m17FZRfTSVNT9CKR/0+EhKZtyL2rIgaBmeXovhVi07G5wTRKK79pEI7aS8YfbgtvQRDARV6MwpiPwShTecgyVTA2+V2lriPnwoYtmAJVJbGhP+lmJqkSGS4RKN5FK8Y8qdb6V2Utms7FxlDA7kmAaq4Snb+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0p9WID8wCWme7yTVDlS/nHDHlNEKgtykRbLwYbaQeI4=; b=MBOLXsBVERafZbLh7mkeLaZFo2epkrLgUA/HZW1MFs0A6SZ2zt26DRSBFEa1BQ/464BczpJR1H4u1/5OAhakuUVHFj8w+YD5z/bCddeq697DfQJvxU9g9CIAiJBMTmlOUBptaqodKEgSTHHDSoZHt2O3KypqBv1y24GcnCgLoAo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: [ImageBuilder][PATCH v3 1/3] uboot-script-gen: Dynamically compute addr and size when loading binaries Date: Wed, 13 Jul 2022 19:30:42 +0300 Message-Id: <20220713163044.3541661-2-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR08CA0022.eurprd08.prod.outlook.com (2603:10a6:208:d2::35) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9cf94d7b-33f0-47f4-4bbb-08da64ed1918 X-MS-TrafficTypeDiagnostic: VI1PR04MB4893:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AafPFvYV+v5lxHgOj7XIkckOVmNDIuWbDaSt/XJeXaZbr9pGGZC8v8m+z16Bq8HsW2c5W/FEX1PaszfRqvXpTiAphcK896JethKJu4PKUBJfG4vGBPAPYoTGWSTN7retkOFKFUZCNOwQlb6Uuy1AWcQH8SQ8EFQKZ6xUHjT91fhOmuw2x7mZie7HrJLu2rNq5GfRvG5nrP6ATXwlIxncHucxELVQ2FTX2kiz8WBANjvgnvILRqoK7Yd8+y3x53R6zMMwLPBp+f6ZazN5eHYWaC8dj/xbBlpcx4K1LV8sOVa6qN6UNcotnESS3NlFNlnl0eUiUoBhjDxbRjsAp0w0d7bl6ESHAsg06RQIf7Y1bBA5KXEIuEeWH3dN4YtPFm6oQor023SckcNyto3fRh+veoU+B1965Wt7rcnjIm9umBNP44Z2riQ/NEbsnyGNNf3f5NrJR4x9dYf4rqBrN/qSM4Mw81pD+iGYUzDLQELIC6cmXM2YkwxqZjH4orBUk+IkbUfWIhWiS6HQmQwQml5VscDdjNlef/gs5pgYfuU//QvPK7BTquo6+o8H4esbksSqDv5nBmDsuIpiMjyNxct4dYxZgqVL5PIaULWm18VfCB1ozs2j53xUMSWxVCFnGVIXvm+S+T37STCxgXnAMtCiW05Qa5eJclbnwLeIF+gopccyqeU6mKw+a9CsZTuVWB/pdA8qS1LNziwe2ZrAZvGSeI8qMyvill5W0e6kl3NoLGYIHHH3kuIp42xXzLwZgxY4SHIMo4SAgEgMMU49JI1M+XBYUnja4JSWjRs0l1E7Mkwoy79DLEoaRWxAWNcTF/Wd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(83380400001)(86362001)(38350700002)(38100700002)(8936002)(5660300002)(478600001)(6486002)(30864003)(6666004)(41300700001)(6916009)(6506007)(316002)(52116002)(4326008)(66476007)(66556008)(8676002)(66946007)(186003)(6512007)(2906002)(2616005)(1076003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lg6aoX5P3bHY0og/gSzld682c3Ky/vP+JCeMrimuoCuJYDzGBTSzEKN3jnUo?= =?us-ascii?Q?KOzCsDnyUvzTWNlOHOp68V/WuVPh1LQYKme5EqRAvFIjyde/5nE9aWhoAly4?= =?us-ascii?Q?5mnGWq3O9VnJ0UwLjqoYyblNoNVeRc4iyWCNNbyrFXot5XnR2zFpyX3DLyFx?= =?us-ascii?Q?GRYSlwBvawq4H9u8Gt4Zto+A91PcCgncdkhOcTrGoM0gB4miK8/5jKS/s/8A?= =?us-ascii?Q?3GZuTGbQU03CfZOQZhXENPCuIxMtTz9sx7VXWC+AUniMKMhG+0R/0Au8T3D6?= =?us-ascii?Q?mkgnl0mLGGyUlAoBJ0yrLo/DV5linFDn5RWrPfWM5pyowntaL+8RZRUHTCzk?= =?us-ascii?Q?8VYWFW9EVeFRI/Lpn90tmICyDZUE2p7mNJda0kenKvEaeSfZl1lFBaZi0zSw?= =?us-ascii?Q?prNxgisBtZS4y0x1rIAB34Wu3MHgrYXWSvpaIp8E8b6ikAP0HFve+m/xjPDd?= =?us-ascii?Q?dwzFyrXlsTVC96UAbclHlBaDIg/55rKqmASTCSIghePjfBku7iJ7mq040itK?= =?us-ascii?Q?TdPfw8xeWDv9snan3XE7tqzVXRmTP982oFrrQj81pSPUqXl048kPCC6sVxmU?= =?us-ascii?Q?eC4F/vtp9z+4W2UjwfDB96FsYPMKrQmEDO899EEatazdfU5Al3V1LC79r5NH?= =?us-ascii?Q?X8qfm14+20pCPq7ExX8doCM3dIuIkSOlK9JqtiEyFhg4GWoaX31iJzlwnJ/n?= =?us-ascii?Q?D1nNSu+mw0R4GlO2ObU310pz19mvx3FSMXn3ewhrVF0waEv0tflJLrebJADs?= =?us-ascii?Q?I0Xe5PCTTp6pwI42HRK/gjqVpXA5V4jgjKMxsCr5gt6HsWxTx8rQDoaPrxW4?= =?us-ascii?Q?h4OQ9aBK1pjd8mLjqjBHj21SU1TQbQblWj3HM3QBxEuISpwbZv6bfG9vrVBX?= =?us-ascii?Q?+lzl3NgXhqAWY6w2vrLpxYV8vwS715jXq4yOhDcFctWPOL2soB3ZSK/Rlw6n?= =?us-ascii?Q?7DG295ejYgtb4mXFPS2VKGyBxxxcsQ7hc4u6imHhC5Z+XhTwU+bBzMX2dblm?= =?us-ascii?Q?JwWm/NRWCyVAPh4PjuEDrnZbLPmSAvC/Llv3phjTzC9thpRJTc37tgODhNU5?= =?us-ascii?Q?CkoAl2w8P73YvuaMDhaDLuax9tHGfH+yWS4NG3T05wy2G7ohcdc/SJswXhHc?= =?us-ascii?Q?lyalWp0UdVoKmptA3Kp9BPYQXVAKhDrq1iQjUxogk3Jy+F4BVXUceZbYtLr1?= =?us-ascii?Q?LBxc+9O/cgyjWcku36AN7pnAFe6VP24o6jCexRSos6Xj9ie5jvj5/0c7UoDn?= =?us-ascii?Q?W2sB5Zvr9JwapjJu9BCTOBdbg11EFj0ypJzgi6gzgl4IuvQ8GXG2o29fDqVT?= =?us-ascii?Q?gGd0p6LZnx/fgn2jLpOkv+N+/2hrulD/kb2L4qo5WaRkBp1SiyLeWqFhGQ0S?= =?us-ascii?Q?tyFZMAvhutIWPOM3KVw/MRxDCmVfLDHTZnADGcNAVPvawjA+p8GvxSwDq/Ib?= =?us-ascii?Q?g57l1PaqpTxl+ppXfU0+rbvUXkgs16DKbQWdZrRpVlhoaQjY/vwqcGEfepmP?= =?us-ascii?Q?9+WMzJOfHO0bZmrcCo95z8YZNb4Ej7lOs4Hxat1AgIu2K/gOYdfXx9ymYAiG?= =?us-ascii?Q?+xk2yWyRWSld7ZfXBBAjqUKkmUkxNL8n462ypAh5ra+TGaty2ufgi+S1M/LU?= =?us-ascii?Q?lg=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9cf94d7b-33f0-47f4-4bbb-08da64ed1918 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 16:31:11.9270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: C/4rivODVPS8rlEtcax28qLBlyExKlhpPxp/1P2jNn3Khd1MEptHoQW1iG7/EYF6F97Ibr9tHH6gf/C+VBQzwqMsD28a/ldkQBw5WkicvXM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 From: Andrei Cherechesu Normally, the script would precompute the sizes of the loaded binaries and addresses where they are loaded before generating the script, and the sizes and addresses that needed to be provided to Xen via /chosen would be hardcoded in the boot script. Added option via "-s" parameter to use the ${filesize} variable in u-boot, which is set automatically after a *load command. The value stored by filesize is now stored in a u-boot env variable with the name corresponding to the binary that was loaded before. The newly set variables are now used in setting the /chosen node, instead of the hardcoded values. Also, the loading addresses for the files are dynamically computed and aligned to 0x200000 using the `setexpr` u-boot command. Basically, if the option is used, there are zero hardcoded addresses inside the boot script, and everything is determined based on the MEMORY_START parameter and each binary's size. If the "-s" parameter is not used, the script does not store the binaries' sizes and addresses in variables and uses the precomputed ones when advertising them in the /chosen node. Signed-off-by: Andrei Cherechesu --- scripts/uboot-script-gen | 136 ++++++++++++++++++++++++++++++++------- 1 file changed, 114 insertions(+), 22 deletions(-) diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 8f08cd6..f8d2fb0 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -4,6 +4,9 @@ offset=$((2*1024*1024)) filesize=0 prog_req=(mkimage file fdtput mktemp awk) +padding_mask=`printf "0x%X\n" $(($offset - 1))` +padding_mask_inv=`printf "0x%X\n" $((~$padding_mask))` + function cleanup_and_return_err() { rm -f $UBOOT_SOURCE $UBOOT_SCRIPT @@ -91,10 +94,18 @@ function add_device_tree_kernel() local size=$3 local bootargs=$4 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" - dt_set "$path/module$addr" "bootargs" "str" "$bootargs" + if test "$dynamic_loading_opt" + then + dt_mknode "$path" "module\${"$addr"}" + dt_set "$path/module\${"$addr"}" "compatible" "str_a" "multiboot,kernel multiboot,module" + dt_set "$path/module\${"$addr"}" "reg" "hex" "0x0 0x\${"$addr"} 0x0 0x\${"$size"}" + dt_set "$path/module\${"$addr"}" "bootargs" "str" "$bootargs" + else + dt_mknode "$path" "module$addr" + dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module" + dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + dt_set "$path/module$addr" "bootargs" "str" "$bootargs" + fi } @@ -104,9 +115,16 @@ function add_device_tree_ramdisk() local addr=$2 local size=$3 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + if test "$dynamic_loading_opt" + then + dt_mknode "$path" "module\${"$addr"}" + dt_set "$path/module\${"$addr"}" "compatible" "str_a" "multiboot,ramdisk multiboot,module" + dt_set "$path/module\${"$addr"}" "reg" "hex" "0x0 0x\${"$addr"} 0x0 0x\${"$size"}" + else + dt_mknode "$path" "module$addr" + dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module" + dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + fi } @@ -116,9 +134,16 @@ function add_device_tree_passthrough() local addr=$2 local size=$3 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + if test "$dynamic_loading_opt" + then + dt_mknode "$path" "module\${"$addr"}" + dt_set "$path/module\${"$addr"}" "compatible" "str_a" "multiboot,device-tree multiboot,module" + dt_set "$path/module\${"$addr"}" "reg" "hex" "0x0 0x\${"$addr"} 0x0 0x\${"$size"}" + else + dt_mknode "$path" "module$addr" + dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module" + dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + fi } function add_device_tree_mem() @@ -186,7 +211,12 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0" dt_set "/chosen/dom0" "compatible" "str_a" "xen,linux-zimage xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)" + if test "$dynamic_loading_opt" + then + dt_set "/chosen/dom0" "reg" "hex" "0x0 0x\${dom0_linux_addr} 0x0 0x\${dom0_linux_size}" + else + dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)" + fi dt_set "/chosen" "xen,dom0-bootargs" "str" "$DOM0_CMD" fi @@ -194,7 +224,12 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0-ramdisk" dt_set "/chosen/dom0-ramdisk" "compatible" "str_a" "xen,linux-initrd xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)" + if test "$dynamic_loading_opt" + then + dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 0x\${dom0_ramdisk_addr} 0x0 0x\${dom0_ramdisk_size}" + else + dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)" + fi fi i=0 @@ -241,14 +276,29 @@ function xen_device_tree_editing() dt_set "/chosen/domU$i" "colors" "hex" "$(printf "0x%x" $bitcolors)" fi - add_device_tree_kernel "/chosen/domU$i" ${domU_kernel_addr[$i]} ${domU_kernel_size[$i]} "${DOMU_CMD[$i]}" + if test "$dynamic_loading_opt" + then + add_device_tree_kernel "/chosen/domU$i" "domU${i}_kernel_addr" "domU${i}_kernel_size" "${DOMU_CMD[$i]}" + else + add_device_tree_kernel "/chosen/domU$i" ${domU_kernel_addr[$i]} ${domU_kernel_size[$i]} "${DOMU_CMD[$i]}" + fi if test "${domU_ramdisk_addr[$i]}" then - add_device_tree_ramdisk "/chosen/domU$i" ${domU_ramdisk_addr[$i]} ${domU_ramdisk_size[$i]} + if test "$dynamic_loading_opt" + then + add_device_tree_ramdisk "/chosen/domU$i" "domU${i}_ramdisk_addr" "domU${i}_ramdisk_size" + else + add_device_tree_ramdisk "/chosen/domU$i" ${domU_ramdisk_addr[$i]} ${domU_ramdisk_size[$i]} + fi fi if test "${domU_passthrough_dtb_addr[$i]}" then - add_device_tree_passthrough "/chosen/domU$i" ${domU_passthrough_dtb_addr[$i]} ${domU_passthrough_dtb_size[$i]} + if test "$dynamic_loading_opt" + then + add_device_tree_passthrough "/chosen/domU$i" "domU${i}_fdt_addr" "domU${i}_fdt_size" + else + add_device_tree_passthrough "/chosen/domU$i" ${domU_passthrough_dtb_addr[$i]} ${domU_passthrough_dtb_size[$i]} + fi fi i=$(( $i + 1 )) done @@ -271,7 +321,12 @@ function device_tree_editing() if test $UBOOT_SOURCE then - echo "fdt addr $device_tree_addr" >> $UBOOT_SOURCE + if test $dynamic_loading_opt + then + echo "fdt addr \${host_fdt_addr}" >> $UBOOT_SOURCE + else + echo "fdt addr $device_tree_addr" >> $UBOOT_SOURCE + fi echo "fdt resize 1024" >> $UBOOT_SOURCE if test $NUM_DT_OVERLAY && test $NUM_DT_OVERLAY -gt 0 @@ -306,7 +361,7 @@ function add_size() function load_file() { local filename=$1 - local fit_scr_name=$2 + local binary_name=$2 local absolute_path="$(realpath --no-symlinks $filename)" local base="$(realpath $PWD)"/ @@ -314,11 +369,30 @@ function load_file() if test "$FIT" then - echo "imxtract \$fit_addr $fit_scr_name $memaddr" >> $UBOOT_SOURCE + echo "imxtract \$fit_addr $binary_name $memaddr" >> $UBOOT_SOURCE else - echo "$LOAD_CMD $memaddr ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE + if test "$dynamic_loading_opt" + then + echo "$LOAD_CMD \${curr_addr} ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE + else + echo "$LOAD_CMD $memaddr ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE + fi fi add_size $filename + + if test "$dynamic_loading_opt" && test ! "$FIT" + then + # Store each binary's load addr and size + local binary_name_addr="${binary_name}_addr" + local binary_name_size="${binary_name}_size" + echo "setenv $binary_name_addr \${curr_addr}" >> $UBOOT_SOURCE + echo "setenv $binary_name_size \${filesize}" >> $UBOOT_SOURCE + + # Compute load addr for next binary dynamically + echo "setexpr curr_addr \${curr_addr} \+ \${filesize}" >> $UBOOT_SOURCE + echo "setexpr curr_addr \${curr_addr} \+ \${padding_mask}" >> $UBOOT_SOURCE + echo "setexpr curr_addr \${curr_addr} \& \${padding_mask_inv}" >> $UBOOT_SOURCE + fi } function check_file_type() @@ -536,6 +610,14 @@ generate_uboot_images() xen_file_loading() { + if test "$dynamic_loading_opt" + then + local curr_addr=`printf "%x\n" $memaddr` + echo "setenv curr_addr $curr_addr" >> $UBOOT_SOURCE + echo "setenv padding_mask $padding_mask" >> $UBOOT_SOURCE + echo "setenv padding_mask_inv $padding_mask_inv" >> $UBOOT_SOURCE + fi + if test "$DOM0_KERNEL" then check_compressed_file_type $DOM0_KERNEL "executable" @@ -891,7 +973,7 @@ function print_help { script=`basename "$0"` echo "usage:" - echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH]" + echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH] [-s]" echo " $script -h" echo "where:" echo " CONFIG_FILE - configuration file" @@ -908,6 +990,7 @@ function print_help echo " U-BOOT_DTB - u-boot control dtb so that the public key gets added to it" echo " -f - enable generating a FIT image" echo " PREPEND_PATH - path to be appended before file names to match deploy location within rootfs" + echo " -s - enable dynamic loading of binaries by storing their addresses and sizes u-boot env variables" echo " -h - prints out the help message and exits " echo "Defaults:" echo " CONFIG_FILE=$cfg_file, UBOOT_TYPE=\"LOAD_CMD\" env var, DIRECTORY=$uboot_dir" @@ -915,7 +998,7 @@ function print_help echo " $script -c ../config -d ./build42 -t \"scsi load 1:1\"" } -while getopts ":c:t:d:ho:k:u:fp:" opt; do +while getopts ":c:t:d:ho:k:u:fp:s" opt; do case ${opt} in t ) case $OPTARG in @@ -957,6 +1040,9 @@ while getopts ":c:t:d:ho:k:u:fp:" opt; do p ) prepend_path="$OPTARG" ;; + s ) + dynamic_loading_opt=y + ;; h ) print_help exit 0 @@ -1151,7 +1237,13 @@ device_tree_editing $device_tree_addr # disable device tree reloation echo "setenv fdt_high 0xffffffffffffffff" >> $UBOOT_SOURCE -echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE + +if test "$dynamic_loading_opt" +then + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE +else + echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE +fi if test "$FIT" then -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366873.597788 (Exim 4.92) (envelope-from ) id 1oBfGf-00035V-Kr; Wed, 13 Jul 2022 16:31:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366873.597788; Wed, 13 Jul 2022 16:31:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGf-00035O-HX; Wed, 13 Jul 2022 16:31:17 +0000 Received: by outflank-mailman (input) for mailman id 366873; Wed, 13 Jul 2022 16:31:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGd-00035D-H4 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:31:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2067.outbound.protection.outlook.com [40.107.104.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 35aef3dd-02c9-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 18:31:13 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 16:31:09 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991%6]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 16:31:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 35aef3dd-02c9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhkF1mY16P9ZWJ5u/9a/kH67tB2NkubyXzSrf+ZDF6VsPz36GZUw9ZNAl1rOm+zvw5iCIkRFdvA+PAUqFAPG8cuG+Z3Dr6Pjs6ySmiRem1S0yUJNiietFlrnlY+D6DT31aN6DVa2RmSSPWUqs9X9XJA37poAqLAd6TBIWFNTD7AxS2Q9fJ4euvgHy4lBeqH7wp85ooWYYcGvfwCv+A8LlzDJkE9RQCdwlAPxLVOl3NQmQHvxw5YyO7+FPH7o64Z2ohtoi7Ev4uzvqpBQfFVLpYM5hLcf1j51OWjvlBHsN4xH2A17ti9y4pEfXseFEY8/7CZG4dVTEzHaSQeygqd7og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CBnG/KHpOC9rWbWx8d1Pz6ZSMmY/aZckRPO5j4SDNSg=; b=A1Fmto7gleiaITVmP+rH8HyofyFVyzsBEcPpXsJx2kgQjOsgxWn2JX2sat31eu07I4XcrS1wYOgF79hGW0Cxn2P4bs8jNQoegZTH0U9UUv00vV5Ijnd1IC74+EAPirnJ2kv6fVp0+CSX2hMremMkINn/rag9NCWbsk0ySThCfS8DEXCJIYSm3CYELVuofpnoDd1Vyb5e+THBS8mgFBPYkxpQA4yOcoCD/uBfWcXc46mdkOLxBybi7yZ4dYm14Yp8fsC+0z+FyNrEosNNColvQm2knHBc/VNaNIcZ4qUABAtKAet6NWUEXnQfTuHMsd3cmVo1HPJvWd6ba8nqXsHeEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CBnG/KHpOC9rWbWx8d1Pz6ZSMmY/aZckRPO5j4SDNSg=; b=cE74XqLtp1wPu+dr9yzIzZkXj1bdF5pEE430gAqDFGhKi9uHCBliu/zuEymOiv2AIGnk/3wcWDwVSn07hOX0x/TBfajAhQ+6xluorChIo/QTSgveaSCd0CObYTpSYO4L3nOeyITIg0GDmtUEJq4Eg+nd/+7dyLVOTd5l86T3Hz4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: [ImageBuilder][PATCH v3 0/3] Add extra ImageBuilder features Date: Wed, 13 Jul 2022 19:30:41 +0300 Message-Id: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR08CA0022.eurprd08.prod.outlook.com (2603:10a6:208:d2::35) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11ef1fc1-f347-4df5-b834-08da64ed1755 X-MS-TrafficTypeDiagnostic: VI1PR04MB4893:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DV0lJdSem15GE/PUHJ0ruAXExDyHAZRhn4JF611DAz0KCd0CvM6mzbWNpaRfq1Srd4rpj/uRIp1algXkD+pLPfK80XzBjENg9CsFY302t5M76GArK4qQVc/M8wo92wK4NjY6BdG/X2YBWuOJwk8ROTO+AXXbF5th9XYn+QdJDrvS/Se0h8W5jpOTR8qTSSl7Fx1zXK58Gj1ZfpOWhGdlK9ViQdVzs/WXDNooDoebSg7HJ9IH3uqGM7KoSQdIR4/3PtFyqiwZ8R0snyLJmxAEi7sHY1XSnUPUrFO2k4YPD0qMIUvl8JzKO63vl+WHe+ctfEdLKx9jpP0xad+WPQHmkK7x7WEVFQ4xY0TfAZVXuy8Nd/coDtNHMT2UZOtbSw2+6J1O1x9saSyM35ThKgsS+ziECPT89u0hSWn+0zQEccMpolJXzYYJPlPDuM/JvnTDVuct2nInE1U2vB2LKo5xI0K19pfAwM5Xy/ruuNyysArCtD7XQUrbhawV/gbhcxZgITCT+o9D/CoZWZflcjdAViGj3dTKF0ln3m8fWlgWIbOByma3Ia6z9BG34MZ4R0fBNoqZCQtReX0p2tGbpGHpJksiLdGzMoa1xaEbUN2wnpB5t9kn3kIlk3W27ctREN4pVmTB1JrXCHb1akWztlGzVhM5wLSpqH3Dls47imq7D817LSrbA2M2lAhMf2/o3MpwTlzktWZ6rEIiontgtW1POrj+juDAxwGY+Xh/Ay907QEy0+2N5VsA6qbgOITAgMG5RUnTIWVWiMUx7BZBhlP2af6EtQEmv/i0kVYsUGxF1l/cEwyvlTCNIDRIAQS8c7hF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(83380400001)(86362001)(38350700002)(38100700002)(8936002)(5660300002)(478600001)(6486002)(4744005)(6666004)(41300700001)(6916009)(6506007)(316002)(52116002)(4326008)(66476007)(66556008)(8676002)(66946007)(186003)(6512007)(2906002)(2616005)(1076003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yGn+r/zE3JdICcaPJ7Jfu9P8hQ29LiMvJK0XGY6sFdaUQxa6DpWtysaqlurd?= =?us-ascii?Q?/QK2YBGLNhBgiJZPOXw2rNKxeBsd9Ksq86a5LBSgOCBQsRnfhNhhozDFV0N/?= =?us-ascii?Q?1FSz+9LC2LbIYcuLhBB02QP3I6Zg1zq7/QOwYnYWZ/7b29Z59HYNxIh4O4/J?= =?us-ascii?Q?SeqDFAlnjXwsvShtmcxHwPB4O7v8kbl2YvtdaI2x7cXK/XuqvLyd451Rl7Sq?= =?us-ascii?Q?yJkxPGpk41395PCIQkGRt6rH6ECcnVy9Xr2u3dGIcvI//rxIpzduEv/xlMFR?= =?us-ascii?Q?DUrzXFehcV+OOA2GWP0eCgPArAH9Ap0JgEvDoVHr5CeP8bgbjSuTO4d9JaMs?= =?us-ascii?Q?OhyldStYS/L0/MY/6GkmzoOgaB2dOZuQaqbQpekh24J2OqqGxGCOE9sepkAL?= =?us-ascii?Q?sjlExEViyFKbZV/yAqrPJLHGk3R7KFBAuAJ7OTgVjjQ2Ubcx8UzilLMHIgwj?= =?us-ascii?Q?zFXIUeoxERNYKlP0DJX1RAG3ts8S2wuroYsQZDlNN2sOz+/MePpZWaSvBj5m?= =?us-ascii?Q?Ot16PSLAAm4Wc6ZZlPgf7aMQlXWs4FGEsTwW648xCHR7iDyoE7nBolDyp4zE?= =?us-ascii?Q?/lNGgZhPEnN5FidR1x25nhwVJpcxYqfCtldxO6uuvuW30lNs+HDeOjjL/7QY?= =?us-ascii?Q?AY0A4ukmd0JFRbWysp6w+uB2K6T/+fZhIXOkJLi6eVq3nW1pAlXbABNnW1Mn?= =?us-ascii?Q?dGmbgaPT8g793wa/cAZn7sqZrr1SbA8Eiqz5RmbgbM9AHSE3oCZ3p/5RkHa3?= =?us-ascii?Q?8dEkOde/yzgYDLl0lFPKX9uEKHoL5ytu+Jq0rahScp6/VsR54hciS3BCcCt1?= =?us-ascii?Q?6ENrPyR4o96UtuyJlm5dfEmAkhedBKoG/5EYz+6sJoSiN/xzK+fdpWnQZqJ5?= =?us-ascii?Q?WlYbKYWYERu7FAKuNEG7RbAQlEjVGOKO9KKLa4Fa87WuBQYaUivi7uJ8Sz5s?= =?us-ascii?Q?eQHhDemWv8yXEXq890Ee7J+BCdrzoeXCTk4CNKBKBP/Hw0bChPhvQlzfl98R?= =?us-ascii?Q?4sOkL6MPkXNUOZ4ueXKFC0Wf93jWMCJoBbYJAIQbzA0yopOeVwSLNH1iTajk?= =?us-ascii?Q?hft6XNYywNMgtM5nJ8uaZiG9YZVqWsZ0f2WA4igQLt1zVLfXGW+0MS571h7w?= =?us-ascii?Q?x5MESKiyafVZPy/SYCi7IbTVZWMnqmTqNv898nab7bMcKlqmu+t4NV20Hc5Y?= =?us-ascii?Q?A/8ezo2ALF7PUQeM+hCfrvMZjuiIK6Ti8ifU6wT6lx3hNEqhdPQKWw/B/UOP?= =?us-ascii?Q?ODJqbcbiw2OFRWfpa90YWti0jbTCRvw/ark/h3pXLGalurFQg2cZ31r6Ke1y?= =?us-ascii?Q?GwNRgDbzB9+07ZoStgQ2H9p7S/4hiN6eVZnwrBUJlXbn1FvUi9mGMA2T3anp?= =?us-ascii?Q?EwrJNUQcWO4nEKjlRjCeFteqj0Rkog2Cd0hu9ttZ3F+PJ537BS1t8BPyXgUZ?= =?us-ascii?Q?skAXTX52JjsJMWWYIGXS8kw7LFfuOMwoa665zgkCpdsy0pN2TTCarhNl46Iq?= =?us-ascii?Q?YUKX8U8LZXuBvesE8eAjkagdAauF6mGaYR3a9DbJNMFUFEGhJ1hc6ajmfXtE?= =?us-ascii?Q?kTfr0dkbkYzpcV8UErOaNyj0pQSZ9W5AZKIhMdyWTGlYhRDMXs9iy0DUHleW?= =?us-ascii?Q?vw=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11ef1fc1-f347-4df5-b834-08da64ed1755 X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 16:31:09.0679 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: c0z8s0l4TlA/uIxrjCT8d5ODYSpbXmr0XleCqPE6em8srBOu9bqjHzKYh4D9AmmGId0tEPTE2wqmz3/ctSXA5aE6vGVyAHl3+2xGI36x7XY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 From: Andrei Cherechesu Hello, This the v3 version for the patches which have not yet been commited. Changes in v3: - Dropped the [PATCH v2 1/4] from the previous series since it's already been commited - For PATCH 1/3: No changes - For PATCH 2/3: Dropped the "-a" parameter and instead sourced the name of the extra commands file from the ImageBuilder config file, from the APPEND_EXTRA_CMDS variable. Also described it in README.md. - For PATCH 3/3: Fixed commit message that still mentioned the "-s" parameter, which was dropped in v2. Andrei Cherechesu (3): uboot-script-gen: Dynamically compute addr and size when loading binaries uboot-script-gen: Enable appending extra commands to boot script uboot-script-gen: Enable not adding boot command to script README.md | 10 ++- scripts/uboot-script-gen | 159 +++++++++++++++++++++++++++++++++------ 2 files changed, 145 insertions(+), 24 deletions(-) -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366875.597809 (Exim 4.92) (envelope-from ) id 1oBfGi-0003bW-Ae; Wed, 13 Jul 2022 16:31:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366875.597809; Wed, 13 Jul 2022 16:31:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGi-0003bO-6I; Wed, 13 Jul 2022 16:31:20 +0000 Received: by outflank-mailman (input) for mailman id 366875; Wed, 13 Jul 2022 16:31:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGg-00035D-Iz for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:31:18 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2041.outbound.protection.outlook.com [40.107.104.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 382e66dd-02c9-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 18:31:17 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 16:31:15 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991%6]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 16:31:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 382e66dd-02c9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HR8xtkUATNFYuRzWZKrnDCi8y/1Do2U5afdZaF6ksnyCcc7I0UHUxmmRC7JvpVZ9etHScboqnIRP7i4JJvcHTM3qOsYlHUJ6q8cztR9SsSbIxmudytC1bGsgdSOlucDL0vjQjBnnI+ct6jg+bYSC/EQLlTeIdXF+P8KmAJABouhPuYodbkU9NXuZZkQiOnaKJbdEV02kLLGETSZ566xhuC3JbvFiq04MLrjeXkjwC3FR7D39UTDg3l9Q20LPWHHpXfyl0OaqLSxV5VsOu1SyfiDL0PeHGs4NctErTImPDBbCh061SHbK4zkwVhj2NKeSwuZ8CiQdi3wVPPqaZ1ZwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FmqTgyPFFWr6Cy0aMCwaNL1SgYThtx501TxRMDkfl/c=; b=TRgDIP+2NzxZRMJ3Tu0mcTQiA9GVqPSH88x8BTlKzCM+ZdS2ljP0UM9g9euekpThTLy5DSwjKvvlL/8/5xhzU8WKq6HvtTUXmPHXQmdlGSd5hUjK5v/moCdyuwmtdtXvsevfiSMbr16lyLwitkxa4PDOL9gD1248uH4eseaVznqfM2DX/waWsukOzlneAMEUlydlN1ycN5RrFVYQSkk6WsK8SuGurBqrs9mbDRuDNU3bQBbA/nzAd5J4qEyZ0UCc6/On+LMx2cdkZTrq1d7+o+XDXeIRYbOcsfI33wpzKbk1X5mtJPW2cmymSL5ACB0OC3XMvHGFHol0cxTNTu4BKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FmqTgyPFFWr6Cy0aMCwaNL1SgYThtx501TxRMDkfl/c=; b=Uy0YfAtcMIb45xb6Kf+PJ0ObyB15W/Q9rdAzfj7QkidqCXeRSxDqFY24YwiItNIiCZfmHfhU23jAJHiI8wQFLbnMeWY4W3n+lrkYbZsf274ZEL6MnJLIqt45JYYE3fudR8aWaH4o+nR5lf+OIqcHhbNuvJJS5lGiz0YSFwiZ6z0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: [ImageBuilder][PATCH v3 2/3] uboot-script-gen: Enable appending extra commands to boot script Date: Wed, 13 Jul 2022 19:30:43 +0300 Message-Id: <20220713163044.3541661-3-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR08CA0022.eurprd08.prod.outlook.com (2603:10a6:208:d2::35) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2ee13a77-9f45-432e-eba0-08da64ed1b4a X-MS-TrafficTypeDiagnostic: VI1PR04MB4893:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1U1NCAxm426kbrrJSQm+ZUSU+sb7yeRZ/Y1U4e9TzYf/qYpe/4FGct29qXg4T5/Ells4X/K4Hd/4MeZlvpoiWz3HPEvwD/++e48NiA9KAJ1MnrDZ0DMFaf4qo3TyV7ZhGNuAAp214CsIzhzr8st8udITALDLvlhioqMMmRJfzw3QtfbDtfUenNKjDvK3baIDJw7MaJOwTGK4yKeqFNnDqjPsK3MLG5Dx6deU4ouC9EF8SSEEMBz46jriniZR1ZU2DnNAo39hN4RJEzsd6Gq7qEnFh+SQsMrekVz5236iqCEpZRrppUI2q7IrLTclMotvGxboTMeqNP35nIiIH5cyL6LdS+T1yBuLRGBgf0C//U+WtgMSy7pDoaH98Pk83K4XnQ8P1m0gaBQ70O8CbmUTk2PTWeCVOiAf/oxSLrP+NGtgiX6o1eI2y5CC2TrHpwD5DQZuNka98gqpQxExMe4944l3mTpAnDrzJQHuYgRBtcdYqHfT5lUtfaBYZE3xzNcaskn2wi2dlXtP3l6cNcMW9fbU78MDGO2l77vf2phrPUOc2kJRi3uzrZxp1P2Ok/99LsPOA+KIc/REq1FCR1YK4m7p3qp73p8HkNHRXbNXCPjSFLgw45sqy6YQ2+MILCT008iN2ZYk29oS62zpyn28KP8i7jjoc91YUGfm2XRBLFOBSw08aXYMK8dCFPIBAOZupXGRSzJHK/R/zLZ2MXmqXiwvoAmvembrihCdLu874PymoxD8UFcrjmjK/YVw1fgHmbVO3g37Thz31RwOGIw5NNPSL2652zWv6MN9d1i83fm0yP4M8IafQnBuHe0AVH1YABgfDbyHprASGGdUJk2SFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(86362001)(38350700002)(38100700002)(8936002)(5660300002)(478600001)(6486002)(6666004)(41300700001)(6916009)(6506007)(316002)(52116002)(4326008)(66476007)(66556008)(8676002)(66946007)(186003)(6512007)(2906002)(2616005)(1076003)(26005)(139555002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?2dJVpksJKh6Ah6mquzNtwx9fNdnTBLO0eIEi7huZ0oiiGh0U9T0AVmPEW9xL?= =?us-ascii?Q?APf7jfEjrf5luxfXtlEsoBT51LPGDz/8IVWTt9oA1uJcr4B/ECjRioWesE3W?= =?us-ascii?Q?nZa4F1q7Imjrb1jk6W175oSKaRbacLxqpTCErgpZyME7mjNMXWVl9WPM3S64?= =?us-ascii?Q?xT5ZBjbZKLYOlVVz/HHw/zMvgp9bt2ty2huGmiEQLDqrZeAqsHV/j0RT1LJY?= =?us-ascii?Q?ZUBK8Co6YkcDJZCdbV3dpKD8TpMUahXCGhOavVvFESDG5CcR+byOs15ovYHm?= =?us-ascii?Q?kEPWFU/xfwfaxzbRB14QxfLqdo+NKG++CYg+yPf5y67bQ1tRJ9D6Yt9U4xUJ?= =?us-ascii?Q?xeON3XmgWxqUHLJdB6mAZqaukFtqD09x5F5VK08I8VP/+197bLPk2igZgPiL?= =?us-ascii?Q?5MKg6iNflOvbSujkk0x9FVPGRfEZ4H7uegcR1YPGbDtSIGHG5RhusNX7LZ+i?= =?us-ascii?Q?ZpUisyCva4M9zS0UoNgACWWQsIubCw1vwKseqIgNCOmMie3Khn15KdWrQ1t3?= =?us-ascii?Q?0JnnEs+2e90LkJm/LaI+bV5KOFBtLFg6T8KzNoxCvzh+JjRW0KX+q6faodJX?= =?us-ascii?Q?od5TBEQAGpOC4NP60MYIeRmqTWDSOmB8olSymstjXZiZ9YmU7Apfks2Da8Rr?= =?us-ascii?Q?iu3ziP2Im57239IhKMPp/zFwpjkv5FpVxyriLTw56zYZatE0t0YYN0/ILqou?= =?us-ascii?Q?5ebockCSO3IaRGofhl5npQ0b7XKkjB5CoizBmIdWwdZN6u6THqN0tmUwvblG?= =?us-ascii?Q?U5aOooumNI5whYcIn7aDtrf+v/l/TWpHP31ZP1Ld8hlZV43XX2cEaXt85Om7?= =?us-ascii?Q?INyTNv4q51T/sVjL36zH9QNFr7cQkD2vtSkl3xaZv0Rk5iTnzceCYAXHYC4F?= =?us-ascii?Q?MsBWDuXxHKqBE0QmQZdw0NSirK4dF7IXxafLcUeJKlrGe2fvvYuCYL7EDUBM?= =?us-ascii?Q?MmNmDdNzdjMI/CIxww7rscnhzAxvwkcW3gb1aj4RWG2tFuLyrI5g9d26R1QU?= =?us-ascii?Q?QBn4pIz27vjKRhf6bQ0zi8k6tqf6lgczWYGy0lO53BHQmwk32L7k6pSJOV0Z?= =?us-ascii?Q?daViSTIbFssEPkIVTKVqTNKfK0Sp6TcLECM8loJDDOUK1eKO0VpoETLoIqyT?= =?us-ascii?Q?NdBFUa47JcMQRBEmUCVjnT5r3ihJ0veSK12mm30f7xwnhgXIed3x6azpBj72?= =?us-ascii?Q?viXT7AUIf5+dyp8juUYb+D8b28APHH/0vBMztnIWMuDdFq2yv0XsFyZPDfdh?= =?us-ascii?Q?D8a6ahNS7PTftkRZ1JANj9gSoQVNZ7jSFbIAD7Va3/luCNzG+zqZy8CVSOhK?= =?us-ascii?Q?V0nO/BvhmJDwEylJlhnXNMEqmSdXJBxyhn8Xx5IsnliRbyG+yM6NbS184Ihi?= =?us-ascii?Q?wVzqF60kRrKJ87YF2mexS5e2+aiS93pj7PTC0HGxOufEORYaBucnZ3wMy86n?= =?us-ascii?Q?XdnL/op5d2ocAXHSti7m05ajGvsz5gxHsgOwD0JDUSM/VMmQgJ+gzLxYC457?= =?us-ascii?Q?7VYRkLsyk1+bUP153oP1kwXOc5feEgqeKU17luJ6BPasp1oF/a7qkh/7HoHY?= =?us-ascii?Q?ewO1nBXCqTLdZSapLiB7w+otxLEiRvIM2yuxnCrasBc/tojiL/LhKnW56oc0?= =?us-ascii?Q?5Q=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ee13a77-9f45-432e-eba0-08da64ed1b4a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 16:31:15.6142 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9g312/3O5qxeaMK1nJ90tWipBRIQs+2SoIKYIFc4VB+XNpgOJfLnnRSCN/5R5aCcOgybJkV0ElolyD32SE9wXrPu34H3+4y2ukLPjP13FKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 From: Andrei Cherechesu Added the parsing for APPEND_EXTRA_CMDS variable, which enables the user to specify the path to a text file that contains, on each line, u-boot commands that will be added to the generated script as "fixups", before the boot command. The file specified by the APPEND_EXTRA_CMDS variable parameter will be copied as-is in the generated script. Signed-off-by: Andrei Cherechesu --- README.md | 5 +++++ scripts/uboot-script-gen | 11 +++++++++++ 2 files changed, 16 insertions(+) diff --git a/README.md b/README.md index cb15ca5..3566a6d 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,7 @@ BOOT_AUX_FILE[1]="uboot.cfg" UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr" +APPEND_EXTRA_CMDS="extra.txt" FDTEDIT="imagebuilder.dtb" FIT="boot.fit" FIT_ENC_KEY_DIR="dir/key" @@ -197,6 +198,10 @@ Where: as you can pass -o FILENAME to uboot-script-gen as a command line parameter +- APPEND_EXTRA_CMDS: is optional and specifies the path to a text file + containing extra u-boot commands to be added to the boot script before + the boot command. Useful for running custom fixup commands. + - FDTEDIT is an optional and is off by default. Specifies the output modified dtb, used for reference and fdt_std. diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index f8d2fb0..f72551a 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -416,6 +416,10 @@ function check_file_type() elif [ "$type" = "Device Tree Blob" ] then type="Device Tree Blob\|data" + + elif [ "$type" = "text" ] + then + type="ASCII text" fi file -L $filename | grep "$type" &> /dev/null @@ -1238,6 +1242,13 @@ device_tree_editing $device_tree_addr # disable device tree reloation echo "setenv fdt_high 0xffffffffffffffff" >> $UBOOT_SOURCE +# append extra u-boot commands (fixups) to script before boot command +if test "$APPEND_EXTRA_CMDS" +then + check_file_type "$APPEND_EXTRA_CMDS" "text" + cat $APPEND_EXTRA_CMDS >> $UBOOT_SOURCE +fi + if test "$dynamic_loading_opt" then echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:31:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:31:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366876.597821 (Exim 4.92) (envelope-from ) id 1oBfGj-0003te-QI; Wed, 13 Jul 2022 16:31:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366876.597821; Wed, 13 Jul 2022 16:31:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGj-0003tR-N7; Wed, 13 Jul 2022 16:31:21 +0000 Received: by outflank-mailman (input) for mailman id 366876; Wed, 13 Jul 2022 16:31:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfGh-00035D-WD for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:31:20 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2068.outbound.protection.outlook.com [40.107.104.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 390a49aa-02c9-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 18:31:19 +0200 (CEST) Received: from VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) by VI1PR04MB4893.eurprd04.prod.outlook.com (2603:10a6:803:5c::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Wed, 13 Jul 2022 16:31:17 +0000 Received: from VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991]) by VI1PR04MB5056.eurprd04.prod.outlook.com ([fe80::c2a:42b9:f908:e991%6]) with mapi id 15.20.5417.026; Wed, 13 Jul 2022 16:31:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 390a49aa-02c9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DAjRY1aKk49WIgUCzjN5b31/IZaXOTKvzbgaAXnXoBkC/IqTbCcvjubhofKh0YdmRMljEA0ZPvvO+fPum++5Gt43ajl9Xe99eiPk+XRSPpEzqZMIlHRZkB92ecHsldMviPf30FpFk+TS8Pdmvleu4ARcjvguvf6Jg1M6w2EuG1hWH/TxdoXs67PQtX2ECnbHsGOUcEFru/KthMuIPFJhocxutIa2V+AHi2KISwtRH7j6pmWQ4Bj5k62IJXxIbv9XL/mZRjfX/H2Pe5oLo994LKdNEsa0RnOQWAK1O7wfxXZHQYW9QA/2h6CkMWlDct5Zd0lZCjpq1Fw8M7Amyb2jTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uwKeDBebJwjIYx1Qo5KRUn+UFPyCgLpm22C/91nkWr4=; b=e9cYdKKXgnwoIR3Av1erPKvEdGXSkshryzcHBcfYeegALLH9btawuMkk0wbYIXEmtLzN7mwDIQYYaHGOsgMrHvHm6/WyvM6cq75imrCb1H3ZEQWlSA8VPE8wIjpub+mBwH5Sbg41fWEKR8D4jt38N/o5Q+NXqrAmMe6Q/zOw9OrgF0nDVmwy0x1O3z8KVEf+M1TYnGqPHvnT3lEGD5TufEIzYkigUx4euRw0WpCloKN3arkkzJFJBtOggGgK4b+AWJVWaOWPrl29zIFSAlYry51ibPWrFQoF5DE3zUszt1L3YUgYL480T05k2wFFJRe14e4dD8SDIbvAuxKGTWrAag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uwKeDBebJwjIYx1Qo5KRUn+UFPyCgLpm22C/91nkWr4=; b=XcMemcdtYKM6RIOzQefMhfarzQGBCgh3BTBFj1OenFQj6PLZZbW+8O+4HPidUjpKJMnFvhDttOCwqY6pZYPtKHbEjkRnRAbaXuNP7oKkUw1b8NHJ4g8VGg1ni8U76u0z6EClLqigOk8G6AP9DwHGsCM2c0Y0wwMeKciUvEYVUWw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; From: "Andrei Cherechesu (OSS)" To: xen-devel@lists.xenproject.org Cc: viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: [ImageBuilder][PATCH v3 3/3] uboot-script-gen: Enable not adding boot command to script Date: Wed, 13 Jul 2022 19:30:44 +0300 Message-Id: <20220713163044.3541661-4-andrei.cherechesu@oss.nxp.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: AM0PR08CA0022.eurprd08.prod.outlook.com (2603:10a6:208:d2::35) To VI1PR04MB5056.eurprd04.prod.outlook.com (2603:10a6:803:5a::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38a5bd6a-79c7-4edc-b45b-08da64ed1c3b X-MS-TrafficTypeDiagnostic: VI1PR04MB4893:EE_ X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jXvn7kw9b3BAlgk70W448MiIJ1FF35LvFMhX5LMWEp7bEnpJOc5uiwMq5XPeCVyIl+7dcrmFlytKgkRoxElZ8YlJY3m9zj+q1woVyBnczV8HDDWEwCwTHm0HYeiWFFCIlOfsH0zxQ4OzGo5hg3Q0n4drfhDb1yBnCttIDHq3unwtrXnelESyk5YR6RgY+AU8sEnytPNIOUcvHvNsZrPd70bWuMpu16ejVL6ZlK+MaUDsU1CtiDQNMa59xYUhldJ8caRUqa2mtQB19kCO9dQS0wKbIr+uj1HUP0pNgElQiw8m7aCarI2NHToqGGmFwrY1v4wS65nn08Vbc9nWpcWtVoA6S60r8U5zeOoaC4Fq97Fq4gfTOhPJmg6RuH+NX2Mgw6Kd6bEhBBkBnh8wRYkvbdGZbyHU5+0CazU5xGe/P3WrvgZq8jO451M1dXXwH58eTt+y2ggbJzKqcUY64XBWcniMrZtGdJ7EleHeFrrjiJw3aCu8WYtRK8P3kLEJ5aQN4U8GMQwEnRWUGmCYm37BamelQc94L5JUo9dkpAiRO5+sPWhKbaPYBS3M6c8gFNL32HNrYgqhzzhd1HpPoIycbvNq/l1eDFaWfJtNBQwoRkr9gNegg6VV/7C9tgvHdtZpxDw1q97yPBkatjBI9Ao670V06yutYEwPeR3+LiQqd6ZgvWwjDjP70X2hH580ql3pC+94PtaTFNrGuFm+fykQ/NH7DYN16swvlmEYDl32380lVZnuD8v5NcMg7e1z62RBM93unjKeWbu3r3nSlR7qLQkwY+1t4U68cqSDlwv6r6urYGPmQhM+jTQkk5TIGRRH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR04MB5056.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(366004)(346002)(39860400002)(83380400001)(86362001)(38350700002)(38100700002)(8936002)(5660300002)(478600001)(6486002)(6666004)(41300700001)(6916009)(6506007)(316002)(52116002)(4326008)(66476007)(66556008)(8676002)(66946007)(186003)(6512007)(2906002)(2616005)(1076003)(26005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0YmgZcCCpqZiq7pxm2LR7EhPrSHzChZZfuj/Hrsz5gaQJI60RyLa0h4pPuGe?= =?us-ascii?Q?iS8hG3KQ2uY/gPR1vx1yXhnGa9oSBk080jKVGCg35o8/oW7MQGNrqfZiVyPm?= =?us-ascii?Q?Atl5ITez4N2igPFlx24T/ARuwKFTwHpGqAnUp2mA+bELpK229rOTT3Cd8+tP?= =?us-ascii?Q?7JurHNt9CJ9RZBM7Bwe/IHPuiXwCmBhHPzpYXZzviLWldiIBcpcH+Zd4Itnv?= =?us-ascii?Q?l7XK9Xk/fBEvO964UbtbHyIHrCaQjnOVH0URXJ6J+BWOF9biKdJaKxCz8g1f?= =?us-ascii?Q?R60gxeTP/QdZJfpFAHr6g2YDU/v5RNmwjnk/nv2tI8LEUUpcKckyfrfPjofk?= =?us-ascii?Q?BCCcai5ojSXGr7JwJz4U/R5J+SH9rlh5laV2h/gkND8MCXY3UUIrPf4VUnJx?= =?us-ascii?Q?v3ancvV7Sr81K+fcW5zKO5/t1wsyCaFKJTImgKcC/fZhPi8hM/pIFl/zmmYG?= =?us-ascii?Q?Q5GcKmst5Sxcc3TsAoTA2a3JyHTVZ21DlHQIXpDA0vkFohvRoY+ZZFXmIivj?= =?us-ascii?Q?F57FUG35rAo/0G6RK74tdWSun5M20laQQ3bhrXQNJKlJHhxiiJYv3l6tVmp8?= =?us-ascii?Q?LfnUiB6Ykiu+SFcrYtYyfK+b/jqSxEgUoTIWF9h59Sc1QNpLe46G6+PWOPhd?= =?us-ascii?Q?rVFW2AtpEjOJf/R+Mk8gGAee6IjvLaTv94Ryvnan4VK3PAAxSCouKScahGol?= =?us-ascii?Q?rB07PNXMh72RMzYn9mx2pvKu0uADwxFd1J4relI9eZeSI78+0uuG5L4eb7gE?= =?us-ascii?Q?OI/owmhG1Xk5s01EGNQAu7VEr1zXrcLGOuQRrt9NBsbi2S2bpx7+yNjsS7Jy?= =?us-ascii?Q?bCL32g083s1VJJSprsfOkjhQQcetC9TF1OZhEjV77Q4s1nG+LMPQr/8aggh/?= =?us-ascii?Q?K14kTp+OAZHHTDsMGa69D73CZliPKbcVXywm2fkMUQFM4rd8NlE8f8P4TJlR?= =?us-ascii?Q?ON6A9ZyHkyLpJE/gD2MGWjwG+yCLQAZ+s5+LcL58xRn12tg+ZwnrmpRPpD2p?= =?us-ascii?Q?K9ilitoFs7IGuXCXQlSIJ2NS6bKHac5XE6Vl/QUUgMo6NOhEwcqDqY5x/AjG?= =?us-ascii?Q?Rr2mmvEDJl3QG2J5dg2SDqQYpALC57eBRcednL8ubexBHkWPqflaThkoS0iE?= =?us-ascii?Q?pSnZZDtYQK37kDWJwb80CpmdK4bzmFfPSgD88nFhT684QBci7YBijHsaV8VQ?= =?us-ascii?Q?09t7dP3Ic3cG3Cq3H6TWIjRTolwoI3tw8GMUoV2bot+oyrwGJg316Un2+3Ql?= =?us-ascii?Q?h/m3fxtUkkqbY6QCIxk42L9+WleES/6vBqTGFx60W0drcbjElQlnYTDNzbzj?= =?us-ascii?Q?zJY+B4ZadDSuvZ3sBnShynQLaAw1h/ZiL/DkK+GziMrB8yVA3fNdVmpad9La?= =?us-ascii?Q?7vN294dS72h+Wo3Z4eR3TMilRevw2c9h4ss4qt2VeatezzamdCw9LZO1Py3/?= =?us-ascii?Q?coPmvs5LlgzWs+SDJOi1I63pb74WTiq/JMwHrASZTo98W/HeiN+2L4edeG/j?= =?us-ascii?Q?lKade289aoTMrZ50Hub2Mtfml1b27NbZDQhGgv6OaEMurnOUD+svs1JHLEnQ?= =?us-ascii?Q?RBF7uAZAHVqMxW4bFGGBiUFLcgFny29ZO/YG3a6hDIzEC7wERkIqHJo6peQ7?= =?us-ascii?Q?EQ=3D=3D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a5bd6a-79c7-4edc-b45b-08da64ed1c3b X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5056.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 16:31:17.1297 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KuGgE3vq74fc35QzRSq1CGbyOLhwc8k4vQqqEB0KJqmjPFTX1zJaVKDiEgoKyHFkzZQYSgrRJb36nuw/4WpwLbpAmRx37nnVe3F6SY2f5YU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4893 From: Andrei Cherechesu If the "BOOT_CMD" variable is set to "none" inside the config file, the boot command (i.e. "booti") will not by added to the generated script, to allow the user to customize the u-boot env or the device-tree after executing the script commands and before actually booting. Added commands to store the addresses where the Xen image and device-tree file are loaded, in 'host_kernel_addr' and 'host_fdt_addr' variables, if BOOTCMD = "none". The `booti` command can then be executed as part of the 'bootcmd' variable in u-boot, which should contain: 1. fetching the generated u-boot script 2. executing the script 3. running `booti ${host_kernel_addr} - ${host_fdt_addr}` command Signed-off-by: Andrei Cherechesu --- README.md | 5 ++++- scripts/uboot-script-gen | 16 +++++++++++++--- 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 3566a6d..07ad432 100644 --- a/README.md +++ b/README.md @@ -81,7 +81,10 @@ Where: - BOOT_CMD specifies the u-boot command used to boot the binaries. By default, it is 'booti'. The acceptable values are 'booti', 'bootm' - and 'bootefi'. + and 'bootefi' and 'none'. If the value is 'none', the BOOT_CMD is not + added to the boot script, and the addresses for the Xen binary and the + DTB are stored in 'host_kernel_addr' and 'host_fdt_addr' u-boot + env variables respectively, to be used manually when booting. - DEVICE_TREE specifies the DTB file to load. diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index f72551a..6a8a2b8 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -966,7 +966,7 @@ function check_depends() function check_boot_cmd() { - if ! [[ " bootm booti bootefi " =~ " ${BOOT_CMD}" ]] + if ! [[ " bootm booti bootefi none " =~ " ${BOOT_CMD}" ]] then echo "\"BOOT_CMD=$BOOT_CMD\" is not valid" exit 1 @@ -1251,9 +1251,19 @@ fi if test "$dynamic_loading_opt" then - echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE + if [ "$BOOT_CMD" != "none" ] + then + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE + fi else - echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE + if [ "$BOOT_CMD" != "none" ] + then + echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE + else + # skip boot command but store load addresses to be used later + echo "setenv host_kernel_addr $kernel_addr" >> $UBOOT_SOURCE + echo "setenv host_fdt_addr $device_tree_addr" >> $UBOOT_SOURCE + fi fi if test "$FIT" -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:42:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:42:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366902.597831 (Exim 4.92) (envelope-from ) id 1oBfRm-0006Zb-RL; Wed, 13 Jul 2022 16:42:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366902.597831; Wed, 13 Jul 2022 16:42:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfRm-0006ZU-Or; Wed, 13 Jul 2022 16:42:46 +0000 Received: by outflank-mailman (input) for mailman id 366902; Wed, 13 Jul 2022 16:42:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfRk-0006ZO-IE for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:42:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfRj-00088b-VZ; Wed, 13 Jul 2022 16:42:43 +0000 Received: from [54.239.6.184] (helo=[192.168.7.160]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBfRj-0004cN-Mu; Wed, 13 Jul 2022 16:42:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Nty5XLd4yLOqpNqxxl6pTXwkStFUN1nzDl8RDxoB23g=; b=LdLxiVmBKIXM7tCtS2+ApznWxs dKupbcJ1fSImhn+sxk0SPiDtc8w1z8MKAgMZcB7LqdQWfwoZ63X7/mZHm4M92BQzEPjWJrWmnEdLD SktgkjQDKNiH6zd5IBynZqQ6HH0XA1gm82jxccvVigW7gSdKmDFtdGJi1gKp9dCL9P+Y=; Message-ID: Date: Wed, 13 Jul 2022 17:42:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Hyperlaunch Working Group: Status and Next Steps (15JUL22) To: "Daniel P. Smith" , Xen-devel Cc: Bertrand Marquis , Stefano Stabellini , Christopher Clark , Rich Persaud , "Smith, Jackson" , "Brookes, Scott" , "Lei, Jason" , Scott Davis References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 10/07/2022 23:45, Daniel P. Smith wrote: > Greetings All, > > We will be holding a Hyperlaunch Working Group meeting on Friday, July > 15th at 0900PDT/1200EDT/1700GMT. Did you mean 16:00 GMT rather than 17:00 GMT? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:45:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:45:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366916.597875 (Exim 4.92) (envelope-from ) id 1oBfUD-0007Uw-MM; Wed, 13 Jul 2022 16:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366916.597875; Wed, 13 Jul 2022 16:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUD-0007Up-IP; Wed, 13 Jul 2022 16:45:17 +0000 Received: by outflank-mailman (input) for mailman id 366916; Wed, 13 Jul 2022 16:45:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUB-0007UT-Nt for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 16:45:16 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a0917d8-02cb-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 18:45:14 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657730708771749.0087011726923; Wed, 13 Jul 2022 09:45:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a0917d8-02cb-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657730710; cv=none; d=zohomail.com; s=zohoarc; b=n5ToOKuGl62OEFSUf+VMJh0rYq0z80qscpY0a8l5cpR+DQSFeSkpHDPFfjFZWN5ZHdIN9lpKEEsLAcuzyP3VGZFf+kiHPaD045NJZy8rj8siKzE2E0cafW5iJQtQgv8NLby1NG5wGHH0OcfxVADxEkcDqWPVxQVxD+w25jFzak0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657730710; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=GB1FqFfHp7Do6un/kvkk+uc3ZVl2jYxAFcMB8ma8vag=; b=lZd0+PQAWwH7srOqLGsZRflZwOQzHqdv9V8mpD+fh4ZCGC+J8CFhTneFeo1ovtQXrl9NTeexts8OOZvaZUMhM5qWV3RmyAzssK06wDG+nvZDrLs4ZLviIMNfoKwY7UeGcGbNEAe+Gjv7T88d4/Im+56IhSAeniDtS5kTuR2CJx8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657730710; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=GB1FqFfHp7Do6un/kvkk+uc3ZVl2jYxAFcMB8ma8vag=; b=R8VKvvwog4LJwOWsU6JiH3320T0HdERIAi1p4NCeQLNnOFEUre8M86ClhhTbM+LU G4tvf6+zawT8gADsSLwDR348YX+Its7HhTn/IjoSAp7r/IiiRtAqCpHMS55FUML/y2f hOhURcuy7HxclUTXkrAXVYaw/KbSzdeH8Fqvme94= Message-ID: <87a70ec9-e8d5-f30b-8ab8-aea817101cd1@apertussolutions.com> Date: Wed, 13 Jul 2022 12:44:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Hyperlaunch Working Group: Status and Next Steps (15JUL22) Content-Language: en-US To: Julien Grall , Xen-devel Cc: Bertrand Marquis , Stefano Stabellini , Christopher Clark , Rich Persaud , "Smith, Jackson" , "Brookes, Scott" , "Lei, Jason" , Scott Davis References: From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/13/22 12:42, Julien Grall wrote: > Hi, > > On 10/07/2022 23:45, Daniel P. Smith wrote: >> Greetings All, >> >> We will be holding a Hyperlaunch Working Group meeting on Friday, July >> 15th at 0900PDT/1200EDT/1700GMT. > > Did you mean 16:00 GMT rather than 17:00 GMT? Yes, you are correct, I did mean 16:00 GMT. My apologies for that, hopefully it did not cause any confusion. v/r, dps > Cheers, > From xen-devel-bounces@lists.xenproject.org Wed Jul 13 16:45:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 16:45:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366917.597886 (Exim 4.92) (envelope-from ) id 1oBfUN-0007qc-TH; Wed, 13 Jul 2022 16:45:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366917.597886; Wed, 13 Jul 2022 16:45:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUN-0007qV-QH; Wed, 13 Jul 2022 16:45:27 +0000 Received: by outflank-mailman (input) for mailman id 366917; Wed, 13 Jul 2022 16:45:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUM-0007pg-7p; Wed, 13 Jul 2022 16:45:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUM-0008E8-5P; Wed, 13 Jul 2022 16:45:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfUL-0002AH-P4; Wed, 13 Jul 2022 16:45:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBfUL-0005UC-Lx; Wed, 13 Jul 2022 16:45:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8AlAmG4neoDLUeuMQwfwMw/mfaxSjPQn+8ya5yWn8d0=; b=6YMB9gLPgftyGnRk9JlakT8+s4 ntUB/urxz8BmUuhmIQJU6VMmvpi6nfExfIoKDe5H7MSWYrtMMDJgL5gQsE9B2bIgSwxh7Jj4WLd3E kD8FMSdR4kNOl1cgLJJCfbF7LoVwGOzvrJHqTBQIMRKvByMLbfbv7rnk6vyac4RXjGGY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171605: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-freebsd10-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=033ae6f88be198b8f56043f94b7076b79b5e447e X-Osstest-Versions-That: xen=27357c394ba6e1571a89105b840ce1c6f026485c From: osstest service owner Date: Wed, 13 Jul 2022 16:45:25 +0000 flight 171605 xen-unstable real [real] flight 171618 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171605/ http://logs.test-lab.xenproject.org/osstest/logs/171618/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-freebsd10-amd64 19 guest-localmigrate/x10 fail pass in 171618-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 171593 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171593 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171593 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171593 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171593 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171593 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171593 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171593 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171593 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171593 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171593 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171593 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171593 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 033ae6f88be198b8f56043f94b7076b79b5e447e baseline version: xen 27357c394ba6e1571a89105b840ce1c6f026485c Last test of basis 171593 2022-07-12 08:56:27 Z 1 days Testing same since 171605 2022-07-12 17:38:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: "G.R." Anthony PERARD Demi Marie Obenour George Dunlap Jan Beulich Juergen Gross Luca Fancellu Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 fail test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 27357c394b..033ae6f88b 033ae6f88be198b8f56043f94b7076b79b5e447e -> master From xen-devel-bounces@lists.xenproject.org Wed Jul 13 17:02:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 17:02:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366933.597897 (Exim 4.92) (envelope-from ) id 1oBfkQ-0002SN-HO; Wed, 13 Jul 2022 17:02:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366933.597897; Wed, 13 Jul 2022 17:02:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfkQ-0002SG-ER; Wed, 13 Jul 2022 17:02:02 +0000 Received: by outflank-mailman (input) for mailman id 366933; Wed, 13 Jul 2022 17:02:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBfkN-0002SA-VE for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 17:02:00 +0000 Received: from sonic314-19.consmr.mail.gq1.yahoo.com (sonic314-19.consmr.mail.gq1.yahoo.com [98.137.69.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7f8ce6eb-02cd-11ed-bd2d-47488cf2e6aa; Wed, 13 Jul 2022 19:01:56 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 17:01:54 +0000 Received: by hermes--production-bf1-58957fb66f-h8ftj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 70b07e2b31dd12d124cfd72e82275b60; Wed, 13 Jul 2022 17:01:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f8ce6eb-02cd-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657731714; bh=NU1NSviOHW2bermSXqhjQpM9qBZCU0Z3Kd/YzNWxavI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=aEWKX12vXsYr1pymabk9KossSuVjhxAFI1vZXffSGTInXnLxR8pZs3yGj1+UjschIsqBd/GF51LZ0ZM1iz4kfS142zwK0MuIyZNa56TLqT0TyFOi4uTjNxieUXDe5IIMYjuBrq0PNKycLKJSIDL6j6/vLuRPa+g3wqdsErPh+iVScX9L/YS9OYLkp9hEaH1SZvkpGqqgAUYuyfVbtVgULHSXQiBNaBuxzztKR6BaaelRRl2rK5FD9SCy0gL9DZrNG3xTbk3SPQOPkeSSwaKA1PrO4M9L4r33MZgio7OKEWxaGLKoUqd4idgrgVwN7wyz7cNpx2WEJ+dg+tKfaSEfMg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657731714; bh=Bfz87iYQ9oTnfukf9wdP1ZP5eWZeKuJ1N1Ld/zusYU8=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=gBVnCeZHEb1/LdzivKXS43b72lPO5kzqh6IrgCSEx3EFhqqDuztAtX3bPf2iUT+zp230j34gB5NzajWKxNCK/e58g4oT35zMz9iDJHJ1VfQyRcBOkFXOXyXeWGMzlbCrmKsl+kWCDxKWh+Ya0DAbeilkhpZOe5F/16gjAOZy2PCmhekHaSAA1Jrlml7kdRzaS/gvfOuAqQARMhpEr6ZJbsnBgsvA3e7CdMeqLR2ouRZtoysTrLuQpZQ3yvH5DIWAwG15+CEvofH7l9OXhzGuXrfO6Tm8MFtvNseL+0yKx9zXiCgNmFIzhGsmAq4FBnDx+aLyJmEhwmaJEu+RkLbddA== X-YMail-OSG: 5KbDXZsVM1km7N4ZHR1DikLmAmfBvGEpUeMMAWSXDPk1CmOq9kjbqdp0GhMqGDY pdKxijSWq8DOhHpEeikVZy1aXfwu9dt_1E3B8bCPZVq.hoh06gpkyXXoTH0EVK6Kygl.krk.kkwZ XujsjXmjAqQlmlGhBc4ZGyq1M.12VzF.RG6TtMh0fFbSeYb9OHjf7OJ7RFTGM.bNsJ8Fr7AAEj6l tnDcFnAqIXB9HBlrtjsw5BCgpjpP4rlrX3nH.IT1ykoARrDrTKkQAO93Zg.eUhChsFYQedJp2D2K iOUqx8nis_95jcwsw3gkNySy08HuEiFOmZ7ajGNF3bVQMZv2bpE7khe0.PMJQL2jTb84MbCLTDtC kBQmwQ.uGJjlZv.2t6DNxY2Ra4ZYZV0BPM5iwJU438YeNpKHT8GCpPu0OuddRVlo1vdBzENzR60U 9B9kk0f5ECwmAJQAL8imed6Q.O13IkT_aqbCwGrVKTRMoaZsOAtFsAsJMp.6r1gtX1A359vsPLoI 8SahK3hemKzgRwGhh4i6OM5V75m6iS8Doe3xOUg8MRyCIpJU14Jx4sD1r2hHe4u5ax_CP5sxNpAa w_Qehl8yZpZnoDcYle.Ure.Fo_D5C6yA_foR85QLSlXvQhesrhEnIRTVxflatpfCxuaKztWL3ubW h9R_RBsH9Alrlup7pP8Juns17PJ.GZ3XCLPG9jVGticdZyZP77.g48enJ4ZZ4Vfd590jYCoEWMxy TW.T9s0nCLobg1n3XOUQX8hLtBTzZccDYg9LeU1BzZf7jVNCxblM3R8M7DwRLNOQ5W_8Gf9fMVL. 84b8ByZyw_8xeZkCzD6puWDLzfzBFa9nrxDfPIMhNp0fgAY0NHifUjGbPOxXCevLkef7ErRbnoPw jVLwGtc0mzn._FloHmLSK4fxS_iLotxCDQV.XvMeT8NmOKmNKV7s70RwXB27uk5i2O6u_Gq9ekmD pmWKMTn94_AD1BMiEzJGpL72150uieSAlektdaSM_igKPaq7WOdYWJ4pwyCKbX6LOHZxvyviFwbk qVVNgiXGKKqPzqOyoOJuBRhlNcQhNyjTtISpZ7lgEvZYTF3vNbYWL7CkoQcFztXm8HvnDE5.7Wfg 9B6OgVxuWhci0qodjsgV1CXDQN3j1PeU2.jec5vwgHqRHQkVGLcmGQPPArlTr5YqADTFcxCqG2Ma OjvL0s5DWNmH2Oz4Q.tuK9v5cluOepH5cnXTSb39SXuwgeTCgJqI.q8zTdWYlBbcp7NbCW0EUxyt HRUCukJqcFVGUsUJTX16jylCZRCDwlHZ_taJ7OEprAs_IFQNr1pzVYVEiI8Ckp7ZLu1Qt0l.WATG O30D2Ux9wkK1CwIcfGv3HzNXJN0x8qwmcMDLjXJaTcWkLHFPUXyoWvvWapRLaRv8KNG9TGk1xWkc .2XIOg7rKY3HDLk55W8GxnqtXvkeInKI1kisrkHXzcgpExDxK4HKWuoriNAkB3XT.JWY_2GY0e8E ut8P_IpX0i0pdpqhhdmy3KJSWnRra2SodwDXmEad9kp7BDeLA00Q_MjQcPEdMR_2CXGcI0l5JD05 DEZ2iCMoE4Exb9uqXNDRV1Xz2J34Zn08B9n8HegJfFec5ccErfTLjIymGzwEjrKZEb3QZ0_NocLH YB3Y_2I.jgRQzibbYvdWk78q0uZWxwVmxURwjWuZP7X2Juy2P2ZIn7G2F5nUVrDW1eIlTMxs5ns. 8IZbFXn5dCftlRDFHh7PQhv6n_hUzFdhwGvHxE7udQSffyb38MrikufUdNrBCPFy6BWv71d4HUHN 25FYZgktRvIs58v_7Yvuy6zLDG62TV4vvrVt7TWVp41co7Xfxk6r9LKgN0qDChWdTcbmSeufw95d ZrKtWd.haJAaUr61KKhrCxGFk.IjzeL0A6h6hvxvQLoGCoYpU6nyTAb.sgtXHy8kyA1vP373DSJ4 pUOMovc0diGJMLNp7y4cdhuq6pWwWLYdqDDcqVbEWuWTw.kuen2ybh5p21MtLqKx7KxwnhbtQHsn wKnGBlHvm5vHUGaF_FP3L5TD2ArZoHYAtXbOoE3wSBNU9nn5uU4GK1YlfhSn0sWWXs5WeyXgmKk0 sr5LbjZPDgqzwmXTt_1juBevNbBHiG3bmBDq5hOLHwzmtmvZtfdejZrJeSVEsd7Za22848z8W0pS 5bUZnuiYY4cD8kuSi8Ur4EY9NSCoZ_9hS4QyvlLf6lCYIkgfWlY3Eb5MGbTE0rllo8GaqEiJg2Qf v6w-- X-Sonic-MF: Message-ID: <3b903a7b-0405-84d4-5a3a-822e2ef51b2e@netscape.net> Date: Wed, 13 Jul 2022 13:01:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Juergen Gross , Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8926 On 7/13/2022 9:45 AM, Juergen Gross wrote: > On 13.07.22 15:34, Jan Beulich wrote: > > On 13.07.2022 13:10, Chuck Zmudzinski wrote: > >> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > >>> On 7/13/2022 5:09 AM, Jan Beulich wrote: > >>>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: > >>>>> On 7/13/22 2:18 AM, Jan Beulich wrote: > >>>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > >>>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>>>>>> *Add the necessary code to incorporate the "nopat" fix > >>>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>>>>>> *Expand the commit message to include relevant parts of the commit > >>>>>>> message of Jan Beulich's proposed patch for this problem > >>>>>>> *Fix 'else if ... {' placement and indentation > >>>>>>> *Remove indication the backport to stable branches is only back to 5.17.y > >>>>>>> > >>>>>>> I think these changes address all the comments on the original patch > >>>>>>> > >>>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>>>>>> include Jan's idea for fixing "nopat" that was missing from the first > >>>>>>> version of the patch. > >>>>>> > >>>>>> You've sufficiently altered this change to clearly no longer want my > >>>>>> S-o-b; unfortunately in fact I think you broke things: > >>>>> > >>>>> Well, I hope we can come to an agreement so I have > >>>>> your S-o-b. But that would probably require me to remove > >>>>> Juergen's R-b. > >>>>> > >>>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>>>>>> } > >>>>>>> > >>>>>>> - if (!pat) { > >>>>>>> + if (!pat || pat_force_disabled) { > >>>>>> > >>>>>> By checking the new variable here ... > >>>>>> > >>>>>>> /* > >>>>>>> * No PAT. Emulate the PAT table that corresponds to the two > >>>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>>>>>> */ > >>>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>>>> > >>>>>> ... you put in place a software view which doesn't match hardware. I > >>>>>> continue to think that ... > >>>>>> > >>>>>>> + } else if (!pat_bp_enabled) { > >>>>>> > >>>>>> ... the variable wants checking here instead (at which point, yes, > >>>>>> this comes quite close to simply being a v2 of my original patch). > >>>>>> > >>>>>> By using !pat_bp_enabled here you actually broaden where the change > >>>>>> would take effect. Iirc Boris had asked to narrow things (besides > >>>>>> voicing opposition to this approach altogether). Even without that > >>>>>> request I wonder whether you aren't going to far with this. > >>>>>> > >>>>>> Jan > >>>>> > >>>>> I thought about checking for the administrator's "nopat" > >>>>> setting where you suggest which would limit the effect > >>>>> of "nopat" to not reporting PAT as enabled to device > >>>>> drivers who query for PAT availability using pat_enabled(). > >>>>> The main reason I did not do that is that due to the fact > >>>>> that we cannot write to the PAT MSR, we cannot really > >>>>> disable PAT. But we come closer to respecting the wishes > >>>>> of the administrator by configuring the caching modes as > >>>>> if PAT is actually disabled by the hardware or firmware > >>>>> when in fact it is not. > >>>>> > >>>>> What would you propose logging as a message when > >>>>> we report PAT as disabled via pat_enabled()? The main > >>>>> reason I did not choose to check the new variable in the > >>>>> new 'else if' block is that I could not figure out what to > >>>>> tell the administrator in that case. I think we would have > >>>>> to log something like, "nopat is set, but we cannot disable > >>>>> PAT, doing our best to disable PAT by not reporting PAT > >>>>> as enabled via pat_enabled(), but that does not guarantee > >>>>> that kernel drivers and components cannot use PAT if they > >>>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > >>>>> instead of pat_enabled()." However, I acknowledge WC mappings > >>>>> would still be disabled because arch_can_pci_mmap_wc() will > >>>>> be false if pat_enabled() is false. > >>>>> > >>>>> Perhaps we also need to log something if we keep the > >>>>> check for "nopat" where I placed it. We could say something > >>>>> like: "nopat is set, but we cannot disable hardware/firmware > >>>>> PAT support, so we are emulating as if there is no PAT support > >>>>> which puts in place a software view that does not match > >>>>> hardware." > >>>>> > >>>>> No matter what, because we cannot write to PAT MSR in > >>>>> the Xen PV case, we probably need to log something to > >>>>> explain the problems associated with trying to honor the > >>>>> administrator's request. Also, what log level should it be. > >>>>> Should it be a pr_warn instead of a pr_info? > >>>> > >>>> I'm afraid I'm the wrong one to answer logging questions. As you > >>>> can see from my original patch, I didn't add any new logging (and > >>>> no addition was requested in the comments that I have got). I also > >>>> don't think "nopat" has ever meant "disable PAT", as the feature > >>>> is either there or not. Instead I think it was always seen as > >>>> "disable fiddling with PAT", which by implication means using > >>>> whatever is there (if the feature / MSR itself is available). > >>> > >>> IIRC, I do think I mentioned in the comments on your patch that > >>> it would be preferable to mention in the commit message that > >>> your patch would change the current behavior of "nopat" on > >>> Xen. The question is, how much do we want to change the > >>> current behavior of "nopat" on Xen. I think if we have to change > >>> the current behavior of "nopat" on Xen and if we are going > >>> to propagate that change to all current stable branches all > >>> the way back to 4.9.y,, we better make a lot of noise about > >>> what we are doing here. > >>> > >>> Chuck > >> > >> And in addition, if we are going to backport this patch to > >> all current stable branches, we better have a really, really, > >> good reason for changing the behavior of "nopat" on Xen. > >> > >> Does such a reason exist? > > > > Well, the simple reason is: It doesn't work the same way under Xen > > and non-Xen (in turn because, before my patch or whatever equivalent > > work, things don't work properly anyway, PAT-wise). Yet it definitely > > ought to behave the same everywhere, imo. > > There is Documentation/x86/pat.rst which rather clearly states, how > "nopat" is meant to work. It should not change the contents of the > PAT MSR and keep it just as it was set at boot time (the doc talks > about the "BIOS" setting of the MSR, and I guess in the Xen case > the hypervisor is kind of acting as the BIOS). > > The question is, whether "nopat" needs to be translated to > pat_enabled() returning "false". I've found exactly one case where > "nopat" seems to be required for a driver to work correctly, but > this driver (drivers/media/pci/ivtv/ivtvfb.c) seems to rely on > MTRR availability, which isn't supported in Xen PV guests. > > Other than that the "nopat" option seems to be a chicken bit from > the early days of PAT usage, which probably isn't really needed any > more. So I wouldn't be worried to drop "nopat" having any effect > on the system in Xen PV guests. > > On bare metal it should still work, of course, if only for said > driver. > > >> Or perhaps, Juergen, could you > >> accept a v3 of my patch that does not need to decide > >> how to backport the change to "nopat" to the stable branches > >> that are affected by the current behavior of "nopat" on Xen? > > Note that it is not me to accept such a patch, this would be one > of the x86 maintainers (e.g. Boris). > > > Juergen Thanks, I think you have given me enough information to try a v3 without a fix for "nopat" that you might be willing to give your Reviewed-by to. Unfortunately, I am not optimistic about coming to an agreement with Jan. I do not want to sign-off on a patch that makes the kind of changes to how "nopat" behaves with the attitude, "I'm not the one to ask about logging." We have to give the administrator accurate information about what we are doing with useful logs, and I cannot sign-off on Jan's approach without giving the administrator a sensible and honest message about what effects, or lack of effects, the "nopat" option will have with his approach. Perhaps Jan will change his mind and sign-off with me on a v3 that will explain with a log message the limitations of the "nopat" option using his approach. I am just against not being open about any issues that are present in what we always call "open source software." Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 17:53:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 17:53:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366940.597908 (Exim 4.92) (envelope-from ) id 1oBgYX-0008Ie-DD; Wed, 13 Jul 2022 17:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366940.597908; Wed, 13 Jul 2022 17:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBgYX-0008IX-8u; Wed, 13 Jul 2022 17:53:49 +0000 Received: by outflank-mailman (input) for mailman id 366940; Wed, 13 Jul 2022 17:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBgYW-0008IN-C6; Wed, 13 Jul 2022 17:53:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBgYW-0000we-5p; Wed, 13 Jul 2022 17:53:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBgYV-0007Kk-II; Wed, 13 Jul 2022 17:53:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBgYV-0002Ua-HZ; Wed, 13 Jul 2022 17:53:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FQAaEpurcYq5jZCbkDAHTAST7N13V0n+5TuHhmcgXwY=; b=ndF0D3QtSe4Do7dlp180NXC8gc f1b/DZhC01xbAb6c/6nuzNpmnSFgOAWDHosE606bP1ZSepxEkEIZiTPh698D4laVqVef3qQ+aAJCQ dc0Ur8rpdZeL2obO4yhboUQUzJd2DIRyIq5fbvHuZBK1+36Xau1HUjUFME/72+zJ9upM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171608: regressions - FAIL X-Osstest-Failures: xen-4.16-testing:build-arm64:xen-build:fail:regression xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-4.16-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 X-Osstest-Versions-That: xen=744accad1b73223b3261e3e678e16e030d83b179 From: osstest service owner Date: Wed, 13 Jul 2022 17:53:47 +0000 flight 171608 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171608/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail REGR. vs. 171595 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171595 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: xen 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 baseline version: xen 744accad1b73223b3261e3e678e16e030d83b179 Last test of basis 171595 2022-07-12 09:37:57 Z 1 days Testing same since 171608 2022-07-12 23:09:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 Author: Andrew Cooper Date: Mon Jun 27 19:29:40 2022 +0100 x86/spec-ctrl: Mitigate Branch Type Confusion when possible Branch Type Confusion affects AMD/Hygon CPUs on Zen2 and earlier. To mitigate, we require SMT safety (STIBP on Zen2, no-SMT on Zen1), and to issue an IBPB on each entry to Xen, to flush the BTB. Due to performance concerns, dom0 (which is trusted in most configurations) is excluded from protections by default. Therefore: * Use STIBP by default on Zen2 too, which now means we want it on by default on all hardware supporting STIBP. * Break the current IBPB logic out into a new function, extending it with IBPB-at-entry logic. * Change the existing IBPB-at-ctxt-switch boolean to be tristate, and disable it by default when IBPB-at-entry is providing sufficient safety. If all PV guests on the system are trusted, then it is recommended to boot with `spec-ctrl=ibpb-entry=no-pv`, as this will provide an additional marginal perf improvement. This is part of XSA-407 / CVE-2022-23825. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit d8cb7e0f069e0f106d24941355b59b45a731eabe) commit 5457a6870eb1369b868f7b8e833966ed43a773ad Author: Andrew Cooper Date: Tue Mar 15 18:30:25 2022 +0000 x86/spec-ctrl: Enable Zen2 chickenbit ... as instructed in the Branch Type Confusion whitepaper. This is part of XSA-407. Signed-off-by: Andrew Cooper (cherry picked from commit 9deaf2d932f08c16c6b96a1c426e4b1142c0cdbe) commit 0826c7596d35c887b3b7858137c7ac374d9ef17a Author: Andrew Cooper Date: Mon May 16 15:48:24 2022 +0100 x86/cpuid: Enumeration for BTC_NO BTC_NO indicates that hardware is not succeptable to Branch Type Confusion. Zen3 CPUs don't suffer BTC. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76cb04ad64f3ab9ae785988c40655a71dde9c319) commit 76c5fcee9027fb8823dd501086f0ff3ee3c4231c Author: Andrew Cooper Date: Thu Feb 24 13:44:33 2022 +0000 x86/spec-ctrl: Support IBPB-on-entry We are going to need this to mitigate Branch Type Confusion on AMD/Hygon CPUs, but as we've talked about using it in other cases too, arrange to support it generally. However, this is also very expensive in some cases, so we're going to want per-domain controls. Introduce SCF_ist_ibpb and SCF_entry_ibpb controls, adding them to the IST and DOM masks as appropriate. Also introduce X86_FEATURE_IBPB_ENTRY_{PV,HVM} to to patch the code blocks. For SVM, the STGI is serialising enough to protect against Spectre-v1 attacks, so no "else lfence" is necessary. VT-x will use use the MSR host load list, so doesn't need any code in the VMExit path. For the IST path, we can't safely check CPL==0 to skip a flush, as we might have hit an entry path before it's IBPB. As IST hitting Xen is rare, flush irrespective of CPL. A later path, SCF_ist_sc_msr, provides Spectre-v1 safety. For the PV paths, we know we're interrupting CPL>0, while for the INTR paths, we can safely check CPL==0. Only flush when interrupting guest context. An "else lfence" is needed for safety, but we want to be able to skip it on unaffected CPUs, so the block wants to be an alternative, which means the lfence has to be inline rather than UNLIKELY() (the replacement block doesn't have displacements fixed up for anything other than the first instruction). As with SPEC_CTRL_ENTRY_FROM_INTR_IST, %rdx is 0 on entry so rely on this to shrink the logic marginally. Update the comments to specify this new dependency. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 53a570b285694947776d5190f591a0d5b9b18de7) commit 2a9e690a0ad5d54dca4166e089089a07bbe7fc85 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework SPEC_CTRL_ENTRY_FROM_INTR_IST We are shortly going to add a conditional IBPB in this path. Therefore, we cannot hold spec_ctrl_flags in %eax, and rely on only clobbering it after we're done with its contents. %rbx is available for use, and the more normal register to hold preserved information in. With %rax freed up, use it instead of %rdx for the RSB tmp register, and for the adjustment to spec_ctrl_flags. This leaves no use of %rdx, except as 0 for the upper half of WRMSR. In practice, %rdx is 0 from SAVE_ALL on all paths and isn't likely to change in the foreseeable future, so update the macro entry requirements to state this dependency. This marginal optimisation can be revisited if circumstances change. No practical change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit e9b8d31981f184c6539f91ec54bd9cae29cdae36) commit e7671561c84322860875745e57b228a7a310f2bf Author: Andrew Cooper Date: Mon Jul 4 21:32:17 2022 +0100 x86/spec-ctrl: Rename opt_ibpb to opt_ibpb_ctxt_switch We are about to introduce the use of IBPB at different points in Xen, making opt_ibpb ambiguous. Rename it to opt_ibpb_ctxt_switch. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit a8e5ef079d6f5c88c472e3e620db5a8d1402a50d) commit 31aa2a20bfefc3a8a200da54a56471bf99f9630e Author: Andrew Cooper Date: Tue Jun 28 14:36:56 2022 +0100 x86/spec-ctrl: Rename SCF_ist_wrmsr to SCF_ist_sc_msr We are about to introduce SCF_ist_ibpb, at which point SCF_ist_wrmsr becomes ambiguous. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76d6a36f645dfdbad8830559d4d52caf36efc75e) commit 3a280cbae7022b83af91c27a8e2211ba3b1234f5 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework spec_ctrl_flags context switching We are shortly going to need to context switch new bits in both the vcpu and S3 paths. Introduce SCF_IST_MASK and SCF_DOM_MASK, and rework d->arch.verw into d->arch.spec_ctrl_flags to accommodate. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 5796912f7279d9348a3166655588d30eae9f72cc) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Jul 13 19:08:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 19:08:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366951.597922 (Exim 4.92) (envelope-from ) id 1oBhiJ-0008Br-1u; Wed, 13 Jul 2022 19:07:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366951.597922; Wed, 13 Jul 2022 19:07:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBhiI-0008Bn-UH; Wed, 13 Jul 2022 19:07:58 +0000 Received: by outflank-mailman (input) for mailman id 366951; Wed, 13 Jul 2022 19:07:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBhiH-0008Bd-Ie for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 19:07:57 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17f7172b-02df-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 21:07:54 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 19:07:51 +0000 Received: by hermes--production-bf1-58957fb66f-h8ftj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 65a156af75367857ded6d2cf2b081491; Wed, 13 Jul 2022 19:07:48 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17f7172b-02df-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657739271; bh=lrtn2id1/w6rDvkb7r86M1MSgYYCSarhdbpXFUxCFVo=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=B84svUECHrKyJj/S/IA0R8B6lzJRrmGR6EjjpwPre6q4FnLUCuFWxAtYl0QfyVHyIuxkXCqQOyFh6hsXj72Wk8JBJk3m2RTXCJElviQNFA3ulDFaBWg7Ao7PGijwTpRfKtWyHj0HT/FPOq7FG4bZRIzn6uGWpOG78VEr6iIUJP6nd8vslvQINGoin87C5RKWpEdOCYPbkdeOLX2Xm9/oKdguMR3gohWdVcDQ/kshLij0URNJEZQ72feeP2efpGeDcIUFj+ZlpjnOVxYOj+sOTOFrvNq1kfkjDKjliTl6YlGnnKILFOmoTqnzMxbIddJAJO8032CJs7C6YmurCvJvSg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657739271; bh=gginz7UTVTgsk/g8Xk92Vk/h7wc2Tv65ymmhLjLTC1X=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=SG+GnJHKUuULT/10FXE8IbELqySkPBhK8iFZ3W73AbOJo+iITG6ge9uydl6ZejYBJm5INzzhh1nnkoAdNwKZiFtCc9GPU3a5WuMlCURYMMjBncMP/2aivjIqAbVvGI0PclkKRSvFIRsDvLGyq6ctVG8tbCviLZgMBIlQf7lpyP2B5uUGkno+GBrFgWgwvwJYPqfVjWhlkJvahJTeI2/uW/cie4pSWpzKHm/eFUo8j2nx7QET2lvcRdD37sgwPesL/CF+5bpctMwWCIy5iDkNypJ/Cpe2u7v0dRDqL0nXTruwlBwJKY+i4KZcNbRNfGPX3DiKO1KyEFY8IjHjmwUv0A== X-YMail-OSG: qTQWnokVM1lfWDhV4gNNqh7DX7aoOaA1up.GlrFFYo.ojAmpcQqaUbXwWXAPITa jNtkZMD.YGcpXxR32NhmVokKMcZFO4ZPbxASOKqpHO4dVXiO4uDYG3lP__.X.SfNsuHfoQONvY9r 4Flln156vhTaQP5jewRxpn3MC0Ivcx6VIn6nxB3kQuQvEUcZfWyzMNXbtnl35xTJKnXvGB_TW6cV Kj9lk_Rhpi8qsb_TzzKG0ZSfU0OemAuCEMILPkOGcdkmRCHVTZ.nBLNVpl8hIHqwE4uF2Q4Fgi7G dSzhvrgEuJPBPHFJeVQ7UnAO4qkRN.rPkuW1hnrRWrcvw8329G_8jV1wWNTHd5S44JrBEOED7Fxe sysf_gbsRcD.aSxbVO.EkXBNGTxoYopcr0VvOpWzZf2mI4OB_FbjtL7.TChw_mOPnN8e8wTv5bo0 IIS7rvgNW2HEzEFq0l3F2hVm5Y4fvpzJ7Utpj7vckmmjRnUY0ArUtF3KYXvAEQQXPEbdMcgknCLh HJExWR1K9oxohb1xQ2yGWomIbn_vGav6tE27non3SPQDYFWs2wqPiETxdGvjmvy5vfpf1RjVxjFX 2W64SP10lFQXbPSbFppMLqFvS19RBlfP0Gdix7NvYMx686gBD3G1gfoBn3x32zSbfdesQSGP74PJ aSwfH_WzE65DvkfJq8wiy4EAIgF7QI7NDWq0CWLxQRAlgqk21eiOG6_33cgDpnRIC8v9gcOooKbH x0GMQaPyWtflSUqnewdH8_p3DQR3oGgW7.gnGfa5QcRYPOljbBWgzwQzHa8xnWOPwMd23c3.Q7w. DlbS.0o1UXu84Cm1xwBL1mHuvmRMi36haFjsn8xRaqACG6kEQsqowAuD5H40_1ayO9ITaZrPKpCn im05CwO_s_sbAl_qx5b0_RRzmqQysTtILJWXHNSY4RJtPRL4eojeE0jEYNU3rxs2AwC63XblRUUY m9RatyGSh1KMx__BVRh4iPWVTINIl6P7YOCRX12dvx8npvP0SVSGnpj7SOwcq4ZZ3DIV3s9zr51_ Gnrv6Er0Sl6kLjel7L38RjaCHbFhnMIjduZBoGY39u_YFXbTwCPTwMAmMd1AUhKrXspWgahDnIAD zyABNCifHavhpX6_XLrTAn4mwTJpHUSn8ou4RzJtQsGn1xjIfO0Jdt8JY_knT3.fV5FE3Frl77kT rLdUf3zIeE_9VFiBhsBY12.GJBeByLvJomYLOv68Jbs0d6BFBkao7t78CP7JKOMXiYyQdnaioL9_ pa8ZQcwKc6JGaJlo1z_OSKZt3PWBIR506nboq_mWxJUONsia50FbfBZb8AseH8C5lRXtoJKbJ1l8 aDj1FHvEC6RXxX5JkrwatiSrUSiCsffA4Gs7iUzDGVEp0B2eb73SdybjGoIqjYPqp2GsAYH3Kx.S 546lUvL8Q8sp9z_G06ud8CQ9nY2ZZaooV1vur4hfuLNJ05c1e9v9K2TAhADd1PowklBHmur4CGmt 4srjVDIVSzaNUs5aHB4uXsAy1BLNiAmOm2L3Cb5HLFpNU2R.X9a0J8zbghJYLKT67QaKpxrSCLjA BSX_1Zs7KD9t4EIAC2WLwm0X38SOrQ3NXW.ooNoQ8YzkTeU0Jge.nypK7iWesFcFhdjTe.gZNx9K jbUwcZSP7Xenf_nZWXWkAIrrg2O4HKlYqzb0bB4h.F_OvTowEaOYYsSr76Job5sVqTuNAfQuC782 BPWDW1hTQQNIjV0inTGndVGy1jhItiSYTi1I6Pm6dQCsgAOuurs2c9NRL4kwOyG3oivnEUfToCg3 r4aIzVQHXyicSINk4G8w76OLcv2lMFYY7N3iVz4BiEcKV5lzcEK8OiEw9dd5hlYTF8JdrGDkdsdi KEouMePMCQFNTHUT.T0E3lB..9jT.poDvp4xHsBtiXo5i_c1c8MZM_pUJIDIZnlBVRjnK6IW_4Uk FqGl3AJrsGl59fteby2HlD2DFPG7Fv1YfG.7ZVIlV0eq9n3RVXV0EsQHmyNJYrZb9bACyo1IhDMU eVbffhs85QmI.wEB5FI9JAC8QgavPsMZSn0chgX3_mqw_W8RYDpE4J54emEMvPIUZey2f_QY45Mg i8fYcnPZvLkmUxkHlpxwLdRlXUNcx.D7jsKtHwkutbzQFEEg3LOY1An8g1kP1Ynogzv_Gff6R89d 3H2swFs5GqURCMNo.1XFgi1D0CHFgmC9WzJvsSCSh.i34nCEe7fa0QJJRcOcF_ZV0JHS5h6I4qvf TEQ-- X-Sonic-MF: Message-ID: <56a304ad-606f-6d33-bd2b-8c614fcdb666@netscape.net> Date: Wed, 13 Jul 2022 15:07:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR To: Juergen Gross , Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2518 On 7/13/2022 9:45 AM, Juergen Gross wrote: > >> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > >> And in addition, if we are going to backport this patch to > >> all current stable branches, we better have a really, really, > >> good reason for changing the behavior of "nopat" on Xen. > >> > >> Does such a reason exist? > > > > Well, the simple reason is: It doesn't work the same way under Xen > > and non-Xen (in turn because, before my patch or whatever equivalent > > work, things don't work properly anyway, PAT-wise). Yet it definitely > > ought to behave the same everywhere, imo. > > There is Documentation/x86/pat.rst which rather clearly states, how > "nopat" is meant to work. It should not change the contents of the > PAT MSR and keep it just as it was set at boot time (the doc talks > about the "BIOS" setting of the MSR, and I guess in the Xen case > the hypervisor is kind of acting as the BIOS). > > The question is, whether "nopat" needs to be translated to > pat_enabled() returning "false". When I started working on a re-factoring effort of the logic surrounding pat_enabled(), I noticed there are five different reasons in the current code for setting pat_disabled to true, which IMO is what should be a redundant variable that should always be equal !pat_enabled() and !pat_bp_enabled, but that unfortunately is not the case. The five reasons for setting pat_disabled to true are given as message strings: 1. "MTRRs disabled, skipping PAT initialization too." 2. "PAT support disabled because CONFIG_MTRR is disabled in the kernel." 3. "PAT support disabled via boot option." 4. "PAT not supported by the CPU." 5. "PAT support disabled by the firmware." The only effect of setting pat_disabled to true is to inhibit the execution of pat_init(), but it does not inhibit the execution of init_cache_modes(), which is for handling all these cases when pat_init() was skipped. The Xen case is one of those cases, so in the Xen case, pat_disabled will be true yet the only way to fix the current regression and the five-year-old commit is by setting pat_bp_enabled to true so pat_enabled() will return true. So to fix the five-year-old commit, we must have pat_enabled() != pat_disabled Something is wrong with this logic, that is why I wanted to precede my fix with some re-factoring that will change some variable and function names and modify some comments before trying to fix the five-year-old commit, so that we will never have a situation when pat_enabled() != pat_disabled. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 19:23:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 19:23:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366957.597933 (Exim 4.92) (envelope-from ) id 1oBhwz-0002FN-AF; Wed, 13 Jul 2022 19:23:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366957.597933; Wed, 13 Jul 2022 19:23:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBhwz-0002FG-6k; Wed, 13 Jul 2022 19:23:09 +0000 Received: by outflank-mailman (input) for mailman id 366957; Wed, 13 Jul 2022 19:23:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBhwx-0002Er-LU for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 19:23:07 +0000 Received: from sonic313-20.consmr.mail.gq1.yahoo.com (sonic313-20.consmr.mail.gq1.yahoo.com [98.137.65.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36fcfdd7-02e1-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 21:23:05 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic313.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 19:23:02 +0000 Received: by hermes--production-bf1-58957fb66f-c5dsp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID be5fa1fef9434c2588515f43cf87c2ec; Wed, 13 Jul 2022 19:22:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36fcfdd7-02e1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657740182; bh=/pqEtPTwoqlqf1VfNjWI+ICxoox940uBU+wleS/dIQA=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=jOfzgrIZnCGAOPIyNe5JIWs0IE3kzATlnIeOengJsRshFZHKdzoOKXtvRZjg2k9NnJ1Wb+7mhzw0v4BbxCPWA5j2OylngBa8yTJpjeI4X+dXVtbJVf37Eppl+XLV946ub17PuQJbPNEDyNJDx+s6XrWrNgc9TTMNjYIxK0gSO7aIKzLqQ/nl/Rme8gw6IDNZh/ML83/boCnGnehv10j9wjRQ/7TCS0PmqltNSLTSxZ9ec310Min8XajREI+1SN8FnmQbJrkpluiQNcKWn5gb4q08j1zvgXeEPJFoaOYFImtBGBgAucJxirOinPKMVLmNEUpMchHbUS85w0HcpX5c8Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657740182; bh=iDdQzQUxoYiwLEBUT6Opp93BUFmnJiJhA/x+KMtY0pk=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=Tr3kDXM64Qz8a/Nk+fSD4+jPhhx8mSk0WOUnB2addJ+WEF6Br33g5JUnyT88sOVE1nvpAEcfGLsr3IfvQ1QRk1KpAgEOHxw4hmaWyHBWvtPElmJRFK9GSY6y8h14vx2QHTTycWrYK1Hhux498KLODzsO7udPsfYXlbAMr1MhvxHoIfY7OLYaqkTHBgmtKrMAKDwxMgc6RCMjF0YHf73hmlel6zkvrnh0IheGEOSMDucecax4i9cORU47hsPBUJfHYi3Y20QuRQAqfJi6BA6x960DldC8+WD9ACduVKAmd8SAK+eidAZ/Hqiqjih+n9ut05UgsEJhHvbxSjG0pcGLdg== X-YMail-OSG: jVFH_4sVM1nv9uVHcq_abWJ3PwOSDpTt4cR4mfH4t5l46G7PndKKnZVIyhOQ95Z kMrzamX_2cnR7VtZSrjVKFN8KdcMsPbNqdYzQHAsfH3K.FLpYl1ESyVCCK3A.rzUPGfgWBhoY_m2 7wRhYUhOUGJvHmHc9XaQDKFd56QUQHTtgN7cAizWZAlfslIFyh6DfCKi49JanjAh_SGs1uOzEJeF 04gR07VvsAH2tKBPc2GNXzdaRwhxQp.hvixGwoXtBgttwA17B3gD1lEqf7NtYN94zg9rcePfL2Iz n9vlowjcfq799NKN3HzEwcHMQ0s2VcoaQwNCgPTgR7Rz0zrFKUjlIkmI_dJnfIDRY7pZGpQthk7x 8pGlT73ukUpUNXmZ.jzAvtZt1_86vE6HxcsgclA6id0V506D.qlPYYcPQXNl5TLCLIwSPEi1PjCK xOwH6kGhfqeO7_4kfzyAShju7pQZvJ3LoQevpK46XoGP.fuUJXBf9PVAqsp6iQdUSBS54UTxfAN0 iB__bo6cbMur4MxBQ_NzsuaVskH3SRRAVmaGtYZm4OIdEdjVToEKSaHwmJ62nWmjs3zee6rtU8ZA vSzdXYL6cPgGrRPN29JdZHPUgEl4uGi_cAykKmk_8bHZw5gFUAIT_kqxUrnM55KJpTqVFdg87ikb I_j4aOxjR_FHkx946MQTVtZFDYXO46z1uY7DnbpAUM6uFS5CVX6g4ejuURaUMlSbvvCSXOugJymm w3uyROGdlJrtCjLKX04xgCQZKwheC6J02nBoOrdb9q0MRR9RwCtITLq6I0s06239AYyi1RPCCmIb vuhKkDQ0sq0TddbHHgCv9QYvxgN60dvE54iFp_CiEIf35gUBPFBPodgpCKG9Wh8qlNH5tum5rgab I9EWOVzDVxD3KmgUXypIjjH.y7y7H4NbxTzJQX5VScLi.CYL_FfRERIoeT2AcJ8D5HDXmDZ08osm qCF6I5061yYDWTy_X6_tD4h2z05haNgm1ZFuMB_qmm1G.Erj2Gqk2.t2Ahamh0oenjH7Ln2NptA5 dhPAThR5RrT.kOJ0DyBFoUToFzj4Db5nYb9_oWX3aDOQc.NBHwH50WQ6Nm04V2qC__rK0HXj4HJU ZojPKFeoUPd9XYVFOUVxga4Ymv3UMeKr7WTj1Gy1tETIExmsmDpE.T1CA5YUiWAsowxrazRkXvnP yXll8heAHBvzLCsPIuslVQcOSZzpEdVKUCXLlm5WQrxGPUBBev5wO0f7.2zap2aSL8uuHNxT0bnI Hv5ctTEi5B21XgM.Psx4Kq.HNVwg22Ij9B7aRalBDgLdlVbBqm.cwOHDoOonL2JzrvCUTSqKOX2f GduBe7IiSsHqhjXPm1KoUEp67Nq1YAVD4NM8XOc2qLBFEK3_HY.dLAZ4c3vFIL9x7JN9Bd32Z1BL 1CCt1ceK2CFj__20ITwrP56hmX7R.cJcQT.YVKp3VHCPw0GZWdeBOySC5ms15GgEcSVK5JVB1IAb __hIpu2F_0xz3kiIpGdZnre77bGdb.N2sGbOMb.See3A5tudGSGQL7hEfhU1MrkFQJS1qE63.rr1 PkONvRZXfxBpvxHEomtCY6uwz4jdusqAQTh52hYzNFFlKuYj5tDt2cMqP02UWQVjT4tVKoMDadP0 FicsqjMwUBpCO8raScPwwHBYZaLd1g5JjCQ5hHlrdv0hsfyjwxSUTsovYohEHzN2lJzAUVLfw1Qb ISijlH4Y6ETlqSkqXMxEhJQu04DLEIhBhgQ.jTIfS6PcOsDNQyibLiOyHDdtLjHRLOCCNtkelVTS ot62jYJu_UeMmVYOcm.RLIFPoINLNGqbFLKWF5Qu_pTTbJcDH.9MS46_oOJagtK_rsh2HYuVyIkm P.EMxBfgPXNh2RDfR_CnDjRnnYXsa7OVH98Pvlt4Un3jdKWv3CWe7F9utXCFlvEGajNtnocuo1Oa VnRR3vEETeNbwhiF7IU2dZgeKXA4wTAPGgPestIFw71DZFie1tcAqF6hr9HJhPrSeYDKXTJ9f5Jv jZ6iaFQUyTGOHQ.4lbH2qDNabRkLsjpVbMr1Ac34ybtuNp94ddE4JN9LDgz0iE_ydBDzxqvpcSwB AJwMKus1Rnc2IPsxry8am4yV8HpSATZhJyrC84xRinldEAZzbEFKQxWs7kI5nTfFTS1VkRf.XJam YKn4KK3kXV_6Q3BQu9MBn5XtRchX_BtgKnWw1uV4vmrxwWJJD2s2zEf8WjkWypPjS9BY_IBhT3vC m6Q-- X-Sonic-MF: Message-ID: <4e74aae6-7d8c-15ed-c571-b797239374cb@netscape.net> Date: Wed, 13 Jul 2022 15:22:57 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> <56a304ad-606f-6d33-bd2b-8c614fcdb666@netscape.net> In-Reply-To: <56a304ad-606f-6d33-bd2b-8c614fcdb666@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2856 On 7/13/2022 3:07 PM, Chuck Zmudzinski wrote: > On 7/13/2022 9:45 AM, Juergen Gross wrote: > > >> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > > >> And in addition, if we are going to backport this patch to > > >> all current stable branches, we better have a really, really, > > >> good reason for changing the behavior of "nopat" on Xen. > > >> > > >> Does such a reason exist? > > > > > > Well, the simple reason is: It doesn't work the same way under Xen > > > and non-Xen (in turn because, before my patch or whatever equivalent > > > work, things don't work properly anyway, PAT-wise). Yet it definitely > > > ought to behave the same everywhere, imo. > > > > There is Documentation/x86/pat.rst which rather clearly states, how > > "nopat" is meant to work. It should not change the contents of the > > PAT MSR and keep it just as it was set at boot time (the doc talks > > about the "BIOS" setting of the MSR, and I guess in the Xen case > > the hypervisor is kind of acting as the BIOS). > > > > The question is, whether "nopat" needs to be translated to > > pat_enabled() returning "false". > > When I started working on a re-factoring effort of the logic > surrounding pat_enabled(), I noticed there are five different > reasons in the current code for setting pat_disabled to true, > which IMO is what should be a redundant variable that should > always be equal !pat_enabled() and !pat_bp_enabled, but that > unfortunately is not the case. The five reasons for setting > pat_disabled to true are given as message strings: > > 1. "MTRRs disabled, skipping PAT initialization too." > 2. "PAT support disabled because CONFIG_MTRR is disabled in the kernel." > 3. "PAT support disabled via boot option." > 4. "PAT not supported by the CPU." > 5. "PAT support disabled by the firmware." > > The only effect of setting pat_disabled to true is to inhibit > the execution of pat_init(), but it does not inhibit the execution > of init_cache_modes(), which is for handling all these cases > when pat_init() was skipped. The Xen case is one of those > cases, so in the Xen case, pat_disabled will be true yet the > only way to fix the current regression and the five-year-old > commit is by setting pat_bp_enabled to true so pat_enabled() > will return true. So to fix the five-year-old commit, we must have > > pat_enabled() != pat_disabled > > Something is wrong with this logic, that is why I wanted to precede > my fix with some re-factoring that will change some variable > and function names and modify some comments before trying > to fix the five-year-old commit, so that we will never have a situation > when pat_enabled() != pat_disabled. > > Chuck Sorry, I meant to say, To fix the five-year-old commit, we must have pat_enabled() != !pat_disabled or pat_enabled() == pat_disabled, and there is something wrong with that logic. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 19:38:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 19:38:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366963.597943 (Exim 4.92) (envelope-from ) id 1oBiBn-00046T-JH; Wed, 13 Jul 2022 19:38:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366963.597943; Wed, 13 Jul 2022 19:38:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBiBn-00046M-GL; Wed, 13 Jul 2022 19:38:27 +0000 Received: by outflank-mailman (input) for mailman id 366963; Wed, 13 Jul 2022 19:38:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBiBm-00046G-88 for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 19:38:26 +0000 Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5a9a138d-02e3-11ed-924f-1f966e50362f; Wed, 13 Jul 2022 21:38:24 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 19:38:21 +0000 Received: by hermes--production-bf1-58957fb66f-p6kcj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 564882263554cd3ca01f52971e669fd2; Wed, 13 Jul 2022 19:38:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a9a138d-02e3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657741101; bh=gvegsbKA0Ugq9G0OL2YHhHKrmsIiT+j/cAd/AQ6k6Xs=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=MZQFw9/JPmpuroD8LpVy2xa3dQDRMBFdA1RTqyTtfXGmJdjhwswFVzyIiTtrjeVLke4h9R6vpbhZrwclrfloBGOp2L+wHCFozHHxshm96MpC8KnvxjrbCxDHjQlpRIUpJr3OANhsOqTkaEeDDjVqPyjjcXAeyvNV5NU3tZXVKTLiEK/0j7m1/p13hezk70gaMuusWCA4JRaa2p0Jzse6r7VoUMRvivNOpBOcUWfv/kgTPfpCaZHSyerdo5KS/z7T6qpy9go7S/K1gkEUopfNCmdCWHS4IDEM6Mgm4KYZ0+hLIe52QXhqSu9Uw1QPPkIk8YBYeUMNc2FU2q5el6C0KQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657741101; bh=gZ+FnmKOj2zVRAIddN3HlDPLO1hF3KTuu1g/XWWOSUs=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=a2pkxJoMqAMjHRNepy+Lww/IxC/RE0FTJRCwDDn/wY4E0LE8qCmiLkebT84SXNo+TlgHg11MluHHmltYfW7+EFlikPZ0urlzkyhtpPIYnT6NBiEKkEIrkJ5o2w4NJKVADJI7/18sg/UjKFESFH+RP6AYTYe1iExKtTUIDxtME5cTWF1ITBkUd+qnpyaT8NMqsZHgdMNbLrpBrJDldNKFgg9Zzpn0s/q6EMtoxgdHUy+mvasB13AiPzduJ9m04jq7bK/mbIgapg9+LTqtVnZf/Vhl5Gjt/5aLDz9bMDVv/+DDIUctfWPI3NckNk1ChAZ+i9BgzS9+VYZuS4pRfNSbeg== X-YMail-OSG: 6luG7AYVM1ncjX7nkCvm9bLVe10whawpCglcbiYMUxQ2vlNaWqmz.Z9bEDOn_49 iRTUpxQz7K2qvaNS2J2y8psq2P0rEXp5vqGKyN11aM77RStL50FoqtrPJ6j0bdro7hg3IcsH09JN ne3T8aDhdkdYjDnOAxG0TmPRA4l7CQlxppszvaPxaSWGEXoEQydR9VpICDcRUf7Q6fDXGSbrNB_0 Q572vxdxIFATyMSkoluEbUneSV3IRw.dOKEdOVreZTJOYaWtmd6mp8juh1i6BTSAU6HhiNGAlCOY UJnkfjbe5CWsZ5zDBlI8Qvhp8HKy0d9SEZZrNp4ZbtrWZEzaDi.o3Ij7rkk9ADsdFrVldnY.psmh knlFFmuqF6mXn_04ZRXKcTCX8829w.r.ah1gNITohjd8JqSnEEgfuqI2rnDOSogBGCGR.ojSthf1 9cwixTxmGffEbuyyKVnf0x1MvLirnTSUrVAeWE2CL7louDYGEpd03wPfoAbs4rnb4l11Y3k21XcW Lbt1W2p4yGRVwKOIwthaq12o74hdGxUinST.2p4ZS2HgDgeQhMWD2SB7vFCrR.ZyWhmG0juDZr_y lFueayb9GF8.WkWzvPIeV7T6lfG73MnfrhAbz.PTbByim89nFkpHGRB46D_LIGQPYBk4gIsgml5F UaCBrtqWwDjWaRyxNqlCr7SfT5XlP7Xoyqgiqqq7LBD2f6fOD0qHtebvJGZccgMk8eOd0ECXRRPa 7l7rNL5juqI99YtXBU4dRG.uP_Tw_T3R20JxGBs.2HXiMA3GB8f16_9rZdCk86nBXJqcGwa2VJV6 yRjwbC7UHKGmlkqDcWYRIqYrj_aaeokYD7yAwntlrAkjo1HLlcIvyT2uQOQS6wSKfB5HjgpRGS0R 9UhoLIsYxVvpwC6v2HWTOvlHC70DFJyk04G69oizXdeBicJGz_eH.InuYvclXJQcX44_EYXtSF80 Xmc5ReIFPw6o4Nvw2a0nmOkwNd67hhv_6vcyGfURwyUHsuys17jHmXyKDsKkY.Bonqyx2H15AQ9b 3tokiGn3Y4nPWzGgnviaD6LXI3DyRu00uv8oB.gzfDuHeDhSETaPelKXMmF2nImaT.tKktPDAocD 4zNoYSG_xPqWm5cksbgvpXA5tR8OqpcZN6djOiIKVLu5Dyx4H6rI0Pu3oOFE17HmEZdZVmVk9lUG rgNtz52CKxTbNdgMmTLJBehtHFw6pansJH296wx0y26C8wZkjpFAU1J8BtiYqjNbTjOX6qNfASio chc.zRQCDGkLV78hS9Z4Jp9fByWtFyJ3DEhF.tco3rXB9la83ONyM2dklm9YQtcofpccVVtMZf6M rFuSmRQVxGQ7mpRiScTlS2dM_PU7XQO3crjWzhZAPSKYnHKwUvDse4tBUGqkgTyv2LxlEtF2p1rE nXzD4O54dQAj7GOH7LZJBB4y.N4VJD0c71jg_zfwoT8PIdvByLHQ2Q1J6CiGDBItchWsci_mkpsZ F.BvZUFLlmGv5SE2r0wFRAIRedSB1LcaiF2w.5T2dDq6c8ntVjv7WJdyViKxF4PoXjQM0MGv.zPt IVFuiiRtW3OxU15KT2btrB7iriw17eCDKzd7JaqBvZujjeCV05DkTGEyVqYDJdN9Z.oCduNyunYC LyW2kuwf0w.KJPt6J2_8s0aQzv11v76SuPMMhUMpPRWFVRnxEDeCTWiVuF4m.XqaRAonA7idjTMk 54s80Vdyra0rFJylo9njYUS7qP4Y.2gdNBO6WXa7w8lh3bNZDsRHChZQPMRPgE48w7zAE9lzrVoY 2vcFB__DJE.MEB8_a43uDr1Wd4HaM8FYe0RCu7YgdcCzjYdmZkKNkQofUpvhtMtN6E_SRxrrtOpr 5OURJ9WfoKOATbcUcbSSOcOrExivbbAGtL0JiQEqYJ47Qlu5QF.WhGdXRUCslRUGq7c9U3Ai_oHo FYRfLsYLhqfxSEzuq6g3.1FFZHFypkQhNncDQ4gU.UZIKvUyFWGBTbjYrV5qS8Wk.qyU1Q1Vedfv umnFJk_NU1qEn.aUiv_.fihm.ivkRppWG0H_a.yp0cuWcELo1hd.W6jKtaIAToVmuxLc.PjczmGD _9tuqHljtG6g92DYqhD.6WkVzlar2mMaD0RmSt3MQvM1eUp6vZ7m1AkYrquTAHudbRlCVO.AIvWI dnc_HFSnf6_NX0xYI.hq.laqyMvQ99CXMuLBFAlCoIczXGGRgwwRynI4OedIYZj95bLfbVasiHgZ WNt2WUQ-- X-Sonic-MF: Message-ID: <9c97d8b4-ae1d-efd0-8414-91a50d22cf12@netscape.net> Date: Wed, 13 Jul 2022 15:38:16 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> <56a304ad-606f-6d33-bd2b-8c614fcdb666@netscape.net> <4e74aae6-7d8c-15ed-c571-b797239374cb@netscape.net> In-Reply-To: <4e74aae6-7d8c-15ed-c571-b797239374cb@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 3702 On 7/13/2022 3:22 PM, Chuck Zmudzinski wrote: > On 7/13/2022 3:07 PM, Chuck Zmudzinski wrote: > > On 7/13/2022 9:45 AM, Juergen Gross wrote: > > > >> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > > > >> And in addition, if we are going to backport this patch to > > > >> all current stable branches, we better have a really, really, > > > >> good reason for changing the behavior of "nopat" on Xen. > > > >> > > > >> Does such a reason exist? > > > > > > > > Well, the simple reason is: It doesn't work the same way under Xen > > > > and non-Xen (in turn because, before my patch or whatever equivalent > > > > work, things don't work properly anyway, PAT-wise). Yet it definitely > > > > ought to behave the same everywhere, imo. > > > > > > There is Documentation/x86/pat.rst which rather clearly states, how > > > "nopat" is meant to work. It should not change the contents of the > > > PAT MSR and keep it just as it was set at boot time (the doc talks > > > about the "BIOS" setting of the MSR, and I guess in the Xen case > > > the hypervisor is kind of acting as the BIOS). > > > > > > The question is, whether "nopat" needs to be translated to > > > pat_enabled() returning "false". > > > > When I started working on a re-factoring effort of the logic > > surrounding pat_enabled(), I noticed there are five different > > reasons in the current code for setting pat_disabled to true, > > which IMO is what should be a redundant variable that should > > always be equal !pat_enabled() and !pat_bp_enabled, but that > > unfortunately is not the case. The five reasons for setting > > pat_disabled to true are given as message strings: > > > > 1. "MTRRs disabled, skipping PAT initialization too." > > 2. "PAT support disabled because CONFIG_MTRR is disabled in the kernel." > > 3. "PAT support disabled via boot option." > > 4. "PAT not supported by the CPU." > > 5. "PAT support disabled by the firmware." > > > > The only effect of setting pat_disabled to true is to inhibit > > the execution of pat_init(), but it does not inhibit the execution > > of init_cache_modes(), which is for handling all these cases > > when pat_init() was skipped. The Xen case is one of those > > cases, so in the Xen case, pat_disabled will be true yet the > > only way to fix the current regression and the five-year-old > > commit is by setting pat_bp_enabled to true so pat_enabled() > > will return true. So to fix the five-year-old commit, we must have > > > > pat_enabled() != pat_disabled > > > > Something is wrong with this logic, that is why I wanted to precede > > my fix with some re-factoring that will change some variable > > and function names and modify some comments before trying > > to fix the five-year-old commit, so that we will never have a situation > > when pat_enabled() != pat_disabled. > > > > Chuck > Sorry, I meant to say, > > To fix the five-year-old commit, we must have > > pat_enabled() != !pat_disabled or pat_enabled() == pat_disabled, > > and there is something wrong with that logic. > > Chuck So to summarize, I think this means that to be comfortable fixing the five-year-old commit and the current regression by artificially setting pat_bp_enabled and pat_enabled() to true, something which both my patch and Jan's patch does, we need to come to a new understanding of what the static boolean variable pat_disabled in arch/x86/mm/pat/memtype.c in the code really means. The fact is, we have a regression and the only fix we can find is to try to make pat_enabled() == pat_disabled I need to stop thinking about this for a while. It is time for those who have authority to fix this regression to make some comments about how they think this should be fixed. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 21:20:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 21:20:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366970.597955 (Exim 4.92) (envelope-from ) id 1oBjls-0006u6-UR; Wed, 13 Jul 2022 21:19:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366970.597955; Wed, 13 Jul 2022 21:19:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBjls-0006tz-RQ; Wed, 13 Jul 2022 21:19:48 +0000 Received: by outflank-mailman (input) for mailman id 366970; Wed, 13 Jul 2022 21:19:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBjlr-0006tp-UI; Wed, 13 Jul 2022 21:19:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBjlr-0004Vr-Px; Wed, 13 Jul 2022 21:19:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBjlr-0002wQ-7m; Wed, 13 Jul 2022 21:19:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBjlr-0001OY-7H; Wed, 13 Jul 2022 21:19:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OOHCAh0h+pH8qCN9BSxA5MEYs+1MOn43zi6H77tERfw=; b=lG5XegfqQHDnFdScEzbiSLrOr5 JgLOtfCuC27IxNwW4UuIWodUTwQimagbNW2sgRP3Eu5oTs2qxmgxOVdIaROdpj0dWBCD876R/Ft0j subQWVVq7WHKqbqUSrgwlPxmp5LLVj+E6+Cel5nJphGYdfL6n/vu6G0on+pK2ewVUMDE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171611: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=b7e05cf96683f5c38b2d70176a7882e35b7ef5eb X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 13 Jul 2022 21:19:47 +0000 flight 171611 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171611/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt b7e05cf96683f5c38b2d70176a7882e35b7ef5eb baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 733 days Failing since 151818 2020-07-11 04:18:52 Z 732 days 714 attempts Testing same since 171611 2022-07-13 04:20:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115612 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 13 21:49:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 21:49:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366987.597998 (Exim 4.92) (envelope-from ) id 1oBkEY-0002eb-P1; Wed, 13 Jul 2022 21:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366987.597998; Wed, 13 Jul 2022 21:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBkEY-0002eU-Ln; Wed, 13 Jul 2022 21:49:26 +0000 Received: by outflank-mailman (input) for mailman id 366987; Wed, 13 Jul 2022 21:49:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBkEX-0002eK-CZ; Wed, 13 Jul 2022 21:49:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBkEX-00051D-3x; Wed, 13 Jul 2022 21:49:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBkEW-0004te-Jd; Wed, 13 Jul 2022 21:49:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBkEW-0003jS-J9; Wed, 13 Jul 2022 21:49:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qXzHiBXcVPSASBxwz7jdvQKjE4cMoDjlMPto8P1Z2vk=; b=p/XpJQDoRHNfp8G+UnQ4l3kGCD EjiBUNMpjc8N+PcpF+3T06vo1i7vsZvHTKTuPExiYAWMfwAPWhQZDedXW5JOk9Vuh4PFzHJ4JTqV3 W9G3Yp/tQ9XuMLnbihni218T2QQ8q9BfYHqfZHFHOlIQPJXp+T/cINM9dhYhQDwpXEPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 171609: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.15-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=35bf91d30f1a480dcf5bfd99b79384b2b283da7f X-Osstest-Versions-That: xen=505771bb1dffdf6f763fad18ee49a913b98abfea From: osstest service owner Date: Wed, 13 Jul 2022 21:49:24 +0000 flight 171609 xen-4.15-testing real [real] flight 171622 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171609/ http://logs.test-lab.xenproject.org/osstest/logs/171622/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 171622-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171622-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171594 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171594 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171594 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171594 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171594 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171594 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171594 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171594 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171594 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171594 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171594 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171594 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 35bf91d30f1a480dcf5bfd99b79384b2b283da7f baseline version: xen 505771bb1dffdf6f763fad18ee49a913b98abfea Last test of basis 171594 2022-07-12 09:37:57 Z 1 days Testing same since 171609 2022-07-13 00:09:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 505771bb1d..35bf91d30f 35bf91d30f1a480dcf5bfd99b79384b2b283da7f -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Jul 13 22:24:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 22:24:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.366995.598009 (Exim 4.92) (envelope-from ) id 1oBklx-0007F5-FX; Wed, 13 Jul 2022 22:23:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 366995.598009; Wed, 13 Jul 2022 22:23:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBklx-0007Ey-Cs; Wed, 13 Jul 2022 22:23:57 +0000 Received: by outflank-mailman (input) for mailman id 366995; Wed, 13 Jul 2022 22:23:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBklv-0007Es-VE for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 22:23:56 +0000 Received: from sonic312-24.consmr.mail.gq1.yahoo.com (sonic312-24.consmr.mail.gq1.yahoo.com [98.137.69.205]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 770299e2-02fa-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 00:23:52 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.gq1.yahoo.com with HTTP; Wed, 13 Jul 2022 22:23:47 +0000 Received: by hermes--production-bf1-58957fb66f-88chf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 89c21ab9e0ecbc439802f7109841f4ef; Wed, 13 Jul 2022 22:12:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 770299e2-02fa-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657751027; bh=sW1ejgoubTLnwSxkyhbV7vGRBPUmBbNSxg5+MIbDhoU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=qpM+8LkNvJpv2IazQOhWoG6ga8Mf5fMzrgAf3iD1Gr7RfXNktjWxVCdm3DskDkpXuOthD398Yh/EixpD17FrwPTJu8UDd+M3//cLneReikEWa+kKjLMqWGhhniN7K3g8bHCyd1/xvLukyGieBUbbXirKi8H61DC/K+Rd4O+MtOr/OFrjZB1IWv9Kq+soOwz/fyoVjFIGFlBJAMnrCuDY05WrEMJlkMw5aaGphEvqPUENbgN1eLx2x4OCD85Wo61z21isd7EcYMg/seiJMhUuCFZQ3R7VINKSM0l2J+qKhJ8Yq7TDlsCeVl8GIdBuzvXQsU8WYeA7XsSspPPZpw1p4Q== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657751027; bh=w3Hbd8gkD27Pm/Oqiz7knXK/nX+yJBbaxcNtUUPlc+N=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=VLPvzEncX0XDu8RqLHJF/4ixjj/9bKpKgYvmCisAfunlxFOgp753Ofrm7Bq3rPdVqVaHcQXHl5HyAG9+Y49YPlDaV3G3hTssa7W2+AGhiI8VHq+9eUodyx9+gdQ5U/gj4DDAuPI4vgpLgqZaCOwg3dja4AzV7AAyEx3ieeVe6GVJATLIEA7B4dMv95hqcdiW5XevZoSIa9f6JgUcWEAieM9x1QJharRwIHbkLljPOTiwYzOSETZUxQXhrPwXVZinEh0GBmzmfixgNudZAuwPXKrefMoXzSodz3pCKsjy5iu2K/g4cGHybqgmY6+v6HoxKqN9heSQB/sgbQhmIO4teQ== X-YMail-OSG: KNOgYQUVM1n2RjKzOe7Hc1pLGEFWIMp2pM7hEiX_E99y_3H6Q3_Ny4uz32kSH3G hYHDfrTumNu5krn0d0Fh_rjTsebyvOa5fOEpnbkAPejPwkFsB3rohEztZkkWAQxvoQf0ibTuahVX wR.uBdlZ8IfjYvVTW0aiKuxsaKpdv1D8lzq6aGwdDnptnoZI.zR2E8YH8EM7gR8NoSkPQpfCmLEr Kj3Smc0LGf1Z2kvMvmwvZqRhjDXffBnSNS8C2y.NG23SFURkzRD0HYiBr56lFTWZ_NmLFx8E7SdQ ySbVZ4LbZIqVkOVG.GTSwlQ9VYw.is3yUSF7Fw4DDL8dI8FmpDv01u5pMlaydiDhbaWdtX45_19i UGY5IIilrxpsUpe6GvtnY7u5AWHz.WJK.NpwQQ7lbn9PsXhWKutB0FhxiOPGS58VYlVdjnF2iQKt FIwxlfA7_wSlJygBEkNwFBWbaMZd0.lYDaTvsJq4pIVpTRWjmXgQZ0.HghbAEI_BZ4fl6_gz1hCU e1nL0oakYqiBXNJ5.7c5uJGE6x4EYPUSxFlRibYeYeaDXEKM59CpdrjPnFIgyeHpnrpqT.wIdbGm yHjCehGxTg8pEhjIOYm9cbUK1BO1LSCTvoTd68GDRyj.J9AxpeG2O3kB1.RSErrUp0fprpBfaROG xy2ymm3JSDCYx.OADcmexujp0.0YJdfPHoA0np9lxJGq9CBYUO7ZwJAB6w.K87.IYm92r2EyM51X bWqUUYcQMEJUqPot0Ov1_QvpTS62TkKYcQiTd3FpeHvntA29dHaFaFNWZ.VBltsp2oYa7fLNy4u7 7Wy6Bh4dfCk68.6sgk2CdbdrPjx7A1ip1TYh_YAJi8fpAqlfyqs0Lc.yVJKY1XVbaRV2r3TSr2sw UCW50eiryck0O2ER3fxnFfLAOA8QntgCPtF0H1xKBi2zfcxvP2EwO07MDQu_NVEOf.sfJD5mTnl0 e2z1qDEVa_y7QHhtKNiR4k1qqtp7nYVjM1W9OjQNakwDHyuMrrFvpHVsK9kbnp6O07f7BypUcj8K ZVNmnUXjHnxvbrZzsqTVom8NkTfGFuuk5KtlcWbD05IdLRUgNvZH1vJ8Ead4_ofdL.nyOs6bvW.M tQuOv_Ot7OW7qQqHjt4chTGW3NIT3fqtu02Nio7WE6bDrLwawBVerJQpq17UXYKWk0aGgJ8sLpU5 .3wucbPo2gePrjqggTm81q4fKD5OJGqyQPIdcLu2vY.TUcbdiMZr5DtnchB8wKvHOMWu25z2qMCm uy49ap2TTcGi0S5_T3QRVcMAZQBoMGFTwfKhpFBDE2V8NvUDyvkycoWAJaEvHctTPWUxrb5_6fI4 B6KIZeVrDz5kEFE_wCNEGar3h4O_FoaI42F1BKx3EdDR34QbniohkM2rqIScVTtX2zDTys1eRpJT 4py_LSSkkDHeigxNszvcAXMeoc90swpjvK6xBt7J.2TQefFDZjU36bP5X.lanG2zRwNq4oL9U4y2 q4kl8gnn11lep29qjae6PKS8HZDDTWSgtRTAHKnwQjqne8EKS_QK618jEFMft5Yqa_uLxHnhTT0J 5Qfeh4gYDIfaY2ryfL3pct5LMe2JX7lm_RjQEuW73gcrRutrkDgjHImYB5PXOBklK2.vLCak88xW i_DmMR74KfbrfSJGB1oQTsmjPQ.L5RPCuTZf_WMbaCJLEZsF8yAUDer7XsaeMm7K5yKhodluLlYm 8JGP_n47da4ZP8zGW6fSoOmgR.XtM4P_uK1QIP3wkgbGb23.3R_l.WVAMStNpP3mQam8PAwfMEnF pXUE4uSqhezLU4uFO_eMmy4HAQI_zuPitQnShyssJ25uqEJNBQWLi_NwbyrDSIUsktJ9qpHtff1b stGhWoejsiviIhPk6.RhqTlDkwIG5fUzC4L7H7XMYoXzjV5HUg90VcXFXXPzUBm3OXfaeTd9CXfw d4fY9UDl0Qof1Go6qBuOW1yvJ0AXTyfz4HONjwm_lrghkEiWYj8awLvg- X-Sonic-MF: Message-ID: Date: Wed, 13 Jul 2022 18:12:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Juergen Gross , Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, "Kirill A. Shutemov" References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <3d3f0766-2e06-428b-65bb-5d9f778a2baf@netscape.net> <775493aa-618c-676f-8aa4-d1667cf2ca78@netscape.net> <1d06203b-97ff-e7eb-28ae-4cdbc7569218@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 9029 On 7/13/2022 9:45 AM, Juergen Gross wrote: > On 13.07.22 15:34, Jan Beulich wrote: > > On 13.07.2022 13:10, Chuck Zmudzinski wrote: > >> On 7/13/2022 6:36 AM, Chuck Zmudzinski wrote: > >>> On 7/13/2022 5:09 AM, Jan Beulich wrote: > >>>> On 13.07.2022 10:51, Chuck Zmudzinski wrote: > >>>>> On 7/13/22 2:18 AM, Jan Beulich wrote: > >>>>>> On 13.07.2022 03:36, Chuck Zmudzinski wrote: > >>>>>>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>>>>>> *Add the necessary code to incorporate the "nopat" fix > >>>>>>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>>>>>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>>>>>> *Expand the commit message to include relevant parts of the commit > >>>>>>> message of Jan Beulich's proposed patch for this problem > >>>>>>> *Fix 'else if ... {' placement and indentation > >>>>>>> *Remove indication the backport to stable branches is only back to 5.17.y > >>>>>>> > >>>>>>> I think these changes address all the comments on the original patch > >>>>>>> > >>>>>>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>>>>>> include Jan's idea for fixing "nopat" that was missing from the first > >>>>>>> version of the patch. > >>>>>> > >>>>>> You've sufficiently altered this change to clearly no longer want my > >>>>>> S-o-b; unfortunately in fact I think you broke things: > >>>>> > >>>>> Well, I hope we can come to an agreement so I have > >>>>> your S-o-b. But that would probably require me to remove > >>>>> Juergen's R-b. > >>>>> > >>>>>>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>>>>>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>>>>>> } > >>>>>>> > >>>>>>> - if (!pat) { > >>>>>>> + if (!pat || pat_force_disabled) { > >>>>>> > >>>>>> By checking the new variable here ... > >>>>>> > >>>>>>> /* > >>>>>>> * No PAT. Emulate the PAT table that corresponds to the two > >>>>>>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>>>>>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>>>>>> */ > >>>>>>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>>>>>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>>>>> > >>>>>> ... you put in place a software view which doesn't match hardware. I > >>>>>> continue to think that ... > >>>>>> > >>>>>>> + } else if (!pat_bp_enabled) { > >>>>>> > >>>>>> ... the variable wants checking here instead (at which point, yes, > >>>>>> this comes quite close to simply being a v2 of my original patch). > >>>>>> > >>>>>> By using !pat_bp_enabled here you actually broaden where the change > >>>>>> would take effect. Iirc Boris had asked to narrow things (besides > >>>>>> voicing opposition to this approach altogether). Even without that > >>>>>> request I wonder whether you aren't going to far with this. > >>>>>> > >>>>>> Jan > >>>>> > >>>>> I thought about checking for the administrator's "nopat" > >>>>> setting where you suggest which would limit the effect > >>>>> of "nopat" to not reporting PAT as enabled to device > >>>>> drivers who query for PAT availability using pat_enabled(). > >>>>> The main reason I did not do that is that due to the fact > >>>>> that we cannot write to the PAT MSR, we cannot really > >>>>> disable PAT. But we come closer to respecting the wishes > >>>>> of the administrator by configuring the caching modes as > >>>>> if PAT is actually disabled by the hardware or firmware > >>>>> when in fact it is not. > >>>>> > >>>>> What would you propose logging as a message when > >>>>> we report PAT as disabled via pat_enabled()? The main > >>>>> reason I did not choose to check the new variable in the > >>>>> new 'else if' block is that I could not figure out what to > >>>>> tell the administrator in that case. I think we would have > >>>>> to log something like, "nopat is set, but we cannot disable > >>>>> PAT, doing our best to disable PAT by not reporting PAT > >>>>> as enabled via pat_enabled(), but that does not guarantee > >>>>> that kernel drivers and components cannot use PAT if they > >>>>> query for PAT support using boot_cpu_has(X86_FEATURE_PAT) > >>>>> instead of pat_enabled()." However, I acknowledge WC mappings > >>>>> would still be disabled because arch_can_pci_mmap_wc() will > >>>>> be false if pat_enabled() is false. > >>>>> > >>>>> Perhaps we also need to log something if we keep the > >>>>> check for "nopat" where I placed it. We could say something > >>>>> like: "nopat is set, but we cannot disable hardware/firmware > >>>>> PAT support, so we are emulating as if there is no PAT support > >>>>> which puts in place a software view that does not match > >>>>> hardware." > >>>>> > >>>>> No matter what, because we cannot write to PAT MSR in > >>>>> the Xen PV case, we probably need to log something to > >>>>> explain the problems associated with trying to honor the > >>>>> administrator's request. Also, what log level should it be. > >>>>> Should it be a pr_warn instead of a pr_info? > >>>> > >>>> I'm afraid I'm the wrong one to answer logging questions. As you > >>>> can see from my original patch, I didn't add any new logging (and > >>>> no addition was requested in the comments that I have got). I also > >>>> don't think "nopat" has ever meant "disable PAT", as the feature > >>>> is either there or not. Instead I think it was always seen as > >>>> "disable fiddling with PAT", which by implication means using > >>>> whatever is there (if the feature / MSR itself is available). > >>> > >>> IIRC, I do think I mentioned in the comments on your patch that > >>> it would be preferable to mention in the commit message that > >>> your patch would change the current behavior of "nopat" on > >>> Xen. The question is, how much do we want to change the > >>> current behavior of "nopat" on Xen. I think if we have to change > >>> the current behavior of "nopat" on Xen and if we are going > >>> to propagate that change to all current stable branches all > >>> the way back to 4.9.y,, we better make a lot of noise about > >>> what we are doing here. > >>> > >>> Chuck > >> > >> And in addition, if we are going to backport this patch to > >> all current stable branches, we better have a really, really, > >> good reason for changing the behavior of "nopat" on Xen. > >> > >> Does such a reason exist? > > > > Well, the simple reason is: It doesn't work the same way under Xen > > and non-Xen (in turn because, before my patch or whatever equivalent > > work, things don't work properly anyway, PAT-wise). Yet it definitely > > ought to behave the same everywhere, imo. > > There is Documentation/x86/pat.rst which rather clearly states, how > "nopat" is meant to work. It should not change the contents of the > PAT MSR and keep it just as it was set at boot time (the doc talks > about the "BIOS" setting of the MSR, and I guess in the Xen case > the hypervisor is kind of acting as the BIOS). If that is the true meaning of "nopat", then the pat_enabled() test we currently have in the i915 driver is the wrong test for the capability of the CPU to use the fast WC type pages for video frames access because it is possible for pat_enabled() to be false and "nopat" set with its official meaning, and still have a CPU with WC cache mode capability. If we accept pat_enabled() as implied WC cache mode support, why not also accept (!pat_enabled && boot_cpu_has(X86_FEATURE_HYPERVISOR)) also as implied WC cache mode support? That is what Jan's patch effectively does. He just possibly places his patch in the wrong portion of the Linux tree to be consistent with the official meaning of "nopat" and pat_enabled(). We could implement Jan's fix instead in the i915 driver instead if we need to be consistent with the official meaning of "nopat" and pat_enabled(). I could make that a v3 of my patch - and try the i915 maintainers instead of the x86 maintainers to provide the fix. But before I do that, can someone on this list of 20 recipients tell me why none of you have fixed this nasty regression? I am new to trying to contribute to Linux and the whole experience is frustrating when all you get is stonewalling from the official maintainers. So why not just someone step up and do this fix? In the meantime, Juergen can start working on cleaning up the x86/PAT code so it can provide the i915 driver with a test not for PAT, but for the WC page caching mode support that works in all supported environments, including Xen. Currently there is no such test available. Juergen proposed one but it failed to accurately test for WC cache mode capability on my Xen workstation. Until the x86 subsystem developers can provide the rest of Linux with an accurate test for the WC caching mode, we have to settle for less than a pure and perfect solution if we are serious about following Linus' regression rule and accept a quick fix to a nasty regression while we wait for a better solution that will hopefully come later. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 13 23:28:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 13 Jul 2022 23:28:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367002.598019 (Exim 4.92) (envelope-from ) id 1oBlls-00062M-7s; Wed, 13 Jul 2022 23:27:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367002.598019; Wed, 13 Jul 2022 23:27:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBlls-00062F-5L; Wed, 13 Jul 2022 23:27:56 +0000 Received: by outflank-mailman (input) for mailman id 367002; Wed, 13 Jul 2022 23:27:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBllq-000628-Jr for xen-devel@lists.xenproject.org; Wed, 13 Jul 2022 23:27:55 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 693464b1-0303-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 01:27:51 +0200 (CEST) Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26DJDchI019281; Wed, 13 Jul 2022 23:27:30 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71xrkme0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jul 2022 23:27:30 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26DNR7lw005503; Wed, 13 Jul 2022 23:27:29 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2170.outbound.protection.outlook.com [104.47.59.170]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h70456hd3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Jul 2022 23:27:29 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DS0PR10MB6030.namprd10.prod.outlook.com (2603:10b6:8:ce::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Wed, 13 Jul 2022 23:27:27 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5438.014; Wed, 13 Jul 2022 23:27:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 693464b1-0303-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=O63Zo9CVw6tLu9AmWzCRCoRDaMmyH4/OstxUvNxdCuE=; b=jiFEWs8HokkynJMv0q6u20JS7BznZ6emF0jyD53yAmrHVhlup8Ec5mDpCMjaf4xPxUyU CGYnkHzH2+fXzRwbk+TT3YyRI9RBkhOdyxbK0qy4/98xvzw1wOlqEm89rzcvF48xKsxV gzhqAvZWxgFSb/GbRpMhk4cbkA3uhrW1JPf6YNDzXp+4JlqRxN8mm5e3GtSKJi7t0kfT mPbqMDsAZHFP+dgsv7PYlhla1VQ6eGT1DysPOKpEd+242xpo7onR7kovKE3UpOzF5QPb Oz+50aKIWqC4ntBb9WAKHIxPkggFJyvpjwQ9SVVbmF1y86lwtt+XPIeSDMoMyI2qfh0d qA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TzY6IJM1nou7EyDN+tOOZVkpJw33uVoS6d36noRMQuniKxElHrsEsMHtT0CqbdpWSeJYCzvZM0Ao0vobtDWknCAyqepzTqHityMEy37evQI9M239qEY7Pw0RWbYR40kTi6uDbN3E0vsQ9iBiR1rmQkRJ5e8MNeaVV7KWJ6Eu8EGY4yWTnQ2tiX9v9Eem0kssGXBUTYcx5H72PJ1Nndh87Zy1kkLJCIu2K+PwzS6WZelYwtzsHVxp5jxggWayoCaLX9CbyMJPK4XIsiPft6hto/q0KUWYHU8QSRm63GctpEbgT5HwqKz54GF74ATe2ue8dMee6riyQy7ATAXqzZibIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O63Zo9CVw6tLu9AmWzCRCoRDaMmyH4/OstxUvNxdCuE=; b=LPk4iyqNot9zWUwgnXnqUHabXwuVwGx4veRP7ud7BWJ9CEaHjka8gjp+WBoykskHUOC6br3Wj/ZIOkPyvaC060Lc/skKe7YsREY/rTMhoSo0yM1tlfeD29rBRZJ5lN+S0cLQT1faZWjFztNp/A3bD9+jp4UQo4BB2ZzoN2wch5dSyGwNoBDq7QwEMWladvdmuwrCUjCpiZDeJ2TMKwuABaTZ7mx0b+zW6D8Zg5gH5D0uPJ+hSBYm9QbzC3s26Al1Hpi7UwoSmhP6fEHSPd2LF3CJg22PmbXhuo5Gpt2SFLule/3gOCvP9JV8/2ZMJdsBjNh8BiEI163dpLZaGUi5kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O63Zo9CVw6tLu9AmWzCRCoRDaMmyH4/OstxUvNxdCuE=; b=ZjgeG4MgpvO69hBJM+O+jo+k9up4sHtZsV2VE41Zwe8HVe763NXaaX9NYyT40fZra/XeRYgS4H8U1zMF+bN+CykOoSBT/kn+Oabt4vFTJUkrALBnrOXQQ0D/cFWUineYzBty2/N8ibszapwS4xMfd6ijhn4l+kPbuJ9FnCTTHGo= Message-ID: <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> Date: Wed, 13 Jul 2022 19:27:20 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane , LKML Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , xen-devel@lists.xenproject.org References: <20220711152230.17749-1-jane.malalane@citrix.com> From: Boris Ostrovsky In-Reply-To: <20220711152230.17749-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BYAPR02CA0054.namprd02.prod.outlook.com (2603:10b6:a03:54::31) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24043e95-fcd2-4ca9-87b7-08da65273f9a X-MS-TrafficTypeDiagnostic: DS0PR10MB6030:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZNLyvlVDc6T59bS+lOZkTDBHgm9qzL+qn24KDZW22dTvbuZN+wurjxQYhKwdDGGnmTr4uoV5aqVokZi6NjJBaN8Iem/L0lpOKbl8Tc20gNB/69KvwWNTkmfDRrKoxzsebfDF1AFfWjo+VLwvVIR3PG6vxcXz782ZxmTxXtuOZSjD9LWUwbM7Q9IcfLxfRz/FJJpSNW1WRsqKMMeXL1/ys2PKsCN3WT08CAs7ViDpnr0KYSt6Wx018U1zaX02uAdh7Aaw7BYHVAQL5FYcxFTmq5/K19xzqJBpfwMVyWpcavTDn3WfXJ3H8ixTsFRU84sVjZX/8zzicg30/f+/HtR7cJpJMvwafVFLBk7Yeexz8osHCeJHF2CaJbk1c6dORAAFkVSNGs8lYCINCtmuHepvHH9lMGyvyvowUHkxdtudtN6ghNTKAa0IYkDVbNR+Rk+EssilgMqrGqVoeyqCbw5ONHpdLReO+GJYX9wEJYd9hBRsW0rIuh5ZPjbrF5czfEjIMvfDBZR8Qrca66C6ymmv+OGmcaHDMMKPo0cPTSdNGrjEKbMgwMvVTkCy6TmnGtYISTsXY9ymZZnspnYUz+JrbYf5EKwT3MXVImJgE+QpJEitjPj9kbSXVO2l7JjlUB6zBPoju7GczK96SXcyCTCtzddPEyTYZ2ZnXYTWfcDlJ53Mrg8Ih2Molw95x81YePf/bWrlaTbujMPy25gGJwJby898/R1Um4QTD0gaUyj8ifx9vtlMw6Z3VpAyyE5TWjmCU4FHpUChGGB7M29PoCI74gqTa3ua7ndpNSLT/E9+govN7EULdHbjgX0y7NUy9jB/8SsQF61eRextfgAkkeEY4Lrsg3so/L1/54eNpiinC2Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(366004)(376002)(346002)(396003)(186003)(66946007)(8936002)(8676002)(478600001)(4326008)(66556008)(66476007)(6512007)(38100700002)(6506007)(2616005)(26005)(41300700001)(53546011)(6666004)(83380400001)(6486002)(2906002)(44832011)(110136005)(5660300002)(7416002)(86362001)(31696002)(31686004)(316002)(36756003)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmtSalU2MzZQOGRpZHhTWUZZZU5CV0swd2tZM0phOTQ4VTl6cWVLS3RFZGty?= =?utf-8?B?cStxWE5wMlEwYmpPdGljS0lQWTJxUXR2Nms0WVZDRmtlVjNjZG1DY1RleFJu?= =?utf-8?B?dCt5Y3JQVVVBRTdKbVFTY01vNEhlQ0xEZXVDOW0wczF3T29SVjgyYXQwd0RF?= =?utf-8?B?M0s2c1pIbzAwMm01QnRGOVVmbitUSlYyMG91V1IzWmNSWlBsNVdRSzNPclpJ?= =?utf-8?B?dFFYRDJZcUxKL1Z3YldxSFllNEVwUFJ2bExYSWwrZHh0cURQNGVTUVh4WEE0?= =?utf-8?B?NUwxT3JTbFlOdnJtQko3OTQxd1FjOXE5UHl4VExjWFl4dUVuQVNYdDZsaXFt?= =?utf-8?B?NzU4OUgxUmRUNnRmSmJGWWNMOUxaQmRXaFhjdWpuV3ZxKytaVVVVVkdYcWpG?= =?utf-8?B?eGhQbGZRMHF6SjEwV0JKOVgzdVJyRitQZXppMVB3YXk3UE1PeUtoTVlZVnRq?= =?utf-8?B?RzRBRDlacVJYS1o2aFRVclY4RXltVDhWYWdPNnpFTHNWd2E1WmZvMklQWXFE?= =?utf-8?B?OHRqbVV5VXZCWWFnWUlaUjdTSVJKOG5ISFc2OTZXSVc1KzZoUm55S1BCRWFU?= =?utf-8?B?WFF5NnUwUnhxYStPVEwzR2xyZnk0cVROMGE0dWlSYXlxeTEzV1NBV2N5c0du?= =?utf-8?B?RUp4TnFTRzRUWWJIbkV4WWNpVkdranROdlJGRkhITExVcC9oRThUOWQ4Qm9W?= =?utf-8?B?SW9UZFBrNGpIem9DTUxNRC9RT1JRV2hibkdOb1FCUXVMSURtWGhlZGRpNmFh?= =?utf-8?B?SEtEallQKzdoanpjcGI2aFR2TFd6RThJQS9FT1p3Q3RTSWYvZElBb1cwS1ow?= =?utf-8?B?RHdFMzVlQ0h3UzBDSUVkWlMvSE1sbmEydmRoNmRLVnJwZXM2dmxuRmN1dXdv?= =?utf-8?B?L2FuZ2ljRm5RVlAzRG03V1AzSWdQaFQ1eXBiYkJWZHp0ejNidzRmMjR5SVkr?= =?utf-8?B?OEZ3eHB0Z2xkd24zaFdEbDBNTjU3VGhkS1pUVWYvNlA2WWJwZmVmT2U0Q2py?= =?utf-8?B?c3Q4ZHFwSFhYWWpxYkt1eXNZNXNENEwyQlJGMGJlL1Fyc2M5dXFpK0Q5UFJC?= =?utf-8?B?NG1PaFExOGpaWDlWVk5QTU4yRVl5azlJQ0ZZalNEZDF3ZVFHM2ZsUjl6UU9i?= =?utf-8?B?K3lKenpld1FhM2VoeEt3Q3ZmaE92cm4xeWgyaTFIb3dxVnkydTA4QncvdEFj?= =?utf-8?B?eFA1b3ZiMHhCcjgzQ3Yvb0lqWThSRzFVQ1htRXg2disvS294eFlxSk5KNXhj?= =?utf-8?B?TmQwV05peDlyWmxwalQ4Vkd2Zm5YNjhlWXpJbUNRT2dnK000OS9IeHBzZktV?= =?utf-8?B?cjk5cEd1UXYvODFLTUZBKzB0a1J5aVhXQVBWRDZXZTF5T25JTTNtMWJwMEs1?= =?utf-8?B?aENOZVZqOTRPZUZ5ekJhS2p4bjNTVDFhdHlzcURrWlhNS0VQNHdTMDZIaXpT?= =?utf-8?B?b295anRydDBCaWwvRGthdkZnODFXa05yekhmR3RDYTZzK2xIcS9YOXF1TWdZ?= =?utf-8?B?LzlGR3ZvbWp3QkFKZWJhalNpVmJiVGxmWlZRTGF3L2d0cmVCQVN5TEo3bWZB?= =?utf-8?B?ZnpTdGRWS0doOW8yZjNsVXVYZ1VOeWJ6S1lPVmo5T2x6RXdLR1dGYXcxVGkz?= =?utf-8?B?bWNmMytGQStnbmZPK1hyWGdIcWpjZWhHb0VTelRNMkN1MlowWjRLL09HeDBp?= =?utf-8?B?SVNCYWh1Y2VsTzN3Tlc0R1BjRkxzZkhzUHZsVEFtKzhSQVg3UzIrY2QramJ4?= =?utf-8?B?a1h5b0pTSmJtdmYwNUh3bjFQQmhLVEM1YzUxczd5M0hwb2g1Z0NucUp5RUJi?= =?utf-8?B?cnN2NnM4L1BuNk1Rb3pMay9temRxZWtFZWd4SU5MRm5US291YXgvdmcvamVJ?= =?utf-8?B?MGQ5bmkvaVJ2eitzUUp2WG85YnBHSzhQYm8vbUJZR2JyUlVvSlNneDNzL1JH?= =?utf-8?B?NmJxcC9zcXFHeGlEUGtqMUhTcTdYeXVaM0dqZGhZSnAxc2ZINmdEeUdMTmxo?= =?utf-8?B?NlpqQktEZVJDaG55SDBVdDZxRWhPdENiYkZGWjJweFg1YTlBTHFsUzBmclRz?= =?utf-8?B?Q2xIdmtlUUcxNHJhcmdEMmF0UWFHQmgrMVFJbmg1aWpPVkRDOHUzeXdrQzB3?= =?utf-8?B?Q0JsdE1RWFBqKzNWeVhsZDY3TUkvS2kzNlZTU3ZFUlFKQnJoV2FaVm1rRGdj?= =?utf-8?B?MGc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24043e95-fcd2-4ca9-87b7-08da65273f9a X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 23:27:27.3130 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gkqUsdd+wnjkiwxLfFTLX53KoFHIWY1j1B6LXLNg+EQ/Lo1jtXzfF/cUkSX64ik8tYruWKooJ0ILj5SFw1pkpY6T8PiNbbAhFd7TFI76RTo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB6030 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-13_12:2022-07-13,2022-07-13 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207130094 X-Proofpoint-GUID: VUyLlksXFZp2kv0TacYfIQkJFJiU0Xa2 X-Proofpoint-ORIG-GUID: VUyLlksXFZp2kv0TacYfIQkJFJiU0Xa2 On 7/11/22 11:22 AM, Jane Malalane wrote: > --- a/arch/x86/xen/enlighten_hvm.c > +++ b/arch/x86/xen/enlighten_hvm.c > @@ -7,6 +7,7 @@ > > #include > #include > +#include > #include > > #include > @@ -30,6 +31,9 @@ > > static unsigned long shared_info_pfn; > > +__ro_after_init bool xen_ack_upcall; > +EXPORT_SYMBOL_GPL(xen_ack_upcall); Shouldn't this be called something like xen_percpu_upcall? > + > void xen_hvm_init_shared_info(void) > { > struct xen_add_to_physmap xatp; > @@ -125,6 +129,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) > { > struct pt_regs *old_regs = set_irq_regs(regs); > > + if (xen_ack_upcall) > + ack_APIC_irq(); > + > inc_irq_stat(irq_hv_callback_count); > > xen_hvm_evtchn_do_upcall(); > @@ -168,6 +175,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) > if (!xen_have_vector_callback) > return 0; > > + if (xen_ack_upcall) { > + xen_hvm_evtchn_upcall_vector_t op = { > + .vector = HYPERVISOR_CALLBACK_VECTOR, > + .vcpu = per_cpu(xen_vcpu_id, cpu), > + }; > + > + BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op)); Does this have to be fatal? Can't we just fail bringing this vcpu up? > + } > + > if (xen_feature(XENFEAT_hvm_safe_pvclock)) > xen_setup_timer(cpu); > > @@ -211,8 +227,7 @@ static void __init xen_hvm_guest_init(void) > > xen_panic_handler_init(); > > - if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) > - xen_have_vector_callback = 1; > + xen_have_vector_callback = !no_vector_callback; Can we get rid of one of those two variables then? > > xen_hvm_smp_init(); > WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); > diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c > index 9d548b0c772f..be66e027ef28 100644 > --- a/arch/x86/xen/suspend_hvm.c > +++ b/arch/x86/xen/suspend_hvm.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > > #include "xen-ops.h" > > @@ -14,6 +15,23 @@ void xen_hvm_post_suspend(int suspend_cancelled) > xen_hvm_init_shared_info(); > xen_vcpu_restore(); > } > - xen_setup_callback_vector(); > + if (xen_ack_upcall) { > + unsigned int cpu; > + > + for_each_online_cpu(cpu) { > + xen_hvm_evtchn_upcall_vector_t op = { > + .vector = HYPERVISOR_CALLBACK_VECTOR, > + .vcpu = per_cpu(xen_vcpu_id, cpu), > + }; > + > + BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, > + &op)); > + /* Trick toolstack to think we are enlightened. */ > + if (!cpu) > + BUG_ON(xen_set_callback_via(1)); What are you trying to make the toolstack aware of? That we have *a* callback (either global or percpu)? BTW, you can take it out the loop. And maybe @op definition too, except for .vcpu assignment. > + } > + } else { > + xen_setup_callback_vector(); > + } > xen_unplug_emulated_devices(); > } -boris From xen-devel-bounces@lists.xenproject.org Thu Jul 14 00:25:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 00:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367008.598031 (Exim 4.92) (envelope-from ) id 1oBmfY-0004vj-Vq; Thu, 14 Jul 2022 00:25:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367008.598031; Thu, 14 Jul 2022 00:25:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBmfY-0004vc-RB; Thu, 14 Jul 2022 00:25:28 +0000 Received: by outflank-mailman (input) for mailman id 367008; Thu, 14 Jul 2022 00:25:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBmfW-0004vV-TU for xen-devel@lists.xen.org; Thu, 14 Jul 2022 00:25:27 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73802876-030b-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 02:25:24 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id ez10so541870ejc.13 for ; Wed, 13 Jul 2022 17:25:23 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73802876-030b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cachengo.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0kqpp7QGbfFm9DUk74gcmib92kRDsr/UjV9s2oX/ecI=; b=vLM0GthkPjRB2WTR9b0e8rUJMstKA6+Y5/d9LUKRpYQFNxthZJrHSsnmEajgYBT6T7 iSLAzzMN7282Rsw9exIPWyXWrHo+T0v9REXb0UCuBtX7VQvf+9h3FLLWOEVJMuoBiY6m XpSz4UoOVk4j0DOVUTzDuvF+/Hq4CtO+kWeT7e3Tzo+mKT6A/SdMvXQAhr228McgDSwe mFJtPYGSk3hcBfs+fzm+garFUhTo57CFpJSPMHDYAW5j99NcWSVydNvxXN0kriZZdGCh zvdAQyjCysUXw0UqNb1KndyrIhMkAMbVxCqZmFmYfsA0yLFRsRBR0Cyq7ptZz4u6KqM3 Zm3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0kqpp7QGbfFm9DUk74gcmib92kRDsr/UjV9s2oX/ecI=; b=cV/JPdWZdA3u7xZ1hFukf1f9sZGKXZAHXpprD6WPXEFkvWZuScmSXgtYy8/qRrPkql i/DB8zY7e9htXeTzw/tGXVK+0gpRmw+bcnWQ5t5Rxxezt1dEoF6f9IZTXRpzdEx52M6F xIIzsMUCkebNRx7aIEBaXsQf+S9aY9EXCe7aeoREWx8EfCtb1frOdyWZT1xmR0KJXylg 3T48JBxL49F8Vk0xOpPaobRW2lLI+25lFfOrCQpdSf0TbGDQw8NmEgxx0dJfF0R+g/La kl2htS3Gf3FrbWuxnT9YycXsl0RjagWaXU1hKIxauz6NuL/zz/q5WUMy7bRvYMu8bs8G tmNA== X-Gm-Message-State: AJIora+DoUi5ktel0oglxwSbfoSYiun7WsvD6u3RC1BCFQRswAdkGmnu 4Tz16C6oepR2Bb5QuZu1Um6qypfBS7uSHEsT5Fptrw== X-Google-Smtp-Source: AGRyM1tPMrhfc74z3EjoFyDkgrOmbPBKfXhCxOSY0fkiIsO8bteZ12hwopVd8N1YwuWuYXGKHL3RGyVbtUEJi2hX8wQ= X-Received: by 2002:a17:906:d553:b0:726:3562:98bd with SMTP id cr19-20020a170906d55300b00726356298bdmr6148777ejc.380.1657758323115; Wed, 13 Jul 2022 17:25:23 -0700 (PDT) MIME-Version: 1.0 References: <81265FD0-2D00-48D7-ACBA-0F7A4FF3DCAA@arm.com> In-Reply-To: From: Brad Churchwell Date: Wed, 13 Jul 2022 19:25:11 -0500 Message-ID: Subject: Re: Xen on rk3399 To: Bertrand Marquis Cc: xen-devel@lists.xen.org Content-Type: multipart/alternative; boundary="000000000000f920a205e3b8eff2" --000000000000f920a205e3b8eff2 Content-Type: text/plain; charset="UTF-8" I just wanted to add that I realize that it's just remapping the same IRQ. I've tried changing the values to accommodate SPI (+16) vs PPI (+32) which has only resulted in failure. On Wed, Jul 13, 2022, 8:32 AM Brad Churchwell wrote: > Hi Bertrand, > > I did this yesterday and it does indeed silence the warnings saying to > disable those cores, however the IRQ errors still remain. > > I think I made some progress by changing "interrupts = IRQ_TYPE_LEVEL_HIGH 0>;" to "interrupts = 0>;". I noticed when trying to use XEN-4.10 that it said "IRQ only through > SPI" and failed to boot XEN where 4.17 unstable boots without this error. > Now that I changed GIC_PPI to GIC_SPI, I get the following output: > zaku => run boot_pci_enum; run nvme_init; fatload nvme 0:1 0x02000000 > xen4.10-uImage; fatload nvme 0:1 0x01f00000 rk3399-zaku.dtb; fatload nvme > 0:1 0x03F80000 Image;fatload nvme 0:1 0 > 885136 bytes read in 5 ms (168.8 MiB/s) > 56185 bytes read in 3 ms (17.9 MiB/s) > 27885576 bytes read in 65 ms (409.1 MiB/s) > 8674182 bytes read in 22 ms (376 MiB/s) > ## Booting kernel from Legacy Image at 02000000 ... > Image Name: > Image Type: AArch64 Linux Kernel Image (uncompressed) > Data Size: 885072 Bytes = 864.3 KiB > Load Address: 02000000 > Entry Point: 02000000 > Verifying Checksum ... OK > ## Flattened Device Tree blob at 01f00000 > Booting using the fdt blob at 0x1f00000 > Loading Kernel Image > Loading Device Tree to 00000000f1efd000, end 00000000f1f0db78 ... OK > > Starting kernel ... > > - UART enabled - > - CPU 00000000 booting - > - Current EL 00000008 - > - Xen starting at EL2 - > - Zero BSS - > - Setting up control registers - > - Turning on paging - > - Ready - > (XEN) Checking for initrd in /chosen > (XEN) RAM: 0000000000200000 - 00000000f7ffffff > (XEN) > (XEN) MODULE[0]: 00000000f1efd000 - 00000000f1f0b000 Device Tree > (XEN) MODULE[1]: 0000000003f80000 - 0000000005a28008 Kernel > (XEN) MODULE[2]: 0000000006000000 - 0000000008000000 Ramdisk > (XEN) > (XEN) Command line: > (XEN) Placing Xen at 0x00000000f7e00000-0x00000000f8000000 > (XEN) Update BOOTMOD_XEN from 0000000002000000-0000000002120d81 => > 00000000f7e00000-00000000f7f20d81 > (XEN) Domain heap initialised > (XEN) Booting using Device Tree > (XEN) Platform: Generic System > (XEN) Taking dtuart configuration from /chosen/stdout-path > (XEN) Looking for dtuart at "serial2", options "1500000n8" > Xen 4.10.1 > (XEN) Xen version 4.10.1 (root@) (aarch64-linux-gnu-gcc (Linaro GCC > 7.3-2018.05) 7.3.1 20180425 [linaro-7.3-2018.05 revision > d29120a424ecfbc167ef90065c0eeb7f91977701]) debug=y Tue J2 > (XEN) Latest ChangeSet: > (XEN) Processor: 410fd034: "ARM Limited", variant: 0x0, part 0xd03, rev 0x4 > (XEN) 64-bit Execution: > (XEN) Processor Features: 0000000001002222 0000000000000000 > (XEN) Exception Levels: EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32 > (XEN) Extensions: FloatingPoint AdvancedSIMD GICv3-SysReg > (XEN) Debug Features: 0000000010305106 0000000000000000 > (XEN) Auxiliary Features: 0000000000000000 0000000000000000 > (XEN) Memory Model Features: 0000000000001122 0000000000000000 > (XEN) ISA Features: 0000000000011120 0000000000000000 > (XEN) 32-bit Execution: > (XEN) Processor Features: 00000131:10011011 > (XEN) Instruction Sets: AArch32 A32 Thumb Thumb-2 Jazelle > (XEN) Extensions: GenericTimer Security > (XEN) Debug Features: 03010066 > (XEN) Auxiliary Features: 00000000 > (XEN) Memory Model Features: 10201105 40000000 01260000 02102211 > (XEN) ISA Features: 02101110 13112111 21232042 01112131 00011142 00011121 > (XEN) Using SMC Calling Convention v1.0 > (XEN) Using PSCI v1.0 > (XEN) SMP: Allowing 4 CPUs > (XEN) Generic Timer IRQ: phys=30 hyp=26 virt=27 Freq: 24000 KHz > (XEN) GICv3 initialization: > (XEN) gic_dist_addr=0x000000fee00000 > (XEN) gic_maintenance_irq=41 > (XEN) gic_rdist_stride=0 > (XEN) gic_rdist_regions=1 > (XEN) redistributor regions: > (XEN) - region 0: 0x000000fef00000 - 0x000000fefc0000 > (XEN) GICv3 compatible with GICv2 cbase 0x000000fff00000 vbase > 0x000000fff20000 > (XEN) GICv3: 288 lines, (IID 0001143b). > (XEN) GICv3: CPU0: Found redistributor in region 0 @000000004001c000 > (XEN) Using scheduler: SMP Credit Scheduler (credit) > (XEN) Allocated console ring of 32 KiB. > (XEN) Bringing up CPU1 > - CPU 00000001 booting - > - Current EL 00000008 - > - Xen starting at EL2 - > - Setting up control registers - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU1: Found redistributor in region 0 @000000004003c000 > (XEN) CPU 1 booted. > (XEN) Bringing up CPU2 > - CPU 00000002 booting - > - Current EL 00000008 - > - Xen starting at EL2 - > - Setting up control registers - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU2: Found redistributor in region 0 @000000004005c000 > (XEN) CPU 2 booted. > (XEN) Bringing up CPU3 > - CPU 00000003 booting - > - Current EL 00000008 - > - Xen starting at EL2 - > - Setting up control registers - > - Turning on paging - > - Ready - > (XEN) GICv3: CPU3: Found redistributor in region 0 @000000004007c000 > (XEN) CPU 3 booted. > (XEN) Brought up 4 CPUs > (XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID > (XEN) P2M: 3 levels with order-1 root, VTCR 0x80023558 > (XEN) I/O virtualisation disabled > (XEN) build-id: b7279757e82e3e9ea4c4115dabdbfe25d56d762b > (XEN) alternatives: Patching with alt table 000000004018fe70 -> > 0000000040190350 > (XEN) grant_table.c:1731:IDLEv0 Expanding d0 grant table from 0 to 1 frames > (XEN) *** LOADING DOMAIN 0 *** > (XEN) Loading kernel from boot module @ 0000000003f80000 > (XEN) Loading ramdisk from boot module @ 0000000006000000 > (XEN) Allocating 1:1 mappings totalling 512MB for dom0: > (XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB) > (XEN) Grant table range: 0x000000f7e00000-0x000000f7e40000 > (XEN) IRQ 41 is already used by Xen > (XEN) Unable to map IRQ41 to dom0 > (XEN) Device tree generation failed (-16). > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Could not set up DOM0 guest OS > (XEN) **************************************** > (XEN) > (XEN) Reboot in five seconds... > > It looks like XEN is now using the interrupt controller but there are > conflicts. I was able to get this error to change to "Unable to map IRQ43 > to dom0" by changing all instances of "IRQ_TYPE_LEVEL_HIGH " to > "IRQ_TYPE_LEVEL_LOW", but I can't get any further. I made sure that there > was nothing in the device tree that is obviously using IRQ 43 as well. > > Any thoughts on this? > > Cheers, > Brad > > > On Wed, Jul 13, 2022, 8:00 AM Bertrand Marquis > wrote: > >> Hi Brad >> >> > On 12 Jul 2022, at 17:24, Brad Churchwell wrote: >> > >> > Hi Bertrand, >> > >> > I believe I understand, but just to clarify, should I leave the >> ppi-partitions block in rk3399.dtsi as is and disable the little cores, or >> should I also modify that block? >> >> Disable the little cores and remove the partitions. >> >> Cheers >> Bertrand >> >> > >> > Brad >> > >> > On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis < >> Bertrand.Marquis@arm.com> wrote: >> > Hi Brad, >> > >> > > On 12 Jul 2022, at 16:59, Brad Churchwell wrote: >> > > >> > > Hi Bertrand, >> > > >> > > Thanks so much for the quick response! >> > > >> > > I should have mentioned previously that this device tree and kernel >> Image (5.15.16) does boot properly with the rootfs without XEN. The >> interrupt errors are only present when booting with XEN. >> > > >> > > These are custom boards and they do have usb c, however we are unable >> to boot from usb as it doesn't receive power. We currently only use the >> usb to flash u-boot to spi which requires us to use a separate power >> adapter. These boards get power and networking through a custom backplane >> and interface with the backplane via a sata style justice (I'm not sure >> what the proper terminology would be here). >> > > >> > > Since I cannot boot to rootfs with XEN, I'm unable to show the device >> tree there. The only bit that I added to accommodate XEN is this bit here: >> > > >> > > chosen { >> > > stdout-path = "serial2:1500000n8"; >> > > bootargs = "hmp-unsafe=true"; >> > > xen,dom0-bootargs = "console=hvc0 earlyprintk=xen >> clk_ignore_unused root=/dev/nvme0n1p2 rw init=/sbin/init rootwait >> rootfstype=ext4 ignore_loglevel"; >> > > modules { >> > > #address-cells = <2>; >> > > #size-cells = <2>; >> > > >> > > module@1 { >> > > compatible = "xen,linux-zimage", "xen,multiboot-module"; >> > > reg = <0x0 0x03F80000 0x0 0x01aa8008>; >> > > }; >> > > module@2 { >> > > compatible = "xen,linux-initrd", "xen,multiboot-module"; >> > > reg = <0x0 0x06000000 0x0 0x02000000>; >> > > }; >> > > }; >> > > >> > > }; >> > > >> > > The gic declaration is in the vanilla rk3399.dtsi file and hasn't >> been modified: >> > > >> > > gic: interrupt-controller@fee00000 { >> > > compatible = "arm,gic-v3"; >> > > #interrupt-cells = <4>; >> > > #address-cells = <2>; >> > > #size-cells = <2>; >> > > ranges; >> > > interrupt-controller; >> > > >> > > reg = <0x0 0xfee00000 0 0x10000>, /* GICD */ >> > > <0x0 0xfef00000 0 0xc0000>, /* GICR */ >> > > <0x0 0xfff00000 0 0x10000>, /* GICC */ >> > > <0x0 0xfff10000 0 0x10000>, /* GICH */ >> > > <0x0 0xfff20000 0 0x10000>; /* GICV */ >> > > interrupts = ; >> > > its: interrupt-controller@fee20000 { >> > > compatible = "arm,gic-v3-its"; >> > > msi-controller; >> > > #msi-cells = <1>; >> > > reg = <0x0 0xfee20000 0x0 0x20000>; >> > > }; >> > > >> > > ppi-partitions { >> > > ppi_cluster0: interrupt-partition-0 { >> > > affinity = <&cpu_l0 &cpu_l1 &cpu_l2 >> &cpu_l3>; >> > > }; >> > > >> > > ppi_cluster1: interrupt-partition-1 { >> > > affinity = <&cpu_b0 &cpu_b1>; >> > > }; >> > > }; >> > >> > Xen is not supporting PPI partitions. >> > I also saw that your booting using SMP unsafe so all core are enabled >> by Xen. >> > >> > Right now big/little is not supported by Xen and here you might have >> some interrupts in your system which can only occur on some specific cores. >> > I would suggest to try the following: >> > - only boot enable in your dtb the cores with the same type than the >> boot core >> > - check in your device tree which devices are assign to the ppi_cluster >> not available and disable them >> > >> > This kind of configuration will be tricky to handle so it will depend >> on which devices have interrupts that can only be fired on one cluster type. >> > >> > Sorry but I cannot right now check in the device tree and do those >> checks myself but if you do get the idea send back a mail :-) >> > >> > Cheers >> > Bertrand >> > >> > > }; >> > > >> > > I've attached the device tree and include files just in case you'd >> like to take a look at those. >> > > >> > > Thanks so much for your help! I've been at this for weeks with very >> little progress. >> > > >> > > Cheers, >> > > Brad >> > > >> > > >> > > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis < >> Bertrand.Marquis@arm.com> wrote: >> > > Hi Brad, >> > > >> > > > On 11 Jul 2022, at 19:38, Brad Churchwell >> wrote: >> > > > >> > > > Hello, >> > > > >> > > > I've been trying to get Xen to boot dom0 with my kernel for weeks >> on an rk3399 based board and thought I'd reach out for help. It looks like >> either Xen is not properly recreating the device tree or the interrupt >> controller is just failing. The hypervisor boots but falls to initramfs >> because it cannot find the root device (nvme on pcie). Any help would be >> greatly appreciated. Here is the complete boot log >> > > >> > > From the logs you have an issue with the interrupt controller and the >> fact that your NVME is behind PCIE and as such depends on ITS is probably >> not helping. >> > > >> > > I would suggest to try to boot on usb as root fs for a try. >> > > >> > > Also it could be useful to compare the device tree on xen and without >> xen to understand what is going on (using /proc/device-tree). >> > > >> > > Xen seems to be ok but Linux is not happy with interrupts and is >> showing several issues around this area on your logs. >> > > Could you show us an extract of your device tree around the gic >> declaration ? >> > > >> > > Cheers >> > > Bertrand >> > > >> > > >> > > IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> > > >> > >> > IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> > --000000000000f920a205e3b8eff2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I just wanted to add that I realize that it's just re= mapping the same IRQ. I've tried changing the values to accommodate SPI= (+16) vs PPI (+32) which has only resulted in failure.=C2=A0

On Wed, Jul 13= , 2022, 8:32 AM Brad Churchwell <br= ad@cachengo.com> wrote:
Hi Bertrand,

I did this yesterday and it does indeed silence the warnings = saying to disable those cores, however the IRQ errors still remain.=C2=A0

I think I made some progr= ess by changing "interrupts =3D <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>= ;;" to "interrupts =3D <GIC_SPI 9 IRQ_TYPE_LEVEL_HIGH 0>;&q= uot;. I noticed when trying to use XEN-4.10 that it said "IRQ only thr= ough SPI" and failed to boot XEN where 4.17 unstable=C2=A0boots withou= t this error. Now that I changed GIC_PPI to GIC_SPI, I get the following ou= tput:
zaku =3D> run boot_pci_enum; run nvme_init;= fatload nvme 0:1 0x02000000 xen4.10-uImage; fatload nvme 0:1 0x01f00000 rk= 3399-zaku.dtb; fatload nvme 0:1 0x03F80000 Image;fatload nvme 0:1 0
8851= 36 bytes read in 5 ms (168.8 MiB/s)
56185 bytes read in 3 ms (17.9 MiB/s= )
27885576 bytes read in 65 ms (409.1 MiB/s)
8674182 bytes read in 22= ms (376 MiB/s)
## Booting kernel from Legacy Image at 02000000 ...
= =C2=A0 =C2=A0Image Name: =C2=A0
=C2=A0 =C2=A0Image Type: =C2=A0 AArch64= Linux Kernel Image (uncompressed)
=C2=A0 =C2=A0Data Size: =C2=A0 =C2=A0= 885072 Bytes =3D 864.3 KiB
=C2=A0 =C2=A0Load Address: 02000000
=C2=A0= =C2=A0Entry Point: =C2=A002000000
=C2=A0 =C2=A0Verifying Checksum ... O= K
## Flattened Device Tree blob at 01f00000
=C2=A0 =C2=A0Booting usin= g the fdt blob at 0x1f00000
=C2=A0 =C2=A0Loading Kernel Image
=C2=A0 = =C2=A0Loading Device Tree to 00000000f1efd000, end 00000000f1f0db78 ... OK<= br>
Starting kernel ...

- UART enabled -
- CPU 00000000 bootin= g -
- Current EL 00000008 -
- Xen starting at EL2 -
- Zero BSS -- Setting up control registers -
- Turning on paging -
- Ready -(XEN) Checking for initrd in /chosen
(XEN) RAM: 0000000000200000 - 0000= 0000f7ffffff
(XEN)
(XEN) MODULE[0]: 00000000f1efd000 - 00000000f1f0b= 000 Device Tree =C2=A0
(XEN) MODULE[1]: 0000000003f80000 - 0000000005a28= 008 Kernel =C2=A0 =C2=A0 =C2=A0
(XEN) MODULE[2]: 0000000006000000 - 000= 0000008000000 Ramdisk =C2=A0 =C2=A0 =C2=A0
(XEN)
(XEN) Command line:= <NULL>
(XEN) Placing Xen at 0x00000000f7e00000-0x00000000f8000000=
(XEN) Update BOOTMOD_XEN from 0000000002000000-0000000002120d81 =3D>= 00000000f7e00000-00000000f7f20d81
(XEN) Domain heap initialised
(XEN= ) Booting using Device Tree
(XEN) Platform: Generic System
(XEN) Taki= ng dtuart configuration from /chosen/stdout-path
(XEN) Looking for dtuar= t at "serial2", options "1500000n8"
=C2=A0Xen 4.10.1=
(XEN) Xen version 4.10.1 (root@) (aarch64-linux-gnu-gcc (Linaro GCC 7.3= -2018.05) 7.3.1 20180425 [linaro-7.3-2018.05 revision d29120a424ecfbc167ef9= 0065c0eeb7f91977701]) debug=3Dy =C2=A0Tue J2
(XEN) Latest ChangeSet: (XEN) Processor: 410fd034: "ARM Limited", variant: 0x0, part 0xd= 03, rev 0x4
(XEN) 64-bit Execution:
(XEN) =C2=A0 Processor Features: = 0000000001002222 0000000000000000
(XEN) =C2=A0 =C2=A0 Exception Levels: = EL3:64+32 EL2:64+32 EL1:64+32 EL0:64+32
(XEN) =C2=A0 =C2=A0 Extensions: = FloatingPoint AdvancedSIMD GICv3-SysReg
(XEN) =C2=A0 Debug Features: 000= 0000010305106 0000000000000000
(XEN) =C2=A0 Auxiliary Features: 00000000= 00000000 0000000000000000
(XEN) =C2=A0 Memory Model Features: 0000000000= 001122 0000000000000000
(XEN) =C2=A0 ISA Features: =C2=A0000000000001112= 0 0000000000000000
(XEN) 32-bit Execution:
(XEN) =C2=A0 Processor Fea= tures: 00000131:10011011
(XEN) =C2=A0 =C2=A0 Instruction Sets: AArch32 A= 32 Thumb Thumb-2 Jazelle
(XEN) =C2=A0 =C2=A0 Extensions: GenericTimer Se= curity
(XEN) =C2=A0 Debug Features: 03010066
(XEN) =C2=A0 Auxiliary F= eatures: 00000000
(XEN) =C2=A0 Memory Model Features: 10201105 40000000 = 01260000 02102211
(XEN) =C2=A0ISA Features: 02101110 13112111 21232042 0= 1112131 00011142 00011121
(XEN) Using SMC Calling Convention v1.0
(XE= N) Using PSCI v1.0
(XEN) SMP: Allowing 4 CPUs
(XEN) Generic Timer IRQ= : phys=3D30 hyp=3D26 virt=3D27 Freq: 24000 KHz
(XEN) GICv3 initializatio= n:
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_dist_addr=3D0x000000fee00000
(XEN) = =C2=A0 =C2=A0 =C2=A0 gic_maintenance_irq=3D41
(XEN) =C2=A0 =C2=A0 =C2=A0= gic_rdist_stride=3D0
(XEN) =C2=A0 =C2=A0 =C2=A0 gic_rdist_regions=3D1(XEN) =C2=A0 =C2=A0 =C2=A0 redistributor regions:
(XEN) =C2=A0 =C2=A0 = =C2=A0 =C2=A0 - region 0: 0x000000fef00000 - 0x000000fefc0000
(XEN) GICv= 3 compatible with GICv2 cbase 0x000000fff00000 vbase 0x000000fff20000
(X= EN) GICv3: 288 lines, (IID 0001143b).
(XEN) GICv3: CPU0: Found redistrib= utor in region 0 @000000004001c000
(XEN) Using scheduler: SMP Credit Sch= eduler (credit)
(XEN) Allocated console ring of 32 KiB.
(XEN) Bringin= g up CPU1
- CPU 00000001 booting -
- Current EL 00000008 -
- Xen s= tarting at EL2 -
- Setting up control registers -
- Turning on paging= -
- Ready -
(XEN) GICv3: CPU1: Found redistributor in region 0 @0000= 00004003c000
(XEN) CPU 1 booted.
(XEN) Bringing up CPU2
- CPU 0000= 0002 booting -
- Current EL 00000008 -
- Xen starting at EL2 -
- S= etting up control registers -
- Turning on paging -
- Ready -
(XEN= ) GICv3: CPU2: Found redistributor in region 0 @000000004005c000
(XEN) C= PU 2 booted.
(XEN) Bringing up CPU3
- CPU 00000003 booting -
- Cur= rent EL 00000008 -
- Xen starting at EL2 -
- Setting up control regis= ters -
- Turning on paging -
- Ready -
(XEN) GICv3: CPU3: Found re= distributor in region 0 @000000004007c000
(XEN) CPU 3 booted.
(XEN) B= rought up 4 CPUs
(XEN) P2M: 40-bit IPA with 40-bit PA and 8-bit VMID
= (XEN) P2M: 3 levels with order-1 root, VTCR 0x80023558
(XEN) I/O virtual= isation disabled
(XEN) build-id: b7279757e82e3e9ea4c4115dabdbfe25d56d762= b
(XEN) alternatives: Patching with alt table 000000004018fe70 -> 000= 0000040190350
(XEN) grant_table.c:1731:IDLEv0 Expanding d0 grant table f= rom 0 to 1 frames
(XEN) *** LOADING DOMAIN 0 ***
(XEN) Loading kernel= from boot module @ 0000000003f80000
(XEN) Loading ramdisk from boot mod= ule @ 0000000006000000
(XEN) Allocating 1:1 mappings totalling 512MB for= dom0:
(XEN) BANK[0] 0x00000020000000-0x00000040000000 (512MB)
(XEN) = Grant table range: 0x000000f7e00000-0x000000f7e40000
(XEN) IRQ 41 is alr= eady used by Xen
(XEN) Unable to map IRQ41 to dom0
(XEN) Device tree = generation failed (-16).
(XEN)
(XEN) *******************************= *********
(XEN) Panic on CPU 0:
(XEN) Could not set up DOM0 guest OS<= br>(XEN) ****************************************
(XEN)
(XEN) Reboot= in five seconds...

It looks like= XEN is now using the interrupt controller but there are conflicts. I was a= ble to get this error to change to "Unable to map IRQ43 to dom0" = by changing all instances of "IRQ_TYPE_LEVEL_HIGH " to "IRQ_= TYPE_LEVEL_LOW", but I can't get any further. I made sure that the= re was nothing in the device tree that is obviously using IRQ 43 as well.= =C2=A0

Any thoughts on this?

<= div>Cheers,
Brad
=C2=A0
<= br>
On Wed,= Jul 13, 2022, 8:00 AM Bertrand Marquis <Bertrand.Marquis@arm.com<= /a>> wrote:
H= i Brad

> On 12 Jul 2022, at 17:24, Brad Churchwell <brad@cachengo.= com> wrote:
>
> Hi Bertrand,
>
> I believe I understand, but just to clarify, should I leave the ppi-pa= rtitions block in rk3399.dtsi as is and disable the little cores, or should= I also modify that block?

Disable the little cores and remove the partitions.

Cheers
Bertrand

>
> Brad
>
> On Tue, Jul 12, 2022 at 11:11 AM Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
> Hi Brad,
>
> > On 12 Jul 2022, at 16:59, Brad Churchwell <brad@cach= engo.com> wrote:
> >
> > Hi Bertrand,
> >
> > Thanks so much for the quick response!
> >
> > I should have mentioned previously that this device tree and kern= el Image (5.15.16) does boot properly with the rootfs without XEN. The inte= rrupt errors are only present when booting with XEN.
> >
> > These are custom boards and they do have usb c, however we are un= able to boot from usb as it doesn't receive power.=C2=A0 We currently o= nly use the usb to flash u-boot to spi which requires us to use a separate = power adapter. These boards get power and networking through a custom backp= lane and interface with the backplane via a sata style justice (I'm not= sure what the proper terminology would be here).
> >
> > Since I cannot boot to rootfs with XEN, I'm unable to show th= e device tree there. The only bit that I added to accommodate XEN is this b= it here:
> >
> > chosen {
> >=C2=A0 =C2=A0 =C2=A0stdout-path =3D "serial2:1500000n8";=
> >=C2=A0 =C2=A0 =C2=A0bootargs =3D "hmp-unsafe=3Dtrue"; > >=C2=A0 =C2=A0 =C2=A0xen,dom0-bootargs =3D "console=3Dhvc0 ear= lyprintk=3Dxen clk_ignore_unused root=3D/dev/nvme0n1p2 rw init=3D/sbin/init= rootwait rootfstype=3Dext4 ignore_loglevel";
> >=C2=A0 =C2=A0 =C2=A0modules {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#address-cells =3D <2>; > >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#size-cells =3D <2>;
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@1 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &qu= ot;xen,linux-zimage", "xen,multiboot-module";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x= 03F80000 0x0 0x01aa8008>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0module@2 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0compatible =3D &qu= ot;xen,linux-initrd", "xen,multiboot-module";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0x= 06000000 0x0 0x02000000>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0};
> >
> > };
> >
> > The gic declaration is in the vanilla rk3399.dtsi file and hasn&#= 39;t been modified:
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gic: interrupt-controller@fee000= 00 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0comp= atible =3D "arm,gic-v3";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#int= errupt-cells =3D <4>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#add= ress-cells =3D <2>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0#siz= e-cells =3D <2>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0rang= es;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inte= rrupt-controller;
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0reg = =3D <0x0 0xfee00000 0 0x10000>, /* GICD */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfef00000 0 0xc0000>, /* GICR */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff00000 0 0x10000>, /* GICC */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff10000 0 0x10000>, /* GICH */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0<0x0 0xfff20000 0 0x10000>; /* GICV */
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0inte= rrupts =3D <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH 0>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0its:= interrupt-controller@fee20000 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0compatible =3D "arm,gic-v3-its";
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0msi-controller;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0#msi-cells =3D <1>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x0 0xfee20000 0x0 0x20000>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}; > >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ppi-= partitions {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0ppi_cluster0: interrupt-partition-0 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&c= pu_l0 &cpu_l1 &cpu_l2 &cpu_l3>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0};
> >
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0ppi_cluster1: interrupt-partition-1 {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0affinity =3D <&c= pu_b0 &cpu_b1>;
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0};
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}; >
> Xen is not supporting PPI partitions.
> I also saw that your booting using SMP unsafe so all core are enabled = by Xen.
>
> Right now big/little is not supported by Xen and here you might have s= ome interrupts in your system which can only occur on some specific cores.<= br> > I would suggest to try the following:
> - only boot enable in your dtb the cores with the same type than the b= oot core
> - check in your device tree which devices are assign to the ppi_cluste= r not available and disable them
>
> This kind of configuration will be tricky to handle so it will depend = on which devices have interrupts that can only be fired on one cluster type= .
>
> Sorry but I cannot right now check in the device tree and do those che= cks myself but if you do get the idea send back a mail :-)
>
> Cheers
> Bertrand
>
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0};
> >
> > I've attached the device tree and include files just in case = you'd like to take a look at those.
> >
> > Thanks so much for your help! I've been at this for weeks wit= h very little progress.
> >
> > Cheers,
> > Brad
> >
> >
> > On Tue, Jul 12, 2022 at 10:05 AM Bertrand Marquis <Bertrand.Marquis@arm.com> wrote:
> > Hi Brad,
> >
> > > On 11 Jul 2022, at 19:38, Brad Churchwell <brad= @cachengo.com> wrote:
> > >
> > > Hello,
> > >
> > > I've been trying to get Xen to boot dom0 with my kernel = for weeks on an rk3399 based board and thought I'd reach out for help. = It looks like either Xen is not properly recreating the device tree or the = interrupt controller is just failing. The hypervisor boots but falls to ini= tramfs because it cannot find the root device (nvme on pcie). Any help woul= d be greatly appreciated. Here is the complete boot log
> >
> > From the logs you have an issue with the interrupt controller and= the fact that your NVME is behind PCIE and as such depends on ITS is proba= bly not helping.
> >
> > I would suggest to try to boot on usb as root fs for a try.
> >
> > Also it could be useful to compare the device tree on xen and wit= hout xen to understand what is going on (using /proc/device-tree).
> >
> > Xen seems to be ok but Linux is not happy with interrupts and is = showing several issues around this area on your logs.
> > Could you show us an extract of your device tree around the gic d= eclaration ?
> >
> > Cheers
> > Bertrand
> >
> >
> > IMPORTANT NOTICE: The contents of this email and any attachments = are confidential and may also be privileged. If you are not the intended re= cipient, please notify the sender immediately and do not disclose the conte= nts to any other person, use it for any purpose, or store or copy the infor= mation in any medium. Thank you.
> > <rk3399-zaku.dts><rk3399-zaku.dtsi><rk3399.dtsi>= ;
>
> IMPORTANT NOTICE: The contents of this email and any attachments are c= onfidential and may also be privileged. If you are not the intended recipie= nt, please notify the sender immediately and do not disclose the contents t= o any other person, use it for any purpose, or store or copy the informatio= n in any medium. Thank you.

IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you.
--000000000000f920a205e3b8eff2-- From xen-devel-bounces@lists.xenproject.org Thu Jul 14 02:49:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 02:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367017.598045 (Exim 4.92) (envelope-from ) id 1oBoux-0002ar-B4; Thu, 14 Jul 2022 02:49:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367017.598045; Thu, 14 Jul 2022 02:49:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBoux-0002aj-5o; Thu, 14 Jul 2022 02:49:31 +0000 Received: by outflank-mailman (input) for mailman id 367017; Thu, 14 Jul 2022 02:49:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBouw-0002aZ-7j; Thu, 14 Jul 2022 02:49:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBouw-0000wy-57; Thu, 14 Jul 2022 02:49:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBouv-0005tu-Pc; Thu, 14 Jul 2022 02:49:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBouv-0002EY-P9; Thu, 14 Jul 2022 02:49:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=exVHcLxmE0oaISs0e0evbiLTsecgxECxrydW8jUymnY=; b=x45dqy/G4YPkw8wZbcZvOG7mZn Jalt6N68CFnCOU71OB4LbN92rOuodJ7WlRgsIdv04XgB/DwxkY7ggOHrgZPEGSsU5v/54BU6MyZzt eUOO4OzI5x+EuW85sXKgV2smrLiaf9o0z3OEr8RPki1ZfMRw4VJbylfFZwLUFjws3vGo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171613: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start.2:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82 X-Osstest-Versions-That: qemuu=9548cbeffffd4253e38570d29b8cff0bf77c998f From: osstest service owner Date: Thu, 14 Jul 2022 02:49:29 +0000 flight 171613 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171613/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qcow2 22 guest-start.2 fail blocked in 171597 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171597 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171597 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171597 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171597 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171597 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171597 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171597 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171597 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82 baseline version: qemuu 9548cbeffffd4253e38570d29b8cff0bf77c998f Last test of basis 171597 2022-07-12 13:11:00 Z 1 days Testing same since 171613 2022-07-13 04:32:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Alexander Bulekov Marc-André Lureau Matheus Kowalczuk Ferst Mauro Matteo Cascella Miaoqian Lin Paolo Bonzini Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9548cbefff..8e3d85d36b 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 14 03:28:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 03:28:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367025.598056 (Exim 4.92) (envelope-from ) id 1oBpWZ-0007QV-6x; Thu, 14 Jul 2022 03:28:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367025.598056; Thu, 14 Jul 2022 03:28:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBpWZ-0007QO-3K; Thu, 14 Jul 2022 03:28:23 +0000 Received: by outflank-mailman (input) for mailman id 367025; Thu, 14 Jul 2022 03:28:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBpWY-0007QE-5h; Thu, 14 Jul 2022 03:28:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBpWY-0001c0-1U; Thu, 14 Jul 2022 03:28:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBpWX-0006ox-KU; Thu, 14 Jul 2022 03:28:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBpWX-00080X-K2; Thu, 14 Jul 2022 03:28:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NDUVmjuYT5UnqXHEE4zxjeHCkGx8VkMFEHcPeCXIdRo=; b=Gwm7frvY27Dp1J8KdevT/pu9IU siBAdAQJ1goFtXH0cHA0LqUgmW6nuTq6brTPn2CyfS1Ok9dOlsQSBvRJ70ddR+LKhLjHtSnQTSRgJ rW/vsNoIDa+KvjAhQybSwNCrELlFDVsEweoYuqeLC9ZClZUdEZ12KtTBcSl6RD/BP4L8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171614: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:guest-start/debianhvm.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0ec831fa971d8099e3c4f46093ffb41d044cc10c X-Osstest-Versions-That: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 From: osstest service owner Date: Thu, 14 Jul 2022 03:28:21 +0000 flight 171614 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171614/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171548 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-xsm 8 xen-boot fail in 171600 pass in 171614 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 18 guest-start/debianhvm.repeat fail in 171600 pass in 171614 test-armhf-armhf-libvirt 8 xen-boot fail pass in 171600 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171548 test-armhf-armhf-xl-credit2 14 guest-start fail in 171600 like 171548 test-armhf-armhf-libvirt 16 saverestore-support-check fail in 171600 like 171548 test-armhf-armhf-libvirt 15 migrate-support-check fail in 171600 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 0ec831fa971d8099e3c4f46093ffb41d044cc10c baseline version: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 Last test of basis 171548 2022-07-07 15:41:19 Z 6 days Testing same since 171600 2022-07-12 14:42:51 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Christoph Lameter Claudiu Beznea Darrick J. Wong David Rientjes David S. Miller Dmitry Osipenko Duoming Zhou Eric Sandeen Florian Fainelli Greg Kroah-Hartman Guenter Roeck Guiling Deng Helge Deller Hsin-Yi Wang Hyeonggon Yoo <42.hyeyoo@gmail.com> Ido Schimmel Jacob Pan Jakub Kicinski Jann Horn Jason A. Donenfeld Jernej Skrabec Jimmy Assarsson Joerg Roedel Jon Hunter Kuniyuki Iwashima Lars-Peter Clausen Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marc Kleine-Budde Miaoqian Lin Michael Ellerman Michael Walle Neil Armstrong Nick Child Oliver Hartkopp Oliver Neukum Paolo Abeni Peter Robinson Peter Ujfalusi Rhett Aultman Rick Lindsley Sabrina Dubroca Sachin Sant Samuel Holland Sasha Levin Satish Nagireddy Shuah Khan Steffen Klassert Vinod Koul Vladimir Oltean Vlastimil Babka Wolfram Sang Yian Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1026 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 04:23:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 04:23:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367034.598067 (Exim 4.92) (envelope-from ) id 1oBqO5-00061P-EV; Thu, 14 Jul 2022 04:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367034.598067; Thu, 14 Jul 2022 04:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqO5-00061I-BN; Thu, 14 Jul 2022 04:23:41 +0000 Received: by outflank-mailman (input) for mailman id 367034; Thu, 14 Jul 2022 04:23:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqO3-00061C-9p for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 04:23:39 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9ff4dce-032c-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 06:23:37 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A7C5761E17; Thu, 14 Jul 2022 04:23:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2CE62C34114; Thu, 14 Jul 2022 04:23:32 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9ff4dce-032c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657772614; bh=J6mQcvC53lBuEVQf65dBBXN3IvFoM94h34szXqWSThQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k3i2Un4GLreSEo1+VkGbpqoeS6wAYqATuUIn88w7Uodjc/p3oi6431Xg+g/oljAeh K3ybYB6Q4Q87A/lD7SBI3p2MbadnKVIBRckiitUdkUdPydBNBIJmnSrzpfX/Wi5S5g XtH4ebpA0+BUQuobX4/Smn23cNFtY4SgQyrpzCoVz2pKErgpRFivjriRMYJL0Kd5qZ SH0XIWEDW8aFTGMdTyV9hjDHkmd7grj2UzNucKB+0Aj9OuytuijA7RPmc4xIfZ0t6W 0iI0S4KJeEBy2qmZ3h4FFmlSsHoPKOLQgiswk3Y8cl3jrXN17n07auyV8tzVxF/14M 6ogZ1VjMSKg1w== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Juergen Gross , Borislav Petkov , Jan Beulich , Boris Ostrovsky , Sasha Levin , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, jpoimboe@kernel.org, peterz@infradead.org, michael.roth@amd.com, brijesh.singh@amd.com, kirill.shutemov@linux.intel.com, ak@linux.intel.com, thomas.lendacky@amd.com, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.18 28/41] x86/xen: Use clear_bss() for Xen PV guests Date: Thu, 14 Jul 2022 00:22:08 -0400 Message-Id: <20220714042221.281187-28-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220714042221.281187-1-sashal@kernel.org> References: <20220714042221.281187-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Juergen Gross [ Upstream commit 96e8fc5818686d4a1591bb6907e7fdb64ef29884 ] Instead of clearing the bss area in assembly code, use the clear_bss() function. This requires to pass the start_info address as parameter to xen_start_kernel() in order to avoid the xen_start_info being zeroed again. Signed-off-by: Juergen Gross Signed-off-by: Borislav Petkov Reviewed-by: Jan Beulich Reviewed-by: Boris Ostrovsky Link: https://lore.kernel.org/r/20220630071441.28576-2-jgross@suse.com Signed-off-by: Sasha Levin --- arch/x86/include/asm/setup.h | 3 +++ arch/x86/kernel/head64.c | 2 +- arch/x86/xen/enlighten_pv.c | 8 ++++++-- arch/x86/xen/xen-head.S | 10 +--------- 4 files changed, 11 insertions(+), 12 deletions(-) diff --git a/arch/x86/include/asm/setup.h b/arch/x86/include/asm/setup.h index 896e48d45828..bccc84de7ff2 100644 --- a/arch/x86/include/asm/setup.h +++ b/arch/x86/include/asm/setup.h @@ -132,6 +132,9 @@ void *extend_brk(size_t size, size_t align); } extern void probe_roms(void); + +void clear_bss(void); + #ifdef __i386__ asmlinkage void __init i386_start_kernel(void); diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c index 4f5ecbbaae77..2e10a33778cf 100644 --- a/arch/x86/kernel/head64.c +++ b/arch/x86/kernel/head64.c @@ -421,7 +421,7 @@ void __init do_early_exception(struct pt_regs *regs, int trapnr) /* Don't add a printk in there. printk relies on the PDA which is not initialized yet. */ -static void __init clear_bss(void) +void __init clear_bss(void) { memset(__bss_start, 0, (unsigned long) __bss_stop - (unsigned long) __bss_start); diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 5038edb79ad5..b55de4ad685c 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -1183,15 +1183,19 @@ static void __init xen_domu_set_legacy_features(void) extern void early_xen_iret_patch(void); /* First C function to be called on Xen boot */ -asmlinkage __visible void __init xen_start_kernel(void) +asmlinkage __visible void __init xen_start_kernel(struct start_info *si) { struct physdev_set_iopl set_iopl; unsigned long initrd_start = 0; int rc; - if (!xen_start_info) + if (!si) return; + clear_bss(); + + xen_start_info = si; + __text_gen_insn(&early_xen_iret_patch, JMP32_INSN_OPCODE, &early_xen_iret_patch, &xen_iret, JMP32_INSN_SIZE); diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index 3a2cd93bf059..13af6fe453e3 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -48,15 +48,6 @@ SYM_CODE_START(startup_xen) ANNOTATE_NOENDBR cld - /* Clear .bss */ - xor %eax,%eax - mov $__bss_start, %rdi - mov $__bss_stop, %rcx - sub %rdi, %rcx - shr $3, %rcx - rep stosq - - mov %rsi, xen_start_info mov initial_stack(%rip), %rsp /* Set up %gs. @@ -71,6 +62,7 @@ SYM_CODE_START(startup_xen) cdq wrmsr + mov %rsi, %rdi call xen_start_kernel SYM_CODE_END(startup_xen) __FINIT -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 04:33:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 04:33:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367040.598077 (Exim 4.92) (envelope-from ) id 1oBqXF-0007eL-AK; Thu, 14 Jul 2022 04:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367040.598077; Thu, 14 Jul 2022 04:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqXF-0007eE-7P; Thu, 14 Jul 2022 04:33:09 +0000 Received: by outflank-mailman (input) for mailman id 367040; Thu, 14 Jul 2022 04:33:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqXE-0007e4-ON; Thu, 14 Jul 2022 04:33:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqXE-0002s5-KL; Thu, 14 Jul 2022 04:33:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBqXE-0002Fp-67; Thu, 14 Jul 2022 04:33:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBqXE-0007IZ-5j; Thu, 14 Jul 2022 04:33:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MW8/aYgQQJ8XWk92SVIjQeBw9P8FKTJ6uIWZVbDqHZY=; b=1rlK5Ae3nUdu8tvbbMAK/5xM5a xIWEvyDjnj5q2PqowgSMTxc6HqA7nTz3ykAlH6dgB9C+2Y4tMsom7DFtAnQ8jmS8tLcI7+1g1b0Pj YfxueQp5YzRj5hEoDY92QocHl/jC/I7ZpL1c5Tl/Bw4uMiehvWjsJGFkbdi+VYKOGHuw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171616: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-multivcpu:xen-boot:fail:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=b047602d579b4fb028128a525f056bbdc890e7f0 X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Thu, 14 Jul 2022 04:33:08 +0000 flight 171616 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171616/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 8 xen-boot fail REGR. vs. 171587 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 171587 build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux b047602d579b4fb028128a525f056bbdc890e7f0 baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 2 days Failing since 171601 2022-07-12 16:11:30 Z 1 days 2 attempts Testing same since 171616 2022-07-13 07:12:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alexandre Chartre Alyssa Rosenzweig Andrew Cooper Borislav Petkov Christian Brauner (Microsoft) Christian Brauner Christian König Daniele Ceraolo Spurio Dave Airlie Dave Hansen Dmitry Osipenko Douglas Anderson Evan Quan Ezequiel Garcia Hangyu Hua Hans de Goede Heiko Stuebner Javier Martinez Canillas Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Kim Phillips Konrad Rzeszutek Wilk Li kunyu Linus Torvalds Liu Ying Masami Hiramatsu (Google) Maxime Ripard Miklos Szeredi Neil Armstrong Nick Desaulniers Nirmoy Das Pawan Gupta Peter Zijlstra (Intel) Peter Zijlstra Rodrigo Vivi Sascha Hauer Steven Price Steven Rostedt (Google) sunliming Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Zimmermann Tiezhu Yang xinhui pan Zheng Yejian jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2125 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 05:31:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 05:31:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367050.598089 (Exim 4.92) (envelope-from ) id 1oBrRR-0006We-M4; Thu, 14 Jul 2022 05:31:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367050.598089; Thu, 14 Jul 2022 05:31:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBrRR-0006WX-Hl; Thu, 14 Jul 2022 05:31:13 +0000 Received: by outflank-mailman (input) for mailman id 367050; Thu, 14 Jul 2022 05:31:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBrRQ-0006WR-15 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 05:31:12 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 289606e1-0336-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 07:31:06 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1oBrR1-0001Nh-2x; Thu, 14 Jul 2022 07:30:47 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 289606e1-0336-11ed-924f-1f966e50362f Message-ID: <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> Date: Thu, 14 Jul 2022 07:30:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Thorsten Leemhuis In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1657776666;7d8d67c6; X-HE-SMSGID: 1oBrR1-0001Nh-2x On 13.07.22 03:36, Chuck Zmudzinski wrote: > The commit 99c13b8c8896d7bcb92753bf > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > incorrectly failed to account for the case in init_cache_modes() when > CPUs do support PAT and falsely reported PAT to be disabled when in > fact PAT is enabled. In some environments, notably in Xen PV domains, > MTRR is disabled but PAT is still enabled, and that is the case > that the aforementioned commit failed to account for. > > As an unfortunate consequnce, the pat_enabled() function currently does > not correctly report that PAT is enabled in such environments. The fix > is implemented in init_cache_modes() by setting pat_bp_enabled to true > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > to account for. > > This approach arranges for pat_enabled() to return true in the Xen PV > environment without undermining the rest of PAT MSR management logic > that considers PAT to be disabled: Specifically, no writes to the PAT > MSR should occur. > > This patch fixes a regression that some users are experiencing with > Linux as a Xen Dom0 driving particular Intel graphics devices by > correctly reporting to the Intel i915 driver that PAT is enabled where > previously it was falsely reporting that PAT is disabled. Some users > are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > Dom0 are experiencing reduced graphics performance because the keying of > the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > means that in particular graphics frame buffer accesses are quite a bit > less performant than possible without this patch. > > Also, with the current code, in the Xen PV environment, PAT will not be > disabled if the administrator sets the "nopat" boot option. Introduce > a new boolean variable, pat_force_disable, to forcibly disable PAT > when the administrator sets the "nopat" option to override the default > behavior of using the PAT configuration that Xen has provided. > > For the new boolean to live in .init.data, init_cache_modes() also needs > moving to .init.text (where it could/should have lived already before). > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") BTW, "submitting-patches.rst" says it should just be "the first 12 characters of the SHA-1 ID" > Co-developed-by: Jan Beulich > Cc: stable@vger.kernel.org > Signed-off-by: Chuck Zmudzinski Sorry, have to ask: is this supposed to finally fix this regression? https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ If yes, please include Link: and Reported-by: tags, as explained in submitting-patches.rst (I only care about the link tag, as I'm tacking that regression). Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Thu Jul 14 05:41:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 05:41:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367058.598100 (Exim 4.92) (envelope-from ) id 1oBraw-0008E3-Oa; Thu, 14 Jul 2022 05:41:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367058.598100; Thu, 14 Jul 2022 05:41:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBraw-0008Dw-K5; Thu, 14 Jul 2022 05:41:02 +0000 Received: by outflank-mailman (input) for mailman id 367058; Thu, 14 Jul 2022 05:41:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBrau-0008Dq-S4 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 05:41:00 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [2001:67c:2178:6::1d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a03cdf5-0337-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 07:40:59 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C40C020747; Thu, 14 Jul 2022 05:40:58 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 162ED13322; Thu, 14 Jul 2022 05:40:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /vQUBGqsz2IyGAAAMHmgww (envelope-from ); Thu, 14 Jul 2022 05:40:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a03cdf5-0337-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657777258; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kAq092ltVUBWQNZDOKFuQWJGrOCULwke+LSsN6A0008=; b=BDxnnTYbDliTqNPAGxJQcmtxtJ91yE0YnzjLc9B4LPSp+yOaVw58c5xY0AwVhjk7TCSeZ/ POtVRR5WxAT7yTr8kpZwb9Loh537jTwlylrnmDDpK0XUszumlrUqvMUwE9ckLOOK0VcEEI 5dGBI2yYwoSww+tvYCNP7YVyp9dPy1M= Message-ID: Date: Thu, 14 Jul 2022 07:40:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Juergen Gross Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------p9W413CsZm9DGQsW6OKQfOn1" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------p9W413CsZm9DGQsW6OKQfOn1 Content-Type: multipart/mixed; boundary="------------qMuRanS00Ra20EBwdeSS8owL"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> --------------qMuRanS00Ra20EBwdeSS8owL Content-Type: multipart/mixed; boundary="------------b1Xo8o7Ir2db0LhahKG1l0Lz" --------------b1Xo8o7Ir2db0LhahKG1l0Lz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTMuMDcuMjIgMDM6MzYsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IFRoZSBjb21t aXQgOTljMTNiOGM4ODk2ZDdiY2I5Mjc1M2JmDQo+ICgieDg2L21tL3BhdDogRG9uJ3QgcmVw b3J0IFBBVCBvbiBDUFVzIHRoYXQgZG9uJ3Qgc3VwcG9ydCBpdCIpDQo+IGluY29ycmVjdGx5 IGZhaWxlZCB0byBhY2NvdW50IGZvciB0aGUgY2FzZSBpbiBpbml0X2NhY2hlX21vZGVzKCkg d2hlbg0KPiBDUFVzIGRvIHN1cHBvcnQgUEFUIGFuZCBmYWxzZWx5IHJlcG9ydGVkIFBBVCB0 byBiZSBkaXNhYmxlZCB3aGVuIGluDQo+IGZhY3QgUEFUIGlzIGVuYWJsZWQuIEluIHNvbWUg ZW52aXJvbm1lbnRzLCBub3RhYmx5IGluIFhlbiBQViBkb21haW5zLA0KPiBNVFJSIGlzIGRp c2FibGVkIGJ1dCBQQVQgaXMgc3RpbGwgZW5hYmxlZCwgYW5kIHRoYXQgaXMgdGhlIGNhc2UN Cj4gdGhhdCB0aGUgYWZvcmVtZW50aW9uZWQgY29tbWl0IGZhaWxlZCB0byBhY2NvdW50IGZv ci4NCj4gDQo+IEFzIGFuIHVuZm9ydHVuYXRlIGNvbnNlcXVuY2UsIHRoZSBwYXRfZW5hYmxl ZCgpIGZ1bmN0aW9uIGN1cnJlbnRseSBkb2VzDQo+IG5vdCBjb3JyZWN0bHkgcmVwb3J0IHRo YXQgUEFUIGlzIGVuYWJsZWQgaW4gc3VjaCBlbnZpcm9ubWVudHMuIFRoZSBmaXgNCj4gaXMg aW1wbGVtZW50ZWQgaW4gaW5pdF9jYWNoZV9tb2RlcygpIGJ5IHNldHRpbmcgcGF0X2JwX2Vu YWJsZWQgdG8gdHJ1ZQ0KPiBpbiBpbml0X2NhY2hlX21vZGVzKCkgZm9yIHRoZSBjYXNlIHRo YXQgY29tbWl0IDk5YzEzYjhjODg5NmQ3YmNiOTI3NTNiZg0KPiAoIng4Ni9tbS9wYXQ6IERv bid0IHJlcG9ydCBQQVQgb24gQ1BVcyB0aGF0IGRvbid0IHN1cHBvcnQgaXQiKSBmYWlsZWQN Cj4gdG8gYWNjb3VudCBmb3IuDQo+IA0KPiBUaGlzIGFwcHJvYWNoIGFycmFuZ2VzIGZvciBw YXRfZW5hYmxlZCgpIHRvIHJldHVybiB0cnVlIGluIHRoZSBYZW4gUFYNCj4gZW52aXJvbm1l bnQgd2l0aG91dCB1bmRlcm1pbmluZyB0aGUgcmVzdCBvZiBQQVQgTVNSIG1hbmFnZW1lbnQg bG9naWMNCj4gdGhhdCBjb25zaWRlcnMgUEFUIHRvIGJlIGRpc2FibGVkOiBTcGVjaWZpY2Fs bHksIG5vIHdyaXRlcyB0byB0aGUgUEFUDQo+IE1TUiBzaG91bGQgb2NjdXIuDQo+IA0KPiBU aGlzIHBhdGNoIGZpeGVzIGEgcmVncmVzc2lvbiB0aGF0IHNvbWUgdXNlcnMgYXJlIGV4cGVy aWVuY2luZyB3aXRoDQo+IExpbnV4IGFzIGEgWGVuIERvbTAgZHJpdmluZyBwYXJ0aWN1bGFy IEludGVsIGdyYXBoaWNzIGRldmljZXMgYnkNCj4gY29ycmVjdGx5IHJlcG9ydGluZyB0byB0 aGUgSW50ZWwgaTkxNSBkcml2ZXIgdGhhdCBQQVQgaXMgZW5hYmxlZCB3aGVyZQ0KPiBwcmV2 aW91c2x5IGl0IHdhcyBmYWxzZWx5IHJlcG9ydGluZyB0aGF0IFBBVCBpcyBkaXNhYmxlZC4g U29tZSB1c2Vycw0KPiBhcmUgZXhwZXJpZW5jaW5nIHN5c3RlbSBoYW5ncyBpbiBYZW4gUFYg RG9tMCBhbmQgYWxsIHVzZXJzIG9uIFhlbiBQVg0KPiBEb20wIGFyZSBleHBlcmllbmNpbmcg cmVkdWNlZCBncmFwaGljcyBwZXJmb3JtYW5jZSBiZWNhdXNlIHRoZSBrZXlpbmcgb2YNCj4g dGhlIHVzZSBvZiBXQyBtYXBwaW5ncyB0byBwYXRfZW5hYmxlZCgpIChzZWUgYXJjaF9jYW5f cGNpX21tYXBfd2MoKSkNCj4gbWVhbnMgdGhhdCBpbiBwYXJ0aWN1bGFyIGdyYXBoaWNzIGZy YW1lIGJ1ZmZlciBhY2Nlc3NlcyBhcmUgcXVpdGUgYSBiaXQNCj4gbGVzcyBwZXJmb3JtYW50 IHRoYW4gcG9zc2libGUgd2l0aG91dCB0aGlzIHBhdGNoLg0KPiANCj4gQWxzbywgd2l0aCB0 aGUgY3VycmVudCBjb2RlLCBpbiB0aGUgWGVuIFBWIGVudmlyb25tZW50LCBQQVQgd2lsbCBu b3QgYmUNCj4gZGlzYWJsZWQgaWYgdGhlIGFkbWluaXN0cmF0b3Igc2V0cyB0aGUgIm5vcGF0 IiBib290IG9wdGlvbi4gSW50cm9kdWNlDQo+IGEgbmV3IGJvb2xlYW4gdmFyaWFibGUsIHBh dF9mb3JjZV9kaXNhYmxlLCB0byBmb3JjaWJseSBkaXNhYmxlIFBBVA0KPiB3aGVuIHRoZSBh ZG1pbmlzdHJhdG9yIHNldHMgdGhlICJub3BhdCIgb3B0aW9uIHRvIG92ZXJyaWRlIHRoZSBk ZWZhdWx0DQo+IGJlaGF2aW9yIG9mIHVzaW5nIHRoZSBQQVQgY29uZmlndXJhdGlvbiB0aGF0 IFhlbiBoYXMgcHJvdmlkZWQuDQo+IA0KPiBGb3IgdGhlIG5ldyBib29sZWFuIHRvIGxpdmUg aW4gLmluaXQuZGF0YSwgaW5pdF9jYWNoZV9tb2RlcygpIGFsc28gbmVlZHMNCj4gbW92aW5n IHRvIC5pbml0LnRleHQgKHdoZXJlIGl0IGNvdWxkL3Nob3VsZCBoYXZlIGxpdmVkIGFscmVh ZHkgYmVmb3JlKS4NCj4gDQo+IEZpeGVzOiA5OWMxM2I4Yzg4OTZkN2JjYjkyNzUzYmYgKCJ4 ODYvbW0vcGF0OiBEb24ndCByZXBvcnQgUEFUIG9uIENQVXMgdGhhdCBkb24ndCBzdXBwb3J0 IGl0IikNCj4gQ28tZGV2ZWxvcGVkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+DQo+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+IFNpZ25lZC1vZmYtYnk6IENo dWNrIFptdWR6aW5za2kgPGJyY2h1Y2t6QGFvbC5jb20+DQo+IC0tLQ0KPiB2MjogKkFkZCBm b3JjZV9wYXRfZGlzYWJsZWQgdmFyaWFibGUgdG8gZml4ICJub3BhdCIgb24gWGVuIFBWIChK YW4gQmV1bGljaCkNCj4gICAgICAqQWRkIHRoZSBuZWNlc3NhcnkgY29kZSB0byBpbmNvcnBv cmF0ZSB0aGUgIm5vcGF0IiBmaXgNCj4gICAgICAqdm9pZCBpbml0X2NhY2hlX21vZGVzKHZv aWQpIC0+IHZvaWQgX19pbml0IGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4gICAgICAqQWRk IEphbiBCZXVsaWNoIGFzIENvLWRldmVsb3BlciAoSmFuIGhhcyBub3Qgc2lnbmVkIG9mZiB5 ZXQpDQo+ICAgICAgKkV4cGFuZCB0aGUgY29tbWl0IG1lc3NhZ2UgdG8gaW5jbHVkZSByZWxl dmFudCBwYXJ0cyBvZiB0aGUgY29tbWl0DQo+ICAgICAgIG1lc3NhZ2Ugb2YgSmFuIEJldWxp Y2gncyBwcm9wb3NlZCBwYXRjaCBmb3IgdGhpcyBwcm9ibGVtDQo+ICAgICAgKkZpeCAnZWxz ZSBpZiAuLi4geycgcGxhY2VtZW50IGFuZCBpbmRlbnRhdGlvbg0KPiAgICAgICpSZW1vdmUg aW5kaWNhdGlvbiB0aGUgYmFja3BvcnQgdG8gc3RhYmxlIGJyYW5jaGVzIGlzIG9ubHkgYmFj ayB0byA1LjE3LnkNCj4gDQo+IEkgdGhpbmsgdGhlc2UgY2hhbmdlcyBhZGRyZXNzIGFsbCB0 aGUgY29tbWVudHMgb24gdGhlIG9yaWdpbmFsIHBhdGNoDQo+IA0KPiBJIGFkZGVkIEphbiBC ZXVsaWNoIGFzIGEgQ28tZGV2ZWxvcGVyIGJlY2F1c2UgSnVlcmdlbiBHcm9zcyBhc2tlZCBt ZSB0bw0KPiBpbmNsdWRlIEphbidzIGlkZWEgZm9yIGZpeGluZyAibm9wYXQiIHRoYXQgd2Fz IG1pc3NpbmcgZnJvbSB0aGUgZmlyc3QNCj4gdmVyc2lvbiBvZiB0aGUgcGF0Y2guDQo+IA0K PiBUaGUgcGF0Y2ggaGFzIGJlZW4gdGVzdGVkLCBpdCB3b3JrcyBhcyBleHBlY3RlZCB3aXRo IGFuZCB3aXRob3V0IG5vcGF0DQo+IGluIHRoZSBYZW4gUFYgRG9tMCBlbnZpcm9ubWVudC4g VGhhdCBpcywgIm5vcGF0IiBjYXVzZXMgdGhlIHN5c3RlbSB0bw0KPiBleGhpYml0IHRoZSBl ZmZlY3RzIGFuZCBwcm9ibGVtcyB0aGF0IGxhY2sgb2YgUEFUIHN1cHBvcnQgY2F1c2VzLg0K PiANCj4gICBhcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5jIHwgMTYgKysrKysrKysrKysrKyst LQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygt KQ0KPiANCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L21tL3BhdC9tZW10eXBlLmMgYi9hcmNo L3g4Ni9tbS9wYXQvbWVtdHlwZS5jDQo+IGluZGV4IGQ1ZWY2NGRkZDM1ZS4uMTBhMzdkMzA5 ZDIzIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5jDQo+ICsrKyBi L2FyY2gveDg2L21tL3BhdC9tZW10eXBlLmMNCj4gQEAgLTYyLDYgKzYyLDcgQEANCj4gICAN Cj4gICBzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IHBhdF9icF9pbml0aWFsaXplZDsNCj4g ICBzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IHBhdF9kaXNhYmxlZCA9ICFJU19FTkFCTEVE KENPTkZJR19YODZfUEFUKTsNCj4gK3N0YXRpYyBib29sIF9faW5pdGRhdGEgcGF0X2ZvcmNl X2Rpc2FibGVkID0gIUlTX0VOQUJMRUQoQ09ORklHX1g4Nl9QQVQpOw0KPiAgIHN0YXRpYyBi b29sIF9fcmVhZF9tb3N0bHkgcGF0X2JwX2VuYWJsZWQ7DQo+ICAgc3RhdGljIGJvb2wgX19y ZWFkX21vc3RseSBwYXRfY21faW5pdGlhbGl6ZWQ7DQo+ICAgDQo+IEBAIC04Niw2ICs4Nyw3 IEBAIHZvaWQgcGF0X2Rpc2FibGUoY29uc3QgY2hhciAqbXNnX3JlYXNvbikNCj4gICBzdGF0 aWMgaW50IF9faW5pdCBub3BhdChjaGFyICpzdHIpDQo+ICAgew0KPiAgIAlwYXRfZGlzYWJs ZSgiUEFUIHN1cHBvcnQgZGlzYWJsZWQgdmlhIGJvb3Qgb3B0aW9uLiIpOw0KPiArCXBhdF9m b3JjZV9kaXNhYmxlZCA9IHRydWU7DQo+ICAgCXJldHVybiAwOw0KPiAgIH0NCj4gICBlYXJs eV9wYXJhbSgibm9wYXQiLCBub3BhdCk7DQo+IEBAIC0yNzIsNyArMjc0LDcgQEAgc3RhdGlj IHZvaWQgcGF0X2FwX2luaXQodTY0IHBhdCkNCj4gICAJd3Jtc3JsKE1TUl9JQTMyX0NSX1BB VCwgcGF0KTsNCj4gICB9DQo+ICAgDQo+IC12b2lkIGluaXRfY2FjaGVfbW9kZXModm9pZCkN Cj4gK3ZvaWQgX19pbml0IGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4gICB7DQo+ICAgCXU2 NCBwYXQgPSAwOw0KPiAgIA0KPiBAQCAtMjkyLDcgKzI5NCw3IEBAIHZvaWQgaW5pdF9jYWNo ZV9tb2Rlcyh2b2lkKQ0KPiAgIAkJcmRtc3JsKE1TUl9JQTMyX0NSX1BBVCwgcGF0KTsNCj4g ICAJfQ0KPiAgIA0KPiAtCWlmICghcGF0KSB7DQo+ICsJaWYgKCFwYXQgfHwgcGF0X2ZvcmNl X2Rpc2FibGVkKSB7DQoNCkNhbiB3ZSBqdXN0IHJlbW92ZSB0aGlzIG1vZGlmaWNhdGlvbiBh bmQgLi4uDQoNCj4gICAJCS8qDQo+ICAgCQkgKiBObyBQQVQuIEVtdWxhdGUgdGhlIFBBVCB0 YWJsZSB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSB0d28NCj4gICAJCSAqIGNhY2hlIGJpdHMs IFBXVCAoV3JpdGUgVGhyb3VnaCkgYW5kIFBDRCAoQ2FjaGUgRGlzYWJsZSkuDQo+IEBAIC0z MTMsNiArMzE1LDE2IEBAIHZvaWQgaW5pdF9jYWNoZV9tb2Rlcyh2b2lkKQ0KPiAgIAkJICov DQo+ICAgCQlwYXQgPSBQQVQoMCwgV0IpIHwgUEFUKDEsIFdUKSB8IFBBVCgyLCBVQ19NSU5V UykgfCBQQVQoMywgVUMpIHwNCj4gICAJCSAgICAgIFBBVCg0LCBXQikgfCBQQVQoNSwgV1Qp IHwgUEFUKDYsIFVDX01JTlVTKSB8IFBBVCg3LCBVQyk7DQo+ICsJfSBlbHNlIGlmICghcGF0 X2JwX2VuYWJsZWQpIHsNCg0KLi4uIHVzZQ0KDQorCX0gZWxzZSBpZiAoIXBhdF9icF9lbmFi bGVkICYmICFwYXRfZm9yY2VfZGlzYWJsZWQpIHsNCg0KaGVyZT8NCg0KVGhpcyB3aWxsIHJl c3VsdCBpbiB0aGUgZGVzaXJlZCBvdXRjb21lIGluIGFsbCBjYXNlcyBJTU86IElmIFBBVCB3 YXNuJ3QNCmRpc2FibGVkIHZpYSAibm9wYXQiIGFuZCB0aGUgUEFUIE1TUiBoYXMgYSBub24t emVybyB2YWx1ZSAoZnJvbSBCSU9TIG9yDQpIeXBlcnZpc29yKSBhbmQgUEFUIGhhcyBiZWVu IGRpc2FibGVkIGltcGxpY2l0bHkgKGUuZy4gZHVlIHRvIGxhY2sgb2YNCk1UUlIpLCB0aGVu IFBBVCB3aWxsIGJlIHNldCB0byAiZW5hYmxlZCIgYWdhaW4uDQoNCj4gKwkJLyoNCj4gKwkJ ICogSW4gc29tZSBlbnZpcm9ubWVudHMsIHNwZWNpZmljYWxseSBYZW4gUFYsIFBBVA0KPiAr CQkgKiBpbml0aWFsaXphdGlvbiBpcyBza2lwcGVkIGJlY2F1c2UgTVRSUnMgYXJlIGRpc2Fi bGVkIGV2ZW4NCj4gKwkJICogdGhvdWdoIFBBVCBpcyBhdmFpbGFibGUuIEluIHN1Y2ggZW52 aXJvbm1lbnRzLCBzZXQgUEFUIHRvDQo+ICsJCSAqIGVuYWJsZWQgdG8gY29ycmVjdGx5IGlu ZGljYXRlIHRvIGNhbGxlcnMgb2YgcGF0X2VuYWJsZWQoKQ0KPiArCQkgKiB0aGF0IENQVSBz dXBwb3J0IGZvciBQQVQgaXMgYXZhaWxhYmxlLg0KPiArCQkgKi8NCj4gKwkJcGF0X2JwX2Vu YWJsZWQgPSB0cnVlOw0KPiArCQlwcl9pbmZvKCJ4ODYvUEFUOiBQQVQgZW5hYmxlZCBieSBp bml0X2NhY2hlX21vZGVzXG4iKTsNCj4gICAJfQ0KPiAgIA0KPiAgIAlfX2luaXRfY2FjaGVf bW9kZXMocGF0KTsNCg0KDQpKdWVyZ2VuDQo= --------------b1Xo8o7Ir2db0LhahKG1l0Lz Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------b1Xo8o7Ir2db0LhahKG1l0Lz-- --------------qMuRanS00Ra20EBwdeSS8owL-- --------------p9W413CsZm9DGQsW6OKQfOn1 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLPrGkFAwAAAAAACgkQsN6d1ii/Ey8r DAf/b61zHAl4g35QZy+u4+OHCls9BYx8Z5X9jhGw36lCViIhFKGxeCZrnO2Q2RTIKpYWXbi1IHqa PHZgz56Y1js1/NTD3rnXCR5kmUMpjyCEsiFNMnz9oUgRsL+IhhL62iYlBzeb5KBk/bWCapBfgb3F doIgbnBmnAjwU/UzDgHcddpRLaOq3InqeqoQzYPAyu02uJiJC0uL2muEU7ZEMatAt3fSfbYBiPgJ BmWwjFb5jPP9aELJ3zzbWo7CJU4cEpF6/eWj3cmSuK8sRvzFkzgS22WOGmrJVOZoj+/bAFS1QVlW TetCZVIRGKrru1QUJMHUpAryatfaDwxJi7ceFuptXg== =tp+D -----END PGP SIGNATURE----- --------------p9W413CsZm9DGQsW6OKQfOn1-- From xen-devel-bounces@lists.xenproject.org Thu Jul 14 06:05:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 06:05:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367063.598110 (Exim 4.92) (envelope-from ) id 1oBryk-0002cW-Kp; Thu, 14 Jul 2022 06:05:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367063.598110; Thu, 14 Jul 2022 06:05:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBryk-0002cP-IA; Thu, 14 Jul 2022 06:05:38 +0000 Received: by outflank-mailman (input) for mailman id 367063; Thu, 14 Jul 2022 06:05:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBryj-0002cJ-2S for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 06:05:37 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f90c8d66-033a-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 08:05:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8347.eurprd04.prod.outlook.com (2603:10a6:10:245::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 06:05:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 06:05:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f90c8d66-033a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYAIjuyLuEejay4mhMFDu3jYQ58gAtC0Qj7v4WYdclfli9YclGHNzNkKQeAB3TfNRLBHQrfR77Xbl99gKWsjrCifGzdmSz0rbvwYposownHMTOgw9B9O54CR+XfBvzB4jC66QlP4nrF9+GD/HdlSEkqHIWY8RK1mYBJoz+hqcXmO81s5N6Mp+DGNw4t5AYKHhXwtRGM53OpLN/u5RW+/Z3sdvKL/qwJwXvVGheHo4DJUArz+lhS2/c5Dkohy3Tt4tGxTCRphuUNpOHG5o/z4pbGEJPBuOmHfGJfhvpRD1VMMKyPcq4gBSP47VW8yhF2sKZ0UfQMDZlqYDhSUBkHJ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=24sQSeTVr8k/uNw9hI04MeMtAN4nyVGXxJrihRxWGkk=; b=Acv6/L4VA/DF3ihTpM6XDv7VIzPnHUmbrYgbIHdpXdOe99p77WuGA/Sd/c4zwVcArgoytDI+Smx8xak1vJRguYaYTjbRH805A5LDVxTWEtMV/4e7o7Hd/o/d6JMbWv1Y8k4k6vcICLTmszEmll6lYFYXLdEVnQkYa22VaIdN4jiBX7BYqFflybMMxaTRaVVkQSDZ73SBgKeTe1+1BzUcxTMWqKl33m8HKk5jn1MizRTHseNoaA+xQ2/Fk+hQsoPWDt0oh1mwpG2rzzynl9t3sU+KWXPAVClISxXT8882OS54kz8xC7zsTgElE2VQhu7TiCuD/tRcDZQUJAYPbvsXCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=24sQSeTVr8k/uNw9hI04MeMtAN4nyVGXxJrihRxWGkk=; b=Aew3WbasWLpNSs7FPakHTSBp49j7mmLU2WVgVZmdKk9t8sCFJoyCh7nHX0JAfLtVVBAjINvKOl6abaaIxyo0PhlTF4vFPDf14+PiX7DhFDsxi9mP1LL8LLYaTrHuS0ZMK0WJjeoQFlp3H4NbHsyHR58wd4WuTt66HMC0c0RegUfiYB6eZBw65ZrV3arlceHEV7IBQE+cmcP4cfvM2PXD7cZoXty/gGoqxPf6MuUBAUgLoB+1dprCX+8wZUhYWsEqtBqTamwx142Vqorf65iuwlraka/ub5fX78XW+8sTFFmdlKWpunNNuEcBP9CIdPXArZIBgTHVuZQ/QxkO7zNlBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 08:05:28 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Connor Davis References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dbcd722d-9453-4810-c8ce-08da655edb7f X-MS-TrafficTypeDiagnostic: DB9PR04MB8347:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +YbIBLkcKQ9BS4/SzyFSKf/BHMS6gMcMNCeBXKMzZXhGa7fI5O8zM+T0+LY8kOT70+ciE8krpZOIye5z5mkJyaUHc/oINkpvpVyg+JMWa6RymqlGAxjMekaxnHRIH8xnh/1P5b6id9P5VrYs7+mzkLzvX3o6OJB/mNRjOI1GMKCxCnQVQYTKbaYi5Pn4LaPAsJIAIQVf94mtOQYSI0KLCdsvtI1wTQnSwCDn29F3t2Q2ZU5v1gcwiq006ylbYncyobSOIBOIvh9FV1uAr6f+lZEKoVIRaiLz6N5DB1H26XRH1ZskttmoK2YQqdzIfaxjntxwilM6PgUMxxuvd2TIY861QkN+ReyyR2x4o/FW0ow7x6UXjlc8fDAh9sYjahsg0u27ykIRfaS8gb/kiqSDxsDfmmDL+5ZRwm4iKMRVPcxZDeB10mqh1OXhlwHW4LY0pUtUy1IHuxiQEcSdoZRrXg1Rw71hmrSGPqEPKMS798yY8ngqPakkhISVTKq7VUfm2k7vWA/0QhLiU//9QsPgVViz369lgH9Nf+O0OsdOY5cJdiODjvI8ZbEqSq/lVPAtJJtRrioeqrWbnhlgsZbIqGBkPBwRHTAWd4bN4+fYb4MtWPvKv2uSXrhyYrRN+nuKs0uLugtXGMPGe/6mQYh7pG5MlkG+t9L3mnMR14lGst0QzNRha6Z447ehBT/eeiNLS/kh+Zs9OUNYvNa3L4Xhhyf3qDkBRWZ5ETd93tz1RqI9vfaaY8C0S7/KFKWqhF211oqcV3Hor+NPS3kW3Di3PQGcTX8sOfaZqEvSw0I2RSrh9dlb38QhXLV7V0PC1PQy0ff/J4JwGzAa151T+FOqIkhh24/nes8QVffGs2yk58k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(366004)(376002)(39860400002)(136003)(4326008)(26005)(5660300002)(6512007)(4744005)(8676002)(66946007)(66476007)(66556008)(478600001)(41300700001)(6666004)(8936002)(6486002)(316002)(31686004)(36756003)(186003)(31696002)(6506007)(54906003)(6916009)(53546011)(2616005)(2906002)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkFmN2EvS3gvSHFWNWhSTWJ0WXc3R1ZOQjIxSVZENUdiOFRXZXlYYnpmK21X?= =?utf-8?B?WkljZ2xOamVxbFh1U3YvUlRMQm9ZZW93WXlYR29rdmdjYVpHekxJMUdhZWYr?= =?utf-8?B?cEhXckJaajhidVErTVN6NjJydlBTK01IYUtQTzc3ZjBnUDR0NjdSS3UxWTRN?= =?utf-8?B?ODZxcXZQODJqTFFFK09pbGFJS215RW50OUVOVVByZ2tkdk43Ni94a2VNakRJ?= =?utf-8?B?c09ydmFScUdCNVFjU0J3R3ZLMHI1R1ovUlNkeGo0YW1YMFN3aFlOdFVvYzJv?= =?utf-8?B?eXdjUGtZaWFHUXdheDIySk5YbklRN0lXTURDTFBsaFZLc0RWQ1RyMWRnYmdH?= =?utf-8?B?OXJSUFRGVTF1c3ZxZEhtZEp0Sm9zRDZxalQ0VHRTRWtjNldaajhHZngza1A3?= =?utf-8?B?T2JWZ01LcWp4SjdlU0xqYlFVem5DTk9vTzhMbk9rajd2OXNhck54aW1Zc0lT?= =?utf-8?B?VWhqdEVqQVh1Nys5UkJ1K2p6UjkrcEVXWTVqbVU3Z2lsUEUxQkgvOGc1SHZ5?= =?utf-8?B?N3h5Z25WU1k0aCs1K096TzAvTU4zR0dBdFpKbjk1ZnRIOU52QnI3a25tU2pD?= =?utf-8?B?a2FoYkt3bzlBakZKOElDbzBEVitmWWdKbmZkL3JTY1QzS2EvdW9TdTlVallZ?= =?utf-8?B?eG42ZHEwMkUyZFVRdkNuSkthMnNEQjhoTlFJc2grcnNZQlo1YUdBbnZ2dm5Q?= =?utf-8?B?VXFYZ3dmeHFXeXBOdyt6WGt0TnN4eDUwQXBkRnIzRFBiYlVwSzlXT2RGMmQ5?= =?utf-8?B?UE9hbWRCeG1PeW52QnNDeHQxSkpGZEd0eDkxSU1HSzFpUUZjb1pua3ZodlBm?= =?utf-8?B?S2l3UnJPOHRTNmc3RDYyMzFndVJiVFRJTkNoQ3RIdkp0NTJEVm45K3hyQ1pq?= =?utf-8?B?VkVCdXBBVS9qUk8xaFdUem9TT1ZTd24zZHV5cmN3S0FMdXdRb2dHbGo5a0Yv?= =?utf-8?B?UkRBUFdFNnorMzZvSXNGOFdIekpDbVlEYi92Nlg4dGpGd1E5cFNROFZxQ2Jm?= =?utf-8?B?Nmt3OHpzRUxEakU3WUlzZml5ZHFQZ2JsVzR3MDdERFZ1M0c0WTFyeHJTM1ZH?= =?utf-8?B?Q1dPc0FxT0ZQbW55K2xIU3JrRUpIMFJFWlA5U05UdnIvTzhMdlRxbmpGeWVz?= =?utf-8?B?eTRkRzIwV28yTlNYQ25QelVzZnhGU0x3Mk5HdGZCK1lGS3lNOHpTMW9ON0h6?= =?utf-8?B?cmt6Tm8ySUczYWdac2NZdStuZktEYnRPczV4dzU1cjdlMUZBM0I3dlAzMTIx?= =?utf-8?B?U2tZTjR4bTYyRlU1dGY3UWRRRXF4RlhZc3VZelJrR3k3dHFMYTB3T2ppcnhI?= =?utf-8?B?QXJPSmxFRENhS3l1cnZ3aXl6RVBadWVacDNUTm1qdkhOZ1FWQUZRYXRBMlp1?= =?utf-8?B?VmQ1TW1xU2ZMdUM3QmRvaFBpa1pxTWhNRm9JQmtQYkVNdnBvZGpCWWk4UTZJ?= =?utf-8?B?akpxNVF6UWgzMk9kd3cxTDRmNmM0NHZYVmsxQldMQnR1bW9qZWc4cDBxcWRW?= =?utf-8?B?UjErMDE2MnRNaGVjZVFPY0hTVjB0Y3J1bkNYai8yM3BLN1NTVk9NNEs5YjRE?= =?utf-8?B?NVo3T3BEbmpNZG5ZZ1JqTzRjS0RkKzcvTlBUNjlCaUJ0dVlIVU1KMHVybGVC?= =?utf-8?B?S3BVbzY1VnRqaVNCTXNxc240b2NhRitPM0JNc3FzNjhxY1k3SHM1UG0xUVdK?= =?utf-8?B?a2tnM2w3WU42NTJ4NjNWQ0lNUyt3TWxwcnl5cFZHSll0cFN2K3RUNSs5dVpG?= =?utf-8?B?VkF4aFhWOTVZVjhaODl5NURjZUswV2E5Zy9rSnc4eDdUVVZWT2N1dlhsMGF2?= =?utf-8?B?QVltaERFQWQ1ajlHeG9NaG9RY25rQjc5L2NJcXI5V3ZpK1RsMHNGbzhYMG93?= =?utf-8?B?ang4WkhRMjNEVEg3d0tjSUlNKzZadFVkdHdyR0NFMWU3RE5UYkJ3a3FNRG1J?= =?utf-8?B?L0NITXd4dkFLM0pqMXM2MmhpR042RXJZVkRsRmdDbDhPODVSMjFXUlZhK0xY?= =?utf-8?B?Zk9TWXZsdjFqVnY3U3dzUStid1ZJUk1RVlFSWW1hRU1iQ29LME9QS1NCUHlO?= =?utf-8?B?UGRWNGI0Y25oZmUxK2ZETWR5a2tFQUVLWS9yblgwcEFRWkx6YTlQbG9iRzkv?= =?utf-8?Q?mM6YsRs2VVWCIPDbCp2X9yOjV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbcd722d-9453-4810-c8ce-08da655edb7f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:05:31.1981 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UufLYRvyTW9oIvloZo3QcKJ2yaq4GgxfHPdVp80Q7zqUTuDvYfysAlH61q6lFosEfl7EqF/+Px8OSR0yuHnzdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8347 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > +struct xue { > + struct xue_dbc_reg *dbc_reg; > + struct xue_dbc_ctx *dbc_ctx; > + struct xue_erst_segment *dbc_erst; > + struct xue_trb_ring dbc_ering; > + struct xue_trb_ring dbc_oring; > + struct xue_trb_ring dbc_iring; > + struct xue_work_ring dbc_owork; > + char *dbc_str; > + > + pci_sbdf_t sbdf; > + uint64_t xhc_mmio_phys; > + uint64_t xhc_mmio_size; > + uint64_t xhc_dbc_offset; One more observation: None of these four field look to be needed. They're all used only in a single function, so could be local variables there (and xhc_dbc_offset is only ever written, so could be dropped altogether). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 06:28:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 06:28:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367069.598122 (Exim 4.92) (envelope-from ) id 1oBsL7-0005Y7-GO; Thu, 14 Jul 2022 06:28:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367069.598122; Thu, 14 Jul 2022 06:28:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBsL7-0005Y0-De; Thu, 14 Jul 2022 06:28:45 +0000 Received: by outflank-mailman (input) for mailman id 367069; Thu, 14 Jul 2022 06:28:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBsL6-0005Xu-Ic for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 06:28:44 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2041.outbound.protection.outlook.com [40.107.21.41]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 34bea86d-033e-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 08:28:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8886.eurprd04.prod.outlook.com (2603:10a6:10:2e1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 06:28:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 06:28:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 34bea86d-033e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QqTqMTAFVOS6hELOasuAtCMQchggV2oG+GQ3DA59npH9S3NWZABjJULmcLN03J0VbyFCbFrEs6ywmFPfYTrYNfBvdWhGCEv4xDrk3JHviqSzIYYuvXbbBIOghWIjggqILRASOE6wh8BGcqa2PCfhP1vOgsCzbkz+Cr4nlmS7XAuCiaeVTdxqHsBfL/WQG6uszaj1RcSSgx+36NjgmAC0anPZzss8ttKq5NYW3SYQLqcwaXF1Hl+3OnmEOBtypzBMPSrKjrYDx2aQ9PCTOTC9tvmPbYszL4KwRy6h8GGrEfVGdjoyV9vOc9NccTNtwlkmw4fdoglztKd/hiV59gAAIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oFcPL/umJ+5KuC79w/CHfNJulm3P2EJlDY+FDAewpq0=; b=dxsPRA72J3RfPqWljx0tqjPV2SnmQteChvkV+9aMGI3Iq9EpSXhibRuXbZyI47QB4bL2gq3+lk3Wbt53eqF+FIoEvuqn3NbqQkb3JXEBMP1L5uyWmyhUNigguIJNjCLKzdVyDNQlIC4QghSPpCiTJs+mpS3GS1tObZUrVtPc3FmceqT+ml/cRLzALW5HB6paFq4801kLV0j5xr5RGNm1724jxPg5jg8Ft+BuItUOCsTcO4/0yYNwKjH3vu8vvQCOK04nI+8TErktnLgIy551kfbyc/YxGDWrdxWD3RrwoEZL/x5KYHinM7j3Ze7gWowBhPv0cknmYO/6GeMphhL3dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oFcPL/umJ+5KuC79w/CHfNJulm3P2EJlDY+FDAewpq0=; b=e1zpRprIVfpu1tHbrNsGB4l26KcpRtYbmgWcPeRnUV69vWNrc0TG2xd2uTRmwsHXAYyvnjG0XVFd4oj4NaOtSFzx5bPoVOYZ5J5Sdzo23iXHu8jjYfNpr9/GLujW7wJzMWN8+ORa0vPatAczdW/SWGl1kFZ/84S10/VbTTDBXrOvYuvcnCjiNTR6OG6j4Eg3ZUQZRWbxzNjcKGIgzLOBB5E0GWsIKMbYjgO8zvYm7g+YXk3EznjYvOKDxel86DZFBi2yGyj/TXRyu9DnpF5bDkRC0wL2ATf2xlE1dq+svzTr+NYTYXDF5ccqBKD0ubk6v8t4RZ1vPcUf+htKk9RU0g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <76b421cd-7a91-ebac-6f48-8a00eaf3c6f5@suse.com> Date: Thu, 14 Jul 2022 08:28:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Juergen Gross Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , xen-devel@lists.xenproject.org, Chuck Zmudzinski , linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0040.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 890d6b25-ecc9-4cfc-1720-08da656217f1 X-MS-TrafficTypeDiagnostic: DU2PR04MB8886:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xsijC1C5/aUsdXTY9sq5FG0lG4MSm/AnyXkF/LQslEiba4ExCq/GuZdGF4vUyo00eT5eFsbVpm4ZVKcfN+E21Aj+SR7pLqAk+nKFZ/M/li4tpiKWnQ2fMFL/tPdhKEtDJ+YtaIJ2LEMF6EbKEIHUHl3Awoi8eCBL2awkLDOpU5GaFEDP1WTeJUBrC9rJeUrg76AQD7bKja+g2M4oTHdDSjJoeTKu6hcJ6W7veO/8z3S7/r/6fQVGnCDP4shdKPiW8nPDJcabMqp4IHs/1VXd9VxPgfxixFjQureMx8/TXZWAiQipOX7JifibNPi+HcVLAS7sjnXSOLruROiOjYklKA0b25g6mXfdWztlEKpFOftur721LJ2klV62aZEPWQHqwrv5RWwfCtxWDnuHJbGahQidS1HVM4EmgWt8+dNDhWtaUbcKRAVlESD8fix1JzLBUUV7tsAp9D5DLILw1l5qAtSSCKI2Vf7ldAbxamuMvHhMLtzAzvze/igG8kUf4/ZgskN2NwioHob2NTDXK3M5aGuI2nxLmrlW7JhJN9upLE190UCq8xC9nJLBV6zQIKED2tPxHNItB99ZL+6o7qRIzGWhGffI/7bIhlIOQib9Pl5pXhnOTbWEFmVPd1hFPwgBYJIzyul8CAVEFwKCrbVzRAWzdDOAK9rvv8oeo6QZBuXkpgxvCUBwp7mMjhd7Jmsezaih1ucMJZKWsYHY79WNf8whV+MyCzWMFIdlBMK/9HhztKtxOZm4S66adgzMGIbYrM4SdByyyI/wdpGf+vXzG/IUicvZg5jvO2LOnDb/8vi5UQVwTMt14j8+eU3nItxEedpd4hKCiKsOC/bLsVuRRQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(376002)(39860400002)(346002)(136003)(66476007)(6512007)(478600001)(41300700001)(8936002)(6862004)(2906002)(6666004)(6506007)(6486002)(86362001)(53546011)(8676002)(7416002)(26005)(2616005)(38100700002)(36756003)(186003)(66946007)(31696002)(54906003)(66556008)(4326008)(316002)(37006003)(31686004)(6636002)(83380400001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWk2QjhDUzhTa0VOa2craVdWbGRyU29Kb3R4em9WVzF2Y1E2cnFCYTlteHNu?= =?utf-8?B?Q0VYUXRsVktTeGhYZmtyWVZlcGgzaVdQczNLMlFmdk5rVDJPclVObmxVZDZ6?= =?utf-8?B?bURoaXdVeitYOVFscmdKNTV6aTg3cmFhdzNITFhyWHNubjZ5UERPZzBsaXJO?= =?utf-8?B?b0Rla1hZRDhZSUdocUxiMXIzS0lxZjJselhJc3l6M29xZzhiME4xSGFWSTI3?= =?utf-8?B?dEkvMyt1R0V0N1lIeTc2emZkVTMxeXdTWVRtRnczYVFJYVhlMHQra28zTFdt?= =?utf-8?B?d3J1QnZ1ejVYNXVnMVhkOVIwZEpvbnBqNGljVlZld1I2aUY2TmIvM1ZGcXho?= =?utf-8?B?YVIwZkhPSlVmWUxNSWpwVWtpeVo2bmt3bWZSZW1OcVFnYVJIQVdBSmlieDht?= =?utf-8?B?NkhVMytZWlZVc2tsc2NtZWRWaTFSSlprTE1FRHhFMkMyMGtEYVk0ODdqb1Fm?= =?utf-8?B?TEg2T1dRSVN1cWNTM2lFS3phKzVtbTRUaVBYc2pNT0k5WGx1TGluVUdLSlcy?= =?utf-8?B?cE5lemlTMm9NeGRWYkcwZnRaQ0JIUm03UFlVbGRlS1FtL2d2RmpwMzR0aHJ3?= =?utf-8?B?Z2NsZEliYnVaTTY4QmRvWE1BQVhYVktDeUc3Q2lhQmhmYkF1bm9HN1JaZ0tt?= =?utf-8?B?RDJVdFhpTHRhSE9Fb3hJVHBKSzhVWTU2aWZRZ3kwQmlXUE50MFVWMDJWcHds?= =?utf-8?B?SERad3VZZExKVkhCWi91V1FnQnpVY1luM3c0bWN4NXUvcmVDTk9mQ0p3bnl1?= =?utf-8?B?ZWFDb3ZWQmptQmE3NjFTR21DS2xkbGx2emsrdzEwc1dpSzNscEFQNGhkTUxH?= =?utf-8?B?aWNtL2syUzZrMUlQRnFRdE9uc0xpRTk5WG9vV1BDSFFLbXhzdkRSOWVZREl0?= =?utf-8?B?RTZwajk5UHNzWTVTUThnOWlKcnJDQjBUZW9BdW1WOGs3cmordE9hRnQzRVRU?= =?utf-8?B?L1NRTXQwQVdiU1pJWEYyQXlzVjYyZG5HMDlZcUJFQmpNc1k5VkcwT2pvK09w?= =?utf-8?B?WHluOVNndWRWc2NzVmk4bWxOYmg3UEdNalltM2c1K3gwMmhyOVVwcUVjcjRu?= =?utf-8?B?NXJNOFQ1amRHTEVlQU84STBlZy80OFRnMUlCTzNsajRjOVJJQ3RZZ2JIQzJr?= =?utf-8?B?UTc0UDhlNUR6bTRKSm0xUXYxQVA0OThpa1p5WGI4K1pzWHIrWHRHZEd2a3A3?= =?utf-8?B?bzVtOHg0ZmZTTFNiV3NLQ2lNQSsyMVgxc1RuWHk1cHlOOTFEQmU3VzU1T1k0?= =?utf-8?B?YUxLMlh6ajdzdUxGaEhpQkNFcUxCb3FnZWRsc3NJWWVERU1hYkk2d3ZsWFQ5?= =?utf-8?B?bFg5ZDF3Ymd2ZUtUamRyYlVlNWtWZnlmZkdaUFhLbHRVMkxMcmtzM2taQjEr?= =?utf-8?B?RlRRaWJKalNuUW1uTDRZN0xZZ3BDMndNeE96YStaTEZaK2lSampEalFUK1hK?= =?utf-8?B?OFBCS3BJRGVCcnpidnhGVHZpblhEVHYrYkdDaFVBWnNGOG9pSUVtUytCQy90?= =?utf-8?B?cy9HK3AzT21QL0huSFN3TU9uamFiNXlTQ1h3M09EblN6N0dRNDZTUXM5c09W?= =?utf-8?B?aXlBem1HUXJML0Q5UEJSOWw4Vk83Nm5WS3hsM3Y4MVZMWHJrK09haGpub3B0?= =?utf-8?B?U2s1Wk1yNHVsdlpyU3BOYkhHbUVyc1A1UERhUW5qU0NCNGdmbjRjaFZrUzlR?= =?utf-8?B?U0hveVdHdzJIUmhhbSt2QXhZMVgxNjY2VGdzd1NUb01ScE5zVUl5aHZydk9j?= =?utf-8?B?blJjdVVnbUc4RkRkL0tMT0UwREtjd3FPeTVrSTkva1NMUTAvNURLc0ZZU1lQ?= =?utf-8?B?anhkbHVrQVNpZzhGVHVXN0JobFFYL1M3S28wSjREVnJVSzErRHJuL3EyQXM1?= =?utf-8?B?YzR0MGloczhSUUtHUG1HT3NqbnFUemxBU3VPaXJVYm5MRUJyNFpHNFVUZitN?= =?utf-8?B?VThKRll5bVA4cnp3RWp2WHhHdW5nSTJJcVRCbGE2cWdFYlEvWklzTnErNWJn?= =?utf-8?B?aWlxaSt4cDM1cEM3S0VoeHdLRSsrb2xITWJLa25Oa01wK0VvZEZCYm1ud0hS?= =?utf-8?B?V1pEMjlkdDJ6ZDBuWWM0N1Y5djdZa3F1ZmFlbGhEK3lTSmJBb0kva0VENjla?= =?utf-8?Q?1OfHrm4/BrJi2eCBAzceTDWXT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 890d6b25-ecc9-4cfc-1720-08da656217f1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:28:41.1254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h0f4nX/qECLf+7es3I6k417KQ63N3bJPznCqljoopr5NSkP6kPu79/8H+6vl5zgAX0asfyRqrn37OSr0EUrvLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8886 On 14.07.2022 07:40, Juergen Gross wrote: > On 13.07.22 03:36, Chuck Zmudzinski wrote: >> @@ -292,7 +294,7 @@ void init_cache_modes(void) >> rdmsrl(MSR_IA32_CR_PAT, pat); >> } >> >> - if (!pat) { >> + if (!pat || pat_force_disabled) { > > Can we just remove this modification and ... > >> /* >> * No PAT. Emulate the PAT table that corresponds to the two >> * cache bits, PWT (Write Through) and PCD (Cache Disable). >> @@ -313,6 +315,16 @@ void init_cache_modes(void) >> */ >> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | >> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); >> + } else if (!pat_bp_enabled) { > > ... use > > + } else if (!pat_bp_enabled && !pat_force_disabled) { > > here? > > This will result in the desired outcome in all cases IMO: If PAT wasn't > disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or > Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of > MTRR), then PAT will be set to "enabled" again. Just to mention it explicitly: If the value _read_ from the MSR is zero, we're hosed anyway, as then we can only express a single memory type (UC) in all PTEs. The zero case we mean to deal with is when reading the MSR wasn't valid to try. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 06:32:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 06:32:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367076.598132 (Exim 4.92) (envelope-from ) id 1oBsOL-0006zR-2f; Thu, 14 Jul 2022 06:32:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367076.598132; Thu, 14 Jul 2022 06:32:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBsOK-0006zK-Vd; Thu, 14 Jul 2022 06:32:04 +0000 Received: by outflank-mailman (input) for mailman id 367076; Thu, 14 Jul 2022 06:32:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBsOJ-0006zE-Bs for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 06:32:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id aaf1f4ca-033e-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 08:32:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8886.eurprd04.prod.outlook.com (2603:10a6:10:2e1::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 06:31:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 06:31:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aaf1f4ca-033e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X4sRnHNuoMHgMqttmVzMxze2W1daVa5z54z64qPsf5fydd9xkhEsBFUXxQRF+TuSMIJwziBOMHCF6peGJRRrJb1nCgzlfx/zjTIFZV+qEkmaJkYjjIK5CAFIXh9RjRhuEDn4/Y8OrHhzpKUOmTZkvG6kEAy1B3XmXVjwgwvrzj3WnpxO8DoP+3EiXKZhXm8XaybrpGsWf2oqDF/HdIPKx5TgNSgsTGQkaDNkay+zx7oZJTBZ4PME1HbCop4+BP4aG1BgcdPM9SvWOBKvS6aZH45xVUD0Rav1U/wU2/8pcTCq2k9OZpE98vIdoHLD+QyzbZSfJZESVP0JnLaq1ZBwpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yadeePzeuVz1Fz3VAUuGl8yJrydeLyLWVLuCPKiQrMY=; b=XFmcAmn3wVYLPZKEJX5bKypINumS2RxMmUvwpopcPYSeN7I2Kjv6K1c1OoWA0joXaXup4Dx872zMSFmbE4+fnsCxZTV2+AHwdh4o1Qc0e24/Tj2ID7Ynflnxqjzeb6J0PeeJUYeIyf4s4ymKzb6zrQ1kLvMAa/HjnAADUZJqeFNZUXzCXfe1H3q3V9oDhjFTKn3syM8Zv7n/8U+34Y4dQmnh73Yfjo1TrD35z0zfTv8PxCtu7+uobKJsloc+ev1k/K0AHg27q7a4w1igXc19CSoJ3u6Amr13HrafDNgS6Rp9F8XtyzflrsKyLNhvmNl9kEFMt+ptYf4n9DpClF2isA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yadeePzeuVz1Fz3VAUuGl8yJrydeLyLWVLuCPKiQrMY=; b=yf+LcPRNxdE5hJNqcPj8iOD1LTvHJOSMlYrYkX9oJXJIVxg8lA9BvJqnD8VPqLsKs738nSCqaKL/NQgE7oWIDgoD8KRuiOUuU9ynofP9eJTTujtFeNcZiaD+on00iO3Tp1CF95xt9dtNYJs6UOA46aXfgtfKqMhf6siCYaqKbWiXbA9+C+zjnKuQO9+0uOYTkhVJkfLkViQeqi+UXLdhUGpUleHhF9LJXouhKJkTxBNYdD0H2/0i71Tx/6hCVnovFcI8LPOL0hOi1OCssFzVPMgEBnFmoe9ebCV5ppvC/cF+CkNwBXY6xK3eziNcreuefLhGigwLp4xAsn10tesQGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 08:31:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-4.16-testing test] 171608: regressions - FAIL Content-Language: en-US To: xen-devel@lists.xenproject.org References: Cc: osstest service owner From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR0202CA0068.eurprd02.prod.outlook.com (2603:10a6:20b:3a::45) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c1f225ef-2c23-453e-290e-08da65628e53 X-MS-TrafficTypeDiagnostic: DU2PR04MB8886:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JyRTTbi9CInRTXD4wwncbCTwA7aEHzR0Vu4lPcRrUJgKjwRgHE2fG7ncjwQC0MHto43JcX1H09OOtiLQjcqIbYEaOW5ElCS2YvOgL5BPJ2vuFUhcvnxPys7LO4iLmi0b0jdJYSr/Pm8QARRfNJy9zUlHUliixHi4jn0ZW5AbZ2JGPPZ0mxLgv2hp2DBgbc4rn/LMsa9xLareNf7ljyE5rfmBvVigJPtx0hg6oSpm7k5Tn7PRC8ye9c919br8EiVHtaRjHu+wdDjgfT50CmCjZHbe1JEuI5TDpxRm6T7BdGaS5POdJ53qWWC+pwhNkbU6nMVruE72q1g5fDgZbkx5hCTcIKmfhH69z4qjDAuvzY6bkCtuUsvvIh5/UF8R7GY7wx71EfFMYCnz/9pWytRqZ84VDOQ0xQLG6LBQMOQmLSvh8Ni/71O9g/YN9T9r7kS2aDZRvHMiT8PPV7z9GWbFKCbvOoauDD30IOugCvbbnp0xg0zW5m/URofMOkvM66yPmMWPj+qQspat2Vh2/dNPrLJS+d0aEa5U6GHSEq5jsJYUt/I+0ADBprPea05kRkjBgN4RRTlcmT2ya9YdssA7CvHRTOYOMfyudcdpnquoghqQ55IY3QEHIcK7aDpy4QU+mYWyQGrtQD8SqHWbTNFhRPqcgVe37r5GhyrS45/qLode+5644OEB01urdTP4Xi9nftfvI1AVml/F8Ln2d9OUsOMerc//75C0fNqdqhIaJHbzdFFQrvVVPiAwWUXH2b+48qr+mGX3yDio2+9rm52vL8rMmtYvhk3JZAlQTcQbKaA5djYcCjo0JoE3fKSy1AfUgdJ0rnepMbcvm+I1QExxg3cBtDZNK6eeRrVallMdFHD653EbnMY5LOBga12Ah6el X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(346002)(396003)(366004)(376002)(186003)(36756003)(38100700002)(66556008)(4326008)(316002)(31686004)(5660300002)(83380400001)(66946007)(966005)(31696002)(2906002)(6916009)(6506007)(66476007)(6512007)(478600001)(41300700001)(8936002)(6486002)(8676002)(2616005)(26005)(4744005)(86362001)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVlaQStJeDJjWlRSZGtnc2lCYzJ4Sjk4dmZHYWJLYk9mWlJueERhU0EvZWIx?= =?utf-8?B?UkptZ0JDREpIa21wUlhiRzBUZEJKdGtoTFZhRjdrazg1cW0ySWRMS3c5OUho?= =?utf-8?B?Zkx6bGoxSHFLSDJHd3lNc0tZZjd3dEU2OWV2VEVkS1g5K1hXY0JhWEwzbWQz?= =?utf-8?B?dnM1Rng2MUdZenlBUW0rc1RUd3VtaW1Fd0tBRG5Pd3AxUFhhZU5LYU9MLzEy?= =?utf-8?B?L3lvK0ZCQjA3eS9PREF0OFJwNVpXWVBsZlpnaU1CNUpzcmZpYTVrclNBK1JS?= =?utf-8?B?TXBKc3R6eWFQczkrZUVReHltalNTNHovZzkwNVVCdEYxeXBuUW5ZYTAwdnBm?= =?utf-8?B?dkpLWFFYclhWR0tTcVp6Q050MkM3RjFaTi90WGlTSW5paTJCNTFHbGFhVXhn?= =?utf-8?B?cktwS1lBTTM1d2tVcmM1cGhQeEtWMzBGVW14dmdVaXJaSVoyVTQwcWJ3QjNL?= =?utf-8?B?SFhXcUg0bjlTcUhPSmljVVg2akVYWVBHUldRVWUrZXZ0Sm5nMkxQbEY2V2Fj?= =?utf-8?B?dTZJNlRLMThFWERJWkxRRUxmNUFSUFRUa1NnY0lYdUpQeTZRT1JzZU84ZkNO?= =?utf-8?B?MEdUWlcvakw5U1NsY2VLMzgrM1p6NDRYNytIbWxiNGlpVzJHcHl1V2o0dG53?= =?utf-8?B?YTB1UDJhTE9aTy9tTTRXY0lFSnVtVXdQaXRwek5waFNzQ3gyczg2KzFYbm9U?= =?utf-8?B?YUx3TXZob05id29pajA3OUVEM1A1MHZQeUs5N3VFQ0s5elJBUEV1RlFESVBE?= =?utf-8?B?QnZnL3ZadEhRcUdqRENPSDUvY0tKeFV3QllZZzhiNWF1Nm40UjgvWDZ1UFpq?= =?utf-8?B?SVFEZEZtZEVDTmp5Wk9FUWtWM2pKRjl3WG9mUE1iMUg2eVRZNGFZU2VqR1Ar?= =?utf-8?B?YktJbTc0RENkQnk4ZUs3dk4wcE9CZjQ4cVlkaVJDOTNHNW8zaU91VDhJdDBE?= =?utf-8?B?Y3duTEVUNjBwRlphcDJqNDQyOXljUUFPY1lKc1o4VmltK0QrYUxpRG53WXha?= =?utf-8?B?SHp6K2N6Y3ZSOFdIWm0wc1ZHZktqQUVueXQ4aEhjMGFqMlpVdlRIZnFmRkpv?= =?utf-8?B?eTVhZGNFalRrZW9MNHFCT2NYdjRyVktEMW0zM2dVL051aUV6R2xZYSthWlJk?= =?utf-8?B?aGlOdlhPS3VPdkUvc1c4bGtGRXh5RzNyMmpyWm9mR04wNThBL2V0ak5od1V4?= =?utf-8?B?UFppek9iM2hDQTNNWUdiSDVRN3RBM04yaGxaWWxsVmFJMGsvS2pHNVVISHJM?= =?utf-8?B?RTJsVHZqS2d6TnhqazVxZVh2S2tjVFRPeUkrd0NrNnNjTXY0eGpFNEErL1ZZ?= =?utf-8?B?czlWMHE5UzE1UXhPM2pFZjlmN0tyOUtNZ2dzcmtYVXdBTXl5dXZSTllrc09L?= =?utf-8?B?NHZzais3R3pZV3VGRXdQSU42aTdpUFB0TkFxNGd4b3NlbnBVVDhUZDlNZ1Ar?= =?utf-8?B?VEJSZktiWkxBS3RFQ2pTVmxQQ25lMXZ0cWMveEh6NXp5WVo3clZLK09YWDB0?= =?utf-8?B?R1JVeU93WithV290eno0cmkwcUR1dzZObmhPVXp1T3RyOGVCMktwTU1YN3pW?= =?utf-8?B?VklJSWdDWkFiV3NaQlRuc2NYUC9WVVc1OUVwcTBhU3p2QjJJdlR3ZXBsQ3JR?= =?utf-8?B?L1dQT2d1dEpBQzRxd3RoakpEVkZvRHJtc01UeFltZGJETnFHY2x5RzJZbmVi?= =?utf-8?B?OW55Q05IT1I5Q2hCakEwYTBUa0VVU2V2ZXcrZlk3L3VZb0VYUkEwc2VKaEJV?= =?utf-8?B?cHgzT3pSYmI0MEIvaUJzNW0vNWF1SmIrdlZxTElNTG5KcjhlV2V5QUltSTVO?= =?utf-8?B?dHVvcjZmMVc1eDdldElsMllCRStGNEg2ZXhtd2ZKdnZRR2pweVFlVkZxcGJU?= =?utf-8?B?SDRmaytYRXFMTEorRGdKVU1HL3ZMY3JodnhtbXFSckZDUkdDc25McmZsdXU0?= =?utf-8?B?Q1JBNWw2RG5ORy9wVnVtT2xtYjVoZ0lSV1dNOWc0NW9sNzNCMm9JcG9GRzRj?= =?utf-8?B?K2EwZnpTK2hUdzJtd1Z1QWdSYlc4RGRmMVJibnZKM3NiM2VRWnF5M2pNcWlr?= =?utf-8?B?eWNZVHR0SldjdS9oTzRseno0Nk9xM2ZvZkpwZHlsN3U3bml4VWpxamdqcitr?= =?utf-8?Q?Ml97iOXixnjZQ7Xrp1VMHjS30?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c1f225ef-2c23-453e-290e-08da65628e53 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 06:31:59.6611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q+qQuIePEVANvya6emE1xmmeTUrjNYs6pXYxyOgsmyif+5r06e4lCI8pxk2XFDRmsPHLh0EKYxFqGgn0ZInmqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8886 On 13.07.2022 19:53, osstest service owner wrote: > flight 171608 xen-4.16-testing real [real] > http://logs.test-lab.xenproject.org/osstest/logs/171608/ > > Regressions :-( > > Tests which did not succeed and are blocking, > including tests which could not be run: > build-arm64 6 xen-build fail REGR. vs. 171595 The (apparently random) compiler issue again, as it looks: cc: internal compiler error: Segmentation fault signal terminated program cc1 Please submit a full bug report, with preprocessed source if appropriate. See for instructions. [1104/2442] Compiling C object libcommon.fa.p/hw_audio_soundhw.c.o [1105/2442] Compiling C object libcommon.fa.p/hw_display_virtio-gpu-pci.c.o [1106/2442] Compiling C object libcommon.fa.p/hw_display_cirrus_vga_isa.c.o ninja: build stopped: subcommand failed. make: *** [Makefile:156: run-ninja] Error 1 Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 07:53:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 07:53:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367116.598162 (Exim 4.92) (envelope-from ) id 1oBtfG-0000SN-EE; Thu, 14 Jul 2022 07:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367116.598162; Thu, 14 Jul 2022 07:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBtfG-0000SG-BX; Thu, 14 Jul 2022 07:53:38 +0000 Received: by outflank-mailman (input) for mailman id 367116; Thu, 14 Jul 2022 07:53:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBtfE-0000S8-QP for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 07:53:37 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10067.outbound.protection.outlook.com [40.107.1.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fe569fe-034a-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 09:53:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8277.eurprd04.prod.outlook.com (2603:10a6:20b:3fc::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 07:53:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 07:53:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fe569fe-034a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D1NDioNQRY5uMEDQRD3MH64PseamVUiwIYajTbSBfJOD75UsfWb6wpjU64c99rhKuWVWh23UEdtgzb4bhHzF1vhGcntTBPHxTLqdjP97CF3DeV1KORbqnHqEBU3XkYTZs8sWuVIz79Vm9urZ3VwHgxVvyhpcbzRQOTMN85VRZXkHsE06IvBhRhnnwVQ7N7dUxTp1klWoHJ5DehSFMMvJLdTbWEkQR1lDaGjUxFT3P4Obv5js7flBCE4UqnaC9U9V2G8BaRUh2nWRYqc8TBSqfMNQbYgJIae+31E9xL+895TFncRzypg5c/yGsvkgZzEOj0mdyGay/v5shNgs9J62oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vg2++ohbROKGuBuD1u7yvOVgR0jicqwjmakPmvGc0Gg=; b=N/pm0rk5/4wNn+fdlvWDGPI+yeCmmU0LnLaUauIrg+e8wTIOQLpCYoVvEk3M8b/ZTgApoDv4GZZ4YPLH8sdHwQVkMN06AgHQ7EAQzFjTKc1AbySNay6bwIgMotsFaCoQ/Kzl33jvuKsLbspmrVOus6Gcde0CHufvWJpbyHGd9e29FhnfzuKUJE63ebsvG2xcBIR/QhtmBQbsJKxZnoajJflVAus6CSEo2zJJukx5YZF6tOeAFq+ckWBAGFGoGJv/4oWJuzpCYwK4GyYg9KcP0LA8Z1hjAjKWyYXMTBaXlyEG4qZthT5mnZ+HM8pK0SGSwMgmgr9ugYxz1nMIpo9tvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Vg2++ohbROKGuBuD1u7yvOVgR0jicqwjmakPmvGc0Gg=; b=LdoCnC22UzDMTynogdfvEujOV45N7sRT8vrJ5yZ9k++toQDsijNGms9W+geD1dIY7IIGfnJYTt4lEDCIOCd/TS7OQx+pZ5X2EvhQ8hM4xAtKPOcnHvm8p1mRg8vpSI3d8PO6Wk2e2dPyI8XLotO8kDxXKUZokvrMbmKEtMj/sidPcBs0ar8vMq14LYJJ9uUvct7/QNzaBmGpUIL0JZYPxmEQJvuQTylXrn0ofma7sclCCJRU/k12V+4FiigFZzvWwVo5OVjU4u6p3rdyf+Rr6uz4zfaMQBPGBdeCG6fhVpItXMZRX7CPiGAfKc3JX5R/+iCGafV7QPxSDN2tQ8abHg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2c3f0ca0-94c2-6462-f4eb-a2ac54c09554@suse.com> Date: Thu, 14 Jul 2022 09:53:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Charles Arnold From: Jan Beulich Subject: [PATCH] x86: deal with gcc12 release build issues Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79cdb4cd-1522-41b7-f19a-08da656df316 X-MS-TrafficTypeDiagnostic: AS8PR04MB8277:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GhjG1VbqxeRzXcMEFqBsUy/PkM7/Sd4HQO9kEmxLQ8PPBOh3BjZsjjXY9pFV1DQ9gri+/S+z1pn8bJ8m/KUGtPYZYcXnTYbsfxJhe0n/BRUEYXi9RQJAeuqT4LtBn0GZk0lBm59eF1CqXKYA1oRoRQRBqdY+HJYfhWBtVPHfu23zA0M00IqupxFxPjllljQSVCcZsqY8Rb2r0ggHfRXalo5vRIsOZX/5RwX9DlZ0JGBFj43T+9PE7+y0aXlRAcinunSnDWfzvEmq1uEtl3OjvUl2Pt9ZYJozde1frvT3HSNbqDPKEFKE6bC0c/zyp0iFTrr+DVny42/qjyE+53ga0ar2OwQmREIiZMLPnVKnM4TlcCg/kbqdsdePWGj1p/1YSyw/MWrVh1WI1j34g6X5oDB4WXaIdUALlOEf8WnDIdN+2t8tEdBG8eB37/poyeb7CmadxLQxehqN098zAomlnnUpLmeCh3P/uHw+7IbaUKpTYTJlnL3awBzHVBjbnnKWXc799+Q9mv4IUwqiewHqCXuhAgiOepd2J/VqDwjnvLVI3nPCsj2HMlGY/YfswkhXy4qEAbuPrXX49At/We5Yryp80GZ60Tcw437JNOWYrPxois/FesUqA11dnc8Ef8fg3/2Oy1NJaIakzSKsuKtOoaiNNMSFMPmbeD+XQSZOJ6HrFnLu+CNGRUd/U10CGp95a9KWTuKzWJ8gXy0oE6hUd9z1ff1OazjRpejv/UP06g3lVRfjKLKPWbeQ5RjwnzznzuDUFLalifiIgoJYlxTSuCh4wJfF7+eNbjDYIpvEOW/c9HBcdDXZaHQRz8Pa8Z/raQ/Lqn+qLIrJtokfsOi1w1TjQvnO8/Xwk33L4FG7t+M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(396003)(136003)(376002)(346002)(31696002)(5660300002)(478600001)(8936002)(6486002)(186003)(6506007)(66556008)(4326008)(26005)(107886003)(38100700002)(66946007)(86362001)(2616005)(316002)(31686004)(66476007)(54906003)(6666004)(6512007)(6916009)(36756003)(8676002)(41300700001)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU1GcWg4UGVNZnJOZ0QxNU4vUWlNYmZVcmZFYTMvUlgzOE5tY09Gb3RIUW5r?= =?utf-8?B?YjAvREZkNTQyUFc1RnJBZFB3NmJFM0txLzBsWjJ3aUtGYVZ5L0lYQUlETTNQ?= =?utf-8?B?dkFwc3EvTmlPY01BeHJoOU1SOHB0YUMzT3N4Q016dHFObkpDUzUwZlFuRzBF?= =?utf-8?B?L0N4bkFyc3JLZkVxM3pzUmo5d3BCbDZDd3VHYTV1UzUyYkx0ZGprdzNUVmt3?= =?utf-8?B?bjg2MW8vMEU2ZERtSmM2b2FOZkVqRk1QZk1xM0dFSmt1UlpKd2ZzUUtSZ2Yx?= =?utf-8?B?eXlNVG93TlZIMFhkdU9XaEw0L3AwTTlmaEUzcUovTFBNLys3SG5BYU9Hd1dO?= =?utf-8?B?QWFHNklOQ015TzdqaDVjVFZVU3BHd2dDelN4VVo5WTJVREg1WnJlcGZybFdT?= =?utf-8?B?eWFOcWpPbFE1N3U4aGp4WWY0SUhrdmlDSzI2QnZsVzlOZ3BCODhwSi91S2gv?= =?utf-8?B?Y0s2aGMwdXVRR3JSdTNjdlZLcjFKc1RneDdrUmx1QjNRc3dEaEdGa2p0K1Fz?= =?utf-8?B?U0szeXV2MmtndERkZmdRS0tSRnZ6V1pCcWpsdkp0V2dDR1Q1Zng5azlSeFpU?= =?utf-8?B?YzRKYUlPQXEvMFI1V1FZekdrQkM4MDZvUWo4c3d6MlIxMktHVG05dEtrQndE?= =?utf-8?B?T0lMNVRzdk42WWVtZlAyZTJmWWw5UUJ4WVV1RWhOL3VyNWJIVk9ieWh5Mi90?= =?utf-8?B?VDV0cEtNVWlvck1uZElGeGVaMmhYaDNpWlFnU1RxNWRQTXJmVG5GUlF3UGM1?= =?utf-8?B?SmdDVWw4U2wwQlR3anlXN3hkWmpNYnVsWmgrU0tzbGh3blRVK2RtL2h3bEtF?= =?utf-8?B?R2FENDU4SmdvRzgxSVNEbU5mRVhSOW1qc1h0ZDg4bFVrS0I2SzFpSWdxZUVi?= =?utf-8?B?TGtEZlVpR1VySWpmK3o4a2d3WlAzdlAyY2pnZ3l2aFpMR0h1SUxLR3NjYUNh?= =?utf-8?B?eExRd28wcTFTNlIzTUE1TkJ1Vk9wTFJ6U1l0TTZMM3MrVzZUNCtLNFVmd2RH?= =?utf-8?B?VGFRK2QwQkswNUhMSzRHUVF0Rmc4eE00ZFJ2WU80T1dpdThNNlplQlRhTVlK?= =?utf-8?B?VHJhM0o0bG1MYytWeWNXdXNteWlqZExzWUJRd3h4SVR4MWlMSkxjOGtkenpX?= =?utf-8?B?aWZxNXRrcHRxVjN4Uk1LMmI3bWcrRDVpWWpRRU5WLzdmNUR1Sm5qYTFRV1pz?= =?utf-8?B?VlFlOUFVSEtvS1IvdjVmNXFUdlVnT2prcVd0Sy90emdaR202RWZhY0p1M1Vr?= =?utf-8?B?R1JVTXJvSGNqRFplTHpnSGZpWUFTOHhIK25iVkhiUlJBeXpVOW9CNDZHSE5N?= =?utf-8?B?SjRJUnhhbG1WcXhidTZtaG1xZUc2S1lxZUNqTmtGeXRPZGlXZTc0SEVRdU5v?= =?utf-8?B?azNSVDNXOTZUWGNDbzNzYzgwOWZYSUlSY2RHbitzWGhEbFd6VCtjcmFDOUtv?= =?utf-8?B?SUQ0T2dZQmtpanBmOWg2TklFV0xPUG9JblkwYlJNUll5dFc4VHVya0JERmJv?= =?utf-8?B?dWd6OVI3bmwzN1RtMHIwdVF4WUs2T2VDWFdLQld3Q25rZTU1M21sdGtBS0I3?= =?utf-8?B?WXVCakJYbktLSERSTXgyZ0NpWVJrSVVWOWRPRWUxbHhaR21OKzRwa2NVdzZp?= =?utf-8?B?MzdSd3A5ZTJCdExETTFXU1NNRzRIQ3NLWDBTVVRsQUptbWxmVlRlSFZlSkE5?= =?utf-8?B?Q3ZrazJGbVhOU3BGUkdaNU14N3NwQUc2KzhpNEp1VkFoODF6YXNneGt4dlRt?= =?utf-8?B?QTdCaVZtUnZjOERTQjN0M1N4clNRWWhGS1g4OGQ2eTdnRUtETW5JZGZibFZs?= =?utf-8?B?bThXNVdFcFNZeVhoZEEycTBObU82YVhjNGpUQ0xXNmN3cnQreFFmdktkTFJG?= =?utf-8?B?ZUsxa1o4bFl6YytYWlN4dzR2czNEMlEySmM4aUk0UmozKzNoMEx4TFNUeERO?= =?utf-8?B?SU9yWU81QWxIRWJYaTdLY0hDbkRVN0gwMCtGN0NsbkhFNzFqTW4zblJjL1B6?= =?utf-8?B?aFZNQkdMTENvZjN0OFJxbGdyODRNSmV5cysvRStMSXpDbVlWL0o3ZFl1eUti?= =?utf-8?B?N21DS2N3ZXNxWDgrUzJEbWFTRW5XNUdSMSt3MDFLQlg5d2xtS1NvODMram04?= =?utf-8?Q?5hhx1j9RABxOmqlDAglWzexxb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79cdb4cd-1522-41b7-f19a-08da656df316 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 07:53:33.1647 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hfF0rv0dAdm7gJSavsdEm9xtaL+bVJQsIH+Y53FupAjJRqN8+V7QaCulgRexf24RIE6y9J00neav7hmLd9CRGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8277 While a number of issues we previously had with pre-release gcc12 were fixed in the final release, we continue to have one issue (with multiple instances) when doing release builds (i.e. at higher optimization levels): The compiler takes issue with subtracting (always 1 in our case) from artifical labels (expressed as array) marking the end of certain regions. This isn't an unreasonable position to take. Simply hide the "array-ness" by casting to an integer type. To keep things looking consistently, apply the same cast also on the respective expressions dealing with the starting addresses. (Note how efi_arch_memory_setup()'s l2_table_offset() invocations avoid a similar issue by already having the necessary casts.) In is_xen_fixed_mfn() further switch from __pa() to virt_to_maddr() to better match the left sides of the <= operators. Reported-by: Charles Arnold Signed-off-by: Jan Beulich --- Initially I had considered introducing something like END_MINUS_1(), but in the end I did consider this uglier than explicitly dealing with the two instances we have. --- a/xen/arch/x86/efi/efi-boot.h +++ b/xen/arch/x86/efi/efi-boot.h @@ -677,10 +677,10 @@ static void __init efi_arch_memory_setup * appropriate l2 slots to map. */ #define l2_4G_offset(a) \ - (((UINTN)(a) >> L2_PAGETABLE_SHIFT) & (4 * L2_PAGETABLE_ENTRIES - 1)) + (((a) >> L2_PAGETABLE_SHIFT) & (4 * L2_PAGETABLE_ENTRIES - 1)) - for ( i = l2_4G_offset(_start); - i <= l2_4G_offset(_end - 1); ++i ) + for ( i = l2_4G_offset((UINTN)_start); + i <= l2_4G_offset((UINTN)_end - 1); ++i ) { l2_pgentry_t pte = l2e_from_paddr(i << L2_PAGETABLE_SHIFT, __PAGE_HYPERVISOR | _PAGE_PSE); --- a/xen/arch/x86/include/asm/mm.h +++ b/xen/arch/x86/include/asm/mm.h @@ -309,8 +309,8 @@ struct page_info #define is_xen_heap_mfn(mfn) \ (mfn_valid(mfn) && is_xen_heap_page(mfn_to_page(mfn))) #define is_xen_fixed_mfn(mfn) \ - (((mfn_to_maddr(mfn)) >= __pa(_stext)) && \ - ((mfn_to_maddr(mfn)) <= __pa(__2M_rwdata_end - 1))) + (((mfn_to_maddr(mfn)) >= virt_to_maddr((unsigned long)_stext)) && \ + ((mfn_to_maddr(mfn)) <= virt_to_maddr((unsigned long)__2M_rwdata_end - 1))) #define PRtype_info "016lx"/* should only be used for printk's */ From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:04:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367126.598173 (Exim 4.92) (envelope-from ) id 1oBuli-0000ij-PE; Thu, 14 Jul 2022 09:04:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367126.598173; Thu, 14 Jul 2022 09:04:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBuli-0000ic-Lq; Thu, 14 Jul 2022 09:04:22 +0000 Received: by outflank-mailman (input) for mailman id 367126; Thu, 14 Jul 2022 09:04:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBulh-0000iW-GT for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:04:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2080.outbound.protection.outlook.com [40.107.20.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0eeca05-0353-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 11:04:18 +0200 (CEST) Received: from FR2P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::18) by AM0PR08MB2964.eurprd08.prod.outlook.com (2603:10a6:208:5d::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 09:04:15 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a:cafe::f7) by FR2P281CA0008.outlook.office365.com (2603:10a6:d10:a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.7 via Frontend Transport; Thu, 14 Jul 2022 09:04:15 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 09:04:14 +0000 Received: ("Tessian outbound 8e3d5168572a:v122"); Thu, 14 Jul 2022 09:04:14 +0000 Received: from 8d27ad46e509.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8541CE5F-A3E9-4F1D-86AA-10FC29D60B39.1; Thu, 14 Jul 2022 09:04:08 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8d27ad46e509.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:04:08 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB5235.eurprd08.prod.outlook.com (2603:10a6:208:163::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 09:03:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:03:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0eeca05-0353-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Aiclgq715UvQsaVxRyeYXldxfKn6L9hnH7xZmp3+d19kqPjEJBQ4XwGG9vDFxOstylQJ1fqnotYJpAk88pH/9HAcsRpOqAzq7xZ8b5QUDyCkiWuWRJdMdVyICRaXVjyRG32kFGVzTvlmD93zK+S24mGUphImR3SU+/+CfHwM8LK2gZj8YbcnHukho7/qQX1Ki2xY66KGOJw3mHgaom9ij49PUpbR25rOFzKbkq8PC6mC9R0gqaC8p1fvQ3fcaJuEl1pAkPGB0Bav1pGykUk8VC6y7SYdJZG6/+XhiE0VLwoetbuoV7iD2LsUI+xpTwu5yRGjNGSv75/RwllBM/E8SQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hslQ4VZDIgTi9JwMfhJR+um9vEhPPpETHGrRcNjqtfE=; b=f6K1HW5Wg7fclhXPoHZU0LyRi64unRcTYxvWiV1OuM6vgMBOCqoySgfbL0RzH0SJqg7drnEJ2PwCcYwQ9fZoNoBMTwg9Oz/2yibAMSoSqk0IeHsJE5Bi7isPaCnqrkFZNbRC2sANl5KJ/rJJcdBN4dD1N66KtUytGefMXg3E8lGN1Wz+kfHombrUwFg0TwyQF2d7pJe5U43D74m9b17obWvX+d3hqTz3Gx8e5pQAMytGBS2IXDT18sPSrdmjCe+obPsq1aVfgmgKW+LbZOcRnAKQsSCigiLQv0bqDXUvaWcHFUw0JxwqHgld5jSxONSBSSgePzZXr2UQVxg4P0yDlQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hslQ4VZDIgTi9JwMfhJR+um9vEhPPpETHGrRcNjqtfE=; b=71t6VI667Z248Wv4gIaZYJo1urY05GqGJb4mFTA/YvWemIS+sGETdkmYqEcVQyPU4IN5C4Yy74RmtF847wxFC5wGdIM8cBJDgRBctVXs0jyMSb23FOnN8nOTX9JeIBjvctTUyaPmb9a46xm0W05hhAj43svbQRdK2rvuCHjEdso= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kB+hiyHxNOSrU+Fv3lyM/D8MXmq07Aw5jQttat/bx4b72dOsNuQhEQ83eWDqreA5Iy5OZqOQv31tdvaTFvAI3gHkQRTYDxxdfQcAdbASpOaWf3VG5bkaCp4O4b8jQRMlUmjG/OiPRdDUUOHlGNOz1VuGvbqlY+4Vn+c3UgEPGFmIxXqvJCATa7T6GGvmSKsAW+kfQLZjIVpr+u7sqVxh3GNuZhS7OQ+6jiUOrBnwsP/D7asy0T6YCo9UcURFayO3/euKsRkZF4x+DofyZlj2e8CaPSvUU1KfG8JUoiPe+QDJkakanakeIuLqHomtaZOUpepqD8dmrwzJyaEMWLkvhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hslQ4VZDIgTi9JwMfhJR+um9vEhPPpETHGrRcNjqtfE=; b=cbZQaIkTvx810qrfs43R98pURfAqPrfWVz+NT7qghEMoUVG6/giQS4FPzBR+YbaYWX6/8unIBYHriGLlWtXbq5Sx8qnagjvBlfESSsekZ5uH9Iod+PPO3AyGWOEUFaS6dH9BHs9RRXHmm/HsCA7UcrC8RiDLq3zjKLFsPHs9Y1nQInmzpEg6umX8miPEQKavxZiaZSQWlvFTfHl7dFVNVvhzGxDLPKE51d0uloY5s9Le9+nLV9mIMyBHnF2QETY4RLo2/EVPK+2hR2bnpmQ/VssSEEfbqHyM73SL6NouUryWLLoitwtpDkMmVlfKBhdonoj3Nrp303aVSZE53+hI4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hslQ4VZDIgTi9JwMfhJR+um9vEhPPpETHGrRcNjqtfE=; b=71t6VI667Z248Wv4gIaZYJo1urY05GqGJb4mFTA/YvWemIS+sGETdkmYqEcVQyPU4IN5C4Yy74RmtF847wxFC5wGdIM8cBJDgRBctVXs0jyMSb23FOnN8nOTX9JeIBjvctTUyaPmb9a46xm0W05hhAj43svbQRdK2rvuCHjEdso= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0A= Date: Thu, 14 Jul 2022 09:03:59 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: FB7DF25F77EC4F46B4448EB4B51F4BCA.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a32222a0-b5d4-4b71-78c2-08da6577d38f x-ms-traffictypediagnostic: AM0PR08MB5235:EE_|VE1EUR03FT006:EE_|AM0PR08MB2964:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: YLIrN9TV7HaAeNBRkxtM91xJPZssuNGqFnxqFCexDkVBxGEgBl0lHF18nswQ6S8jFeeMBbBZIt+1ZZijk1I18zWbnjVxlpR1R+DdDrqzDrmb2CpWaAHHkS63SJ2y26El+OElm8v652dKSKlEoalEd6LveuXW449jPsdae6ndoKIgwNlOah49mb5DEnRcw6twQPk0HtarDPKblfMwHCMoHt5htwwl3O6SLRXII99s6XoRsk92HBb9EcS8MiHZAlzf/r0FzJWxM5J7W0hE7cp+GRkN3lt2S3IkSZdkHCHpvaNEWR9PQ0gPaUo+CBY3kmmCDLEdGf5N9ViX0xjXqX3lOq2ikxQiolgsBjKWUwuaA/tGe/zJtXB9HeBaYh+sIlS6u1/Ms+o6PaZF+bo8H1x55fyv3VKfkNsZxZyMI4DhKwejubY78JFDV9p0/yZz5SBj3x1ZPAqLf0PqIBJJPjron1gzBjVk3WIB06j94Z0PBUvkggBt+/NKiZ0GMZcaDQ4EcQNfmZyYsGBdn6ksu8RBDGiQ9Iqxb5bPKwBYXlD8Ef6BVi/GZn/jnOFhwzqppBh5KLc5fXfDkOE9N7U9X+BhwdxaxT939JBu9OxI1/JzkNNSESXgdk2hf7H+ZFIkwMzf6WopXP+WPVCuA0ltytI4T6oTca3TA5puIOlj3Nt+ICrHG/S3UpJlfeOZYk2vO9I40E4KGRZlXeGnhR+TQtGT19GLj43xGUe0QIR0A32lrvWJscQAjcWmy2PiHnhcWgCGwNDQUbQupF5MRor9Nj7ym+qMyKGRf9MTUKPy1Erq5EgB82Xi2K5sRYVJADYtCDNa X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(136003)(396003)(366004)(38100700002)(186003)(122000001)(316002)(38070700005)(54906003)(6916009)(55016003)(52536014)(5660300002)(9686003)(33656002)(478600001)(7696005)(6506007)(41300700001)(83380400001)(53546011)(26005)(86362001)(66446008)(8676002)(76116006)(64756008)(66946007)(66556008)(66476007)(4326008)(2906002)(71200400001)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5235 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2d5b2ecb-9691-4fa2-9b3b-08da6577ca38 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eFeBKQ1VniN/w0kLdZrFH6gM+vQHCeMjSoZSLd3zqHIS7mdi9D2Vp6T2/ZmbCn2e72DohJIyqJP4o00vx7EBfqGgkYEacnoSvPR9Nj3IUhEynoTxEODEPntQ7YifXStV8kbtT0JlZJ6MwpTSXCiFbmQi6oQfMKXU1t10Dksk2QBjGqfr7iy5i2mjbgE/B3eLjq1RgDpREKrDsAirINMuwm6o+W8GzG72lcJivrl4ZHuBDIHLBHxzkAFBtcgyA6CWbjTQVIxhj78gLjvyRzScP5fyrFtOnZ46HQHMp3Y3cx85rkAd0aSXd6++LkUMUu3qi/aoyHpoJ7yIpw4/HIrjPOtDS0Gc9Qhs/xmUpIFbg/krfn90WDr0GHSJNeza43VcY81VE/d3jo0rFYdLQGPjUdhcllpkgIDlhZbVqsxGXfLCULwsjKImWkFEh4+6zgwRafFNJ69VWy+C20jSHT6kn+QGJ2ONYtzp8CTDot6jti2j9A7pAs+BnRnzwkOr5FSMI3zyz0zpZqw54lC0tErbaywb7gVtNXRwwEVsYQnieDjmBE09BfcV7ZffnHUXyrc77qFm3BCkWnM8CzvjTt1vmFZ14R+YbODf5oJ/XJ3Xa4xEp0h09/yf2YWm6NUz9h2R5Y7gOMjcM3ckHT41vqCu70c41ztx7Ce1A1URkzlBB/oMC9hVyJiQr64O04gUWjUeQOi7t8CXwu5b1LA86Az1F80Du5bxGf3E4yD1lxhyjeQVsncdi8IAAZaBt3deF0GeSU30CmpzLaR7keSd5T7WdDr2U81U7NLuiarczrJjdu8TkDeVlakuNV8TYMXdRWoS X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(376002)(39860400002)(40470700004)(46966006)(36840700001)(70586007)(47076005)(40460700003)(70206006)(9686003)(4326008)(8676002)(186003)(26005)(7696005)(2906002)(41300700001)(86362001)(336012)(6506007)(8936002)(478600001)(6862004)(52536014)(33656002)(5660300002)(36860700001)(53546011)(40480700001)(54906003)(82740400003)(356005)(316002)(83380400001)(81166007)(55016003)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:04:14.9692 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a32222a0-b5d4-4b71-78c2-08da6577d38f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB2964 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMDo0OQ0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg Mi85XSB4ZW4veDg2OiBVc2UgZW51bWVyYXRpb25zIHRvIGluZGljYXRlIE5VTUENCj4gc3RhdHVz DQo+IA0KPiBPbiAwOC4wNy4yMDIyIDE2OjU0LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBJbiBjdXJy ZW50IGNvZGUsIHg4NiBpcyB1c2luZyB0d28gdmFyaWFibGVzLCBudW1hX29mZiBhbmQgYWNwaV9u dW1hLA0KPiA+IHRvIGluZGljYXRlIHRoZSBOVU1BIHN0YXR1cy4gVGhpcyBpcyBiZWNhdXNlIE5V TUEgaXMgbm90IGNvdXBsZWQgd2l0aA0KPiA+IEFDUEksIGFuZCBBQ1BJIHN0aWxsIGNhbiB3b3Jr IHdpdGhvdXQgTlVNQSBvbiB4ODYuIFdpdGggdGhlc2UgdHdvDQo+ID4gdmFyaWFibGVzJyBjb21i aW5hdGlvbnMsIHg4NiBjYW4gaGF2ZSBzZXZlcmFsIE5VTUEgc3RhdHVzOg0KPiA+IE5VTUEgc3dp dGggb24sDQo+ID4gTlVNQSBzd2l0aCBvZmYsDQo+ID4gTlVNQSBzd2l0aCBvbiB3aXRoIE5VTUEg ZW11bGF0aW9uLA0KPiA+IE5VTUEgc3dpdGggb24gd2l0aCBuby1BQ1BJLA0KPiA+IE5VTUEgc3dp dGggb24gd2l0aCBBQ1BJLg0KPiANCj4gSG1tLCB3aXRoIGJvdGggdGhpcyBhbmQgdGhlIGFjdHVh bCBjaGFuZ2UgSSdtIG5vdCBhYmxlIHRvIGNvbnZpbmNlDQo+IG15c2VsZiB0aGF0IHlvdSd2ZSBl eHByZXNzZWQgdGhlIHByaW9yIGNvbWJpbmF0aW9ucyBjb3JyZWN0bHkuIE1heQ0KPiBJIHN1Z2dl c3QgdGhhdCB5b3UgbWFrZSB0YWJsZSByZXByZXNlbnRpbmcgdGhlIDYgKEkgdGhpbmspDQo+IGNv bWJpbmF0aW9ucyBvZiBvcmlnaW5hbCBzdGF0ZXMgd2l0aCB0aGVpciBtYXBwaW5nIHRvIHRoZSBu ZXcNCj4gZW51bWVyYXRvcnM/IChJdCBkb2Vzbid0IG5lZWQgdG8gYmUgNiBkaWZmZXJlbnQgZW51 bWVyYXRvcnMsIGJ1dA0KPiBhbGwgNiBleGlzdGluZyBzdGF0ZXMgbmVlZCBhIFtwcm9wZXJdIHJl cHJlc2VudGF0aW9uIGluIHRoZSBuZXcNCj4gbW9kZWwuKQ0KPiANCg0KU29ycnkgZm9yIHJlcGx5 aW5nIGxhdGVyLCBJIHBhaWQgc29tZXRpbWUgdG8gY2hlY2sgdGhlIGNvZGUgYWdhaW4sDQphbmQg ZHJldyBhIHRhYmxlIGxpa2UgYmVsb3csIEkgaWdub3JlIHR3byBjb2x1bW5zIHdoZW4gbnVtYV9v ZmY9dHJ1ZQ0KYW5kIGFjcGlfbnVtYT0xLy0xLiBCZWNhdXNlIHdoZW4gbnVtYV9vZmYgPSB0cnVl LCBBQ1BJIHNyYXQgdGFibGUNCndpbGwgbm90IGJlIHBhcnNlZDoNCistLS0tLS0tLS0tLSstLS0t LS0tLS0rLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0t Kw0KfCBvcmlnaW5hbCAgfCAgY29sMSAgIHwgIGNvbDIgICAgICAgICB8ICBjb2wzICAgICB8ICBj b2w0ICAgICAgfCAgY29sNSAgICB8DQorLS0tLS0tLS0tLS0rLS0tLS0tLS0tKy0tLS0tLS0tLS0t LS0tLSstLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLSsNCnxudW1hX29mZiAgIHx0 cnVlICAgICB8ZmFsc2UgICAgICAgICAgfGZhbHNlICAgICAgfGZhbHNlICAgICAgIHxmYWxzZSAg ICAgfA0KfGFjcGlfbnVtYSAgfDAgICAgICAgIHwwICAgICAgICAgICAgICB8MSAgICAgICAgICB8 LTEgICAgICAgICAgfHggICAgICAgICB8DQp8bnVtYV9mYWtlICB8eCAgICAgICAgfHggICAgICAg ICAgICAgIHx4ICAgICAgICAgIHx4ICAgICAgICAgICB8ZmFrZV9ub2Rlc3wNCnxlbnVtIHN0YXRl IHxudW1hX29mZiB8bnVtYV9md19ub2RhdGEgfG51bWFfZndfb2sgfG51bWFfZndfYmFkIHxudW1h X2VtdSAgfA0KKy0tLS0tLS0tLS0tKy0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0t LS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0rDQoNCk5vdGVzOg0KVGhlIGZvbGxvd2luZyBzY2Vu YXJpb3Mgd2lsbCBtYWtlIGFjcGlfbnVtYT0wOg0KMS4gWGVuIGRpc2FibGUgQUNQSSB0aHJvdWdo IGFjcGlfZGlzYWJsZWQgPSAxLg0KMi4gQUNQSSB0YWJsZSBkb2Vzbid0IGhhdmUgU1JBVCwgb3Ig U1JBVCBkb2Vzbid0IGNvbnRhaW4gQ1BVIGFuZCBtZW1vcnkNCiAgIE5VTUEgYWZmaW5pdHkgaW5m b3JtYXRpb24uDQozLiBFbXVsYXRlIG51bWEgdGhyb3VnaCAibnVtYT1mYWtlIiBjb21tYW5kIGxp bmUgcGFyYW1ldGVyLiBCdXQgSSBmb3VuZA0KICAgdGhhdCB3aGVuIG51bWFfZmFrZSBpcyBlbmFi bGVkLCBjdXJyZW50IGNvZGUgd2lsbCBub3QgcHJldmVudCBBQ1BJDQogICBzcmF0IHBhcnNlcnMg dG8gcGFyc2UgTlVNQSBpbmZvcm1hdGlvbi4gU28gYWNwaV9udW1hIHN0aWxsIG1heSBiZQ0KICAg Y2hhbmdlZCBsYXRlci4gSXMgdGhlcmUgYW55IGZ1cnRoZXIgcmVhc29ucyB0aGF0IHdlIHN0aWxs IG5lZWQgdG8NCiAgIHBhcnNlIE5VTUEgaW5mbyBmcm9tIFNSQVQgdGFibGUgd2hlbiBudW1hPWZh a2U/IE9yIGNhbiB3ZSBzZXQNCiAgIGFjcGlfbnVtYSA9IC0xIGluIG51bWVfc2V0dXAgd2hlbiAi bnVtYT1mYWtlIiB0byBtYWtlIHNyYXRfZGlzYWJsZWQNCiAgIGNhbiBwcmV2ZW50IEFDUEkgU1JB VCBwYXJzaW5nLg0KDQpJZiBtZWV0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucywgdGhlbiBhY3Bp X251bWEgPSAxOg0KMS4gWGVuIGVuYWJsZSBBQ1BJIHRocm91Z2ggYWNwaV9kaXNhYmxlZCA9IDAu DQoyLiBBQ1BJIFNSQVQgcGFyc2VyIGNhbiBwYXJzZSBDUFUgYW5kIE1lbW9yeSBOVU1BIGFmZmlu aXRpZXMgc3VjY2Vzc2Z1bGx5DQogICBmcm9tIFNSQVQgdGFibGUuDQozLiBQYXNzIHRoZSBtZW1t b3J5IGJsb2Nrcycgc2FuaXR5IGNoZWNrIGFuZCBoYXNoIGNvbXB1dGluZyBpbg0KICAgYWNwaV9z Y2FuX25vZGVzLg0KDQpUaGUgZm9sbG93aW5nIHNjZW5hcmlvcyB3aWxsIG1ha2UgYWNwaV9udW1h PS0xOg0KMS4gQUNQSSB0YWJsZSBpcyBkaXNhYmxlZCAgYnkgIm51bWE9bm9hY3BpIiBjb21tYW5k IGxpa2UgcGFyYW1ldGVyLg0KMi4gWGVuIGVuYWJsZSBBQ1BJIHRocm91Z2ggYWNwaV9kaXNhYmxl ZCA9IDAgYnV0IEFDUEkgU1JBVCBwYXJzZXIgY2FuIG5vdA0KICAgcGFyc2UgQ1BVIG9yIE1lbW9y eSBOVU1BIGFmZmluaXRpZXMgc3VjY2Vzc2Z1bGx5IGZyb20gU1JBVCB0YWJsZS4NCjMuIFRoZSBt ZW1tb3J5IGJsb2Nrcycgc2FuaXR5IGNoZWNrIG9yIGhhc2ggY29tcHV0aW5nIGluIGFjcGlfc2Nh bl9ub2Rlcw0KICAgaXMgZmFpbGVkLg0KDQo+IEFzIGFuIGFzaWRlIC0gSSB0aGluayB5b3UgbWVh biAic3dpdGNoZWQiIGluIGFsbCBmaXZlIG9mIHRoZXNlDQo+IGxpbmVzLg0KPiANCg0KWWVzLCBJ IHdpbGwgZml4IHRoZW0gaW4gbmV4dCB2ZXJzaW9uLg0KDQo+ID4gLS0tIGEveGVuL2FyY2gveDg2 L2luY2x1ZGUvYXNtL251bWEuaA0KPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9u dW1hLmgNCj4gPiBAQCAtMjgsMTIgKzI4LDIyIEBAIGV4dGVybiBub2RlaWRfdCBweG1fdG9fbm9k ZSh1bnNpZ25lZCBpbnQgcHhtKTsNCj4gPiAgI2RlZmluZSBaT05FX0FMSUdOICgxVUwgPDwgKE1B WF9PUkRFUitQQUdFX1NISUZUKSkNCj4gPiAgI2RlZmluZSBWSVJUVUFMX0JVR19PTih4KQ0KPiA+ DQo+ID4gKy8qIEVudW1lcmF0aW9ucyBmb3IgTlVNQSBzdGF0dXMuICovDQo+ID4gK2VudW0gbnVt YV9tb2RlIHsNCj4gPiArCW51bWFfb24gPSAwLA0KPiA+ICsJbnVtYV9vZmYsDQo+IA0KPiBNYXkg SSBzdWdnZXN0IHRvIHN3aXRjaCB0aGVzZSB0d28gYXJvdW5kLCBzdWNoIHRoYXQgIm9mZiIgYmVj b21lcw0KPiB0aGUgbWVhbmluZyBvZiAwLCBwb3RlbnRpYWxseSBhbGxvd2luZyAhIHRvIGJlIHVz ZWQgaW4gYSBib29sZWFuLQ0KPiBsaWtlIGZhc2hpb24gaGVyZSBvciB0aGVyZT8gQW5kIHBsZWFz ZSBvbWl0IHRoZSAiPSAwIiBwYXJ0IC0gaXQncw0KPiBvbmx5IG5vbi16ZXJvIGZpcnN0IHZhbHVl cyB3aGljaCBhY3R1YWxseSBuZWVkIHNwZWxsaW5nIG91dC4NCj4gDQoNCk9rLg0KDQo+ID4gKwkv KiBOVU1BIHR1cm5zIG9uLCBidXQgQUNQSSB0YWJsZSBpcyBiYWQgb3IgZGlzYWJsZWQuICovDQo+ ID4gKwludW1hX25vX2FjcGksDQo+ID4gKwkvKiBOVU1BIHR1cm5zIG9uLCBhbmQgQUNQSSB0YWJs ZSB3b3JrcyB3ZWxsLiAqLw0KPiA+ICsJbnVtYV9hY3BpLA0KPiANCj4gQXMgdG8gdGhlIG5hbWVz IG9mIHRoZXNlOiBJbiB0aGUgZGVzY3JpcHRpb24geW91IGFscmVhZHkgc2F5IHRoYXQNCj4geW91 IHdhbnQgdG8gcmUtdXNlIHRoZSBjb2RlIGZvciBub24tQUNQSSBjYXNlcy4gV291bGRuJ3QgeW91 IGJldHRlcg0KPiBhdm9pZCAiYWNwaSIgaW4gdGhlIG5hbWVzIHRoZW4gKHJhdGhlciB0aGFuIHBl cmhhcHMgcmVuYW1pbmcgdGhlc2UNCj4gYW5vdGhlciB0aW1lIGxhdGVyIG9uKT8NCj4gDQo+IEkn ZCBhbHNvIGxpa2UgdG8gdW5kZXJzdGFuZCB3aGF0IHVzZWZ1bCBzdGF0ZSAibnVtYV9ub19hY3Bp IiBpcy4NCj4gSSByZWFsaXplIHRoaXMgd2FzIGEgc3RhdGUgZXhwcmVzc2FibGUgYnkgdGhlIHR3 byBvcmlnaW5hbA0KPiB2YXJpYWJsZXMsIGJ1dCBkb2VzIGl0IG1ha2Ugc2Vuc2U/DQo+IA0KDQpJ IGhhdmUgdXBkYXRlZCB0aGUgbmV3IG5hbWVzIGluIGFib3ZlIHRhYmxlLiBBbmQgIm51bWFfbm9f YWNwaSINCmlzIG1hcHBpbmcgdG8gIiBudW1hX2Z3X2JhZCIgZW51bSBzdGF0ZS4NCg0KPiA+IEBA IC01MjgsNyArNTI4LDggQEAgaW50IF9faW5pdCBhY3BpX3NjYW5fbm9kZXMocGFkZHJfdCBzdGFy dCwgcGFkZHJfdA0KPiBlbmQpDQo+ID4gIAlmb3IgKGkgPSAwOyBpIDwgTUFYX05VTU5PREVTOyBp KyspDQo+ID4gIAkJY3V0b2ZmX25vZGUoaSwgc3RhcnQsIGVuZCk7DQo+ID4NCj4gPiAtCWlmIChh Y3BpX251bWEgPD0gMCkNCj4gPiArCS8qIE9ubHkgd2hlbiBudW1hX29uIHdpdGggZ29vZCBmaXJt d2FyZSwgd2UgY2FuIGRvIG51bWEgc2NhbiBub2Rlcy4NCj4gKi8NCj4gPiArCWlmICghbnVtYV9l bmFibGVkX3dpdGhfZmlybXdhcmUoKSkNCj4gPiAgCQlyZXR1cm4gLTE7DQo+IA0KPiBOaXQ6IFBl cmhhcHMgZHJvcCAiZG8gbnVtYSIgZnJvbSB0aGUgY29tbWVudD8NCj4gDQoNCk9rLCBJIHdpbGwg ZG8gaXQgaW4gbmV4dCB2ZXJzaW9uLg0KDQpDaGVlcnMsDQpXZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:18:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:18:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367133.598184 (Exim 4.92) (envelope-from ) id 1oBuyv-0002hx-4V; Thu, 14 Jul 2022 09:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367133.598184; Thu, 14 Jul 2022 09:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBuyv-0002hq-1h; Thu, 14 Jul 2022 09:18:01 +0000 Received: by outflank-mailman (input) for mailman id 367133; Thu, 14 Jul 2022 09:17:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBuyt-0002hk-S9 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:17:59 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2068.outbound.protection.outlook.com [40.107.104.68]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d963f0a6-0355-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 11:17:57 +0200 (CEST) Received: from FR3P281CA0025.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::23) by DB9PR08MB6959.eurprd08.prod.outlook.com (2603:10a6:10:2bf::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15; Thu, 14 Jul 2022 09:17:54 +0000 Received: from VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1c:cafe::d) by FR3P281CA0025.outlook.office365.com (2603:10a6:d10:1c::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.7 via Frontend Transport; Thu, 14 Jul 2022 09:17:54 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT062.mail.protection.outlook.com (10.152.18.252) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 14 Jul 2022 09:17:53 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Thu, 14 Jul 2022 09:17:53 +0000 Received: from 969db86233e7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 138DCEFA-C007-4352-8A16-37505B897494.1; Thu, 14 Jul 2022 09:17:47 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 969db86233e7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:17:47 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB4270.eurprd08.prod.outlook.com (2603:10a6:803:f9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 09:17:44 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:17:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d963f0a6-0355-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AbW4VT52VwEo8MXrH8ulsfrm5OIkym6MneC1KxG75i4EenE0b11Ruam26xZP2MfzjVss6xT0ny0r0K/hKVaQ6GQAN9Ox4EPhZORRvkS0SHMGewisTWZ/i1PgCnsB5Wc1KiqCv8uQwSrfWvrGbgu89VCCKUZ7ERw3UyAFIcdup76qgAxCGTegGYtqSxg2/lEVWvWk4XNLgCu2SsJah3A0YKmEtjjKMfLSIdvTerDIEcMKCyN3Ct8xprs5hFK/dvZDzijUwPLR/4ODhIzXE54g/qj9d1imqWUhPb9kYweZEQbyEmhGQq4+hXNHvlSF0oWpNBE75UQ4SWVaHoORNnw4QA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=kWtWPrNgVBC8u/1slDXk7KEobBvy+6UP0V3WsqK4TDdNuISHVlX5rIIzjWhLKc49jFJiaE2RU8YHj/3mti5nIvciLkMeWUEc5YqpCZTyrTKv7+krgxM/YbfevLZJl9NfxPNXIlqkPzrFaO4mnWPHU+1rNrX7oLXR6tZgQHfsptJvzR4wXZPcPHhjkgfIpjAD1d1TjBVPzAHiv27hlb72q+Nj96KB5czAGUS2mtPkyqxnlcXHK3DauJTA8oQ3jJg0qhPSGVIzhoOqq2dytKzAVmkc83Vd2xAzcJNaKifF9bLRd0/GpJ6A9YB7lVZJ9jAhhHzrvox2N559y5FsD7u4JQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=WjbTewEzZz359NrFu+Nv1V3HZPNeU3intQKGj0GKzpDm8Yxp9vjcimon6Z7KBbBc95fZOvY1gJzS4LFfUDoBZcCIfwpG+3F9qw18bn8/nj8mBn7O3hmkVQujX+UJtwzoKXoOAVpJzmgNLZZOmW7K2QyHImOTNIsWsVxodmkYPiI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XgtImSabczKKtsrR7bSgzNgd3UcJZGcEpXyhcUWgf6vt3qt6bdR0GrVLKe8Sa2jYmFgzFWd45cjd2unpgS2+oriEBHsoN9+2j56d0o+mjCNUJzUmQ2y29h+2C4/F4hdUHoGMje1FoSm20Is0eXJg/K7u+Vl/2hRUMqxsi2q9zp/E9qRKeM6d3prfTW8aCCjVCTAQMv+F1MYcqTbAvia/DEAkDXsony81kACJOsx2xaawZ9iX6woNj1daD79deVoL5XmJcFkWxE6JZ/c9r/qGYUx7fsjuzWhAEeWLtp10y/PjHJ1J+kLyaLUgwValBkIxXYhlYx3UVUBI5aIkpLfXqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=ga12MosjF8XnuFJq+51GCOmII/n/XSgpbX1kmYxuymRvSfrbZ1C7QZKE1zwC/N3f2x/DLt8mO98EYl51Tf1amLA/atimvCzcvXbD+puldhScqJNFyYQNK9cn0au3m4OFfpDX5jFNA52JGPbDzMa5dsQzsLed7fSCLmwI7Ea7QDEFNEUFQdWBV5wnX34trEEY+8/a+r2yYV8UESJ+IaIGSGccVFde54jiM0hU8UvkEy6sSe7wp7hPprDu9zF2lFW9KYoJBdaP3pN8wGLMuef4c3xR/57a09zNw4MY6F9OyiKzOnFUd0uBrdVJws4+jJV5f6Rg5X7GbtbXmovjLoci7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dHIaqGKAV4GSAaAAgx/n/6Xin3AeRZwXkbmphePOUgE=; b=WjbTewEzZz359NrFu+Nv1V3HZPNeU3intQKGj0GKzpDm8Yxp9vjcimon6Z7KBbBc95fZOvY1gJzS4LFfUDoBZcCIfwpG+3F9qw18bn8/nj8mBn7O3hmkVQujX+UJtwzoKXoOAVpJzmgNLZZOmW7K2QyHImOTNIsWsVxodmkYPiI= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad Thread-Topic: [PATCH v2 7/9] xen/x86: rename bad_srat to numa_bad Thread-Index: AQHYktrEQRgCjYljLE+D+LLS9lLfW6160MYAgALOd4A= Date: Thu, 14 Jul 2022 09:17:44 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-8-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3EC4D5A975DC4143ABC87AF5D533560F.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ae72757d-2939-422a-4787-08da6579bb84 x-ms-traffictypediagnostic: VI1PR08MB4270:EE_|VE1EUR03FT062:EE_|DB9PR08MB6959:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: e6zpfNVxFmNTupgDzDJDlL1r/lF+pkTH/NJaY1Vz9LHOZzBeLCEiFrzx9oslqBFOiU0JWGpgeXiPkEjVxa2WWt4QCxixf0pddVoHHz7tfLd+oUmoupLENum9aKs79TbCWSLc+GoxDNYYlpH0DRBcxRtPoEjR+gkEneCvvqA8mlRwn1ZGRH+GIhTCqwAcJgEBp9lS9Jmtvi6x4Fe2g2rgF6dOVSmB4objLSz9mPHocSGsTtdibd7Fz+ms2kOxLNXIIaCCsMeyZpBWgIhemebblgXpnf1qMILhjoU6ce1kTGkr/aAK7aPldNBsuWepIZQs7srsCuUky8q7YMo1m70i8uBEHcbG25lLeCHhZdqDyy57QoTaHNcUpLMQi+gMlRhptXyogYbwZ26PN6XTrBZlJNKiIZKTsh1IPKZzZ4f0oikGcdF6UqqMsBogAtn5Vxtm4uTYxgmcTieejU/ENP0CS5zU2rkzSOCayT2lMg4Jux2I814W7yyClEVJJPF339DBch5KfSmJ0MOyVRa4yJHHR+QIcGKBQcW+oL0pnjscgdURefSxHpVraU6ICa7puG6nMf41Zga0kNJZJyrNj4Pgtn4maTJ9ICDPq50RMh7AktVZFCVF3q1fqFH/wUsv5VLPhghM5qEiNxpnTsxENTgA709LwAo25BKuvItZgQ4Z+ybKDCNj+yFjfilBoFMK6gehFrVwt/s9etfmbYuExNOsjYhfdt/au1GJMYbGSW3iAOKqRbKS5Akgt3N6OxNsWX2OZw5EiRq6YcABMLFJv9TzaoUjxAo4ygNK1c8+NFZJp3yYpFeGHF8ZAAV7KaEcr+Lj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(6506007)(478600001)(9686003)(7696005)(8936002)(52536014)(26005)(53546011)(122000001)(2906002)(5660300002)(38070700005)(33656002)(86362001)(41300700001)(186003)(38100700002)(55016003)(83380400001)(4326008)(66946007)(66476007)(66556008)(316002)(64756008)(66446008)(8676002)(76116006)(71200400001)(54906003)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4270 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7dfb751f-41f1-471d-3f53-08da6579b625 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7ynNMgYM6cD+kzrmwBIN1Qo+1VdLnYeOrwYjAZ1jNVd3qBmcvl55pd/cm+Tdoby625YNPTvuPK3lXKmJmaXJinsTkI7JnvjpjR7L4/Mbdb89dNvY/zUxIE0/Rfr8B7cmwqLSgEaCdm5ixf3mIxRLdzQQB9x5A47XK/o48CHmyrqoh7IsRFqTvINKF3ZoApHdBs01VQVPeFOXQOGlX39MqyMrpztfM1LoFY2j7DYmg5waCveSZiZqErSF+7BE7hwJDRU354IMfNPBa+ToMJPnDE2uEItouyaw3KUMfGzazFDOhc2wRpp0LLsypEEik3SvPed0crAEJpz3UEf5cCMtUqlpIdUMTtvzlK1cUxn0db/pEgBeUtrYR6Vkpe0dg11iOxuQ5g7Tl9Y8eWb4GCy3mU5JIXKOeMNtOAdZybJLnh3nBKfY3sKu0Vk1IJv/UfVqjTWhW9ispkzf3ZDuEeNhdBRBPpWgu9DLy4Ceflat682/oqEYISbbnMUXn7K1bHCMLjrhp9GfTu9O5iohbXtfJbh8d/HeSSLYcLnaUOdD7XI5gO6RSLuxFnYROwwwncq8XtD+8M+TO7itsdH/zkmj+kCBQAy5OClocHhPw7REnhYj1ajpbrNzx8qgT6PP/AdyqWE9iTELL9HxVknpgeAuK1AJ4j7B8aglabSEQXv2+OO/rnDQUAAafdyeJC/k6fUVQs4Ck15ybKDaQwfZsXE9LGLJkZz6rpV8ixHSo99yAIuC9WOM8rE3gp9eC/jL2o8+m8JvdVVHBdugftjBckbkCVf4Y9V2W1NIMgIKqyQz4uiy83IN11xqso4Axbs7U1S8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(346002)(396003)(376002)(46966006)(40470700004)(36840700001)(478600001)(47076005)(36860700001)(2906002)(33656002)(82310400005)(336012)(26005)(356005)(55016003)(40460700003)(83380400001)(316002)(41300700001)(7696005)(82740400003)(8676002)(52536014)(70206006)(186003)(4326008)(86362001)(8936002)(5660300002)(54906003)(81166007)(6862004)(70586007)(40480700001)(9686003)(6506007)(53546011);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:17:53.6709 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae72757d-2939-422a-4787-08da6579bb84 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6959 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMjoyNg0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgNy85XSB4ZW4veDg2OiByZW5hbWUgYmFkX3NyYXQgdG8gbnVtYV9iYWQNCj4gDQo+IE9u IDA4LjA3LjIwMjIgMTY6NTQsIFdlaSBDaGVuIHdyb3RlOg0KPiA+IFdoZW4gTlVNQSBpbml0aWFs aXphdGlvbiBjb2RlIGlzIGZhaWxlZCBpbiBzY2FubmluZyBTUkFULiBJdCB3aWxsDQo+ID4gY2Fs bCBiYWRfc3JhdCB0byBzZXQgZGlzYWJsZSBOVU1BIGFuZCBjbGVhciByZWxhdGUgZGF0YS4gQnV0 IHRoaXMNCj4gPiBuYW1lIGlzIEFDUEkgc3BlY2lmaWMsIHdlIGhhdmUgbW92ZWQgZ2VuZXJpY2Fs bHkgdXNhYmxlIE5VTUEgY29kZXMNCj4gPiB0byBjb21tb24sIGJhZF9zcmF0IGhhcyBjYW1lIHdp dGggdGhlc2UgY29kZXMgdG8gY29tbW9uIGNvZGUuIEJ1dA0KPiA+IGl0J3Mgbm90IHJlYXNvbmFi bGUgZm9yIG90aGVyIE5VTUEgaW1wbGVtZW50YXRpb25zIHRvIGltcGxlbWVudCBhDQo+ID4gZmFs bCBiYWNrIGZ1bmN0aW9uIG5hbWVkIGJhZF9zcmF0LiBTbyBpbiB0aGlzIHBhdGNoLCB3ZSByZW5h bWUNCj4gPiBiYWRfc3JhdCB0byBudW1hX2JhZC4NCj4gPg0KPiA+IFNpZ25lZC1vZmYtYnk6IFdl aSBDaGVuIDx3ZWkuY2hlbkBhcm0uY29tPg0KPiA+IC0tLQ0KPiA+IHYxIC0+IHYyOg0KPiA+IDEu IE5ldyBpbiB2Mi4NCj4gDQo+IEkgdGhpbmsgdGhpcyB3YW50cyB0byBjb21lIGJlZm9yZSBtb3Zp bmcgdG8gY29tbW9uIGNvZGUuIEFuZCBJJ2QNCj4gYWxzbyBsaWtlIHlvdSB0byBjb25zaWRlciB1 c2luZyBlLmcuIG51bWFfZndfYmFkKCkgb3INCj4gbnVtYV9maXJtd2FyZV9iYWQoKSB0byBiZXR0 ZXIgcmVmbGVjdCB0aGUgb3JpZ2luYWwgcHVycG9zZS4NCj4gDQoNCk9rLCBJIHdpbGwgcmUtb3Jk ZXIgdGhlIHNlcmllcyBhbmQgdXBkYXRlIHRoZSBmdW5jdGlvbiBuYW1lcy4NCg0KVGhhbmtzLA0K V2VpIENoZW4NCg0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:18:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:18:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367136.598194 (Exim 4.92) (envelope-from ) id 1oBuzS-0003C1-Di; Thu, 14 Jul 2022 09:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367136.598194; Thu, 14 Jul 2022 09:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBuzS-0003Bu-Ao; Thu, 14 Jul 2022 09:18:34 +0000 Received: by outflank-mailman (input) for mailman id 367136; Thu, 14 Jul 2022 09:18:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBuzR-0003Bb-38 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:18:33 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edd024b7-0355-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 11:18:31 +0200 (CEST) Received: from FR0P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::23) by AM0PR08MB3844.eurprd08.prod.outlook.com (2603:10a6:208:101::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 09:18:29 +0000 Received: from VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:15:cafe::9d) by FR0P281CA0018.outlook.office365.com (2603:10a6:d10:15::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Thu, 14 Jul 2022 09:18:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT032.mail.protection.outlook.com (10.152.18.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 09:18:29 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Thu, 14 Jul 2022 09:18:28 +0000 Received: from 40f132e111b6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 336090EA-058F-4BC7-A274-C60EAEFB24CC.1; Thu, 14 Jul 2022 09:18:22 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 40f132e111b6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:18:22 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB4270.eurprd08.prod.outlook.com (2603:10a6:803:f9::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 09:18:21 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:18:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edd024b7-0355-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mSANp9ELcYoSR5k2dNGaA01H2HC+qZ7hvjiepgwE5oYVZCm9VjW95gnEMEyp++VbYtSKxzH0qf73U9GuAy14pFCv1GDMA/3gQefqRMjRSveB2Y8YyoFqMR1zKAqlQm/3gyBrt+01T8zKvF9yUfTOWdZXocTinyjh8ZlXIIxZpCsyWvri00umGDFAyS+h6vCf+Twba1Jwb5uxSg2GXMBJQGQj3NXio0iqtbc5LlGiyzBC1TcJLDNsrntf7I+UViDS/F8fOuciT8ClyBLip6g9wNEVHiooF6BDwccRHQroXktzPCbWDNVX/Ypl11px+IioOf8vAi81SKHFcJZGj3DnSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6RLBzkFkt2bartYGr5T9EvpA4ljTjXS/JEPyvVx+Kmw=; b=dDkLaisiAPNFUSiwX9FbP+BlCOYjxV9PdVGbhX20YwH4f16m+86B8bDImOp01QhBVpyaFTvhrdAMz0gkcMgvOJeRha++mOCQkiEYVGzzlNuhe5VH5v56/SAY/DT40vCrNju0o+NvHZJk68tEhkZPP/KqkED4SjtJCnQLKR9kQAPeEJq7Lpy0B6e9tnQcWfEK7u3ExcDm0D5BmR7BOzXy2FMmNxEcuRly3hLfKcEm2h+0L2C83zEHAcvf/D6iX+Ifaw3BVDWJ8z+dibFZTorH0u1jzKuh8Bp0h3VWyDYyH+rGZp7Z+0n7lLWCYsIcb8CVDDqi3BH390sYXpCmSmsHJA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6RLBzkFkt2bartYGr5T9EvpA4ljTjXS/JEPyvVx+Kmw=; b=stX4iRE7gqe25R4MzmPwKr81lLs8bzLSLiqCFFEbyJBMl0OdNrlqmuAbcLPaCKHuF4BznVEC7HmuJm9gaCKGrTpGn+LepARF9eR3sPI+bvnVVzpUISOlSvY3AGYHffvnbNFHDnrKZcU0z0qS61R5Cy6jqPvxuk6FbUser8eetc8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mSvDvMJxkMy9fVLV8t+DvCYTxo4TZ4JhLO1vv1ySO4zYBYyoI21KpHtjq5NLKW0oPtm9C8gYR8xT2gJ1ZkspkwvD+tIUz1WMg2PDKP6QXKp3uhL8f/QCBtKatqH00KxXo3+AyhVx915hj2CUO40UZeH2or96E8YiJCsuUQ9NIX8mPnIu0sa22v7RTkzJwD2/riRZSgf2c96zZTUodFcts0lFkOc7gk8IXeS7m4p4MCF+kUVF3z8Kta5hO5Vt9n8+1NVnuX08z/aLjsYswO8gpTgrMJXVyT1iQ09l1wtWo/KG+3aOLufV1f/1bdOUJP76SHbje5L7ZbtChCbYwLaB8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6RLBzkFkt2bartYGr5T9EvpA4ljTjXS/JEPyvVx+Kmw=; b=is3xsWQWtBVsIYgqGekg9ACHAyIvMJEp9fTZkCvTAlPX/dH9jhKPOl4Ah/ScoRlElAPBDCuzCROXD3rouf93PAZPlBfaqMDtQifQOtoHSf+lHPM7EMfoCU83N5faOejnvgRWuiNBiGra/uVMSIk0BTV0DydUMD2wWH+G/LMNYDY/jf7zeMnDogaSnoJtLBqGpLaP7weF4iBWu7vWiVPqexGzr9TlrxMDnhOmUO9k8M7rM9dRtTM8hlA25JeVJTlc8yNd+FA68FXSdiNDg0ypfUR8E2zkTSrzFH3MW22h/84QHj8bJ/J81AbcoIXZOI5WqsjgLwgCXqgNceAUOxTfcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6RLBzkFkt2bartYGr5T9EvpA4ljTjXS/JEPyvVx+Kmw=; b=stX4iRE7gqe25R4MzmPwKr81lLs8bzLSLiqCFFEbyJBMl0OdNrlqmuAbcLPaCKHuF4BznVEC7HmuJm9gaCKGrTpGn+LepARF9eR3sPI+bvnVVzpUISOlSvY3AGYHffvnbNFHDnrKZcU0z0qS61R5Cy6jqPvxuk6FbUser8eetc8= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 8/9] xen: rename acpi_scan_nodes to numa_scan_nodes Thread-Topic: [PATCH v2 8/9] xen: rename acpi_scan_nodes to numa_scan_nodes Thread-Index: AQHYktrQSxGeD9dw606vij1sbUd1TK160UiAgALOLvA= Date: Thu, 14 Jul 2022 09:18:20 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-9-wei.chen@arm.com> <1796ff82-6c48-8eb5-9c68-1e84de51bb2a@suse.com> In-Reply-To: <1796ff82-6c48-8eb5-9c68-1e84de51bb2a@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 827D698F2AE9774BA70FE17F47D8D10D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: ea095d8a-9d28-4b25-76cc-08da6579d0c3 x-ms-traffictypediagnostic: VI1PR08MB4270:EE_|VE1EUR03FT032:EE_|AM0PR08MB3844:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Uft/I/CG4Af4Tm6UzyhOyfS7wRJDMZwMp9JhdRJK/Bbzl7SHxyoXO5gW+8t0g/iYcILGkRnAgdi/GHlTf78DQdveMJRz3Kg3EadceaRS1tH8hid4Hmq8urYWL2aq0+/PsNV4FsV4q2XbqPn1zKhZZm1G3/Ck0973htdx4c0dJOUnucjloAEkAdwZlNeUXoGFP9kMWEY035lY868KiGRiuzG7+xm/MoRKNFOwfMjjpn4zW9UUDhQYz0SEe+0DMO+kIuOOGsfgjcAZKNP+ty6rtYXTvY+h6vKU/3kVrFunV/cdroxHh4HSTkcanpX2GDhjEkX25kCmwXBPGx4ce5yoqSq1hxH7I18vLgQGIuLsiTFFtHHCkN/0xItCKgTcmjxOGJhtpN9xVUWeeplB3sh4w/wUTc+I7NlKX9CyFSLYXVWjPJuajRW3bnAJVNouTRFPkmHBladCYxDpAXG9p2dGGltNU/ckxt2wV4Gv2AWsWMxEcphY1b7hu0CX3Ge+GNe4WN0BKyhwc96gUN8xXBoEaPTseTdlDmQ9+ey/5OzdNx45JWmO6fAs+0IDfijyh7u39tgYIwZiRYqL8SapfW3LOJNvcibY08l36FMtSiYcKoJSwHDcDvdjZCGFx65IIfPlX1+4lUKJ4zUsFXLxa6CrrEL/Fr6JAwZpxRfJl1ikVJyQck+361spZ95smzL7SnwJ34ZfsuTU1QZ6vDeVpMtnJCUCxr3ZetiZzf9toOgJhPJ4vpaKwHuZUueMDFeJw9oOkFlCGVoOWZ9y4YoYmRspnis2flbo4UQptFRucEIb18T7T+9W1oPDvTcxQfiUFaKp X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(376002)(136003)(39860400002)(366004)(6506007)(478600001)(9686003)(7696005)(8936002)(52536014)(4744005)(26005)(53546011)(122000001)(2906002)(5660300002)(38070700005)(33656002)(86362001)(41300700001)(186003)(38100700002)(55016003)(83380400001)(4326008)(66946007)(66476007)(66556008)(316002)(64756008)(66446008)(8676002)(76116006)(71200400001)(54906003)(6916009);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4270 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d90f0db5-9948-40e5-25be-08da6579cbb8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dn49P6tezm6DLhLtN1TAeyhpPINMrfX/ixUlhvuK6ASKvjZRKbJUNZ4XBVYkyYDfOURBIpuyFsox2aRs+gW7Bkez7sduxFGwAb5w/DsxjRhgdrGuG9BJpHvbo4KaV/nNZ2jpSmxjbqvfwmaNpWp+GWwrZiKwtvpW+onAwu7mpMafJY2cnBwdbRPNLRcMGG2Ws2fwQ5UMpM24M/yu5bk6+6D1FDtI73EWfjumTbH82rlQ09ljsn3xZNu/TUGxyhF/Kc8JjvqgsLFDgOqTDrTsuLs9dRiJ6mN7DbnfQ2vZIBCGqVU6Z/cYH6SxhWQpA8Y5CAlQ7qc9t2iJgVD6+talWm3hLMMppWV5D/DRrHwFHEdvYE0An+0QcjC+w72GSWzrNXcu9gBsGDL0C2+r0i7uls+YJRp1GiXaaWtxKSbA3WXeFKTzTxpXIR7b2cS4LU/3dBTddCvBkdt4Wxj1OqgrVjVv8Du4T3/A1QdmwfUwokDsn1pU8oIYAoNfnBJiq1Ylrs+BHzB7sJt9IFj7FtaQSmzZJ0sGVmcO4uwYVlYsnfmnrC+azioFc9jM0o+OrYg1j4u28Qyh7wUXtXg486J/O3izk1YyLxcqF7aEu2oDOF0G+p0u+5iKewHax8jV49QiquK6QmY3c6WPqslZuJ2kNxkeiSuDAdMN2aiCis/+kg57u6Pq2XLwHd9xbrPzoSXbj0Td062zbTT/v89vr8VwAJMuS5XY5WkaT+qTG7totxhiqHkqm5YiGwSv9bP33xDnLBvzZm1MuZRsguGhnLmlTF3MBcFQK0WBJ92snb1FXno8OGG6VSgUJ8z4PUD5CLfy X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(40470700004)(46966006)(36840700001)(54906003)(52536014)(478600001)(316002)(4744005)(55016003)(8936002)(6862004)(8676002)(83380400001)(36860700001)(33656002)(7696005)(5660300002)(40480700001)(40460700003)(9686003)(41300700001)(81166007)(356005)(53546011)(47076005)(82740400003)(2906002)(6506007)(70206006)(70586007)(86362001)(186003)(4326008)(336012)(82310400005)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:18:29.3015 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea095d8a-9d28-4b25-76cc-08da6579d0c3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3844 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMjoyNw0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyBHZW9y Z2UgRHVubGFwDQo+IDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1 bGllbkB4ZW4ub3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwu b3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgOC85XSB4ZW46IHJlbmFtZSBhY3BpX3NjYW5fbm9kZXMgdG8gbnVtYV9zY2FuX25vZGVz DQo+IA0KPiBPbiAwOC4wNy4yMDIyIDE2OjU0LCBXZWkgQ2hlbiB3cm90ZToNCj4gPiBXZSBoYXZl IG1vdmVkIGFjcGlfc2Nhbl9ub2RlcyBmcm9tIHg4NiB0byBjb21tb24uIEJlY2F1c2Ugb2YNCj4g PiBvZiBvdXIgcHJldmlvdXMgd29yaywgdGhpcyBmdW5jdGlvbiBubyBsb25nZXIgaGFzIG1hbnkg QUNQSQ0KPiA+IGNoYXJhY3RlcmlzdGljcywgZXhjZXB0IHNvbWUgIlNSQVQiIHdvcmRzIGluIHBy aW50IG1lc3NhZ2VzLg0KPiA+IFNvIHdlIHJlbmFtZSBhY3BpX3NjYW5fbm9kZXMgdG8gYSBtb3Jl IGdlbmVyaWMgbmFtZQ0KPiA+IG51bWFfc2Nhbl9ub2RlcywgYW5kIHJlcGxhY2UgIlNSQVQiIHdv cmRzIGluIHByaW50IG1lc3NhZ2VzLg0KPiANCj4gT25jZSBhZ2FpbiBJIHRoaW5rIHRoZSByZW5h bWUgc2hvdWxkIGhhcHBlbiBiZWZvcmUgdGhlIG1vdmluZyB0bw0KPiBjb21tb24gY29kZS4NCj4g DQoNCkFjayBhZ2Fpbi4NCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:33:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:33:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367146.598206 (Exim 4.92) (envelope-from ) id 1oBvDU-0005lm-Mv; Thu, 14 Jul 2022 09:33:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367146.598206; Thu, 14 Jul 2022 09:33:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvDU-0005lf-JU; Thu, 14 Jul 2022 09:33:04 +0000 Received: by outflank-mailman (input) for mailman id 367146; Thu, 14 Jul 2022 09:33:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvDT-0005lZ-H2 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:33:03 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2061.outbound.protection.outlook.com [40.107.20.61]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f4913cb9-0357-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 11:33:02 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7998.eurprd04.prod.outlook.com (2603:10a6:102:c5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 09:33:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 09:33:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f4913cb9-0357-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TJt4BkVggjUpXAIezAAB9JtzZwX0uH+pqfbRo01I6oZJMXHaHtw2GMaWf+kATY4WlZsvuqJ1JSxAbfIMHwm10mykRFV8WJObweT/uN7EpuAqo02XcKu8pV2grKzXbTqRzxqWIEUFrtE31wHU9ddXIFxVbnD2CP6w9iK8HhiYLjx8t07mFRG+Jw8SUfxJ0KdNp8kp3CsakpP429BeQcufrOe0G4WE601Da00nJ5E+KftCsw85TZRoD47Ozr/L45oMX3uLZny+JPvvKqCGKpllIySCzNWf9A2BNK3U1/56JaqZ+/0GNGANtv8dX8YrsNTHRxhN5YE+VwbdKUnoV9DtNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=94XitmqY8VfE62voQ/Qdjh+YoxzpIhHUJZ900TeyxGQ=; b=O45jHPFGvPoPCOP3re+rHRMu+DA0CLzMPNnlKeYR5hDiPXOJ31fhlFnUTlWp/jRHpwKqQD2+fRguAgxbKdAuS1263YQlg9GAJtWUlfJ1FFTxTkmJiKFluooL/3wjhPFk9E82hC1G+F24tQpq5hXgnFsIfUPWQIJrdhDUl3X6BisoT/hoqUoBNMfeQgdxqV6QxFjmUKStb3WPbJqWsFxDDFpHOVq74114z5LD1vI4BjWzXD+gV/MS2C7uqJWnESYcFwsfjZ6joNAtyB6wmIs/HY8O07/esriDRwhj+fqLQwer94xGpqlP5JOfNeLHpt0s/FeEZQ3VIYX4UhMOF/KA0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=94XitmqY8VfE62voQ/Qdjh+YoxzpIhHUJZ900TeyxGQ=; b=Cq7yOw6TJ5qx65Zh4UopkiML10h4fIwvBXGQwES9rWV2hDQHs3SCHsvIoY3FLColR7Pt80sRiu/iWLazRNj1ZoadBvPIKc1Dh6rJBVyWZ5LPFfRWJmSogZbshjm9xxylpe3hloeiWtt7GiNRa8r4s+xal3FnP6o42WMgUgG+eUuOKbsO/W3lvFdzaB1Y0x6ud59IKNc1yBqYfP9a95dnkaxXdWcuIParuoujrgvJG+1r8xcrqSNJ/i6VSEoNDEMk2suOARF/8Oh0KSIdhDispx+o3R2Sxu6kgFHyFlByZyqhDy9L5ftY5WSs6N3Z0Pbicxxk11L6gdcuKDHL8MVuWQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 11:32:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM7PR04CA0025.eurprd04.prod.outlook.com (2603:10a6:20b:110::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc5ca24c-0fd9-44ca-08a1-08da657bd7e7 X-MS-TrafficTypeDiagnostic: PA4PR04MB7998:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /fNvKBl3gfbBKGZD4qzywWYNA/TeIsDyxPPuZvGjrvS1jfuiKrNSFa6oxnXSYFVnnJYIArvDYgLkvghdHUlKA5Pm/Ume3N2aWAATvUYNJK83mbd5I9sG09ocdaxzsi1ENYpFm+7Kw8NovMgc/ZIVJkkrZ6kmmtLUWHujCxzJA+3YuOQJ0/ez37D2rHbLFqbHLSj07sAfcixNjEpUCXLWWPiTjzZVYXtU4XqSWhQNVOoWEP/LR1PcbkDYdmFcbcLnHi2+MZ+oaIGDKSDgXaW0pCHJGbFocpsxhDfutWTzmD9mjkKhJx5xp2MPOYty/F46ypLRp04jMYyAh2RaFWu2Ey80LEb2/jMwhB6oDobODv4gPnshMoPdGcUCMwa+U2v3lHogTNyjWTEs/YUOJjyFDAmJop2+sWxbvUm2bv+U3QEVadqHZV36rKFB1SGeJaSCM725lxPKc85GOiafl7dZo5wUlWI90S/oNlL7HdcJGDPWy5xZalyCcw/3++F23BFmJkE/ODaTmHifiKwZ881Zr2OtcQtOnJKh2ErtzZWDraBRx9GoK+vneIUUrnniTcWYm4Jh6yMb1Pr0eDGvTR2ADt2S+oBWJlYqhgnpavr2/HFVVTB4jFrUSkk87W/9sYdwUOIA8WRb6s+4mZC8Tr9U9ihhInaHJNJIbTYKJS8xSjk3wqG9VBjSOG8qi77npLhWAYFaiaHB4TlLMrObrJV3GU8XFk1gyw8aGFDz3lUFei6dLuqplo6GNH1ewaCh8a/8bfB+yoFb9pzk+eaKHD1YS5hMcAinY176HqOeDNrYVdMtfr8ZZeGX7PLSO4w43QLb+Li6zuTDQu81XlMhL/oZ9QwqoHHGMe8c4tfwurFV14g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(396003)(366004)(346002)(136003)(36756003)(6512007)(2906002)(31686004)(41300700001)(26005)(2616005)(4326008)(8676002)(38100700002)(53546011)(66556008)(66946007)(66476007)(54906003)(186003)(8936002)(6862004)(5660300002)(6506007)(86362001)(316002)(31696002)(478600001)(6486002)(83380400001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0d0RnoyZlhrMHVGS245ZnNSQlc4L3MySUxYak92S1B1V3NIbExuOHNOdnpH?= =?utf-8?B?cmtacmFlM3JZeWdGRGZldThvWkMrUGRPQ1NlM0FyTDVoMC9IT1RpNnVLaVEv?= =?utf-8?B?alkzNXprWWY1T2I1VHlSMUloWUVublo2S09nSEhiRWg1WHREL0dOcmo5Tzlh?= =?utf-8?B?NU5aUzEzdjFSaGo3dEZTU0RKWmcxeUN5TTFrbDFXQXJhMHl4cVpnR3BwN0dS?= =?utf-8?B?eStXOFdiWW5pNWNvbFd3ZDZqcjkrOHhIYmJKcStCekZGaXpBYnRDQ1MxUWNr?= =?utf-8?B?ZnpVcmVsZkZ0RnZFYmIrdjVCbTh6TlQ5Vmh5TzdGVnNDVElmWUJTaVgrQkQ5?= =?utf-8?B?cWRPQWVibHRuTU5JT1lEQlVaell1QVJGWGV2R1lqa1hMNndhMzlSVm1Od1VF?= =?utf-8?B?T2dtZElEeUZQZzRsWklXU05BWE1DR1BBVVdYcnoxUWd1WUxxZmJTYytmZmcz?= =?utf-8?B?V1g5ZURqQmxBc29zeHltK0xFTTBJOVlmUXR2bW1ZdlEvcTdWbWRaM2ZYaVh3?= =?utf-8?B?eTVPR1Y3VWo2Z3FycHU4SGIrTlNIZ2lGanZEWmhjdkFMVlluM3pIZVRTdGpJ?= =?utf-8?B?cDFsdlpFdGd6b2xWUlpkNE1ZZFNUOS9JdUsyQjBncXZxdy9PV29hZnp2NzdD?= =?utf-8?B?SUFzcTVwQm5wZjNmUWVsVnVhVlJ4ZlZGV3BPV1k0THprR3hNeUJmZXg2Zmtx?= =?utf-8?B?ek5zWFBJVEpFc1VZeTBvY1Bpd2s5MGhlbWhJcG85NEVnQVFTZHdhS1VobW5k?= =?utf-8?B?dU45bmVvQXkwME15cjJTRmtQcE10U1RuSnArZnVmVHIvdU9GL0haZ056SkJn?= =?utf-8?B?Mnk4cjNqM0I5dEoxUjQ5cU9TQ3hDS014cTNORXFJMUIyZmFCWjdyTWh0Y2Er?= =?utf-8?B?ZkFnQWpycEhNUWVlcXpIRGFTZDhQWUx6clRkTkxERGZKN214ZTg3eXlRT25n?= =?utf-8?B?b3lPSGRMMHZqbzBEZXNEbGdiS21rL2pCZXBjYlNWblQvc2poOFVFd2RVMHBx?= =?utf-8?B?allZeW50MU1pYkIrNG9TV0ZKTzdrM1Vyb1BYWi9uTW4wOHhVQzVjWFladkJt?= =?utf-8?B?SVQ3VDhLaGREdTBycTc4VktZa1NRNmNVNXVCUHJCQS9IWVp6NmFNVmRYOUtp?= =?utf-8?B?eDR2eWRaV2poajFEZWZUR0NDRCtrc3UyRWp0S3NkeHlDVkRKcG56VldKSW5y?= =?utf-8?B?S29yRmo5U081bk1FSmp3b3NIZ0lDZi96c1NUeFFQZFA3RHZ2Zm1KUEI0TnBu?= =?utf-8?B?djdTVFQyTkFNRGpaRFgveWd5a2txSmVzTVQrNTJWdTdDZUhrTmpJL2d2SFpq?= =?utf-8?B?aVAxOVJWUi9HdUpQKytUZjJ5Qm9NU1JuNE9XQktDWGlQckMxU1Zjd3VSV2R2?= =?utf-8?B?bGpkK3dpOEE2SUhJT1VIWk5oMTdCLzk2TlVkMSs3UzRLUzduU3U5WnAwaFp6?= =?utf-8?B?M0NHeW5rekFDYm5JYTFDM2tUTUxHcy9PL0k2VTdPZzEwVlFITzZ5ZGp5dC8v?= =?utf-8?B?anhXYkdNdm5GdTdHby8zQlhIN1VtMTNBaU5BbmpYYUNiNnVKQVdEWFB4Unoy?= =?utf-8?B?eWNwU0o5L045dFhqY2pKNUNLU2ZvemQvQ2F0VmYxZERlOEJQOGZBbHJDYnVp?= =?utf-8?B?ZStSc3puOXVKcDJYblY3cUdWSEtyTkJDUGtFYlN3dFQ2U200R1FVVkgxOGVV?= =?utf-8?B?SFpMbCtBSno2ZjlsWlZPN0hGZ3pTYWdBMTEwRWJhZ2lycDYxK212MkgyK0pR?= =?utf-8?B?RG1yZGhROUZGZnU4WTQyc2ZQdzBlR21PYlVtY3pkL011S01qVHZJTlA1TG85?= =?utf-8?B?dVF0cmN6SDhzdU1mT3BaY1hRREtaZWNRM1ovZmdYbktBQUJqOTZFSFNHSG1I?= =?utf-8?B?ZTBOaXlQcnlQbzk5YU5vQ1AveFBhT2tDQXdQUWIwanRRcjBnRW42dlJLYTJQ?= =?utf-8?B?T0Z1QUR6Wis3TmZWQUdTZXhrcWtrc2dDWmIxK1U5eE0wUW5mVlQ4aTJ1UlNi?= =?utf-8?B?K3RmbzJOZXhQZVoyTzRDMXdGb0VsT0hLSDVtY1g5RDNHSDU4RVd0Rnp6L3BO?= =?utf-8?B?dXBVbXY0NHZqTmpUZnA1NlM2MzJyTkU2UE91MmVqVG5QRTVRdDR5amorTEt1?= =?utf-8?Q?KUpvzrSoBZ0MJS7ovJbNyroOe?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc5ca24c-0fd9-44ca-08a1-08da657bd7e7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:33:00.5534 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iz0HxGW1eEi+XmRA6M3975PvM652LgYco5w5EzelkM0qygUePMgIBmPNUz05rMS+R5QUwOFbI1poMgP6kHJEwA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7998 On 14.07.2022 11:03, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月12日 20:49 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; xen- >> devel@lists.xenproject.org >> Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA >> status >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> In current code, x86 is using two variables, numa_off and acpi_numa, >>> to indicate the NUMA status. This is because NUMA is not coupled with >>> ACPI, and ACPI still can work without NUMA on x86. With these two >>> variables' combinations, x86 can have several NUMA status: >>> NUMA swith on, >>> NUMA swith off, >>> NUMA swith on with NUMA emulation, >>> NUMA swith on with no-ACPI, >>> NUMA swith on with ACPI. >> >> Hmm, with both this and the actual change I'm not able to convince >> myself that you've expressed the prior combinations correctly. May >> I suggest that you make table representing the 6 (I think) >> combinations of original states with their mapping to the new >> enumerators? (It doesn't need to be 6 different enumerators, but >> all 6 existing states need a [proper] representation in the new >> model.) >> > > Sorry for replying later, I paid sometime to check the code again, > and drew a table like below, I ignore two columns when numa_off=true > and acpi_numa=1/-1. Because when numa_off = true, ACPI srat table > will not be parsed: While I agree with this fact, the problem is that there are two independent command line options driving the then single variable. IOW numa_off and acpi_numa both turned on may still need a representation. In fact I'm not convinced we can eliminate the original variables. What we ought to be able to do is consolidate their values into the one single new variable you add, before ever evaluating anything. _Then_ I think I agree with the table. Jan > +-----------+---------+---------------+-----------+------------+----------+ > | original | col1 | col2 | col3 | col4 | col5 | > +-----------+---------+---------------+-----------+------------+----------+ > |numa_off |true |false |false |false |false | > |acpi_numa |0 |0 |1 |-1 |x | > |numa_fake |x |x |x |x |fake_nodes| > |enum state |numa_off |numa_fw_nodata |numa_fw_ok |numa_fw_bad |numa_emu | > +-----------+---------+---------------+-----------+------------+----------+ > > Notes: > The following scenarios will make acpi_numa=0: > 1. Xen disable ACPI through acpi_disabled = 1. > 2. ACPI table doesn't have SRAT, or SRAT doesn't contain CPU and memory > NUMA affinity information. > 3. Emulate numa through "numa=fake" command line parameter. But I found > that when numa_fake is enabled, current code will not prevent ACPI > srat parsers to parse NUMA information. So acpi_numa still may be > changed later. Is there any further reasons that we still need to > parse NUMA info from SRAT table when numa=fake? Or can we set > acpi_numa = -1 in nume_setup when "numa=fake" to make srat_disabled > can prevent ACPI SRAT parsing. > > If meet the following conditions, then acpi_numa = 1: > 1. Xen enable ACPI through acpi_disabled = 0. > 2. ACPI SRAT parser can parse CPU and Memory NUMA affinities successfully > from SRAT table. > 3. Pass the memmory blocks' sanity check and hash computing in > acpi_scan_nodes. > > The following scenarios will make acpi_numa=-1: > 1. ACPI table is disabled by "numa=noacpi" command like parameter. > 2. Xen enable ACPI through acpi_disabled = 0 but ACPI SRAT parser can not > parse CPU or Memory NUMA affinities successfully from SRAT table. > 3. The memmory blocks' sanity check or hash computing in acpi_scan_nodes > is failed. From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:44:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:44:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367182.598235 (Exim 4.92) (envelope-from ) id 1oBvOl-000053-5k; Thu, 14 Jul 2022 09:44:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367182.598235; Thu, 14 Jul 2022 09:44:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvOl-00004u-1k; Thu, 14 Jul 2022 09:44:43 +0000 Received: by outflank-mailman (input) for mailman id 367182; Thu, 14 Jul 2022 09:44:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvOj-0008WS-E1 for xen-devel@lists.xen.org; Thu, 14 Jul 2022 09:44:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2077.outbound.protection.outlook.com [40.107.20.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 94c46c9b-0359-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 11:44:40 +0200 (CEST) Received: from DB6P192CA0008.EURP192.PROD.OUTLOOK.COM (2603:10a6:4:b8::18) by AM0PR08MB4977.eurprd08.prod.outlook.com (2603:10a6:208:163::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 09:44:38 +0000 Received: from DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b8:cafe::2b) by DB6P192CA0008.outlook.office365.com (2603:10a6:4:b8::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Thu, 14 Jul 2022 09:44:38 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT031.mail.protection.outlook.com (100.127.142.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 09:44:38 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Thu, 14 Jul 2022 09:44:37 +0000 Received: from 9f68f10db1ff.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 578A68B4-DDD5-449D-8CFA-D18CCF5DEFE9.1; Thu, 14 Jul 2022 09:44:31 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9f68f10db1ff.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:44:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB7PR08MB3820.eurprd08.prod.outlook.com (2603:10a6:10:7f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 09:44:28 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:44:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 94c46c9b-0359-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AQHD6kAe3dRlH8ApfSR83BtEx/yUG3FZYmhNLUFFbUUAW6Ch5aLjh3dZMt2AnPUm4j9ELdE+PTlbuH4DAbdyHkHNtfphXHGx38UeB4vmLowIJD/BCOTpJyASRc5vmLuLjPztDEJJMC+WZDQGJy2LCGJJFejuiGpY8usTyqp+wRBy4UPn13u/Vs83cF6Z7tSeR8gzYeuhe4jJK4UdC2YsH4PRrYR7XGDV2TYDf3Ei1wnm7wk+8LDSGR8CNccw2wZ/uHunic+DyvgZMqtSR+oTSN1pdmY2bhv9KLoy3981DQgdYvpiA4xnO4SXX5vT7voOfeuz4LjqP08OSsOrr+aCjQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S36hyEWjsytbeUC8SKEf+oYA+nwYUEcZ7pFbvyOdqgs=; b=oHP1hXGyML4U3AMRh/oVIt/1wte8wPPIfJr3xJbsNUbNZwJBp96yCI60ZgQnaKmHZfcvaJl/F8D0y4cstpk42te8vurnXAtQBGAfo3892FfXWTHkUWigTE/6dLzRzUJFgxm9G4R2KTVXq/nBiP5MaA4mXBkQe4jXtmNhMuw5q8FylpppszpFwZ/zeLdXjkT/JZZx3qYamxw6TRjXy1bNuVAR6UxGkGmVbZr63z/xj78tLR+db/VEdFUjOeqsARW1ipzFxi6ky8M7IOHan9ZJpHYtZuZq52cgMSDnSgR4MD3TEAigS3HLap+bsqAt+zxM6JMMnmOIc8HIELeJXu/dVA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xen.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S36hyEWjsytbeUC8SKEf+oYA+nwYUEcZ7pFbvyOdqgs=; b=sPWuXmIbef/SRI3k00nJt6xP3enLM6EhseqzTCm+rRNjxnGPM0kUsxXlkjDMlI8EcGgpwI6f+3In+1TI1JafmOGO9LxA3diEk6CNzUGifIs9Ulpghm/BDKmkzy8+K5DZZvh6E/U+47WGmGgS3pzk0HfM6Yn0uxpIyrOKbKv45Qo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 4bd34dce404285c6 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KoBnZ/aVVfbwSCALut2qQN5PwJq2o/MORRySJ5kEuhd6PgYkAMzqpUl8KkGhqtEUCVM479KjhhKaRJjTHDN9EWa777v0+Z1AvD1zQZWytRfWp9l/1uzbonNiBPFmePh2SqEzRzJ1hBjmtlbbpaE7wMHMAJNDmCVMlVe6ShFdcTTekQ6VV0zS7BZgnJ017tvMaoeRPTG+QCa3TwQJ+qXuScLv9wNCk3Dt04rmxUsvVlIwI/MEhMAT03/SnNaQyRw5rcI/rglxDWKHGAJ5Akc81wdRFEh+sGiX7j/ENHTCF5T8SZeLiR6YmO1fmuBW959ZGlUBxvLDtsVUhYyaZwj5hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=S36hyEWjsytbeUC8SKEf+oYA+nwYUEcZ7pFbvyOdqgs=; b=E5CFFXBpAo9Fc3SS2h2QEdpRTeBut/JqAdTDMwB0rSF8quyOERGJx+fP7R9+BN/pCb+ns6DzQh3/RifZrD1NiRJwR1CespWXStq/10A8pNiXaS48GVdGbkCCO91C4P8zrmVCLYE/gyUODFlaprOI4/FEdV1vsEr3Epeglln3+aT7FH1s0Dhee3dHPNUXE6bFsPqIXqop1LJKlMYCaaDDSHMjAW/WY3tY4rI/R+W7LFR2xL+dq4VqHhJFUGpCjqIGynyRmLT/XvWs0CkOkyKkdrpTy0mxIlcIj4+wFKlS0o/ByLC6hk0/jSnZ1FwU7OGo9uapfnI3UbmDCXyQOTXUWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S36hyEWjsytbeUC8SKEf+oYA+nwYUEcZ7pFbvyOdqgs=; b=sPWuXmIbef/SRI3k00nJt6xP3enLM6EhseqzTCm+rRNjxnGPM0kUsxXlkjDMlI8EcGgpwI6f+3In+1TI1JafmOGO9LxA3diEk6CNzUGifIs9Ulpghm/BDKmkzy8+K5DZZvh6E/U+47WGmGgS3pzk0HfM6Yn0uxpIyrOKbKv45Qo= From: Bertrand Marquis To: Brad Churchwell CC: "xen-devel@lists.xen.org" Subject: Re: Xen on rk3399 Thread-Topic: Xen on rk3399 Thread-Index: AQHYlaRzw0VI/DSwq0Ot3R+564rcea161i+AgAAPUoCAAANZAIAAA34AgAFZWwCAAAjiAIABUr+A Date: Thu, 14 Jul 2022 09:44:27 +0000 Message-ID: <3E15C816-7A02-47A1-ACA0-BF2B106CF482@arm.com> References: <81265FD0-2D00-48D7-ACBA-0F7A4FF3DCAA@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d819271d-f600-4c0c-1ea5-08da657d77b8 x-ms-traffictypediagnostic: DB7PR08MB3820:EE_|DBAEUR03FT031:EE_|AM0PR08MB4977:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: XrOYe/FpuZYQxK4z0Fppyl2jKRPp2tZhxka4vPxNL9XmxZBPq3bma7cRXPMApcGHrUTpzNtU+W85VQz9ncCfjaKXj3X6CWgox3ELoxnm/zsyyOwOF1ovUhEHjBDCd55dVtXgRWb7ycjBwSzp41DVknMSIASjZfAgNtUjS+RsgtKre0WLvELwvj2tvlQjh7QHksz67PHXUx/lAWb3vugKZvWWggUVrN9j71kJtQpOBCiUWU51g9+iZFi7wAhqeqXuHpr5RuNe+fqHFLNOulSG4WG1qfa/5YfVR04XjCDvuyq1BB3HoKaJM5zAI2uqY1JBzzQ9moTY3wESdhdGV2AclTx1GNVUGgq4E2aqj7ofDDG0zAZlnfPD+KD8ghH8iCyOcjRtFFV2mWPsqRfkEyy252OS4evohrwb8x8pRCMeMg4rCWBBWx/0CQP+M4QjekFh908hFji4V1266NKmiUw8+NTWGILi/OLj93nvNiGDI6ianMplWo2vGe9urrnBB9CpUmOdYR321iltTYnFINoVEXpoJCtpfwDUx7Yx2EKqQa2FLdWuogqRvEm/aonSKnvv+Bc5Vb8ZO6pfUEKRW3aEnzStNzD+5mklmSYgmvnyUlJPSgg6pZGEyFmRK5BZ14NpcG6FYz5eQxVjZY2yU7Ehxrc5zOXzqak7urYjv/feyOYVepZ7QlNJmoLSCfYI59Pdo+uE5C0Bp0+f45W1Yfrt+6yFngyJe95inCjNmNNfs9XUEiaxyHuspvZPJzcRUW2xTiAQ/uHRA40sG9HiGjY6vfAvnjNWv7WiAFZ20NRm57eYSbkkUjJEiEFDQAiECnQCVv/hBkR3x+4hH6ioAcviJV8i1BmiUkqhqhZFdXOyxu0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(346002)(366004)(478600001)(33656002)(83380400001)(38070700005)(36756003)(6506007)(2906002)(122000001)(6486002)(5660300002)(7116003)(8936002)(66476007)(64756008)(91956017)(6916009)(86362001)(316002)(4326008)(8676002)(66556008)(66446008)(26005)(71200400001)(76116006)(6512007)(53546011)(2616005)(38100700002)(66946007)(41300700001)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6CFF211B2A897942AE99E71F20E197C0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3820 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b3b29fe0-a98d-4a8f-0d2d-08da657d719b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TiH6b62jkTlO/osy230bxHK1KOeu6/R4FajaegbHaZ6u3uim7CepfDGBQSfY5d8vQq/+ZD/ix0ggGzQJYmzT1ftnJGnNFXTurQs3UOs4XltqgEvbTJRjOnqUIKlC7bCT0vwC+96jHMpnMkEeqZRSLrW38hSrgXHveoBSnQ986E8gsCsqiR5aPeCuKYPe34t+wWEIxXU6nlYhzkaaLrCNmXr6uPGY1RvEa6vwO5SY4ow1eYQrU0X9s0Vr7pO+N8yisKBzFBSj7T2Ai/lInomMppDVVTw+8U4mbF6heQ44JIKwyUXnlD3S4JCGD5+WQ9SEFjNdW6Rx2wTFfXr/5uI6z6kn9ZpAMcfPyuJHgFSCj5H+3o9X6W6feB48/MNYsNaD95AcnsrMEVV6nY6CQaIkmPyfPhf7RABO9o7Jx8H5KaiGSvUQW+KfTtTiiZzHXwkvVO9j7Pi5GWgbKA7MpzzzgcWWqqE6ye3EmifrTXafTSyl5aPJ2IPOeo0/GVopll5lEZiYeZxwfKADnxm09IDhvXAP01RLOiqGvx4A9NILCHDcSP19n0mEi5uC9mGQXt4DxktP2tGEV+ZkNn5p8tPHyWo9j6rlMUn7e92QmcWraSrzsHcAgmLoLbbPl4KddbZknv5+VTVnqUOVCUIuEt5TyiZj5YIBGSaoK+Y/6Zd4SYS/MHG0kunUzxrJZpI+CXl4+o1ZeUHjLRLbZF+6yDSloYQOCjneFtC69xL8uJxt95KLSW4jI6c/UHsR2PXUswWyF8LV/iI434sbC3HLk6dHTe/vTEhwcjJo1YNeJw9IVtyDIsj+sGp9t8mO+wsj+y4E X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(36840700001)(40470700004)(46966006)(83380400001)(5660300002)(2906002)(186003)(6862004)(8936002)(86362001)(2616005)(47076005)(336012)(82310400005)(82740400003)(356005)(40480700001)(40460700003)(33656002)(81166007)(26005)(6506007)(478600001)(70206006)(70586007)(36756003)(4326008)(8676002)(6486002)(53546011)(316002)(41300700001)(7116003)(36860700001)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:44:38.0219 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d819271d-f600-4c0c-1ea5-08da657d77b8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT031.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4977 Hi Brad > On 13 Jul 2022, at 14:32, Brad Churchwell wrote: > > Hi Bertrand, > > I did this yesterday and it does indeed silence the warnings saying to di= sable those cores, however the IRQ errors still remain. Can you check to which domain it belongs ? If it belongs to the domain with= little cores this might explain it. > > I think I made some progress by changing "interrupts =3D ;" to "interrupts =3D ;".= I noticed when trying to use XEN-4.10 that it said "IRQ only through SPI" = and failed to boot XEN where 4.17 unstable boots without this error. Now th= at I changed GIC_PPI to GIC_SPI, I get the following output: You cannot change a Per Processor Interrupt into an SPI those are different= kind of interrupts (please check the GIC reference manual for more explana= tions on those principles). You have a board specific PCI controller and it could be that the ITS/MSI i= mplementation has some specific parts which are not supported by Xen. It will be hard for me to provide more support here and I would suggest to = try to explain your problem in Xen-user mailing list instead of xen-devel, = maybe someone did try xen on this board. Cheers Bertrand IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:52:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:52:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367191.598246 (Exim 4.92) (envelope-from ) id 1oBvVn-0001lD-Sd; Thu, 14 Jul 2022 09:51:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367191.598246; Thu, 14 Jul 2022 09:51:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvVn-0001l6-Pg; Thu, 14 Jul 2022 09:51:59 +0000 Received: by outflank-mailman (input) for mailman id 367191; Thu, 14 Jul 2022 09:51:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvVl-0001kx-LE for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:51:57 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 98b2d550-035a-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 11:51:56 +0200 (CEST) Received: from AS9PR04CA0099.eurprd04.prod.outlook.com (2603:10a6:20b:50e::22) by AM6PR08MB3109.eurprd08.prod.outlook.com (2603:10a6:209:4c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 09:51:52 +0000 Received: from AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:50e:cafe::fd) by AS9PR04CA0099.outlook.office365.com (2603:10a6:20b:50e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15 via Frontend Transport; Thu, 14 Jul 2022 09:51:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT028.mail.protection.outlook.com (10.152.16.118) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 09:51:52 +0000 Received: ("Tessian outbound 13cb25bfb745:v122"); Thu, 14 Jul 2022 09:51:51 +0000 Received: from 0769022c8349.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5157D8C2-6705-4201-988B-DAD50528093A.1; Thu, 14 Jul 2022 09:51:45 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0769022c8349.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:51:45 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM9PR08MB6786.eurprd08.prod.outlook.com (2603:10a6:20b:305::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 09:51:42 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:51:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98b2d550-035a-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HLqUsFHpphnOft5zKc4KkrJ3cji0v6fhO1uOh4dfdrsP+SlJqI3R31ynlStHDWjr9qp9+2MJjMy9qi7Cr9LyW4tuacpE60tHf79waPeh2++w8piUdoFTqV1V7Ild4cp58LsCJ8fPHN5R8zzEjyrNQbQZ+NovVKAdKMvU7m+PgPaXuU/sHGRGB7/hPR4nH6awRSfkzvxPTnB3YgAnnEg/OytdTP5LUIG8gxQujp6cyYzjeaHJm+F3Zpcz1LNhlFmuFIXUI+RapvzqP5Qv2MuWHbgo4rGm/GQYFdJ864oYSAFr0Wfh5lxMXctadcbOoIEykkWn+24e6TvQ5+kJy1+1TA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nea4bKN61ggX/ruB7EyI5rRgdfsfvJOym339G2AR42U=; b=W19N67WQCfwFJ98FkX7jxmfTZnkNIe5WSmVGtt7F5ZxdNtP2NW0HPFoGkbrmDGGK7LVm+2rLexW3X2sGA907/QoInPqgyQkxKfYIjFCUM4ZSZVd7MDrVKWtmYGEmC7UI6A8XgZbjAmGTTNc4A/zCkQkZHUlBfvpIt0w+zB7E+GKo7bRMZZdMBEI+vLQE2xGcVhapbuymprx7QDTv7uBFGWwmiJ7CsKzUOpyFbm713PdkbiptFlR+wvVoD5VyKiQNMJwuN3ZytpFH5ERvHcmMLrnPG2LXkdi2Pw+5HYXustPf52txnJspx2yy41GNjWYXDM+8sI6KDqGH7rEk3B+seg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nea4bKN61ggX/ruB7EyI5rRgdfsfvJOym339G2AR42U=; b=kY+4qCNDFPDAwRMSmAzVjvQ/jgOkKhFQ5wzYOauGfUzPvdfdieJzfHtVL2Bef9otF/tosKxR2bB/JqrZEWni0zAALKeCRRU29TsXJcbrodQDOAqDftjFwVu5K5Rt1P+2ULvLJwWYOG6OmbR1lYIfM946sJBvHzCYaQdn1HpVFb8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 41da30b9bb5525c0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iqqFfblLygbO4Vnd6xm3j+h2u2W6tmMXryB0A7179Uk6dOKaq5/2wnyDY9tLBwO3E/4ed0kOppTmZnDnjQ4ulTztSrX+I2ONM5bSB6jaA9+xUf0VAfPUtPVHSIKQ+aGuCUIpAwdUH8vMKuVuQR6ATcFSpCZGVhY8vumt5fWYoLLO4D3pWPtRHUdeanXn6GvheiIxCvic74VceDjGxSyh4q52YFHg2hl3I+4l3wF+bCpjDzywUeXgv7HXwahWWYgUFFen3pMc2n82JLQX4VdA2jkKwVxmm4SpYXflkKEi2/aYG2COP7PbS4Z36mPFCZ4ySzJr1o4LjvE3l83hIgzrXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nea4bKN61ggX/ruB7EyI5rRgdfsfvJOym339G2AR42U=; b=TBKVaBDv5SfXcecyH83EN7HP95n5uBiihlKdoaeHdQ6y2zFLBHca7j6+Hoi5taz+IkUiOnIPXDwbKCnPpGoqBW5MjZYZ+18I2eqhW10XAW2R8qe1pM7Pp07ny7ltV2zmvDhLJ8JSp7TyQ/rlgPyggmv8xgKYf9yX0NnfoqUgUDlhPG2su41nxS1oS7IzssqYyYs/B+wAMQ6AhUadZSjDLInNy9SVdtOqebn4423ghH7UND+r90VyFtxap7XVmqsEJZ/OxokDSEkbZ2oNqgXZPhV0FGsMpYADT5Wcmn/ecQOg2m86BVu9kYzYCZuExCZuluB0MiVEzrbDPwmU7qxKdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nea4bKN61ggX/ruB7EyI5rRgdfsfvJOym339G2AR42U=; b=kY+4qCNDFPDAwRMSmAzVjvQ/jgOkKhFQ5wzYOauGfUzPvdfdieJzfHtVL2Bef9otF/tosKxR2bB/JqrZEWni0zAALKeCRRU29TsXJcbrodQDOAqDftjFwVu5K5Rt1P+2ULvLJwWYOG6OmbR1lYIfM946sJBvHzCYaQdn1HpVFb8= From: Bertrand Marquis To: Jens Wiklander CC: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator Thread-Topic: [PATCH v4 2/2] xen/arm: add FF-A mediator Thread-Index: AQHYhj32JXXtKHb7m068zMJ/M+86kK19wigA Date: Thu, 14 Jul 2022 09:51:42 +0000 Message-ID: <2E5B1159-9569-40D9-9BA1-92022378B9C6@arm.com> References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> In-Reply-To: <20220622134219.1596613-3-jens.wiklander@linaro.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9bd5a8ff-75ff-4508-6570-08da657e7a7d x-ms-traffictypediagnostic: AM9PR08MB6786:EE_|AM5EUR03FT028:EE_|AM6PR08MB3109:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gJAkM1yavwmEtOQGkB8mXoOb0tTVqCW4qHorAqSZCfmDbc5Vu+SiENZy2grgzKtHNhMwSpL6YssDK++dkKMsj2V/Sgncs+MpMMqn+tY8y0E1Y2bcCs+yEmey966WhIEmn/gj9f952ezXJr+l8rltTv1rJ7vWLemM5sy00zagxUdd96/WiNYO+Jg8mwBkEmSJ3ExXo4ctHk1eGbhfKQYyD4wdRx75KRFwICVYX9z9kW1xKwfnwpRqODUOo4KV+ZWJRmvpxizVYrDRVZgmrhFFc5cV6cb7mNCXUEKWofO+PSfSEl7b6u8YEGEPdYVk07Bce0q423RsJLdhFCl6wknrLEaIoLfKn3/x2ztP3aiTxFOV2jKSKVw7dHKokNoRVMRQiNENjYWk7r6V+9NXmSWY/gH7+mKEH+jBGMlnqBqRw5qWxKlytObscH29OQIci2Z6VSe2CuqwGdsVrm8p6HK3CaJ8+RUDNY4DxxcCmq5jX7R+sfR4/kXgPH3BKhavp52YxekZdI2eLiOZC+kULZ3lRDP8O6gir3sk2hX98l6v9AGYbQ5WCRpc6rMb3zuzTN54Qde8qlsgc2EWVQawI/Tmp+HxqjAwycDMMGjTOyBZzl5IN5cGOxs0H31FhEm22Ze1B41wdOKn3X5ZzkaTXMZbsJHmGJTL4UOLS2F81un+I/Mgk2yaRpk5fdeU8Qp2CC2xnWrguvyYISQMTFsEhjEUL9QjRyxm6mx+SJ2nJDyOgNXXOLpmAmV4SQJz7JT6JSbWKzQl4dteBlI3urxRO8g9sXKOZoplJZcLkJ62GJks/v7I/WZWdp+laptC11+g/4SMyLIvOeMDXjWO05T3ngRyXs7cHA9KXVIExNrUd4NDudzXFZm1LRCgx6Ijwkg6WIEK X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(366004)(376002)(136003)(478600001)(6486002)(53546011)(66476007)(6512007)(6916009)(6506007)(86362001)(54906003)(66946007)(64756008)(66556008)(66446008)(26005)(41300700001)(5660300002)(76116006)(91956017)(966005)(71200400001)(122000001)(316002)(38100700002)(36756003)(38070700005)(83380400001)(8676002)(2616005)(2906002)(8936002)(186003)(30864003)(4326008)(33656002)(45980500001)(579004)(559001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <08BEF9EF1B99234E9F1A1BE52AAEF9B1@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6786 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 94217cb2-cf89-49a0-1537-08da657e74c8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dFuYpU23sRcnG5MSOB5c75h7CzF81nzLi8OE2znNoIzHdphf5yICrfvH/TTxwWZZ6rCQEV5/6J2X6BP6JULGTZGUKQiLiJUxjJywoNFZqKzS7i0HbwTs2ZxD9XkqUx0uPu4XG7bAXl4zJEY28HmOGLv5bqSduD0NLzW+BfgHDbwPU81W/Lr3moDueRQFd4BGqTXBu3xP5YRHGST6G+7xA1urciOq/f7UxWtKYdcwlRZiWYpLrVgqPYbn+vRAzINHIkMWkJXADhJU4WpF3WFV6aOIxBJzV5DyikpWqLs65O0vVQhA0VHRbnIVLI0uv6TrwuQFv6jocif0OEA0HMBK2REuF22dWlRw4LaJaJKHsZzOr0jEJQJ/G8IwN0D4xq2IQyUKOFrTn81SZi1NyHtnLQ6jRHOMrZw8CwnHPYa0Iv3CvvPJOn/D77+kBPogOSY+RI4WNMwOJKG5n8Hin3bSZ8Ne3sBaZxTyGTdp1hzfN4TNTkeXssFecjlhj+SPYVtUvc7zTR+L6Cla5S1LqPo5S03C7b1FHo6MsYMo4RWj5ArtBOZHNA8tlb0xUhtRb7Glrb0zVfwMl6BHJN2p4y042ZNqrjHSp9Mb1/Iq7sU37ZMMU2v51B/iM/5xWHj8aXLT8e4x0jE9Vz+pW1+wJRrDN6k/dcKB/1kIhqbjjoVMp/NF/xzOr1U8RDJT2q2bqXDpkAtz1FqMrHC5O7R1xIP6Es/FmHxJx9Jxg4Uhuh0awhY1OXIUehwb/SIE78ODOmOfAvPS4UrTwP60SU9EM4WXj0Oe/cOFSluah5K2VXLB5WJvWnwYLl35gyYhVzSruDWW/yj4buzuCW5AZ0rkZwq04ufj7g/JGnmzvN+WXNkY084= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(346002)(396003)(46966006)(40470700004)(36840700001)(81166007)(966005)(82310400005)(40460700003)(2906002)(30864003)(478600001)(82740400003)(6486002)(356005)(8676002)(70206006)(4326008)(70586007)(41300700001)(6512007)(316002)(83380400001)(107886003)(26005)(336012)(8936002)(36860700001)(54906003)(5660300002)(47076005)(2616005)(53546011)(86362001)(6862004)(6506007)(33656002)(40480700001)(186003)(36756003)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:51:52.0888 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bd5a8ff-75ff-4508-6570-08da657e7a7d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT028.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3109 Hi Jens, > On 22 Jun 2022, at 14:42, Jens Wiklander wrot= e: >=20 > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > Partition in secure world. >=20 > The implementation is the bare minimum to be able to communicate with > OP-TEE running as an SPMC at S-EL1. >=20 > This is loosely based on the TEE mediator framework and the OP-TEE > mediator. >=20 > [1] https://developer.arm.com/documentation/den0077/latest > Signed-off-by: Jens Wiklander I spent quite some time on this patch and on the spec and there are far to much code and concepts introduced here to be able to do a review in one go. Could you try to split the patch to introduce each concept in a specific pa= tch ? I would suggest something like introducing each call in its own patch, havi= ng a specific patch for the tool support, etc. At this stage I am not convinced that there is no issue here where a guest = could access information from an other guest and reviewing smaller patches will h= elp me following the spec for each subject and ask questions along the way. Cheers Bertrand > --- > SUPPORT.md | 7 + > tools/libs/light/libxl_arm.c | 3 + > tools/libs/light/libxl_types.idl | 1 + > tools/xl/xl_parse.c | 3 + > xen/arch/arm/Kconfig | 11 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain.c | 10 + > xen/arch/arm/domain_build.c | 1 + > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > xen/arch/arm/include/asm/domain.h | 4 + > xen/arch/arm/include/asm/ffa.h | 71 ++ > xen/arch/arm/vsmc.c | 17 +- > xen/include/public/arch-arm.h | 2 + > 13 files changed, 1811 insertions(+), 3 deletions(-) > create mode 100644 xen/arch/arm/ffa.c > create mode 100644 xen/arch/arm/include/asm/ffa.h >=20 > diff --git a/SUPPORT.md b/SUPPORT.md > index 70e98964cbc0..215bb3c9043b 100644 > --- a/SUPPORT.md > +++ b/SUPPORT.md > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed throu= gh. >=20 > No support for QEMU backends in a 16K or 64K domain. >=20 > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > + > + Status, Arm64: Tech Preview > + > +There are still some code paths where a vCPU may hog a pCPU longer than > +necessary. The FF-A mediator is not yet implemented for Arm32. > + > ### ARM: Guest Device Tree support >=20 > Status: Supported > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > index eef1de093914..a985609861c7 100644 > --- a/tools/libs/light/libxl_arm.c > +++ b/tools/libs/light/libxl_arm.c > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > return ERROR_FAIL; > } >=20 > + config->arch.ffa_enabled =3D > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > + > return 0; > } >=20 > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty= pes.idl > index 2a42da2f7d78..bf4544bef399 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -646,6 +646,7 @@ libxl_domain_build_info =3D Struct("domain_build_info= ",[ >=20 > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > ("vuart", libxl_vuart_type), > + ("ffa_enabled", libxl_defbool), > ])), > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > ])), > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > index b98c0de378b6..e0e99ed8d2b1 100644 > --- a/tools/xl/xl_parse.c > +++ b/tools/xl/xl_parse.c > @@ -2746,6 +2746,9 @@ skip_usbdev: > exit(-ERROR_FAIL); > } > } > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > + xlu_cfg_get_defbool(config, "ffa_enabled", > + &b_info->arch_arm.ffa_enabled, 0); >=20 > parse_vkb_list(config, d_config); >=20 > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > index be9eff014120..e57e1d3757e2 100644 > --- a/xen/arch/arm/Kconfig > +++ b/xen/arch/arm/Kconfig > @@ -139,6 +139,17 @@ config TEE >=20 > source "arch/arm/tee/Kconfig" >=20 > +config FFA > + bool "Enable FF-A mediator support" if EXPERT > + default n > + depends on ARM_64 > + help > + This option enables a minimal FF-A mediator. The mediator is > + generic as it follows the FF-A specification [1], but it only > + implements a small subset of the specification. > + > + [1] https://developer.arm.com/documentation/den0077/latest > + > endmenu >=20 > menu "ARM errata workaround via the alternative framework" > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index bb7a6151c13c..af0c69f793d4 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -20,6 +20,7 @@ obj-y +=3D domain_build.init.o > obj-y +=3D domctl.o > obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o > obj-y +=3D efi/ > +obj-$(CONFIG_FFA) +=3D ffa.o > obj-y +=3D gic.o > obj-y +=3D gic-v2.o > obj-$(CONFIG_GICV3) +=3D gic-v3.o > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 8110c1df8638..a3f00e7e234d 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -27,6 +27,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > if ( (rc =3D tee_domain_init(d, config->arch.tee_type)) !=3D 0 ) > goto fail; >=20 > + if ( (rc =3D ffa_domain_init(d, config->arch.ffa_enabled)) !=3D 0 ) > + goto fail; > + > update_domain_wallclock_time(d); >=20 > /* > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struc= t page_list_head *list) > enum { > PROG_pci =3D 1, > PROG_tee, > + PROG_ffa, > PROG_xen, > PROG_page, > PROG_mapping, > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) >=20 > PROGRESS(tee): > ret =3D tee_relinquish_resources(d); > + if ( ret ) > + return ret; > + > + PROGRESS(ffa): > + ret =3D ffa_relinquish_resources(d); > if (ret ) > return ret; >=20 > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 7ddd16c26da5..d708f76356f7 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > if ( gic_number_lines() > 992 ) > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > dom0_cfg.arch.tee_type =3D tee_get_type(); > + dom0_cfg.arch.ffa_enabled =3D true; > dom0_cfg.max_vcpus =3D dom0_max_vcpus(); >=20 > if ( iommu_enabled ) > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > new file mode 100644 > index 000000000000..3117ce5cec4d > --- /dev/null > +++ b/xen/arch/arm/ffa.c > @@ -0,0 +1,1683 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > + * > + * Copyright (C) 2022 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > + > +/* Error codes */ > +#define FFA_RET_OK 0 > +#define FFA_RET_NOT_SUPPORTED -1 > +#define FFA_RET_INVALID_PARAMETERS -2 > +#define FFA_RET_NO_MEMORY -3 > +#define FFA_RET_BUSY -4 > +#define FFA_RET_INTERRUPTED -5 > +#define FFA_RET_DENIED -6 > +#define FFA_RET_RETRY -7 > +#define FFA_RET_ABORTED -8 > + > +/* FFA_VERSION helpers */ > +#define FFA_VERSION_MAJOR _AC(1,U) > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > +#define FFA_VERSION_MINOR _AC(1,U) > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > +#define MAKE_FFA_VERSION(major, minor) \ > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > + ((minor) & FFA_VERSION_MINOR_MASK)) > + > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > + FFA_VERSION_MINOR) > + > + > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) > + > +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareab= le */ > +#define FFA_NORMAL_MEM_REG_ATTR _AC(0x2f,U) > + > +/* Memory access permissions: Read-write */ > +#define FFA_MEM_ACC_RW _AC(0x2,U) > + > +/* Clear memory before mapping in receiver */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > +/* Relayer may time slice this operation */ > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > +/* Clear memory after receiver relinquishes it */ > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > + > +/* Share memory transaction */ > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (_AC(1,U) << 3) > + > +#define FFA_HANDLE_INVALID _AC(0xffffffffffffffff,ULL) > + > +/* Framework direct request/response */ > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > +#define FFA_MSG_TYPE_MASK _AC(0xFF,U); > +#define FFA_MSG_PSCI _AC(0x0,U) > +#define FFA_MSG_SEND_VM_CREATED _AC(0x4,U) > +#define FFA_MSG_RESP_VM_CREATED _AC(0x5,U) > +#define FFA_MSG_SEND_VM_DESTROYED _AC(0x6,U) > +#define FFA_MSG_RESP_VM_DESTROYED _AC(0x7,U) > + > +/* > + * Flags used for the FFA_PARTITION_INFO_GET return message: > + * BIT(0): Supports receipt of direct requests > + * BIT(1): Can send direct requests > + * BIT(2): Can send and receive indirect messages > + * BIT(3): Supports receipt of notifications > + * BIT(4-5): Partition ID is a PE endpoint ID > + */ > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0,U) > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1,U) > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2,U) > +#define FFA_PART_PROP_RECV_NOTIF BIT(3,U) > +#define FFA_PART_PROP_IS_PE_ID (_AC(0,U) << 4) > +#define FFA_PART_PROP_IS_SEPID_INDEP (_AC(1,U) << 4) > +#define FFA_PART_PROP_IS_SEPID_DEP (_AC(2,U) << 4) > +#define FFA_PART_PROP_IS_AUX_ID (_AC(3,U) << 4) > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6,U) > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7,U) > +#define FFA_PART_PROP_AARCH64_STATE BIT(8,U) > + > +/* Function IDs */ > +#define FFA_ERROR _AC(0x84000060,U) > +#define FFA_SUCCESS_32 _AC(0x84000061,U) > +#define FFA_SUCCESS_64 _AC(0xC4000061,U) > +#define FFA_INTERRUPT _AC(0x84000062,U) > +#define FFA_VERSION _AC(0x84000063,U) > +#define FFA_FEATURES _AC(0x84000064,U) > +#define FFA_RX_ACQUIRE _AC(0x84000084,U) > +#define FFA_RX_RELEASE _AC(0x84000065,U) > +#define FFA_RXTX_MAP_32 _AC(0x84000066,U) > +#define FFA_RXTX_MAP_64 _AC(0xC4000066,U) > +#define FFA_RXTX_UNMAP _AC(0x84000067,U) > +#define FFA_PARTITION_INFO_GET _AC(0x84000068,U) > +#define FFA_ID_GET _AC(0x84000069,U) > +#define FFA_SPM_ID_GET _AC(0x84000085,U) > +#define FFA_MSG_WAIT _AC(0x8400006B,U) > +#define FFA_MSG_YIELD _AC(0x8400006C,U) > +#define FFA_MSG_RUN _AC(0x8400006D,U) > +#define FFA_MSG_SEND2 _AC(0x84000086,U) > +#define FFA_MSG_SEND_DIRECT_REQ_32 _AC(0x8400006F,U) > +#define FFA_MSG_SEND_DIRECT_REQ_64 _AC(0xC400006F,U) > +#define FFA_MSG_SEND_DIRECT_RESP_32 _AC(0x84000070,U) > +#define FFA_MSG_SEND_DIRECT_RESP_64 _AC(0xC4000070,U) > +#define FFA_MEM_DONATE_32 _AC(0x84000071,U) > +#define FFA_MEM_DONATE_64 _AC(0xC4000071,U) > +#define FFA_MEM_LEND_32 _AC(0x84000072,U) > +#define FFA_MEM_LEND_64 _AC(0xC4000072,U) > +#define FFA_MEM_SHARE_32 _AC(0x84000073,U) > +#define FFA_MEM_SHARE_64 _AC(0xC4000073,U) > +#define FFA_MEM_RETRIEVE_REQ_32 _AC(0x84000074,U) > +#define FFA_MEM_RETRIEVE_REQ_64 _AC(0xC4000074,U) > +#define FFA_MEM_RETRIEVE_RESP _AC(0x84000075,U) > +#define FFA_MEM_RELINQUISH _AC(0x84000076,U) > +#define FFA_MEM_RECLAIM _AC(0x84000077,U) > +#define FFA_MEM_FRAG_RX _AC(0x8400007A,U) > +#define FFA_MEM_FRAG_TX _AC(0x8400007B,U) > +#define FFA_MSG_SEND _AC(0x8400006E,U) > +#define FFA_MSG_POLL _AC(0x8400006A,U) > + > +/* Partition information descriptor */ > +struct ffa_partition_info_1_0 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > +}; > + > +struct ffa_partition_info_1_1 { > + uint16_t id; > + uint16_t execution_context; > + uint32_t partition_properties; > + uint8_t uuid[16]; > +}; > + > +/* Constituent memory region descriptor */ > +struct ffa_address_range { > + uint64_t address; > + uint32_t page_count; > + uint32_t reserved; > +}; > + > +/* Composite memory region descriptor */ > +struct ffa_mem_region { > + uint32_t total_page_count; > + uint32_t address_range_count; > + uint64_t reserved; > + struct ffa_address_range address_range_array[]; > +}; > + > +/* Memory access permissions descriptor */ > +struct ffa_mem_access_perm { > + uint16_t endpoint_id; > + uint8_t perm; > + uint8_t flags; > +}; > + > +/* Endpoint memory access descriptor */ > +struct ffa_mem_access { > + struct ffa_mem_access_perm access_perm; > + uint32_t region_offs; > + uint64_t reserved; > +}; > + > +/* Lend, donate or share memory transaction descriptor */ > +struct ffa_mem_transaction_1_0 { > + uint16_t sender_id; > + uint8_t mem_reg_attr; > + uint8_t reserved0; > + uint32_t flags; > + uint64_t global_handle; > + uint64_t tag; > + uint32_t reserved1; > + uint32_t mem_access_count; > + struct ffa_mem_access mem_access_array[]; > +}; > + > +struct ffa_mem_transaction_1_1 { > + uint16_t sender_id; > + uint16_t mem_reg_attr; > + uint32_t flags; > + uint64_t global_handle; > + uint64_t tag; > + uint32_t mem_access_size; > + uint32_t mem_access_count; > + uint32_t mem_access_offs; > + uint8_t reserved[12]; > +}; > + > +/* > + * The parts needed from struct ffa_mem_transaction_1_0 or struct > + * ffa_mem_transaction_1_1, used to provide an abstraction of difference= in > + * data structures between version 1.0 and 1.1. This is just an internal > + * interface and can be changed without changing any ABI. > + */ > +struct ffa_mem_transaction_x { > + uint16_t sender_id; > + uint8_t mem_reg_attr; > + uint8_t flags; > + uint8_t mem_access_size; > + uint8_t mem_access_count; > + uint16_t mem_access_offs; > + uint64_t global_handle; > + uint64_t tag; > +}; > + > +/* Endpoint RX/TX descriptor */ > +struct ffa_endpoint_rxtx_descriptor_1_0 { > + uint16_t sender_id; > + uint16_t reserved; > + uint32_t rx_range_count; > + uint32_t tx_range_count; > +}; > + > +struct ffa_endpoint_rxtx_descriptor_1_1 { > + uint16_t sender_id; > + uint16_t reserved; > + uint32_t rx_region_offs; > + uint32_t tx_region_offs; > +}; > + > +struct ffa_ctx { > + void *rx; > + void *tx; > + struct page_info *rx_pg; > + struct page_info *tx_pg; > + unsigned int page_count; > + uint32_t guest_vers; > + bool tx_is_mine; > + bool interrupted; > + struct list_head frag_list; > + spinlock_t lock; > +}; > + > +struct ffa_shm_mem { > + struct list_head list; > + uint16_t sender_id; > + uint16_t ep_id; /* endpoint, the one lending */ > + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ > + unsigned int page_count; > + struct page_info *pages[]; > +}; > + > +struct mem_frag_state { > + struct list_head list; > + struct ffa_shm_mem *shm; > + uint32_t range_count; > + unsigned int current_page_idx; > + unsigned int frag_offset; > + unsigned int range_offset; > + uint8_t *buf; > + unsigned int buf_size; > + struct ffa_address_range range; > +}; > + > +/* > + * Our rx/rx buffer shared with the SPMC > + */ > +static uint32_t ffa_version; > +static uint16_t *subsr_vm_created; > +static unsigned int subsr_vm_created_count; > +static uint16_t *subsr_vm_destroyed; > +static unsigned int subsr_vm_destroyed_count; > +static void *ffa_rx; > +static void *ffa_tx; > +static unsigned int ffa_page_count; > +static DEFINE_SPINLOCK(ffa_buffer_lock); > + > +static LIST_HEAD(ffa_mem_list); > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > + > +static uint64_t next_handle =3D FFA_HANDLE_HYP_FLAG; > + > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > +{ > + return (uint64_t)reg0 << 32 | reg1; > +} > + > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > + uint64_t val) > +{ > + *reg0 =3D val >> 32; > + *reg1 =3D val; > +} > + > +static bool ffa_get_version(uint32_t *vers) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_VERSION, .a1 =3D FFA_MY_VERSION, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 =3D=3D FFA_RET_NOT_SUPPORTED ) > + { > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > + return false; > + } > + > + *vers =3D resp.a0; > + return true; > +} > + > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > +{ > + switch ( resp->a0 ) > + { > + case FFA_ERROR: > + if ( resp->a2 ) > + return resp->a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + return FFA_RET_OK; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_features(uint32_t id) > +{ > + const struct arm_smccc_1_2_regs arg =3D { .a0 =3D FFA_FEATURES, .a1 = =3D id, }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + return get_ffa_ret_code(&resp); > +} > + > +static bool check_mandatory_feature(uint32_t id) > +{ > + uint32_t ret =3D ffa_features(id); > + > + if (ret) > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id)= ; > + return !ret; > +} > + > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > + uint32_t page_count) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > +#ifdef CONFIG_ARM_64 > + .a0 =3D FFA_RXTX_MAP_64, > +#endif > +#ifdef CONFIG_ARM_32 > + .a0 =3D FFA_RXTX_MAP_32, > +#endif > + .a1 =3D tx_addr, .a2 =3D rx_addr, > + .a3 =3D page_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_RXTX_UNMAP, .a1 =3D vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_= t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_PARTITION_INFO_GET, .a1 =3D w1, .a2 =3D w2, .a3 =3D = w3, .a4 =3D w4, > + .a5 =3D w5, > + }; > + struct arm_smccc_1_2_regs resp; > + uint32_t ret; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + ret =3D get_ffa_ret_code(&resp); > + if ( !ret ) > + *count =3D resp.a2; > + > + return ret; > +} > + > +static uint32_t ffa_rx_release(void) > +{ > + const struct arm_smccc_1_2_regs arg =3D { .a0 =3D FFA_RX_RELEASE, }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > + register_t addr, uint32_t pg_count, > + uint64_t *handle) > +{ > + struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_SHARE_32, .a1 =3D tot_len, .a2 =3D frag_len, .a3= =3D addr, > + .a4 =3D pg_count, > + }; > + struct arm_smccc_1_2_regs resp; > + > + /* > + * For arm64 we must use 64-bit calling convention if the buffer isn= 't > + * passed in our tx buffer. > + */ > + if (sizeof(addr) > 4 && addr) > + arg.a0 =3D FFA_MEM_SHARE_64; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + *handle =3D reg_pair_to_64(resp.a3, resp.a2); > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + *handle =3D reg_pair_to_64(resp.a2, resp.a1); > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > + uint16_t sender_id) > +{ > + struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_FRAG_TX, .a1 =3D handle & UINT32_MAX, .a2 =3D ha= ndle >> 32, > + .a3 =3D frag_len, .a4 =3D (uint32_t)sender_id << 16, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_ERROR: > + if ( resp.a2 ) > + return resp.a2; > + else > + return FFA_RET_NOT_SUPPORTED; > + case FFA_SUCCESS_32: > + return FFA_RET_OK; > + case FFA_MEM_FRAG_RX: > + return resp.a3; > + default: > + return FFA_RET_NOT_SUPPORTED; > + } > +} > + > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > + uint32_t flags) > +{ > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MEM_RECLAIM, .a1 =3D handle_lo, .a2 =3D handle_hi, .= a3 =3D flags, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + > + return get_ffa_ret_code(&resp); > +} > + > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > + uint8_t msg) > +{ > + uint32_t exp_resp =3D FFA_MSG_FLAG_FRAMEWORK; > + int32_t res; > + > + if ( msg !=3D FFA_MSG_SEND_VM_CREATED && msg !=3DFFA_MSG_SEND_VM_DES= TROYED ) > + return FFA_RET_INVALID_PARAMETERS; > + > + if ( msg =3D=3D FFA_MSG_SEND_VM_CREATED ) > + exp_resp |=3D FFA_MSG_RESP_VM_CREATED; > + else > + exp_resp |=3D FFA_MSG_RESP_VM_DESTROYED; > + > + do { > + const struct arm_smccc_1_2_regs arg =3D { > + .a0 =3D FFA_MSG_SEND_DIRECT_REQ_32, > + .a1 =3D sp_id, > + .a2 =3D FFA_MSG_FLAG_FRAMEWORK | msg, > + .a5 =3D vm_id, > + }; > + struct arm_smccc_1_2_regs resp; > + > + arm_smccc_1_2_smc(&arg, &resp); > + if ( resp.a0 !=3D FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 !=3D ex= p_resp ) > + { > + /* > + * This is an invalid response, likely due to some error in = the > + * implementation of the ABI. > + */ > + return FFA_RET_INVALID_PARAMETERS; > + } > + res =3D resp.a3; > + } while ( res =3D=3D FFA_RET_INTERRUPTED || res =3D=3D FFA_RET_RETRY= ); > + > + return res; > +} > + > +static u16 get_vm_id(struct domain *d) > +{ > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > + return d->domain_id + 1; > +} > + > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register= _t v1, > + register_t v2, register_t v3, register_t v4, regist= er_t v5, > + register_t v6, register_t v7) > +{ > + set_user_reg(regs, 0, v0); > + set_user_reg(regs, 1, v1); > + set_user_reg(regs, 2, v2); > + set_user_reg(regs, 3, v3); > + set_user_reg(regs, 4, v4); > + set_user_reg(regs, 5, v5); > + set_user_reg(regs, 6, v6); > + set_user_reg(regs, 7, v7); > +} > + > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_co= de) > +{ > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > +} > + > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > + uint32_t w3) > +{ > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > +} > + > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle= _lo, > + uint32_t handle_hi, uint32_t frag_offset, > + uint16_t sender_id) > +{ > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > + (uint32_t)sender_id << 16, 0, 0, 0); > +} > + > +static void handle_version(struct cpu_user_regs *regs) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t vers =3D get_user_reg(regs, 1); > + > + if ( vers < FFA_VERSION_1_1 ) > + vers =3D FFA_VERSION_1_0; > + else > + vers =3D FFA_VERSION_1_1; > + > + ctx->guest_vers =3D vers; > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > +} > + > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > + register_t rx_addr, uint32_t page_count) > +{ > + uint32_t ret =3D FFA_RET_INVALID_PARAMETERS; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + struct page_info *tx_pg; > + struct page_info *rx_pg; > + p2m_type_t t; > + void *rx; > + void *tx; > + > + if ( !smccc_is_conv_64(fid) ) > + { > + tx_addr &=3D UINT32_MAX; > + rx_addr &=3D UINT32_MAX; > + } > + > + /* For now to keep things simple, only deal with a single page */ > + if ( page_count !=3D 1 ) > + return FFA_RET_NOT_SUPPORTED; > + > + /* Already mapped */ > + if ( ctx->rx ) > + return FFA_RET_DENIED; > + > + tx_pg =3D get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC)= ; > + if ( !tx_pg ) > + return FFA_RET_INVALID_PARAMETERS; > + /* Only normal RAM for now */ > + if (t !=3D p2m_ram_rw) > + goto err_put_tx_pg; > + > + rx_pg =3D get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC)= ; > + if ( !tx_pg ) > + goto err_put_tx_pg; > + /* Only normal RAM for now */ > + if ( t !=3D p2m_ram_rw ) > + goto err_put_rx_pg; > + > + tx =3D __map_domain_page_global(tx_pg); > + if ( !tx ) > + goto err_put_rx_pg; > + > + rx =3D __map_domain_page_global(rx_pg); > + if ( !rx ) > + goto err_unmap_tx; > + > + ctx->rx =3D rx; > + ctx->tx =3D tx; > + ctx->rx_pg =3D rx_pg; > + ctx->tx_pg =3D tx_pg; > + ctx->page_count =3D 1; > + ctx->tx_is_mine =3D true; > + return FFA_RET_OK; > + > +err_unmap_tx: > + unmap_domain_page_global(tx); > +err_put_rx_pg: > + put_page(rx_pg); > +err_put_tx_pg: > + put_page(tx_pg); > + return ret; > +} > + > +static uint32_t handle_rxtx_unmap(void) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t ret; > + > + if ( !ctx->rx ) > + return FFA_RET_INVALID_PARAMETERS; > + > + ret =3D ffa_rxtx_unmap(get_vm_id(d)); > + if ( ret ) > + return ret; > + > + unmap_domain_page_global(ctx->rx); > + unmap_domain_page_global(ctx->tx); > + put_page(ctx->rx_pg); > + put_page(ctx->tx_pg); > + ctx->rx =3D NULL; > + ctx->tx =3D NULL; > + ctx->rx_pg =3D NULL; > + ctx->tx_pg =3D NULL; > + ctx->page_count =3D 0; > + ctx->tx_is_mine =3D false; > + > + return FFA_RET_OK; > +} > + > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint= 32_t w3, > + uint32_t w4, uint32_t w5, > + uint32_t *count) > +{ > + uint32_t ret =3D FFA_RET_DENIED; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + > + if ( !ffa_page_count ) > + return FFA_RET_DENIED; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || !ctx->tx_is_mine ) > + goto out; > + ret =3D ffa_partition_info_get(w1, w2, w3, w4, w5, count); > + if ( ret ) > + goto out; > + if ( ctx->guest_vers =3D=3D FFA_VERSION_1_0 ) > + { > + size_t n; > + struct ffa_partition_info_1_1 *src =3D ffa_rx; > + struct ffa_partition_info_1_0 *dst =3D ctx->rx; > + > + for ( n =3D 0; n < *count; n++ ) > + { > + dst[n].id =3D src[n].id; > + dst[n].execution_context =3D src[n].execution_context; > + dst[n].partition_properties =3D src[n].partition_properties; > + } > + } > + else > + { > + size_t sz =3D *count * sizeof(struct ffa_partition_info_1_1); > + > + memcpy(ctx->rx, ffa_rx, sz); > + } > + ffa_rx_release(); > + ctx->tx_is_mine =3D false; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static uint32_t handle_rx_release(void) > +{ > + uint32_t ret =3D FFA_RET_DENIED; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + > + spin_lock(&ctx->lock); > + if ( !ctx->page_count || ctx->tx_is_mine ) > + goto out; > + ret =3D FFA_RET_OK; > + ctx->tx_is_mine =3D true; > +out: > + spin_unlock(&ctx->lock); > + > + return ret; > +} > + > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint3= 2_t fid) > +{ > + struct arm_smccc_1_2_regs arg =3D { .a0 =3D fid, }; > + struct arm_smccc_1_2_regs resp =3D { }; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t src_dst; > + uint64_t mask; > + > + if ( smccc_is_conv_64(fid) ) > + mask =3D 0xffffffffffffffff; > + else > + mask =3D 0xffffffff; > + > + src_dst =3D get_user_reg(regs, 1); > + if ( (src_dst >> 16) !=3D get_vm_id(d) ) > + { > + resp.a0 =3D FFA_ERROR; > + resp.a2 =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + arg.a1 =3D src_dst; > + arg.a2 =3D get_user_reg(regs, 2) & mask; > + arg.a3 =3D get_user_reg(regs, 3) & mask; > + arg.a4 =3D get_user_reg(regs, 4) & mask; > + arg.a5 =3D get_user_reg(regs, 5) & mask; > + arg.a6 =3D get_user_reg(regs, 6) & mask; > + arg.a7 =3D get_user_reg(regs, 7) & mask; > + > + while ( true ) > + { > + arm_smccc_1_2_smc(&arg, &resp); > + > + switch ( resp.a0 ) > + { > + case FFA_INTERRUPT: > + ctx->interrupted =3D true; > + goto out; > + case FFA_ERROR: > + case FFA_SUCCESS_32: > + case FFA_SUCCESS_64: > + case FFA_MSG_SEND_DIRECT_RESP_32: > + case FFA_MSG_SEND_DIRECT_RESP_64: > + goto out; > + default: > + /* Bad fid, report back. */ > + memset(&arg, 0, sizeof(arg)); > + arg.a0 =3D FFA_ERROR; > + arg.a1 =3D src_dst; > + arg.a2 =3D FFA_RET_NOT_SUPPORTED; > + continue; > + } > + } > + > +out: > + set_user_reg(regs, 0, resp.a0); > + set_user_reg(regs, 1, resp.a1 & mask); > + set_user_reg(regs, 2, resp.a2 & mask); > + set_user_reg(regs, 3, resp.a3 & mask); > + set_user_reg(regs, 4, resp.a4 & mask); > + set_user_reg(regs, 5, resp.a5 & mask); > + set_user_reg(regs, 6, resp.a6 & mask); > + set_user_reg(regs, 7, resp.a7 & mask); > +} > + > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > + struct ffa_address_range *range, uint32_t range= _count, > + unsigned int start_page_idx, > + unsigned int *last_page_idx) > +{ > + unsigned int pg_idx =3D start_page_idx; > + unsigned long gfn; > + unsigned int n; > + unsigned int m; > + p2m_type_t t; > + uint64_t addr; > + > + for ( n =3D 0; n < range_count; n++ ) > + { > + for ( m =3D 0; m < range[n].page_count; m++ ) > + { > + if ( pg_idx >=3D shm->page_count ) > + return FFA_RET_INVALID_PARAMETERS; > + > + addr =3D read_atomic(&range[n].address); > + gfn =3D gaddr_to_gfn(addr + m * PAGE_SIZE); > + shm->pages[pg_idx] =3D get_page_from_gfn(d, gfn, &t, P2M_ALL= OC); > + if ( !shm->pages[pg_idx] ) > + return FFA_RET_DENIED; > + pg_idx++; > + /* Only normal RAM for now */ > + if ( t !=3D p2m_ram_rw ) > + return FFA_RET_DENIED; > + } > + } > + > + *last_page_idx =3D pg_idx; > + > + return FFA_RET_OK; > +} > + > +static void put_shm_pages(struct ffa_shm_mem *shm) > +{ > + unsigned int n; > + > + for ( n =3D 0; n < shm->page_count && shm->pages[n]; n++ ) > + { > + put_page(shm->pages[n]); > + shm->pages[n] =3D NULL; > + } > +} > + > +static void init_range(struct ffa_address_range *addr_range, > + paddr_t pa) > +{ > + memset(addr_range, 0, sizeof(*addr_range)); > + addr_range->address =3D pa; > + addr_range->page_count =3D 1; > +} > + > +static int share_shm(struct ffa_shm_mem *shm) > +{ > + uint32_t max_frag_len =3D ffa_page_count * PAGE_SIZE; > + struct ffa_mem_transaction_1_1 *descr =3D ffa_tx; > + struct ffa_mem_access *mem_access_array; > + struct ffa_mem_region *region_descr; > + struct ffa_address_range *addr_range; > + paddr_t pa; > + paddr_t last_pa; > + unsigned int n; > + uint32_t frag_len; > + uint32_t tot_len; > + int ret; > + unsigned int range_count; > + unsigned int range_base; > + bool first; > + > + memset(descr, 0, sizeof(*descr)); > + descr->sender_id =3D shm->sender_id; > + descr->global_handle =3D shm->handle; > + descr->mem_reg_attr =3D FFA_NORMAL_MEM_REG_ATTR; > + descr->mem_access_count =3D 1; > + descr->mem_access_size =3D sizeof(*mem_access_array); > + descr->mem_access_offs =3D sizeof(*descr); > + mem_access_array =3D (void *)(descr + 1); > + region_descr =3D (void *)(mem_access_array + 1); > + > + memset(mem_access_array, 0, sizeof(*mem_access_array)); > + mem_access_array[0].access_perm.endpoint_id =3D shm->ep_id; > + mem_access_array[0].access_perm.perm =3D FFA_MEM_ACC_RW; > + mem_access_array[0].region_offs =3D (vaddr_t)region_descr - (vaddr_t= )ffa_tx; > + > + memset(region_descr, 0, sizeof(*region_descr)); > + region_descr->total_page_count =3D shm->page_count; > + > + region_descr->address_range_count =3D 1; > + last_pa =3D page_to_maddr(shm->pages[0]); > + for ( n =3D 1; n < shm->page_count; last_pa =3D pa, n++ ) > + { > + pa =3D page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE =3D=3D pa ) > + { > + continue; > + } > + region_descr->address_range_count++; > + } > + > + tot_len =3D sizeof(*descr) + sizeof(*mem_access_array) + > + sizeof(*region_descr) + > + region_descr->address_range_count * sizeof(*addr_range); > + > + addr_range =3D region_descr->address_range_array; > + frag_len =3D (vaddr_t)(addr_range + 1) - (vaddr_t)ffa_tx; > + last_pa =3D page_to_maddr(shm->pages[0]); > + init_range(addr_range, last_pa); > + first =3D true; > + range_count =3D 1; > + range_base =3D 0; > + for ( n =3D 1; n < shm->page_count; last_pa =3D pa, n++ ) > + { > + pa =3D page_to_maddr(shm->pages[n]); > + if ( last_pa + PAGE_SIZE =3D=3D pa ) > + { > + addr_range->page_count++; > + continue; > + } > + > + if ( frag_len =3D=3D max_frag_len ) > + { > + if ( first ) > + { > + ret =3D ffa_mem_share(tot_len, frag_len, 0, 0, &shm->han= dle); > + first =3D false; > + } > + else > + { > + ret =3D ffa_mem_frag_tx(shm->handle, frag_len, shm->send= er_id); > + } > + if ( ret <=3D 0) > + return ret; > + range_base =3D range_count; > + range_count =3D 0; > + frag_len =3D sizeof(*addr_range); > + addr_range =3D ffa_tx; > + } > + else > + { > + frag_len +=3D sizeof(*addr_range); > + addr_range++; > + } > + init_range(addr_range, pa); > + range_count++; > + } > + > + if ( first ) > + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > + else > + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > +} > + > +static int read_mem_transaction(uint32_t ffa_vers, void *buf, size_t ble= n, > + struct ffa_mem_transaction_x *trans) > +{ > + uint16_t mem_reg_attr; > + uint32_t flags; > + uint32_t count; > + uint32_t offs; > + uint32_t size; > + > + if ( ffa_vers >=3D FFA_VERSION_1_1 ) > + { > + struct ffa_mem_transaction_1_1 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr =3D buf; > + trans->sender_id =3D read_atomic(&descr->sender_id); > + mem_reg_attr =3D read_atomic(&descr->mem_reg_attr); > + flags =3D read_atomic(&descr->flags); > + trans->global_handle =3D read_atomic(&descr->global_handle); > + trans->tag =3D read_atomic(&descr->tag); > + > + count =3D read_atomic(&descr->mem_access_count); > + size =3D read_atomic(&descr->mem_access_size); > + offs =3D read_atomic(&descr->mem_access_offs); > + } > + else > + { > + struct ffa_mem_transaction_1_0 *descr; > + > + if ( blen < sizeof(*descr) ) > + return FFA_RET_INVALID_PARAMETERS; > + > + descr =3D buf; > + trans->sender_id =3D read_atomic(&descr->sender_id); > + mem_reg_attr =3D read_atomic(&descr->mem_reg_attr); > + flags =3D read_atomic(&descr->flags); > + trans->global_handle =3D read_atomic(&descr->global_handle); > + trans->tag =3D read_atomic(&descr->tag); > + > + count =3D read_atomic(&descr->mem_access_count); > + size =3D sizeof(struct ffa_mem_access); > + offs =3D offsetof(struct ffa_mem_transaction_1_0, mem_access_arr= ay); > + } > + > + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_M= AX || > + count > UINT8_MAX || offs > UINT16_MAX ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Check that the endpoint memory access descriptor array fits */ > + if ( size * count + offs > blen ) > + return FFA_RET_INVALID_PARAMETERS; > + > + trans->mem_reg_attr =3D mem_reg_attr; > + trans->flags =3D flags; > + trans->mem_access_size =3D size; > + trans->mem_access_count =3D count; > + trans->mem_access_offs =3D offs; > + return 0; > +} > + > +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int off= s, > + unsigned int frag_len) > +{ > + struct domain *d =3D current->domain; > + unsigned int o =3D offs; > + unsigned int l; > + int ret; > + > + if ( frag_len < o ) > + return FFA_RET_INVALID_PARAMETERS; > + > + /* Fill up the first struct ffa_address_range */ > + l =3D min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_= offset); > + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); > + s->range_offset +=3D l; > + o +=3D l; > + if ( s->range_offset !=3D sizeof(s->range) ) > + goto out; > + s->range_offset =3D 0; > + > + while ( true ) > + { > + ret =3D get_shm_pages(d, s->shm, &s->range, 1, s->current_page_i= dx, > + &s->current_page_idx); > + if ( ret ) > + return ret; > + if ( s->range_count =3D=3D 1 ) > + return 0; > + s->range_count--; > + if ( frag_len - o < sizeof(s->range) ) > + break; > + memcpy(&s->range, s->buf + o, sizeof(s->range)); > + o +=3D sizeof(s->range); > + } > + > + /* Collect any remaining bytes for the next struct ffa_address_range= */ > + s->range_offset =3D frag_len - o; > + memcpy(&s->range, s->buf + o, frag_len - o); > +out: > + s->frag_offset +=3D frag_len; > + return s->frag_offset; > +} > + > +static void handle_mem_share(struct cpu_user_regs *regs) > +{ > + uint32_t tot_len =3D get_user_reg(regs, 1); > + uint32_t frag_len =3D get_user_reg(regs, 2); > + uint64_t addr =3D get_user_reg(regs, 3); > + uint32_t page_count =3D get_user_reg(regs, 4); > + struct ffa_mem_transaction_x trans; > + struct ffa_mem_access *mem_access; > + struct ffa_mem_region *region_descr; > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + struct ffa_shm_mem *shm =3D NULL; > + unsigned int last_page_idx =3D 0; > + uint32_t range_count; > + uint32_t region_offs; > + int ret =3D FFA_RET_DENIED; > + uint32_t handle_hi =3D 0; > + uint32_t handle_lo =3D 0; > + > + /* > + * We're only accepting memory transaction descriptors via the rx/tx > + * buffer. > + */ > + if ( addr ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + /* Check that fragment legnth doesn't exceed total length */ > + if ( frag_len > tot_len ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + spin_lock(&ctx->lock); > + > + if ( frag_len > ctx->page_count * PAGE_SIZE ) > + goto out_unlock; > + > + if ( !ffa_page_count ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out_unlock; > + } > + > + ret =3D read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &tr= ans); > + if ( ret ) > + goto out_unlock; > + > + if ( trans.mem_reg_attr !=3D FFA_NORMAL_MEM_REG_ATTR ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out; > + } > + > + /* Only supports sharing it with one SP for now */ > + if ( trans.mem_access_count !=3D 1 ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + if ( trans.sender_id !=3D get_vm_id(d) ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out_unlock; > + } > + > + /* Check that it fits in the supplied data */ > + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) > + goto out_unlock; > + > + mem_access =3D (void *)((vaddr_t)ctx->tx + trans.mem_access_offs); > + if ( read_atomic(&mem_access->access_perm.perm) !=3D FFA_MEM_ACC_RW = ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_offs =3D read_atomic(&mem_access->region_offs); > + if ( sizeof(*region_descr) + region_offs > frag_len ) > + { > + ret =3D FFA_RET_NOT_SUPPORTED; > + goto out_unlock; > + } > + > + region_descr =3D (void *)((vaddr_t)ctx->tx + region_offs); > + range_count =3D read_atomic(®ion_descr->address_range_count); > + page_count =3D read_atomic(®ion_descr->total_page_count); > + > + shm =3D xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); > + if ( !shm ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out; > + } > + shm->sender_id =3D trans.sender_id; > + shm->ep_id =3D read_atomic(&mem_access->access_perm.endpoint_id); > + shm->page_count =3D page_count; > + > + if ( frag_len !=3D tot_len ) > + { > + struct mem_frag_state *s =3D xzalloc(struct mem_frag_state); > + > + if ( !s ) > + { > + ret =3D FFA_RET_NO_MEMORY; > + goto out; > + } > + s->shm =3D shm; > + s->range_count =3D range_count; > + s->buf =3D ctx->tx; > + s->buf_size =3D ffa_page_count * PAGE_SIZE; > + ret =3D add_mem_share_frag(s, sizeof(*region_descr) + region_of= fs, > + frag_len); > + if ( ret <=3D 0 ) > + { > + xfree(s); > + if ( ret < 0 ) > + goto out; > + } > + else > + { > + shm->handle =3D next_handle++; > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + list_add_tail(&s->list, &ctx->frag_list); > + } > + goto out_unlock; > + } > + > + /* > + * Check that the Composite memory region descriptor fits. > + */ > + if ( sizeof(*region_descr) + region_offs + > + range_count * sizeof(struct ffa_address_range) > frag_len ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + ret =3D get_shm_pages(d, shm, region_descr->address_range_array, ran= ge_count, > + 0, &last_page_idx); > + if ( ret ) > + goto out; > + if ( last_page_idx !=3D shm->page_count ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + /* Note that share_shm() uses our tx buffer */ > + spin_lock(&ffa_buffer_lock); > + ret =3D share_shm(shm); > + spin_unlock(&ffa_buffer_lock); > + if ( ret ) > + goto out; > + > + spin_lock(&ffa_mem_list_lock); > + list_add_tail(&shm->list, &ffa_mem_list); > + spin_unlock(&ffa_mem_list_lock); > + > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > + > +out: > + if ( ret && shm ) > + { > + put_shm_pages(shm); > + xfree(shm); > + } > +out_unlock: > + spin_unlock(&ctx->lock); > + > + if ( ret > 0 ) > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.send= er_id); > + else if ( ret =3D=3D 0) > + set_regs_success(regs, handle_lo, handle_hi); > + else > + set_regs_error(regs, ret); > +} > + > +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, > + uint64_t handle) > +{ > + struct mem_frag_state *s; > + > + list_for_each_entry(s, &ctx->frag_list, list) > + if ( s->shm->handle =3D=3D handle ) > + return s; > + > + return NULL; > +} > + > +static void handle_mem_frag_tx(struct cpu_user_regs *regs) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t frag_len =3D get_user_reg(regs, 3); > + uint32_t handle_lo =3D get_user_reg(regs, 1); > + uint32_t handle_hi =3D get_user_reg(regs, 2); > + uint64_t handle =3D reg_pair_to_64(handle_hi, handle_lo); > + struct mem_frag_state *s; > + uint16_t sender_id =3D 0; > + int ret; > + > + spin_lock(&ctx->lock); > + s =3D find_frag_state(ctx, handle); > + if ( !s ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + sender_id =3D s->shm->sender_id; > + > + if ( frag_len > s->buf_size ) > + { > + ret =3D FFA_RET_INVALID_PARAMETERS; > + goto out; > + } > + > + ret =3D add_mem_share_frag(s, 0, frag_len); > + if ( ret =3D=3D 0 ) > + { > + /* Note that share_shm() uses our tx buffer */ > + spin_lock(&ffa_buffer_lock); > + ret =3D share_shm(s->shm); > + spin_unlock(&ffa_buffer_lock); > + if ( ret =3D=3D 0 ) > + { > + spin_lock(&ffa_mem_list_lock); > + list_add_tail(&s->shm->list, &ffa_mem_list); > + spin_unlock(&ffa_mem_list_lock); > + } > + else > + { > + put_shm_pages(s->shm); > + xfree(s->shm); > + } > + list_del(&s->list); > + xfree(s); > + } > + else if ( ret < 0 ) > + { > + put_shm_pages(s->shm); > + xfree(s->shm); > + list_del(&s->list); > + xfree(s); > + } > +out: > + spin_unlock(&ctx->lock); > + > + if ( ret > 0 ) > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id)= ; > + else if ( ret =3D=3D 0) > + set_regs_success(regs, handle_lo, handle_hi); > + else > + set_regs_error(regs, ret); > +} > + > +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) > +{ > + struct ffa_shm_mem *shm; > + uint32_t handle_hi; > + uint32_t handle_lo; > + int ret; > + > + spin_lock(&ffa_mem_list_lock); > + list_for_each_entry(shm, &ffa_mem_list, list) > + { > + if ( shm->handle =3D=3D handle ) > + goto found_it; > + } > + shm =3D NULL; > +found_it: > + spin_unlock(&ffa_mem_list_lock); > + > + if ( !shm ) > + return FFA_RET_INVALID_PARAMETERS; > + > + reg_pair_from_64(&handle_hi, &handle_lo, handle); > + ret =3D ffa_mem_reclaim(handle_lo, handle_hi, flags); > + if ( ret ) > + return ret; > + > + spin_lock(&ffa_mem_list_lock); > + list_del(&shm->list); > + spin_unlock(&ffa_mem_list_lock); > + > + put_shm_pages(shm); > + xfree(shm); > + > + return ret; > +} > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > +{ > + struct domain *d =3D current->domain; > + struct ffa_ctx *ctx =3D d->arch.ffa; > + uint32_t count; > + uint32_t e; > + > + if ( !ctx ) > + return false; > + > + switch ( fid ) > + { > + case FFA_VERSION: > + handle_version(regs); > + return true; > + case FFA_ID_GET: > + set_regs_success(regs, get_vm_id(d), 0); > + return true; > + case FFA_RXTX_MAP_32: > +#ifdef CONFIG_ARM_64 > + case FFA_RXTX_MAP_64: > +#endif > + e =3D handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(r= egs, 2), > + get_user_reg(regs, 3)); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_RXTX_UNMAP: > + e =3D handle_rxtx_unmap(); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_PARTITION_INFO_GET: > + e =3D handle_partition_info_get(get_user_reg(regs, 1), > + get_user_reg(regs, 2), > + get_user_reg(regs, 3), > + get_user_reg(regs, 4), > + get_user_reg(regs, 5), &count); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, count, 0); > + return true; > + case FFA_RX_RELEASE: > + e =3D handle_rx_release(); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_MSG_SEND_DIRECT_REQ_32: > +#ifdef CONFIG_ARM_64 > + case FFA_MSG_SEND_DIRECT_REQ_64: > +#endif > + handle_msg_send_direct_req(regs, fid); > + return true; > + case FFA_MEM_SHARE_32: > +#ifdef CONFIG_ARM_64 > + case FFA_MEM_SHARE_64: > +#endif > + handle_mem_share(regs); > + return true; > + case FFA_MEM_RECLAIM: > + e =3D handle_mem_reclaim(reg_pair_to_64(get_user_reg(regs, 2), > + get_user_reg(regs, 1)), > + get_user_reg(regs, 3)); > + if ( e ) > + set_regs_error(regs, e); > + else > + set_regs_success(regs, 0, 0); > + return true; > + case FFA_MEM_FRAG_TX: > + handle_mem_frag_tx(regs); > + return true; > + > + default: > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > + return false; > + } > +} > + > +int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + struct ffa_ctx *ctx; > + unsigned int n; > + unsigned int m; > + unsigned int c_pos; > + int32_t res; > + > + if ( !ffa_version || !ffa_enabled ) > + return 0; > + > + ctx =3D xzalloc(struct ffa_ctx); > + if ( !ctx ) > + return -ENOMEM; > + > + for ( n =3D 0; n < subsr_vm_created_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subsr_vm_created[n], get_vm_id(d)= , > + FFA_MSG_SEND_VM_CREATED); > + if ( res ) > + { > + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %= u to %u: res %d\n", > + get_vm_id(d), subsr_vm_created[n], res); > + c_pos =3D n; > + goto err; > + } > + } > + > + INIT_LIST_HEAD(&ctx->frag_list); > + > + d->arch.ffa =3D ctx; > + > + return 0; > + > +err: > + /* Undo any already sent vm created messaged */ > + for ( n =3D 0; n < c_pos; n++ ) > + for ( m =3D 0; m < subsr_vm_destroyed_count; m++ ) > + if ( subsr_vm_destroyed[m] =3D=3D subsr_vm_created[n] ) > + ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(= d), > + FFA_MSG_SEND_VM_DESTROYED); > + return -ENOMEM; > +} > + > +int ffa_relinquish_resources(struct domain *d) > +{ > + struct ffa_ctx *ctx =3D d->arch.ffa; > + unsigned int n; > + int32_t res; > + > + if ( !ctx ) > + return 0; > + > + for ( n =3D 0; n < subsr_vm_destroyed_count; n++ ) > + { > + res =3D ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(= d), > + FFA_MSG_SEND_VM_DESTROYED); > + > + if ( res ) > + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_i= d %u to %u: res %d\n", > + get_vm_id(d), subsr_vm_destroyed[n], res); > + } > + > + XFREE(d->arch.ffa); > + > + return 0; > +} > + > +static bool __init init_subscribers(void) > +{ > + struct ffa_partition_info_1_1 *fpi; > + bool ret =3D false; > + uint32_t count; > + uint32_t e; > + uint32_t n; > + uint32_t c_pos; > + uint32_t d_pos; > + > + if ( ffa_version < FFA_VERSION_1_1 ) > + return true; > + > + e =3D ffa_partition_info_get(0, 0, 0, 0, 1, &count); > + ffa_rx_release(); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", (int)e= ); > + goto out; > + } > + > + fpi =3D ffa_rx; > + subsr_vm_created_count =3D 0; > + subsr_vm_destroyed_count =3D 0; > + for ( n =3D 0; n < count; n++ ) > + { > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) > + subsr_vm_created_count++; > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) > + subsr_vm_destroyed_count++; > + } > + > + if ( subsr_vm_created_count ) > + subsr_vm_created =3D xzalloc_array(uint16_t, subsr_vm_created_co= unt); > + if ( subsr_vm_destroyed_count ) > + subsr_vm_destroyed =3D xzalloc_array(uint16_t, subsr_vm_destroye= d_count); > + if ( (subsr_vm_created_count && !subsr_vm_created) || > + (subsr_vm_destroyed_count && !subsr_vm_destroyed) ) > + { > + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"= ); > + subsr_vm_created_count =3D 0; > + subsr_vm_destroyed_count =3D 0; > + XFREE(subsr_vm_created); > + XFREE(subsr_vm_destroyed); > + goto out; > + } > + > + for ( c_pos =3D 0, d_pos =3D 0, n =3D 0; n < count; n++ ) > + { > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) > + subsr_vm_created[c_pos++] =3D fpi[n].id; > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED= ) > + subsr_vm_destroyed[d_pos++] =3D fpi[n].id; > + } > + > + ret =3D true; > +out: > + ffa_rx_release(); > + return ret; > +} > + > +static int __init ffa_init(void) > +{ > + uint32_t vers; > + uint32_t e; > + unsigned int major_vers; > + unsigned int minor_vers; > + > + /* > + * psci_init_smccc() updates this value with what's reported by EL-3 > + * or secure world. > + */ > + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) > + { > + printk(XENLOG_ERR > + "ffa: unsupported SMCCC version %#x (need at least %#x)\n= ", > + smccc_ver, ARM_SMCCC_VERSION_1_2); > + return 0; > + } > + > + if ( !ffa_get_version(&vers) ) > + return 0; > + > + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) > + { > + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers)= ; > + return 0; > + } > + > + major_vers =3D (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR= _MASK; > + minor_vers =3D vers & FFA_VERSION_MINOR_MASK; > + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", > + FFA_VERSION_MAJOR, FFA_VERSION_MINOR); > + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > + major_vers, minor_vers); > + > + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || > + !check_mandatory_feature(FFA_RX_RELEASE) || > +#ifdef CONFIG_ARM_64 > + !check_mandatory_feature(FFA_RXTX_MAP_64) || > + !check_mandatory_feature(FFA_MEM_SHARE_64) || > +#endif > +#ifdef CONFIG_ARM_32 > + !check_mandatory_feature(FFA_RXTX_MAP_32) || > +#endif > + !check_mandatory_feature(FFA_RXTX_UNMAP) || > + !check_mandatory_feature(FFA_MEM_SHARE_32) || > + !check_mandatory_feature(FFA_MEM_FRAG_TX) || > + !check_mandatory_feature(FFA_MEM_RECLAIM) || > + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > + return 0; > + > + ffa_rx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_rx ) > + return 0; > + > + ffa_tx =3D alloc_xenheap_pages(0, 0); > + if ( !ffa_tx ) > + goto err_free_ffa_rx; > + > + e =3D ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); > + if ( e ) > + { > + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", (int)e)= ; > + goto err_free_ffa_tx; > + } > + ffa_page_count =3D 1; > + ffa_version =3D vers; > + > + if ( !init_subscribers() ) > + goto err_free_ffa_tx; > + > + return 0; > + > +err_free_ffa_tx: > + free_xenheap_pages(ffa_tx, 0); > + ffa_tx =3D NULL; > +err_free_ffa_rx: > + free_xenheap_pages(ffa_rx, 0); > + ffa_rx =3D NULL; > + ffa_page_count =3D 0; > + ffa_version =3D 0; > + XFREE(subsr_vm_created); > + subsr_vm_created_count =3D 0; > + XFREE(subsr_vm_destroyed); > + subsr_vm_destroyed_count =3D 0; > + return 0; > +} > + > +__initcall(ffa_init); > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm= /domain.h > index ed63c2b6f91f..b3dee269bced 100644 > --- a/xen/arch/arm/include/asm/domain.h > +++ b/xen/arch/arm/include/asm/domain.h > @@ -103,6 +103,10 @@ struct arch_domain > void *tee; > #endif >=20 > +#ifdef CONFIG_FFA > + void *ffa; > +#endif > + > bool directmap; > } __cacheline_aligned; >=20 > diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ff= a.h > new file mode 100644 > index 000000000000..4f4a739345bd > --- /dev/null > +++ b/xen/arch/arm/include/asm/ffa.h > @@ -0,0 +1,71 @@ > +/* > + * xen/arch/arm/ffa.c > + * > + * Arm Firmware Framework for ARMv8-A(FFA) mediator > + * > + * Copyright (C) 2021 Linaro Limited > + * > + * Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without restriction, > + * including without limitation the rights to use, copy, modify, merge, > + * publish, distribute, sublicense, and/or sell copies of the Software, > + * and to permit persons to whom the Software is furnished to do so, > + * subject to the following conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT= . > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#ifndef __ASM_ARM_FFA_H__ > +#define __ASM_ARM_FFA_H__ > + > +#include > + > +#include > +#include > + > +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) > +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) > + > +static inline bool is_ffa_fid(uint32_t fid) > +{ > + uint32_t fn =3D fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >=3D FFA_FNUM_MIN_VALUE && fn <=3D FFA_FNUM_MAX_VALUE; > +} > + > +#ifdef CONFIG_FFA > +#define FFA_NR_FUNCS 11 > + > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); > +int ffa_domain_init(struct domain *d, bool ffa_enabled); > +int ffa_relinquish_resources(struct domain *d); > +#else > +#define FFA_NR_FUNCS 0 > + > +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t = fid) > +{ > + return false; > +} > + > +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) > +{ > + return 0; > +} > + > +static inline int ffa_relinquish_resources(struct domain *d) > +{ > + return 0; > +} > +#endif > + > +#endif /*__ASM_ARM_FFA_H__*/ > diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c > index 6f90c08a6304..34586025eff8 100644 > --- a/xen/arch/arm/vsmc.c > +++ b/xen/arch/arm/vsmc.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -32,7 +33,7 @@ > #define XEN_SMCCC_FUNCTION_COUNT 3 >=20 > /* Number of functions currently supported by Standard Service Service Ca= lls. */ > -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) > +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) >=20 > static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) > { > @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_re= gs *regs) > return do_vpsci_0_1_call(regs, fid); > } >=20 > +static bool is_psci_fid(uint32_t fid) > +{ > + uint32_t fn =3D fid & ARM_SMCCC_FUNC_MASK; > + > + return fn >=3D 0 && fn <=3D 0x1fU; > +} > + > /* PSCI 0.2 interface and other Standard Secure Calls */ > static bool handle_sssc(struct cpu_user_regs *regs) > { > uint32_t fid =3D (uint32_t)get_user_reg(regs, 0); >=20 > - if ( do_vpsci_0_2_call(regs, fid) ) > - return true; > + if ( is_psci_fid(fid) ) > + return do_vpsci_0_2_call(regs, fid); > + > + if ( is_ffa_fid(fid) ) > + return ffa_handle_call(regs, fid); >=20 > switch ( fid ) > { > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.= h > index ab05fe12b0de..53f8d44a6a8e 100644 > --- a/xen/include/public/arch-arm.h > +++ b/xen/include/public/arch-arm.h > @@ -318,6 +318,8 @@ struct xen_arch_domainconfig { > /* IN/OUT */ > uint8_t gic_version; > /* IN */ > + uint8_t ffa_enabled; > + /* IN */ > uint16_t tee_type; > /* IN */ > uint32_t nr_spis; > --=20 > 2.31.1 >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:55:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:55:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367197.598257 (Exim 4.92) (envelope-from ) id 1oBvZ7-0002QA-HV; Thu, 14 Jul 2022 09:55:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367197.598257; Thu, 14 Jul 2022 09:55:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvZ7-0002Q3-DD; Thu, 14 Jul 2022 09:55:25 +0000 Received: by outflank-mailman (input) for mailman id 367197; Thu, 14 Jul 2022 09:55:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvZ6-0002Px-Oo for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:55:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70049.outbound.protection.outlook.com [40.107.7.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13c8e303-035b-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 11:55:23 +0200 (CEST) Received: from FR3P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::16) by DBBPR08MB4491.eurprd08.prod.outlook.com (2603:10a6:10:d2::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 09:55:20 +0000 Received: from VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::9d) by FR3P281CA0126.outlook.office365.com (2603:10a6:d10:94::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.5 via Frontend Transport; Thu, 14 Jul 2022 09:55:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT022.mail.protection.outlook.com (10.152.18.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 09:55:19 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Thu, 14 Jul 2022 09:55:19 +0000 Received: from c09948a20837.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C7ECF1EB-692B-4A89-8B91-5787F25BD70E.1; Thu, 14 Jul 2022 09:55:13 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c09948a20837.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 09:55:13 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DU2PR08MB7328.eurprd08.prod.outlook.com (2603:10a6:10:2e7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 09:55:11 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 09:55:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13c8e303-035b-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Wr54NL1bo/QQrDKtS+0QZnGWTYb/4Oc96SqXJpXupY0uw2vZKlFlBwFTTULzKSc5Pas17k6/LrW+hFKKXB0lZuc5Q7Ls/SdQeQn073FmJP4qQ678fDcWF+cWz+yY7BjNb5CFi7KsoHZAQxOBp1UvxSvOOVMautY+2qASX7STk60btQOfgpayKvR4YH7Fa1QqumORTqIjm0vTZzY+gl0dE4sak67pn8TcBpAIZD6ih64BYECPGOopnx0md5UcWmXTLRlOif12+v4N+AUDkQBT81SlNYrje6jFuAujM5yD1pkAlr9OEewjJowi5Stfq+ePsPVKxv1nwOJxH/jvebYK1Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=GIuQNzkbt9w2jH5SRL8qQdr5OcbIqbIiuih8PffehIys7eYGDZeHIbOXJv5tofvKDq/xFDjMkDCxABUn+lv3McYAcFLLWYKCdzhqduYlg6pXCNF0PbDwoZmwDk8REObJ4GBK7M73fPI0ANyrXxkrGB3UUOM35FfNC6IyIPGaQtvFlxgfdLgGWVawWGj2/CpSf473036Ck+YBjbNbcDwolQB5aiBnphYMYKQUpLUUT/Smh6mkXr+dXeUTpHWcjN2QFv8GUdwQ9D7ocl2FnVmQjXlhv4RdoZC/V8JgVzkGx6tG77Tcq9EZyLjxb1JSUupl5nDnrlRcU2SOcaFOnhPI2Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=u764LojPr7BeYreyb6z9DsXv8MUaAJ+QwoieRA/ov0cYkc9sYM4e4lsTrQBEFqsfVJfw1v6MPgVMoZwOgc4TirBZ1A+1k5RS5D92/HUWJolVDZZk1EyNXR6sZFRw92buANr5f8x4Pjjv8WlNhbIbWqY1x9Uh8FLtpZU07wNLh+g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJWe6Xv0ZuRBE21P78pwHaP4pEq7EZYXB6lFUpFrztLSuBXlkWSr4xKLKQ6NXVCQXibsOKd19d4THyp6rjc65xpXXkjhKtI8Cphvv9GOYZHtZOt9i9RDzpiDUFPM27Uvg44LCxL6uBdBWtI+h4duaCXDU9Je7W1i1PL5B9/Qpwbp4Wgf3/adUw5Ao8a/EYtq44kaM0NZwefjzWIVh5jkotC4Qvfi86FPGVjhiHhkawiwawEV+RpClhXwwPuccaPwjLwGRaYmsgWuCo0imafr6wQuMTjtFwePAsADlMfDBPJww6kqZTlfB8vpgnCb41F7JIN9kao6Op7fEeyjkZF/BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=YKolNt4AkNRCLY7oEmzKBnPvKw3fkGat2EIyWrzhk/I7WHeEBP8nAZSh1fFk9j6LMUNfwu74QPNVVtXihGLH9GqV6q04stKbA59q0ec21/0kqsI5xHjLTvgieLziXqY1rfvSli5BY1RyRowaX+KO/oM9UjxLhOhQmVDN/fcbfLxQN9wk0C958qYQI3xyMX7fOrys7MVEifi4HyWZhkghejbE2l+vy3hMgIXnD2ZJbREHrWWqN1cyL4y3m9q5SERfDvOaLcMOIFLCTDnP4sEryU6VqvoqJF9HRzWnftr9blKTlRYZStXT2yqoBfeuxYrJntsB51uUNVVCBETKPeAA+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zhelHElerS/PLSCl+hS++8jQdHm5dviKAPMHRkrLOVA=; b=u764LojPr7BeYreyb6z9DsXv8MUaAJ+QwoieRA/ov0cYkc9sYM4e4lsTrQBEFqsfVJfw1v6MPgVMoZwOgc4TirBZ1A+1k5RS5D92/HUWJolVDZZk1EyNXR6sZFRw92buANr5f8x4Pjjv8WlNhbIbWqY1x9Uh8FLtpZU07wNLh+g= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItg Date: Thu, 14 Jul 2022 09:55:11 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 69964E85206DE04689CD23529DDE7A60.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 77c9262e-538e-4cb6-6ad8-08da657ef665 x-ms-traffictypediagnostic: DU2PR08MB7328:EE_|VE1EUR03FT022:EE_|DBBPR08MB4491:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: REagUPrtZ/0Q6+hHBF4bORLyInrZQZ9+q1alF2vO7QyOgklhgwa+0MVBvxmJkenrzmWkKr/f2fCLfewIK5OXnD4QQzhZRIcqg3kcPwSaX6czx7AZyqr3SBs+gZpu/SLVhZhu1U2rK1gssGJBfRH3P+Oxxkkio1ddiW6lSgVETjrz+M+unOUTmDU0LbYGF5L770whMCc+557aME2/Y1oonilb4bCE2uBW74nVKFoWA3LVVFkrrGBEB+M6PsG80RYJC+ATW3H0X5svZ9RvyZXBU3+6S0BYvZMvUYGAL4c/DuNyr/6aG0qTJBQyru3zRaFhT3qU9RyCNEHftRM5dTh/DCCbGjvAguQr/pVysXbqEDOCwah41vtGKxBwFQEffv6P0edKRhHUDbJcPdL6JXLwSYUv4uWvC1ZJV/lLaCCsFMqjp48SYGxr1ntxYiDddWTzEL47nP/K3nHbXf+HHDRaXePyK2rCztEhc5/yy3BaDViBELoAargWeBzDD/AZs9M+BNR+vV/Jy+BD+q1WnvnzAvEpZjSFT8H5nfR6nek+Tetg2M78YGVgdxPEyOdchnhot2zOM7dt39f2FQkR5poR5TFq5wk6kCRhhgEWIM5oJ6uptQKFSMznQY5HiXR92iLuakJTCgbvxCWNdpphGf0MJ3Y7+82Knfiditx6AR8xdwc7IqCaW3yUO3YGG6OttZuo1gxxXvTed3w4lEWwZVLhBInavKOauLK7Qgc1uL6T6eaxcOZ0JrKOI+v5rldTsRFTf5cJA/hYQkTgLaW/wG25bIXa/+gdFBPCh3qvYr+um8Xm8LwQBrN8KqwEuE+yrgvf X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(346002)(136003)(376002)(5660300002)(316002)(6916009)(52536014)(2906002)(9686003)(54906003)(38070700005)(122000001)(6506007)(478600001)(41300700001)(33656002)(26005)(186003)(66556008)(76116006)(4326008)(71200400001)(64756008)(66446008)(66946007)(8676002)(55016003)(83380400001)(38100700002)(7696005)(8936002)(86362001)(66476007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7328 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b4fd5db9-0433-4717-341a-08da657ef13a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5tOI6LzRi7eoMP/rVCut9cHV2bxdsbxkxol07RNL5ZOZi8ldXnOUxNv6GVHCpEoNCOAAPLcwzv2ReuJpkO6SsTP6LlGprD1EVja7CPilDwfqfLPY4j6/jtlfy+ksvYFhAZQexNgqibHGaGJXciTEQfno4bKEPoNqchoxaXOQ6HiC5wHuv5HRTsXRpNfgfWwkHGZzIsksX6G/mvnpZQjmL8otWr7d7Btb9UlZmde5qwTgdmUBIkFdz7A7kuoHgtu+scXaHH+Fj6hTJwtvHarRcjoQyKKPh3TBx0kQGep/5+XHZrTnh3rrRnlPVlSQhbA9u4y1CMf2ajIW9MLmva5I1YMprOBNG+BTF1ou3+hK6yjA1IxGg+eRNmlU0MlBotkB6dTLtO2h2OAFXDVrBO0TTcyLvEPdabQqlqI1t8IM7os+vsIS+VEkEsJ/GH1k3+MiMSn+He3MrvByJfpnhJivBTAcXydZQc87qnJvPsSFSKOhIrEZbZFfycWpuPLO3yjD6lwIU8c71/GKqRtnX6tOAv2a0YooNe0qQzaEvfSe5BQrVaWUDa6tOTm4Y9NzS3CZmorivOlhhYVZlZUIYYze1Xfj+M3mRUp+sLxqqwEYAIW5Xj1cE2LDEBZ2u6mzBRdaG6CbQ4Mv2ksPedIuIUOkAHsF14jveKZHIdbJfufU9UzR/ESEvQ0id2bzkl3YPJRZ5xy4xGlzUS/W7GQjgtYBs0sVLck7iFt2IN7PQ6Sltf3r+BH/15NKWQc5T1/91ndOEa+HsuFmMU8mcvH/NeIf2BNF3MVnsMjV2wgNT8rFe5QMo6jCQPOVtMXPkeQFrJBj X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966006)(40470700004)(36840700001)(82740400003)(41300700001)(9686003)(5660300002)(26005)(70206006)(70586007)(356005)(2906002)(7696005)(478600001)(8936002)(82310400005)(86362001)(6506007)(52536014)(40460700003)(47076005)(336012)(83380400001)(36860700001)(186003)(6862004)(54906003)(55016003)(316002)(40480700001)(4326008)(8676002)(33656002)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:55:19.9379 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 77c9262e-538e-4cb6-6ad8-08da657ef665 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT022.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4491 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4+DQo+ID4NCj4gPiBT b3JyeSBmb3IgcmVwbHlpbmcgbGF0ZXIsIEkgcGFpZCBzb21ldGltZSB0byBjaGVjayB0aGUgY29k ZSBhZ2FpbiwNCj4gPiBhbmQgZHJldyBhIHRhYmxlIGxpa2UgYmVsb3csIEkgaWdub3JlIHR3byBj b2x1bW5zIHdoZW4gbnVtYV9vZmY9dHJ1ZQ0KPiA+IGFuZCBhY3BpX251bWE9MS8tMS4gQmVjYXVz ZSB3aGVuIG51bWFfb2ZmID0gdHJ1ZSwgQUNQSSBzcmF0IHRhYmxlDQo+ID4gd2lsbCBub3QgYmUg cGFyc2VkOg0KPiANCj4gV2hpbGUgSSBhZ3JlZSB3aXRoIHRoaXMgZmFjdCwgdGhlIHByb2JsZW0g aXMgdGhhdCB0aGVyZSBhcmUgdHdvDQo+IGluZGVwZW5kZW50IGNvbW1hbmQgbGluZSBvcHRpb25z IGRyaXZpbmcgdGhlIHRoZW4gc2luZ2xlIHZhcmlhYmxlLg0KPiBJT1cgbnVtYV9vZmYgYW5kIGFj cGlfbnVtYSBib3RoIHR1cm5lZCBvbiBtYXkgc3RpbGwgbmVlZCBhDQo+IHJlcHJlc2VudGF0aW9u LiBJbiBmYWN0IEknbSBub3QgY29udmluY2VkIHdlIGNhbiBlbGltaW5hdGUgdGhlDQo+IG9yaWdp bmFsIHZhcmlhYmxlcy4gV2hhdCB3ZSBvdWdodCB0byBiZSBhYmxlIHRvIGRvIGlzIGNvbnNvbGlk YXRlDQo+IHRoZWlyIHZhbHVlcyBpbnRvIHRoZSBvbmUgc2luZ2xlIG5ldyB2YXJpYWJsZSB5b3Ug YWRkLCBiZWZvcmUNCj4gZXZlciBldmFsdWF0aW5nIGFueXRoaW5nLiBfVGhlbl8gSSB0aGluayBJ IGFncmVlIHdpdGggdGhlIHRhYmxlLg0KPiANCj4gSmFuDQo+IA0KPiA+ICstLS0tLS0tLS0tLSst LS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSstLS0tLS0t LQ0KPiAtLSsNCj4gPiB8IG9yaWdpbmFsICB8ICBjb2wxICAgfCAgY29sMiAgICAgICAgIHwgIGNv bDMgICAgIHwgIGNvbDQgICAgICB8ICBjb2w1DQo+IHwNCj4gPiArLS0tLS0tLS0tLS0rLS0tLS0t LS0tKy0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0NCj4g LS0rDQo+ID4gfG51bWFfb2ZmICAgfHRydWUgICAgIHxmYWxzZSAgICAgICAgICB8ZmFsc2UgICAg ICB8ZmFsc2UgICAgICAgfGZhbHNlDQo+IHwNCj4gPiB8YWNwaV9udW1hICB8MCAgICAgICAgfDAg ICAgICAgICAgICAgIHwxICAgICAgICAgIHwtMSAgICAgICAgICB8eA0KPiB8DQo+ID4gfG51bWFf ZmFrZSAgfHggICAgICAgIHx4ICAgICAgICAgICAgICB8eCAgICAgICAgICB8eA0KPiB8ZmFrZV9u b2Rlc3wNCj4gPiB8ZW51bSBzdGF0ZSB8bnVtYV9vZmYgfG51bWFfZndfbm9kYXRhIHxudW1hX2Z3 X29rIHxudW1hX2Z3X2JhZCB8bnVtYV9lbXUNCj4gfA0KPiA+ICstLS0tLS0tLS0tLSstLS0tLS0t LS0rLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSstLS0tLS0tLQ0KPiAt LSsNCj4gPg0KDQpIb3cgYWJvdXQgdXBkYXRlIHRoZSB0YWJsZSBsaWtlIHRoaXM6DQorLS0tLS0t LS0tLS0tKy0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0t LS0tLS0tLSsNCnwgIG9yaWdpbmFsICB8ICAgICAgICAgIHwgICAgICAgICAgICAgICAgfCAgICAg ICAgICAgICAgICB8ICAgICAgICAgICAgfA0KKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0tKy0tLS0t LS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rDQp8IG51bWFfb2ZmICAg fCB0cnVlICAgICB8IHRydWUgICAgICAgICAgIHwgdHJ1ZSAgICAgICAgICAgfCB0cnVlICAgICAg IHwNCnwgYWNwaV9udW1hICB8IDAgICAgICAgIHwgMSAgICAgICAgICAgICAgfCAtMSAgICAgICAg ICAgICB8IHggICAgICAgICAgfA0KfCBudW1hX2Zha2UgIHwgeCAgICAgICAgfCB4ICAgICAgICAg ICAgICB8IHggICAgICAgICAgICAgIHwgZmFrZV9ub2RlcyB8DQp8IGVudW0gc3RhdGUgfCBudW1h X29mZiB8IG51bWFfb2ZmICAgICAgIHwgbnVtYV9vZmYgICAgICAgfCBudW1hX29mZiAgIHwNCist LS0tLS0tLS0tLS0rLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0r LS0tLS0tLS0tLS0tKw0KDQorLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0t LS0tKy0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKw0KfCAgb3JpZ2luYWwgIHwgICAgICAgICAg ICAgICAgfCAgICAgICAgICAgIHwgICAgICAgICAgICAgfCAgICAgICAgICAgIHwNCistLS0tLS0t LS0tLS0rLS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLSstLS0tLS0t LS0tLS0rDQp8IG51bWFfb2ZmICAgfCBmYWxzZSAgICAgICAgICB8IGZhbHNlICAgICAgfCBmYWxz ZSAgICAgICB8IGZhbHNlICAgICAgfA0KfCBhY3BpX251bWEgIHwgMCAgICAgICAgICAgICAgfCAx ICAgICAgICAgIHwgLTEgICAgICAgICAgfCB4ICAgICAgICAgIHwNCnwgbnVtYV9mYWtlICB8IHgg ICAgICAgICAgICAgIHwgeCAgICAgICAgICB8IHggICAgICAgICAgIHwgZmFrZV9ub2RlcyB8DQp8 IGVudW0gc3RhdGUgfCBudW1hX2Z3X25vZGF0YSB8IG51bWFfZndfb2sgfCBudW1hX2Z3X2JhZCB8 IG51bWFfZW11ICAgfA0KKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0t LSstLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSsNCg0KQ2hlZXJzLA0KV2VpIENoZW4NCg0KPiA+ IE5vdGVzOg0KPiA+IFRoZSBmb2xsb3dpbmcgc2NlbmFyaW9zIHdpbGwgbWFrZSBhY3BpX251bWE9 MDoNCnNhbml0eSBjaGVjayBvciBoYXNoIGNvbXB1dGluZyBpbiBhY3BpX3NjYW5fbm9kZXMNCj4g PiAgICBpcyBmYWlsZWQuDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 09:58:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 09:58:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367204.598268 (Exim 4.92) (envelope-from ) id 1oBvbb-0003Er-SL; Thu, 14 Jul 2022 09:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367204.598268; Thu, 14 Jul 2022 09:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvbb-0003Ek-OJ; Thu, 14 Jul 2022 09:57:59 +0000 Received: by outflank-mailman (input) for mailman id 367204; Thu, 14 Jul 2022 09:57:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvba-0003Ea-1X for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 09:57:58 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60055.outbound.protection.outlook.com [40.107.6.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6fb0dbee-035b-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 11:57:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM4PR0401MB2257.eurprd04.prod.outlook.com (2603:10a6:200:51::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 09:57:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 09:57:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fb0dbee-035b-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H+/MJ/uri/zZnnvASeWLcdbiSfRzcpOSNVlJAMlnoyvYUB0/Wq/egAmA4GM16pXqtwQo/4bdor8y1mrXdO9w58xPMSxp28b0dcNg9+X9FMDKSZKTJxfhoQLka8WqlLCOBQcTfVVPP/ng8E1UDMgcNaVV+gwErJBn0W1FukEE5qPZuVI1MERW9i1kjoRZvFqdt4LN9jbzl/chQOAlurUS8pKWLrGTiSPb4ScsQ/xgOWlAo19iy6sJsA2mjEkYNMtWl1Kw2Y0CVY6hcHX7NataTzeVxeGsQDBaHboe+pUY3IA2mvYH1Q0KucDFhYMhl5DmmdAsFMC5OUWF7XAyLEHP9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lLzcafsrwjrqsew2vwdKnFBz6cWZ1azva8NG24mJ74E=; b=Qvi5f2YY7qwB0Yaa0YShCee3BcZ/ivpvq3RRpLRlIhTn6JaDpWddd28Z3/Vkyt32DRw8uo/qZ3q1iwlqbogkJQhBcMBpNCZhh1MQ4YKAJFqu+eNuzOPwNq8oonvFrFTg3jwc+pwNcoB0hQY8yRuhvXE9ZYRb5PItOjgE3JtK0UQR/oxR8l/9OXefYM6oaegc6z0EvpN1obIXlcNGLo24zRuj5lW9Vq6Ww1qxDTGiQZEEO+EujW02i9cn3+6kVu8uaIaYeKzekcKV7YBs/Dbfae1KRbvB26VIrOOdjEz9szOT0VXOdluRl0kFTawlRhFfRa6voCqF4/TvNBjTDzJrPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lLzcafsrwjrqsew2vwdKnFBz6cWZ1azva8NG24mJ74E=; b=RGIxBAW5FmC/xvUDOvMGd6ee1Tag/UfYEyeQ6lZ7dfBdrT9AHtJ+iudAxUVChEaOcmVGtsUXGMdfyoqQwioonOHxhvMTSxWb9s4G9hLY5e3qw1V1LC4wUtSa6FBruoMl0MTiIyTb8jsLtXUk9MRp6UG6RyLGjFztLWWB5JcZ4KBlarWlGgJrHh1fbkyerfuTVFmFVwSat5/2mq9hf/dwG8nrswMy8FDret/bVNv+vVBhmdzJXcu1WPrEcbltymPGLhAIqP/MuNm93fueVlVfmy1Yz9syuEQ2qLPciCi5ztLlhbKuRkLQfi2RUffEi0Iat4gWEKNhX6aeeP9lnaq12Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 11:57:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0073.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dd184eb9-56f6-4aa3-5b60-08da657f52e1 X-MS-TrafficTypeDiagnostic: AM4PR0401MB2257:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4MHHLWOzgvmOUrjyb6zYwPoNJLoFxjkIB2ZpqvEMu5Ea9fiD1bcTCLeeM5e4d6yeefK8AzdTl1vBR67uEevPVmggMBb8Lb7a8PU33dmzmQ9VrY1qird3ZF0RCKc1IOdsESle+yf4JkJ9vj6u23zYPjacfdb3vP4l2TrTqerZ+iLs/71smz+du4XBqwcA9yaPIgdvlNT4Z8SWs2guUZ9OhEZLpmI470n6hHaOzv/U2dM+9gEK4yLQmWIJqEuL1hWEkMe9Ffgv9fmPNb8dfShYMLQK5JQxlqCD4y1uHkZ41v6qMZAuXQLHpWEybxW12V02xN+puP5qtHbS94jsO3EKO6COqrIq+2BdQ0Y6YD7DTLzElkd9RiUC2kGzrUrQCoTXzNEJuwkuyPLrd7D1DZXL3NMxL1hb3cPhfMNwooqiegy6pmAYIIKc/zofnQIFe3hPDWpnsBWMjazCJn7vndOXyUjjDpFbysIF9gHwF3iwEDahpuD7eVo9qCpuKq9YVHhGiksiOSoAGnCwNTtl1/6yMmfJOovZmvMIQLXgctdZnH0pKR8f3gdcoD3Qqqqm8hPBP85BfyB5ZLohsTHtm2j0w087KreQcOyEQigGvGyv4SFZWUbU8/an/PlM7OVoIs0GJjouqdrt/HFOXhieNd9yZBgVKOiDZBVF01geZyW7h6Di3S6yXKnledZtrISawu1EAkXyy4sq++3zcWkiUbiEutFJcoy403vXDyLc3vH7La59WToePLvhIk6RkADMQ+0EMQvEGS0TlWzjRJOyta2b7dPDMpwHfuhvGZNUeSG5SuAYZ39aaoDiXdJyaejOMRNH+J3qjlCsS63H0TvGyaouHYKb9hOe6Ce2ZIPp3/t3i48= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(136003)(376002)(346002)(66946007)(53546011)(86362001)(6862004)(66556008)(8676002)(4326008)(5660300002)(66476007)(31696002)(6506007)(41300700001)(478600001)(6486002)(8936002)(83380400001)(2906002)(186003)(38100700002)(36756003)(316002)(54906003)(2616005)(6512007)(31686004)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TWwrTTJEWklyenppT1lvN1pkR2k5WFpzL2YvaWg4dWU3bXdvMFRQeWg0WklJ?= =?utf-8?B?SkNUQ2dRK0xXQTQrc21WNGJ1YlQ3R2xIekZRMDJsM2hJRTcrTTM2NmhHTFR3?= =?utf-8?B?RnI4cFJuMjZIUGhtVHpRRWJWRzhPaC9OZjdzRHF1eHhqdTkzeks4dlhyeXps?= =?utf-8?B?Ulo0eklpSWM4b2VoV1FvUTdURldEWXd6TUVYeFRyUlFvcGQyMWc0aVdVOGJG?= =?utf-8?B?UDJCZXdTeG5pNWp1S0J5SG0vVFR2MndXdVpHQWFQNDZHN2JIRTl4SWpPT1Bj?= =?utf-8?B?K2hKdzNoVUZDZDExNm9LVmZSUkxTeGM3SFF2c09TSDYyQXlSYXUzTXVZU0J6?= =?utf-8?B?am5PZ1FIeFpDRUo1R1d0Nk1mRVpScHdlVHlzSHc1b2xMc09PREU0dGIzQ3dv?= =?utf-8?B?eDhhUENURjJjZWY5a2Y0UXJyRldoUGFRWkdJVFB1ek9VWFUxZkhCSDI3Q29Y?= =?utf-8?B?OVFNcDlXVFd2eUpqaU1vM1lXMTV3aWZUb2ZMZHFiQ3RZS1NlbXFqcDR0WE53?= =?utf-8?B?Z3AzQnVVOHQ1clNIc21NeTA4MlVjQndTQ1dNVGtMckVGRUkyUzFhUW04UFA3?= =?utf-8?B?Sk9hRU5qY2xta09WSnhmL05hRnpZbm90dVJRUjJOU1dGcElSb0xFQU9HRXhQ?= =?utf-8?B?MC9PNVg5UlZBK0tPWnZncXJCT291V29vWnBnSHVCUU1kcmlWdlZCY0xCcndu?= =?utf-8?B?ZmZtd1AwZ21XY1IrQTBFVFRORE5RVStLem44VytiOCtrQ3g0Vld4cm9ScEFx?= =?utf-8?B?STUyRXNvaTg0cklTeEtFSTN1Mi84VHhWK0lCeVJFcHQ1S1VyV3FYVHRSb3Ax?= =?utf-8?B?V0g1WUVCeGQ5WFVVSXJCU0poWEZCdzR3MzhqbWFWcnV6cjBTL2RaN01Ka1lE?= =?utf-8?B?eE9uQWJZaUM0Z2FNb2pRNHhZOFRPSVFTb3dTS2d2QTVvaGlXNWdLSXJ3SW9z?= =?utf-8?B?VXVOcEZxZEJGZktpbTFheXZ2aFdpdHo0L1R3OVZTcHZTOVJtdVREUGRNaVhC?= =?utf-8?B?WmlJOEliek1saE1xdUQ0ajdoR0orUDBJaWpqUXZWWlFLYytmMmxVWm1EQ2g2?= =?utf-8?B?WGdqbm1pL01qR2FSUDhWbHNzYVJVNnRzV1dXYTVVcW5rdkU5WTlYL1AwR2Rz?= =?utf-8?B?NVBSSE55NEk1SUVsUFJTK25kemNwa2FFZlZuaEZxUUs3Q0dicTY3U0U5WmNN?= =?utf-8?B?MkJwS1pWaTdPLzNmZkRkNFgzNStEUjh3UWVuM3NPbmVtL1BZVVp1Tmt3R0Zp?= =?utf-8?B?MDNSYTFjbHVuSWpmRFNtYlFmT2FMeVN6U0g3cHk2QlJyR0o3RUhuUDNjNUFZ?= =?utf-8?B?SWJYTytnYldpZGRTZXBRWXdZK2svN0p3d01jK2hyUVJFVDNYTzdLc0loem94?= =?utf-8?B?UEE3azBPVWRoYkhIbHB3YmZ5bEg1SjhXdDJzc0psT2hVMnVnUXMyM2V4QmxN?= =?utf-8?B?NGQ0Y3RBYlQyWUxvSlhNYkpuN1Z3V2F4WFROOW5Pb3NmWnQ1VisxQXo4d0J1?= =?utf-8?B?RmUvbURZNlQyU1dSK1NjOU13eGhjZmoxUGxjN3Z0ZVlaVkpLVHMzNjI2ZGg2?= =?utf-8?B?RWZLMW0rcklhZFk4andGR293Q3U5M29CQ21la09jamUxUWtvcEcyMyttS0tv?= =?utf-8?B?UE9nNjhGTjhQMTRmeFplWURRRG56c2ZyREJRdkd3bVJFTkZjaUEycVlXNFlE?= =?utf-8?B?Ynd0OGdsOE9tcGZtbndoKzZCMi81Zm1KN1R1REo4RnZOYmRVUHpRZTN1MDZn?= =?utf-8?B?STlnWWtYTk9oalJJVURXY2VaWkNJZGlHdHpkb0QwbTNhRjRKK1R5bC9aMkpz?= =?utf-8?B?RzBNR0ZwRURmNGRsTGc3TUlYcUFIK2oyeW82WldMemo0NmNXd0JzUjV2eUgz?= =?utf-8?B?ZEdmZXNTcit3ek54cml1MWlXK25PTEROVXR3SDhEYzcxNW03cERUWVQwSytr?= =?utf-8?B?UHp6OWptWnVyNEE2RnBSR3pnbXRPb2daK1lEVjFFOUtqQ0JCL2ZRaGZ5Y3px?= =?utf-8?B?UzhCTVhodlpYNlVJYmU4ckExSGRrTExvdkNidGFTWTlTWE1BUUtJSjJQbWs0?= =?utf-8?B?K2VCbmtzVlpkRTNrQ0p6Ui9qamoxTzFEa3IvRGVFUW9PWEtKOXdpZWlPSVAv?= =?utf-8?Q?zCYdzRWWC4vRXWjnQwCUEcg3C?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dd184eb9-56f6-4aa3-5b60-08da657f52e1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 09:57:55.3192 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qElgW9t80JFSCizqwTJFjEfheR0rY1lEx4ZgLIHqa/HXzKRGBToMeLOC4Lk4Za0NSCzfPiLta9O4G8U5RXCxdw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR0401MB2257 On 14.07.2022 11:55, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >>>> >>> >>> Sorry for replying later, I paid sometime to check the code again, >>> and drew a table like below, I ignore two columns when numa_off=true >>> and acpi_numa=1/-1. Because when numa_off = true, ACPI srat table >>> will not be parsed: >> >> While I agree with this fact, the problem is that there are two >> independent command line options driving the then single variable. >> IOW numa_off and acpi_numa both turned on may still need a >> representation. In fact I'm not convinced we can eliminate the >> original variables. What we ought to be able to do is consolidate >> their values into the one single new variable you add, before >> ever evaluating anything. _Then_ I think I agree with the table. >> >> Jan >> >>> +-----------+---------+---------------+-----------+------------+-------- >> --+ >>> | original | col1 | col2 | col3 | col4 | col5 >> | >>> +-----------+---------+---------------+-----------+------------+-------- >> --+ >>> |numa_off |true |false |false |false |false >> | >>> |acpi_numa |0 |0 |1 |-1 |x >> | >>> |numa_fake |x |x |x |x >> |fake_nodes| >>> |enum state |numa_off |numa_fw_nodata |numa_fw_ok |numa_fw_bad |numa_emu >> | >>> +-----------+---------+---------------+-----------+------------+-------- >> --+ >>> > > How about update the table like this: > +------------+----------+----------------+----------------+------------+ > | original | | | | | > +------------+----------+----------------+----------------+------------+ > | numa_off | true | true | true | true | > | acpi_numa | 0 | 1 | -1 | x | > | numa_fake | x | x | x | fake_nodes | > | enum state | numa_off | numa_off | numa_off | numa_off | > +------------+----------+----------------+----------------+------------+ > > +------------+----------------+------------+-------------+------------+ > | original | | | | | > +------------+----------------+------------+-------------+------------+ > | numa_off | false | false | false | false | > | acpi_numa | 0 | 1 | -1 | x | > | numa_fake | x | x | x | fake_nodes | > | enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu | > +------------+----------------+------------+-------------+------------+ Well, this makes the table complete, but it doesn't explain how you mean to fold the settings of the two command line options into one variable. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:10:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367213.598296 (Exim 4.92) (envelope-from ) id 1oBvnG-0005LZ-NF; Thu, 14 Jul 2022 10:10:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367213.598296; Thu, 14 Jul 2022 10:10:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnG-0005Ks-GO; Thu, 14 Jul 2022 10:10:02 +0000 Received: by outflank-mailman (input) for mailman id 367213; Thu, 14 Jul 2022 10:10:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnF-0004wq-3z for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:10:01 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1def74b3-035d-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:09:59 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C74AD15A1; Thu, 14 Jul 2022 03:09:58 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C71D23F70D; Thu, 14 Jul 2022 03:09:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1def74b3-035d-11ed-bd2d-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [RFC PATCH 2/2] automation: Add yocto containers with cache Date: Thu, 14 Jul 2022 11:09:45 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Create yocto containers for kirkstone with a builder step to fill the yocto cache by running the build script once. Those containers depend on the kirkstone.dockerfile container to be created and use it as base image. To run a build test on one image the following command must be called inside the container: build-yocto.sh --xen-dir=XENSRC TARGET where - XENSRC is the directory where xen sources are available in the container - TARGET is the build target (qemuarm64, qemuarm or qemux86_64) In case of error, the script will return an error code and the logs will be in /home/docker-build/logs. !!! The build of each container can take several hours depending on the network bandwith (for downloading all sources) and the amount of computing power on the machine where the docker images are created. !!! Signed-off-by: Bertrand Marquis --- automation/build/Makefile | 2 ++ .../build/yocto/kirkstone-qemuarm.dockerfile | 28 +++++++++++++++++++ .../yocto/kirkstone-qemuarm64.dockerfile | 28 +++++++++++++++++++ .../yocto/kirkstone-qemux86-64.dockerfile | 28 +++++++++++++++++++ 4 files changed, 86 insertions(+) create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile diff --git a/automation/build/Makefile b/automation/build/Makefile index a4b2b85178..00e6f46090 100644 --- a/automation/build/Makefile +++ b/automation/build/Makefile @@ -16,5 +16,7 @@ help: $(DOCKER_CMD) push $(REGISTRY)/$(@D):$(@F); \ fi +yocto/kirkstone-%: yocto/kirkstone + .PHONY: all all: $(CONTAINERS) diff --git a/automation/build/yocto/kirkstone-qemuarm.dockerfile b/automation/build/yocto/kirkstone-qemuarm.dockerfile new file mode 100644 index 0000000000..e3cdc4dcf3 --- /dev/null +++ b/automation/build/yocto/kirkstone-qemuarm.dockerfile @@ -0,0 +1,28 @@ +# Docker file to populate the initial sstate and download cache for yocto +# for a specific target +# +# This requires the build-yocto.sh script to be in the same directory as this +# dockerfile during the image creation +# +# Arguments that can be passed during image creation using --build-arg: +# "from_image=img" to select the docker image and tag to start from +# "target=qemuxxx": to select which target to build in this image + +ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone + +FROM $from_image AS builder + +ARG target=qemuarm + +# This step can take one to several hours depending on your download bandwith +# and the speed of your computer +RUN /home/$USER_NAME/bin/build-yocto.sh $target + +FROM $from_image + +# Only copy the cache status +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. + +LABEL maintainer.name="The Xen Project " \ + maintainer.email="xen-devel@lists.xenproject.org" + diff --git a/automation/build/yocto/kirkstone-qemuarm64.dockerfile b/automation/build/yocto/kirkstone-qemuarm64.dockerfile new file mode 100644 index 0000000000..6045b6ac24 --- /dev/null +++ b/automation/build/yocto/kirkstone-qemuarm64.dockerfile @@ -0,0 +1,28 @@ +# Docker file to populate the initial sstate and download cache for yocto +# for a specific target +# +# This requires the build-yocto.sh script to be in the same directory as this +# dockerfile during the image creation +# +# Arguments that can be passed during image creation using --build-arg: +# "from_image=img" to select the docker image and tag to start from +# "target=qemuxxx": to select which target to build in this image + +ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone + +FROM $from_image AS builder + +ARG target=qemuarm64 + +# This step can take one to several hours depending on your download bandwith +# and the speed of your computer +RUN /home/$USER_NAME/bin/build-yocto.sh $target + +FROM $from_image + +# Only copy the cache status +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. + +LABEL maintainer.name="The Xen Project " \ + maintainer.email="xen-devel@lists.xenproject.org" + diff --git a/automation/build/yocto/kirkstone-qemux86-64.dockerfile b/automation/build/yocto/kirkstone-qemux86-64.dockerfile new file mode 100644 index 0000000000..35e2fdeb1e --- /dev/null +++ b/automation/build/yocto/kirkstone-qemux86-64.dockerfile @@ -0,0 +1,28 @@ +# Docker file to populate the initial sstate and download cache for yocto +# for a specific target +# +# This requires the build-yocto.sh script to be in the same directory as this +# dockerfile during the image creation +# +# Arguments that can be passed during image creation using --build-arg: +# "from_image=img" to select the docker image and tag to start from +# "target=qemuxxx": to select which target to build in this image + +ARG from_image=registry.gitlab.com/xen-project/xen/yocto:kirkstone + +FROM $from_image AS builder + +ARG target=qemux86-64 + +# This step can take one to several hours depending on your download bandwith +# and the speed of your computer +RUN /home/$USER_NAME/bin/build-yocto.sh $target + +FROM $from_image + +# Only copy the cache status +COPY --from=builder /home/$USER_NAME/yocto-cache /home/$USER_NAME/yocto-cache/. + +LABEL maintainer.name="The Xen Project " \ + maintainer.email="xen-devel@lists.xenproject.org" + -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:10:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367212.598290 (Exim 4.92) (envelope-from ) id 1oBvnG-0005GU-A0; Thu, 14 Jul 2022 10:10:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367212.598290; Thu, 14 Jul 2022 10:10:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnG-0005Fm-6V; Thu, 14 Jul 2022 10:10:02 +0000 Received: by outflank-mailman (input) for mailman id 367212; Thu, 14 Jul 2022 10:10:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnE-0004wq-Es for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:10:00 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1d837cfa-035d-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:09:58 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0930F13D5; Thu, 14 Jul 2022 03:09:58 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E23513F70D; Thu, 14 Jul 2022 03:09:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d837cfa-035d-11ed-bd2d-47488cf2e6aa From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [RFC PATCH 1/2] automation: Add elements for Yocto test and run Date: Thu, 14 Jul 2022 11:09:44 +0100 Message-Id: <21d016bf1a6e1823e8d716ad087d82b91509170e.1657792818.git.bertrand.marquis@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add a container suitable to run yocto kirkstone build based on ubuntu 22.04. It contains all packages required by Yocto and a checkout of the layers required to build Xen with Yocto. Add a build script to build and run xen on qemu using Yocto. The script supports arm32, arm64 and x86_64 and checks that dom0 is properly booting. The build script is currently in the same directory than the docker files so that it can be included directly in the image. This is required for the next step which creates images with an initial cache content to speed up testing. Signed-off-by: Bertrand Marquis --- automation/build/yocto/build-yocto.sh | 322 ++++++++++++++++++++ automation/build/yocto/kirkstone.dockerfile | 98 ++++++ 2 files changed, 420 insertions(+) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/kirkstone.dockerfile diff --git a/automation/build/yocto/build-yocto.sh b/automation/build/yocto/build-yocto.sh new file mode 100755 index 0000000000..f4b809d974 --- /dev/null +++ b/automation/build/yocto/build-yocto.sh @@ -0,0 +1,322 @@ +#!/bin/bash +# +# Yocto meta virtualization build and run script +# +# This script is building Yocto xen-image-minimal for qemu targets and run +# them using runqemu inside yocto to check that dom0 is booting properly +# The build is using a local xen source tree so that specific patches can be +# tested. +# In order to optimize the build time, a build cache is used so that only xen +# packages and its dependencies are rebuilt (qemu and final image mainly). +# + +# Directories +YOCTODIR="$HOME/yocto-layers" +CACHEDIR="$HOME/yocto-cache" +LOGDIR="$HOME/logs" +XENDIR="$HOME/xen" +BUILDDIR="$HOME/build" + +# what yocto bsp we support +TARGET_SUPPORTED="qemuarm qemuarm64 qemux86-64" +VERBOSE="n" +TARGETLIST="" + +# actions to do +do_clean="n" +do_build="y" +do_run="y" +do_localsrc="n" +build_result=0 + +# layers to include in the project +build_layerlist="poky/meta poky/meta-poky poky/meta-yocto-bsp \ + meta-openembedded/meta-oe meta-openembedded/meta-python \ + meta-openembedded/meta-filesystems \ + meta-openembedded/meta-networking meta-virtualization" + +# yocto image to build +build_image="xen-image-minimal" + +function print_progress() { + echo -n "$(date +%T) $*" +} + +function run_task() { + local task_name="$1" + local task_target="$2" + + task_log="${task_name//project_}-${task_target}" + + mkdir -p "${LOGDIR}" + print_progress + echo -n "${task_name//project_} ${task_target}: " + if [ "${VERBOSE}" = "n" ]; then + $@ > "${LOGDIR}/${task_log}.log" 2>&1 + else + $@ 2>&1 | tee "${LOGDIR}/${task_log}.log" + fi + + if [ ${?} -ne 0 ]; then + echo "Error" + build_result=$((build_result+1)) + return 1 + else + echo "OK" + return 0 + fi +} + +function project_create() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + # init yocto project + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" + + # add needed layers + for layer in ${build_layerlist}; do + bitbake-layers add-layer ${YOCTODIR}/${layer} || exit 1 + done + ) || return 1 + + # customize project configuration + cat <> "${destdir}/conf/local.conf" +# Yocto BSP +MACHINE = "${target}" + +# Use local cache to reuse previous builds results +SSTATE_DIR = "${CACHEDIR}/sstate-cache" +DL_DIR = "${CACHEDIR}/downloads" + +# Enable xen and virtualization +DISTRO_FEATURES = " virtualization xen ipv4" + +# Speed up run by not generating ssh host keys +IMAGE_INSTALL:append:pn-xen-image-minimal = " ssh-pregen-hostkeys" + +# Save some disk space +INHERIT += "rm_work" + +EOF + + if [ "${do_localsrc}" = "y" ]; then + XENVERS=$(grep -e "^XEN_REL" \ + "${YOCTODIR}"/meta-virtualization/recipes-extended/xen/xen_*.bb \ + 2> /dev/null | tr -d ' ' | tr -d '?' | tr -d '"' \ + | sed -e "s/.*=//" | sort -V | tail -n 1) + + XENBASE=$(dirname "$(realpath -m "${XENDIR}")") + XENSUB=$(basename "$(realpath -m "${XENDIR}")") + + cat <> "${destdir}/conf/local.conf" +# Use local sources for xen and xen-tools +FILESEXTRAPATHS:prepend:pn-xen := "${XENBASE}:" +FILESEXTRAPATHS:prepend:pn-xen-tools := "${XENBASE}:" + +SRC_URI:pn-xen = "file://${XENSUB}/;subdir=local-xen/" +SRC_URI:pn-xen-tools = "file://${XENSUB}/;subdir=local-xen/" + +PREFERRED_VERSION:pn-xen = "${XENVERS}%" +PREFERRED_VERSION:pn-xen-tools = "${XENVERS}%" + +S:pn-xen = "\${WORKDIR}/local-xen/${XENSUB}" +S:pn-xen-tools = "\${WORKDIR}/local-xen/${XENSUB}" + +SRCREV:pn-xen = "\${AUTOREV}" +SRCREV:pn-xen-tools = "\${AUTOREV}" + +SRCPV:pn-xen = "1" +SRCPV:pn-xen-tools = "1" + +# Disable all QA errors as the recipe is not up to date with changes in Xen +# when we use local sources +ERROR_QA:pn-xen = "arch" +ERROR_QA:pn-xen-tools = "arch" + +EOF + fi +} + +function project_build() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + ( + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" + + bitbake "${build_image}" || exit 1 + ) || return 1 +} + +function project_clean() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + + rm -rf "${destdir}" +} + +function project_run() { + target="${1:?}" + destdir="${BUILDDIR}/${target}" + ( + source ${YOCTODIR}/poky/oe-init-build-env "${destdir}" > /dev/null 2>&1 + + /usr/bin/expect < Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:10:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367211.598279 (Exim 4.92) (envelope-from ) id 1oBvnE-0004x8-Tj; Thu, 14 Jul 2022 10:10:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367211.598279; Thu, 14 Jul 2022 10:10:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnE-0004x0-Qw; Thu, 14 Jul 2022 10:10:00 +0000 Received: by outflank-mailman (input) for mailman id 367211; Thu, 14 Jul 2022 10:09:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvnD-0004wp-R7 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:09:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 1cf12de5-035d-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:09:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2679F139F; Thu, 14 Jul 2022 03:09:57 -0700 (PDT) Received: from e109506.cambridge.arm.com (e109506.cambridge.arm.com [10.1.199.62]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 251F73F70D; Thu, 14 Jul 2022 03:09:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1cf12de5-035d-11ed-924f-1f966e50362f From: Bertrand Marquis To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [RFC PATCH 0/2] Yocto Gitlab CI support Date: Thu, 14 Jul 2022 11:09:43 +0100 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series is a first attempt to check if we could use Yocto in gitlab ci to build and run xen on qemu for arm, arm64 and x86. The first patch is creating a container with all elements required to build Yocto, a checkout of the yocto layers required and an helper script to build and run xen on qemu with yocto. The second patch is creating containers with a first build of yocto done so that susbsequent build with those containers would only rebuild what was changed and take the rest from the cache. This is is mainly for discussion and sharing as there are still some issues/problem to solve: - building the qemu* containers can take several hours depending on the network bandwith and computing power of the machine where those are created - produced containers containing the cache have a size between 8 and 12GB depending on the architecture. We might need to store the build cache somewhere else to reduce the size. If we choose to have one single image, the needed size is around 20GB and we need up to 40GB during the build, which is why I splitted them. - during the build and run, we use a bit more then 20GB of disk which is over the allowed size in gitlab Once all problems passed, this can be used to build and run dom0 on qemu with a modified Xen on the 3 archs in less than 10 minutes. Bertrand Marquis (2): automation: Add elements for Yocto test and run automation: Add yocto containers with cache automation/build/Makefile | 2 + automation/build/yocto/build-yocto.sh | 322 ++++++++++++++++++ .../build/yocto/kirkstone-qemuarm.dockerfile | 28 ++ .../yocto/kirkstone-qemuarm64.dockerfile | 28 ++ .../yocto/kirkstone-qemux86-64.dockerfile | 28 ++ automation/build/yocto/kirkstone.dockerfile | 98 ++++++ 6 files changed, 506 insertions(+) create mode 100755 automation/build/yocto/build-yocto.sh create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile create mode 100644 automation/build/yocto/kirkstone.dockerfile -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:14:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:14:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367234.598312 (Exim 4.92) (envelope-from ) id 1oBvrL-0007cB-3V; Thu, 14 Jul 2022 10:14:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367234.598312; Thu, 14 Jul 2022 10:14:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvrL-0007c4-0f; Thu, 14 Jul 2022 10:14:15 +0000 Received: by outflank-mailman (input) for mailman id 367234; Thu, 14 Jul 2022 10:14:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvrK-0007by-2P for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:14:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4b243f4-035d-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:14:12 +0200 (CEST) Received: from DB6PR0402CA0020.eurprd04.prod.outlook.com (2603:10a6:4:91::30) by AM0PR08MB3875.eurprd08.prod.outlook.com (2603:10a6:208:104::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 10:14:10 +0000 Received: from DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:91:cafe::1b) by DB6PR0402CA0020.outlook.office365.com (2603:10a6:4:91::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Thu, 14 Jul 2022 10:14:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT010.mail.protection.outlook.com (100.127.142.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 10:14:09 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Thu, 14 Jul 2022 10:14:09 +0000 Received: from 16e2de483e8b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 88CCA65A-B6BC-46BC-8B95-20F1FA76F769.1; Thu, 14 Jul 2022 10:14:04 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 16e2de483e8b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 10:14:04 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB7077.eurprd08.prod.outlook.com (2603:10a6:20b:34b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.17; Thu, 14 Jul 2022 10:14:03 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:14:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4b243f4-035d-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=YWQphDKYG7AhVVMYL+Lc2lgcO+bBRvFDLKdfv6+y8DZWB2iZi57GUHzCyboD3PqVqtSSA4MbUIwNfn0tVv60JNGtC6AqO3GK+oSXAHW2n8/y4eP13R7B6xDDHCN7yBgvIWyK8U0AoAZ3RPKpbtug16ktVZID2Z8cAicIS69GaNPG6172QSX23DkZnrssJgMexHaYnOqNNKn7lT5VJlQgStKJal/Cg6w6o7OqEa5ZH+/aMZ1c9UW8lakU4iEZqhDirKTi0mY0abHqHUEzfEBmjuEQ541+SYxZ+Ucw8zEEhYqCRNnBz/g/5WZaexFxDkL0DaIqJ9eYJZ9jqFBjMMu55Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ts86O84BYfVQcArgHkycbUW2jS5wZqD15tgO5hh3g3U=; b=l1mfZ0q7A9ZhWze/F3vs3xxJlCKaLNS2URMigzJopeEqHkFMRfts8JK9FXvHALpp0kfGYD861SRjNrK6dc3bq6fhb+tAnEEE9kzTYPsFEt8+L80pltzGdB2QHvBgq1GEJW8eLqLECiaKwXQJ3uugz2txFF22sAnxe6yltGWpSFJKsG6EVelnGjhGyX3DHLNZAzyRSxo10TjihB8xUzpD3RW465YRPnalS3rghL7uzJxsdikPu44y4BCXbc3ZPOKa0vZkMQi13THYbO+ZmX6ktlUhibFPw3lCyPm4Q5vlRi6zp5m6CvfRwY332ID/UadRk+LisxAgO9ILyR5SiAT7ew== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ts86O84BYfVQcArgHkycbUW2jS5wZqD15tgO5hh3g3U=; b=PBSnrsEvr/If/CVXHcGF9L8QAYw+eaxW9uO/Avbml3YQDxZ8wWb47DR1cp+vENjruTvyo3CVqo+ri7eeu9UnybioTLox/0gr+5krIoCyzRFwx7F1zH4sdp2IEHLuvvcBQ7BFJMsYC9JbERPnuRgYg9Qa5loUKmUvcn6uWt9ECnI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZwIJONM5qEXx8o0geu9u1xjcAlG674TIGbBbwH/czgbYmBJ6OIDZyfGooRYwtnOsOZzDgGE3tKO/S9wpRf+3gJ3a7GKRotSrygxmR4f6sIy+VHLOsFvCZ5wEiVbyu3n9SoqymNetZCmqq0GCw2NYlYQQOX4E2nfO8NGTAZf00gl08E+gZMBg5JE9ZHZ1cELMOFRcXB0Yx/Q9JWQ3m3s1+8C3a995tbkpSe3Ukkku40Wf7ydA84ihFSXxzvAsZwCRjDfegLp+D+uf5ZBuMaSuSLISUnCt434W3iCEwz1Z3+YARUcxQAhd1LP1cJEHmvL+UpbSLRQxkBo9Unk9MCeV+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ts86O84BYfVQcArgHkycbUW2jS5wZqD15tgO5hh3g3U=; b=dSNtiCQTP44qxeIJstBsswW+F95CG8raRv9V5gmjnYE22lAB3Ubm/VkscZb9UlsvL2y8KwmekzsA3M9thr49G8erEs3rpt7ep4TRhy7sjJB7ukyBuTKbl0FkE7nifI7GAAuYNSU/sto8X/aAf1/ZAkwjKR67dpv8geQX/QVelkrKcwHhPm5/vD6rA/moklUVqorS03qNvBZJjdNaD3ZZsGyGoXuNX/2Q+eey+tW80jJvaOai6YDuczNsdepARqb186zuoePFB4YxNiVmTC1weBLdUQmbZZ1eDX5fNtTJWCpUtG1bwZ4r7j5FAT9zJagtprkP3ueLnCyKS2H3o40/NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ts86O84BYfVQcArgHkycbUW2jS5wZqD15tgO5hh3g3U=; b=PBSnrsEvr/If/CVXHcGF9L8QAYw+eaxW9uO/Avbml3YQDxZ8wWb47DR1cp+vENjruTvyo3CVqo+ri7eeu9UnybioTLox/0gr+5krIoCyzRFwx7F1zH4sdp2IEHLuvvcBQ7BFJMsYC9JbERPnuRgYg9Qa5loUKmUvcn6uWt9ECnI= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Topic: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Index: AQHYktrGRUcF8MDJDk6LN0+4egi+Ca160z2AgALXevA= Date: Thu, 14 Jul 2022 10:14:03 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F7EAD9C8B1304F418C36FA216A321D9B.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 3eb219e6-ad34-4e18-3eb0-08da658197cd x-ms-traffictypediagnostic: AS8PR08MB7077:EE_|DBAEUR03FT010:EE_|AM0PR08MB3875:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: oRSgw1GlKEDtavq55xntD4Ft7Zr32NXumxlc12cN/wjU/VvnIkYTqaGL2DpolCBJKJGVnQSL2LfkzMX4k7RVL6peGVy0uShtE2DxOKhaK1SBe5d1bHnmd6IEaIryeAUXy3ePgsQA6c6cJMxWTlczBGELwUp8h8ot+o3ba6/wkX2+dFvASkoW8/fQ8MVdlgDoW8oXt/4bkTfwj5h1KjtIA1E4zXv6L965hFazN+PY5TSrdHtcwcG2wjERLvcYf6pV5ABB8W0zS0Ypp0vxNa35l4gISVoz6EjoLe1uNJ/kM8WHfncyoqgWbNZuaTQ6EQxUv5dw3D++0pNsjYTXxP5vGkX3M1ILpUL8YJ2HL+YRBNlsVqHDM/OnuAuSC79Rhn0OjLv4M0q80ag6s3DwzM3kPllqGiI1TrwiFpIFoSqGZkzOrsttp2TVYbNytFEe1xiqiuI7hCiRZRAW9n62iZPRQu8NrORljtKfTCrY5QhG+hloch8U3FCjMO69kfMpK1zXIu3RtDbkWO3a2FQ79RePvGHjbHu6VOPPeJZAZZlgGt5kRJYVk71sa8LUR3Pxwwspxw2+lbYkxTihXvqhUzp6T7Q2M8TUFwXpTkOuxJL3TbZuMxPXWz1X9bzHgmDa/mAS+cqCZIGdqHJ1CHGV20QxH8ZDEKLMXho8nP0E76gqEmW2TPtrg2dNCKPGtmzJbDPKOsEYi5/41i2bC3lFd8gJyS3xpyanzr/aB7KKHbnIvUQs0zbotXacpYMIDboyCwV5es9712rDN79KBxwsvZtxNGad4JdmAjDmJAquxrZkvz+EY3SSiOHpXC+xUQpBkSYN X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(376002)(396003)(26005)(33656002)(86362001)(9686003)(83380400001)(38100700002)(122000001)(38070700005)(6506007)(66476007)(71200400001)(186003)(41300700001)(4326008)(7696005)(76116006)(478600001)(66946007)(8676002)(5660300002)(2906002)(66556008)(6916009)(8936002)(66446008)(64756008)(53546011)(55016003)(316002)(54906003)(52536014);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7077 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e61c7db7-4980-40ec-1724-08da658193d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jxzw9stHeXDmEsfa90pEfzw4pZKSC797Jj3OdXN9vB1mt0xqtyBIOmYC5dzRUK5PH8AeO6p58wmTx0GRk+cgaJzkeCSHnM6t/YGUnjPnmTAK/oQtpfj/bNeLRFm9wNxPkrYkVo8ObKLZLux/A2d6V9xFOgTxY26RZn/MV6yNap98F6kuev3fbgjH9rZN6q+cTOSbFRvBVFaFrZoSDt9A2r4/KRlR9kEoUAOsoFU0JeT8lvSJ3t/05iK5tW3IzyhN5V8fhbGxF5SIz0/vcQ3K30MbhriLPTILKHBojLNe3ow5sjXNZgCu/+dugUURwvS3x76uf0lQwR/urRCiYhtaobsNvLzeKJ2QMSac5lUt7jwAhQDiJ7uM+9AWoQqXqQZbGbwE+gevZoPEiqzdhXjSbzgEkFXA1HI/HG3LSwOq66l/wgkxhi5aUohjURYZU87+nXEVLRaLtLq9NxotKxQeC9tsUQ6Rn0Otu67vnLYMNRoGgzNSCwaihQlpiS66am9xdgWc+8vqAYKnQ9WutC2eJNYfKp+HbKFu7Wde4Jxdf6W3LbWbxaz54GZgujXuCORV11EyIsaafm3gGhCRqJAT4ftKXnAdSKT12q3vHvQ/PVs3d33NSN0z+MPT+JU/WQTGuPurp0bZmr4a6XSap+e1pZrW+8Gw1Mq1BYZbpvsx8g+FMZC4IYtH8i0Y+krDb/5U0MNIvP3dnLe/hNtJcT1VIi4YChjH/0QK94L+cM96BAZiBbMjhi0xZgc7owL+zZn57zqu9Y7g91fS+luTkKOlbyM6eJH6Jpkt/m1VbDvhC/3VrpC/Hnyx0RLgHAJOKDNA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(39860400002)(346002)(40470700004)(46966006)(36840700001)(33656002)(55016003)(6862004)(40460700003)(8936002)(2906002)(40480700001)(86362001)(5660300002)(70206006)(82310400005)(316002)(8676002)(70586007)(54906003)(52536014)(356005)(41300700001)(36860700001)(336012)(186003)(26005)(478600001)(4326008)(9686003)(6506007)(81166007)(82740400003)(53546011)(7696005)(83380400001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:14:09.8343 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3eb219e6-ad34-4e18-3eb0-08da658197cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3875 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxMuaXpSAyMjozNA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UNCj4gRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPjsgU3RlZmFubw0KPiBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgV2Vp IExpdSA8d2xAeGVuLm9yZz47IFJvZ2VyIFBhdSBNb25uw6kNCj4gPHJvZ2VyLnBhdUBjaXRyaXgu Y29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFU Q0ggdjIgOS85XSB4ZW46IGludHJvZHVjZSBhIEtjb25maWcgb3B0aW9uIHRvIGNvbmZpZ3VyZQ0K PiBOVU1BIG5vZGVzIG51bWJlcg0KPiANCj4gT24gMDguMDcuMjAyMiAxNjo1NCwgV2VpIENoZW4g d3JvdGU6DQo+ID4gLS0tIGEveGVuL2FyY2gvS2NvbmZpZw0KPiA+ICsrKyBiL3hlbi9hcmNoL0tj b25maWcNCj4gPiBAQCAtMTcsMyArMTcsMTQgQEAgY29uZmlnIE5SX0NQVVMNCj4gPiAgCSAgRm9y IENQVSBjb3JlcyB3aGljaCBzdXBwb3J0IFNpbXVsdGFuZW91cyBNdWx0aS1UaHJlYWRpbmcgb3IN Cj4gc2ltaWxhcg0KPiA+ICAJICB0ZWNobm9sb2dpZXMsIHRoaXMgdGhlIG51bWJlciBvZiBsb2dp Y2FsIHRocmVhZHMgd2hpY2ggWGVuIHdpbGwNCj4gPiAgCSAgc3VwcG9ydC4NCj4gPiArDQo+ID4g K2NvbmZpZyBOUl9OVU1BX05PREVTDQo+ID4gKwlpbnQgIk1heGltdW0gbnVtYmVyIG9mIE5VTUEg bm9kZXMgc3VwcG9ydGVkIg0KPiA+ICsJcmFuZ2UgMSAyNTUNCj4gPiArCWRlZmF1bHQgIjY0Ig0K PiA+ICsJZGVwZW5kcyBvbiBOVU1BDQo+IA0KPiBEb2VzIDEgbWFrZSBzZW5zZT8gVGhhdCdzIG5v dCBnb2luZyB0byBiZSBOVU1BIHRoZW4sIEkgd291bGQgc2F5Lg0KPiANCg0KT2ssIHdlIG5lZWQg YXQgbGVhc3QgMiBub2RlcyB0byBiZSBhIHJlYWwgTlVNQS4NCg0KPiBEb2VzIHRoZSB2YWx1ZSBi ZWluZyAocGVyaGFwcyBmYXIpIGxhcmdlciB0aGFuIE5SX0NQVVMgbWFrZSBzZW5zZT8NCj4gDQoN CkFybSBoYXMgMTI4IGRlZmF1bHQgTlJfQ1BVUyAoZXhjZXB0IHNvbWUgcGxhdGZvcm1zKSBhbmQg eDg2IGhhcyAyNTYuDQpTbyBJIGFtIG5vdCB2ZXJ5IGNsZWFyIGFib3V0IHlvdXIgY29tbWVudHMg YWJvdXQgZmFyIGxhcmdlcj8gQXMgbXkNClVuZGVyc3RhbmRpbmcsIG9uZSBub2RlIGhhcyAyIG9y IDQgY29yZXMgYXJlIHZlcnkgY29tbW9uIGluIGEgTlVNQQ0KU3lzdGVtLg0KDQo+IFdoeSBkb2Vz IHRoZSByYW5nZSBlbmQgYXQgYSBub3QtcG93ZXItb2YtMiB2YWx1ZT8gKEkgd2FzIGFjdHVhbGx5 DQo+IGdvaW5nIHRvIHN1Z2dlc3QgdG8gaGF2ZSBhIHNoaWZ0IHZhbHVlIHNwZWNpZmllZCBoZXJl LCB1bnRpbA0KPiBzcG90dGluZyB0aGF0IE5PREVTX1NISUZUIGlzbid0IHVzZWQgYW55d2hlcmUg ZWxzZSwgYW5kIGhlbmNlDQo+IHlvdSdyZSByaWdodGZ1bGx5IGRlbGV0aW5nIGl0LikNCj4gDQoN CkkgdGhpbmsgd2UgaGF2ZSBkaXNjdXNzZWQgYWJvdXQgdGhlIDI1NSBpbiB2MS4gQmVjYXVzZSBY ZW4gaXMgdXNpbmcNCnU4IGFzIG5vZGVpZF90LCBzbyAyNTUgbWF5IGJlIGEgdXBwZXIgYm91bmQu DQoNCkFuZCBpZiB1c2UgYSBzaGlmdCB2YWx1ZSwgZnJvbSBhIHVzZXIgcGVyc3BlY3RpdmUsIEkg ZG9uJ3QgbGlrZSBpdC4NCkl0IG5lZWRzIHRvIGJlIGNvbnZlcnRlZCwgbm90IGludHVpdGl2ZSBl bm91Z2guIEl0IGFsc28gbGltaXRzIG15DQppbnB1dCByYW5nZSwgZXZlbiB0aG91Z2ggbXkgbnVt ZXJpY2FsIHZhbHVlcyBhcmUgcmVhc29uYWJsZS4gWWVzLA0KaWYgYSBtYWNoaW5lIGhhcyAxNSBu b2RlLCB3ZSBjYW4gYXNrIHRoZW0gdG8gaW5wdXQgMTYsIGJ1dCB3aHkgbm90DQpsZXQgdGhlIHVz ZXJzIGRlY2lkZT8gaW5zdGVhZCBvZiBiZWluZyBmb3JjZWQgdG8gZW50ZXIgMTYgYnkgdGhlIHBy b2dyYW0/DQoNCj4gPiArCWhlbHANCj4gPiArCSAgQ29udHJvbHMgdGhlIGJ1aWxkLXRpbWUgc2l6 ZSBvZiB2YXJpb3VzIGFycmF5cyBhbmQgYml0bWFwcw0KPiA+ICsJICBhc3NvY2lhdGVkIHdpdGgg bXVsdGlwbGUtbm9kZXMgbWFuYWdlbWVudC4gSXQgaXMgdGhlIHVwcGVyIGJvdW5kDQo+IG9mDQo+ ID4gKwkgIHRoZSBudW1iZXIgb2YgTlVNQSBub2RlcyB0aGF0IHRoZSBzY2hlZHVsZXIsIG1lbW9y eSBhbGxvY2F0aW9uIGFuZA0KPiA+ICsgICAgICAgICAgb3RoZXIgTlVNQS1hd2FyZSBjb21wb25l bnRzIGNhbiBoYW5kbGUuDQo+IA0KPiBOaXQ6IGluZGVudGF0aW9uLg0KPiANCg0KT2suDQoNCkNo ZWVycywNCldlaSBDaGVuDQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:18:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:18:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367266.598341 (Exim 4.92) (envelope-from ) id 1oBvux-00012h-0H; Thu, 14 Jul 2022 10:17:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367266.598341; Thu, 14 Jul 2022 10:17:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvuw-00012Y-Tp; Thu, 14 Jul 2022 10:17:58 +0000 Received: by outflank-mailman (input) for mailman id 367266; Thu, 14 Jul 2022 10:17:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvuv-00012L-U4 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:17:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80075.outbound.protection.outlook.com [40.107.8.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ac18a05-035e-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:17:56 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7133.eurprd04.prod.outlook.com (2603:10a6:800:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 10:17:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:17:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ac18a05-035e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IeJIulJ56Nb2dkf7rqk5rSd7PQHHLsemaHpwr1Md+PczuAdlOFldmH95SjTe1qwX02IUNEgfCXzAqijKm9oMPS0tEY62+c/SqwKDwBJCRr6VcvqlbQEi12NBIGg8TuoLNkNG6MFVv+6KPOBnFYGXDEDOH1Ca4Rg+eddIxw9nOpUGL5QUoLfbihI5vv8szVoyaHpx6c+DfNMVzIRxArhp8makvdhqapGXn3QUjLV6HaxBqPptZWMMOQYu+pNmwnIhUyRsehpT0W2EOcnITpEodOCLwD/Lkpop3RX1udKZDPH/R0F68980mheIjUncqWVwYuMnIegkQL5h5Z2fIoxLVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j03mID6bl8/6lDw0QEjHD4R/1oGOPe96nOda6mrupuE=; b=FjunMJUG/SwllBqhSYtp9DK0r+CJitRIXPADwM9plcwHhhvUPtE1V95wl72dMISt2Wh26Y+DjlNK0I7A/ZXlqccW2lXGBWKqyy2zT1oG232nymekqM6jb8cVbvsRLJu42lwa7Ys09ztlQ/q57EWE+u60UjLWZ5+f4B4dK96R3D8JNN/6DPJ+X6Vniy7xvPdNadJuqjQozgzsdFvlgRL8qlgpgJapn1iTvmYp1cWojmlG2KJvoBsY0PEYW7DMciwRjQ3beSph2SSebiiyDmfrfFD5wJ/g651xuks6i9gligUN9Sw0MobcuIRcDEZ65qywtbiJF1t3WkhBRea1JrsweQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j03mID6bl8/6lDw0QEjHD4R/1oGOPe96nOda6mrupuE=; b=ZUG/ZInIQPuf6zKjOgW+ca6qvrAIo700hhaXM4DelS7QWe1upDHySa9jAYmFYTcySNLZO9oasfGLs7Zi6fTGXLODQBEcUyw3IzvPhcG8X6HPXIyqTazLc1/YT+Zcb54RG+vTHm0eprrUN8kgCwsaiyEDffXXh3ySsuE1ESVZDNJ5UQsQv7wsFVPEPkyj9MwH3YQwSurxAFD0qpG9Lqctj74+/PiP/8S52VYOUQS0Q276tGdg4ux6YJKQk07XhVijkm2d1rhweeI6rab9doVACyBvnmY8aktviuIxoRjuImEieVBQsIOyU//Hb8uqXhUFzVGyo1ygBazjdZloA0AVqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> Date: Thu, 14 Jul 2022 12:17:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e6ba117-6816-40a7-c74a-08da65821da9 X-MS-TrafficTypeDiagnostic: VI1PR04MB7133:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3UBQREBIYXukoMHEw9EBN3HVqWBfNsFeygWOUM264TPCXIhHprwiM2c3Gce8BdBH8V87HK0OEtYbAhhoaSbASI/hE8rTde+NwHTAj7pNJFusmu1DzmB2FFL1kTYFcD8WFPjFwPJ75Cwr17JyJad5r4zUJg8He4EKX52iWKRwLaYeRDcEkpTvUgjCCO2tmnRro5Un8oEJIFZ9Mn3NnHaBVFHyQyUoruCO7KNYfwDg/puSBcGx4/ZcC4Lw5EP30B6D4sM+DjlARO37c60HboDP17V7LRaxT5OCxUvOa3gksdOWy/cocMnL/6A7S0Ak7SuB1uzTpDBnTNCwxwvJwKVByaJd446ZKhGzxfyEiLNApS1vbLKCA0O8JiIjywSQhVpgdojpuNbaK2FkiLORWWdjHodao6Wjxy5ahWTBdDpENJUfNrc4eae/74UoiB379qq7RkTCniil3WsGgbUIUhfSZUdw892kDJWPVT7WaUchjFW0yGRkwSjBWUEIKx37B8c3cLYbT1kP44N6hspo08Gdw8IHOdnun28Zo/AohBZTpqR4tvWCWUW581mscWO+ArP91E5YWEmjt9XugC+3N2eqqeI1n+pyBWJMPl7fm3QbJ/iRAUmeiFBWsA+R+1X9xJedpN9LsY1KHtMzJyMzbfs8PFeNlwhJJPjw9S8YbMo9TUylXN2DCt6oPhN/Brflvuj4mjOhjguBFV+GO1KKn20zQyhnsaOhoBf82jWq4Lc5WEyo6JZ3h2iWKMp7eiNQ8X6aeU5KsN6cYs4Ff7wUMT+AHx+nL8LP7hd9YeLa7mxoU3W/qb2vrFH7DQwNrqTmze8kw/kgbB45PaFyun10YSn58BbxNdLmYNu8GFVHP+xykak= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(366004)(396003)(136003)(36756003)(5660300002)(186003)(31686004)(66946007)(4326008)(8676002)(2906002)(66476007)(8936002)(66556008)(41300700001)(6486002)(478600001)(86362001)(6506007)(53546011)(316002)(26005)(6512007)(31696002)(54906003)(2616005)(6916009)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3dtbGNMbWRWRThiSUxpdXhiWkJvTkc5bWlFSU8rdk4wTHFJVlpidElIVTI0?= =?utf-8?B?clBsOWpTRmdOZnNhdlA2ZFdFc0VpcXllNWhRcy9yd2MwRmZXbENWM29GTDFQ?= =?utf-8?B?UFhOS3JoL1BsZnpqYlhGUit2QmVDRjdtRitGS0taalhLTk82RUl1ZCtvYjhI?= =?utf-8?B?anVrVW1lRFBnUVVDdVpjSVM2emNmRnR5N1FJZHdHcHNPbmpsa3ZkbnA4T0Jo?= =?utf-8?B?SEJUaXI2WDU2UFlUaW5rMXFLM3VKczFXOElRdWxvTGp0OTVkNEhmdm8zRGFy?= =?utf-8?B?Ny9ieElQZHVZQWU0NC8xWkk1d2dWblc1a3dmREkxSldpK1dCSmR0QVZQNUI0?= =?utf-8?B?V1Jnc1A1Y2FqdjVpaEgyaWNHSWNNMUg2a0U0SlJwTlFlWkI1VzR6czFzeTc2?= =?utf-8?B?UDlLcU83eGhhSEkyUW92NWtwajBtdndSYytNRWF3N3Z6eENVTnhpNEord3Fj?= =?utf-8?B?OGpGd3FlTHZjQnFFQlVJdUNyQjQ0azd5V0JWdzBySFlGcWh3S3ZHL0RTS1hi?= =?utf-8?B?VEI2TDRlTTc3LzJkNTA0ek5sVjlZVkxzWGYvVHY4TXRneXNiQ05zS1V6ZExP?= =?utf-8?B?dkRxTDd5NHpMWWlQNFlWQXhtQkdtOSsvOXlHcXNJZ1RDSTJ4dlRkdEs3eDJF?= =?utf-8?B?QmN5Q2psWXlDWW9rVXg5OExTWGZlMmQwNThuOVpXRWo3cG8renRDeTk3dHNG?= =?utf-8?B?ZkRTSkJQdzBpQ01PVEZtSkZhajVNQWhad3o2dUFCRUliMjRlN0F0TkRYbllj?= =?utf-8?B?WXo3dldqVUVQMUU5ZlpvUjdsckVKbzRzZUMrT01sck9sVUlYQ2lZLzUvdGYy?= =?utf-8?B?UUJIVXZxQ3c1dGIyZGNWM2FtWmwybDhTUCs0TS9sc0hVbHc1N1BEdVdPRG42?= =?utf-8?B?WWZwY1dsUjZ4VDQrQ2p2N2xCaWEvV05UZlZteEFhMmYwNWhZUDc5a205bEpp?= =?utf-8?B?amd1TVBiL1phLzE3VmhqdUppUENkbHJ6RzJhWnhKU21GNnBIQktxS3hGS0JY?= =?utf-8?B?U2M1VGJwZEN5MlVNTTM2S1dCdkVTV0hZY05hVWJMYzVlVDBROS9VSEg2VzEx?= =?utf-8?B?SWU3V1E3VTZaY2dyTTBtYzlSS0ZZMFRIRGp3cXo0bDdVMkc3SjFPbmo2S0dk?= =?utf-8?B?b1VLUVlsWStYcVp5M2R2cWJhTTVhbEpoTVB0RnFOY0pXVWYzbzI1RlZPcitE?= =?utf-8?B?ZUVHUklHTFEreFJOaHZCK09LUVZSU2FsalNWTzh5WUdoTW9ZNThwQld1SGs3?= =?utf-8?B?anZTWW5Bekp3MTFFMEFaSm84eWJlcXlHSFNya3hnMU8reWZaVW5YN1EzdC9G?= =?utf-8?B?aGJ3RFg5UU9rT1ZCR2h2RFNCdnVscVN3SUhOQUlhU0dyNFB1Z09Sd0ZwaTMx?= =?utf-8?B?UUVxbWRMQ1dzVkZZc0JNMzI1STRTcXNOSko1eXp4MUYxQnh1MmpQVHQreDJq?= =?utf-8?B?STEyc3g4SnlObHVpWnE0alhaT2lhYkxLSWkzYk9xWHpvL3VwVkxxTEljbnpZ?= =?utf-8?B?WW5sMWNxcDI0djYrcUtuRU9BQ0F3TGtISjBkWGFRb29vOFJNbXQwZGRVSmpw?= =?utf-8?B?T3lmT2tiUy9WQ1NLQ2FZc3ZVVWYySE5GSFR6d2VQUmRESkViUXdaVUt2Szlu?= =?utf-8?B?ei8yZ2tQUTNPOVBXaXFYSnB5WmtwTFVoQUMwMHdTeThzMWhBSlFFc3ZzelNs?= =?utf-8?B?R3pJSHREZjlFc2crM3BxMkIrL1JXUVlWNUpUOCtxcXhtcWxMczZTMWxHY1B4?= =?utf-8?B?VXVmQ2VuRUo2VCtMVXZXeTh4d2RINDNnbFRZM0Z0SzhHVFJyc2ZMdEFEaXlY?= =?utf-8?B?UjJMMGtQN0Q5andISVUxZStFdWlKYS9nWFJZSkhjVllhMWhNL1hhSm5kM1h3?= =?utf-8?B?Zmh6VXZSU3JyVENPTi85R2VzeVFobFQzUk9FeUsrcmF0SkRzMVFxT0VQSVNp?= =?utf-8?B?UEE2amF2U0pzMk5wa2x2N0xIcnFiVzNqSzczTkpoVDRheUZWZDB4TDJ0V3Jh?= =?utf-8?B?Vys5eXUwL1NMckI2UzRoYkJScXJBV3pHVE9TMW9JUlAwL3FONmN6cUUwdWw0?= =?utf-8?B?ZEdFMVVYQkU2UmRtQ3FqclFBSDBVWm5PbHNUdzhGSWRwVTlkMzI5VVBwSGFJ?= =?utf-8?Q?Fz9Cc5cWKl29E5/Ek4JgTdage?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e6ba117-6816-40a7-c74a-08da65821da9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:17:54.5416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: K7eidlcfmqJVk3KwplgHaqcjv3wV9sJGZEfi1pmUCH0wPJ4xWOg8OgpJvjJPxfOVZ6E4g/DoYkM82z5DixAsNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7133 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > Add API similar to rmrr= and ivmd= arguments, but in a common code. This > will allow drivers to register reserved memory regardless of the IOMMU > vendor. > The direct reason for this API is xhci-dbc console driver (aka xue), > that needs to use DMA. But future change may unify command line > arguments for user-supplied reserved memory, and it may be useful for > other drivers in the future too. I take it that I'll understand the purpose of this when making it to later patches. > --- a/xen/drivers/passthrough/iommu.c > +++ b/xen/drivers/passthrough/iommu.c > @@ -651,6 +651,46 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) > return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); > } > > +#define MAX_EXTRA_RESERVED_RANGES 20 > +struct extra_reserved_range { > + xen_pfn_t start; Why not unsigned long? > + xen_ulong_t nr; Why not unsigned int or unsigned long? > + u32 sbdf; uint32_t please. All these type related remarks apply elsewhere as well; others below also apply wherever else applicable. > +}; > +static unsigned int __initdata nr_extra_reserved_ranges; > +static struct extra_reserved_range __initdata extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; Overly long line. > +int iommu_add_extra_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr, u32 sbdf) > +{ > + unsigned int idx; > + > + if ( nr_extra_reserved_ranges >= MAX_EXTRA_RESERVED_RANGES ) > + return -ENOMEM; > + > + idx = nr_extra_reserved_ranges++; > + extra_reserved_ranges[idx].start = start; > + extra_reserved_ranges[idx].nr = nr; > + extra_reserved_ranges[idx].sbdf = sbdf; > + return 0; > +} Blank line please before final return statement. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:21:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367279.598352 (Exim 4.92) (envelope-from ) id 1oBvyl-0002Xx-Gd; Thu, 14 Jul 2022 10:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367279.598352; Thu, 14 Jul 2022 10:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvyl-0002Xq-Dd; Thu, 14 Jul 2022 10:21:55 +0000 Received: by outflank-mailman (input) for mailman id 367279; Thu, 14 Jul 2022 10:21:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvyk-0002Xg-QJ; Thu, 14 Jul 2022 10:21:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvyk-0001JQ-MH; Thu, 14 Jul 2022 10:21:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvyk-0007xQ-54; Thu, 14 Jul 2022 10:21:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBvyk-0005MA-4F; Thu, 14 Jul 2022 10:21:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mms2MzhBF1AB9GZ6qNYFKL+sw/LmZHI3ZqjGX5TwUUo=; b=3hvBgWsBwMXBgy2vCa9DLHkY7w 2VOieIiBPN44oL15wpK86Cr9PGo6RMpl2JNv+Ja6xZ074NcuKYXpJEhxdvpRNS2hLGtli+aYsAt0Z EAcf8meS2nYsOuRx80l4Wb1bafyetEQunOor5EL7kgCEZx6NSMrpu1BAjdQiPBzUhW2k=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171619: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe X-Osstest-Versions-That: xen=033ae6f88be198b8f56043f94b7076b79b5e447e From: osstest service owner Date: Thu, 14 Jul 2022 10:21:54 +0000 flight 171619 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171619/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171605 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171605 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171605 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171605 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171605 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171605 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171605 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171605 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171605 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171605 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171605 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171605 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen d8cb7e0f069e0f106d24941355b59b45a731eabe baseline version: xen 033ae6f88be198b8f56043f94b7076b79b5e447e Last test of basis 171605 2022-07-12 17:38:22 Z 1 days Testing same since 171619 2022-07-13 16:49:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 033ae6f88b..d8cb7e0f06 d8cb7e0f069e0f106d24941355b59b45a731eabe -> master From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:22:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:22:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367293.598378 (Exim 4.92) (envelope-from ) id 1oBvzV-0003Jq-53; Thu, 14 Jul 2022 10:22:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367293.598378; Thu, 14 Jul 2022 10:22:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvzV-0003Jj-2M; Thu, 14 Jul 2022 10:22:41 +0000 Received: by outflank-mailman (input) for mailman id 367293; Thu, 14 Jul 2022 10:22:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBvzT-0002vg-Sb for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:22:40 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140051.outbound.protection.outlook.com [40.107.14.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2f8c746-035e-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:22:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7133.eurprd04.prod.outlook.com (2603:10a6:800:126::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 10:22:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:22:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2f8c746-035e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G96STHvvt+V3ZJDvdHwpkHE+uCVngx+seSLqVAUN9rAe9gsO05BNLRPs5mnFAT69V98kBYKtlGFpsktIvxlXBEYYIjPjnHqen2zvbDe50eBfxclzjdmxG3eXzYPzGRKU5h4okwvvT7JqyRAPJPB2m9C6peeeiIjzUdZ59ZmJaSDaPKb9CXEoIqRnxqmBJgNOKJ1/g1e0L8Zgq4KhW26CBxXEWOONfqKr4Fqp0AdGocTVaRzgc0/7YXel9/3RtIAp8E5gToinjptjhNj+X8GKAnbjAlanQv7CDUV4zYL17Ieabj6svYkg91dcdRNQye4Bxgjzp7pxo+YMzR+M0YPIiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q8OpmW4MgrVn+Wl2J7lABTGUu0w2yPM03XOTyhPALbw=; b=mzqpuLbpKaUPKOzdycKm2zp69LhzSUHwwy/6EeeMXkzTjrsBMDuL03lrhWerPFQoRx6ehesRHziB42kB4Zv2oNiqfW1/YUBre6TEaAinoaSLrnoVJg2OFJ9Lr/ywyB4e+hML0RVZcJXQ4d72xAWJA+aLdUx7A0G/tHDEfxy6+8FzE92e1wmSKq9s1t4eneu0mJM1Vbz0xbuxp31WRgn5qh23KxCA0AvehHIgdiIMcDvKM88YwatzovKX24iT+HBpJcic/XOWQ/MJDIAwvtmAS7tjzlKOaMSgUFEdmHyV36GNk7VBl62pPdG3ZKRC0Va+CssP18XU80Es5C+0FMSYhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8OpmW4MgrVn+Wl2J7lABTGUu0w2yPM03XOTyhPALbw=; b=K7YtrtQsIX0xDuLCiAKVJ0ZKcxirbgJlyZ120W4LkYPcRaqDx3YPr8p2MvFdCcIQt3i7SEuRF1aeb1m4vuTTArl1F746h1w4YS3M6nMGypGj7t3HO+VrOFSb1rildDWjF5qx/MURLKehldfTWCOhvWGKXesGqdUIZ5o9EGsJD6ShfnKYmPg2tlaE2RKh//vzhOudGh2IRqUqobKa4KbXVTBSzXj5yBYKQLPK4McGBIRQGdqe6bTLNsVOkPDMcaOOhwlsaU2MN6OYoRehiA73G2b0rdZNqAfnOS4nOU0Xmfc/QRkDHAXSpLUZUS1Pucm88d0sEwfdZ1OSPamof2CsyQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <00c64c2e-a007-8188-469e-08e8c8cd25e1@suse.com> Date: Thu, 14 Jul 2022 12:22:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 7/9] IOMMU/AMD: wire common device reserved memory API Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , xen-devel@lists.xenproject.org References: <457056cbc6dcc00958b1f4e0cad35121e0cd1557.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <457056cbc6dcc00958b1f4e0cad35121e0cd1557.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9P251CA0004.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:50f::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c3746ed-f069-4732-0bb6-08da6582c685 X-MS-TrafficTypeDiagnostic: VI1PR04MB7133:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Kv3eMj1OlrBcMj6jldRYK//DvKwfYKYvPsOZmtoWYOHMbkSTIfrHR0OOh47GqXm+QdyAZrq22mKnBdMuEKKLkUI0MowZ8KGZiEICzuK9Igfu6952oJv/jOa0QGVsT4jcD/FM2yL+SgwJZV0QQC9dupCZuU3c+TGg8KK908/yxgEM64jUArkW4PZcfDLc2VPKs1C0WsvdQrTz8lmlGgi2g1lponIAODRK97eSZX5+3BGn07o/msZczdztNJl7bzKMze++rvWA7UAnc4HLUi6LkpkO+IxYzf17gjsNK9+HAgu63+HGc1o++4hTX4vpe/fyn161vihz9OHzcgcz28wQXio+7unWaTebdseyO1oKiZ+mqyYE2zuHGk9wdJjje0ME1MnBd0cK5sWEWSHP5JvMTx4DnMhaB35MrQlKl/y8+/5la6imlDBuUpYNfQQkCzE5OJCCyLOS//RHjlysXMU2gZzY+RVnxQdx9yIFQ59psssKYU1YyeKfRnLcbsVFDuOITtoK1TBdJQNoDzdv001NH1yWhpiIEwIFuPpfHNwP+Jn9Z9XYwyZ+mcHAL4wtKgT0GLWbreu22kouVcTZIGlMTnq4Vom/3UNh6UdkfuI6PMUwdG2tG3kIsHbPHJwYj+QFLmZKHcgI/jgWO9Zoaj+EdEL3TA/3zcq34yhdiDJ/N3SkemIf2kDi2oQTTDM7tgadrnCrEBqHnDk7Ht4NgP1fpahLHNqwYhryIiHgnNIT8MeaH+Byh0FWqvZZl4v3Zj5wn8urmSIbhljJBaf4khEjltqHa4YELIQ9uAqp84wnd583HQIJ0nK2G+SmetRNLD3qW1BnA4MxRVwkh/M3HTyCV0Yjl77a8YWpCfUpgSbqFXQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(376002)(39860400002)(346002)(366004)(26005)(6512007)(316002)(2616005)(6916009)(31696002)(6486002)(41300700001)(53546011)(478600001)(86362001)(6506007)(38100700002)(186003)(83380400001)(66574015)(5660300002)(36756003)(66476007)(8936002)(66556008)(31686004)(66946007)(2906002)(4744005)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WEJDWVdkREFUTzZpWlNQL21iMnhGMkhwcVhGeVJrd0FYM0diUitlTkVOcW5T?= =?utf-8?B?UUFUNmNEWUJHenN5VGhEMWpuOEhDU1AvZEJNT2Z2Vm9TU25JK1NNbnIvc25B?= =?utf-8?B?QkhwZDljTW9sR2lHUVRtWnMxTWEyRVBqUERtL2xSa2h1SEpqOGh0VVlPTURX?= =?utf-8?B?TGdKUkpFVEdEYmpwdVRxdk1KMkxqUGVXeGt3TVcvS2tRL3pmRFRQVXY4T3h1?= =?utf-8?B?ejh1bHptVnB5Z01pa3RyV3JJUmtXUnlmUXFUVitQRlVZSHRtd2lVV2FWRzV5?= =?utf-8?B?dGZ0VHRLaG9CTzFmK3dmaDJ4K1dRb2lweHhMdlJ5STBrSUhMQ3FQWWdUamdX?= =?utf-8?B?L0I4UUlnT2J2eVpOa21BQWJOZS91bTJ5Rng2T1Rhd2syWjkzSC9oSmVldWNH?= =?utf-8?B?UWxha2NiUVF0aWw4SmFib0lTeXppYzVYOXkzcW9LMXYvYlJTMXoxRkFINGJP?= =?utf-8?B?S0hxMUNQM1k2RzNyYjBaNWxFSGlub05mczJWZlc2QmhvY0xkOXJCZHRVVFp6?= =?utf-8?B?bU5JTVhpNWlzUjk2N3ZVL1NGbFRDdnVmNk1TVUNQK2FrS1NxQnRKQnRqSDhV?= =?utf-8?B?Q2ppMGY3QmI1UFJwNFg0SmlCeUhmaDdJVkZXWWY5OW9Xd2E4Yjk5MExIUnhB?= =?utf-8?B?WEFHNTRsY2k3UjBLblh1N2F2Rk5FMGJiOHhDRXlNRXRIUnlOckFQeTJsTXJi?= =?utf-8?B?OTNMbHkrdTg4UENUUDU3b09uV3VRVEN1ZmFjQ3pmMXpYdTl5dmtVcUM1TTFy?= =?utf-8?B?ZnhNUFRpQXo1YUY4eFl0WG5JWXRMWHU3cHdVR1pUcS9UT2FCR04rUjRpTm1o?= =?utf-8?B?Ym5aVHdFclpkMXBURFpUSmlUOFdXNHlhbUR4WlZXbk85a2hHVXVBSUh5aHV4?= =?utf-8?B?R2FnZmliYWo5d2Z2Y1ZmRW11dTNrWVoxL2VsMS80SzR2YzAvUm5xVDhlb2FR?= =?utf-8?B?VnB0bWx4MFhXOVJTaXN2VmlwODR4VlVMSGxlNjBnTEZBRG9GOE5KRW0xNGpU?= =?utf-8?B?eG5aN2pWazRxRHcwcGFjWnFjdC9VTFF0eFBDNmxCQVpxZjdDaDFBVCtaTXoz?= =?utf-8?B?L05TM3p4b0RXUUxQZWVmR0tNb1pEZ1A0WUhIaGZtT0JHczZheGljUjdOQnNi?= =?utf-8?B?Sk5OR1RDREcvS091L0VXejhEbHI2RzRNdUpxdWl2Z3NzRDBzU2l0WitYQmlq?= =?utf-8?B?bnlZbkpZZ3M4VWIrNWRaeTRWcVlFUUxqYSsxNWtIc0ZjUUJVbDVPRW1ONnBv?= =?utf-8?B?eTlzTCtTUStZWG9rVW8yRE5EMUhIbWFhNnlkTkYyd0JaNlVMOFZVOFBWTjg4?= =?utf-8?B?ZHFmd3JYdFEzQnhmdDBlbkZPNGVhZjU4bmlkNmJ1dVRTM2loaXhkSXF5L3BQ?= =?utf-8?B?a2dvNm4yTnk2K3g4Zi9BVHJzbHhLdkx4LzRhWVJONGxiakpnUDQ0RnZCQm5u?= =?utf-8?B?RzRLaTRKZzVHeXZsMytnWGRObFB2Ny9aaGJIYnBOdDBSM3ZaUHE3Q2JnSG1S?= =?utf-8?B?QmplR1gzR0NjMURHcDkzZEQzRHZBZVE0VldWOVk3cWk2Y3huTWxvVHNGVWQv?= =?utf-8?B?RVgvNnRGRU0xWHlyNFZodm5PUzVzZytOaDg5NUJBc1lNWi9pOG1rNnJuNkpG?= =?utf-8?B?QXFGOGljT0xSMzFoSkhad2dYcWtSaXJpOEc3SVlUVkJjUHBuay9DM1hQM0Fl?= =?utf-8?B?ZExBbXlsNVlrUmE4dlJLQ2JQWStZcmJqOXkwRHV3RnFLelREcG12SjM1OURW?= =?utf-8?B?U1dGaXlGekVmSkJGcStNQ3QxbmROM3FTWmlGbUxYL1c4a0I0SnN3NUd3OWhF?= =?utf-8?B?UnpDTXBWUk1oL0NWNFMvd2EwZ1RsYkxLZ3JmR094aTlMRGM1R2hCUDV1V0pp?= =?utf-8?B?YjFTbXNKNnhWQndrKzhTczR5N1BPL2gwU0k0eGVNcm5JK3A1dHZRNGgzZTlj?= =?utf-8?B?KzE1UVdiUTB0WXVQcCtBZGpvV1VKQkk4Z0VjQ1k3Z1N1cFlGZ29ZWFZRZG9r?= =?utf-8?B?NjdOT004OUJyaFhJYVlseWlqYzhZdnJaelluczlNVXArekZzR2lHSFM0NUVW?= =?utf-8?B?UmJtellmenhTekZkWVhyaUQyOERRQmhtVEYxNDB0SEVjSi9Ha01saVd3V1lY?= =?utf-8?Q?y3NsimJ8YPEa2ZL5Vf2H8k1SM?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c3746ed-f069-4732-0bb6-08da6582c685 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:22:37.8358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMdmmPhkMAAE6AETWXPAP4wLBkoh8CHDs7jmDUTj8tocXooAqFbc9KrQ1gDV7uD/DAdg/GUwDTFRwAmqLkrfsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7133 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > @@ -1078,6 +1078,20 @@ static inline bool_t is_ivmd_block(u8 type) > type == ACPI_IVRS_TYPE_MEMORY_IOMMU); > } > > +static int __init cf_check add_one_extra_ivmd(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) > +{ > + struct acpi_ivrs_memory ivmd; > + > + ivmd.start_address = start << PAGE_SHIFT; > + ivmd.memory_length = nr << PAGE_SHIFT; Aren't these at risk of truncation on 32-bit architectures? We have suitable wrappers for such conversions, avoiding such issues. > + ivmd.header.flags = ACPI_IVMD_UNITY | > + ACPI_IVMD_READ | ACPI_IVMD_WRITE; > + ivmd.header.length = sizeof(ivmd); > + ivmd.header.device_id = id; > + ivmd.header.type = ACPI_IVRS_TYPE_MEMORY_ONE; Please make these the variable's initializer. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:26:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:26:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367305.598406 (Exim 4.92) (envelope-from ) id 1oBw3V-0004LP-Sl; Thu, 14 Jul 2022 10:26:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367305.598406; Thu, 14 Jul 2022 10:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBw3V-0004LI-Pw; Thu, 14 Jul 2022 10:26:49 +0000 Received: by outflank-mailman (input) for mailman id 367305; Thu, 14 Jul 2022 10:26:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBw3U-0004Eo-1K for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:26:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80073.outbound.protection.outlook.com [40.107.8.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 76b022ba-035f-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:26:46 +0200 (CEST) Received: from FR3P281CA0077.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::10) by DBBPR08MB6009.eurprd08.prod.outlook.com (2603:10a6:10:1f5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Thu, 14 Jul 2022 10:26:44 +0000 Received: from VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1f:cafe::59) by FR3P281CA0077.outlook.office365.com (2603:10a6:d10:1f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.6 via Frontend Transport; Thu, 14 Jul 2022 10:26:44 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT039.mail.protection.outlook.com (10.152.19.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16 via Frontend Transport; Thu, 14 Jul 2022 10:26:43 +0000 Received: ("Tessian outbound 0ba541f03a2a:v122"); Thu, 14 Jul 2022 10:26:43 +0000 Received: from 29e173dc9270.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E7288B6A-2FFF-4F5A-BBB4-30F04256BBBB.1; Thu, 14 Jul 2022 10:26:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 29e173dc9270.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 10:26:37 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB4567.eurprd08.prod.outlook.com (2603:10a6:20b:b0::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 10:26:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:26:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 76b022ba-035f-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=fgtqguuO4W7xna52fzYUaqe+QscS5zO3jn2b94miYB4+YrXy7mhOr+8P1HxUzG8XgPSunC12Qrk3RTnrAlTphj0G9TuNeUwv8aaMzEdem8TAk9CBeWaqzJO6WzyYL6vf2JJ6RGzR2yTlPfQDA2Kg6VTmmFlosI5o9JwHtUj/piq8wqNJUbebpiyqg2xjyQPFzn9uQg9mH7th9MDSCGvN6kiv5hQfZKlswCat84KtFVSNapvLBN6sgiRaY7tzPX0cngK+c4OiMOjUIJWH6QCM2OadUxClfrsA93wCq+/Q0+/yPjax2oxJG0k8IyB/u0De2P0C46nujYy9FnS0wDCDsw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4oTIMlQg8UVVIUd34TiOjZI3QtD4f96r6dKnDq6w/PY=; b=DbZ/fMs8gEBZ0m8g0obepSOnXTdvkyItIqPttM1MF7rylSdS3r8xYki9/HcpLNsTTe6vGwcdcwW3JhFl3Alt2g3oupo9yXExrCVrDvpfo34a8LqutMKIA7FVG+lqJGwOCLrWqdQ6dLG+Mddh3mnwLYotKZQMDoH7EXIC0tm0zwTPRugl5oDFt/TOdSor9T2Gfgt+DFGDGX24dBHUt8Bn0BS6x/l2npM5nj9RcXkHpIddC+3Hr9HjEeqp4izGg+DApLWD3X5UXKckf8+GPHu8wPK9DbpeGyaHyGd3sNzIAyWnGSVW3v5c5otC49SOUfK7Lx3O35Vaw1LpftHNwMIyaw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4oTIMlQg8UVVIUd34TiOjZI3QtD4f96r6dKnDq6w/PY=; b=qUI/w5bfO9Anynx2J1pZmU43awGVJlXz3XV8WVzDmsc8HCJWivqKE2m0lsupIbY/yIjASOVBHUObpQUTtOvemlKLKuHyNEw42FDgO54OQl6Nvos+xbaHLp+uVHQCYO8kPkNeZrCN2zrYpKFnfvyjSJ689moSpq/6ppZ+x9r6YYk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y2v7w5OH8jpkRNwORYM6BMyDtAuWHALlDsDFJafZxNjEDZnmmQGWYboSoLVIvsPZnC7jzywfLYmptKIQMen1lsqAOVsqHt4TpIc331P8WFYeFQBlZmSOwfmuvbseWbbfRfbwZzmfI5+CCDfPTSHpXbbn8Svsz3L/bim5luMG0ZCF1PhI5uY8I+D49zpJ8JcpxJYDP7gzTqwTyj1CHPOooFKphWSrv5em7bDlUlECTo1tH011Hu3WodPnXmlTjoHPIkxCeNcpQpi4VRv7lnYLJWWIoOA+MHwxEgsAATtk1MevD6dw95g/pyi4HSf/P+AcHfSiD0xUlMUlHtTK9+oo7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4oTIMlQg8UVVIUd34TiOjZI3QtD4f96r6dKnDq6w/PY=; b=obKeHm0rEY/9oeZeUFrjEadyLrCP/6Q+2Bou5Ztey8Vusw7/YIdHCyXeOKcIQXA4FRPBr25JU5A0HQCKdEBlTcvR912vBm2eMxACg8qQGDBoOUXMRaKbj5jfwOiseSWFHtKbEKCZuT8+ZDs6uiLJa1o1T6PdyjKBnI1i5yORNCbwPJl1HaEn+vg2zLYH0SjiI8TlovScuC7y+ZUWFCLuGICqsV7wtcdqGXv7YlVC0fKUX7j20TScCh223gsfZ1QZC6c9Hq8+N4+ZyM+XImhfrrmTFiSsRhMiAf/c+/i1FraI8fZwwdNfabaHLccWaSXe8KSo9GJocLw+ieD+7bY0+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4oTIMlQg8UVVIUd34TiOjZI3QtD4f96r6dKnDq6w/PY=; b=qUI/w5bfO9Anynx2J1pZmU43awGVJlXz3XV8WVzDmsc8HCJWivqKE2m0lsupIbY/yIjASOVBHUObpQUTtOvemlKLKuHyNEw42FDgO54OQl6Nvos+xbaHLp+uVHQCYO8kPkNeZrCN2zrYpKFnfvyjSJ689moSpq/6ppZ+x9r6YYk= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItggAACa4CAAAWRQA== Date: Thu, 14 Jul 2022 10:26:35 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 4B2395EE90CBF440BCBB3B82F5320B29.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 6588c896-8bcc-4335-b487-08da6583590d x-ms-traffictypediagnostic: AM6PR08MB4567:EE_|VE1EUR03FT039:EE_|DBBPR08MB6009:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: bFqoWYt3FM/o/zLX8twL8KaPbpmJxgVKnlC1IN+O4WftvfvArFEu5XCtBnlgTUKUY26+zc2gPbSINf3cH5OU8AjceT2xSGgGJIqwltDRu07NI2tGTcO010gB25+n4+CKEMtj5B0a+i62aXxw7RNo+3UpmuFlKXvZGejgVLkv3y6DqAlWFJOcE0stLGArn3fSkGTnqRJpPWuOOM8BQRATs1ZYBHr5sDU2wUvfDXCH8ehzkCpsPqapfHbcE4OTxVNVugU1QFAOy9NbDWTWYawNvnTeQVQBuFkUKgqD8usLA0VwOfL2R19JHUIhfGVRlxVT2IOlW+pnENTdMrZfQWv9rrJdWMdfzJZqb8LvOBCzxIJQjeobtI/79GSOd3gqUxi8ODleUyYkfef2R7iySwnoqFgRWY0PA0dSj36774DxO//o+5keR4WSXLN7jgrApJk75/IBaPAU+WkzKDYJLzFmlyNkUCcpFzGO+P7yD1m79LE7vHD5aAIR03Pi22JYUsyCZEEjQysz5NXgVn0LWK5fd4P39l8c4p2Rp6AfrI/s7we10zcfklAfH37ZgGrtcPDkLS62hL6lDDj1nvfpNU7pzgvIZDOtHP0PNVQfXa+T5DwYUgh2tAZ1+EVp0bhz6bdeqGcD+mNb3pRDRNmukI2r9jXidw0scwT2sTHk6+QRo5S4OAzCXhF0Nu/frMgsRzHGPFpejhduwUiLboCv9GJB8DbOzUukzJCsSw/nYbwCQSFTTZHrXjI9b8YtgAl3Xvr5JPu74D+EhoIq/Rh3KchX52nOUQLGN23bS/G8r6VLpYQEplnniuNVrF+ZP4WaSyTM X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(396003)(136003)(346002)(376002)(478600001)(9686003)(66446008)(6506007)(26005)(38100700002)(54906003)(2906002)(52536014)(53546011)(8936002)(86362001)(5660300002)(33656002)(41300700001)(55016003)(66556008)(66476007)(8676002)(83380400001)(71200400001)(66946007)(122000001)(4326008)(316002)(7696005)(186003)(6916009)(38070700005)(76116006)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4567 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 828b1e3b-8b73-4d0c-3bf9-08da6583548e X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H6VrKVXFahnQ7TeB78PK/o5i4vmYkhqByw/OndPf36ni2rbtIGr7TKbCPpNFWurkQqye+bJR7WUgE0jDlWzTy6Lp+ErXXOkV/qoSPcbP4y5zlm3Wx6K9kWQsmlnixXniroUiwnoFpyjSMvgLiZDY7iaCBY0UrVve8sfSATdv7k0s/5OkP95h/+aGxG4T0ymRmbu/chGpbPIpjFPxSa4OPr78/E6xWBokP8dPaDrHR/Eb7bPcV9vxlTGczSwde6+O7eb85T3badxD+mgogkpLL3JW8ZTzFoEeaFffGJa2bxkemph1SqoSt2lDMPJsuS6G41AispPCu7xLS7z3C+iiJa3KpVjkhAfB6Dgv4i5Y+TqDwqjkQj3jUHKJH8alZydlUliym+eLPaQ5fAxzHNPGZOOaP7QS2QooU+l3jbAZohe4HndEL/uxNPU3qbpeVeeyq8B0IS/idqLEJ69NruhiRDEXw/yq1LyozbO5jLTMjxdhMgLWlFH2qerAAczT/JhXFgqe6LmJDMz5NejB+nkTFd7O6YI3kKC9rqnc0L9DHkEnLGGfIK9XzHBd2f36DPLMPDIXzE41mUZc7RnxdeHVzTQu7gBCrumQkg7YAjdD3v0ItKxVbe+95I9hb1VOSMfiN2bTiqtA3yojwqJt0S802S1qEjkvLFCFcGmQSxVWArodlo7/RH5Gt5nRb36UgfYiNDPQVY6yvOqBj3x2ii16Xd01EdSw9W+OwfGssqxLqZ8Bam/MsqQhw8IPwcbsPLg3himlLqBPAiVoPW9uS//dwKuaQUu73PupiEea/pOh7ibJLON1GFMGEqphZ6/uiAyA X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(396003)(136003)(46966006)(36840700001)(40470700004)(26005)(9686003)(47076005)(336012)(40480700001)(53546011)(52536014)(356005)(186003)(86362001)(40460700003)(7696005)(81166007)(33656002)(2906002)(36860700001)(82310400005)(83380400001)(316002)(6862004)(8676002)(54906003)(82740400003)(8936002)(5660300002)(70586007)(55016003)(478600001)(4326008)(41300700001)(70206006)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:26:43.4444 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6588c896-8bcc-4335-b487-08da6583590d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT039.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6009 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxNOaXpSAxNzo1OA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg Mi85XSB4ZW4veDg2OiBVc2UgZW51bWVyYXRpb25zIHRvIGluZGljYXRlIE5VTUENCj4gc3RhdHVz DQo+IA0KPiA+DQo+ID4gSG93IGFib3V0IHVwZGF0ZSB0aGUgdGFibGUgbGlrZSB0aGlzOg0KPiA+ ICstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0t LS0rLS0tLS0tLS0tLS0tKw0KPiA+IHwgIG9yaWdpbmFsICB8ICAgICAgICAgIHwgICAgICAgICAg ICAgICAgfCAgICAgICAgICAgICAgICB8ICAgICAgICAgICAgfA0KPiA+ICstLS0tLS0tLS0tLS0r LS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0t Kw0KPiA+IHwgbnVtYV9vZmYgICB8IHRydWUgICAgIHwgdHJ1ZSAgICAgICAgICAgfCB0cnVlICAg ICAgICAgICB8IHRydWUgICAgICAgfA0KPiA+IHwgYWNwaV9udW1hICB8IDAgICAgICAgIHwgMSAg ICAgICAgICAgICAgfCAtMSAgICAgICAgICAgICB8IHggICAgICAgICAgfA0KPiA+IHwgbnVtYV9m YWtlICB8IHggICAgICAgIHwgeCAgICAgICAgICAgICAgfCB4ICAgICAgICAgICAgICB8IGZha2Vf bm9kZXMgfA0KPiA+IHwgZW51bSBzdGF0ZSB8IG51bWFfb2ZmIHwgbnVtYV9vZmYgICAgICAgfCBu dW1hX29mZiAgICAgICB8IG51bWFfb2ZmICAgfA0KPiA+ICstLS0tLS0tLS0tLS0rLS0tLS0tLS0t LSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKw0KPiA+DQo+ ID4gKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLSstLS0tLS0tLS0t LS0tKy0tLS0tLS0tLS0tLSsNCj4gPiB8ICBvcmlnaW5hbCAgfCAgICAgICAgICAgICAgICB8ICAg ICAgICAgICAgfCAgICAgICAgICAgICB8ICAgICAgICAgICAgfA0KPiA+ICstLS0tLS0tLS0tLS0r LS0tLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0r DQo+ID4gfCBudW1hX29mZiAgIHwgZmFsc2UgICAgICAgICAgfCBmYWxzZSAgICAgIHwgZmFsc2Ug ICAgICAgfCBmYWxzZSAgICAgIHwNCj4gPiB8IGFjcGlfbnVtYSAgfCAwICAgICAgICAgICAgICB8 IDEgICAgICAgICAgfCAtMSAgICAgICAgICB8IHggICAgICAgICAgfA0KPiA+IHwgbnVtYV9mYWtl ICB8IHggICAgICAgICAgICAgIHwgeCAgICAgICAgICB8IHggICAgICAgICAgIHwgZmFrZV9ub2Rl cyB8DQo+ID4gfCBlbnVtIHN0YXRlIHwgbnVtYV9md19ub2RhdGEgfCBudW1hX2Z3X29rIHwgbnVt YV9md19iYWQgfCBudW1hX2VtdSAgIHwNCj4gPiArLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0t LS0rLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tKw0KPiANCj4gV2VsbCwg dGhpcyBtYWtlcyB0aGUgdGFibGUgY29tcGxldGUsIGJ1dCBpdCBkb2Vzbid0IGV4cGxhaW4gaG93 IHlvdSBtZWFuDQo+IHRvIGZvbGQgdGhlIHNldHRpbmdzIG9mIHRoZSB0d28gY29tbWFuZCBsaW5l IG9wdGlvbnMgaW50byBvbmUgdmFyaWFibGUuDQo+IA0KDQpObyBtYXR0ZXIgaG93IG1hbnkgc2Vw YXJhdGUgIm51bWE9IiBwYXJhbWV0ZXJzIGhhdmUgYmVlbiBwYXJzZWQgZnJvbQ0KQ29tbWFuZCBs aW5lLCB0aGUgdmFsdWVzIG9mIHRoZXNlIG9yaWdpbmFsIHZhcmlhYmxlcyBhcmUgZGV0ZXJtaW5l ZA0KYWZ0ZXIgcGFyc2luZyB0aGUgY29tbWFuZCBsaW5lLiBTbyB0aGUgZGV0ZXJtaW5lZCBzdGF0 dXMgY2FuIGJlIG1hcHBlZA0KdG8gdGhlIG5ldyBvbmUgdmFyaWFibGUgZnJvbSBhYm92ZSB0YWJs ZS4NCg0KVGhhbmtzLA0KV2VpIENoZW4NCg0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:33:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367344.598453 (Exim 4.92) (envelope-from ) id 1oBw9r-0007J6-9I; Thu, 14 Jul 2022 10:33:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367344.598453; Thu, 14 Jul 2022 10:33:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBw9r-0007Iw-6M; Thu, 14 Jul 2022 10:33:23 +0000 Received: by outflank-mailman (input) for mailman id 367344; Thu, 14 Jul 2022 10:33:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBw9p-0006sV-DM for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:33:21 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5f35a7b1-0360-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:33:18 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 06:33:09 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5916.namprd03.prod.outlook.com (2603:10b6:806:115::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 14 Jul 2022 10:33:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:33:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f35a7b1-0360-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657794798; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=VIjHaFxTIq3387J3I4OLADxWv+3LptoTj7Adnp4A4S4=; b=KjdcDaEZG/+8VVgXXDG+puwAFV6Wd/+Tk2lLRTzeUx1q7JjX4MSXyd8E xW89311Xd0vgOULSa/RwssQ7wbWZ6erPOSIvoKcNiVQi5tAFDKVO24sd7 L2BEXWN3mPI2sMYX7dhkEZmeC3Xlg2QzpBFEffJmK+3ay9y9L6eaONA11 k=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 78350323 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:4O7Wqqk3CP/OwxjcloT++qbo5gx+J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIdXzvVaf6NamCmfI9zaYq28RkDv5fSmNcyTQBu+ClgHiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462u4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kVItEHw6FlGVtJr 7s7DXMPXz6po7mPlefTpulE3qzPLeHNFaZG4zRK62GcCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAI7gvL9cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSL327eUx3iTtIQ6L6Xm595YjVOv9jYhFUBRFlKDpKChlRvrMz5YA wlOksY0loAW6UeiCPf0WRa1pHqZlhcGXpxbFOhSwASE1qrV7hvfGmEeVDdFQMQ8s9MxQzkj1 1vPlNTsbRR/vbvQVGmQ7Ky8qTKpJTNTPWIEfTUDTwYO/5/kuo5bphDFQ8tnEaW1psboAjy2y DePxAAuirNWgcMV2qGT+VHcnynqtpXPVhQy5AjcQiSi9AwRTK6oYZa5r2fS6/loJZycCFKGu RA5d9O26ekPCdSHknyLSeBURbWxva/bYHvbnEJlGIQn+3K14Xm/cItM4TZ4YkB0LsIDfjyva 0jW0e9M2KJu0LKRRfcfS+qM5w4ClMAMyfyNuijoU+dz IronPort-HdrOrdr: A9a23:zMFaTK0UAe/BU4J5oOo9ZQqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="78350323" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E7B8RkyoVEHIowkVPosUCIpyX2SzEutF+7l1eHYUV4+xGlb2LdKkvkgQ7qddSkCqHeNKjoCC+XLzbGoIPIBU99spsu9T8pWyR9RjD+cg+DVupTV7bmUu6Ogokz2/K+Ujqvr7Q96fYZUDjG0b06SCsUVIE9iYzpMG6dWh3DtzG5ILrkb4KTqf8ZL8s5yqmedxIoXDFkIzRSDfnbFUM0clmNHcoYPOsqVMYEIGYKDqzReG29WS0CaLdQBfp/+6yXQl/j1jjhEl1VfCxgHTRUX4D374PjojYhED5m5PTYtzqiIOyapzD6t9SIRkyibDosNGdrf9VgaH0GXgM/z9LL++8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VIjHaFxTIq3387J3I4OLADxWv+3LptoTj7Adnp4A4S4=; b=jMRfIv7I7EcrYK6P70C2R+YKv3iEVWUAgulBEd6P7u9z5W8Z2NH1qvAPuhUhOI1LfsA9qqw0ocMmjLkeZ4SFjShub6dv2I9BENLHSuphjeqaKVJnZuO3t7QXrQqz44Bkd7IHfeClk+K1uOvLYKbwB+qkzsGm7xdzDJWXBfcQUklaZoBVmIVaIUFW6kdVwbXO/lup341kFI+d1wJEdN5+WzVxWADHuy7SrZ6jqu8K6gOu4CAk+TRn8zSkGU+/bO4VAqpAU7L6TgzgXheR8gxl6TaSImPSTSCL9JyLt4kgiBsInMIym9cAKdU+ZcsfDWJ4UpjQV3hvSC6nbozqgrF5Rg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VIjHaFxTIq3387J3I4OLADxWv+3LptoTj7Adnp4A4S4=; b=mJ7EVRnk6leNmCnu2ThvA8plCUkVR3UcEF0McJV9KZzX7aPR3G5JsN8hfpv1XIjcCNkUoWaFcYL92yLyvlN7npbaRp6l8Cw3NXms4HsOXP8efIEzQiUbvvWLz4rnV3IjQZ2ucrc7+rdCQALGwlgJDltXwVFEhexvheVXM7pKUKQ= From: Andrew Cooper To: Luca Fancellu , Mathieu Tarral CC: Xen-users , Jan Beulich , Roger Pau Monne , xen-devel , Henry Wang Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Topic: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Index: AQHYlsiZU/X6oYzkBUqjI0g62JIGmK18caCAgAAKCoCAAPuhAIAAJpSAgAAJHQCAAAWjAA== Date: Thu, 14 Jul 2022 10:33:02 +0000 Message-ID: References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0f1a73cf-34a6-4bcc-0f1d-08da65843aeb x-ms-traffictypediagnostic: SA2PR03MB5916:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SejD1eR6W8WFvl7mNB9edznR+81PDFY+mBrBwzJ7WE1YNnNI3OzM5lwVAEL4+DBbddXRz6x0oqeFdQBE0QJ8vU05ChoVqrNRnBcDpAwqEZtwbL/Yyo+dKjfAfN49BwM7zWSrSOU7jUEzBdGOts+Bquv3z4+bDBXjMv4dit027ITZCFPksd3XUIn16cVRnvxFEhgPlX90y15gmi3JovxPfjeXd0YPQ9Mr27CrAG/UCW9aLmzB/jFy9Y7n1O7F295N0YoIsgDkqHYmF8cwGQXf4Pxs1d02NB5cCnIkhFUMlbCsO3vsYkKvMh31YxIwvtCWAYUlHQBKfL0Xfz+y0eyx05UyooNqRAVhhbe2pCmnIh8P0PIiCad8jbGUvNS4k4i4gylqt+scrOgfbE/kd/wjRmr8v1jzjy/vRJADqM90s6/0vdPT6Z2/cPWp8HVNvFs1BvQQL+Jiqc6SdIKVl7vD/zVRqplMPWmVD8oupAHwwnDVajOjTgHayFBmnsT9Z0HRZAMcRApjNTA6T3ChXlaf9eS/QX/RhBzQFjJ9L6Tb1FINWQIX6LGZiaPo3mb+XD321jxI/U7Z9/vjwgEl68LI+LHHLJvSnwontepHmETk4DbRKHDijJz1ieYMBuVwHHb68L0AyRCpAceunsLeTzvHOX26/tq6PbXyJNEUe5whoS7mWdOUxpu5Q+u2RQUYN19uaXDpqpBDBOaAFU+n48YrmrlFKU+rY6dsS9+Jg0FPKpBWaRONISyWPyjmKdF3uYmhCnaiOW7F3Q4qotM3TSKRHk2cMVTV9YBDzRKw0e51ZXyEt9ZXJjZxI5VAYhBpCiQpumKpGNKpAG35XazZ/13E3fndG0D+Xs/kcQLxvl9ZbXqFhbxBMuQsDuK7EjbzdWXFKpFJ+xIPaHnaYC3mKCVt0lK5Rdl3wm0pny+RXEbBqsOdZWPW6AQopK8pvwn0ki6f x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(366004)(396003)(346002)(136003)(8936002)(38100700002)(66476007)(82960400001)(2906002)(31686004)(41300700001)(122000001)(5660300002)(38070700005)(83380400001)(86362001)(66446008)(2616005)(31696002)(110136005)(54906003)(53546011)(6486002)(8676002)(71200400001)(4326008)(186003)(6512007)(966005)(478600001)(66946007)(91956017)(26005)(64756008)(76116006)(66556008)(6506007)(36756003)(316002)(45980500001)(43740500002)(547064002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UWZCSHY0Uis3bkppK1hSakxkMmM2aURKT21vd0tSaERlaXd3dFZvaWlpa3Ny?= =?utf-8?B?Q3l1U1Z0VGxhUWVrMTRLWitwNmlVMitVaVB2cFh4cU5sMCtoU294YjBXaXY3?= =?utf-8?B?NzNHTkxCa3JWWjFsbGEvSWFLZGFHM2gyeXlJaU1WdWJ4VDR2TXJpRXc1QXNM?= =?utf-8?B?bVJQWEwxcGFvczFmaDFkM1laVmQzaENIYmVSRXdkSmQwUkhnUlBuUHZXWTh2?= =?utf-8?B?Y2xHajBORVBlbGNxcDh0VGxwSmc1bWI5emUyRmlabis2YXVuQ2RRek5qaWtZ?= =?utf-8?B?eGloV0l3VGYwL0YyS2RhM0VyVVZDY3NqNzMrMUtpZGdWcWJySGJGdFVCQUVj?= =?utf-8?B?UkdPOXgrb2NLT2t1MFdYT0FKcjZpd1JZRGdIL1hBWWxiWVJSb2tZdGVjVVJt?= =?utf-8?B?dmdrM1RSaUl4VGNlRENzazBiWFRlZzNVNHFjWTM1cC9iN0pjWk8rTnMvcWJ1?= =?utf-8?B?bFZraDNpVTdYRWFEMi9CMWJuSjVIL2xiQU1QTHVGUzFwTDJRVnJSUVVjOEE2?= =?utf-8?B?aDVpTlZsVk5BQk04TVRyZ2FDS2hXQnU0ZUxxSU1La2o3UVBxcnJVeTlSVFVj?= =?utf-8?B?UHVJVHZpa1VqbHd2ZVk1V3NWK0p3cU44VFJGcldKaittelJ6N0JOeHNxUVF0?= =?utf-8?B?VUJET2twMWkvVDg2eTZ4dit1SElia2U1QmprNGozWGwwUThCbS9CZ0xsSFJr?= =?utf-8?B?VnVGNHVPTFBseko4aUI3SHphazF5R3JxbWViWk5HSGQxR1ZiWjV4SC96NWJu?= =?utf-8?B?MDI2ellzWUo5RVBZYURxUG5JWks1VXFmMGZhaU42OTJOdSsxdm91YTc2bFBl?= =?utf-8?B?YXNUOVR3N0JJQkxoUGlOSmV2YUYvdU5kZURXVFV6b0hwYXp1VGJTOEFkZ0dN?= =?utf-8?B?Vm5wTmpGNXJ5S1lBN3pWZkJ2QUVzUitzeHRQa3VTbzZqRFhkVXBXOWRzQWds?= =?utf-8?B?NTVvdWxiNk1jNXVWUnFUMExUeEhRR0c4LzBQVyt3V1RENXRDR2Qxc2Vxamp5?= =?utf-8?B?a0xvekpPMThVa1ZQdkZDOFIveUpQYW1zMTM3bEZLOUZib3JGR2dFeWxtRGdE?= =?utf-8?B?SEhYUEJUN3lDekxVU0xucUJPMW9mRE9MNnhHczVKbXozbmxtL2ZUVk9pdFNo?= =?utf-8?B?NFp1R1pCNkVjL0RlSzArL2diTHdLU2Vka0xjWFRlNEtpWG5VbWE1MjlLeDE5?= =?utf-8?B?RkNLemd3ejhoV3JjY1R6d2Jwckt4NHJVNXA3QkFXMGZPT2k1V2VpOWFCbGZU?= =?utf-8?B?N1VlM2FRWUR4THBEekdaTE5nb0dmRmZLZ3I2dCtqWVJscnNVSWtmbXlJQy95?= =?utf-8?B?R2ZkbmNscmRCa2ZPV1NNcnpUYk0rT1Y0ZjRLS0J6ZENNWFkwdFdsRXZqckc0?= =?utf-8?B?MEs1K0ZrdW0yNU9QZ1pRYWVIc3owUU9DTFMwcE8wRzBaSUcveDJWNmlNOHBS?= =?utf-8?B?NWR0MExZS0kxKytqRTlOVFNPMVRid1VUM2dsNlN6Q01ET3RNZXNFdTA1TnVl?= =?utf-8?B?MmVlSnhkdTZJSURPQmpzYUNScXpUWnZUc245TlViNFB0MlllZWkxNnFqUGpw?= =?utf-8?B?RElpejdSVG9sL285N0VvR08vaWgyeVBLd21GYUNrM0NFKzhWUWF2Tk1FWU9R?= =?utf-8?B?OVJrTHl0UXh0dTNzc2FmNS9qUk1Ha1gyNUtFVWs0cGRTWGdQZ2cwcFMrN1A2?= =?utf-8?B?eW51cXE5MTV5K3NsRksrOUxwWUYxek1DZUZ1WCtqay92VzNvdWpaVGZpZzM2?= =?utf-8?B?aGdrUWZBblZOcUQxWUhUcFpKbm40V01IREsrS1JlN3JnTEQvQnlFU0FkRzhJ?= =?utf-8?B?MDhyVHJkM1crMjg1V2UrN1pNbGw4Mlc0WTNkSTVEeU1MSThPOFlDTENoMyth?= =?utf-8?B?OGE1TnhUbVgwN2NQMDVha2drUm9LM0I4VnVNYmlGV0F2R2hLcEV2WHI2b2VD?= =?utf-8?B?Y0RkRm9aUHJ0VUk4eXh4VkJ6OWZCbmw4QlRtWEtiKzBURnB1dnhUZDlQRjFL?= =?utf-8?B?WW9La25FeVBYTDZGZ091K1BrRGEvRHFhb2l2cUtFeHMrN2hNL0VkZGlUbW1p?= =?utf-8?B?bW9KSlZFaDNmbHc4N2dEcmtXREt1YUZIcGNuWDV2UWREZjY0anFGVjM1N3hm?= =?utf-8?Q?N8nw7p5i7x9pvqChAFEV4httm?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f1a73cf-34a6-4bcc-0f1d-08da65843aeb X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 10:33:02.4762 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eADH+pCFoLC2OBKfQSfir/VQRgInBGzyqZK8w4nKzdF1e29IUIstXabUp912DcZmZbD8C0N/3hbNbZxP37/XewsbUsTFvxbbJBnXidNCFPc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5916 T24gMTQvMDcvMjAyMiAxMToxMiwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4gKyBDQyB4ODYgbWFp bnRhaW5lcnMNCj4NCj4+IE9uIDE0IEp1bCAyMDIyLCBhdCAxMDo0MCwgTWF0aGlldSBUYXJyYWwg PG1hdGhpZXUudGFycmFsQHByb3Rvbm1haWwuY29tPiB3cm90ZToNCj4+DQo+PiBIaSBMdWNhLA0K Pj4NCj4+PiBIaSBNYXRoaWV1LA0KPj4+DQo+Pj4gWW91IGFyZSBtaXNzaW5nIHdnZXQgaW4geW91 ciBwYWNrYWdlcy4NCj4+IEluZGVlZCwgaW5zdGFsbGluZyB3Z2V0IHNvbHZlZCB0aGUgaXNzdWUg YW5kIEkgd2FzIGFibGUgdG8gZ2VuZXJhdGUNCj4+IGEgZGViaWFuIHBhY2thZ2UuDQo+Pg0KPj4g U3RpbGwsIHdlIGhhdmUgYSBidWlsZCBzeXN0ZW0gdGhhdCBzaWxlbnRseSBkZXBlbmRzIG9uIGdh d2sgYW5kIHdnZXQsIGFuZCB0aGVyZSBpcyBubyBjaGVjayBpbiB0aGUgY29uZmlndXJlIHNjcmlw dCB0byBlbnN1cmUgdGhlc2UgdG9vbHMgYXJlIGluc3RhbGxlZC4NCj4+DQo+PiBBbmQgdGhlIGVy cm9ycyBpbiB0aGUgYnVpbGQgc3lzdGVtIGFyZSBxdWl0ZSBvYnNjdXJlLCBpdCdzIGhhcmQgdG8g dW5kZXJzdGFuZCB0aGF0IHlvdSB3ZXJlIG1pc3NpbmcgZ2F3ayBvciB3Z2V0IGluIHRoZSBmaXJz dCBwbGFjZS4NCj4+DQo+PiBXaGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGlzID8NCj4gSGkgTWF0 aGlldSwNCj4NCj4gSeKAmXZlIENDIHRoZSB4ODYgbWFpbnRhaW5lciwgcHJvYmFibHkgdGhleSBr bm93IGJldHRlciB0aGUgcmVhc29ucy4NCg0KVGhlc2UgYXJlIHR3byBkaWZmZXJlbnQgcHJvYmxl bXMuDQoNClRoZSBjb25maWd1cmUgc2NyaXB0IGRvZXMgY2hlY2sgZm9yIFdHRVQgKG9yIG1vcmUg Z2VuZXJhbGx5IEZFVENIRVIpIGFuZA0Kd2lsbCBvYmplY3QgaWYgc29tZXRoaW5nIGlzIG5vdCBw cmVzZW50LsKgIFRoaXMgaXMgb25seSByZWxldmFudCBmb3INCnRvb2xzLyB3aGljaCB5b3Ugc2hv dWxkIGhhdmUgYmVlbiBmb3JjZWQgdG8gcnVuIGNvbmZpZ3VyZSBmb3IgYW55d2F5LCBzbw0KSSdt IHJlYWxseSBub3Qgc3VyZSB3aGF0IHdlbnQgb24gdGhlcmUuDQoNCkZvciB2YWxpZC1hZGRycyB2 cyBhbGwtYWRkcnMsIHRoYXQncyBjb21lIHVwIG9uIHhlbi1kZXZlbCBiZWZvcmUuwqAgSQ0KdGhp bmsgdGhlIGdlbmVyYWwgY29uc2Vuc3VzIGlzIHRoYXQgd2UgZG9uJ3Qgd2FudCB0byBzaWxlbnRs eSBkZXBlbmQgb24NCmdhd2suDQoNCihXZSdyZSB0cnlpbmcgc29tZSBuZXcgcHJvamVjdCBtYW5h Z2VtZW50IHRvb2xzLikgQ2FuIHlvdSB0cnkgb3BlbmluZyBhDQpidWcgaGVyZTogaHR0cHM6Ly9n aXRsYWIuY29tL3hlbi1wcm9qZWN0L3hlbi8tL2lzc3VlcyBhYm91dCB0aGUNCmNoZWNrLWVuZGJy LnNoIGlzc3VlPw0KDQpUaGlzIG91Z2h0IHRvIGJlIGEgNC4xNyByZWxlYXNlIGJsb2NrZXIgc2Vl aW5nIGFzIGl0cyBhIHJlZ3Jlc3Npb24gZnJvbQ0KNC4xNi7CoCAoQ0MnaW5nIEhlbnJ5IGFzIHJl bGVhc2UgbWFuYWdlci4pDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:36:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:36:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367379.598472 (Exim 4.92) (envelope-from ) id 1oBwCl-0000FO-AX; Thu, 14 Jul 2022 10:36:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367379.598472; Thu, 14 Jul 2022 10:36:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwCl-0000E2-3W; Thu, 14 Jul 2022 10:36:23 +0000 Received: by outflank-mailman (input) for mailman id 367379; Thu, 14 Jul 2022 10:36:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwCk-00008g-29 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:36:22 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60064.outbound.protection.outlook.com [40.107.6.64]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc701c64-0360-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:36:20 +0200 (CEST) Received: from AS9PR06CA0300.eurprd06.prod.outlook.com (2603:10a6:20b:45a::7) by AM5PR0801MB2017.eurprd08.prod.outlook.com (2603:10a6:203:42::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 10:36:18 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::66) by AS9PR06CA0300.outlook.office365.com (2603:10a6:20b:45a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17 via Frontend Transport; Thu, 14 Jul 2022 10:36:18 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 10:36:17 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Thu, 14 Jul 2022 10:36:17 +0000 Received: from 7fc474404b7c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2CD300AF-7B4B-46A9-B484-13120B1E5B26.1; Thu, 14 Jul 2022 10:36:10 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7fc474404b7c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 10:36:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM7PR08MB5416.eurprd08.prod.outlook.com (2603:10a6:20b:10e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 10:36:09 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:36:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc701c64-0360-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AvuX/3PBWNdtxyBG7wfIWShpjfcvlKPwa2v7bky3vOxCf7wx3iU4TlNlGjGPsgjSyeeNbP7cnaIi7u6lIwmxy0nDYtY844TUA7sLFk04kZLIMGwgIbTS6UeA40VmylGkf7/jZLaA4Kwp/8dd4IUm+12bxRMOEGFz2OzcFmIN7LFoB5jROWN34AWluqkeCNYy/CC+xjQWntegKy79Wx5jaO+1oTtl8iNTqKcY8VWvq1szHZufC9H3Yhw82IDbeifhRS9LUyFwXaZ6hF6k6DqHbIZ2IfsdJ9RAuiUPpexFNYZ08jfIXa7i+09ABirztOmpAN8IYDWoo1PwQ+EreN/dVQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mL7SvvIq27r2hFrdA/HcUdbhgmP+f64r+efNEYmLPbU=; b=P+mb0I790GqYkBGU4mUyuSNmGOg5WDeOB5H2Lrp367tEI8sL9XqaRXnxLHtLkeE2j1CATAkGgH2pToex/1v4qtrnMIUD12Tad2O53cOAzu1fByLqC9+TxnKSoxn04RGLW2USycxah1TM1rpDqD4UzM4ngwWbgBZlRgyz6O550efMoEa2FWaPZzCnGVQ/gj7TEKjgp7wnylQWhLdlV4F3EweaEmlP/1YmPZNr7s4A+lRFU79d1j+On6SjMUYQQR7c8dS2F90YDtJsL9ZU/26vYIEbhQrHpBU95eJDWeWKnmFlkdr387EX2/CAWWyfSu5FuuTSQQbF3zlhqaiKa11Fxw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mL7SvvIq27r2hFrdA/HcUdbhgmP+f64r+efNEYmLPbU=; b=iaTLo1U1ldKfCSKri06NvPtsbOVyziANJIq5CGfYNHfMrUeosUyMfl+n/5erLdTrdJmxWPNzDWC+GcoHBVSy6EK3HFi/iRNzaLbd+VB2ax1yo9UaF2TpodcUwdiKl3W/Vxi9Z1BG8uKVxT5+2qKjYRZ6dOW7nSoaNWZb4vsfAqo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e7a501c8949880e4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HWdwE+Ns91WI6o+XSF7FmInMDFiRuHiEAXyUMpKwiVYetu1wCkLE2M0IZmM87WuROK0VRPTQsCwPK+rNaxu1+eqWf1v5ygnkF04WdTdryQwiTX7IoWO1Rk0UvMVLfYCn/WtsK8gAriyJsIj+OtH5P+r4aQiYLr9qAC712tjjlUL2RJADEnYs/cyGGVcuWCmEWSZxwEqmy4qfX/v9de3NtHWVmPchye/IpEA2kbUeeD3fsGQOlgxYhVBq6FFPHXbX29eG5kuKoYcDpQJrahaFmR43GZf7j6YeIiWGi18Cb2C3zzebIBrydIblsoj8f7T80nW/w+ghGU7HUymhRxbOAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mL7SvvIq27r2hFrdA/HcUdbhgmP+f64r+efNEYmLPbU=; b=LUPsHu/W+3cXYIAx1453/AJr+NuGA9selyNv/JfWCTmD7dQW+CvWJ9XJ9cOfSN+ZXooeW3Z5sQWeIWHse1aylUTILvqphgtbfHUqfXuI3sBaZHZYNrkhVTyJsMiKZkEwRHS3hSocPbf8NX7TX7UXTlnMJcJFoOF0Ta68JcBqE8JSRVMTt6TEmaDA5LN5/NNPpE7ZJJvXa3QOxM1QGAugcNMpLEzHvEOm2EeqxKP/Evumh/ErL4eftCJotRRMGP2How1jiFczQBHXS1XhfWPF9Rqj5Ga9sIwEGOqlwOHaF3cst06Q5aqMMPunRa37/rkGs+cYgZjRtujtgn2SU18qKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mL7SvvIq27r2hFrdA/HcUdbhgmP+f64r+efNEYmLPbU=; b=iaTLo1U1ldKfCSKri06NvPtsbOVyziANJIq5CGfYNHfMrUeosUyMfl+n/5erLdTrdJmxWPNzDWC+GcoHBVSy6EK3HFi/iRNzaLbd+VB2ax1yo9UaF2TpodcUwdiKl3W/Vxi9Z1BG8uKVxT5+2qKjYRZ6dOW7nSoaNWZb4vsfAqo= From: Bertrand Marquis To: Andrew Cooper CC: Luca Fancellu , Mathieu Tarral , Xen-users , Jan Beulich , Roger Pau Monne , xen-devel , Henry Wang Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Topic: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Index: AQHYlsicqOth5aGebEinuouQN8xr5618caEAgAAKCYCAAPuhAIAAJpSAgAAJHQCAAAWjAIAAAN0A Date: Thu, 14 Jul 2022 10:36:09 +0000 Message-ID: References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88e1132f-312d-40f2-fa35-08da6584af7e x-ms-traffictypediagnostic: AM7PR08MB5416:EE_|VE1EUR03FT023:EE_|AM5PR0801MB2017:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qCcDVTPPobettaFiIl7dSlLAJRnuL0r36WQKUrOi0rUDw+uo+OuwYGTm+NdFRPC8FzA5bmH7FL0IwnbeJFHy0+W3UhwLCzZGTEsjQ9/DSbjgCsyrXEPMXlSBGfZIFjSCN/3YFya8hRMY2Xm/j0hIjI5Bo+sI0DTp1ieAQ/fPkQVG6pnywcnOSOwjtSe3Bm3mtO5h1XCztUn9k0WvjG17teaFQY9TkwYZMv/fYX+V58z9fm0+eaqGVbbNW86MGOhZvfNqEROKLt2gYgNnmgFQmbjNWxcK0zV9bqYSYwqjqUnE9TUVAM8KYptAAyJF7txhPsZLrKnVg7qiPc/X632033yLgcK0dW3i9UYui1I5PmmzySoP4ddAQ6HZU3dKqb9mCrt4PARx7G0Tk3hRr0/f9nXUa9Bfa8vm7/2FwvZq9J53QUi0+SfGNB2cOmkVBQKSdZQfzXIiA1WfkUWN4sJyksSuuYmnKCIhmQkHmAXsVuT7DFbCwHkunxdUwj6CWW5Ji5E5FPVtgFWXjaYI6TJnHUdjrtFL7sMbZtbVLMjwJQqSuHFLO3pmVGV8ja6wNFpuauGVdMGg30ccWJU5DvPb6AIdW9nKB/YQ0WUl+eCgSn5k2tNNW/l1nh9R/shTh+0BUEVIbq4BBxmM1DIlHmlsbUgtpczYokqB982W4K5WqndotC0VMPBv02DsKpyuHmdOmciCpbGLz/Y3wyHl2xNPd31Aw2iok3LRDVYp9JsOryQ1KqgVQ9IC0+stT0fEtgYiguVJFMeXWjd29oylEqMMbgpwwA00/k4s/x9q9mzUO7FLR8YKEJ+P5VgFdaYUwHisE7i9SA0HWqexA94eYBFyYc55+ZU/vCRqv5RnXVQP0e7oB+2DWYFbU2fkuGwcIF4bsbUvmrEPSdkqGWoFjoxOWw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(366004)(346002)(6512007)(83380400001)(122000001)(41300700001)(8936002)(5660300002)(478600001)(26005)(53546011)(6506007)(38070700005)(71200400001)(966005)(38100700002)(91956017)(66946007)(76116006)(186003)(316002)(66556008)(54906003)(6916009)(66446008)(2616005)(66476007)(6486002)(64756008)(2906002)(8676002)(33656002)(86362001)(36756003)(4326008)(45980500001)(547064002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9C334E3B4912E149B865A91D8FDA7686@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR08MB5416 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 2a6b03d7-e26c-4e81-9c04-08da6584aa6c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7y78bndrZRaNC1mCE4WMy9oRMYHTXT7mXG+LOaDg3TMZ7p6QyzrLPh4YANnVsfYmtssnWmwR26WjrT80Z2VWUkUhcz4TBH60XFE0hCCf1K/+MlsNtdrNtFuLcfmJvHe7eHAjsjRl98RmBuQ4EADt96Mh+wsMtw/BfKSfWhoa/KOHunEiBXupIPCaA1Jd6EDT/MdGXnixrOU2PAw6evdsUvrsZx4O2kUAjAVPDCKJdsNGG2i8ok1XnPmlkta/RyP4PPqyqM3aOkXby/YJgzbgVXzDWlJ5PYQwHYaRSxsBjIklGLFVTimbwjmp6C7UofSUsbH95sMSqUKmLPMIIDPo5lLPrjzS5AIVmEm2J5OtJBcyxe78vEwOc2hVuAgr3ilA8XWLFrZncP7dvDfUVhoO8gzNXm5sAkvV2Tf5tBmZjxnJctp/vHvMggEmMbk7o7Oc8xVpNsmy0L/3IVJ/8luPOB3tUgY2/F7kYMn3JW+nuUHEyPUZ3YTe4+HWnTkWm434JMaKPNp3+4tVqZ/k+DcYbwwDhM4jPZ6PQkyQyagGZhHSEz3tE+9kENb7vu3B/CYWDvKzLFxRfQB31Q2gOMAA5b3cwVCl9W2ghzLSBHRvICAZcuilYXZyo85g1IuSL6iTPEJbnmks1CIOv4C3fgYnf9vG+q182QNVbWkhoM5gY9QouJ+IJG8xV05tayRfO1Mnv2rlknzr3T41mhT7+QHc2gU5GaEHvWEk4+F/C2z05MZZQHQcRyq/Z3wpKMLQVwYsaMIHl/bzTbBLq8p5n8QKATyxpfV48vWdwMBmpKUo36qq28/3+XfFvujpL2fSQrj2VAEouKVTg5VlDgjuQR+7k/Ic0nVw4Qb+vATmVY3y8zqOixnbbKp01RWh4tE0Jfj/ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(376002)(136003)(39860400002)(46966006)(36840700001)(40470700004)(82740400003)(83380400001)(8676002)(2616005)(81166007)(47076005)(336012)(2906002)(356005)(40480700001)(33656002)(4326008)(6862004)(8936002)(186003)(26005)(41300700001)(82310400005)(5660300002)(53546011)(6512007)(6486002)(478600001)(70586007)(6506007)(86362001)(54906003)(70206006)(36860700001)(316002)(36756003)(40460700003)(450100002)(966005)(547064002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:36:17.9306 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88e1132f-312d-40f2-fa35-08da6584af7e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB2017 SGkgQW5keSwNCg0KPiBPbiAxNCBKdWwgMjAyMiwgYXQgMTE6MzMsIEFuZHJldyBDb29wZXIgPEFu ZHJldy5Db29wZXIzQGNpdHJpeC5jb20+IHdyb3RlOg0KPiANCj4gT24gMTQvMDcvMjAyMiAxMTox MiwgTHVjYSBGYW5jZWxsdSB3cm90ZToNCj4+ICsgQ0MgeDg2IG1haW50YWluZXJzDQo+PiANCj4+ PiBPbiAxNCBKdWwgMjAyMiwgYXQgMTA6NDAsIE1hdGhpZXUgVGFycmFsIDxtYXRoaWV1LnRhcnJh bEBwcm90b25tYWlsLmNvbT4gd3JvdGU6DQo+Pj4gDQo+Pj4gSGkgTHVjYSwNCj4+PiANCj4+Pj4g SGkgTWF0aGlldSwNCj4+Pj4gDQo+Pj4+IFlvdSBhcmUgbWlzc2luZyB3Z2V0IGluIHlvdXIgcGFj a2FnZXMuDQo+Pj4gSW5kZWVkLCBpbnN0YWxsaW5nIHdnZXQgc29sdmVkIHRoZSBpc3N1ZSBhbmQg SSB3YXMgYWJsZSB0byBnZW5lcmF0ZQ0KPj4+IGEgZGViaWFuIHBhY2thZ2UuDQo+Pj4gDQo+Pj4g U3RpbGwsIHdlIGhhdmUgYSBidWlsZCBzeXN0ZW0gdGhhdCBzaWxlbnRseSBkZXBlbmRzIG9uIGdh d2sgYW5kIHdnZXQsIGFuZCB0aGVyZSBpcyBubyBjaGVjayBpbiB0aGUgY29uZmlndXJlIHNjcmlw dCB0byBlbnN1cmUgdGhlc2UgdG9vbHMgYXJlIGluc3RhbGxlZC4NCj4+PiANCj4+PiBBbmQgdGhl IGVycm9ycyBpbiB0aGUgYnVpbGQgc3lzdGVtIGFyZSBxdWl0ZSBvYnNjdXJlLCBpdCdzIGhhcmQg dG8gdW5kZXJzdGFuZCB0aGF0IHlvdSB3ZXJlIG1pc3NpbmcgZ2F3ayBvciB3Z2V0IGluIHRoZSBm aXJzdCBwbGFjZS4NCj4+PiANCj4+PiBXaGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGlzID8NCj4+ IEhpIE1hdGhpZXUsDQo+PiANCj4+IEnigJl2ZSBDQyB0aGUgeDg2IG1haW50YWluZXIsIHByb2Jh Ymx5IHRoZXkga25vdyBiZXR0ZXIgdGhlIHJlYXNvbnMuDQo+IA0KPiBUaGVzZSBhcmUgdHdvIGRp ZmZlcmVudCBwcm9ibGVtcy4NCj4gDQo+IFRoZSBjb25maWd1cmUgc2NyaXB0IGRvZXMgY2hlY2sg Zm9yIFdHRVQgKG9yIG1vcmUgZ2VuZXJhbGx5IEZFVENIRVIpIGFuZA0KPiB3aWxsIG9iamVjdCBp ZiBzb21ldGhpbmcgaXMgbm90IHByZXNlbnQuICBUaGlzIGlzIG9ubHkgcmVsZXZhbnQgZm9yDQo+ IHRvb2xzLyB3aGljaCB5b3Ugc2hvdWxkIGhhdmUgYmVlbiBmb3JjZWQgdG8gcnVuIGNvbmZpZ3Vy ZSBmb3IgYW55d2F5LCBzbw0KPiBJJ20gcmVhbGx5IG5vdCBzdXJlIHdoYXQgd2VudCBvbiB0aGVy ZS4NCj4gDQo+IEZvciB2YWxpZC1hZGRycyB2cyBhbGwtYWRkcnMsIHRoYXQncyBjb21lIHVwIG9u IHhlbi1kZXZlbCBiZWZvcmUuICBJDQo+IHRoaW5rIHRoZSBnZW5lcmFsIGNvbnNlbnN1cyBpcyB0 aGF0IHdlIGRvbid0IHdhbnQgdG8gc2lsZW50bHkgZGVwZW5kIG9uDQo+IGdhd2suDQo+IA0KPiAo V2UncmUgdHJ5aW5nIHNvbWUgbmV3IHByb2plY3QgbWFuYWdlbWVudCB0b29scy4pIENhbiB5b3Ug dHJ5IG9wZW5pbmcgYQ0KPiBidWcgaGVyZTogaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0 L3hlbi8tL2lzc3VlcyBhYm91dCB0aGUNCj4gY2hlY2stZW5kYnIuc2ggaXNzdWU/DQoNCkkgd2ls bCBkbyB0aGF0IGZvciB5b3UgTHVjYSBhcyB5b3UgY2FuIG9ubHkgZG8gaXQgaWYgeW91IGFyZSBh IHByb2plY3QgbWVtYmVyIHJpZ2h0IG5vdy4NCg0KPiANCj4gVGhpcyBvdWdodCB0byBiZSBhIDQu MTcgcmVsZWFzZSBibG9ja2VyIHNlZWluZyBhcyBpdHMgYSByZWdyZXNzaW9uIGZyb20NCj4gNC4x Ni4gIChDQydpbmcgSGVucnkgYXMgcmVsZWFzZSBtYW5hZ2VyLikNCg0KQWNrDQoNCkJlcnRyYW5k DQoNCj4gDQo+IH5BbmRyZXcNCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:39:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:39:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367415.598493 (Exim 4.92) (envelope-from ) id 1oBwFT-00026U-O1; Thu, 14 Jul 2022 10:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367415.598493; Thu, 14 Jul 2022 10:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwFT-00026N-LF; Thu, 14 Jul 2022 10:39:11 +0000 Received: by outflank-mailman (input) for mailman id 367415; Thu, 14 Jul 2022 10:39:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwFS-000252-9p for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:39:10 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3155f03c-0361-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:39:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB6591.eurprd04.prod.outlook.com (2603:10a6:803:123::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 10:39:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:39:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3155f03c-0361-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OGqOzbNlD+CvV1UHGkmqegQWzu3doVpnJPU1jtvRdK3Uu0In+hQwprF8Q8X4YcfSqm1AJoXmz6qHqbMWjWFg+z4xb2jIbKYjFpYeCgTyamntk/3MmsRyp7EqicFNuKYh32nN0nd9NNO/pNtvIaat+weia15xFyIhbV+czi4W8VdxGuBq/j8bUBqWYXfKGoHJeYmWrpoHI6zpZzkGIqfTfr2O5oE4DBhNUmEAcbKvdyv1ZpGD+y6e1XasrLHfBvdJms1dM7pdcNhu+rvxeG+rchtHX9ODfOjLBizXgSPjb0Ox5brmfqCIVaJt7joC+1Spw9sVBpbmgDOtzDjYB08PlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KJcJljgLHXd3rWvovq7m0uFmd//a+EvxQqGvBRRbhUE=; b=C5pHMNJspS6KX7zuilx1WRt9fnHXepyAmcwRoc0TlEtEkNNSkOf0QIfSxKp3NHwNpomURxOghWOipW2LM1zXqAxGJjNseZknYnKgSU0M2X3LrVnf9E6rMDc6mskwRKRxx+LpjVl6GDfPnd0GmdgpYl6x1A1ORq33oHPupzg2GiRG+giU3bgk/nj8mNkGCURGzAGPh6jjNm7psQaPEv2em59YN0maBau0wW5nHHeBHhTo47CVs5KT8TQmhaq1Qd1/n2CeSjLqSHskpYr1jf9qauoSQwLu4vDbKchPSxeqz9G1DTZ+LewLackeXS0d+kqWfqAtrabHfJqD7V9DdtK6NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KJcJljgLHXd3rWvovq7m0uFmd//a+EvxQqGvBRRbhUE=; b=PND3StzMRCslz9z3nD6j2IO5hksaBBp/eW6ppeszKYBVGdgwh8JMe4kBorlAo9ITt62KOcXtGGkPajeSt4ogWL1nY9JwO/AhOE8ScKX3uWzV89nfuwSmXkI3uvI4qVasAKaf92SyvK9RPPRRYVV42pYYdfMibJ669zO+WtCgno8wDNK0r7I9RcT14GH4/23ygDgKjhM7x0etRFYBeXU2YKI4MUK7umr36UkK3GwpZ7XOlcz2q2Yrpg7dIbqptFtFtJBdCvfG9WpNbTe0xRz+cCh6JzpIIiZGWUpO5b/MkcT+CzDvJ/nH+9/MPMjJ9YvAp3bYYH/5Y7KWJhMh3cBPUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <2fad8072-e5f1-2302-f01d-82f744606d9b@suse.com> Date: Thu, 14 Jul 2022 12:39:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Content-Language: en-US To: Andrew Cooper Cc: Xen-users , Roger Pau Monne , xen-devel , Henry Wang , Luca Fancellu , Mathieu Tarral References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 17e7a3d4-50ca-44dd-ffee-08da658514be X-MS-TrafficTypeDiagnostic: VE1PR04MB6591:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1vOY7d+SG0T+jvSVkKrE70SHq25YXID5ywcOQ+CxRrHQpuY9YbuyUSQYgjjrKA005C689OVFFVf1UL0J8VYb/Uy/wxu+SnNxVnIIBVtI9oJ5DwjQ8H4W6ayHRF7EYlHXohadq5oWmiqy1EBQtlRiW/mOaL7SeUykyWdgvcMFbehwmc/8yexc8XCjiVNwgEDvG1ERZgUBNL2ysbJ7YyJFw7vkNxCgZLs8lkQVwzafjEWx01L2YsLB701OakTqx8QCuSmDjAscefwgra5NzwbkiaIHpzK3p+Bvn1ntOq2b31jWqK9O+hfbdDOnuGptmudj0YLvRfkT7G81+/U9Fh6tQDecnGi9PKBciRQ+JRNqtpx6CGYaK356Y1MVxAfxEhFCey61KxWr9MCM+zPMcM4tv2ZorspNst9RaWh7IzISfV34gy8BWdgzdezSC5byOinQskbUMBy/jlG/fe5leo70biPlVQLlEaI1FMQb+jigulw77DDjRfl359vN3nfFaW4verg9gSro3N9bWIImH0vwv1a0FSRc4C7VrkgsRZsK2BD3y9514WcFQDTk1kGJhNL7OUYJUA2f+eglDn+M15S9F16f2atBtRylIJ+jAVQiVPQW2HRqr7EbBdy4E08L+rD7rinh86xCX+ujZB/1oHYIos15hDwxmNneU5asPMGhSwNcyBc2np+RM+e2+M5ZDOwrAG8n3/M36fW2vhyZuuMlB5BQw0IADpmHilak23pnQG1uFVvPl7AHJsLr61cQUJrjqqzXIf6YV/hO4QoiFYn7tzKrfSc/3AtLXmwoouA5rihCGtZMmz3F3gr/iTikIWMWMt/OVrMne0oYLe0c3+BMJdpJYWCaFHDWe0ISUlxCiYupjwUFWcvaDfFqF8e8wVoAYxKiL9hQu5/cYiqNdsWy2Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(376002)(136003)(346002)(2906002)(5660300002)(53546011)(8936002)(83380400001)(86362001)(31696002)(36756003)(6486002)(6506007)(38100700002)(966005)(478600001)(66556008)(66946007)(8676002)(316002)(6916009)(186003)(54906003)(2616005)(6512007)(41300700001)(4326008)(26005)(31686004)(66476007)(547064002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1lpVTgzQXRKTVExbGo1S2dhd2w4TjI5UXkxVWQzN3hPMGlteEpFMXpXc3V2?= =?utf-8?B?bEFya0ZjRURzU0M0ZU5wK1Q3NC9EL3dDcVZsNTN6RnNkeUdvQjFHOHp6VmZs?= =?utf-8?B?eGtHMGRDR0dWanpQNnRUWnFZOU8zTVg2RmxwSHFjV2wwZWJXcmZBS1gra1BG?= =?utf-8?B?cy9ncXY1VjBBMjZrS2JJd1dqNVEwMFU5T2p5RlhBWkZEempqZ256Q1VDVkhz?= =?utf-8?B?dGlkTE1GTlpHMjJtazBpRm1FbXczSVNkdU02VnlPcGtDVGZRd0ZjZmsxUFBY?= =?utf-8?B?UGpldDNnMXd1YVkrS0FnK0l0VVlTbUwzUGJTRDBWdUtNMVkzdU9NL21CanNj?= =?utf-8?B?RVpMWlc5NVFVU0s0WS9LZjdxQ0hOWElpMEc4Zy9FVW4vZjJISVBqN21CUTRC?= =?utf-8?B?MHlEYjF5dEJIVm05d1RjZzhTaGVPNjJKRGNlNkcxOVc4dnllKzlKVSthbmFi?= =?utf-8?B?V3dESFU0V3k2OGoxbGpiRWdJVHVyU0NHdTVXRW9KQndBTmFUdkw2b1JDY0s5?= =?utf-8?B?dzRGMWtka2RtKzVQdUlwL3UxanovM2htU2xRVXhiT3l1SHZIbWNjeE1mS0Nh?= =?utf-8?B?WGxsTnRMaEpLY3l6RUo2S3B5dWp3ejJsTkV1ZTFHZEp0anJzOE1Dc0ZrVWR5?= =?utf-8?B?RjNWZTM4dzBTQnpiQjc5aG1ac2g0SmF4MUJHQmNxNjlMazkwem8rZk0yUEtO?= =?utf-8?B?ajdSUlgyNDlvczcrUFVkZnVLSEFHU1F3Y1gxaUxSbmVjSk13OERhMGZHTTdV?= =?utf-8?B?dDRoTGJ0ajBFUnVMMThYT1o2Z0NTQ0hjVXdTUkU1Z0xlZXJGU3hzZDhtT2hk?= =?utf-8?B?UFhMOVVmVytvVDkrdlB1ek5MVTlQMXo5TzZGSXJXTkgzcllCalJGem04Y1g2?= =?utf-8?B?QS9GTFFGUUFrd2xQTVlQSVIrdEF4bXoxTGwyUHByK1BnNEhjaFBGZGdJYVM2?= =?utf-8?B?ODhhMEdna2VWNlpCWkxZcWYzYkNja1N0NXBzd0tNNGw4dEl3QkJPTWxVSjZ3?= =?utf-8?B?RENycWtFVnlWaVJ2QTQ3UWpqbGEyOCtOOVNLSDByRXNLazFQVzJhMkZUVFJx?= =?utf-8?B?VERrK1l4UjhrTXdUcnArNjRiY2VrRVZ0VHpJWTFZOWJ5b0VnMkdHL3FuV1dy?= =?utf-8?B?b0JKSGpZNk1XU3N1emsyVWZNeU1Na3ZSRWNlbkFuRVozbzNwVFJOWFFTV1N2?= =?utf-8?B?aHZGZWlib01aUDRNK2R2amRiRzV3VnFmdDBFcEVwWWRJbGNXTmdsMzJxWC9U?= =?utf-8?B?RlA0bFpHbGVBVXRYekkyM2Q4V1ZwakxlTWp0eGVCYkJjWjZtMGMva21aOVNC?= =?utf-8?B?M1ljL2xMUy9NUXRaeEFzdURUbk5MNWhZVHJhMzljS29zaGMrSjBIcW5kWFFa?= =?utf-8?B?UGh5MjN0Z0FKQklGS2Z6S0o1RnlVRVBCNHY2ek16M1F4b2EzRDBnOGVEMEwr?= =?utf-8?B?VmtVcmtRZmRUUXJoTndHK1VLRzRra3RJL1FoRTZlWHgxRlFvbXJnakpLUFdk?= =?utf-8?B?dGkzaS81TDlkSGtDZS9NbHhtWFFkbWJWNDdTcXNJd3g2NW1MaVZwSWEzN3Fh?= =?utf-8?B?a08wWkVpd3h0bVRDTWxscTFKTlBTNVFSVm8vRldWS2FQM2ZlMHdDOElaZ0xG?= =?utf-8?B?bHNVWHNlRXpNaFphN2owbm1iZDhDNVNXUmViVEFVTDNWOURWTUthejNwTEhG?= =?utf-8?B?VmM2dkZSckdLckNyNXVIL25uakdXWDFUSGNGNEFTK2o4ODN6L0dYVnA5bG9P?= =?utf-8?B?WEJKRHR5c3NhZGs4bk85RlFpMHF2TTlGNE9KTnpxWmtoaEVjTUdQMTB4YXlF?= =?utf-8?B?anpoN3Z3TDFBRVdqU05ZdHBwQ21rY0NrdVlHSkIxbWcyUmxqeE1hUnNPbTNF?= =?utf-8?B?a1ZHbW9ySFFjMzYvam15WWlsSnU5T2RDWUtZMGpHUXZjdFk3aVZtdWFwcUlS?= =?utf-8?B?WVJ0dHNDeU9xZlBzS1hpekcwbmtmNmpveE9HK2IyQ0Z3ZDl4NDlsR05BTlo2?= =?utf-8?B?MWdpWFNFY3F6bFU3UWNaSjdGZGtpMXhhMGEvTXZleEtITEFQWkJ5SWorUTdC?= =?utf-8?B?ZGxSSEJnZ09vdWFWREFBL3pld0wrVEFXclNQeW0yNi94cXp3V0IzS3Z5QzFI?= =?utf-8?Q?fV9AsLM4De+XGTLarBxpCeuhT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17e7a3d4-50ca-44dd-ffee-08da658514be X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:39:08.0870 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7lQpCByB6phA7Gm9gefpWplUWlgRfMGBl0NMjojtPk2VPUiY9pta8o+/bdPp4rWwoMSR9DGGbupa01TF5G8few== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6591 On 14.07.2022 12:33, Andrew Cooper wrote: > On 14/07/2022 11:12, Luca Fancellu wrote: >> + CC x86 maintainers >> >>> On 14 Jul 2022, at 10:40, Mathieu Tarral wrote: >>> >>> Hi Luca, >>> >>>> Hi Mathieu, >>>> >>>> You are missing wget in your packages. >>> Indeed, installing wget solved the issue and I was able to generate >>> a debian package. >>> >>> Still, we have a build system that silently depends on gawk and wget, and there is no check in the configure script to ensure these tools are installed. >>> >>> And the errors in the build system are quite obscure, it's hard to understand that you were missing gawk or wget in the first place. >>> >>> What do you think about this ? >> Hi Mathieu, >> >> I’ve CC the x86 maintainer, probably they know better the reasons. > > These are two different problems. > > The configure script does check for WGET (or more generally FETCHER) and > will object if something is not present.  This is only relevant for > tools/ which you should have been forced to run configure for anyway, so > I'm really not sure what went on there. > > For valid-addrs vs all-addrs, that's come up on xen-devel before.  I > think the general consensus is that we don't want to silently depend on > gawk. > > (We're trying some new project management tools.) Can you try opening a > bug here: https://gitlab.com/xen-project/xen/-/issues about the > check-endbr.sh issue? > > This ought to be a 4.17 release blocker seeing as its a regression from > 4.16.  (CC'ing Henry as release manager.) Except that 4.16 and older then already have regressed as well, due to the backports they've received. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:44:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:44:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367463.598522 (Exim 4.92) (envelope-from ) id 1oBwKy-0004jn-1A; Thu, 14 Jul 2022 10:44:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367463.598522; Thu, 14 Jul 2022 10:44:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwKx-0004jg-UX; Thu, 14 Jul 2022 10:44:51 +0000 Received: by outflank-mailman (input) for mailman id 367463; Thu, 14 Jul 2022 10:44:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwKw-0004jV-Iu for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:44:50 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2071.outbound.protection.outlook.com [40.107.104.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbe344e5-0361-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:44:49 +0200 (CEST) Received: from DB8P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::27) by DB6PR08MB2902.eurprd08.prod.outlook.com (2603:10a6:6:1b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 10:44:36 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:130:cafe::41) by DB8P191CA0017.outlook.office365.com (2603:10a6:10:130::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 14 Jul 2022 10:44:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 10:44:35 +0000 Received: ("Tessian outbound 190453a6d737:v122"); Thu, 14 Jul 2022 10:44:35 +0000 Received: from 04af41098621.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 717067F9-525F-4241-A0F2-3D3619AB5773.1; Thu, 14 Jul 2022 10:42:57 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 04af41098621.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 10:42:57 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB3975.eurprd08.prod.outlook.com (2603:10a6:20b:a7::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 10:42:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:42:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbe344e5-0361-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CgjWanMHvepepiBmibWibEnzK+kKCKLoV78MlGc6Jr9Be+g5y/Zjh8SwQ48tNKo6UxSmjaFVvfxjEN/CbG11elt7K2Fjyzy0TMroe23zz/nQLVN2Ml2bLt57CtWeigmx/ZUKcAID0en6/Nj0bcqrtf3htZVQCpNaZ7Pepe5xXJpdGbSb4DQc7U5640S+I1Y4wV72Vl3jOQvAQd/rFUzFjhaBEiXMc1VtNblc5gNSaR8BEIFwxIlx0i/nFFqEqI+36oi6tkeneyLtxTMTDs9O2miYRdDRhWS+E/Kke2081Z5KdWWk9QnDJN+zvt1FiF89LPGevqPZQGsG7+q3mcCuoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wwDkF22i7Fj5EvOLNGirO00OQNWiRNo5aPZ9fHSBrJU=; b=nPdouDdHogT1nE9TiY6Rh9X3SJ7pZiZaz1hr04LKEVZDKTC+9FPKS0mMJ+cz1GC19tPVuGdPzW7s9ui34PL0p9Y8bT0VelNX1Re0b2Vb5xN/Nyir+PjHqikWx/QdjfiZHb0xDbyaYqLNDSeLG3eH+kstpcf8R/JrDeMA8sS8I116jpaWALBPyPofJlkE0Ccc5IK814tEilPDgfgN755Z5GhZwgOF1Pt6DmRVpmZ23IOhrvCCDvYO+s+zDmvwWqU1H5nhS40GrZM1v1Gx4cTtYxSUcda13HUdjgqUfbR7DjmklO7QUplhY59GUUGbe76BDZ5VOFGoZFE4uhh5ura1qQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwDkF22i7Fj5EvOLNGirO00OQNWiRNo5aPZ9fHSBrJU=; b=v575aBanFrz/wU8A0LY4UQDQkhKDgWk6jLOM7qI4zNWxFU5uqTXYmEhK1sedFD940Y+H9uURPR6mzrZt+yjeWgWE8xdVr55SHM6/e0yX3S5942rzoQ6lw5TeAV1viJpEHzJtvlAEAj5k4l9zmg3QzPvy5JB9VhhaY3YF1XB3diw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2d22269e404014df X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPmT2iD9EtTeewXNg9sYMynZ83EO7p/1httePV+L4J4SsE+xC3/1Qz1ouFOrOijZZb9eGYXHvN9NVCfZs8Wdx7uadSlReG+PM9I/voW6Lj9w7E2HL1BI8Y3ySj9qHsih8/nU8GZqf/FjZw6eURQyRdv1f8ixfDp7LZFmiN+q21K5tnz7GpH8jmpyvmqOw/lnNcy5PfbbCYGcYY8YkONEXzyMzVL7YLUnoHHZqssR0Cl+5b039QbwRSFj2lPNWOmbXZZ9nN6I/PZhXubPrpmhfnyXRQNXXY5D6i2db+9gKVCzwX6BDXhve2B4qVknh7PysvbdYh5QAs82YsMGDycLzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wwDkF22i7Fj5EvOLNGirO00OQNWiRNo5aPZ9fHSBrJU=; b=mL4r4+9UaYcZBmKTAhEOe/rOqBl9zq64Srr3v9SJCFBG0CjUQiLto6vNnkJxuyVd2ecfxdKpHRkJTjxXQ1SFZHZK5OXDyUHQy3CQ0ofRu6Bumt+wwb8YS71Grh2PDLqSDS+5gE1Sq1hMM1zsrcZ96h8ai1XkSGHKfDqx0gJ7fYrBnWLUL98p1sr9+jkbhWzeijxDDEwIv0vssI0C8rfEdFL83f1A0piweKBOVIwmpuiU4Yh8MtiIGYi8QkTq5JunE7jm8QxyHgLM4H0wNGEMirO5v+07qIr5a5KaI+x9+n1rApqWfqydu1/lvOTbcMZ27qMrzkpJEbQBlaYomG2DnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wwDkF22i7Fj5EvOLNGirO00OQNWiRNo5aPZ9fHSBrJU=; b=v575aBanFrz/wU8A0LY4UQDQkhKDgWk6jLOM7qI4zNWxFU5uqTXYmEhK1sedFD940Y+H9uURPR6mzrZt+yjeWgWE8xdVr55SHM6/e0yX3S5942rzoQ6lw5TeAV1viJpEHzJtvlAEAj5k4l9zmg3QzPvy5JB9VhhaY3YF1XB3diw= From: Bertrand Marquis To: Andrew Cooper , "marc.ungeschikts@vates.fr" CC: Luca Fancellu , Mathieu Tarral , Xen-users , Jan Beulich , Roger Pau Monne , xen-devel , Henry Wang Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Topic: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Index: AQHYlsicqOth5aGebEinuouQN8xr5618caEAgAAKCYCAAPuhAIAAJpSAgAAJHQCAAAWjAIAAAsOA Date: Thu, 14 Jul 2022 10:42:55 +0000 Message-ID: References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1629ced1-ccd4-4c5a-6807-08da6585d844 x-ms-traffictypediagnostic: AM6PR08MB3975:EE_|DBAEUR03FT062:EE_|DB6PR08MB2902:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?V3ZoTUx6dElKUDZKZi9xaXpnLzB3UVRmTkJtdkk3MExQME5PeEQ2QXozT1Rj?= =?utf-8?B?L2pmQUNpREoyYmtpR0pPMEJQclY3WUpJU3RDV0d2R2dHZlpaNjZVZ3ZNOW5i?= =?utf-8?B?YVlrVUZEOWRxUUdTcVFGT2xkZXNrM0pBMkJpYkpJS3FnNWhmUW5GdENIVURi?= =?utf-8?B?aitDUHpuQ1MzWlpBa1oyL0M2a2tNU3hoTHV6ejVBbW5YRERsQWhTOEpLNjF0?= =?utf-8?B?Sk1KT2tkeDFJTUhIUmloMm9Da0hPd0tGNURXUmx0S3FOcnJOUVZYaHhOaSsr?= =?utf-8?B?akdBK0dnQ0F3WFFxOFo4MU80U3dPMVRaRG9ST3NQQlVHTE1JQ1pNQVBWazZP?= =?utf-8?B?TnBkcU1KdU50TVJVOTFWak9sdTJYczZSOVdlVHduanBvUUtyZmRWMnFnWUhi?= =?utf-8?B?Vy9YVmlhMWQ4SGRJMFhoN3d0K0ZhdDZqUm9lNXQxdUZrb3VEVzZEZlNPMzRQ?= =?utf-8?B?VWtzWDltMzhzT28wbE9OWmxSbUx6TEZSak5HY0p4dWpRTDFhNXB5czgvTkNr?= =?utf-8?B?OXZJSzVtSkV5RUpmbHNsaGxaRVhkd0R5S1lVSWRxRGZTZDFhU2s4aXM4bXF3?= =?utf-8?B?aDdtWjdCNi9tdE90ZDJ6OFNyaFpuS1RjQ1R5clEyb2dXbVMvUnhENktQN2Rr?= =?utf-8?B?ejNIdnBlYUNRaGlsZno1VXBRYWJGTEZQUGlFS0xHdjhoUHlJaDZJZUI2ZWtK?= =?utf-8?B?NXJaUEJBL2JnbU9QNitUWHU1NS9ocXJzSjBnVmhSNUU1MXlpSFdEcW9EQXJN?= =?utf-8?B?dk9OZmQ0dUVxK2xUZVRYRjlKVVdYeFZJY1lqQy82azZ1M1h2b0lVdmtzTDZy?= =?utf-8?B?diswcHhtWXFTc2FHREt3VEFHR0RSdGw0Q0l2WnRmQ1RxVm1zTkZTOWUvbTJj?= =?utf-8?B?dkRwRVE3SzM2d0dHdFZyTG0wSldiUHNmSGpSU0RjaGI2a2xwSTh6Z3pWMFJk?= =?utf-8?B?a2hRdFBnK1NXVDlMWk44SW82ejd2a0djK2VSelVFTFpKVWs5cUdpaFFCaDM3?= =?utf-8?B?U2RJSnFDUmxqT0xiWVlSVXpjOWUxZWRiL1JCTFBtOGlIOFlZakZ5cXlWOXJW?= =?utf-8?B?MEJ6clI0ckNSM3hDUDhIaWZQNFhEK3BuVGJLSWVqNFV3cjdNQ3RrYUJKUXNt?= =?utf-8?B?NWJFUk9XU29jUUd3cW4yK3M4MEJaYi83WHRUNkxaZnprWVU0dlB1SlJLNE4z?= =?utf-8?B?S0R1YXZob3k4R3d3TmQ5OUtGUXhQL1FzU0VCVGlIL3pTYzlHZXlzdjJSRHVW?= =?utf-8?Q?A1TGOn6SIdt6dCZ?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(366004)(346002)(376002)(8676002)(66476007)(6486002)(66446008)(316002)(64756008)(4326008)(66946007)(71200400001)(478600001)(8936002)(91956017)(66556008)(2906002)(5660300002)(76116006)(110136005)(54906003)(966005)(83380400001)(86362001)(36756003)(41300700001)(122000001)(33656002)(38100700002)(2616005)(53546011)(26005)(38070700005)(6506007)(6512007)(186003)(547064002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3975 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7f1a50e0-f8c3-484f-85ca-08da65859c93 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /gGOi72Jf10pRklcdA01H19w85YRtzsD4+1Bc4NNCGwX/L3dVNYaoGCqODe1Cy+40FOKXcsek8BeVdmqhRQ+l6vKnDR0J1xb29ys1RSQF65iOQoyduDkRE+Dmk8W0pkN+L/gP40X0+E1iVhXBTPbIXKxNwMv0HtY6iz/etx+V2FavcvH9sNhevmoDx10SOU+rt7jgLlKmPuf0vuRi8UnFzLI9wxyOVeV3c6/IYt/TSXKHxuFbwXQ6AXulQdPCc0BBAgss0kEsYGpCysIkYvJKtmJjNKvMVJOgOu5g9nXtYp8e90R0XYothEDLzeM/YBYrZ3zpH5GTyyatBytBpcBo2agVgh0JQkWjPTAESqFaU5C32BqA/WdCp8vd/biu79gBUHlAtZDQVWCLwYvjcndbX9X2BFzpJpgkqHR10c9BbTLoB1zaXg8wdf6RB1+shjUiLjekg2jZc0lwTV+DAQkAjUwd52toyJSneomgZBW1U+UtLVhRan3OyJVluoBeSEs7fXfL5bRBb5HWuVlhiYaOrCotyWX/IAJ1+Z6a9f1EchBbTYRIF9u8aoW45y8aVn36hjDoZDEJwmR65c1f54uXSnxfgS3mBjrlPCruTLH+moMoxIjpUbZbTF/jkPMfOMx7/dKbl24nQiVGY6qlOsk/lXww366dJ780cy9GwaXhlemUmqCQGNsutRDeKMfQb6eNaHAKBfGGpKUlXxRCQlQcZoiZ31y//EDddXFzoXIhUimQml3iVIED6aWIp9Tqy7Z9wpCI6nV+tz4+PY+Nrj0e8GaWltCU+FjgI8mFhsb5s2MC+60JsTLnBgFh7YA4yFI8TW0HZ+fUri7FGP708q7y6k/jWfgt3j71SkQc/zLCkwOXTc1M1VMUYk5nXBq2nCaP1TdCs0zJ6Ryvj34ivs7zMW6K1DJDKSo45g1Fgscvaw= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(39860400002)(136003)(396003)(36840700001)(46966006)(40470700004)(186003)(86362001)(82310400005)(70206006)(70586007)(36860700001)(316002)(8676002)(450100002)(336012)(26005)(47076005)(83380400001)(6486002)(5660300002)(4326008)(966005)(33656002)(6512007)(40460700003)(54906003)(82740400003)(81166007)(478600001)(41300700001)(2906002)(53546011)(8936002)(40480700001)(36756003)(356005)(110136005)(6506007)(2616005)(547064002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:44:35.9607 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1629ced1-ccd4-4c5a-6807-08da6585d844 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2902 DQoNCj4gT24gMTQgSnVsIDIwMjIsIGF0IDExOjMzLCBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29v cGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDE0LzA3LzIwMjIgMTE6MTIsIEx1Y2Eg RmFuY2VsbHUgd3JvdGU6DQo+PiArIENDIHg4NiBtYWludGFpbmVycw0KPj4gDQo+Pj4gT24gMTQg SnVsIDIwMjIsIGF0IDEwOjQwLCBNYXRoaWV1IFRhcnJhbCA8bWF0aGlldS50YXJyYWxAcHJvdG9u bWFpbC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+IEhpIEx1Y2EsDQo+Pj4gDQo+Pj4+IEhpIE1hdGhp ZXUsDQo+Pj4+IA0KPj4+PiBZb3UgYXJlIG1pc3Npbmcgd2dldCBpbiB5b3VyIHBhY2thZ2VzLg0K Pj4+IEluZGVlZCwgaW5zdGFsbGluZyB3Z2V0IHNvbHZlZCB0aGUgaXNzdWUgYW5kIEkgd2FzIGFi bGUgdG8gZ2VuZXJhdGUNCj4+PiBhIGRlYmlhbiBwYWNrYWdlLg0KPj4+IA0KPj4+IFN0aWxsLCB3 ZSBoYXZlIGEgYnVpbGQgc3lzdGVtIHRoYXQgc2lsZW50bHkgZGVwZW5kcyBvbiBnYXdrIGFuZCB3 Z2V0LCBhbmQgdGhlcmUgaXMgbm8gY2hlY2sgaW4gdGhlIGNvbmZpZ3VyZSBzY3JpcHQgdG8gZW5z dXJlIHRoZXNlIHRvb2xzIGFyZSBpbnN0YWxsZWQuDQo+Pj4gDQo+Pj4gQW5kIHRoZSBlcnJvcnMg aW4gdGhlIGJ1aWxkIHN5c3RlbSBhcmUgcXVpdGUgb2JzY3VyZSwgaXQncyBoYXJkIHRvIHVuZGVy c3RhbmQgdGhhdCB5b3Ugd2VyZSBtaXNzaW5nIGdhd2sgb3Igd2dldCBpbiB0aGUgZmlyc3QgcGxh Y2UuDQo+Pj4gDQo+Pj4gV2hhdCBkbyB5b3UgdGhpbmsgYWJvdXQgdGhpcyA/DQo+PiBIaSBNYXRo aWV1LA0KPj4gDQo+PiBJ4oCZdmUgQ0MgdGhlIHg4NiBtYWludGFpbmVyLCBwcm9iYWJseSB0aGV5 IGtub3cgYmV0dGVyIHRoZSByZWFzb25zLg0KPiANCj4gVGhlc2UgYXJlIHR3byBkaWZmZXJlbnQg cHJvYmxlbXMuDQo+IA0KPiBUaGUgY29uZmlndXJlIHNjcmlwdCBkb2VzIGNoZWNrIGZvciBXR0VU IChvciBtb3JlIGdlbmVyYWxseSBGRVRDSEVSKSBhbmQNCj4gd2lsbCBvYmplY3QgaWYgc29tZXRo aW5nIGlzIG5vdCBwcmVzZW50LiAgVGhpcyBpcyBvbmx5IHJlbGV2YW50IGZvcg0KPiB0b29scy8g d2hpY2ggeW91IHNob3VsZCBoYXZlIGJlZW4gZm9yY2VkIHRvIHJ1biBjb25maWd1cmUgZm9yIGFu eXdheSwgc28NCj4gSSdtIHJlYWxseSBub3Qgc3VyZSB3aGF0IHdlbnQgb24gdGhlcmUuDQo+IA0K PiBGb3IgdmFsaWQtYWRkcnMgdnMgYWxsLWFkZHJzLCB0aGF0J3MgY29tZSB1cCBvbiB4ZW4tZGV2 ZWwgYmVmb3JlLiAgSQ0KPiB0aGluayB0aGUgZ2VuZXJhbCBjb25zZW5zdXMgaXMgdGhhdCB3ZSBk b24ndCB3YW50IHRvIHNpbGVudGx5IGRlcGVuZCBvbg0KPiBnYXdrLg0KPiANCj4gKFdlJ3JlIHRy eWluZyBzb21lIG5ldyBwcm9qZWN0IG1hbmFnZW1lbnQgdG9vbHMuKSBDYW4geW91IHRyeSBvcGVu aW5nIGENCj4gYnVnIGhlcmU6IGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4tcHJvamVjdC94ZW4vLS9p c3N1ZXMgYWJvdXQgdGhlDQo+IGNoZWNrLWVuZGJyLnNoIGlzc3VlPw0KDQpodHRwczovL2dpdGxh Yi5jb20veGVuLXByb2plY3QveGVuLy0vaXNzdWVzLzI2DQoNClBsZWFzZSBjb21wbGV0ZSBpZiBu ZWVkZWQuDQoNCkBtYXJjOiBXZSBoYXZlIGEgZmlyc3QgZXhhbXBsZSBvZiBzb21ldGhpbmcgdG8g YmUgdXNlZCBhcyBhIHBvdGVudGlhbCByZWxlYXNlDQpibG9ja2VyLiBBbHNvIHRoZSB0ZW1wbGF0 ZSBpcyBxdWl0ZSBleHRlbnNpdmUgYW5kIGhhcmQgdG8gZmlsbCwgd2UgbWlnaHQgd2FudCB0byBz aW1wbGlmeSBpdC4NCg0KQ2hlZXJzDQpCZXJ0cmFuZCANCg0KPiANCj4gVGhpcyBvdWdodCB0byBi ZSBhIDQuMTcgcmVsZWFzZSBibG9ja2VyIHNlZWluZyBhcyBpdHMgYSByZWdyZXNzaW9uIGZyb20N Cj4gNC4xNi4gIChDQydpbmcgSGVucnkgYXMgcmVsZWFzZSBtYW5hZ2VyLikNCj4gDQo+IH5BbmRy ZXcNCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:46:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:46:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367495.598550 (Exim 4.92) (envelope-from ) id 1oBwMg-0006NL-0l; Thu, 14 Jul 2022 10:46:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367495.598550; Thu, 14 Jul 2022 10:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwMf-0006NE-Tt; Thu, 14 Jul 2022 10:46:37 +0000 Received: by outflank-mailman (input) for mailman id 367495; Thu, 14 Jul 2022 10:46:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwDs-00008g-Hk for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:37:32 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f6c0f091-0360-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:37:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB6591.eurprd04.prod.outlook.com (2603:10a6:803:123::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 10:37:30 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:37:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6c0f091-0360-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izH1WXrDxOxyLBl0ZOITAHFTqG2cTYMqGN2tAAa3gVq6hkeDtKyYGMFT7uxmACPriHRF6N/fea2+NNDsCKX6ULIBEgAxu3tCl+z2Qi/63/jArAO2QgIOwLslJaEgV50O2Ii4zC0OFBNd8bTtNnsbMX9tRu6V1hPp9w/oz6DpyMvGJiSMfuOoEPVSPmXXD4hdPX8807iCDAhm3RFy3Zv6oQY9JgNC1BFKhZHppUQsrjSCzNEGFsjv5DBNnpZ3oBHJAwCGoxgm1DX0JeWr47K/AMjgg/s+/m6ieFw32bKr0sWtxXH3ODEtNAgBpVv1EsIl8DZicRAiRNmr7OLrWG8iOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LVsHDb5UE2EgU0row//0YNCGlvcrSgWlyewvZ2FYruo=; b=EN1er7g15WJocCzqQgFlebsbCx/rdBN0QuYGLVSuCNSrdwZGXwBfBwlGu3mLZykyqTaX1IO5ueFldGaHhNYhZmUhqshVR/7/yq0DKd1HBt3httC6hvpncBRan4lXGqOKngaLnr86YpEMTb/9sfWEIBYBC0/mhWoAuDGk8e2JbqQErvjWQLHU8D0aiw9fmFAP2Hcpc6TEDrij77QMpXW37KtvUQS2iTdx4QzyoftwtZ4zhapRLUxuOfu1EZs5GNDpeLYgP71z0kjQiPocnZeB7nmyTh+B8VL/kAJIOTfPB3NeCPF3bMhL+FerUrTSL11/WSzFIh1YJeHXW3QAk3Z86w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LVsHDb5UE2EgU0row//0YNCGlvcrSgWlyewvZ2FYruo=; b=MJIl7dR0zZH3iVfGaDOr7fLNqfXyqtVLVERd1WRrDeMk2ZlD0X6gqpFYH7H7TCNxn3hO+2UN0a1Os2ZMB+fu4iItnCnpaZFiMvmtkDkSpI2oSvCfzfKw+vw/nujm1JOEWRK1DQUjY66Pwwa5a2HOsvalAUytDLH4ELVxeVPwcCrLIC/P18ObUlK4eQF/9Fndop9guIFwtfSOHE8JNOABGRRoV8l7h4fffYEiEleeQYkpBXCtv+hZTdtKp2oz1M8rt7jbE1C5OXgJfb1q45ncPJoo64JLaLXAseXWZY48DwCnUCndh9Y4kvT32dvciX7mj9SNfB1QiccglF5eEGrSBw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> Date: Thu, 14 Jul 2022 12:37:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM7PR03CA0024.eurprd03.prod.outlook.com (2603:10a6:20b:130::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: aed88ac9-4a30-4801-845b-08da6584da3e X-MS-TrafficTypeDiagnostic: VE1PR04MB6591:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j/afxU4pmzdIA8a/ttBWRoN4cEtGSPfGorqsvI2Dxj1g7ug61P2/E1Ckr+Ilz228Xvj+o1VhD8o+QNsTO8BlpI24fBGlmbbD8ll+ySbE9Noq6563sCQ2x+DWnlfVj6ZuHn7FZLeTYr0i56r357EfwFC7XWFy9CO96FJ3jmdqrRRcDoTYrxPru3M71VeJiCEi/a0LqWX9odB/shosmG60iEH6wXDnSbW7qUz1avuueLxZrzxZ/xYmUpYrMlxrf0Sq5Ml/DOvIwioIROzgZmY8SAemXY3VdGmSfDVY0hm1JeZ/hpkEeTyOGVpm1C77YgjT8I7YFZwmN7TA4et/PbPfb6VbSWxXHoVmzGh80tryBDhD+IQ/sUbagN4iGBpd0HGpdoRFvvsLe/cegIzwL3ZI6LboJ0L0mP3RJak020vbsEQ0yK9Q5SzDW4kJh/sqHZBPi/rZWmM23B5O8bzKRfCJd7va5oJF/B6PKCDtBqj34dZxlTabSY4CR/+cvohZQ8BIZwmYX3epkkuDxPfYiGMetKRcexHTtaKtfqibAG+cVbGkYvjgtDsTVMdLP+mQ1uUvjvgoZi438Bkbr1hLVhbUXFWpvI2QxxDqM+MH4ej60VnBxsHN0dVVc/m/zUj7817CNAEFeLSugcdEzsST+w3+5VWwKTv97FKr3iJwvVXuKylNd7ZMaW3RI+dpFsRCcOLa0mHdiuVa4z26IXLHDQYN4KZc9J1RyQtQou9J8KKN27K596vKk4oCNITnM501LrVOWJ/QPbswuTjWXOqaPuIif40w3RIzrKO+5CccR0+9rWzWTzZiE953Ie+S6eJzKLZeMOLddydz9bdVdU/WijyiZkz7XTYU87vgqQhfZmMNYgA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(376002)(136003)(346002)(6862004)(2906002)(5660300002)(53546011)(8936002)(83380400001)(86362001)(31696002)(36756003)(6486002)(6506007)(38100700002)(478600001)(66556008)(66946007)(8676002)(316002)(186003)(54906003)(2616005)(6666004)(6512007)(41300700001)(4326008)(26005)(31686004)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEhRREd2T3BrUFBrdlBPSEQzKzVUeE9lbkhmTXh5SzBxQ2lQbnJ1OUtoUnJk?= =?utf-8?B?SUt1bklDNW1rbmw2UlVwOWFMUDhId3NJS3JrQzF5VGtoNkVnRXhlOHJ4aHFr?= =?utf-8?B?TnlGZ2NFQkpQajFWRDdYYnN3UjZ5Vld3NlN6MkZSTWJsdW5jVTdLY2NVb1Zi?= =?utf-8?B?R3dZYlZpQU5HNGkyb3puSWtaZzBDVkprdkZNajJKVEhvUjkyb0tSRXMrakRv?= =?utf-8?B?ci9RZFgyWjJGOHVQa056bVVXUW9PZGNzWE9RcTN3Wkw4eWxicnRsenN2VTFj?= =?utf-8?B?Y09FTU10d1dqejdlbFNjdHNNV20xaFVtN2owazQyK0Z0cW5nenZjV3ZlOEti?= =?utf-8?B?NHU0d21BejRxcS9mZjErWEtiWmdhdm1Rb2JQWHU4bWlSb2ZTdlFDdVVyRWVF?= =?utf-8?B?QzNSblgzMjRsVWdDWXFId2lHZ0hSN0VaK0FWWDJxc0o4T0N5a3NTMlBaS2ll?= =?utf-8?B?WWQ1ZkYyYXFhTzE2MFN3NVN1TnVicGJkNXJLQ3phSUdjT0E1NDloSmFTaFBE?= =?utf-8?B?SVVWREhmbEpxY0FKdGNzcDdqR0lRTnZQR1hCZG1PV1YxeTI1K05idFV2V2la?= =?utf-8?B?SmptdnR2dXE1dTZIeTRIMjcvVCsrRmo5NWpmdlgwaVdyejNrYkdWSkdiNVJt?= =?utf-8?B?UlRpdXVMd0FjakVWaUxiUWM3T2VlRGhtVnBiNndjNHBxMSs5eVh6NXZCancx?= =?utf-8?B?TWh2d0tGc1hmbjZjdEVmSlBFYldxVG5IaGxkU2xqK0psWjlqMmpCeTYzdXFX?= =?utf-8?B?MDJ0cmF3SHZLQXdTTzlZcmI4VmpyMmtBaGZiWTE1RmdaODZrWDB1Y0tyYyt0?= =?utf-8?B?aFkxVTNBQms5OVhwSHlZT28wOXRyVHFIalZQSGpxZ0N1TTUwOHQwcmF4QzF6?= =?utf-8?B?a0FuMnNEOUNreXRJQjhtbm9OODl6bjZaTWdKZHlBRUd4QnlYYW5kSXRmbU5K?= =?utf-8?B?WXFnMk9aUUNjdG00c2E4WWtwTERjeE1pL1VmRUZNMkNiakhEeWM3WHFnZmt2?= =?utf-8?B?bXZJQ0twUnpJU3J5b0tDd25vL2VaWXIzWnp1Q0xrWnBLYVZFNTN0MGdNcm5R?= =?utf-8?B?UEgwQ1Q3REFBYUhsMW5rbmxqM2p3RUNHMk1SYi9GOTFqNktXWU4zUEx6eisr?= =?utf-8?B?MUVXR1VwMVFXbFFHNm9OcVliekI2Zmc3NDQwaWJIalBjZGE4d28zMVJPUm9q?= =?utf-8?B?Rm9PZzBVNE13RUNZRlBKNHdFWXltMUpNUUZuWjRzZ0xDYlRrUmFRU1RwcFUw?= =?utf-8?B?Qy9USkw3OFVyeHA3ME1LY3B4K3JUVzZxZ0ltc21KRnd6T2dlZDk5b241anhE?= =?utf-8?B?TTlTQVFyRmUwWkJickYxQ21LVVI3RXJZd29FMksrL205TkRKWmlmOVcwOVpk?= =?utf-8?B?WU50WVZGaGpNTXNXN1hnU3RYcGhTcWR0QzJnbm50TWxXVEZXd2E5YW9SdERI?= =?utf-8?B?Zml6VmpyZDM3c3BVZXI1cThlWkR2cmJ0SmxoOTF3NHVSOWNOMXRkR3dBcXMx?= =?utf-8?B?Y3N0Nk44ODdmMVJVUExsOVpQKzVKUjYvQUhHZ0huaTBmUVkvMmhQcGI4R0pq?= =?utf-8?B?Y3dSbFNwVVl4cGs2K3B2bVRkQnoxcCtMRVk2L3VaNWg4V1l0d0V4U1ZTRFk1?= =?utf-8?B?YWYxQVhpSWVnMDd1d2lmaHprYXFvR1R3cnlRT21KbG81Q3I5T3FyRFIyMjRs?= =?utf-8?B?bFg1ZUt0bUlrUVNPeE9EMTBIK25tdzJUUDZ3RnBLREd2ZmNkYVNQWXQ2RmFW?= =?utf-8?B?WG9DckM0cytuQW04TUFLRjd4MWRPZ3ZKT2xDZHdkSUFFSTFyd3ZiTkp4S2s0?= =?utf-8?B?bDllMUlCU0xHZVJsSW9keGdITWF4VGhqb29rekFFU2E4Sm1YVC82WUNTUXF1?= =?utf-8?B?SlNETUlBc2pRZm80YkxQUURSZmg0QmRNdnNIQ09WSEhYaFFoV2Y0Sy9hSzNh?= =?utf-8?B?Vm1taVgxendydmVsdU9wTTl4WVdsd0djTzNmYW9vN1hlM01sU0xrdzVOcEFk?= =?utf-8?B?ZUtqRzBqMkVkNGtDR1AwckVzbUUwdnhHcjQwMEllU1NrRGlYM28vNkF1a2Ru?= =?utf-8?B?U3p4dXpYalFCMVdFejhBVmkrVzgzVDUxSi9kUWQwMWpZVXUzMTRkR01KUWRG?= =?utf-8?Q?Zlc6Fz0VmleCORkDKRT6HOJnv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: aed88ac9-4a30-4801-845b-08da6584da3e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:37:29.9215 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ktSF/L0TXImNE0Hhuea7xLyIsmCKt9P4uEDtvvllVoyvB0g9NctvyfECDKgVETMXpoXubCc8VG0H/y2fGfmm8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6591 On 14.07.2022 12:26, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月14日 17:58 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; Roger Pau >> Monné ; Wei Liu ; xen- >> devel@lists.xenproject.org >> Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA >> status >> >>> >>> How about update the table like this: >>> +------------+----------+----------------+----------------+------------+ >>> | original | | | | | >>> +------------+----------+----------------+----------------+------------+ >>> | numa_off | true | true | true | true | >>> | acpi_numa | 0 | 1 | -1 | x | >>> | numa_fake | x | x | x | fake_nodes | >>> | enum state | numa_off | numa_off | numa_off | numa_off | >>> +------------+----------+----------------+----------------+------------+ >>> >>> +------------+----------------+------------+-------------+------------+ >>> | original | | | | | >>> +------------+----------------+------------+-------------+------------+ >>> | numa_off | false | false | false | false | >>> | acpi_numa | 0 | 1 | -1 | x | >>> | numa_fake | x | x | x | fake_nodes | >>> | enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu | >>> +------------+----------------+------------+-------------+------------+ >> >> Well, this makes the table complete, but it doesn't explain how you mean >> to fold the settings of the two command line options into one variable. >> > > No matter how many separate "numa=" parameters have been parsed from > Command line, the values of these original variables are determined > after parsing the command line. So the determined status can be mapped > to the new one variable from above table. Hmm, I was partly wrong - the initial values of both variables are indeed set from just the single "numa=" parsing. But later on they "evolve" independently, and multiple "numa=" on the command line can also have "interesting" effects. I'm afraid I still can't convince myself that the new mapping fully represents all originally possible combinations (nor can I convince myself that in the existing code everything is working as intended). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:49:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367514.598562 (Exim 4.92) (envelope-from ) id 1oBwPE-0007Gq-F8; Thu, 14 Jul 2022 10:49:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367514.598562; Thu, 14 Jul 2022 10:49:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwPE-0007Gj-Ar; Thu, 14 Jul 2022 10:49:16 +0000 Received: by outflank-mailman (input) for mailman id 367514; Thu, 14 Jul 2022 10:49:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwGX-0002w5-G9 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:40:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 593e6253-0361-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:40:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7C133B82489; Thu, 14 Jul 2022 10:40:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 156B9C34115; Thu, 14 Jul 2022 10:40:14 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E7C31E45228; Thu, 14 Jul 2022 10:40:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 593e6253-0361-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657795214; bh=Ooz89c2I2B1VTAZ2/C/Wt525paEje7ftISA5Of5DqxA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=CJfxU8cIVWihxpp7021m42vgK2Ei/0zSEQole+TY1e8PG9PGGBXGl7Hcrq9Lzh4UF yBEuU+1Vuw2ixt2yr8vibBI8KKpOfZjcvYYpYbv4rse/SJvPbDev2FsVydHRJTcBYM quoke4L0MtCfQsQVjNSecZEFfTuffUEQw93vCVQeBl6J8N1DzsWS3rM1BXiWo3uXLh 9FPJRj9f2lvKorZXb06gOHS3sXe9WAKSBW8VZKFHKutNDNPCJgxo+BmmWo5ua198DZ ATujL9ZgwnSa6aHmmp2kmPlNN73gMetSwua21imuZWyORO1J1rxiVri971b9EGPXE9 G1dS7RhwStHVQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next 0/2] xen-netfront: XSA-403 follow-on From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165779521394.17700.1175257223306226603.git-patchwork-notify@kernel.org> Date: Thu, 14 Jul 2022 10:40:13 +0000 References: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> In-Reply-To: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> To: Jan Beulich Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org, jgross@suse.com, stefano@stabellini.net, oleksandr_tyshchenko@epam.com Hello: This series was applied to netdev/net-next.git (master) by Paolo Abeni : On Wed, 13 Jul 2022 11:18:03 +0200 you wrote: > While investigating the XSA, I did notice a few more things. The two > patches aren't really dependent on one another. > > 1: remove leftover call to xennet_tx_buf_gc() > 2: re-order error checks in xennet_get_responses() > > Jan Here is the summary with links: - [net-next,1/2] xen-netfront: remove leftover call to xennet_tx_buf_gc() https://git.kernel.org/netdev/net-next/c/ad39bafda736 - [net-next,2/2] xen-netfront: re-order error checks in xennet_get_responses() (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:49:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:49:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367519.598573 (Exim 4.92) (envelope-from ) id 1oBwPM-0007bz-Mc; Thu, 14 Jul 2022 10:49:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367519.598573; Thu, 14 Jul 2022 10:49:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwPM-0007bs-J5; Thu, 14 Jul 2022 10:49:24 +0000 Received: by outflank-mailman (input) for mailman id 367519; Thu, 14 Jul 2022 10:49:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwPK-0007bH-RN for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:49:22 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2045.outbound.protection.outlook.com [40.107.20.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e152cff-0362-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:49:21 +0200 (CEST) Received: from AS8PR04CA0065.eurprd04.prod.outlook.com (2603:10a6:20b:313::10) by DB7PR08MB3500.eurprd08.prod.outlook.com (2603:10a6:10:49::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 10:49:19 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::7a) by AS8PR04CA0065.outlook.office365.com (2603:10a6:20b:313::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15 via Frontend Transport; Thu, 14 Jul 2022 10:49:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 10:49:18 +0000 Received: ("Tessian outbound 6f9e7ef31fa8:v122"); Thu, 14 Jul 2022 10:49:18 +0000 Received: from 09ccef1bb25c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0EEF6103-3ED4-4850-8C3F-77C2B457AB81.1; Thu, 14 Jul 2022 10:49:12 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 09ccef1bb25c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 10:49:12 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB6PR0802MB2182.eurprd08.prod.outlook.com (2603:10a6:4:86::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Thu, 14 Jul 2022 10:49:09 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 10:49:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e152cff-0362-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=bRd8aEs3FQhkkDLCMCRH2tQQ9H+iINtqrAosvwFylx4qioqIa5kHMwpvRHUGaH/0w5bCpugM4hY/ardyR71xh/rtLqxA9yJcIrbqh2hzT5bUJ+lJkGucZnvZhmjsG6ohp2sSpFf2orWhMI1KCa9OvzMA0ByvxwR18EMSTF59YT9xwTT7+IcDvcvy+IJH5mdmf54sykBPLnyFgqh7GUb7E1ArphfnZQz9dfCeBgk3rSHFwKX0vnnIJZaSqr+ro/XjSGwysSzl9gaa9QdDyoA1uoauiOU+19Kqnf7Fg+I7Yr1pedyq+2tukrrK0KaDdJF1J5TLDQFzeKp3+Fr5Q+RmZg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NEdrk124nRAavj0rfG9jQ9C/87PocluAQuXl930QdYk=; b=bN0tIIX+NU2p/cwX15JXAnn4DX5oXk4BlCnIWFEb3lf/DNKzw8zXlKE7+bXpAgbVbgqY8xIwoSxI+sTexl2pITXMnKLcaWD+RGvaTUQeaCph/wA4EJFhIv3A6HZvvVIFixNa6JOrSlD2agJiWbi+Qtk8dWyM0YUPReKYg0tKCtUc9mBjCGgFQuWhyNVZCHYK2LojETrmvHm0IGi6zwEPUF00O0OLgUX7K80jV7Iz9e+f4Q3ZHKLlEcgjCJv7XEjsgEznZDyqAyTQltjxzNdZ93fWLtHf5X1xthCUY9Pepltzk0jeDd1m5IyiXlzM4jTBcoF+KvZa1QkepsFHbwbhsA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NEdrk124nRAavj0rfG9jQ9C/87PocluAQuXl930QdYk=; b=HmY1rYfgDY4JCl56iXfKNSLrr8wK9N3vbZ2Ug8jKl8izEIwv7LAjNys0TSjnPuYqQA1QIyt3u5FJeKoaIvaXXAwKaBOWouQlOWGPnMRvYEK1pyAZlblE20iprNvtNRkNwOoKmLHz2hPDvIqNUbcJSD5HeDI1GziZcGi3pU0+CVs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvXxIw6wmjfr/ehqo4rb9tb4cNWek/PsgO9JdxRVWO3SxbmjpoQ03kkyNJhpU7X7+OMQ/OqkCYdEQCvz3YlfkhoHoAPhcQvk9wuYodQksIcbFw8azR8m/fc64I5/Hy3umJFoNFBvuk2+w2qsQVQr79Pvj30bACqynaPbc8pFHG2In6rmA7FKBa8Ht8DwN2Hypr1YvflGiirfG7OM1fNoViXy7jd4XAUQ/lMKRrBlHXUI1Eh6OvuFU2+Ej+uM3wNxsHlTsZmdKSxDuLK3LM5uMnrMSFpK5OUDTiPuotzA3q1V0B0IE26gEfq44H2Ddi3wUquXUX567w3eEj5dHecyWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NEdrk124nRAavj0rfG9jQ9C/87PocluAQuXl930QdYk=; b=eGXYkBuuD+LtchwM54l4ca66RAf6dVHIExgm4HLIwCVVchlvPmcqfsm4Q2m6eeFKtUnY+w+kGiPFZBt38qDHZFNXh83E6+vTax/c9Fm++lAUe9qc50zQ4Qw/xguFPHDBtgwN/1K7nxj1I8vmpK0JN5yFsUV2lBLqSGlh2ymooNnKceCBSYYqCY5joybe8TrrCThOOMXjJ4S88+5+XE+3JZkQ9CBgz9NrQL+OU8aRQMBXbezGvENapne472YQHALwF/SMXGjpZqnJtZnadk7OKTFNBtcC3ntkqL7JiiaxkxCL5Uy/n6vBEyKFcz0u3Bv3Evfcw20PCCaiHk8ZbLQ+EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NEdrk124nRAavj0rfG9jQ9C/87PocluAQuXl930QdYk=; b=HmY1rYfgDY4JCl56iXfKNSLrr8wK9N3vbZ2Ug8jKl8izEIwv7LAjNys0TSjnPuYqQA1QIyt3u5FJeKoaIvaXXAwKaBOWouQlOWGPnMRvYEK1pyAZlblE20iprNvtNRkNwOoKmLHz2hPDvIqNUbcJSD5HeDI1GziZcGi3pU0+CVs= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItggAACa4CAAAWRQIAABX2AgAAC1iA= Date: Thu, 14 Jul 2022 10:49:09 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> In-Reply-To: <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 5F46BAD4ED097D49A0010A54F27D6A39.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5ef0b44c-e93e-4525-2c8f-08da658680ef x-ms-traffictypediagnostic: DB6PR0802MB2182:EE_|VE1EUR03FT055:EE_|DB7PR08MB3500:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mAmyxOcVE50BH0LR8AwF4odDzCpXTCnxVZxWTVszyEB1pQ7Rfzd+J7l+okP2QGeof1G6C26XuxpBQId4mZbQO/IsBLMyF5poPMgWGzKK+ArwjgRDSP2HoniFsOTs12tVwiN+WVazx4VehzQY0540WjkNKNrOGjnv5o3tgdL7oF0hcgG1daNdAR5xRsDqBCDQ3bGNvilOqB/Gww6/BqWWW3UJKAHSNCwfgv9SsVYwVYbRXxcZAsElAaezLfOhzxgT9vOdPVIFs/LUxTeJ5qs79Yarm30FC+NpNEYtx2eUL+GXd8W3hUunD+Zv7s7CUl7kOB102QiBDZsM95ADtdeUlWG7EhR9zsESOmlWuhtc1FuDbsjB5b29IIlAWs+cfzlapzpm2wc7B8XdQNUphI9doPxRAoRQR9omGtDeeN4n8dLDW6plx5fxvTDhbXqJCR46f+x7I1o+PLYEemGpR/zXi7pzFwNQBHVCl7+0BlU7SBBCrIUYPu1UVFpd+xSJH1J+uQhqsgdBOGJ6lhO2+BODDRMwsVbNIcCvRv9DYMnAvrE4omh76myDdBHEAkJAMBJt0JgpdKoz425eDmumfe2O6I5i03SE8sye0s0pVbQVLdgi6n+OQPCIrvJ6iVeMH9Yu77/2cyt1KQL2+NviX90Tj/nslFX7VQrem03yPIt5GJZALJaEtIQiRwkhlAwRIwxmc6v1upy16B3b2IkwBrEyUbFZFo81VTrVAdzipTga126kUqzzm1e7pOPalfDGyPqQ237aHKsB1SL6nqU2OF9xmUUG9zDNs1y8ilV59NgFfHKqqndyVGzZqPef1N+fVhm2 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(366004)(66946007)(478600001)(38100700002)(66446008)(53546011)(52536014)(71200400001)(38070700005)(26005)(9686003)(8676002)(66556008)(66476007)(86362001)(76116006)(4326008)(5660300002)(54906003)(6916009)(64756008)(186003)(122000001)(41300700001)(316002)(2906002)(55016003)(7696005)(8936002)(33656002)(83380400001)(6506007);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2182 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ee984122-2bd3-4383-17eb-08da65867b14 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iNGR24apmt8xuEEnYqY3J5hdiASImlcBddQmziIQ5JaUK6ZfhLiy5TQyU7pnzeyh/zHdeR3mlC0qEA3o76IaHaeZ4HfsxbV0pu20Rl7x+PV8xt2uMFm+xpHHvlZLXBhZ14m22oGHGqQlFOSL5+jzXAIg+f4w/yesonESGqhzqv6TI4tSHCj9l8YzMhH9N0SYRENbVKiqhGHL5Gtm4TTbAMj0o4WEXZXXt/ppVsYs2iut7+HSgUHZp/Upc91SEWkdSbIrKKfvqH9So4mXbjQpQ2n3arDTJ7kxBZpPLzC8vLMvY/N7krSPjRnN0sQzv0z0olv+875pcBaczXML/9nh5Ybj39gNslkB1wIXK9gS7/V055yR5mYSE5QQ5ThoxSUl1jrEMwfJlqrvJ9Dbxlh2xCyjflDxk6PqKMGTql2mg20NjqA9pcm9QMi3zjuWWfoc+v4GAIMHu1YehS9vfaU/9KLm9xUYertocx/Fa4ngyuhvmHXAbinM3bIK0RyaIPzfNssZWv3v/i65n9RFk+dPv/1Oivn4scCnB6xncQ9IEBcGB8yE1H22y8T1Qq/bodgr/Oe+lHMe1QLBphhW2GRxhYAC/hbfCmurUWsQWta9Z+YZHlww163Wmcrw7jR63vpr05gFmbwoT2I1tQpqEBz6Ekh10ZwU448fe5nQOdLb11OyZ32ptZMCFto2UFLO6F5ZURqUYTuO5rTDQsDD8BCF2oOgFkLY/xlsKnMGTl6vqw0+RiRIczE+4+F7p/0XsllcJFufgnApsPlY2QOgJ/UhCnyx6uJ0OLGmxa862tZwlMHDUT032g1xXBnJqEOGgp/J X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(36840700001)(40470700004)(46966006)(316002)(478600001)(186003)(70586007)(53546011)(83380400001)(2906002)(82740400003)(70206006)(40460700003)(4326008)(7696005)(54906003)(6506007)(81166007)(8676002)(41300700001)(33656002)(336012)(86362001)(5660300002)(36860700001)(55016003)(6862004)(26005)(40480700001)(47076005)(82310400005)(9686003)(52536014)(356005)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:49:18.8439 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef0b44c-e93e-4525-2c8f-08da658680ef X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3500 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxNOaXpSAxODozNw0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg Mi85XSB4ZW4veDg2OiBVc2UgZW51bWVyYXRpb25zIHRvIGluZGljYXRlIE5VTUENCj4gc3RhdHVz DQo+ID4+DQo+ID4+IFdlbGwsIHRoaXMgbWFrZXMgdGhlIHRhYmxlIGNvbXBsZXRlLCBidXQgaXQg ZG9lc24ndCBleHBsYWluIGhvdyB5b3UNCj4gbWVhbg0KPiA+PiB0byBmb2xkIHRoZSBzZXR0aW5n cyBvZiB0aGUgdHdvIGNvbW1hbmQgbGluZSBvcHRpb25zIGludG8gb25lIHZhcmlhYmxlLg0KPiA+ Pg0KPiA+DQo+ID4gTm8gbWF0dGVyIGhvdyBtYW55IHNlcGFyYXRlICJudW1hPSIgcGFyYW1ldGVy cyBoYXZlIGJlZW4gcGFyc2VkIGZyb20NCj4gPiBDb21tYW5kIGxpbmUsIHRoZSB2YWx1ZXMgb2Yg dGhlc2Ugb3JpZ2luYWwgdmFyaWFibGVzIGFyZSBkZXRlcm1pbmVkDQo+ID4gYWZ0ZXIgcGFyc2lu ZyB0aGUgY29tbWFuZCBsaW5lLiBTbyB0aGUgZGV0ZXJtaW5lZCBzdGF0dXMgY2FuIGJlIG1hcHBl ZA0KPiA+IHRvIHRoZSBuZXcgb25lIHZhcmlhYmxlIGZyb20gYWJvdmUgdGFibGUuDQo+IA0KPiBI bW0sIEkgd2FzIHBhcnRseSB3cm9uZyAtIHRoZSBpbml0aWFsIHZhbHVlcyBvZiBib3RoIHZhcmlh YmxlcyBhcmUNCj4gaW5kZWVkIHNldCBmcm9tIGp1c3QgdGhlIHNpbmdsZSAibnVtYT0iIHBhcnNp bmcuIEJ1dCBsYXRlciBvbiB0aGV5DQo+ICJldm9sdmUiIGluZGVwZW5kZW50bHksIGFuZCBtdWx0 aXBsZSAibnVtYT0iIG9uIHRoZSBjb21tYW5kIGxpbmUNCj4gY2FuIGFsc28gaGF2ZSAiaW50ZXJl c3RpbmciIGVmZmVjdHMuIEknbSBhZnJhaWQgSSBzdGlsbCBjYW4ndA0KDQpDYW4geW91IHByb3Zp ZGUgc29tZSBleGFtcGxlcz8gVGhpcyB3YXkgSSBjYW4gYmV0dGVyIHVuZGVyc3RhbmQgeW91cg0K Y29uY2VybnMuDQoNCkNoZWVycywNCldlaSBDaGVuDQoNCj4gY29udmluY2UgbXlzZWxmIHRoYXQg dGhlIG5ldyBtYXBwaW5nIGZ1bGx5IHJlcHJlc2VudHMgYWxsIG9yaWdpbmFsbHkNCj4gcG9zc2li bGUgY29tYmluYXRpb25zIChub3IgY2FuIEkgY29udmluY2UgbXlzZWxmIHRoYXQgaW4gdGhlIGV4 aXN0aW5nDQo+IGNvZGUgZXZlcnl0aGluZyBpcyB3b3JraW5nIGFzIGludGVuZGVkKS4NCj4gDQo+ IEphbg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:51:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367531.598583 (Exim 4.92) (envelope-from ) id 1oBwRj-0000t1-7q; Thu, 14 Jul 2022 10:51:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367531.598583; Thu, 14 Jul 2022 10:51:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwRj-0000su-5E; Thu, 14 Jul 2022 10:51:51 +0000 Received: by outflank-mailman (input) for mailman id 367531; Thu, 14 Jul 2022 10:51:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwRh-0000si-H3 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:51:49 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20077.outbound.protection.outlook.com [40.107.2.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f598a57c-0362-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 12:51:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB9145.eurprd04.prod.outlook.com (2603:10a6:10:2f4::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Thu, 14 Jul 2022 10:51:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:51:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f598a57c-0362-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ofAfOwJ4c+lZiEzxqE6twSO4sBiFI6K89z4JS3sAdWxB/e5yv3Yolz1fnvR3fCcbpbl6vxy4RgfQ/ZfkWLzmxFwRLtQnWdctMT6QIKcHUNlnrwwWtgLlytBj7Nl8Bu4PKaqkUq7QfiXgrFAco7kibfGF0PJA9yAyipcqwQLGTxI6ektMkM9tiklgjOwdt4obnaf72gSC76lKZh4Vcyz60FZLhGUPv4yKsh/h1OVEEhZT+Bc9H4ZicBRMq8Igem+m2TnOfhoOMv7MzLb1i648nyKkzrcvz8Tzpa+P8GiPSU+ZNF5f6Tr5O0j34wRPDD990cZwAZn5GQRcZ+fkpMq3DA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfx2gLiDdbTQCZftkUnqkWcZ0L9UfsBF/czeE5UqdVw=; b=PyYcebXmpYaEyW+zhBiw8HcqIjHMQVwdAMUaReMS+QeeSNRPG8ld9qsXknTJy9wkzhQuF/STNV/2lM9/+WgPbXpFxg2GH0EcK0SC4mVvg/i7WQHV1T+6ExSYNJBS2SsnMhiXiBJ0e/+AgkQDN8J3h40ZspWvvzsXlYcUiBJLidsPvh7yc/qlXGr1rFiXCwUyBD+dUcN4+o1myTQYOqRgpp/BcUhrOvGbotF/52a/vW3GfnnnuSjfU6w6/SvedklLZm62o42MvOcwahsTHnGTHcHPSQhqJn6gigcmT9+ahAoDVTikHeOtXwA+uTSroha044OQP3kEC4ZuG6JQ9/ssnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tfx2gLiDdbTQCZftkUnqkWcZ0L9UfsBF/czeE5UqdVw=; b=iMGBE5XOYWoQ4WmU/cwxWPcO0PYEaaU1G3BzHQrtGtREHlwyH92HfbrA4UPWYQl9p8gzVr0/DlJ7ZLfZrFUihkRhdRBB938rRe8dlDAwgA5LFe42sWR312eqm866V/Tpmp6VjOgwXUMPWXAYmvR0H+yD/Kuya3uW6m+Un7VfDaMrx493uynKK3KQC91BrPilunjmLwIRD07j6ys2D7hapk/o2CVHQXmtRFVHezEmhcyUvE8sDrrRc6e3dBjd4N6LMLnsHLAJ7lAR4L4iJaSCAPmgEXlJAUEEsJXG84GW+6+UG7VU8ZTpm5M6VajUye9hu0VLcoe4SynUtrNJhiZ09w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41876fdf-862d-bb6a-7a34-0d1db9183716@suse.com> Date: Thu, 14 Jul 2022 12:51:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US From: Jan Beulich To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> In-Reply-To: <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0154.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62739ffb-aed3-4b79-243a-08da6586d807 X-MS-TrafficTypeDiagnostic: DU2PR04MB9145:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CX501OCnkrH9YkLZaW1evndzSZ1i4ebFiV0qeW2rvrWmefVNcyp4qwSmzx/NmRnC6zWum/lbKO5hxDrhRX4dvvSBFJ/7jFdhTvvw4xwMqbfqveucLrMSEHGIA/boKaUfw+I4ggX55BcHxAFqHlgeMI2mLbjI7rHvEsN0GWSHxTsSebhugnuX4XXobXNPVQiayZvqRfYOl/3qxAUy/Q8JaI0iN8sadd323dpPmXU2rYIOjioOWmeGwOs/4t9SwCQncfuqJTkmLprJGwi00KduZGKYh9aohDWAIHTxAayVq7WRrgOKM133TyXwQxUXgzksYv1RcXp1hVaqvVi/X6h82GO9y/QJ1KNcKHWokx8Yl4UyRSuXhP3p01aqpxcklF5KsZjbBdwH7JEjIUHyE2e2Thx2FkmZbaCXEk9PqKIkqJ2UG6TtwbbHydYb0nOG4epndGJxy/ma2mRXghZ3W+vfYL8pQCi49KqZ/mVOhHThPS5iwjgC6DkItY+WrWIys1l4bDZNCdlVeOs+HadM2eSE5v4kgXtrLxi/keSPz/YoiyQcmjtF4giTGcOHO1rImJfF1kxYZY3ByMSf4OHFy6341/DmKM/D07F7wFSVLiPAWEd7SVzb2nU3VGYuSLkmtb/I1sO7ttTcLLMqPiNQ9E34Ri5wlelI0NrE4rnmujcWUIxERpeoxLH4wWPkYNfjfvaqhpRxmnIdcgfZM07smFJhLiUISVJvfDQsdPuf6AZHPhvyGcNTsjsatI0nwaiP10ScDGO11+wB8ttlX6JbS1raQyH+26WsNj0YevULpcP88wwXZ7waecAc4zWxr3CBoI5OzkvcdpVrxVezJIMpjK0Q/l4QD0Ze3/QbkK1wK1W5BGo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(366004)(396003)(136003)(31686004)(36756003)(8936002)(186003)(66476007)(316002)(86362001)(31696002)(4326008)(6486002)(6512007)(54906003)(8676002)(66946007)(6862004)(66556008)(26005)(478600001)(5660300002)(38100700002)(41300700001)(83380400001)(2906002)(53546011)(6666004)(2616005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eGFhcFNSVjgxOVBGODRJaXhQVFJTU3pGRXV6eEdkZm90c1NOQ3JxMldvT0JC?= =?utf-8?B?YkF4WjVBVmdnVFhYdVF3ankwZGFIQjc4Q3FoeURzc3d5UXA5L25YVVBRaEl5?= =?utf-8?B?WmdGL20xd014L1VWVXRMSjY0Z2lJSmxHd1NSNDNESWphN3lKZTFQOFBsY3VR?= =?utf-8?B?ai8xZGVnQVNqU0MxLzJnOGtPMk4zY2NEbTNBaWJyRlorcitqMkZxQWN0L3p0?= =?utf-8?B?dFdCbWhjd1N3d2RESGFzT1E1djlHdFJRRGlQYnlUK0hsMmlJOUhvNFRxR0t6?= =?utf-8?B?SDdNa2pNU2hjY0VJa055WklwL016TXRKeHJZeEo1VHM5eSs4L2FsTmdtT2g5?= =?utf-8?B?WlZvSzhlVTRYK0dFRDcrU2x1dVZXQ2EwTVlMa0pSaHRpMHI4NEVQSjVIbGtJ?= =?utf-8?B?UUVTdXlQejRpcThFSXVVUVhEeTJUOW1GZTN4Y0dvUHZ6dzhJVExzSkg5ZjE3?= =?utf-8?B?QUtTRGdYek9wTisxN1BCV0JVYnFEWFBIMDVpblg1OVR5dVEzek1SSXh0OU45?= =?utf-8?B?UjNrcHV4NktMMFBkenhXSWFKWVBpN0ZtNjVTeUpmUmJGZ0xVV2RXbkE4VWNF?= =?utf-8?B?UmpUUUZwVWNhTXQ2UDRoNlFlb0ZKUzI2QmZOTzZCV1RYSFk1YjVscWVFTWlE?= =?utf-8?B?VHNybVgwSC9tMmNqbE9ueEYvWnZEMDhUeEY3eWo1MmVYYmdrZURQclZicWZU?= =?utf-8?B?RGJmalZZd1o1dWZWcENjL0dTZjRhS1NsSmxXQzFyb01qdVFrMVlQcGRFK0dM?= =?utf-8?B?L0drZStuWlh1ZmlyRFk1OHRzUG4wVEpMR3ZCdUYwN21JVGFJbFY0clJhMGNB?= =?utf-8?B?dyt4aGZqYlhaRlgvRzdUL1ZtWE9lQklnZXByNkUyLzRPUG13Uzk2M0hoLzd5?= =?utf-8?B?eFRtL3FqQmRUMnVCNkJRQXFCMUZmUm5SRmc4VGxJRGxJWG01a1FyaUZBVVJS?= =?utf-8?B?SkNpNUxpWTI0YmJla096cEs3MVdCRWZubmkvOGtocWZVZkZtMjlSbGtteGxU?= =?utf-8?B?S0RlbDZ2U1IwRkpPTU9sVE16bEJRRDVIWFVJMFVOZUE3blNiTEI1dkZoT29K?= =?utf-8?B?b0NMR0U3bzRzYlExQnphUWpQWCt0UUJGUlNRbVdBMW9odjA2M0syL0p4UXVw?= =?utf-8?B?RjJMTEhxNjhRRk1CM3FibG1jSlEyS1paZk9hbWlUQ3RHVWR3eWd6VVNrUCtT?= =?utf-8?B?NWVxam81Ny9ndFo5Q2tLMC9aMDhXVkZnZDNQdU00V0VmeXJBOUplRnZmc3Y0?= =?utf-8?B?NXFiNWFZUHIxUGdzQ091c1JraXR4WFdKT0twbGVyRUdmZ3dZaDFyYk03bUpB?= =?utf-8?B?Ylc3TWFuZmZRMWRBa1lzSmZjZ1RoYU8zZkEyeVJMc0prWldWa3RuNzMrblFN?= =?utf-8?B?WWpxZ3dpK0dGaGFkOUsxTnU2em9Ddjc1cEw2dzFjTVBNNzdDMExjbGY4UFFU?= =?utf-8?B?cXhuaDhlTGNMUHRPSEV1V2xCWHU0dmVtU1dvTUtWNFFyV0s0Slk0ZzYvYVh1?= =?utf-8?B?ZzZyQWh6dnRQS1NsdzdRWFRQV1dtK3ZVWGNtNXM3aWU1U0NUSUhRRWxtcHRo?= =?utf-8?B?U3FQRGU1Q3V4MGFzUzdpdnhVNlZsalJBRWRHVzhRTjZQYjZwVFBhM3RHcitD?= =?utf-8?B?NzJFUmNlTmdzZjJhRTJTUGNva0NqZTBvOW53elFOWk00UXRrNVNSUEt2RjdN?= =?utf-8?B?NkVZN1dCalVSajhnNk9ZamM0c2N1QitiTWdCaEJzSTZkYjNZYzUvVERpZG9Q?= =?utf-8?B?bzVWL1pSTjd0VUN4SEk5dmk1RTN0ZEFnZ0lBMFkxT2lzYWl6aWVTZzM1WG1M?= =?utf-8?B?aXdoU3ZadzFpLzU2M3RlNjVYcnVpZlNFMW41MWJTWW9VU1pnSkdXWUdUQTJ5?= =?utf-8?B?dHJWU09OU2JoWm40WU5NMFhBM2hzOHduNXBpdmJSdnhRYk5MamVpN0VoREhP?= =?utf-8?B?RHc4L2R5RkJMazRINTZ6SXZYN1I1b3pIckk0YkExTzZIVDhBSkY1bWFZeDVp?= =?utf-8?B?NVZWeGJVTHpubEZkY21QakZIdUhKblNjRm1zN003YWU4dm4vRFNlSFZUV0ZQ?= =?utf-8?B?a1VZNjdCZ3RnaXdiUTdMNVV5QjBwSG9iYWpzQ2JDWFVRUWJFR20yMTliWVdF?= =?utf-8?Q?Z+nYgV5z1WHgBrR4f0+HyqAlR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62739ffb-aed3-4b79-243a-08da6586d807 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:51:45.1653 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Umm/OcyfOZ5O/49DmQ03zAKXQtsQdvkdlQEMyuneGEy4Y0Srs823L9PrM2EQOcR4MQKwApBHIZ8KZVGhI6c5/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB9145 On 14.07.2022 12:37, Jan Beulich wrote: > On 14.07.2022 12:26, Wei Chen wrote: >>> From: Jan Beulich >>> Sent: 2022年7月14日 17:58 >>> To: Wei Chen >>>> >>>> How about update the table like this: >>>> +------------+----------+----------------+----------------+------------+ >>>> | original | | | | | >>>> +------------+----------+----------------+----------------+------------+ >>>> | numa_off | true | true | true | true | >>>> | acpi_numa | 0 | 1 | -1 | x | >>>> | numa_fake | x | x | x | fake_nodes | >>>> | enum state | numa_off | numa_off | numa_off | numa_off | >>>> +------------+----------+----------------+----------------+------------+ >>>> >>>> +------------+----------------+------------+-------------+------------+ >>>> | original | | | | | >>>> +------------+----------------+------------+-------------+------------+ >>>> | numa_off | false | false | false | false | >>>> | acpi_numa | 0 | 1 | -1 | x | >>>> | numa_fake | x | x | x | fake_nodes | >>>> | enum state | numa_fw_nodata | numa_fw_ok | numa_fw_bad | numa_emu | >>>> +------------+----------------+------------+-------------+------------+ >>> >>> Well, this makes the table complete, but it doesn't explain how you mean >>> to fold the settings of the two command line options into one variable. >>> >> >> No matter how many separate "numa=" parameters have been parsed from >> Command line, the values of these original variables are determined >> after parsing the command line. So the determined status can be mapped >> to the new one variable from above table. > > Hmm, I was partly wrong - the initial values of both variables are > indeed set from just the single "numa=" parsing. But later on they > "evolve" independently, and multiple "numa=" on the command line > can also have "interesting" effects. I'm afraid I still can't > convince myself that the new mapping fully represents all originally > possible combinations (nor can I convince myself that in the existing > code everything is working as intended). Maybe the solution is to make numa_off common but keep acpi_numa arch-specific? Then e.g. the replacement of srat_disabled() could be int numa_disabled(void) { return numa_off || arch_numa_disabled(); } with arch_numa_disabled() evaluating acpi_numa on x86. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 10:58:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 10:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367540.598595 (Exim 4.92) (envelope-from ) id 1oBwXo-0001bb-Us; Thu, 14 Jul 2022 10:58:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367540.598595; Thu, 14 Jul 2022 10:58:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwXo-0001bU-Qo; Thu, 14 Jul 2022 10:58:08 +0000 Received: by outflank-mailman (input) for mailman id 367540; Thu, 14 Jul 2022 10:58:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwXo-0001bO-Cv for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:58:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7758494-0363-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:58:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9390.eurprd04.prod.outlook.com (2603:10a6:102:2a9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 10:58:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 10:58:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7758494-0363-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aZqcYvpiRaXgY1bNUR/e5Gmv0re08+59jd7RbExT3SOo/6Qy/wGGkuWDcAOG33Evfqe89+bWZqpV9VZ+5Ou4a+Dxi3qv/CmNlicbe1x2hkpZSmXE5txUYTXcuYlOhippl+hZGosUZQakZ0CblduSpSJUTXlzRxVrvriCJRspWGlSrmBI6G9nmnKCVI9igphNVatH54ttECNxyV/XdJwI23IV7/eKam+ipf1+bGRmJCjAL7H/E1p9AjqMQ4+18Y9uQS4tLf3T1hGMpx/D+QP55UlA4NG+R5ROYZjSxEGbRLpOvB02p0s91wm2pUWHaWkX4t3jsE+ODCZ4roptyKkyJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Bibu7jyJrS/qbbXSfecX2SbhNuCbugRY9QRrHx+y2m8=; b=cWDyEq7QeuqoCKJqXTshmq4w+CCvUsAEf2jgePe2jV2XlQGNZLl3jaDcgOIxb81N4vRoIjJVcbEICK4TfFApGuAWsfcLqB3Wiftuq/IURQXHAuVwhmlg0jdAkwjr0guT2vGBlY+OEr/kMSmkgse4lFkLV824kJegYjV0WHiZ6a0CufrZatQoud6mVRnzTIktUyU3O4bMrtKi/ZVnjOQwuQhi5sEHzvkgpxAd+aYJU+ZiA4yQo1KcoXIqZdWHeIMj2SVykNfO/F6pkfVK/b988SeZGCVcHX/VefK2a5APq1x66+P3nIpJ9gZ3XgmitRHUX9IVNLTKkLN1CNY/frDTTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Bibu7jyJrS/qbbXSfecX2SbhNuCbugRY9QRrHx+y2m8=; b=XOdpvfpl21nDz5Cjj6C/nyUnETAXmMdZPRuvxjxdCWiJb28so6CzulZ3Xw4rQDESsREw0wYzXCfXq1loJOuteGrYNzw6uzlpcYnKDAKypQqVlKOuDyL6vi60DlSOXH8uykfnosddgreN1pZkaQzIkTg3BZ7L8D9amLl+R1y0kMwbbwWjg5GeXwK0+s75Xi4HvHthQpGyW1qdZp9pbYJGzPNF+4/T4zAIzgVeluRL5tT1W9qcwDKBD/dAOOmI54P54qMLaabqM6TOknUnkB5LKRlAKIVyqm0CI4pt7/SsBoCLa5Oak25WjGPWLs/EjnWZI+d3kUErGZ8+XeKyetvs0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <94652840-c563-3424-d2d2-70871b39ad62@suse.com> Date: Thu, 14 Jul 2022 12:58:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9eaa0da-ac2c-4681-8fcf-08da6587ba68 X-MS-TrafficTypeDiagnostic: PA4PR04MB9390:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o7M7eV8TeblZWdeT+cTce0iXJs9O5tzO7y8YqPbHCszrAz44xIfD5ZkL1V5OFraqZtMLuilq6Wa937q15qubtXrihPfq4P2P7VOujGT+CAuajBOE0B8OKcB0U162KfD5ZTf2vbBSEK7Rf80N+aFGP2msr5RQwlddfMqLVYExMik5G0zFdfCMpZQGxM47rkaT5jRn843H5ySe8aAc47hz0cD1yyb8HgxjP0l7DZ5N5bA+eyaUL8pEtnyllT5it910r61EUd6OJwhZhByW4IvMrTSV5QTz7AE3DhunhB868mNig8aB8hHHPcHAcEYqC4bnxBg7tD1uNyNwmJApHU50FVBEzoOFiib4llvQ2PxzT56Ir3WAJlFWi5Z1SU/CDOH/bJ8EJyM2FxYhf2ZShJ9r7lPfTlM4bpTof22PaztsLjVgpvBDMGqkdlISCM6QEf1vm2vBfOf3DVKeA5G52H5nBxcrWek2feVp2rGzLt9h2i+s2Msfyir4esySfC9qFyui01SSwilwZK9Q88sRgWmNN9U2E1GOptbSEQAx2BYOJZxhtOZNYVoPWgPpLk3Dk718Bim/mz1jVarSIGPu3wukpWmwoWMsmuThDDtwZG99R7aJQZ7oWMKmmkRbsb4tkdoosB5umZcwK2DL8AMccdYv9g7gJSV/a1TDVz4z/LlN0B88X/AZzBGGQACvnBoPlar06WFZIg2PxBaaZil8X+SIfLBArBLjfzsjKxvEqa2juUB8wmpHHY2kiFUP5qDdZFwwqH69Q55/I8aCxNebWOWMCUQPPD+i3cnbwpYb3K1guEwRZSZpoBUsa1Vo7ov6MTcpvIasFtm8a50M3WOwRfrxk6GvKNFbIdtK9hHaIZH+AG4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(376002)(39860400002)(366004)(346002)(186003)(8936002)(38100700002)(66946007)(31686004)(2616005)(2906002)(36756003)(5660300002)(6862004)(66556008)(6486002)(66476007)(8676002)(478600001)(41300700001)(26005)(53546011)(6512007)(6506007)(54906003)(31696002)(4326008)(86362001)(316002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VW40S2dYdEJNZWlLSk9HRHB4SGx4bmtuSlhmSDV3OUphS01xVVR4bFRiNG5O?= =?utf-8?B?VWV6Ry9aQ1pjMFA2SDFTYVR5NXliVWtjUG9zcjQ2bVFneXp2QWlVUkJuMWQr?= =?utf-8?B?TjkxUllSSk5QTjdjd0tZa0dmUzFhazhSWk5KWEhaYkJROVAxbkVsVFBNZEFr?= =?utf-8?B?MVFqS0hQUG4vZFFibjJmeEMxWGZXa0VRNnRtNDEzY3JSdGQwMVQwUnJBS21F?= =?utf-8?B?ZWlmeGQ0NjdnenpxRU1BTGcrdUJ6SmhiMm1VMEFLRXRGb0haVWRhcUpVMDlr?= =?utf-8?B?TXBlT0JKeDE0N21rSGtkbDBabkU3cHBBS2tDc0dPYlBqbStqQmZENysvR3pW?= =?utf-8?B?RTF4MHRNZGlYY0lpVEdoVHZNdm1Kd0xqWEhBbHlOTFlwSmpnTUtxRVlEOHVW?= =?utf-8?B?eWJ5djB2dWwxWFJJcDNITzFRZ3VaTUQxOE1aOUVXRHNsSTM0TlBFbXRWc0hr?= =?utf-8?B?TG5XVUtNeWozbFBzazJMZWExbkxMeE1XYStsc1NRUGY4UzBndUh0ZXViblhG?= =?utf-8?B?NGN0NDBKekNLbXdPK3J5OGVRU0hCbmdpckVmRElkd2ZJMzRLYWk1bUxzbzVE?= =?utf-8?B?dGtocjBMeW5RM0U5ckdRdU1JdDN3bEU2QXNJcUtkejk2OUhsbjdpcE92WkNp?= =?utf-8?B?Wng1MlN0aXAxL0VyaGR4dUk2cDBjWFN0UXJRRHJYbWN3eVR6dDZpZ2VEWC9K?= =?utf-8?B?TzYwY3NwaWNpMlNIbU01NVEzZWpyMXpqaEx2MllJUGhBWldvcGZOaHRnL2wx?= =?utf-8?B?R2RrclU4cjB0MGlGSmhXOVI4UTJoSXpHZi9YL2E5bERDTjE0V3FYdFhQRk9O?= =?utf-8?B?S0dHa3VSTEYweVIzS1RKNHRKeE9rS05Fa082c2N5YnpmbEx6S3ZPWFZWTFhQ?= =?utf-8?B?ZU05RlF6NGFVRmNlcFFMWkh2QkhkdmZkR3VLWmdTZzhQS05UTkdDdjhhMlNh?= =?utf-8?B?ZndFVWYyQTBSOUJCdEgrWnVBMG12aUpxU1Viank0WkJLSDVNK2FFbEhZKzdW?= =?utf-8?B?Sk1Mc0ZHTWp5NUtrMTlpcDNKTDk5U3UyaG5USUdyMVU3UThkWTY5UjRQZUdD?= =?utf-8?B?Tk9XakJENUVueVF4RGVIV0hZMGQ5c3FTcnpDMjVVMjZQV2FjVElZaVpZVXUr?= =?utf-8?B?UXZMeWw5UnhVNUlBaXgveFdBMXd1Z1J2TU1ia2ZicjFnVDZEMXhIQjVQNkY3?= =?utf-8?B?dUdEOGVDRncvMDZFdE4zK3pQWG1DZjN0QVlndXJVS3ZhK3VtSXpyUjZUTTN4?= =?utf-8?B?bThRVnZlV2p3b0I4TSthbjdKSi9zOHgySjhMaU5KQUdqNmVkc0tlbDJieVpz?= =?utf-8?B?Z3Y1dU5pVC94L0lEUVpORmF5S0d3eVA4YWpoYjR2RVZEdjJIWHl5ZHk2WkRs?= =?utf-8?B?YitsYmdKZzYxRnovMjk0SnBxNDhkcmZRakhLeUl0SWtoY094Z1VRU3NoMnVF?= =?utf-8?B?M21qdXBuaFpEYkM4UDBSbHFMZFc3TlNGUUxLVDcrY3k5VTVGc3B5bjNNTUVH?= =?utf-8?B?VXJWYWw2dEE1aDJ5S01iL080MERMUnBmWFdidEkvNkxOWU9HR2hleW83a2Yy?= =?utf-8?B?RkxJWE5jTHJUVFJCY29haUlHUTZtTWwvQmU0S3NtUHUraEMxU0lLOE9rSmtZ?= =?utf-8?B?K2lpNFFuOE56TFRpWlJ6UnRIcmNVc0ErUG9venhCRG1wZFpaQWs4SDl2TVRa?= =?utf-8?B?M215NHdKdk41VHFvRklKNUdQL1QvV3dFVzRhVmdmY3phQ3h2UDVsOCtXbEgw?= =?utf-8?B?SGxvbzFEeisweUxGdFVncWFHSHlScGxuT0tDZU80RmYwMDNHTXp0Mi9OM2hB?= =?utf-8?B?YjFha2E5akh3RTBtcXgvSklDZ1lLcmdDQ0ZlNE91OU1FRFhRNDlMRTZMbXky?= =?utf-8?B?K1JPREFyUW8vcmxCTW5XNGVvb1VCRy9HUWp1Y08wM0E5eTdQMnJvVzhsUHJz?= =?utf-8?B?VFdqRWVXTklBK2ZJWjhHd01WOU5KZzVFOGQ3RUZzbFVod2tuOXMxTncwY0JD?= =?utf-8?B?RUxkRHZERjhndzdCcDMrcXY1UlZpVFVHUHVmamVldzdHZmRmQW03SWxoeUdS?= =?utf-8?B?aUo5aE55cWVqYmo4cDFnK1h4ZDNhRHFTMW04QWdKV2xIYmVhMXJVQkdkeEU2?= =?utf-8?Q?QCPDXL8PaON/1RzkSo3SJqFzf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9eaa0da-ac2c-4681-8fcf-08da6587ba68 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 10:58:05.0626 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: X9+Wy+CSnmB1+xKU9Po5q6c0IgESAv5PU5F+NusfTVVrUGlOVvBQmfH4owQatFkiAj6MCXmQoKJv1Umig2hv2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9390 On 14.07.2022 12:49, Wei Chen wrote: >> From: Jan Beulich >> Sent: 2022年7月14日 18:37 >> status >>>> >>>> Well, this makes the table complete, but it doesn't explain how you >> mean >>>> to fold the settings of the two command line options into one variable. >>>> >>> >>> No matter how many separate "numa=" parameters have been parsed from >>> Command line, the values of these original variables are determined >>> after parsing the command line. So the determined status can be mapped >>> to the new one variable from above table. >> >> Hmm, I was partly wrong - the initial values of both variables are >> indeed set from just the single "numa=" parsing. But later on they >> "evolve" independently, and multiple "numa=" on the command line >> can also have "interesting" effects. I'm afraid I still can't > > Can you provide some examples? This way I can better understand your > concerns. Take bad_srat(): you convert "acpi_numa = -1" to setting numa_no_acpi. Yet imo (matching the present model) numa_off shouldn't be affected. While your change is fine in practice for (current) x86, it is wrong in the abstract model (which is relevant when making things common). Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:05:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:05:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367546.598606 (Exim 4.92) (envelope-from ) id 1oBweR-0003AI-Ko; Thu, 14 Jul 2022 11:04:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367546.598606; Thu, 14 Jul 2022 11:04:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBweR-0003AB-HC; Thu, 14 Jul 2022 11:04:59 +0000 Received: by outflank-mailman (input) for mailman id 367546; Thu, 14 Jul 2022 11:04:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBweQ-0003A5-FP for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:04:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBweQ-00026v-6A; Thu, 14 Jul 2022 11:04:58 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.239.30]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBweP-00079W-VZ; Thu, 14 Jul 2022 11:04:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=k+C4Rb4cxBkM7+iec7DRe88W2zTuy1OgOYLFKsmSElw=; b=HC6/TV5GXjy0COhkgq+CiY02WJ UtXAK3V2xHhnnghc6bmqvEpYP3Td16qxao1Oh2Zfb3vDTdFDi3Tzv4JdUSRBXu8wKNGf9YD28a5XI J37RAwm6j4jhrQcutH8OpO784V/qWvwOLBArpG2WGjIstDa2YcSPsfTjEfwMudz+0nkw=; Message-ID: Date: Thu, 14 Jul 2022 12:04:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] xen/arm: avoid overflow when setting vtimer in context switch To: Bertrand Marquis Cc: Jiamei Xie , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk , Wei Chen References: <20220706082558.1116811-1-jiamei.xie@arm.com> <0847A13D-967B-450D-85D4-3D644E821905@arm.com> From: Julien Grall In-Reply-To: <0847A13D-967B-450D-85D4-3D644E821905@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 07/07/2022 16:35, Bertrand Marquis wrote: > Hi Julien, > >> On 7 Jul 2022, at 16:33, Julien Grall wrote: >> >> Hi Jiamei, >> >> On 06/07/2022 09:25, Jiamei Xie wrote: >>> virt_vtimer_save() will calculate the next deadline when the vCPU is >>> scheduled out. At the moment, Xen will use the following equation: >>> virt_timer.cval + virt_time_base.offset - boot_count >>> The three values are 64-bit and one (cval) is controlled by domain. In >>> theory, it would be possible that the domain has started a long time >>> after the system boot. So virt_time_base.offset - boot_count may be a >>> large numbers. >>> This means a domain may inadvertently set a cval so the result would >>> overflow. Consequently, the deadline would be set very far in the >>> future. This could result to loss of timer interrupts or the vCPU >>> getting block "forever". >>> One way to solve the problem, would be to separately >>> 1) compute when the domain was created in ns >>> 2) convert cval to ns >>> 3) Add 1 and 2 together >>> The first part of the equation never change (the value is set/known at >>> domain creation). So take the opportunity to store it in domain structure. >>> Signed-off-by: Jiamei Xie >> >> Reviewed-by: Julien Grall >> >> The commit message is my own, I would like to Bertrand or Stefano to confirm they are happy with it :). > > I am ok with it so: > Reviewed-by: Bertrand Marquis Thanks. I have committed the patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:07:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:07:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367552.598625 (Exim 4.92) (envelope-from ) id 1oBwgT-00044w-Gm; Thu, 14 Jul 2022 11:07:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367552.598625; Thu, 14 Jul 2022 11:07:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwgT-00044H-AT; Thu, 14 Jul 2022 11:07:05 +0000 Received: by outflank-mailman (input) for mailman id 367552; Thu, 14 Jul 2022 11:07:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwgR-0003yf-T6 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:07:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1351bc4d-0365-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 13:07:01 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 07:06:49 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB5970.namprd03.prod.outlook.com (2603:10b6:610:e1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 11:06:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 11:06:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1351bc4d-0365-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657796821; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0TEMu2CA2U9x4EFs+YsQVGy8ZKemKxwsGT058D5nLX0=; b=G5+26mTEJgD2CFhzFURfGJ558wAUQ2/XwPneBAnALcCpH5x1rgVBfZ0Q /TKFGRw8lD/oEELUTAU3RvjV/QJYxWW7vnWeVK3HLD62QnEwxExTE0itx TQ9/kKkoug/zA8XWVoYA5IwvNHXCN49MRFDYlA4cRxSDUYZClE43LiQDB U=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 75601274 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:6eWM1a0ypvzXaFWqpPbD5Sxwkn2cJEfYwER7XKvMYLTBsI5bpzRVy GEfXzyHOayDYmegeNh3a9yw9kMDuMPVx9dgTQZrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8U835pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj68xRJX4VOr1HwL4pIm9Br tcDLg81LR/W0opawJrjIgVtruIKCZCyea865DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ya5KmIBwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTAlGTdqyjz2ocjmwurZMU2Drmp1MRxqw2W7EMQUEI3eVyS9KzRZkmWHog3x 1Yv0igkoLU29UerZsLgRBD+q3mB1jYMVtwVDvY38hqlzqvP/x3fFmUCViRGatEtqIkxXzNC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmMtw9TlupB1sRvJQf5qCqvzhdrwcRnU3 juD6gY3gb4eicoW/6yh+BbMhDfEjp3AUg406xiRQmu/9Ap9TJa/YJCv713S7PIGJ4GcJmRtp 1ABksmaqewLU5eEkXXURP1XRe7wofGYLDfbnFhjWYE78Cig8GKieoYW5yxiIEBuMYAPfjqBj FLvhD69LaR7ZBOCBZKbqaroYyj25cAMzejYa80= IronPort-HdrOrdr: A9a23:rbOEEKBrBMDp4QvlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="75601274" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqLgNdYTIpdh3StDRfaAf5kighAePxkxqyuVk+F7tdFlAO6QDn99zQ+spHJg2JCU+f1i1U9Abx1qXwpi3AXX3O+0IQqEB55mUUmkqnb+6DY+TupX/JX1JoZRZdqQX9NGcJsmydSwsb/hMXnzS/kGED/8YvzAKpoc3E6wBIzdbH24p+cZvk2OiaoiwDwoOiqfGnhy03vBYfqT11yx43oyFjh7M9QBpZAvoC5Sdj2puTJ54CAvdXEQot3yLiCO0b1eHnG6aiw4huKYYkhPPpDhJMxAu5DNkV1FgFII3Xgv2OU9xKjcrp7IIe7QG37ojPNqNqs3xSOQxSdRHuuo23KPfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0TEMu2CA2U9x4EFs+YsQVGy8ZKemKxwsGT058D5nLX0=; b=PP66atG0XLgwt/p383Wmh3rGXi9HloeRHv9284C29dXw8o/CI6xk2lePVaZPgxvPXWK/9x62sKz24wB3z1uRpKuogg6VQpYVczpiQQZ2J4kudsA+x6Hha7gByewjXeTlZP+rOtFUTrqlh9UoMmKnQtUDHZfichPc4qbOqZL0AhguvO3wvDFPInFAA3sFpl5zdukeWp57lZW0KBMXFt8b/QD2ggm6/GLZdfhJU1kt8xPdcK47PLSqZzFdDVQSiKed5znTAIIS3YUNFqAyFIC4Lqu93WWapBzE8zefmLP12vHQmPmLQlb/6c0eSJ79hvfS4zhk+62CqzCaeN2/C8nzEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0TEMu2CA2U9x4EFs+YsQVGy8ZKemKxwsGT058D5nLX0=; b=iUfKbjSKAkE1kIdD5PtF+XFIjmu+k/H/bpVlnMZ5AL8/dim2z77E+6LNOQsO3UrRWcWzA3LieM9bLGe6XOmVb6lgHfjA4oPyN7OV2vpRYOp9F/VO3GelOSrTInMeIk5GX+gs9/EEEm8hap4SLalNQeu3CUe8r3YMr8Ny+t/dpjo= From: Andrew Cooper To: Jan Beulich CC: Xen-users , Roger Pau Monne , xen-devel , Henry Wang , Luca Fancellu , Mathieu Tarral Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Topic: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Index: AQHYlsiZU/X6oYzkBUqjI0g62JIGmK18caCAgAAKCoCAAPuhAIAAJpSAgAAJHQCAAAWjAIAAAbIAgAAHvIA= Date: Thu, 14 Jul 2022 11:06:47 +0000 Message-ID: <2e761a65-f24b-edb5-6a7f-cebf47d51c68@citrix.com> References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> <2fad8072-e5f1-2302-f01d-82f744606d9b@suse.com> In-Reply-To: <2fad8072-e5f1-2302-f01d-82f744606d9b@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d8bdc9de-edaf-4877-40e6-08da6588f23c x-ms-traffictypediagnostic: CH0PR03MB5970:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KRwR9EYlM38osi7nX0z2tgkJQ54+/qMmm331Ayus2FIFonWiBHKhN05/sw7uIC8bunH3yjvsIRvYFAfdJzfoH+lSzPgyH0eqRQb7rgqNBLsYK22aSoSlwHPG9g8O26Ngyd4ROU5lnHG6sEUKc1TiG/dLPnXGYA52O9aM5PvGPB+SRt2IKutOTnZDQhploHtD+iIgoVbekYNe+ThQgrmaMihClTV+zE4UkDEow0lzc2Md+Hx3maXMsgHcz10UZL72d6TGa1HkVmiHbOhO9ZT/Kvc2+vaJRqmqhp3CHvWYeVrSnW2VMyWrBQncG9UIlHrHcw8YuZ1kpuhv1h8dV4vnLpVd1SHfnYt9f3gStPMhpZLM9wYSIcGjQMboG1A4zkwO1c/PmdhR9bh67nfJlu7Sgii9qkSFlKSWcFy1Tv/AiL6GCoshyv/wJ+RLWMStGVSwNZFML3fePdL3Rr81gpGqjjzNDhhZk9TyWGGdPJFqlTly2gRyV+HJ1UoxwiLqeV8rZK3fkhx6+YF3PCO1nnohmtcl4gUIqQN+LYBk+T1wsZpECz/EwwpgkN+yuqMcnC7poHZhV2KVhknUHVGaWa4W1QdmNT/V3FpWv6uAbjzGFxFspazlmmSorzYIN+b7n2z62UUWmqD2/MVhthjykLAZzj0HN5kIqhsryvPaLDfOy7HttoJYJZdcDhhNQ7p3Ilrrtmy3lg6qXAOrzqBOGDwzBq6xtDcPf0H+/nrlPFlYl3VnYMdOGFTAX1NHUKqlFZwEQj1z7DQoOA4V5Jrljhm0wMaFb3dPPVTyd6xVxH+kFZBBxGcYG9DLzffFRERkOqSVkydzXqfB3kP31OuAGT5buAop1B4jlFdr9pH0QQD8bsVv6NCAdcYEZWi/19ErEpBOEoZim5c4qr+IxxLiCjRsOfH6EfmpVKneZWHALQ3Bzyqt5uMry57LkrdsAGv434x9 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(366004)(346002)(8936002)(4326008)(316002)(122000001)(26005)(86362001)(83380400001)(6512007)(8676002)(31696002)(82960400001)(64756008)(66476007)(478600001)(6506007)(53546011)(76116006)(71200400001)(66946007)(966005)(66556008)(38100700002)(6486002)(91956017)(6916009)(36756003)(38070700005)(54906003)(5660300002)(186003)(31686004)(66446008)(2616005)(2906002)(41300700001)(547064002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cExUbWxFZDdEK0ZmZkY2SUFBcSswMTVUUld2OU5hek02TGlucktyYlhLc2tl?= =?utf-8?B?OTZUQ1kzU0xnRmtFeDlXaE9wK1NVMnJyNFFrQjBBZ1lIb2RpekQzSDkwckJC?= =?utf-8?B?bmhTRUFRb1Q1OUROK1NmVXByUk54MGVQLzZ4bVV5QVlPMTRQdUlGakJFU3Mx?= =?utf-8?B?QlN6MktpN0ZaL1VZMzM5TkJqVUt6NmVJUmVvcmZNYlIrWExHZ3dYbjNGVURu?= =?utf-8?B?OGlmWmhTcFNyNStzN29lOHFjWXBydVJRc3A4Zjg2dnp4QUJtdlNvMTV0NVdY?= =?utf-8?B?TkxMNXdWSkltbldjUC9BV2EwOXZiMCtvS0lVTDFUblY4d3hzL3MzTDAycjhJ?= =?utf-8?B?V25FOE0zYjdJWk12RVVGVGwyT2E4ZWZPUTlwS1g1aUxyNCs4QTc1RmduS1Ev?= =?utf-8?B?VTAwRHkvS3VaNzF5OUlPcXpRL0dRb2VSSE43T2M4aEVzUGNoLzRsbk9sSEFS?= =?utf-8?B?LzI5QkduMDZSRHN0dVhIQWpoeHphOEczU0d2MVJTSGUrMEhJTkFQR0ZnOGEr?= =?utf-8?B?dzEydHFUTnp5SERJNDdsaDNybUtvRUhwS1E2dlY2ZGNTZ21pUUwzSUJ2R1Ew?= =?utf-8?B?alZnT25mc21DWXVZYkRYT0l0akZnVERLeG40dTY3Ums1MEJWSy9ZSWc0YkpW?= =?utf-8?B?MnBIK3FGUDVPNmMrcHlaRzdSQ0pSc3BZYkJkY1E2L250NjU5K2JRY0MvUzRM?= =?utf-8?B?K1dNa2dEQytGdlNCL2dncWFoRkd0bU9MemlRZFc4TGkwdDYzQmtrRjROekI0?= =?utf-8?B?TGgrcDF6dVRUQmxBWDhFVExybTlseTVXQmlhK1dSUzQvS1lwVmgwbGM5Mkl0?= =?utf-8?B?UTNOS2RqUWFweVQrUkY2NHdDUTgzdVloU0dTWVpuS3VsaVExL1VOcHR0N1BP?= =?utf-8?B?SVJSQmtHR1d6bGRhdlpOSUd6U3ljdXZ6bkJicVh3OEtiaUJ3NW1kZVJKSURq?= =?utf-8?B?dGlXOGFMaytrSzRPdzIwVWo3eUFUTXpJVnBVWlgwUVVmamVYQjZQeXhIdTlp?= =?utf-8?B?Wll4d2luVmtqVzZyUUVnV0tucXhVeStiY2lzVGNnNDdOT2pteTRwZVEwU0dT?= =?utf-8?B?dGRHMEFZRThEVG5kOGZjenBnUlI5RnB6UUR1Z09RTHBMUjA4c3dmeCtRZEpR?= =?utf-8?B?RmRWQ3AxN0tOT0VTMyswYlVZemNSeUdwK25udUovcWxkbjNWTktOdVVtcTRZ?= =?utf-8?B?UkFUcS9lMjNIdlFVWnBCZWZZRVNyY1V2NWlZb0Z0MXVXbVZNeWtDMnlqODNz?= =?utf-8?B?Q0JSSDRQUjRxQTdweEREakRpOUwwSjV4dXppYTVGYmNvbUJlbEFyU05hYzQr?= =?utf-8?B?cWVCeWxvRGt1ZENXTm9YVWZTQ052RkNkQVVrUDMyTzcwMXZROVRsTXQ0Uk40?= =?utf-8?B?RGo3ajJQR2F4aStlM2d4eFhzc1dXeVZMdFFrWVpZcHdWdDVJNXMzTlVjV1px?= =?utf-8?B?YzVwVjFvQm9hOE5sTVdNRjRuTnFBdjdyN3pWWUk1MFN3NklxTFViRm4yNlVN?= =?utf-8?B?bWlBSjl5dUtSbUQrMUdSTVlSNkNFT0dJTWljbkxMOFZESXBjSGF0UHZqVG04?= =?utf-8?B?NGlaNmx1UTA1eDBTcTlTdHI3eEREdzVydmQ5SWZITjVud09ocmVWMWd0T3lX?= =?utf-8?B?YUxvSXpnL3FZaVhvanVwd0dGS2dvaklTclg0WUdoVnliK2ZJRGhJZm16dGhu?= =?utf-8?B?T1l2QlVVa0xPSzB1UkJzc212TEhteXRWNVN4V28wSjNPanVpNnQ2OWVkcGZr?= =?utf-8?B?Y3lNOTZFdlppcWMwbVRaaXNnalBta0R0RVoxZW01Y1VWaEtBN1hiclV2SnFv?= =?utf-8?B?c05seVMvMGFNT3lsWWZXczRlZE5NWFRYOWZuZk90ZXMwM0dBQTYrU2xza2x3?= =?utf-8?B?eXlXbnkxUDRVOHB5NW9WU2JHY2poV0pnbWZ5eFB3UWdrNk5JOWZQckNuQ1Zj?= =?utf-8?B?S1c5cHM2cTVqNFYyVXVocm5mQ29jelcrTXZqN2RXL1hmWHFZWTJnUVJwelR3?= =?utf-8?B?NFBFLzZVSTJTQitvLzdsaVZPa3Yvb1R0ZkFqNE91ZW8zRW1tcVhHVUJXMFI0?= =?utf-8?B?d2FmK1p1ZGJObnIvOW9wYlpQWHJTSU85Wk13MHRSNGFMUStldFpwWGMzaWsw?= =?utf-8?Q?RIy7w5NgZTSJcyKgwiQyHFOsv?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8bdc9de-edaf-4877-40e6-08da6588f23c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 11:06:47.9870 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AT+GjXAjnCUcZV6iUIwel+1pAcLuguqMX9ZaizmGEhumB42mcPKaVkyYDRS3el6zqyXln189/z2ejeh0perAwp+oWnoZCwlqcpn32rMUmKk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5970 T24gMTQvMDcvMjAyMiAxMTozOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjA3LjIwMjIg MTI6MzMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNC8wNy8yMDIyIDExOjEyLCBMdWNh IEZhbmNlbGx1IHdyb3RlOg0KPj4+ICsgQ0MgeDg2IG1haW50YWluZXJzDQo+Pj4NCj4+Pj4gT24g MTQgSnVsIDIwMjIsIGF0IDEwOjQwLCBNYXRoaWV1IFRhcnJhbCA8bWF0aGlldS50YXJyYWxAcHJv dG9ubWFpbC5jb20+IHdyb3RlOg0KPj4+Pg0KPj4+PiBIaSBMdWNhLA0KPj4+Pg0KPj4+Pj4gSGkg TWF0aGlldSwNCj4+Pj4+DQo+Pj4+PiBZb3UgYXJlIG1pc3Npbmcgd2dldCBpbiB5b3VyIHBhY2th Z2VzLg0KPj4+PiBJbmRlZWQsIGluc3RhbGxpbmcgd2dldCBzb2x2ZWQgdGhlIGlzc3VlIGFuZCBJ IHdhcyBhYmxlIHRvIGdlbmVyYXRlDQo+Pj4+IGEgZGViaWFuIHBhY2thZ2UuDQo+Pj4+DQo+Pj4+ IFN0aWxsLCB3ZSBoYXZlIGEgYnVpbGQgc3lzdGVtIHRoYXQgc2lsZW50bHkgZGVwZW5kcyBvbiBn YXdrIGFuZCB3Z2V0LCBhbmQgdGhlcmUgaXMgbm8gY2hlY2sgaW4gdGhlIGNvbmZpZ3VyZSBzY3Jp cHQgdG8gZW5zdXJlIHRoZXNlIHRvb2xzIGFyZSBpbnN0YWxsZWQuDQo+Pj4+DQo+Pj4+IEFuZCB0 aGUgZXJyb3JzIGluIHRoZSBidWlsZCBzeXN0ZW0gYXJlIHF1aXRlIG9ic2N1cmUsIGl0J3MgaGFy ZCB0byB1bmRlcnN0YW5kIHRoYXQgeW91IHdlcmUgbWlzc2luZyBnYXdrIG9yIHdnZXQgaW4gdGhl IGZpcnN0IHBsYWNlLg0KPj4+Pg0KPj4+PiBXaGF0IGRvIHlvdSB0aGluayBhYm91dCB0aGlzID8N Cj4+PiBIaSBNYXRoaWV1LA0KPj4+DQo+Pj4gSeKAmXZlIENDIHRoZSB4ODYgbWFpbnRhaW5lciwg cHJvYmFibHkgdGhleSBrbm93IGJldHRlciB0aGUgcmVhc29ucy4NCj4+IFRoZXNlIGFyZSB0d28g ZGlmZmVyZW50IHByb2JsZW1zLg0KPj4NCj4+IFRoZSBjb25maWd1cmUgc2NyaXB0IGRvZXMgY2hl Y2sgZm9yIFdHRVQgKG9yIG1vcmUgZ2VuZXJhbGx5IEZFVENIRVIpIGFuZA0KPj4gd2lsbCBvYmpl Y3QgaWYgc29tZXRoaW5nIGlzIG5vdCBwcmVzZW50LsKgIFRoaXMgaXMgb25seSByZWxldmFudCBm b3INCj4+IHRvb2xzLyB3aGljaCB5b3Ugc2hvdWxkIGhhdmUgYmVlbiBmb3JjZWQgdG8gcnVuIGNv bmZpZ3VyZSBmb3IgYW55d2F5LCBzbw0KPj4gSSdtIHJlYWxseSBub3Qgc3VyZSB3aGF0IHdlbnQg b24gdGhlcmUuDQo+Pg0KPj4gRm9yIHZhbGlkLWFkZHJzIHZzIGFsbC1hZGRycywgdGhhdCdzIGNv bWUgdXAgb24geGVuLWRldmVsIGJlZm9yZS7CoCBJDQo+PiB0aGluayB0aGUgZ2VuZXJhbCBjb25z ZW5zdXMgaXMgdGhhdCB3ZSBkb24ndCB3YW50IHRvIHNpbGVudGx5IGRlcGVuZCBvbg0KPj4gZ2F3 ay4NCj4+DQo+PiAoV2UncmUgdHJ5aW5nIHNvbWUgbmV3IHByb2plY3QgbWFuYWdlbWVudCB0b29s cy4pIENhbiB5b3UgdHJ5IG9wZW5pbmcgYQ0KPj4gYnVnIGhlcmU6IGh0dHBzOi8vZ2l0bGFiLmNv bS94ZW4tcHJvamVjdC94ZW4vLS9pc3N1ZXMgYWJvdXQgdGhlDQo+PiBjaGVjay1lbmRici5zaCBp c3N1ZT8NCj4+DQo+PiBUaGlzIG91Z2h0IHRvIGJlIGEgNC4xNyByZWxlYXNlIGJsb2NrZXIgc2Vl aW5nIGFzIGl0cyBhIHJlZ3Jlc3Npb24gZnJvbQ0KPj4gNC4xNi7CoCAoQ0MnaW5nIEhlbnJ5IGFz IHJlbGVhc2UgbWFuYWdlci4pDQo+IEV4Y2VwdCB0aGF0IDQuMTYgYW5kIG9sZGVyIHRoZW4gYWxy ZWFkeSBoYXZlIHJlZ3Jlc3NlZCBhcyB3ZWxsLCBkdWUgdG8NCj4gdGhlIGJhY2twb3J0cyB0aGV5 J3ZlIHJlY2VpdmVkLg0KDQpMdWNraWx5IG5vdC4NCg0KUmVtZW1iZXIgdGhhdCB3ZSBkZWNpZGVk IHRvIG9ubHkgYmFja3BvcnQgdGhlIGxlc3MgaW52YXNpdmUgcGFydHMgb2YNCkNFVC1JQlQgZm9y IHRoZSBzZWN1cml0eSBmaXgsIHdoaWNoIGlzICJlbmRicjY0IG9uIGFsbCBmdW5jdGlvbnMiLg0K DQpXaGVuIGV2ZXJ5IGZ1bmN0aW9uIGlzIG9wZW4gdG8gKGFiKXVzZSwgdGhlcmUncyBubyBwb2lu dCBzZWFyY2hpbmcgZm9yDQptaXNhbGlnbmVkIG9uZXMgdG9vLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:08:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:08:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367585.598646 (Exim 4.92) (envelope-from ) id 1oBwi1-0005Z6-Sp; Thu, 14 Jul 2022 11:08:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367585.598646; Thu, 14 Jul 2022 11:08:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwi1-0005Yz-Pu; Thu, 14 Jul 2022 11:08:41 +0000 Received: by outflank-mailman (input) for mailman id 367585; Thu, 14 Jul 2022 11:08:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwi0-0005Yl-Fq for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:08:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwhz-0002C5-Qy; Thu, 14 Jul 2022 11:08:39 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.239.30]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBwhz-0007KP-LN; Thu, 14 Jul 2022 11:08:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vrY0Op20dG3xf4WFqXZ3HrIBS3lGeXpOVlxhgZv8Db8=; b=TugnwwK46lxtBFCMFG35RwOoSv JFKyClScvEKMW+bn94B3DtLUjyyHDBDesR81XJYu+q3qljVcKPeDQdoLnuktA1qyoi9djuwaNyWUP A1dJcAawJOlRqibGC2BKekOvtbqhC8CnGuLABa9czde1unEsMjzuHZf10KZo6LNZ44gU=; Message-ID: Date: Thu, 14 Jul 2022 12:08:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] xen/arm: traps: Fix MISRA C 2012 Rule 8.4 violation To: Stefano Stabellini , Xenia Ragiadakou Cc: xen-devel@lists.xenproject.org, Volodymyr_Babchuk@epam.com, bertrand.marquis@arm.com References: <20220706121156.666500-1-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 07/07/2022 00:42, Stefano Stabellini wrote: > On Wed, 6 Jul 2022, Xenia Ragiadakou wrote: >> Add the function prototype of show_stack() in header file >> so that it is visible before its definition in traps.c. >> >> Although show_stack() is referenced only in traps.c, it is declared with >> external linkage because, during development, it is often called also by >> other files for debugging purposes. Declaring it static would increase >> development effort. Add appropriate comment >> >> Signed-off-by: Xenia Ragiadakou > > Acked-by: Stefano Stabellini Committed. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:10:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:10:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367594.598657 (Exim 4.92) (envelope-from ) id 1oBwja-00079Y-7S; Thu, 14 Jul 2022 11:10:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367594.598657; Thu, 14 Jul 2022 11:10:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwja-00079R-4S; Thu, 14 Jul 2022 11:10:18 +0000 Received: by outflank-mailman (input) for mailman id 367594; Thu, 14 Jul 2022 11:10:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwjY-00078r-Eo for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:10:16 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 887cba6c-0365-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 13:10:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6358.eurprd04.prod.outlook.com (2603:10a6:20b:da::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Thu, 14 Jul 2022 11:10:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 11:10:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 887cba6c-0365-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FQL/RQeGCQdd5sI2ZA6uK4+7sX2aaRu/Xl7u2ASOHBJm1VRrH5NSVnq6JnM/W6SloT4RF2NfjNmuIhFlFt4VpotZhWweNZlpyaMiZiNJzfBfBJmnhfqzW8N1Ghmz/nTBNpSJNaeOQEob5pWhb45qKl+kwizQQrlrqN/3Waa9mNTG9YGGvJUtlB+G8Z2Ce1qPxy0EUiSsSBqFE+1Yq2Fd6J0L+tXa+Uqhfapaago6w2J6AE8lefL1gk/mlHyMpnIBkYIFV+Iif9uDABO1kow/den6qnSgp5CWZ1DWsfIInCs0lpWBo//viSawDFRshIDASxYy27X21lkiZS9IOozmtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i62fDuX3E5nXSFqeJ28T1/CIrf0ZC7wQqaqTxJVT+Hs=; b=CLSHL/5r45/ZsO/WJQHIds4i8uigDc6LLd16DIbi7ZGNIumFC+LX3eQ6jkHQE20Ytp850R75wIW0AK/Hvb1Kd8RCi4C3MyFgIDJeVwiZ7Q7oDw/Wp9Cw9V24TN4jZK6YGDnlGwP9maNHYD/nGcT9LuNVjo27vDTuarNsj92akqh1WIryQzZ9olCmPMDCvxajZtUX11rJ+jE/sW7iHkhbAhkMwyrwOsigZ4U3zDYmKslsAsSXNUBQ6KLSc1UltRDD8Lwse6WNFwoJ8UJfHxcDhkopItVUAdDHV4dI9paV6X9k+KFPXlFYKxGMuCOnt2DltkKzPGpTjHpaPay2fibmhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i62fDuX3E5nXSFqeJ28T1/CIrf0ZC7wQqaqTxJVT+Hs=; b=dFwcj9ZvHYqPxAYKpOV71HkagpkwLwA14nTbSWkR6Vb6AZdq+g1i1NXrix33wgw3hJumymBB4HR91muAZuLTNRV4YDxkBhFJm3iJikaLWo5o6lIx4ipGWXB4MxTgmaVmzxZMSU/PTeKCwqdy4JV8s6/0PkSsVLUJaJYin1W9Dsjfr2oQS6td0iObarlDP8ByKIAYR7XW6A21SFxZ7PAeCIUW+ZlG32hnnz8r9HtwNk0Za38YwQvbUcXSRt/NRL+GimweWnKFnI7beLMmWHiH+BlWVa7Qup/fGccP3mu5JRjqOmXDSlpTWVDqSAPCPJukubwFoM6V+ZBGz5nr0APX5w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 13:10:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f43f3b59-b349-4954-4b58-08da65896b40 X-MS-TrafficTypeDiagnostic: AM6PR04MB6358:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 11MVpfGWE6Wg641laVuIb4Su9kTAkJ4s9vxAXXPjOc/4W+BJCpzAlJWLyL556FusfbKnjfv/F2o7oUEk+tuSMjFNTsKLG5CAS7qD7bZDBcs+xpzves8UIsm252t+9wbNf03BEq57xPY6k5+SmXwAqUZZKa5y+L9Ao8ACcohfLyoL7IIc3fdnhgjgq644y3+q5p2+u3QUyqzeS7rmGr9y8mppHnl3vK6AczBQ1YUwCyNyvnBTcjmddPNMcUkIboDnVJvsOelYaSFB+5eCmOAohpBKUjuLNjP59K7IFPs9nnj86jte5uSs5i6P9W1FpER5jolDZo7ZBtw2rAb0J6ObUTyoYRSLRNeH9jqv04pEkwUfbaSL1kkpnDysutqryBUhe+qIE41ZhnBQnUsEzWwFUIPpreKstbciU5oJomMIUszCNT56KBb3dFLQp/HCZbwsAjQr19rcvaFmfQ9ybBRcb5LGqjE/mPlXJ36QDyXFj4ISIyE5Ss3Y+mAUjAx2fpC9PPQun7fOwYv5vDyMbkEl2TlFlNipnV9Cx901D3BGfb7Jz201juFuYpLOHQuuZ7w2aYFZgavZxt4caT6nogkaaxpVz0R6168ryh4rO8uGe8+jmVp1CXWVpIgOD2ug2PU3Jcr3AaHpZaEgt9ExUOIkTTDW4d0/rhE09YSZMkbXUs80a2LYl69/TzOySI3JTd7foOHCSa9uM+agIHD0iVbnG9j/Zdc2/j9zSuWnSGSNue7dBNM5RL7OlxG+QJgZpQKezqo1ly9MGrAycmLVsC0+48vW9x8Qhu2yze63zYcE7hxzDlMBH4wEgV+0Yb7asW1QBExJGBAgOWb35lJp44/Hqaq0mxhd2kb0e+y6KibEca8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(346002)(376002)(39860400002)(31696002)(6486002)(6862004)(2616005)(66556008)(54906003)(86362001)(8936002)(38100700002)(478600001)(186003)(4326008)(6512007)(316002)(26005)(31686004)(6506007)(66476007)(36756003)(5660300002)(2906002)(8676002)(53546011)(83380400001)(41300700001)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUZkMHhDTml2MzhoQmNEZnRvTlExZzdicmlOOUE1cUtyRHBCMTVnT2NvaWh4?= =?utf-8?B?cEdIdjNNQm9JQlJjM1FqVjl5clRNdWJoWEJyMWprQUIxVjh2OHhXRzFncC81?= =?utf-8?B?bnBJVzIvcXFxc015azlkcFpmY3ZVOEM4Wm5pSlR3WW4vMHl2RmxpUXlsMTAy?= =?utf-8?B?R0Rwc25UcFpScUVBakpJZ3R6ekpZenMvZk94ckxDYXl5ZStyRUkyM3Vya216?= =?utf-8?B?WnRWMjEzT29ORGJNYzZDSGVDV2h4eHRnY2Uzc0ZhMWc0TEpkSHNrUVhHMzE1?= =?utf-8?B?eXhnUzIrMHhKV3pIVTY0S2tmUHk3Wkh4SWVSZStML3dGQkh2cGRUNnFOZnF1?= =?utf-8?B?N3A3QmY5bFJJUHB6a2Q4V3JMLzYwYnBhOHhVTzNGemNGYmdJRmdtVU1BK2l3?= =?utf-8?B?dC9VVDNWcWVMNWFkb1RvSjRaYTNiV0Y0c0VYVWxhWU5TSzBYM2hGallaeGYx?= =?utf-8?B?bXRDcnM4eFkvNzNHdVBGdldSVE1iS2Q4Q1p5QW1RdzVET2VHR2JBWW9xLzBj?= =?utf-8?B?Mk5sdUZwN0dTdlExV0J6alNDNE9aVTdvQU9UL2dwQ0ZycUdNNFZZV0VVYTBv?= =?utf-8?B?TDUyNitsdFNYS2VFdDQ5L050MjVGbHVEOXFtYnJmQzBxK1VBZ0s3QkpPTXRG?= =?utf-8?B?UUNEWDN3b3NGZC90SW5laFd1UGoxY2M4UEN3c2VwUjNJUzNTOEFiTGJ0TzBM?= =?utf-8?B?K25Mc0VwTkVEdW5reXdvNmdmQzhaZTF3QjZjWkxqSmY5WHhVbFdJMjBYNDJa?= =?utf-8?B?SlhlZlJxUmNKNnNtdEVqVm5xcUZyaWdmRGg1K215L2l0d3NIZWQxeUJQdnVu?= =?utf-8?B?Uzd6K1dGL3RZMHBDTXBTVnhXeXYyZitzQlhISWNmUWh2dHFRTFAyUmVzc0VD?= =?utf-8?B?VXBONk1DcS80M0t1c3JmU2NCUW1GUHRwUkVURDlpUWpBb0l3SFE5N2pkbW1j?= =?utf-8?B?eTQva1JJbkNtOVZoaXZJMVY3eE9qNjdocVlYMzgyMldoWFM0SGlub3BmZldM?= =?utf-8?B?TU5iTDh2SE9oWHdGU3dlcmxqN1NWekxMUGNsVG5HcFgzbEFOb3pDK3ZHNzhz?= =?utf-8?B?UnhOaGhUWnpyQ2FOUkpiWjNuWVpBOU1XUDRBMC9PNHRpZ3RkbUlEVUpCdEo2?= =?utf-8?B?dThZTUg3NkEyOUlNYnFreTM2ejQvamJhWUxQWnRiZDFPK2ExNUVob3FpU01K?= =?utf-8?B?WVZ2eHl6TDI5S2tUMWVhU1IxQVRWSEVrYUp1cDhsa1NIYWNRUzlGVVA4Q1p1?= =?utf-8?B?VkY3L0crOU5NVkRnUURLQ1VIcWY3ZmNiWmlrRVNkK2ZLSW9EbGZsdEVVS0JH?= =?utf-8?B?WFBBYmVtd1BMTzNLZ0Jlbkd2KzNvY2IrbEJSWFROTEQrZjNrdU02bWRHN3hE?= =?utf-8?B?cjNjaGo3dkoxamhaakJJM3lmM0JvU1JpdHBSZTlEdVlNeE13akRNTG9rbUUy?= =?utf-8?B?VEo4WFIwMld2ZnAwbzBYSE0vWjRmSUtlTkp0TDJCSVFsamh3VUxZU3pIbS9V?= =?utf-8?B?cEg3MzBSU3l3ZldWcW1jcWFacXlBTTlnUGZXRVRSTW9LUDA5djdRVERiRlYz?= =?utf-8?B?c1drOWZRMFVJV2Y1UkNrd2N5S3dOcnNnUVZDelI4TWdKOFZlRGp5N3BpRDRp?= =?utf-8?B?VC9BampwNlFNMEluRmZaTmJHWnZOMmEvbUpXdmxFR3VlZ3JRU0MrMVArZEgx?= =?utf-8?B?czNuN2Q2enorVm9FemhQWUQxZ3Vhbmp1NlpUaGt2c1NJblRMVG1HNDNoaUM3?= =?utf-8?B?ZXVhcWQ0RHY5TW9oT2lqSm5pRHZJdXpmSXV0WEhQQjB0Nnc1UGVEWjJGNFcz?= =?utf-8?B?NklLeSs5QklsQWJrbGNjVFVQaVJxc00xdDFFSjhqcXRFMFFMajNKUGtGdEFQ?= =?utf-8?B?ZmRmMW1EQUhSNnhKUERQeW94U2xyL2FXbUlucVBUVUJqbEhQeVd5K2l0c3Fm?= =?utf-8?B?NnRpNTdaYS9ncDlpQnVidnFPL2pIMGg4SWNUS214ejVyaDFjcVNOeXNGWWRH?= =?utf-8?B?SjdlQ1V4MnE0eHkzcnp4S2VmRE5jWnUvQThwNU16RkZQN0txUzdJeklPTldh?= =?utf-8?B?VVVjTUNJRXEvcmNZMG4zTnFJM3JSQjNNdnlLcHFoTmNkL2lMUGhZNjdNbExw?= =?utf-8?Q?D5grqyuk3/iVXinKh0MLNmpox?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f43f3b59-b349-4954-4b58-08da65896b40 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:10:11.1740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 64i6NJQzQkK3PU+D52Nz1L62s14Iiem9HT3LMrsl3hefiVYfrTJ/tz63XmL5TeYYts2ySfcLapOyZm3AWj1+6Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6358 On 14.07.2022 12:14, Wei Chen wrote: > Hi Jan, > >> -----Original Message----- >> From: Jan Beulich >> Sent: 2022年7月12日 22:34 >> To: Wei Chen >> Cc: nd ; Andrew Cooper ; George >> Dunlap ; Julien Grall ; Stefano >> Stabellini ; Wei Liu ; Roger Pau Monné >> ; xen-devel@lists.xenproject.org >> Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure >> NUMA nodes number >> >> On 08.07.2022 16:54, Wei Chen wrote: >>> --- a/xen/arch/Kconfig >>> +++ b/xen/arch/Kconfig >>> @@ -17,3 +17,14 @@ config NR_CPUS >>> For CPU cores which support Simultaneous Multi-Threading or >> similar >>> technologies, this the number of logical threads which Xen will >>> support. >>> + >>> +config NR_NUMA_NODES >>> + int "Maximum number of NUMA nodes supported" >>> + range 1 255 >>> + default "64" >>> + depends on NUMA >> >> Does 1 make sense? That's not going to be NUMA then, I would say. >> > > Ok, we need at least 2 nodes to be a real NUMA. > >> Does the value being (perhaps far) larger than NR_CPUS make sense? >> > > Arm has 128 default NR_CPUS (except some platforms) and x86 has 256. > So I am not very clear about your comments about far larger? As my > Understanding, one node has 2 or 4 cores are very common in a NUMA > System. The defaults are fine. But does it make sense to have 255 nodes when just 32 CPUs were selected? I'm afraid kconfig is going to get in the way, but I think I'd like the upper bound to be min(NR_CPUS, 255). >> Why does the range end at a not-power-of-2 value? (I was actually >> going to suggest to have a shift value specified here, until >> spotting that NODES_SHIFT isn't used anywhere else, and hence >> you're rightfully deleting it.) >> > > I think we have discussed about the 255 in v1. Because Xen is using > u8 as nodeid_t, so 255 may be a upper bound. Indeed, but that's something you could have mentioned in the commit message as justification. But you could also have opted to make the upper bound 128. Let me ask you: Are you aware of systems with more than a dozen or so nodes, that Xen can in principle run on? > And if use a shift value, from a user perspective, I don't like it. > It needs to be converted, not intuitive enough. It also limits my > input range, even though my numerical values are reasonable. Yes, > if a machine has 15 node, we can ask them to input 16, but why not > let the users decide? instead of being forced to enter 16 by the program? At least x86 Linux also wants this specified as a shift value, so people may actually be (more) used to that. Plus non-pwer-of-2 values may yield more complex calculations when the compiler generates code. Think of a two-dimensional distance table, for example. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:27:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:27:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367610.598675 (Exim 4.92) (envelope-from ) id 1oBx00-0000kK-Pc; Thu, 14 Jul 2022 11:27:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367610.598675; Thu, 14 Jul 2022 11:27:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBx00-0000kD-N2; Thu, 14 Jul 2022 11:27:16 +0000 Received: by outflank-mailman (input) for mailman id 367610; Thu, 14 Jul 2022 11:27:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwzz-0000k5-4l for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:27:15 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwzv-0002Vs-2l; Thu, 14 Jul 2022 11:27:11 +0000 Received: from 54-240-197-226.amazon.com ([54.240.197.226] helo=[10.7.239.30]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oBwzu-0008EN-Sv; Thu, 14 Jul 2022 11:27:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=65AcNvDRfMlCqNJ2gUxekm50rS2E2CK6wUc8u4O4XfI=; b=ENcp8AoOiauClZ3zaEHvtokUYe A9bGal+mzmFg24KKWMMVIWYsiN+0bF83JspulLSFN8X7XFZq/VGJZN/ZoN/7CjThEv2x9a+AERLzS TtjDgnHPccOh1QmK3VDi5E40fO9H91lFW/ZlhWFfNoGrfHqpFfFXY8cCpFkmbhVQwbAk=; Message-ID: Date: Thu, 14 Jul 2022 12:27:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number To: Jan Beulich , Wei Chen Cc: nd , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jan, On 14/07/2022 12:10, Jan Beulich wrote: > On 14.07.2022 12:14, Wei Chen wrote: >> Hi Jan, >> >>> -----Original Message----- >>> From: Jan Beulich >>> Sent: 2022年7月12日 22:34 >>> To: Wei Chen >>> Cc: nd ; Andrew Cooper ; George >>> Dunlap ; Julien Grall ; Stefano >>> Stabellini ; Wei Liu ; Roger Pau Monné >>> ; xen-devel@lists.xenproject.org >>> Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure >>> NUMA nodes number >>> >>> On 08.07.2022 16:54, Wei Chen wrote: >>>> --- a/xen/arch/Kconfig >>>> +++ b/xen/arch/Kconfig >>>> @@ -17,3 +17,14 @@ config NR_CPUS >>>> For CPU cores which support Simultaneous Multi-Threading or >>> similar >>>> technologies, this the number of logical threads which Xen will >>>> support. >>>> + >>>> +config NR_NUMA_NODES >>>> + int "Maximum number of NUMA nodes supported" >>>> + range 1 255 >>>> + default "64" >>>> + depends on NUMA >>> >>> Does 1 make sense? That's not going to be NUMA then, I would say. >>> >> >> Ok, we need at least 2 nodes to be a real NUMA. >> >>> Does the value being (perhaps far) larger than NR_CPUS make sense? >>> >> >> Arm has 128 default NR_CPUS (except some platforms) and x86 has 256. >> So I am not very clear about your comments about far larger? As my >> Understanding, one node has 2 or 4 cores are very common in a NUMA >> System. > > The defaults are fine. But does it make sense to have 255 nodes when > just 32 CPUs were selected? I'm afraid kconfig is going to get in the > way, but I think I'd like the upper bound to be min(NR_CPUS, 255). Looking around NUMA nodes with 0 CPUs exists. So I don't think we should tie the two. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:30:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:30:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367411.598687 (Exim 4.92) (envelope-from ) id 1oBx3C-0002J7-8T; Thu, 14 Jul 2022 11:30:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367411.598687; Thu, 14 Jul 2022 11:30:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBx3C-0002J0-5W; Thu, 14 Jul 2022 11:30:34 +0000 Received: by outflank-mailman (input) for mailman id 367411; Thu, 14 Jul 2022 10:37:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBwE9-0000sT-KS for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 10:37:49 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 005b1819-0361-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 12:37:48 +0200 (CEST) Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-241-Feqbb9jJOOGBsmIhHqyL7w-1; Thu, 14 Jul 2022 06:37:45 -0400 Received: by mail-wm1-f69.google.com with SMTP id a6-20020a05600c348600b003a2d72b7a15so2447015wmq.9 for ; Thu, 14 Jul 2022 03:37:45 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-97-238.dyn.eolo.it. [146.241.97.238]) by smtp.gmail.com with ESMTPSA id y18-20020a05600c365200b003a2c67aa6c0sm1744360wmq.23.2022.07.14.03.37.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Jul 2022 03:37:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 005b1819-0361-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657795066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4aMq9d6XOL2BYD5DztJ4VTiy/FnmnCeD5N5a+nINSVM=; b=TfOJe27aUqpExY64HMllRYd3rLsto1wK/MSUUQjm4GQcgX3V3uDyTu0YX47UKrb1DbxhZL 4FAgHIi6+aA/gAuEmNxgIl7o8HLeOQYgr0RvVdfCoGeMLOqXmXntqFLvCFyK9mtj7DVDdT vatDJfLnezvkLRzgwsvcr16cjSouN4c= X-MC-Unique: Feqbb9jJOOGBsmIhHqyL7w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=4aMq9d6XOL2BYD5DztJ4VTiy/FnmnCeD5N5a+nINSVM=; b=h42oZ1mSS/tJVGE7IEzEg7PJ1IARyDVAdwyDpkhVsjXDNXAnDnw193zO3N+3iiPCO9 /47fYZV8N3j4jX+0kCyKEb5LmHlcdMaXpc8IqMh0SwE+31v/kkkedFRVueCSTIrN47FI rf3TM8lVFZQbxcwLP/tENxEKYmfZYD1R3vvTgTQi4cSI2i+MC95aZNpW9sqcj5nOkLZU E044V3nPb6oCHXs7okAkaHnxEF0GGzelj2ZvW23fog88rY92WTFb4/375DBDqXfO1jTA VcSWd2V/y/h5JHmZPLZEKtxMDzVcVNFsDR2nCW62xdRTX3I6r5MUMpt8QJqK8kQd3Fq8 090Q== X-Gm-Message-State: AJIora+7LR2yTsIx/U36Tv1zIasIlSDv1aEtvnTAXtS6/u3bXaRkZknc iXkv6yAPOy7fGtqH2sWipNRXxar0PNdoGU5OfS+xwJBhKMT2pA0ul632xwAITyjVhIZ6b8oJgXl vd/oVzg1dZYfensYTNoVnth5IsnA= X-Received: by 2002:a5d:5268:0:b0:21d:6c45:fe6 with SMTP id l8-20020a5d5268000000b0021d6c450fe6mr7908393wrc.380.1657795064437; Thu, 14 Jul 2022 03:37:44 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tnjBGgvWE3ovLJfa/IOyiITy8LVVfr+LAvxJzgOIn3iB+Jjr4weNUd9JZmrQbt3acfbGY+ng== X-Received: by 2002:a5d:5268:0:b0:21d:6c45:fe6 with SMTP id l8-20020a5d5268000000b0021d6c450fe6mr7908378wrc.380.1657795064245; Thu, 14 Jul 2022 03:37:44 -0700 (PDT) Message-ID: <9582eec95583412e51484092e13d7a773c338f34.camel@redhat.com> Subject: Re: [PATCH net-next 2/2] xen-netfront: re-order error checks in xennet_get_responses() From: Paolo Abeni To: Jan Beulich , "netdev@vger.kernel.org" , "xen-devel@lists.xenproject.org" Cc: Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko Date: Thu, 14 Jul 2022 12:37:42 +0200 In-Reply-To: <743b3ff3-896c-bfc9-e187-6d50da88f103@suse.com> References: <7fca0e44-43b5-8448-3653-249d117dc084@suse.com> <743b3ff3-896c-bfc9-e187-6d50da88f103@suse.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pabeni@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Wed, 2022-07-13 at 11:19 +0200, Jan Beulich wrote: > Check the retrieved grant reference first; there's no point trying to > have xennet_move_rx_slot() move invalid data (and further defer > recognition of the issue, likely making diagnosis yet more difficult). > > Signed-off-by: Jan Beulich > --- > I question the log message claiming a bad ID (which is how I read its > wording): rx->id isn't involved in determining ref. I don't see what > else to usefully log, though, yet making the message just "Bad rx > response" also doesn't look very useful. For the records, I (mis-)read that log message differently, claiming there is a bad RX response, and specifying the ID of such response, which may or may be not useful to diagnose where/when the problem happens. Cheers, Paolo From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:51:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:51:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367625.598698 (Exim 4.92) (envelope-from ) id 1oBxNe-0005Cv-UZ; Thu, 14 Jul 2022 11:51:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367625.598698; Thu, 14 Jul 2022 11:51:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxNe-0005Co-RY; Thu, 14 Jul 2022 11:51:42 +0000 Received: by outflank-mailman (input) for mailman id 367625; Thu, 14 Jul 2022 11:51:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxNd-0005Ci-Eo for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:51:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5248c70c-036b-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 13:51:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4783.eurprd04.prod.outlook.com (2603:10a6:803:5e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Thu, 14 Jul 2022 11:51:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 11:51:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5248c70c-036b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SYq/ARUONuBH7Yzjy3+s55DRn9H1OZ4f/4hCTMdw/WZ55diKm6z7OZ8BN4tIrrIOzv/GUBEVoxXFF9Q0cv38KzXxeddkxq4wZVQvYLEY9r/NL7UxiT3W4fnDe9SN7m0vnCBkneW0QzLa85WHb/OJai31unPR9YyTHisZncdpe7DoICyWDp01HXOTpX3lrHdSSvscLc41iuCjvMcSWdFGsSUoHh6aboFWmBgQrynUlaiwP3rUwKbacZKInmrGR3KphQH/NregoRm2Rpu7vZ/YNRVlnQG45NQJlEvxRspy8/PUP8HvS/Pd3Yx8Llxt//UL9MlmjCUwocecHDpbb1tkYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wRJvKi/TcqUW/3TSHShq/4XKra83Qjczh2+hSwFAFZk=; b=dq8nnzlDv4IzpCTpR/dtHCB1f40tvepGlQOLDgYrXZSz1ZbA2vpg2aprQwUh+VeUmWjVHD0c/T9j2MPV1AmPZ4oXvi2uMi7kOGHmgWaFC3ol5qjLTCKVE91tz+Mgoh3Tch7Rtm92xqcMXnmn7Hl6eeF9oh0MHkY92lQXu2o85Cy7QUysmiyxuvA4m1Nrki5sBMnXu+vu5E0MMPRB8pa3QvCFV8jMdKnt6UfYd/Byz2x+7uSH+A1aEh0WFDGNluuNhAermVxs1ZlK7UkQrWHoYImfQ9GMqpK4HJkoFtsflf9oW60J7TOhr7MHHXhVbHGfW5h8SEGT26uzQy4g0h0Z1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wRJvKi/TcqUW/3TSHShq/4XKra83Qjczh2+hSwFAFZk=; b=ys058qn5HSILyprmaZNCu0IYy3RfVUKfECj1eYjMtX9F3TFs6tq2UAWRz7ZiWWvH3iySpZ/UZRWsY3bzNteEBGKfjuHDGpm6BVfR5dJfGL2+7cc4uWL9rPXhFq91zLLa312pss+n8+sZXH+O9+OHkkwah3fIguZAXziKErcEPQbFe7T9Cx293eWjP5+TnfEJ88d9V2A7rMZyq7NvoBURYTwmZdyEdw9wl9jdKfIc5HDErVnhCb2IixTBtHTwNswHoZg/4oK9SWn5DJpMDZsgaHwqGltKcPS9byVqiBgLXVz0oUsqN1Yn3YL7TWBGLElj/hvSg0m29Na/m2XuR/XldA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 13:51:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org References: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0048.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 726d4715-afc4-47c1-244f-08da658f2394 X-MS-TrafficTypeDiagnostic: VI1PR04MB4783:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iVcvopmGeQBcqdFO10gpyfonAMFferdQElMCuCglz2qwC5zgOSGPlTeSIJPP//730LCtHIy0b9gm64lO5Vc4ngi12Lt0DuyFojg8oj/pJqTLsR+/94aJfPbKLYvmfz3AC7kTCyrYbm9Gki/sxFywY65QBAcE/tHKspujYtd9PisGC0BGBathn3iavFAM5SoezbTz7OS5FJLcChn4bOzlGtKaAoJHa+zfFqzmXHiZEJp04r/uC2GUJFJ+RHdDEsRkUF06jgL4w8cmBO1iXcFYSm2aFYV/p0Fr/zAipa9qRyhb7KP/pBJ/a85H785gXJR2iBrZz1EZLdNUR747In29N01g+g2R6GNTqCZt0BIy7THGN/zEEC/iOVdVWbvIMhxVhvpavc2ncj2NzI4KQ244Maq/285StdryeDJ/KEDTtmL2JmMa3qPdBdC/qxhCTW0nTbSGkPNe2DfeFsfceFsfjIUsHqdkb6UA6sBdqYROLZU1U/ZbSpCVo2kvrZBaVAUyOTX2rS87NvM3HSx6NziXI+bQkSf0UfFxQS5gJhEK7tVzTIlIH0bUxerFwFTgfupjMnPG31zPenNFqZ93ezal0QVWVDyvfdu5eFMb57SG+SUc96pvM4HNS66oqdPTQovV0cS/3QmrmMr9e35uDji2syv6kCIbohcmzrQCC/O4x/ZjZuXCzPlcTbMfEZ0EujwrRuXEbFO3PEL8zWUQWPxHKKH+Q9hSpoHF8etCxq0n6yQkPFSlMRHPPXbL4c8QVIhHwbdraekVsiKNB/eI8dWb9BIqJkjfQR4x+QX2wjflcbIGuPmAoU9HSK7HQuG2hSRDZZGP6HrSxzjRoy77ZqGke+R5SzSmCg/yieNwJn/j18w= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(396003)(366004)(39860400002)(86362001)(6506007)(83380400001)(53546011)(186003)(6512007)(36756003)(6916009)(66574015)(31696002)(8936002)(2616005)(26005)(478600001)(66946007)(31686004)(54906003)(6486002)(8676002)(66556008)(316002)(4326008)(66476007)(5660300002)(2906002)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T0s0dUpzcjd3aExuWEhSdXV2enFaVklpWVJQUmhnYkozL2FGY3ZuWTNQc2lN?= =?utf-8?B?bThkeWo5R2ZLNFkxNGtCTTFFRjJJSDBhSjhaTk9aYkgyLzJzZCtNdUVVWXpV?= =?utf-8?B?RldQWksyd2VmQjc4QUN5bkFWR2ZuMFE1ZG9PWUR2Ry80U0xSWkloeUdOVm11?= =?utf-8?B?eUVLek8weXRpdEdmWWJuMWZnajFnTXVTSjg2Y3lJd3d2UUVYMmJ6ajNVRnB4?= =?utf-8?B?a2tVTGJLVldqbFVVbWhFTEdDSFlYeUtMMmhWZHcybXhRRElJbzJ4RlJBcDNS?= =?utf-8?B?ZWpoRlJKUnNXS1ZYamNmbWF0RWpVZWhkQS9TVzhXMm83aWJkL0FSd2l4RG94?= =?utf-8?B?SVVwS0JhdzJpODZLZzJSVUVvVWZPdlJSeXdFaTFieVpjaUU3LzF5V2FpTmtH?= =?utf-8?B?dU1IbHlJWHBXWkVadG1MaTAxS2Y1d01BeThxVlMzSHFFV0xjSXB5WEJRMFRC?= =?utf-8?B?SnVIeUN0cjU3TEVTWWpISWJxcXFKd2xueDd4TzZsR2x1WElzcFZDUXowTUFN?= =?utf-8?B?U2piQllUVG5EdTg2RHhWd210WUN2QzBZZFF2M2JvaFlaNEt1QlFtQVJiREx0?= =?utf-8?B?Z2N4K3Boc042WlZCT1hHelB5YjJvOE1wMk5aUlpVamFjVjMveGRsSWZYV0tq?= =?utf-8?B?dWlkSjhielBJckJ2T3RwaVV0VXlzakw3ZlIvcWM5dG1UTGtYci9ObTRIVzRq?= =?utf-8?B?WEJDTjgvdnpJMzJTUHY5bVA5REFBT2xhdzRnUjhNQ2xzTVU1bmp6U3FWNExm?= =?utf-8?B?dnVWTjN0bjdnWTcrQ25RUFNiWGVRbTBiWEkzZkdjeXZyVG1YbW9CcjllTUk1?= =?utf-8?B?NDNPWnZrVENsdWU3aldMak9RWGo4YU5wVENsSlhwZUFqSWVsL0NtUHdiWXZk?= =?utf-8?B?UTNWQmV5NWdodVR1SFJGMVAxMjNPM1AxdElQZm1iSDc5Nkttb2cxS0dJMkZK?= =?utf-8?B?Vk5qZG14N0I4N0ZUYmNJT3ZUUlNuRnRtRDVBbEtYK1ZZcDhkZ2lOSlVzMjh6?= =?utf-8?B?RHpwT09mYWpaQ1ZnaFB3ckpJUTNVYXdYWXROZ3Z3YTFlN3FNMFRGMXlERFds?= =?utf-8?B?M0ZHNkc4OHBGcWJRTTFQZGh1NWwyMWVVdGo4VHBEMms3cmFZak05QTYwZHBm?= =?utf-8?B?NTUzcnR0OGY1UVFpcW5jZzBUZjBGcXhnaDNiQXFkQTVMYU8rVjFnNlgyS2NL?= =?utf-8?B?Q0xuN0xCWFJHTGhRSURMdVFYVHNvUVZ1eW9JejZ4UHlxMTJ4UjFGMmxSRjRs?= =?utf-8?B?MHo1cWI4cTl2dEtmUmpWUFRJREFibjlBSzFPUzZzOFFDdngxTktaMFJablRu?= =?utf-8?B?a29sZS9SRGFiT29BMENteGR1SVROZ0ZiaU5yZFRnbjZKYmVOWmlHcHdPbGdo?= =?utf-8?B?SWZHMi9OSUdrckdLZkN5a0RSUExFUUhSS2ZIb1lOM29UTFlUeXN6SnJtbXc2?= =?utf-8?B?T1ljQlVYK3JBZkxReWRvalhTSWJLZ0p3dGZUbjRkcXBSc2xWRkROT1pIZk9B?= =?utf-8?B?U2JzcXFGZkdMTmYrSEkvdFg4RUh6WWpmKzIyYXpoWm15M0hPOGFBUzVpSmxG?= =?utf-8?B?dXpSaWc3RkZlb2FQTGIxalJvam44VlFVZUNWb3g2YnRwMElZTmlzcERybSs2?= =?utf-8?B?YjRXMlI2L2lzMzZiKzdROGJNVW5ZTmI0Q0R5eTFCSkFVR1dUeEsyczRCUzdt?= =?utf-8?B?QlB5Rm9pK21Gd2pveGdMbEpUMnpjK1JDMHB6dURmb3paWlNock9LTnZtbjZw?= =?utf-8?B?YU5SVEV4b1JXd1hRMmxnR3JJNW54WUNsYXltYWh3bXVBK3FlSTVTMG1LTWtJ?= =?utf-8?B?bXdjdTFpdDBnWlVHams0bm9zREcvQS9qRlBHWnliV01PNTBEbXlHdEVLVlNZ?= =?utf-8?B?ZWVKakVacE55SGJPbm9JQzFjYkVzZ2tlakN2SElBUE00U0E5anErdzJaU010?= =?utf-8?B?SjJib1VXYUdCTFUveUd3cUlLbmo5QTEybndJa08vdVBkc2pSU0pab0ZqVmY3?= =?utf-8?B?WkQ5TWQyS000REttQndIRFBuaUppV2w1aVpmODNPdkhOWUJVdWd2cmFLZmtZ?= =?utf-8?B?cjVNc0pmQ2NtMzhkVDFReitQdHk4Rm03NDN2OEpVWVJVL1JuR0tIYUcweG5Z?= =?utf-8?Q?9Znhh9Qh5zQ8GtAm/oYSm3u6f?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 726d4715-afc4-47c1-244f-08da658f2394 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:51:07.9392 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: msmrhx5rUx3Xnr3IMLyXRigAPNAxMTb79wYkoR7Jwq6GNTYGfjCe1bv7qW7906u4swl9jZNeCfhyCdKE2WEx/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4783 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > The important part is to include those buffers in IOMMU page table > relevant for the USB controller. Otherwise, DbC will stop working as > soon as IOMMU is enabled, regardless of to which domain device assigned > (be it xen or dom0). > If the device is passed through to dom0 or other domain (see later > patches), that domain will effectively have access to those buffers too. > It does give such domain yet another way to DoS the system (as is the > case when having PCI device assigned already), but also possibly steal > the console ring content. Thus, such domain should be a trusted one. > In any case, prevent anything else being placed on those pages by adding > artificial padding. I don't think this device should be allowed to be assigned to any DomU. Just like the EHCI driver, at some point in the series you will want to call pci_hide_device() (you may already do, and I may merely have missed it). > Using this API for DbC pages requires raising MAX_USER_RMRR_PAGES. I disagree here: This is merely an effect of you re-using the pre- existing functionality there with too little customization. I think the respective check shouldn't be applied for internal uses. > @@ -952,13 +953,21 @@ static struct uart_driver xue_uart_driver = { > .flush = xue_uart_flush, > }; > > -static struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > -static struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > -static struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > -static struct xue_erst_segment erst __aligned(64); > -static struct xue_dbc_ctx ctx __aligned(64); > -static uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); > -static char str_buf[XUE_PAGE_SIZE] __aligned(64); > +struct xue_dma_bufs { > + struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > + struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > + struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > + struct xue_erst_segment erst __aligned(64); > + struct xue_dbc_ctx ctx __aligned(64); > + uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); > + char str_buf[XUE_PAGE_SIZE] __aligned(64); Please arrange data such that the amount of unused (padding) space is minimal. If I'm not mistaken the page-size-aligned fields are also an even multiple of pages in size, in which case they all want to go ahead of the 64-byte aligned but sub-page-size fields (as per an earlier comment str_buf[] likely can go away anyway, being the one field which is a page in size but having smaller alignment). > + /* > + * Don't place anything else on this page - it will be > + * DMA-reachable by the USB controller. > + */ > + char _pad[0] __aligned(XUE_PAGE_SIZE); I don't think this is needed, due to sizeof() being required to be a multiple of alignof(). > +}; > +static struct xue_dma_bufs xue_dma_bufs __aligned(XUE_PAGE_SIZE); I don't think the alignment here is needed, as the struct will already have suitable alignment (derived from the biggest field alignment value). Instead please consider putting this in .bss.page_aligned. > @@ -990,16 +999,22 @@ void __init xue_uart_init(void) > xue->sbdf = PCI_SBDF(0, bus, slot, func); > } > > - xue->dbc_ctx = &ctx; > - xue->dbc_erst = &erst; > - xue->dbc_ering.trb = evt_trb; > - xue->dbc_oring.trb = out_trb; > - xue->dbc_iring.trb = in_trb; > - xue->dbc_owork.buf = wrk_buf; > - xue->dbc_str = str_buf; > + xue->dbc_ctx = &xue_dma_bufs.ctx; > + xue->dbc_erst = &xue_dma_bufs.erst; > + xue->dbc_ering.trb = xue_dma_bufs.evt_trb; > + xue->dbc_oring.trb = xue_dma_bufs.out_trb; > + xue->dbc_iring.trb = xue_dma_bufs.in_trb; > + xue->dbc_owork.buf = xue_dma_bufs.wrk_buf; > + xue->dbc_str = xue_dma_bufs.str_buf; > > if ( xue_open(xue) ) > + { > + iommu_add_extra_reserved_device_memory( > + PFN_DOWN(virt_to_maddr(&xue_dma_bufs)), virt_to_pfn()? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:58:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367633.598720 (Exim 4.92) (envelope-from ) id 1oBxUH-0006Fa-VY; Thu, 14 Jul 2022 11:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367633.598720; Thu, 14 Jul 2022 11:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUH-0006FT-Sf; Thu, 14 Jul 2022 11:58:33 +0000 Received: by outflank-mailman (input) for mailman id 367633; Thu, 14 Jul 2022 11:58:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUG-0006Ej-OE; Thu, 14 Jul 2022 11:58:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUG-00030z-IM; Thu, 14 Jul 2022 11:58:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUF-0002xe-Uq; Thu, 14 Jul 2022 11:58:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oBxUF-0007DA-UR; Thu, 14 Jul 2022 11:58:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=x1YgvfXqEd6AYQgsoZDC1iP+C3LKkBM9T9fU1lKdbpE=; b=JWySczwbRs0Xh71/Ts6TmdiMDV mHG6iFSO/7e/Zy/irt7NuX8XalO3nYpAG/7oQRZVyXYk6fi+AxntKiUAghJi5sc03MTJvkUcfXfnM /bTABaW0c3QKBQFn4wmyMXFx78hE2nyzDOmnp0YzCNDYF3zCFxrYTGZOtxGgP/H/2UbA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171621: regressions - trouble: broken/fail/pass X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt::broken:regression xen-4.16-testing:build-arm64:xen-build:fail:regression xen-4.16-testing:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-4.16-testing:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl:build-check(1):blocked:nonblocking xen-4.16-testing:build-arm64-libvirt:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 X-Osstest-Versions-That: xen=744accad1b73223b3261e3e678e16e030d83b179 From: osstest service owner Date: Thu, 14 Jul 2022 11:58:31 +0000 flight 171621 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171621/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken build-arm64 6 xen-build fail in 171608 REGR. vs. 171595 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken pass in 171608 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-credit2 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-xl 1 build-check(1) blocked in 171608 n/a build-arm64-libvirt 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked in 171608 n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked in 171608 n/a test-armhf-armhf-libvirt 16 saverestore-support-check fail in 171608 like 171595 test-armhf-armhf-libvirt 15 migrate-support-check fail in 171608 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171595 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 baseline version: xen 744accad1b73223b3261e3e678e16e030d83b179 Last test of basis 171595 2022-07-12 09:37:57 Z 2 days Testing same since 171608 2022-07-12 23:09:33 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt broken test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken broken-step test-armhf-armhf-libvirt host-install(5) Not pushing. ------------------------------------------------------------ commit 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 Author: Andrew Cooper Date: Mon Jun 27 19:29:40 2022 +0100 x86/spec-ctrl: Mitigate Branch Type Confusion when possible Branch Type Confusion affects AMD/Hygon CPUs on Zen2 and earlier. To mitigate, we require SMT safety (STIBP on Zen2, no-SMT on Zen1), and to issue an IBPB on each entry to Xen, to flush the BTB. Due to performance concerns, dom0 (which is trusted in most configurations) is excluded from protections by default. Therefore: * Use STIBP by default on Zen2 too, which now means we want it on by default on all hardware supporting STIBP. * Break the current IBPB logic out into a new function, extending it with IBPB-at-entry logic. * Change the existing IBPB-at-ctxt-switch boolean to be tristate, and disable it by default when IBPB-at-entry is providing sufficient safety. If all PV guests on the system are trusted, then it is recommended to boot with `spec-ctrl=ibpb-entry=no-pv`, as this will provide an additional marginal perf improvement. This is part of XSA-407 / CVE-2022-23825. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit d8cb7e0f069e0f106d24941355b59b45a731eabe) commit 5457a6870eb1369b868f7b8e833966ed43a773ad Author: Andrew Cooper Date: Tue Mar 15 18:30:25 2022 +0000 x86/spec-ctrl: Enable Zen2 chickenbit ... as instructed in the Branch Type Confusion whitepaper. This is part of XSA-407. Signed-off-by: Andrew Cooper (cherry picked from commit 9deaf2d932f08c16c6b96a1c426e4b1142c0cdbe) commit 0826c7596d35c887b3b7858137c7ac374d9ef17a Author: Andrew Cooper Date: Mon May 16 15:48:24 2022 +0100 x86/cpuid: Enumeration for BTC_NO BTC_NO indicates that hardware is not succeptable to Branch Type Confusion. Zen3 CPUs don't suffer BTC. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76cb04ad64f3ab9ae785988c40655a71dde9c319) commit 76c5fcee9027fb8823dd501086f0ff3ee3c4231c Author: Andrew Cooper Date: Thu Feb 24 13:44:33 2022 +0000 x86/spec-ctrl: Support IBPB-on-entry We are going to need this to mitigate Branch Type Confusion on AMD/Hygon CPUs, but as we've talked about using it in other cases too, arrange to support it generally. However, this is also very expensive in some cases, so we're going to want per-domain controls. Introduce SCF_ist_ibpb and SCF_entry_ibpb controls, adding them to the IST and DOM masks as appropriate. Also introduce X86_FEATURE_IBPB_ENTRY_{PV,HVM} to to patch the code blocks. For SVM, the STGI is serialising enough to protect against Spectre-v1 attacks, so no "else lfence" is necessary. VT-x will use use the MSR host load list, so doesn't need any code in the VMExit path. For the IST path, we can't safely check CPL==0 to skip a flush, as we might have hit an entry path before it's IBPB. As IST hitting Xen is rare, flush irrespective of CPL. A later path, SCF_ist_sc_msr, provides Spectre-v1 safety. For the PV paths, we know we're interrupting CPL>0, while for the INTR paths, we can safely check CPL==0. Only flush when interrupting guest context. An "else lfence" is needed for safety, but we want to be able to skip it on unaffected CPUs, so the block wants to be an alternative, which means the lfence has to be inline rather than UNLIKELY() (the replacement block doesn't have displacements fixed up for anything other than the first instruction). As with SPEC_CTRL_ENTRY_FROM_INTR_IST, %rdx is 0 on entry so rely on this to shrink the logic marginally. Update the comments to specify this new dependency. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 53a570b285694947776d5190f591a0d5b9b18de7) commit 2a9e690a0ad5d54dca4166e089089a07bbe7fc85 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework SPEC_CTRL_ENTRY_FROM_INTR_IST We are shortly going to add a conditional IBPB in this path. Therefore, we cannot hold spec_ctrl_flags in %eax, and rely on only clobbering it after we're done with its contents. %rbx is available for use, and the more normal register to hold preserved information in. With %rax freed up, use it instead of %rdx for the RSB tmp register, and for the adjustment to spec_ctrl_flags. This leaves no use of %rdx, except as 0 for the upper half of WRMSR. In practice, %rdx is 0 from SAVE_ALL on all paths and isn't likely to change in the foreseeable future, so update the macro entry requirements to state this dependency. This marginal optimisation can be revisited if circumstances change. No practical change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit e9b8d31981f184c6539f91ec54bd9cae29cdae36) commit e7671561c84322860875745e57b228a7a310f2bf Author: Andrew Cooper Date: Mon Jul 4 21:32:17 2022 +0100 x86/spec-ctrl: Rename opt_ibpb to opt_ibpb_ctxt_switch We are about to introduce the use of IBPB at different points in Xen, making opt_ibpb ambiguous. Rename it to opt_ibpb_ctxt_switch. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit a8e5ef079d6f5c88c472e3e620db5a8d1402a50d) commit 31aa2a20bfefc3a8a200da54a56471bf99f9630e Author: Andrew Cooper Date: Tue Jun 28 14:36:56 2022 +0100 x86/spec-ctrl: Rename SCF_ist_wrmsr to SCF_ist_sc_msr We are about to introduce SCF_ist_ibpb, at which point SCF_ist_wrmsr becomes ambiguous. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76d6a36f645dfdbad8830559d4d52caf36efc75e) commit 3a280cbae7022b83af91c27a8e2211ba3b1234f5 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework spec_ctrl_flags context switching We are shortly going to need to context switch new bits in both the vcpu and S3 paths. Introduce SCF_IST_MASK and SCF_DOM_MASK, and rework d->arch.verw into d->arch.spec_ctrl_flags to accommodate. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 5796912f7279d9348a3166655588d30eae9f72cc) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 11:58:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 11:58:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367632.598709 (Exim 4.92) (envelope-from ) id 1oBxUF-0005zU-P1; Thu, 14 Jul 2022 11:58:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367632.598709; Thu, 14 Jul 2022 11:58:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUF-0005zN-Kz; Thu, 14 Jul 2022 11:58:31 +0000 Received: by outflank-mailman (input) for mailman id 367632; Thu, 14 Jul 2022 11:58:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxUE-0005zH-JM for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 11:58:30 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2040.outbound.protection.outlook.com [40.107.20.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 462cbe32-036c-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 13:58:29 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3676.eurprd04.prod.outlook.com (2603:10a6:8:d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 11:58:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 11:58:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 462cbe32-036c-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkkfeTlANHevIDBzX2kP62nBjz3l5atPi1AHzaZLyDG6gcIZ/LUtrQSiub5pkosiJk8/QMi0Xe7DO53S+E1sQhMoGWtRq3w382U29U5OImNEPG743arObIovkiO4XNzPYo8azKctb3/ghI7fskDwrjDsRljqzHiL+Z+5FRKB/4HtNGmJCDzgc4RV/MqLsg0tlmjwti4O8KGmMxDEdwGs08zoXnUaVzHtvasxaaAAI0G9ewdxL0jJP1gV+sCE9LqxON7W7CpfE9K/k31XYjiD5slmpf+qdceQkusyoWoTKD5H0l9KpOrcu7LeegDJ/Sqxam6+LrDz8uUtm6B0Srr7mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=11unytSiLs678PrZ8sc7YV1Xvo4MxclbMNsP2wJRGwI=; b=Lh5h87BDt62MPCm91iLYhVFwtmbtram3VFCqcwXZN+Xiv6oXW4w6GrDpggdkbPkTbkxLZRX2Ji8UWT+ZGC/dridWuShigpph/eIgfmq9D4VLYPWzcxl73+O+/dLUmURxu88D+oCa1cFU4w3cTS5OFX8Eia/mFNt7+0m+GlR828bhzCK10oWZ6Env6V5c45l45Pdfa59GJ7aVfjHsNOeh0AbrPDuT/DULnPJivt4avvEYEruzTh19KxCwDuYDJZmljliszzNHEvn8UqE1G7PncQb5p1KbAyg9SjRT5FY9G+sa9r5b6VISwgkqXtMEEzjEkJjYeIx89abF+n/ZCQMwmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=11unytSiLs678PrZ8sc7YV1Xvo4MxclbMNsP2wJRGwI=; b=io8GNxrl5Qiz80bcb00md+FatEC7hZzuud5gee6Xkt0EMolKEb/LMhZ8KqS4nJFGyE+7gA7IGX2MxxSke7RROyCQ5sSZaWKT9ALVNk/RremY1SPTZvyxefgt5pKpSPxHVr1nWxKn7tn1Spvo2R/0EIqq4orQL9p0RhkjY27CrbzOU0uOOebMlHtzVD2Aojz9oC1goWRoEIcdBd8F8YpjVXQGI3Nd3XiYv1k9t2snrwOznPLovTcUn9siafwdBVEr6kOEbIE6RBeDZ0eTdStxpZrqP/2/SbAvvGLoaGHaIDot+plKr6ZeKpGHg6f2oealF8o+J2ekIrdrQKYcL9H0VA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 14 Jul 2022 13:58:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Connor Davis References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 79c96960-3951-4505-4de5-08da65902948 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3676:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8rCj+LVeaL/12v+7CFyW3m/bgTd/glICzSNHnFwnDANu0ucKYSaoQ1lVaNpXT5eqiaDj/Nsl4wQneYXd82piE34vODSaZ0+C73/qbQYChqrb6VZDlQnIsYOPMr3s1q0CBXnhfTiYh8M0IjS9aCKNCBUOWmkdCeTAejwUJxLPbDHjUpA3wS/a0YcnFM8sXlrMcuVnow72ZNqefI8j7LA9tIbSgkSY2jHeDeaKAuXfF/Iecy5zvJ7CSSWfMA/wGNw395xikoI1jwg1k6jxQOVrYXpVoB5KvRN9b2H1GaCnUBJqAeBiz1jfEewwpgFr4Ynxy6gEZT6pcSSY67gfbyPBv6FgOzFFDCrDm12v/KEtMuXVJnBvmIc6f2AsLmP8PdpYRCHYnplwpA4Hq/0jqAi6ybEAnPRZDrhuZwjF/P5jrSwCDGQgLtvd6QImHETE5BqvpQYFzlJ6LMI16fllQJYTcqoQHzYHrjkLrxEmi+6+7+bXavyZizulQFtqFH3HkessvKceqjuOqzuMsSE2zWrBEu8BzRNlffl3RNVBcYXTxH65Kyq9dvL0rUJ2f0hDSRlMRKaqiYzMwumLJShVj2BgePC7A3m0coDtkKtRIf1JmUF47I9ACZbeAhNZXbAEJalfZKkHqiiLUrfOTr9dhsK8ifyJlnP5zpsEQguEarV1RalJ0QhYAaXTa9MSwJQ2FbEB5PpC3O55qe3UludCTcwIutiJSHNGEDfxSeiyWva2VakxwxZp81B8/5KAJQZ9zpoQVozZ0IGA3I84grNIKkrCymSFrNeNVLS08/4UsZJMdPotKrCUOE9pLIW2ps5rFjA50JPTDKB0tgLKwzEXfkuq8pPBFj8i19ZRaV08NLtRF5Y= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(39860400002)(366004)(346002)(396003)(186003)(2616005)(38100700002)(2906002)(31686004)(5660300002)(36756003)(8676002)(54906003)(6512007)(41300700001)(66946007)(8936002)(478600001)(66556008)(66476007)(6506007)(6486002)(26005)(53546011)(4326008)(31696002)(86362001)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEZ3MWFvMS8vd3B1T01kL2FVMHM3RUYvcE8zYkw1MEk3SVF2WElFcklHR2o5?= =?utf-8?B?OThTRXU5RGlIZld4NU1oeEM0VENKRHU0YjlNaEpsaVVCbFExWk1qQ0hyRmFT?= =?utf-8?B?eHoxT3MyMFZIek15OVh2RkVlRWNZV2lENGh0c2JVcE5tZG01RlBFSFBnaDla?= =?utf-8?B?TmhueHgyTTVCZWIvblBJRVVFeU1EQkcvWXVNNFNpekJBVTZQYnBFZElKSmJZ?= =?utf-8?B?YmNnTm9oWUNuUGVlWTEycGg2NmVYMVZjWldjZ1hPdFZWRDJkWWJSODMxOGJr?= =?utf-8?B?MEhFdkE3a3RSSXNUdGFiUEdUSlhtMUNCeXpzWEQ3YThGQ3lIbVYvYXc1d2dL?= =?utf-8?B?NG9VNll2Uzdkb3RvalFVTUF1TVFPNDFaSTRMdUZBQTZNRXpJRXU2Rk5PNmNx?= =?utf-8?B?R3gyQXZESk9mWTFYR2JoYjFRN1U1V1QzcWU1Z0dmUThOUDR4ellscmVUSzFV?= =?utf-8?B?T0JjK0ZhUFJRZmpoeEpESE5QMmxPTDUzbmFBMDVqUjRQWkNlcWFNbS9jelJ1?= =?utf-8?B?Vmg2OGZKRUZCcGFLNGE5Ri9BRGo3d0xJQmIvQzcreXJ5TnZCU0xWN0ZNbzV2?= =?utf-8?B?cHk3TmVMK3NNSkVOS3FRRUxCUEhucnpLZVJkK3djTm9MNHN1dzhrcGFHbWNK?= =?utf-8?B?bDFrdFg2WXBtOFBBMEo5anBKWkJUNXpSZlRCWWlFLzlSMWkwbHhpZVd5cFVj?= =?utf-8?B?S3RLeEVneTRkTzB2K2FKMWdwYXBHTlpWYXNtem5mMVhWTi9lb2RaTTlINlcy?= =?utf-8?B?Z3RselpCcUQyRy9mRnpPY1R1Wm80QmNZTnVxV0t5TTZCZEZ6SE1Db3VYNmZ2?= =?utf-8?B?cjY0aXU3Uk51YVQycERpR0tKK3R0NnAwMnU2eUZJWWZVYlJya3did0ZQZEIw?= =?utf-8?B?c2doblVESDBVRHhoM0tVTUVaSysvTDJSMDRINS9TRzg2VnBwVnpUWDMraUtj?= =?utf-8?B?YTVEci9tMFhaSlVjaEVQb1R2dmJyZ1laQ09ueWgycVExSlZTV08ybHZkdEpM?= =?utf-8?B?QmVkWjBPeUpGUWxpK2FGTGR4SHc2anVlS3lvMHdVenRDK0g1a2ZhMk8zQ05s?= =?utf-8?B?eGpqTmhtUFFqdEVNalBvc1d0MktodWxNOWFkMS90VFFqWitNeHRlUlFkc2t5?= =?utf-8?B?a3pGSkZrclUrNkkxS0ZYclIyMEY5NVBpZ3g1V2I5VTdaVXhnQWZ2K0lNQUNN?= =?utf-8?B?TENjcm1JdU5mbnl6L0RmbVExc2VTVU8vcncraEQzQlNJenBsc0dGWXp4V3dq?= =?utf-8?B?UjJKQmZ3WWJITklZVWxHY2lodGU4MHNkSEREWHcwNCtIVTRhRFdYWUkwL2RH?= =?utf-8?B?eGYyQnU3S3U3VTZ5VGFwWWptaGlxSGFaYlVSRjNYaGZuU2VQa0dta3dxRVB4?= =?utf-8?B?TjVhRTRKMnVDNmJuVFlZUUtSeWgvS0lxbk9xbzIwck1uamtPNnNDTmVHM2Vp?= =?utf-8?B?WUFUSFJxS2M3QWNyRHR3RytuU1RKdW94S3k5ZUorTCs0NHUwYmsxR1EycHAy?= =?utf-8?B?V1ZhVzRrYzZ5ZmhYNW9aMERlT25TK2hxYW9ub2FrbHpwM3BWdTd1MTN5VG5N?= =?utf-8?B?MkdnZnpKenR4bnpQY1dHckczblFUamR6REJDNFk4RHl2U1dLeTYvY0Y2ZW9X?= =?utf-8?B?Ni8xLytYdC9ReFA5MkdEUzRvMFJjRXZCam5ybVcvU2FjWS9UbzZLdGxkditI?= =?utf-8?B?T0FhRVYwV3V2bzhmNVlvd3VXR1JvZzhTZ293cTJZSlR1NzN4WVBKSUdBWXor?= =?utf-8?B?d0RkZVgxN0lQU2lVeTdnOU5DaEVkS1FwaUxvMWJ4bWdENUVLYkpvMi9QNkVI?= =?utf-8?B?Tkc1NmlEbUM3RXpsZWk1ekpBb3JTSVoxTm1wZktMU1NEaXR6RHZkbmpFcHV0?= =?utf-8?B?SEJUd3JxQWdSSlltWTRiUzBWWWxyRGVjTEFuTXlXTFkwcEI5L25aR1lhRDNU?= =?utf-8?B?anMxK05tVkhJK2hkSHBwOUYvdU14TXpyaHFCZTlhZGJwZWZhMVFxVURFTHNp?= =?utf-8?B?emdocHFwZE9aM2lObms5TVZXcTlqNW1na1FpMEF2UER0b0pkZ0ZSeGhGamp5?= =?utf-8?B?NGRmTnEzbXlzbGVnUVlweXVXa2pWekNKODR4cUx3QTZFMW4xWVljYTJlTlRa?= =?utf-8?Q?MTjSmIt7NDvnT3u2dY0j8/Jfq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 79c96960-3951-4505-4de5-08da65902948 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 11:58:26.9896 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5N2ejT+/OeDuqLGIIWQH2fOZUZthDIqcxQ6YJyrd/d4IyljUD0U0FXBK6LU1/OEgcocbVxyDXv/KI9wWf9i9Kg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3676 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > +static int xue_init_dbc(struct xue *xue) > +{ > + uint64_t erdp = 0; > + uint64_t out = 0; > + uint64_t in = 0; > + uint64_t mbs = 0; > + struct xue_dbc_reg *reg = xue_find_dbc(xue); > + > + if ( !reg ) > + return 0; > + > + xue->dbc_reg = reg; > + xue_disable_dbc(xue); > + > + xue_trb_ring_init(xue, &xue->dbc_ering, 0, XUE_DB_INVAL); > + xue_trb_ring_init(xue, &xue->dbc_oring, 1, XUE_DB_OUT); > + xue_trb_ring_init(xue, &xue->dbc_iring, 1, XUE_DB_IN); > + > + erdp = virt_to_maddr(xue->dbc_ering.trb); > + if ( !erdp ) > + return 0; > + > + memset(xue->dbc_erst, 0, sizeof(*xue->dbc_erst)); > + xue->dbc_erst->base = erdp; > + xue->dbc_erst->size = XUE_TRB_RING_CAP; > + > + mbs = (reg->ctrl & 0xFF0000) >> 16; > + out = virt_to_maddr(xue->dbc_oring.trb); > + in = virt_to_maddr(xue->dbc_iring.trb); > + > + memset(xue->dbc_ctx, 0, sizeof(*xue->dbc_ctx)); > + xue_init_strings(xue, xue->dbc_ctx->info); > + xue_init_ep(xue->dbc_ctx->ep_out, mbs, xue_ep_bulk_out, out); > + xue_init_ep(xue->dbc_ctx->ep_in, mbs, xue_ep_bulk_in, in); > + > + reg->erstsz = 1; > + reg->erstba = virt_to_maddr(xue->dbc_erst); > + reg->erdp = erdp; > + reg->cp = virt_to_maddr(xue->dbc_ctx); The only place this field is read looks to be xue_dump(). > +static struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > +static struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > +static struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE); > +static struct xue_erst_segment erst __aligned(64); > +static struct xue_dbc_ctx ctx __aligned(64); > +static uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); > +static char str_buf[XUE_PAGE_SIZE] __aligned(64); While I think I can see the point of the page-size alignment, can you please clarify the need for the three instances of 64-byte alignment? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 12:06:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 12:06:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367655.598731 (Exim 4.92) (envelope-from ) id 1oBxbh-0008Si-7p; Thu, 14 Jul 2022 12:06:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367655.598731; Thu, 14 Jul 2022 12:06:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxbh-0008Sb-51; Thu, 14 Jul 2022 12:06:13 +0000 Received: by outflank-mailman (input) for mailman id 367655; Thu, 14 Jul 2022 12:06:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBxbg-0008SV-Il for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 12:06:12 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 59dbea78-036d-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 14:06:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6584.eurprd04.prod.outlook.com (2603:10a6:20b:f5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 12:06:09 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 12:06:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59dbea78-036d-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTqt/DUwXhNpyWP634WFNHQFHMJbrSxDD8KIvjY/FdeN1ODI0d2duLk4Jy6k0cLJv4CPJMj4+gtgs/d5z08j+clNpmGaJzX+J4rweyyvm3VrnUcpOVorHKx/lUGGHmS53wqZ6ZH2rnp6R+xRKcUadw2wiGUTf+KBFMTabI0hXxdEinGsfcjqy5ZtzQq9ZHAGx7cYKySme2Nr1c0RS2wzSBqBWxKcUfd+Ql0zAWwrDQVeft7nmDQh2Rxbsfp5sh64fQLSzGjoa59+YlkxAr2Fdu21I7VgFcba9xXTVVu0vDUwvlILMvhSd+Iky7xQnDFqrqoViKv+JRuSMWZ2y7QNWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bv9ZxjO+xZzNd8Lu6UIjQ0aHJCqx3bltUUDcdw/vLJ0=; b=ZTaGcU86ET0DOk8JMv2o01QhDTJbFh6y7BtZevY56FykFP1SISVsACOVPtup5NyVlvSKm58LCMkTqiuqygS6qx7qj7ONIcdpKXB13DcLAN62hA9Qmmv/qk8LgpcYuOsErE8VGQz0VXDSbWbA9pU8vabhjYUS3vpk8+VqJrfbPASwUj0tk0s5LWwnF6T/ICVuJ3HPFYLnFUsGwI1u54elvmHit6L3Zb5wN7ekag7EN06TpKWJkzySpf01fBHuYT+ocDpW+RC8jx3hpo7/FKl/O1ISi3kqLXZ1iwiGGa6gX1zV7v5LaOiirl3MsXWSbaEBtg/7NlBjv1K1Av6Fg9sYIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bv9ZxjO+xZzNd8Lu6UIjQ0aHJCqx3bltUUDcdw/vLJ0=; b=Iadi9p795IP6k819zfiMfwrDkTW0/ei0xcJhOwev4wz3+A8CDh1JtosCR6CVuh3vnWzoq/fG9tNWDgS2glDZ1tbd+sQTfsCNxiWK45RwZmmPjRY0SOPvM6FXe6lbCKTB5Cn4EzcJlqnUqW9fitj2mF50MrRMdX0MAVO0pW4awKyTnLYU16LNv/4ssb4qX40EbuqH3Y6+tJUcNL6+KOFzghcG8aP7HwmPLJP8j9uk9zjnuaxBMXdes9y7+7utj1cnRMvmeESVS347nq30prfUqYZdKVE8Rkl4dva3GPmriruRfRF5HwXO7WLSMh3sWXyLOiyxidWZtmFlW8SoT1ZJgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50867e92-8d35-44d6-e10f-a26f35f53221@suse.com> Date: Thu, 14 Jul 2022 14:06:07 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0143.eurprd04.prod.outlook.com (2603:10a6:20b:127::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 30496200-a505-4f46-88cd-08da65913cbd X-MS-TrafficTypeDiagnostic: AM6PR04MB6584:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a1USaZAF763HeGxhdOcyH8gKtEXJd07LxsgDf86yUY9NxFL+qF6v4vs4A9zEy4cviW24/BwCcxn6fsaG4yLwznAeXZ3/o6PRv3o5K1HurJSdpk2AJxdkG/8xefl73nvyO8JJ3IHKLF30/7DU9tF7OpWsXhATiBgyenDQSg9+M0hLsBpU77idZGbg62BqSS4fIdVjuVDoSlDX8uXg9apyuKvNghu/AKuwyIdp/+BvHPhEJ95aD0zFQA872yOaEzlkKsTgvShSCW/3FLyTWrt5rAjceudo6UyY0oDjGPptd+4WxE/f/ELbm4/luBYZ3fmZ9lF/141aQgK7iQ+gXHZZknLyupRf4rgQJ4b8eaJk2ulNF7fgHRM5sJay4LG2XK/ijos30byxfcwqC9YRMCVsAVhZGg4sJe8W1UUq3ygJdIT2amvQjBbjyLrdJkJaRqHIdU+TfQ/p0S0M2tyqQobHCidvuLOKE02pBOjWoAu923OwG4HlRm7V40/yw4gS63nRMCjaUDYtfy5NGRess40nkWxvEhZ1M5pGkgkfNMUG5lM0sIaFC6pXw3ADg8VF/rMRRZyE7HreOJnq5Crz7YHaf0mrGt5BTX/aQiD9funMYw4HaIo/NWr1odnvxhQifgvL7RzmaplJAISLFoO1FN1hOmayrNZevCJYqnlkDwixu1ejGjUfz8z9nA5p4SAcFDKcywLgXcloUKQsCapNrWexZ6GpS0neIfj4xJH+h31m42fYCWjB7ITL6efafMtF/YgQk17+szw+zSb0MxrHY1qGDnB8dDK1ar7SOts5mq5LnKSYSu18UOPu1hcpi/+jKD8rpKHOkPcUIqwc907sS+nEzJyBiSZyruIQ2UHgk7NvvQk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(136003)(366004)(346002)(39860400002)(4326008)(66574015)(53546011)(6506007)(6486002)(66556008)(86362001)(478600001)(8676002)(66476007)(66946007)(5660300002)(31696002)(41300700001)(8936002)(83380400001)(2906002)(54906003)(38100700002)(186003)(316002)(31686004)(6916009)(36756003)(2616005)(26005)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmpScmd6Slp6VHBRWnFEQjBxMkxJbHk0cGV5dm8ySlZvdDFFTmZUallIcFhC?= =?utf-8?B?MlZ0ZlhxcXVYNERCWGNHcjk2ZWpBdlFycnBmcDlOMktzSTJuMkNPSDZ3ZWVw?= =?utf-8?B?NlBobGxLbWU0Sm5ZMGh2KzRCTm9ZQVNYbHNGOHdxcE1URmhyQ2VJR2p3TjdE?= =?utf-8?B?NnI1OHppRWpUYXRwemh5RnljSmpLd2h1WjBLb3JnbnhCNXFuWnBqUmR6ZjJS?= =?utf-8?B?cndRSDFDdnpDQlgweldHRmloZlQrRFZNZkx5bFZzdGcySUZLSXFSQW9Gc1Fr?= =?utf-8?B?ek90ZHM4bnhKdnBEOE1NVkVHNnVCc1JORnlUU0ZxMjM3ckR2SnA5blBJLzZq?= =?utf-8?B?MjJSSE5iOXdsRWg2S1ljRE12RjArOHpnQWorM2NxbkdrUGQ2RnVob2JFVGlN?= =?utf-8?B?NGV0cmo5d1NNcG5SUC9PNXV6N3plQnZKY09TOCtUMEJuZjlGVFFEdEF3Y0c5?= =?utf-8?B?d1FybUQwTGlXY0ZiR09uNUJPRFpzb2U5ZWZzQ3BiSm8rZ0pYTXNpWHZWdlRU?= =?utf-8?B?b01leEFoWUE4cGZVZ1QvdDVYdk9MUEI4aXI3Mmo3RHY2VlJwc2k4eDBDNkdq?= =?utf-8?B?N1c2OWR4VmlERkhtUEdBVFdFMmRqeVlUNFpKeW8xU1BJNzZxdzBybmZRZ3F4?= =?utf-8?B?OEJROW0wNW5TelIySWlBUGtpNU56ZmZUalU0V1BZaWdnWTdRa050MUlvaWhF?= =?utf-8?B?SGRZRHBUd09adlBxTy9qZXhBYnZ0UVRUbHJ0ZWJIa3JUTkorVUZJeU52MW5K?= =?utf-8?B?WWpsaG9GSzNoREx4ak13cDVQaHVWZnRzd0NGMTdpd0RrUHM1Nmg2cFNLVXdq?= =?utf-8?B?dHluL2loT0tOWmlIVmpBYUpsQm9xa29QdU1iaXpNeWdYczF4STR2M29KZjkr?= =?utf-8?B?WjJ3K0ozN3ZqMkxxZ2k5TUNHV01sYUJ6VE92MWlUYjVyaUtucTYrWXNiSWRa?= =?utf-8?B?Z1lPcWNhQWdZNEZoNWpzVG1PcFl5OVFmQjdDZHdaMmFZcTBlQ2hzaU4zNUVI?= =?utf-8?B?T2ExRk5rNVNDVkZRcUU1K0RoZUw2NlNhYXQ0TVJMWjQ0VDg2MnRVRWtxM0p5?= =?utf-8?B?ZG5rOTFkNlhVRkxoWG52VVU1eDBORWxvbm9OWnExT3R3VzlqZFBDVFk2ejhE?= =?utf-8?B?alVLTW9zK3Y4WTV0R0JVR3lndDVub0M5NXN1Mm1HQjUrcExrTkl2dCtKMHp2?= =?utf-8?B?SEJJL3g5R0NlT2xqZmlFeXJ4VEdxczNkRm9MeWwwQjBtbkZFcExScFZiT2hL?= =?utf-8?B?a3ljcVEwNjJvRjQveVlQc0taQ2d3aW1KSUtwam1Tb2F6aFU2V2I5eUJHKzNS?= =?utf-8?B?dGhDNHZaeDBDZW9DSHhEcHVubXIwSmt2aXFWYytISExiZlR5cDdybWxCZGtT?= =?utf-8?B?bHFOd3hYaDFJSWJoUTNnODFPN2tEQ0IrNVRDMXo0bHluLzdlZlI0NldFUXBi?= =?utf-8?B?b3lrZ24vZTd0dnZja1FwdUxXT1h6ZTZscVJPMFNHRjN0RWFqMWVzYnFrRzVT?= =?utf-8?B?K1VzdDZXOTcvekpaTXF4U0s5RVBFK0VwY211NzNsRDQwQjhyMmE2RHorSER0?= =?utf-8?B?LzBqZjRGSVRqNks2RVFyK2xhajdFZHdteFAxMjd6aXlVb0FzVSt6M0xsWkRK?= =?utf-8?B?aXY1N3lnRkx1NGVHbXFPRzI0UmtKaTQ4OTBaMnRHWktCRUhCVmt2WFJ5M3Rx?= =?utf-8?B?dGhwNmQ4aUttWmZUOEVGeUF5V1dGcmo3THplQkZXd21YaldDc0Nwa2Z5blN5?= =?utf-8?B?bkloZU9tRDZ0TjJtWEhGc2UzTFVLVzg2dit0Wjk2UzV2UHRUTG5CWC8rWnM0?= =?utf-8?B?U20zUnZhRW9BWVAyUys4dUZJazZ1VFFVek91Q2xaMnNFT0VnMVQrY0pXMVZB?= =?utf-8?B?eGVZNU8rdHJWd3hBS29IUFlTY0p4aUpJWWhmL2VjMHQrdFFDcUJjc3RzYk1P?= =?utf-8?B?T0hmRFRYSzdWRkdBb1Z5amsxMVhOSTZsejZGNkdCL2huQUtUaFlrZWRGMlZz?= =?utf-8?B?aXJIZFZGTW9mOXkrb3luemRJTkdKdHM3bTNobjRNOS85RnlSc2NFZWdWUkwz?= =?utf-8?B?cVZHSERaY1Q5a054K2Q5azBGRkd2bXZpalBLRTdIS3NCWlk2cjV2elBxRm1w?= =?utf-8?Q?kJIDJE2Dh/o29cW2fr8aF9+Y5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 30496200-a505-4f46-88cd-08da65913cbd X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 12:06:09.1470 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zDq88xCyrXKv9od0c6jdQmwV/W1AzkJGb4aTaPcEK6NOGeMjEwkVVbR5LONKjzndmZq7HFxGlswT2del81SWSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6584 On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: > That's possible, because the capability was designed specifically to > allow separate driver handle it, in parallel to unmodified xhci driver > (separate set of registers, pretending the port is "disconnected" for > the main xhci driver etc). It works with Linux dom0, although requires > an awful hack - re-enabling bus mastering behind dom0's backs. > Linux driver does similar thing - see > drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). Isn't there a risk that intermediately data was lost? > To avoid Linux messing with the DbC, mark this MMIO area as read-only. In principle this would want to happen quite a bit earlier in the series. I'm okay with it being kept here as long as it is made very obvious to and easily noticeable by committers that this series should only be committed all in one go. Also along with this is where I'd see the pci_hide_device() go. > @@ -817,6 +819,16 @@ static void xue_flush(struct xue *xue, struct xue_trb_ring *trb, > xue_enable_dbc(xue); > } > > + /* Re-enable bus mastering, if dom0 (or other) disabled it in the meantime. */ > + cmd = pci_conf_read16(xue->sbdf, PCI_COMMAND); > +#define XUE_XHCI_CMD_REQUIRED (PCI_COMMAND_MEMORY|PCI_COMMAND_MASTER) > + if ( (cmd & XUE_XHCI_CMD_REQUIRED) != XUE_XHCI_CMD_REQUIRED ) > + { > + cmd |= XUE_XHCI_CMD_REQUIRED; > + pci_conf_write16(xue->sbdf, PCI_COMMAND, cmd); > + } > +#undef XUE_XHCI_CMD_REQUIRED > + > xue_pop_events(xue); > > if ( !(reg->ctrl & (1UL << XUE_CTRL_DCR)) ) > @@ -916,6 +928,13 @@ static void __init cf_check xue_uart_init_postirq(struct serial_port *port) > serial_async_transmit(port); > init_timer(&uart->timer, xue_uart_poll, port, 0); > set_timer(&uart->timer, NOW() + MILLISECS(1)); > + > +#ifdef CONFIG_X86 > + if ( rangeset_add_range(mmio_ro_ranges, > + PFN_DOWN(uart->xue.xhc_mmio_phys + uart->xue.xhc_dbc_offset), > + PFN_UP(uart->xue.xhc_mmio_phys + uart->xue.xhc_dbc_offset + sizeof(*uart->xue.dbc_reg)) - 1) ) > + printk(XENLOG_INFO "Error while adding MMIO range of device to mmio_ro_ranges\n"); > +#endif > } According to my counting there are three overly long lines in these two hunks. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367662.598741 (Exim 4.92) (envelope-from ) id 1oBzzq-0002UX-7W; Thu, 14 Jul 2022 14:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367662.598741; Thu, 14 Jul 2022 14:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzq-0002UQ-4p; Thu, 14 Jul 2022 14:39:18 +0000 Received: by outflank-mailman (input) for mailman id 367662; Thu, 14 Jul 2022 14:39:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzo-0002UF-NF for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 14:39:16 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b98e8788-0382-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 16:39:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b98e8788-0382-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657809552; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=dQODjwmva5Xst8eJxHRwQB5vT+181m4vKnymdYgFv3w=; b=LWROWe4EUcDr6f9rSfL+cnnVNuXehkSGHuxgsAFe+ff3eMl9fTE8yXhh DyjDn6wVAfCTTRmMH+uF27scjEfM9PvzgCM6E/FUGSUL6pu+7Efdu5chX 281pcuigRKjd65QTrFat2aF/9eyLPBe6I1R5Hy7bFbnzuG9TdPjQosZq7 o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 76233198 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:KLKSWqukjaWcl2wmx+3d8PmOLufnVHBeMUV32f8akzHdYApBsoF/q tZmKTvUPfaLZWrwLdEjOo+1oE8HvMDXmIRqHgdoriA0FC4Q+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzh8B56r8ks15qyt4W9A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYhbxNYsHEBvz vAndykDfC282tiS3YvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3Fb4SPIYfTFJU9ckCwn kbmvD6oP0kmG5+ikwijy3Xyne3tpHauMG4VPOLhraM76LGJ/UQRFRkXWF2TsfS/zEmkVLp3M FcI8yAjqawz8k2DTdTnWRC85nmesXY0WdBdDuk74wGl0bfP7kCSAW1sZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluaJiw9PWIEIygeQmM4D8LL+d9pyEiVF5A6TfDz3oad9SzML y6iqWsAt+4OrO8w25rk5F7Vvg3xnLzUd1tgjunIZV5J/j+Vdab8OdH3tAmDsK8YRGqKZgLf5 SZZwqBy+MhLVMjQz3LVHY3hCZnzv5643CvgbUmD9nXL3xCk4DadcI9Z+1mSz285Y59fKVcFj KI+0D69BaO/31PwNMebm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzRdzyv5jY cjBKZ3E4ZMm5UNPlWDeegvg+eVzmnBWKZ37H/gXMChLIZLBPSXIGN/pwXOFb/wj7bPsnTg5B +13bpPQoz0GCbWWSnCOoeY7cAFRRVBmVM+eliCiXrPaSuaQMDp6UKG5LHJIU9ENopm5Yc+So irkABYImACg7ZAFQC3TAk1ehHrUdc4XhRoG0eYEZD5EB1BLjV6T0Zoi IronPort-HdrOrdr: A9a23:HhLAa6qdCYPsPZIQ8itg7vAaV5usL9V00zEX/kB9WHVpm5Oj+f xGzc516farslossSkb6K290dq7MA/hHP9OkMMs1NKZPTUO11HYVb2KgbGSoQEIXheOjNK1tp 0QPpSWaueAdWSS5PySiGLTfrZQo+VvsprY/ts2pE0dKT2CHpsQiTuRfTzrdXGeKjM2YKYRJd 653I5qtjCgcXMYYoCQHX8eRdXOoNXNidbPfQMGLwRP0njDsRqYrJrBVzSI1BYXVD1ChZ0493 LergD/7qK/99mm1x7n0XPJ5Zg+oqqv9jIDPr3DtiEmEESttu+aXvUjZ1REhkF2nAib0idqrD ALmWZkAy080QKUQoj/m2qT5+Cp6kdR15al8y7evZMmyvaJHQ7TzKF69MRkm1LimjsdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw5zvmWehTMYd3E8LAt26RE X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="76233198" From: Anthony PERARD To: CC: Anthony PERARD , Wei Liu , "Andrew Cooper" , Jan Beulich , "George Dunlap" , Julien Grall , "Stefano Stabellini" Subject: [XEN PATCH 0/2] xen: check-endbr.sh fix and improvement Date: Thu, 14 Jul 2022 15:39:05 +0100 Message-ID: <20220714143907.25938-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.check-endbr-fix-v1 Hi. Anthony PERARD (2): xen: Fix check-endbr with mawk xen: Introduce $AWK in check-endbr xen/tools/check-endbr.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367664.598763 (Exim 4.92) (envelope-from ) id 1oBzzs-0002zj-Pb; Thu, 14 Jul 2022 14:39:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367664.598763; Thu, 14 Jul 2022 14:39:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzs-0002zc-MZ; Thu, 14 Jul 2022 14:39:20 +0000 Received: by outflank-mailman (input) for mailman id 367664; Thu, 14 Jul 2022 14:39:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzr-0002UF-AM for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 14:39:19 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bcdc8d90-0382-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 16:39:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcdc8d90-0382-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657809558; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dERAYYpHGNdDoJC+KVVotxHQ1VnjUBp5rhHFM0sXzE4=; b=MCK7bo/vXRh/8qb5578TiMBgnU8smrPJn9woVb8DeQdq1pPIr8TduhaM kOuhHxJJfIEvRuymF+z5bmX6bsr7chnRXwLYcaNhxL2ycEAD4kdtfWn6o VnUQdKTNDuTcpXrjJU9FtzMtfbT3sTg23AMUxTX8l1CdXeo2QExuYoZAU 4=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75798792 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AiXDNOq6KkQbvo+zrfQ9WOwxR2vbMJYB3ticv2?= =?us-ascii?q?ybIaGNq3BzvzP6J+z/mGEsNoGQgghEXUqHF+SBmUu4agP2hTNrF5aKgZyR3R?= =?us-ascii?q?4P4GA0qI50YOLPjud6PHCHi/1pOz2/MjEBijBIvfJmnoJTSD1r450U94P76C?= =?us-ascii?q?xccJKfJwXAzxWyrM2mO8kNp34j21uwmza5YK9eBcDdZSSM+Oq8WgedLlLy7L?= =?us-ascii?q?ilHHkFyRhaeczJEz38cw76laVo7i5/olpY3zrGbZTnTuBmPOdoJkVvFfxEnV?= =?us-ascii?q?VVg360t0pFhwiBmhiHjbr8cMbtbjo+MxvjrSTtQ14DTU7v0YL5xmn7tVwsVS?= =?us-ascii?q?2OnkB7RrGaQ5kH5IjXSUlG/oWRqcQwqOaK1Wu1D3LpBxiW87lG3SAH5N/fg3?= =?us-ascii?q?oRM6/k6U0A3yZsiFP/omaov9OXhyoMRQxzp9yi5up3rlFIdv7ZUq/7JYNBaS?= =?us-ascii?q?TFeeQkGSGtzhx4zrXhFnn0YOA4mZiCDtojdWaPEMBCDvwQ6QqXpy+elXXQ/g?= =?us-ascii?q?x1oLtf2l+HpiQTTor8PWQ4yo3x/Oqr0Sg35Bc1nPIdFSRt6HuHuCJfQYiQ08?= =?us-ascii?q?w6HbeZW6pBqLiki3YtecajmBOYxITr/jx5q6xJcUx+WXKM1xFd06B5FJhu7t?= =?us-ascii?q?nfxxu15URlUMPknFdmkspJXfiF7qud+m3xHtW71NRIIvJmK7VFqXJ+Wg52VW?= =?us-ascii?q?jyn/yEiGdx2UDbbVA+K58z3qEBXqILxEAe0rZl31CuexgqYcEx/JzWHO7RJi?= =?us-ascii?q?aG1BsMypDww2+Ctw3jArzZSDYwprMvqIK52uoFFsa+yx+sr3WePRvXhZEDjz?= =?us-ascii?q?1+vkGAlqZabNYYD+LOuApdGy3riUzitx/RAutaEd0mzgL/pPqsjfexIqW+ZS?= =?us-ascii?q?gZEiWr+dsk2pZLOydjULJVD461dtZ8grF6Z+m8wZZ5Ov0+1bhapbMrJfpZWL?= =?us-ascii?q?doseUGY+fzqJ5NfxXM3KpfHYmp9+gF4q4cY/muCm4bSf5uDqLmgLCgsZBHue?= =?us-ascii?q?qzJl+10Yu113VgXABjO2LHFgBS50AyD6yFpLouno96OnKWIHpgazx1eYm3FL?= =?us-ascii?q?lysRNNOKBnYX0H50hkcqRk0wzKiLmbFcbcGrbX7SLTUW8wZMxjCGb9akKAkh?= =?us-ascii?q?k1IxWVVWHhlmqk/UVjb7aWW+B1ano2yMj7/CUJS4Grry3hvnC2LzoqgIHgzx?= =?us-ascii?q?u6N7odaA2a+di3sbKRddy7tRFx+yBkY0IQY8tQEPB1TsAd2ys0jqHUPcAJN6?= =?us-ascii?q?sbdt6k+/donjUuCNZVjrrdykKysV3cfq6SOrS3pEcDDzmLMpk0ziNb6kTQ4w?= =?us-ascii?q?GQPQKK4XsyWw3J3PCn/2epLQ8rCnGhthvhKH1GI1LShfXi0rW0J7gFP8J5MO?= =?us-ascii?q?HRdV1H9CbTPH4SfN2jp8Fd1MN4nXmnl9l0tGEs8PH+qA2EFrrVWjYm0sxoKR?= =?us-ascii?q?5RXYtt+mptl4HJ8qNpRyn7npjZ/uDOuollSs0bfVNmqykJhB2NOl7mBtHQef?= =?us-ascii?q?tf73jofkSS0mxpjNvUsnM0s2ygxP1+pR9KSpoaaZL3oCwGEiIGV5Wkh9sBNY?= =?us-ascii?q?Sxhej1vviDMHN2RLZL9e8S1xzMxmOSpD62qABxPfd6LjZcL5fbgaA8ab2YMo?= =?us-ascii?q?aDZHnZrMUD8bA2jXfBFsQjjHKbBlT0n1A9C5H/Y1yuCWjMyeFHzKl4f6+FoW?= =?us-ascii?q?hd9unqNCoL33o1SYNALpcXZU1UZHma4igo9ZrCbTunGR5akx/UHsIEs4DOaK?= =?us-ascii?q?j4x7yH2Z2VhlFcazZZ2mnkG34hGn0wGhw8v5UC+Q3neOxqmISh9K1dlbgiru?= =?us-ascii?q?XfsWLNvo/0+2sUja72gij3XPraCtI5xYsV3GupDCZPDgDfbgQzsDa2K1BuJ7?= =?us-ascii?q?VsEDaxA6PQGM0fqS3pnUADPKDVVQL2WAalt7g7lKPJs+Z13EBOV5IXKuDgCQ?= =?us-ascii?q?ct4MiYmtrbW+x0oI5Soaf0fRTCfB/LS50VMy5+wyr2NsavrM5kp1ADi+lH88?= =?us-ascii?q?D5kqqSW/VhTiN47vCZqjgqj07CLlxWwsJ1581JirwIgPbS5qtnFsA4Uvqlfa?= =?us-ascii?q?lNjRWUuZAgkqebKxXnlWXDLka4PR8ZzvvyzEIhhQSAmlFNk8vXkyQlGFxJjW?= =?us-ascii?q?r7IvBFRCd2jYBKCRcpji3lf/QMlMqGyf0/NWLI5c1DLZ17G2lby2Qt0E5qyK?= =?us-ascii?q?DRffaxLuzNLZDBHD5Dojtwmi+MZed/VOpqDOwluqHBkE+JR9kzBzh2U+Vyep?= =?us-ascii?q?KWMptqQfgdPS5L2Vy9C1+EamuGik82R04s7amRdx1Suxadg22Rvp4PlEmQTO?= =?us-ascii?q?pCJSr0yu0yY6os1Bnxp2g5JvkAjzxeeSVTNOue9pHFY7ncuzj9fD+td6g8D+?= =?us-ascii?q?eNHKh12p3DH9pCBSvnbXHIPXzYTafac/038UE3jmRucQCpfieuSAPRyz5bVZ?= =?us-ascii?q?1H98P92BOlgPp8x5MEEGYaCio3Ph+L4/DMQ65lgVrkwjAjF57FXZRVnrUzC/?= =?us-ascii?q?ANrWbN3ovroCIbU/1LkokPJN8gho7oGakmtIhh8IbIFzSKJSrqN2+Qfwk74n?= =?us-ascii?q?8yIU5kdCfvF3OAJpar+5bFZMGdnVyfZ26SLQUHprSuKaNSoYVhCYdrL7cJKl?= =?us-ascii?q?WBlsMF3q+7VXCU2c1uAthfhHZ+IipvH2z7yAfsjhgaC7r72T+wTEZ320bljA?= =?us-ascii?q?h0kI08wVsJbq3YZtj+uB+qxn4itMlnc/VAFyYsOgYFRW4C+4Csf0gWwjpxJS?= =?us-ascii?q?wi6lGrVYebNFWpR4zS58cwXjangMABpudta8CfCUpgKAQ4y6ah/qbx3DLMAM?= =?us-ascii?q?qrmkmtasd8q/rRacCdYyN7h+Qm0B0UHbIRw412VaWF4jEjK1ewdc/5CrGlZt?= =?us-ascii?q?DWngAiTR1wW3g=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="75798792" From: Anthony PERARD To: CC: Anthony PERARD , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" , Wei Liu Subject: [XEN PATCH 2/2] xen: Introduce $AWK in check-endbr Date: Thu, 14 Jul 2022 15:39:07 +0100 Message-ID: <20220714143907.25938-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220714143907.25938-1-anthony.perard@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Signed-off-by: Anthony PERARD --- xen/tools/check-endbr.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh index 64fa9a56b7..523797a15f 100755 --- a/xen/tools/check-endbr.sh +++ b/xen/tools/check-endbr.sh @@ -10,6 +10,7 @@ MSG_PFX="${0##*/} ${1##*/}" OBJCOPY="${OBJCOPY:-objcopy}" OBJDUMP="${OBJDUMP:-objdump}" ADDR2LINE="${ADDR2LINE:-addr2line}" +AWK="${AWK:-awk}" D=$(mktemp -d) trap "rm -rf $D" EXIT @@ -64,7 +65,7 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & # numbers, which don't lose precision. # eval $(${OBJDUMP} -j .text $1 -h | - awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') + $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN @@ -78,7 +79,7 @@ then else grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ -e "$(printf '\146\17\37\1')" $TEXT_BIN -fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL +fi | $AWK -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL # Wait for $VALID to become complete wait -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:39:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:39:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367663.598747 (Exim 4.92) (envelope-from ) id 1oBzzq-0002Y3-HJ; Thu, 14 Jul 2022 14:39:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367663.598747; Thu, 14 Jul 2022 14:39:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzq-0002Xd-CI; Thu, 14 Jul 2022 14:39:18 +0000 Received: by outflank-mailman (input) for mailman id 367663; Thu, 14 Jul 2022 14:39:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oBzzp-0002UF-6s for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 14:39:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bba4ace8-0382-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 16:39:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bba4ace8-0382-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657809554; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nc5Of1JguiIJKYdeJhWijIYiWRv/ScVk33+JiERSYGg=; b=KYH0OLfzZ3I0ocFT0wZbfP/EykCmbVhy1E3B5Er3oUtH+LhX67fKZoKg wl/oxwxiZiijxCxdm43MfIKJLZfvq9zr3FwbKo+RYn9BvB/aopS9fpAA6 mbj4P+Pspk4J7GKyeAOK4zP2mFd3jKWa+4e9oFDIBYMIMDf5vnPr5FzsP M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 76233202 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:gN8p9qD3SjtKExVW//Xjw5YqxClBgxIJ4kV8jS/XYbTApDoggz0Bz moXXj2EPq2La2v3Kd0jbtu09EIPvcXXx9EyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsv7b8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW3S9ztlIHkQ5BIcn2MpcGCZh8 OEjCC9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDaJl1criOKF3Nz9J8yEX9l2tHijp F3Uo1zCGUEnBN2D1m/Qmp6rrrCWxn6qMG4IL5W66/prjVu71mEVThoMWjOTuuKlg0SzX9ZeL U08+Sc0q6U2skuxQbHVQBmQsHOC+BkGVLJ4Eec39QWMwar8+BuCCy4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkA9CXIJbGkqRA0O7t3nvak6lBeJRdFmeIawh8H1GDzth SyDtjI3g50Ll8kX0KO+9FHDxTmro/D0ohUdv1uNGDj/t0UgOdDjN9fABUXnAehoI9eUYn+Tu Xc9kfe8wMsXSr6IiRetX7BYdF223MppIAEwkHY2QcR+qmX1pif7FWxDyGogfRk0a67obResO RaO4l0Jufe/KVPwNcdKj5SN59PGJEQKPfDsTbjqY9VHefCdnyfXrXg1NSZ8M40A+XXAcJ3T2 r/BKK5A9V5AVcxaIMOeHo/xK4MDyCEk3n/0Tpvm1Rmh2rf2TCfLFOhaawTSNr9jtPjsTODpH zF3bpHi9vmieLemPnm/HXA7dzjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/I7Nj7dNxvwP/s+Rp ynVchYBmDLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNtIeJ+rrUznaQrJ xTHEu3Zaslypv3802x1RfHAQEZKLnxHWSrm0/KZXQUC IronPort-HdrOrdr: A9a23:RDxlcaFXdJliAEVtpLqE7seALOsnbusQ8zAXP0AYc3Nom6uj5q eTdZUgpGbJYVkqOU3I9ersBEDEewK/yXcX2/h0AV7BZmnbUQKTRekIh7cKgQeQfhEWntQts5 uIGJIRNDSfNzRHZL7BkWqFL+o= X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="76233202" From: Anthony PERARD To: CC: Anthony PERARD , Luca Fancellu , Mathieu Tarral , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Date: Thu, 14 Jul 2022 15:39:06 +0100 Message-ID: <20220714143907.25938-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220714143907.25938-1-anthony.perard@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain check-endbr.sh works well with gawk, but fails with mawk. The produced $ALL file is smaller, it is missing 0x$vma_lo on every line. On mawk, int(0x2A) just produce 0, instead of the expected value. The use of hexadecimal-constant in awk is an optional part of the posix spec, and mawk doesn't seems to implemented. There is a way to convert an hexadecimal to a number be putting it in a string, and awk as I understand is supposed to use strtod() to convert the string to a number when needed. The expression 'int("0x15") + 21' would produce the expected value in `mawk` but now `gawk` won't convert the string to a number unless we use the option "--non-decimal-data". So let's convert the hexadecimal number before using it in the awk script. The shell as no issue with dealing with hexadecimal-constant so we'll simply use the expression "$(( 0x15 ))" to convert the value before using it in awk. Fixes: 4d037425dc ("x86: Build check for embedded endbr64 instructions") Reported-by: Luca Fancellu Reported-by: Mathieu Tarral Signed-off-by: Anthony PERARD --- xen/tools/check-endbr.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh index 552f233912..64fa9a56b7 100755 --- a/xen/tools/check-endbr.sh +++ b/xen/tools/check-endbr.sh @@ -78,7 +78,7 @@ then else grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ -e "$(printf '\146\17\37\1')" $TEXT_BIN -fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL +fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL # Wait for $VALID to become complete wait -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:51:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:51:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367682.598774 (Exim 4.92) (envelope-from ) id 1oC0Bl-0006Eq-0p; Thu, 14 Jul 2022 14:51:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367682.598774; Thu, 14 Jul 2022 14:51:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0Bk-0006Ej-US; Thu, 14 Jul 2022 14:51:36 +0000 Received: by outflank-mailman (input) for mailman id 367682; Thu, 14 Jul 2022 14:51:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0Bj-0006EZ-7v; Thu, 14 Jul 2022 14:51:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0Bj-00065B-6n; Thu, 14 Jul 2022 14:51:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0Bi-0006bu-Jf; Thu, 14 Jul 2022 14:51:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC0Bi-0004jp-J8; Thu, 14 Jul 2022 14:51:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=59YvDnt27p9yC4BLNXr+EUSiBsw4IvfysDzkPhN6inM=; b=2kWPjSwqnE7hbrPtvfA/PtXggf XJWJg42Oc7/97RL/CSzWiQpK8gFsvJHk4xFSEuR+qXGCK3yuLdKCg2nKjCp96+kXQDHCrNVLBA3Ld ofTtqnG8uX7JPDk8MJWfllSi81jT8qPKT4sK7ydHzQ5HAmvRu4ebm4FY/+46XBNY8zd0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171629: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b X-Osstest-Versions-That: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe From: osstest service owner Date: Thu, 14 Jul 2022 14:51:34 +0000 flight 171629 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171629/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b baseline version: xen d8cb7e0f069e0f106d24941355b59b45a731eabe Last test of basis 171602 2022-07-12 17:03:16 Z 1 days Testing same since 171629 2022-07-14 12:02:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiamei Xie Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d8cb7e0f06..355caa9ef2 355caa9ef29fd4bcdf48bc263e6ca3b24392490b -> smoke From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:54:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:54:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367690.598786 (Exim 4.92) (envelope-from ) id 1oC0E9-0006pB-FM; Thu, 14 Jul 2022 14:54:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367690.598786; Thu, 14 Jul 2022 14:54:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0E9-0006p4-Bn; Thu, 14 Jul 2022 14:54:05 +0000 Received: by outflank-mailman (input) for mailman id 367690; Thu, 14 Jul 2022 14:54:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0E7-0006ou-Cr for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 14:54:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cb5bdbd6-0384-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 16:54:01 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 10:53:34 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6625.namprd03.prod.outlook.com (2603:10b6:806:1c8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 14:53:32 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 14:53:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb5bdbd6-0384-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657810441; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=+qesU61S1uD2pO1BRVOwgxgzkC4AwXaj4uyltg6FBc4=; b=O2cF9j80mIM3sZ/fnos6hmQgrIx7JNu6wE21xUzzEtPFGPIvy6KbTRM+ qZZG8hLOCcI9uE+WEUL/SHX2YBjOdGg3eVHiErUtT3ToYEVL9De91M6RQ aZQltCisaUudeJnYaAdjsVV93BUxhGbiEHskB2AWfwz/BcWynC0aCQX2I E=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 75622518 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:2PAu0qAx1Iro8BVW/+jiw5YqxClBgxIJ4kV8jS/XYbTApDwh0mYCx zcZUDrVa6mJM2enedAjaoS/8E9Q65bXyYMxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsv7b8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW1vox+VANEw0BtYn/eZ+OE8S1 voaFC9YO3hvh8ruqF66Ys9Fo516aeLMZcYYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14wbnu3yahG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFaYLFk2fcohpAgMfPnDvJdJAMNoSq//9Frk20934KAgUvAA7TTf6RzxTWt8hkA 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mlyKDZ/gKYDWgsVSNaZZots8pebT430 l6Emfv5CDopt6eaIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyKksijrfQ9AlF7S65uAZAhn1y jGO6SM53rMaiJdS073hpA+ZxTWxupLOUwg5oB3NWX6o5R94Y4jjYJG07V/c7rBLK4PxokS9g UXoUvO2tIgmZaxhXgTRKAnRNNlFP8q4DQA= IronPort-HdrOrdr: A9a23:bFL9yaGhQW4rd8HRpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="75622518" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7VkKkFFg7AyWyhMqQl8M2goPyLGDNdkGyc4bavQs2aWihkEmmact0f3bjBKZwXE+jyqtVN1IYl0Sn3ACtp5dyuBGSvdIi9LnpcnhOYOl2unShBwHcCAclOXGV/ZerSpUTfd7BxWjgwT1lmArcQpR/RMeiMXoQRoGXDc/za4Ew1inijSKg2vq+yUHp+223yMt1wnJaNUePHh+exqof6rEDNxN+aZgf5d/nvzBMDz9iUWuSA2HJ3GomWueJVRa1AO0WZEWF+uAlBYEBjsbJM/Zzwo/d10Zzy6SAuaJqf6J9KG3eQlefU7Uk9j+iKtBo1PtLFWHQC8eqSboqR84RiqLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+qesU61S1uD2pO1BRVOwgxgzkC4AwXaj4uyltg6FBc4=; b=AJZE+bwYEv5EMuY3KEPQRz6r6OgbAwBTgpLZjckx02+P3sq0jCIXugiQvyPyNgZ+dCamtyz03Bz0bYrXqyZSV1LaE5BB3YN37vJKibpPupq6PJc8CFrpy/m/0duB+LanF5hQGkdIZrBkGDLqLMm+b7oAeTSUq2qbOGmkRQlkOGsYoYj8vaiChpaqFBLK7EOrdxqUGTuclKD2Oi/PLFJOVTeQIpcW1lhx4nfllP7j6BX8N4n4aKf1ASBHZXv01oiwfLqcFnmUfB8jVwgfKSguEcr+xgF4dodjW5BhFkO35KX+49qCoYyVotxRc5DpQY+4UbIHuRIAjLZIXLYaM2/IlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+qesU61S1uD2pO1BRVOwgxgzkC4AwXaj4uyltg6FBc4=; b=sCmvfwQvMTFaTbVwV5F1aNZSqH29meva8VK4PJXnMD4Jg9XnC9w1Mp/+zgYddQwM6yxVoE0elnPchWjM8k667lXHHOWgPs5P9Z/OB1PEFUcp4RjsblU5/TDkJUMHyiXw9PF+eaxUS5U6u4HbUIYk6BAaoidyfEt/+15sGqmg5yA= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH 2/2] xen: Introduce $AWK in check-endbr Thread-Topic: [XEN PATCH 2/2] xen: Introduce $AWK in check-endbr Thread-Index: AQHYl4+EPxA5nYqw/02GdHJyv+moia1989iA Date: Thu, 14 Jul 2022 14:53:31 +0000 Message-ID: <9e811b53-2859-3d8b-b503-527cb187cfd0@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-3-anthony.perard@citrix.com> In-Reply-To: <20220714143907.25938-3-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 924ade66-e44c-4acc-668e-08da65a89ec7 x-ms-traffictypediagnostic: SA1PR03MB6625:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eUndIf1PhyCfReVPdMjaU554KljWjvlrktNdUhCC9jqUiydVHdgvD8NpJe6nhoKaqrBbFl07IA/1ebc0K1aKuMwIQoCTz7za9SXQrD/vX0IpOyPESoUP65x9XUzyRDC6NQ1GZpUol0OKvd4DzClWra49Up74llQctyqs8UdR4vdMjvXMUPSX0lDjqJwpM3sTjahWVgOtLatVDwH0ofAin+VZ/SbCZOBK/w39d7ybLsUXCiKDInXKXzOxApSINa8nK8XhBvJwClzhnXrbrixgxUAuQbOh+Ig+/N/NZfdXSvtnVoI0k6EfLWgKfJ1jt5JHcigyHnEsglOwEK5xtgau1RLkWacDP6EmlHoobOWwOFCqiLancoTuv2wuIrsdhR8gISbK3Zwqcy4Bd7z7sx78cr9j1Frau65eiQ5uy+TdEoRVgvFzp4hLXIowlKlDhlZmEe9zirfhp5zX3wlZ1exdw9o19YKZ6NBaHvXxoSMJwRwkKNHGm/2Z4trJjUimoOimtSkznw1rCnl3xrNqr8D+tMKlUQ1P16LI35RiaCbqoJYDJsd7YRTaH2EMe/cdg/E3MXQGNpTMoUUdIs0CBY3WRNlr/Wqe6Kskq3sks/do5OpOjwcUFyxI+w1XzIU83r/WzoZle7gw5zwhoKM1F8ahGJq5TLfKnC+gYS6jMyWqMGednCWT0/Q23R+5e9V/TljhCJ1Gbd1ifzV3RnMc/YIcjaYkZHPN7Cj1pEfpSlTZySIvkar4C5Z1ETp6W1qo8NHsuG2O6fnq745AtP1vztRbwk0geaS3Us+WhbZwvzsq1n9LZG6p2ff3o8knZeqjv1zQuJcDletQiR50GiN8ZUKuEMFMnoYV73mVRvs+hysyjklBQTtNVeSXVhwk8tJMCObt x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(396003)(346002)(136003)(39860400002)(38100700002)(31686004)(6486002)(36756003)(2906002)(316002)(122000001)(53546011)(5660300002)(31696002)(86362001)(66476007)(64756008)(82960400001)(478600001)(6506007)(66556008)(91956017)(186003)(4326008)(8936002)(41300700001)(558084003)(6512007)(110136005)(2616005)(8676002)(66446008)(26005)(54906003)(76116006)(71200400001)(66946007)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZXh6ZitGMmdUOWJDcXBRNUI1WDNGNlBrNVpjczBQazlrbnhwQzIxS0wzOVNK?= =?utf-8?B?SGpEdlV4cno3S2J4UkhxaWluMWVDL1V4QnRadldOd2RCekpwelBwMzNxNU5n?= =?utf-8?B?SDVpbkdUQm5yMXpKZDk3dkUwai9iMmlQaTlCWitzbEJTWWE0a1k1VkppbmQx?= =?utf-8?B?Nm94SlJLUldnNE1KaU1FNGUybmg1TDNNTHp5TEc1TXZ5QUtTYVUrYXJzZGxr?= =?utf-8?B?V3NlNGY5RlNrcFZ3U0RmRTloQ2FjTkhHcWZoTjZXcmJrM1FibGljMnFwMVBB?= =?utf-8?B?VFdkZ05EL1V5TEh6Mjg5UitGcWwzNndzSjI2NmJzM2NmTTI5RmFjdWlMRFdi?= =?utf-8?B?cXBnOU5mdU85djk4MEJjUFRSNlZ4d2hjU1RYMGhOUHF6cFdOTElpNktXeVdq?= =?utf-8?B?bHRmQThIeFkwaXA2RG9nWkYyN2JLdGZVRU5vTS9ESUkya3pzTW91ZWo3cHBW?= =?utf-8?B?aXlycVJDZHZQaDJaTHN6RTdjL2E2Q0szeFFlQ3o1VEkrakI2VWZXOUp0VXpG?= =?utf-8?B?UytMQUtRUTJ3V29FS0lvZUVpNTdpQjB0cFkrazd1NmVaVlhuUkhmYUpVM0cr?= =?utf-8?B?bFdTdC8xSmRNRG9aOHpSMlRDMVpBUms5TFUvNXduZU1TZGNYRHBuaHg4S3Rk?= =?utf-8?B?Q0h3eEN6dEFuTkphUFB1R3hmd25IL0FKd1o0SXhDWkhDaEs5Qk4wMjJYb2t6?= =?utf-8?B?RitkYlJ1R0ZYd0J0U0hQc3hRS0JDUDNLRUhxY1F5QkZNbUVaTGZwNlZhcGpU?= =?utf-8?B?dkl3UTA5cHM0azZ4MHRwQkMzZkhTWFRaa01aUjhrb21rRkNxdlN4U3d6SVMz?= =?utf-8?B?VFVtS2VYRStPVzN0UFRrZm8zYUhzZUV3KzRsMm5MdSthTndVL3ZLSUhSQVpO?= =?utf-8?B?M1pIY2cvNG9mY29QeHp4SzdjNkwrVENhcVV4Z2dDYzlZRnZCaTFmSzlOMEJl?= =?utf-8?B?K0FGNm41VDIybXNmK29iV2dRYVQ0eWVXTjJLZXRyUkdzdUNKK0w4SFk0N20z?= =?utf-8?B?WWdWOW5vaFZnSE83Z0p0V0EzZ04yNXMrZkc1SGh0UFFoZVc5S25lSGVDUVho?= =?utf-8?B?UW94b3IxZVE3ZnVnOGFUQ2diK1lVblJiNmVUTS9YYUYvaFJqTUFxTlBXU3g2?= =?utf-8?B?QVZYN1dvUWZXTUMvNGVaT1l1T0dMbm13V200bXdTQU4ySlEvUWVjUWtmOU43?= =?utf-8?B?UCtsY3hUQUlSRllscCtkSGQvZXB2aGV6ZC9vTUh4MU9FaFlsRExkdzRHRFg1?= =?utf-8?B?TDM0ZmZxeWZlVHhhYitOcG9XYWVFNE9WRlZaQlNiTkRjL0xSOTdtT3ErMWxQ?= =?utf-8?B?SHYwdi9LblJNRkFJS0JQdERWQWx5L21DR3Z5cTkyMUxkNzFURFBJOTVFT2pu?= =?utf-8?B?QjdFTlpZOEovYUlRS3Vjb2hYMnQvZjY3RVpMcEE3VFB3U3BDWElkOGZSRmcz?= =?utf-8?B?NUt3M0RHQWRzWkFoZGNWYkViRHlIWjdUQ3hxcXdlZ0FtYlNWSkRvRzIyREl3?= =?utf-8?B?a2Rqb1BlTTZVSjhXL0ovSmFpY0tyMmhNQU1EK3ZBQjRYY0FOcWVnU2hTRC9n?= =?utf-8?B?M1luT2dWNGR3UDJtOG8wVHhLdWtWQUR1b3hUMmJCRzdoMWRjUElmWlg2RW4z?= =?utf-8?B?ZWVLMk5GbktqaXNSZTZ1MGRpaWZxWjRKckQrM0dCZUVYY0hQQXBnZHRxVUpW?= =?utf-8?B?TmNXeVh6VFp3R2VsTHMwSWx5NHNmeGF1Y3laUFhzNy9QSU1LcGlRR1I2ZkhE?= =?utf-8?B?OVdHTk5abUd5UzNxRTQvaWhna0MxRWcva1ZTSW9wYUROWVRYZUwrejk1QVk5?= =?utf-8?B?cXhtOFMrR0RGSUV2ZDBFM3BvQURqTXJXV3A5UXcwdnhoc3dxdE5SSUxGQ29n?= =?utf-8?B?eHdQMlduc3pmdkh3Qk4vYTg3UC9ETkdDZjhDQVBrNkVZL0lsWmowcjJWN1FQ?= =?utf-8?B?WWhnVzZNWFZWL255UFk3K0ZFQVRUMWlxaGg2d1I3emhpZWdzQWQ3UXFrYXhW?= =?utf-8?B?NDJGRnErYUN0R0ZIYzk2TExoY2d0QnJWVVpWUS9tTGZjMXB1OHZZeUN1Qk9B?= =?utf-8?B?cGxrbnI4M2RGbHBrakZua0xZQ2I0MzFuay9yN0tSL2RlbTh0NE0xWTFxaXZa?= =?utf-8?Q?dIW4gsTnjj/sOO3bCW6cdknDq?= Content-Type: text/plain; charset="utf-8" Content-ID: <8E532D1FB9929C49ABF0E3D4BB854870@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 924ade66-e44c-4acc-668e-08da65a89ec7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 14:53:31.8813 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R128glzss6L7MnaxcZZEDIm4w/l6ggwu/Tdi4hqOVyJg7I1k4+RlVLNFbw4EoKQ8ygf8Q12hexG12Y+6QWX9HST4qGRvYmsb7keek9b+PWQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6625 T24gMTQvMDcvMjAyMiAxNTozOSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IFNpZ25lZC1vZmYt Ynk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpBY2tlZC1i eTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 14:58:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 14:58:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367697.598797 (Exim 4.92) (envelope-from ) id 1oC0I9-0007jR-0K; Thu, 14 Jul 2022 14:58:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367697.598797; Thu, 14 Jul 2022 14:58:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0I8-0007jK-T9; Thu, 14 Jul 2022 14:58:12 +0000 Received: by outflank-mailman (input) for mailman id 367697; Thu, 14 Jul 2022 14:58:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0I7-0007jC-Mq for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 14:58:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60e72f42-0385-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 16:58:11 +0200 (CEST) Received: from DB8PR06CA0050.eurprd06.prod.outlook.com (2603:10a6:10:120::24) by HE1PR0801MB2121.eurprd08.prod.outlook.com (2603:10a6:3:80::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 14 Jul 2022 14:58:06 +0000 Received: from DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:120:cafe::bf) by DB8PR06CA0050.outlook.office365.com (2603:10a6:10:120::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.11 via Frontend Transport; Thu, 14 Jul 2022 14:58:06 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT016.mail.protection.outlook.com (100.127.142.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Thu, 14 Jul 2022 14:58:05 +0000 Received: ("Tessian outbound afad550a20c6:v122"); Thu, 14 Jul 2022 14:58:05 +0000 Received: from 4c3acbc0006e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 265A82A6-8C84-459A-A3F2-8D329435901A.1; Thu, 14 Jul 2022 14:57:54 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4c3acbc0006e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 14 Jul 2022 14:57:54 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2485.eurprd08.prod.outlook.com (2603:10a6:4:9b::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 14 Jul 2022 14:57:52 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 14:57:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60e72f42-0385-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=nFkWFkHbNb1I44cip1f1hld6Zy2BjSb7+icQSJpy5JWshxZK3AnbofByqi3Px/cc8bD+A5aaIf7vCKMMoHm1AASSPbyhmBFnyO2b6I1Oh56bAg0HEg2rxARz1UtsaQ4vZMK9QSjW7F8WPKOzy9JCn4p4/yQNgTxj8jrDnT8UdoIym/6HEHGx0PPGoxuxMbMEwgIm3TfqrZJDFg0lNvy+H3/Bo8rjEl9fNVYhf+DbICefDENOxCzhfjdqSekB2EoODNNmxkmoNkJLJtVxIunMBiNxb9ulBpn2xD1mRXilfzELtTT77iNBG0YaTTfNhenj0Vq1pUcdD7yie5x1QDp3Zw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkD+V04XSIkTHahi19jI9OlNy5zjuYhTGjZdDHwLeOw=; b=IJS9OGWhD5SrTQ0gVuS9nSEljX7Lkn3g9dsTy5Yste7Z8IuvYPMtSxzfpWdsz6foHvCUpFLZT5HA1F5kM1ArLz5v/geXp+/MvuzRUjKYquRZUzml9UG3HQH7XlXkin2S4RUephbaFgXTw6yrpMcftXTuVezISBQdqcXuEctvK8O4PFp5y8QRwz4yUxPYMXJp/GHOZzdKwypLF7P+gEY2ZY2qe10G20jKfppL80arR0KIO+nsmcsrP8l+w0CtDdSDn3K8PDfQD5zkUGBjN5bX5HLrqAE8Ij87oKpUbL5oHq6EjlI4fIV3aalczpUAbjkLcrK1ygMPqu+vcUSNR44C/A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkD+V04XSIkTHahi19jI9OlNy5zjuYhTGjZdDHwLeOw=; b=Y4T7yIO9vS75Pu8LC6CyVWFRtRemgLYWWPMTRdDR71uTg6nLlsBniPdBC0czAQmVVQDbcis2ELTp66c1YYahlHtCvWSgVKJ/YD/H98ejAQPMHEvlX/JcCci6eduiUVPz7qvug6ztkxRY3BP4C5zhVHVApTR6V0GdoClBGBTF/Vs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 97492a1bc17da79d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gB9Rxjp03qB473cI84uIbYlOgfv0KbcwsgfLHnuTFpP3+yPpcBPtjHQ2BKx1jbXvyhT1akpLjL9scbRAgY1Uho/54NBJOEuYhJX+g5XM/LgF/N8x1xrwerMzmHgV43kz3+yiohgPujj6Ane4FT6fIIODQc/TfCNNW/s48ZfMD49COUx76pI7/0CK8Iywc6MPvH2vL+OaeWFEMxP0XiptxLUItpDV2Q3OhSLUXYzSmWNlNif06ILYKOOJP9urupYGLEPMYMghreJ1uIMwIPco8jdX2llfz3WvXXlXpc0jsStva1g+2SI1teKuThrUKpvlq2kZ0BGu5tSA8hPF7awFAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DkD+V04XSIkTHahi19jI9OlNy5zjuYhTGjZdDHwLeOw=; b=dU2p/oTy4hkLhYe/c2Tox72uZCurKIJRcv+VdYiTvt9aSb8VEDVuTYLQrnMo2OET18voGC7g8oQ/c8ffXptDLeYywz+LRqrXxhEROKa0W11AjQmcNj6NS016U2GjCepi1o6KgVlKzkQi6sTqVBUkVa3dwLGapZ14wseNYSPGNDGvKc3An2D5TfYHryswkfqZr7Vw8mTmnOQCmjF98mNapiu+lGx35X5C8x6AVEa+KkmWYOSL43MPqHDTfRANVrc9qB0LMckPfyHW0B/W6MjdZvAeude08RNwE1fk9f6jfoONSi9foS4qjSARICYta+2u4Is0Hi1u3Ub7ERUPwyUODg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DkD+V04XSIkTHahi19jI9OlNy5zjuYhTGjZdDHwLeOw=; b=Y4T7yIO9vS75Pu8LC6CyVWFRtRemgLYWWPMTRdDR71uTg6nLlsBniPdBC0czAQmVVQDbcis2ELTp66c1YYahlHtCvWSgVKJ/YD/H98ejAQPMHEvlX/JcCci6eduiUVPz7qvug6ztkxRY3BP4C5zhVHVApTR6V0GdoClBGBTF/Vs= From: Bertrand Marquis To: Anthony PERARD CC: xen-devel , Luca Fancellu , Mathieu Tarral , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+SOiEnzZfQqUyU0a50UPEkY6199Q0A Date: Thu, 14 Jul 2022 14:57:51 +0000 Message-ID: <7EFC2F80-43EC-49EB-A162-FAF0DF945A03@arm.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> In-Reply-To: <20220714143907.25938-2-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 541855fe-7a50-433f-8eae-08da65a9420e x-ms-traffictypediagnostic: DB6PR0802MB2485:EE_|DBAEUR03FT016:EE_|HE1PR0801MB2121:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4JuNEpONpMBakrw7vKASdgaumZPjQsrXSGqCeEHmbmWWjoF16287MkPNLpI6FgVetAxcEgcfJ+9A3o9M39LRe/mU6FBJBCpv3S/aoeKJbh8bKCYLuDCbvWAjZEdWskhzzGu3JlKA1NQhByka9JWSEIhd8T1WkJd8x9f4uweGcC3f6lV/SCuWnIuUOcob3IfliDri2SwVCTeg3tYA3TCFmnQdD0AY/7SCwQj/3VdK7Gbh8IG6HJ9SkI//99AgKjBLIVPlJAQpKHlz+0H7y4E8MQPTmy6k8uG9TLT/j1t1XJ/J+50NJM7RMp30ss2SDdr3ercHsUqzyUNmVj2bPKT5pP7ftuve5WysQNO+pS1Nfjf5GaP2ICZO+ZsK8Jbjv06+EpbNQ1liaKpOpcYgsaxhLHr0DVQnx1ocDu02RGIdZplPWYGSz4Mxqf2+TB6/CIwpuBbkmIeeTTR47bryV0A9hKy5SEE75PgRYpfH84nUfZlFI3cbR3D/hVy+AkTtrFPVe6LUaT90C5zrzAknzCzqyiO6It1G2CXakdyiXUNhzuRZtDo4hmHbnvWhIhcx9SvSZD+FvQUHk7UOOhjjixefBr56TTgEi8x3nBpdftAUJ/bWnEDci3TwMEK73I29MBzQcWIgxAnl7MVm+SzzndTRdjwVIwIsbuIovS01o9ObhmqDL9ZA+Xm/IRl+7O3fC6Iuoqh/gxfU+nQrIqD/kU/UmFvjo3OW5XmlgGWU4YMsinSP7G49Cjo9Qr7VMjv16GP/Wt2KHANe/81UrQqqOq39pleXa+1QJYeIn9zM7+pf24KDPFwI6QmuO9ZTdoh7Z3EQCMeK442IDqBdsxpgODDRIDd0Tp+PY7hvkP0rzib53E0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(39860400002)(366004)(376002)(38070700005)(186003)(6916009)(38100700002)(8936002)(66946007)(2616005)(2906002)(36756003)(5660300002)(33656002)(66556008)(64756008)(6486002)(8676002)(41300700001)(66476007)(478600001)(26005)(53546011)(76116006)(6512007)(66446008)(6506007)(71200400001)(54906003)(4326008)(122000001)(91956017)(86362001)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <6E865206FAE20442A9E37BD791D1C949@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2485 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 353f8962-e870-4747-2bd1-08da65a939be X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UDUEJ3XeN+zxzvQq0GZ9CDNAHB3D6j7I0wGn4QQO6+3dL4Bh1WP5Q9APGAOphjKp5/aVRbouqEXBM6kFkzxzEBqmzQfz10dd16HUEhEHh5v8O4RlBB0f52mJlucpHs4OhyvWRsrWEKdmrWf72153ibLD4B/FYUItlzbkUfPaBV3OOMUMTgLT5udDRXAnHdSwNKxS44WaHInV7fkkQ52qD4tQwzkolXlNnd4qd3KshKTATt62014mpug9U8KiRk6GYXx9q5cXxtEAoQexnBrtjZngD7++YISUhXl9/AgapV3tMRUAGfTXA2dacrAwKo+o60WM+4eFJrkAS+f9U/sI21Ixojp3YHBeY11N1t6Yv7vUq6s1w+qPlZoJJmRFQIck8zC1C27xVJCGX1eKEvwz2hWHBf2KHxJkKzreN+RtdTBZVk7LmRmo7MaYSYdwTz9HeoKOsbhcdy7ax0hH91PtjlFSOdynr281Ri+lrlReRhSq9fBQSeoQuqJmRMuDPq2Zp5e0b0WW2yXwLqBxARyWYVh8cP9j+8p+28xijlIjuS49Oud2TluNRseEMiquCWBhC+FkmLfURFaICQid5omx/rIciFQeZ6+dFZTQOwFw3wDvfHGyFtMGrxCLY2Fy8u+vzCfKg3k2HGC9FVZzE+P9tzNMgXEruhdYOTmaNrR4YYdxyRlgNF4JggL6w1PkYkQaPZ0ZpGYRJbRbFX+Es3osjLpz6PHmRrduqkoia+L3tPzY8tyyNOgWd6y3g6tZ34Q6VURQXvCa/kyWRXp48LXlXuPFCaj7F2DZ7MzZGI9fB9VFQwI21ebJK9XM52/TkjE4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(396003)(376002)(136003)(36840700001)(40470700004)(46966006)(36860700001)(186003)(336012)(36756003)(82740400003)(4326008)(47076005)(316002)(2616005)(81166007)(356005)(8676002)(70206006)(26005)(5660300002)(6486002)(54906003)(6512007)(41300700001)(6862004)(70586007)(86362001)(478600001)(82310400005)(33656002)(53546011)(40460700003)(8936002)(40480700001)(2906002)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 14:58:05.8318 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 541855fe-7a50-433f-8eae-08da65a9420e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2121 Hi Anthony, > On 14 Jul 2022, at 15:39, Anthony PERARD wrot= e: >=20 > check-endbr.sh works well with gawk, but fails with mawk. The produced > $ALL file is smaller, it is missing 0x$vma_lo on every line. On mawk, > int(0x2A) just produce 0, instead of the expected value. >=20 > The use of hexadecimal-constant in awk is an optional part of the > posix spec, and mawk doesn't seems to implemented. >=20 > There is a way to convert an hexadecimal to a number be putting it in > a string, and awk as I understand is supposed to use strtod() to > convert the string to a number when needed. The expression > 'int("0x15") + 21' would produce the expected value in `mawk` but now > `gawk` won't convert the string to a number unless we use the option > "--non-decimal-data". >=20 > So let's convert the hexadecimal number before using it in the awk > script. The shell as no issue with dealing with hexadecimal-constant > so we'll simply use the expression "$(( 0x15 ))" to convert the value > before using it in awk. >=20 > Fixes: 4d037425dc ("x86: Build check for embedded endbr64 instructions") > Reported-by: Luca Fancellu > Reported-by: Mathieu Tarral > Signed-off-by: Anthony PERARD Very nice solution Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Thu Jul 14 15:13:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 15:13:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367704.598808 (Exim 4.92) (envelope-from ) id 1oC0WW-0001x6-CY; Thu, 14 Jul 2022 15:13:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367704.598808; Thu, 14 Jul 2022 15:13:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0WW-0001wz-8n; Thu, 14 Jul 2022 15:13:04 +0000 Received: by outflank-mailman (input) for mailman id 367704; Thu, 14 Jul 2022 15:13:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC0WV-0001wt-0H for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 15:13:03 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71e97a22-0387-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 17:13:00 +0200 (CEST) Received: from mail-dm6nam11lp2176.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 11:12:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6345.namprd03.prod.outlook.com (2603:10b6:303:11c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Thu, 14 Jul 2022 15:12:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 15:12:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71e97a22-0387-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657811580; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ejx7DBOsXgOaWVhhUyyVAc+3MJQWQ8erEiFWaoGlSKA=; b=ICjwn0SvQ+wS+XLOezPdcpuX7KRm7inQPcC+ly1evxJo9iKFW6wgiU22 PJ7a/SJDdb1CLt+//D5tHr1Ttu171ynQZtIQHPwHbgZ47h3Uak+VhAFme nEduV9slylDV2qeLEDrj6o6HwoRqqWYxr9Oc+AthkWA0xY15hXJ66Slng Q=; X-IronPort-RemoteIP: 104.47.57.176 X-IronPort-MID: 75805300 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:KVFyq6vjBq3/6bnpKhlSOj9ZQ+fnVBdeMUV32f8akzHdYApBsoF/q tZmKTyPMqzcZjSjL98lO42yp0JUv5bSz95gG1Br/ChnQ35D+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzh8B56r8ks15qyt4W9A5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYoY9+FuAVBUz O4FDQ5QTgmOtcCJxr3uH4GAhux7RCXqFKU2nyg5iB38U7MhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q3T/PVpi4TQ5FUZPLzFGdzZYNGVA+5SmV6Vv Dnu9GXlGBAKcteYzFJp91rz27+XwHijAOr+EpWX//5gn0OV1FUpDU01WkeJudSyg2uHDoc3x 0s8v3BGQbIJ3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQAsaiNKYZoIvck9SDguy 3eAhdavDjtq2JWQQG6d97qJ6y+7IzIcKUcafygYSg0A6tjn5oo0i3rnTNxuDaq0hd3dAizrz naBqy1Wr7cOic8G0Y2r8FaBhCijzrDSVRI87AjTWmOj7yt6aZSjaoju7kLUhd5fKK6JQ1/Hu 2IL8+C04foSF5iLmGqoSf8UAbCyz/+fNXvXhlsHN7ks8S68vUGqe4946St7YkxuN64sfDbza wnOvwxc/5RTPXi2dodpap68EIIk18Dd+c/NU/nVap9CZ8Z3fQrepSV2PxfPgSbqjVQmlrw5N dGDa8GwAH0GCKNhij2rW+Ma1rxtzSc7rY/Oea3GI92c+eL2TBaopX0taQTmgjwRhE9cnDjoz g== IronPort-HdrOrdr: A9a23:fiktPq0DPIJdnc3CjeE6AQqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.92,271,1650945600"; d="scan'208";a="75805300" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AX+Qp8bxuHBvrAEOBrFYfNDTG3bfkCW5PAym2T08d7xp5gFuk0/Sd6cXdYJxMeiHYfXpOnusVyDSUKo0WaBcdNI07XqeSs7noRrV927vBur5OmadAqtQlwsm3k9qxmbueHKCO6LCtS9Gb/kgh26KTDHQTGZhZ+YpSg+iVqabJGqzqdMLRy2CB4Kwkui5FgUv+qIox2reofIzkDSXVGpXmrlaGuM0Wue4hAPlzpykFiNmZRt4ahsXjaxjXWPF2Lli8gmn9ajJQtyHCCsklvJqFKxLM1wJFd8ZnxiTKlCPMujwhVIssMzMO5iLMndjG7W57i3xdUTKf0j3gseEME5HSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ejx7DBOsXgOaWVhhUyyVAc+3MJQWQ8erEiFWaoGlSKA=; b=BdWg+8OKJvKlq748QbI0db6xOwK1qVMDl0pcdULa1Qz84JDYVQt9SebL+9w4gAbxWHWBAjoXfyAxSjnSHcCHYn0xVYfnfXb4UPo3b6y8b3a7FLw0k25nw7Awue6OG4/KZRPpgtYP7wCj5E76jEZq6BvUdBkHxCVfJJ3ltkUmP5L38SiUoAs+pArbj1J7W/hyKtyOf0GB7os6bkGASeFcYKYJMKbpW0I3UjlQ6DR5j28D5T4eSQaCBpPTFuDh6CqNbo46b4Z0oUTdCD6T6YODFP2tI/FzmNvGbw+LUMHnxZkSh36E8joa59xryodbo3Fp7tA5i2qXkXQEQw4BNfSw5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejx7DBOsXgOaWVhhUyyVAc+3MJQWQ8erEiFWaoGlSKA=; b=XsJJlaC6G1aZZPJ+TuTbD4xByYhc+tHyBFnvOQUh+tgpomllakuj1Csodru5wErp2izD0op2tFGUh7HCxsGVvQg0CEkpm8akFUw4MWI+TxQql1zdznB2h2j2XChCMpxMDpWrmX/LTomBpQeis2V+8OjyA58KRjXs0JjReEGSNj4= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , "marc.ungeschikts@vates.fr" Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw619+TQA Date: Thu, 14 Jul 2022 15:12:42 +0000 Message-ID: References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> In-Reply-To: <20220714143907.25938-2-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e5fd53e8-279e-4008-2f0c-08da65ab4c7b x-ms-traffictypediagnostic: MW4PR03MB6345:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GL1F9n1oboE6eEJo02+blVNhQ/doApM+IObKhBN9XmebHszymft5VR6lICruArgz9JBLIkgRhr6fJVb8Y9FdE+giadJuGKWa1dZiIc1+ydC/0AvOsF7i24y1rLGMDiIQLZLPtQ9QdRDdJjuyy1jQRns3C2Yez7M2D24DdGymEgr3pYoF5CnjpkWJuIpqGHoszdN20slwt8nR5gVH+UZGUK3g242SMRpSHdDn2PqK1JO4zFnZbjA4h5eoGmxw0g9hnbieR1tni+xma0D+Lg3TF1mob30/gSrLKzR0y2tkEG+IctH4CDh+3/J/UgBbYteSyovAVXzFOFI/Fx68cHeNI20Z9ZcyX2InxscYNGu8UIdNRcJEfK7iJQHcXM8wpIOp79BK6h2p3kOOxW3wMEitBjErqjIgYMgCx0WmIMD4WrA3H29uT+P6Pvk88+PbUnAgo+N11+VAovPIVhBjMw0XhNELfPj0E2BGSqnvTl8gyGuuDERYRC+Sl2KURaGALRf/PClJ7B7PO1lKPnH0d+kuefQY9jPShOAN8Bb7xbFq+hFQnm204Zd2DmB+hxN1ai3z4gNSTOt/OJ9hO52KxVtpnKW8nH3If0IBVUwhpoemHem6pNT3v6ZPMI7BoXEnwQnuraYnM40Xv+Fyy9Hdhzg+eFDZK25inVMPk7KzgNS8IgJgrQ5wQzQHxHpwc570pchAnELN6bozadVeaSvin+CUEAas6kOFThxbaZtyw7GQbbVRIgNbj2MjP/biuaxM6sEUXFpyzzm+Gv4mxT6rWp4FfSz5w2Rs0DpAFw3cLBVGwitNUXtCLgNtI9A3Hg9hODvwvrv8Wq6Pbigku3eH+wKis5iXnG/eOnJAtiJ3m2JyCiaXr7H0ABeuLU0hTH0VgbrwIaxJVy7grlaptMYuFqtwE1h07dwVkIvVyncVdQ7hLKY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(366004)(39860400002)(396003)(478600001)(64756008)(41300700001)(2906002)(4326008)(66556008)(966005)(110136005)(38100700002)(71200400001)(8676002)(66946007)(54906003)(31696002)(6512007)(316002)(6506007)(36756003)(76116006)(91956017)(26005)(6486002)(66476007)(66446008)(38070700005)(53546011)(2616005)(7416002)(31686004)(82960400001)(5660300002)(122000001)(186003)(86362001)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YmNGdlZZUzY3Y3Z3VklxVEJqOGFONzRITFhucGwydHBJL1I5d1Z0MWNjZkMy?= =?utf-8?B?NmpXcWpLcXVySDJlQTkvTGpuV25kVldFYmMyTkc4SEhiUWFZTUplVTA2YUll?= =?utf-8?B?dnNjbDNIWExzdXBvVm5mNXlWS01QZVRpZWtBa2RhbUVlSmxEcHJMMHhGRUlP?= =?utf-8?B?aHd4d0NjUTNwaWhuUWRFNGtuUDc3dlFKNGZZWm0vWHFKOTBDTDFIOHVyOTRP?= =?utf-8?B?YjdwczZuOENjN2JtQXpScDMrdmhldVhoOC9HRVVvTEtvbGhHQ1FuV3BqOVgr?= =?utf-8?B?Uk9ZUXF0dmJXZnIwSlJ1K0VidGZ0OFZXTTdDYUdPTm02K2F3V0Z2eEhod1FI?= =?utf-8?B?SGJwNVp4UXAxcUMxZFFob3pOWTM3c2t2VHFXTlQ0YkpwUzV5UDdQMldqQWFG?= =?utf-8?B?MjM0cXEybmUxd1V0dFFkblN4NGNHaTJTRVZnaWU5Z0t1SFZ5cHkyMmxTR1RR?= =?utf-8?B?QUlHbU5mckpHZzJXUjBBTXNhQ29hWFlvWnphVURPeTUwNWlmZkFGUEhjRnZi?= =?utf-8?B?dk4wRU14V1IxYk1kQ3lWK2xnWmtNWXRhbHlsOWxDeWJmTStOaW9CR05MUWFo?= =?utf-8?B?Njk0dlZkaHZEY3BHWkgxVSsyc0g5eCtFcjdPWU1KNjNISmZjQ3p6U1U0MDR2?= =?utf-8?B?ZjNMckZlZmwySy9MYzB0YVVJY2xlTHdzZ2oxUGdsV2hWRzRZSGFCN041OWRJ?= =?utf-8?B?Tm84MVBXSm9GZ0M2Z1cxek5sWXc4ZkNEVzViOEVvbnNlbEMrMGhoRk9Tb3Fh?= =?utf-8?B?L3J6S2hKMFhQMC9UNmVic1Y3TmNmbEQreGlERW9qcFdzK3kwSG5FVmJYbUhG?= =?utf-8?B?VFBZLzFMd1hSOWFjSityWWZGdlQ0cFVRYk10RU1kNFZIdjRISFJ4czh6d3Fq?= =?utf-8?B?Q1hjbGVhZVBQOXRDYkFJOU56OExtSzNJS2lpam9TR3FlWEVjUGFlSlJxZllt?= =?utf-8?B?Ym8vb1UvejduNDd2Q0FFc0RXU2l3NlNnRW4yUUJhZDcxdFUxQUNsUHZrMDIr?= =?utf-8?B?aEdTbXcyYjlkaW12OFZtNFA0cTNNb0VDa1dnT3Voa2VvZi82ZFF1dG5sNktv?= =?utf-8?B?citMQzl4NXhDbkhWc2FBSEswYlJ4VjJ2UmkzOGF3WURPa2V4TnMwYlJrWEFV?= =?utf-8?B?K0RpaVJpOFFkTUxtVjdmQ2ZGa3BXajJtc1hMUXlHNjd0ZTh2OFUxQ2F0ZWhX?= =?utf-8?B?UVdYMWtOOGhpTENxdm51Yldva05JWmYwWDlnKy9EK3FPQW80M3BSRm9oNS9o?= =?utf-8?B?bnh2aCtpL0JaTTVvSkZaZVNESkpOLzBsTGprdjV5bWNtSS9ySlZuenRKOU9M?= =?utf-8?B?YzI2WE41bnp3SkxtSCtzOU9jQXhwNnJlcEpTeUhXaUZGVEZqN2dSWnpzaUcw?= =?utf-8?B?dGlsVnNGUklSdlFvd2RmeEVVRFFURVMxZWhSV3ZiaGVKVjlDNGt2WFUvUlFH?= =?utf-8?B?N05odlppcGlCeG96TVc0bkNUdVBabXh4Zis2NXgrWFBPOGt0UUxiUXdTWUNO?= =?utf-8?B?TXZETU12TXRXM2Mwc1U3a3loZDV0ckNEUmZsTlQwN09mbHRuMXlTcFE2VUxr?= =?utf-8?B?dmhJbmlvSFliRUJwL09xSWpydmQ4ZUxuMEJNZVZlWXFVd2p5MEZ3R3grZ0xr?= =?utf-8?B?b2JrSThLS1kyMWR3TGVyazRKZVRLZWdtT3hiQURhZkNuV2FTK3JuTEpqdDFN?= =?utf-8?B?bS9PY2RFZ2xKM3VPVlFNbE5pc1B2UTM5ZmQreXRvRENCNFVldGs4eFFHb09s?= =?utf-8?B?SFVnRlVkamNJVWdlRHpqYldWQnptTTVUWFNSaEhhQlpxb0pWWEhKNWZ0cFRY?= =?utf-8?B?cWc2cFlIR2xDazlTdFlsbHFLaG1lMml3Uy91NGJ4c3h2cVorYVJqemttczBH?= =?utf-8?B?R1NzMkRkc2lLamovdGRLUEltejRhOE41dWlIa2M2dEFiWEF4MjFaM1NiSy96?= =?utf-8?B?Y3RlSGRsQ3RGMGRJaFI0RDNOQkU5VGJvU1FhLzB6Tk1IRHlTT0g0eXJTOHhL?= =?utf-8?B?VU5SSk02cmlKQ2REVzQyVjhENFNubE42dk1hY01tMUx3NWd4U1lYYXFWOVlC?= =?utf-8?B?bktoQ2dCVmptbjJWK0lmY1NXWTJjc0NmRHphTVY0ejZBby9JKy95U0E1dkhU?= =?utf-8?Q?bSG+Q4j4iOFVQ/dFS1GmAKbt/?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e5fd53e8-279e-4008-2f0c-08da65ab4c7b X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 15:12:42.3144 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5Dwlqr5s+rfhSf83NYN1EEvkvd5JLAQc92ThImy0cjRcXj0jznJrEVs0PBaoboWm5lL1c5OLVRnem+LQGVpeWLh6eKsQ2HIQabwMBx9H8oA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6345 T24gMTQvMDcvMjAyMiAxNTozOSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IGNoZWNrLWVuZGJy LnNoIHdvcmtzIHdlbGwgd2l0aCBnYXdrLCBidXQgZmFpbHMgd2l0aCBtYXdrLiBUaGUgcHJvZHVj ZWQNCj4gJEFMTCBmaWxlIGlzIHNtYWxsZXIsIGl0IGlzIG1pc3NpbmcgMHgkdm1hX2xvIG9uIGV2 ZXJ5IGxpbmUuIE9uIG1hd2ssDQo+IGludCgweDJBKSBqdXN0IHByb2R1Y2UgMCwgaW5zdGVhZCBv ZiB0aGUgZXhwZWN0ZWQgdmFsdWUuDQo+DQo+IFRoZSB1c2Ugb2YgaGV4YWRlY2ltYWwtY29uc3Rh bnQgaW4gYXdrIGlzIGFuIG9wdGlvbmFsIHBhcnQgb2YgdGhlDQo+IHBvc2l4IHNwZWMsIGFuZCBt YXdrIGRvZXNuJ3Qgc2VlbXMgdG8gaW1wbGVtZW50ZWQuDQo+DQo+IFRoZXJlIGlzIGEgd2F5IHRv IGNvbnZlcnQgYW4gaGV4YWRlY2ltYWwgdG8gYSBudW1iZXIgYmUgcHV0dGluZyBpdCBpbg0KPiBh IHN0cmluZywgYW5kIGF3ayBhcyBJIHVuZGVyc3RhbmQgaXMgc3VwcG9zZWQgdG8gdXNlIHN0cnRv ZCgpIHRvDQo+IGNvbnZlcnQgdGhlIHN0cmluZyB0byBhIG51bWJlciB3aGVuIG5lZWRlZC4gVGhl IGV4cHJlc3Npb24NCj4gJ2ludCgiMHgxNSIpICsgMjEnIHdvdWxkIHByb2R1Y2UgdGhlIGV4cGVj dGVkIHZhbHVlIGluIGBtYXdrYCBidXQgbm93DQo+IGBnYXdrYCB3b24ndCBjb252ZXJ0IHRoZSBz dHJpbmcgdG8gYSBudW1iZXIgdW5sZXNzIHdlIHVzZSB0aGUgb3B0aW9uDQo+ICItLW5vbi1kZWNp bWFsLWRhdGEiLg0KPg0KPiBTbyBsZXQncyBjb252ZXJ0IHRoZSBoZXhhZGVjaW1hbCBudW1iZXIg YmVmb3JlIHVzaW5nIGl0IGluIHRoZSBhd2sNCj4gc2NyaXB0LiBUaGUgc2hlbGwgYXMgbm8gaXNz dWUgd2l0aCBkZWFsaW5nIHdpdGggaGV4YWRlY2ltYWwtY29uc3RhbnQNCj4gc28gd2UnbGwgc2lt cGx5IHVzZSB0aGUgZXhwcmVzc2lvbiAiJCgoIDB4MTUgKSkiIHRvIGNvbnZlcnQgdGhlIHZhbHVl DQo+IGJlZm9yZSB1c2luZyBpdCBpbiBhd2suDQo+DQo+IEZpeGVzOiA0ZDAzNzQyNWRjICgieDg2 OiBCdWlsZCBjaGVjayBmb3IgZW1iZWRkZWQgZW5kYnI2NCBpbnN0cnVjdGlvbnMiKQ0KPiBSZXBv cnRlZC1ieTogTHVjYSBGYW5jZWxsdSA8THVjYS5GYW5jZWxsdUBhcm0uY29tPg0KPiBSZXBvcnRl ZC1ieTogTWF0aGlldSBUYXJyYWwgPG1hdGhpZXUudGFycmFsQHByb3Rvbm1haWwuY29tPg0KPiBT aWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4N Cg0KVGhhbmtzIGZvciBkb2luZyB0aGlzLsKgIFlvdSBiZWF0IG1lIHRvIGl0Lg0KDQpPbiBwb2xp Y3kgZmlyc3QsIHdlIGhhdmUgaHR0cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L3hlbi8tL2lz c3Vlcy8yNg0Kb3BlbiBmb3IgdHJhY2tpbmcgdGhpcyBidWcuDQoNCldlIHNob3VsZCBjb25zaWRl ciBoYXZpbmcNCg0KUmVzb2x2ZXMgeGVuLXByb2plY3QveGVuIzI2DQoNCmluIG91ciBsaXN0IG9m IHRhZ3MsIHNvIEdpdGxhYiBjYW4gcHJvcGVybHkgY3Jvc3MtcmVmZXJlbmNlIHRoaXMgZml4LsKg DQooSSB3b25kZXIgaWYgUmVzb2x2ZXM6IHdvcmtzLi4uKQ0KDQpodHRwczovL2RvY3MuZ2l0bGFi LmNvbS9lZS91c2VyL3Byb2plY3QvaXNzdWVzL21hbmFnaW5nX2lzc3Vlcy5odG1sI2Nsb3Npbmct aXNzdWVzLWF1dG9tYXRpY2FsbHkNCmlzIHRoZSBmdWxsIGxpc3Qgb2YgcGF0dGVybnMgYXZhaWxh YmxlLCBidXQgSSB0aGluayB3ZSB3YW50IHRvIGtlZXANCkZpeGVzOiBmb3IgaXQncyBjdXJyZW50 IG1lYW5pbmcuDQoNCg0KSSBhbHNvIHdhbnQgdG8gd2FpdCBmb3IgdGhlIHBhdGNoZXcgQ0kgcnVu IHRvIGNvbXBsZXRlIGJlY2F1c2Ugd2UndmUgZ290DQpzZXZlcmFsIGJ1aWxkIGVudmlyb25tZW50 cyB3aGljaCBoYXZlIGJlZW4gYSBmZXJ0aWxlIHNvdXJjZSBvZiBzaGVsbA0KcmVsYXRlZCBidWdz Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 14 16:10:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 16:10:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367712.598822 (Exim 4.92) (envelope-from ) id 1oC1Pf-00016e-LA; Thu, 14 Jul 2022 16:10:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367712.598822; Thu, 14 Jul 2022 16:10:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC1Pf-000169-GS; Thu, 14 Jul 2022 16:10:03 +0000 Received: by outflank-mailman (input) for mailman id 367712; Thu, 14 Jul 2022 16:10:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC1Pd-0000mw-Sr; Thu, 14 Jul 2022 16:10:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC1Pd-0007xw-F0; Thu, 14 Jul 2022 16:10:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC1Pc-0002Wq-WC; Thu, 14 Jul 2022 16:10:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC1Pc-0001Kj-VQ; Thu, 14 Jul 2022 16:10:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=fNff6lhO2FGqlSXcc760f1WTZRBDMvejJo+wcxKUCWk=; b=HFPhsDtpA9kTLPUSFIaZZDFF4b vjjQx7KK9/D2UNN8lGvngQc6APJ2U+HGu7TTVdbnC05CoEHpBCTBPfI/46+Ax2kLSBsERGIXOMwN8 pbF1hK3wcBPzwkcU7vZuC8s6ID5O7mdmyYLEsRECkmwSPqdhW5Q6qPTDCfM15Vm3Xpiw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171623: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=824824d12217f7d80b372eb051aad2c082cffb98 X-Osstest-Versions-That: qemuu=8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82 From: osstest service owner Date: Thu, 14 Jul 2022 16:10:00 +0000 flight 171623 qemu-mainline real [real] flight 171630 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171623/ http://logs.test-lab.xenproject.org/osstest/logs/171630/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171630-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171613 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171613 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171613 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171613 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171613 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171613 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171613 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171613 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 824824d12217f7d80b372eb051aad2c082cffb98 baseline version: qemuu 8e3d85d36b77f11ad7bded3a2d48c1f0cc334f82 Last test of basis 171613 2022-07-13 04:32:50 Z 1 days Testing same since 171623 2022-07-14 02:53:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alberto Faria Daniel P. Berrangé Hanna Reitz John Snow Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 8e3d85d36b..824824d122 824824d12217f7d80b372eb051aad2c082cffb98 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 14 17:18:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 17:18:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367734.598833 (Exim 4.92) (envelope-from ) id 1oC2TZ-0001AV-35; Thu, 14 Jul 2022 17:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367734.598833; Thu, 14 Jul 2022 17:18:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2TY-0001AO-W3; Thu, 14 Jul 2022 17:18:08 +0000 Received: by outflank-mailman (input) for mailman id 367734; Thu, 14 Jul 2022 17:18:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2TX-0001AI-Pd for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 17:18:08 +0000 Received: from sonic310-21.consmr.mail.gq1.yahoo.com (sonic310-21.consmr.mail.gq1.yahoo.com [98.137.69.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id eb1176c7-0398-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 19:18:04 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Thu, 14 Jul 2022 17:18:02 +0000 Received: by hermes--production-ne1-7864dcfd54-dxcrc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 78c9938f79c6bfaa1dd44261bd92c198; Thu, 14 Jul 2022 17:17:56 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb1176c7-0398-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657819082; bh=K6joDuzaz6ReyBN1azQqrz7eoLesddIL/DW3l7lThp0=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=M9awDOAzPh3Fw17O4JgpEjPn9mjHJ7usy0wGo+t1B7h5gSKRHlXk09+YYJNOmCQev4heN9bp1zRakNptwTWQ2UkwWQnTul777CPYQdrqZSh6uRifbNoUO02fg2kg5UknGqw0wcaYPxUns6Bd+glWpl0iYwiRb8kWaRSKT767APrn04VY9HtROnGES40Uqc/Iz3wN1XB+G24k9ZWGilZ0QEY6gDntHRXL3ON6ikCUpJPh2sz4QJYyUFEAyMBpeMRjth9WM9SSkDaZq9bSvW6xSQOzrZ2kAEvU/wYQGKp79kb4hMsv9dw1pjM9pxH1VSLNQI7lO4HQ3gSDO5tvX2Z8Qg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657819082; bh=xIGE8RBQDUpUkF4cyoBG8GZz5Q2LafG9TdX2VJtrVS4=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=knCxCA00GJeVPCjt3+nTqNd4TO7ZzSXoX849CBPd6pAYvOEFPHeSibRa1eouvP9tn5Gu6fZwoOS20jkWiuYBBNX5wsAbKsNb30cXlxYK2mq8zYmGLw04M5k2L5N3WpmONTVbl2XgX0oqYk8auMwwIjD1MYWM37CPy1z5lKQdiTNCOn5Hu2TSelh2klvuCp+hK/8pOqh1HcJKg8njPK0DfwtwAT+TF2SXRk0+e1T8jom5Ut2r9S5X9HKQfv3Gdf+24NVxNzZ2DASEzITsFpAHaYOY9Gp8gF/wxvsn13M44igaQ4Za6e6MYwaDGSjBdcZnQFlqruZV77fimkCDcBcY9Q== X-YMail-OSG: _G3Z_fUVM1mmgdigp1QpLXL0sKHIi8.3W1ckI4YZkbMlI7ljSvNIqCVUpe7tT8v GIu_y4vEnuYkUh_CcSsHGTJidjxFYuXfB66rZspz56_qx84XD0bhk9l_br2Jjfbyn8QsaU2grcBq 9f8JV6apWuACoFy4V9Nrq8bdV6jJZX9uFeoWm0C0tTg0sAkhMefP4qCMqAsca2ZALq2X4zoRyzqL E1ld_DFdxjERy9edhOpN8CJAAopAZO4QQZhFqyq44C4u4jFH.YxWAMUXByLE2iky3_q4vCrqBebh I3U2v4EuOSpt7U6.QG88zH8L5hXrjKBmoIp3jBOfCHQ758dUybjOL7uCJ3yubSeTb4q_ovqEleWk I124SYO.SdneY3XgIjYxEQ2kCi3Kxx5yN5KS7L3wYlUkeCxYEI_M3Apo1PSsth_EzCwnO2qoiY1G LYZQN4sqzVuwbKmcLDad0oGWR.DOLAacx5J2anrtS42WdpqJL.tmMQ7ja_1QniXkWoGaovhp4YiM 8Oksu9rrvYM5zJoVq6pmObXQdF5pcRZLzr_vhjVcKZGHBwW1BUoJxjo0pQG3Mw7XZOCR1hEEjN8K RyMwIpnfTIs9bp_oZW9SWFW5iVQO.ThbbJoaKL34wC6ppUDnRaysfHq7sT3YSE4YbL0iUl_rSZO0 x4_JCD9B_1OTKBlRo45RKNzrOjgEFXw8p716FtthW4n4cK3MLrji2o_rlncsiDs9Uj9wiDctVMlf 4bWgD7u2zGmJdF0BHKSHVpFgNQdF6viE_OE7QU2_eCpGykC811NkmlVpI9RYD6G9sQe77fG6Bqp3 zrxM38o6rvKuhxyQcCTwKYCyvFFNcxDVdUO2tarFhhjKLp2AFmaT.otRFpMNZ9zZxNlB2DE_s4IC mF0I66peWeKkG5Qqg4A8KdA7NGI_oJI4V3K4j04oxIY9YC6YNxyjdfBDj7RYfXUNvnIylI8h7DUG DBAJ3BdLBSzeEx3g4r13Dl6msk7aGSv51NHXqoYR2sFLPYiV92tVAVLpGSZEPxjN4zudbfjHNFok it2V.HXHZnw5ztr5n_tBW5LVOk9GftbeSLGMEw502Jr51Hk62cLTcWdr0hks.IWOZJaqB1ffoN1r pPIRTgKWFWLyvPNyQpKy9LEjOcCLmYESX_armBrxLZGXRtQFm704WAY8n5BSes8lrvrIJ52lY.HR gEaomrCMaiMvVUNxgaFM92srpoB93tfTSf5Whn6zTcGAribQp1zO0BrP6tWD3OGFlIEMui7JQQFs GDCta4unrrOegQh1DyttghwxZdA0IHpw40qm5NkDZxdIMc_gy1FcRQBCSZTHLDUpVcCarpr3LfnS an64El6lVaiRQab08E6EzarOAjaUicBj5aed8TzMzY.LMJkriBa7K7tx8Y8JpdFiXIbYbu6JXa_o mbf6S2hofpCMT5_FjD_S2wkGV8W8t3yWl7ze49Nq4R4LK7sHUeWNjR0j0gAPkoOZ2Siv4SP859OT 253vAIbvHVZ5c3HUx9wWABJvjQ76KILFbYW63yn6FtjOiuOPP_M05NCGcR21943DRX6UbJ4bWNMB wW67eJ38MrpthNtdkcm400ftIXOGHePta4KOrij6NCTlANmh4DmgyUorIpRgjXQByINO3uYLgoek v8kzlRrQ_l6fOngV8JIJg413TrC1eSP74d2X.lXwx23LECZgllruKvskMcaBQclkaIO6LLjTxlPg DtCqVW_hGlWX0LiWrHvotDFSCzJgaVvSqs_VseD9aEA27vAohe1KRDmUB_q7e3FRBvWugJRXwVam _Q6otUZOtc0Yc_SWK8mAToqxCrYcbpISPjlmOSM1beFaX8ImRKAic3TuW05GTGde9pGH4uXPyuWN Zuq4.lSEyEjc9_w8hJte9Fq8.hWfm9XZE3r3wS0.w9TaSa3K5xzDir_42qBa7F7qpO9bT05rxPO. 3t0KFBuypyampyroB3D2Qfmpb45vvvyLdzFpTB_oX.dxo2uMPt6ubF9gmYswWjaBTqimRPlkJT3Z AgWr0aunWDyVCiOdzHuZU3nWshCkdeIldhEjtXny49tIyyXtrsb35_FPzgGM.FM3fMOI.wBz7kKn saB8OkA_CcD7dqlKuykEZJi1FOirLbYg.1KoWjlMTLiCHVgjFIONSZEqGPYNcV4mpBbdbtFRB5iC rOHMq0xlLgY7Of1SF3Nf.XbdpNbnnPUuY7HOIWZRwD01w9Oc2lB2ZRA6zYDerd1_dIdb5jUCzdce PvXPWEcaPXdPtOkcYx9Uhr5VSvT.ow.bVphpSVoxTLmd2QYyy2.uC8iFSeHMY5h0VrouMQwTl_Wn jjYcN55VtVsr1wqqHOK_Ns5zOElFJOEpB X-Sonic-MF: Message-ID: Date: Thu, 14 Jul 2022 13:17:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen To: Thorsten Leemhuis , Jan Beulich Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> Content-Language: en-US In-Reply-To: <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20432 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5321 On 7/5/22 6:57 AM, Thorsten Leemhuis wrote: > [CCing tglx, mingo, Boris and Juergen] > > On 04.07.22 14:26, Jan Beulich wrote: > > On 04.07.2022 13:58, Thorsten Leemhuis wrote: > >> On 25.05.22 10:55, Jan Beulich wrote: > >>> On 28.04.2022 16:50, Jan Beulich wrote: > >>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > >>>> with pat_enabled()") pat_enabled() returning false (because of PAT > >>>> initialization being suppressed in the absence of MTRRs being announced > >>>> to be available) has become a problem: The i915 driver now fails to > >>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I > >>>> located the induced failure), and its error handling is flaky enough to > >>>> (at least sometimes) result in a hung system. > >>>> > >>>> Yet even beyond that problem the keying of the use of WC mappings to > >>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > >>>> graphics frame buffer accesses would have been quite a bit less > >>>> performant than possible. > >>>> > >>>> Arrange for the function to return true in such environments, without > >>>> undermining the rest of PAT MSR management logic considering PAT to be > >>>> disabled: Specifically, no writes to the PAT MSR should occur. > >>>> > >>>> For the new boolean to live in .init.data, init_cache_modes() also needs > >>>> moving to .init.text (where it could/should have lived already before). > >>>> > >>>> Signed-off-by: Jan Beulich > >>> > >>> The Linux kernel regression tracker is pestering me because things are > >>> taking so long (effectively quoting him), and alternative proposals > >>> made so far look to have more severe downsides. > >> > >> Has any progress been made with this patch? It afaics is meant to fix > >> this regression, which ideally should have been fixed weeks ago (btw: > >> adding a "Link:" tag pointing to it would be good): > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > >> > >> According to Juergen it's still needed: > >> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > >> > >> Or was a different solution found to fix that regression? > > > > No progress and no alternatives I'm aware of. > > Getting closer to the point where I need to bring this to Linus > attention. I hope this mail can help avoiding this. > > Jan, I didn't follow this closely, but do you have any idea why Dave, > Luto, and Peter are ignoring this? Is reverting bdd8b6c98239 a option to > get the regression fixed? Would a repost maybe help getting this rolling > again? Hi, Thorsten, Here is a link to the hardware probe of my system which exhibits a system hang before fully booting with bdd8b6c98239. Without bdd8b6c98239, the problem is gone: https://linux-hardware.org/?probe=32e615b538 Keep in mind this problem is not seen with bdd8b6c98239 on the bare metal, but only when running as a traditional Dom0 PV type guest on Xen. I don't know see the problem on Xen HVM DomU, and I have not tested it on Xen PVH DomU, Xen PV DomU, or the experimental Xen PVH Dom0. You can probably verify yourself that reverting bdd8b6c98239 fixes the regression if you try to reproduce the regression with any Linux version that has bdd8b6c98239 or its equivalent on the stable branches with a hardware profile similar to the link to the profile of my machine which exhibits the problem. Mine is a Haswell core-i5 4590S CPU and ASRock B85M-Pro4 motherboard. Also, other notes: 1. Yes, AFAICT, Marek at Qubes OS is the first to report the problem. 2. Juergen Gross' work to try to fix this has been helpful, but none of his posted patches has fixed the regression on my system. 3. Jan's patch fixes it also, and so do the two patches I posted to lkml earlier this week to the appropriate maintainers. 4. On the pkg-xen-devel mailing list, which is public, this issue was briefly discussed where I first reported it. Someone there said they did not see the issue with Broadwell Xeons. Mine is a Haswell core i5, which is one generation older than Broadwell, so you are most likely to be able to reproduce the problem with a Haswell core i5 desktop system like my ASRock system, which was my own private build which has been working fine for eight years until Linux 5.17.y. Hope this helps. Chuck > BTW, for anyone new to this, Jan's patch afaics is supposed to fix the > regression reported here: > https://lore.kernel.org/all/YnHK1Z3o99eMXsVK@mail-itl/ > > Side note: Juergen Gross recently posted related patches in this code > area to fix some other problems (regressions?), but his efforts look > stalled, too: > https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ > > And he recently stated this Jan's patch is still needed, even if his > changes make it in. > https://lore.kernel.org/all/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > This from my point all looks a bit... unsatisfying. :-/ > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > reports and sometimes miss something important when writing mails like > this. If that's the case here, don't hesitate to tell me in a public > reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Thu Jul 14 17:20:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 17:20:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367739.598844 (Exim 4.92) (envelope-from ) id 1oC2Vf-0002VI-GU; Thu, 14 Jul 2022 17:20:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367739.598844; Thu, 14 Jul 2022 17:20:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2Vf-0002VB-CO; Thu, 14 Jul 2022 17:20:19 +0000 Received: by outflank-mailman (input) for mailman id 367739; Thu, 14 Jul 2022 17:20:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2Ve-0002V3-6n for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 17:20:18 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 39db0177-0399-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 19:20:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AFBB6620DB; Thu, 14 Jul 2022 17:20:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 0EEC6C341C6; Thu, 14 Jul 2022 17:20:14 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id E7A4FE45227; Thu, 14 Jul 2022 17:20:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39db0177-0399-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657819214; bh=mwbikd27srKBB4H1oi//HqBqo/5GVj37mlD7K7FUkgA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=i0M9UqPnWQFLgyHm4Z5KBRGohNmeutOSy85I3+8THypH/7W6Ot5JYIN7PyfYrjyFs XOXBtezsTNRndqDnZvi9a2rdWjDQsLxRdCUsLTIA585m6UkMGx5PpCC8/cKLt76Jzk XgWuVdip4t/iHftcShz8kuFoAtQm38WNf8Q4E0nxvgY/kt1Nt9z9h1HAmcbrxSyFtT 00OEZmGv850vZ088Q4bY1ZiDuE16FcGP5Rjpop1oJFCeDFrug9yW44beUTDG7sl5Sm yk+HzJUoEPPjqjASsd//N+ov/q/JruLwH+6kBpydPh2/Jmf07UrvEwGIWNtwaSUCag UxQojyc3DaRhw== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165781921394.9202.6162247811572175997.git-patchwork-notify@kernel.org> Date: Thu, 14 Jul 2022 17:20:13 +0000 References: <20220713135322.19616-1-jgross@suse.com> In-Reply-To: <20220713135322.19616-1-jgross@suse.com> To: Juergen Gross Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, wei.liu@kernel.org, paul@xen.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, stable@vger.kernel.org, jbeulich@suse.com Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski : On Wed, 13 Jul 2022 15:53:22 +0200 you wrote: > xenvif_rx_next_skb() is expecting the rx queue not being empty, but > in case the loop in xenvif_rx_action() is doing multiple iterations, > the availability of another skb in the rx queue is not being checked. > > This can lead to crashes: > > [40072.537261] BUG: unable to handle kernel NULL pointer dereference at 0000000000000080 > [40072.537407] IP: xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.537534] PGD 0 P4D 0 > [40072.537644] Oops: 0000 [#1] SMP NOPTI > [40072.537749] CPU: 0 PID: 12505 Comm: v1-c40247-q2-gu Not tainted 4.12.14-122.121-default #1 SLE12-SP5 > [40072.537867] Hardware name: HP ProLiant DL580 Gen9/ProLiant DL580 Gen9, BIOS U17 11/23/2021 > [40072.537999] task: ffff880433b38100 task.stack: ffffc90043d40000 > [40072.538112] RIP: e030:xenvif_rx_skb+0x23/0x590 [xen_netback] > [40072.538217] RSP: e02b:ffffc90043d43de0 EFLAGS: 00010246 > [40072.538319] RAX: 0000000000000000 RBX: ffffc90043cd7cd0 RCX: 00000000000000f7 > [40072.538430] RDX: 0000000000000000 RSI: 0000000000000006 RDI: ffffc90043d43df8 > [40072.538531] RBP: 000000000000003f R08: 000077ff80000000 R09: 0000000000000008 > [40072.538644] R10: 0000000000007ff0 R11: 00000000000008f6 R12: ffffc90043ce2708 > [40072.538745] R13: 0000000000000000 R14: ffffc90043d43ed0 R15: ffff88043ea748c0 > [40072.538861] FS: 0000000000000000(0000) GS:ffff880484600000(0000) knlGS:0000000000000000 > [40072.538988] CS: e033 DS: 0000 ES: 0000 CR0: 0000000080050033 > [40072.539088] CR2: 0000000000000080 CR3: 0000000407ac8000 CR4: 0000000000040660 > [40072.539211] Call Trace: > [40072.539319] xenvif_rx_action+0x71/0x90 [xen_netback] > [40072.539429] xenvif_kthread_guest_rx+0x14a/0x29c [xen_netback] > > [...] Here is the summary with links: - [v2] xen/netback: avoid entering xenvif_rx_next_skb() with an empty rx queue https://git.kernel.org/netdev/net/c/94e810067888 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html From xen-devel-bounces@lists.xenproject.org Thu Jul 14 17:49:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 17:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367746.598856 (Exim 4.92) (envelope-from ) id 1oC2y1-0005px-Rs; Thu, 14 Jul 2022 17:49:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367746.598856; Thu, 14 Jul 2022 17:49:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2y1-0005pq-Mq; Thu, 14 Jul 2022 17:49:37 +0000 Received: by outflank-mailman (input) for mailman id 367746; Thu, 14 Jul 2022 17:49:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2xz-0005pg-UU; Thu, 14 Jul 2022 17:49:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2xz-0001Bq-QI; Thu, 14 Jul 2022 17:49:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2xz-0007SM-9h; Thu, 14 Jul 2022 17:49:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC2xz-0000PK-99; Thu, 14 Jul 2022 17:49:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1syWI860qXtYOsTT27tu366XXHlwfoIEti3l1CYIeYA=; b=OnzIte7WiPe3QMnHSnKJ93Ee42 UdEP23msbyrfEKGLoPh0JEB18piK+82hWYf/q4SEie2OA6ytajvzgOVYCo3653qLHbWnb8sOJl/tL qJYr+SguKg0BdpQ0r0bANqo9idOHuAx0K9U2Ps/09bKkAGJRgAQlygYHLfjv1RvAOMng=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171625: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=265d49896d3b2217a2dd79ac496257f92f66074f X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 14 Jul 2022 17:49:35 +0000 flight 171625 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171625/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 265d49896d3b2217a2dd79ac496257f92f66074f baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 734 days Failing since 151818 2020-07-11 04:18:52 Z 733 days 715 attempts Testing same since 171625 2022-07-14 04:20:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115948 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 17:49:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 17:49:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367749.598866 (Exim 4.92) (envelope-from ) id 1oC2y6-00066a-8O; Thu, 14 Jul 2022 17:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367749.598866; Thu, 14 Jul 2022 17:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2y6-00066S-5K; Thu, 14 Jul 2022 17:49:42 +0000 Received: by outflank-mailman (input) for mailman id 367749; Thu, 14 Jul 2022 17:49:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC2y4-00065d-EZ for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 17:49:40 +0000 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [2607:f8b0:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 546c73ef-039d-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 19:49:39 +0200 (CEST) Received: by mail-pl1-x636.google.com with SMTP id g17so1069476plh.2 for ; Thu, 14 Jul 2022 10:49:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 546c73ef-039d-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=AoII7QfHsh0FNbRunZNvbmxpoj9M13hEFMAA79iSDDY=; b=c2ezCfZdkJdgOHkGl2PuHlR6OqlODRiBwlE/I/+w8civ4z8qFZ6xgZ4bB7Mf77Eg7+ KWY1YYEjQe+2FsoOi2YbkaU1MNouAnFbmTqy99tJPjqgjNsSETcUcYJLQCZ+3iUqclVO MUsBrj11z+vTujqbRY1O1ft7OvktsGfbHw1QU7ej3yYKhra2VfR5oM+tlUjNAMO00Fbb /ceIi99ZjGI/yygDqLYXbls0K+DUT/uVt7TCfZoU6IvvtTjfTsqJUWARyJ6tOyM3fS83 EoH78tcS4Sdw8gbr8lRQG81yQqz8L+WomFt7/X2Sgmnh1TZSpcRiGs6SLBpjVl4OfGQf lGPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AoII7QfHsh0FNbRunZNvbmxpoj9M13hEFMAA79iSDDY=; b=aig8dD//WO3LMppqyFRx43yea5RYpSrZQVoDy3KDoU4482vfn0g61YBS6fhZNBJOkN xJw0gM1x9pDDr5IejhEEkNGdO5UKh4wn75EvKF/kUpaHJWRK8nlfWR32DM+oh96+HErv YFM2MowLD3W+vIpz/EXzQbQyd9m9FlC5WkgpI2b6RciA1ZQPVHQ5fKLFrq021IU046IQ n+mybkOSaZPF7joBwC8mKem4oBypzIhtbJjtRIE4UcfVOw7foDT7hzIjdX8uaiQB+96K NsgrNDxnkfLtj4o6uW+OL7hDasoXlTI8ryR0tVh0ea/A+8brv26YiIQZYDSeC6bggKK4 poCQ== X-Gm-Message-State: AJIora+HgWANzzzLNWVReHFVXhy346JMj+1P1wbcOtpCcvx/S2HbJaYK n4N/nQrBcLEmFezw3pO2aWjrwDq2mvdFRjAQYclS5qFrg0I= X-Google-Smtp-Source: AGRyM1sUEIvN42AJCCxu8XnOxqtkv6mpbBaqsGZv7zQO6d0v22rXTWaHZUvCgEHo0LRpLhkuBlX21XT7WZDobUFNxfo= X-Received: by 2002:a17:902:f691:b0:16c:4fb6:e08b with SMTP id l17-20020a170902f69100b0016c4fb6e08bmr9680591plg.174.1657820977392; Thu, 14 Jul 2022 10:49:37 -0700 (PDT) MIME-Version: 1.0 References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-2-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Thu, 14 Jul 2022 19:49:26 +0200 Message-ID: Subject: Re: [PATCH v4 1/2] xen/arm: smccc: add support for SMCCCv1.2 extended input/output registers To: Luca Fancellu Cc: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Luca, On Fri, Jul 8, 2022 at 2:01 PM Luca Fancellu wrote: > > Hi Jens, > > > On 22 Jun 2022, at 14:42, Jens Wiklander wr= ote: > > > > SMCCC v1.2 AArch64 allows x0-x17 to be used as both parameter registers > > and result registers for the SMC and HVC instructions. > > > > Arm Firmware Framework for Armv8-A specification makes use of x0-x7 as > > parameter and result registers. > > > > Let us add new interface to support this extended set of input/output > > registers. > > > > This is based on 3fdc0cb59d97 ("arm64: smccc: Add support for SMCCCv1.2 > > extended input/output registers") by Sudeep Holla from the Linux kernel > > > > The SMCCC version reported to the VM is bumped to 1.2 in order to suppo= rt > > handling FF-A messages. > > > > Signed-off-by: Jens Wiklander > > --- > > > > I think you need to update the copyright information of the smccc.h heade= r (maintainers can confirm if it=E2=80=99s needed), > also it seems that you agreed with Julien to update the commit message wi= th a reference to the spec but maybe you > forgot about that: > https://patchwork.kernel.org/comment/24897413/ I'm sorry, I'll fix it. > > With these addressed: > > Reviewed-by: Luca Fancellu Thanks, I'll add the to the V5 of the patch set. Cheers, Jens > > > > From xen-devel-bounces@lists.xenproject.org Thu Jul 14 18:25:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 18:25:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367763.598877 (Exim 4.92) (envelope-from ) id 1oC3WJ-000313-1o; Thu, 14 Jul 2022 18:25:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367763.598877; Thu, 14 Jul 2022 18:25:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3WI-00030w-TV; Thu, 14 Jul 2022 18:25:02 +0000 Received: by outflank-mailman (input) for mailman id 367763; Thu, 14 Jul 2022 18:25:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3WH-00030q-9X for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 18:25:01 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 425e6351-03a2-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 20:24:58 +0200 (CEST) Received: from mail-dm6nam12lp2173.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.173]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 14:24:45 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 14 Jul 2022 18:24:43 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 18:24:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 425e6351-03a2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657823097; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nig3n99PepNWWrv6rObTVnq+5T0F8QPKeXChqjVlbWA=; b=SUPZ9NBU0x++qZGWjQG+SHnBQNftiY4RJgsIhmxXBtw6RebXCoatDrBI +ZmRqDWijD7wJzXCgk2eIKj6zE4MoODaPPrOhOofSsLZRcPdDlZpzqIRt qs7sG2bSmeRQ45l1H+ws7eD5foqzxhQvZtEk0uEPTNE0QuqJEfjQEIIBF k=; X-IronPort-RemoteIP: 104.47.59.173 X-IronPort-MID: 75642553 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:CqexVKjJF2ipjiMX5CgKXIWTX161nxEKZh0ujC45NGQN5FlHY01je htvXj+BO/6CYzOjLdF3Oty/8BwEsMDdn9U2TQJp+3s3RXkb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur5GtD1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eJdQp5tRYL291s uUVLmAgdDylqc7nz+fuIgVsrpxLwMjDGqo64ysl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF+RTM+vFfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2i3x2LOVwH6gMG4UPI2m39tApFOP+mcWBQUfDQCgmtCjpHfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAgUzVILvIvssQ7QTg3/ laTmpXiAjkHmLicVXKc+6rSsTqoIyERBXcYYjMDSw4M4t2lq4Y25jrNRNt+FK++jvXuBCr9h TuNqUAWhagXjMMN/7W2+xbAmT3EjoPSUgc/6wHTX2SkxgB0foioY8qv81ezxelEBJaUSB+Gp ndspiSFxOUHDJXImCnTRuwIReut/6zcb2aahkNzFZ488Tjr42SkYY1b/DB5IgFuL9oAfjjqJ kTUvGu9+aNuAZdjVocvC6rZNijg5fGI+QjNPhwMUudzXw== IronPort-HdrOrdr: A9a23:84IEHq1fyZyWOwqb2vl37QqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.92,272,1650945600"; d="scan'208";a="75642553" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IFY90l9qWo6WCjq1WCPhIbgucKS7Ae5w9qMtK99sFATo41Rb9IQJ7LCNNk/O/IvaEB9Y0jOQvk1wTRBi5m0YZGZ6yoL84WLrwxN445+MAGl8X+hp0VoR6z4PiOk+N5Dx3naw2u1f42eke+OJ4zAgId6N43W6F0SNV+6XsHqbkFNASBGn2MnlFFE7YBbSAFOQ4MXRH24x3yqfJ2WPvyy2lu8T2q0glGecUzQgobK5hqyNpMPZOUjHMJKSopUrpK27OXuEJa6wJDv2PVgswCldx3erQKhqbRwkbPnZeeyJOZq1s+S0++VUbMSRAHuFJ8lISjXKPzrTE29zDIF6UYLylQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nig3n99PepNWWrv6rObTVnq+5T0F8QPKeXChqjVlbWA=; b=h4tymM3Q+jMu3FzyWHL8WtIaZn4S44KM+8AiAoa7KgT7AiynVd9/WPTQ5EPQbUl+SA1jQd1NWj3oDPsXw+KPGEO1+cW39acdrSyEExQnFQpHIEoxfHXK3NFSAQP0hA7oqf5aJDWBHJo23eXkVJPKElbNrKlYbiS9/pUXphKZgCA68JhWi+QYNewtzvaNayxPMtEHTifSrIVy5XixkJpU68RUBdc+fJEWlb0ELu/pbtcetkMWy3HzQvbHY8G+Fflxqz5hpzBpC/+JXz/BFdMMGzKe7R3kK53MtoKKi6AB4/XKYhizazndoKMi06RPXG8J5ytphCVjnIcftjoflANFtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nig3n99PepNWWrv6rObTVnq+5T0F8QPKeXChqjVlbWA=; b=kUdsankuF/23fsmePsBCW9pncNKFUudS3c9tsVl+OFIEhQ+fW/CTMH1G2UHiPpMEGhmi4OcpaTgL0CqV2Ihbqazr6OzpzQ7IbQdu51BAiCI9ju/r5veXE9qSS3qdjvLZ9/cEnANpqtQuGDinc+qBjNT40oDVJT+9EICQZC8D5ik= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw61+LtiA Date: Thu, 14 Jul 2022 18:24:42 +0000 Message-ID: <8790939e-7f92-a3b5-9433-335b9875693e@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> In-Reply-To: <20220714143907.25938-2-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e61f88f-3476-451a-0097-08da65c61f5d x-ms-traffictypediagnostic: PH0PR03MB5669:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: k0u3CAEHzD8nU2mh4d0bD9AhhlExkLdhFKb9VV4hE4tWrAa0Abtl88g4a5CIrADtV157atN9iAHaQeMHCOlSrnz4yfQE4hVxiB06Gu6Km2Az/eiKVjvKT2IAU72ZUhdIB6B3iHUs0kWKHHTuxpN/0eCUzZk3ZE5p94KQ3vprP1PXTxy5vZVOeDHIs+adka6sVOEE8Vy3HObJlqfFlaPbDoz8C+JKFzPpq28t7WJzj1nRO9UqJKw5upmD13srnwNJ+W/ZZeHx5cngCj2OsmKlL2tJ1dhf0A3hjg2/ZItkGTXnhdtvYspYdtmaGjGc4v6WEKTliEpENdMVjaoiMtSqypPNFoTbjYqPtwXqiy6P8PmdG61s6ZlCLP58KgEPio29XuBAQYyu6nlVik+yr2aBQDhoq+81bls26KbVBGJxg8uGM9lSL8Uw2QuFuX0rIqklo8bkfqLQ9lkNEB4BJulghDUTK2zRRIcnML3ilJt/gTioIPNoesLXLIMeOAHXL0py9dB/Jz5bXsPe0uUDRztjsXzXuIBXtlucYuX2tGa/I9Q8ls4IGyeuvM/LrEeR79y1Z6mL1QQSOejJuQNLGX9g9WjKraVfth4n4SCzZYZDW7mcCrryiwJUFFjtQlOPA6ktAQ5v9OP/ZwA6t2jstBjYWoZi+Kd6aR7E9PRvjucYPD2L+B/9AiKM3xBYV5GVBK2QY+x9yRk2sM+96/QsZ/VzB4Bs2mU5gmeAvB+nNG8FbracwDBvkrX3vaWyTW8Qk13IAvNT2rizROoudacI546/oI1bNcwBjzxNbiTHJCblhfyr2XLBucNUglxjSrlT8n33nBfWzF1srDr1GnNllKWK5IZGtaBPShOPoWxMnu/pqbaHYUOXuWu0F7XUsNiXsJAKHgIa8I9n/XeSNiIyf/XyJ2jGUy0zjxi9+SrVQhE4weI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(376002)(136003)(366004)(346002)(31696002)(86362001)(5660300002)(38070700005)(186003)(2616005)(82960400001)(8936002)(4326008)(66556008)(91956017)(2906002)(66476007)(8676002)(31686004)(64756008)(38100700002)(26005)(76116006)(66446008)(71200400001)(66946007)(110136005)(6486002)(53546011)(6506007)(36756003)(316002)(41300700001)(54906003)(478600001)(6512007)(122000001)(4290200001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cDYwL0RTQnpoVk1Jckx0MEp1YlEzbERGbGQ0TzQ4LzFoa21UNnMzQVZ3Y1pE?= =?utf-8?B?M1NFNm4yV1VNU3VvMUpsbXNtRkhiMUtiRThlVjN5TldZdG44S2hCcGFELzVU?= =?utf-8?B?Vi95Nnp4Ry9YRS9HbHVJZXZqb1NTNE1ueFV4V2tKQmVBWDVQd290UTNvZW9R?= =?utf-8?B?TVpNRjUvdXIxT2J2QUtxamRlTzE4OXFqTmp6VnNQaHJxQmNzZENQKzZxY2Nk?= =?utf-8?B?U0dtSXRmNTlMOGxJaDVYOU5KQm1wTVFDNVBEZFBoODcvVkpiS0tjL2QyRU1G?= =?utf-8?B?YkxSK2FpS3B3dVF6eVphZ2c4Lytvc1luQzR0SWtzYTZyRmRITEtvUUFKcVdL?= =?utf-8?B?Ry8ycVRqMDd1bEZuQ1BvNDJIY3JFMVRCOUtaSHNJa1J6MFBOUFJwNDkvcGox?= =?utf-8?B?aEtibG5KckVodFNCbmoyV1hyWG8xZ2xUblZvakJ4VVhnbkZXMyt3Y1hVbHlZ?= =?utf-8?B?MWdGbXBycVBWTTBBeU1Ma01LUFNuNU83RFI5elpHNDJhQWlRMVBIajlwRFZ5?= =?utf-8?B?Z2tIK0xvcFNRU2xVYWY5Nk1SR2F6YjJxbk8yaHE5UFkxcU40L25xYmNqTzV5?= =?utf-8?B?dkcxNmlyeGZZUHpoYXRoQmtOeUJWRkVNUWlUZFFzWHJ3eGJtekpDdmkxcVo4?= =?utf-8?B?TnVQQVFQODdvcVNZaGFHSUVBNittSi81NFR3QmZUVGZNdkZiaFRha1phNkNp?= =?utf-8?B?UVpHY2FFejBCZzlGdzFSRy9MWFo4ZkpDUUN5cEY5d2R6V0cwbjJJMlFjRGF3?= =?utf-8?B?akVWaDVUL2VlVjBYelF1bjRibk1BajFSb2dTa09nMkxJankrNWZvVnpWTlBF?= =?utf-8?B?dmFXSWNRcEhOOXhGZWNKVE5scVZoeVVsMTVsV2ZKMUdibXlEOWJnU3pxS3RF?= =?utf-8?B?U2FMU2RweU5VZ3N2bTJ2cmxRNlppcnFjVXZ3WnFOdUZWb0ZGVWRZampLT200?= =?utf-8?B?enBBM0xTYjJMN1JXUlFxMzltR2orSjBINHNTQ2tGSE84Y0RRUGFrbXhOejBG?= =?utf-8?B?YUdjdndNSWd5c013NDNFYnZBWStkZzJWZFVUQXNxL0pMTGdJc2lrMHM0WkI2?= =?utf-8?B?a3BWYWZwTmNZZ2c1SWttWDExRTk4Z2NsV2hSbVZCVGgxYTVYZjZJUEovbklG?= =?utf-8?B?OUNOd2twWFU5ODE2aGlZNUhobFpQRURVekY4SUxrekVwd1N4WHNoeUJRYURC?= =?utf-8?B?bXg1K21ITlBPazloc0pvblZDQmZEK1MxeERiOGNpOHZkejY4YTVUSUI5SEVO?= =?utf-8?B?Qm0rdGNZaHVCZ0kzRFVNdEtESXVNRHpvMDRTQS9LK2dvL2wxN3ZDK2VaWDkv?= =?utf-8?B?NFQ0MWxIL3k3SHFPbFJIR2lvbDQycUQ3VWVkY293cVJ1VUVWRzdaMmxJMnF6?= =?utf-8?B?Q1d0V3owdkU5eFlRM2ZvSG9RVGt5ZzNwMFJoNU5tQld0Q3lHbzlCMm1jUXRC?= =?utf-8?B?Rzh0RGx2NCszbHlhL2h5L3lYRlAwT2c2SCtVU1hiZEswZWV0N1pYWXFOTTNM?= =?utf-8?B?aDRiZUxoeGxDTWZOUS8rKzFaeHdSNzlvYlNGNlZEWHd6S1BQOS9Wc3l0MkJT?= =?utf-8?B?YkdKaUxnZnBjRnJsWTFHM3BlYlFMNGROYU1kQVBXQUlLMkdZMC9wQ08wZFpv?= =?utf-8?B?WWN2NGFudkZhQVBYZngybkNtRk9Dbjl5ckdPRER0YmJVNUpLTkpLeitJbDdj?= =?utf-8?B?SGt5THVMUElZNFFSV2tHcE5vM1RCL2RVNXdRNlFFVGYxVlZzQ3dTenVjRXlq?= =?utf-8?B?WU9kaEFQczNBczk3TDRFckVRTmZZUk1LdDlLWU5md3lYbDZ5N2V1bDVxc3Bh?= =?utf-8?B?L1JqNDJXanV5ZXU4RklrbEJFall5U09vQUx3Y1B6SDhneXRmRU5tVFF6cWFX?= =?utf-8?B?NEpNczdkQ0dESzBMQjhDeVRvbHhFVDhENjU4bktDbjlYZGtlS2xtaVk2LzEv?= =?utf-8?B?SHdzRXRhbTJXbzRrQWxyTnV4N2VVQVdPVEZLS0p1RVI5ekZIVDE0cFJ6YnBk?= =?utf-8?B?UUgrMDNTUWE3aGpEMXJiT0U0UFVnZU5aeEQ0VVBDWjZLTFBwSFpmZ245RmFT?= =?utf-8?B?WkVseksyNHA0YXJhT25uWUt5b1BJOGYwWEh5SlZ2V0x4NXJBdmlxTG5tbGxQ?= =?utf-8?Q?Hpw16IhAUUkfBpzrMMPkCGYXX?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e61f88f-3476-451a-0097-08da65c61f5d X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 18:24:43.0308 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QE39xA3jtJ+P+107Ju7Q8bVnU0mLoa79ZGQOnYQ05Irs4aH4jPKRbUGhQWan6C8Oumr60V/7zSEWSrIztQ0tUurZej+Vl6Vo2lmvXR6QnK4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5669 T24gMTQvMDcvMjAyMiAxNTozOSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IGRpZmYgLS1naXQg YS94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2ggYi94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCj4g aW5kZXggNTUyZjIzMzkxMi4uNjRmYTlhNTZiNyAxMDA3NTUNCj4gLS0tIGEveGVuL3Rvb2xzL2No ZWNrLWVuZGJyLnNoDQo+ICsrKyBiL3hlbi90b29scy9jaGVjay1lbmRici5zaA0KPiBAQCAtNzgs NyArNzgsNyBAQCB0aGVuDQo+ICBlbHNlDQo+ICAgICAgZ3JlcCAtYW9iIC1lICIkKHByaW50ZiAn XDM2M1wxN1wzNlwzNzInKSIgLWUgIiQocHJpbnRmICdcMzYzXDE3XDM2XDM3MycpIiBcDQo+ICAg ICAgICAgICAtZSAiJChwcmludGYgJ1wxNDZcMTdcMzdcMScpIiAkVEVYVF9CSU4NCj4gLWZpIHwg YXdrIC1GJzonICd7cHJpbnRmICIlcyV4XG4iLCAiJyR2bWFfaGknIiwgaW50KDB4JyR2bWFfbG8n KSArICQxfScgPiAkQUxMDQo+ICtmaSB8IGF3ayAtRic6JyAne3ByaW50ZiAiJXMleFxuIiwgIick dm1hX2hpJyIsIGludCgnJCgoMHgkdm1hX2xvKSknKSArICQxfScgPiAkQUxMDQo+ICANCj4gICMg V2FpdCBmb3IgJFZBTElEIHRvIGJlY29tZSBjb21wbGV0ZQ0KPiAgd2FpdA0KDQpJIHRob3VnaHQg SSdkIGZvdW5kIGEgY3VubmluZyB3YXkgdG8gc2ltcGx5IHRoaXMsIGJ1dCBhbGFzLg0KDQpSZXZp ZXdlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4sIGJ1dCB0 aGlzDQp3YXJyYW50cyBhIGNvbW1lbnQsIHNvIEkndmUgYWRkZWQgdGhpcyBodW5rIHRvbzoNCg0K ZGlmZiAtLWdpdCBhL3hlbi90b29scy9jaGVjay1lbmRici5zaCBiL3hlbi90b29scy9jaGVjay1l bmRici5zaA0KaW5kZXggZjYzMzg0NmIwZjc5Li44MDk1NWY3NGM3MWMgMTAwNzU1DQotLS0gYS94 ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCisrKyBiL3hlbi90b29scy9jaGVjay1lbmRici5zaA0K QEAgLTY0LDYgKzY0LDExIEBAICR7T0JKRFVNUH0gLWogLnRleHQgJDEgLWQgLXcgfCBncmVwICfC oMKgwqDCoMKgwqDCoCBlbmRicjY0DQoqJCcgfCBjdXQgLWYgMSAtZCAnOicgPiAkVkFMSUQgJg0K wqAjwqDCoMKgIHNwbGl0IHRoZSBWTUEgaW4gaGFsZiBzbyBBV0sncyBudW1lcmljIGFkZGl0aW9u IGlzIG9ubHkgd29ya2luZyBvbg0KMzIgYml0DQrCoCPCoMKgwqAgbnVtYmVycywgd2hpY2ggZG9u J3QgbG9zZSBwcmVjaXNpb24uDQrCoCMNCisjIDQpIE1BV0sgZG9lc24ndCBzdXBwb3J0IHBsYWlu IGhleCBjb25zdGFudHMgKGFuIG9wdGlvbmFsIHBhcnQgb2YgdGhlDQpQT1NJWA0KKyPCoMKgwqAg c3BlYyksIGFuZCBHQVdLIGFuZCBNQVdLIGNhbid0IGFncmVlIG9uIGhvdyB0byB3b3JrIHdpdGgg aGV4IGNvbnN0YW50cw0KKyPCoMKgwqAgaW4gYSBzdHJpbmcuwqAgVXNlIHRoZSBzaGVsbCB0byBj b252ZXJ0ICR2bWFfbG8gdG8gZGVjaW1hbCBiZWZvcmUNCnBhc3NpbmcNCisjwqDCoMKgIHRvIEFX Sy4NCisjDQrCoGV2YWwgJCgke09CSkRVTVB9IC1qIC50ZXh0ICQxIC1oIHwNCsKgwqDCoMKgICRB V0sgJyQyID09ICIudGV4dCIge3ByaW50ZiAidm1hX2hpPSVzXG52bWFfbG89JXNcbiIsIHN1YnN0 cigkNCwgMSwNCjgpLCBzdWJzdHIoJDQsIDksIDE2KX0nKQ0KwqANCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 14 18:37:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 18:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367769.598888 (Exim 4.92) (envelope-from ) id 1oC3iV-000543-40; Thu, 14 Jul 2022 18:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367769.598888; Thu, 14 Jul 2022 18:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3iV-00053w-0s; Thu, 14 Jul 2022 18:37:39 +0000 Received: by outflank-mailman (input) for mailman id 367769; Thu, 14 Jul 2022 18:37:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3iT-00053q-PP for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 18:37:38 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 06d408b9-03a4-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 20:37:36 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1657823849553651.8044949330165; Thu, 14 Jul 2022 11:37:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 06d408b9-03a4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1657823852; cv=none; d=zohomail.com; s=zohoarc; b=lET8+YswKQnt9z1OT2xhDqDPbpGN8hvbv6gfW19MgBRoj1wCQEOxY/PiMy/AHi5f4lTuPWH75yj7qNbVsIZh5SHsVB363AGotwIZt9ynF5coDTtmjxL8kTVmzFSkixQzQKmdGqUGTeKoVbWij0Lr+c3dPMjTahfwTzuq5iqMdMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1657823852; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fG+QZHlO/wSEPhTewtGSNBoT1Wkf0kp1paagS1eHz+k=; b=cSNSDU81n7BxlAfyQ02HQTxh/EbDrq7C6k6iOYF+Ld3bBX96WhA3hKSsEw97HJPieN8S4Vxo8rja32tMjAg94WBRY5UDGlHrrDtacaaUitduLsH1ECgFOCLaJ4fIzjiiVigJFhfrAOzL2+MuD+zUf5IS9K3aFJgbcGDNby4W32o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1657823852; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:From:From:To:To:Cc:Cc:References:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=fG+QZHlO/wSEPhTewtGSNBoT1Wkf0kp1paagS1eHz+k=; b=ops2pci6OZN4lCJORnY+Nh+w+/3QcxVHaEgX+sq5tSEuYc2CGr6V77MbYBxJmew+ r2zg1GsxsjDAQvZ4SfqI+YJKzdtO3CdUDRqA7OcfI2buKLKoKLKLXI8mnd/Gj55nx5A NXVYMTPo241rNmFsWEYCGTBoxYI20KjqAL1iycUI= Message-ID: <08f742e3-eff2-a53c-bf1d-91226a223d4f@apertussolutions.com> Date: Thu, 14 Jul 2022 14:37:14 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Hyperlaunch Working Group: Status and Next Steps (15JUL22) Content-Language: en-US From: "Daniel P. Smith" To: Xen-devel Cc: Julien Grall , Bertrand Marquis , Stefano Stabellini , Christopher Clark , Rich Persaud , "Smith, Jackson" , "Brookes, Scott" , "Lei, Jason" , Scott Davis References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/10/22 18:45, Daniel P. Smith wrote: > Greetings All, > > We will be holding a Hyperlaunch Working Group meeting on Friday, July > 15th at 0900PDT/1200EDT/1700GMT. The agenda will be ready by Wednesday > and can be found at the below cryptpad link. Call-in details will be > published in the agenda once it has been set up. > > Agenda: > https://cryptpad.fr/pad/#/2/pad/edit/0uw06jY29gjSJMxs8Q9CWipp/ > > Agenda has been published with the call in being via GoTo Meeting[1]. If anyone would like to see specific questions addressed, feel free to contribute to the Community Topics section. [1] https://meet.goto.com/apertussolutions V/r, Daniel P. Smith Apertus Solutions, LLC From xen-devel-bounces@lists.xenproject.org Thu Jul 14 18:53:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 18:53:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367775.598898 (Exim 4.92) (envelope-from ) id 1oC3y5-0007cv-EY; Thu, 14 Jul 2022 18:53:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367775.598898; Thu, 14 Jul 2022 18:53:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3y5-0007co-C2; Thu, 14 Jul 2022 18:53:45 +0000 Received: by outflank-mailman (input) for mailman id 367775; Thu, 14 Jul 2022 18:53:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC3y4-0007ci-4z for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 18:53:44 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46c2b0b5-03a6-11ed-bd2d-47488cf2e6aa; Thu, 14 Jul 2022 20:53:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46c2b0b5-03a6-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657824822; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=PYjZibqlUc5HapZ3z5TXoIsV/PSL5eJB/GaF84eWiGU=; b=Vr3UTERrfbmbRFn7dnav6nlLl7aVHt3q3T8dyiA92SZfnuhz2TgZea0R rEXmuOibRh2PovipcyJg44LUhePFv+Kt6qUKIqhBYVDkhlc0O52ofxiUA rJ627iVenQ7hB9krUp9e73ttxwiOyROAWiJXmQAk2enunv2y5KmSecdwo w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 78398029 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Fl4eR6mFWdlN1vXnvjcAwKTo5gynJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOXmyFb6mMZDD1KNx3YNvl9B9V78PdxtVqSAU5/Ck0EiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462u4GhwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k3ZYZEqtd3Dlps3 tBFJBsPdU6J3dyflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVmPFsNBY14t+CvnnTlKBVTqU6PpLpx6G/WpOB0+Oe9a4uFIobbLSlTtm2Zg 3Lp3Wb5OTAXOdnY7BOVrUuRisaayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRiFO6Wt9ZA 1wZ/Gwpt6da3FewUtD3Uhm8oXiFlh0RQdxdF6s98g7l4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9a1iQ67OVpjOaIjUOICkJYipscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6 zHSp3RutrUctuwg+/i31lLc3Tj2mLGcG2bZ+T7rsnKZAhJRPdD4ONH5sQWCtZ6sP67CEADf4 SFsd9y2qblXUMrTzHHlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCHx7ZiLCgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT2yzxNzzflgY 8/AGSpJMZr9If09pAdaus9HieN7rszA7Tm7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ65TPHu2 48HbaOikkwHOMWnO3m/2dNCdjgicClkba0aXuQKL4Zv1CI9Qzp/YxIQqJt8E7FYc1N9zbqSp C3iBxcIlzISRxTvcG23V5yqU5u3Nb4XkJ7xFXBE0YqAs5T7XbuS0Q== IronPort-HdrOrdr: A9a23:F6a1K66YsO7U24MI0wPXwMrXdLJyesId70hD6qhwISY6TiX4rb HWoB1173/JYVoqNE3I3OrwXZVoIkmsk6Kdg7NhXotKNTOO0ADDQb2Kr7GSpwEIcxeOkdK1vp 0AT0ERMrLN5CBB/KTH3DU= X-IronPort-AV: E=Sophos;i="5.92,272,1650945600"; d="scan'208";a="78398029" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Anthony PERARD Subject: [PATCH 3/2] README: State POSIX compatibility as a requirement for AWK Date: Thu, 14 Jul 2022 19:53:05 +0100 Message-ID: <20220714185305.29507-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220714143907.25938-1-anthony.perard@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain In particular, we support FreeBSD and NetBSD build environments, and some Linux build environments use MAWK over GAWK anyway. Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Anthony PERARD --- README | 1 + 1 file changed, 1 insertion(+) diff --git a/README b/README index 5e55047ffd9e..89a1d0b43c4c 100644 --- a/README +++ b/README @@ -48,6 +48,7 @@ provided by your OS distributor: - For ARM 64-bit: - GCC 5.1 or later - GNU Binutils 2.24 or later + * POSIX compatible awk * Development install of zlib (e.g., zlib-dev) * Development install of Python 2.6 or later (e.g., python-dev) * Development install of curses (e.g., libncurses-dev) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 19:00:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 19:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367781.598910 (Exim 4.92) (envelope-from ) id 1oC448-00006M-4t; Thu, 14 Jul 2022 19:00:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367781.598910; Thu, 14 Jul 2022 19:00:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC448-00006F-1D; Thu, 14 Jul 2022 19:00:00 +0000 Received: by outflank-mailman (input) for mailman id 367781; Thu, 14 Jul 2022 18:59:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC446-000069-3s for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 18:59:58 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 25dbddd9-03a7-11ed-924f-1f966e50362f; Thu, 14 Jul 2022 20:59:56 +0200 (CEST) Received: from mail-bn1nam07lp2046.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 14 Jul 2022 14:59:52 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5875.namprd03.prod.outlook.com (2603:10b6:303:90::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Thu, 14 Jul 2022 18:59:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 18:59:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25dbddd9-03a7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657825196; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=nRcjv3beWnD4LWIRFTqpeKJtj5MF12QYMuqTM7uC+D8=; b=f5KLC3B5BzOMxuIZp2JTYKROQG7vIRls3hz7/XAyXRdpj8cvoZ3XuRBz 7CzYgCBDVwq9OLa2gYliEozPmZTTcj8MuqJsYAHEjs7MKrZx5G+uJeto5 txDaZHpXCEi+X7mApGXdwauFkdAz6h4znxssqGhxziT6RgC5bb9+vZX3/ o=; X-IronPort-RemoteIP: 104.47.51.46 X-IronPort-MID: 76257622 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:8HawFqjSMldTjARuSmovij3SX161JxAKZh0ujC45NGQN5FlHY01je htvWz+FMv2LYWrzLtwlYIy280pSuZGGnIdqGQBprXhgEyMb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur5GtD1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eZrESw/d4DHpy9 aImKgA9aw2SgcO1z+fuIgVsrpxLwMjDGqo64isl5xeASPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF8RTJ+8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSz227CRx3mTtIQ6EoeV5t13oGKq4E8zTx5NcGufuOCooxvrMz5YA wlOksY0loAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLkwZRTcHRtUgv8IyQSEC3 0WM2djuAFRHtbSJSXOQ6/GIpCmoMCw9NXUFeSgCSAIE55/op4RbphDFQ8tnEaW1psboAjy2y DePxAA8mrESgMgjx6i9u1fdjFqEvYPVRwQ44gHWWGON7Q5jYoOhIYuy5jDz8vJoPIufCF6bs xAsscWE8PoHC53LsSWXWfgMB5mg/fPDOzrZ6XZPEp875nKS8nisVYlK5Xd1I0IBGsMNYzSvf UnctBha5J5QIGCCc6Zrbpn3Bd5C8ET7PdHsV/SRZNwXZJF0LFCD5Hs2ORDW2H3xmk8xl615I Y2cbcunEXcdD+Jg0SayQOAel7Qsw0jS2F/ueHwy9Dz/uZL2WZJfYe5t3IemBgzh0J65nQ== IronPort-HdrOrdr: A9a23:Gfbr36G+W6Bs4gpBpLqE4ceALOsnbusQ8zAXPiFKOHhom6Oj+v xG8M526fbUskdzZJhCo7C90cu7IE80nKQdieJ6AV7LZniAhILCFu5fBOXZrQEIYxeOk9K1rp 0QEZRDNA== X-IronPort-AV: E=Sophos;i="5.92,272,1650945600"; d="scan'208";a="76257622" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H6Y8F3B8MVEnt5dxyc3VszVyL6kqmLnzrR4mXSq/0jajoyBjmOWwBIW4eJq8eKTKPjg2KmePWWzqGlRdD0lAfEK1O45IY8dMH4gXWVnuHn4k60Ejqha7BYKg+rw+GVEoP4r2tfoMQojPJqf60uQXSmOK0uUhXsZ8MSJ5/FgWUzQNYaydd8X3tQi19w1HgAAJYS6MHSnErheckew6kX3DMtGO2CwA39Pkq19LdpjI29+N7Pvv0L9UccCGrDC5pgahQVoIHvAF+5pYYV9sXG1Ho+GvnKWaCvfEeUAvhvuGEKngL8KUnV/6KUrLWB475pkF4Gb8Oc6PQ54poOws3tGUXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nRcjv3beWnD4LWIRFTqpeKJtj5MF12QYMuqTM7uC+D8=; b=BREWy5r+Vy+r7oKit/DezKRzRU+fpxAEyqwBXVU4RTzhTbsY41jmYHyQhWRUMZueitKYYAq73UlbbAx+CYA9e7v3W0CjK76ZkyTfqvOKBxkytbhsPjzhszDcjO+IG048S+oPGxJrt5ZTmtX+Aa6RtRy26Acv47bk7A8YOTAg5+vjEwdKiHg+3p61KVpwg5kQJm4yVvuTQPO3XheJx1VZyw/x9KlIW9bb/L+tyTs1y22XkRGTPsP+zfA42iVkE1pD+M8n+vdmt0VFgyr/OLnx/2ZI33iw11tDBg+xyPkBLBu/q0dR14AeX56BGWYAP0aVYrXDcz5Ju6VWhotD6FtKvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nRcjv3beWnD4LWIRFTqpeKJtj5MF12QYMuqTM7uC+D8=; b=KCHVDMM1cET0UB2pWcxnYmf4KY8McGihHh5p51FYsa6K/7rkpkABuZVxFQP9TtAJgrXXmgig+syF2iPwdd1x2jVbEeyo3i7oOC0neMyn4fXOL6aLnef50txjgfgxTfm86VRr8uvDrfscFEZn3bvWTrwT8Lh7Tmc+9USY7fF8mQw= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , "marc.ungeschikts@vates.fr" Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw619+TQAgAA/dYA= Date: Thu, 14 Jul 2022 18:59:49 +0000 Message-ID: <57df4df1-2145-72c6-7268-eba6de7c6a55@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2d4ac924-fca2-4958-5015-08da65cb06e4 x-ms-traffictypediagnostic: CO1PR03MB5875:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SqSvOcgAjaKX1s89WBP0q0MPWeWu3EHB6KidQ0Wd6FlQZHtBQ1fhN6erqlC/bAsQmRvYYRm360+kkz6NzGnO4Spr33IAQAuErgntZ7iWYqAU9Z8jycKvnloEm0sU7WdSUnF77FEl7MFpHXungobM2Vkh0kEXvgaXKvelAE2CzFsnocrXSdAny+nj1XizhmK4WxXWZ/kq0h9JkWdSVJp84qO6rtjVUnWtOR6xr/Tk6Dtkvu/OJuftrg5reU6anTIjdYzHkWQ9hvveulw+XgeOay9MoTf9+S+7k+ZY6HD1R7FvqMZxmn/ZdhJKUTc9Xbj/Eik7hHaPXrNDyPwwfGAKviG9xiwZsnDMPuWvuu7P59o3SCSImnZ1TazrltTulqeJABi8cUBkdiB757fJdExv013+1+YOYEFD4fA9Ks9FH41unsepBBr4xwHfFMI3Zmeh1cEAT7cmyrBA9LeVfz3EVcZN6sx22YhYI3wl169CZlmnaSX0zSAKJeBsiPTJv34Zk51I7iiiBSanR46QKXTn/TeChpWtYknL4lYAlhnW2hXhHyKABKpY4NKWxKxcB6u/5Oc3x8VIVNPe9imN8ey2GA4UHaCt143fY4rrpOf+XCka/S+BQZ+Uw0VZBhQ4LeZKEVwLn/fdHpTF7w+hCuDENzeVE7zDo7Mr+gjxQOCe4h3QnNgYIB2z4La3ZOOj9BuSRP1r75QNenNlhUzzakovnUmoNr9v/8v6EUv8s3JqusVJT7xffUVqir7RffkgifzKuqw4hBe4E4Ck2N4QBYxgN/y+Nhcn48sfRa7jrYkI2oBWvfqQQP+X835+32EqnHumfgqA6VR7M8MErG41/Y7Je5ljPvGYxDH9EQ3ryXVMFMlb5l51/VhKUAtWLhZp1M5FKDZuVAePppjd9sunA6A6Nfiy99tnW8IR+43ehc4/x0g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(71200400001)(26005)(6512007)(53546011)(6506007)(478600001)(41300700001)(5660300002)(8936002)(7416002)(2906002)(54906003)(8676002)(110136005)(316002)(6486002)(66446008)(76116006)(91956017)(66946007)(66556008)(4326008)(966005)(64756008)(66476007)(122000001)(38070700005)(82960400001)(31686004)(38100700002)(31696002)(86362001)(36756003)(186003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Yk4wVHA4MWpoM09WL1AvNnBsTWRkRE9Id3VPQXorKzhXTW9qak1GMzJnNjlW?= =?utf-8?B?cVB3MjRnaGkxTDV5VlFHQk40d2I3eUhmcWNuQWFOQi9WQVoybENNZmV2cWRQ?= =?utf-8?B?b1BYbFZYdzhsSUlVRUlWcWNnd0FSbXN0VVN5S0UxZjd0SjZoNDJVYy9JdVY0?= =?utf-8?B?ZmtpYm5wTkpmRmxEcVBGVXBuWnlkTnVuQ2I5ejdKOHNBNGowTlhPNmxkQjkr?= =?utf-8?B?SGtjN3o3bWR1Y1RIaUp0UnBaSlJlaXlvM1REM1IySnRJSXQvZTVnem9xRUU4?= =?utf-8?B?c20rdmtOQmtNdTVvQkNVNUJQZE5vZ1BNeXZOUnpCaTNIc1J5dWEvMkRhWHpO?= =?utf-8?B?eDNyUlFpMys3dFFPQUtUME8vaTRpV0xkU3NiUWVYTkZkOHBvaytVRkMrbUZZ?= =?utf-8?B?bENkeldid05HNjAyM0R2NXhDUjlMWXAxN3VMQUxoQmZLRGQ2UmlkRVJIVDFP?= =?utf-8?B?cDdKUFhIT2dKZnFWL3lnTVpiY21MU1BXdkltcUpVQmxQUnZKTjE3UkVRTmZk?= =?utf-8?B?R2FUYStwK3VzdDcxZzlDSkUxU0ZSZjcycGFrWU1iV2l2WTBSMnk3VXkrZDhU?= =?utf-8?B?VCtuTEpoQStSd0FURGtXaERGVTNEOC9PellubFVrZHpOeWg1UGMrNTBmYndu?= =?utf-8?B?TlNLSUFZa3JWRVdUNW0xZ2RvMHpHVVRWdjFHL0tOeURkN3FUbElvRkNYeVlC?= =?utf-8?B?R1ZhQU1DU0dSS3BBbGlXQ2FHU3IxUTFwRzc3eDNGRlk4UGVvS3VWS2xtbXBI?= =?utf-8?B?OGxnWm1vb3B3akp1REZ6T3cyK3VYNzRsUEYxMzh3TXVZVEdCa3pNQVZNZlox?= =?utf-8?B?UmJRT0M2WmdqWVdiQ3plbWZzdVlMWXlJRlRXRjFtZW1iTjJpaVpWNlRScXIr?= =?utf-8?B?RW9aU2V0QUFOdEVhNFNpSEJ5cDVEMEwwNkJQYkhEYk9CblRZM3A4OUtvbGth?= =?utf-8?B?cjl1MUFFdWRNOFpqM0xIWm5CSDhSK1pieGFEVzFrNGxFOVl3K0Z3ck8vaTgv?= =?utf-8?B?K3ZLTDFXQk1FdzFQMytjYWZMakFqZDV0dCsrS2gySlRKY2ZtUkRaeE9oUHhO?= =?utf-8?B?bkpFVzZMcENtVFFMSjZMZnZCcUtaUzNBSVQ4VTBlcTdRaWRQYk5NYktLOHYv?= =?utf-8?B?Uzl4VXRwb2JvdCtKREEyWmdtOWc4ZFJMaUxsa2lQcHp2U09BNER3TldYdm1I?= =?utf-8?B?MkExWmxCWnlzTFJUNFM1Tzc4WW9tRXRNYUI4NTc1b3lrUm5NSzBQcmJtNDFF?= =?utf-8?B?enRrUUFZWHVoTnYrcURiWjlub1NXdkpUa0pZNkJRdVJERW9RMDd5STVjcEdh?= =?utf-8?B?TWg4MjVkcU1QMkJFRjdIMHd2VFRhSHBVMXNMQWxJUmZwN3Noc202Qk8xeS93?= =?utf-8?B?WGJDS1pNUnp4aWoraC9FbSswTGMwQzloR2U3Um01WnJPUGRwaWlWaTJOcWJJ?= =?utf-8?B?VlhSWkMwVzQxd0s0N1gvdjFwN3dWOFNiWTFMaERNVitEM0ozQXlyclJacXpp?= =?utf-8?B?MGFzSkYyTzkxQnV4OXZDKzdSRTBTV1ZkdW40Y1RSV0NqQk0xbklZN0RUOUlF?= =?utf-8?B?a1RuSGNqOWoyTS95ZENtRnovWktKNmxvK1ZuNDdodTVaUmJEWXQ4M01ONWt4?= =?utf-8?B?NkNZdDVnZkNmaGpaM3VlMmRyU0lFcDZnTGFEU1ZGSDBNRWNxbCtydTAySGoy?= =?utf-8?B?SUdLZEJiWHdXLzFiajhjVjdGeUdWQlBLRFlCQ05QTUJ1VHBzR2JUMFpTb1lt?= =?utf-8?B?OG5xU0ZVZFJKYlMwQzIyRmUyY1NwQWFGYnB2aUY3VnU5YTRiRk4wb050T0dZ?= =?utf-8?B?N3RQbGhhTVZQY1g5clFNWWpVaythdTBjb09DNUlOeURnVytiT3l1SWZIMUNS?= =?utf-8?B?ekJTc0x5ZE96aVZvKzNiT2RFVlZxandYUGFYOEJvVk51VVhSazRtbmVzV05L?= =?utf-8?B?Rm9YUnJNdjNFRmNkTUhZUjFhb1BhUnlONEFFQWVLV0xacXFQQTZNUjNzQzZH?= =?utf-8?B?YlEwR1Ewc0tTK0ozcWhNUTZ3TlA1cVVRaGVyc1ROdzI2VlpwdUZPbkhkWmNT?= =?utf-8?B?bFMrYnJOREU3OE11dmZHUm0zVXlldTNjSEpsM2sweXhKZmIySW85L0gyL3lN?= =?utf-8?Q?0jKp7MMmBqVB0LYCi2WhMWNZi?= Content-Type: text/plain; charset="utf-8" Content-ID: <01095F175B638844948B13F9EA93ABB0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d4ac924-fca2-4958-5015-08da65cb06e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 18:59:49.4426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PaE5EKZi+sPlqZfgZdk2j/x0NQPBH21aNOQb0vx/zdJsD8Y+4umW52UA1UUjER8KNTN1pMTEY4xqEuHcqkje8+IawyFmsqg3KqK6WWbBUIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5875 T24gMTQvMDcvMjAyMiAxNjoxMiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMTQvMDcvMjAy MiAxNTozOSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+PiBjaGVjay1lbmRici5zaCB3b3JrcyB3 ZWxsIHdpdGggZ2F3aywgYnV0IGZhaWxzIHdpdGggbWF3ay4gVGhlIHByb2R1Y2VkDQo+PiAkQUxM IGZpbGUgaXMgc21hbGxlciwgaXQgaXMgbWlzc2luZyAweCR2bWFfbG8gb24gZXZlcnkgbGluZS4g T24gbWF3aywNCj4+IGludCgweDJBKSBqdXN0IHByb2R1Y2UgMCwgaW5zdGVhZCBvZiB0aGUgZXhw ZWN0ZWQgdmFsdWUuDQo+Pg0KPj4gVGhlIHVzZSBvZiBoZXhhZGVjaW1hbC1jb25zdGFudCBpbiBh d2sgaXMgYW4gb3B0aW9uYWwgcGFydCBvZiB0aGUNCj4+IHBvc2l4IHNwZWMsIGFuZCBtYXdrIGRv ZXNuJ3Qgc2VlbXMgdG8gaW1wbGVtZW50ZWQuDQo+Pg0KPj4gVGhlcmUgaXMgYSB3YXkgdG8gY29u dmVydCBhbiBoZXhhZGVjaW1hbCB0byBhIG51bWJlciBiZSBwdXR0aW5nIGl0IGluDQo+PiBhIHN0 cmluZywgYW5kIGF3ayBhcyBJIHVuZGVyc3RhbmQgaXMgc3VwcG9zZWQgdG8gdXNlIHN0cnRvZCgp IHRvDQo+PiBjb252ZXJ0IHRoZSBzdHJpbmcgdG8gYSBudW1iZXIgd2hlbiBuZWVkZWQuIFRoZSBl eHByZXNzaW9uDQo+PiAnaW50KCIweDE1IikgKyAyMScgd291bGQgcHJvZHVjZSB0aGUgZXhwZWN0 ZWQgdmFsdWUgaW4gYG1hd2tgIGJ1dCBub3cNCj4+IGBnYXdrYCB3b24ndCBjb252ZXJ0IHRoZSBz dHJpbmcgdG8gYSBudW1iZXIgdW5sZXNzIHdlIHVzZSB0aGUgb3B0aW9uDQo+PiAiLS1ub24tZGVj aW1hbC1kYXRhIi4NCj4+DQo+PiBTbyBsZXQncyBjb252ZXJ0IHRoZSBoZXhhZGVjaW1hbCBudW1i ZXIgYmVmb3JlIHVzaW5nIGl0IGluIHRoZSBhd2sNCj4+IHNjcmlwdC4gVGhlIHNoZWxsIGFzIG5v IGlzc3VlIHdpdGggZGVhbGluZyB3aXRoIGhleGFkZWNpbWFsLWNvbnN0YW50DQo+PiBzbyB3ZSds bCBzaW1wbHkgdXNlIHRoZSBleHByZXNzaW9uICIkKCggMHgxNSApKSIgdG8gY29udmVydCB0aGUg dmFsdWUNCj4+IGJlZm9yZSB1c2luZyBpdCBpbiBhd2suDQo+Pg0KPj4gRml4ZXM6IDRkMDM3NDI1 ZGMgKCJ4ODY6IEJ1aWxkIGNoZWNrIGZvciBlbWJlZGRlZCBlbmRicjY0IGluc3RydWN0aW9ucyIp DQo+PiBSZXBvcnRlZC1ieTogTHVjYSBGYW5jZWxsdSA8THVjYS5GYW5jZWxsdUBhcm0uY29tPg0K Pj4gUmVwb3J0ZWQtYnk6IE1hdGhpZXUgVGFycmFsIDxtYXRoaWV1LnRhcnJhbEBwcm90b25tYWls LmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBj aXRyaXguY29tPg0KPiBUaGFua3MgZm9yIGRvaW5nIHRoaXMuwqAgWW91IGJlYXQgbWUgdG8gaXQu DQo+DQo+IE9uIHBvbGljeSBmaXJzdCwgd2UgaGF2ZSBodHRwczovL2dpdGxhYi5jb20veGVuLXBy b2plY3QveGVuLy0vaXNzdWVzLzI2DQo+IG9wZW4gZm9yIHRyYWNraW5nIHRoaXMgYnVnLg0KPg0K PiBXZSBzaG91bGQgY29uc2lkZXIgaGF2aW5nDQo+DQo+IFJlc29sdmVzIHhlbi1wcm9qZWN0L3hl biMyNg0KPg0KPiBpbiBvdXIgbGlzdCBvZiB0YWdzLCBzbyBHaXRsYWIgY2FuIHByb3Blcmx5IGNy b3NzLXJlZmVyZW5jZSB0aGlzIGZpeC7CoA0KPiAoSSB3b25kZXIgaWYgUmVzb2x2ZXM6IHdvcmtz Li4uKQ0KDQpZZXMgaXQgZG9lcy7CoCBHaXRsYWIgc3VjY2Vzc2Z1bGx5IGNyb3NzLXJlZmVyZW5j ZWQgbXkgZGV2IGJyYW5jaCAuLi4NCg0KPg0KPiBodHRwczovL2RvY3MuZ2l0bGFiLmNvbS9lZS91 c2VyL3Byb2plY3QvaXNzdWVzL21hbmFnaW5nX2lzc3Vlcy5odG1sI2Nsb3NpbmctaXNzdWVzLWF1 dG9tYXRpY2FsbHkNCj4gaXMgdGhlIGZ1bGwgbGlzdCBvZiBwYXR0ZXJucyBhdmFpbGFibGUsIGJ1 dCBJIHRoaW5rIHdlIHdhbnQgdG8ga2VlcA0KPiBGaXhlczogZm9yIGl0J3MgY3VycmVudCBtZWFu aW5nLg0KPg0KPg0KPiBJIGFsc28gd2FudCB0byB3YWl0IGZvciB0aGUgcGF0Y2hldyBDSSBydW4g dG8gY29tcGxldGUNCg0KLi4uIHB1c2hlZCBiZWNhdXNlIHBhdGNoZXcgZmFpbGVkIHRvIHBpY2sg dGhlIHNlcmllcyB1cCBmb3Igc29tZSByZWFzb24uDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 14 19:17:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 19:17:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367788.598921 (Exim 4.92) (envelope-from ) id 1oC4Ki-00036b-Nu; Thu, 14 Jul 2022 19:17:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367788.598921; Thu, 14 Jul 2022 19:17:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC4Ki-00036U-KT; Thu, 14 Jul 2022 19:17:08 +0000 Received: by outflank-mailman (input) for mailman id 367788; Thu, 14 Jul 2022 19:17:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC4Kh-00036K-Ok; Thu, 14 Jul 2022 19:17:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC4Kh-0002n0-K9; Thu, 14 Jul 2022 19:17:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC4Kg-00057L-Vr; Thu, 14 Jul 2022 19:17:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC4Kg-0001Ca-VQ; Thu, 14 Jul 2022 19:17:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=agmNfuNcdGb74FU4KEJ/y8zJ3+6xt5q2Z6h3MULbHkw=; b=SmV32+5XvDaA3wGt7BSNnbgHql jxIVXfvNDmv3MhK5cQ6DIuBL6SxiD1ecYV7ucPPuOHosD1MWH9XUkhFZXX9Ntv2w8vWEWzcPj2bED le0glFwQy/baGNC/UvZFw3EM0a+aJIY8lFBG/40hCfEz0iEDnwu9n+v8sGaDBBsV0Mms=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171624: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0ec831fa971d8099e3c4f46093ffb41d044cc10c X-Osstest-Versions-That: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 From: osstest service owner Date: Thu, 14 Jul 2022 19:17:06 +0000 flight 171624 linux-5.4 real [real] flight 171632 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171624/ http://logs.test-lab.xenproject.org/osstest/logs/171632/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 171614 REGR. vs. 171548 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 8 xen-boot fail in 171614 pass in 171624 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 171614 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171548 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 171614 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 171614 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail like 171548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail like 171548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 0ec831fa971d8099e3c4f46093ffb41d044cc10c baseline version: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 Last test of basis 171548 2022-07-07 15:41:19 Z 7 days Testing same since 171600 2022-07-12 14:42:51 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Christoph Lameter Claudiu Beznea Darrick J. Wong David Rientjes David S. Miller Dmitry Osipenko Duoming Zhou Eric Sandeen Florian Fainelli Greg Kroah-Hartman Guenter Roeck Guiling Deng Helge Deller Hsin-Yi Wang Hyeonggon Yoo <42.hyeyoo@gmail.com> Ido Schimmel Jacob Pan Jakub Kicinski Jann Horn Jason A. Donenfeld Jernej Skrabec Jimmy Assarsson Joerg Roedel Jon Hunter Kuniyuki Iwashima Lars-Peter Clausen Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marc Kleine-Budde Miaoqian Lin Michael Ellerman Michael Walle Neil Armstrong Nick Child Oliver Hartkopp Oliver Neukum Paolo Abeni Peter Robinson Peter Ujfalusi Rhett Aultman Rick Lindsley Sabrina Dubroca Sachin Sant Samuel Holland Sasha Levin Satish Nagireddy Shuah Khan Steffen Klassert Vinod Koul Vladimir Oltean Vlastimil Babka Wolfram Sang Yian Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1026 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 20:49:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 20:49:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367804.598932 (Exim 4.92) (envelope-from ) id 1oC5lb-0005s3-8P; Thu, 14 Jul 2022 20:48:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367804.598932; Thu, 14 Jul 2022 20:48:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC5lb-0005rw-5h; Thu, 14 Jul 2022 20:48:59 +0000 Received: by outflank-mailman (input) for mailman id 367804; Thu, 14 Jul 2022 20:48:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC5la-0005rm-5N; Thu, 14 Jul 2022 20:48:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC5la-0004Q4-3N; Thu, 14 Jul 2022 20:48:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC5lZ-0002r2-N2; Thu, 14 Jul 2022 20:48:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC5lZ-0003t9-MY; Thu, 14 Jul 2022 20:48:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=o9FrviQGTQ0MlYlQCxQp9YKckQJodJ9oerW8x6WwAFY=; b=whajZKIGeMtLCX8xD8SviMD1rL pBGpwp/yph+Pb0b9eNnH9Sekgh8tugE8Wie/6yv7TZtuKNUCpUhC55nkBovA8EQCJlUwHo4WFtunB honGAd3NqeR9ewnf/6M97Y1RLt2Xg6+fnemGmmuKyRgywUusxlfAaq+o/gDDSB84AJPA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171633: all pass - PUSHED X-Osstest-Versions-This: ovmf=470206ba7f118aaa1153d66689cf3ee4d17051b7 X-Osstest-Versions-That: ovmf=12dd064a1804536518eb12229836fa572c232502 From: osstest service owner Date: Thu, 14 Jul 2022 20:48:57 +0000 flight 171633 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171633/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 470206ba7f118aaa1153d66689cf3ee4d17051b7 baseline version: ovmf 12dd064a1804536518eb12229836fa572c232502 Last test of basis 171581 2022-07-11 08:42:58 Z 3 days Testing same since 171633 2022-07-14 18:41:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Kuo, Ted Ted Kuo jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 12dd064a18..470206ba7f 470206ba7f118aaa1153d66689cf3ee4d17051b7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 14 22:22:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 22:22:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367821.598943 (Exim 4.92) (envelope-from ) id 1oC7DH-00013C-TT; Thu, 14 Jul 2022 22:21:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367821.598943; Thu, 14 Jul 2022 22:21:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7DH-000135-Qg; Thu, 14 Jul 2022 22:21:39 +0000 Received: by outflank-mailman (input) for mailman id 367821; Thu, 14 Jul 2022 22:21:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7DG-00012v-Vf; Thu, 14 Jul 2022 22:21:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7DG-0005yc-Qe; Thu, 14 Jul 2022 22:21:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7DG-0001C6-Bi; Thu, 14 Jul 2022 22:21:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC7DG-0006yI-BC; Thu, 14 Jul 2022 22:21:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=IjRj5v0c3JekkB3IjU5ePq5xiIMMHdfnP57aqrSxLVM=; b=PMAUli7X3zt7Xd6po3KQiupKr4 CnCuFf85l5OynzkwvBwD31zwDJX2UIT6wpdSNYUuJ34fZ+utdIYLNLqzMPGkr1G7uZ3W/e8pd+8Sn ohejl6UgYNtZj3sQwGqFK2QidHtXBmRS8AfdIWAWDBzfV5N6v21ofyqhruCZyz/XCW00=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171626: regressions - FAIL X-Osstest-Failures: linux-linus:test-arm64-arm64-libvirt-raw:xen-boot:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4a57a8400075bc5287c5c877702c68aeae2a033d X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Thu, 14 Jul 2022 22:21:38 +0000 flight 171626 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171626/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-libvirt-raw 8 xen-boot fail REGR. vs. 171587 build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 4a57a8400075bc5287c5c877702c68aeae2a033d baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 2 days Failing since 171601 2022-07-12 16:11:30 Z 2 days 3 attempts Testing same since 171626 2022-07-14 04:37:44 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alexandre Chartre Alyssa Rosenzweig Andrew Cooper Ansgar Lößer Ansgar Lößer Borislav Petkov Christian Brauner (Microsoft) Christian Brauner Christian König Daniele Ceraolo Spurio Dave Airlie Dave Chinner Dave Hansen Dmitry Osipenko Douglas Anderson Evan Quan Ezequiel Garcia Hangyu Hua Hans de Goede Heiko Stuebner Javier Martinez Canillas Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Kim Phillips Konrad Rzeszutek Wilk Li kunyu Linus Torvalds Liu Ying Masami Hiramatsu (Google) Maxime Ripard Miklos Szeredi Neil Armstrong Nick Desaulniers Nirmoy Das Pawan Gupta Peter Zijlstra (Intel) Peter Zijlstra Rodrigo Vivi Sascha Hauer Steven Price Steven Rostedt (Google) sunliming Tejun Heo Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Zimmermann Tiezhu Yang xinhui pan Zheng Yejian jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 2264 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 14 22:33:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 22:33:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367831.598954 (Exim 4.92) (envelope-from ) id 1oC7Ou-0002tP-5K; Thu, 14 Jul 2022 22:33:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367831.598954; Thu, 14 Jul 2022 22:33:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7Ou-0002tI-1E; Thu, 14 Jul 2022 22:33:40 +0000 Received: by outflank-mailman (input) for mailman id 367831; Thu, 14 Jul 2022 22:33:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7Os-0002tC-JP for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 22:33:38 +0000 Received: from sonic306-21.consmr.mail.gq1.yahoo.com (sonic306-21.consmr.mail.gq1.yahoo.com [98.137.68.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fdce5e42-03c4-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 00:33:35 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Thu, 14 Jul 2022 22:33:31 +0000 Received: by hermes--production-ne1-7864dcfd54-q5j27 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 97517d2a66b128664f6173582b24cba9; Thu, 14 Jul 2022 22:33:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fdce5e42-03c4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657838011; bh=QXJxK9uRHPgeJRYwYqRfbGAEL0vbJkn+fNS92crcabw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=SrT8orGXGXfdlnw18KfQ6xiDEMi1bWINravl/lGmRyFYTsbGoBPJSb5FLtNWlDqfID1gVSPFqe84lzpKmUtt00FK+IhmjIHXGXSi0LkKW0ZAj3+IXQf78uSQPajb80E9OBIxyB/e47VbMHx6nU3SupOwWxtsJevwoyTU8Q+gR4OE3ic97VP8WSuR7/0+Jp7q5SEG82NQHL4I8Cu4wfrE7R9/2/r0gtWCMpOf5W8segQhYm/KMpxjxo6ZWIeogSKFVOmupwHi55+Uph1cMOnhaIUS5bL47ik5htW0Wz0YCj81+ANo/J3yQup5SZ0UNr5843QvkLoT5/Z2dkEG7xKn0A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657838011; bh=5EH6pEyDHX14H2TfJ4h1fCsU95bY0bgSM0NUqADtoMo=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=anMbBvXEVzp1zpYaTS+WzCGGdkS3ySaGB/nmk72ujHZywg8Abul9wnx8Nxw8APiFMEBi8HofXG3bY4Z9RqxTLkeW81CTOkJ737hidIp8DVYeYPkff+0SnLCq9r4P8ah5bqYcqm/WJKCIH3aAgcOT5AEnnUiO44NWiN+7MndwU6sJdPWjzoAIlx85fpDfvfPv2LLNxIdCP/kmax3EWwV9x5GvC4GjpmKNucePsNe2QQqbkLWNnUuHs0E4fF5etDB3MFFJwtLHfNnlGrAEBBhRh9PuJ0UpIUfRTvGVbOaE3Cb2FhBHDptbj14nsnD6fFQtuOcXHzUoRzsuxB1E4WIQeQ== X-YMail-OSG: 7LiRrc0VM1mpINPlx9OtkbZVhtIdlEu.6jc1MF2_AlHiYGU0IvI5LM8aIsRrE4U dZA3WYXohky5mb.HQ6NPcyk8dnsqQRbpe_Uj2eiMJmyGznOZenH7LyFDNUpVRuNEbFPA5MiDn1JY NUCfYQP.isyvQk_sYaH.oN.ce1r2v5uoMGBfByQqpXFtNacsVBBzqaM3bOGXoF.YE8P_HWdjWt5O VnWL26UMHwP_sgTU6t1Xh56sfcBRzdlgDl7zE2.eLia5ujeqg92UK.BmBZufttMz2mnPuzOJx3PS 5HsEIWLGOEA.GahB.pV8aB9FRPWhBJufsSxop6pUBIeeVqt7jAP94pyRVNYv58Q3CRVAs9722AT2 VpnEjTc2FkwKecdBf04k9bg_rnps7jWMDdAoMbKjp7xmSQdKPYRYwOwneLa3XxiKHem.AC1cPQa4 sIC4d6h.5rc6aejrnp7dOHzLBoLiYPPII9JOSRp30AMEAs89BIBJh6uYDNQ7NI1JkDp_U71cfUQ4 c6s6wH6tMjdA7UomXWZfG7chxnvVBwUdSt95DWUp1roNJ9gT6WXVCwwWW6VCm.8p8QWZULOCsCQa ekqYeF.eqFbTRH8xTAaaSpeK797v7H.Sjwi8J6nsMyZIKtAWsVO7VntlP9t1G7_lQ.Nq52UeieCp 0lb09R6k.EzeevL9amiE4itDq35YjL71VYdvwJHQzJH0lMlpqK39vNftIKkRVLeZDv53jqhZz9pB F4fBBRH_BZk.u79YrPUeiVpnoR3hqhtLCit6JiewR3mAwS_5.cd_bTc5K59ZgbPPTWw9mmz6YT5q hR77zAuvfVDYf1WkAa4zVN86MBgNN9tl2UDhlnAKfkPwxz.5eL6r4TSe.ViigS8MMKamJaCoqvDh hge8PrOSbtQbyDieAQV.TLUBLv0kSdUoE.DRkSW1v.sbxNMoYtIE0UGRydeDtgJCPPWGG7yZt0yZ Y0VRcD.i8mER_ZLyvDx8m0RAvAnIBuGMrgKDJDNFCrvkTv9Q4HX4sluYFkHgONKpE0M5b8jj7szP xq_CmFuEHX_4Ip3WloXAHR8mI4qmZvvKVieh0k8eDcYZhE48._Ri.u.bFwokKpLX4IntLpz2hg5_ 4Ese1tgx1CrWI4qqRWlP.b_hiR1rfjOUU0eK0YzIeNGW48nGeRzRVeUI9SD06s9WKiqyV0pKD4Ce E0kDss17PM8OJGFdVzxKFl0WFjK5PAEBiMXokDnytF9Dmyn5tEK7tyTtVCSQFpHgxiRUDVnWcFH1 JyOU7vMxVQJ9rBq6omrhI62kWoIgziIFzI1L08NyT_RJ_qvbq.JTeTp7g4hbBMoUoULHz0YsRLCw I5XTyPmrtelZRvXAlpKQDo_UrlT7Rm6Uq7gz0ZwvdMxL1fG2fMG.wEgnKYPd.7RmF5Crun2Pzqls poNalRcNlM7dvoRSpwfsZke2EHZzW0T4v3IPObjeW_nzQXlpCJog8LDfJIGrQYCKX1PDEBdtgf3O Pr2pqHNXprkwnugK9S1BZDSQNN1j090_ExqdZvVEK8ut4tv3zJxRPC3jssR0FspbDJYlsBMolXUs YLcIcG7pUCM1lyF1Yq2ZG2smQykkjdVMi_dYZG0488TXPflOlvdy4g7Dn6IiN1RiIPqyhxfpMuHU QCvF6OzK_uisToqLAtCDsShqt4NflKLv6arQFcGkYm2QLb1N6_vlM8IYbtWVNIZnPAR4s8hiXFXg u3D.b9R.LEsXy65AMvv_sQ2ZkIkSbLAi_sDOwnENgUdJC6MIqrQ1oX2JGGaRm6oGtXLhsw2pMAxk aVCdp4eUsjEbmNGTqWCblmHWZwkwEH1pND7PdPzHWvmNtE3R4r1dAPL.lTn54SoscY5UNsUzDG4Q gnCqwMqHwMdPyBjYHUgjU6YtZ4oGcmRlsxgtOdU7_yg.rCjpX6BeJiiYlERcDzL0glxM0_G..BKK mgemFArKIq.9CD1rOBb9mpN.rklqSfJ01HbiZgr0amafF2rCI2VB3DMG.IPxQP20pL3U1bpRfh2z javnaR9dbAqlDUOD2YaGoCRHozthmk115.9NueZYuK9h2DeOiqJECug12FygH1UiJgWOE_0c_kpB 76wDsk.ppOgEvDqCK85s8BJkWGeUs0J4FBPqCNjO_YW2VBVFja2bRJKdz8TiHhYNTXJV3mhDRPtZ tTdL_iWD3WicNXZkwKy1q_pkcGAnNOt3fg_8N9npv7yfO2c7vOmjmaPnyZujPoXHoid4Jy6oJwki uQSc90ySOEP6uZqnuWkPFiQ6U X-Sonic-MF: Message-ID: <1a486b6d-037e-ac54-4279-286b4ae9452e@netscape.net> Date: Thu, 14 Jul 2022 18:33:23 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US From: Chuck Zmudzinski To: Thorsten Leemhuis , Jan Beulich Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6446 On 7/14/2022 1:17 PM, Chuck Zmudzinski wrote: > On 7/5/22 6:57 AM, Thorsten Leemhuis wrote: > > [CCing tglx, mingo, Boris and Juergen] > > > > On 04.07.22 14:26, Jan Beulich wrote: > > > On 04.07.2022 13:58, Thorsten Leemhuis wrote: > > >> On 25.05.22 10:55, Jan Beulich wrote: > > >>> On 28.04.2022 16:50, Jan Beulich wrote: > > >>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > > >>>> with pat_enabled()") pat_enabled() returning false (because of PAT > > >>>> initialization being suppressed in the absence of MTRRs being announced > > >>>> to be available) has become a problem: The i915 driver now fails to > > >>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I > > >>>> located the induced failure), and its error handling is flaky enough to > > >>>> (at least sometimes) result in a hung system. > > >>>> > > >>>> Yet even beyond that problem the keying of the use of WC mappings to > > >>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > > >>>> graphics frame buffer accesses would have been quite a bit less > > >>>> performant than possible. > > >>>> > > >>>> Arrange for the function to return true in such environments, without > > >>>> undermining the rest of PAT MSR management logic considering PAT to be > > >>>> disabled: Specifically, no writes to the PAT MSR should occur. > > >>>> > > >>>> For the new boolean to live in .init.data, init_cache_modes() also needs > > >>>> moving to .init.text (where it could/should have lived already before). > > >>>> > > >>>> Signed-off-by: Jan Beulich > > >>> > > >>> The Linux kernel regression tracker is pestering me because things are > > >>> taking so long (effectively quoting him), and alternative proposals > > >>> made so far look to have more severe downsides. > > >> > > >> Has any progress been made with this patch? It afaics is meant to fix > > >> this regression, which ideally should have been fixed weeks ago (btw: > > >> adding a "Link:" tag pointing to it would be good): > > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > >> > > >> According to Juergen it's still needed: > > >> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > >> > > >> Or was a different solution found to fix that regression? > > > > > > No progress and no alternatives I'm aware of. > > > > Getting closer to the point where I need to bring this to Linus > > attention. I hope this mail can help avoiding this. > > > > Jan, I didn't follow this closely, but do you have any idea why Dave, > > Luto, and Peter are ignoring this? Is reverting bdd8b6c98239 a option to > > get the regression fixed? Would a repost maybe help getting this rolling > > again? > > Hi, Thorsten, > > Here is a link to the hardware probe of my system which exhibits > a system hang before fully booting with bdd8b6c98239. Without > bdd8b6c98239, the problem is gone: > > https://linux-hardware.org/?probe=32e615b538 > > Keep in mind this problem is not seen with bdd8b6c98239 > on the bare metal, but only when running as a traditional Dom0 > PV type guest on Xen. I don't know see the problem on Xen HVM > DomU, and I have not tested it on Xen PVH DomU, Xen PV DomU, > or the experimental Xen PVH Dom0. Update: On affected hardware, you do not need to run in a Xen PV Dom0 to see the regression caused by bdd8b6c98239. All you need to do is run, on the bare metal, on the affected hardware, with the Linux kernel nopat boot option. Jan mentions in his commit message the function in the i915 driver that was touched by bdd8b6c98239 and that causes this regression. That is, any Intel IGD that needs to execute the function that Jan mentions in the commit message of his proposed patch when the i915 driver is setting up the graphics engine will most likely be hardware that is affected. My Intel IGD was marketed as HD Graphics 4600, I think. So find an a system with these hardware characteristics, and try running, with the nopat option, the Linux kernel, with and without bdd8b6c98239. You will see the regression I am experiencing, I predict. Chuck > > You can probably verify yourself that reverting bdd8b6c98239 > fixes the regression if you try to reproduce the regression with > any Linux version that has bdd8b6c98239 or its equivalent on > the stable branches with a hardware profile similar to the link > to the profile of my machine which exhibits the problem. Mine > is a Haswell core-i5 4590S CPU and ASRock B85M-Pro4 > motherboard. > > Also, other notes: > > 1. Yes, AFAICT, Marek at Qubes OS is the first to report the problem. > 2. Juergen Gross' work to try to fix this has been helpful, but none > of his posted patches has fixed the regression on my system. > 3. Jan's patch fixes it also, and so do the two patches I posted to lkml > earlier this week to the appropriate maintainers. > 4. On the pkg-xen-devel mailing list, which is public, this issue was > briefly discussed where I first reported it. Someone there said they > did not see the issue with Broadwell Xeons. Mine is a Haswell core i5, > which is one generation older than Broadwell, so you are most likely > to be able to reproduce the problem with a Haswell core i5 desktop > system like my ASRock system, which was my own private build > which has been working fine for eight years until Linux 5.17.y. > > Hope this helps. > > Chuck > > > BTW, for anyone new to this, Jan's patch afaics is supposed to fix the > > regression reported here: > > https://lore.kernel.org/all/YnHK1Z3o99eMXsVK@mail-itl/ > > > > Side note: Juergen Gross recently posted related patches in this code > > area to fix some other problems (regressions?), but his efforts look > > stalled, too: > > https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ > > > > And he recently stated this Jan's patch is still needed, even if his > > changes make it in. > > https://lore.kernel.org/all/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > > > This from my point all looks a bit... unsatisfying. :-/ > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > > reports and sometimes miss something important when writing mails like > > this. If that's the case here, don't hesitate to tell me in a public > > reply, it's in everyone's interest to set the public record straight. > From xen-devel-bounces@lists.xenproject.org Thu Jul 14 22:44:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 22:44:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367838.598965 (Exim 4.92) (envelope-from ) id 1oC7ZG-0004dR-4A; Thu, 14 Jul 2022 22:44:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367838.598965; Thu, 14 Jul 2022 22:44:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7ZG-0004dK-1M; Thu, 14 Jul 2022 22:44:22 +0000 Received: by outflank-mailman (input) for mailman id 367838; Thu, 14 Jul 2022 22:44:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7ZE-0004dE-33 for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 22:44:20 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7de4abd2-03c6-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 00:44:18 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3D36EB829DA; Thu, 14 Jul 2022 22:44:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EDE5DC34114; Thu, 14 Jul 2022 22:44:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7de4abd2-03c6-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657838654; bh=ZTNaD7TTclpn13DZH9gmDu/kVHAK0vU6nq05MFNP/OI=; h=From:To:Cc:Subject:Date:From; b=OeQS1awqXop0peSKh0A2dyghSIgn/D6oI+ww24QPmvMecatn8NjCA7FnNbTxEA1a/ jFfq/8eoAnF4reSH3Zx5kRBPZtq+YrIOM8HKBzJObtP2Ce3WAxlCRQiGY63uEN5Hen DXyg1enx4YljQAw7SN2WDuLqa7+SvA0Tirs62KT5LpVuYOAhBNesaRbael/3jB9R3e Ipu0Z9Ok3f1qtPoAtUizrTvfyKyZgfT1XWtlp8dlj7SLkFReNxP74nx3isQPvw2C6h h0ATw8BT5o2FV9ZpvVEjQMzburXRmJx+x+EICrJ/Hog1ZVlmG8L60Q+0d9vLU8VYyC PbhWXmyYeRo0w== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, SeongJae Park , stable@vger.kernel.org Subject: [PATCH v2] xen-blkback: fix persistent grants negotiation Date: Thu, 14 Jul 2022 22:44:10 +0000 Message-Id: <20220714224410.51147-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Persistent grants feature can be used only when both backend and the frontend supports the feature. The feature was always supported by 'blkback', but commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") has introduced a parameter for disabling it runtime. To avoid the parameter be updated while being used by 'blkback', the commit caches the parameter into 'vbd->feature_gnt_persistent' in 'xen_vbd_create()', and then check if the guest also supports the feature and finally updates the field in 'connect_ring()'. However, 'connect_ring()' could be called before 'xen_vbd_create()', so later execution of 'xen_vbd_create()' can wrongly overwrite 'true' to 'vbd->feature_gnt_persistent'. As a result, 'blkback' could try to use 'persistent grants' feature even if the guest doesn't support the feature. This commit fixes the issue by moving the parameter value caching to 'xen_blkif_alloc()', which allocates the 'blkif'. Because the struct embeds 'vbd' object, which will be used by 'connect_ring()' later, this should be called before 'connect_ring()' and therefore this should be the right and safe place to do the caching. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximilian Heyne Signed-off-by: SeongJae Park --- Changes from v1[1] - Avoid the behavioral change[2] - Rebase on latest xen/tip/linux-next - Re-work by SeongJae Park - Cc stable@ [1] https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/ [2] https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/ drivers/block/xen-blkback/xenbus.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 97de13b14175..16c6785d260c 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -157,6 +157,11 @@ static int xen_blkif_alloc_rings(struct xen_blkif *blkif) return 0; } +/* Enable the persistent grants feature. */ +static bool feature_persistent = true; +module_param(feature_persistent, bool, 0644); +MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature"); + static struct xen_blkif *xen_blkif_alloc(domid_t domid) { struct xen_blkif *blkif; @@ -181,6 +186,8 @@ static struct xen_blkif *xen_blkif_alloc(domid_t domid) __module_get(THIS_MODULE); INIT_WORK(&blkif->free_work, xen_blkif_deferred_free); + blkif->vbd.feature_gnt_persistent = feature_persistent; + return blkif; } @@ -472,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd) vbd->bdev = NULL; } -/* Enable the persistent grants feature. */ -static bool feature_persistent = true; -module_param(feature_persistent, bool, 0644); -MODULE_PARM_DESC(feature_persistent, - "Enables the persistent grants feature"); - static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, unsigned major, unsigned minor, int readonly, int cdrom) @@ -520,8 +521,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, if (bdev_max_secure_erase_sectors(bdev)) vbd->discard_secure = true; - vbd->feature_gnt_persistent = feature_persistent; - pr_debug("Successful creation of handle=%04x (dom=%u)\n", handle, blkif->domid); return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 14 22:45:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 14 Jul 2022 22:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367844.598976 (Exim 4.92) (envelope-from ) id 1oC7aG-0005Ax-Eg; Thu, 14 Jul 2022 22:45:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367844.598976; Thu, 14 Jul 2022 22:45:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7aG-0005Aq-BA; Thu, 14 Jul 2022 22:45:24 +0000 Received: by outflank-mailman (input) for mailman id 367844; Thu, 14 Jul 2022 22:45:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC7aE-0005Aa-8w for xen-devel@lists.xenproject.org; Thu, 14 Jul 2022 22:45:22 +0000 Received: from sonic309-21.consmr.mail.gq1.yahoo.com (sonic309-21.consmr.mail.gq1.yahoo.com [98.137.65.147]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a241c81a-03c6-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 00:45:20 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Thu, 14 Jul 2022 22:45:17 +0000 Received: by hermes--production-ne1-7864dcfd54-s2f4b (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5c27b74b8dd2814fc3bb62f87e7a5d5a; Thu, 14 Jul 2022 22:45:13 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a241c81a-03c6-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657838717; bh=82dHPxHVfQ14eG1W2sdvtK1J1D0zijc4Oov2w7XaO/I=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=h92Ne8t1w+CKrsgxM/GEldeMguYF4gOCATEwiq4hhPUWK1IIU02YW5EgSVHQWKJdAwxi/aYWqmY5Plo3MpYgsylVqdOmfy5fgLcvCg1dXiCVOkh7P5IqJGrfxqjnsDD+MyeQQocvIsDnvPXNSoSnsAh0a4x+JpygGwH9uAf4XBbkgGIu7CnE56iX9fRCTF4Sob+DVUbqRjONw1RCp4LFDRVwkj2RrhTWANClwYP0kUJOfKW16flygeLUFou9woXqX6ZkovL5JhoEHHyXaXYUwreY0s32FptY2eTtBq6VC8qVoLy69zH+RDTwFSKQZqV7i6a9tlQus/jONykPhSrVPw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657838717; bh=TmBkStm0hBJ24ECMc/C3uaRtfT+qmAuIvDZZGQOe1ZS=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=XgMLdzxJKNCqLNlErV2aAgQ7rSWVE+G+1OPT2qpcPEcVCG0YihTh7K5mALean9d1KHKv5Z7BTyWyGoTQ1bSMDulCvEzmdlyjN5s1EdSD4APl0Zv8dR4KvTxyGggdveLxbHdSo4nDMy0pULu353+oFxE4ZCSqiStlj3Lga/vh3r45wwhZpQRschn30UjxQAS1/CJQd9bhG7rEk3gZOuwOsONV8V4aTUiF+5qTKdCwmifmnBUyjIhBNv8/Zdj58Ius0RXmxtgIeJD3N1VaPP9J+CSRVdl8/waT+WvnSKPiiBGQSNyZK3KT/zA+CLEirGXSwEKwSz3Gozjx9ln4iYKsLA== X-YMail-OSG: Pzotum8VM1leh.sKkXQqcF1UiNJUYee6HDwjc0lyFFlu1O73oiWf1Nv..QzGrDj 8AgRtCbiOcgoR3ypZEpyjkoVRmyu.D0aqA4FxIptgcip82L2wX9R7SWIKhOw2VQMCK8q1lpg.Utk mup3IRC9.IWYmAm.SV6TvOL_635OkocO.czf174XV8i8bxFtPj2DqICEk2Za4iFcKlaI2Jgcnspq sRddyMNsrRf2zt_5vVk8hZnMs2n2c_.EiR9D8cFiAEZf8cBYnKuMxmuDyInzPYJx8ux6_YU7vq9q 0UIxoJlkbOgUpOZJvB.03eYWgKWkMiyZwTfelUqANBX7H5JYmkenDGE8SiQNbsHWVbBCbiy7omfd 1SdqkAgEjJ5tWMNURCCFOl7peZSBLpXe67.WEkM0NefsUYX72yw_R5oXv67eqGOvt45H50n5NiT9 6o6CxwDH3NVkGeGZa6ztsD5MHaDO_HmZMbsoaZKi0lzU3u691DBlceSD__rC11MoEQKf7ttK3F6y SBJaZg4mzaoLSHp9FJDmPJXufkWrFWYZOmdZZGpKylGF.zkSFF6xWbpyNu9Hek7.ZTU8yTBUUaP9 i9d.UsQxSC7SIFCuOys.8CdXvahJ4p2xu2F1k07tjDqewjqPgzvfKoBtS_F1TDcRfALTDiYBdA.M fvFEgAGsz.FSst1t98T4clG6RaJSnn.df3ft82MVIYNVY8zeSxZkuPeHpfsEXttJhuALVpguxGqP f3E.Fue8sQZlhpH8uXL8jGTjEYWN5DV4AhC504wGRddvo9OqCPjcvA7ZYAOt5kicjq4mINbPpK7U yu62ltUDPXZIWVMTIPMROY4wMiPDnTSgi37lPAaa4Vv3iaq3T24gvoi6EyplaEFQB13Mh7rzg9Op h_qefxvmm1a_TybxTfTi1i6dcLgerzjUBObUSojtSBpXO90fBuawGSuZNKoUiZsEPuKdrbrurBz6 wkhSvnyL27Jg.enLc_7mxI7mbm0JG_Qc4wNpStfdobc.Ftn9R7aOcmQi38MCx9jTEnfHLrAxFVTH sJ8F99TUAcfcui2gdHfAJqzCwsynr4Q_72zM8A6i_kzwngS3Gi6YCMb7l3rmTi2XSCznynL44g9D 01RoKO6CnyeCOrPwONV.uIbuc7c7O_bdjF3WPKm_Pf_w6fcAehQi3fecVjmvUkEDF7OB3RT3yqGR N5yNc8e9mUdrXXrZKSnokaaLl0Llas5isSfUrtr4AGAry10G1bv2.NOFSjFhBHcWalaN8OiBC_JN A_DlERt0on2T06FXNEM0TR34.b46VzP.oy3e0rJvY07ZJ9leaaSrSd22AbP7JHGwnNKDyphsRCIF Tk61tHlOsuYMBrbxD2UWFzELnjcSCf4167n5zvN2HsPTTjveeaX.cwwCh0aiMIAkxZ6TNGLAgjWn CzNnoVqGFzqFzIg6qGhzq8Z4C6tS_h6e39hFovDsl1osqz7GpjQNbPn3bqHs31uXYFQeUPmSEnr4 .SLCpfWjHPCMd9ryDT1iOpHzxAZG9_.yiSTf0h4d5Aj5QOGsoFGZbL9SN67FkBd85RW_i7is_BEj 5cZaH7xPNIqb5BTDnJzD_AjA30Lvoc.f84zO8TXQDGP4nUZJzuYxT9Qxj0ZtV2ReM.D3Dvl8soT4 WYk.xgG8xzGg5rbPzDg2u9aPg2TvIRU2KgON3IoHoIAka8rGbhEOBbHzI6kod7emcFrFf78bdKkP kvyHu7bhhrlN7PhKQStnDnxD8AXPQsM1IUfzm1a4vRH4yd0ZfkfovrB1LaTVcSO0t_kZGgRPO1m8 2IqvvhL2Z64L4Xs737Rt46hngIek_dYKu1j73j_FavfjLUtLL_EIC66aukpUz2YcNkrJ_pX5gJkP FG26j1PDGqApGWiLvW9MsPgwEZe0bi9DidQadC4xl7LgoWjVh9TaRmUXReChwTBmaCW9FleL558O 81mZa2ynfnStlgpR66sDUl1oMBsljgwXqkfkrjZDRWPfzXWU.rws- X-Sonic-MF: Message-ID: Date: Thu, 14 Jul 2022 18:45:11 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US From: Chuck Zmudzinski To: Thorsten Leemhuis , Jan Beulich Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> <1a486b6d-037e-ac54-4279-286b4ae9452e@netscape.net> In-Reply-To: <1a486b6d-037e-ac54-4279-286b4ae9452e@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7310 On 7/14/2022 6:33 PM, Chuck Zmudzinski wrote: > On 7/14/2022 1:17 PM, Chuck Zmudzinski wrote: > > On 7/5/22 6:57 AM, Thorsten Leemhuis wrote: > > > [CCing tglx, mingo, Boris and Juergen] > > > > > > On 04.07.22 14:26, Jan Beulich wrote: > > > > On 04.07.2022 13:58, Thorsten Leemhuis wrote: > > > >> On 25.05.22 10:55, Jan Beulich wrote: > > > >>> On 28.04.2022 16:50, Jan Beulich wrote: > > > >>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > > > >>>> with pat_enabled()") pat_enabled() returning false (because of PAT > > > >>>> initialization being suppressed in the absence of MTRRs being announced > > > >>>> to be available) has become a problem: The i915 driver now fails to > > > >>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I > > > >>>> located the induced failure), and its error handling is flaky enough to > > > >>>> (at least sometimes) result in a hung system. > > > >>>> > > > >>>> Yet even beyond that problem the keying of the use of WC mappings to > > > >>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > > > >>>> graphics frame buffer accesses would have been quite a bit less > > > >>>> performant than possible. > > > >>>> > > > >>>> Arrange for the function to return true in such environments, without > > > >>>> undermining the rest of PAT MSR management logic considering PAT to be > > > >>>> disabled: Specifically, no writes to the PAT MSR should occur. > > > >>>> > > > >>>> For the new boolean to live in .init.data, init_cache_modes() also needs > > > >>>> moving to .init.text (where it could/should have lived already before). > > > >>>> > > > >>>> Signed-off-by: Jan Beulich > > > >>> > > > >>> The Linux kernel regression tracker is pestering me because things are > > > >>> taking so long (effectively quoting him), and alternative proposals > > > >>> made so far look to have more severe downsides. > > > >> > > > >> Has any progress been made with this patch? It afaics is meant to fix > > > >> this regression, which ideally should have been fixed weeks ago (btw: > > > >> adding a "Link:" tag pointing to it would be good): > > > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > > >> > > > >> According to Juergen it's still needed: > > > >> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > > >> > > > >> Or was a different solution found to fix that regression? > > > > > > > > No progress and no alternatives I'm aware of. > > > > > > Getting closer to the point where I need to bring this to Linus > > > attention. I hope this mail can help avoiding this. > > > > > > Jan, I didn't follow this closely, but do you have any idea why Dave, > > > Luto, and Peter are ignoring this? Is reverting bdd8b6c98239 a option to > > > get the regression fixed? Would a repost maybe help getting this rolling > > > again? > > > > Hi, Thorsten, > > > > Here is a link to the hardware probe of my system which exhibits > > a system hang before fully booting with bdd8b6c98239. Without > > bdd8b6c98239, the problem is gone: > > > > https://linux-hardware.org/?probe=32e615b538 > > > > Keep in mind this problem is not seen with bdd8b6c98239 > > on the bare metal, but only when running as a traditional Dom0 > > PV type guest on Xen. I don't know see the problem on Xen HVM > > DomU, and I have not tested it on Xen PVH DomU, Xen PV DomU, > > or the experimental Xen PVH Dom0. > > Update: On affected hardware, you do not need to run in a > Xen PV Dom0 to see the regression caused by bdd8b6c98239. > > All you need to do is run, on the bare metal, on the affected > hardware, with the Linux kernel nopat boot option. > > Jan mentions in his commit message the function in the i915 > driver that was touched by bdd8b6c98239 and that causes this > regression. That is, any Intel IGD that needs to execute the > function that Jan mentions in the commit message of his > proposed patch when the i915 driver is setting up the graphics > engine will most likely be hardware that is affected. My Intel > IGD was marketed as HD Graphics 4600, I think. > > So find an a system with these hardware characteristics, and > try running, with the nopat option, the Linux kernel, with > and without bdd8b6c98239. You will see the regression I > am experiencing, I predict. This raises a disturbing question: The commit message of bdd8b6c98239 mentions the nopat option. It does not specify what effect the commit was supposed to have on system with the nopat option, but the actual effect on the system, both with the seldom used nopat option and in Xen PV Dom0, a nasty regression on some older Intel IGD devices. My question: Was this intentional? Or just grossly incompetent? Any other possibilities? I think you should definitely notify Linus about this if you can verify the story I am telling here. Chuck > > Chuck > > > > > You can probably verify yourself that reverting bdd8b6c98239 > > fixes the regression if you try to reproduce the regression with > > any Linux version that has bdd8b6c98239 or its equivalent on > > the stable branches with a hardware profile similar to the link > > to the profile of my machine which exhibits the problem. Mine > > is a Haswell core-i5 4590S CPU and ASRock B85M-Pro4 > > motherboard. > > > > Also, other notes: > > > > 1. Yes, AFAICT, Marek at Qubes OS is the first to report the problem. > > 2. Juergen Gross' work to try to fix this has been helpful, but none > > of his posted patches has fixed the regression on my system. > > 3. Jan's patch fixes it also, and so do the two patches I posted to lkml > > earlier this week to the appropriate maintainers. > > 4. On the pkg-xen-devel mailing list, which is public, this issue was > > briefly discussed where I first reported it. Someone there said they > > did not see the issue with Broadwell Xeons. Mine is a Haswell core i5, > > which is one generation older than Broadwell, so you are most likely > > to be able to reproduce the problem with a Haswell core i5 desktop > > system like my ASRock system, which was my own private build > > which has been working fine for eight years until Linux 5.17.y. > > > > Hope this helps. > > > > Chuck > > > > > BTW, for anyone new to this, Jan's patch afaics is supposed to fix the > > > regression reported here: > > > https://lore.kernel.org/all/YnHK1Z3o99eMXsVK@mail-itl/ > > > > > > Side note: Juergen Gross recently posted related patches in this code > > > area to fix some other problems (regressions?), but his efforts look > > > stalled, too: > > > https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ > > > > > > And he recently stated this Jan's patch is still needed, even if his > > > changes make it in. > > > https://lore.kernel.org/all/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > > > > > This from my point all looks a bit... unsatisfying. :-/ > > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > > > > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > > > reports and sometimes miss something important when writing mails like > > > this. If that's the case here, don't hesitate to tell me in a public > > > reply, it's in everyone's interest to set the public record straight. > > > > From xen-devel-bounces@lists.xenproject.org Fri Jul 15 00:22:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 00:22:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367852.598987 (Exim 4.92) (envelope-from ) id 1oC95e-0001Kj-3b; Fri, 15 Jul 2022 00:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367852.598987; Fri, 15 Jul 2022 00:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC95d-0001Kc-Vz; Fri, 15 Jul 2022 00:21:53 +0000 Received: by outflank-mailman (input) for mailman id 367852; Fri, 15 Jul 2022 00:21:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC95c-0001KS-6c; Fri, 15 Jul 2022 00:21:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC95c-0000BR-3J; Fri, 15 Jul 2022 00:21:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oC95b-0006Th-G5; Fri, 15 Jul 2022 00:21:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oC95b-0007jd-FF; Fri, 15 Jul 2022 00:21:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iMfU+1iFLrq1dOQIHEDrwDHj7eoIqw1Wew30V4AP9j8=; b=22/ewymU/nXqgh3JUqPA1ydPeQ CIEAMh0Eb5DrWK8Z4EDtmtOnnAnenq4O2w5saR60m48kkFHWT8651ZnFc1O90hu8ApnmtHd2Rxo9V nPGk1MpciR+FAU+E+F1f8cX+7vpiaD/zFbyxS3uPCW4TenZ3b8H1mzGGMjt4urSP8BSs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171627: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe X-Osstest-Versions-That: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe From: osstest service owner Date: Fri, 15 Jul 2022 00:21:51 +0000 flight 171627 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171627/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 8 xen-boot fail pass in 171619 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 171619 blocked in 171627 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 171619 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171619 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171619 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171619 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171619 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171619 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171619 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171619 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171619 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171619 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171619 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171619 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen d8cb7e0f069e0f106d24941355b59b45a731eabe baseline version: xen d8cb7e0f069e0f106d24941355b59b45a731eabe Last test of basis 171627 2022-07-14 10:25:22 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Jul 15 02:08:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 02:08:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367860.598998 (Exim 4.92) (envelope-from ) id 1oCAkE-0004Ea-Kq; Fri, 15 Jul 2022 02:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367860.598998; Fri, 15 Jul 2022 02:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCAkE-0004ES-Fh; Fri, 15 Jul 2022 02:07:54 +0000 Received: by outflank-mailman (input) for mailman id 367860; Fri, 15 Jul 2022 02:07:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCAkC-0004EM-On for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 02:07:53 +0000 Received: from sonic303-23.consmr.mail.gq1.yahoo.com (sonic303-23.consmr.mail.gq1.yahoo.com [98.137.64.204]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eb5bf858-03e2-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 04:07:48 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 02:07:45 +0000 Received: by hermes--production-ne1-7864dcfd54-8q7fk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 71743821a1d43004a7054548f9d96445; Fri, 15 Jul 2022 02:07:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eb5bf858-03e2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657850865; bh=nzz5QL7S9DLFkCMBr3Jim+Elhx8CrLEWNxNyWEg5v+E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=S1vxLiilifOP+Y+3gVSDu3ocGcLdk3Yl3flRXk6iiZcJTd8jE2f8uPN6E6vSH+yE3Tce0f8vZBUMDDcy86+CjNE6ffihuNFWMFlO+Kza8AJhFBnKIAWdWugB5cMlLhadY4kHFzBaH50rUAojasyh5G4PZhRrglsmypYLwzWGIPK+1BEN1W9DpEXCMG6k4MqEtErZwcpWrEEet7+cym49+mlBI5v8ap03AebS6BWfqpn6/B/zj44Iwi2xzUCuqSFDyOW2fh4dbmEX/rYp1ibPS6PjshJ+yh3glGsAUdayoZV68d15JVMAPN6ameysRjmI0CFvQzumuCm1aOWd7qj1EQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657850865; bh=mBjM5fr05W7yyMdpoeeh4co6EO/zHVVw+ogE46gMJKr=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=QfFDbf0P7TH17MXGL93AmFSC1u+aXl7GlpyPXJDXyjEZSfvMYCZCwjhBptEKK8VSdPZYMlwhNXjJmPGXM5ZvCSrq1VybyE1A5OZMSXt1iQQmyjQyu7jjCthhOGl/vdgxpFf6J1mZVHtp0rn6AHfQxw2i28p4oPSTqXZ0AQ4HBakiEccEZXgPg8yKEyOlgIjjDh+N4+d302CIM0XtMti0zr4ofBkbH4eQQr65gfPfl3LshfNEr7YRyoP6TDaO/OmSkqA4shrtIkaFR4L5Zq6OiuxMBbhY4Igm3xJAlqIr6wn6T3fFGxoJmOF6SDQmSOP/3SlJ6RJStphQD/u+k/5THA== X-YMail-OSG: HvN33AoVM1kCCkC0XcVyGo6GBCiv59acgj3M6hzk2m_M8XCdr5VdEkA__n9uf0e ZxFOV5wtFW51DkgGDy7HIJNs3hcffNgdYFypFExDHWbnZg1EbT0DBtg0.ySt.lGnQFAktP2sSoVr EsQJkXa4A5fXMOz6Lrz3bS71HJ6d0NkXBECp.YyfZnPWAfeMV4a0uUY7LsKNIJcROjiq33QcdJoG 2f.18Ju177hjNmUY4yz1HoYocGH.OZgjYBkSfwUp8xz6nzqU81_TB6GUy0atquF5_bkkXxiMXwC9 a72DorlfDypCGmdTeR6e4bZp55mFtCpxCKY9CwMkqn7U94LCZ0Vp2yxf5mYtTFImF97JgX9xsfs. w_.lhDhU6XlUp7AUPRkxqJcVbifLx1L8bTj.6uDIJvJZZD3UMqR254Y.zRbX.Y2qjSpBLHpW5tAY C6fJK_jzx_gUw8yBK3mYgIqs6WTsvN46qNf3ivGo5Nqus9EFdybskGO7fkC_LckTuhu6wA2sjEYy MkCngTwn2M02OWwNJF1nw0Patw5h1EG.8q4LrYhUrSoRxXK1CWbBwB.uwBg5vOhD8t2swFAcfVk_ n4ZLIW_dmfQDsTGtD1Dpq3b70BkQLZ8iaorJwDib6LiUgiNG8X83JDfOeTVy33pfWUtOax1U3wsP .geDph1Xs.bxTp46yC7JZuk3xCLK25jGHvTEKvM9n1GpiZuzjw5_00Oh6jTdIQvbRQl4oOV96oxW ZBY2CSjbYOyzZvBF2RarId_Qa3P9wYgkx_XFwuunZ0C.HPCNFxhR7uZMVSByAaZWuxHjdOAbbpwN b29JeINk3hi73M8Bz.e14.jMtusHcJPZxz_0fexQisxDQhXYQUrK3ZRjFQiZseR2mY5sJNdus_Y6 0dixxbM_2INjZNNPjMiW6gJp7K.DqCp3IUt5NvZPdhiVDWfzY4IfD1CEjOe33n4uH1cAI1ycoDr5 prlMAZIfyFTPv0Wq6twh0VkDyIaS7mex3In3S6Z7dhSnCus5T9pAm3IV69_OpCwzVMc7aj3vSt34 55FsYEJcx7NddlYpySIJJo_F3DYNc3Ce.sW87wcPSfpm.B1MNghUgp5eo9eZBfLgTjzUub3SvhS2 Sz8wiqGrvQMDrKfbhQHNqtNmHVwahRVMRUymK61QnY8LucyPD19_jx2gpK39BG0vSwXo8kqXG7eL EGNztORaW2RTXdXWsK8VylfM3DCmL3vfnLuSQoTbiQ_UkeEFiU5oTFyMynJbymps5oKH4usPlJzR 7lu.kzYkUpeTlq4Ff8iq4aUUpmfjJ5bc01Z9DqGOehxQDhR0gk4IJ2Dj9GDoKDTIfYwcY7QZ9ucr BfAC2Pa4f6cwm2eeKUycfJc94Nf55ycZ.7NIpt3rDKeHsMljqWSk1B0DioEmxlODjPSB5aBzbGEH A518VwJTPH3.DGbUMTNNQaQkc4ViDkfhfZuh76LuWUiNrRI4ToSWTrUKKIBgxXZ6I2FCH8utGH95 yjnCs8EItKvCGkU8TpRmfl55TdbM3b5PQWEHVx8fUYRU9n6CXhClIcwgTFzTpaIstZVF7nE1d5Y7 Rl4aTza7dwrGPq_rtfX4ze20hTGNgv0avdx0LaNm9B36pVckN72oYXi8uSNgh8qAxp03NWex2I4O bpMVpx8Od3HJRMRNuPBgwLmCccWS8fAFHdtP4cNT66YII5ZLlshCTBYx13qhK_TQGrgUrWqtVsYI GdR0QlqBsqj5EP2LibZa_r2MXTvCf7ETXvWWHSgfZ63J4h1DhxTP3PaZTCwBumPy.LSBAhmKFKls udSxpuzIA_A_cSIwb5vVzN3nIvRqaSb_krMMQ6n9_C2kyeNPd.p2E1K_5g1At_.e1yXtaBtm51Uw by9P0qj1mJ2PG.Zr_IFl3DH9_KLxa_wBtSVzVvkEzEAWUorwQqqpN210nf4lWicWiv.SJ2Ed8MRX jGH4qYu86UzK56g4K3LDMyQPiD7LV8lduflZG_I4bvfO0dKtdLaGp.FLdI1NVNztsJXIZCveO7kj BWxXNBiSfzBw9XeN0lkaUxWnS_BJgToi4DCQMnDfh5YwAC14npUM_DGkH_TstqL3dfqaRyRtf9vF Thg0O6tW5U258edg4TdD3kPUqm4BE0Fos0vI3ZiqC4koGAtKPN5YfyVU_uu3zcctZBE4BimkPa.P _Xp0Uob9BC_hoso6EQFQhM0KpkzXOLtc4kk4XeoH.81PxbZ8.DYNIKwWNfRtUkqFUOLDcXqjsZml 6.y6l X-Sonic-MF: Message-ID: <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> Date: Thu, 14 Jul 2022 22:07:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Thorsten Leemhuis , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> From: Chuck Zmudzinski In-Reply-To: <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 4181 On 7/14/2022 1:30 AM, Thorsten Leemhuis wrote: > On 13.07.22 03:36, Chuck Zmudzinski wrote: > > The commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > incorrectly failed to account for the case in init_cache_modes() when > > CPUs do support PAT and falsely reported PAT to be disabled when in > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > MTRR is disabled but PAT is still enabled, and that is the case > > that the aforementioned commit failed to account for. > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > not correctly report that PAT is enabled in such environments. The fix > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > to account for. > > > > This approach arranges for pat_enabled() to return true in the Xen PV > > environment without undermining the rest of PAT MSR management logic > > that considers PAT to be disabled: Specifically, no writes to the PAT > > MSR should occur. > > > > This patch fixes a regression that some users are experiencing with > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > correctly reporting to the Intel i915 driver that PAT is enabled where > > previously it was falsely reporting that PAT is disabled. Some users > > are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > > Dom0 are experiencing reduced graphics performance because the keying of > > the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > > means that in particular graphics frame buffer accesses are quite a bit > > less performant than possible without this patch. > > > > Also, with the current code, in the Xen PV environment, PAT will not be > > disabled if the administrator sets the "nopat" boot option. Introduce > > a new boolean variable, pat_force_disable, to forcibly disable PAT > > when the administrator sets the "nopat" option to override the default > > behavior of using the PAT configuration that Xen has provided. > > > > For the new boolean to live in .init.data, init_cache_modes() also needs > > moving to .init.text (where it could/should have lived already before). > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > BTW, "submitting-patches.rst" says it should just be "the first 12 > characters of the SHA-1 ID" Actually it says "at least", so more that 12 is It is probably safest to put the entire SHA-1 ID in because of the possibility of a collision. At least that's how I understand what submitting-patches.rst. > > > Co-developed-by: Jan Beulich > > Cc: stable@vger.kernel.org > > Signed-off-by: Chuck Zmudzinski > > Sorry, have to ask: is this supposed to finally fix this regression? > https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ Yes that's the first report I saw to lkml about this isssue. So if I submit a v3 I will include that. But my patch does not have a sign-off from the Co-developer as I mentioned in a message earlier today, and the discussion that has ensued leads me to think a better solution is to just revert the commit in the i915 driver instead, and leave the bigger questions for Juergen Gross and his plans to re-work the x86/PAT code in September, as he said on this thread in the last couple of days. This patch is dead now, as far as I can tell, because the Co-developer is not cooperating. Chuck > > If yes, please include Link: and Reported-by: tags, as explained in > submitting-patches.rst (I only care about the link tag, as I'm tacking > that regression). > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > reports and sometimes miss something important when writing mails like > this. If that's the case here, don't hesitate to tell me in a public > reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Fri Jul 15 02:19:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 02:19:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367867.599009 (Exim 4.92) (envelope-from ) id 1oCAvp-00063i-Nm; Fri, 15 Jul 2022 02:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367867.599009; Fri, 15 Jul 2022 02:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCAvp-00063b-Ka; Fri, 15 Jul 2022 02:19:53 +0000 Received: by outflank-mailman (input) for mailman id 367867; Fri, 15 Jul 2022 02:19:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCAvn-00063V-Ow for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 02:19:52 +0000 Received: from sonic308-8.consmr.mail.gq1.yahoo.com (sonic308-8.consmr.mail.gq1.yahoo.com [98.137.68.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 996e0066-03e4-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 04:19:49 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 02:19:47 +0000 Received: by hermes--production-ne1-7864dcfd54-xmlhn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ba0ca635c88d8bc86fe3ed38195e495d; Fri, 15 Jul 2022 02:19:44 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 996e0066-03e4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657851587; bh=ikYj4oGExaqVUjXEqqwrkniGmBXQdtogeu3jz7ioOUw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=QFOscrCN2oVaeycP2RbKLtRi7bImemzW671zFZhpnbsqWt4HC9FMMzPey6mMQwIJEN5/WabaadMuotMims7n3yiLh4VQvJZiVGsTlMUgnGKQv3j7jDb7wfKn/2jBbO4VHE56C/DNKmpPx2Muc1+fYhjGlCpR8Ubsh2EXt0Ei9PPyXMtZL1ALWt6M9zkRkfDQpYzILKE0m4PfxW8vjwlIjGZyhXWtCYFIl2ewpWJY5lrsjls/qWA2frSnD4XmmnVx0xeUwz6X7Kq0eVVtFInX2L6YPvEh8zDqUbkr7pHSsQrmJT60WhxA1hLrFGwwOwSiBl1SrHeQSzXuG4aaoDsEtg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657851587; bh=2tvmpiwH/jUC7q1rvaoVWpN60yRmZ3/H7HpMVZ0HX6u=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=qBQ5x2hvSABvVUR9T6tfp5kzDs4vIUHpmjJukK6R1D293SOiSXflauNRC8h8V7yGA5NUIGjpd9kOasV9Uyo1o+sH2HPxnKlJQGH0NGdtgISVl0IEJ7tZrAV6pXZnNxPQqkgR1uOliRQxaPJd8Ou/O2lKnEM+0XcJZEe2z3tqYGvsTbJtr7XkBc1oQBYxCPW0d6/e9lHn2D5F7tay+QP3/gNc1Ptw+gYTAwZLKFV4KhcGS/JfUdqJm2SvmKQaMdpWWjUqRJo0jPmCQS7zCMNK8B8gp/ZbP/r7JtF9Ejj7R2yNKGIzWnJQwgjTpw6TO7fGfdq/rDFqiYWWDRXO1Iw7jg== X-YMail-OSG: ApqVZPQVM1m.wsDXoGVxxoB9DGoFc4flSA7teL_IGd3AKzWtk3YLgQV_I29qiDi KIdhvF8By5OGwCsQhwz88fQWE4Xyg5YpV2OkAsNbZl0iediYd5KK0tP0uE_2uxWqC6yeUHzNjpoT 6zJus7ZrCPA9aS9BZsPxbbZOlM5FDHBtPFWcLnSuaox6WtgJt72OJhvM6wcPkfc8d43KwDVDvnFH JH0OsckJjHtd_.SXdIZiEJXSTDdm8PZ71JtO0cMP2PU.5cQxyJ0tt8ov9lbLbalGygWMEdRR1v2Q IKu0EtemjPuQW9k.Mznx2_48l9OvBJctdXrG8b3IX4u7cQB7u4ZEluB1cP..CO.aJBh375RRZYVz lH0YuUcu_4SCWucRUNNWYmZ_TUsN5Qq.EyIXeWXi6gU5m24bh6.pQhxlSHDA_y3EIJ0il1R00He8 yD19JMqHMzNZeL0XoJ4sQEPqrgLh1t0u1EraisbHbEPWPH4aN4rGiIJlYJm3b7tKUCAtk6H3SnGS Sq7iyMy9PGBXiptV1yqxq4t_9Ogf1nTaIaSnujBlb80pcCqYbUQNNpU28OjymzGT0FKPEr1J8hp3 jTw_oJHZp5evOHpJzJuXNsqDxhDQ6QK2PL7keZgqwMPXm0zbSGoeJ3V6aGAfaXE2eJ9z.MhoBlMW 1eUpZZF.wfzxpdaqj1ka83puoc6k0PXrrzlRMO.qI04cJxSn0S6WrGhVOHMSxLPn.tEkCk16imCj hTj.0.dXsQtvh4S6ODaiX8LKiLbk135orr9Hds7lv.P4.LJy.SQaOc1Kyhrd_dBrVX1miyjZvnas wF.7ADKh31NviBWh.5qUUs73Qdd3RU3ZHIS3UhfHixjiCU3ZwJrUJpr_GSwWt4PzJuOFwId0POTr qtG_7tzE5L7vXbEF8goVIDY4_YSWfqngUzIydcuz.KWwvkB7raE6DE28qqFcipEIZUS9roExNaGg ahXxhkhq.1mN7tB_gXpGP1IPli3LU6aDXphQxowwu.7sv6Uy0fgfwEDEMnv8dmqhGIOKWY8qUUEP 3h3KUfmQoyvPvexFnmG2VVENhaKkp7fly5tVGdcYgz94FxCTiqtkqsruEncEuCVePpqgMIi3ySMi as_Bcd68LeDhwBoGwrj7mmpCuAITvs6t0OYahqQX3FTV7tpz4ITJefXH0Pp7xhQfxgydowiGEXI5 FrqG3qKZ4fbJryg2O5G8u7z.Iauq3xkWmP5_wUGtl3yxn1KYpUIMGHuhlVUXl01eHii6pUVLUGKC IErXK09TeFdDLvsZPsUuqWfa0UNEGSBSKeD1HIjskIiFLQE0tIuDX.xxXuMYRdt._p8s9aphqmgH KFBFoqmIsI8xiC1Bh1EiLVRw7d6HSntdZZ2L2w_3_VCenabqMfsXM8B0WQ_Kr2gRGtZZejjBTT.M hfAvEkaspRkbwSKzZLE71jso7pGHsVaP8liKErRjqBYlIcEzm1bI4GdDuTBJAb4ZRMnnKn7vxffF rdKbc9FEjjGDpR_8PSsSQ4e9a7iVMy8KnV8PJ64CfutNuryMKnQuEpnrfz7CcjSfeMcomKh7ZI7C XhDFZEMEbLfgFEPyvmW_jtAhmV3DSL_CrTIwAe28AU.SorZhYnCvsZ8rmHP9rbuPkL22aFX.m70a ligBiA.hiAKujwRdnB4xwHdZRdPdJUaNI5.w2pERn0j5.iAvBRljuxCVnOOVN8Z1kyMe5H5cxwWV NPHqGzGW7aBzwyoFjLqFOP0XYHS_xymYcSrG3LBblT.D0JSJq0p5UYizPI0lkaUM967RUqlbxce3 OyBHcrmZeVn0l9fSbEpVymyZtX.s10CXiSzwqSUg4Zhi9D6zBKPKqQNcyBqhNPTkzzP8zSmdcKmf Jak8OicvOEK.9qWNEJLFsE2sMs4kOj2wdGtzZjP3_xuIdMBI1cAFMe4rL3h9d1nUw58DJhpBdlI5 xStANGwAAQWxYweCSe_G7y.qusltHEkeIhsdOv085GnWaNHhlpgDExxR4yugFhtT9hrGOpOhhxTO hz7PQfEU_2ITr9.ICrBIWexsKfYAbeSfLQslCyXhuZGj3EX_Ft30TNvNuMZI9PdJfiE9I8oda5p7 WoMGXhNoePb013uAAP3bMTAgZ6Cg6duvgDKTREuVNKDu6SVPuyeUs0ZO3fqwVCQcwWNhNEb8FY6I xuBud4UC4q7cHXLd6vvVjimMaopaeHnppdeJxZCFLszjSRGRY1deIV.B2j.MQObec2QN3IY5qCiZ n8Ac- X-Sonic-MF: Message-ID: Date: Thu, 14 Jul 2022 22:19:40 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Juergen Gross , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7069 On 7/14/2022 1:40 AM, Juergen Gross wrote: > On 13.07.22 03:36, Chuck Zmudzinski wrote: > > The commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > incorrectly failed to account for the case in init_cache_modes() when > > CPUs do support PAT and falsely reported PAT to be disabled when in > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > MTRR is disabled but PAT is still enabled, and that is the case > > that the aforementioned commit failed to account for. > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > not correctly report that PAT is enabled in such environments. The fix > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > to account for. > > > > This approach arranges for pat_enabled() to return true in the Xen PV > > environment without undermining the rest of PAT MSR management logic > > that considers PAT to be disabled: Specifically, no writes to the PAT > > MSR should occur. > > > > This patch fixes a regression that some users are experiencing with > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > correctly reporting to the Intel i915 driver that PAT is enabled where > > previously it was falsely reporting that PAT is disabled. Some users > > are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > > Dom0 are experiencing reduced graphics performance because the keying of > > the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > > means that in particular graphics frame buffer accesses are quite a bit > > less performant than possible without this patch. > > > > Also, with the current code, in the Xen PV environment, PAT will not be > > disabled if the administrator sets the "nopat" boot option. Introduce > > a new boolean variable, pat_force_disable, to forcibly disable PAT > > when the administrator sets the "nopat" option to override the default > > behavior of using the PAT configuration that Xen has provided. > > > > For the new boolean to live in .init.data, init_cache_modes() also needs > > moving to .init.text (where it could/should have lived already before). > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > Co-developed-by: Jan Beulich > > Cc: stable@vger.kernel.org > > Signed-off-by: Chuck Zmudzinski > > --- > > v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > > *Add the necessary code to incorporate the "nopat" fix > > *void init_cache_modes(void) -> void __init init_cache_modes(void) > > *Add Jan Beulich as Co-developer (Jan has not signed off yet) > > *Expand the commit message to include relevant parts of the commit > > message of Jan Beulich's proposed patch for this problem > > *Fix 'else if ... {' placement and indentation > > *Remove indication the backport to stable branches is only back to 5.17.y > > > > I think these changes address all the comments on the original patch > > > > I added Jan Beulich as a Co-developer because Juergen Gross asked me to > > include Jan's idea for fixing "nopat" that was missing from the first > > version of the patch. > > > > The patch has been tested, it works as expected with and without nopat > > in the Xen PV Dom0 environment. That is, "nopat" causes the system to > > exhibit the effects and problems that lack of PAT support causes. > > > > arch/x86/mm/pat/memtype.c | 16 ++++++++++++++-- > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > index d5ef64ddd35e..10a37d309d23 100644 > > --- a/arch/x86/mm/pat/memtype.c > > +++ b/arch/x86/mm/pat/memtype.c > > @@ -62,6 +62,7 @@ > > > > static bool __read_mostly pat_bp_initialized; > > static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > static bool __read_mostly pat_bp_enabled; > > static bool __read_mostly pat_cm_initialized; > > > > @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) > > static int __init nopat(char *str) > > { > > pat_disable("PAT support disabled via boot option."); > > + pat_force_disabled = true; > > return 0; > > } > > early_param("nopat", nopat); > > @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) > > wrmsrl(MSR_IA32_CR_PAT, pat); > > } > > > > -void init_cache_modes(void) > > +void __init init_cache_modes(void) > > { > > u64 pat = 0; > > > > @@ -292,7 +294,7 @@ void init_cache_modes(void) > > rdmsrl(MSR_IA32_CR_PAT, pat); > > } > > > > - if (!pat) { > > + if (!pat || pat_force_disabled) { > > Can we just remove this modification and ... > > > /* > > * No PAT. Emulate the PAT table that corresponds to the two > > * cache bits, PWT (Write Through) and PCD (Cache Disable). > > @@ -313,6 +315,16 @@ void init_cache_modes(void) > > */ > > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > + } else if (!pat_bp_enabled) { > > ... use > > + } else if (!pat_bp_enabled && !pat_force_disabled) { > > here? > > This will result in the desired outcome in all cases IMO: If PAT wasn't > disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or > Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of > MTRR), then PAT will be set to "enabled" again. With that, you can also completely remove the new Boolean - it will be a meaningless variable wasting memory. This will also make my patch more or less do what Jan's patch does - the "nopat" option will not cause the situation when the PAT MSR does not match the software view. So you are basically proposing just going back to my original patch, after fixing the style problems, of course. That also would solve the problem of needing Jan's S-o-b. I am inclined, however, to wait for a maintainer who has power to actually do the commit, to make a comment. Your R-b to my v2 did not have much clout with the actual maintainers, as far as I can tell. I am somewhat annoyed that it was at your suggestion that my v2 ended up confusing the main issue, the regression, with the red herring of the "nopat" option. Chuck > > + /* > > + * In some environments, specifically Xen PV, PAT > > + * initialization is skipped because MTRRs are disabled even > > + * though PAT is available. In such environments, set PAT to > > + * enabled to correctly indicate to callers of pat_enabled() > > + * that CPU support for PAT is available. > > + */ > > + pat_bp_enabled = true; > > + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > > } > > > > __init_cache_modes(pat); > > > Juergen From xen-devel-bounces@lists.xenproject.org Fri Jul 15 02:29:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 02:29:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367873.599020 (Exim 4.92) (envelope-from ) id 1oCB4d-0007oJ-JC; Fri, 15 Jul 2022 02:28:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367873.599020; Fri, 15 Jul 2022 02:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCB4d-0007oC-Fj; Fri, 15 Jul 2022 02:28:59 +0000 Received: by outflank-mailman (input) for mailman id 367873; Fri, 15 Jul 2022 02:28:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCB4c-0007o2-5k; Fri, 15 Jul 2022 02:28:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCB4c-00015a-2z; Fri, 15 Jul 2022 02:28:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCB4b-000693-Hw; Fri, 15 Jul 2022 02:28:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCB4b-0003DP-Ff; Fri, 15 Jul 2022 02:28:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=URb6Gpk84pfhOL7D12jQNXe2dk7Er7q0ob1SVQOpQAk=; b=1fYgiYiZZWLrV9qkXBmRdbFM5k 7+dZz4fXHUeP2VXkzfu+mzrbYE9NHX0PaiQG3KhTc1iUPAl1CwmkdjgnNyhaoLqfn0jatA6oXrCLB vrgdbBZURTQF7/Da1hqyPyJKao26LeWt76Nh9k2RK5tD3X2TCETrxt0GsREHspWusHlU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171628: FAIL X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-libvirt::broken:regression xen-4.16-testing:test-armhf-armhf-libvirt:host-install(5):broken:heisenbug xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 X-Osstest-Versions-That: xen=744accad1b73223b3261e3e678e16e030d83b179 From: osstest service owner Date: Fri, 15 Jul 2022 02:28:57 +0000 flight 171628 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171628/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt broken in 171621 Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 5 host-install(5) broken in 171621 pass in 171628 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 171621 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171595 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 baseline version: xen 744accad1b73223b3261e3e678e16e030d83b179 Last test of basis 171595 2022-07-12 09:37:57 Z 2 days Testing same since 171608 2022-07-12 23:09:33 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-armhf-armhf-libvirt broken Not pushing. ------------------------------------------------------------ commit 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 Author: Andrew Cooper Date: Mon Jun 27 19:29:40 2022 +0100 x86/spec-ctrl: Mitigate Branch Type Confusion when possible Branch Type Confusion affects AMD/Hygon CPUs on Zen2 and earlier. To mitigate, we require SMT safety (STIBP on Zen2, no-SMT on Zen1), and to issue an IBPB on each entry to Xen, to flush the BTB. Due to performance concerns, dom0 (which is trusted in most configurations) is excluded from protections by default. Therefore: * Use STIBP by default on Zen2 too, which now means we want it on by default on all hardware supporting STIBP. * Break the current IBPB logic out into a new function, extending it with IBPB-at-entry logic. * Change the existing IBPB-at-ctxt-switch boolean to be tristate, and disable it by default when IBPB-at-entry is providing sufficient safety. If all PV guests on the system are trusted, then it is recommended to boot with `spec-ctrl=ibpb-entry=no-pv`, as this will provide an additional marginal perf improvement. This is part of XSA-407 / CVE-2022-23825. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit d8cb7e0f069e0f106d24941355b59b45a731eabe) commit 5457a6870eb1369b868f7b8e833966ed43a773ad Author: Andrew Cooper Date: Tue Mar 15 18:30:25 2022 +0000 x86/spec-ctrl: Enable Zen2 chickenbit ... as instructed in the Branch Type Confusion whitepaper. This is part of XSA-407. Signed-off-by: Andrew Cooper (cherry picked from commit 9deaf2d932f08c16c6b96a1c426e4b1142c0cdbe) commit 0826c7596d35c887b3b7858137c7ac374d9ef17a Author: Andrew Cooper Date: Mon May 16 15:48:24 2022 +0100 x86/cpuid: Enumeration for BTC_NO BTC_NO indicates that hardware is not succeptable to Branch Type Confusion. Zen3 CPUs don't suffer BTC. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76cb04ad64f3ab9ae785988c40655a71dde9c319) commit 76c5fcee9027fb8823dd501086f0ff3ee3c4231c Author: Andrew Cooper Date: Thu Feb 24 13:44:33 2022 +0000 x86/spec-ctrl: Support IBPB-on-entry We are going to need this to mitigate Branch Type Confusion on AMD/Hygon CPUs, but as we've talked about using it in other cases too, arrange to support it generally. However, this is also very expensive in some cases, so we're going to want per-domain controls. Introduce SCF_ist_ibpb and SCF_entry_ibpb controls, adding them to the IST and DOM masks as appropriate. Also introduce X86_FEATURE_IBPB_ENTRY_{PV,HVM} to to patch the code blocks. For SVM, the STGI is serialising enough to protect against Spectre-v1 attacks, so no "else lfence" is necessary. VT-x will use use the MSR host load list, so doesn't need any code in the VMExit path. For the IST path, we can't safely check CPL==0 to skip a flush, as we might have hit an entry path before it's IBPB. As IST hitting Xen is rare, flush irrespective of CPL. A later path, SCF_ist_sc_msr, provides Spectre-v1 safety. For the PV paths, we know we're interrupting CPL>0, while for the INTR paths, we can safely check CPL==0. Only flush when interrupting guest context. An "else lfence" is needed for safety, but we want to be able to skip it on unaffected CPUs, so the block wants to be an alternative, which means the lfence has to be inline rather than UNLIKELY() (the replacement block doesn't have displacements fixed up for anything other than the first instruction). As with SPEC_CTRL_ENTRY_FROM_INTR_IST, %rdx is 0 on entry so rely on this to shrink the logic marginally. Update the comments to specify this new dependency. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 53a570b285694947776d5190f591a0d5b9b18de7) commit 2a9e690a0ad5d54dca4166e089089a07bbe7fc85 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework SPEC_CTRL_ENTRY_FROM_INTR_IST We are shortly going to add a conditional IBPB in this path. Therefore, we cannot hold spec_ctrl_flags in %eax, and rely on only clobbering it after we're done with its contents. %rbx is available for use, and the more normal register to hold preserved information in. With %rax freed up, use it instead of %rdx for the RSB tmp register, and for the adjustment to spec_ctrl_flags. This leaves no use of %rdx, except as 0 for the upper half of WRMSR. In practice, %rdx is 0 from SAVE_ALL on all paths and isn't likely to change in the foreseeable future, so update the macro entry requirements to state this dependency. This marginal optimisation can be revisited if circumstances change. No practical change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit e9b8d31981f184c6539f91ec54bd9cae29cdae36) commit e7671561c84322860875745e57b228a7a310f2bf Author: Andrew Cooper Date: Mon Jul 4 21:32:17 2022 +0100 x86/spec-ctrl: Rename opt_ibpb to opt_ibpb_ctxt_switch We are about to introduce the use of IBPB at different points in Xen, making opt_ibpb ambiguous. Rename it to opt_ibpb_ctxt_switch. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit a8e5ef079d6f5c88c472e3e620db5a8d1402a50d) commit 31aa2a20bfefc3a8a200da54a56471bf99f9630e Author: Andrew Cooper Date: Tue Jun 28 14:36:56 2022 +0100 x86/spec-ctrl: Rename SCF_ist_wrmsr to SCF_ist_sc_msr We are about to introduce SCF_ist_ibpb, at which point SCF_ist_wrmsr becomes ambiguous. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 76d6a36f645dfdbad8830559d4d52caf36efc75e) commit 3a280cbae7022b83af91c27a8e2211ba3b1234f5 Author: Andrew Cooper Date: Fri Jul 1 15:59:40 2022 +0100 x86/spec-ctrl: Rework spec_ctrl_flags context switching We are shortly going to need to context switch new bits in both the vcpu and S3 paths. Introduce SCF_IST_MASK and SCF_DOM_MASK, and rework d->arch.verw into d->arch.spec_ctrl_flags to accommodate. No functional change. This is part of XSA-407. Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich (cherry picked from commit 5796912f7279d9348a3166655588d30eae9f72cc) (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 15 02:54:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 02:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367882.599031 (Exim 4.92) (envelope-from ) id 1oCBSg-0003Bl-Nt; Fri, 15 Jul 2022 02:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367882.599031; Fri, 15 Jul 2022 02:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCBSg-0003Be-Je; Fri, 15 Jul 2022 02:53:50 +0000 Received: by outflank-mailman (input) for mailman id 367882; Fri, 15 Jul 2022 02:53:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCBSe-0003BV-EF for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 02:53:48 +0000 Received: from sonic309-22.consmr.mail.gq1.yahoo.com (sonic309-22.consmr.mail.gq1.yahoo.com [98.137.65.148]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5736610e-03e9-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 04:53:46 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 02:53:43 +0000 Received: by hermes--production-ne1-7864dcfd54-hwfdm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0c5cc85777bf3bf7cde9ad4fd0cf95dc; Fri, 15 Jul 2022 02:53:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5736610e-03e9-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657853623; bh=nRV6iAnQ79cAVUulUzKd9r0uGj8vG1wTg/tfSrpm9Vw=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=sipFMQdUJn/hdysSQLEyNfx16pFDg2bpiPQYUmh2qLgnprjdpmDXaeJTMlUdUx3RF+2lWokk9iCqe+vStDt5yHG8rIL2APmWTWwJ0XFTxkfJrFIvVUFqn854nnqfhnO341sUAR3KOmPACJS1Rm7wEoUWBKntXfxs6AqXwAuOQbO33/+qrwSGhqbt+nKr/K/ybmG0jMOiyXQSyBCvz1YYwHvFx4SVXtbMrk5o/lDFFVMfhVLNFvh8Ac27R84M1N5ccBEmfa08WkxpwZNwICmef52IFAgrOp7XhmB/zgEidBYsCaqLXw8DTXIzkYAHA8gol46hzk7t5XHWdssx/tW+oA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657853623; bh=zNVuMCa/AAnwR+dpImS0D5d8UXGJXDiMkIRe2FiJnP6=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=eMwfQe0xvjeAQ6bBCCJlQ5Lw2ZMIvLR8b8aHCV65TLySkvM7nZUG0RfNex0oeh3w+UyHAtyS6yeBdFhc+1MOYEYy0MEj3SacoFtZFhPKUm2QGQbqQxQFIXb8z/yO2zU4N+9FbGxvkpwM6DUk+uuZ1llor4JTVeYC9Jt53tw4uJkMFNPpoG3Ok82zVQQc/qBkLaDGrSZSKLrE0GYqGG1HdNmCX+FJyUr62JKhE7q3PxvdjlMmDC7NtZkAZvkzqX8XlkXIaaekJZqhV4pD7GzWkHU689yKsDWmmEw0evQD75FGgW3q2IDbw+8bIhf+UHfQdaHwW6EwgWo+tDR3gO3CdQ== X-YMail-OSG: TB5Ll.UVM1nYThAvfPo6v2qNfDlUusmCkMRtK6o7DjTMKp_RE29vE07kYbwtu_f ayeQGpwaA_TsYailnCw5aHiwOYytzX_XTKZ1GwRqTotYoxuZsxHV.ztTlHV6uCdPqNGz1_9_s3ot 3kqKl9LL3lToA2olNXhzMAHlQKUx5jIAoynmHCZQRCDvabImFKx3HZZAImCq0fkzXm2eQ19a6ABx At9PzO.hlQdoUM8QYgyOdwI8oSHEyQ118BtmYEbxvtjZujqn5bzJTgzTkI1cwgnECKUaGa8VeVvF zck9VRQ4uH_3IW89hun_mM68Bc0Sn51oW3DvfGxbryHFQqCcRqR.ShMfvThcVAhQCT1EH6mceTk7 R3KA6Vy_l_PIhERfYKHRrrQGe0tB5w6CNkkK9cVa3HXkHWM_2zBjFHnxYheGBoYSllJMQjozHXq0 UZvjHP9_3.UnI_BvJ2zR4cIxB4U7z_P4dhXP7tpuDLnLaIAcHezvBBe6lBgjl0WSORW5lzmk1a1e t0BC.O1OcrVhQuV4xnKHj.rNozhDYH8EFn8rEZvNm9lZqr4H6z29WHKPmlFoCSCK.oWNA.sguOUN dWCZLjGiK4io.TiLGDQ6CUoS0AMY9N9PRUHhORoGYkEOECgBwfF80HL8GZDNPy5.h6mxaF7trYH2 EvmqfTmvkvJlft6BJexwxXvX8pln2YGS10hQGNqCic51xDKCV59WVc_GXVl6TkXIukmUsrwOQqXo .jvycop0zrgGxgD2OdmLs62ISZuQ_6xaJv8WvvOTYjH2pW_wxOB8ybMuwyxVOIaxK_ApnZr71qm4 vLh9GpvKHeFIWButrneMn.yrmd9dSYvNTYQbMUMxrv_H4NISonjltepU7hb7XUIh6Luzr2fAIH5t 7P7ngkv2PUBhZr2thT..cgohYqlo2fhY.XCIqryLsrIjFr843WXjreOeOuUUxMFyli2K2hePwo5x CNe2YKi5Fv4Nq3Qvnt57pogVi8uiBDtezZsC6tuacvSdPvOb5dqadQsNhV3CmIUR8GQpiGG5EBWm LqxzUMhsINrBrTx2i4snIAMgqGkhuxQ9U3QbAWIlTibsRIZD2OH93wD2Dbw6uGC2btKExrpF_IKt UGWhilNU7uiTJCk4gkyZwOjF5atCf7AbJXqdNjTigd0qjTnVuPY0cpNMRzLdCHGPlwO9QdqwCwDC R_ZLqaxWcK3fwa55pHu1pEg8KGC4hXquzLgp60lp_U.lvhrls9ZLTji0Ehwc1dAjZ79b6Wd5GJIs vHibVLOpdALqxIiTKUYzA255IM7peSOb6G0ONTDC7aJmUEBIM209MuQUzkIbyqRCw9f2M7Uc_O11 RbeP9VITMghaqTDfP_zKtVpnzW9_BEK3eo0MvbDY1DBDMvRB7hGmHvhYgiGMYZ3oo4HYa3M18Uii QvZQ95r380aqPBAESGZ4Nu9vr6kQlh_jsw_zLjuptJUmrRysgCYXoyeDJIOnnjg_O0519kX.97Bf u_7X3c4lp.wMSITuCfQlneUQ0dtB7lIeQTDmVjrsI89Okho1kYm.tV.EJgOn5eKF6xhHq7Wl0FqH aJMIqWhYtfiMrGZF8QNCvHfKF_kE2YMAggt_oXvBBfsAGqeJROvFLz4Mln_VNANH8fSi1rSKRsHr W7I0OUW7s3d2y4GU4NaOGtQrDCQVbfY.lrTWYG1jKJA6vfMfrmC5DJzdx6M1.pZHFwuhoGRhYcmj SUjmMCagW3HDzVD5lDcjHPW5597xTOnNLKhY3M6sWslj8pfvvXAzHA0K8eA_b4FAJaXZgQWwsltX eL9ED0WDoBHqKncxfru6evYkDq_7kLipy_wjWGvdxTFYAX1wEOOf4gJZ1iOptrCmpQWAlEbYClKZ g97W3FxrllxJpCPoc7gOllX3zoaCBosnBztoMd88iFaKMdtbTsgGEM7DPybb83DZ10uv1eO0bUHo 5hH5v2Vcf_7jR9h97EHatfuWmJ1jxz9CUU_9ZlBu2dGHrCZNfbUBHsQF5nOICbwO3PzvcUeHFL6J Zzdj5NEKn21w2I1fYGDtSzXeBQ_9A6anvnKbr.bg7O31qM2pPpnswbtYyEFGpbL220vMDTMdOGMN 1Ef9icJCnrrw74lJ7QL2MApzCg1BwKWJYPS90krSROYrw_wfJQgPd7BVJ1BLd3x1ZAjnIbCu1SOe 2W7TwX3AsV9OjL9QcGTW.Lo7jGoFNY7zQHOKp7ESX77sgMHq5ximbWzQAre2DT57SREI7s6gJzmt _nw-- X-Sonic-MF: Message-ID: <364742fa-160f-cb45-b868-a2a6527a716a@netscape.net> Date: Thu, 14 Jul 2022 22:53:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8047 On 7/14/2022 10:19 PM, Chuck Zmudzinski wrote: > On 7/14/2022 1:40 AM, Juergen Gross wrote: > > On 13.07.22 03:36, Chuck Zmudzinski wrote: > > > The commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > incorrectly failed to account for the case in init_cache_modes() when > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > MTRR is disabled but PAT is still enabled, and that is the case > > > that the aforementioned commit failed to account for. > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > not correctly report that PAT is enabled in such environments. The fix > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > to account for. > > > > > > This approach arranges for pat_enabled() to return true in the Xen PV > > > environment without undermining the rest of PAT MSR management logic > > > that considers PAT to be disabled: Specifically, no writes to the PAT > > > MSR should occur. > > > > > > This patch fixes a regression that some users are experiencing with > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > previously it was falsely reporting that PAT is disabled. Some users > > > are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > > > Dom0 are experiencing reduced graphics performance because the keying of > > > the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > > > means that in particular graphics frame buffer accesses are quite a bit > > > less performant than possible without this patch. > > > > > > Also, with the current code, in the Xen PV environment, PAT will not be > > > disabled if the administrator sets the "nopat" boot option. Introduce > > > a new boolean variable, pat_force_disable, to forcibly disable PAT > > > when the administrator sets the "nopat" option to override the default > > > behavior of using the PAT configuration that Xen has provided. > > > > > > For the new boolean to live in .init.data, init_cache_modes() also needs > > > moving to .init.text (where it could/should have lived already before). > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > Co-developed-by: Jan Beulich > > > Cc: stable@vger.kernel.org > > > Signed-off-by: Chuck Zmudzinski > > > --- > > > v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > > > *Add the necessary code to incorporate the "nopat" fix > > > *void init_cache_modes(void) -> void __init init_cache_modes(void) > > > *Add Jan Beulich as Co-developer (Jan has not signed off yet) > > > *Expand the commit message to include relevant parts of the commit > > > message of Jan Beulich's proposed patch for this problem > > > *Fix 'else if ... {' placement and indentation > > > *Remove indication the backport to stable branches is only back to 5.17.y > > > > > > I think these changes address all the comments on the original patch > > > > > > I added Jan Beulich as a Co-developer because Juergen Gross asked me to > > > include Jan's idea for fixing "nopat" that was missing from the first > > > version of the patch. > > > > > > The patch has been tested, it works as expected with and without nopat > > > in the Xen PV Dom0 environment. That is, "nopat" causes the system to > > > exhibit the effects and problems that lack of PAT support causes. > > > > > > arch/x86/mm/pat/memtype.c | 16 ++++++++++++++-- > > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > index d5ef64ddd35e..10a37d309d23 100644 > > > --- a/arch/x86/mm/pat/memtype.c > > > +++ b/arch/x86/mm/pat/memtype.c > > > @@ -62,6 +62,7 @@ > > > > > > static bool __read_mostly pat_bp_initialized; > > > static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > > +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > > static bool __read_mostly pat_bp_enabled; > > > static bool __read_mostly pat_cm_initialized; > > > > > > @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) > > > static int __init nopat(char *str) > > > { > > > pat_disable("PAT support disabled via boot option."); > > > + pat_force_disabled = true; > > > return 0; > > > } > > > early_param("nopat", nopat); > > > @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) > > > wrmsrl(MSR_IA32_CR_PAT, pat); > > > } > > > > > > -void init_cache_modes(void) > > > +void __init init_cache_modes(void) > > > { > > > u64 pat = 0; > > > > > > @@ -292,7 +294,7 @@ void init_cache_modes(void) > > > rdmsrl(MSR_IA32_CR_PAT, pat); > > > } > > > > > > - if (!pat) { > > > + if (!pat || pat_force_disabled) { > > > > Can we just remove this modification and ... > > > > > /* > > > * No PAT. Emulate the PAT table that corresponds to the two > > > * cache bits, PWT (Write Through) and PCD (Cache Disable). > > > @@ -313,6 +315,16 @@ void init_cache_modes(void) > > > */ > > > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > > + } else if (!pat_bp_enabled) { > > > > ... use > > > > + } else if (!pat_bp_enabled && !pat_force_disabled) { > > > > here? > > > > This will result in the desired outcome in all cases IMO: If PAT wasn't > > disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or > > Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of > > MTRR), then PAT will be set to "enabled" again. > > With that, you can also completely remove the new Boolean - it > will be a meaningless variable wasting memory. This will also make > my patch more or less do what Jan's patch does - the "nopat" option > will not cause the situation when the PAT MSR does not match the > software view. So you are basically proposing just going back to > my original patch, after fixing the style problems, of course. That > also would solve the problem of needing Jan's S-o-b. I am inclined, > however, to wait for a maintainer who has power to actually do the > commit, to make a comment. Your R-b to my v2 did not have much clout > with the actual maintainers, as far as I can tell. I am somewhat annoyed > that it was at your suggestion that my v2 ended up confusing the > main issue, the regression, with the red herring of the "nopat" > option. > > Chuck Actually, what your change does depend on keeping pat_force_disable, but after all the discussion and further thinking about this, I would prefer that you give a R-b to v3 as simply my original patch with the style fixed. I think it is wrong to confuse the regression with the "nopat" issue. If you and Jan want to do a patch for the "nopat" issue, that is your decision. I am not interested in that. I am interested in fixing the regression. Also, I am not included to formally submit v3 until Dave, Andy, Boris, or someone else with more clout here on Linux expresses interest in giving this idea an R-b. Chuck > > > > > + /* > > > + * In some environments, specifically Xen PV, PAT > > > + * initialization is skipped because MTRRs are disabled even > > > + * though PAT is available. In such environments, set PAT to > > > + * enabled to correctly indicate to callers of pat_enabled() > > > + * that CPU support for PAT is available. > > > + */ > > > + pat_bp_enabled = true; > > > + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > > > } > > > > > > __init_cache_modes(pat); > > > > > > Juergen > > From xen-devel-bounces@lists.xenproject.org Fri Jul 15 02:58:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 02:58:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367888.599041 (Exim 4.92) (envelope-from ) id 1oCBX3-00046m-8B; Fri, 15 Jul 2022 02:58:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367888.599041; Fri, 15 Jul 2022 02:58:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCBX3-00046f-5Y; Fri, 15 Jul 2022 02:58:21 +0000 Received: by outflank-mailman (input) for mailman id 367888; Fri, 15 Jul 2022 02:58:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCBX2-00046Z-Dg for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 02:58:20 +0000 Received: from sonic301-20.consmr.mail.gq1.yahoo.com (sonic301-20.consmr.mail.gq1.yahoo.com [98.137.64.146]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f98db1c7-03e9-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 04:58:18 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic301.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 02:58:16 +0000 Received: by hermes--production-ne1-7864dcfd54-s2f4b (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 80211909ddb51aab8fb5f5b0cfa4adfe; Fri, 15 Jul 2022 02:58:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f98db1c7-03e9-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657853896; bh=m9WtjFON2B2diYQ8onMXGAxyEnFHSnd98fWeZZfI1Vo=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=uMJNQltaYczYEmV/q+XCTACUcdSwmQOqv5EJevLC3LMt6Z6cUmQ+l7oQNNyxS9L1YI4yvS3AjVljb+3p9hTlnXIx9kBF6rE9gb9TGmdR57r52Fg96XgIFOieX/jHM1Km4ZextVuLM7XvKl7lyYrER/QN7aF38uk/lmMYCZiUpUZjnTEZ655NiQO6uqLHJ0KoRZTZ7/Pa/NJ5koRQG2gZlIN2p1Q7Y5XmbRPKBqkJTIr6tCmHsb5BfGhyFKkWChMraLaLahGhvyoXw5ow8UscclDXWQcbR+bLjV6achvcDvFKPXROnQnuMNAuPY/CQpi9OH6TcDhSNzktNwzqduIJJg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657853896; bh=Xrn+9aaEmbHNmDSKMSRN7UhoTyUP9tPDcEfCdsCLjNa=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=Llle1/nWWVdOE1sX6CimvAn7UgvBeWLT6E5v3ig4dxYsKg4XOoJ+5nThcOCz1PbLKouvbrBqa2Z7YKkv6AyPxiDYv9CVDRVZRI5tiWBaiL5B9c2T9/rSVWcxxAWPY0G3F3fxldhRnd+ICBq0BfEI3R094gyBQXaYTSPpoizi94n9D9fjxwDLabPXZM26afeXwNFPjmxWkHGoKqnTcLXOzucXcDDucaXa712vBApxYnQVp3Y/M5bxOjDaX+/qhO1ZdCFnisoU+rUg5oFmnZ+i3K27BgacK1PKdxspOAvJIypyeJMCyRxsAPxhqMzjC5zAGZpSMycFee2b4Kep7WPYxQ== X-YMail-OSG: TbIwLbgVM1ns_ZUQz3sJrAf2KJBf3iE6PK8r1xkCzI0ZuOSRvhhsJ8wWrT2KLWf UES80omEwKD.0AD1peXiUpAA7E_JKXuCJr8azDLeocnKbOfhDhZLHCIX5ECaNUUeI0TlAZYT3k6S K2cREfNTthUYKEfnvkmK2vz_LJtzCxk74BScnM6d1kweHI5iCh7XN7m_6zVjSmisCfUL6ipwW8r4 gBvZSr52zVMdw6qUMLhiTL1ETQ3bNih9awcZgbm2rqk3D1cUbWORiQxI5SQZVkYzwqxHCV2a8ZbT 8i2m3nV0OphykoHhPv6jhwLsYkQfE2wqUDwpsLyIf37uK1MiaaA5_gI_gnU_NcWatP4Msd5Huh7Z pBbCt5ZdEiUnABPPp0SY.ieU7.yiqalqR89RXIUSWJM6BNTtzyem3KULxpa140zrWanOUD52BX8i CDsXjMN7reg7InA3OpxGQBub5HyGvQ8sIyKUfvqWGfbJTEy8Np2aKl6jCqX5lH6SHUv9ln2g4pUU SNpzvQildU_USD9mobxfpY66zMKXuMGNhzepmuE0Drlt5JAtFntr_7yEde9tp.XcFttT0sVadRF1 T3uclNwje3QLnqKH7e7yQST9UlSRHXexy.qyG73NlFq6rvT17cNOkDNkjw0bXdgFJCeSdR.asVmO wT4q9m1MFspdUgwtYJqi4_anvgeyXRZfeKwRlWEnt9yit6ZtN6wK2sodmDgV3ldvtCzu2BLgCWjg LD84tWjI0_.U_h4JEJNxqgu.3io5PVtwFr1s7aQbvZorziYaT6kfZ9eTg.81TIc05UdpE_dTkUim u1rvZczRZ4rintfgPrxAvB6lQ2AmGfZ277FeU9XYHsGn3D_60dqDJ8ARCBWTeHNH0gk2gSnFwFvR OViFUQQ.g8cHB1OWsp4D7CdOuuay2b61XcQ2w0pfYGQpqYXf06yVaTCGJSYe8XOdZZtiySCEci9_ dLwXeWunOpSpW7avx3TMg1yOnI4HLeBbLm1RKSrsApwuRZZErlgnWeZq0qjsL.UefVgS7m7CMZ_v 9RgE6Nn2JkIrIaGSHxdY1Cq7v.Eh2H3WnJvLNolemC0opgezRw_mTrhRCfnCOXsgkYNnROO4QmIM 1HsPT_GPh9G5r.2ikL_g_.tF7WJrOnoBLJcO82I0y0T5UOY2rCJYZhXmXigebb51l86Puge3F7SN S9TpCnSj5CegyDWtXg15_U_.MUWGmaHwHWxoPiZ61EZB1rrkc06j1vwqhZ29msmC2EQeuoAyGOXI U8TP_FLaTiU7_yJJppRozZfrIK2BSnguqNIC5G2rvvRgooYFVG0ZEf7YPadeUZKhHmjjMUZ2KRCK JZoW4fB0itihfcjDPgSqTLtAxrlEgd5bG3Ka4SLrbaTn1JT9F_4KSsF5TNPryi531h5x_3qXE.uD fFju.gtMUZUct4Gck0rTzTiGcP88YlEtpUB5G9FLAYUROf3ziLhWplgi87nLPo7OiNXuh9DX3lyC bdOg.XKBk0sI7sBxjGrPLHt3R9GZb1RIEQb.xXQTxEjPpUT2g9BKpa_nPVkMLgL.D8C06d8_lXo4 W.rQEKGYUu0gH3SE0aXTa_kijcgRkh0qnoo6gYdV9B30BlFoqsyZQhfeF0LIcdp7nce_Vm6GRq0j BpZWaPsks.qMfMZO0jVxvueUg2gJT3m.BlGpf4FfSZEQhUQY7oWtNSFsTGsQ92KBV1HT8.h8Gah5 gpMrGgY4mxMs5ZKC3C3NYKnSQTbUsm4IAQBQA7OQmAQdnUEeCLPRq5Ao2BanK6sENpGHlpE3ri6o i9nlDcrsh8FKUGGNMSYa7c5jwK2CRicCZaefpdJ6FRWsWGFTeBHx0iHtHy_yMFbJmHnIjnNbmgyX qCFztZ2tgr3d0COZxZkRg8yRpDyqea7.CV9GgJypuGdbx5Iwq_86p8sbBtRLin_2ryDFoQfeiKmG cr_BUEyzodfYwSX4T74s7uwfEWoVkPbwdUGKVJ1iY6oZsdGCWhh_h4g-- X-Sonic-MF: Message-ID: <81f3e88e-a13d-f89d-6010-516f4286e0e1@netscape.net> Date: Thu, 14 Jul 2022 22:58:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <364742fa-160f-cb45-b868-a2a6527a716a@netscape.net> In-Reply-To: <364742fa-160f-cb45-b868-a2a6527a716a@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8534 On 7/14/2022 10:53 PM, Chuck Zmudzinski wrote: > On 7/14/2022 10:19 PM, Chuck Zmudzinski wrote: > > On 7/14/2022 1:40 AM, Juergen Gross wrote: > > > On 13.07.22 03:36, Chuck Zmudzinski wrote: > > > > The commit 99c13b8c8896d7bcb92753bf > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > incorrectly failed to account for the case in init_cache_modes() when > > > > CPUs do support PAT and falsely reported PAT to be disabled when in > > > > fact PAT is enabled. In some environments, notably in Xen PV domains, > > > > MTRR is disabled but PAT is still enabled, and that is the case > > > > that the aforementioned commit failed to account for. > > > > > > > > As an unfortunate consequnce, the pat_enabled() function currently does > > > > not correctly report that PAT is enabled in such environments. The fix > > > > is implemented in init_cache_modes() by setting pat_bp_enabled to true > > > > in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > > > ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > > > to account for. > > > > > > > > This approach arranges for pat_enabled() to return true in the Xen PV > > > > environment without undermining the rest of PAT MSR management logic > > > > that considers PAT to be disabled: Specifically, no writes to the PAT > > > > MSR should occur. > > > > > > > > This patch fixes a regression that some users are experiencing with > > > > Linux as a Xen Dom0 driving particular Intel graphics devices by > > > > correctly reporting to the Intel i915 driver that PAT is enabled where > > > > previously it was falsely reporting that PAT is disabled. Some users > > > > are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > > > > Dom0 are experiencing reduced graphics performance because the keying of > > > > the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > > > > means that in particular graphics frame buffer accesses are quite a bit > > > > less performant than possible without this patch. > > > > > > > > Also, with the current code, in the Xen PV environment, PAT will not be > > > > disabled if the administrator sets the "nopat" boot option. Introduce > > > > a new boolean variable, pat_force_disable, to forcibly disable PAT > > > > when the administrator sets the "nopat" option to override the default > > > > behavior of using the PAT configuration that Xen has provided. > > > > > > > > For the new boolean to live in .init.data, init_cache_modes() also needs > > > > moving to .init.text (where it could/should have lived already before). > > > > > > > > Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > > > Co-developed-by: Jan Beulich > > > > Cc: stable@vger.kernel.org > > > > Signed-off-by: Chuck Zmudzinski > > > > --- > > > > v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > > > > *Add the necessary code to incorporate the "nopat" fix > > > > *void init_cache_modes(void) -> void __init init_cache_modes(void) > > > > *Add Jan Beulich as Co-developer (Jan has not signed off yet) > > > > *Expand the commit message to include relevant parts of the commit > > > > message of Jan Beulich's proposed patch for this problem > > > > *Fix 'else if ... {' placement and indentation > > > > *Remove indication the backport to stable branches is only back to 5.17.y > > > > > > > > I think these changes address all the comments on the original patch > > > > > > > > I added Jan Beulich as a Co-developer because Juergen Gross asked me to > > > > include Jan's idea for fixing "nopat" that was missing from the first > > > > version of the patch. > > > > > > > > The patch has been tested, it works as expected with and without nopat > > > > in the Xen PV Dom0 environment. That is, "nopat" causes the system to > > > > exhibit the effects and problems that lack of PAT support causes. > > > > > > > > arch/x86/mm/pat/memtype.c | 16 ++++++++++++++-- > > > > 1 file changed, 14 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > > > > index d5ef64ddd35e..10a37d309d23 100644 > > > > --- a/arch/x86/mm/pat/memtype.c > > > > +++ b/arch/x86/mm/pat/memtype.c > > > > @@ -62,6 +62,7 @@ > > > > > > > > static bool __read_mostly pat_bp_initialized; > > > > static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > > > +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > > > > static bool __read_mostly pat_bp_enabled; > > > > static bool __read_mostly pat_cm_initialized; > > > > > > > > @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) > > > > static int __init nopat(char *str) > > > > { > > > > pat_disable("PAT support disabled via boot option."); > > > > + pat_force_disabled = true; > > > > return 0; > > > > } > > > > early_param("nopat", nopat); > > > > @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) > > > > wrmsrl(MSR_IA32_CR_PAT, pat); > > > > } > > > > > > > > -void init_cache_modes(void) > > > > +void __init init_cache_modes(void) > > > > { > > > > u64 pat = 0; > > > > > > > > @@ -292,7 +294,7 @@ void init_cache_modes(void) > > > > rdmsrl(MSR_IA32_CR_PAT, pat); > > > > } > > > > > > > > - if (!pat) { > > > > + if (!pat || pat_force_disabled) { > > > > > > Can we just remove this modification and ... > > > > > > > /* > > > > * No PAT. Emulate the PAT table that corresponds to the two > > > > * cache bits, PWT (Write Through) and PCD (Cache Disable). > > > > @@ -313,6 +315,16 @@ void init_cache_modes(void) > > > > */ > > > > pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > > > > PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > > > > + } else if (!pat_bp_enabled) { > > > > > > ... use > > > > > > + } else if (!pat_bp_enabled && !pat_force_disabled) { > > > > > > here? > > > > > > This will result in the desired outcome in all cases IMO: If PAT wasn't > > > disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or > > > Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of > > > MTRR), then PAT will be set to "enabled" again. > > > > With that, you can also completely remove the new Boolean - it > > will be a meaningless variable wasting memory. This will also make > > my patch more or less do what Jan's patch does - the "nopat" option > > will not cause the situation when the PAT MSR does not match the > > software view. So you are basically proposing just going back to > > my original patch, after fixing the style problems, of course. That > > also would solve the problem of needing Jan's S-o-b. I am inclined, > > however, to wait for a maintainer who has power to actually do the > > commit, to make a comment. Your R-b to my v2 did not have much clout > > with the actual maintainers, as far as I can tell. I am somewhat annoyed > > that it was at your suggestion that my v2 ended up confusing the > > main issue, the regression, with the red herring of the "nopat" > > option. > > > > Chuck > > Actually, what your change does depend on keeping > pat_force_disable, but after all the discussion and > further thinking about this, I would prefer that you > give a R-b to v3 as simply my original patch with the > style fixed. I think it is wrong to confuse the regression > with the "nopat" issue. If you and Jan want to do a patch > for the "nopat" issue, that is your decision. I am not interested > in that. I am interested in fixing the regression. Also, I am > not included to formally submit v3 until Dave, Andy, Boris, or > someone else with more clout here on Linux expresses > interest in giving this idea an R-b. I meant to say "i am not inclined..." not I am not included..." Sorry for the confusion, Chuck > > > > > > > > > + /* > > > > + * In some environments, specifically Xen PV, PAT > > > > + * initialization is skipped because MTRRs are disabled even > > > > + * though PAT is available. In such environments, set PAT to > > > > + * enabled to correctly indicate to callers of pat_enabled() > > > > + * that CPU support for PAT is available. > > > > + */ > > > > + pat_bp_enabled = true; > > > > + pr_info("x86/PAT: PAT enabled by init_cache_modes\n"); > > > > } > > > > > > > > __init_cache_modes(pat); > > > > > > > > > Juergen > > > > > From xen-devel-bounces@lists.xenproject.org Fri Jul 15 04:23:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 04:23:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367894.599053 (Exim 4.92) (envelope-from ) id 1oCCqv-0006a8-AR; Fri, 15 Jul 2022 04:22:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367894.599053; Fri, 15 Jul 2022 04:22:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCCqv-0006a1-7Q; Fri, 15 Jul 2022 04:22:57 +0000 Received: by outflank-mailman (input) for mailman id 367894; Fri, 15 Jul 2022 04:22:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCCqt-0006Zv-VA for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 04:22:56 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbbc2aff-03f5-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 06:22:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8315433C2D; Fri, 15 Jul 2022 04:22:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D57C3133A6; Fri, 15 Jul 2022 04:22:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id OGKqMpzr0GKySwAAMHmgww (envelope-from ); Fri, 15 Jul 2022 04:22:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbbc2aff-03f5-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657858973; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YUFV8lGLyNcki2QXaB/06UGYVGKE3MtbnfRGU8W6WMw=; b=lVjAsTowSb+Kb0dq2tiRXFv8Pe6UMXCgY9MU0LuegIzrwtrvZVqqDt/EsgR9w1+ehnndEC DWQ7/i/ydNIrgjPpP365OJAqmb9uKJN82scuAr72KEsM8kqA6Xek0rXwK2tX5miuz7vCjD u/bYeBLWroXdfgmtJawB+QOCgA3zu6g= Message-ID: Date: Fri, 15 Jul 2022 06:22:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Chuck Zmudzinski , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Juergen Gross Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------EQ4qcO3BsuuirRREa53dJEtQ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------EQ4qcO3BsuuirRREa53dJEtQ Content-Type: multipart/mixed; boundary="------------bxKcZEHZlX70PgXzH2z1YL6d"; protected-headers="v1" From: Juergen Gross To: Chuck Zmudzinski , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org Message-ID: Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> In-Reply-To: --------------bxKcZEHZlX70PgXzH2z1YL6d Content-Type: multipart/mixed; boundary="------------uCPvqSlE4vvTlN2SPxRYkRDj" --------------uCPvqSlE4vvTlN2SPxRYkRDj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTUuMDcuMjIgMDQ6MTksIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+IE9uIDcvMTQv MjAyMiAxOjQwIEFNLCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0KPj4gT24gMTMuMDcuMjIgMDM6 MzYsIENodWNrIFptdWR6aW5za2kgd3JvdGU6DQo+Pj4gVGhlIGNvbW1pdCA5OWMxM2I4Yzg4 OTZkN2JjYjkyNzUzYmYNCj4+PiAoIng4Ni9tbS9wYXQ6IERvbid0IHJlcG9ydCBQQVQgb24g Q1BVcyB0aGF0IGRvbid0IHN1cHBvcnQgaXQiKQ0KPj4+IGluY29ycmVjdGx5IGZhaWxlZCB0 byBhY2NvdW50IGZvciB0aGUgY2FzZSBpbiBpbml0X2NhY2hlX21vZGVzKCkgd2hlbg0KPj4+ IENQVXMgZG8gc3VwcG9ydCBQQVQgYW5kIGZhbHNlbHkgcmVwb3J0ZWQgUEFUIHRvIGJlIGRp c2FibGVkIHdoZW4gaW4NCj4+PiBmYWN0IFBBVCBpcyBlbmFibGVkLiBJbiBzb21lIGVudmly b25tZW50cywgbm90YWJseSBpbiBYZW4gUFYgZG9tYWlucywNCj4+PiBNVFJSIGlzIGRpc2Fi bGVkIGJ1dCBQQVQgaXMgc3RpbGwgZW5hYmxlZCwgYW5kIHRoYXQgaXMgdGhlIGNhc2UNCj4+ PiB0aGF0IHRoZSBhZm9yZW1lbnRpb25lZCBjb21taXQgZmFpbGVkIHRvIGFjY291bnQgZm9y Lg0KPj4+DQo+Pj4gQXMgYW4gdW5mb3J0dW5hdGUgY29uc2VxdW5jZSwgdGhlIHBhdF9lbmFi bGVkKCkgZnVuY3Rpb24gY3VycmVudGx5IGRvZXMNCj4+PiBub3QgY29ycmVjdGx5IHJlcG9y dCB0aGF0IFBBVCBpcyBlbmFibGVkIGluIHN1Y2ggZW52aXJvbm1lbnRzLiBUaGUgZml4DQo+ Pj4gaXMgaW1wbGVtZW50ZWQgaW4gaW5pdF9jYWNoZV9tb2RlcygpIGJ5IHNldHRpbmcgcGF0 X2JwX2VuYWJsZWQgdG8gdHJ1ZQ0KPj4+IGluIGluaXRfY2FjaGVfbW9kZXMoKSBmb3IgdGhl IGNhc2UgdGhhdCBjb21taXQgOTljMTNiOGM4ODk2ZDdiY2I5Mjc1M2JmDQo+Pj4gKCJ4ODYv bW0vcGF0OiBEb24ndCByZXBvcnQgUEFUIG9uIENQVXMgdGhhdCBkb24ndCBzdXBwb3J0IGl0 IikgZmFpbGVkDQo+Pj4gdG8gYWNjb3VudCBmb3IuDQo+Pj4NCj4+PiBUaGlzIGFwcHJvYWNo IGFycmFuZ2VzIGZvciBwYXRfZW5hYmxlZCgpIHRvIHJldHVybiB0cnVlIGluIHRoZSBYZW4g UFYNCj4+PiBlbnZpcm9ubWVudCB3aXRob3V0IHVuZGVybWluaW5nIHRoZSByZXN0IG9mIFBB VCBNU1IgbWFuYWdlbWVudCBsb2dpYw0KPj4+IHRoYXQgY29uc2lkZXJzIFBBVCB0byBiZSBk aXNhYmxlZDogU3BlY2lmaWNhbGx5LCBubyB3cml0ZXMgdG8gdGhlIFBBVA0KPj4+IE1TUiBz aG91bGQgb2NjdXIuDQo+Pj4NCj4+PiBUaGlzIHBhdGNoIGZpeGVzIGEgcmVncmVzc2lvbiB0 aGF0IHNvbWUgdXNlcnMgYXJlIGV4cGVyaWVuY2luZyB3aXRoDQo+Pj4gTGludXggYXMgYSBY ZW4gRG9tMCBkcml2aW5nIHBhcnRpY3VsYXIgSW50ZWwgZ3JhcGhpY3MgZGV2aWNlcyBieQ0K Pj4+IGNvcnJlY3RseSByZXBvcnRpbmcgdG8gdGhlIEludGVsIGk5MTUgZHJpdmVyIHRoYXQg UEFUIGlzIGVuYWJsZWQgd2hlcmUNCj4+PiBwcmV2aW91c2x5IGl0IHdhcyBmYWxzZWx5IHJl cG9ydGluZyB0aGF0IFBBVCBpcyBkaXNhYmxlZC4gU29tZSB1c2Vycw0KPj4+IGFyZSBleHBl cmllbmNpbmcgc3lzdGVtIGhhbmdzIGluIFhlbiBQViBEb20wIGFuZCBhbGwgdXNlcnMgb24g WGVuIFBWDQo+Pj4gRG9tMCBhcmUgZXhwZXJpZW5jaW5nIHJlZHVjZWQgZ3JhcGhpY3MgcGVy Zm9ybWFuY2UgYmVjYXVzZSB0aGUga2V5aW5nIG9mDQo+Pj4gdGhlIHVzZSBvZiBXQyBtYXBw aW5ncyB0byBwYXRfZW5hYmxlZCgpIChzZWUgYXJjaF9jYW5fcGNpX21tYXBfd2MoKSkNCj4+ PiBtZWFucyB0aGF0IGluIHBhcnRpY3VsYXIgZ3JhcGhpY3MgZnJhbWUgYnVmZmVyIGFjY2Vz c2VzIGFyZSBxdWl0ZSBhIGJpdA0KPj4+IGxlc3MgcGVyZm9ybWFudCB0aGFuIHBvc3NpYmxl IHdpdGhvdXQgdGhpcyBwYXRjaC4NCj4+Pg0KPj4+IEFsc28sIHdpdGggdGhlIGN1cnJlbnQg Y29kZSwgaW4gdGhlIFhlbiBQViBlbnZpcm9ubWVudCwgUEFUIHdpbGwgbm90IGJlDQo+Pj4g ZGlzYWJsZWQgaWYgdGhlIGFkbWluaXN0cmF0b3Igc2V0cyB0aGUgIm5vcGF0IiBib290IG9w dGlvbi4gSW50cm9kdWNlDQo+Pj4gYSBuZXcgYm9vbGVhbiB2YXJpYWJsZSwgcGF0X2ZvcmNl X2Rpc2FibGUsIHRvIGZvcmNpYmx5IGRpc2FibGUgUEFUDQo+Pj4gd2hlbiB0aGUgYWRtaW5p c3RyYXRvciBzZXRzIHRoZSAibm9wYXQiIG9wdGlvbiB0byBvdmVycmlkZSB0aGUgZGVmYXVs dA0KPj4+IGJlaGF2aW9yIG9mIHVzaW5nIHRoZSBQQVQgY29uZmlndXJhdGlvbiB0aGF0IFhl biBoYXMgcHJvdmlkZWQuDQo+Pj4NCj4+PiBGb3IgdGhlIG5ldyBib29sZWFuIHRvIGxpdmUg aW4gLmluaXQuZGF0YSwgaW5pdF9jYWNoZV9tb2RlcygpIGFsc28gbmVlZHMNCj4+PiBtb3Zp bmcgdG8gLmluaXQudGV4dCAod2hlcmUgaXQgY291bGQvc2hvdWxkIGhhdmUgbGl2ZWQgYWxy ZWFkeSBiZWZvcmUpLg0KPj4+DQo+Pj4gRml4ZXM6IDk5YzEzYjhjODg5NmQ3YmNiOTI3NTNi ZiAoIng4Ni9tbS9wYXQ6IERvbid0IHJlcG9ydCBQQVQgb24gQ1BVcyB0aGF0IGRvbid0IHN1 cHBvcnQgaXQiKQ0KPj4+IENvLWRldmVsb3BlZC1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPg0KPj4+IENjOiBzdGFibGVAdmdlci5rZXJuZWwub3JnDQo+Pj4gU2lnbmVk LW9mZi1ieTogQ2h1Y2sgWm11ZHppbnNraSA8YnJjaHVja3pAYW9sLmNvbT4NCj4+PiAtLS0N Cj4+PiB2MjogKkFkZCBmb3JjZV9wYXRfZGlzYWJsZWQgdmFyaWFibGUgdG8gZml4ICJub3Bh dCIgb24gWGVuIFBWIChKYW4gQmV1bGljaCkNCj4+PiAgICAgICAqQWRkIHRoZSBuZWNlc3Nh cnkgY29kZSB0byBpbmNvcnBvcmF0ZSB0aGUgIm5vcGF0IiBmaXgNCj4+PiAgICAgICAqdm9p ZCBpbml0X2NhY2hlX21vZGVzKHZvaWQpIC0+IHZvaWQgX19pbml0IGluaXRfY2FjaGVfbW9k ZXModm9pZCkNCj4+PiAgICAgICAqQWRkIEphbiBCZXVsaWNoIGFzIENvLWRldmVsb3BlciAo SmFuIGhhcyBub3Qgc2lnbmVkIG9mZiB5ZXQpDQo+Pj4gICAgICAgKkV4cGFuZCB0aGUgY29t bWl0IG1lc3NhZ2UgdG8gaW5jbHVkZSByZWxldmFudCBwYXJ0cyBvZiB0aGUgY29tbWl0DQo+ Pj4gICAgICAgIG1lc3NhZ2Ugb2YgSmFuIEJldWxpY2gncyBwcm9wb3NlZCBwYXRjaCBmb3Ig dGhpcyBwcm9ibGVtDQo+Pj4gICAgICAgKkZpeCAnZWxzZSBpZiAuLi4geycgcGxhY2VtZW50 IGFuZCBpbmRlbnRhdGlvbg0KPj4+ICAgICAgICpSZW1vdmUgaW5kaWNhdGlvbiB0aGUgYmFj a3BvcnQgdG8gc3RhYmxlIGJyYW5jaGVzIGlzIG9ubHkgYmFjayB0byA1LjE3LnkNCj4+Pg0K Pj4+IEkgdGhpbmsgdGhlc2UgY2hhbmdlcyBhZGRyZXNzIGFsbCB0aGUgY29tbWVudHMgb24g dGhlIG9yaWdpbmFsIHBhdGNoDQo+Pj4NCj4+PiBJIGFkZGVkIEphbiBCZXVsaWNoIGFzIGEg Q28tZGV2ZWxvcGVyIGJlY2F1c2UgSnVlcmdlbiBHcm9zcyBhc2tlZCBtZSB0bw0KPj4+IGlu Y2x1ZGUgSmFuJ3MgaWRlYSBmb3IgZml4aW5nICJub3BhdCIgdGhhdCB3YXMgbWlzc2luZyBm cm9tIHRoZSBmaXJzdA0KPj4+IHZlcnNpb24gb2YgdGhlIHBhdGNoLg0KPj4+DQo+Pj4gVGhl IHBhdGNoIGhhcyBiZWVuIHRlc3RlZCwgaXQgd29ya3MgYXMgZXhwZWN0ZWQgd2l0aCBhbmQg d2l0aG91dCBub3BhdA0KPj4+IGluIHRoZSBYZW4gUFYgRG9tMCBlbnZpcm9ubWVudC4gVGhh dCBpcywgIm5vcGF0IiBjYXVzZXMgdGhlIHN5c3RlbSB0bw0KPj4+IGV4aGliaXQgdGhlIGVm ZmVjdHMgYW5kIHByb2JsZW1zIHRoYXQgbGFjayBvZiBQQVQgc3VwcG9ydCBjYXVzZXMuDQo+ Pj4NCj4+PiAgICBhcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5jIHwgMTYgKysrKysrKysrKysr KystLQ0KPj4+ICAgIDEgZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0 aW9ucygtKQ0KPj4+DQo+Pj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L21tL3BhdC9tZW10eXBl LmMgYi9hcmNoL3g4Ni9tbS9wYXQvbWVtdHlwZS5jDQo+Pj4gaW5kZXggZDVlZjY0ZGRkMzVl Li4xMGEzN2QzMDlkMjMgMTAwNjQ0DQo+Pj4gLS0tIGEvYXJjaC94ODYvbW0vcGF0L21lbXR5 cGUuYw0KPj4+ICsrKyBiL2FyY2gveDg2L21tL3BhdC9tZW10eXBlLmMNCj4+PiBAQCAtNjIs NiArNjIsNyBAQA0KPj4+ICAgIA0KPj4+ICAgIHN0YXRpYyBib29sIF9fcmVhZF9tb3N0bHkg cGF0X2JwX2luaXRpYWxpemVkOw0KPj4+ICAgIHN0YXRpYyBib29sIF9fcmVhZF9tb3N0bHkg cGF0X2Rpc2FibGVkID0gIUlTX0VOQUJMRUQoQ09ORklHX1g4Nl9QQVQpOw0KPj4+ICtzdGF0 aWMgYm9vbCBfX2luaXRkYXRhIHBhdF9mb3JjZV9kaXNhYmxlZCA9ICFJU19FTkFCTEVEKENP TkZJR19YODZfUEFUKTsNCj4+PiAgICBzdGF0aWMgYm9vbCBfX3JlYWRfbW9zdGx5IHBhdF9i cF9lbmFibGVkOw0KPj4+ICAgIHN0YXRpYyBib29sIF9fcmVhZF9tb3N0bHkgcGF0X2NtX2lu aXRpYWxpemVkOw0KPj4+ICAgIA0KPj4+IEBAIC04Niw2ICs4Nyw3IEBAIHZvaWQgcGF0X2Rp c2FibGUoY29uc3QgY2hhciAqbXNnX3JlYXNvbikNCj4+PiAgICBzdGF0aWMgaW50IF9faW5p dCBub3BhdChjaGFyICpzdHIpDQo+Pj4gICAgew0KPj4+ICAgIAlwYXRfZGlzYWJsZSgiUEFU IHN1cHBvcnQgZGlzYWJsZWQgdmlhIGJvb3Qgb3B0aW9uLiIpOw0KPj4+ICsJcGF0X2ZvcmNl X2Rpc2FibGVkID0gdHJ1ZTsNCj4+PiAgICAJcmV0dXJuIDA7DQo+Pj4gICAgfQ0KPj4+ICAg IGVhcmx5X3BhcmFtKCJub3BhdCIsIG5vcGF0KTsNCj4+PiBAQCAtMjcyLDcgKzI3NCw3IEBA IHN0YXRpYyB2b2lkIHBhdF9hcF9pbml0KHU2NCBwYXQpDQo+Pj4gICAgCXdybXNybChNU1Jf SUEzMl9DUl9QQVQsIHBhdCk7DQo+Pj4gICAgfQ0KPj4+ICAgIA0KPj4+IC12b2lkIGluaXRf Y2FjaGVfbW9kZXModm9pZCkNCj4+PiArdm9pZCBfX2luaXQgaW5pdF9jYWNoZV9tb2Rlcyh2 b2lkKQ0KPj4+ICAgIHsNCj4+PiAgICAJdTY0IHBhdCA9IDA7DQo+Pj4gICAgDQo+Pj4gQEAg LTI5Miw3ICsyOTQsNyBAQCB2b2lkIGluaXRfY2FjaGVfbW9kZXModm9pZCkNCj4+PiAgICAJ CXJkbXNybChNU1JfSUEzMl9DUl9QQVQsIHBhdCk7DQo+Pj4gICAgCX0NCj4+PiAgICANCj4+ PiAtCWlmICghcGF0KSB7DQo+Pj4gKwlpZiAoIXBhdCB8fCBwYXRfZm9yY2VfZGlzYWJsZWQp IHsNCj4+DQo+PiBDYW4gd2UganVzdCByZW1vdmUgdGhpcyBtb2RpZmljYXRpb24gYW5kIC4u Lg0KPj4NCj4+PiAgICAJCS8qDQo+Pj4gICAgCQkgKiBObyBQQVQuIEVtdWxhdGUgdGhlIFBB VCB0YWJsZSB0aGF0IGNvcnJlc3BvbmRzIHRvIHRoZSB0d28NCj4+PiAgICAJCSAqIGNhY2hl IGJpdHMsIFBXVCAoV3JpdGUgVGhyb3VnaCkgYW5kIFBDRCAoQ2FjaGUgRGlzYWJsZSkuDQo+ Pj4gQEAgLTMxMyw2ICszMTUsMTYgQEAgdm9pZCBpbml0X2NhY2hlX21vZGVzKHZvaWQpDQo+ Pj4gICAgCQkgKi8NCj4+PiAgICAJCXBhdCA9IFBBVCgwLCBXQikgfCBQQVQoMSwgV1QpIHwg UEFUKDIsIFVDX01JTlVTKSB8IFBBVCgzLCBVQykgfA0KPj4+ICAgIAkJICAgICAgUEFUKDQs IFdCKSB8IFBBVCg1LCBXVCkgfCBQQVQoNiwgVUNfTUlOVVMpIHwgUEFUKDcsIFVDKTsNCj4+ PiArCX0gZWxzZSBpZiAoIXBhdF9icF9lbmFibGVkKSB7DQo+Pg0KPj4gLi4uIHVzZQ0KPj4N Cj4+ICsJfSBlbHNlIGlmICghcGF0X2JwX2VuYWJsZWQgJiYgIXBhdF9mb3JjZV9kaXNhYmxl ZCkgew0KPj4NCj4+IGhlcmU/DQo+Pg0KPj4gVGhpcyB3aWxsIHJlc3VsdCBpbiB0aGUgZGVz aXJlZCBvdXRjb21lIGluIGFsbCBjYXNlcyBJTU86IElmIFBBVCB3YXNuJ3QNCj4+IGRpc2Fi bGVkIHZpYSAibm9wYXQiIGFuZCB0aGUgUEFUIE1TUiBoYXMgYSBub24temVybyB2YWx1ZSAo ZnJvbSBCSU9TIG9yDQo+PiBIeXBlcnZpc29yKSBhbmQgUEFUIGhhcyBiZWVuIGRpc2FibGVk IGltcGxpY2l0bHkgKGUuZy4gZHVlIHRvIGxhY2sgb2YNCj4+IE1UUlIpLCB0aGVuIFBBVCB3 aWxsIGJlIHNldCB0byAiZW5hYmxlZCIgYWdhaW4uDQo+IA0KPiBXaXRoIHRoYXQsIHlvdSBj YW4gYWxzbyBjb21wbGV0ZWx5IHJlbW92ZSB0aGUgbmV3IEJvb2xlYW4gLSBpdA0KPiB3aWxs IGJlIGEgbWVhbmluZ2xlc3MgdmFyaWFibGUgd2FzdGluZyBtZW1vcnkuIFRoaXMgd2lsbCBh bHNvIG1ha2UNCg0KTm8sIGl0IGlzIG1ha2luZyBhIGRpZmZlcmVuY2Ugd2l0aCAibm9wYXQi IGhhdmluZyBiZWVuIHNwZWNpZmllZC4NCg0KSW4gdGhlIFhlbiBQViBjYXNlIHdlIHdpbGwg aGF2ZSBwYXRfYnBfZW5hYmxlZCA9PSBmYWxzZSBkdWUgdG8gdGhlDQpsYWNrIG9mIE1UUlIu IFdlIGRvbid0IHdhbnQgdG8gc2V0IGl0IHRvIHRydWUgaWYgIm5vcGF0IiBoYXMgYmVlbg0K c3BlY2lmaWVkIG9uIHRoZSBjb21tYW5kIGxpbmUsIHNvIHBhdF9mb3JjZV9kaXNhYmxlZCBz aG91bGQgbm90IGJlDQp0cnVlIHdoZW4gd2UgYXJlIHNldHRpbmcgcGF0X2JwX2VuYWJsZWQg dG8gdHJ1ZSBhZ2Fpbi4NCg0KPiBteSBwYXRjaCBtb3JlIG9yIGxlc3MgZG8gd2hhdCBKYW4n cyBwYXRjaCBkb2VzIC0gdGhlICJub3BhdCIgb3B0aW9uDQo+IHdpbGwgbm90IGNhdXNlIHRo ZSBzaXR1YXRpb24gd2hlbiB0aGUgUEFUIE1TUiBkb2VzIG5vdCBtYXRjaCB0aGUNCj4gc29m dHdhcmUgdmlldy4gU28geW91IGFyZSBiYXNpY2FsbHkgcHJvcG9zaW5nIGp1c3QgZ29pbmcg YmFjayB0bw0KPiBteSBvcmlnaW5hbCBwYXRjaCwgYWZ0ZXIgZml4aW5nIHRoZSBzdHlsZSBw cm9ibGVtcywgb2YgY291cnNlLiBUaGF0DQo+IGFsc28gd291bGQgc29sdmUgdGhlIHByb2Js ZW0gb2YgbmVlZGluZyBKYW4ncyBTLW8tYi4gSSBhbSBpbmNsaW5lZCwNCj4gaG93ZXZlciwg dG8gd2FpdCBmb3IgYSBtYWludGFpbmVyIHdobyBoYXMgcG93ZXIgdG8gYWN0dWFsbHkgZG8g dGhlDQo+IGNvbW1pdCwgdG8gbWFrZSBhIGNvbW1lbnQuIFlvdXIgUi1iIHRvIG15IHYyIGRp ZCBub3QgaGF2ZSBtdWNoIGNsb3V0DQo+IHdpdGggdGhlIGFjdHVhbCBtYWludGFpbmVycywg YXMgZmFyIGFzIEkgY2FuIHRlbGwuIEkgYW0gc29tZXdoYXQgYW5ub3llZA0KPiB0aGF0IGl0 IHdhcyBhdCB5b3VyIHN1Z2dlc3Rpb24gdGhhdCBteSB2MiBlbmRlZCB1cCBjb25mdXNpbmcg dGhlDQo+IG1haW4gaXNzdWUsIHRoZSByZWdyZXNzaW9uLCB3aXRoIHRoZSByZWQgaGVycmlu ZyBvZiB0aGUgIm5vcGF0Ig0KPiBvcHRpb24uDQoNCkknbSBzb3JyeSBmb3IgdGhhdC4NCg0K DQpKdWVyZ2VuDQo= --------------uCPvqSlE4vvTlN2SPxRYkRDj Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------uCPvqSlE4vvTlN2SPxRYkRDj-- --------------bxKcZEHZlX70PgXzH2z1YL6d-- --------------EQ4qcO3BsuuirRREa53dJEtQ Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLQ65wFAwAAAAAACgkQsN6d1ii/Ey9e Qwf/UHgmea7UlSta7tPdTRjaaf0ASXWWmDzU2Qn4O93SjjaNQUcSmKYashsA7ApSoOLpl+hRblRG 9cmQCDsZ1tFgTsz9svEtKKVX4DMeWf+ToAtWmVt9nj54IpNCrFS8Fw7R+yUTmTqOE9tMk0mFP43i 4ofYa99WvCtMOLvbN8GY7YQK3VrlJ8MSWYz7CByyomp8tNyeELvVd/oIzVbZrJCO2FSm0Rr6kjsp /IsPLGdomu2HPv+EsQG9J/JjNVB7ZTC/mvdUrfAwgpXqprjZgxCiSjOearn4TKWmEiAJQ1MkcCG0 mXG9XuLeVOcjV7JLQZcpLTxvw6g2cVImhFAZi3lflg== =SqTB -----END PGP SIGNATURE----- --------------EQ4qcO3BsuuirRREa53dJEtQ-- From xen-devel-bounces@lists.xenproject.org Fri Jul 15 04:42:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 04:42:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367902.599064 (Exim 4.92) (envelope-from ) id 1oCDAB-0001Jd-13; Fri, 15 Jul 2022 04:42:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367902.599064; Fri, 15 Jul 2022 04:42:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCDAA-0001JW-U3; Fri, 15 Jul 2022 04:42:50 +0000 Received: by outflank-mailman (input) for mailman id 367902; Fri, 15 Jul 2022 04:42:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCDA9-0001JN-8h for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 04:42:49 +0000 Received: from sonic317-21.consmr.mail.gq1.yahoo.com (sonic317-21.consmr.mail.gq1.yahoo.com [98.137.66.147]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 906f05f1-03f8-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 06:42:46 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 04:42:42 +0000 Received: by hermes--production-bf1-58957fb66f-88chf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID ed1b76fa43d6095b5b2fe5d241aa346f; Fri, 15 Jul 2022 04:42:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 906f05f1-03f8-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657860162; bh=PdXtmKC/fMFYRiHLmCdqe073IqBMbeVVyHRlJzaM88E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=D9ej/y6R1UgtrKbFyb5WwflsOaoHe3KWTnpSXldMMMHi/aTXaN5et6s/ppHcdnBv9g/lAhjVieYrOwynMfivnZM4t4HVN8WCdl5RfSUe1zxF0QLx5AIdLyjJ5moqkHdTTAHYDeWO7/yGx1Dx1SxFMnOW957rwzMR2xnE/RpgLu2/zOoddszoEm0PHcSkyrQIHN8nN5qheiy5RZKsQnWZbs/2bmsR4u2u1DlBphhRSn5Ir12e2wHPNOolwPhV/mrCYL2i0QS9+4LBSwYc8QaBspa+aFVClqZPP3zhxMx4b5OkHF8s8gL9wKUliQsBxP8c6l50CFfYeaSTWiZ4vdpflg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657860162; bh=Io+PiMS/j1k6QqUwRDZp1H+ycGnjKn1PqrkBhFpVQZk=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=rSu4N88zCLEu9IOajFNBTzCGo01XRJ270e3GVxKrp6b+ua7Zc6rTRy9eMfGEE0gC2LsQ9V4ZXMOAlWjU9T2kVkGuidluaoaEySPpOJfVoBorsa7GlAkwbsYWg4akIipF6ni6v+qCiX6DKLjn14z9hoWSWzm3aPx7I9Z37n7BLjedyRmrnGjoadlCp6gE2OuC/27aQL8JbFbZBM2Wl2yjtvbmsioNVZbQZ/qLh4/yfaVte2VcXJw0GX44h1Wnyk3YyQaaiTGRH4SDLiJBbeeg8mpjnocaaXMG9XVdexkki+9BQswVmFIEsQYgx9H4/i0baF5PhTifdBuDtR8EBSKHiA== X-YMail-OSG: Fgzng9wVM1kGWsn6SvqtrQ61hNeMGMssO5ecVsDJXa2.aDHVw_o9sICVMT8sWwN KA3dZ8ZKB.gmSaXIepaZoQ3wcXWpCX14tTrU9ZOO2SvMbqDNFszAkdAkstd3R47bvffcDpT2EDos ATq.iab5u7phl1cjG9zaeg3ZXZKHZuuylnGpLeZPF3cOt2kXBxYs09C5viBPpaBy4C5FkTvxiXDJ 8ufqLqOAT2rd3SaSvzY0awYeSsG2M7Rj7_gsO2zCZ.jhZ6ceCrXguX.7LBb1i82gMk7RHFBtyOP3 VLCHLnErxQiQcJW8pH.hWXE3RgKa3WRu.e0VGqTBH4DF.YVKss0d5xjXkCLnhmLz22PYyNc1D0xM kKOCqdlKh9Q_p39Zwct204_bSOyUdJBxb80QEc.uuj3wswtqqpVrhgFolDaJKD.FkQtkkN6VG5MQ p3G9b_UmSWAKoFMT1q4L4X1IacHoC5fbsNfK66PJ2__.L8QAORZ.NF5X8xg_t7NuRrlDekaebbUf clrq50Rwuk.6bV1GhcCLDLXav9PW_bXjiVRdoRUn4s2uSo7yb5n8eMDO0za0tr01ArxPnqpCqhN. gNngEaD56kpXB85B95Vd3sPdkUnh6RsFsnqwVwBT6CcMZqrehH7xSzI2Mhu7YGXJpQnTS3hekpnj u_g7q1O_m8OTNCyg5bncPhAc1QGASRCCpab5g3cyx7gSyXO5BSvgWtGVJdfWSmnml1h4NioAgqBg aKU_plszWMO0J6vdilDbAOHhA_PWc6qnJELdHLBJKz4G4Vo9Z5eRtftV_JztUrXmECFanEp9_VV6 fMcSKlDN5zrBxYhTb_taJ2MJ0tF_5qYc0_tNldCt_xnEf3dTV2o.51Aklli2RB5z3YmRnog3gCo4 sV6iolJGoMU.0B6MxMid2g.8UJPb87EMJAjktEX8dNVpVgy41mDtZFmfi214B8mUhexgwyBGMrhF RGpY_17OysIh2Zqg_CeN7_5fd0hJeevDVkbDvyRlb.SPm9zjyy9HWpiMGft1e0nzLYdy7l4ddkBF 7c35HtZcUYsfOxkamZdWIibgSFepr4DvxvuLYgWOepUCmrIHCBN5Nazs.pwA.8XjtWejxnUMbcR5 FpCEgZuW5POXEol3kenqg84tx_aqSJMQZaXYWxbpPRlaqA3TjvQNvtHja4zJMrSJpd_8f4l15veA 9Cpu9VkKSFlQeiSRFIqQnio1hi8mKCXTsheRivTskEeQZALwYdWcPZp18G7Y4wQT7TRbwqrxPjD. 1PhbhuBw1q9AUigm0PGDDBQRYYrGAZAf7ks436METF0bNxD4W1v0VqcTqVbrPDwz7PHz6Zl8teD_ GbAEsXBCYmbJi.HMZToRjoOwTcS7mgsgEJjJkk5sMamLJzwb2pIAlPPhjs6lAj5l8D5vL6jcI4RY ZxD1BbDb4WU4uHnkxFBxfR_qKkfj4dKR5C1Ti02RyyvkPk1zEmmmlUQGbHuG1_B.lBYx8JoaMzPC cDC5FRcT.wXksOZyDj.XS.RXBljdGzsYnXdTJ9l1bm7avcrAZxMKe_ohC3TMDy4iwUX5jAuqupWW i.OmUm9Cyc879HT4pE7La4iWXbn19QJsL1G2BhsY5Vy8u1Y_dhomlQwKxulVfzjBAFG089XhAu4L ysQSYfvmKoJny2y_xJZELXijlp2jfmwVJs86V9RQsHRPbnVWLXPsvDevfrBtVoc9DkRHyJnQ31nx WM9mFMZDmxN2RCI8t8FOPVeu1zAA6IDIUkjEn4Qq6m0YLmD3D.fbQRL4vGeKvyqN3g4kGPcsoPWQ EpwbocOBmkwEIHSa98ShiT0kb.J._Viy0BDxUXckTdb2qJNqJw0I5LodWAdlIcjgQ7K5pBhzn3Gb Ei6y206BzUAou02D6CfN3YO3GlxSRSf0OP1jwAZrMwM0HMY4KrybVRhJmVA5UgQcmsDiBqpmDOZd VscCSTJe2XeLQVQxtUbyEbIF64PXKhHziKpICeRN3zKaowGmJy0PxSZ4rPhS83kg9077m4YVacjn J31Qd3fCw5wKkJ4A_EbxVdaU8SE6cRCjVoUK4uqSoW9g5vWCIr2wh0qUkJ_yir8LXaz1_luWi1d_ 4ScrhZpEapXWZJ0lWQWWj697RlYWG8KPBJKle75FK6V1w7WuD2i79A7iBLqpRhwzUbJ098EhqQpj nJPSDXcBz7xdtaEPnYNeDsIFaptZ8yKvoR2zxXXxr5kKW.jrLnKqbH6X.46.67Q52uU2pq3PWmBY vHBlgSv134Q2zctbXVPxOx0I9 X-Sonic-MF: Message-ID: Date: Fri, 15 Jul 2022 00:42:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7659 On 7/15/2022 12:22 AM, Juergen Gross wrote: > On 15.07.22 04:19, Chuck Zmudzinski wrote: > > On 7/14/2022 1:40 AM, Juergen Gross wrote: > >> On 13.07.22 03:36, Chuck Zmudzinski wrote: > >>> The commit 99c13b8c8896d7bcb92753bf > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > >>> incorrectly failed to account for the case in init_cache_modes() when > >>> CPUs do support PAT and falsely reported PAT to be disabled when in > >>> fact PAT is enabled. In some environments, notably in Xen PV domains, > >>> MTRR is disabled but PAT is still enabled, and that is the case > >>> that the aforementioned commit failed to account for. > >>> > >>> As an unfortunate consequnce, the pat_enabled() function currently does > >>> not correctly report that PAT is enabled in such environments. The fix > >>> is implemented in init_cache_modes() by setting pat_bp_enabled to true > >>> in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > >>> to account for. > >>> > >>> This approach arranges for pat_enabled() to return true in the Xen PV > >>> environment without undermining the rest of PAT MSR management logic > >>> that considers PAT to be disabled: Specifically, no writes to the PAT > >>> MSR should occur. > >>> > >>> This patch fixes a regression that some users are experiencing with > >>> Linux as a Xen Dom0 driving particular Intel graphics devices by > >>> correctly reporting to the Intel i915 driver that PAT is enabled where > >>> previously it was falsely reporting that PAT is disabled. Some users > >>> are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > >>> Dom0 are experiencing reduced graphics performance because the keying of > >>> the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > >>> means that in particular graphics frame buffer accesses are quite a bit > >>> less performant than possible without this patch. > >>> > >>> Also, with the current code, in the Xen PV environment, PAT will not be > >>> disabled if the administrator sets the "nopat" boot option. Introduce > >>> a new boolean variable, pat_force_disable, to forcibly disable PAT > >>> when the administrator sets the "nopat" option to override the default > >>> behavior of using the PAT configuration that Xen has provided. > >>> > >>> For the new boolean to live in .init.data, init_cache_modes() also needs > >>> moving to .init.text (where it could/should have lived already before). > >>> > >>> Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > >>> Co-developed-by: Jan Beulich > >>> Cc: stable@vger.kernel.org > >>> Signed-off-by: Chuck Zmudzinski > >>> --- > >>> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich) > >>> *Add the necessary code to incorporate the "nopat" fix > >>> *void init_cache_modes(void) -> void __init init_cache_modes(void) > >>> *Add Jan Beulich as Co-developer (Jan has not signed off yet) > >>> *Expand the commit message to include relevant parts of the commit > >>> message of Jan Beulich's proposed patch for this problem > >>> *Fix 'else if ... {' placement and indentation > >>> *Remove indication the backport to stable branches is only back to 5.17.y > >>> > >>> I think these changes address all the comments on the original patch > >>> > >>> I added Jan Beulich as a Co-developer because Juergen Gross asked me to > >>> include Jan's idea for fixing "nopat" that was missing from the first > >>> version of the patch. > >>> > >>> The patch has been tested, it works as expected with and without nopat > >>> in the Xen PV Dom0 environment. That is, "nopat" causes the system to > >>> exhibit the effects and problems that lack of PAT support causes. > >>> > >>> arch/x86/mm/pat/memtype.c | 16 ++++++++++++++-- > >>> 1 file changed, 14 insertions(+), 2 deletions(-) > >>> > >>> diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > >>> index d5ef64ddd35e..10a37d309d23 100644 > >>> --- a/arch/x86/mm/pat/memtype.c > >>> +++ b/arch/x86/mm/pat/memtype.c > >>> @@ -62,6 +62,7 @@ > >>> > >>> static bool __read_mostly pat_bp_initialized; > >>> static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); > >>> +static bool __initdata pat_force_disabled = !IS_ENABLED(CONFIG_X86_PAT); > >>> static bool __read_mostly pat_bp_enabled; > >>> static bool __read_mostly pat_cm_initialized; > >>> > >>> @@ -86,6 +87,7 @@ void pat_disable(const char *msg_reason) > >>> static int __init nopat(char *str) > >>> { > >>> pat_disable("PAT support disabled via boot option."); > >>> + pat_force_disabled = true; > >>> return 0; > >>> } > >>> early_param("nopat", nopat); > >>> @@ -272,7 +274,7 @@ static void pat_ap_init(u64 pat) > >>> wrmsrl(MSR_IA32_CR_PAT, pat); > >>> } > >>> > >>> -void init_cache_modes(void) > >>> +void __init init_cache_modes(void) > >>> { > >>> u64 pat = 0; > >>> > >>> @@ -292,7 +294,7 @@ void init_cache_modes(void) > >>> rdmsrl(MSR_IA32_CR_PAT, pat); > >>> } > >>> > >>> - if (!pat) { > >>> + if (!pat || pat_force_disabled) { > >> > >> Can we just remove this modification and ... > >> > >>> /* > >>> * No PAT. Emulate the PAT table that corresponds to the two > >>> * cache bits, PWT (Write Through) and PCD (Cache Disable). > >>> @@ -313,6 +315,16 @@ void init_cache_modes(void) > >>> */ > >>> pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) | > >>> PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC); > >>> + } else if (!pat_bp_enabled) { > >> > >> ... use > >> > >> + } else if (!pat_bp_enabled && !pat_force_disabled) { > >> > >> here? > >> > >> This will result in the desired outcome in all cases IMO: If PAT wasn't > >> disabled via "nopat" and the PAT MSR has a non-zero value (from BIOS or > >> Hypervisor) and PAT has been disabled implicitly (e.g. due to lack of > >> MTRR), then PAT will be set to "enabled" again. > > > > With that, you can also completely remove the new Boolean - it > > will be a meaningless variable wasting memory. This will also make > > No, it is making a difference with "nopat" having been specified. > > In the Xen PV case we will have pat_bp_enabled == false due to the > lack of MTRR. We don't want to set it to true if "nopat" has been > specified on the command line, so pat_force_disabled should not be > true when we are setting pat_bp_enabled to true again. > > > my patch more or less do what Jan's patch does - the "nopat" option > > will not cause the situation when the PAT MSR does not match the > > software view. So you are basically proposing just going back to > > my original patch, after fixing the style problems, of course. That > > also would solve the problem of needing Jan's S-o-b. I am inclined, > > however, to wait for a maintainer who has power to actually do the > > commit, to make a comment. Your R-b to my v2 did not have much clout > > with the actual maintainers, as far as I can tell. I am somewhat annoyed > > that it was at your suggestion that my v2 ended up confusing the > > main issue, the regression, with the red herring of the "nopat" > > option. > > I'm sorry for that. I accept your apology. A few days back you indicated Boris was willing to go along with the approach I was suggesting. Do you have any idea why he didn't give me an R-b for either my original patch or v2 or at least tell me what I would have to do to get his R-b? Chuck > > > Juergen From xen-devel-bounces@lists.xenproject.org Fri Jul 15 05:01:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 05:01:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367908.599075 (Exim 4.92) (envelope-from ) id 1oCDRn-0004YT-Hd; Fri, 15 Jul 2022 05:01:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367908.599075; Fri, 15 Jul 2022 05:01:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCDRn-0004YM-EK; Fri, 15 Jul 2022 05:01:03 +0000 Received: by outflank-mailman (input) for mailman id 367908; Fri, 15 Jul 2022 05:01:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCDRm-0004YG-HD for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 05:01:02 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ecf68e1-03fb-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 07:01:01 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1oCDRN-0004qt-V5; Fri, 15 Jul 2022 07:00:38 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ecf68e1-03fb-11ed-924f-1f966e50362f Message-ID: <463dd8be-cdfe-d4c2-35b4-1d6b13f2825f@leemhuis.info> Date: Fri, 15 Jul 2022 07:00:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski , Chuck Zmudzinski , linux-kernel@vger.kernel.org Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Jan Beulich , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> From: Thorsten Leemhuis In-Reply-To: <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1657861261;393b77c6; X-HE-SMSGID: 1oCDRN-0004qt-V5 On 15.07.22 04:07, Chuck Zmudzinski wrote: > On 7/14/2022 1:30 AM, Thorsten Leemhuis wrote: >> On 13.07.22 03:36, Chuck Zmudzinski wrote: >>> The commit 99c13b8c8896d7bcb92753bf >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") >>> incorrectly failed to account for the case in init_cache_modes() when >>> CPUs do support PAT and falsely reported PAT to be disabled when in >>> fact PAT is enabled. In some environments, notably in Xen PV domains, >>> MTRR is disabled but PAT is still enabled, and that is the case >>> that the aforementioned commit failed to account for. >>> >>> As an unfortunate consequnce, the pat_enabled() function currently does >>> not correctly report that PAT is enabled in such environments. The fix >>> is implemented in init_cache_modes() by setting pat_bp_enabled to true >>> in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed >>> to account for. >>> >>> This approach arranges for pat_enabled() to return true in the Xen PV >>> environment without undermining the rest of PAT MSR management logic >>> that considers PAT to be disabled: Specifically, no writes to the PAT >>> MSR should occur. >>> >>> This patch fixes a regression that some users are experiencing with >>> Linux as a Xen Dom0 driving particular Intel graphics devices by >>> correctly reporting to the Intel i915 driver that PAT is enabled where >>> previously it was falsely reporting that PAT is disabled. Some users >>> are experiencing system hangs in Xen PV Dom0 and all users on Xen PV >>> Dom0 are experiencing reduced graphics performance because the keying of >>> the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) >>> means that in particular graphics frame buffer accesses are quite a bit >>> less performant than possible without this patch. >>> >>> Also, with the current code, in the Xen PV environment, PAT will not be >>> disabled if the administrator sets the "nopat" boot option. Introduce >>> a new boolean variable, pat_force_disable, to forcibly disable PAT >>> when the administrator sets the "nopat" option to override the default >>> behavior of using the PAT configuration that Xen has provided. >>> >>> For the new boolean to live in .init.data, init_cache_modes() also needs >>> moving to .init.text (where it could/should have lived already before). >>> >>> Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") >> >> BTW, "submitting-patches.rst" says it should just be "the first 12 >> characters of the SHA-1 ID" > > Actually it says "at least", /me looks a bit confused, as he quoted above directly from that file Ohh, that "at least" is in a different section of the document. :-D For the fixes tag is explicitly "12 characters": ``` If your patch fixes a bug in a specific commit, e.g. you found an issue using git bisect, please use the ‘Fixes:’ tag with the first 12 characters of the SHA-1 ID, and the one line summary. ``` > so more that 12 is It is probably safest > to put the entire SHA-1 ID in because of the possibility of > a collision. Yes, sure, but it's a little mess if everybody uses something different and 12 characters is what was agreed on as "good enough" for now. > At least that's how I understand what > submitting-patches.rst. > >>> Co-developed-by: Jan Beulich >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Chuck Zmudzinski >> >> Sorry, have to ask: is this supposed to finally fix this regression? >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > Yes that's the first report I saw to lkml about this isssue. Thx for confirming. > So if I submit a v3 I will include that. Thx. > But my patch does not have a sign-off from the > Co-developer as I mentioned in a message earlier today, and the > discussion that has ensued leads me to think a better solution is to just > revert the commit in the i915 driver instead, and leave the bigger questions > for Juergen Gross and his plans to re-work the x86/PAT code in September, > as he said on this thread in the last couple of days. This patch is dead > now, > as far as I can tell, because the Co-developer is not cooperating. k, thx for the quick summary, this whole thing is a bit hard to follow for me: I can only briefly look into most regressions, as there is only so much time in a day... Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. From xen-devel-bounces@lists.xenproject.org Fri Jul 15 06:00:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 06:00:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367917.599097 (Exim 4.92) (envelope-from ) id 1oCENV-0004Fl-9B; Fri, 15 Jul 2022 06:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367917.599097; Fri, 15 Jul 2022 06:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCENV-0004Fe-67; Fri, 15 Jul 2022 06:00:41 +0000 Received: by outflank-mailman (input) for mailman id 367917; Fri, 15 Jul 2022 06:00:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCENT-0003xG-9E for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 06:00:39 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2071.outbound.protection.outlook.com [40.107.21.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 735e7e3b-0403-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 08:00:38 +0200 (CEST) Received: from DU2PR04CA0067.eurprd04.prod.outlook.com (2603:10a6:10:232::12) by VI1PR08MB2704.eurprd08.prod.outlook.com (2603:10a6:802:1b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Fri, 15 Jul 2022 06:00:09 +0000 Received: from DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:232:cafe::f7) by DU2PR04CA0067.outlook.office365.com (2603:10a6:10:232::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17 via Frontend Transport; Fri, 15 Jul 2022 06:00:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT060.mail.protection.outlook.com (100.127.142.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 06:00:09 +0000 Received: ("Tessian outbound e5f49c5d38f9:v122"); Fri, 15 Jul 2022 06:00:09 +0000 Received: from 5417a9e41465.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5717585E-11E4-4806-A2E0-614EB68FE600.1; Fri, 15 Jul 2022 05:59:59 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5417a9e41465.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 05:59:59 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DB6PR0801MB1974.eurprd08.prod.outlook.com (2603:10a6:4:72::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.21; Fri, 15 Jul 2022 05:59:57 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%8]) with mapi id 15.20.5438.012; Fri, 15 Jul 2022 05:59:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 735e7e3b-0403-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WLKcgiuWGMxRRiBFZpLj7iUkIAonHCw3KasOAVFdLMl5NPgo+goyvL18fhtW0SABtR01cNVkaP5s5q1fvwB3lxOjXJc2QFAoU45HXrFfxHrellW8ngyn2Qbar0AORv9Wcx5sJ33RbUq5lq3dFE1KNpooz5a4l+9x0EPOWXYbb5gfdhB4ORyEwXFpnvT+R9zM+niKhLE2Orz6/f0eZe4eZdgbuP8gmgESZL2Pb8SIkaIY1UeV6C/ey6ySfOho5P0EN0kqbrVYVS7UgH109Mwy8oRD9k2ns49f8v1I/OZEtdH1JZPSombmOj8rhspIxphnQLqnhjIVpYrPxFNYPXE91Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPOYveqwoRW4k7OC0VPBqWQKtvV8eUY2IV2jDi9z8TM=; b=GZzJDNo+a/MDdQRmgZN6Ha7fCPHqWu2cnNSb28voMSyWBE07VLN2+7PpPSTYjTatQuxQ2ymj2L6OIGPIjPpvjPXBt/thX+VNiqTe/2FJ2uzQVC8NAJU5uE8TMDxNK8C2eIOSYGdL0b2YLrmBZfMolKjaju9HZCd2VQINuam6vKsITwhamls8ro0HBLzRZOIIjtGo9TEJEGfq1lsnjso1+dVk/fYmIpzk2GNUccUXc1apzF8DPpt22iBo0Ded4qs02LX5FnEtlUU2/Ef3CRdFXQBizVt6bHYfQ9apII7A9LDYBjnsz7kj0oQZyX0LESaTdDMoVkhG27n/OizntxV10g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPOYveqwoRW4k7OC0VPBqWQKtvV8eUY2IV2jDi9z8TM=; b=jwT56aKi8Qb7eOhV/p1YI3R2wiA5T0i4wayLLIKqpfVC2wj928Tyuyi0kDwcKRyB3YQDJ+653K5LPzAGHsAQXiXl2m824Tj4mIgtM4UMvDD/BZgtcWel4AcXd1ahFeQyofu6gCEAhX04uYgiX2rjs5z7anoEvHoDPLVyd42i7Lw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1qPEzUg0SIQOMQ/FjcdB0zaKi7SUGgNCrdsPBM4jTxjfhU/jQb0a6BI3+pfoVsUxSBD2k2M4H+ouivXwHkWiVs5CAC29FNQ5k8HQlz8aiCqgq+P86WKhFxRJjxPWbqAVchbajbNBBmKB0O4Aam2v0mIq5JyeqGg/cfj6DkUBpc7VY5yMe3tJOgRBd+CCFrcfe6/MYhseLsMqCEiBi7bQvrmAgNYf+2w/NSBLwsZ902nUQLLx8zXzL4SL6BG3bsHhPQ/aXwk27YdUjsXecVt+liExzGplnINv9/5M1P+PbzzgdxgQDP7O5CcwbSTnhnMRZj8INyzDmOHFeCANEDfqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dPOYveqwoRW4k7OC0VPBqWQKtvV8eUY2IV2jDi9z8TM=; b=Q2Ss156bD30jb48avlDc+R6As0rjYXEf2aN73KVaDrZ3F4rPRtkzwkSqgw/NfJoxdxoGKadYA4La1oHKoa4gPN0aSjtAcGIvvU0XitNl7qipqO/IIf+BnQ8whsimQ4DEZ+sYgy9OcCZGyeQK318QXo0wuyjk9JvhJUjYP2RtF680fRzfAPFsc5pCW1+sCRTSMn2QcjWSjxbUhZ+cnjXJRcieM8lfLQPZw03pyWn9ddQ2yxuHplWNzdIZ1fjwaLlxF0oqddWOyXLudcfAKFW0NNw0XT9wXLuABvK93MJMyi0zzNJxBGMI9fue+bawo7knrAnHBU5NW1R9XGTwu0m3lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dPOYveqwoRW4k7OC0VPBqWQKtvV8eUY2IV2jDi9z8TM=; b=jwT56aKi8Qb7eOhV/p1YI3R2wiA5T0i4wayLLIKqpfVC2wj928Tyuyi0kDwcKRyB3YQDJ+653K5LPzAGHsAQXiXl2m824Tj4mIgtM4UMvDD/BZgtcWel4AcXd1ahFeQyofu6gCEAhX04uYgiX2rjs5z7anoEvHoDPLVyd42i7Lw= From: Henry Wang To: "xen-devel@lists.xenproject.org" CC: "Daniel P. Smith" , George Dunlap , Jan Beulich , "christopher.w.clark@gmail.com" , "christopher.clark@starlab.io" , Bertrand Marquis , Julien Grall , Julien Grall , Stefano Stabellini , "sstabellini@kernel.org" , "jgross@suse.com" , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Anthony PERARD , Volodymyr Babchuk , Wei Liu , "Wei Liu (LSG)" Subject: RE: Xen 4.17: Proposed release schedule Thread-Topic: Xen 4.17: Proposed release schedule Thread-Index: AdiSei6vjIC3DQhRQxe+drETJuVp3wFlFvgQ Date: Fri, 15 Jul 2022 05:59:56 +0000 Message-ID: References: In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C652778E3AB11A4B99D2116111B11912.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: a344b3a5-b686-4b48-182b-08da66274624 x-ms-traffictypediagnostic: DB6PR0801MB1974:EE_|DBAEUR03FT060:EE_|VI1PR08MB2704:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4gIalwd+8uHDKg6Q5jwezs3kVXvGwnInow4WjoDibQCNtwLVL6x3k6PE4wEmPHSWjI4IG20uj7G7bjuI4Y6OC7uw7Yn7YIskBSe9iCtj8+qNQBG5alaKiEGj1iqr2oG8Mo4sP91EKz7KrlXQrE5Rg20UjjdsncAlWAMlA2VOFChWupCmqirIwc9hzxn+fb++joZOPa/ZNdJXLn+jIKbBMwbbMUNC/I4aWyzj4w7pch3dyvdSONYvSZF3WRra8WjbfKNLzMEAsavxBN6+LNh6RgFiCPjCHIIWyWhp6U1QiJxQTkx17guR3tWQDEIx+7k70GcTNCv9LudmO/h0pzM/9nDtTbym/Qvc2mzUrqHxu3oUFkCTL+efdfUKyLpkueATIv8MrC33ds1/+Op/s7LjdNygdPGdowvHLaZcE4x5+XTc6Ug2Inq26neWbLaSzutDcH8WzILs8LSnQ2FmQbb/4l857KzNCX+38McISxW7ClykQGriTPqNj/8XNqIdUOFoz1jGmDqrZyTxHmKfuRIAp9q/a8qvpJTK1VCsVnPHJDh5dDYDsIlLdaitYicO28oy+NVpzcfZsEid8ypqhfvyZLsB4yRiD75ojnXkg3RTac4v8YSZMDodfzsMTIchF6DSE12RJZDJbR2TRcNHK5+uj/cR0IH6jXGdTOmvRanklWHkdW02yJXeoiLKr5bVzMmPgGcJOqdSo4w5AmjoptAAveZEai1W9ypg6RO5lnoebbPVMmJ8b0l+b10EVI1Ye3ODsJ6Bo2TTbKXTrCEcdKQPfbhxv+71ypEZB9Opn8ogWhbeOPaZUe4SAQBTRw/ovqZT X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(8936002)(9686003)(55016003)(2906002)(4744005)(33656002)(6506007)(83380400001)(41300700001)(64756008)(26005)(4326008)(478600001)(66446008)(186003)(8676002)(76116006)(66946007)(71200400001)(122000001)(7416002)(7696005)(66556008)(66476007)(38100700002)(38070700005)(52536014)(54906003)(86362001)(6916009)(5660300002)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1974 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5427f22d-df6f-4fb2-5ea3-08da66273e79 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yWIgcWRGV7o3UljweiWnx+xWg8TvB9ty0ceqpyzG2dDPEv0asOQpIFhnvD4VfXmJhggDOegtIwxz0O+Vo/jzUXcrjn4za6XjdDhD8TLlqP6T4KjiYVJZyJQRtdL0jtrj7JwMZBf9sxiaEdNmeg+/rYQXSwvOcEJg9UbjNYbxJybycrjW8r96GIQkEzGwzrt1aYOq44DDsyaTInnYemPO8+rWGkS1k+7R8oD3+GakRsCVcNQyRy4IFPo/7LM3/rHsSGdqQV6bms21uL9Y3Z067C+H+S/hl/Vk3kA9mP4GHB+VOveJCldrd/PB01kuIpd4jZA1O8NhGgaurpEsyMXQ1wDifLxYQX0Ad4yUtW57XxpxATGwvka0FzM3v239utNZrmaj+SxE2gYCGAZyN8GhA1aBFmwEVGRfbxgEMrN1pK/q8hVHMGDssPzaSppsmAOula4EivFbQVY3GenlRJQUX+mhQ1fhZYqzWLOSSg3lsuXzcyoRSkvcUKVWXPyKBRFoFRPnp3HA6yvnaqqAc/g/12rnLRP7rAYxzMjVdJG9sYdXKUg7GwIHDX1szqIgP0qu/S8Fjezy8pbbbqfN1llftcs0fhXt40hjK23uSQAOFrhIsLDKB3FnNWX2URz546aMGakj47ZAEQnlH8s+cmzpVQc7neaFxJCpnKL9BbS6iGoCwSk/+MATqLF3nETYwH54ruqAIMaxua7/Lme3IHOgTWTWaslzTaPPnFrgb/C5C96O1/h5WYMRtWCuAFFsSsnr2Xkek8URuvIcaAuXdejK3Ce1NyJlc0W6Sxh2gl9t9pvJAns4qrt0TOWAYLwFTcPZ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(346002)(40470700004)(36840700001)(46966006)(47076005)(82310400005)(52536014)(70586007)(82740400003)(55016003)(2906002)(40460700003)(86362001)(36860700001)(70206006)(6916009)(8936002)(81166007)(336012)(4326008)(40480700001)(356005)(478600001)(33656002)(4744005)(83380400001)(41300700001)(26005)(186003)(9686003)(5660300002)(6506007)(316002)(107886003)(7696005)(8676002)(54906003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 06:00:09.2562 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a344b3a5-b686-4b48-182b-08da66274624 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT060.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2704 Hi, > -----Original Message----- > From: Henry Wang > Subject: Xen 4.17: Proposed release schedule >=20 > Hi, >=20 > As discussed in the community call on July 7, the release schedule for Xe= n > 4.17 is proposed below. Please send comments ASAP and in any case by the > end of Friday the 15th of July. I hope we can finalise the schedule then. Since everyone (who voted for the release) chose below, I guess we can follow the timeline for the Xen 4.17 release. Proposed option: Wed Nov 2, 2022 (+1 year from Xen 4.16 release) - Last posting date Fri Aug 12, 2022 (+5 weeks from now) - Feature freeze Fri Sep 2, 2022 (+3 weeks from Last posting da= te) - Code freeze Fri Sep 23, 2022 (+3 weeks from Feature freeze= ) - Hard code freeze Fri Oct 14, 2022 (+3 weeks from Code freeze) - Final commits Fri Oct 28, 2022 (+2 weeks from Hard code free= ze) - Release Wed Nov 2, 2022 >From now on, I will post reminders one week before important dates. Kind regards, Henry From xen-devel-bounces@lists.xenproject.org Fri Jul 15 06:00:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 06:00:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367916.599086 (Exim 4.92) (envelope-from ) id 1oCENF-0003xT-14; Fri, 15 Jul 2022 06:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367916.599086; Fri, 15 Jul 2022 06:00:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCENE-0003xM-T9; Fri, 15 Jul 2022 06:00:24 +0000 Received: by outflank-mailman (input) for mailman id 367916; Fri, 15 Jul 2022 06:00:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCEND-0003xG-Di for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 06:00:23 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 68f05f50-0403-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 08:00:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 311301FB88; Fri, 15 Jul 2022 06:00:20 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F310E13AC3; Fri, 15 Jul 2022 06:00:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id lNAKOnMC0WKtaQAAMHmgww (envelope-from ); Fri, 15 Jul 2022 06:00:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 68f05f50-0403-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657864820; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Z/F3cQT+cH3GAtGr2gCyZOGo26FZMuBzzs2I/si0ezY=; b=rGKKnreJ2+t4MDodt8pguFR1rgCvsfX1QkMDJ5fOY8QpvqNN34RAtJ7bdHc30HgaSbjFsg Jfs+tEMU6ymU/z9Ud4OUmXRcRke4uzTjB7ACeOZ3DnpVpf0T8f7qtMONlTjSi5YiR6gjgF O+FFdTw0aK/W8Xs/T1WOEfHgdVKyGdg= From: Juergen Gross To: torvalds@linux-foundation.org Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org Subject: [GIT PULL] xen: branch for v5.19-rc7 Date: Fri, 15 Jul 2022 08:00:19 +0200 Message-Id: <20220715060019.5197-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19a-rc7-tag xen: branch for v5.19-rc7 It contains a single patch for fixing an issue in the Xen gntdev driver causing inappropriate WARN() messages. Thanks. Juergen drivers/xen/gntdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) Demi Marie Obenour (1): xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE From xen-devel-bounces@lists.xenproject.org Fri Jul 15 07:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 07:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367933.599108 (Exim 4.92) (envelope-from ) id 1oCFav-0005UI-0F; Fri, 15 Jul 2022 07:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367933.599108; Fri, 15 Jul 2022 07:18:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCFau-0005UB-Rg; Fri, 15 Jul 2022 07:18:36 +0000 Received: by outflank-mailman (input) for mailman id 367933; Fri, 15 Jul 2022 07:18:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCFat-0005U5-Sz for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 07:18:36 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 557c06a4-040e-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 09:18:33 +0200 (CEST) Received: from DB6PR1001CA0001.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b7::11) by DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 07:18:30 +0000 Received: from DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:b7:cafe::d3) by DB6PR1001CA0001.outlook.office365.com (2603:10a6:4:b7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Fri, 15 Jul 2022 07:18:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT041.mail.protection.outlook.com (100.127.142.233) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 07:18:29 +0000 Received: ("Tessian outbound f9f15f9daab2:v122"); Fri, 15 Jul 2022 07:18:29 +0000 Received: from dcf0c26012b5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 166D18AF-C247-4EFC-9490-D9E98B92F3F5.1; Fri, 15 Jul 2022 07:18:23 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id dcf0c26012b5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 07:18:23 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR08MB3166.eurprd08.prod.outlook.com (2603:10a6:803:42::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 07:18:18 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%6]) with mapi id 15.20.5438.017; Fri, 15 Jul 2022 07:18:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 557c06a4-040e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=agfOIlCjHnCmmHBumU2HTCwcfRjkr7v1w7FC5oDdMy0PkWdOV5OyjPbwq/HAkIRrPSUKeNFm4er+YbIdNBagLQ3LCGfLs41R78MP2SJYapR3iQdWtGYw9BxpKB3MzaYcn0mJ3E3lUv3bxvnXw2dU7R9wvUACPHVY7zuUG8o+0ZNwK7tuM9b4OBFVoPxESCXCN0NDqEXbmKb8TsA4hqwV8CZJ/Bcl3J9a4FMk6AOtqadech6HELTFZYsy+i7DY06hNSOjSDasrA5ym5KjV6gnuUZUlMmrKDFRX/uL9jJ8TvVIvtOlmhu8pM5VtjYdancH/5myoVxbcgLyxfxC28wkNQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=YKFXhFXplSk1v4hoPptt6lk6B9lUFSDqZbuAu/crDIIzBQ4slrp8n1s10fwzlUqreu71AaxUS4DdHI8CAXQ3fz39nZLtyoUFVSH+SebG2ZGWWsPLS6gcQpVxRPisLeWK8utkLbuUX/F6Q+K1NovhgYskLeEl51pLrd2BEBlPAyB3+EZTJEs7jCNa52/HrUdF4oRsgyGc5wDkLV0JZRe6Ug9hg/39VJ4iEThKNaE7PFLBmOiu1tqIY3ix0+44Qw+2mzQiPZ2m8XrBAzK5fG9GtXwl1YWcf+CtxrKnXDmnm5ldGAfabJZxhHgaMLtiB65WA+MknwwmbxTTO7JWGu0AGQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=93BQkmB0G+8waCarzm9oKe69DB8RfydtHHUd3Q8Wk3gPOLDhL2yR4FtDys5vdX+1SYmwdvz8r1pj97E4U5nxHi/+2qhQkbSpje4KxFskocVzBpzOuo2K5N0dgiyTzNa1lAx4UEHlAsE8QF+oU5rt218GaIneRUID+HSGgI1Ll1M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dEQsY06Bg5KgcgA0V4aYi0PXK5EOoZWYHQoKydEsACgJ4WhzzI9pxGjOrO1D+2+Bo01/bo25p3WLJBraKq2HXs/vdoHvJ9vNENPl5p81kDUFqxyHvw7gygQg4k0IrAz0lP7mTAsH1WveHyL+Iubsv4hyQA1JSxtfAgyWTJFF8gJuwUcA1SHPUKrCylrJ+6Uyu9yNUwnnCTiBzx+uNX1+dBMStVDHAppsVJQF/6DKwYFUImSjsjBKqv7Q6YZV2HwtHkkQwxv7+PSAO75O5XJn2adnbLWQfWZ/aSnRfEeSzPlNImc3DSGsiVdjwDG4HTKndyX+r1/ikeX2oGiPpByo/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=kntRjpJOv/Te3dnQmT3vqTS+DdPVxEkjAgCnhrE7etdjcSZE/P0OVaIlNqJitN9TXzsumt1SRi/zF3uY2Unk99Uovgol1o4WiSskOeaj/aova8WcXd4xjeN0or3xJcdcvhLHqF7AZDfLQQSbHCTpmiKggIqL9rmSm1LvQTOONNy3GWlg9X2N14Yb2RQQa4/OttXTftA1Q1XezRNa9J1O7P0MY6Y3mO5LsYhgMHm+rbgjrhfBXHJwCiYu4UNojfsvIhnzmJCzDQJiO+T3lPQ/dNzVTF2EWtlLoVO8PLQtIZoslMGXPpQwKOhOrEWA0AA/NKHFlXq2ZIHFogJQ8DA16w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=arymSuFwklfPLOmYlNy8bZY5qdA7XbUIlSc8COvUre8=; b=93BQkmB0G+8waCarzm9oKe69DB8RfydtHHUd3Q8Wk3gPOLDhL2yR4FtDys5vdX+1SYmwdvz8r1pj97E4U5nxHi/+2qhQkbSpje4KxFskocVzBpzOuo2K5N0dgiyTzNa1lAx4UEHlAsE8QF+oU5rt218GaIneRUID+HSGgI1Ll1M= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Topic: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Thread-Index: AQHYktrASbKlS5xyGUK27wSgSLVuo616tdwAgALfc0CAAA5jAIAABItggAACa4CAAAWRQIAABX2AgAAC1iCAAALsgIABU/pA Date: Fri, 15 Jul 2022 07:18:17 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> <94652840-c563-3424-d2d2-70871b39ad62@suse.com> In-Reply-To: <94652840-c563-3424-d2d2-70871b39ad62@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 351A7B024BDE8D4FB399685DA1029CAB.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b806ae77-fcf7-4c5a-865e-08da663237cd x-ms-traffictypediagnostic: VI1PR08MB3166:EE_|DBAEUR03FT041:EE_|DB7PR08MB3260:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hKaylmny/nUyoM1nssyVigLqvkVpfduttoHSazhN3NElmVM86a/88fvCyTnP4vn/3fNp1XAVF2t9P79UiVVcMuDrkXqrv27FZUzVe6cgdmgsiZsIbPo1tyM8cLC3x36XjV/RZAmrmNyeirWUMADQUF+qxd61YfxgGEXrUt00eIK+RBCFgKHOjC/yb8odaRcwkv871Ue7IGAUnW6AGl3AdDMnb2lPEFJFbLgw9OCPwe4CneuvY5bVTphGt7NNtlvkvjE558ZSsCU6Ut+83Cqzzacg8B6/CVB3rUD2PDVgWYgdns0jG23X49anWFIOBCN7PfB47yga++Lwhqe1JxaQZuMEOrzAnrjJ6Rzqc4KyKfnC95DwA/jXQKc5qhGx0IlBSmkFcDnxNDhmPaB1W3YU6U4oAb99cu7wKgkMS0ORvUhUs8lknB6YPbYZuCgCRXyL3BmKEJB3/kcdQjyYSj3qcYdBf9fPL6IOtIYjb21v4LP4vyM/DWygAoLaGF2PvW9b610diubLYDSmucVxeB6JS989dJgKswUbJnN/pyOtfcSZ6ZRQ1CFeIImiyygTE1TBBe1gHhgcBlNCBnd74ivV3W5Den4v4b0/8XU9mok1RfiSGiUGUlCldAjK5u6iPIf5bdyA3RrzgLRi+8naNkmVrqYYDqFG+AV+rJU68Z9e7D1c+Cx+tTm6yajRKJdUGPyKjJUZPiWVSZT6+sqSQa6kSAFkFu/ajgSoxf5E51kb4+V6wExeH6bMQeUrATtnTdGp9MZ78+QVl3m5hCKrGvBP7OUcKv5gcHCiEeAbdV70Xbc7epNCMHC9URc+BHdT2GvH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(2906002)(5660300002)(64756008)(76116006)(186003)(83380400001)(66446008)(33656002)(66946007)(66556008)(8936002)(66476007)(52536014)(8676002)(7696005)(41300700001)(53546011)(478600001)(71200400001)(38100700002)(86362001)(26005)(4326008)(9686003)(54906003)(6916009)(6506007)(316002)(55016003)(122000001)(38070700005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3166 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b01f5339-8ad6-4b8e-6689-08da66323075 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dBeGtFkgqxNZdRr/mfCY7m6HHBtZfhuqwsAZ5r89CIlT3Awcb2qjBCerDJ9WHFooUqOt0XFarYSJaRvd9p0gJ7A37WDhS+i5c+lFy6Vj/bgNY6IP6VWBftnTTdXCFXuzKGSrmxmOq8EMSaeT6VHvbZPAGCN0aBmiUlxsR1SpZ31NrWdWqQWHZjScYHgzxQ0ldBUnVVma+uerHnDl2taAWNjS+cKqfrA32Q4GYNzOreshnG3qfQJJ4MnhM2ZAwrbDkwiKrzEOzosAUbnVM2lBD2zfBFaO4rr4uSi7riQ+ncx30f9HqqGY/nFvBd37ZjxPkrjLQG48iI8BmUcOx8ALyBy59k36a77uNb6+chMQ2Vtjls5+n/NgbD3ri3Jx5pMDrjCaYTnZkBl7N1z35unF3fHzm8GAycYbjTB88ILco4emqQ1gW1LfpZdNIb1e0PhILeI3UrFuM9ROlAZrfFI41dSMXtm441VrNV7viSUqHDFkHyRZCY3H33xA/tXgHuvSwoIsXmk30GDj4O/g5szFiK6OTcFHhLY7Ci/sUIKLLrJVDzzfbk1L/qXZaAapvMPqVEDwsxRD70aTgwiJWc0gvdD12X8br4E49MVISwvjfar9Uhdh/gAVnQI9zpTNACAYosJRT1lYKThUfrbn/oLndp4kj1XuefSh94GAc18jh+y6njSauptS8jMhPFJref25Yk/WffSzdm/RGCZX8Erp6G24NkEqNDsfWuTAmFlUfCCXlcjjW+M7TiHQmoho8fNkaRcaw+8o2pI9XZQYX2OeGOkASWv+NwFYN+zpqpKOSXXSc4+czReODPwFl2ivP5Uq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(39860400002)(376002)(136003)(40470700004)(46966006)(36840700001)(2906002)(316002)(41300700001)(82310400005)(8936002)(356005)(478600001)(6862004)(36860700001)(52536014)(82740400003)(86362001)(81166007)(40460700003)(5660300002)(54906003)(7696005)(6506007)(40480700001)(186003)(55016003)(33656002)(83380400001)(47076005)(8676002)(53546011)(336012)(4326008)(70206006)(26005)(9686003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 07:18:29.6804 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b806ae77-fcf7-4c5a-865e-08da663237cd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3260 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxNOaXpSAxODo1OA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBSb2dlciBQYXUNCj4g TW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT47IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4t DQo+IGRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIg Mi85XSB4ZW4veDg2OiBVc2UgZW51bWVyYXRpb25zIHRvIGluZGljYXRlIE5VTUENCj4gc3RhdHVz DQo+IA0KPiBPbiAxNC4wNy4yMDIyIDEyOjQ5LCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4gRnJvbTog SmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiA+PiBTZW50OiAyMDIy5bm0N+aciDE0 5pelIDE4OjM3DQo+ID4+IHN0YXR1cw0KPiA+Pj4+DQo+ID4+Pj4gV2VsbCwgdGhpcyBtYWtlcyB0 aGUgdGFibGUgY29tcGxldGUsIGJ1dCBpdCBkb2Vzbid0IGV4cGxhaW4gaG93IHlvdQ0KPiA+PiBt ZWFuDQo+ID4+Pj4gdG8gZm9sZCB0aGUgc2V0dGluZ3Mgb2YgdGhlIHR3byBjb21tYW5kIGxpbmUg b3B0aW9ucyBpbnRvIG9uZQ0KPiB2YXJpYWJsZS4NCj4gPj4+Pg0KPiA+Pj4NCj4gPj4+IE5vIG1h dHRlciBob3cgbWFueSBzZXBhcmF0ZSAibnVtYT0iIHBhcmFtZXRlcnMgaGF2ZSBiZWVuIHBhcnNl ZCBmcm9tDQo+ID4+PiBDb21tYW5kIGxpbmUsIHRoZSB2YWx1ZXMgb2YgdGhlc2Ugb3JpZ2luYWwg dmFyaWFibGVzIGFyZSBkZXRlcm1pbmVkDQo+ID4+PiBhZnRlciBwYXJzaW5nIHRoZSBjb21tYW5k IGxpbmUuIFNvIHRoZSBkZXRlcm1pbmVkIHN0YXR1cyBjYW4gYmUgbWFwcGVkDQo+ID4+PiB0byB0 aGUgbmV3IG9uZSB2YXJpYWJsZSBmcm9tIGFib3ZlIHRhYmxlLg0KPiA+Pg0KPiA+PiBIbW0sIEkg d2FzIHBhcnRseSB3cm9uZyAtIHRoZSBpbml0aWFsIHZhbHVlcyBvZiBib3RoIHZhcmlhYmxlcyBh cmUNCj4gPj4gaW5kZWVkIHNldCBmcm9tIGp1c3QgdGhlIHNpbmdsZSAibnVtYT0iIHBhcnNpbmcu IEJ1dCBsYXRlciBvbiB0aGV5DQo+ID4+ICJldm9sdmUiIGluZGVwZW5kZW50bHksIGFuZCBtdWx0 aXBsZSAibnVtYT0iIG9uIHRoZSBjb21tYW5kIGxpbmUNCj4gPj4gY2FuIGFsc28gaGF2ZSAiaW50 ZXJlc3RpbmciIGVmZmVjdHMuIEknbSBhZnJhaWQgSSBzdGlsbCBjYW4ndA0KPiA+DQo+ID4gQ2Fu IHlvdSBwcm92aWRlIHNvbWUgZXhhbXBsZXM/IFRoaXMgd2F5IEkgY2FuIGJldHRlciB1bmRlcnN0 YW5kIHlvdXINCj4gPiBjb25jZXJucy4NCj4gDQo+IFRha2UgYmFkX3NyYXQoKTogeW91IGNvbnZl cnQgImFjcGlfbnVtYSA9IC0xIiB0byBzZXR0aW5nIG51bWFfbm9fYWNwaS4NCj4gWWV0IGltbyAo bWF0Y2hpbmcgdGhlIHByZXNlbnQgbW9kZWwpIG51bWFfb2ZmIHNob3VsZG4ndCBiZSBhZmZlY3Rl ZC4NCj4gV2hpbGUgeW91ciBjaGFuZ2UgaXMgZmluZSBpbiBwcmFjdGljZSBmb3IgKGN1cnJlbnQp IHg4NiwgaXQgaXMgd3JvbmcNCj4gaW4gdGhlIGFic3RyYWN0IG1vZGVsICh3aGljaCBpcyByZWxl dmFudCB3aGVuIG1ha2luZyB0aGluZ3MgY29tbW9uKS4NCj4gDQoNClRoYW5rcywgSSB1bmRlcnN0 YW5kIHlvdXIgY29uY2VybnMgbm93LiBJbiB0aGlzIGNhc2UsIEkgYWdyZWUgd2l0aCB5b3VyDQpz dWdnZXN0aW9uIGluIHByZXZpb3VzIGUtbWFpbDoNCg0KPiBpbnQgbnVtYV9kaXNhYmxlZCh2b2lk KQ0KPiB7DQo+ICAgIHJldHVybiBudW1hX29mZiB8fCBhcmNoX251bWFfZGlzYWJsZWQoKTsNCj4g fQ0KPg0KPiB3aXRoIGFyY2hfbnVtYV9kaXNhYmxlZCgpIGV2YWx1YXRpbmcgYWNwaV9udW1hIG9u IHg4Ni4NCg0KSSB3b3VsZCB1cGRhdGUgdGhpcyBwYXRjaCBsaWtlIGFib3ZlIHNhbXBsZSBpbiBu ZXh0IHZlcnNpb24uIEFuZCBpbg0KdGhpcyB3YXksIEkgdGhpbmsgV2UgZG9uJ3QgbmVlZCB0aGUg bmV3IGVudW1lcmF0aW9ucyBhbmQgbWFwcGluZyB0YWJsZS4NCg0KQ2hlZXJzLA0KV2VpIENoZW4N Cg0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 15 07:46:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 07:46:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367940.599119 (Exim 4.92) (envelope-from ) id 1oCG1p-0000s8-4I; Fri, 15 Jul 2022 07:46:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367940.599119; Fri, 15 Jul 2022 07:46:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCG1p-0000s1-1N; Fri, 15 Jul 2022 07:46:25 +0000 Received: by outflank-mailman (input) for mailman id 367940; Fri, 15 Jul 2022 07:46:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCG1n-0000rr-Uv; Fri, 15 Jul 2022 07:46:23 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCG1n-00074F-QG; Fri, 15 Jul 2022 07:46:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCG1n-0007oD-EU; Fri, 15 Jul 2022 07:46:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCG1n-0000M2-9s; Fri, 15 Jul 2022 07:46:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UIvwj3HN3iSuRRYsAOTXAqZJ86lt/aa5O9ZZMgDsv/Q=; b=XRUP99JXEO3s2N/Bf1Fs8KdvDi 47l/Nga10J3pXUhF7ATiu0ekLZ/f5JCbUA9PEQ8VKCvS5ws8+bvHMy8+ZyCNIKO8zcByOt/qMH9xy NgOmObCJlk8HIVIC+4136xyB7bFbczzyFD0l+q/8wocxn/oRd5nkNmeGQUFdemotiu/E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171631: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=08c9f7eec7002dac2da52c8265eb319aba381c86 X-Osstest-Versions-That: qemuu=824824d12217f7d80b372eb051aad2c082cffb98 From: osstest service owner Date: Fri, 15 Jul 2022 07:46:23 +0000 flight 171631 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171631/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171623 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171623 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171623 test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail like 171623 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171623 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171623 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171623 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171623 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171623 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 08c9f7eec7002dac2da52c8265eb319aba381c86 baseline version: qemuu 824824d12217f7d80b372eb051aad2c082cffb98 Last test of basis 171623 2022-07-14 02:53:41 Z 1 days Testing same since 171631 2022-07-14 16:39:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Cameron Esfahani Pavel Dovgalyuk Peter Delevoryas Peter Maydell Philippe Mathieu-Daudé Richard Henderson Silvio Moioli Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 824824d122..08c9f7eec7 08c9f7eec7002dac2da52c8265eb319aba381c86 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jul 15 08:18:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 08:18:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367957.599130 (Exim 4.92) (envelope-from ) id 1oCGWz-0005yj-1v; Fri, 15 Jul 2022 08:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367957.599130; Fri, 15 Jul 2022 08:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCGWy-0005yc-Te; Fri, 15 Jul 2022 08:18:36 +0000 Received: by outflank-mailman (input) for mailman id 367957; Fri, 15 Jul 2022 08:18:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCGWx-0005yT-OI for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 08:18:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b67dc2d2-0416-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 10:18:33 +0200 (CEST) Received: from mail-mw2nam04lp2177.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 04:18:30 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by MW4PR03MB6441.namprd03.prod.outlook.com (2603:10b6:303:120::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 08:18:27 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::298d:4044:f235:c782%6]) with mapi id 15.20.5417.026; Fri, 15 Jul 2022 08:18:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b67dc2d2-0416-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657873113; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tU36mPMvGMR4pFpwKSZ/n9B/7cKnZJksI9dkuvajUUc=; b=NoQ06AxBEwXaf+YMyg3gyNLz3YxAyiS6akCwAAvYPtSn8SDLKuGSL+ok RCaI4WRMbMmAGX04AmcRXFFSpaVqdePMdbkyA25A7M7QDyoxPY7ty39Kl 7pgSXRskus9fSZqqHENBKYtCOP1XcjiJPl61/lwmqNEMjO/ys5mu2Scy7 U=; X-IronPort-RemoteIP: 104.47.73.177 X-IronPort-MID: 75860348 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AKXQ9G6vWxPUXlXa15ug105Ad5ufnOphVZpANC?= =?us-ascii?q?cmfNqXej2XJXxfKv0VeTJM5Uo87buhUoIT61S7M9MUuHW69dM8B7dbbYfLqP?= =?us-ascii?q?tBry85aM5BzRjERZHfJoamesGtX0DSC/+Ec6WCudI4CHxXZPAY10Qots6xRf?= =?us-ascii?q?5+vfAAyvU+KWVNB9TeLJ+T7DrKZMpasbyMdJL4upZOnMrewOi1pn16XED4Xo?= =?us-ascii?q?j2uo5BpCfhYfMCScj6JFsat8lRzA280TXScH/xUn7vuKxKaZfkWe24sUDfSQ?= =?us-ascii?q?XHmfBkYy0Gghx/VkKi+gAJwu48Jn91te20WYoV0Gwk7d/an25FC8YleWo6Mt?= =?us-ascii?q?ggTDKSjiJk9DwSWeWeIhLt8blIeSZzW7lTbys4+IzXcRsTMEe/DmHQfaTWxp?= =?us-ascii?q?OouYX1C7XrpP4KAwIPikjmpRTp1QPbxxPCCjDJYi3dpFN9Tj34aWK/QDju7T?= =?us-ascii?q?TIx/xQxYaiPDCy2+TTr8qmtGUM+vXB0t6TTMBApwKURDNcg5rIpWSIdALviQ?= =?us-ascii?q?MH6LuA/0pOhf6LtcT4523A9VEVLF2AqmOk8Qu4q1OtgGHs8r9vbb85Xn4dq1?= =?us-ascii?q?m8IGgk1mD+DrmAwMQkz0z2T5MZnX4sP/hbqayX8FEgWDVu8xnx0M5Ltysk7T?= =?us-ascii?q?wurDAzfua6K3deFRvAOKx/v5PiMHC2Mm+UWcU30df7TM4brktAFq5ZOywVUE?= =?us-ascii?q?im4aqE0UAyLCO7HIpSekjddonco+Ka6zlDedgtbbsqov2wGNmieWuSY/cn6q?= =?us-ascii?q?yHZoyNSPVSxjz8CLG7SX4/JvqoiLdMCjZZR1Xx5SVkmr2iKS+H+/hzC2Qfia?= =?us-ascii?q?HhnbbX4D5lpXCmKBazzOumLYDXmxJHNiPDY8FsGXeCpfsXasQ2P1oB+tqT7E?= =?us-ascii?q?wRcHH2KgjI5sdDfTx1GKkuWOvu7xwyEUGzegZLlfB5NU4oc5qMNz6SmhyW4c?= =?us-ascii?q?mIuFOPdW4zPAopk2yYCfcve9okFxh3sdVwRg/9S5jPs11Jh3RMWUicA3I2gG?= =?us-ascii?q?a+OH7ceiwvedW2H1xxcwVavXrnwlhNQWp8fAi1E0cuCmAFRnMQTRTSTez4KD?= =?us-ascii?q?wEDfBtZpzA/nwXN0UQtZiOCFrXItW8EtIrG1xjRDkKeoi05IojFX386HC2HV?= =?us-ascii?q?Q6UCypp0N9UWgb/L0Dn/FUfi0EM66XICvKlyZa4ePAklhikfB2Ixo0GnmecQ?= =?us-ascii?q?XiheBZh6MYMQV3drTIqQiEnElZ/YuUprxWdgVeRxnrJr72yKauP2shB0oSNq?= =?us-ascii?q?ZOvcfsEitWSpPh+ulVBu/CW5x9DcwVkWpMLV/q6Qn1HucfoySmaS41tSNArB?= =?us-ascii?q?mvFSTqmQFXM5UXGv0tEv0Asy1kCwiKds+NQtDDLJPCdGaLO/w94pkmCMbA7D?= =?us-ascii?q?LlVnGOMaOO7KX+ecd89gh9pwvaQsGZsd5NBMnWdGaqeF3SNRBspASBTsYP4B?= =?us-ascii?q?4sCopEcmHc7ACkg18BErN72gHKXk1ebDkRakLDq/SiWhE5dEl6u47wH8dx8T?= =?us-ascii?q?S2Y42U7qU4dEOz6TCaocC5rGCXZiUuihh+zNPkImnpAxNuFMa4j6uUvzADvP?= =?us-ascii?q?lZk344thmh0DDgaqZrX3dRidekXlo03DregT3SJHTIpygF/Tn9DITX1eJ2SX?= =?us-ascii?q?CIz83hjhyygFlKG2Ee6oYNujTA6dKhErolTAZ19C9jwFIvVH4P2YNU44yXqP?= =?us-ascii?q?C6xflduI8SXk42L+Mqn08CcKqxHg8TZSdYvbMmBv3OBca2030q84VlPpWSjA?= =?us-ascii?q?xKO54s3ReqZZkeJbGQX1xx4LXrmv0uHgfi4mMKrOnkGcxykKDoK6L+5TCacs?= =?us-ascii?q?EXSNafiKaLRxn4dIGAuby8US4Fx/z7cP/QmXwfVFnOp9mcKgxfND+ZySIHIm?= =?us-ascii?q?/b4xZdgi56JJxOcaRYrZEAXGCis5ueCmrilo+oOaVNb9D93YF1w2fCZG2AmP?= =?us-ascii?q?/wU6KE3S/EamNO0RLm622dNeiy4gfiZHWwP4f4ug9/ZJEE6F0Y6HT8LnEMnP?= =?us-ascii?q?5eT/Ub93DkJnHkmzyhrnDWPI+dljJg9/3JxAyazlA6CpKv2pbCnCciiLNudH?= =?us-ascii?q?3SrAX2L25qiq+pqTRXiYpaX9jTwLGr4sVJnaiqkhJVjZ+SYZfsiqRzVNXk3C?= =?us-ascii?q?Fj/zqr5tx55xqW3UeyDt0PSM7eZdu+EL+zaS7RvQFRhypqAbcgPWhEeSo7oV?= =?us-ascii?q?eDimi+6I1foTbdxrZe5rsnI5IEroDKgfrEj4L+gnqVwizro+nXlTrwLYT6Rl?= =?us-ascii?q?3bqnulfZ0sPcDJT2dB0Bz9ns2hzDDSccqEjeR4Mxtq51OfsBfLAQoWijmIKX?= =?us-ascii?q?rmuRxhm7wXQfoS6SpZihQOzrc4xXZdl3GD5U0+2MPo5Rw1DzealNDVndNyEq?= =?us-ascii?q?6bqyKRszrhJgX42vJQVi6zq+81w/upE+vsjplUhBiUyKfxum+LYJzScnIdpv?= =?us-ascii?q?ivF6dpAW/lNdszmyAeCTMnSIsnsGfsNP85qtYxYtxPNADbP8sJhcObuhwY2x?= =?us-ascii?q?2H22LQNgws/7G178b6cpDiZLgQs9yu1a9BTXMEOrSO/362EcW+2MNh15c6h4?= =?us-ascii?q?u40wYEFYegt22ByVwei512JSXL6UORZZ0pPUOTn6p5ug7LFxOawt6eaEUjlp?= =?us-ascii?q?8XEOXdm6CVLwNNHnHyvmWr/JpYI2oFyes0plfuhlqo9BCPwJmRYkt0hb2Jyc?= =?us-ascii?q?Fu5O3l1atNtuKSl5hrg14bztr1S99DEJzh0i/Guz23LylPXMHmZlOwDx/Paq?= =?us-ascii?q?1F1MlytWriQgz9XbFIq81yDHtn6z7x0mi6BD/KQdVtBJ8T7R/6pzeoDG6Xzx?= =?us-ascii?q?Y5RJo/INna3sS9+iN28ltzi0kPR+TYJlJxMszHGWlw3Ndve2NfvK5P8HKOm/?= =?us-ascii?q?ICTRnhQqc0VOEMFbbu4jSwJe9ILnmneoJrhr1Rdq9GYH7lT5iDIe5WIGlhuh?= =?us-ascii?q?xtWjMUqk17pH2kNgpNhoWdPF1qJ4EdyRM/EARmBuYy6DMJMSx6QKW306nWTd?= =?us-ascii?q?NN/cLU88aXx65KgyyaLWE8SUdwEESGvnVqeYY18KjcjQpISaI699KyyivEDa?= =?us-ascii?q?MfUTpD8x1gO+IC8YTjYf2fUd01gokC/Oa8ZxhzL7tRYZ/AhZvW7MEH3LxHSs?= =?us-ascii?q?eqK3YF42o2dJycQTBSABxShHE+kLYfX+ODv5SeYNuSvB4/EiC+mgM7a/TN3C?= =?us-ascii?q?ABtJUfhXydmfyoV9E9/Dj3uMefpgjg0a2gW0eFPeBluHMsT?= X-IronPort-AV: E=Sophos;i="5.92,273,1650945600"; d="scan'208";a="75860348" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=liDBpOiSTpTBvpoCrvATDC/uQirYDqWlMy/ngdWWHp9dwn3odQSyLxtw4wZh2sjsnQkKD9v08i2S1BmfIbQVURrbnwG2eNtZNwALWjs5NoBupmo5sWvuUa7B8vg35NGI38k6dqFD07Wuei/2WtwJZwRTgGEMlA5fgQBT/gsrzVdbyZt278m0lRVqA/MFtzjnHYiShKgKdnVGNFMgHUl6yK94y3qdqi7ej5+q1m+tQwjyEpcFQOenaCI93T2+Gv6hxiPvB3Fa1AL5ndxD517iQ+vCN6UkMQtUX4skVBj2zWDnlSQ2rS7Ittf1dBpXmS41xrC0pjo1H90c/agXR6bhjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tU36mPMvGMR4pFpwKSZ/n9B/7cKnZJksI9dkuvajUUc=; b=fiIxxYf30bpZx4LZJ6qKbLNk0uwdFP4VDhI+n5soaQAlEXzthjrPUjaRmOQYenLjAfqanwYrl7qa9cw/wpcyNJWmByncHQeSDZAqiY/XEr5+v39kpgGyV+qSUihWskE3aK6UI4nO+TNLzDHKLJcsEw0Udzl7GpO5MBmsMB4V2ye8BBVcn/ospS8u0kXe42+CA03WoQhn4D3tY4emz5SxbQ/1SwSMFghXdGJ7u6Za8Ok3qLU79FI6fR2g1hemwWTcynPrSpnQUNyr43USDSQNPfuLbVOqTJ+L0qFYHmtRGqRTQU0HOptUkDvQ7ldpT9+B72f5vZ59Q+0LWpqBSfXmkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tU36mPMvGMR4pFpwKSZ/n9B/7cKnZJksI9dkuvajUUc=; b=haI5A9RBUn7trJiMwh4UaMgmbSltNzhscB0WMJu8+mKgOHHJpXY4aNWF0j3aciUJI9XNkFmWVZw7NZO00Ekd4L00L/eFfXp80CxUJqJrf8C5IHE51p14wwj3aucVFesIWJDOmnG5qf2tvOg6s0IslwSpUdIaiUo84GUcVF5bKYA= From: Jane Malalane To: Boris Ostrovsky , LKML CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlTod5hgtPAUSGEuMopkQlGVYGq189b0AgAImowA= Date: Fri, 15 Jul 2022 08:18:27 +0000 Message-ID: <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> In-Reply-To: <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 91ee08e1-0cbe-4651-3301-08da663a9871 x-ms-traffictypediagnostic: MW4PR03MB6441:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5iWb2vyLFf2Nz8CWq4Sx8HdQXyFpQyad8aa969K8YpxORkhYIl7fJ64d4TrEFVQIAb6gxG9Es6/n+hAb5EKiQ57BgUGrMxhlFHvKFVopxNkG9+64wjg8F+LTecSyaqN7BXDdOF7Mo30g4f704MGQKdPWAVdah/g+Knl7aMe+vhe7byWX2dzFX1YQjr4DRGdzmbgdOLmYxPpo/lpvcC5sOujLAcOtZBsVk/eE3WrDtL95Y2WYuT14CYCH/yA0QKV+W4OWJ4LV2gC1MXz3d4m17FyCfc+O6bKrX5A4OF65T3QNzH5YhpMziZPNi/5wCLe/s9lgJkRzUDP63s4TmbjHLMXndOmzko4TiTWz2gG3Neuf2jY1ZZFiutqy7vELIzev09CmtVVCvij8WTIpu6EoCXprZnGimGY2uQy9p8Cvcz67llWMoqNjMB/9zeugcDiU/cV9N1b8tWZonecn318fOJ5MU01wl3/l3dHCOTRxdy03g6HEI0uT7rnU1+bynlcTZ5Lj0NjoSum75S3viAIKba2PDf7fFQLv2yz5nKNe3BKJSZqdQd5Yq6YmA9PYnbv/6IYhsird8SCnQRpHV99zQMv6gzsnS3nwY2IJpGI26CzliRMXjOFFfoYTF95mTgTKCyDECPUIyBURb5toys8TOYkGebQ/xevXzzhe2paOG8FE1hlbDgAzcPaMGPAcjVskXoULCYjqLM3lukUb0tLrHPJT5ijvGmy448FmANPKKcd9rshYb8PjEiy2N1mgyREnmKBt+jJWT0pBXzox+gwNxOhwQFiBkNddql3JPCEjncbYghbRxn2bnk1mol7NnvlMPJvvKJvBGHSqmTocFDaUrE5wWo2fKT0R4VK14Kl6DkI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(478600001)(6506007)(86362001)(64756008)(6486002)(54906003)(66556008)(122000001)(76116006)(53546011)(66446008)(66476007)(5660300002)(110136005)(6512007)(41300700001)(91956017)(26005)(66946007)(38100700002)(316002)(71200400001)(36756003)(38070700005)(83380400001)(8676002)(31686004)(31696002)(8936002)(7416002)(2906002)(4326008)(82960400001)(186003)(2616005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UjJaaFp2eEo2NWxXV1NkYUZKL3QwSnplTWJBQmNONVRualVVVnllSmhnZEFG?= =?utf-8?B?WTdybEJFY0ZrS3V0MlQ4QlQ5NWlnVXVWaWRWU0Y0cyt6L3BMa21wYlVPRVJi?= =?utf-8?B?YzJoZ0xaQUFzM0wwRjEyN0JGYVdUTjl5cndSQUhDZk5WcGpmN3RtZUpHaUJ1?= =?utf-8?B?bmYzWEZEVXNITStsNHJaeTdEeGpFRkpkUXVLd2FibXQ3WHhRckF3d1JyRXB3?= =?utf-8?B?WFlWdjRSSXdER1A4Z1VISmRTRlF4dW53eGhNM1FIczR5SUcyUHJNOFc1Nk8r?= =?utf-8?B?UlkwaXAwdkV2aGdnS0lkZ3ZCQ3B2Nm5VRi9NSmFhcWhUNWt4QWFGZzVuRWF5?= =?utf-8?B?YTUxYStWVzA3MFlmNkkyVjlPdjc2Mmw2TVpaN0YxNXdmU1ZzNjg4bGJBUi90?= =?utf-8?B?MXZTTnZiQ0ludE0rNmRiaUFmNWFDVld3YitYV0dnVnJCT044NDlhQ2NYL2NZ?= =?utf-8?B?N3VhZmpWcUtsWWx1WFg0ZmZEOGNJdldLUkRGSkJQOUtXcmh0UHEwMFJtNm9V?= =?utf-8?B?RThkeHpSRFFhc3FNeEtlTmFvUVM0T0JpV05GK2tDN093aHVVbUFXMG1NK3JJ?= =?utf-8?B?c3BQcy9jSVlhbjdGcnV6bWtlV2NnOVpoOVk2RlpOZk1KVk44bGo5dzZWTG9M?= =?utf-8?B?R0Nuc2U3bldrUzJvOENVT2FISGtBOHZoNWFSNHU0a3hVNVJ2OHU3WFZJNVU2?= =?utf-8?B?djg0c2N4dnl4YjlqMDIwWjFTUEFvS0pTWmVuUmJRdmYyR3loODgzeTVIUncv?= =?utf-8?B?SnAzUzY5dWx5VnMvU1R1WFJnRGNDVld0UWJWRlJKQzFhb1FXOEVKcm9rUFJp?= =?utf-8?B?WmNzbEFjenl4OEJnVWFwdGorMzl3NXhHNDgwMGNhNFRUMkt5cDkwaHViM2Vt?= =?utf-8?B?bzBSZUtzYW5BdmZsTERwczB1QVMxT3o2UDFZaTRQNkF2VUthanZhcUlkemxs?= =?utf-8?B?VFk3M21uWFZkbThWTU5xaGg5aEFaalNNV2FzVnBxYmZJTE5wYTlDV2NRT1gy?= =?utf-8?B?UHl6OGFFdWMvMXEwL0JneEpsV2ErSXZyS0V4a0gvZFliTUYzM2ErWjVlclcz?= =?utf-8?B?UVh0MHFWQjFRaERaTloyZ3AzOTFuRkdLQ24rSldTRzFSQm13TWJoMS9SS1k1?= =?utf-8?B?b1FYdTBNQm8rK0pHM1hGYkVJMkk4MUVNZWVFUVdKaFI0cjRzZzhUaXVKVGNV?= =?utf-8?B?K1lMU2l4azkvcUo2N3hubHczR3Rkb0JwZzdSSVpFYVp1Zy9ZWUFNN1BjL0ZN?= =?utf-8?B?akRNRGVwcDRNeUdVTmNSM0JuM2VZaWlaRVg5OHUyb3JPQjhOZnppYUJHdjVr?= =?utf-8?B?ZUpUTEt0Q1BtRnNZZmRhUFJEcGh2bnJseW1FYkNIc0ovTmh1Zi96SzNEaDBF?= =?utf-8?B?b3RpWVRYYmVGTm9BYWptWllGSWtqdWRHejhTMXJnUEMvRkYwLzFzYi9mbmNv?= =?utf-8?B?cE92OUZBSXNzYXAyK1pYVmxuaytxMzRTV0xwOUZZQW1tcnJVZldBQjdmV2Jx?= =?utf-8?B?WDZEelgxeXFsUVBlNUl3TmhxeXdZVlFaL1NPZEgxdk1XZHBYVXVGUXdZa0Mv?= =?utf-8?B?Zm9BL0tzUnE3U1lvV1RVQ2NNSTlxREI3M2J5aWdzYXdwWDRxM3pjOFpQRm1D?= =?utf-8?B?NTNVMExQZ1ZuVERuaXpERC9vTzdKYVo4T3ltSGV3a1VJRVJIbE9rWG8rVXVz?= =?utf-8?B?UVRkRHBMRmlIcm1NQjVuemxXSGhPeU5sYUhwcEFLaG5ubDlKbUhQT3NqYlBO?= =?utf-8?B?ODF1TzVDWEFqYVpicUhrWnF1aEtQVFpSQm1QQkkzQnhKV2JrVnliNkpBc2Jt?= =?utf-8?B?L1U5WVg1cXgwVm1LK1NNRWJiR0RTaktnU2Qzbm9QZ3N5VFNRbDBCcVRrcjVT?= =?utf-8?B?YXBJTmNaVnZCZmtVeGE1L21qYXRTOEJmNGpySld3bHhEZU9pNlEyTGRHNk14?= =?utf-8?B?S2NwZjZteUJHWlBJbjVzSHNYQnduUmI2YVN1T0FYVGNFVXd5T3NVNjFJcml4?= =?utf-8?B?WVdzdDcyUm5vWXk4ZzBEQlZWbU5iQWNFYzllNFUveDlHaHdKMFBEeStrSnpT?= =?utf-8?B?Qk9aN2E1SllENmcxTDE1WkxHUXA0em1YQ242cmJReENycGdrYmpMcUEyNnA5?= =?utf-8?B?UXlMSTZycERkNWdjZWphRUoxVHR5NzkrTVdOQUYrd3hFYW9NblY3VzBoTUIz?= =?utf-8?B?N0E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <27ECB359466807499E59DD4C032E2466@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91ee08e1-0cbe-4651-3301-08da663a9871 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 08:18:27.7569 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mMs+mqy1hB+SFhCPFcT9AYZO7xOyDEv4d2UAT0Nl5kjES9TDWtoMDiJ/kB+wmqJqziqGAh/H9nK7x3VxAy/bvAraV74FkfkgcIz3ft7/Mbc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6441 T24gMTQvMDcvMjAyMiAwMDoyNywgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPiBbQ0FVVElPTiAt IEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIA0KPiBh dHRhY2htZW50cyB1bmxlc3MgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0 aGUgY29udGVudCBpcyANCj4gc2FmZS4NCj4gDQo+IE9uIDcvMTEvMjIgMTE6MjIgQU0sIEphbmUg TWFsYWxhbmUgd3JvdGU6DQo+PiAtLS0gYS9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jDQo+ PiArKysgYi9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jDQo+PiBAQCAtNyw2ICs3LDcgQEAN Cj4+IMKgICNpbmNsdWRlIDx4ZW4vZmVhdHVyZXMuaD4NCj4+IMKgICNpbmNsdWRlIDx4ZW4vZXZl bnRzLmg+DQo+PiArI2luY2x1ZGUgPHhlbi9pbnRlcmZhY2UvaHZtL2h2bV9vcC5oPg0KPj4gwqAg I2luY2x1ZGUgPHhlbi9pbnRlcmZhY2UvbWVtb3J5Lmg+DQo+PiDCoCAjaW5jbHVkZSA8YXNtL2Fw aWMuaD4NCj4+IEBAIC0zMCw2ICszMSw5IEBADQo+PiDCoCBzdGF0aWMgdW5zaWduZWQgbG9uZyBz aGFyZWRfaW5mb19wZm47DQo+PiArX19yb19hZnRlcl9pbml0IGJvb2wgeGVuX2Fja191cGNhbGw7 DQo+PiArRVhQT1JUX1NZTUJPTF9HUEwoeGVuX2Fja191cGNhbGwpOw0KPiANCj4gDQo+IFNob3Vs ZG4ndCB0aGlzIGJlIGNhbGxlZCBzb21ldGhpbmcgbGlrZSB4ZW5fcGVyY3B1X3VwY2FsbD8NClN1 cmUuDQo+IA0KPiANCj4+ICsNCj4+IMKgIHZvaWQgeGVuX2h2bV9pbml0X3NoYXJlZF9pbmZvKHZv aWQpDQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIHN0cnVjdCB4ZW5fYWRkX3RvX3BoeXNtYXAgeGF0 cDsNCj4+IEBAIC0xMjUsNiArMTI5LDkgQEAgREVGSU5FX0lEVEVOVFJZX1NZU1ZFQyhzeXN2ZWNf eGVuX2h2bV9jYWxsYmFjaykNCj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IHB0X3JlZ3Mg Km9sZF9yZWdzID0gc2V0X2lycV9yZWdzKHJlZ3MpOw0KPj4gK8KgwqDCoCBpZiAoeGVuX2Fja191 cGNhbGwpDQo+PiArwqDCoMKgwqDCoMKgwqAgYWNrX0FQSUNfaXJxKCk7DQo+PiArDQo+PiDCoMKg wqDCoMKgIGluY19pcnFfc3RhdChpcnFfaHZfY2FsbGJhY2tfY291bnQpOw0KPj4gwqDCoMKgwqDC oCB4ZW5faHZtX2V2dGNobl9kb191cGNhbGwoKTsNCj4+IEBAIC0xNjgsNiArMTc1LDE1IEBAIHN0 YXRpYyBpbnQgeGVuX2NwdV91cF9wcmVwYXJlX2h2bSh1bnNpZ25lZCBpbnQgY3B1KQ0KPj4gwqDC oMKgwqDCoCBpZiAoIXhlbl9oYXZlX3ZlY3Rvcl9jYWxsYmFjaykNCj4+IMKgwqDCoMKgwqDCoMKg wqDCoCByZXR1cm4gMDsNCj4+ICvCoMKgwqAgaWYgKHhlbl9hY2tfdXBjYWxsKSB7DQo+PiArwqDC oMKgwqDCoMKgwqAgeGVuX2h2bV9ldnRjaG5fdXBjYWxsX3ZlY3Rvcl90IG9wID0gew0KPj4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqAgLnZlY3RvciA9IEhZUEVSVklTT1JfQ0FMTEJBQ0tfVkVDVE9S LA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLnZjcHUgPSBwZXJfY3B1KHhlbl92Y3B1X2lk LCBjcHUpLA0KPj4gK8KgwqDCoMKgwqDCoMKgIH07DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAg QlVHX09OKEhZUEVSVklTT1JfaHZtX29wKEhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3Rvciwg Jm9wKSk7DQo+IA0KPiANCj4gRG9lcyB0aGlzIGhhdmUgdG8gYmUgZmF0YWw/IENhbid0IHdlIGp1 c3QgZmFpbCBicmluZ2luZyB0aGlzIHZjcHUgdXA/DQpZZXMsIHdpbGwgYW1lbmQuDQo+IA0KPiAN Cj4+ICvCoMKgwqAgfQ0KPj4gKw0KPj4gwqDCoMKgwqDCoCBpZiAoeGVuX2ZlYXR1cmUoWEVORkVB VF9odm1fc2FmZV9wdmNsb2NrKSkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fc2V0dXBfdGlt ZXIoY3B1KTsNCj4+IEBAIC0yMTEsOCArMjI3LDcgQEAgc3RhdGljIHZvaWQgX19pbml0IHhlbl9o dm1fZ3Vlc3RfaW5pdCh2b2lkKQ0KPj4gwqDCoMKgwqDCoCB4ZW5fcGFuaWNfaGFuZGxlcl9pbml0 KCk7DQo+PiAtwqDCoMKgIGlmICghbm9fdmVjdG9yX2NhbGxiYWNrICYmIHhlbl9mZWF0dXJlKFhF TkZFQVRfaHZtX2NhbGxiYWNrX3ZlY3RvcikpDQo+PiAtwqDCoMKgwqDCoMKgwqAgeGVuX2hhdmVf dmVjdG9yX2NhbGxiYWNrID0gMTsNCj4+ICvCoMKgwqAgeGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNr ID0gIW5vX3ZlY3Rvcl9jYWxsYmFjazsNCj4gDQo+IA0KPiBDYW4gd2UgZ2V0IHJpZCBvZiBvbmUg b2YgdGhvc2UgdHdvIHZhcmlhYmxlcyB0aGVuPw0KSSdsbCByZW1vdmUgbm9fdmVjdG9yX2NhbGxi YWNrIGZvciBsZXNzIGNvZGUgY2hhbmdlcy4NCj4gDQo+IA0KPj4gwqDCoMKgwqDCoCB4ZW5faHZt X3NtcF9pbml0KCk7DQo+PiDCoMKgwqDCoMKgIFdBUk5fT04oeGVuX2NwdWhwX3NldHVwKHhlbl9j cHVfdXBfcHJlcGFyZV9odm0sIHhlbl9jcHVfZGVhZF9odm0pKTsNCj4+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+ PiBpbmRleCA5ZDU0OGIwYzc3MmYuLmJlNjZlMDI3ZWYyOCAxMDA2NDQNCj4+IC0tLSBhL2FyY2gv eDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+PiArKysgYi9hcmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0u Yw0KPj4gQEAgLTUsNiArNSw3IEBADQo+PiDCoCAjaW5jbHVkZSA8eGVuL2h2bS5oPg0KPj4gwqAg I2luY2x1ZGUgPHhlbi9mZWF0dXJlcy5oPg0KPj4gwqAgI2luY2x1ZGUgPHhlbi9pbnRlcmZhY2Uv ZmVhdHVyZXMuaD4NCj4+ICsjaW5jbHVkZSA8eGVuL2V2ZW50cy5oPg0KPj4gwqAgI2luY2x1ZGUg Inhlbi1vcHMuaCINCj4+IEBAIC0xNCw2ICsxNSwyMyBAQCB2b2lkIHhlbl9odm1fcG9zdF9zdXNw ZW5kKGludCBzdXNwZW5kX2NhbmNlbGxlZCkNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5faHZt X2luaXRfc2hhcmVkX2luZm8oKTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fdmNwdV9yZXN0 b3JlKCk7DQo+PiDCoMKgwqDCoMKgIH0NCj4+IC3CoMKgwqAgeGVuX3NldHVwX2NhbGxiYWNrX3Zl Y3RvcigpOw0KPj4gK8KgwqDCoCBpZiAoeGVuX2Fja191cGNhbGwpIHsNCj4+ICvCoMKgwqDCoMKg wqDCoCB1bnNpZ25lZCBpbnQgY3B1Ow0KPj4gKw0KPj4gK8KgwqDCoMKgwqDCoMKgIGZvcl9lYWNo X29ubGluZV9jcHUoY3B1KSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5faHZtX2V2 dGNobl91cGNhbGxfdmVjdG9yX3Qgb3AgPSB7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqAgLnZlY3RvciA9IEhZUEVSVklTT1JfQ0FMTEJBQ0tfVkVDVE9SLA0KPj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC52Y3B1ID0gcGVyX2NwdSh4 ZW5fdmNwdV9pZCwgY3B1KSwNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIH07DQo+PiArDQo+ PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdfT04oSFlQRVJWSVNPUl9odm1fb3AoSFZNT1Bf c2V0X2V2dGNobl91cGNhbGxfdmVjdG9yLA0KPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAmb3ApKTsNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IC8qIFRyaWNrIHRvb2xzdGFjayB0byB0aGluayB3ZSBhcmUgZW5saWdodGVuZWQuICovDQo+PiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIWNwdSkNCj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgQlVHX09OKHhlbl9zZXRfY2FsbGJhY2tfdmlhKDEpKTsNCj4gDQo+IA0KPiBX aGF0IGFyZSB5b3UgdHJ5aW5nIHRvIG1ha2UgdGhlIHRvb2xzdGFjayBhd2FyZSBvZj8gVGhhdCB3 ZSBoYXZlICphKiANCj4gY2FsbGJhY2sgKGVpdGhlciBnbG9iYWwgb3IgcGVyY3B1KT8NClllcywg c3BlY2lmaWNhbGx5IGZvciB0aGUgY2hlY2sgaW4gbGlieGxfX2RvbWFpbl9wdmNvbnRyb2xfYXZh aWxhYmxlLg0KPiANCj4gDQo+IEJUVywgeW91IGNhbiB0YWtlIGl0IG91dCB0aGUgbG9vcC4gQW5k IG1heWJlIEBvcCBkZWZpbml0aW9uIHRvbywgZXhjZXB0IA0KPiBmb3IgLnZjcHUgYXNzaWdubWVu dC4NCj4gDQo+IA0KPj4gK8KgwqDCoMKgwqDCoMKgIH0NCj4+ICvCoMKgwqAgfSBlbHNlIHsNCj4+ ICvCoMKgwqDCoMKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+PiArwqDCoMKg IH0NCj4+IMKgwqDCoMKgwqAgeGVuX3VucGx1Z19lbXVsYXRlZF9kZXZpY2VzKCk7DQo+PiDCoCB9 DQo+IA0KPiANCj4gLWJvcmlzDQo+IA0KPiANCg0KVGhhbmsgeW91LA0KDQpKYW5lLg== From xen-devel-bounces@lists.xenproject.org Fri Jul 15 08:21:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 08:21:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367963.599141 (Exim 4.92) (envelope-from ) id 1oCGZI-0007PL-Ds; Fri, 15 Jul 2022 08:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367963.599141; Fri, 15 Jul 2022 08:21:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCGZI-0007PE-B1; Fri, 15 Jul 2022 08:21:00 +0000 Received: by outflank-mailman (input) for mailman id 367963; Fri, 15 Jul 2022 08:20:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCGZG-0007Or-IM for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 08:20:58 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0c2a6fd2-0417-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 10:20:56 +0200 (CEST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26F4ZjZ9024288; Fri, 15 Jul 2022 08:20:50 GMT Received: from iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta03.appoci.oracle.com [130.35.103.27]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h71scfcms-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Jul 2022 08:20:49 +0000 Received: from pps.filterd (iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26F8BjCs009765; Fri, 15 Jul 2022 08:20:49 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2172.outbound.protection.outlook.com [104.47.55.172]) by iadpaimrmta03.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3h7046qbgh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Jul 2022 08:20:49 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BN8PR10MB3282.namprd10.prod.outlook.com (2603:10b6:408:d2::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 08:20:47 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 08:20:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c2a6fd2-0417-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=I9k6znyuZNGJI5ofq1Xh/B9hlJ3AE3YMMudmaZJ66n0=; b=JgbHp+Q/QFx3qBdiqb+3eMDq97Vz2MwfkitRZk2bL8K03JgABtwiOZpZDS6LVIG3DYJB 0zlxR+FhzvOhCRRB2oygeuTSS4WFrWjVbka8PrNFFtjdTDGQ/MWMm7rJSsJSEuhzvugI c/AayQQDkty+1fJyXK3Qz4c4uzyx+wJRuYABQibQHgRijeB1RliaS4gtd0EwNjOy87fo rBvkGdcjv4efEcMg8c0s30o2kdbsxE9VQdkXFADfMwuj4NrgLnmX8Sq/jRjYa9t94HtF M8Q1NJniZvtq7Y5wPBgWzAMnuj/ywc/HN/IkNV3MWat3Q7Yc0YHsFORYFccP7EOre16S 8Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CnTJDVvKpAQEhD2YBB494lk5QmIDLfQZN6PHo8Mypan8IG8svN03By1PU19UQtjUIzfozXIX4u4to4NTtpZ+cgYMIwqD+XXGv/Z3HS3Af0HLTtciw8S8vHNTJFJ1yr07EQ6jysqEHBbz2Fiaf7jhCOsMxn0L6pnyHAEhcrDBsxD1EQ05tO0Qfnimi20BMPvX69a+le4qdI6IbpGolAtCHZ5nW3EC4jBqqYG1hGQuP1Eb5YtZJVLKSu4dR3Pr9RtbDH5QyMVEQdV74uHoT5kKlCMAKM1gTLF3uUt3aR8PX6oaVmXdv8CWxWoLB/bC4tkKRhmXiR0E4awluH9tvx9esA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=I9k6znyuZNGJI5ofq1Xh/B9hlJ3AE3YMMudmaZJ66n0=; b=IX7QyS1Z6W8xIekxcg6MCqezadlFDbva0pTOvQk6HC+C3PjkdzrGNJ6WpufPu46qSbQu6JbZlIeUzPRFt/P9VhoXUDVzHojc0jDrwHjynjkz/gLePnrR+70hiRKSB+5X5uyVsJ7lfpK9wTNEEuPt0ArEjshbcYpmX9Rbp1d4U6lBmC+VGWNlcipPqwCS4UDWSuqidZ2TglNTFuCVRr6g81JzMpO7IfFCye+0r4aO4KVBfm17RgEr6Vx8aKnHCWaDS55/HGHHhZ59VJNjLhJPdkmshETSnI1z0PSsrDqBs2K9QUBoU0UeD5xAMs128KZPuBB2tmlEHQpsv1dRGuVK4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I9k6znyuZNGJI5ofq1Xh/B9hlJ3AE3YMMudmaZJ66n0=; b=sCdL9fUI/s7csGNiiUmvU737quPaGbpzyEEx+pyRbFv1Z9EEXiEunI8qn1TX0Ir8pFB8Wevih8tNSPHgr84YynIfS0IUL9iJ4Clo9rowmv2stUGDA8Kou+C1Xd8YS53VWHGA9G6SVWlfs611fELqLMB1gvPbX3PlUkvavJk55sU= Date: Fri, 15 Jul 2022 11:20:37 +0300 From: Dan Carpenter To: Juergen Gross Cc: Stefano Stabellini , Oleksandr Tyshchenko , Andres Lagar-Cavilla , Konrad Rzeszutek Wilk , David Vrabel , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Subject: [PATCH] xen/privcmd: prevent integer overflow on 32 bit systems Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding X-ClientProxiedBy: ZR0P278CA0187.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:44::9) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f246f03f-843c-4e75-6327-08da663aeb5a X-MS-TrafficTypeDiagnostic: BN8PR10MB3282:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OEzQ+VsbPWXDH1Ck6JOYBnJHg4u58xwIw/EOItlK1Jx0kUwoAoWDZW6swP9/ktTuSvqMFyCvSqgBm0VgQn2VgBsbGdfMyUO+WNW0a7H2s1Jq/58mSppiidflyCb9jPvJcL6Puuwl5cOStRit9Vb7+vWqjiIzduz+FaVVGjNRLwJqLZ7mc+wYOsByLEbaLoTQqxtzfw2qr39jqfAIRqOaUfaReUQq4SPgJ1N3a1DGJmIEJQKuf3TGL73ON7wtMCL4zrSiCXub9NvbQeY6rQ+ugiaUJX00TctK6hOGK+6a965GjXs6UFSeg9FBsbIfeEIiq77QOUPXhiuweEPAqJ79vu+GHYizOkui77ULy0klFQaaw4WLf4ufpYccWKpvXIWRWyhvKE1cWVxgSO6OUyxGO+R7YoSUEdvF6Bk5uQ1e7D2wnfarc1B07xSJ9jXZiLtKZyr8VXZm5DEdY0LHvMchgChM0Tjn9RiwglSY2NzplcFLxVSAcHz6sPuRteqinEEtDA0NnL3kj2HNkmU8w0OkIwHvpEE0ybQ4MxjXf6K4j1y4IkZW/1RSO90Sxb4n3VowtPsUTzu5bsXB7Ib8vFCxWk1Hlnc8T+KbdRS9ThASGUHzdMPB/JuEb/61lGoERbgpxHuUwLC/OOoitUCdYw1OSv1QMVZsmXKXgm9sq3XECCGj08tW5ZhibiO69Y+L38Kk2oujPDDNXkjBEMrWtt1x6e09F2i2QCTubTU6VeAMHMA1HmxLvPAIF8fuftyIJ9gazzjyoW48HKTaU9tmfQ0CSSpedzNJ2VWlFeOpLs6nRjxbA4Vdm4u7YXY2aFWj0iMk X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(376002)(346002)(136003)(366004)(396003)(39860400002)(316002)(6506007)(2906002)(66946007)(44832011)(54906003)(5660300002)(6916009)(26005)(83380400001)(52116002)(66556008)(41300700001)(33716001)(8676002)(6666004)(4326008)(66476007)(478600001)(6486002)(8936002)(38350700002)(9686003)(186003)(86362001)(6512007)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?HwjIgLKd0J74mlo32cu3Ur60YPaX4C1uA80r7kYCGO8bxp73oJ587/zt2m+1?= =?us-ascii?Q?EmV0JSpcTEozd/jPNBA8AQpI7Dp3bcba5x4zhNMU+cnNOzTaN6BfzAeG/dVt?= =?us-ascii?Q?8Dy8uqB5kfJmxtoABOZGfJChVfB1czUaMK3h6U0KzKKeaoRMzSjofKsvn6VI?= =?us-ascii?Q?lt9SwgLGjPpdCzkYw64Vyo0yn3sCXj1I88qGobdixWLoyF5mfFpcXBGtJMP8?= =?us-ascii?Q?UAgr67eLZfIYx/Ew4jK/SmnkNj0BqdZzwSU37UuUQcXGszxJf2CSfjEXcrkH?= =?us-ascii?Q?VrknbKt7b4wAMoIpGPzL6PT4s+nZUDB9OLH5p1Xqcj0VGhWXlIcUeDegTbZ9?= =?us-ascii?Q?likGHG1uaK6mb2pHxi9d9SmLNfoF7GByHvLUehPfoE8Xdd4pCDrel+0wSu9t?= =?us-ascii?Q?U3037Jl/6oP5bdmobwXzTaJs823nwLpKPJRPbfHNnFNI6rhHZYz5VW8ZN5kt?= =?us-ascii?Q?uzpzkJ9ehQK3xp8rcYxuIqAtW9RQ/92laj8Uw1MfSWh55d6iXuRhPGRg/iY6?= =?us-ascii?Q?o0Q8nsm0zHLawSE3uQNPLKQssjgGzq8v4L+3nK0owTR6RpMUmywWOjLo3V2r?= =?us-ascii?Q?KueossACW7b+2T21YQXQdeb5ozMjL71Fz0dmwJY1YwbQkQkrwejMYKvHydKe?= =?us-ascii?Q?tyK2CR6CGsZNE8DMUFsm2p2EGIgilGY6DA5cIkBKKXMKVdH24jahRc3TWwXr?= =?us-ascii?Q?gaxrvWhAmmeD7R317XwvOcKszxgpAukkdwaj5YwIrFg8zGBwsahN8oF7hee0?= =?us-ascii?Q?jab3b4MAobRKWWZOjZ9rub7EWZsTF3LNio0SsuvHaXYOmTLfN3Gbj5wB5VXo?= =?us-ascii?Q?rRg/00d4fV/ONZPx0dLRuR8nemPOwTLs6WBmUrOJsm4aUlYTTmHjAI+Ipv8l?= =?us-ascii?Q?+aLC7MqaIDCnH5g3AlliPxDTO5Vp86lb+lMnjLg6XfHIs/Tmjj0H+UKo+1ds?= =?us-ascii?Q?7WBMefTsZPJfqq9WVtdGz67hUFQRxcyFAv7ou/IgnhFLeLvVYZO/USO+6Du3?= =?us-ascii?Q?8PM/nrtpEDQ3BvuarVaGIe64jlT0VlKmkv/0Y6/FzWDawBh0oCMs4YtoUIpd?= =?us-ascii?Q?ihACGQoP9NbqLN4qvTuW25ZIWtxlTlekF2Sf6/vQsXH/9qxV0Jl5mniew2C3?= =?us-ascii?Q?6v2xxErx1uuh7eX/KSBRCJQHkVtybeW23bfEzrRvHSSc7dO52qe0PFBChLom?= =?us-ascii?Q?goGyOv/R3mqq6SW0Oark/Zln662mhlfQs5sARWkr/E8z3AfNhCzO0IQNOxPV?= =?us-ascii?Q?JDQe6walC+wry9iw1pqSSWnHXUh59ESMepP115q5qE0XIyygfAPLDLQgq0ma?= =?us-ascii?Q?83G89U2EB3GXpm3D85CXNbWkJ5m596/7uUBrVJZTxFa6cv9y11hqgT1Htu/9?= =?us-ascii?Q?BaTDSdZO822OBZpATdGwkOOg1ZT/yT8QAv8SAH8IeZ/9QXlGabVVIaC+q9lX?= =?us-ascii?Q?wT4v0SajHmUnqGfr/bgihLdDqjR7QsK4C1IFlBtDI4SWLPz+qp8IEM8XJMRt?= =?us-ascii?Q?xSCvwziwQx1wcvKlwnHGGToU/Xej82u366rqHfc77XdXOaNLGvSpVY2oHdyX?= =?us-ascii?Q?BkI3ZXVPsvBUuvPBVjgmB1XnEnseM08rC27e76YU266EAJwqF/jAc7/TE7NW?= =?us-ascii?Q?fw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f246f03f-843c-4e75-6327-08da663aeb5a X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 08:20:47.2020 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iimI9xoGMLQlXr1C8+btkV2f50MHWnB6hwnPtRcOOlj8rEpdmr4NKbcMNfimBss8NwtmGHivo7UltHbNmsEgoXz6Ni1SRvgs5Pi+1lBOVjk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3282 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-15_03:2022-07-14,2022-07-15 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207150035 X-Proofpoint-GUID: z65xdZIJiF8oR_iDbVd2Umha1-w-OwIn X-Proofpoint-ORIG-GUID: z65xdZIJiF8oR_iDbVd2Umha1-w-OwIn The "m.num * sizeof(*m.arr)" multiplication can have an integer overflow on 32 bit systems. Probably no one really uses this software on 32 bit systems, but it's still worth fixing the bug if only to make the static checker happy. Fixes: ceb90fa0a800 ("xen/privcmd: add PRIVCMD_MMAPBATCH_V2 ioctl") Signed-off-by: Dan Carpenter --- drivers/xen/privcmd.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c index ad17166b0ef6..1e59b76c618e 100644 --- a/drivers/xen/privcmd.c +++ b/drivers/xen/privcmd.c @@ -456,6 +456,8 @@ static long privcmd_ioctl_mmap_batch( if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch))) return -EFAULT; /* Returns per-frame error in m.arr. */ + if (m.num > SIZE_MAX / sizeof(*m.arr)) + return -EINVAL; m.err = NULL; if (!access_ok(m.arr, m.num * sizeof(*m.arr))) return -EFAULT; @@ -464,6 +466,8 @@ static long privcmd_ioctl_mmap_batch( if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch_v2))) return -EFAULT; /* Returns per-frame error code in m.err. */ + if (m.num > SIZE_MAX / sizeof(*m.arr)) + return -EINVAL; if (!access_ok(m.err, m.num * (sizeof(*m.err)))) return -EFAULT; break; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 08:53:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 08:53:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.367974.599152 (Exim 4.92) (envelope-from ) id 1oCH4o-0003E7-Qr; Fri, 15 Jul 2022 08:53:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 367974.599152; Fri, 15 Jul 2022 08:53:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCH4o-0003E0-O1; Fri, 15 Jul 2022 08:53:34 +0000 Received: by outflank-mailman (input) for mailman id 367974; Fri, 15 Jul 2022 08:53:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCH4m-0003Dp-PR for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 08:53:33 +0000 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 999bb09b-041b-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 10:53:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 999bb09b-041b-11ed-bd2d-47488cf2e6aa Date: Fri, 15 Jul 2022 08:53:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1657875210; x=1658134410; bh=DKp8LYg+guIukYB1LLpLmqp/yuSY1kfQ9mOFW6QmJK4=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=nhFy0t58ITp+i3b14mevJRP5GHUPxkwn86VRedxBn2yqO+bZTw+3D+8oLITc3MwgU 09jPNC32+dJnEn0O9eF5EZ3MyXVhx4FtVqZT80f32qYzu/fidB843D6LOfRz9QuiKB H7fUQZmntQM7MVGrCr7FV+Q64J7gVnaFeAnDdyemK33qRdSMvTk8L0ShsgdvkTfGuU QnnDTMLe4FTUCPJaGl1rXejc986dZUwIaMplo5SKJ8ti1KzRaiHgxYw5//OaUyqKB9 oVzI9Ks764nQRvBDHQjQf872KkBHOot/mL6L62/JHfqx5g4mrbgnpNcFflTym95Jzp yKhv21O0M4GjA== To: Andrew Cooper From: Mathieu Tarral Cc: Jan Beulich , Xen-users , Roger Pau Monne , xen-devel , Henry Wang , Luca Fancellu Reply-To: Mathieu Tarral Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Message-ID: <8xw3d1YneEfFrFwF4YmilgJ0_F-AsJxCZMUFdsGm_TJOKc7q1IzeQ33kC0XKLdfRGRWQLJ1vUfIa7tNDnHxjN9Bb9g5PJlJ_TO22uT25OO8=@protonmail.com> In-Reply-To: <2e761a65-f24b-edb5-6a7f-cebf47d51c68@citrix.com> References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> <2fad8072-e5f1-2302-f01d-82f744606d9b@suse.com> <2e761a65-f24b-edb5-6a7f-cebf47d51c68@citrix.com> Feedback-ID: 279104:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > > > (We're trying some new project management tools.) Can you try opening= a > > > bug here: https://gitlab.com/xen-project/xen/-/issues about the > > > check-endbr.sh issue? I'm getting a Gitlab 404 page when trying to access this link. Are there access restrictions in place ? And same for: https://gitlab.com/xen-project/xen/-/issues/26 I see the fix is already on its way ! Thank you for the great support. Mathieu From xen-devel-bounces@lists.xenproject.org Fri Jul 15 08:56:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 08:56:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368005.599181 (Exim 4.92) (envelope-from ) id 1oCH7x-000553-Lv; Fri, 15 Jul 2022 08:56:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368005.599181; Fri, 15 Jul 2022 08:56:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCH7x-00054w-JB; Fri, 15 Jul 2022 08:56:49 +0000 Received: by outflank-mailman (input) for mailman id 368005; Fri, 15 Jul 2022 08:56:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCH7w-00054o-5W for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 08:56:48 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0d90c53d-041c-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 10:56:46 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26F7SpwY029778; Fri, 15 Jul 2022 08:56:35 GMT Received: from eur02-ve1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3haua5sb4n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Jul 2022 08:56:35 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by DB3PR0302MB3259.eurprd03.prod.outlook.com (2603:10a6:8:6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 08:56:30 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Fri, 15 Jul 2022 08:56:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d90c53d-041c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TjjPiJWCnyHnGLRhmP0pjDqQ3cDougDZWJmerU/mjLfhnxonnK4z35AlWIRLnjT4jSVqhE+s8j7mRIPyZuKOxtnvOec+8zwtiv7ZY98PBy9vxysyVXPY6HCKa/1CrmEkI6E1UpvhWrsqpJvF9+v30Xr1jKQM+oz4z2ojNa3F34S7q72G2oqaLizxSVtb83i/DKGwc/FG2SVBTTa9FJuKHawiSupxLRvfCVzq+/IrXX0w9MmXAowzMkm86Ix/wYnr0PZZAUxys8dYAxJds0pkGP5MAfu9sKKqNKTU36dJKJrE/nb9A9BKZg5n564QZ/QyfbAGIz15nh5OML7x317y7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ul4YRkWIBpTNfduzak5HQ9qlutYvL9Q30qHW4nlXxgk=; b=SCdm2lXJtwkeJU5qbmOuFjct6qwKP1f8vtV+6HjdpwrKUavI8PlMpMzg9n/QfthQWxVFx9rAbsApr3eMhHQnQqdYLbUWXwCyIw+Uvx20/4YzKch3VbJ3NFyJ2cGGTjT5L7akn+iQtcliu0+TEKK3i7iKFHAKDfjxSxAUg6w4sz40g7psJ5KoZ2PVVC8rf6u/CR4JZNpiE9Ab7kki/Uf4XgDby1/MEXVK8sjb2hgOL50LOsoCJjW5T6kPoLZPggSvOpD82AnBedbres/BHp3mPuf/4y2yu+xsHG9LJTtXaNVll2it4AEwr/6LQ4iDnWtiIK20WULJf2G/wcIXDKK40A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ul4YRkWIBpTNfduzak5HQ9qlutYvL9Q30qHW4nlXxgk=; b=fScKFPK1hOav/gD8RSLygCBxzjvfmeFDUOZtKqmQ7ffz990zBArWbX7X8f+A2TSt1fXnY/+ZGvBZJnr2oD18Mxv9t93VghlXNdh6ludMvERShlSqo/k3spibDPMR+V2qBDpO+l0r1J+1YHAe6vybQkDZYBP9shX9E9wbsIqc7tyjb44FQx0KTUamvV+tyTlYe6zVbBlbILWTZzFsPROYN/H2STtZZ/9nKS56yxyf8d5/crDGK/+J+shXDhgYzIHaQVE3Cv+pqmgcPIGLlot/TQMrUl2cPtqZmQFNRTJwhSnm9+Ebchk9hWykhIO7753CMb3j5ew6ZQUbKHSBblIGgw== From: Oleksandr Tyshchenko To: Dan Carpenter CC: Stefano Stabellini , Andres Lagar-Cavilla , Konrad Rzeszutek Wilk , David Vrabel , "xen-devel@lists.xenproject.org" , "kernel-janitors@vger.kernel.org" , Juergen Gross Subject: Re: [PATCH] xen/privcmd: prevent integer overflow on 32 bit systems Thread-Topic: [PATCH] xen/privcmd: prevent integer overflow on 32 bit systems Thread-Index: AQHYmCjGqfExByPyt0K1yo9lRsWBCw== Date: Fri, 15 Jul 2022 08:56:30 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 00415b8c-42e8-47b0-758e-08da663fe8cf x-ms-traffictypediagnostic: DB3PR0302MB3259:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9qhEQhfTEDu04inhMjET/lxI0Pvl8uLOSoHzvnfTpmk8PMO7fFDU916vkRUcqxG0EZM8oc+gbdRjL9+NToNjtgkDndpEDa98VM1nGjKiFulsE3fHVHzuPxn1aXvjDxaLF4CYf8bRS49MVbP6OKAERhuiNo9DOEIv44gJWbthfT4aORiLqg1vqJFuCyDtj7iG7QZvqgVUkJa6NLMyD+/BSdm/Ai+cD3K+0UP/sZ/MgXDroZ9d00vs3Z5sMSMCxV1gZBZ+tT2/tpcIv2uouYZLKdzCP1QBMJbuagOyMXcP2WytfD+jgwSX66mR5xC0Uu26HXPTNXPG+3jsav4D/l3sV5yJelDia3wpeiLCZCvPgP/23hxQ5aiaCdBB0dig8guJMN8qFlj1w+XZnEak97aJ6h8MCvhVXNoKOlYqQGhgX5PFD3u+vHAkLfBhAHNXOhzYFcaTjvsh6AvxhriVT/sDWUo6To+cde7ajpUmKAghIDBKIDE7gr7js60axUS8HGVq/+xkHQ9BCpSLH7KMf3zajyrMcGN+Zj9+Di31De9KzECyLhsnApk3HPRnGed9fRmKi06Oys9JqzsQVzFRXbcsUa/eK41llcOqi804I+/AHX7IxV4n2Z1EgZNDNtw4oJjfQjx5xI5bp6SJd0NsSt48jJ8/95ysar84ftvxFU8hA4ZBl+KtxGsUHCUnChEMp+mG9LEu43Lu4SSOX9l+V3SyDbkYnpX+ZXjaILpba4urjst/VmiRg6tRnodnIzOjDebgDX+VfxSG60bOq0Q0i1UxVAyeZZWU6kPjqa5iOBbxGjR97cOCIumz2WTBDQosJyICPzg7i5JfwY+LlFup5qb3H1yHwBbrA9GgysHthEa9Zvs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(39860400002)(376002)(136003)(396003)(26005)(2616005)(6512007)(6486002)(71200400001)(55236004)(2906002)(8676002)(41300700001)(31696002)(86362001)(122000001)(66476007)(5660300002)(53546011)(6506007)(54906003)(478600001)(6916009)(38070700005)(186003)(31686004)(316002)(4326008)(91956017)(36756003)(83380400001)(38100700002)(8936002)(66446008)(76116006)(66946007)(66556008)(64756008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eTR0UDI2d2IzTmJIa1U5SSt4RlE1bmRhY1BobitSb28wTzJmdUprQlVrbEQ4?= =?utf-8?B?M0ZwakZiSzd5MlV4OHpPcHVqZVhNbVlnc1RkeHl2cWJrbkNHSXFRMGU2M3Rv?= =?utf-8?B?b0VPT2oxcmNDdzFBZzZ0bFg5SHRPQWtTdGJibXYyVDM1S2NhUnZHZnpWZXRO?= =?utf-8?B?SEI1c1ZqMU9McWtHN0N3ZnF3UXNobU1ZQjMvY2p6NVJlTmcxY2pqZ0ZxbnFC?= =?utf-8?B?SlAxNVFLWmg3WlM1eVhhaENsVlV2M3lZOGM1K3F4S3paVktibWR0eW51ajZt?= =?utf-8?B?TlRPdWJlUWkwcW0vQ1Y5NFMzVUl5elhDZDJGbFc3VnovbWFsT3cxbTcyZlNl?= =?utf-8?B?R2h5Ry93S2lPSGRYMzk4VWNoaXB6a0RRUk1pa0N0dmdCYVhSNER4WHZkZlFL?= =?utf-8?B?UW9XUVZZci9KN3NtQ01COG8zdzhaeVhNb3lUd29rMWU3dTgxSW43cVFoeTVP?= =?utf-8?B?MDNJekxkSmpneU9SZ0RYUGJ4U3liQWRxbC9ZVDI4WDZERlc2aHhHSFI0Nk4w?= =?utf-8?B?RldJUW16OTg1QkM1M2RDN2lzcXduS3d6NHA4UmtGUnBtYUJUaG1JYkF3NFVl?= =?utf-8?B?MmdQbkxBZlczNnRJVUpULy9hdWFzL1hxY2VXbDVITlBGaXJMWVVyTE9MTTVF?= =?utf-8?B?NWhzVDRmS080MzdHVXR4ei9DaXpDeHl6ZzNabWpFL255YmNwTkJGWTlzdGxn?= =?utf-8?B?RHE0MGpNVmlKcGhsVEk1YWVJNkpFWVViRktMRVQxaFNYbGtUZUMvbW1sc2N3?= =?utf-8?B?bWJwZDBva0RYVnZIeGl1SXRNcnJSRkx6eDdhVDlWQWNaczh4YkxzR0N0U21U?= =?utf-8?B?RXpETTkvWFVGWE1WUDA2V0krYTNYMkpSMC9kUGNQam05UEUwamEwU1NZM05V?= =?utf-8?B?a1dIMTVHMWJIcDg2WTV5UHZVR0VyMzNaems4MUcxTUpFMGgwM2NoZGs5YUQw?= =?utf-8?B?SGk0Sm94NjBaSlEzVEoyTUd0QkhncnlTRUxpZVZzT0NPKzdMc1JaNjhqSzlE?= =?utf-8?B?NmJiS3kxV081dUhjalVCb2RlTUlNNnFwMjBhRldsbkpKVThCTmY5c21kTFpV?= =?utf-8?B?RWlZb1FoL0tIbmRqbmJEWTZjSUYyYVRvTDhvYmd5NWR3Smt2SWY1WnY0akVX?= =?utf-8?B?b1JIeG9EamF6N3JySThLTWQvVExxTGRXZ0hwWWJRcVpCaXhaQ2xLYTdqYzZa?= =?utf-8?B?V0JsOXlqVjl0WkR1WVZUTlByKzF3b0M1UlRaVlZ4TXgzRmVtL251TjVzcDlt?= =?utf-8?B?QmhwQ0ZETnN5UTVnWHNPa0NyN1JRWGtpdGJHN2cxN2pkY2FrakZrOGJlMXRS?= =?utf-8?B?N0svWXRsOUR2WVh0dkVOMzFRYXlBc3M3aXErOXBBRkNjTHFra1AxVy9ncnVN?= =?utf-8?B?QVRxWlZjTGdxaHE4NjZ2VTAyV1BvR0NNZnI0NGhGZVNRZWFwcXpYSjlrVGtY?= =?utf-8?B?NGl1TFNSdGlTTjRldHJXK2N4V3QyOEt6UFlHR0RMS1BXbTRibEpOd2J2alFM?= =?utf-8?B?MHltTU9TSXM3VzlISm94T2FOTXc1eXV3ZUpNL2NNNllXcUtsc0FJVFBKWlNS?= =?utf-8?B?amQ5QkRVQ2NjSEN1a2U2aHZENW4yR1FPVmdjWlFkVkZ3cllHR0crMXJhN1l2?= =?utf-8?B?WVVwUDNoUHk2czF2QVdETUJLdC9iSlVEZHNaRGc3amFQV0VUM3E2MnR4Nmoz?= =?utf-8?B?cUFsR2w0cmZINncyMGtSTUd0YW8rSFNIUEJudzlkbmx6enFhNnFUTzE2VjU5?= =?utf-8?B?OGJmYWpscDliRk9qT0lIVmt3cE14clRtSGRReUc0YU13RU1zdVV1WVZhOHFp?= =?utf-8?B?RTUxVGdmTVlpU1l3eVpJaTVhNVpPS2pkT3VhSFhTVlNtc0tkOGlxMHJaa084?= =?utf-8?B?WDBSNU9XaHlaVzl1eHprU1REWU5iWUJBZ2FKVVowcHk1dEIwQTN3ajl6VHk5?= =?utf-8?B?UE9yZ0lEZW10ZUtwSCtUeWxDNW9Dcjl5NnZRUGkyOHBDREg1cmo0WkRKdzFX?= =?utf-8?B?R2o2QTRHL0Zyc25yRitTeSthZlVDVEg2elNFN1d1Rk44NjNQTTk2QXBaTlB4?= =?utf-8?B?S1Q3akR3SEM4dTk4dU5vVXhJOFhVWEZHdlllV0xHZHozTGxlV3lSeFFrVUpZ?= =?utf-8?B?bnhUblZHRTN1SUQrYU9vZjJqRTZWWGFXc0lQM1Zha01FQk1TbW9iQkxieHdp?= =?utf-8?Q?0o0FWIHU00rvo9yQDmmd0PM=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00415b8c-42e8-47b0-758e-08da663fe8cf X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 08:56:30.0916 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ZOEMLDFOeAIHyMQBYAlngCEwycubE3A0w1LYYxbCIEqsrxpgPyUlwm4piGvDbKH5G2xLFta+eRA5BPZ1Jmb/OPTofi7KJQjnhel3vwN92U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0302MB3259 X-Proofpoint-ORIG-GUID: mqAfiAXF7dypPOmkr6zyfVeTeAlt-WQj X-Proofpoint-GUID: mqAfiAXF7dypPOmkr6zyfVeTeAlt-WQj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-15_03,2022-07-14_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1011 mlxscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207150038 DQpPbiAxNS4wNy4yMiAxMToyMCwgRGFuIENhcnBlbnRlciB3cm90ZToNCg0KDQpIZWxsbyBEYW4N Cg0KPiBUaGUgIm0ubnVtICogc2l6ZW9mKCptLmFycikiIG11bHRpcGxpY2F0aW9uIGNhbiBoYXZl IGFuIGludGVnZXIgb3ZlcmZsb3cNCj4gb24gMzIgYml0IHN5c3RlbXMuICBQcm9iYWJseSBubyBv bmUgcmVhbGx5IHVzZXMgdGhpcyBzb2Z0d2FyZSBvbiAzMiBiaXQNCj4gc3lzdGVtcywgYnV0IGl0 J3Mgc3RpbGwgd29ydGggZml4aW5nIHRoZSBidWcgaWYgb25seSB0byBtYWtlIHRoZSBzdGF0aWMN Cj4gY2hlY2tlciBoYXBweS4NCj4NCj4gRml4ZXM6IGNlYjkwZmEwYTgwMCAoInhlbi9wcml2Y21k OiBhZGQgUFJJVkNNRF9NTUFQQkFUQ0hfVjIgaW9jdGwiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBEYW4g Q2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5jb20+DQo+IC0tLQ0KPiAgIGRyaXZlcnMv eGVuL3ByaXZjbWQuYyB8IDQgKysrKw0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KykNCj4NCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMveGVuL3ByaXZjbWQuYyBiL2RyaXZlcnMveGVu L3ByaXZjbWQuYw0KPiBpbmRleCBhZDE3MTY2YjBlZjYuLjFlNTliNzZjNjE4ZSAxMDA2NDQNCj4g LS0tIGEvZHJpdmVycy94ZW4vcHJpdmNtZC5jDQo+ICsrKyBiL2RyaXZlcnMveGVuL3ByaXZjbWQu Yw0KPiBAQCAtNDU2LDYgKzQ1Niw4IEBAIHN0YXRpYyBsb25nIHByaXZjbWRfaW9jdGxfbW1hcF9i YXRjaCgNCj4gICAJCWlmIChjb3B5X2Zyb21fdXNlcigmbSwgdWRhdGEsIHNpemVvZihzdHJ1Y3Qg cHJpdmNtZF9tbWFwYmF0Y2gpKSkNCj4gICAJCQlyZXR1cm4gLUVGQVVMVDsNCj4gICAJCS8qIFJl dHVybnMgcGVyLWZyYW1lIGVycm9yIGluIG0uYXJyLiAqLw0KPiArCQlpZiAobS5udW0gPiBTSVpF X01BWCAvIHNpemVvZigqbS5hcnIpKQ0KPiArCQkJcmV0dXJuIC1FSU5WQUw7DQo+ICAgCQltLmVy ciA9IE5VTEw7DQo+ICAgCQlpZiAoIWFjY2Vzc19vayhtLmFyciwgbS5udW0gKiBzaXplb2YoKm0u YXJyKSkpDQo+ICAgCQkJcmV0dXJuIC1FRkFVTFQ7DQo+IEBAIC00NjQsNiArNDY2LDggQEAgc3Rh dGljIGxvbmcgcHJpdmNtZF9pb2N0bF9tbWFwX2JhdGNoKA0KPiAgIAkJaWYgKGNvcHlfZnJvbV91 c2VyKCZtLCB1ZGF0YSwgc2l6ZW9mKHN0cnVjdCBwcml2Y21kX21tYXBiYXRjaF92MikpKQ0KPiAg IAkJCXJldHVybiAtRUZBVUxUOw0KPiAgIAkJLyogUmV0dXJucyBwZXItZnJhbWUgZXJyb3IgY29k ZSBpbiBtLmVyci4gKi8NCj4gKwkJaWYgKG0ubnVtID4gU0laRV9NQVggLyBzaXplb2YoKm0uYXJy KSkNCg0KTG9va3MgbGlrZSBoZXJlIHdlIG5lZWQgdG8gY2hlY2sgYWdhaW5zdCBzaXplb2YoKm0u ZXJyKSB3aGljaCBpcyB1c2VkIGluIA0KdGhlIG11bHRpcGxpY2F0aW9uIGJlbG93Lg0KDQoNCj4g KwkJCXJldHVybiAtRUlOVkFMOw0KPiAgIAkJaWYgKCFhY2Nlc3Nfb2sobS5lcnIsIG0ubnVtICog KHNpemVvZigqbS5lcnIpKSkpDQo+ICAgCQkJcmV0dXJuIC1FRkFVTFQ7DQo+ICAgCQlicmVhazsN Cg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K From xen-devel-bounces@lists.xenproject.org Fri Jul 15 09:01:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 09:01:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368020.599198 (Exim 4.92) (envelope-from ) id 1oCHCD-0006gy-Ki; Fri, 15 Jul 2022 09:01:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368020.599198; Fri, 15 Jul 2022 09:01:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCHCD-0006g0-HO; Fri, 15 Jul 2022 09:01:13 +0000 Received: by outflank-mailman (input) for mailman id 368020; Fri, 15 Jul 2022 09:01:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCHCC-0006c5-2s for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 09:01:12 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70055.outbound.protection.outlook.com [40.107.7.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a9e049c7-041c-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 11:01:09 +0200 (CEST) Received: from AS9PR06CA0409.eurprd06.prod.outlook.com (2603:10a6:20b:461::18) by HE1PR0801MB1817.eurprd08.prod.outlook.com (2603:10a6:3:84::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 09:01:05 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::d2) by AS9PR06CA0409.outlook.office365.com (2603:10a6:20b:461::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17 via Frontend Transport; Fri, 15 Jul 2022 09:01:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 09:01:04 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 15 Jul 2022 09:01:04 +0000 Received: from 806764d8dfed.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 1AA9892D-36EB-4F67-97DC-865A2DAEEE2E.1; Fri, 15 Jul 2022 09:00:56 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 806764d8dfed.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 09:00:56 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by PAXPR08MB7202.eurprd08.prod.outlook.com (2603:10a6:102:209::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 09:00:55 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5417.026; Fri, 15 Jul 2022 09:00:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9e049c7-041c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EWTJJoJOTTWwus+6eufr4rhBofDBCzYw8+JcZId3CfKVG5kwnjl7WE604l2jAZTz3vvBGqLzcHq816/JFRjlI+xCySwcpzrrXrx6PSHcEIlkd/7zY0CefX2dVX00L2b4hAiENyKCS3mU5BF5Oys5LABxUPLJzUGSjCidMWZgREDYkQqZefcTzhhl+8GIlWVTLXmkzBya6uEDbZGsos/orrNbYccF6yIZAI9TH9kDF/247WcFMkw/ZQx79oNY57vRemOR+ugJL1hIVflqfdbhAk1BBZTCfqoh0X8E/sJx5BKVieVpB8GWdDLM/gIyDmcnqxRBVU8CQqCVC4A9h+DMqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU56CzXIptzU7NuE6EUpd+7li5NbOLKM3g4lCKJKIYU=; b=L0UbEbYKFH+W4vj1jJ2NMxFH00yDNzgbcIGU32CEPXhjdILGGAYsqUsNjHhgHGVfJ5DtrEdhuQKDQZ02yQmh0rfNYy1jfpyYz33YkeZH54VubpuQMpwhZRJvqIup836GYe8VkElgciXDqFbKSIGP1C8niUGrHYDZ7MRuDOrJKAUu9bJMwrRmGh/GiJ9yntSdIRYNAkccoFM93ivg/3m3br3vIMtXJWpNOfxsIFNPHjLMYW3dVZk9MicrhiYbnrLs+UukU+VnDEQg6S/xNmH19hrRlWKxn191nIhT+Re9AtIQVGsdkFqBgpcNQDTnp747FCzSU76Qx7QgII3vmFcy6g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cU56CzXIptzU7NuE6EUpd+7li5NbOLKM3g4lCKJKIYU=; b=96ndREOJyUfLINQx56xARBJhSVWfJGNfgu+dbF4l+/Gxqx8GzT80mYrbnfkn6oiJl+zFnrfH/ZjMr7+o8D/x+tSnzsk6vIW7vj26xeCO1pp7bobmga14MgE3Cg9czGMuvDRG9DC02luoqIm+jC0ytZCJ67U8ieJCJC9V+PAlMVY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8296eb58a26565a3 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DHgqKdUu7b7ZmrdTqAPwsGGCyBc65pHvyd0QgWu/08QdsL+6CmH7yQ/3DcRt13kp3GhCSrnFYnaC4WAIQBWzxQutYgArEpGP/DKY/wSasOvXnfGQvHYnYO1rCQhiC8heWtH0vytazh+nDGeyf974uyjNbyvPgjfbEA2O9uW75HZa91mThI1cWn87V7/j4t1yzSmTVo/3rlSmRT76UPrgsc6oO/JOBOSJw0AFpPZ2mP6r6lAoyFPl7Bh57LHtSWlksPNzclYDTZ1e3IVp3yVFxFDZpIIJEj4SFAerFz+4ViSUZgojAvC+JbpXOEv+tpgx9cqJucpruzNR7eEbbXZnFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU56CzXIptzU7NuE6EUpd+7li5NbOLKM3g4lCKJKIYU=; b=H9D6nEDzRtRb5duiHADECM8lobKIcgn2cZUHKGTQR9dBqA8WI2CuSWVe3WQHKxi42xsM5xUwoGbpQDu/TxZUS/F4q5vF38koVu1U/tLvvt909ozf8eyiR3mWLLU4hvSWyfMf+up1nvGH3gr0aZ4Vy+3+Fej0WHxAWNvuRaUyvouS+mOcklCluhzBqv+tCAqzBUpBr/YkYbzLE4rHzqp7slnCto7oa+D44kNY0SvhGGOTpB0ybymUpXm6IDP8j0PFK9yDp9BA1KAXf0nEccobWftfrTL0R4O9AKMhH5bLS+GCtQM7Iur+EF84IhtVSwGu/1cZJLeL50+uetMMEK7THQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cU56CzXIptzU7NuE6EUpd+7li5NbOLKM3g4lCKJKIYU=; b=96ndREOJyUfLINQx56xARBJhSVWfJGNfgu+dbF4l+/Gxqx8GzT80mYrbnfkn6oiJl+zFnrfH/ZjMr7+o8D/x+tSnzsk6vIW7vj26xeCO1pp7bobmga14MgE3Cg9czGMuvDRG9DC02luoqIm+jC0ytZCJ67U8ieJCJC9V+PAlMVY= From: Bertrand Marquis To: Mathieu Tarral , "marc.ungeschikts@vates.fr" CC: Andrew Cooper , Jan Beulich , Xen-users , Roger Pau Monne , xen-devel , Henry Wang , Luca Fancellu Subject: Re: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Topic: make debball fails on Ubuntu 20.04: More valid-addrs than all-addrs Thread-Index: AQHYlsicqOth5aGebEinuouQN8xr5618caEAgAAKCYCAAPuhAIAAJpSAgAAJHQCAAAWjAIAAAbIAgAAHvICAAW0PgIAAAhoA Date: Fri, 15 Jul 2022 09:00:54 +0000 Message-ID: <88D45FB0-5036-4B02-8C0E-77EF04D2C14A@arm.com> References: <5952497A-CB6F-4C66-8FA9-8EF9A1A08B5E@arm.com> <9gC8biTj2pIJoXJRy4N2I6nsOUEUjYsbIAj0XZsWdAwiwzXpgBBeBrLFB0bAC7LjVmKwPvzufWHPSVYaWuMl33lKHKbzChEgW4R9QBwJZJk=@protonmail.com> <13TmiNmQ9iXXKyshVeCbt4ul_jYjdNejXrqhIJK7CioLQRgpSITJX1Ik0jNEZZDTUIXs9OvM0qjZJeqRhQl1oKU9IdiZ3W-Ajsqp3sYgt6Y=@protonmail.com> <2fad8072-e5f1-2302-f01d-82f744606d9b@suse.com> <2e761a65-f24b-edb5-6a7f-cebf47d51c68@citrix.com> <8xw3d1YneEfFrFwF4YmilgJ0_F-AsJxCZMUFdsGm_TJOKc7q1IzeQ33kC0XKLdfRGRWQLJ1vUfIa7tNDnHxjN9Bb9g5PJlJ_TO22uT25OO8=@protonmail.com> In-Reply-To: <8xw3d1YneEfFrFwF4YmilgJ0_F-AsJxCZMUFdsGm_TJOKc7q1IzeQ33kC0XKLdfRGRWQLJ1vUfIa7tNDnHxjN9Bb9g5PJlJ_TO22uT25OO8=@protonmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 766a2b0a-76bb-4b33-2345-08da66408c4a x-ms-traffictypediagnostic: PAXPR08MB7202:EE_|AM5EUR03FT033:EE_|HE1PR0801MB1817:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: QLAVgnm7qqxGn74va3zLriCzBlcoT/nZDmPTE7zetm2r6SAE/4ZLZ2RQMMoLyPgYtnIxMOC56nw0OUEmUs4BdxuZvP5bBxNQp9wU8QPhkdhyR+2KbwItEZXK72iQ/vSit6TdqPR7qOESS683y6iyoViD34VvNHMAwTAICUTWGhTEFHu+SuwKuZep878SC9ibBogp/0gPJRBPYMXS9aLCxOggOXyPQVgvU/VCm/xDY/TBxLtlBNZr5z5eWKfWnWVjh+2JlMtDcsrrSnyaZ/oX3jpKS0bIzm19FTgmBRfHhO7Mn7NkRU39cP1F67Z9v0qBZmx2kP1BofLVizkG707uVNKmvJSOcQshdlG5zB//SxBISIUuUT0NXGed00p78guXCjzfnxTz/PLrhz7+I/gUNDKTAp45C/OyM0ZxW2cjEeB/zpzvHBrgxHu+8iKHtRY8QlVfXVV3g5tKIDTXKS3ZxjJEjI7LVdWRqaMllau91r7sgQVbM9k36de+KEqLX2TdAfhbe77xHM/pe8nDrCe/jVSM5Vvsaw0k6v3wZf1mLYwCzXKAFIWdbidNOV1LDLs02QQO3VdgDbjIdfz7o+OIZLBCeVFSr+32HgiYqMGsivnjNm/xSL2ZIxqvJxrdNPksjQBuTY+1oPCACNZW+XRlmnOnEjczCYV2EJgPlgsm3b2KMR6xqz6f5G4Bjpzq/UlN1cPtYmazEJNqda5VkSVHtKA62M+kfvs4y3X0jwAyEdh2VbcTf5vCeK37ZLrMbT7cl1pIOFJHNlIYI7krUhjxvqoN/ufUyXFE16AhYQgwWkbKepsKdUgAYczJX0O4SUH/TP7LzWPzbm7IwqJnzEEqsi05hG/+b/1NSz0DBar1BMx8cOkxbZPzfggj+VYuj52PqAx88x0U+/tRXOW/ylOQowo7NII5tNZe84wdnqS7oG0= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(366004)(346002)(39860400002)(83380400001)(38070700005)(33656002)(8936002)(5660300002)(86362001)(122000001)(38100700002)(478600001)(36756003)(71200400001)(53546011)(54906003)(966005)(41300700001)(6506007)(4744005)(316002)(110136005)(66556008)(66946007)(91956017)(4326008)(26005)(8676002)(66476007)(186003)(6512007)(76116006)(2906002)(2616005)(66446008)(64756008)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7202 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 82ab4198-4961-4635-bbd5-08da664086b6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JnMN0xdXx/hgrmOOKp6RZbV9CgZ/Na+FZm0P342vG9N8Zcjklccj2exMNFAq48CQyx5Kv3MITMP51q/M0dNCpGk6PccWXNHbbhftw+ufCHEgReuV1Rq12pvrWBpu/3hIRmRNUWMoaOiP9xQV3xlIvLDSkIGKrvL+i+5Z+20MAMIOjqXeidhPLuAaksRqnERA9FikEXMEyO6jRHJfR9FJThCrtv/d+rpSL4+yOw7TB0QHgYwIa0UtdocfBAQY1wsYs5V8vyVnXLOkECR7orj7N7rairFWO8G3rWejHhSSpwQRjMB7Wy/Bcu7OgRD2YgpgQweeqbQ4gtlDCFXGeZOnu3T42ubT5kCR34tdUe0SdBdqijFuRO1tH4M/Vp/UKPR0uWVsDo6S6LgwpZcKaZogbYHsbucAduRYrnvWkGdbKlf3JrTKzbiokbe1yyRk3KATMbWpDQTmpUOoNEIqfobAw3j43jci2CZGHgLLZhJiv7O3XzLCuJGbZjPi1P5CFujLqo0cCw4foXlQX1TLPdb/w7cBzQDVvQIJafDSrLoWBriIXLq3WGwLvuIRXjYooYLp25xsy2nRCXQTqbdipfp8nUFJlxFQY212ULjbVeTntv4UAtOo1crTkR4cm3pSmO2vF2Cz+9q2mGmglGwehFgHJ1IUfdQMDVyPV761kW4v1t1McP9bYzxgSwOJPQv1xY/jglgKRLF9ul76rfoUGfI1RsliM1585oV0JyIY2yetbGJ4/IX48NtB+OdkgRCFEt1lDrOm+KrMVsvqfyL30s5TygenKqisFugGskU1vLP7omCwmel82IqhOXAA3z0dLmQSzjVRJPhn97zh+AjHbE7bamuJhb2ROOgX424xRzh1yGON+Mlqt9WjTmPApqE7Z100cTwW/+UiA+Hv0+PgtSB8kw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(346002)(396003)(46966006)(40470700004)(36840700001)(81166007)(6486002)(82740400003)(966005)(6506007)(2616005)(336012)(47076005)(41300700001)(356005)(53546011)(478600001)(26005)(36860700001)(83380400001)(186003)(6512007)(33656002)(5660300002)(4744005)(40480700001)(2906002)(8936002)(82310400005)(36756003)(70206006)(8676002)(110136005)(86362001)(54906003)(40460700003)(316002)(70586007)(450100002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 09:01:04.3018 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 766a2b0a-76bb-4b33-2345-08da66408c4a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1817 Hi Matthieu, > On 15 Jul 2022, at 09:53, Mathieu Tarral = wrote: >=20 >>>> (We're trying some new project management tools.) Can you try opening = a >>>> bug here: https://gitlab.com/xen-project/xen/-/issues about the >>>> check-endbr.sh issue? >=20 > I'm getting a Gitlab 404 page when trying to access this link. > Are there access restrictions in place ? >=20 > And same for: > https://gitlab.com/xen-project/xen/-/issues/26 Yes there are at the moment. @marc: is there a way to let everybody read the tickets ? Cheers Bertrand >=20 > I see the fix is already on its way ! > Thank you for the great support. >=20 > Mathieu >=20 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 09:50:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 09:50:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368062.599221 (Exim 4.92) (envelope-from ) id 1oCHxl-0005sD-Gv; Fri, 15 Jul 2022 09:50:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368062.599221; Fri, 15 Jul 2022 09:50:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCHxl-0005s6-Cj; Fri, 15 Jul 2022 09:50:21 +0000 Received: by outflank-mailman (input) for mailman id 368062; Fri, 15 Jul 2022 09:50:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCHxk-0005s0-Fb for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 09:50:20 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87991537-0423-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 11:50:18 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 05:50:13 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6339.namprd03.prod.outlook.com (2603:10b6:806:1b6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 09:50:12 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5417.026; Fri, 15 Jul 2022 09:50:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87991537-0423-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657878618; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=e3bbx5rylSNKU/LPywsvKq7scNIXTXJNf/37NymovyU=; b=cfDZDWlxQRKEAcAyverTJ/5sKZ4isjbRDDITdMuKUFnTsmk5gBqHNpeG QWfGIJjBCkoC01SsI6P76AbeUpwhdD7U5p+ZBzPz1LStxqIOmnNAqNxlP h2/arayvxL5xPgMEzIarocBWGdkoWadHrzl7i1c903r+wA4TnBclJ6lSu w=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 76298642 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UyhfnK7LY+DKRILfXb37BwxRtBfHchMFZxGqfqrLsTDasY5as4F+v mUaXz2APfbZYGTze9pxPtnipE1Q7MCAzoBmTQY4/ylhHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimQc3l48sfrZ8ksw5amq4Vv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJGEtbZco4953Ozlx3 PYcFwoiTTeyhv3jldpXSsE07igiBO/CGdpF/1tGnXTeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LmAe8Q3PzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLarCj91rGTx0sXXqoOLL25yu9422e4mElJFA0ddX2nuNSm3xvWt9V3b hZ8FjAVhaI17k2wCN7mQwe/vmWHrzYbQdNbF+B84waIooLQ4gCEFi0HQyRHZdgOqsA7X3op2 0WPktevAiZg2JWXRmia7ay8ti6pNG4eKmpqTTMLSRst59jlvZ0piRTOXpBvHcadi9zzFjbY2 T2GrCEiwb4UiKYj3b2T9FTGjjT84JTEJiY57xvaGGKs6Bh0YqahZoq1+R7a6+pNKMCSSVzpl GhUxeCd4foIAJXLkzaCKM0NBLiB9eeZNyeaillqd7E67Cik8XOneYFW4Rl9KV1vP8JCfiXmC GfUvQ5S/5ZVMGGdcb5sY4mxBsIpyoDtDd3gEPvTa7JmZ5h8ZQmK1ChrbFyX2SbhnSAEk6syJ JOaesaEFmsBBOJsyz/eb+wa1b4tgCM/w2z7RJbnwhDh2r2bDFaFRLFAPFaQY+QR6KKfvB6T4 9tZL9GNyRhUTKv5eCa/zGIIBVUDLHx+D5amrcVSL7SHOlA/RztnDOLNy7Q8fYAjh75SiurD4 nC6XAlf1Ub7gnrEbw6NbxiPdY/SYHq2llpjVQREALpi8yFLjVqHhEvHS6YKQA== IronPort-HdrOrdr: A9a23:e7Ezd6CVM6jEf/LlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.92,273,1650945600"; d="scan'208";a="76298642" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HRSOFA5rYVHwIJXfSWY7ghHRTfCd2bZucz8hX6HSkzKSYGhz5AGXkyTkhzKQmTuU1DvdQS9tDe/aV0/aiOR4ejkeXIN04xipd0kxmnLjuDcpcbmPqzvnrJABkPbDkKT9VGY70y8TZ+Pago53ajpjv45hNgdgf1iP3rmwIkUJOs6ZcsF/yiuM3HUlP139ksXywVqjaDhE750SIUfhlGoQsfO1gJZ/ZJhF2ANRF0DZ0+lbqwRe0ylDvzBHlf18To2OJocjGTqwKG/T45ImNT7jZCj73U00mnq+qddKWZwVWw5TTwSGUKIOAtvkrx6Wk68GFgIKdFcY90xof5BS80XLmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e3bbx5rylSNKU/LPywsvKq7scNIXTXJNf/37NymovyU=; b=TOEgel9hJgapPoK9KESfJYdoTc/u96uokVbZ9j1xRN5qdAecXajsGef9yvbCD16ELz4A4isA0+KAODnU+Vw0DBVWsG7O3IJXiHJ9hJxk+0PEzqO6H90mOS8LiOaFrkq4FjRany8oHWnkXoe8anXGbKxD/fIkLHLs/xNOVe5e60rZFbsi6+SDkL+lPw/oN03lV8H60g0ULJlxZmp90AwVwlxgt/GkKuyU3Muc7kPF9E4ACsHVLRHxiFDUn9UYWMwz+nJVu2uZS3UhfY1xGO8EeOU6P2qsJwM5e2CpkH6grccGO0TTUYZM4rB3Z5tlRPhqqAkgOG04Cov5f4J8b0L9/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e3bbx5rylSNKU/LPywsvKq7scNIXTXJNf/37NymovyU=; b=MzPVriiUTKxOTk1rZe3HNRVG89kJJiAclFBII/KeVjy+ngGI952a5Wf/qSE1tD+s7ZuXVH3Hz08/lBo506NQLbPr9thfZlSQA3mTU81TBDHwkoZALx/fvQRRiSoMkgzove8kVOEuzr/rszdIfR2j59vaH/q+wu1XgiUSzZdM4y4= From: Andrew Cooper To: Jane Malalane , Boris Ostrovsky , LKML CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlToncjhzapb0rEGq8Bkg0N3t9a189b0AgAImuYCAABmhgA== Date: Fri, 15 Jul 2022 09:50:11 +0000 Message-ID: <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> In-Reply-To: <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 277626c2-9149-449a-da80-08da6647690d x-ms-traffictypediagnostic: SA1PR03MB6339:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1yfUbqdCwEuFpgWQ+dB0kWaTumNVtG6csgg4ZHxxK63gmxP1WlkjJp/mFqjIyPH6gPUzwS5K6TCmgeUuSRg4JKSzpUM3nsmK/ZwOlSrKX5lxtUkMen6jgeBwTHhxmQhfyIlmFOl/jKh4wbfs7Bg4TCSyOtn0jrl1+F8W2db/IgnNsNl2MDAz0TdQPrPk3RwpX9RaWCpktVvlnZ5G30EmI4yZQjp72vWr8urpw9fma6XQhh2Bfpw38kTr+2txTO2OsKLTrfqyjahH61p85J+04AlMQUJPoeAz6WhBvt2KugWgZjckJ4j8VGaceEeI4AbKaNl/gsmJgUgl/hWOWX3VEmLoETD2WxVE4fr1X/FTjoDISGrB7p39zhOLxSXoqeXWJvXqdvBNFV85Diy4v4q+wtNk/PdCNVeN+JBllV/8mAgArPu3ZSti38LM86TRzqZSihPVXKEj9dSJjv8EW5727QnWnyyEv59UfdYXJwXqvkaUrJzuRsQ/CeFj9VB+N39IKy4b2Kv4DUbZDX1KUOpzQbG3C2l2NGCdN8jz0ffKQMfCp8CRbwWYvrIBllCpd7y7izhrdYzxE8TnQuC4l7tRJaOmC7jHCufZsoynpfV2O3OWXEKpixbdr/KhxlY5/yiNiJyAcLEGMGttLGukRtdM5J+eIDgc2zx8Yf81Gwk5MQbXsR8dackI4oKgddIlZaeGG5nI8UxHJLbYuoSLC+g88O9azZrhIivC42HUv+UDrTsgLVg1meaXBsTFbXtOOPKtIcioV+m83Ig2dw7WL4+uaiIuofzTs2yjV7v9jy7kaGpkSJVh9H82nVMHudhCNZzwLtkLdIRhx4abTnLD83O0u5qxWKOUY8SHwSebeXTB9fxJJ6sgiUPZSgIBGwuYpAy7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(366004)(346002)(376002)(82960400001)(54906003)(66446008)(110136005)(316002)(4326008)(83380400001)(8676002)(91956017)(66556008)(38100700002)(66946007)(76116006)(64756008)(66476007)(31686004)(71200400001)(122000001)(38070700005)(36756003)(6486002)(7416002)(6506007)(186003)(478600001)(8936002)(5660300002)(26005)(86362001)(41300700001)(2906002)(6512007)(53546011)(31696002)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDY1MUxGQTRCSytoeXZOZDBtdlZUMy9TS3dLWWZwcHF4VDdKY3NnS1lxY3Nx?= =?utf-8?B?MDhkVnltY01tYWhacnVlWlNrWWtUM2wrdmRYM1pMaHNDUDZNSHVCNG9ZKzl3?= =?utf-8?B?c1o4Y20rZ2NMeG01bzN2b0V5NG1ta3h2YTQvYXNzSjdmYytIT29vWUQyTlQ5?= =?utf-8?B?cmk5a3BUUDJBSmNnaHFsWHl3Z0ZIN1ZpOGFPOFFIZHdvZHpJbHAwOHZmUkRL?= =?utf-8?B?WmNzYlN0OU1Pekxycy8wWHd1aU5FMjlsU1A4WlFJdTF6dFZFTmJqQ2s1eTh2?= =?utf-8?B?ZUNRR2w0TTRYU2g1UFVia1NUeFBHbSt1M05SN1dQbUNja2lwdjYwT0xHbHZ3?= =?utf-8?B?Vi9nTFNxUkYzUWF0Q0RsbFREMUF0YTZPbFlPZ3owVGo5aWE4SGVCVzhDUVVL?= =?utf-8?B?R3lTTnQ2anl5bkhlUmVsZE90UTJiRVZmWWtvb0hyb3ppYXNDcVJyaFlZUDc2?= =?utf-8?B?RzRiY240MFBWeC8vOG5BUkdxUDBQSTYvU1V6cThHaXRhc2ZjWDQ3QWVYZ29v?= =?utf-8?B?ZUVESEw0U1gwcVdJZVZ3bmRGeTRZUGRwK3ZFRXBLTHltaUszbGQ0bkExa21Z?= =?utf-8?B?clE2a25lTk4rcmlVdS9XblhNWkhJREd6RUFUODIyM0VORkNNS2YxOGNHNXF4?= =?utf-8?B?eGtETlNUQlVlTWhuMWU5dkcrN0JHd0Z5QnczVkpGSEdmdzJxTjVzRUpHZUtJ?= =?utf-8?B?V0F1azRsRjB0UUNkN1FXem9Zb3FGakVJbUdqOUZKaU42MGhiNHJOd2dnUlpz?= =?utf-8?B?ZGZvcVh3MG5xZUx5TVVQMXdSMllteStEc3VKVjZWbmJRcXAwaGc2T1NwK2NU?= =?utf-8?B?cWt1dDc3d1dwMVdGTzdZWTNZN2xRMWU3WjRXci9TUlVMOE1rbmpLb2pBYjRH?= =?utf-8?B?QTJtc0ZtWW1qQ2QrOVZsK3JGNjNMN2VWNVRhK0pZWWlpK0tGM3NZUjNTbnNx?= =?utf-8?B?aWNsckhBTzJjNXU1c2lLVXZRczQ2OTRjYzhESHV1UFNWWHBTcUpGZGV6MVIr?= =?utf-8?B?ZVY4eFlNTGxLRlg2R0s0bG5VdzR4bnl0bGduLzdZU0lKVWJBN3cwRmtScUNP?= =?utf-8?B?cklVdjZ6VmZjWjhqNldXRThhNzRGYTdWUGh3WnBVekw4UVpPamJwVEJsUnp0?= =?utf-8?B?Y0Rkd2l4Und0NGZ2c2hvd280WDJhYmlzU0xzOGpHUjRrVGlZUloxa0tGM3ds?= =?utf-8?B?dlEwT20zbFVxN1p5bUZLanNMeHU1RE5qcDc3STlmWXFmQUZOem1SZ0dhbkpD?= =?utf-8?B?RVAwSlZqUUw4UEs1bHRlL2JjWHJhR0dZYlJKL3B6bFczTGlhSHdCRWRMazZa?= =?utf-8?B?M2FMcEpkOVM4eHBndUl0S1F5c2JSMHNqNUptVGFzZldyUjh2TDliK0tnQU1j?= =?utf-8?B?b0VhVko1Q0pibVoxOTlGaGJTYXhwWU9Vem5GcHlVTms5a0NqYXltTzVGdCt5?= =?utf-8?B?eGZoM1JKbTdDMC9pQnB1eTZYSG5Hbis5WnJZY1kwM3VEZkI5dmxCYmZCRDVJ?= =?utf-8?B?aFc2dVI4dDczbDU1N3pTSlV1dlBxc1JXYjFqeXFSRUdPVERNRUUwdzIrVnps?= =?utf-8?B?ZnFiRWZmSmpHSFBTcFQrRnFJNWtQR254Z2dUaEoyTGFybThvM1hsMjg2eFlo?= =?utf-8?B?akRLZ0RCUzNaMnRBOXB0Snh2RzE0UVdIRndPWWVXTkxrSHJsZGtab0R1RUJP?= =?utf-8?B?L0ZiMXBidThoQ0ZVNmdwZEpWM1N6WkZjN2x5UU9ML3pmREdrRkpaM2RQNzhR?= =?utf-8?B?VTZiK21FTHRBY2RqeXMxeGpidXQxTGdCVnFsTDM2VEk5anpzdVRuOXgvdW5Z?= =?utf-8?B?TkFWQm9MNkFVWmtTQVQxaGNsT092OVg2ZUVOV0twVkh4Um4zQlhrNThpY3VH?= =?utf-8?B?a09zS1h1TUUzSDBtOXM2Y1dKNVV4bHRoejRSV2haa212VXlEWFRHOE1zWkVU?= =?utf-8?B?UTlsdTRJeFc5ai84WkcvS3pEZGxmbVRoZlQ2Mi83RGhXWGZZSzdua2FFNHNi?= =?utf-8?B?QktNMkVPSEhhMWt3bTlkTUpoQXFxdjJVZDU3b09GRlB5ZTFRL3plemhHcFlW?= =?utf-8?B?STVyTitNTk4zb081VU51WWVzWDgvSVhhOWlad25sRnZsa1dUa2xBQkNsRHpQ?= =?utf-8?Q?3KmlNRgoPnYIyEkTJIElg3Eip?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 277626c2-9149-449a-da80-08da6647690d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 09:50:11.7260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: C86w2ArmZU3MMUgvnT2clwa4A9a40f8Oewr+JBs+7gkWgXcTvBN0v5z8DAtURLvqHFMqWdTBE8oNXeDocpJhrnSvyVnBlxrqajCd2YqEJEk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6339 T24gMTUvMDcvMjAyMiAwOToxOCwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4gT24gMTQvMDcvMjAy MiAwMDoyNywgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPj4+IMKgwqDCoMKgwqAgeGVuX2h2bV9z bXBfaW5pdCgpOw0KPj4+IMKgwqDCoMKgwqAgV0FSTl9PTih4ZW5fY3B1aHBfc2V0dXAoeGVuX2Nw dV91cF9wcmVwYXJlX2h2bSwgeGVuX2NwdV9kZWFkX2h2bSkpOw0KPj4+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+ Pj4gaW5kZXggOWQ1NDhiMGM3NzJmLi5iZTY2ZTAyN2VmMjggMTAwNjQ0DQo+Pj4gLS0tIGEvYXJj aC94ODYveGVuL3N1c3BlbmRfaHZtLmMNCj4+PiArKysgYi9hcmNoL3g4Ni94ZW4vc3VzcGVuZF9o dm0uYw0KPj4+IEBAIC01LDYgKzUsNyBAQA0KPj4+IMKgICNpbmNsdWRlIDx4ZW4vaHZtLmg+DQo+ Pj4gwqAgI2luY2x1ZGUgPHhlbi9mZWF0dXJlcy5oPg0KPj4+IMKgICNpbmNsdWRlIDx4ZW4vaW50 ZXJmYWNlL2ZlYXR1cmVzLmg+DQo+Pj4gKyNpbmNsdWRlIDx4ZW4vZXZlbnRzLmg+DQo+Pj4gwqAg I2luY2x1ZGUgInhlbi1vcHMuaCINCj4+PiBAQCAtMTQsNiArMTUsMjMgQEAgdm9pZCB4ZW5faHZt X3Bvc3Rfc3VzcGVuZChpbnQgc3VzcGVuZF9jYW5jZWxsZWQpDQo+Pj4gwqDCoMKgwqDCoMKgwqDC oMKgIHhlbl9odm1faW5pdF9zaGFyZWRfaW5mbygpOw0KPj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB4 ZW5fdmNwdV9yZXN0b3JlKCk7DQo+Pj4gwqDCoMKgwqDCoCB9DQo+Pj4gLcKgwqDCoCB4ZW5fc2V0 dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+Pj4gK8KgwqDCoCBpZiAoeGVuX2Fja191cGNhbGwpIHsN Cj4+PiArwqDCoMKgwqDCoMKgwqAgdW5zaWduZWQgaW50IGNwdTsNCj4+PiArDQo+Pj4gK8KgwqDC oMKgwqDCoMKgIGZvcl9lYWNoX29ubGluZV9jcHUoY3B1KSB7DQo+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqAgeGVuX2h2bV9ldnRjaG5fdXBjYWxsX3ZlY3Rvcl90IG9wID0gew0KPj4+ICvCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudmVjdG9yID0gSFlQRVJWSVNPUl9D QUxMQkFDS19WRUNUT1IsDQo+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIC52Y3B1ID0gcGVyX2NwdSh4ZW5fdmNwdV9pZCwgY3B1KSwNCj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB9Ow0KPj4+ICsNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdfT04o SFlQRVJWSVNPUl9odm1fb3AoSFZNT1Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yLA0KPj4+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgJm9wKSk7DQo+ Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogVHJpY2sgdG9vbHN0YWNrIHRvIHRoaW5rIHdl IGFyZSBlbmxpZ2h0ZW5lZC4gKi8NCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIWNw dSkNCj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJVR19PTih4ZW5fc2V0X2Nh bGxiYWNrX3ZpYSgxKSk7DQo+Pg0KPj4gV2hhdCBhcmUgeW91IHRyeWluZyB0byBtYWtlIHRoZSB0 b29sc3RhY2sgYXdhcmUgb2Y/IFRoYXQgd2UgaGF2ZSAqYSogDQo+PiBjYWxsYmFjayAoZWl0aGVy IGdsb2JhbCBvciBwZXJjcHUpPw0KPiBZZXMsIHNwZWNpZmljYWxseSBmb3IgdGhlIGNoZWNrIGlu IGxpYnhsX19kb21haW5fcHZjb250cm9sX2F2YWlsYWJsZS4NCg0KQW5kIG90aGVycy4NCg0KVGhp cyBpcyBhbGwgYSBnaWFudCBib2RnZSwgYnV0IGJhc2ljYWxseSBhIGxvdCBvZiB0b29saW5nIHVz ZXMgdGhlDQpub24temVyby1uZXNzIG9mIHRoZSBDQUxMQkFDS19WSUEgcGFyYW0gdG8gZGV0ZXJt aW5lIHdoZXRoZXIgdGhlIFZNIGhhcw0KWGVuLWF3YXJlIGRyaXZlcnMgbG9hZGVkIG9yIG5vdC4N Cg0KVGhlIHZhbHVlIDEgaXMgYSBDQUxMQkFDS19WSUEgdmFsdWUgd2hpY2ggZW5jb2RlcyBHU0kg MSwgYW5kIHRoZSBvbmx5DQpyZWFzb24gdGhpcyBkb2Vzbid0IGV4cGxvZGUgZXZlcnl3aGVyZSBp cyBiZWNhdXNlIHRoZQ0KZXZ0Y2huX3VwY2FsbF92ZWN0b3IgcmVnaXN0cmF0aW9uIHRha2VzIHBy aW9yaXR5IG92ZXIgR1NJIGRlbGl2ZXJ5Lg0KDQpUaGlzIGlzIGRlY2FkZXMgb2YgdGVjaCBkZWJ0 IHBpbGVkIG9uIHRvcCBvZiB0ZWNoIGRlYnQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:05:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:05:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368067.599232 (Exim 4.92) (envelope-from ) id 1oCICi-0007sm-S9; Fri, 15 Jul 2022 10:05:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368067.599232; Fri, 15 Jul 2022 10:05:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCICi-0007sf-Nm; Fri, 15 Jul 2022 10:05:48 +0000 Received: by outflank-mailman (input) for mailman id 368067; Fri, 15 Jul 2022 10:05:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCICh-0007sZ-51 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:05:47 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b113fe5a-0425-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:05:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9206.eurprd04.prod.outlook.com (2603:10a6:20b:44d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Fri, 15 Jul 2022 10:05:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 10:05:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b113fe5a-0425-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0m/otbQBR1z3RHKxAh+8yj4tIfez70sYAJeNhDORekLhW8/J/+3Gi8eSUMb56j7CJgTkJ4JWionkd2bskFFCNSK8L05kBD2wobP/L0ETblncWDhldBSGnQcez/BYbkeKbA9Azq91xhFOxyzKscLBAjt1ugOzC5zCgEyWcH+E8gRZcRy06WiPWnTh4i4+pyiQK581ekd/9PjN+7Y7fWxqheBKdppTje+C2QkpL32D+MS+yy/O2cPG2QNVYj+pkjXbyyaPbE7B4ORs05oMXRnkoJ5lsyh6ByF1ByRyZqt3aVnSr4Vh5AsDko8mrmt5VCiEM6J+1ic06V0agV62BEc6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F75NRxR9MgeTn5EeqhVQIyF7+ur8NDOgRsR5SJEcsqI=; b=ETPzDUB8LgyO1eVOwvYc4GLvLoxgGTbNFH2ulPp0jDoLCdAMuOuMUyXxSLAnIJHG/omo96Mr2gNDiUIleyK2XtL8R3WysJyClAU1f/E5xZbBr0AuVI9bZIdgwZrP0Q+oEu/hKrkZNgTvI38CeN2XzVX/ZtUxz8D01/nXDYP9KcX8kus5lpDZn00WuL848ir/WhY1ev2scZZhbbgyYm95RueSqd0dlyPuDS4TxEi7G3PgSWk78YmzDEPrmn5p2tpkF2iBODoV65ZZrAf3cFiOFaWBwt5WWykiYEqOLnEhgvtycEl9iSfkIX6pZBcWaL+KBfUNhgrKiqM6fxMnImJOgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F75NRxR9MgeTn5EeqhVQIyF7+ur8NDOgRsR5SJEcsqI=; b=WdNO32ZJxxebqYmT81MGcXnaLuUPnKhuOd+TRbr5Z5PonUhEKkPoHi6SMHF+5WMLGJw4YZk0pVWZe8+dqxF0RXg2myfCkbShzaVN5xGxgM1vG/B2vtrcofdkBgolZT6Or47le8iK3pD6MTH5iHSne9htUY3KTsjyCfERmkyeZz52tzZ0sO9i0CIPSpCWS2LKpKddIblT0I1NyunKGqIDEWh6bPTPMKXmTeX3tnENhNRGAwPzFVaZ8sEdUfzQnDeCJk1NL9m8wGFHO2hBY22vvrFrFsOGcvuchIDBzHu+70S/6f/zOeFKskLohlFlCF63X+kmSdBPWC2x+K79IsBMiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 15 Jul 2022 12:05:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis , Chuck Zmudzinski , linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> From: Jan Beulich In-Reply-To: <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR05CA0010.eurprd05.prod.outlook.com (2603:10a6:20b:488::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 18a1ce87-d6ed-421b-ed42-08da66499398 X-MS-TrafficTypeDiagnostic: AS8PR04MB9206:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bEUb81t3iRAnc6GagpTLOd5WGjTqdcLOLaDkw/hooa4w4/LziT8n6BdLwtAjSDtyp3LTzHvvCAAg4svqkhewQzEtu5w5jceNYU3ujHQioL85BAxFhtpi5KCzM5AZErOY8Db5+zHbYC3ibcKB7IOHkBR1ndmSGZfkizoNWcPNLYo4pyF/miTMnR3sQCdUaQznnrmDkBU3PXAGkDCnehseL5mMAUw23uKpgAyRrvT4H8gHVlvuWugra19bbm4f4RaFnX6Lyt9PuzO/GiKL16+dNr3v3ff2jZHoRJhhPAKVzHke5N4u+VRI0srhOgpV3nK88bFStGYloeLsZlS+pyfLyF4UjeOnDeuTTfg6a4+pD/RVxm569gz+9QxU8sspuHkss0KsSye4S0/pT2orY9ate8tJlr2asQfJ05ktHiIGPUnz5V0HmvJA/BCdTKNyvihOwsfV4PW6IkD2rx6WNSVA0+TUSFITkLdp8soErsPair7Gb/p/3JNqb9rpc2ct1eDDz08TzDa2XjN5O9DnKUVCfl5NWzjQhf8Btn6CTj7I35MKVnc7tAp29ti+XoCvDbGSShzWVwHN4ALPsE7Zaugypdw+6f+JwkTJAAjepG3zdiaq3CwF5/5YQsgkLDYTni+Yw5AyoQRTy+uDrK55Zm7ebm/IOE74N1KKWO6QnpN8ZSXKk3Me24qxk2V4LSxr0iICSH5fRtrDrKpLlKEWkmvZI1WCqOkFaliv+k2n01v95A/+kNG8JZzvf3Y03cLML3Z27sAFhTgLLCzEtIu9KvpVGiQJjY0bCXA0Qpy9KdH4k8Zo297sP+wpazo1hDQMx+homnfzymqOec27SRjnMMMD8ep9x3z5iEt8yEk0fXxOm0Zv2LBq8SA6XQfpEfbVzjjB X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(396003)(39860400002)(366004)(136003)(83380400001)(6512007)(2616005)(36756003)(86362001)(186003)(478600001)(6506007)(54906003)(6486002)(53546011)(316002)(41300700001)(8936002)(6666004)(26005)(66476007)(966005)(8676002)(2906002)(31686004)(6916009)(7416002)(66946007)(38100700002)(31696002)(66556008)(5660300002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZWt0dWFxQXVnb2E0eXU1WHk0bjJCOVkwcThrQnd5ZURrRUs2TWlYN01wdzRU?= =?utf-8?B?Rm13TG9qTjUrR3hCVzQxNlNzMUFoaS9yY0JETEg0bCtuQnE0Y1FsdlFjZ0Zx?= =?utf-8?B?RE5Wd09acThEbmowVlFlTGF5Vkt5ZHVBZkdSc3NBOFVzRCtDVFNLa1ZTMHZZ?= =?utf-8?B?Q0k4VExhYmNuSXFPUWE2YVVOdDZmYllnN3ZHNW9YWDF4SGRwMEswNktXTGRY?= =?utf-8?B?ZHVwQkFLN2FUWTJsdzJ3YjErbXo5eXg3Z1hoc0M3QjVVYkJ5K0gycjMxeklZ?= =?utf-8?B?enY0YUdtZTdoTS9NTzY5d2VXNkhNTm93OEtLT3djQThUbjJVSmhIYVh6bWFM?= =?utf-8?B?bG83QkVTZEpGK21NQVVmVWZWanRDdjNpWkErc0E1Ym5DVlF3c0VadXd5QlMx?= =?utf-8?B?dGZvR1pEUHhBWThsYXp6MVhiWThVVy8zQnkwSTRkSG1pQ0hCMU5sRXpvemYv?= =?utf-8?B?bWxJcDA5QXBPTnZqTVFuci9MbXZ4L3BDM1lxUlUwd2dST1FNK0VVYi9WVVpU?= =?utf-8?B?TFU5STlWMzV4a1IvdVp2L2RzSC9maHA2bkRGTUM1ckRUWFlndlBpSmxnWWQv?= =?utf-8?B?c2o4WGpma3ZUWWlUMittYTZMTGtqa3lmdzVBQ0lpT0dua3Q3R0lFTW9naE9T?= =?utf-8?B?REF4enI0L2wrS1Z4dlVWMTJhbFM0OCtzeG9KemhXQXdlUmdINWtHMG5RV2o1?= =?utf-8?B?ME00enRTZUdHNjJjZnFKTFZrSFpKWHRDVU9IR0FXSXVjUVhqZndFaFE1Tk5o?= =?utf-8?B?bENOZFd4V2IzK3ZwaUI0MWROY01BUXdQNjVzaXpERkdKOTJCNno5TTFLT0J5?= =?utf-8?B?OHlxQlh2aUhyZ2t6VjYraGw0N2tQNjZwUEQ4RFAzOWlkTGtlQjljNHc3ZDIr?= =?utf-8?B?WFN3MXVORkpDVyt5OFFER2EwQUtSdWNVempZSm1pQll0ZlBSRFZ1UDNFRGhs?= =?utf-8?B?a3g5TkhzaDVhSzBxVG9zZjFwMUwxTGQ5U3F2MEJNd3dscEZpdGVUeEh3YmtU?= =?utf-8?B?ODUzT1UrRmZ0cFRTM0JvOXNMOHhVWFhSb2g4aHkrRjBXUW90TEtiN3ZwcHVP?= =?utf-8?B?OStwQmZqZmJTS0VML095elpsRXVVNDJjUmNOMHpTSGNyMWlJSlpMWDBiN1FR?= =?utf-8?B?ZEErdlliVUIwakZ0RmdBVzljTi91UC90aEZQc21nYk95RDBPL2phUHd6VU5h?= =?utf-8?B?ZVdpdGREU3dJQVhTVHo5TURnL3V3a05LUFJCSndsWnE4eHpoc2U0M1JxY3VM?= =?utf-8?B?T0ErS3hLbVZ3WGEwYmFWTGt4SksvYWxQQmx6cE5rUFV3Q2pBbnNPcjR2STh6?= =?utf-8?B?SGNiRWd0ZVhoWkJxbTZ1bzl2aVp6UWZlTXdoR3BwT1BDUVU2Uy9rL1dEb2ha?= =?utf-8?B?TFJoUmFkL0hQeHoxczJMamcwTDI0TE85S3htR0c1S3hmWkhOVDA1bERhUk51?= =?utf-8?B?ZGdYTnBjSW55RTJqanZOT3NPMWJYWnh3N1JHQ0dyeTk0dWZYak9jTlBKYU14?= =?utf-8?B?bHFNZllHTkxqNml6dkxlZHlaK0owTUtrREw0eXhIeEIvbFRuelVoa0dvOXkv?= =?utf-8?B?QVNEbU9mU1VXV0d4ZTNaZ3ZTVWpUekpOR3Z2eDcvRHZoRC9vcURxdjcydFRv?= =?utf-8?B?OHJ2VVFFWm9nQUtDSUFQMVh4a2RLSGN2V0ZBSjFleERtZHZaRHlWL0JRWjJK?= =?utf-8?B?ZVNIYXNUMnN4TGNQUEVlWlB2ajBzY0NtWERNbnhQWXFxajNRWXpPbjFaNGp6?= =?utf-8?B?Wk9PV0FxM3hrdCtCOEplM1pITkJVbUxnK0NWcm1pM1Vjc0hpNFU2Nk13dGtB?= =?utf-8?B?OVFQN3owOXFlTnJyVEZDeStWc2lDVFAvc1RjRDdGaXlSM0ZEamdzNm94bnFv?= =?utf-8?B?Nlo3b0pPQlVMNGFBYzVUa05Qbml4SGZLMGxqZlNvUjhlRHY1ejBRY0FrWHNX?= =?utf-8?B?T0huZE1lMkVEU0VONjN5K3E5a2x3cVFOWmI3d3g3WjUyYjZ2U3hrTTJuMEVv?= =?utf-8?B?WS9QR2ZNRERoLzY0S0xNMjI3VitCdmo5MEZxNmFLTCt5TUFwWEt6blF0Z1FC?= =?utf-8?B?a2FiaHpRanZjWmg0RENYaTV4T3c2REd2blJ5cFlEUTA1dGhJQjN5d0VnU0Zk?= =?utf-8?Q?Jtg59MIAWfjrR3y706AuS76gI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a1ce87-d6ed-421b-ed42-08da66499398 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 10:05:42.3608 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Odorhk4LqhFbyfoSR8HvULu7T5DGTUViViGBL6nr/hiq7jw8Knki+I/xt4e6pDnNJQx9axKFkeUmd+vLtBNFRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9206 On 15.07.2022 04:07, Chuck Zmudzinski wrote: > On 7/14/2022 1:30 AM, Thorsten Leemhuis wrote: >> On 13.07.22 03:36, Chuck Zmudzinski wrote: >>> The commit 99c13b8c8896d7bcb92753bf >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") >>> incorrectly failed to account for the case in init_cache_modes() when >>> CPUs do support PAT and falsely reported PAT to be disabled when in >>> fact PAT is enabled. In some environments, notably in Xen PV domains, >>> MTRR is disabled but PAT is still enabled, and that is the case >>> that the aforementioned commit failed to account for. >>> >>> As an unfortunate consequnce, the pat_enabled() function currently does >>> not correctly report that PAT is enabled in such environments. The fix >>> is implemented in init_cache_modes() by setting pat_bp_enabled to true >>> in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed >>> to account for. >>> >>> This approach arranges for pat_enabled() to return true in the Xen PV >>> environment without undermining the rest of PAT MSR management logic >>> that considers PAT to be disabled: Specifically, no writes to the PAT >>> MSR should occur. >>> >>> This patch fixes a regression that some users are experiencing with >>> Linux as a Xen Dom0 driving particular Intel graphics devices by >>> correctly reporting to the Intel i915 driver that PAT is enabled where >>> previously it was falsely reporting that PAT is disabled. Some users >>> are experiencing system hangs in Xen PV Dom0 and all users on Xen PV >>> Dom0 are experiencing reduced graphics performance because the keying of >>> the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) >>> means that in particular graphics frame buffer accesses are quite a bit >>> less performant than possible without this patch. >>> >>> Also, with the current code, in the Xen PV environment, PAT will not be >>> disabled if the administrator sets the "nopat" boot option. Introduce >>> a new boolean variable, pat_force_disable, to forcibly disable PAT >>> when the administrator sets the "nopat" option to override the default >>> behavior of using the PAT configuration that Xen has provided. >>> >>> For the new boolean to live in .init.data, init_cache_modes() also needs >>> moving to .init.text (where it could/should have lived already before). >>> >>> Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") >> >> BTW, "submitting-patches.rst" says it should just be "the first 12 >> characters of the SHA-1 ID" > > Actually it says "at least", so more that 12 is It is probably safest > to put the entire SHA-1 ID in because of the possibility of > a collision. At least that's how I understand what > submitting-patches.rst. > >> >>> Co-developed-by: Jan Beulich >>> Cc: stable@vger.kernel.org >>> Signed-off-by: Chuck Zmudzinski >> >> Sorry, have to ask: is this supposed to finally fix this regression? >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > Yes that's the first report I saw to lkml about this isssue. So if I submit > a v3 I will include that. But my patch does not have a sign-off from the > Co-developer as I mentioned in a message earlier today, and the > discussion that has ensued leads me to think a better solution is to just > revert the commit in the i915 driver instead, and leave the bigger questions > for Juergen Gross and his plans to re-work the x86/PAT code in September, > as he said on this thread in the last couple of days. This patch is dead > now, > as far as I can tell, because the Co-developer is not cooperating. ??? Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:08:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:08:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368072.599243 (Exim 4.92) (envelope-from ) id 1oCIFj-0000PR-Ct; Fri, 15 Jul 2022 10:08:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368072.599243; Fri, 15 Jul 2022 10:08:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIFj-0000PK-A8; Fri, 15 Jul 2022 10:08:55 +0000 Received: by outflank-mailman (input) for mailman id 368072; Fri, 15 Jul 2022 10:08:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIFh-0000P9-9s for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:08:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 203b4ee4-0426-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 12:08:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9206.eurprd04.prod.outlook.com (2603:10a6:20b:44d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Fri, 15 Jul 2022 10:08:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 10:08:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 203b4ee4-0426-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpKSO2oPomHojWqPf/6keT8cOrJ9dvvYvW3mhFxQYg19JgCzZj1mjEv+B8tWtq8a6p4LMIlmV/1Q6fKy4Zf1kBdU+4YgGr7kGKuJ4YEhID+nqCOVKKfZTQQFZRYaAVCDFbFkdkHl9v+IXIMOaKw5yLED0+hIGsbxuKsVacbvTL2TfosZtG++g49QIo0rWWY8Yez8IWbfTEo59M0iprKm17kqQ57+DQQxrh/L1B0pL0ev4EiKqVlFdANh59rVd/rNRFcROlU9rSXzV3uL8mTkT0h6j5VLrIh863qxEsfCxhSHf1i3tO6qh3kjN/DexHOdhyLulPujk0AIs7+4K0VTGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+2a6LxpowYNbgTiewYZ2MIYtO8BA4A3pc9y7J+gBXMw=; b=W0iKkzCp4aSm+78oRDv6Sr0QcAMuxxOEeKsNp84qSeNUhLFSs6YjbC4cur2oez44GOXqcFAyxaFUT6aVOxRkhml6sSs5S0i+rEYWTemrAzPxjSaBorJDh5f5Ba+Tzbz86XIWDHeOPMUWM0lP9urYfxXT3939xLwVNZQYHoADWGBM7xZXF0HowBYk06c7a8fFD0kaS3ogS3rqL5/zyCyU+MtihqErLOC3xGJaeBRUMvaKcQLsNcEzDK5s2KtM+CkosGIyeml6o9TY3CKwUwehx03CSjPiO+amavs5eC/odoz4iJRUpueJiRoReR2f28dIr+dxlL90z1Ybj9QuS/G0Aw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+2a6LxpowYNbgTiewYZ2MIYtO8BA4A3pc9y7J+gBXMw=; b=YwYlMyqjsoFhKApoAJaO1b3+7HjdzSAtffPyGIP61T1boyQirrWJCbrWEjhUy5nixzgERJx5AaflYeYStJgbksX/l41d0q4w6l1x+YR11pzftf0YVj6iDICWV69fGGz7kbX5mypjJjHERZeDO7hQn4h2Mma6GIi4o3oo5EEdcPvsenS7yDx3TJ1VwCHhYEQ+LS8CTnOuwiPaDe3pE6iYBdey3rXb/7UeBnl4LX//OE+Z/2oZAyESNDudGVSC5ytVXHCKkJZk2SG3twm4XcdmUhXe78JqArc8dG2NhLvO7QYMF9sfUmH5lkB0B9BpoC7ffwXhPW+HwE3H9PGpvOFTbA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 15 Jul 2022 12:08:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/2] README: State POSIX compatibility as a requirement for AWK Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony PERARD , Xen-devel References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714185305.29507-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220714185305.29507-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0602CA0019.eurprd06.prod.outlook.com (2603:10a6:203:a3::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f2eacb2-1c90-4466-18bb-08da664a039c X-MS-TrafficTypeDiagnostic: AS8PR04MB9206:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fZ6IjFm4c4mxT3gAKvlSiJipHdyit+Ke/eZ8n9AItMrOj3jF4hEQZQmXDOOT2qCPu83CYqaU3unAYmi0NsAqck4oVa0DrbJht4j+/zyha/iX9lcPN436v0k8OByi1WXeI0njuJ9fVAw38T2oGzxPvYHvqxiumoREXozLYd6EHZRLYuVAPW5q0WIqv6b19rAe6E8wDpWGEkQ+HTPmclfPtGF9nuML0hAMxUGkJLPY3DuqOj1/W1xHnYwV9m6ehDOFpYTumklMI9vz1aRLDQG5iQcR9ZLE84HRJ46fZSYdphm4bc4psZcF4ixYWKTJJIlds0K8iKO953BivgYeWu8D0pbXNb+cvdevZa+3YCNrGKNMsD6b7yhmw+vgLxKSPLc00Mz74nUSE8Gc1xYoS4wDz/ks8ztRJv3P53WjDYe1n1eCntknwumwQzhFkq61kquHa2y0BJygeEkD2QMBvsKZ5RibVHYI8g+pw1xppuCty3y5HvW3Tpmzh59i1XBw9yXpFJr4vB1xPlT70h8TaL7QlTPH38o0Z9O5VKwJSMdpaNqilo7Ge/prqY1g6eXBEJ1GXhV3ylhCvhwXBiN1xhoVO2q6H8SBT5bsB51YPq5hBwoMgTQktJcruynBOwMTyrQIMCeit0qbr4Iv9VrYYUaxXbpXr/xYJgVwsPYMgD5/KdoTUwj3v2Ge1on4OMFNj5sHfLoWjcKaVXtLg6MQLNS76BvbXLne2TCimqzNkRbAGPJGQSD0H0hiNO9cxRrhCCz1Hb4g61DOeh3sRgsRFoFZfNUi1HKDQLdroyBDB2YR1h3/EC4yiplUUlGAevtaJX5FfWpkLNpgRLAUzc7ONlqVrkSipreHgY7tX9HonLTq+OTg9PwH4IhOgatmCJ18cqDW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(396003)(39860400002)(366004)(136003)(6512007)(2616005)(36756003)(86362001)(186003)(478600001)(6506007)(54906003)(6486002)(53546011)(316002)(558084003)(41300700001)(8936002)(26005)(66476007)(8676002)(2906002)(31686004)(6916009)(66946007)(38100700002)(31696002)(66556008)(5660300002)(4326008)(4290200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?em0zK0p4TVhkRHhqMUI4Ri9PRngzaTZlYjJrT1ZEN3dadzdDYkphZUFtN0x6?= =?utf-8?B?aDVQbEVidnpIVCs4UFlwNm9YdTQvOXE3ZnhKN0R3NGoweGxDdmNUU1NkdFF5?= =?utf-8?B?NXpXS2JnSzE4RFNpNC91KzZvNzhqTUMxRzRzS2R5blpZWHUyVTBSa1BCbUZl?= =?utf-8?B?ZDNYWnlwY2FkQlpHUENFUmVWVEx1Z2RFVEFFd05SeTBXR2RIWk8wRVNVVWJE?= =?utf-8?B?U0hsZlYyKzg3eFo0S251Lzc2TEFmZXlSRG1Nd3RsNmZ5TXI4cE9CVURUc1dQ?= =?utf-8?B?RzRudjh6SXRqak9qd3dkZEVHOG1Ed2t0S3lFQlBQa1NaeGpzaThYZGtTcGRM?= =?utf-8?B?OTdFNnJOYVJvTHNnekxhN2hEV0RIMnRFYjk3WkdBdHlIdnZ5ckxhTVE3dzVS?= =?utf-8?B?NVprYUJzdnBDb3liS28yQTAzbGJIT0dJUUZ0S05aUDREZE1sSWRMcE05Yiti?= =?utf-8?B?d2puWUpQSGFTaXVXOVVobFYyOFQ0bkJaY1RWK1g0WmUydjZqUnMyMFFjdUpi?= =?utf-8?B?OHlsblk4dnlxMHk4M3BFODEydDY1V3FjQTJNQUJqWXkwVUphcUpHZ1ozWjYy?= =?utf-8?B?S3FJOEllQ2xia1VkNEt0aVYrQTVid0NpZm50My9wenZWalBkNjFWSmVGZFdK?= =?utf-8?B?aHpaVkFzSG9vREZzV3VKZ0hJY1o2bkw5MnhaYk1mc0M5VXQ5Z2Z2YzByY1Bx?= =?utf-8?B?bk5lTDRNYmkxMEs5enRJdFRwVWVvZnVHdmlQM3lmUU8veStERENDNS9qUFoy?= =?utf-8?B?T1hqRjdQSE40QWV3eFRyUFRwWmV5YlE3eXZpaG5mR01ockc4S3grUGZVTzFO?= =?utf-8?B?ajU1YnViTGtEZHpzZ1RQVTFIM1g5blJ1Tkp1a3NmNFppMUwyZVVtS3A1MkV1?= =?utf-8?B?RGR0Y0FBa2lReUN1TlJkYzg5bVMwNWVPY0ZFWVgvQktLS3d4R3dYaFJQQ0Vi?= =?utf-8?B?dUlWLzJNOXRyVHdzSXNwSzRlalkxT1ZJTVpWMk5ZMXZHd1d3STJVMUUyRU9G?= =?utf-8?B?ZE5DZVJLKyt0N1VXbGw0dHFvR0I3NkZXODNvblI3T1EvajZHdEJiRDdEeklj?= =?utf-8?B?RFczWEpXcFphMVJzQm4rTXB6ZmJEQTNPd1h5L2NReWczaGNDd09iNE1JaklL?= =?utf-8?B?NERYTVRRd3Zhem1EOVpXcnJKVitVMDQ3UUhoTjFjYzBnUG9JZzRXV0hYWVox?= =?utf-8?B?MWN0YkVaRjNnTmVnd2ZyMWl2UXhtNXozelFEVjlkZUsxWS83SGZkQ0xKcUJo?= =?utf-8?B?ZEFGYk1XeTkvLzhGTVFicXhkRGJDLzVaL1JQa3F2cGpqSWQ0TklGYjR3NkVv?= =?utf-8?B?ZzNGK3RDbGwvQXZEaHRGWmZISzRMbHJwN0JGZ1JqSEN2S24ydnFlM1ErdDBt?= =?utf-8?B?RDROTHlsQ1NXNHRTVFcvbUN1T3J4VEtkdURYaTRvY0R6NXZrV0NoRE5ZbmUx?= =?utf-8?B?MTBhYXNSY0JrdmNxbTRoR09hZFZ6Q2J5M0tGRVpmeEdYY04vMEU3ei9nem9i?= =?utf-8?B?cG44UmtEcHJtYWJnSUFJYm1TSDVHM0xURHhNWXd1YTZ0bVN0dDZRZTlwNXpz?= =?utf-8?B?aDJKd2ZhcUt4NHgxK2IxOWZ6RHRYUkRTeHNXblhpTTE5UEpQclFOaFlpWklo?= =?utf-8?B?bmV0MXpxdDEvTU5VVk5oM0FoTzhJMXJDejdGS1krb1cwYUNkM2YwVTcrR2FM?= =?utf-8?B?aFZRcmJySS9iMU9KMGtEQ0UvMXBFd3NPS0ZFV2ZpRmhucGhYVzVKeEQwMHVa?= =?utf-8?B?QmkxVGNhOENzQjNXUm5UVkFIZkJjTTltU2JlVXRFWmFIZ3hpVllabjRLaVF3?= =?utf-8?B?cEk0b3VDVkVNdlV1akI5TmdMdWpyL0ZjRjMzMVVlTzQ2T1lGajUwZHN2SDh4?= =?utf-8?B?VjZ5YVZJai84TGlBT1krZVJLT0tZcWpVOWZRdEJjUUlybGJUM0w4U0JISWR5?= =?utf-8?B?b2hzWHYwL2NLbFVBU0hvY0U3OHV4WHRNVnNWTFAwUGc0Y2ZMNjlCZ0I0eFlv?= =?utf-8?B?UWVKeEx5b2M0ZS9XR2k2d2V2alp2bDBQV3hYNmI2WnEzV20zc1NZOGVFcVFp?= =?utf-8?B?ZWxjSlpxM1ZPUnRONks4Q3NBYzAzTDlMREExcE5TNmZuVHMzRWtXZmswVHhH?= =?utf-8?Q?AoCcYQMHSXqfaxZncuPOrDTys?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f2eacb2-1c90-4466-18bb-08da664a039c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 10:08:50.2396 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KNXGAXZGiyzzk5FPQYrSklVPENcNqMbU2Fb31QCHVTiKrUSmH54mCt9QJ8yggNwCPNGc6ngUezEfmhPVQTc2iA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9206 On 14.07.2022 20:53, Andrew Cooper wrote: > In particular, we support FreeBSD and NetBSD build environments, and some > Linux build environments use MAWK over GAWK anyway. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:14:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:14:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368079.599253 (Exim 4.92) (envelope-from ) id 1oCILL-0001pS-0e; Fri, 15 Jul 2022 10:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368079.599253; Fri, 15 Jul 2022 10:14:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCILK-0001pL-UK; Fri, 15 Jul 2022 10:14:42 +0000 Received: by outflank-mailman (input) for mailman id 368079; Fri, 15 Jul 2022 10:14:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCILK-0001pF-CQ for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:14:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f086e10f-0426-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:14:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB9206.eurprd04.prod.outlook.com (2603:10a6:20b:44d::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Fri, 15 Jul 2022 10:14:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 10:14:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f086e10f-0426-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jPGAf9U380EhN4D59cA0RUUQ6q397j3pFNAsFatm0jLDHvFRLmBeSsrw9pgL3WM4Qq9WaU3Aw3RCiI5LkkbbaYa2/DSYWtIwFHuykSJ2FdwHGOOXNZImkSzpx+820K5XOSA6kB/6VNMztPmPP0IuR6fF3pncd27zkUTbJihYAgLm4DCSmB4wmtHeHsAnKYhDfAH3VLjNd+Y8TN1JYfZGkwru7PbOeALEfmgV0LR/MHg97d/BxREdJs6tH3Jvyin1Z8zgeQFKkHtdOUd5nRpuQFOE6uMSxcHESZW4YofWXApiXj+ZGV35fWrxR2Sm8Jg44IE2u8+N3dsfccULYJU5nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrHxZTLfABoiB5W2wRRF/3pHtCvhqOHQnkTZMH0RHdE=; b=J2ilypP/fJMmO1p9HwohkQmybRxLkpuv6i1DvHdwh8eOvlSPkLqZkBngGe3wI/vBeh811IKjJ/ncz9eawc/PikvMpSBXnuRvgc37+2VFT8/vDQKEiFfMAK37TaILoBnnczAjcLTe0DQxyK3XVy1ZYBPWVBJZ4T9Ist5+ip4OXsr+xIGq1sGf/z10k76+drv93vObWkez18OO+CjPN1Y+6IVhngdsqtIR86pTIiGT87or3E04JYqvvSl5q1rwXME/sVnIPg2f3SNhr9pXYI3y8v9lxgojleJ3qGPFlxplThqByrCAHsaPbwqfWjGqUfJyXL6BCy7ks6vC6SVN4DTBPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xrHxZTLfABoiB5W2wRRF/3pHtCvhqOHQnkTZMH0RHdE=; b=CkAX7b1v3vC/CMbfpIkf+VJvFWc3zt/q2WEdv/gs96uLYnDjKmPyYUC0WaJDxMypFEyRqsEd5YjhDHis5dOxZ2zsU9XrFYu6ctti78GpQMaBDNwbEsBtsVF5Jay/Pcha32R2ex5BJUGN+GrWwJzi3gHhKx+tGapHxd9ByC9G3euZf7D5HnqOZ3YIpS5G9CdIFEYJzsMxwnxWqS2iKxJOda0Bgao2tiFRwaCOpBjDKqOtuFeUtmIfL2PnHjDY4YNz0P33MpB3LvgLVrkloLHet4x4exMyIoGjg/ZhiJm5l726Wg0Jt3b9muNj7srta0dVxtvMx8+InpUdBlaC4n8M7Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 15 Jul 2022 12:14:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Content-Language: en-US To: Anthony PERARD Cc: Luca Fancellu , Mathieu Tarral , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: <20220714143907.25938-2-anthony.perard@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR07CA0006.eurprd07.prod.outlook.com (2603:10a6:20b:451::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef9c1e18-6133-4dbb-3398-08da664ad3de X-MS-TrafficTypeDiagnostic: AS8PR04MB9206:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T0Xw5AKRqbxi8+zRdE8pihGwZb1G7JpmkhOqQGQXSW0cnaoj8mgQUJCsqRWKgBCENo3xs44EOB6seCmENH1gTASbvP1zA0cmLP/UyCG27o4B6zwIBhw/wGD8egtsd/qIvYfNOtCycE3BKBq9uLuSxTivsRgExKahazFDMt6JiIepEsCa3FGXiqw5nrq/4qOBOcO+z+mzzgHl7ClFYfNz4tudhtr1nPrZsvhQ92kQZ819A7FytbDoUnsTIb3tG/AqIdlElXUWJaaLiARznDWYdQo1tUYcflOKF52rvXUHoCNpySga+vc4MY4GsHI8WOhG6QjjdTc4+Y26X6O8p/ZqQ8nzOs4WZvmiMLMcXtCUWwGKz0tlGNolX5UN3IrJxX0PUfs3HqjAExbl7zKv3AwvLB7gN3ScdKgL0JO6GhcJs80+jcSFV+5ORz6PaUfXbMBhG/aKSYH+tUqZ5eVV98jhhlHGRvRlNRCMpGxbNVQbb93FFIDTjcjUXwS84VXI/zKS3Wx6OSXGwfwr2HI1dmEhSsxeIZQRst1V+ohXORl7tteM8kycXy1IhQp2xPOzP/59RwJaIrIagDwO+HtfmqHUWL2Dvfi1pkZOvOP3PuBbctAYdgq5AuWtby6F9ZYYV7tYBHzTt4tU/p6xqfyf6/kCQAy/a4MjbS6m5Iqo2NvrcELu3T/c0l0B/sEf8uksauO0qoHQQvGOeRImRlMBm4PIoZL7LLC70qZy/7O0H7t/dbzuHxsN2NrltKy/HIhw1ofl2M3j43GooiwQuTzILNnO/gasjbOT3MD+rqbGQ3z+ENXRho3qy7FVCZOlN9VTK0QaaFjdWEsZTO6fokKmTLuazw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(39860400002)(346002)(376002)(66476007)(31686004)(6916009)(8676002)(2906002)(8936002)(4744005)(26005)(66556008)(5660300002)(4326008)(66946007)(38100700002)(31696002)(478600001)(86362001)(186003)(6512007)(2616005)(36756003)(6506007)(316002)(53546011)(41300700001)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXNHK0d5eGRtUlZhZkJXcmNydXBUZy9XK3RndURCaDAzU0luWWFtNkpmQXhZ?= =?utf-8?B?a1N6TEtKdXhWWEFOM3AxZmpBQTBjdWlnSmNRZUd1dUFLS2NsNm9yOHVOUlJ5?= =?utf-8?B?VEZVSXlqcWhJS1hmdUhzbFl1TVpXcjhCK1ZKSytjZ1FseUsyOThwcmtsdjZ0?= =?utf-8?B?dFY3WjVaRG9ZYnplcHNLU3U0dmprN1dWdGd3STFTL1NIeHpRejVBcTFKOEI2?= =?utf-8?B?MVo0dXZ1ODJIbzZ4VXluTkVVcTB2dHlBaGVGU1J3SHBlZnF2REZwS0ZvSnFV?= =?utf-8?B?TmtiRWlyUWNBeEp2Uk5HalA0VXpkSjZTK2ZINTFRQ3BucTBqd01hc2tMcEtJ?= =?utf-8?B?RHk0d3I4R1FmaWlSQU95Q280ODREOU5reUJoOUtLVEZBM2NDMmNvdjVUQVEz?= =?utf-8?B?dVdxTTVuaERjaCtBbkFGWE5Va3Q4RHlPQnZMU050Y29aZHNFQ2NvamI3VlF0?= =?utf-8?B?VDZTK0VFQU5CMEFLMlpHR1pOWktKRHB5WlAxU3MvdnhNUVNROU0xdG9Wek9x?= =?utf-8?B?aXRrV0Z4MkFRdU5ZdVR6Q3RzL2lLQXRwbUx2My9XSk1xYjUyTWJTd2Vmek1I?= =?utf-8?B?S0NwUCs0QzV2dTRsUFhNbCtUQ085bHNaRzZsOGgzSXgvTDg4dG5ncGw5NlBa?= =?utf-8?B?ejd2N1ExemRRSDYwaXpycnl5a1U5WWZqUis3OWVoVnc2Q2EyUWw0QjlqbHVm?= =?utf-8?B?VnNWNnFQWU10M0k0aFNFWmxsdnZQQU52QzUwZUk0WVprQ3g2cm9XeFJGUGcy?= =?utf-8?B?WUYwbHhsb0NQeDRxRXF4TUxyWGVjS3E2aDM5bW5SVHpzeUYweUlNT2owZjZD?= =?utf-8?B?a0M1K1JLdEIyc3pBQ0ZLb1hGb0FLREtQQkhuTTR2SHA0SmJRYk1jcGl5cEVC?= =?utf-8?B?YWNxV2tpNUluTlc0MDZVRURFb0NLV2VSZ0U5b2JaSUU5MUlmZzk1ekZ2ZmRP?= =?utf-8?B?QlVmSEZRMHFYVk0xZVFTVGZSUmk5NkVncERnR09EcHl0cndkTTBHbkRzQk1s?= =?utf-8?B?d2g5VjU1NENCbnNvLzYwUEtCcU1sQkpGUk1nMHdJb0drS3k5S3N6UkZUOHh3?= =?utf-8?B?dDRTQ0F4V0lzRmtDNXAyM0JWQ21CK2xMZkZNREs3SUlUc1p0bFBoelJOR3Qw?= =?utf-8?B?SmswNkVieXlnK2Y1ampJNkF3L3JzOXRHWE1wdjVmdVVxbUhHNGVUUnB4S2hW?= =?utf-8?B?YW1mRHFzeW9vK3h3OVpUNEkxajFYR0kzaGJ6RGVuNlo2bmVJL1cyemVZbWh6?= =?utf-8?B?dkl0cjh1R3VIOUJyR0czcytNM0lBZDVuTW1ISllabk9lQ1FTZUJaN3A0bFZH?= =?utf-8?B?N2NYVU1ObzlybEFPSnVYdDVsZEZFaUk4dEJUdE1LYkJBUUpxNldxN0xYczM1?= =?utf-8?B?Y2hDbHVHV2MxV29UbWs4bHoxVnFzd0QvUnV0elV0SHI4UVBUVzFqUE81K0Zy?= =?utf-8?B?cTM3WEh0NGpBNWFyZDVLd3dQanZHdHlVQ3Fab0dmSzhRVzEyWUd5M3JQTFE1?= =?utf-8?B?UzBQeUExWmxGM0hVWDd6c1pvRElRbldrMVM0S1Z2T2NMeXlEZUNMc2MrdUh5?= =?utf-8?B?TnNnZlRXak1uTXlSWmhvZTVGVnAvTTNxVUE3NEhPRDgvTFp3TkNHMlJtRkZJ?= =?utf-8?B?cFZBakxSbnhtdmFuSUVMNkZpUDhvYzN6WEN6OXdFRm4rS3NRUHcyWWpNTHI1?= =?utf-8?B?NWNPR2lDMVVQbXVkYnlwSEZwZXZUMzhTNC9OZ203VVVwWUl0Z0ZTa3FBL3Vz?= =?utf-8?B?dDM2REJlWEpITEx0bG5mSkdkbjM2MnN2T1c4S2lJd0tPdm94eDRKckpPRGlC?= =?utf-8?B?aVExc2dnTUh5MXFURG5qblBzTXBkT21ZZXU2Q01DZGc3NHlUalJEdUYzMlcr?= =?utf-8?B?QVFNUmlGZmFwZVdQRWJlRGdQWW1FVk5XQUs0U0lOdFY2ZHF6dG4zUU5STG9X?= =?utf-8?B?UW1rWVJ3dzFMVng1dy93d3lUWnN5TC9MUWlRblB0UjgySmxMalp5eW9JV2xC?= =?utf-8?B?SUtGQ2FEQnZtam8wRmREYjNUMzF3R3pEN1dzTjJ3a2JWZFBLSDNDc20zWHJC?= =?utf-8?B?NHJ5Mm9lVHVlUkFaVis5MjUrK1BHcGxuNEJoM3lFWnFWTlpMbTI5cVYwNHdQ?= =?utf-8?Q?Z6paDz4kgcT9vYYbTwVKAhplT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef9c1e18-6133-4dbb-3398-08da664ad3de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 10:14:39.6857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ioTqIRDZtOGNEDIChtAOM1eaDqmnandbWCaJglUYXWa/nWlRiLN+mEwQPkCAs9+JgS5vUe/4lTrRRrkVTeTVTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB9206 On 14.07.2022 16:39, Anthony PERARD wrote: > --- a/xen/tools/check-endbr.sh > +++ b/xen/tools/check-endbr.sh > @@ -78,7 +78,7 @@ then > else > grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ > -e "$(printf '\146\17\37\1')" $TEXT_BIN > -fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL > +fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL I'm afraid that's not portable to environments where sizeof(long) < 8. The shell isn't required to use wider than long for the evaluation. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:15:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368084.599265 (Exim 4.92) (envelope-from ) id 1oCIMF-0002Mi-AC; Fri, 15 Jul 2022 10:15:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368084.599265; Fri, 15 Jul 2022 10:15:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIMF-0002Mb-7P; Fri, 15 Jul 2022 10:15:39 +0000 Received: by outflank-mailman (input) for mailman id 368084; Fri, 15 Jul 2022 10:15:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIME-0001pF-D4 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:15:38 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 123b98fa-0427-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:15:37 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id o7so7058791lfq.9 for ; Fri, 15 Jul 2022 03:15:37 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id e10-20020a19674a000000b00483f8c40c14sm835123lfj.243.2022.07.15.03.15.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 03:15:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 123b98fa-0427-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=3jL/lfoMTvA3SObDpy7W+GRYeEbbVoydVSs+VhMSyQ8=; b=LKqUeJAhYet/E4+FOjDCJ0dKq4cDW2x4E+rfQdu83sWKvClZdCu1e1M0E0f3NVLWeY RXqHP7rrV4Gy0UvBJZ6Bv4RiaH1MNOZ0zYRfjZ35s6KLeY6hYXQcra7SL8Bs6qETPdr5 dYYLgG48qse3A1sQodtQrzuSaIVuhSnWYGOCsfY5B7tL5JDS6Z3SbspiTM2N6zT81LBz GrmAOEmVMPpU117asGxfbCJUPK8r1VAAGAELjEv0s/Ph5p+GAAYDP5wadDJdkdPE4Jv9 Ebcy0Ity1RZ3igPwXdeAet2+5VSr+p+LL13YixBvp19SsNp9YpNMvk/gnMMrJ07RuCcm 55Dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=3jL/lfoMTvA3SObDpy7W+GRYeEbbVoydVSs+VhMSyQ8=; b=fSrqG5G6Y61cMj7F7GOOBux7EZPNnqMCjPs56aQuCtPXON+7B3/zTTAJ0s2UEBakzX pW4mH9ciMgIjwYdKuAdQI4gbIYPDh1oeAesgjynEmS5gLxM/T3XdwtsE2xaD0uBceWZ3 UkfV1wSljbZVDoC5bRw5lRdN8F438/6kP8s03WXlK+Mdubj6fMmjVBnR5mZz0YlUqaYO FjLtcYccJjneSXuEacE7vsM9zE22wrNDYsao2EfhE3eGKEyb8cguhKx3jl/5Y4G3sKU1 MG/JPPsb61gx266K7U3q3FGVtUI+HljUyPOEYzRIyFXBiVSV/jF4NPNQdJ6d/NGeKKtu Plpg== X-Gm-Message-State: AJIora+qHz+mEw3Owny3lE/KB/tf+xrVucK/wO2Yk+TjGoy8rZ+1XhlM 8bjbQjfJR6TT+WsEtbL3QS4= X-Google-Smtp-Source: AGRyM1t48mlwdtZzT1aWp5fHW0tldYcGnnIY2KtrlB80elovY46YP+G88J/+IMfODsBiDN0SPqzLiA== X-Received: by 2002:a19:4f0b:0:b0:489:c753:5c1d with SMTP id d11-20020a194f0b000000b00489c7535c1dmr7473118lfb.339.1657880136897; Fri, 15 Jul 2022 03:15:36 -0700 (PDT) Message-ID: <41207539-f621-1bb2-2f43-0b2b9e3f6866@gmail.com> Date: Fri, 15 Jul 2022 13:15:34 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2] xen-blkback: fix persistent grants negotiation Content-Language: en-US To: SeongJae Park , roger.pau@citrix.com, jgross@suse.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, andrii.chepurnyi82@gmail.com References: <20220714224410.51147-1-sj@kernel.org> From: Oleksandr In-Reply-To: <20220714224410.51147-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.07.22 01:44, SeongJae Park wrote: Hello all. Adding Andrii Chepurnyi to CC who have played with the use-case which required reconnect recently and faced some issues with feature_persistent handling. > Persistent grants feature can be used only when both backend and the > frontend supports the feature. The feature was always supported by > 'blkback', but commit aac8a70db24b ("xen-blkback: add a parameter for > disabling of persistent grants") has introduced a parameter for > disabling it runtime. > > To avoid the parameter be updated while being used by 'blkback', the > commit caches the parameter into 'vbd->feature_gnt_persistent' in > 'xen_vbd_create()', and then check if the guest also supports the > feature and finally updates the field in 'connect_ring()'. > > However, 'connect_ring()' could be called before 'xen_vbd_create()', so > later execution of 'xen_vbd_create()' can wrongly overwrite 'true' to > 'vbd->feature_gnt_persistent'. As a result, 'blkback' could try to use > 'persistent grants' feature even if the guest doesn't support the > feature. > > This commit fixes the issue by moving the parameter value caching to > 'xen_blkif_alloc()', which allocates the 'blkif'. Because the struct > embeds 'vbd' object, which will be used by 'connect_ring()' later, this > should be called before 'connect_ring()' and therefore this should be > the right and safe place to do the caching. > > Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") > Cc: # 5.10.x > Signed-off-by: Maximilian Heyne > Signed-off-by: SeongJae Park > --- > > Changes from v1[1] > - Avoid the behavioral change[2] > - Rebase on latest xen/tip/linux-next > - Re-work by SeongJae Park > - Cc stable@ > > [1] https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/ > [2] https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/ > > drivers/block/xen-blkback/xenbus.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c > index 97de13b14175..16c6785d260c 100644 > --- a/drivers/block/xen-blkback/xenbus.c > +++ b/drivers/block/xen-blkback/xenbus.c > @@ -157,6 +157,11 @@ static int xen_blkif_alloc_rings(struct xen_blkif *blkif) > return 0; > } > > +/* Enable the persistent grants feature. */ > +static bool feature_persistent = true; > +module_param(feature_persistent, bool, 0644); > +MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature"); > + > static struct xen_blkif *xen_blkif_alloc(domid_t domid) > { > struct xen_blkif *blkif; > @@ -181,6 +186,8 @@ static struct xen_blkif *xen_blkif_alloc(domid_t domid) > __module_get(THIS_MODULE); > INIT_WORK(&blkif->free_work, xen_blkif_deferred_free); > > + blkif->vbd.feature_gnt_persistent = feature_persistent; > + > return blkif; > } > > @@ -472,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd) > vbd->bdev = NULL; > } > > -/* Enable the persistent grants feature. */ > -static bool feature_persistent = true; > -module_param(feature_persistent, bool, 0644); > -MODULE_PARM_DESC(feature_persistent, > - "Enables the persistent grants feature"); > - > static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, > unsigned major, unsigned minor, int readonly, > int cdrom) > @@ -520,8 +521,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, > if (bdev_max_secure_erase_sectors(bdev)) > vbd->discard_secure = true; > > - vbd->feature_gnt_persistent = feature_persistent; > - > pr_debug("Successful creation of handle=%04x (dom=%u)\n", > handle, blkif->domid); > return 0; -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368096.599276 (Exim 4.92) (envelope-from ) id 1oCIg1-0005Pp-0u; Fri, 15 Jul 2022 10:36:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368096.599276; Fri, 15 Jul 2022 10:36:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIg0-0005Pi-TK; Fri, 15 Jul 2022 10:36:04 +0000 Received: by outflank-mailman (input) for mailman id 368096; Fri, 15 Jul 2022 10:36:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIfz-0005Pc-1b for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:36:03 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea32776c-0429-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:36:00 +0200 (CEST) Received: from mail-bn8nam04lp2040.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 06:35:54 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SJ0PR03MB6239.namprd03.prod.outlook.com (2603:10b6:a03:3ad::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Fri, 15 Jul 2022 10:35:50 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b%6]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 10:35:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea32776c-0429-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657881360; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=k9r1jD/6gnkECBcJIOg/D08LS7wQzsFoNBipF+j4veM=; b=XVly6BQhVwDdgcdintf1ygHaBjqUmW5Lh2Y21ZQz43V7HW3XNKlyKa3L mfV4ylPXted+Mqwzav27isMZJu15d5xFfiiSHVa3h6lKDMOU2Dco/7ZP3 AVo+8JR1e+kfOKTWsY3VdN4rO2P5pBP1XLDmbjRydY/to/uMEjJtiBbGN 8=; X-IronPort-RemoteIP: 104.47.74.40 X-IronPort-MID: 75175607 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:YC04BKv1aiBun0gnuP59Cy+JUOfnVBFeMUV32f8akzHdYApBsoF/q tZmKTuFPK6JYDDwfoh2PIrk8klSvcDcydRrGlds/y8xEi1G+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzh8B56r8ks15qyt4W5A5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FYom1/pyL3NFz 95CeWEiQArToOeLyZvuH4GAhux7RCXqFKU2nyk8iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9w7T+fJfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2i3x37CSw3ukMG4UPJji7NpJgVe8/Dc0IRZRCQefutyisUHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAgUzVILvIvssQ7QTg3/ laTmpXiAjkHmLicVXKc+6rSsTqoIyERBXcYYjMDSw4M4t2lq4Y25jrNRNt+FK++jvXuBCr9h TuNqUAWhagXjMMN/7W2+xbAmT3EjoPSUgc/6wHTX2SkxgB0foioY8qv81ezxelEBJaUSB+Gp ndss+KT9vwUBJeB0gmEWvwQHaqB7uyAdjbbhDZHP5Qn7SXrxHelcqhZ+jQ4L0BsWu4BcCXiJ lLVtg5K759SP2exRbF+f4+qTcowpZUMDvzgX/HQK9BIMp54cVfb+Dk0PRLImWfwjEIrjKczf 4+BdtqhBmobDqIhyyeqQ+Aa0vkgwSVWKX7veK0XBi+PidK2DEN5g59cWLdSRojVNJ+5nTg= IronPort-HdrOrdr: A9a23:ohmb/6zFyeqtpzOlcYwDKrPxj+skLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMQs1MSZLXPbUQyTXc1fBOrZsnfd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadu/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZebxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESttu/oXvUjZ1SxhkFxnAid0idvrD AKmWZmAy1H0QKSQohym2qq5+Cv6kd215ao8y7kvZKqm72EeNt9MbsOuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGLf2RYUh2rD3xnklZqsoDWb/8sQqAe NuBMbT6LJfdk6bdWnQui1qzMa3Vno+Ex+aSgxa0/blmAR+jTR81Q8V1cYflnAP+NY0TIRF/f 3NNuBtmKtVRsEbYKphDKMKQNexCGbKXRXQWVjiaWjPBeUCITbAupT36LI66KWjf4EJ1oI7nN DbXFZRpQcJCjbT4A21reh2Gzz2MRWAtG7Wu7BjDrBCy87BbauuNzGfQ1YzlMblq+kDA6TgKo SOBK4= X-IronPort-AV: E=Sophos;i="5.92,273,1650945600"; d="scan'208";a="75175607" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEq4sLN5Oy0rZYKrZwtISzVCf9/+9zmCpepabEWYueEGUjDG4C46UUSpG6lYnbvZtQSUa/6uQ6mTlr1+lN8wlQYS4/zQG0MLRXZ3SjF8rqSw403O1rFlv7RixSohOA8EnQh0DBmMOYTPd/q5OG4MH+/F0MxR/1sP0yEx+s+pTL7Qgvb71hBX9xsZ1iyQOvJcBvuvGgDaUK3Ruc2UHU9vZCjsP1oEsCzEtU5z74DM1/r1mSd0rt/OxvXlxmnANzAaxq9AT2VgzURH4DBpQCqKqLv8nyhGPrYbFx7QKiLQ9iAbkMyoc51MYQmXxy7ZqR+QG3fUuDRrEyxpEviV9Xouog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k9r1jD/6gnkECBcJIOg/D08LS7wQzsFoNBipF+j4veM=; b=LUopwFPv40QGYVdeNvBTxkWQv7MynpMVv6+mh9BbUjC80ESGQaTEM6eR8UQajN/+uVuPzUTQLn0jSxYY5Z78re+tiErgr3kf84AsfQmTHVvQTbrq9RrYkiz5cH1Q4rfwVR2CiX3TY4/EUesaDo7yobOop3iFoEaVpo5uOEJwAj+9dOt9vRaHf20ntLUwhYAzRComoHoJmqx8O+L0w+MdpVlgrW2A1BkhQxXKD2UH5vL9kafq/HCSdTK7+w0e0ypdopKsslCXBKeHHoG4gIuQzBRb6lb4hOw/X2kDOBjbqLAVbhHz5uJEokXHm/nivLBvbBNgdRa0uLdZKjAvMPkgSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k9r1jD/6gnkECBcJIOg/D08LS7wQzsFoNBipF+j4veM=; b=qWs/urt/Nz918t9e00Sw+duOnxIOMgHQpe78TmI0Tep/qcMvZ+aituhfPeDbXrEqRjDbzGiGdl2Ou0F5l7Gsctr/w2ypd07MWOAAnhg62GvgkkrthoF9RWIO/zide2p3cAFf3G0/K/WNBRde1qcEGP+KbosZ8pJhySf8npenzMc= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Bertrand Marquis , Henry Wang , "marc.ungeschikts@vates.fr" Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw619+TQAgAA/dYCAAQWFAA== Date: Fri, 15 Jul 2022 10:35:50 +0000 Message-ID: <220999bc-8467-d057-9dad-9a98bb00c73b@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> <57df4df1-2145-72c6-7268-eba6de7c6a55@citrix.com> In-Reply-To: <57df4df1-2145-72c6-7268-eba6de7c6a55@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 909bba41-40c0-4588-1d96-08da664dc98d x-ms-traffictypediagnostic: SJ0PR03MB6239:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fzn1lLr+673lIuxYuycnpWI4Iq3hdA8XOl+Fo0Gx41uz0YcpiEmVr9YNttSBlwIVBI1xTF1f6eC59BkBAS5Y52G2xZjasqtsSvOmA3EdKpdCCOQzrLE1pxavNahJNZdkDwR60o4ZlR0jHNqnp5sgCsd/1p4nm1MXwr8hq6ChvKBJwNMoESNtcpL/A1cegi8xe60i2XwXiVimOnCi5X6xNQzf6ZLKINgenYiaKWQKpdbtApo02m9Iua6Vky9b9r9S+yCvTL1Wbz2tShBu/ZFEhwCE0CchIpMoUDSWSTj7LpyhIOKleUCbLLYBd2VM/h8fF/nyVrojwTtO5X8eCo6we89+lo2HcAr9A3AG5F5kp5fQ4pg9w2sTomsEFxCg8ZEfP5t1xzqhZRAJ1aVESaZYc9tLFFld1x8F6pxwAxtXlIiNM4iOvaSUHJUwfDkzqZN59VYtJGw107rK5xj6ZZyrCDSxDVN7C3SLN2WydkWxZdWWbEFWL1hGnKe+Z5gN9uEpjez/H/9oX+D306F2piOBpqkn5M+2UY7DsUqd83hjDequX9tM18maokwvYr1Y7nTqzRIdhDd+xtTeg4DB+9r+AH7agSBKYd2Js7byIXFroMWyutLhKCeufDkJwID8tgvBIhlhj3UHu/AV3F2TmBex0bjIeKlD0T2V03tY9BmFk04YTlY+RIduN7qqicyGDELNLgMcrDs4oi+RmRx32cXeWKhxy7GnP9poY4uCjdgtm5+0ZwFI2xwnf6h07U1LkhZ2UdSye8VDakCCRywdANPh1uJzqcJyoTy9z+q3SdHxwd8pXzJXJv/kA72KzpZku4NRkWwJBe5TxNt37NcQJLafhjCQL1aopnOTUVzM7POq8ue17eshWNfzMWXALP/lWyNmhS30iXNFAFMw3z9EfPk0z0TQto+veEfRBIAM9Iz3m+g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(39860400002)(376002)(136003)(346002)(41300700001)(6486002)(71200400001)(53546011)(6506007)(966005)(186003)(478600001)(2616005)(7416002)(5660300002)(2906002)(6512007)(26005)(38100700002)(76116006)(54906003)(110136005)(316002)(91956017)(8936002)(4326008)(64756008)(66446008)(66476007)(66946007)(8676002)(66556008)(38070700005)(31696002)(31686004)(86362001)(122000001)(82960400001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Lytaemx5SUVnTk5lYWlrbFBJdWRUS1VRWEVHWnJ1OW9LSDgzaVhPS0NRbDBG?= =?utf-8?B?QVU2QWRNVlFVdW9rUkw3eE1TSnZyY3BoM1kra2EyOGdIalZGTnRqc09pQzdj?= =?utf-8?B?bDdXY2kwb2hnLzc2QTNlTTZJeW9yNFRKZEtGQW1uVjQ3a2pTODZjK3FOZHdq?= =?utf-8?B?bnpLZWV1UFBvdmM5SVIrWHIwOStpckZJdlJ0TGkraVUzRnp6VXZSZjUrcUNy?= =?utf-8?B?WUsrUWpOWVBYZXhFZXY3L1FMcG1NYzdlNUtUQnRyMHB6YWtJVUtMRzFsZVBy?= =?utf-8?B?SU1DWHNCWUFDZHZ1cS9TS01GWTIwbkhjb3hrWHBXQ1lQMzRYeklmSkc1VzBL?= =?utf-8?B?UldUU0VCdFdWVVNCdXlydmlBOTd1dnpJQnNoSkhURmVkbUVsSndVS1hGOFFV?= =?utf-8?B?NkJ2TTAyZFVzMTluYzNFaHlDaTN3VnFQTTNleXo0SmRNZGZtVGxKb2Y3UVpU?= =?utf-8?B?Z2V1d0tDSnMvZG5yaTZ5OUxpeXI1YXBjRko1WFVkWFZUSGdQcE9MdVNCWjRj?= =?utf-8?B?UllIYmc1SXJsNURRMENqV3ZJanE4eUhuY3hFZk1POVoxWGFmL0t5WnlhTXZm?= =?utf-8?B?QnR0cmxBYkpEOG0vdGJPZWFlc1g2bWhMNG9WdHhkc1UzbEYwRWwyNVVRMm5D?= =?utf-8?B?a1V2dzI0N0RpMmlZT1Jpci8rVElReWlQc3NjTi84SVlpcW1oQmVYTnRMbk5X?= =?utf-8?B?RnFDZUNGZUZ4bTdsQ2R3c0t0aitLZzJOeHJIN2ZzSGRzVHF0VmFiUVUyb1Ex?= =?utf-8?B?RjJ4by9hRXArNWJxMnA0dkIzVnp4aUNzV2ROSHIvUjE4Vk9Iazk1TzJvaFJk?= =?utf-8?B?NmtlWkpsWkpsY1dmMllPQWJIdEwyd1VxbWp6VUdVMTlOZlgwUURiQUhKc3A1?= =?utf-8?B?YWQrUWlSbE5zUHdzOXRKRWVnd0tGT2VSeXYyR1FhaEd5K0hydzdiQ1BGdk9r?= =?utf-8?B?dUtVbSt0eVBzMmRnOGZmYXlkMWpseUZPNTBlZU1qYWJqNmJYdWllRWpvNHhU?= =?utf-8?B?NFdER1Z5THVhYng2THFJejQ2ZFFGNHJjUk1ueElTekNCMTJCb3NIYStLNmRM?= =?utf-8?B?MytWYnBiYlVRZ0o2Wm5YTVY0KzBFcHR5cGZYZGNyV25jS3p3LzQ1aFJ3bjM0?= =?utf-8?B?NHdndVRYQk9GeVZjalQzNkEyQmxRd052RTdZRjBrY01JVWhDK3NlMndWWGxv?= =?utf-8?B?VG5iZDJBdm1sR0ZsRzVrVGlrQkxlL003Rzc5UUVnZHJwUWthaGFWTU5oZDJv?= =?utf-8?B?a0luOEVNQjJIU0lyMldyK2J3bGtoRXBod1ZKS3hJUjd2bW8weno0a3lVMEM1?= =?utf-8?B?QmhtbStycW5NaG13WnloMWN1My9TZlFEaWpFQlpsTE1PWlpPa3JyOXdadVZI?= =?utf-8?B?aENSWS9hbjEyQlhyc3NpaFVQVU5XMGkwTloxbjRYd1VlcG1keCtSajc1ZzdK?= =?utf-8?B?RDFsNE9zTGZKWXF2TmhIWlVIK0pZT0pKSHR2L3FTS1JtUkNNY29WV2hyeEdB?= =?utf-8?B?c0dvK29ZUHVsZU5kaFM5SGFFOGNqbFppaFNZRTNsSjBjaEpOeVVRaStuR3Jr?= =?utf-8?B?R3JiYXI2clBBYWk0c21TUEFLOFBjVll1dk9Nd0dXcTExSHBrZWNwczJrSVVH?= =?utf-8?B?OUQ4RFArc0RIeEtlaC9PQmhTOUUybkEyR0NxelRpZlpjRVo4Y3g2YzNuLytX?= =?utf-8?B?SElhOWJHR3dmb1RaYTRLQmJJU0xtU2tBa1BYZ3dwc01sT0dtNUN2Uy94YTRC?= =?utf-8?B?blJrY1dwR3JTYlRSaUhiNy9Mck5QQXBjNG5lOTJvZUtWdWJ3MEY1VHhlTmp6?= =?utf-8?B?VDV4VDBYMzNVOUcrdE41TzBTSEFIeHRiU1h2VXJKdUcyVUQzOU56R25oZlZa?= =?utf-8?B?cHIxTFAzMDJNS2l6c0ZFRWRod1ZXRDdJeTg3d3pUcjRCQllsOW96c09KQ1k2?= =?utf-8?B?REJ2VndjTS8zVXlkM3JHZmdjVFhxaDl0eUpuSDZUMW1lRU4vYXRVa2xGVW1P?= =?utf-8?B?MWNlWkhnSTdOMk1PZ1JHWUpzNnlUc0t4RXhTK3hOdWRIQ0pwcFZ4eDBBNnhR?= =?utf-8?B?REozRGJpWDEySUdRd0xPTjAwSDFSQlVYN3UvTUxaSkxxRVFCOHRLQUtrS2pm?= =?utf-8?Q?vDY+VEj6iDSFxC2cU/n1Mm4nz?= Content-Type: text/plain; charset="utf-8" Content-ID: <1C879F78B751814DAAF7D0308F734233@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 909bba41-40c0-4588-1d96-08da664dc98d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 10:35:50.6173 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G69pb/AcI1lqfpc5tQcBRo6GKUTSN8NZLFodrrOcrvDJ5R+BtAww41LxHqLg5A7nfe4j9PJD8u76B4JTtWlhLGSLm1WlmL0jU4GgEw1DTKg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6239 T24gMTQvMDcvMjAyMiAxOTo1OSwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMTQvMDcvMjAy MiAxNjoxMiwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4+IE9uIDE0LzA3LzIwMjIgMTU6MzksIEFu dGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4+IGNoZWNrLWVuZGJyLnNoIHdvcmtzIHdlbGwgd2l0aCBn YXdrLCBidXQgZmFpbHMgd2l0aCBtYXdrLiBUaGUgcHJvZHVjZWQNCj4+PiAkQUxMIGZpbGUgaXMg c21hbGxlciwgaXQgaXMgbWlzc2luZyAweCR2bWFfbG8gb24gZXZlcnkgbGluZS4gT24gbWF3aywN Cj4+PiBpbnQoMHgyQSkganVzdCBwcm9kdWNlIDAsIGluc3RlYWQgb2YgdGhlIGV4cGVjdGVkIHZh bHVlLg0KPj4+DQo+Pj4gVGhlIHVzZSBvZiBoZXhhZGVjaW1hbC1jb25zdGFudCBpbiBhd2sgaXMg YW4gb3B0aW9uYWwgcGFydCBvZiB0aGUNCj4+PiBwb3NpeCBzcGVjLCBhbmQgbWF3ayBkb2Vzbid0 IHNlZW1zIHRvIGltcGxlbWVudGVkLg0KPj4+DQo+Pj4gVGhlcmUgaXMgYSB3YXkgdG8gY29udmVy dCBhbiBoZXhhZGVjaW1hbCB0byBhIG51bWJlciBiZSBwdXR0aW5nIGl0IGluDQo+Pj4gYSBzdHJp bmcsIGFuZCBhd2sgYXMgSSB1bmRlcnN0YW5kIGlzIHN1cHBvc2VkIHRvIHVzZSBzdHJ0b2QoKSB0 bw0KPj4+IGNvbnZlcnQgdGhlIHN0cmluZyB0byBhIG51bWJlciB3aGVuIG5lZWRlZC4gVGhlIGV4 cHJlc3Npb24NCj4+PiAnaW50KCIweDE1IikgKyAyMScgd291bGQgcHJvZHVjZSB0aGUgZXhwZWN0 ZWQgdmFsdWUgaW4gYG1hd2tgIGJ1dCBub3cNCj4+PiBgZ2F3a2Agd29uJ3QgY29udmVydCB0aGUg c3RyaW5nIHRvIGEgbnVtYmVyIHVubGVzcyB3ZSB1c2UgdGhlIG9wdGlvbg0KPj4+ICItLW5vbi1k ZWNpbWFsLWRhdGEiLg0KPj4+DQo+Pj4gU28gbGV0J3MgY29udmVydCB0aGUgaGV4YWRlY2ltYWwg bnVtYmVyIGJlZm9yZSB1c2luZyBpdCBpbiB0aGUgYXdrDQo+Pj4gc2NyaXB0LiBUaGUgc2hlbGwg YXMgbm8gaXNzdWUgd2l0aCBkZWFsaW5nIHdpdGggaGV4YWRlY2ltYWwtY29uc3RhbnQNCj4+PiBz byB3ZSdsbCBzaW1wbHkgdXNlIHRoZSBleHByZXNzaW9uICIkKCggMHgxNSApKSIgdG8gY29udmVy dCB0aGUgdmFsdWUNCj4+PiBiZWZvcmUgdXNpbmcgaXQgaW4gYXdrLg0KPj4+DQo+Pj4gRml4ZXM6 IDRkMDM3NDI1ZGMgKCJ4ODY6IEJ1aWxkIGNoZWNrIGZvciBlbWJlZGRlZCBlbmRicjY0IGluc3Ry dWN0aW9ucyIpDQo+Pj4gUmVwb3J0ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPEx1Y2EuRmFuY2VsbHVA YXJtLmNvbT4NCj4+PiBSZXBvcnRlZC1ieTogTWF0aGlldSBUYXJyYWwgPG1hdGhpZXUudGFycmFs QHByb3Rvbm1haWwuY29tPg0KPj4+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRo b255LnBlcmFyZEBjaXRyaXguY29tPg0KPj4gVGhhbmtzIGZvciBkb2luZyB0aGlzLsKgIFlvdSBi ZWF0IG1lIHRvIGl0Lg0KPj4NCj4+IE9uIHBvbGljeSBmaXJzdCwgd2UgaGF2ZSBodHRwczovL2dp dGxhYi5jb20veGVuLXByb2plY3QveGVuLy0vaXNzdWVzLzI2DQo+PiBvcGVuIGZvciB0cmFja2lu ZyB0aGlzIGJ1Zy4NCj4+DQo+PiBXZSBzaG91bGQgY29uc2lkZXIgaGF2aW5nDQo+Pg0KPj4gUmVz b2x2ZXMgeGVuLXByb2plY3QveGVuIzI2DQo+Pg0KPj4gaW4gb3VyIGxpc3Qgb2YgdGFncywgc28g R2l0bGFiIGNhbiBwcm9wZXJseSBjcm9zcy1yZWZlcmVuY2UgdGhpcyBmaXguwqANCj4+IChJIHdv bmRlciBpZiBSZXNvbHZlczogd29ya3MuLi4pDQo+IFllcyBpdCBkb2VzLsKgIEdpdGxhYiBzdWNj ZXNzZnVsbHkgY3Jvc3MtcmVmZXJlbmNlZCBteSBkZXYgYnJhbmNoIC4uLg0KPg0KPj4gaHR0cHM6 Ly9kb2NzLmdpdGxhYi5jb20vZWUvdXNlci9wcm9qZWN0L2lzc3Vlcy9tYW5hZ2luZ19pc3N1ZXMu aHRtbCNjbG9zaW5nLWlzc3Vlcy1hdXRvbWF0aWNhbGx5DQo+PiBpcyB0aGUgZnVsbCBsaXN0IG9m IHBhdHRlcm5zIGF2YWlsYWJsZSwgYnV0IEkgdGhpbmsgd2Ugd2FudCB0byBrZWVwDQo+PiBGaXhl czogZm9yIGl0J3MgY3VycmVudCBtZWFuaW5nLg0KPj4NCj4+DQo+PiBJIGFsc28gd2FudCB0byB3 YWl0IGZvciB0aGUgcGF0Y2hldyBDSSBydW4gdG8gY29tcGxldGUNCj4gLi4uIHB1c2hlZCBiZWNh dXNlIHBhdGNoZXcgZmFpbGVkIHRvIHBpY2sgdGhlIHNlcmllcyB1cCBmb3Igc29tZSByZWFzb24u DQoNClRoaXMgc2VyaWVzIGlzIG5vdyBmdWxseSBhY2tlZC9yZXZpZXdlZCBhbmQgcmVhZHksIGFu ZCBwYXNzZWQgQ0kgKHdlbGwgLQ0KdGhlIGJpdHMgb2YgQ0kgd2hpY2ggYXJlbid0IGJyb2tlbiBm b3Igb3RoZXIgcmVhc29ucykuDQoNCkdpdmVuIHRoZSBsYWNrIG9mIG9iamVjdGlvbnMsIEknbSBn b2luZyB0byB1c2UgdGhpcyBwYXRjaCBhbG9uZSBhcyBhbg0KZXhwZXJpbWVudCB0byBzZWUgaG93 IFJlc29sdmVzOiB3b3JrcyB0aHJvdWdoIG90aGVyIGJpdHMgb2Ygb3VyIHdvcmtmbG93DQp0b28u wqAgVW5sZXNzIHNvbWVvbmUgb2JqZWN0cyB2ZXJ5IHByb21wdGx5Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:43:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:43:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368104.599287 (Exim 4.92) (envelope-from ) id 1oCInD-0007Dk-Tz; Fri, 15 Jul 2022 10:43:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368104.599287; Fri, 15 Jul 2022 10:43:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCInD-0007Dd-RA; Fri, 15 Jul 2022 10:43:31 +0000 Received: by outflank-mailman (input) for mailman id 368104; Fri, 15 Jul 2022 10:43:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCInB-0007DX-RQ for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:43:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f559231d-042a-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:43:28 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 06:43:25 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by BY5PR03MB5252.namprd03.prod.outlook.com (2603:10b6:a03:224::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Fri, 15 Jul 2022 10:43:20 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b%6]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 10:43:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f559231d-042a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657881808; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FRPLlU3oexD7vGBeeD1i7qjtguNQRRtKb69qkCk8GZ4=; b=ayl1Uu2au9v+C8uvMmntBWaj3cZ3gDLUpL+41jTdoS1G0D7f0cqcuQnx A9UTAzv/GnofML2ivtaqe+PZse8LUKLJ4rN9NfWBmiCKwvQFaGF37hOVq r2mg0b3S0tW0SMGIZmaHppbxE5hCWmEtZE2A9h38pAZxVWdchFpAYUvPf g=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 75176088 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tFfoy6P+5QPK1+vvrR1alsFynXyQoLVcMsEvi/4bfWQNrUp30DwDm mEbC2HXOvffMWHzLYpyOYnkpEoD6sSHyNIwSwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPve8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPmzNU1AhA0DLYBpM1vXyJIy 7szcxYSO0Xra+KemNpXS8FKr+F6dYzBGtNavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr4wCChI1W0q3rMzUYzy0HVwBZ8z/7GN93Nd8bRbc5UglyZt iTN+GGR7hQya4HGlmTdoiLEaunnh2TYSpk3DbGE69FopAe41nU6CkMMbA7uyRW+ogvkMz5FE GQW8Cczqak59GSwU8LwGRa/pRasmgMXUpx+Gusx5QWJ14Ld+QPfDW8BJhZEYcAmtcIrAyAjz EWAm/vxHztzt7uQQHOZsLyTqFuaOzURLGIETT8JS00C+daLiJookhvFQ9JnEai0pt74Azf9x 3aNtidWr6oXpd4G0eO851+vqyKhoN3FQxA44i3TX3m59UVpaYi9fYuq5FPHq/FaI+6kokKpu XEFn42U6rAIBJTUzSiVGrxTTPeu+uqPNyDajRh3BZ49+j+x+nmlO4dN/DV5I0QvOcEBEdP0X HLuVcpqzMc7FBOXgWVfOupd1+xCIXDcKOnY IronPort-HdrOrdr: A9a23:PHIboKH0Q1wB5eyFpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.92,273,1650945600"; d="scan'208";a="75176088" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Joyg+Y9OJWLrrPsQaLxz8vZkf3xcNtRRrVnfCzFD/VVc+g5UXCugTCLQv7rAwhIslxFW428ox+nNlcIwkl0oIS1EExJxGR5J7Kmi2bnFi11KpmeGUyL6Kf3adsWLv4A5rKS8WWj1zr775wmvtGUmv5818EzqxGGTy+pWqbXi18J58zMqzVcQOsSMU1RM+UJ9l5qcepx1Span46h07xkWQNJWjMdFtHLhKfwE/BcDFOdjPW/XYYJFmt+6ShV+qqGCYI2cFiRstPpIVKfJcyt/yDC4GDwlswI7cZN126s5JNejdhUcmJFfG+djnC0Ho8NkufSgK32Ab/ymH3x1vzsmbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FRPLlU3oexD7vGBeeD1i7qjtguNQRRtKb69qkCk8GZ4=; b=hvnUmL8thzAlV4de4yrHL9Ago5nddPV3SgvjNTpObh6hqfv9dtLdTTHM3jxa3nli/yhw/EOxTZC0RCDJ1MZzku8mPX0L22bLjFPZeKH8UAv0+01gf4RuY4Ry5rrhDjvpIuF7mqmQzK1bwX/2y3nRRWpENg8pPSsbkaOZeKaQz6QMrF1ebdiONnUDSNiQ2ghI5v6zjklZ+TmsrqoGOCghgADag/uUlG96PkCL0Dx6DnZQNsNijvKFho60oa2qHYpKImu/BaDMfJ3BHUwj/eiPmlW5Bd1SH2+IxUB58qGS8JodFvfQtIyobm28ZOOVQVkRz39d2PilCSUAeO5t+RBkBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FRPLlU3oexD7vGBeeD1i7qjtguNQRRtKb69qkCk8GZ4=; b=RR951cQCBiiMJMkaUmmHs0W3w9/FflzZCU1NcKHegWGI4ZTyYzYjRdND4+bcNoZjsgbXn4P/+yiQ3sVcGbIxDy5xxlg06z7TDvN6R6qeb7k8X8nHTVXke2ajPbtirknSeuMBryhSXMFYmhkdF0J4wQwODxEIU47+V2F9O/76KX4= From: Andrew Cooper To: Jan Beulich , Anthony Perard CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw61/OECAgAAIBYA= Date: Fri, 15 Jul 2022 10:43:20 +0000 Message-ID: References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7f25dc97-7df6-45a0-d130-08da664ed58a x-ms-traffictypediagnostic: BY5PR03MB5252:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eoesUkTABDKQ3fg/ptFi9w9yvXGobVeVltoqXXI/f/jr/TJDehRArRrOlCFs31lVFxdEZAT9DWR36idblu75G3xiQkVy4oiSqNcdpjZROwC/vJUBgXGKf9yUeWpnvRSr5BUV2UBIeEuV6OhDbRTKpIDz2G31ehA4BTCzbVbdW5RRoCccxBMhE/wjvxOw/p2sPfH0Lrd2SnSgHP9Bdk3FHAUeHXtN/d48sDM0dzmFfLDPhzN4fsRszmcP9KzgORuh1YbsWq10lF313uXJ1lwkSJ8/FuOLCv1nMZQVTcpU0H29qPnaTLZiqtdXbm2utmS35rmBgaCz+pkPsAEUqXYL9OeZ9rNvz+NqZgx0rdblBRxbx5xa+bBMNTjXsjZNHnwOmGypru/TBu4N0lJyAhw8BMTyRn3+Vtm78CSLfNFJzLeK8/77EIn8zovRSPImhzUd2nBNVE4v5N12Ukb2mtnR89S2+/Npj5Uir4DyBldaF8/97GBVTRpNgJ+tEW/JhO5RU6U465gRBvSuUMgx1yi8Ti/1mHSmgKA5UkvjEgqKPFjUr1sl4xk7HDyYZ/jMaDvwE87qdpmFdC1wT5nl/g4+lHX0/NSuLA1PSY9Bhhc/BKROW1E/2qjTnPV2prBi7zw6V+toqJQV+g+oOMUkUJEg5Ty2aymXVbi9Y6b2wzqGOd17bTZZHzALV9JZbitxrXRZO5k7yZYD1tuQ+qmLZBpWa7QSdOcUa/tRI7VMGIq748/SVC9hMYUEvDWlMnslJXEdPvTRttck97eKIWITGkiGOVwU3WlLDlE/7XPUbPDATxP74ZWqzip55hDV/lDtqVJwNCoJrgMmWj2vabqw9zlP5Qk7XgBR+0j8871zYhWAT7hS0uAmrlvfOmLj9sAEN/ua x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(2616005)(5660300002)(186003)(82960400001)(38070700005)(2906002)(31686004)(36756003)(66946007)(64756008)(66476007)(4326008)(66446008)(8676002)(8936002)(76116006)(66556008)(6506007)(316002)(71200400001)(91956017)(26005)(53546011)(6512007)(41300700001)(38100700002)(122000001)(6636002)(54906003)(478600001)(86362001)(6486002)(110136005)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bDZ0emx1ck9jTEV3ZmJBQnV2SXU3di9mUFR3UXgybTRCTzBVQWp0K3Q1ZTBz?= =?utf-8?B?dDhuSXowaVZHL1M5TUE4MS9uam1RODEranlyWTVkL1BXVnNkZC9WSlhwZS9Z?= =?utf-8?B?a2M1WWFYV2dNSm1MYTRuWlBmYmhJd09iMEpyWlYyWGVoRFNzR3NrVG93LzEr?= =?utf-8?B?cWV1YVVVMEdJaEhTbE55c1YyRVFLRkplOUo3bG00ajVHSUM0c1Rpa0tGZ3l5?= =?utf-8?B?SW1EZXZTdGRydnByTng4emZQc3lBL21qaXFMVHpySjZoMGZjcmY2UVQ2UmRy?= =?utf-8?B?VUN0anltb3Vhek1XTWY0S24wWGR5NUZWUS9kcEx6bkt0c0sxT0orVTVTUDB6?= =?utf-8?B?VnFQZTVEeXpCMlF6ZnlSMjJ6K0Z1N3V1UHBrWFlMdlp6QTA0cTFnYXBJbVR0?= =?utf-8?B?QXJCZm1ic1QzSjRSNmVFams1VmFKdi9qZFBwVTB6MmdGQURsWkJtOUV4Rmxz?= =?utf-8?B?Vk5ycWlXc3I4K3BZSHlpZnQ0VmtidHhFSHlFNEwwVmpObTVMSkVwR2N4c000?= =?utf-8?B?dDZLMWtwRGlsMnd1cXl1SVFNYm9ObnN6YW1mU2NFMy83SkpJdGloSEFFaDhL?= =?utf-8?B?aHEwUFlLa3diSG1EY2ROSnhMK0ZSZUtMS1N0a2dXYWo5RFowVndIUnM0UzMx?= =?utf-8?B?KzZXTlIxZHZON1ZYcy8xOHowTW1nN2pVMmNKaGhpOEQ1VzJ0NS8vREVMc3pt?= =?utf-8?B?T2QzeGd0ei9raWthS3lCVUI1bnFSMnNnK3ByOTlQcGNOS1pSRXhzZWpiQUQ5?= =?utf-8?B?Z203cFY5aS92Vy8yQmgrQVJycSt3NkdqRng3WnBTaDI3S2NIQ3JpRzFkb0ZS?= =?utf-8?B?K2JYSkd4VU1XSmlYNVJEQ3loeWMybkNjSURmQUpxN1B0a2NUL3V0c2tFSUFC?= =?utf-8?B?WEpCbmRGZnExbTdWYXVod0wwQ3dlWFo5YjZkaDBZU1ErVEtqQVBXdzVMTnFE?= =?utf-8?B?V1FPWk10U3UzR2NmOE5xZk1lYVJsazlTOUJwZURZV2s0QzQxZEN4VDhMcmEr?= =?utf-8?B?OWhPbUExWmtZZDVwWVVjKzJ3YlY5b3p1NHcrZDUybXp5Y0VCK05mMEVDZWd3?= =?utf-8?B?V2traEF6ODk3MlNIcTJzN2ovNU8zdk1IcmdTNGZ4anUyb0NsVGlNVFpEVUFk?= =?utf-8?B?R3dnNTY4dXJIV05GYUdlU2FRRUVBR09uSFppdVQzUlg2RHFkMGZSSU5HQmsx?= =?utf-8?B?ZzM3bmdvaWQyYVdhWFZackFwOTR2VjhJa2VoeE9LaVZxV1ZrOGRlRnYxWm1C?= =?utf-8?B?ZFI0NjEyOEE3Y0JOeHRNUHVwcTBHblZIMjdIeDVJeXhlU3R5T2tqc3FBbXc0?= =?utf-8?B?eHlGUk90ZDdNTEVNNnBqQktLcWlsaU9xS2YyQTlHVmEvVGtVUEZxUUVsWEZ4?= =?utf-8?B?eEVrOHQ4YjQ2UWJ0blNnR3JXMHdDQkQvTjdNd2FDM2JGMml1bjhmQ0ZWMEtk?= =?utf-8?B?c2FIWjdZZitGaTFxQmtDSERQWjBsSW1OMFBtd3hPbGVneVJFOXdNU2NNcmwy?= =?utf-8?B?N0hjOTJNcFFUdW1QZzd3MFhNek9wRVJDR2IwVFFvVktDTHFzK2pZRjFCS2NY?= =?utf-8?B?cHJOOVBxUmp1aHZ0eEx5d0dKQ0NoZGlEQ1I0L0w3SExiaTNoT1hvaHV1L2No?= =?utf-8?B?Wm55WEJhNlBCekduTnlHaThWRlhrWGhWYkg5ODlJRHpWZUJPMVBxTXdSSnVz?= =?utf-8?B?RUo0bXFWWXJpeFlXQTBGNEUrL3hIWU1hZzZFZEZNT3pHRm1ZckpCd3VXbmNx?= =?utf-8?B?aFBRWEZmbmc2N3BwVEpKWEU3dlRoTTVxWEpGUXhWVXdnSVpaZlhQd3d5Nks2?= =?utf-8?B?ZmxxMHRUSDF1UmpmNFJYVjFCM2ZHRjlRNzMxU1VQcC9XK0poTWUyWmh2Q01B?= =?utf-8?B?a25NeURqRHJETlZqZTExVlpnK2lmdlk3bzl4ZEwwd1ZqY1NiUHdUc0ZxdzY4?= =?utf-8?B?ZitoYThlOHFNQ0I2a2VXYWlIeWNrR3EvQXZ0bEpJSWxMaC9kVVFUNlRadWFt?= =?utf-8?B?a2h3TnN2MjVzbkY4RFJ2RzhzNUNzQkp5OUFLYVZ0c2lNWWhsMktMRnlsMExn?= =?utf-8?B?RTNDVGNpU2lLWVdvbEJuQThNejJmRnc4ME1mSVRwS2JxTUVudnY1enlWTEN0?= =?utf-8?Q?8WfmEo//zwSIoSqHv04c0UDzb?= Content-Type: text/plain; charset="utf-8" Content-ID: <8220B262BCD16049A1F5E4155183B98A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f25dc97-7df6-45a0-d130-08da664ed58a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 10:43:20.2160 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 22eTuzoaQr4RbvIyoU5yqGuBQXGCTQlk+ZURM8kyGGAw2XjMCtopvRuDGSIhqLmgBSLTzI39pBwiRBiL1K3pTWETIhX7W2hlsIPEBdV6474= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR03MB5252 T24gMTUvMDcvMjAyMiAxMToxNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE0LjA3LjIwMjIg MTY6MzksIEFudGhvbnkgUEVSQVJEIHdyb3RlOg0KPj4gLS0tIGEveGVuL3Rvb2xzL2NoZWNrLWVu ZGJyLnNoDQo+PiArKysgYi94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCj4+IEBAIC03OCw3ICs3 OCw3IEBAIHRoZW4NCj4+ICBlbHNlDQo+PiAgICAgIGdyZXAgLWFvYiAtZSAiJChwcmludGYgJ1wz NjNcMTdcMzZcMzcyJykiIC1lICIkKHByaW50ZiAnXDM2M1wxN1wzNlwzNzMnKSIgXA0KPj4gICAg ICAgICAgIC1lICIkKHByaW50ZiAnXDE0NlwxN1wzN1wxJykiICRURVhUX0JJTg0KPj4gLWZpIHwg YXdrIC1GJzonICd7cHJpbnRmICIlcyV4XG4iLCAiJyR2bWFfaGknIiwgaW50KDB4JyR2bWFfbG8n KSArICQxfScgPiAkQUxMDQo+PiArZmkgfCBhd2sgLUYnOicgJ3twcmludGYgIiVzJXhcbiIsICIn JHZtYV9oaSciLCBpbnQoJyQoKDB4JHZtYV9sbykpJykgKyAkMX0nID4gJEFMTA0KPiBJJ20gYWZy YWlkIHRoYXQncyBub3QgcG9ydGFibGUgdG8gZW52aXJvbm1lbnRzIHdoZXJlIHNpemVvZihsb25n KSA8IDguDQo+IFRoZSBzaGVsbCBpc24ndCByZXF1aXJlZCB0byB1c2Ugd2lkZXIgdGhhbiBsb25n IGZvciB0aGUgZXZhbHVhdGlvbi4NCg0KWXVjay7CoCBUaGlzIHdvcmtzIGF0IHRoZSBtb21lbnQg aW4gMzIgYml0IGJ1aWxkcyBiZWNhdXNlOg0KDQorKyBvYmpkdW1wIC1qIC50ZXh0IHhlbi1zeW1z IC1oDQorKyBhd2sgJyQyID09ICIudGV4dCIge3ByaW50ZiAidm1hX2hpPSVzXG52bWFfbG89JXNc biIsIHN1YnN0cigkNCwgMSwNCjgpLCBzdWJzdHIoJDQsIDksIDE2KX0nDQorIGV2YWwgdm1hX2hp PWZmZmY4MmQwIHZtYV9sbz00MDIwMDAwMA0KKysgdm1hX2hpPWZmZmY4MmQwDQorKyB2bWFfbG89 NDAyMDAwMDANCg0Kc28gdGhlIHRvcCBiaXQgaXNuJ3Qgc2V0Lg0KDQpBbmQgZ29pbmcgZnJvbSBh biA4Lzggc3BsaXQgdG8gYSA5Lzcgc3BsaXQgZG9lc24ndCB3b3JrIGVpdGhlciBiZWNhdXNlDQp0 aGF0IHVzZXMgNCBiaXRzIGFuZCB3ZSd2ZSBvbmx5IGdvdCAyIHRvIHBsYXkgd2l0aCBnaXZlbiAu dGV4dCdzIDFHDQphbGlnbm1lbnQuDQoNCkkga25vdyBpdCdzIGRpc2d1c3RpbmcsIGJ1dCBob3cg YWJvdXQgYSBCVUlMRF9CVUdfT04oWEVOX1ZJUlRfU1RBUlQgJg0KKDF1IDw8IDMxKSkgPw0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:47:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368114.599298 (Exim 4.92) (envelope-from ) id 1oCIqd-0008AN-Fe; Fri, 15 Jul 2022 10:47:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368114.599298; Fri, 15 Jul 2022 10:47:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIqd-0008AG-CO; Fri, 15 Jul 2022 10:47:03 +0000 Received: by outflank-mailman (input) for mailman id 368114; Fri, 15 Jul 2022 10:47:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIqc-0008A3-Hd for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:47:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 742883ed-042b-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 12:46:59 +0200 (CEST) Received: from AS9PR06CA0764.eurprd06.prod.outlook.com (2603:10a6:20b:484::18) by PA4PR08MB6157.eurprd08.prod.outlook.com (2603:10a6:102:e3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Fri, 15 Jul 2022 10:46:49 +0000 Received: from VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::bd) by AS9PR06CA0764.outlook.office365.com (2603:10a6:20b:484::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13 via Frontend Transport; Fri, 15 Jul 2022 10:46:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT050.mail.protection.outlook.com (10.152.19.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.15 via Frontend Transport; Fri, 15 Jul 2022 10:46:48 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 15 Jul 2022 10:46:48 +0000 Received: from 10096d9e19d6.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A5E590E2-AAF3-477A-A09A-9ADFF792A8E7.1; Fri, 15 Jul 2022 10:46:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10096d9e19d6.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 10:46:41 +0000 Received: from AS8PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:20b:311::23) by GV1PR08MB7682.eurprd08.prod.outlook.com (2603:10a6:150:61::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Fri, 15 Jul 2022 10:46:40 +0000 Received: from AM5EUR03FT060.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:311:cafe::f9) by AS8PR05CA0018.outlook.office365.com (2603:10a6:20b:311::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19 via Frontend Transport; Fri, 15 Jul 2022 10:46:39 +0000 Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT060.mail.protection.outlook.com (10.152.16.160) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 10:46:39 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2507.9; Fri, 15 Jul 2022 10:46:38 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.9; Fri, 15 Jul 2022 10:46:37 +0000 Received: from a015977.shanghai.arm.com (10.169.188.38) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 15 Jul 2022 10:46:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 742883ed-042b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WLZKzkvyJEmMQrkyjiSiyLQC94kONBpsD/4YlDSpsjG5COF0aBje1zvfhizukdmr2Umsqu9pRDa9pFVo0mVCpdARTp1Ozn8F19w5P/WU3HUfN8Gw1t9Fv8ya4cHlrWEQUWJk5BLE8ip6N+MHojHj/tM2sGuBJqEQRsBpa9BiZnEflmQYdagi1m+arCHsMvTsqmSv4/Esd5Kx9Z2JBhG1pDkv0sTZV2NVVkznzHdhorAY2Pe3FCsK4p4CdYINYywLOzbpgQaQ27nnadAuztlDxrMOK5IDTxaA4cnGeSxX0mLlpxZQyd0/7JVEDJFGpjjXGH7f/cOiN4WnEpfj1dDfcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=be62q+eqSPIlABcw9yzXa9Ay/ADAWlWUIE8vacmfxBo=; b=evcSwLdbMHeElTF1UDGeK46ka1vgPmvZ+aI5aXxP5Y3XxWwIuweL/DGgj+WUDR/bRpoyA3k3uacKKj40jFk6rvWBeEQgx2uAlGCydr1hz7aM/ERDMgQO/Boi/vcOlTYp69du70rDWsZxHu2cattuzRuTAKXgBtbssyleD57TBZlaJb25yzU2iT+RYkkmRjzJ6fL+rl7agBSVOMlliw1MhYe9cTTF/JEWYNDR6OYCXtT6P2lTLrO6lHxLjxTU4oTIgD/8NOEv6Fh6nKmbXE4B6hqLlXA9YCHfSCvYCMJwcq+DcK9S8VpOXc52Ho7KU6nTat0IcaKA+9baorgjCQyLrw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=be62q+eqSPIlABcw9yzXa9Ay/ADAWlWUIE8vacmfxBo=; b=YMvk2BNN8OuHnaq+to4XkScH4s27AIABcK8lNxN4fgWZ6YQQxhkChFYPxwDb5nstofMK99icqE/37jtHWsgp+CmdW8KM7ghYASX91ONhY/y3UhcMgMIcghGAdoE+86dnfyJ7Fxg1ByZjsesrOWwBbGPE4e1fNEANSZZN4klxoF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 85b31f4851c6721a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOC2GatxIcjXdx2iR8xsmi88/DFQ6IxbEQmJ7jlRxCWyYP5/V6To/KRokjsM596yCbd0vTYp9k/SvnpdDtg/BCsNHlNCQzzVNCjYqoxfvv2jcDBUdDnhpexxWNB0BYrPvmr7QPzNAVs2WJkDZIONkhaKV5UD+RZ7a8w6Kg9zz3UZ5kiRAGU4fvGUNFHn1oNCrIXij0pin0dghzclorfjRARbGi0Wx/em959DlrSTnJt0DZfMRkE9t2HD/UePdyfdBVZZgrdk6t8JWwye/KaHWvotjdBXOEtHiSOry5/zEtYCTqJtgtqyymsJJ/TUuG6J2pYh+PYYMfYhDO8U3BnDpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=be62q+eqSPIlABcw9yzXa9Ay/ADAWlWUIE8vacmfxBo=; b=ehA43hgOaky8UXBEkgmVfvqMzoi81CQa6PXBSBiIFZ9labHug4cY7n4cy7ihJRUI7NTngb0rEvRSpK4ABTh5diD89K0uYF4dRM4QbNE1LoOxpERuHbBnSq58VfmwWsC+U5RtrYH7cNPgrgQJNUvTfT6RwrLt1GXzQ9MvdUj1Ntr9G7rQluZy4hJ8KVz/V+xU09upQdjS/XZY4SOS0ZsBoZ3fo0+oO1IHghPSeZmOYkg5V54wVeS2W1EFdXqFbO3+mDb3AX9TwjlfJJkRPB8ePON5+v9i3lLQpWFBaWs23UT38VXabPBUdjB96PPhb5jRqk7wPuAz/Lja5pDiRYJMBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=be62q+eqSPIlABcw9yzXa9Ay/ADAWlWUIE8vacmfxBo=; b=YMvk2BNN8OuHnaq+to4XkScH4s27AIABcK8lNxN4fgWZ6YQQxhkChFYPxwDb5nstofMK99icqE/37jtHWsgp+CmdW8KM7ghYASX91ONhY/y3UhcMgMIcghGAdoE+86dnfyJ7Fxg1ByZjsesrOWwBbGPE4e1fNEANSZZN4klxoF8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Hongda Deng To: CC: , Hongda Deng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] arm/vgic-v3: fix virq offset in the rank Date: Fri, 15 Jul 2022 18:46:20 +0800 Message-ID: <20220715104620.3929121-1-Hongda.Deng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 4c028a7e-0f56-476f-1174-08da664f5206 X-MS-TrafficTypeDiagnostic: GV1PR08MB7682:EE_|VE1EUR03FT050:EE_|PA4PR08MB6157:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: c2g8wCF+01WILBQI35qmUDrcRpymUfKbEZwL9Q8nqGX35+4jKgQ/4nTOr+dNvbn4vVx+iYfDikYk683uzn+plk9rZ+J8vzyKzcAtQ2YwNGeulQNbTjgi1ncqVQrHNN+STJxezjLKtgTZ3JzWLAgc9kLxGgSVw1AJN+V2g8M7OUblxdxsWdInPaI4O1+QNMmFqP2OphIY1JpURXzfz4VX8H6fZwXSwzKI8GrtpcGwo6tCBsklOyDXlQJK8Ov2IDdOjz+S1F2uEO5mSvE6Ol2S77QEfZ+deZynUh6Cu9MM0nIXGmZvfKxADgQU9dnEo9ZSX0AWwGSEvZvhF6mT7/XjaMBmkY8hjazPS5FlhTULTeItpo+2Ukt49RzUCqaGUIVo1LME6lgsnUhqDD0s1OIto5xZr68ubCTfEbLHHz4JZl9LdCnSgpXbW2arU4dTyEoJgFXDRkxjqYdXGcgK7hcUw1QqwXnBLFD+VgAGzwwIbRPdBFNJ3eHKARDIDhx2nj+F35PRuy6YI9eUI53KWC9uJ6b/GChzxdskI44KsDsWkYFGVcuuWrr5C5Gp1zVDjql5AH61FRzlpWp6MxsTf8+bl3WFfiguIxMd6IVxORgL+V6zSOdSPBTt6rpj7txAnei3kGkm94c0jJki7Td8+jy3ozq/Sm8lZjfIv9McMrIYz6IVYvzsWcuDY6ixCtwIe7BeUUZCvyjXFrkYCXd/e79VVj3T3DEkHFG06WamWt56ZJeTBDM32bF0wWpHvn8xNKDIgAHRTDLuMbwsiNhtjX6Br5c0p5p8aw1rqUKfDpqAj3TXXiQwTbipHj3QNv9jTL/5ut7s2hCmzeduB2kFdw6WITudWdXKIXr+wUaCkDEzRiM= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(39860400002)(396003)(46966006)(40470700004)(36840700001)(26005)(41300700001)(82310400005)(8676002)(356005)(2616005)(478600001)(5660300002)(7696005)(6666004)(8936002)(2906002)(40460700003)(36860700001)(426003)(1076003)(47076005)(86362001)(81166007)(36756003)(186003)(82740400003)(83380400001)(70206006)(4326008)(70586007)(336012)(54906003)(316002)(6916009)(40480700001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7682 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3b496153-4e76-4fb1-7581-08da664f4c30 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ikAiAC+8b4IOyTwDxBt+R25ehjsNTK6VGBc9uBQpu99YUUi+oe0xI8HRq2O7olobc52VdAoKHqQHINaqfEInw4y037IdZhAjKCbRIsPlAtxAILz+cmrFeHJjHKRPqE84wwRwkCmiyhXgjGad5b7WF+mq0EBSuhSBa7e5I/SkfO7Tr/jCiKcPZAikAZtcT5URkR/H1vzRJXz50NFCs/4ut94Qk8oK7vhfX4o9CLGlUL8HUMcbUpRw/+Y5qjcGk9u8NjURBENqOcwZDzDDTLqvSJLMSKQNVxMY5OxDUpzqCZKZOJjMPxT2xp0SP/WQB+qxL4dtbWYJUKAUKoTSpQTCZvYwJIXUT1AsDeEf5Wlg8hD9p3EW35nB+zSKuvDLjkthrN9ex+UgjY89MpCpWDPNqffwDpKtSe783LPIZuFi1VuE7Gw395D3n1Ms25rpuhRObuna7AbWPcV2SeEBDT9DhyJGuMY1yAr2VIBFTBps5q/YquiPr2kCD59f9okw8R3T2Re54qLVUL/3XCmRoJ8ga2drkTcoGct8MbeEBNBXzjNaav7wLlQQ0+PWKTpbqm0dCdvqOwEde4X8OuPn8met61kki/dpotO3Ur80iUfQtcGnb3RGduDOEQ0jv78lWKKWnmr+h5zjZc+eV8ZNfA3Pj0SQJDObLYEWd0JzKANjkvnDBxbSK3vL/ldtMR6N1RzKVvX5Aalz+HF08Z0MmwEz04x9vw6J4awUMecbwe21TDh/+Fe6XStaGkbybXvvV/1SyOQbgl5tTFwbvG/j8ONePydnM9+m7d7YX3WiQaPgX764vvC4tLQhdoqe6zYRLa3d X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(46966006)(36840700001)(40470700004)(4326008)(86362001)(82740400003)(36860700001)(70586007)(40460700003)(81166007)(83380400001)(8676002)(70206006)(82310400005)(2906002)(5660300002)(336012)(40480700001)(107886003)(7696005)(2616005)(8936002)(47076005)(186003)(316002)(426003)(54906003)(36756003)(478600001)(41300700001)(1076003)(26005)(6666004)(6916009);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 10:46:48.9860 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c028a7e-0f56-476f-1174-08da664f5206 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB6157 When vgic performs irouter registers emulation, to get the target vCPU via virq conveniently, Xen doesn't store the irouter value directly, instead it will use the value (affinities) in irouter to calculate the target vCPU, and then save the target vCPU in irq rank->vCPU[offset]. But there seems to be a bug in the way the offset is calculated when vgic tries to store irouter. When vgic tries to get the target vcpu, it first calculates the target vcpu index via int target = read_atomic(&rank->vcpu[virq & INTERRUPT_RANK_MASK]); and then get the target vcpu via v->domain->vcpu[target]; When vgic tries to store irouter for one virq, the target vcpu index in the rank is got via offset &= virq & INTERRUPT_RANK_MASK; finally it gets the target vcpu via d->vcpu[read_atomic(&rank->vcpu[offset])]; There is a difference between them when gets the target vcpu index in the rank. Here (virq & INTERRUPT_RANK_MASK) would already get the target vcpu index in the rank, so we don't need the '&' before '=' when calculate the offset. For example, the target vcpu index in the rank should be 6 for virq 38, but vgic will get offset=0 when vgic stores the irouter for this virq, and finally vgic will access wrong target vcpu index in the rank when it updates the irouter. Fixes: 5d495f4349b5 ("xen/arm: vgic: Optimize the way to store the target vCPU in the rank") Signed-off-by: Hongda Deng --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index e4ba9a6476..7fb99a9ff2 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -135,7 +135,7 @@ static void vgic_store_irouter(struct domain *d, struct vgic_irq_rank *rank, ASSERT(virq >= 32); /* Get the index in the rank */ - offset &= virq & INTERRUPT_RANK_MASK; + offset = virq & INTERRUPT_RANK_MASK; new_vcpu = vgic_v3_irouter_to_vcpu(d, irouter); old_vcpu = d->vcpu[read_atomic(&rank->vcpu[offset])]; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 10:52:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 10:52:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368120.599309 (Exim 4.92) (envelope-from ) id 1oCIvT-00018a-3D; Fri, 15 Jul 2022 10:52:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368120.599309; Fri, 15 Jul 2022 10:52:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIvS-00018T-WF; Fri, 15 Jul 2022 10:52:03 +0000 Received: by outflank-mailman (input) for mailman id 368120; Fri, 15 Jul 2022 10:52:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCIvS-00018N-7q for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:52:02 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30042.outbound.protection.outlook.com [40.107.3.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 27a72ded-042c-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:52:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4752.eurprd04.prod.outlook.com (2603:10a6:803:5e::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Fri, 15 Jul 2022 10:51:57 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 10:51:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 27a72ded-042c-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lb3Eyn8Vsah1eRby7o9fGZsIniuCSAB58clkhz8l+qAdK0WhSqnnGxfVsljLsbxnpsrhC8wIBKFzNsFU+QVBdIJLEOzUJ4U5C4et37Gtnu/mrDx/hdNk+VfM3Wm12/QkvGu0+/2mHWAP5XuB6Qda128mzxHEUBHVyXVIGhdaafJ6XA3KofH2hLig2Pd5GkK3a+Yu2lkjgkBwmhLXQzZW0ZwOnuSteDNIoT3qeEwqB7ICATkzTRebRjTi4z2F9zc6KT5yMy9qGKtBBI9ek0LXjRURHBf6UiS44JBGZXUkKIxxkw98d3rQHn19aYDxODxtM5u1+gUM5omV/c1yX1t9Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jp1LeJhPFHwfYBbhRNsYQf6Nf0QdVhWm96SXmKJGxPM=; b=nihH/j5+gq0/vV43eXznsNHM/HHRmryMkjDSQaxH+3+GNc8k4mXO7bIq7xoIhTum1XrU9JgwE+TyOtgK6aDdQQ7661+aGYwiKtIWlwQ8/QrqaKrCApECEtk+z0eOHTJo8ucYC8RLvcEESF1JjohS0vMM8P7MpHE1sRJ1H1BtFqoWO0Al1er2xMWUzmpRwYzv4qZ412YgUG9snobCPZkUKBH4QV5XJ9WqOCln6N5NhOWg77toOP7w5Kp1c9WTFJvooCxgzJf+oPedkC+O8/yyVKNChoCHrlaXmyN20vraBWUMXchoZPY4ExikgUCFcbeIKS9hwC1vgvVyNJIYrc1XzQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jp1LeJhPFHwfYBbhRNsYQf6Nf0QdVhWm96SXmKJGxPM=; b=Wkdeyzibhm4aMbKiKzD1Q+dUR6eLZElm2whjf3POVrGIV5FUsu4zC8Ih75xdS5wg9P3fKhHb8ueGu4CZT8C2UDtyWTmCCUNiY/ZayoCuwXTLzOVSaYh4JVgZs2QtTThD0/xyqJ8Z3dfZDS4D0WDKhLDt6ASI5kBaMWlnvYewbKYyWFCU9nwcKQYR2JgkoGKaciYmiMEBiTIlbw9YgFco+oSwHJqDjWteg8awiHd7/jI8DPOSUFrR9fLYa5ztV51KazR3yjwhn1d3ewRkcxjageadxfjehwooOtCPuK6rs94QaIbPhmbDPPrhqU45hUvx/jazVMfmqdkQFrL94+RMzQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <41ea1e23-83fd-d4ef-c279-fad7f5611a43@suse.com> Date: Fri, 15 Jul 2022 12:51:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Content-Language: en-US To: Andrew Cooper Cc: Luca Fancellu , Mathieu Tarral , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0156.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37858928-664f-4806-0685-08da665009e7 X-MS-TrafficTypeDiagnostic: VI1PR04MB4752:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tUd+7bJTTrbAT+3b8PX8IybUDxp9eaF2cAog7r6TJmckeAGi9XVRbU8W9NcH87i7gIv+FtbStqW+eqBDKoArKttGYMDZdYbfJFc9HH34LXQV7jo7+PGBFqaVLkmEG/CggXEQm+0AOyD8dU+521sShKXH7ifHRdBZQV6lONsTjD6WhpPKFangLtDToH/8iSFwmb3sZVwWvV0JYmZeTJrUB9dzog/KnbORbn66LVWP5oZHtdGalp7oDh2XCkopQnnZlvmjTxy3MqkgZmO7+78lOKVlz9Dhlh/N80m7DvauE7ri56ujq1JgiiYIn9fN/kOUhb6xrAdYwVbX6Zsteduap0ApQ1SREh/t4aEXMfFdDi6QOkiyt67m4h3j0X1H82gh1ARClQ3KWnjVDylFo4g+YSAScNUOb33/c+zC64SO3I9fhgfJb+bm0hVq4uUd+LV+e87EfamjiVGdsAbBgzpjpdRNeaLEL0XjU03IvVLfmvyANRyq4IiQHKP/YGx2KS4jYgePOI1Tmbvfcjoqa0rDBPyoUlcTUxYoaoKI2TKaJI6BQIqM/LCAuOjlA9dHFBHAoam8Vmp1e2zN5CLYaEVsS6nDRnnmZkr1PFvAPC9OYVzl4tC7U6xKWQQFG2JqLUPVZQJZ/n8U7XuyjEZhaVLJVhAER1LrOxOuyP30dnxvfSC7Ucy95f0mvwLT2OFYSR673d58go1LqzBk+9Es3W49iSXg5/uXs9cNY1NabEcYupi+cw6fRpXp7GRtEerSROpy/3tF3aZwSNV1aWYlXRLFb+hQeVaxJUmvsbfQjGRDzWHQ+PiCx6cWQRP15QlfzzXSdkARu3iEahknDLWB+b5xWwkKCBCLWkbgNBXs3yLrKws= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(366004)(396003)(36756003)(2906002)(478600001)(6486002)(186003)(83380400001)(31686004)(2616005)(66556008)(8936002)(8676002)(31696002)(5660300002)(316002)(38100700002)(4326008)(66946007)(6916009)(54906003)(53546011)(66476007)(86362001)(6512007)(41300700001)(26005)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RVRvUjJoYnlJUEUwclFCYXBtZ056VmNsemVjYXJVaTJzUVRhY0RUQ0JjYnlQ?= =?utf-8?B?QTU3dEgwaTNWbDFSUnJONXZmb3FTVGgrTWZGRTJDczllRmRSVzMzcjdDZEN0?= =?utf-8?B?MDFDcDNZdVNGQkU2c0VrVEpRRnVWV0pSQkU4SHlGb2NNSGRjRTFhVE9JWXFF?= =?utf-8?B?UXlWL3VmOU80UjFvMy8yNFpKdEx2V1VrLzVkQmQ5Wnk2YzlQYmZ0TDVtZ3hs?= =?utf-8?B?U2FKTFNVUGNtRFIwOHNxa3E3YzZjZ3djcnFtOGdISW0rTVhta0trZzgrU1ZX?= =?utf-8?B?bDhqRWJWVldwb1N3TGtqc2Vlc0pMVUlrbUhpcERwSnVtNUVSZG56OUlnUTN0?= =?utf-8?B?ZjNNMExONmpPbVZ6QnBkanFMMnB2RU8zT1ozM0xDSndJK3ppbXY4ckRxdkkr?= =?utf-8?B?NC8wSlhLWHBNemc0eTgrWkphVE4vdnFieVczMm9JTUNJM2YwQlZTLy9FYk44?= =?utf-8?B?aExyYVoxMWxlbVM3ZThzZGpNY2RXcEw2Y3VzMXZSMTA1SXBzOHRudEdBNndp?= =?utf-8?B?SWwzcEpSYlZ4N3g2OStFUGl0YmRsaXdMelUyTGFPdlR6L0VOTG9zZkU0eGJx?= =?utf-8?B?U1pBRUQ1ZFgxMUlRdzk3RCtiRkFYaUpGUHJENHpXTDJQcFhWbFFRVkk1UXNL?= =?utf-8?B?clYwSmovclEzY0dFTnhqK2prN0xOTC85bEhFVmE1R0RUaS9PM3FHbk1BOWhy?= =?utf-8?B?ekc0ZHIzZkxVdEEzV1FCWkwveTBRdlFwR1NBYXdrS0dNUXgrZHZObzNjQ0ht?= =?utf-8?B?YUVxazdJcjluR0tPSitGT0JvNm0vcVN3QXI0U3AzVEY0Tm1vbXJtZFZodity?= =?utf-8?B?NGQrcTFONlBBeHcwUVowSFg4NUx0elJEMDE0SE5UZGxVZ0hRNGJkN0VrQ3Vq?= =?utf-8?B?cmRWaE42TUsvaGh4dDk4Ym92emlTK3VjQjYwVGdMbTFlWVlGK3NFNW1QYm9P?= =?utf-8?B?MHJFS09oRUFWZWNyRlc1d3lOKzcxdFlWa2JKRDg0WDY4QWZCb0ViTGI5VUNp?= =?utf-8?B?bFBKNFZPb3VkOTZRQmNzd05qZkIvY0l3TURZL1BPMDU2UVcxL0RPcldtOHp1?= =?utf-8?B?UURpL0I1UWhMUlF6Tk9vYTJzQUU4cS9FVy9KNEM2ZXg2WmdWUlhYTUhwNVdm?= =?utf-8?B?WDRldXBnYm1jdDZZTTFFalBMdVJuZXRveERaNDh6N1RiUDlISXNyRTFkMHhl?= =?utf-8?B?bU5vK0tsbW9lMmErd3A2V3YyYkx3VWRVejN0dmNSZER2dkJ5R0dDRFVIZHhj?= =?utf-8?B?Zmx3b0ZnYlhFbmJkL1dpL3YvemhhQjFTTXhGU3ZUVDZ0aDBOanRnc1Q4Qzl5?= =?utf-8?B?MHRxd1phSTRVS0VCUFhRT3FsdGNQV1gwK2lZbE1DQjFqaGEvQ1NmQlM0aCtL?= =?utf-8?B?Mm05K0FFVDRIOEhUUnVSMU1OMEVWdVMxNDVsZG5CVElNUC9pN0E3amhJL3NY?= =?utf-8?B?d0FLcndLSmRHUWZtbDNSVXgvVlJOclRkc0oxQ25Za2VsUXRXMm1UTkU4djA0?= =?utf-8?B?bDg1VmdEQ0k2WnVTRUxHRG9kV3RrdnhlYkY0R2FkWTRoZmUvczc0M0FxQU1x?= =?utf-8?B?WG52THFZVzFwOWp0TWR3Sm82UmNtclQ3TWxMZmQrUVl2YTBOZ2h4Q0JGR3hS?= =?utf-8?B?YVdyVFhtNmcrczdSeElma0diOCt2NzZ0ZXlxUlQwQXoyK2ZKK1grZXh3ZmJL?= =?utf-8?B?ZXRybVN0ekVKb0NaUXF2MlBLRllWZTFVWlV1anUxZzFKQk1lWngyc24xL2dw?= =?utf-8?B?WXAwcGE2aTBKdkswTStLeW9Mc0xNeC9sVGRnL0U2VC9IcXlodVJHK2ZmOEhU?= =?utf-8?B?cXA0Ly9CNm1jZkh6WlpneGd3TVliZHNSc3dWL05na1dUQUoyZVViOG9kYlY3?= =?utf-8?B?RWtiZjI4NUlrekZLZTc2ejB6T0FNWlZpNHZ2TStaMlpaV3F6Yld1TzNVK2dv?= =?utf-8?B?MHJUS0lHaGxxVE1UYjQvTXBOallhSXJ0ZTlBUUNyVDNNRnlKSUNaYzNQUmlK?= =?utf-8?B?NTVnTk5lMkxFNmtmdkoxK2hESzQrM3FrckIxMjdPOFYvVGtqSzFNUTB1c0g1?= =?utf-8?B?NlcxVU1zNTl3bG1ia3EzSkxKRU9SSnFFUyt2dG0yeXl2YUFSTmRGQkx1aTZO?= =?utf-8?Q?6gtdn1QJRBwqjoGUoD+xCAjPP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37858928-664f-4806-0685-08da665009e7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 10:51:57.7773 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KswIYAGRqbLND8iEJePod/7bokqkOfWS7nPa8FM97CrzOFIeybIhvpqNFYXTq6uFBNY/E/oMFDmy3E0kTpcAJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4752 On 15.07.2022 12:43, Andrew Cooper wrote: > On 15/07/2022 11:14, Jan Beulich wrote: >> On 14.07.2022 16:39, Anthony PERARD wrote: >>> --- a/xen/tools/check-endbr.sh >>> +++ b/xen/tools/check-endbr.sh >>> @@ -78,7 +78,7 @@ then >>> else >>> grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ >>> -e "$(printf '\146\17\37\1')" $TEXT_BIN >>> -fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL >>> +fi | awk -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL >> I'm afraid that's not portable to environments where sizeof(long) < 8. >> The shell isn't required to use wider than long for the evaluation. > > Yuck.  This works at the moment in 32 bit builds because: > > ++ objdump -j .text xen-syms -h > ++ awk '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, > 8), substr($4, 9, 16)}' > + eval vma_hi=ffff82d0 vma_lo=40200000 > ++ vma_hi=ffff82d0 > ++ vma_lo=40200000 > > so the top bit isn't set. > > And going from an 8/8 split to a 9/7 split doesn't work either because > that uses 4 bits and we've only got 2 to play with given .text's 1G > alignment. Why does text alignment matter here? All we care about are offsets into the Xen image. An I guess we aren't really at risk of going beyond 256M in image size ... > I know it's disgusting, but how about a BUILD_BUG_ON(XEN_VIRT_START & > (1u << 31)) ? In the worst case, why not. But that would be an odd restriction on changes to the memory layout (which we've done in the past). Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 15 11:00:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 11:00:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368130.599320 (Exim 4.92) (envelope-from ) id 1oCJ39-0002Bq-0V; Fri, 15 Jul 2022 10:59:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368130.599320; Fri, 15 Jul 2022 10:59:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCJ38-0002Bj-Ts; Fri, 15 Jul 2022 10:59:58 +0000 Received: by outflank-mailman (input) for mailman id 368130; Fri, 15 Jul 2022 10:59:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCJ37-0002Bb-Ep for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 10:59:57 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 40e8ab3b-042d-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 12:59:54 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26F9hEMX028927; Fri, 15 Jul 2022 10:59:46 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3haua5sv51-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Jul 2022 10:59:46 +0000 Received: from AM9PR03MB7680.eurprd03.prod.outlook.com (2603:10a6:20b:41d::24) by AS8PR03MB7495.eurprd03.prod.outlook.com (2603:10a6:20b:2e9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Fri, 15 Jul 2022 10:59:42 +0000 Received: from AM9PR03MB7680.eurprd03.prod.outlook.com ([fe80::ed37:904b:2d41:e883]) by AM9PR03MB7680.eurprd03.prod.outlook.com ([fe80::ed37:904b:2d41:e883%2]) with mapi id 15.20.5438.015; Fri, 15 Jul 2022 10:59:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40e8ab3b-042d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cvQcKGlG3w/Xc1h7/Fvi7ILsZsMzXnPCosydx6Qt8hdzCzqaOI/zCo7xVLTPO+UYUWdNeMqPoXfJDLju7cRXinbNnUTK0htxr+b/nBNdrATOnTVU3X5vQ/CC1TrvH+G274KznWAMc7BFrqRo2tO4eK97aTp1DPwq/RXSyuYzY94ZQjN0BwZhp7sf+jpVEyKYsU8uNZPzWAocXxlu73ATn7Iamq5rOCzmhl6CfJKjtj+ziwgyFJLXKEa/KareMPaNqWAWC1Bt8nwk8Jg4+n8nBUuGTGdovneCUrbRvwwQgzqCf7y5iTxkOHNgtm8n2OR9TLUSZM+RSkUwbad9I8mXhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=86oec6kRLuR1HZKTv1IVdAH9Ta8dfgthXd+CsTmA3gQ=; b=ecfqFW46xv0gT66UrAWqK0dxOGtjjfk7Y4ZdfewAxiNR0c2hqz5Jxk5TmswrRF3LXVENDizQLsKDy6QVRQX3FvS+f/nI/s/I+GRmMTwSvm6drPrMhJ69687Wo0vodeBm7u5Ap4PmKELn8m2NqlTvk+gkImV7sGarr9egFkKmwR7Plarl+F8kYa2k7EOjo7I/T9n7icXIJ+NkPxqNrk7/K3i/gER3hRDc14LCWDKUeGk6zEWcvtvG9nUfgASF2jnh6yJNZiF7LKgjdeUt+yRoN3jIFaTdi/bDwBSrGkgkp1PPhBxW2VAJ38V+9T7Ih6KzNrKDVULp+QtTCSV9PAHgxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86oec6kRLuR1HZKTv1IVdAH9Ta8dfgthXd+CsTmA3gQ=; b=hXDXYkPTC1/x6326U7KkH1LGSqeEOXUIuJT76bu95I1PiGEA+RPpupBKA+MVAi1G53Ujuc6zYqoQq3F1SEz9cQflKJ3uh/U0sjIKAe5WOAOTgBraDB++6kVwCl5DRc5n33VrGphQyN11Ca5+ONkqYMLY8CUWpbDA6cZlalMmEktyqDlaOkJhTfEzTa7WixQMjTx74AqxFMq1XEdbw+5Pn0ji6IOwix2QBEs4474Znf/tCqa9+g7+wzMmdFsU7s076f20vbGLkitPQ12GZ1QMKp1uYKsVwkAVzJ50ZxQSj3U51c/cktVRn3bAoSW3BRIKOR+sMbgaY7x8ddiqVpQkZw== From: Artem Mygaiev To: =?utf-8?B?QWxleCBCZW5uw6ll?= , Trilok Soni , Oleksandr Tyshchenko CC: Stratos Mailing List , Viresh Kumar , Mathieu Poirier , Mike Holmes , Azzedine Touzni , Stefano Stabellini , Christopher Clark , Arnd Bergmann , Peter Griffin , AKASHI Takahiro , Leonardo Garcia , Randy Linnell , "don.harbin@linaro.org" , Sumit Semwal , "xen-devel@lists.xenproject.org" , Wei Liu , "Florescu, Andreea" , "rust-vmm@lists.opendev.org" Subject: Re: Add Xen support to vmm-reference? (was Re: Call for topics and skipping next weeks sync) Thread-Topic: Add Xen support to vmm-reference? (was Re: Call for topics and skipping next weeks sync) Thread-Index: AQHYltDLuF+fxmsbi0mh4vi499rA6a1/Ritt Date: Fri, 15 Jul 2022 10:59:42 +0000 Message-ID: References: <8735f5s6n7.fsf@linaro.org> <87o7xtqa92.fsf@linaro.org> In-Reply-To: <87o7xtqa92.fsf@linaro.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6882b556-91f1-4b41-9cfc-08da66511ed8 x-ms-traffictypediagnostic: AS8PR03MB7495:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MTCkUW2vUCXStqXOmoJGFVWrcJIoppZuJli+n91mbRSLHzhwDcPtyRTsibAeFHI+P/kXMoL2343YSy48mK4LjVgDkrlHbvFXJIRveZgeb28XsYgHKj4eHb2XRSFINy9Gak9KG9JpkhC4E2obHYOm6dwTTsy7drig71G9mNOSs/tlr07JrhxNHqCZhSRQq1/0KxszXVwBmT5FRGbeucxTbkpczP4zONUoY8itEOWjv797+OzviDW13R0vQ6FaedT/KMIRutC4ksgCH9tQ4h3jMuwqpRi7F0vFBvh3EdrIM2O8lOzgDdglBufZnqDRjFWwz/u3be97xSUfe4GBOTqW6RLUNyNrqFfB23u7gAB6fweFcoPqBm/6Z8nT0SapKsCHDn4UnYCS5fkO/Ui1mP7B24LF3MTp779bgpmCm3YCt88Bo8cYYemwMOyeaCEvn2aNxL4OIqmytFSxwDn0pq0N30nM//YSiCoLcU1JN0oFXhshP7D/igEInnBFsk28Ad1TJYAw7RUwIt1At1gGzRM5QRgrrdHajiOtNJIZ09HeveiQfBNqhWWWHuWG3dRD0SAJzvx9HA9QEaVMFcB5lwazDnI2SIq8h36n4s6g8rWG68DZvIENx5LpRebBYRFvUVBhCrMvjqFKOM/ecPRd+RVwRq3OigIZXZyOFCEWNW2Rb65b1D8u+r9zt6VZvSxRXfUH3MkIKza9Cu5ud/6YCDe0x30L8ANxO5Fi9MjOcNWtjC2ukpxkKJrOej1jkkEljDUsIdHqiDisKv4IdCOq5z5/k1ZSPvTxcxUNs7YYvAmV2I+NCC1JQSznLiyLU5etdcuk3kQOqg/5xE+q0xpKpAK65ad5gOrljXjMaUB4CMgLEFQ/k253FspyHxsqnk9sRttq8olRprDFnREgXZ0giW81Wa09BOfxy/E0lCCF9Fyn8Co= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR03MB7680.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(86362001)(38070700005)(122000001)(166002)(91956017)(66446008)(38100700002)(66556008)(110136005)(8676002)(66946007)(4326008)(66476007)(76116006)(64756008)(6636002)(18265965005)(55016003)(54906003)(316002)(2906002)(5660300002)(52536014)(186003)(66574015)(7416002)(83380400001)(8936002)(966005)(478600001)(71200400001)(7696005)(9686003)(26005)(41300700001)(33656002)(53546011)(6506007);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TW1uWG5BUDFnTVFKL2RqTmNCdWFDNXg5eHlIeHVDWkd6VEZ2emZodFRZTkN3?= =?utf-8?B?R2MraFMydFhVbnVLMXRFNVp3N2RYYm1oQ1RVdTRKQWZhM2Y2VzVVNVNWMjBr?= =?utf-8?B?RkJwaUVFQy9RZUR0Z2laUWR5MlQvZG1lS0xGSlk0VS83ZCtReWRKSWtRbHNr?= =?utf-8?B?N3kzY050MkxtZ09tVFdmdFE4VlJpNE9kQ3dpcVlnTXR3NkI3MlhzUFlTdCt5?= =?utf-8?B?anZhc0hFc2QxMmhZK0MvanI5VWpTbG50Z3I1cHAxWHFtUWdnQUpXQm1GT1VO?= =?utf-8?B?NDBvZlNiVHJhQWU4Z051T0ZJSGw3OXFMSDFWWXhFVHpQWWtXdy9SVVpsT2Ry?= =?utf-8?B?b3NEb2p1aWthNmMzM01ERi9Xb0pJSlY2bkZwK1dwTHpZREZROExneEpBZFBh?= =?utf-8?B?em1KWmVFVVNRc0hWa1JlMU4xakJjOURLcnk1Y05VOUJobXpEaDVyenVrUEc5?= =?utf-8?B?U0poV0lhT3N0Q3dBUFNXSEwyZXU2dGd3MDhURzYzemppTU5KbXNtRzQ3L21q?= =?utf-8?B?VWJDY040RHk2UHZJN0pOZVl4TWk2SlBISndXeFFERnFXei9od1p6NytYaHg5?= =?utf-8?B?TFMyTThLSDJRMWc2MjRaSDBzN3NqaWJLazdjTk4rRDIrNmFxUllDOUljMWlo?= =?utf-8?B?aHZ3aFRkQmtKKzFnQVRNMmFKbWllcXR3MkNwbG1EOXBJNUVkWFhFb2tKM2dW?= =?utf-8?B?OHIxWlJVZGFkQy9OQ2VSOCtNeFE5c0xtd0ZET1FpYWFialcvZFZZeE50VnFG?= =?utf-8?B?MFJQNzdtOVd6dTdUUUhoelloeGdaWE5LRFdWQTlJaFJoV2JiREc5TFBBelY5?= =?utf-8?B?WWhaT3dGbms3OFRGS0liRDhSektwV0ZZNXFmdXM3dklUZ1JkNEJMVHFBdzBn?= =?utf-8?B?ZlBwOUtOeFIwUjF5RGZrQnlpTEc1WS9RV25BWHBKM3JOSkZFNVloVHZGd3g4?= =?utf-8?B?VWVjdjJBeCswbWJGbTBqdmlLTHZEdlZxbXMyUFhSSDhOaXdJYzJFRDc4TWlW?= =?utf-8?B?ZSsyWTRwb29DQjlOeU1DTTRzdENCWVliTFZWMlFqcXdkaE1Ec2VwdkFraStq?= =?utf-8?B?di96NFRVZXpwQVpVNHg0NXFrZFg0SWVQN3FtMTJLaWowUXlyWlNWa3BYd3c0?= =?utf-8?B?cHdsZ24zZE5pcGcxaDRSZlBkb3FNWDZQNDlsZW81U3NXQlIwaWVkbnl2OGZy?= =?utf-8?B?UmlHZmRmR3lRclJ5Qmk0Um1udnBOVHhsNW5Dam51OVVCdDZVTE9ES01Vbmxz?= =?utf-8?B?YzkvMUVhaXpPekhMb3NCK0ZrWFMxVmZxa2lPRmFIakJmOXhQT0Zza2wxcXlp?= =?utf-8?B?QmlrV3BXSWw2UTcrMkJPd1hwMFc5b0FDSmtuTlZFSktnRWpxbHd3YU85YTJo?= =?utf-8?B?Ni9KaTdpLzJDdG1tTFB3K3d1TDJtcmZGSHJTdzBPdUtLeGN5VkR4RjhGYXVJ?= =?utf-8?B?THNHWmxxMGF5RWlMVktWMXNFdHZxTGcvcEtob00rUm1TTnpmL1BmVFVzdXhT?= =?utf-8?B?U3ZJb0puaGs2TXdFaWtxc0xyYzNSMFg1eTQ0SGx2VVB2dllRZmRWNDNUSE4w?= =?utf-8?B?cTVCTERqVmRXUFJqNHU1ZHZNWjQwMEoyVUdwQmh3b3dVemppVWNhWU5ON0pR?= =?utf-8?B?ejUxTlVRQnlFdWpOYjU0N2VzNVJpNnBOZS9PYW1jL1h1OGtrVllISFZRSGFG?= =?utf-8?B?ZURyOXhlaW8zNGhUVnE3YkQyVm5QU3o0RFBva1o2ZzNjVXBLdFFnR2l5aHhY?= =?utf-8?B?ekpvWFF0YkdRMEJwQkpoRjRhWnNnaTNSMHR3ZElPT1YvZy9iYk9SUnRDaTZk?= =?utf-8?B?TnhMOGUwTE14ZmVQRHFTOXRzbmtGbUJLbzF2Z2VaQWxmQ2MvVERkNjlQaDFs?= =?utf-8?B?a2dUQVpTUWpWNjlLSXpxNGZhTHMvRFRhVTltbHU4RkV1d3ZCUlFFWGxzcXdV?= =?utf-8?B?SnpwbmJveU1GdTRlQlBjcHZ5dWxoNmNqcHRwR25EWWtEc2tDT2t1R29sbHl3?= =?utf-8?B?ZjlZai9RODlkZWdqa1ZhRSs0bndnSmNIakQzRmx1TnhiNFluWmw3OXlLRlJq?= =?utf-8?B?Y2VzcFJiZ2plRUF3ZHZTak02Z2NWckhubjUwTEl5OUhRdVl4KzZMMmlPV3hM?= =?utf-8?B?K1F1bFdvL2hvdkloN1d5d3I0UDdIUW45VTk2NndFRVUxZVZjMFJ3OEFWQ0JE?= =?utf-8?B?ZUE9PQ==?= Content-Type: multipart/alternative; boundary="_000_AM9PR03MB7680EFA0E9F1BD182641CA20F48B9AM9PR03MB7680eurp_" MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: AM9PR03MB7680.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6882b556-91f1-4b41-9cfc-08da66511ed8 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 10:59:42.1774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jzsNysPwWZvB67HVCjgnKaO4mbQEsMykxbw8eaDRihtyJkNx1ZtpIA134z9eJ2CNB/N+XDx1j8lQn7nAoW3Dxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7495 X-Proofpoint-ORIG-GUID: hpH0GOuXqGHOj93XNOW1luQBioqfSRSX X-Proofpoint-GUID: hpH0GOuXqGHOj93XNOW1luQBioqfSRSX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-15_03,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 suspectscore=0 phishscore=0 clxscore=1011 mlxscore=0 spamscore=0 malwarescore=0 lowpriorityscore=0 mlxlogscore=999 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207150048 --_000_AM9PR03MB7680EFA0E9F1BD182641CA20F48B9AM9PR03MB7680eurp_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 KyBPbGVrc2FuZHIgVHlzaGNoZW5rbw0KDQotLSBBcnRlbQ0KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18NCkZyb206IEFsZXggQmVubsOpZSA8YWxleC5iZW5uZWVAbGluYXJvLm9yZz4N ClNlbnQ6IFdlZG5lc2RheSwgSnVseSAxMywgMjAyMiA2OjM5OjIzIFBNDQpUbzogVHJpbG9rIFNv bmkgPHRzb25pQHF1aWNpbmMuY29tPg0KQ2M6IFN0cmF0b3MgTWFpbGluZyBMaXN0IDxzdHJhdG9z LWRldkBvcC1saXN0cy5saW5hcm8ub3JnPjsgVmlyZXNoIEt1bWFyIDx2aXJlc2gua3VtYXJAbGlu YXJvLm9yZz47IE1hdGhpZXUgUG9pcmllciA8bWF0aGlldS5wb2lyaWVyQGxpbmFyby5vcmc+OyBN aWtlIEhvbG1lcyA8bWlrZS5ob2xtZXNAbGluYXJvLm9yZz47IEF6emVkaW5lIFRvdXpuaSA8YXRv dXpuaUBxdGkucXVhbGNvbW0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pIDxzdGVmYW5vLnN0YWJl bGxpbmlAeGlsaW54LmNvbT47IENocmlzdG9waGVyIENsYXJrIDxjaHJpc3RvcGhlci53LmNsYXJr QGdtYWlsLmNvbT47IEFybmQgQmVyZ21hbm4gPGFybmQuYmVyZ21hbm5AbGluYXJvLm9yZz47IFBl dGVyIEdyaWZmaW4gPHBldGVyLmdyaWZmaW5AbGluYXJvLm9yZz47IEFLQVNISSBUYWthaGlybyA8 dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+OyBBcnRlbSBNeWdhaWV2IDxBcnRlbV9NeWdhaWV2 QGVwYW0uY29tPjsgTGVvbmFyZG8gR2FyY2lhIDxsZW9uYXJkby5nYXJjaWFAbGluYXJvLm9yZz47 IFJhbmR5IExpbm5lbGwgPHJhbmR5Lmxpbm5lbGxAbGluYXJvLm9yZz47IGRvbi5oYXJiaW5AbGlu YXJvLm9yZyA8ZG9uLmhhcmJpbkBsaW5hcm8ub3JnPjsgU3VtaXQgU2Vtd2FsIDxzdW1pdC5zZW13 YWxAbGluYXJvLm9yZz47IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyA8eGVuLWRldmVs QGxpc3RzLnhlbnByb2plY3Qub3JnPjsgV2VpIExpdSA8d2xAeGVuLm9yZz47IEZsb3Jlc2N1LCBB bmRyZWVhIDxmYW5kcmVlQGFtYXpvbi5jb20+OyBydXN0LXZtbUBsaXN0cy5vcGVuZGV2Lm9yZyA8 cnVzdC12bW1AbGlzdHMub3BlbmRldi5vcmc+DQpTdWJqZWN0OiBBZGQgWGVuIHN1cHBvcnQgdG8g dm1tLXJlZmVyZW5jZT8gKHdhcyBSZTogQ2FsbCBmb3IgdG9waWNzIGFuZCBza2lwcGluZyBuZXh0 IHdlZWtzIHN5bmMpDQoNCg0KKGFkZGVkIHhlbi9ydXN0LXZtbSB0byBDQykNCg0KVHJpbG9rIFNv bmkgPHRzb25pQHF1aWNpbmMuY29tPiB3cml0ZXM6DQoNCj4gSGVsbG8gQWxleCwNCj4NCj4gSXQg d291bGQgYmUgZ29vZCB0byBjaGVjayBpZiB0aGVyZSBpcyBhIGVub3VnaCBpbnRlcmVzdCB0byBt YWtlDQo+ICJ2bW0tcmVmZXJlbmNlIiBleHRlbmRlZCB0byB3b3JrIHcvIFR5cGUtMSBIeXBlcnZp c29yIGxpa2UgWGVuLiBUaGlzDQo+IHdpbGwgY2xlYW4tdXAgdm1tLXJlZmVyZW5jZSB3LyBLVk0g cmVmZXJlbmNlcywgYW5kIGl0IHdpbGwgYmUgYSBnb29kDQo+IGluZGVwZW5kZW50IHRvb2wgdG8g dGVzdCB0aGUgbmV3IGludGVyZmFjZXMgYWRkaXRpb25zIGluIHRoZSBydXN0LXZtbS4NCj4NCj4g aHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0aHViLmNvbS9ydXN0LXZtbS92 bW0tcmVmZXJlbmNlX187ISFHRl8yOWRiY1FJVUJQQSEwdWo3N1NsLWhaVmRSNjlYdUFhRExJODdr c1RrdFN6RTMtcTJ1TDcweGxSZUhfUWJrRHJqbnZkbTlmTTBFNVBlZUs1aWlzT3BRVHM5UWY3OW1K V3RuSjJaJCBbZ2l0aHViWy5dY29tXQ0KDQpXZSBoYXZlIGNlcnRhaW5seSB0YWxrZWQgYWJvdXQg aXQgYmVmb3JlIGFuZCB0aGUgd2UndmUgcHV0IGluIHNvbWUgb2YNCnRoZSBncm91bmR3b3JrIHdp dGggdGhlIHhlbi1zeXMgY3JhdGUNCihodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6 Ly9naXRodWIuY29tL3J1c3Qtdm1tL3hlbi1zeXNfXzshIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wt aFpWZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVl SzVpaXNPcFFUczlRZjc5bUpSc2paelUkIFtnaXRodWJbLl1jb21dKSB3aGljaCB3ZSBhcmUgdXNp bmcgZm9yIHRoZQ0KeGVuLXZob3N0LW1hc3RlciB3b3JrLiBPZmYgdGhlIHRvcCBvZiBteSBoZWFk IHdlIHdvdWxkIG5lZWQgdG8gd29yayBvdXQ6DQoNCiAgLSBXaGljaCBhZGRpdGlvbmFsIEFQSXMg bmVlZCBpbXBsZW1lbnRpbmcgZm9yIFZNTSBsaWZlY3ljbGUgbWFuYWdlbWVudA0KICAtIEhvdyB0 aGUgcnVuIGxvb3Agd291bGQgbG9vaw0KICAgIC0gQUlVSSBIeXBlci1WIG11bmdlcyB0aGlzIGZv ciBydXN0LXZtbSBieSBwcm92aWRpbmcgYSBLVk0tbGlrZQ0KICAgICAgaW9jdGwgQVBJIChQT0Mg dmlhIENyb3NWTTogaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vZ2l0aHViLmNv bS9wZXRydXRsdWNpYW45NC9jcm9zdm0vdHJlZS93aW5kb3dzX187ISFHRl8yOWRiY1FJVUJQQSEw dWo3N1NsLWhaVmRSNjlYdUFhRExJODdrc1RrdFN6RTMtcTJ1TDcweGxSZUhfUWJrRHJqbnZkbTlm TTBFNVBlZUs1aWlzT3BRVHM5UWY3OW1OSDFtRkZXJCBbZ2l0aHViWy5dY29tXSkNCiAgICAtIFNl ZSBhbHNvIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dpdGh1Yi5jb20vcnVz dC12bW0vY29tbXVuaXR5L2lzc3Vlcy8xMjFfXzshIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpW ZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVp aXNPcFFUczlRZjc5bU9FX0tnangkIFtnaXRodWJbLl1jb21dDQogIC0gV291bGQgd2UgYWltIGZv ciBmdWxsIGluZGVwZW5kZW5jZSBmcm9tIHRoZSBleGl0aW5nIFhlbiB1c2Vyc3BhY2UgbGlicz8N CiAgICAtIHhlbi12aG9zdC1tYXN0ZXIgd2FzIGJyb3VnaHQgdXAgdXNpbmcgdGhlbSwgbm93IHNs b3dseSBiZWluZw0KICAgICAgcmVwbGFjZWQgd2l0aCBwdXJlIHJ1c3QNCg0KSSd2ZSBhZGRlZCBp dCBhcyBhIGRpc2N1c3Npb24gdG9waWMgZm9yIHRoZSBzeW5jIGNhbGw6DQoNCiAgaHR0cHM6Ly91 cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vY2FsZW5kYXIuZ29vZ2xlLmNvbS9ldmVudD9hY3Rp b249VEVNUExBVEUmdG1laWQ9Tlc4M05YTnNaMlExTm1GMGJURTBkR05rTTNRMFlqRnJjVGxmTWpB eU1qQTRNRE5VTVRVd01EQXdXaUJqWDJvM2JtZHBNVzg0Y214dlptdHdaV1EwY2pWamFEazRiWFpu UUdjJnRtc3JjPWNfajduZ2kxbzhybG9ma3BlZDRyNWNoOThtdmcqNDBncm91cC5jYWxlbmRhci5n b29nbGUuY29tX187SlEhIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tz VGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFUczlRZjc5bUlB WFJwQkgkIFtjYWxlbmRhclsuXWdvb2dsZVsuXWNvbV0NCg0KSXQgd291bGQgYmUgZ3JlYXQgaXMg d2UgY291bGQgZ2V0IGFueSBpbnRlcmVzdGVkIGZvbGtzIGZyb20gdGhlIHJ1c3Qtdm1tDQphbmQg WGVuIGNvbW11bml0aWVzIHRvIGNvbWUgYWxvbmcgdG8gdGhlIGNhbGwuDQoNCj4NCj4gLS0tVHJp bG9rIFNvbmkNCj4NCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQWxleCBC ZW5uw6llIDxhbGV4LmJlbm5lZUBsaW5hcm8ub3JnPg0KPiBTZW50OiBXZWRuZXNkYXksIEp1bHkg MTMsIDIwMjIgMjoxNiBBTQ0KPiBUbzogU3RyYXRvcyBNYWlsaW5nIExpc3QgPHN0cmF0b3MtZGV2 QG9wLWxpc3RzLmxpbmFyby5vcmc+DQo+IENjOiBWaXJlc2ggS3VtYXIgPHZpcmVzaC5rdW1hckBs aW5hcm8ub3JnPjsgTWF0aGlldSBQb2lyaWVyDQo+IDxtYXRoaWV1LnBvaXJpZXJAbGluYXJvLm9y Zz47IE1pa2UgSG9sbWVzIDxtaWtlLmhvbG1lc0BsaW5hcm8ub3JnPjsNCj4gQXp6ZWRpbmUgVG91 em5pIDxhdG91em5pQHF0aS5xdWFsY29tbS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHN0 ZWZhbm8uc3RhYmVsbGluaUB4aWxpbnguY29tPjsgQ2hyaXN0b3BoZXIgQ2xhcmsNCj4gPGNocmlz dG9waGVyLncuY2xhcmtAZ21haWwuY29tPjsgQXJuZCBCZXJnbWFubg0KPiA8YXJuZC5iZXJnbWFu bkBsaW5hcm8ub3JnPjsgUGV0ZXIgR3JpZmZpbiA8cGV0ZXIuZ3JpZmZpbkBsaW5hcm8ub3JnPjsN Cj4gQUtBU0hJIFRha2FoaXJvIDx0YWthaGlyby5ha2FzaGlAbGluYXJvLm9yZz47IEFydGVtIE15 Z2FpZXYNCj4gPEFydGVtX015Z2FpZXZAZXBhbS5jb20+OyBMZW9uYXJkbyBHYXJjaWENCj4gPGxl b25hcmRvLmdhcmNpYUBsaW5hcm8ub3JnPjsgVHJpbG9rIFNvbmkgPHRzb25pQHF1aWNpbmMuY29t PjsgUmFuZHkNCj4gTGlubmVsbCA8cmFuZHkubGlubmVsbEBsaW5hcm8ub3JnPjsgZG9uLmhhcmJp bkBsaW5hcm8ub3JnOyBTdW1pdA0KPiBTZW13YWwgPHN1bWl0LnNlbXdhbEBsaW5hcm8ub3JnPg0K PiBTdWJqZWN0OiBDYWxsIGZvciB0b3BpY3MgYW5kIHNraXBwaW5nIG5leHQgd2Vla3Mgc3luYw0K Pg0KPiBXQVJOSU5HOiBUaGlzIGVtYWlsIG9yaWdpbmF0ZWQgZnJvbSBvdXRzaWRlIG9mIFF1YWxj b21tLiBQbGVhc2UgYmUgd2FyeSBvZiBhbnkgbGlua3Mgb3IgYXR0YWNobWVudHMsIGFuZCBkbyBu b3QgZW5hYmxlIG1hY3Jvcy4NCj4NCj4gSGkgQWxsLA0KPg0KPiBJJ2xsIGJlIG9uIGhvbGlkYXkg KG1vdmluZyBob3VzZSkgbmV4dCB3ZWVrIHNvIEkgd29uJ3QgYmUgYWJsZSB0bw0KPiBjaGFpciB0 aGUgU3RyYXRvcyBzeW5jIG1lZXRpbmcuIEFzIGl0IGlzIHRoZSBtaWRkbGUgb2Ygc3VtbWVyIEkn bQ0KPiBnb2luZyB0byBwcm9wb3NlIHdlIHNraXAgbmV4dCB3ZWVrcyBzeW5jIGFuZCByZS1jb252 ZW5lIG9uIHRoZSAzcmQgb2YNCj4gQXVndXN0LiBBbnkgb2JqZWN0aW9ucz8NCj4NCj4gV2hpbGUg b24gdGhlIHN1YmplY3Qgb2Ygc3luYyBtZWV0aW5ncyBhcmUgdGhlcmUgYW55IHRvcGljcyB0byBk aXNjdXNzLg0KPiBXZSd2ZSBoYWQgc29tZSBkaXNjdXNzaW9ucyBvbiBuZXh0IHJ1c3Qtdm1tIGRl dmljZSB0byBpbXBsZW1lbnQgYnV0DQo+IGJleW9uZCBhIHZhZ3VlICJtYXliZSB2aXJ0aW8tZ3B1 IHRvIGhlbHAgd2l0aCBkZW1vcyIgSSBkb24ndCB0aGluaw0KPiB3ZSd2ZSBuYWlsZWQgaXQgZG93 bi4gdmlydGlvLWNhbiBhbHNvIGtlZXBzIGdldHRpbmcgbWVudGlvbmVkIGFuZA0KPiB3aGlsZSB1 c2VmdWwgSSdtIHdhcnkgaXQncyBub3QgcHVzaGluZyBvdXIgZXhwbG9yYXRpb24gb2YgdGhlDQo+ IHBvc3NpYmlsaXRpZXMgb2YgdmlydGlvIGZ1cnRoZXIuDQo+DQo+IEkgZGlkIGEgdGFsayBhdCBH U1QyMiBsYXN0IHdlZWsgd2hpY2ggd2FzIGFuIG92ZXJ2aWV3IG9mIFZpcnRJTyBhbmQgd2hhdCB3 ZSBoYWQgZG9uZSBzbyBmYXIgYXMgd2VsbCBhcyBkaXNjdXNzaW5nIHNvbWUgZnV0dXJlIGRpcmVj dGlvbnMuIFlvdSBjYW4gc2VlIHRoZSB0YWxrIGF0Og0KPg0KPiAgIGh0dHBzOi8vdXJsZGVmZW5z ZS5jb20vdjMvX19odHRwczovL2h1YXdlaS1ldmVudHMuZGUvZW4vZ3N0czIyLWo4M2Rjby12b2Qu aHRtX187ISFHRl8yOWRiY1FJVUJQQSEwdWo3N1NsLWhaVmRSNjlYdUFhRExJODdrc1RrdFN6RTMt cTJ1TDcweGxSZUhfUWJrRHJqbnZkbTlmTTBFNVBlZUs1aWlzT3BRVHM5UWY3OW1Bb2hRdXNSJCBb aHVhd2VpLWV2ZW50c1suXWRlXQ0KPiAgIChEYXkgMiBzdHJlYW0sIENoYXB0ZXIgNi9UUyAwNTox MzowMCkNCj4NCj4gSW4gaXQgcG90ZW50aWFsIGZ1dHVyZSBhcmVhcyBvZiBleHBsb3JhdGlvbiB3 aGVyZToNCj4NCj4gSW1wcm92ZSBYZW4gQVBJDQo+IOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKV kOKVkOKVkOKVkOKVkOKVkOKVkA0KPg0KPiAgIOKAoiBNb3JlIHN0YW5kYXJkIG1tYXANCj4gICDi gKIgZGlyZWN0IGlycWZkL2V2ZW50ZmQgcm91dGluZw0KPg0KPiBNZW1vcnkgSXNvbGF0aW9uDQo+ IOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkA0KPg0KPiAg IOKAoiBmYXQgdmlydHF1ZXVlDQo+ICAg4oCiIGlvbW11L2dyYW50cyB2cyByZWdpb25zDQo+ICAg KHgtb3ZlciB3aXRoIHBLVk0vQ0NBPykNCj4NCj4gQmFyZSBtZXRhbCBydXN0DQo+IOKVkOKVkOKV kOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkA0KPg0KPiAgIOKAoiByZS11c2Ug ZXhpdGluZyBWaXJ0SU8gbG9naWMNCj4gICDigKIgYnV0IHdpdGhvdXQgUE9TSVggbGF5ZXINCj4N Cj4gSSdkIGxpa2UgdG8gZ2V0IGEgYmV0dGVyIHN0ZWVyIG9uIHdoYXQgd2Ugc2hvdWxkIGZvY3Vz IG9uIG5leHQgYWZ0ZXIgd2UndmUgZGVtb2VkIG91ciBleGlzdGluZyBydXN0LXZtbSBkYWVtb25z IGFuZCB0aGUgWGVuIHZob3N0LW1hc3RlciB3b3JrLg0KDQoNCi0tDQpBbGV4IEJlbm7DqWUNCg== --_000_AM9PR03MB7680EFA0E9F1BD182641CA20F48B9AM9PR03MB7680eurp_ Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBzdHlsZT0i Y29sb3I6IHJnYigzMywgMzMsIDMzKTsgYmFja2dyb3VuZC1jb2xvcjogcmdiKDI1NSwgMjU1LCAy NTUpOyIgZGlyPSJhdXRvIj4NCisgT2xla3NhbmRyIFR5c2hjaGVua28mbmJzcDs8L2Rpdj4NCjxk aXYgaWQ9Im1zLW91dGxvb2stbW9iaWxlLXNpZ25hdHVyZSIgZGlyPSJhdXRvIj4NCjxkaXY+PGJy Pg0KPC9kaXY+DQotLSBBcnRlbSZuYnNwOzwvZGl2Pg0KPGhyIHN0eWxlPSJkaXNwbGF5OmlubGlu ZS1ibG9jazt3aWR0aDo5OCUiIHRhYmluZGV4PSItMSI+DQo8ZGl2IGlkPSJkaXZScGx5RndkTXNn IiBkaXI9Imx0ciI+PGZvbnQgZmFjZT0iQ2FsaWJyaSwgc2Fucy1zZXJpZiIgc3R5bGU9ImZvbnQt c2l6ZToxMXB0IiBjb2xvcj0iIzAwMDAwMCI+PGI+RnJvbTo8L2I+IEFsZXggQmVubsOpZSAmbHQ7 YWxleC5iZW5uZWVAbGluYXJvLm9yZyZndDs8YnI+DQo8Yj5TZW50OjwvYj4gV2VkbmVzZGF5LCBK dWx5IDEzLCAyMDIyIDY6Mzk6MjMgUE08YnI+DQo8Yj5Ubzo8L2I+IFRyaWxvayBTb25pICZsdDt0 c29uaUBxdWljaW5jLmNvbSZndDs8YnI+DQo8Yj5DYzo8L2I+IFN0cmF0b3MgTWFpbGluZyBMaXN0 ICZsdDtzdHJhdG9zLWRldkBvcC1saXN0cy5saW5hcm8ub3JnJmd0OzsgVmlyZXNoIEt1bWFyICZs dDt2aXJlc2gua3VtYXJAbGluYXJvLm9yZyZndDs7IE1hdGhpZXUgUG9pcmllciAmbHQ7bWF0aGll dS5wb2lyaWVyQGxpbmFyby5vcmcmZ3Q7OyBNaWtlIEhvbG1lcyAmbHQ7bWlrZS5ob2xtZXNAbGlu YXJvLm9yZyZndDs7IEF6emVkaW5lIFRvdXpuaSAmbHQ7YXRvdXpuaUBxdGkucXVhbGNvbW0uY29t Jmd0OzsgU3RlZmFubyBTdGFiZWxsaW5pICZsdDtzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54LmNv bSZndDs7DQogQ2hyaXN0b3BoZXIgQ2xhcmsgJmx0O2NocmlzdG9waGVyLncuY2xhcmtAZ21haWwu Y29tJmd0OzsgQXJuZCBCZXJnbWFubiAmbHQ7YXJuZC5iZXJnbWFubkBsaW5hcm8ub3JnJmd0Ozsg UGV0ZXIgR3JpZmZpbiAmbHQ7cGV0ZXIuZ3JpZmZpbkBsaW5hcm8ub3JnJmd0OzsgQUtBU0hJIFRh a2FoaXJvICZsdDt0YWthaGlyby5ha2FzaGlAbGluYXJvLm9yZyZndDs7IEFydGVtIE15Z2FpZXYg Jmx0O0FydGVtX015Z2FpZXZAZXBhbS5jb20mZ3Q7OyBMZW9uYXJkbyBHYXJjaWEgJmx0O2xlb25h cmRvLmdhcmNpYUBsaW5hcm8ub3JnJmd0OzsNCiBSYW5keSBMaW5uZWxsICZsdDtyYW5keS5saW5u ZWxsQGxpbmFyby5vcmcmZ3Q7OyBkb24uaGFyYmluQGxpbmFyby5vcmcgJmx0O2Rvbi5oYXJiaW5A bGluYXJvLm9yZyZndDs7IFN1bWl0IFNlbXdhbCAmbHQ7c3VtaXQuc2Vtd2FsQGxpbmFyby5vcmcm Z3Q7OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcgJmx0O3hlbi1kZXZlbEBsaXN0cy54 ZW5wcm9qZWN0Lm9yZyZndDs7IFdlaSBMaXUgJmx0O3dsQHhlbi5vcmcmZ3Q7OyBGbG9yZXNjdSwg QW5kcmVlYSAmbHQ7ZmFuZHJlZUBhbWF6b24uY29tJmd0OzsNCiBydXN0LXZtbUBsaXN0cy5vcGVu ZGV2Lm9yZyAmbHQ7cnVzdC12bW1AbGlzdHMub3BlbmRldi5vcmcmZ3Q7PGJyPg0KPGI+U3ViamVj dDo8L2I+IEFkZCBYZW4gc3VwcG9ydCB0byB2bW0tcmVmZXJlbmNlPyAod2FzIFJlOiBDYWxsIGZv ciB0b3BpY3MgYW5kIHNraXBwaW5nIG5leHQgd2Vla3Mgc3luYyk8L2ZvbnQ+DQo8ZGl2PiZuYnNw OzwvZGl2Pg0KPC9kaXY+DQo8ZGl2IGNsYXNzPSJCb2R5RnJhZ21lbnQiPjxmb250IHNpemU9IjIi PjxzcGFuIHN0eWxlPSJmb250LXNpemU6MTFwdDsiPg0KPGRpdiBjbGFzcz0iUGxhaW5UZXh0Ij48 YnI+DQooYWRkZWQgeGVuL3J1c3Qtdm1tIHRvIENDKTxicj4NCjxicj4NClRyaWxvayBTb25pICZs dDt0c29uaUBxdWljaW5jLmNvbSZndDsgd3JpdGVzOjxicj4NCjxicj4NCiZndDsgSGVsbG8gQWxl eCw8YnI+DQomZ3Q7PGJyPg0KJmd0OyBJdCB3b3VsZCBiZSBnb29kIHRvIGNoZWNrIGlmIHRoZXJl IGlzIGEgZW5vdWdoIGludGVyZXN0IHRvIG1ha2U8YnI+DQomZ3Q7ICZxdW90O3ZtbS1yZWZlcmVu Y2UmcXVvdDsgZXh0ZW5kZWQgdG8gd29yayB3LyBUeXBlLTEgSHlwZXJ2aXNvciBsaWtlIFhlbi4g VGhpczxicj4NCiZndDsgd2lsbCBjbGVhbi11cCB2bW0tcmVmZXJlbmNlIHcvIEtWTSByZWZlcmVu Y2VzLCBhbmQgaXQgd2lsbCBiZSBhIGdvb2Q8YnI+DQomZ3Q7IGluZGVwZW5kZW50IHRvb2wgdG8g dGVzdCB0aGUgbmV3IGludGVyZmFjZXMgYWRkaXRpb25zIGluIHRoZSBydXN0LXZtbS48YnI+DQom Z3Q7PGJyPg0KJmd0OyA8YSBocmVmPSJodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6 Ly9naXRodWIuY29tL3J1c3Qtdm1tL3ZtbS1yZWZlcmVuY2VfXzshIUdGXzI5ZGJjUUlVQlBBITB1 ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZN MEU1UGVlSzVpaXNPcFFUczlRZjc5bUpXdG5KMlokIj4NCmh0dHBzOi8vdXJsZGVmZW5zZS5jb20v djMvX19odHRwczovL2dpdGh1Yi5jb20vcnVzdC12bW0vdm1tLXJlZmVyZW5jZV9fOyEhR0ZfMjlk YmNRSVVCUEEhMHVqNzdTbC1oWlZkUjY5WHVBYURMSTg3a3NUa3RTekUzLXEydUw3MHhsUmVIX1Fi a0Ryam52ZG05Zk0wRTVQZWVLNWlpc09wUVRzOVFmNzltSld0bkoyWiQ8L2E+IFtnaXRodWJbLl1j b21dPGJyPg0KPGJyPg0KV2UgaGF2ZSBjZXJ0YWlubHkgdGFsa2VkIGFib3V0IGl0IGJlZm9yZSBh bmQgdGhlIHdlJ3ZlIHB1dCBpbiBzb21lIG9mPGJyPg0KdGhlIGdyb3VuZHdvcmsgd2l0aCB0aGUg eGVuLXN5cyBjcmF0ZTxicj4NCig8YSBocmVmPSIiPjwvYT5odHRwczovL3VybGRlZmVuc2UuY29t L3YzL19faHR0cHM6Ly9naXRodWIuY29tL3J1c3Qtdm1tL3hlbi1zeXNfXzshIUdGXzI5ZGJjUUlV QlBBITB1ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpu dmRtOWZNMEU1UGVlSzVpaXNPcFFUczlRZjc5bUpSc2paelUkIFtnaXRodWJbLl1jb21dKSB3aGlj aCB3ZSBhcmUgdXNpbmcgZm9yIHRoZTxicj4NCnhlbi12aG9zdC1tYXN0ZXIgd29yay4gT2ZmIHRo ZSB0b3Agb2YgbXkgaGVhZCB3ZSB3b3VsZCBuZWVkIHRvIHdvcmsgb3V0Ojxicj4NCjxicj4NCiZu YnNwOyAtIFdoaWNoIGFkZGl0aW9uYWwgQVBJcyBuZWVkIGltcGxlbWVudGluZyBmb3IgVk1NIGxp ZmVjeWNsZSBtYW5hZ2VtZW50PGJyPg0KJm5ic3A7IC0gSG93IHRoZSBydW4gbG9vcCB3b3VsZCBs b29rPGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7IC0gQUlVSSBIeXBlci1WIG11bmdlcyB0aGlzIGZv ciBydXN0LXZtbSBieSBwcm92aWRpbmcgYSBLVk0tbGlrZTxicj4NCiZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyBpb2N0bCBBUEkgKFBPQyB2aWEgQ3Jvc1ZNOiA8YSBocmVmPSJodHRwczov L3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9naXRodWIuY29tL3BldHJ1dGx1Y2lhbjk0L2Ny b3N2bS90cmVlL3dpbmRvd3NfXzshIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1QWFE TEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFUczlR Zjc5bU5IMW1GRlckIj4NCmh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dpdGh1 Yi5jb20vcGV0cnV0bHVjaWFuOTQvY3Jvc3ZtL3RyZWUvd2luZG93c19fOyEhR0ZfMjlkYmNRSVVC UEEhMHVqNzdTbC1oWlZkUjY5WHVBYURMSTg3a3NUa3RTekUzLXEydUw3MHhsUmVIX1Fia0Ryam52 ZG05Zk0wRTVQZWVLNWlpc09wUVRzOVFmNzltTkgxbUZGVyQ8L2E+IFtnaXRodWJbLl1jb21dKTxi cj4NCiZuYnNwOyZuYnNwOyZuYnNwOyAtIFNlZSBhbHNvIDxhIGhyZWY9Imh0dHBzOi8vdXJsZGVm ZW5zZS5jb20vdjMvX19odHRwczovL2dpdGh1Yi5jb20vcnVzdC12bW0vY29tbXVuaXR5L2lzc3Vl cy8xMjFfXzshIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tzVGt0U3pF My1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFUczlRZjc5bU9FX0tnangk Ij4NCmh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dpdGh1Yi5jb20vcnVzdC12 bW0vY29tbXVuaXR5L2lzc3Vlcy8xMjFfXzshIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2 OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNP cFFUczlRZjc5bU9FX0tnangkPC9hPiBbZ2l0aHViWy5dY29tXTxicj4NCiZuYnNwOyAtIFdvdWxk IHdlIGFpbSBmb3IgZnVsbCBpbmRlcGVuZGVuY2UgZnJvbSB0aGUgZXhpdGluZyBYZW4gdXNlcnNw YWNlIGxpYnM/PGJyPg0KJm5ic3A7Jm5ic3A7Jm5ic3A7IC0geGVuLXZob3N0LW1hc3RlciB3YXMg YnJvdWdodCB1cCB1c2luZyB0aGVtLCBub3cgc2xvd2x5IGJlaW5nPGJyPg0KJm5ic3A7Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7IHJlcGxhY2VkIHdpdGggcHVyZSBydXN0PGJyPg0KPGJyPg0KSSd2 ZSBhZGRlZCBpdCBhcyBhIGRpc2N1c3Npb24gdG9waWMgZm9yIHRoZSBzeW5jIGNhbGw6PGJyPg0K PGJyPg0KJm5ic3A7IDxhIGhyZWY9Imh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczov L2NhbGVuZGFyLmdvb2dsZS5jb20vZXZlbnQ/YWN0aW9uPVRFTVBMQVRFJmFtcDt0bWVpZD1OVzgz TlhOc1oyUTFObUYwYlRFMGRHTmtNM1EwWWpGcmNUbGZNakF5TWpBNE1ETlVNVFV3TURBd1dpQmpY Mm8zYm1kcE1XODRjbXh2Wm10d1pXUTBjalZqYURrNGJYWm5RR2MmYW1wO3Rtc3JjPWNfajduZ2kx bzhybG9ma3BlZDRyNWNoOThtdmcqNDBncm91cC5jYWxlbmRhci5nb29nbGUuY29tX187SlEhIUdG XzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJl SF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFUczlRZjc5bUlBWFJwQkgkIj4NCmh0dHBzOi8v dXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2NhbGVuZGFyLmdvb2dsZS5jb20vZXZlbnQ/YWN0 aW9uPVRFTVBMQVRFJmFtcDt0bWVpZD1OVzgzTlhOc1oyUTFObUYwYlRFMGRHTmtNM1EwWWpGcmNU bGZNakF5TWpBNE1ETlVNVFV3TURBd1dpQmpYMm8zYm1kcE1XODRjbXh2Wm10d1pXUTBjalZqYURr NGJYWm5RR2MmYW1wO3Rtc3JjPWNfajduZ2kxbzhybG9ma3BlZDRyNWNoOThtdmcqNDBncm91cC5j YWxlbmRhci5nb29nbGUuY29tX187SlEhIUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1 QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFU czlRZjc5bUlBWFJwQkgkPC9hPg0KIFtjYWxlbmRhclsuXWdvb2dsZVsuXWNvbV08YnI+DQo8YnI+ DQpJdCB3b3VsZCBiZSBncmVhdCBpcyB3ZSBjb3VsZCBnZXQgYW55IGludGVyZXN0ZWQgZm9sa3Mg ZnJvbSB0aGUgcnVzdC12bW08YnI+DQphbmQgWGVuIGNvbW11bml0aWVzIHRvIGNvbWUgYWxvbmcg dG8gdGhlIGNhbGwuPGJyPg0KPGJyPg0KJmd0Ozxicj4NCiZndDsgLS0tVHJpbG9rIFNvbmk8YnI+ DQomZ3Q7PGJyPg0KJmd0OyAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLTxicj4NCiZndDsgRnJv bTogQWxleCBCZW5uw6llICZsdDthbGV4LmJlbm5lZUBsaW5hcm8ub3JnJmd0OyA8YnI+DQomZ3Q7 IFNlbnQ6IFdlZG5lc2RheSwgSnVseSAxMywgMjAyMiAyOjE2IEFNPGJyPg0KJmd0OyBUbzogU3Ry YXRvcyBNYWlsaW5nIExpc3QgJmx0O3N0cmF0b3MtZGV2QG9wLWxpc3RzLmxpbmFyby5vcmcmZ3Q7 PGJyPg0KJmd0OyBDYzogVmlyZXNoIEt1bWFyICZsdDt2aXJlc2gua3VtYXJAbGluYXJvLm9yZyZn dDs7IE1hdGhpZXUgUG9pcmllcjxicj4NCiZndDsgJmx0O21hdGhpZXUucG9pcmllckBsaW5hcm8u b3JnJmd0OzsgTWlrZSBIb2xtZXMgJmx0O21pa2UuaG9sbWVzQGxpbmFyby5vcmcmZ3Q7Ozxicj4N CiZndDsgQXp6ZWRpbmUgVG91em5pICZsdDthdG91em5pQHF0aS5xdWFsY29tbS5jb20mZ3Q7OyBT dGVmYW5vIFN0YWJlbGxpbmk8YnI+DQomZ3Q7ICZsdDtzdGVmYW5vLnN0YWJlbGxpbmlAeGlsaW54 LmNvbSZndDs7IENocmlzdG9waGVyIENsYXJrPGJyPg0KJmd0OyAmbHQ7Y2hyaXN0b3BoZXIudy5j bGFya0BnbWFpbC5jb20mZ3Q7OyBBcm5kIEJlcmdtYW5uPGJyPg0KJmd0OyAmbHQ7YXJuZC5iZXJn bWFubkBsaW5hcm8ub3JnJmd0OzsgUGV0ZXIgR3JpZmZpbiAmbHQ7cGV0ZXIuZ3JpZmZpbkBsaW5h cm8ub3JnJmd0Ozs8YnI+DQomZ3Q7IEFLQVNISSBUYWthaGlybyAmbHQ7dGFrYWhpcm8uYWthc2hp QGxpbmFyby5vcmcmZ3Q7OyBBcnRlbSBNeWdhaWV2PGJyPg0KJmd0OyAmbHQ7QXJ0ZW1fTXlnYWll dkBlcGFtLmNvbSZndDs7IExlb25hcmRvIEdhcmNpYTxicj4NCiZndDsgJmx0O2xlb25hcmRvLmdh cmNpYUBsaW5hcm8ub3JnJmd0OzsgVHJpbG9rIFNvbmkgJmx0O3Rzb25pQHF1aWNpbmMuY29tJmd0 OzsgUmFuZHk8YnI+DQomZ3Q7IExpbm5lbGwgJmx0O3JhbmR5Lmxpbm5lbGxAbGluYXJvLm9yZyZn dDs7IGRvbi5oYXJiaW5AbGluYXJvLm9yZzsgU3VtaXQ8YnI+DQomZ3Q7IFNlbXdhbCAmbHQ7c3Vt aXQuc2Vtd2FsQGxpbmFyby5vcmcmZ3Q7PGJyPg0KJmd0OyBTdWJqZWN0OiBDYWxsIGZvciB0b3Bp Y3MgYW5kIHNraXBwaW5nIG5leHQgd2Vla3Mgc3luYzxicj4NCiZndDs8YnI+DQomZ3Q7IFdBUk5J Tkc6IFRoaXMgZW1haWwgb3JpZ2luYXRlZCBmcm9tIG91dHNpZGUgb2YgUXVhbGNvbW0uIFBsZWFz ZSBiZSB3YXJ5IG9mIGFueSBsaW5rcyBvciBhdHRhY2htZW50cywgYW5kIGRvIG5vdCBlbmFibGUg bWFjcm9zLjxicj4NCiZndDs8YnI+DQomZ3Q7IEhpIEFsbCw8YnI+DQomZ3Q7PGJyPg0KJmd0OyBJ J2xsIGJlIG9uIGhvbGlkYXkgKG1vdmluZyBob3VzZSkgbmV4dCB3ZWVrIHNvIEkgd29uJ3QgYmUg YWJsZSB0bzxicj4NCiZndDsgY2hhaXIgdGhlIFN0cmF0b3Mgc3luYyBtZWV0aW5nLiBBcyBpdCBp cyB0aGUgbWlkZGxlIG9mIHN1bW1lciBJJ208YnI+DQomZ3Q7IGdvaW5nIHRvIHByb3Bvc2Ugd2Ug c2tpcCBuZXh0IHdlZWtzIHN5bmMgYW5kIHJlLWNvbnZlbmUgb24gdGhlIDNyZCBvZjxicj4NCiZn dDsgQXVndXN0LiBBbnkgb2JqZWN0aW9ucz88YnI+DQomZ3Q7PGJyPg0KJmd0OyBXaGlsZSBvbiB0 aGUgc3ViamVjdCBvZiBzeW5jIG1lZXRpbmdzIGFyZSB0aGVyZSBhbnkgdG9waWNzIHRvIGRpc2N1 c3MuPGJyPg0KJmd0OyBXZSd2ZSBoYWQgc29tZSBkaXNjdXNzaW9ucyBvbiBuZXh0IHJ1c3Qtdm1t IGRldmljZSB0byBpbXBsZW1lbnQgYnV0PGJyPg0KJmd0OyBiZXlvbmQgYSB2YWd1ZSAmcXVvdDtt YXliZSB2aXJ0aW8tZ3B1IHRvIGhlbHAgd2l0aCBkZW1vcyZxdW90OyBJIGRvbid0IHRoaW5rPGJy Pg0KJmd0OyB3ZSd2ZSBuYWlsZWQgaXQgZG93bi4gdmlydGlvLWNhbiBhbHNvIGtlZXBzIGdldHRp bmcgbWVudGlvbmVkIGFuZDxicj4NCiZndDsgd2hpbGUgdXNlZnVsIEknbSB3YXJ5IGl0J3Mgbm90 IHB1c2hpbmcgb3VyIGV4cGxvcmF0aW9uIG9mIHRoZTxicj4NCiZndDsgcG9zc2liaWxpdGllcyBv ZiB2aXJ0aW8gZnVydGhlci48YnI+DQomZ3Q7PGJyPg0KJmd0OyBJIGRpZCBhIHRhbGsgYXQgR1NU MjIgbGFzdCB3ZWVrIHdoaWNoIHdhcyBhbiBvdmVydmlldyBvZiBWaXJ0SU8gYW5kIHdoYXQgd2Ug aGFkIGRvbmUgc28gZmFyIGFzIHdlbGwgYXMgZGlzY3Vzc2luZyBzb21lIGZ1dHVyZSBkaXJlY3Rp b25zLiBZb3UgY2FuIHNlZSB0aGUgdGFsayBhdDo8YnI+DQomZ3Q7PGJyPg0KJmd0OyZuYnNwOyZu YnNwOyA8YSBocmVmPSJodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9odWF3ZWkt ZXZlbnRzLmRlL2VuL2dzdHMyMi1qODNkY28tdm9kLmh0bV9fOyEhR0ZfMjlkYmNRSVVCUEEhMHVq NzdTbC1oWlZkUjY5WHVBYURMSTg3a3NUa3RTekUzLXEydUw3MHhsUmVIX1Fia0Ryam52ZG05Zk0w RTVQZWVLNWlpc09wUVRzOVFmNzltQW9oUXVzUiQiPg0KaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92 My9fX2h0dHBzOi8vaHVhd2VpLWV2ZW50cy5kZS9lbi9nc3RzMjItajgzZGNvLXZvZC5odG1fXzsh IUdGXzI5ZGJjUUlVQlBBITB1ajc3U2wtaFpWZFI2OVh1QWFETEk4N2tzVGt0U3pFMy1xMnVMNzB4 bFJlSF9RYmtEcmpudmRtOWZNMEU1UGVlSzVpaXNPcFFUczlRZjc5bUFvaFF1c1IkPC9hPiBbaHVh d2VpLWV2ZW50c1suXWRlXTxicj4NCiZndDsmbmJzcDsmbmJzcDsgKERheSAyIHN0cmVhbSwgQ2hh cHRlciA2L1RTIDA1OjEzOjAwKTxicj4NCiZndDs8YnI+DQomZ3Q7IEluIGl0IHBvdGVudGlhbCBm dXR1cmUgYXJlYXMgb2YgZXhwbG9yYXRpb24gd2hlcmU6PGJyPg0KJmd0Ozxicj4NCiZndDsgSW1w cm92ZSBYZW4gQVBJPGJyPg0KJmd0OyDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDi lZDilZDilZDilZA8YnI+DQomZ3Q7PGJyPg0KJmd0OyZuYnNwOyZuYnNwOyDigKIgTW9yZSBzdGFu ZGFyZCBtbWFwPGJyPg0KJmd0OyZuYnNwOyZuYnNwOyDigKIgZGlyZWN0IGlycWZkL2V2ZW50ZmQg cm91dGluZzxicj4NCiZndDs8YnI+DQomZ3Q7IE1lbW9yeSBJc29sYXRpb248YnI+DQomZ3Q7IOKV kOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkOKVkDxicj4NCiZndDs8 YnI+DQomZ3Q7Jm5ic3A7Jm5ic3A7IOKAoiBmYXQgdmlydHF1ZXVlPGJyPg0KJmd0OyZuYnNwOyZu YnNwOyDigKIgaW9tbXUvZ3JhbnRzIHZzIHJlZ2lvbnM8YnI+DQomZ3Q7Jm5ic3A7Jm5ic3A7ICh4 LW92ZXIgd2l0aCBwS1ZNL0NDQT8pPGJyPg0KJmd0Ozxicj4NCiZndDsgQmFyZSBtZXRhbCBydXN0 PGJyPg0KJmd0OyDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZDilZA8 YnI+DQomZ3Q7PGJyPg0KJmd0OyZuYnNwOyZuYnNwOyDigKIgcmUtdXNlIGV4aXRpbmcgVmlydElP IGxvZ2ljPGJyPg0KJmd0OyZuYnNwOyZuYnNwOyDigKIgYnV0IHdpdGhvdXQgUE9TSVggbGF5ZXI8 YnI+DQomZ3Q7PGJyPg0KJmd0OyBJJ2QgbGlrZSB0byBnZXQgYSBiZXR0ZXIgc3RlZXIgb24gd2hh dCB3ZSBzaG91bGQgZm9jdXMgb24gbmV4dCBhZnRlciB3ZSd2ZSBkZW1vZWQgb3VyIGV4aXN0aW5n IHJ1c3Qtdm1tIGRhZW1vbnMgYW5kIHRoZSBYZW4gdmhvc3QtbWFzdGVyIHdvcmsuPGJyPg0KPGJy Pg0KPGJyPg0KLS0gPGJyPg0KQWxleCBCZW5uw6llPGJyPg0KPC9kaXY+DQo8L3NwYW4+PC9mb250 PjwvZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg0K --_000_AM9PR03MB7680EFA0E9F1BD182641CA20F48B9AM9PR03MB7680eurp_-- From xen-devel-bounces@lists.xenproject.org Fri Jul 15 11:05:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 11:05:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368138.599331 (Exim 4.92) (envelope-from ) id 1oCJ84-0003i2-NT; Fri, 15 Jul 2022 11:05:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368138.599331; Fri, 15 Jul 2022 11:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCJ84-0003hv-KH; Fri, 15 Jul 2022 11:05:04 +0000 Received: by outflank-mailman (input) for mailman id 368138; Fri, 15 Jul 2022 11:05:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCJ83-0003hp-KE for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 11:05:03 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7cfc30d-042d-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 13:05:01 +0200 (CEST) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 07:04:58 -0400 Received: from BN7PR03MB3618.namprd03.prod.outlook.com (2603:10b6:406:c3::27) by SA2PR03MB5721.namprd03.prod.outlook.com (2603:10b6:806:117::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.20; Fri, 15 Jul 2022 11:04:56 +0000 Received: from BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b]) by BN7PR03MB3618.namprd03.prod.outlook.com ([fe80::ec74:68a1:2448:721b%6]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 11:04:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7cfc30d-042d-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657883101; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eiZL8Jhc13u9kBT840U8XZEo9UKoSJkaebqVB5hSbr0=; b=KkRrcPF7GkIEbvdnI05qzj+y3BoUZ23sRyj7SqEEHzg+Q0fb/R+NkS1L oPBPQecYPHDaq5tiuzoiY7brQMWyFZE3gKySgqQd3fQnuDfmVrIUch5Jx kAy0RoJRT6BSOmA6UXZKLEpxnvaZXAqY2TdbiDKLYdMOGUR9Yc6m8ztXP Y=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 76303260 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:GBbjZ6kfunNfwn140U9WPDzo5gx+J0RdPkR7XQ2eYbSJt1+Wr1Gzt xJNDWCGOazfZGqkL4oka4i+oR9Qu8eEzN5lSwJlqHs3RSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462v4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kqZtVG37hcLV1K5 MI/FhosTk+p2euflefTpulE3qzPLeHNFaZG4zRL6micCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAG7gvK/8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSz33rSVw3uTtIQ6K73i5NMyp3moxDYSK143Xn3g+t6ghRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4N/Ax4Uejw6zf7gKdG0ANVDsHY9sj3OczTCAq1 1KU2c/gHyZmtJWNU3WB8bGRpDK2fyMSKAcqZzIATAYDy8nupsc0lB2nZs14DKe/g9nxGDfx6 zOHti4zg/MUl8Fj/7q/1UDKhXSrvJehZh444EDbU3yo6it9ZZW5fMq45F7D9/FCIY2FCF6bs xA5d9O26ekPCdSGk3WLSeBURbWxva/aanvbnEJlGIQn+3K14Xm/cItM4TZ4YkB0LsIDfjyva 0jW0e9M2KJu0LKRRfcfS+qM5w4ClMAMyfyNuijoU+dz IronPort-HdrOrdr: A9a23:KJARv6/k3Ot84SQOccBuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.92,273,1650945600"; d="scan'208";a="76303260" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IcFKJWxpPoQN3EYJWvFlWjXvvh91aR/qRAMd4lu3k2iWKvixgFinTaKz3hiH16z1O95jsHvXQIdu+Y2mIsqs7bdPjjaxL9GnQtjjBy2bvjRg4OjyFrDdR1iO1Dj3PmafHvA22ApZP9bxorXWBAnC0jLZdJXKh3b7/fdwDlJVyVP4QYobh1caSkqF+EzCByxqIh7pzLRyNT+2CFRC6d84daOWkpUHX0rCv2SbqWr3JUImjQaGoFYtgWhEvm0MKRKk1YLAwscZmgZJbD6TfQi/25DOIEHcqdU878BWMlFtN8WNpBPOWP+nPzcLqHyokFqnkfAA7/hDGFrBOhhTaRPlHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eiZL8Jhc13u9kBT840U8XZEo9UKoSJkaebqVB5hSbr0=; b=c8HL5GF9qfwOz4uZn3WJy/7+AMLqB0Qkbd0iqfW8KBTAqn/HxLcKP9sZpkLWB+/psbAnRZcxhXx2vkpwCA5o8aegiFoqubswoHBnhZOscoO8soPKp0bNzQMsSbQBST3tDIsBcaTCYyoO/R9mXPy7D0sPBFYo8Rz4rDTaCRR7dU79pRWAAB4kp6JpC6mAFuNzu8a5IuPBhjHxeTajgb27h0vKRPupizNj/FMCqo8mFYjZNmx+NOsOwnzsyW/gnb7lUtC7zxVqq1ykzXGk8srDVVacSi2mNlGzWzREiwdlKX6fTlbx+3IRjwCb+KLVgyQ2a1GjctBDVi9Z1BOs2q/fKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eiZL8Jhc13u9kBT840U8XZEo9UKoSJkaebqVB5hSbr0=; b=dccVkEtVLB7zz5CroP4pOndqnFJ8fPk+y5oRujJ574CWWKnHpqypBql0cNlvF1joofKG/85BwPQlT/yWdZ6horaKF3Q6BEERTkDPdytffVjxnFBD7zwAsEekfFmBk9pAMz5g0nC2u9xfoMJOH+9Aoy5ltZJpK8fNm3NvZc8Los8= From: Andrew Cooper To: Jan Beulich CC: Luca Fancellu , Mathieu Tarral , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" , Anthony Perard Subject: Re: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Topic: [XEN PATCH 1/2] xen: Fix check-endbr with mawk Thread-Index: AQHYl4+Dg7FHxwiGFEGkNOu8rM/Cw61/OECAgAAIBYCAAAJngIAAA6MA Date: Fri, 15 Jul 2022 11:04:56 +0000 Message-ID: <2bba36f5-5da1-c685-cd49-fec253e97ca7@citrix.com> References: <20220714143907.25938-1-anthony.perard@citrix.com> <20220714143907.25938-2-anthony.perard@citrix.com> <41ea1e23-83fd-d4ef-c279-fad7f5611a43@suse.com> In-Reply-To: <41ea1e23-83fd-d4ef-c279-fad7f5611a43@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d1a1b895-3ed2-45c5-cbef-08da6651da2a x-ms-traffictypediagnostic: SA2PR03MB5721:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: f5p5iITkjpkopP/Sq58pKaQujdToOrSG616TEgmMkreu4jPa5rZvFuIPt9MDGQvhQzEnLEr+pkSJOVoeLN2BCMoZd1Id6ic0lFQW5r0X0/qZ9/ELqpLEkj0B3qmeuKRvoG327nYNYkMkQvnf38NLbDVjlDrA3jNq8QSbwdAIamyXLzGxUi/NHX1ulO9sRzrjrSjgzDb+d4FP8B6zyRMhsfmWWfnlo/QWsDMTcJxqn0QoCYh0FvrgGdNQWwut7BIz4LPL5sHm+3YFZycqlcJ2Fre8cNoGA16BYPcDZtSWBz1HCR1NI792VkOYu3HE9QXtQG2bPRstVZZaW978RLSAObBsYr8tSrzeQHS0qq4KyfE7KGSQ+Hpngo5vSRyQavWAbHjcjEjVsFUcomfuDindDSHJNg5UuXN41ErX533hrhQoNFgkmfM51OKPG+Jr8bFYOjGCHX8t07C4kzGlYAg3iO+4vKDeesS4YG+SKZN2IGhl7hvBtWLxxD/P8FKo5HsRoxKE7G55PW49ghTGt/jO6k0ht+BTThlkKnWWNedO6ZXWfup3e165ob1ejZBFZ5ghhboQmeYb7NtSo4tkECzLF7b3S4ZZS9izTNXNnMpkCL8jX+JlBOGB2vjsuar+ntfrG/yQ5AMOfXdnOw2GgQrTygWwI+5Cvn2pp8obCTaiatiSuN1Hg3ydPUwYyk+RzDX+7DwdTbfOqFr73jw2iFzZspgy79Ztt61+SB7yMEwtlOQe09F3HWZsc8Im0tIyNjBY6WYlCtRF6nH34EFkpDiWIim7+3iH+dTRwuGxTujXgVVPRfQWk6WyFRj3jktOtXUke3jJNy9XzErytuunL0sMBKUgoRdG+rf478RYzJ9EQDdCFy7GiA16qnQXxkIw/Cxt x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN7PR03MB3618.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(366004)(346002)(39860400002)(71200400001)(186003)(38100700002)(66446008)(38070700005)(122000001)(83380400001)(54906003)(66946007)(6916009)(31686004)(64756008)(53546011)(36756003)(66556008)(91956017)(4326008)(316002)(82960400001)(8676002)(66476007)(107886003)(6486002)(6512007)(86362001)(478600001)(2616005)(6506007)(8936002)(5660300002)(31696002)(41300700001)(2906002)(76116006)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MmtFOVhPS290ZGwwQTJDVEU3ZjAzcjB5Uk81TldMaEtOVDZDenNjY1RETnhQ?= =?utf-8?B?bFRIb0VyRGJDMXdiRU1HYjNwekFKdmZpeXMxaGUwd3lFMnFPT0NTd2s4NWgv?= =?utf-8?B?cm5KV2hiejdyaEpLRDRuVmlvc2NtMDNnTzhSQWg1ZVVNd05lajJvRlhlMGZL?= =?utf-8?B?NjNaeDBiejhvZXNEREg0M2pRYWlFY3FWUzRNc0dZa3BGQ2w0WG5KeFMwZTVL?= =?utf-8?B?RG9EdDRRQUV0RWlVNUJqTjNYZnNPL2JZTzVLalE3MkFOK3lTUGUvaFh4RVpQ?= =?utf-8?B?cFdNT3dUbGZCSHBhclpmdXdUTis3RWorbmNIaTJmTnhhYTFId3cySllyd0pY?= =?utf-8?B?cWs2NnVRdjU2aURzVWlHZGJqNEJBRXFvWVVXU0ladHRaRk9BZFJoWUVhWmZ0?= =?utf-8?B?cEpKU3YySmdpMHhqL0EwcDB6S3BnTmkvRUZ3bEVPMHp2WkpTZjY1TUJra3Nw?= =?utf-8?B?RnpoRC8wOFBDVmJKTTA2S2puVTVXb0V2Rkd2NVBLVGdsVlE1VEk0OGpiZEhp?= =?utf-8?B?aFVhQWtSNEJ5bU1xVWo0RnFReDdOVWcvOU9SeFBJMVVJaS9YNmptN0RXcjd1?= =?utf-8?B?VDcvZm90QUVHL2swYnlBUUZmcHpaeXlpK3YrYlhhT2NxUUJ6cjJUbkNqemlp?= =?utf-8?B?RUpMTG1uVzBzemZ4UUdyYTZObTFlRXEvQkJ4Q2NNLzU2QlJoMGN5WmNsaFVI?= =?utf-8?B?alhEWmtTTGx6R3lVV0p1NFUzbVQxTVZ6VDE2cTJSRUR2WWtRSCtnanRFOUo4?= =?utf-8?B?b0tjQkxKQ0NxVU0vcm1oNGk0bys1NlZRYjRZb0lSb2RkbDFqME50MjhrTFlB?= =?utf-8?B?RkcwRlQreE8yOUJDV2VPQ3lBNm8wZG5iUVlHRzRUMFNwb0FJYWlmV2FENlFX?= =?utf-8?B?Wk02L1VxSXB4RURpaWxLbnBmMFNkV1BjbmhwaEFLc09xckJ3bS9aYldmL0Zp?= =?utf-8?B?ODM1dE9RQUFMb3g5UlcxSXZWOG5QVE1EUmpFYzY4RlFTVDQxaWNNbGUzRjRw?= =?utf-8?B?RHlzUjlyV3pEMWxweHpnK3ljdVdkZFAzVzBPSkxNN1czdWV2eWI3bWtCd3Bz?= =?utf-8?B?RTBwKzVxbmx4dXdOcjZFWFFWQnNTVWg4ekRPaDYyU0U0eHM0TDhiZjIzV1Z2?= =?utf-8?B?QzZOUU9KRjlUeWdIWWg4NFFHR01nVFlBcnhXSllEd1hjdDRNQmFMSmlHQnh4?= =?utf-8?B?SFZqQ0RnRnZzYW5MdzVsN3orWGphU0E0YVMwMll2aDZTWTlCNm5EQzFPeW9Z?= =?utf-8?B?MERqM1NVUDNYNGp6VlFOQUc4SVpodTkrNzVFQWZ2WUwzek9sejluNzhReldQ?= =?utf-8?B?TDdTZlJlaDFNQ2QzaGlZSmkvYVFqYWNnMEcybHA1b1lXM3lQNitIUmFNc2NW?= =?utf-8?B?bm1GTUlvV2pQR1ZGejZYczdNTXIrazNjbllpMDdBZFQ0eDEwOWtETFZyVU5j?= =?utf-8?B?eHlnd05qd2cyY1lhQit4QXZJWEd3SXJDdWY3dEd1U2N1ZWc3dEZ3K0lwazVn?= =?utf-8?B?V0hYRXBUeGVLVnNyaHZTTmxTYWFTL29FdWpnakp0czJJY21hbEtvbkFhUGpa?= =?utf-8?B?VlRjTDlLMXIvd29Xc3J3N1drYlN4YmRldk1QRGM1WTRIbUdCTXlXTGFvWCtU?= =?utf-8?B?M2psazA0SFRmOWpvWmc2VnZBUUxTZTAwUSt3VzduQ3BNbmg0MmJvUkc0cE84?= =?utf-8?B?TUphQ0VaTy9yb2ZrMkpFZXBXbk4xbTZNRGdlMmUzeFk0YVFWQ3pLanBrZ01j?= =?utf-8?B?QTIyUmJEN1Y1bmJQa0d3MEhHM1ZqbGNsNDJrWlltTVI1N213WXNOY2QyTXl3?= =?utf-8?B?QjN5WHBOWGVoVnZaQU5PVEtVekJBYXF4ekdlUmNZOXlxWTcxbmx1Mnh0TG1k?= =?utf-8?B?MStwK29WV1FCY2hRNVg2Nm51eGRkMkR1SFQ3WGtvMnYyZHlyTVUydHhnWGN2?= =?utf-8?B?TFJIcWROc0FYZVF2Y2NDbC9wY2x4WUtUOE5hSzRlN0grRERmNllLa2RtQ0VM?= =?utf-8?B?UTFKQkJORi9LWVVoeDd3dUJtU2FMZmhjeVlYaCtQb1luMHBKZm1KWXVBUERK?= =?utf-8?B?emdyN01xL2tkdzFYZmRPUy82a1BIR1JtM3BuVGVIQkRRMEVrajl6TGVjT0VD?= =?utf-8?Q?M6BF6F98bd7BRYNCnRhVb0DW7?= Content-Type: text/plain; charset="utf-8" Content-ID: <9838B3BE6AB9EA489DF7D8F0610972A7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB3618.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d1a1b895-3ed2-45c5-cbef-08da6651da2a X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 11:04:56.4499 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lufKE+qhskFD65s4iKl4Op0cvOdfg0qzAhEsR3nhmUSfl2qCC49pXVyxt2rYJ0PVeTchUWWOc5VbYHd2sQbFnqWQEaeCcflep6OKvcNuB3Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5721 T24gMTUvMDcvMjAyMiAxMTo1MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE1LjA3LjIwMjIg MTI6NDMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNS8wNy8yMDIyIDExOjE0LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNC4wNy4yMDIyIDE2OjM5LCBBbnRob255IFBFUkFSRCB3 cm90ZToNCj4+Pj4gLS0tIGEveGVuL3Rvb2xzL2NoZWNrLWVuZGJyLnNoDQo+Pj4+ICsrKyBiL3hl bi90b29scy9jaGVjay1lbmRici5zaA0KPj4+PiBAQCAtNzgsNyArNzgsNyBAQCB0aGVuDQo+Pj4+ ICBlbHNlDQo+Pj4+ICAgICAgZ3JlcCAtYW9iIC1lICIkKHByaW50ZiAnXDM2M1wxN1wzNlwzNzIn KSIgLWUgIiQocHJpbnRmICdcMzYzXDE3XDM2XDM3MycpIiBcDQo+Pj4+ICAgICAgICAgICAtZSAi JChwcmludGYgJ1wxNDZcMTdcMzdcMScpIiAkVEVYVF9CSU4NCj4+Pj4gLWZpIHwgYXdrIC1GJzon ICd7cHJpbnRmICIlcyV4XG4iLCAiJyR2bWFfaGknIiwgaW50KDB4JyR2bWFfbG8nKSArICQxfScg PiAkQUxMDQo+Pj4+ICtmaSB8IGF3ayAtRic6JyAne3ByaW50ZiAiJXMleFxuIiwgIickdm1hX2hp JyIsIGludCgnJCgoMHgkdm1hX2xvKSknKSArICQxfScgPiAkQUxMDQo+Pj4gSSdtIGFmcmFpZCB0 aGF0J3Mgbm90IHBvcnRhYmxlIHRvIGVudmlyb25tZW50cyB3aGVyZSBzaXplb2YobG9uZykgPCA4 Lg0KPj4+IFRoZSBzaGVsbCBpc24ndCByZXF1aXJlZCB0byB1c2Ugd2lkZXIgdGhhbiBsb25nIGZv ciB0aGUgZXZhbHVhdGlvbi4NCj4+IFl1Y2suwqAgVGhpcyB3b3JrcyBhdCB0aGUgbW9tZW50IGlu IDMyIGJpdCBidWlsZHMgYmVjYXVzZToNCj4+DQo+PiArKyBvYmpkdW1wIC1qIC50ZXh0IHhlbi1z eW1zIC1oDQo+PiArKyBhd2sgJyQyID09ICIudGV4dCIge3ByaW50ZiAidm1hX2hpPSVzXG52bWFf bG89JXNcbiIsIHN1YnN0cigkNCwgMSwNCj4+IDgpLCBzdWJzdHIoJDQsIDksIDE2KX0nDQo+PiAr IGV2YWwgdm1hX2hpPWZmZmY4MmQwIHZtYV9sbz00MDIwMDAwMA0KPj4gKysgdm1hX2hpPWZmZmY4 MmQwDQo+PiArKyB2bWFfbG89NDAyMDAwMDANCj4+DQo+PiBzbyB0aGUgdG9wIGJpdCBpc24ndCBz ZXQuDQo+Pg0KPj4gQW5kIGdvaW5nIGZyb20gYW4gOC84IHNwbGl0IHRvIGEgOS83IHNwbGl0IGRv ZXNuJ3Qgd29yayBlaXRoZXIgYmVjYXVzZQ0KPj4gdGhhdCB1c2VzIDQgYml0cyBhbmQgd2UndmUg b25seSBnb3QgMiB0byBwbGF5IHdpdGggZ2l2ZW4gLnRleHQncyAxRw0KPj4gYWxpZ25tZW50Lg0K PiBXaHkgZG9lcyB0ZXh0IGFsaWdubWVudCBtYXR0ZXIgaGVyZT8gQWxsIHdlIGNhcmUgYWJvdXQg YXJlIG9mZnNldHMNCj4gaW50byB0aGUgWGVuIGltYWdlLiBBbiBJIGd1ZXNzIHdlIGFyZW4ndCBy ZWFsbHkgYXQgcmlzayBvZiBnb2luZw0KPiBiZXlvbmQgMjU2TSBpbiBpbWFnZSBzaXplIC4uLg0K DQpWZXJ5IGdvb2QgcG9pbnQsIGJ1dCBpdCdzIG5vdCBldmVuIHRoZSBpbWFnZSBzaXplLsKgIEl0 J3Mgb25seSAudGV4dC4NCg0KRnVydGhlcm1vcmUsIHdlIGNhbiBoYXZlIHRoZSBzYWZldHkgY2hl Y2sgZm9yIHRoYXQgaW4gdGhpcyBzY3JpcHQgdG9vLg0KDQpMZW1tZSBzZWUgd2hhdCBJIGNhbiBk by4NCg0KPj4gSSBrbm93IGl0J3MgZGlzZ3VzdGluZywgYnV0IGhvdyBhYm91dCBhIEJVSUxEX0JV R19PTihYRU5fVklSVF9TVEFSVCAmDQo+PiAoMXUgPDwgMzEpKSA/DQo+IEluIHRoZSB3b3JzdCBj YXNlLCB3aHkgbm90LiBCdXQgdGhhdCB3b3VsZCBiZSBhbiBvZGQgcmVzdHJpY3Rpb24gb24NCj4g Y2hhbmdlcyB0byB0aGUgbWVtb3J5IGxheW91dCAod2hpY2ggd2UndmUgZG9uZSBpbiB0aGUgcGFz dCkuDQoNCkkgZGlkIHNheSBkaXNndXN0aW5nLi4uwqAgSSdtIGVudGlyZWx5IGhhcHB5IHRoYXQg aXQgZG9lc24ndCBhcHBlYXIgdG8gYmUNCm5lZWRlZC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Fri Jul 15 12:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 12:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368186.599367 (Exim 4.92) (envelope-from ) id 1oCK3B-0004Ol-Tt; Fri, 15 Jul 2022 12:04:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368186.599367; Fri, 15 Jul 2022 12:04:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCK3B-0004Oe-RL; Fri, 15 Jul 2022 12:04:05 +0000 Received: by outflank-mailman (input) for mailman id 368186; Fri, 15 Jul 2022 12:04:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCK3B-0004OU-8O; Fri, 15 Jul 2022 12:04:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCK3B-0003pR-5k; Fri, 15 Jul 2022 12:04:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCK3A-0003QL-RJ; Fri, 15 Jul 2022 12:04:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCK3A-0000Bo-Qn; Fri, 15 Jul 2022 12:04:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C0+k+yUpJMO6fF3fIR3HMDGQG/lQXnqWGY+6WHAsTo8=; b=Ng2bo57E3+/sbqb+u647S9OEDn Mif3BnVLngJ4ybbomvExi9DXzt/Lc2yPbfhhVpw5TNvyB+noJ/iAhTbwC5+KsrahXnmdr+BR/0wZm jkWB5RQN0Gx0f4te6A9WRKZilPeU4emU+Lc4/YZPTUtFmXg0eGt86TLfK54rCZUejhIc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171638: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f02a579b6127de6adc373031ecd2434d2e97e557 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 15 Jul 2022 12:04:04 +0000 flight 171638 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171638/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt f02a579b6127de6adc373031ecd2434d2e97e557 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 735 days Failing since 151818 2020-07-11 04:18:52 Z 734 days 716 attempts Testing same since 171638 2022-07-15 04:20:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 115976 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 15 12:05:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 12:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368181.599379 (Exim 4.92) (envelope-from ) id 1oCK4R-0004uQ-9D; Fri, 15 Jul 2022 12:05:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368181.599379; Fri, 15 Jul 2022 12:05:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCK4R-0004uJ-64; Fri, 15 Jul 2022 12:05:23 +0000 Received: by outflank-mailman (input) for mailman id 368181; Fri, 15 Jul 2022 12:00:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCJzc-0004Bg-59 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 12:00:24 +0000 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [2001:4860:4864:20::2c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b445c550-0435-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 14:00:23 +0200 (CEST) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-10c0e6dd55eso5918227fac.7 for ; Fri, 15 Jul 2022 05:00:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b445c550-0435-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1AogFaIBNHLVxEl9g85HNQ6PNSYsmdEqrn/tB/pzrJs=; b=jX9Pf/0Ic5b/hkcNqf4c0vxLpp+ecwFm2Q8sd59jXQROio8GyzjPDi4d625IOJ16Tk Krn01+q7K+Z7V/uKcP98EzRgnuKWNqOTpqePd6QuX4+fc1fzFQ+cb3409JxLjnM3dddM RKj4krs/9XThI5DE+eHSyYCvnx3Zhq56PJIy2aA7bsQmufenm13s+0yN5fBtr8zRihcY gxb26CaMzz8ZmNTL6D/PysbMrPZ3xtQ8eUjj6ykzUk+Zyyw2cr57b6q79GazkAUn3+5E azX4wjlBG+m/o4u4++kh9s9fvtlLQEQFbVxEzvqNFKkn23kCnQJAB7dG7sajJCZVp0NJ QbCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1AogFaIBNHLVxEl9g85HNQ6PNSYsmdEqrn/tB/pzrJs=; b=Ju+ibDEPciBp5pCCwxy4neNgHAED/U4eseC9wGBLJHUMYEuZuU8fzuquWfQFKJDv/3 3v1PuJ74nwjkxYthKhTbGMyMGhYSgZNUNE9XvPZk8dA+0G2QUVuLF+ipnbAKFcmXq0IG 7UEADjBi4GZwHMsBU3Wm+bMJqZ5tR+gMmRhbnc3u0OZ8TkijaYq5z9FWW8wC5SgNI0K1 lCgfGNxBBC8uECeVBFAa9WnQOsDPxipBPDKqNflAlZuYI2+8/JOY3AP0mMwv36FHf9v5 Rt5KIMwIgUocCshmM7HblKtA8ujRn8T3dfmakwd/sK/m17K0FpwYAjh41u5fmFcEEBF1 db9A== X-Gm-Message-State: AJIora+PyTK2QEy6ULgN1Vva/3Jk/r8lHZc0SDtNLFlsArsVPzpg945A KXimPSBUJH/URupUARhqVtssv77yAszYPPYkzxM= X-Google-Smtp-Source: AGRyM1sVxfePi8rAk/gHeLL7GDiWUlgVMPRpqnyNhU5VBUmUNQmMziBE0Mt7b+vBBuJTGTDRSPVtGVwl86bQo4TspMk= X-Received: by 2002:a05:6870:d610:b0:10c:692:668a with SMTP id a16-20020a056870d61000b0010c0692668amr7067435oaq.86.1657886421671; Fri, 15 Jul 2022 05:00:21 -0700 (PDT) MIME-Version: 1.0 References: <20220714224410.51147-1-sj@kernel.org> <41207539-f621-1bb2-2f43-0b2b9e3f6866@gmail.com> In-Reply-To: <41207539-f621-1bb2-2f43-0b2b9e3f6866@gmail.com> From: Andrii Chepurnyi Date: Fri, 15 Jul 2022 15:00:10 +0300 Message-ID: Subject: Re: [PATCH v2] xen-blkback: fix persistent grants negotiation To: Oleksandr Cc: SeongJae Park , roger.pau@citrix.com, jgross@suse.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: multipart/alternative; boundary="0000000000003de32205e3d6c364" --0000000000003de32205e3d6c364 Content-Type: text/plain; charset="UTF-8" Hello All, I faced the mentioned issue recently and just to bring more context here is our setup: We use pvblock backend for Android guest. It starts using u-boot with pvblock support(which frontend doesn't support the persistent grants feature), later it loads and starts the Linux kernel(which frontend supports the persistent grants feature). So in total, we have sequent two different frontends reconnection, the first of which doesn't support persistent grants. So the original patch [1] perfectly solves the original issue and provides the ability to use persistent grants after the reconnection when Linux frontend which supports persistent grants comes into play. At the same time [2] will disable the persistent grants feature for the first and second frontend. Is it possible to keep [1] as is? [1] https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/ [2] https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/ Best regards, Andrii On Fri, Jul 15, 2022 at 1:15 PM Oleksandr wrote: > > On 15.07.22 01:44, SeongJae Park wrote: > > > Hello all. > > Adding Andrii Chepurnyi to CC who have played with the use-case which > required reconnect recently and faced some issues with > feature_persistent handling. > > > > > > Persistent grants feature can be used only when both backend and the > > frontend supports the feature. The feature was always supported by > > 'blkback', but commit aac8a70db24b ("xen-blkback: add a parameter for > > disabling of persistent grants") has introduced a parameter for > > disabling it runtime. > > > > To avoid the parameter be updated while being used by 'blkback', the > > commit caches the parameter into 'vbd->feature_gnt_persistent' in > > 'xen_vbd_create()', and then check if the guest also supports the > > feature and finally updates the field in 'connect_ring()'. > > > > However, 'connect_ring()' could be called before 'xen_vbd_create()', so > > later execution of 'xen_vbd_create()' can wrongly overwrite 'true' to > > 'vbd->feature_gnt_persistent'. As a result, 'blkback' could try to use > > 'persistent grants' feature even if the guest doesn't support the > > feature. > > > > This commit fixes the issue by moving the parameter value caching to > > 'xen_blkif_alloc()', which allocates the 'blkif'. Because the struct > > embeds 'vbd' object, which will be used by 'connect_ring()' later, this > > should be called before 'connect_ring()' and therefore this should be > > the right and safe place to do the caching. > > > > Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of > persistent grants") > > Cc: # 5.10.x > > Signed-off-by: Maximilian Heyne > > Signed-off-by: SeongJae Park > > --- > > > > Changes from v1[1] > > - Avoid the behavioral change[2] > > - Rebase on latest xen/tip/linux-next > > - Re-work by SeongJae Park > > - Cc stable@ > > > > [1] > https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/ > > [2] > https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/ > > > > drivers/block/xen-blkback/xenbus.c | 15 +++++++-------- > > 1 file changed, 7 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/block/xen-blkback/xenbus.c > b/drivers/block/xen-blkback/xenbus.c > > index 97de13b14175..16c6785d260c 100644 > > --- a/drivers/block/xen-blkback/xenbus.c > > +++ b/drivers/block/xen-blkback/xenbus.c > > @@ -157,6 +157,11 @@ static int xen_blkif_alloc_rings(struct xen_blkif > *blkif) > > return 0; > > } > > > > +/* Enable the persistent grants feature. */ > > +static bool feature_persistent = true; > > +module_param(feature_persistent, bool, 0644); > > +MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants > feature"); > > + > > static struct xen_blkif *xen_blkif_alloc(domid_t domid) > > { > > struct xen_blkif *blkif; > > @@ -181,6 +186,8 @@ static struct xen_blkif *xen_blkif_alloc(domid_t > domid) > > __module_get(THIS_MODULE); > > INIT_WORK(&blkif->free_work, xen_blkif_deferred_free); > > > > + blkif->vbd.feature_gnt_persistent = feature_persistent; > > + > > return blkif; > > } > > > > @@ -472,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd) > > vbd->bdev = NULL; > > } > > > > -/* Enable the persistent grants feature. */ > > -static bool feature_persistent = true; > > -module_param(feature_persistent, bool, 0644); > > -MODULE_PARM_DESC(feature_persistent, > > - "Enables the persistent grants feature"); > > - > > static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, > > unsigned major, unsigned minor, int readonly, > > int cdrom) > > @@ -520,8 +521,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, > blkif_vdev_t handle, > > if (bdev_max_secure_erase_sectors(bdev)) > > vbd->discard_secure = true; > > > > - vbd->feature_gnt_persistent = feature_persistent; > > - > > pr_debug("Successful creation of handle=%04x (dom=%u)\n", > > handle, blkif->domid); > > return 0; > > -- > Regards, > > Oleksandr Tyshchenko > > --0000000000003de32205e3d6c364 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello All,

I faced the mentioned issue recently and= just to bring more context here is our setup:
We use pvblock backend fo= r Android guest. It starts using u-boot with pvblock support(which frontend= doesn't support the persistent grants feature), later it loads and sta= rts the Linux kernel(which frontend supports the persistent grants feature)= . So in total, we have sequent two different frontends reconnection, the fi= rst of which doesn't support persistent grants.
So the original patc= h [1] perfectly solves the original issue and provides the ability to use p= ersistent grants after the reconnection when Linux frontend which supports = persistent grants comes into play.
At the same time [2] will disable the= persistent grants feature for the first and second frontend.
Is it poss= ible to keep [1] =C2=A0as is?

[1] https://lore.kernel.o= rg/xen-devel/20220106091013.126076-1-mheyne@amazon.de/
[2] https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/

Best regards,
Andrii

On Fri, Jul 1= 5, 2022 at 1:15 PM Oleksandr <ole= kstysh@gmail.com> wrote:

On 15.07.22 01:44, SeongJae Park wrote:


Hello all.

Adding Andrii Chepurnyi to CC who have played with the use-case which
required reconnect recently and faced some issues with
feature_persistent handling.




> Persistent grants feature can be used only when both backend and the > frontend supports the feature.=C2=A0 The feature was always supported = by
> 'blkback', but commit aac8a70db24b ("xen-blkback: add a p= arameter for
> disabling of persistent grants") has introduced a parameter for > disabling it runtime.
>
> To avoid the parameter be updated while being used by 'blkback'= ;, the
> commit caches the parameter into 'vbd->feature_gnt_persistent&#= 39; in
> 'xen_vbd_create()', and then check if the guest also supports = the
> feature and finally updates the field in 'connect_ring()'.
>
> However, 'connect_ring()' could be called before 'xen_vbd_= create()', so
> later execution of 'xen_vbd_create()' can wrongly overwrite &#= 39;true' to
> 'vbd->feature_gnt_persistent'.=C2=A0 As a result, 'blkb= ack' could try to use
> 'persistent grants' feature even if the guest doesn't supp= ort the
> feature.
>
> This commit fixes the issue by moving the parameter value caching to > 'xen_blkif_alloc()', which allocates the 'blkif'.=C2= =A0 Because the struct
> embeds 'vbd' object, which will be used by 'connect_ring()= ' later, this
> should be called before 'connect_ring()' and therefore this sh= ould be
> the right and safe place to do the caching.
>
> Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling = of persistent grants")
> Cc: <st= able@vger.kernel.org> # 5.10.x
> Signed-off-by: Maximilian Heyne <mheyne@amazon.de>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>
> Changes from v1[1]
> - Avoid the behavioral change[2]
> - Rebase on latest xen/tip/linux-next
> - Re-work by SeongJae Park <sj@kernel.org>
> - Cc stable@
>
> [1] https://lore.ker= nel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/
> [2] https://lore.kernel.= org/xen-devel/20220121102309.27802-1-sj@kernel.org/
>
>=C2=A0 =C2=A0drivers/block/xen-blkback/xenbus.c | 15 +++++++-------- >=C2=A0 =C2=A01 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-bl= kback/xenbus.c
> index 97de13b14175..16c6785d260c 100644
> --- a/drivers/block/xen-blkback/xenbus.c
> +++ b/drivers/block/xen-blkback/xenbus.c
> @@ -157,6 +157,11 @@ static int xen_blkif_alloc_rings(struct xen_blkif= *blkif)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;
>=C2=A0 =C2=A0}
>=C2=A0 =C2=A0
> +/* Enable the persistent grants feature. */
> +static bool feature_persistent =3D true;
> +module_param(feature_persistent, bool, 0644);
> +MODULE_PARM_DESC(feature_persistent, "Enables the persistent gra= nts feature");
> +
>=C2=A0 =C2=A0static struct xen_blkif *xen_blkif_alloc(domid_t domid) >=C2=A0 =C2=A0{
>=C2=A0 =C2=A0 =C2=A0 =C2=A0struct xen_blkif *blkif;
> @@ -181,6 +186,8 @@ static struct xen_blkif *xen_blkif_alloc(domid_t d= omid)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0__module_get(THIS_MODULE);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0INIT_WORK(&blkif->free_work, xen_blki= f_deferred_free);
>=C2=A0 =C2=A0
> +=C2=A0 =C2=A0 =C2=A0blkif->vbd.feature_gnt_persistent =3D feature_= persistent;
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0return blkif;
>=C2=A0 =C2=A0}
>=C2=A0 =C2=A0
> @@ -472,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0vbd->bdev =3D NULL;
>=C2=A0 =C2=A0}
>=C2=A0 =C2=A0
> -/* Enable the persistent grants feature. */
> -static bool feature_persistent =3D true;
> -module_param(feature_persistent, bool, 0644);
> -MODULE_PARM_DESC(feature_persistent,
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"Enables the per= sistent grants feature");
> -
>=C2=A0 =C2=A0static int xen_vbd_create(struct xen_blkif *blkif, blkif_v= dev_t handle,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0unsigned major, unsigned minor, int readonly,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0int cdrom)
> @@ -520,8 +521,6 @@ static int xen_vbd_create(struct xen_blkif *blkif,= blkif_vdev_t handle,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (bdev_max_secure_erase_sectors(bdev))
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vbd->discard_= secure =3D true;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0vbd->feature_gnt_persistent =3D feature_persis= tent;
> -
>=C2=A0 =C2=A0 =C2=A0 =C2=A0pr_debug("Successful creation of handle= =3D%04x (dom=3D%u)\n",
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0handle, blkif-&g= t;domid);
>=C2=A0 =C2=A0 =C2=A0 =C2=A0return 0;

--
Regards,

Oleksandr Tyshchenko

--0000000000003de32205e3d6c364-- From xen-devel-bounces@lists.xenproject.org Fri Jul 15 12:57:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 12:57:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368212.599389 (Exim 4.92) (envelope-from ) id 1oCKsS-0003hH-5S; Fri, 15 Jul 2022 12:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368212.599389; Fri, 15 Jul 2022 12:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCKsS-0003hA-2g; Fri, 15 Jul 2022 12:57:04 +0000 Received: by outflank-mailman (input) for mailman id 368212; Fri, 15 Jul 2022 12:57:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCKsQ-0003h0-QF; Fri, 15 Jul 2022 12:57:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCKsQ-0004i9-Hp; Fri, 15 Jul 2022 12:57:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCKsQ-0004ew-5z; Fri, 15 Jul 2022 12:57:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCKsQ-0005ih-5U; Fri, 15 Jul 2022 12:57:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1os5ApopMKFCwsvAMwB9GA7M/hPvdUb3Wafjae5+oeI=; b=x8WSBDLeOeiisJfxilhiq29JIh kNAGCDMM4+s5SbkaKzw162JzAJiFHMmetUAAewrxBXcN8J+n/ohWUaIFRh8xFN+rLoPKOIBG8gbPU 0+ZCJkAy6ZgThVg4iDccK0KwMT1qKn7RouzOWAcpDnjKRyOXH3fdbg0SW/YD6MBZIW+U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171634: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-amd64-i386-freebsd10-i386:guest-start/freebsd.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=0ec831fa971d8099e3c4f46093ffb41d044cc10c X-Osstest-Versions-That: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 From: osstest service owner Date: Fri, 15 Jul 2022 12:57:02 +0000 flight 171634 linux-5.4 real [real] flight 171641 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171634/ http://logs.test-lab.xenproject.org/osstest/logs/171641/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171548 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 171624 pass in 171634 test-armhf-armhf-xl-credit1 14 guest-start fail pass in 171624 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171624 test-amd64-i386-freebsd10-i386 21 guest-start/freebsd.repeat fail pass in 171624 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 171624 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171548 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 171624 like 171548 test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail in 171624 like 171548 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171624 like 171548 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 171624 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 171624 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171624 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171624 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 171624 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 171624 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 0ec831fa971d8099e3c4f46093ffb41d044cc10c baseline version: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 Last test of basis 171548 2022-07-07 15:41:19 Z 7 days Testing same since 171600 2022-07-12 14:42:51 Z 2 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Christoph Lameter Claudiu Beznea Darrick J. Wong David Rientjes David S. Miller Dmitry Osipenko Duoming Zhou Eric Sandeen Florian Fainelli Greg Kroah-Hartman Guenter Roeck Guiling Deng Helge Deller Hsin-Yi Wang Hyeonggon Yoo <42.hyeyoo@gmail.com> Ido Schimmel Jacob Pan Jakub Kicinski Jann Horn Jason A. Donenfeld Jernej Skrabec Jimmy Assarsson Joerg Roedel Jon Hunter Kuniyuki Iwashima Lars-Peter Clausen Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marc Kleine-Budde Miaoqian Lin Michael Ellerman Michael Walle Neil Armstrong Nick Child Oliver Hartkopp Oliver Neukum Paolo Abeni Peter Robinson Peter Ujfalusi Rhett Aultman Rick Lindsley Sabrina Dubroca Sachin Sant Samuel Holland Sasha Levin Satish Nagireddy Shuah Khan Steffen Klassert Vinod Koul Vladimir Oltean Vlastimil Babka Wolfram Sang Yian Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 fail test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1026 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 15 13:11:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 13:11:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368220.599401 (Exim 4.92) (envelope-from ) id 1oCL6b-0006KX-GG; Fri, 15 Jul 2022 13:11:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368220.599401; Fri, 15 Jul 2022 13:11:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCL6b-0006KQ-DG; Fri, 15 Jul 2022 13:11:41 +0000 Received: by outflank-mailman (input) for mailman id 368220; Fri, 15 Jul 2022 13:11:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCL6Z-0006KK-6y for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 13:11:39 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a778e8bb-043f-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 15:11:37 +0200 (CEST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26FBZugJ016644; Fri, 15 Jul 2022 13:11:10 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3h727srbx7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Jul 2022 13:11:10 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26FD5jKZ017520; Fri, 15 Jul 2022 13:11:09 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com with ESMTP id 3h70479g01-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Jul 2022 13:11:09 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by DM6PR10MB3387.namprd10.prod.outlook.com (2603:10b6:5:1aa::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 13:11:02 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5438.014; Fri, 15 Jul 2022 13:11:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a778e8bb-043f-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=vh7iSdzvr7okfya/6V271OzBWagVp/6n6bZo6iTlwOw=; b=NzyoBYLCkXmWqcv8c+yqYoEFPvXjQInFZ/J7N2D+36JN73mMWPFDdvhLeU3Ljqy9Abpu ahyCqYhn3S8+9mewKNEjQIybCUADRgUHF0Td5sAmmQ8dK/dfSUu9UDKDz0zcOKB0E4LI 34H1e4wOdGge/ygDX1L7NTzzI9u/0u07DulBhxJHysKZwxCtZjgvDxC2vXC8dxLNHY5t Rg/Zl+oUiaB9H+ZFRcK4hcKNm6pEDaB8jsZkzXxWO6KEg6emQ5fU4Mk5VtSlrYZ0Ly65 zdPle/leeFzlt6QVOxojBM1GFkvnJKpb1izj8KkQV7JSrueG8RPq0ljy2hVSmli5FjJC HA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QcE9H7JqsIIvl95M+l/93/HTX+rC89c3KHjnoZEDqV4/2EwrLM8fleV6FFhtvlcWaEHlJMxZ4ZvzgQ81ggZHS+BK37mF24OnbyHkWJgP+atipjKrKWiLZPbashWSERQT361awNKmxo4Pe4ifALN/reyf31PwWbcLjCkBhFXFlq9J6XvrE5kQVTcsZCW8nsZ5HCKD7IwEC7pG8vvrhfYWXMzcsW9ged6ZzA5YsUQfrgMw7mbCn7miR9gpzfsZzwmr4fOVdCI7NcD/VkkHuRF5ruKno+3H2Uk3/LNFu1dmujM/B8DF2qrwpaVNCAmIslU+fS/dmLYSukRWnv9Mbpthww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vh7iSdzvr7okfya/6V271OzBWagVp/6n6bZo6iTlwOw=; b=TCcoxRUgfMzrTvbjL0QcVg0oaKajrs/u7rWHvj4MEFUXSXap1W5XSQfqgzjv2O9+MXEN6FHeD7+vTiH0iBN+USebU7fwEzeW1fMisa4nTs/WSLJj7i1dFGCXQCKk/jBn1z7yRZnX0lwAtqN+1BF6fBxIJzOwa6nSC48q+KiEP7DRcsBaw7qZV/gCTLNHxnu8L4Rc6ZQI5RRj4kzfhxGB1fytymoFZfpR6DG2tQfqZI+P0uLXGbY2KSkqx7zO5mJoMeX12If52+/3vN+XIPJrmi2q4c1LG9bb5kQhfoB/Ml2BI8h4jCX0Y/hHNQwzMIOpZjizn7oEqZAD5lerKEpyIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vh7iSdzvr7okfya/6V271OzBWagVp/6n6bZo6iTlwOw=; b=QJXybN+bwxGh2JG4NfhYFXb9qOwJy7QOV0phZf46c1TD/NtllQ+F2bnot9vHr14Bep9k//gwSZtHGiXYTOZKBMIawAPHcaVkD/iw8gB34JT8zx/uBxG9eJm83M9rrbUOcktZAADRrs/oZkiN2yaVk6V92FCZ/BAkuS2iDytfWNg= Message-ID: <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> Date: Fri, 15 Jul 2022 09:10:58 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Andrew Cooper , Jane Malalane , LKML Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> From: Boris Ostrovsky In-Reply-To: <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SA0PR11CA0188.namprd11.prod.outlook.com (2603:10b6:806:1bc::13) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8ce6f684-995a-4d8a-3a33-08da666377ba X-MS-TrafficTypeDiagnostic: DM6PR10MB3387:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xHcZUSlXQ/MoX2tNAkSdvH+5k74yh+JrOdTnVtxj89rEVEJrX8NxW9AGQcXVqeod2vUGPDYMURYlajogtAfROIwLWlfBHCg80i7LY0b7ThuuhfG3ia6gE2iWd/mGf+9F/8NJ8CUz2QCSHUkL+Lk7ZhCDxkatblayMD6XIZDR4kVZpulieYk5ck3uOcu24ebtvmAOuL0UV+9kYsQWnTD9DFc9/blTnG/tuw4N8AsFGSnDn55OhJDM8lyHUNJ7ZQyGAgM4nF/obDdDshhtT+G1icrrZFyrK0bicCbAmzFLPADSzG1stEdqshdk0PXodO4DPfqRBPCIBq1LsOvXHk669VUrMFxMbQhMffFe6PBxXjQS+OojMk1eK0mxugerB9xDST+0oV0UuYuKluFpdm63RUsuJOKUwse6kXQbFbBSfLei4tEShkMNY0zCJ1iTeWaltoVpmhXRdlDPmPJICogEDYKmpohzt6D9Ih2YYJ90Lwywa42/TJI5/gx2c45hgMClefV2gH7QcYGp7J5iUZ1XUzay7Ao8xeNSGruyFLnTrcY3BZO5AVbmKKkcJDdMiC6+9UmzAllRZpJUBgdKHSlxKrTMeTm92qTAqyM37e2LrFMgrTo/IYFaPz33NjrqQkp76Bwf7lW48UAmucONsJVO5DMQvAuFMozmDFzeu9SbSVDOohfZclfIgOBBNuHZONfsWNSJTQybxLFbBd+NtdEgddAQjTmw5cVX6rmpUT+euXEFFeSkFMYrQ72JuR+up2Fg62qovy8JYxqKTvVLfLEdC33Nb2cU0HxQHTCB72XpObeche7NrJ1pz/CWU1Wx/K+12B7m89YilVK+RmV6scjrXWpCN6qLj7llWkxz3C3DANE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(366004)(396003)(39860400002)(376002)(186003)(44832011)(31686004)(36756003)(7416002)(2616005)(38100700002)(8936002)(2906002)(5660300002)(26005)(6506007)(66476007)(110136005)(478600001)(8676002)(6666004)(41300700001)(316002)(66556008)(83380400001)(6486002)(4326008)(66946007)(86362001)(54906003)(6512007)(31696002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTJtNVNiYzBOanBjZmF3K2cxNVl5dUNRS1liMHdQVWlJc3EvRWV1QjdOaUc2?= =?utf-8?B?UjBWT1dIWFhPdXhSeXAxZnhzNDFCdUkzTnQybU85NTM3VWJjQk1wb3J2WUg2?= =?utf-8?B?QnBMTkk0dVczcit0azhMY3M1bjViWmgzUGxkakxvSkFLOENOVWo3clpad0Ri?= =?utf-8?B?UUltRktyTWtVeXpnOW1zUURDeWFMa1NSd2hyeXhrTjlWaFZ5cDZVOFJYWWJq?= =?utf-8?B?d1N3YzVzVHdzZXV0Q1dyMVAvaVFwbms3M3VsVlJ1d1RBZForS091MnRyNnFZ?= =?utf-8?B?Ky8zMjh5V3I2c0ltMXQ0SGxXek9YNnJVLzc0QlZTVnBiU3ZiTDIzTHF3OHB2?= =?utf-8?B?MEVKbGhSNGF3OHE4aG5HTjZZcVRwbFdNdURwUmVhWDVVSHpwOTY1UXhaK0h5?= =?utf-8?B?TmtIYXplOUxBaEpNNGV0WStoVUYvNEQ3cGQ1WXlnUmtVa0c4NFFzUVNMQlcy?= =?utf-8?B?MVBLZjNPY2pnRkVhQXhzd21pdUtkdUloSmp4eGcyQTZxMmRjVHBzODZFNHBJ?= =?utf-8?B?WjVGcmJqTGRQRHdlUjVYMzZ2QlV0ZlpjUmkyWXlzM3hFZUpIMzYvV3Yycktu?= =?utf-8?B?NDQwS296RURUaVBNcVkvUVU4eXlaS054RzJMRTVkWmJNcUZyVHBtSm1yVTBh?= =?utf-8?B?ZUZRVXovWjBpbVlvMXBrVXI5Rmx0NUphQ1NWbmxrN2ozS1I1cnRZeXRQTmRV?= =?utf-8?B?c0pFSGE5RGxFOFhZWkttRGhXbTVWZFpaUDdUdXRzajQ2YTlxL1paNTA5aXEz?= =?utf-8?B?Umd5dHE1MFhzSXdSWHJXRFhtN0ZhVkhtRmdFdTJiWFNxMWFMNnhwbU5NY21x?= =?utf-8?B?a2owQ1lIMGJwcDV0cGE1ZXRuUlVCcHpXL1JzaTR6SDN0bDdwcW5IcklFYmpv?= =?utf-8?B?ZS9FdnhPVHVJR0RwVTk1SG5IZkhMQW9IcmM4TjB2L3FMSHNVc2tMMVZnOE42?= =?utf-8?B?LzZXS3RsWHBmRUEzRmhjd0xtRG1WSU1ma1g1ZzQ3TmVSa0l4T0Y1MlZaVFZ4?= =?utf-8?B?U0NkaXZKR3ZidkloMFFmWGg5QWVkcWpzNVF2SUlZWW0xczNlaklzUXJrc0Vs?= =?utf-8?B?bUZIWlEycGVzeEFpMW1NR2RuQS9vYStaTGphSGpsZDVSRXFEazM2bWp2Tkw3?= =?utf-8?B?alEyRlNCSnlka0s3U0tORmNHcmJ1N0hwYTVuV3dVRG16eE4rcmFJdk13RHhD?= =?utf-8?B?RjFlSjNQV3VQNWR1eXhUZmFXMlhXamZjMW1aUmd0a2RSRmlweExBaHJKNDNn?= =?utf-8?B?WEhOejM3WDZyc1JHK0I3VE5QdHdBNWVsUnVINWlhMmFWZGk1NnFBNlprSllJ?= =?utf-8?B?TTNNdVA3TVJQSWVXRlZwKzBGV1AyWGlCQzlpWmN4elhBUFlWWHdrZ0ROSWlM?= =?utf-8?B?am9lZEplclBqSWt6NUxqcWRralQwNkppbytYQ3REN29ad3lFbzVJaVl3QkM2?= =?utf-8?B?VDA4TTFqUXZMYlFORFdHeHY3K2FuQmpFWllKamdYaTB0ckUvWFhlVmRuSFNs?= =?utf-8?B?TUNxbkFiM0hEZHMrcThJVUlVTWc2ckZDeVVWa1B2ajJxU0pPalY3SEtpVTBr?= =?utf-8?B?TUN6bWpJT2c0RXc1VWQxU0l5cXQxRkUwUkEwY0RCRVZPanl4Q1hsMzVYRWQ4?= =?utf-8?B?KzRjSm44b05wOUJNZmI0TWNmVHZyeCtNbWN3UnBGSWlXczVVMFZSWVVPVHpx?= =?utf-8?B?RU5kQkNmcG5vVHpjNVRKb20xWkVXZ0xCWXQrTVQ1NTJsUUFDY1NIVzdnU3dp?= =?utf-8?B?YjRTTVhraXdJM1BTeXNtVHBLWlphM3NscmhERlVQVmhGZ1crR0JmbEsyNlgy?= =?utf-8?B?V294aVc1cDBVclJhRHRkVkZDRzgyVVFMK0l4cnd5V3FjbHoxcmwzdC81ZkRM?= =?utf-8?B?ekZGT3M1VGJkT2cxMkxhUEQyeWFCTVcrb3JVTHN1Znd2eWV5QzhaQm4yb1A1?= =?utf-8?B?UWJGMVBCNVV3NGdXSFQ1c2xicExCNU50a1czZ2M2RW5HTldJQTkrcUM3NGhi?= =?utf-8?B?bFhHUUlkOTZmT0tGN1RWVVZBemc5c1FiNmJiMUJ4dlIrMHpOamlqQWpubjA0?= =?utf-8?B?QU94aXo2YjFZdlc2WlFZUkNuTUxFS1d2aGhUbjF5QmtYQUdvTDZUWm11TXdF?= =?utf-8?B?YWJqR29IUWwxVWtxTHJBZWl1cFRLQ0NYRzBzZ1l0dDU2ZG91dDNaMnNZZXpm?= =?utf-8?B?b2c9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce6f684-995a-4d8a-3a33-08da666377ba X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 13:11:02.4241 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T7VAEVTM5e1rT8TKWch4Wys3WzAbejtey+tW0UPgqLe+Saw6D45uHu+Zx1vjVg4FcieWmuVuBPqeBbnWyJcDq/I4rByjXlmPFqxtqDD3mfo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB3387 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-15_05:2022-07-14,2022-07-15 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207150058 X-Proofpoint-ORIG-GUID: wumeSia-bQlmqPpV1mP4ekre0fCVp65j X-Proofpoint-GUID: wumeSia-bQlmqPpV1mP4ekre0fCVp65j On 7/15/22 5:50 AM, Andrew Cooper wrote: > On 15/07/2022 09:18, Jane Malalane wrote: >> On 14/07/2022 00:27, Boris Ostrovsky wrote: >>>>       xen_hvm_smp_init(); >>>>       WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); >>>> diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c >>>> index 9d548b0c772f..be66e027ef28 100644 >>>> --- a/arch/x86/xen/suspend_hvm.c >>>> +++ b/arch/x86/xen/suspend_hvm.c >>>> @@ -5,6 +5,7 @@ >>>>   #include >>>>   #include >>>>   #include >>>> +#include >>>>   #include "xen-ops.h" >>>> @@ -14,6 +15,23 @@ void xen_hvm_post_suspend(int suspend_cancelled) >>>>           xen_hvm_init_shared_info(); >>>>           xen_vcpu_restore(); >>>>       } >>>> -    xen_setup_callback_vector(); >>>> +    if (xen_ack_upcall) { >>>> +        unsigned int cpu; >>>> + >>>> +        for_each_online_cpu(cpu) { >>>> +            xen_hvm_evtchn_upcall_vector_t op = { >>>> +                    .vector = HYPERVISOR_CALLBACK_VECTOR, >>>> +                    .vcpu = per_cpu(xen_vcpu_id, cpu), >>>> +            }; >>>> + >>>> +            BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, >>>> +                         &op)); >>>> +            /* Trick toolstack to think we are enlightened. */ >>>> +            if (!cpu) >>>> +                BUG_ON(xen_set_callback_via(1)); >>> What are you trying to make the toolstack aware of? That we have *a* >>> callback (either global or percpu)? >> Yes, specifically for the check in libxl__domain_pvcontrol_available. > And others. > > This is all a giant bodge, but basically a lot of tooling uses the > non-zero-ness of the CALLBACK_VIA param to determine whether the VM has > Xen-aware drivers loaded or not. > > The value 1 is a CALLBACK_VIA value which encodes GSI 1, and the only > reason this doesn't explode everywhere is because the > evtchn_upcall_vector registration takes priority over GSI delivery. > > This is decades of tech debt piled on top of tech debt. Feels like it (setting the callback parameter) is something that the hypervisor should do --- no need to expose guests to this. -boris From xen-devel-bounces@lists.xenproject.org Fri Jul 15 13:27:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 13:27:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368229.599423 (Exim 4.92) (envelope-from ) id 1oCLLl-0000OP-5Y; Fri, 15 Jul 2022 13:27:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368229.599423; Fri, 15 Jul 2022 13:27:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLl-0000OI-2j; Fri, 15 Jul 2022 13:27:21 +0000 Received: by outflank-mailman (input) for mailman id 368229; Fri, 15 Jul 2022 13:27:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLk-00007s-4y for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 13:27:20 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d9929a37-0441-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 15:27:19 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d9929a37-0441-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657891639; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=Bo8WYCUkVXZCZC7rokwVAr1QbuRms3WVx1QMppMlBro=; b=Qk3ZvARhIJABb0VmBkgNepGSvVHhiiIGx0vZrGBxMAXrCttjevaHikFN 3WXF+57lqgvDazTZtFDFqiRSdJAskfgctCJyuHA1lhAmGN2qCiMJCIyST 07+V86S7sDy/HhkJnf0QHPTbHekGiy/SV7+nyASp+Ee9nOjUh3esvaLvZ 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75187320 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:LZ1TWqMOoOa/7AbvrR1Tl8FynXyQoLVcMsEvi/4bfWQNrUp20DcPx zdMXT3XPvnbZzCjL912aNm18BgD7JLWxoVgSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPve8EgHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPnxfdMNEw5OLZF491IGTpPz 94da24kO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeOlVwui+K1WDbTUvyWftdwmUTCn z7t5UD8IRQlL+649wPQpxpAgceQxHimCer+DoaQ8/d2gFye2yoPAQcMXF+TueO+lkm4XtteL wof/S9Ghaov8E2mSPHtUhv+p2SL1jY2VsBMCeQ85Eeow7DN/geCLmEeS3hKb9lOnOsrTjVs+ FaPlN7tASFHuaeQD3ma89+8jxm/JCwUJm8qfjIfQE0O5NyLiJE+iFfDQ8huFIaxj8bpAnfgz jaSti88ir4Py8kR2M2T4lTvkz+q4J/TQWYd/R7LV2io6gd4Yo+NZIGy71Xfq/FaI+6kokKp5 SZe3ZLEtaZXUM/LxHflrPgx8K+B7PCHEgXRjltUQoAayCz2+kSBeMMOyWQrTKt2CfroaQMFc WeK514OtMMCYyLxBUNkS9nvUpp3lMAMAfygD6mJNYQWP/CdYSfdpElTiVisM3cBeaTGuYU2I t+lfMmlFh724ow3nWPtF4/xPVLGrx3SJF8/prihlnxLKZLEOBaopU4taTNilNwR4qKeuxny+ N1CLcaMwBg3eLSgP3aHq9VDdgBQciNT6XXKRyt/L7TrH+abMDt5V6+5LU0JIeSJYJi5Zs+Xp yrgCye0OXL0hGHdKBXiV02PnIjHBM4lxVpiZHREFQ/xixALPNf0hI9CJsRfQFXS3LE6pRKCZ 6JeIJvo7zUmYmmvxgnxmrGm/d05JEnx3FzfV8dnCRBmF6Ndq8Xy0oeMVmPSGOMmUkJbaeNWT 2Wc6z7m IronPort-HdrOrdr: A9a23:9u2/RK/CT4G883Uhn35uk+DaI+orL9Y04lQ7vn2YSXRuHPBw9v re5cjzuiWVtN98Yh0dcJW7Scy9qBDnhPhICOsqTNSftWDd0QPCRuxfBMnZslnd8kXFh4lgPM xbEpSWZueeMbEDt7eZ3DWF X-IronPort-AV: E=Sophos;i="5.92,274,1650945600"; d="scan'208";a="75187320" From: Andrew Cooper To: Xen-devel CC: Anthony PERARD , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Luca Fancellu , Mathieu Tarral , Bertrand Marquis Subject: [PATCH v2 1/2] xen: Fix check-endbr.sh with mawk Date: Fri, 15 Jul 2022 14:26:50 +0100 Message-ID: <20220715132651.1093-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220715132651.1093-1-andrew.cooper3@citrix.com> References: <20220715132651.1093-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain From: Anthony PERARD check-endbr.sh works with gawk, but fails with mawk. The produced $ALL file is smaller as it is missing 0x$vma_lo on every line. With mawk, int(0x2A) just produces 0, instead of the expected value. The use of hexadecimal-constant in awk is an optional part of the posix spec, and mawk doesn't seems to implemented. There is a way to convert an hexadecimal to a number be putting it in a string, and awk as I understand is supposed to use strtod() to convert the string to a number when needed. The expression 'int("0x15") + 21' would produce the expected value in `mawk` but now `gawk` won't convert the string to a number unless we use the option "--non-decimal-data". So let's convert the hexadecimal number before using it in the awk script. The shell as no issue with dealing with hexadecimal-constant so we'll simply use the expression "$(( 0x15 ))" to convert the value before using it in awk. Note: This does introduce a latent portability bug, which fixed in a separate change to avoid mixing complexity/explanations. Fixes: 4d037425dc ("x86: Build check for embedded endbr64 instructions") Resolves: xen-project/xen#26 Reported-by: Luca Fancellu Reported-by: Mathieu Tarral Signed-off-by: Anthony PERARD Reviewed-by: Bertrand Marquis Reviewed-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Anthony PERARD CC: Luca Fancellu CC: Mathieu Tarral CC: Bertrand Marquis v2: * Add comment explaining what's going on. * Tweak commit message. Add a note about the portibility issue. --- xen/tools/check-endbr.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh index f633846b0f79..b3febd6a4ccc 100755 --- a/xen/tools/check-endbr.sh +++ b/xen/tools/check-endbr.sh @@ -64,6 +64,11 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & # split the VMA in half so AWK's numeric addition is only working on 32 bit # numbers, which don't lose precision. # +# 4) MAWK doesn't support plain hex constants (an optional part of the POSIX +# spec), and GAWK and MAWK can't agree on how to work with hex constants in +# a string. Use the shell to convert $vma_lo to decimal before passing to +# AWK. +# eval $(${OBJDUMP} -j .text $1 -h | $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') @@ -79,7 +84,7 @@ then else grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ -e "$(printf '\146\17\37\1')" $TEXT_BIN -fi | $AWK -F':' '{printf "%s%x\n", "'$vma_hi'", int(0x'$vma_lo') + $1}' > $ALL +fi | $AWK -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL # Wait for $VALID to become complete wait -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 13:27:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 13:27:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368230.599434 (Exim 4.92) (envelope-from ) id 1oCLLn-0000ey-FK; Fri, 15 Jul 2022 13:27:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368230.599434; Fri, 15 Jul 2022 13:27:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLn-0000ep-BM; Fri, 15 Jul 2022 13:27:23 +0000 Received: by outflank-mailman (input) for mailman id 368230; Fri, 15 Jul 2022 13:27:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLl-00007s-CD for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 13:27:21 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da51210b-0441-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 15:27:20 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da51210b-0441-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657891640; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=U5l4uZAhsQRLLS5kMyqPK59gZmSwaebKw6RbWmoikFw=; b=XFOfC6UEt/X4f1cpX/J3Y9dCW8gz+L/NwVIzNQxErV1YvRHo43V4DDma EzM49tcvLXtYe6CTzjQi3lpxJsfTR3Lz/EHPF9KteFSGemCnUzCOysBfW NnTJUrl08EFnPBJ2Amjw+E0woPI8h2bj435Dii4AemWjE6Y+uiaxSzJ1C M=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75187322 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:B3v3G61K40KjDHM+X/bD5SVxkn2cJEfYwER7XKvMYLTBsI5bpz0Cn zMWXGnVbv/YZWSkeYh/OoS2ox5SusfTmIRnHQNtpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8U4355wehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/5oDmMOMIIdwbtuOl5Wr v0iCjVOMDnW0opawJrjIgVtrsEqLc2tN4IDoHBwizreCJ7KQ7iaHf+Mv4UBmm5t2IYeRp4yZ OJAAdZrRD3GbwdCJRE8D5Umkf3zrnL+bydZuBSeoq9fD237k1EogOe2aoC9ltqiY90K3Rypq 1n8pUfSDD5EDoOC8WWfyyf57gPItXyiA99DfFGizdZviUGTx2EOTgEfT0GypdGhkEmiXNRaI k0QvCEpqMAa9lGvT9T7dw21pjiDpBF0c/BdCfEg4QeBjI/d+R+EB3MsRyRELtchsaceYSEh3 xmnltXiCDhrrZWcU3fb/bCRxRuQEyUIKW4JZQcfUBAIpdLkpekbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lXjYhxq8q56PSRQ6ji3MRX6s5A59YI+jZqSr5ELd4PIGK5yWJmRtp 1BdxZLYtrpXS8jQymrdG43hAY1F+d6ONj/+uVNgGqJ87g+S4yWiR6JVo29XcRIB3tk/RdP5X KPCkVoPucADYCr1NPQfj5GZUJpzk/W5fTjxfrWNN4cVPMAsHOOS1Hs2DXN8yVwBh6TFfUsXH Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwY507+uVZmTCTJIYrpyXPXBgzD0IuKoR/O7 /FUPNaQxhNUXYXWO3eKrt5JdgBRfSJkXvgaTvC7kcbaeGJb9JwJUaeNkdvNhaQ/90iqqgs41 i7kARIJoLYOrXbGNR+LehheVV8bZr4m9ShTFXV1ZT6AgiFzCa7yvfx3X8ZmItEaGBlLkKcco w8tIJ7bXJyii13vplwgUHUKhNczJU/72FjXYXvNjfpWV8cIejElM+TMJmPHnBTixALt3Sfii 9VMDj/mfKc= IronPort-HdrOrdr: A9a23:Sqxqj6ickQ/t/Xk8JOH9arjRfnBQXt4ji2hC6mlwRA09TySZ// rOoB17726NtN9/YgBCpTntAsa9qDbnhPpICOoqTM6ftWvdyQmVxehZhOOIqVCNJ8S9zJ876U 4JSdkZNDSaNzhHZKjBjjVQa+xQpeW6zA== X-IronPort-AV: E=Sophos;i="5.92,274,1650945600"; d="scan'208";a="75187322" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Anthony PERARD , Luca Fancellu , Mathieu Tarral , Bertrand Marquis Subject: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Date: Fri, 15 Jul 2022 14:26:51 +0100 Message-ID: <20220715132651.1093-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220715132651.1093-1-andrew.cooper3@citrix.com> References: <20220715132651.1093-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain While Xen's current VMA means it works, the mawk fix (i.e. using $((0xN)) in the shell) isn't portable in 32bit shells. See the code comment for the fix. The fix found a second latent bug. Recombining $vma_hi/lo should have used printf "%s%08x" and only worked previously because $vma_lo had bits set in it's top nibble. Combining with the main fix, %08x becomes %07x. Fixes: $XXX patch 1 Reported-by: Jan Beulich Signed-off-by: Andrew Cooper --- CC: George Dunlap CC: Jan Beulich CC: Stefano Stabellini CC: Wei Liu CC: Julien Grall CC: Anthony PERARD CC: Luca Fancellu CC: Mathieu Tarral CC: Bertrand Marquis v2: * New --- xen/tools/check-endbr.sh | 25 +++++++++++++++++++++---- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh index b3febd6a4ccc..d6aa117de13b 100755 --- a/xen/tools/check-endbr.sh +++ b/xen/tools/check-endbr.sh @@ -61,19 +61,36 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & # the lower bits, rounding integers to the nearest 4k. # # Instead, use the fact that Xen's .text is within a 1G aligned region, and -# split the VMA in half so AWK's numeric addition is only working on 32 bit -# numbers, which don't lose precision. +# split the VMA so AWK's numeric addition is only working on <32 bit +# numbers, which don't lose precision. (See point 5) # # 4) MAWK doesn't support plain hex constants (an optional part of the POSIX # spec), and GAWK and MAWK can't agree on how to work with hex constants in # a string. Use the shell to convert $vma_lo to decimal before passing to # AWK. # +# 5) Point 4 isn't fully portable. POSIX only requires that $((0xN)) be +# evaluated as long, which in 32bit shells turns negative if bit 31 of the +# VMA is set. AWK then interprets this negative number as a double before +# adding the offsets from the binary grep. +# +# Instead of doing an 8/8 split with vma_hi/lo, do a 9/7 split. +# +# The consequence of this is that for all offsets, $vma_lo + offset needs +# to be less that 256M (i.e. 7 nibbles) so as to be successfully recombined +# with the 9 nibbles of $vma_hi. This is fine; .text is at the start of a +# 1G aligned region, and Xen is far far smaller than 256M, but leave safety +# check nevertheless. +# eval $(${OBJDUMP} -j .text $1 -h | - $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') + $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 9), substr($4, 10, 16)}') ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN +bin_sz=$(stat -c '%s' $TEXT_BIN) +[ "$bin_sz" -ge $(((1 << 28) - $vma_lo)) ] && + { echo "$MSG_PFX Error: .text offsets can exceed 256M" >&2; exit 1; } + # instruction: hex: oct: # endbr64 f3 0f 1e fa 363 017 036 372 # endbr32 f3 0f 1e fb 363 017 036 373 @@ -84,7 +101,7 @@ then else grep -aob -e "$(printf '\363\17\36\372')" -e "$(printf '\363\17\36\373')" \ -e "$(printf '\146\17\37\1')" $TEXT_BIN -fi | $AWK -F':' '{printf "%s%x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL +fi | $AWK -F':' '{printf "%s%07x\n", "'$vma_hi'", int('$((0x$vma_lo))') + $1}' > $ALL # Wait for $VALID to become complete wait -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 13:27:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 13:27:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368228.599412 (Exim 4.92) (envelope-from ) id 1oCLLj-000085-US; Fri, 15 Jul 2022 13:27:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368228.599412; Fri, 15 Jul 2022 13:27:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLj-00007y-Rs; Fri, 15 Jul 2022 13:27:19 +0000 Received: by outflank-mailman (input) for mailman id 368228; Fri, 15 Jul 2022 13:27:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCLLj-00007s-9O for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 13:27:19 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d7bab69d-0441-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 15:27:17 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7bab69d-0441-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657891637; h=from:to:cc:subject:date:message-id:mime-version; bh=rFsX1mk7Lb89Tw58crT1ZMj/2nbs2lEVYgiqDjeDrYU=; b=TuF75kvBJZDVJ6ygev/3mfMwKKsY9babql9dlOM1z9osO81SGHrr6MpL lZVSO4qK87ppWmIUmcNntcJAFqlbHeWUcj1/aVDIFlO5Qx3hAc+uipv8A a8yruqwQWCI2E5+JKO7n9otFUsXvavTLv/MDIPPL7V7s0jd+wEeIrb0pI 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 75187321 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:AaBsdK29vA1bms+pWvbD5SVxkn2cJEfYwER7XKvMYLTBsI5bp2MOn WVJX2+GM/2KZmD8Kopyb9m09U1Vvp+BxtdnGQVrpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8U4355wehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/5oDmMOMIIdwbtuOl5Wr v0iCjVOMDnW0opawJrjIgVtrsEqLc2tN4IDoHBwizreCJ7KQ7iaHf+Mv4UBmm5t2IYeRp4yZ OJAAdZrRD3GbwdCJRE8D5Umkf3zrnL+bydZuBSeoq9fD237k1EogOe2aoO9ltqia8JMnFech j/6+3nAXz9HOMO95yG3yyf57gPItXyiA99DfFGizdZviUGTx2EOTgEfT0GypdGhkEmiXNRaI k0QvCEpqMAa9lGvT9T7dw21pjiDpBF0c/BdCfEg4QeBjI/d+R+EB3MsRyRELtchsaceYSEh3 xmnltXiCDhrrZWcU3fb/bCRxRuQEyUIKW4JZQcfUBAIpdLkpekbnh/JC9puDqOxptn0Ai3rh SCHqjAkgLcehtJN0L+0lXjYhxq8q56PSRQ6ji3MRX6s5A59YI+jZqSr5ELd4PIGK5yWJmRtp 1BdxZLYtrpXS8jQymrdG43hAY1F+d6ONj/+uVNgGqJ87g+S4yWiR6JVo29XcRIB3tk/RdP5X KPCkVoPucADYCr1NPQfj5GZUJpzk/W5fTjxfrWNN4cVPMAsHOOS1Hs2DXN8yVwBh6TFfUsXH Z6AOfihAn8BYUiM5GrnHrxNuVPHK81X+I8yeXwY507+uVZmTCTJIYrpyXPXBgzD0IuKoR/O7 /FUPNaQxhNUXYXWO3eKrt5JdgBRfSJkXvgaTvC7kcbaeGJb9JwJUaeNkdvNhaQ/90iqqgs41 i7kARIJoLYOrXbGNR+LehheVV8bZr4m9ShTFXV1ZT6AgiFzCa7yvfx3X8ZmItEaGBlLkKcco w8tIJ7bXJyii13vplwgUHUKhNczJU/72FjXYXvNjfpWV8cIejElM+TMJmPHnBTixALr3Sfii 9VMDj/mfKc= IronPort-HdrOrdr: A9a23:O5riIaFEyGEU/gwzpLqE4MeALOsnbusQ8zAXP0AYc31om62j5q aTdZsgpHzJYVoqN03I+urwX5VoI0msl6KdiLN5VdzJMWXbUQOTXeVfBODZowEIdReRygck79 YET5RD X-IronPort-AV: E=Sophos;i="5.92,274,1650945600"; d="scan'208";a="75187321" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , George Dunlap , Jan Beulich , "Stefano Stabellini" , Wei Liu , Julien Grall , Anthony PERARD , Luca Fancellu , Mathieu Tarral , Bertrand Marquis Subject: [PATCH v2 0/2] xen: Fixes to check-endbr.sh Date: Fri, 15 Jul 2022 14:26:49 +0100 Message-ID: <20220715132651.1093-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain I committed the two trivial patches, which leaves the main MAWK fix from Anthony, and the fix for the portability issue spotted by Jan. Andrew Cooper (1): xen: Fix latent check-endbr.sh bug with 32bit build environments Anthony PERARD (1): xen: Fix check-endbr.sh with mawk xen/tools/check-endbr.sh | 30 ++++++++++++++++++++++++++---- 1 file changed, 26 insertions(+), 4 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:16:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368253.599453 (Exim 4.92) (envelope-from ) id 1oCM6m-0007l8-6f; Fri, 15 Jul 2022 14:15:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368253.599453; Fri, 15 Jul 2022 14:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCM6m-0007l1-2u; Fri, 15 Jul 2022 14:15:56 +0000 Received: by outflank-mailman (input) for mailman id 368253; Fri, 15 Jul 2022 14:15:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCM6k-0007kr-Pn; Fri, 15 Jul 2022 14:15:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCM6k-0006BH-N5; Fri, 15 Jul 2022 14:15:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCM6k-0000pH-4Z; Fri, 15 Jul 2022 14:15:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCM6k-0002lM-44; Fri, 15 Jul 2022 14:15:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MZBzH3Gvs/zzh3Lg+0N5Xb860fmUmkNeR7WhhP6YqTw=; b=HCEITnBr135EI3/bJNQbt40LPh ezyF4DRn0tXgfta4lXiCZFswK0wuMjJzKkmdtYTJBohjl/OqEg/jbyerL/ts3XotqHKRIgGUTm804 o0jT+59uIz8J/+pcpgafKJ71X4ackqqXB7Hwf8v/nKIjdOwthiuWQCb+9d+5aKlEcDCY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171636: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b X-Osstest-Versions-That: xen=d8cb7e0f069e0f106d24941355b59b45a731eabe From: osstest service owner Date: Fri, 15 Jul 2022 14:15:54 +0000 flight 171636 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171636/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171627 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171619 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171627 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171627 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171627 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171627 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171627 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171627 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171627 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171627 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171627 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171627 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171627 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b baseline version: xen d8cb7e0f069e0f106d24941355b59b45a731eabe Last test of basis 171627 2022-07-14 10:25:22 Z 1 days Testing same since 171636 2022-07-15 00:39:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jiamei Xie Stefano Stabellini Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d8cb7e0f06..355caa9ef2 355caa9ef29fd4bcdf48bc263e6ca3b24392490b -> master From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368264.599482 (Exim 4.92) (envelope-from ) id 1oCMGS-0001Uu-Us; Fri, 15 Jul 2022 14:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368264.599482; Fri, 15 Jul 2022 14:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGS-0001T5-Mu; Fri, 15 Jul 2022 14:25:56 +0000 Received: by outflank-mailman (input) for mailman id 368264; Fri, 15 Jul 2022 14:25:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGR-0001BP-8R for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 14:25:55 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 084fc170-044a-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 16:25:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 159531FEFD; Fri, 15 Jul 2022 14:25:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B50A913B28; Fri, 15 Jul 2022 14:25:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yF3cKvB40WK+QQAAMHmgww (envelope-from ); Fri, 15 Jul 2022 14:25:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 084fc170-044a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657895153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hzOhvTFCR82QZ7iKoRr+Nal/xjLFCKOCfmvvUa9Dxk8=; b=Z0JBV9s4Lfa87plttXYv1iKr47UlJrL14HRvAZPYuh8VEtPbZQBTUYjQ0fRmoA0fRHN6jZ 6NAxb1ezCZIxkxQnkYRg8HS3eCF3aah417PQ9z1w76NKH3GdfOCv4VgCSjq1pnIa0qiRe+ 7CLyc6NdFJ3cN/zZbljXaomOKYAO4gk= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: brchuckz@netscape.net, jbeulich@suse.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , stable@vger.kernel.org Subject: [PATCH 1/3] x86: move some code out of arch/x86/kernel/cpu/mtrr Date: Fri, 15 Jul 2022 16:25:47 +0200 Message-Id: <20220715142549.25223-2-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220715142549.25223-1-jgross@suse.com> References: <20220715142549.25223-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Prepare making PAT and MTRR support independent from each other by moving some code needed by both out of the MTRR specific sources. Cc: # 5.17 Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") Signed-off-by: Juergen Gross --- arch/x86/include/asm/mtrr.h | 4 ++ arch/x86/include/asm/processor.h | 3 ++ arch/x86/kernel/cpu/common.c | 76 ++++++++++++++++++++++++++++ arch/x86/kernel/cpu/mtrr/generic.c | 80 +++--------------------------- 4 files changed, 91 insertions(+), 72 deletions(-) diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 76d726074c16..12a16caed395 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -48,6 +48,8 @@ extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); +void mtrr_disable(void); +void mtrr_enable(void); # else static inline u8 mtrr_type_lookup(u64 addr, u64 end, u8 *uniform) { @@ -87,6 +89,8 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) #define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) +#define mtrr_disable() do {} while (0) +#define mtrr_enable() do {} while (0) # endif #ifdef CONFIG_COMPAT diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 356308c73951..5c934b922450 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -865,4 +865,7 @@ bool arch_is_platform_page(u64 paddr); #define arch_is_platform_page arch_is_platform_page #endif +void cache_disable(void); +void cache_enable(void); + #endif /* _ASM_X86_PROCESSOR_H */ diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 736262a76a12..e43322f8a4ef 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -61,6 +61,7 @@ #include #include #include +#include #include "cpu.h" @@ -2327,3 +2328,78 @@ void arch_smt_update(void) /* Check whether IPI broadcasting can be enabled */ apic_smt_update(); } + +/* + * Disable and enable caches. Needed for changing MTRRs and the PAT MSR. + * + * Since we are disabling the cache don't allow any interrupts, + * they would run extremely slow and would only increase the pain. + * + * The caller must ensure that local interrupts are disabled and + * are reenabled after cache_enable() has been called. + */ +static unsigned long saved_cr4; +static DEFINE_RAW_SPINLOCK(cache_disable_lock); + +void cache_disable(void) __acquires(cache_disable_lock) +{ + unsigned long cr0; + + /* + * Note that this is not ideal + * since the cache is only flushed/disabled for this CPU while the + * MTRRs are changed, but changing this requires more invasive + * changes to the way the kernel boots + */ + + raw_spin_lock(&cache_disable_lock); + + /* Enter the no-fill (CD=1, NW=0) cache mode and flush caches. */ + cr0 = read_cr0() | X86_CR0_CD; + write_cr0(cr0); + + /* + * Cache flushing is the most time-consuming step when programming + * the MTRRs. Fortunately, as per the Intel Software Development + * Manual, we can skip it if the processor supports cache self- + * snooping. + */ + if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) + wbinvd(); + + /* Save value of CR4 and clear Page Global Enable (bit 7) */ + if (boot_cpu_has(X86_FEATURE_PGE)) { + saved_cr4 = __read_cr4(); + __write_cr4(saved_cr4 & ~X86_CR4_PGE); + } + + /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */ + count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); + flush_tlb_local(); + + if (boot_cpu_has(X86_FEATURE_MTRR)) + mtrr_disable(); + + /* Again, only flush caches if we have to. */ + if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) + wbinvd(); +} + +void cache_enable(void) __releases(cache_disable_lock) +{ + /* Flush TLBs (no need to flush caches - they are disabled) */ + count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); + flush_tlb_local(); + + if (boot_cpu_has(X86_FEATURE_MTRR)) + mtrr_enable(); + + /* Enable caches */ + write_cr0(read_cr0() & ~X86_CR0_CD); + + /* Restore value of CR4 */ + if (boot_cpu_has(X86_FEATURE_PGE)) + __write_cr4(saved_cr4); + + raw_spin_unlock(&cache_disable_lock); +} diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 558108296f3c..84732215b61d 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -396,9 +396,6 @@ print_fixed(unsigned base, unsigned step, const mtrr_type *types) } } -static void prepare_set(void); -static void post_set(void); - static void __init print_mtrr_state(void) { unsigned int i; @@ -450,11 +447,11 @@ void __init mtrr_bp_pat_init(void) unsigned long flags; local_irq_save(flags); - prepare_set(); + cache_disable(); pat_init(); - post_set(); + cache_enable(); local_irq_restore(flags); } @@ -715,80 +712,19 @@ static unsigned long set_mtrr_state(void) return change_mask; } - -static unsigned long cr4; -static DEFINE_RAW_SPINLOCK(set_atomicity_lock); - -/* - * Since we are disabling the cache don't allow any interrupts, - * they would run extremely slow and would only increase the pain. - * - * The caller must ensure that local interrupts are disabled and - * are reenabled after post_set() has been called. - */ -static void prepare_set(void) __acquires(set_atomicity_lock) +void mtrr_disable(void) { - unsigned long cr0; - - /* - * Note that this is not ideal - * since the cache is only flushed/disabled for this CPU while the - * MTRRs are changed, but changing this requires more invasive - * changes to the way the kernel boots - */ - - raw_spin_lock(&set_atomicity_lock); - - /* Enter the no-fill (CD=1, NW=0) cache mode and flush caches. */ - cr0 = read_cr0() | X86_CR0_CD; - write_cr0(cr0); - - /* - * Cache flushing is the most time-consuming step when programming - * the MTRRs. Fortunately, as per the Intel Software Development - * Manual, we can skip it if the processor supports cache self- - * snooping. - */ - if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) - wbinvd(); - - /* Save value of CR4 and clear Page Global Enable (bit 7) */ - if (boot_cpu_has(X86_FEATURE_PGE)) { - cr4 = __read_cr4(); - __write_cr4(cr4 & ~X86_CR4_PGE); - } - - /* Flush all TLBs via a mov %cr3, %reg; mov %reg, %cr3 */ - count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); - flush_tlb_local(); - /* Save MTRR state */ rdmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); /* Disable MTRRs, and set the default type to uncached */ mtrr_wrmsr(MSR_MTRRdefType, deftype_lo & ~0xcff, deftype_hi); - - /* Again, only flush caches if we have to. */ - if (!static_cpu_has(X86_FEATURE_SELFSNOOP)) - wbinvd(); } -static void post_set(void) __releases(set_atomicity_lock) +void mtrr_enable(void) { - /* Flush TLBs (no need to flush caches - they are disabled) */ - count_vm_tlb_event(NR_TLB_LOCAL_FLUSH_ALL); - flush_tlb_local(); - /* Intel (P6) standard MTRRs */ mtrr_wrmsr(MSR_MTRRdefType, deftype_lo, deftype_hi); - - /* Enable caches */ - write_cr0(read_cr0() & ~X86_CR0_CD); - - /* Restore value of CR4 */ - if (boot_cpu_has(X86_FEATURE_PGE)) - __write_cr4(cr4); - raw_spin_unlock(&set_atomicity_lock); } static void generic_set_all(void) @@ -797,7 +733,7 @@ static void generic_set_all(void) unsigned long flags; local_irq_save(flags); - prepare_set(); + cache_disable(); /* Actually set the state */ mask = set_mtrr_state(); @@ -805,7 +741,7 @@ static void generic_set_all(void) /* also set PAT */ pat_init(); - post_set(); + cache_enable(); local_irq_restore(flags); /* Use the atomic bitops to update the global mask */ @@ -836,7 +772,7 @@ static void generic_set_mtrr(unsigned int reg, unsigned long base, vr = &mtrr_state.var_ranges[reg]; local_irq_save(flags); - prepare_set(); + cache_disable(); if (size == 0) { /* @@ -855,7 +791,7 @@ static void generic_set_mtrr(unsigned int reg, unsigned long base, mtrr_wrmsr(MTRRphysMask_MSR(reg), vr->mask_lo, vr->mask_hi); } - post_set(); + cache_enable(); local_irq_restore(flags); } -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368263.599476 (Exim 4.92) (envelope-from ) id 1oCMGS-0001RG-Jo; Fri, 15 Jul 2022 14:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368263.599476; Fri, 15 Jul 2022 14:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGS-0001R9-EK; Fri, 15 Jul 2022 14:25:56 +0000 Received: by outflank-mailman (input) for mailman id 368263; Fri, 15 Jul 2022 14:25:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGR-0001BV-Ae for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 14:25:55 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [2001:67c:2178:6::1c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0891baf6-044a-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 16:25:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 80F2934DD4; Fri, 15 Jul 2022 14:25:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1D52B13754; Fri, 15 Jul 2022 14:25:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id +OLnBfF40WK+QQAAMHmgww (envelope-from ); Fri, 15 Jul 2022 14:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0891baf6-044a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657895153; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xntJCVnqXRvk9vE3Jl/BFSzPfnA84i+bvpB8MsbTJGc=; b=lOgqztde0SbRvIEqM6HAvbK3tjPLn1bvAuQVuCXa9oRPJPnmWvKxrugSZxsdfLzsOOX/dl R2FwYYKg48SifuMNapYEea3ILYC/mlWR0DFoBH9jjhbI3Oriu1ZjiY+MtSyhjtmuSSAmsJ 5k0k4Q/GW+N3aIW6S88sM87/E5K8kIc= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: brchuckz@netscape.net, jbeulich@suse.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek , stable@vger.kernel.org Subject: [PATCH 2/3] x86: add wrapper functions for mtrr functions handling also pat Date: Fri, 15 Jul 2022 16:25:48 +0200 Message-Id: <20220715142549.25223-3-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220715142549.25223-1-jgross@suse.com> References: <20220715142549.25223-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit There are several MTRR functions which also do PAT handling. In order to support PAT handling without MTRR in the future, add some wrappers for those functions. Cc: # 5.17 Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") Signed-off-by: Juergen Gross --- arch/x86/include/asm/mtrr.h | 2 -- arch/x86/include/asm/processor.h | 7 +++++ arch/x86/kernel/cpu/common.c | 44 +++++++++++++++++++++++++++++++- arch/x86/kernel/cpu/mtrr/mtrr.c | 25 +++--------------- arch/x86/kernel/setup.c | 5 +--- arch/x86/kernel/smpboot.c | 8 +++--- arch/x86/power/cpu.c | 2 +- 7 files changed, 59 insertions(+), 34 deletions(-) diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 12a16caed395..900083ac9f60 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -43,7 +43,6 @@ extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); extern void mtrr_ap_init(void); -extern void set_mtrr_aps_delayed_init(void); extern void mtrr_aps_init(void); extern void mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); @@ -86,7 +85,6 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } #define mtrr_ap_init() do {} while (0) -#define set_mtrr_aps_delayed_init() do {} while (0) #define mtrr_aps_init() do {} while (0) #define mtrr_bp_restore() do {} while (0) #define mtrr_disable() do {} while (0) diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index 5c934b922450..e2140204fb7e 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -865,7 +865,14 @@ bool arch_is_platform_page(u64 paddr); #define arch_is_platform_page arch_is_platform_page #endif +extern bool cache_aps_delayed_init; + void cache_disable(void); void cache_enable(void); +void cache_bp_init(void); +void cache_ap_init(void); +void cache_set_aps_delayed_init(void); +void cache_aps_init(void); +void cache_bp_restore(void); #endif /* _ASM_X86_PROCESSOR_H */ diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index e43322f8a4ef..0a1bd14f7966 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -1929,7 +1929,7 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) #ifdef CONFIG_X86_32 enable_sep_cpu(); #endif - mtrr_ap_init(); + cache_ap_init(); validate_apic_and_package_id(c); x86_spec_ctrl_setup_ap(); update_srbds_msr(); @@ -2403,3 +2403,45 @@ void cache_enable(void) __releases(cache_disable_lock) raw_spin_unlock(&cache_disable_lock); } + +void __init cache_bp_init(void) +{ + if (IS_ENABLED(CONFIG_MTRR)) + mtrr_bp_init(); + else + pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); +} + +void cache_ap_init(void) +{ + if (cache_aps_delayed_init) + return; + + mtrr_ap_init(); +} + +bool cache_aps_delayed_init; + +void cache_set_aps_delayed_init(void) +{ + cache_aps_delayed_init = true; +} + +void cache_aps_init(void) +{ + /* + * Check if someone has requested the delay of AP cache initialization, + * by doing cache_set_aps_delayed_init(), prior to this point. If not, + * then we are done. + */ + if (!cache_aps_delayed_init) + return; + + mtrr_aps_init(); + cache_aps_delayed_init = false; +} + +void cache_bp_restore(void) +{ + mtrr_bp_restore(); +} diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index 2746cac9d8a9..c1593cfae641 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -69,7 +69,6 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; static DEFINE_MUTEX(mtrr_mutex); u64 size_or_mask, size_and_mask; -static bool mtrr_aps_delayed_init; static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; @@ -176,7 +175,8 @@ static int mtrr_rendezvous_handler(void *info) if (data->smp_reg != ~0U) { mtrr_if->set(data->smp_reg, data->smp_base, data->smp_size, data->smp_type); - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { + } else if ((use_intel() && cache_aps_delayed_init) || + !cpu_online(smp_processor_id())) { mtrr_if->set_all(); } return 0; @@ -789,7 +789,7 @@ void mtrr_ap_init(void) if (!mtrr_enabled()) return; - if (!use_intel() || mtrr_aps_delayed_init) + if (!use_intel()) return; /* @@ -823,16 +823,6 @@ void mtrr_save_state(void) smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); } -void set_mtrr_aps_delayed_init(void) -{ - if (!mtrr_enabled()) - return; - if (!use_intel()) - return; - - mtrr_aps_delayed_init = true; -} - /* * Delayed MTRR initialization for all AP's */ @@ -841,16 +831,7 @@ void mtrr_aps_init(void) if (!use_intel() || !mtrr_enabled()) return; - /* - * Check if someone has requested the delay of AP MTRR initialization, - * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, - * then we are done. - */ - if (!mtrr_aps_delayed_init) - return; - set_mtrr(~0U, 0, 0, 0); - mtrr_aps_delayed_init = false; } void mtrr_bp_restore(void) diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index bd6c6fd373ae..27d61f73c68a 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -1001,10 +1001,7 @@ void __init setup_arch(char **cmdline_p) max_pfn = e820__end_of_ram_pfn(); /* update e820 for memory not covered by WB MTRRs */ - if (IS_ENABLED(CONFIG_MTRR)) - mtrr_bp_init(); - else - pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); + cache_bp_init(); if (mtrr_trim_uncached_memory(max_pfn)) max_pfn = e820__end_of_ram_pfn(); diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 5e7f9532a10d..535d73a47062 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1432,7 +1432,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) uv_system_init(); - set_mtrr_aps_delayed_init(); + cache_set_aps_delayed_init(); smp_quirk_init_udelay(); @@ -1443,12 +1443,12 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) void arch_thaw_secondary_cpus_begin(void) { - set_mtrr_aps_delayed_init(); + cache_set_aps_delayed_init(); } void arch_thaw_secondary_cpus_end(void) { - mtrr_aps_init(); + cache_aps_init(); } /* @@ -1491,7 +1491,7 @@ void __init native_smp_cpus_done(unsigned int max_cpus) nmi_selftest(); impress_friends(); - mtrr_aps_init(); + cache_aps_init(); } static int __initdata setup_possible_cpus = -1; diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c index bb176c72891c..21e014715322 100644 --- a/arch/x86/power/cpu.c +++ b/arch/x86/power/cpu.c @@ -261,7 +261,7 @@ static void notrace __restore_processor_state(struct saved_context *ctxt) do_fpu_end(); tsc_verify_tsc_adjust(true); x86_platform.restore_sched_clock_state(); - mtrr_bp_restore(); + cache_bp_restore(); perf_restore_debug_store(); c = &cpu_data(smp_processor_id()); -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368265.599486 (Exim 4.92) (envelope-from ) id 1oCMGT-0001cu-AW; Fri, 15 Jul 2022 14:25:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368265.599486; Fri, 15 Jul 2022 14:25:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGT-0001a5-3b; Fri, 15 Jul 2022 14:25:57 +0000 Received: by outflank-mailman (input) for mailman id 368265; Fri, 15 Jul 2022 14:25:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGS-0001BV-42 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 14:25:56 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08dfd06d-044a-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 16:25:54 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F419634DD5; Fri, 15 Jul 2022 14:25:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 89D0F13754; Fri, 15 Jul 2022 14:25:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id WJg6IPF40WK+QQAAMHmgww (envelope-from ); Fri, 15 Jul 2022 14:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08dfd06d-044a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657895154; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vwUbrqUUHvFoVh3Zv7qCqQxs3hoqoCxPCyuEJqRoUEM=; b=ANCRktCNdbwJrH1JJDcdGCzxaLCVeh7q2T72wPJjvT6lgNoOU4jRPubM60FZJ0pFrZQyLu 6Ka5m5KPYPmolEHu7zfcIXo5p3SnSBIP3r5SzvByFDah0ynL6x2M5mFCiilSfsV4zPjePI j2kL3wL2uTim4xmH1slYYf1MYzImfmo= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: brchuckz@netscape.net, jbeulich@suse.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky , stable@vger.kernel.org Subject: [PATCH 3/3] x86: decouple pat and mtrr handling Date: Fri, 15 Jul 2022 16:25:49 +0200 Message-Id: <20220715142549.25223-4-jgross@suse.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20220715142549.25223-1-jgross@suse.com> References: <20220715142549.25223-1-jgross@suse.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today PAT is usable only with MTRR being active, with some nasty tweaks to make PAT usable when running as Xen PV guest, which doesn't support MTRR. The reason for this coupling is, that both, PAT MSR changes and MTRR changes, require a similar sequence and so full PAT support was added using the already available MTRR handling. Xen PV PAT handling can work without MTRR, as it just needs to consume the PAT MSR setting done by the hypervisor without the ability and need to change it. This in turn has resulted in a convoluted initialization sequence and wrong decisions regarding cache mode availability due to misguiding PAT availability flags. Fix all of that by allowing to use PAT without MTRR and by adding an environment dependent PAT init function. Cc: # 5.17 Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") Signed-off-by: Juergen Gross --- arch/x86/include/asm/memtype.h | 13 ++- arch/x86/include/asm/mtrr.h | 21 +++-- arch/x86/kernel/cpu/common.c | 13 +-- arch/x86/kernel/cpu/mtrr/generic.c | 14 ---- arch/x86/kernel/cpu/mtrr/mtrr.c | 33 ++++---- arch/x86/kernel/cpu/mtrr/mtrr.h | 1 - arch/x86/kernel/setup.c | 7 -- arch/x86/mm/pat/memtype.c | 127 +++++++++++++++++++++-------- arch/x86/xen/enlighten_pv.c | 4 + 9 files changed, 146 insertions(+), 87 deletions(-) diff --git a/arch/x86/include/asm/memtype.h b/arch/x86/include/asm/memtype.h index 9ca760e430b9..93ad980631dc 100644 --- a/arch/x86/include/asm/memtype.h +++ b/arch/x86/include/asm/memtype.h @@ -8,7 +8,18 @@ extern bool pat_enabled(void); extern void pat_disable(const char *reason); extern void pat_init(void); -extern void init_cache_modes(void); +#ifdef CONFIG_X86_PAT +void pat_init_set(void (*func)(void)); +void pat_init_noset(void); +void pat_cpu_init(void); +void pat_ap_init_nomtrr(void); +void pat_aps_init_nomtrr(void); +#else +#define pat_init_set(f) do { } while (0) +#define pat_cpu_init(f) do { } while (0) +#define pat_ap_init_nomtrr(f) do { } while (0) +#define pat_aps_init_nomtrr(f) do { } while (0) +#endif extern int memtype_reserve(u64 start, u64 end, enum page_cache_mode req_pcm, enum page_cache_mode *ret_pcm); diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h index 900083ac9f60..bb76e5c6e21d 100644 --- a/arch/x86/include/asm/mtrr.h +++ b/arch/x86/include/asm/mtrr.h @@ -42,9 +42,9 @@ extern int mtrr_add_page(unsigned long base, unsigned long size, extern int mtrr_del(int reg, unsigned long base, unsigned long size); extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); -extern void mtrr_ap_init(void); -extern void mtrr_aps_init(void); -extern void mtrr_bp_restore(void); +extern bool mtrr_ap_init(void); +extern bool mtrr_aps_init(void); +extern bool mtrr_bp_restore(void); extern int mtrr_trim_uncached_memory(unsigned long end_pfn); extern int amd_special_default_mtrr(void); void mtrr_disable(void); @@ -84,9 +84,18 @@ static inline int mtrr_trim_uncached_memory(unsigned long end_pfn) static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) { } -#define mtrr_ap_init() do {} while (0) -#define mtrr_aps_init() do {} while (0) -#define mtrr_bp_restore() do {} while (0) +static inline bool mtrr_ap_init(void) +{ + return false; +} +static inline bool mtrr_aps_init(void) +{ + return false; +} +static inline bool mtrr_bp_restore(void) +{ + return false; +} #define mtrr_disable() do {} while (0) #define mtrr_enable() do {} while (0) # endif diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c index 0a1bd14f7966..3edfb779dab5 100644 --- a/arch/x86/kernel/cpu/common.c +++ b/arch/x86/kernel/cpu/common.c @@ -2408,8 +2408,8 @@ void __init cache_bp_init(void) { if (IS_ENABLED(CONFIG_MTRR)) mtrr_bp_init(); - else - pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); + + pat_cpu_init(); } void cache_ap_init(void) @@ -2417,7 +2417,8 @@ void cache_ap_init(void) if (cache_aps_delayed_init) return; - mtrr_ap_init(); + if (!mtrr_ap_init()) + pat_ap_init_nomtrr(); } bool cache_aps_delayed_init; @@ -2437,11 +2438,13 @@ void cache_aps_init(void) if (!cache_aps_delayed_init) return; - mtrr_aps_init(); + if (!mtrr_aps_init()) + pat_aps_init_nomtrr(); cache_aps_delayed_init = false; } void cache_bp_restore(void) { - mtrr_bp_restore(); + if (!mtrr_bp_restore()) + pat_cpu_init(); } diff --git a/arch/x86/kernel/cpu/mtrr/generic.c b/arch/x86/kernel/cpu/mtrr/generic.c index 84732215b61d..bb6dd96923a4 100644 --- a/arch/x86/kernel/cpu/mtrr/generic.c +++ b/arch/x86/kernel/cpu/mtrr/generic.c @@ -441,20 +441,6 @@ static void __init print_mtrr_state(void) pr_debug("TOM2: %016llx aka %lldM\n", mtrr_tom2, mtrr_tom2>>20); } -/* PAT setup for BP. We need to go through sync steps here */ -void __init mtrr_bp_pat_init(void) -{ - unsigned long flags; - - local_irq_save(flags); - cache_disable(); - - pat_init(); - - cache_enable(); - local_irq_restore(flags); -} - /* Grab all of the MTRR state for this CPU into *state */ bool __init get_mtrr_state(void) { diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c index c1593cfae641..76b1553d90f9 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.c +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c @@ -762,9 +762,6 @@ void __init mtrr_bp_init(void) /* BIOS may override */ __mtrr_enabled = get_mtrr_state(); - if (mtrr_enabled()) - mtrr_bp_pat_init(); - if (mtrr_cleanup(phys_addr)) { changed_by_mtrr_cleanup = 1; mtrr_if->set_all(); @@ -772,25 +769,17 @@ void __init mtrr_bp_init(void) } } - if (!mtrr_enabled()) { + if (!mtrr_enabled()) pr_info("Disabled\n"); - - /* - * PAT initialization relies on MTRR's rendezvous handler. - * Skip PAT init until the handler can initialize both - * features independently. - */ - pat_disable("MTRRs disabled, skipping PAT initialization too."); - } } -void mtrr_ap_init(void) +bool mtrr_ap_init(void) { if (!mtrr_enabled()) - return; + return false; if (!use_intel()) - return; + return false; /* * Ideally we should hold mtrr_mutex here to avoid mtrr entries @@ -806,6 +795,8 @@ void mtrr_ap_init(void) * lock to prevent mtrr entry changes */ set_mtrr_from_inactive_cpu(~0U, 0, 0, 0); + + return true; } /** @@ -826,20 +817,24 @@ void mtrr_save_state(void) /* * Delayed MTRR initialization for all AP's */ -void mtrr_aps_init(void) +bool mtrr_aps_init(void) { if (!use_intel() || !mtrr_enabled()) - return; + return false; set_mtrr(~0U, 0, 0, 0); + + return true; } -void mtrr_bp_restore(void) +bool mtrr_bp_restore(void) { if (!use_intel() || !mtrr_enabled()) - return; + return false; mtrr_if->set_all(); + + return true; } static int __init mtrr_init_finialize(void) diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.h b/arch/x86/kernel/cpu/mtrr/mtrr.h index 2ac99e561181..f6135a539073 100644 --- a/arch/x86/kernel/cpu/mtrr/mtrr.h +++ b/arch/x86/kernel/cpu/mtrr/mtrr.h @@ -53,7 +53,6 @@ void set_mtrr_prepare_save(struct set_mtrr_context *ctxt); void fill_mtrr_var_range(unsigned int index, u32 base_lo, u32 base_hi, u32 mask_lo, u32 mask_hi); bool get_mtrr_state(void); -void mtrr_bp_pat_init(void); extern void __init set_mtrr_ops(const struct mtrr_ops *ops); diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c index 27d61f73c68a..14bb40cd22c6 100644 --- a/arch/x86/kernel/setup.c +++ b/arch/x86/kernel/setup.c @@ -1008,13 +1008,6 @@ void __init setup_arch(char **cmdline_p) max_possible_pfn = max_pfn; - /* - * This call is required when the CPU does not support PAT. If - * mtrr_bp_init() invoked it already via pat_init() the call has no - * effect. - */ - init_cache_modes(); - /* * Define random base addresses for memory sections after max_pfn is * defined and before each memory section base is used. diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c index d5ef64ddd35e..3d4bc27ffebb 100644 --- a/arch/x86/mm/pat/memtype.c +++ b/arch/x86/mm/pat/memtype.c @@ -41,6 +41,7 @@ #include #include #include +#include #include #include @@ -65,30 +66,23 @@ static bool __read_mostly pat_disabled = !IS_ENABLED(CONFIG_X86_PAT); static bool __read_mostly pat_bp_enabled; static bool __read_mostly pat_cm_initialized; -/* - * PAT support is enabled by default, but can be disabled for - * various user-requested or hardware-forced reasons: - */ -void pat_disable(const char *msg_reason) -{ - if (pat_disabled) - return; +static void init_cache_modes(void); - if (pat_bp_initialized) { - WARN_ONCE(1, "x86/PAT: PAT cannot be disabled after initialization\n"); - return; - } - - pat_disabled = true; - pr_info("x86/PAT: %s\n", msg_reason); +#ifdef CONFIG_X86_PAT +static void pat_init_nopat(void) +{ + init_cache_modes(); } static int __init nopat(char *str) { - pat_disable("PAT support disabled via boot option."); + pat_disabled = true; + pr_info("PAT support disabled via boot option."); + pat_init_set(pat_init_nopat); return 0; } early_param("nopat", nopat); +#endif bool pat_enabled(void) { @@ -243,13 +237,17 @@ static void pat_bp_init(u64 pat) u64 tmp_pat; if (!boot_cpu_has(X86_FEATURE_PAT)) { - pat_disable("PAT not supported by the CPU."); + pr_info("PAT not supported by the CPU."); + pat_disabled = true; + pat_init_set(pat_init_nopat); return; } rdmsrl(MSR_IA32_CR_PAT, tmp_pat); if (!tmp_pat) { - pat_disable("PAT support disabled by the firmware."); + pr_info("PAT support disabled by the firmware."); + pat_disabled = true; + pat_init_set(pat_init_nopat); return; } @@ -272,7 +270,7 @@ static void pat_ap_init(u64 pat) wrmsrl(MSR_IA32_CR_PAT, pat); } -void init_cache_modes(void) +static void init_cache_modes(void) { u64 pat = 0; @@ -318,25 +316,12 @@ void init_cache_modes(void) __init_cache_modes(pat); } -/** - * pat_init - Initialize the PAT MSR and PAT table on the current CPU - * - * This function initializes PAT MSR and PAT table with an OS-defined value - * to enable additional cache attributes, WC, WT and WP. - * - * This function must be called on all CPUs using the specific sequence of - * operations defined in Intel SDM. mtrr_rendezvous_handler() provides this - * procedure for PAT. - */ -void pat_init(void) +#ifdef CONFIG_X86_PAT +static void pat_init_native(void) { u64 pat; struct cpuinfo_x86 *c = &boot_cpu_data; -#ifndef CONFIG_X86_PAT - pr_info_once("x86/PAT: PAT support disabled because CONFIG_X86_PAT is disabled in the kernel.\n"); -#endif - if (pat_disabled) return; @@ -406,6 +391,80 @@ void pat_init(void) #undef PAT +void pat_init_noset(void) +{ + pat_bp_enabled = true; + init_cache_modes(); +} + +static void (*pat_init_func)(void) = pat_init_native; + +void __init pat_init_set(void (*func)(void)) +{ + pat_init_func = func; +} + +/** + * pat_init - Initialize the PAT MSR and PAT table on the current CPU + * + * This function initializes PAT MSR and PAT table with an OS-defined value + * to enable additional cache attributes, WC, WT and WP. + * + * This function must be called on all CPUs using the specific sequence of + * operations defined in Intel SDM. mtrr_rendezvous_handler() provides this + * procedure for PAT. + */ +void pat_init(void) +{ + pat_init_func(); +} + +static int __pat_cpu_init(void *data) +{ + unsigned long flags; + + local_irq_save(flags); + cache_disable(); + + pat_init(); + + cache_enable(); + local_irq_restore(flags); + + return 0; +} + +void pat_cpu_init(void) +{ + if (pat_init_func != pat_init_native) + pat_init(); + else + __pat_cpu_init(NULL); +} + +void pat_ap_init_nomtrr(void) +{ + if (pat_init_func != pat_init_native) + return; + + stop_machine_from_inactive_cpu(__pat_cpu_init, NULL, cpu_callout_mask); +} + +void pat_aps_init_nomtrr(void) +{ + if (pat_init_func != pat_init_native) + return; + + stop_machine(__pat_cpu_init, NULL, cpu_online_mask); +} +#else +void pat_init(void) +{ + pr_info_once("x86/PAT: PAT support disabled because CONFIG_X86_PAT is disabled in the kernel.\n"); + init_cache_modes(); +} +#endif /* CONFIG_X86_PAT */ + static DEFINE_SPINLOCK(memtype_lock); /* protects memtype accesses */ /* diff --git a/arch/x86/xen/enlighten_pv.c b/arch/x86/xen/enlighten_pv.c index 70fb2ea85e90..97831d822872 100644 --- a/arch/x86/xen/enlighten_pv.c +++ b/arch/x86/xen/enlighten_pv.c @@ -69,6 +69,7 @@ #include #include #include +#include #ifdef CONFIG_X86_IOPL_IOPERM #include #endif @@ -1317,6 +1318,9 @@ asmlinkage __visible void __init xen_start_kernel(struct start_info *si) initrd_start = __pa(xen_start_info->mod_start); } + /* Don't try to modify PAT MSR. */ + pat_init_set(pat_init_noset); + /* Poke various useful things into boot_params */ boot_params.hdr.type_of_loader = (9 << 4) | 0; boot_params.hdr.ramdisk_image = initrd_start; -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:25:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:25:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368262.599463 (Exim 4.92) (envelope-from ) id 1oCMGR-0001Bd-8z; Fri, 15 Jul 2022 14:25:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368262.599463; Fri, 15 Jul 2022 14:25:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGR-0001BW-6P; Fri, 15 Jul 2022 14:25:55 +0000 Received: by outflank-mailman (input) for mailman id 368262; Fri, 15 Jul 2022 14:25:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMGQ-0001BP-Gq for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 14:25:54 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 083c71fe-044a-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 16:25:53 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B7E1134DD1; Fri, 15 Jul 2022 14:25:52 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2F88F13754; Fri, 15 Jul 2022 14:25:52 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wkAkCvB40WK+QQAAMHmgww (envelope-from ); Fri, 15 Jul 2022 14:25:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 083c71fe-044a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1657895152; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Tle2lhJhQp2g1mDXUt7ZR3944PM4JXbq65HXWxNQb9s=; b=Q72RTBuD7k4s6+lQaBTvP7XBaVckub1f8rXxhmEYqk15ECh+YhcXULfMBDLX5wgm3sUevt Sy7CZREhmcgK5mvyF/r2pt77ayU0bXXrwGbDnpImxAQ+rgRtXXPu8V7PVQ1DGDimwk99Ch U5mq93BlCh5EhiuDrT92+X1e6paGPnE= From: Juergen Gross To: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: brchuckz@netscape.net, jbeulich@suse.com, Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky Subject: [PATCH 0/3] x86: make pat and mtrr independent from each other Date: Fri, 15 Jul 2022 16:25:46 +0200 Message-Id: <20220715142549.25223-1-jgross@suse.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today PAT can't be used without MTRR being available, unless MTRR is at least configured via CONFIG_MTRR and the system is running as Xen PV guest. In this case PAT is automatically available via the hypervisor, but the PAT MSR can't be modified by the kernel and MTRR is disabled. As an additional complexity the availability of PAT can't be queried via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT to be disabled. This leads to some drivers believing that not all cache modes are available, resulting in failures or degraded functionality. The same applies to a kernel built with no MTRR support: it won't allow to use the PAT MSR, even if there is no technical reason for that, other than setting up PAT on all cpus the same way (which is a requirement of the processor's cache management) is relying on some MTRR specific code. Fix all of that by: - moving the function needed by PAT from MTRR specific code one level up - adding a PAT indirection layer supporting the 3 cases "no or disabled PAT", "PAT under kernel control", and "PAT under Xen control" - removing the dependency of PAT on MTRR Juergen Gross (3): x86: move some code out of arch/x86/kernel/cpu/mtrr x86: add wrapper functions for mtrr functions handling also pat x86: decouple pat and mtrr handling arch/x86/include/asm/memtype.h | 13 ++- arch/x86/include/asm/mtrr.h | 27 ++++-- arch/x86/include/asm/processor.h | 10 +++ arch/x86/kernel/cpu/common.c | 123 +++++++++++++++++++++++++++- arch/x86/kernel/cpu/mtrr/generic.c | 90 ++------------------ arch/x86/kernel/cpu/mtrr/mtrr.c | 58 ++++--------- arch/x86/kernel/cpu/mtrr/mtrr.h | 1 - arch/x86/kernel/setup.c | 12 +-- arch/x86/kernel/smpboot.c | 8 +- arch/x86/mm/pat/memtype.c | 127 +++++++++++++++++++++-------- arch/x86/power/cpu.c | 2 +- arch/x86/xen/enlighten_pv.c | 4 + 12 files changed, 289 insertions(+), 186 deletions(-) -- 2.35.3 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 14:40:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 14:40:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368295.599508 (Exim 4.92) (envelope-from ) id 1oCMU8-0005k3-Re; Fri, 15 Jul 2022 14:40:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368295.599508; Fri, 15 Jul 2022 14:40:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMU8-0005jU-N0; Fri, 15 Jul 2022 14:40:04 +0000 Received: by outflank-mailman (input) for mailman id 368295; Fri, 15 Jul 2022 14:40:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCMU6-0005MK-RK for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 14:40:03 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 010a2231-044c-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 16:40:00 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id bu42so8205819lfb.0 for ; Fri, 15 Jul 2022 07:40:00 -0700 (PDT) Received: from jade (h-79-136-84-253.A175.priv.bahnhof.se. [79.136.84.253]) by smtp.gmail.com with ESMTPSA id u10-20020a05651220ca00b0048928d4317esm928763lfr.283.2022.07.15.07.39.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 07:39:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 010a2231-044c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=s0afabyc3zlzo2p3H9dwVzA8jc80JldBWht4J1fhr/s=; b=BC7srtOCGv46MD8PCFW7toISNqfO1h84zlN9pphfxTup1OWzTPj09xPbvOd2kOxyl1 GQZMl3kuYsOleHBqNOkV4rJTWjuotN68fyUqHHqlp3jvjJxP06bCsuPgX6fBTjb56tTb +3oj5RizPpMwwO+xSyzRFyrLqzf+4U4mWVfRWXj5sshKIIO7nZvuQqwc6j7hjg9z0YF7 usHmvlagdAz/DWEV911bp9i7ikNQMjjFzGE+9KRPsOG0maWxp3YsjccTlc6KWek3clnA qi6cG5GPC5aYd6vgfwGIkDTITSjGXep2gxRUsfrVAzBue/1Ky3MXvs9HZQlPaxlEr87t EulQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=s0afabyc3zlzo2p3H9dwVzA8jc80JldBWht4J1fhr/s=; b=t38Ke8iPhV3wCpnoqkWIoRkYT1fnTpvthVwWdCzsPhh3cNGB6iCahXMFUAKDLlPz14 o4aqDU0k7tZeQuUtxDNp7ZqwHLrKQiTQVRnrN/5OFeIICYTeClqTOL/PT5l/vB3F01Ip 4YmbDKCxuaRh9W5MlzgnaSLmwTgFBRV+OscGu6+t680GWhUha/RndZqcUwlvPWwquaGr 7sP402EafIWZV3thYxZrw13raXho/P+68zQi4ioMhym8m/RNomur0deqk0kKbyXdg9pp 9Bu9I6DHwI+JfZNX69cJqURikLjm7T+S+am2GFvKbTVMWEPClNzySDdUEnFifPzLCfID yRQQ== X-Gm-Message-State: AJIora/91nuUkQVCP2AeZ4i57eP0qh8nEwrBbvQ6hE8yLA/4Bs9T7Y8q aUMk1Yjt5DSiNpgl8q8a5g47BA== X-Google-Smtp-Source: AGRyM1vN4acv/T8Wqjs/1RtwcXZEe+3+htrjdex0WpSt4UMiA3EI/YFEKjkG1C3DvVTeR9aoFPGteQ== X-Received: by 2002:a05:6512:280f:b0:48a:26a2:db16 with SMTP id cf15-20020a056512280f00b0048a26a2db16mr1245152lfb.251.1657895999317; Fri, 15 Jul 2022 07:39:59 -0700 (PDT) Date: Fri, 15 Jul 2022 16:39:56 +0200 From: Jens Wiklander To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator Message-ID: <20220715143956.GA4099005@jade> References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> Hi Julien, On Fri, Jul 08, 2022 at 02:40:56PM +0100, Julien Grall wrote: > Hi Jens, > > I haven't checked whether the FFA driver is complaint with the spec. I > mainly checked whether the code makes sense from Xen PoV. > > This is a fairly long patch to review. So I will split my review in multiple > session/e-mail. Thanks for the comments. It's going to take a bit longer than I first thought to go through and respond. I'll get back once I'm though it. Thanks, Jens > > On 22/06/2022 14:42, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the bare minimum to be able to communicate with > > OP-TEE running as an SPMC at S-EL1. > > > > This is loosely based on the TEE mediator framework and the OP-TEE > > mediator. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > --- > > SUPPORT.md | 7 + > > tools/libs/light/libxl_arm.c | 3 + > > tools/libs/light/libxl_types.idl | 1 + > > tools/xl/xl_parse.c | 3 + > > These changes would need an ack from the toolstack maintainers. > > > xen/arch/arm/Kconfig | 11 + > > xen/arch/arm/Makefile | 1 + > > xen/arch/arm/domain.c | 10 + > > xen/arch/arm/domain_build.c | 1 + > > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > > xen/arch/arm/include/asm/domain.h | 4 + > > xen/arch/arm/include/asm/ffa.h | 71 ++ > > xen/arch/arm/vsmc.c | 17 +- > > xen/include/public/arch-arm.h | 2 + > > 13 files changed, 1811 insertions(+), 3 deletions(-) > > create mode 100644 xen/arch/arm/ffa.c > > create mode 100644 xen/arch/arm/include/asm/ffa.h > > > > diff --git a/SUPPORT.md b/SUPPORT.md > > index 70e98964cbc0..215bb3c9043b 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > No support for QEMU backends in a 16K or 64K domain. > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > > + > > + Status, Arm64: Tech Preview > > + > > +There are still some code paths where a vCPU may hog a pCPU longer than > > +necessary. The FF-A mediator is not yet implemented for Arm32. > > + > > ### ARM: Guest Device Tree support > > Status: Supported > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > > index eef1de093914..a985609861c7 100644 > > --- a/tools/libs/light/libxl_arm.c > > +++ b/tools/libs/light/libxl_arm.c > > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > > return ERROR_FAIL; > > } > > + config->arch.ffa_enabled = > > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > > + > > return 0; > > } > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index 2a42da2f7d78..bf4544bef399 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > + ("ffa_enabled", libxl_defbool), > > This needs to be accompagnied with a define LIBXL_HAVE_* in > tools/include/libxl.h. Please see the examples in the header. > > > ])), > > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > > ])), > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > > index b98c0de378b6..e0e99ed8d2b1 100644 > > --- a/tools/xl/xl_parse.c > > +++ b/tools/xl/xl_parse.c > > @@ -2746,6 +2746,9 @@ skip_usbdev: > > exit(-ERROR_FAIL); > > } > > } > > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > > + xlu_cfg_get_defbool(config, "ffa_enabled", > > + &b_info->arch_arm.ffa_enabled, 0); > > This option needs to be documented in docs/man/xl.cfg.5.pod.in. > > > parse_vkb_list(config, d_config); > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > index be9eff014120..e57e1d3757e2 100644 > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -139,6 +139,17 @@ config TEE > > source "arch/arm/tee/Kconfig" > > +config FFA > > + bool "Enable FF-A mediator support" if EXPERT > > + default n > > + depends on ARM_64 > > + help > > + This option enables a minimal FF-A mediator. The mediator is > > + generic as it follows the FF-A specification [1], but it only > > + implements a small subset of the specification. > > Where would a user be able to find which subset of the specification that > Xen implements? > > > + > > + [1] https://developer.arm.com/documentation/den0077/latest > > + > > endmenu > > menu "ARM errata workaround via the alternative framework" > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > > index bb7a6151c13c..af0c69f793d4 100644 > > --- a/xen/arch/arm/Makefile > > +++ b/xen/arch/arm/Makefile > > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > > obj-y += domctl.o > > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > > obj-y += efi/ > > +obj-$(CONFIG_FFA) += ffa.o > > obj-y += gic.o > > obj-y += gic-v2.o > > obj-$(CONFIG_GICV3) += gic-v3.o > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > index 8110c1df8638..a3f00e7e234d 100644 > > --- a/xen/arch/arm/domain.c > > +++ b/xen/arch/arm/domain.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > > goto fail; > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > > + goto fail; > > + > > update_domain_wallclock_time(d); > > /* > > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > > enum { > > PROG_pci = 1, > > PROG_tee, > > + PROG_ffa, > > PROG_xen, > > PROG_page, > > PROG_mapping, > > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > PROGRESS(tee): > > ret = tee_relinquish_resources(d); > > + if ( ret ) > > + return ret; > > + > > + PROGRESS(ffa): > > + ret = ffa_relinquish_resources(d); > > if (ret ) > > return ret; > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 7ddd16c26da5..d708f76356f7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > > if ( gic_number_lines() > 992 ) > > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > > dom0_cfg.arch.tee_type = tee_get_type(); > > + dom0_cfg.arch.ffa_enabled = true; > > AFAICT, ffa_enabled is a uint8_t. So we should use 1. However, I am not > convinced that using a uint8_t for what looks like a boolean is warrant. I > will detail more on the definition. > > > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > if ( iommu_enabled ) > > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > > new file mode 100644 > > index 000000000000..3117ce5cec4d > > --- /dev/null > > +++ b/xen/arch/arm/ffa.c > > @@ -0,0 +1,1683 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > > + * > > + * Copyright (C) 2022 Linaro Limited > > + * > > + * Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without restriction, > > + * including without limitation the rights to use, copy, modify, merge, > > + * publish, distribute, sublicense, and/or sell copies of the Software, > > + * and to permit persons to whom the Software is furnished to do so, > > + * subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > This doesn't look like to be a GPLv2 license. Can you clarify which license > you are using? > > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +/* Error codes */ > > All the #define below are using hard tab. Please use soft tab. > > > +#define FFA_RET_OK 0 > > +#define FFA_RET_NOT_SUPPORTED -1 > > +#define FFA_RET_INVALID_PARAMETERS -2 > > +#define FFA_RET_NO_MEMORY -3 > > +#define FFA_RET_BUSY -4 > > +#define FFA_RET_INTERRUPTED -5 > > +#define FFA_RET_DENIED -6 > > +#define FFA_RET_RETRY -7 > > +#define FFA_RET_ABORTED -8 > > + > > +/* FFA_VERSION helpers */ > > +#define FFA_VERSION_MAJOR _AC(1,U) > > NIT: The use of _AC() is a bit pointless given that you are only use the > values in C code. > > > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > > +#define FFA_VERSION_MINOR _AC(1,U) > > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > > +#define MAKE_FFA_VERSION(major, minor) \ > > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > > + ((minor) & FFA_VERSION_MINOR_MASK)) > > + > > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > > + FFA_VERSION_MINOR) > > NIT: I think it would be better that FFA_VERSION_MAJOR AND FFA_VERSION_MINOR > are defined closer to FFA_MY_VERSION and they are renamed to > FFA_MY_VERSION_*. > > I would also potentially move the 3 defines past all the definition related > to the specification. This would make clearer that this is what Xen > supports. > > > + > > + > > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) > > Coding style: You seem to use a mix of FOO(... , ...) and FOO(...,...). > At mimimum, please be consistent within the file. > > For Xen, we usually add a space after the comma. > > [...] > > > +/* > > + * Our rx/rx buffer shared with the SPMC > > + */ > > Hmmm... The comment seems to be misplaced. > > > +static uint32_t ffa_version; > > This probably can be __read_mostly. > > > +static uint16_t *subsr_vm_created; > > What subsr stand for? > > > +static unsigned int subsr_vm_created_count; > > +static uint16_t *subsr_vm_destroyed; > > +static unsigned int subsr_vm_destroyed_count; > > +static void *ffa_rx; > > +static void *ffa_tx; > > subsr_vm_created, subsr_vm_destroyed, ffa_rx and ffa_tx can probably be > __read_mostly. > > > +static unsigned int ffa_page_count; > > Is this related to ffa_rx? > > > +static DEFINE_SPINLOCK(ffa_buffer_lock); > > + > > +static LIST_HEAD(ffa_mem_list); > > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > > + > > +static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; > > next_handle only seems to be used handle_mem_share(). So I think it would be > better to move the definition (as static) within the function. > > This will reduce the number of global variables. > > > + > > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > > +{ > > + return (uint64_t)reg0 << 32 | reg1; > > +} > > + > > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > > + uint64_t val) > > +{ > > + *reg0 = val >> 32; > > + *reg1 = val; > > +} > > Those two functions are the same as optee.c but with a different. I would > rather prefer if we avoid the duplication and provide generic helpers in a > pre-requisite. > > > + > > +static bool ffa_get_version(uint32_t *vers) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_VERSION, .a1 = FFA_MY_VERSION, > > Coding sytle: Please set each field on their own line. > > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > > + { > > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > > + return false; > > + } > > + > > + *vers = resp.a0; > > Coding style: We tend to add a newline before the last return. I am not > necessarily going to comment about this on all the instances. So please have > a look through the code. > > > + return true; > > +} > > + > > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > > FFA_RET_* will be negative, so shouldn't this return int32_t? > > > +{ > > + switch ( resp->a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp->a2 ) > > + return resp->a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + return FFA_RET_OK; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_features(uint32_t id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_FEATURES, .a1 = id, }; > > Coding style. Please split each field on their own line. > > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static bool check_mandatory_feature(uint32_t id) > > +{ > > + uint32_t ret = ffa_features(id); > > + > > + if (ret) > > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); > > + return !ret; > > +} > > + > > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > > + uint32_t page_count) > > Aside the parameters, the helper looks very similar to ffa_features(), > ffa_rxtx_unmap(). Can this be abstracted? Maybe using macro if you still > want to have separate helper name. > > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > +#ifdef CONFIG_ARM_64 > > + .a0 = FFA_RXTX_MAP_64, > > +#endif > > +#ifdef CONFIG_ARM_32 > > + .a0 = FFA_RXTX_MAP_32, > > +#endif > > + .a1 = tx_addr, .a2 = rx_addr, > > Coding: Please don't use hard tab and put each field on their own line. > > > + .a3 = page_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_RXTX_UNMAP, .a1 = vm_id, > > Coding style. Please add each field on their own line. > > > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_PARTITION_INFO_GET, .a1 = w1, .a2 = w2, .a3 = w3, .a4 = w4, > > Ditto. > > > + .a5 = w5, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + uint32_t ret; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + ret = get_ffa_ret_code(&resp); > > + if ( !ret ) > > + *count = resp.a2; > > + > > + return ret; > > +} > > + > > +static uint32_t ffa_rx_release(void) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_RX_RELEASE, }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > > + register_t addr, uint32_t pg_count, > > + uint64_t *handle) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_SHARE_32, .a1 = tot_len, .a2 = frag_len, .a3 = addr, > > Ditto. > > > + .a4 = pg_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + /* > > + * For arm64 we must use 64-bit calling convention if the buffer isn't > > + * passed in our tx buffer. > > + */ > > Can you explain why we would want to use the 32-bit calling convention if > addr is 0? > > > + if (sizeof(addr) > 4 && addr) > > sizeof(addr) > 4 is a bit odd to read. I think it would be better to check > that CONFIG_ARM_64 is set (i.e. IS_ENABLED()). > > > + arg.a0 = FFA_MEM_SHARE_64; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + *handle = reg_pair_to_64(resp.a3, resp.a2); > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + *handle = reg_pair_to_64(resp.a2, resp.a1); > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > > + uint16_t sender_id) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_FRAG_TX, .a1 = handle & UINT32_MAX, .a2 = handle >> 32, > > + .a3 = frag_len, .a4 = (uint32_t)sender_id << 16, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > > + uint32_t flags) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_RECLAIM, .a1 = handle_lo, .a2 = handle_hi, .a3 = flags, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > > OOI, why is this call returns int32_t when all the other use uint32_t (even > if may returned negative values)? > > > + uint8_t msg) > > +{ > > + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; > > + int32_t res; > > + > > + if ( msg != FFA_MSG_SEND_VM_CREATED && msg !=FFA_MSG_SEND_VM_DESTROYED ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + if ( msg == FFA_MSG_SEND_VM_CREATED ) > > + exp_resp |= FFA_MSG_RESP_VM_CREATED; > > + else > > + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; > > NIT: I think it would be easier to read if you drop the first 'if' and > instead write: > > if ( msg == ..._CREATED ) > ... > else if ( msg == ..._DESTROYED ) > ... > else > return FFA_RET_INVALID_PARAMETERS. > > > + > > + do { > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, > > + .a1 = sp_id, > > + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, > > + .a5 = vm_id, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) > > + { > > + /* > > + * This is an invalid response, likely due to some error in the > > + * implementation of the ABI. > > + */ > > + return FFA_RET_INVALID_PARAMETERS; > > + } > > + res = resp.a3; > > + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); > > + > > + return res; > > +} > > + > > +static u16 get_vm_id(struct domain *d) > > d is not meant to be modified by the helper. So please use 'const'. > > > +{ > > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > > + return d->domain_id + 1; > > +} > > + > > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > > + register_t v2, register_t v3, register_t v4, register_t v5, > > + register_t v6, register_t v7) > > +{ > > + set_user_reg(regs, 0, v0); > > + set_user_reg(regs, 1, v1); > > + set_user_reg(regs, 2, v2); > > + set_user_reg(regs, 3, v3); > > + set_user_reg(regs, 4, v4); > > + set_user_reg(regs, 5, v5); > > + set_user_reg(regs, 6, v6); > > + set_user_reg(regs, 7, v7); > > +} > > + > > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) > > +{ > > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > > + uint32_t w3) > > +{ > > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, > > + uint32_t handle_hi, uint32_t frag_offset, > > + uint16_t sender_id) > > +{ > > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > > + (uint32_t)sender_id << 16, 0, 0, 0); > > +} > > + > > +static void handle_version(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t vers = get_user_reg(regs, 1); > > + > > + if ( vers < FFA_VERSION_1_1 ) > > + vers = FFA_VERSION_1_0; > > + else > > + vers = FFA_VERSION_1_1; > > I find a bit strange to 'cap' the version provided by the user. Is this part > of the spec? > > > + > > + ctx->guest_vers = vers; > > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > > +} > > + > > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > > + register_t rx_addr, uint32_t page_count) > > Xen, Linux, and the firmware may use different page size. Below, you seem to > have the page size will always be 4KB. Is this guaranteed by the spec? If > not, how do all the 3 components agree on it? > > If yes, then I think this should be written down and we should have a > BUILD_BUG_ON(PAGE_SIZE != SZ_4K). > > > +{ > > + uint32_t ret = FFA_RET_INVALID_PARAMETERS; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + struct page_info *tx_pg; > > + struct page_info *rx_pg; > > + p2m_type_t t; > > + void *rx; > > + void *tx; > > + > > + if ( !smccc_is_conv_64(fid) ) > > + { > > + tx_addr &= UINT32_MAX; > > + rx_addr &= UINT32_MAX; > > + } > > + > > + /* For now to keep things simple, only deal with a single page */ > > + if ( page_count != 1 ) > > + return FFA_RET_NOT_SUPPORTED; > > + > > + /* Already mapped */ > > + if ( ctx->rx ) > > + return FFA_RET_DENIED; > > + > > + tx_pg = get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + return FFA_RET_INVALID_PARAMETERS; > > + /* Only normal RAM for now */ > > This comment suggests the check below should be p2m_is_ram() but you are > using p2m_ram_rw. > > > + if (t != p2m_ram_rw) > > Coding style: if ( ... ) > > > + goto err_put_tx_pg; > > + > > + rx_pg = get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + goto err_put_tx_pg; > > + /* Only normal RAM for now */ > > Same about the comment. > > > + if ( t != p2m_ram_rw ) > > + goto err_put_rx_pg; > > + > > + tx = __map_domain_page_global(tx_pg); > > + if ( !tx ) > > + goto err_put_rx_pg; > > + > > + rx = __map_domain_page_global(rx_pg); > > + if ( !rx ) > > + goto err_unmap_tx; > > + > > + ctx->rx = rx; > > + ctx->tx = tx; > > + ctx->rx_pg = rx_pg; > > + ctx->tx_pg = tx_pg; > > + ctx->page_count = 1; > > + ctx->tx_is_mine = true; > > + return FFA_RET_OK; > > + > > +err_unmap_tx: > > + unmap_domain_page_global(tx); > > +err_put_rx_pg: > > + put_page(rx_pg); > > +err_put_tx_pg: > > + put_page(tx_pg); > > + return ret; > > +} > > + > > +static uint32_t handle_rxtx_unmap(void) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t ret; > > + > > + if ( !ctx->rx ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + ret = ffa_rxtx_unmap(get_vm_id(d)); > > + if ( ret ) > > + return ret; > > + > > + unmap_domain_page_global(ctx->rx); > > + unmap_domain_page_global(ctx->tx); > > + put_page(ctx->rx_pg); > > + put_page(ctx->tx_pg); > > + ctx->rx = NULL; > > + ctx->tx = NULL; > > + ctx->rx_pg = NULL; > > + ctx->tx_pg = NULL; > > + ctx->page_count = 0; > > + ctx->tx_is_mine = false; > > + > > + return FFA_RET_OK; > > +} > > + > > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ffa_page_count ) > > + return FFA_RET_DENIED; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || !ctx->tx_is_mine ) > > + goto out; > > + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); > > + if ( ret ) > > + goto out; > > + if ( ctx->guest_vers == FFA_VERSION_1_0 ) > > + { > > + size_t n; > > + struct ffa_partition_info_1_1 *src = ffa_rx; > > + struct ffa_partition_info_1_0 *dst = ctx->rx; > > + > > + for ( n = 0; n < *count; n++ ) > > Who is going to sanitize 'count' and how do you make sure that... > > > + { > > + dst[n].id = src[n].id; > > ... this will still be written within the page provided by the domain? > > > + dst[n].execution_context = src[n].execution_context; > > + dst[n].partition_properties = src[n].partition_properties; > > + } > > + } > > + else > > + { > > + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); > > + > > + memcpy(ctx->rx, ffa_rx, sz); > > + } > > + ffa_rx_release(); > > I saw above that you are expecting the ffa_rx to be "locked". Will it be the > firmware to block another thread that may need ffa_rx? > > > + ctx->tx_is_mine = false; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static uint32_t handle_rx_release(void) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || ctx->tx_is_mine ) > > + goto out; > > + ret = FFA_RET_OK; > > + ctx->tx_is_mine = true; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; > > + struct arm_smccc_1_2_regs resp = { }; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t src_dst; > > + uint64_t mask; > > + > > + if ( smccc_is_conv_64(fid) ) > > + mask = 0xffffffffffffffff; > > + else > > + mask = 0xffffffff; > > Please use GENMASK() (or similar). So it is easier to confirm the number of > 'f' is correct. > > > + > > + src_dst = get_user_reg(regs, 1); > > + if ( (src_dst >> 16) != get_vm_id(d) ) > > + { > > + resp.a0 = FFA_ERROR; > > + resp.a2 = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + arg.a1 = src_dst; > > + arg.a2 = get_user_reg(regs, 2) & mask; > > + arg.a3 = get_user_reg(regs, 3) & mask; > > + arg.a4 = get_user_reg(regs, 4) & mask; > > + arg.a5 = get_user_reg(regs, 5) & mask; > > + arg.a6 = get_user_reg(regs, 6) & mask; > > + arg.a7 = get_user_reg(regs, 7) & mask; > > + > > + while ( true ) > > + { > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_INTERRUPT: > > + ctx->interrupted = true; > > + goto out; > > + case FFA_ERROR: > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + case FFA_MSG_SEND_DIRECT_RESP_32: > > + case FFA_MSG_SEND_DIRECT_RESP_64: > > + goto out; > > + default: > > + /* Bad fid, report back. */ > > + memset(&arg, 0, sizeof(arg)); > > + arg.a0 = FFA_ERROR; > > + arg.a1 = src_dst; > > + arg.a2 = FFA_RET_NOT_SUPPORTED; > > + continue; > > + } > > + } > > + > > +out: > > + set_user_reg(regs, 0, resp.a0); > > + set_user_reg(regs, 1, resp.a1 & mask); > > + set_user_reg(regs, 2, resp.a2 & mask); > > + set_user_reg(regs, 3, resp.a3 & mask); > > + set_user_reg(regs, 4, resp.a4 & mask); > > + set_user_reg(regs, 5, resp.a5 & mask); > > + set_user_reg(regs, 6, resp.a6 & mask); > > + set_user_reg(regs, 7, resp.a7 & mask); > > You have already an helper to set all the registers. Why not using it? > > > +} > > I will continue the rest of the review at a later point. > > Cheers, > > -- > Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 15:25:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 15:25:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368304.599519 (Exim 4.92) (envelope-from ) id 1oCNBj-00033L-Ax; Fri, 15 Jul 2022 15:25:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368304.599519; Fri, 15 Jul 2022 15:25:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNBj-00033E-7f; Fri, 15 Jul 2022 15:25:07 +0000 Received: by outflank-mailman (input) for mailman id 368304; Fri, 15 Jul 2022 15:25:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNBi-000338-6U for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 15:25:06 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4b6f546c-0452-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 17:25:03 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b6f546c-0452-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657898703; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=MuyVNov3n87qXgrxIOmnRgMHXtp5gciIjQXjAl81t+I=; b=X6DMvq+jalk5bCndZpGSitH+ljyBSRci7tLSh3/50yXtoRgTc3yN0R7Y S6VOIZ7JL5DSGkGPGoR6hFj4r3VaBLVKe4S6asloWqX4qneM0vbpqCap7 5uWbPVJp677aWi82nZxsexmJuUH0eHmOQR2jjFwPucHN6/G6MBiFijFM3 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 5.1 X-MesageID: 78464100 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:IFBlw6j/04VhRHqUhF7ZhHS6X161xRAKZh0ujC45NGQN5FlHY01je htvCGqCOarfYWL1L4gkPoW29B5S78SByN4wHlRlrytmQysb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur5WtD1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eYZIX9bYuIU537 NcmDTRcYCuNv7u1+efuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZCyYIaLJoXSHa25mG6am Hzcz23+LihBH9+Q4yGe30+3i8LQyHaTtIU6S+Tjq68CbEeo7m4ODBwbU3OrrP//jVSxM/pEM FAd8Ccqqak09WSoQ8P7Uhn+p2SL1jYiXN5XH/w/+Ru64KPe6AaEBUAJVjdELtchsaceQjgn1 USVjsjpLTNqubyRD3ma89+8pz6oJTIcK2NEYCYeVBYE+PHquoR1hRXKJv5hH7SylcbdAizrz naBqy1Wr5IXgM0Q3qO352f7kimsrZjESA0yzgjPV2fj5QR8DKa1aort5VXF4PJoKIeCUkLHr HUCg9KZ7u0FEdeKjiPlaP8KB7uz4PGGNhXThFduG98q8DHF02GnVZBd5nd5PkgBDyofUWa3O gmJ41oXvcINeivxBUNqX26vI5g1wqewTPTKb+n/UP9KM5ZKejfe/xg7MCZ8wFvRfFgQfbAXY MnGLpbwXClDUsyL3xLtGb5DjOZDKjQWgDqKGMull0nPPa+2Pib9dFsTDLeZggnVBougqR6dz dtQPtDiJ/53ALynOXm/HWL+wDk3wZkH6XPe8ZU/mhareFYOJY3YI6a5LUkdU4Jkhb9JsezD4 2uwXERVoHKm2yCYeV/ROiszMuy0NXqakZ7cFXV2VWtEJlB5Odr/hEvhX8FfkUYbGBxLkqcvE qhtlzSoCfVTUDXXkwkggW3GhNU6LnyD3FvWVwL8OWhXV8MxHGThp467FjYDAQFTV0JbQ+Nl+ Ob+vu4aKLJeLzlf4DH+M6P+lAPs5yFDyYqfnSLge7FuRakly6AyQwSZsxP9C5tkxcnrrtdC6 zurPA== IronPort-HdrOrdr: A9a23:Dus5WKAXXwFxOBDlHemq55DYdb4zR+YMi2TC1yhKJyC9Vvbo8/ xG+85rsiMc6QxhPU3I9ursBEDtex/hHNtOkO8s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U 4JSdkGNDSaNzlHZKjBjzWFLw== X-IronPort-AV: E=Sophos;i="5.92,274,1650945600"; d="scan'208";a="78464100" Date: Fri, 15 Jul 2022 16:24:49 +0100 From: Anthony PERARD To: Oleksandr Tyshchenko CC: George Dunlap , Juergen Gross , xen-devel , Wei Liu , "Nick Rosbrook" , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Oleksandr Subject: Re: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Message-ID: References: <62903b8e-6c20-600e-8283-5a3e3b853a18@gmail.com> <1655482471-16850-1-git-send-email-olekstysh@gmail.com> <9A36692A-8095-4C76-A69B-FBAB221A365C@citrix.com> <02648046-7781-61e5-de93-77342e4d6c16@gmail.com> <36d4c786-9fb7-4b30-1a4d-171f92cc84d7@gmail.com> <5fa04098-a3a0-a517-ca8c-19d45ecac63e@epam.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5fa04098-a3a0-a517-ca8c-19d45ecac63e@epam.com> On Wed, Jul 13, 2022 at 08:03:17AM +0000, Oleksandr Tyshchenko wrote: > > On 13.07.22 03:01, George Dunlap wrote: > > Hello George, Anthony > > > > > > >> On 30 Jun 2022, at 22:18, Oleksandr wrote: > >> > >> > >> Dear all. > >> > >> > >> On 25.06.22 17:32, Oleksandr wrote: > >>> > >>> On 24.06.22 15:59, George Dunlap wrote: > >>> > >>> Hello George > >>> > >>>> > >>>>> On 17 Jun 2022, at 17:14, Oleksandr Tyshchenko > >>>>> wrote: > >>>>> > >>>>> From: Oleksandr Tyshchenko > >>>>> > >>>>> This patch adds basic support for configuring and assisting > >>>>> virtio-mmio > >>>>> based virtio-disk backend (emulator) which is intended to run out of > >>>>> Qemu and could be run in any domain. > >>>>> Although the Virtio block device is quite different from traditional > >>>>> Xen PV block device (vbd) from the toolstack's point of view: > >>>>> - as the frontend is virtio-blk which is not a Xenbus driver, nothing > >>>>> written to Xenstore are fetched by the frontend currently ("vdev" > >>>>> is not passed to the frontend). But this might need to be revised > >>>>> in future, so frontend data might be written to Xenstore in order to > >>>>> support hotplugging virtio devices or passing the backend domain id > >>>>> on arch where the device-tree is not available. > >>>>> - the ring-ref/event-channel are not used for the backend<->frontend > >>>>> communication, the proposed IPC for Virtio is IOREQ/DM > >>>>> it is still a "block device" and ought to be integrated in existing > >>>>> "disk" handling. So, re-use (and adapt) "disk" parsing/configuration > >>>>> logic to deal with Virtio devices as well. > >>>>> > >>>>> For the immediate purpose and an ability to extend that support for > >>>>> other use-cases in future (Qemu, virtio-pci, etc) perform the > >>>>> following > >>>>> actions: > >>>>> - Add new disk backend type (LIBXL_DISK_BACKEND_OTHER) and reflect > >>>>> that in the configuration > >>>>> - Introduce new disk "specification" and "transport" fields to struct > >>>>> libxl_device_disk. Both are written to the Xenstore. The transport > >>>>> field is only used for the specification "virtio" and it assumes > >>>>> only "mmio" value for now. > >>>>> - Introduce new "specification" option with "xen" communication > >>>>> protocol being default value. > >>>>> - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current > >>>>> one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model > >>>>> > >>>>> An example of domain configuration for Virtio disk: > >>>>> disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=other, > >>>>> specification=virtio'] > >>>>> > >>>>> Nothing has changed for default Xen disk configuration. > >>>>> > >>>>> Please note, this patch is not enough for virtio-disk to work > >>>>> on Xen (Arm), as for every Virtio device (including disk) we need > >>>>> to allocate Virtio MMIO params (IRQ and memory region) and pass > >>>>> them to the backend, also update Guest device-tree. The subsequent > >>>>> patch will add these missing bits. For the current patch, > >>>>> the default "irq" and "base" are just written to the Xenstore. > >>>>> This is not an ideal splitting, but this way we avoid breaking > >>>>> the bisectability. > >>>>> > >>>>> Signed-off-by: Oleksandr Tyshchenko > >>>> OK, I am *really* sorry for coming in here at the last minute and > >>>> quibbling about things. > >>> > >>> > >>> no problem > >>> > >>> > >>>> But this introduces a public interface which looks really wrong to > >>>> me.  I’ve replied to the mail from December where Juergen proposed > >>>> the “Other” protocol. > >>>> > >>>> Hopefully this will be a simple matter of finding a better name > >>>> than “other”. (Or you guys convincing me that “other” is really the > >>>> best name for this value; or even Anthony asserting his right as a > >>>> maintainer to overrule my objection if he thinks I’m out of line.) > >>> > >>> > >>> I saw your reply to V6 and Juergen's answer. I share Juergen's > >>> opinion as well as I understand your concern. I think, this is > >>> exactly the situation when finding a perfect name (obvious, short, > >>> etc) for the backendtype (in our particular case) is really difficult. > >>> > >>> Personally I tend to leave "other", because there is no better > >>> alternative from my PoV. Also I might be completely wrong here, but > >>> I don't think we will have to extend the "backendtype" for > >>> supporting other possible virtio backend implementations in the > >>> foreseeable future: > >>> > >>> - when Qemu gains the required support we will choose qdisk: > >>> backendtype qdisk specification virtio > >>> - for the possible virtio alternative of the blkback we will choose > >>> phy: backendtype phy specification virtio > >>> > >>> If there will be a need to keep various implementation, we will be > >>> able to describe that by using "transport" (mmio, pci, xenbus, argo, > >>> whatever). > >>> Actually this is why we also introduced "specification" and "transport". > >>> > >>> IIRC, there were other (suggested?) names except "other" which are > >>> "external" and "daemon". If you think that one of them is better > >>> than "other", I will happy to use it. > >> > >> > >> Could we please make a decision on this? > >> > >> If "other" is not unambiguous, then maybe we could choose "daemon" to > >> describe arbitrary user-level backends, any thought? > > > > Unfortunately I didn’t have time to dig into this; I’m just going to > > have to withdraw my objection, and let you & Juergen decide what to > > call it. > > George, thanks for letting me know. Juergen proposed to use "standalone" > for the new backendtype name which is far more specific. I agree with that. > > > Anthony, would you be happy with that renaming? I tried to figure out what backendtype is supposed to mean, how it's used. I feel it's quite messy at the moment. Man page xl-disk-configuration says it's a backend implementation to use. Beside 'phy', which I guess is the kernel or blkback, the two other point to QEMU ('qdisk') and tapdisk ('tap'). The, backendtype is used throughout libxl to deal with the different backend implementation, and the value is stored in the xenstore key "type". From "blkif.h", "type" should be 'file' or 'phy' or 'tap', but we store 'qdisk' for 'qdisk'... so the "type" note in xenstore is probably useless for qdisk, but maybe useful for 'phy'? (This "type" node is only for the backend, so probably useless for a front end.) Anyway, it seems to me that backendtype should be the name of the implementation of the backend we want to use. It is just a parameter to tell libxl how to communicate with the backend. At the moment libxl uses xenstore to communicates with all backends even if that's not required, because libxl works this way and it's hard to change. (We could communicate with QEMU via QMP rather than xenstore for example.) So I guess either you have a name for your implementation, or something generic will do. So "standalone" is fine. (We probably want to document somewhere that this new type would simply mean "only-relying-on-xenstore-data" like Juergen is putting it, and isn't blkback or QEMU.) Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 15 15:35:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 15:35:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368311.599530 (Exim 4.92) (envelope-from ) id 1oCNLE-0004q3-77; Fri, 15 Jul 2022 15:34:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368311.599530; Fri, 15 Jul 2022 15:34:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNLE-0004pw-44; Fri, 15 Jul 2022 15:34:56 +0000 Received: by outflank-mailman (input) for mailman id 368311; Fri, 15 Jul 2022 15:34:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNLD-0004pm-GF; Fri, 15 Jul 2022 15:34:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNLD-0007XF-CO; Fri, 15 Jul 2022 15:34:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNLC-000597-V4; Fri, 15 Jul 2022 15:34:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCNLC-0004jq-Ub; Fri, 15 Jul 2022 15:34:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=55byUKHH9d1b6850D7XiolltnJzfEC5hl2Fn7MvcAvg=; b=HhMfHeuaqFMSFEvDUM0CC/Oi4W V3/KaFvGv97jOqQQryOpUdtUMCsc4Fs54YIuyT1Uc00Fm+G7un67ePneplu17Pel4m4dsHyKdEhDI PmlyvcJTVq1OOl0Lc7rmg4GkAypCjeXm/Icn6cOPpcsvEhztkvLRM76hTh7JqfSGxqbM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171640: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b X-Osstest-Versions-That: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b From: osstest service owner Date: Fri, 15 Jul 2022 15:34:54 +0000 flight 171640 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171640/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ab2977b027acbbd33a7eecda854d1911a7702f8b baseline version: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b Last test of basis 171629 2022-07-14 12:02:14 Z 1 days Testing same since 171640 2022-07-15 12:01:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 355caa9ef2..ab2977b027 ab2977b027acbbd33a7eecda854d1911a7702f8b -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 15 15:46:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 15:46:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368323.599542 (Exim 4.92) (envelope-from ) id 1oCNWl-00070S-Do; Fri, 15 Jul 2022 15:46:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368323.599542; Fri, 15 Jul 2022 15:46:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNWl-00070L-9E; Fri, 15 Jul 2022 15:46:51 +0000 Received: by outflank-mailman (input) for mailman id 368323; Fri, 15 Jul 2022 15:46:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNWj-00070F-Pb for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 15:46:49 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 55a08c82-0455-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 17:46:48 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D9B94620A3; Fri, 15 Jul 2022 15:46:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65BE5C34115; Fri, 15 Jul 2022 15:46:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 55a08c82-0455-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657900006; bh=1pP6wpTZR6yxJttIfhQ8GaI8CR+vOrFTZHxcwN15uk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nTS1MBom8JQTTyxEVLiCJsH0hjcLXRd+KWRW8j3+FwNB94NtVwxVS2b96USqC+sj4 X/y9CH5O8YMTLBPq2aLd6pHgYwMMkzcQE8XH7EE5DFEuPgy48tsQv1wK1nuHVA8sjv d9LxY2RmBRhHoOoqQHLHJmdKo67NuGc+5QL5hrDXhUzcvX1aesCIXJLRFKlGsLsT+U rvJ9XJYf3yOkXRvfjwP0iY+hRoZsNgrRJ1SbPWaq5DYVaa4NkP9SzzfADd2GOYlAmX BGuzgB7BqNF8zrOFWIG+/Hiit3qJ6zHtel3LuLoAF7S4p7KhMQcV/CU9YTJSlfi0if u/t2DHgvbMY0g== From: SeongJae Park To: Andrii Chepurnyi Cc: Oleksandr , SeongJae Park , roger.pau@citrix.com, jgross@suse.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] xen-blkback: fix persistent grants negotiation Date: Fri, 15 Jul 2022 15:46:43 +0000 Message-Id: <20220715154643.54334-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello, Oleksandr, thank you for Cc-ing Andrii. Andrii, thank you for the comment! On Fri, 15 Jul 2022 15:00:10 +0300 Andrii Chepurnyi wrote: > [-- Attachment #1: Type: text/plain, Size: 5237 bytes --] > > Hello All, > > I faced the mentioned issue recently and just to bring more context here is > our setup: > We use pvblock backend for Android guest. It starts using u-boot with > pvblock support(which frontend doesn't support the persistent grants > feature), later it loads and starts the Linux kernel(which frontend > supports the persistent grants feature). So in total, we have sequent two > different frontends reconnection, the first of which doesn't support > persistent grants. > So the original patch [1] perfectly solves the original issue and provides > the ability to use persistent grants after the reconnection when Linux > frontend which supports persistent grants comes into play. > At the same time [2] will disable the persistent grants feature for the > first and second frontend. Thank you for this great explanation of your situation. > Is it possible to keep [1] as is? Yes, my concerns about Max's original patch[1] are conflicting behavior description in the document[1] and different behavior on blkfront-side 'feature_persistent' parameter. I will post Max's patch again with patches for blkfront behavior change and Documents updates. [1] https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/ Thanks, SJ > > [1] > https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/ > [2] https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/ > > Best regards, > Andrii > > On Fri, Jul 15, 2022 at 1:15 PM Oleksandr wrote: > > > > > On 15.07.22 01:44, SeongJae Park wrote: > > > > > > Hello all. > > > > Adding Andrii Chepurnyi to CC who have played with the use-case which > > required reconnect recently and faced some issues with > > feature_persistent handling. [...] From xen-devel-bounces@lists.xenproject.org Fri Jul 15 15:57:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 15:57:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368329.599552 (Exim 4.92) (envelope-from ) id 1oCNgi-0000Of-Aq; Fri, 15 Jul 2022 15:57:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368329.599552; Fri, 15 Jul 2022 15:57:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNgi-0000OY-7i; Fri, 15 Jul 2022 15:57:08 +0000 Received: by outflank-mailman (input) for mailman id 368329; Fri, 15 Jul 2022 15:57:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNgg-0000OS-Dx for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 15:57:06 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140071.outbound.protection.outlook.com [40.107.14.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c4e3b67c-0456-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 17:57:03 +0200 (CEST) Received: from FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::7) by PR2PR08MB4732.eurprd08.prod.outlook.com (2603:10a6:101:26::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.23; Fri, 15 Jul 2022 15:56:55 +0000 Received: from VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:48:cafe::54) by FR0P281CA0044.outlook.office365.com (2603:10a6:d10:48::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.10 via Frontend Transport; Fri, 15 Jul 2022 15:56:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT006.mail.protection.outlook.com (10.152.18.116) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 15 Jul 2022 15:56:54 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 15 Jul 2022 15:56:54 +0000 Received: from 046164cbf809.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 08896A65-25DD-41A6-97FD-7926CD3ECACC.1; Fri, 15 Jul 2022 15:56:49 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 046164cbf809.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 15 Jul 2022 15:56:49 +0000 Received: from DB8PR08MB5452.eurprd08.prod.outlook.com (2603:10a6:10:111::10) by VI1PR08MB3021.eurprd08.prod.outlook.com (2603:10a6:803:47::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 15 Jul 2022 15:56:46 +0000 Received: from DB8PR08MB5452.eurprd08.prod.outlook.com ([fe80::4f1:335d:1b5f:feed]) by DB8PR08MB5452.eurprd08.prod.outlook.com ([fe80::4f1:335d:1b5f:feed%7]) with mapi id 15.20.5438.012; Fri, 15 Jul 2022 15:56:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c4e3b67c-0456-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DIB3r1lm6OGsylITK6rEPq3CWaScUL0/64Cn+QwFzR3J6ww/vfLBI6l1qe70EJ6QngHV54EC2uh87qqJBNdIEdPPMV2HRqONm0QzrPg0LWpAMxrT8EwpSNxLBvBtX7L5liVtHw3I5+yW7wshrnx6TGuIwMF2V6CnEamztsGuPvqoCLN7hnJM/n+oQxK0uaZBHMOFyS2QVMqO8/8gq5zWqFr85P5X0VHd/FFrZKmA6JdpM7l8dcP2mUN/9ZWY1tXpIi9AryNO7pKqLb8MkqGYTG8Bld9xBK9bgPahK3Kgw7DkoEmR1DhGe3+ARlWFy+JDhK6EZrVVHSm1uMfKy9AFMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d6NyEoGTV5ehoXG7tuaM9ypqXVWZ0zpVIBlCr4aAS3M=; b=VA5gXmcpBmvTOhhgvOhU1wr8AOwZGt/T79i0GE4FW5BRLqnn8VGeORi8+lIRhZTHDg8hZZ5l3sVZE5Rl2RhJSFodDwTEE/VobTztLybUrhngpudm6O/+lsrJ5qSAM1mExpOjv0f+d5L3NHIE0zDfAGSeyT0GHg9+hXU0Bv5EGXWgUj7j77VNUz9lFIDf0HUxGZElXoWL8ssYii2q6py9OfXyyKmm26FfFA8Ba5q+z/og7trwPfg8W0MqfFl12ehNAjmWdotV9HRwh3NjZaSjNNYoeNxNBXdBOCbY9Zw8ZJqvz/xklc1TRll3X4d26zRyI7WtmiD0f3mj+agFJL3Msw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6NyEoGTV5ehoXG7tuaM9ypqXVWZ0zpVIBlCr4aAS3M=; b=Rb01hdM6LCRs0aJyxEdAhAbzogUdiLA66bmcLjbLQEgy+FmRv1xhuJyI/ZiGQAcMOpM1PL4C4NCNvdwIDwE+AaLRPJz4SHeIW8ppHD+B5xsWbiJi5381neVcWFs5S2wMV/H4zQF4Jw/gJnj1fsRSjh1Etv9enooVO/pLjRVaBjc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WyY4yX/gnNnOgPqA2xEbL6pTqIpJGyz15rR0N/CQVEMeqPZziuX86i/MiOmjSgXaplLCJW6lqwHT7yCDR7LDKV12ujdQtHeVhB7QZStQPVBSqYb3GlzKN97qEibZCESmD5reIM504FzyKNhfXQHh845WqRc95bidPa/8D95HC5jBE40pMBKoB4CLxizrQl1qnILNiK7KPGtfatMTrJK9lvhxCWrYQXekbh/rqjmbFWQtVrbdezWOC9XrYXQfA71dI/37NVl5t9d8O/jIrTviVTx17AtFbPtKQS3d6TUy1EVman2OZQf0FG3G16NYMlOJ86iEx6oQ5VGIVPuns3fE5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d6NyEoGTV5ehoXG7tuaM9ypqXVWZ0zpVIBlCr4aAS3M=; b=As1orPsb8ZCqGKvLckMU0IuT+jBRxwbkFosSq7lCgoq+nEwTUikp7t/MvUOsta7Yl33K+AHNsB0eBo/c6DSA2JuiczwcngZHxvMsWSXRqIAMGLsxpCYg1hsldWASwyFspPvnE3jOKsk+9y+iGKEqVC5XjLV3B/Ki2r5gZ5P9Co2/IzyN8eaK7/ueY9MOsDKjW4hEaHo8C1OW8dLDh5YCcq+shNejOZz1nK2ZeZemPZdJhM4nm32z+TutohBuu04xrtSmZ45OluPCmxlw/Z6wOiqViXfvFVEspxcIHyvrG8l0n7aUXna5Aahs+6caYBvvVoG1Uq/6TOZItOYoPA48EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d6NyEoGTV5ehoXG7tuaM9ypqXVWZ0zpVIBlCr4aAS3M=; b=Rb01hdM6LCRs0aJyxEdAhAbzogUdiLA66bmcLjbLQEgy+FmRv1xhuJyI/ZiGQAcMOpM1PL4C4NCNvdwIDwE+AaLRPJz4SHeIW8ppHD+B5xsWbiJi5381neVcWFs5S2wMV/H4zQF4Jw/gJnj1fsRSjh1Etv9enooVO/pLjRVaBjc= From: Marc Bonnici To: "xen-devel@lists.xenproject.org" Subject: Xen Memory Sharing Query Thread-Topic: Xen Memory Sharing Query Thread-Index: AdiXcIvKzj1u3ooYRvOwLKlCsLdCEA== Date: Fri, 15 Jul 2022 15:56:46 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B2E591B8C1A07049A5F2AF3BDD84E2A9.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f2f72cbe-98b3-4164-0290-08da667aa3de x-ms-traffictypediagnostic: VI1PR08MB3021:EE_|VE1EUR03FT006:EE_|PR2PR08MB4732:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: kTJp6GzcFw4sm24IQhggHedBp23EFkdlLa/u53lC0PjBXBbd23Qn62EcM1bLXF1eP0mY5kz+eq46emr0gk6SzKiVkweZxN3noCxDeWj/jV+fefLlzyf5hxcRo3qQoRmyGp0oZUHIfekMcxdD3mReBO1kLE1j3XMBFYkdTvRfhwNOeNW7VOa22KFi9D3vjV3mfTSFwTuDHN2viUmo7463q/PjWI28WvhGNevGuBiwJoDxNZoFodnDCBQnI/nANrQoWpyhdGWdbkf5n64L/oCqiVtS1Qa1KkaYURZgBYSxFijorG2eyNqo/8ORfv9wzEJmBk3hvMsL67/1xMhU7QF5EiP7QqEIWaFCPj/SPvYzCPJNTn0mVQgux/Rhu0On5RHqSAQ4PEpc02dMnCJsW19vf1TxxCpodmSEUR/SVvwVNB8tiluI5ygNrY3P6P/rX6n5znKMCQtwKvInqIzTpvhDYkBPq7ix259EVnFQISeoRZ/dqBFZTtoCj+TohfWMVdpkP/Cd+iqQG3Od8i5if367JUB1kc66SgJHRoXnikoBJRkKt2Zm00BNLuJNCWyyo7k77yguVcBOnNUnSVw3sq0ScCDb1Xwn7HeHbWzwPWeg5ozBNN7auw7COhRVBwf24+1hpCSbB5ArUaC2hI7W4nQKFg8PLURDhbJgn5E6GwBz7gG/sEF49lkpG9qpBbNRH8EQHSVxsxGPg54f28ekGJJVYayaUYVdVT2P1wOAVddEAB0ky5WiUsnl2YOtExpIshEJyzuS3Zfibn/f8hSNEw6L0KeCVZBZpjf8T8e3wKo5rwDiXpG5mariwyudV/rFJvTH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB5452.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(39860400002)(376002)(366004)(38070700005)(186003)(38100700002)(76116006)(2906002)(55016003)(5660300002)(52536014)(33656002)(3480700007)(66446008)(9686003)(8676002)(122000001)(26005)(66556008)(41300700001)(7696005)(478600001)(66476007)(6506007)(83380400001)(6916009)(86362001)(66946007)(64756008)(316002)(71200400001)(8936002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3021 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 41ab6892-4c19-4f3c-8990-08da667a9f10 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +sNeglGIdpHxDTEEIgc2ZMqm8xWg435jRxBm4U2DCnCGQLf5/KedQF6ZeAMR3vEv64G48Yk9/Hbwem2by3Sf0O87pH6lpQ/vgzga8TmoZXV2V8tDd9NwBk7Uo60rtmdm6UqlQnSFYgJ1lA6wCfP03Get8pYAI/eNH9RQGKBX6bX4a1sNAn8reOj1J4GQkE06RP50CVRmbSztFjjfK7XumtIq9hH3ra+/hgEVHUppm5158Yngi7uoy+ibyH3qhwsyuc6bh2xhT39FmWYQVfUzjQodX4utY5ehUAtDPeDNVjPrTYm3uwuANcDj73yZBWQM8sprANlm9Nqw21EduvVZuOIeeX5QL6acLs861CURkeuhi/CD6sD2kr3E5qyTm95z0uBOtCh7yu1ABg8uF0YG2U5uzq3cCWs2wz4nMTwQz+7l20g4cEaNzaUz7wJ0PhzBJBWfil/YQpwnEeMicsrzkByGgwZde95Xy59SiJFONJXu5O1XVvOSio1d13nJyYm/no+Y30C3MqAZ0zUpuAGIH+4h3zT37ZJcEn1MTL7ho5hoaqs1/0k0aV75MwiRbcX52d9I4I1bO9n9Hxun9HFroT3ThRDFWJuxY42ql5/NhuXtfYkJpmyrUclF6nOrcusNGRm2QfOAj9IucXqal+4zGRK42vQeiu4d4EgfoOdtKB/v9cHoFrBZWVJOJopca7OWsRkLoq0trE3XhRVDVlDVsuhHLLpSRKT4+ELoTJEuBuxGZ8wtatjynxliteoYII3yEdf7XlVkrvmYQxu27OFd15a5q4uT1uWTYjz79f2kEnvoVsFI7sy2K5KLoZDjOGH8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(376002)(396003)(39860400002)(46966006)(36840700001)(40470700004)(8676002)(41300700001)(81166007)(26005)(478600001)(82310400005)(3480700007)(70586007)(40460700003)(47076005)(2906002)(6916009)(5660300002)(83380400001)(70206006)(6506007)(356005)(82740400003)(316002)(9686003)(86362001)(8936002)(55016003)(40480700001)(36860700001)(33656002)(336012)(186003)(52536014)(7696005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2022 15:56:54.6531 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2f72cbe-98b3-4164-0290-08da667aa3de X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4732 Hi All, I was wondering if someone could help me understand some of the rules of th= e=20 memory sharing implementation in Xen? Specifically I'm looking to understand what restrictions Xen places on granting access from one Dom to another from Xen's perspective, and what ty= pes=20 of grant requests would be allowed/rejected by Xen? I.e. How would the situation be handled if the same frame of memory was att= empted=20 to be shared multiple times? As an example scenario, DomA shares 1 physical page of memory in a transact= ion=20 with DomB. And then without releasing any memory, DomA attempts to share another region of memory, which includes the same physical page of the prev= ious share with DomB again. This would result in two concurrent shares containing an o= verlap. Apologies if I've missed something but is there any documentation / threat = model that would cover these types of scenarios? So far I have been trying to rea= d through=20 the code but was wondering if there is something else I could refer to help= me=20 with my understanding? Thanks=20 Kind Regards, Marc Bonnici=20 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 16:01:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 16:01:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368337.599562 (Exim 4.92) (envelope-from ) id 1oCNkz-0002OV-V7; Fri, 15 Jul 2022 16:01:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368337.599562; Fri, 15 Jul 2022 16:01:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNkz-0002OO-SO; Fri, 15 Jul 2022 16:01:33 +0000 Received: by outflank-mailman (input) for mailman id 368337; Fri, 15 Jul 2022 16:01:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCNky-0002OI-7Y for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 16:01:32 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6370782a-0457-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 18:01:30 +0200 (CEST) Received: from pps.filterd (m0174683.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26FFtkna011845; Fri, 15 Jul 2022 16:01:18 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2105.outbound.protection.outlook.com [104.47.18.105]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hbb3sr1yh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Jul 2022 16:01:17 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM0PR03MB6305.eurprd03.prod.outlook.com (2603:10a6:20b:157::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Fri, 15 Jul 2022 16:01:14 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5417.025; Fri, 15 Jul 2022 16:01:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6370782a-0457-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kraK0fSSzdxyopmb4cQHDS+gtBL2XnTpbOoiSe6eAYF4Osy7cufwwcqEtTXaE6AgXOJqARKInxTGR7WJsINchTKW5fgd6ge6kw7y6vCz+l4KwLhIwLwW2xLQgNQ/MRmFITsI9sYxNF6sbxg8m2TKqdeYUlNees6+EglAs+0gySF1/scfVfAlgkg7ppQx48H8VtHoCnY2fLUB9y6oDzKKVjjM4kGzOi57+vm9CSagMTdi/e+8b/UvywCnhMLgeAo2yKw2umu4S8aLqUAAPJXrVa3J84qJNGWChRPh+EPg/h69a5xmUWx2U94O5fYEyPBWzpzGLxbuTRFWfkOuemS7wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g1N3b3ss6ufPPPiM5WhnX2Q/E0tcdmdSa5I/vjSC9r0=; b=Uqx6sZWmeDuPSIGrJxSUer3npFAKorpscDxYcL6QJwbSOl1aUR9Ezq+zjQzNZp1X0UE3N9+bb5JMXrzkptyclImxOZDlZ/5j/yrOxTVrRhOlxGasKIMfvnm7YlnEB3gjbcebfOlsMQQPsFKayU08IYvCjntjDMUtLdTu5cfsbAaFfZaXhzvwhcPhvI4zu6tDgPcnhfgTQfvWadK5/hY0TyzMoozcl/VW2sSu6R7tGwlVko0hqUpNLULB7neXs1YKsETng9SXs2DQ1kN91oDx5DvNyE+pnRurDeZ110xgyF381g0ZgZT8YZ5gHYjmHjsMvY/yiLG3ZncV7+yvsto3Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g1N3b3ss6ufPPPiM5WhnX2Q/E0tcdmdSa5I/vjSC9r0=; b=DyS0ifDfh9CQfPq+SZ1bCJ+Ci3U2LVHTDL07IgaWPZ42I8UtRN7xofqrXtFl0rNfrliJQqPdzov43FmqrvGh71tZpKzpJBXXiSbMP+LvKGWvl8dYd8xtT3hFLN+Jp+iQDrzqbtfPQ8PMkhSzPc0NqhZsn4DdSwNs9LQ/0h8P2hBM37UEt2RtSW0SsyCH6HXTo11n6QWneH4FDXhJnyxuRGe6AgdwZfrfV4GHT9dj13DQPkKuJ5WYfj6RcEGf9laOWhbdHrgp3iwLJHFM3pHncLfEeCfCEpgik19DZy5Aeuxwl51M/Sj3bc2DiQQYrrMOhF783rXi9shh16+pBnTVsg== From: Oleksandr Tyshchenko To: Anthony PERARD CC: George Dunlap , Juergen Gross , xen-devel , Wei Liu , Nick Rosbrook , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis , Oleksandr Subject: Re: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V10 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYf1A6pQ9CS25xdkGDIpueSgv3zq1QiHQAgAAkCwCAAwIqgIAAEjKAgAALK4CACsnJAIABrEAAgAe2TICAE6BaAIAAhq0AgAOgCICAAAosgA== Date: Fri, 15 Jul 2022 16:01:14 +0000 Message-ID: <8301452f-04ba-9060-9b8c-c4421318469c@epam.com> References: <62903b8e-6c20-600e-8283-5a3e3b853a18@gmail.com> <1655482471-16850-1-git-send-email-olekstysh@gmail.com> <9A36692A-8095-4C76-A69B-FBAB221A365C@citrix.com> <02648046-7781-61e5-de93-77342e4d6c16@gmail.com> <36d4c786-9fb7-4b30-1a4d-171f92cc84d7@gmail.com> <5fa04098-a3a0-a517-ca8c-19d45ecac63e@epam.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 43af0be4-75b2-48cd-3c38-08da667b3ed1 x-ms-traffictypediagnostic: AM0PR03MB6305:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b9QhWMWs0kvvD84ZadbDCEaf9mpyz0zUKdaaN7CFURfMMkLKwOQXaSSA6OvDNvN88sR+bX9rgJokHMR4cmyEurjZOis/PAHgS9a/2s4QnY+mhoCXnLheurPfyUHHIb+wXIuTPrZtSMN24lVSzrzqETDI45/nzP0RGxNEYPWUuruAQYCH2cvZ8D52ucrtK6zcZhHoXxnV+hP7ryieWetguPzWa7b2/XOYtJzDLw8gi1NQp9aYHM2YFmlXXWHcn3CkQiiBIFQTc0zYibiZnvPq38xsfycOUoAqWI0lIs5g+SlgxjPxv0hKgAYBGc2kmrMbuQhyZ7LnkxgOxcRbnpLzFsR2upyBAV/rjfPfPyLNZA+OHpyu+FlHcKwxRBE4hPKzMfKaFktvsrRCezTz+w4TstBkRzgDH3gRWXHEgv+VWkTChmqb4aK/X6AKHyY/jY2920wLAW5Ik1jAzoIbHkXAob20IKLhHJI1PoA+u6j+JfWeRk8y8ph/rCh2oPqWX9E09hFyYMTIMFye0F67oEgIgN6ZN3pL3FUsfyGqm675qiEZbqakXTodcAigo0J55ZFZIJeLVOsKHh//LbLry0TKnn+Q4K48RvjV95TGE3LEtgswdWVuJX9Bp1Kvq45SXDUSyrZvjPIGQQQKJawZSsrtoAFP9qJtZQucJuZbBskSZ3UUkUoZnHPAYReIpjQPpO54XWH7E4vgNqhFTlsFbufPdj6Fs5wCcE4K66K8iaKrjFjsYQgcCya5MecB1tJPym419uv3R9gCVtBM1MdcdaiG6CBRuzXjdbP1D/bVXUcGMsvRCC1mIbPJcxdW7JfiA8Ep+AgDrAFWV4e0wcuimAK6zQp4G5cRIq22tCcXS+JstY4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(366004)(55236004)(53546011)(2616005)(186003)(83380400001)(26005)(4326008)(5660300002)(6512007)(2906002)(7416002)(6506007)(478600001)(31686004)(71200400001)(41300700001)(36756003)(8936002)(54906003)(6486002)(6916009)(31696002)(38070700005)(316002)(91956017)(66556008)(66476007)(76116006)(122000001)(86362001)(38100700002)(8676002)(66946007)(66446008)(64756008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RTBUNXZpZ1haQjkxM0NOU0thcEFPVEZOSTB0bDgvcHJCREIvVkpGVWJ4TDl6?= =?utf-8?B?VGh1a3NORzYzQWE4NndLY1djRlJCSUlMdktFaTgrT0JmZkhCY2djRE42V2Q4?= =?utf-8?B?UG53NkVVMjJCV0thSmwyS2h4ZGlMdURIUVBhOVBFakJGa09yYVhwd3BsNnVL?= =?utf-8?B?WmhBYnM0T2g3eEtPazc5ZTR3ZENoOHBpRVNyQ0RVck1rTG14OW1YdS9YRk1X?= =?utf-8?B?YU5LMVJqYW9ubmUrZ05zelBlZVFNVjQ3UXNuSUh5QkNUcWdyQXZkM1JIcDNJ?= =?utf-8?B?MGlmck1DTUxmZE9uQ2NabjloRXUzOGdnYWU3ZHd1YklGUDhNall4ZWNlVUdW?= =?utf-8?B?WWJ5bkNSM3JVUkJOMkFmWHJsbzhFbll4OXlndW5JdUQwbXY5MVFKSGxpak1P?= =?utf-8?B?cGdxbFB1UTlnWUFyYTNIcXkzRWMrcmdSNHpyMUZBNmZiMFRabEcrdnJJL2JY?= =?utf-8?B?R09LdjdIL0JsSVBtYmR1QW5oQkxMNC9jM0dyTDdBWXpKQ2VLb3RIUmNPVzZL?= =?utf-8?B?U1d2blcvWWZFY0gwTGJ4YW1NZEVZRlY1QmdwVWlQdCtrWkpmM1BMaXJmM1JB?= =?utf-8?B?SklTSGpGV2dGVU5kQjdRTHVuaE9ZczVsMkIzdjIvWjlQSW8xejhIaTdGbXVL?= =?utf-8?B?ckFNUVkrYmx2RjNFcHVweDFoQVlyNmRJeFVmejdXWmpPazQrcmxrajVIMDlE?= =?utf-8?B?bTJQV29VNUtJS3kvRzhXZC9Oa05sVXFpT2xRdW1LOUJqdmRDQVp4ZU5VT0F5?= =?utf-8?B?a1hSZ1BSZjZNelY4b1ZicHdZU1RtUUw5WmJldlNMOXBFUVJ6YzJGcFI1UXo4?= =?utf-8?B?clN6VS92aFJ3SHBuaTgrKzlNZUNQYnYzOCtITFVhNk1IT3llb3piaGdUVW54?= =?utf-8?B?Y0c4ZXNMN2kwOXg0SFhXaFlaa0dDOHRNTGdzUXhhSW5KbDhNNElyOHlPMnVZ?= =?utf-8?B?T0hxNWN1WFl5UzZmL09iK0lVaHpEQmdXY2VLS1dPWVBiK080MklWREtWV0lI?= =?utf-8?B?N3M4RGxuN0QzeVpwZ1lZSmk2RS84ZGplRHJ4T0kyL0FYWXF1ZXhSRTFWcGJa?= =?utf-8?B?WC9GcFFVZS9aOTVtVDNOWGFJN04yNXNNMGYvZjUrZTNhU0ZNQXRCbUxsM2Zp?= =?utf-8?B?aWlZalhURWszaVNtSlJORU9nUDVoZmlHQ3lnY2tUN1JmOG5HR0FkQjlRY2Ry?= =?utf-8?B?U0h6cWJvSVg3VXpUeUZSNVF1TGliTndWNGJkQ3R0Vk1vMFZxSzZIRDZsaDYy?= =?utf-8?B?T2Evencxd3NScVRwTndNOFFnZno0cG1ubTgwZU4xUGlrTjZldnhPaTUzdTE0?= =?utf-8?B?MGY2c2lqTmlYVXZ4YVgyTmhMbWpCenV4RjBaWWRkai9JeEdpdXpEaU1weXBI?= =?utf-8?B?SVdraEFDMzRUY3EzWFdGbEQ1c21OdldPZmEvZmZPVnhmQVlJUCtnNGxVK0xu?= =?utf-8?B?SlM2a1p1MjJxNFNjQ2ErMTFZaHBVM0NoVno1ZjB4UTVkMlR1bjZ5ZGVSdklP?= =?utf-8?B?WkJySjU3UEVackdCdmZFMVQvbDNjQWxLc2ttejVub3NNL1pNRldhL1FaQUI5?= =?utf-8?B?Y05JYlluQlhWRHMxRWs4dzRLaTBzb2dNSElVNTlhZ2VIV1ZQcVFuV2VEYVIx?= =?utf-8?B?Y3hRbzZEYW5ZWjdyc0NHVEdDT3A2bjFBRC9WUllFa2hGTHZNQ0krZy9KZnZS?= =?utf-8?B?dmt6UEIzWXVPQ2EwM1YzR0VLQ1JWYUZHTTNBOXRIUDdVVTltT01SandmckRl?= =?utf-8?B?cURPYXJ3N1Uxd3RxYjhNaWxyYTdpcCtCMERTa0dnTmhjd0RoM2JHOFk1ckgv?= =?utf-8?B?U1B0TFZrTnY5OVBXZ3lxb1F1TnhzMjBBUld0bERQbUdRNmZ2MTljKzh0UURr?= =?utf-8?B?TTBveEpvU3kzUWJQZTZkOXVmbmwvTVpjYjNFelFWTW1EVDkzeEpyS1FYeFhz?= =?utf-8?B?UUkzYWJlaitpVnEzdjVxaU5aazh3TEoyb2FHYzNMK2NGSE9LUTU0UnVSRlEr?= =?utf-8?B?SFp4VUlLVk1JajdTY2lhOEZXM0tnL1hweUFRRFltUXQ1OUJDbEFxSG1ML3Nl?= =?utf-8?B?Wm43Uks4dzF5aHZPdkRRZFRuUDBKazhvRGRLZHZrVzlBc2FpZnYxYnVWSWNh?= =?utf-8?B?amgzRmJaNUQ0WThqRlc4ZW4vMExXSnU5TU1Dcmgxdi94dEJlcVVTRG85YlBy?= =?utf-8?Q?1EYFDMCNNoYuhyYsPOHs0C0=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <6491594FCEFAD04A9402D8B0D2EC1079@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43af0be4-75b2-48cd-3c38-08da667b3ed1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 16:01:14.6944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tOvMLbbzARV7yK4IkHb8bsm9WLfkyaM+RWGUo5UjlMzF4WChaYDgnJIVH1GWaEge6MzZjL34cLdZ5/tSHi3UaDOcuzCK/S8hEBKhVF9JYVw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB6305 X-Proofpoint-GUID: b_2xI2OEdjlMLZDyKniWJJDQCPOFs22a X-Proofpoint-ORIG-GUID: b_2xI2OEdjlMLZDyKniWJJDQCPOFs22a X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-15_09,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 adultscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 mlxscore=0 spamscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207150071 DQpPbiAxNS4wNy4yMiAxODoyNCwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQoNCg0KSGVsbG8gQW50 aG9ueQ0KDQo+IE9uIFdlZCwgSnVsIDEzLCAyMDIyIGF0IDA4OjAzOjE3QU0gKzAwMDAsIE9sZWtz YW5kciBUeXNoY2hlbmtvIHdyb3RlOg0KPj4gT24gMTMuMDcuMjIgMDM6MDEsIEdlb3JnZSBEdW5s YXAgd3JvdGU6DQo+Pg0KPj4gSGVsbG8gR2VvcmdlLCBBbnRob255DQo+Pg0KPj4+DQo+Pj4+IE9u IDMwIEp1biAyMDIyLCBhdCAyMjoxOCwgT2xla3NhbmRyIDxvbGVrc3R5c2hAZ21haWwuY29tPiB3 cm90ZToNCj4+Pj4NCj4+Pj4NCj4+Pj4gRGVhciBhbGwuDQo+Pj4+DQo+Pj4+DQo+Pj4+IE9uIDI1 LjA2LjIyIDE3OjMyLCBPbGVrc2FuZHIgd3JvdGU6DQo+Pj4+PiBPbiAyNC4wNi4yMiAxNTo1OSwg R2VvcmdlIER1bmxhcCB3cm90ZToNCj4+Pj4+DQo+Pj4+PiBIZWxsbyBHZW9yZ2UNCj4+Pj4+DQo+ Pj4+Pj4+IE9uIDE3IEp1biAyMDIyLCBhdCAxNzoxNCwgT2xla3NhbmRyIFR5c2hjaGVua28NCj4+ Pj4+Pj4gPG9sZWtzdHlzaEBnbWFpbC5jb20+IHdyb3RlOg0KPj4+Pj4+Pg0KPj4+Pj4+PiBGcm9t OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+ Pj4+Pj4+DQo+Pj4+Pj4+IFRoaXMgcGF0Y2ggYWRkcyBiYXNpYyBzdXBwb3J0IGZvciBjb25maWd1 cmluZyBhbmQgYXNzaXN0aW5nDQo+Pj4+Pj4+IHZpcnRpby1tbWlvDQo+Pj4+Pj4+IGJhc2VkIHZp cnRpby1kaXNrIGJhY2tlbmQgKGVtdWxhdG9yKSB3aGljaCBpcyBpbnRlbmRlZCB0byBydW4gb3V0 IG9mDQo+Pj4+Pj4+IFFlbXUgYW5kIGNvdWxkIGJlIHJ1biBpbiBhbnkgZG9tYWluLg0KPj4+Pj4+ PiBBbHRob3VnaCB0aGUgVmlydGlvIGJsb2NrIGRldmljZSBpcyBxdWl0ZSBkaWZmZXJlbnQgZnJv bSB0cmFkaXRpb25hbA0KPj4+Pj4+PiBYZW4gUFYgYmxvY2sgZGV2aWNlICh2YmQpIGZyb20gdGhl IHRvb2xzdGFjaydzIHBvaW50IG9mIHZpZXc6DQo+Pj4+Pj4+IC0gYXMgdGhlIGZyb250ZW5kIGlz IHZpcnRpby1ibGsgd2hpY2ggaXMgbm90IGEgWGVuYnVzIGRyaXZlciwgbm90aGluZw0KPj4+Pj4+ PiB3cml0dGVuIHRvIFhlbnN0b3JlIGFyZSBmZXRjaGVkIGJ5IHRoZSBmcm9udGVuZCBjdXJyZW50 bHkgKCJ2ZGV2Ig0KPj4+Pj4+PiBpcyBub3QgcGFzc2VkIHRvIHRoZSBmcm9udGVuZCkuIEJ1dCB0 aGlzIG1pZ2h0IG5lZWQgdG8gYmUgcmV2aXNlZA0KPj4+Pj4+PiBpbiBmdXR1cmUsIHNvIGZyb250 ZW5kIGRhdGEgbWlnaHQgYmUgd3JpdHRlbiB0byBYZW5zdG9yZSBpbiBvcmRlciB0bw0KPj4+Pj4+ PiBzdXBwb3J0IGhvdHBsdWdnaW5nIHZpcnRpbyBkZXZpY2VzIG9yIHBhc3NpbmcgdGhlIGJhY2tl bmQgZG9tYWluIGlkDQo+Pj4+Pj4+IG9uIGFyY2ggd2hlcmUgdGhlIGRldmljZS10cmVlIGlzIG5v dCBhdmFpbGFibGUuDQo+Pj4+Pj4+IC0gdGhlIHJpbmctcmVmL2V2ZW50LWNoYW5uZWwgYXJlIG5v dCB1c2VkIGZvciB0aGUgYmFja2VuZDwtPmZyb250ZW5kDQo+Pj4+Pj4+IGNvbW11bmljYXRpb24s IHRoZSBwcm9wb3NlZCBJUEMgZm9yIFZpcnRpbyBpcyBJT1JFUS9ETQ0KPj4+Pj4+PiBpdCBpcyBz dGlsbCBhICJibG9jayBkZXZpY2UiIGFuZCBvdWdodCB0byBiZSBpbnRlZ3JhdGVkIGluIGV4aXN0 aW5nDQo+Pj4+Pj4+ICJkaXNrIiBoYW5kbGluZy4gU28sIHJlLXVzZSAoYW5kIGFkYXB0KSAiZGlz ayIgcGFyc2luZy9jb25maWd1cmF0aW9uDQo+Pj4+Pj4+IGxvZ2ljIHRvIGRlYWwgd2l0aCBWaXJ0 aW8gZGV2aWNlcyBhcyB3ZWxsLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBGb3IgdGhlIGltbWVkaWF0ZSBw dXJwb3NlIGFuZCBhbiBhYmlsaXR5IHRvIGV4dGVuZCB0aGF0IHN1cHBvcnQgZm9yDQo+Pj4+Pj4+ IG90aGVyIHVzZS1jYXNlcyBpbiBmdXR1cmUgKFFlbXUsIHZpcnRpby1wY2ksIGV0YykgcGVyZm9y bSB0aGUNCj4+Pj4+Pj4gZm9sbG93aW5nDQo+Pj4+Pj4+IGFjdGlvbnM6DQo+Pj4+Pj4+IC0gQWRk IG5ldyBkaXNrIGJhY2tlbmQgdHlwZSAoTElCWExfRElTS19CQUNLRU5EX09USEVSKSBhbmQgcmVm bGVjdA0KPj4+Pj4+PiB0aGF0IGluIHRoZSBjb25maWd1cmF0aW9uDQo+Pj4+Pj4+IC0gSW50cm9k dWNlIG5ldyBkaXNrICJzcGVjaWZpY2F0aW9uIiBhbmQgInRyYW5zcG9ydCIgZmllbGRzIHRvIHN0 cnVjdA0KPj4+Pj4+PiBsaWJ4bF9kZXZpY2VfZGlzay4gQm90aCBhcmUgd3JpdHRlbiB0byB0aGUg WGVuc3RvcmUuIFRoZSB0cmFuc3BvcnQNCj4+Pj4+Pj4gZmllbGQgaXMgb25seSB1c2VkIGZvciB0 aGUgc3BlY2lmaWNhdGlvbiAidmlydGlvIiBhbmQgaXQgYXNzdW1lcw0KPj4+Pj4+PiBvbmx5ICJt bWlvIiB2YWx1ZSBmb3Igbm93Lg0KPj4+Pj4+PiAtIEludHJvZHVjZSBuZXcgInNwZWNpZmljYXRp b24iIG9wdGlvbiB3aXRoICJ4ZW4iIGNvbW11bmljYXRpb24NCj4+Pj4+Pj4gcHJvdG9jb2wgYmVp bmcgZGVmYXVsdCB2YWx1ZS4NCj4+Pj4+Pj4gLSBBZGQgbmV3IGRldmljZSBraW5kIChMSUJYTF9f REVWSUNFX0tJTkRfVklSVElPX0RJU0spIGFzIGN1cnJlbnQNCj4+Pj4+Pj4gb25lIChMSUJYTF9f REVWSUNFX0tJTkRfVkJEKSBkb2Vzbid0IGZpdCBpbnRvIFZpcnRpbyBkaXNrIG1vZGVsDQo+Pj4+ Pj4+DQo+Pj4+Pj4+IEFuIGV4YW1wbGUgb2YgZG9tYWluIGNvbmZpZ3VyYXRpb24gZm9yIFZpcnRp byBkaXNrOg0KPj4+Pj4+PiBkaXNrID0gWyAncGh5Oi9kZXYvbW1jYmxrMHAzLCB4dmRhMSwgYmFj a2VuZHR5cGU9b3RoZXIsDQo+Pj4+Pj4+IHNwZWNpZmljYXRpb249dmlydGlvJ10NCj4+Pj4+Pj4N Cj4+Pj4+Pj4gTm90aGluZyBoYXMgY2hhbmdlZCBmb3IgZGVmYXVsdCBYZW4gZGlzayBjb25maWd1 cmF0aW9uLg0KPj4+Pj4+Pg0KPj4+Pj4+PiBQbGVhc2Ugbm90ZSwgdGhpcyBwYXRjaCBpcyBub3Qg ZW5vdWdoIGZvciB2aXJ0aW8tZGlzayB0byB3b3JrDQo+Pj4+Pj4+IG9uIFhlbiAoQXJtKSwgYXMg Zm9yIGV2ZXJ5IFZpcnRpbyBkZXZpY2UgKGluY2x1ZGluZyBkaXNrKSB3ZSBuZWVkDQo+Pj4+Pj4+ IHRvIGFsbG9jYXRlIFZpcnRpbyBNTUlPIHBhcmFtcyAoSVJRIGFuZCBtZW1vcnkgcmVnaW9uKSBh bmQgcGFzcw0KPj4+Pj4+PiB0aGVtIHRvIHRoZSBiYWNrZW5kLCBhbHNvIHVwZGF0ZSBHdWVzdCBk ZXZpY2UtdHJlZS4gVGhlIHN1YnNlcXVlbnQNCj4+Pj4+Pj4gcGF0Y2ggd2lsbCBhZGQgdGhlc2Ug bWlzc2luZyBiaXRzLiBGb3IgdGhlIGN1cnJlbnQgcGF0Y2gsDQo+Pj4+Pj4+IHRoZSBkZWZhdWx0 ICJpcnEiIGFuZCAiYmFzZSIgYXJlIGp1c3Qgd3JpdHRlbiB0byB0aGUgWGVuc3RvcmUuDQo+Pj4+ Pj4+IFRoaXMgaXMgbm90IGFuIGlkZWFsIHNwbGl0dGluZywgYnV0IHRoaXMgd2F5IHdlIGF2b2lk IGJyZWFraW5nDQo+Pj4+Pj4+IHRoZSBiaXNlY3RhYmlsaXR5Lg0KPj4+Pj4+Pg0KPj4+Pj4+PiBT aWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29A ZXBhbS5jb20+DQo+Pj4+Pj4gT0ssIEkgYW0gKnJlYWxseSogc29ycnkgZm9yIGNvbWluZyBpbiBo ZXJlIGF0IHRoZSBsYXN0IG1pbnV0ZSBhbmQNCj4+Pj4+PiBxdWliYmxpbmcgYWJvdXQgdGhpbmdz Lg0KPj4+Pj4NCj4+Pj4+IG5vIHByb2JsZW0NCj4+Pj4+DQo+Pj4+Pg0KPj4+Pj4+IEJ1dCB0aGlz IGludHJvZHVjZXMgYSBwdWJsaWMgaW50ZXJmYWNlIHdoaWNoIGxvb2tzIHJlYWxseSB3cm9uZyB0 bw0KPj4+Pj4+IG1lLsKgIEnigJl2ZSByZXBsaWVkIHRvIHRoZSBtYWlsIGZyb20gRGVjZW1iZXIg d2hlcmUgSnVlcmdlbiBwcm9wb3NlZA0KPj4+Pj4+IHRoZSDigJxPdGhlcuKAnSBwcm90b2NvbC4N Cj4+Pj4+Pg0KPj4+Pj4+IEhvcGVmdWxseSB0aGlzIHdpbGwgYmUgYSBzaW1wbGUgbWF0dGVyIG9m IGZpbmRpbmcgYSBiZXR0ZXIgbmFtZQ0KPj4+Pj4+IHRoYW4g4oCcb3RoZXLigJ0uIChPciB5b3Ug Z3V5cyBjb252aW5jaW5nIG1lIHRoYXQg4oCcb3RoZXLigJ0gaXMgcmVhbGx5IHRoZQ0KPj4+Pj4+ IGJlc3QgbmFtZSBmb3IgdGhpcyB2YWx1ZTsgb3IgZXZlbiBBbnRob255IGFzc2VydGluZyBoaXMg cmlnaHQgYXMgYQ0KPj4+Pj4+IG1haW50YWluZXIgdG8gb3ZlcnJ1bGUgbXkgb2JqZWN0aW9uIGlm IGhlIHRoaW5rcyBJ4oCZbSBvdXQgb2YgbGluZS4pDQo+Pj4+Pg0KPj4+Pj4gSSBzYXcgeW91ciBy ZXBseSB0byBWNiBhbmQgSnVlcmdlbidzIGFuc3dlci4gSSBzaGFyZSBKdWVyZ2VuJ3MNCj4+Pj4+ IG9waW5pb24gYXMgd2VsbCBhcyBJIHVuZGVyc3RhbmQgeW91ciBjb25jZXJuLiBJIHRoaW5rLCB0 aGlzIGlzDQo+Pj4+PiBleGFjdGx5IHRoZSBzaXR1YXRpb24gd2hlbiBmaW5kaW5nIGEgcGVyZmVj dCBuYW1lIChvYnZpb3VzLCBzaG9ydCwNCj4+Pj4+IGV0YykgZm9yIHRoZSBiYWNrZW5kdHlwZSAo aW4gb3VyIHBhcnRpY3VsYXIgY2FzZSkgaXMgcmVhbGx5IGRpZmZpY3VsdC4NCj4+Pj4+DQo+Pj4+ PiBQZXJzb25hbGx5IEkgdGVuZCB0byBsZWF2ZSAib3RoZXIiLCBiZWNhdXNlIHRoZXJlIGlzIG5v IGJldHRlcg0KPj4+Pj4gYWx0ZXJuYXRpdmUgZnJvbSBteSBQb1YuIEFsc28gSSBtaWdodCBiZSBj b21wbGV0ZWx5IHdyb25nIGhlcmUsIGJ1dA0KPj4+Pj4gSSBkb24ndCB0aGluayB3ZSB3aWxsIGhh dmUgdG8gZXh0ZW5kIHRoZSAiYmFja2VuZHR5cGUiIGZvcg0KPj4+Pj4gc3VwcG9ydGluZyBvdGhl ciBwb3NzaWJsZSB2aXJ0aW8gYmFja2VuZCBpbXBsZW1lbnRhdGlvbnMgaW4gdGhlDQo+Pj4+PiBm b3Jlc2VlYWJsZSBmdXR1cmU6DQo+Pj4+Pg0KPj4+Pj4gLSB3aGVuIFFlbXUgZ2FpbnMgdGhlIHJl cXVpcmVkIHN1cHBvcnQgd2Ugd2lsbCBjaG9vc2UgcWRpc2s6DQo+Pj4+PiBiYWNrZW5kdHlwZSBx ZGlzayBzcGVjaWZpY2F0aW9uIHZpcnRpbw0KPj4+Pj4gLSBmb3IgdGhlIHBvc3NpYmxlIHZpcnRp byBhbHRlcm5hdGl2ZSBvZiB0aGUgYmxrYmFjayB3ZSB3aWxsIGNob29zZQ0KPj4+Pj4gcGh5OiBi YWNrZW5kdHlwZSBwaHkgc3BlY2lmaWNhdGlvbiB2aXJ0aW8NCj4+Pj4+DQo+Pj4+PiBJZiB0aGVy ZSB3aWxsIGJlIGEgbmVlZCB0byBrZWVwIHZhcmlvdXMgaW1wbGVtZW50YXRpb24sIHdlIHdpbGwg YmUNCj4+Pj4+IGFibGUgdG8gZGVzY3JpYmUgdGhhdCBieSB1c2luZyAidHJhbnNwb3J0IiAobW1p bywgcGNpLCB4ZW5idXMsIGFyZ28sDQo+Pj4+PiB3aGF0ZXZlcikuDQo+Pj4+PiBBY3R1YWxseSB0 aGlzIGlzIHdoeSB3ZSBhbHNvIGludHJvZHVjZWQgInNwZWNpZmljYXRpb24iIGFuZCAidHJhbnNw b3J0Ii4NCj4+Pj4+DQo+Pj4+PiBJSVJDLCB0aGVyZSB3ZXJlIG90aGVyIChzdWdnZXN0ZWQ/KSBu YW1lcyBleGNlcHQgIm90aGVyIiB3aGljaCBhcmUNCj4+Pj4+ICJleHRlcm5hbCIgYW5kICJkYWVt b24iLiBJZiB5b3UgdGhpbmsgdGhhdCBvbmUgb2YgdGhlbSBpcyBiZXR0ZXINCj4+Pj4+IHRoYW4g Im90aGVyIiwgSSB3aWxsIGhhcHB5IHRvIHVzZSBpdC4NCj4+Pj4NCj4+Pj4gQ291bGQgd2UgcGxl YXNlIG1ha2UgYSBkZWNpc2lvbiBvbiB0aGlzPw0KPj4+Pg0KPj4+PiBJZiAib3RoZXIiIGlzIG5v dCB1bmFtYmlndW91cywgdGhlbiBtYXliZSB3ZSBjb3VsZCBjaG9vc2UgImRhZW1vbiIgdG8NCj4+ Pj4gZGVzY3JpYmUgYXJiaXRyYXJ5IHVzZXItbGV2ZWwgYmFja2VuZHMsIGFueSB0aG91Z2h0Pw0K Pj4+IFVuZm9ydHVuYXRlbHkgSSBkaWRu4oCZdCBoYXZlIHRpbWUgdG8gZGlnIGludG8gdGhpczsg SeKAmW0ganVzdCBnb2luZyB0bw0KPj4+IGhhdmUgdG8gd2l0aGRyYXcgbXkgb2JqZWN0aW9uLCBh bmQgbGV0IHlvdSAmIEp1ZXJnZW4gZGVjaWRlIHdoYXQgdG8NCj4+PiBjYWxsIGl0Lg0KPj4gR2Vv cmdlLCB0aGFua3MgZm9yIGxldHRpbmcgbWUga25vdy4gSnVlcmdlbiBwcm9wb3NlZCB0byB1c2Ug InN0YW5kYWxvbmUiDQo+PiBmb3IgdGhlIG5ldyBiYWNrZW5kdHlwZSBuYW1lIHdoaWNoIGlzIGZh ciBtb3JlIHNwZWNpZmljLiBJIGFncmVlIHdpdGggdGhhdC4NCj4+DQo+Pg0KPj4gQW50aG9ueSwg d291bGQgeW91IGJlIGhhcHB5IHdpdGggdGhhdCByZW5hbWluZz8NCj4gSSB0cmllZCB0byBmaWd1 cmUgb3V0IHdoYXQgYmFja2VuZHR5cGUgaXMgc3VwcG9zZWQgdG8gbWVhbiwgaG93IGl0J3MNCj4g dXNlZC4gSSBmZWVsIGl0J3MgcXVpdGUgbWVzc3kgYXQgdGhlIG1vbWVudC4NCj4NCj4gTWFuIHBh Z2UgeGwtZGlzay1jb25maWd1cmF0aW9uIHNheXMgaXQncyBhIGJhY2tlbmQgaW1wbGVtZW50YXRp b24gdG8NCj4gdXNlLiBCZXNpZGUgJ3BoeScsIHdoaWNoIEkgZ3Vlc3MgaXMgdGhlIGtlcm5lbCBv ciBibGtiYWNrLCB0aGUgdHdvIG90aGVyDQo+IHBvaW50IHRvIFFFTVUgKCdxZGlzaycpIGFuZCB0 YXBkaXNrICgndGFwJykuDQo+DQo+IFRoZSwgYmFja2VuZHR5cGUgaXMgdXNlZCB0aHJvdWdob3V0 IGxpYnhsIHRvIGRlYWwgd2l0aCB0aGUgZGlmZmVyZW50DQo+IGJhY2tlbmQgaW1wbGVtZW50YXRp b24sIGFuZCB0aGUgdmFsdWUgaXMgc3RvcmVkIGluIHRoZSB4ZW5zdG9yZSBrZXkNCj4gInR5cGUi LiBGcm9tICJibGtpZi5oIiwgInR5cGUiIHNob3VsZCBiZSAnZmlsZScgb3IgJ3BoeScgb3IgJ3Rh cCcsIGJ1dA0KPiB3ZSBzdG9yZSAncWRpc2snIGZvciAncWRpc2snLi4uIHNvIHRoZSAidHlwZSIg bm90ZSBpbiB4ZW5zdG9yZSBpcw0KPiBwcm9iYWJseSB1c2VsZXNzIGZvciBxZGlzaywgYnV0IG1h eWJlIHVzZWZ1bCBmb3IgJ3BoeSc/IChUaGlzICJ0eXBlIg0KPiBub2RlIGlzIG9ubHkgZm9yIHRo ZSBiYWNrZW5kLCBzbyBwcm9iYWJseSB1c2VsZXNzIGZvciBhIGZyb250IGVuZC4pDQoNCkkgbWln aHQgbWlzdGFrZSwgYnV0IGV2ZW4gdGhlIHByZXNlbmNlIG9mICJ0eXBlIiBub2RlIChvciBvdGhl ciBub2RlcykgDQppbiBYZW5zdG9yZSBpcyB1c2VsZXNzIGZvciBzb21lIGJhY2tlbmQgaW1wbGVt ZW50YXRpb25zLA0KDQp0aGlzIHByb3ZpZGVzIHVzIGFuIGFiaWxpdHkgdG8gcmV0cmlldmUgYWxt b3N0IHdob2xlIGxpYnhsX2RldmljZV9kaXNrIA0KaW5zdGFuY2UgZnJvbSB0aGUgWGVuc3RvcmUg KHBsZWFzZSBzZWUgbGlieGxfX2Rpc2tfZnJvbV94ZW5zdG9yZSgpKS4NCg0KPg0KPiBBbnl3YXks IGl0IHNlZW1zIHRvIG1lIHRoYXQgYmFja2VuZHR5cGUgc2hvdWxkIGJlIHRoZSBuYW1lIG9mIHRo ZQ0KPiBpbXBsZW1lbnRhdGlvbiBvZiB0aGUgYmFja2VuZCB3ZSB3YW50IHRvIHVzZS4gSXQgaXMg anVzdCBhIHBhcmFtZXRlcg0KPiB0byB0ZWxsIGxpYnhsIGhvdyB0byBjb21tdW5pY2F0ZSB3aXRo IHRoZSBiYWNrZW5kLg0KDQpJIGFsc28gdGhpbmsgdGhlIHNhbWUNCg0KDQo+ICAgQXQgdGhlIG1v bWVudCBsaWJ4bA0KPiB1c2VzIHhlbnN0b3JlIHRvIGNvbW11bmljYXRlcyB3aXRoIGFsbCBiYWNr ZW5kcyBldmVuIGlmIHRoYXQncyBub3QNCj4gcmVxdWlyZWQsIGJlY2F1c2UgbGlieGwgd29ya3Mg dGhpcyB3YXkgYW5kIGl0J3MgaGFyZCB0byBjaGFuZ2UuIChXZQ0KPiBjb3VsZCBjb21tdW5pY2F0 ZSB3aXRoIFFFTVUgdmlhIFFNUCByYXRoZXIgdGhhbiB4ZW5zdG9yZSBmb3IgZXhhbXBsZS4pDQo+ DQo+IFNvIEkgZ3Vlc3MgZWl0aGVyIHlvdSBoYXZlIGEgbmFtZSBmb3IgeW91ciBpbXBsZW1lbnRh dGlvbiwgb3Igc29tZXRoaW5nDQo+IGdlbmVyaWMgd2lsbCBkby4gU28gInN0YW5kYWxvbmUiIGlz IGZpbmUuDQoNClRoYW5rcyBmb3IgdGhlIGNvbmZpcm1hdGlvbiENCg0KDQo+DQo+IChXZSBwcm9i YWJseSB3YW50IHRvIGRvY3VtZW50IHNvbWV3aGVyZSB0aGF0IHRoaXMgbmV3IHR5cGUgd291bGQN Cj4gc2ltcGx5IG1lYW4gIm9ubHktcmVseWluZy1vbi14ZW5zdG9yZS1kYXRhIiBsaWtlIEp1ZXJn ZW4gaXMgcHV0dGluZw0KPiBpdCwgYW5kIGlzbid0IGJsa2JhY2sgb3IgUUVNVS4pDQoNCkkgd2ls bCBhZGQgYSBjb21tZW50IGluIGxpYnhsX3R5cGVzLmlkbCB3aGVyZSAiU1RBTkRBTE9ORSIgZW51 bSBpdGVtIGlzIA0KaW50cm9kdWNlZC4NCg0KDQoNCj4NCj4gVGhhbmtzLA0KPg0KLS0gDQpSZWdh cmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K From xen-devel-bounces@lists.xenproject.org Fri Jul 15 16:41:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 16:41:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368346.599574 (Exim 4.92) (envelope-from ) id 1oCONh-0007pO-0m; Fri, 15 Jul 2022 16:41:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368346.599574; Fri, 15 Jul 2022 16:41:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCONg-0007pH-U1; Fri, 15 Jul 2022 16:41:32 +0000 Received: by outflank-mailman (input) for mailman id 368346; Fri, 15 Jul 2022 16:41:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCONg-0007pB-0g for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 16:41:32 +0000 Received: from mail-yb1-f178.google.com (mail-yb1-f178.google.com [209.85.219.178]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9e068a6-045c-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 18:41:30 +0200 (CEST) Received: by mail-yb1-f178.google.com with SMTP id 75so9338167ybf.4 for ; Fri, 15 Jul 2022 09:41:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9e068a6-045c-11ed-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UvwfLw66R/P7k8ZVdzukFQ8abYNVRPzG+g6tIH2YHJ8=; b=Zvvnqz9xlmszutx0qeMIKTYl6BeDQYMGTKHXE+j5GIfBbG+WFavgP02MxvK3FKBegN bgzk05yjaSdy9MWHWLT3vgYqpeCCckpM2LOI9P+pKWHc70vtf//RkG/Em/gJXLXng1ma EheG12HKtrFSoMxdK6xPP7E9nWO0ekUvN7DIQcAI2oIvz+GFDFC8hbomutiJwAWWu08a kBw0pExsGhfSr/2N/5vEBts5Js+4XZtc94wcz5NohPoZT1QcWy8WtssTNWvRs22KywgL sh3OvtW2UvDmWMpNhJ3bh6pZWjPD37/DJUeayutV+dWF3D/37mGPyLs9+2feUjCorfMV SaZw== X-Gm-Message-State: AJIora9B8AHXO4t/mfMROYEAAk0Qd48ID45Xhrn3vjRvJCsALQUhb++f 1wHDv7SJxV0Sj6Yp5G+mQgZd5fiu7jiRoX6L1pg= X-Google-Smtp-Source: AGRyM1vbk52b4PTIMyepiNCX50Et3/hR2FYDZGF2luietd8kabCMCwcigDx9h7LkJfN+B4X89PhLum0ZlW4vpxO2Ga8= X-Received: by 2002:a05:6902:1207:b0:66e:f2d2:6e91 with SMTP id s7-20020a056902120700b0066ef2d26e91mr15502657ybu.153.1657903288940; Fri, 15 Jul 2022 09:41:28 -0700 (PDT) MIME-Version: 1.0 References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-3-jgross@suse.com> In-Reply-To: <20220715142549.25223-3-jgross@suse.com> From: "Rafael J. Wysocki" Date: Fri, 15 Jul 2022 18:41:17 +0200 Message-ID: Subject: Re: [PATCH 2/3] x86: add wrapper functions for mtrr functions handling also pat To: Juergen Gross Cc: xen-devel@lists.xenproject.org, "the arch/x86 maintainers" , Linux Kernel Mailing List , Linux PM , brchuckz@netscape.net, Jan Beulich , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek , Stable Content-Type: text/plain; charset="UTF-8" On Fri, Jul 15, 2022 at 4:25 PM Juergen Gross wrote: > > There are several MTRR functions which also do PAT handling. In order > to support PAT handling without MTRR in the future, add some wrappers > for those functions. > > Cc: # 5.17 > Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > Signed-off-by: Juergen Gross Do I understand correctly that this particular patch doesn't change the behavior? If so, it would be good to mention that in the changelog. > --- > arch/x86/include/asm/mtrr.h | 2 -- > arch/x86/include/asm/processor.h | 7 +++++ > arch/x86/kernel/cpu/common.c | 44 +++++++++++++++++++++++++++++++- > arch/x86/kernel/cpu/mtrr/mtrr.c | 25 +++--------------- > arch/x86/kernel/setup.c | 5 +--- > arch/x86/kernel/smpboot.c | 8 +++--- > arch/x86/power/cpu.c | 2 +- > 7 files changed, 59 insertions(+), 34 deletions(-) > > diff --git a/arch/x86/include/asm/mtrr.h b/arch/x86/include/asm/mtrr.h > index 12a16caed395..900083ac9f60 100644 > --- a/arch/x86/include/asm/mtrr.h > +++ b/arch/x86/include/asm/mtrr.h > @@ -43,7 +43,6 @@ extern int mtrr_del(int reg, unsigned long base, unsigned long size); > extern int mtrr_del_page(int reg, unsigned long base, unsigned long size); > extern void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi); > extern void mtrr_ap_init(void); > -extern void set_mtrr_aps_delayed_init(void); > extern void mtrr_aps_init(void); > extern void mtrr_bp_restore(void); > extern int mtrr_trim_uncached_memory(unsigned long end_pfn); > @@ -86,7 +85,6 @@ static inline void mtrr_centaur_report_mcr(int mcr, u32 lo, u32 hi) > { > } > #define mtrr_ap_init() do {} while (0) > -#define set_mtrr_aps_delayed_init() do {} while (0) > #define mtrr_aps_init() do {} while (0) > #define mtrr_bp_restore() do {} while (0) > #define mtrr_disable() do {} while (0) > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h > index 5c934b922450..e2140204fb7e 100644 > --- a/arch/x86/include/asm/processor.h > +++ b/arch/x86/include/asm/processor.h > @@ -865,7 +865,14 @@ bool arch_is_platform_page(u64 paddr); > #define arch_is_platform_page arch_is_platform_page > #endif > > +extern bool cache_aps_delayed_init; > + > void cache_disable(void); > void cache_enable(void); > +void cache_bp_init(void); > +void cache_ap_init(void); > +void cache_set_aps_delayed_init(void); > +void cache_aps_init(void); > +void cache_bp_restore(void); > > #endif /* _ASM_X86_PROCESSOR_H */ > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index e43322f8a4ef..0a1bd14f7966 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -1929,7 +1929,7 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) > #ifdef CONFIG_X86_32 > enable_sep_cpu(); > #endif > - mtrr_ap_init(); > + cache_ap_init(); > validate_apic_and_package_id(c); > x86_spec_ctrl_setup_ap(); > update_srbds_msr(); > @@ -2403,3 +2403,45 @@ void cache_enable(void) __releases(cache_disable_lock) > > raw_spin_unlock(&cache_disable_lock); > } > + > +void __init cache_bp_init(void) > +{ > + if (IS_ENABLED(CONFIG_MTRR)) > + mtrr_bp_init(); > + else > + pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); > +} > + > +void cache_ap_init(void) > +{ > + if (cache_aps_delayed_init) > + return; > + > + mtrr_ap_init(); > +} > + > +bool cache_aps_delayed_init; > + > +void cache_set_aps_delayed_init(void) > +{ > + cache_aps_delayed_init = true; > +} > + > +void cache_aps_init(void) > +{ > + /* > + * Check if someone has requested the delay of AP cache initialization, > + * by doing cache_set_aps_delayed_init(), prior to this point. If not, > + * then we are done. > + */ > + if (!cache_aps_delayed_init) > + return; > + > + mtrr_aps_init(); > + cache_aps_delayed_init = false; > +} > + > +void cache_bp_restore(void) > +{ > + mtrr_bp_restore(); > +} > diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c > index 2746cac9d8a9..c1593cfae641 100644 > --- a/arch/x86/kernel/cpu/mtrr/mtrr.c > +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c > @@ -69,7 +69,6 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; > static DEFINE_MUTEX(mtrr_mutex); > > u64 size_or_mask, size_and_mask; > -static bool mtrr_aps_delayed_init; > > static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; > > @@ -176,7 +175,8 @@ static int mtrr_rendezvous_handler(void *info) > if (data->smp_reg != ~0U) { > mtrr_if->set(data->smp_reg, data->smp_base, > data->smp_size, data->smp_type); > - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { > + } else if ((use_intel() && cache_aps_delayed_init) || > + !cpu_online(smp_processor_id())) { > mtrr_if->set_all(); > } > return 0; > @@ -789,7 +789,7 @@ void mtrr_ap_init(void) > if (!mtrr_enabled()) > return; > > - if (!use_intel() || mtrr_aps_delayed_init) > + if (!use_intel()) > return; > > /* > @@ -823,16 +823,6 @@ void mtrr_save_state(void) > smp_call_function_single(first_cpu, mtrr_save_fixed_ranges, NULL, 1); > } > > -void set_mtrr_aps_delayed_init(void) > -{ > - if (!mtrr_enabled()) > - return; > - if (!use_intel()) > - return; > - > - mtrr_aps_delayed_init = true; > -} > - > /* > * Delayed MTRR initialization for all AP's > */ > @@ -841,16 +831,7 @@ void mtrr_aps_init(void) > if (!use_intel() || !mtrr_enabled()) > return; > > - /* > - * Check if someone has requested the delay of AP MTRR initialization, > - * by doing set_mtrr_aps_delayed_init(), prior to this point. If not, > - * then we are done. > - */ > - if (!mtrr_aps_delayed_init) > - return; > - > set_mtrr(~0U, 0, 0, 0); > - mtrr_aps_delayed_init = false; > } > > void mtrr_bp_restore(void) > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > index bd6c6fd373ae..27d61f73c68a 100644 > --- a/arch/x86/kernel/setup.c > +++ b/arch/x86/kernel/setup.c > @@ -1001,10 +1001,7 @@ void __init setup_arch(char **cmdline_p) > max_pfn = e820__end_of_ram_pfn(); > > /* update e820 for memory not covered by WB MTRRs */ > - if (IS_ENABLED(CONFIG_MTRR)) > - mtrr_bp_init(); > - else > - pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); > + cache_bp_init(); > > if (mtrr_trim_uncached_memory(max_pfn)) > max_pfn = e820__end_of_ram_pfn(); > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c > index 5e7f9532a10d..535d73a47062 100644 > --- a/arch/x86/kernel/smpboot.c > +++ b/arch/x86/kernel/smpboot.c > @@ -1432,7 +1432,7 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) > > uv_system_init(); > > - set_mtrr_aps_delayed_init(); > + cache_set_aps_delayed_init(); > > smp_quirk_init_udelay(); > > @@ -1443,12 +1443,12 @@ void __init native_smp_prepare_cpus(unsigned int max_cpus) > > void arch_thaw_secondary_cpus_begin(void) > { > - set_mtrr_aps_delayed_init(); > + cache_set_aps_delayed_init(); > } > > void arch_thaw_secondary_cpus_end(void) > { > - mtrr_aps_init(); > + cache_aps_init(); > } > > /* > @@ -1491,7 +1491,7 @@ void __init native_smp_cpus_done(unsigned int max_cpus) > > nmi_selftest(); > impress_friends(); > - mtrr_aps_init(); > + cache_aps_init(); > } > > static int __initdata setup_possible_cpus = -1; > diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c > index bb176c72891c..21e014715322 100644 > --- a/arch/x86/power/cpu.c > +++ b/arch/x86/power/cpu.c > @@ -261,7 +261,7 @@ static void notrace __restore_processor_state(struct saved_context *ctxt) > do_fpu_end(); > tsc_verify_tsc_adjust(true); > x86_platform.restore_sched_clock_state(); > - mtrr_bp_restore(); > + cache_bp_restore(); > perf_restore_debug_store(); > > c = &cpu_data(smp_processor_id()); > -- > 2.35.3 > From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:03:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:03:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368358.599611 (Exim 4.92) (envelope-from ) id 1oCOio-00032D-MG; Fri, 15 Jul 2022 17:03:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368358.599611; Fri, 15 Jul 2022 17:03:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOio-000325-I6; Fri, 15 Jul 2022 17:03:22 +0000 Received: by outflank-mailman (input) for mailman id 368358; Fri, 15 Jul 2022 17:03:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOin-0002vl-Om for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:03:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOin-0001FL-HX; Fri, 15 Jul 2022 17:03:21 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOin-0007gg-93; Fri, 15 Jul 2022 17:03:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=pum9q+DodIOJh9CL2EYHuaYglNoP6XP3Sj591zoPRio=; b=2fBkNdi6/m3/X6Wou0bgX6JPce qLAUC8Sr8RnnatsnR64C2ES95wTF2jFTxUlGPMeFxZcxBNcm0sT2R59e5MjOfsPr8sxtua8nXdTis ltNNkjpuu9pJiVbe0hiKfeMd1C69u1+gJwhvi52nwpi1bNBquslFm07rlbLPsz73lPeo=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Hongyan Xia , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall Subject: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init Date: Fri, 15 Jul 2022 18:03:12 +0100 Message-Id: <20220715170312.13931-4-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220715170312.13931-1-julien@xen.org> References: <20220715170312.13931-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Hongyan Xia The idea is to split the range into multiple aligned power-of-2 regions which only needs to call free_heap_pages() once each. We check the least significant set bit of the start address and use its bit index as the order of this increment. This makes sure that each increment is both power-of-2 and properly aligned, which can be safely passed to free_heap_pages(). Of course, the order also needs to be sanity checked against the upper bound and MAX_ORDER. Tested on a nested environment on c5.metal with various amount of RAM and CONFIG_DEBUG=n. Time for end_boot_allocator() to complete: Before After - 90GB: 1445 ms 96 ms - 8GB: 126 ms 8 ms - 4GB: 62 ms 4 ms Signed-off-by: Hongyan Xia Signed-off-by: Julien Grall --- Changes in v2: - Update comment - Update the numbers. They are slightly better as is_contig_page() has been folded in init_heap_pages(). --- xen/common/page_alloc.c | 35 ++++++++++++++++++++++++++++++++--- 1 file changed, 32 insertions(+), 3 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index eedb2fed77c3..2b99801d2ea3 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1779,7 +1779,7 @@ int query_page_offline(mfn_t mfn, uint32_t *status) /* * This function should only be called with valid pages from the same NUMA - * node. + * node and zone. */ static void _init_heap_pages(const struct page_info *pg, unsigned long nr_pages, @@ -1806,8 +1806,22 @@ static void _init_heap_pages(const struct page_info *pg, while ( s < e ) { - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); - s += 1UL; + /* + * For s == 0, we simply use the largest increment by checking the + * MSB of the region size. For s != 0, we also need to ensure that the + * chunk is properly sized to end at power-of-two alignment. We do this + * by checking the LSB of the start address and use its index as + * the increment. Both cases need to be guarded by MAX_ORDER. + * + * Note that the value of ffsl() and flsl() starts from 1 so we need + * to decrement it by 1. + */ + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); + + if ( s ) + inc_order = min(inc_order, ffsl(s) - 1); + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); + s += (1UL << inc_order); } } @@ -1844,6 +1858,9 @@ static void init_heap_pages( for ( i = 0; i < nr_pages; ) { +#ifdef CONFIG_SEPARATE_XENHEAP + unsigned int zone = page_to_zone(pg); +#endif unsigned int nid = phys_to_nid(page_to_maddr(pg)); unsigned long left = nr_pages - i; unsigned long contig_pages; @@ -1856,6 +1873,18 @@ static void init_heap_pages( */ for ( contig_pages = 1; contig_pages < left; contig_pages++ ) { + /* + * No need to check for the zone when !CONFIG_SEPARATE_XENHEAP + * because free_heap_pages() can only take power-of-two ranges + * which never cross zone boundaries. But for separate xenheap + * which is manually defined, it is possible for power-of-two + * range to cross zones. + */ +#ifdef CONFIG_SEPARATE_XENHEAP + if ( zone != page_to_zone(pg) ) + break; +#endif + if ( nid != (phys_to_nid(page_to_maddr(pg))) ) break; } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:03:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:03:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368357.599606 (Exim 4.92) (envelope-from ) id 1oCOio-00030M-ED; Fri, 15 Jul 2022 17:03:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368357.599606; Fri, 15 Jul 2022 17:03:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOio-00030F-Az; Fri, 15 Jul 2022 17:03:22 +0000 Received: by outflank-mailman (input) for mailman id 368357; Fri, 15 Jul 2022 17:03:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOim-0002eD-CJ for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:03:20 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOim-0001F6-6Z; Fri, 15 Jul 2022 17:03:20 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOil-0007gg-VD; Fri, 15 Jul 2022 17:03:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=Bsjke5ID8DQGCSuhgcRoj1MKXOjC6ERn1kNwJSr/oAY=; b=2lD/AJZDGttXngLR3/Ei8/hPKh vQblHlz9cPwU18EDIXMCP+gM4miqO130gb79XxyaSwpQXu32mKjVSyUQnHM906ffE7Rc78pUdeg48 ddsIJVlVcJM+N1BORfYS3bACL/EJJR4SKqbMJAIGwLyItVT+jDAP/xRNy4DjGtmpk/CE=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two Date: Fri, 15 Jul 2022 18:03:11 +0100 Message-Id: <20220715170312.13931-3-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220715170312.13931-1-julien@xen.org> References: <20220715170312.13931-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, init_heap_pages() will call free_heap_pages() page by page. To reduce the time to initialize the heap, we will want to provide multiple pages at the same time. init_heap_pages() is now split in two parts: - init_heap_pages(): will break down the range in multiple set of contiguous pages. For now, the criteria is the pages should belong to the same NUMA node. - _init_heap_pages(): will initialize a set of pages belonging to the same NUMA node. In a follow-up patch, new requirements will be added (e.g. pages should belong to the same zone). For now the pages are still passed one by one to free_heap_pages(). Note that the comment before init_heap_pages() is heavily outdated and does not reflect the current code. So update it. This patch is a merge/rework of patches from David Woodhouse and Hongyan Xia. Signed-off-by: Julien Grall --- Interestingly, I was expecting this patch to perform worse. However, from testing there is a small increase in perf. That said, I mainly plit the patch because it keeps refactoring and optimization separated. Changes in v2: - Rename init_contig_pages() to _init_heap_pages() - Fold is_contig_page() --- xen/common/page_alloc.c | 77 ++++++++++++++++++++++++++--------------- 1 file changed, 50 insertions(+), 27 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 078c2990041d..eedb2fed77c3 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) } /* - * Hand the specified arbitrary page range to the specified heap zone - * checking the node_id of the previous page. If they differ and the - * latter is not on a MAX_ORDER boundary, then we reserve the page by - * not freeing it to the buddy allocator. + * This function should only be called with valid pages from the same NUMA + * node. */ +static void _init_heap_pages(const struct page_info *pg, + unsigned long nr_pages, + bool need_scrub) +{ + unsigned long s, e; + unsigned int nid = phys_to_nid(page_to_maddr(pg)); + + s = mfn_x(page_to_mfn(pg)); + e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); + if ( unlikely(!avail[nid]) ) + { + bool use_tail = IS_ALIGNED(s, 1UL << MAX_ORDER) && + (find_first_set_bit(e) <= find_first_set_bit(s)); + unsigned long n; + + n = init_node_heap(nid, s, nr_pages, &use_tail); + BUG_ON(n > nr_pages); + if ( use_tail ) + e -= n; + else + s += n; + } + + while ( s < e ) + { + free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); + s += 1UL; + } +} + static void init_heap_pages( struct page_info *pg, unsigned long nr_pages) { unsigned long i; - bool idle_scrub = false; + bool need_scrub = scrub_debug; /* * Keep MFN 0 away from the buddy allocator to avoid crossing zone @@ -1812,35 +1840,30 @@ static void init_heap_pages( spin_unlock(&heap_lock); if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) - idle_scrub = true; + need_scrub = true; - for ( i = 0; i < nr_pages; i++ ) + for ( i = 0; i < nr_pages; ) { - unsigned int nid = phys_to_nid(page_to_maddr(pg+i)); + unsigned int nid = phys_to_nid(page_to_maddr(pg)); + unsigned long left = nr_pages - i; + unsigned long contig_pages; - if ( unlikely(!avail[nid]) ) + /* + * _init_heap_pages() is only able to accept range following + * specific property (see comment on top of _init_heap_pages()). + * + * So break down the range in smaller set. + */ + for ( contig_pages = 1; contig_pages < left; contig_pages++ ) { - unsigned long s = mfn_x(page_to_mfn(pg + i)); - unsigned long e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); - bool use_tail = (nid == phys_to_nid(pfn_to_paddr(e - 1))) && - IS_ALIGNED(s, 1UL << MAX_ORDER) && - (find_first_set_bit(e) <= find_first_set_bit(s)); - unsigned long n; - - n = init_node_heap(nid, mfn_x(page_to_mfn(pg + i)), nr_pages - i, - &use_tail); - BUG_ON(i + n > nr_pages); - if ( n && !use_tail ) - { - i += n - 1; - continue; - } - if ( i + n == nr_pages ) + if ( nid != (phys_to_nid(page_to_maddr(pg))) ) break; - nr_pages -= n; } - free_heap_pages(pg + i, 0, scrub_debug || idle_scrub); + _init_heap_pages(pg, contig_pages, need_scrub); + + pg += contig_pages; + i += contig_pages; } } -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:03:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:03:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368356.599596 (Exim 4.92) (envelope-from ) id 1oCOin-0002ko-6a; Fri, 15 Jul 2022 17:03:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368356.599596; Fri, 15 Jul 2022 17:03:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOin-0002kh-3h; Fri, 15 Jul 2022 17:03:21 +0000 Received: by outflank-mailman (input) for mailman id 368356; Fri, 15 Jul 2022 17:03:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOil-0002V9-8x for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:03:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOil-0001Ep-04; Fri, 15 Jul 2022 17:03:19 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOik-0007gg-OO; Fri, 15 Jul 2022 17:03:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=8L8GaWN4JsHGX2p2Nk+ZEuevrv2pgtM1BqqTvQho3HU=; b=oIFyXXGVlvAjFNf6w0dtHA7myt IoggkwA7PiN1xkHSZzMzs3+FqFapQYFRpXAWCZJAcuPAZq1W5AYHrL10A8GVPu109C3ahP4jQNG+T Asse8pCVipotB0F+W2EWTyipZwHXPtf/IesJ4GKoNDHebe6sGEpqUpyNxU/H7deNrEYk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH v2 1/3] xen: page_alloc: Don't open-code IS_ALIGNED() Date: Fri, 15 Jul 2022 18:03:10 +0100 Message-Id: <20220715170312.13931-2-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220715170312.13931-1-julien@xen.org> References: <20220715170312.13931-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace it to improve the readability of the code. No functional change intended. Signed-off-by: Julien Grall --- Changes in v2: - Patch added --- xen/common/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index fe0e15429af3..078c2990041d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1823,7 +1823,7 @@ static void init_heap_pages( unsigned long s = mfn_x(page_to_mfn(pg + i)); unsigned long e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); bool use_tail = (nid == phys_to_nid(pfn_to_paddr(e - 1))) && - !(s & ((1UL << MAX_ORDER) - 1)) && + IS_ALIGNED(s, 1UL << MAX_ORDER) && (find_first_set_bit(e) <= find_first_set_bit(s)); unsigned long n; -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:03:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:03:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368355.599584 (Exim 4.92) (envelope-from ) id 1oCOil-0002VM-UL; Fri, 15 Jul 2022 17:03:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368355.599584; Fri, 15 Jul 2022 17:03:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOil-0002VF-Rb; Fri, 15 Jul 2022 17:03:19 +0000 Received: by outflank-mailman (input) for mailman id 368355; Fri, 15 Jul 2022 17:03:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOik-0002V3-40 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:03:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOij-0001Ef-Px; Fri, 15 Jul 2022 17:03:17 +0000 Received: from 54-240-197-232.amazon.com ([54.240.197.232] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOij-0007gg-HY; Fri, 15 Jul 2022 17:03:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=09GQn0LINaeqQf4APUPgbQ6Hh70i4IAy8Q6zOjVfr9g=; b=nfPUoe JhHcd7NAMFmQt8Nj/+L1Ykhareh3XuABnLpPC9jA4eZDIc2rHCsjhIhtwpMojhkNNyDVKiKBqpEAt mnPndFKutLV7KSEGUo9PqZNR+7M4q6GbXjWUJnJetALQ/0upd7oCwLKpLf6gIU0wAVcKklydaLSrl e/12lZobtPk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu Subject: [PATCH v2 0/3] xen/mm: Optimize init_heap_pages() Date: Fri, 15 Jul 2022 18:03:09 +0100 Message-Id: <20220715170312.13931-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, As part of the Live-Update work, we noticed that a big part Xen boot is spent to add pages in the heap. For instance, on when running Xen in a nested envionment on a c5.metal with 90GB, it takes ~1.4s. This small series is reworking init_heap_pages() to give the pages to free_heap_pages() by chunk rather than one by one. With this approach, the time spent to init the heap is down to 96 ms in the setup mention above. There is potentially one more optimization possible that would allow to further reduce the time spent. The new approach is accessing the page information multiple time in separate loop that can potentially be large. Cheers, Julien Grall (2): xen: page_alloc: Don't open-code IS_ALIGNED() xen/heap: Split init_heap_pages() in two xen/heap: pass order to free_heap_pages() in heap init xen/common/page_alloc.c | 106 ++++++++++++++++++++++++++++++---------- 1 file changed, 79 insertions(+), 27 deletions(-) -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:05:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:05:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368369.599628 (Exim 4.92) (envelope-from ) id 1oCOkr-0004k9-1t; Fri, 15 Jul 2022 17:05:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368369.599628; Fri, 15 Jul 2022 17:05:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOkq-0004k2-UY; Fri, 15 Jul 2022 17:05:28 +0000 Received: by outflank-mailman (input) for mailman id 368369; Fri, 15 Jul 2022 17:05:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOkq-0004jp-1X; Fri, 15 Jul 2022 17:05:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOkp-0001Jb-VD; Fri, 15 Jul 2022 17:05:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOkp-00028x-BP; Fri, 15 Jul 2022 17:05:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCOkp-0004SU-Ax; Fri, 15 Jul 2022 17:05:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XWKqt1J1VTNWbnp3tvER4ryufxnnw+bJ/oGYswVegX8=; b=hZyGW7DvgTQNhcan3CA+eujOCc p7SSjwjMcZJY6Tx0bvrsIkZAjNaQmtkUSQxtpMBVEkQA2OWgjKBHa3N4RukD12USXd9+jFlbL02ZT lGhdsewNWpyJXrUgOc1iBHQIUSFYPADyzWxOL39UkwlqLf8d4BFB1GA9qFlSAJHgBU1Y=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171635: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=db886979683a8360ced9b24ab1125ad0c4d2cf76 X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Fri, 15 Jul 2022 17:05:27 +0000 flight 171635 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171635/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux db886979683a8360ced9b24ab1125ad0c4d2cf76 baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 3 days Failing since 171601 2022-07-12 16:11:30 Z 3 days 4 attempts Testing same since 171635 2022-07-14 22:41:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alex Deucher Alexandre Chartre Alexei Starovoitov Alyssa Rosenzweig Andrea Mayer Andrew Cooper Ansgar Lößer Ansgar Lößer Ard Biesheuvel Arnd Bergmann Baowen Zheng Borislav Petkov Brent Lu Bryan O'Donoghue Charles Keepax Chia-Lin Kao (AceLan) Christian Brauner (Microsoft) Christian Brauner Christian König Chuck Lever Coiby Xu Dan Carpenter Daniel Borkmann Daniel Mack Daniele Ceraolo Spurio Dave Airlie Dave Chinner Dave Hansen David Owens David Owens David S. Miller Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Felix Fietkau Florian Westphal Francesco Dolcini Gal Pressman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Huaxin Lu Igor Mammedov Jakub Kicinski Jason Wang Javier Martinez Canillas Jeff Layton Jeremy Szu Jianglei Nie Joanne Koong Johan Almbladh Johannes Berg Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Kashyap Desai Kefeng Wang Kim Phillips Konrad Rzeszutek Wilk Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Liu Ying Liu, Changcheng Lorenzo Bianconi Marek Vasut Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthieu Baerts Maxim Mikityanskiy Maxime Ripard Meng Tang Michael Chan Michael Ellerman Miklos Szeredi Mimi Zohar Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Nirmoy Das Oder Chiou Pablo Neira Ayuso Paolo Abeni Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Ping-Ke Shih Rodrigo Vivi Roi Dayan Russell King (Oracle) Ryder Lee Saeed Mahameed Sascha Hauer Shyam Prasad N Siddharth Vadapalli Simon Horman Stefan Berger Steve French Steven Price Steven Rostedt (Google) sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Zimmermann Tianyu Yuan Tiezhu Yang Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Nguyen Vikas Gupta Vinayak Yadawad Wang Kefeng Will Deacon xinhui pan Xiu Jianfeng Yassine Oudjana Yevhen Orlov Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5692 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:15:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:15:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368392.599640 (Exim 4.92) (envelope-from ) id 1oCOuZ-0006h2-5O; Fri, 15 Jul 2022 17:15:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368392.599640; Fri, 15 Jul 2022 17:15:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOuZ-0006gv-1s; Fri, 15 Jul 2022 17:15:31 +0000 Received: by outflank-mailman (input) for mailman id 368392; Fri, 15 Jul 2022 17:15:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOuX-0006gp-79 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:15:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOuW-0001UT-JZ; Fri, 15 Jul 2022 17:15:28 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOuW-0008Or-Di; Fri, 15 Jul 2022 17:15:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jrJT0zNET/jrL2M1ahTkFOn4gMSsVaqUsxXHTqhaxs0=; b=bOc8OBGYtaB4BPVF7VnsgAKHlK nfx/nKEp1ZtcT5eBYVZSkEcvQyApPl5SqsQe6Tx6PQq+Mo8K9taO70yec3rG7nzzbjiuim+GC8qcC jCpVxHdoUN4mNL3z4M150urRzjSQ2CVCCr8wO/1u5dUCaaWX+UFHi4fitJBugRVIWn/Y=; Message-ID: Date: Fri, 15 Jul 2022 18:15:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V6 2/2] xen/arm: Harden the P2M code in p2m_remove_mapping() To: Oleksandr , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> <1652294845-13980-2-git-send-email-olekstysh@gmail.com> <42b0d343-a491-877c-3b5c-d9c95872774c@xen.org> <94afe35c-627c-8aba-37ce-1d017a2e4e3c@gmail.com> From: Julien Grall In-Reply-To: <94afe35c-627c-8aba-37ce-1d017a2e4e3c@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 24/06/2022 16:31, Oleksandr wrote: > > On 23.06.22 21:08, Julien Grall wrote: >> Hi Oleksandr, > > > Hello Julien Hi Oleksandr, > >> >> On 11/05/2022 19:47, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> Borrow the x86's check from p2m_remove_page() which was added >>> by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e >>> "x86/p2m: don't assert that the passed in MFN matches for a remove" >>> and adjust it to the Arm code base. >>> >>> Basically, this check is strictly needed for the xenheap pages only >>> since there are several non-protected read accesses to our simplified >>> xenheap based M2P approach on Arm (most calls to page_get_xenheap_gfn() >>> are not protected by the P2M lock). >> >> To me, this read as you introduced a bug in patch #1 and now you are >> fixing it. So this patch should have been first. > > > Sounds like yes, I agree. But, in that case I propose to rewrite this > text like the following: > > > Basically, this check will be strictly needed for the xenheap pages only > *and* only after applying subsequent NIT: s/only and only/, this is pretty clear that this patch is necessary for a follow-up patch. Also please add "a" in from of subsequent because the two patches may not be committed together. > commit which will introduce xenheap based M2P approach on Arm. But, it > will be a good opportunity > to harden the P2M code for *every* RAM pages since it is possible to > remove any GFN - MFN mapping > currently on Arm (even with the wrong helpers). [...] >>> >>> Suggested-by: Julien Grall >>> Signed-off-by: Oleksandr Tyshchenko >>> --- >>> You can find the corresponding discussion at: >>> https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/ >>> >>> >>> Changes V5 -> V6: >>>   - new patch >>> --- >>>   xen/arch/arm/p2m.c | 21 +++++++++++++++++++++ >>>   1 file changed, 21 insertions(+) >>> >>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>> index f87b48e..635e474 100644 >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -1311,11 +1311,32 @@ static inline int p2m_remove_mapping(struct >>> domain *d, >>>                                        mfn_t mfn) >>>   { >>>       struct p2m_domain *p2m = p2m_get_hostp2m(d); >>> +    unsigned long i; >>>       int rc; >>>         p2m_write_lock(p2m); >>> +    for ( i = 0; i < nr; ) >> One bit I really hate in the x86 code is the lack of in-code >> documentation. It makes really difficult to understand the logic. >> >> I know this code was taken from x86, but I would like to avoid making >> same mistake (this code is definitely not trivial). So can we document >> the logic? > > > ok, I propose the following text right after acquiring the p2m lock: > > >  /* >   * Before removing the GFN - MFN mapping for any RAM pages make sure >   * that there is no difference between what is already mapped and what >   * is requested to be unmapped. If passed mapping doesn't match >   * the existing one bail out early. NIT: I would simply write "If they don't match bail out early". Also, it would be good to explanation how this could happen. Something like: "For instance, this could happen if two CPUs are requesting to unmap the same P2M concurrently." >   */ > > > Could you please clarify, do you agree with both? I have proposed some changes in both cases. I originally thought I would do the update in the commit. However, this is more than simple tweak, so would you mind to send a new version? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:16:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:16:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368398.599651 (Exim 4.92) (envelope-from ) id 1oCOvv-0007d4-FQ; Fri, 15 Jul 2022 17:16:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368398.599651; Fri, 15 Jul 2022 17:16:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOvv-0007cx-BY; Fri, 15 Jul 2022 17:16:55 +0000 Received: by outflank-mailman (input) for mailman id 368398; Fri, 15 Jul 2022 17:16:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOvu-0007cp-B9 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:16:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCOvq-0001VW-K7; Fri, 15 Jul 2022 17:16:50 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCOvq-0008Pm-Dn; Fri, 15 Jul 2022 17:16:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=k8r5A+QcoZnfq5aXkyslmIh+0yDUBkX2OrrbbjBNL30=; b=zejudGc08amAcllnsAUF/ZbuZX 1pF/aESusrd0b8CnM40xKGpHaoY5S6N5FFCLqN9tEmzN+W2YEJdTUVxI3nhnpQNW3mevmEwvZ1Hi8 Ebzc/gSUf/iZPzagmwgiCaUyhaZGJUcZneI8l1k9Ia8Tb7o2Bs5ZYsXMw2tqiQjVp3LQ=; Message-ID: Date: Fri, 15 Jul 2022 18:16:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] xen/heap: pass order to free_heap_pages() in heap init To: Jan Beulich Cc: bertrand.marquis@arm.com, Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220609083039.76667-1-julien@xen.org> <20220609083039.76667-3-julien@xen.org> <4462bfdf-fc24-12df-0f16-7c09d0618d0f@suse.com> From: Julien Grall In-Reply-To: <4462bfdf-fc24-12df-0f16-7c09d0618d0f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 09/06/2022 14:22, Jan Beulich wrote: >> /* >> * This function should only be called with valid pages from the same NUMA >> - * node. >> + * node and the same zone. >> * >> * Callers should use is_contig_page() first to check if all the pages >> * in a range are contiguous. >> @@ -1817,8 +1829,22 @@ static void init_contig_heap_pages(struct page_info *pg, unsigned long nr_pages, >> >> while ( s < e ) >> { >> - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); >> - s += 1UL; >> + /* >> + * For s == 0, we simply use the largest increment by checking the >> + * index of the MSB set. For s != 0, we also need to ensure that the > > "The MSB" reads as it it was not in line with the code; at least I would, > short of it being spelled out, assume it can only be the page's address > which is meant (as is the case for LSB below). But it's the MSB of the > range's size. Indeed. I have reworded the comment to: /* * For s == 0, we simply use the largest increment by checking the * MSB of the region size. For s != 0, we also need to ensure that the * chunk is properly sized to end at power-of-two alignment. We do this * by checking the LSB of the start address and use its index as * the increment. Both cases need to be guarded by MAX_ORDER. * * Note that the value of ffsl() and flsl() starts from 1 so we need * to decrement it by 1. */ > >> + * chunk is properly sized to end at power-of-two alignment. We do this >> + * by checking the LSB set and use its index as the increment. Both >> + * cases need to be guarded by MAX_ORDER. >> + * >> + * Note that the value of ffsl() and flsl() starts from 1 so we need >> + * to decrement it by 1. >> + */ >> + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); >> + >> + if ( s ) >> + inc_order = min(inc_order, ffsl(s) - 1); >> + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); >> + s += (1UL << inc_order); >> } >> } >> >> @@ -1856,12 +1882,13 @@ static void init_heap_pages( >> for ( i = 0; i < nr_pages; ) >> { >> unsigned int nid = phys_to_nid(page_to_maddr(pg)); >> + unsigned int zone = page_to_zone(pg); >> unsigned long left = nr_pages - i; >> unsigned long contig_pages; >> >> for ( contig_pages = 1; contig_pages < left; contig_pages++ ) >> { >> - if ( !is_contig_page(pg + contig_pages, nid) ) >> + if ( !is_contig_page(pg + contig_pages, nid, zone) ) >> break; >> } > > Coming back to your reply to my comment on patch 1: I think this > addition of the node check is actually an argument for inlining the > function's body here (and then dropping the function). That way the > separate-Xen-heap aspect is visible at the place where it matters, > rather than requiring an indirection via looking at the helper > function (and leaving a dead parameter in the opposite case). But as > said - I'm not going to insist as long as the helper function has a > suitable name (representing what it does and not misguiding anyone > with the common "contig"-means-addresses implication). I have followed your suggestion in patch #1: * is_contig_page() is now inlined * init_contig_heap_pages() was renamed to _init_heap_pages() Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:24:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:24:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368405.599661 (Exim 4.92) (envelope-from ) id 1oCP3L-0000gb-6G; Fri, 15 Jul 2022 17:24:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368405.599661; Fri, 15 Jul 2022 17:24:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCP3L-0000gU-3Z; Fri, 15 Jul 2022 17:24:35 +0000 Received: by outflank-mailman (input) for mailman id 368405; Fri, 15 Jul 2022 17:24:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCP3J-0000gO-Cx for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:24:33 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fd4dba56-0462-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 19:24:32 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id u13so8907117lfn.5 for ; Fri, 15 Jul 2022 10:24:32 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g18-20020ac24d92000000b0048650aee2b2sm998680lfe.144.2022.07.15.10.24.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 10:24:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd4dba56-0462-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=JEdvamrpt2hB1WAOJO1ivuRpQdwFZrXR4pbATBn9fnE=; b=JH97wN2Yok2ZTjYnJIDWN1yDkPbwz8bQ/KYvnwgORo8jWpKfXFv8YXumtGOoCXz6AR greiZ7W/ETN+uv7X7UP6A8tTMo51qAcCb0A7nVMpBX/N5c0Nl0ssNDVysVztTjQ5HTWJ ThokglJ4GZSDoYSUCUemsGsl1Wqf0FpGiQQ/MoId3Pb23hTqI1sp3x2ihY9MP1SCehDo SffSOF583vlsli++q9rlodBHhhIMApQDERbc6VJPTfRPsbaHeKnbPfIfeZsk3ZENTbd0 rgoiwn2r1n8CaX0gMtcl9CrX5uPAmEKW2U0AV2+9nBniyM0sluAoWldqYuFYuX/dxsID Lwuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=JEdvamrpt2hB1WAOJO1ivuRpQdwFZrXR4pbATBn9fnE=; b=u2Hj9xZF7IKufvBWZwrc5og1TFf7VF42QPcFkGySEhQQB4hFbQzPXcdB6HZAm187LO h7h1ACHROR+zAv5bbUu9/I5ToHgTwKaT7GuB1Pbt3hebw1Oi0NILE+A66C2MS6w3hmgg Hpa3EFAlG6LZWeqFZeMHiVRV2h+aUrxz6AUOgBgKxBeoQSom25y7KVWCd3Ia1dCNBKCG seBM0yMM2Xwz/y2aBawSoZXgkz7yE2Y0gBQfnPDSAfU30UewlUgdTmZk52+WjfiFKidD 19QVzhybu+XTahaagEHDIo7rt8hUBqcaZqSXCsvrSbQBYpDuOaUB9HaXbPHpxGBk2IUa PiIQ== X-Gm-Message-State: AJIora/XcadVXrGbry1mCPQIE47OHx6CCJLdrUHimSCRZbSAnp/cemeY uxKp3Cgf1pk1qbOfyigu/tk= X-Google-Smtp-Source: AGRyM1uelt0c3CLX/j5YrgBuNrQk9BWSDGWhfh8ZnoqMnjPIiYUxF38lsh43aLJz0evIhP2WrUaCUw== X-Received: by 2002:a05:6512:2397:b0:487:8ae9:7486 with SMTP id c23-20020a056512239700b004878ae97486mr8096105lfv.102.1657905871680; Fri, 15 Jul 2022 10:24:31 -0700 (PDT) Message-ID: <313ce039-31c2-1081-b044-d39c940e7565@gmail.com> Date: Fri, 15 Jul 2022 20:24:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V6 2/2] xen/arm: Harden the P2M code in p2m_remove_mapping() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> <1652294845-13980-2-git-send-email-olekstysh@gmail.com> <42b0d343-a491-877c-3b5c-d9c95872774c@xen.org> <94afe35c-627c-8aba-37ce-1d017a2e4e3c@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15.07.22 20:15, Julien Grall wrote: > > > On 24/06/2022 16:31, Oleksandr wrote: >> >> On 23.06.22 21:08, Julien Grall wrote: >>> Hi Oleksandr, >> >> >> Hello Julien > > Hi Oleksandr, Hello Julien > > >> >>> >>> On 11/05/2022 19:47, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Tyshchenko >>>> >>>> Borrow the x86's check from p2m_remove_page() which was added >>>> by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e >>>> "x86/p2m: don't assert that the passed in MFN matches for a remove" >>>> and adjust it to the Arm code base. >>>> >>>> Basically, this check is strictly needed for the xenheap pages only >>>> since there are several non-protected read accesses to our simplified >>>> xenheap based M2P approach on Arm (most calls to >>>> page_get_xenheap_gfn() >>>> are not protected by the P2M lock). >>> >>> To me, this read as you introduced a bug in patch #1 and now you are >>> fixing it. So this patch should have been first. >> >> >> Sounds like yes, I agree. But, in that case I propose to rewrite this >> text like the following: >> >> >> Basically, this check will be strictly needed for the xenheap pages >> only *and* only after applying subsequent > > NIT: s/only and only/, this is pretty clear that this patch is > necessary for a follow-up patch. ok > > > Also please add "a" in from of subsequent because the two patches may > not be committed together. ok > >> commit which will introduce xenheap based M2P approach on Arm. But, >> it will be a good opportunity >> to harden the P2M code for *every* RAM pages since it is possible to >> remove any GFN - MFN mapping >> currently on Arm (even with the wrong helpers). > > [...] > >>>> >>>> Suggested-by: Julien Grall >>>> Signed-off-by: Oleksandr Tyshchenko >>>> --- >>>> You can find the corresponding discussion at: >>>> https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/ >>>> >>>> >>>> Changes V5 -> V6: >>>>   - new patch >>>> --- >>>>   xen/arch/arm/p2m.c | 21 +++++++++++++++++++++ >>>>   1 file changed, 21 insertions(+) >>>> >>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>>> index f87b48e..635e474 100644 >>>> --- a/xen/arch/arm/p2m.c >>>> +++ b/xen/arch/arm/p2m.c >>>> @@ -1311,11 +1311,32 @@ static inline int p2m_remove_mapping(struct >>>> domain *d, >>>>                                        mfn_t mfn) >>>>   { >>>>       struct p2m_domain *p2m = p2m_get_hostp2m(d); >>>> +    unsigned long i; >>>>       int rc; >>>>         p2m_write_lock(p2m); >>>> +    for ( i = 0; i < nr; ) >>> One bit I really hate in the x86 code is the lack of in-code >>> documentation. It makes really difficult to understand the logic. >>> >>> I know this code was taken from x86, but I would like to avoid >>> making same mistake (this code is definitely not trivial). So can we >>> document the logic? >> >> >> ok, I propose the following text right after acquiring the p2m lock: >> >> >>   /* >>    * Before removing the GFN - MFN mapping for any RAM pages make sure >>    * that there is no difference between what is already mapped and what >>    * is requested to be unmapped. If passed mapping doesn't match >>    * the existing one bail out early. > > NIT: I would simply write "If they don't match bail out early". ok, I guess this is related to the last sentence only. > > Also, it would be good to explanation how this could happen. Something > like: > > "For instance, this could happen if two CPUs are requesting to unmap > the same P2M concurrently." agree > > >>    */ >> >> >> Could you please clarify, do you agree with both? > > I have proposed some changes in both cases. I originally thought I > would do the update in the commit. However, this is more than simple > tweak, so would you mind to send a new version? yes, will do > > > Cheers, > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:29:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:29:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368412.599672 (Exim 4.92) (envelope-from ) id 1oCP7f-0001ev-OC; Fri, 15 Jul 2022 17:29:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368412.599672; Fri, 15 Jul 2022 17:29:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCP7f-0001eo-Kc; Fri, 15 Jul 2022 17:29:03 +0000 Received: by outflank-mailman (input) for mailman id 368412; Fri, 15 Jul 2022 17:29:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCP7e-0001ei-U4 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:29:03 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c1d026c-0463-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 19:29:00 +0200 (CEST) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 15 Jul 2022 13:28:57 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM4PR03MB6860.namprd03.prod.outlook.com (2603:10b6:8:43::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.26; Fri, 15 Jul 2022 17:28:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.019; Fri, 15 Jul 2022 17:28:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c1d026c-0463-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1657906140; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=mXJLVFrcthD42hxcsZ+JmmHuqPHK0pqLkI928Y/v8uw=; b=WT9gA0AZq4vSo+vpRhi2/n6fbyeACj9Ihx+C27gzfQqwRPEn++HI3IQx 2fEb7CNsdqglj6WfzVeSXNatxGmGEOs9vORGogGYn3YRk9QyR2sddMG2O 8ZU1b9y81OgzYTtH8YJP+1SFTdFB1UdQa5MOP2CTQr4snyFxZswlCQzYH U=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 75903211 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EMxiYqgC5MbQlzt1mIcNrsMKX161GBEKZh0ujC45NGQN5FlHY01je htvXWnSbq2CYmv8edF/Ptuy9kgDu56Bz4M1HAVq+CxhRCkb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur5WtD1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eZbYy6+B+JnN0z Mc2KDsXN0C4vfCx3+fuIgVsrpxLwMjDGqo64ysl5xeJSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9RTM+vJfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2i3x17eUx3qiMG4UPLiZrdFLhUHP/XU8FhM1dF61ivqSjGfrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWblXoVRZEYd0i8cUwFToj0 wbTm8uzXGM39rqIVXia67GY6yuoPjQYJnMDYilCShYZ597ko8c4iRenostfLZNZR+bdQVnYq w1mZgBl71nPpabnD5mGwG0= IronPort-HdrOrdr: A9a23:pWCG6qgd+xH7+MJKYhpW9QLKd3BQX3Z13DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQJVp2RvnhNRICPoqTMyftW7dySaVxeBZnMDfKljbdxEWmdQtsZ uIH5IeNDS0NykCsS+Y2nj1Lz9D+qjhzEnAv463oBlQpENRGsddBmxCe2Wm+zhNNWx77O0CZf ihD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnX4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlVFtyssHfpWG1SYczBgNkHmpDr1L/sqq iJn/4UBbUx15oWRBDznfKi4Xin7N9k0Q6Z9bbRuwqfnSW+fkN0NyMJv/MnTvOSgXBQwO1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRj+UC3fLFuHIO5l7Zvi399AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8vC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eV66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBsPkoLVeL+zNbFwg2HwqT+GLErQI+llluhEk6y5Qqb3OiueT11rm9e8opwkc77mZ8 o= X-IronPort-AV: E=Sophos;i="5.92,274,1650945600"; d="scan'208";a="75903211" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LWnHC7+Zrrwe7fhHjNRlG1aLvd6UyVS0ILXJ7NR5YzNdE79+vrAVRIbjBYQ2VGgErHdZu+HTG/q+3cRntRnuLofFBGtphGsoqrNn+oH6By/uIH+MpkHLYhr6tl1UlPRqBz5De8CMtPwwu01stqAV0wF9uUtuMOKl6SugNqaBf9YqormkbdAqrRjj1jfZDNKt7KT/Ydk+BelKtGR+t1NfpKgqFJGMj7hMf0etFPSi9EaOKAhaNrVLHUJgO2a+3U8wymKcl9Bv5baXhBBYlcGNQR69f4ARDmODKe7g+DROxtap5Q5Ey5YKSCxSwB+7nOgRlaIvhPBMjLLF57bPg4igww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mXJLVFrcthD42hxcsZ+JmmHuqPHK0pqLkI928Y/v8uw=; b=FUMwV1BRGzNqa5DWhpbVqH/EL22DkJTyLbciskTBXdYUWnqh7z4cXovhToNQ08PKpORFrBNvEG1L8Pm12hO/tCDYzzL7HIbESVYDeEEv2KzUDaM7iEmGI7iSZz7EjNrh0KR5Pxbynb0NDrLiu515TfnJOcx0fzVT4iPORnEqO6fEEZAh4bbjTwlvepmpskge/HKX85m7UEbqU43Xg0VXaJSXzBObAMayuKrX9fj1LbNmZMX31db0Nv++sG279vI78Jg0yjTQhGUcLfN5y/CyegUTNYO/wWqw/e3qaEmymg1Mw5Xgh+nhva2V/oL7sXAPWydVFonpj8kQflmaMEY2yQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mXJLVFrcthD42hxcsZ+JmmHuqPHK0pqLkI928Y/v8uw=; b=KuOOkQfIJn4obtkHLxXFrGmdPa/RY7kSQk/54nrCyC1K40ZSJzKIJ7bUoDvGqFeqAYhz7VJfV+DtHmQtsPCSCO9avlo8HoXZ3jDIoBEKarP/QisrwSvhP6bDMtorYyeCV7r31zUaEgg2UW2awgpA4JeUQcaQyJX3/yCR627DzpQ= From: Andrew Cooper To: Marc Bonnici , "xen-devel@lists.xenproject.org" Subject: Re: Xen Memory Sharing Query Thread-Topic: Xen Memory Sharing Query Thread-Index: AdiXcIvKzj1u3ooYRvOwLKlCsLdCEAA/89UA Date: Fri, 15 Jul 2022 17:28:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 767b483f-373b-496d-f973-08da66877e2d x-ms-traffictypediagnostic: DM4PR03MB6860:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ql2avDDW3V43CYsjcAOpo1GEVMNr3csHw/TNOir3p8TwjHboUepknbfkTjmEWK03aZMm7D1RepUEVEd4XHt0xECrubzccPzW9pdpWwNcuiK7YLVVg28c2mEYvt1hEt241PuyM/W8DJgC779Jyu5YxH7SLV7o+iO+jh7GxOxsfIz4WkA3bTrXUs64W+hkDYcLqMCIjz3zfGlTtJgPD5B1NmYUIto556zpyJmim/yRgQ9YS/oevsm4zZr3dCgwGFzSsLoWPY/Fm9k/gwXz0QpN6mvO+vLZp/2iME2vPvmGDUDNOJqzmiuWAWtkHPfDkb3hnSidZXCBN9Fs0/N6in/xrGvVQ5NLOxlu5B5uC3l4zB9behlsqyNS48PYuOlWbeJM3BqWQh7cGEuAbyd6TbmF38+MbQM1jmAiuRCwTlFIZJ88+/T741Ddv+lovBvkOg38TxdN7Mg3e8jzoN2pZURRG9LEP6C0domlX+RUGwRlLs287dnFomtZDzim0ek7Rs4kZ/lwt+r3LrUc5hdVTNgi9flG3aMGnwdHBTyfrTrvAHU4OTb12t4fQH99sj2TZJQyEPG60f/pZ+/F7jVV+0DdJtX0kpL4BGFdK8b0XW3Jbxp7JUzQuBFGTXWwKCMW7kenX5Z4UBfOgxgMGSJLf+VWpFq2sbkb2LdV83I+FE3PqN8WBm98Z/uulwmVk7WDqg5UrH68CpeaCBjH14Pd8dB9kjy7j3NuK9fHfnOx7blxIMYL3fKFjBAZGAol6p/nTGy6bA8f4R5gK7Fd/NfYTpqiu7j0jyMS1be013QYurkvp20ZtAzzGO5iWp+z8IAoY4HM5eKpT07qAR3GSsnhAS9VJd/axT2nlAvY1BzTaIcX9zr/3QNUOC7MK/0LE+gYwiyPFULRalkvLURDCvPmLcFqLw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(376002)(39860400002)(346002)(136003)(316002)(86362001)(110136005)(186003)(31696002)(41300700001)(2616005)(26005)(53546011)(6512007)(122000001)(6506007)(6486002)(966005)(71200400001)(478600001)(38070700005)(82960400001)(38100700002)(83380400001)(66946007)(3480700007)(8936002)(64756008)(66446008)(66476007)(5660300002)(66556008)(8676002)(2906002)(36756003)(76116006)(31686004)(91956017)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?d2lZQ0ZZR2RybWNDNlBwZ3pIZlhoaTZEbm5CSjBuL2kwNERPY1RxT01iaTIr?= =?utf-8?B?N2R1aGk3R3FHVHE0emhMTlRJOHR5UmEyWko0NTViMHlhUWMvVWRhaEk5UEZS?= =?utf-8?B?cXNsYTNJTE84MlN3U2xzdUtOVDVQSUl0NjkwbzNiWGkwUWFnSTJPQ2pMM1BO?= =?utf-8?B?UjhHNXlNUjJGT0pIR1plSmtWWFBtOTdjTWZwaytyRWdhbFNEeTY4Sjc0YW5l?= =?utf-8?B?OE93a0V2NUowNVVuT1JpcWk2ZXo2MThCRzVKTUQxSzc0b200aTAwV3d0U3dt?= =?utf-8?B?ZXlwOFcrU2hxZE1xUjFsZnVJdWlwbWRDclVtclhKRVBZSDhoUXhkU283Wkls?= =?utf-8?B?MnFaQ3EvR1hrVjJCc0l1a3VnVldtVFJYRVVhSU1LMjdwOHBBK0c5Q1dNNFBl?= =?utf-8?B?QStJeDhKT01TcXVSdmJKMUxKVHRCeVMwYnNsa3p2UUlWVzRqY1M4QUR6NlJ2?= =?utf-8?B?bEh3cHIvWVF0VUdJMlBINGsvcE5YWjAvencxTStKUW9RN3RwVjk3c0R6MVhG?= =?utf-8?B?NUY5UWU3OFh3MHRxandkYVo4cE9VS1NQK0FMNEhmdUVESHkrZFkyMnJWVXl2?= =?utf-8?B?UWRrSEVlQmYyR0pySktFdHBNeWZVZDlGbS9XMUV2UGZqOTN0RHJrL2Q3WVFI?= =?utf-8?B?M0p3U1JuMXJwL1Z6ZWtPT3ROREdzeVFqdXBlVng4bVJoZEV5UnpXZG0vZ3pN?= =?utf-8?B?cURlM3VIR1ppSmZZMERzVTJrU3lRNVdDV3hIMDN4VWFMd1RwWVMrUnpraUNh?= =?utf-8?B?Y254NGNnZzFqYkZlK3ZHaHdPdmMyRnk0L0d2SHRuZFY3VG5KR3ZwYkV0MllV?= =?utf-8?B?YlVUOTd2VnE1OFJCRE1vY3B3LzJ3WDZ5OWo0N1g4TktreThQT2d4SWN4TzVU?= =?utf-8?B?TW53OWZVVDlldGQ0cmxvaFhxMVJBR2NpL01MZ2xnbTJDdnVobS9MS1hObnlL?= =?utf-8?B?dFowdWhGU05sMi92Mkc2ZDdRYXdQT1NzUjVWK0lnSDNKRUZadnFock1UYi8r?= =?utf-8?B?dzAyYVllZEpJWlNnbnJRQzhtbitseXlIK1Y3WG1XWGRrVU8va2VlemtHOG4z?= =?utf-8?B?dEs2TFBhY1BPTGlFdklYT0hNQnZBK1crNExMeVlsR3VtRHpoVHp2aW1QRmlG?= =?utf-8?B?WlVNR0RtOGEvZkJtM1NmdzREOVhEVit4K1I0Qi95Q1NwbnFVa2ljMXV6dXJa?= =?utf-8?B?RW4yTmIxdFZSNHhIa055THR0RVhwSDJvaXB5czRWczJGQTNjWDVGc09lMFlR?= =?utf-8?B?RS9iNlNOcjRFeWk4OEZrMDdCMDdyOEpNUHhoV2JGdUhNcW5abDYzbGtxNDBR?= =?utf-8?B?S1g4YTJsY3VYVk5yTUFDWWZSeEMzclQvcDNzekREZkc0MkVUTkhsYUh4cnM1?= =?utf-8?B?UitSb3VYNWZEQmc0dXFNMGdWSURndjM5Q1JndTNVdkpHM3JlRWJMOU1MT3BS?= =?utf-8?B?SC9nV1dlSUJKbFJJNWFzQ1pIN0k1QlRpYWIrbGN5eHloKy9hVUUyeVNXVFNm?= =?utf-8?B?ZlFCQWpjRER0djlMTWdrVWRKYnMyMmFkYjVIbkp5UUllZmNLWUozVFdFMzR0?= =?utf-8?B?Z2FSS3VSUlBRQ2NsdUgwQ2pITFB3cDhTeVY2MFZVYzRNd3hCZ1p5R0FqYTRx?= =?utf-8?B?d2tTSlhHTTAxQ0tycHhqcG5XdG8zSEMvK09FR00wc3BWOE50ejgrcUxqcVJD?= =?utf-8?B?S3RtbjlTckhUODdpVnFEY3Fudy9abjZabnY0cWtxVmtpTFNyN2hjMjA4emR2?= =?utf-8?B?cnpQMW95aVRDZ09WRmlwNG9ZOGRndFdjMHhoR3lFVTBrVDQrbDcxMnJyb1Z5?= =?utf-8?B?VjNEazBVSGQ5Qy9hWjhkbmV6SHcyb2NsY01xSit1Wk1HTVRZcTRBUS9UYlBE?= =?utf-8?B?UFBnSEpXNFBFaHM5dkJueUlYMkxnUXQxOXM0TzZybzBjVEgvM3ExZmJGZTEv?= =?utf-8?B?MlE3T1NmWDV5VEg3K3I5enBCVXlEKzcvWkxrbUNmbGN4T0xRQ2ZZdnJGRFlt?= =?utf-8?B?ZDd3Zm4vUG5McFZhOFRhVHBWWDFtNVFaUkdja1JMSFBCR1JVbUwxN3Urd2ZH?= =?utf-8?B?L3VuNE1Mekk2bnlVSk5RT2RuVFBIZlo3S29HaWhIa1Y4RDFlWDNvV0RIUjlR?= =?utf-8?Q?cZykcoFxUm7uac0hsEdAo1AKo?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 767b483f-373b-496d-f973-08da66877e2d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jul 2022 17:28:54.9281 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aofIj2WaChNihqQImngt6h+gKSvcBebge0E6qMOD0f5sumeKcSyVLe61QB96oWHbtgSowSJGbWE7Ov+U27QlnIAAK3zrnCZ1pSJQgGTbEZI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR03MB6860 T24gMTUvMDcvMjAyMiAxNjo1NiwgTWFyYyBCb25uaWNpIHdyb3RlOg0KPiBIaSBBbGwsDQo+DQo+ IEkgd2FzIHdvbmRlcmluZyBpZiBzb21lb25lIGNvdWxkIGhlbHAgbWUgdW5kZXJzdGFuZCBzb21l IG9mIHRoZSBydWxlcyBvZiB0aGUgDQo+IG1lbW9yeSBzaGFyaW5nIGltcGxlbWVudGF0aW9uIGlu IFhlbj8NCj4NCj4gU3BlY2lmaWNhbGx5IEknbSBsb29raW5nIHRvIHVuZGVyc3RhbmQgd2hhdCBy ZXN0cmljdGlvbnMgWGVuIHBsYWNlcyBvbg0KPiBncmFudGluZyBhY2Nlc3MgZnJvbSBvbmUgRG9t IHRvIGFub3RoZXIgZnJvbSBYZW4ncyBwZXJzcGVjdGl2ZSwgYW5kIHdoYXQgdHlwZXMgDQo+IG9m IGdyYW50IHJlcXVlc3RzIHdvdWxkIGJlIGFsbG93ZWQvcmVqZWN0ZWQgYnkgWGVuPw0KPg0KPiBJ LmUuIEhvdyB3b3VsZCB0aGUgc2l0dWF0aW9uIGJlIGhhbmRsZWQgaWYgdGhlIHNhbWUgZnJhbWUg b2YgbWVtb3J5IHdhcyBhdHRlbXB0ZWQgDQo+IHRvIGJlIHNoYXJlZCBtdWx0aXBsZSB0aW1lcz8N Cj4NCj4gQXMgYW4gZXhhbXBsZSBzY2VuYXJpbywgRG9tQSBzaGFyZXMgMSBwaHlzaWNhbCBwYWdl IG9mIG1lbW9yeSBpbiBhIHRyYW5zYWN0aW9uIA0KPiB3aXRoIERvbUIuIEFuZCB0aGVuIHdpdGhv dXQgcmVsZWFzaW5nIGFueSBtZW1vcnksIERvbUEgYXR0ZW1wdHMgdG8gc2hhcmUNCj4gYW5vdGhl ciByZWdpb24gb2YgbWVtb3J5LCB3aGljaCBpbmNsdWRlcyB0aGUgc2FtZSBwaHlzaWNhbCBwYWdl IG9mIHRoZSBwcmV2aW91cyBzaGFyZQ0KPiB3aXRoIERvbUIgYWdhaW4uIFRoaXMgd291bGQgcmVz dWx0IGluIHR3byBjb25jdXJyZW50IHNoYXJlcyBjb250YWluaW5nIGFuIG92ZXJsYXAuDQo+DQo+ IEFwb2xvZ2llcyBpZiBJJ3ZlIG1pc3NlZCBzb21ldGhpbmcgYnV0IGlzIHRoZXJlIGFueSBkb2N1 bWVudGF0aW9uIC8gdGhyZWF0IG1vZGVsDQo+IHRoYXQgd291bGQgY292ZXIgdGhlc2UgdHlwZXMg b2Ygc2NlbmFyaW9zPyBTbyBmYXIgSSBoYXZlIGJlZW4gdHJ5aW5nIHRvIHJlYWQgdGhyb3VnaCAN Cj4gdGhlIGNvZGUgYnV0IHdhcyB3b25kZXJpbmcgaWYgdGhlcmUgaXMgc29tZXRoaW5nIGVsc2Ug SSBjb3VsZCByZWZlciB0byBoZWxwIG1lIA0KPiB3aXRoIG15IHVuZGVyc3RhbmRpbmc/DQoNClRo ZXJlJ3Mgbm90aGluZyBhZGVxdWF0ZWx5IHdyaXR0ZW4gZG93bi7CoCBJdCBvdWdodCB0byBsaXZl IGluIHNwaGlueA0KZG9jcywgYnV0IG15IGNvcGlvdXMgZnJlZSB0aW1lIGlzIG5vbi1leGlzdGVu dCBmb3Igc3BlY3VsYXRpdmUgc2VjdXJpdHkNCnJlYXNvbnMuDQoNClRoaXMgYWxsIHBlcnRhaW5z IHRvIGdudHRhYiB2MSB3aGljaCBpcyB0aGUgb25seSBzdXBwb3J0ZWQgb25lIG9uIEFSTQ0Kcmln aHQgbm93LsKgIGdudHRhYiB2MiBpcyBob3JyaWJseSBtb3JlIGNvbXBsaWNhdGVkLsKgIFJlZmVy IHRvDQpodHRwczovL2dpdGh1Yi5jb20veGVuLXByb2plY3QveGVuL2Jsb2IvbWFzdGVyL3hlbi9p bmNsdWRlL3B1YmxpYy9ncmFudF90YWJsZS5oI0wxMzItTDE4Ng0KDQpXaGVuIERvbUEgYW5kIERv bUIgYXJlIHNldCB1cCBhbmQgcnVubmluZywgdGhleSBlYWNoIGhhdmUgYSBncmFudA0KdGFibGUu wqAgVGhlIGdyYW50IHRhYmxlIGlzIHNvbWUgc2hhcmVkIG1lbW9yeSAob2YgWGVuJ3MpIG1hcHBl ZCBpbnRvIHRoZQ0KZ3Vlc3QsIGFuZCBpcyBhIGJpZGlyZWN0aW9uYWwgY29tbXVuaWNhdGlvbiBp bnRlcmZhY2UgYmV0d2VlbiB0aGUgZ3Vlc3QNCmtlcm5lbCBhbmQgWGVuLg0KDQpUaGUgZ3Vlc3Qg a2VybmVsIGxvZ2ljYWxseSBvd25zIHRoZSBncmFudCB0YWJsZSwgYW5kIGl0J3MgYSBzaW1wbGUg YXJyYXkNCm9mIGdyYW50IGVudHJpZXMuwqAgRW50cmllcyAwIHRocnUgNyBhcmUgcmVzZXJ2ZWQg Zm9yIHN5c3RlbSB1c2UsIGFuZA0KaW5kZWVkIHR3byBlbnRyaWVzIChvbmUgZm9yIHhlbnN0b3Jl LCBvbmUgZm9yIHhlbmNvbnNvbGUpIGFyZSBzZXQgdXAgb24NCnRoZSBndWVzdCBrZXJuZWwncyBi ZWhhbGYgYnkgdGhlIGRvbWFpbiBidWlsZGVyLsKgIEVudHJpZXMgOCB0aHJ1ICROIGFyZQ0KZW50 aXJlbHkgdW5kZXIgdGhlIGd1ZXN0J3MgY29udHJvbC4NCg0KQSBndWVzdCBrZXJuZWwgKGRvbUEp IGNyZWF0ZXMgYSBncmFudCBieSBmaWxsaW5nIGluIGEgZ3JhbnQgdGFibGUgZW50cnksDQphbmQg cGFzc2luZyB0aGUgZ3JhbnQgcmVmZXJlbmNlICh0aGUgZW50cnkncyBpbmRleCBpbiB0aGUgdGFi bGUpIHRvIHNvbWUNCm90aGVyIGVudGl0eSBpbiB0aGUgc3lzdGVtIChpbiB0aGlzIGNhc2UsIGRv bUIpLg0KDQpUaGUgZ3JhbnQgdGFibGUgZW50cnkgaXMgZm9ybWVkIG9mOg0KDQp1MTYgZmxhZ3MN CnUxNiBkb21pZA0KdTMyIGZyYW1lDQoNCnNvIGZvciBkb21BIHRvIGdyYW50IGEgZnJhbWUgdG8g ZG9tQiwgaXQgd291bGQgcGljayBhIGZyZWUgZ3JlZiAoYW55DQplbnRyeSBpbiB0aGUgdGFibGUg d2l0aCBmbGFncz0wKSBhbmQgZmlsbCBpbjoNCg0KZnJhbWUgPSBmDQpkb21pZCA9IGRvbUINCnNt cF93bWIoKQ0KZmxhZ3MgPSBHVEZfcGVybWl0X2FjY2VzcyAodGhpbmsgImdyYW50IHVzYWJsZSIp DQoNCkdGVF9yZWFkb25seSBpcyBhbm90aGVyIHJlbGV2YW50IGZsYWcgdGhhdCBkb21BIG1pZ2h0 IGNob29zZSB0byBzZXQuDQoNClRoZW4sIGRvbUIgd291bGQgdGFrZSB0aGUgZ3JlZiBpdCBoYXMg YmVlbiBnaXZlbiBieSBkb21BLCBhbmQgbWFrZSBhDQpnbnR0YWJfb3BfbWFwKCkgaHlwZXJjYWxs LCBwYXNzaW5nIHtkb21BLCBncmVmfSBhcyBhbiBpbnB1dC4NCg0KWGVuIGxvb2tzIHVwIGdyZWYg aW4gZG9tQSdzIGdyYW50IHRhYmxlLCBjaGVja3MgZS5nLiBkb21BIGdyYW50ZWQgYWNjZXNzDQp0 byBkb21CLCBhbmQgaWYgZXZlcnl0aGluZyBpcyBoYXBweSwgc2V0cyB0aGUgdGhlIEdGVF97cmVh ZGluZyx3cml0aW5nfQ0KZmxhZ3MgKGFzIGFwcHJvcHJpYXRlKSBpbiBmbGFncy7CoCBUaGlzIHRl bGxzIGRvbUEgdGhhdCB0aGUgZ3JhbnQgaXMNCmN1cnJlbnRseSBtYXBwZWQgcmVhZGFibHkgYW5k L29yIHdyaXRlYWJseS4NCg0KTGF0ZXIsIHdoZW4gZG9tQiB1bm1hcHMgdGhlIGdyYW50LCBYZW4g Y2xlYXJzIHRoZSBHRlRfe3JlYWRpbmcsd3JpdGluZ30NCmJpdHMsIHRlbGxpbmcgZG9tQSB0aGF0 IHRoZSBncmFudCBpcyBubyBsb25nZXIgaW4gdXNlLg0KDQpEb21BIHRoZW4gY2xlYXJzIEdURl9w ZXJtaXRfYWNjZXNzIHRvIG1hcmsgdGhpcyBhcyBncmVmIGFzIGludmFsaWQsIGFuZA0KY2FuIHRo ZW4gZnJlZSB0aGUgZnJhbWUuDQoNCg0KTm93LCB0aGF0J3MgdGhlIHNpbXBsZSBvdmVydmlldy7C oCBUbyBhbnN3ZXIgc29tZSBvZiB5b3VyIHNwZWNpZmljIHF1ZXN0aW9uczoNCg0KRG9tQSBpcyBw ZXJmZWN0bHkgZnJlZSB0byBncmFudCBhd2F5IHRoZSBzYW1lIGZyYW1lIG11bHRpcGxlIHRpbWVz LsKgDQpEb21BIGRvZXMgdGhpcyBieSB3cml0aW5nIG11bHRpcGxlIGRpZmZlcmVudCBncmVmcyB3 aXRoIHRoZSBzYW1lIGZyYW1lDQpmaWVsZC7CoCBUaGVzZSBncmVmcyBjb3VsZCBiZSB0byB0aGUg c2FtZSwgb3IgZGlmZmVyZW50IGRvbWFpbnMsIGFuZCBjYW4NCmhhdmUgYW55ICh2YWxpZCkgY29t YmluYXRpb24gb2YgZmxhZ3MuDQoNCkRvbUIgaXMgcGVyZmVjdGx5IGZyZWUgdG8gbWFwIHRoZSBz YW1lIGdyZWYgbXVsdGlwbGUgdGltZXMuwqAgVGhpcyBpcw0KYWN0dWFsbHkgYSBuZWNlc3NpdHkg Zm9yIHg4NiBQViBndWVzdHMsIGJlY2F1c2Ugb2YgaG93IHdlIHJlZmVyZW5jZQ0KY291bnQgcGFn ZXRhYmxlIGVudHJpZXMuwqAgSXQgaXMgbm90IG5lY2Vzc2FyeSBmb3IgYW55IGtpbmQgb2YgZ3Vl c3Qgb2YNCkhWTSBndWVzdCAoeDg2IG9yIEFSTSkgYmVjYXVzZSBvZiBob3cgZ3Vlc3QgcGh5c2lj YWwgYWRkcmVzcyBzcGFjZSB3b3Jrcy4NCg0KSU1PIGl0IHNob3VsZCBoYXZlIGJlZW4gcmVzdHJp Y3RlZCB3aGVuIHRoZSBIVk0gQUJJIHdhcyBkZXNpZ25lZCwgYnV0DQphbGFzLsKgIEluIHByYWN0 aWNlLCBYZW4gaGFzIGFuIGludGVybmFsIHJlZmNvdW50IHdoaWNoIHByZXZlbnRzIGEgZ3JlZg0K YmVpbmcgbWFwcGVkIG1vcmUgdGhhbiAxMjcgdGltZXMgSUlSQy4NCg0KV2hpbGUgYSBncmVmIGlz IG1hcHBlZCwgZG9tQSBpcyBub3QgcGVybWl0dGVkIHRvIGVkaXQgdGhlIGFzc29jaWF0ZWQNCmVu dHJ5LsKgIERvaW5nIHNvIHNob3VsZG4ndCBjYXVzZSBhIHNlY3VyaXR5IHZpb2xhdGlvbiAoWGVu IGhhcyBhIGxvY2FsDQpjb3B5IG9mIHRoZSBlbnRyeSBpbiB0aGUgbWFwdHJhY2sgdGFibGUpLCBi dXQgd2lsbCBhdCBsZWFzdCBjb25mdXNlDQpkaWFnbm9zdGljcyBvZiB0aGUgZ3JhbnRlZCBzdGF0 ZS4NCg0KSW1wb3J0YW50bHksIGFuZCB3aGF0IG1heSBjb21lIGFzIGEgc3VycHJpc2UsIGlzIHRo YXQgZG9tQSBoYXMgbm8gd2F5IHRvDQpyZXZva2UgYSBjdXJyZW50bHktbWFwcGVkIGdyYW50LsKg IEZpeGluZyB0aGlzIGxpbWl0YXRpb24gaGFzIGJlZW4NCmRpc2N1c3NlZCBzZXZlcmFsIHRpbWVz OyB0aGVyZSBhcmUgc29tZSB2ZXJ5IGNvbXBsaWNhdGVkIGNvcm5lciBjYXNlcywNCmFuZCBJJ20g bm90IGF3YXJlIG9mIGFueSB3b3JrIGhhdmluZyBzdGFydGVkIGluIGVhcm5lc3QuDQoNClhlbiBk b2VzIGhhdmUgbG9naWMgdG8gdW5tYXAgZ3JhbnRzIG9mIFZNcyB3aGljaCBoYXZlIHNodXQgZG93 biAoZm9yDQp3aGF0ZXZlciByZWFzb24pIHdpdGggZ3JhbnRzIHN0aWxsIG1hcHBlZC7CoCBUaGlz IHByZXZlbnRzIGRlYWRsb2Nrcw0KKGUuZy4gdHdvIGRvbWFpbnMgZ3JhbnQgdG8gZWFjaCBvdGhl ciwgdGhlbiBib3RoIGNyYXNoIGRlbGliZXJhdGVseSkuDQoNCg0KRnJvbSBhIGdyYW50IHBlcnNw ZWN0aXZlLCBYZW4gZG9lc24ndCBlbmZvcmNlIGFueSBwb2xpY3kuwqAgZG9tQSdzIGdyZWZzDQpj YW4gYmUgbWFwcGVkIGluIHRoZSBtYW5uZXIgcGVybWl0dGVkIGJ5IHdoYXQgZG9tQSB3cm90ZSBp bnRvIHRoZSBncmFudA0KdGFibGUuDQoNCklmIHlvdSB3YW50IHRvIGdldCBpbnRvIHBvbGljaWVz IHRoYXQgWGVuIG1heSBlbmZvcmNlLCB0aGF0IHdvdWxkIGJlIGENCmRpc2N1c3Npb24gYWJvdXQg WFNNLCBYZW4gU2VjdXJpdHkgTW9kdWxlcy4NCg0KRG9lcyBhbnkgb2YgdGhpcyBoZWxwPw0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:45:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:45:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368420.599683 (Exim 4.92) (envelope-from ) id 1oCPNk-0004Lz-9c; Fri, 15 Jul 2022 17:45:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368420.599683; Fri, 15 Jul 2022 17:45:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPNk-0004Ls-6J; Fri, 15 Jul 2022 17:45:40 +0000 Received: by outflank-mailman (input) for mailman id 368420; Fri, 15 Jul 2022 17:45:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPNj-0004Lm-6e for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:45:39 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ee45ac34-0465-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 19:45:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0063C622D3; Fri, 15 Jul 2022 17:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6184AC36AEF; Fri, 15 Jul 2022 17:45:34 +0000 (UTC) Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4809BE4522F; Fri, 15 Jul 2022 17:45:34 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ee45ac34-0465-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657907134; bh=upDQS3vqXsVzxg+tNckdGACur/G8xxuSK67U6Jd7Iq0=; h=Subject:From:In-Reply-To:References:Date:To:Cc:From; b=O1ap3U8X5XGojDmbf0JSsjtmMNbjIYIOdG6tjkoOH0/emJC9ieL5VciXlS3DZF9F8 zRlybQGtcDBoy5xq73HsGYa0z5n/K7+nA/JN0rFru73YH4VgKt3NcPjW8+jDVQP/zo yLz82cz9CjeOsnfSll4WOIN4/hTq9Cbf50cUvx6nMyrNpcbuj4XtgOd5ws3GOqglU3 Hl2PCrii/F2v61/esS4Vx2kwgXszn9z2N1yrPX6eeJOd6H4VCWbXdn4lDRpbM5NCY0 H+dIpgO/0SJBK2fX2sOeikwzJ3GyeriRmD8CWc8FhaCKkpE/Ik/cUhiig5PeUY+j6X WlVPl87GPo1fA== Subject: Re: [GIT PULL] xen: branch for v5.19-rc7 From: pr-tracker-bot@kernel.org In-Reply-To: <20220715060019.5197-1-jgross@suse.com> References: <20220715060019.5197-1-jgross@suse.com> X-PR-Tracked-List-Id: X-PR-Tracked-Message-Id: <20220715060019.5197-1-jgross@suse.com> X-PR-Tracked-Remote: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19a-rc7-tag X-PR-Tracked-Commit-Id: 166d3863231667c4f64dee72b77d1102cdfad11f X-PR-Merge-Tree: torvalds/linux.git X-PR-Merge-Refname: refs/heads/master X-PR-Merge-Commit-Id: 339f74e38f53c83b5715abd28f7002b66731d917 Message-Id: <165790713429.27298.14101332307075836483.pr-tracker-bot@kernel.org> Date: Fri, 15 Jul 2022 17:45:34 +0000 To: Juergen Gross Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, sstabellini@kernel.org The pull request you sent on Fri, 15 Jul 2022 08:00:19 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-5.19a-rc7-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/339f74e38f53c83b5715abd28f7002b66731d917 Thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/prtracker.html From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:49:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:49:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368426.599695 (Exim 4.92) (envelope-from ) id 1oCPRe-0005J7-Q1; Fri, 15 Jul 2022 17:49:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368426.599695; Fri, 15 Jul 2022 17:49:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPRe-0005J0-N0; Fri, 15 Jul 2022 17:49:42 +0000 Received: by outflank-mailman (input) for mailman id 368426; Fri, 15 Jul 2022 17:49:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPRd-0005Iu-G5 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:49:41 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPRc-00023H-IL; Fri, 15 Jul 2022 17:49:40 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCPRc-0001gp-C7; Fri, 15 Jul 2022 17:49:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=70EnEEQbRDpt+rARZCqKNQZ8qgUjGJbSgZSJjs7h3bY=; b=BZdZOakWsA8sSFkUVN49QT2Wb2 cdCkqvhQsiDyKKmgbxfSgN8XQT/7Ko5A5kd6U+EOCHhLbY+IimnJagmyTnsGcFN5FqZkMKR4npsrb nohafDgIxb7m4auWpf59L470i9oWAnzO8cjk8M2LRDhna+jDFjdCiLwqWsP5YaiNyalY=; Message-ID: Date: Fri, 15 Jul 2022 18:49:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V6 1/2] xen/gnttab: Store frame GFN in struct page_info on Arm To: Oleksandr , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> <632404c3-b285-753d-6644-bccbc17d42c0@xen.org> <834ed066-9e5f-f440-f6b5-78746c0d4163@gmail.com> From: Julien Grall In-Reply-To: <834ed066-9e5f-f440-f6b5-78746c0d4163@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleksandr, On 24/06/2022 12:47, Oleksandr wrote: > > On 23.06.22 20:50, Julien Grall wrote: >> On 11/05/2022 19:47, Oleksandr Tyshchenko wrote: >>> diff --git a/xen/arch/arm/include/asm/mm.h >>> b/xen/arch/arm/include/asm/mm.h >>> +/* >>> + * All accesses to the GFN portion of type_info field should always be >>> + * protected by the P2M lock. In case when it is not feasible to >>> satisfy >>> + * that requirement (risk of deadlock, lock inversion, etc) it is >>> important >>> + * to make sure that all non-protected updates to this field are >>> atomic. >> >> Here you say the non-protected updates should be atomic but... >> >> [...] >> >>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >>> index 7b1f2f4..c94bdaf 100644 >>> --- a/xen/arch/arm/mm.c >>> +++ b/xen/arch/arm/mm.c >>> @@ -1400,8 +1400,10 @@ void share_xen_page_with_guest(struct >>> page_info *page, struct domain *d, >>>       spin_lock(&d->page_alloc_lock); >>>         /* The incremented type count pins as writable or read-only. */ >>> -    page->u.inuse.type_info = >>> -        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1; >>> +    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask); >>> +    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none >>> +                                                  : >>> PGT_writable_page) | >>> +                                MASK_INSR(1, PGT_count_mask); >> >> ... this is not going to be atomic. So I would suggest to add a >> comment explaining why this is fine. > > > Yes, I should have added your explanation given in V5 why this is fine. > > So I propose the following text, do you agree with that being added? > > /* >  * Please note, the update of type_info field here is not atomic as we use >  * Read-Modify-Write operation on it. But currently it is fine because >  * the caller of page_set_xenheap_gfn() (which is another place where >  * type_info is updated) would need to acquire a reference on the page. >  * This is only possible after the count_info is updated *and* there a Missing word: there *is* a. > barrier >  * between the type_info and count_info. So there is no immediate need > to use >  * cmpxchg() here. >  */ > > >> >> >>>         page_set_owner(page, d); >>>       smp_wmb(); /* install valid domain ptr before updating refcnt. */ >>> @@ -1505,7 +1507,23 @@ int xenmem_add_to_physmap_one( >>>       } >>>         /* Map at new location. */ >>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); >> >>> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) >>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); >> >> I would expand the comment above to explain why you need a different >> path for xenheap mapped as RAM. AFAICT, this is because we need to >> call page_set_xenheap_gfn(). > > > agree, I propose the following text, do you agree with that? > > /* >  * Map at new location. Here we need to map xenheap RAM page differently >  * because we need to store the valid GFN and make sure that nothing was >  * mapped before (the stored GFN is invalid). >  */ So I think the key point here is the p2m_set_xenheap_gfn() needs to happen with the P2M lock held. That said, looking at the code again this is a bit confusing to use guest_physmap_add_entry() in one place and p2m_set_entry() in the other. The only way I can think to avoid the confusion is than open-coding guest_physmap_add_entry() (i.e. p2m_write_lock(); p2m_set_entry(); p2m_write_unlock()) or try to merge the two paths. However, I am aware this is already at version 6 and your code should work. So I would be OK with a comment explaining that guest_physmap_add_entry() is just a wrapper on top of p2m_set_entry(). >>> +    else >>> +    { >>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d); >>> + >>> +        p2m_write_lock(p2m); >>> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), >>> INVALID_GFN) ) >> >> Sorry to only notice it now. This check will also change the behavior >> for XENMAPSPACE_shared_info. Now, we are only allowed to map the >> shared info once. >> >> I believe this is fine because AFAICT x86 already prevents it. But >> this is probably something that ought to be explained in the already >> long commit message. So I was wrong thinking that x86 would prevent it (see Jan's answer). However, I think this is a mistake to allow it because it can result to weird issues. In fact, you mentioned on IRC that there is already an example on how this hypercall could be misused in U-boot [1]. At the moment, U-boot will steal a RAM page to map the shared info page but not unmap it. The OS will not be aware where the shared info page is mapped. As this is part of the RAM region, the OS may end up to allocate for other purpose and corrupt the page. If Xen were going to unmap it, then we would create a hole and the OS will crash when accessing the page. In some way, it is better than corruption but still a good user experience (the RAM page may only be accessed a long time after boot). So I think it is much better to return -EBUSY here at least we can catch misuse in the firmware code earlier. In the case of U-boot, as discussed on IRC, the code should: 1) Unmap the page 2) Populate the area with memory using XENMEM_populate_physmap An optimization would be to use the extended regions. But this was only recently introduced so U-boot cannot always rely on it. > > > agree, I propose the following text, do you agree with that? > > Please note, this patch changes the behavior how the shared_info page > (which is xenheap RAM page) is mapped in xenmem_add_to_physmap_one(). > Now, we only allow to map the shared_info at once. The subsequent attempts > to map it will result in -EBUSY, if there is a legitimate use case > we will be able to relax that behavior. I would suggest to summarize what I wrote above in the commit message. I think this is a strong reason to return -EBUSY and push other projects (e.g. U-boot) to fix there code. Cheers, [1] https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/xen/hypervisor.c -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:56:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368433.599705 (Exim 4.92) (envelope-from ) id 1oCPXh-0006pL-Ea; Fri, 15 Jul 2022 17:55:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368433.599705; Fri, 15 Jul 2022 17:55:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXh-0006pE-BW; Fri, 15 Jul 2022 17:55:57 +0000 Received: by outflank-mailman (input) for mailman id 368433; Fri, 15 Jul 2022 17:55:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXf-0006p6-VL for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:55:55 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5eb5aeb0-0467-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 19:55:54 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 21D2D622E8; Fri, 15 Jul 2022 17:55:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 86A0BC34115; Fri, 15 Jul 2022 17:55:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5eb5aeb0-0467-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657907752; bh=3vpFnLXaDApO/bt2hcR2Da04h1fv9AjDwAOX2idNzpY=; h=From:To:Cc:Subject:Date:From; b=Q/ZTXqmNHNmAWAhqO90vFwqEL5aIVTYf+ebtpezt8GgJHQN+wfnpq6cNk4/7kFaX9 ufxmW2Sui2gMueP9cdN3WEXzj6fDf0gjv5bqwHPH+qh11iDvKKcH+72aEa281diUlo xWFSSFsseYO6Pbbb7XKx4WeL5FIiTSUe5CtPTIttcnKrk1ajgtYis34qYUmSFiPfva akRFGTDdtn7ZxgJg8oFbhSi0hv3ZkVcCcLqjYp4QtcmQYrYm8ZLVjb1k+v9Zbh+3U2 LtEeW8KscRSshrNMDjKjANF5k96gJWHR4IpuJwZbTrNXHp+gC9qYY6gAJBF3Vf8jpA wqakYDG7mRLqg== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change Date: Fri, 15 Jul 2022 17:55:19 +0000 Message-Id: <20220715175521.126649-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The first patch of this patchset fixes 'feature_persistent' parameter handling in 'blkback' to respect the frontend's persistent grants support always. The fix makes a behavioral change, so the second patch makes the counterpart of 'blkfront' to consistently follow the behavior change. Changes from v2 (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/) - Keep the behavioral change of v1 - Update blkfront's counterpart to follow the changed behavior - Update documents for the changed behavior Changes from v1 (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/) - Avoid the behavioral change (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/) - Rebase on latest xen/tip/linux-next - Re-work by SeongJae Park - Cc stable@ Maximilian Heyne (1): xen, blkback: fix persistent grants negotiation SeongJae Park (1): xen-blkfront: Apply 'feature_persistent' parameter when connect Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkback/xenbus.c | 9 +++------ drivers/block/xen-blkfront.c | 4 +--- 4 files changed, 6 insertions(+), 11 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:56:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368434.599717 (Exim 4.92) (envelope-from ) id 1oCPXi-00074q-Ne; Fri, 15 Jul 2022 17:55:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368434.599717; Fri, 15 Jul 2022 17:55:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXi-00074j-JR; Fri, 15 Jul 2022 17:55:58 +0000 Received: by outflank-mailman (input) for mailman id 368434; Fri, 15 Jul 2022 17:55:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXi-0006sk-2C for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:55:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 600a1b96-0467-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 19:55:56 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6C364622BC; Fri, 15 Jul 2022 17:55:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E73DBC341C6; Fri, 15 Jul 2022 17:55:53 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 600a1b96-0467-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657907754; bh=glq1x5HjisMX5ci0YsvyB4Ygu//43duXbX0NbnuWshE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hwiOW9YiIbTCMdE0Tf/wDkTu2UsIH14atZA/yHy8G06FnwGKtOvtYIp7JmSM860P4 m+G2KTFISLmBB0n/oEn8K3iH1lIn6aH1fWMLr7ww7PITjexJM6W7ZiuqU1DabSZBq6 ZkcjxYbTGCjxLiP6g/cFeKH/FkCdsABIN2KAKfZMBEOIvPbq2P2UCQEPLEtUiPMz9J bLjFGcCRLmlNFaclKw6IP4+80g51MAYkepMQwlXy4XO8/e3VSueMCLT0xHfCpQw5WP 8V1Pa5gDFUAvwHJgrms8TjifJPJ4u8v1dljABKadLQRH9bMyMnHIve039sDnxUTegP cIcw+eyH/Bk9A== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH 2/2] xen-blkfront: Apply 'feature_persistent' parameter when connect Date: Fri, 15 Jul 2022 17:55:21 +0000 Message-Id: <20220715175521.126649-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715175521.126649-1-sj@kernel.org> References: <20220715175521.126649-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Previous commit made xen-blkback's 'feature_persistent' parameter to make effect for not only newly created backends but also for every reconnected backends. This commit makes xen-blkfront's counterpart parameter to works in same manner and update the document to avoid any confusion due to inconsistent behavior of same-named parameters. Cc: # 5.10.x Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkfront.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkfront b/Documentation/ABI/testing/sysfs-driver-xen-blkfront index 7f646c58832e..4d36c5a10546 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkfront +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkfront @@ -15,5 +15,5 @@ KernelVersion: 5.10 Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note - that this option only takes effect on newly created frontends. + that this option only takes effect on newly connected frontends. The default is Y (enable). diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 3646c0cae672..4e763701b372 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1988,8 +1988,6 @@ static int blkfront_probe(struct xenbus_device *dev, info->vdevice = vdevice; info->connected = BLKIF_STATE_DISCONNECTED; - info->feature_persistent = feature_persistent; - /* Front end dir is a number, which is used as the id. */ info->handle = simple_strtoul(strrchr(dev->nodename, '/')+1, NULL, 0); dev_set_drvdata(&dev->dev, info); @@ -2283,7 +2281,7 @@ static void blkfront_gather_backend_features(struct blkfront_info *info) if (xenbus_read_unsigned(info->xbdev->otherend, "feature-discard", 0)) blkfront_setup_discard(info); - if (info->feature_persistent) + if (feature_persistent) info->feature_persistent = !!xenbus_read_unsigned(info->xbdev->otherend, "feature-persistent", 0); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 17:56:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 17:56:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368435.599728 (Exim 4.92) (envelope-from ) id 1oCPXj-0007Kv-Vh; Fri, 15 Jul 2022 17:55:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368435.599728; Fri, 15 Jul 2022 17:55:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXj-0007Kk-SF; Fri, 15 Jul 2022 17:55:59 +0000 Received: by outflank-mailman (input) for mailman id 368435; Fri, 15 Jul 2022 17:55:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPXi-0006p6-PI for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 17:55:58 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6110c7d3-0467-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 19:55:57 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F2FC5B82DC6; Fri, 15 Jul 2022 17:55:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDD7AC341C0; Fri, 15 Jul 2022 17:55:52 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6110c7d3-0467-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657907753; bh=diKv2YzAoxgEDY60qc5gR9piIzmslAMbkYmuxNqe/ZM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fw1MINtcSM4pJAG0nsuh8IAM8Wr7uRi8M3aS0vjGeLT1EI/GVh6OJWZ+YVlJJwqqx bM31L0AeRA4WLQ9md1tQ0nTXsFrGX8PRpdBlV+Mh/AbOiXhcSxgsfY0uLaQr3XlkIO lm3ZnegDZ8aEwlUzyysoHyiFREQSZgaZAAJNQV3qoDJ76NGHY8DQcY07ZiqqweNjaY G+7nZLFKyemUMbTY0JMT0GhNes72Ig0BZbgNeHry5ztF4VwzS912XIIAoMZ27jI2vJ alwxG/kpfOJENpxe0eeEepmWBoXTsABm/JvzJ7CLVdQ+uyrz56qF7TI3qFXUVgNgn6 4Ru1qOB1bZO1A== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH 1/2] xen, blkback: fix persistent grants negotiation Date: Fri, 15 Jul 2022 17:55:20 +0000 Message-Id: <20220715175521.126649-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715175521.126649-1-sj@kernel.org> References: <20220715175521.126649-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Maximilian Heyne Given dom0 supports persistent grants but the guest does not. Then, when attaching a block device during runtime of the guest, dom0 will enable persistent grants for this newly attached block device: $ xenstore-ls -f | grep 20674 | grep persistent /local/domain/0/backend/vbd/20674/768/feature-persistent = "0" /local/domain/0/backend/vbd/20674/51792/feature-persistent = "1" Here disk 768 was attached during guest creation while 51792 was attached at runtime. If the guest would have advertised the persistent grant feature, there would be a xenstore entry like: /local/domain/20674/device/vbd/51792/feature-persistent = "1" Persistent grants are also used when the guest tries to access the disk which can be seen when enabling log stats: $ echo 1 > /sys/module/xen_blkback/parameters/log_stats $ dmesg xen-blkback: (20674.xvdf-0): oo 0 | rd 0 | wr 0 | f 0 | ds 0 | pg: 1/1056 The "pg: 1/1056" shows that one persistent grant is used. Before commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") vbd->feature_gnt_persistent was set in connect_ring. After the commit it was intended to be initialized in xen_vbd_create and then set according to the guest feature availability in connect_ring. However, with a running guest, connect_ring might be called before xen_vbd_create and vbd->feature_gnt_persistent will be incorrectly initialized. xen_vbd_create will overwrite it with the value of feature_persistent regardless whether the guest actually supports persistent grants. With this commit, vbd->feature_gnt_persistent is set only in connect_ring and this is the only use of the module parameter feature_persistent. This avoids races when the module parameter changes during the block attachment process. Note that vbd->feature_gnt_persistent doesn't need to be initialized in xen_vbd_create. It's next use is in connect which can only be called once connect_ring has initialized the rings. xen_update_blkif_status is checking for this. Please also note that this commit makes a behavioral change of the parameter. That is, the parameter made effect on only newly created backends before this commit, but it makes the effect for every new connection after this commit. Therefore, this commit also updates the document. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximilian Heyne Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- drivers/block/xen-blkback/xenbus.c | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback index 7faf719af165..fac0f429a869 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkback +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback @@ -42,5 +42,5 @@ KernelVersion: 5.10 Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note - that this option only takes effect on newly created backends. + that this option only takes effect on newly connected backends. The default is Y (enable). diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 97de13b14175..874b846fb622 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -520,8 +520,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, if (bdev_max_secure_erase_sectors(bdev)) vbd->discard_secure = true; - vbd->feature_gnt_persistent = feature_persistent; - pr_debug("Successful creation of handle=%04x (dom=%u)\n", handle, blkif->domid); return 0; @@ -1087,10 +1085,9 @@ static int connect_ring(struct backend_info *be) xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol); return -ENOSYS; } - if (blkif->vbd.feature_gnt_persistent) - blkif->vbd.feature_gnt_persistent = - xenbus_read_unsigned(dev->otherend, - "feature-persistent", 0); + + blkif->vbd.feature_gnt_persistent = feature_persistent && + xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); blkif->vbd.overflow_max_grants = 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:10:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:10:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368453.599739 (Exim 4.92) (envelope-from ) id 1oCPlN-0002Ix-8H; Fri, 15 Jul 2022 18:10:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368453.599739; Fri, 15 Jul 2022 18:10:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPlN-0002Iq-4z; Fri, 15 Jul 2022 18:10:05 +0000 Received: by outflank-mailman (input) for mailman id 368453; Fri, 15 Jul 2022 18:10:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPlL-00025E-Rw for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:10:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPlL-0002Un-Ii; Fri, 15 Jul 2022 18:10:03 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCPlL-0002md-Bu; Fri, 15 Jul 2022 18:10:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=0dq+NPThF+RlX1bDPiXVFdfGt6qqMAkPqDf4Cr73lIk=; b=il5ytrRZ3EsxlBO41OJc62gmnJ KXWFyXBFomzzeeeyFQRc4VajTHf6KovzxTjDb/+AigIpFtbass/L5X9CBvkdxCPWCXxcEbo1VSuRB 5s3TmMNenn5ZDKJokLFBnMqTiVYflBcuc7ZxeWWZj94o/PCmGcoNY547EwxS1yspB+2Q=; Message-ID: Date: Fri, 15 Jul 2022 19:10:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 1/8] xen/arm: introduce static shared memory To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-2-Penny.Zheng@arm.com> <45a41132-1520-a894-a9eb-6688c79a660d@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Penny, On 29/06/2022 09:39, Penny Zheng wrote: >>> + for ( i = 0; i < mem->nr_banks; i++ ) >>> + { >>> + /* >>> + * A static shared memory region could be shared between multiple >>> + * domains. >>> + */ >>> + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) >>> + break; > > Maybe I need to add a check on shm-id: > " > /* > * A static shared memory region could be shared between multiple > * domains. > */ > if ( strcmp(shm_id, mem->bank[i].shm_id) == 0 ) > { > if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) > break; > else > { > printk("Warning: xen,shm-id %s does not match for all the nodes using the same region.\n", > shm_id); > return -EINVAL; > } > } > " > Wdyt？ AFAICT, this would allow to region to overlap if they have different shm ID. I am not entirely sure the rest of your code would work properly in this case (what if the owner is different). So I think we need the following checks: 1) The shm ID matches *and* the region exactly match 2) The shm ID doesn't match and the region doesn't overlap with an existing one Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:10:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368460.599750 (Exim 4.92) (envelope-from ) id 1oCPm5-00039V-Mi; Fri, 15 Jul 2022 18:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368460.599750; Fri, 15 Jul 2022 18:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPm5-00039O-Jp; Fri, 15 Jul 2022 18:10:49 +0000 Received: by outflank-mailman (input) for mailman id 368460; Fri, 15 Jul 2022 18:10:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPm3-0002tM-KJ for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:10:47 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 72fa110e-0469-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 20:10:46 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id r9so9068896lfp.10 for ; Fri, 15 Jul 2022 11:10:46 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id 27-20020ac25f5b000000b0047255d210e4sm1020202lfz.19.2022.07.15.11.10.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Jul 2022 11:10:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72fa110e-0469-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=teXKXVfnpcIU6qZcVOyu3M10ANHzL0rBlLTcp7zPbgc=; b=XJTQXedxrhKxUSKN3WA/lLU+NvAYlbqZtBVDUx9kQPos1f8CtGTp6Ui0aCO5hAMXtR F/UG+BP0W10cfMyeh4UeIYxd6BZtwL0Bx86LpXpfD3GNV4PZ1uRNLJxvyzCu6Y2BpC/G wKNJSNuXjp6p30uk3P9SHovldO5LWORpN9Ik9y4SxYvyMaM0zHK4wH/z3Qh2ms0U35qG EiisFNqKWD18US4YyYvwcbHD0CuVDT//eKxMQvligmCD93UUMFWPmuC+34CXsdKE5Mom TesbJfd1HtWWoyd8PcsA/yY3/7Eq9GO6oPpOYzdSUVSPhZE+YjDISusIBjw1uWK6DBEi 7m0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=teXKXVfnpcIU6qZcVOyu3M10ANHzL0rBlLTcp7zPbgc=; b=Zc5Xx0FxvOPOzV0biA695dp6OUkEvy2/VIxRBUlZxmdJtvxR7kigc8fZLQK1Q1PG5K 7B/04byInKpoQqUDHU3meEFVSrqgp81RdemcGwziH9F90iNRmKUk/vZuJGqMT495Oxmr IS5qxZCNs/k9/PDPFHgT83v4ahM/bpocxlpefvcmm/kyXCf2bB1NTVW8OHMxIv58/pME S34FDaIg58Dcj4AmtwEBlMBIFbxkhVuBH2o2JhS9CnW/yo4jRaYDHS+KoaGMFcYusn5e XLIUFy17f+Gi7kuz+xqV+N027NP0VRyBVGycSwA5WcwESorOfTDzgLf6KBfkP7cn46hc rFjg== X-Gm-Message-State: AJIora8fGeWyFD1ZyDIITtjHw6Dlzr6Jvc30Xy+qU73+WH3Ov+rryik1 mROQg8c6UkosKYiVnKKMw48= X-Google-Smtp-Source: AGRyM1sRxrwM7eMr5tysW4dMwYRRYPFJW/KY6eSv1Odzh/eQD02xikaASkfSgD9+fl4QULbKKlZ1KQ== X-Received: by 2002:a19:4f4e:0:b0:48a:11f0:26c7 with SMTP id a14-20020a194f4e000000b0048a11f026c7mr7095935lfk.394.1657908646154; Fri, 15 Jul 2022 11:10:46 -0700 (PDT) Message-ID: <04d4ebbb-8437-0d92-da97-eabf5c6f206b@gmail.com> Date: Fri, 15 Jul 2022 21:10:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V6 1/2] xen/gnttab: Store frame GFN in struct page_info on Arm Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <1652294845-13980-1-git-send-email-olekstysh@gmail.com> <632404c3-b285-753d-6644-bccbc17d42c0@xen.org> <834ed066-9e5f-f440-f6b5-78746c0d4163@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15.07.22 20:49, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 24/06/2022 12:47, Oleksandr wrote: >> >> On 23.06.22 20:50, Julien Grall wrote: >>> On 11/05/2022 19:47, Oleksandr Tyshchenko wrote: >>>> diff --git a/xen/arch/arm/include/asm/mm.h >>>> b/xen/arch/arm/include/asm/mm.h >>>> +/* >>>> + * All accesses to the GFN portion of type_info field should >>>> always be >>>> + * protected by the P2M lock. In case when it is not feasible to >>>> satisfy >>>> + * that requirement (risk of deadlock, lock inversion, etc) it is >>>> important >>>> + * to make sure that all non-protected updates to this field are >>>> atomic. >>> >>> Here you say the non-protected updates should be atomic but... >>> >>> [...] >>> >>>> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >>>> index 7b1f2f4..c94bdaf 100644 >>>> --- a/xen/arch/arm/mm.c >>>> +++ b/xen/arch/arm/mm.c >>>> @@ -1400,8 +1400,10 @@ void share_xen_page_with_guest(struct >>>> page_info *page, struct domain *d, >>>>       spin_lock(&d->page_alloc_lock); >>>>         /* The incremented type count pins as writable or >>>> read-only. */ >>>> -    page->u.inuse.type_info = >>>> -        (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1; >>>> +    page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask); >>>> +    page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none >>>> +                                                  : >>>> PGT_writable_page) | >>>> +                                MASK_INSR(1, PGT_count_mask); >>> >>> ... this is not going to be atomic. So I would suggest to add a >>> comment explaining why this is fine. >> >> >> Yes, I should have added your explanation given in V5 why this is fine. >> >> So I propose the following text, do you agree with that being added? >> >> /* >>   * Please note, the update of type_info field here is not atomic as >> we use >>   * Read-Modify-Write operation on it. But currently it is fine because >>   * the caller of page_set_xenheap_gfn() (which is another place where >>   * type_info is updated) would need to acquire a reference on the page. >>   * This is only possible after the count_info is updated *and* there a > > Missing word: there *is* a. ok > >> barrier >>   * between the type_info and count_info. So there is no immediate >> need to use >>   * cmpxchg() here. >>   */ >> >> >>> >>> >>>>         page_set_owner(page, d); >>>>       smp_wmb(); /* install valid domain ptr before updating >>>> refcnt. */ >>>> @@ -1505,7 +1507,23 @@ int xenmem_add_to_physmap_one( >>>>       } >>>>         /* Map at new location. */ >>>> -    rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); >>> >>>> +    if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) >>>> +        rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); >>> >>> I would expand the comment above to explain why you need a different >>> path for xenheap mapped as RAM. AFAICT, this is because we need to >>> call page_set_xenheap_gfn(). >> >> >> agree, I propose the following text, do you agree with that? >> >> /* >>   * Map at new location. Here we need to map xenheap RAM page >> differently >>   * because we need to store the valid GFN and make sure that nothing >> was >>   * mapped before (the stored GFN is invalid). >>   */ > > So I think the key point here is the p2m_set_xenheap_gfn() needs to > happen with the P2M lock held. > > That said, looking at the code again this is a bit confusing to use > guest_physmap_add_entry() in one place and p2m_set_entry() in the other. > > The only way I can think to avoid the confusion is than open-coding > guest_physmap_add_entry() (i.e. p2m_write_lock(); p2m_set_entry(); > p2m_write_unlock()) or try to merge the two paths. > > However, I am aware this is already at version 6 and your code should > work. So I would be OK with a comment explaining that > guest_physmap_add_entry() is just a wrapper on top of p2m_set_entry(). ok, thanks > >>>> +    else >>>> +    { >>>> +        struct p2m_domain *p2m = p2m_get_hostp2m(d); >>>> + >>>> +        p2m_write_lock(p2m); >>>> +        if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), >>>> INVALID_GFN) ) >>> >>> Sorry to only notice it now. This check will also change the >>> behavior for XENMAPSPACE_shared_info. Now, we are only allowed to >>> map the shared info once. >>> >>> I believe this is fine because AFAICT x86 already prevents it. But >>> this is probably something that ought to be explained in the already >>> long commit message. > > So I was wrong thinking that x86 would prevent it (see Jan's answer). > However, I think this is a mistake to allow it because it can result > to weird issues. > > In fact, you mentioned on IRC that there is already an example on how > this hypercall could be misused in U-boot [1]. At the moment, U-boot > will steal a RAM page to map the shared info page but not unmap it. > > The OS will not be aware where the shared info page is mapped. As this > is part of the RAM region, the OS may end up to allocate for other > purpose and corrupt the page. > > If Xen were going to unmap it, then we would create a hole and the OS > will crash when accessing the page. In some way, it is better than > corruption but still a good user experience (the RAM page may only be > accessed a long time after boot). > > So I think it is much better to return -EBUSY here at least we can > catch misuse in the firmware code earlier. > > In the case of U-boot, as discussed on IRC, the code should: >   1) Unmap the page >   2) Populate the area with memory using XENMEM_populate_physmap > > An optimization would be to use the extended regions. But this was > only recently introduced so U-boot cannot always rely on it. you are right, I have nothing to add > >> >> >> agree, I propose the following text, do you agree with that? >> >> Please note, this patch changes the behavior how the shared_info page >> (which is xenheap RAM page) is mapped in xenmem_add_to_physmap_one(). >> Now, we only allow to map the shared_info at once. The subsequent >> attempts >> to map it will result in -EBUSY, if there is a legitimate use case >> we will be able to relax that behavior. > > I would suggest to summarize what I wrote above in the commit message. > I think this is a strong reason to return -EBUSY and push other > projects (e.g. U-boot) to fix there code. agree, will do > > > Cheers, > > [1] > https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/xen/hypervisor.c > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:12:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:12:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368466.599761 (Exim 4.92) (envelope-from ) id 1oCPnl-0003nY-1u; Fri, 15 Jul 2022 18:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368466.599761; Fri, 15 Jul 2022 18:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPnk-0003nP-VD; Fri, 15 Jul 2022 18:12:32 +0000 Received: by outflank-mailman (input) for mailman id 368466; Fri, 15 Jul 2022 18:12:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCPnk-0003nJ-1f for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:12:32 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b0ac4c94-0469-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 20:12:30 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9D0F62314; Fri, 15 Jul 2022 18:12:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24257C3411E; Fri, 15 Jul 2022 18:12:28 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0ac4c94-0469-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657908749; bh=zv88e6V2bOYszh5xZ5YFkXFxU2Be44JHufVZU7uo7YY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lOXj38MUE4WmuKeKIPlNexwIs7d8j8Mz4uoK2G7zN/dZp+RTkb2v8L75BR+FVb2zH NmLEm83eUNRwIqIcI9wL5Q7Y/K5KaSXYAggo90eNZJreO3MwD6YLDAVtSqrhawd220 FfTrGX7RzR5bYdQfxpxddrFbFuFVbOAP84mKTE5tFRcQ9vpdfUvihzKC280u33p+nf sgh91eVFS1/df/x4i5S5Y3xGZfhkxUDSNLG//qoPSaN62QmkmLK3zEnf05TyCfYrGC o42ruHmQt/OmwMwUVYrktc9irgZcBlYavqVg1mrCYYtvemdz22qgg797b5wCsDY7Xe fosRk69rVR62A== From: SeongJae Park To: SeongJae Park Cc: roger.pau@citrix.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change Date: Fri, 15 Jul 2022 18:12:26 +0000 Message-Id: <20220715181226.126714-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715175521.126649-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, On Fri, 15 Jul 2022 17:55:19 +0000 SeongJae Park wrote: > The first patch of this patchset fixes 'feature_persistent' parameter > handling in 'blkback' to respect the frontend's persistent grants > support always. The fix makes a behavioral change, so the second patch > makes the counterpart of 'blkfront' to consistently follow the behavior > change. I made the behavior change as requested by Andrii[1]. I therefore made similar behavior change to blkfront and Cc-ed stable for the second change, too. To make the change history clear and reduce the stable side overhead, however, it might be better to apply the v2, which don't make behavior change but only fix the issue, Cc stable@ for it, make the behavior change commits for both blkback and blkfront, update the documents, and don't Cc stable@ for the behavior change and documents update commits. One downside of that would be that it will make a behavioral difference in pre-5.19.x and post-5.19.x. I think both downsides are not critical, so posted this patchset in this shape. If anyone prefer some changes, please let me know, though. [1] https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g@mail.gmail.com/ Thanks, SJ > > Changes from v2 > (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/) > - Keep the behavioral change of v1 > - Update blkfront's counterpart to follow the changed behavior > - Update documents for the changed behavior > > Changes from v1 > (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/) > - Avoid the behavioral change > (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/) > - Rebase on latest xen/tip/linux-next > - Re-work by SeongJae Park > - Cc stable@ > > > > Maximilian Heyne (1): > xen, blkback: fix persistent grants negotiation > > SeongJae Park (1): > xen-blkfront: Apply 'feature_persistent' parameter when connect > > Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- > Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- > drivers/block/xen-blkback/xenbus.c | 9 +++------ > drivers/block/xen-blkfront.c | 4 +--- > 4 files changed, 6 insertions(+), 11 deletions(-) > > -- > 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:43:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:43:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368475.599771 (Exim 4.92) (envelope-from ) id 1oCQHz-00086e-CV; Fri, 15 Jul 2022 18:43:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368475.599771; Fri, 15 Jul 2022 18:43:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQHz-00086X-9s; Fri, 15 Jul 2022 18:43:47 +0000 Received: by outflank-mailman (input) for mailman id 368475; Fri, 15 Jul 2022 18:43:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQHx-00086R-VG for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:43:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQHx-00033y-BR; Fri, 15 Jul 2022 18:43:45 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQHx-0004Qr-3E; Fri, 15 Jul 2022 18:43:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PcZm0DHbVphf3FyzZlxWrneC0vuRwz5cMQN3Cx+Xfw8=; b=uAYS80UC7qCsRr+pRweShefKbe Yb43E+RB+YalTuadVkrQwNvz7tnHB2VvNhX1dcQyMG7UiubAL1VfFQ5WK7f1gjIkMz4Z2bh5BKk3B 0Kx30CIwKMq+t8irk2HcweT12aP3M8WwP20MNAfhQPQM5la7yLBHm55SgzQWuE1oo/f8=; Message-ID: Date: Fri, 15 Jul 2022 19:43:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5 2/8] xen/arm: allocate static shared memory to the default owner dom_io To: Penny Zheng , "xen-devel@lists.xenproject.org" Cc: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-3-Penny.Zheng@arm.com> <3b7b32cb-df48-e458-e8a9-f17e86f39c9a@xen.org> <5a49381c-c69d-88dc-1bba-783241dbfe23@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 04/07/2022 08:20, Penny Zheng wrote: >>>>> + >>>>> + return acquire_static_memory_bank(d, NULL, addr_cells, size_cells, >>>>> + pbase, psize); >>>>> + >>>>> +} >>>>> + >>>>> +/* >>>>> + * Func allocate_shared_memory is supposed to be only called >>>> >>>> I am a bit concerned with the word "supposed". Are you implying that >>>> it may be called by someone that is not the owner? If not, then it >>>> should be "should". >>>> >>>> Also NIT: Spell out completely "func". I.e "The function". >>>> >>>>> + * from the owner. >>>> >>>> I read from as "current should be the owner". But I guess this is not >>>> what you mean here. Instead it looks like you mean "d" is the owner. >>>> So I would write "d should be the owner of the shared area". >>>> >>>> It would be good to have a check/ASSERT confirm this (assuming this >>>> is easy to write). >>>> >>> >>> The check is already in the calling path, I guess... >> >> Can you please confirm it? >> > > I mean that allocate_shared_memory is only called under the following condition, and > it confirms it is the right owner. > " > if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || > (!owner_dom_io && strcmp(role_str, "owner") == 0) ) > { > /* Allocate statically shared pages to the owner domain. */ > ret = allocate_shared_memory(owner_dom_io ? dom_io : d, > addr_cells, size_cells, > pbase, psize, gbase); > " I agree that this looks to be the case today. But error can slip easily, so if we can add some ASSERT() in function then you could catch issues during development. Hence why I suggested to add an ASSERT() if possible. > > TBH, apart from that, I don't know how to check if the input d is the right owner, or am I > misunderstanding some your suggestion here? Is page_get_owner() already properly set? If yes, you could ASSERT() the first page of the range belongs to 'd'. This is more an hardening exercise, so it is not critical if it is difficult (or not possible) to have an ASSERT(). > >> [...] >> >>>>> + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); >>>>> + if ( !prop ) >>>>> + { >>>>> + printk("Shared memory node does not provide >>>>> + \"xen,shared- >>>> mem\" property.\n"); >>>>> + return -ENOENT; >>>>> + } >>>>> + cells = (const __be32 *)prop->value; >>>>> + /* xen,shared-mem = ; */ >>>>> + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); >>>>> + ASSERT(IS_ALIGNED(pbase, PAGE_SIZE) && IS_ALIGNED(psize, >>>>> + PAGE_SIZE)); >>>> >>>> See above about what ASSERT()s are for. >>>> >>> >>> Do you think address was suitably checked here, is it enough? >> >> As I wrote before, ASSERT() should not be used to check user inputs. >> They need to happen in both debug and production build. >> >>> If it is enough, I'll modify above ASSERT() to mfn_valid() >> >> It is not clear what ASSERT() you are referring to. >> > > For whether page is aligned, I will add the below check: > " > if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(psize, PAGE_SIZE) || > !IS_ALIGNED(gbase, PAGE_SIZE) ) > { > printk("%pd: physical address %lu, size %lu or guest address %lu is not suitably aligned.\n", AFAICT, the type for the 3 variables is paddr_t. So you want to use 0x%"PRIpaddr" instead of %lu. BTW, in general, for address it is preferable to use hexadecimal over decimal. > d, pbase, psize, gbase); > return -EINVAL; > } > " > For whether the whole address range is valid, I will add the below check: > " > for ( i = 0; i < PFN_DOWN(psize); i++ ) > if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) > { > printk("%pd: invalid physical address %"PRI_paddr" or size %"PRI_paddr"\n", s/PRI_paddr/PRIpaddr/ I am also not sure why you want to print the size here? > d, pbase, psize); > return -EINVAL; > } > " Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:44:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:44:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368481.599783 (Exim 4.92) (envelope-from ) id 1oCQJ3-0000D5-Ma; Fri, 15 Jul 2022 18:44:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368481.599783; Fri, 15 Jul 2022 18:44:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQJ3-0000Cy-Jk; Fri, 15 Jul 2022 18:44:53 +0000 Received: by outflank-mailman (input) for mailman id 368481; Fri, 15 Jul 2022 18:44:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQJ2-0000Cl-7i for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:44:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQJ1-00034q-UG; Fri, 15 Jul 2022 18:44:51 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQJ1-0004eh-Oe; Fri, 15 Jul 2022 18:44:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Af8ynqGLd69VSdZ+W1LoA6Il0jjZC9ZL8koWvQJc4T8=; b=t5ygL2m7b8o1qJuNS+wLmvg4zP gwAQ1uBXlZ7fiaGQQo57DmvCD9JoE+UzZEwTwWMyTLHHJ1CkfKuMD0PgQh7CHu/0/aw8iqUfs9Xvt C1Py2xQIy83V24tle6U9Hq9St0uYQbwipjVNfnl4oj9nmuXE5lLs8U382dPcpvxtJzXI=; Message-ID: Date: Fri, 15 Jul 2022 19:44:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 1/9] xen/arm: rename PGC_reserved to PGC_static To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-2-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220707092244.485936-2-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 07/07/2022 10:22, Penny Zheng wrote: > PGC_reserved could be ambiguous, and we have to tell what the pages are > reserved for, so this commit intends to rename PGC_reserved to > PGC_static, which clearly indicates the page is reserved for static > memory. > > Signed-off-by: Penny Zheng > Acked-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:51:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:51:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368488.599794 (Exim 4.92) (envelope-from ) id 1oCQPJ-00026I-BO; Fri, 15 Jul 2022 18:51:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368488.599794; Fri, 15 Jul 2022 18:51:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQPJ-00026B-8b; Fri, 15 Jul 2022 18:51:21 +0000 Received: by outflank-mailman (input) for mailman id 368488; Fri, 15 Jul 2022 18:51:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQPH-000265-Ue for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:51:19 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQPH-0003DY-R7 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:51:19 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQPH-0004tM-Lc for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:51:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:To:Subject:MIME-Version:Date:Message-ID; bh=tyn1zz5tm3g7Y0vssQxQtttPAqBN/BP25WP5W3PwqUE=; b=KQKSRWQz3D7CEwr+Rr0HwWcd+J hPVHtnXiEswvIqL1SaYVwZbVZyySc+/ttu+y0IFCzcE6seER3E2niqLSvqxszeKiIMxIf9UykH2aQ nZ5XJPKoR+7E3lAdGuF4e1ojmC+VlYW3UiPQwNRje2Ff3iGCcvF9Ak1jwT3X0HKIyaAA=; Message-ID: <411c7978-d98d-cacd-c485-18ba1570514b@xen.org> Date: Fri, 15 Jul 2022 19:51:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 6/9] xen/arm: introduce CDF_staticmem To: xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-7-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220707092244.485936-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 07/07/2022 10:22, Penny Zheng wrote: > In order to have an easy and quick way to find out whether this domain memory > is statically configured, this commit introduces a new flag CDF_staticmem and a > new helper is_domain_using_staticmem() to tell. > > Signed-off-by: Penny Zheng > --- > v8 changes: > - #ifdef-ary around is_domain_using_staticmem() is not needed anymore > --- > v7 changes: > - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore > --- > v6 changes: > - move non-zero is_domain_using_staticmem() from ARM header to common > header > --- > v5 changes: > - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY > - #define is_domain_using_staticmem zero if undefined > --- > v4 changes: > - no changes > --- > v3 changes: > - change name from "is_domain_static()" to "is_domain_using_staticmem" > --- > v2 changes: > - change name from "is_domain_on_static_allocation" to "is_domain_static()" > --- > xen/arch/arm/domain_build.c | 5 ++++- > xen/include/xen/domain.h | 8 ++++++++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > index 3fd1186b53..b76a84e8f5 100644 > --- a/xen/arch/arm/domain_build.c > +++ b/xen/arch/arm/domain_build.c > @@ -3287,9 +3287,12 @@ void __init create_domUs(void) > if ( !dt_device_is_compatible(node, "xen,domain") ) > continue; > > + if ( dt_find_property(node, "xen,static-mem", NULL) ) > + flags |= CDF_staticmem; > + > if ( dt_property_read_bool(node, "direct-map") ) > { > - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) It is not clear to me why dropping IS_ENABLED(...) here is fine. What would happen if a user specify "xen,static-mem" in the device-tree but forgot CONFIG_STATIC_MEMORY in Xen? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:55:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:55:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368496.599805 (Exim 4.92) (envelope-from ) id 1oCQTa-0002oG-VW; Fri, 15 Jul 2022 18:55:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368496.599805; Fri, 15 Jul 2022 18:55:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQTa-0002o9-Sf; Fri, 15 Jul 2022 18:55:46 +0000 Received: by outflank-mailman (input) for mailman id 368496; Fri, 15 Jul 2022 18:55:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQTa-0002o2-4x for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:55:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQTa-0003IU-3n for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:55:46 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQTZ-0005C4-Sj for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:55:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:To:From:Subject:MIME-Version:Date:Message-ID; bh=a11fVIrHQdulZB4boos27lKgQXzDwBhaObnXlJb2dcI=; b=4zPmKaOXo2F9iS9ACUkJjTXpkO QHI/ZeP57KFEvxKhKfnv536rU9CcBY4z9hTKtQmC6RU7730qMTqj015T+XYQV950NA/gmK8y/R43J Dq9Rits8XASFsgCcdGT+cZ0rCANuVWq1XEGaNJaGokMzUdJ5DUxwEMlucrivn58hyDI8=; Message-ID: <5dfb4226-fa26-2ad1-7873-10b30aca3e92@xen.org> Date: Fri, 15 Jul 2022 19:55:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 6/9] xen/arm: introduce CDF_staticmem From: Julien Grall To: xen-devel@lists.xenproject.org References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-7-Penny.Zheng@arm.com> <411c7978-d98d-cacd-c485-18ba1570514b@xen.org> In-Reply-To: <411c7978-d98d-cacd-c485-18ba1570514b@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 15/07/2022 19:51, Julien Grall wrote: > Hi Penny, > > On 07/07/2022 10:22, Penny Zheng wrote: >> In order to have an easy and quick way to find out whether this domain >> memory >> is statically configured, this commit introduces a new flag >> CDF_staticmem and a >> new helper is_domain_using_staticmem() to tell. >> >> Signed-off-by: Penny Zheng >> --- >> v8 changes: >> - #ifdef-ary around is_domain_using_staticmem() is not needed anymore >> --- >> v7 changes: >> - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore >> --- >> v6 changes: >> - move non-zero is_domain_using_staticmem() from ARM header to common >> header >> --- >> v5 changes: >> - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY >> - #define is_domain_using_staticmem zero if undefined >> --- >> v4 changes: >> - no changes >> --- >> v3 changes: >> - change name from "is_domain_static()" to "is_domain_using_staticmem" >> --- >> v2 changes: >> - change name from "is_domain_on_static_allocation" to >> "is_domain_static()" >> --- >>   xen/arch/arm/domain_build.c | 5 ++++- >>   xen/include/xen/domain.h    | 8 ++++++++ >>   2 files changed, 12 insertions(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c >> index 3fd1186b53..b76a84e8f5 100644 >> --- a/xen/arch/arm/domain_build.c >> +++ b/xen/arch/arm/domain_build.c >> @@ -3287,9 +3287,12 @@ void __init create_domUs(void) >>           if ( !dt_device_is_compatible(node, "xen,domain") ) >>               continue; >> +        if ( dt_find_property(node, "xen,static-mem", NULL) ) >> +            flags |= CDF_staticmem; >> + >>           if ( dt_property_read_bool(node, "direct-map") ) >>           { >> -            if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || >> !dt_find_property(node, "xen,static-mem", NULL) ) > > It is not clear to me why dropping IS_ENABLED(...) here is fine. What > would happen if a user specify "xen,static-mem" in the device-tree but > forgot CONFIG_STATIC_MEMORY in Xen? Nvm... flags & CDF_staticmem would be 0 so it would cover that case. Sorry for the noise. Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 18:57:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 18:57:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368502.599816 (Exim 4.92) (envelope-from ) id 1oCQV0-0003jt-90; Fri, 15 Jul 2022 18:57:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368502.599816; Fri, 15 Jul 2022 18:57:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQV0-0003jm-6A; Fri, 15 Jul 2022 18:57:14 +0000 Received: by outflank-mailman (input) for mailman id 368502; Fri, 15 Jul 2022 18:57:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQUz-0003jb-BT for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 18:57:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQUy-0003Jl-Px; Fri, 15 Jul 2022 18:57:12 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQUy-0005D1-Jv; Fri, 15 Jul 2022 18:57:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=PrKpW/zh8/qaVH1P26x2fNdvrrnB46UyjB8jGX2ohCE=; b=JoiN/uh2h1XIpsP/zHGsBKA/VL xXD14OlLxxfwE4+Vts2hiQfrpjXVVSzQfHPYVOTA3gauslB5tguUtg9G6KFH9b+8V1vN1y9iecEP8 ihOUeVydsL+MRiCIutHcvpAW5YbOUxVHgJ3/0EohY0Hq0mjYKLARlFA+qi//mKvQ0jw4=; Message-ID: Date: Fri, 15 Jul 2022 19:57:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v8 8/9] xen: introduce prepare_staticmem_pages To: Penny Zheng , xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-9-Penny.Zheng@arm.com> From: Julien Grall In-Reply-To: <20220707092244.485936-9-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Penny, On 07/07/2022 10:22, Penny Zheng wrote: > Later, we want to use acquire_domstatic_pages() for populating memory > for static domain on runtime, however, there are a lot of pointless work > (checking mfn_valid(), scrubbing the free part, cleaning the cache...) > considering we know the page is valid and belong to the guest. > > This commit splits acquire_staticmem_pages() in two parts, and > introduces prepare_staticmem_pages to bypass all "pointless work". > > Signed-off-by: Penny Zheng > Acked-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:16:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:16:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368510.599827 (Exim 4.92) (envelope-from ) id 1oCQnG-0006VQ-Sz; Fri, 15 Jul 2022 19:16:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368510.599827; Fri, 15 Jul 2022 19:16:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQnG-0006VJ-Pk; Fri, 15 Jul 2022 19:16:06 +0000 Received: by outflank-mailman (input) for mailman id 368510; Fri, 15 Jul 2022 19:16:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQnF-0006VD-1y for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:16:05 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQnD-0003fy-MQ; Fri, 15 Jul 2022 19:16:03 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQnD-0006GB-FT; Fri, 15 Jul 2022 19:16:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=arvjlA3l8K5gzm9a9hMeK1m+Hrcj3nW7D+7T4XKonLQ=; b=yBxscqSgyTAYJLAngz/nLocNEU H+5930LONalzwPnunZk1PaZRcCkBdCFpX307CzztUCYq41KPpnorkVz6DFINCrjgFfDa/nj4KBs6X 9+fT98F2cg18RtjZWHozI+UycfMYPFItiUZrHK9wsP67bf5fHXdIeXNYySoCgC5s6AaE=; Message-ID: Date: Fri, 15 Jul 2022 20:16:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules To: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20220706210454.30096-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Daniel, On 06/07/2022 22:04, Daniel P. Smith wrote: > For x86 the number of allowable multiboot modules varies between the different > entry points, non-efi boot, pvh boot, and efi boot. In the case of both Arm and > x86 this value is fixed to values based on generalized assumptions. With > hyperlaunch for x86 and dom0less on Arm, use of static sizes results in large > allocations compiled into the hypervisor that will go unused by many use cases. > > This commit introduces a Kconfig variable that is set with sane defaults based > on configuration selection. This variable is in turned used as the array size > for the cases where a static allocated array of boot modules is declared. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark I am not entirely sure where this reviewed-by is coming from. Is this from internal review? If yes, my recommendation would be to provide the reviewed-by on the mailing list. Ideally, the review should also be done in the open, but I understand some company wish to do a fully internal review first. At least from a committer perspective, this helps me to know whether the reviewed-by still apply. An example would be if you send a v2, I would not be able to know whether Christoffer still agreed on the change. > --- > xen/arch/Kconfig | 12 ++++++++++++ > xen/arch/arm/include/asm/setup.h | 5 +++-- > xen/arch/x86/efi/efi-boot.h | 2 +- > xen/arch/x86/guest/xen/pvh-boot.c | 2 +- > xen/arch/x86/setup.c | 4 ++-- > 5 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig > index f16eb0df43..24139057be 100644 > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,15 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_BOOTMODS > + int "Maximum number of boot modules that a loader can pass" > + range 1 32768 > + default "8" if X86 > + default "32" if ARM > + help > + Controls the build-time size of various arrays allocated for > + parsing the boot modules passed by a loader when starting Xen. > + > + This is of particular interest when using Xen's hypervisor domain > + capabilities such as dom0less. > diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h > index 2bb01ecfa8..312a3e4209 100644 > --- a/xen/arch/arm/include/asm/setup.h > +++ b/xen/arch/arm/include/asm/setup.h > @@ -10,7 +10,8 @@ > > #define NR_MEM_BANKS 256 > > -#define MAX_MODULES 32 /* Current maximum useful modules */ > +/* Current maximum useful modules */ > +#define MAX_MODULES CONFIG_NR_BOOTMODS > > typedef enum { > BOOTMOD_XEN, > @@ -38,7 +39,7 @@ struct meminfo { > * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. > * The purpose of the domU flag is to avoid getting confused in > * kernel_probe, where we try to guess which is the dom0 kernel and > - * initrd to be compatible with all versions of the multiboot spec. > + * initrd to be compatible with all versions of the multiboot spec. In general, I much prefer if coding style changes are done separately because it helps the review (I don't have to stare at the line to figure out what changed). I am not going to force this here. However, the strict minimum is to mention the change in the commit message. > */ > #define BOOTMOD_MAX_CMDLINE 1024 > struct bootmodule { > diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h > index 6e65b569b0..4e1a799749 100644 > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { > * The array size needs to be one larger than the number of modules we > * support - see __start_xen(). > */ > -static module_t __initdata mb_modules[5]; > +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; Please explain in the commit message why the number of modules was bumped from 5 to 9. > > static void __init edd_put_string(u8 *dst, size_t n, const char *src) > { > diff --git a/xen/arch/x86/guest/xen/pvh-boot.c b/xen/arch/x86/guest/xen/pvh-boot.c > index 498625eae0..834b1ad16b 100644 > --- a/xen/arch/x86/guest/xen/pvh-boot.c > +++ b/xen/arch/x86/guest/xen/pvh-boot.c > @@ -32,7 +32,7 @@ bool __initdata pvh_boot; > uint32_t __initdata pvh_start_info_pa; > > static multiboot_info_t __initdata pvh_mbi; > -static module_t __initdata pvh_mbi_mods[8]; > +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; What's the +1 for? > static const char *__initdata pvh_loader = "PVH Directboot"; > > static void __init convert_pvh_info(multiboot_info_t **mbi, > diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c > index f08b07b8de..2aa1e28c8f 100644 > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1020,9 +1020,9 @@ void __init noreturn __start_xen(unsigned long mbi_p) > panic("dom0 kernel not specified. Check bootloader configuration\n"); > > /* Check that we don't have a silly number of modules. */ > - if ( mbi->mods_count > sizeof(module_map) * 8 ) > + if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) > { > - mbi->mods_count = sizeof(module_map) * 8; > + mbi->mods_count = CONFIG_NR_BOOTMODS; > printk("Excessive multiboot modules - using the first %u only\n", > mbi->mods_count); > } AFAIU, this check is to make sure that we will not overrun module_map in the next line: bitmap_fill(module_map, mbi->mods_count); The current definition of module_map will allow 64 modules. But you are allowing 32768. So I think you either want to keep the check or define module_map as: DECLARE_BITMAP(module_map, CONFIG_NR_BOOTMODS); Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:20:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:20:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368516.599837 (Exim 4.92) (envelope-from ) id 1oCQrb-0008Ev-Ct; Fri, 15 Jul 2022 19:20:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368516.599837; Fri, 15 Jul 2022 19:20:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQrb-0008Eo-AJ; Fri, 15 Jul 2022 19:20:35 +0000 Received: by outflank-mailman (input) for mailman id 368516; Fri, 15 Jul 2022 19:20:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQrZ-0008Ef-EM for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:20:33 +0000 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [2a00:1450:4864:20::136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 31f63b9a-0473-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 21:20:32 +0200 (CEST) Received: by mail-lf1-x136.google.com with SMTP id z25so9388883lfr.2 for ; Fri, 15 Jul 2022 12:20:32 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k3-20020ac257c3000000b0048159b43083sm1043178lfo.201.2022.07.15.12.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 12:20:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31f63b9a-0473-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FaPwFj/RyF+5QWfOP5Acgw2pLkYCh6swXVii47zLS0I=; b=jsTgVWfwyu5bvzziBMqFPerEk1yuqiQUw2NZeXzAVF9atLNfyrov9YLnsdA5RlyhNR fEv2DvKI28I8a57h+vZ6UFZAyqJOM8Pj/FXmEFBMd+ZWIJXj9iEFNbeUha22u/4ybIbX XfyPLDUr8pIOmovYcOPLeCmez/bHaJGm4S6g88fgPrywVO6LWyS22qnIJ/O6ermXin/m LBnxnKJOg90C/7WhCjg1IiyZJWj6T3vXyStFGn0ptIOl2/bH5KgWYKAP5VyxVb3uYjlO lqbqJUBRFCofxieU5+bDclxzMNFi6/4m3f259UC46Uh0KFx712jm7H4QefRPwAnQ2kLU 5cqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=FaPwFj/RyF+5QWfOP5Acgw2pLkYCh6swXVii47zLS0I=; b=tz+otgf/s3yB9eUSEkdawoclO1HbWpFIKeDzF7cfVpSs4eyvNpG8ZeR88rKkN95ozK +qK4TLLEhPhC2kqcPxF8B4DUevsaP6zsdTXCkE6HrpmsrLCq3ruFcEUCmjWU+N1yfvC0 P4EfbZoHClISs0vSFjBC1nbI2Ui72uM11bFrzYfmY60pcCJ6WAQk5QBNQSl2EJU9du3z kMHIrz4aWyf/VtghYXKnyY61C9I0/Q5sFaTgwaBPw+G6eP7dtdihccgpnYcEiD0F6clU j+0VtG9Kc+4OIU5RgA9Si6+pVn2+903w99H/CT19OMrnpgC+JBQSuarrOAdDBmkRcXar wX8w== X-Gm-Message-State: AJIora+AG6xDNWHRf8sfdGSH36+MM6zw6XhF+O2KmAHsxOvhwEPJfTXb uZV66vwp6HytdJLlPMqjH5wRbY739TEatQ== X-Google-Smtp-Source: AGRyM1um1bamUWFLz0Z+t5BdkNIGW/BhIt/p1025yguHrB8xdq0iH/9TrgMm+E9eI+zt8L8hMCYwkg== X-Received: by 2002:a05:6512:1283:b0:489:eed8:5414 with SMTP id u3-20020a056512128300b00489eed85414mr8992198lfs.532.1657912831592; Fri, 15 Jul 2022 12:20:31 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , Jan Beulich , Wei Chen , Kaly Xin , Jiamei Xie , Henry Wang , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH V11 0/3] Virtio support for toolstack on Arm (Was "IOREQ feature (+ virtio-mmio) on Arm") Date: Fri, 15 Jul 2022 22:20:23 +0300 Message-Id: <20220715192026.4013441-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Hello all. The purpose of this patch series is to add missing virtio-mmio bits to Xen toolstack on Arm. The Virtio support for toolstack [1] was postponed as the main target was to upstream IOREQ/DM support on Arm in the first place. Now, we already have IOREQ support in, so we can resume Virtio enabling work. You can find previous discussions at [2]. Patch series [3] is based on recent "staging" branch (bf2f989531ad3851685a1847cbc1e28901ed80a2 public/io: xs_wire: Document that new errors should be added at the end) and tested on Renesas Salvator-X board + H3 ES3.0 SoC (Arm64) with virtio-mmio based virtio-disk backend [4] running in Dom0 (or Driver domain) and unmodified Linux Guest running on existing virtio-blk driver (frontend). No issues were observed. Guest domain 'reboot/destroy' use-cases work properly. !!! All patches except "libxl: Add support for Virtio disk configuration" have Stefano's and Anthony's R-b tags. Anthony already gave his R-b and George already gave his A-b (golang changes) for "libxl: Add support for Virtio disk configuration", but I dropped them due to the changes(s/other/standalone for the backendtype). Any feedback/help would be highly appreciated. [1] https://lore.kernel.org/xen-devel/1610488352-18494-24-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1610488352-18494-25-git-send-email-olekstysh@gmail.com/ [2] https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02403.html https://lists.xenproject.org/archives/html/xen-devel/2021-01/msg02536.html https://lore.kernel.org/xen-devel/1621626361-29076-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1638982784-14390-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1649442065-8332-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1651598763-12162-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1654106261-28044-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1653944813-17970-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1654197833-25362-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1655143522-14356-1-git-send-email-olekstysh@gmail.com/ [3] https://github.com/otyshchenko1/xen/commits/libxl_virtio_next4 [4] https://github.com/otyshchenko1/virtio-disk/commits/virtio_grant Julien Grall (1): libxl: Introduce basic virtio-mmio support on Arm Oleksandr Tyshchenko (2): libxl: Add support for Virtio disk configuration libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device docs/man/xl-disk-configuration.5.pod.in | 38 +- tools/golang/xenlight/helpers.gen.go | 8 + tools/golang/xenlight/types.gen.go | 18 + tools/include/libxl.h | 7 + tools/libs/light/libxl_arm.c | 164 +++- tools/libs/light/libxl_device.c | 62 +- tools/libs/light/libxl_disk.c | 146 +++- tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 18 + tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_utils.c | 2 + tools/libs/util/libxlu_disk_l.c | 959 +++++++++++----------- tools/libs/util/libxlu_disk_l.h | 2 +- tools/libs/util/libxlu_disk_l.l | 9 + tools/xl/xl_block.c | 6 + xen/include/public/arch-arm.h | 7 + xen/include/public/device_tree_defs.h | 3 +- 17 files changed, 969 insertions(+), 483 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:20:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:20:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368517.599849 (Exim 4.92) (envelope-from ) id 1oCQre-0008WG-Kc; Fri, 15 Jul 2022 19:20:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368517.599849; Fri, 15 Jul 2022 19:20:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQre-0008W9-HR; Fri, 15 Jul 2022 19:20:38 +0000 Received: by outflank-mailman (input) for mailman id 368517; Fri, 15 Jul 2022 19:20:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQrc-0008UB-NV for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:20:36 +0000 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [2a00:1450:4864:20::134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 339338d1-0473-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 21:20:35 +0200 (CEST) Received: by mail-lf1-x134.google.com with SMTP id e28so9363797lfj.4 for ; Fri, 15 Jul 2022 12:20:35 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k3-20020ac257c3000000b0048159b43083sm1043178lfo.201.2022.07.15.12.20.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 12:20:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 339338d1-0473-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HfGXLZl0uqtSVoEgYcRpa8oa4JNcYbokEx6kJKQjdBU=; b=nrSjerpWpAZ6vYpdCPMLD7PxMgiW2+6FfAuRVeU8MOzklMCNcpgdgBznhFc6UMAiR1 T3j7o7vn1KFZ4VC43YXCsmOHbLSAlqopGq/Rwz+T+6W1zSWiYw2bFYK0jb06v/xKY1XA RAESJ+S6zsqGJ4m99z9CNz7x42OQWXiOgx3MsbgmE3de/l81z23HH3Rs4FuoJEBsS9p4 8/YXZlds4eb9JH3GUU8aaRLfzJZcfgqhDXdzHezogn9Lt+cq829QDDwndq+WIAMOU1GA 7x3s6oETrb9yS/Vn3jg2Oxg0wg8+U0da1fV8GTMUsXJKED/ZIoKLir9qTcUMpkuk5DbJ NrVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HfGXLZl0uqtSVoEgYcRpa8oa4JNcYbokEx6kJKQjdBU=; b=3hH3tW/eufY31zNjAbHDEeXkhot/RhGHayN945KQikOzXAMr1oFlsItJdr8hBwNwdK d3Tf1p452W+ZHKfTQhJRQbSo0o04wLDoZDz1sLqb9VskY97TCUpnMT5Vn3KfwwMZqAUS cv+OTy0WdyzJegQrjQKMzIf5PQEM5IqtnlFkm2KQ8dKHZLj5XzU3jX+2zB+K2wsbif5j Si6apeCy5eR7YLrHzqbl0VaKbMsqiCYG2KLCBfRDgNYYS7Y2mQSfp5nTKD1Zxys25rOp 4ggyJlJZ5oaW8iJGriiavtdpgPZcwaRuxBPEWk8pQK5yNCZ3OVEu2BNTYLVgzCmgOnnl yfow== X-Gm-Message-State: AJIora9ojS4NFR3UTzPBCW6ErG64vC01cZ8qaYEGwsUE3AZpkKlB5uN+ +0b5sFjc46HfrtLXUGrHnddJ3+LjdxUcnA== X-Google-Smtp-Source: AGRyM1tAMW7m1QV+hVEy3vhmuZ48f7bnHl/vdjviXsVeKp2jp5fm+MrcAe2FK5qoz3sedjWD5PMpQQ== X-Received: by 2002:a19:5f46:0:b0:488:4e69:2da2 with SMTP id a6-20020a195f46000000b004884e692da2mr8970850lfj.130.1657912834488; Fri, 15 Jul 2022 12:20:34 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Julien Grall , Wei Liu , Anthony PERARD , Juergen Gross , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Oleksandr Tyshchenko Subject: [PATCH V11 2/3] libxl: Introduce basic virtio-mmio support on Arm Date: Fri, 15 Jul 2022 22:20:25 +0300 Message-Id: <20220715192026.4013441-3-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715192026.4013441-1-olekstysh@gmail.com> References: <20220715192026.4013441-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Julien Grall This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD --- Please note, this is a split/cleanup/hardening of Julien's PoC: "Add support for Guest IO forwarding to a device emulator" Changes RFC -> V1: - was squashed with: "[RFC PATCH V1 09/12] libxl: Handle virtio-mmio irq in more correct way" "[RFC PATCH V1 11/12] libxl: Insert "dma-coherent" property into virtio-mmio device node" "[RFC PATCH V1 12/12] libxl: Fix duplicate memory node in DT" - move VirtIO MMIO #define-s to xen/include/public/arch-arm.h Changes V1 -> V2: - update the author of a patch Changes V2 -> V3: - no changes Changes V3 -> V4: - no changes Changes V4 -> V5: - split the changes, change the order of the patches - drop an extra "virtio" configuration option - update patch description - use CONTAINER_OF instead of own implementation - reserve ranges for Virtio MMIO params and put them in correct location - create helpers to allocate Virtio MMIO params, add corresponding sanity-сhecks - add comment why MMIO size 0x200 is chosen - update debug print - drop Wei's T-b Changes V5 -> V6: - rebase on current staging Changes V6 -> V7: - rebase on current staging - add T-b and R-b tags - update according to the recent changes to "libxl: Add support for Virtio disk configuration" Changes V7 -> V8: - drop T-b and R-b tags - make virtio_mmio_base/irq global variables to be local in libxl__arch_domain_prepare_config() and initialize them at the beginning of the function, then rework alloc_virtio_mmio_base/irq() to take a pointer to virtio_mmio_base/irq variables as an argument - update according to the recent changes to "libxl: Add support for Virtio disk configuration" Changes V8 -> V9: - Stefano already gave his Reviewed-by, I dropped it due to the changes - remove the second set of parentheses for check in alloc_virtio_mmio_base() - clarify the updating of "nr_spis" right after num_disks loop in libxl__arch_domain_prepare_config() and add a comment on top of it - use GCSPRINTF() instead of using a buffer of a static size calculated by hand in make_virtio_mmio_node() Changes V9 -> V10: - add Stefano's and Anthony's R-b --- tools/libs/light/libxl_arm.c | 121 +++++++++++++++++++++++++++++++++- xen/include/public/arch-arm.h | 7 ++ 2 files changed, 126 insertions(+), 2 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index eef1de0939..9be9b2a2d1 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -8,6 +8,46 @@ #include #include +/* + * There is no clear requirements for the total size of Virtio MMIO region. + * The size of control registers is 0x100 and device-specific configuration + * registers starts at the offset 0x100, however it's size depends on the device + * and the driver. Pick the biggest known size at the moment to cover most + * of the devices (also consider allowing the user to configure the size via + * config file for the one not conforming with the proposed value). + */ +#define VIRTIO_MMIO_DEV_SIZE xen_mk_ullong(0x200) + +static uint64_t alloc_virtio_mmio_base(libxl__gc *gc, uint64_t *virtio_mmio_base) +{ + uint64_t base = *virtio_mmio_base; + + /* Make sure we have enough reserved resources */ + if (base + VIRTIO_MMIO_DEV_SIZE > + GUEST_VIRTIO_MMIO_BASE + GUEST_VIRTIO_MMIO_SIZE) { + LOG(ERROR, "Ran out of reserved range for Virtio MMIO BASE 0x%"PRIx64"\n", + base); + return 0; + } + *virtio_mmio_base += VIRTIO_MMIO_DEV_SIZE; + + return base; +} + +static uint32_t alloc_virtio_mmio_irq(libxl__gc *gc, uint32_t *virtio_mmio_irq) +{ + uint32_t irq = *virtio_mmio_irq; + + /* Make sure we have enough reserved resources */ + if (irq > GUEST_VIRTIO_MMIO_SPI_LAST) { + LOG(ERROR, "Ran out of reserved range for Virtio MMIO IRQ %u\n", irq); + return 0; + } + (*virtio_mmio_irq)++; + + return irq; +} + static const char *gicv_to_string(libxl_gic_version gic_version) { switch (gic_version) { @@ -26,8 +66,10 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, { uint32_t nr_spis = 0; unsigned int i; - uint32_t vuart_irq; - bool vuart_enabled = false; + uint32_t vuart_irq, virtio_irq = 0; + bool vuart_enabled = false, virtio_enabled = false; + uint64_t virtio_mmio_base = GUEST_VIRTIO_MMIO_BASE; + uint32_t virtio_mmio_irq = GUEST_VIRTIO_MMIO_SPI_FIRST; /* * If pl011 vuart is enabled then increment the nr_spis to allow allocation @@ -39,6 +81,35 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, vuart_enabled = true; } + for (i = 0; i < d_config->num_disks; i++) { + libxl_device_disk *disk = &d_config->disks[i]; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + disk->base = alloc_virtio_mmio_base(gc, &virtio_mmio_base); + if (!disk->base) + return ERROR_FAIL; + + disk->irq = alloc_virtio_mmio_irq(gc, &virtio_mmio_irq); + if (!disk->irq) + return ERROR_FAIL; + + if (virtio_irq < disk->irq) + virtio_irq = disk->irq; + virtio_enabled = true; + + LOG(DEBUG, "Allocate Virtio MMIO params for Vdev %s: IRQ %u BASE 0x%"PRIx64, + disk->vdev, disk->irq, disk->base); + } + } + + /* + * Every virtio-mmio device uses one emulated SPI. If Virtio devices are + * present, make sure that we allocate enough SPIs for them. + * The resulting "nr_spis" needs to cover the highest possible SPI. + */ + if (virtio_enabled) + nr_spis = max(nr_spis, virtio_irq - 32 + 1); + for (i = 0; i < d_config->b_info.num_irqs; i++) { uint32_t irq = d_config->b_info.irqs[i]; uint32_t spi; @@ -58,6 +129,13 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, return ERROR_FAIL; } + /* The same check as for vpl011 */ + if (virtio_enabled && + (irq >= GUEST_VIRTIO_MMIO_SPI_FIRST && irq <= virtio_irq)) { + LOG(ERROR, "Physical IRQ %u conflicting with Virtio MMIO IRQ range\n", irq); + return ERROR_FAIL; + } + if (irq < 32) continue; @@ -787,6 +865,37 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, return 0; } + +static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, + uint64_t base, uint32_t irq) +{ + int res; + gic_interrupt intr; + const char *name = GCSPRINTF("virtio@%"PRIx64, base); + + res = fdt_begin_node(fdt, name); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "virtio,mmio"); + if (res) return res; + + res = fdt_property_regs(gc, fdt, GUEST_ROOT_ADDRESS_CELLS, GUEST_ROOT_SIZE_CELLS, + 1, base, VIRTIO_MMIO_DEV_SIZE); + if (res) return res; + + set_interrupt(intr, irq, 0xf, DT_IRQ_TYPE_EDGE_RISING); + res = fdt_property_interrupts(gc, fdt, &intr, 1); + if (res) return res; + + res = fdt_property(fdt, "dma-coherent", NULL, 0); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; +} + static const struct arch_info *get_arch_info(libxl__gc *gc, const struct xc_dom_image *dom) { @@ -988,6 +1097,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; + unsigned int i; const libxl_version_info *vers; const struct arch_info *ainfo; @@ -1094,6 +1204,13 @@ next_resize: if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); + for (i = 0; i < d_config->num_disks; i++) { + libxl_device_disk *disk = &d_config->disks[i]; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + } + if (pfdt) FDT( copy_partial_fdt(gc, fdt, pfdt) ); diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h index ab05fe12b0..c8b6058d3a 100644 --- a/xen/include/public/arch-arm.h +++ b/xen/include/public/arch-arm.h @@ -407,6 +407,10 @@ typedef uint64_t xen_callback_t; /* Physical Address Space */ +/* Virtio MMIO mappings */ +#define GUEST_VIRTIO_MMIO_BASE xen_mk_ullong(0x02000000) +#define GUEST_VIRTIO_MMIO_SIZE xen_mk_ullong(0x00100000) + /* * vGIC mappings: Only one set of mapping is used by the guest. * Therefore they can overlap. @@ -493,6 +497,9 @@ typedef uint64_t xen_callback_t; #define GUEST_VPL011_SPI 32 +#define GUEST_VIRTIO_MMIO_SPI_FIRST 33 +#define GUEST_VIRTIO_MMIO_SPI_LAST 43 + /* PSCI functions */ #define PSCI_cpu_suspend 0 #define PSCI_cpu_off 1 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:20:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:20:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368518.599855 (Exim 4.92) (envelope-from ) id 1oCQrf-0000BL-2v; Fri, 15 Jul 2022 19:20:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368518.599855; Fri, 15 Jul 2022 19:20:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQre-00008r-TU; Fri, 15 Jul 2022 19:20:38 +0000 Received: by outflank-mailman (input) for mailman id 368518; Fri, 15 Jul 2022 19:20:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQrd-0008UB-Kj for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:20:37 +0000 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [2a00:1450:4864:20::231]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3476136e-0473-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 21:20:36 +0200 (CEST) Received: by mail-lj1-x231.google.com with SMTP id m9so4064781ljp.9 for ; Fri, 15 Jul 2022 12:20:36 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k3-20020ac257c3000000b0048159b43083sm1043178lfo.201.2022.07.15.12.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 12:20:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3476136e-0473-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=elrHr5L0SkxQ3LO81KmQhscJxktKNPP4wxTaLG26eSY=; b=X0EcvT6E+XdoN9C113NAQwTHE+VY9yWTB2n9g1wcvztNrB6fkeFhpZqZfau8gBWjv2 mFzP1CJHjMA/xPepyyKCtP577kawYa4I8IlNUqLc/1AmYpI+wNmmO2VGR/Ff2uvp5nd9 mPe5xNzCNB6TPUBLHdbwSwTpWWgyqXmSUlMjX+uuEWZeD2QUUkZ53RgULOICNYFMucgo iN9ShgYV6H5JlgHpBCKdEBwdnDWtaDGCmgAqMEaFbcmRPv5fM/ghfzOzSX3UK70wYhfu gU9hfXM4RNt+QWdvfQPPxjCdj5TpH3CU7NgNETj5+s6RdPeTdJigWgg00JWulGjCifSH DKhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=elrHr5L0SkxQ3LO81KmQhscJxktKNPP4wxTaLG26eSY=; b=tjB69BMEb7dhISVw1MYo17fHZVOUbJZdzp9Oe8M/LNfsyPvFZBoJRH08qJefFUYwPt g3CdJT10AWv9Ua4yZyROIQ0k2jihM2e+7G1f+xo5j0Syi+TNc7Arnu9ulzdkL7DHBSz1 cP8zJFNBrlHDf0gyC2eBdQiDckdof87dfyUEJqAdfdsP8XqB83cn/jiL1TR6DKIeFbDm mcpAUBBxXozFz57kHJkCKMJwIHl92Jud3bm/lpii/jA7E3qVFaRB4H/N+qXscNGIAzi3 0L9NAYC/YosW+rfTKTKJk0yq7Yz7rUsyo/5KU+1E53OS+PiKskN3bz0dv32ZjrobnC4X fmwg== X-Gm-Message-State: AJIora/sv6SqvoKo5wwxUo+k81gOfEA7c0BF9pO4HQnYTsys0LKzmR1+ bKuTNHefwMOLjoJ+iNVziZftJVfIRGJrdw== X-Google-Smtp-Source: AGRyM1vxTB+eGNKJRv4tZVNZM98KJaujiTk2xJQ6Lsr7EFf4XdImQnRL57UnQYMTmdbUdouTqRSdBw== X-Received: by 2002:a05:651c:1691:b0:25d:8240:6b3a with SMTP id bd17-20020a05651c169100b0025d82406b3amr7021640ljb.305.1657912835973; Fri, 15 Jul 2022 12:20:35 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , Juergen Gross , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH V11 3/3] libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Date: Fri, 15 Jul 2022 22:20:26 +0300 Message-Id: <20220715192026.4013441-4-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715192026.4013441-1-olekstysh@gmail.com> References: <20220715192026.4013441-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD --- Changes RFC -> V1: - update commit description - rebase according to the recent changes to "libxl: Introduce basic virtio-mmio support on Arm" Changes V1 -> V2: - Henry already gave his Reviewed-by, I dropped it due to the changes - use generic IOMMU device tree bindings instead of custom property "xen,dev-domid" - change commit subject and description, was "libxl/arm: Insert "xen,dev-domid" property to virtio-mmio device node" Changes V2 -> V3: - add Stefano's and Anthony's R-b - send together with the series it depends on and drop post commit remark that described dependencies - update a comment on top of #define GUEST_PHANDLE_GIC --- tools/libs/light/libxl_arm.c | 49 +++++++++++++++++++++++++-- xen/include/public/device_tree_defs.h | 3 +- 2 files changed, 48 insertions(+), 4 deletions(-) diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c index 9be9b2a2d1..72da3b17a8 100644 --- a/tools/libs/light/libxl_arm.c +++ b/tools/libs/light/libxl_arm.c @@ -865,9 +865,32 @@ static int make_vpci_node(libxl__gc *gc, void *fdt, return 0; } +static int make_xen_iommu_node(libxl__gc *gc, void *fdt) +{ + int res; + + /* See Linux Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml */ + res = fdt_begin_node(fdt, "xen_iommu"); + if (res) return res; + + res = fdt_property_compat(gc, fdt, 1, "xen,grant-dma"); + if (res) return res; + + res = fdt_property_cell(fdt, "#iommu-cells", 1); + if (res) return res; + + res = fdt_property_cell(fdt, "phandle", GUEST_PHANDLE_IOMMU); + if (res) return res; + + res = fdt_end_node(fdt); + if (res) return res; + + return 0; +} static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, - uint64_t base, uint32_t irq) + uint64_t base, uint32_t irq, + uint32_t backend_domid) { int res; gic_interrupt intr; @@ -890,6 +913,16 @@ static int make_virtio_mmio_node(libxl__gc *gc, void *fdt, res = fdt_property(fdt, "dma-coherent", NULL, 0); if (res) return res; + if (backend_domid != LIBXL_TOOLSTACK_DOMID) { + uint32_t iommus_prop[2]; + + iommus_prop[0] = cpu_to_fdt32(GUEST_PHANDLE_IOMMU); + iommus_prop[1] = cpu_to_fdt32(backend_domid); + + res = fdt_property(fdt, "iommus", iommus_prop, sizeof(iommus_prop)); + if (res) return res; + } + res = fdt_end_node(fdt); if (res) return res; @@ -1097,6 +1130,7 @@ static int libxl__prepare_dtb(libxl__gc *gc, libxl_domain_config *d_config, size_t fdt_size = 0; int pfdt_size = 0; libxl_domain_build_info *const info = &d_config->b_info; + bool iommu_created; unsigned int i; const libxl_version_info *vers; @@ -1204,11 +1238,20 @@ next_resize: if (d_config->num_pcidevs) FDT( make_vpci_node(gc, fdt, ainfo, dom) ); + iommu_created = false; for (i = 0; i < d_config->num_disks; i++) { libxl_device_disk *disk = &d_config->disks[i]; - if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) - FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq) ); + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + if (disk->backend_domid != LIBXL_TOOLSTACK_DOMID && + !iommu_created) { + FDT( make_xen_iommu_node(gc, fdt) ); + iommu_created = true; + } + + FDT( make_virtio_mmio_node(gc, fdt, disk->base, disk->irq, + disk->backend_domid) ); + } } if (pfdt) diff --git a/xen/include/public/device_tree_defs.h b/xen/include/public/device_tree_defs.h index 209d43de3f..228daafe81 100644 --- a/xen/include/public/device_tree_defs.h +++ b/xen/include/public/device_tree_defs.h @@ -4,9 +4,10 @@ #if defined(__XEN__) || defined(__XEN_TOOLS__) /* * The device tree compiler (DTC) is allocating the phandle from 1 to - * onwards. Reserve a high value for the GIC phandle. + * onwards. Reserve high values for the specific phandles. */ #define GUEST_PHANDLE_GIC (65000) +#define GUEST_PHANDLE_IOMMU (GUEST_PHANDLE_GIC + 1) #define GUEST_ROOT_ADDRESS_CELLS 2 #define GUEST_ROOT_SIZE_CELLS 2 -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:20:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:20:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368520.599871 (Exim 4.92) (envelope-from ) id 1oCQrg-0000a8-AY; Fri, 15 Jul 2022 19:20:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368520.599871; Fri, 15 Jul 2022 19:20:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQrg-0000ZT-4c; Fri, 15 Jul 2022 19:20:40 +0000 Received: by outflank-mailman (input) for mailman id 368520; Fri, 15 Jul 2022 19:20:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQre-0008UB-Me for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:20:39 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 33cb0596-0473-11ed-bd2d-47488cf2e6aa; Fri, 15 Jul 2022 21:20:35 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id p6so6718516ljc.8 for ; Fri, 15 Jul 2022 12:20:35 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k3-20020ac257c3000000b0048159b43083sm1043178lfo.201.2022.07.15.12.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 12:20:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 33cb0596-0473-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4tTyAGIljF1M8o7Zp6xcDYS1i1GY6yi+U5pjXumAWGQ=; b=Ho9/t4tOBZYbC6uFRwKjiIpJEYjylxRxPFV6W8ouOIeHCuSmjuAGkcLLQO3jMbCjac SDsAg+FRiMP1uPji2Q7CoEPUxEZSipTZJP6ZW+VunEv1LwX76MHBF4UqQ9wF/K99yDFV K5ZyMqcJX2HGFEF/02NXWdtcJ5M/gGsmE9mhPA2WAoarT0zrmLNQEKtYXhyYJUEGsN4P FHaxFx5o2/YlJvdHYvJR0ExA0k9PHfaQfNo4Pm0N3xE+83NOk0En4Fg43s4B7oXJTg+z clTLq0rN4W5MC8JtdlJFkbQPiZWzPVakOQewMO0JXTsqbGgFNA5Veev4ukbfcbjGMbUx eg1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4tTyAGIljF1M8o7Zp6xcDYS1i1GY6yi+U5pjXumAWGQ=; b=HuUksWEBN/vZwZ8GFX4YNhOuLIHsXlDlIdmt8rZJqIA5u3rXB9GO5s9FkooqfQdJ6L px9F+XKBCLWDe0VP/GWLJjmm7sUsyMGnuQvNhAy1V1Gk7TNXN8v0yPAQngsDfSHIDKj1 juaLdtfXDXLqDaQBIuIPjpn6SSO4InV/tqYtpgXrujOgUB4CLx5yf9Er8/c7uVGDT5T9 KxjUiTzKGBkqk+QZCz3C1A2YWAAPAwrKuCvt75YOMPRZcxxTHN6AHziXhmOuLrye4yfO TyCxMfXS6OOyUMuFRV1z0dGSWk2tk5gHAuVAxIj0ZSHKbZST48nTQRNUBV2Bv4IaDtY5 ykQg== X-Gm-Message-State: AJIora+BRepru16XK+7lHNk4OPeQSZ+tIJzDEfdzcMtWbeBEOIxhCmQs KUmPLumPfRWIQ++N2m2o/xg3MuBPyxWCcA== X-Google-Smtp-Source: AGRyM1sdcFsRTduyDkwyy/80iIylCCt0HP/SIsYpZGbFYPmdsetXOiE/NYzfea6BsnGg8WpwNKZUjw== X-Received: by 2002:a05:651c:1a1e:b0:25d:a829:1d5e with SMTP id by30-20020a05651c1a1e00b0025da8291d5emr1065088ljb.160.1657912833241; Fri, 15 Jul 2022 12:20:33 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH V11 1/3] libxl: Add support for Virtio disk configuration Date: Fri, 15 Jul 2022 22:20:24 +0300 Message-Id: <20220715192026.4013441-2-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715192026.4013441-1-olekstysh@gmail.com> References: <20220715192026.4013441-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - no changes Changes V1 -> V2: - rebase according to the new location of libxl_virtio_disk.c Changes V2 -> V3: - no changes Changes V3 -> V4: - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT Changes V4 -> V5: - split the changes, change the order of the patches - update patch description - don't introduce new "vdisk" configuration option with own parsing logic, re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk - introduce "virtio" flag and document it's usage - add LIBXL_HAVE_DEVICE_DISK_VIRTIO - update libxlu_disk_l.[ch] - drop num_disks variable/MAX_VIRTIO_DISKS - drop Wei's T-b Changes V5 -> V6: - rebase on current staging - use "%"PRIu64 instead of %lu for disk->base in device_disk_add() - update *.gen.go files Changes V6 -> V7: - rebase on current staging - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description - rework significantly to support more flexible configuration and have more generic basic implementation for being able to extend that for other use-cases (virtio-pci, qemu, etc). Changes V7 -> V8: - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description and comments in the code - use "specification" config option instead of "protocol" - update libxl_types.idl and code according to new fields in libxl_device_disk Changes V8 -> V9: - update (and harden) checks in libxl__device_disk_setdefault(), return error in case of incorrect settings of specification and transport - remove both asserts in device_disk_add() - update virtio related code in libxl__disk_from_xenstore(), do not fail if specification node is absent, replace open-coded checks of fetched specification and transport by libxl_disk_specification_from_string() and libxl_disk_transport_from_string() respectively - s/libxl_device_disk_get_path/libxl__device_disk_get_path - add a comment for virtio-mmio parameters in struct libxl_device_disk Changes V9 -> V10: - s/ERROR_FAIL/ERROR_INVAL in both places in libxl__device_disk_setdefault() - rework libxl__device_disk_get_path() Changes V10 -> V10.1: - fix small coding style issue in libxl__device_disk_get_path() - drop specification check in main_blockattach() and add required check in libxl__device_disk_setdefault() - update specification check in main_blockdetach() Changes V10.1 -> V11: - Anthony already gave his Reviewed-by, I dropped it due to the changes - George already gave his Acked-by, I dropped it due to the changes - s/other/standalone for the backendtype --- docs/man/xl-disk-configuration.5.pod.in | 38 +- tools/golang/xenlight/helpers.gen.go | 8 + tools/golang/xenlight/types.gen.go | 18 + tools/include/libxl.h | 7 + tools/libs/light/libxl_device.c | 62 +- tools/libs/light/libxl_disk.c | 146 +++- tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 18 + tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_utils.c | 2 + tools/libs/util/libxlu_disk_l.c | 959 +++++++++++----------- tools/libs/util/libxlu_disk_l.h | 2 +- tools/libs/util/libxlu_disk_l.l | 9 + tools/xl/xl_block.c | 6 + 14 files changed, 798 insertions(+), 480 deletions(-) diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in index 71d0e86e3d..822c940f90 100644 --- a/docs/man/xl-disk-configuration.5.pod.in +++ b/docs/man/xl-disk-configuration.5.pod.in @@ -232,7 +232,7 @@ Specifies the backend implementation to use =item Supported values -phy, qdisk +phy, qdisk, standalone =item Mandatory @@ -244,11 +244,13 @@ Automatically determine which backend to use. =back -This does not affect the guest's view of the device. It controls -which software implementation of the Xen backend driver is used. +It controls which software implementation of the backend driver is used. +Depending on the "specification" option this may affect the guest's view +of the device. Not all backend drivers support all combinations of other options. -For example, "phy" does not support formats other than "raw". +For example, "phy" and "standalone" do not support formats other than "raw" +and "standalone" does not support specifications other than "virtio". Normally this option should not be specified, in which case libxl will automatically determine the most suitable backend. @@ -344,8 +346,36 @@ can be used to disable "hole punching" for file based backends which were intentionally created non-sparse to avoid fragmentation of the file. +=item B=I + +=over 4 + +=item Description + +Specifies the communication protocol (specification) to use for the chosen +"backendtype" option + +=item Supported values + +xen, virtio + +=item Mandatory + +No + +=item Default value + +xen + =back +Besides forcing toolstack to use specific backend implementation, this also +affects the guest's view of the device. For example, "virtio" requires +Virtio frontend driver (virtio-blk) to be used. Please note, the virtual +device (vdev) is not passed to the guest in that case, but it still must be +specified for the internal purposes. + +=back =head1 COLO Parameters diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index b746ff1081..00f10b9df3 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1751,6 +1751,10 @@ x.DirectIoSafe = bool(xc.direct_io_safe) if err := x.DiscardEnable.fromC(&xc.discard_enable);err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +x.Specification = DiskSpecification(xc.specification) +x.Transport = DiskTransport(xc.transport) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) if err := x.ColoEnable.fromC(&xc.colo_enable);err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } @@ -1788,6 +1792,10 @@ xc.direct_io_safe = C.bool(x.DirectIoSafe) if err := x.DiscardEnable.toC(&xc.discard_enable); err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +xc.specification = C.libxl_disk_specification(x.Specification) +xc.transport = C.libxl_disk_transport(x.Transport) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) if err := x.ColoEnable.toC(&xc.colo_enable); err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index b1e84d5258..c729b95d02 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -99,6 +99,20 @@ DiskBackendUnknown DiskBackend = 0 DiskBackendPhy DiskBackend = 1 DiskBackendTap DiskBackend = 2 DiskBackendQdisk DiskBackend = 3 +DiskBackendStandalone DiskBackend = 4 +) + +type DiskSpecification int +const( +DiskSpecificationUnknown DiskSpecification = 0 +DiskSpecificationXen DiskSpecification = 1 +DiskSpecificationVirtio DiskSpecification = 2 +) + +type DiskTransport int +const( +DiskTransportUnknown DiskTransport = 0 +DiskTransportMmio DiskTransport = 1 ) type NicType int @@ -643,6 +657,10 @@ Readwrite int IsCdrom int DirectIoSafe bool DiscardEnable Defbool +Specification DiskSpecification +Transport DiskTransport +Irq uint32 +Base uint64 ColoEnable Defbool ColoRestoreEnable Defbool ColoHost string diff --git a/tools/include/libxl.h b/tools/include/libxl.h index 7ce978e83c..0f02b6b58b 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -527,6 +527,13 @@ */ #define LIBXL_HAVE_MAX_GRANT_VERSION 1 +/* + * LIBXL_HAVE_DEVICE_DISK_SPECIFICATION indicates that 'specification' and + * 'transport' fields (of libxl_disk_specification and libxl_disk_transport + * types respectively) are present in libxl_device_disk. + */ +#define LIBXL_HAVE_DEVICE_DISK_SPECIFICATION 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c index e6025d135e..a75c21d433 100644 --- a/tools/libs/light/libxl_device.c +++ b/tools/libs/light/libxl_device.c @@ -289,9 +289,16 @@ static int disk_try_backend(disk_try_backend_args *a, libxl_disk_backend backend) { libxl__gc *gc = a->gc; + libxl_disk_specification specification = a->disk->specification; /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or * backend on success */ + if ((specification == LIBXL_DISK_SPECIFICATION_VIRTIO && + backend != LIBXL_DISK_BACKEND_STANDALONE) || + (specification != LIBXL_DISK_SPECIFICATION_VIRTIO && + backend == LIBXL_DISK_BACKEND_STANDALONE)) + goto bad_specification; + switch (backend) { case LIBXL_DISK_BACKEND_PHY: if (a->disk->format != LIBXL_DISK_FORMAT_RAW) { @@ -329,6 +336,29 @@ static int disk_try_backend(disk_try_backend_args *a, if (a->disk->script) goto bad_script; return backend; + case LIBXL_DISK_BACKEND_STANDALONE: + if (a->disk->format != LIBXL_DISK_FORMAT_RAW) + goto bad_format; + + if (a->disk->script) + goto bad_script; + + if (libxl_defbool_val(a->disk->colo_enable)) + goto bad_colo; + + if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) { + LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, " + "skipping physical device check", a->disk->vdev); + return backend; + } + + if (libxl__try_phy_backend(a->stab.st_mode)) + return backend; + + LOG(DEBUG, "Disk vdev=%s, backend standalone unsuitable as phys path not a " + "block device", a->disk->vdev); + return 0; + default: LOG(DEBUG, "Disk vdev=%s, backend %d unknown", a->disk->vdev, backend); return 0; @@ -352,6 +382,12 @@ static int disk_try_backend(disk_try_backend_args *a, LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with colo", a->disk->vdev, libxl_disk_backend_to_string(backend)); return 0; + + bad_specification: + LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with specification %s", + a->disk->vdev, libxl_disk_backend_to_string(backend), + libxl_disk_specification_to_string(specification)); + return 0; } int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path, @@ -376,8 +412,9 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { a.gc = gc; a.disk = disk; - LOG(DEBUG, "Disk vdev=%s spec.backend=%s", disk->vdev, - libxl_disk_backend_to_string(disk->backend)); + LOG(DEBUG, "Disk vdev=%s spec.backend=%s specification=%s", disk->vdev, + libxl_disk_backend_to_string(disk->backend), + libxl_disk_specification_to_string(disk->specification)); if (disk->format == LIBXL_DISK_FORMAT_EMPTY) { if (!disk->is_cdrom) { @@ -392,7 +429,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { } memset(&a.stab, 0, sizeof(a.stab)); } else if ((disk->backend == LIBXL_DISK_BACKEND_UNKNOWN || - disk->backend == LIBXL_DISK_BACKEND_PHY) && + disk->backend == LIBXL_DISK_BACKEND_PHY || + disk->backend == LIBXL_DISK_BACKEND_STANDALONE) && disk->backend_domid == LIBXL_TOOLSTACK_DOMID && !disk->script) { if (stat(disk->pdev_path, &a.stab)) { @@ -408,7 +446,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { ok= disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?: disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?: - disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP); + disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?: + disk_try_backend(&a, LIBXL_DISK_BACKEND_STANDALONE); if (ok) LOG(DEBUG, "Disk vdev=%s, using backend %s", disk->vdev, @@ -441,10 +480,25 @@ char *libxl__device_disk_string_of_backend(libxl_disk_backend backend) case LIBXL_DISK_BACKEND_QDISK: return "qdisk"; case LIBXL_DISK_BACKEND_TAP: return "phy"; case LIBXL_DISK_BACKEND_PHY: return "phy"; + case LIBXL_DISK_BACKEND_STANDALONE: return "standalone"; + default: return NULL; + } +} + +char *libxl__device_disk_string_of_specification(libxl_disk_specification specification) +{ + switch (specification) { + case LIBXL_DISK_SPECIFICATION_XEN: return "xen"; + case LIBXL_DISK_SPECIFICATION_VIRTIO: return "virtio"; default: return NULL; } } +char *libxl__device_disk_string_of_transport(libxl_disk_transport transport) +{ + return (transport == LIBXL_DISK_TRANSPORT_MMIO ? "mmio" : NULL); +} + const char *libxl__qemu_disk_format_string(libxl_disk_format format) { switch (format) { diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index a5ca77850f..4429bfd479 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -163,6 +163,30 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); if (rc < 0) return rc; + if (disk->specification == LIBXL_DISK_SPECIFICATION_UNKNOWN) + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_XEN && + disk->transport != LIBXL_DISK_TRANSPORT_UNKNOWN) { + LOGD(ERROR, domid, "Transport is only supported for specification virtio"); + return ERROR_INVAL; + } + + /* Force transport mmio for specification virtio for now */ + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + if (!(disk->transport == LIBXL_DISK_TRANSPORT_UNKNOWN || + disk->transport == LIBXL_DISK_TRANSPORT_MMIO)) { + LOGD(ERROR, domid, "Unsupported transport for specification virtio"); + return ERROR_INVAL; + } + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; + } + + if (hotplug && disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + LOGD(ERROR, domid, "Hotplug isn't supported for specification virtio"); + return ERROR_FAIL; + } + /* Force Qdisk backend for CDROM devices of guests with a device model. */ if (disk->is_cdrom != 0 && libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { @@ -204,6 +228,9 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, case LIBXL_DISK_BACKEND_QDISK: device->backend_kind = LIBXL__DEVICE_KIND_QDISK; break; + case LIBXL_DISK_BACKEND_STANDALONE: + device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO_DISK; + break; default: LOGD(ERROR, domid, "Unrecognized disk backend type: %d", disk->backend); @@ -212,7 +239,8 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, device->domid = domid; device->devid = devid; - device->kind = LIBXL__DEVICE_KIND_VBD; + device->kind = disk->backend == LIBXL_DISK_BACKEND_STANDALONE ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; return 0; } @@ -330,7 +358,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD); break; + case LIBXL_DISK_BACKEND_STANDALONE: + dev = disk->pdev_path; + + flexarray_append(back, "params"); + flexarray_append(back, dev); + assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK); + break; case LIBXL_DISK_BACKEND_TAP: LOG(ERROR, "blktap is not supported"); rc = ERROR_FAIL; @@ -386,6 +421,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, flexarray_append_pair(back, "discard-enable", libxl_defbool_val(disk->discard_enable) ? "1" : "0"); + flexarray_append(back, "specification"); + flexarray_append(back, libxl__device_disk_string_of_specification(disk->specification)); + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + flexarray_append(back, "transport"); + flexarray_append(back, libxl__device_disk_string_of_transport(disk->transport)); + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base)); + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq)); + } flexarray_append(front, "backend-id"); flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); @@ -532,6 +575,53 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path, } libxl_string_to_backend(ctx, tmp, &(disk->backend)); + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/specification", libxl_path)); + if (!tmp) { + LOG(DEBUG, "Missing xenstore node %s/specification, assuming specification xen", libxl_path); + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + } else { + rc = libxl_disk_specification_from_string(tmp, &disk->specification); + if (rc) { + LOG(ERROR, "Unable to parse xenstore node %s/specification", libxl_path); + goto cleanup; + } + } + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/transport", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path); + goto cleanup; + } + rc = libxl_disk_transport_from_string(tmp, &disk->transport); + if (rc) { + LOG(ERROR, "Unable to parse xenstore node %s/transport", libxl_path); + goto cleanup; + } + if (disk->transport != LIBXL_DISK_TRANSPORT_MMIO) { + LOG(ERROR, "Only transport mmio is expected for specification virtio"); + goto cleanup; + } + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/base", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); + goto cleanup; + } + disk->base = strtoul(tmp, NULL, 10); + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/irq", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); + goto cleanup; + } + disk->irq = strtoul(tmp, NULL, 10); + } + disk->vdev = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/dev", libxl_path), &len); if (!disk->vdev) { @@ -575,6 +665,42 @@ cleanup: return rc; } +static int libxl__device_disk_get_path(libxl__gc *gc, uint32_t domid, + char **path) +{ + const char *xen_dir, *virtio_dir; + char *xen_path, *virtio_path; + int rc; + + /* default path */ + xen_path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, xen_path, &xen_dir); + if (rc) + return rc; + + virtio_path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, virtio_path, &virtio_dir); + if (rc) + return rc; + + if (xen_dir && virtio_dir) { + LOGD(ERROR, domid, "Invalid configuration, both xen and virtio paths are present"); + return ERROR_INVAL; + } else if (virtio_dir) { + *path = virtio_path; + } else { + *path = xen_path; + } + + return 0; +} + int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, const char *vdev, libxl_device_disk *disk) { @@ -588,10 +714,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, libxl_device_disk_init(disk); - libxl_path = libxl__domain_device_libxl_path(gc, domid, devid, - LIBXL__DEVICE_KIND_VBD); + rc = libxl__device_disk_get_path(gc, domid, &libxl_path); + if (rc) + return rc; - rc = libxl__disk_from_xenstore(gc, libxl_path, devid, disk); + rc = libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, devid), + devid, disk); GC_FREE; return rc; @@ -605,16 +733,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid, char *fe_path, *libxl_path; char *val; int rc; + libxl__device_kind kind; diskinfo->backend = NULL; diskinfo->devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL); - /* tap devices entries in xenstore are written as vbd devices. */ + /* tap devices entries in xenstore are written as vbd/virtio_disk devices. */ + kind = disk->backend == LIBXL_DISK_BACKEND_STANDALONE ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; fe_path = libxl__domain_device_frontend_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); libxl_path = libxl__domain_device_libxl_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); diskinfo->backend = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/backend", libxl_path), NULL); if (!diskinfo->backend) { @@ -1418,6 +1549,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk) #define libxl__device_disk_update_devid NULL DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks, + .get_path = libxl__device_disk_get_path, .merge = libxl_device_disk_merge, .dm_needed = libxl_device_disk_dm_needed, .from_xenstore = (device_from_xenstore_fn_t)libxl__disk_from_xenstore, diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index bdef5a605e..cb9e8b3b8b 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -1493,6 +1493,8 @@ _hidden char * libxl__domain_pvcontrol_read(libxl__gc *gc, /* from xl_device */ _hidden char *libxl__device_disk_string_of_backend(libxl_disk_backend backend); +_hidden char *libxl__device_disk_string_of_specification(libxl_disk_specification specification); +_hidden char *libxl__device_disk_string_of_transport(libxl_disk_transport transport); _hidden char *libxl__device_disk_string_of_format(libxl_disk_format format); _hidden const char *libxl__qemu_disk_format_string(libxl_disk_format format); _hidden int libxl__device_disk_set_backend(libxl__gc*, libxl_device_disk*); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index 2a42da2f7d..3c898e320c 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -130,6 +130,18 @@ libxl_disk_backend = Enumeration("disk_backend", [ (1, "PHY"), (2, "TAP"), (3, "QDISK"), + (4, "STANDALONE"), # Only relying on the Xenstore data + ]) + +libxl_disk_specification = Enumeration("disk_specification", [ + (0, "UNKNOWN"), + (1, "XEN"), + (2, "VIRTIO"), + ]) + +libxl_disk_transport = Enumeration("disk_transport", [ + (0, "UNKNOWN"), + (1, "MMIO"), ]) libxl_nic_type = Enumeration("nic_type", [ @@ -704,6 +716,12 @@ libxl_device_disk = Struct("device_disk", [ ("is_cdrom", integer), ("direct_io_safe", bool), ("discard_enable", libxl_defbool), + ("specification", libxl_disk_specification), + ("transport", libxl_disk_transport), + # Note that virtio-mmio parameters (irq and base) are for internal use + # by libxl and can't be modified. + ("irq", uint32), + ("base", uint64), # Note that the COLO configuration settings should be considered unstable. # They may change incompatibly in future versions of Xen. ("colo_enable", libxl_defbool), diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 3593e21dbb..8f71980aec 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "VIRTIO_DISK"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c index e5e6b2da96..e403bd9bcf 100644 --- a/tools/libs/light/libxl_utils.c +++ b/tools/libs/light/libxl_utils.c @@ -297,6 +297,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, libxl_disk_backend *backend *backend = LIBXL_DISK_BACKEND_TAP; } else if (!strcmp(s, "qdisk")) { *backend = LIBXL_DISK_BACKEND_QDISK; + } else if (!strcmp(s, "standalone")) { + *backend = LIBXL_DISK_BACKEND_STANDALONE; } else if (!strcmp(s, "tap")) { p = strchr(s, ':'); if (!p) { diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c index 32d4b74b58..0b59723b71 100644 --- a/tools/libs/util/libxlu_disk_l.c +++ b/tools/libs/util/libxlu_disk_l.c @@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner ); yyg->yy_hold_char = *yy_cp; \ *yy_cp = '\0'; \ yyg->yy_c_buf_p = yy_cp; -#define YY_NUM_RULES 36 -#define YY_END_OF_BUFFER 37 +#define YY_NUM_RULES 37 +#define YY_END_OF_BUFFER 38 /* This struct is not used in this scanner, but its presence is necessary. */ struct yy_trans_info @@ -558,74 +558,77 @@ struct yy_trans_info flex_int32_t yy_verify; flex_int32_t yy_nxt; }; -static const flex_int16_t yy_acclist[575] = +static const flex_int16_t yy_acclist[594] = { 0, - 35, 35, 37, 33, 34, 36, 8193, 33, 34, 36, - 16385, 8193, 33, 36,16385, 33, 34, 36, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 33, 34, - 36, 33, 34, 36, 33, 34, 36, 33, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 35, 36, - 36, 33, 33, 8193, 33, 8193, 33,16385, 8193, 33, - 8193, 33, 33, 8224, 33,16416, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - - 33, 33, 33, 33, 33, 33, 33, 33, 33, 35, - 8193, 33, 8193, 33, 8193, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 28, 8224, 33,16416, 33, 33, 15, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 8217, - 8224, 33,16409,16416, 33, 33, 31, 8224, 33,16416, - 33, 8216, 8224, 33,16408,16416, 33, 33, 8219, 8224, - 33,16411,16416, 33, 33, 33, 33, 33, 28, 8224, - - 33, 28, 8224, 33, 28, 33, 28, 8224, 33, 3, - 33, 15, 33, 33, 33, 33, 33, 30, 8224, 33, - 16416, 33, 33, 33, 8217, 8224, 33, 8217, 8224, 33, - 8217, 33, 8217, 8224, 33, 33, 31, 8224, 33, 31, - 8224, 33, 31, 33, 31, 8224, 8216, 8224, 33, 8216, - 8224, 33, 8216, 33, 8216, 8224, 33, 8219, 8224, 33, - 8219, 8224, 33, 8219, 33, 8219, 8224, 33, 33, 10, - 33, 33, 28, 8224, 33, 28, 8224, 33, 28, 8224, - 28, 33, 28, 33, 3, 33, 33, 33, 33, 33, - 33, 33, 30, 8224, 33, 30, 8224, 33, 30, 33, - - 30, 8224, 33, 33, 29, 8224, 33,16416, 8217, 8224, - 33, 8217, 8224, 33, 8217, 8224, 8217, 33, 8217, 33, - 33, 31, 8224, 33, 31, 8224, 33, 31, 8224, 31, - 33, 31, 8216, 8224, 33, 8216, 8224, 33, 8216, 8224, - 8216, 33, 8216, 33, 8219, 8224, 33, 8219, 8224, 33, - 8219, 8224, 8219, 33, 8219, 33, 33, 10, 23, 10, - 7, 33, 33, 33, 33, 33, 33, 33, 13, 33, - 30, 8224, 33, 30, 8224, 33, 30, 8224, 30, 33, - 30, 2, 33, 29, 8224, 33, 29, 8224, 33, 29, - 33, 29, 8224, 16, 33, 33, 11, 33, 22, 10, - - 10, 23, 7, 23, 7, 33, 8, 33, 33, 33, - 33, 6, 33, 13, 33, 2, 23, 2, 33, 29, - 8224, 33, 29, 8224, 33, 29, 8224, 29, 33, 29, - 16, 33, 33, 11, 23, 11, 26, 8224, 33,16416, - 22, 23, 22, 7, 7, 23, 33, 8, 23, 8, - 33, 33, 33, 33, 6, 23, 6, 6, 23, 6, - 23, 33, 2, 2, 23, 33, 33, 11, 11, 23, - 26, 8224, 33, 26, 8224, 33, 26, 33, 26, 8224, - 22, 23, 33, 8, 8, 23, 33, 33, 17, 18, - 6, 6, 23, 6, 6, 33, 33, 14, 33, 26, - - 8224, 33, 26, 8224, 33, 26, 8224, 26, 33, 26, - 33, 33, 33, 17, 23, 17, 18, 23, 18, 6, - 6, 33, 33, 14, 33, 20, 9, 19, 17, 17, - 23, 18, 18, 23, 6, 5, 6, 33, 21, 20, - 23, 20, 9, 23, 9, 19, 23, 19, 4, 6, - 5, 6, 33, 21, 23, 21, 20, 20, 23, 9, - 9, 23, 19, 19, 23, 4, 6, 12, 33, 21, - 21, 23, 12, 33 + 36, 36, 38, 34, 35, 37, 8193, 34, 35, 37, + 16385, 8193, 34, 37,16385, 34, 35, 37, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 34, 35, + 37, 34, 35, 37, 34, 35, 37, 34, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 36, 37, + 37, 34, 34, 8193, 34, 8193, 34,16385, 8193, 34, + 8193, 34, 34, 8225, 34,16417, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 36, 8193, 34, 8193, 34, 8193, 8225, 34, 8225, 34, + 8225, 24, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 8225, 34, 8225, + 34, 8225, 24, 34, 34, 29, 8225, 34,16417, 34, + 34, 16, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 8218, 8225, 34,16410,16417, 34, 34, 32, 8225, + 34,16417, 34, 8217, 8225, 34,16409,16417, 34, 34, + 34, 8220, 8225, 34,16412,16417, 34, 34, 34, 34, + + 34, 29, 8225, 34, 29, 8225, 34, 29, 34, 29, + 8225, 34, 3, 34, 16, 34, 34, 34, 34, 34, + 31, 8225, 34,16417, 34, 34, 34, 8218, 8225, 34, + 8218, 8225, 34, 8218, 34, 8218, 8225, 34, 34, 32, + 8225, 34, 32, 8225, 34, 32, 34, 32, 8225, 8217, + 8225, 34, 8217, 8225, 34, 8217, 34, 8217, 8225, 34, + 34, 8220, 8225, 34, 8220, 8225, 34, 8220, 34, 8220, + 8225, 34, 34, 11, 34, 34, 29, 8225, 34, 29, + 8225, 34, 29, 8225, 29, 34, 29, 34, 3, 34, + 34, 34, 34, 34, 34, 34, 31, 8225, 34, 31, + + 8225, 34, 31, 34, 31, 8225, 34, 34, 30, 8225, + 34,16417, 8218, 8225, 34, 8218, 8225, 34, 8218, 8225, + 8218, 34, 8218, 34, 34, 32, 8225, 34, 32, 8225, + 34, 32, 8225, 32, 34, 32, 8217, 8225, 34, 8217, + 8225, 34, 8217, 8225, 8217, 34, 8217, 34, 34, 8220, + 8225, 34, 8220, 8225, 34, 8220, 8225, 8220, 34, 8220, + 34, 34, 11, 24, 11, 7, 34, 34, 34, 34, + 34, 34, 34, 14, 34, 31, 8225, 34, 31, 8225, + 34, 31, 8225, 31, 34, 31, 2, 34, 30, 8225, + 34, 30, 8225, 34, 30, 34, 30, 8225, 17, 34, + + 34, 12, 34, 34, 23, 11, 11, 24, 7, 24, + 7, 34, 8, 34, 34, 34, 34, 6, 34, 14, + 34, 2, 24, 2, 34, 30, 8225, 34, 30, 8225, + 34, 30, 8225, 30, 34, 30, 17, 34, 34, 12, + 24, 12, 34, 27, 8225, 34,16417, 23, 24, 23, + 7, 7, 24, 34, 8, 24, 8, 34, 34, 34, + 34, 6, 24, 6, 6, 24, 6, 24, 34, 2, + 2, 24, 34, 34, 12, 12, 24, 34, 27, 8225, + 34, 27, 8225, 34, 27, 34, 27, 8225, 23, 24, + 34, 8, 8, 24, 34, 34, 18, 19, 6, 6, + + 24, 6, 6, 34, 34, 15, 34, 34, 27, 8225, + 34, 27, 8225, 34, 27, 8225, 27, 34, 27, 34, + 34, 34, 18, 24, 18, 19, 24, 19, 6, 6, + 34, 34, 15, 34, 34, 21, 9, 20, 18, 18, + 24, 19, 19, 24, 6, 5, 6, 34, 22, 34, + 21, 24, 21, 9, 24, 9, 20, 24, 20, 4, + 6, 5, 6, 34, 22, 24, 22, 34, 21, 21, + 24, 9, 9, 24, 20, 20, 24, 4, 6, 13, + 34, 22, 22, 24, 10, 13, 34, 10, 24, 10, + 10, 10, 24 + } ; -static const flex_int16_t yy_accept[356] = +static const flex_int16_t yy_accept[373] = { 0, 1, 1, 1, 2, 3, 4, 7, 12, 16, 19, 21, 24, 27, 30, 33, 36, 39, 42, 45, 48, @@ -633,39 +636,41 @@ static const flex_int16_t yy_accept[356] = 74, 76, 79, 81, 82, 83, 84, 87, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, - 109, 110, 111, 113, 115, 116, 118, 120, 121, 122, + 109, 110, 111, 112, 114, 116, 117, 119, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, - 143, 144, 145, 146, 148, 150, 151, 152, 153, 154, - - 158, 159, 160, 162, 163, 164, 165, 166, 167, 168, - 169, 170, 175, 176, 177, 181, 182, 187, 188, 189, - 194, 195, 196, 197, 198, 199, 202, 205, 207, 209, - 210, 212, 214, 215, 216, 217, 218, 222, 223, 224, - 225, 228, 231, 233, 235, 236, 237, 240, 243, 245, - 247, 250, 253, 255, 257, 258, 261, 264, 266, 268, - 269, 270, 271, 272, 273, 276, 279, 281, 283, 284, - 285, 287, 288, 289, 290, 291, 292, 293, 296, 299, - 301, 303, 304, 305, 309, 312, 315, 317, 319, 320, - 321, 322, 325, 328, 330, 332, 333, 336, 339, 341, - - 343, 344, 345, 348, 351, 353, 355, 356, 357, 358, - 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, - 371, 374, 377, 379, 381, 382, 383, 384, 387, 390, - 392, 394, 396, 397, 398, 399, 400, 401, 403, 405, - 406, 407, 408, 409, 410, 411, 412, 413, 414, 416, - 418, 419, 420, 423, 426, 428, 430, 431, 433, 434, - 436, 437, 441, 443, 444, 445, 447, 448, 450, 451, - 452, 453, 454, 455, 457, 458, 460, 462, 463, 464, - 466, 467, 468, 469, 471, 474, 477, 479, 481, 483, - 484, 485, 487, 488, 489, 490, 491, 492, 494, 495, - - 496, 497, 498, 500, 503, 506, 508, 510, 511, 512, - 513, 514, 516, 517, 519, 520, 521, 522, 523, 524, - 526, 527, 528, 529, 530, 532, 533, 535, 536, 538, - 539, 540, 542, 543, 545, 546, 548, 549, 551, 553, - 554, 556, 557, 558, 560, 561, 563, 564, 566, 568, - 570, 571, 573, 575, 575 + 143, 144, 145, 146, 147, 148, 150, 152, 153, 154, + + 155, 156, 160, 161, 162, 164, 165, 166, 167, 168, + 169, 170, 171, 172, 177, 178, 179, 183, 184, 189, + 190, 191, 192, 197, 198, 199, 200, 201, 202, 205, + 208, 210, 212, 213, 215, 217, 218, 219, 220, 221, + 225, 226, 227, 228, 231, 234, 236, 238, 239, 240, + 243, 246, 248, 250, 253, 256, 258, 260, 261, 262, + 265, 268, 270, 272, 273, 274, 275, 276, 277, 280, + 283, 285, 287, 288, 289, 291, 292, 293, 294, 295, + 296, 297, 300, 303, 305, 307, 308, 309, 313, 316, + 319, 321, 323, 324, 325, 326, 329, 332, 334, 336, + + 337, 340, 343, 345, 347, 348, 349, 350, 353, 356, + 358, 360, 361, 362, 363, 365, 366, 367, 368, 369, + 370, 371, 372, 373, 374, 376, 379, 382, 384, 386, + 387, 388, 389, 392, 395, 397, 399, 401, 402, 403, + 404, 405, 406, 407, 409, 411, 412, 413, 414, 415, + 416, 417, 418, 419, 420, 422, 424, 425, 426, 429, + 432, 434, 436, 437, 439, 440, 442, 443, 444, 448, + 450, 451, 452, 454, 455, 457, 458, 459, 460, 461, + 462, 464, 465, 467, 469, 470, 471, 473, 474, 475, + 476, 478, 479, 482, 485, 487, 489, 491, 492, 493, + + 495, 496, 497, 498, 499, 500, 502, 503, 504, 505, + 506, 508, 509, 512, 515, 517, 519, 520, 521, 522, + 523, 525, 526, 528, 529, 530, 531, 532, 533, 535, + 536, 537, 538, 539, 540, 542, 543, 545, 546, 548, + 549, 550, 551, 553, 554, 556, 557, 559, 560, 562, + 564, 565, 567, 568, 569, 570, 572, 573, 575, 576, + 578, 580, 582, 583, 585, 586, 588, 590, 591, 592, + 594, 594 } ; static const YY_CHAR yy_ec[256] = @@ -708,216 +713,224 @@ static const YY_CHAR yy_meta[35] = 1, 1, 1, 1 } ; -static const flex_int16_t yy_base[424] = +static const flex_int16_t yy_base[443] = { 0, - 0, 0, 901, 900, 902, 897, 33, 36, 905, 905, - 45, 63, 31, 42, 51, 52, 890, 33, 65, 67, - 69, 70, 889, 71, 888, 75, 0, 905, 893, 905, - 91, 94, 0, 0, 103, 886, 112, 0, 89, 98, - 113, 92, 114, 99, 100, 48, 121, 116, 119, 74, - 124, 129, 123, 135, 132, 133, 137, 134, 138, 139, - 141, 0, 155, 0, 0, 164, 0, 0, 849, 142, - 152, 164, 140, 161, 165, 166, 167, 168, 169, 173, - 174, 178, 176, 180, 184, 208, 189, 183, 192, 195, - 215, 191, 193, 223, 0, 0, 905, 208, 204, 236, - - 219, 209, 238, 196, 237, 831, 242, 815, 241, 224, - 243, 261, 244, 259, 277, 266, 286, 250, 288, 298, - 249, 283, 274, 282, 294, 308, 0, 310, 0, 295, - 305, 905, 308, 306, 313, 314, 342, 319, 316, 320, - 331, 0, 349, 0, 342, 344, 356, 0, 358, 0, - 365, 0, 367, 0, 354, 375, 0, 377, 0, 363, - 356, 809, 327, 322, 384, 0, 0, 0, 0, 379, - 905, 382, 384, 386, 390, 372, 392, 403, 0, 410, - 0, 407, 413, 423, 426, 0, 0, 0, 0, 409, - 424, 435, 0, 0, 0, 0, 437, 0, 0, 0, - - 0, 433, 444, 0, 0, 0, 0, 391, 440, 781, - 905, 769, 439, 445, 444, 447, 449, 454, 453, 399, - 464, 0, 0, 0, 0, 757, 465, 476, 0, 478, - 0, 479, 476, 753, 462, 490, 749, 905, 745, 905, - 483, 737, 424, 485, 487, 490, 500, 493, 905, 729, - 905, 502, 518, 0, 0, 0, 0, 905, 498, 721, - 905, 527, 713, 0, 705, 905, 495, 697, 905, 365, - 521, 528, 530, 685, 905, 534, 540, 540, 657, 905, - 537, 542, 650, 905, 553, 0, 557, 0, 0, 551, - 641, 905, 558, 557, 633, 614, 613, 905, 547, 555, - - 563, 565, 569, 584, 0, 0, 0, 0, 583, 570, - 585, 612, 905, 601, 905, 522, 580, 589, 594, 905, - 600, 585, 563, 520, 905, 514, 905, 586, 486, 597, - 480, 441, 905, 416, 905, 345, 905, 334, 905, 601, - 254, 905, 242, 905, 200, 905, 151, 905, 905, 607, - 86, 905, 905, 905, 620, 624, 627, 631, 635, 639, - 643, 647, 651, 655, 659, 663, 667, 671, 675, 679, - 683, 687, 691, 695, 699, 703, 707, 711, 715, 719, - 723, 727, 731, 735, 739, 743, 747, 751, 755, 759, - 763, 767, 771, 775, 779, 783, 787, 791, 795, 799, - - 803, 807, 811, 815, 819, 823, 827, 831, 835, 839, - 843, 847, 851, 855, 859, 863, 867, 871, 875, 879, - 883, 887, 891 + 0, 0, 936, 935, 937, 932, 33, 36, 940, 940, + 45, 63, 31, 42, 51, 52, 925, 33, 65, 67, + 69, 70, 924, 71, 923, 75, 0, 940, 928, 940, + 91, 95, 0, 0, 104, 921, 113, 0, 91, 99, + 114, 92, 115, 80, 100, 48, 119, 121, 122, 74, + 123, 128, 131, 129, 125, 133, 135, 136, 137, 143, + 138, 145, 0, 157, 0, 0, 168, 0, 0, 926, + 140, 146, 165, 159, 152, 164, 155, 168, 171, 176, + 177, 170, 180, 175, 184, 188, 212, 191, 185, 192, + 193, 194, 219, 212, 199, 230, 0, 0, 940, 195, + + 200, 239, 235, 197, 246, 225, 226, 919, 244, 918, + 243, 236, 245, 266, 248, 264, 282, 271, 291, 248, + 270, 254, 300, 279, 296, 302, 288, 303, 311, 0, + 315, 0, 311, 318, 940, 313, 319, 208, 313, 344, + 321, 331, 325, 333, 0, 352, 0, 345, 347, 359, + 0, 361, 0, 368, 0, 370, 0, 322, 366, 379, + 0, 381, 0, 359, 357, 923, 382, 384, 392, 0, + 0, 0, 0, 387, 940, 386, 390, 392, 329, 401, + 397, 409, 0, 417, 0, 399, 412, 426, 429, 0, + 0, 0, 0, 412, 427, 438, 0, 0, 0, 0, + + 440, 0, 0, 0, 0, 436, 405, 447, 0, 0, + 0, 0, 438, 443, 922, 940, 921, 442, 450, 449, + 452, 454, 459, 458, 453, 469, 0, 0, 0, 0, + 920, 470, 481, 0, 483, 0, 484, 481, 919, 368, + 467, 495, 918, 940, 917, 940, 488, 916, 479, 490, + 492, 495, 505, 498, 940, 915, 940, 507, 523, 0, + 0, 0, 0, 940, 503, 864, 940, 846, 532, 836, + 0, 824, 940, 516, 796, 940, 513, 530, 536, 538, + 784, 940, 542, 535, 547, 772, 940, 549, 551, 768, + 940, 502, 562, 0, 564, 0, 0, 562, 764, 940, + + 544, 557, 760, 752, 744, 940, 552, 568, 571, 568, + 581, 577, 588, 0, 0, 0, 0, 589, 580, 591, + 736, 940, 728, 940, 601, 602, 597, 599, 940, 603, + 720, 712, 700, 672, 940, 665, 940, 610, 656, 603, + 648, 607, 629, 940, 627, 940, 625, 940, 624, 940, + 607, 574, 940, 614, 572, 940, 491, 940, 433, 940, + 940, 622, 389, 940, 303, 940, 261, 940, 204, 940, + 940, 635, 639, 642, 646, 650, 654, 658, 662, 666, + 670, 674, 678, 682, 686, 690, 694, 698, 702, 706, + 710, 714, 718, 722, 726, 730, 734, 738, 742, 746, + + 750, 754, 758, 762, 766, 770, 774, 778, 782, 786, + 790, 794, 798, 802, 806, 810, 814, 818, 822, 826, + 830, 834, 838, 842, 846, 850, 854, 858, 862, 866, + 870, 874, 878, 882, 886, 890, 894, 898, 902, 906, + 910, 914 } ; -static const flex_int16_t yy_def[424] = +static const flex_int16_t yy_def[443] = { 0, - 354, 1, 355, 355, 354, 356, 357, 357, 354, 354, - 358, 358, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 359, 354, 356, 354, - 360, 357, 361, 361, 362, 12, 356, 363, 12, 12, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, + 371, 1, 372, 372, 371, 373, 374, 374, 371, 371, + 375, 375, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 12, 12, 12, 376, 371, 373, 371, + 377, 374, 378, 378, 379, 12, 373, 380, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 359, 360, 361, 361, 364, 365, 365, 354, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 362, 12, 12, 12, 12, - 12, 12, 12, 364, 365, 365, 354, 12, 12, 366, - + 12, 12, 376, 377, 378, 378, 381, 382, 382, 371, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 367, 86, 86, 368, 12, 369, 12, 12, 370, - 12, 12, 12, 12, 12, 371, 372, 366, 372, 12, - 12, 354, 86, 12, 12, 12, 373, 12, 12, 12, - 374, 375, 367, 375, 86, 86, 376, 377, 368, 377, - 378, 379, 369, 379, 12, 380, 381, 370, 381, 12, - 12, 382, 12, 12, 371, 372, 372, 383, 383, 12, - 354, 86, 86, 86, 12, 12, 12, 384, 385, 373, - 385, 12, 12, 386, 374, 375, 375, 387, 387, 86, - 86, 376, 377, 377, 388, 388, 378, 379, 379, 389, - - 389, 12, 380, 381, 381, 390, 390, 12, 12, 391, - 354, 392, 86, 12, 86, 86, 86, 12, 86, 12, - 384, 385, 385, 393, 393, 394, 86, 395, 396, 386, - 396, 86, 86, 397, 12, 398, 391, 354, 399, 354, - 86, 400, 12, 86, 86, 86, 401, 86, 354, 402, - 354, 86, 395, 396, 396, 403, 403, 354, 86, 404, - 354, 405, 406, 406, 399, 354, 86, 407, 354, 12, - 86, 86, 86, 408, 354, 408, 408, 86, 402, 354, - 86, 86, 404, 354, 409, 410, 405, 410, 406, 86, - 407, 354, 12, 86, 411, 412, 408, 354, 408, 408, - - 86, 86, 86, 409, 410, 410, 413, 413, 86, 12, - 86, 414, 354, 415, 354, 408, 408, 86, 86, 354, - 416, 417, 418, 414, 354, 415, 354, 408, 408, 86, - 419, 420, 354, 421, 354, 422, 354, 408, 354, 86, - 423, 354, 420, 354, 421, 354, 422, 354, 354, 86, - 423, 354, 354, 0, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354 + 12, 12, 12, 12, 12, 12, 379, 12, 12, 12, + 12, 12, 12, 12, 12, 381, 382, 382, 371, 12, + + 12, 383, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 384, 87, 87, 385, 12, 386, 12, + 12, 12, 387, 12, 12, 12, 12, 12, 388, 389, + 383, 389, 12, 12, 371, 87, 12, 12, 12, 390, + 12, 12, 12, 391, 392, 384, 392, 87, 87, 393, + 394, 385, 394, 395, 396, 386, 396, 12, 12, 397, + 398, 387, 398, 12, 12, 399, 12, 12, 388, 389, + 389, 400, 400, 12, 371, 87, 87, 87, 12, 12, + 12, 401, 402, 390, 402, 12, 12, 403, 391, 392, + 392, 404, 404, 87, 87, 393, 394, 394, 405, 405, + + 395, 396, 396, 406, 406, 12, 12, 397, 398, 398, + 407, 407, 12, 12, 408, 371, 409, 87, 12, 87, + 87, 87, 12, 87, 12, 401, 402, 402, 410, 410, + 411, 87, 412, 413, 403, 413, 87, 87, 414, 12, + 12, 415, 408, 371, 416, 371, 87, 417, 12, 87, + 87, 87, 418, 87, 371, 419, 371, 87, 412, 413, + 413, 420, 420, 371, 87, 421, 371, 12, 422, 423, + 423, 416, 371, 87, 424, 371, 12, 87, 87, 87, + 425, 371, 425, 425, 87, 419, 371, 87, 87, 421, + 371, 12, 426, 427, 422, 427, 423, 87, 424, 371, + + 12, 87, 428, 429, 425, 371, 425, 425, 87, 87, + 87, 12, 426, 427, 427, 430, 430, 87, 12, 87, + 431, 371, 432, 371, 425, 425, 87, 87, 371, 12, + 433, 434, 435, 431, 371, 432, 371, 425, 425, 87, + 436, 12, 437, 371, 438, 371, 439, 371, 425, 371, + 87, 440, 371, 12, 437, 371, 438, 371, 439, 371, + 371, 87, 440, 371, 441, 371, 442, 371, 442, 371, + 0, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371 } ; -static const flex_int16_t yy_nxt[940] = +static const flex_int16_t yy_nxt[975] = { 0, 6, 7, 8, 9, 6, 6, 6, 6, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 17, 17, 17, 17, 20, 17, 21, 22, 23, 24, 25, 17, 26, 17, 17, 17, 32, 32, 33, 32, 32, 33, 36, 34, 36, 42, 34, 29, 29, 29, 30, 35, - 50, 36, 37, 38, 43, 44, 39, 36, 79, 45, + 50, 36, 37, 38, 43, 44, 39, 36, 80, 45, 36, 36, 40, 29, 29, 29, 30, 35, 46, 48, 37, 38, 41, 47, 36, 49, 36, 53, 36, 36, - 36, 56, 58, 36, 36, 55, 82, 60, 51, 342, - 54, 61, 52, 29, 64, 32, 32, 33, 36, 65, - - 70, 36, 34, 29, 29, 29, 30, 36, 36, 36, - 29, 38, 66, 66, 66, 67, 66, 71, 74, 66, - 68, 72, 36, 36, 73, 36, 77, 78, 36, 76, - 36, 53, 36, 36, 75, 85, 80, 83, 36, 86, - 84, 36, 36, 36, 36, 81, 36, 36, 36, 36, - 36, 36, 93, 89, 337, 98, 88, 29, 64, 101, - 90, 36, 91, 65, 92, 87, 29, 95, 89, 99, - 36, 100, 96, 36, 36, 36, 36, 36, 36, 106, - 105, 85, 36, 36, 102, 36, 107, 36, 103, 36, - 109, 112, 36, 36, 104, 108, 115, 110, 36, 117, - - 36, 36, 36, 335, 36, 36, 122, 111, 29, 29, - 29, 30, 118, 36, 116, 29, 38, 36, 36, 113, - 114, 119, 120, 123, 36, 29, 95, 121, 36, 134, - 131, 96, 130, 36, 125, 124, 126, 126, 66, 127, - 126, 132, 133, 126, 129, 333, 36, 36, 135, 137, - 36, 36, 36, 140, 139, 35, 35, 352, 36, 36, - 85, 141, 141, 66, 142, 141, 160, 145, 141, 144, - 35, 35, 89, 117, 155, 36, 146, 147, 147, 66, - 148, 147, 162, 36, 147, 150, 151, 151, 66, 152, - 151, 36, 36, 151, 154, 120, 161, 36, 156, 156, - - 66, 157, 156, 36, 36, 156, 159, 164, 171, 163, - 29, 166, 29, 168, 36, 36, 167, 170, 169, 35, - 35, 172, 36, 36, 173, 36, 213, 184, 36, 36, - 175, 36, 174, 29, 186, 212, 36, 349, 183, 187, - 177, 176, 178, 178, 66, 179, 178, 182, 348, 178, - 181, 29, 188, 35, 35, 35, 35, 189, 29, 193, - 29, 195, 190, 36, 194, 36, 196, 29, 198, 29, - 200, 191, 36, 199, 36, 201, 219, 29, 204, 29, - 206, 36, 202, 205, 209, 207, 29, 166, 36, 293, - 208, 214, 167, 35, 35, 35, 35, 35, 35, 36, - - 36, 36, 249, 218, 220, 29, 222, 216, 36, 217, - 235, 223, 29, 224, 215, 226, 36, 227, 225, 346, - 35, 35, 36, 228, 228, 66, 229, 228, 29, 186, - 228, 231, 232, 36, 187, 233, 35, 29, 193, 29, - 198, 234, 36, 194, 344, 199, 29, 204, 236, 36, - 35, 241, 205, 242, 36, 35, 35, 270, 35, 35, - 35, 35, 247, 36, 35, 35, 29, 222, 244, 262, - 248, 36, 223, 243, 245, 246, 35, 252, 29, 254, - 29, 256, 258, 342, 255, 259, 257, 35, 35, 339, - 35, 35, 69, 264, 35, 35, 35, 35, 35, 35, - - 267, 35, 35, 275, 35, 35, 35, 35, 271, 35, - 35, 276, 277, 35, 35, 272, 278, 315, 273, 281, - 29, 254, 290, 313, 282, 275, 255, 285, 285, 66, - 286, 285, 35, 35, 285, 288, 295, 298, 296, 35, - 35, 35, 35, 298, 301, 328, 299, 294, 35, 35, - 275, 35, 35, 35, 303, 29, 305, 300, 275, 29, - 307, 306, 35, 35, 302, 308, 337, 36, 35, 35, - 309, 310, 320, 316, 35, 35, 35, 35, 322, 36, - 35, 35, 317, 275, 319, 311, 29, 305, 335, 275, - 318, 321, 306, 323, 35, 35, 35, 35, 330, 329, - - 35, 35, 331, 333, 327, 35, 35, 338, 35, 35, - 353, 340, 35, 35, 350, 325, 275, 315, 35, 35, - 27, 27, 27, 27, 29, 29, 29, 31, 31, 31, - 31, 36, 36, 36, 36, 62, 313, 62, 62, 63, - 63, 63, 63, 65, 269, 65, 65, 35, 35, 35, - 35, 69, 69, 261, 69, 94, 94, 94, 94, 96, - 251, 96, 96, 128, 128, 128, 128, 143, 143, 143, - 143, 149, 149, 149, 149, 153, 153, 153, 153, 158, - 158, 158, 158, 165, 165, 165, 165, 167, 298, 167, - 167, 180, 180, 180, 180, 185, 185, 185, 185, 187, - - 292, 187, 187, 192, 192, 192, 192, 194, 240, 194, - 194, 197, 197, 197, 197, 199, 289, 199, 199, 203, - 203, 203, 203, 205, 284, 205, 205, 210, 210, 210, - 210, 169, 280, 169, 169, 221, 221, 221, 221, 223, - 269, 223, 223, 230, 230, 230, 230, 189, 266, 189, - 189, 196, 211, 196, 196, 201, 261, 201, 201, 207, - 251, 207, 207, 237, 237, 237, 237, 239, 239, 239, - 239, 225, 240, 225, 225, 250, 250, 250, 250, 253, - 253, 253, 253, 255, 238, 255, 255, 260, 260, 260, - 260, 263, 263, 263, 263, 265, 265, 265, 265, 268, - - 268, 268, 268, 274, 274, 274, 274, 279, 279, 279, - 279, 257, 211, 257, 257, 283, 283, 283, 283, 287, - 287, 287, 287, 264, 138, 264, 264, 291, 291, 291, - 291, 297, 297, 297, 297, 304, 304, 304, 304, 306, - 136, 306, 306, 312, 312, 312, 312, 314, 314, 314, - 314, 308, 97, 308, 308, 324, 324, 324, 324, 326, - 326, 326, 326, 332, 332, 332, 332, 334, 334, 334, - 334, 336, 336, 336, 336, 341, 341, 341, 341, 343, - 343, 343, 343, 345, 345, 345, 345, 347, 347, 347, - 347, 351, 351, 351, 351, 36, 30, 59, 57, 36, - - 30, 354, 28, 28, 5, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 36, 56, 58, 36, 36, 55, 83, 61, 51, 36, + 54, 62, 52, 29, 65, 59, 32, 32, 33, 66, + + 36, 36, 71, 34, 29, 29, 29, 30, 36, 36, + 77, 29, 38, 67, 67, 67, 68, 67, 75, 72, + 67, 69, 73, 36, 36, 74, 78, 79, 36, 53, + 36, 36, 36, 87, 36, 76, 84, 36, 36, 85, + 36, 81, 36, 86, 36, 36, 36, 36, 82, 36, + 92, 95, 36, 100, 36, 36, 89, 90, 88, 29, + 65, 36, 91, 101, 36, 66, 90, 93, 36, 94, + 29, 97, 102, 36, 36, 104, 98, 36, 103, 36, + 36, 107, 108, 106, 36, 36, 36, 105, 86, 36, + 109, 110, 111, 36, 36, 114, 112, 36, 117, 119, + + 36, 36, 36, 36, 36, 121, 36, 368, 36, 36, + 120, 113, 29, 29, 29, 30, 118, 36, 134, 29, + 38, 36, 127, 115, 116, 122, 123, 125, 36, 126, + 128, 124, 29, 97, 36, 36, 180, 138, 98, 129, + 129, 67, 130, 129, 36, 36, 129, 132, 133, 135, + 136, 140, 36, 36, 36, 36, 142, 36, 137, 35, + 35, 123, 86, 36, 370, 143, 144, 144, 67, 145, + 144, 148, 158, 144, 147, 35, 35, 90, 119, 36, + 36, 149, 150, 150, 67, 151, 150, 159, 36, 150, + 153, 154, 154, 67, 155, 154, 164, 36, 154, 157, + + 160, 160, 67, 161, 160, 36, 368, 160, 163, 165, + 166, 36, 36, 29, 170, 167, 168, 29, 172, 171, + 36, 175, 36, 173, 35, 35, 176, 36, 36, 177, + 36, 36, 188, 174, 36, 29, 190, 178, 36, 181, + 36, 191, 223, 179, 182, 182, 67, 183, 182, 186, + 206, 182, 185, 187, 29, 192, 35, 35, 35, 35, + 193, 29, 197, 29, 199, 194, 36, 198, 36, 200, + 29, 202, 29, 204, 195, 36, 203, 36, 205, 268, + 207, 29, 209, 29, 211, 214, 213, 210, 218, 212, + 217, 36, 353, 36, 29, 170, 36, 35, 35, 219, + + 171, 35, 35, 35, 35, 224, 36, 231, 36, 225, + 36, 29, 227, 221, 36, 222, 232, 228, 220, 29, + 229, 36, 240, 35, 35, 230, 233, 233, 67, 234, + 233, 29, 190, 233, 236, 237, 348, 191, 238, 35, + 29, 197, 29, 202, 239, 36, 198, 36, 203, 29, + 209, 242, 36, 35, 247, 210, 255, 241, 248, 36, + 35, 35, 36, 35, 35, 35, 35, 253, 36, 35, + 35, 29, 227, 250, 269, 254, 36, 228, 249, 251, + 252, 35, 258, 29, 260, 29, 262, 264, 36, 261, + 265, 263, 35, 35, 346, 35, 35, 70, 271, 35, + + 35, 35, 35, 35, 35, 274, 35, 35, 282, 35, + 35, 36, 277, 278, 35, 35, 283, 284, 35, 35, + 279, 285, 36, 280, 288, 29, 260, 35, 35, 289, + 312, 261, 293, 293, 67, 294, 293, 301, 306, 293, + 296, 35, 35, 298, 303, 306, 304, 35, 35, 35, + 35, 309, 308, 36, 307, 282, 302, 319, 35, 35, + 35, 35, 35, 311, 29, 314, 29, 316, 35, 35, + 315, 282, 317, 35, 35, 344, 310, 364, 325, 35, + 35, 318, 35, 35, 329, 320, 36, 328, 332, 36, + 29, 314, 35, 35, 330, 326, 315, 331, 327, 333, + + 35, 35, 35, 35, 282, 282, 340, 341, 35, 35, + 35, 35, 36, 282, 35, 35, 36, 351, 35, 35, + 362, 339, 365, 36, 338, 366, 342, 361, 360, 354, + 358, 349, 356, 35, 35, 27, 27, 27, 27, 29, + 29, 29, 31, 31, 31, 31, 36, 36, 36, 36, + 63, 353, 63, 63, 64, 64, 64, 64, 66, 350, + 66, 66, 35, 35, 35, 35, 70, 70, 324, 70, + 96, 96, 96, 96, 98, 322, 98, 98, 131, 131, + 131, 131, 146, 146, 146, 146, 152, 152, 152, 152, + 156, 156, 156, 156, 162, 162, 162, 162, 169, 169, + + 169, 169, 171, 348, 171, 171, 184, 184, 184, 184, + 189, 189, 189, 189, 191, 346, 191, 191, 196, 196, + 196, 196, 198, 344, 198, 198, 201, 201, 201, 201, + 203, 337, 203, 203, 208, 208, 208, 208, 210, 335, + 210, 210, 215, 215, 215, 215, 173, 282, 173, 173, + 226, 226, 226, 226, 228, 324, 228, 228, 235, 235, + 235, 235, 193, 322, 193, 193, 200, 276, 200, 200, + 205, 267, 205, 205, 212, 257, 212, 212, 243, 243, + 243, 243, 245, 245, 245, 245, 230, 306, 230, 230, + 256, 256, 256, 256, 259, 259, 259, 259, 261, 300, + + 261, 261, 266, 266, 266, 266, 270, 270, 270, 270, + 272, 272, 272, 272, 275, 275, 275, 275, 281, 281, + 281, 281, 286, 286, 286, 286, 263, 246, 263, 263, + 290, 290, 290, 290, 295, 295, 295, 295, 271, 297, + 271, 271, 299, 299, 299, 299, 305, 305, 305, 305, + 313, 313, 313, 313, 315, 292, 315, 315, 321, 321, + 321, 321, 323, 323, 323, 323, 317, 291, 317, 317, + 334, 334, 334, 334, 336, 336, 336, 336, 343, 343, + 343, 343, 345, 345, 345, 345, 347, 347, 347, 347, + 352, 352, 352, 352, 355, 355, 355, 355, 357, 357, + + 357, 357, 359, 359, 359, 359, 363, 363, 363, 363, + 367, 367, 367, 367, 369, 369, 369, 369, 287, 276, + 273, 216, 267, 257, 246, 244, 216, 141, 139, 99, + 36, 30, 60, 57, 36, 30, 371, 28, 28, 5, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; -static const flex_int16_t yy_chk[940] = +static const flex_int16_t yy_chk[975] = { 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, @@ -927,101 +940,105 @@ static const flex_int16_t yy_chk[940] = 18, 14, 11, 11, 13, 14, 11, 46, 46, 14, 15, 16, 11, 12, 12, 12, 12, 12, 14, 16, 12, 12, 12, 15, 19, 16, 20, 20, 21, 22, - 24, 22, 24, 50, 26, 21, 50, 26, 19, 351, - 20, 26, 19, 31, 31, 32, 32, 32, 39, 31, - - 39, 42, 32, 35, 35, 35, 35, 40, 44, 45, - 35, 35, 37, 37, 37, 37, 37, 39, 42, 37, - 37, 40, 41, 43, 41, 48, 45, 45, 49, 44, - 47, 47, 53, 51, 43, 53, 48, 51, 52, 54, - 52, 55, 56, 58, 54, 49, 57, 59, 60, 73, - 61, 70, 60, 61, 347, 70, 56, 63, 63, 73, - 58, 71, 59, 63, 59, 55, 66, 66, 57, 71, - 74, 72, 66, 72, 75, 76, 77, 78, 79, 78, - 77, 79, 80, 81, 74, 83, 80, 82, 75, 84, - 82, 85, 88, 85, 76, 81, 87, 83, 87, 89, - - 92, 89, 93, 345, 90, 104, 92, 84, 86, 86, - 86, 86, 90, 99, 88, 86, 86, 98, 102, 86, - 86, 91, 91, 93, 91, 94, 94, 91, 101, 104, - 102, 94, 101, 110, 99, 98, 100, 100, 100, 100, - 100, 103, 103, 100, 100, 343, 105, 103, 105, 107, - 109, 107, 111, 110, 109, 113, 113, 341, 121, 118, - 111, 112, 112, 112, 112, 112, 121, 113, 112, 112, - 114, 114, 116, 116, 118, 116, 114, 115, 115, 115, - 115, 115, 123, 123, 115, 115, 117, 117, 117, 117, - 117, 124, 122, 117, 117, 119, 122, 119, 120, 120, - - 120, 120, 120, 125, 130, 120, 120, 125, 131, 124, - 126, 126, 128, 128, 131, 134, 126, 130, 128, 133, - 133, 133, 135, 136, 133, 139, 164, 140, 138, 140, - 134, 164, 133, 141, 141, 163, 163, 338, 139, 141, - 136, 135, 137, 137, 137, 137, 137, 138, 336, 137, - 137, 143, 143, 145, 145, 146, 146, 143, 147, 147, - 149, 149, 145, 155, 147, 161, 149, 151, 151, 153, - 153, 146, 160, 151, 270, 153, 176, 156, 156, 158, - 158, 176, 155, 156, 161, 158, 165, 165, 170, 270, - 160, 170, 165, 172, 172, 173, 173, 174, 174, 175, - - 208, 177, 220, 175, 177, 178, 178, 173, 220, 174, - 208, 178, 180, 180, 172, 182, 182, 183, 180, 334, - 190, 190, 183, 184, 184, 184, 184, 184, 185, 185, - 184, 184, 190, 243, 185, 191, 191, 192, 192, 197, - 197, 202, 202, 192, 332, 197, 203, 203, 209, 209, - 213, 213, 203, 214, 214, 215, 215, 243, 216, 216, - 217, 217, 218, 218, 219, 219, 221, 221, 215, 235, - 219, 235, 221, 214, 216, 217, 227, 227, 228, 228, - 230, 230, 232, 331, 228, 233, 230, 233, 233, 329, - 232, 232, 236, 236, 241, 241, 244, 244, 245, 245, - - 241, 246, 246, 247, 248, 248, 267, 267, 244, 259, - 259, 247, 247, 252, 252, 245, 248, 326, 246, 252, - 253, 253, 267, 324, 259, 316, 253, 262, 262, 262, - 262, 262, 271, 271, 262, 262, 272, 276, 273, 272, - 272, 273, 273, 277, 278, 316, 276, 271, 281, 281, - 299, 278, 278, 282, 282, 285, 285, 277, 300, 287, - 287, 285, 290, 290, 281, 287, 323, 293, 294, 294, - 290, 293, 303, 299, 301, 301, 302, 302, 310, 310, - 303, 303, 300, 317, 302, 294, 304, 304, 322, 328, - 301, 309, 304, 311, 309, 309, 311, 311, 318, 317, - - 318, 318, 319, 321, 314, 319, 319, 328, 330, 330, - 350, 330, 340, 340, 340, 312, 297, 296, 350, 350, - 355, 355, 355, 355, 356, 356, 356, 357, 357, 357, - 357, 358, 358, 358, 358, 359, 295, 359, 359, 360, - 360, 360, 360, 361, 291, 361, 361, 362, 362, 362, - 362, 363, 363, 283, 363, 364, 364, 364, 364, 365, - 279, 365, 365, 366, 366, 366, 366, 367, 367, 367, - 367, 368, 368, 368, 368, 369, 369, 369, 369, 370, - 370, 370, 370, 371, 371, 371, 371, 372, 274, 372, - 372, 373, 373, 373, 373, 374, 374, 374, 374, 375, - - 268, 375, 375, 376, 376, 376, 376, 377, 265, 377, - 377, 378, 378, 378, 378, 379, 263, 379, 379, 380, - 380, 380, 380, 381, 260, 381, 381, 382, 382, 382, - 382, 383, 250, 383, 383, 384, 384, 384, 384, 385, - 242, 385, 385, 386, 386, 386, 386, 387, 239, 387, - 387, 388, 237, 388, 388, 389, 234, 389, 389, 390, - 226, 390, 390, 391, 391, 391, 391, 392, 392, 392, - 392, 393, 212, 393, 393, 394, 394, 394, 394, 395, - 395, 395, 395, 396, 210, 396, 396, 397, 397, 397, - 397, 398, 398, 398, 398, 399, 399, 399, 399, 400, - - 400, 400, 400, 401, 401, 401, 401, 402, 402, 402, - 402, 403, 162, 403, 403, 404, 404, 404, 404, 405, - 405, 405, 405, 406, 108, 406, 406, 407, 407, 407, - 407, 408, 408, 408, 408, 409, 409, 409, 409, 410, - 106, 410, 410, 411, 411, 411, 411, 412, 412, 412, - 412, 413, 69, 413, 413, 414, 414, 414, 414, 415, - 415, 415, 415, 416, 416, 416, 416, 417, 417, 417, - 417, 418, 418, 418, 418, 419, 419, 419, 419, 420, - 420, 420, 420, 421, 421, 421, 421, 422, 422, 422, - 422, 423, 423, 423, 423, 36, 29, 25, 23, 17, - - 6, 5, 4, 3, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 24, 22, 24, 50, 26, 21, 50, 26, 19, 44, + 20, 26, 19, 31, 31, 24, 32, 32, 32, 31, + + 39, 42, 39, 32, 35, 35, 35, 35, 40, 45, + 44, 35, 35, 37, 37, 37, 37, 37, 42, 39, + 37, 37, 40, 41, 43, 41, 45, 45, 47, 47, + 48, 49, 51, 54, 55, 43, 51, 52, 54, 52, + 53, 48, 56, 53, 57, 58, 59, 61, 49, 71, + 59, 61, 60, 71, 62, 72, 56, 62, 55, 64, + 64, 75, 58, 72, 77, 64, 57, 60, 74, 60, + 67, 67, 73, 76, 73, 75, 67, 78, 74, 82, + 79, 78, 79, 77, 84, 80, 81, 76, 80, 83, + 81, 82, 83, 85, 89, 86, 84, 86, 88, 90, + + 88, 90, 91, 92, 100, 92, 104, 369, 95, 101, + 91, 85, 87, 87, 87, 87, 89, 138, 104, 87, + 87, 94, 100, 87, 87, 93, 93, 94, 93, 95, + 101, 93, 96, 96, 106, 107, 138, 107, 96, 102, + 102, 102, 102, 102, 103, 112, 102, 102, 103, 105, + 105, 109, 111, 109, 113, 105, 111, 120, 106, 115, + 115, 122, 113, 122, 367, 112, 114, 114, 114, 114, + 114, 115, 120, 114, 114, 116, 116, 118, 118, 121, + 118, 116, 117, 117, 117, 117, 117, 121, 124, 117, + 117, 119, 119, 119, 119, 119, 124, 127, 119, 119, + + 123, 123, 123, 123, 123, 125, 365, 123, 123, 125, + 126, 126, 128, 129, 129, 127, 128, 131, 131, 129, + 133, 134, 139, 131, 136, 136, 136, 134, 137, 136, + 141, 158, 143, 133, 143, 144, 144, 136, 179, 139, + 142, 144, 179, 137, 140, 140, 140, 140, 140, 141, + 158, 140, 140, 142, 146, 146, 148, 148, 149, 149, + 146, 150, 150, 152, 152, 148, 165, 150, 164, 152, + 154, 154, 156, 156, 149, 159, 154, 240, 156, 240, + 159, 160, 160, 162, 162, 165, 164, 160, 168, 162, + 167, 167, 363, 168, 169, 169, 174, 176, 176, 174, + + 169, 177, 177, 178, 178, 180, 181, 186, 186, 181, + 180, 182, 182, 177, 207, 178, 187, 182, 176, 184, + 184, 187, 207, 194, 194, 184, 188, 188, 188, 188, + 188, 189, 189, 188, 188, 194, 359, 189, 195, 195, + 196, 196, 201, 201, 206, 206, 196, 213, 201, 208, + 208, 214, 214, 218, 218, 208, 225, 213, 219, 219, + 220, 220, 225, 221, 221, 222, 222, 223, 223, 224, + 224, 226, 226, 220, 241, 224, 241, 226, 219, 221, + 222, 232, 232, 233, 233, 235, 235, 237, 249, 233, + 238, 235, 238, 238, 357, 237, 237, 242, 242, 247, + + 247, 250, 250, 251, 251, 247, 252, 252, 253, 254, + 254, 292, 249, 250, 265, 265, 253, 253, 258, 258, + 251, 254, 277, 252, 258, 259, 259, 274, 274, 265, + 292, 259, 269, 269, 269, 269, 269, 277, 284, 269, + 269, 278, 278, 274, 279, 283, 280, 279, 279, 280, + 280, 285, 284, 301, 283, 307, 278, 301, 285, 285, + 288, 288, 289, 289, 293, 293, 295, 295, 302, 302, + 293, 308, 295, 298, 298, 355, 288, 352, 307, 310, + 310, 298, 309, 309, 311, 302, 312, 310, 319, 319, + 313, 313, 311, 311, 312, 308, 313, 318, 309, 320, + + 318, 318, 320, 320, 325, 326, 327, 328, 327, 327, + 328, 328, 330, 338, 340, 340, 342, 340, 351, 351, + 351, 326, 354, 354, 325, 362, 330, 349, 347, 342, + 345, 338, 343, 362, 362, 372, 372, 372, 372, 373, + 373, 373, 374, 374, 374, 374, 375, 375, 375, 375, + 376, 341, 376, 376, 377, 377, 377, 377, 378, 339, + 378, 378, 379, 379, 379, 379, 380, 380, 336, 380, + 381, 381, 381, 381, 382, 334, 382, 382, 383, 383, + 383, 383, 384, 384, 384, 384, 385, 385, 385, 385, + 386, 386, 386, 386, 387, 387, 387, 387, 388, 388, + + 388, 388, 389, 333, 389, 389, 390, 390, 390, 390, + 391, 391, 391, 391, 392, 332, 392, 392, 393, 393, + 393, 393, 394, 331, 394, 394, 395, 395, 395, 395, + 396, 323, 396, 396, 397, 397, 397, 397, 398, 321, + 398, 398, 399, 399, 399, 399, 400, 305, 400, 400, + 401, 401, 401, 401, 402, 304, 402, 402, 403, 403, + 403, 403, 404, 303, 404, 404, 405, 299, 405, 405, + 406, 290, 406, 406, 407, 286, 407, 407, 408, 408, + 408, 408, 409, 409, 409, 409, 410, 281, 410, 410, + 411, 411, 411, 411, 412, 412, 412, 412, 413, 275, + + 413, 413, 414, 414, 414, 414, 415, 415, 415, 415, + 416, 416, 416, 416, 417, 417, 417, 417, 418, 418, + 418, 418, 419, 419, 419, 419, 420, 272, 420, 420, + 421, 421, 421, 421, 422, 422, 422, 422, 423, 270, + 423, 423, 424, 424, 424, 424, 425, 425, 425, 425, + 426, 426, 426, 426, 427, 268, 427, 427, 428, 428, + 428, 428, 429, 429, 429, 429, 430, 266, 430, 430, + 431, 431, 431, 431, 432, 432, 432, 432, 433, 433, + 433, 433, 434, 434, 434, 434, 435, 435, 435, 435, + 436, 436, 436, 436, 437, 437, 437, 437, 438, 438, + + 438, 438, 439, 439, 439, 439, 440, 440, 440, 440, + 441, 441, 441, 441, 442, 442, 442, 442, 256, 248, + 245, 243, 239, 231, 217, 215, 166, 110, 108, 70, + 36, 29, 25, 23, 17, 6, 5, 4, 3, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; #define YY_TRAILING_MASK 0x2000 @@ -1160,9 +1177,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"standalone")) DSET(dpc,backend,BACKEND,str,STANDALONE); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -1199,9 +1224,9 @@ static int vdev_and_devtype(DiskParseContext *dpc, char *str) { #undef DPC /* needs to be defined differently the actual lexer */ #define DPC ((DiskParseContext*)yyextra) -#line 1202 "libxlu_disk_l.c" +#line 1227 "libxlu_disk_l.c" -#line 1204 "libxlu_disk_l.c" +#line 1229 "libxlu_disk_l.c" #define INITIAL 0 #define LEXERR 1 @@ -1477,13 +1502,13 @@ YY_DECL } { -#line 177 "libxlu_disk_l.l" +#line 185 "libxlu_disk_l.l" -#line 180 "libxlu_disk_l.l" +#line 188 "libxlu_disk_l.l" /*----- the scanner rules which do the parsing -----*/ -#line 1486 "libxlu_disk_l.c" +#line 1511 "libxlu_disk_l.c" while ( /*CONSTCOND*/1 ) /* loops until end-of-file is reached */ { @@ -1515,14 +1540,14 @@ yy_match: while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; *yyg->yy_state_ptr++ = yy_current_state; ++yy_cp; } - while ( yy_current_state != 354 ); + while ( yy_current_state != 371 ); yy_find_action: yy_current_state = *--yyg->yy_state_ptr; @@ -1572,152 +1597,158 @@ do_action: /* This label is used only to access EOF actions. */ case 1: /* rule 1 can match eol */ YY_RULE_SETUP -#line 182 "libxlu_disk_l.l" +#line 190 "libxlu_disk_l.l" { /* ignore whitespace before parameters */ } YY_BREAK /* ordinary parameters setting enums or strings */ case 2: /* rule 2 can match eol */ YY_RULE_SETUP -#line 186 "libxlu_disk_l.l" +#line 194 "libxlu_disk_l.l" { STRIP(','); setformat(DPC, FROMEQUALS); } YY_BREAK case 3: YY_RULE_SETUP -#line 188 "libxlu_disk_l.l" +#line 196 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 4: YY_RULE_SETUP -#line 189 "libxlu_disk_l.l" +#line 197 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 5: YY_RULE_SETUP -#line 190 "libxlu_disk_l.l" +#line 198 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 0; } YY_BREAK case 6: /* rule 6 can match eol */ YY_RULE_SETUP -#line 191 "libxlu_disk_l.l" +#line 199 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown value for type"); } YY_BREAK case 7: /* rule 7 can match eol */ YY_RULE_SETUP -#line 193 "libxlu_disk_l.l" +#line 201 "libxlu_disk_l.l" { STRIP(','); setaccess(DPC, FROMEQUALS); } YY_BREAK case 8: /* rule 8 can match eol */ YY_RULE_SETUP -#line 194 "libxlu_disk_l.l" +#line 202 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } YY_BREAK case 9: /* rule 9 can match eol */ YY_RULE_SETUP -#line 195 "libxlu_disk_l.l" +#line 203 "libxlu_disk_l.l" { STRIP(','); setbackendtype(DPC,FROMEQUALS); } YY_BREAK case 10: /* rule 10 can match eol */ YY_RULE_SETUP -#line 197 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } +#line 204 "libxlu_disk_l.l" +{ STRIP(','); setspecification(DPC,FROMEQUALS); } YY_BREAK case 11: /* rule 11 can match eol */ YY_RULE_SETUP -#line 198 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } +#line 206 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } YY_BREAK case 12: +/* rule 12 can match eol */ YY_RULE_SETUP -#line 199 "libxlu_disk_l.l" -{ DPC->disk->direct_io_safe = 1; } +#line 207 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } YY_BREAK case 13: YY_RULE_SETUP -#line 200 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, true); } +#line 208 "libxlu_disk_l.l" +{ DPC->disk->direct_io_safe = 1; } YY_BREAK case 14: YY_RULE_SETUP -#line 201 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, false); } +#line 209 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, true); } YY_BREAK -/* Note that the COLO configuration settings should be considered unstable. - * They may change incompatibly in future versions of Xen. */ case 15: YY_RULE_SETUP -#line 204 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, true); } +#line 210 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, false); } YY_BREAK +/* Note that the COLO configuration settings should be considered unstable. + * They may change incompatibly in future versions of Xen. */ case 16: YY_RULE_SETUP -#line 205 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, false); } +#line 213 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, true); } YY_BREAK case 17: -/* rule 17 can match eol */ YY_RULE_SETUP -#line 206 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } +#line 214 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, false); } YY_BREAK case 18: /* rule 18 can match eol */ YY_RULE_SETUP -#line 207 "libxlu_disk_l.l" -{ STRIP(','); setcoloport(DPC, FROMEQUALS); } +#line 215 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } YY_BREAK case 19: /* rule 19 can match eol */ YY_RULE_SETUP -#line 208 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } +#line 216 "libxlu_disk_l.l" +{ STRIP(','); setcoloport(DPC, FROMEQUALS); } YY_BREAK case 20: /* rule 20 can match eol */ YY_RULE_SETUP -#line 209 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } +#line 217 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } YY_BREAK case 21: /* rule 21 can match eol */ YY_RULE_SETUP -#line 210 "libxlu_disk_l.l" +#line 218 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } + YY_BREAK +case 22: +/* rule 22 can match eol */ +YY_RULE_SETUP +#line 219 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); } YY_BREAK /* the target magic parameter, eats the rest of the string */ -case 22: +case 23: YY_RULE_SETUP -#line 214 "libxlu_disk_l.l" +#line 223 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); } YY_BREAK /* unknown parameters */ -case 23: -/* rule 23 can match eol */ +case 24: +/* rule 24 can match eol */ YY_RULE_SETUP -#line 218 "libxlu_disk_l.l" +#line 227 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown parameter"); } YY_BREAK /* deprecated prefixes */ /* the "/.*" in these patterns ensures that they count as if they * matched the whole string, so these patterns take precedence */ -case 24: +case 25: YY_RULE_SETUP -#line 225 "libxlu_disk_l.l" +#line 234 "libxlu_disk_l.l" { STRIP(':'); DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'"); setformat(DPC, yytext); } YY_BREAK -case 25: +case 26: YY_RULE_SETUP -#line 231 "libxlu_disk_l.l" +#line 240 "libxlu_disk_l.l" { char *newscript; STRIP(':'); @@ -1731,65 +1762,65 @@ YY_RULE_SETUP free(newscript); } YY_BREAK -case 26: +case 27: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 8; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 244 "libxlu_disk_l.l" +#line 253 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 27: +case 28: YY_RULE_SETUP -#line 245 "libxlu_disk_l.l" +#line 254 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 28: +case 29: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 246 "libxlu_disk_l.l" +#line 255 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 29: +case 30: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 6; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 247 "libxlu_disk_l.l" +#line 256 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 30: +case 31: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 5; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 248 "libxlu_disk_l.l" +#line 257 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 31: +case 32: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 249 "libxlu_disk_l.l" +#line 258 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 32: -/* rule 32 can match eol */ +case 33: +/* rule 33 can match eol */ YY_RULE_SETUP -#line 251 "libxlu_disk_l.l" +#line 260 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix"); return 0; } YY_BREAK /* positional parameters */ -case 33: -/* rule 33 can match eol */ +case 34: +/* rule 34 can match eol */ YY_RULE_SETUP -#line 258 "libxlu_disk_l.l" +#line 267 "libxlu_disk_l.l" { STRIP(','); @@ -1816,27 +1847,27 @@ YY_RULE_SETUP } } YY_BREAK -case 34: +case 35: YY_RULE_SETUP -#line 284 "libxlu_disk_l.l" +#line 293 "libxlu_disk_l.l" { BEGIN(LEXERR); yymore(); } YY_BREAK -case 35: +case 36: YY_RULE_SETUP -#line 288 "libxlu_disk_l.l" +#line 297 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0; } YY_BREAK -case 36: +case 37: YY_RULE_SETUP -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" YY_FATAL_ERROR( "flex scanner jammed" ); YY_BREAK -#line 1839 "libxlu_disk_l.c" +#line 1870 "libxlu_disk_l.c" case YY_STATE_EOF(INITIAL): case YY_STATE_EOF(LEXERR): yyterminate(); @@ -2104,7 +2135,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; @@ -2128,11 +2159,11 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - yy_is_jam = (yy_current_state == 354); + yy_is_jam = (yy_current_state == 371); if ( ! yy_is_jam ) *yyg->yy_state_ptr++ = yy_current_state; @@ -2941,4 +2972,4 @@ void yyfree (void * ptr , yyscan_t yyscanner) #define YYTABLES_NAME "yytables" -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h index 6abeecf279..509aad67dc 100644 --- a/tools/libs/util/libxlu_disk_l.h +++ b/tools/libs/util/libxlu_disk_l.h @@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner); #undef yyTABLES_NAME #endif -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" #line 699 "libxlu_disk_l.h" #undef xlu__disk_yyIN_HEADER diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_disk_l.l index 3bd639aab0..c3617f1263 100644 --- a/tools/libs/util/libxlu_disk_l.l +++ b/tools/libs/util/libxlu_disk_l.l @@ -122,9 +122,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"standalone")) DSET(dpc,backend,BACKEND,str,STANDALONE); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -192,6 +200,7 @@ devtype=[^,]*,? { xlu__disk_err(DPC,yytext,"unknown value for type"); } access=[^,]*,? { STRIP(','); setaccess(DPC, FROMEQUALS); } backend=[^,]*,? { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); } +specification=[^,]*,? { STRIP(','); setspecification(DPC,FROMEQUALS); } vdev=[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } script=[^,]*,? { STRIP(','); SAVESTRING("script", script, FROMEQUALS); } diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c index 70eed431e4..8836c07d6b 100644 --- a/tools/xl/xl_block.c +++ b/tools/xl/xl_block.c @@ -119,6 +119,12 @@ int main_blockdetach(int argc, char **argv) fprintf(stderr, "Error: Device %s not connected.\n", argv[optind+1]); return 1; } + + if (disk.specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + fprintf(stderr, "Hotunplug isn't supported for specification virtio\n"); + return 1; + } + rc = !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) : libxl_device_disk_destroy(ctx, domid, &disk, 0); if (rc) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:25:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:25:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368544.599882 (Exim 4.92) (envelope-from ) id 1oCQw9-0002IS-89; Fri, 15 Jul 2022 19:25:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368544.599882; Fri, 15 Jul 2022 19:25:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQw9-0002IL-5C; Fri, 15 Jul 2022 19:25:17 +0000 Received: by outflank-mailman (input) for mailman id 368544; Fri, 15 Jul 2022 19:25:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQw8-0002IF-Bg for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:25:16 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCQw7-0003pP-CQ; Fri, 15 Jul 2022 19:25:15 +0000 Received: from [54.239.6.188] (helo=[192.168.17.116]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCQw7-0006iq-32; Fri, 15 Jul 2022 19:25:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=SroAn5sAyGZPK89dB+xgyIVv186RoJ/iI00k8W+Fk+k=; b=AKC0fzu4mtvgCOYj4/AjiXEZHd TVhwoqrUHXEk/CIEDWeRtFlTbfcEqpuoMOy5gi+Qc31A6e0+TSd8rCTgRI2lBy0aYzPsOlFN/jBdQ u1iLpIUdqGD5hlafrebWZ9dDR3ehs+mWPm8p4+BCsfnLdTIfJJKWPCO9lvygIF7IyiSk=; Message-ID: Date: Fri, 15 Jul 2022 20:25:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 02/18] introduction of generalized boot info To: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Stefano Stabellini References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> From: Julien Grall In-Reply-To: <20220706210454.30096-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 06/07/2022 22:04, Daniel P. Smith wrote: > The x86 and Arm architectures represent in memory the general boot information > and boot modules differently despite having commonality. The x86 > representations are bound to the multiboot v1 structures while the Arm > representations are a slightly generalized meta-data container for the boot > material. The multiboot structure does not lend itself well to being expanded > to accommodate additional metadata, both general and boot module specific. The > Arm structures are not bound to an external specification and thus are able to > be expanded for solutions such as dom0less. > > This commit introduces a set of structures patterned off the Arm structures to > represent the boot information in a manner that captures common data. The > structures provide an arch field to allow arch specific expansions to the > structures. The intended goal of these new common structures is to enable > commonality between the different architectures.  Specifically to enable > dom0less and hyperlaunch to have a common representation of boot-time > constructed domains. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark > --- > xen/arch/x86/include/asm/bootinfo.h | 48 +++++++++++++++++++++++++ > xen/include/xen/bootinfo.h | 54 +++++++++++++++++++++++++++++ > 2 files changed, 102 insertions(+) > create mode 100644 xen/arch/x86/include/asm/bootinfo.h > create mode 100644 xen/include/xen/bootinfo.h > > diff --git a/xen/arch/x86/include/asm/bootinfo.h b/xen/arch/x86/include/asm/bootinfo.h > new file mode 100644 > index 0000000000..b0754a3ed0 > --- /dev/null > +++ b/xen/arch/x86/include/asm/bootinfo.h > @@ -0,0 +1,48 @@ > +#ifndef __ARCH_X86_BOOTINFO_H__ > +#define __ARCH_X86_BOOTINFO_H__ > + > +/* unused for x86 */ > +struct arch_bootstring { }; > + > +struct __packed arch_bootmodule { > +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 > + uint32_t flags; > + uint32_t headroom; > +}; > + > +struct __packed arch_boot_info { > + uint32_t flags; > +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 > +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 > +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 > +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 > +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 > +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 > +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 > +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 > +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 > +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 > +#define BOOTINFO_FLAG_X86_APM 1U << 10 > + > + bool xen_guest; > + > + char *boot_loader_name; > + char *kextra; > + > + uint32_t mem_lower; > + uint32_t mem_upper; > + > + uint32_t mmap_length; > + paddr_t mmap_addr; > +}; > + > +struct __packed mb_memmap { > + uint32_t size; > + uint32_t base_addr_low; > + uint32_t base_addr_high; > + uint32_t length_low; > + uint32_t length_high; > + uint32_t type; > +}; > + > +#endif NIT: Missing emacs magics. > diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h > new file mode 100644 > index 0000000000..42b53a3ca6 > --- /dev/null > +++ b/xen/include/xen/bootinfo.h > @@ -0,0 +1,54 @@ > +#ifndef __XEN_BOOTINFO_H__ > +#define __XEN_BOOTINFO_H__ > + > +#include > +#include > + > +#include > + > +typedef enum { > + BOOTMOD_UNKNOWN, > + BOOTMOD_XEN, > + BOOTMOD_FDT, > + BOOTMOD_KERNEL, > + BOOTMOD_RAMDISK, > + BOOTMOD_XSM, > + BOOTMOD_UCODE, > + BOOTMOD_GUEST_DTB, > +} bootmodule_kind; > + > +typedef enum { > + BOOTSTR_EMPTY, > + BOOTSTR_STRING, > + BOOTSTR_CMDLINE, > +} bootstring_kind; > + > +#define BOOTMOD_MAX_STRING 1024 > +struct __packed boot_string { As you use __packed, the fields... > + bootstring_kind kind; > + struct arch_bootstring *arch; ... may not be naturally aligned anymore. Here it will depend on the size of bootstring_kind (this is an enum and it don't think C guarantees the size). This... > + > + char bytes[BOOTMOD_MAX_STRING]; > + size_t len; > +}; > + > +struct __packed boot_module { > + bootmodule_kind kind; > + paddr_t start; > + mfn_t mfn; > + size_t size; > + > + struct arch_bootmodule *arch; > + struct boot_string string; > +}; > + > +struct __packed boot_info { > + char *cmdline; > + > + uint32_t nr_mods; > + struct boot_module *mods; ... more obvious on this one because on 64-bit arch, there will be no 32-bit padding. So 'mods' will be 32-bit aligned even if the value 64-bit. This is going to be a problem on any architecture that forbid unaligned access (or let the software decide). In this case, I don't think any structures you defined warrant to be __packed. > + > + struct arch_boot_info *arch; > +}; > + > +#endif NIT: Missing emacs magics. -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 15 19:55:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 19:55:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368551.599893 (Exim 4.92) (envelope-from ) id 1oCRPB-0006aM-Jn; Fri, 15 Jul 2022 19:55:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368551.599893; Fri, 15 Jul 2022 19:55:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCRPB-0006aF-GX; Fri, 15 Jul 2022 19:55:17 +0000 Received: by outflank-mailman (input) for mailman id 368551; Fri, 15 Jul 2022 19:55:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCRPA-0006a9-Gx for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 19:55:16 +0000 Received: from sonic302-49.consmr.mail.gq1.yahoo.com (sonic302-49.consmr.mail.gq1.yahoo.com [98.137.68.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07eb9bd0-0478-11ed-924f-1f966e50362f; Fri, 15 Jul 2022 21:55:11 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.gq1.yahoo.com with HTTP; Fri, 15 Jul 2022 19:55:08 +0000 Received: by hermes--production-bf1-58957fb66f-6z4lk (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 967fca0f97858552404598730ce034c7; Fri, 15 Jul 2022 19:53:06 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07eb9bd0-0478-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657914908; bh=rTI2DdUsIF+W6MCmovjAWoU956VYoKdj5S83w2EQfWg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=HOxJ+n4eERsCK3x24RUH8IJ+tcaOkGSSrcbJsci9IOGdlzo53BwSF9zS7HXjvB5gOBfKwJ9LDwuTCwlMhOkiHed5HMJC2hQk1alOAxtsEoo794q/B+JOej5zLimZG2GMJnu6P2x2R39tc1hXuBSh5MZNAdbJeZnGQ+4it/1fXWmKGwi8gxBeMLhweqGOra0sJ0RDcLyCYCkULg8RS5kGq5umHn0xMKnexFUbschAop8/97ezmCzuVONYEjLZIumaHdTorOegXBjMxMrVG4gzw61++ZS/I+7+lUeIL21ffuJgsA/9m8q4U7VtsAdQjv/+aASK6eX1GzxjGtgdnY1Ssg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657914908; bh=lCZp2eusSTQ4jHMhLVc2F13HbYW5HTXHXZK4DpR462L=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=A0FDR+bF9cz9mvEzs3cLzHLUjWoUYsJpg0n8mHNpJL5IEaA7iw5iZn6Qrg5hPZxRuzpqomyTRHWScFqcLIorAXcMuFtDsFSfPA9ds1Kr4LxUDDloZL8twaaHAbYCNneQyaMCUKKYSq3X5MOuua4WsVk2C/SFfNUfLogc1DWkTRGTjeLWeY8uRpsK2FYF9EbSY5ZOLd+4/1k0jy7mTvb6EQE7qsqbTp5/q09rEIH7wzNNxrvMDb/3eaVOLsgrbfgzdi1B7MI6ADDy9idlz7zjNwobktkvgnQp5SHIooNhuo9hfNKcIBXUdkwM/HEeoBPTNl6MTXcGjDQqgzuI9y2qEw== X-YMail-OSG: vHMX3MMVM1klkVJeDUatRuZ2K5KUb.n.e0POhXElXyIu7j9JFzrdeVG6GYk6jFb UCKpvryBVGwEQYggLhzjBP8GkJcyZlPAmUM8YWH4ozNAbuxfNPw.TFTPl73HyzyGyXMA3GNt8Wj7 277uAszpnXxcrrncyhqhWSkmUWIoNBAgtruJV9TuypoTWPWWHfwVSYJE81V0qeKPcc8Z8TcxuvOJ 3Klw32SwzFRi71eivPG3k7uUKBU2LwWT86VtijBuw3.DWdqLbJvbdehpcoWAqiGd7hAGxwULAkpA ZP_SBt8qTbZOGIk.scVTnrKj.EI.eTvPo4LryDTdvgSds7LfCAv5JeOCatLsZJPViuim3LKX5BQ3 ekgbod3BYbZZO.8zrh66aQtYHnG05kgR6cUdCpFX8eKf3MMs3V.aj.Kfg_hYinh1puvUjbuq6I3t .5qQ0_RcDooNW4yDmYCcLO0RUCqmhFl6r8z7Kjx3y4wkQqpQNi65P7aaeyXYYRbxO0DnSf7xOYy1 HKI7RWUV8Ly9iw1t_3yeVBXHXYRBVhutB2S45ZFj1ynHsqSgOgklA7x.pWJnLYXj99ln1au.f795 wyo9uKqvRqP0ppmoSIl9TzujmSTYzLGQP0Blz1.pcvt7qjVkcSxhNDN43Gshb0jCSaYq1Bxj7CH4 ic.ZKuBMuovEt_BXvyff2w4Zz2BIwxbW8Mc5RP00LCmfJ3kQ892zoSy90BTg7b4wSEZhZTMf6BaW CFvGhFtpDXiWppgyK7R8cerRzwnKoKSQ0_TPsTbt8yJlmuF2.xlQesR0FlgnCHjHcIbb.jiWUEUC NlAN681hbc2RvZO76ZAtjd6XQBd5ejuxY1H5__xr7x2BBOHwNONHscPK8spPwb3MrmX6PFWuEcsr .P9gCUM5U3NRDYFQHGmGdpiSNdySyQSlh6WwdvTZ9iUWOSL5C1WIjg222JUo_8KtFD6r5dlzEUh9 uRtIYeYu0iDHPdC_il_T_o66GXJxu1_MOnSjYc49ZUl729cBUKPfliSHlETrGWMBzThvqRjnDtLk H7AvV.ACmDYhM75xusPYCbsScYsB23BzgMKo01Y1HzevJdj5GTNGDkX_uVoHzvkpmHkfFWueoM14 eO1f.A0h2LwAo_Y0TXp5EM3ceRA6d6w1pbi25nLrbNPDNq9PHt3tfXAd1G31aERw5P3kzcympIYs cfyA3Jk1ZOZ5f0C0nzawHeEWAeGxFuXI8Y5hxXpRDu1pdDvKKq3WHBF8Q5LfjEpjQzwBaFS0VtRQ z21DG8q5U3sWp4C0TtF2ccRJa205fBc2elTgnbUc5sd3egb9qIaH96_PTTw41gOhevjo5BQ4Xt04 0zLrLwq8VBVb7R3JNJdPR5i808GCNRI3os61CorFjQe7qtyFtjgYrJ.tKENLRiFtinuJS87qqe6s yVOW9u4f4WWxYwz1jdeo017aKTm8_o6perLjzsBqS__3wuHHIhpPkbQY0Qpx57MNcOkdPVlKXxBA NGt3YEgjCbrlu8V4OG6uqEw9SmDdS0cur2D666s3ghiC0bRZzMDYqXXBc6C.M0vqN1RCPHeBFeRH QkEyxMlDa9uaeTxQA8Hg.Ao7FpM0cx8qFYsVj7oqI_.Br8zIc_hsymugA_DAtq3yPX4_Uce4a5Yb _Tk5LMSwrcdWZmCwcsYYrw8UGp5Eki90PY.0wo4KV83EXeSlLbT4gNEfDKPiS4cXjDjF9dMOtB91 3ulJOmDkEWdYO65rN_Vhgf6L8sS1ymSHoG7sPnTt0W31rzlL859Kjg3hJgPDJD1b3MX4vkoIUBHX wlWKgzP7Zldedd_OqY9XsClg7pOYWcXh7AZ5BA9RgqPCZ1mq4nLt9SZAi1AonKoGBJqdfS2MJE9E v5NEMG733val9xUTUes8T_g08CqsKiOt1JPLcTCxCkn9jXLpZuU.XNFNI9rAGciSwwlzFrblhjvc uY4rUtuBrDtxghPGHCaOahZBduJ2bRQ3l.7Kvu18unePuMXKAA5fXhv4fU7SwMv7Y7r2HFBsiwRv XKSf1yn7rzgK1qHjoSlCbTbsZgDxnukl2qvBkZ48giAgtmQxt73AF.UzGkMc_xkoNFo.1P71q41l tL27zPcT50XkwFHqeaYXFiBZjKJx5MkHtW20az94sQWTvAikwwKMk7krjq1BhnBWVchx56aw5yJO p6yvx3qyFk3G05J8wAlGoPjb9FqV.tlVnk7wLorfrgEflemaq2rZGwd6eW.a7sS5YrkocnobNdi1 tFdc- X-Sonic-MF: Message-ID: <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> Date: Fri, 15 Jul 2022 15:53:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5222 On 7/15/2022 6:05 AM, Jan Beulich wrote: > On 15.07.2022 04:07, Chuck Zmudzinski wrote: > > On 7/14/2022 1:30 AM, Thorsten Leemhuis wrote: > >> On 13.07.22 03:36, Chuck Zmudzinski wrote: > >>> The commit 99c13b8c8896d7bcb92753bf > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > >>> incorrectly failed to account for the case in init_cache_modes() when > >>> CPUs do support PAT and falsely reported PAT to be disabled when in > >>> fact PAT is enabled. In some environments, notably in Xen PV domains, > >>> MTRR is disabled but PAT is still enabled, and that is the case > >>> that the aforementioned commit failed to account for. > >>> > >>> As an unfortunate consequnce, the pat_enabled() function currently does > >>> not correctly report that PAT is enabled in such environments. The fix > >>> is implemented in init_cache_modes() by setting pat_bp_enabled to true > >>> in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > >>> to account for. > >>> > >>> This approach arranges for pat_enabled() to return true in the Xen PV > >>> environment without undermining the rest of PAT MSR management logic > >>> that considers PAT to be disabled: Specifically, no writes to the PAT > >>> MSR should occur. > >>> > >>> This patch fixes a regression that some users are experiencing with > >>> Linux as a Xen Dom0 driving particular Intel graphics devices by > >>> correctly reporting to the Intel i915 driver that PAT is enabled where > >>> previously it was falsely reporting that PAT is disabled. Some users > >>> are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > >>> Dom0 are experiencing reduced graphics performance because the keying of > >>> the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > >>> means that in particular graphics frame buffer accesses are quite a bit > >>> less performant than possible without this patch. > >>> > >>> Also, with the current code, in the Xen PV environment, PAT will not be > >>> disabled if the administrator sets the "nopat" boot option. Introduce > >>> a new boolean variable, pat_force_disable, to forcibly disable PAT > >>> when the administrator sets the "nopat" option to override the default > >>> behavior of using the PAT configuration that Xen has provided. > >>> > >>> For the new boolean to live in .init.data, init_cache_modes() also needs > >>> moving to .init.text (where it could/should have lived already before). > >>> > >>> Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > >> > >> BTW, "submitting-patches.rst" says it should just be "the first 12 > >> characters of the SHA-1 ID" > > > > Actually it says "at least", so more that 12 is It is probably safest > > to put the entire SHA-1 ID in because of the possibility of > > a collision. At least that's how I understand what > > submitting-patches.rst. > > > >> > >>> Co-developed-by: Jan Beulich > >>> Cc: stable@vger.kernel.org > >>> Signed-off-by: Chuck Zmudzinski > >> > >> Sorry, have to ask: is this supposed to finally fix this regression? > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > > > Yes that's the first report I saw to lkml about this isssue. So if I submit > > a v3 I will include that. But my patch does not have a sign-off from the > > Co-developer as I mentioned in a message earlier today, and the > > discussion that has ensued leads me to think a better solution is to just > > revert the commit in the i915 driver instead, and leave the bigger questions > > for Juergen Gross and his plans to re-work the x86/PAT code in September, > > as he said on this thread in the last couple of days. This patch is dead > > now, > > as far as I can tell, because the Co-developer is not cooperating. > > ??? > > Jan I think I recall you said my patch proves I don't want your S-o-b. I also want to add some useful logs with your approach, probably a pr_warn, which you are not interested in doing. I think it is probably necessary, under the current situation, to warn all users of Xen/Linux that Linux on Xen is not guaranteed to be secure and full-featured anymore. That is also why I think the Linux maintainers are ignoring your patch. They are basically saying Xen is just some weird one-off thing, I can't remember who said it, but I did read it here in some of the comments on your patch, and you do not seem to be listening to and responding to what the Linux developers are asking you to do. Two things I see here in my efforts to get a patch to fix this regression: 1. Does Xen have plans to give Linux running in Dom0 write-access to the PAT MSR? 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? These don't have to be the defaults for Dom0. But can Xen at least make these as supported configurations for Linux? Then, the problem of Xen being some weird one-off thing goes away. At least that's how I see the situation. Maybe Xen can provide these for Linux in Dom0, but from what I've read here, it seems Xen is not willing to do that for Linux. Do I understand that correctly? Chuck From xen-devel-bounces@lists.xenproject.org Fri Jul 15 20:34:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 20:34:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368558.599903 (Exim 4.92) (envelope-from ) id 1oCS0y-0003mF-I3; Fri, 15 Jul 2022 20:34:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368558.599903; Fri, 15 Jul 2022 20:34:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCS0y-0003m8-FA; Fri, 15 Jul 2022 20:34:20 +0000 Received: by outflank-mailman (input) for mailman id 368558; Fri, 15 Jul 2022 20:34:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCS0w-0003ly-PJ; Fri, 15 Jul 2022 20:34:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCS0w-00056T-Lh; Fri, 15 Jul 2022 20:34:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCS0w-0006z2-7p; Fri, 15 Jul 2022 20:34:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCS0w-00007P-7N; Fri, 15 Jul 2022 20:34:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oCI+LDB8NPljwIykIdWwPtWHKwKqYT/MK9O3xXpFE/c=; b=DT0HvJFYc3ZfM3V5errIZwewBT sLjx/HA8im4miHUiTh95ouo8zf2YQOCG3yZfOs1D/s3n1Dzh/ntlwO30cOIggheVWA6IduLXsuUqk 6sxKgNz5yI5WyztPZU9cbERND5n4r9Yl8gOQ8RKHY7mo211PtjtQ/kQqcCSUAq0bXXh8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171645: all pass - PUSHED X-Osstest-Versions-This: ovmf=0d23c447d6f574cbe511414b70df14119099c70f X-Osstest-Versions-That: ovmf=470206ba7f118aaa1153d66689cf3ee4d17051b7 From: osstest service owner Date: Fri, 15 Jul 2022 20:34:18 +0000 flight 171645 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171645/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0d23c447d6f574cbe511414b70df14119099c70f baseline version: ovmf 470206ba7f118aaa1153d66689cf3ee4d17051b7 Last test of basis 171633 2022-07-14 18:41:54 Z 1 days Testing same since 171645 2022-07-15 18:11:45 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jagadeesh Ujja Sami Mujawar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 470206ba7f..0d23c447d6 0d23c447d6f574cbe511414b70df14119099c70f -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 15 22:16:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 22:16:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368567.599914 (Exim 4.92) (envelope-from ) id 1oCTbv-0000E4-SM; Fri, 15 Jul 2022 22:16:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368567.599914; Fri, 15 Jul 2022 22:16:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCTbv-0000Dx-Pa; Fri, 15 Jul 2022 22:16:35 +0000 Received: by outflank-mailman (input) for mailman id 368567; Fri, 15 Jul 2022 22:16:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCTbu-00004w-9K for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 22:16:34 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8254f1c-048b-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 00:16:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A52C1B82EB3; Fri, 15 Jul 2022 22:16:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C99AC34115; Fri, 15 Jul 2022 22:16:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8254f1c-048b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657923390; bh=5/bcyrjFpp5Iuv4UCuUwJcz8BDDH3Jj7t4EoceoC5iE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NvfK/jLzTa/S0wO9Yu7D5Jj5Fqj2YFjk1gi1svN5MtA8ehbFBJQc2RMO9X4ScthVs QsizMcGJn7zk4W0Q3qGAkYt5Xj7DUH3MiVecJWCNDWVTicNQBpujr5kpgNbSeEotZJ OL7a0dy1v8P4oiwQ2lzX1fSSWGN5aJz9TvIhxB8GxpoV6utwwratBETIkCoPtKgB8G zgF1NCIytZlL2WQlSg6UoeibjYVBrB6HeYMze2quwYG0Tc0fnlsZ57dLrUSVvRgN9V m/k5ebjsanBpcE15qxEz7qp7QPV+iB5uoCnQDAXTMlzemLomd7+ODKbJzYMRAGSxkc peojgDaJNTxsQ== From: SeongJae Park To: SeongJae Park Cc: roger.pau@citrix.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v3 0/2] Fix persistent grants negotiation with a behavior change Date: Fri, 15 Jul 2022 22:16:27 +0000 Message-Id: <20220715221627.127648-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715181226.126714-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi all, On Fri, 15 Jul 2022 18:12:26 +0000 SeongJae Park wrote: > Hi all, > > On Fri, 15 Jul 2022 17:55:19 +0000 SeongJae Park wrote: > > > The first patch of this patchset fixes 'feature_persistent' parameter > > handling in 'blkback' to respect the frontend's persistent grants > > support always. The fix makes a behavioral change, so the second patch > > makes the counterpart of 'blkfront' to consistently follow the behavior > > change. > > I made the behavior change as requested by Andrii[1]. I therefore made similar > behavior change to blkfront and Cc-ed stable for the second change, too. Now I realize that commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") introduced two issues. One is what Max reported with his patch, and the second one is unintended behavioral change that broke Andrii's use case. That is, Andrii's use case should had no problem at all before the introduction of 'feature_persistent', as at that time 'blkback' checked if the frontend support the persistent grants for every 'reconnect()' and enables it if so. However, introduction of the parameter made it behaves differently. Yes, we intended to make the prameter to make effects to newly created devices. But, as it breaks user workflows, this should be fixed. Same for the 'blkfront' side 'feature_persistent'. > > To make the change history clear and reduce the stable side overhead, however, > it might be better to apply the v2, which don't make behavior change but only > fix the issue, Cc stable@ for it, make the behavior change commits for both > blkback and blkfront, update the documents, and don't Cc stable@ for the > behavior change and documents update commits. I'd say having one patch for each issue would be the right way to go, and all fixes should Cc stable@. > > One downside of that would be that it will make a behavioral difference in > pre-5.19.x and post-5.19.x. The unintended behavioral fix should also be considered fix and therefore should be merged into stable@, so above concern is not valid. I will send the next spin soon. Thanks, SJ [...] From xen-devel-bounces@lists.xenproject.org Fri Jul 15 22:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 22:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368573.599925 (Exim 4.92) (envelope-from ) id 1oCU9c-0005YD-Ha; Fri, 15 Jul 2022 22:51:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368573.599925; Fri, 15 Jul 2022 22:51:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9c-0005Y6-F0; Fri, 15 Jul 2022 22:51:24 +0000 Received: by outflank-mailman (input) for mailman id 368573; Fri, 15 Jul 2022 22:51:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9b-0005Xu-5q for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 22:51:23 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a4a123c4-0490-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 00:51:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B9BCFB82EF2; Fri, 15 Jul 2022 22:51:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E7B9C341C6; Fri, 15 Jul 2022 22:51:17 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a4a123c4-0490-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657925478; bh=dlKaQtwg6yYz18rR7yrtedCSXkIPHob7qvry1GivQwU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zfee0JPaAo7oMHjphPshW1SCisXCB26lmUDf4+N5Lfa3ZXWP/1h9AYnrlFDyOnNGa 8CZCtlA0YcgiyS66d8rMWfTaDRK7BIaeNQsTXBSIJBWZcdIXsm6wJMbEebhJ0AHuHQ E7ljrx5Vc/3IEsYX/sJTdT+2WNJtr8q4TKoP2iBaDXH8ARh4/17mMXAxgC2RbBf/K2 d5QfzG48sV1dKnSkxRUMsXwBfgW5WnZrxs8QqGVmfjqa477pJcj5R1aKWjoD/dg20e pGpPpMEEltiWk3QRupHXiLvkIvon2u4J27h7ydm+P58QnbX7Wq0/CPCdq771cV88PS wvmYZSwRdGvyQ== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH v4 1/3] xen-blkback: fix persistent grants negotiation Date: Fri, 15 Jul 2022 22:51:06 +0000 Message-Id: <20220715225108.193398-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715225108.193398-1-sj@kernel.org> References: <20220715225108.193398-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Persistent grants feature can be used only when both backend and the frontend supports the feature. The feature was always supported by 'blkback', but commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") has introduced a parameter for disabling it runtime. To avoid the parameter be updated while being used by 'blkback', the commit caches the parameter into 'vbd->feature_gnt_persistent' in 'xen_vbd_create()', and then check if the guest also supports the feature and finally updates the field in 'connect_ring()'. However, 'connect_ring()' could be called before 'xen_vbd_create()', so later execution of 'xen_vbd_create()' can wrongly overwrite 'true' to 'vbd->feature_gnt_persistent'. As a result, 'blkback' could try to use 'persistent grants' feature even if the guest doesn't support the feature. This commit fixes the issue by moving the parameter value caching to 'xen_blkif_alloc()', which allocates the 'blkif'. Because the struct embeds 'vbd' object, which will be used by 'connect_ring()' later, this should be called before 'connect_ring()' and therefore this should be the right and safe place to do the caching. Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximilian Heyne Signed-off-by: SeongJae Park --- drivers/block/xen-blkback/xenbus.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 97de13b14175..16c6785d260c 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -157,6 +157,11 @@ static int xen_blkif_alloc_rings(struct xen_blkif *blkif) return 0; } +/* Enable the persistent grants feature. */ +static bool feature_persistent = true; +module_param(feature_persistent, bool, 0644); +MODULE_PARM_DESC(feature_persistent, "Enables the persistent grants feature"); + static struct xen_blkif *xen_blkif_alloc(domid_t domid) { struct xen_blkif *blkif; @@ -181,6 +186,8 @@ static struct xen_blkif *xen_blkif_alloc(domid_t domid) __module_get(THIS_MODULE); INIT_WORK(&blkif->free_work, xen_blkif_deferred_free); + blkif->vbd.feature_gnt_persistent = feature_persistent; + return blkif; } @@ -472,12 +479,6 @@ static void xen_vbd_free(struct xen_vbd *vbd) vbd->bdev = NULL; } -/* Enable the persistent grants feature. */ -static bool feature_persistent = true; -module_param(feature_persistent, bool, 0644); -MODULE_PARM_DESC(feature_persistent, - "Enables the persistent grants feature"); - static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, unsigned major, unsigned minor, int readonly, int cdrom) @@ -520,8 +521,6 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, if (bdev_max_secure_erase_sectors(bdev)) vbd->discard_secure = true; - vbd->feature_gnt_persistent = feature_persistent; - pr_debug("Successful creation of handle=%04x (dom=%u)\n", handle, blkif->domid); return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 22:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 22:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368575.599940 (Exim 4.92) (envelope-from ) id 1oCU9e-0005r5-6F; Fri, 15 Jul 2022 22:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368575.599940; Fri, 15 Jul 2022 22:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9e-0005qD-1q; Fri, 15 Jul 2022 22:51:26 +0000 Received: by outflank-mailman (input) for mailman id 368575; Fri, 15 Jul 2022 22:51:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9c-0005Y5-M1 for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 22:51:24 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a582a4aa-0490-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 00:51:22 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 64EFF61DA5; Fri, 15 Jul 2022 22:51:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E108DC341CD; Fri, 15 Jul 2022 22:51:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a582a4aa-0490-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657925480; bh=AV0+69P96lBk4BCX+QsSeC3xZH+PgsfB0jKHeIQR8Hw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZtrJxm7JK/F+zYUSYRD53qvkq6ZbXXR238NJUdHAlXahrigxJLDmadWU7VzKU3Cbh 66/l/yAsn9WaxtwwUp1gkXZ+C3vr54YHZ9t7fqthSwAnP3AKWQ2MZfSoKs20PzBL6n X+JhJlLr/PWSFFszpvSaWjUYn4ssPaNz01rxUOA6s7N1iZ761rfNJ94TCss3Wn4B8W IElj94yUPXzzIIbpTiwS+N5B9OZYf5h2yjMlpp32bhhM2Ne22oWRw3wnF6Jz2EpSM5 VF0rxuU5zk6Mj8B+bsINHe+hjkGe4hGFItpaotx60zGrLSg01iL+AhTM3tT5d5phH1 aMVXGwwkO3YOQ== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH v4 3/3] xen-blkfront: Apply 'feature_persistent' parameter when connect Date: Fri, 15 Jul 2022 22:51:08 +0000 Message-Id: <20220715225108.193398-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715225108.193398-1-sj@kernel.org> References: <20220715225108.193398-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In some use cases[1], the backend is created while the frontend doesn't support the persistent grants feature, but later the frontend can be changed to support the feature and reconnect. In the past, 'blkback' enabled the persistent grants feature since it unconditionally checked if frontend supports the persistent grants feature for every connect ('connect_ring()') and decided whether it should use persistent grans or not. However, commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") has mistakenly changed the behavior. It made the frontend feature support check to not be repeated once it shown the 'feature_persistent' as 'false', or the frontend doesn't support persistent grants. Similar behavioral change has made on 'blkfront' by commit 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants"). This commit changes the behavior of the parameter to make effect for every connect, so that the previous behavior of 'blkfront' can be restored. [1] https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g@mail.gmail.com/ Fixes: 74a852479c68 ("xen-blkfront: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkfront.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkfront b/Documentation/ABI/testing/sysfs-driver-xen-blkfront index 7f646c58832e..4d36c5a10546 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkfront +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkfront @@ -15,5 +15,5 @@ KernelVersion: 5.10 Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note - that this option only takes effect on newly created frontends. + that this option only takes effect on newly connected frontends. The default is Y (enable). diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 3646c0cae672..4e763701b372 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1988,8 +1988,6 @@ static int blkfront_probe(struct xenbus_device *dev, info->vdevice = vdevice; info->connected = BLKIF_STATE_DISCONNECTED; - info->feature_persistent = feature_persistent; - /* Front end dir is a number, which is used as the id. */ info->handle = simple_strtoul(strrchr(dev->nodename, '/')+1, NULL, 0); dev_set_drvdata(&dev->dev, info); @@ -2283,7 +2281,7 @@ static void blkfront_gather_backend_features(struct blkfront_info *info) if (xenbus_read_unsigned(info->xbdev->otherend, "feature-discard", 0)) blkfront_setup_discard(info); - if (info->feature_persistent) + if (feature_persistent) info->feature_persistent = !!xenbus_read_unsigned(info->xbdev->otherend, "feature-persistent", 0); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 22:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 22:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368576.599948 (Exim 4.92) (envelope-from ) id 1oCU9e-0005xq-IW; Fri, 15 Jul 2022 22:51:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368576.599948; Fri, 15 Jul 2022 22:51:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9e-0005v5-B1; Fri, 15 Jul 2022 22:51:26 +0000 Received: by outflank-mailman (input) for mailman id 368576; Fri, 15 Jul 2022 22:51:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9c-0005Xu-Up for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 22:51:25 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a5004039-0490-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 00:51:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4435B61DA6; Fri, 15 Jul 2022 22:51:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B07D5C341CA; Fri, 15 Jul 2022 22:51:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a5004039-0490-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657925479; bh=mrIb/ElueXH2WPoRY6/+AIbMzXNHxy0Ea9Il6Cse/O8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tZxT+pQbuYr4srnjPLlT74GcfOoy9RBpxXwayjAkFgyh5LrNUY2q22OQHx045z57h JdL3SjIYgm+lnKlOTPxlxhxTXrDItgz5B7Iq0KW9mCCuECOsfsPxQLvCGEY2TAaylX 2k3Ob5C7883feGULACavffuwP/y6NAcpUwh1zqITBCaRejmAzNJdScnUecrJbb03C1 56w9YccBqDpPCC3y+dRiauLqFDY13lTcAFOM9J+bJQugs6+dxc7q/fhpTvxXAmKs6/ UFobBSH5woSg6vsIMZc1Ne6tlWWStPO2MzvrYtDH9IlB94a1Y1CeYMd2QJpBnzdiOD V5dPouOxOxBTA== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH v4 2/3] xen-blkback: Apply 'feature_persistent' parameter when connect Date: Fri, 15 Jul 2022 22:51:07 +0000 Message-Id: <20220715225108.193398-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220715225108.193398-1-sj@kernel.org> References: <20220715225108.193398-1-sj@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Maximilian Heyne In some use cases[1], the backend is created while the frontend doesn't support the persistent grants feature, but later the frontend can be changed to support the feature and reconnect. In the past, 'blkback' enabled the persistent grants feature since it unconditionally checked if frontend supports the persistent grants feature for every connect ('connect_ring()') and decided whether it should use persistent grans or not. However, commit aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") has mistakenly changed the behavior. It made the frontend feature support check to not be repeated once it shown the 'feature_persistent' as 'false', or the frontend doesn't support persistent grants. This commit changes the behavior of the parameter to make effect for every connect, so that the previous workflow can work again as expected. [1] https://lore.kernel.org/xen-devel/CAJwUmVB6H3iTs-C+U=v-pwJB7-_ZRHPxHzKRJZ22xEPW7z8a=g@mail.gmail.com/ Reported-by: Andrii Chepurnyi Fixes: aac8a70db24b ("xen-blkback: add a parameter for disabling of persistent grants") Cc: # 5.10.x Signed-off-by: Maximilian Heyne Signed-off-by: SeongJae Park --- Documentation/ABI/testing/sysfs-driver-xen-blkback | 2 +- drivers/block/xen-blkback/xenbus.c | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-driver-xen-blkback b/Documentation/ABI/testing/sysfs-driver-xen-blkback index 7faf719af165..fac0f429a869 100644 --- a/Documentation/ABI/testing/sysfs-driver-xen-blkback +++ b/Documentation/ABI/testing/sysfs-driver-xen-blkback @@ -42,5 +42,5 @@ KernelVersion: 5.10 Contact: Maximilian Heyne Description: Whether to enable the persistent grants feature or not. Note - that this option only takes effect on newly created backends. + that this option only takes effect on newly connected backends. The default is Y (enable). diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 16c6785d260c..ee7ad2fb432d 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -186,8 +186,6 @@ static struct xen_blkif *xen_blkif_alloc(domid_t domid) __module_get(THIS_MODULE); INIT_WORK(&blkif->free_work, xen_blkif_deferred_free); - blkif->vbd.feature_gnt_persistent = feature_persistent; - return blkif; } @@ -1086,10 +1084,9 @@ static int connect_ring(struct backend_info *be) xenbus_dev_fatal(dev, err, "unknown fe protocol %s", protocol); return -ENOSYS; } - if (blkif->vbd.feature_gnt_persistent) - blkif->vbd.feature_gnt_persistent = - xenbus_read_unsigned(dev->otherend, - "feature-persistent", 0); + + blkif->vbd.feature_gnt_persistent = feature_persistent && + xenbus_read_unsigned(dev->otherend, "feature-persistent", 0); blkif->vbd.overflow_max_grants = 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 15 22:51:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 15 Jul 2022 22:51:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368574.599937 (Exim 4.92) (envelope-from ) id 1oCU9d-0005nw-Th; Fri, 15 Jul 2022 22:51:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368574.599937; Fri, 15 Jul 2022 22:51:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9d-0005np-Pw; Fri, 15 Jul 2022 22:51:25 +0000 Received: by outflank-mailman (input) for mailman id 368574; Fri, 15 Jul 2022 22:51:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCU9b-0005Xu-Um for xen-devel@lists.xenproject.org; Fri, 15 Jul 2022 22:51:23 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3f3db26-0490-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 00:51:21 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 838E5B80B9D; Fri, 15 Jul 2022 22:51:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43707C3411E; Fri, 15 Jul 2022 22:51:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3f3db26-0490-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657925477; bh=o0ng7rDUX3HJX5PzVTuirQIgJKM/KMzDsM7dZaRh1UQ=; h=From:To:Cc:Subject:Date:From; b=jN2p0VTKf1wUpI/xIITkZTZrE1Q/c7CqHuh8qboGE4G0SNvGc9IfTeBQLq2ahdIuY do2hayd/4Mmdbw5t7ZkJv8RDEvHCtnoaNR+ZQRxgkhfP63e+xVcp0HK1+dGzHK+Ezq SU0WLlUSv1HgX09NslYVXtXxn7idycRhZNlLaHkx+pQhPv2DjP/5iM1qPm5Wt49clu KSJFB+1yJ9ejUCFuXU6tGi7Iw+xJiJsJAwEWDq7XAOf5txN7DzZccNtqA5IcsLvr5E /Ouo0Gdk7SlwryUAz67KdbHlBT/dXn9pau8TVZIxon9PgFxpE4eJHTjPbFNjXOp1Mn Jtupck9KTLUQA== From: SeongJae Park To: roger.pau@citrix.com Cc: axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, olekstysh@gmail.com, andrii.chepurnyi82@gmail.com, mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, SeongJae Park Subject: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent' Date: Fri, 15 Jul 2022 22:51:05 +0000 Message-Id: <20220715225108.193398-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Introduction of 'feature_persistent' made two bugs. First one is wrong overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong parameter value caching position, and the second one is unintended behavioral change that could break previous dynamic frontend/backend persistent feature support changes. This patchset fixes the issues. Changes from v3 (https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@kernel.org/) - Split 'blkback' patch for each of the two issues - Add 'Reported-by: Andrii Chepurnyi ' Changes from v2 (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/) - Keep the behavioral change of v1 - Update blkfront's counterpart to follow the changed behavior - Update documents for the changed behavior Changes from v1 (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/) - Avoid the behavioral change (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/) - Rebase on latest xen/tip/linux-next - Re-work by SeongJae Park - Cc stable@ Maximilian Heyne (1): xen-blkback: Apply 'feature_persistent' parameter when connect SeongJae Park (2): xen-blkback: fix persistent grants negotiation xen-blkfront: Apply 'feature_persistent' parameter when connect .../ABI/testing/sysfs-driver-xen-blkback | 2 +- .../ABI/testing/sysfs-driver-xen-blkfront | 2 +- drivers/block/xen-blkback/xenbus.c | 20 ++++++++----------- drivers/block/xen-blkfront.c | 4 +--- 4 files changed, 11 insertions(+), 17 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 00:51:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 00:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368603.599970 (Exim 4.92) (envelope-from ) id 1oCW1F-0006dR-VE; Sat, 16 Jul 2022 00:50:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368603.599970; Sat, 16 Jul 2022 00:50:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCW1F-0006dK-S2; Sat, 16 Jul 2022 00:50:53 +0000 Received: by outflank-mailman (input) for mailman id 368603; Sat, 16 Jul 2022 00:50:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCW1E-0006dA-1U; Sat, 16 Jul 2022 00:50:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCW1D-0001bj-Ti; Sat, 16 Jul 2022 00:50:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCW1D-00073n-Az; Sat, 16 Jul 2022 00:50:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCW1D-0003sB-AX; Sat, 16 Jul 2022 00:50:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=obCGBrJuRgwANAGhBpI67T4Wb9ZFIdSjVGb7YTfU76I=; b=0L0FTubfWujBRcrm1CaFSD6mcT dSRiN6xJqSZ3TqSju97el2RbD4bvEH6SWAhkhVhrNM/Zmsf+RwgTfOFJs+hPSwtzUI6gCHUsZYI9w 5M+559wBhS34JWKIpJ3IGlejMI5Sp5PVjP53UIpNYypoORjHkz/nQyjpCbPIZYoyeIpo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171637: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-4.16-testing:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 X-Osstest-Versions-That: xen=744accad1b73223b3261e3e678e16e030d83b179 From: osstest service owner Date: Sat, 16 Jul 2022 00:50:51 +0000 flight 171637 xen-4.16-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171637/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171628 pass in 171637 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171628 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171595 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171595 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171595 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171595 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171595 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171595 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171595 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 baseline version: xen 744accad1b73223b3261e3e678e16e030d83b179 Last test of basis 171595 2022-07-12 09:37:57 Z 3 days Testing same since 171608 2022-07-12 23:09:33 Z 3 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 744accad1b..0a5387a011 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 03:14:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 03:14:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368624.600013 (Exim 4.92) (envelope-from ) id 1oCYFY-0006un-JE; Sat, 16 Jul 2022 03:13:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368624.600013; Sat, 16 Jul 2022 03:13:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCYFY-0006ug-FP; Sat, 16 Jul 2022 03:13:48 +0000 Received: by outflank-mailman (input) for mailman id 368624; Sat, 16 Jul 2022 03:13:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCYFX-0006uW-8v; Sat, 16 Jul 2022 03:13:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCYFX-0002mI-6H; Sat, 16 Jul 2022 03:13:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCYFW-0002Bm-Jc; Sat, 16 Jul 2022 03:13:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCYFW-0004wi-Io; Sat, 16 Jul 2022 03:13:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5huGDMGkY/ujbC0eJiX022ob+KeER/k3wGNFvhyD1Gc=; b=3XBywpJoYsRLPMQbjj9WFQm5Om Vl6/E1PP5e8wYUu7c83oelQQfJGL2lqt6khZjlsr89RPW7W4nZia4IWKaoG89kE+h9Qg4SjKnyCW4 ejzejbfpJ1ETj6xT4b0L31nLfme1pqepkqiZIk7E95Pmj1LEofqhf1cljiZ70o/rpDEE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171639: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8482ab545e52f50facacfe1118b22b97462724ab X-Osstest-Versions-That: qemuu=08c9f7eec7002dac2da52c8265eb319aba381c86 From: osstest service owner Date: Sat, 16 Jul 2022 03:13:46 +0000 flight 171639 qemu-mainline real [real] flight 171646 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171639/ http://logs.test-lab.xenproject.org/osstest/logs/171646/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 171646-retest Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 171631 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171631 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171631 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171631 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171631 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171631 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171631 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171631 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171631 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 8482ab545e52f50facacfe1118b22b97462724ab baseline version: qemuu 08c9f7eec7002dac2da52c8265eb319aba381c86 Last test of basis 171631 2022-07-14 16:39:49 Z 1 days Testing same since 171639 2022-07-15 07:49:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Kostiuk Peter Maydell zhenwei pi jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 08c9f7eec7..8482ab545e 8482ab545e52f50facacfe1118b22b97462724ab -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Jul 16 04:58:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 04:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368634.600024 (Exim 4.92) (envelope-from ) id 1oCZsK-0003v3-2B; Sat, 16 Jul 2022 04:57:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368634.600024; Sat, 16 Jul 2022 04:57:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCZsJ-0003uw-V2; Sat, 16 Jul 2022 04:57:55 +0000 Received: by outflank-mailman (input) for mailman id 368634; Sat, 16 Jul 2022 04:57:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCZsI-0003um-6r; Sat, 16 Jul 2022 04:57:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCZsH-0004fl-K7; Sat, 16 Jul 2022 04:57:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCZsH-0005K6-5O; Sat, 16 Jul 2022 04:57:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCZsH-0002xH-4y; Sat, 16 Jul 2022 04:57:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EGx8WG0dr2R6/xEY0x1ER8yau7izDenQ/uwNnMqlzSs=; b=jGOCgeWV1uSNh6fN7bav6HBG5t 9qqszqtO9lBo1wldnbafMMe8D++mCQEXggO320/XB6dE1bbatb9INBVJRpeuUXDIXBZ1d4Gx6uykz D2o2LapbYdsFsWOp8BrpuJsiw7IxYRftGyed1F2LCYNdmEjLZPENIhRp8fFMF0FtRStE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171647: all pass - PUSHED X-Osstest-Versions-This: ovmf=07c8e5e59b117f2414d7c928d3f86c85574f1fc3 X-Osstest-Versions-That: ovmf=0d23c447d6f574cbe511414b70df14119099c70f From: osstest service owner Date: Sat, 16 Jul 2022 04:57:53 +0000 flight 171647 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171647/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 07c8e5e59b117f2414d7c928d3f86c85574f1fc3 baseline version: ovmf 0d23c447d6f574cbe511414b70df14119099c70f Last test of basis 171645 2022-07-15 18:11:45 Z 0 days Testing same since 171647 2022-07-16 03:10:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sean Rhodes jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0d23c447d6..07c8e5e59b 07c8e5e59b117f2414d7c928d3f86c85574f1fc3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 16 06:30:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 06:30:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368650.600035 (Exim 4.92) (envelope-from ) id 1oCbJV-0008KF-NT; Sat, 16 Jul 2022 06:30:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368650.600035; Sat, 16 Jul 2022 06:30:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCbJV-0008JQ-Jq; Sat, 16 Jul 2022 06:30:05 +0000 Received: by outflank-mailman (input) for mailman id 368650; Sat, 16 Jul 2022 06:30:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCbJT-0007yh-IZ; Sat, 16 Jul 2022 06:30:03 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCbJT-0006YU-Dl; Sat, 16 Jul 2022 06:30:03 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCbJS-0002Fb-Jj; Sat, 16 Jul 2022 06:30:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCbJS-0000P6-JK; Sat, 16 Jul 2022 06:30:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hgVuhQDgNHLFKw2uBd3OtaN6BCDkRZfIWfD8AnuQenE=; b=AhQokAz8gnSV7evLKCXvdR1Qi0 w4ov9NzQOX7hFK+TfIx+HRx0CAsFiZAOmNJJSuuTOkiGdo/nx5/wBchmUNvCdoG19NIeNsRMrzLA8 0JYIrEpfBUdM8CbAueihxwjMBYBEFma9517eqEpWFZlZ2BPXTT+sxwUPxsfK7RxwJfX0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171643: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:debian-di-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b X-Osstest-Versions-That: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b From: osstest service owner Date: Sat, 16 Jul 2022 06:30:02 +0000 flight 171643 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171643/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171636 pass in 171643 test-arm64-arm64-xl-vhd 12 debian-di-install fail pass in 171636 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-vhd 14 migrate-support-check fail in 171636 never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail in 171636 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171636 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171636 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171636 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171636 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171636 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171636 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171636 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171636 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171636 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171636 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171636 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171636 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b baseline version: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b Last test of basis 171643 2022-07-15 14:18:13 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jul 16 08:01:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 08:01:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368669.600046 (Exim 4.92) (envelope-from ) id 1oCcjg-000460-Sx; Sat, 16 Jul 2022 08:01:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368669.600046; Sat, 16 Jul 2022 08:01:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCcjg-00045t-Pr; Sat, 16 Jul 2022 08:01:12 +0000 Received: by outflank-mailman (input) for mailman id 368669; Sat, 16 Jul 2022 08:01:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCcjf-00045j-Ul; Sat, 16 Jul 2022 08:01:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCcjf-0000Dc-CM; Sat, 16 Jul 2022 08:01:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCcje-0006oV-TD; Sat, 16 Jul 2022 08:01:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCcje-0002fQ-Sj; Sat, 16 Jul 2022 08:01:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RxAYrpW8Iv7SGg81K7KObzTBrxWoZlJqDHVBSrYhc60=; b=SHZW/7EPJXHkfhkASAd33i3Jje OD5LQubTRIRGHStxShHQf1Dk15MapUshZnyQTIA7W/Ck4hCfM0BcChty6yqQNf1gB9ARauAynx67z cMJUDL18qCf0NchnCIM5mvly/4rT05+n0dkrnzgMatldFce+EZXCWouL+SOw/SZcGohM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171642: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-amd64-amd64-qemuu-freebsd12-amd64:guest-start/freebsd.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6584107915561f860b7b05dcca5c903dd62a308d X-Osstest-Versions-That: linux=49286fbdad47ecca61a4818e77bd0aced7f59383 From: osstest service owner Date: Sat, 16 Jul 2022 08:01:10 +0000 flight 171642 linux-5.4 real [real] flight 171651 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171642/ http://logs.test-lab.xenproject.org/osstest/logs/171651/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-qemuu-freebsd12-amd64 21 guest-start/freebsd.repeat fail pass in 171651-retest test-armhf-armhf-xl-credit1 14 guest-start fail pass in 171651-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail blocked in 171548 test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 171651 like 171548 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 171651 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 171651 never pass test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171548 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171548 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171548 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171548 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171548 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171548 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 6584107915561f860b7b05dcca5c903dd62a308d baseline version: linux 49286fbdad47ecca61a4818e77bd0aced7f59383 Last test of basis 171548 2022-07-07 15:41:19 Z 8 days Failing since 171600 2022-07-12 14:42:51 Z 3 days 5 attempts Testing same since 171642 2022-07-15 13:02:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Lalaev Christoph Lameter Claudiu Beznea Darrick J. Wong David Rientjes David S. Miller Dmitry Osipenko Duoming Zhou Eric Sandeen Florian Fainelli Greg Kroah-Hartman Guenter Roeck Guiling Deng Helge Deller Hsin-Yi Wang Hyeonggon Yoo <42.hyeyoo@gmail.com> Ido Schimmel Jacob Pan Jakub Kicinski Jann Horn Jason A. Donenfeld Jernej Skrabec Jimmy Assarsson Joerg Roedel Jon Hunter Kuniyuki Iwashima Lars-Peter Clausen Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Marc Kleine-Budde Miaoqian Lin Michael Ellerman Michael Walle Neil Armstrong Nick Child Oliver Hartkopp Oliver Neukum Paolo Abeni Peter Robinson Peter Ujfalusi Rhett Aultman Rick Lindsley Sabrina Dubroca Sachin Sant Samuel Holland Sasha Levin Satish Nagireddy Shuah Khan Steffen Klassert Vinod Koul Vladimir Oltean Vlastimil Babka Wolfram Sang Yian Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 49286fbdad47..658410791556 6584107915561f860b7b05dcca5c903dd62a308d -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 09:34:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 09:34:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368681.600057 (Exim 4.92) (envelope-from ) id 1oCeBb-0007TH-Hu; Sat, 16 Jul 2022 09:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368681.600057; Sat, 16 Jul 2022 09:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCeBb-0007TA-Eu; Sat, 16 Jul 2022 09:34:07 +0000 Received: by outflank-mailman (input) for mailman id 368681; Sat, 16 Jul 2022 09:34:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCeBa-0007T0-6s; Sat, 16 Jul 2022 09:34:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCeBa-0001jb-0q; Sat, 16 Jul 2022 09:34:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCeBZ-0004fb-8C; Sat, 16 Jul 2022 09:34:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCeBZ-0001Sx-7g; Sat, 16 Jul 2022 09:34:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PnNpcoCL24jzaqIhWrLatGGVD0sUrUQMdKJlrWFBg/I=; b=AJlfTUan01IOrVu62i9SC/EL42 sRNrs0JoLaMUeFZgDMsKE77KfuyFMYU49mzhKRS2ayBJM0+lZmSxfwVXFrgvX6ZFB1YZizoGpkrfj yTfav5wpoNL2w5Yj82ZvusCokxbc5fhn9naH1RobB86HASe0Uso++R3YAouyJB6tnJX0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171644: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e5d523f1ae8f2cef01f8e071aeee432654166708 X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sat, 16 Jul 2022 09:34:05 +0000 flight 171644 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171644/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux e5d523f1ae8f2cef01f8e071aeee432654166708 baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 4 days Failing since 171601 2022-07-12 16:11:30 Z 3 days 5 attempts Testing same since 171644 2022-07-15 17:10:35 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alex Deucher Alexandre Chartre Alexei Starovoitov Alyssa Rosenzweig Andrea Mayer Andrew Cooper Ansgar Lößer Ansgar Lößer Ard Biesheuvel Arnd Bergmann Baowen Zheng Borislav Petkov Brent Lu Bryan O'Donoghue Charles Keepax Chia-Lin Kao (AceLan) Christian Brauner (Microsoft) Christian Brauner Christian König Chuck Lever Coiby Xu Dan Carpenter Daniel Borkmann Daniel Mack Daniele Ceraolo Spurio Dave Airlie Dave Chinner Dave Hansen David Owens David Owens David S. Miller Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Felix Fietkau Florian Westphal Francesco Dolcini Gal Pressman Guenter Roeck Gurucharan (A Contingent worker at Intel) Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Huaxin Lu Igor Mammedov Jakub Kicinski Jason Wang Javier Martinez Canillas Jeff Layton Jeremy Szu Jianglei Nie Joanne Koong Johan Almbladh Johannes Berg Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Kashyap Desai Kefeng Wang Kim Phillips Konrad Rzeszutek Wilk Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Liu Ying Liu, Changcheng Lorenzo Bianconi Marek Vasut Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthieu Baerts Maxim Mikityanskiy Maxime Ripard Meng Tang Michael Chan Michael Ellerman Miklos Szeredi Mimi Zohar Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Nirmoy Das Oder Chiou Pablo Neira Ayuso Paolo Abeni Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Ping-Ke Shih Rodrigo Vivi Roi Dayan Russell King (Oracle) Ryder Lee Saeed Mahameed Sascha Hauer Shyam Prasad N Siddharth Vadapalli Simon Horman Stefan Berger Steve French Steven Price Steven Rostedt (Google) sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Zimmermann Tianyu Yuan Tiezhu Yang Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Nguyen Vikas Gupta Vinayak Yadawad Wang Kefeng Will Deacon xinhui pan Xiu Jianfeng Yassine Oudjana Yevhen Orlov Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 5751 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 16 10:13:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 10:13:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368691.600068 (Exim 4.92) (envelope-from ) id 1oCenP-0004li-Mi; Sat, 16 Jul 2022 10:13:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368691.600068; Sat, 16 Jul 2022 10:13:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCenP-0004lb-Hk; Sat, 16 Jul 2022 10:13:11 +0000 Received: by outflank-mailman (input) for mailman id 368691; Sat, 16 Jul 2022 10:13:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCenN-0004lP-QV for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 10:13:10 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cdde389f-04ef-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 12:12:33 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26G3CEhD002739; Sat, 16 Jul 2022 10:13:01 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbn7a0bcg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 16 Jul 2022 10:13:00 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.16.1.2/8.16.1.2) with SMTP id 26GABiXK007572; Sat, 16 Jul 2022 10:12:59 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2176.outbound.protection.outlook.com [104.47.57.176]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com with ESMTP id 3hbkrynfx8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 16 Jul 2022 10:12:59 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by CO1PR10MB4532.namprd10.prod.outlook.com (2603:10b6:303:6d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Sat, 16 Jul 2022 10:12:57 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::5020:9b82:5917:40b%6]) with mapi id 15.20.5438.014; Sat, 16 Jul 2022 10:12:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cdde389f-04ef-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2022-7-12; bh=1k6gj6cFFW104RN+pwDglwXobR+RGNKua6JhD5+mt2k=; b=ulJMSdfhaKe5bIWiLrP3Y/GDB2AyiASabwWxLfBRujmRkWzUwfYrj6TYtJIt3Yy2Das0 f4HYAxW4XB19RFr7XmsTHSm4wfCLZukbRLOsrN6OHs75dNbqlHrmV9//M83S+EgK/fWf /fMt4rfObYdwZBTEPtqSMUwIChMObPzoP2vj0q9HcUpCQkNgWvhEUQSZIZos7XRwaXUs aQHwjYExDaZh944tUVMzoP1yRXdEdNN+bPYIYTu3Dddoo8swD5rFlknU7rz32qpcSRLY Q99qdTA649FWGO9DkdvKb45p3VdapluBYOZFQGpnmVD3uzs85YE2k7Aror3lzDehLRYC Mw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVF9qS3I7dT4P4f3Lt4K+oP1bslio8KIukAJ3OVT5brH7h5it9vKNF+4Ok5NV9lImbiY+sD/sTNLUH46oLkQMEMpvC6tyODGPzdCfPdJQKjvL9w0oDvI8BCdNyFInZfxgwlu0TKAdZ7HdOr5qBKdXtgUhU2OYWQnCO3RO+ZWyLZcYJ0ahXfBbdkRqaJYkQKU3h95d0R6IEk0tkZcZmWi+L9F6OVIk14XBEarC9fWJBNAT0byzkMJ+wZmlk4wygDF8yojCm2AMqv5kqTAoSSAo6QCOBuQS7iRccdmdkzpsQe31c/aU5n0A50Xez0WHWPmcNcLWzTvmZl1Tzfo+PmVAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1k6gj6cFFW104RN+pwDglwXobR+RGNKua6JhD5+mt2k=; b=LqRMF6Kc6F9rAs+FtTlyYyfxveGL86mzzYSH849W5g4s0qxrP37narNBPO/oplSO61GgCuwNRxdw0hKaobAbUdtYBpcJsa9un8pturQikQkQw1VPfq194oHZjB+Lq37yRZAC3v2ivak9njoGWWCCMDBayA/RHuFw3NsBgsN1xAruSXmRbMIOsSU5y1eHmcndtSaM0Hic7r6s03qR5pFHyz61QpLpq0s616RVD+3m5IKP97wQTF82edwYQIhM4kiCSFzhtqeNU9cW2e166xdKzgD29lmzljYJVzKQMAjnjLej9poOQtGWtAlPVGJjbWRpagQMawdbPW4+JKtoM7MxyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1k6gj6cFFW104RN+pwDglwXobR+RGNKua6JhD5+mt2k=; b=Kxbf8ZnGa9P6RfHObC4+Wcx3mGzjVsk96tOpE4Yo+PgLLifCTObj058+vi+3IZp8RmP1GokahfQFiILDdWR1D6BDhIrJOZ2PDVXr+Qc8hTneAhIpA3IeWEAkBTVHUblS8hXZWCSSA5pKsVxCG0PqJ8AiMjjHnriCmt1K/2hNUmw= Date: Sat, 16 Jul 2022 13:12:46 +0300 From: Dan Carpenter To: Oleksandr Tyshchenko Cc: Stefano Stabellini , Andres Lagar-Cavilla , Konrad Rzeszutek Wilk , David Vrabel , "xen-devel@lists.xenproject.org" , "kernel-janitors@vger.kernel.org" , Juergen Gross Subject: Re: [PATCH] xen/privcmd: prevent integer overflow on 32 bit systems Message-ID: <20220716101246.GA2338@kadam> References: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: MR2P264CA0044.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::32) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c968cf8a-b27f-4c63-81e1-08da6713c107 X-MS-TrafficTypeDiagnostic: CO1PR10MB4532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sXT14P+tgbTEwQJUQ4nMfdbFxdYxRVoytehprs6PzyPZHZ1K4xrLEsZMgsUHyq46hKadmquxG3SOceQ7p1KTXKALAUj6KJqRQtE8Skcepblgq6KkpHOtU/Cs5G/UO8qZ4TOHS1+yjgwh43cXIsldZNFTowAS7jDwBDaSb+coV6Y3ie6/1kcwgqIOdBqr0mgs8omegiBArF+9FzKaSPkr159UcxwT98qLQs8e/sPnUVpk5MWBNvQTdVQMy+7C/44L16Oj3CYB34lxwWijyIFCkRg7xn+GlTe5zjkFO9PagHDCNsWA7ziC6zMdhRtkdS7qD8tugh2irdDp/YBhdukf8OJplF4XHr0HbHxq6JXMCHknxePkQt+L9sCdxNxLDngPwiOhmg42yr3Al5MdPZnMII2fr/hj4DgG28823rnUjiqdf9IPEwyTqxQczinRc23PzBt/TOfqgEVZ/ATRAmYjzwjx6GJVvXGMs2bZMqOG5pyxNeAPzHb9bHNIU4Ji74LyWriud5b5LmWTTS82KWmHGyn/TfJWfavehOV2w9yQHHrn6q340Lh7MkfydoMIEt0F4rRDcvvAqmcFKvWsCXypO9U3eeiFMHJ3xr3idv280HXv1szQKKzPAL+Qj3YVwx4b/XUpCFi+Us3AIVyrWf8KQZBw19GbxkzDsF3paOtEUF4hbhlVGpSVH/5tob36eXDlUn6Fn5HyB2s1btc1T8PkfXoMrwIOK8K2YVKPsZV36xP6YjXmWOOEkHsOlJFqmac5RopmGbcxlGDvdG7APHd3TOewHq0GnIPWraSJNHKgQqJ1pcbCwR0y60/+gxLApjmi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(7916004)(39860400002)(136003)(396003)(366004)(346002)(376002)(6506007)(9686003)(6512007)(26005)(478600001)(53546011)(5660300002)(8936002)(52116002)(41300700001)(6666004)(2906002)(33656002)(54906003)(44832011)(1076003)(38350700002)(33716001)(38100700002)(83380400001)(86362001)(186003)(316002)(6486002)(66946007)(8676002)(6916009)(4326008)(66556008)(66476007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rKum5LHWG2R2GAO++IfvqoxbVehEe/E7VCCWJxbyxLkjTpsphy9Xvvp/LbXK?= =?us-ascii?Q?UQBZlRVjep7+Lkb3fTw7P9S/ygg1TxjMCiBP1Ut8pVdYqVM38memMJYom1Ii?= =?us-ascii?Q?Bit3HA9aPzMIfXqVPBu6rxjueQVY+OIEi+Qkwm0Ra0olI+tMHywr8p3YbiRE?= =?us-ascii?Q?lhEHamjXi5TQ5tqWgfH7kqaaTztfbZr84aigcPoXy+JQlkLpyqvQo0p4Sq4l?= =?us-ascii?Q?YItR82e2wUeq5SNgmqOLxKSgvskcuCgP0tz2TfTSlRWgIpnWhXePqtojBI+N?= =?us-ascii?Q?32JtDfXdxkLk9azzowyGkh8+vV0aMzPaFuqyDRGCFqP5VJQ9xlH3gxsPXF3B?= =?us-ascii?Q?Lu+OQXkYzQJRqB7i11H44GIltJ38PJU/FOQqcgxw1SuPvfTlhSoeaREGS/Je?= =?us-ascii?Q?6Jzqpwm3B+uC8qqfV1cVeQ5EepPKtHs3GVQY7tjQ0cxrmpY2Tfwl/RRjqHLN?= =?us-ascii?Q?wfTtVrIcgtSmXZ8u6zJpzpfqVdjqIcV9T9gdcwsABrHBURzCk60yQmCEqgau?= =?us-ascii?Q?CG1oOLAJYC5xHH44euEMjOarU1oEZ1lyXHhewrA58P/2ncNSdydc9zytO4Iv?= =?us-ascii?Q?cpsRV3C5dnychOGvDb1o+8lm8mFe4mPvgS8HSm8H1x6nqM/RAxsROl04qlkw?= =?us-ascii?Q?PBYnWxwBKcytR3DL4jh1fKpb76TCyfLvh79O0qipfNV4Jtdse0iiBXaRLHCT?= =?us-ascii?Q?i2CUt6136Izt0dW8EwyVhDATa55DIjyQIXKL7uUmE4VVwyD35f9UvhIlsKme?= =?us-ascii?Q?tizognQkjdaaPU86aCYHg9dtoXBXk9AR/PJfh4FMeEZYpS3PZB/ciFS5P02M?= =?us-ascii?Q?QpjValCeUpyEeqPFP+GlXTtKgpR4XddwNBv3H/346LdrorQ5jjsonovU6KB+?= =?us-ascii?Q?aPyhbJnq+D9k0BlRmowL0CLMPXTcSzWeDww2u1Hil+9ndjypF6JSKuEXbIzL?= =?us-ascii?Q?XZ7zh5JRUTiyGbM8yHSmCDAlqNBuZeyu1LAfL5hfurZ8+rgujKOMHTdUJb1J?= =?us-ascii?Q?zClCFQbEkWFd0f0sNn0tzBVEcD+lrsGKutsifT16yJ6NT92RH/0aiBsllBLz?= =?us-ascii?Q?XrE5EA5XsrHU0F19jSzWq/W5OTPon9GTXOvqgRk+7c3ANFs8b6P70JHLxLuz?= =?us-ascii?Q?BQceGoqqny3TI+8b6xJiZZdI8AuinYd1xvgBlGEREbu/NxkAaEH6qLI5GFDJ?= =?us-ascii?Q?MrZp5DxojOzgXS+IreaN3ftLcPAFi6nz5n5flwO3epZbjUKT1OfCzNQHyxlW?= =?us-ascii?Q?TFSWsXTtYR3ztgdfd+tJA7ZYAgwl5tf3QjX5GMaUS3H/xLBNhGV9Z01+iM0X?= =?us-ascii?Q?hZuNWcP4+k/aXz3VrgVK0cIflcTZv746C8+COHSqBRmE5Rt2DLbBJg42Ct7V?= =?us-ascii?Q?eUd46ZkoDAkfysJPM7Wf0ooUjnTGLkXKRJsdx+LxelTvFaZotX0EvQ/vDaWz?= =?us-ascii?Q?AHBkgVW1RgxT+xXw9TKWuvjWK1vbSGoxI6Mq7E+PyTq6BsPpVZdN+T7LUzIY?= =?us-ascii?Q?kPd1RY9O4zOuhDKWBkuE3suvslku4aBBKTmTRGsrlZxpC6s+trkXHY5Bb91I?= =?us-ascii?Q?EORiACzMwKdVPdHYz+ZNQRLDHigf8ZlWLQ+mwnqq?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c968cf8a-b27f-4c63-81e1-08da6713c107 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 10:12:57.1411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JHI1bBxj+tn533Iwdq0Ohc84HT6sLCH2F0E8YBru0D6HyGJh0N9BzfyGzpIRfcJ2rEkfl4l7g+qthRVQ679q15cClCornNosEM53LDnj7Fc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4532 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883 definitions=2022-07-16_08:2022-07-14,2022-07-16 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 bulkscore=0 spamscore=0 suspectscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207160040 X-Proofpoint-ORIG-GUID: qZYC0BGH8z82PbgsedSVW__RJKzuTlCR X-Proofpoint-GUID: qZYC0BGH8z82PbgsedSVW__RJKzuTlCR On Fri, Jul 15, 2022 at 08:56:30AM +0000, Oleksandr Tyshchenko wrote: > > On 15.07.22 11:20, Dan Carpenter wrote: > > > Hello Dan > > > The "m.num * sizeof(*m.arr)" multiplication can have an integer overflow > > on 32 bit systems. Probably no one really uses this software on 32 bit > > systems, but it's still worth fixing the bug if only to make the static > > checker happy. > > > > Fixes: ceb90fa0a800 ("xen/privcmd: add PRIVCMD_MMAPBATCH_V2 ioctl") > > Signed-off-by: Dan Carpenter > > --- > > drivers/xen/privcmd.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/xen/privcmd.c b/drivers/xen/privcmd.c > > index ad17166b0ef6..1e59b76c618e 100644 > > --- a/drivers/xen/privcmd.c > > +++ b/drivers/xen/privcmd.c > > @@ -456,6 +456,8 @@ static long privcmd_ioctl_mmap_batch( > > if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch))) > > return -EFAULT; > > /* Returns per-frame error in m.arr. */ > > + if (m.num > SIZE_MAX / sizeof(*m.arr)) > > + return -EINVAL; > > m.err = NULL; > > if (!access_ok(m.arr, m.num * sizeof(*m.arr))) > > return -EFAULT; > > @@ -464,6 +466,8 @@ static long privcmd_ioctl_mmap_batch( > > if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch_v2))) > > return -EFAULT; > > /* Returns per-frame error code in m.err. */ > > + if (m.num > SIZE_MAX / sizeof(*m.arr)) > > Looks like here we need to check against sizeof(*m.err) which is used in > the multiplication below. Oh, yeah. Sorry! Need to redo that. regards, dan carpenter From xen-devel-bounces@lists.xenproject.org Sat Jul 16 11:04:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 11:04:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368698.600079 (Exim 4.92) (envelope-from ) id 1oCfb9-0003F8-Cp; Sat, 16 Jul 2022 11:04:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368698.600079; Sat, 16 Jul 2022 11:04:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCfb9-0003F1-9U; Sat, 16 Jul 2022 11:04:35 +0000 Received: by outflank-mailman (input) for mailman id 368698; Sat, 16 Jul 2022 11:04:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCfb8-0003Ev-5K for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 11:04:34 +0000 Received: from sonic311-50.consmr.mail.gq1.yahoo.com (sonic311-50.consmr.mail.gq1.yahoo.com [98.137.65.232]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fba1c94-04f7-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 13:04:30 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic311.consmr.mail.gq1.yahoo.com with HTTP; Sat, 16 Jul 2022 11:04:27 +0000 Received: by hermes--production-bf1-58957fb66f-fvhff (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0c6d0fae316bf9b3c37baf18a7fd0b51; Sat, 16 Jul 2022 11:02:25 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fba1c94-04f7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657969467; bh=9kCVGUMpl2oWSCZYJC+fW/uAOWc3h3qV4xzemUT96SE=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=GujfvsK3tbeKL650aaxCePnYUZ+BCHW6RyYhVhTtwzmjtMCy4UE76Bg1eTFVFWVbmQl3dNyC+bicRyQ4mktA3cpdzi7aIf/lDpc5fjhSQT8+Yktz4pgheMWNfCBJGytJPHsktdrqVNZwsMF7Vs1RJ6vy/WsyyhmKCbH9a9D4Df0gxnaA5YzVpvTtsBLceikdGRQ0yQQcsc6F/ANtJbyq7w0j1t0HNQKv5w104XLcXvVFVleeCzZMSvn2ANRXQPUs2nlePEWaakL2TBaL4vHUc9u/d8xdoZ6MdU7E7wgVSpGUKcsjWvgqMfuglOGMS4ucLM6xS0u3yDvFh55ki+V+Pg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657969467; bh=pALuA2PaqkJcZFg6nSOqnMnN/y9LNS4HKyh+F3Huagi=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=DyLPwWJ//DNjw29UXmL9nnGyACsUzRP/XRiW/H4zxVpJUO3hIqSVVk0WNRjXWv4nNEa6gLrhAl9z4rmP+5PSemyymB83RsI5GJIHYl1POEY3uDqDL45kgyXOpwcuP2dmBSFawqmW3/qhXZUqssZu+jeXoLxAQm0Naohz5TZWGuaphrrvRgWt6on2iCymhTgPqKmlfWqct0K8zpC7fyGcEIm7/gVxdbflXP7QOMkjMOuM7r1MRMwXTOmihH3aQEQf61rV9eHVfvCNuIeVzDfOSgqQjt3ZDjZbuiE9/cex3396ziRDLDoYQrnHtB4jrEh69WDAWaYvUNpsXxKQ2f1YQg== X-YMail-OSG: S306_2UVM1n7GGGk3qFOuAulwIAj3xRtTyH_jeOihl0nI2.mN5zvtlDgTr88v_. YAGkQDbmRJLdZ8_ONmncnqU0vwKvLqPdKw70fu9fz1a6LpHUN_3kqQNSi660ldOVvV20IF0baY2V bByy42KCH8A.Y6Ez1fHHb8BfIpUay_Wb5VtZLXBiKinrTBuWRgK7lYKDqdGYFI3GiOorAGrclyJI ehHSwO1EELMPc0AxdSNMT5qWkLf2JVitExqqZH3OuHEDB_xhAPuUsYhl0OJPPNH_rOJQFqVpaXm7 YoNQWdjgFku_xqNNDqBJmk483ZIG_HQ106jGOmDjc_RZgNJImX75NoC5l3YLVGpb.NX43tbTaGX0 tuVzSSK._ubE3W_8Z0KzG75Sdm40.kZCHWPjL4SEWNQtsJM8LFwsostM0Qg4zBvofGT7D87ZbDyK FkEjD7FU6R8BEezJfUgOd_OJo0ES_81FGi3PPwC_bfOpqctoUvr7C.Dyf7AbNRCLOJv5MXU_VPhN TC5IMFisbVOeqKqZPIJMLqjQcmkslnq7fMUJOf7c2HgNXjLzWUjp_oNW9lM3z4VTEe0Yu2EpaTV9 Zyvfgb8HEH7CSdMKvCKGExAxrW4rwDxIJhlmQNNQRsJhArFcCaPGAwYKhgAvz1rxCSFvYmyYVzD2 JKTGwgAWD_KOnv9YLRYCj0viJp9TpHZwCSXKEiRnPW4WQgF0wMperaxXGJKcc0V4oi6UGuFTks0E ONbPZEY3NmD6UE9J8ev_Ny5HnwIG6nhzYBYneMHe2PPL9FLQhCpsUJP3G1Qg7zay6aor2x3zurwX HM5gnvxw_etjyWr6owcPU.eKxYi8cSdULiRT32N2HGLTx9iwQm.NTsvSzVX1X5MQdQm_vl6DBujz hw1MdOYVoR7Yx91p_OD_bJnfdQKJkgqNwrVwFjyNM5v_IGaHCWOW3P9Meme_jGgztsGL7OmCYSHz wpGG_MMqTKDP.MCgvVxbxPzb.a9HF9Cqsdw.1Gio24yTybwv5hXWQLE7AbwuuOpMmbDdbhwIpcaF PCCLjzSAjbdl5uE_uf7_f69WD_IbInpzG6frG.ZtuZpmucWg7q966PPizMrpDhqDIwS1cDC1qzXS NwxuLgF3T2aXo1g3t15zpgF5nw3v3b8nlhRLBHY0j.c95gU_1KDDAoqUY53ttpF8uQjKDoJBii5D 7bCIoDez13wfgBMVeWuObZtOvJVmt0licA9.RzK5V.dhbFMaw_F452BaB.na3tuI.zVq5UOHhW5b vrPtbLi89246B2ydKxPFtwPjfdhtH4hll8aqaGZSWxWWEnrqnJn8UYfxz6O5lbb1.NEDymXWAE.J pVFJz9yNRs5j73MmBp7SdpF5nbtrXh7JUvLXA_GOHYu4mhU8KVNQjXXJyawyXhfxTeOxiFvWXhhz HsnsA1bT_AhXSrDOCBrR52XQ7FtLJV2oCBY_AMMXBG1qHezbNGvTkhfXEdM4syPPvBm75P8oWfBe j5G218exk02Yex2LrmoGYpOUMAN1x1fL2OafQpYK4.pTq5V_BdSUeBmghh8CgBhx0eDEZq63JPXR 8NZMBMjXPJyg6vdNfHmdPfcusq9r1S65iGdz8SbLETsBwttLTv5dIxUwePq.Fofa5leRFV_5OLbW 5GfbUJafiT1JPA.qXypWbBlOVhOIzvizmviuucgM1UTV1H_RchKKRyqz1hvlb8MuHPr26RVtjZtY ciS5BuFWw9rYRIoA8mYkzt1J4Coa9.PHWCpbzGLckYoV1J.TimUzJLXoupimaHdcfCCDoFHLIi_6 9hjk2y_8urGYYJCArIdCsGLUJKxf_R0Y5wSrxVvpoTQGjSY4jhoaLmPy0E36fAUKsaW_7BH5cEuh gsEnCfHF2PWE8LGtd6qglHyUp8SNpLfDWny8EiJ3zaV8Vx4ytJBbACyao.1_CwMFN.Hw2Qcw9GXT TArFvhuPu.zVnD578neQfQvQLTH4xXkF2vHL5..Qnk04W_lAAysQ8Ay2WF1baDOZl2X.scrz.CoJ iMhwyxlcUXkBIiAn2Q0YTyDqwbGUIRz_rJy0now_TGBg80cmxiSqIvL75KnIC8UHs0YqdJweeJ0m r2ULwuiLaAmeaE3iO8loghYzGrQkhpKlN7_h_GgPx.DlpK2mJ_adBjwg6EXpASzkSmVvI3uQcK.i Gh7atEOp1qGo7HORtKjoOfjp9G4E_BQvFYn5xBlUeVgp6aUDpiI38ykFV3AcEPsABXMKgJ8sYfLP _6w-- X-Sonic-MF: Message-ID: <03ae6425-6d99-4ec8-9f94-005a4d79ca16@netscape.net> Date: Sat, 16 Jul 2022 07:02:25 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US From: Chuck Zmudzinski To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> In-Reply-To: <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 5482 On 7/15/2022 3:53 PM, Chuck Zmudzinski wrote: > On 7/15/2022 6:05 AM, Jan Beulich wrote: > > On 15.07.2022 04:07, Chuck Zmudzinski wrote: > > > On 7/14/2022 1:30 AM, Thorsten Leemhuis wrote: > > >> On 13.07.22 03:36, Chuck Zmudzinski wrote: > > >>> The commit 99c13b8c8896d7bcb92753bf > > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > >>> incorrectly failed to account for the case in init_cache_modes() when > > >>> CPUs do support PAT and falsely reported PAT to be disabled when in > > >>> fact PAT is enabled. In some environments, notably in Xen PV domains, > > >>> MTRR is disabled but PAT is still enabled, and that is the case > > >>> that the aforementioned commit failed to account for. > > >>> > > >>> As an unfortunate consequnce, the pat_enabled() function currently does > > >>> not correctly report that PAT is enabled in such environments. The fix > > >>> is implemented in init_cache_modes() by setting pat_bp_enabled to true > > >>> in init_cache_modes() for the case that commit 99c13b8c8896d7bcb92753bf > > >>> ("x86/mm/pat: Don't report PAT on CPUs that don't support it") failed > > >>> to account for. > > >>> > > >>> This approach arranges for pat_enabled() to return true in the Xen PV > > >>> environment without undermining the rest of PAT MSR management logic > > >>> that considers PAT to be disabled: Specifically, no writes to the PAT > > >>> MSR should occur. > > >>> > > >>> This patch fixes a regression that some users are experiencing with > > >>> Linux as a Xen Dom0 driving particular Intel graphics devices by > > >>> correctly reporting to the Intel i915 driver that PAT is enabled where > > >>> previously it was falsely reporting that PAT is disabled. Some users > > >>> are experiencing system hangs in Xen PV Dom0 and all users on Xen PV > > >>> Dom0 are experiencing reduced graphics performance because the keying of > > >>> the use of WC mappings to pat_enabled() (see arch_can_pci_mmap_wc()) > > >>> means that in particular graphics frame buffer accesses are quite a bit > > >>> less performant than possible without this patch. > > >>> > > >>> Also, with the current code, in the Xen PV environment, PAT will not be > > >>> disabled if the administrator sets the "nopat" boot option. Introduce > > >>> a new boolean variable, pat_force_disable, to forcibly disable PAT > > >>> when the administrator sets the "nopat" option to override the default > > >>> behavior of using the PAT configuration that Xen has provided. > > >>> > > >>> For the new boolean to live in .init.data, init_cache_modes() also needs > > >>> moving to .init.text (where it could/should have lived already before). > > >>> > > >>> Fixes: 99c13b8c8896d7bcb92753bf ("x86/mm/pat: Don't report PAT on CPUs that don't support it") > > >> > > >> BTW, "submitting-patches.rst" says it should just be "the first 12 > > >> characters of the SHA-1 ID" > > > > > > Actually it says "at least", so more that 12 is It is probably safest > > > to put the entire SHA-1 ID in because of the possibility of > > > a collision. At least that's how I understand what > > > submitting-patches.rst. > > > > > >> > > >>> Co-developed-by: Jan Beulich > > >>> Cc: stable@vger.kernel.org > > >>> Signed-off-by: Chuck Zmudzinski > > >> > > >> Sorry, have to ask: is this supposed to finally fix this regression? > > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > > > > > Yes that's the first report I saw to lkml about this isssue. So if I submit > > > a v3 I will include that. But my patch does not have a sign-off from the > > > Co-developer as I mentioned in a message earlier today, and the > > > discussion that has ensued leads me to think a better solution is to just > > > revert the commit in the i915 driver instead, and leave the bigger questions > > > for Juergen Gross and his plans to re-work the x86/PAT code in September, > > > as he said on this thread in the last couple of days. This patch is dead > > > now, > > > as far as I can tell, because the Co-developer is not cooperating. > > > > ??? > > > > Jan > > I think I recall you said my patch proves I don't want your S-o-b. I > also want > to add some useful logs with your approach, probably a pr_warn, which you > are not interested in doing. I think it is probably necessary, under the > current > situation, to warn all users of Xen/Linux that Linux on Xen is not > guaranteed > to be secure and full-featured anymore. That is also why I think the Linux > maintainers are ignoring your patch. They are basically saying Xen is just > some weird one-off thing, I can't remember who said it, but I did read > it here > in some of the comments on your patch, and you do not seem to be listening > to and responding to what the Linux developers are asking you to do. > > Two things I see here in my efforts to get a patch to fix this regression: > > 1. Does Xen have plans to give Linux running in Dom0 write-access to the > PAT MSR? > > 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? > > These don't have to be the defaults for Dom0. But can Xen at least make > these as supported configurations for Linux? Then, the problem of Xen > being some weird one-off thing goes away. At least that's how I see > the situation. Maybe Xen can provide these for Linux in Dom0, but > from what I've read here, it seems Xen is not willing to do that for > Linux. Do I understand that correctly? > > Chuck ??? Chuck From xen-devel-bounces@lists.xenproject.org Sat Jul 16 11:35:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 11:35:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368705.600090 (Exim 4.92) (envelope-from ) id 1oCg4U-0007Xe-PW; Sat, 16 Jul 2022 11:34:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368705.600090; Sat, 16 Jul 2022 11:34:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCg4U-0007XX-Lb; Sat, 16 Jul 2022 11:34:54 +0000 Received: by outflank-mailman (input) for mailman id 368705; Sat, 16 Jul 2022 11:34:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCg4T-0007XR-CM for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 11:34:53 +0000 Received: from sonic308-33.consmr.mail.gq1.yahoo.com (sonic308-33.consmr.mail.gq1.yahoo.com [98.137.68.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38223925-04fb-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 13:34:16 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Sat, 16 Jul 2022 11:34:48 +0000 Received: by hermes--production-ne1-7864dcfd54-hwfdm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 624a151775341492620246c559b32b79; Sat, 16 Jul 2022 11:32:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38223925-04fb-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657971288; bh=LEI6S1S45c0ysUsshBMGHEIFmmv3MJEhsY6+MP0Z5zs=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=Aj3lS59QpKn7iZ0gu1MOr37rgo48nRFJsUSPgOf5ll1wdJegWI54r58e6bjdfzeGzt0m/e7Lcd0zi979wv7CyjMku0ttz6bSDS4tA33g7SF0t6ENkgNJ+rtIr81NNBSpJlnIQkeeiulUlgWLV//1+UlzcPdEw7YwDxzeffC8fxjTRgb0+L+5lDzUv+F9kasQA/pazxPZQTqzdpJqN31keotHeqnQlOMHeH/trlmfpMkrSQJmQlHS84l+cDH9PocyG+6dgZvLfQNESObZNT9FFRjDsaeeXSNIRxlYZrlt7/B3ViIMYvzPntiM/RNOgvXkHklrL+97pNvWQaJoZuyv/g== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657971288; bh=P+xRlcqAf7oAGWwcEzcEHvfoMpdDoaZHpquMHbj+jBb=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=pxa7gcl/n4iqc/++FiDk5cpDKdfp451G2HdLmOZINMA9OAVzDWQKEwc2Js924ahR8kyRfIg456poTplfiqC96N6cjOxOJKABHhGVoytu1NKK4DOZjuh36X/DekITU+dMfKXRJOqHk3r7Rkh68cVSUFj+YxM1Jt6KBYmfeQI5ISSNWUvLGAqhW1y2oEVkj34QX819MB3ks2nOFm2IqeS+OepWxaVQUt4Wx5WxNVqF6BVY5Gs3vtB4VLq9aSjt4NPQrPLQBPKu0LDaX61qJBw4GTwD1/yUzsd8xknW5/2BVowLJq/mWOZLoNpeqq6/Z7sAI5tL4H3qoapRDi21AukPHw== X-YMail-OSG: 5v5_HrEVM1lgnRTJCZlWRbByKxEcIclSxi2uREnsMN7EUy9Ha3Mry9KtjmJWRfk umPMoBMmcW5SmJ9Wwde2GtauvclJVmOvWDLgfAfPEg7rAp_lI5ne7qPBVNFtkbwYvRYm79cfE_wM Riu0Z1dD6_gYLZUp.ResqetLyc_ke2K43RG3k5FX5clO1FG1_JT1gzLeT7mGqDkcT8X.IPmUD1Yf zUFtSel3fDPH8PvEU_j3Fuv1aGjPRgyks7PVeJGX5Oa1rZdB5aagu_OemEbrCgdSO0G7Af.jDG.j GvPOYNmVtVpiW5d4WkWdLhFFI950bdpoE2Ixvr_vlVaNnWCgsgi1AW2qzpk6nwuinYn4jvqHFJ0C LwPek_NwTQacopX3FPL6oqa0w3ilLt9tE09mXWUm9RPDj.bejGOpEhaIHvAX5h63iItRQZ.LU7cJ hY60lVxNP5vo3x9QjFgvEUzY4jeCpFZTu9ZpH7AyRENh3XJAtxnuooR4LOghi226S02VrBSyNS9p m8t0Xxvj_5_tprFmz244KkATOWr4BZwLKd5STBiMOhfwSPdRMQ7jgZAHB5807ziYggRnmK8tnZRj SvafG4jvYRZy3OD0rrGbe3oqMUdHlUf.FV1cIYq1xlzzpb2o_r7yLgoYTfgGpEHr8DYaAocAcYwP eoNqO3qNrQC.xIaSLJJJMtQmbLTZFOi.R8KPxxS3FCjbeNM9AQ2La8aHtiDf_90LjeEiNAJf0EKu iPVyA3Rk8WOuBJK2cDZBF_YXNUmfF26og8cQtFcfI4z8t4u8AfxY5Kq0zFfbihbBOVEVKuaorjhs ZAosoBYqyByYeMIJz4JT0kivrYkeb7U5IxokclSY82d33bCk94uL2elwmaVNnDfrCVJiHPv0Bfr4 Awg1NIMgY10PUCztzFTdh_w3VFhXsTRNR5m0foUDEG2RssG3lLtqiwN5zxjDiDkQa9a65ovZo9ge 4zuizc4Cy0nbkgzY__VEPAMFpmo8SCOnh6OurwA1ii7iuErG2ZtXvzF0vXGf2kcsaUfjiO0xeZe. 560Mc7iXQt3cMr4LFMte8bKQ.LwYqPU2vfWiiAcvsvglvnqc4Kb6F3CVZTXf74WVbapnC1vVOqYg FqImS8nBRG60WWa2jW.kx2yurax.IUKxlRW7xbqxrNLKORZM5ETiQdssCOWEPKca37Z5xLzLC.6P NHibWL8JvoqxMIWEdLTg1zMUHSiA00qeAzYMbd9Ke6x3qQ7naDNg1QfOtiIxmRsaA9A3tPdTjgwX 2LUMnvbLcK3Dd.iApERlr6rN12RBVhMqO0jFuv16EpbttWjCZTWQ0sZ87NTmUllsic2ki1cdAoOY e1ntJ0PRHH9bddEqfzRhx3SW_As4Ysva.hEQBqFBwAG.1u8OWzoUJt71fFfIcYZBgmtlJew0gGWu 422b5LvwTKL7vczaU2oMiOzV4geeQDA7_m18x6hdh.4VQw4KtcoAhq5XjMThz3eiBQABmG1ajChR 08CbIQaKUEYM58Iom3vBiNeJecvlvfVNaZVWq5aWMryrf9QXKSMTSTiiRMzDFefS72lNlMmYXQKJ UN6TBLyHDQsaF9huOo7HPV9hrK1BzPw.JOjfQxLa7q4MeCpHI0F3CYzGolvJ_usRRA0tnXF8x6TP vZaWyKIP9OjUJG3_GlQDa0FovYZqDrPn1VFxr.HnQuFi2vSz1htyR9JH5lJQknu2GVNzzzThPZUn 7w9NxfVniLsE.xJS1g5yp9nWFFPnDP.TnBqJ1RTNmvwFMoKNC.NtPqbqhSdijesr4yB9ZMZd_3SM VCn8NGOSZ3VegcgWrHyDrHaEz8vJYd2TyfzP1Q7yaodSxmesZ2QwXfIJUY6XSYd3OvMxdI6Sjz8L lxaCyFU34djb7wp_o07dwUYNN7qqiyGW42roPwiKupRH9QcMSiCUM4CpMVtulsqBAUV0UOidXEot ofAHzUbplstQbd7x5qnKF7XHQNx7q0USrliecmrIoVk01dXSa3UKaEpKgPaNi15J9HPPWTB4LclV YxqSlKTgDzddz2sD1IXx8WQTagXmwC2XH55r6gmm6TyfDjBBSiYM4DOsNd7Aw.rYKy952e5trj4m dL64NJZ_mV8ICZZ9oU9hEiA2Pdf1SWTxAv7sKqX8ye2gUGMclPCBKOj4VQpi0o6Ri0l1FLgOE84c sYJJrWmrDLakLc6CnJGmcSyRSeJGW7s4Ftw9L23Kqa25wy0OoYbwUJSnz9jUntYIhtx.AwVJHChO ybFblTUzWbzGxnXObLfaX7yBlkG9qZA-- X-Sonic-MF: Message-ID: <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> Date: Sat, 16 Jul 2022 07:32:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Thorsten Leemhuis Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> From: Chuck Zmudzinski In-Reply-To: <20220715142549.25223-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2427 On 7/15/2022 10:25 AM, Juergen Gross wrote: > Today PAT can't be used without MTRR being available, unless MTRR is at > least configured via CONFIG_MTRR and the system is running as Xen PV > guest. In this case PAT is automatically available via the hypervisor, > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > As an additional complexity the availability of PAT can't be queried > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > to be disabled. This leads to some drivers believing that not all cache > modes are available, resulting in failures or degraded functionality. > > The same applies to a kernel built with no MTRR support: it won't > allow to use the PAT MSR, even if there is no technical reason for > that, other than setting up PAT on all cpus the same way (which is a > requirement of the processor's cache management) is relying on some > MTRR specific code. > > Fix all of that by: > > - moving the function needed by PAT from MTRR specific code one level > up > - adding a PAT indirection layer supporting the 3 cases "no or disabled > PAT", "PAT under kernel control", and "PAT under Xen control" > - removing the dependency of PAT on MTRR > > Juergen Gross (3): > x86: move some code out of arch/x86/kernel/cpu/mtrr > x86: add wrapper functions for mtrr functions handling also pat > x86: decouple pat and mtrr handling > > arch/x86/include/asm/memtype.h | 13 ++- > arch/x86/include/asm/mtrr.h | 27 ++++-- > arch/x86/include/asm/processor.h | 10 +++ > arch/x86/kernel/cpu/common.c | 123 +++++++++++++++++++++++++++- > arch/x86/kernel/cpu/mtrr/generic.c | 90 ++------------------ > arch/x86/kernel/cpu/mtrr/mtrr.c | 58 ++++--------- > arch/x86/kernel/cpu/mtrr/mtrr.h | 1 - > arch/x86/kernel/setup.c | 12 +-- > arch/x86/kernel/smpboot.c | 8 +- > arch/x86/mm/pat/memtype.c | 127 +++++++++++++++++++++-------- > arch/x86/power/cpu.c | 2 +- > arch/x86/xen/enlighten_pv.c | 4 + > 12 files changed, 289 insertions(+), 186 deletions(-) > This patch series seems related to the regression reported here on May 5, 2022: https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ I am experiencing that regression and could test this patch on my system. Can you confirm that with this patch series you are trying to fix that regression? Chuck From xen-devel-bounces@lists.xenproject.org Sat Jul 16 11:42:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 11:42:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368712.600101 (Exim 4.92) (envelope-from ) id 1oCgBr-0000zI-Lp; Sat, 16 Jul 2022 11:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368712.600101; Sat, 16 Jul 2022 11:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgBr-0000zB-Iu; Sat, 16 Jul 2022 11:42:31 +0000 Received: by outflank-mailman (input) for mailman id 368712; Sat, 16 Jul 2022 11:42:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgBg-0000z5-8V for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 11:42:30 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 580f8e7e-04fc-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 13:42:18 +0200 (CEST) Received: from zn.tnic (p200300ea9729766f329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:766f:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id B7A2F1EC02AD; Sat, 16 Jul 2022 13:42:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 580f8e7e-04fc-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1657971732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=TrWzbl6mvGD+VhoF3wfcgTYjQ8begmaufTzu3BvWSfI=; b=C1ExD3plau1kTCEQtER4H4Afs2+xeOeYPdQkVI3hVtoyEHvXXh4x8ST6pfJ8nCPkw5vdB6 V/2P5mRnswj3HgN4AytzdE54tUOQgR8o4d6HIrp5I000qDMrxEZopxWIJ4elhwERZ9O4iV 6zUwd1IRMq3uG3UdGZ568ut+/m+6Clo= Date: Sat, 16 Jul 2022 13:42:08 +0200 From: Borislav Petkov To: Chuck Zmudzinski Cc: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Thorsten Leemhuis , jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Message-ID: References: <20220715142549.25223-1-jgross@suse.com> <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> On Sat, Jul 16, 2022 at 07:32:46AM -0400, Chuck Zmudzinski wrote: > Can you confirm that with this patch series you are trying > to fix that regression? Yes, this patchset is aimed to fix the whole situation but please don't do anything yet - I need to find time and look at the whole approach before you can test it. Just be patient and we'll ping you when the time comes. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Sat Jul 16 12:03:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 12:03:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368721.600112 (Exim 4.92) (envelope-from ) id 1oCgWA-0004Am-HY; Sat, 16 Jul 2022 12:03:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368721.600112; Sat, 16 Jul 2022 12:03:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgWA-0004Af-EA; Sat, 16 Jul 2022 12:03:30 +0000 Received: by outflank-mailman (input) for mailman id 368721; Sat, 16 Jul 2022 12:03:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgW9-0004AZ-5P for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 12:03:29 +0000 Received: from sonic304-51.consmr.mail.gq1.yahoo.com (sonic304-51.consmr.mail.gq1.yahoo.com [98.137.68.233]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c1c1e9b-04ff-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 14:03:27 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.gq1.yahoo.com with HTTP; Sat, 16 Jul 2022 12:03:25 +0000 Received: by hermes--production-bf1-58957fb66f-qrtmg (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 15342210b74ec2b3efb792f6ae39851b; Sat, 16 Jul 2022 12:01:22 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c1c1e9b-04ff-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1657973005; bh=DAM/bEP7xnNDHYTVl67GsU8rgaN43Xl0MJMznYJcJ8k=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=NP41fgjAshEYihUjHn3vCQb5C01OBhdiioWHeY+5uv9KuLa77wA7bT4hLSKPulU9KLcAuP8QA/fWGSI/yZJA1J53tBLGn2vbgKWXokQTnrcbThcmY51hB54mvG7ddAD0Wnpot/g0gSYer8FzyjqSPTryrZeVmZn1hX0f/lg0TroTzRgwBPluhI7HciiC40Day7CFXrIGeYs65PK4bH93MSmaFjMgNs+UzoohkjzYIGCc3wlzqGYn3x+erVkcQerCs5WN6pTr53KiTbZ6J6PgqpoXcMC+xxdIJCiGDKBMLr7Dp9J4G09dumyL6/8978uBPTD3hoKxiQZPGsDtKO3tNQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1657973005; bh=+hW1DQW7YFURSc4bkniM2nFGuTDWQjmcm2vfVIrE9Y4=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=Q6+0mwXVEJtGc2uIcAK2YSoWUszCUKu85XQX8U7hqhjlvxPOQRVEwEsrLx+6kSqiaoRGpbJZDkjYx5teYXBtqd39zPFyESjBxiMIIAoxyYY/P/sg5EsLND0AMHNKLb1hGvUvdbqGzYGuBbNQBjGcLbRdcyIz9yXF/gMSJBkg+n1NKsk1WjfKJcQN5YdZ7qfJCKqceeA2LhRmJlfOz6IiFoGup9N8FQrO4e9qyAq1StQPeRKPtFq1bkyYS6Vw/gxh/SOK5FEBq9FSYYXeK+L2sADzU4HxpjBm/yE//2mb/TQoame8aHGwjG4AJAcuo7MLPB/S79SHpr9tbDBBLgn9hw== X-YMail-OSG: UyYPEY8VM1knZXXCuCD9X7SMCCLHmK47it_NQ7T3OD6p35j98RQWU0OArQdTxwE Tv5lMIOAFO6E2gQX.W6NBOoIY59Fn9QsdL0WKVOpcQqcUkJM3YzpvCeRt3EgtT.n_ys8T6z6YTDy lhVqxN2uFxa.o.KQWB4ZgUvrG4x0ZfZ9Gd8hXfeYlg6jwQxzbg.UqjGrXYvpCmB6YRp0GkpuYn6z pYL2pjjizzaTCsWS1kdTNsa9LVPYpdc_uuvnKSuvSLY05TDnD8tniwtBriJf3mexDfrvMNDFdgAX un7ODWI9OQBr.ZFWroiKNWXsL_iWcypAbHGseQMpalAkzuCact3nvSPnEJWR2yxcoxWuOCJzBiix 44wMH6uoLZQovIue0xCp7dKoRXFlSRAW5VNggCqK7hqnWE3umaku5_yGtayouv2fla2VmF0XnsUs M5tmI9GdLz1GMuth_9NJhkQCAZ.5iI79inO1OAkdIfWqzSnmQaCPgF71SsTe256sJhN5ue7ld.Ak KeRaJIBKNoUDWTpgI5wWhbK3JTgSC9FYgy_WxuIYLjZiPlBfoZrPtktHErLisikKqOXArXD6x.s0 KWCqQz1i06Ch2AavloZ1K54HPiXYkcnw_SVd5fpN7.E4jBFS9EIs9ec7SgooW3S6WZc_1ZNJZoZt limpkLNDPG9TSt_fxWaaMdh3vKnDJYGe_sqLo0NRObJZz5qBQMJmyZNaahD.5I_JU9GvnLHMh1KO _Iz88ifTyBgGe5X0HNWLPwy56ivkxPoMvL.LRkAlf_6Rzkp.DzhZZOjIKT3EQs9L3.nT24zXxoH7 zNS8HDJruz__GJb4NYNmAUzAOT78aEzZ_Wr5g1pKkt94h8TUsfGHT_KqnobnEAe0MqhCed6UaCda L8X3veByAOWVfuRjqrYqcdjzxosEaj1vJE0zMolLBVQDSCWHPuuMOw8GJR9OygNL68OYl2YDbLFI 36qiT5T9cf_yqCyM4IOGcWmNZ_7oP80TqLU7MzkTZVoIpOK6ZckdLqmG4MwDhfwePWkSy32QLrIm 03fA7cUK1Z0XdYzN9tqh9l2Sx7DqxTbhmj5vCcXpjZjOeMwfLmmqnN4SeBhXg862LdHzql._q3or zp8ccokJmgb.SBEXUbgpkHFbcnjmGEIMIyrbUnuyH2wm0TXyAqvYcXSre8_s3b5H_WLB_ms_eBjx 0yNy3dWFNV1YsPhix5KFACxsrj8jqjrwCKIylbhRSQ6JeEx.ADf0M2sIsrXzvRSHTq0N33dbQcBf cm4mHGzsgolEroBnnIrWlPvKFkFqYdlFuA_9pcTXWUvatBwalFEupzp7NZZj3K8MgiN8pDUPGJRe ymuVULKAMnLxOCjuXqfBEv4HFBsxSR9.E0MH9rRukA59.wXby33kr0Q3VEmzKEoOcWkxi7zvi7gm pWSngiyu5i0b2Ff05ruxewFf_4bYC.XKAHrH9PtMcqBGfvnmgoM_qnlv0z7Bu7oEMUccunlRjBm6 LgY7wBBlFCx0xPUUArhXv4s.xPLRkCZG7_40fqtB7nvqME2c.9iTQVQVjcrgoC6792I5A8HzwBTi 1y46aQjhUp26giE52sFny7k72JkjmdZ5TOiYBi9Omjw.FyQHofL5DonUzl46T8sf.80uAS0m5MF7 QMVmkf4VytjBOtuxcwPca67UseXeYoDee2uz6Vi9drl0wRnHJVo7By4EUW1V7WFm_a.oT3_bfXyL oMEpf8.zN0AZJwqbglnUXZb.VW4vSh1EAGBpfJOr6oeQP_bWyMpbpfLkZjw.MCU0hoAZFK_K8Xts eHFnU.RpR98uMGoB1dzQqrC4flHL.QyyneeGOHuxoPyLjffmObTueEbtxQiIWWp3SnKvqrBWxdfj 2wp6Bf6DETmwz6rMpC74pdJqNKEQ_by8cqXyK8kSIU4FjOBcNcXYyYh5A2OZybWv9MsNwJgnAIyC mV29Bd7EvTpcjm_FYghulo9hevzrXcSQE9l836ACoaTzty79ShCgiZEyS0P0jPvTOSO_Wgufr4HW Q7uJXRCij_P3B7yBfay9QVNTQ48Rq_EV0EBSyX9D3T5SfPl.qFr4g.YXv_FBwQ9c1ZzYpcKHPq4. wluTRmXIyIM6RFDKzwoVLvXRz1mSAn_26s4_AJ1mGGE_myeHJBLXotfMCLDlx1W2Q2BuuDrzrZbq sWfgP6QesGJrR10ZdZKhY4RDE04GDrnLxlqppV7cTfQXBf32jMlfMfnB1jYkWxOUwinpplyTPIbM x9HwiLw7xhm4AIwJ4Xh.Op5rnDa2W1MPm X-Sonic-MF: Message-ID: Date: Sat, 16 Jul 2022 08:01:22 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US From: Chuck Zmudzinski To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Thorsten Leemhuis Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> In-Reply-To: <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2877 On 7/16/2022 7:32 AM, Chuck Zmudzinski wrote: > On 7/15/2022 10:25 AM, Juergen Gross wrote: > > Today PAT can't be used without MTRR being available, unless MTRR is at > > least configured via CONFIG_MTRR and the system is running as Xen PV > > guest. In this case PAT is automatically available via the hypervisor, > > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > > > As an additional complexity the availability of PAT can't be queried > > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > > to be disabled. This leads to some drivers believing that not all cache > > modes are available, resulting in failures or degraded functionality. > > > > The same applies to a kernel built with no MTRR support: it won't > > allow to use the PAT MSR, even if there is no technical reason for > > that, other than setting up PAT on all cpus the same way (which is a > > requirement of the processor's cache management) is relying on some > > MTRR specific code. > > > > Fix all of that by: > > > > - moving the function needed by PAT from MTRR specific code one level > > up > > - adding a PAT indirection layer supporting the 3 cases "no or disabled > > PAT", "PAT under kernel control", and "PAT under Xen control" > > - removing the dependency of PAT on MTRR > > > > Juergen Gross (3): > > x86: move some code out of arch/x86/kernel/cpu/mtrr > > x86: add wrapper functions for mtrr functions handling also pat > > x86: decouple pat and mtrr handling > > > > arch/x86/include/asm/memtype.h | 13 ++- > > arch/x86/include/asm/mtrr.h | 27 ++++-- > > arch/x86/include/asm/processor.h | 10 +++ > > arch/x86/kernel/cpu/common.c | 123 +++++++++++++++++++++++++++- > > arch/x86/kernel/cpu/mtrr/generic.c | 90 ++------------------ > > arch/x86/kernel/cpu/mtrr/mtrr.c | 58 ++++--------- > > arch/x86/kernel/cpu/mtrr/mtrr.h | 1 - > > arch/x86/kernel/setup.c | 12 +-- > > arch/x86/kernel/smpboot.c | 8 +- > > arch/x86/mm/pat/memtype.c | 127 +++++++++++++++++++++-------- > > arch/x86/power/cpu.c | 2 +- > > arch/x86/xen/enlighten_pv.c | 4 + > > 12 files changed, 289 insertions(+), 186 deletions(-) > > > > This patch series seems related to the regression reported > here on May 5, 2022: I'm sorry, the date of that report was May 4, 2022, not May 5, 2022 - just to avoid any doubt about which regression I am referring to. Chuck > > https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > I am experiencing that regression or a very similar regression that is caused by the same commit: bdd8b6c98239cad ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > and could test this patch > on my system. > > Can you confirm that with this patch series you are trying > to fix that regression? > > Chuck Chuck From xen-devel-bounces@lists.xenproject.org Sat Jul 16 12:17:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 12:17:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368728.600123 (Exim 4.92) (envelope-from ) id 1oCgjQ-0006Ox-MG; Sat, 16 Jul 2022 12:17:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368728.600123; Sat, 16 Jul 2022 12:17:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgjQ-0006Oq-JT; Sat, 16 Jul 2022 12:17:12 +0000 Received: by outflank-mailman (input) for mailman id 368728; Sat, 16 Jul 2022 12:17:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgjP-0006Og-Ta; Sat, 16 Jul 2022 12:17:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgjP-0004i9-P4; Sat, 16 Jul 2022 12:17:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCgjP-0006Rr-GH; Sat, 16 Jul 2022 12:17:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCgjP-0002yP-Fo; Sat, 16 Jul 2022 12:17:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pJ6684DrWO02maTo8S/soLKlqG3ajNx85dA6H6Pxx18=; b=kk4n5XJhRoX/485WWY96ItmKzV WtrjuGTWudMGI8sz5l/iTp7hv8y95Iu1vnXjYVG5CzCFGycuzM+ijMiEUjjsWBh6X45TnnTH7682G dvJgaUBlRg1OJ0jmudnunA0TrGAk5A7tSeTjVdkePki+TQ3At2glKlGmSNFNqQzlqTM8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171649: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=62ca3005307e9b07ebdcf09ac9742c8f8be1c072 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 16 Jul 2022 12:17:11 +0000 flight 171649 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171649/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 62ca3005307e9b07ebdcf09ac9742c8f8be1c072 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 736 days Failing since 151818 2020-07-11 04:18:52 Z 735 days 717 attempts Testing same since 171649 2022-07-16 04:18:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116192 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 16 14:39:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 14:39:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368752.600134 (Exim 4.92) (envelope-from ) id 1oCiwg-0007hz-Pp; Sat, 16 Jul 2022 14:39:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368752.600134; Sat, 16 Jul 2022 14:39:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCiwg-0007hs-Li; Sat, 16 Jul 2022 14:39:02 +0000 Received: by outflank-mailman (input) for mailman id 368752; Sat, 16 Jul 2022 14:39:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCiwe-0007hm-Mc for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 14:39:00 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCiwe-00076N-Am; Sat, 16 Jul 2022 14:39:00 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCiwe-0005tc-5u; Sat, 16 Jul 2022 14:39:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=f7bgdcn+SPnSu6vO7aABBfXXGdBS4ZO++wPuHr3aOmw=; b=TTHB6XQeHqRVdORpqaammTADyg d2rCHVRWklIH3pM2+c48zQTijBSx5hWh+J5VE5D2XsnbHgyYt7UD2PpVBi/iLOIfBeBkEpQ1ciEuz T0p2NrcdTmYMDWIQOQyRjTVrQHmVoc7pZquuACGGN5EJw9UbckF7iETGZoLpGGqYi/5c=; Message-ID: <8c6a788c-ccb9-fc5c-fdf6-870540eed722@xen.org> Date: Sat, 16 Jul 2022 15:38:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings() To: Bertrand Marquis Cc: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-5-julien@xen.org> <5CD19BFD-62C6-4409-A5A9-675D8F5FF795@arm.com> From: Julien Grall In-Reply-To: <5CD19BFD-62C6-4409-A5A9-675D8F5FF795@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bertrand, On 04/07/2022 13:35, Bertrand Marquis wrote: > Hi Julien, > >> On 24 Jun 2022, at 10:11, Julien Grall wrote: >> >> From: Julien Grall >> >> Both destroy_xen_mappings() and modify_xen_mappings() will take in >> parameter a range [start, end[. Both end should be page aligned. >> >> Add extra ASSERT() to ensure start and end are page aligned. Take the >> opportunity to rename 'v' to 's' to be consistent with the other helper. >> >> Signed-off-by: Julien Grall > > With the prototype updated in mm.h as suggested by Michal: Done. I will send a new version shortly. > Reviewed-by: Bertrand Marquis Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 16 14:57:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 14:57:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368760.600145 (Exim 4.92) (envelope-from ) id 1oCjEL-0002Og-Ek; Sat, 16 Jul 2022 14:57:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368760.600145; Sat, 16 Jul 2022 14:57:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjEL-0002OZ-Bt; Sat, 16 Jul 2022 14:57:17 +0000 Received: by outflank-mailman (input) for mailman id 368760; Sat, 16 Jul 2022 14:57:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjEK-0002OT-Bm for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 14:57:16 +0000 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [2a00:1450:4864:20::229]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9479f075-0517-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 16:57:15 +0200 (CEST) Received: by mail-lj1-x229.google.com with SMTP id o12so8666508ljc.3 for ; Sat, 16 Jul 2022 07:57:15 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id z13-20020a19504d000000b00489e64dcf75sm1500151lfj.204.2022.07.16.07.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 07:57:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9479f075-0517-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w+NcaTZFgfiP0eoFL71IUd0qkS2K5R9KmoF4rAY2ohQ=; b=qOg58/SBYgZEHIQSoU92g09pU7mKL2ywx+oT7Y+Yal1Lif5PIj4bgjIGg6IVB/M/R+ Z5GACmWnBDAvDQZKkZZqCiWXWh9IeqQUN5StZCi/7gS7WgT9veD30LhGEt7SgR9M0HUQ RmyIP/c49StDJZp9DCEQDHPgYB7iRQBW7N4hyw98B78ee5LIAzmI3MZjtCJx+zVcjWeY CxvGFgIKhd5ZdBEQkws/83+jDQakAct+EMO60fNR9GEvs2Qcnv0RMiyhvfWvuSoL24QG H08kh7z1VVHCvforPQreUJG50xSV/WN5awjJ1Cz4EPXELlIvgaiT7QO4/JV7Vw19rY6K qHpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=w+NcaTZFgfiP0eoFL71IUd0qkS2K5R9KmoF4rAY2ohQ=; b=f4LLRWNARduFm1JSuURLWyLN0Mpc3WftKf0gFRFgUHa2J+zZWmvUH2EM3VZN7D+Eh5 MMhv4xCGpB1IK5Y012btpUCWrzoL7D5r/ENGX4cEi4AKwdYpoU/vhuooITVOlv5+rE+q spEs6NT7D0k0WdV0nVgskPgc1S7jG3EtBBRegZJDHhrTC9oZrxFnIFMrSk81mFzXj1BV +LgOr+2ZLG0ddsPh5frRL/oh3P8bnFpN2eBpEcfTrwS9FUsvNMrmC6t5nGnKJ7VdKr0L Z9pEGB8l/DPnxyIfHp9777RG3CyXx/ZR9EZ2o9WWcAYMcsD1TBkaFEvouhL5gG6JQuwn mcrA== X-Gm-Message-State: AJIora+BOGi0gu0sVsfUFbAY3IXYGHQ+Tyqt4pjcPQxNpR5JBa/c/VIT RWa2ME6pwFkzPmmmw7pQzFe/jVOFSV3wDA== X-Google-Smtp-Source: AGRyM1uqz1fvzo324unIq/HAStICivJUs7FuREFQ5tCJTfLKcWIQxiWDSduv98MIzDvVntCvJSCw0Q== X-Received: by 2002:a05:651c:4cb:b0:25d:9a43:16fd with SMTP id e11-20020a05651c04cb00b0025d9a4316fdmr6626776lji.493.1657983434261; Sat, 16 Jul 2022 07:57:14 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Julien Grall Subject: [PATCH V7 1/2] xen/arm: Harden the P2M code in p2m_remove_mapping() Date: Sat, 16 Jul 2022 17:56:57 +0300 Message-Id: <20220716145658.4175730-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Borrow the x86's check from p2m_remove_page() which was added by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e "x86/p2m: don't assert that the passed in MFN matches for a remove" and adjust it to the Arm code base. Basically, this check will be strictly needed for the xenheap pages after applying a subsequent commit which will introduce xenheap based M2P approach on Arm. But, it will be a good opportunity to harden the P2M code for *every* RAM pages since it is possible to remove any GFN - MFN mapping currently on Arm (even with the wrong helpers). Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- You can find the corresponding discussion at: https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/ https://lore.kernel.org/xen-devel/1652294845-13980-2-git-send-email-olekstysh@gmail.com/ Changes V6 -> V7: - make this commit to be the first - update commit description and add a comment in code --- xen/arch/arm/p2m.c | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index d00c2e462a..2a0d383df4 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -1308,11 +1308,39 @@ static inline int p2m_remove_mapping(struct domain *d, mfn_t mfn) { struct p2m_domain *p2m = p2m_get_hostp2m(d); + unsigned long i; int rc; p2m_write_lock(p2m); + /* + * Before removing the GFN - MFN mapping for any RAM pages make sure + * that there is no difference between what is already mapped and what + * is requested to be unmapped. + * If they don't match bail out early. For instance, this could happen + * if two CPUs are requesting to unmap the same P2M concurrently. + */ + for ( i = 0; i < nr; ) + { + unsigned int cur_order; + p2m_type_t t; + mfn_t mfn_return = p2m_get_entry(p2m, gfn_add(start_gfn, i), &t, NULL, + &cur_order, NULL); + + if ( p2m_is_any_ram(t) && + (!mfn_valid(mfn) || !mfn_eq(mfn_add(mfn, i), mfn_return)) ) + { + rc = -EILSEQ; + goto out; + } + + i += (1UL << cur_order) - + ((gfn_x(start_gfn) + i) & ((1UL << cur_order) - 1)); + } + rc = p2m_set_entry(p2m, start_gfn, nr, INVALID_MFN, p2m_invalid, p2m_access_rwx); + +out: p2m_write_unlock(p2m); return rc; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 14:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 14:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368761.600156 (Exim 4.92) (envelope-from ) id 1oCjEN-0002eB-Ne; Sat, 16 Jul 2022 14:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368761.600156; Sat, 16 Jul 2022 14:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjEN-0002e4-JB; Sat, 16 Jul 2022 14:57:19 +0000 Received: by outflank-mailman (input) for mailman id 368761; Sat, 16 Jul 2022 14:57:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjEM-0002OT-Bj for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 14:57:18 +0000 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [2a00:1450:4864:20::129]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9561aeb8-0517-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 16:57:16 +0200 (CEST) Received: by mail-lf1-x129.google.com with SMTP id d12so12204467lfq.12 for ; Sat, 16 Jul 2022 07:57:16 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id z13-20020a19504d000000b00489e64dcf75sm1500151lfj.204.2022.07.16.07.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 07:57:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9561aeb8-0517-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J6bLnQbN2THnje0cYKpZNnTrTAJ0NLkOSbUXbhosl7E=; b=cdl+jeDHbSaVh8RF2KuhK5K1KSIwZNWH+q145h0BJ7Rzfwg6ElbAtISFyvTyII/z5e i0s2a3v5gxr5r4xUmi6SiR8yMtGCSXXa+o5R1u7e/5Tm5Aq4hrAXKesJppXenAvag76N 8vP5jFTLQ5xi8yJOb6tRGAG8JYW6B5ir87yEOc+swTEE7xZCVaNAYa2Bolt8WhfGmH9C B+yjpnzDS49T5NpRjW7fTHERF0KvJUhEJBZbrwvkZgp4QMhmPFo7J8vJ0wqJYuAnIe58 mAYdbGFN8Ku23ny3VwFbR9pwEr9m8uobU2r2xP/0u7iM88ToEbk8sD0BAWAgS+GAR0fi pNww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J6bLnQbN2THnje0cYKpZNnTrTAJ0NLkOSbUXbhosl7E=; b=zKxG/ni7P2YEph0rt9ruTP+GAbQdHQd1JBSyKeOhHMTE9u9wH53D7jQPQ+ZZOl9AUC 8fQIKeRL1DZkYC0G9m/GT+5tj8Ej0ni0SEdDDbD0XA/kZ41B6q6EKrSHeH0euTbGHYwT NqyGEitQUDUSnuIy5Yim2X8cB0XCo41CgaoTovvSPZN1gC0ktFT8rWWzjk4l+cn+Fmb4 m6VWlJ/YV2K5eAuLwkALfQQJ48ho4X484x8862jXJpxoVXtYSgt9Uw88TqMFXnNHlOmE /L47yMAiEn4klilJqjtE1QyaWe+mkLH8IfcWOzER71rMGKfjSgP67FElRbJY1X2+Mi10 qqbQ== X-Gm-Message-State: AJIora+dS67Dgv+vLS/QAXJZhuz7H5PA353eazadqCzEKukTaN+Wy4cg xn4FDVIkkDTlyymNDmL2TbilbXWh7NAQig== X-Google-Smtp-Source: AGRyM1vVJ6Tkr1z8JkJGPokfsvE1DjhTWGpnVFoEZDuX7I0bu6bLedn5BsUN1EWMSmxmNgrhxfn8aQ== X-Received: by 2002:a05:6512:31c1:b0:48a:2990:17b6 with SMTP id j1-20020a05651231c100b0048a299017b6mr2984052lfe.10.1657983435694; Sat, 16 Jul 2022 07:57:15 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Julien Grall Subject: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on Arm Date: Sat, 16 Jul 2022 17:56:58 +0300 Message-Id: <20220716145658.4175730-2-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220716145658.4175730-1-olekstysh@gmail.com> References: <20220716145658.4175730-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Rework Arm implementation to store grant table frame GFN in struct page_info directly instead of keeping it in standalone status/shared arrays. This patch is based on the assumption that a grant table page is a xenheap page. To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space to hold 52-bit/28-bit + extra bit value respectively. In order to not grow the size of struct page_info borrow the required amount of bits from type_info's count portion which current context won't suffer (currently only 1 bit is used on Arm). Please note, to minimize code changes and avoid introducing an extra #ifdef-s to the header, we keep the same amount of bits on both subarches, although the count portion on Arm64 could be wider, so we waste some bits here. Introduce corresponding PGT_* constructs and access macro page_get(set)_xenheap_gfn. Please note, all accesses to the GFN portion of type_info field should always be protected by the P2M lock. In case when it is not feasible to satisfy that requirement (risk of deadlock, lock inversion, etc) it is important to make sure that all non-protected updates to this field are atomic. As several non-protected read accesses still exist within current code (most calls to page_get_xenheap_gfn() are not protected by the P2M lock) the subsequent patch will introduce hardening code for p2m_remove_mapping() to be called with P2M lock held in order to check any difference between what is already mapped and what is requested to be ummapped. Update existing gnttab macros to deal with GFN value according to new location. Also update the use of count portion of type_info field on Arm in share_xen_page_with_guest(). While at it, extend this simplified M2P-like approach for any xenheap pages which are proccessed in xenmem_add_to_physmap_one() except foreign ones. Update the code to set GFN portion after establishing new mapping for the xenheap page in said function and to clean GFN portion when putting a reference on that page in p2m_put_l3_page(). And for everything to work correctly introduce arch-specific initialization pattern PGT_TYPE_INFO_INITIALIZER to be applied to type_info field during initialization at alloc_heap_pages() and acquire_staticmem_pages(). The pattern's purpose on Arm is to clear the GFN portion before use, on x86 it is just a stub. This patch is intended to fix the potential issue on Arm which might happen when remapping grant-table frame. A guest (or the toolstack) will unmap the grant-table frame using XENMEM_remove_physmap. This is a generic hypercall, so on x86, we are relying on the fact the M2P entry will be cleared on removal. For architecture without the M2P, the GFN would still be present in the grant frame/status array. So on the next call to map the page, we will end up to request the P2M to remove whatever mapping was the given GFN. This could well be another mapping. Please note, this patch also changes the behavior how the shared_info page (which is xenheap RAM page) is mapped in xenmem_add_to_physmap_one(). Now, we only allow to map the shared_info at once. The subsequent attempts to map it will result in -EBUSY. Doing that we mandate the caller to first unmap the page before mapping it again. This is to prevent Xen creating an unwanted hole in the P2M. For instance, this could happen if the firmware stole a RAM address for mapping the shared_info page into but forgot to unmap it afterwards. Besides that, this patch simplifies arch code on Arm by removing arrays and corresponding management code and as the result gnttab_init_arch/gnttab_destroy_arch helpers and struct grant_table_arch become useless and can be dropped globally. Suggested-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko --- Dear @RISC-V maintainers, please note in current patch I drop arch specific helpers gnttab_init(destroy)_arch helpers as unneeded for both Arm and x86. Please let me know if you are going to reuse them in the nearest future and I will retain them. You can find the related discussions at: https://lore.kernel.org/xen-devel/93d0df14-2c8a-c2e3-8c51-54412190171c@xen.org/ https://lore.kernel.org/xen-devel/1628890077-12545-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1631652245-30746-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1632425551-18910-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1641424268-12968-1-git-send-email-olekstysh@gmail.com/ https://lore.kernel.org/xen-devel/1652294845-13980-1-git-send-email-olekstysh@gmail.com/ Changes RFC1 -> RFC2: - update patch description - add/update comments in code - clarify check in p2m_put_l3_page() - introduce arch_alloc_xenheap_page() and arch_free_xenheap_page() and drop page_arch_init() - add ASSERT to gnttab_shared_page() and gnttab_status_page() - rework changes to Arm's struct page_info: do not split type_info, allocate GFN portion by reducing count portion, create corresponding PGT_* construct, etc - update page_get_frame_gfn() and page_set_frame_gfn() - update the use of count portion on Arm - drop the leading underscore in the macro parameter names Changes RFC2 -> RFC3: - update patch description - drop PGT_count_base and MASK_INSR() in share_xen_page_with_guest() - update alloc_xenheap_page() and free_xenheap_page() for SEPARATE_XENHEAP case (Arm32) - provide an extra bit for GFN portion, to get PGT_INVALID_FRAME_GFN one bit more than the maximum number of physical address bits on Arm32 Changes RFC3 -> V4: - rebase on Jan's "gnttab: remove guest_physmap_remove_page() call from gnttab_map_frame()" - finally resolve locking question by recent Julien's suggestion, so drop the RFC tag - update comments in Arm's mm.h/p2m.c to not mention grant table - convert page_set(get)_frame_gfn to static inline func and rename them to page_set(get)_xenheap_gfn() - rename PGT_INVALID_FRAME_GFN to PGT_INVALID_XENHEAP_GFN - add ASSERT(is_xen_heap_page(...)) in page_set(get)_frame_gfn - remove BUG_ON() in arch_free_xenheap_page - remove local type_info in share_xen_page_with_guest() - remove an extra argument p2m in p2m_put_l3_page() - remove #ifdef CONFIG_GRANT_TABLE in p2m_put_l3_page() - also cover real-only pages by using p2m_is_ram instead of a check against p2m_ram_rw in p2m_put_l3_page() and use "else if" construct - call arch_free_xenheap_page() before clearing the PGC_xen_heap in free_xenheap_pages() - remove ASSERT() in gnttab_shared(status)_page and use simpler virt_to_page - remove local pg_ in gnttab_shared(status)_gfn - update patch description to reflect recent changes Changes V4 -> V5: - rebase on latest staging - update patch description - drop arch_alloc(free)_xenheap_page macro and use arch-specific initialization pattern to clear GFN portion before use - add const to struct page_info *p in page_get_xenheap_gfn - fix a breakage on Arm32 Changes V5 -> V6: - update patch description - add/update comments in code - s/PGT_TYPE_INFO_INIT_PATTERN/PGT_TYPE_INFO_INITIALIZER - define PGT_TYPE_INFO_INITIALIZER in page_alloc.c if arch doesn't define it - modify page_get_xenheap_gfn() to use ACCESS_ONCE() when reading type_info field - modify page_set_xenheap_gfn() to use cmpxchg() when changing type_info field - apply PGT_TYPE_INFO_INITIALIZER in alloc_heap_pages() and acquire_staticmem_pages() rather than altering both flavors of alloc_xenheap_pages() to make an extra assignment - simplify gnttab_shared(status)_page and gnttab_(shared)status_gfn macro - update a check in Arm's gnttab_set_frame_gfn() Changes V6 -> V7: - make this commit to be the last - update commit description and add/update comments in code --- xen/arch/arm/include/asm/grant_table.h | 53 ++++++-------------------- xen/arch/arm/include/asm/mm.h | 47 +++++++++++++++++++++-- xen/arch/arm/mm.c | 51 ++++++++++++++++++++++--- xen/arch/arm/p2m.c | 7 +++- xen/arch/x86/include/asm/grant_table.h | 5 --- xen/common/grant_table.c | 9 ----- xen/common/page_alloc.c | 8 +++- 7 files changed, 112 insertions(+), 68 deletions(-) diff --git a/xen/arch/arm/include/asm/grant_table.h b/xen/arch/arm/include/asm/grant_table.h index a283dd5cd6..e13dfeefa5 100644 --- a/xen/arch/arm/include/asm/grant_table.h +++ b/xen/arch/arm/include/asm/grant_table.h @@ -11,11 +11,6 @@ #define INITIAL_NR_GRANT_FRAMES 1U #define GNTTAB_MAX_VERSION 1 -struct grant_table_arch { - gfn_t *shared_gfn; - gfn_t *status_gfn; -}; - static inline void gnttab_clear_flags(struct domain *d, unsigned int mask, uint16_t *addr) { @@ -56,53 +51,27 @@ int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn, #define gnttab_dom0_frames() \ min_t(unsigned int, opt_max_grant_frames, PFN_DOWN(_etext - _stext)) -#define gnttab_init_arch(gt) \ -({ \ - unsigned int ngf_ = (gt)->max_grant_frames; \ - unsigned int nsf_ = grant_to_status_frames(ngf_); \ - \ - (gt)->arch.shared_gfn = xmalloc_array(gfn_t, ngf_); \ - (gt)->arch.status_gfn = xmalloc_array(gfn_t, nsf_); \ - if ( (gt)->arch.shared_gfn && (gt)->arch.status_gfn ) \ - { \ - while ( ngf_-- ) \ - (gt)->arch.shared_gfn[ngf_] = INVALID_GFN; \ - while ( nsf_-- ) \ - (gt)->arch.status_gfn[nsf_] = INVALID_GFN; \ - } \ - else \ - gnttab_destroy_arch(gt); \ - (gt)->arch.shared_gfn ? 0 : -ENOMEM; \ -}) - -#define gnttab_destroy_arch(gt) \ - do { \ - XFREE((gt)->arch.shared_gfn); \ - XFREE((gt)->arch.status_gfn); \ - } while ( 0 ) - #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ - ({ \ - int rc_ = 0; \ - gfn_t ogfn = gnttab_get_frame_gfn(gt, st, idx); \ - if ( gfn_eq(ogfn, INVALID_GFN) || gfn_eq(ogfn, gfn) || \ - (rc_ = guest_physmap_remove_page((gt)->domain, ogfn, mfn, \ - 0)) == 0 ) \ - ((st) ? (gt)->arch.status_gfn \ - : (gt)->arch.shared_gfn)[idx] = (gfn); \ - rc_; \ - }) + (gfn_eq(gfn, INVALID_GFN) \ + ? guest_physmap_remove_page((gt)->domain, \ + gnttab_get_frame_gfn(gt, st, idx), \ + mfn, 0) \ + : 0) #define gnttab_get_frame_gfn(gt, st, idx) ({ \ (st) ? gnttab_status_gfn(NULL, gt, idx) \ : gnttab_shared_gfn(NULL, gt, idx); \ }) +#define gnttab_shared_page(t, i) virt_to_page((t)->shared_raw[i]) + +#define gnttab_status_page(t, i) virt_to_page((t)->status[i]) + #define gnttab_shared_gfn(d, t, i) \ - (((i) >= nr_grant_frames(t)) ? INVALID_GFN : (t)->arch.shared_gfn[i]) + page_get_xenheap_gfn(gnttab_shared_page(t, i)) #define gnttab_status_gfn(d, t, i) \ - (((i) >= nr_status_frames(t)) ? INVALID_GFN : (t)->arch.status_gfn[i]) + page_get_xenheap_gfn(gnttab_status_page(t, i)) #define gnttab_need_iommu_mapping(d) \ (is_domain_direct_mapped(d) && is_iommu_enabled(d)) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index c4bc3cd1e5..6c0a3c789f 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -98,9 +98,22 @@ struct page_info #define PGT_writable_page PG_mask(1, 1) /* has writable mappings? */ #define PGT_type_mask PG_mask(1, 1) /* Bits 31 or 63. */ - /* Count of uses of this frame as its current type. */ -#define PGT_count_width PG_shift(2) -#define PGT_count_mask ((1UL<u.inuse.type_info) & PGT_gfn_mask); + + ASSERT(is_xen_heap_page(p)); + + return gfn_eq(gfn_, PGT_INVALID_XENHEAP_GFN) ? INVALID_GFN : gfn_; +} + +static inline void page_set_xenheap_gfn(struct page_info *p, gfn_t gfn) +{ + gfn_t gfn_ = gfn_eq(gfn, INVALID_GFN) ? PGT_INVALID_XENHEAP_GFN : gfn; + unsigned long x, nx, y = p->u.inuse.type_info; + + ASSERT(is_xen_heap_page(p)); + + do { + x = y; + nx = (x & ~PGT_gfn_mask) | gfn_x(gfn_); + } while ( (y = cmpxchg(&p->u.inuse.type_info, x, nx)) != x ); +} + #endif /* __ARCH_ARM_MM__ */ /* * Local variables: diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 009b8cd9ef..e59a4ce6d0 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1449,9 +1449,21 @@ void share_xen_page_with_guest(struct page_info *page, struct domain *d, spin_lock(&d->page_alloc_lock); - /* The incremented type count pins as writable or read-only. */ - page->u.inuse.type_info = - (flags == SHARE_ro ? PGT_none : PGT_writable_page) | 1; + /* + * The incremented type count pins as writable or read-only. + * + * Please note, the update of type_info field here is not atomic as + * we use Read-Modify-Write operation on it. But currently it is fine + * because the caller of page_set_xenheap_gfn() (which is another place + * where type_info is updated) would need to acquire a reference on + * the page. This is only possible after the count_info is updated *and* + * there is a barrier between the type_info and count_info. So there is + * no immediate need to use cmpxchg() here. + */ + page->u.inuse.type_info &= ~(PGT_type_mask | PGT_count_mask); + page->u.inuse.type_info |= (flags == SHARE_ro ? PGT_none + : PGT_writable_page) | + MASK_INSR(1, PGT_count_mask); page_set_owner(page, d); smp_wmb(); /* install valid domain ptr before updating refcnt. */ @@ -1554,8 +1566,37 @@ int xenmem_add_to_physmap_one( return -ENOSYS; } - /* Map at new location. */ - rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); + /* + * Map at new location. Here we need to map xenheap RAM page differently + * because we need to store the valid GFN and make sure that nothing was + * mapped before (the stored GFN is invalid). And these actions need to be + * performed with the P2M lock held. The guest_physmap_add_entry() is just + * a wrapper on top of p2m_set_entry(). + */ + if ( !p2m_is_ram(t) || !is_xen_heap_mfn(mfn) ) + rc = guest_physmap_add_entry(d, gfn, mfn, 0, t); + else + { + struct p2m_domain *p2m = p2m_get_hostp2m(d); + + p2m_write_lock(p2m); + if ( gfn_eq(page_get_xenheap_gfn(mfn_to_page(mfn)), INVALID_GFN) ) + { + rc = p2m_set_entry(p2m, gfn, 1, mfn, t, p2m->default_access); + if ( !rc ) + page_set_xenheap_gfn(mfn_to_page(mfn), gfn); + } + else + /* + * Mandate the caller to first unmap the page before mapping it + * again. This is to prevent Xen creating an unwanted hole in + * the P2M. For instance, this could happen if the firmware stole + * a RAM address for mapping the shared_info page into but forgot + * to unmap it afterwards. + */ + rc = -EBUSY; + p2m_write_unlock(p2m); + } /* * For XENMAPSPACE_gmfn_foreign if we failed to add the mapping, we need diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c index 2a0d383df4..eec5e90ab0 100644 --- a/xen/arch/arm/p2m.c +++ b/xen/arch/arm/p2m.c @@ -716,6 +716,8 @@ static int p2m_mem_access_radix_set(struct p2m_domain *p2m, gfn_t gfn, */ static void p2m_put_l3_page(const lpae_t pte) { + mfn_t mfn = lpae_get_mfn(pte); + ASSERT(p2m_is_valid(pte)); /* @@ -727,11 +729,12 @@ static void p2m_put_l3_page(const lpae_t pte) */ if ( p2m_is_foreign(pte.p2m.type) ) { - mfn_t mfn = lpae_get_mfn(pte); - ASSERT(mfn_valid(mfn)); put_page(mfn_to_page(mfn)); } + /* Detect the xenheap page and mark the stored GFN as invalid. */ + else if ( p2m_is_ram(pte.p2m.type) && is_xen_heap_mfn(mfn) ) + page_set_xenheap_gfn(mfn_to_page(mfn), INVALID_GFN); } /* Free lpae sub-tree behind an entry */ diff --git a/xen/arch/x86/include/asm/grant_table.h b/xen/arch/x86/include/asm/grant_table.h index a8a21439a4..5c23cec90c 100644 --- a/xen/arch/x86/include/asm/grant_table.h +++ b/xen/arch/x86/include/asm/grant_table.h @@ -14,9 +14,6 @@ #define INITIAL_NR_GRANT_FRAMES 1U -struct grant_table_arch { -}; - static inline int create_grant_host_mapping(uint64_t addr, mfn_t frame, unsigned int flags, unsigned int cache_flags) @@ -35,8 +32,6 @@ static inline int replace_grant_host_mapping(uint64_t addr, mfn_t frame, return replace_grant_pv_mapping(addr, frame, new_addr, flags); } -#define gnttab_init_arch(gt) 0 -#define gnttab_destroy_arch(gt) do {} while ( 0 ) #define gnttab_set_frame_gfn(gt, st, idx, gfn, mfn) \ (gfn_eq(gfn, INVALID_GFN) \ ? guest_physmap_remove_page((gt)->domain, \ diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index aea0ad30a7..ad773a6996 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -99,8 +99,6 @@ struct grant_table { /* Domain to which this struct grant_table belongs. */ struct domain *domain; - - struct grant_table_arch arch; }; unsigned int __read_mostly opt_max_grant_frames = 64; @@ -2018,14 +2016,9 @@ int grant_table_init(struct domain *d, int max_grant_frames, grant_write_lock(gt); - ret = gnttab_init_arch(gt); - if ( ret ) - goto unlock; - /* gnttab_grow_table() allocates a min number of frames, so 0 is okay. */ ret = gnttab_grow_table(d, 0); - unlock: grant_write_unlock(gt); out: @@ -3939,8 +3932,6 @@ grant_table_destroy( if ( t == NULL ) return; - gnttab_destroy_arch(t); - for ( i = 0; i < nr_grant_frames(t); i++ ) free_xenheap_page(t->shared_raw[i]); xfree(t->shared_raw); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index fe0e15429a..6ca986584d 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -155,6 +155,10 @@ #define PGC_reserved 0 #endif +#ifndef PGT_TYPE_INFO_INITIALIZER +#define PGT_TYPE_INFO_INITIALIZER 0 +#endif + /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -1024,7 +1028,7 @@ static struct page_info *alloc_heap_pages( &tlbflush_timestamp); /* Initialise fields which have other uses for free pages. */ - pg[i].u.inuse.type_info = 0; + pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; page_set_owner(&pg[i], NULL); } @@ -2702,7 +2706,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, */ pg[i].count_info = PGC_reserved | PGC_state_inuse; /* Initialise fields which have other uses for free pages. */ - pg[i].u.inuse.type_info = 0; + pg[i].u.inuse.type_info = PGT_TYPE_INFO_INITIALIZER; page_set_owner(&pg[i], NULL); } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:00:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:00:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368772.600167 (Exim 4.92) (envelope-from ) id 1oCjHI-0004Pi-82; Sat, 16 Jul 2022 15:00:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368772.600167; Sat, 16 Jul 2022 15:00:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjHI-0004Pb-52; Sat, 16 Jul 2022 15:00:20 +0000 Received: by outflank-mailman (input) for mailman id 368772; Sat, 16 Jul 2022 15:00:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjHG-0004PT-Bo for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:00:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjHA-0007UA-AF; Sat, 16 Jul 2022 15:00:12 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCjHA-0007DE-3K; Sat, 16 Jul 2022 15:00:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=4USBPYDKjqQUtKQEf8+/aCXTiowYxIS2S/D5eVuKUFw=; b=BO4cZt7o0VnOgAUNoTGPtgPuNF /+pv51gQaZRd0pn1nxtM7me9Ul0GgnT01xAcob7DTCemomWJhzCCZvZxZQPkIz2yD17QMe3jxl34N hvxixOWEgH65nKlWsIpcEyo1eGQvoAKbXqDIvEMWD6BHkYfs+W9YAJSS9nAqPEK4qWgw=; Message-ID: <76a622ec-bd10-04c3-250f-c55563f9a210@xen.org> Date: Sat, 16 Jul 2022 16:00:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 6/7] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file To: Jan Beulich Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-7-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 24/06/2022 10:43, Jan Beulich wrote: > On 24.06.2022 11:11, Julien Grall wrote: >> From: Julien Grall >> >> The file xen/arch/mm.c has been growing quite a lot. It now contains >> various independent part of the MM subsytem. >> >> One of them is the helpers to map/unmap a page when CONFIG_DOMAIN_PAGE >> (only used by arm32). Move them in a new file xen/arch/arm/domain_page.c. >> >> In order to be able to use CONFIG_DOMAIN_PAGE in the Makefile, a new >> Kconfig option is introduced that is selected by x86 and arm32. >> >> Signed-off-by: Julien Grall > > In principle > Acked-by: Jan Beulich > > But ... > >> --- a/xen/arch/x86/Kconfig >> +++ b/xen/arch/x86/Kconfig >> @@ -10,6 +10,7 @@ config X86 >> select ALTERNATIVE_CALL >> select ARCH_SUPPORTS_INT128 >> select CORE_PARKING >> + select DOMAIN_PAGE >> select HAS_ALTERNATIVE >> select HAS_COMPAT >> select HAS_CPUFREQ >> diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/config.h >> index 07bcd158314b..fbc4bb3416bd 100644 >> --- a/xen/arch/x86/include/asm/config.h >> +++ b/xen/arch/x86/include/asm/config.h >> @@ -22,7 +22,6 @@ >> #define CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS 1 >> #define CONFIG_DISCONTIGMEM 1 >> #define CONFIG_NUMA_EMU 1 >> -#define CONFIG_DOMAIN_PAGE 1 > > ... while I realize it has been named this way, I wonder whether ... > >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -11,6 +11,9 @@ config COMPAT >> config CORE_PARKING >> bool >> >> +config DOMAIN_PAGE >> + bool > > ... this isn't a good opportunity to make the name match what it is > about - MAP_DOMAIN_PAGE. See e.g. {clear,copy}_domain_page() which > aren't under this guard, and domain pages in general is a concept we > can't get away without in the first place. Fair point. I decided to move this change in a prerequisite name the new Kconfig ARCH_MAP_DOMAIN_PAGE. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:06:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:06:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368780.600178 (Exim 4.92) (envelope-from ) id 1oCjNN-0005Dh-Se; Sat, 16 Jul 2022 15:06:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368780.600178; Sat, 16 Jul 2022 15:06:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjNN-0005Da-Q2; Sat, 16 Jul 2022 15:06:37 +0000 Received: by outflank-mailman (input) for mailman id 368780; Sat, 16 Jul 2022 15:06:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjNM-0005DT-Hl for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:06:36 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjNM-0007by-8S; Sat, 16 Jul 2022 15:06:36 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCjNM-0007T6-2f; Sat, 16 Jul 2022 15:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=v9RHWzfCywtNJsLWIO9efdXoki6IitgFnhsbuPUMKIQ=; b=CZbPp65WsLQDo10vsn34lDgaLM HeP+j4ocS1bizDsI+ClpS7J+k7QUAd927PPSEz/6wdQ5qJ2QCQ711gCgsqU35ziZ/MeQMPtGCISwz VpMfI7zvoLA+yeUHh3/gWgXURIlLRXb1hOROlYWhQYnXuDb66NjDlHSS8ibKbruv/3Mw=; Message-ID: Date: Sat, 16 Jul 2022 16:06:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 1/2] xen/arm: Harden the P2M code in p2m_remove_mapping() To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall References: <20220716145658.4175730-1-olekstysh@gmail.com> From: Julien Grall In-Reply-To: <20220716145658.4175730-1-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksandr, In the future, please provide a cover letter (even if it is short) when you bundle multiple patches. This is useful to make generic comments and help threading in e-mail client (each patch would be a subthread of 0 rather than 1). On 16/07/2022 15:56, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Borrow the x86's check from p2m_remove_page() which was added > by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e > "x86/p2m: don't assert that the passed in MFN matches for a remove" > and adjust it to the Arm code base. > > Basically, this check will be strictly needed for the xenheap pages > after applying a subsequent commit which will introduce xenheap based > M2P approach on Arm. But, it will be a good opportunity to harden > the P2M code for *every* RAM pages since it is possible to remove > any GFN - MFN mapping currently on Arm (even with the wrong helpers). > > Suggested-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko > --- > You can find the corresponding discussion at: > https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/ > https://lore.kernel.org/xen-devel/1652294845-13980-2-git-send-email-olekstysh@gmail.com/ > > Changes V6 -> V7: > - make this commit to be the first > - update commit description and add a comment in code > --- > xen/arch/arm/p2m.c | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c > index d00c2e462a..2a0d383df4 100644 > --- a/xen/arch/arm/p2m.c > +++ b/xen/arch/arm/p2m.c > @@ -1308,11 +1308,39 @@ static inline int p2m_remove_mapping(struct domain *d, > mfn_t mfn) > { > struct p2m_domain *p2m = p2m_get_hostp2m(d); > + unsigned long i; > int rc; > > p2m_write_lock(p2m); > + /* > + * Before removing the GFN - MFN mapping for any RAM pages make sure > + * that there is no difference between what is already mapped and what > + * is requested to be unmapped. > + * If they don't match bail out early. For instance, this could happen > + * if two CPUs are requesting to unmap the same P2M concurrently. Missing word: P2M *entry* Other than that: Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:08:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:08:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368786.600188 (Exim 4.92) (envelope-from ) id 1oCjPZ-00063X-9X; Sat, 16 Jul 2022 15:08:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368786.600188; Sat, 16 Jul 2022 15:08:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjPZ-00063Q-6y; Sat, 16 Jul 2022 15:08:53 +0000 Received: by outflank-mailman (input) for mailman id 368786; Sat, 16 Jul 2022 15:08:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjPY-00063I-6k for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:08:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjPX-0007eK-Hh; Sat, 16 Jul 2022 15:08:51 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oCjPX-0007cl-Bo; Sat, 16 Jul 2022 15:08:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=p9u2ywCIcQGacq8CjeG2zDy3bJE3LuJSn729dCdUl4g=; b=ZuwRE90N0kobvHAWLDfHz/erZL abx+G2sVddKR2JSPW5D0CpJCoNG9cTt/34WcCDdMiI6/r75IqhKZC7FTSd1jyQIQ+A4gg3iiazznh lg3CoK2TImzGQXlOT3eCuB5A0qIFNL+zdXmdopct+OlNgJSzsKzTA4euW2mZlk7lTink=; Message-ID: <89d03f62-cc43-663b-bbfb-5341498f55a7@xen.org> Date: Sat, 16 Jul 2022 16:08:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on Arm To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall References: <20220716145658.4175730-1-olekstysh@gmail.com> <20220716145658.4175730-2-olekstysh@gmail.com> From: Julien Grall In-Reply-To: <20220716145658.4175730-2-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksandr, On 16/07/2022 15:56, Oleksandr Tyshchenko wrote: > Suggested-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Julien Grall > xen/arch/x86/include/asm/grant_table.h | 5 --- This changes will need an ack from the x86 maintainers. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:20:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:20:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368795.600200 (Exim 4.92) (envelope-from ) id 1oCjaw-0000Ge-AK; Sat, 16 Jul 2022 15:20:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368795.600200; Sat, 16 Jul 2022 15:20:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjaw-0000GX-7e; Sat, 16 Jul 2022 15:20:38 +0000 Received: by outflank-mailman (input) for mailman id 368795; Sat, 16 Jul 2022 15:20:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjau-0000GR-UC for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:20:37 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d6254a59-051a-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 17:20:35 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26GDT2fw016366; Sat, 16 Jul 2022 15:20:23 GMT Received: from eur03-am5-obe.outbound.protection.outlook.com (mail-am5eur03lp2051.outbound.protection.outlook.com [104.47.8.51]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hbpq60nx5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Jul 2022 15:20:23 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by HE1PR0302MB2682.eurprd03.prod.outlook.com (2603:10a6:3:f5::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Sat, 16 Jul 2022 15:20:19 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5438.020; Sat, 16 Jul 2022 15:20:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d6254a59-051a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I70TF1oCO8RVwduXeAKQSY56qH/qEAQAcxcdmLN8nnoMJVPBkDCFIQEr0WeSito8dGrNvdRwtVG/CnFld19bAZqQiZ5cxaCt/DYO+jYvuu/972DJ/R2/qPlNFNqkHoIJmEg9xlnNmJxP3MpXW5C7zOk4ZZLa4FwDIJcA0jzrDtTH8MXw6kHcTQUJb6yn18z1UvAriZAAKRgqBZ3eu6RGRX1JD9IG0EcbI3MKzZZ7RoANA+u7o1lDD3rtf//YxwM7SyCXX5Pbjwkt6xIzn8qXnUK57I9egWqGIfHcpTicip2A5miHeGnxyNMh6A/Bom7ZmvAPCc1Om16YKSUUfsK2zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pMdtZuGqM6Yn4z3iBA6jOwDfkIR17zhSR5ATfqdD4Ug=; b=JjMFXYdnsKXIqQxH8Rq5dfIAoR3fOYF1HeJqJ7Mk+rG68hIX88Ex/yCdf8QR6Fsill/qGT+wlOrub6Y0ZN8fkj5JNKP+yNUjippHHMAaIVAfRo6oKOUo1KDYqOMCpeidwfngRvJjvuQCROQYxSBMPvkjlxHyg9y/5BDmtwG+Zpdd0ihvWwFIq7hq1zoWSLbziHJrnyd7vMY7UBKJclVScPZIvSQUZ6MZjhGCqhN2mr/OMzfqZgbL/kDKnuyv6KbsXHBUKJT3+B/00eC57u1fGSCdm0Yo9BRMjkHFH9GjLHYzJ5bzYQmNoLgpaQ921M8JRL/nvHRLwvSQXoTRkWOCGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pMdtZuGqM6Yn4z3iBA6jOwDfkIR17zhSR5ATfqdD4Ug=; b=PX0jcnbxe2FbgAiRJfW2MAgp0pUcLega8krpnKuibqhUwcSI6zVumY8IEft8GjOZnw4XtzNyglShUE8oxflGpcyz+Okf1VS6BbMipeXtrh7rsVUTBsmR91YE52VLBDEDz7MR6W58kpO16Y6jWl9ALqYMvMFOFhZDSDnVA8ldddUWIDcuBY8XALz4a+3aufUo6PzBpl4DYoWtfwvAWKA7iky6iUABGz4YJJwreFqsuvxx0qeBJVnfDHsKfypKZAkPZVonUKeIp2sp8Sri9KSLayWmfgjIcqjeZoQ+cH0yaVuwcrAhBb9204+L9kzM6OUCjY+MBakJptlnnEcAz4katQ== From: Oleksandr Tyshchenko To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Oleksandr Tyshchenko , Julien Grall Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on Arm Thread-Topic: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on Arm Thread-Index: AQHYmSRblRf/ElMSr02W3irv+3b7ea2BGZ0AgAADNYA= Date: Sat, 16 Jul 2022 15:20:19 +0000 Message-ID: <9b2a088c-0996-8871-2c64-e2d8ffd48a83@epam.com> References: <20220716145658.4175730-1-olekstysh@gmail.com> <20220716145658.4175730-2-olekstysh@gmail.com> <89d03f62-cc43-663b-bbfb-5341498f55a7@xen.org> In-Reply-To: <89d03f62-cc43-663b-bbfb-5341498f55a7@xen.org> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3839cb45-9428-45e6-5b71-08da673eb19c x-ms-traffictypediagnostic: HE1PR0302MB2682:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: e2aSdAn6BTHJKS+zgvmB7bORYN0ompBabDRd5zJBaRykv65+ih/dRtrimkHAD+Gvh5x/dEZXGUxCY1hj8cM1UcbveJCJYPSsfPDmAhK63B644BAN0L5oqxZbEiyRkLShop+bCpoTtOdPbf3x2wzr6Cvms1FsRweF8ssGUO1QYyzsYY49+Hhm71ZD+0E7CiO/l5PHMLZMfEh60UJLgRU6vm6yh4BuGVBprkFlTCN7n3aiEapipvyOSYIzW/p4ewQZiVmHsH4nBQ9VQX34I03ILv6jcnP2eAwJjWNJEHbyE3tLsIwmAFR1bxSlvlECcW2XxloG8jAivI3g9b5FcDeXY7/5xm34AuHuXsQFf7d0+uMZZ3UPvy/wEEkeXlvXDXXSe5OpBooiPVvbJpfq58WKxDgCbV9Z7rJcsYSbBz0kr7KpZAwS4ThGYJ/xfqmAu27Pcw1FYRb1J2nyraJk7av0XU2GtFj7VY+SrsIkoatGnDxBaom2/Sz9HjE3MnqJwV8+5P97vX1Sgfwgol0Vgg9q2LeYMcoprmrCou5nUFVJ4EiiE3GrgB2Eon7B5mrM6bYOrbcQWBkXsrYASoCRONJawgsQ96VN7ERNNGd8vvY9ZOWDMQ/pmmLO8PWUTxPJ1p7gDOJfNeHbYbkuuX05focgl4mMb8WyEYd5cmYUtPxLlF/JetTXeSnmy2FpxJYkLiiZ+6wrlAJIbCU0avh5W6z7Rr2/whWtS8z6564rf10vhHMswWwwPvjGK8LeromYUVx3HIm0dUCZCtbJlplJTMz+xc6WYmMGzJZ1c/kuA17SDyUrCm75CKCuMR4gCxchIgUucT7SR5EX9tNLMBgdFSPli1ydCjHmPxc5L6lDVJo9DzA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(6486002)(71200400001)(41300700001)(31696002)(478600001)(186003)(6506007)(6512007)(26005)(2616005)(53546011)(55236004)(122000001)(38070700005)(38100700002)(2906002)(4744005)(31686004)(7416002)(8936002)(86362001)(5660300002)(36756003)(66946007)(76116006)(66556008)(316002)(64756008)(66446008)(66476007)(8676002)(91956017)(54906003)(4326008)(110136005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RmJ3ODMzcFBpaytIUnM2UlQ3MHBGcUNQRUhkMHVRQmliVEFZRTZBM21vTjAy?= =?utf-8?B?c2R6REVZcjhZd3JyM0hiaUNzYWJkcGtKSDJtOWNVQndpSUh6SGUrY2EwcW1S?= =?utf-8?B?MmJNalJWRzluOG85ak4xMjBtVVdqTmluNlMzUmN2NmxzZG5WZGFlZGlrQUhZ?= =?utf-8?B?M21JWWNXOEdOMVREOThzTUs4QTBFa3lsTkM3cVZEWlVHRTFWMWJvM0QvN2F5?= =?utf-8?B?MjBWMVRKWWp4VCtqbXZRTGVmMlo4YjFMS3pkMTE1OGxCSEg3WnlXVDJGaWRn?= =?utf-8?B?QUhMQlJFM2NvZG5ja2Jwc0d6d2FVbU9TNWVDRjc4N2RFSTZJajhkZjVFcWlJ?= =?utf-8?B?MitQdXkxQTJtdXl0MWMybjhBeEhYakFUQ3ZTRDNEaTBGTXpoem0rVndMd3hx?= =?utf-8?B?VWEwRE9wSDU1RVJETFRWVVhjM3kzc2VKbCtBMDNEUmdNMnltOCtDZlpVQjZP?= =?utf-8?B?Tm5yM1dEREhZYWhrOHVyM3NQWkY1T0FZTUNWbXhPUEpmRjVpVm1acTJydzVW?= =?utf-8?B?MS95Z0VSUEIwdk1GY05RVnNGTDI4Q2NWV0ZyMkZoWmY3VXpiaDA4U3Z1aHVT?= =?utf-8?B?cldXbEc4anlvbm16K1M4enkwMHlsem41ci9OOGlqUzQ3U2FIV2RDMTB0azNQ?= =?utf-8?B?QlZmUWpnbHFGNkYxcmhabGREU2xHcEZVb1NHazlSek5KdDBhRUNvSUxQdDBo?= =?utf-8?B?Ny9lWGRyRXYwZEQyWFJhZEpaSTE4UWx6SGV4R1hOalA1d1M4SGwrOTkxRTNa?= =?utf-8?B?THE1OEFxZ0E3SVMwM3M0NTk4TEpwK1VSTDZldzBCVDlReXpPREZvM0pCYTdm?= =?utf-8?B?UENQYjdTNC9udXI2a3ZvZWdCWEl2NFFtaWZSR2lQWDArN3NXeDkyZE90YVdz?= =?utf-8?B?UWkrNllmN2hNY3RmamcvUWtua3J5NFNEWUxrOGRqOXlVNzJ2Y1hGSjVPb0d0?= =?utf-8?B?RGQ4R2VzRHI2TzRXZGQ1Zm1Cd0NWVGRlTkRnQVJFKzRpWEUvaHVUUlNuSG5x?= =?utf-8?B?Z3lKOEdqbDVQclFsL3VRcTl2byt3RkgwR1N1eFdZRUR3K1ppL2d2eUNyV3I0?= =?utf-8?B?VVNKbU00U0FGbkhZR1J3RVlTYXkvUXpCaHErWWlRdnN0TjczYXcrdnRSQU4z?= =?utf-8?B?cCtWenFpdHk1SkZsMHVXRXcvZ05XclhQaXdwcU00OHROOGI2d3dBV3ZGbENL?= =?utf-8?B?bFU3bllSNk9NYXEyMXozWjlocXB0NCtWQ1VDa3JJOFhCdzhOSFhrY3prQjJR?= =?utf-8?B?L0dDR2o2b01KTmZYNGtzbVRjelk1WGZOYzdEMWk0ODNwTm1vT2liMC9rRFJt?= =?utf-8?B?SVI4R0QydzZwN25Mb1B5MkJocmxzVTEyOXhJNzhjQ3ZRalpxYmI2THhCdzBs?= =?utf-8?B?OVY1Z3JtRHBmbXFXL2xzQlhYN2FRWUx0UkxFNW9wcSswVm9MVExGNCtOOEEz?= =?utf-8?B?aTJPejdUWGZtYmpqSUprdGFsZzZmUC8rd1d6akJqV1ZLWk95cEpBa0dDd1k2?= =?utf-8?B?Wjh0NkFCRkdjZHdTSjNSKzNud3FmeWQrY1FZSlJudUlKUnZENnEwV1dGVHVj?= =?utf-8?B?ME52UkpvTnBoUkpNajAzdzUvMGE1ZjJTYTFrRXR2b0RWL3hsMFVvOWdsNnNW?= =?utf-8?B?RTlUbmZ2SjcrM00xeDRrZ1NyU0RmZXdPdmNxc253UnM4YlRxOGZSQlFVUmtR?= =?utf-8?B?QVZuckdEYjA1WmtsZFh1SlEyRGxTR1VVU3kwR2ZGT1NBVHFxSHluMndNS2l2?= =?utf-8?B?UDQwRzRJbGZDSHM0N0Vhbmp1cWN5VVRIQjdxbHFBRG83eXlJWWJkRWs0TElR?= =?utf-8?B?dVdTcXFVK1htRVBpUG8xd0Y3UkpIdEJtMFBGTmFab21CYm83UXdNTlBLeGtK?= =?utf-8?B?bmdRRDRwSlphQ25kMGxlaTZrT1hhM1NaYmh4NzdoQVR5Vlk5Q0sza2ZIOS93?= =?utf-8?B?RXJjWHRlTnZaa24rOWdrRWpxVkZrT1pPdUVBL3ZEUnJvVFpwVmp6RmZna2VO?= =?utf-8?B?UzBTQWxUTC9aT2N1VjdXZDFqNlBWazFyRnQrVUpQenRTK1cvUnJFdXhBbHFQ?= =?utf-8?B?cE9xRWxReHhnMllGOUxhTDZiK2N5amRubnpDMzlSR3YzVHI3RDZVOXdTaFNM?= =?utf-8?B?WEFSOHcrSUlLZzBzQmZjQk9uLzNkVFNOT245RFpSVkp3a0VyZUplM05DWDJL?= =?utf-8?Q?lhHzyG4TV3L1IxAsFYp6cSY=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3839cb45-9428-45e6-5b71-08da673eb19c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2022 15:20:19.1169 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Rox/UrSc3pXc0Kahy9KqAIu5DI0HvHlqo8msImTadyx5UuMFmn+V8OEec345b3sb9fCZK2WQRmHAv9fCO/WqPQxg7FMIfZsDs53wWhDPaZ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0302MB2682 X-Proofpoint-GUID: Jy9SJFo8fzba9tEgpBS7gBHja71GFk2q X-Proofpoint-ORIG-GUID: Jy9SJFo8fzba9tEgpBS7gBHja71GFk2q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-16_11,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1011 mlxlogscore=590 adultscore=0 phishscore=0 suspectscore=0 lowpriorityscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207160066 DQpPbiAxNi4wNy4yMiAxODowOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs DQoNCg0KSGVsbG8gSnVsaWVuDQoNCg0KPg0KPiBPbiAxNi8wNy8yMDIyIDE1OjU2LCBPbGVrc2Fu ZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+IFN1Z2dlc3RlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3Jh bGxAYW1hem9uLmNvbT4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxv bGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4NCj4NCj4gUmV2aWV3ZWQtYnk6IEp1bGllbiBH cmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQoNClRoYW5rIHlvdSENCg0KDQo+DQo+PiDCoCB4ZW4v YXJjaC94ODYvaW5jbHVkZS9hc20vZ3JhbnRfdGFibGUuaCB8wqAgNSAtLS0NCj4NCj4gVGhpcyBj aGFuZ2VzIHdpbGwgbmVlZCBhbiBhY2sgZnJvbSB0aGUgeDg2IG1haW50YWluZXJzLg0KDQpZZXMu DQoNCg0KSmFuIGhhcyByZXZpZXdlZCB0aGF0IHBhdGNoIG1hbnkgdGltZXMuDQoNCg0KPg0KPiBD aGVlcnMsDQo+DQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:29:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:29:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368801.600211 (Exim 4.92) (envelope-from ) id 1oCjjV-0001KW-4s; Sat, 16 Jul 2022 15:29:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368801.600211; Sat, 16 Jul 2022 15:29:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjjV-0001KP-2A; Sat, 16 Jul 2022 15:29:29 +0000 Received: by outflank-mailman (input) for mailman id 368801; Sat, 16 Jul 2022 15:29:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjjT-0001KJ-EF for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:29:27 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12c4fac7-051c-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 17:29:26 +0200 (CEST) Received: from pps.filterd (m0174682.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26GDSElm022600; Sat, 16 Jul 2022 15:29:20 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2052.outbound.protection.outlook.com [104.47.9.52]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hbns20pke-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Jul 2022 15:29:20 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM6PR03MB3797.eurprd03.prod.outlook.com (2603:10a6:20b:23::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Sat, 16 Jul 2022 15:29:16 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5438.020; Sat, 16 Jul 2022 15:29:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12c4fac7-051c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l6hVNrDLpff8Q07sx0AuaER5zQBZIqI+7N7d4TEVrrq8xPHRUtqCb5yZHsxMG9jfT64MF5SGVxfwKJqLi917MK5e5zGTdo1wJAkKZvrr6QlmLV9z4/7t8AF0qEH2fdI7Striri18T1pfEjK2BKLE9kQmzQNna199z9UabzYopB/2z+o9lqYpBIJk9kWFwToL+GNgMJPvJV6kv+wIPkzBj/tNiU6LnPfk5o5psJctiE2Y5hikbngjdC9hpjkM4iqppC8oMF1e5FBbM4icQgPH2D/2tsPvMw1XCVTXbhT/3IsTvxbcyIvarhVS1Iy/pCUtulzpJMcLIyyfpOqrkWWd7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6xshPb5lPc/HAxThS2vp8lPrOIubeqM3CHtihU+Px9Q=; b=X49xPLm6PYUThVTTHb/IOPpr106mu89JBMO9qjKfKsAkMx6zCMB571V42idLGhfiaj8wz/J3U5dcGua6MQ7EcRnHs18RtcJ0+BNG9DAuJLIaBLHa/ky/2SgX5Iwf78H/hqWHFu8UedgGDPES6OrMcjAya9UmGo4+7a5yvb3vfagfo0Rl6BF/od2/5mvB1TiyFPlUXzMc7E0ut9Vsa9ReMqderneUMQGeVY/47+xuPvtBKeAltfZBtanaPYFHLRB3pQPlLFb5R6HZMxRL/5kVqtWiSFJlMWSsdpeDIf3UUW8LP9cOa/G2Ss7HUMaq7XQ+dPmoGDv6qsaJIt10TI/IpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6xshPb5lPc/HAxThS2vp8lPrOIubeqM3CHtihU+Px9Q=; b=lxWgXSkBFvKZevoUsaq67M6JzeNS8wuAQOFPHRLeoSna8IYrxUHm0mp9L2pYuTe9eScj/h7W8g6aKz1h9wF9CKrra+Q4n61jqWLy3RYLWMYd7kET16ffmeQWAkdVAIBCZVyf5+wW24C36VZRlx+Ja6RlCPDvU/14f9EB0Zlpwv4MXYO5BnXea+MLO+uvCay6tNoR6LxLAUhyLiYS12vAuIMswNTLjiUafQANN2OZzs/2AS04xAAO+qREOpBYLIeAH90+lcdoyWf2TL/JXkOQ794AcUjHCbkxTp+bH/0PFziQNKLKL4wFoytL6ufgsYq+5kiKa9zgS7CQi5Wx/votZA== From: Oleksandr Tyshchenko To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Oleksandr Tyshchenko Subject: Re: [PATCH V7 1/2] xen/arm: Harden the P2M code in p2m_remove_mapping() Thread-Topic: [PATCH V7 1/2] xen/arm: Harden the P2M code in p2m_remove_mapping() Thread-Index: AQHYmSRZ9DGrhwhfOkObghuNT/IAia2BGPyAgAAGWIA= Date: Sat, 16 Jul 2022 15:29:15 +0000 Message-ID: <7960855a-5135-00d9-fff8-b571d7be03d1@epam.com> References: <20220716145658.4175730-1-olekstysh@gmail.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fdd8380-bbe2-4f7f-772f-08da673ff182 x-ms-traffictypediagnostic: AM6PR03MB3797:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7cjKkk3whdmTONZmUP1AJjnjVRrhAoA1dPIWsrYI/6DspPfRojwAh0Y+ArEiW6QfWsRoWbbDIP0QQGxGeUhAQa6WCY0n8SAjiBlaQeByo4jpsvhQzwIqvhR0JbIEWbsG0VM293Clz1YJxL3hg5998O8yhXqtqb9sDem2FOtUf4vHXZctVXrmDgGiSqLGECCtjfNU/R7b8uI7CBs4ilw59SVze8VgnCGQu4YSaSmEjNi60a7rYaIvJRhxtTp4gbzK7JJz4m1EZh+GnrjbUkmlTaeUC+iGlkhGKrwiPr40vdyyoRHht+XReSTlhuyN8aDnNfC0Ywl4+oBlPgMjtU2XQP0waN2146Wda8vYiasgcy6+h45N4liJyQ2JHXoOQZxjsYZwj3w3+IiOTvbG61qmaz5/qQQhq22DETkTlilYH+jTXMvDqUNMd45cf2rTJuQDx94dg51zkkPkn0Vlo+qAzVOpxMzDeK+2q7UDVLH+KYCUoptruGuDhroDHsbUg0n/Xk6Sxuj2s3U9KwqMeefYldFxGPopX2fm+mbXPNyyT+C4Hg+Uquaqkz2oVpgujCaMESDTwfbfYFRhjTGy8c/oyYs+D+rtuBkuHOKjwdCHPLlEIrtlujB9lWpdDN0SxrwGczpYr4FDqvxkzuTUdhz2dzLxquSjQdNnhcq9AdgleX7fjkspVS5NFeflNSnyK74J0e1a/hre+cOpTdOkdeJ9ks7DBQ7ULAhogF6DA2/zhbEr46CaC24UbfkLjgrXCCHjelKna7uGV23rv+a3w50eYxGtLnv5Xn6OCVGDuGWK9ygC8yFrvEERooy0QiiNcu8+TaO7SYq2HpTIKcKRNndGfTjhAmbC/e3TksTf1qLwQlUB98ZvbfXWEATCth+76lFb x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(71200400001)(122000001)(316002)(38070700005)(86362001)(5660300002)(31696002)(38100700002)(110136005)(2906002)(76116006)(54906003)(66946007)(83380400001)(4326008)(2616005)(66446008)(66556008)(64756008)(66476007)(478600001)(8676002)(186003)(8936002)(6512007)(6486002)(55236004)(6506007)(53546011)(91956017)(26005)(41300700001)(36756003)(966005)(31686004)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T2d1cVVKUFNZUC90cVBYaXRWQ3BHdDU2a3ZIdDUzeTNmREdMWXhDNUVXQmpN?= =?utf-8?B?M1htU09oNlREYVcwZzNuWE8zNEovOEt3a3RiVG1zTUhVL242N1dENmdHQVoy?= =?utf-8?B?OEQ1MjE3VUZOcUV3TWd0Rjc2eFM3U296TzNwZXgvN1JUeUNsQXdwb1o1Vkln?= =?utf-8?B?WExyUThyNmF5TDZaeWRVTVhUaVVFYnQxeTg2T2VWTmxPZjhvVlBJNnFaK1VG?= =?utf-8?B?QlpwYjlya2Z3bTMwTVducTBNQitJTWc5cE9yc2ZOdW1JakhMYzVCWWpObXB0?= =?utf-8?B?cklFZU1KbVlWcTNIdUk3MGhWZ3pjUWk5T1RiaGExVC80ZW04aDFkdUhOakVP?= =?utf-8?B?NTVjS0lZTWs3bnF1NGppc09zUDF2WDdJUFpkL3ZlQ1J4QjB0aHA2a0NUak5E?= =?utf-8?B?ME01MzA2SUE2SnE5MFlEbDFDMGF0WjJPNnBObDRQd2Rla1hNbVdseW5MUWZy?= =?utf-8?B?OE12NmhlNVJJLys2WDFPZWRVK0hsa3VDd1pQaDdKbnNId3ZOdmtlalArbFZY?= =?utf-8?B?ME02TjNwRXV3SEI2YjRyVlRjamlUMjZoWjVTRm4rOXByTjJqWUd6WmQ1QXlt?= =?utf-8?B?c0JXUzdTN0JLR1lPQ3dPZEkraG9IVFFXaFhxWFN0RXowWlFLb0pGa0puaVpm?= =?utf-8?B?K2tScE5SdFVmTDF0U0N6Zy9YbWt1N1JPSGFOcmFHVVdnT3c1amJzazE1NlFM?= =?utf-8?B?Y29WTEdLYzJTc2NRTVFHU0RwdllYaWNXL3ZkdE44UGY5OWtndWhBNGJmbzN1?= =?utf-8?B?MmN2aHhJdUoxcUFPUGc0TFdmRkE2c2phcjNVekxhdUFERm1RVi9GTHFUS2x2?= =?utf-8?B?ZFRubU03TEhiZUhqVGR2WmFGSnY2UXlFcm05YWNiZ1VYc0ZhNmRqcGFKc3c2?= =?utf-8?B?MXlFUUtuaEs2Q3hOalovbFFGMlJaN1VHMmN1KzJSZGtZc3Niem1IRzdCdzFL?= =?utf-8?B?dlgzOStvWjNIQXVvcDFkUk92Q2U2L3JIc0dsT3lScXk2NmNUUzR5Q0wvc25I?= =?utf-8?B?blovVk1mcldFdXgzY2NtZlF5UjJxdCtzQXVUc0dQY2YxelF3TlRqQm5rczYy?= =?utf-8?B?MWJlNTJyYjM5UDVJa0dVRFRSbGJ4dnpZdHVoKzRBKzdUbDFja012bHJ5blVp?= =?utf-8?B?OERSaTBaQldRUnRvdGpYbUNBL2tMVHcxbll2VDlraHkvVjNYSFcvUlVwWU9y?= =?utf-8?B?dW1hTnd3N0JUYXdKYTdoMG1vRzVpRXE2NXZPYnJzWVFucHZqWFJpRW5iaWtC?= =?utf-8?B?TlBhUlBjOEJ5VkpnZGVBZXdLaUFnMXYxeHA3ZHlUeDcycDU0MTQyZ3YzejJn?= =?utf-8?B?Q1FwNm9sVWw4NUkrckNWdTI3MTlnaktPSWVUaTdCclZsQWJwd3M5NE0rNDBC?= =?utf-8?B?R2RLWTZuc0FCNm9wckJoZEpZbjhvTlRvN3pUUWhGVTJqcndPcW5zTXJDZGVW?= =?utf-8?B?ZUtrQ0VzQk92UFpKK1E3VVk4cGFkd1pIQ0xIenV0THRabjhOMStON1RtYkNF?= =?utf-8?B?WU9mVDViK0R1eTJhaStXWkpCL3duMDMwL0hZZG5JMk1FdTY3MlRXcnBRcW5X?= =?utf-8?B?dkVKeEQxcmdUUnZYWlhBNzcvUUJnTFdZOWtyV2RLdDZyNjFFV0p4eTZRdEdU?= =?utf-8?B?eVNpemVBL2JwUUIxaTFwOG9DMmpwVGZnUEN1UTZEZDY3ZGFXTXZ4ZWNva0NV?= =?utf-8?B?Tk5pWmlJU0lmY0kvNkNhbVdMS0E2ZExOR1E4TUlhZEZ3Q05PWUwzcmFWTG5r?= =?utf-8?B?cXYzTFpFbWJJN29QQ0pIQy9IVnRidm45TG1neDhtc1h3YW4ya2tnM3lGcHVO?= =?utf-8?B?blZ4VzVvL2VMeWl6cnNWcG9WRDBGeVoxWGREUVZ4NEpKeHV4T1dnM00rQ2ND?= =?utf-8?B?NTFzNnpRbDFUM0RVSi90clhFN3h2dE11QnpKUE5yMUl6d2ozaXFaa3NKODMx?= =?utf-8?B?SWZFUkcvSVZrdUJXMGpOQkZtcXRaaWdydkhYV3hQcHZwcjkxdFI0YnhuOGtT?= =?utf-8?B?S1IvNU9DMG9LamRlNFlaV3VNcVlWLzlPZXRZdDVKY09weTBQSm5mZ281OUxP?= =?utf-8?B?cDRmSHpoTmVuVTBhYVpGcHJFbVNIQWU1MDk0RWhsM3dKa0ZERmN3eFpTY2lt?= =?utf-8?B?OUFNazd6NkpPVGpTSU5GbmlzUU1LN3pzbUIyNEVuMTRlVGRZbVpvS2puL2hu?= =?utf-8?Q?lwkxMrdZvdK7172GPsJZeaE=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <66C355C7875E004A804D4DC0720F8214@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fdd8380-bbe2-4f7f-772f-08da673ff182 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2022 15:29:15.8650 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YQmBkNEnuoXeJnTfSGmwkMalEP5LSRdM+ar6PSVlKC5Tmy6KnyWqxR5QxpQ1oRM5iu3v/IHNm4j1AAZKP3lUVu3B2JxmnHiAH2UoQJpiJYI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR03MB3797 X-Proofpoint-GUID: A-C4dze16qQ3_7WNkCd6ECjd0g42JSk1 X-Proofpoint-ORIG-GUID: A-C4dze16qQ3_7WNkCd6ECjd0g42JSk1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-16_11,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207160066 DQpPbiAxNi4wNy4yMiAxODowNiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBIaSBPbGVrc2FuZHIs DQoNCg0KSGVsbG8gSnVsaWVuDQoNCg0KDQo+DQo+IEluIHRoZSBmdXR1cmUsIHBsZWFzZSBwcm92 aWRlIGEgY292ZXIgbGV0dGVyIChldmVuIGlmIGl0IGlzIHNob3J0KSANCj4gd2hlbiB5b3UgYnVu ZGxlIG11bHRpcGxlIHBhdGNoZXMuIFRoaXMgaXMgdXNlZnVsIHRvIG1ha2UgZ2VuZXJpYyANCj4g Y29tbWVudHMgYW5kIGhlbHAgdGhyZWFkaW5nIGluIGUtbWFpbCBjbGllbnQgKGVhY2ggcGF0Y2gg d291bGQgYmUgYSANCj4gc3VidGhyZWFkIG9mIDAgcmF0aGVyIHRoYW4gMSkuDQoNCg0KWWVzLCB3 aWxsIGRvLg0KDQoNCj4NCj4gT24gMTYvMDcvMjAyMiAxNTo1NiwgT2xla3NhbmRyIFR5c2hjaGVu a28gd3JvdGU6DQo+PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hj aGVua29AZXBhbS5jb20+DQo+Pg0KPj4gQm9ycm93IHRoZSB4ODYncyBjaGVjayBmcm9tIHAybV9y ZW1vdmVfcGFnZSgpIHdoaWNoIHdhcyBhZGRlZA0KPj4gYnkgdGhlIGZvbGxvd2luZyBjb21taXQ6 IGM2NWVhMTZkYmNhZmJlNGZlMjE2OTNiMThmOGMyYTNjNWQxNDYwMGUNCj4+ICJ4ODYvcDJtOiBk b24ndCBhc3NlcnQgdGhhdCB0aGUgcGFzc2VkIGluIE1GTiBtYXRjaGVzIGZvciBhIHJlbW92ZSIN Cj4+IGFuZCBhZGp1c3QgaXQgdG8gdGhlIEFybSBjb2RlIGJhc2UuDQo+Pg0KPj4gQmFzaWNhbGx5 LCB0aGlzIGNoZWNrIHdpbGwgYmUgc3RyaWN0bHkgbmVlZGVkIGZvciB0aGUgeGVuaGVhcCBwYWdl cw0KPj4gYWZ0ZXIgYXBwbHlpbmcgYSBzdWJzZXF1ZW50IGNvbW1pdCB3aGljaCB3aWxsIGludHJv ZHVjZSB4ZW5oZWFwIGJhc2VkDQo+PiBNMlAgYXBwcm9hY2ggb24gQXJtLiBCdXQsIGl0IHdpbGwg YmUgYSBnb29kIG9wcG9ydHVuaXR5IHRvIGhhcmRlbg0KPj4gdGhlIFAyTSBjb2RlIGZvciAqZXZl cnkqIFJBTSBwYWdlcyBzaW5jZSBpdCBpcyBwb3NzaWJsZSB0byByZW1vdmUNCj4+IGFueSBHRk4g LSBNRk4gbWFwcGluZyBjdXJyZW50bHkgb24gQXJtIChldmVuIHdpdGggdGhlIHdyb25nIGhlbHBl cnMpLg0KPj4NCj4+IFN1Z2dlc3RlZC1ieTogSnVsaWVuIEdyYWxsIDxqZ3JhbGxAYW1hem9uLmNv bT4NCj4+IFNpZ25lZC1vZmYtYnk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlz aGNoZW5rb0BlcGFtLmNvbT4NCj4+IC0tLQ0KPj4gWW91IGNhbiBmaW5kIHRoZSBjb3JyZXNwb25k aW5nIGRpc2N1c3Npb24gYXQ6DQo+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6 Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzgyZDhiZmUwLWNiNDYtZDMwMy02YTYwLTIzMjRk ZDc2YTFmN0B4ZW4ub3JnL19fOyEhR0ZfMjlkYmNRSVVCUEEhM2EydS1YTDROdkF6U01mejcyTEFS cmRXVkZ2cTJJbjVacFVkeFAyY1N0N2JNOFBnVjdQX1pjbFpHMlItckU5UGNvc1VIeXFzS1JOZlZH MlRpTTlUbGckIA0KPj4gW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+PiBodHRwczovL3VybGRlZmVu c2UuY29tL3YzL19faHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcveGVuLWRldmVsLzE2NTIyOTQ4NDUt MTM5ODAtMi1naXQtc2VuZC1lbWFpbC1vbGVrc3R5c2hAZ21haWwuY29tL19fOyEhR0ZfMjlkYmNR SVVCUEEhM2EydS1YTDROdkF6U01mejcyTEFScmRXVkZ2cTJJbjVacFVkeFAyY1N0N2JNOFBnVjdQ X1pjbFpHMlItckU5UGNvc1VIeXFzS1JOZlZHMGtnN0laU0EkIA0KPj4gW2xvcmVbLl1rZXJuZWxb Ll1vcmddDQo+Pg0KPj4gQ2hhbmdlcyBWNiAtPiBWNzoNCj4+IMKgwqDCoCAtIG1ha2UgdGhpcyBj b21taXQgdG8gYmUgdGhlIGZpcnN0DQo+PiDCoMKgwqAgLSB1cGRhdGUgY29tbWl0IGRlc2NyaXB0 aW9uIGFuZCBhZGQgYSBjb21tZW50IGluIGNvZGUNCj4+IC0tLQ0KPj4gwqAgeGVuL2FyY2gvYXJt L3AybS5jIHwgMjggKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KPj4gwqAgMSBmaWxlIGNo YW5nZWQsIDI4IGluc2VydGlvbnMoKykNCj4+DQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJt L3AybS5jIGIveGVuL2FyY2gvYXJtL3AybS5jDQo+PiBpbmRleCBkMDBjMmU0NjJhLi4yYTBkMzgz ZGY0IDEwMDY0NA0KPj4gLS0tIGEveGVuL2FyY2gvYXJtL3AybS5jDQo+PiArKysgYi94ZW4vYXJj aC9hcm0vcDJtLmMNCj4+IEBAIC0xMzA4LDExICsxMzA4LDM5IEBAIHN0YXRpYyBpbmxpbmUgaW50 IHAybV9yZW1vdmVfbWFwcGluZyhzdHJ1Y3QgDQo+PiBkb21haW4gKmQsDQo+PiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIG1mbl90IG1mbikNCj4+IMKgIHsNCj4+IMKgwqDCoMKgwqAgc3RydWN0IHAybV9k b21haW4gKnAybSA9IHAybV9nZXRfaG9zdHAybShkKTsNCj4+ICvCoMKgwqAgdW5zaWduZWQgbG9u ZyBpOw0KPj4gwqDCoMKgwqDCoCBpbnQgcmM7DQo+PiDCoCDCoMKgwqDCoMKgIHAybV93cml0ZV9s b2NrKHAybSk7DQo+PiArwqDCoMKgIC8qDQo+PiArwqDCoMKgwqAgKiBCZWZvcmUgcmVtb3Zpbmcg dGhlIEdGTiAtIE1GTiBtYXBwaW5nIGZvciBhbnkgUkFNIHBhZ2VzIG1ha2UgDQo+PiBzdXJlDQo+ PiArwqDCoMKgwqAgKiB0aGF0IHRoZXJlIGlzIG5vIGRpZmZlcmVuY2UgYmV0d2VlbiB3aGF0IGlz IGFscmVhZHkgbWFwcGVkIA0KPj4gYW5kIHdoYXQNCj4+ICvCoMKgwqDCoCAqIGlzIHJlcXVlc3Rl ZCB0byBiZSB1bm1hcHBlZC4NCj4+ICvCoMKgwqDCoCAqIElmIHRoZXkgZG9uJ3QgbWF0Y2ggYmFp bCBvdXQgZWFybHkuIEZvciBpbnN0YW5jZSwgdGhpcyBjb3VsZCANCj4+IGhhcHBlbg0KPj4gK8Kg wqDCoMKgICogaWYgdHdvIENQVXMgYXJlIHJlcXVlc3RpbmcgdG8gdW5tYXAgdGhlIHNhbWUgUDJN IGNvbmN1cnJlbnRseS4NCj4NCj4gTWlzc2luZyB3b3JkOiBQMk0gKmVudHJ5Kg0KDQpZZXMuIE1h eSBJIHBsZWFzZSBhc2ssIGNvdWxkIHRoaXMgYmUgZG9uZSBvbiB0aGUgY29tbWl0IGlmIHRoaXMg YXBwZWFycyANCnRvIGJlIHRoZSBsYXN0IHZlcnNpb24/DQoNCg0KPg0KPiBPdGhlciB0aGFuIHRo YXQ6DQo+DQo+IFJldmlld2VkLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0K DQoNClRoYW5rIHlvdSENCg0KDQo+DQo+DQo+IENoZWVycywNCj4NCi0tIA0KUmVnYXJkcywNCg0K T2xla3NhbmRyIFR5c2hjaGVua28NCg== From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:32:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:32:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368808.600223 (Exim 4.92) (envelope-from ) id 1oCjmI-0002mF-P5; Sat, 16 Jul 2022 15:32:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368808.600223; Sat, 16 Jul 2022 15:32:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjmI-0002m8-Jx; Sat, 16 Jul 2022 15:32:22 +0000 Received: by outflank-mailman (input) for mailman id 368808; Sat, 16 Jul 2022 15:32:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjmH-0002ly-Bd; Sat, 16 Jul 2022 15:32:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjmH-00083L-9f; Sat, 16 Jul 2022 15:32:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCjmG-0003NB-SR; Sat, 16 Jul 2022 15:32:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCjmG-0000y8-Rz; Sat, 16 Jul 2022 15:32:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vgqMc4NOXzoRKNWDkeRsQiMIdFPn//Yt52wGAVHZ1VE=; b=A4oiB8HDf+dLEnZj11nHsJNxo2 QdSlYZqxK4/0vMIsq9rfKNUibwQSEQp95phLvOpDVsgl2yQpBc4LkY/mmaHZLIKLfOGxKtoojJl0B 7R6UEpCIs8nMbb8RoIGecj1LImeF7VxB/DQSbG7je45j3WviK5/pelAVlhozzechE5Sc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171648: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-pair:xen-install/src_host:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=0ebf76aae58324b8f7bf6af798696687f5f4c2a9 X-Osstest-Versions-That: qemuu=8482ab545e52f50facacfe1118b22b97462724ab From: osstest service owner Date: Sat, 16 Jul 2022 15:32:20 +0000 flight 171648 qemu-mainline real [real] flight 171653 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171648/ http://logs.test-lab.xenproject.org/osstest/logs/171653/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 10 xen-install/src_host fail pass in 171653-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171639 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171639 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171639 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171639 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171639 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171639 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171639 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171639 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 0ebf76aae58324b8f7bf6af798696687f5f4c2a9 baseline version: qemuu 8482ab545e52f50facacfe1118b22b97462724ab Last test of basis 171639 2022-07-15 07:49:59 Z 1 days Testing same since 171648 2022-07-16 03:15:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Akihiko Odaki Alexander Bulekov Cédric Le Goater Darren Kenny Iris Chen Jinhao Fan Joel Stanley Klaus Jensen Mark Cave-Ayland Mauro Matteo Cascella Niklas Cassel Paolo Bonzini Peter Delevoryas Peter Delevoryas Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 8482ab545e..0ebf76aae5 0ebf76aae58324b8f7bf6af798696687f5f4c2a9 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Jul 16 15:55:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 15:55:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368819.600233 (Exim 4.92) (envelope-from ) id 1oCk8t-0005sR-Mv; Sat, 16 Jul 2022 15:55:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368819.600233; Sat, 16 Jul 2022 15:55:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCk8t-0005sK-J2; Sat, 16 Jul 2022 15:55:43 +0000 Received: by outflank-mailman (input) for mailman id 368819; Sat, 16 Jul 2022 15:55:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCk8s-0005rT-Ea for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 15:55:42 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bcbff6f1-051f-11ed-924f-1f966e50362f; Sat, 16 Jul 2022 17:55:39 +0200 (CEST) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26GDSGHk025845; Sat, 16 Jul 2022 15:55:34 GMT Received: from eur02-ve1-obe.outbound.protection.outlook.com (mail-ve1eur02lp2051.outbound.protection.outlook.com [104.47.6.51]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hbnh48t27-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 16 Jul 2022 15:55:34 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AM0PR03MB4305.eurprd03.prod.outlook.com (2603:10a6:208:c0::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Sat, 16 Jul 2022 15:55:28 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5438.020; Sat, 16 Jul 2022 15:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bcbff6f1-051f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EU1Njc9+2DurIE0E2b/ae85NQqfEFe6sEGVLur/93nJ2sqDG9KQ6YLSmQnPDfLoYDZo1BCALupVdtHolQ+jOaQp5nUqxqOYz059HNygjywjSJ4SQUi4uCuv/MDwF7nOa1X/2uY5imXdYlIwaFnpQZPPYeESIOy/UCyVRZQeCZI4M+Yn1Bhg1Okmaf/akZbS9fcIKhnmVcp8e72FmaxImNB3+ED3L/pz+2k9HYUAKZRLI7UCEfTlFAwqG+T0N1z7mT4U7fVAMkrpt/RSiMj16e4XyKq40UUn8s7zcGj3Zt9rfZ55XmDdwlGoblv9/oWs/rpOVM7BgWkX2KktzSUGFIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btePDiAM88NFpJagtvHPsjc+2cSx5GO/bLziVxhqff0=; b=EPii9M7iAr5E37zuRGpD4j9IKIfjQZsqTVcDGl7MCy1lYnxhaDipeewu0dIYapDqh463Fr/7tZLbq+s3q/zlaqNk4CIM/iYnJ7fkmEycXtFll6NamcJVDJFCEthURGfTwhgxy1rZQb7CccJFK6HXwwtIsn9uNu3z3HzxZmejQpiYkXPJkslWwh80OCKAG3HtDs8/KuOrpiuPIbq+eRBJ0yDgrkU5Y6WmgM+pyx3BOOmwr98zixAU9TF0enGepVc+RB/tSU6cdoO065tsfCa81M6OFDwo6sKK4deJ3OAvPBJamGM46iLBIDS+/xRC7xCYwYkcQYn8WYtPj2MagtzfrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btePDiAM88NFpJagtvHPsjc+2cSx5GO/bLziVxhqff0=; b=PWoRrtjG75Qio6mNU2bVZQxw8CoijQiB6bc5rfCOsp3DY1Jy1ubZd6R6EfigcHAtDGWOaoDwowC+yOljOAlIMtXR+aXGPxHsX3Y5OpLUtB1coe4sUIH6bU6Cwj3LtPV5L7+DnuXiSpIxN4+XlwDhiQgwt/MAoqBOrhpqrHpUZdSF8DDm4gNcK/iDq+gnHUfqSac/3JxUyGwMbwhgTV+LeEoXHHZiHCOkGCx4bbVUvcHjpQyNy3TCA1BQX6S9KjpB9aTgiMhHl/+zYmcYpqQeviilS54XNFf0B2OwQTUPpndmpNo30SoD4nfBpGpK7HLEPvMmT5Za5+FOwsRU2muTaQ== From: Oleksandr Tyshchenko To: "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Oleksandr Tyshchenko , Bertrand Marquis Subject: Re: [PATCH V11 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V11 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYmH/5Fy4H059mo02DmQSX0PsOXK2BJ++A Date: Sat, 16 Jul 2022 15:55:28 +0000 Message-ID: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> References: <20220715192026.4013441-1-olekstysh@gmail.com> <20220715192026.4013441-2-olekstysh@gmail.com> In-Reply-To: <20220715192026.4013441-2-olekstysh@gmail.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2239005d-e699-47e0-906d-08da67439ad6 x-ms-traffictypediagnostic: AM0PR03MB4305:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aVQQcKDujZS9EhG7YT+espWjqaeVq96OPXxTIZaBYMeRDV0ELkzUR1+dYwgcl476hhcJgjHqYfoPWuGVats7qVAjVkHcOKpvtDhxv/QaWOwADQRaFAZWybYz1KDkB0HxZGCL5iyaKbUusG1hCAtTuH2bm2BU6FAjSuWBpN4npiqNzZaPq2FC/dJVuyqFmS+xL1Hh5H6eFTvAf7+fe7uQ5/baJ9xE3Mp7eNcC2+Dnw8T2eGrHLxRfO4frmKQdhZ4QKc+8qqCeT/rLO0+9BDFZcTIWyGJIdvnU/+H5NsFAUUyuc29teS/QgQ3EkQGF70vqhN2fUlcVlOIlZxzij2SIkdCXKCHJzjiXe2z6El+Sfdys7sl8OKJ5H0xm7QdcxTKH7WecH1B27Jn+meQSdvx+IxbdkzaKnGUp8OujZ/IoovY86xPR34Df/4i9ETom+EAf0iMpuYJTwvFzuy/ZKHwjfehEGjsjhNz1AI53JzmWW2v43spsAemTh+uTKRN2XAZyVmRo7TvmAHT2oHpILxJf8f+ClXdLzlEeACuIGWWn2HfL/GdTlRMYzcdNa6q2hLLD4m2UkQqKmTGcpPuO7UA7lrrUKUG0MjqbIbfdgf90eMq3CBvAsXmmQFCAVa/ita8TzptA/QCdwxUDslDP5u5a8z3qSXB7aMHXEpH6BVVgmzBsv+A2kfH5dMcqotF2XMv3Y6VrpVfqlgMUhWNFKMto1YuPLyhj0+szukCZCCP6O7LyjTaofq5ZiyxHKwuIWKwWs72JkDVlrvaOXTyygqVTZdePG+2NdcMtFqwoz1Cje7qssgvZl6AUdaWno4L0+RvR5wgvOAMvOHKD+1YnBQiIxDABd09sx5REWEkup9wRLtE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(366004)(55236004)(41300700001)(53546011)(6512007)(6506007)(316002)(26005)(478600001)(91956017)(71200400001)(6486002)(54906003)(6916009)(122000001)(38100700002)(31696002)(86362001)(66446008)(64756008)(66476007)(2616005)(38070700005)(83380400001)(66946007)(2906002)(31686004)(66556008)(8936002)(5660300002)(7416002)(4326008)(76116006)(36756003)(186003)(8676002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UUp2UGQwRVBOeEhJVWdnejkydCtDN013Vmk0WFlJVlBDWWw3dnREVnErc0JH?= =?utf-8?B?Sk8ycFJpMVorWVJGeGZYL3p0OFFWbHc4Umt2bzdQbXlOUjBiOWt2dHduN01r?= =?utf-8?B?by8wMUxBb08rZGdPb2N3cHAxdi9SNGxoNGkveGFBc1hRNmdySUY5UGhwQzlv?= =?utf-8?B?U2dqYTBLWlZwZUpXODExRFhzOG5WdkJ2djNMOGs5R045eE1LcHUxbFlLZ0s0?= =?utf-8?B?SzA1NlBVb3VZSGFjS0JmT1IyVlhyOFMwL0pZSVpSbEZ3UE4wQnBFN2w2VGNl?= =?utf-8?B?WlVwYXlaYnY0b2lUaDIrRTF3dXBWa0ZoVnpOUllkWlVmSkhOd0NJQWZkZncv?= =?utf-8?B?RnFIRWsrc2UvbEEzR0VzeE5TUUpNNmpqa2poNDBLN3ZNcHhXcXZUYllORnFh?= =?utf-8?B?U3FUTDRTNnlrSFVBWklWQlU2bktzM2NDYzJkRFAvMlAva2w0eUZuWnFCS2Jy?= =?utf-8?B?YU9md0psbHh5QU1ld1AxZjVFZkZkb2VEN2xwaGtsZ0NmbHNDNXFZN05hTlVI?= =?utf-8?B?N0MzT24yeGtTUmRaRTN4bU9PYlQwd25UbkNzRE5vTGg5YS94aFFtT1pBMS96?= =?utf-8?B?cE4yMC9NNTZLQ3Z6dG5oeXRNazZOOHM3UjVveXNFOW9EdksrYXdLUUsxTWNz?= =?utf-8?B?QWlEZkxaU21PcGZWd3EvcTdTVkNzVzd4VjVwVlE0RTR4N0praEo2V242VGpY?= =?utf-8?B?UFR3ZVV6Ym0ranZvZEpvTzY0aHRNNlV5RmYycGFKYndtZjJ2UW9xdmpSK05m?= =?utf-8?B?NEdtRjZ5V0MxZk9KZU1yUUVWcUorSXlVWlVsSGhNZDdwUGhxd3NDeWx2NFEw?= =?utf-8?B?dGJhdHZjYkRYTXlwWjRHci9xemNOOWptdVFSTzBFVTY3TCtjMWVJSnRhQkZV?= =?utf-8?B?MHo3K21NZWRNckpqN3c2R1lVc0haZ2duWE5PWC9WYy9HMEgrcU1zQlZ2UGpH?= =?utf-8?B?TTdVbkwwRTF4eU1VQmw4UnhIN3ZrU0kzbm8vL0xuaWMvelNha1gvQURHM1lY?= =?utf-8?B?MVFrWDNYcEU3R0tBNjUvMnBwR2c1NTFiVmRFSGZ1T29hMndmZlVkUUtleUhI?= =?utf-8?B?UGlRMjFYS2lXUmFTZjFqRFZFUGVyNU9BcUlKUlliZkdZYzVBakllOTF6L2N1?= =?utf-8?B?a3ZMNnBnMnZSUVFsb05ORXJwL2NxbTRpRUY2OHB1UHZXYWFZSTZKVFc1L1Ar?= =?utf-8?B?SWVqV0dtZlVBSzBKQUhXcUFxa01memNiRG4vdWV3K1BoVnB5RVNwaEpZTHFH?= =?utf-8?B?UXVDaThjd0tDME1tWUhyMFBYSzRrbWJZMDFQU0ZqOU8yVEd1a2N3NE1pd0Ny?= =?utf-8?B?Sm92c0d3SWNuNk5QQWVoK2E0MVhOaDdZRm5VZ2lITTl2NWtqemhJODFBYzEw?= =?utf-8?B?eGJySjBONjgvWnNUTndwQXR4MlBMT3V5QXRzZDVzeU1LZGZSMnJWeFNaWFNo?= =?utf-8?B?YVU5NE0vdDRkQkxTaXUyTW9hWlJpTWtXa01xbVV0MW8xNjhaOXc0NWd6bzJJ?= =?utf-8?B?djkrSEo5bnJwa1VPaHdWemhQdTdIaXg0NG9wT3U0TlpLZEhOY0dvY0F5QmNG?= =?utf-8?B?N1JtMGRwUUpSUGx2T1lDOVd2aGQ2YURqWERuT0EzSUJqNkpOczA1MUh0ME5t?= =?utf-8?B?SUUycFFLNFdXSGZPWXU0RnBRTkNXR3MwWEo1Q2VtQTZkU0dtMGlzWlpyNm5w?= =?utf-8?B?ZkJhalBLNXdvTzhFSldkc2oyazRvV25GclBXQ3l5ZmhEWXJUZXFwQ1ZoUHYv?= =?utf-8?B?MGo5bVBUUG9sWVd1ZVJlWjZqajQvbEh2YjYxczFuSTVCM3hybkVpaERjNUp4?= =?utf-8?B?eHBsUkpzeVFYTWp1MFBVY3V4R3pYOUNFY2lyMDBjWkp5WW9uWkl1Tk13OCsr?= =?utf-8?B?SzNHODlnYi9XYlhRUHpVdU1aUWZwQ3FDZHJvMUNNMVVua2FHMFNCWHd1RUh3?= =?utf-8?B?QTdLb2l1eWZzNWk5UWZtZ0lwUURYQjhpS0pNdUFKblFOQ2xjbTFEQnd5SnhJ?= =?utf-8?B?ZGEvalRwK3VyUnh0dXZwWi9NR0Y0NTREQnQ2WU5XZFVoM05vUTFOaDhYeFkw?= =?utf-8?B?RnhXcHBId0RxdEQwTVZSOW9qWFNLRWpWUmhvQlF2VFRzNnFpdGdGYkY0cWc5?= =?utf-8?B?emErb3JEQU1JejVjbHY4Nkl5Qms1TWtjc1MxcXF3VDREODVRclBkY0lBallt?= =?utf-8?Q?SJFCZSmA+Wbw2vYSRrk09NA=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <8212DD36044FEC40AE5FDE62EF462B71@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2239005d-e699-47e0-906d-08da67439ad6 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2022 15:55:28.4256 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2FFKR4bZLGUBQHEPc9YCrqU+WddAaeYxlGSmJvO/tduOzrmAnDhUewmWQnkZC70m1Kp7WMOrjxt1AuVDg8WX0/aEBK/9g3WGFgFrRDLQNF8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR03MB4305 X-Proofpoint-ORIG-GUID: sJulxz2LfoYsVcfDS9GDeevHRhBNcGdc X-Proofpoint-GUID: sJulxz2LfoYsVcfDS9GDeevHRhBNcGdc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-16_11,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 mlxlogscore=999 mlxscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207160067 DQpIZWxsbyBhbGwuDQoNCg0KT24gMTUuMDcuMjIgMjI6MjAsIE9sZWtzYW5kciBUeXNoY2hlbmtv IHdyb3RlOg0KPiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVu a29AZXBhbS5jb20+DQo+DQo+IFRoaXMgcGF0Y2ggYWRkcyBiYXNpYyBzdXBwb3J0IGZvciBjb25m aWd1cmluZyBhbmQgYXNzaXN0aW5nIHZpcnRpby1tbWlvDQo+IGJhc2VkIHZpcnRpby1kaXNrIGJh Y2tlbmQgKGVtdWxhdG9yKSB3aGljaCBpcyBpbnRlbmRlZCB0byBydW4gb3V0IG9mDQo+IFFlbXUg YW5kIGNvdWxkIGJlIHJ1biBpbiBhbnkgZG9tYWluLg0KPiBBbHRob3VnaCB0aGUgVmlydGlvIGJs b2NrIGRldmljZSBpcyBxdWl0ZSBkaWZmZXJlbnQgZnJvbSB0cmFkaXRpb25hbA0KPiBYZW4gUFYg YmxvY2sgZGV2aWNlICh2YmQpIGZyb20gdGhlIHRvb2xzdGFjaydzIHBvaW50IG9mIHZpZXc6DQo+ ICAgLSBhcyB0aGUgZnJvbnRlbmQgaXMgdmlydGlvLWJsayB3aGljaCBpcyBub3QgYSBYZW5idXMg ZHJpdmVyLCBub3RoaW5nDQo+ICAgICB3cml0dGVuIHRvIFhlbnN0b3JlIGFyZSBmZXRjaGVkIGJ5 IHRoZSBmcm9udGVuZCBjdXJyZW50bHkgKCJ2ZGV2Ig0KPiAgICAgaXMgbm90IHBhc3NlZCB0byB0 aGUgZnJvbnRlbmQpLiBCdXQgdGhpcyBtaWdodCBuZWVkIHRvIGJlIHJldmlzZWQNCj4gICAgIGlu IGZ1dHVyZSwgc28gZnJvbnRlbmQgZGF0YSBtaWdodCBiZSB3cml0dGVuIHRvIFhlbnN0b3JlIGlu IG9yZGVyIHRvDQo+ICAgICBzdXBwb3J0IGhvdHBsdWdnaW5nIHZpcnRpbyBkZXZpY2VzIG9yIHBh c3NpbmcgdGhlIGJhY2tlbmQgZG9tYWluIGlkDQo+ICAgICBvbiBhcmNoIHdoZXJlIHRoZSBkZXZp Y2UtdHJlZSBpcyBub3QgYXZhaWxhYmxlLg0KPiAgIC0gdGhlIHJpbmctcmVmL2V2ZW50LWNoYW5u ZWwgYXJlIG5vdCB1c2VkIGZvciB0aGUgYmFja2VuZDwtPmZyb250ZW5kDQo+ICAgICBjb21tdW5p Y2F0aW9uLCB0aGUgcHJvcG9zZWQgSVBDIGZvciBWaXJ0aW8gaXMgSU9SRVEvRE0NCj4gaXQgaXMg c3RpbGwgYSAiYmxvY2sgZGV2aWNlIiBhbmQgb3VnaHQgdG8gYmUgaW50ZWdyYXRlZCBpbiBleGlz dGluZw0KPiAiZGlzayIgaGFuZGxpbmcuIFNvLCByZS11c2UgKGFuZCBhZGFwdCkgImRpc2siIHBh cnNpbmcvY29uZmlndXJhdGlvbg0KPiBsb2dpYyB0byBkZWFsIHdpdGggVmlydGlvIGRldmljZXMg YXMgd2VsbC4NCj4NCj4gRm9yIHRoZSBpbW1lZGlhdGUgcHVycG9zZSBhbmQgYW4gYWJpbGl0eSB0 byBleHRlbmQgdGhhdCBzdXBwb3J0IGZvcg0KPiBvdGhlciB1c2UtY2FzZXMgaW4gZnV0dXJlIChR ZW11LCB2aXJ0aW8tcGNpLCBldGMpIHBlcmZvcm0gdGhlIGZvbGxvd2luZw0KPiBhY3Rpb25zOg0K PiAtIEFkZCBuZXcgZGlzayBiYWNrZW5kIHR5cGUgKExJQlhMX0RJU0tfQkFDS0VORF9TVEFOREFM T05FKSBhbmQgcmVmbGVjdA0KPiAgICB0aGF0IGluIHRoZSBjb25maWd1cmF0aW9uDQo+IC0gSW50 cm9kdWNlIG5ldyBkaXNrICJzcGVjaWZpY2F0aW9uIiBhbmQgInRyYW5zcG9ydCIgZmllbGRzIHRv IHN0cnVjdA0KPiAgICBsaWJ4bF9kZXZpY2VfZGlzay4gQm90aCBhcmUgd3JpdHRlbiB0byB0aGUg WGVuc3RvcmUuIFRoZSB0cmFuc3BvcnQNCj4gICAgZmllbGQgaXMgb25seSB1c2VkIGZvciB0aGUg c3BlY2lmaWNhdGlvbiAidmlydGlvIiBhbmQgaXQgYXNzdW1lcw0KPiAgICBvbmx5ICJtbWlvIiB2 YWx1ZSBmb3Igbm93Lg0KPiAtIEludHJvZHVjZSBuZXcgInNwZWNpZmljYXRpb24iIG9wdGlvbiB3 aXRoICJ4ZW4iIGNvbW11bmljYXRpb24NCj4gICAgcHJvdG9jb2wgYmVpbmcgZGVmYXVsdCB2YWx1 ZS4NCj4gLSBBZGQgbmV3IGRldmljZSBraW5kIChMSUJYTF9fREVWSUNFX0tJTkRfVklSVElPX0RJ U0spIGFzIGN1cnJlbnQNCj4gICAgb25lIChMSUJYTF9fREVWSUNFX0tJTkRfVkJEKSBkb2Vzbid0 IGZpdCBpbnRvIFZpcnRpbyBkaXNrIG1vZGVsDQo+DQo+IEFuIGV4YW1wbGUgb2YgZG9tYWluIGNv bmZpZ3VyYXRpb24gZm9yIFZpcnRpbyBkaXNrOg0KPiBkaXNrID0gWyAncGh5Oi9kZXYvbW1jYmxr MHAzLCB4dmRhMSwgYmFja2VuZHR5cGU9c3RhbmRhbG9uZSwgc3BlY2lmaWNhdGlvbj12aXJ0aW8n XQ0KPg0KPiBOb3RoaW5nIGhhcyBjaGFuZ2VkIGZvciBkZWZhdWx0IFhlbiBkaXNrIGNvbmZpZ3Vy YXRpb24uDQo+DQo+IFBsZWFzZSBub3RlLCB0aGlzIHBhdGNoIGlzIG5vdCBlbm91Z2ggZm9yIHZp cnRpby1kaXNrIHRvIHdvcmsNCj4gb24gWGVuIChBcm0pLCBhcyBmb3IgZXZlcnkgVmlydGlvIGRl dmljZSAoaW5jbHVkaW5nIGRpc2spIHdlIG5lZWQNCj4gdG8gYWxsb2NhdGUgVmlydGlvIE1NSU8g cGFyYW1zIChJUlEgYW5kIG1lbW9yeSByZWdpb24pIGFuZCBwYXNzDQo+IHRoZW0gdG8gdGhlIGJh Y2tlbmQsIGFsc28gdXBkYXRlIEd1ZXN0IGRldmljZS10cmVlLiBUaGUgc3Vic2VxdWVudA0KPiBw YXRjaCB3aWxsIGFkZCB0aGVzZSBtaXNzaW5nIGJpdHMuIEZvciB0aGUgY3VycmVudCBwYXRjaCwN Cj4gdGhlIGRlZmF1bHQgImlycSIgYW5kICJiYXNlIiBhcmUganVzdCB3cml0dGVuIHRvIHRoZSBY ZW5zdG9yZS4NCj4gVGhpcyBpcyBub3QgYW4gaWRlYWwgc3BsaXR0aW5nLCBidXQgdGhpcyB3YXkg d2UgYXZvaWQgYnJlYWtpbmcNCj4gdGhlIGJpc2VjdGFiaWxpdHkuDQo+DQo+IFNpZ25lZC1vZmYt Ynk6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0BlcGFtLmNvbT4N Cj4gLS0tDQo+IENoYW5nZXMgUkZDIC0+IFYxOg0KPiAgICAgLSBubyBjaGFuZ2VzDQo+DQo+IENo YW5nZXMgVjEgLT4gVjI6DQo+ICAgICAtIHJlYmFzZSBhY2NvcmRpbmcgdG8gdGhlIG5ldyBsb2Nh dGlvbiBvZiBsaWJ4bF92aXJ0aW9fZGlzay5jDQo+DQo+IENoYW5nZXMgVjIgLT4gVjM6DQo+ICAg ICAtIG5vIGNoYW5nZXMNCj4NCj4gQ2hhbmdlcyBWMyAtPiBWNDoNCj4gICAgIC0gcmViYXNlIGFj Y29yZGluZyB0byB0aGUgbmV3IGFyZ3VtZW50IGZvciBERUZJTkVfREVWSUNFX1RZUEVfU1RSVUNU DQo+DQo+IENoYW5nZXMgVjQgLT4gVjU6DQo+ICAgICAtIHNwbGl0IHRoZSBjaGFuZ2VzLCBjaGFu Z2UgdGhlIG9yZGVyIG9mIHRoZSBwYXRjaGVzDQo+ICAgICAtIHVwZGF0ZSBwYXRjaCBkZXNjcmlw dGlvbg0KPiAgICAgLSBkb24ndCBpbnRyb2R1Y2UgbmV3ICJ2ZGlzayIgY29uZmlndXJhdGlvbiBv cHRpb24gd2l0aCBvd24gcGFyc2luZyBsb2dpYywNCj4gICAgICAgcmUtdXNlIFhlbiBQViBibG9j ayAiZGlzayIgcGFyc2luZy9jb25maWd1cmF0aW9uIGxvZ2ljIGZvciB0aGUgdmlydGlvLWRpc2sN Cj4gICAgIC0gaW50cm9kdWNlICJ2aXJ0aW8iIGZsYWcgYW5kIGRvY3VtZW50IGl0J3MgdXNhZ2UN Cj4gICAgIC0gYWRkIExJQlhMX0hBVkVfREVWSUNFX0RJU0tfVklSVElPDQo+ICAgICAtIHVwZGF0 ZSBsaWJ4bHVfZGlza19sLltjaF0NCj4gICAgIC0gZHJvcCBudW1fZGlza3MgdmFyaWFibGUvTUFY X1ZJUlRJT19ESVNLUw0KPiAgICAgLSBkcm9wIFdlaSdzIFQtYg0KPg0KPiBDaGFuZ2VzIFY1IC0+ IFY2Og0KPiAgICAgLSByZWJhc2Ugb24gY3VycmVudCBzdGFnaW5nDQo+ICAgICAtIHVzZSAiJSJQ Ukl1NjQgaW5zdGVhZCBvZiAlbHUgZm9yIGRpc2stPmJhc2UgaW4gZGV2aWNlX2Rpc2tfYWRkKCkN Cj4gICAgIC0gdXBkYXRlICouZ2VuLmdvIGZpbGVzDQo+DQo+IENoYW5nZXMgVjYgLT4gVjc6DQo+ ICAgICAtIHJlYmFzZSBvbiBjdXJyZW50IHN0YWdpbmcNCj4gICAgIC0gdXBkYXRlICouZ2VuLmdv IGZpbGVzIGFuZCBsaWJ4bHVfZGlza19sLltjaF0gZmlsZXMNCj4gICAgIC0gdXBkYXRlIHBhdGNo IGRlc2NyaXB0aW9uDQo+ICAgICAtIHJld29yayBzaWduaWZpY2FudGx5IHRvIHN1cHBvcnQgbW9y ZSBmbGV4aWJsZSBjb25maWd1cmF0aW9uDQo+ICAgICAgIGFuZCBoYXZlIG1vcmUgZ2VuZXJpYyBi YXNpYyBpbXBsZW1lbnRhdGlvbiBmb3IgYmVpbmcgYWJsZSB0byBleHRlbmQNCj4gICAgICAgdGhh dCBmb3Igb3RoZXIgdXNlLWNhc2VzICh2aXJ0aW8tcGNpLCBxZW11LCBldGMpLg0KPg0KPiBDaGFu Z2VzIFY3IC0+IFY4Og0KPiAgICAgLSB1cGRhdGUgKi5nZW4uZ28gZmlsZXMgYW5kIGxpYnhsdV9k aXNrX2wuW2NoXSBmaWxlcw0KPiAgICAgLSB1cGRhdGUgcGF0Y2ggZGVzY3JpcHRpb24gYW5kIGNv bW1lbnRzIGluIHRoZSBjb2RlDQo+ICAgICAtIHVzZSAic3BlY2lmaWNhdGlvbiIgY29uZmlnIG9w dGlvbiBpbnN0ZWFkIG9mICJwcm90b2NvbCINCj4gICAgIC0gdXBkYXRlIGxpYnhsX3R5cGVzLmlk bCBhbmQgY29kZSBhY2NvcmRpbmcgdG8gbmV3IGZpZWxkcw0KPiAgICAgICBpbiBsaWJ4bF9kZXZp Y2VfZGlzaw0KPg0KPiBDaGFuZ2VzIFY4IC0+IFY5Og0KPiAgICAgLSB1cGRhdGUgKGFuZCBoYXJk ZW4pIGNoZWNrcyBpbiBsaWJ4bF9fZGV2aWNlX2Rpc2tfc2V0ZGVmYXVsdCgpLA0KPiAgICAgICBy ZXR1cm4gZXJyb3IgaW4gY2FzZSBvZiBpbmNvcnJlY3Qgc2V0dGluZ3Mgb2Ygc3BlY2lmaWNhdGlv bg0KPiAgICAgICBhbmQgdHJhbnNwb3J0DQo+ICAgICAtIHJlbW92ZSBib3RoIGFzc2VydHMgaW4g ZGV2aWNlX2Rpc2tfYWRkKCkNCj4gICAgIC0gdXBkYXRlIHZpcnRpbyByZWxhdGVkIGNvZGUgaW4g bGlieGxfX2Rpc2tfZnJvbV94ZW5zdG9yZSgpLA0KPiAgICAgICBkbyBub3QgZmFpbCBpZiBzcGVj aWZpY2F0aW9uIG5vZGUgaXMgYWJzZW50LCByZXBsYWNlDQo+ICAgICAgIG9wZW4tY29kZWQgY2hl Y2tzIG9mIGZldGNoZWQgc3BlY2lmaWNhdGlvbiBhbmQgdHJhbnNwb3J0IGJ5DQo+ICAgICAgIGxp YnhsX2Rpc2tfc3BlY2lmaWNhdGlvbl9mcm9tX3N0cmluZygpIGFuZCBsaWJ4bF9kaXNrX3RyYW5z cG9ydF9mcm9tX3N0cmluZygpDQo+ICAgICAgIHJlc3BlY3RpdmVseQ0KPiAgICAgLSBzL2xpYnhs X2RldmljZV9kaXNrX2dldF9wYXRoL2xpYnhsX19kZXZpY2VfZGlza19nZXRfcGF0aA0KPiAgICAg LSBhZGQgYSBjb21tZW50IGZvciB2aXJ0aW8tbW1pbyBwYXJhbWV0ZXJzIGluIHN0cnVjdCBsaWJ4 bF9kZXZpY2VfZGlzaw0KPg0KPiBDaGFuZ2VzIFY5IC0+IFYxMDoNCj4gICAgIC0gcy9FUlJPUl9G QUlML0VSUk9SX0lOVkFMIGluIGJvdGggcGxhY2VzIGluIGxpYnhsX19kZXZpY2VfZGlza19zZXRk ZWZhdWx0KCkNCj4gICAgIC0gcmV3b3JrIGxpYnhsX19kZXZpY2VfZGlza19nZXRfcGF0aCgpDQo+ DQo+IENoYW5nZXMgVjEwIC0+IFYxMC4xOg0KPiAgICAgLSBmaXggc21hbGwgY29kaW5nIHN0eWxl IGlzc3VlIGluIGxpYnhsX19kZXZpY2VfZGlza19nZXRfcGF0aCgpDQo+ICAgICAtIGRyb3Agc3Bl Y2lmaWNhdGlvbiBjaGVjayBpbiBtYWluX2Jsb2NrYXR0YWNoKCkgYW5kIGFkZA0KPiAgICAgICBy ZXF1aXJlZCBjaGVjayBpbiBsaWJ4bF9fZGV2aWNlX2Rpc2tfc2V0ZGVmYXVsdCgpDQo+ICAgICAt IHVwZGF0ZSBzcGVjaWZpY2F0aW9uIGNoZWNrIGluIG1haW5fYmxvY2tkZXRhY2goKQ0KPg0KPiBD aGFuZ2VzIFYxMC4xIC0+IFYxMToNCj4gICAgIC0gQW50aG9ueSBhbHJlYWR5IGdhdmUgaGlzIFJl dmlld2VkLWJ5LCBJIGRyb3BwZWQgaXQgZHVlIHRvIHRoZSBjaGFuZ2VzDQo+ICAgICAtIEdlb3Jn ZSBhbHJlYWR5IGdhdmUgaGlzIEFja2VkLWJ5LCBJIGRyb3BwZWQgaXQgZHVlIHRvIHRoZSBjaGFu Z2VzDQo+ICAgICAtIHMvb3RoZXIvc3RhbmRhbG9uZSBmb3IgdGhlIGJhY2tlbmR0eXBlDQo+IC0t LQ0KPiAgIGRvY3MvbWFuL3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBvZC5pbiAgIHwgIDM4ICst DQo+ICAgdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdvICAgICAgfCAgIDggKw0K PiAgIHRvb2xzL2dvbGFuZy94ZW5saWdodC90eXBlcy5nZW4uZ28gICAgICAgIHwgIDE4ICsNCj4g ICB0b29scy9pbmNsdWRlL2xpYnhsLmggICAgICAgICAgICAgICAgICAgICB8ICAgNyArDQo+ICAg dG9vbHMvbGlicy9saWdodC9saWJ4bF9kZXZpY2UuYyAgICAgICAgICAgfCAgNjIgKy0NCj4gICB0 b29scy9saWJzL2xpZ2h0L2xpYnhsX2Rpc2suYyAgICAgICAgICAgICB8IDE0NiArKystDQo+ICAg dG9vbHMvbGlicy9saWdodC9saWJ4bF9pbnRlcm5hbC5oICAgICAgICAgfCAgIDIgKw0KPiAgIHRv b2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsICAgICAgICAgIHwgIDE4ICsNCj4gICB0b29s cy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzX2ludGVybmFsLmlkbCB8ICAgMSArDQo+ICAgdG9vbHMv bGlicy9saWdodC9saWJ4bF91dGlscy5jICAgICAgICAgICAgfCAgIDIgKw0KPiAgIHRvb2xzL2xp YnMvdXRpbC9saWJ4bHVfZGlza19sLmMgICAgICAgICAgIHwgOTU5ICsrKysrKysrKysrLS0tLS0t LS0tLS0NCj4gICB0b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5oICAgICAgICAgICB8ICAg MiArLQ0KPiAgIHRvb2xzL2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmwgICAgICAgICAgIHwgICA5 ICsNCj4gICB0b29scy94bC94bF9ibG9jay5jICAgICAgICAgICAgICAgICAgICAgICB8ICAgNiAr DQo+ICAgMTQgZmlsZXMgY2hhbmdlZCwgNzk4IGluc2VydGlvbnMoKyksIDQ4MCBkZWxldGlvbnMo LSkNCg0KDQpJIGhhdmUganVzdCByZWFsaXplZCB0aGF0IGN1cnJlbnQgcGF0Y2ggZG9lc24ndCBh cHBseSB0byB0aGUgc3RhZ2luZyANCmNsZWFybHkuDQoNCkl0J3MgbXkgZmF1bHQsIGFzIFYxMSBp cyBiYXNlZCBvbiB0aGUgc2FtZSBzdGFnaW5nIHN0YXRlIGFzIFYxMCB3YXMuDQoNCkl0IGNvbmZs aWN0cyB3aXRoIGNoYW5nZXMgZG9uZSBieSB0aGUgZm9sbG93aW5nIGNvbW1pdDoNCg0KNTRkOGYy N2QwNCB0b29scy9saWJ4bDogcmVwb3J0IHRydXN0ZWQgYmFja2VuZCBzdGF0dXMgdG8gZnJvbnRl bmRzDQoNCg0KQWxzbyBJIG5vdGljZWQgdGhhdCBnb2xhbmcgYmluZGluZ3MgaW4gY3VycmVudCBz dGFnaW5nIGlzIG91dC1vZi1zeW5jLg0KDQpJIHdpbGwgcHVzaCBhIHJlYmFzZWQgdmVyc2lvbiBz b29uIGluIHJlcGx5IHRvIGN1cnJlbnQgdGhyZWFkLiBTb3JyeSBmb3IgDQp0aGUgaW5jb252ZW5p ZW5jZS4NCg0KDQpbc25pcF0NCg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5r bw0K From xen-devel-bounces@lists.xenproject.org Sat Jul 16 16:35:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 16:35:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368833.600244 (Exim 4.92) (envelope-from ) id 1oCklS-0003bZ-RQ; Sat, 16 Jul 2022 16:35:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368833.600244; Sat, 16 Jul 2022 16:35:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCklS-0003bS-NQ; Sat, 16 Jul 2022 16:35:34 +0000 Received: by outflank-mailman (input) for mailman id 368833; Sat, 16 Jul 2022 16:35:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCklR-0003bM-78 for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 16:35:33 +0000 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4eda7830-0525-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 18:35:31 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F0837202E4; Sat, 16 Jul 2022 16:35:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 94E591351D; Sat, 16 Jul 2022 16:35:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YKsHI9Lo0mIjBgAAMHmgww (envelope-from ); Sat, 16 Jul 2022 16:35:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4eda7830-0525-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657989330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ou8Rl3rKdNin3iFI14DAAcINBGak3oEAgpZ2DwPHU24=; b=h2RyGvFZRNu1j239mKDyQg+j7qJ/jd7VwXWZgEFZyK9SHH3Yg7cTBC0MhwLFrfkg0Bg/XK kOUrPpE5EcgMxvhAw9n5jZpoPuN2+Z0d28R0eyGtXst7y/YUwJNZgB59kz5W2MRSsGhzJW zdtef5jJRiqQ058zvI09cl6+/wJcl3I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657989330; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ou8Rl3rKdNin3iFI14DAAcINBGak3oEAgpZ2DwPHU24=; b=h3HhjFZuj75cKW79F2SYwnpVgjphh1wfpkaUmhihoh9HRjQTIpvR2xUEozkj3RjoNPESIQ H1hifNVornz8VhDg== From: Nicolai Stange To: Greg KH Cc: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, Ben Hutchings Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports References: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> Date: Sat, 16 Jul 2022 18:35:29 +0200 In-Reply-To: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> (Boris Ostrovsky's message of "Tue, 12 Jul 2022 16:22:41 -0400") Message-ID: <875yjxrp66.fsf@linux.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, I see a patch for this has been queued up for 5.10 already ([1]), I'm just sharing my findings in support of this patch here -- it doesn't merely exchange one warning for another, but fixes a real issue and should perhaps get applied to other stable branches as well. TL;DR: for this particular warning, objtool would exit early and fail to create any .orc_unwind* ELF sections for head_64.o, which are consumed by the ORC unwinder at runtime. Boris Ostrovsky writes: > On 7/12/22 3:31 PM, Greg KH wrote: >> On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote: >>> >>> On 7/12/22 12:38 PM, Greg KH wrote: >>>> Hi all, >>>> >>>> I'm seeing the following build warning: >>>> arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update= (): can't find starting instruction >>>> in the 5.15.y and 5.10.y retbleed backports. The reason for this is that with RET being multibyte, it can cross those "xen_hypecall_*" symbol boundaries, because ... >>>> >>>> I don't know why just this one hypercall is being called out by objtoo= l, >>>> and this warning isn't in 5.18 and Linus's tree due to I think commit >>>> 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. >>>> >>>> But, is this a ret call that we "forgot" here? It's a "real" ret in >>>> Linus's branch: >>>> >>>> .pushsection .noinstr.text, "ax" >>>> .balign PAGE_SIZE >>>> SYM_CODE_START(hypercall_page) >>>> .rept (PAGE_SIZE / 32) >>>> UNWIND_HINT_FUNC >>>> ANNOTATE_NOENDBR >>>> ANNOTATE_UNRET_SAFE >>>> ret >>>> /* >>>> * Xen will write the hypercall page, and sort out ENDBR. >>>> */ >>>> .skip 31, 0xcc >>>> .endr >>>> >>>> while 5.15.y and older has: >>>> .pushsection .text >>>> .balign PAGE_SIZE >>>> SYM_CODE_START(hypercall_page) >>>> .rept (PAGE_SIZE / 32) >>>> UNWIND_HINT_FUNC >>>> .skip 31, 0x90 ... the "31" is no longer correct, ... >>>> ANNOTATE_UNRET_SAFE >>>> RET ... as with RET occupying more than one byte, the resulting hypercall entry's total size won't add up to 32 anymore. Note that those xen_hypercall_* symbols' values are getting statically calculated as 'hypercall page + n * 32' in the HYPERCALL() #define from xen-head.S. So there's a mismatch and with RET =3D=3D 'ret; int3', the resulting .text effectively becomes 101e: 90 nop 101f: c3 ret=20=20=20=20 0000000000001020 : 1020: cc int3=20=20=20 1021: 90 nop 1022: 90 nop This is probably already not what has been intended, but because 'ret' and 'int3' both are single-byte encoded, objtool would still be able to find at least some "starting instruction" at this point. But with RET =3D=3D 'jmp __x86_return_thunk', it becomes 101e: 90 nop 101f: e9 .byte 0xe9 0000000000001020 : 1020: 00 00 add %al,(%rax) 1022: 00 00 add %al,(%rax) 1024: 90 nop Here the 'e9 00 00 00 00' jmp crosses the symbol boundary and objtool errors out. >>>> .endr >>>> >>>> So should the "ret" remain or be turned into "RET" in mainline right >>>> now? >>> >>> >>> It doesn't matter --- this is overwritten by the hypervisor during >>> initialization when Xen fills in actual hypercall code. It does makes a difference though: even though objtool reports only a warning, it still exits early in this particular case and won't create any of the .orc_unwind* or .return_sites sections for head_64.o as it's supposed to. The significance of not having .orc_unwind* for head_64.o is that the reliable stacktracing implementation would mark the swapper tasks' stacktraces as unreliable at runtime, because the ORC unwinder would fail to recognize their final secondary_startup_64() from head_64.o as being the end. Note that livepatching relies on reliable stacktraces when transitioning tasks. >>> >>> >>> So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool= happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes.= The latter was not really necessary but harmless. >>> >>> >>> So it can be 'ret', RET, or anything else that tools don't complain abo= ut. It will not be executed. >> Cool, thanks. >> But what about the objtool warning that I now see? Is that "real"? > > > > It's not real in the sense that the code there is not real, it will be ov= erwritten. (Originally the whole page was 'nop's) > > > I am getting a different error BTW: > > arch/x86/kernel/head_64.o: warning: objtool: .text+0x5: unreachable inst= ruction > I think this one is (mostly?) harmless, at least as as far as the .orc_unwind* generation is concerned. Josh would know more. Thanks, Nicolai [1] https://lore.kernel.org/r/Ys+8ZYxkDmSCcDWv@kroah.com > > >> I don't run any Xen systems, so I can't test any of this myself. > > > You can't test any changes to that code --- it is rewritten when Xen gues= t is running. > > > We probably do want to shut up objtool. Josh, any suggestions? > > > -boris > --=20 SUSE Software Solutions Germany GmbH, Frankenstra=C3=9Fe 146, 90461 N=C3=BC= rnberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman (HRB 36809, AG N=C3=BCrnberg) From xen-devel-bounces@lists.xenproject.org Sat Jul 16 16:38:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 16:38:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368841.600255 (Exim 4.92) (envelope-from ) id 1oCkny-0004ZR-7v; Sat, 16 Jul 2022 16:38:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368841.600255; Sat, 16 Jul 2022 16:38:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCkny-0004ZK-4G; Sat, 16 Jul 2022 16:38:10 +0000 Received: by outflank-mailman (input) for mailman id 368841; Sat, 16 Jul 2022 16:38:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCknw-0004ZE-Jq for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 16:38:09 +0000 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [2a00:1450:4864:20::12f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aa5dff8d-0525-11ed-bd2d-47488cf2e6aa; Sat, 16 Jul 2022 18:38:04 +0200 (CEST) Received: by mail-lf1-x12f.google.com with SMTP id a9so12510828lfk.11 for ; Sat, 16 Jul 2022 09:38:04 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id o9-20020ac24e89000000b00489daae997asm1535963lfr.1.2022.07.16.09.38.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jul 2022 09:38:01 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aa5dff8d-0525-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rkdZEsWtYk7NxOaoT+HAew93mxZVgXDi6g2zI7tJ9cE=; b=BkzITOjzBaPellm4WZdh+tD6zcK0Dplx2LvwFIzXbxKT2p5qA2Rz5dieR1r+/084vK c5wLSlvSXZJ9Ty6czisWNCxcNDqICMqJs6OH9MTh+i80MQP88e9YdDKMUJ4WDRFz0yfC H3cDuj9zxvgFSEX4NlaZW2p6hRrgv1G+FNUIiFLdlqMjaY+/ZZsMS+WHQLiBFmsZlP1q legrjmQH0gicIuiobH9qhnQaS1Q5vmw5xMOynQ4Q6amZ6Lg/dJuCI2cgAQocQ1zxft/O uifr8nL2J+1BxY32GtnmcNYCaXM5qVZzLz7iR9aqWf9wd8R8P8IHAnEfMYHaE3qNQt74 0okg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rkdZEsWtYk7NxOaoT+HAew93mxZVgXDi6g2zI7tJ9cE=; b=10viwdCgCJf59eE5D+dSO2usxUcTzADxQoZwbxMyTDi+qpxqCjexBl+ggpCWYFqMk6 QOL5LrCIt3IgFDyYXnRNeYlmwMkX6EoR5/9+v2MDWqiZnumOyr6pqSl1ISCjG6q0e4z+ OmgSy/sN3LDixR027e4xPfiQmQ/fZJspoGsETJ9F9EjS4p23ifWwcgFNi2wWzbJ487hX 2cxuLLWijZoKBFmn+IRdoRNxTVPEOi7b37/EGMVIWzYzHQSWA3BHC2flJd1hOYB4EdU0 Hhhn0KBjICbkfrY0g2t94omkTypGMqfl/MycAPcbTGafh4mE3srZ4qDGg5Gbp/EcHmuP I5bA== X-Gm-Message-State: AJIora91RR/9sU5nu5RtGRjwMB6qHHIkbBwYKiAjdGfVGLQDA5Q8kUvZ 5gEvnNqYlJDVgeYP3sBF6rzsu84z+48sug== X-Google-Smtp-Source: AGRyM1tqSX1oBM/BDooBeSarMlJ7+jK1UFuqtLspwldAeKU9j5FoUEgfjkZYOhcJWi8eumIERDcjvg== X-Received: by 2002:a05:6512:33c9:b0:48a:27ab:cc0b with SMTP id d9-20020a05651233c900b0048a27abcc0bmr3722184lfg.250.1657989482671; Sat, 16 Jul 2022 09:38:02 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Date: Sat, 16 Jul 2022 19:37:45 +0300 Message-Id: <20220716163745.28712-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko --- Changes RFC -> V1: - no changes Changes V1 -> V2: - rebase according to the new location of libxl_virtio_disk.c Changes V2 -> V3: - no changes Changes V3 -> V4: - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT Changes V4 -> V5: - split the changes, change the order of the patches - update patch description - don't introduce new "vdisk" configuration option with own parsing logic, re-use Xen PV block "disk" parsing/configuration logic for the virtio-disk - introduce "virtio" flag and document it's usage - add LIBXL_HAVE_DEVICE_DISK_VIRTIO - update libxlu_disk_l.[ch] - drop num_disks variable/MAX_VIRTIO_DISKS - drop Wei's T-b Changes V5 -> V6: - rebase on current staging - use "%"PRIu64 instead of %lu for disk->base in device_disk_add() - update *.gen.go files Changes V6 -> V7: - rebase on current staging - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description - rework significantly to support more flexible configuration and have more generic basic implementation for being able to extend that for other use-cases (virtio-pci, qemu, etc). Changes V7 -> V8: - update *.gen.go files and libxlu_disk_l.[ch] files - update patch description and comments in the code - use "specification" config option instead of "protocol" - update libxl_types.idl and code according to new fields in libxl_device_disk Changes V8 -> V9: - update (and harden) checks in libxl__device_disk_setdefault(), return error in case of incorrect settings of specification and transport - remove both asserts in device_disk_add() - update virtio related code in libxl__disk_from_xenstore(), do not fail if specification node is absent, replace open-coded checks of fetched specification and transport by libxl_disk_specification_from_string() and libxl_disk_transport_from_string() respectively - s/libxl_device_disk_get_path/libxl__device_disk_get_path - add a comment for virtio-mmio parameters in struct libxl_device_disk Changes V9 -> V10: - s/ERROR_FAIL/ERROR_INVAL in both places in libxl__device_disk_setdefault() - rework libxl__device_disk_get_path() Changes V10 -> V10.1: - fix small coding style issue in libxl__device_disk_get_path() - drop specification check in main_blockattach() and add required check in libxl__device_disk_setdefault() - update specification check in main_blockdetach() Changes V10.1 -> V11: - Anthony already gave his Reviewed-by, I dropped it due to the changes - George already gave his Acked-by, I dropped it due to the changes - s/other/standalone for the backendtype Changes V11 -> V11.1: - rebase --- docs/man/xl-disk-configuration.5.pod.in | 38 +- tools/golang/xenlight/helpers.gen.go | 8 + tools/golang/xenlight/types.gen.go | 18 + tools/include/libxl.h | 7 + tools/libs/light/libxl_device.c | 62 +- tools/libs/light/libxl_disk.c | 146 +++- tools/libs/light/libxl_internal.h | 2 + tools/libs/light/libxl_types.idl | 18 + tools/libs/light/libxl_types_internal.idl | 1 + tools/libs/light/libxl_utils.c | 2 + tools/libs/util/libxlu_disk_l.c | 959 +++++++++++----------- tools/libs/util/libxlu_disk_l.h | 2 +- tools/libs/util/libxlu_disk_l.l | 9 + tools/xl/xl_block.c | 6 + 14 files changed, 798 insertions(+), 480 deletions(-) diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk-configuration.5.pod.in index 95d039655a..bc945cc517 100644 --- a/docs/man/xl-disk-configuration.5.pod.in +++ b/docs/man/xl-disk-configuration.5.pod.in @@ -232,7 +232,7 @@ Specifies the backend implementation to use =item Supported values -phy, qdisk +phy, qdisk, standalone =item Mandatory @@ -244,11 +244,13 @@ Automatically determine which backend to use. =back -This does not affect the guest's view of the device. It controls -which software implementation of the Xen backend driver is used. +It controls which software implementation of the backend driver is used. +Depending on the "specification" option this may affect the guest's view +of the device. Not all backend drivers support all combinations of other options. -For example, "phy" does not support formats other than "raw". +For example, "phy" and "standalone" do not support formats other than "raw" +and "standalone" does not support specifications other than "virtio". Normally this option should not be specified, in which case libxl will automatically determine the most suitable backend. @@ -373,8 +375,36 @@ processing or causing malfunction to the frontend or the whole domain. Note frontends can ignore such recommendation. +=item B=I + +=over 4 + +=item Description + +Specifies the communication protocol (specification) to use for the chosen +"backendtype" option + +=item Supported values + +xen, virtio + +=item Mandatory + +No + +=item Default value + +xen + =back +Besides forcing toolstack to use specific backend implementation, this also +affects the guest's view of the device. For example, "virtio" requires +Virtio frontend driver (virtio-blk) to be used. Please note, the virtual +device (vdev) is not passed to the guest in that case, but it still must be +specified for the internal purposes. + +=back =head1 COLO Parameters diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index dece545ee0..ad8c11eae1 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1763,6 +1763,10 @@ x.DirectIoSafe = bool(xc.direct_io_safe) if err := x.DiscardEnable.fromC(&xc.discard_enable);err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +x.Specification = DiskSpecification(xc.specification) +x.Transport = DiskTransport(xc.transport) +x.Irq = uint32(xc.irq) +x.Base = uint64(xc.base) if err := x.ColoEnable.fromC(&xc.colo_enable);err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } @@ -1800,6 +1804,10 @@ xc.direct_io_safe = C.bool(x.DirectIoSafe) if err := x.DiscardEnable.toC(&xc.discard_enable); err != nil { return fmt.Errorf("converting field DiscardEnable: %v", err) } +xc.specification = C.libxl_disk_specification(x.Specification) +xc.transport = C.libxl_disk_transport(x.Transport) +xc.irq = C.uint32_t(x.Irq) +xc.base = C.uint64_t(x.Base) if err := x.ColoEnable.toC(&xc.colo_enable); err != nil { return fmt.Errorf("converting field ColoEnable: %v", err) } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 253c9ad93d..b9143390f8 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -99,6 +99,20 @@ DiskBackendUnknown DiskBackend = 0 DiskBackendPhy DiskBackend = 1 DiskBackendTap DiskBackend = 2 DiskBackendQdisk DiskBackend = 3 +DiskBackendStandalone DiskBackend = 4 +) + +type DiskSpecification int +const( +DiskSpecificationUnknown DiskSpecification = 0 +DiskSpecificationXen DiskSpecification = 1 +DiskSpecificationVirtio DiskSpecification = 2 +) + +type DiskTransport int +const( +DiskTransportUnknown DiskTransport = 0 +DiskTransportMmio DiskTransport = 1 ) type NicType int @@ -645,6 +659,10 @@ Readwrite int IsCdrom int DirectIoSafe bool DiscardEnable Defbool +Specification DiskSpecification +Transport DiskTransport +Irq uint32 +Base uint64 ColoEnable Defbool ColoRestoreEnable Defbool ColoHost string diff --git a/tools/include/libxl.h b/tools/include/libxl.h index f351669039..2321a648a5 100644 --- a/tools/include/libxl.h +++ b/tools/include/libxl.h @@ -549,6 +549,13 @@ */ #define LIBXL_HAVE_ASSISTED_APIC 1 +/* + * LIBXL_HAVE_DEVICE_DISK_SPECIFICATION indicates that 'specification' and + * 'transport' fields (of libxl_disk_specification and libxl_disk_transport + * types respectively) are present in libxl_device_disk. + */ +#define LIBXL_HAVE_DEVICE_DISK_SPECIFICATION 1 + /* * libxl ABI compatibility * diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_device.c index e6025d135e..a75c21d433 100644 --- a/tools/libs/light/libxl_device.c +++ b/tools/libs/light/libxl_device.c @@ -289,9 +289,16 @@ static int disk_try_backend(disk_try_backend_args *a, libxl_disk_backend backend) { libxl__gc *gc = a->gc; + libxl_disk_specification specification = a->disk->specification; /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or * backend on success */ + if ((specification == LIBXL_DISK_SPECIFICATION_VIRTIO && + backend != LIBXL_DISK_BACKEND_STANDALONE) || + (specification != LIBXL_DISK_SPECIFICATION_VIRTIO && + backend == LIBXL_DISK_BACKEND_STANDALONE)) + goto bad_specification; + switch (backend) { case LIBXL_DISK_BACKEND_PHY: if (a->disk->format != LIBXL_DISK_FORMAT_RAW) { @@ -329,6 +336,29 @@ static int disk_try_backend(disk_try_backend_args *a, if (a->disk->script) goto bad_script; return backend; + case LIBXL_DISK_BACKEND_STANDALONE: + if (a->disk->format != LIBXL_DISK_FORMAT_RAW) + goto bad_format; + + if (a->disk->script) + goto bad_script; + + if (libxl_defbool_val(a->disk->colo_enable)) + goto bad_colo; + + if (a->disk->backend_domid != LIBXL_TOOLSTACK_DOMID) { + LOG(DEBUG, "Disk vdev=%s, is using a storage driver domain, " + "skipping physical device check", a->disk->vdev); + return backend; + } + + if (libxl__try_phy_backend(a->stab.st_mode)) + return backend; + + LOG(DEBUG, "Disk vdev=%s, backend standalone unsuitable as phys path not a " + "block device", a->disk->vdev); + return 0; + default: LOG(DEBUG, "Disk vdev=%s, backend %d unknown", a->disk->vdev, backend); return 0; @@ -352,6 +382,12 @@ static int disk_try_backend(disk_try_backend_args *a, LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with colo", a->disk->vdev, libxl_disk_backend_to_string(backend)); return 0; + + bad_specification: + LOG(DEBUG, "Disk vdev=%s, backend %s not compatible with specification %s", + a->disk->vdev, libxl_disk_backend_to_string(backend), + libxl_disk_specification_to_string(specification)); + return 0; } int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path, @@ -376,8 +412,9 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { a.gc = gc; a.disk = disk; - LOG(DEBUG, "Disk vdev=%s spec.backend=%s", disk->vdev, - libxl_disk_backend_to_string(disk->backend)); + LOG(DEBUG, "Disk vdev=%s spec.backend=%s specification=%s", disk->vdev, + libxl_disk_backend_to_string(disk->backend), + libxl_disk_specification_to_string(disk->specification)); if (disk->format == LIBXL_DISK_FORMAT_EMPTY) { if (!disk->is_cdrom) { @@ -392,7 +429,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { } memset(&a.stab, 0, sizeof(a.stab)); } else if ((disk->backend == LIBXL_DISK_BACKEND_UNKNOWN || - disk->backend == LIBXL_DISK_BACKEND_PHY) && + disk->backend == LIBXL_DISK_BACKEND_PHY || + disk->backend == LIBXL_DISK_BACKEND_STANDALONE) && disk->backend_domid == LIBXL_TOOLSTACK_DOMID && !disk->script) { if (stat(disk->pdev_path, &a.stab)) { @@ -408,7 +446,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, libxl_device_disk *disk) { ok= disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?: disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?: - disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP); + disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?: + disk_try_backend(&a, LIBXL_DISK_BACKEND_STANDALONE); if (ok) LOG(DEBUG, "Disk vdev=%s, using backend %s", disk->vdev, @@ -441,10 +480,25 @@ char *libxl__device_disk_string_of_backend(libxl_disk_backend backend) case LIBXL_DISK_BACKEND_QDISK: return "qdisk"; case LIBXL_DISK_BACKEND_TAP: return "phy"; case LIBXL_DISK_BACKEND_PHY: return "phy"; + case LIBXL_DISK_BACKEND_STANDALONE: return "standalone"; + default: return NULL; + } +} + +char *libxl__device_disk_string_of_specification(libxl_disk_specification specification) +{ + switch (specification) { + case LIBXL_DISK_SPECIFICATION_XEN: return "xen"; + case LIBXL_DISK_SPECIFICATION_VIRTIO: return "virtio"; default: return NULL; } } +char *libxl__device_disk_string_of_transport(libxl_disk_transport transport) +{ + return (transport == LIBXL_DISK_TRANSPORT_MMIO ? "mmio" : NULL); +} + const char *libxl__qemu_disk_format_string(libxl_disk_format format) { switch (format) { diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index 9da2b2ed27..ea3623dd6f 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -164,6 +164,30 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); if (rc < 0) return rc; + if (disk->specification == LIBXL_DISK_SPECIFICATION_UNKNOWN) + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + + if (disk->specification == LIBXL_DISK_SPECIFICATION_XEN && + disk->transport != LIBXL_DISK_TRANSPORT_UNKNOWN) { + LOGD(ERROR, domid, "Transport is only supported for specification virtio"); + return ERROR_INVAL; + } + + /* Force transport mmio for specification virtio for now */ + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + if (!(disk->transport == LIBXL_DISK_TRANSPORT_UNKNOWN || + disk->transport == LIBXL_DISK_TRANSPORT_MMIO)) { + LOGD(ERROR, domid, "Unsupported transport for specification virtio"); + return ERROR_INVAL; + } + disk->transport = LIBXL_DISK_TRANSPORT_MMIO; + } + + if (hotplug && disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + LOGD(ERROR, domid, "Hotplug isn't supported for specification virtio"); + return ERROR_FAIL; + } + /* Force Qdisk backend for CDROM devices of guests with a device model. */ if (disk->is_cdrom != 0 && libxl__domain_type(gc, domid) == LIBXL_DOMAIN_TYPE_HVM) { @@ -205,6 +229,9 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, case LIBXL_DISK_BACKEND_QDISK: device->backend_kind = LIBXL__DEVICE_KIND_QDISK; break; + case LIBXL_DISK_BACKEND_STANDALONE: + device->backend_kind = LIBXL__DEVICE_KIND_VIRTIO_DISK; + break; default: LOGD(ERROR, domid, "Unrecognized disk backend type: %d", disk->backend); @@ -213,7 +240,8 @@ static int libxl__device_from_disk(libxl__gc *gc, uint32_t domid, device->domid = domid; device->devid = devid; - device->kind = LIBXL__DEVICE_KIND_VBD; + device->kind = disk->backend == LIBXL_DISK_BACKEND_STANDALONE ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; return 0; } @@ -331,7 +359,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, assert(device->backend_kind == LIBXL__DEVICE_KIND_VBD); break; + case LIBXL_DISK_BACKEND_STANDALONE: + dev = disk->pdev_path; + + flexarray_append(back, "params"); + flexarray_append(back, dev); + assert(device->backend_kind == LIBXL__DEVICE_KIND_VIRTIO_DISK); + break; case LIBXL_DISK_BACKEND_TAP: LOG(ERROR, "blktap is not supported"); rc = ERROR_FAIL; @@ -387,6 +422,14 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, flexarray_append_pair(back, "discard-enable", libxl_defbool_val(disk->discard_enable) ? "1" : "0"); + flexarray_append(back, "specification"); + flexarray_append(back, libxl__device_disk_string_of_specification(disk->specification)); + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + flexarray_append(back, "transport"); + flexarray_append(back, libxl__device_disk_string_of_transport(disk->transport)); + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, disk->base)); + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq)); + } flexarray_append(front, "backend-id"); flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); @@ -535,6 +578,53 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, const char *libxl_path, } libxl_string_to_backend(ctx, tmp, &(disk->backend)); + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/specification", libxl_path)); + if (!tmp) { + LOG(DEBUG, "Missing xenstore node %s/specification, assuming specification xen", libxl_path); + disk->specification = LIBXL_DISK_SPECIFICATION_XEN; + } else { + rc = libxl_disk_specification_from_string(tmp, &disk->specification); + if (rc) { + LOG(ERROR, "Unable to parse xenstore node %s/specification", libxl_path); + goto cleanup; + } + } + + if (disk->specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/transport", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path); + goto cleanup; + } + rc = libxl_disk_transport_from_string(tmp, &disk->transport); + if (rc) { + LOG(ERROR, "Unable to parse xenstore node %s/transport", libxl_path); + goto cleanup; + } + if (disk->transport != LIBXL_DISK_TRANSPORT_MMIO) { + LOG(ERROR, "Only transport mmio is expected for specification virtio"); + goto cleanup; + } + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/base", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); + goto cleanup; + } + disk->base = strtoul(tmp, NULL, 10); + + tmp = libxl__xs_read(gc, XBT_NULL, + GCSPRINTF("%s/irq", libxl_path)); + if (!tmp) { + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); + goto cleanup; + } + disk->irq = strtoul(tmp, NULL, 10); + } + disk->vdev = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/dev", libxl_path), &len); if (!disk->vdev) { @@ -578,6 +668,42 @@ cleanup: return rc; } +static int libxl__device_disk_get_path(libxl__gc *gc, uint32_t domid, + char **path) +{ + const char *xen_dir, *virtio_dir; + char *xen_path, *virtio_path; + int rc; + + /* default path */ + xen_path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VBD)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, xen_path, &xen_dir); + if (rc) + return rc; + + virtio_path = GCSPRINTF("%s/device/%s", + libxl__xs_libxl_path(gc, domid), + libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); + + rc = libxl__xs_read_checked(gc, XBT_NULL, virtio_path, &virtio_dir); + if (rc) + return rc; + + if (xen_dir && virtio_dir) { + LOGD(ERROR, domid, "Invalid configuration, both xen and virtio paths are present"); + return ERROR_INVAL; + } else if (virtio_dir) { + *path = virtio_path; + } else { + *path = xen_path; + } + + return 0; +} + int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, const char *vdev, libxl_device_disk *disk) { @@ -591,10 +717,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, libxl_device_disk_init(disk); - libxl_path = libxl__domain_device_libxl_path(gc, domid, devid, - LIBXL__DEVICE_KIND_VBD); + rc = libxl__device_disk_get_path(gc, domid, &libxl_path); + if (rc) + return rc; - rc = libxl__disk_from_xenstore(gc, libxl_path, devid, disk); + rc = libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, devid), + devid, disk); GC_FREE; return rc; @@ -608,16 +736,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, uint32_t domid, char *fe_path, *libxl_path; char *val; int rc; + libxl__device_kind kind; diskinfo->backend = NULL; diskinfo->devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL); - /* tap devices entries in xenstore are written as vbd devices. */ + /* tap devices entries in xenstore are written as vbd/virtio_disk devices. */ + kind = disk->backend == LIBXL_DISK_BACKEND_STANDALONE ? + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; fe_path = libxl__domain_device_frontend_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); libxl_path = libxl__domain_device_libxl_path(gc, domid, diskinfo->devid, - LIBXL__DEVICE_KIND_VBD); + kind); diskinfo->backend = xs_read(ctx->xsh, XBT_NULL, GCSPRINTF("%s/backend", libxl_path), NULL); if (!diskinfo->backend) { @@ -1421,6 +1552,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk) #define libxl__device_disk_update_devid NULL DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks, + .get_path = libxl__device_disk_get_path, .merge = libxl_device_disk_merge, .dm_needed = libxl_device_disk_dm_needed, .from_xenstore = (device_from_xenstore_fn_t)libxl__disk_from_xenstore, diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_internal.h index bdef5a605e..cb9e8b3b8b 100644 --- a/tools/libs/light/libxl_internal.h +++ b/tools/libs/light/libxl_internal.h @@ -1493,6 +1493,8 @@ _hidden char * libxl__domain_pvcontrol_read(libxl__gc *gc, /* from xl_device */ _hidden char *libxl__device_disk_string_of_backend(libxl_disk_backend backend); +_hidden char *libxl__device_disk_string_of_specification(libxl_disk_specification specification); +_hidden char *libxl__device_disk_string_of_transport(libxl_disk_transport transport); _hidden char *libxl__device_disk_string_of_format(libxl_disk_format format); _hidden const char *libxl__qemu_disk_format_string(libxl_disk_format format); _hidden int libxl__device_disk_set_backend(libxl__gc*, libxl_device_disk*); diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl index f3ceb38c9e..d634f304cd 100644 --- a/tools/libs/light/libxl_types.idl +++ b/tools/libs/light/libxl_types.idl @@ -130,6 +130,18 @@ libxl_disk_backend = Enumeration("disk_backend", [ (1, "PHY"), (2, "TAP"), (3, "QDISK"), + (4, "STANDALONE"), # Only relying on the Xenstore data + ]) + +libxl_disk_specification = Enumeration("disk_specification", [ + (0, "UNKNOWN"), + (1, "XEN"), + (2, "VIRTIO"), + ]) + +libxl_disk_transport = Enumeration("disk_transport", [ + (0, "UNKNOWN"), + (1, "MMIO"), ]) libxl_nic_type = Enumeration("nic_type", [ @@ -706,6 +718,12 @@ libxl_device_disk = Struct("device_disk", [ ("is_cdrom", integer), ("direct_io_safe", bool), ("discard_enable", libxl_defbool), + ("specification", libxl_disk_specification), + ("transport", libxl_disk_transport), + # Note that virtio-mmio parameters (irq and base) are for internal use + # by libxl and can't be modified. + ("irq", uint32), + ("base", uint64), # Note that the COLO configuration settings should be considered unstable. # They may change incompatibly in future versions of Xen. ("colo_enable", libxl_defbool), diff --git a/tools/libs/light/libxl_types_internal.idl b/tools/libs/light/libxl_types_internal.idl index 3593e21dbb..8f71980aec 100644 --- a/tools/libs/light/libxl_types_internal.idl +++ b/tools/libs/light/libxl_types_internal.idl @@ -32,6 +32,7 @@ libxl__device_kind = Enumeration("device_kind", [ (14, "PVCALLS"), (15, "VSND"), (16, "VINPUT"), + (17, "VIRTIO_DISK"), ]) libxl__console_backend = Enumeration("console_backend", [ diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_utils.c index e5e6b2da96..e403bd9bcf 100644 --- a/tools/libs/light/libxl_utils.c +++ b/tools/libs/light/libxl_utils.c @@ -297,6 +297,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, libxl_disk_backend *backend *backend = LIBXL_DISK_BACKEND_TAP; } else if (!strcmp(s, "qdisk")) { *backend = LIBXL_DISK_BACKEND_QDISK; + } else if (!strcmp(s, "standalone")) { + *backend = LIBXL_DISK_BACKEND_STANDALONE; } else if (!strcmp(s, "tap")) { p = strchr(s, ':'); if (!p) { diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_disk_l.c index 32d4b74b58..0b59723b71 100644 --- a/tools/libs/util/libxlu_disk_l.c +++ b/tools/libs/util/libxlu_disk_l.c @@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* msg , yyscan_t yyscanner ); yyg->yy_hold_char = *yy_cp; \ *yy_cp = '\0'; \ yyg->yy_c_buf_p = yy_cp; -#define YY_NUM_RULES 36 -#define YY_END_OF_BUFFER 37 +#define YY_NUM_RULES 37 +#define YY_END_OF_BUFFER 38 /* This struct is not used in this scanner, but its presence is necessary. */ struct yy_trans_info @@ -558,74 +558,77 @@ struct yy_trans_info flex_int32_t yy_verify; flex_int32_t yy_nxt; }; -static const flex_int16_t yy_acclist[575] = +static const flex_int16_t yy_acclist[594] = { 0, - 35, 35, 37, 33, 34, 36, 8193, 33, 34, 36, - 16385, 8193, 33, 36,16385, 33, 34, 36, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 33, 34, - 36, 33, 34, 36, 33, 34, 36, 33, 34, 36, - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, - 34, 36, 33, 34, 36, 33, 34, 36, 35, 36, - 36, 33, 33, 8193, 33, 8193, 33,16385, 8193, 33, - 8193, 33, 33, 8224, 33,16416, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - - 33, 33, 33, 33, 33, 33, 33, 33, 33, 35, - 8193, 33, 8193, 33, 8193, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, - 33, 33, 33, 33, 33, 8224, 33, 8224, 33, 8224, - 23, 33, 33, 28, 8224, 33,16416, 33, 33, 15, - 33, 33, 33, 33, 33, 33, 33, 33, 33, 8217, - 8224, 33,16409,16416, 33, 33, 31, 8224, 33,16416, - 33, 8216, 8224, 33,16408,16416, 33, 33, 8219, 8224, - 33,16411,16416, 33, 33, 33, 33, 33, 28, 8224, - - 33, 28, 8224, 33, 28, 33, 28, 8224, 33, 3, - 33, 15, 33, 33, 33, 33, 33, 30, 8224, 33, - 16416, 33, 33, 33, 8217, 8224, 33, 8217, 8224, 33, - 8217, 33, 8217, 8224, 33, 33, 31, 8224, 33, 31, - 8224, 33, 31, 33, 31, 8224, 8216, 8224, 33, 8216, - 8224, 33, 8216, 33, 8216, 8224, 33, 8219, 8224, 33, - 8219, 8224, 33, 8219, 33, 8219, 8224, 33, 33, 10, - 33, 33, 28, 8224, 33, 28, 8224, 33, 28, 8224, - 28, 33, 28, 33, 3, 33, 33, 33, 33, 33, - 33, 33, 30, 8224, 33, 30, 8224, 33, 30, 33, - - 30, 8224, 33, 33, 29, 8224, 33,16416, 8217, 8224, - 33, 8217, 8224, 33, 8217, 8224, 8217, 33, 8217, 33, - 33, 31, 8224, 33, 31, 8224, 33, 31, 8224, 31, - 33, 31, 8216, 8224, 33, 8216, 8224, 33, 8216, 8224, - 8216, 33, 8216, 33, 8219, 8224, 33, 8219, 8224, 33, - 8219, 8224, 8219, 33, 8219, 33, 33, 10, 23, 10, - 7, 33, 33, 33, 33, 33, 33, 33, 13, 33, - 30, 8224, 33, 30, 8224, 33, 30, 8224, 30, 33, - 30, 2, 33, 29, 8224, 33, 29, 8224, 33, 29, - 33, 29, 8224, 16, 33, 33, 11, 33, 22, 10, - - 10, 23, 7, 23, 7, 33, 8, 33, 33, 33, - 33, 6, 33, 13, 33, 2, 23, 2, 33, 29, - 8224, 33, 29, 8224, 33, 29, 8224, 29, 33, 29, - 16, 33, 33, 11, 23, 11, 26, 8224, 33,16416, - 22, 23, 22, 7, 7, 23, 33, 8, 23, 8, - 33, 33, 33, 33, 6, 23, 6, 6, 23, 6, - 23, 33, 2, 2, 23, 33, 33, 11, 11, 23, - 26, 8224, 33, 26, 8224, 33, 26, 33, 26, 8224, - 22, 23, 33, 8, 8, 23, 33, 33, 17, 18, - 6, 6, 23, 6, 6, 33, 33, 14, 33, 26, - - 8224, 33, 26, 8224, 33, 26, 8224, 26, 33, 26, - 33, 33, 33, 17, 23, 17, 18, 23, 18, 6, - 6, 33, 33, 14, 33, 20, 9, 19, 17, 17, - 23, 18, 18, 23, 6, 5, 6, 33, 21, 20, - 23, 20, 9, 23, 9, 19, 23, 19, 4, 6, - 5, 6, 33, 21, 23, 21, 20, 20, 23, 9, - 9, 23, 19, 19, 23, 4, 6, 12, 33, 21, - 21, 23, 12, 33 + 36, 36, 38, 34, 35, 37, 8193, 34, 35, 37, + 16385, 8193, 34, 37,16385, 34, 35, 37, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 34, 35, + 37, 34, 35, 37, 34, 35, 37, 34, 35, 37, + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, + 35, 37, 34, 35, 37, 34, 35, 37, 36, 37, + 37, 34, 34, 8193, 34, 8193, 34,16385, 8193, 34, + 8193, 34, 34, 8225, 34,16417, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 36, 8193, 34, 8193, 34, 8193, 8225, 34, 8225, 34, + 8225, 24, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 34, 34, 34, 34, 34, 34, 8225, 34, 8225, + 34, 8225, 24, 34, 34, 29, 8225, 34,16417, 34, + 34, 16, 34, 34, 34, 34, 34, 34, 34, 34, + 34, 8218, 8225, 34,16410,16417, 34, 34, 32, 8225, + 34,16417, 34, 8217, 8225, 34,16409,16417, 34, 34, + 34, 8220, 8225, 34,16412,16417, 34, 34, 34, 34, + + 34, 29, 8225, 34, 29, 8225, 34, 29, 34, 29, + 8225, 34, 3, 34, 16, 34, 34, 34, 34, 34, + 31, 8225, 34,16417, 34, 34, 34, 8218, 8225, 34, + 8218, 8225, 34, 8218, 34, 8218, 8225, 34, 34, 32, + 8225, 34, 32, 8225, 34, 32, 34, 32, 8225, 8217, + 8225, 34, 8217, 8225, 34, 8217, 34, 8217, 8225, 34, + 34, 8220, 8225, 34, 8220, 8225, 34, 8220, 34, 8220, + 8225, 34, 34, 11, 34, 34, 29, 8225, 34, 29, + 8225, 34, 29, 8225, 29, 34, 29, 34, 3, 34, + 34, 34, 34, 34, 34, 34, 31, 8225, 34, 31, + + 8225, 34, 31, 34, 31, 8225, 34, 34, 30, 8225, + 34,16417, 8218, 8225, 34, 8218, 8225, 34, 8218, 8225, + 8218, 34, 8218, 34, 34, 32, 8225, 34, 32, 8225, + 34, 32, 8225, 32, 34, 32, 8217, 8225, 34, 8217, + 8225, 34, 8217, 8225, 8217, 34, 8217, 34, 34, 8220, + 8225, 34, 8220, 8225, 34, 8220, 8225, 8220, 34, 8220, + 34, 34, 11, 24, 11, 7, 34, 34, 34, 34, + 34, 34, 34, 14, 34, 31, 8225, 34, 31, 8225, + 34, 31, 8225, 31, 34, 31, 2, 34, 30, 8225, + 34, 30, 8225, 34, 30, 34, 30, 8225, 17, 34, + + 34, 12, 34, 34, 23, 11, 11, 24, 7, 24, + 7, 34, 8, 34, 34, 34, 34, 6, 34, 14, + 34, 2, 24, 2, 34, 30, 8225, 34, 30, 8225, + 34, 30, 8225, 30, 34, 30, 17, 34, 34, 12, + 24, 12, 34, 27, 8225, 34,16417, 23, 24, 23, + 7, 7, 24, 34, 8, 24, 8, 34, 34, 34, + 34, 6, 24, 6, 6, 24, 6, 24, 34, 2, + 2, 24, 34, 34, 12, 12, 24, 34, 27, 8225, + 34, 27, 8225, 34, 27, 34, 27, 8225, 23, 24, + 34, 8, 8, 24, 34, 34, 18, 19, 6, 6, + + 24, 6, 6, 34, 34, 15, 34, 34, 27, 8225, + 34, 27, 8225, 34, 27, 8225, 27, 34, 27, 34, + 34, 34, 18, 24, 18, 19, 24, 19, 6, 6, + 34, 34, 15, 34, 34, 21, 9, 20, 18, 18, + 24, 19, 19, 24, 6, 5, 6, 34, 22, 34, + 21, 24, 21, 9, 24, 9, 20, 24, 20, 4, + 6, 5, 6, 34, 22, 24, 22, 34, 21, 21, + 24, 9, 9, 24, 20, 20, 24, 4, 6, 13, + 34, 22, 22, 24, 10, 13, 34, 10, 24, 10, + 10, 10, 24 + } ; -static const flex_int16_t yy_accept[356] = +static const flex_int16_t yy_accept[373] = { 0, 1, 1, 1, 2, 3, 4, 7, 12, 16, 19, 21, 24, 27, 30, 33, 36, 39, 42, 45, 48, @@ -633,39 +636,41 @@ static const flex_int16_t yy_accept[356] = 74, 76, 79, 81, 82, 83, 84, 87, 87, 88, 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, - 109, 110, 111, 113, 115, 116, 118, 120, 121, 122, + 109, 110, 111, 112, 114, 116, 117, 119, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, - 143, 144, 145, 146, 148, 150, 151, 152, 153, 154, - - 158, 159, 160, 162, 163, 164, 165, 166, 167, 168, - 169, 170, 175, 176, 177, 181, 182, 187, 188, 189, - 194, 195, 196, 197, 198, 199, 202, 205, 207, 209, - 210, 212, 214, 215, 216, 217, 218, 222, 223, 224, - 225, 228, 231, 233, 235, 236, 237, 240, 243, 245, - 247, 250, 253, 255, 257, 258, 261, 264, 266, 268, - 269, 270, 271, 272, 273, 276, 279, 281, 283, 284, - 285, 287, 288, 289, 290, 291, 292, 293, 296, 299, - 301, 303, 304, 305, 309, 312, 315, 317, 319, 320, - 321, 322, 325, 328, 330, 332, 333, 336, 339, 341, - - 343, 344, 345, 348, 351, 353, 355, 356, 357, 358, - 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, - 371, 374, 377, 379, 381, 382, 383, 384, 387, 390, - 392, 394, 396, 397, 398, 399, 400, 401, 403, 405, - 406, 407, 408, 409, 410, 411, 412, 413, 414, 416, - 418, 419, 420, 423, 426, 428, 430, 431, 433, 434, - 436, 437, 441, 443, 444, 445, 447, 448, 450, 451, - 452, 453, 454, 455, 457, 458, 460, 462, 463, 464, - 466, 467, 468, 469, 471, 474, 477, 479, 481, 483, - 484, 485, 487, 488, 489, 490, 491, 492, 494, 495, - - 496, 497, 498, 500, 503, 506, 508, 510, 511, 512, - 513, 514, 516, 517, 519, 520, 521, 522, 523, 524, - 526, 527, 528, 529, 530, 532, 533, 535, 536, 538, - 539, 540, 542, 543, 545, 546, 548, 549, 551, 553, - 554, 556, 557, 558, 560, 561, 563, 564, 566, 568, - 570, 571, 573, 575, 575 + 143, 144, 145, 146, 147, 148, 150, 152, 153, 154, + + 155, 156, 160, 161, 162, 164, 165, 166, 167, 168, + 169, 170, 171, 172, 177, 178, 179, 183, 184, 189, + 190, 191, 192, 197, 198, 199, 200, 201, 202, 205, + 208, 210, 212, 213, 215, 217, 218, 219, 220, 221, + 225, 226, 227, 228, 231, 234, 236, 238, 239, 240, + 243, 246, 248, 250, 253, 256, 258, 260, 261, 262, + 265, 268, 270, 272, 273, 274, 275, 276, 277, 280, + 283, 285, 287, 288, 289, 291, 292, 293, 294, 295, + 296, 297, 300, 303, 305, 307, 308, 309, 313, 316, + 319, 321, 323, 324, 325, 326, 329, 332, 334, 336, + + 337, 340, 343, 345, 347, 348, 349, 350, 353, 356, + 358, 360, 361, 362, 363, 365, 366, 367, 368, 369, + 370, 371, 372, 373, 374, 376, 379, 382, 384, 386, + 387, 388, 389, 392, 395, 397, 399, 401, 402, 403, + 404, 405, 406, 407, 409, 411, 412, 413, 414, 415, + 416, 417, 418, 419, 420, 422, 424, 425, 426, 429, + 432, 434, 436, 437, 439, 440, 442, 443, 444, 448, + 450, 451, 452, 454, 455, 457, 458, 459, 460, 461, + 462, 464, 465, 467, 469, 470, 471, 473, 474, 475, + 476, 478, 479, 482, 485, 487, 489, 491, 492, 493, + + 495, 496, 497, 498, 499, 500, 502, 503, 504, 505, + 506, 508, 509, 512, 515, 517, 519, 520, 521, 522, + 523, 525, 526, 528, 529, 530, 531, 532, 533, 535, + 536, 537, 538, 539, 540, 542, 543, 545, 546, 548, + 549, 550, 551, 553, 554, 556, 557, 559, 560, 562, + 564, 565, 567, 568, 569, 570, 572, 573, 575, 576, + 578, 580, 582, 583, 585, 586, 588, 590, 591, 592, + 594, 594 } ; static const YY_CHAR yy_ec[256] = @@ -708,216 +713,224 @@ static const YY_CHAR yy_meta[35] = 1, 1, 1, 1 } ; -static const flex_int16_t yy_base[424] = +static const flex_int16_t yy_base[443] = { 0, - 0, 0, 901, 900, 902, 897, 33, 36, 905, 905, - 45, 63, 31, 42, 51, 52, 890, 33, 65, 67, - 69, 70, 889, 71, 888, 75, 0, 905, 893, 905, - 91, 94, 0, 0, 103, 886, 112, 0, 89, 98, - 113, 92, 114, 99, 100, 48, 121, 116, 119, 74, - 124, 129, 123, 135, 132, 133, 137, 134, 138, 139, - 141, 0, 155, 0, 0, 164, 0, 0, 849, 142, - 152, 164, 140, 161, 165, 166, 167, 168, 169, 173, - 174, 178, 176, 180, 184, 208, 189, 183, 192, 195, - 215, 191, 193, 223, 0, 0, 905, 208, 204, 236, - - 219, 209, 238, 196, 237, 831, 242, 815, 241, 224, - 243, 261, 244, 259, 277, 266, 286, 250, 288, 298, - 249, 283, 274, 282, 294, 308, 0, 310, 0, 295, - 305, 905, 308, 306, 313, 314, 342, 319, 316, 320, - 331, 0, 349, 0, 342, 344, 356, 0, 358, 0, - 365, 0, 367, 0, 354, 375, 0, 377, 0, 363, - 356, 809, 327, 322, 384, 0, 0, 0, 0, 379, - 905, 382, 384, 386, 390, 372, 392, 403, 0, 410, - 0, 407, 413, 423, 426, 0, 0, 0, 0, 409, - 424, 435, 0, 0, 0, 0, 437, 0, 0, 0, - - 0, 433, 444, 0, 0, 0, 0, 391, 440, 781, - 905, 769, 439, 445, 444, 447, 449, 454, 453, 399, - 464, 0, 0, 0, 0, 757, 465, 476, 0, 478, - 0, 479, 476, 753, 462, 490, 749, 905, 745, 905, - 483, 737, 424, 485, 487, 490, 500, 493, 905, 729, - 905, 502, 518, 0, 0, 0, 0, 905, 498, 721, - 905, 527, 713, 0, 705, 905, 495, 697, 905, 365, - 521, 528, 530, 685, 905, 534, 540, 540, 657, 905, - 537, 542, 650, 905, 553, 0, 557, 0, 0, 551, - 641, 905, 558, 557, 633, 614, 613, 905, 547, 555, - - 563, 565, 569, 584, 0, 0, 0, 0, 583, 570, - 585, 612, 905, 601, 905, 522, 580, 589, 594, 905, - 600, 585, 563, 520, 905, 514, 905, 586, 486, 597, - 480, 441, 905, 416, 905, 345, 905, 334, 905, 601, - 254, 905, 242, 905, 200, 905, 151, 905, 905, 607, - 86, 905, 905, 905, 620, 624, 627, 631, 635, 639, - 643, 647, 651, 655, 659, 663, 667, 671, 675, 679, - 683, 687, 691, 695, 699, 703, 707, 711, 715, 719, - 723, 727, 731, 735, 739, 743, 747, 751, 755, 759, - 763, 767, 771, 775, 779, 783, 787, 791, 795, 799, - - 803, 807, 811, 815, 819, 823, 827, 831, 835, 839, - 843, 847, 851, 855, 859, 863, 867, 871, 875, 879, - 883, 887, 891 + 0, 0, 936, 935, 937, 932, 33, 36, 940, 940, + 45, 63, 31, 42, 51, 52, 925, 33, 65, 67, + 69, 70, 924, 71, 923, 75, 0, 940, 928, 940, + 91, 95, 0, 0, 104, 921, 113, 0, 91, 99, + 114, 92, 115, 80, 100, 48, 119, 121, 122, 74, + 123, 128, 131, 129, 125, 133, 135, 136, 137, 143, + 138, 145, 0, 157, 0, 0, 168, 0, 0, 926, + 140, 146, 165, 159, 152, 164, 155, 168, 171, 176, + 177, 170, 180, 175, 184, 188, 212, 191, 185, 192, + 193, 194, 219, 212, 199, 230, 0, 0, 940, 195, + + 200, 239, 235, 197, 246, 225, 226, 919, 244, 918, + 243, 236, 245, 266, 248, 264, 282, 271, 291, 248, + 270, 254, 300, 279, 296, 302, 288, 303, 311, 0, + 315, 0, 311, 318, 940, 313, 319, 208, 313, 344, + 321, 331, 325, 333, 0, 352, 0, 345, 347, 359, + 0, 361, 0, 368, 0, 370, 0, 322, 366, 379, + 0, 381, 0, 359, 357, 923, 382, 384, 392, 0, + 0, 0, 0, 387, 940, 386, 390, 392, 329, 401, + 397, 409, 0, 417, 0, 399, 412, 426, 429, 0, + 0, 0, 0, 412, 427, 438, 0, 0, 0, 0, + + 440, 0, 0, 0, 0, 436, 405, 447, 0, 0, + 0, 0, 438, 443, 922, 940, 921, 442, 450, 449, + 452, 454, 459, 458, 453, 469, 0, 0, 0, 0, + 920, 470, 481, 0, 483, 0, 484, 481, 919, 368, + 467, 495, 918, 940, 917, 940, 488, 916, 479, 490, + 492, 495, 505, 498, 940, 915, 940, 507, 523, 0, + 0, 0, 0, 940, 503, 864, 940, 846, 532, 836, + 0, 824, 940, 516, 796, 940, 513, 530, 536, 538, + 784, 940, 542, 535, 547, 772, 940, 549, 551, 768, + 940, 502, 562, 0, 564, 0, 0, 562, 764, 940, + + 544, 557, 760, 752, 744, 940, 552, 568, 571, 568, + 581, 577, 588, 0, 0, 0, 0, 589, 580, 591, + 736, 940, 728, 940, 601, 602, 597, 599, 940, 603, + 720, 712, 700, 672, 940, 665, 940, 610, 656, 603, + 648, 607, 629, 940, 627, 940, 625, 940, 624, 940, + 607, 574, 940, 614, 572, 940, 491, 940, 433, 940, + 940, 622, 389, 940, 303, 940, 261, 940, 204, 940, + 940, 635, 639, 642, 646, 650, 654, 658, 662, 666, + 670, 674, 678, 682, 686, 690, 694, 698, 702, 706, + 710, 714, 718, 722, 726, 730, 734, 738, 742, 746, + + 750, 754, 758, 762, 766, 770, 774, 778, 782, 786, + 790, 794, 798, 802, 806, 810, 814, 818, 822, 826, + 830, 834, 838, 842, 846, 850, 854, 858, 862, 866, + 870, 874, 878, 882, 886, 890, 894, 898, 902, 906, + 910, 914 } ; -static const flex_int16_t yy_def[424] = +static const flex_int16_t yy_def[443] = { 0, - 354, 1, 355, 355, 354, 356, 357, 357, 354, 354, - 358, 358, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 12, 359, 354, 356, 354, - 360, 357, 361, 361, 362, 12, 356, 363, 12, 12, - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, + 371, 1, 372, 372, 371, 373, 374, 374, 371, 371, + 375, 375, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 12, 12, 12, 376, 371, 373, 371, + 377, 374, 378, 378, 379, 12, 373, 380, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 359, 360, 361, 361, 364, 365, 365, 354, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 12, 12, 12, 12, 362, 12, 12, 12, 12, - 12, 12, 12, 364, 365, 365, 354, 12, 12, 366, - + 12, 12, 376, 377, 378, 378, 381, 382, 382, 371, 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, - 12, 367, 86, 86, 368, 12, 369, 12, 12, 370, - 12, 12, 12, 12, 12, 371, 372, 366, 372, 12, - 12, 354, 86, 12, 12, 12, 373, 12, 12, 12, - 374, 375, 367, 375, 86, 86, 376, 377, 368, 377, - 378, 379, 369, 379, 12, 380, 381, 370, 381, 12, - 12, 382, 12, 12, 371, 372, 372, 383, 383, 12, - 354, 86, 86, 86, 12, 12, 12, 384, 385, 373, - 385, 12, 12, 386, 374, 375, 375, 387, 387, 86, - 86, 376, 377, 377, 388, 388, 378, 379, 379, 389, - - 389, 12, 380, 381, 381, 390, 390, 12, 12, 391, - 354, 392, 86, 12, 86, 86, 86, 12, 86, 12, - 384, 385, 385, 393, 393, 394, 86, 395, 396, 386, - 396, 86, 86, 397, 12, 398, 391, 354, 399, 354, - 86, 400, 12, 86, 86, 86, 401, 86, 354, 402, - 354, 86, 395, 396, 396, 403, 403, 354, 86, 404, - 354, 405, 406, 406, 399, 354, 86, 407, 354, 12, - 86, 86, 86, 408, 354, 408, 408, 86, 402, 354, - 86, 86, 404, 354, 409, 410, 405, 410, 406, 86, - 407, 354, 12, 86, 411, 412, 408, 354, 408, 408, - - 86, 86, 86, 409, 410, 410, 413, 413, 86, 12, - 86, 414, 354, 415, 354, 408, 408, 86, 86, 354, - 416, 417, 418, 414, 354, 415, 354, 408, 408, 86, - 419, 420, 354, 421, 354, 422, 354, 408, 354, 86, - 423, 354, 420, 354, 421, 354, 422, 354, 354, 86, - 423, 354, 354, 0, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354 + 12, 12, 12, 12, 12, 12, 379, 12, 12, 12, + 12, 12, 12, 12, 12, 381, 382, 382, 371, 12, + + 12, 383, 12, 12, 12, 12, 12, 12, 12, 12, + 12, 12, 12, 384, 87, 87, 385, 12, 386, 12, + 12, 12, 387, 12, 12, 12, 12, 12, 388, 389, + 383, 389, 12, 12, 371, 87, 12, 12, 12, 390, + 12, 12, 12, 391, 392, 384, 392, 87, 87, 393, + 394, 385, 394, 395, 396, 386, 396, 12, 12, 397, + 398, 387, 398, 12, 12, 399, 12, 12, 388, 389, + 389, 400, 400, 12, 371, 87, 87, 87, 12, 12, + 12, 401, 402, 390, 402, 12, 12, 403, 391, 392, + 392, 404, 404, 87, 87, 393, 394, 394, 405, 405, + + 395, 396, 396, 406, 406, 12, 12, 397, 398, 398, + 407, 407, 12, 12, 408, 371, 409, 87, 12, 87, + 87, 87, 12, 87, 12, 401, 402, 402, 410, 410, + 411, 87, 412, 413, 403, 413, 87, 87, 414, 12, + 12, 415, 408, 371, 416, 371, 87, 417, 12, 87, + 87, 87, 418, 87, 371, 419, 371, 87, 412, 413, + 413, 420, 420, 371, 87, 421, 371, 12, 422, 423, + 423, 416, 371, 87, 424, 371, 12, 87, 87, 87, + 425, 371, 425, 425, 87, 419, 371, 87, 87, 421, + 371, 12, 426, 427, 422, 427, 423, 87, 424, 371, + + 12, 87, 428, 429, 425, 371, 425, 425, 87, 87, + 87, 12, 426, 427, 427, 430, 430, 87, 12, 87, + 431, 371, 432, 371, 425, 425, 87, 87, 371, 12, + 433, 434, 435, 431, 371, 432, 371, 425, 425, 87, + 436, 12, 437, 371, 438, 371, 439, 371, 425, 371, + 87, 440, 371, 12, 437, 371, 438, 371, 439, 371, + 371, 87, 440, 371, 441, 371, 442, 371, 442, 371, + 0, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371 } ; -static const flex_int16_t yy_nxt[940] = +static const flex_int16_t yy_nxt[975] = { 0, 6, 7, 8, 9, 6, 6, 6, 6, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 17, 17, 17, 17, 20, 17, 21, 22, 23, 24, 25, 17, 26, 17, 17, 17, 32, 32, 33, 32, 32, 33, 36, 34, 36, 42, 34, 29, 29, 29, 30, 35, - 50, 36, 37, 38, 43, 44, 39, 36, 79, 45, + 50, 36, 37, 38, 43, 44, 39, 36, 80, 45, 36, 36, 40, 29, 29, 29, 30, 35, 46, 48, 37, 38, 41, 47, 36, 49, 36, 53, 36, 36, - 36, 56, 58, 36, 36, 55, 82, 60, 51, 342, - 54, 61, 52, 29, 64, 32, 32, 33, 36, 65, - - 70, 36, 34, 29, 29, 29, 30, 36, 36, 36, - 29, 38, 66, 66, 66, 67, 66, 71, 74, 66, - 68, 72, 36, 36, 73, 36, 77, 78, 36, 76, - 36, 53, 36, 36, 75, 85, 80, 83, 36, 86, - 84, 36, 36, 36, 36, 81, 36, 36, 36, 36, - 36, 36, 93, 89, 337, 98, 88, 29, 64, 101, - 90, 36, 91, 65, 92, 87, 29, 95, 89, 99, - 36, 100, 96, 36, 36, 36, 36, 36, 36, 106, - 105, 85, 36, 36, 102, 36, 107, 36, 103, 36, - 109, 112, 36, 36, 104, 108, 115, 110, 36, 117, - - 36, 36, 36, 335, 36, 36, 122, 111, 29, 29, - 29, 30, 118, 36, 116, 29, 38, 36, 36, 113, - 114, 119, 120, 123, 36, 29, 95, 121, 36, 134, - 131, 96, 130, 36, 125, 124, 126, 126, 66, 127, - 126, 132, 133, 126, 129, 333, 36, 36, 135, 137, - 36, 36, 36, 140, 139, 35, 35, 352, 36, 36, - 85, 141, 141, 66, 142, 141, 160, 145, 141, 144, - 35, 35, 89, 117, 155, 36, 146, 147, 147, 66, - 148, 147, 162, 36, 147, 150, 151, 151, 66, 152, - 151, 36, 36, 151, 154, 120, 161, 36, 156, 156, - - 66, 157, 156, 36, 36, 156, 159, 164, 171, 163, - 29, 166, 29, 168, 36, 36, 167, 170, 169, 35, - 35, 172, 36, 36, 173, 36, 213, 184, 36, 36, - 175, 36, 174, 29, 186, 212, 36, 349, 183, 187, - 177, 176, 178, 178, 66, 179, 178, 182, 348, 178, - 181, 29, 188, 35, 35, 35, 35, 189, 29, 193, - 29, 195, 190, 36, 194, 36, 196, 29, 198, 29, - 200, 191, 36, 199, 36, 201, 219, 29, 204, 29, - 206, 36, 202, 205, 209, 207, 29, 166, 36, 293, - 208, 214, 167, 35, 35, 35, 35, 35, 35, 36, - - 36, 36, 249, 218, 220, 29, 222, 216, 36, 217, - 235, 223, 29, 224, 215, 226, 36, 227, 225, 346, - 35, 35, 36, 228, 228, 66, 229, 228, 29, 186, - 228, 231, 232, 36, 187, 233, 35, 29, 193, 29, - 198, 234, 36, 194, 344, 199, 29, 204, 236, 36, - 35, 241, 205, 242, 36, 35, 35, 270, 35, 35, - 35, 35, 247, 36, 35, 35, 29, 222, 244, 262, - 248, 36, 223, 243, 245, 246, 35, 252, 29, 254, - 29, 256, 258, 342, 255, 259, 257, 35, 35, 339, - 35, 35, 69, 264, 35, 35, 35, 35, 35, 35, - - 267, 35, 35, 275, 35, 35, 35, 35, 271, 35, - 35, 276, 277, 35, 35, 272, 278, 315, 273, 281, - 29, 254, 290, 313, 282, 275, 255, 285, 285, 66, - 286, 285, 35, 35, 285, 288, 295, 298, 296, 35, - 35, 35, 35, 298, 301, 328, 299, 294, 35, 35, - 275, 35, 35, 35, 303, 29, 305, 300, 275, 29, - 307, 306, 35, 35, 302, 308, 337, 36, 35, 35, - 309, 310, 320, 316, 35, 35, 35, 35, 322, 36, - 35, 35, 317, 275, 319, 311, 29, 305, 335, 275, - 318, 321, 306, 323, 35, 35, 35, 35, 330, 329, - - 35, 35, 331, 333, 327, 35, 35, 338, 35, 35, - 353, 340, 35, 35, 350, 325, 275, 315, 35, 35, - 27, 27, 27, 27, 29, 29, 29, 31, 31, 31, - 31, 36, 36, 36, 36, 62, 313, 62, 62, 63, - 63, 63, 63, 65, 269, 65, 65, 35, 35, 35, - 35, 69, 69, 261, 69, 94, 94, 94, 94, 96, - 251, 96, 96, 128, 128, 128, 128, 143, 143, 143, - 143, 149, 149, 149, 149, 153, 153, 153, 153, 158, - 158, 158, 158, 165, 165, 165, 165, 167, 298, 167, - 167, 180, 180, 180, 180, 185, 185, 185, 185, 187, - - 292, 187, 187, 192, 192, 192, 192, 194, 240, 194, - 194, 197, 197, 197, 197, 199, 289, 199, 199, 203, - 203, 203, 203, 205, 284, 205, 205, 210, 210, 210, - 210, 169, 280, 169, 169, 221, 221, 221, 221, 223, - 269, 223, 223, 230, 230, 230, 230, 189, 266, 189, - 189, 196, 211, 196, 196, 201, 261, 201, 201, 207, - 251, 207, 207, 237, 237, 237, 237, 239, 239, 239, - 239, 225, 240, 225, 225, 250, 250, 250, 250, 253, - 253, 253, 253, 255, 238, 255, 255, 260, 260, 260, - 260, 263, 263, 263, 263, 265, 265, 265, 265, 268, - - 268, 268, 268, 274, 274, 274, 274, 279, 279, 279, - 279, 257, 211, 257, 257, 283, 283, 283, 283, 287, - 287, 287, 287, 264, 138, 264, 264, 291, 291, 291, - 291, 297, 297, 297, 297, 304, 304, 304, 304, 306, - 136, 306, 306, 312, 312, 312, 312, 314, 314, 314, - 314, 308, 97, 308, 308, 324, 324, 324, 324, 326, - 326, 326, 326, 332, 332, 332, 332, 334, 334, 334, - 334, 336, 336, 336, 336, 341, 341, 341, 341, 343, - 343, 343, 343, 345, 345, 345, 345, 347, 347, 347, - 347, 351, 351, 351, 351, 36, 30, 59, 57, 36, - - 30, 354, 28, 28, 5, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 36, 56, 58, 36, 36, 55, 83, 61, 51, 36, + 54, 62, 52, 29, 65, 59, 32, 32, 33, 66, + + 36, 36, 71, 34, 29, 29, 29, 30, 36, 36, + 77, 29, 38, 67, 67, 67, 68, 67, 75, 72, + 67, 69, 73, 36, 36, 74, 78, 79, 36, 53, + 36, 36, 36, 87, 36, 76, 84, 36, 36, 85, + 36, 81, 36, 86, 36, 36, 36, 36, 82, 36, + 92, 95, 36, 100, 36, 36, 89, 90, 88, 29, + 65, 36, 91, 101, 36, 66, 90, 93, 36, 94, + 29, 97, 102, 36, 36, 104, 98, 36, 103, 36, + 36, 107, 108, 106, 36, 36, 36, 105, 86, 36, + 109, 110, 111, 36, 36, 114, 112, 36, 117, 119, + + 36, 36, 36, 36, 36, 121, 36, 368, 36, 36, + 120, 113, 29, 29, 29, 30, 118, 36, 134, 29, + 38, 36, 127, 115, 116, 122, 123, 125, 36, 126, + 128, 124, 29, 97, 36, 36, 180, 138, 98, 129, + 129, 67, 130, 129, 36, 36, 129, 132, 133, 135, + 136, 140, 36, 36, 36, 36, 142, 36, 137, 35, + 35, 123, 86, 36, 370, 143, 144, 144, 67, 145, + 144, 148, 158, 144, 147, 35, 35, 90, 119, 36, + 36, 149, 150, 150, 67, 151, 150, 159, 36, 150, + 153, 154, 154, 67, 155, 154, 164, 36, 154, 157, + + 160, 160, 67, 161, 160, 36, 368, 160, 163, 165, + 166, 36, 36, 29, 170, 167, 168, 29, 172, 171, + 36, 175, 36, 173, 35, 35, 176, 36, 36, 177, + 36, 36, 188, 174, 36, 29, 190, 178, 36, 181, + 36, 191, 223, 179, 182, 182, 67, 183, 182, 186, + 206, 182, 185, 187, 29, 192, 35, 35, 35, 35, + 193, 29, 197, 29, 199, 194, 36, 198, 36, 200, + 29, 202, 29, 204, 195, 36, 203, 36, 205, 268, + 207, 29, 209, 29, 211, 214, 213, 210, 218, 212, + 217, 36, 353, 36, 29, 170, 36, 35, 35, 219, + + 171, 35, 35, 35, 35, 224, 36, 231, 36, 225, + 36, 29, 227, 221, 36, 222, 232, 228, 220, 29, + 229, 36, 240, 35, 35, 230, 233, 233, 67, 234, + 233, 29, 190, 233, 236, 237, 348, 191, 238, 35, + 29, 197, 29, 202, 239, 36, 198, 36, 203, 29, + 209, 242, 36, 35, 247, 210, 255, 241, 248, 36, + 35, 35, 36, 35, 35, 35, 35, 253, 36, 35, + 35, 29, 227, 250, 269, 254, 36, 228, 249, 251, + 252, 35, 258, 29, 260, 29, 262, 264, 36, 261, + 265, 263, 35, 35, 346, 35, 35, 70, 271, 35, + + 35, 35, 35, 35, 35, 274, 35, 35, 282, 35, + 35, 36, 277, 278, 35, 35, 283, 284, 35, 35, + 279, 285, 36, 280, 288, 29, 260, 35, 35, 289, + 312, 261, 293, 293, 67, 294, 293, 301, 306, 293, + 296, 35, 35, 298, 303, 306, 304, 35, 35, 35, + 35, 309, 308, 36, 307, 282, 302, 319, 35, 35, + 35, 35, 35, 311, 29, 314, 29, 316, 35, 35, + 315, 282, 317, 35, 35, 344, 310, 364, 325, 35, + 35, 318, 35, 35, 329, 320, 36, 328, 332, 36, + 29, 314, 35, 35, 330, 326, 315, 331, 327, 333, + + 35, 35, 35, 35, 282, 282, 340, 341, 35, 35, + 35, 35, 36, 282, 35, 35, 36, 351, 35, 35, + 362, 339, 365, 36, 338, 366, 342, 361, 360, 354, + 358, 349, 356, 35, 35, 27, 27, 27, 27, 29, + 29, 29, 31, 31, 31, 31, 36, 36, 36, 36, + 63, 353, 63, 63, 64, 64, 64, 64, 66, 350, + 66, 66, 35, 35, 35, 35, 70, 70, 324, 70, + 96, 96, 96, 96, 98, 322, 98, 98, 131, 131, + 131, 131, 146, 146, 146, 146, 152, 152, 152, 152, + 156, 156, 156, 156, 162, 162, 162, 162, 169, 169, + + 169, 169, 171, 348, 171, 171, 184, 184, 184, 184, + 189, 189, 189, 189, 191, 346, 191, 191, 196, 196, + 196, 196, 198, 344, 198, 198, 201, 201, 201, 201, + 203, 337, 203, 203, 208, 208, 208, 208, 210, 335, + 210, 210, 215, 215, 215, 215, 173, 282, 173, 173, + 226, 226, 226, 226, 228, 324, 228, 228, 235, 235, + 235, 235, 193, 322, 193, 193, 200, 276, 200, 200, + 205, 267, 205, 205, 212, 257, 212, 212, 243, 243, + 243, 243, 245, 245, 245, 245, 230, 306, 230, 230, + 256, 256, 256, 256, 259, 259, 259, 259, 261, 300, + + 261, 261, 266, 266, 266, 266, 270, 270, 270, 270, + 272, 272, 272, 272, 275, 275, 275, 275, 281, 281, + 281, 281, 286, 286, 286, 286, 263, 246, 263, 263, + 290, 290, 290, 290, 295, 295, 295, 295, 271, 297, + 271, 271, 299, 299, 299, 299, 305, 305, 305, 305, + 313, 313, 313, 313, 315, 292, 315, 315, 321, 321, + 321, 321, 323, 323, 323, 323, 317, 291, 317, 317, + 334, 334, 334, 334, 336, 336, 336, 336, 343, 343, + 343, 343, 345, 345, 345, 345, 347, 347, 347, 347, + 352, 352, 352, 352, 355, 355, 355, 355, 357, 357, + + 357, 357, 359, 359, 359, 359, 363, 363, 363, 363, + 367, 367, 367, 367, 369, 369, 369, 369, 287, 276, + 273, 216, 267, 257, 246, 244, 216, 141, 139, 99, + 36, 30, 60, 57, 36, 30, 371, 28, 28, 5, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; -static const flex_int16_t yy_chk[940] = +static const flex_int16_t yy_chk[975] = { 0, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, @@ -927,101 +940,105 @@ static const flex_int16_t yy_chk[940] = 18, 14, 11, 11, 13, 14, 11, 46, 46, 14, 15, 16, 11, 12, 12, 12, 12, 12, 14, 16, 12, 12, 12, 15, 19, 16, 20, 20, 21, 22, - 24, 22, 24, 50, 26, 21, 50, 26, 19, 351, - 20, 26, 19, 31, 31, 32, 32, 32, 39, 31, - - 39, 42, 32, 35, 35, 35, 35, 40, 44, 45, - 35, 35, 37, 37, 37, 37, 37, 39, 42, 37, - 37, 40, 41, 43, 41, 48, 45, 45, 49, 44, - 47, 47, 53, 51, 43, 53, 48, 51, 52, 54, - 52, 55, 56, 58, 54, 49, 57, 59, 60, 73, - 61, 70, 60, 61, 347, 70, 56, 63, 63, 73, - 58, 71, 59, 63, 59, 55, 66, 66, 57, 71, - 74, 72, 66, 72, 75, 76, 77, 78, 79, 78, - 77, 79, 80, 81, 74, 83, 80, 82, 75, 84, - 82, 85, 88, 85, 76, 81, 87, 83, 87, 89, - - 92, 89, 93, 345, 90, 104, 92, 84, 86, 86, - 86, 86, 90, 99, 88, 86, 86, 98, 102, 86, - 86, 91, 91, 93, 91, 94, 94, 91, 101, 104, - 102, 94, 101, 110, 99, 98, 100, 100, 100, 100, - 100, 103, 103, 100, 100, 343, 105, 103, 105, 107, - 109, 107, 111, 110, 109, 113, 113, 341, 121, 118, - 111, 112, 112, 112, 112, 112, 121, 113, 112, 112, - 114, 114, 116, 116, 118, 116, 114, 115, 115, 115, - 115, 115, 123, 123, 115, 115, 117, 117, 117, 117, - 117, 124, 122, 117, 117, 119, 122, 119, 120, 120, - - 120, 120, 120, 125, 130, 120, 120, 125, 131, 124, - 126, 126, 128, 128, 131, 134, 126, 130, 128, 133, - 133, 133, 135, 136, 133, 139, 164, 140, 138, 140, - 134, 164, 133, 141, 141, 163, 163, 338, 139, 141, - 136, 135, 137, 137, 137, 137, 137, 138, 336, 137, - 137, 143, 143, 145, 145, 146, 146, 143, 147, 147, - 149, 149, 145, 155, 147, 161, 149, 151, 151, 153, - 153, 146, 160, 151, 270, 153, 176, 156, 156, 158, - 158, 176, 155, 156, 161, 158, 165, 165, 170, 270, - 160, 170, 165, 172, 172, 173, 173, 174, 174, 175, - - 208, 177, 220, 175, 177, 178, 178, 173, 220, 174, - 208, 178, 180, 180, 172, 182, 182, 183, 180, 334, - 190, 190, 183, 184, 184, 184, 184, 184, 185, 185, - 184, 184, 190, 243, 185, 191, 191, 192, 192, 197, - 197, 202, 202, 192, 332, 197, 203, 203, 209, 209, - 213, 213, 203, 214, 214, 215, 215, 243, 216, 216, - 217, 217, 218, 218, 219, 219, 221, 221, 215, 235, - 219, 235, 221, 214, 216, 217, 227, 227, 228, 228, - 230, 230, 232, 331, 228, 233, 230, 233, 233, 329, - 232, 232, 236, 236, 241, 241, 244, 244, 245, 245, - - 241, 246, 246, 247, 248, 248, 267, 267, 244, 259, - 259, 247, 247, 252, 252, 245, 248, 326, 246, 252, - 253, 253, 267, 324, 259, 316, 253, 262, 262, 262, - 262, 262, 271, 271, 262, 262, 272, 276, 273, 272, - 272, 273, 273, 277, 278, 316, 276, 271, 281, 281, - 299, 278, 278, 282, 282, 285, 285, 277, 300, 287, - 287, 285, 290, 290, 281, 287, 323, 293, 294, 294, - 290, 293, 303, 299, 301, 301, 302, 302, 310, 310, - 303, 303, 300, 317, 302, 294, 304, 304, 322, 328, - 301, 309, 304, 311, 309, 309, 311, 311, 318, 317, - - 318, 318, 319, 321, 314, 319, 319, 328, 330, 330, - 350, 330, 340, 340, 340, 312, 297, 296, 350, 350, - 355, 355, 355, 355, 356, 356, 356, 357, 357, 357, - 357, 358, 358, 358, 358, 359, 295, 359, 359, 360, - 360, 360, 360, 361, 291, 361, 361, 362, 362, 362, - 362, 363, 363, 283, 363, 364, 364, 364, 364, 365, - 279, 365, 365, 366, 366, 366, 366, 367, 367, 367, - 367, 368, 368, 368, 368, 369, 369, 369, 369, 370, - 370, 370, 370, 371, 371, 371, 371, 372, 274, 372, - 372, 373, 373, 373, 373, 374, 374, 374, 374, 375, - - 268, 375, 375, 376, 376, 376, 376, 377, 265, 377, - 377, 378, 378, 378, 378, 379, 263, 379, 379, 380, - 380, 380, 380, 381, 260, 381, 381, 382, 382, 382, - 382, 383, 250, 383, 383, 384, 384, 384, 384, 385, - 242, 385, 385, 386, 386, 386, 386, 387, 239, 387, - 387, 388, 237, 388, 388, 389, 234, 389, 389, 390, - 226, 390, 390, 391, 391, 391, 391, 392, 392, 392, - 392, 393, 212, 393, 393, 394, 394, 394, 394, 395, - 395, 395, 395, 396, 210, 396, 396, 397, 397, 397, - 397, 398, 398, 398, 398, 399, 399, 399, 399, 400, - - 400, 400, 400, 401, 401, 401, 401, 402, 402, 402, - 402, 403, 162, 403, 403, 404, 404, 404, 404, 405, - 405, 405, 405, 406, 108, 406, 406, 407, 407, 407, - 407, 408, 408, 408, 408, 409, 409, 409, 409, 410, - 106, 410, 410, 411, 411, 411, 411, 412, 412, 412, - 412, 413, 69, 413, 413, 414, 414, 414, 414, 415, - 415, 415, 415, 416, 416, 416, 416, 417, 417, 417, - 417, 418, 418, 418, 418, 419, 419, 419, 419, 420, - 420, 420, 420, 421, 421, 421, 421, 422, 422, 422, - 422, 423, 423, 423, 423, 36, 29, 25, 23, 17, - - 6, 5, 4, 3, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, - 354, 354, 354, 354, 354, 354, 354, 354, 354 + 24, 22, 24, 50, 26, 21, 50, 26, 19, 44, + 20, 26, 19, 31, 31, 24, 32, 32, 32, 31, + + 39, 42, 39, 32, 35, 35, 35, 35, 40, 45, + 44, 35, 35, 37, 37, 37, 37, 37, 42, 39, + 37, 37, 40, 41, 43, 41, 45, 45, 47, 47, + 48, 49, 51, 54, 55, 43, 51, 52, 54, 52, + 53, 48, 56, 53, 57, 58, 59, 61, 49, 71, + 59, 61, 60, 71, 62, 72, 56, 62, 55, 64, + 64, 75, 58, 72, 77, 64, 57, 60, 74, 60, + 67, 67, 73, 76, 73, 75, 67, 78, 74, 82, + 79, 78, 79, 77, 84, 80, 81, 76, 80, 83, + 81, 82, 83, 85, 89, 86, 84, 86, 88, 90, + + 88, 90, 91, 92, 100, 92, 104, 369, 95, 101, + 91, 85, 87, 87, 87, 87, 89, 138, 104, 87, + 87, 94, 100, 87, 87, 93, 93, 94, 93, 95, + 101, 93, 96, 96, 106, 107, 138, 107, 96, 102, + 102, 102, 102, 102, 103, 112, 102, 102, 103, 105, + 105, 109, 111, 109, 113, 105, 111, 120, 106, 115, + 115, 122, 113, 122, 367, 112, 114, 114, 114, 114, + 114, 115, 120, 114, 114, 116, 116, 118, 118, 121, + 118, 116, 117, 117, 117, 117, 117, 121, 124, 117, + 117, 119, 119, 119, 119, 119, 124, 127, 119, 119, + + 123, 123, 123, 123, 123, 125, 365, 123, 123, 125, + 126, 126, 128, 129, 129, 127, 128, 131, 131, 129, + 133, 134, 139, 131, 136, 136, 136, 134, 137, 136, + 141, 158, 143, 133, 143, 144, 144, 136, 179, 139, + 142, 144, 179, 137, 140, 140, 140, 140, 140, 141, + 158, 140, 140, 142, 146, 146, 148, 148, 149, 149, + 146, 150, 150, 152, 152, 148, 165, 150, 164, 152, + 154, 154, 156, 156, 149, 159, 154, 240, 156, 240, + 159, 160, 160, 162, 162, 165, 164, 160, 168, 162, + 167, 167, 363, 168, 169, 169, 174, 176, 176, 174, + + 169, 177, 177, 178, 178, 180, 181, 186, 186, 181, + 180, 182, 182, 177, 207, 178, 187, 182, 176, 184, + 184, 187, 207, 194, 194, 184, 188, 188, 188, 188, + 188, 189, 189, 188, 188, 194, 359, 189, 195, 195, + 196, 196, 201, 201, 206, 206, 196, 213, 201, 208, + 208, 214, 214, 218, 218, 208, 225, 213, 219, 219, + 220, 220, 225, 221, 221, 222, 222, 223, 223, 224, + 224, 226, 226, 220, 241, 224, 241, 226, 219, 221, + 222, 232, 232, 233, 233, 235, 235, 237, 249, 233, + 238, 235, 238, 238, 357, 237, 237, 242, 242, 247, + + 247, 250, 250, 251, 251, 247, 252, 252, 253, 254, + 254, 292, 249, 250, 265, 265, 253, 253, 258, 258, + 251, 254, 277, 252, 258, 259, 259, 274, 274, 265, + 292, 259, 269, 269, 269, 269, 269, 277, 284, 269, + 269, 278, 278, 274, 279, 283, 280, 279, 279, 280, + 280, 285, 284, 301, 283, 307, 278, 301, 285, 285, + 288, 288, 289, 289, 293, 293, 295, 295, 302, 302, + 293, 308, 295, 298, 298, 355, 288, 352, 307, 310, + 310, 298, 309, 309, 311, 302, 312, 310, 319, 319, + 313, 313, 311, 311, 312, 308, 313, 318, 309, 320, + + 318, 318, 320, 320, 325, 326, 327, 328, 327, 327, + 328, 328, 330, 338, 340, 340, 342, 340, 351, 351, + 351, 326, 354, 354, 325, 362, 330, 349, 347, 342, + 345, 338, 343, 362, 362, 372, 372, 372, 372, 373, + 373, 373, 374, 374, 374, 374, 375, 375, 375, 375, + 376, 341, 376, 376, 377, 377, 377, 377, 378, 339, + 378, 378, 379, 379, 379, 379, 380, 380, 336, 380, + 381, 381, 381, 381, 382, 334, 382, 382, 383, 383, + 383, 383, 384, 384, 384, 384, 385, 385, 385, 385, + 386, 386, 386, 386, 387, 387, 387, 387, 388, 388, + + 388, 388, 389, 333, 389, 389, 390, 390, 390, 390, + 391, 391, 391, 391, 392, 332, 392, 392, 393, 393, + 393, 393, 394, 331, 394, 394, 395, 395, 395, 395, + 396, 323, 396, 396, 397, 397, 397, 397, 398, 321, + 398, 398, 399, 399, 399, 399, 400, 305, 400, 400, + 401, 401, 401, 401, 402, 304, 402, 402, 403, 403, + 403, 403, 404, 303, 404, 404, 405, 299, 405, 405, + 406, 290, 406, 406, 407, 286, 407, 407, 408, 408, + 408, 408, 409, 409, 409, 409, 410, 281, 410, 410, + 411, 411, 411, 411, 412, 412, 412, 412, 413, 275, + + 413, 413, 414, 414, 414, 414, 415, 415, 415, 415, + 416, 416, 416, 416, 417, 417, 417, 417, 418, 418, + 418, 418, 419, 419, 419, 419, 420, 272, 420, 420, + 421, 421, 421, 421, 422, 422, 422, 422, 423, 270, + 423, 423, 424, 424, 424, 424, 425, 425, 425, 425, + 426, 426, 426, 426, 427, 268, 427, 427, 428, 428, + 428, 428, 429, 429, 429, 429, 430, 266, 430, 430, + 431, 431, 431, 431, 432, 432, 432, 432, 433, 433, + 433, 433, 434, 434, 434, 434, 435, 435, 435, 435, + 436, 436, 436, 436, 437, 437, 437, 437, 438, 438, + + 438, 438, 439, 439, 439, 439, 440, 440, 440, 440, + 441, 441, 441, 441, 442, 442, 442, 442, 256, 248, + 245, 243, 239, 231, 217, 215, 166, 110, 108, 70, + 36, 29, 25, 23, 17, 6, 5, 4, 3, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, + 371, 371, 371, 371 } ; #define YY_TRAILING_MASK 0x2000 @@ -1160,9 +1177,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"standalone")) DSET(dpc,backend,BACKEND,str,STANDALONE); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -1199,9 +1224,9 @@ static int vdev_and_devtype(DiskParseContext *dpc, char *str) { #undef DPC /* needs to be defined differently the actual lexer */ #define DPC ((DiskParseContext*)yyextra) -#line 1202 "libxlu_disk_l.c" +#line 1227 "libxlu_disk_l.c" -#line 1204 "libxlu_disk_l.c" +#line 1229 "libxlu_disk_l.c" #define INITIAL 0 #define LEXERR 1 @@ -1477,13 +1502,13 @@ YY_DECL } { -#line 177 "libxlu_disk_l.l" +#line 185 "libxlu_disk_l.l" -#line 180 "libxlu_disk_l.l" +#line 188 "libxlu_disk_l.l" /*----- the scanner rules which do the parsing -----*/ -#line 1486 "libxlu_disk_l.c" +#line 1511 "libxlu_disk_l.c" while ( /*CONSTCOND*/1 ) /* loops until end-of-file is reached */ { @@ -1515,14 +1540,14 @@ yy_match: while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; *yyg->yy_state_ptr++ = yy_current_state; ++yy_cp; } - while ( yy_current_state != 354 ); + while ( yy_current_state != 371 ); yy_find_action: yy_current_state = *--yyg->yy_state_ptr; @@ -1572,152 +1597,158 @@ do_action: /* This label is used only to access EOF actions. */ case 1: /* rule 1 can match eol */ YY_RULE_SETUP -#line 182 "libxlu_disk_l.l" +#line 190 "libxlu_disk_l.l" { /* ignore whitespace before parameters */ } YY_BREAK /* ordinary parameters setting enums or strings */ case 2: /* rule 2 can match eol */ YY_RULE_SETUP -#line 186 "libxlu_disk_l.l" +#line 194 "libxlu_disk_l.l" { STRIP(','); setformat(DPC, FROMEQUALS); } YY_BREAK case 3: YY_RULE_SETUP -#line 188 "libxlu_disk_l.l" +#line 196 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 4: YY_RULE_SETUP -#line 189 "libxlu_disk_l.l" +#line 197 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 1; } YY_BREAK case 5: YY_RULE_SETUP -#line 190 "libxlu_disk_l.l" +#line 198 "libxlu_disk_l.l" { DPC->disk->is_cdrom = 0; } YY_BREAK case 6: /* rule 6 can match eol */ YY_RULE_SETUP -#line 191 "libxlu_disk_l.l" +#line 199 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown value for type"); } YY_BREAK case 7: /* rule 7 can match eol */ YY_RULE_SETUP -#line 193 "libxlu_disk_l.l" +#line 201 "libxlu_disk_l.l" { STRIP(','); setaccess(DPC, FROMEQUALS); } YY_BREAK case 8: /* rule 8 can match eol */ YY_RULE_SETUP -#line 194 "libxlu_disk_l.l" +#line 202 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } YY_BREAK case 9: /* rule 9 can match eol */ YY_RULE_SETUP -#line 195 "libxlu_disk_l.l" +#line 203 "libxlu_disk_l.l" { STRIP(','); setbackendtype(DPC,FROMEQUALS); } YY_BREAK case 10: /* rule 10 can match eol */ YY_RULE_SETUP -#line 197 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } +#line 204 "libxlu_disk_l.l" +{ STRIP(','); setspecification(DPC,FROMEQUALS); } YY_BREAK case 11: /* rule 11 can match eol */ YY_RULE_SETUP -#line 198 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } +#line 206 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } YY_BREAK case 12: +/* rule 12 can match eol */ YY_RULE_SETUP -#line 199 "libxlu_disk_l.l" -{ DPC->disk->direct_io_safe = 1; } +#line 207 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } YY_BREAK case 13: YY_RULE_SETUP -#line 200 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, true); } +#line 208 "libxlu_disk_l.l" +{ DPC->disk->direct_io_safe = 1; } YY_BREAK case 14: YY_RULE_SETUP -#line 201 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->discard_enable, false); } +#line 209 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, true); } YY_BREAK -/* Note that the COLO configuration settings should be considered unstable. - * They may change incompatibly in future versions of Xen. */ case 15: YY_RULE_SETUP -#line 204 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, true); } +#line 210 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->discard_enable, false); } YY_BREAK +/* Note that the COLO configuration settings should be considered unstable. + * They may change incompatibly in future versions of Xen. */ case 16: YY_RULE_SETUP -#line 205 "libxlu_disk_l.l" -{ libxl_defbool_set(&DPC->disk->colo_enable, false); } +#line 213 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, true); } YY_BREAK case 17: -/* rule 17 can match eol */ YY_RULE_SETUP -#line 206 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } +#line 214 "libxlu_disk_l.l" +{ libxl_defbool_set(&DPC->disk->colo_enable, false); } YY_BREAK case 18: /* rule 18 can match eol */ YY_RULE_SETUP -#line 207 "libxlu_disk_l.l" -{ STRIP(','); setcoloport(DPC, FROMEQUALS); } +#line 215 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } YY_BREAK case 19: /* rule 19 can match eol */ YY_RULE_SETUP -#line 208 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } +#line 216 "libxlu_disk_l.l" +{ STRIP(','); setcoloport(DPC, FROMEQUALS); } YY_BREAK case 20: /* rule 20 can match eol */ YY_RULE_SETUP -#line 209 "libxlu_disk_l.l" -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } +#line 217 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } YY_BREAK case 21: /* rule 21 can match eol */ YY_RULE_SETUP -#line 210 "libxlu_disk_l.l" +#line 218 "libxlu_disk_l.l" +{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } + YY_BREAK +case 22: +/* rule 22 can match eol */ +YY_RULE_SETUP +#line 219 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); } YY_BREAK /* the target magic parameter, eats the rest of the string */ -case 22: +case 23: YY_RULE_SETUP -#line 214 "libxlu_disk_l.l" +#line 223 "libxlu_disk_l.l" { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); } YY_BREAK /* unknown parameters */ -case 23: -/* rule 23 can match eol */ +case 24: +/* rule 24 can match eol */ YY_RULE_SETUP -#line 218 "libxlu_disk_l.l" +#line 227 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown parameter"); } YY_BREAK /* deprecated prefixes */ /* the "/.*" in these patterns ensures that they count as if they * matched the whole string, so these patterns take precedence */ -case 24: +case 25: YY_RULE_SETUP -#line 225 "libxlu_disk_l.l" +#line 234 "libxlu_disk_l.l" { STRIP(':'); DPC->had_depr_prefix=1; DEPRECATE("use `[format=]...,'"); setformat(DPC, yytext); } YY_BREAK -case 25: +case 26: YY_RULE_SETUP -#line 231 "libxlu_disk_l.l" +#line 240 "libxlu_disk_l.l" { char *newscript; STRIP(':'); @@ -1731,65 +1762,65 @@ YY_RULE_SETUP free(newscript); } YY_BREAK -case 26: +case 27: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 8; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 244 "libxlu_disk_l.l" +#line 253 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 27: +case 28: YY_RULE_SETUP -#line 245 "libxlu_disk_l.l" +#line 254 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 28: +case 29: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 246 "libxlu_disk_l.l" +#line 255 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 29: +case 30: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 6; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 247 "libxlu_disk_l.l" +#line 256 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 30: +case 31: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 5; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 248 "libxlu_disk_l.l" +#line 257 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 31: +case 32: *yy_cp = yyg->yy_hold_char; /* undo effects of setting up yytext */ yyg->yy_c_buf_p = yy_cp = yy_bp + 4; YY_DO_BEFORE_ACTION; /* set up yytext again */ YY_RULE_SETUP -#line 249 "libxlu_disk_l.l" +#line 258 "libxlu_disk_l.l" { DPC->had_depr_prefix=1; DEPRECATE(0); } YY_BREAK -case 32: -/* rule 32 can match eol */ +case 33: +/* rule 33 can match eol */ YY_RULE_SETUP -#line 251 "libxlu_disk_l.l" +#line 260 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"unknown deprecated disk prefix"); return 0; } YY_BREAK /* positional parameters */ -case 33: -/* rule 33 can match eol */ +case 34: +/* rule 34 can match eol */ YY_RULE_SETUP -#line 258 "libxlu_disk_l.l" +#line 267 "libxlu_disk_l.l" { STRIP(','); @@ -1816,27 +1847,27 @@ YY_RULE_SETUP } } YY_BREAK -case 34: +case 35: YY_RULE_SETUP -#line 284 "libxlu_disk_l.l" +#line 293 "libxlu_disk_l.l" { BEGIN(LEXERR); yymore(); } YY_BREAK -case 35: +case 36: YY_RULE_SETUP -#line 288 "libxlu_disk_l.l" +#line 297 "libxlu_disk_l.l" { xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0; } YY_BREAK -case 36: +case 37: YY_RULE_SETUP -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" YY_FATAL_ERROR( "flex scanner jammed" ); YY_BREAK -#line 1839 "libxlu_disk_l.c" +#line 1870 "libxlu_disk_l.c" case YY_STATE_EOF(INITIAL): case YY_STATE_EOF(LEXERR): yyterminate(); @@ -2104,7 +2135,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; @@ -2128,11 +2159,11 @@ static int yy_get_next_buffer (yyscan_t yyscanner) while ( yy_chk[yy_base[yy_current_state] + yy_c] != yy_current_state ) { yy_current_state = (int) yy_def[yy_current_state]; - if ( yy_current_state >= 355 ) + if ( yy_current_state >= 372 ) yy_c = yy_meta[yy_c]; } yy_current_state = yy_nxt[yy_base[yy_current_state] + yy_c]; - yy_is_jam = (yy_current_state == 354); + yy_is_jam = (yy_current_state == 371); if ( ! yy_is_jam ) *yyg->yy_state_ptr++ = yy_current_state; @@ -2941,4 +2972,4 @@ void yyfree (void * ptr , yyscan_t yyscanner) #define YYTABLES_NAME "yytables" -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_disk_l.h index 6abeecf279..509aad67dc 100644 --- a/tools/libs/util/libxlu_disk_l.h +++ b/tools/libs/util/libxlu_disk_l.h @@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner); #undef yyTABLES_NAME #endif -#line 291 "libxlu_disk_l.l" +#line 300 "libxlu_disk_l.l" #line 699 "libxlu_disk_l.h" #undef xlu__disk_yyIN_HEADER diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_disk_l.l index e115460d99..6d53c093a3 100644 --- a/tools/libs/util/libxlu_disk_l.l +++ b/tools/libs/util/libxlu_disk_l.l @@ -122,9 +122,17 @@ static void setbackendtype(DiskParseContext *dpc, const char *str) { if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); + else if (!strcmp(str,"standalone")) DSET(dpc,backend,BACKEND,str,STANDALONE); else xlu__disk_err(dpc,str,"unknown value for backendtype"); } +/* Sets ->specification from the string. IDL should provide something for this. */ +static void setspecification(DiskParseContext *dpc, const char *str) { + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION,str,XEN); + else if (!strcmp(str,"virtio")) DSET(dpc,specification,SPECIFICATION,str,VIRTIO); + else xlu__disk_err(dpc,str,"unknown value for specification"); +} + /* Sets ->colo-port from the string. COLO need this. */ static void setcoloport(DiskParseContext *dpc, const char *str) { int port = atoi(str); @@ -192,6 +200,7 @@ devtype=[^,]*,? { xlu__disk_err(DPC,yytext,"unknown value for type"); } access=[^,]*,? { STRIP(','); setaccess(DPC, FROMEQUALS); } backend=[^,]*,? { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } backendtype=[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); } +specification=[^,]*,? { STRIP(','); setspecification(DPC,FROMEQUALS); } vdev=[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } script=[^,]*,? { STRIP(','); SAVESTRING("script", script, FROMEQUALS); } diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c index 70eed431e4..8836c07d6b 100644 --- a/tools/xl/xl_block.c +++ b/tools/xl/xl_block.c @@ -119,6 +119,12 @@ int main_blockdetach(int argc, char **argv) fprintf(stderr, "Error: Device %s not connected.\n", argv[optind+1]); return 1; } + + if (disk.specification == LIBXL_DISK_SPECIFICATION_VIRTIO) { + fprintf(stderr, "Hotunplug isn't supported for specification virtio\n"); + return 1; + } + rc = !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) : libxl_device_disk_destroy(ctx, domid, &disk, 0); if (rc) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Sat Jul 16 16:54:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 16:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368850.600266 (Exim 4.92) (envelope-from ) id 1oCl3t-0007IY-Pl; Sat, 16 Jul 2022 16:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368850.600266; Sat, 16 Jul 2022 16:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCl3t-0007IR-MB; Sat, 16 Jul 2022 16:54:37 +0000 Received: by outflank-mailman (input) for mailman id 368850; Sat, 16 Jul 2022 16:54:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCl3t-0007IH-5J; Sat, 16 Jul 2022 16:54:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCl3t-0001W9-1Z; Sat, 16 Jul 2022 16:54:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCl3s-0005PG-Hu; Sat, 16 Jul 2022 16:54:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCl3s-00038z-HP; Sat, 16 Jul 2022 16:54:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=9YHE4vdx6BJfpi+BI4LvBcYmwjqiO98SKWln13b3gbw=; b=5S2Q+ld1V6t5nDMNIJBAAMw6/h AlQ4B9kkphwl3ni0yk6YwBngIrtA7u4tfnTPqGH/MKepLrrWkDU4e7o4L3CTRTw+UGhSnpI4cFRv8 OWzmNHy3KKXAreOzWDAiUEjJi6KPKDOXY0z0WxP1laQIn0JAI4mOonEvViLpYas6etKo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171650: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b X-Osstest-Versions-That: xen=355caa9ef29fd4bcdf48bc263e6ca3b24392490b From: osstest service owner Date: Sat, 16 Jul 2022 16:54:36 +0000 flight 171650 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171650/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171636 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171643 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171643 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171643 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171643 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171643 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171643 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171643 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171643 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171643 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171643 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171643 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171643 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen ab2977b027acbbd33a7eecda854d1911a7702f8b baseline version: xen 355caa9ef29fd4bcdf48bc263e6ca3b24392490b Last test of basis 171643 2022-07-15 14:18:13 Z 1 days Testing same since 171650 2022-07-16 06:33:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 355caa9ef2..ab2977b027 ab2977b027acbbd33a7eecda854d1911a7702f8b -> master From xen-devel-bounces@lists.xenproject.org Sat Jul 16 21:00:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 21:00:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368878.600285 (Exim 4.92) (envelope-from ) id 1oCotq-0002gD-2y; Sat, 16 Jul 2022 21:00:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368878.600285; Sat, 16 Jul 2022 21:00:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCotp-0002g6-WD; Sat, 16 Jul 2022 21:00:30 +0000 Received: by outflank-mailman (input) for mailman id 368878; Sat, 16 Jul 2022 21:00:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCoto-0002fv-CC; Sat, 16 Jul 2022 21:00:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCoto-0005iK-7P; Sat, 16 Jul 2022 21:00:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCotn-0002pU-KY; Sat, 16 Jul 2022 21:00:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCotn-00036R-K7; Sat, 16 Jul 2022 21:00:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VspY6Pl6jHJbDuNyFGTS8w63NPYOwtfWMWsFyR6SrDc=; b=r45mEC1Yn6vxHuFSX59+1xyI0L qK8Th0olAFUdUdzebEFURcI1ZAYMZgMeZB+elGCJPpy9ZE8lh/V58qKBxun6fPIdOJaFBnKdb0DIG lTDWGNuB/1BTCtG5779shzaCje49hM6njoE0tUZpgiigefhEjHWboAZoly2h7C2f1orQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171652: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-freebsd12-amd64:guest-start/freebsd.repeat:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=9b59ec8d50a1f28747ceff9a4f39af5deba9540e X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sat, 16 Jul 2022 21:00:27 +0000 flight 171652 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171652/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-freebsd12-amd64 21 guest-start/freebsd.repeat fail blocked in 171587 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 9b59ec8d50a1f28747ceff9a4f39af5deba9540e baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 4 days Failing since 171601 2022-07-12 16:11:30 Z 4 days 6 attempts Testing same since 171652 2022-07-16 09:39:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alex Deucher Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller Demi Marie Obenour Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Greg Kroah-Hartman Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilya Dryomov Jack Wang Jakub Kicinski Jason Wang Javier Martinez Canillas Jeff Layton Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Joanne Koong Johan Almbladh Johannes Berg Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marek Vasut Mario Kleiner Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Michael Chan Michael Ellerman Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Miklos Szeredi Mimi Zohar Misaka19465 Muchun Song Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Nirmoy Das Oder Chiou Pablo Neira Ayuso Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Philipp Zabel Ping-Ke Shih Prike Liang Pär Eriksson Rafael J. Wysocki Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Nguyen Vaishnav Achath Vikas Gupta Vinayak Yadawad Vitaly Kuznetsov Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Yingliang Yassine Oudjana Yefim Barashkin Yevhen Orlov Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 7756 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 16 22:41:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 22:41:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368888.600295 (Exim 4.92) (envelope-from ) id 1oCqSu-000611-Gw; Sat, 16 Jul 2022 22:40:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368888.600295; Sat, 16 Jul 2022 22:40:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCqSu-00060u-Du; Sat, 16 Jul 2022 22:40:48 +0000 Received: by outflank-mailman (input) for mailman id 368888; Sat, 16 Jul 2022 22:40:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCqSt-00060o-0p for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 22:40:47 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51e4c9cb-0558-11ed-bd2d-47488cf2e6aa; Sun, 17 Jul 2022 00:40:43 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 69F6B5C0098; Sat, 16 Jul 2022 18:40:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 16 Jul 2022 18:40:40 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Jul 2022 18:40:38 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51e4c9cb-0558-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658011240; x= 1658097640; bh=ceZsdSL2HT6asQORyI7l3sLKAzKheJh2gl0LFzFi/rg=; b=d K+Xc6EvnTGGxGTV6JrZRIHc8WvZOexzOe8O278Bg9PTS2gKXMfMW9yUaxeGWgigr +Oa4v6oaHGvyRS3xuN/jPRi4aC62fU9us2WJuD9Aug3up9VYSkvRN8gJbJvybHdW HI096u3rjsIMNe/umE6OrIu2ssPC0jE0fFk4I3apKSUE0ShlTWKur46HEnV7vlws J/IvHC/OKvrq2u525QTTt1uPGuSZfdsu2/RwKv6TPdSr6Hyt8bGO23QVwzjFhjrk HmUB4PV37dK6vdF9qloenEGGA3zlSH8S7WIaq/bP6mzhbwo5x+FA2UgfDQbyEpJx M3caUBoOe3VhTSrIxBHBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658011240; x=1658097640; bh=ceZsdSL2HT6asQORyI7l3sLKAzKh eJh2gl0LFzFi/rg=; b=n528aPq7l1Rxx0JqHkiErInu9qSoVxUCItUErdyY0bb1 OMhG/l83/N618pJPsXxPc2xPhism2869N/pVMYFSSmlsN8uwgqqUoaSwXOoh4xD3 MItEC3S4/FOQDglg97124KAA1409NzYOUDpjOTHw0E1deENYugTKpv8v6/VH07Pu DhFzzoa+9Q1+L6qMR1OxGbOhMKlhcazG5P7m5GidRzSXbGG7websUO07lwuG5G7q jX0Pt2fJX4p35KH8Q5hCVMl3M5dPhJrs4BhMz3oayPripF6LzxuULQDQLfOgiOFY lV9N/8dXldFv2Q2TaFlXNFw4mmNxPQmVMcLg1rS54A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekgedguddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sun, 17 Jul 2022 00:40:35 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="V1v6WYkCrxpsBPdv" Content-Disposition: inline In-Reply-To: --V1v6WYkCrxpsBPdv Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 17 Jul 2022 00:40:35 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger On Thu, Jul 14, 2022 at 08:05:28AM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > +struct xue { > > + struct xue_dbc_reg *dbc_reg; > > + struct xue_dbc_ctx *dbc_ctx; > > + struct xue_erst_segment *dbc_erst; > > + struct xue_trb_ring dbc_ering; > > + struct xue_trb_ring dbc_oring; > > + struct xue_trb_ring dbc_iring; > > + struct xue_work_ring dbc_owork; > > + char *dbc_str; > > + > > + pci_sbdf_t sbdf; > > + uint64_t xhc_mmio_phys; > > + uint64_t xhc_mmio_size; > > + uint64_t xhc_dbc_offset; >=20 > One more observation: None of these four field look to be needed. > They're all used only in a single function, so could be local > variables there (and xhc_dbc_offset is only ever written, so > could be dropped altogether). While xhc_mmio_size indeed isn't used outside of this function, xhc_mmio_phys and xhc_dbc_offset are in later patches. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --V1v6WYkCrxpsBPdv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLTPmMACgkQ24/THMrX 1ywlEQf7BqEwX/O78YamDaHtZ6aSO7ZjejZx1ZG5inBoKTuJ/qQuH4voOjXfFcJH u/QDp4Xn/UCgbZuXJqKGucqavc5fVHhZgdvtLGhNlMPZ00CxTj4V2+v4ZcbCzKba yTHadDKx18NrFPQCQ03OyjkkPndP39bx4N++IYUtSvMOAPvordfMFoI6I5aGrV/F AoqL+bq2SHtAaVi/+F9ENITmJ4EWmorrEhdYseBWYQ6xRKBONa5+mW0ZexRBvvSx 4qDFNV9HbdEmsQ+oj50RJvMMPy2gxa3K+gsR9S+O7nTyeBzj1mODn1IIDm8pyg4W 2Qs4iotBWchrQTjsZLuXJrFACZ4UHQ== =wO1A -----END PGP SIGNATURE----- --V1v6WYkCrxpsBPdv-- From xen-devel-bounces@lists.xenproject.org Sat Jul 16 22:48:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 22:48:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368895.600307 (Exim 4.92) (envelope-from ) id 1oCqZp-0006sy-8E; Sat, 16 Jul 2022 22:47:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368895.600307; Sat, 16 Jul 2022 22:47:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCqZp-0006sr-4T; Sat, 16 Jul 2022 22:47:57 +0000 Received: by outflank-mailman (input) for mailman id 368895; Sat, 16 Jul 2022 22:47:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCqZm-0006sS-KT for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 22:47:55 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 514e2423-0559-11ed-924f-1f966e50362f; Sun, 17 Jul 2022 00:47:50 +0200 (CEST) Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26GJ99t8024361; Sat, 16 Jul 2022 22:47:14 GMT Received: from iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta01.appoci.oracle.com [130.35.100.223]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbnvt8s6w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 16 Jul 2022 22:47:14 +0000 Received: from pps.filterd (iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26GMY4lH022122; Sat, 16 Jul 2022 22:47:13 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2177.outbound.protection.outlook.com [104.47.73.177]) by iadpaimrmta01.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3hc1k1k70r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 16 Jul 2022 22:47:12 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MN2PR10MB4190.namprd10.prod.outlook.com (2603:10b6:208:19a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Sat, 16 Jul 2022 22:47:10 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5438.021; Sat, 16 Jul 2022 22:47:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 514e2423-0559-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=uKdMkqz3E2oTHDk7To4ERXtK95ZP047rw2nRDj0jbtM=; b=jXGVlyL2f4oV+G0SR8SbR1s9XuHgoli6KGsxxAl06UNwkwBUcI/Tvbue39YYyTfYKhED WbCrJER4fYv0Tu1o/6FelWI1t2URBAdCEhwX8lU1EO9TKs4knR8mfErjE8c7A40gT6nn T/7jwSvvxPAsMRoq2IjWMRdv9BrGLtFNitBOZah4DrgpUVntoKkcHtAhNUzmKji5PSfy LQ2Kl+DSZsZBGwPTd2W8mDtGn4iAfG2ECuYvegh+t3azEXzJU59YHO0dPExvWR1ZOREH o/ZJJCaKkmPcNTCy2a4qbrDIzG8VCuVO67CdaYtoSk05FDwNvCPyPXwqdcxXxsfI4JI+ Wg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b8bQu7LIrWEucKcf1eNXLotv7i9piKTkNLuSxoVzo90gAw9R2qyH9Bc/2obMW5bfnH2gxtZG21TGjrX5SrxllrGGr6eqJf2QpBoj8L7EggQpULA0uy2cG7t8d81/t/Udr1O66DMlnRRIdxgyDPsJHs4QUMz5Skosw8GUSYoTuuspOKYBEwdf2wZPg4y14+a9+LAcW96UT1zw5MQBIbHY3c8zO40ME3BqOwk/JrOudIIp8z6sYnWH9TogFciQN1y8ZPdIAcoKDObPsJaErd03y0waD9o9jK9ZbIRPIqogrjPiyOPw7Rbp/3XGeDiq75dG+2K1N/VNljk4S2z0OLJoZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKdMkqz3E2oTHDk7To4ERXtK95ZP047rw2nRDj0jbtM=; b=IQCNpEipV+EZMWccufNrtolHk9mPGFgkwThQvKowzHn/nn+m9CLwnwTXY63bv7RwN1AiFWclivDMLw1wUzZ0jmLRedBTBzTto56SZ0GgXScYj5LKsyYBoQLiNFa8Sv1+utNBVXutrQ4K4jMYwbtkMh6llZfKp7RxTe3KpqDvLDAp+SW51dOyF9x52JamSp8Skn68+zKjSvieLDmak84h4YOOXT5YigKKkPMYvBCZHPr8EsJb+6kjl+sChzJBXNrtg/WE27rr1OgFVVc3mqChCxem9XpDcIAtS8cywd92bELGMlmEm2TMwT6kj++R9XDdjvQvDGaLKrbPgZByVpyQqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKdMkqz3E2oTHDk7To4ERXtK95ZP047rw2nRDj0jbtM=; b=WeUVD1VLfKzvINRMASO264IewzNlbmmlYh6S71HNSRNrx0RJARdO+vDKgWuvvdXw2rmv4t/uRXka+FjbDFVwM71ZXmknD0wRtbzyQQhyfxnSG9yzunHSBgtHPqX0N1Ws/5MbE7jbVmq+OnkANl+A4fP/lL9UOIIfG6XiJAfOy0g= Message-ID: Date: Sat, 16 Jul 2022 18:47:05 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Content-Language: en-US To: Nicolai Stange , Greg KH Cc: Juergen Gross , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, Ben Hutchings References: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> <875yjxrp66.fsf@linux.fritz.box> From: Boris Ostrovsky In-Reply-To: <875yjxrp66.fsf@linux.fritz.box> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR06CA0090.namprd06.prod.outlook.com (2603:10b6:3:4::28) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 094a27b7-e244-48b2-8ed7-08da677d1e5a X-MS-TrafficTypeDiagnostic: MN2PR10MB4190:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bdEO53L4WYbh6vNCO7Ow7JO4g4mYXzy1PhD82MamuNkDZUGIjzEDqJ6CLEn8GPqGCMWZzd2qOp38A5zQm5/Rx+ntsHqNpHhaOAphCqkIKwfdKc/ajtXcaWzWCG/w8/U72koH30DptMM0wugaMc2f9cQOlbUZviWxTI1y/noy4bidUV3l/10OBZaIfx0m9HwrCDVGorSR3bSKx4k61+2+z5Qgt4+QV/gb+ddo37s24Q7dP/ITC+EZKP6RpkWs1Cg7f17pFpTZkulIMvrDzEAu2SdeZbzyalvh3bKNqOW260CCreBKTFw1yTR0CQPYn26QHGYzVQwlJllsKVZSI68+QXcLWwjWWtYHJjQrJc2BurIBJCMHQuk1sGb7owK10nLwk+vVJVsAVK4t4wQBSOzbWP5xcggZwvaPdHKV5VXM8y0zU/jT/jAwQN3DLjjJJa7QXl8h5OUBATGKdM/sv3H172ORsSAXai+MMtrtNmDaae0GC4P4rNAuMjfTE+Tj1xa6nblHveiPIdmolkFYaC5rSr3+WV0pEiH5xzJc82I6CydKuuWPk8LAWdwPGcsZZ7kU5b/9GUczgv1exBpmmaMP9UTW/GPtC0Y1xeKkhicTFlucgFIzxMN3Bu+8YMhl29f5+Rkt8N7MneGagG6oHPOh/rcxjptqB1buyo4wk5K+gZ6uYMvxEYuB3t69QcZxQQNfGuK0VHHnEIcKrSyssqIXfSuxtBKxfpUCWXwfYmYEIJA8KjxO8V4kqRT9oEo2NRlAmTCSMFD4ILjmuifNstOKtwoxW23LR8fudxoIJw5feGaC5Mfnw6DSMQZMNoOqYTovFHo6BVpk2tqfZ86sBxl7vDZEd3B2bbR4okgZvehma8a26uwR4yFa7TxoMS3WWtIg X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(39860400002)(376002)(396003)(366004)(6666004)(41300700001)(53546011)(26005)(6512007)(6506007)(2906002)(66946007)(66556008)(66476007)(38100700002)(8676002)(4326008)(5660300002)(7416002)(966005)(6486002)(478600001)(83380400001)(31696002)(86362001)(8936002)(36756003)(186003)(110136005)(54906003)(31686004)(2616005)(316002)(44832011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z0MweW5VSjFKTEt1eHoza2R6Y2RldytMZGxWYURVamhCbFI5NVJEbEZCYnhk?= =?utf-8?B?Vy9FVnFKeEVyTTU0d3h1UWlTZHFRU21rU3FVMkhMMGVJeFVNOXlvMzFNRW84?= =?utf-8?B?dzFJc1BReFg5akZKM3FhazFObmJnektXb0huU3k2OEJYM3NlRHk0OE12c3gr?= =?utf-8?B?aHFPYzRyQ1hxQTJzbTR6dmN0TnhXRGthY1pZLzhWZ1VqL3o4bFRURjRkbnpR?= =?utf-8?B?NzFTRVRCc2ozZTF2R3BPVExQSXlWa0NLUWd6bDl5SHRxVWF4OVlic0tiOVlL?= =?utf-8?B?bk10MCsvNlNzaUFKUGRuMVFGUXh0YUM5Si9lazBPVWdnbjJxdDIrMlp1emwy?= =?utf-8?B?ZWJLYUEvMG1IeGlZUXV3dXIrUUxaN0ViZ0IxYnpjNTJaOFcvS1lPSDRYMXF3?= =?utf-8?B?emtDWGxtdzVMUDNxT1JLS2FKcnNCOStZOEtPQjZ2MzJmVmN5dW1panI1TDNk?= =?utf-8?B?Rm1FVDNZaE1zMU1SRzdsd0p2aUlFZDZ4YnZHc1QzTHl0cFVNY1l4M2JVNGhz?= =?utf-8?B?akJHMmdHTVR5dlJSMGJQTVl4UGpLdHJDNHNvcjJ4L2JZdzFiMHo3eWxvMVIv?= =?utf-8?B?TFdLM01EbEhJdDJvWnJsakFYTys0K1lSUVljamFSWitFZm54TExoSEloNlh1?= =?utf-8?B?Z3hxUGhXWUl5azlCdlFKUkxBWDVZclJlb2tHQXovNVdWZGliMUtLSklPWmF6?= =?utf-8?B?K0ZtYXdLenFqdTZuTUhkMjFrdDh6QW1jaEI1S0JVNTZNS0EweXAzZExDbllZ?= =?utf-8?B?NmhEckRUYzRXTE85cHo3dHllS2tVWlJWQ2JTZHppL3RMQmlLYWVEWDZtZkdD?= =?utf-8?B?MFFlSmhOSXFnOTFxL05rZFg5Zi9ydC9WbGJzenBZemV6dlpuVXVSRWFsbndw?= =?utf-8?B?aFN3bzVidXN3RGFzZEJpMUc1djZEL1oyL0dQcExKWmxzdHBZcEhKeVh5ZXpi?= =?utf-8?B?MVVOQ0RpSjZSSWhpM0RVTWhsQnV6bXFiYVE5ZTJIZmZzQnpZYzd2TGlWRTc2?= =?utf-8?B?elFLemUxTUljQWUwelRYeTZncENDdCtxSUQxRWdwdysyVlBYNzFETWhsc3E2?= =?utf-8?B?b1VSV2hJWG8zeWF1d0FSQ2gvQUVtbStXWHNSaEMzeUtKc3BCSThLQi91Uk9m?= =?utf-8?B?aE1Wai9PcVoycXBQOTlkcnJTa0JTeitHTXo1c0VlR1FZSTc5ck12OGhPWGR4?= =?utf-8?B?bDIxT09LL1RUNEh2amQ0dTB0THJ2ZExRblVSRWJwalVINzdpQzQxblBtSHlN?= =?utf-8?B?VXhLdVZnSFBVUFhwM2lYYi9nczVUekdOcWwwd2hYc0xGZ3JwbkJFcGxkMUJ6?= =?utf-8?B?NzNVTjBpaXZOV0tmY1ppQVQ2bXNsZ1gwdFl5MElFcGdaMVdmb3FuNUVMV0hi?= =?utf-8?B?OFIyRDhwM29uTGRTNHlvYzZ2b083WEdUeTdwV01ZSmNqbjI5dU9zeEtySXli?= =?utf-8?B?OGdxTU50Y3VOanlWSytsY3RhTk42TzB4ckFoNEM4bUNxTXJLU0l1cnUweS9H?= =?utf-8?B?emlsOVJ6Vm1SYnBSQXZCY2JHdU9DQ2daWVp1RWtGdnc4N2I0bVpMdC8xWUNt?= =?utf-8?B?T0dqUTA4TjJyTFQ0OStwQzIraWdMd3ZmQVNuQUZRRVVZVmY2MEpldmdJTWI2?= =?utf-8?B?UnA1UjRIUXRoSXJIK0V5VHNzQkttTU10bjRQRUdtWktyZlNiYXdFbVhiL0U4?= =?utf-8?B?VFducEZ6eS9zdWNPenFpV3pOZ3JmeDFFSFBpbFdsYnVwUTNnSzg0cVVUb1dv?= =?utf-8?B?My9NS295YmpydnVIMnNYK3RmUS9SQXl5NFcxOXlzaFFKNUh4YXhRekgxNGlm?= =?utf-8?B?NnFraVJOT01xcDNGbnhtaEJxSjRxaHhEa1pvb3BDSFc3VFhUSS9UOExTSlY2?= =?utf-8?B?VWdCR3dVeHRrb2VGUFlkU1c0djNxUXBTM204OVJRbTlIWWhJbU90UXpwR0lO?= =?utf-8?B?VUQyVFZqQVBBdmducTVDVlV3YXZuaS96MDhJK1RJbWpkazFwQjhiVUNOeW1y?= =?utf-8?B?dmZRKzkzeWFmVWE4K3crblhjNk5KY3NvTkhTRWtTTDBvQjVhVWR3UXgydmFu?= =?utf-8?B?QTNjTEswQk9YL1lscytpQ1hLWk5wSlgxenM3a1NlbWhvOXU3VHMrNi93QWsz?= =?utf-8?B?UGZxTWZRbnc0eVNPM1pQODhVNkE0c0NOWk44bzdCQTd4dG95YTlPcERRdmxP?= =?utf-8?B?c1E9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 094a27b7-e244-48b2-8ed7-08da677d1e5a X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2022 22:47:10.5576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Nh37PECMHjU+ML83Y8Kv77vrO3TPti7oG2NCWOXh3xOf4oPLH9rnSfveSz1H7aLqh4BRviEQBho1YkOkKoPrQzWU402XfAksNBz2U/YEPyo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4190 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-16_19,2022-07-15_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207160100 X-Proofpoint-GUID: OGvBwwcZGHL3kQYk7FqZyMcBbqjnKKHC X-Proofpoint-ORIG-GUID: OGvBwwcZGHL3kQYk7FqZyMcBbqjnKKHC On 7/16/22 12:35 PM, Nicolai Stange wrote: > Hi, > > I see a patch for this has been queued up for 5.10 already ([1]), I'm > just sharing my findings in support of this patch here -- it doesn't > merely exchange one warning for another, but fixes a real issue and > should perhaps get applied to other stable branches as well. > > TL;DR: for this particular warning, objtool would exit early and fail to > create any .orc_unwind* ELF sections for head_64.o, which are consumed > by the ORC unwinder at runtime. > > > Boris Ostrovsky writes: > >> On 7/12/22 3:31 PM, Greg KH wrote: >>> On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote: >>>> >>>> On 7/12/22 12:38 PM, Greg KH wrote: >>>>> Hi all, >>>>> >>>>> I'm seeing the following build warning: >>>>> arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction >>>>> in the 5.15.y and 5.10.y retbleed backports. > > The reason for this is that with RET being multibyte, it can cross those > "xen_hypecall_*" symbol boundaries, because ... > >>>>> >>>>> I don't know why just this one hypercall is being called out by objtool, >>>>> and this warning isn't in 5.18 and Linus's tree due to I think commit >>>>> 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there. >>>>> >>>>> But, is this a ret call that we "forgot" here? It's a "real" ret in >>>>> Linus's branch: >>>>> >>>>> .pushsection .noinstr.text, "ax" >>>>> .balign PAGE_SIZE >>>>> SYM_CODE_START(hypercall_page) >>>>> .rept (PAGE_SIZE / 32) >>>>> UNWIND_HINT_FUNC >>>>> ANNOTATE_NOENDBR >>>>> ANNOTATE_UNRET_SAFE >>>>> ret >>>>> /* >>>>> * Xen will write the hypercall page, and sort out ENDBR. >>>>> */ >>>>> .skip 31, 0xcc >>>>> .endr >>>>> >>>>> while 5.15.y and older has: >>>>> .pushsection .text >>>>> .balign PAGE_SIZE >>>>> SYM_CODE_START(hypercall_page) >>>>> .rept (PAGE_SIZE / 32) >>>>> UNWIND_HINT_FUNC >>>>> .skip 31, 0x90 > > ... the "31" is no longer correct, ... > >>>>> ANNOTATE_UNRET_SAFE >>>>> RET > > ... as with RET occupying more than one byte, the resulting hypercall > entry's total size won't add up to 32 anymore. Right! I haven't thought about that part. I think this has been broken since 14b476e07fab ("x86: Prepare asm files for straight-line-speculation"). It still shouldn't matter as far as correct execution is concerned which is probably why noone complained. > > Note that those xen_hypercall_* symbols' values are getting statically > calculated as 'hypercall page + n * 32' in the HYPERCALL() #define from > xen-head.S. So there's a mismatch and with RET == 'ret; int3', the > resulting .text effectively becomes > > 101e: 90 nop > 101f: c3 ret > > 0000000000001020 : > 1020: cc int3 > 1021: 90 nop > 1022: 90 nop > > > This is probably already not what has been intended, but because 'ret' > and 'int3' both are single-byte encoded, objtool would still be able to > find at least some "starting instruction" at this point. > > But with RET == 'jmp __x86_return_thunk', it becomes > > 101e: 90 nop > 101f: e9 .byte 0xe9 > > 0000000000001020 : > 1020: 00 00 add %al,(%rax) > 1022: 00 00 add %al,(%rax) > 1024: 90 nop > > Here the 'e9 00 00 00 00' jmp crosses the symbol boundary and objtool > errors out. > Ah, thanks for explanation. Then I think we need to replace .skip 31, 0x90 with something like #if defined(CONFIG_RETHUNK) && !defined(__DISABLE_EXPORTS) && !defined(BUILD_VDSO) #define SKIP_BYTES 27 /* RET is 'jmp __x86_return_thunk' (5 bytes) */ #else /* CONFIG_RETPOLINE */ #ifdef CONFIG_SLS #define SKIP_BYTES 30 /* RET is 'ret; int3' (2 bytes) */ #else #define SKIP_BYTES 31 /* RET is 'ret' (1 byte) */ #endif .skip SKIP_BYTES, 0x90 (I don't have patched 5.15 so I am going by what mainline looks like) Or replace RET with ret. (Although at least with unpatched 5.15 the warning below is still generated) -boris >>>>> .endr >>>>> >>>>> So should the "ret" remain or be turned into "RET" in mainline right >>>>> now? >>>> >>>> >>>> It doesn't matter --- this is overwritten by the hypervisor during >>>> initialization when Xen fills in actual hypercall code. > > It does makes a difference though: even though objtool reports only a > warning, it still exits early in this particular case and won't create > any of the .orc_unwind* or .return_sites sections for head_64.o as it's > supposed to. > > The significance of not having .orc_unwind* for head_64.o is that the > reliable stacktracing implementation would mark the swapper tasks' > stacktraces as unreliable at runtime, because the ORC unwinder would > fail to recognize their final secondary_startup_64() from head_64.o as > being the end. Note that livepatching relies on reliable stacktraces > when transitioning tasks. > > >>>> >>>> >>>> So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes. The latter was not really necessary but harmless. >>>> >>>> >>>> So it can be 'ret', RET, or anything else that tools don't complain about. It will not be executed. >>> Cool, thanks. >>> But what about the objtool warning that I now see? Is that "real"? >> >> >> >> It's not real in the sense that the code there is not real, it will be overwritten. (Originally the whole page was 'nop's) >> >> >> I am getting a different error BTW: >> >> arch/x86/kernel/head_64.o: warning: objtool: .text+0x5: unreachable instruction >> > > I think this one is (mostly?) harmless, at least as as far as the > .orc_unwind* generation is concerned. Josh would know more. > > > Thanks, > > Nicolai > > [1] https://lore.kernel.org/r/Ys+8ZYxkDmSCcDWv@kroah.com > >> >> >>> I don't run any Xen systems, so I can't test any of this myself. >> >> >> You can't test any changes to that code --- it is rewritten when Xen guest is running. >> >> >> We probably do want to shut up objtool. Josh, any suggestions? >> >> >> -boris >> > From xen-devel-bounces@lists.xenproject.org Sat Jul 16 23:33:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 16 Jul 2022 23:33:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368902.600318 (Exim 4.92) (envelope-from ) id 1oCrHP-0004Kw-M4; Sat, 16 Jul 2022 23:32:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368902.600318; Sat, 16 Jul 2022 23:32:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCrHP-0004Kp-JE; Sat, 16 Jul 2022 23:32:59 +0000 Received: by outflank-mailman (input) for mailman id 368902; Sat, 16 Jul 2022 23:32:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCrHO-0004Kd-13 for xen-devel@lists.xenproject.org; Sat, 16 Jul 2022 23:32:58 +0000 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9cb9d13b-055f-11ed-924f-1f966e50362f; Sun, 17 Jul 2022 01:32:56 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id C42F35C006E; Sat, 16 Jul 2022 19:32:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 16 Jul 2022 19:32:52 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Jul 2022 19:32:51 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9cb9d13b-055f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658014372; x= 1658100772; bh=AyLBseLVw0cxvFBVtnYDeDLdNs68t9fYviQCJ7yrw/E=; b=o ECoCc5KDdwSFpi1YrmCMYg5KY6/eM4FML5Ri+453lYK+s21s4BUtG3PbGgtBQoIb VjaSItb31NDR3ZdPz/bcLYIwYPJ9PiBddeGbrtPzbAn0vxTuf2kJk4xVL6SMqpT6 Gqunr6Nsga+67ZwE2JdW7DncBjM4UI2d++LJVCh4MwvrlG/H2ouzv4w6TjeYI9PF /Kb0KZlLcEigDHWX6A1TbqL1D/qz9WFQ6odiZpuHr31GCZRdn8zP5mUHYhMrM8Gp KLvnzgyVlMsNn27N5bqLESTlPoiCt5uTMfvQ02bjKVuIdMF5tIlolpwertVgcO/m U3N6CL1ucw5GM2e4R9qDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658014372; x=1658100772; bh=AyLBseLVw0cxvFBVtnYDeDLdNs68 t9fYviQCJ7yrw/E=; b=UqwPEzTsxlnSoNqtE8Uwhgq9b25c11FfE8R0HAdq1zAW 7cetDHAamQpF9zeaXbnLACotU61l1/DI29/YE5g9JuAexxE03PEhhRGenVEpfnFT Aj2yrURXF5PbKP8UKEGOV+m1XqoTRQnmT4OUCrvcMWyqs/K3lkl0nRFgdFjbltqE wI/dv4ho0fXJQadYUnk5y7ivxmQYBddUgP6OJDrfeFmbB2bryorEKbO7CayC/udx 4Tqnc3ifqT7dMA800lUMVuxBZQOgvv4yTG8WauH/B1zKOZ/hxaO1Ds+tZquuic/n AeIQKfjy74G6WFKXac17lkxanJUaFJ4oG6oNwv0lrA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekgedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Sun, 17 Jul 2022 01:32:48 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bqKZOL95VrcQIk2G" Content-Disposition: inline In-Reply-To: --bqKZOL95VrcQIk2G Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Sun, 17 Jul 2022 01:32:48 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > +static int xue_init_dbc(struct xue *xue) > > +{ > > + uint64_t erdp =3D 0; > > + uint64_t out =3D 0; > > + uint64_t in =3D 0; > > + uint64_t mbs =3D 0; > > + struct xue_dbc_reg *reg =3D xue_find_dbc(xue); > > + > > + if ( !reg ) > > + return 0; > > + > > + xue->dbc_reg =3D reg; > > + xue_disable_dbc(xue); > > + > > + xue_trb_ring_init(xue, &xue->dbc_ering, 0, XUE_DB_INVAL); > > + xue_trb_ring_init(xue, &xue->dbc_oring, 1, XUE_DB_OUT); > > + xue_trb_ring_init(xue, &xue->dbc_iring, 1, XUE_DB_IN); > > + > > + erdp =3D virt_to_maddr(xue->dbc_ering.trb); > > + if ( !erdp ) > > + return 0; > > + > > + memset(xue->dbc_erst, 0, sizeof(*xue->dbc_erst)); > > + xue->dbc_erst->base =3D erdp; > > + xue->dbc_erst->size =3D XUE_TRB_RING_CAP; > > + > > + mbs =3D (reg->ctrl & 0xFF0000) >> 16; > > + out =3D virt_to_maddr(xue->dbc_oring.trb); > > + in =3D virt_to_maddr(xue->dbc_iring.trb); > > + > > + memset(xue->dbc_ctx, 0, sizeof(*xue->dbc_ctx)); > > + xue_init_strings(xue, xue->dbc_ctx->info); > > + xue_init_ep(xue->dbc_ctx->ep_out, mbs, xue_ep_bulk_out, out); > > + xue_init_ep(xue->dbc_ctx->ep_in, mbs, xue_ep_bulk_in, in); > > + > > + reg->erstsz =3D 1; > > + reg->erstba =3D virt_to_maddr(xue->dbc_erst); > > + reg->erdp =3D erdp; > > + reg->cp =3D virt_to_maddr(xue->dbc_ctx); >=20 > The only place this field is read looks to be xue_dump(). >=20 > > +static struct xue_trb evt_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZ= E); > > +static struct xue_trb out_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZ= E); > > +static struct xue_trb in_trb[XUE_TRB_RING_CAP] __aligned(XUE_PAGE_SIZE= ); > > +static struct xue_erst_segment erst __aligned(64); > > +static struct xue_dbc_ctx ctx __aligned(64); > > +static uint8_t wrk_buf[XUE_WORK_RING_CAP] __aligned(XUE_PAGE_SIZE); > > +static char str_buf[XUE_PAGE_SIZE] __aligned(64); >=20 > While I think I can see the point of the page-size alignment, can you > please clarify the need for the three instances of 64-byte alignment? (Guessing why original author of this code did it this way) At least ERSTBA (5.5.2.3.2 section of the spec) is required to be 64-byte aligned by the xHCI spec. Interestingly the DbC version of this register (DCERSTBA, section 7.6.8.3.2) requires just 16-byte alignment. ctx seems to require just 16-byte alignment too, and str_buf (in practice) requires just 2-byte alignment. I'll try to reduce those alignments and see if that still works... --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --bqKZOL95VrcQIk2G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLTSp8ACgkQ24/THMrX 1yx6GQf8CyX1b7X/rrlEXSSdK1+GTeAP/I1fgx4N3OAq6GceCvkBzys6tJKuA8CO S6ee0BOkOwWCmwqcJOMD7ZudO9e0i04Y+5YqmCwvIVMv0jx8Yk4H/hH5OGPgHDjR R9Cw/XRFS5ie0uMvV/K4nHJj0ErH+uWbExIFKdSp6wlX1EBADwpLanxdaYsR35em AV2+77FL8MgXHETfR+QRn8BTNrrcD9puu5U4dt7O9CFhNzp2HuGM+B1MK8DAHKLC sdzrhaqfb/v8XAtBrq3/PsXhPa2NJ2T9E4aWy1yLdUTG3ZJQHFKZKcU/2Ljl82I+ 8Kp0xCvt40JiFbPmfbxE2gQiMrQZiA== =Ou61 -----END PGP SIGNATURE----- --bqKZOL95VrcQIk2G-- From xen-devel-bounces@lists.xenproject.org Sun Jul 17 02:34:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 02:34:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368915.600329 (Exim 4.92) (envelope-from ) id 1oCu6o-0007JX-Ks; Sun, 17 Jul 2022 02:34:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368915.600329; Sun, 17 Jul 2022 02:34:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCu6o-0007J7-FB; Sun, 17 Jul 2022 02:34:14 +0000 Received: by outflank-mailman (input) for mailman id 368915; Sun, 17 Jul 2022 02:34:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCu6m-0007Ix-JD; Sun, 17 Jul 2022 02:34:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCu6m-0002Mx-GK; Sun, 17 Jul 2022 02:34:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCu6l-00066q-VH; Sun, 17 Jul 2022 02:34:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCu6l-00038G-UA; Sun, 17 Jul 2022 02:34:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CuIm091UboCTe6toi6Y4HGdEPfEc91feI4VA9wu/Gns=; b=sMoLfKG1R6n1PJJ1t1zroHbo3y yVa4jV0qM3Ef8ZOemZ9J4pj6J4oKCLJQcp86zomqbktaMUNdllyBxEoFLOnTm2TxQl/meaSnd5VfV vbdF6SxQiL/5xA6wPEGFhz2DOEjXj2QndrYas/fRXEuFgWmb68v4n5ZmqmGq/JaxxeMU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171654: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:host-ping-check-xen:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-armhf-armhf-xl-rtds:guest-start.2:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=c5fe7a97f20c7f3070ac870144515c0fabc6b999 X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sun, 17 Jul 2022 02:34:11 +0000 flight 171654 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171654/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 10 host-ping-check-xen fail REGR. vs. 171587 build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 19 guest-start.2 fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux c5fe7a97f20c7f3070ac870144515c0fabc6b999 baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 5 days Failing since 171601 2022-07-12 16:11:30 Z 4 days 7 attempts Testing same since 171654 2022-07-16 21:11:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alex Deucher Alex Deucher Alexander Gordeev Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda AngeloGioacchino Del Regno Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bean Huo Biju Das Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue C. Erastus Toe Changyuan Lyu Chanho Park Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Christian Zigotzky Christoph Hellwig Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Darren Stevens Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller Demi Marie Obenour Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Greg Kroah-Hartman Guangwu Zhang Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilpo Järvinen Ilya Dryomov Israel Rukshin Jack Wang Jakub Kicinski Jason A. Donenfeld Jason Wang Javier Martinez Canillas Jeff Layton Jens Axboe Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Jiri Slaby Joanne Koong Joe Lawrence Johan Almbladh Johan Hovold Johannes Berg John Ogness Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Keith Busch Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Linyu Yuan Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Lucien Buchmann Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marcin Wojtas Marek Vasut Mario Kleiner Mario Limonciello Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin K. Petersen Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Max Staudt Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Michael Chan Michael Ellerman Michael Grzeschik Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Mike Christie Miklos Szeredi Mimi Zohar Ming Lei Misaka19465 Muchun Song Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Niklas Schnelle Nirmoy Das Nuno Gonçalves Oder Chiou Pablo Neira Ayuso Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Philipp Zabel Ping-Ke Shih Po-Wen Kao Prike Liang Pär Eriksson Rafael J. Wysocki Rob Herring Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sumanth Korikkar sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thinh Nguyen Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Todd Brandt Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Krowiak Tony Lindgren Tony Nguyen Vaishnav Achath Vasily Gorbik Vikas Gupta Vinayak Yadawad Viresh Kumar Vitaly Kuznetsov Vladimir Murzin Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Yingliang Yangxi Xiang Yassine Oudjana Yefim Barashkin Yevhen Orlov Yi Yang Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8803 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 17 04:06:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 04:06:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368927.600340 (Exim 4.92) (envelope-from ) id 1oCvY4-00016Q-7q; Sun, 17 Jul 2022 04:06:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368927.600340; Sun, 17 Jul 2022 04:06:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCvY4-00016J-4Q; Sun, 17 Jul 2022 04:06:28 +0000 Received: by outflank-mailman (input) for mailman id 368927; Sun, 17 Jul 2022 04:06:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCvY2-00016D-Lb for xen-devel@lists.xenproject.org; Sun, 17 Jul 2022 04:06:27 +0000 Received: from sonic315-8.consmr.mail.gq1.yahoo.com (sonic315-8.consmr.mail.gq1.yahoo.com [98.137.65.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d10797a2-0585-11ed-bd2d-47488cf2e6aa; Sun, 17 Jul 2022 06:06:23 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic315.consmr.mail.gq1.yahoo.com with HTTP; Sun, 17 Jul 2022 04:06:20 +0000 Received: by hermes--production-ne1-7864dcfd54-jmsp4 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 76f19ee75a50bf95f5392cd0b76efdaa; Sun, 17 Jul 2022 04:06:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d10797a2-0585-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658030780; bh=cFQdqAlSWQ4CBg5sHoVyAua4lSY5DokrLNSjD/d1ri4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=jlq14HhZZg105Ye1jFmKak3k9TWx6zGR/HCyAi8rDZpN78Y2mq5IxgDNeMZVZr/mjmQKjxIU4wVI7kHRonFTtCsa34JhoRl+QWl9XgG6SGKnSeavMRGUYvyCS9kh8jZNyLLGkoJzyGb2FWywrbXNtBmDiI1KC32j5iEnfsvK9WpgMws4bav7jmB1nL5iuw59pZeSH/GDa6x+g/xtgLr34m5dhTebcnKDDu56H5hf/tuxYE7f+UM8m+a9jv7uiPl+Z4alZjeFu4W0M+xm/2MU5VUZrsikuJKwIIdGrB8EeDDFoIYtIUU469chlwg1pquOmgzbzgL/Y8YGDtf4Np2sjA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658030780; bh=iqlz8AX8cYnQt049OzKCHJ20MTwlqIp5A81Hb3meSLv=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=txQuTHr8TkO44ag8sFyCZovVaIm3cTq7sp1ozY3hZJhGEPayLXVGNB43AYtk6ZDjz2lxQbYzHGwGrfD8+SjUVxpEb3ilYjqjUVco5HKOL6NVAoR44L/zmGVPYTAqV65WyySECJlucQo2J0QphTVRAT4ixGnC3Xnsm5LrwHf4j7cAaCiCNh69/8unfBqAdO9rkj7irJTwk/dIXwEct1QoP3xGb7m9vk2wQNfJyEX3CieyqKimHpce+RKEChdCn4DYNr+W4R6kAM3t3OTDPLf/Wa6U2fLEGtG/R4HvRuc9P/gSpGkgL0MJZuSzneeWKALjAbjpGDQteC33Z2uLa/6MTg== X-YMail-OSG: i677T34VM1nRFvOlQ3CCChOdXznGaiPU.aGmFRK_C5Z0TVS00794IZFEwFz_kyn 9Nc6NrfdrpuOvsnHiTaj0xHKidH3hubleVWZ5XrrRgMcloj3XI3QONjdrJsS9BAH.PhwsnlcDM7r oX9TnVbiSP9H53xdguWFFAASAzYTrcyppaGUTWbe9yQJYv1SKQ9sUCb8IlqG3Xvb0T1YffT8MGOX YaFlpxqWkUAbBAHilV9sXSfwN2oALmHXvdwpGulX5.N7VyxJNZuryKayCL0m6vbm72ID7vOUbzCr YbqboJ6.1bfeshChIFsH41YH1fSx5xAGcROZjhMvGfmajrToL4w40OoMegiUNL_FPBZrOeze419M WhvwxdLmG1QK.5yHopdGWX7B0YdpgEkPS9Fbc0B.qgOqR.f4VUwmXe5CSvVeWZdTx1.C55fLWWRS 5X5.R7W.FNqAgAql5e7saQxs8bEEKbifrPm1vunCxjA_FMunrqqQIKNtk3sTnxQ8ZEuZb2Z4wozF SVKmt2B2.sSKMmPCL7qXpDW7.KZWAhL4bps1YCENARRU61_qAXcNYFmikoCS0ICkDMEveSi4lTS5 5CE2LqN0el6eue1c4PwXxUevtF38NFbBhHCUZFpXe0fM8TECcYoRddz8DP6KGHCgEO_HBLslJctn E0xqfygKY7FpAkkkVRmt2UozB55x_F_sLFxNK8W1qPTYZGF5ydzozQA5lxnfdVDyAeYjl4S2hOQh Ak6UrhLbYQB_6XV.pSXPQDcjFHBJqkPT1GMidS0ACDu70drY_sYfrS5mT8RaMxY98WVqux7WAKXf 1sD59mhWSHXOOX7jTGqmWYsDtPuaCu1RldLFyoIofwFB3_VYJJvXhXeEqiuupAWptn7ugbd1QTNw SzclM2wbfLOTqkjgvGc3ndx1BQbzlZNZbmMQLhJQUwi1hwqB_KS7XU9xqhUB2ch4YMpulSsup2Iw cxfHmZzQOkgOzLyt7wSZyLvL2aObHZ_uIheeT22LZkUtz2Um8ggvtjMY7tD7aS3S6nr45_aeLlI1 R4e3WWFIGPFx3.B2ps5fVDO.oz8c_YA3dxcoPaodI4F0DyEQ3ARoW8M5FSv0_YsKnwryVMnS3Y0Q _NfuBIA2rO1s4gJQ_hlEiStezgo5Ce.PwkPsbkidKcmwCul.LNsnz1gkrlzSzegmKbwi1k0N2fCw x0HQ72QgngGu5u3jF_yhdlqDiBs_SB_ICafXzCea6ai8LQT_VUAqvi2ynWvR66yOHEyb7Q5AT_ti lPAoC.TD6Oaj9oT1kaGtk2PWfllLm0cp759hUmvX0Rj7YrpajkkMnYKyOFV0ZyiJ89jFFCsE7Tn9 wPzqS.9A_4eM_wqPUvQOFGs8QJeEyKYd2MTxrGLb..8o5AQU19lvRrZx.YQv1H4tr1DiGHO84LtD bGaLHQCuqdfqh.kdri1IB7YcuPoD_vMz8O_exeyf3pqG9iISuvflxA.KM0X0bdZIcb2Ur12nLVov avgfc.RWbTNRAjGGQ21cKhbPDUv_3HpMHnHmbV_mIw08k2.pJHpRYJ57IsuiLhqwowLLSW3LnfQw lv5vMGJPtSCaK64q2UGhEGH34DUEfpQEH_WptKgJZM5G0PSQqz80FWTyW5fUpYc03U7czk9xBd8e umCsMznxG4L1dyPf7neH1twIhhCeMvKswhyeIEKOSHG0R_hwo0mfNLPJU11lw96NjRaFuCxrI.4S WOnDzoTA2jHUZ2HC6dKrSOKW2qNH0QS6XYNrkCAldD0EG6JF2u.ON9imN7WD_H9CbbgUyWKoivpu Als7OCsSAHQe_plMn0T.cOmrPDkQBFl.GWjLR7bTnFOVyNfzHweeellsvyOYqnbivFCdR_ZuBz5x r2VjjG9z0aKHSiJagHCbixvCyB_nVY4UK7_bcXEqHkq3oVefKZOvEPgqgrpT0djYJnLmdYevGxrZ fBXgS_zjvO9wddpe7JQx3Fzf5H9iugb8_uhllHbocmx4wZRHYh.JpTRIl_gPGZeZlJM3w4yrdNEH LhjB27QhfECh1grgbAhreJKhl81b4XeHLZXbp322Y6YInoBTnLQu0wHNEL0hzmZj6B19M9ExTfFd EGdLjVAkUzlKmUqPWCkcg2GWH3ZZ7YxyWDJx6tFXaK0HQ0w4QOCaQVw2wIXdTzCMVKkL9cATc2Ok U_YZSTW7N73UeJlrKZTUbT20qh6J94YR961j9l6hzoYvDuyyO2llJOX32qR4gSQwNMVEcdZQ2w9d 6oJ9KzDZw_yU- X-Sonic-MF: Message-ID: <3be26f87-78d4-c2fb-0e27-db0196f9d62f@netscape.net> Date: Sun, 17 Jul 2022 00:06:17 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US To: Borislav Petkov Cc: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Thorsten Leemhuis , jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> <7bf307c7-0b05-781b-a2a3-19b47589eb8a@netscape.net> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 515 On 7/16/2022 7:42 AM, Borislav Petkov wrote: > On Sat, Jul 16, 2022 at 07:32:46AM -0400, Chuck Zmudzinski wrote: > > Can you confirm that with this patch series you are trying > > to fix that regression? > > Yes, this patchset is aimed to fix the whole situation but please don't > do anything yet - I need to find time and look at the whole approach > before you can test it. Just be patient and we'll ping you when the time > comes. > > Thx. > I will wait until I get the ping before trying it. Thanks, Chuck From xen-devel-bounces@lists.xenproject.org Sun Jul 17 05:20:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 05:20:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368938.600350 (Exim 4.92) (envelope-from ) id 1oCwhf-0002Ut-Mo; Sun, 17 Jul 2022 05:20:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368938.600350; Sun, 17 Jul 2022 05:20:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCwhf-0002Um-K0; Sun, 17 Jul 2022 05:20:27 +0000 Received: by outflank-mailman (input) for mailman id 368938; Sun, 17 Jul 2022 05:20:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCwhe-0002Ug-FT for xen-devel@lists.xenproject.org; Sun, 17 Jul 2022 05:20:26 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2937becd-0590-11ed-924f-1f966e50362f; Sun, 17 Jul 2022 07:20:24 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E575634866; Sun, 17 Jul 2022 05:20:23 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7DDC113A89; Sun, 17 Jul 2022 05:20:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id jyb/HBec02KCUAAAMHmgww (envelope-from ); Sun, 17 Jul 2022 05:20:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2937becd-0590-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1658035223; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nBxnxsBvQk92FZoXjukF0aK9XCteCOTDK2DUR1P5eu4=; b=S6ylxJaN+tzXZ8g1AJ9zt2Ry9UHYc06k2NE1bR7yxhtX0g8kpW1TZOteKs/3Smf+/0+9jt s28OuHCpUGhAL1BBKAM0cpk/zr2Rt4Y5w5eH8kFinPxfwuiOwmcsM9IQXAFgEicNyORDnj MUVif9Qu598k1KWa6DBgzS+cUgpsvAI= Message-ID: <6eea38ab-17d2-7bdc-1277-9964a3828a9e@suse.com> Date: Sun, 17 Jul 2022 07:20:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Content-Language: en-US To: Boris Ostrovsky , Nicolai Stange , Greg KH Cc: Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, Ben Hutchings References: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> <875yjxrp66.fsf@linux.fritz.box> From: Juergen Gross In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------7zGKpLsubE0ZasDYHbv93z3k" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------7zGKpLsubE0ZasDYHbv93z3k Content-Type: multipart/mixed; boundary="------------8epbhHZboIDosp92OlpVYKs5"; protected-headers="v1" From: Juergen Gross To: Boris Ostrovsky , Nicolai Stange , Greg KH Cc: Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, Ben Hutchings Message-ID: <6eea38ab-17d2-7bdc-1277-9964a3828a9e@suse.com> Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports References: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> <875yjxrp66.fsf@linux.fritz.box> In-Reply-To: --------------8epbhHZboIDosp92OlpVYKs5 Content-Type: multipart/mixed; boundary="------------An3p6WjSIkMGZfJvD7k73r3z" --------------An3p6WjSIkMGZfJvD7k73r3z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 T24gMTcuMDcuMjIgMDA6NDcsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4gDQo+IA0KPiBP biA3LzE2LzIyIDEyOjM1IFBNLCBOaWNvbGFpIFN0YW5nZSB3cm90ZToNCj4+IEhpLA0KPj4N Cj4+IEkgc2VlIGEgcGF0Y2ggZm9yIHRoaXMgaGFzIGJlZW4gcXVldWVkIHVwIGZvciA1LjEw IGFscmVhZHkgKFsxXSksIEknbQ0KPj4ganVzdCBzaGFyaW5nIG15IGZpbmRpbmdzIGluIHN1 cHBvcnQgb2YgdGhpcyBwYXRjaCBoZXJlIC0tIGl0IGRvZXNuJ3QNCj4+IG1lcmVseSBleGNo YW5nZSBvbmUgd2FybmluZyBmb3IgYW5vdGhlciwgYnV0IGZpeGVzIGEgcmVhbCBpc3N1ZSBh bmQNCj4+IHNob3VsZCBwZXJoYXBzIGdldCBhcHBsaWVkIHRvIG90aGVyIHN0YWJsZSBicmFu Y2hlcyBhcyB3ZWxsLg0KPj4NCj4+IFRMO0RSOiBmb3IgdGhpcyBwYXJ0aWN1bGFyIHdhcm5p bmcsIG9ianRvb2wgd291bGQgZXhpdCBlYXJseSBhbmQgZmFpbCB0bw0KPj4gY3JlYXRlIGFu eSAub3JjX3Vud2luZCogRUxGIHNlY3Rpb25zIGZvciBoZWFkXzY0Lm8sIHdoaWNoIGFyZSBj b25zdW1lZA0KPj4gYnkgdGhlIE9SQyB1bndpbmRlciBhdCBydW50aW1lLg0KPj4NCj4+DQo+ PiBCb3JpcyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPiB3cml0ZXM6 DQo+Pg0KPj4+IE9uIDcvMTIvMjIgMzozMSBQTSwgR3JlZyBLSCB3cm90ZToNCj4+Pj4gT24g VHVlLCBKdWwgMTIsIDIwMjIgYXQgMDM6MTk6MzlQTSAtMDQwMCwgQm9yaXMgT3N0cm92c2t5 IHdyb3RlOg0KPj4+Pj4NCj4+Pj4+IE9uIDcvMTIvMjIgMTI6MzggUE0sIEdyZWcgS0ggd3Jv dGU6DQo+Pj4+Pj4gSGkgYWxsLA0KPj4+Pj4+DQo+Pj4+Pj4gSSdtIHNlZWluZyB0aGUgZm9s bG93aW5nIGJ1aWxkIHdhcm5pbmc6DQo+Pj4+Pj4gwqDCoMKgwqBhcmNoL3g4Ni9rZXJuZWwv aGVhZF82NC5vOiB3YXJuaW5nOiBvYmp0b29sOiANCj4+Pj4+PiB4ZW5faHlwZXJjYWxsX21t dV91cGRhdGUoKTogY2FuJ3QgZmluZCBzdGFydGluZyBpbnN0cnVjdGlvbg0KPj4+Pj4+IGlu IHRoZSA1LjE1LnkgYW5kIDUuMTAueSByZXRibGVlZCBiYWNrcG9ydHMuDQo+Pg0KPj4gVGhl IHJlYXNvbiBmb3IgdGhpcyBpcyB0aGF0IHdpdGggUkVUIGJlaW5nIG11bHRpYnl0ZSwgaXQg Y2FuIGNyb3NzIHRob3NlDQo+PiAieGVuX2h5cGVjYWxsXyoiIHN5bWJvbCBib3VuZGFyaWVz LCBiZWNhdXNlIC4uLg0KPj4NCj4+Pj4+Pg0KPj4+Pj4+IEkgZG9uJ3Qga25vdyB3aHkganVz dCB0aGlzIG9uZSBoeXBlcmNhbGwgaXMgYmVpbmcgY2FsbGVkIG91dCBieSBvYmp0b29sLA0K Pj4+Pj4+IGFuZCB0aGlzIHdhcm5pbmcgaXNuJ3QgaW4gNS4xOCBhbmQgTGludXMncyB0cmVl IGR1ZSB0byBJIHRoaW5rIGNvbW1pdA0KPj4+Pj4+IDViMmZjNTE1NzZlZiAoIng4Ni9pYnQs eGVuOiBTcHJpbmtsZSB0aGUgRU5EQlIiKSBiZWluZyB0aGVyZS4NCj4+Pj4+Pg0KPj4+Pj4+ IEJ1dCwgaXMgdGhpcyBhIHJldCBjYWxsIHRoYXQgd2UgImZvcmdvdCIgaGVyZT/CoCBJdCdz IGEgInJlYWwiIHJldCBpbg0KPj4+Pj4+IExpbnVzJ3MgYnJhbmNoOg0KPj4+Pj4+DQo+Pj4+ Pj4gLnB1c2hzZWN0aW9uIC5ub2luc3RyLnRleHQsICJheCINCj4+Pj4+PiDCoMKgwqDCoC5i YWxpZ24gUEFHRV9TSVpFDQo+Pj4+Pj4gU1lNX0NPREVfU1RBUlQoaHlwZXJjYWxsX3BhZ2Up DQo+Pj4+Pj4gwqDCoMKgwqAucmVwdCAoUEFHRV9TSVpFIC8gMzIpDQo+Pj4+Pj4gwqDCoMKg wqDCoMKgwqAgVU5XSU5EX0hJTlRfRlVOQw0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIEFOTk9U QVRFX05PRU5EQlINCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCBBTk5PVEFURV9VTlJFVF9TQUZF DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgcmV0DQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgLyoN Cj4+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgICogWGVuIHdpbGwgd3JpdGUgdGhlIGh5cGVyY2Fs bCBwYWdlLCBhbmQgc29ydCBvdXQgRU5EQlIuDQo+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoCAq Lw0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIC5za2lwIDMxLCAweGNjDQo+Pj4+Pj4gwqDCoMKg wqAuZW5kcg0KPj4+Pj4+DQo+Pj4+Pj4gd2hpbGUgNS4xNS55IGFuZCBvbGRlciBoYXM6DQo+ Pj4+Pj4gLnB1c2hzZWN0aW9uIC50ZXh0DQo+Pj4+Pj4gwqDCoMKgwqAuYmFsaWduIFBBR0Vf U0laRQ0KPj4+Pj4+IFNZTV9DT0RFX1NUQVJUKGh5cGVyY2FsbF9wYWdlKQ0KPj4+Pj4+IMKg wqDCoMKgLnJlcHQgKFBBR0VfU0laRSAvIDMyKQ0KPj4+Pj4+IMKgwqDCoMKgwqDCoMKgIFVO V0lORF9ISU5UX0ZVTkMNCj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCAuc2tpcCAzMSwgMHg5MA0K Pj4NCj4+IC4uLiB0aGUgIjMxIiBpcyBubyBsb25nZXIgY29ycmVjdCwgLi4uDQo+Pg0KPj4+ Pj4+IMKgwqDCoMKgwqDCoMKgIEFOTk9UQVRFX1VOUkVUX1NBRkUNCj4+Pj4+PiDCoMKgwqDC oMKgwqDCoCBSRVQNCj4+DQo+PiAuLi4gYXMgd2l0aCBSRVQgb2NjdXB5aW5nIG1vcmUgdGhh biBvbmUgYnl0ZSwgdGhlIHJlc3VsdGluZyBoeXBlcmNhbGwNCj4+IGVudHJ5J3MgdG90YWwg c2l6ZSB3b24ndCBhZGQgdXAgdG8gMzIgYW55bW9yZS4NCj4gDQo+IA0KPiBSaWdodCEgSSBo YXZlbid0IHRob3VnaHQgYWJvdXQgdGhhdCBwYXJ0LiBJIHRoaW5rIHRoaXMgaGFzIGJlZW4g YnJva2VuIHNpbmNlIA0KPiAxNGI0NzZlMDdmYWIgKCJ4ODY6IFByZXBhcmUgYXNtIGZpbGVz IGZvciBzdHJhaWdodC1saW5lLXNwZWN1bGF0aW9uIikuDQo+IA0KPiBJdCBzdGlsbCBzaG91 bGRuJ3QgbWF0dGVyIGFzIGZhciBhcyBjb3JyZWN0IGV4ZWN1dGlvbiBpcyBjb25jZXJuZWQg d2hpY2ggaXMgDQo+IHByb2JhYmx5IHdoeSBub29uZSBjb21wbGFpbmVkLg0KPiANCj4gDQo+ Pg0KPj4gTm90ZSB0aGF0IHRob3NlIHhlbl9oeXBlcmNhbGxfKiBzeW1ib2xzJyB2YWx1ZXMg YXJlIGdldHRpbmcgc3RhdGljYWxseQ0KPj4gY2FsY3VsYXRlZCBhcyAnaHlwZXJjYWxsIHBh Z2UgKyBuICogMzInIGluIHRoZSBIWVBFUkNBTEwoKSAjZGVmaW5lIGZyb20NCj4+IHhlbi1o ZWFkLlMuIFNvIHRoZXJlJ3MgYSBtaXNtYXRjaCBhbmQgd2l0aCBSRVQgPT0gJ3JldDsgaW50 MycsIHRoZQ0KPj4gcmVzdWx0aW5nIC50ZXh0IGVmZmVjdGl2ZWx5IGJlY29tZXMNCj4+DQo+ PiDCoMKgwqDCoCAxMDFlOsKgwqDCoMKgwqDCoCA5MMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBub3ANCj4+IMKgwqDCoMKgIDEwMWY6wqDCoMKgwqDCoMKg IGMzwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldA0KPj4N Cj4+IDAwMDAwMDAwMDAwMDEwMjAgPHhlbl9oeXBlcmNhbGxfbW11X3VwZGF0ZT46DQo+PiDC oMKgwqDCoCAxMDIwOsKgwqDCoMKgwqDCoCBjY8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCBpbnQzDQo+PiDCoMKgwqDCoCAxMDIxOsKgwqDCoMKgwqDCoCA5 MMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBub3ANCj4+IMKg wqDCoMKgIDEwMjI6wqDCoMKgwqDCoMKgIDkwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIG5vcA0KPj4NCj4+DQo+PiBUaGlzIGlzIHByb2JhYmx5IGFscmVh ZHkgbm90IHdoYXQgaGFzIGJlZW4gaW50ZW5kZWQsIGJ1dCBiZWNhdXNlICdyZXQnDQo+PiBh bmQgJ2ludDMnIGJvdGggYXJlIHNpbmdsZS1ieXRlIGVuY29kZWQsIG9ianRvb2wgd291bGQg c3RpbGwgYmUgYWJsZSB0bw0KPj4gZmluZCBhdCBsZWFzdCBzb21lICJzdGFydGluZyBpbnN0 cnVjdGlvbiIgYXQgdGhpcyBwb2ludC4NCj4+DQo+PiBCdXQgd2l0aCBSRVQgPT0gJ2ptcCBf X3g4Nl9yZXR1cm5fdGh1bmsnLCBpdCBiZWNvbWVzDQo+Pg0KPj4gwqDCoMKgwqAgMTAxZTrC oMKgwqDCoMKgwqAgOTDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgbm9wDQo+PiDCoMKgwqDCoCAxMDFmOsKgwqDCoMKgwqDCoCBlOcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAuYnl0ZSAweGU5DQo+Pg0KPj4gMDAwMDAw MDAwMDAwMTAyMCA8eGVuX2h5cGVyY2FsbF9tbXVfdXBkYXRlPjoNCj4+IMKgwqDCoMKgIDEw MjA6wqDCoMKgwqDCoMKgIDAwIDAwwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGFkZMKgwqDCoCAlYWwsKCVyYXgpDQo+PiDCoMKgwqDCoCAxMDIyOsKgwqDCoMKgwqDC oCAwMCAwMMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBhZGTCoMKgwqAg JWFsLCglcmF4KQ0KPj4gwqDCoMKgwqAgMTAyNDrCoMKgwqDCoMKgwqAgOTDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbm9wDQo+Pg0KPj4gSGVyZSB0aGUg J2U5IDAwIDAwIDAwIDAwJyBqbXAgY3Jvc3NlcyB0aGUgc3ltYm9sIGJvdW5kYXJ5IGFuZCBv Ymp0b29sDQo+PiBlcnJvcnMgb3V0Lg0KPj4NCj4gDQo+IA0KPiBBaCwgdGhhbmtzIGZvciBl eHBsYW5hdGlvbi4NCj4gDQo+IA0KPiBUaGVuIEkgdGhpbmsgd2UgbmVlZCB0byByZXBsYWNl DQo+IA0KPiAgwqDCoMKgwqAuc2tpcCAzMSwgMHg5MA0KPiANCj4gd2l0aCBzb21ldGhpbmcg bGlrZQ0KPiANCj4gI2lmIGRlZmluZWQoQ09ORklHX1JFVEhVTkspICYmICFkZWZpbmVkKF9f RElTQUJMRV9FWFBPUlRTKSAmJiAhZGVmaW5lZChCVUlMRF9WRFNPKQ0KPiAjZGVmaW5lIFNL SVBfQllURVPCoMKgwqAgMjfCoMKgwqAgLyogUkVUIGlzICdqbXAgX194ODZfcmV0dXJuX3Ro dW5rJyAoNSBieXRlcykgKi8NCj4gI2Vsc2UgLyogQ09ORklHX1JFVFBPTElORSAqLw0KPiAj aWZkZWYgQ09ORklHX1NMUw0KPiAjZGVmaW5lIFNLSVBfQllURVPCoMKgwqAgMzDCoMKgwqAg LyogUkVUIGlzICdyZXQ7IGludDMnICgyIGJ5dGVzKSAqLw0KPiAjZWxzZQ0KPiAjZGVmaW5l IFNLSVBfQllURVPCoMKgwqAgMzHCoMKgwqAgLyogUkVUIGlzICdyZXQnICgxIGJ5dGUpICov DQo+ICNlbmRpZg0KPiAgwqDCoMKgwqAuc2tpcCBTS0lQX0JZVEVTLCAweDkwDQo+IA0KPiAo SSBkb24ndCBoYXZlIHBhdGNoZWQgNS4xNSBzbyBJIGFtIGdvaW5nIGJ5IHdoYXQgbWFpbmxp bmUgbG9va3MgbGlrZSkNCj4gDQo+IE9yIHJlcGxhY2UgUkVUIHdpdGggcmV0LiAoQWx0aG91 Z2ggYXQgbGVhc3Qgd2l0aCB1bnBhdGNoZWQgNS4xNSB0aGUgd2FybmluZyANCj4gYmVsb3cg aXMgc3RpbGwgZ2VuZXJhdGVkKQ0KDQpXaGF0IGFib3V0IGZpbGxpbmcgdGhlIGNvbXBsZXRl IGh5cGVyY2FsbCBwYWdlIGp1c3Qgd2l0aCAiaW50IDMiIG9yICJ1ZDIiPw0KDQpBbnkgdHJ5 IHRvIGRvIGEgaHlwZXJjYWxsIGJlZm9yZSB0aGUgaHlwZXJjYWxsIHBhZ2UgaGFzIGJlZW4g aW5pdGlhbGl6ZWQNCmlzIGEgYnVnIGFueXdheS4gV2hhdCBnb29kIGNhbiBjb21lIGZyb20g Y2FsbGluZyBhIGZ1bmN0aW9uIHdoaWNoIHdpbGwNCnJldHVybiBhIGJhc2ljYWxseSByYW5k b20gdmFsdWUgaW5zdGVhZCBvZiBkb2luZyBhIHByaXZpbGVnZWQgb3BlcmF0aW9uPw0KDQoN Ckp1ZXJnZW4NCg== --------------An3p6WjSIkMGZfJvD7k73r3z Content-Type: application/pgp-keys; name="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Disposition: attachment; filename="OpenPGP_0xB0DE9DD628BF132F.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xsBNBFOMcBYBCACgGjqjoGvbEouQZw/ToiBg9W98AlM2QHV+iNHsEs7kxWhKMjri oyspZKOBycWxw3ie3j9uvg9EOB3aN4xiTv4qbnGiTr3oJhkB1gsb6ToJQZ8uxGq2 kaV2KL9650I1SJvedYm8Of8Zd621lSmoKOwlNClALZNew72NjJLEzTalU1OdT7/i 1TXkH09XSSI8mEQ/ouNcMvIJNwQpd369y9bfIhWUiVXEK7MlRgUG6MvIj6Y3Am/B BLUVbDa4+gmzDC9ezlZkTZG2t14zWPvxXP3FAp2pkW0xqG7/377qptDmrk42GlSK N4z76ELnLxussxc7I2hx18NUcbP8+uty4bMxABEBAAHNHEp1ZXJnZW4gR3Jvc3Mg PGpnQHBmdXBmLm5ldD7CwHkEEwECACMFAlOMcBYCGwMHCwkIBwMCAQYVCAIJCgsE FgIDAQIeAQIXgAAKCRCw3p3WKL8TL0KdB/93FcIZ3GCNwFU0u3EjNbNjmXBKDY4F UGNQH2lvWAUy+dnyThpwdtF/jQ6j9RwE8VP0+NXcYpGJDWlNb9/JmYqLiX2Q3Tye vpB0CA3dbBQp0OW0fgCetToGIQrg0MbD1C/sEOv8Mr4NAfbauXjZlvTj30H2jO0u +6WGM6nHwbh2l5O8ZiHkH32iaSTfN7Eu5RnNVUJbvoPHZ8SlM4KWm8rG+lIkGurq qu5gu8q8ZMKdsdGC4bBxdQKDKHEFExLJK/nRPFmAuGlId1E3fe10v5QL+qHI3EIP tyfE7i9Hz6rVwi7lWKgh7pe0ZvatAudZ+JNIlBKptb64FaiIOAWDCx1SzR9KdWVy Z2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+wsB5BBMBAgAjBQJTjHCvAhsDBwsJ CAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/Ey/HmQf/RtI7kv5A2PS4 RF7HoZhPVPogNVbC4YA6lW7DrWf0teC0RR3MzXfy6pJ+7KLgkqMlrAbN/8Dvjoz7 8X+5vhH/rDLa9BuZQlhFmvcGtCF8eR0T1v0nC/nuAFVGy+67q2DH8As3KPu0344T BDpAvr2uYM4tSqxK4DURx5INz4ZZ0WNFHcqsfvlGJALDeE0LhITTd9jLzdDad1pQ SToCnLl6SBJZjDOX9QQcyUigZFtCXFst4dlsvddrxyqT1f17+2cFSdu7+ynLmXBK 7abQ3rwJY8SbRO2iRulogc5vr/RLMMlscDAiDkaFQWLoqHHOdfO9rURssHNN8WkM nQfvUewRz80hSnVlcmdlbiBHcm9zcyA8amdyb3NzQG5vdmVsbC5jb20+wsB5BBMB AgAjBQJTjHDXAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AACgkQsN6d1ii/ Ey8PUQf/ehmgCI9jB9hlgexLvgOtf7PJnFOXgMLdBQgBlVPO3/D9R8LtF9DBAFPN hlrsfIG/SqICoRCqUcJ96Pn3P7UUinFG/I0ECGF4EvTE1jnDkfJZr6jrbjgyoZHi w/4BNwSTL9rWASyLgqlA8u1mf+c2yUwcGhgkRAd1gOwungxcwzwqgljf0N51N5Jf VRHRtyfwq/ge+YEkDGcTU6Y0sPOuj4Dyfm8fJzdfHNQsWq3PnczLVELStJNdapwP OoE+lotufe3AM2vAEYJ9rTz3Cki4JFUsgLkHFqGZarrPGi1eyQcXeluldO3m91NK /1xMI3/+8jbO0tsn1tqSEUGIJi7ox80eSnVlcmdlbiBHcm9zcyA8amdyb3NzQHN1 c2UuZGU+wsB5BBMBAgAjBQJTjHDrAhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgEC F4AACgkQsN6d1ii/Ey+LhQf9GL45eU5vOowA2u5N3g3OZUEBmDHVVbqMtzwlmNC4 k9Kx39r5s2vcFl4tXqW7g9/ViXYuiDXb0RfUpZiIUW89siKrkzmQ5dM7wRqzgJpJ wK8Bn2MIxAKArekWpiCKvBOB/Cc+3EXE78XdlxLyOi/NrmSGRIov0karw2RzMNOu 5D+jLRZQd1Sv27AR+IP3I8U4aqnhLpwhK7MEy9oCILlgZ1QZe49kpcumcZKORmzB TNh30FVKK1EvmV2xAKDoaEOgQB4iFQLhJCdP1I5aSgM5IVFdn7v5YgEYuJYx37Io N1EblHI//x/e2AaIHpzK5h88NEawQsaNRpNSrcfbFmAg987ATQRTjHAWAQgAyzH6 AOODMBjgfWE9VeCgsrwH3exNAU32gLq2xvjpWnHIs98ndPUDpnoxWQugJ6MpMncr 0xSwFmHEgnSEjK/PAjppgmyc57BwKII3sV4on+gDVFJR6Y8ZRwgnBC5mVM6JjQ5x Dk8WRXljExRfUX9pNhdE5eBOZJrDRoLUmmjDtKzWaDhIg/+1Hzz93X4fCQkNVbVF LELU9bMaLPBG/x5q4iYZ2k2ex6d47YE1ZFdMm6YBYMOljGkZKwYde5ldM9mo45mm we0icXKLkpEdIXKTZeKDO+Hdv1aqFuAcccTg9RXDQjmwhC3yEmrmcfl0+rPghO0I v3OOImwTEe4co3c1mwARAQABwsBfBBgBAgAJBQJTjHAWAhsMAAoJELDendYovxMv Q/gH/1ha96vm4P/L+bQpJwrZ/dneZcmEwTbe8YFsw2V/Buv6Z4Mysln3nQK5ZadD 534CF7TDVft7fC4tU4PONxF5D+/tvgkPfDAfF77zy2AH1vJzQ1fOU8lYFpZXTXIH b+559UqvIB8AdgR3SAJGHHt4RKA0F7f5ipYBBrC6cyXJyyoprT10EMvU8VGiwXvT yJz3fjoYsdFzpWPlJEBRMedCot60g5dmbdrZ5DWClAr0yau47zpWj3enf1tLWaqc suylWsviuGjKGw7KHQd3bxALOknAp4dN3QwBYCKuZ7AddY9yjynVaD5X7nF9nO5B jR/i1DG86lem3iBDXzXsZDn8R38=3D =3D2wuH -----END PGP PUBLIC KEY BLOCK----- --------------An3p6WjSIkMGZfJvD7k73r3z-- --------------8epbhHZboIDosp92OlpVYKs5-- --------------7zGKpLsubE0ZasDYHbv93z3k Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEhRJncuj2BJSl0Jf3sN6d1ii/Ey8FAmLTnBcFAwAAAAAACgkQsN6d1ii/Ey9q mwf/SL+4KNaRGqLo52fTKu4xvsuojYaTxHE0TVn5glhFdSXkUO7URPUXMlIevHKohgAP7n3/TAKj ogxtkuaVkr/GP18CiDzjX3tBcEE9Hz8fn5kbHaTO1HErCt4eKnE4g0VWIMMlsEgB/we4gYKwRoln zmDb4lcp7g2LavkQ04FErpxgFnq4WCzIvAl1XQYvpS8A+y7FA1egPWw97HgSThSlF8nct+yi66c0 +NDUxg8Ecd6obkSN4NAlnM32/HQZq4Zz1FROTY0LyXZBSAwD8w2gZI97gcZQtM47yKvYzVXnkLX3 OQaw/HPSvgq2grg+b8emRWYy9td9w5mEgrDZu8pV0A== =vrHJ -----END PGP SIGNATURE----- --------------7zGKpLsubE0ZasDYHbv93z3k-- From xen-devel-bounces@lists.xenproject.org Sun Jul 17 07:13:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 07:13:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368951.600362 (Exim 4.92) (envelope-from ) id 1oCyTH-0007R7-Oh; Sun, 17 Jul 2022 07:13:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368951.600362; Sun, 17 Jul 2022 07:13:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCyTH-0007R0-Kh; Sun, 17 Jul 2022 07:13:43 +0000 Received: by outflank-mailman (input) for mailman id 368951; Sun, 17 Jul 2022 07:13:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCyTF-0007Qq-RJ; Sun, 17 Jul 2022 07:13:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCyTF-0007mT-P6; Sun, 17 Jul 2022 07:13:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCyTF-0006HV-9N; Sun, 17 Jul 2022 07:13:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCyTF-00051s-8w; Sun, 17 Jul 2022 07:13:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZQQ9HOSGY0a0tF1ikHlIOlWOtQUIAHxKGNn3jKip2PI=; b=1c6o5ksXSagvw46fWBqkzzDeC4 UIk8RIfPet1CX14rbgXtREspTtdNbSsa9grlouzH0wv1aZeCHwv8atYgbaTOwDrwceGMd3+2y24Vb be9WUDM3/PJ1TyvX4IWRfaVwAwGYB7QNqqTFL5nxb+lW7U7mVTi+KpdqPlQZWm4ombWo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171657: all pass - PUSHED X-Osstest-Versions-This: ovmf=176016387f0a6ad16efcfdcef19fd90bdc3a77e4 X-Osstest-Versions-That: ovmf=07c8e5e59b117f2414d7c928d3f86c85574f1fc3 From: osstest service owner Date: Sun, 17 Jul 2022 07:13:41 +0000 flight 171657 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171657/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 176016387f0a6ad16efcfdcef19fd90bdc3a77e4 baseline version: ovmf 07c8e5e59b117f2414d7c928d3f86c85574f1fc3 Last test of basis 171647 2022-07-16 03:10:43 Z 1 days Testing same since 171657 2022-07-17 02:41:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chen, Christine Yuwei Chen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 07c8e5e59b..176016387f 176016387f0a6ad16efcfdcef19fd90bdc3a77e4 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 17 07:55:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 07:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368962.600373 (Exim 4.92) (envelope-from ) id 1oCz7P-0003zN-Qm; Sun, 17 Jul 2022 07:55:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368962.600373; Sun, 17 Jul 2022 07:55:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCz7P-0003zG-Na; Sun, 17 Jul 2022 07:55:11 +0000 Received: by outflank-mailman (input) for mailman id 368962; Sun, 17 Jul 2022 07:55:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCz7N-0003zA-PP for xen-devel@lists.xenproject.org; Sun, 17 Jul 2022 07:55:09 +0000 Received: from wp530.webpack.hosteurope.de (wp530.webpack.hosteurope.de [2a01:488:42:1000:50ed:8234::]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c574236c-05a5-11ed-bd2d-47488cf2e6aa; Sun, 17 Jul 2022 09:55:08 +0200 (CEST) Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1oCz7G-0003PZ-5e; Sun, 17 Jul 2022 09:55:02 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c574236c-05a5-11ed-bd2d-47488cf2e6aa Message-ID: Date: Sun, 17 Jul 2022 09:55:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Cc: brchuckz@netscape.net, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> From: Thorsten Leemhuis In-Reply-To: <20220715142549.25223-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1658044508;3110b8b4; X-HE-SMSGID: 1oCz7G-0003PZ-5e Hi Juergen! On 15.07.22 16:25, Juergen Gross wrote: > Today PAT can't be used without MTRR being available, unless MTRR is at > least configured via CONFIG_MTRR and the system is running as Xen PV > guest. In this case PAT is automatically available via the hypervisor, > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > As an additional complexity the availability of PAT can't be queried > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > to be disabled. This leads to some drivers believing that not all cache > modes are available, resulting in failures or degraded functionality. > > The same applies to a kernel built with no MTRR support: it won't > allow to use the PAT MSR, even if there is no technical reason for > that, other than setting up PAT on all cpus the same way (which is a > requirement of the processor's cache management) is relying on some > MTRR specific code. > > Fix all of that by: > > - moving the function needed by PAT from MTRR specific code one level > up > - adding a PAT indirection layer supporting the 3 cases "no or disabled > PAT", "PAT under kernel control", and "PAT under Xen control" > - removing the dependency of PAT on MTRR Thx for working on this. If you need to respin these patches for one reason or another, could you do me a favor and add proper 'Link:' tags pointing to all reports about this issue? e.g. like this: Link: https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ These tags are considered important by Linus[1] and others, as they allow anyone to look into the backstory weeks or years from now. That is why they should be placed in cases like this, as Documentation/process/submitting-patches.rst and Documentation/process/5.Posting.rst explain in more detail. I care personally, because these tags make my regression tracking efforts a whole lot easier, as they allow my tracking bot 'regzbot' to automatically connect reports with patches posted or committed to fix tracked regressions. [1] see for example: https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/ https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/ Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I deal with a lot of reports and sometimes miss something important when writing mails like this. If that's the case here, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. BTW, let me tell regzbot to monitor this thread: #regzbot ^backmonitor: https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ From xen-devel-bounces@lists.xenproject.org Sun Jul 17 08:20:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 08:20:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368979.600384 (Exim 4.92) (envelope-from ) id 1oCzVm-0008O9-3R; Sun, 17 Jul 2022 08:20:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368979.600384; Sun, 17 Jul 2022 08:20:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCzVm-0008O2-0f; Sun, 17 Jul 2022 08:20:22 +0000 Received: by outflank-mailman (input) for mailman id 368979; Sun, 17 Jul 2022 08:20:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCzVk-0008Ns-Gj; Sun, 17 Jul 2022 08:20:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCzVk-0000yZ-CV; Sun, 17 Jul 2022 08:20:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oCzVj-0000bM-Re; Sun, 17 Jul 2022 08:20:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oCzVj-0001Fw-RF; Sun, 17 Jul 2022 08:20:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=raOJno4d4DsBflknheh4DUXFQlYt9YC7By9u4RZbGcM=; b=WDnRCub0or6IafDVjMbPfIIvBT XAv79FFet/qXRYOQrfflFObnyLYBpNS/NbzYMhVuvp+gGh0DC8ilovv7QtcfzKETXCeaMTNXiG7Fn TSHyVyDlrBibxaxjG4RntsTxkCjv48BcognwotAtPPYj4ptU70BVatscMqgAHmZPcvKU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171655: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b X-Osstest-Versions-That: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b From: osstest service owner Date: Sun, 17 Jul 2022 08:20:19 +0000 flight 171655 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171655/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171650 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171650 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171650 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171650 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171650 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171650 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171650 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171650 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171650 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171650 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171650 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171650 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen ab2977b027acbbd33a7eecda854d1911a7702f8b baseline version: xen ab2977b027acbbd33a7eecda854d1911a7702f8b Last test of basis 171655 2022-07-17 01:53:18 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 17 08:58:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 08:58:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.368991.600395 (Exim 4.92) (envelope-from ) id 1oD06i-0004C6-4z; Sun, 17 Jul 2022 08:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 368991.600395; Sun, 17 Jul 2022 08:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD06i-0004Bz-2K; Sun, 17 Jul 2022 08:58:32 +0000 Received: by outflank-mailman (input) for mailman id 368991; Sun, 17 Jul 2022 08:58:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD06g-0004Bp-Bl; Sun, 17 Jul 2022 08:58:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD06g-0001bF-71; Sun, 17 Jul 2022 08:58:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD06f-0001Yf-Oy; Sun, 17 Jul 2022 08:58:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oD06f-00068i-OY; Sun, 17 Jul 2022 08:58:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=i6DfiUgPNZXFnIM33mwlYARIrjERrTlj3oNafYe4eOU=; b=sHFsj+RyjuQRxvrChg8swUVk/f fTayg5kcS2c9P1WVaH1gd2zquLQzFy3BFzgAEayaD8omE/dh2yQT4ZYe62v50azciLMvn47nm+bXu Bov0/5NO6A9ikVwUy9BwRNrHxgEDWuLO/ZEFYKDbJj5Gym/teeXaE+LfocjQS4xvDgDU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171658: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=62ca3005307e9b07ebdcf09ac9742c8f8be1c072 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 17 Jul 2022 08:58:29 +0000 flight 171658 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171658/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 62ca3005307e9b07ebdcf09ac9742c8f8be1c072 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 737 days Failing since 151818 2020-07-11 04:18:52 Z 736 days 718 attempts Testing same since 171649 2022-07-16 04:18:59 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116192 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 17 09:37:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 09:37:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369013.600406 (Exim 4.92) (envelope-from ) id 1oD0i7-0000lO-3c; Sun, 17 Jul 2022 09:37:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369013.600406; Sun, 17 Jul 2022 09:37:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD0i7-0000lH-0j; Sun, 17 Jul 2022 09:37:11 +0000 Received: by outflank-mailman (input) for mailman id 369013; Sun, 17 Jul 2022 09:37:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD0i5-0000l7-3R; Sun, 17 Jul 2022 09:37:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD0i5-0002FW-0p; Sun, 17 Jul 2022 09:37:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD0i4-0002bI-Pt; Sun, 17 Jul 2022 09:37:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oD0i4-0001Zq-PO; Sun, 17 Jul 2022 09:37:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XgtVy2yvySZDDF+xNrtkFxksTQWV8jcO33sxNxd6qNE=; b=Kw7mLgIgrcL8y675DDfr0tvwM1 gDnrVf2Uy2UHh20E8vtA7WLxCDQF1znkbNOFgo7EzC04iY7vXkdtcPDBUlyHCpreRwqWSZupWZnjl tx9VkS1zLEJl2V9Ra0wMtS+LT+/BtbgKiL0+763uHEOWWqsXzYSjA2tWmEBbmpTyiYR4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171659: all pass - PUSHED X-Osstest-Versions-This: ovmf=039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 X-Osstest-Versions-That: ovmf=176016387f0a6ad16efcfdcef19fd90bdc3a77e4 From: osstest service owner Date: Sun, 17 Jul 2022 09:37:08 +0000 flight 171659 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171659/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 baseline version: ovmf 176016387f0a6ad16efcfdcef19fd90bdc3a77e4 Last test of basis 171657 2022-07-17 02:41:23 Z 0 days Testing same since 171659 2022-07-17 07:43:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chen, Christine Yuwei Chen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 176016387f..039bdb4d3e 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 17 10:36:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 10:36:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369047.600417 (Exim 4.92) (envelope-from ) id 1oD1dh-0007vh-Fy; Sun, 17 Jul 2022 10:36:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369047.600417; Sun, 17 Jul 2022 10:36:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD1dh-0007va-CN; Sun, 17 Jul 2022 10:36:41 +0000 Received: by outflank-mailman (input) for mailman id 369047; Sun, 17 Jul 2022 10:36:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD1dg-0007vQ-5p; Sun, 17 Jul 2022 10:36:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD1dg-0003Hw-2E; Sun, 17 Jul 2022 10:36:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD1df-00040G-MW; Sun, 17 Jul 2022 10:36:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oD1df-0005qY-M2; Sun, 17 Jul 2022 10:36:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+IdukZKea3eSrNjtg9ny00ato/WdGEtxxHS+A/OV0QU=; b=eDyJFT1M/VUVqLkCWytUfNUfa7 UlYqmCvLhclw5iPP6/88yIe6UGJ245Zp6wYPbLVqHeXmUoCwaCfScLfvBo8I/Tg4rK6g95q6aC6j3 SgYonoaj7J4rzQT8W7ObmYTV8qx7Re356F+GnUcz6qAX/FrXLJpN5eRhCqKIZqIpoC7o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171656: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=972a278fe60c361eb8f37619f562f092e8786d7c X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sun, 17 Jul 2022 10:36:39 +0000 flight 171656 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171656/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 972a278fe60c361eb8f37619f562f092e8786d7c baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 5 days Failing since 171601 2022-07-12 16:11:30 Z 4 days 8 attempts Testing same since 171656 2022-07-17 02:37:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alex Deucher Alex Deucher Alexander Gordeev Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda AngeloGioacchino Del Regno Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bean Huo Biju Das Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue C. Erastus Toe Changyuan Lyu Chanho Park Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Christian Zigotzky Christoph Hellwig Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Darren Stevens Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller David Sterba Demi Marie Obenour Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Greg Kroah-Hartman Guangwu Zhang Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilpo Järvinen Ilya Dryomov Israel Rukshin Jack Wang Jakub Kicinski Jason A. Donenfeld Jason Wang Javier Martinez Canillas Jeff Layton Jens Axboe Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Jiri Slaby Joanne Koong Joe Lawrence Johan Almbladh Johan Hovold Johannes Berg John Ogness Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Keith Busch Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Linyu Yuan Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Lucien Buchmann Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marcin Wojtas Marek Vasut Mario Kleiner Mario Limonciello Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin K. Petersen Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Max Staudt Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Michael Chan Michael Ellerman Michael Grzeschik Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Mike Christie Miklos Szeredi Mimi Zohar Ming Lei Misaka19465 Muchun Song Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Niklas Schnelle Nirmoy Das Nuno Gonçalves Oder Chiou Pablo Neira Ayuso Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Philipp Zabel Ping-Ke Shih Po-Wen Kao Prike Liang Pär Eriksson Rafael J. Wysocki Rob Herring Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sumanth Korikkar sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thinh Nguyen Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Todd Brandt Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Krowiak Tony Lindgren Tony Nguyen Vaishnav Achath Vasily Gorbik Vikas Gupta Vinayak Yadawad Viresh Kumar Vitaly Kuznetsov Vladimir Murzin Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Yingliang Yangxi Xiang Yassine Oudjana Yefim Barashkin Yevhen Orlov Yi Yang Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 17 13:06:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 13:06:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369066.600427 (Exim 4.92) (envelope-from ) id 1oD3yc-0007vt-9R; Sun, 17 Jul 2022 13:06:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369066.600427; Sun, 17 Jul 2022 13:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD3yc-0007vm-6o; Sun, 17 Jul 2022 13:06:26 +0000 Received: by outflank-mailman (input) for mailman id 369066; Sun, 17 Jul 2022 13:06:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD3yb-0007vg-9r for xen-devel@lists.xenproject.org; Sun, 17 Jul 2022 13:06:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD3ya-0005oS-L9; Sun, 17 Jul 2022 13:06:24 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oD3ya-0000CM-EI; Sun, 17 Jul 2022 13:06:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=uUAYx4VSAOCD5C1ACoAywJWE3QEcUX/3ndNnyoI3T98=; b=gIfRbY27E9u20RclCP/lUBnI1D /1t1f1PyG+KeIFZ02yNVvimMbc+zRuGTXb/2TOr8MeLqUv2uQZac1W2XbRFK/7AA/duI41wZFVhLm b2uuBxat+dGPSx4FTSkKMt3zwLgYr8seyxeXNwJMQpaAQlrfUl1u3rAJ9UsENJXsfq5Q=; Message-ID: <2b8cac30-f696-8414-944c-aeb1bcaf58a5@xen.org> Date: Sun, 17 Jul 2022 14:06:22 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 7/7] xen/arm: mm: Reduce the area that xen_second covers To: Michal Orzel , xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-8-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Michal, On 27/06/2022 08:51, Michal Orzel wrote: > On 24.06.2022 11:11, Julien Grall wrote: >> From: Julien Grall >> >> At the moment, xen_second is used to cover the first 2GB of the >> virtual address space. With the recent rework of the page-tables, >> only the first 1GB region (where Xen resides) is effectively used. >> >> In addition to that, I would like to reshuffle the memory layout. >> So Xen mappings may not be anymore in the first 2GB of the virtual >> address space. >> >> Therefore, rework xen_second so it only covers the 1GB region where >> Xen will reside. >> >> With this change, xen_second doesn't cover anymore the xenheap area >> on arm32. So, we first need to add memory to the boot allocator before >> setting up the xenheap mappings. >> >> Take the opportunity to update the comments on top of xen_fixmap and >> xen_xenmap. >> >> Signed-off-by: Julien Grall >> --- >> xen/arch/arm/mm.c | 32 +++++++++++--------------------- >> xen/arch/arm/setup.c | 13 +++++++++++-- >> 2 files changed, 22 insertions(+), 23 deletions(-) >> >> diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c >> index 74666b2e720a..f87a7c32d07d 100644 >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -116,17 +116,14 @@ static DEFINE_PAGE_TABLE(cpu0_pgtable); >> #endif >> >> /* Common pagetable leaves */ >> -/* Second level page tables. >> - * >> - * The second-level table is 2 contiguous pages long, and covers all >> - * addresses from 0 to 0x7fffffff. Offsets into it are calculated >> - * with second_linear_offset(), not second_table_offset(). >> - */ >> -static DEFINE_PAGE_TABLES(xen_second, 2); >> -/* First level page table used for fixmap */ >> +/* Second level page table used to cover Xen virtual address space */ >> +static DEFINE_PAGE_TABLE(xen_second); >> +/* Third level page table used for fixmap */ >> DEFINE_BOOT_PAGE_TABLE(xen_fixmap); >> -/* First level page table used to map Xen itself with the XN bit set >> - * as appropriate. */ >> +/* >> + * Third level page table used to map Xen itself with the XN bit set >> + * as appropriate. >> + */ >> static DEFINE_PAGE_TABLE(xen_xenmap); >> >> /* Non-boot CPUs use this to find the correct pagetables. */ >> @@ -168,7 +165,6 @@ static void __init __maybe_unused build_assertions(void) >> BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); >> #endif >> BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); >> - BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= XEN_PT_LPAE_ENTRIES); > Instead of removing this completely, shouldn't you change it to: > BUILD_BUG_ON(second_table_offset(XEN_VIRT_START)); ? This would be wrong because the 2nd table offset is 1 today (Xen starts at 2MB). Furthermore, setup_pagetables() doesn't make any assumption regarding the 2nd table offset. So I don't think we should have a BUILD_BUG_ON(). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Sun Jul 17 15:29:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 15:29:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369106.600454 (Exim 4.92) (envelope-from ) id 1oD6CV-00075t-Jy; Sun, 17 Jul 2022 15:28:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369106.600454; Sun, 17 Jul 2022 15:28:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD6CV-00075m-HH; Sun, 17 Jul 2022 15:28:55 +0000 Received: by outflank-mailman (input) for mailman id 369106; Sun, 17 Jul 2022 15:28:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD6CU-00075c-So; Sun, 17 Jul 2022 15:28:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD6CU-0008Az-OV; Sun, 17 Jul 2022 15:28:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD6CU-0006bb-At; Sun, 17 Jul 2022 15:28:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oD6CU-0006Fn-8P; Sun, 17 Jul 2022 15:28:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k7XNBq6z+5o8hF+yZtVa4+BTyO9uxcIkTjIEYb+/DC8=; b=mWklVIwCIKtDAs4P7XLQKG1rp5 h3+MzWbAKzWRnoc+MFgiEOT5tNfsql5a6P9KVF1d9JFyWuFTVcCHViAYzL34jIIsS+RReI8pti9wq hQhHbrrRr4ReRS5KXwRMuxMXUh5xbhYsQ3dcgI5IM3/AVTLq7IuuamPQ4Exd8UIWcNZY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171660: regressions - FAIL X-Osstest-Failures: linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-libvirt-xsm:guest-start/debian.repeat:fail:heisenbug linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=972a278fe60c361eb8f37619f562f092e8786d7c X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sun, 17 Jul 2022 15:28:54 +0000 flight 171660 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171660/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-xsm 20 guest-start/debian.repeat fail pass in 171656 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail pass in 171656 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 972a278fe60c361eb8f37619f562f092e8786d7c baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 5 days Failing since 171601 2022-07-12 16:11:30 Z 4 days 9 attempts Testing same since 171656 2022-07-17 02:37:23 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alex Deucher Alex Deucher Alexander Gordeev Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda AngeloGioacchino Del Regno Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bean Huo Biju Das Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue C. Erastus Toe Changyuan Lyu Chanho Park Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Christian Zigotzky Christoph Hellwig Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Darren Stevens Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller David Sterba Demi Marie Obenour Dmitry Osipenko Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Greg Kroah-Hartman Guangwu Zhang Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilpo Järvinen Ilya Dryomov Israel Rukshin Jack Wang Jakub Kicinski Jason A. Donenfeld Jason Wang Javier Martinez Canillas Jeff Layton Jens Axboe Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Jiri Slaby Joanne Koong Joe Lawrence Johan Almbladh Johan Hovold Johannes Berg John Ogness Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Keith Busch Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Linyu Yuan Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Lucien Buchmann Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marcin Wojtas Marek Vasut Mario Kleiner Mario Limonciello Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin K. Petersen Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Max Staudt Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Michael Chan Michael Ellerman Michael Grzeschik Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Mike Christie Miklos Szeredi Mimi Zohar Ming Lei Misaka19465 Muchun Song Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Niklas Schnelle Nirmoy Das Nuno Gonçalves Oder Chiou Pablo Neira Ayuso Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Philipp Zabel Ping-Ke Shih Po-Wen Kao Prike Liang Pär Eriksson Rafael J. Wysocki Rob Herring Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sumanth Korikkar sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thinh Nguyen Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Todd Brandt Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Krowiak Tony Lindgren Tony Nguyen Vaishnav Achath Vasily Gorbik Vikas Gupta Vinayak Yadawad Viresh Kumar Vitaly Kuznetsov Vladimir Murzin Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Yingliang Yangxi Xiang Yassine Oudjana Yefim Barashkin Yevhen Orlov Yi Yang Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm fail test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 8917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 17 17:45:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 17:45:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369135.600466 (Exim 4.92) (envelope-from ) id 1oD8KT-0005tf-9O; Sun, 17 Jul 2022 17:45:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369135.600466; Sun, 17 Jul 2022 17:45:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD8KT-0005tY-6W; Sun, 17 Jul 2022 17:45:17 +0000 Received: by outflank-mailman (input) for mailman id 369135; Sun, 17 Jul 2022 17:45:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD8KR-0005tO-Qx; Sun, 17 Jul 2022 17:45:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD8KR-0002d8-Oz; Sun, 17 Jul 2022 17:45:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oD8KR-0004Pp-89; Sun, 17 Jul 2022 17:45:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oD8KR-0005jH-7g; Sun, 17 Jul 2022 17:45:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dORlkLaGYBrh/8pDrEtc+KsR2/Dx63FVKQGOTjTRCGE=; b=r3gOvf4eG/9XoFnTH8/AH44QG2 tuP+P92YAv8AQvlnTIpijN52jp6mQ017tcefYM8FkJ441cBy/tOti0JohP8DTFRgw87b4Jw354ky8 DLq2RmbUy6r5pvbYOflDMQNN8NuBuYprWksm9F9Og88HuyfsVDEghX2TsTw4m0v99vQo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171661: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 X-Osstest-Versions-That: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b From: osstest service owner Date: Sun, 17 Jul 2022 17:45:15 +0000 flight 171661 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171661/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 baseline version: xen ab2977b027acbbd33a7eecda854d1911a7702f8b Last test of basis 171640 2022-07-15 12:01:46 Z 2 days Testing same since 171661 2022-07-17 14:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ab2977b027..a5fb66f451 a5fb66f4513c2c2d222dcc3753163b15690bd003 -> smoke From xen-devel-bounces@lists.xenproject.org Sun Jul 17 20:59:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 17 Jul 2022 20:59:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369147.600476 (Exim 4.92) (envelope-from ) id 1oDBM9-0001NE-4x; Sun, 17 Jul 2022 20:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369147.600476; Sun, 17 Jul 2022 20:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDBM9-0001N7-2G; Sun, 17 Jul 2022 20:59:13 +0000 Received: by outflank-mailman (input) for mailman id 369147; Sun, 17 Jul 2022 20:59:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDBM8-0001Mx-E7; Sun, 17 Jul 2022 20:59:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDBM8-00060Q-AY; Sun, 17 Jul 2022 20:59:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDBM7-0003yT-PI; Sun, 17 Jul 2022 20:59:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDBM7-0007PK-Oi; Sun, 17 Jul 2022 20:59:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dcMGwikojnaPuSW1xi31oRnjJoRRTpEVC5wG66K/NYk=; b=0HwO5eMq5xbmXBAsnNySUb+pp0 k7BgyA4zUMLdthh/sVAPeJF4fDYusuXXjllJHrRyOvspPe7hlzpvW72bxrGayW93A+haNCfDE4Yqg fM0qIrZdrkWPv5+P06KDYq4C8xWyn79ZFhdLPHSqEOcKDIB0lhrUSapBteuYMTyqKLE4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171662: regressions - FAIL X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:xen-boot:fail:regression linux-linus:build-i386-pvops:kernel-build:fail:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=2eccaca7b62b2836260c6fb22156a44e3d99a74a X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Sun, 17 Jul 2022 20:59:11 +0000 flight 171662 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171662/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-libvirt 8 xen-boot fail REGR. vs. 171587 build-i386-pvops 6 kernel-build fail REGR. vs. 171587 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 2eccaca7b62b2836260c6fb22156a44e3d99a74a baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 5 days Failing since 171601 2022-07-12 16:11:30 Z 5 days 10 attempts Testing same since 171662 2022-07-17 15:40:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alan Stern Alex Deucher Alex Deucher Alexander Gordeev Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda AngeloGioacchino Del Regno Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bartosz Golaszewski Bean Huo Biju Das Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue C. Erastus Toe Changyuan Lyu Chanho Park Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Christian Zigotzky Christoph Hellwig Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Darren Stevens Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller David Sterba Demi Marie Obenour Dmitry Osipenko Dmitry Torokhov Dorian Rudolph Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Gao Chao Greg Kroah-Hartman Guangwu Zhang Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilpo Järvinen Ilya Dryomov Israel Rukshin Jack Wang Jakub Kicinski Jason A. Donenfeld Jason Wang Javier Martinez Canillas Jeff Layton Jens Axboe Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Jiri Slaby Joanne Koong Joe Lawrence Johan Almbladh Johan Hovold Johannes Berg John Ogness Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Keith Busch Kent Gibson Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Linyu Yuan Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Lucien Buchmann Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marcin Wojtas Marek Vasut Mario Kleiner Mario Limonciello Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin K. Petersen Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Max Staudt Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Miaoqian Lin Michael Chan Michael Ellerman Michael Grzeschik Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Mike Christie Miklos Szeredi Mimi Zohar Ming Lei Misaka19465 Muchun Song Nathan Chancellor Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Niklas Schnelle Nirmoy Das Nuno Gonçalves Oder Chiou Pablo Neira Ayuso Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Philipp Zabel Ping-Ke Shih Po-Wen Kao Prike Liang Pär Eriksson Rafael J. Wysocki Rob Herring Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Sebastian Reichel Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siarhei Vishniakou Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sumanth Korikkar sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thinh Nguyen Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Todd Brandt Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Krowiak Tony Lindgren Tony Nguyen Uwe Kleine-König Vaishnav Achath Vasily Gorbik Vikas Gupta Vinayak Yadawad Viresh Kumar Vitaly Kuznetsov Vladimir Murzin Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Yingliang Yangxi Xiang Yassine Oudjana Yefim Barashkin Yevhen Orlov Yi Yang Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops fail test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 9159 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 18 02:03:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 02:03:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369208.600518 (Exim 4.92) (envelope-from ) id 1oDG68-0000sw-Fw; Mon, 18 Jul 2022 02:03:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369208.600518; Mon, 18 Jul 2022 02:03:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDG68-0000so-A8; Mon, 18 Jul 2022 02:03:00 +0000 Received: by outflank-mailman (input) for mailman id 369208; Mon, 18 Jul 2022 02:02:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDG67-0000se-2j; Mon, 18 Jul 2022 02:02:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDG67-00020A-0E; Mon, 18 Jul 2022 02:02:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDG66-0003O9-E9; Mon, 18 Jul 2022 02:02:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDG66-0005tB-Cs; Mon, 18 Jul 2022 02:02:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=zv/8Nhd1BkDqxLllrQw1t3bt/Q9fKVoBQRCzHAEsPyA=; b=ho49I5HKE3yT+QSq7+FVo+qrh0 UApDJ+ISWC7gDnYmsPq+JFflOeG0naZTOS4fTYWAT93PEoF/rTWZyygTjb48k6pvPRp9fNSTBMVYo y29lpWFSO1rxq6FTDVXgvtZAMIW7JAxha3NNmXoLQtSGcRWK90m9KyhdX9z8DGkGWqfU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171663: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 X-Osstest-Versions-That: xen=ab2977b027acbbd33a7eecda854d1911a7702f8b From: osstest service owner Date: Mon, 18 Jul 2022 02:02:58 +0000 flight 171663 xen-unstable real [real] flight 171665 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171663/ http://logs.test-lab.xenproject.org/osstest/logs/171665/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-examine-bios 6 xen-install fail pass in 171665-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171655 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171655 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171655 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171655 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171655 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171655 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171655 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171655 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171655 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171655 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171655 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171655 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 baseline version: xen ab2977b027acbbd33a7eecda854d1911a7702f8b Last test of basis 171655 2022-07-17 01:53:18 Z 1 days Testing same since 171663 2022-07-17 18:09:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Julien Grall Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios fail test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git ab2977b027..a5fb66f451 a5fb66f4513c2c2d222dcc3753163b15690bd003 -> master From xen-devel-bounces@lists.xenproject.org Mon Jul 18 02:35:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 02:35:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369219.600529 (Exim 4.92) (envelope-from ) id 1oDGbs-0004dD-Uc; Mon, 18 Jul 2022 02:35:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369219.600529; Mon, 18 Jul 2022 02:35:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDGbs-0004d6-Rq; Mon, 18 Jul 2022 02:35:48 +0000 Received: by outflank-mailman (input) for mailman id 369219; Mon, 18 Jul 2022 02:35:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDGbs-0004d0-3O for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 02:35:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60041.outbound.protection.outlook.com [40.107.6.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 524c5bb8-0642-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 04:35:46 +0200 (CEST) Received: from FR3P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::20) by HE1PR0801MB2011.eurprd08.prod.outlook.com (2603:10a6:3:49::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 02:35:41 +0000 Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1d:cafe::c8) by FR3P281CA0017.outlook.office365.com (2603:10a6:d10:1d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.16 via Frontend Transport; Mon, 18 Jul 2022 02:35:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT023.mail.protection.outlook.com (10.152.18.133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 02:35:40 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Mon, 18 Jul 2022 02:35:40 +0000 Received: from 4143b5c5ee54.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 34E6835D-0429-474A-AB64-725DF248BB9D.1; Mon, 18 Jul 2022 02:35:34 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4143b5c5ee54.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 02:35:34 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VE1PR08MB5165.eurprd08.prod.outlook.com (2603:10a6:803:10b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 02:35:31 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 02:35:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 524c5bb8-0642-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=X31sVj9mqYShu89wtmVBecDL+sJ/eKr97EeOkq+1dw0pM6xyXkJPLWxylnhVblsnr/FY0c5m2EsKxL0qcfwP3iVAjIrUi6ilmD8fDFJs5nIk/pqkWh5u9KY2pAKhCb9H3pjAjYdgzjY3XnBBYGfw04kitJAt+jZvBT5nT8K9wa9E3effkA6oyovUmdp//3AScn4Cy+DJlfQGR+4ABpBRAR3LpRbAyX460Y7TbL8L4JI87d9D3Nat4S3ntGsZJMRdotWdxY/I2SElkEdOv/aKHgJVHsGauS+HbGTw6zu5Jb6Wh+iJupEP3ALlZGtDIn3sQGbpdwXG9s6XcI8tv1YNCQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IXeSAIE5D9TtN7VgfaN92kv4d7Jb6GTKGVhKjbNHNnA=; b=UkmzcbzZLenOb0S68NKqi4HPZcIujgZv707dHEN/BsIifAyYxQdhu4+l1ciC9lRnzYmPJEFGVIOojy1iGl7pBktf6W4c6g9hUjkubkJ63vAc79GgBj1rtJwuowgx7chG4w2MxLdbwoPmBUkow4cNflDtlAsid6Mq9mDEBgw3l7eDLMPMZpblDpbvGH/zdECIafo6D063XaWvt5LZ1yY626eVvWyNWSx7/a7nwpPaI4kZMf//6h1fmwgkRi3KZdTa1I+fG0N1oLXrr7MxUscGn/5uu04KejU74Y9Y76GL15v1v1/E8QvPW53vtwpRu+dlMtTjqRyJeHN7YvkFhrbKDg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXeSAIE5D9TtN7VgfaN92kv4d7Jb6GTKGVhKjbNHNnA=; b=vJzImpqm2ybvrXgm/cGiNT0lZ1IWHt3iOGXYITjxFRFRJs5C0VlgsiBeehAlLC1+HUsdAlYZig4g9/JNRihuxQ8Z+pLo5ORD/fTj3msb/g+T/EK5RiGh+t3z6pbQYhtjL+BCa0YgTJC1oWaKrgEYve56onr9knYzKl6L9JhDL24= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GIAkHR+8pU71PNi12h5WY8x9bFFOz6JhXV3/v1/dkeWh6OLVtmOI/KXlJxr7Og3cjk5PclFPAVB9Va0DDPBsnaKxIWpscA1S659SSY5/Ua8g5qjixPdXwrzmHhksvMWAc5mggpZOLNBB+S0OQ5NRKJkpPtWx4l4uCWjy0L1Iw8z8jUR3Rmr8BbKSRoANZ4NvxV3JbD9n4uGtWUZj52/lv1BIHjiRj/0ZuFD91Qij3YHKjKx+fsNLNMBXBhKPymk0pbLw1t+wmzIb+M1ThoFSmW2h81CMm7CTXV4M1mMNGIq2fsFRqz7WpHLuPV2JNdN2JGeKH9yNzq7JGl0ZNByK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IXeSAIE5D9TtN7VgfaN92kv4d7Jb6GTKGVhKjbNHNnA=; b=ne0VDd2jK12XziQqDxWT0L3nEXl3Keu7FDBO0D4jZ6eMFEr6KHV8QVDID69H46OvFMUPwEWXDvFYIYdoTJPy2aiJ1JslZXKjSAkvsYZ7CdFBrUY3/XZRzCWhP+LX5uXqLpCrxiW1g2VWZ5URVZCRylumvCRIHwQ51AaNSudroGPGFcpyv8uCzlT4MRXOPwUVh+JBmzG4QoxCe31ABLH7+de2bzW2TzwBGTt/FlI9wLdcFlVwDQIqo/Lq2Z+jd+zFfiXV9zIJXXcTmX1NgzwW3l9/qYgt0TIPznUOzRxXl5sEa36LBTpxZ9z014MwHpE7zp6tpOvJHeQtT8AhYPWTEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IXeSAIE5D9TtN7VgfaN92kv4d7Jb6GTKGVhKjbNHNnA=; b=vJzImpqm2ybvrXgm/cGiNT0lZ1IWHt3iOGXYITjxFRFRJs5C0VlgsiBeehAlLC1+HUsdAlYZig4g9/JNRihuxQ8Z+pLo5ORD/fTj3msb/g+T/EK5RiGh+t3z6pbQYhtjL+BCa0YgTJC1oWaKrgEYve56onr9knYzKl6L9JhDL24= From: Penny Zheng To: Julien Grall , "xen-devel@lists.xenproject.org" CC: Wei Chen , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: RE: [PATCH v5 1/8] xen/arm: introduce static shared memory Thread-Topic: [PATCH v5 1/8] xen/arm: introduce static shared memory Thread-Index: AQHYhGRAIMWAAZoglEyYz3pT8Ubq/a1e3kuAgAc4ucCAGcxmgIADsJ/Q Date: Mon, 18 Jul 2022 02:35:30 +0000 Message-ID: References: <20220620051114.210118-1-Penny.Zheng@arm.com> <20220620051114.210118-2-Penny.Zheng@arm.com> <45a41132-1520-a894-a9eb-6688c79a660d@xen.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 388CD2AECDA56A4688DFE397CA5F400D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 11edf379-d497-4b5f-8519-08da686634c3 x-ms-traffictypediagnostic: VE1PR08MB5165:EE_|VE1EUR03FT023:EE_|HE1PR0801MB2011:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: IOkdwOgsSTKYxtFHoDLpanVfwZhJq1iE6UAjJ96fbmo/QuIYk/b0c/2SSVyhsCsYjhaHqJ7JZc3ZKRO0fcrxRi1jc9vLcFxEOnR81TKCFbynlRyNt/rEqrtNfKgiDda7Pxcr8h7txbYDP6lGZFNNKKX77kZzvbdOK5CVfEdhu5tAdSAbUgfarpqwncJfiNQCDkBgB1IkFc3czg25ZnT4i1mjw8ic/RZAcHOl0wOQcJiwT9+Iok3qenyiGiaT184PGtkFPuZD+NT8jPDPLyP8O6EAhxEUEwNhCRBBNFEalR1j5UT17pZYH8jnxIJ6NDKFZU/KthRfmytTiRq6+zH9Q6pGp2zSShKpcSwa8tzIftDeGHmUrp3sHr6o4dhZoRSYP891YHj5SHxx/BWNXOX1xNPLGeImwM95EJ5kfQusuJnL1iXu9i5iyTaiG0Y/eFeEhc2zo196vxcrJfBq3SjIHWkWIb22SFHziVHIhBT0AJEv91umg34eX5l3uKF51rlJvx4r4Ykeuvx5suef5DhsIWgOuRD9tEZk4172GhXMhmI7XTXYkqXk46M3AjiNn6nlZ1OQ3lWxsQdksrcwIjYxtuPM5pUsjmTRwSQ0dgWVWbPS1zUwB40iKFRAvaVZD70Lbc8Ds4hXLdDmKpej8aerXifF4JumruPl9z7BAsGAQPEIJxFwCwEu7nYudP7rUOH88FTCj5KGqqEdI5Q9idDd6QpJggt8COHrXTtMADgcnqSrh+NlCaSSgS6xrk28AP1PMmzY+13Kuw0nFXC4dbYPt01qzazazuKcaE5vErGqdIAvzpW/3d2Hgxv8PUheRtPu X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(366004)(39850400004)(376002)(9686003)(5660300002)(86362001)(52536014)(8936002)(7696005)(6506007)(478600001)(41300700001)(53546011)(2906002)(26005)(33656002)(4326008)(122000001)(38070700005)(83380400001)(186003)(55016003)(66556008)(66446008)(64756008)(66476007)(8676002)(76116006)(316002)(66946007)(54906003)(110136005)(71200400001)(38100700002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5165 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 100257bf-88d0-46a1-cfd1-08da68662ec7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yRqY5n8qXMHTOmZcqyErtVGm+w+QNY+VtBGc0IHeF6B7Y2ao/sTAOxzgb8nyETXWlvTVLe5joSVeioalxQT8djruUnbPiIXzvTh45yN5f7HzRNJQ4n7sLrJmR1gOelB0bhlcBf//nixOs3xLR2hA0J9d4qNr6zc4Z5sp0zmlqGdYQNLKrKbkJJ3puRfrypeYDR1PgFqqajb5ieOSjHGR2vXZ0ixixqMmPNOEHGNEDQt1oEhmaWR5qk6UG423HvIi5nhUdoqR4iZ583rPhn8zmrsT0A/yhNi7gb/Wx+prmYBZIkZYbDULt7SI4XOFj9EQcC2akWiTA5XPE4phWb3p9XZsKKfz22gF3V6nTjrpSngs6YIhdDUTHkH9lsnTkfs3GiynYZnuUpiB8SkUFwR+D3ufC8Ulen+30yek0c2R79hMkk4hJ0hP79tZLpo3dNUXQOA/rgFqr+nnrImBlXESHYF8sC/0qKkRMamtbD1czSKClPJNeaThdQKCah2hqgCkOcdj5KoJ7uy2rkbF1W3oT6lqMuRvdvfyTVU+2Uyig0q0DOILEyvXRBmyDpKu++pdPSAGCPbrhC4ABFbG5r6pRazGo289hmhrWhdrcfxodc3b9Orpb5lW53C3vDrdYE0yAZFX7DP334vmlFXBtUMUaLtoil9h8ZGZP+Qrmc+iLoAfRsprnkgI/sLcT7AXFNydeaANsgVMIORHgim/Lmg+SQBObNoy2WORMG10mRyo9BytnsZBFSRCrZOQF/oCFwyubdhCZlQ1N1cKqHEttr0hUg4Tw9REYL4MwsyIwJMszoU= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39850400004)(396003)(376002)(136003)(36840700001)(46966006)(40480700001)(36860700001)(5660300002)(55016003)(86362001)(82740400003)(316002)(70206006)(54906003)(2906002)(81166007)(70586007)(110136005)(336012)(107886003)(8676002)(186003)(47076005)(4326008)(478600001)(9686003)(26005)(7696005)(52536014)(8936002)(6506007)(41300700001)(53546011)(82310400005)(33656002)(356005)(83380400001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 02:35:40.6340 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11edf379-d497-4b5f-8519-08da686634c3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2011 SGkgSnVsaWVuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSnVsaWVu IEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogU2F0dXJkYXksIEp1bHkgMTYsIDIwMjIg MjoxMCBBTQ0KPiBUbzogUGVubnkgWmhlbmcgPFBlbm55LlpoZW5nQGFybS5jb20+OyB4ZW4tZGV2 ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gQ2M6IFdlaSBDaGVuIDxXZWkuQ2hlbkBhcm0uY29t PjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPjsgQmVydHJh bmQgTWFycXVpcyA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsNCj4gVm9sb2R5bXlyIEJhYmNo dWsgPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIIHY1 IDEvOF0geGVuL2FybTogaW50cm9kdWNlIHN0YXRpYyBzaGFyZWQgbWVtb3J5DQo+IA0KPiBIaSBQ ZW5ueSwNCj4gDQo+IE9uIDI5LzA2LzIwMjIgMDk6MzksIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+ Pj4gKyAgICBmb3IgKCBpID0gMDsgaSA8IG1lbS0+bnJfYmFua3M7IGkrKyApDQo+ID4+PiArICAg IHsNCj4gPj4+ICsgICAgICAgIC8qDQo+ID4+PiArICAgICAgICAgKiBBIHN0YXRpYyBzaGFyZWQg bWVtb3J5IHJlZ2lvbiBjb3VsZCBiZSBzaGFyZWQgYmV0d2VlbiBtdWx0aXBsZQ0KPiA+Pj4gKyAg ICAgICAgICogZG9tYWlucy4NCj4gPj4+ICsgICAgICAgICAqLw0KPiA+Pj4gKyAgICAgICAgaWYg KCBwYWRkciA9PSBtZW0tPmJhbmtbaV0uc3RhcnQgJiYgc2l6ZSA9PSBtZW0tPmJhbmtbaV0uc2l6 ZSApDQo+ID4+PiArICAgICAgICAgICAgYnJlYWs7DQo+ID4NCj4gPiBNYXliZSBJIG5lZWQgdG8g YWRkIGEgY2hlY2sgb24gc2htLWlkOg0KPiA+ICINCj4gPiAgICAgICAgICAvKg0KPiA+ICAgICAg ICAgICAqIEEgc3RhdGljIHNoYXJlZCBtZW1vcnkgcmVnaW9uIGNvdWxkIGJlIHNoYXJlZCBiZXR3 ZWVuIG11bHRpcGxlDQo+ID4gICAgICAgICAgICogZG9tYWlucy4NCj4gPiAgICAgICAgICAgKi8N Cj4gPiAgICAgICAgICBpZiAoIHN0cmNtcChzaG1faWQsIG1lbS0+YmFua1tpXS5zaG1faWQpID09 IDAgKQ0KPiA+ICAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAgaWYgKCBwYWRkciA9PSBtZW0t PmJhbmtbaV0uc3RhcnQgJiYgc2l6ZSA9PSBtZW0tPmJhbmtbaV0uc2l6ZSApDQo+ID4gICAgICAg ICAgICAgICAgICBicmVhazsNCj4gPiAgICAgICAgICAgICAgZWxzZQ0KPiA+ICAgICAgICAgICAg ICB7DQo+ID4gICAgICAgICAgICAgICAgICBwcmludGsoIldhcm5pbmc6IHhlbixzaG0taWQgJXMg ZG9lcyBub3QgbWF0Y2ggZm9yIGFsbCB0aGUgbm9kZXMNCj4gdXNpbmcgdGhlIHNhbWUgcmVnaW9u LlxuIiwNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICBzaG1faWQpOw0KPiA+ICAgICAgICAg ICAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4gICAgICAgICAgICAgIH0NCj4gPiAgICAgICAg ICB9DQo+ID4gIg0KPiA+IFdkeXTvvJ8NCj4gDQo+IEFGQUlDVCwgdGhpcyB3b3VsZCBhbGxvdyB0 byByZWdpb24gdG8gb3ZlcmxhcCBpZiB0aGV5IGhhdmUgZGlmZmVyZW50IHNobSBJRC4gSQ0KPiBh bSBub3QgZW50aXJlbHkgc3VyZSB0aGUgcmVzdCBvZiB5b3VyIGNvZGUgd291bGQgd29yayBwcm9w ZXJseSBpbiB0aGlzIGNhc2UNCj4gKHdoYXQgaWYgdGhlIG93bmVyIGlzIGRpZmZlcmVudCkuDQo+ IA0KPiBTbyBJIHRoaW5rIHdlIG5lZWQgdGhlIGZvbGxvd2luZyBjaGVja3M6DQo+ICAgIDEpIFRo ZSBzaG0gSUQgbWF0Y2hlcyAqYW5kKiB0aGUgcmVnaW9uIGV4YWN0bHkgbWF0Y2gNCj4gICAgMikg VGhlIHNobSBJRCBkb2Vzbid0IG1hdGNoIGFuZCB0aGUgcmVnaW9uIGRvZXNuJ3Qgb3ZlcmxhcCB3 aXRoIGFuDQo+IGV4aXN0aW5nIG9uZQ0KPiANCg0KVW5kZXJzdG9vZCwgdHJ1ZSwgdGhlIG92ZXJs YXAgc2hhbGwgYWxzbyBiZSBjaGVja2VkLg0KIg0KQEAgLTQ1MSw2ICs0NTMsMzEgQEAgc3RhdGlj IGludCBfX2luaXQgcHJvY2Vzc19zaG1fbm9kZShjb25zdCB2b2lkICpmZHQsIGludCBub2RlLA0K ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCiAgICAgICAgICAgICB9DQogICAgICAg ICB9DQorICAgICAgICBlbHNlDQorICAgICAgICB7DQorICAgICAgICAgICAgcGFkZHJfdCBlbmQg PSBwYWRkciArIHNpemU7DQorICAgICAgICAgICAgcGFkZHJfdCBiYW5rX2VuZCA9IG1lbS0+YmFu a1tpXS5zdGFydCArIG1lbS0+YmFua1tpXS5zaXplOw0KKw0KKyAgICAgICAgICAgIGlmICggKHBh ZGRyIDwgbWVtLT5iYW5rW2ldLnN0YXJ0ICYmIGVuZCA8PSBtZW0tPmJhbmtbaV0uc3RhcnQpIHx8 DQorICAgICAgICAgICAgICAgICAocGFkZHIgPj0gYmFua19lbmQgJiYgZW5kID4gYmFua19lbmQp ICkNCisgICAgICAgICAgICB7DQorICAgICAgICAgICAgICAgIGlmICggc3RybmNtcChzaG1faWQs IG1lbS0+YmFua1tpXS5zaG1faWQsDQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICBNQVhf U0hNX0lEX0xFTkdUSCkgIT0gMCApDQorICAgICAgICAgICAgICAgICAgICBicmVhazsNCisgICAg ICAgICAgICAgICAgZWxzZQ0KKyAgICAgICAgICAgICAgICB7DQorICAgICAgICAgICAgICAgICAg ICBwcmludGsoImZkdDogZGlmZmVyZW50IHNoYXJlZCBtZW1vcnkgcmVnaW9uIGNvdWxkIG5vdCBz aGFyZSB0aGUgc2FtZSBzaG0gSUQgJXNcbiIsDQorICAgICAgICAgICAgICAgICAgICAgICAgICAg c2htX2lkKTsNCisgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOw0KKyAgICAgICAg ICAgICAgICB9DQorICAgICAgICAgICAgfQ0KKyAgICAgICAgICAgIGVsc2UNCisgICAgICAgICAg ICB7DQorICAgICAgICAgICAgICAgIHByaW50aygiZmR0OiBzaGFyZWQgbWVtb3J5IHJlZ2lvbiBv dmVybGFwIHdpdGggYW4gZXhpc3RpbmcgZW50cnkgJSMiUFJJcGFkZHIiIC0gJSMiUFJJcGFkZHIi XG4iLA0KKyAgICAgICAgICAgICAgICAgICAgICAgIG1lbS0+YmFua1tpXS5zdGFydCwgYmFua19l bmQpOw0KKyAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsNCisgICAgICAgICAgICB9DQor ICAgICAgICB9DQogICAgIH0NCg0KICAgICBpZiAoIGkgPT0gbWVtLT5ucl9iYW5rcyApDQoiDQoN Cj4gQ2hlZXJzLA0KPiANCj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 04:52:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 04:52:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369230.600540 (Exim 4.92) (envelope-from ) id 1oDIk9-0003TH-MS; Mon, 18 Jul 2022 04:52:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369230.600540; Mon, 18 Jul 2022 04:52:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDIk9-0003TA-JZ; Mon, 18 Jul 2022 04:52:29 +0000 Received: by outflank-mailman (input) for mailman id 369230; Mon, 18 Jul 2022 04:52:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDIk8-0003T0-9F; Mon, 18 Jul 2022 04:52:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDIk8-0005XE-4k; Mon, 18 Jul 2022 04:52:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDIk7-0003Zh-NF; Mon, 18 Jul 2022 04:52:27 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDIk7-0001cs-MZ; Mon, 18 Jul 2022 04:52:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kGl/BxV7a/WmNFny6C9QtzdQFSt0k6kY9fErgdFfLtU=; b=bvhbCj2NWJDj2xSw6tvwsvZ9hy mKuWfCvE2RzMqBNSncGfG4iB/Hw88D8tV9x2Znag91O5+Wk+/rLPB5+OwG2rPvvuPAB6t9wN4BvDc EfgIWZax5ldNVIN6on0f8KipxkUlOuE/WB8oM88ZRi9u21bav+Gtnd8YVvUoqtQqNQaU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171664: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ff6992735ade75aae3e35d16b17da1008d753d28 X-Osstest-Versions-That: linux=5a29232d870d9e63fe5ff30b081be6ea7cc2465d From: osstest service owner Date: Mon, 18 Jul 2022 04:52:27 +0000 flight 171664 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171664/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171587 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171587 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171587 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171587 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171587 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171587 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ff6992735ade75aae3e35d16b17da1008d753d28 baseline version: linux 5a29232d870d9e63fe5ff30b081be6ea7cc2465d Last test of basis 171587 2022-07-12 00:10:46 Z 6 days Failing since 171601 2022-07-12 16:11:30 Z 5 days 11 attempts Testing same since 171664 2022-07-17 21:11:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Alan Stern Alex Deucher Alex Deucher Alexander Gordeev Alexandre Chartre Alexandre Ghiti Alexei Starovoitov Alyssa Rosenzweig Andi Shyti Andrea Mayer Andrew Cooper Andrzej Hajda AngeloGioacchino Del Regno Ansgar Lößer Ansgar Lößer Anup Patel Anup Patel Ard Biesheuvel Arnaldo Carvalho de Melo Arnd Bergmann Arunpravin Paneer Selvam Bagas Sanjaya Baowen Zheng Bartosz Golaszewski Bean Huo Biju Das Bin Meng Bjorn Andersson Bjorn Helgaas Borislav Petkov Brent Lu Brian Norris Bryan O'Donoghue C. Erastus Toe Changyuan Lyu Chanho Park Charles Keepax Chia-Lin Kao (AceLan) Chris Wilson Chris Wilson Christian Brauner (Microsoft) Christian Brauner Christian König Christian Zigotzky Christoph Hellwig Chuck Lever Claudiu Beznea Coiby Xu Conor Dooley Cristian Ciocaltea Cédric Le Goater Dan Carpenter Daniel Borkmann Daniel Mack Daniel Wheeler Daniele Ceraolo Spurio Darren Stevens Dave Airlie Dave Chinner Dave Hansen David Howells David Owens David Owens David S. Miller David Sterba Demi Marie Obenour Dmitry Osipenko Dmitry Torokhov Dorian Rudolph Douglas Anderson Edward Cree Eli Cohen Enzo Matsumiya Eric Dumazet Evan Quan Ezequiel Garcia Fangzhi Zuo Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Frank Mankel Gal Pressman Gao Chao Greg Kroah-Hartman Guangwu Zhang Guenter Roeck Gurucharan (A Contingent worker at Intel) Han Xu Hangyu Hua Hans de Goede Hayes Wang Hector Martin Heiko Stuebner Heinrich Schuchardt Huaxin Lu Ian Woloschin Igor Mammedov Ilpo Järvinen Ilya Dryomov Israel Rukshin Jack Wang Jakub Kicinski Jason A. Donenfeld Jason Wang Javier Martinez Canillas Jeff Layton Jens Axboe Jens Wiklander Jeremy Szu Jernej Skrabec Jiang Jian Jianglei Nie Jiapeng Chong Jiri Slaby Joanne Koong Joe Lawrence Johan Almbladh Johan Hovold Johannes Berg John Ogness Jon Hunter Josh Poimboeuf Josh Poimboeuf José Roberto de Souza Juergen Gross Julian Sikorski Kalle Valo Kalle Valo Karolina Drobnik Kashyap Desai Kefeng Wang Keith Busch Kent Gibson Kim Phillips Konrad Rzeszutek Wilk Kris Bahnsen Kuniyuki Iwashima Li kunyu Liang He Linus Torvalds Linus Walleij Linyu Yuan Liu Ying Liu, Changcheng Lorenzo Bianconi Luca Weiss Lucien Buchmann Luis Chamberlain Lukas Bulwahn Marc Kleine-Budde Marcin Wojtas Marek Vasut Mario Kleiner Mario Limonciello Mark Bloch Mark Brown Martin Blumenstingl Martin Habets Martin K. Petersen Martin Povišer Masami Hiramatsu (Google) Mat Martineau Matthew Auld Matthieu Baerts Mauro Carvalho Chehab Max Krummenacher Max Staudt Maxim Mikityanskiy Maxime Ripard Mel Gorman Melissa Wen Meng Tang Miaoqian Lin Michael Chan Michael Ellerman Michael Grzeschik Michael Walle Michal Hocko Michal Suchanek Michel Dänzer Mika Kuoppala Mike Christie Miklos Szeredi Mimi Zohar Ming Lei Misaka19465 Muchun Song Nathan Chancellor Naveen N. Rao Neil Armstrong Nick Bowler Nick Desaulniers Nicolas Dichtel Niklas Schnelle Nirmoy Das Nuno Gonçalves Oder Chiou Pablo Neira Ayuso Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Blakey Paul M Stillwell Jr Paul Moore Pavan Chebbi Pavel Skripkin Pawan Gupta Peter Geis Peter Ujfalusi Peter Zijlstra (Intel) Peter Zijlstra Petr Mladek Philipp Zabel Ping-Ke Shih Po-Wen Kao Prike Liang Pär Eriksson Rafael J. Wysocki Rob Herring Rodrigo Vivi Roi Dayan Ron Economos Russell King (Oracle) Ryan Wanner Ryder Lee Saeed Mahameed Samuel Holland Sascha Hauer Sean Anderson Sebastian Reichel Serge Semin Shawn Guo Shyam Prasad N Shyam Sundar S K Siarhei Vishniakou Siddharth Vadapalli Simon Horman Solomon Chiu Stefan Berger Stephen Boyd Steve French Steven Price Steven Rostedt (Google) Sumanth Korikkar sunliming Takashi Iwai Tariq Toukan Tejun Heo Thadeu Lima de Souza Cascardo Thinh Nguyen Thomas Gleixner Thomas Hellström Thomas Voegtle Thomas Zimmermann Tianyu Yuan Tiezhu Yang Todd Brandt Toke Høiland-Jørgensen Toke Høiland-Jørgensen Tom Lendacky Tony Krowiak Tony Lindgren Tony Nguyen Uwe Kleine-König Vaishnav Achath Vasily Gorbik Vikas Gupta Vinayak Yadawad Viresh Kumar Vitaly Kuznetsov Vladimir Murzin Wang Kefeng Will Deacon William Zhang xinhui pan Xiu Jianfeng Xiubo Li Yang Jihong Yang Yingliang Yangxi Xiang Yassine Oudjana Yefim Barashkin Yevhen Orlov Yi Yang Zhen Lei Zheng Yejian Zhenyu Wang Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 5a29232d870d..ff6992735ade ff6992735ade75aae3e35d16b17da1008d753d28 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Jul 18 05:42:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 05:42:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369241.600551 (Exim 4.92) (envelope-from ) id 1oDJWb-0001Is-CS; Mon, 18 Jul 2022 05:42:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369241.600551; Mon, 18 Jul 2022 05:42:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJWb-0001Il-9c; Mon, 18 Jul 2022 05:42:33 +0000 Received: by outflank-mailman (input) for mailman id 369241; Mon, 18 Jul 2022 05:42:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJWZ-0001If-6C for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 05:42:31 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 672b72b4-065c-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 07:42:27 +0200 (CEST) Received: from mail-bn8nam12lp2177.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 01:42:24 -0400 Received: from PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) by MN2PR03MB5342.namprd03.prod.outlook.com (2603:10b6:208:1ea::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Mon, 18 Jul 2022 05:42:22 +0000 Received: from PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d]) by PH0PR03MB5669.namprd03.prod.outlook.com ([fe80::b4c7:a1fc:f10d:8b9d%3]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 05:42:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 672b72b4-065c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658122947; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=dMXNaLEMJxluRIoKEwjzEhx4WVOVK7DjDaTYIy0tRhg=; b=AdisXuZohW/C+JiWpBHgir01EYqnljRGfMeHP25IXgcqK3y5O4f2w6yJ umiaO4qMPH384+3NxRrQAN6Mc1UpywOqXTEn2rnGpmuc5xxwOg1lyn2ay DbVIHusf3tZycidlE3TCKwhnQxL9vh0TuLfllEjKB28o/XvZTW/SVaOWd o=; X-IronPort-RemoteIP: 104.47.55.177 X-IronPort-MID: 76007427 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:q+zM2qzsygtTw+A+YYl6t+eqxyrEfRIJ4+MujC+fZmQN5Y8a5oE1v iFGDjfXfrrIN3ykOIpG3L7G/UxXupDTytNmTgBv+Cw9Qn9D9ZDPWt+TJ0qpZnLIJJOdHBo+4 pVCNYGRdZE/Hi6A+0z3bee583J3iajZSOqiA4YoVswJqSpMEU/N3jo/y75RbvdUvOWE7yOxV fLa8pLRNVOogDUkbT5E5fzS9kxm5Kv/6WkTsFBgPa8a5QGPy3VNAJwhfqzgdHGQrqu4vwKZq 0Qv6Jnjows1Kj90UovNfo7TKxFMGPiKVeS3oiI+c7C4hRRfrTAF3K8+Nf4NAW9akDzMlN1qo Dl3ncXYpTwBY+udwozxbzECS3skZfIfp+edSZSCmZf7I3PuIiOEL8pGVCnaDaVAks5rDGdH8 +AvKTxlRnhvUMrvndpX4sE17igSBJGD0LE34xmM/hmAZRoSerjRQr2i2DNt9GxYavaivxrpT 5FxhTJHNHwsavDUU7sdIMpWcOyA3hETf9DEwb48SGVeD2X7lWRMPLbR3NX9ZNDRHeBsrGWkj 2fWwD7FATU7LP/O4G/Qmp6srrencSLTfqs3Tef93Ng6xVqZyyoUFQEcUka9rb+hkEmiVtlDK ksSvC0zsaw180/tRd74N/G6iCfc4lhABJwNTqtjt17lJqn8um51AkArQzlbZ9FgmNIwQTUy/ lSIg8noFXpkt7j9pXe1qenM9WzuY3d9wWkqSh1aEBoj2oDfjb5slh3LTdt4L4OKt4igcd336 3XQxMQkvJ0Rh8MW06Sw/Xjcnimh4JPOS2Yd9gjRG26o8A59TIqkfJCzr0jW6+5aK4SURUXHu 2IL8+CB6MgeAJfLkzaCKM0RHbSB9/uDdjrGjjZS84IJ8j2s/zupe9BW6TQnfkNxaJ9bJnnuf VPZvh5X6NlLJny2YKRrYoW3TcM30aznEtejXffRBjZTXqVMmMa81HkGTSatM6rFySDATYlX1 U+nTPuR IronPort-HdrOrdr: A9a23:7PCacqNB+YAkkcBcT23155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90dq7MAnhHP9OkMQs1NKZMDUO11HYS72KgbGC/9SkIVyHygc/79 YtT0EdMqyXMbESt6+Tj2eF+pQbsaC6GcuT9IXjJgJWPGVXgtZbnmJE42igcnFedU1jP94UBZ Cc7s1Iq36LYnIMdPm2AXEDQqzqu8DLvIiOW29JOzcXrC21yR+44r/zFBaVmj0EVSlU/Lsk+W /Z1yTk+6SYte2hwBO07R6T030Woqqg9jJwPr3PtiEnEESotu9uXvUkZ1S2hkF3nAho0idsrD CDmWZnAy050QKtQoj8m2qQ5+Cn6kdg15aq8y7nvVLz5cP+Xz40EMxHmMZQdQbY8VMpuJVm3L tMxH/xjeseMfpuplWO2zBZPysa6XZcjEBS59L7tUYvGLc2eftUt8gS7UlVGJAPEGbz750mCv BnCIXZ6OxNeV2XYnjFti03qebcFEgbD1ODWAwPq8aV2z9ZkDRwyFYZ3tUWmjMF+IgmQ5dJ6u zYOuBjla1ITMURcaVhbd1xCvefGyjIW1bBIWiSKVPoGOUOPG/MsYf+5PEv6OSjaPUzvewPcV T6ISdlXEIJCjLT4Je1rex2Gzj2MRaAdCWozN1C7J5kvbC5TKb3MES4OSUTr/c= X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="asc'?scan'208,217";a="76007427" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iKQn3EX2kdWIaWgqG3EBToJhnIygrNcoH7WuC4EntoHJ/PQCIWVSffIsFIM5rtaI8xSSL8cmomJzrj20Fk7VLhFyCMqsPsvbBYwlLGJrq6v84Fn6U6rP5uuou5MHb70o6Ot2bA93cZV8SSxEfEfRsQvq/S50raFZP0lAkVv3WFjLqC11VeW7CXDUnrObJyGQQo3zCrtaWQySeKaMFhXhp+f3GZ7M8xox2kkZyZJAYIXNDqqOxIQ4TUE3G0BYjr00Wd/bwoSnLd9JLutvUx16A3kWfQgl2GPNBUJlPCbMjx1QrOldUlDnAQ7mH1k63MWkYZC790ADFP+qf+s8DUDgIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bV06MbpGMcLYbTL87gpdq9MyUV/jcZP7G81t3heswKk=; b=OijuQ4W6kjcG6od6ugYi419TDZ76EAcBiNSS62rawRd1zUe3JKxU4ykbRn77dvweyu2j5EIMcOBNsrH8MKp3JhxnsNgsdUZd7B+ez12y27HzgrhwxwXw7ZmA5wcwd8Ss9KWhyzZVU8EfmY/YgiT2UbfiI+AmoN7UZyOuR2K9VoWsDmj8Gbv8pVsvdq7HHeW54vhfqxnQXXcJkTcSI/ND1cEtNSuMLk86z4bqZ+0L0j1LzIHGaY2BUoPZeqZjH2+9IX6N+hVk252NxL/CUlIoEgz6tQgVnENXWGIG5jc+DsPAGXGqDQ3F7L0CR6E0kilRuC0gdHz82anEWejjDrzZ3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bV06MbpGMcLYbTL87gpdq9MyUV/jcZP7G81t3heswKk=; b=Gw1tUWq2BgmnKZezCjmsm3cJeBXvkcq1EF+c2z3LvHiISoyTDdTFicILHAO1ACG9U/U1mJUmkgeU5Xx4y/CVYtyZ2jA7eUL5NyEAIuGrUoiMLWYHCO3cknalyMLeNDxtcwE3zbcrWQOMEriudxS9r/IFuz1NhL6dt6Rei03TtTo= From: George Dunlap To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau Monne , "Tim (Xen.org)" Subject: Re: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests Thread-Topic: [PATCH 2/2] x86/P2M: allow 2M superpage use for shadowed guests Thread-Index: AQHX7O/bKX0sOdH9/0aIlntq4rv2Q61gJw0AgAPel4CAIPLIgA== Date: Mon, 18 Jul 2022 05:42:22 +0000 Message-ID: <85FA3236-5BDA-4387-AEE1-A97D139353EE@citrix.com> References: <9ae1d130-178a-ba01-b889-f2cf2a403d95@suse.com> <7a80d08b-edd7-43c8-a7ce-42eb85d6f3be@suse.com> <8D91423A-67A6-40B3-A3D7-44711DC41A7E@citrix.com> <64ff8cc6-6c15-7255-e908-36d7bbbd6348@suse.com> In-Reply-To: <64ff8cc6-6c15-7255-e908-36d7bbbd6348@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a958d3b3-66c8-4db1-126a-08da6880496b x-ms-traffictypediagnostic: MN2PR03MB5342:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UqYFNm+rCzYJmZcmiq26hWb5ZFqGxmV9uKN/H2FGMQnD5X2K1ojjZPa/irG1X7t4QVKCMUprB3HrWnqEQD4mGUBQZdi/d5N7g8HO6I1+D3wkAKdt7ITz0O1yFpzurDGH5BmIq3cd77PTd9JQs/297a0fh282XEIcPS1WBRSjWfakWQT8b8hkFuNRSdBUifYpH4eLbb/zgS3KVDav3xUdTv+OeTn8oFVks78tedDihPb6LI31OP8ukbuHN0pFvHySzWpzo925dJowspNZ74mkH76xw4bvW01yoiVKoeZxYCDtkhEHwaJPPlhpLyixtL/bHAt31+0DwnWiElQmM4DIS4WQdyfrbmIFFY9NxOcpZBtHw3lmfkcQJZ2O+O3Yp1Irw/uKWneURNvORjcxAEChrjmpO4yJ7DZUChU+g0LbZ8uZboxddqmpc0P3SbGGzOoDlbML5JFso6pamLMWlV6VlxPAA4waQ9kJcGC4GoodLLJlV86rc89ISKgLXORRLG4aQws8eus6j27C2RfBVoesrZbxALIBOR2QJhzp7ct3slFBkHDRGuZXGxpzs55kquFKoT0FQk6iBzv2KdyVhCbzNATB8QPU2yiIcyfrVlbmZL8BVCa1ujzBzOorLdwRV+1zUMOqlxxiZDxX7czIZBMyxtMFbGKsyv456vNVs1MJbtBzukBXw463ADe7bM1iaPlCgO15MQQURxIKZx9nunCWcWeK0IcAAt2Niht77ELmef+LvW5LgAw2Nigsuusm6sW4C1/+zpX4+QkWZlWDjRJODiQYicrgU7n41kvcJcClsiUuAxRNqayVrw/iLPKgwlhoRJ712leoMREn56Tp8I2GR9qilO1KmQfi17e/Vr0UnAA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR03MB5669.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(99936003)(66446008)(82960400001)(64756008)(66946007)(8676002)(4326008)(66476007)(91956017)(38100700002)(66556008)(76116006)(5660300002)(2616005)(86362001)(4744005)(83380400001)(478600001)(53546011)(8936002)(186003)(6916009)(6486002)(6506007)(41300700001)(122000001)(316002)(6512007)(54906003)(71200400001)(33656002)(26005)(36756003)(2906002)(38070700005)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?eUlKMEFtOFZpYmJvajhMcFhlMW51azR0TjYyc2MyMW5tV1ZUaGtSNUVBaWNS?= =?utf-8?B?WlNSY3h4aEFHczIzaGJjMnd1a1lycnhBR0dkRERtRWIxV3BjUkVQNHhKeWJ2?= =?utf-8?B?Ti9XL2NOSE1Gd0J4VzA3U2IwbEQ3SnNLNzNzVkJEVkZCMUtwSmNrVzliUVI4?= =?utf-8?B?R2NwdEhZQXNLeUdmK1F3RXA5dFQxeVQ3ZW9BUm1SUG5ZK2ZiRGJuenpHMXh6?= =?utf-8?B?TWl5UWJXZERGUzFqZjZMTHJHaEkwNnkxRm52ekdXeGpOelp4RlgwNjJYajAy?= =?utf-8?B?djZJckhBczMzMW5LWmJqZ2R5TGJqaVFLZFE2Y1ZuYkJGLy9XVUNqOTEyem92?= =?utf-8?B?OVp2aGJKdllGL2tnM09ENWRFbHFhTHFtUGNjVVB1Q3hBNHFld1h4NVQzRVhj?= =?utf-8?B?amtiRUt2S2FqOU8yY0tXdnFuZ3hSNEswRXd3d3ZxR2pCUkhUMFhHRWw5TlJ5?= =?utf-8?B?MFdQZFpDOU5uYllmeEZTRUhuenkvM0xUVFVhY2VYM3g5V3hvOEhzdmhqV1k1?= =?utf-8?B?TSt4WXExbnZaNFlWRnBRRHFVTHppbE42QXhIWC9mdWdwUldldXlQd0hsTUVl?= =?utf-8?B?TWluTThWTXA1L2dIVXhSVUxBNDJWcU0zZkdqdjF6eExoS2NZVTJXZUdRMjNH?= =?utf-8?B?dzVrSlVacEtoejlVSUh0RHRrNWsyR3RXMGpuYVJLQnJnSWVWYm8vUlc0Y0dK?= =?utf-8?B?N3VMUi91QnBvZ1dHK3BIczlIbnZMOGtGeVpDTXlOSUZ3SVd2OFVVNmpWNDlX?= =?utf-8?B?TE1pVG55VisrMFVKckEvWDN1L0ZKTlRRQTcwREo5TDkyby85UHJUMVJxRFVD?= =?utf-8?B?L3VUaG4yVGVFLzRYUTBjeTZadEJSZ1pGREQ1a2xtb0gxVVB3K3JpMExDNWRt?= =?utf-8?B?d3ZiOU92MDN6cXh5eUJURzRncERsSXVseFdXc0hNYWRGYjdNd3JpZGpnVVl3?= =?utf-8?B?OGk3QW41eFh6bWNTa05OTFNCb0NKQ2ZreWRlNWlRUHV3cy9HZG1rMkhLeXY2?= =?utf-8?B?bU9nSXRrZ0QvM3hiU1AzTVZZamZuVE41aXdmbVFIRGlYYlNSSGJwK3hBZmc2?= =?utf-8?B?aW9MU3RZY3BqYXhFY2FnaUhuOXY3dlQwTFREME9vL1owdjA0TW9NZ25Tc2Rq?= =?utf-8?B?RTZ6YlNCVWsyUXdWNXpJMmtVdndZcFJZdkpwcDliREs5NHoxcW9HSDUxWVhG?= =?utf-8?B?ZDFjSUtnQXhrQzA0OFBMMy9xWGdoa1ovc3BJZzVUVS8ra3dybGNNdWJnSU14?= =?utf-8?B?WisxRnNYQzFVRExuUWFhS25UNkJka2lHSlZRNjhiS3dJeUVHbzBQU016NVJr?= =?utf-8?B?eEZMSWtJZ05KUEdURk5oalBHZUIvckN0ZG5QajR1alhJTUFWYUJGd3Y1UVU0?= =?utf-8?B?MVlZTW1pOXFaNHpyTExXT1JFa1dHcDFjZTh5Tm16NXRwRXF0WTEydnNZa0E3?= =?utf-8?B?RmgwdEw2UjJtVThZbDVhcDVkK3pOQVRYTmJzS2pkc3BJalRTRVZIUCtiY05z?= =?utf-8?B?U3pEVk5wd3B0Rjd1UHdqWFd3UWsxd2w0ZE1PVkt4ZFJlM2s1cTdubkVuQm5B?= =?utf-8?B?YXFnZk5vOElJZlM1V293ZkpCTE4vYmR6cFhwKzZQazRia1lES3ZQUkJGMzhx?= =?utf-8?B?Rm9ReFQxQXUzNUhPWm5KRWRCTHRleVFXSVVkd2RYV3dJSTJtbC9HUkdVOEN2?= =?utf-8?B?MXlldS9lZHZLOGhUYWNHVkZ4dFBmcU00ZWU2enhodUFBUTdhOHpvVDROcFdq?= =?utf-8?B?eTl2U04zZ3JtVmxNcFN4WmJkVGlQeE5rZW5NcEhMTktLcGY0Q051SjFuKzYr?= =?utf-8?B?cWVzNXZDbk5RZ21JOE5USGF3T0UzNlBsRlhqSzBFSGRLY2l4U0dWbXV0Uldk?= =?utf-8?B?UmJ4WUNKamJTbDM5ejY3RlhrVDFEbHRCc1hieTM4UEdPYjMraXFsL21Fb2Qy?= =?utf-8?B?OGJsbko2TGdKblZsOUZWNnFxVE5zWTRIR1NWaXpwbm4vTHFxRHc1ZkFaZjB1?= =?utf-8?B?ckVxeEFRTnAwWUI0cmtlbGh3cXBwZUFnMkxCakJsRHVaZUw2Z1paQkFCNG1V?= =?utf-8?B?WW9uTk5oZHhHSFlKRVRRbXR0L3A3N01yU2dkTkswOTF3RmF3Z1JHeFB3S2dR?= =?utf-8?B?YkhiRDZ1M0oxRTcrWjdlSlZCcWJHR0xMR1FrWTUxL1FScUExMUVad2I5ZXdU?= =?utf-8?B?QUE9PQ==?= Content-Type: multipart/signed; boundary="Apple-Mail=_D7E9DF75-3A62-47B4-BD8C-7471050F269F"; protocol="application/pgp-signature"; micalg=pgp-sha256 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR03MB5669.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a958d3b3-66c8-4db1-126a-08da6880496b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 05:42:22.3046 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FuK78f6Ezz/ZquCl3XZOVrU1/awLEX3ZZdYBQiRme/1Vvf/WNqk6cVnzfn+xhv9ouLeQtFeX3Aag2HiTwTmnpyGjp6M2iY0cO2RQarXolcw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5342 --Apple-Mail=_D7E9DF75-3A62-47B4-BD8C-7471050F269F Content-Type: multipart/alternative; boundary="Apple-Mail=_EF54E9BD-9A61-4C52-8172-F9FD5E7174E9" --Apple-Mail=_EF54E9BD-9A61-4C52-8172-F9FD5E7174E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 27 Jun 2022, at 16:33, Jan Beulich wrote: >=20 > On 24.06.2022 21:27, George Dunlap wrote: >>=20 >>=20 >>> On 9 Dec 2021, at 11:27, Jan Beulich wrote: >>>=20 >>> For guests in shadow mode the P2M table gets used only by software. = The >>> only place where it matters whether superpages in the P2M can be = dealt >>> with is sh_unshadow_for_p2m_change(). >>=20 >> It=E2=80=99s easy to verify that this patch is doing what it claims = to do; but whether it=E2=80=99s correct or not depends on the veracity = of this claim here. Rather than me having to duplicate whatever work you = did to come to this conclusion, can you briefly explain why it=E2=80=99s = true in a way that I can easily verify? >=20 > Would >=20 > "The table is never made accessible by hardware for address = translation, > and the only checks of _PAGE_PSE in P2M entries in shadow code are in > this function (all others are against guest page table entries)." >=20 > look sufficient to you? Sorry for the delay responding to this =E2=80=94 yes, I think this would = do, thanks. -George --Apple-Mail=_EF54E9BD-9A61-4C52-8172-F9FD5E7174E9 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On 27 Jun 2022, at 16:33, Jan Beulich <jbeulich@suse.com> = wrote:

On 24.06.2022 21:27, George Dunlap wrote:


On 9 Dec = 2021, at 11:27, Jan Beulich <jbeulich@suse.com> wrote:

For guests in shadow mode the P2M table gets used only by = software. The
only place where it matters whether = superpages in the P2M can be dealt
with is = sh_unshadow_for_p2m_change().

It=E2=80=99s easy to verify that this patch is doing what it = claims to do; but whether it=E2=80=99s correct or not depends on the = veracity of this claim here. Rather than me having to duplicate whatever = work you did to come to this conclusion, can you briefly explain why = it=E2=80=99s true in a way that I can easily verify?

Would

"The table is never made accessible by hardware for address = translation,
and the only checks of _PAGE_PSE in P2M entries in shadow = code are in
this function (all others are against guest page table = entries)."

look sufficient to you?

Sorry for = the delay responding to this =E2=80=94 yes, I think this would do, = thanks.

 -George

= --Apple-Mail=_EF54E9BD-9A61-4C52-8172-F9FD5E7174E9-- --Apple-Mail=_D7E9DF75-3A62-47B4-BD8C-7471050F269F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEj3+7SZ4EDefWZFyCshXHp8eEG+0FAmLU8r0ACgkQshXHp8eE G+0gYggAt1Btu4Ku76B5INynwH6SkDgzF73Qf8+MM04Ll5pe5FaqTtoMAR3FFl9X V1EjihrChWN1nq5Fr5P55AiixiP5DrZ9dhGNXpefBxiLfgXa7wQrL5WTHZRmuAgX M1ThGZjKuVXZ1A5vLQ8/Kx4HXoZfrMDcYDQWRiG7s4CdjW8IJFTfTVzlt6lSXaIo Hzozc40l53rmm/e0RQy69F6/vfCWPg1iLH7T2WnfFjbNWTv6BfO5YVFqIvO6mMnF /gn/vYiQLMOv+5VY3ave0od3ZMV0s5F5+YkhtAWO9Q67f+v5l+lvRgVeNzW0/h0U Qpy3GydZJh6HaqEpZ7J7YRTYMh/SWg== =bNt5 -----END PGP SIGNATURE----- --Apple-Mail=_D7E9DF75-3A62-47B4-BD8C-7471050F269F-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 06:08:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 06:08:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369250.600562 (Exim 4.92) (envelope-from ) id 1oDJvH-0004F6-Gq; Mon, 18 Jul 2022 06:08:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369250.600562; Mon, 18 Jul 2022 06:08:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJvH-0004Ez-CG; Mon, 18 Jul 2022 06:08:03 +0000 Received: by outflank-mailman (input) for mailman id 369250; Mon, 18 Jul 2022 06:08:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJvF-0004Et-TQ for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 06:08:02 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70057.outbound.protection.outlook.com [40.107.7.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9dad5dd-065f-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 08:08:00 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB8026.eurprd04.prod.outlook.com (2603:10a6:10:1ed::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Mon, 18 Jul 2022 06:07:56 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.021; Mon, 18 Jul 2022 06:07:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9dad5dd-065f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ETYOJfMeDxXpPQEfRSnLKM4quMgV14NEImj3h+j9Gbp3N+t+uiRmEHQscelc9vpREj0j+G4e2VLCut+qyaNi7BV53OcyJwJknnm58IA5H63NmZ732JF0zQTman9SEMeheZ5jGXfWJJcwCyw/h0p2Gn2tHokVVhBZOGeXsSPdf9O0Vh3UHLZR+BMV63BWn8xUyDOhxKhVK+awqOre0cFvmq16HIo8KbWzYwWGE3aFsQMOee/aBelwtsnc4pKHnUnNc+6EdvxtZRolUOjU44+HOleK68vSG8PeNeGaRL6A+K6WvHLj1yXuos32jr0zAnF0zItCxyOnUCRNsidl4hXczg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1IXuJHho9OSOXl7UV/zLebNmFWmzinEovfcnOoaOWdg=; b=E3rE0F3WSLSYgPteSKr1Xg4uEOw/Tp6UZ/Oi1Q0bTKs/NGyDj9XPKgx0r7Rth77WY6WxBTgnK1vSx9W+Y1xvSJUXXjFZUUnTkNfGKD40GlWTjVSl2ggiMkYhhE/TtbmDiQy8UpvOC/aFhi8gp08z7omG6PczezOpxHRTZu5QZrc+v+ps9LsrA1TYH+yaBBgoN7iCPbIgbGAFgqPoCnvK8NBav5ZuOUVDiXnBDLfvGl7ut8UXv/TB5rDBkXzV3fRHmwr/7Obb8Cn4LmWx6QHEMC0iiZ+dxV5Yy2q4m1t4wYOMbk77ccuRiV9GSM+KIHqxcujBc59vMnaGP02FCUOn5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1IXuJHho9OSOXl7UV/zLebNmFWmzinEovfcnOoaOWdg=; b=YXnzq6b7PQOkppzmoYhYAaxWI0o4IGdlFtLExcAfLKh3pBkyv4JC15JI/q7/GJ20SKI40uAHLAOazgkl0B9Fcmk4KTpf/05Uf0t7jWFKczFardOYca2o23FDH9zRMAUFI7wYcgo41yiWBpkKeL5d+7bWj8GKGuvK2f/TeWHisz/4qn+ZMlpbrwC2eU6jXY1IfVPf/9i7OM16pugfk8xvCCkj1Vmd3C7p/L1cdWVw73WeLN8wMWd5JDNTd9GsDM5tbJe4RKh3h9SuanYJqlyvJMas1JD335GkHljfQuNIE9sphd2XX9UrQUbva//0iJZQhBpNtOd08820AJU+eHC5cg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> Date: Mon, 18 Jul 2022 08:07:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> From: Jan Beulich In-Reply-To: <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8789e7cb-adcd-486e-ee7e-08da6883db80 X-MS-TrafficTypeDiagnostic: DBBPR04MB8026:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ib6hWwTUpm8/rvKtopY5kGkyrZa3GRJKV/R7txsEmtstaa/tlcu+HxkAM/GUCQf7Mb5PQ0qh0TDCyB9NVMGR04bCmszQE5NQCA8xMQCdZF2IqMtMqjSmdjy4Cxr75dzfCFX8dnFTjNx9J4NG5xWZyVqjzDHLos13OMwhduA3DrdAUhpWATGEsXXeD4OQKKnyR4ydMMjVKWPY9eT5jWnIeswgZ4zDUdIrRT4zPoLx36ho8vPokyXBajsIYcRcaYxApyHdBESM2934egBKIgXwGSCtiyIhsP00SgvAPk7JyJQ7YT3Km9IdF61Xo91aEXYlW04Dg3+d910a4Aew7g/jBJmBVDwcsutJlkdYRffSSv0x3pGKHci263xsvHXqRGIjVmxQdYW+SpBif09hDAhLyDKTfYug6vFqEtIeTnOPQk2GLFO2WQme13FzLjVu/vnyilZkIOD8QZSBQWrFPlnenYOa1kZC17yCcKpzZiTXpR2jimabcnCFC+bbhVFKwLCsUf2OhYJhZQ1vrlOSLcc7YQ5PJiSr1aNtZBghkpB+xwTcaFJRvrMXfJjGBjIkCu1Bb7RQ804NGd/HEjB+XmwLTqnsBRPO9jx9zaNnGgRqPTfXFPKKiF9tbYcBc+eS1XvRfWFtg6yHQpov1+j7/NbMPsMGRHOHOBWcGAsKRQHFY848FwNf7O0wKWZDRpTUXMR1P+jLu2j0Y8vxpwPZV4sYD6d7l7h32UaXu7FffcVgwy9NyjLtwfCk2GWp94y6+vPyh7p9kbjLHJX6r9oySroReTNwOA7OH5mtRF62myS9TH33rsSaZ52Be//Z7+FSBj4u+XPviv/nAcF98U4hZGzG0YiZer3CSJ7EcCQLkB/l+iU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(376002)(39850400004)(396003)(136003)(6486002)(6916009)(4744005)(2906002)(41300700001)(83380400001)(8936002)(7416002)(66556008)(5660300002)(86362001)(2616005)(31696002)(54906003)(478600001)(53546011)(38100700002)(6506007)(31686004)(36756003)(6512007)(26005)(316002)(8676002)(4326008)(66946007)(186003)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d2tkN3d1d0JGNkM0YUp3RlhReDM0cFpMQjVCZXNaYWlESUwxdkZCeXZhU1Zv?= =?utf-8?B?NWpkK0pqQ0V6bmExRnFHSCttQUxzS1dGbE1uc215RzJ4ZFoyMUU2RmZkM3RK?= =?utf-8?B?MytKbXYvQXhGdmxCMUZjcVRLSGhCZlhLU0R5N21RSzhKQUVtMHVyRE85dThk?= =?utf-8?B?dWQ4azU2N3BscXZoYndVem9QMmtLR29GUmlzcGs5eC91M21GU1ZtTWx5VzRs?= =?utf-8?B?Q3pPNkUwenJFQzNHZXE3V2k5blB2Rm50YUs4Sys1N0xhdUJFTFEyYlV6em5Q?= =?utf-8?B?cU9FYmlYWHMzTitGRkpNdnhLZFYzZXdPdm1oRks0Q0R1ZDAvYlVYbzhXTm1Y?= =?utf-8?B?d2VJREp5eFc0WVEwU1AxV2FDMU9tSGxSZG5hdVNOMTZSbEtYVGtxdlQwMXJ4?= =?utf-8?B?QXh1OWx4Vm9pM1pHQmEzb2hTVmlIODMwWlR4UW15S1I3SVpNRE9jZEJGQkFZ?= =?utf-8?B?VWxQcmJCWlZ5cDlCdHlDSXgzM0FjQWJUbkY5ZE1VY1BuQjhlKzNKNmtsSUda?= =?utf-8?B?QWdwRVFQOSt1K1d1VzhBMXdpYmMvMGZFa045UE1QNkFvNzFBTXJBcXk0Qll5?= =?utf-8?B?SlVtVnhZL2R4K1NiM3p2RHN6d0FhbVZsVkloUjc2d2x6R0xuMTAvaUxManZ5?= =?utf-8?B?Zml0S3FZNkg1WVd4TTBDYUpJazhoSUlWTWRPRm9lU1pTS01zNHMyaHQvRDU5?= =?utf-8?B?bnNLWmd4MFJTK1Q0MUhxMnVpOCsra3RJZnN5VUY0Z0RIUm9wcUdxbGZsQjhW?= =?utf-8?B?b2lCK0pSNGh2dlJ1VlB4Sjh5eXJTNlU4SEhLRkpLTy9MMGRoTXNoTitvdEsv?= =?utf-8?B?WWMwWkVjcm9CVEg3MGRSOEZ6OENuYk5MWmJENzBtWUJ3aXNya1lVMERsVklR?= =?utf-8?B?d203enVWeVNPSjJBMnJhenNRQTdOc2pkTjd4RWdZckZKL0xySVhoUHhSWk1n?= =?utf-8?B?VEFUbzlzVCsreGdDbmdDQkcrcHo4Ym1CT2NHaHErVmtPM0VlWlZBZ3VsOHBL?= =?utf-8?B?V1BNOEsyWjJ3SjJSY2NiMGgrL2JJWUFVVmxaV3FSeWNNbFhUd0tzNWxZMWNL?= =?utf-8?B?cnkxTDdWdHExdmZyNW1xR09Tc2EvZi84cTM4bVJTRUwyTTZhLzhWVk9xNWd2?= =?utf-8?B?NUs1bmdDL2FCWHM1WmZyV0VsU1dXZUlua3hLbCtZRnV0MXA5cHhNR04zZFVm?= =?utf-8?B?TE14Z29ab2E1c1FLdjhRalYzQk1mS0k5eCttT2FzUHVtNmZXeWtrMkFyOWsv?= =?utf-8?B?TVhHUkFPazMraXd0Z3NoUVhmT3hsSGZqdUEvd0l1R2pKTTh1Tlk5QWhiZ0Zk?= =?utf-8?B?QmFtY2I2V2RZOWhaN2pYSFB6Mis1Yld1ZEhpNXhva2tsdHV0ckZaQ2VJdm1K?= =?utf-8?B?ZS9WTnQvbVkwa1EzQ2dEcTdtSUF5amQvV3YvL283UXA2b2tPYlZJaTVpUFcv?= =?utf-8?B?Q0RORm4vODBKVHpHTDIxREVGOFE4SnZPdlBnU3p0NzlwQVE0OTVBWjdrVTdi?= =?utf-8?B?UmtkQ0VGZXNHM0ZuQWJvb0RXOEpHYnBBbHg4VE80ZCtJdTVrTG50djhSLzJh?= =?utf-8?B?R3pldzhuS3J4U2JTWVJINzQ0MXI1UnMza0ZHa3d3ZWFyc3RLYis2TEx5Y2hv?= =?utf-8?B?SG1JV0tPSytZRnpQT2hydUxmQ1ZEMWdwYTZKa3lQbE9mblJuRC9TakdqSlho?= =?utf-8?B?UVludmFmRWo3UWYxbWFVWHFiU09IMGtaRjd0Tzg5K0tiQS9TMDliSHB4RDlm?= =?utf-8?B?cXUwN0hpN2hWVU5xa3lZRFZzMVF0TEFsT1k1RE9pdlF6WjIzbEg4dkZjRVNF?= =?utf-8?B?ektlK3l6d084QVVFWDc1cjJWUzQ4d00va3FzVWFoVm5iQVpyU2NQSnpBMEJr?= =?utf-8?B?RmdaSDBrVlBvS3pFY2Y2TFhMaDNlTzVNUmsyUkQ0ME5iSkZDSld1ZFVoWUN6?= =?utf-8?B?L2FjT3NkaU9ISTcwc1lETHJSUmcxUTFOQklyL1M1OWJ4N3ZCRVl3elpmQkMz?= =?utf-8?B?Yzhya2lOdndpTzRVSzZzNVpzcFlsSzhJbXdsMEE2R0hsbjBuRk1zZFhJUVRY?= =?utf-8?B?OUN2VnIwcGs0RUtKb0pPZUxlY2V6eWhqd28zM3Y2UFVNK2p4RTJTUEFQRnI0?= =?utf-8?Q?xANokraIXdPXr3Re9SC36O35v?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8789e7cb-adcd-486e-ee7e-08da6883db80 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 06:07:56.0885 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SfWz5ydNitlLQuAlzLNOK2GMnbdeziDfGDNQS5pRtK23635iJbDj/oVy06/IJuWwOkIHZDQ92ALvOOlmvWwXoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB8026 On 15.07.2022 21:53, Chuck Zmudzinski wrote: > Two things I see here in my efforts to get a patch to fix this regression: > > 1. Does Xen have plans to give Linux running in Dom0 write-access to the > PAT MSR? No, as this is not technically feasible (all physical CPUs should run with the same value in the MSR, or else other issues arise). > 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I don't think there are plans on the Xen side to support the MSR interface (and hence to expose the CPUID bit), and iirc there are no plans on the Linux side to use the MTRR interface. This also wouldn't really make sense anymore now that it has become quite clear that Linux wants to have PAT working without depending on MTRR. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 06:09:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 06:09:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369255.600573 (Exim 4.92) (envelope-from ) id 1oDJwd-0004qq-Q3; Mon, 18 Jul 2022 06:09:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369255.600573; Mon, 18 Jul 2022 06:09:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJwd-0004qj-NG; Mon, 18 Jul 2022 06:09:27 +0000 Received: by outflank-mailman (input) for mailman id 369255; Mon, 18 Jul 2022 06:09:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDJwc-0004qZ-SZ for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 06:09:27 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2055.outbound.protection.outlook.com [40.107.20.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2bfbf3cd-0660-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 08:09:24 +0200 (CEST) Received: from AM5PR0301CA0001.eurprd03.prod.outlook.com (2603:10a6:206:14::14) by VE1PR08MB4671.eurprd08.prod.outlook.com (2603:10a6:802:ad::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 06:09:20 +0000 Received: from AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:14:cafe::58) by AM5PR0301CA0001.outlook.office365.com (2603:10a6:206:14::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Mon, 18 Jul 2022 06:09:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT043.mail.protection.outlook.com (10.152.17.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 06:09:18 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Mon, 18 Jul 2022 06:09:18 +0000 Received: from bbd765527ea1.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DB02A38C-9D95-4629-967D-C853B9E2DF18.1; Mon, 18 Jul 2022 06:09:08 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bbd765527ea1.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 06:09:08 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by AM6PR08MB3496.eurprd08.prod.outlook.com (2603:10a6:20b:4e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 06:09:06 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 06:09:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bfbf3cd-0660-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=EAO4+/EjOMJCta00dWFrfMTr2C820Ika2ffMzmN8dsKo9LKfbQrg2ijU/OUczpgfGKMWCoV4rniJB8eMZrTImJkJiZwdYcyOPx0t6yBUngLL8p48cs7/7FpQwdIcxEJEbE5qwCYCWRloYBnHNLX5oBK/t6yCvabnhH/SGRQHHyYFXnKpbArVAWAnIPqJ8BsMGD1lJ193jyIQK0PTiiBuC0HWpPgDnRyzhfxCDr71dUZwcWtXErpasr3TctcJl5kZIHHswQcqnhvMEPkr2u3F0gVwEDvQ8GZ6y86Ea8G32+ky6dgb8eW84YYarBavFfJA/Wbg2RgaQP1RzqTqDKwurA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ECWi0u5Qd/LatKWNWwU26XIJrdW3oc6HoJjq49c6keA=; b=Wx0pqrB0oy7fJmuVx1/9oHHTl4xXMoAUpny6zs+ZdUCa2SbaZJflrRIiMayEzMzxY31zsuclUmeqOdAXy9iGAJrw+LzV2k1565DaTIKdXAE7W60Ve7A2afscx3vappE756wJk7j3HrJQf1fEaptMxqSU9yOmyUtc+0be6LqpbCpF50cNv8hkogpffVPSwRl+lKT4BG+C4mDcV/vIHvNpqMCDe7JDCczDHVCRocRPhODQlJr83kHAkV7Dq9wuf27lGsm7XOSk2uL3i3MlWRfBJUi9pgACzBoqoEK+I43xzlFUeKlL6w2pvlWCazk6NAeKat698Jq0Nska4Tx93fG8Bg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ECWi0u5Qd/LatKWNWwU26XIJrdW3oc6HoJjq49c6keA=; b=sKcbej+MNa2z/6NbCAKGkgC/99U01XtOZdRUH7Kx8uBxi6p7dZIcNqxHZw/RNIPdQjcqo1Yeivwm+Un05VBQ7qotOXg9ObDhtP4Yz0Cunb0xtiqx3NY/ZcRYejcw04+a0ESYzjn+HCZa0J5qBZTWx0WEXWdencqi9JcX54Yar/o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EI+WFRQ1AXbMkccqP9gP/wu4W5QSE+1cZLyhH+0iAzRHvOf/oYyX8S3wUr1dCuzv4MdjTzBT9pU0HTg6Kkonq2bz0+OOGFmTxAOjX0WrrcI03SPM1cy7NvUP8QFmauIAXMyXWeXnp55B0/46rYcLAylLIqsXlEhuocafgjVLVRbNKMXwqEHR47d/9M02g1CgQ2dBgnPYJDIsPnQ6ZaCaMSislkJgq2fcglWarEDJzPeyJ4s4MN6PzjswwR5m8SshxE3M5pM/L7EeQ8J6grJp8SQjilAcRo/+3FKug/URsQ8AxZPUrPQbcNL5mmFFy7IEXWK90nTttmnzobNTblWpXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ECWi0u5Qd/LatKWNWwU26XIJrdW3oc6HoJjq49c6keA=; b=WdDpGBKHSHbl2XX7Wc2iOUbyZXdG/GBEALbLTRBQV6jAvJZVcnf1NJPewDklxWnlFNV6x1LTMOAdQlr7VABC/0wzToxDrDBPxSe8SZNQIReDT4A2RTJl8yJq9q3MCmxhjAnleL2GZe8rhTmXFQvvbOfAb/L0fDHBohIDnNrJYxFxqTc17Wu+taJsFUbGn0l6l6dYLME5FWu667+VyWdkBT1eopbZvbceHr7ThP5ESa1ipKPNXGhxATqG2IbjlXIDK47KRdlRXwxkEV8I+1fvMqRVWqDnr8p35p3LkoH79BiRVNMFdMsCBUJ9NJNOfPRAOSDCjBCeh+NsoCBFhcl3rQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ECWi0u5Qd/LatKWNWwU26XIJrdW3oc6HoJjq49c6keA=; b=sKcbej+MNa2z/6NbCAKGkgC/99U01XtOZdRUH7Kx8uBxi6p7dZIcNqxHZw/RNIPdQjcqo1Yeivwm+Un05VBQ7qotOXg9ObDhtP4Yz0Cunb0xtiqx3NY/ZcRYejcw04+a0ESYzjn+HCZa0J5qBZTWx0WEXWdencqi9JcX54Yar/o= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 2/9] xen: do not free reserved memory into heap Thread-Topic: [PATCH v8 2/9] xen: do not free reserved memory into heap Thread-Index: AQHYkeMzaseZ5YPTu0ykk9py2DMCTK10bf4AgA88QbA= Date: Mon, 18 Jul 2022 06:09:06 +0000 Message-ID: References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-3-Penny.Zheng@arm.com> <670588e9-48aa-779c-ec5e-88d6b9d12a76@suse.com> In-Reply-To: <670588e9-48aa-779c-ec5e-88d6b9d12a76@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 3E3E7605B7C7E84493DE4AC0BDD5522E.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5d6bde5a-beee-4f93-ba08-08da68840ce8 x-ms-traffictypediagnostic: AM6PR08MB3496:EE_|AM5EUR03FT043:EE_|VE1PR08MB4671:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WnYzdTejtlzf9kplBmGed4zTxrMWUKIjUcVrWbyktcnAoVzZCWXxTvf5MFBhyTtsmnbtLNianIdGVVmx9f6QwUMnl0pVz+/MYlurlDEojJDw6PxuEdnd4E1I0xmlnGtU8QMFgRgkKiPJ2j0F7/SaYeXVyigwaZQCyZrSTXkDUTVXS7Mw+DcYL2rAkqKAcfLVNEI1ygbuWmFV7r72SJoAmDs+NSfrKrKLMG5Cloka8RylNJf+U3lX4JIyzczUf/ybiqCBZ4hIYZ2LDqpDtRnE2yTxjMi4Tmd3VEI893QdvyqqSPH/hREvGL1DeNWHsOcryTGGLw62odKpv7ET/s92rFs75QPj9jFAlLet3gGcB90xZ9/hxPfHHciq6bdk/Q6TnHTTN0VZim7kcaL/ep9H7cNQxYQz5IffXUpFOUwFD6FX2yLvuvjUzwmu523nO8mZnHulMAbB0fM6CqZxrrsKWrSZtvBaesP5ac0NbldImIwP4IEyzLGQcqoacriyVyQxasi2It2s4o6aS+wfN6HqLSrb95547p0YcoSO2f4GC8Y4WViE9Q660lykKGukjpLz7flSMXJvSUsst8dAxfwmezDH41bW1gekE0ecFBnCScbSS+k7I5SKpnJteEtHDNlCZxJPPW+DAOIwbFlO8Z6xxljNNTF9LDSQJ5bh5bDeriY4bFTnujc1id2A6ZgtI1T7SXecV/HIKC6fhaqZcTYF+SAjtT5F7Px05imTtPxVGnJW1nvWTGV+6+wLztLepm8UfzU+oIurYf8i5WK4HF/5ImEef8MNtRQJXJ1db/bj/NJmZS9GFMGgzr7Eojd/puIH X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(396003)(376002)(39860400002)(346002)(6916009)(316002)(122000001)(38070700005)(38100700002)(66556008)(66946007)(76116006)(4326008)(54906003)(8676002)(64756008)(66446008)(66476007)(71200400001)(55016003)(26005)(33656002)(2906002)(41300700001)(186003)(9686003)(83380400001)(52536014)(5660300002)(8936002)(53546011)(86362001)(7696005)(6506007)(478600001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3496 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5a268509-8d34-45e4-06b0-08da68840568 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B/wg5y+tgvYUZyX6nie8eb/hat3epZIqoAc/ryosyYNl87dXUGbMAsdy8tls+pvYQimJaey3XNomx4Wrax8CVxgjG7+t6Z/IcOcLsN+OdKpjZFFK/HjEl55cFdDMKRBKBjyPIT9nRFN0noXWKzmhtdQhYjoHlcgfKCwClleZ5+AcVJ1vI4K99fY+24Da8mrPuZn3hTiUW5Z8wgS83sYscvrRgpk4oFIB9vYO/kndWtlu6d2s+hpcxd7GmGf5qx0KSCOtRfJaEOg28JS0BWYxc44ebjp94Oqpp94934/j3N47exWwERbBqR3A+CkT5zneYaZ494lbEm9HEElxw0yIbG6FZh40OcBmtbvnq0yn8EpcGf9uOzg9o8C+D27oNdparwHdCo2LSU5009KCxYSGYA53I33sPsg8RIvpeCIeLrDcKyhiaEmFrlcKpCe269hvJmViahUptsQjvenc2PQ1SosMZ4yTFDHnwlqb2y3H0hW9WdgSebAUb1LBVGq+KOmvIHN6b9zWHKYXCyegDo202gmwAoQSIMFyHbe41cnDMkibnzuDn7ONv6rlsel1Va6moO8MZaSzl557jrJ++9EacHLNTbluek4VtWsxg2Bd3Yw4RjaUiA+LEdPn4MrWmhetPElqw+2wa5Kw8uk0SIthC4dMzhaOi+SCQXIaEmgeFCOq+XNHQyCOUIpgr6oR0N/z9AL9gAxumfiqeZGpQIrTa8VFP8FeHENEZO33hMLu4+6YgbLs83axtVqkT//DHgbtEeuI9sD8+LHu6cFec9iI7bpb+MdNyLjnVwYcPvuJGw0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39850400004)(136003)(396003)(376002)(36840700001)(46966006)(36860700001)(47076005)(336012)(55016003)(40480700001)(83380400001)(81166007)(186003)(54906003)(70206006)(70586007)(316002)(8676002)(478600001)(41300700001)(6506007)(7696005)(2906002)(6862004)(53546011)(8936002)(5660300002)(9686003)(86362001)(52536014)(356005)(82310400005)(82740400003)(26005)(33656002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 06:09:18.7115 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5d6bde5a-beee-4f93-ba08-08da68840ce8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4671 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBGcmlkYXksIEp1bHkgOCwgMjAyMiA4OjQ4 IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdlaSBD aGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgU3RlZmFubyBTdGFiZWxsaW5pDQo+IDxzc3RhYmVsbGlu aUBrZXJuZWwub3JnPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IEJlcnRyYW5kIE1h cnF1aXMNCj4gPEJlcnRyYW5kLk1hcnF1aXNAYXJtLmNvbT47IFZvbG9keW15ciBCYWJjaHVrDQo+ IDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT47IEFuZHJldyBDb29wZXINCj4gPGFuZHJldy5j b29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UgRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5j b20+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qu b3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjggMi85XSB4ZW46IGRvIG5vdCBmcmVlIHJlc2Vy dmVkIG1lbW9yeSBpbnRvIGhlYXANCj4gDQo+IE9uIDA3LjA3LjIwMjIgMTE6MjIsIFBlbm55IFpo ZW5nIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9hcmNoL2FybS9tbS5jDQo+ID4gKysrIGIveGVuL2Fy Y2gvYXJtL21tLmMNCj4gPiBAQCAtMTYyMiw2ICsxNjIyLDggQEAgdm9pZCBwdXRfcGFnZShzdHJ1 Y3QgcGFnZV9pbmZvICpwYWdlKQ0KPiA+DQo+ID4gICAgICBpZiAoIHVubGlrZWx5KChueCAmIFBH Q19jb3VudF9tYXNrKSA9PSAwKSApDQo+ID4gICAgICB7DQo+ID4gKyAgICAgICAgaWYgKCB1bmxp a2VseShueCAmIFBHQ19zdGF0aWMpICkNCj4gPiArICAgICAgICAgICAgZnJlZV9kb21zdGF0aWNf cGFnZShwYWdlKTsNCj4gPiAgICAgICAgICBmcmVlX2RvbWhlYXBfcGFnZShwYWdlKTsNCj4gDQo+ IERpZG4ndCB5b3UgaGF2ZSAiZWxzZSIgdGhlcmUgaW4gdGhlIHByb3Bvc2FsIHlvdSBtYWRlIHdo aWxlIGRpc2N1c3Npbmcgdjc/DQo+IFlvdSBhbHNvIGRvbid0IGFsdGVyIGZyZWVfZG9taGVhcF9w YWdlKCkgdG8gc2tpcCBzdGF0aWMgcGFnZXMuDQo+IA0KDQpZZXMsICJlbHNlIiBpcyBuZWVkZWQN Cg0KPiA+IEBAIC0yNjUyLDkgKzI2NTAsNDggQEAgdm9pZCBfX2luaXQgZnJlZV9zdGF0aWNtZW1f cGFnZXMoc3RydWN0DQo+IHBhZ2VfaW5mbyAqcGcsIHVuc2lnbmVkIGxvbmcgbnJfbWZucywNCj4g PiAgICAgICAgICAgICAgc2NydWJfb25lX3BhZ2UocGcpOw0KPiA+ICAgICAgICAgIH0NCj4gPg0K PiA+IC0gICAgICAgIC8qIEluIGNhc2UgaW5pdGlhbGl6aW5nIHBhZ2Ugb2Ygc3RhdGljIG1lbW9y eSwgbWFyayBpdCBQR0Nfc3RhdGljLiAqLw0KPiA+ICAgICAgICAgIHBnW2ldLmNvdW50X2luZm8g fD0gUEdDX3N0YXRpYzsNCj4gPiAgICAgIH0NCj4gPiArDQo+ID4gKyAgICBzcGluX3VubG9jaygm aGVhcF9sb2NrKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArdm9pZCBmcmVlX2RvbXN0YXRpY19wYWdl KHN0cnVjdCBwYWdlX2luZm8gKnBhZ2UpIHsNCj4gPiArICAgIHN0cnVjdCBkb21haW4gKmQgPSBw YWdlX2dldF9vd25lcihwYWdlKTsNCj4gPiArICAgIGJvb2wgZHJvcF9kb21fcmVmLCBuZWVkX3Nj cnViOw0KPiA+ICsNCj4gPiArICAgIEFTU0VSVF9BTExPQ19DT05URVhUKCk7DQo+ID4gKw0KPiA+ ICsgICAgaWYgKCBsaWtlbHkoZCkgKQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIC8qIE5CLiBN YXkgcmVjdXJzaXZlbHkgbG9jayBmcm9tIHJlbGlucXVpc2hfbWVtb3J5KCkuICovDQo+ID4gKyAg ICAgICAgc3Bpbl9sb2NrX3JlY3Vyc2l2ZSgmZC0+cGFnZV9hbGxvY19sb2NrKTsNCj4gPiArDQo+ ID4gKyAgICAgICAgYXJjaF9mcmVlX2hlYXBfcGFnZShkLCBwYWdlKTsNCj4gPiArDQo+ID4gKyAg ICAgICAgLyoNCj4gPiArICAgICAgICAgKiBOb3JtYWxseSB3ZSBleHBlY3QgYSBkb21haW4gdG8g Y2xlYXIgcGFnZXMgYmVmb3JlIGZyZWVpbmcgdGhlbSwNCj4gPiArICAgICAgICAgKiBpZiBpdCBj YXJlcyBhYm91dCB0aGUgc2VjcmVjeSBvZiB0aGVpciBjb250ZW50cy4gSG93ZXZlciwgYWZ0ZXIN Cj4gPiArICAgICAgICAgKiBhIGRvbWFpbiBoYXMgZGllZCB3ZSBhc3N1bWUgcmVzcG9uc2liaWxp dHkgZm9yIGVyYXN1cmUuIFdlIGRvDQo+ID4gKyAgICAgICAgICogc2NydWIgcmVnYXJkbGVzcyBp ZiBvcHRpb24gc2NydWJfZG9taGVhcCBpcyBzZXQuDQo+ID4gKyAgICAgICAgICovDQo+ID4gKyAg ICAgICAgbmVlZF9zY3J1YiA9IGQtPmlzX2R5aW5nIHx8IHNjcnViX2RlYnVnIHx8IG9wdF9zY3J1 Yl9kb21oZWFwOw0KPiANCj4gTWF5IEkgc3VnZ2VzdCB0aGF0IGluc3RlYWQgb2YgY29weWluZyB0 aGUgY29tbWVudCB5b3Ugc2ltcGx5IGFkZCBvbmUgaGVyZQ0KPiByZWZlcnJpbmcgdG8gdGhlIG90 aGVyIG9uZT8gT3RvaCBJJ20gbm90IHN1cmUgYWJvdXQgdGhlICJkeWluZyIgY2FzZTogV2hhdA0K PiBoYXBwZW5zIHRvIGEgZG9tYWluJ3Mgc3RhdGljIHBhZ2VzIGFmdGVyIGl0cyBkZWF0aD8gSXNu J3QgaXQgdGhhdCB0aGV5IGNhbm5vdA0KPiBiZSByZS11c2VkPyBJZiBzbywgc2NydWJiaW5nIGlz IHBvaW50bGVzcy4gQW5kIHdoZXRoZXIgdGhlIG90aGVyIHJlYXNvbnMgdG8NCj4gc2NydWIgYWN0 dWFsbHkgYXBwbHkgdG8gc3RhdGljIHBhZ2VzIGFsc28gaXNuJ3QgcXVpdGUgY2xlYXIgdG8gbWUu DQo+IA0KDQpZZXMsIEp1bGllbiBhbHNvIHJhaXNlZCB0aGUgc2FtZSBxdWVzdGlvbiBvbmNlIGJl Zm9yZSB3aGlsZSB3ZSBoYXZlIGJlZW4gZGlzY3Vzc2luZw0KYWJvdXQgaG93IHRvIG1ha2UgdGhl IHNjcnViYmluZyBzdGF0aWMgcGFnZXMgYXN5bmNocm9ub3VzbHkuDQoNClJpZ2h0IG5vdywgc3Rh dGljIG1lbW9yeSBpcyBlaXRoZXIgcmVzZXJ2ZWQgYXMgZ3Vlc3QgbWVtb3J5IG9yIGFzIHNoYXJl ZCBtZW1vcnksDQp3aGljaCBib3RoIGNhbm5vdCBiZSByZS11c2VkLCBzbyBhcyB5b3Ugc2FpZCwg c2NydWJiaW5nIGlzIHBvaW50bGVzcyBhdCB0aGUgbW9tZW50Lg0KDQpTbyBoZXJlIEknbGwgb25s eSBrZWVwIHRoZSBzY3J1Yl9kZWJ1ZyBvcHRpb24sIGFzIHN5bmNocm9ub3VzbHkgc2NydWJiaW5n IGlzIGFscmVhZHkgaW4NCmZyZWVfc3RhdGljbWVtX3BhZ2VzLg0KDQo+ID4gKyAgICAgICAgZHJv cF9kb21fcmVmID0gIWRvbWFpbl9hZGp1c3RfdG90X3BhZ2VzKGQsIC0xKTsNCj4gPiArDQo+ID4g KyAgICAgICAgc3Bpbl91bmxvY2tfcmVjdXJzaXZlKCZkLT5wYWdlX2FsbG9jX2xvY2spOw0KPiA+ ICsgICAgfQ0KPiA+ICsgICAgZWxzZQ0KPiA+ICsgICAgew0KPiA+ICsgICAgICAgIGRyb3BfZG9t X3JlZiA9IGZhbHNlOw0KPiA+ICsgICAgICAgIG5lZWRfc2NydWIgPSB0cnVlOw0KPiA+ICsgICAg fQ0KPiANCj4gV2h5IHRoaXMgImVsc2UiPyBJIGNhbid0IHNlZSBhbnkgd2F5IHVub3duZWQgcGFn ZWQgd291bGQgbWFrZSBpdCBoZXJlLg0KPiBJbnN0ZWFkIHlvdSBjb3VsZCBlLmcuIGhhdmUgYW5v dGhlciBBU1NFUlQoKSBhdCB0aGUgdG9wIG9mIHRoZSBmdW5jdGlvbi4NCj4gDQoNClRydWUsIHRy dWUuIEFTU0VSVChkKSB3aWxsIGJlIGFkZGVkDQoNCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 06:55:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 06:55:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369265.600584 (Exim 4.92) (envelope-from ) id 1oDKfN-00025j-8K; Mon, 18 Jul 2022 06:55:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369265.600584; Mon, 18 Jul 2022 06:55:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDKfN-00025c-5N; Mon, 18 Jul 2022 06:55:41 +0000 Received: by outflank-mailman (input) for mailman id 369265; Mon, 18 Jul 2022 06:55:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDKfL-00025W-RI for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 06:55:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2087.outbound.protection.outlook.com [40.107.20.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a14f89f7-0666-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 08:55:38 +0200 (CEST) Received: from AM6PR0202CA0055.eurprd02.prod.outlook.com (2603:10a6:20b:3a::32) by VE1PR08MB4703.eurprd08.prod.outlook.com (2603:10a6:802:b1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 06:55:34 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:3a:cafe::36) by AM6PR0202CA0055.outlook.office365.com (2603:10a6:20b:3a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Mon, 18 Jul 2022 06:55:34 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 06:55:33 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Mon, 18 Jul 2022 06:55:33 +0000 Received: from 7ee5ca051378.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 8CDB0368-7D53-41C0-9BC0-EB56FB4B988F.1; Mon, 18 Jul 2022 06:55:23 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7ee5ca051378.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 06:55:23 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR08MB4032.eurprd08.prod.outlook.com (2603:10a6:803:e2::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 06:55:15 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 06:55:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a14f89f7-0666-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hywb9ODP8k3Wy/wWyZV6lsDjAeiCjUEQiO6GsjySDWvK4h3HgGI3j12ag8WUu4AYwZJa/yFQs7ETVoJ2INPvzgN1mlAxTUuWiHyNKgfy6qd4tCBbjhvMKzqSB1NUA1O6+ElBJHufbJmlTSmrMM79HxIdIHcpLdaMFGF+ITvutmeDnxrcWHZzgfjo4KMnT2jyko8zPbAlaqVqRBy29NU9rJLw+D9SIHGIkWxIQ9+jby2hVGA2MnK/LHLluW+72uDcyFIfV505fesC8nn6qib5U3CFmErOByQ1AIlirdou3LzXU+bOEuHKu07NbEgKWT/awTgMvsf0d44QvXfkowaoog== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c29vz3kTNv/RXNVhzO6kc8mAWheac5OoKcFAF1JWE4g=; b=GzlPZ/Df4CZ4074BpDFHwLInKvbDus2505VBvj5t1u63+SF0fTzH/2STpTrY5UblqVSutu/QwroSofEX4RM371TXN/fYft31Q9LNR+kQPJzkYSnSkID8mY/KK6swUTkNzFShAFpCi4JGFyyGHpsWGVbiWuHm0OYEF6kK/GZjJChK6l02+uTsKEzsGIwBZmTN2clnd6zH7h6m9gV/M1bDNn5Vlbf3qkqfioVQzjPg+saDHWpHca2i+TH35U4vzlMpoZJIrBJZ60mOmP3ubejDr2z815jyvnhPFiweS3VdLFjOLBHan9y3+uDngop3eGmcrJsIyov6VQFOqrmNxArn0g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c29vz3kTNv/RXNVhzO6kc8mAWheac5OoKcFAF1JWE4g=; b=zXEx6RftfuNzpjYO8w2ruzmNlw+/4VrN3E9GeHk3EqjcmO3fkOLNVyT7Or/AEbWLfmnUDswAn9ipQz3kdYETlv2D7Y0mILvZbia5bwmxXEH2mY+5ffD3lZQ/negS2WFhIUSZ648ZZ+gqyP68qZ0LNibHf3JBC6yhQdkaCSAtWws= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nyeF6tzaU65xy4rDjhweaZGgsPn2mus1A9DragFmecYzVlYV0AmDCpR5ZwOgEk9kBn/e/BHJ5mRYN2wQoSdxdxDVwIiUTC6V/6FVW1xn7OsOOPGfriChOzdD/Qkr3C8bh07WsaaMKbt1OXhTiVdWP0UDRscUhKtGReYoI6k7U5XeNpxg9xsti/RdM8RAowP8pDUhf5Byye46FImKrqfY5Run/GJBEt/3DPO//lypwJgGlANBnQ4suQAEXeSUEez+wtLwVqFoYBDbm7qZgQagZmoK1CA21mFrhEDy1NjLUhguSNS0iRP3ED8HLYgSErzM6sVV6hirr4P/6ukUIsJ2ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c29vz3kTNv/RXNVhzO6kc8mAWheac5OoKcFAF1JWE4g=; b=VN5shFLLgyCmZZJ480sIM2xxSwcOgPz9O60MjpqLmKO2mVS+1t0V7QAx5ZCWW0SGtB/StG2dMVRKgGewgouA8s7vief0ttQViJjHJUkDfCb4wKH6iyX6jN1/dmZp6La9Vv0kOjS0eG8hA6CS7KtLqEC/HJvSTgg9QMENpU7jiWWKizHJ1y1zPQWLc7Mzo2XykP7mMBlHeN1LaNVHvqqBc+8WXVC+/k+721mt0zTmicKJ72wfbvRrUPHioEdEGb2OgPlrx9HyQ9lXCwBdHC/AvKnCk+D/BXYm2hVKnwPvoIE5+pkbUaYbqO5EYjaY8ApOXyWlDAND4C928ynIFjI4UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c29vz3kTNv/RXNVhzO6kc8mAWheac5OoKcFAF1JWE4g=; b=zXEx6RftfuNzpjYO8w2ruzmNlw+/4VrN3E9GeHk3EqjcmO3fkOLNVyT7Or/AEbWLfmnUDswAn9ipQz3kdYETlv2D7Y0mILvZbia5bwmxXEH2mY+5ffD3lZQ/negS2WFhIUSZ648ZZ+gqyP68qZ0LNibHf3JBC6yhQdkaCSAtWws= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v8 9/9] xen: retrieve reserved pages on populate_physmap Thread-Topic: [PATCH v8 9/9] xen: retrieve reserved pages on populate_physmap Thread-Index: AQHYkeNFlB68JC6RfEmkKZyT8Sz16q10c0gAgA9MCTA= Date: Mon, 18 Jul 2022 06:55:15 +0000 Message-ID: References: <20220707092244.485936-1-Penny.Zheng@arm.com> <20220707092244.485936-10-Penny.Zheng@arm.com> <9697f641-d660-a346-3baf-18bc8ffab717@suse.com> In-Reply-To: <9697f641-d660-a346-3baf-18bc8ffab717@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: A11586945C03FD42B27CA98E068C1C7C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e6edcf61-e403-4eba-f093-08da688a830c x-ms-traffictypediagnostic: VI1PR08MB4032:EE_|VE1EUR03FT055:EE_|VE1PR08MB4703:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: j3EBDorFCeInXf1+hYaDaxjvnGi1+aQkPWf977KX+qdweECzVoUs0TS8PZtVOGNwcuIIdoe8wIf1Rt45A07OZB1w+cQQ9IsSNp7vONTDkCYp62z9QB40OYuWUpBTR8e/FvtDH4uINjewXnJ1wuubBWhJZZi6n7SjuPJ5LllPXSdSb28OAHym6p7n/XDxVmxWApnLLgolC21tq3gPbr3pAe8g75+WjJ52xSYeLc8WU9wRniaWmXnTyB7RvPiAPf4avlnUwaCR1PjjuidgXoYyZgCzJU6lreHQB61qa1VzCmw96rEvde2HYJ2YQZwohNYLCsETrGN3MT4DGzsQBzUezdtzhyhfiIEr9znLP+XhMmOumVmsa7BD+Yi6Q2tsrNBNcrjuQNJMAwrU5KB41UDKfXgeM1W9AfuMSvjwvETW/al0r30C5uexRAa1HwclJZg2agAIe4KylsBkpTAbme1TN1fo0foxiArU9vi93p6PggH+xU67vyqBmqjEZxEWCGwPoxv6u1cBEM5ZmbdjIV3T0TQKyULnH0FNG2c6zBCqIyeGfq2eCniArQzT+6bSabbMDw2sySx8UeAqV3HCEKvx5jNHYp9sAN7qfzcF6wQL2Cou/yvBq/oefQYP345QXUfh/ZY2fVaeaKhb1YlKx+5aBc6fyxYLxQa9VN5n2lP7sgEqFj3WYwadDRtOQwpkFlBoajz9pCClNADNn0JJwYNUg0BN3D33E/PSoLhLQmRSRmNUApVOae84vMnavjdkza6hczlRLSi51bHXASnpt0l3xDt0oG7+7i8o7UcpkZt4hrhB6LwEe1SnmaU+Jas1DzH4 X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39850400004)(366004)(396003)(8936002)(33656002)(52536014)(38100700002)(38070700005)(66556008)(4326008)(64756008)(66446008)(66476007)(8676002)(66946007)(76116006)(316002)(6916009)(54906003)(53546011)(7696005)(6506007)(26005)(83380400001)(55016003)(41300700001)(9686003)(186003)(122000001)(71200400001)(5660300002)(86362001)(478600001)(2906002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4032 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d6720f69-0b00-4f68-24af-08da688a77d9 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yavoToxkv8Ac3oUWq1eV/FqnxvCHjnWCo5XUPgoXfcUvDvX8QslmriZHl+sn2QxbUOFaYjmnQAiOjsxIc6/Yn5jv5emZjVR9nVc/rOPLQND4AmXfBqxP+zBrBed5vapheMcmJ9lilJ/H9kzLceh8k0rNHj/0Cc6fWGNPrNpMLCfp9ahLBMc/JLmjjGt1TI62t5LNzT3GbTGqk1W3WJjIBob2R2eHj4znAzHeJ0k3s/09WWD/OywEkBnX9GztvzV9qikTT8YCaQqoDRFdJULD01zWgahgEyVupXwpsYJxnnNn3o6CSAmP/u9AlrmkBIBMLf6MtH5cVi8oyb0hejwmLxD51VBY/8OB7Fz231OT4S03YG+0rQbaTDvm3gdbla44Qoqoa4wOmCcZXORHdtQILoNs6mOjo3WU8sDxaXN7O91VjztXpkcrZkInazcGFzy9aO4ZvuLj6Z2QNQ7oh/q1EvkiVtwOpfZEEfNpUQg01QiMYmX8zaOTVtzBJbUiDDNu8c2Wf/dhAqge9TUlqk9XMdneXDd3yrYCPgAckCF0Mt/x5XF+DyV3MhYzmYqAljiL76/cpjQWrhKdNnV8Kxo1aeKQVt2IivQSJmn04iTW9PfLINznBW/SD9TwFXin/jpQ8mWpM56t1wLqojXGvXA4ueaB8neIBb4DhDO5OzflEvz/Q2gneUEUNDa6cXTpUf+C+aMOwFLWkImn8LcZtmwpUCBsGeHjyMkDrFsP0to1fLeg1NzfeViXPBGkwyCW+Qq+15tDG6XXgC7ifgFqExlRfRPGi8riVNnWqxKcsUC2qb4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39850400004)(46966006)(36840700001)(336012)(47076005)(5660300002)(186003)(86362001)(82310400005)(52536014)(54906003)(36860700001)(8936002)(356005)(83380400001)(82740400003)(6862004)(81166007)(70206006)(8676002)(4326008)(2906002)(33656002)(7696005)(26005)(41300700001)(478600001)(6506007)(40480700001)(53546011)(316002)(55016003)(9686003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 06:55:33.8377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e6edcf61-e403-4eba-f093-08da688a830c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4703 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBGcmlkYXksIEp1bHkgOCwgMjAyMiA5OjA2 IFBNDQo+IFRvOiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gQ2M6IFdlaSBD aGVuIDxXZWkuQ2hlbkBhcm0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3LmNvb3BlcjNA Y2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4LmNvbT47DQo+ IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+OyBTdGVmYW5vIFN0YWJlbGxpbmkgPHNzdGFi ZWxsaW5pQGtlcm5lbC5vcmc+Ow0KPiBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgeGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnDQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjggOS85XSB4ZW46IHJl dHJpZXZlIHJlc2VydmVkIHBhZ2VzIG9uDQo+IHBvcHVsYXRlX3BoeXNtYXANCj4gDQo+IE9uIDA3 LjA3LjIwMjIgMTE6MjIsIFBlbm55IFpoZW5nIHdyb3RlOg0KPiA+IC0tLSBhL3hlbi9jb21tb24v bWVtb3J5LmMNCj4gPiArKysgYi94ZW4vY29tbW9uL21lbW9yeS5jDQo+ID4gQEAgLTI0NSw2ICsy NDUsMjkgQEAgc3RhdGljIHZvaWQgcG9wdWxhdGVfcGh5c21hcChzdHJ1Y3QgbWVtb3BfYXJncw0K PiA+ICphKQ0KPiA+DQo+ID4gICAgICAgICAgICAgICAgICBtZm4gPSBfbWZuKGdwZm4pOw0KPiA+ ICAgICAgICAgICAgICB9DQo+ID4gKyAgICAgICAgICAgIGVsc2UgaWYgKCBpc19kb21haW5fdXNp bmdfc3RhdGljbWVtKGQpICkNCj4gPiArICAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAg ICAgLyoNCj4gPiArICAgICAgICAgICAgICAgICAqIE5vIGVhc3kgd2F5IHRvIGd1YXJhbnRlZSB0 aGUgcmV0cmlldmVkIHBhZ2VzIGFyZSBjb250aWd1b3VzLA0KPiA+ICsgICAgICAgICAgICAgICAg ICogc28gZm9yYmlkIG5vbi16ZXJvLW9yZGVyIHJlcXVlc3RzIGhlcmUuDQo+ID4gKyAgICAgICAg ICAgICAgICAgKi8NCj4gPiArICAgICAgICAgICAgICAgIGlmICggYS0+ZXh0ZW50X29yZGVyICE9 IDAgKQ0KPiA+ICsgICAgICAgICAgICAgICAgew0KPiA+ICsgICAgICAgICAgICAgICAgICAgIGdk cHJpbnRrKFhFTkxPR19XQVJOSU5HLA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJDYW5ub3QgYWxsb2NhdGUgc3RhdGljIG9yZGVyLSV1IHBhZ2VzIGZvciBzdGF0aWMgJXBkXG4i LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGEtPmV4dGVudF9vcmRlciwgZCk7 DQo+IA0KPiBJJ20gcHJvYmFibHkgd3JvbmcgaW4gdGhpbmtpbmcgdGhhdCBJIGRpZCBwb2ludCBv dXQgYmVmb3JlIHRoYXQgdGhlcmUncyBubyByZWFsDQo+IHJlYXNvbiB0byBoYXZlICJzdGF0aWMi IHR3aWNlIGluIHRoZSBtZXNzYWdlLiBPciBhbSBJIG1pc3Rha2VuIGluIG15DQo+IHVuZGVyc3Rh bmRpbmcgdGhhdCBvbmx5IHN0YXRpYyBkb21haW5zIGNhbiBldmVyIGhhdmUgc3RhdGljIHBhZ2Vz Pw0KPiANCg0KU29ycnkgZm9yIG9taXR0aW5nIHRoZSBjb21tZW50LCBJJ2xsIG9ubHkga2VlcCBv bmUgc3RhdGljIGhlcmUuDQpZb3UncmUgcmlnaHQsIG9ubHkgc3RhdGljIGRvbWFpbnMgY2FuIGhh dmUgc3RhdGljIHBhZ2VzIGF0IHRoZSBtb21lbnQuDQoNCj4gPiBAQCAtMjgxOCw2ICsyODA1LDU1 IEBAIGludCBfX2luaXQgYWNxdWlyZV9kb21zdGF0aWNfcGFnZXMoc3RydWN0DQo+ID4gZG9tYWlu ICpkLCBtZm5fdCBzbWZuLA0KPiA+DQo+ID4gICAgICByZXR1cm4gMDsNCj4gPiAgfQ0KPiA+ICsN Cj4gPiArLyoNCj4gPiArICogQWNxdWlyZSBucl9tZm5zIGNvbnRpZ3VvdXMgcGFnZXMsIHN0YXJ0 aW5nIGF0ICNzbWZuLCBvZiBzdGF0aWMNCj4gPiArbWVtb3J5LA0KPiA+ICsgKiB0aGVuIGFzc2ln biB0aGVtIHRvIG9uZSBzcGVjaWZpYyBkb21haW4gI2QuDQo+ID4gKyAqLw0KPiA+ICtpbnQgX19p bml0IGFjcXVpcmVfZG9tc3RhdGljX3BhZ2VzKHN0cnVjdCBkb21haW4gKmQsIG1mbl90IHNtZm4s DQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5y X21mbnMsIHVuc2lnbmVkIGludA0KPiA+ICttZW1mbGFncykgew0KPiA+ICsgICAgc3RydWN0IHBh Z2VfaW5mbyAqcGc7DQo+ID4gKw0KPiA+ICsgICAgQVNTRVJUX0FMTE9DX0NPTlRFWFQoKTsNCj4g PiArDQo+ID4gKyAgICBwZyA9IGFjcXVpcmVfc3RhdGljbWVtX3BhZ2VzKHNtZm4sIG5yX21mbnMs IG1lbWZsYWdzKTsNCj4gPiArICAgIGlmICggIXBnICkNCj4gPiArICAgICAgICByZXR1cm4gLUVO T0VOVDsNCj4gPiArDQo+ID4gKyAgICBpZiAoIGFzc2lnbl9kb21zdGF0aWNfcGFnZXMoZCwgcGcs IG5yX21mbnMsIG1lbWZsYWdzKSApDQo+ID4gKyAgICAgICAgcmV0dXJuIC1FSU5WQUw7DQo+ID4g Kw0KPiA+ICsgICAgcmV0dXJuIDA7DQo+ID4gK30NCj4gPiArDQo+ID4gKy8qDQo+ID4gKyAqIEFj cXVpcmUgYSBwYWdlIGZyb20gcmVzZXJ2ZWQgcGFnZSBsaXN0KHJlc3ZfcGFnZV9saXN0KSwgd2hl bg0KPiA+ICtwb3B1bGF0aW5nDQo+ID4gKyAqIG1lbW9yeSBmb3Igc3RhdGljIGRvbWFpbiBvbiBy dW50aW1lLg0KPiA+ICsgKi8NCj4gPiArbWZuX3QgYWNxdWlyZV9yZXNlcnZlZF9wYWdlKHN0cnVj dCBkb21haW4gKmQsIHVuc2lnbmVkIGludCBtZW1mbGFncykNCj4gPiArew0KPiA+ICsgICAgc3Ry dWN0IHBhZ2VfaW5mbyAqcGFnZTsNCj4gDQo+IFVzZSBBU1NFUlRfQUxMT0NfQ09OVEVYVCgpIGhl cmUgYXMgd2VsbD8NCj4gDQoNClN1cmUsDQoNCj4gPiArICAgIC8qIEFjcXVpcmUgYSBwYWdlIGZy b20gcmVzZXJ2ZWQgcGFnZSBsaXN0KHJlc3ZfcGFnZV9saXN0KS4gKi8NCj4gPiArICAgIHNwaW5f bG9jaygmZC0+cGFnZV9hbGxvY19sb2NrKTsNCj4gPiArICAgIHBhZ2UgPSBwYWdlX2xpc3RfcmVt b3ZlX2hlYWQoJmQtPnJlc3ZfcGFnZV9saXN0KTsNCj4gPiArICAgIHNwaW5fdW5sb2NrKCZkLT5w YWdlX2FsbG9jX2xvY2spOw0KPiA+ICsgICAgaWYgKCB1bmxpa2VseSghcGFnZSkgKQ0KPiA+ICsg ICAgICAgIHJldHVybiBJTlZBTElEX01GTjsNCj4gPiArDQo+ID4gKyAgICBpZiAoICFwcmVwYXJl X3N0YXRpY21lbV9wYWdlcyhwYWdlLCAxLCBtZW1mbGFncykgKQ0KPiA+ICsgICAgICAgIGdvdG8g ZmFpbDsNCj4gDQo+IERvbid0IHlvdSBuZWVkIHRvIHVuZG8gd2hhdCB0aGlzIGRpZCBpZiAuLi4N Cj4gDQo+ID4gKyAgICBpZiAoIGFzc2lnbl9kb21zdGF0aWNfcGFnZXMoZCwgcGFnZSwgMSwgbWVt ZmxhZ3MpICkNCj4gPiArICAgICAgICBnb3RvIGZhaWw7DQo+IA0KPiAuLi4gdGhpcyBmYWlscz8N Cg0KWWVzLCB0aGFua3MgZm9yIHBvaW50aW5nIG91dC4NCmZyZWVfc3RhdGljbWVtX3BhZ2VzIGlz IG5lZWRlZCB0byBkbyB0aGUgcmV2ZXJzYWwgd2hlbiBpdCBmYWlscw0KDQo+IA0KPiBKYW4NCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369274.600612 (Exim 4.92) (envelope-from ) id 1oDL1l-0005Eo-SN; Mon, 18 Jul 2022 07:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369274.600612; Mon, 18 Jul 2022 07:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1l-0005ET-M1; Mon, 18 Jul 2022 07:18:49 +0000 Received: by outflank-mailman (input) for mailman id 369274; Mon, 18 Jul 2022 07:18:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1j-0004to-NP for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id db04218d-0669-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 09:18:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db04218d-0669-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=MBnjpYcrthIMf2A0TClYrTSnU8giI6pEvHtffLJlDVY=; b=G6cN5xEVpKp13zbtjNdQm9WsVzxFaw8p3fJI03vxLfTZTyT70n27sbKB 5Fe0u/NAZ1NvsVofjfiTZOKFUtndI93zhU6NZCoh/hWXVLl3emHSQ0B3W /j1dTrGX2SBDEjWOH75qG4lmfkTV6cwAbIIO1aihYscV9kohivGAuh1Py 0=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76011728 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:P9jYk60dOKxWYV0JffbD5bpxkn2cJEfYwER7XKvMYLTBsI5bpzNVn zMeWD+HbKrcMGCgfo1xYYjj/E5S65+Gm9FhSVNspC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8Uw35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/FxKkI2P4kmw7YtI01E2 6I7NC4kVh/W0opawJrjIgVtrsEqLc2tN4IDoHBwizreCJ7KQ7iaHf+Mv4UBmm5t2IYeRp4yZ OJAAdZrRD3GbwdCJRE8D5Umkf3zrnL+bydZuBSeoq9fD237k1IpieGyaoq9ltqiVcdSlWiWh 1P/pHnHXS8UNPGy6yDZ/Sf57gPItXyiA99DfFGizdZ1hHWDy2pVDwcZPXOZi/Skjk+1W/pEN lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWblXoVRYYNoZg7pVvA2V3i BnZxLsFGACDrpWRVlSe9rWQkwriYwo5J0FcRjMaZDMKtoyLTJ4Isv7fcjpyOPfr04KkQWChn 2riQDsW3OtK05NSv0mv1RWe2m/3+MCUJuIgzl+PNl9J+D+Vc2JMi2aAzVHApchNI4+CJrVql ChVwpPOhAzi4HzkqcBsfAnuNOvwjxp9GGeA6WOD5rF4n9hXx1atfJpL/BZ1L1pzP8APdFfBO RGO6VsBvs4MZCL7Mcebhr5d7Oxzl8Dd+SnNDKiIPrKinLArHON4wM2eTRHJhD28+KTduao+J Y2aYa6RMJruMow+lWLeb7pMjtcWKtUWnzy7qWbTk0v6itJzpRe9Fd84Dbd5RrpktP3U+FiJr 4432gnj40w3bdASqxL/qeY7RW3m51BibXwqg6S7rtK+Hzc= IronPort-HdrOrdr: A9a23:6oN8nqq5ic+i+tM3scP2gRoaV5oTeYIsimQD101hICG8cqSj+f xG+85rrCMc6QxhPk3I9urhBEDtex/hHNtOkOws1NSZLW7bUQmTXeJfBOLZqlWKcUDDH6xmpM NdmsBFeaXN5DNB7PoSjjPWLz9Z+qjkzJyV X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76011728" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/5] xen/wait: Drop vestigial remnants of TRAP_regs_partial Date: Mon, 18 Jul 2022 08:18:21 +0100 Message-ID: <20220718071825.22113-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The preservation of entry_vector was introduced with ecf9846a6a20 ("x86: save/restore only partial register state where possible") where TRAP_regs_partial was introduced, but missed from f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") where TRAP_regs_partial was removed. Fixes: f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/wait.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/xen/common/wait.c b/xen/common/wait.c index 9276d76464fb..3ebb884fe738 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -124,7 +124,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) struct cpu_info *cpu_info = get_cpu_info(); struct vcpu *curr = current; unsigned long dummy; - u32 entry_vector = cpu_info->guest_cpu_user_regs.entry_vector; ASSERT(wqv->esp == 0); @@ -169,8 +168,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) for ( ; ; ) do_softirq(); } - - cpu_info->guest_cpu_user_regs.entry_vector = entry_vector; } static void __finish_wait(struct waitqueue_vcpu *wqv) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369277.600635 (Exim 4.92) (envelope-from ) id 1oDL1n-0005jt-82; Mon, 18 Jul 2022 07:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369277.600635; Mon, 18 Jul 2022 07:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1m-0005gn-WD; Mon, 18 Jul 2022 07:18:51 +0000 Received: by outflank-mailman (input) for mailman id 369277; Mon, 18 Jul 2022 07:18:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1l-0004tp-GG for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:49 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ddd22d0f-0669-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 09:18:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ddd22d0f-0669-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128728; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XkwkicbnqybarudXENzuLnv1vjxC0glvjl5QcpNJ1bw=; b=Vz3PPRUgdVdDfZEX51XXFe+pmhT1AL5iIn+wrslCYDDwMuYRR3eaTSQ1 KDP11ZTmTJHofKwcAxPNuARg/IjlcC/NyKc4N+++LirLZO3FV+ZTa1J/e 76ZK486u99VGRgEdVGbNyYn4bOdymMtZPzgChq8IYjHk21vDkrECDamBg 0=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76442484 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:YD4n06JDNufvLTwkFE+RuJUlxSXFcZb7ZxGr2PjKsXjdYENS1j1Wn WRLXWGBb/mIM2D8KIhzYdi+9kkF7ZfRm9NlHgJlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYjdJ5xYuajhOs/3a90s11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE8sh+J2IbbY4iw6VRGmVC0 eIqcgIQcUXW7w626OrTpuhEg80iKI/gPZ8Fu2EmxjbcZRokacmdGeOQv4YehWpuwJAVdRrdT 5NxhT5HRRLMeRBQfHwQD4ozhryAjXjjaTxI7lmSoMLb5kCMklAtiuS9bLI5fPSJaf1Rwk/Bq ljo/m/aLEgIaMXClheKpyfEaujnwnqgBdN6+KeD3uFuqE2ewCoUEhJ+fXmRrOS9i0W+c8lCM EFS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxO4QfZmcfMpp87pZwHGF0k A/S9z/0OdBxmIyoWVm+2+eXlwrxHzMRIUscV3U2UBRQtrEPv7oPYgLzosdLSfDo0YytSGCsm VhmvwBl2exN0JdjO7GTuAme3mny/sWhohsdvF2/Y46z0u9uiGdJjaSM4EOT0/tPJZ3xorKp7 CldwJj2AAzj4PiweM2xrAYlRujBCw6tamG0vLKWN8BJG86R03CiZ5tMxzp1OV1kNM0JERewP hKD4VMLtcALZSr2BUOSX25WI51wpZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGfuR4YIhIf0+lFKeGrZCuYLHMwhkmgs/s7inkEn8uVdfDVbJIYo43KymNL1hsvPc/VmJq 76y9aKikn1ibQE3WQGPmaZ7ELzABSJT6UzewyCPStO+Hw== IronPort-HdrOrdr: A9a23:ENnVu62qu+sCT10vgT5uSwqjBIgkLtp133Aq2lEZdPRUGvb4qy nIpoVi6faUskdpZJhOo6HiBEDtexzhHNtOkO0s1NSZLW/bUQmTXeNfBOLZqlWKcUCTygce79 YGT0EXMqyKMbEQt6bHCWeDferIuOP3lZyVuQ== X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76442484" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/5] xen/wait: Minor asm improvements Date: Mon, 18 Jul 2022 08:18:23 +0100 Message-ID: <20220718071825.22113-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit There is no point preserving all registers. Instead, preserve an arbitrary 6 registers, and list the rest as clobbered. This does not alter the register scheduling at all, but does reduce the amount of state needing saving. Use a named parameter for page size, instead of needing to parse which is parameter 3. Adjust the formatting of the parameters slightly to simply the diff of the subsequent patch. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/wait.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/xen/common/wait.c b/xen/common/wait.c index 4dcfa17a8a3f..4bc030d1a09d 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -151,13 +151,12 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) * copies in from wqv->stack over the active stack. */ asm volatile ( - "push %%rax; push %%rbx; push %%rdx; push %%rbp;" - "push %%r8; push %%r9; push %%r10; push %%r11;" - "push %%r12; push %%r13; push %%r14; push %%r15;" + "push %%rbx; push %%rbp; push %%r12;" + "push %%r13; push %%r14; push %%r15;" "sub %%esp,%%ecx;" - "cmp %3,%%ecx;" - "ja .L_skip;" + "cmp %[sz], %%ecx;" + "ja .L_skip;" /* Bail if >4k */ "mov %%rsp,%%rsi;" /* check_wakeup_from_wait() longjmp()'s to this point. */ @@ -165,12 +164,12 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) "mov %%rsp,%%rsi;" ".L_skip:" - "pop %%r15; pop %%r14; pop %%r13; pop %%r12;" - "pop %%r11; pop %%r10; pop %%r9; pop %%r8;" - "pop %%rbp; pop %%rdx; pop %%rbx; pop %%rax" + "pop %%r15; pop %%r14; pop %%r13;" + "pop %%r12; pop %%rbp; pop %%rbx;" : "=&S" (wqv->esp), "=&c" (dummy), "=&D" (dummy) - : "i" (PAGE_SIZE), "0" (0), "1" (cpu_info), "2" (wqv->stack) - : "memory" ); + : "0" (0), "1" (cpu_info), "2" (wqv->stack), + [sz] "i" (PAGE_SIZE) + : "memory", "rax", "rdx", "r8", "r9", "r10", "r11" ); if ( unlikely(wqv->esp == 0) ) { @@ -224,11 +223,12 @@ void check_wakeup_from_wait(void) * All other GPRs are available for use; they're either restored from * wqv->stack or explicitly clobbered. */ - asm volatile ( - "mov %1,%%"__OP"sp; jmp .L_wq_resume;" - : : "S" (wqv->stack), "D" (wqv->esp), - "c" ((char *)get_cpu_info() - (char *)wqv->esp) - : "memory" ); + asm volatile ( "mov %%rdi, %%rsp;" + "jmp .L_wq_resume;" + : + : "S" (wqv->stack), "D" (wqv->esp), + "c" ((char *)get_cpu_info() - (char *)wqv->esp) + : "memory" ); unreachable(); } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369273.600605 (Exim 4.92) (envelope-from ) id 1oDL1l-0005BU-Fq; Mon, 18 Jul 2022 07:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369273.600605; Mon, 18 Jul 2022 07:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1l-0005BN-Ci; Mon, 18 Jul 2022 07:18:49 +0000 Received: by outflank-mailman (input) for mailman id 369273; Mon, 18 Jul 2022 07:18:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1j-0004tp-Eu for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:47 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db29b1b6-0669-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 09:18:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db29b1b6-0669-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PfqPuU4iTL51oPEUzQUxPoZi5ngRHlXvkVkGKzmfCpg=; b=Cl4/cJ4sG+JO9UjFbRgz+vXSyCSLwY79A0ptG1tdgkJzKNYr4D2Vq2ij aIeySyznHnmJTl5Eo+BkFr7il9rlQ97FsVghTuVZnzv6k2hnPrH0DucM3 sGNoJvsGiIFgFCrEO27Yo4WMKZiepnP27NBNzddkBTiJzdhueUYvLHk0y o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76442482 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:KjqbEqMATTNixGLvrR2xl8FynXyQoLVcMsEvi/4bfWQNrUpwhTQDy DAYUG+Hbv3fN2b0Kd13YN/npxwE7JTWmN5jSgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPvc8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPd/uVFL2xmPrchucBsBW1q6 85CGi0SO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJGahjabgIJEVAQEJ8kx8+jh2Xlci0eo1WQzUYyyzeNkFArjOi3WDbTUvOQfsRUsmmAn 03l42bBWk4fGc247QPQpxpAgceQxHimCer+DoaQ9PFwh0aI7ncOExBQXly+ydG1hEexVNNYL 0084Tc1oO4580nDZvvXUgC8oXWElgUBQNcWGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmKKRYWKQ8PGTtzzaBMQOBTZcP2leF1JDuoS95tFo5v7Scjp9OJ+InvbWNGHz+ QnJijM6i5ENv5Q5yrruqDgrnAmQSoj1oh8dv1uKATP9v1IlPuZJdKTztwGFsK8owJKxCwDY4 SNaw5X2APUmV8nlqcCbfAka8FhFDd6hOSaUv1NgFoJJG9+Fqy/6JtA4DN2TyS5U3ic4ldzBO ha7Vft5vsM7AZdTRfYfj3iNI8or17P8Mt/uS+rZaNFDCrAoKlLXpHE0NBHIhjGx+KTJrU3YE c7BGftA8F5AUfg3pNZIb711PUAXKtAWmjqIGMGTI+WP2ruCfn+FIYo43K+1RrlgtMus/VSKm +uzwuPQlH2zpsWiPXSMmWPSRHhWRUUG6Wfe8ZEPKL7bf1Y6QAnMyZb5mNscRmCspIwN/s+gw 513chUwJIbX7ZEfFTi3Vw== IronPort-HdrOrdr: A9a23:zruxQq8fbdeFxVAGgkJuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76442482" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Juergen Gross , Dario Faggioli Subject: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT Date: Mon, 18 Jul 2022 08:18:25 +0100 Message-ID: <20220718071825.22113-6-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit With the waitqueue logic updated to not use an absolute stack pointer reference, the vCPU can safely be resumed anywhere. Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes, and a logical corner case where resetting the vcpu with an oustanding waitqueue would crash the domain. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Juergen Gross CC: Dario Faggioli --- xen/common/domain.c | 2 -- xen/common/sched/core.c | 4 +--- xen/common/wait.c | 23 ----------------------- xen/include/xen/sched.h | 1 - 4 files changed, 1 insertion(+), 29 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 618410e3b257..323b92102cce 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -1428,8 +1428,6 @@ int vcpu_reset(struct vcpu *v) v->is_initialised = 0; if ( v->affinity_broken & VCPU_AFFINITY_OVERRIDE ) vcpu_temporary_affinity(v, NR_CPUS, VCPU_AFFINITY_OVERRIDE); - if ( v->affinity_broken & VCPU_AFFINITY_WAIT ) - vcpu_temporary_affinity(v, NR_CPUS, VCPU_AFFINITY_WAIT); clear_bit(_VPF_blocked, &v->pause_flags); clear_bit(_VPF_in_reset, &v->pause_flags); diff --git a/xen/common/sched/core.c b/xen/common/sched/core.c index f689b55783f7..cff8e59aba7c 100644 --- a/xen/common/sched/core.c +++ b/xen/common/sched/core.c @@ -1610,12 +1610,10 @@ void watchdog_domain_destroy(struct domain *d) /* * Pin a vcpu temporarily to a specific CPU (or restore old pinning state if * cpu is NR_CPUS). - * Temporary pinning can be done due to two reasons, which may be nested: + * Temporary pinning can be done for a number of reasons, which may be nested: * - VCPU_AFFINITY_OVERRIDE (requested by guest): is allowed to fail in case * of a conflict (e.g. in case cpupool doesn't include requested CPU, or * another conflicting temporary pinning is already in effect. - * - VCPU_AFFINITY_WAIT (called by wait_event()): only used to pin vcpu to the - * CPU it is just running on. Can't fail if used properly. */ int vcpu_temporary_affinity(struct vcpu *v, unsigned int cpu, uint8_t reason) { diff --git a/xen/common/wait.c b/xen/common/wait.c index 4f1daf650bc4..bd6f09662ac0 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -127,16 +127,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) ASSERT(wqv->used == 0); - /* Save current VCPU affinity; force wakeup on *this* CPU only. */ - if ( vcpu_temporary_affinity(curr, smp_processor_id(), VCPU_AFFINITY_WAIT) ) - { - gdprintk(XENLOG_ERR, "Unable to set vcpu affinity\n"); - domain_crash(curr->domain); - - for ( ; ; ) - do_softirq(); - } - /* * Hand-rolled setjmp(). * @@ -187,7 +177,6 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) static void __finish_wait(struct waitqueue_vcpu *wqv) { wqv->used = 0; - vcpu_temporary_affinity(current, NR_CPUS, VCPU_AFFINITY_WAIT); } void check_wakeup_from_wait(void) @@ -201,18 +190,6 @@ void check_wakeup_from_wait(void) if ( likely(!wqv->used) ) return; - /* Check if we are still pinned. */ - if ( unlikely(!(curr->affinity_broken & VCPU_AFFINITY_WAIT)) ) - { - gdprintk(XENLOG_ERR, "vcpu affinity lost\n"); - domain_crash(curr->domain); - - /* Re-initiate scheduler and don't longjmp(). */ - raise_softirq(SCHEDULE_SOFTIRQ); - for ( ; ; ) - do_softirq(); - } - /* * Hand-rolled longjmp(). * diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b9515eb497de..ba859a4abed3 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -223,7 +223,6 @@ struct vcpu /* VCPU need affinity restored */ uint8_t affinity_broken; #define VCPU_AFFINITY_OVERRIDE 0x01 -#define VCPU_AFFINITY_WAIT 0x02 /* A hypercall has been preempted. */ bool hcall_preempted; -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369272.600595 (Exim 4.92) (envelope-from ) id 1oDL1k-0004uv-8b; Mon, 18 Jul 2022 07:18:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369272.600595; Mon, 18 Jul 2022 07:18:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1k-0004uT-55; Mon, 18 Jul 2022 07:18:48 +0000 Received: by outflank-mailman (input) for mailman id 369272; Mon, 18 Jul 2022 07:18:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1i-0004to-Vl for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:46 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id daf19339-0669-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 09:18:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: daf19339-0669-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128725; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F6JK8R4vklGJZNuhaf1bZprn0UinPkgJRlwtPk8D4E8=; b=HZK3hd3kiqWSIHd/x1jXWXR8ib2eGtSumJ/y/am1jHgNUn3jQnwoxrJV PiVyrphtfpQ4a1saxqDjdYAXNEtepVzCMeAfIhoI4HVIst5awZCN3UL+X hDnBmx4shia/Yo4UsiXSNt7r/9tSH8WkDhvYspbURR6cV+gXq4D9xJL5S 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76007331 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3Ae1brrKP0+ugpJ/zvrXNrnJYgzKimJRAgMBhAA?= =?us-ascii?q?5OJyBtyWkJYtZNa93r/TTRbcNWNAwAcmmIG0TFDXW4DK0JKoVnUygFF/X7yB?= =?us-ascii?q?ptrHy3eogHlySd64WL/45REHnRZwXvr0cO00x4icwyFQPofEgcEg2A9myiYE?= =?us-ascii?q?v9wJDbu2DlYKfYgvPGDMBIhVKJL48ReOvCXKqpniY5GLvlbxIQggiE59Xnbz?= =?us-ascii?q?Zi68uGBRy3+JDcSLhVh36GdRVC1ubN0aWN7JSUWeWN1V0phqE4k8tAatNnXP?= =?us-ascii?q?ck7dADaMfnpsO2IhMoGwUIXklH7v6FVIQVsPe3YflA2/L+ABkPjXNH1bo8mv?= =?us-ascii?q?pQEH5eAXkPLTEEqCK2N5HnFphwakPmhBHBSn+slivtfCFQG81Z5/ll82YUld?= =?us-ascii?q?xN/GbdiKQiE1aVCJMHx5Jkc2yBM1T9NgtjHVF93U8cvndjzBQdNiU8ADZNtF?= =?us-ascii?q?E0mrCzvbbyl0QJ/9z1iY/lY2zNr+e+vKHFq21Wy8Y/aExTk/Fk03u55Xb7/l?= =?us-ascii?q?p01yOrhe++d1rZAaqYxosbi+GZO8SMQfUfj4cWE3pX6tCtSnN+hdDJmwKPSQ?= =?us-ascii?q?WNNjyv3WowYP9eByCdtkVdnZffBSlWokb3JTU8KFyZ7cWVN5uWMHvE2TB/mV?= =?us-ascii?q?7dCC/lMbsVxFDgztceO+m1hk6WE8rover18RBGHyMun3r8akIqLlc8X0BxB8?= =?us-ascii?q?KPKzwSLKKLaZox7dCewjh7uWwRH4/OV8oXud/2q003eHU5jBC60S576otRN9?= =?us-ascii?q?KQ/aFfo2bdsWfc8HYwtdZKBSjchkB7lsg4ulVHbJ/TdbSeVOjkSjRnsjxZgq?= =?us-ascii?q?wdOh0ec0cm/7NGjQ6mdRKUmUecLzhQzzSLzNdkkKD9hsMZlqoqGQjZB4IjRo?= =?us-ascii?q?KJAssNvEGLycLdqJWW02YcG90fR+vLlhCNqcGPdGgDAsMQTRfKdCrCf7mw4R?= =?us-ascii?q?wGMkdw1MOac7qIq2GOKfQhbwCbQrV8xeKaZS8IGXL46B1r3gIW4ijgHHNHz/?= =?us-ascii?q?sGBpOI8fjcRWXw9TSRgN/ICgtkZcyoE3YWZo39Ea6GEFQD2OiW3910/aoTbM?= =?us-ascii?q?zJ6QIRUvYu0AWtCwhNDA4rn3KwonBqiP46DAW6C8DJR22pL+ZuMEESNCT58l?= =?us-ascii?q?e6QP8YUi8ernjKQuViv/mtFjGrybNJdmGwT0Ha7N0ZO32pybvYDm9Z+XixTA?= =?us-ascii?q?rysugTj0poqGbjUqPKZ0U2LYhIG1rmPDFTiEvq2x687Y4VMG0H7RUvFSjeZX?= =?us-ascii?q?56rg8rabFSvjIRedtpv+ImH31p57hqqp2cj4F00Xj0KaQCpIwkIFicH+8mgn?= =?us-ascii?q?1s4EVsp4IlwxwKN4qvPjx3oyfdTB/7Hb5VlaljhnPLILgw1Dk2zfnEODnK+n?= =?us-ascii?q?O4QOAC4hIBG5jIuFbKo/8ZoySQNrZWVLFtxMldfd80rJh14Wx7U1WdBv6TYo?= =?us-ascii?q?z0FHeJoTuuhvPr+izHegFPGk5F14bcaF9esGdxtCaFaHZ5bnY+PBXAYs6JNe?= =?us-ascii?q?v7x1TVmWRfm0Dzz8n1RLIwTDvohD1Kapz9JtRhDBbKEUmSFGDGV/QacltqJM?= =?us-ascii?q?Y15Fo4X4d+joQ3UfK9H2r2uzY0zN4k15XCegBgVza/UXEJAVDUKZIQrIY33v?= =?us-ascii?q?L7yrS1CY2D962FtyO2dx4JK3rNmYvyNzvO8TcOlT6T0k59Z+i75bhUJ22nQB?= =?us-ascii?q?ZJdTJLGCa7p5v3lYydZv895/k9Z9sm1y8f2BQT62NLFXxPTgn3lyl/zKh/qo?= =?us-ascii?q?nB546CCFVDSfOf7POkesdYW7JoYRAiL/TpX6052YL5WuP4pGkHKZGtTgzULq?= =?us-ascii?q?M7bW+pvYtmKR31NWyTiSvhi4LFh9n5LAtJ3IRwypxKfo99J/J7lh/0aTvtAL?= =?us-ascii?q?s6gfUde9hNuCIImQ1hroMfyxGvr+/H9CpgM9Hq1q12r1IAPp6WQxWwmA3YaB?= =?us-ascii?q?/Jy4WQ4Wt05qDYHzk/iuLHbwAAqgl3AsdQMvfmoxGzhuv9NXtC7v4r5axjTd?= =?us-ascii?q?92RR/meuYTlHeIda7xUsKX2aedzBaEYldB8RxCQrnfavPTHHb6DtZaHMft7O?= =?us-ascii?q?JCPzOX6ag5biexcO3FvUdXJzEGG3jVS50ekjgjUsGB7PyGJ5iHKxArTZTFEb?= =?us-ascii?q?MXcdhQIJKo4wliWOQgpRGnbMlOUiosvkXS70eQTKzIdGXE/JDyAxRskUVTVw?= =?us-ascii?q?hHRZnIYfwFbVZZlgT0BAolCfDaFiT7+P9wGOgZXS2+ELeDsQYHjGLKr8A1cE?= =?us-ascii?q?X8iWEbjjeseBC8MZidyaJdQHbs/iOH9mdEkImoumGZ/QEAqg2VxFoLAYv3UR?= =?us-ascii?q?FHrAcI64UkNnn3Df0ywgniN6sD0YL/hDiuBmEdOXs5opcKG4cjy+Exv7UVIL?= =?us-ascii?q?KvO218hY+LgAtJI7Gh1wugXAad2NS8kJQh2D4fl1YqykeZLwsoBzzwL4TyUy?= =?us-ascii?q?YnYvVpHY7q7xgWCG6qbKm001crSPd0Kop7xDQMTZwRzcqumEVY6eYQKtu8R6?= =?us-ascii?q?HELunW1qxXW4IiRKJ+6U5BIUmtJ9P+1hjfUyesROhwOL6COc5liJF0GFudPm?= =?us-ascii?q?IU0nkWdbSFsjlnf63+9LmQLdmEtn4D05fUOHgVUEC8ZXYMn/UHyP0lwFdZhV?= =?us-ascii?q?t8h/jpwdnXf6EFB9uZoBIAGBpTKbOTYxzBtxVkC8bF0zufqLP23uQYoaqaVT?= =?us-ascii?q?mFUgAHWUkdkPJd0vIFlObk5KSStdVqJvtvCC0SPIliCTn6tNuPIk/riYAsnp?= =?us-ascii?q?g1gUW2P+m2O6PiPWtyeW6tq?= X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76007331" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Date: Mon, 18 Jul 2022 08:18:22 +0100 Message-ID: <20220718071825.22113-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/wait.c | 29 +++++++++++++++++++++++++---- 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/xen/common/wait.c b/xen/common/wait.c index 3ebb884fe738..4dcfa17a8a3f 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -137,7 +137,19 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) do_softirq(); } - /* Hand-rolled setjmp(). */ + /* + * Hand-rolled setjmp(). + * + * __prepare_to_wait() is the leaf of a deep calltree. Preserve the GPRs, + * bounds check what we want to stash in wqv->stack, copy the active stack + * (up to cpu_info) into wqv->stack, then return normally. Our caller + * will shortly schedule() and discard the current context. + * + * The copy out is performed with a rep movsb. When + * check_wakeup_from_wait() longjmp()'s back into us, %rsp is pre-adjusted + * to be suitable and %rsi/%rdi are swapped, so the rep movsb instead + * copies in from wqv->stack over the active stack. + */ asm volatile ( "push %%rax; push %%rbx; push %%rdx; push %%rbp;" "push %%r8; push %%r9; push %%r10; push %%r11;" @@ -199,9 +211,18 @@ void check_wakeup_from_wait(void) } /* - * Hand-rolled longjmp(). Returns to __prepare_to_wait(), and lands on a - * `rep movs` instruction. All other GPRs are restored from the stack, so - * are available for use here. + * Hand-rolled longjmp(). + * + * check_wakeup_from_wait() is always called with a shallow stack, + * immediately after the vCPU has been rescheduled. + * + * Adjust %rsp to be the correct depth for the (deeper) stack we want to + * restore, then prepare %rsi, %rdi and %rcx such that when we intercept + * the rep movs in __prepare_to_wait(), it copies from wqv->stack over the + * active stack. + * + * All other GPRs are available for use; they're either restored from + * wqv->stack or explicitly clobbered. */ asm volatile ( "mov %1,%%"__OP"sp; jmp .L_wq_resume;" -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369276.600626 (Exim 4.92) (envelope-from ) id 1oDL1m-0005U9-K7; Mon, 18 Jul 2022 07:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369276.600626; Mon, 18 Jul 2022 07:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1m-0005Rb-CH; Mon, 18 Jul 2022 07:18:50 +0000 Received: by outflank-mailman (input) for mailman id 369276; Mon, 18 Jul 2022 07:18:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1k-0004to-Nh for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dcd84a51-0669-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 09:18:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcd84a51-0669-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128726; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ebOQyw54nOOd0pf8acUFtFVapBth6uiZeKHzw4jUO8k=; b=dbRg3o8jbpf7EYumHEO9USjY+zLSYaKU6IU3RjkwyUnzL8bnIQ3sMkJw TuUrI0SedUVrKNuV/qcJeYeFxVx+Hjjw8tsvdWg+e9QBL8KMxxATDqO/S BVv/MW2GfUmXN8oX7WoytCg9e1rz/RMFOXQ8E+krJfNLHWhoTQRmpydmo E=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76007332 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AzjBJsa2tB0xEkJQofPbDix16xS7N8HFdZTh5A?= =?us-ascii?q?9k8jSZ0cfkRliZWkhF6PiwklHlZu+rW2YndT/em3FGgmSslSUnMXd4QO/PJH?= =?us-ascii?q?hVrmHATwQEHUHVE2NFApiHviEdWNnjUaBy65wBs81Eismu0A9pSy5YFciCEk?= =?us-ascii?q?jMPwJ7ek37nVVutO35b33UT7JRP5F/H3jn+KVRCr5/xrZZxp+VXVcLF2F/lF?= =?us-ascii?q?q3KSUyb0H8LcL8SdO1n3lp5gr09/uS/VfPfvYA9iS3hT7yfGtBZyU31dpkBN?= =?us-ascii?q?rx7mkC4lYI8xl9BbuzQl74WYbXOwNE/LrirTkv/hEMReKhLiR+VXP5Z+PtEz?= =?us-ascii?q?TU6wWRo/NhkDABzB3T4+aL8uBx9xnwALmCCVJBPKATbm+55KHZrd4jNRVens?= =?us-ascii?q?DLN5KJ1Y6xEWpQzxsWc5HfteSE8KUCIRl/fIwRaGMAsL/A3WrdvC88c/l0lI?= =?us-ascii?q?PjXh23vQYIm3LxsIRS7q8w01GL6FhGa6/6SXuQGnlFXp4T8Ji5Pt0qELmP4L?= =?us-ascii?q?T09DwL1nc7phsLmE9/PePhpT6Ud1kUBu09lXuDlpZ+xCmm8rIQEhZ7j4u+Ta?= =?us-ascii?q?yUflwoG+NwI4z/9IKnKb0cFF4+9zymJqLwW1Wnrc//O+P9cjXfFrPkKSUqQm?= =?us-ascii?q?2EggxRtnS4E/6WVUlJrarcs5WB/VN1P/ZAXBxdJHGF3ZCUNGeaP2BXb2zapl?= =?us-ascii?q?sufyb+QxJFWdAd2AKlTk6hmAtFfGCY3BqecuUIAeOODnFRSRD5El1bZkVTeA?= =?us-ascii?q?BXJEPLNd6CmcKiocVKHTNs1Rtv+ib0aow1Vd0Yv32hmzbpopmL+T6n4Aa8AV?= =?us-ascii?q?rHNePMiFAEcM32wAr6S6dapPO3yV3uMjFv6Ys88F8D7hZo936QdpG89j2JPV?= =?us-ascii?q?rhuBki62RiKdIFqrKlnavZ/bY657+c1P0iwmUgF9QIKc4jf6twjk8fpsaxq+?= =?us-ascii?q?Giw3iXdS68a5dxfndxD3hcJfd/wNlkKM5LF7u0ozPQ7Ez77Jl+YmJwAhQI1E?= =?us-ascii?q?kXMrCr08HlFkRWHYITsYZaSi2ElyS0RC9cKwnNjQEmQ2HMSjMrSInTqrdQjf?= =?us-ascii?q?+riPAUd+l8mNMHVbXcIXHDycDBQse6Ge8bg9VxNOzDtekFMDffAlheffciXv?= =?us-ascii?q?URsKXmLqcbiYkn4WewPfWmZfqzlVyBvIrUWimBC2wBsY1lCh8k2L2jiJKs6A?= =?us-ascii?q?l4i018ucgPgxFmvAtc0uyjgJ5STKYWPAmnX27nXbh9s9dWyo2btBF4JolKew?= =?us-ascii?q?yKnxDWTKc7IbTZXOLcM8xw4dLBHJ4U5irDGZSfpCErn3f4IU4cmTxMgwifYs?= =?us-ascii?q?04mdMMGMQTLyr/6MdJyQEA2j5uuxVn40FcGIB0CuzDrO45+s52Ra633kXyOe?= =?us-ascii?q?UecITqzRciQrgQ1W0OoyawiQerdoeH0bJwZSDZH28HIVc7UaZGK4buvxPDiI?= =?us-ascii?q?OhldnMURbQj8s2ZDSXG5OLr9fEWX1nI36xi9QnDc7DZH8/GVR99AO9doyOuS?= =?us-ascii?q?1XDLNLwsiuh0pNr8n2WYiScvxMph9l9L8q0O24BqBKIMlalyS4MuQZ21pcl+?= =?us-ascii?q?7pZOwDGzoNGu6mw2XodioYsE52k+95+n5vAiQ8n40yjzVLk6zardi15ONIP6?= =?us-ascii?q?BmCHVyscY0b5B/8Gj89HB7vxzzp1sGb1qGR/EaOwbAa6TGikImFi9Dn2iV+v?= =?us-ascii?q?WsizV5GHj0BIc08AUTtwB5HHVScAGy2hNmS5u8QCzMbSMOXQiTGa3P9x3rtO?= =?us-ascii?q?HMSePyfCBDtS7A49pq2qbVqjvTqlOyhDwZEpz693zP4aekwr9NbEctmYzP5o?= =?us-ascii?q?8ssw5YIW8yqTqsDy3lo5aJEjsNqcdoc5qJl/IOkFXuj3N6ka7Z49rFDWBIEJ?= =?us-ascii?q?kyh00D/Qd+h99JpNijBx/QGjyb544knApj9Ejal+CU0Ywh20BqUNi7eKaUcq?= =?us-ascii?q?HJA/ofDDxeKFpJk5EL4wYvctZslSfJJ4R3JyAc4c5s1TS+3GixP7gZxI/icX?= =?us-ascii?q?+Na5bY8xIPrhWMW7hC8A72hBrVvHbt79AuNDhw26dB10X/ckN7JR8mblrdqM?= =?us-ascii?q?frVtZbolwZFcU7nqfLSK8j8rbrOLzIWpUeHZy91oDwz4nfAE3JecsOKzTdqu?= =?us-ascii?q?1C9AkQCD+8XC/mUfPBOhE2AmA0IJ4GFX289K03lJPx0aR3997VDbHIasgdyP?= =?us-ascii?q?e3+pkEwtUXw26Jor0+X4bXD7xZ28BjVchK/lyrWU/ujyFtTBZ3e7NWsnlQQT?= =?us-ascii?q?WIeGwUrodpuJrSGaaLo9GGoxT19Nv3uIp4ox9nRMgHxAOQTJp2OZ63K4KtgZ?= =?us-ascii?q?o69spRrkTbnOQSfVRrxN12Er5y4z4b/E3BsOIHhLAFB7kdpPCsz7iZfLsgYu?= =?us-ascii?q?VEXz7UQCGOFCSEIzBob9f2riyi5KiDJrg9jSpp9yxa0SV7oOaZZub+vcX+RG?= =?us-ascii?q?abo8BPqd4Iou1q9SsQO0znSDXzPbobCCTDCaL+MN2eEXbefTVQzeXq+3/1g6?= =?us-ascii?q?+OE/b/UgQWHkjK2JGEMaTjKqH2ozj4SInCJAUhMPApaPU53NqC5Vgf7RlsOJ?= =?us-ascii?q?J9XxseJneJi6YTkHGtDva8UAa47lvKzc2ZMLHNHfVPYG6Q5gg/Rrd41LgRGv?= =?us-ascii?q?EI5NmNuy3YQwZqtSB3mgzFhIoshSkkfmg6fvAGkhao89CkGoTqbJafEAy084?= =?us-ascii?q?2u7U8M7jxVpIVtopct0AuiWcTNdhKh0d0Lz8pm1so0Z8FrzDCepLYKVW6cdf?= =?us-ascii?q?3FZ5JzO7gB7Wdgwrbip3We7+UJn?= X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76007332" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 4/5] xen/wait: Use relative stack adjustments Date: Mon, 18 Jul 2022 08:18:24 +0100 Message-ID: <20220718071825.22113-5-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The waitqueue's esp field is overloaded. It serves both as an indication that the waitqueue is in use, and as a direction to check_wakeup_from_wait() as to where to adjust the stack pointer to, but using an absolute pointer comes with a cost if requiring the vCPU to wake up on the same pCPU it went to sleep on. Instead, have the waitqueue just keep track of how much data is on wqv->stack. This is no practical change in __prepare_to_wait() (it already calculated the delta) but split the result out of the (also overloaded) %rsi output parameter by using a separate register instead. check_wakeup_from_wait() has a bit more work to do. It now needs to calculate the adjustment to %rsp rather than having the new %rsp provided as a parameter. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/common/wait.c | 44 ++++++++++++++++++++++++++++---------------- 1 file changed, 28 insertions(+), 16 deletions(-) diff --git a/xen/common/wait.c b/xen/common/wait.c index 4bc030d1a09d..4f1daf650bc4 100644 --- a/xen/common/wait.c +++ b/xen/common/wait.c @@ -32,8 +32,8 @@ struct waitqueue_vcpu { * Xen/x86 does not have per-vcpu hypervisor stacks. So we must save the * hypervisor context before sleeping (descheduling), setjmp/longjmp-style. */ - void *esp; char *stack; + unsigned int used; #endif }; @@ -121,11 +121,11 @@ void wake_up_all(struct waitqueue_head *wq) static void __prepare_to_wait(struct waitqueue_vcpu *wqv) { - struct cpu_info *cpu_info = get_cpu_info(); struct vcpu *curr = current; unsigned long dummy; + unsigned int used; - ASSERT(wqv->esp == 0); + ASSERT(wqv->used == 0); /* Save current VCPU affinity; force wakeup on *this* CPU only. */ if ( vcpu_temporary_affinity(curr, smp_processor_id(), VCPU_AFFINITY_WAIT) ) @@ -154,24 +154,25 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) "push %%rbx; push %%rbp; push %%r12;" "push %%r13; push %%r14; push %%r15;" - "sub %%esp,%%ecx;" + "sub %%esp, %%ecx;" /* ecx = delta to cpu_info */ "cmp %[sz], %%ecx;" "ja .L_skip;" /* Bail if >4k */ - "mov %%rsp,%%rsi;" + + "mov %%ecx, %%eax;" + "mov %%rsp, %%rsi;" /* Copy from the stack, into wqv->stack */ /* check_wakeup_from_wait() longjmp()'s to this point. */ ".L_wq_resume: rep movsb;" - "mov %%rsp,%%rsi;" ".L_skip:" "pop %%r15; pop %%r14; pop %%r13;" "pop %%r12; pop %%rbp; pop %%rbx;" - : "=&S" (wqv->esp), "=&c" (dummy), "=&D" (dummy) - : "0" (0), "1" (cpu_info), "2" (wqv->stack), + : "=a" (used), "=D" (dummy), "=c" (dummy), "=&S" (dummy) + : "a" (0), "D" (wqv->stack), "c" (get_cpu_info()), [sz] "i" (PAGE_SIZE) - : "memory", "rax", "rdx", "r8", "r9", "r10", "r11" ); + : "memory", "rdx", "r8", "r9", "r10", "r11" ); - if ( unlikely(wqv->esp == 0) ) + if ( unlikely(used > PAGE_SIZE) ) { gdprintk(XENLOG_ERR, "Stack too large in %s\n", __func__); domain_crash(curr->domain); @@ -179,11 +180,13 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) for ( ; ; ) do_softirq(); } + + wqv->used = used; } static void __finish_wait(struct waitqueue_vcpu *wqv) { - wqv->esp = NULL; + wqv->used = 0; vcpu_temporary_affinity(current, NR_CPUS, VCPU_AFFINITY_WAIT); } @@ -191,10 +194,11 @@ void check_wakeup_from_wait(void) { struct vcpu *curr = current; struct waitqueue_vcpu *wqv = curr->waitqueue_vcpu; + unsigned long tmp; ASSERT(list_empty(&wqv->list)); - if ( likely(wqv->esp == NULL) ) + if ( likely(!wqv->used) ) return; /* Check if we are still pinned. */ @@ -220,14 +224,22 @@ void check_wakeup_from_wait(void) * the rep movs in __prepare_to_wait(), it copies from wqv->stack over the * active stack. * + * We are also bound by __prepare_to_wait()'s output constraints, so %eax + * needs to be wqv->used. + * * All other GPRs are available for use; they're either restored from * wqv->stack or explicitly clobbered. */ - asm volatile ( "mov %%rdi, %%rsp;" + asm volatile ( "sub %%esp, %k[var];" /* var = delta to cpu_info */ + "neg %k[var];" + "add %%ecx, %k[var];" /* var = -delta + wqv->used */ + + "sub %[var], %%rsp;" /* Adjust %rsp down to make room */ + "mov %%rsp, %%rdi;" /* Copy from wqv->stack, into the stack */ "jmp .L_wq_resume;" - : - : "S" (wqv->stack), "D" (wqv->esp), - "c" ((char *)get_cpu_info() - (char *)wqv->esp) + : "=D" (tmp), [var] "=&r" (tmp) + : "S" (wqv->stack), "c" (wqv->used), "a" (wqv->used), + "[var]" (get_cpu_info()) : "memory" ); unreachable(); } -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:18:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:18:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369275.600619 (Exim 4.92) (envelope-from ) id 1oDL1m-0005LY-8d; Mon, 18 Jul 2022 07:18:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369275.600619; Mon, 18 Jul 2022 07:18:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1l-0005IR-Vg; Mon, 18 Jul 2022 07:18:49 +0000 Received: by outflank-mailman (input) for mailman id 369275; Mon, 18 Jul 2022 07:18:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDL1k-0004tp-Br for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:18:48 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dcff2983-0669-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 09:18:47 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dcff2983-0669-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658128727; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Mum1aKh8B28t6+mlcr+GzyZyZrglrMoFRYfHGq4I0qs=; b=Zuu7XkbW4U82RljWa/OJqD8BvI9FPCqBCsPbUewEoLDUWg97ABwt/tqZ TzUDcXuw3x9mw9bvKdmH8s7g7GDe57TJmeiR2U2lRZEhy9TYt90+oK6gN H9xu0ymW4oiyL18q6+6RvM+iFNuUqMgV4v+dSB+CS4zEnMPN76fHxH3vE g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76442483 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Rcff2qBxOxqi9BVW/z3jw5YqxClBgxIJ4kV8jS/XYbTApGtwgjRWn TccX2nQOPyKMDH8Lt90O9zkoxlV75TXx4ViQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsv3b8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW0rR095NIRE1B7Rb3P1zDUVQx 6YqNS9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQRNpYA7NfFtkPVAPBYhltOypmmP+Y3tTr1f9Sa8fvDaPkFYtgOOF3Nz9JeDSY8xloFqh/ 3uB8GvyW04aD/nC8G/Qmp6rrrCWxn6qMG4IL5W6+eRtm0a73XEIBVsdUl7TifW3g0GxWtVbK mQP5zEj66M18SSDbPPwQhm5q36spQMHVpxbFOhSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHr7m9WX+bsLCOoluP1TM9dDFYI3VeFE1cvoel8NpbYg/zoshLIZOlpf7YSTLK+ nOstywyo6sh1/wWyPDulbzYuA5AtqQlXyZsuFiIDzr0v18jDGK2T9f2sAaGtJ6sOK7cFwDc5 yZcxqBy+chUVfmweDqxrPLh9V1Dz9KMK3XijFFmBPHNHBz9qif4Lei8DNyTTXqF0/romhezO Sc/QSsLuPdu0IKCNMebmb6ZBcUw1rTHHt/4TP3SZdcmSsEvKV/frHs/OhbJjjyFfK0QfUYXY M3zTCpRJSxCVfQPIMSeHY/xLoPHNghhnDiOFPgXPjys0KaEZW79dIrpxGCmN7lhhIvZ8Vq9z jqqH5HVo/mpeLGhP3K/HE96BQxiEEXX8ris9pQJJrbeflY+cIzjYteIqY4cl0Vet/w9vo/1E ruVACe0FHKXaaX7FDi3 IronPort-HdrOrdr: A9a23:Kho/nKhMTd6jj0eTVbL0W7Yk/nBQXtQji2hC6mlwRA09TySZ// rOoB19726TtN9xYgBGpTnuAtjifZqxz/FICOoqTNOftWvdyQmVxehZhOOIqVCNJ8SXzJ8l6U 4KSchD4bPLY2SS9fyKhTWFLw== X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76442483" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Juergen Gross , Dario Faggioli Subject: [PATCH 0/5] xen/wait: Improvements Date: Mon, 18 Jul 2022 08:18:20 +0100 Message-ID: <20220718071825.22113-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This started out as patch 2 for a different task, and quickly identified some technical debt, long overdue for cleaning up. Andrew Cooper (5): xen/wait: Drop vestigial remnants of TRAP_regs_partial xen/wait: Extend the description of how this logic actually works xen/wait: Minor asm improvements xen/wait: Use relative stack adjustments xen/wait: Remove VCPU_AFFINITY_WAIT xen/common/domain.c | 2 - xen/common/sched/core.c | 4 +- xen/common/wait.c | 117 +++++++++++++++++++++++++----------------------- xen/include/xen/sched.h | 1 - 4 files changed, 63 insertions(+), 61 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369315.600661 (Exim 4.92) (envelope-from ) id 1oDLNz-00031m-5r; Mon, 18 Jul 2022 07:41:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369315.600661; Mon, 18 Jul 2022 07:41:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLNz-00031f-3F; Mon, 18 Jul 2022 07:41:47 +0000 Received: by outflank-mailman (input) for mailman id 369315; Mon, 18 Jul 2022 07:41:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLNx-00031V-W7; Mon, 18 Jul 2022 07:41:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLNx-0000T3-NP; Mon, 18 Jul 2022 07:41:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLNx-0002Bf-84; Mon, 18 Jul 2022 07:41:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDLNx-0002mT-73; Mon, 18 Jul 2022 07:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OLDuto/ZVW70fbBeVAfSkWo5eQDWearXjb7ULtHt/eU=; b=b3KxPiSYgpnOJMoEKftcrdv13q lAfsMm9ivdBlvtqE/wMR9Va03gEwNImLicoHOZRWvHdyjTyYCXfE8VlOj9ToJnYG4ia/2ta72aqQr FWuvgccFtNgU76af3lqGUzvs1T7G1NiRhJ7FJb9qfN3RnOVKyTy9D+GcWy0u3De9SVt4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171667: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=62ca3005307e9b07ebdcf09ac9742c8f8be1c072 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 18 Jul 2022 07:41:45 +0000 flight 171667 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171667/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 62ca3005307e9b07ebdcf09ac9742c8f8be1c072 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 738 days Failing since 151818 2020-07-11 04:18:52 Z 737 days 719 attempts Testing same since 171649 2022-07-16 04:18:59 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116192 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:43:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:43:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369322.600672 (Exim 4.92) (envelope-from ) id 1oDLPr-0003b1-Hv; Mon, 18 Jul 2022 07:43:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369322.600672; Mon, 18 Jul 2022 07:43:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLPr-0003au-F5; Mon, 18 Jul 2022 07:43:43 +0000 Received: by outflank-mailman (input) for mailman id 369322; Mon, 18 Jul 2022 07:43:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLPp-0003ao-LA for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:43:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56a1ad13-066d-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 09:43:39 +0200 (CEST) Received: from AM5PR04CA0033.eurprd04.prod.outlook.com (2603:10a6:206:1::46) by AS8PR08MB7920.eurprd08.prod.outlook.com (2603:10a6:20b:53b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 07:43:37 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::f1) by AM5PR04CA0033.outlook.office365.com (2603:10a6:206:1::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Mon, 18 Jul 2022 07:43:37 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 07:43:36 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Mon, 18 Jul 2022 07:43:36 +0000 Received: from 7b4b9f32162d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D77B9C93-39D7-4EB0-8EB2-B6D9DAF25473.1; Mon, 18 Jul 2022 07:43:25 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7b4b9f32162d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 07:43:25 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB9PR08MB7866.eurprd08.prod.outlook.com (2603:10a6:10:39d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 07:43:22 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 07:43:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56a1ad13-066d-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iWFDq/6n8mTWKPCZEUkA3sgVgGj/XK66m9dI+Wxfp0mxuV64RSYN/3OsKwizs3yEQLgk8JpsOiZcz30iBTdVXpd6dWATtdWN8A3PkMGfpXEYstExAU+3az0HkCi0JN5oGnAmvPxGESl+9ifXeZvWs81t1fPxWzwre28AOrflglb33+RCdvaqdNDbIRCodFJqgnBGv+52OiHYtO7bed/27FJKmhFGZeSHsvdZnLd/UN6cGE6SQ8/+cdsOahSFJWqQfS50npGHZb1vPOKKnr726AgOgQRYY9V3eSG9E+TPHWodwti70kJiQ7lHU4lyUBpQBwzU5sfh4XOwzAuT4humbw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dkLTIi9YPTdoER/M+4E9T371U0Kg6Br5yqlWc3SukQw=; b=WkAQUrMlLxAOsyQk5Ly13BEcmySIgTitjedCR/qtBP07jDUNHJwsyfRljVaf2kmiddO4KFuOtEUOfmUUsxnw+HisHgGQ0pQV8R99rWXwnWWJGF1UwVHp+sbqhFM8cgtf5VTkSM5j3ZlyOvOtY88P6KrlYN8oL6lYNgAXKSDiVMITlPoiPFFx10vV/q6RbDgLtkdTTNj6xAEgeatoWBWXgqhB+tROAuXJUxBtFcqbfjZHcHd21iA97DpS6ysrfQEZI/XOdKQMBbWQTbl3PZFJSBqoZOaRgMAc2tXC3LksJyIJEP79e8WgC4EjjdlNmki9WOUdFlK3cLJ3MVqFVnzSBQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dkLTIi9YPTdoER/M+4E9T371U0Kg6Br5yqlWc3SukQw=; b=L2xG0ADs2SSEA5UOHJrDJvc5HHenVm7QvYjMUDiW/Ye9izVyA+pk7Sqh6YsqZTyQGSw2FzWyFx/fnq6mGVUDhXZLBeW+3Be7m8dan82du9sxx+B+zm1pD2ojAQjBhKWYgXjrSsZeT7+BxY6IdSycQ3FT7Wr/LwaPjsoHOgAgTww= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8a984f2f8e8e1fbf X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IGu6YSF+/U+LdVS3VTdjarNyiRCw8j7LMjjzRZZMoCK9ZtuRIMxaANgZGs1cToEx8hQMfR7wkrp5YSpDI2xsfEXhXJZ0pfj2CC3YTFXVmS5hnuufmMjGnjAcIJaHQJoj7+LV4oD7owPN83/XKDsPRJiX1BWViPV3zUu1iGnPqskDsFKF0t0wHftgkHTnReke+P2VyZQluqYr/GK4MTD5IL6tVA4aA1cDLtK9maAyeDltJQ7WlNxHerexBv5pGPYQG3tieqHZTvs1O01PH4RjaXZ8KIhT5h7JvXZWNX6ceioyyjqQoagqkRcCzCdswSJJs1ZiASOtVJ7nsJNJWYxsuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dkLTIi9YPTdoER/M+4E9T371U0Kg6Br5yqlWc3SukQw=; b=Dkfa9CsKNHGkDQL7XomXaqFGIwjuSpaPd8eOgoN4mV/2VS++YRQpdoHLppQOnxBxK8PqHMS94+3pbdXbJYKgh6BPPGEesaLVovtUX/WOSc8Z1FciM/dDKRtL4aDg4gMZnLRFIiqeK9upw+0NLnejXdIBKrJ6axffAREtmlQZ3sbep22ICubvg76FmXpwxaEvu6mP5AuGc38xdWxoBHst/M259urVNU/TAO/k1k/5w/89cM+ho9vBs43AyEnSFu4joxRLyVMWoSTNYOqnLipRXZ/kbqqVn//sbW1V1DZiUIsfSr2ubYePXKoHEptPCTzdtT+xDA5GEgaCrISmjkG7VA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dkLTIi9YPTdoER/M+4E9T371U0Kg6Br5yqlWc3SukQw=; b=L2xG0ADs2SSEA5UOHJrDJvc5HHenVm7QvYjMUDiW/Ye9izVyA+pk7Sqh6YsqZTyQGSw2FzWyFx/fnq6mGVUDhXZLBeW+3Be7m8dan82du9sxx+B+zm1pD2ojAQjBhKWYgXjrSsZeT7+BxY6IdSycQ3FT7Wr/LwaPjsoHOgAgTww= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <911597d8-4655-6963-853a-7088044a3e20@arm.com> Date: Mon, 18 Jul 2022 15:43:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Arm64's xen.efi vs GNU binutils (and alike) Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <04b5e393-e7ad-956c-dbea-8203b6846726@suse.com> From: Wei Chen In-Reply-To: <04b5e393-e7ad-956c-dbea-8203b6846726@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0158.apcprd01.prod.exchangelabs.com (2603:1096:4:28::14) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: a228d8b1-0ad1-47e9-2ece-08da68913959 X-MS-TrafficTypeDiagnostic: DB9PR08MB7866:EE_|AM5EUR03FT061:EE_|AS8PR08MB7920:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: f3ZBe9qCm7LLJswV81TPbDTr+9oIv7N+v/Fq94rF8bNTdWCF3I7to+B2c8e8btPX4V8O+nCjAfCr4HQgFym2Eye6d649+YOlbvdrNq4AnnmoEBfFUteI8F5DbgOw5aS2JeV8LnYbPLYGtUWfFtLQSANMS04i7Tcgz9K+a3t77d5YDMWiqZsdmIhY07rc9csbA8sscxrHPn5KwNAO59ZaESB/Wb/9w64xQ4OkZxiXiTTziSMRAxw7M3msmc73udX/r4PrjjBf3P9cmwhrEE7mEMgtZ/CsIudrUm4Acz80V400R0rPvR5yTPUz3Lz336bWfDUAtIqWoAaQzNlbnI6/9y2pRfdiMmNrHJEsSTVsMQnmSz43bMijkLk2KiaNx4HWXK68hcLIJg3zwq4f5Q+1H7vDWzcfzl2ZZTJOnO+Ax0irTlwqnYoS420UDzZvW4sSbiljdWqIFwXBx59mMUdr6FBUgjIKu+7Yi35pKn9bAbJopgYfEtJJJkaj5dLIEF1GlQwCliw0LZOWZ6A6H1eAiwu3DiEjtLbvpMi2k7hFT6ILmH7dC+AY9kScyI/7MmJ4PrEEk9q0BBl+S3CopnUWwmko2dCmABA8zLtGEwhviv4k2KwXit159juGhIJ70nApTEsz/vtRCHq/Kym/esLdirA5dcXXOSZi2hF/4IQ6TpdBPD+KutvWdgCUkzBeodPTjGUFz7iP0+gbEwhteF4gFI2Oz6xAkviok1kE86UVTwfz3YD/C0cBgf3ejeW3x+5DHbLYmfEhEz4xFyxpBmtY3Voxt2rfcLVz1N8G7s8FRFkz17zuNnq+KvelBR+2F//AMMi8CK8CJAr+WcHfGsEPoONQmUICwSwnk6I23MkHOnw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(316002)(31686004)(110136005)(36756003)(54906003)(38100700002)(41300700001)(186003)(2616005)(4326008)(66476007)(66556008)(8676002)(66946007)(2906002)(6666004)(5660300002)(31696002)(6506007)(53546011)(26005)(86362001)(8936002)(6512007)(478600001)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7866 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1bbdc4c8-7a63-456d-3d35-08da68913082 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ssETPKoUWghpC5eao0hbVOQL9WQqkPWVQLsKIRXvtafMRND9/3aDI4JxYC/2cI7auH/hgcUNfVEWqOBF9TLN3XQILEUXparitO//ZHaMgbeskfU8jYxf8CZXZiLS+ZWad7T4cA3lsVWwjdD4BDSJ1p0QFXJF+gdb/aaOG9HOleC9LSf9e6tx8rWOB/8W2fcC24mZpGeE/Zng0fXTtiIwdP+IG7ov1nsoR7GOD1WAY0JRr55kTadefwSMG1Tjg8I4VVyaszWVgkBk1T7hgGQQ9AqoNbOozeA05lcayYus/qbYz9WycMkKLa9okb+n0QjtWe/Lz4CEiXzXTq48Owd8wrasFosoO5ZJxuVH7++thqsaTDHYPmUEMzw0VUrjg74M3K1ToqwxO07TSAKlC82mhxz8Nhpd7D+jd9sNtctOrDetUeHHENskpDOGtCMwO9tFyEVIV+E/EgGsviCth3iEaAuAu0wUm+d/FRVWWEM8ZytWCiAP6nB4761jaPf68NhNHmccGT2065o9DjWDC+xh7CuP16pgDiIuP5ymhwDd83NpgLqBNZcY16qsiwa7/Wqf6dq/Z++BFOTsZMsE2V9CZW8eoodOohq523ZK34CMTEk0toUwoPja9rxOZArzTJrfy+5mtb57pJ4Os4ye9pJEdu55tNBo9LRnHnGVr0Fe7NOsfPBdWOg9Do7x1dZ8JbJqXzfwlzE1TAW1Caifpt7Y6boyovZOfhgcIOAxlOTg9+ofu4CdTymfGx3a+krIZfG7mqy0YTX4b4cyS9PnLokI4jgDiYSl1r+aMUD/B7T2JcIvw+dinYqxxoJSOZM4b9Ug7bCIg/xjaMW8eMGmt7JleRFNEDC9DmU0y2/M6WCCI64= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(39860400002)(40470700004)(36840700001)(46966006)(70586007)(36860700001)(110136005)(54906003)(4326008)(6486002)(8676002)(478600001)(36756003)(40460700003)(70206006)(31686004)(41300700001)(316002)(5660300002)(8936002)(2616005)(6666004)(53546011)(186003)(26005)(6506007)(47076005)(336012)(6512007)(2906002)(356005)(40480700001)(82310400005)(81166007)(82740400003)(86362001)(31696002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 07:43:36.7414 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a228d8b1-0ad1-47e9-2ece-08da68913959 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7920 Hi Jan, On 2022/7/11 22:32, Jan Beulich wrote: > Hello, > > the other day I wanted to look at the basic structure of xen.efi. First > I used my own dumping tool, which didn't work. Then I used objdump, > which appeared to work. I decided that I should look into what they do > different, and whether I could make mine work as well, or whether > instead objdump is broken and shouldn't work on this sort of binary. > While I'm not fully certain yet, I'm leaning to the latter. This is > supported by GNU objcopy corrupting the binary (I assume this is known > and considered okay-ish). > Did you use x86's objcopy? AArch64 GNU objcopy does not support any PE format file. So I'm curious about the version of objcopy you are using. > Many problems boil down to the (ab)use of the DOS executable header > fields, yielding an invalid header. The first 8 bytes are instructions, > with the first carefully chosen to produce 'MZ' in its low half. > (Oddly enough Xen and Linux use different insns there.) This doesn't > play well with the meaning of the respective fields in the DOS header. UEFI executables are regular PE32/PE32+ images, Arm64 EFI applications use a subsystem "0xAA64". PE32/PE32+ require images to have a DOS header for option#1 backwards compatibility,or option#2 to prevent images to be run in DOS. I think Arm64 EFI applications select option#2. In this case I don't understand why we need a valid DOS header? For my understanding, we just need 'MZ' for file type identify and "offset to the PE header". Other fields have be re-used by other purpose when load Xen image as binary. And lots of bootloaders are following this header format to load Xen (Linux, or other Arm64 OS/VMM) images. Therefore, it is not currently possible to construct a valid DOS header. > Subsequently there are a number of .quad-s, some of which again yield > an invalid DOS header. I'm therefore inclined to submit a patch to > make objdump properly fail on this binary. But of course with both I have not used objdump to dump xen image successfully. I always use xen-syms for objdump.Sorry, Maybe I didn't understand your question clearly. > Xen and Linux (and who knows who else) using this hairy approach, it > may end up necessary to continue to "support" this special case, > which is why I'm seeking your input here first. > Yes, like I said above, most OSs, VMMs and bootloaders currently follow this format and boot protocol. Therefore, it is difficult for us to completely remove it all at once. > Furthermore the fake .reloc section overlaps the file header. The > section is zero size (i.e. empty), but a reasonable PE loader might > still object to its RVA being zero. > I am not very clear about "overlaps". Is it because we are setting PointerToRelocations to zero? Cheers, Wei Chen > As to objcopy: It shrinks the binary significantly in size, removes > the dummy .reloc section, re-writes fair parts of the DOS header, > and extends the NT header resulting in the file position of .text > changing. The size reduction and possibly the movement of .text may > be okay as long as the resulting binary is to only be used with UEFI > (as it's due to zapping of the embedded DTB and the unnecessary zero- > filling of .bss, afaict), but my understanding is that the other > adjustments are all fatal to the usability of the binary even on > UEFI. > > I may easily have forgotten further anomalies. > > Jan > From xen-devel-bounces@lists.xenproject.org Mon Jul 18 07:51:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 07:51:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369330.600683 (Exim 4.92) (envelope-from ) id 1oDLXn-0005H2-Gy; Mon, 18 Jul 2022 07:51:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369330.600683; Mon, 18 Jul 2022 07:51:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLXn-0005Gv-Df; Mon, 18 Jul 2022 07:51:55 +0000 Received: by outflank-mailman (input) for mailman id 369330; Mon, 18 Jul 2022 07:51:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLXm-0005Gp-J5 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 07:51:54 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20071.outbound.protection.outlook.com [40.107.2.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7cef50cd-066e-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 09:51:53 +0200 (CEST) Received: from AM6P193CA0053.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::30) by AM8PR08MB6628.eurprd08.prod.outlook.com (2603:10a6:20b:362::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 07:51:51 +0000 Received: from VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8e:cafe::b6) by AM6P193CA0053.outlook.office365.com (2603:10a6:209:8e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Mon, 18 Jul 2022 07:51:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT005.mail.protection.outlook.com (10.152.18.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 07:51:50 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 18 Jul 2022 07:51:50 +0000 Received: from 0579016e35cd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5100EEED-9845-48DF-AFCA-2F06814DAB20.1; Mon, 18 Jul 2022 07:51:44 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0579016e35cd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 07:51:44 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB8PR08MB4124.eurprd08.prod.outlook.com (2603:10a6:10:b0::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 07:51:40 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 07:51:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cef50cd-066e-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=A/a66/Cah+Fgtu9PZqo2fSCabBRv+/TxX0u5z7cncub41iGxWpnqkdf+CjccBzaw4w3we1OCAOqxJoLqtuo7XkNejP7JLEiMFHn3/iZHo2i1I8uVQIKkbCE/gmPGKckSzShQiQ2GCvwCFAwF9LgqjZwsB+9tIAfvwBRjl3lFcnGAdpXoKT5YOsamILrtCPCnUsiR1XNyXrCKRiZtxZIN9CqnTfQ4ru2rWzLmx9s9VdMGCnF3M02zVvxcUDoJ7sYt7iFOKWDz/Ojd5uTH9zC5iUEhVGZrxcDp3q3cuPqEsCZJfQkRUtYAA6ezRWA0t2cHEg3pQfVM3PhayUpqQk8aOw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjGx78bJnWHhRzsa/su5yBPTVwWm1/fIEMhsXv8gEOc=; b=i6UNPV3SIZKPQX+IW6cT/g6eivJywfmgU2kPFHn8BqKfSKdLIZGy1g3C/zGgsRuAk+Yo73Az+qcoVk346cq+iWYadEJj9Ecb8FC7OylUQBajDio/bjFfAsz20O/8f2ZPY+0OsJ9NqT9EB4g74ARzSy4rVrAZVQ/ME9Tdsr4Txeh0asIMImUFwOk7H7/5sl3I/buqX8KeDhFivLTvMSiUCUHnpr121KkUOWSc7SSNx8mXgV2bGLXuJiZGSiwrxWIOG0TQlspHgClKbnaJUeeyOlnmUWTOi6nPdhf+ec+0cKmqKGg+AGbxVZddPrksbX06saJ55Q/EEA0H9gSoLOfc2A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BjGx78bJnWHhRzsa/su5yBPTVwWm1/fIEMhsXv8gEOc=; b=SGwHRILjXRF7fIpcb2eZsq8nR2M+ZfXLJWcvvGXvM8MO70ETY4SHIUTdQ4ey0FSx0oA3anoWZGFGVl8UuhxViyOo1K1wE1TSGxahATt7cYE5fH2iSO8UhhXi6eNe4BYpH8/yuINIo7TI5uXYO81M5mN/51C+XprZFkTpS6O8GCQ= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bSlBcItPErkvBfYfUw6PzuRPhfU/L/hiKkTlG9dHYc8FRN1h8utnJTFJjAeKQ4HYx2g2YJTCIZm6+zxj/vqXtgld7Tgr8Num7E4TSEi5j6ueF0V+s0E1va+h5oLkr1myaxdr3PjeIvZvmRpGhCqbqvXUJ7b05tEpoxnykq62xUuACiwfs12SQJ6mwr7aUNTM4g9thfkp42z6oFayOcWxI3hOQ98URU3P6FWNbx/0aEu53uvvgaKW+xki4+h/mzHRAkL5uESd+nGmqseC/MG+q5tQ5T7Yl9keFD9btmtPxSqpfY+Rq2GQg1ldVKnafxEpV71LLh4VakNEXfdnoLbMTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BjGx78bJnWHhRzsa/su5yBPTVwWm1/fIEMhsXv8gEOc=; b=Bbev20bPVoxP35xu5H12PeHTGEOWitI53R7h9VKFtM5mPyEG6oD0YBP/INaOc26EUWwrM2ewG3df596+MJGDRxSdTrNiioYqnQ5LERHSxhVPXPadYMDsfERi4VbFnNnUMxPZFeXKrD0UyfxOtzs1Q9Gj5STxOMo/TdxT7Lkf9gAA5e8r+qLeHUpOdeZAerNd0hLNhX7WoThfiNHyaNc9eEf7hEpH+95NOddDi+c0GlPujI2vpJacbKFjmkL5Ni9xxG0QmfkpOfJL2w4Jd79hosha9Y6/x1vF5R+x7UpTXUeyjWIQmIl2rfau7Znqy702UhqOfhSm14Lwwmxf4ChUFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BjGx78bJnWHhRzsa/su5yBPTVwWm1/fIEMhsXv8gEOc=; b=SGwHRILjXRF7fIpcb2eZsq8nR2M+ZfXLJWcvvGXvM8MO70ETY4SHIUTdQ4ey0FSx0oA3anoWZGFGVl8UuhxViyOo1K1wE1TSGxahATt7cYE5fH2iSO8UhhXi6eNe4BYpH8/yuINIo7TI5uXYO81M5mN/51C+XprZFkTpS6O8GCQ= From: Wei Chen To: Julien Grall , Jan Beulich CC: nd , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Topic: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Index: AQHYktrGRUcF8MDJDk6LN0+4egi+Ca160z2AgALXevCAABQigIAABL8AgAYMPgA= Date: Mon, 18 Jul 2022 07:51:40 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 954B3AF06E76EF4583D800EF0DF16378.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b6e411cc-64e4-4529-5644-08da68925fd8 x-ms-traffictypediagnostic: DB8PR08MB4124:EE_|VE1EUR03FT005:EE_|AM8PR08MB6628:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: af337b/Bp6H6xyv1c/Z+AMowQzAKdUe7qd1XHF9nQbSSn45lM8fky9cMyS2P1+ddQjJO9YVg1gfcCR/UB61fhzi8tIzD9NjdIVF1Pz+4lWQXfeiHX9pEC8LAM4fjnlj9Wdq1f3nL0SnYd6BZvpWKaBh3RAqscxZLRHuChhSNA6d/kIhEGmPctatmDm31RU/nuaJwEzsgomlTK5vMI6eRj+kr38rCHgSoy/wjFvfw1x+oQw8gSHg6L0EsntCKF/b7GH7+Xr8YsfE4tiJRcE3qgWnI4xczaK3T5n2QKK5Ik/Gnef6+ns/o0Fa3jsws9jhV8o5DgPwiiJiBFV2QAXzdtL7w/vyF+4Ku1UH/XOgXOHnYp3cM7xwnyNbTrFP0LveD7fSnfhzL8/OSOUOezfssiRB0lGbjTYzt4xe/incapo7fxDdkF8O3rZ5wmd9ACxVHi7qB+95FmJdAITzJzonH6w2LkSxIDfmsywtv4373X+Vb5NMwqVU+dYCcCAwvEMqqw1smKmGeVUoK5Iyx+r18Jxh8weR3KOazBORFhXHb33dcRGcqhbB6JTRthE8wbdh2V10ESLZRWRhXwOJRWsk3wRIQBTy7NEURcPw9ogGIO0S6ObaxLi6/jNFPfoGqCFEB2jRrikikDSbID2eEYLvv0u+4q5DdolETYXDMqBheGo8j6gcglE4KqcQ4TUSk8fIFycr0buSG/NuWxXtKy0/PZRyOfDp1Fd4Kl/3WUM0QbsMHXPJlqRqPI5I7yGwl+chBAz14In2OQWpr9N4hPjGHp1rYouD4NTqzQ7l6mOkXqPpDbF976wJG71XIr8rztoQW X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(33656002)(86362001)(52536014)(8936002)(38100700002)(4326008)(8676002)(64756008)(66446008)(66476007)(66556008)(66946007)(76116006)(55016003)(38070700005)(110136005)(7696005)(54906003)(53546011)(6506007)(316002)(26005)(83380400001)(41300700001)(9686003)(186003)(478600001)(71200400001)(5660300002)(2906002)(122000001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4124 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 97dbad04-34c9-42ab-cd57-08da689259c7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FNxiVKCxesET/jdQyZg7236P/2slIpiVD+rF26SxwPSqxO7oyQzNlstYqWBOel9WxsIWcNya2PXsqo4YKmsI5KmAeVsakBhpafSGlQsWsHklcAxpnsOt12sVz9kek5K7p36uED8+JXuROSMBa7hxaqMz7GUKdEq8P9SB9xq/iYpu0hkGMnd0sOJVfC1ryjXVZar8kHE6ejZDdi0IlUuAGVF2xTDwcQD+c6lx/UgwbVmurgr+3yg2RfvvDbaYtktWzQU/h7Ee6nqHr9CZd2/CP/BuVs2sMx9lRv+ivnoY5yWs5mOODfxOubnqL1R+SumsaKwB6vpYiRazAzHZ/CXvySugTkaQvaWtfkpMXP0y2f7VMOCKj7D9CanDZ4JGHccTA4MnXmDMlaT53dd5/L18FaMH+QlnVsZlcDXSd4DOtbcxQdirGBEtWU3WqhgSWdJDpcfmh0g04XMIqyRCjwqCCzuBk2tb/vdWlfqO17y/HmFXKQ8gR3WE0iFBJPfFEI3NDrpiCMb+o4dIEvp441Jv3JUw/CRm0upKnbiCe3kozr9LhdFWncDDeX/vu5X2sf2QgIKKWrndva3MU8y2NJCoVJVfhIiYIPBdvubaqfrpdSbYegN4x7gdbbd7ef3MZk95sVMeiL4Q91BugOryuFGfmmL9nqDGgM/n5S75rWggAbLeVtCO/1wi1rWCqd2xEIq5mUnAajPeO53zUnMDIyArnhWS53eesCM03OqvvSPw+TyAgPTc8LnpLzEeqisFXuuDxKBRJNv1fmIsaB7xcgITs6UbPYqCdY8BNkrvBvZoGAJ29V+fMToWuMW1CJD7zItd X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(36840700001)(46966006)(40470700004)(478600001)(41300700001)(86362001)(6506007)(7696005)(356005)(54906003)(316002)(33656002)(81166007)(82740400003)(9686003)(26005)(83380400001)(186003)(336012)(47076005)(110136005)(53546011)(82310400005)(4326008)(40480700001)(40460700003)(55016003)(5660300002)(8936002)(8676002)(70206006)(70586007)(52536014)(2906002)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 07:51:50.7770 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6e411cc-64e4-4529-5644-08da68925fd8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6628 SGkgSnVsaWVuLCBKYW4sDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTog SnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4NCj4gU2VudDogMjAyMuW5tDfmnIgxNOaXpSAx OToyNw0KPiBUbzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPjsgV2VpIENoZW4gPFdl aS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UNCj4gRHVubGFwIDxnZW9yZ2UuZHVubGFw QGNpdHJpeC5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5v cmc+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgUm9nZXIgUGF1IE1vbm7DqQ0KPiA8cm9nZXIucGF1 QGNpdHJpeC5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDog UmU6IFtQQVRDSCB2MiA5LzldIHhlbjogaW50cm9kdWNlIGEgS2NvbmZpZyBvcHRpb24gdG8gY29u ZmlndXJlDQo+IE5VTUEgbm9kZXMgbnVtYmVyDQo+IA0KPiBIaSBKYW4sDQo+IA0KPiBPbiAxNC8w Ny8yMDIyIDEyOjEwLCBKYW4gQmV1bGljaCB3cm90ZToNCj4gPiBPbiAxNC4wNy4yMDIyIDEyOjE0 LCBXZWkgQ2hlbiB3cm90ZToNCj4gPj4gSGkgSmFuLA0KPiA+Pg0KPiA+Pj4gLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCj4gPj4+IEZyb206IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4gPj4+IFNlbnQ6IDIwMjLlubQ35pyIMTLml6UgMjI6MzQNCj4gPj4+IFRvOiBXZWkgQ2hl biA8V2VpLkNoZW5AYXJtLmNvbT4NCj4gPj4+IENjOiBuZCA8bmRAYXJtLmNvbT47IEFuZHJldyBD b29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UNCj4gPj4+IER1bmxhcCA8 Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47 DQo+IFN0ZWZhbm8NCj4gPj4+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBX ZWkgTGl1IDx3bEB4ZW4ub3JnPjsgUm9nZXIgUGF1DQo+IE1vbm7DqQ0KPiA+Pj4gPHJvZ2VyLnBh dUBjaXRyaXguY29tPjsgeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+ID4+PiBTdWJq ZWN0OiBSZTogW1BBVENIIHYyIDkvOV0geGVuOiBpbnRyb2R1Y2UgYSBLY29uZmlnIG9wdGlvbiB0 bw0KPiBjb25maWd1cmUNCj4gPj4+IE5VTUEgbm9kZXMgbnVtYmVyDQo+ID4+Pg0KPiA+Pj4gT24g MDguMDcuMjAyMiAxNjo1NCwgV2VpIENoZW4gd3JvdGU6DQo+ID4+Pj4gLS0tIGEveGVuL2FyY2gv S2NvbmZpZw0KPiA+Pj4+ICsrKyBiL3hlbi9hcmNoL0tjb25maWcNCj4gPj4+PiBAQCAtMTcsMyAr MTcsMTQgQEAgY29uZmlnIE5SX0NQVVMNCj4gPj4+PiAgIAkgIEZvciBDUFUgY29yZXMgd2hpY2gg c3VwcG9ydCBTaW11bHRhbmVvdXMgTXVsdGktVGhyZWFkaW5nIG9yDQo+ID4+PiBzaW1pbGFyDQo+ ID4+Pj4gICAJICB0ZWNobm9sb2dpZXMsIHRoaXMgdGhlIG51bWJlciBvZiBsb2dpY2FsIHRocmVh ZHMgd2hpY2ggWGVuDQo+IHdpbGwNCj4gPj4+PiAgIAkgIHN1cHBvcnQuDQo+ID4+Pj4gKw0KPiA+ Pj4+ICtjb25maWcgTlJfTlVNQV9OT0RFUw0KPiA+Pj4+ICsJaW50ICJNYXhpbXVtIG51bWJlciBv ZiBOVU1BIG5vZGVzIHN1cHBvcnRlZCINCj4gPj4+PiArCXJhbmdlIDEgMjU1DQo+ID4+Pj4gKwlk ZWZhdWx0ICI2NCINCj4gPj4+PiArCWRlcGVuZHMgb24gTlVNQQ0KPiA+Pj4NCj4gPj4+IERvZXMg MSBtYWtlIHNlbnNlPyBUaGF0J3Mgbm90IGdvaW5nIHRvIGJlIE5VTUEgdGhlbiwgSSB3b3VsZCBz YXkuDQo+ID4+Pg0KPiA+Pg0KPiA+PiBPaywgd2UgbmVlZCBhdCBsZWFzdCAyIG5vZGVzIHRvIGJl IGEgcmVhbCBOVU1BLg0KPiA+Pg0KPiA+Pj4gRG9lcyB0aGUgdmFsdWUgYmVpbmcgKHBlcmhhcHMg ZmFyKSBsYXJnZXIgdGhhbiBOUl9DUFVTIG1ha2Ugc2Vuc2U/DQo+ID4+Pg0KPiA+Pg0KPiA+PiBB cm0gaGFzIDEyOCBkZWZhdWx0IE5SX0NQVVMgKGV4Y2VwdCBzb21lIHBsYXRmb3JtcykgYW5kIHg4 NiBoYXMgMjU2Lg0KPiA+PiBTbyBJIGFtIG5vdCB2ZXJ5IGNsZWFyIGFib3V0IHlvdXIgY29tbWVu dHMgYWJvdXQgZmFyIGxhcmdlcj8gQXMgbXkNCj4gPj4gVW5kZXJzdGFuZGluZywgb25lIG5vZGUg aGFzIDIgb3IgNCBjb3JlcyBhcmUgdmVyeSBjb21tb24gaW4gYSBOVU1BDQo+ID4+IFN5c3RlbS4N Cj4gPg0KPiA+IFRoZSBkZWZhdWx0cyBhcmUgZmluZS4gQnV0IGRvZXMgaXQgbWFrZSBzZW5zZSB0 byBoYXZlIDI1NSBub2RlcyB3aGVuDQo+ID4ganVzdCAzMiBDUFVzIHdlcmUgc2VsZWN0ZWQ/IEkn bSBhZnJhaWQga2NvbmZpZyBpcyBnb2luZyB0byBnZXQgaW4gdGhlDQo+ID4gd2F5LCBidXQgSSB0 aGluayBJJ2QgbGlrZSB0aGUgdXBwZXIgYm91bmQgdG8gYmUgbWluKE5SX0NQVVMsIDI1NSkuDQo+ DQo+IExvb2tpbmcgYXJvdW5kIE5VTUEgbm9kZXMgd2l0aCAwIENQVXMgZXhpc3RzLiBTbyBJIGRv bid0IHRoaW5rIHdlIHNob3VsZA0KPiB0aWUgdGhlIHR3by4NCj4gDQoNClllcywgc29tZSBub2Rl cyBjYW4gb25seSBoYXZlIFJBTSBhbmQgc29tZSBub2RlcyBjYW4gb25seSBoYXZlIENQVXMuDQpT byBpcyBpdCBvayB0byB1c2UgMi0yNTUgZm9yIG5vZGUgcmFuZ2U/DQoNCj4gQ2hlZXJzLA0KPiAN Cj4gLS0NCj4gSnVsaWVuIEdyYWxsDQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:07:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369340.600694 (Exim 4.92) (envelope-from ) id 1oDLmb-0007fU-5G; Mon, 18 Jul 2022 08:07:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369340.600694; Mon, 18 Jul 2022 08:07:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLmb-0007fN-2R; Mon, 18 Jul 2022 08:07:13 +0000 Received: by outflank-mailman (input) for mailman id 369340; Mon, 18 Jul 2022 08:07:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLmZ-0007fH-N8 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:07:11 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50052.outbound.protection.outlook.com [40.107.5.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ea2b51e-0670-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:07:09 +0200 (CEST) Received: from FR3P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::10) by HE1PR0802MB2363.eurprd08.prod.outlook.com (2603:10a6:3:c8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 08:07:04 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4a:cafe::9b) by FR3P281CA0047.outlook.office365.com (2603:10a6:d10:4a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.10 via Frontend Transport; Mon, 18 Jul 2022 08:07:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 08:07:03 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Mon, 18 Jul 2022 08:07:03 +0000 Received: from f2ad9da0c612.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7C7E0122-8B8C-4601-8D89-F8E9CF8CEDD7.1; Mon, 18 Jul 2022 08:06:56 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f2ad9da0c612.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 08:06:56 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by VI1PR0802MB2367.eurprd08.prod.outlook.com (2603:10a6:800:a1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 08:06:54 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:06:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ea2b51e-0670-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=A+y0QDEL0lXX4i7fACShDLGiKJgmWyiJiL1rN0m4kryVbTiDFLixJrpmLw4jpkgXwBHLC0EEN2Ek6AiZI+bQBKrtT3RaDa2KHTCCNoZbn3rRYU4HnK/X8/NXEHjIX1zx0hRMpWNVhNyazc6ukYOWTQVWe3Oes4WgRAsEMY+ITzbW/In0Qbg8Tk5SVCvNd3xHF5R+sjKjZixTky1CKquPxZtVavY13R0DMTgTSv7d8IA70B9DhZdT86Sb8l4MHFMw+VxcUgNLR71Q7YfijtodwTEi5VqPRPd7aV2ZjgWm/uTpgw6yqWi+KSvfPGqIJMFiRpghqjbcstTKPjmn+L6AXw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RG8CVJ9twEL0jibBQYHZJdG7LC/Za2m6QYKX22a9tcc=; b=KTFH4Esw9VllXXQGNG/7rqOI4P7VsISJ+u6Y5V/pVjwvV/BkJ/PGa1wFoL4fTQnS4k1v9kzMrLKr0XMhCtX6f7Sl+/sEe/SPAGE5kmYIZ0sdMQFJzrzo1AzB6Cn5Q7h/lZmxzEKzxDj5vgjap03Ih2HB0AS432l5MVEOiHqDDpCuvyWUcb6TQQcye1Xn4djfkSEylbBy7sg+9G1iOafudmMx6c6Y5ImUOxc5OmJ+p2cl1A96notdpWUJnXAVrR2Jk5udL3IWGyOuw7u2UrLZay/9wy9y2PjjVFKbhxVJeOTBtVwO2bYlw9C4mBJSt8nlHb9BmU1mLMHD3U2JsXOe7g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RG8CVJ9twEL0jibBQYHZJdG7LC/Za2m6QYKX22a9tcc=; b=je611WXgoGGtPbesQ7XuX7OqTHgHfSeAfsgbibiEb2Ez0CWOXp7SsMxMVt1GyJ2UEBC1TYlLC/CloaBLvGxrz+9Lc8Xw0vWLM1mjQOOSS5vB+8lxg5veeKIbz/2SYFQFu/Lp2mcy8GAZbtVg+vhmpnvIzO0ntA0Yo/f5dS9vlV0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ab111e52c8fb7c37 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y5tiM9DfloIyvhdU7+YsiG8gux+F+gN7Jvp16D3SVwAb1C6OPqXCS6xJuU4KHU6EKkfooDmzyXAxLcUvGRsIjykO6F6Sm89YgGWQcsz0wVyS4czbv5rDzdKhWySAiN5ea3YRFk9EaHpGGJIzTqdUqeW8G716BUQPZv3ZeEJ6QlLYrq5zPXZALu0Fc//QZrMr+YFbdOFrN0Eq7IIOtnVDh+O/62FFdjfZRW45j5xf8QlGD0uakohNb96idK/B0PytKp6dn4K2sUwe5NcNY5KQcV28foyYX/vmvczfEpzHUPs1l4qzlcCLAtIHToQAW+XGVyeeDvcxbogKzL1aSwxkPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RG8CVJ9twEL0jibBQYHZJdG7LC/Za2m6QYKX22a9tcc=; b=NyTIhJoYfBjqVLwDDIdTym0mFptY7ZyIVUo1pO7R+yLvZFSd/mmlTeCtX6zpS5h87eMyomLQZx3FgyCMyP/ScNg7/gbD0AC5mbJQ2cHPXsJq3MIAv74nLNm3I+8qbgLbXK83vaQcBBfQW0UEQvFhnn4coc05cNd95L5RwLAjA0qAetgPlvADzNJ3G87h5pn9t2la4U+HxxNe+/ld7iOFOd0jwLau/AiqpC2XHqnh+bi2k3F1JH3M+ntMGGfu5HzHZ1kfRmB7QsohrXcTGak788it/My8UBSZJ8p7CZc2G7+iyHBevU8uqMglCj43TYu15xeLVJdVV7Ve/0EGfZCD6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RG8CVJ9twEL0jibBQYHZJdG7LC/Za2m6QYKX22a9tcc=; b=je611WXgoGGtPbesQ7XuX7OqTHgHfSeAfsgbibiEb2Ez0CWOXp7SsMxMVt1GyJ2UEBC1TYlLC/CloaBLvGxrz+9Lc8Xw0vWLM1mjQOOSS5vB+8lxg5veeKIbz/2SYFQFu/Lp2mcy8GAZbtVg+vhmpnvIzO0ntA0Yo/f5dS9vlV0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <0ddf67ce-fd63-9331-2579-9257f08a8f88@arm.com> Date: Mon, 18 Jul 2022 16:06:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/3] xen: page_alloc: Don't open-code IS_ALIGNED() Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-2-julien@xen.org> From: Wei Chen In-Reply-To: <20220715170312.13931-2-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0054.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::23) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: c0f56255-b68d-472e-272a-08da6894800c X-MS-TrafficTypeDiagnostic: VI1PR0802MB2367:EE_|VE1EUR03FT013:EE_|HE1PR0802MB2363:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AQilLFVmbvf2kfYndEZhyCrD8raeXr/j6JMZsHytAf9EPKh7ji5wxgsi1CWo5Ago25KmTStEk/Evqq/3WdwRdyhS9XrX79PpeNw9alNV/UMUyNLyCPrO39T3saMMPJhaAhO0+JwhpDEF2TWdE3UzFMKN5HQM/TMcv3N+xmbWcvMI/geYDY6RBNSZI5I4thP4o9LbQCIkKA26rOWKNN94ly/sjpIkd7aLlUz2RrVnzzYaK/zXFongnAfLypAzN/MYVmB8eoyvGB4zORutUOCGOwIQFe0PH2HBfvkLm+tyf1oQZZIEftaygdT4Xgw0lVuf+lkAIkcL+oM6yQe0topAD5pNmEkSwGv5LQi4iWXF43CETQdKcRcvGDTx1ZZgEVV+AMg6l1tyIc7Uis2oHTWyP3W+6j0Po6+pgrSI1YgRV2w0/3KMETTTTg44ONSndiZPdq0UnD0fyJ3BfE7Rlr/g79o1/EkRL+SsAwYDmem5kOUOQOt1AU3tysi7LeGTS4hnqCUI1gba0DqJ+qdlWcRTOYZe2i6ME4YWmri27nX6mbaE8THtwq0TNCPcnSfJJI2yAkN9cXouoGxanCOsjY/ncoP5SGHIMKR4O9dQ+Cj6ZR6BNUw2qUzs782SLR2BPvNv+ALeusBKDWN2GkAN3koMRtytZxjL6CcZSRsDDccWf3M1U2/O8LkwiY2klzSVA1gXNxT94hs+QlhZPkSStOLA2sRrl1StksF5udOBeAlDJ7/RG30lLUlhdRLGFB2xFtkrLalGuAYScwhStoRHuJ+OEcPfygBfnYBkhPP4IgnQ9kVeAj9yNNc2VA4iyb0GCbKdAMkpmk+xN9A0o8QPuM4o3pCKK+ZOtarg8lOzGioYIp4= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39850400004)(396003)(346002)(366004)(376002)(136003)(8936002)(5660300002)(31686004)(2906002)(54906003)(86362001)(31696002)(8676002)(66556008)(4326008)(316002)(36756003)(53546011)(26005)(6506007)(6486002)(6666004)(41300700001)(2616005)(186003)(478600001)(6512007)(83380400001)(66946007)(38100700002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2367 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d978f912-3544-4ef3-1076-08da689479f1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zfol/JmEmi316PQ20csRuEkAplTCBGR59ka0LRbJwJ+gtirP4c/6zwA+Qhete3+Gptb5R8tAOCmxPWkum2MUu7nd2SUCoHRJWzBDUaQlT++34AmNJ5Lw6tyMnM5EZVu30HxKhMQy+0L2MO2heytfyX6UCBjFA8b60HJu6H1gY+MpnpQgnq+02iptyfGp14QM38aRhgIfLjv0r0pP8HwuskHZR9C4iCw9OYaVwbdS2irwQmMv0QTjR3iq8r3ltFE+JLIrAp6X/5BuBnGKgyE4h9M+cMcsYIZRBp8UydV2VCbW3aEzqbBeET7X/1e1jrAYh5tbr7pNWIw+ybrHCBrK39b1hW+yGIFdIeVQxjAwJFh1nfffEgARshL9b45BdNx214geueGd5cASMXjjgpL1KdPbO8YZWHuOrMp+IYO5MEc9wkN+YsQGV3qTDnQCSAPnPDtlFFEgmW+slcmZIerKS2a9+UWeqUK+fn8cihtrAapcf5RJRxTyqeCtrXFz11aTC3uAM+aYrqAT0QH4P7d4HnZtV+B6ZyPi8OA7jrgY9hNHymLKEWSQiyE/BLet6CCwoOJurq3oGCGTrtTzIJ4gBWpanCp2yL8y6Z8iRyRC8nzc7zfZwk9ErB8HgxsSKhAYxBEyG9ShYvutl82ENpXFNE1oHSlef/XLCayId+DH2PJV7avyyzRq4f6aaQfQtAzGAcuDopp2LBBEKR55NYxQT+A4FjYPMr/h7tG3BgHU23zxKM6u7quAjsua4ZNFqYignWBCzVdcOGluOTKoL9yO0yRKI3UwuVFLcF2EvL0cY23ah30Y672KlVvCo+qBoeNCc0E3zoB0sfOsDV3hzKyebulIe70LfQFX+cUpxPJaV3Y= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(136003)(396003)(36840700001)(46966006)(40470700004)(6506007)(6666004)(53546011)(41300700001)(6486002)(478600001)(186003)(83380400001)(336012)(47076005)(26005)(40480700001)(31696002)(5660300002)(82310400005)(40460700003)(2616005)(6512007)(316002)(54906003)(8676002)(70206006)(70586007)(4326008)(8936002)(31686004)(36860700001)(36756003)(81166007)(82740400003)(356005)(86362001)(2906002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:07:03.7981 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c0f56255-b68d-472e-272a-08da6894800c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2363 Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: > From: Julien Grall > > init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace > it to improve the readability of the code. > > No functional change intended. > > Signed-off-by: Julien Grall > > --- > > Changes in v2: > - Patch added > --- > xen/common/page_alloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index fe0e15429af3..078c2990041d 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1823,7 +1823,7 @@ static void init_heap_pages( > unsigned long s = mfn_x(page_to_mfn(pg + i)); > unsigned long e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); > bool use_tail = (nid == phys_to_nid(pfn_to_paddr(e - 1))) && > - !(s & ((1UL << MAX_ORDER) - 1)) && > + IS_ALIGNED(s, 1UL << MAX_ORDER) && > (find_first_set_bit(e) <= find_first_set_bit(s)); > unsigned long n; > LGTM. Reviewed-by: Wei Chen From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:10:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369346.600705 (Exim 4.92) (envelope-from ) id 1oDLpn-0000f5-Qj; Mon, 18 Jul 2022 08:10:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369346.600705; Mon, 18 Jul 2022 08:10:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLpn-0000ey-MX; Mon, 18 Jul 2022 08:10:31 +0000 Received: by outflank-mailman (input) for mailman id 369346; Mon, 18 Jul 2022 08:10:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLpm-0000es-QW for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:10:30 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50065.outbound.protection.outlook.com [40.107.5.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 15d417c1-0671-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 10:10:29 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR04MB7075.eurprd04.prod.outlook.com (2603:10a6:208:19e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 08:10:26 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:10:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15d417c1-0671-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AW2ab3VvzXWWig6m+FcdniguSnvIv2gQI+TWoxT8q0zYAkDx28rhdEl9RZC/DSuLFLFj8dO43KLNwbMxumrVMlQqA6qFKo4Kn1gj3AcNKlS9tfh3bGspWlMNYhkevKC/lPDHke6OcAIhfVcleAXswFTY7zAKsQYq/TQo8LqaH5gBgIosXUOV1QhVOPDmH05pNr9VJwrtQmeIFKxK4wWknBUanu0IeroUdCfOafiqAjNCjkh98qX7scyZHw7pl/1NiGxmhyo9hzURcSBupFD5D+vj5q4xOBN3DwtIX/fJWlXuNr/3L4G7FaQJKzkWIiaUC3PC6wvyAxGb2ZTFkxUKSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OLiRB3NPnmg89a3Id+CFH0yyvip2V4psLbTZNzRF7nI=; b=Kdm1ozieyFW1beb2WlOJurVrsae8veJw1RtQAVWphTuHJA45Qqn3DhYx1jk+nB+H7pl6Vb2DevgCZyaqmiHtunBhysFQiTwoaF5GePdPRFN4b9F2mPASePR/SOZRwqNHiToHomk6tU5VQ0hYgE/EI/65xTIOhoAuECZ5g4CDsUAv8RX9fs141l9sKXIbL5dJY7UwEdNcfYbnmuQYaWucXiDOXqroSgmXoNsIIXISvtDTz2il/ohlNriVyxWW61B7bSrNdZExy0OdZQWQH02DRTkfoetKXHNIopFqb0ikvrrC9EcdnZZJVRQKSB8FI+uUVWn1wO6lEMZDfEpEBqrFKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OLiRB3NPnmg89a3Id+CFH0yyvip2V4psLbTZNzRF7nI=; b=Hb/I7fgqFHAN/7h+XrQcPOQN5urutp688hMjXZXvQQ6dAFcYgen04ZoxsLqLybMuW4Gh8KiwGPS5iBvapFGCITWaETznH5og3J2Pcpgep6I5u0EHY/06pu5Syv9w9T8VebX6YLCz5Mo8vsISyI7dbdXwbCQT6XR0NsmnOyrI6CRwrtO6EgvQsfPkVTA2Dj0tmPe86CDNgB9rdvjXAX1lzj4Ac6e9PYVRf0GsE2INFkU9IphELSj+EudnmxuPE0jlvHmDDqUYmG9lMPo4/a5/OJdoOGdVbF4ZE0EbxcIu1DprNYlsNF8Fp8wp0qOmIUutADroYFAqB2/G4fPCQ99GPg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 10:10:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Content-Language: en-US To: Wei Chen Cc: nd , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" , Julien Grall References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0141.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::14) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8385ac31-7667-4623-062a-08da6894f8ae X-MS-TrafficTypeDiagnostic: AM0PR04MB7075:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pxAsrg1osfYnylj3rXK1gVYEJPMpkz5ONezT6cvIKHCJoQXNBG9o+E/2fly+1/s1n+xi3bKlGvKMsP9gWC4DID/O1JXqeD8JAKa9Fy419VvcnthRRzIxfhRcxR7BiK88JzjxEPYH3TnUIG65365+cnhLX3G1fKneiO0SbXMLKE6JFnoa9eS7dsZRiyofC/hQY6dTFe2Ih15a2arzEz7fqF4qqMuN/X4Jv5lho7enDzR35lcDPe/u8I5/KHmZX6PvHt09kBoODlJE28+YnVbdQw0JQqdY6AXA/rIrL0cbl0S2vIKKVnNE9E8AEIsMpQMNZJZOsLPzZPIhzDPOtX21kvqPQliXVezgtRZXRk/21aLVnED74GJWLT8iww+rEsXkBqkmzReTHPJsj2VMbyQsrZqTHc1s5AbMHDR1pqbVB4QvuxchMHZghEioe9IMpe0Lg5y3Wy742H9sffpQGsaRooMlE5RskryXf5iQ8JwZ8a3SUXN/N8UJVIo97mycnYZbOLRLMWifIwZJ18LhqKZBYu4F5gDytNJI0kJvkuxeJuXy3UqP0vTKQTvH1HF6M1FLJSGBqh26+rtfqpvPFcR8uObRlSyk4zBBF2+RJj6ylvKhm/K89TNlrbIYloSXR0Q2Eerw16kmA7EHnk8MqsGUlrLREZ+IIyoBtiiRJv1xRlG3iZ9QfSO+RwG7EwNsB4n/QD7Mbga5gH8dDNlZM8WJJwl+SCzphG2dNGuKJG45G/qnFNr7ty34bnNbAWvIB7hzGKuS9UN1T+ngPh8oHRluHBg92sNmCgJHiSJAF6qLMPkFOXyiJQqjtHNFKSnh+UlVmYNjfo8pO1bA3jQo2608/Peb1oP55kAiFWlpoHR2NZo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(366004)(376002)(396003)(39860400002)(6506007)(53546011)(41300700001)(6486002)(478600001)(83380400001)(26005)(2616005)(6862004)(186003)(2906002)(5660300002)(6512007)(54906003)(316002)(8676002)(66476007)(66556008)(66946007)(4326008)(8936002)(31686004)(36756003)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NlZUSnljNlNWM1JPdGgvck85bm9LV2lwS3h0cGJUYy9NQXE1Rm03emhqSVor?= =?utf-8?B?dWRpcWNxL2k5VnFHYzlkT2JkWXkxc3ZWS1U3UzBnWnMwVmx4MkI0Z0ozZlZF?= =?utf-8?B?Tkg5WFcvaVBVd09GdWZqWUlOWmtzYTRzR2RxVTJuTlhlcU9PdzExbmZpV0ZD?= =?utf-8?B?WGJkam1WaWJBS1FRQ2lLVDRMdGFESVlnRnV1TUM3RzB6QUhJM01PeEpXZno4?= =?utf-8?B?WlJPaDJaZUEyTTU0dGtQTytuYTltSXRqSEZMOFR4am9tcWY3QmJiMHVCczM5?= =?utf-8?B?VEF6R3R1NXhQN1lrVWZ3YitjbHJ5ZjhIWjJENGxqZkFjNWsvdzFVZGxzdFhF?= =?utf-8?B?azJyOURFclpaSThTQkR6SXFQYXdoYUZ0c21wbHlTdUVuMXd4RElGMW5CSmFV?= =?utf-8?B?U05kNEt4QkNHZ3R3ZWU5dWVEZFdMTkN1RTVsNlkxNUd1TVMzYnpUNDdrd1pE?= =?utf-8?B?bVhDUld0V1hoU1NFZ1RxZTV4ajdyV3VCWEcyWjM0ek94TDdmNmdaOU1XUkdB?= =?utf-8?B?OEtZc1A5Mm5tVnFqUExQRjUvRHIybHdidG9wNm9tM3ZqQUd6NVlpZGtWWWhV?= =?utf-8?B?aWZsbHA1UWpkY1JxYnU2dGF0eGN6NHZqSVZpZVF2WHlueUhPSlRZTGJhWDhr?= =?utf-8?B?VW1MQ0lkV3Nhd3p3Q0UwU3FIeUtVdWdVV1QzOTA0OFYzTm5lcHBWUm1MUFVG?= =?utf-8?B?Y0RBdzZhRml6em5na3ozcldoYmw2MGJlMlo1YlBBNUV0dnpSUWdqb3VyTlBZ?= =?utf-8?B?RlB1MHhYZ0NzTFhvblpEMHdUeG1OTHcyLzl4S2ExWFdpczAwLzVUamNFMWlM?= =?utf-8?B?UWZHTWpSWlZ3eHByenRmMHpuZXF2czNxNVRndnBUZEYzVWlqSm5KUFdZSUZs?= =?utf-8?B?YXJyOGtmTXVWTDhWbkFIL0oyMFNqSStCaTlmWSs2dVEzaW12SVpkdk9nYlAz?= =?utf-8?B?Mm0zYkZHVm5pR1o4WGlFVjNTZnp2emRLc1hhNWgreUZtM1hKUmM0UFFnMy9Y?= =?utf-8?B?NW9vMWZNNzlVTGRtY3pSQlUzZkVOY3FRZTFPbGV1c0EramNSMXZ6eTNRdHVq?= =?utf-8?B?b0NHY0NaQzVKalNUaTB2bEdOaktsckZBaFJocW1oM2lta3dZYUZieERvU2E5?= =?utf-8?B?MFNBbTkwRVFJbWFLY3VQWnc0T1ZnUVZQZDBzMTlHNzVocjltUllEcTJCQjF1?= =?utf-8?B?WitOelB3aVhwUTBWMEcxdHgrdmZaSUd0UnVGY1JSREhROUlXcjExTjVHL09U?= =?utf-8?B?RnhNa05WbTRxWkExVi9DbHZUQUJENjlTVXlGMEt0WmJYRmFPRFZGU2tlK1pu?= =?utf-8?B?TVdycEtiVTRxeWV5QktsZVVoTk04NTNpS0trL0srTkdnK3N0OFZYN0pmc1pn?= =?utf-8?B?M1JKc3ZYYU4rSTFrUHNFQ001SzJ2WmdBbnV1UGFheE9Ud1dyL2FLcUNrUnIr?= =?utf-8?B?NUszYWtLNDN4WDR4V2FHdzNMVXF5aU1Rcm9QZVEyNlpqTUl4WEU2YVpDNmVP?= =?utf-8?B?VmJZSFpWNnA3VFdNR2I0UnpjbVdCUjdCZEN2YWtaNXUvY204dTRxckR4K2hw?= =?utf-8?B?V05FWWtzc3NES2xOUlJ3UVZtbmNoc1R4bEJIM1Q5QnZpQWg0eTZiMktEUHYy?= =?utf-8?B?a1g4akVRd0VOZjlpT1NqZUxNbjN3amRDcjlwNW9ZeFRqYk5sZUJBQ3ZRU0lp?= =?utf-8?B?VHJMdU9ZVmdyU0VSRXhWZHNtclE4b1dxTmo2Y2tOR0lqSE1yb1FoUHJMNHYx?= =?utf-8?B?VmtPN2xubm9ZaDJSd3lxa2FZcUFsb0lRdytid2hDK2didkNZeEhreUZGU01D?= =?utf-8?B?OG1paWJUdXhaN09pZDBYOExPcU1SL2hTdUJtbURaaS9mdHAvNlM4aVFhTjI4?= =?utf-8?B?K3l0SGRYTTA1eEs5UUQ5ZkpWUGN6a1VzdjEvWWQ3a1RyeE92R0dBMDV5VGJz?= =?utf-8?B?elZaZ1NDSkVqTHJla1NWeWo5Y2JzVmJDNFNCL2tTajUya1oxSTA4bHNpcm9V?= =?utf-8?B?bDZNQlJac0paZlc3WHhHc2l0bUZHUTlaY2tndHM0Z0ZkWVhLV2pkZnRlVzhJ?= =?utf-8?B?R2E4UnY1aWNubDVDaXg2NDlkWkxhTU15bXhNTWprSjJrbTNvSTBMdDZTT3hv?= =?utf-8?Q?q53Y2/jqcWqeu0/ggbwErvfv2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8385ac31-7667-4623-062a-08da6894f8ae X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:10:26.4511 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 51XCTmCBZii2rrKqP+78pJssYcUJRr5q4BKff8Pf7rY6PGEJnDDa7nLebBtRnypUvnkOb+boQ9QPo25mV5GeIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7075 On 18.07.2022 09:51, Wei Chen wrote: >> From: Julien Grall >> Sent: 2022年7月14日 19:27 >> >> On 14/07/2022 12:10, Jan Beulich wrote: >>> On 14.07.2022 12:14, Wei Chen wrote: >>>>> From: Jan Beulich >>>>> Sent: 2022年7月12日 22:34 >>>>> >>>>> On 08.07.2022 16:54, Wei Chen wrote: >>>>>> --- a/xen/arch/Kconfig >>>>>> +++ b/xen/arch/Kconfig >>>>>> @@ -17,3 +17,14 @@ config NR_CPUS >>>>>> For CPU cores which support Simultaneous Multi-Threading or >>>>> similar >>>>>> technologies, this the number of logical threads which Xen >> will >>>>>> support. >>>>>> + >>>>>> +config NR_NUMA_NODES >>>>>> + int "Maximum number of NUMA nodes supported" >>>>>> + range 1 255 >>>>>> + default "64" >>>>>> + depends on NUMA >>>>> >>>>> Does 1 make sense? That's not going to be NUMA then, I would say. >>>>> >>>> >>>> Ok, we need at least 2 nodes to be a real NUMA. >>>> >>>>> Does the value being (perhaps far) larger than NR_CPUS make sense? >>>>> >>>> >>>> Arm has 128 default NR_CPUS (except some platforms) and x86 has 256. >>>> So I am not very clear about your comments about far larger? As my >>>> Understanding, one node has 2 or 4 cores are very common in a NUMA >>>> System. >>> >>> The defaults are fine. But does it make sense to have 255 nodes when >>> just 32 CPUs were selected? I'm afraid kconfig is going to get in the >>> way, but I think I'd like the upper bound to be min(NR_CPUS, 255). >> >> Looking around NUMA nodes with 0 CPUs exists. So I don't think we should >> tie the two. >> > > Yes, some nodes can only have RAM and some nodes can only have CPUs. > So is it ok to use 2-255 for node range? Personally I think we shouldn't allow unreasonably high node counts, unless proven by real hardware existing. Which goes hand in hand with me wanting the upper bound to be a power of 2 value, if for nothing else than a hint that using power-of-2 values here is preferable. Hence I'd like to propose 64 or 128 as upper bound, in this order of (my personal) preference. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:12:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:12:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369349.600716 (Exim 4.92) (envelope-from ) id 1oDLrG-0001FW-4P; Mon, 18 Jul 2022 08:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369349.600716; Mon, 18 Jul 2022 08:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLrG-0001FP-1h; Mon, 18 Jul 2022 08:12:02 +0000 Received: by outflank-mailman (input) for mailman id 369349; Mon, 18 Jul 2022 08:12:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLrF-0001FJ-6Z for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:12:01 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4c58286a-0671-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 10:12:00 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR04MB7075.eurprd04.prod.outlook.com (2603:10a6:208:19e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 08:11:59 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:11:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c58286a-0671-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HZjFMSXg5F1+1ahkXzdOSosoVDP0twpGpIwgf0MoeLMyeDd5O8+DE4VGP0ZEJhQW6y9Zr7d7MD235fG5Mebzb9kSja0NjnJdYgUMQigbaO5CWytaU5wl9EUs5IxLVZiWwlaT/kZ4ZLSDlVQj8GDBdBBpw1aB/g8ogOqTdtT/qDt6D0CvPCPL1NJwBJKmsbwug1xa/8Qe2rjPPVSzx+HAOd8jb5/kkHdHE8/AuHO1vjZJu0TLzfr1puXZyCkpj7gI4bcS5+KHjppao6uJzzEDq+t1GwVxDZbPcSUq3ZdJfDu70TRpUonGX0Nfk8qIwhcL6fqwbU1qlNbaCg/77toytQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ez4zvXKIRz4UVCemwKgZOWU+3bA+TSO69mayaJv36OA=; b=GiKcpPidMUbgU0s2ptozYGmFM3+3pPN5pdSGPkBVNShbzlZPdHfb40gkC7ufyZ8a7Kffw2Jh3iD82LQ0L+eIn0cxSRviObn1J0utm716pBDrPsBtx4gTFr5J0IfE4IYE+0Zm196rcxQBZmnZIk1uTU2vVsOC8n8EJ7D3H7Ghk3d0r0iwbotx6zif31+YdcrcK3Do491H4Q5Q7IdsGqbp4Dkjttyt00UW1m+DC/vIVNCTOhqls/f8Rhhw8KHWOVhJ/5+5/Dm/IJFN5TIVpqPJTPt3/vmBph9lELwVaIKEmYqNtbuQee8VC6tRN7cixapGjEx90MPlMEFgZ6AwMoQN2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ez4zvXKIRz4UVCemwKgZOWU+3bA+TSO69mayaJv36OA=; b=2W2tLLk12UBgqBdzV4m3hNfzh8NvtTWkrerJhOy/wgmYUaxQJUVTwQ2QM4yw1xdejhgaIIf8+u6xrG+8VxVmFBNuOkeqQZn0W9x4VL7eMQ0XzOyaZOwfFgrxubVjUyhPFvnOehYgw/G2vb5IpirkdyfwEoEhi6c1a8aWj7dPzkURcHrikHDn7VkVN9YX9lsqNYit8Q5hpsjHiPLL+avMwdcRSjFCshxBQWiTqRbPejTFx+EdennKHi3rhMmxMCW+JB1eXvbRzhkUFhcCLyek+WnQmBlZBV8FpKyPafM4xWTuQ1W3kZmSznq+wK8WqWXY9UTyzTFvDCZMrD6oDPFnGA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 10:11:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/3] xen: page_alloc: Don't open-code IS_ALIGNED() Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-2-julien@xen.org> From: Jan Beulich In-Reply-To: <20220715170312.13931-2-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FRYP281CA0013.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10::23) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e912e69-feeb-4f56-e982-08da68952fd1 X-MS-TrafficTypeDiagnostic: AM0PR04MB7075:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CRKb1Mp4jM3TLmMJNfiUnGK3EpRoNDQu/8fFwSMe3YbvP7L7WtyHWzbDOfQVTCwmbKiRQsFlTFLioFAG2n6ivtipKHYv0oUzejDaj3OJBD/sgKYk516SbFdxTNny9g8bF/VnakMEiXeri1WMLRAoSAxQEBk7TGJp0G+tWCcwLu4dMqrFzh67ugP2ZCIqkEnOlXn9xM4iVYEVbCF3OTCO4EPdQW5o81Oe4ZtobYdVJTBClFg2YKgrR/RydEIGC8K+gOVz7Yb8nK3xIkGpl2j99YDKvSD0eTnQ/7z7BX/5357kzyQvBZiS6Tk+D7VXYZdRXKkYsUpNhEmp3nTOHnB561DDtF1ank/2iUkB6s2uXxUdiVy3gBfRLiFWgVbxPCgEGJA4XGIXS86j4M2KMMnPLJxHSpxuZGSMwuor0VLj3qIBKhfb7eg9hD0ENWYD31/waw81plMrsPA8iJH0oYkeOAcqmSbijQkK6gvz3dPUZxP/HYU6BdhvigABwUNllnRRwsAp1ImfyxJvrAYeArQ+2SLlJIisPacUH0Kp7Gg1rTitkLC/tWAuHPSMFGgUzBHJRji6VrsTNFO8aS3930ynsXf0sy0PdfioaodewcRCDBNT/bGchF3JbcPmQ78jUmQNdpeiLwqCVQd9JaGjlO/ktK6Vn7nvFRo5e69YBZ1y8tE8MlUpsVlYMV/YjSJpNZOmDf8s5nrP0KE7Ua5Nc/nJuePDWmbsh+e7yL6fRnvxhUFhATihqsPo5MjaKoqWIiJqb0ofyK1RB1PhNJjFjlOoPkasUeRbRkW4ceM6LnJDaKdlfc2Eq60Qr8h8sjzhdaf9WXWcyCfROPce6b0mmA1ym1q2BZEr/Q7yTOU7J9fF9X4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(366004)(376002)(396003)(39860400002)(6506007)(53546011)(41300700001)(6486002)(478600001)(26005)(2616005)(186003)(2906002)(5660300002)(4744005)(6512007)(6916009)(54906003)(316002)(8676002)(66476007)(66556008)(66946007)(4326008)(8936002)(31686004)(36756003)(38100700002)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NmFOckoyeXNkZDloVFdzQ1lxNm50ZmN6OVlpbEllb3RJVllPWWNxSnBXc0ha?= =?utf-8?B?Zi96aWVxT1RjMFAySGxtZ2hDWmtHYnJnVnRoOVRRS1N3TFBJWmM5SUhKU3ZT?= =?utf-8?B?RU9WSllqakYvQjlkK2wrU2ZDUGFmTlpnUlVIWWJxUlU0bU1SMys2Z1ZldWNZ?= =?utf-8?B?WnFBWTh0OEFBMEt4QXA4VE1nRkt0c0Z6YUtoSUVUbDh0TE9TUURSOFEyV1Na?= =?utf-8?B?Y0NiR0lldFpHeTlkd21SQzI1dGdISWVVZStPZGc2OWZIeEsva2p6emFoa3lU?= =?utf-8?B?YkZSUy9uVEJ5Y29hdHJDNkJXWXloczRQTUM4dUZBVjM3ckFHYU1laW5PQ0dD?= =?utf-8?B?L1NONVpRMkZnRUJMZWxETGJnOGdabGI2L3psenRjczhjN3NHQlY1aGZtN1hY?= =?utf-8?B?VVYvakdLTE1vMW5PL3lLUE1SNlZpWVh3d0swSTZNa3o5b1lyc3kxWEc0MTZ2?= =?utf-8?B?YXpoUG5sOUpOQ1FpOGpJaW0zamc2RFdwSTRmdGMycXNYTTBEekdla3hoS3dB?= =?utf-8?B?b2pYUHhGZjBYaW5XcmwzSVlvMWplYTgxYzdPd0NHZmduUWlpU2hpYjRvaVJv?= =?utf-8?B?VlExVmhwMUNyWnd6Z2dIZy9hUG02QjE5WFlXb1I3alFmTW1VU0FJU2lYUE1V?= =?utf-8?B?eW1qNlQ3TDllYjdDc3Y4c1M5QlhrRkRKc3RSaUl1TXNUcmsxeVpaOHJic3hi?= =?utf-8?B?eFNHS0lxZ2Q0am1ZdjNXZFF1aTJyU0VRSnl4OCtjNEVkUUIzM01tMFFpWUh6?= =?utf-8?B?SS9nbmlWTGNuclBIWjdpL0paMmJ0WW5RQjFpcWF0NzhHdzMwMUpmaFQwSkdU?= =?utf-8?B?SlZSTG9pUzhxS0M0VVZyeGZVYVREaXdjcFNSd2pDb1ZjSFVXYVV2SlNWNHBY?= =?utf-8?B?TmJlbWloNFFubUVjZldPcG1tSUlRQjFqZUgxdU1TQmF1NlhydEE1YnZNcDVF?= =?utf-8?B?OTA5cjJJaHJCRFhXS0p0QXdLZ1BXMCszZHJCVjhNaS96S3dqSlpCT2Uyelox?= =?utf-8?B?WkIzL0ZESSs5QzZaSmVMZzRMZXIrdXBDdDNYUXFiODRFOEhGNyt6UTlPMEEy?= =?utf-8?B?elpQaEJYK3dNdmdQVU9jSTlybVBmQ1BOLzhrWm0xWE5wTFNqaGJ2MVhMZCtz?= =?utf-8?B?OUJ5azRVQklvZExPYms3bVAvTUQ1WlAwVmpjY3hrSmcyYVFDZFVXd2tlMzZW?= =?utf-8?B?bE1uNk5WazhwcmFLK3hBN3QxQXdCSnRGR3JxaHhmRkNwaEE2eTZMSE9wYnBL?= =?utf-8?B?cGtqREN0ZGUrd3pIWjBtc1pqZFJtZ0pYK3hkS3duMjU5MENaVUdhdDVwekpm?= =?utf-8?B?ZjhXV0FNaVZUSlZZd0JmT3BRY2lsaktKNW5zb0hHZWFTNjNqNjRDK0hJc25j?= =?utf-8?B?YVlrRW00WHhCdE1iUmdLem1DY3pTYzBRVk43ZVUwRDZVQWs4S3l4VjY1OGlM?= =?utf-8?B?R2xZWitGQ25pQkx3SXE3bWg0UjAxZ3EvdjRlemJFR3p4Rm00dXhQZ2orcVBD?= =?utf-8?B?ekNvZ2ltL3hydGcyVGF6OFp1TzhxTzdRdjlNNmNYSFN5SWp6SjlCUnlIUUY1?= =?utf-8?B?S0RwN0VURHRhOS9KS3N2dlBNeTZmbVgwV1V4SUlKVkcyY2Zzdkg4VVE1RkUy?= =?utf-8?B?WUhQQXNsUlJKNW9lZnFlbU9ReDl2Mm1nRlUwNEdSQ0pYcVJ4Wk9haVFveC9S?= =?utf-8?B?R0prL0wyenUzVVdjWVBrRlZaZFcxY2ZyM0phR2tjM2tFblBIVmdvRjdxQXZC?= =?utf-8?B?NnhzVWxDRmQvWnZpNUh2eFRnTWNSc1dMSGpsT01DUStXa2FVdzNYMzJvWVFI?= =?utf-8?B?ajBiejVzdWRpQmJYcS9PaVVyRDJrckFVMGNXY01TM2lFWUh6WmRMYVZnZGFF?= =?utf-8?B?N1ZyWE5CUWYvUTdmTkJOVHk4N2I5MlhXcUhYUVJhK0RlMjBQSEdZby9Hc2dE?= =?utf-8?B?U0lCOVZBU2k1WVNkRkZjbUh0MlpBakVKelVCRVMydEpNNWcxWStIMmNTelVo?= =?utf-8?B?MUQvRXU2eTJNWEFBNlhSUTd6bUxNbFhsdkVBZ3l5eGhySHQzV2pLTXh0VVI5?= =?utf-8?B?dWZpSDVYSFBoYjZZdTA1UHpWNXI4ZnlsOUVMWTFaZFU4ZHk1bTlzdVVYUkFN?= =?utf-8?Q?3vQ9fx9pKPpDDWbEaA6Zyy9ZV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e912e69-feeb-4f56-e982-08da68952fd1 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:11:58.9766 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fbau7P2cgtk9wb5nVBWRDbTa4FEeI+76TGQNpstQYLH6XQI5r+GGKqKtHD2034pgk5N8cHP1fUA4lbTejhEOSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7075 On 15.07.2022 19:03, Julien Grall wrote: > From: Julien Grall > > init_heap_pages() is using an open-code version of IS_ALIGNED(). Replace > it to improve the readability of the code. > > No functional change intended. > > Signed-off-by: Julien Grall Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:19:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:19:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369359.600727 (Exim 4.92) (envelope-from ) id 1oDLyR-000255-Ti; Mon, 18 Jul 2022 08:19:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369359.600727; Mon, 18 Jul 2022 08:19:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLyR-00024y-Po; Mon, 18 Jul 2022 08:19:27 +0000 Received: by outflank-mailman (input) for mailman id 369359; Mon, 18 Jul 2022 08:19:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDLyQ-00024s-DQ for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:19:26 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2087.outbound.protection.outlook.com [40.107.21.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 551114dc-0672-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:19:24 +0200 (CEST) Received: from AM6PR10CA0078.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::19) by AM5PR0802MB2593.eurprd08.prod.outlook.com (2603:10a6:203:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 08:19:22 +0000 Received: from VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:8c:cafe::e3) by AM6PR10CA0078.outlook.office365.com (2603:10a6:209:8c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 08:19:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT053.mail.protection.outlook.com (10.152.19.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 08:19:19 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Mon, 18 Jul 2022 08:19:19 +0000 Received: from 8a89f3a10fb9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 345D46B2-E52B-44BB-89F9-B8D2DF1806E5.1; Mon, 18 Jul 2022 08:19:12 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8a89f3a10fb9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 08:19:12 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM6PR08MB3367.eurprd08.prod.outlook.com (2603:10a6:20b:44::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 08:19:07 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:19:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 551114dc-0672-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RoFnJVweWxPUlNbHbLQDxgqPeGWEUSPv1z3v46jWNz+x28TnZJXkCQBldFDxobQ0ApjPtZEvjR3WEZ2C+dKBu3UsnM80dMC471J3JdHELyLQDp7Tbk1Yu4kiz7xGnkaD+JjSLFiaVJISnjPqEUjPqQZ5fDqb0lIGBUhmd2FTs6Zv7TI/nMCSQXwwMtQ5ZdbG/zakw+dsur7M4vnw+sCv7DhwrDALSFSoTFhYZwQNZ0OT9mdM7paMzkdV6Qoz8hb2U3vLu34LOg4YmNseDuLwmM1UgaIF7Y/e6q5bFlcsAq7NLcY7z6v11UclOcfudVcwPwgvV669JU9EW/PgOFfGbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7g6d8Ro0Yxe62ViASgmY2GXjGbikG0PCi8ly4bRu7c4=; b=MHElfvqdGDwKphFIO0+0o1nlrx0ewBhGbGnKKuoYZj37vETsTD1KB34gqYcNDr3sKLJlt/U84OavrtNqEhmlIDvrm+2Hpz3anN5KRL9iRrFdQXc8a5p/nDoOCrDkq24/NPpPTKwMXxVOCExH1tAVhpjSQRYQHlfA9m7b/fp9SzUkxA2Y6VPQ1NvhN38RF9SYB1Qq4R4mxhPNoUOG1KNlS5xYtTuUwT/goU4TuIu/+FakZMxXmWZFa0Juyg7F/J67XRE9yTeT0Kq5dcRUCQAMpwphhByPRkOnlV1bDVtqlhWk4OD1P/m/U5Ykg38GtjF8ZXtLGlQv06Q0q9eitz/iqQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7g6d8Ro0Yxe62ViASgmY2GXjGbikG0PCi8ly4bRu7c4=; b=uOAt17Lz3XMbeY2HlyrEyPgNRnD9RXiEnQQA389SB60U4kDO6An0CqE3xq2umz/tsqHmiK1SUm9+uGH9+JdG+BQAuwzpKg6sMu1xUjwFDDo4OH+ZjqUGSSSpv+QDO9dyH3ZrJhi7zizrT+/Up/M32sGH1bsgb04yP9PehpZUqZA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8b2de34b28723259 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5mDZ7UYW0t7cVPxCUPLEbl1GArb7ECOiiH4RcEUuXNKNl0kk8Av9e2hnefm/aZoVUU4rC+jlwudtg37BdYoIOdYZ5NA77lMEOOw+KnxhBXltILENcw3ZMU6l1vaHpqpXtwwL3TD0hAdT9RbUbRt20oE3LeqcDKRLM8cqrwxwUA0UdC6zAIo6tE0RHfGrk/OALb+3+zTY6ifyfodUgbxwNBKI+Zhv8pTR1Re1esA4ZDe3TN1kv9jxwWXIPrCdN/YjsV8d3acrhZ5xo7qeKhGl8yz2hQIbWkrptSrkHaOjieAwj/5iuNZEx6+EGmHVLb9BoOm0ucrG2b+91xTl85mLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7g6d8Ro0Yxe62ViASgmY2GXjGbikG0PCi8ly4bRu7c4=; b=bYtBFM2dzz3/7JMiUtX5JTnvlDE89e+co2dBG5EiMCXNworgLGbE9jShjUe1hrFfPGf4zCBa86MIZfGHDPN8ximoxMbPh1z6abjAG6m/L39Gi4k75TVjAWPncD4U9Crx8nOPTLetBbp5S6q4cbF+cEIn45GPxXtbjf1Zj2UT9gbHmVrgdGvSMGxVh8h8TESTafMtMiSYNqVOJloGqGNAJRRvspf1QXUWJcSvFRyneiNo4qUDZO/DvVJK13AZCpvKhvSxXmNjhS5ru62yi9A3DygjtoRVGzr8AqN+V+OPF9ljo4FKoyKEl9DRpw7f+TQrReiaSkhs5SlOuRHU+YaxFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7g6d8Ro0Yxe62ViASgmY2GXjGbikG0PCi8ly4bRu7c4=; b=uOAt17Lz3XMbeY2HlyrEyPgNRnD9RXiEnQQA389SB60U4kDO6An0CqE3xq2umz/tsqHmiK1SUm9+uGH9+JdG+BQAuwzpKg6sMu1xUjwFDDo4OH+ZjqUGSSSpv+QDO9dyH3ZrJhi7zizrT+/Up/M32sGH1bsgb04yP9PehpZUqZA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Mon, 18 Jul 2022 16:18:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-3-julien@xen.org> From: Wei Chen In-Reply-To: <20220715170312.13931-3-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR06CA0185.apcprd06.prod.outlook.com (2603:1096:4:1::17) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6ec72924-637e-4b19-a200-08da689636b5 X-MS-TrafficTypeDiagnostic: AM6PR08MB3367:EE_|VE1EUR03FT053:EE_|AM5PR0802MB2593:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9MDlax4Pmqc0G5imWkq5qDQlI2eFH2scUsy3A523GHIpaZMHnIKnH2DlvSlJ/8TLyj/HkoVGExBB6mdOdAHm8SyU/R5/d9OkqvQnOnWFrCtBrAJW7H/TvDiN55HLhtS372ZmHAScGAP6az3IYfGcMJYFKp35NSyQFpZY3S5jTCXkRfhgNqabAkY5jBLePkSRxLV8kybRVlEM1EUIjQ31MlJxOQ2MRpKDvl7hOq2HYcgTEkF3OAXXQve0q1JSHIuSPMEhjrjdM9nKPiefAaLDY2/q24gS3MvO6y5YaJ2g9CyijC7GXDdd9RyjrstVDXLBVO7NHBeEV6OvOww50f30pNEDy1vq13QIrmIavBGLRXDjw1LmmjCcA0jLR67Gg5wB+ZSP7Zfnoi4JMIPAl5Kg1Iu1XvNVdnqqDxBiTOF8/ySvl8jq5wO33XkN5GYgjdLtvEIzliPsfUstlA5/lGteB7GGTdVzev3RDTQ/1AARc6rZfucXOM6SjNG5DYeGgjHYBKL/pQH2xEyo42t3oYG/mnBdt24bEXa53E/yxG7elHxRrCpS6/jLLKe1O0KQPgcSVIKsjqKFGN24vynBdOfOsQAPA8ygH40pWKgqZ8yhEf+GBPQYJwTTy/WcsdADqz86bAEDsqvmyfckZF5xXnbTbThs0tnlfhw7sWZrTfgygdDozXSFOp2Imx9orpKlp2oaLf1/CmVR11XWFKsaKTAD8iQkNojHisw/8+vTd9vnrziGrpYrzSmGW+QEhrXBFzLukJTkMShBzAY73tmT0HPc7+x84OUrdltudXGl7PCBMFtyWcZLHmKxtYDgw0iKzlIugiVh/Y3G4Iq1ogVpfY74q3w6OStKPlcVBkH5gMms+Ck= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(366004)(83380400001)(6512007)(26005)(186003)(41300700001)(6666004)(2906002)(86362001)(53546011)(6506007)(478600001)(6486002)(5660300002)(2616005)(8936002)(31696002)(38100700002)(316002)(4326008)(8676002)(54906003)(66476007)(66946007)(36756003)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3367 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 25f76191-8f08-41b0-90bf-08da68962f06 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fyfnvRHM+dXtnD6gevKwKDta3AO8+i9Tte7ZMCjI0Uzm4/gpB9FzFUqBJVQoFZ63UaZJ2MY1yzpKAWQLNzS7PhFwpqBQNhJizNGFLAThFULftPD2NXaWq4+doaqAi8RTvepJ7YQ2GISlo9KpJFoYVn8eV8pWSGD9BNCF/wDBPLDr0osa2bq3LGrRwVZzYLhoU64yA0OrCTEfeNAdTX7GsSGHlfU9pzWvOXxymWuDcvYhsKTr/8e/aLSw3yRbc8qktgAkGsJLhXNjfo3tFVHTnSHldJuWb60njUdd8Y94xMYxPLxV9AkJU/eC6HrywgdB1uTZbEOKIPx3orzIujGDOpTqq2zlDTa5J9hctsFV5CcLDwSsfT6siDwlnHWmLr1PKlHTejSihpZMp3x5P3XyCLmhbb56JCzRRP7fgfUFcPEcO+Gal3stiVhdc5GaeSakLiXmk2S3ni6GHqpiqeKlvnw+Nv4OP5DqQhS1Dqm51VM9WJpzKMq2i4ReTh3Q18ySUVHSIgXZ8xOjU6wBjtxCFy0cqYxrnqd2YSIKl9QI4w0l5+gef5fmBW4qtjGleHlmZi/8bJVlv/dnCXD4xJi7jdWdwmHr6qbZm4tOU9TPAoqPEz0hQj8Q62sEZQk+UdMI+D77QsJwuzcFZlMhMxexn4MZghNl7S0Sp2XeNKTjt+O4Hxa7c18Wz+IsuAzcqFWGYwxfVMPoIcletSkomeJHc/YiW8WBrY0ltOSJVEA5BPe1lKsgxmtJbhbnDFUVxBw6ogTJdVuzTPNrR+Zo0EGVofJIu0h4kMrAwdyS/rTcGaw04lAQgzIqbZ0F7MTASOaWk0+2Rk4Bq6tvPdvbmQ8/rC/bsvxi1DE7QPkz+H2lYaM= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(376002)(39860400002)(46966006)(40470700004)(36840700001)(26005)(40460700003)(82310400005)(186003)(54906003)(6512007)(47076005)(2616005)(336012)(36756003)(40480700001)(70206006)(41300700001)(31686004)(478600001)(36860700001)(6486002)(2906002)(8936002)(86362001)(316002)(81166007)(6506007)(83380400001)(53546011)(5660300002)(6666004)(70586007)(356005)(82740400003)(31696002)(8676002)(4326008)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:19:19.7165 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6ec72924-637e-4b19-a200-08da689636b5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT053.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2593 Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: > From: Julien Grall > > At the moment, init_heap_pages() will call free_heap_pages() page > by page. To reduce the time to initialize the heap, we will want > to provide multiple pages at the same time. > > init_heap_pages() is now split in two parts: > - init_heap_pages(): will break down the range in multiple set > of contiguous pages. For now, the criteria is the pages should > belong to the same NUMA node. > - _init_heap_pages(): will initialize a set of pages belonging to > the same NUMA node. In a follow-up patch, new requirements will > be added (e.g. pages should belong to the same zone). For now the > pages are still passed one by one to free_heap_pages(). > > Note that the comment before init_heap_pages() is heavily outdated and > does not reflect the current code. So update it. > > This patch is a merge/rework of patches from David Woodhouse and > Hongyan Xia. > > Signed-off-by: Julien Grall > > --- > > Interestingly, I was expecting this patch to perform worse. However, > from testing there is a small increase in perf. > > That said, I mainly plit the patch because it keeps refactoring and > optimization separated. > > Changes in v2: > - Rename init_contig_pages() to _init_heap_pages() > - Fold is_contig_page() > --- > xen/common/page_alloc.c | 77 ++++++++++++++++++++++++++--------------- > 1 file changed, 50 insertions(+), 27 deletions(-) > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index 078c2990041d..eedb2fed77c3 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) > } > > /* > - * Hand the specified arbitrary page range to the specified heap zone > - * checking the node_id of the previous page. If they differ and the > - * latter is not on a MAX_ORDER boundary, then we reserve the page by > - * not freeing it to the buddy allocator. > + * This function should only be called with valid pages from the same NUMA > + * node. > */ > +static void _init_heap_pages(const struct page_info *pg, > + unsigned long nr_pages, > + bool need_scrub) > +{ > + unsigned long s, e; > + unsigned int nid = phys_to_nid(page_to_maddr(pg)); > + > + s = mfn_x(page_to_mfn(pg)); > + e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); > + if ( unlikely(!avail[nid]) ) > + { > + bool use_tail = IS_ALIGNED(s, 1UL << MAX_ORDER) && > + (find_first_set_bit(e) <= find_first_set_bit(s)); > + unsigned long n; > + > + n = init_node_heap(nid, s, nr_pages, &use_tail); > + BUG_ON(n > nr_pages); > + if ( use_tail ) > + e -= n; > + else > + s += n; > + } > + > + while ( s < e ) > + { > + free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); > + s += 1UL; > + } > +} > + > static void init_heap_pages( > struct page_info *pg, unsigned long nr_pages) > { > unsigned long i; > - bool idle_scrub = false; > + bool need_scrub = scrub_debug; > You have changed idle_scrub to need_scrub, but haven't mentioned this in commit log, and I also haven't found related discussion in v1. I am very clear about this change. Cheers, Wei Chen > /* > * Keep MFN 0 away from the buddy allocator to avoid crossing zone > @@ -1812,35 +1840,30 @@ static void init_heap_pages( > spin_unlock(&heap_lock); > > if ( system_state < SYS_STATE_active && opt_bootscrub == BOOTSCRUB_IDLE ) > - idle_scrub = true; > + need_scrub = true; > > - for ( i = 0; i < nr_pages; i++ ) > + for ( i = 0; i < nr_pages; ) > { > - unsigned int nid = phys_to_nid(page_to_maddr(pg+i)); > + unsigned int nid = phys_to_nid(page_to_maddr(pg)); > + unsigned long left = nr_pages - i; > + unsigned long contig_pages; > > - if ( unlikely(!avail[nid]) ) > + /* > + * _init_heap_pages() is only able to accept range following > + * specific property (see comment on top of _init_heap_pages()). > + * > + * So break down the range in smaller set. > + */ > + for ( contig_pages = 1; contig_pages < left; contig_pages++ ) > { > - unsigned long s = mfn_x(page_to_mfn(pg + i)); > - unsigned long e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); > - bool use_tail = (nid == phys_to_nid(pfn_to_paddr(e - 1))) && > - IS_ALIGNED(s, 1UL << MAX_ORDER) && > - (find_first_set_bit(e) <= find_first_set_bit(s)); > - unsigned long n; > - > - n = init_node_heap(nid, mfn_x(page_to_mfn(pg + i)), nr_pages - i, > - &use_tail); > - BUG_ON(i + n > nr_pages); > - if ( n && !use_tail ) > - { > - i += n - 1; > - continue; > - } > - if ( i + n == nr_pages ) > + if ( nid != (phys_to_nid(page_to_maddr(pg))) ) > break; > - nr_pages -= n; > } > > - free_heap_pages(pg + i, 0, scrub_debug || idle_scrub); > + _init_heap_pages(pg, contig_pages, need_scrub); > + > + pg += contig_pages; > + i += contig_pages; > } > } > From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:22:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:22:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369365.600738 (Exim 4.92) (envelope-from ) id 1oDM18-0003VS-De; Mon, 18 Jul 2022 08:22:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369365.600738; Mon, 18 Jul 2022 08:22:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDM18-0003VL-AN; Mon, 18 Jul 2022 08:22:14 +0000 Received: by outflank-mailman (input) for mailman id 369365; Mon, 18 Jul 2022 08:22:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDM16-0003VF-6s for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:22:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b85db049-0672-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:22:11 +0200 (CEST) Received: from AM6P193CA0140.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:85::45) by PAXPR08MB6956.eurprd08.prod.outlook.com (2603:10a6:102:1db::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 08:22:08 +0000 Received: from AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:85:cafe::7a) by AM6P193CA0140.outlook.office365.com (2603:10a6:209:85::45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14 via Frontend Transport; Mon, 18 Jul 2022 08:22:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT049.mail.protection.outlook.com (10.152.17.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 08:22:07 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Mon, 18 Jul 2022 08:22:07 +0000 Received: from 618754c55b8d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 41B7B2EF-9AA6-4B79-A5C8-231EA7A1C0D5.1; Mon, 18 Jul 2022 08:22:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 618754c55b8d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 08:22:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by PAXPR08MB6972.eurprd08.prod.outlook.com (2603:10a6:102:1dc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 08:21:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:21:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b85db049-0672-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Krddpn27Qh+4/K/MabD0yPdiDtH8N9s4HvgwyQn79WM3GgfXGlLdsK+g1BvK9z1LZFwHYEr33iHnAfYugplxfksjS8Nr+QL/FV1iSZt2udLOu+HOhyOKklU2txBKMwFVBYnV/BTGhl8eZYdCTZwGsIYr9dOLm0iqznwA6MZhbapozkwjrg84vqKBbVXeoS/7jvLaeUuA8oZpm4SIGn942KtunpnEbnxNhsUcj/0JeBcBKCVSnV02FPyqsP93WwmCYP7D/BIRZCp7xN6PvPLH+md/cWmxFYsamHY7gAmq1oRvscqcMSrjmNaW2xT2jcreeyM8m/UjGrfF/USG7YdsFw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4P3BF+AqsvyB7H/9sjXGoLW1vk2+/1oxAQaHmfCcm+Y=; b=lCF+Nq4wUELmNIlj+I9WtUTu0LMidnzW8zJ587BDevjVMirBU2WWfjcBHmHfgTjnW8CUYO/J4n3eBHpel06+oTM0l67Pv341S2ox32FJpdcB7bLYKxscWPNAq8LPjvECwwwda9spppjw4Hv0HlFKQw/DfrGh3ESiKu95nCCKT9szojwaL4UR8RyrAMLcdIGAL+UYenmf3Z5ujct8KplwSJ91t/INL/1R+JhHSC7zFhvxB6Oxl+TnUpQQVpZgDsaWzaeI9dpwttwXtMeNZu3R9nRQ895jbO0Az70uuqnhMaqoK8INlyVcpDx95rsCZy/r7cm5RVj1SdoGDNcKoJnWwA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4P3BF+AqsvyB7H/9sjXGoLW1vk2+/1oxAQaHmfCcm+Y=; b=xaYoq2O712PC6tx76G+DfA9DtZ5ZFBnJZSDF8iwAwvWU+uMEOiLLtv5zQ1ga6tAv275qc7yraCdk+PCD/rmuyC27Hp1ig/L0DhOXRUJreQ6sN7TGsaBw0AZbI7xcsMnsuNDmCbW3mHEa6GL9LLrOuYp/ebvkVwXCgXtLBo2v5Ws= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TILqza8r9L0qGngyApp7aHwIvt8iLodUItZkj1G5DDZBXhK8/MRo+Bxd4EqgvHSIbX/v96nSKWZ+X00snFOZbucepa9XD8BsWptExi2r6AAj1T8OLo5hcuwfoKSZeQntvdjS9q3VBaFuPUUzv0PMgjcyOhHzPJFez4u+pTtpOQZCQz/4+/FHiAFiewxfxhpwCtAgE5LZcgcwX1jNi1AudgQ1MtZM/ClzS8jtpdnnJq+x4BO2TLllyepuMdTMb4YGql12KGTfKIaXl3Fn3OPlIpUQtPSXiaWjMwEnzaSOaK43GWy3Y2VvYI5g8gsVIeakbhZnwFi4nmiHIhZhE/09hQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4P3BF+AqsvyB7H/9sjXGoLW1vk2+/1oxAQaHmfCcm+Y=; b=I4ffz4RlSQupqPnNR6XiOo8AmNyTQOIB+hiCU6u8Bjyg5+kCIeL9lw1I7XxATAYwXs7tlreKbuLTQR1fQFQFWz1j28fTVqK9pjDieon1X3SMuzJ+peBUgAIIU8OT9SKPVMvftujeLq/Yl75cIS/z21aep0ImMEgjXrat7SsHSLKixBtckeK6FjGXW+ilimC5STVV8dVeOG46qSMwZU3luVlWwOW380zqx9FuBHM1S9ydrwPbFOOJleAPJbmt3DMddGjP32GkomdG7zJAgGEHhWTSH3LJMXIXmcLiAdZE3SOii+fXcW9DbUHhqwwuDQjSnVq/miOiLl29+oawVMjO6g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4P3BF+AqsvyB7H/9sjXGoLW1vk2+/1oxAQaHmfCcm+Y=; b=xaYoq2O712PC6tx76G+DfA9DtZ5ZFBnJZSDF8iwAwvWU+uMEOiLLtv5zQ1ga6tAv275qc7yraCdk+PCD/rmuyC27Hp1ig/L0DhOXRUJreQ6sN7TGsaBw0AZbI7xcsMnsuNDmCbW3mHEa6GL9LLrOuYp/ebvkVwXCgXtLBo2v5Ws= From: Wei Chen To: Jan Beulich CC: nd , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , "xen-devel@lists.xenproject.org" , Julien Grall Subject: RE: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Topic: [PATCH v2 9/9] xen: introduce a Kconfig option to configure NUMA nodes number Thread-Index: AQHYktrGRUcF8MDJDk6LN0+4egi+Ca160z2AgALXevCAABQigIAABL8AgAYMPgCAAAYhgIAAAsoQ Date: Mon, 18 Jul 2022 08:21:58 +0000 Message-ID: References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-10-wei.chen@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F4A71446FA05274E93634B698C44F9B1.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 75eb83b6-e654-44f1-d873-08da68969ab9 x-ms-traffictypediagnostic: PAXPR08MB6972:EE_|AM5EUR03FT049:EE_|PAXPR08MB6956:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 6WETbHRjDV3ebKLoESThSEyNf75H5uzLZgm0LaR4F5zrPUgyryo1gbNsHJM9aYGwZuq2fRo5Zz2W/WuuAgutK8C65BUhAUnYKW3CC8HmUZciIU0C2G3OXmSa6nIL2Jitfdp9972HFAk/eGRm00hV8dH5fht1F8rBMRg4wZdfOflSIfZUOy1fs0KYcLBDYOnWGv8hrufOGYE7C2+m1K90FrlPgItrdR14BfA8rBtZAu5y7WM2ql5RSLviotpeQFI+NcW0C48F1SeUO1C7AXj535GDm9joTqClceAnhzYdi80j1D6Udorwrp+od/+5RTuW/IieN0/OUd4Snn7zo2FL/eeE1sast2X8AYif/majfPoQyzu/7uNmvNwEQUyU3X4bNZi66nihjn1uXZN2rbqGkTJ+tBu32GgFKe+MiNT3fsmHE6B4PGQnUTGBYo3X9sMs8hIUVpJBYFMzQ+qDNjyBE9Q88ThSOYd5uj5gUDZwdDAqY7UCx1tDENmCD5b1SARmLq1X4tMmHo/RKN4j72PedEULcjXKx1e2pvPDvmeA2f47txf0Pp1/z+nTLH8WNcC3s8qPHmymAmwnBGgN/ZepyoRMMBT/O555ZVBjuQNXoSl2V5LtZMQO8IZrbXXTdFv6yekPvvixyCbCxf0LgIB53fO5CAv05YOi3Xoc03FATEnMbjuCam5DItaK+0h6pqUGLinc+r+aaPWoihkL/x0dEqmhftQq0KyxecaJXT16qyc8/gEWn4j85NiQt2K4av7KNTbk7TpGz2CizhZWgCXHGELUJPJa/tG/yepHGYjk3SiTcw+gzj53gcpMkqeclM3+ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(39860400002)(376002)(396003)(346002)(33656002)(52536014)(5660300002)(8936002)(55016003)(2906002)(54906003)(6916009)(86362001)(4326008)(76116006)(66556008)(66446008)(66476007)(8676002)(316002)(53546011)(122000001)(478600001)(7696005)(41300700001)(71200400001)(9686003)(6506007)(83380400001)(38100700002)(26005)(186003)(38070700005)(66946007)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6972 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: bc9f2c89-04f5-46a1-1e97-08da68969587 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sz21iGWyppVg8Oz6wfDkjuWow8sUIDifG9dqRZXEXQizNX9gKIoJXpeV0AfOxErYLH4BLaAw6fo3jUgGb1jNUJrm5EqJq8Fs+jCjavsP5dfGnZtajXwrpDESGA1uXtZMcXyWqjkNn2ApXojyio22fsW6tMJdjxUBT6IBr5kmZEjYP/M0oNW13w+VX8Ix+JsGkkJoJ4+hOU46ghkob2ZMG4oRB6j/EgHH/UpWhEj3j9GPNDiZ1+HlUiuatUWpbBx5F3I37cy9lIg6DJgLSlYh/aH/xVsfzU1SoZLrfKmwIduVMbxJc0rijoN0Ar+Ez+buSlXFSg3gZ+XgV38Om71TWfxtQlkI2UmlZQZJwvG7/e0H5+aYWJDGREwl0orxlHcBQg4IToCUCziymSBUzdQ1qv8IrN5doAuAXRuB6lgBSaLB7IYfhnSzXXiDIokV4wOVptnYlUALkci58Bdgq6jXBw/WH2bWj+4tMEy9u1FposWQYxQB5GxNJ5BFKG1Qyb5Src8LK8Vh7ONqnYr22NNSHnFhESHH6Evs4XC/sSB9hwTWEjBPVIIBlCHLEFXHkSn9xzJlI5vjj7ntWBnoiRYzkOTkShoaGZC63v73YSUGre35vJqp8PKDRW8OKXtrOePnOgMwxomx6efdIyxbNuZz9mRQEiXXeJ0ukfQau2yRarnIMv+lBRqkvSLTOSUfv9nZuXVlgR2r8Ksqiu+olrgElRWJj8tQl8iZAd+PFEwVUeeTVVfjJZNINoKtfzydCmBCaE+E6nR4U4vsiFrjD8s9ccytisCufZjCFWx5CCLkf3H3o1M71snszOeaHrJzJq2p X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(396003)(39860400002)(46966006)(40470700004)(36840700001)(36860700001)(52536014)(82310400005)(8936002)(33656002)(40460700003)(86362001)(6862004)(356005)(478600001)(82740400003)(5660300002)(81166007)(316002)(54906003)(4326008)(8676002)(70586007)(70206006)(47076005)(336012)(186003)(40480700001)(55016003)(83380400001)(53546011)(7696005)(6506007)(41300700001)(2906002)(26005)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:22:07.5975 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 75eb83b6-e654-44f1-d873-08da68969ab9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6956 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gU2VudDogMjAyMuW5tDfmnIgxOOaXpSAxNjoxMA0K PiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiBuZCA8bmRAYXJtLmNvbT47 IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+OyBHZW9yZ2UNCj4gRHVu bGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNz dGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBXZWkgTGl1IDx3bEB4ZW4ub3JnPjsgUm9nZXIgUGF1IE1v bm7DqQ0KPiA8cm9nZXIucGF1QGNpdHJpeC5jb20+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmc7IEp1bGllbiBHcmFsbA0KPiA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBb UEFUQ0ggdjIgOS85XSB4ZW46IGludHJvZHVjZSBhIEtjb25maWcgb3B0aW9uIHRvIGNvbmZpZ3Vy ZQ0KPiBOVU1BIG5vZGVzIG51bWJlcg0KPiANCj4gPj4+Pj4gU2VudDogMjAyMuW5tDfmnIgxMuaX pSAyMjozNA0KPiA+Pj4+Pg0KPiA+Pj4+PiBPbiAwOC4wNy4yMDIyIDE2OjU0LCBXZWkgQ2hlbiB3 cm90ZToNCj4gPj4+Pj4+IC0tLSBhL3hlbi9hcmNoL0tjb25maWcNCj4gPj4+Pj4+ICsrKyBiL3hl bi9hcmNoL0tjb25maWcNCj4gPj4+Pj4+IEBAIC0xNywzICsxNywxNCBAQCBjb25maWcgTlJfQ1BV Uw0KPiA+Pj4+Pj4gICAJICBGb3IgQ1BVIGNvcmVzIHdoaWNoIHN1cHBvcnQgU2ltdWx0YW5lb3Vz IE11bHRpLVRocmVhZGluZyBvcg0KPiA+Pj4+PiBzaW1pbGFyDQo+ID4+Pj4+PiAgIAkgIHRlY2hu b2xvZ2llcywgdGhpcyB0aGUgbnVtYmVyIG9mIGxvZ2ljYWwgdGhyZWFkcyB3aGljaCBYZW4NCj4g Pj4gd2lsbA0KPiA+Pj4+Pj4gICAJICBzdXBwb3J0Lg0KPiA+Pj4+Pj4gKw0KPiA+Pj4+Pj4gK2Nv bmZpZyBOUl9OVU1BX05PREVTDQo+ID4+Pj4+PiArCWludCAiTWF4aW11bSBudW1iZXIgb2YgTlVN QSBub2RlcyBzdXBwb3J0ZWQiDQo+ID4+Pj4+PiArCXJhbmdlIDEgMjU1DQo+ID4+Pj4+PiArCWRl ZmF1bHQgIjY0Ig0KPiA+Pj4+Pj4gKwlkZXBlbmRzIG9uIE5VTUENCj4gPj4+Pj4NCj4gPj4+Pj4g RG9lcyAxIG1ha2Ugc2Vuc2U/IFRoYXQncyBub3QgZ29pbmcgdG8gYmUgTlVNQSB0aGVuLCBJIHdv dWxkIHNheS4NCj4gPj4+Pj4NCj4gPj4+Pg0KPiA+Pj4+IE9rLCB3ZSBuZWVkIGF0IGxlYXN0IDIg bm9kZXMgdG8gYmUgYSByZWFsIE5VTUEuDQo+ID4+Pj4NCj4gPj4+Pj4gRG9lcyB0aGUgdmFsdWUg YmVpbmcgKHBlcmhhcHMgZmFyKSBsYXJnZXIgdGhhbiBOUl9DUFVTIG1ha2Ugc2Vuc2U/DQo+ID4+ Pj4+DQo+ID4+Pj4NCj4gPj4+PiBBcm0gaGFzIDEyOCBkZWZhdWx0IE5SX0NQVVMgKGV4Y2VwdCBz b21lIHBsYXRmb3JtcykgYW5kIHg4NiBoYXMgMjU2Lg0KPiA+Pj4+IFNvIEkgYW0gbm90IHZlcnkg Y2xlYXIgYWJvdXQgeW91ciBjb21tZW50cyBhYm91dCBmYXIgbGFyZ2VyPyBBcyBteQ0KPiA+Pj4+ IFVuZGVyc3RhbmRpbmcsIG9uZSBub2RlIGhhcyAyIG9yIDQgY29yZXMgYXJlIHZlcnkgY29tbW9u IGluIGEgTlVNQQ0KPiA+Pj4+IFN5c3RlbS4NCj4gPj4+DQo+ID4+PiBUaGUgZGVmYXVsdHMgYXJl IGZpbmUuIEJ1dCBkb2VzIGl0IG1ha2Ugc2Vuc2UgdG8gaGF2ZSAyNTUgbm9kZXMgd2hlbg0KPiA+ Pj4ganVzdCAzMiBDUFVzIHdlcmUgc2VsZWN0ZWQ/IEknbSBhZnJhaWQga2NvbmZpZyBpcyBnb2lu ZyB0byBnZXQgaW4gdGhlDQo+ID4+PiB3YXksIGJ1dCBJIHRoaW5rIEknZCBsaWtlIHRoZSB1cHBl ciBib3VuZCB0byBiZSBtaW4oTlJfQ1BVUywgMjU1KS4NCj4gPj4NCj4gPj4gTG9va2luZyBhcm91 bmQgTlVNQSBub2RlcyB3aXRoIDAgQ1BVcyBleGlzdHMuIFNvIEkgZG9uJ3QgdGhpbmsgd2UNCj4g c2hvdWxkDQo+ID4+IHRpZSB0aGUgdHdvLg0KPiA+Pg0KPiA+DQo+ID4gWWVzLCBzb21lIG5vZGVz IGNhbiBvbmx5IGhhdmUgUkFNIGFuZCBzb21lIG5vZGVzIGNhbiBvbmx5IGhhdmUgQ1BVcy4NCj4g PiBTbyBpcyBpdCBvayB0byB1c2UgMi0yNTUgZm9yIG5vZGUgcmFuZ2U/DQo+IA0KPiBQZXJzb25h bGx5IEkgdGhpbmsgd2Ugc2hvdWxkbid0IGFsbG93IHVucmVhc29uYWJseSBoaWdoIG5vZGUgY291 bnRzLA0KPiB1bmxlc3MgcHJvdmVuIGJ5IHJlYWwgaGFyZHdhcmUgZXhpc3RpbmcuIFdoaWNoIGdv ZXMgaGFuZCBpbiBoYW5kIHdpdGgNCj4gbWUgd2FudGluZyB0aGUgdXBwZXIgYm91bmQgdG8gYmUg YSBwb3dlciBvZiAyIHZhbHVlLCBpZiBmb3Igbm90aGluZw0KPiBlbHNlIHRoYW4gYSBoaW50IHRo YXQgdXNpbmcgcG93ZXItb2YtMiB2YWx1ZXMgaGVyZSBpcyBwcmVmZXJhYmxlLg0KPiBIZW5jZSBJ J2QgbGlrZSB0byBwcm9wb3NlIDY0IG9yIDEyOCBhcyB1cHBlciBib3VuZCwgaW4gdGhpcyBvcmRl ciBvZg0KPiAobXkgcGVyc29uYWwpIHByZWZlcmVuY2UuDQo+IA0KDQpUaGFua3MsIEkgd2lsbCB1 c2UgNjQgaW4gbmV4dCB2ZXJzaW9uLg0KDQpXZWkgQ2hlbg0KDQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:37:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:37:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369372.600749 (Exim 4.92) (envelope-from ) id 1oDMG6-0005Pg-NT; Mon, 18 Jul 2022 08:37:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369372.600749; Mon, 18 Jul 2022 08:37:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMG6-0005PZ-Kb; Mon, 18 Jul 2022 08:37:42 +0000 Received: by outflank-mailman (input) for mailman id 369372; Mon, 18 Jul 2022 08:37:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMG6-0005PT-Aw for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:37:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e2b23d76-0674-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:37:41 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB5616.eurprd04.prod.outlook.com (2603:10a6:803:e0::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 08:37:38 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:37:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2b23d76-0674-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YB0TVyxLt8bWSRR+Srdlrz2EMoVeXqOr3ZFQ6xvlMMWyt690p+qnLfYIQzSoDAA4YGSFZshBRekObvNNO1qKYIgb1mNaHe2HoBg8Sit5uEjFc+AtFuDLUYamz2N+DVbkj3EgblTeUSamF2aawGfW3UhKFwAlse9cslCmR/ftxE/67Vk08hOsLjczwU3RbwmlRMtWpRL+EH9Nc5fx9khXpLStI8wP0z3ukOuog2UBOblEOEiebMLByFTI1OKHGy26SJfXQapLaEJi70tb1WDI/+g3PAhOGExY03XMi/Mbya4+YlSD7uyrj7JuqHCWrMYCbBHjahBu8p6RMk8jzPMabQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c9D/Ywffqtx99+quMO0eYCLpSRFiRiHpqbZLvUVT6VU=; b=N+gR5sURQFTln0U/JkgOujAJkvLpJMILIJ0WGbVWoW8KsgdLl0BNscoufJJnXvvtpu3GUNTVLg85lVDcEWZG5IU9XqgyeXREkCz5s6FKbA5OoVKJfwtWGe1ZI1OZ+6LQjx1R8uFrMzx12FrCtDn8F28SCSuOSHUJ/oh9MYjLuo2XtqPb8MXX/10WKxLuxvAZJ5M0OWQZ9F1dvb2d/Ju1yUPtMfZ3A8OzExSHzPo/kjp8gO+ycfYKqH+EZqJoEPXPoTrRZOzoUNa1Mj1pPhsR/FnVK8d8k4qZjUAlHu5PRO1d2XhML9n4bCsZD3bpG17wwVB5maIUFOUa0n4L2y1+FQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c9D/Ywffqtx99+quMO0eYCLpSRFiRiHpqbZLvUVT6VU=; b=V7dmyPrqthQTm7/mOZKTGwT7V7li5GuBHC5LnVGHicQ6FpJSWiK5npFMPJdhk5DprVqPIOxVeBhxyoou6lqkbLyYleR81YvoaWcBt9lUxU3pQ1teKD2ARwE4lpoVy0hxU6apF+JrIHk4CMBlLXnmfRs+5DtoPgysuBaa7RoFBRzchgA46lNNIUmTIyO6M8pb7tXDCrIItiGqQrf5hj4Z2rPbmYQbg16Ixfct5HaCNPsZ4RmXnX5F8go/ONwjAyIU/fjG5KOPpg3lPGxYGT/v7aOEI/vrhgBQ6e8GLm6ADnwCkab5Mo5PVefkeDTKtCx7GOQAVFxbpnoUFfPPE3BBog== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <414c8615-6449-89e2-d119-14b0198d89bf@suse.com> Date: Mon, 18 Jul 2022 10:37:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Arm64's xen.efi vs GNU binutils (and alike) Content-Language: en-US To: Wei Chen Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis , "xen-devel@lists.xenproject.org" References: <04b5e393-e7ad-956c-dbea-8203b6846726@suse.com> <911597d8-4655-6963-853a-7088044a3e20@arm.com> From: Jan Beulich In-Reply-To: <911597d8-4655-6963-853a-7088044a3e20@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0166.eurprd04.prod.outlook.com (2603:10a6:20b:530::27) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6978c874-df1b-4be5-2706-08da6898c552 X-MS-TrafficTypeDiagnostic: VI1PR04MB5616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kXId6Q0Esa2bIu7NW07RgWBSQzu9i1QHjmuUuSRlKQwq2GglrL0jUwImp/o4Mc1MtfnLzw50dU5cTtR8pNgWhfwSftoMZ77r6H6RGO+AmwAj1vJexJMQgOqVjxlnKA7DeWD89QdzpCuIX9shy07useVrZdHuKNilmDPATUWJwtd8rx0O7OJPaVFHM5XHUrr/1hJtqCiJrh0T2+XzwxxTJZfiQELBJHGFlre367t7UPHy7QattZ3pIJtlLg5UGESBq6+U8Jp6xa+7CjRVLgVh0moZICmdO6EjpY1Py/fB1xd59Ib8E6hPrrVw/WAdM/f3j8ryNiFMbTPQKZC3imfErFfVBkjAt8HeNO37QixrVpulhn0/fkiDljp09xGwYDHV2zzvf4L0bheCqATlGk+VNvQKghJ9p2V/Bh5gf+cxpNXivJBToghz8h1rGjYrknrNi6BUpLApObuH4B1Lc/ulzDhO0RQKBg5i7ntjjEL2Gq1AkvFIsmHmPFMxWiI16V1Xt15k9nLoPwvOTckG7I2WPn6UwdctEMRzevROs058G82BzifLe4otw9x2PF1IXj/Sm1uZhqn8GZsVY+FTyYkCzf+TlNY3u900cziB95BiW15Iu6LRwG8jcYKWepr5bk12O3gOuht70tDzZ6wzu+jghROClxez5Y/65sPx4X10/rGXEz0zJ1a+Sm3o6CSnykLu3yJfEwhO67G6p52DMFATWZ9CZExLGV4yrq80BMULDXKDcPNGCFIyQDqNtQXUOhLZxjL2wumII57kO5yqifxbJ/NbDd8+YBU3dqB3kxYzAbwVX8gnkoGlW9ZqChVP2wB/3r67RUs3kMUs49hTyFrXAk8dsc4GNIUX7tRubG8Gn4M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(376002)(136003)(346002)(39850400004)(6916009)(38100700002)(316002)(66946007)(36756003)(66556008)(31686004)(54906003)(8676002)(4326008)(66476007)(26005)(2906002)(41300700001)(186003)(6512007)(83380400001)(5660300002)(2616005)(6486002)(31696002)(8936002)(53546011)(6506007)(86362001)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTQydzAvRjc3MHZGaDBDbnFSanM4cHRkYWRBVWdNaHZ3T2MvVGozR050VnJH?= =?utf-8?B?SUFXMUFVd1FlcTFSSUtTc1ZiSjNkTTM1K21jeVF4MFczaHR3Z1VMVlV0ZjVS?= =?utf-8?B?eVd2aEJiWWt2UWw5eDkyY20vNy9BMi9XSkJEQUs2M0o5UytaUGRzMEJib2xa?= =?utf-8?B?QmowTW5pVDA5aE1kb2Y3ZXlBNEQrRExUWEpINGg3alJVQVBHT1Zua3dIYk41?= =?utf-8?B?enVBaFRubkZKTjdHTHhoTGp6Yzl0ZUFmcThiaC9CK2VYb2oyZEhLcmhOUzNZ?= =?utf-8?B?czFNdCttR2JseGZCaU5tdnpPTjEyMXlwc2IzSzlUMWg2TytkclVBVFdmaDNU?= =?utf-8?B?d1B1Y2M5MXgvRjh6eWlQTXFUb3lndm1PWXBRbS9xK3FCbFNOc3JmMHFYUWtT?= =?utf-8?B?dEVtTXlIL2p6dW1CSnNEYXM4VHVpbjlJU291L0Vlb2NMcjZrYUkwK25DeG93?= =?utf-8?B?eVpjUENRUk8vLzVaZjZibEYzbXhoRUNwVHViWnorTDFNVWtxZnBsQUl3MEFP?= =?utf-8?B?cXA1VURzdnFTYjdJY2llZE1QbXJRSDdmT01oazQ0MElYSGY5Tzd6blVMbzA1?= =?utf-8?B?MlpRV1BHVVBteFNqYkNMMGg0K3U5TFVUVjB4ZmhaeDFaWEhkcEVVeTl4NVl6?= =?utf-8?B?dGdqWVdqQTNEVDBkMUF1b0M1MUg5blc3YXVIUnQrUmllektrZGZHbEY0Qk1p?= =?utf-8?B?RTRTSDhWSDMzbFRMVmk3akVtUGt1OXNXSDU4bnZ5MGZjajdIT25GUDZ3VzRO?= =?utf-8?B?ZWl3Q3Z6MHpoRmVEYzRLMGk1NGJGaTR2NWdGMEhVeEVWMVlzOE43dUU4NXVO?= =?utf-8?B?WktLUy9jaTNLSkJzbWg4RTYvaWRJQWJjYzBCSlEzNWd5dlAra1BhbVZyZTFD?= =?utf-8?B?R20zV3MvODBSK1A4Ykt4M3RPUnFmSzhtQW40K3RPNmd6SHhiaXZZOFkzcVZJ?= =?utf-8?B?ZFpWYTNwcEJjeisxdTR6bXEwUWFRNW4vcmNiTWNWZzlIdkFwckY5eGNxUHhr?= =?utf-8?B?ZFVucm5Kc3JjbkI5TzZnRDJPb1hWd2Z0ekdkMnZocW5EWVgwKzNEN0RzMENS?= =?utf-8?B?TURKRHdTN08yOTR4SWVnQ3YrdVlIK3ZTT1IrRmxIdHFsM0l2RXp2R2JDUDJq?= =?utf-8?B?TzV6UEIzc2dVbHhXN2RLdnRQUGpFZElvNEdHZ2VVd2x4K00vUFY1aWwzYWkv?= =?utf-8?B?R1hvcEZYcGhsdlF2eWFyQlViRis5NXlycFZQc2hRVlJPQU42ZW9GOWZQNzFP?= =?utf-8?B?Zko0SjRTUkpseXJhb01pSE8wZ2JLemo2TlFVVmQ3Y05jcUd4MVVUdWVCL2NF?= =?utf-8?B?N1pLOThKVUczNzZObTJGV0Noa0twM2FHcFhVTmRhT0Y4UnlDY2dxWG9ta2dq?= =?utf-8?B?WXhrK284ZTQxaThzbHM5b2Q2bVNkUFBiSFc1cWYvS1BSSC9lTmxjQ0lnZ3lJ?= =?utf-8?B?VHYwVi9GMUtpNkxDSWRNN2tvU0pWdXBNQ1dXd0VKNEhJTnlaZUg5Q2wvdkQ4?= =?utf-8?B?WXhOWmVGYXNrZjZYU2kzYTJTVXQzN09MRTZpWVh3cVgxYmI5aHlkR1gwOC85?= =?utf-8?B?R1Q3UlBxRHVialFFRThwNDdhQi8yNUtUdUw0dG9jb0dqangrbWJEVHFFV1Nq?= =?utf-8?B?cG5zZUxqVis4QkxkVnB6Y09zQ2JBQjdORVlqbVNzSlFiNXFzZFJOUDBiMFB4?= =?utf-8?B?Ym95UitvbHc0MkE1cmFqWno2OG02WFRvS1h0VjIwMVkweXVvaFFLUDZMeWlJ?= =?utf-8?B?UG1oOEN4TGQySHd4NHFqTE9FQmNnTytDd1FYUnhJRXZBZHFEVmZleGdRRC9t?= =?utf-8?B?azJkbUNhZjdGV1RTYU9GbUprT3VFelRGbjZDeWlCRm40NkJiM2VEV00zU2RU?= =?utf-8?B?eW93b2JwcFdXaGxrTDA1anh6RVpKSWNOc0l5bTRSTFlDRERheEFhUTF0eEdx?= =?utf-8?B?Uk55c1JMMXRMSysyMkc3dWUvZXF6MGQrNHlIRW9wMENSWEtHcmt3Y2F4dlFN?= =?utf-8?B?ZzNocG9ZNUVPVWw4TStoWmgxRzUwY1E3bDhyRFFPcHdIOTZuSEdZK1pDeTNj?= =?utf-8?B?MTQ0RHdDanRIMDVTMzl4ZWE0RVoyS0hTV1M1TFpKSUNEZVpTK3dmelVjUUl5?= =?utf-8?Q?yetQ9xrd59UT7GIrJkPo88j3t?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6978c874-df1b-4be5-2706-08da6898c552 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:37:38.2409 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8YY0Nwe/fyL8gO5uhmPlUyseM8CHKWUdgB87Y8gLJXJci+tlwrqw1kgYm99I14M+Gf9gM5UGqtbuWFUDM3vMyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5616 On 18.07.2022 09:43, Wei Chen wrote: > On 2022/7/11 22:32, Jan Beulich wrote: >> the other day I wanted to look at the basic structure of xen.efi. First >> I used my own dumping tool, which didn't work. Then I used objdump, >> which appeared to work. I decided that I should look into what they do >> different, and whether I could make mine work as well, or whether >> instead objdump is broken and shouldn't work on this sort of binary. >> While I'm not fully certain yet, I'm leaning to the latter. This is >> supported by GNU objcopy corrupting the binary (I assume this is known >> and considered okay-ish). >> > > Did you use x86's objcopy? AArch64 GNU objcopy does not support any > PE format file. So I'm curious about the version of objcopy you are using. I did use an aarch64 one, yes. Are you sure (partial) support wasn't added? I've had no error messages, just a corrupt output binary. Btw, this is 2.38's entry in bfd/config.bfd: aarch64-*-linux* | aarch64-*-netbsd*) targ_defvec=aarch64_elf64_le_vec targ_selvecs="aarch64_elf64_be_vec aarch64_elf32_le_vec aarch64_elf32_be_vec arm_elf32_le_vec arm_elf32_be_vec aarch64_pei_vec" want64=true ;; Clearly PEI (the name used in GNU binutils) is included by default. >> Many problems boil down to the (ab)use of the DOS executable header >> fields, yielding an invalid header. The first 8 bytes are instructions, >> with the first carefully chosen to produce 'MZ' in its low half. >> (Oddly enough Xen and Linux use different insns there.) This doesn't >> play well with the meaning of the respective fields in the DOS header. > > UEFI executables are regular PE32/PE32+ images, Arm64 EFI applications > use a subsystem "0xAA64". PE32/PE32+ require images to have a DOS header > for option#1 backwards compatibility,or option#2 to prevent images to be > run in DOS. I think Arm64 EFI applications select option#2. In this case > I don't understand why we need a valid DOS header? For my understanding, > we just need 'MZ' for file type identify and "offset to the PE header". This last step requires reading a field from the DOS header which hadn't been there forever. Therefore one first needs to establish whether the field is actually inside the header. Yet the fields used to determine header size have been re-used (abused). > Other fields have be re-used by other purpose when load Xen image as > binary. And lots of bootloaders are following this header format to load > Xen (Linux, or other Arm64 OS/VMM) images. Therefore, it is not > currently possible to construct a valid DOS header. Which would carry the implication that well-behaved PE processing tools should refuse to work with these binaries. >> Subsequently there are a number of .quad-s, some of which again yield >> an invalid DOS header. I'm therefore inclined to submit a patch to >> make objdump properly fail on this binary. But of course with both > > I have not used objdump to dump xen image successfully. I always use > xen-syms for objdump.Sorry, Maybe I didn't understand your question clearly. xen-syms is an ELF binary. That's of course easily dumpable. The question very specifically is xen.efi, which ought to be a valid binary (and hence possible to process by tools understanding the format), but isn't really. As a result the question is: Should GNU binutils be able to deal with this half-broken format? Imo the answer can only be yes (requiring all tools to properly handle it) or no (suggesting all tools to properly refuse to work with it). >> Xen and Linux (and who knows who else) using this hairy approach, it >> may end up necessary to continue to "support" this special case, >> which is why I'm seeking your input here first. >> > > Yes, like I said above, most OSs, VMMs and bootloaders currently follow > this format and boot protocol. Therefore, it is difficult for us to > completely remove it all at once. > > > >> Furthermore the fake .reloc section overlaps the file header. The >> section is zero size (i.e. empty), but a reasonable PE loader might >> still object to its RVA being zero. >> > > I am not very clear about "overlaps". Is it because we are setting > PointerToRelocations to zero? What is PointerToRelocations? There's an NT header field (entry 5 of the Data Directory) which is supposed to hold the same address as the .reloc section's RVA. And it is the .reloc section's RVA being zero which makes that section live at the same address as the image header (both at RVA 0). The section being zero size, it can effectively be put anywhere, and hence I cannot see why it isn't put at a valid address (outside of the header). As long as it comes ahead of .text in the section table, it would e.g. be fine to live at the same RVA as .text. (Note how on x86 we had to adjust the RVAs of .debug_* to match the general expectation of RVAs of successive sections to never go backwards. Without that linker script adjustment GNU ld would have produced a broken and unusable binary.) Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:39:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:39:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369378.600760 (Exim 4.92) (envelope-from ) id 1oDMHX-000632-5q; Mon, 18 Jul 2022 08:39:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369378.600760; Mon, 18 Jul 2022 08:39:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMHX-00062v-2s; Mon, 18 Jul 2022 08:39:11 +0000 Received: by outflank-mailman (input) for mailman id 369378; Mon, 18 Jul 2022 08:39:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMHW-00062n-2h for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:39:10 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10056.outbound.protection.outlook.com [40.107.1.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16f8e22e-0675-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:39:08 +0200 (CEST) Received: from AM7PR03CA0014.eurprd03.prod.outlook.com (2603:10a6:20b:130::24) by AM9PR08MB6722.eurprd08.prod.outlook.com (2603:10a6:20b:302::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 08:39:07 +0000 Received: from VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:130:cafe::57) by AM7PR03CA0014.outlook.office365.com (2603:10a6:20b:130::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Mon, 18 Jul 2022 08:39:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT058.mail.protection.outlook.com (10.152.19.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 08:39:06 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 18 Jul 2022 08:39:06 +0000 Received: from 335e4c3ae968.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E8A7AECC-1FDF-48FA-9518-4B23895CEA61.1; Mon, 18 Jul 2022 08:38:59 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 335e4c3ae968.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 08:38:59 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AM0PR08MB5058.eurprd08.prod.outlook.com (2603:10a6:208:160::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 08:38:56 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:38:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f8e22e-0675-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gfuIO1/8/Da4JfFlGsu3YLUA8aOE7cxH9sC9h6wxuG+L+/OE8I/30vJiEocjK5aFXD19Ns59vyzGDhGY2nxpgcFxOCXyAZRok4KtMH5O4AkkAtTlKK71IkxD/+DMlz3QobC+k7L8hj4NufwJD4OFzNlOAyrFpdu0sFum8fHlImwluTnJIFA9/i8xmZ7Fa5iezLl2ZK1tI72NC0LVLvzOwpaau6ve7c+jNraDdeLqS6xKOwIL1KUL0fufG7StRRXLz+dxCIZgwbVp5frOaplkqah/sFyl5bp8/vrXy4QEzYnyjlbph+Qci+pJONUK1MXiV91JMZC1HTckCD07kCinPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSMW2xPomPgsPEXkhoXTJ54KGnxk4Wc+qdpif4iCmrc=; b=Imi1gYfbGRXnKJoKH8CyMCBup9Bkv5i/QzSaPEWVmEfiCo8xPacEN1MAhcI9VxoPIK8nBByv2fQvxDZB87i+GBLJ7Gmjop7BHCqEwAmN7srvHM1AMXpPjaJTq7nGqQdipsqTTvbCgfM2afmN9bmlJ2V5ZGcvxS2QVlNQ3JuIGI4SPG75vOocFAk+AlkTtF36eBvJhmP0AEE5gUS3qXR6ZDuKsr4M/+yQO9aqhOsP5v+ZwlYrV4XvO9QrN16oRIXZ9K9KSEkm26f3QSC4jDbIa3Tfu9W6JVHS+tfuJn1Dj/aCqSBDVVn8YUvxnFgFE/TuxFCRFsBIXSTKzKRwDdKihA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jSMW2xPomPgsPEXkhoXTJ54KGnxk4Wc+qdpif4iCmrc=; b=t03P1t+j3E141tPBKv6+1GhW7mrT1663l9peEbVZS+EON2pnfTp0FAppmDRgWRIf86dvzVXdtvkwvkNzp+C3bzZfk2cTNIHYyzRmSkk6OCugiDC+bptLdMHJud9uZVI9USkK8QML+ClBtvmcIxAQz8ivDNXyzxLVqambFF7/xOk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e64e0e2b5116f203 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbEOs+gJeK9zAM5KkvJVNLjxEc78Mfleh6eGFEE5czLd1uuzkF+OBihJjHMWZhR6QBuLTIRGunQ/LTRZkmYZAT1pOF/FmYs6AfrVX2O37kV15jovGpIL5iYObwMuRUePmhecBLg6oxr9q4eCy4TlbWspxfLvuD1DJ2MsMTf2A4dprfp7WtJKBImDy4andcqjdV+1rO49MQxoPGHRIyy1b4JUlYb/4Ish0UaHhU74nvxRkIs7mgcX33/F9GF2gNuc8DjqUDXny7MxNDhoc58m6vScugZWP85ILak18XYb+Dg23dhN/bCgAb3gcp22vz+j3/ej7LOYI9WcWrEyRGh5VA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jSMW2xPomPgsPEXkhoXTJ54KGnxk4Wc+qdpif4iCmrc=; b=LaIw9six9hjanUQVki+Y4EM4F+9xUA6btdPj4qoRMeKMUZo9uo6dSxznad8T8kWeknuUmJEf/PS6IkR3cwPO9CJstdIMP/8bF866VdF3HWZrzfb1EyEeEiJq5+zKdMQPSQNLtHJqKVyUBk64pqBXPP6dDo9zFlTLefIgtqMAYbYk9XbYio7EzMSOViVHMApl3U3kcm/4LyZHSEnstouROXwbVsRlUZ+RzMRfv/knF0xRW9KHSUhwqgjCauEtH+rGytg/0eCRsxYbTNKTwikTat6dKU2hgKVHfRlehs23KJAr2af/BzNnKUNGFbxpcJnu7TOIBoP5ocuEwIB9gUzNiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jSMW2xPomPgsPEXkhoXTJ54KGnxk4Wc+qdpif4iCmrc=; b=t03P1t+j3E141tPBKv6+1GhW7mrT1663l9peEbVZS+EON2pnfTp0FAppmDRgWRIf86dvzVXdtvkwvkNzp+C3bzZfk2cTNIHYyzRmSkk6OCugiDC+bptLdMHJud9uZVI9USkK8QML+ClBtvmcIxAQz8ivDNXyzxLVqambFF7/xOk= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <6dbab639-8749-1120-2006-92171897a700@arm.com> Date: Mon, 18 Jul 2022 16:38:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu , Julien Grall References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> From: Wei Chen In-Reply-To: <20220715170312.13931-4-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SGAP274CA0014.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b6::26) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 54500ceb-dea3-4995-88d2-08da6898fa32 X-MS-TrafficTypeDiagnostic: AM0PR08MB5058:EE_|VE1EUR03FT058:EE_|AM9PR08MB6722:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Ya5NIUMSUK+MgJIcEa/alfEfpPdo8pQwOllnvW/L9a5oNEtY4Hg4diIdceydFjFw9hdyX23M0j9d2xVL5jxPwily04v32EBJ2PuKUeUIIrVDojzavuBs7aeSwc7tQm0QxyqE/hGxQPQwyhgLHtyiWVdK0TAylKOWwWegk+mBe0s6MfOCLLxZ4Z47Kx3hTr7yiQAE5glBcgXbAG9RAkiivWX3F7joouzAO0Qj+1/FtCdqAdS6Pz/qG0+Jm0cxMTTokNoHKheW946MOer4muHhpM9pjCFq8TSf/rHE28UgAR+BFBC6isS5FGhtPByTjSczXMksBWZV/Uzd+3DIxSTrJiftyPN1+tTzQTuXHQNMLpLYbiKGq/1qqmqkhRN/E2Sjb1Yb+Ff86AAZk46uPRCc0hRkQEAal5R9M+ynN/NqQAjmQ94MtLsscSGOoUCseGF9L4z7BGXJBZuHVT3Wk5xm1rnW8AiPkOfqe8Zc9zg5HY59CwRW4P1n4ZQ07tRtP605imcceK+GMdxQQgCfibIMm1HD84UJd/FvRJb4OlLZeTp0Zly7maqpKj6uDRXWX12lghZ368xS6L6sSEAfgNIq46TC7EHaSPtPgSowtTne9lhB8ustN2jGtZD1lLefPAc9BKN++enecfCDq9ITk+Vth6TKuPv5BbcyWVPqYb9TwmjSGiFUvgf8T5ZnMwDLLKrJDmWUeNe/ltfXQDbuIThzCYn3Q4aLc3qvhlceH0HGLUzSj1hmQgWTdE1T6Y/8UV9xSpHgYgRrycO0usBIbBr3+OBB4L/y2++DfxsxFzVvav+md7uYngC1Y3X9lUQPtuPXUGXpHTLUVrG0goshYwQ0JJRBvraaRyIaUznK1L9eyJM= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(8676002)(66946007)(4326008)(66556008)(66476007)(8936002)(316002)(54906003)(36756003)(86362001)(2906002)(31686004)(38100700002)(83380400001)(26005)(186003)(6486002)(478600001)(53546011)(41300700001)(6666004)(6506007)(2616005)(6512007)(31696002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5058 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 932048ef-5659-4624-384b-08da6898f389 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 864yz7hF5fLy6GPnG8cMu0e9I7x5S5aOIM7/eHlal6k5cvYdyPJnbDihHhgYXOT3JGNVYiPdYtehxJa6MdGpzfxGeTcxHCZ6RgfdmO6Nz0ky3hgk96seMpxWTanaN6/JlbvorS63kThDfWXBbVIe4quwVhO42StykJRgLoQtmNK1sHO9hyZH3HKfqkmbMx8hlhihiHxTldfsjYXhSQQ1xMEyH2oBPT53SMOd8SIdgaYMDbgDLbrarAlRXu/xfElBxvv5TL9f1YpXPRnzkA9b8RJ7zNTj+TJlsLqx4mr1ipWKO3EDtUu7t8EX4K097D9s2Jh+lIHY8HL1I5MsBxgJvATyEi1ZOHMcHaXybPS0FiOxKG3Pgqp+o9fTQSQqjGtYGX7C6jLVEX7qxcWum4PAsoA890hy9Ytaeh9xhGrEcJFDQDTO8cHzNzEBWxlJCt7eXFGOKU/6a7Btpyi4l1AXwVpP9VCf7a5WFFD8wbCWf5LAv+vA02WT/zqAWn3s430KLmpPxuQBYJrKPWGC3TbaX4r+uE3T7vltKwkeu1o86oZ3dxSI+tGOetdGyWTENQw1IOFw8Ehslp/6soRVh+OwotHwNLRRB9TsuUcnnb8utEG8LMRRZoGZT6PsYqU1uRaWTA9D3lcH93Xao5lVE02+4IB66S+buJZBsr0n9KUqnqlSm/0lC/02AmX8A1gf6NpXbosBQQwVpKkjObWDmPx6GOmY5cBtQVwwGDzzhbEgtlmbB0GuifkdV0nbpoN6LhCPlOXV56kG5quhF2NSiv6p9pdtkhKbERFGvKunAbr1vu2VqQIk6r2hPUEsXsu6OJaAcFLrTM/bOwJWhunNbhVh0OXoJGoae1vT/QW69TTZ6cQ= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(376002)(136003)(46966006)(40470700004)(36840700001)(83380400001)(6512007)(186003)(26005)(41300700001)(6666004)(2906002)(40460700003)(6506007)(53546011)(478600001)(36860700001)(6486002)(5660300002)(2616005)(107886003)(8936002)(31696002)(86362001)(316002)(82310400005)(356005)(82740400003)(81166007)(4326008)(8676002)(54906003)(40480700001)(70586007)(36756003)(70206006)(31686004)(336012)(47076005)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:39:06.7342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 54500ceb-dea3-4995-88d2-08da6898fa32 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT058.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6722 Hi Julien, On 2022/7/16 1:03, Julien Grall wrote: > From: Hongyan Xia > > The idea is to split the range into multiple aligned power-of-2 regions > which only needs to call free_heap_pages() once each. We check the least > significant set bit of the start address and use its bit index as the > order of this increment. This makes sure that each increment is both > power-of-2 and properly aligned, which can be safely passed to > free_heap_pages(). Of course, the order also needs to be sanity checked > against the upper bound and MAX_ORDER. > > Tested on a nested environment on c5.metal with various amount > of RAM and CONFIG_DEBUG=n. Time for end_boot_allocator() to complete: > Before After > - 90GB: 1445 ms 96 ms > - 8GB: 126 ms 8 ms > - 4GB: 62 ms 4 ms > > Signed-off-by: Hongyan Xia > Signed-off-by: Julien Grall > > --- > > Changes in v2: > - Update comment > - Update the numbers. They are slightly better as is_contig_page() > has been folded in init_heap_pages(). > --- > xen/common/page_alloc.c | 35 ++++++++++++++++++++++++++++++++--- > 1 file changed, 32 insertions(+), 3 deletions(-) > > diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c > index eedb2fed77c3..2b99801d2ea3 100644 > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1779,7 +1779,7 @@ int query_page_offline(mfn_t mfn, uint32_t *status) > > /* > * This function should only be called with valid pages from the same NUMA > - * node. > + * node and zone. > */ > static void _init_heap_pages(const struct page_info *pg, > unsigned long nr_pages, > @@ -1806,8 +1806,22 @@ static void _init_heap_pages(const struct page_info *pg, > > while ( s < e ) > { > - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); > - s += 1UL; > + /* > + * For s == 0, we simply use the largest increment by checking the > + * MSB of the region size. For s != 0, we also need to ensure that the > + * chunk is properly sized to end at power-of-two alignment. We do this > + * by checking the LSB of the start address and use its index as > + * the increment. Both cases need to be guarded by MAX_ORDER. > + * > + * Note that the value of ffsl() and flsl() starts from 1 so we need > + * to decrement it by 1. > + */ > + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); > + > + if ( s ) > + inc_order = min(inc_order, ffsl(s) - 1); > + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); > + s += (1UL << inc_order); > } > } > > @@ -1844,6 +1858,9 @@ static void init_heap_pages( > > for ( i = 0; i < nr_pages; ) > { > +#ifdef CONFIG_SEPARATE_XENHEAP > + unsigned int zone = page_to_zone(pg); > +#endif > unsigned int nid = phys_to_nid(page_to_maddr(pg)); > unsigned long left = nr_pages - i; > unsigned long contig_pages; > @@ -1856,6 +1873,18 @@ static void init_heap_pages( > */ > for ( contig_pages = 1; contig_pages < left; contig_pages++ ) > { > + /* > + * No need to check for the zone when !CONFIG_SEPARATE_XENHEAP > + * because free_heap_pages() can only take power-of-two ranges > + * which never cross zone boundaries. But for separate xenheap > + * which is manually defined, it is possible for power-of-two > + * range to cross zones. > + */ > +#ifdef CONFIG_SEPARATE_XENHEAP > + if ( zone != page_to_zone(pg) ) > + break; > +#endif > + > if ( nid != (phys_to_nid(page_to_maddr(pg))) ) > break; > } Reviewed-by: Wei Chen From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:47:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:47:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369385.600770 (Exim 4.92) (envelope-from ) id 1oDMPn-0007jn-0m; Mon, 18 Jul 2022 08:47:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369385.600770; Mon, 18 Jul 2022 08:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMPm-0007jg-UE; Mon, 18 Jul 2022 08:47:42 +0000 Received: by outflank-mailman (input) for mailman id 369385; Mon, 18 Jul 2022 08:47:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMPl-0007ja-IS for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:47:41 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20088.outbound.protection.outlook.com [40.107.2.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 47f8c078-0676-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 10:47:40 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by HE1PR0401MB2476.eurprd04.prod.outlook.com (2603:10a6:3:83::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 08:47:37 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:47:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47f8c078-0676-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iWiqeX7Hb3ZWJkPs+chvXDZjCUgh5mxomnmtdbzc8Vh54ZgU8pkMV0VRO5ME6turwmDVoKwSTemICYDfIzNelly64uRIoe8NcUTeag/W0OdKkDE6l+SAj0yUIaLtzOnIHjjBEM4LRPYpN3hAn4litsyUXFOaMUWjYKJKeuKdjBnCaj9OKCTFb36NRqpjuK1JUjml8By1uJnIBrS2RBurtD6iO1V3bbuc6odUqgtbS3gELF1PnFHZVQvoDajSpYWn/sFnvQVYV6RqoAIZbQ84nTl5jMgbTrL5yp7xBRIYeeUdrgLXsyyTJEaPBdVsOYvm+dbuCwuTEyx50jFoKJ2W6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uvsjDqGL2BujawmzknEtMFgCpnNttGWLdgUDtHSTwH4=; b=RT3LQwoGME3AgwiLjm6p4A17fqYTIpC+IdCxBL3ZwCIpzbB5BKhUq5+ZpjcAjV0ls/xqb4wRxDjyAdU089tjJW+GAzCTZW4MMxDtknv+8LA8CCjjl8JksdCXP6GRZ/mB8x0/92IZFgl67FJ65DVsT2DfQ5k+JF9DRzXfONVe18kCp/HEaAu9QoPs3VDEZ2pqJcCHAKN/U4kl06XoLYuswJS5WpfE/4PUuLEcvukFdaAtDhzmhcyfbLLl13uUqr4TMPOQtCc744Ld0+yJTTmiOrObSVoCAqlQoITekuWNlVWP1bW89CH/iPh3X0X3maTTdc+84WY6kC8muJyQIWlBLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uvsjDqGL2BujawmzknEtMFgCpnNttGWLdgUDtHSTwH4=; b=MyVaek/O+8lNfo6KyQd7xj7JTWzgSPnI5vhoZ0p3G0Ajeyway1tJ2GDtYbS84OgEVl59v2lQ9xDtdDRD6KMDKnWwJVHS7H8fBptEVsqzWb8USoXC0tTXMdfIN9eKoBVlvlDN9kqPUdxPY34yFeYR55kTp6160jT9bnmGcFC+9TtwE59c09Iok5n1kJdMQCVlBkeKnSP34ENuT1vmfigfkL1KXFsF21HUL112dIQ+fnoUNFL2g8nfuYA91qCb8X191xn6UAG3tvnhMsiumqYDUSMK6/DGgBKjfbWsglfu4/ohdIv7yJQerxGb0JQwrTtn0bqcTcBNn2rFyZXCfaA0zw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <48d5cdc0-3937-a5f5-5c0e-a0eee90342f3@suse.com> Date: Mon, 18 Jul 2022 10:47:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings() Content-Language: en-US To: Julien Grall Cc: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-5-julien@xen.org> <5CD19BFD-62C6-4409-A5A9-675D8F5FF795@arm.com> <8c6a788c-ccb9-fc5c-fdf6-870540eed722@xen.org> From: Jan Beulich In-Reply-To: <8c6a788c-ccb9-fc5c-fdf6-870540eed722@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::6) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcfad578-af38-40e3-81f1-08da689a2aa3 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2476:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AQrrAYBSQQWWgIpsrNWe6DL/VtXzL69W2y9kZdNL9UZ3nt7bFn9aIhFpVEAwxLHDR03aHBj/wv8eRZiuG+eCa0vOxUxrpn/SZ9IPVCegSlBGXwkMSplJl3W1pvuGCUqrD5qFk6tROhmVbCk7nUOiyo+mNdmhRmaHVmQIy5MpEx48CAJbgO+oDY0Ro4nbZjSZd2EWSYEcnv4N7ct/aiXZ4VO00l+4mGjIm4zQlaCD7ZbyHRvgb8kJVRHcLpDzqPu4RkFU6hXie9dp5gCayCQU6WYu7vTWm8fQWIW2ufIerVy6+RPYOJmENzyoKVglYRe3qyVOKW1Zz795mNbcFB8AlUfFitIxqBWQBcdWdl4cUmSPsJJUVtQbZ/K2Y5dMBnXpNi9KW1NB0j5COOQ3YOMMLQFOKnpZIo5kVhYikp6V1f4xMX7durRwXeonusLfggsaLw6ZV+ea0oXly9vu8RJoO7vvK9W4BLWzXAfZ7LGiiW9dXD75mszPRhIeYbBfKcikFymMEaQZvYTLb6CljSi1Pex8IHb9IoT6KpJjhOpooGqGKqJll0dZFZs0/qysUmaSNc9G859EoNrWL6IY3idG5qboG4c7xtX9tJ6OeZA0JTOaB19oJkGElAYQeCQiWCx4/8ZpENQQCfHjAGV3NSYcPHJN7D8XXcOr6rLl8PMNdcnvtf6H13uPnT5k7ERHuWXj2gXKm0XgJ0hWf3oprFqj5ibokn9g06v3eIHEZmZGDeJjP4UMPSAO+2hMOCmix8B79Ggstey1lMrR/dtuctsOPdINNfFWDmN+PRD/wpmW3UvNxTc6hypyqTTy+3mrSzMQNbtYpgKxY3uxsmLCndiqmg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(346002)(39860400002)(376002)(83380400001)(4744005)(186003)(6512007)(2906002)(26005)(41300700001)(86362001)(53546011)(6506007)(478600001)(6486002)(2616005)(8936002)(5660300002)(31696002)(38100700002)(6916009)(54906003)(316002)(31686004)(36756003)(66476007)(66946007)(66556008)(4326008)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UGx0TXdNSW5DNG96STJGL1dIQXVrVGM4Mld0K1cxSGJtUmhadUZ1elhDMmZv?= =?utf-8?B?YXA3aGpkWnZTZDMzdHRPUUlmZG1Ya1dFSUUyRUh4Qi9ubENEai9Id2RaaUFZ?= =?utf-8?B?a3VuNTJEZEVTZlljOWg0dmZiZEhXYTEwbXZSd0tNVDVFTktnUjdnNkxWQ245?= =?utf-8?B?N3ZNdm1EcjlPcEFuYitIcUw0Rk9Mc01qa016eFZZbDFSTWpaTTFvdVgrWU9P?= =?utf-8?B?RjVqV2FWc2I4aDJGNUZvWnhjMTZBRHZ6MDFwcG54WERVczFDMjFvdFY5U0Vv?= =?utf-8?B?U1ZnbW1FckpGRitXZndVRnBUdm4yQzk0L25ZcS9iMjBvSFovREk0YVpNWHpa?= =?utf-8?B?OUltTFl5Z00vdXFQSk1yTnBnV25FU0VxazdyOVo3VDFnSlV0Q3p4Tm9TaUp5?= =?utf-8?B?Z0g1KzRLdkNIZEJ5bllTTE40Z29zT1VUeHlScWF0anIzcVlKUWdaSmh3eDBS?= =?utf-8?B?dkpZak1KcG0zNjVRRGh0Yis4ekNtNW9GN0RzbnRUZS9zcXVHcFpTRE9zQWNW?= =?utf-8?B?eXJoR1BSVjc3M0lmcC9rK0xxQjlmMGNlMW8ySWthcEdiWFRFQ2s5SWRFUDVM?= =?utf-8?B?eUhNVEFkVFBKQTBaamtuV0swQlpaV011WHRWYStqeUlieXQxb0hVQ1dwMlUw?= =?utf-8?B?SjI0bU5KRm5UZk5IR3NBZ0xPeXVDOFh6RmRDU3ZvV0hkUENxemVSS1lQQjh2?= =?utf-8?B?RDFNTzh5Y3BFSkxtRzY4SkJUWnNSbTdYRDIvWVgzeDVYOTNQWmZtWUpRV0ZY?= =?utf-8?B?WW1EWW1Nc3ZOelZPakNGTGxQWkpXRUd6K0ZEL1UxZXREOXBBK1ZCTThGaFRX?= =?utf-8?B?akFJRkZzSGIyMndpbDdwSHQ2UlZ2T2FKSDBLeUx0akhMTG51cyswUzBaMHp2?= =?utf-8?B?ckN6NEZ4ZklrQnZXRlFlb1Z3RVhsMUp2TTgzei9hOS9aSzZPSlVYcGxaZm0v?= =?utf-8?B?MUZPTW1kMFoxSjMyd25pUEExVll6M1JYdnRPQUtpdnZrTDZ0MEZZQWhZelp6?= =?utf-8?B?YjVidkFTMVNML2dQckswU2V6VEg1UXA1a3dzK003UTlCRFNWMFpreTFJN1JQ?= =?utf-8?B?S3MvSS9tS1NSZUhrd2FMMVl4ZnRKazRIOWxhTDU2TmZXT0dLTitkVnhlVnk0?= =?utf-8?B?N3FNaXpYREVHclBtL3RYTzQvRWtCdUkxeEEzNEJPbW04T3M1eWdNRERQUGpj?= =?utf-8?B?Y2tiMWVnQUNrMThIdUlyRkVXL1JKT1hQcjFQV1ErL2NZWmQ4ZDJrbFRxZENW?= =?utf-8?B?VXFxTzhhQzlkbHhlWXFETmxpMGZ1TWdMbldSQmErbS9YQUx6Q1YvUFk4TnF5?= =?utf-8?B?T2FNTFJQN0pzTjViY0wxVmtwQU1BcnpyUXpyVEFBaUhCa2RsWGoyaThLOEVs?= =?utf-8?B?dTdHdzR4VnpDWU1paUxnbkc1aXRWbGU0UGM0MGlBdWc4dk56SzRORWp5SWZp?= =?utf-8?B?cjQ1ZW9xQ1NaNHU1cVJGTVl4dExNbEhzSklTV3ptUzVPREpHRVNiVzZPM2c3?= =?utf-8?B?aWdaQ25RbkJzanNrMDl0LzVOYVdoQ2hMMStKVFgxNldFbWs0Rjc4cWRqWHpC?= =?utf-8?B?VHVaR2J5d09xKzhXcGcrTnJLdDEwNjBzOUpDbFBQaloxWUM3TDIzUElwMDVN?= =?utf-8?B?UExva1ZCWTdpVklVMXk4b1UyQ3Njd09WeEdXMHJzdm9QRWRHS3l1M3pueEYx?= =?utf-8?B?WFdnUXZwQXhob0VMV1JrT3dQTGNiTmxYQXg1Sm1qRGVRcFBjTVVHNVZQTnpt?= =?utf-8?B?aGxXd2l3N3NicThEMlQ1VDhUN3Jwa05leGROV1VNeW5oclFUbCtXc2tXQldX?= =?utf-8?B?dWErK05pMVdzbCs4QlI3eStuUFVXRTl5NENHTlVTSmxWWlBseUhJaS9ieTBQ?= =?utf-8?B?cWtoWGZiaVZGLzBoV0lLcGF5UFBwa2pyVzBMektRS0g0c0dhSU5KNjZFME16?= =?utf-8?B?OWV0OXVMRGdBdGdId0NjdXZDZVYwcDJTZmI2VllDR0F4ZHNSUjY4M29BNnBz?= =?utf-8?B?Q0wzU085eklRc1M3KzV0bExPUklqQ2p6TjB2Ti9nYUlPL0x5WE1OeHh2U2JY?= =?utf-8?B?QkwxcTlIMWVxcGJueWZlcTVUU29sSjNwaUhrYTRXWDArOHBqWmlxSTAvdVVk?= =?utf-8?Q?x6ZRNH9NTVxjf8mfG9VCemvrk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcfad578-af38-40e3-81f1-08da689a2aa3 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:47:37.7363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Rw4kKoj6v2H9GlGgEEJsft7vy2/K2CVgoELvmW6nFNG1nR7iPUnN4O8mefv/7FirJK3fOYrkfWdk5yqaXOeFhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2476 On 16.07.2022 16:38, Julien Grall wrote: > On 04/07/2022 13:35, Bertrand Marquis wrote: >>> On 24 Jun 2022, at 10:11, Julien Grall wrote: >>> >>> From: Julien Grall >>> >>> Both destroy_xen_mappings() and modify_xen_mappings() will take in >>> parameter a range [start, end[. Both end should be page aligned. >>> >>> Add extra ASSERT() to ensure start and end are page aligned. Take the >>> opportunity to rename 'v' to 's' to be consistent with the other helper. >>> >>> Signed-off-by: Julien Grall >> >> With the prototype updated in mm.h as suggested by Michal: > > Done. I will send a new version shortly. I notice you had applied and then reverted this, with the revert saying an x86 ack was missing. I don't see any need for an x86 ack here though, so I'm puzzled ... Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:53:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:53:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369391.600782 (Exim 4.92) (envelope-from ) id 1oDMV4-0000i8-Gi; Mon, 18 Jul 2022 08:53:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369391.600782; Mon, 18 Jul 2022 08:53:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMV4-0000i1-DR; Mon, 18 Jul 2022 08:53:10 +0000 Received: by outflank-mailman (input) for mailman id 369391; Mon, 18 Jul 2022 08:53:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMV3-0000hv-CB for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:53:09 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20065.outbound.protection.outlook.com [40.107.2.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0aed69c1-0677-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:53:07 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM6PR04MB4744.eurprd04.prod.outlook.com (2603:10a6:20b:5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 08:53:05 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:53:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0aed69c1-0677-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XLONbPqdlWFHOSxLA7AynVTqXld0PKK/j/EWWsBiFmn7GUVXFYlYL0y8vdjo88fnqoBQDSRDU3IYBqtwEOUbu7/E7w/X6cJ7QDN7ZgBFK11otA7I5MVOJgTGXvi+fZpR/JUK7+i7jLYCgVglrfOQlGAs4OqB3yPJDZ4XDmypiUIR6R11tvwhsVBMuPumeJpV7St3YSJRc7u57/EOkvYxDJ0hgu+LoVxqYWmK3dDSIo6lUkTWsctc2XMuEl3lFbOQE/4rnGdmvuSlBe8AuExC3+91c3Na/gAIg41ouroc9v4pBfjSAxk2Jc4ZudsUNZCij6r3U3MsLeCVoaOXzlfaww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0y4NpEPVsh+0hDEh+toso5RpkSjt5rwTlUb0rw6Z14I=; b=FohFFHDNxV3qnNQ1Zs39R86Yito7KQ6fiebiI1mBEITL125ypzvv2VoI6Rkq6DGtMICVkndMpLTiOMMO5CcSXCe7DQLwp/taJe3Tc+hhveSVa1FRRkLFd07O7Y67Ce4QGouZc8AzScXvNtX+/ub8kUJnHkhNhM9jnSDkjlvOmq+YB6wEoN/QmVBkGmr/VnhXefshl400A41l88nnLE+20yYhnHtdV0HsuM9yAi1Las2JrOlaQMvBQrBasKRQBRSnFi0+bngxZwW6EP6pHCCHKccXJCXK0gjLbyaYfAITuL6wgyXAADsuj+Wkkk/hf8o0ypdqdunyUh5igUhraYMFnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0y4NpEPVsh+0hDEh+toso5RpkSjt5rwTlUb0rw6Z14I=; b=d6f0usFZSIx7L0bgb4lkvvEzthVWD1Xi+9TDu0E1AsIh+yqCoiVjn6Q/MZlNwC8aCKYoXNZEX7CbxCmO+nYWL3gEff3TZ9QlIC9alcgZeGRLJtjjCfRTyytvewDpjqp7FCA9g/lYunIMdeBM3Fw4mTkoC4LJ2gaGnqDOiEzkfnOTb82/dTRUWzwlVr4BD8fTYvrDbMBm3J2H2exTiaXf9LS+d1ejbLIRCJXaKljSttNiGmZp5sVk7qax/LO6l8tht90JVHdABBUHzg3dduKIPQWz2fzmocI/olEZJXB+d01w8bV//ri6gDlUdZ4xrDmrdR3IzbdfQkHBiLt7lr00jw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1ab92b5d-a908-8027-fb64-51e95d08c727@suse.com> Date: Mon, 18 Jul 2022 10:53:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 2/2] xen/gnttab: Store frame GFN in struct page_info on Arm Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , xen-devel@lists.xenproject.org References: <20220716145658.4175730-1-olekstysh@gmail.com> <20220716145658.4175730-2-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220716145658.4175730-2-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d046c35-de49-4168-dff6-08da689aedb5 X-MS-TrafficTypeDiagnostic: AM6PR04MB4744:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 94/kvKrJNBgeJap2hlfSna3gM8WNPwiQxJTsGc2fKpmagtG0KQSogUtFfs47+CNNTWrExF5Wcyp2CvXok3i1bxqIOqklg1X0EmH4tB3h6HR1jbmAWlRjBG/mY7SbIUoF9Fd2SH4ppthsD/LcZ91lXyksYR7vFTLl7cEoj/K03x9PUeKWYJzucllY6BKX8PKAXmIp+0GTORmVRvQsOoUUZda3QYkNO90jJQHY4YVGQde+Dj+CMbUmqj0EiPVeUKFyPjKuDq9TnUpQ6TKiaS5x/BN2UmzaJO14mPxM2UKIkTS51k4LRccsQ2E2hKMmyTyANCq6tvMS0ici/qTJRTo0R2IGZ/w2UnrfRBYy40qAQ88a4mhAgDiiSXJ6OChR1ywEltdSi3KuducpEIKwK5SxTGkmfIIfyvwMC+rLyFFoH58LXXD2D04xYOSnn6DsqeT9ruyYOkMIbaQz/KAGH9r3KnKmIAFQnjqs3YzMFxVIdyuyT1JAtX3z7Y7kPFOBEZOqT023WvLtqhUKvZzReoBRCNuPSsq1rLNs+2diXNGxpfDr4ByVFwtPRFxAtyk4jtVmplQshQfS1gc12oFbgQ6aL+LYTtpHhk+YG3Y9hDlMXIt97Vfe0sF1wzeY2WHnQze+Qi7v8EoDcPB7lum6KXz7oacQ5B2kPcoDn+gYTttP2edqMqRDi2QaFXoSpUGdMGOMbwbarMBF1kwTrPadOpfzAlrd6Mu+6auYQ1J+oSdxUCzQoj3Z6zfZxU/HPz5e+ec3XI6jKansVJDW7+1g9tSKxBDax/AVfOL6mlhY38wUApsmlpVBZi3clm0SZpfLn56S8l2MoKAmBjNGdk6Iz94ffe9yliDXI/Dp/DEImZ1SOAs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(366004)(346002)(396003)(376002)(31696002)(86362001)(41300700001)(53546011)(478600001)(6506007)(6512007)(26005)(36756003)(31686004)(83380400001)(186003)(316002)(54906003)(6916009)(2616005)(6486002)(8676002)(4326008)(2906002)(8936002)(7416002)(5660300002)(66476007)(66556008)(66946007)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUFrbWFNZkpvcW1kZzRsTFBIMjByQUVwS0RNMUVWYjdsUTV2ZFBpM2JicGhi?= =?utf-8?B?cE1zampDTDlnNnhBWFU1WUlqUFVBZG5uVlIvazlwaFdURWc2dmhkaVZ4dStP?= =?utf-8?B?NW81dTdqSGUzZXY0TnJQKzhuR0prdXFKZUt6OEpUTmpwOHMyWmQ1SWR4LzJX?= =?utf-8?B?czA4bVNwT2RKYWZrNGwvRFJVaVhQV1QrNktVdDVPcHJVL0h0WDRmU2RNZzRw?= =?utf-8?B?ZUcyR1FkYUNXck9Cbzh5cXR3aGx2cTVQTXRvME5lanpsNy92ZWhiaGtxRjgr?= =?utf-8?B?NkJXUnNLV1EzcS82V1NJT2x6TmUvb1FMR2xwTFlIM3lOMUVIL2l0K1JmZ0xV?= =?utf-8?B?MGMzV3I0bHpZWW5tMGRIMUVIelBrVGhaZDBmTG5iV2R1Y0pSQlcxdzJqMUlU?= =?utf-8?B?bHJlcDNiY3dvN2Zyd0hMK0k5MFBSNm9EWVNyUmlkKytucGhjbVJ1NjVhdldF?= =?utf-8?B?Z1dGanBoTjJnRjQvVDlGdHRWcm5hbzJwRkdHUzd0dlE1aTJxeTdxekFZcWQ3?= =?utf-8?B?WUllS1NJOHdHajFVK2V4VmVpOFNxUEhCdWk1c3Z6ZkFrVkFOT1BHMHJTYzU5?= =?utf-8?B?c1N3U3UyUnRlRFgwb2wvZnpHQ3oybzJSR0VJWHRETnFITzVRL2dEQTZoUFZH?= =?utf-8?B?eXB3c3p1RnVkYWthVEdzRHlkOTgwVzVxUy95NTlpdVZ3U0k2dVhZN212Nnpi?= =?utf-8?B?TnJ5NnFrMkh3Y3RlVjZEbmRpZW41Lys2NGFrK1UzZlZLUEo3azBQU1Mzdkpy?= =?utf-8?B?cjJzKzg0N2oyWW0zTkpNN1V2RmlWMDBVUXZXRytzQ3BzNzZBbjBtMzlBbFVV?= =?utf-8?B?ZWgzdEFQUGEzTlprUW5MdVpRejhuN1RlRmVRTnd2bUZBYzM1Q2swdGM2NHAw?= =?utf-8?B?V3FuWlcvd1dhWmlJR0dMVVVwN3pWWnRlVVZpSEh4UUw0YUtlRDA0L3lqeW5h?= =?utf-8?B?NEVSUWgyUlRENjVadEpmWFE2UEt3dkhpREFDczNTUkJCRWdPV3h1RGxlZEhW?= =?utf-8?B?QVROVk5jV2kwdHZ6cmhVMWFVNjdhQkZtOXhWdXB1WnFHSEp6cGJFOTZxMHB1?= =?utf-8?B?QmN2N0RIT1ZhQi9jWktoc1lXbVFQelQxTmpJYTVONVBpTnZydXZvdktkZGN1?= =?utf-8?B?ZzYvUHN0NzNRbzB3VnlIdFVtNDVLdEplQjlMS2t5SGFhaFUxWUI0L3Q1ZzU2?= =?utf-8?B?bUR2YVFBSTUzR0kzT1NTMVpES2VPNTN0WmRPWVpCaEpMWEw2RzRHZUYrbnE1?= =?utf-8?B?bVZ2OWRTUWh1cHdBOExsdXpQQ0ZneUlIZ0loYUVnc2FvZEZ6ZTZKTW5SNnBN?= =?utf-8?B?RkJ6QmNmVXU4SEFTVXBjU1JWV243VUo4d2NwUS9PSXB5RGRmbjJJR05CSFJF?= =?utf-8?B?a05QUmxPdTA2R2lKN1NCVVdYb0lPWjJoODRiUEVRZEFBK0xSL2dSRTRuSFAx?= =?utf-8?B?eTRES05adHg2VEtmeEhFZ3VVMUJoTmxJenh6SGVjSE5TSTQxSUk5SkF0SWpj?= =?utf-8?B?S2ZyN2tsUlJuWTIzVGhGNnI3Qk5XelBQU3NMYUVwVG9rbU5PZjdpdXJaV0la?= =?utf-8?B?bHM4K1o4RnFJYWdiQ3FTOENQK29td1JJTkMxMW9FdFR4MGQwU09MNnVQakFJ?= =?utf-8?B?bW9RTkV5U2hPQ3N2bHQrbjZiZTRsWVpkNy9aUDNDWnpvRnhCYWJsUnhUSTVI?= =?utf-8?B?am1qdDNZd1F6a3BhNDM5U3E1SGNXTjVNMGJEVXh1U0hBd05zMU4zdTFBYzZF?= =?utf-8?B?QXo3K1dJNGdld21qMGpmanlqbWxuU2RlT3d0NGQ3VndndmorZ25jeGFEazJu?= =?utf-8?B?SktHNDVlOFZpUk4zOWJqVERkdVJ4elRmckNaUWtKOUJwTUtFTlpDcGJzemgy?= =?utf-8?B?Zkw1UmlBNmtIOGV4SzFYSU4xbENFY2hnekhJSkxiOGFSQVU3VnZzOVBpdm4z?= =?utf-8?B?K21oSW5XRDlIMXZIOHUreVhISExMRXdad0hqN0tHWkN4emdqcC96emJoSjdZ?= =?utf-8?B?QTBhcExvbHErYzVBWmcvdjhTY04xdURnMExyVW5Hd1ZCUVJuZHQvcER4R1BK?= =?utf-8?B?aGhCMVFzZXZjVGZJTnFKbEd5Nk5hemxCbEtTMGNXYTUwV2xWL2p2U3VFZFJ1?= =?utf-8?Q?98w1Y5ulj1YTt/HKnI+fXo5n1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0d046c35-de49-4168-dff6-08da689aedb5 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 08:53:05.0593 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q22gXpkbT17Y3wXaHUkcMQ02OXb+Vh8NgomvomzqZyPlkxx8gIQDfHNj63E6XNKAb8t4qVY8CzV5QJitivs2eA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4744 On 16.07.2022 16:56, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Rework Arm implementation to store grant table frame GFN > in struct page_info directly instead of keeping it in > standalone status/shared arrays. This patch is based on > the assumption that a grant table page is a xenheap page. > > To cover 64-bit/40-bit IPA on Arm64/Arm32 we need the space > to hold 52-bit/28-bit + extra bit value respectively. In order > to not grow the size of struct page_info borrow the required > amount of bits from type_info's count portion which current > context won't suffer (currently only 1 bit is used on Arm). > Please note, to minimize code changes and avoid introducing > an extra #ifdef-s to the header, we keep the same amount of > bits on both subarches, although the count portion on Arm64 > could be wider, so we waste some bits here. > > Introduce corresponding PGT_* constructs and access macro > page_get(set)_xenheap_gfn. Please note, all accesses to > the GFN portion of type_info field should always be protected > by the P2M lock. In case when it is not feasible to satisfy > that requirement (risk of deadlock, lock inversion, etc) > it is important to make sure that all non-protected updates > to this field are atomic. > As several non-protected read accesses still exist within > current code (most calls to page_get_xenheap_gfn() are not > protected by the P2M lock) the subsequent patch will introduce > hardening code for p2m_remove_mapping() to be called with P2M > lock held in order to check any difference between what is > already mapped and what is requested to be ummapped. > > Update existing gnttab macros to deal with GFN value according > to new location. Also update the use of count portion of type_info > field on Arm in share_xen_page_with_guest(). > > While at it, extend this simplified M2P-like approach for any > xenheap pages which are proccessed in xenmem_add_to_physmap_one() > except foreign ones. Update the code to set GFN portion after > establishing new mapping for the xenheap page in said function > and to clean GFN portion when putting a reference on that page > in p2m_put_l3_page(). > > And for everything to work correctly introduce arch-specific > initialization pattern PGT_TYPE_INFO_INITIALIZER to be applied > to type_info field during initialization at alloc_heap_pages() > and acquire_staticmem_pages(). The pattern's purpose on Arm > is to clear the GFN portion before use, on x86 it is just > a stub. > > This patch is intended to fix the potential issue on Arm > which might happen when remapping grant-table frame. > A guest (or the toolstack) will unmap the grant-table frame > using XENMEM_remove_physmap. This is a generic hypercall, > so on x86, we are relying on the fact the M2P entry will > be cleared on removal. For architecture without the M2P, > the GFN would still be present in the grant frame/status > array. So on the next call to map the page, we will end up to > request the P2M to remove whatever mapping was the given GFN. > This could well be another mapping. > > Please note, this patch also changes the behavior how the shared_info > page (which is xenheap RAM page) is mapped in xenmem_add_to_physmap_one(). > Now, we only allow to map the shared_info at once. The subsequent > attempts to map it will result in -EBUSY. Doing that we mandate > the caller to first unmap the page before mapping it again. This is > to prevent Xen creating an unwanted hole in the P2M. For instance, > this could happen if the firmware stole a RAM address for mapping > the shared_info page into but forgot to unmap it afterwards. > > Besides that, this patch simplifies arch code on Arm by > removing arrays and corresponding management code and > as the result gnttab_init_arch/gnttab_destroy_arch helpers > and struct grant_table_arch become useless and can be > dropped globally. > > Suggested-by: Julien Grall > Signed-off-by: Oleksandr Tyshchenko Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 18 08:56:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 08:56:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369397.600793 (Exim 4.92) (envelope-from ) id 1oDMYD-0001OH-2s; Mon, 18 Jul 2022 08:56:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369397.600793; Mon, 18 Jul 2022 08:56:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMYD-0001OA-07; Mon, 18 Jul 2022 08:56:25 +0000 Received: by outflank-mailman (input) for mailman id 369397; Mon, 18 Jul 2022 08:56:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMYB-0001O4-Tz for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 08:56:24 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7dd6c70f-0677-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 10:56:21 +0200 (CEST) Received: from mail-sn1anam02lp2046.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 04:56:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5624.namprd03.prod.outlook.com (2603:10b6:5:2d1::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Mon, 18 Jul 2022 08:56:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 08:56:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7dd6c70f-0677-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658134581; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=mBwG3F2FB9u8m+MzWXH8m4m2+uk9RGt0rE6NNCVZoqU=; b=bdZmfcIoSarK7BOvQF8Zi0QrqxEWDANOAu9xTp3FYDokk6K83sGKIy6d Qwmu7Ht+DJOZ6M6lk8KGlsLfaWBL0bFwenqSbDVpub6YzWPWOMX87lxA0 0C5UmKfmi7cSFMqE+5LIw59aUpGDfZrcGwOJP0w5vOQAZ20DIyvMGDvNo 8=; X-IronPort-RemoteIP: 104.47.57.46 X-IronPort-MID: 76448307 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gG/Jg66kY2j+nwvayCwlUAxRtBbHchMFZxGqfqrLsTDasY5as4F+v mUcWmGPa/6IZ2Kne9t/b4u0/UwHvJ/dyddhSwJvrC43Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimQc3l48sfrZ8ksw5auq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJBsubNU7ufd+Onh10 9M/JxEIdA2ThMvjldpXSsE07igiBO/CGdtF/0pGlHTeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LmIe9Az9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WXbri783beQ9c/9cNogBpC37/xzuXy8xWIOKiRLXmORjfbs3yZSXPoac ST44BEGp68o9VftScLhRRqmu32VlhkGUtFUHqsx7wTl4q7V5RuJQ2sJVDhMbPQ4u8IsAz8nz FmEm5XuHzMHmL+aU3WG7Z+PsCi/fyMSKAcqeSAAXSMB4t/+vJs0iBPfCNpueIawj9v6Hhnqz jyKpTR4jLIW5eYBz42y+VHKhWLqqpWhZgI8+AiRXmuj9Q5/TIqkYZG4r1nd8ftEao2eSzGpr Chas8uT9uYDCdeKjiPlaOUVFZm79uqCKnvXhlsHN4I66z2n9nqnfIZRyDJzPkFkNoADYzCBS EjXtABK7ZlfJky2fLR3aIK8Dcct5aX4HNGjXffRBvJLYpVgcgKv9SRnd0mWmWzg+GAum6wiP ZaQce63EG0XT69gyVKeTOAZ0LltxSE4ykvSQ4z2y1Ks1r/2TG6YT/IJPUWDasg97biYu0PF/ tBHLcyIxh5DFurkbUHqHZU7KFkLKT0gA8n/rcVSLrSHOlA+RD9nDOLNy7Q8fYAjh75SiurD4 nC6XAlf1Ub7gnrEbw6NbxiPdY/SYHq2llpjVQREALpi8yJ7CWpzxM/zr6cKQIQ= IronPort-HdrOrdr: A9a23:y0sgI6BJ57fuIw7lHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76448307" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CdLGIXfL5j0vcTKVDzlibj/CmrO4+IxIzNbAaO3Gdz1S7qmU45W+3a/gy0sGRUeandYubQQL7QMPhJh7e3ASi8pvhxiZfiOtstGJJZuzJFMZOnsNzfjDc4wmSVpV/w2SJYSRuBmMH7N4cVWeaBihZQbJu9BdpNuPK3ngVlCn1sWAV2lNh4yURecGnjjwZgV8ZP6i5iN2fownXVYXgThnVzFyvxMINDeDLz5+0GUqwuUxQiULTbgqT9CnRdvHa2N/CiJAVVcWvaP7QJzLIODnfPtTzscm1EXSaeRYrbstm11aeVFwAs42f3+1MCMcrO4bXVeXkxsWtC3S/cfnqf5sHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mBwG3F2FB9u8m+MzWXH8m4m2+uk9RGt0rE6NNCVZoqU=; b=ERpR2KonXn306P0Neh1MtspCFJxPHacwl4tMY1+VjxZBTUBGbF2LbstJXOxzihau7KDy8lR6AGHitwKEufTN88bdJCYDkOI6+l1RqyoKG0SXlBG/HJ5DJ7LMWbiXNdkhBpcvPVKXfftT9J8GioX1x6PiZrw5LFVN5pwfGHGLQbRgDGE2fbWVTbtAUR/zbzfWlk4HNHCPgaLl2/tBxBz2Di0Z/80VStQarQxuGwvl2POaZ2WPLw26LnA8TZmJVR1hW38xcVB2xl9mi4ECIqdp3zbEAtz+4kvSudcJ8L2yIU+gWBorqtmzYidpHssdORAVTRD6EwUzL7/Tic/qimsUUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mBwG3F2FB9u8m+MzWXH8m4m2+uk9RGt0rE6NNCVZoqU=; b=YEa0fYm5Bqn5DWrcD7FQ0KzXadebjv9k7zeWf6enN8W0KryWkGvtBHORXS1rBqgRZX41RTyfHFSywtU+jTxkaAKXFpNksOMuxMSyTx0LKaiilcxvT431udnpGcq4ro4CzNktX/aITPeHUTxAlUCf/yKq/369Frj561qeS6OiMPw= From: Andrew Cooper To: Boris Ostrovsky , Jane Malalane , LKML CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlToncjhzapb0rEGq8Bkg0N3t9a189b0AgAImuYCAABmhgIAAOBoAgARvxAA= Date: Mon, 18 Jul 2022 08:56:02 +0000 Message-ID: References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> In-Reply-To: <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2183091-8aad-4acb-ae9f-08da689b57b7 x-ms-traffictypediagnostic: DS7PR03MB5624:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GWecnd1aESU04Cz3dwR55Ta8eb8QmxwBSD/qew5hNW5b7WyNgQ0nWz8EkDmkUTH9mZk450fVUJBkoqeqd3QlgA8JDuJrRoPXifYGCzUIAJ01KlYzlzCgsNgRA6XbTHCEZ8+OqFFVyZoAY50x82S7i+05n+3OQErULw2VtVOctCIt51EIZK85U9hWrwRqIWLCMb6Q2rsiWjvUwh0ZQB00cauGenvNeirFglNXoyP8fyqhS0dn0Fz4bIQfyPAVaKjNguCB+CnaORvBQm61LTLpmH5vNbnrSwl2VZas2VgdoUfbt9PwAvzO46JphOTEQ5Sf9LRHwNCGbHpCKt8MINNVxtdoMc9whRa/P2Xf+exkoyXjCBlB1RThvq3uTmslBo7AEUeCyEnPeILXibsAl8OTKBq0XMf6hUBOaY7RSQNrheRuE/4R9gr6V9izICnqPLdj9T3K+ZQoyAyJx0tsqvfiOkGDMrAmP/aQ9GiG6Jy73mOK92zRwQIY1yCYTWN9GuY/H6UfhGgXGBdEl94SaWk2xx/xtbi3NPU3Kbk7yz3JqKlS3pJpILz5a2FjNVhA4uDuexgROLffERfyg0Yn7W+CilnZyXzZGjPRgdTHQgqOgOKoe/wM2i/aL0XAFCjcjnwaHxcZU4ByJlDi+dXSrqkMYYKcRR7sA80uKv8x5dFWHv1+ZHN31wttFUkcs7qpJ2eOp2/Z4RHS8FlPThJ/Z0wJC2tht65AuadOONM4TbXQ2ZxdNENCT0nTh+fxyHzkTbqD3yjtgBcH+f/cqXoYKENFDrBIw71bsPwtstDK3O/R+QQYGGzLQgWuJuGJdgMukeC6d6dx7hV4Cn4ttHVwVOqfB120d5IRXX1Kjkf1CySj0D2+v1oLTJ1dkHGt3r7UmFRT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(71200400001)(76116006)(2616005)(91956017)(64756008)(66446008)(2906002)(4326008)(8676002)(66556008)(66476007)(41300700001)(66946007)(478600001)(5660300002)(7416002)(31696002)(53546011)(6486002)(6506007)(26005)(6512007)(54906003)(86362001)(8936002)(31686004)(316002)(36756003)(122000001)(82960400001)(38100700002)(110136005)(83380400001)(186003)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Ry9mZFhqWGEzQk9jTXhOVnNWNDFsbnQ1aUFmOUNianB3MjYrSU5hd1dzZXBR?= =?utf-8?B?ZHgrbHRnQWdFc0VqNkJ6Q1BKY1NJQmYwc3pPSHhZbWFwTXpzQzFBa3hYcWV3?= =?utf-8?B?dk0zZ0pCSXVMclZkaHVXWlJSWTRpUXkrVGJ6cmNQY1NabGtaNXRoalZ2bXgx?= =?utf-8?B?N1gxMnc1VitXWUJMbUhhYzQxQjhHWi9mS3FuT3FsUGhuYUVFZDF2cWhhUjJn?= =?utf-8?B?TU5SNDZBc2Y5MkZlVVFzNFBHb25NWGVoczBtMEpTSXdDajNiLzFsWU9aV1Ns?= =?utf-8?B?N2hGNzNUUVp3ZDhBME11RTExVHl0VVdlZ25UQWhsWGZiUUNGMkFpb1ZiaGRt?= =?utf-8?B?OHJyV3ZiVmgrZDNWbHBCWGgvMlJseVYvZlhaOFZURXEyS2diS2xOR1NPamZZ?= =?utf-8?B?WWNxdTh2cEVid3VjOTcvY3g3RVA0dko2UHlyb2RHNitUbkZVM3VWWUVXUWpZ?= =?utf-8?B?REtiQmFSbVZIeWh6ai9ZMzFrcGRxOGFZWkg5US81OHJUdUJwa1BzMWhyU21y?= =?utf-8?B?QXIrYmtDSEplOUIzY1ZMZU5NMXFFN0I4RDZLNm1zSkhGeTgrS1RFSjRqYy9y?= =?utf-8?B?WGh2dFhyWllSTWhuTlJ2MjZ0TjBkMDJHMWxXVjhOeWgwZytpNHM5QjlweDV2?= =?utf-8?B?WnZaU0RSOHB2OUtMY08ya1NDRkh0TkhobVdhMzh4bmJQTHpVeHdLc28xWUR4?= =?utf-8?B?aE05MHV6d1Z5TjVHNHJGSmRFYjh2UDc3UER1Ykw2RFZOVm1yMkZsc2IxazA5?= =?utf-8?B?YzhJNDNiR0crdElka0NHZEtNZWpHOVVRVi9QYWoycmhjQWRJM0ttMmM4bitk?= =?utf-8?B?U25jZ2tyQXEvOWFsaFhwTTEzNGhicC9yRFlhdGl6WVI4Yld6bXIwU3U0Wmx0?= =?utf-8?B?OEFYU01JWVlSVGtaQ2p5MUY4Mmc4MFB4YTZFc1FVQnAzNkFTcWY0U0c1STB2?= =?utf-8?B?TnhsNzdlc0JEY0gzUTRFR0wvQ29vNjNQeDNIVlA2QzB1b1MrYk90dXZSTXBx?= =?utf-8?B?bmErVDNsWThKVmhHOVh2ZnZvcC9XaG5IeEZEeWZYMFpWckFHdndJdEFUNlRR?= =?utf-8?B?Uk53ZGw3cHZkZDgxV1RNNUN0d3I3eUpIQm9pSlcxNldqZUUzdHdKWUlJMFU1?= =?utf-8?B?SmhOMTVOZkEvTmh5ZVMzdGVROUpKQ1RBYmNRelkvK1Y2dkhubkJTMzRNUTRh?= =?utf-8?B?b1g2QjUvSGg4VmQyRysxTDlGRDI3TWdIeGJPbmp6ekM5ZTVJK1lCODAzaGc3?= =?utf-8?B?eFc5VWVOZ205S1NoYWhOcjRZVFRHclNaMjkwREJ5MnZDY0psMWNXMHBEK24w?= =?utf-8?B?d3RaeGJVeGllZTNRblNJVCtMbS9HWDJlZ0NkUGlaMkYwbW1tSUlGK0dkNGUz?= =?utf-8?B?dytrWmVNRlJtUXp5TFNIT0NFblMwRlhTZzdvRzNmdmwrNGtBSi9jWUtsVjVP?= =?utf-8?B?cmI1VitGa2gzYjZacWg5K3FZQ2IyTDNBd2pPaVlRNFVQWE01ZFZpeEJyVWp4?= =?utf-8?B?T1F4QWlxY1l2alpINVh1TytMd3p2eW83WTAwa0tQVUhGVzA3eWc5am5ZNy9n?= =?utf-8?B?cnBOWll5MEtIOHZmL1lTbURWWEU2dXdYVEc5V0NISnU4YlZMTHBMWExaK3lW?= =?utf-8?B?aUZ3dUxYSUdodHp5RjhrVS8xcjhQZXBYaFNta2dQYWRyN3ZvcVpaRks1VkhD?= =?utf-8?B?ZTd4bnJUMDZNVE5qOEZQRUthMXExZ0xzdlUwZnEydHVqaFQ3NzdZMW1mclZo?= =?utf-8?B?dERBMHIzT0NhNmZ0ZGxZR3ZCRlZmaFBGbzRlMWpFZHM2V0hpclNqZVMvcHVp?= =?utf-8?B?ZldMcmJwUTlrd2tLZUFVQ1pvQ1hCdkFJbzJncjlvK01wbTQvc21UL3A0cnRN?= =?utf-8?B?eXBJUFk3YlB4RTJ0Vy9qQXZRYkY5ZkJhUU5oMURwN1NxbHpxRDl5WVU3RWhy?= =?utf-8?B?aEpnRXZ6ekZOeFEvV1U2TXVBVFlBczhXd2l4SHlwNWw4SFlnUWtzUkx0RE9i?= =?utf-8?B?VFpTVjZHSU9VOXBRUjdOZ1RBbHRUNkJCcEhWMzIxL1RxejNyN0xGUTNZOXRY?= =?utf-8?B?MFBHTUJKTzF5dmVwOGwyOG12akNadVp1V0dXbXptTkpURlJhVTRDTHphbWpP?= =?utf-8?Q?yDqFfm3LEzc9CdDOCHUVBkHSu?= Content-Type: text/plain; charset="utf-8" Content-ID: <459C3E8FBDC64644A0C3D4D327CB90BF@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2183091-8aad-4acb-ae9f-08da689b57b7 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 08:56:02.6909 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B/5ljpc4lUGy/HaLI5h/5UOLG2cdvsLoe9xPaaVyPZ3YRtZgDi/784mTF5u2VM0ySX22wjh64y9wenA1A/fgb80S2ooggi/LBja7R3c4A/A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5624 T24gMTUvMDcvMjAyMiAxNDoxMCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPg0KPiBPbiA3LzE1 LzIyIDU6NTAgQU0sIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNS8wNy8yMDIyIDA5OjE4 LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4+IE9uIDE0LzA3LzIwMjIgMDA6MjcsIEJvcmlzIE9z dHJvdnNreSB3cm90ZToNCj4+Pj4+IMKgwqDCoMKgwqDCoCB4ZW5faHZtX3NtcF9pbml0KCk7DQo+ Pj4+PiDCoMKgwqDCoMKgwqAgV0FSTl9PTih4ZW5fY3B1aHBfc2V0dXAoeGVuX2NwdV91cF9wcmVw YXJlX2h2bSwNCj4+Pj4+IHhlbl9jcHVfZGVhZF9odm0pKTsNCj4+Pj4+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+ Pj4+PiBpbmRleCA5ZDU0OGIwYzc3MmYuLmJlNjZlMDI3ZWYyOCAxMDA2NDQNCj4+Pj4+IC0tLSBh L2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+Pj4+PiArKysgYi9hcmNoL3g4Ni94ZW4vc3Vz cGVuZF9odm0uYw0KPj4+Pj4gQEAgLTUsNiArNSw3IEBADQo+Pj4+PiDCoMKgICNpbmNsdWRlIDx4 ZW4vaHZtLmg+DQo+Pj4+PiDCoMKgICNpbmNsdWRlIDx4ZW4vZmVhdHVyZXMuaD4NCj4+Pj4+IMKg wqAgI2luY2x1ZGUgPHhlbi9pbnRlcmZhY2UvZmVhdHVyZXMuaD4NCj4+Pj4+ICsjaW5jbHVkZSA8 eGVuL2V2ZW50cy5oPg0KPj4+Pj4gwqDCoCAjaW5jbHVkZSAieGVuLW9wcy5oIg0KPj4+Pj4gQEAg LTE0LDYgKzE1LDIzIEBAIHZvaWQgeGVuX2h2bV9wb3N0X3N1c3BlbmQoaW50IHN1c3BlbmRfY2Fu Y2VsbGVkKQ0KPj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKgwqAgeGVuX2h2bV9pbml0X3NoYXJlZF9p bmZvKCk7DQo+Pj4+PiDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5fdmNwdV9yZXN0b3JlKCk7DQo+ Pj4+PiDCoMKgwqDCoMKgwqAgfQ0KPj4+Pj4gLcKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVj dG9yKCk7DQo+Pj4+PiArwqDCoMKgIGlmICh4ZW5fYWNrX3VwY2FsbCkgew0KPj4+Pj4gK8KgwqDC oMKgwqDCoMKgIHVuc2lnbmVkIGludCBjcHU7DQo+Pj4+PiArDQo+Pj4+PiArwqDCoMKgwqDCoMKg wqAgZm9yX2VhY2hfb25saW5lX2NwdShjcHUpIHsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHhlbl9odm1fZXZ0Y2huX3VwY2FsbF92ZWN0b3JfdCBvcCA9IHsNCj4+Pj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudmVjdG9yID0gSFlQRVJWSVNPUl9DQUxM QkFDS19WRUNUT1IsDQo+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqAgLnZjcHUgPSBwZXJfY3B1KHhlbl92Y3B1X2lkLCBjcHUpLA0KPj4+Pj4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqAgfTsNCj4+Pj4+ICsNCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEJV R19PTihIWVBFUlZJU09SX2h2bV9vcChIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IsDQo+ Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgICZv cCkpOw0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgLyogVHJpY2sgdG9vbHN0YWNrIHRv IHRoaW5rIHdlIGFyZSBlbmxpZ2h0ZW5lZC4gKi8NCj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIGlmICghY3B1KQ0KPj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdf T04oeGVuX3NldF9jYWxsYmFja192aWEoMSkpOw0KPj4+PiBXaGF0IGFyZSB5b3UgdHJ5aW5nIHRv IG1ha2UgdGhlIHRvb2xzdGFjayBhd2FyZSBvZj8gVGhhdCB3ZSBoYXZlICphKg0KPj4+PiBjYWxs YmFjayAoZWl0aGVyIGdsb2JhbCBvciBwZXJjcHUpPw0KPj4+IFllcywgc3BlY2lmaWNhbGx5IGZv ciB0aGUgY2hlY2sgaW4gbGlieGxfX2RvbWFpbl9wdmNvbnRyb2xfYXZhaWxhYmxlLg0KPj4gQW5k IG90aGVycy4NCj4+DQo+PiBUaGlzIGlzIGFsbCBhIGdpYW50IGJvZGdlLCBidXQgYmFzaWNhbGx5 IGEgbG90IG9mIHRvb2xpbmcgdXNlcyB0aGUNCj4+IG5vbi16ZXJvLW5lc3Mgb2YgdGhlIENBTExC QUNLX1ZJQSBwYXJhbSB0byBkZXRlcm1pbmUgd2hldGhlciB0aGUgVk0gaGFzDQo+PiBYZW4tYXdh cmUgZHJpdmVycyBsb2FkZWQgb3Igbm90Lg0KPj4NCj4+IFRoZSB2YWx1ZSAxIGlzIGEgQ0FMTEJB Q0tfVklBIHZhbHVlIHdoaWNoIGVuY29kZXMgR1NJIDEsIGFuZCB0aGUgb25seQ0KPj4gcmVhc29u IHRoaXMgZG9lc24ndCBleHBsb2RlIGV2ZXJ5d2hlcmUgaXMgYmVjYXVzZSB0aGUNCj4+IGV2dGNo bl91cGNhbGxfdmVjdG9yIHJlZ2lzdHJhdGlvbiB0YWtlcyBwcmlvcml0eSBvdmVyIEdTSSBkZWxp dmVyeS4NCj4+DQo+PiBUaGlzIGlzIGRlY2FkZXMgb2YgdGVjaCBkZWJ0IHBpbGVkIG9uIHRvcCBv ZiB0ZWNoIGRlYnQuDQo+DQo+DQo+IEZlZWxzIGxpa2UgaXQgKHNldHRpbmcgdGhlIGNhbGxiYWNr IHBhcmFtZXRlcikgaXMgc29tZXRoaW5nIHRoYXQgdGhlDQo+IGh5cGVydmlzb3Igc2hvdWxkIGRv IC0tLSBubyBuZWVkIHRvIGV4cG9zZSBndWVzdHMgdG8gdGhpcy4NCg0KU2Vuc2libGUgb3Igbm90 LCBpdCBpcyB0aGUgQUJJLg0KDQpMaW51eCBzdGlsbCBuZWVkcyB0byB3b3JrIChuaWNlbHkpIHdp dGggb2xkZXIgWGVuJ3MgaW4gdGhlIHdvcmxkLCBhbmQgd2UNCmNhbid0IGp1c3QgcmV0cm9maXQg YSBjaGFuZ2UgaW4gdGhlIGh5cGVydmlzb3Igd2hpY2ggc2F5cyAiYnR3LCB0aGlzIEFCSQ0Kd2Un dmUganVzdCBjaGFuZ2VkIG5vdyBoYXMgYSBzaWRlIGVmZmVjdCBvZiBtb2RpZnlpbmcgYSBmaWVs ZCB0aGF0IHlvdQ0KYWxzbyBsb2dpY2FsbHkgb3duIi4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:02:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:02:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369405.600804 (Exim 4.92) (envelope-from ) id 1oDMdb-0002zk-PA; Mon, 18 Jul 2022 09:01:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369405.600804; Mon, 18 Jul 2022 09:01:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMdb-0002zd-Ll; Mon, 18 Jul 2022 09:01:59 +0000 Received: by outflank-mailman (input) for mailman id 369405; Mon, 18 Jul 2022 09:01:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMdb-0002zX-1m for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:01:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4656c773-0678-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 11:01:57 +0200 (CEST) Received: from mail-bn8nam04lp2040.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 05:01:44 -0400 Received: from DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) by BN8PR03MB5075.namprd03.prod.outlook.com (2603:10b6:408:df::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 09:01:42 +0000 Received: from DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534]) by DS7PR03MB5608.namprd03.prod.outlook.com ([fe80::40af:d5f4:95eb:d534%7]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:01:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4656c773-0678-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658134917; h=date:from:to:cc:subject:message-id:mime-version; bh=VclLy3bulJ8Vpgv0hfnTQNnt18s/6nZGfYK2sRPooJQ=; b=cSruDnFXX9CqQq2j2nnMWroEWTzFjtn5lvmo6IXqIqe5Mp2KFcO1cXwd CYf+lYusj8buQcOlQ4AwFSqX9fR9wqfEvrQx/Jh3JcR6C6RfPuvZ2tJV2 FdIrVvalowlTNfYJLGaqHt+2FSd8+bnTCCMBVBXqle3PME+KH/a8a4sFe E=; X-IronPort-RemoteIP: 104.47.74.40 X-IronPort-MID: 75315889 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:EROQ0q2F8T2bLK3/GfbD5eFwkn2cJEfYwER7XKvMYLTBsI5bp2cOy mtMDGHUb63cYzGmctt1Ot/jo0wDucODmNIxSlRqpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8Uw35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6/R0N1w9H9YSw/l+LXtj1 eEZKA0fbynW0opawJrjIgVtruIKCZG3eak56jRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2SW5L2UwRFG9/MLb50DJywN8yv71Ocf9cd2WX8RF2E2fo woq+kymX0pDaYzPmFJp9FqApe/rhTihab43V7Tj1sxoiwzI31ccXUh+uVyT5KPRZlSFc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUS4hyN0K3LywCXDGMNSnhGctNOnM05Xzsxz XeSgsjkQzdotdW9S2+Z97qShSO/P24SN2BqTTAAZRsI5Z/kuo5bs/7UZtNqEarwhNulHzj1m 2yOtHJm2+1VitMX3aKm+1yBmyirupXCUg8y4EPQQ36h6QR6IoWiYuRE9GTm0BqJF67BJnHpg ZTOs5L2ADwmZX1VqBGwfQ== IronPort-HdrOrdr: A9a23:KxSVkaONZHGrpMBcTyj155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jztSWatN/eYgBEpTmlAtj4fZq8z+8S3WB1B9uftWbd2FdAQLsSjrcKoAeQYREWlNQtsp uIGpIWYLOQMbETt7eA3ODSKadF/DDoytHLuQ+IpE0dNT2CJpsQmjtRO0K+KAlbVQNGDZ02GN 614ddGnSOpfTAyYt6gDncIcuDfr5mT/aiWFiIuNloC0k2jnDmo4Ln1H1yx2QofaSpGxfMH/X LemwL0y62/u7WQywPa1UXU85NK8eGRvudrNYipsIw4Oz/sggGnaMBIXKCDhik8pKWV5FMjgL D30mcdFvU2z0mUUnC+oBPr1QWl+i0p8WXexViRhmamidDlRRohYvAxzr5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqrEypunAv+NRjx0C3abFuJYO5kLZvsH+8SPw7bW3HAcEcYa BT5fjnlbxrmQjwVQGWgoFtqObcL0jbUC32A3TqgfblrwS+rEoJsnfw+/Zv4Uvo1KhNOKWstN 60QJhApfVpcvI8S55bKaMoffaXY1a9Py4kdljiV2jaKA== X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="75315889" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UwY7egmsc/XfWTeN8Gt8SvaHn6PEGsOee3lLUxQs551/p/DnUFUYRfTV2RBP+N6vPlL6o6LCCpGPUkSqBZUj8XK3JjNKZB2sOnkp5r1/BAbl/r3owTiJRFnKt2Kni2DSL7fmTWXoXhCe85LoWzvJF6pR+AfIkNSLUUNRJUEeA4b7/nTarxJ2nYCNKPTsDQfBOo2SV2Md/UTUXZj09rYIIuJRQ3PYzez3+115WED/gnyModdKNHhJmgjQNHWLvg46QP1pKeBBN/rIdcnxgQDzKferQx8s4dmtQzzVAxkLmIK9eUfXrYAfi8jbGDHYIrtZVzCzcXrC1WHmkxEtcwjvWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VclLy3bulJ8Vpgv0hfnTQNnt18s/6nZGfYK2sRPooJQ=; b=F+eRdnK+60uF1vKedjp7zV3HX1z+HyF05RmVsyFpMMn9fskGpPfm+CH9FVUJ8sNXhi8jT35vq+9UVXepHf3DXpn1qbGXiIp75zmFFBG8ofgKO94Yxr8RfZ6wQV0HAzMH+zx9d/5LknGXzafxClOSvdkpNzhWXfW9/OKpl6YiAY6ZhSs5TGRQ5ZQCzs1Bkj481oG1UsQhepoZb1sOE7y0/WSmZOdhP3+OuqBs0hETtnmHyubisOY5ALtqWzd3hD+WAY6Gkbj8ew3mnULOzcKfl16TlDwwKn5xbY2wIVOCotEJCrO3FsPgnA1EYyYAkIuYIvInDl+PPgP7dccSydY3og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VclLy3bulJ8Vpgv0hfnTQNnt18s/6nZGfYK2sRPooJQ=; b=fZR/gVmol63MUcgvwswnTF52/jN2BWBUTZkl4kCIUQIgwTXWWaTuqgKkWQo8R2lLVI7JZRUUyK97hggldpaP5Qn5WQ0+FPOjbZS9SJoS0/rpS8v300tJ5RYmmtAr7VLAWjstaJw/0kWiSi6i4z25Jz/SEnTL8qdABDJgL1hl/gQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; Date: Mon, 18 Jul 2022 11:01:38 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: xen-devel@lists.xenproject.org Cc: buhrow@nfbcal.org, Juergen Gross , Julien Grall , Wei Liu Subject: xenstored socket backlog length Message-ID: Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-ClientProxiedBy: MR2P264CA0044.FRAP264.PROD.OUTLOOK.COM (2603:10a6:500::32) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f481196-5266-46b7-e550-08da689c2266 X-MS-TrafficTypeDiagnostic: BN8PR03MB5075:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SGU2Df9Uozn4XIFHV4V6Hths0zauM5vZKM/4ss8eoLk2ao+HvDkuibAJmzFNS3BgiMCA+HaREMOKFFNiIA+9wkjwAjopPyIdbONAX8rP5ZDoVNYraTwgeuHQSTRDicNEUOnMTmZN/pWtHoRj9UqU/+TdCZx7A1+p/IuGpop1nOLvD+WR90MVxvJ1XxU7mNmE0QHp2YmsQW8jVr2KF6eWG/X2QvMOYT/aq4Y+8ntw0RXX2D/sVHvLxb1aCKl+ISPdSQSKEK7zx3v2rOF/lua5zjJ1Uua47DZaTEf7yWUueYaEmlOnLXTVeO9lbDhfCva8kieRwQjMc7JyDvgNuWpBUXzKJLNoO97MT0sLmxFH4xOcg6bYT2diGqeKW06unZufXAjFRXR1SHywwXtYMXUy6PJIBd+daIL0FNJ4us8XZY19UK7F2mhXyqYvK63IDapQYuWn43irHDNbgWpvO7b78K7nXk6Wyvruvyka9BAEgWvyWkDXx1mpDxhfsI/udDUAAc2aIeb7nFL/aMeE+PNzb4AkW79BicdEW1Wzu247Q7pjh/R/C/pdqqYvGdm8B/LjBPmTeFeReriYKe++t34kxwDJhxUUJ6UjFTEq2eoXjm0wLl1SztoE5Lwc/ptJYiU/YFYLxVJr+MFp5CnLN3YUjwNlb9C6bzA2NEo0b1bUJrGBc9/pIansDHZOOiVZ/US/b1bGX7z8BA24NM++EbEwScROaziTHrk6Rpy9xa+9Zn6p+sVJwVilkolNrQ3eK78lRV0isit00o1bl67yYhOxLAy8W02P2dyUch1pjRhou0QatduLdQpHkzz4zFA5/hvOlCHk6No0NTouIjLwjXcBwVfnlPplS1TOeQEuunGMoVY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(7916004)(396003)(376002)(136003)(366004)(39850400004)(346002)(9686003)(86362001)(6512007)(5660300002)(6486002)(8936002)(6506007)(41300700001)(2906002)(26005)(38100700002)(6666004)(478600001)(82960400001)(4744005)(186003)(33716001)(3480700007)(966005)(66556008)(316002)(66946007)(85182001)(8676002)(54906003)(6916009)(66476007)(4326008)(533714002)(158833001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzR1Q2loSityUkRXWWhwa1llM1REVy9ZYVpqTkxieGxRemh6TWgzbkw5a0pJ?= =?utf-8?B?MU1UR2ZRMno1b01yWEFGM1hERm1ncm9yeFBZVFFuSEVBZVRweVpCREVjY2Zm?= =?utf-8?B?amVZSHFoRU5HeThHdTVnajhzZmlXYlIwMnhVS01jTnlqRC9LaWR5dHRqaktQ?= =?utf-8?B?RkJTSFVqS0cxako3Z3YwWks0bko0dFlCV1VkRjNtZHlLVHpSRVA1cVhOcHY1?= =?utf-8?B?ZURISmVPejFGQVVkUmxSbHplSjZtN1J1aTYzWXh1VTB2R3FOSU4zZC9NM2hl?= =?utf-8?B?cDRxdFR2ZFZLUDlHbnRsVFFPdFlUUUFod0FQNzNIWHZtd3hvYXREK0hLY0Iy?= =?utf-8?B?dWgrM3FMZnNXNDBFRTVFOXIzMkdOY215QStnRE1tV0pJTzlFVEk2c0ZORnRS?= =?utf-8?B?VXJJS3JxL1QrN1ZiQkxUbzBqRC9QVENNblJJWVEyUGFQY1NWSHpkY2FERWhU?= =?utf-8?B?MU5meG9aZ0Rab25jbm5BYXFWcmtvR0pmWk1Sa0E5dnduK2o5ZTZMVXdieS9D?= =?utf-8?B?Q2dHNEZJWU5GeWEvWHdPcWI1SkpTK1Jmd3FSRVd3L0djbzd1Sng2bVNwMkg5?= =?utf-8?B?UjlmMERMeG1aQitUQzE4TkhBNmswY2liOVJNYWk1OVkxZG1aQlg4dncrek5X?= =?utf-8?B?Q1czYUp1ODh4aFV3QUN5dStaSmpCVUl2QXdrVVY2RHBmck53ZjBzVG0zT3Z5?= =?utf-8?B?cWczVVZrT1VVaVYrbmZwbjRtVi9Ia2xTeEo2S1JEbXErUURpSUtTZVRzVVE2?= =?utf-8?B?ZG4yU1A0Q01XaTJvZlVTeThFZ0JsZGEyc3UrTkJuVjEvay9XVXhUQTJOUmFp?= =?utf-8?B?Wk5vUVRzRnlaZUNGdFl0bGc3VVIxU2E2RVZjZ3poZHRHa2hSb05nQXFjREti?= =?utf-8?B?eDUyaHhkUktvMVZPWFhVLzBvLzdsTGoyMXdSaTVBMkJvRk0vOTBOVXNYWDZM?= =?utf-8?B?Z3luZzNFVnVrejhsZC9Da0dhWE5SSzh1TkR0SEhCTDJjZUtxbzFWVTUwOHJt?= =?utf-8?B?MWkzMDdGNkxjM3BHTUlHeUg0SnExaFlmcURvRDl2dEJjQmVrS1NZOUV5WVND?= =?utf-8?B?MFNMczJBU29FSFFEYXpXaHB5ZG5DMk52eEJpOVRUUkJpL2tXRTNrREpUaGR0?= =?utf-8?B?R2QzU2V6Tkh4NklMMFgyQ0t5RWI2K2dUV2p1NUZpMzdjUXVNODQvVHZUdmsz?= =?utf-8?B?WURzSUYrWXN1VDlTUlRaL3EwQXN4czM4R3VCSk11RUx3MDd1eHNBWVRyajls?= =?utf-8?B?WE9SWWRCQTFCNktzZGJqRnJJeis4U1dBS2x4Sks3QndvTnF6SG5wZW5EL3U2?= =?utf-8?B?eFhuUUp3eWlYd25VV29neG9LVXZ6amtFcHRnQ1ZhcHVXbi9CMWUxZEFYeFJr?= =?utf-8?B?OW1oWlg4MEliOHB2aUZHQTIwNDUwUXpSZTJGNloxUFQ4K3U1TFo3U1Z2Q1BB?= =?utf-8?B?RWdodjM1MC8xQ3k2b3orVldFRndFZklwL3VqYmM2R2VhZ2tVQUpkMWtkbVBn?= =?utf-8?B?MFZ0SVpwdXFhNGpNNDA3UTEvUGVsMUF0bzVwaUkrWnR4SVdOOFVZQmF4dDBw?= =?utf-8?B?MWgxM0dJSDVxMS82MC9URGZBNmo3bEE2UXcrWTZoUXpIZndoL2lwd0FsemRQ?= =?utf-8?B?UHRtVWNja3NsK29sNE93aDRXblg3OTlCSjNhS2srcVpZektWSnFSVFp6SmpE?= =?utf-8?B?UWs3VkYwK1FWNWp1M1VaYXlDZWViaUVxcWQ2dXpramFJNmV4dkFGUlkvSDEw?= =?utf-8?B?bFFrck0yUjNkZjZPMzZtaUNlSWh5RUdVdnVNZU5GMHl5dlBJQnJQL1V4dzNl?= =?utf-8?B?ZWZVb0o1NDRYZGo2NGsxVkZCTlp6b0NGbG52NUhUQncrRVpSZG5rbU1JYWha?= =?utf-8?B?c1ZET25tZ2s0VmhWVm9nU25HN0Z0RkM2d0dTdnYzenRjb09WdXg3YVNHaUky?= =?utf-8?B?NmRhWFo0cGVrTXBKd051cHFiL0REem1MWG5BK040MTFnVWZNdnN2ckxtMjNU?= =?utf-8?B?VzErbnJ4anpWUytzSnNkOFFRd0hpVkJuY0JqR0NZdUxrZTRrR21kUlgvVkZs?= =?utf-8?B?ZEh6REE1dzROd0I4Z3VGK1JHOW5wNGxhZjdxQml0N3JPeGZKc2REMTVheUVF?= =?utf-8?Q?mgzRiHcsnaWuO8r+zbvcKh2ux?= X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5f481196-5266-46b7-e550-08da689c2266 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:01:42.8795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lUYZzq5ZnOsJfCLvvB0rVms5HO9bp4yq/RQeWMOA5h9iqnK6q05PQlSnpL7uLp46+15JGtQVqGIy+0o/ZR1v2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB5075 Hello, It has been raised on the freebsd-xen mailing list [0] that the socket queue length for the xenstored local domain socket is set to 1, which can cause concurrent executions of xl commands to fail. I see in xenstored implementation (xenstored_core.c init_sockets()) that the call to listen() is made setting a backlog length to 1, and hence would like to ask if there's a reasoning for this, as I would think having a slightly longer pending connections queue shouldn't be an issue. Was this value chosen based on a toolstack that has a central daemon with a single connection to xenstored? Thanks, Roger. [0] https://lists.freebsd.org/archives/freebsd-xen/2022-July/000116.html From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:11:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:11:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369412.600814 (Exim 4.92) (envelope-from ) id 1oDMn2-0004e7-MM; Mon, 18 Jul 2022 09:11:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369412.600814; Mon, 18 Jul 2022 09:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMn2-0004e0-Ja; Mon, 18 Jul 2022 09:11:44 +0000 Received: by outflank-mailman (input) for mailman id 369412; Mon, 18 Jul 2022 09:11:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMn1-0004du-8v for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:11:43 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a3112b39-0679-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 11:11:41 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU2PR04MB8950.eurprd04.prod.outlook.com (2603:10a6:10:2e1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 09:11:40 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3112b39-0679-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKeZSm6Igia5t4k/foPy3hLJOLKqsL8sVyvJXX2HtxIphSNd0z951snGyRazldQV2YN0YEUUvvzPcYngBp3/29PzGbVVk/anQ+bDakqauCKh0k6q+jJZ5jq1ciFh3hvzVXL+RGVVjBd4bhuQJuBi/4x6wVKxJDbUy0EtSpop7JIHSer+dy2LnVHVBnj8wb49sI82a1jkcsTT6s034mtK83hWiQoQdICoZZVnFSgq0z+0LQaBsAJKPC1LNY5iJu+Owv3wW2ugMROlUyufHzlpGUTsbuMuwx2Et8kxbHLcFT2oSODblswRBAvDVcZbmzR7tePjb88V8qDa6UgOG1JK8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JEEVgnAVgf0unhwcndHTceHBQIXvox7S5PPgOOD0iHs=; b=MRQxS+cPeHkx3bz+725HEzmHaSBVxYSEcT4H0GuMzxGmGkzjZU/8kTczlq67F7AA3ef/sLA7GfPTw3wS8OYfMAl/QOT2btCgpsMLs1pJP+y9N2EJIN9uTvweq+bQrxiFzWaTV/rVHCPsN0zxrQS7B6wzZd81JxDQ7dqbAfrvJ7A0kPh/CC/L1jY/ht1q/4E+B/EGvvSw693spMKfhEIW5Me74HJ5vHDjy1YpF/z1TMPVB5yDFgosxhyEWYTTVu5DNVWykaPpUhX9Lf0fWPL80COrSDwXNunK3mPjbgAZrpoE1k/azINjrJdiPoljgcGe6FPjoxNghFSWgB5puSLRGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JEEVgnAVgf0unhwcndHTceHBQIXvox7S5PPgOOD0iHs=; b=zjZO4t7x3Tqe9pwQJaSUkoErXoXvhCe1w1PROORgqaDqlSmTYIWwfITNvaZYdaZAVvpBXMaqYKDkONN6W8Uogpjt9ViGpwGTVe6Oo7U7m0yFeHRryBErSLmRLsc34Hbr/BUc2SJPdwIHgaLTgWKyBWZEXxOn60PCsZPbOpzlH3v0YKsV1KLHpyM0VXihWP0KzFF0czO5WufbZDmi/bS4eGPkL/IXp++v8fcWPUnzCIIyfcCahHXGa7jdCU+puc3DdLRdRQh5ySnpBLT1JURNfL7pYxaQvAbBtugxO0/x+KeknKEUYRrKOhOVRMGTq4Yv2Hl8gCixnrCMotreGVjkHA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 11:11:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony PERARD , Luca Fancellu , Mathieu Tarral , Bertrand Marquis , Xen-devel References: <20220715132651.1093-1-andrew.cooper3@citrix.com> <20220715132651.1093-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220715132651.1093-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0135.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 26b15c35-f5ac-4c17-1f39-08da689d864a X-MS-TrafficTypeDiagnostic: DU2PR04MB8950:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FRkV8n54tAy4K/YfpYqLCS0+HRyN97LdKKDFT4MrMC0qtYS85lQgtdqU5YoI6wGG9mmFKUu9rokdVSudZm+R1IZ6qpxuYXL4JLNA9P6XMPF5oTt4s81ECZt6uUsiMH9roAvqOcus9TP2CEholMiSvAn2Vz233Vse4x7L37YeTmDRSkARIpWFXv5t6I0c0RvLBZdcl2fbdyWlTGJ9mTT69bD8jssxmJ0p18g+xEiUEwnQ4gDEqnrRpf1lVluuUObc4b7RnLP5bGUHHC37sZyUewl9r/OzgbFpK4kFReyecy116ZA0o4Szwqr9jUCasTfGMSbLqm45Wga2G/O8iUy+lghwjS2MTL5azO4Oa/o3qY0hP74BB90Zp012FNXT6Ca4eoJiDQDqZfRX7FuvUV9PoKsF2dUb1tOMil6w2qWwWjjjZ48mpV5LkUpQEwHwnuE1kuCkPcNmL+qWvjk0B/72/0cqLWtA60FADPe444N6OAXVC7A2K4AFNNEwzLxHB1bZj5LY/YMMnlb5K9TsKwVK2owHnHE4jnqh7d4821FgVupLh2wv0VM6Qaq7u+0K4XSlCKjISRbzXaSxqUrsItYS+vitpxzrhYuBEYj+xK1nm56WQK+VkyK86yzzjGSJXIPUgT7kTk1Aj6N3+KeyWewVclj+5AiAwtEOMKgCi69KHkLP27CJuKHAU3m4xWSaynn/+ihgJPrtPLmVJze9JH2CgsyyUebkkMdsE6D8kHjCoSge3ecIiy4lEscRafQePsRwlUuIcXG1qTVbcQFRLIyaHtYgbIYMc9SOrsah1B1/yR92aGPqb32cyUehe+1IPqDMIlAj3w39L8ajfkEb4q6V7b6N7Evds+KYFT3Qe3+Ui2dHvWvJIuhgyFmiVMJhdcO04b2cGVP+sU2TpXBQBkPw5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(376002)(396003)(136003)(41300700001)(6486002)(478600001)(186003)(2616005)(66476007)(6512007)(26005)(53546011)(66946007)(6506007)(38100700002)(83380400001)(31686004)(7416002)(2906002)(8936002)(5660300002)(316002)(36756003)(54906003)(31696002)(6916009)(8676002)(66556008)(4326008)(86362001)(4290200001)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U0V3MWhwZHUzRGczZ2pjazdRS0lzVUk4aEdoeHhXNUtGOWZGMG9VV0R4aUlZ?= =?utf-8?B?NmtxNHdIa2VSbVVodGk4OWlKbFBsVmhIMzVEQ1FpSFloMUVKYTRlYzhKSWt4?= =?utf-8?B?NEcrY0g4Uzl2eFR1UXRxcVdqclNXYXZoMzBuNHBrSVU2WUIzWTZsclBDdE9l?= =?utf-8?B?ak1nRUJWU0ZkV2gvcEtQRzdkZnlhLytodGQrUVZaZkp6YVR5U3FaQnREYnJ6?= =?utf-8?B?YmYwd24xWFVTdWwwYkhCeUNlcnVIenZqQnU3VXdxb3AzSjk0K1ZhWGU3bFFE?= =?utf-8?B?VjhQRTJPd21WaFp6OE9ZbkZVMlQySDhGbFByODY4emI0S1RVcllHcy9MUnVz?= =?utf-8?B?OFBqQWpwTEdLdVVjRHRaOEpGem5qWGxydmVBNTV6Nnd4bW14UzZOUStnTTZm?= =?utf-8?B?NmpKSUdKK2lxTkx3alJMRzZNUE80WUM1aXExWkViYXVFUkE1OVVDOHVzeEZz?= =?utf-8?B?RENMbHplU0JUYUVlM1E3SG1YVWdXMGJhUHE4TDRlTVNvT3Zia0FGVVdscjJM?= =?utf-8?B?TUw3LzBUU0s1Tkt1aVBqdXZIOU1Bc1dVRjdDQU95Qjd4M3lHR21vU1lYSE1j?= =?utf-8?B?ellzYUJIYUhrNzRkT29rdkJKMGJRQ3dBUGpHdEVVcUR3Wm15dTArWUNaYkkr?= =?utf-8?B?aUZ2UHlRaW5qMWQzVFo4aHZScTV2VzZmYTMxMmZVZmdvbmZOTi9YNHd3bHdX?= =?utf-8?B?U1FML0VRYk92ODBjWWxxWFFnWnp1eURFQjUxbDJ6RFhHeFZGL1h0a3RydXp4?= =?utf-8?B?d3ByQUF5Y2Fqd3pvZnlkM25pVHorSEloZnhGcVNkRlNsVnFvdVNRMUswNnhI?= =?utf-8?B?N29YVE96anV2MHZhcjRpc2VhWVhWWk14YWUreUhYdzZtVklCSzhuL3hkWDVN?= =?utf-8?B?VmM5Rjl6a2ErRmEzVktnRERWR1VQbXpyU0xqd1dtaTdrODZRanhRVWExN3VI?= =?utf-8?B?SC9YNDkxa1BxU2s5YUttTm1XYkE3aUVIRUViY2dnYkN0TTBINmNqNExUWkFM?= =?utf-8?B?T3V5NjdzWHQrOEpUNDdLUFc2WXQvUnBRaEpQanA4Smxpbk9IcVBzbm9Sekdz?= =?utf-8?B?N3IyNDdtOFdaU2c5cllVd0RDQ3NSRzREWGQ1MCtjWkZVWnd5UlNFQ0ZmRGkw?= =?utf-8?B?dTNuaEdab2VVMXkwQjF3eXF4bEhqaGMwMzFJZDE1NWtnakZ0azVxOCtTQ2dD?= =?utf-8?B?NDZsM3g2S3R2WnJ0N3p2eU82cTFRckswMFFoRmJyRkF5TXlIYUZDY3RIdTBH?= =?utf-8?B?cWZmUmQ0K0lEb0s3b20rUHdqblVSVTlCazVBTDFHdTh3K1gwa1dnQi9kQXV5?= =?utf-8?B?MHdjQ0lpUG9uTzZXUTNuTHFiNXBPN3ArdkUrQkJaQkhmelNQSjRTenNQTU9B?= =?utf-8?B?YUZuUjg1OGxIY3FNODhTamxrYTBKdXNsemIvVlZORk8vZ2pKUG9BU3RsN1ZD?= =?utf-8?B?MFpuRXNPS2c2eFNoOGxzZTdEdnBuTjlCZS8yb2VYcDU4andSa1BPbDQ2SEg5?= =?utf-8?B?MXNSZTAwZnl4NDVsbG5mTFYwQVg1NlZpWEdhOWpZTkd1NXBicUpXbmVzdDlD?= =?utf-8?B?bGQ1bU5ZRWsyN1dxdlNTRUwvODVKYk1yQkhEUUh5R05EdSs0YURlMmNKK0N5?= =?utf-8?B?VVY3Zy9iNUlkNEdvMDhzMjJRTUhpOGkyL0FqblNkSG1vNTFkeEEyOU5mdzkv?= =?utf-8?B?aFVoSm14bTBmMm9zbkF2YyswZlcwYXFUOHRvN0MwSndpUGNXcnJKNEVWNVda?= =?utf-8?B?QlBDUXlZaGxVVE9QdlpQYVIybWxUTHRSR3MrcmpsMHVJREZEaGk3RWdZcHE1?= =?utf-8?B?ZmZLeS9TRmhlOHUvQWJiU3JvNTM1MXBhbE9idDN1ZU5saU1nS3JsUlZDRSt1?= =?utf-8?B?QlJjTjRacDJEZXAxY2FOYktaZVREYUQ0YVl6YXBUWEY5OEg4Zzc5M1NNelp2?= =?utf-8?B?TCtEMm1oRW5XZXZjQ3Z0Wi9lOGdXSWxkOFVkSFZnNjlxNzNiUWtVZElZQVo0?= =?utf-8?B?amV1dFNIY2RuZ2luNEtya2JpWTczZHdGVGE0UGNsZ0FUWHNjSklrV2tDT0U2?= =?utf-8?B?c01JQkxIZXdFZFU1WnNNanRicThxekFKa0kyL1h5bFRaWFhWdElIWHZlR0FY?= =?utf-8?Q?P1Ln4CS4givdL0PdkuMdgyZco?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26b15c35-f5ac-4c17-1f39-08da689d864a X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:11:40.0223 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3j25HM9bDoc0CwL/0lCkYYI+qxZiNuYRXQQzGg6c/PxDK73HT7ro1Zw7kkxZkNNRM9pCUQllerlAWIrC/t8OSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8950 On 15.07.2022 15:26, Andrew Cooper wrote: > While Xen's current VMA means it works, the mawk fix (i.e. using $((0xN)) in > the shell) isn't portable in 32bit shells. See the code comment for the fix. > > The fix found a second latent bug. Recombining $vma_hi/lo should have used > printf "%s%08x" and only worked previously because $vma_lo had bits set in > it's top nibble. Combining with the main fix, %08x becomes %07x. > > Fixes: $XXX patch 1 > Reported-by: Jan Beulich > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich with, I guess, ... > --- a/xen/tools/check-endbr.sh > +++ b/xen/tools/check-endbr.sh > @@ -61,19 +61,36 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & > # the lower bits, rounding integers to the nearest 4k. > # > # Instead, use the fact that Xen's .text is within a 1G aligned region, and > -# split the VMA in half so AWK's numeric addition is only working on 32 bit > -# numbers, which don't lose precision. > +# split the VMA so AWK's numeric addition is only working on <32 bit > +# numbers, which don't lose precision. (See point 5) > # > # 4) MAWK doesn't support plain hex constants (an optional part of the POSIX > # spec), and GAWK and MAWK can't agree on how to work with hex constants in > # a string. Use the shell to convert $vma_lo to decimal before passing to > # AWK. > # > +# 5) Point 4 isn't fully portable. POSIX only requires that $((0xN)) be > +# evaluated as long, which in 32bit shells turns negative if bit 31 of the > +# VMA is set. AWK then interprets this negative number as a double before > +# adding the offsets from the binary grep. > +# > +# Instead of doing an 8/8 split with vma_hi/lo, do a 9/7 split. > +# > +# The consequence of this is that for all offsets, $vma_lo + offset needs > +# to be less that 256M (i.e. 7 nibbles) so as to be successfully recombined > +# with the 9 nibbles of $vma_hi. This is fine; .text is at the start of a > +# 1G aligned region, and Xen is far far smaller than 256M, but leave safety > +# check nevertheless. > +# > eval $(${OBJDUMP} -j .text $1 -h | > - $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') > + $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 9), substr($4, 10, 16)}') > > ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN > > +bin_sz=$(stat -c '%s' $TEXT_BIN) > +[ "$bin_sz" -ge $(((1 << 28) - $vma_lo)) ] && > + { echo "$MSG_PFX Error: .text offsets can exceed 256M" >&2; exit 1; } ... s/can/cannot/ ? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:19:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:19:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369420.600825 (Exim 4.92) (envelope-from ) id 1oDMuQ-0005WZ-Hw; Mon, 18 Jul 2022 09:19:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369420.600825; Mon, 18 Jul 2022 09:19:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMuQ-0005WS-FF; Mon, 18 Jul 2022 09:19:22 +0000 Received: by outflank-mailman (input) for mailman id 369420; Mon, 18 Jul 2022 09:19:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMuO-0005WI-S5; Mon, 18 Jul 2022 09:19:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMuO-0002l1-P3; Mon, 18 Jul 2022 09:19:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMuO-0004cI-9h; Mon, 18 Jul 2022 09:19:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDMuO-0000Ox-9C; Mon, 18 Jul 2022 09:19:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pM1JkZ7gB8ng+rh7rBlRjPQHPEHV3iMz1hyODN/sG4A=; b=SE/7MFcvj2r8yZn9l2TUtOgThs ZLu+nqwVAyMMabe5nuvdFS0xRfjSHnuxzV/fxKSS12m2gsZLhnI81ryzjqyOW/Oh6OeJ56+mgMQi4 Bzfmbpu9x5khxpa6C9h7Fdc08th+60k6aiI9JoH30fwr8BCZF3qdWkuV65uUdDZnv+ac=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171666: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-examine-bios:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 X-Osstest-Versions-That: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 From: osstest service owner Date: Mon, 18 Jul 2022 09:19:20 +0000 flight 171666 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171666/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-examine-bios 6 xen-install fail in 171663 pass in 171666 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 171663 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171663 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171663 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171663 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171663 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171663 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171663 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171663 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171663 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171663 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171663 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171663 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171663 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171663 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171663 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171663 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 baseline version: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 Last test of basis 171666 2022-07-18 02:05:01 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:21:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:21:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369427.600837 (Exim 4.92) (envelope-from ) id 1oDMwj-0006u8-Uv; Mon, 18 Jul 2022 09:21:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369427.600837; Mon, 18 Jul 2022 09:21:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMwj-0006u1-SM; Mon, 18 Jul 2022 09:21:45 +0000 Received: by outflank-mailman (input) for mailman id 369427; Mon, 18 Jul 2022 09:21:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDMwh-0006tv-Ud for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:21:44 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09595e06-067b-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 11:21:42 +0200 (CEST) Received: by mail-lj1-x22e.google.com with SMTP id x10so12407334ljj.11 for ; Mon, 18 Jul 2022 02:21:42 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id p21-20020a2ea4d5000000b0025a6e47056csm2012190ljm.124.2022.07.18.02.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 02:21:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09595e06-067b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zlJEKutNY9pVuug6Mt5ewgM5fGaIPrNI9KwDTjr6eZQ=; b=q6NIJsqw9/m/lD1D3dwpC/s3rbbYzCq0t6AXddu1NPSNyvdOFiIen44qEhGj+XeWxL +S83phBdKn3A9swVP8DnonoacaP9FYyNHwKFe+Iuu6mBtUZB5YQPX5gIYIC8mXikJynG wzkctJSi6in50zlGVvu2PEhl8uyzUIyliN0qSIc7Q645TRRdW7R/xlI/A+xqdrQfcYaU KPdnJYK8CsvSakOy/SDgRlr994JZ0nhyjlqtKBeQ60QYtGy7RSGx2AcT5PBnjRse1XJ7 KiZIU62WYh3KiNRFQGhqbcilXXf1+vwzmabtGGlttm8HObv9Z9TZXTip5nnbBNGSXygK 5kig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=zlJEKutNY9pVuug6Mt5ewgM5fGaIPrNI9KwDTjr6eZQ=; b=099DUQuL8utmFRq0OnR185iCfxy0HdalLbcScqs5cjSXLGvQXBmt9hoQ7FW7r1f6di UxcY1lT9EZlGl7tnbJmcZIhMLXZ/qNT2dm4DU2DK6rQVhLHBPV21Y8JliqaU81nvnnvX 0e2P9ho691X/ONRj3o92OAHcbyaqAeU5MXNj/IxbVA48cKZLQBFVCAC7POkEw2MMLhp5 y+Sw6OjAzoUT+t86EvMQgI1a0365bOsNYVYwsHUXqp96d0y4/uVqvbY735FCr9QVfWwJ 0ZK2EDqSm94lzVdH1PXaWnvJCQoiTmkqN5jMyv27hrZNy7ya7avYVu2rdNk5q4HFPEmp F7vw== X-Gm-Message-State: AJIora/W/lLp5TABCUytSCIJOm10GMbTtmEUu69QYjESny9x5G1mwYEs j2DeYj/T3a9MZ2iA7Ki1UgKuHJp+Vmpv6A== X-Google-Smtp-Source: AGRyM1taznRmUP5tNMGMb7q0aG1XElsMhXGCfKn5LZr37uGgPIFVls8VpEhKNy5FlWbp3YN8pqMvMg== X-Received: by 2002:a05:651c:23b:b0:25d:6920:2b06 with SMTP id z27-20020a05651c023b00b0025d69202b06mr11732155ljn.226.1658136101706; Mon, 18 Jul 2022 02:21:41 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , George Dunlap , Nick Rosbrook , Wei Liu , Anthony PERARD Subject: [PATCH] golang/xenlight: Update generated code Date: Mon, 18 Jul 2022 12:21:25 +0300 Message-Id: <20220718092125.307310-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Re-generate goland bindings to reflect changes to libxl_types.idl from the following commit: 54d8f27d0477 tools/libxl: report trusted backend status to frontends Signed-off-by: Oleksandr Tyshchenko --- tools/golang/xenlight/helpers.gen.go | 12 ++++++++++++ tools/golang/xenlight/types.gen.go | 2 ++ 2 files changed, 14 insertions(+) diff --git a/tools/golang/xenlight/helpers.gen.go b/tools/golang/xenlight/helpers.gen.go index dece545ee0..33fe03971f 100644 --- a/tools/golang/xenlight/helpers.gen.go +++ b/tools/golang/xenlight/helpers.gen.go @@ -1774,6 +1774,9 @@ x.ColoPort = int(xc.colo_port) x.ColoExport = C.GoString(xc.colo_export) x.ActiveDisk = C.GoString(xc.active_disk) x.HiddenDisk = C.GoString(xc.hidden_disk) +if err := x.Trusted.fromC(&xc.trusted);err != nil { +return fmt.Errorf("converting field Trusted: %v", err) +} return nil} @@ -1815,6 +1818,9 @@ if x.ActiveDisk != "" { xc.active_disk = C.CString(x.ActiveDisk)} if x.HiddenDisk != "" { xc.hidden_disk = C.CString(x.HiddenDisk)} +if err := x.Trusted.toC(&xc.trusted); err != nil { +return fmt.Errorf("converting field Trusted: %v", err) +} return nil } @@ -1899,6 +1905,9 @@ x.ColoFilterSecRedirector1Outdev = C.GoString(xc.colo_filter_sec_redirector1_out x.ColoFilterSecRewriter0Queue = C.GoString(xc.colo_filter_sec_rewriter0_queue) x.ColoCheckpointHost = C.GoString(xc.colo_checkpoint_host) x.ColoCheckpointPort = C.GoString(xc.colo_checkpoint_port) +if err := x.Trusted.fromC(&xc.trusted);err != nil { +return fmt.Errorf("converting field Trusted: %v", err) +} return nil} @@ -2028,6 +2037,9 @@ if x.ColoCheckpointHost != "" { xc.colo_checkpoint_host = C.CString(x.ColoCheckpointHost)} if x.ColoCheckpointPort != "" { xc.colo_checkpoint_port = C.CString(x.ColoCheckpointPort)} +if err := x.Trusted.toC(&xc.trusted); err != nil { +return fmt.Errorf("converting field Trusted: %v", err) +} return nil } diff --git a/tools/golang/xenlight/types.gen.go b/tools/golang/xenlight/types.gen.go index 253c9ad93d..bb149547fd 100644 --- a/tools/golang/xenlight/types.gen.go +++ b/tools/golang/xenlight/types.gen.go @@ -652,6 +652,7 @@ ColoPort int ColoExport string ActiveDisk string HiddenDisk string +Trusted Defbool } type DeviceNic struct { @@ -718,6 +719,7 @@ ColoFilterSecRedirector1Outdev string ColoFilterSecRewriter0Queue string ColoCheckpointHost string ColoCheckpointPort string +Trusted Defbool } type DevicePci struct { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:31:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:31:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369435.600848 (Exim 4.92) (envelope-from ) id 1oDN6L-00005e-SS; Mon, 18 Jul 2022 09:31:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369435.600848; Mon, 18 Jul 2022 09:31:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDN6L-00005W-Pc; Mon, 18 Jul 2022 09:31:41 +0000 Received: by outflank-mailman (input) for mailman id 369435; Mon, 18 Jul 2022 09:31:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDN6L-00005Q-3Z for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:31:41 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00070.outbound.protection.outlook.com [40.107.0.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d1d3f53-067c-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 11:31:39 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB7619.eurprd04.prod.outlook.com (2603:10a6:20b:284::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 09:31:38 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:31:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d1d3f53-067c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oHA1VolOOwFgImxk6BCQNlkuKNma9lp3Y7pJ3OusiYvEgXS3A7lCWO/74ASCOp3wPG7DLUj22E2g89tx/eY5A7XcIb6efKUxVzLCQO/al22FLbOCVWNBjNC3YfDG4vuNMMny6k4h7/H7WJFV/5871WfclL6w8mkKxn833hUWvPLE69GjlLwBiixfQ+auNQ/AhqgACBNmswz2ddie1WVtOFK9AADVc2dKx2vqKAdms84Y/08RKjr9gZaonP948MLmUlgZ/DlKsbMCjhNNAPs9RWRz7mbSpEt2gs5PW1N2hl7RQhL3NAp4DnlcAjpaEbR51rGxgnRkpZ/+YjhUoFTOqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hPw+CQPEmTurCtoPIeD/mDTuJpK4KoP8XKbF8Tsnrgw=; b=GLw72F4RA9lnwEQ50zbFkTeda+on1d/HQiDr0f3WKr2yK96TrI4oiFKBF7ykqE1JtRf43wFnz5l9pCm/qJpW2oAO7NUzdr6dU1D97SHuexdpZOhvsP2kTD4e4naWbXcOtLe+0D2Jx0buLL/ReuqYgNLweF9shs08Ip2txuyjb4DHiX2ncZRRMudqoLYfr3lYt15KiePvH6XcTyGumbym64mr7dQ9kRuIn4v7vgAvtQgWDrrdCJRXIE8Bx8SabfQ8MB5KjPU62ZCHBhm8keVIVexrIeH6tXZ2D3RZoKbP26tqb1L3MGWMA6iXyUxKS+aWwUhf9QKSQKhQ1+up4xclaw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hPw+CQPEmTurCtoPIeD/mDTuJpK4KoP8XKbF8Tsnrgw=; b=gHIz+DB9g5BXgaQ2NewPxbrnbdYMFtlwQc81F+hh2GP25S2BLiQo1M7RQJkXzZZ9oJS0biYbQnXqLtng7IZPrLp6K5Y5GEnVpgbGjkq8vHdQE4dVzIh6N3PJ4sKHPQnjHUm2t9CDRPJYbbRA2221GSzXSgdHPpbr4uGE5uUVnX8rIMMkUNaGLLLTe0apIW3k6uFNdXMfjhHaDD7EQ0qDaezQb8HWUBUzWdsSK2RANstWQ5ofbnx0Z6B4G9MR8aNuTBsg8ybwjBuJkw15mEyiRfZV+zGtA8/EVFdSNyD3KIPAzO6RYZJNsGby5o0D31Bb6q5BIM7b6HlAG/sR9DR2TA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <07304aef-e278-9da9-ebd9-640ac7933268@suse.com> Date: Mon, 18 Jul 2022 11:31:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-3-julien@xen.org> From: Jan Beulich In-Reply-To: <20220715170312.13931-3-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11f0659f-8b12-4276-2dfa-08da68a0507f X-MS-TrafficTypeDiagnostic: AM9PR04MB7619:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sd/sEgumq99JcdBF+CHdZMHZrL+uAkXRY+dVKsyTH/oI6OTYnImXVFvrIbwhqaoLrksc340yhVPjCNPoKEdVo0ClIYkH4nw/iuYk1EOuPMPU8oZVbQIM8DJNYs8NEwVMGxQyAyAS+IK56QVZiGUnbmHDp/DfxMKHhoTvyM/wEZ/+1EI88VZPnILCI6PUtpyYFpYd5inFkJNqcvNSSDfn4QAy1rCh28rh6qKVJie7U26TbR3Iro9UfcaCk5QJ6X1J+kArHciolgzk+7v8wdN6uL+fPSC5PcQtB0iOwf7eaeboc2FAMUAfHDuxdNjin4yyDXHB8ryemTs1I1MuYZOdXKbMhPlPlTXBj3kMd5NZbt2w7S6+M/bBOsgNq7nPjM/sx6HDxVaKUvPxzn1rdIWpEPCGHDQJivZKqksyMCkD+RYNur7qTSszf0u4HeZYCEjAG3GatPEyxA5TsdaRWsgP4JsQUvScZ/MQLH3DYGD6g2dVtWqMkankY5B65LOms9ELiY3asAU0Oi2L6nACaZJMFebkvRbZY1aujugmKitMSBQdkE0Whh6QGMLdMniHOLHy5rLas4mVN7eAHbRNm59YoBQDcDsIJvBpL/QkvUp6v0rv9GA/i8LJqmaUQ/7l2qBtwDkVpNcjCD+9J4NMswi93K6RXnAEkHMeGwA39+kP05oBZxTEv3rH2yxgF4sgG9wtXwoKnTmXQwkJvEhtDS8dD6qWYPPA6wb2kzY1I4mqYo4m04s22ZkJM5+4DIIBZdsjgu/CMb5ljsZOoFHzIStyNzNeS8+mYa3WLRYLm8yRk8r7IEGbqFPmM+zBtW3f02LV9zt1KDEWbLKVevxt4vDBMZOoAllSCJubww6XYYso/j8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(376002)(396003)(39860400002)(136003)(4326008)(83380400001)(186003)(38100700002)(36756003)(31686004)(66556008)(66946007)(8676002)(316002)(66476007)(6916009)(54906003)(31696002)(6506007)(2906002)(53546011)(41300700001)(8936002)(6512007)(5660300002)(86362001)(2616005)(6486002)(478600001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2FlSFoyQmFWcDJxZWc1QjIzaXpNZUN4ZThHWDhubHJhVCtoZERuWDR0WEYr?= =?utf-8?B?eXh0Njd2M3Z3djZxNFRESFE4SWdSdlVNL3dkZkE4YndFU2ZaVG9qT0kreGFZ?= =?utf-8?B?N2lpamVKTXRhUWxXelIxdEo0QzJYUGpOMHV1N0J5SzkwZE1iekZDQ3doaDdW?= =?utf-8?B?N1l4bkxZb0dWK05NUExtdFBRc3U0QWxPLzMwWHFOT1RyajM5K0M2bnQrT3Zy?= =?utf-8?B?N3FCdEdJd1RpZGMyblBkTlVyRHpQNkFTQkpZY0FCTGxLMTkwK3IwQzF6Yk5J?= =?utf-8?B?VUZYWjlPTDdndkhXZ1JVL0VBRU5tZUxKSmFhUlJMM0JPZFVKMTZpNXJUcWZv?= =?utf-8?B?dWZ2Q3lHeVhFTnpkTVdwS2hQNysyN3N0YUc5d3RKMXdFYjJoVm9sLzZudVYz?= =?utf-8?B?ZGM1Zk5UODdndGNtamhFY1Y0UGpFQ01XVlZIM1NQbVFVSmR0UUNibmN0T281?= =?utf-8?B?bkRGTHdWMWMvV2pISFljblc4WGd0VU5sNTgySVQ4M3ZvdFZNa05sUmluRUsy?= =?utf-8?B?aTlNNUZWeTdwTWNlakYvRHVPTkpOWEtMeU02eVI5UzcwTnIrVWZodjZnVVlo?= =?utf-8?B?NDcvVW9BaEo5OXZXYUFKT1QwWnpkYkZzbHVmYXExbDc1YnRIUGpxakxoWlBR?= =?utf-8?B?VVlXV3A5QkxFWW9OalJGUlVwa05nTmF0dm16OHVBYnl5ek1MbmNjRlg0MlVO?= =?utf-8?B?aDJjaG4xdzk0eEk0VkhHa3VJS0N2MHU4QTNmZmhxMk5uVkFVVVNiazg2ZzVj?= =?utf-8?B?REFJYzArNFdXRktGUEdyTXlkcXJlZ29veDA5VEU5VFlpZHI3ZXhUamJBQXVR?= =?utf-8?B?dkxIUmgrSlY4WUZuOStJVW9LVEhYaWQzQkFIN1lqTHdXNEZsVzRqbU1waXlm?= =?utf-8?B?d1Z4OWxSaEEvKzRFcGZRam5STVIvRzFyR2UwM0VBbko4WXZhczUyYVNrM2ta?= =?utf-8?B?Umk2blNmcWZ3cmVidWs2aGIybWZOY24xK3VNMnlkR25tdjhrckZ1MmovTERD?= =?utf-8?B?SndKN2pvY20wOG5aSUVpT2JLMy9UTU5lL3pJV2JoU3prN2liRVg4U2ZwVmZE?= =?utf-8?B?VllPM2RBcDgrNThmNld1R3BybDVOYTFjWVFNZXdqbkZNdnhNaFNaNW5oUXQ2?= =?utf-8?B?UXZJSWtSTzc5Q1N0ZU9BUDdFNUE2aW1mV3lLYzc2UFJSUUdIVmhsbk5JM0Zi?= =?utf-8?B?NGwrUTA1U0pPcmY3aUlZcUlCRDFIbTZCaUo4bHVqWGF5dXRpZitQay9pMm1k?= =?utf-8?B?b3pzNXRMdlJ3Vm1CUnU0MU5waFJ2aXordks0Y1JBNWdzbzlWM3lsZkZUOGF1?= =?utf-8?B?Um92eElwQ29PdmNFRlhIcTQ2SmQ2NjdWcGxPRUR0WUtqZnZkK0s0V2tFZ1NT?= =?utf-8?B?ZTVxbkVSMVd3MGkvNi9oSEFVdzRHcnFSVzlMWDNlMkprSEVCellhRDdNY0Fv?= =?utf-8?B?aUVUazdWOUJQbUZwM2RnQTE0UGRWd0pQeEpIenFsT0FoeWFKcDV0YkVEdHdD?= =?utf-8?B?YnorWVErbGFRNGtkU2UxOHdIVFg0RVZGaG54SzVjbGtwL1NvMXpObGZOTFo3?= =?utf-8?B?NytiV2lGb0JONHh0NjBoZWdRYkJ5QnQvUEc5VWowNDFvNjR3UVZyVTE3T1di?= =?utf-8?B?ZE1WYjE2Nk5OQ0FwbGx0UWVYWFBVTklFdmExUG5sZWhudUFrRVpKcjUxTzhx?= =?utf-8?B?QlV4ZFI1STVoZ2lNck45QjlMc29xakRYdm9DN3ZBOHhHd1AzRDJVREZOVnNa?= =?utf-8?B?bWhTYytVL2R3VTRBNEVrRlpzZEg4WTdCTi9DbXQyUjNSZnloWU55Vm9pOXFM?= =?utf-8?B?V2plSHdnVE55T0k5T3ppSU93djdIVUNYaTQrQTl0a2xjV3ErOVMyMlFIdFZY?= =?utf-8?B?eEE0eDZBNnVsSzY0WTg1Kzg2SDR3eFBNMmRpZlU3LzhoWTJqckpycVBqZnND?= =?utf-8?B?cFdwRG9lZGpPL0pmUElFekpBckRIbnBvejFCMDVNcnpsKzlDUm1LOUc4cTlx?= =?utf-8?B?UXhHLzRTeTZiRnNUY1ltMTdOaTc0UXg1T29oUVN1bnJxK2VPbnllUXlzaFF1?= =?utf-8?B?TjBTS01EQUtNM0VrRTUwZnU2SGxsd1NpZGtweFNaaGZPSllDcll2ZDFreGNL?= =?utf-8?Q?LvzF55JMPoQ0wjd+H7AAMmu1z?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 11f0659f-8b12-4276-2dfa-08da68a0507f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:31:38.2008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oxlhLpvGfV8uLK3iW5gHjZbX0YHDuyuG5QzDOxDDT61CGxZUPZrtXYJa3QMPlOtxlZbItfJzIA6MGUZI+4eU4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB7619 On 15.07.2022 19:03, Julien Grall wrote: > From: Julien Grall > > At the moment, init_heap_pages() will call free_heap_pages() page > by page. To reduce the time to initialize the heap, we will want > to provide multiple pages at the same time. > > init_heap_pages() is now split in two parts: > - init_heap_pages(): will break down the range in multiple set > of contiguous pages. For now, the criteria is the pages should > belong to the same NUMA node. > - _init_heap_pages(): will initialize a set of pages belonging to > the same NUMA node. In a follow-up patch, new requirements will > be added (e.g. pages should belong to the same zone). For now the > pages are still passed one by one to free_heap_pages(). > > Note that the comment before init_heap_pages() is heavily outdated and > does not reflect the current code. So update it. > > This patch is a merge/rework of patches from David Woodhouse and > Hongyan Xia. > > Signed-off-by: Julien Grall Reviewed-by: Jan Beulich Albeit maybe with ... > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) > } > > /* > - * Hand the specified arbitrary page range to the specified heap zone > - * checking the node_id of the previous page. If they differ and the > - * latter is not on a MAX_ORDER boundary, then we reserve the page by > - * not freeing it to the buddy allocator. > + * This function should only be called with valid pages from the same NUMA > + * node. > */ > +static void _init_heap_pages(const struct page_info *pg, > + unsigned long nr_pages, > + bool need_scrub) > +{ > + unsigned long s, e; > + unsigned int nid = phys_to_nid(page_to_maddr(pg)); > + > + s = mfn_x(page_to_mfn(pg)); > + e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); > + if ( unlikely(!avail[nid]) ) > + { > + bool use_tail = IS_ALIGNED(s, 1UL << MAX_ORDER) && > + (find_first_set_bit(e) <= find_first_set_bit(s)); > + unsigned long n; > + > + n = init_node_heap(nid, s, nr_pages, &use_tail); > + BUG_ON(n > nr_pages); > + if ( use_tail ) > + e -= n; > + else > + s += n; > + } > + > + while ( s < e ) > + { > + free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); > + s += 1UL; ... the more conventional s++ or ++s used here? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369439.600859 (Exim 4.92) (envelope-from ) id 1oDN6i-0000VF-9t; Mon, 18 Jul 2022 09:32:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369439.600859; Mon, 18 Jul 2022 09:32:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDN6i-0000V7-6Y; Mon, 18 Jul 2022 09:32:04 +0000 Received: by outflank-mailman (input) for mailman id 369439; Mon, 18 Jul 2022 09:32:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDN6h-00005Q-76 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:32:03 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 79a84bfc-067c-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 11:32:02 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 05:31:47 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5641.namprd03.prod.outlook.com (2603:10b6:806:b0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 09:31:46 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:31:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 79a84bfc-067c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658136722; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=g6TxDv8L6D3sVlzAgOLhq2K8/C0ssrD28Etz2HezzaM=; b=OnOzY0Br+cfCCS+xpBBcdWBgGzU8K1m4m6M+9u3fgTPmRNGK0gEzOHyA rC/TtRbpSLE1viG0YJk8w9LegtM1+xFBVeDPtNTrPlxCN+e+e6QEvN6zA JwHqn8Q3IUlLXXyDAO9kvYhuhu98p+TPCjDJi4A1BeAzeSHmtrK3EdQtT 4=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 76015450 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AnxA9F6veFMkVNnufsug0GxU+yufnOphVZtUHD?= =?us-ascii?q?cmfNp3fP3jJ3xfKXnsEbRFcyGXui9imYTMeS5SwoJmzjKRV9u3v4DYpZuM8h?= =?us-ascii?q?77rr09jo4IdxTGCvyVmeAIwTsNIyoBSI6Af0iPgdrLZQ2WD+PpWMVcanmDXh?= =?us-ascii?q?GfVcMvItJs5CcbsPrqLUGUPz53XtP5MjYBzlU91T8fRt5BGY92KCbBxkO8yN?= =?us-ascii?q?J+YjCDGHyhP9/75wbiV3MhypkGfBzBQMCGFwPPiF3yiCMBpSA8O8qH3zQ5Jo?= =?us-ascii?q?Kbk5IqSVu/5FmMhUDud10jCyyKPJ5SZCBV+UFqt301czi4e/jBHVxRn+WOgo?= =?us-ascii?q?4+MTDloAox57B5V/1N7+FlXgeR90QOITOAb4Wd04958z8Pg+o/F+TOOrI5Mp?= =?us-ascii?q?sLztEg9J/r6OeOrVVzTyiA0XYvJ+jPM8zf4wB7pVMb+kZomc2s1HX5lco/7P?= =?us-ascii?q?ZkgO00dOfSw5yaGCPfVKHu479qgt+iGjUWWdfhaWCZyiZExzdQCIdaNrEYoo?= =?us-ascii?q?D1kXUipgdZj/NWgAPWwvNEDmwX8qH+TSoYFu1QTwp6W6ZA4ZLsG8mwhWYOkT?= =?us-ascii?q?XAQ8egLtHpH22fF6CZCPT6mlg6lzMxCxiQpIM9YRFP9PPc1UloTX3ryZc/wb?= =?us-ascii?q?1cDY12p1ffkTPQ6lXewmAkRETPzTwuk2epTDnezphbsE/qY70Dcp58NHs+mI?= =?us-ascii?q?o4I0hYEqd58hHvyxbexZ/NhN5X1WgSM66nJ4UbeQnnSGOQeOO13rqeYJbEg3?= =?us-ascii?q?sDRV/mi4FrPug0PCXLC5HJNkdmZxWz2Fk/jz+SS+Sj3k3zOjCpQrjLpQ6/RJ?= =?us-ascii?q?lj89eO66eDeoTN2cR4GCD3RPjwrJZBgNDCsM2FT1a5UHJ5BR4CZtzFvGz6dq?= =?us-ascii?q?PAe2RX52iH/TltSWJnBOB1QYMgmRDJIHxXVR6SxVtvYaWAn2wn8KKi/aANIZ?= =?us-ascii?q?qGNUCDow0NGroswiu0XPOv77npS0OTuJt6dks4bLN0K1xeNc0XVIGvnFvUyF?= =?us-ascii?q?uTh3GCBfaOw0HdGScmsGZW1UNbdtMSlbJjaBmk7/3pDQloEgWBTX/K37SJhE?= =?us-ascii?q?6lxCBJrz3SQUlM9m1zFsRiplpNtCrDe6ibcykNjLGNW1y7XgNciFZD10OX8s?= =?us-ascii?q?BZ0QgBYEQ+jU4crwV6ToYq8r7RaCwvDDsP1RNaZgh6Uut8hZjGLpqaRGrBse?= =?us-ascii?q?59SxMUnLbcLX02b4y/KsdyS9SB6IIDCWUtHYNp+5b9Tt4sMLA3QQVcp8CaTD?= =?us-ascii?q?UOk1D7J8d8rGsr5i4YSVlR9L3w38sDJBanazJcvXPA6R6ew16ivVqlVPGdd0?= =?us-ascii?q?KEg+FdqzKgxTEmFmnSGOUQtJax7ySRLgiNVBxRgYJEBgSIotcR9huBymSiwe?= =?us-ascii?q?rkX/g3Sz7dWa2WvNeUe5axcXNQAch7KguD1DKNPo8G26/o3obGlKRvIN5lNV?= =?us-ascii?q?AXyiRD9MY3INXQAjAL72g1KbVYsPat5BA2ZRq22RX9QxEXZeoJU5TDzR/vb1?= =?us-ascii?q?zcf4I/F3a0oj61p8vjfyRNs72sxP/E1j07WayNxPy3db2LT+4/9MHRauEIgG?= =?us-ascii?q?0JtpRk5cAQwPgl7WzvabM+jKuUzYJEmiEZXppyRH1Wi7YMw2b1mcn3iexuAv?= =?us-ascii?q?MSzB6fwBxMUMYGDQL2iEUFPbRxCs8WzF5bzJakdi5mLPiv1yfnOYcdA4FmV5?= =?us-ascii?q?fuEEu3oHn0cwTdC326Gu/waQ0+KUDHng+iSxqKwWjXF+YegukXHu2PScNoas?= =?us-ascii?q?E0hWkyF004Ozwq7bKFeHoSDf9yrTY0jg1ITwELBQ4SK0njq7Bi2Y5aWYVf6Q?= =?us-ascii?q?EdNZ0oYWZcOJrkdoyeWCE0Hj7WmMhhExNM0aoxThDIxkNBLv+0NXYR9BTkYM?= =?us-ascii?q?v2INvnCHF0WTITePt2zp/H4OhLxazGLJTGnPxxqshAsaIKQydhIj6nG52z2k?= =?us-ascii?q?vnS4ZgvYpmbTNKgaSp7sX4AXjst247/IkDSxS82MX9pOISqxfsTlODrSnG1+?= =?us-ascii?q?EON7Oa7c/CJNI54ebnyOce2YJnPc1r11ba61ie2tTNSxL3h89ffLiQ/xfebV?= =?us-ascii?q?FLbXnqs1X6K2pRja32uxGzfuw2hN3rXx7d3aoxbbeJj4ZRzY4GmbpDl+zpbX?= =?us-ascii?q?Tl8Ugf0mpifRw3EtCDOzpyktwsOQ79imuPzqs8UoL5xxZMmfG/bnPXF0+0On?= =?us-ascii?q?Mh9gmA+wAdpc9juUyTTB0ZewrqSiTNMfk4xwa6DxDcJtbN0WpYAe18a2pzcT?= =?us-ascii?q?Ec9py1+HYlLEJ0twgRq2Co6ZESA2lTLXfvOZAoVFzLMOP6bcTBZ+hOzd8VSZ?= =?us-ascii?q?o/oldLasv91EZFn3p7vfMcu/J7/3KJ9neAHSd0dNS17uoCnBRrIoQbhcEmkp?= =?us-ascii?q?1Dih8F1FD9Dk8IxH09jXcxUmB4+WKJ2rNzHfvV6ORKmco+d7O3Qc490fFz48?= =?us-ascii?q?57VghLLrHGkvSsmb+rnSuyAytuHNtkAEN9faj1xWC+nR/2nFEunjrEYdwibl?= =?us-ascii?q?E0u2qti6byXp7nJjTQpevlc5dhJEv8v91Ivczw1Gn1CHBhO4VBM2MrGlDAQ3?= =?us-ascii?q?W0CBh6t+T1OZlRmO5Om4SOqI/nUWZ7xIA51E8NPXIJRrTVM3Xc/1gy+2PGxk?= =?us-ascii?q?GcEm+J3AFfLq1/ocXbCed9CtboZzOLr0iX8v4P8Yp80uqJDeY4iRATYkmue7?= =?us-ascii?q?pl4KV7WsUFODdS0eEPHHgXnIUch0BoMC9VhtAX+sg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76015450" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HURXq/rgyC+PfMiyS4DNgbBm06CkQqbgXbRBGO0d0mCoPuP9Zr5s53ujajKQ/qJMo/6GRk0ijMsscqqHKyJggH8PTiCpHaXVf8lXqiJX4fq/jwbkel0aEbFcgIgonJImuWZHkTUaQSO3At7bsVWjL1w17twjwVuhFK4QR3yBdVR+ltdYq2CIGBlLxbjAhmCjQbNV0RpNtl9vcCNamzOb+dnFPTpfuKvvTXWSqZK3SdCP0otZQbuENiYmEPUiHdiFJOOzXG/kyMDM0P14nzJHaCFib9cHsYSn+jUaZwH+SwQfQ/542NquJNcYWFEjvSZ9LgxIxl9yxF7cRUqiDMKaow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g6TxDv8L6D3sVlzAgOLhq2K8/C0ssrD28Etz2HezzaM=; b=Jd9cqJhPCuTqvssTg28O64NIBocJuU4uwjSNvNp3UcmfKEzADiZ1uXnv06WITBxu14uxvid8iZXpXs7bezga7bI3a+VE0ymv7+aO2jN1nNzr/H9sp6bv9hA4dVEBUPRpfJtFtogy5NoF9zkhOUssjIVH9c+S8RCzc8Xf+4j58w7lrzPX6bUcJBpmKnVl85AwgoCKsc4C8cxYegAXJe/AXGF4Wnif2z+mwhEPiIO0byCSSGwbZSHNQZv4flAl4BKNY4KUdyV9krE05F+BXflcWnD9PpZWs18wDpHMe2UtJ6cS0TyCqH/XJFTiOgW23JBtsXKWFCDiiITb6jf+l+/Oiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g6TxDv8L6D3sVlzAgOLhq2K8/C0ssrD28Etz2HezzaM=; b=qSlaMlfcbcYDQlOwK2uOHZWFnBWvWshX2gm6sYmOjGhZBmIz4g0w9K/n9drietX+XwyPZhQx/U9e1wEtO5xnb8fek/2eQdaNBVCxSKodaYTlXGVP+okEvLg4scgodVOiUQpxfqOQeee30723FEkEzPwqRbNxysny4E+b6J7aSbE= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony Perard , Luca Fancellu , Mathieu Tarral , Bertrand Marquis , Xen-devel Subject: Re: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Thread-Topic: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Thread-Index: AQHYmE6f3nf19rITF02bMhbJMzY4w62D3CgAgAAFn4A= Date: Mon, 18 Jul 2022 09:31:45 +0000 Message-ID: References: <20220715132651.1093-1-andrew.cooper3@citrix.com> <20220715132651.1093-3-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 463d4781-7f3d-46d5-9c8c-08da68a05504 x-ms-traffictypediagnostic: SA0PR03MB5641:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TlEeayr9QiySN3sBDkmpMynGX7L0yfgT9eGCxhI9yBb0wdeDhYl0oJH2DTMivNCYH8ZjnhUAehgk5vnvCiyFru8fQPX9CUZVzapebKKl8ESjzNKHeRGwa0ToCz4XPv5Zae7y6PigNvF8EI+UPjEUuGioj0dBky6A1FYrcXvMzmQquthU25EnXX0dENl775CZuFZu/msNdXo706FyxPK//o9xGAJHSq1JxsJ68EC8gmvAPKL3He05/DRIGPxxW7e7yH6cjzRfWg0f/W4MtBEb8DdecfLLW/oCGXXW1MYaBOWD6e8mCAlHs1fDY8eX96vL1SnuZ3bY5IG4HlMIX02RLMYT8SEumUfua+0wpGbaQxw5LRyHWO5gM/MAAabzpbrRQERAigepVo2VdkbcTHE0sqxP7x3vFhnoZGa0eNa+eWDuqNS0rMOneCAW2Xoq+4raPJg7LH/Ein34x2ihiiERiCSX8F5252DZTa9YHzHun0uqX5CPSKaSpmUvUh83qfQOGzPk2BCpi0yvxqbdT/tLAkIb/M/cbJ9yqERmLkrUNryX3874Nt0ONgF7qdS919Q4B1lPMDgQIyBz/Zrp7qIbU1ck6m5meGTPslBKKTZ3ckKrLzs/FbFrGCbTVAu7W5aCkvUoRp+r2hpR+9utd3+OlXiRb79v8DzSwqGYAYcA4SiPUTSLuo04bU3i+eJVMfNbt/MhMtM4Kj4nkq6eRvSS4/Q6TsfeZJcqxzqXrcT6h27g4Ww9C1WwTjh6+hc/DLRkMvC0oxjew0z9mjt+LrGZaaf0llEycjd6shUZNC5r1L3ZdfRe4m9YE/9Oed45Ux/30pRWETNuAuQDkcPdvyN++BgsF1R0jvgz/UyQGSA2Y1X6Gld+iTjoE49k0Dq+zIdo2Qlce7nJpcB3hEUWd9Fwhizklls0tVoer0iAZ5PvIP8= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(31686004)(316002)(38070700005)(82960400001)(122000001)(54906003)(6916009)(36756003)(83380400001)(38100700002)(91956017)(41300700001)(186003)(76116006)(8676002)(66476007)(66556008)(4326008)(64756008)(2906002)(71200400001)(66946007)(66446008)(5660300002)(2616005)(31696002)(6506007)(53546011)(26005)(86362001)(8936002)(6512007)(478600001)(6486002)(4290200001)(21314003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NEFQb1FWNEIydnFBYXZVdXQvT0JEK2lVSC81cGF0a1c3M3NZVlZmVjJxcklk?= =?utf-8?B?RFJzZVpwNWF1UjJqN3NuWnM2OGpOS0F5K2x0RzR1cnNYVXhxbHdmOG5zMExO?= =?utf-8?B?U1VCRHZSVTZCbXp0TVJKSXQ5Vk1TbnYvL2VKWmtyVEQzbVlEcVN5SEVNd0s5?= =?utf-8?B?dGppVGY4MHRmWlNoMmM0aHJQVitFY255TUVVQVJLSmw5NUNPUFh0ZkhKMEUy?= =?utf-8?B?WWV4UjBWTXpvZTFwSng3WVMrOUlxOFl4dGFHSXFvdi9FdHozclZFVDhDdnp0?= =?utf-8?B?UlZIRUxmQWRFdHhYNUg4R0Fxb0NhRUpoWll3OWNTOHh6b3NrSUZxdGhOdWpq?= =?utf-8?B?b3dRc2JwUlppd2FsVmdUR2JBV1I2N05RekQxOHNtVy9XUGpyQTUwa1d3WmRa?= =?utf-8?B?NGpyOU4xVGJKVTYzY1lRb1BUbnVIQU1tMEpkNDI4NnAwNlZ3amNXVXd4bDho?= =?utf-8?B?UmpQc1lBZDNwVGxIQ2ZhaWFzeTBKSXVpK2lkNHFpOHZzaXc5VGRNS3lHOHBS?= =?utf-8?B?VnBEc05kUURUY1dqV1pTeldGWGg2UHdUNU1OeHlDL2Z5WkY1LzhQU0oyQ3FN?= =?utf-8?B?cjVvTk9qTnlNRkRNNVVpQWZENk9yemhzRTJEUHVqcCtqMTNIQ1dqRVZFVzdT?= =?utf-8?B?eWxHL04wUmNXU2hHc1pxRGlYTmJ5RnIxdUV2TkxNNngxS0FHOHRmeFV0VkMr?= =?utf-8?B?UmRFcVREQUs0dlFteFJ1Qk1udThPZitCbkxuU09WWTM0Q0JFR1FxTENLR2tO?= =?utf-8?B?MHdML29BVE9WdlVGZG9uTTFEbHJwTVNoc3RBdFcxRkVPMUNXQnVlTlh5OG15?= =?utf-8?B?QStQMkhjTW14dC9MZFdQMEJyTjBxV1ZBTzBCQ1krangrNmI5bXR4ZjNPbXlE?= =?utf-8?B?ZDQ4OVBLRU5TclJUa0xhYUFNdkg4aEZsWW9PTklBTW9nVXhMQkVmcEx6VXAx?= =?utf-8?B?Nm1kdWZNbmlKYjduSlptUXlMeVpBdUJUbTZLZ3FnK25XRmdmbkMrb2VocTdD?= =?utf-8?B?ajFwZSt3ODB1NnV4ekVjVXNhR2hROTQ4dWVEd2xoUUNPUFpEN1YrelFGdDVB?= =?utf-8?B?QlNCOVhRd3FZVWdhUWNXLzM5OGFMdnFON3lGWnNUb2psdzJ2dTVVRnJDL0Vz?= =?utf-8?B?MmM5VWM5YzVTNXdLejdiMlFWUStwcnRhMEZlbExrV3lHV0c3a0cveGRVNnJq?= =?utf-8?B?aVNiQlBYZldqZTV6cENUR01Ga1BmNzg3M0JVMVkzbVVYRzhNNmxKYXN2MDI1?= =?utf-8?B?S21YcnBVWXIxbUs3UUZBMDNwWG90L0ZWUU9SUkxsVmVvaXdUbWF2U0djL0JO?= =?utf-8?B?c0VNejZUcEVCdDU0MzJCeUZPQzVSMXlNbHFwa0ltYTRhc1R1WEROR2lrck84?= =?utf-8?B?YWtvVUE2M2w3RWkxb2IzVTNDK0Y1aDdlYmJ1U1BmVGFPb05HNGRKZ09Nbk8z?= =?utf-8?B?RDBiQzNQMTN1Tks0OGdIcUZvaHJiZXd2ZlJrSkdwZitTRVEzN2hrTHcvdCti?= =?utf-8?B?NWI5YVJzbFk1YzZjbEJVU3NnWEdzak1pWE9PV2svWlFJTnV1ajVrNnpod3lF?= =?utf-8?B?UEY3ZUJWeWZxbEhPQ2xNRnc2Mk4yT2w5ODBTOE5QNlh2QUhPY3RxTnFWY0tN?= =?utf-8?B?ckZWYTlnQlluNFJRTWtVSGN2R2liRXpIWHJoODErSzFhSlQxSDRhSE1uTnBS?= =?utf-8?B?WmY5RlVncEhyYXoyQTRvQldsL00xYVRVbFdxODVXSS9oNnB5SmM1K2Fxckpx?= =?utf-8?B?Tnlvb05xcmVibyt4R2JyNnFJV0RoM01Xb1pibW92VGFIMk1iNjZhTHRVdFdZ?= =?utf-8?B?K0YwL2dVaDRLY1NiQmlteFdBaisvek5XNnRROXp5K1I0cmdBRHV6aDZmQkVE?= =?utf-8?B?SVloNWdyUXc1VHVXT3g1OTh2QTY3eUQvTmM2YUY4enU4MHdYZVF0bmNXZFlm?= =?utf-8?B?RGpGQ0lYbUt6VTNoTDlzQU4zRmlmbk5xSVpWUngwSTBDckpYb1pHS2E0SVFZ?= =?utf-8?B?UkNza1F6a1E0dWVoZndqaDVQTnhQajA4TVZ3Tzd2K3p2clFFeUdueHI5bUF6?= =?utf-8?B?am9NSi9KRHNLRk1zQ29VNk94Q1BRUjNoeUdOMytYeStwLzduQjg4aldIcVAw?= =?utf-8?Q?Jhtp/q8KVwyFUaLpDpp2gLF9E?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 463d4781-7f3d-46d5-9c8c-08da68a05504 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 09:31:45.6455 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kRCSnnhWki1hhCwve1tC32+qBGtbXssiDa6sJwbr62e8mh2Ior0XOlC7SLNysAwgOSUGJKp669RSpY5JK7UGzfIK12VShhDeAB6DR4kaayo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5641 T24gMTgvMDcvMjAyMiAxMDoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE1LjA3LjIwMjIg MTU6MjYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXaGlsZSBYZW4ncyBjdXJyZW50IFZNQSBt ZWFucyBpdCB3b3JrcywgdGhlIG1hd2sgZml4IChpLmUuIHVzaW5nICQoKDB4TikpIGluDQo+PiB0 aGUgc2hlbGwpIGlzbid0IHBvcnRhYmxlIGluIDMyYml0IHNoZWxscy4gIFNlZSB0aGUgY29kZSBj b21tZW50IGZvciB0aGUgZml4Lg0KPj4NCj4+IFRoZSBmaXggZm91bmQgYSBzZWNvbmQgbGF0ZW50 IGJ1Zy4gIFJlY29tYmluaW5nICR2bWFfaGkvbG8gc2hvdWxkIGhhdmUgdXNlZA0KPj4gcHJpbnRm ICIlcyUwOHgiIGFuZCBvbmx5IHdvcmtlZCBwcmV2aW91c2x5IGJlY2F1c2UgJHZtYV9sbyBoYWQg Yml0cyBzZXQgaW4NCj4+IGl0J3MgdG9wIG5pYmJsZS4gIENvbWJpbmluZyB3aXRoIHRoZSBtYWlu IGZpeCwgJTA4eCBiZWNvbWVzICUwN3guDQo+Pg0KPj4gRml4ZXM6ICRYWFggcGF0Y2ggMQ0KPj4g UmVwb3J0ZWQtYnk6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4NCj4+IFNpZ25lZC1v ZmYtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo+IFJldmll d2VkLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClRoYW5rcywgYnV0Li4u DQoNCj4gd2l0aCwgSSBndWVzcywgLi4uDQo+DQo+PiAtLS0gYS94ZW4vdG9vbHMvY2hlY2stZW5k YnIuc2gNCj4+ICsrKyBiL3hlbi90b29scy9jaGVjay1lbmRici5zaA0KPj4gQEAgLTYxLDE5ICs2 MSwzNiBAQCAke09CSkRVTVB9IC1qIC50ZXh0ICQxIC1kIC13IHwgZ3JlcCAnCWVuZGJyNjQgKiQn IHwgY3V0IC1mIDEgLWQgJzonID4gJFZBTElEICYNCj4+ICAjICAgIHRoZSBsb3dlciBiaXRzLCBy b3VuZGluZyBpbnRlZ2VycyB0byB0aGUgbmVhcmVzdCA0ay4NCj4+ICAjDQo+PiAgIyAgICBJbnN0 ZWFkLCB1c2UgdGhlIGZhY3QgdGhhdCBYZW4ncyAudGV4dCBpcyB3aXRoaW4gYSAxRyBhbGlnbmVk IHJlZ2lvbiwgYW5kDQo+PiAtIyAgICBzcGxpdCB0aGUgVk1BIGluIGhhbGYgc28gQVdLJ3MgbnVt ZXJpYyBhZGRpdGlvbiBpcyBvbmx5IHdvcmtpbmcgb24gMzIgYml0DQo+PiAtIyAgICBudW1iZXJz LCB3aGljaCBkb24ndCBsb3NlIHByZWNpc2lvbi4NCj4+ICsjICAgIHNwbGl0IHRoZSBWTUEgc28g QVdLJ3MgbnVtZXJpYyBhZGRpdGlvbiBpcyBvbmx5IHdvcmtpbmcgb24gPDMyIGJpdA0KPj4gKyMg ICAgbnVtYmVycywgd2hpY2ggZG9uJ3QgbG9zZSBwcmVjaXNpb24uICAoU2VlIHBvaW50IDUpDQo+ PiAgIw0KPj4gICMgNCkgTUFXSyBkb2Vzbid0IHN1cHBvcnQgcGxhaW4gaGV4IGNvbnN0YW50cyAo YW4gb3B0aW9uYWwgcGFydCBvZiB0aGUgUE9TSVgNCj4+ICAjICAgIHNwZWMpLCBhbmQgR0FXSyBh bmQgTUFXSyBjYW4ndCBhZ3JlZSBvbiBob3cgdG8gd29yayB3aXRoIGhleCBjb25zdGFudHMgaW4N Cj4+ICAjICAgIGEgc3RyaW5nLiAgVXNlIHRoZSBzaGVsbCB0byBjb252ZXJ0ICR2bWFfbG8gdG8g ZGVjaW1hbCBiZWZvcmUgcGFzc2luZyB0bw0KPj4gICMgICAgQVdLLg0KPj4gICMNCj4+ICsjIDUp IFBvaW50IDQgaXNuJ3QgZnVsbHkgcG9ydGFibGUuICBQT1NJWCBvbmx5IHJlcXVpcmVzIHRoYXQg JCgoMHhOKSkgYmUNCj4+ICsjICAgIGV2YWx1YXRlZCBhcyBsb25nLCB3aGljaCBpbiAzMmJpdCBz aGVsbHMgdHVybnMgbmVnYXRpdmUgaWYgYml0IDMxIG9mIHRoZQ0KPj4gKyMgICAgVk1BIGlzIHNl dC4gIEFXSyB0aGVuIGludGVycHJldHMgdGhpcyBuZWdhdGl2ZSBudW1iZXIgYXMgYSBkb3VibGUg YmVmb3JlDQo+PiArIyAgICBhZGRpbmcgdGhlIG9mZnNldHMgZnJvbSB0aGUgYmluYXJ5IGdyZXAu DQo+PiArIw0KPj4gKyMgICAgSW5zdGVhZCBvZiBkb2luZyBhbiA4Lzggc3BsaXQgd2l0aCB2bWFf aGkvbG8sIGRvIGEgOS83IHNwbGl0Lg0KPj4gKyMNCj4+ICsjICAgIFRoZSBjb25zZXF1ZW5jZSBv ZiB0aGlzIGlzIHRoYXQgZm9yIGFsbCBvZmZzZXRzLCAkdm1hX2xvICsgb2Zmc2V0IG5lZWRzDQo+ PiArIyAgICB0byBiZSBsZXNzIHRoYXQgMjU2TSAoaS5lLiA3IG5pYmJsZXMpIHNvIGFzIHRvIGJl IHN1Y2Nlc3NmdWxseSByZWNvbWJpbmVkDQo+PiArIyAgICB3aXRoIHRoZSA5IG5pYmJsZXMgb2Yg JHZtYV9oaS4gIFRoaXMgaXMgZmluZTsgLnRleHQgaXMgYXQgdGhlIHN0YXJ0IG9mIGENCj4+ICsj ICAgIDFHIGFsaWduZWQgcmVnaW9uLCBhbmQgWGVuIGlzIGZhciBmYXIgc21hbGxlciB0aGFuIDI1 Nk0sIGJ1dCBsZWF2ZSBzYWZldHkNCj4+ICsjICAgIGNoZWNrIG5ldmVydGhlbGVzcy4NCj4+ICsj DQo+PiAgZXZhbCAkKCR7T0JKRFVNUH0gLWogLnRleHQgJDEgLWggfA0KPj4gLSAgICAkQVdLICck MiA9PSAiLnRleHQiIHtwcmludGYgInZtYV9oaT0lc1xudm1hX2xvPSVzXG4iLCBzdWJzdHIoJDQs IDEsIDgpLCBzdWJzdHIoJDQsIDksIDE2KX0nKQ0KPj4gKyAgICAkQVdLICckMiA9PSAiLnRleHQi IHtwcmludGYgInZtYV9oaT0lc1xudm1hX2xvPSVzXG4iLCBzdWJzdHIoJDQsIDEsIDkpLCBzdWJz dHIoJDQsIDEwLCAxNil9JykNCj4+ICANCj4+ICAke09CSkNPUFl9IC1qIC50ZXh0ICQxIC1PIGJp bmFyeSAkVEVYVF9CSU4NCj4+ICANCj4+ICtiaW5fc3o9JChzdGF0IC1jICclcycgJFRFWFRfQklO KQ0KPj4gK1sgIiRiaW5fc3oiIC1nZSAkKCgoMSA8PCAyOCkgLSAkdm1hX2xvKSkgXSAmJg0KPj4g KyAgICB7IGVjaG8gIiRNU0dfUEZYIEVycm9yOiAudGV4dCBvZmZzZXRzIGNhbiBleGNlZWQgMjU2 TSIgPiYyOyBleGl0IDE7IH0NCj4gLi4uIHMvY2FuL2Nhbm5vdC8gPw0KDQpXaHk/wqAgIkNhbiIg aXMgY29ycmVjdCBoZXJlLsKgIElmIHRoZSBvZmZzZXRzIGNhbid0IGV4Y2VlZCAyNTZNLCB0aGVu DQpldmVyeXRoaW5nIGlzIGdvb2QuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:43:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:43:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369449.600870 (Exim 4.92) (envelope-from ) id 1oDNHt-0002NU-Av; Mon, 18 Jul 2022 09:43:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369449.600870; Mon, 18 Jul 2022 09:43:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNHt-0002NN-7v; Mon, 18 Jul 2022 09:43:37 +0000 Received: by outflank-mailman (input) for mailman id 369449; Mon, 18 Jul 2022 09:43:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNHr-0002NH-Tg for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:43:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17589cbb-067e-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 11:43:34 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB4573.eurprd04.prod.outlook.com (2603:10a6:803:73::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.22; Mon, 18 Jul 2022 09:43:31 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:43:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17589cbb-067e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ToWbAoIGmWiB2JWApOjwq1nhSt76bY9RiF0g9NFpNhfIDGzQ5a4+vLw+c282uSno9JsIttFZx2Xd7j0Bq/7VZOsoH3CQwbYAkZ0wO2IL5WeFXUgkY7HAIEfo74JPdDpc1T71VqStpvikYEnfMarVLNw9Yi+Pxar/gUmnIDVDiCqetcyXbqbvjtXpBcspsAka4zXdn9c8cHJQvbfg+MPwDjlTq39o+WRYurAMsBHXqGCyQD1+56+mf5SUeasZ3R0P03Pt57Yp+bvsYEnQBWyN0pWVHLN7r8Ux8RrUnyIuQnp4ZMmWizVew91mG9naaCzm+8h+xYAHbO94yCdtL8ZpQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8dLd18yrvmKkY6RdSDTFDHEopdb2NaPYrmYREfKHUus=; b=hIX9SvDy+rREyE1J9KlzI1guSPK5BGBZCXylBp6P6ae4m4Ij32yf8YPthulCmV3BpwxAFC0dECFkF9cw09dbqVgtFNLltb0yB/BHr4UvN3pwfrGUB4E53tqviteOeXuQta/0RLu1Te1Ll2tRYNy+riHLJtQwcE35VnQaBzEn24m5WEG7TE6Eeh2L778oug4/ybl4TctvxByiYFlKxG+wV/AXBqPcw66I/moQa7UijQkGSXr3jZK0ic7KU9EbUfK3y3NtdImqhP0Cx3NoMORXG91AZYOvY+5n5xx/m5ksh7Djl2HUpEd8CHxmlQ4F7aFIywCzN1CSMygO4rK0DmOzhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8dLd18yrvmKkY6RdSDTFDHEopdb2NaPYrmYREfKHUus=; b=hCYsDc1YtFfgBoQst5OllSrTalLdYIsDaGvrFSdyetpCsir0JbcrbvquB1q39+Kso4W3E+s8AdTBAy9L4iGCtPYmsbVw4YA8s5JoF6ru8W6ayyLAuTpKKTWA78HahfyFBetAJrpPzx/CgsZoKdtJLPL4HIkcBznZGvwRDxjzKJO7bqHYsg7TixEFe4OV1CByRdh92q9y7Thf0CDGeXVNNZvGM+H6x8hCpBUI6aqdtgr50d86cgzaAs5+A4+F7TlGeGIhEYuwdX0NIpuAhL1drwj7U6G+b5Q1+4Yw9MJx/rY/bzKvfsB2wYQGwWFAaHmfPFEUNm7TS2AY7gDgzrgjBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> Date: Mon, 18 Jul 2022 11:43:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> From: Jan Beulich In-Reply-To: <20220715170312.13931-4-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0608.eurprd06.prod.outlook.com (2603:10a6:20b:46e::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 983c5309-74b5-407c-d63a-08da68a1f9cb X-MS-TrafficTypeDiagnostic: VI1PR04MB4573:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HRWtpXBB8QMsljIOZ9zIhjn5BtPwx1W1D8BoEClfvIvJLuMLQdvewDg4kYFjeExChbeO4JU0KjtTCqmHuOGpbGkbeseCdMQAtvErZGsNFzUoysfBbooAWS097H+b7ocxYFQQ1w2COSQxPFoAlK2kMHCzio8d/4RCub+5sHDEOe1CpQEfXDk879bYOGDmno8EG5u3Eh/HVHwRZCaMnAOpN1jntcYGUzLLSUVNiCq0fZEBisF2TZJ9GMoGfWRHSFvZyRcbjP55mipRn+ji2b378hpEhquawNnKGX17SMdf/EvmD6Gk09iNlu64R98ePvNjMrctTDzBqtmQh0eYCpaI2wgP6oGiwDUP/AunuKZnEfZ8q0E5iHEVgUkrJ5BrpVyCr/b20vjvB+2FV7NqECKpLW2hPqLVt9WEKaOzOE4CWLYKoBuO/amqjfHxtFYA9Vk/QON1Pcym2dEp6Oopd2D9mg0eehXKR7UzVA4rP/KneHXBKRn34n02pNWy7YX6apzoF+nLX9Z4JPGo0hSo126paiKscxwYvFXpjR91qpZfDsgOFtySK7JusvUWbRDMFfstKHqIEzUswu2/YMKDALHwMnO2MeJF4D8dwk7H5cYwBC4xjOQ4PgrTEeQnur641VSPmmPem2W+DnBL74iaGl0smxyDfj3Sph3PuLpAykvw7iXDSYtcVxe0nWT8jaXa8CaZqgGh+rA+PftX5WbqtpBYbtk7I2WtrD/Y3OWYtF7l7cd4HM+2jLq3TH1b9ge3DqZAjqsVA+qpg4cSrsm4grsZ9ZXgHh8y7Pz9Rf7nGU6bAR8uvqjYnpfj29K+10E85iirCEuEmU9rNcKi1exKj3gfwtWGRriBkIwRGxgFitkWtLQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(376002)(366004)(39850400004)(346002)(66476007)(66556008)(66946007)(4326008)(8676002)(8936002)(6916009)(316002)(54906003)(36756003)(86362001)(2906002)(31686004)(38100700002)(83380400001)(5660300002)(26005)(186003)(53546011)(41300700001)(6506007)(6486002)(478600001)(2616005)(6512007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WWtLUk9uaGR2RGNEaTQyTnQ4Uk8rcWV5V3NQbEVRMzZSeWcrNG13Um5qNGJN?= =?utf-8?B?emJxVVFab2lWa3BDOVp2Vm9CYkU2OVU2TlVPb1dnVmlpZUxRaUNTYjNGVmRv?= =?utf-8?B?Y3dVYW80all3MGI3QzU0eTlaRGdxVnUrTHdRa3B2ZWYwYk5pRE53Y1hkL1l5?= =?utf-8?B?WDBmVXlVYjdaSC94YWcwV0tZQW4ycHByOXFFUDM3dWdKbjJuMUd3YTBpbXg2?= =?utf-8?B?VVNZSDZUcHR1TXRSeEx0cjhCOUhUaEFzaUJsNDZVdlpJL3ltZGZEeW5PTDFR?= =?utf-8?B?U0EzWHYxWitmdHBZd29NblhwQ2NvUmE1N0trc1V2YXhBZFdYbFlGUHpBY1Rp?= =?utf-8?B?N0ZtQVdzbCtqM3Y0U1hua3FiVHBzMXRNeUZwREpWNWhFRHdSZSt3VVBDcG5S?= =?utf-8?B?RC9VYXpabmVQak1zNkRQNUF5eXR2cVJ6bVFHQnZCaEd6RENNVW1POWJBeEFH?= =?utf-8?B?UFRwNExvM2JyTjhCbHd6ZGhxdzRsOWtveDFrajhFejlwMnp2alhhc2VtNHc5?= =?utf-8?B?bE1ZZG9lOXR3aWZkQ2Qwd1VaOVhQUTRWcGtBWEdDU09MUU5TNGpyNStsUzJz?= =?utf-8?B?Z1IwRDNvOW11SWJjbnVJbFB2ZG1nOXJMQXFMUlFlaEx3eHlKUmtvWlE1c2x0?= =?utf-8?B?Q08yRzhnaGVMTk9Dby9TK21GcjRxa1FkRjN4bndKRlZ1V2QwTXdoWWRzOE9X?= =?utf-8?B?UmZ1Qy9haytpZHdsYjRmQWN3M0M3NFVqVnhKNy9vZGtaWno1RGR1aW5LV1o2?= =?utf-8?B?TUdoU0VFekN4OWRjNUl6ajhUVlRENWVCZWptYmpVS29EYlRVeUNZczRrVk5t?= =?utf-8?B?Y1NLbmF1UzA4RTJYbzFNVExsU2t1cHppWmU5L0pVbnJ4RlV5anY4Ty9MWStK?= =?utf-8?B?WHZSMXpBTzFnQWZjUStnSHNZS2wwUC8yVDByMUZzUzh5N2dwOGU2aVRWd2g2?= =?utf-8?B?T0hjTjRBVEoyVjJjbjZQclpPZEhUTU94Tk8za1hlc1orcjd3QlJyS1NhZWxx?= =?utf-8?B?U01IVFFuK3BGb2thcTBjMFVCS1dQKzQrYlRDcjFsaGVaOXAzYlBaWnZLbW5q?= =?utf-8?B?cE8xS3QwSnh0Y1RBQkF4cU1nZnZNZUJHcGM4QWowT1JEbElQZjk4VmZiUkRv?= =?utf-8?B?SGJuWlFiRStmNEhsdmVyVkU3Rk5KL0xZSmN6SEJ5VWJoQ3FsTnhadkhOdVY5?= =?utf-8?B?V1pLcDdPL24wKzludjJ2cm1FNnhOZlAwVWd6dm1CTkpCTVRjTU8wekVKYU1N?= =?utf-8?B?d3F2aW9BbkFtMkVMNUxoRG9BN2dVOHV6VEdTSDV6bWtEOWVFMGE1U280azB0?= =?utf-8?B?QVBOSE5oQUQ2SlBwTUxFYVRhbVpJcGIzaEwxVDNXMVRlNDFCV203YUl5a2ZN?= =?utf-8?B?cUdKczBYbE1ERVV4YUtHQ0c3dStKREZRd3dneDBZQ21kei9VQUtwM1V2ek8r?= =?utf-8?B?UXp4Yk1wYzVFVDR3OXgyRjNhdnVaTC9tVnQzempBckxmd2ZNUXRRZGtwSHRV?= =?utf-8?B?dGJvQUFoUlJVcUM0MkhVL0NGVHZtS3lsL2tETm1GT1BNakVIRVBUMDNheGtS?= =?utf-8?B?aEw1UWhXUzQvSE1QdHA5cEZKSG1Ua05ubGh1bmNJRXJTdzZZVUJqMXlYdFZD?= =?utf-8?B?aTFVYjRwWHo5RTZwZi9QZ1FJUzJTYytZZVIyV1AxZDlFb1Y2blV2bWtaK2F3?= =?utf-8?B?RWJ0T0x6NWVIZlZUbDNpcm05VmF0UVlxNHI3a3dmdHR5OUJkZ05tVWxzb3pH?= =?utf-8?B?WWJTeWxWQkJmcCtkMGJtTHRmQW9OWlYxSGdHNVFEWlNhOElYbFY0VjN2OTdl?= =?utf-8?B?Z00vU3IyUUtYT1A5Z0tDeFhCR2hxYzJSRzZGT0RCdlNQbFBQNVJFckVJWktn?= =?utf-8?B?VDQyczZVRXl5VXo1QnVRSEIxVkxTQWltQkoySnR3VUQzUldNOS9WNFh0N3R1?= =?utf-8?B?eVV0SG0wWWFLcEdRR0g1aGdZeFRMRmN1VldIUWpGS3FrZ25ydVBIcGFvOGVu?= =?utf-8?B?ZU0wbWRhcktUdWtSLzl1NlVHQWNMTEVNeHkrRzVubmJkVTd5NDEzbEFBNnhU?= =?utf-8?B?QWRyZnU1RGhVNHg4cTZIZXNhZXZ6K0tKblhiSkYxY3l1TGFqTGZsNHg4cVVY?= =?utf-8?Q?StyZl6li/N4jxCrUz4hlk4W5T?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 983c5309-74b5-407c-d63a-08da68a1f9cb X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:43:31.7661 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pSeh9h30FpYVMyJT1eVHFCWIyuDh1w21wzTg/WyeNyN/XPQSxMdkBSmAH3nsYpFPZrtn+6tq+GbKTGDe7dotmQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4573 On 15.07.2022 19:03, Julien Grall wrote: > @@ -1806,8 +1806,22 @@ static void _init_heap_pages(const struct page_info *pg, > > while ( s < e ) > { > - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); > - s += 1UL; > + /* > + * For s == 0, we simply use the largest increment by checking the > + * MSB of the region size. For s != 0, we also need to ensure that the > + * chunk is properly sized to end at power-of-two alignment. We do this > + * by checking the LSB of the start address and use its index as > + * the increment. Both cases need to be guarded by MAX_ORDER. s/guarded/bounded/ ? > + * Note that the value of ffsl() and flsl() starts from 1 so we need > + * to decrement it by 1. > + */ > + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); unsigned int, since ... > + if ( s ) > + inc_order = min(inc_order, ffsl(s) - 1); > + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); ... that's what the function parameter says, and the value also can go negative? Preferably with these adjustments Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:49:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:49:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369460.600880 (Exim 4.92) (envelope-from ) id 1oDNNW-0003BU-W9; Mon, 18 Jul 2022 09:49:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369460.600880; Mon, 18 Jul 2022 09:49:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNNW-0003BN-T8; Mon, 18 Jul 2022 09:49:26 +0000 Received: by outflank-mailman (input) for mailman id 369460; Mon, 18 Jul 2022 09:49:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNNV-0003BH-Jp for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:49:25 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10054.outbound.protection.outlook.com [40.107.1.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e7ca6782-067e-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 11:49:24 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB7PR04MB5209.eurprd04.prod.outlook.com (2603:10a6:10:13::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 09:49:21 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:49:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e7ca6782-067e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jgk31qrwKk2FNTfp2htxMK4tbVS71MBcNrQCOENE3olX55LyUvdwRNs2eKdbBeHI3gdG41gkNVApYqM337rQpY4pM77iffQJe+WSjy62cp4FsUOZ5NrNjgTDXrMrV8siK2KJhrPW06nAvxeYSNSL0nM6vtu8v6bAOhVgG9stCWMwkOwlQNdcc1LBurv7jbEkbJs9oonkL60jbKySTHlhGsCLqu1RjHJwEyNBMKqrtRsg1j09lV3jPWmDcG+1tkwxaishcD0mcIYx4Polf2t9GHnXJCci9o/Rw7X8pbxHOhTA/dLSEU2SVYPbhBE57gzKM0RtLwVuVwO/lL2JbwWt5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mQ5zshumVsMdkpAYtuQQKspNTbzMA87oEp5PPWkFb/s=; b=iERV8tzxGAsRsaONMCPbXIv7iaoa7nAg8mYFWEbFnHctetH1oVQc+SQSARZHTrMzVFVdhY++IVkMHul5wfgrr8jrFk57L/4xpex5NlE+iWvAGQ7vE0KtB2iXyKvLGZseeK03MQw5BSeP9wvIDDRo6xe19HzVswSNaiGLm9to1/Kr15pFeVJviKFTuiDIr5ZE9qeXVzImOsD95nWeJ1M0zURNwgUHgmsSXuiYNcgbiMvvfvCRdIp7y/n2wQqSvRtAmfz2GYlhGfOXARmQmijhqgkZPzOu53oDs6Ss3zhGkLEifE+zexv4WA9kwTGBm2El3y3vQxK6x9qzTybFY54sbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mQ5zshumVsMdkpAYtuQQKspNTbzMA87oEp5PPWkFb/s=; b=bJSv8vp3lI2vOpaq0US90eNNvjNCyPyApR0YCwRYL0kp737dPceSOT4J4UzUdjPiYUyiAkyOievqD9A0AKhyyKogvQ221+4Xcbqlrw1asSkuWFgVlZ9lOzKH/TUbk1Yeos3JHksbpUzT/4nGWS3pu41Mkvc0pkIxV93YyB7Svqa2ysb98VG5jvoXf9A3Icz1E91DVt76DO6qMvpHMya1gXXx9xoNnBmxgJeQmahQ53GvvWfXhxlC047BigyE2SnbqD1AYBNxY+Wb1brqngWpaAk035+FmInO7/x2D21Sbnja/XNOZxmLKa9sVPMtLmUaZ0gABDxiAaPqAOl4TB11xg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <465e44a0-2005-99bc-3fca-241b8c510df5@suse.com> Date: Mon, 18 Jul 2022 11:49:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony Perard , Luca Fancellu , Mathieu Tarral , Bertrand Marquis , Xen-devel References: <20220715132651.1093-1-andrew.cooper3@citrix.com> <20220715132651.1093-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0086.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::22) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5622d46b-53d4-4ba4-9f8f-08da68a2ca4e X-MS-TrafficTypeDiagnostic: DB7PR04MB5209:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rqQl0f9fPFcByqqAlE2vq3LGZ3W8XsJQJKnnj2g9QdvKsZnPprSKp8HvskmlPzaDVENLHCGPE6xdbPvQrYYnly3n1TpZfD9eqjICCBP8TuvGjdUYRI3EXtYiU1PpZ8WcMCiHvJP8ckCC22iUxc3KJ9zkN0guSt2fJbbCc0/pJFMBjRwY8tmgDjXQfr3DBEzaqeKLjoBiMyjLGV+zxLQB5oDfiDgCowp/yGou3HkFJ3TZbTCJHHyYw50Sq/mPEn0wN8VvyDe96TwaccflceEFLog8XSc6TRqYQx1ty4sWB4I2+pVgyWDfl+q66umUaMSXYdl8KSF8HX2MbSQFbhcmtutBAC4rLsQJaD0Km0YF27rZkzkAps3JnOX7bih5uZbXiZDeFm+iiseooImXNBfFZY3ex8QUlmgx51d6aSK8RSl/S/qBIHt1AveG0hDnYBCcLLaGTTwepF2F76yfdHe4q7qSqTDdDqLT8GGVafdaEH0L8Pm792GIzjVoCtMpBp0xZkdxexHMRLkDmbsDIwmPkgq+mZIAm74rtNjpZ7PDZdZd4PF5nmAc/ih3kvH6P/LIaS04lCrqzMkPoz04i3aimFC3FxHDCitXxGBWTTXYVlW3wZVkEvnk/Y9ei2JGvqAX5z1kZXR4rK6//M8RhEqSZrWt/zfnbTetY8y7r+sdnEEER0/8Q9j058prYKnBhYTkgNHTyTljCRwHF0u0Sic7w4rXWeZbRGRdEBniUht0VFbhVyK3n/A0E2fIaG7bhgTimkMv5s6WNz5jmpF0QdI+wBpHmLdh54ivpBwUY/DOAOdwvwYIWGqvhIHDRWml9LnrMr3c/BRpU+bWmxsTe6bW1gwXCXelDwQiryAVnfAUzHfQXnUOgFL4aNS8TEDsPCYF X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(39850400004)(346002)(396003)(376002)(5660300002)(31696002)(86362001)(186003)(2616005)(7416002)(38100700002)(54906003)(8936002)(83380400001)(8676002)(66556008)(66946007)(4326008)(66476007)(41300700001)(2906002)(6486002)(26005)(478600001)(6506007)(53546011)(316002)(6512007)(31686004)(36756003)(6916009)(4290200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eXAvZlVOd2ZNK3FoSmdNQVdDbDhBSDU4ZnpSdkZEcFRiYmRXcEtZY2lvYmd4?= =?utf-8?B?TW0rYUgvOG44ZElZcHhLSVgzUThuM1luR3Z3OUhwRHFkR3lYQ0F4VzVXTTR6?= =?utf-8?B?cUc2cU9wWWZCd2lYQzZFbVc4aDVQRmZnZnk4SkZ1WVhMem1DaFdtT0dqODNU?= =?utf-8?B?SzAwakxzVHd0SWRSb3YwUjNqOCtxb2kyaGl0VFZGeVZ5M3pXUUJHek5vSzI4?= =?utf-8?B?NDY0QUNremJYcndTcGRaSXJKWWdNc3RBZ1pDNDY0d0F3MW92UWxVRjNtQWY0?= =?utf-8?B?VXd6eEI5ZVQzcTFBeEdrQ25FOVdha1N5eDEzNXZWeFE0c2wrc1NvdGFOREFM?= =?utf-8?B?bzljQnhJNmlySGtiTW1HTC9yMlZ0N2JmL09peUtyVUFCNm14dDJ0cnBXVFB0?= =?utf-8?B?aVgzSE1CSVpxUis3SDZ5cE5CYkIyNzZDUnJFSEYzM2dOODRsQXNPR3FHRCtN?= =?utf-8?B?YzBIZk55dmhjVkUvOC9sSDRUZS9BUjBKaTI2Zmw2UlJWclBhZFo4cGpSeGpI?= =?utf-8?B?b2lTWmJrQ3ovYmNjL01INGRockhoeTEzM0laUmVRZVZ2RXRVN1Fac3pQWnpH?= =?utf-8?B?UlBpeEZKVUdzSGRaUlFneDMrSW1vMUI4amwyT0lhK3laVHpjM1BQdWJJa1FC?= =?utf-8?B?N2JPdjFycXhXM1NQNVk2dGwyZExjWVQxMHFpOHp3Uis0Q2pRQ2JLMExtdk1a?= =?utf-8?B?VlBNR3VWdldoZGp5WExxeVZHa3FmVnA5WklhdnhUY1RVbW90VUdyUzNBNDJW?= =?utf-8?B?R0FKMmdGS3lpR0pra0xpeDFSc0FhWUdkZEk4cWFHaGh4bWNOYTFLa0RHbVBl?= =?utf-8?B?WnFMaXVuNHBKV0hSSmZHWkMwdDlwOVNUNjNIVG45bTVGYmVHTUpDd2x4WEFz?= =?utf-8?B?L1FHTzdISHF0a2xvdlV3QW8vdlR2YzZDOEpGRVFwSUhoN2pveEtqZFNTdGF0?= =?utf-8?B?aTJUUFpSNzBKOVROeUJnNHZDUC9Sd0ZoYWZwd3haS0psNTd4L0s5NFdnVFVB?= =?utf-8?B?NkViYy82dERQS2FsdVVYMWJxa2xzR2xIbzZqeGs0a04vb2xqaW5LMXdNMk0w?= =?utf-8?B?MllpSkNTZ0pmb09hc2pOL3Q0aHRGRTBzalZtMVJkK2lHbjd0eFJNVTdNREY5?= =?utf-8?B?dFNubGJsRVhiQXlzOEJQYXFEQkg3aTN3VG1ZL1IvT3hMeGZ4bHdRWUFmMDYv?= =?utf-8?B?eStBak96Vld0N2dXcHE5S3VhM242UTVPRnloUjZTZmJRTGQ3RnBNOG1ZUWZC?= =?utf-8?B?Z3NTTzZFT0hOUjR4NTdCdjRLT0VZS2FTaVc0TGlCejhQbTJhY0pRT3lyZXlj?= =?utf-8?B?a0w2Yll4RVhKYkg5NXZobUZCWU50OERId0xFcitpSFZNLyt2dDllaEpIcysy?= =?utf-8?B?M1YzMTM4Q1ppbXRJbzBpMm5ubVNXZGpoZjVaVmM3TVBOVGhSZjNZUG1xcGRC?= =?utf-8?B?VHZYLzRwc0Vyc1Nnd0VoMlZZcm1pdVRTbjJjN2wxKysxSytYOFRDYmNkRkNK?= =?utf-8?B?cFBvWlBsZk5qU3lZZ0kyL2c0WHBHL1RUSE1jTVhZb2NKUENPRUt1MW5zeEhO?= =?utf-8?B?eGxVMHJnd2hjc1YyK0NXeC9zOXhyODRFNXR2SW0zTWt0cmZRS2JJMFJuenpx?= =?utf-8?B?Nlgva2wyUndtRVN0MHRyMmNmZmhoR0Z2Q09kTkZVamVRZDFRTjhCdElrdkJF?= =?utf-8?B?WUkzMWNuZ3ZQZ3dmS0IxcXptb3loaFdoSTYraGpDc1ZDQ2JpZnlRcmN1N01q?= =?utf-8?B?aEgydnZnL2ZjZlFoY0xMOUczY3hWVm9FUDUxUVNuVWlRck5sbmx4ZEFIYm9L?= =?utf-8?B?a0lxbEVBTHJNaitFZ0VNNVJMczZwOUpOcVp5TkJ3SlBhYWEyWGswbWEvQzkx?= =?utf-8?B?NnhiUzF6WDkxS1VVU1JMd0dDZ1Ztank3di9aMThjYS9zL09NbFBQUVJ0MTBE?= =?utf-8?B?MlVST3lWUFluakpFTjVjemNEcFgydjZ3SGlwR2xpcXgzcnlLdFZIRS9oS0sx?= =?utf-8?B?ZG5YOEx3NGZlL0t6ckM4QmVwV3lsQVhOUTVPN0V6TWpnS0tkUzlQN1ZDek92?= =?utf-8?B?UjFFMjgvbHVnNXF1aTJiUWhjZHFmaENHWjVwanlWM3VnalhWR1dqMVpEWUVM?= =?utf-8?Q?qKE+JCAZAfAEju4cH7WTkvmwm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5622d46b-53d4-4ba4-9f8f-08da68a2ca4e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:49:21.5581 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kw5Ay9pZrP7zRuxZeMIKjn1qi4P/kbrLNmHjXZy+RMmP+WUQTOMxPRdatfKuGRGNRGyHjhCeSnGjJvQFSORVNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5209 On 18.07.2022 11:31, Andrew Cooper wrote: > On 18/07/2022 10:11, Jan Beulich wrote: >> On 15.07.2022 15:26, Andrew Cooper wrote: >>> --- a/xen/tools/check-endbr.sh >>> +++ b/xen/tools/check-endbr.sh >>> @@ -61,19 +61,36 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & >>> # the lower bits, rounding integers to the nearest 4k. >>> # >>> # Instead, use the fact that Xen's .text is within a 1G aligned region, and >>> -# split the VMA in half so AWK's numeric addition is only working on 32 bit >>> -# numbers, which don't lose precision. >>> +# split the VMA so AWK's numeric addition is only working on <32 bit >>> +# numbers, which don't lose precision. (See point 5) >>> # >>> # 4) MAWK doesn't support plain hex constants (an optional part of the POSIX >>> # spec), and GAWK and MAWK can't agree on how to work with hex constants in >>> # a string. Use the shell to convert $vma_lo to decimal before passing to >>> # AWK. >>> # >>> +# 5) Point 4 isn't fully portable. POSIX only requires that $((0xN)) be >>> +# evaluated as long, which in 32bit shells turns negative if bit 31 of the >>> +# VMA is set. AWK then interprets this negative number as a double before >>> +# adding the offsets from the binary grep. >>> +# >>> +# Instead of doing an 8/8 split with vma_hi/lo, do a 9/7 split. >>> +# >>> +# The consequence of this is that for all offsets, $vma_lo + offset needs >>> +# to be less that 256M (i.e. 7 nibbles) so as to be successfully recombined >>> +# with the 9 nibbles of $vma_hi. This is fine; .text is at the start of a >>> +# 1G aligned region, and Xen is far far smaller than 256M, but leave safety >>> +# check nevertheless. >>> +# >>> eval $(${OBJDUMP} -j .text $1 -h | >>> - $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') >>> + $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 9), substr($4, 10, 16)}') >>> >>> ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN >>> >>> +bin_sz=$(stat -c '%s' $TEXT_BIN) >>> +[ "$bin_sz" -ge $(((1 << 28) - $vma_lo)) ] && >>> + { echo "$MSG_PFX Error: .text offsets can exceed 256M" >&2; exit 1; } >> ... s/can/cannot/ ? > > Why?  "Can" is correct here.  If the offsets can't exceed 256M, then > everything is good. Hmm, the wording then indeed is ambiguous. I read "can" as "are allowed to", when we mean "aren't allowed to". Maybe ".text is 256M or more in size"? If you mention "offsets", then I think the check should be based on actually observing an offset which is too large (which .text size alone doesn't guarantee will happen). Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 09:54:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 09:54:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369467.600892 (Exim 4.92) (envelope-from ) id 1oDNRz-0004dk-KJ; Mon, 18 Jul 2022 09:54:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369467.600892; Mon, 18 Jul 2022 09:54:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNRz-0004dd-HW; Mon, 18 Jul 2022 09:54:03 +0000 Received: by outflank-mailman (input) for mailman id 369467; Mon, 18 Jul 2022 09:54:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNRy-0004dX-Jn for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 09:54:02 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50079.outbound.protection.outlook.com [40.107.5.79]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8cb15c87-067f-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 11:54:01 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB6218.eurprd04.prod.outlook.com (2603:10a6:10:d0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 09:53:59 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 09:53:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8cb15c87-067f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ss2VFauA/15yjAKgmEh0cYLqrZL20RzVvDFoA+qmP/S7e1l+TrvEcrA7iBEkX2HfWzkhH8wt8sMbnuAODH8FQElHW9BxAQE75bxBq6DVJev4/wib0bsQuLfDluvX95tlA+8kXDFT9T7rmlPnWzjokMcHrauZxscSR+v0nQmjEuj3So5efOtdQCL0IZ62LYqSm5WigEM0PlRdWjqQ71H12YqelSL1cJV8mi2VKZT5wmm5S/o4WZk1y10j7B0S6U5Sr+soqRgFDOXhp4drfqYxLcQleZkhs7lfB6j2cy4Glbp2JGsXPaWOz6HuWNBzMoNMv+M4g9oHwm+TIRTteTc3uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/9xodgE5LBf9b1OcI6jGILzYQ/ZOc3DQVDTLo6B3ccM=; b=hSoWso2/wdPGS0wJAKB+famTqQhHLIrTgfQ51dF919q6w/Dxlc6zgkxVd1q/FwH/oFEb0FsuT/FtMCr++KsF6dehBPk/Zz6j8JKSSlmQEbyu9jmkUfzeHoPyTbtBXs3vBUa4tHqv1PS7KjBRKIb3gHqGscuk6RQwRuqYK05X/WXl7hXrh/HnGJIEbnDADoo8rxoIRCVaT+jo4h6Ueg8o3kiGjD0Dlh2I7MvTBzNzxNdf/ta76Purj05589q7piikFpLwL4Vsq431/ZAywlgJO7qbEUtEPjphOBslLyVZpfk0kI5G4Bf9ybSC7kH6B5Cg+p/K7ods9yPpiKbMDPpIeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/9xodgE5LBf9b1OcI6jGILzYQ/ZOc3DQVDTLo6B3ccM=; b=jheXQyU2ZLbE188hWtu+Aj6MwFIl0lrQ/FTPwrWnT5dM6IcwCuY/vgBRRs+y2W7HRzoy6EFcgl0QYhe8UBcxtHTeUbqcYKlykkeHgO/XHzumLriFsIHGNFAo/8uY3aK35iRy6dwSocKz9sE7KDKwwguwRtawXNgXM5ZN2W0nmeY0NWZYAxrUdxEDP1CaSa8uFwthuTIeSyM2JKbquM6eczXsDDLMmm9Vnt9KHRr3pQFIUa6U24oATdA5VS9kbueZgrsmGCc3wV7RU3lSTDWb5OWnxzSkQ7Lev68SCwctQvMU+KyAOtpzSRS58c2qQW7mP6Jb+Cfda5KA605BnEyzOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 11:53:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/5] xen/wait: Drop vestigial remnants of TRAP_regs_partial Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0064.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 275ac16f-4074-4ed6-0a04-08da68a36fea X-MS-TrafficTypeDiagnostic: DBBPR04MB6218:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u36OmBtBmTRURsgsKDFeSi17ykcjJPBzGnq2H0hHiE8rVelHfvGI0N7azOq2Vo8HwifqWU+i0oFmtIXqu+HF/oqQ34MXXWEaemZ/Ea/ZJWg1eVqbiQZ0C1FwrHQyTbuQ4fzLngUJEAMPPbHQe3HruTAJB8/t9QOi3A/fhbX+kzuuze0mGlcVD74O5XmmByTlIiHtUAmATZENQb6q4LyCmRj7InGXoAO8IBjqC9AaAFVCiYwRHaLigr/vwVi2hJHFnSSmD5JTin7+i4yhO5yJKfoRcNk1aJ2TBSpLggiXxrKcF2rr4Gw69i3kit9rd0YcQNaOwFJp3KU8x0wuDZ5ackwCcdR5FQViX7DbtNovEcVaoExMYDtceEL1hxDd0N7G7e8RN0CAhQEr6b29hrHvVlcMJGi0QMRjZTRNhJeBtbbGHaqMRoShgvduSSeKsRlkaLozby7A43/Jl8qRwelokoWk9utidId84yyNX2KBD9q7hZq9k4a6RoPCEx29NaZmQg4Q+JTeoG8Z/vhausuMGDWglcjUrqBNaoS7e5g6lrTvgxGWgLYTJu5q/koK3DRBYGLTzmpjMputv9x5x9DoDLCuAkD6N/341uI6fLT7+hYiU3GUJ9/yrFUjHpyzhKyFxc0OrCYf6FW+1IJKJYw0kO9mBrTuDMI5Gn4Lk2B8xKBmy5emGt/g92TUOFGYQAR5nx5PH6D1mhWGHv7T9D2LtShFsyj+euMItqX10tG6X6v7Mmjmvl9V/0dgQK2M+KaTakWgLlRQmj0u1VgCPm9dH4eaaL5JdH3Lz5N1gG6Sye1H1DR3vPm9ivvcTfN2VvSWgqL511yCHL8eVzQKE8cN6+HKm3cd9ixvh/fX+h4GQSw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(376002)(396003)(136003)(366004)(83380400001)(4744005)(26005)(186003)(6512007)(41300700001)(2906002)(86362001)(53546011)(6506007)(478600001)(6486002)(5660300002)(2616005)(8936002)(31696002)(38100700002)(316002)(6916009)(4326008)(54906003)(8676002)(66476007)(66946007)(36756003)(66556008)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UEFiM04rRWRidmhFVHZkWkZIc1FWeDlIWi9RZ2tHRUovODJFN1ZLb3ZqVUNv?= =?utf-8?B?aUVHdVJiUjdJc0UxTTBCTU9NRjErNWhUcDU1NHFXY2RsUktBTlREWHZHWnRO?= =?utf-8?B?OUd1WHFhTkdSTnRPaFk4NFg3elEvKzZiSklSRTlTKy9NQjZMK2hoZThxUFkw?= =?utf-8?B?NGRnQVJGOC9UTkVVUzBaYlgvaWQvNHNvUTR5RFdaODBESFFaNWJUTXhvb2JS?= =?utf-8?B?QXovUjlncWdseUxyekZhQlMvY3RSVVRYTHJwcGdVa2FhZDRoUDJsSTJieXJm?= =?utf-8?B?cWcwVHZCRHFBL0FCVUcwVHRhUldXVGZsSS9tZ3hQdjZCTHF1OUpiSEU5RG56?= =?utf-8?B?S3ZLdDFzbHdGanlmalJnN0llL1FiVzVZUFE1MkplZFZoeldQekRSZFhwaDVz?= =?utf-8?B?NlZxZ2cva2tkUEE4ZWVHL1hMR2lRMk84a3orZnVSMUhiMjhYNTUwWlhyWE5x?= =?utf-8?B?VHJjTmMzZmd2Zm9reXhrNE1vV3Y4QWVpOFRYR0xyUW95bFNtNFg5bFh1V1Zq?= =?utf-8?B?cXNnL1FTNUJkRUM1bklHcjdVdXBtVnpvSU02NXJSaU0rWUFrWHhQRXNmQmdO?= =?utf-8?B?MEVOUkdxMjlnMlQ0Ym5MS2tZSUtRVFBvZWpEMUhxMzZwcVFJcGcyL1NMWU55?= =?utf-8?B?ODcya3hNR3k1c3dtSkN3KzYzRGJGVmt0VXNCMndRU1NtbHJ0SFlya0doMmow?= =?utf-8?B?dmdlaU5Cdkp6WSs0WEZYTndpSC9CS2pjMXFEZUE3MEptcUtUNTh6Y1ZXY3JW?= =?utf-8?B?K21nWU5SdmRSTVpDM1U0eTJTSnZhZGVQWSt0aFh4L3BhV0ZFa3dmaklNZmZP?= =?utf-8?B?aGdiU1BuaW9lUEU0Zzh4c3ZLWFhvdmdPa2ludklIWTJtSUZsUlB1NnZ6SnYr?= =?utf-8?B?aTQ3dTZBZFRsNlQwMlZ0L3hsWTh6bGFyYmxuNWNLRm95WG5leTBHUEFrVDBY?= =?utf-8?B?dmx1MWVpSTRmWjl6YjdEbmdlaHVaVURYQm5oTFdEUkpaV2t2dG5oNEJubjdK?= =?utf-8?B?cVNHaE56Vk1Ya2Zvb04xQkRhcVZlOTB3Wnd1RFpmSEZCWldGUis4N3lkWVM5?= =?utf-8?B?Ly9ETVNxZDJ0MTdCdlhYTjJrenVhZ0d6cXFCOGRuNTRsaXVCUHhwVEk1ODd3?= =?utf-8?B?U1Y4b21rT0IrUzU2cFBoZjRFMzNhSFdtc1JxSlNnOEZvejNlUzVJc1dzVU94?= =?utf-8?B?Z3FiQjNneUJCVmRjeEpHVzMxRE1zcDY2UmR1M3g1eGlYVWpoRzk5dFdjckJ3?= =?utf-8?B?TTh6c2Y1YVlNVnBud1I4T0tSbCtOUkVGdk4wOUxHcVE4T0hQR2xmUzUxbHZx?= =?utf-8?B?TXZIVGlGMy9KTFA0aWxWZGRBcWJPQmVvOTVUbkZNUzFWM0s2NG41NjlGUEow?= =?utf-8?B?QWdBd2dyT2VrOXZaZjdTYlFrSXhXdHk0dHFTNzM5TWN1UHJ6M3Jzd3ppVTJy?= =?utf-8?B?MHdQRHg1VTlSYjJHOFl6Q2gxQnE2d0xUektBQ1FXQ1BFUkdvY3hlN01YcVBn?= =?utf-8?B?dFUyZytQVlJ5amkrZGlxWVNSaFd4V1llNWlMQkRHb2FYckxMeHVsNzFXK3NT?= =?utf-8?B?ejJUcTNPMmE4QUkycnZJYXo4YUVSWmxVUm5tOHdzV3I3Wi9LbUxFUXRrRDlR?= =?utf-8?B?L1BsYWZ3dFNRUnNoUzl5dWYxeDd4NVp4RkhNbkliZzJFM3M0OTFLS2xyQ2l3?= =?utf-8?B?T0lHMDlQdmc5cytOSlRvaGpkUmpQRndndzQ4QXJFdDI1ckVEOEdYWklrMXNN?= =?utf-8?B?dkVaT0xYTlhyQ1RvTXd1SXYzN0NoY0Y0UU5Fc2hsb0o4d1QxUWdiZjZzRXRt?= =?utf-8?B?dGNrRUVCYTlCQk8yemF0QnhTY3NlZElhWHAvV0ErdzhJSDBEOG92ZEhJOHRk?= =?utf-8?B?L3N0OXViOXY0czc3VVdpdjFNcVVuajAwUGdXclQ2WDlyK0xZbkdHZ1JNMzVB?= =?utf-8?B?RUp5WENBd3k2bU8wQmE1K2xXOWRZTURFOWIzOFN3QWkzS21QQ1JnU2NYejA5?= =?utf-8?B?QnprS2tLakNWNDdYZmMvVFFoVU9YRWduWHhhSFhyMUtzL0dnNGlGbldSMTVS?= =?utf-8?B?SkVuSTdCVzhEdDBqWkJlYW05OVpSb0lqTVdKMkVXM0lPd0ZwSHZzYlN0UVFE?= =?utf-8?Q?m7k5YA62mLKjVvZ2311hLKZb1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 275ac16f-4074-4ed6-0a04-08da68a36fea X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 09:53:59.4319 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oNfh52N83ImxEn5TD9obj4XLoO5lSHWo9CF1t5RhdaZCGIHwIV8H0HJVvzAVCo0ZshxhRG9VZNrrlxefcURYhw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6218 On 18.07.2022 09:18, Andrew Cooper wrote: > The preservation of entry_vector was introduced with ecf9846a6a20 ("x86: > save/restore only partial register state where possible") where > TRAP_regs_partial was introduced, but missed from f9eb74789af7 ("x86/entry: > Remove support for partial cpu_user_regs frames") where TRAP_regs_partial was > removed. > > Fixes: f9eb74789af7 ("x86/entry: Remove support for partial cpu_user_regs frames") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:00:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:00:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369475.600903 (Exim 4.92) (envelope-from ) id 1oDNY7-0006Iv-B5; Mon, 18 Jul 2022 10:00:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369475.600903; Mon, 18 Jul 2022 10:00:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNY7-0006Io-71; Mon, 18 Jul 2022 10:00:23 +0000 Received: by outflank-mailman (input) for mailman id 369475; Mon, 18 Jul 2022 10:00:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNY5-0006Ii-Nr for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:00:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2057.outbound.protection.outlook.com [40.107.21.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6ed3d946-0680-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:00:20 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR0402MB3584.eurprd04.prod.outlook.com (2603:10a6:803:a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:00:19 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:00:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ed3d946-0680-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XJlrxNSfDHw+VY+fQ4x5tYiRkRUonC+QApLypJglL+kvJDa5mQue4Z0U7fBZ5Bn7KQRvQcKnam4hkaEIEEFooroUdwHY0HP75Qm+JimyWSk23g54YJL0HJ4Sv6A7kd9hNmud+RLSPtIZiaeIPOB3aogvfeP6JbhQE1dkvyJ7e7OG+MXj01HZfKqzElm8hlrgri5KftlSMHELZmsVzV+G0TnnA+B/01n9K0xZr1rXcman44osg+2C1hqThi6/eSz/1cVNuXHIEfFXzMgyoW9u6bN3dFGBNWu7THCt07IC7uERhXn14+lBk+e8wNq2+UjdN/6ysYc616SfJN03jVio4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r6RRE/7vyec7TCnmbMoT+grO3CN/b298eviZj9dRqUU=; b=WWcnDLQvmdKJtlgt15DYtQRPTFdxL9Z3WxonsbwpmK9Y5xK1euM6dtUfGoJySG8GI1R82hw9tSofG01LIIyuKLP+mtF85s1NPmaLbDYIdLPYdewfbz6zJtJqF0vUIExm1uaS6+RnC6rszyJqxEdM6EhzL9bmf08cynNcMa5v3Hz/Qnz1p7l7QJs/6+yq+G7dFXYG5bYKJtt76GRpxaSWR7N2rnI2rSlM+8cnjmwsMqC/8TNOD6LTg6Edj8dF8pr2UfKWIdGe33rJPJzdQEnC75iQs1dOvcWsNGmTCFfM2xiG0aQEYuf5sk2w+Qqtf/eUtaw9SGYF2OXzkCgNaRiD5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r6RRE/7vyec7TCnmbMoT+grO3CN/b298eviZj9dRqUU=; b=SxLI49Yt9iktw8E+zApvFXPuRZF+HXp0pCbxKQvd3Eywa76rTAeISDVnpcQFrpoxHnXcd6nJzjPIMnOcJZ+g/2d+qjW3EtfbLCT9yingGeNAEaNXqVFRt1ruD29ez8yPrHEpxaxLoS2sJ/ybzMMos3FElY1zEtrc7YwtNPQxGjsY8RAf2y8nHp6kCEovYzVS6OlKurmRinUBUtswJsfbpBfrkNloeJj9bjzzbI+hdoPxuk7THtD/V5x6MxYm1GNyhNbevIYN7DvIFXAd4whChK3UVkUOsbogpzSM+t9EpHlnN1jhdgFpsiOfG0mq0lfDWVVw9dbjGNZPxWZfTnzV+w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40b1ab24-5e94-ea2b-c9cc-6efa5418d283@suse.com> Date: Mon, 18 Jul 2022 12:00:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d65cadc1-e7ca-43a9-cde9-08da68a45227 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3584:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QKV8HXsZP7qD8QKjEYzPPaR/jq2xgrQwQxBHCXU159DGzmanmE1Up2Gitx2Ec9//eJwjBnzCso1kAGMKwpJl4DxdZ3L02ZeA5hRkLTqCPFkV8ls23qePRCnCjYEDYm1s4UHiEk4etPid0nNwFgkzdhyFmI6q+PXCOeEd3DW1is2WPNenBjg5rKZkCKpqo/1RvGljr2IOZlQuriSh8uvkMe0Or9z0Lu2qFTT6XDKzbH1zQda4aO1B00pAX5vmn1H0n0fUK803T0B43Inw3CHmJf3RXC0eja4CPFXVDFsTfEemHwoB5RNrNEI+ktfVeDI1eCyv95XL2pkE0GrBTN2YXV3QKwFdr7rXMw6e7Ovg6BhpTwSQ0hQt/1Vk6LC+RmBzoohmNEK9y0hZ7Axtbc8irSc0hKnAlnMKA315bBzcw5J4ybuiLXC3+q7TrRc70cjGujfYlRT1CIrnCAHslchalrOX9NAkIlnLAGibxbNYmeNu24rw5IE8gHCR99bV6t1MDv/wFuxC1PcwgnJXRHpFk7UAYFqu90/78XDSoFnCVRqR3XK5oNaqC54f64tKDBkdA+hGOJZEVf6reipJaApDkuWbChPft+e+PZS7PHjD8/Yxd5vqPMBFNNibwcY22tn6McgzilH46mJyRLn2tWLzHr8jdKsCDMtCKEzAHT4KfQLk0quZq4yQSgLpdg4ADp29F0PdrLgTZILmqfTtJ80vaajLnDkmneqXd664w8PUlDLPSq0LYuXVc0zcPPrxtlqr0GwkxKkMY8Q/+QAIEpwNp3x9YS532Fgzb9N6RrbwRUoAlWBNYaQta80xrRg2p7NizT9TS0J+jUHwZS6K31vuJQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(39850400004)(396003)(136003)(366004)(66946007)(2616005)(478600001)(41300700001)(6486002)(186003)(83380400001)(36756003)(31686004)(8676002)(4326008)(66476007)(66556008)(54906003)(6916009)(316002)(86362001)(8936002)(5660300002)(2906002)(31696002)(6512007)(38100700002)(53546011)(6506007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Rm9jc2lCTzdkRDV1UDlUeGx1cDhzbEJweEtuaFBFbU9KMHQ2NFlPRlZsb3Za?= =?utf-8?B?SmU0WkxXbllUNGIyTVcxeXVCZktOa0xDUVhNS1g5cUtIQnY4bjFIdnpFTmFD?= =?utf-8?B?T3FlNitJZERWN0cwZmpmTWhVT080Y1RjZ01MNDBVUGlwT1E3QmxYOVRWeVJn?= =?utf-8?B?Nlh2T0VmajhiRXRPSE1uNnFmOXFFeGtxSmY2NVh1emFsamtQWVByUWJ3d0gz?= =?utf-8?B?RUYvTWh3K0tCV1BzdDFteU5mVkl4RUp4akdJeXVva2ZPSWFvR2FtbkFxTVdP?= =?utf-8?B?YWY5YWxEdzhiZTJ2R2plZTdGZVpmVlFGYWRaMytwNk9TcTlucW1lQ05RY2My?= =?utf-8?B?dnN4L1dacWgweUFVZ0FxcHlLWDlXTjhienNpY3ZWRE9RV0JDVS9lTFAxSTc3?= =?utf-8?B?UWNCa3ZHT09MRDlxc0lWOTlGUUZjRTR3MUd1SWs1aGo3bE9jblcxcEhNN2lk?= =?utf-8?B?andQWVZSV21ZeWVnZldvZlpPZGlhOWZRRk4xWEFIcGsycjlnQTZmZjhsRzhw?= =?utf-8?B?WHJkKzJjZlVVYXp5NFhvSmcrTEE3S2R4ZkxySVFZZWhMRndQbGtBN29KYlJy?= =?utf-8?B?ZG93MThjUlBoVmlaWE9FSEZvOEREdHNKaStHejFxeWJWRzBEUlgvV2tLam1i?= =?utf-8?B?YURxbDQ5bnJWVmNiUUpqbkhUTytOSVJJL0MydmZSN0YwbUtGaGRzRm8xUlg0?= =?utf-8?B?TUlaRFhKM3JuNkN0MlBveWZlYUhLZVlJYlR2Zm9Tem05TGNvNGdrbGVNZlVF?= =?utf-8?B?YnVRSVowWVQ3c21ZRS9keWxiNmRiZjVTRjh2VDIrZk9TRHVTbVQ4WFRiSnpL?= =?utf-8?B?Z09NZ3dsTGJQS1FDMmprNVdiRit4QUtyams5cjE1ajhsbVBxcEhYdjZRdHF5?= =?utf-8?B?WEloL3NRZi8xZ2ViM0VWQTZEZkNlZVV2N0Q5azlpR0xUY0Z1ZEE0a3p5VFZW?= =?utf-8?B?MjVvSEt2VVp1cW1aVjFweERzQ01RNTNnVURPLzFmQWNXU0YrcXFTSEo3T0xD?= =?utf-8?B?RGZuQkNEcXpxSHdod3VKM2ptQURadnJOOTUvTTVVd0hWd1YzdWhLSklzczRa?= =?utf-8?B?bEMrTm1BQ09mZlk2djdRMHcwY2xuakxsdHhhNmt6ZmpJRCtaVTRJa1MxZFlB?= =?utf-8?B?TmZrR1FQN2ZtR2NVT1pXUG1JNGFiQXR5SFVsZDkyS0NpL2ZUZjBYVkdDSmQr?= =?utf-8?B?S2xySnJQaUJhQktZV1Rubi8rZXZyblBlSW9tQkxFU2Q1djFwZjFDNkRQQkxt?= =?utf-8?B?ekxKd0U2Rk9xR2tiQ2hUUWwreTM3RzhnbzZrOEEvM1NrUDRZb0JGVldPN3di?= =?utf-8?B?c0tGajg1UE5OK1kxTUZBQnRObXVlR2M2aGVObWxCV1MxYkdXOW43WU5YZDJC?= =?utf-8?B?bmNaNExIbk4zWmFtOGRoWkZQYmV4RTNGaFBQeTBLeDUrV1RzRUR0eHhRSG5F?= =?utf-8?B?VDE1UVBaTXVNeDk0MXJ5YXMvWVVCVWtrTHZaN3hsSnlKZFJwbGF5bkR6dVd0?= =?utf-8?B?T0J0QUU3V0lWRTRrazRPVDVoblI5L2JpVG9IZ2FGRWFPR01wbUQybDJnYW4x?= =?utf-8?B?OGs1ank4eng2T210SnZINU0zbC95S1V4TlVHVEdFajM3d1g5aVFOUlVuZ1RZ?= =?utf-8?B?NTVXakEwdEtUaDlDNzc1RC9zeU9XU21NT1laem1hSGFic3lBYkJrSUdOZUlx?= =?utf-8?B?WllqK2FQbUVoakRpYzYrOWVvUGhDMytYaFVGMUs2aEhXNmt1bXFjZHFjc0ph?= =?utf-8?B?ZkM2b2RyRjRpN0E1bHplbDVOd29tRWZLQ0JUemc2aU1BMWh2MWRHazdIb05B?= =?utf-8?B?ejIwSmhzUVk3YWI5czU4dHkwNk40Q2hLd1FsNTlTMmpyRWhFaVMwUEpLclFw?= =?utf-8?B?a05ISGdUVjRzSGh0TG5RVEJtQk9HdXpndEczYjNMd3JWTDJ6RFV4bzRORzBZ?= =?utf-8?B?TTlxRHlKUDB0Vk9xeWtzbnpZSHZrMzI1VmZyQWVQMVEySmVwSjkvOC9mRXI1?= =?utf-8?B?VnM2TDgzc0p5aW4rUm0rcFhMVkp1cmtXTDJpcS9tMVhMdDQwK0FJaGVVTzBI?= =?utf-8?B?NlRoeWt6eEFLbllYTThHbVdWQmRtR1NMcGNaRm1rQ1Q1bEpoMi9ZT3VKcGM5?= =?utf-8?Q?ln5cZ0bTEkXjVkJ+CXJCHiCPN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d65cadc1-e7ca-43a9-cde9-08da68a45227 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:00:18.9705 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /QXqoZNtZjYQSm7tFIVXUS3sEp5EAZxI6V5dnwRQysWEWCzx9CRjIIfKJTUbomAcUUQt+qFabBn/u/jW2oMmww== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3584 On 18.07.2022 09:18, Andrew Cooper wrote: > @@ -199,9 +211,18 @@ void check_wakeup_from_wait(void) > } > > /* > - * Hand-rolled longjmp(). Returns to __prepare_to_wait(), and lands on a > - * `rep movs` instruction. All other GPRs are restored from the stack, so > - * are available for use here. > + * Hand-rolled longjmp(). > + * > + * check_wakeup_from_wait() is always called with a shallow stack, > + * immediately after the vCPU has been rescheduled. > + * > + * Adjust %rsp to be the correct depth for the (deeper) stack we want to > + * restore, then prepare %rsi, %rdi and %rcx such that when we intercept > + * the rep movs in __prepare_to_wait(), it copies from wqv->stack over the > + * active stack. I'm struggling with the use of "intercept" here, but I guess that's just because I'm not a native speaker. > + * All other GPRs are available for use; they're either restored from > + * wqv->stack or explicitly clobbered. You talking of "other GPRs" - there aren't any which are explicitly clobbered. It's only the previously named ones which are. Hence I'd like to ask that the respective parts of the sentence be dropped. Then Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:05:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:05:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369481.600914 (Exim 4.92) (envelope-from ) id 1oDNcZ-0006vl-S2; Mon, 18 Jul 2022 10:04:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369481.600914; Mon, 18 Jul 2022 10:04:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNcZ-0006ve-Oy; Mon, 18 Jul 2022 10:04:59 +0000 Received: by outflank-mailman (input) for mailman id 369481; Mon, 18 Jul 2022 10:04:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNcY-0006vY-HY for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:04:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140048.outbound.protection.outlook.com [40.107.14.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 13c09431-0681-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:04:57 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS8PR04MB7685.eurprd04.prod.outlook.com (2603:10a6:20b:29c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.22; Mon, 18 Jul 2022 10:04:55 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:04:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13c09431-0681-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEhzMzO+KsbC3me/t2TqhTbSavDu85LmJF/ivsKqknZxZu4yMMj08TLb+GdrRYN2/XpFg3wj1ep7Eg5UvkliU/vrbzPdCJi3IoIlr61sl2k4xN50jHa1uu3Pp083y4arTGtOnHCc9W4mbn0X15SHsQuQZrw4y2PCPgfk3yz4fPhvksgDUBCDNLUeQFk0X0NWbqnx4pe/iMQJw5GFTu+N8K8MfRqHvZqrkhpRIHnRZGWYGdiEHDTfiRS0x3eNESvcRXlwSOB+eFTwnJx27bSSUDR9AFvPzgNGDtxNiz+WtS7SmU9FRP9kVI+MveK/r2aIlMRuQP1Szj4i3u8Sj9I2Qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=00tc1BLgrNjZqmg52bXLTNx+98YBiFDFO9AhKU7PAIk=; b=ISAcDm8tV+Ftd1TkvqGeQs5sbO42ExS65zb2YTQJEhjL9GEc7W8KAwgzcVIQ6sUm6b556FA0HMFDzTcruvAxIREXjJEloJXCO3DWwKbhpmQfhIs235ggK6+4TGvzM8sE8GFuXdzBPbTtpmwNBsbaTyq0PXkhYq7EdMdptWAw0KqCw5bmkU8Ocv1wVI8ZYeOsK8EQZrkAduIxM9dzsxq1yiyPikqqOUfTRhZKmw6Z5yIJG+ckFORNN4zHCrsJjTlU9Krb91to5EkiJZMcln+Wkyi41qJXSPXgUHE5FArHEtEcT8tFxfTZMotQoNdoEd24W6hktwlXvrleiUrbJcWpAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=00tc1BLgrNjZqmg52bXLTNx+98YBiFDFO9AhKU7PAIk=; b=FyNGRJprxe3n1MeWiUtIIuMvvl+eXpPlYC6U7D+yCLZrBC5cP00sqSrq2F2ymbfr+/a1MacDdxjoAh3ox/9yvKd39yWRSLtwP4PGGMD2z8ZRcciLKmDzyC0OpmXDvaCVIAALY7zMaaD0W/MWglCWNyHoRod8VqoymxQtlb/I9TeT9A1ir9AhslZSQdaei9Ip6SrZuNUFvVVFX4Ep4sBh1zhsgpkB/YrIOLDk/UL6RoHnyzckyiv5CARjJWVSJR85ptHGPhNluyNGk6cBdGF8O5OmEJzO13qplc2zGMG1fA02ICk7wuSxwMA3xL3zItt8ZLuZDwNV9L9LG/ReaJoPwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <187166f8-1f38-a2f3-e6b7-d8dca587d945@suse.com> Date: Mon, 18 Jul 2022 12:04:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/5] xen/wait: Minor asm improvements Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0099.eurprd04.prod.outlook.com (2603:10a6:20b:31e::14) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9e049c7-38b5-43a2-c7e4-08da68a4f6c1 X-MS-TrafficTypeDiagnostic: AS8PR04MB7685:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cCyP43chqb3gsdrV2ILGwVzUAeZKDFUfKUzkMYPoaZb5LV2ch+oBkQ9YqfKhaIF9GwVlUP/sS9zrmW6NfsG7OXV9PXWn58B6brHA9DwAwU0rMDxp1mn1a0X6J/5V3D89PHwCDrw5j8GPlq4Yv9nHgTc4JD6wHMIF9rcy4Qc8s6H8TZPxqvBQ0UWIhQd2h3F++tgNNYVdx7LomGR8C+yxJ86SMM2j9rcqrxY6WVkp41y8nrnOrvNEic3+ZffCC9TvCcAQK84b+8MLWMMWiqvFGCqCvsMz3fSaAODrqVYSu/FfWopXrbuAOXXs7H7FQrWZJrC+l13leS9O0VgT11jXGwlydgUsPY5hk+rOZP3Z/+vEk5Gcp8a3QwJXBWWtm7AjesF/KM+jlCXa8NpFR05lElFuaRJRTRRNViLow9BY+wb4mAE3qxwaLhjwlwEKnN5KCfe3y6soprRwLQs9YglbwMXyJGty40OLyWo5G3ZXDTzVmJr/CAwH4OojgLIUjZn231fTk5M63ggat1Ea1ahfxh35BAodJ8wigb/tctpIu0kNdErmVmF/TUiUGvgdQRdqi3xPcHLQTyeY6tPrde2+LhHeCuj7tKuXsNvPXidOHZA6cxGJhnzlFnFPKGbXXnS4QvOP9tLH3/vUz+qQOnbb53UvlTl6xCy341jD+cK+uoik7S3UmViBGlP0HOp111By9pgjqM6YFPxwQXZV+cuayVAk0ht2IlQt9jacQep6iW0FpHZQhXBlscIUriJBdPqiUDcV7zoL3K6QiQT1gAqnNYec66CGOQMYh9xlL2fVCFiVR43Mp5fXu5se0iz7jfA2p/qroZ5DW7xss9NeL+jE6A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(136003)(376002)(39860400002)(366004)(83380400001)(186003)(38100700002)(41300700001)(6506007)(53546011)(6512007)(8936002)(478600001)(54906003)(316002)(6916009)(6486002)(26005)(2906002)(2616005)(66556008)(31686004)(4326008)(8676002)(5660300002)(31696002)(86362001)(66476007)(66946007)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUZtbUFSSFZ5ZGpKc0Q3NitHYWNUejkxbTVYdml3SWZtOElnWm92L2lWaGVt?= =?utf-8?B?WmdoMHJFZ21BdnNuaVg5R0R4YVJ6Y3dDMWJpcEZ4c2Y1dk5EU1oyNWZKejBn?= =?utf-8?B?UWdPMjRtVUQxMys3T2pPd1hKR3ZGdi8xZ0JwSVV1WDY1MGZObktYVnBQY1Bt?= =?utf-8?B?ZE0xcTRsNG5LelVoc21Cc2tUVnZhcEhoWlNqWVNLZU1GK2RLS3E1NGRocGM5?= =?utf-8?B?NGtrWWMzU0gzMVV0cXlxNjJ3SmMzYTV6NDBYLzlSZHFoMlQ2bW1wMi9qZzVP?= =?utf-8?B?cVNRSjBCbXhaY2JwMEEzVTc4ZzJMYk0yV2xvWWZuYWF2MEFTKzBGSlA5OSt2?= =?utf-8?B?c0VFRGswN0VGbXpPS0wyV25iSjZXWndmd0xmcWZWZUlHVDlpZDArMWd5RjZ6?= =?utf-8?B?ZEJHZzYzVk5lZENFeEU4NEJOaEM5VnRGTy84TmlJb0Q3aWZmRHhzbHBSOWIx?= =?utf-8?B?WmtSdXhiVEFtRVNiVk9KVGpkeGorOVk3bURsT3UvZ1l4Tmc2Y2UwU3VYWFBN?= =?utf-8?B?ZDk1UDJOaEFQMzQwdDMzZ0lVdXh1MmlkbEhrTmlTTXVFYzRzNkI5WVlXQlZZ?= =?utf-8?B?d2dJUjRhQ3diajA2M28vYytHRERvRTB2TXdXN2tJNmZnZjBIRGRNSGhQK3M2?= =?utf-8?B?MnI3Z281cWh5ZjlwSm9DRllSaTA4a3VINEY3WUFGRVNGdTFZZllqY2ZUa1dJ?= =?utf-8?B?MzU1cXltbkZmQlIzUUZ4bVVRMHR4SVdSSC92TkR6dVJnSEc5ZTNpVVJrdXBT?= =?utf-8?B?dndacUZJSjMwb1B0UmkzQjNGSE4wUDhrMWZUYmFlbWdHdElLY0pjcjZQVGpR?= =?utf-8?B?ejBoQWF3aTVINGxqR3IrbFEyZUxHZHIxSjhoalJMRWcyK1JWRlZNOUNxbHcx?= =?utf-8?B?UnJEUUx1QXpkZm5ZMHMwd3hFQnlBWjJyQVAxbnpOTXhQNTBMaGpaSWhEU0F4?= =?utf-8?B?dHBHT3JqUGJzZWNYMVNHZzl2NWRDVzl2ZUdPNmYzbXp1QmdIVVNlREllM25i?= =?utf-8?B?ZGw0UDhXZzBsbVNVRVJ5QWl2Zm4rMEV6N3prZXBJa1FqMjNzcWFnTmkxTlBK?= =?utf-8?B?cjVTeHliUjFpNWY1djczSE1MdFRDakVxeno1ZHgvOGVCRWhIZGswWi8zT3Bo?= =?utf-8?B?UWtXRFBMbzVGTHVoeVRzVkUwOFNLL2ZwWnkvZWhQbTZIMkpvdEpOMXRjK2Q1?= =?utf-8?B?NHpuYkFrZTJXREpFM25Va3lJcjh2NkFqYU8zUDdQeVVmWUIxczN1UGdSSno0?= =?utf-8?B?M3Bzc0RaQ2ZIY2hMZTNSc1p3ODRXZTFiT0ZOV1p1bWFjT2xGdHhrbXJlVjM1?= =?utf-8?B?cEVjUUVFYWNja2VNajVuWk9NUWlYVmVxRnM3MWZlVk1NSEZTRThSbEZhcSs2?= =?utf-8?B?U0hGcXlobytSbndaNDRFQ3puUWdZY09xWnBzNCt2dGJBRnV1dDBkdlVuTGxT?= =?utf-8?B?VTMvSHlGdUM5Y2U4RnZ2OElVQnZLWGFHQVZIUFpZZWdteGRmZHhMaUdITkZG?= =?utf-8?B?SzZFMklVNWpDRWhLR01DWThsZGRPSUxVeXJ5NXp5cHNRRHQ2dGhLMkR6MFoz?= =?utf-8?B?L2MxMGlJNTF6NEhUZG95dHlWUzVnQVJBTWN1Y3VVSnZtdVNscTNxK0tabkds?= =?utf-8?B?bUtUZ1FwcGwyamU4TUxwWVF2Unpmei83NzJ6emFFdFBZK0VSSVFYNDJDS0lv?= =?utf-8?B?K2U2cS8rek9rcE9Ma3N5MURNeDZSRnlLQ2NmM0o2bm95cWV3L20va0duN0Ny?= =?utf-8?B?cUo0WlBNellLUk83RmZGM3A3RTEzbGdvQ0dEZ2wzYWRyWnl0N05YZXpvdCs0?= =?utf-8?B?cWlMQUFCTWwwN244NFp0bFd0MHpTc095dk9IbXRTblRLZDh0OFBJbk1WdkxC?= =?utf-8?B?VExWWFBwZzRveVVLbGorc1pUSzZMSHRZUU1YRTEzMWdteXB6NmQvbTdabFhW?= =?utf-8?B?bjRNTjRqTmVtTWJ4d0pLODF1L0ZvMHQ0NzNJRDc1NnJuS2p2Rjg0NHBpS3dz?= =?utf-8?B?YkpCUndJbDZKMVpGQWpuNVBPZG1wYnhodXp6dWoyRVVWL2lQZUI0NkhNMjc3?= =?utf-8?B?VVA2dmxxTTNBcElmN1lLakcrTVE4WTFhV1FVdUlETURlUHhIYmloRVRaOURk?= =?utf-8?Q?Cx0bZsBFdz10GT9DwnttQ6g4C?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9e049c7-38b5-43a2-c7e4-08da68a4f6c1 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:04:55.1416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HxzGBZytRiROktzmuHl4niZzGhg56Xr/xQSaUVBMboOXHEAMvjOMD7qNm1vIQyhzPl+DLX+vmAtgWZAJQBtajA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7685 On 18.07.2022 09:18, Andrew Cooper wrote: > --- a/xen/common/wait.c > +++ b/xen/common/wait.c > @@ -151,13 +151,12 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) > * copies in from wqv->stack over the active stack. > */ > asm volatile ( > - "push %%rax; push %%rbx; push %%rdx; push %%rbp;" > - "push %%r8; push %%r9; push %%r10; push %%r11;" > - "push %%r12; push %%r13; push %%r14; push %%r15;" > + "push %%rbx; push %%rbp; push %%r12;" > + "push %%r13; push %%r14; push %%r15;" > > "sub %%esp,%%ecx;" > - "cmp %3,%%ecx;" > - "ja .L_skip;" > + "cmp %[sz], %%ecx;" > + "ja .L_skip;" /* Bail if >4k */ > "mov %%rsp,%%rsi;" > > /* check_wakeup_from_wait() longjmp()'s to this point. */ > @@ -165,12 +164,12 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) > "mov %%rsp,%%rsi;" > > ".L_skip:" > - "pop %%r15; pop %%r14; pop %%r13; pop %%r12;" > - "pop %%r11; pop %%r10; pop %%r9; pop %%r8;" > - "pop %%rbp; pop %%rdx; pop %%rbx; pop %%rax" > + "pop %%r15; pop %%r14; pop %%r13;" > + "pop %%r12; pop %%rbp; pop %%rbx;" > : "=&S" (wqv->esp), "=&c" (dummy), "=&D" (dummy) > - : "i" (PAGE_SIZE), "0" (0), "1" (cpu_info), "2" (wqv->stack) > - : "memory" ); > + : "0" (0), "1" (cpu_info), "2" (wqv->stack), > + [sz] "i" (PAGE_SIZE) > + : "memory", "rax", "rdx", "r8", "r9", "r10", "r11" ); > > if ( unlikely(wqv->esp == 0) ) > { > @@ -224,11 +223,12 @@ void check_wakeup_from_wait(void) > * All other GPRs are available for use; they're either restored from > * wqv->stack or explicitly clobbered. > */ Ah, this is where the comment stops being misleading. I think it would be better if you had it correct there and adjusted it here. > - asm volatile ( > - "mov %1,%%"__OP"sp; jmp .L_wq_resume;" > - : : "S" (wqv->stack), "D" (wqv->esp), > - "c" ((char *)get_cpu_info() - (char *)wqv->esp) > - : "memory" ); > + asm volatile ( "mov %%rdi, %%rsp;" > + "jmp .L_wq_resume;" Minor remark: No need for trailing semicolons like this one. Anyway: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:05:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:05:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369487.600925 (Exim 4.92) (envelope-from ) id 1oDNd5-0007Ry-8V; Mon, 18 Jul 2022 10:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369487.600925; Mon, 18 Jul 2022 10:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNd5-0007Rr-5X; Mon, 18 Jul 2022 10:05:31 +0000 Received: by outflank-mailman (input) for mailman id 369487; Mon, 18 Jul 2022 10:05:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNd3-0007PM-Uz for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:05:29 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNd2-0003fw-Rd; Mon, 18 Jul 2022 10:05:28 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDNd2-0008Uv-Le; Mon, 18 Jul 2022 10:05:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dV+jasoKk3gC8wKgROH3pnd7QENC8d8zIdRedI6098A=; b=0VfQ4lflbavOMvCoL/aoFMI0xh CnxecszZ+Pk69NPSaj+kCnhavV1a8l/2p++A71bNFDSgWHnN9gaV+iD02evRaWsCLV7Sl6ngwUoNz pqdl4ljWyxlsopUd1NJWYFRnXQ9dMoE6Qgh8quXRgZCMGbyg1mNNo6gi7LJEpC1geSZ8=; Message-ID: <3c46a848-eac9-3dcb-80ae-3ceb7ea92402@xen.org> Date: Mon, 18 Jul 2022 11:05:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two To: Wei Chen , xen-devel@lists.xenproject.org Cc: Julien Grall , Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Wei Liu References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-3-julien@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 18/07/2022 09:18, Wei Chen wrote: >>   static void init_heap_pages( >>       struct page_info *pg, unsigned long nr_pages) >>   { >>       unsigned long i; >> -    bool idle_scrub = false; >> +    bool need_scrub = scrub_debug; >> > > You have changed idle_scrub to need_scrub, but haven't mentioned this > in commit log, and I also haven't found related discussion in v1. I > am very clear about this change. The meaning/use of the variable is now different. Before this patch, the variable was only indicating whether idle scrub was enabled (this is configurable by the admin). This was then or-ed with 'scrub_debug' when calling free_heap_pages(). With this patch, we now store the result of the or-ed in the local variable. This is not something I felt was necessary to mention in the commit message. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:08:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:08:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369495.600935 (Exim 4.92) (envelope-from ) id 1oDNgQ-0008M1-Nh; Mon, 18 Jul 2022 10:08:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369495.600935; Mon, 18 Jul 2022 10:08:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNgQ-0008Lu-Kv; Mon, 18 Jul 2022 10:08:58 +0000 Received: by outflank-mailman (input) for mailman id 369495; Mon, 18 Jul 2022 10:08:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNgP-0008Lo-E6 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:08:57 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNgM-0003j9-Fb; Mon, 18 Jul 2022 10:08:54 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDNgM-0000Gy-9w; Mon, 18 Jul 2022 10:08:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=gg/eIRBR+2729+QDn3Xu6pAoLH4/146HRGNk99x43K0=; b=oTkJIAk6HBHdfoSRbceft2zpvs 0UAEEk3lUvnD8yqmECo533fCwVkWHGpS6zOuVVkCKSvCnR/TkaUWp2OTUc4ByyGt9HFXppBA+6X23 ln0owUgxcsBUSVJqubJJ7M08cqkJBGoALzLbX05lM84LH3MGEg92iw9fAIqBHf3d6BM4=; Message-ID: Date: Mon, 18 Jul 2022 11:08:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two To: Jan Beulich Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-3-julien@xen.org> <07304aef-e278-9da9-ebd9-640ac7933268@suse.com> From: Julien Grall In-Reply-To: <07304aef-e278-9da9-ebd9-640ac7933268@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 18/07/2022 10:31, Jan Beulich wrote: > On 15.07.2022 19:03, Julien Grall wrote: >> From: Julien Grall >> >> At the moment, init_heap_pages() will call free_heap_pages() page >> by page. To reduce the time to initialize the heap, we will want >> to provide multiple pages at the same time. >> >> init_heap_pages() is now split in two parts: >> - init_heap_pages(): will break down the range in multiple set >> of contiguous pages. For now, the criteria is the pages should >> belong to the same NUMA node. >> - _init_heap_pages(): will initialize a set of pages belonging to >> the same NUMA node. In a follow-up patch, new requirements will >> be added (e.g. pages should belong to the same zone). For now the >> pages are still passed one by one to free_heap_pages(). >> >> Note that the comment before init_heap_pages() is heavily outdated and >> does not reflect the current code. So update it. >> >> This patch is a merge/rework of patches from David Woodhouse and >> Hongyan Xia. >> >> Signed-off-by: Julien Grall > > Reviewed-by: Jan Beulich Thanks. >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) >> } >> >> /* >> - * Hand the specified arbitrary page range to the specified heap zone >> - * checking the node_id of the previous page. If they differ and the >> - * latter is not on a MAX_ORDER boundary, then we reserve the page by >> - * not freeing it to the buddy allocator. >> + * This function should only be called with valid pages from the same NUMA >> + * node. >> */ >> +static void _init_heap_pages(const struct page_info *pg, >> + unsigned long nr_pages, >> + bool need_scrub) >> +{ >> + unsigned long s, e; >> + unsigned int nid = phys_to_nid(page_to_maddr(pg)); >> + >> + s = mfn_x(page_to_mfn(pg)); >> + e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); >> + if ( unlikely(!avail[nid]) ) >> + { >> + bool use_tail = IS_ALIGNED(s, 1UL << MAX_ORDER) && >> + (find_first_set_bit(e) <= find_first_set_bit(s)); >> + unsigned long n; >> + >> + n = init_node_heap(nid, s, nr_pages, &use_tail); >> + BUG_ON(n > nr_pages); >> + if ( use_tail ) >> + e -= n; >> + else >> + s += n; >> + } >> + >> + while ( s < e ) >> + { >> + free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); >> + s += 1UL; > > ... the more conventional s++ or ++s used here? I would prefer to keep using "s += 1UL" here because: * it will be replace with a proper order in the follow-up patch. So this is temporary. * one could argue that if I use "s++" then I should also switch to a for loop which would make sense here but not in the next patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:11:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:11:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369500.600947 (Exim 4.92) (envelope-from ) id 1oDNiw-0001IS-47; Mon, 18 Jul 2022 10:11:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369500.600947; Mon, 18 Jul 2022 10:11:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNiw-0001IL-1P; Mon, 18 Jul 2022 10:11:34 +0000 Received: by outflank-mailman (input) for mailman id 369500; Mon, 18 Jul 2022 10:11:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNiu-0001I9-H4 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:11:32 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd56e558-0681-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:11:30 +0200 (CEST) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 06:11:19 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5555.namprd03.prod.outlook.com (2603:10b6:208:29b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 10:11:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:11:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd56e558-0681-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658139090; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=zVxoY6IXl/6MojUYRI21I/D5pL0heFwimBj6noRG9w8=; b=PktPOOouGIrkC12dKooru+p1SkdBHapXFvBazL0gao8CpWQkNDnN0UF2 poEC42BOfG8I7hdnQgqavffYgUV0aLdSgtTbfn0MWku4Fu+eo5o3GIWk9 9kUzH5Zq+czfopinZeoQHs+YwAvcNWg+wawPWekTkBeiJMpp/qLtCO5UC Y=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 76452664 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Jhlip6nh8InNcrw94TNMO9Lo5gyYJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJLCG/VPf+KMDfyfdx3Poq/9U0B7ZfQzIA2SQFtriEwRCMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462t4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2ltHNNEp/hrBl1u2 sNbOSEmYSulov6plefTpulE3qzPLeHNFaZG4zRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAH7gvK/8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSzw27WRw3+TtIQ6RaL/+e5a20aqnEsKLBEaclC+kMiglRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4DOkS+AyLjK3O7G6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnop4thu3MCkRaGMHOykNSFJc58G5+d5pyBXSUtxkDai5yMXvHi39y CyLqy54gKgPickM1OOw+lWvby+Qm6UlhzUdvm3/Nl9JJCspDGJ5T+REMWTm0Ms= IronPort-HdrOrdr: A9a23:lsRCI6+qs3By1CPc7Lhuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76452664" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DV2PQIBSES6vy8jqxx15oIFPilrvMytjy8VC1+tg8bY3ke3Zq3N4kA4Z4HuoRE56Au64avqc4bj2dzaFglBEIezRz6tHJrb6aYBVf+fXnGbI7dTVK+RtWf3TkGgNDs6YUMfMlBm617ithM00/7OS0HthJmk+HLJcJbvHHCG6Lft41m8kDknHtWCOXNyDBptiRKl/PqSl/irPODsvEGqGKP19kR8JqM4Ee2XHC6llsBQ8L8IdMvYOMb0uo5lY5JDvF/AqypyehvObfZo/sbKHhd7JO+qrtXECjeV3ow1u1tK48RXsjqK9IknqXN+cdXfqcfFuR4uloWTqEJ3i7rjquw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zVxoY6IXl/6MojUYRI21I/D5pL0heFwimBj6noRG9w8=; b=B/g0H5YItiHtUCo67JvgP5tbVHJ9C3n7NyETuqKtAyaKOlHDssz3XEexAf1ZZRhlsJcHRwbgaiUGJmVTGHRedB+5GtyoKKdYvX7qKk+KqhuqUR8q9m+kU22E6qAJqP0S/sfF8vQjhYaFMTEW+QEXL9Jxf4LjFQJ7sIQUruKVTsXqBoWOIegmsg4S9hlsv7YdNXXIuC8hUUizDAAePwboj0mHr/UXoAeEHRVjk2TXjOa9AjDw992Fqz+p6ejA9UkoXd90WYo+JhZkPBMLmEhoc9lQHleBE8r0Pb5G09jUBZPP63SlOA38aC/8x6/kEYeX+3c8u8G2riZda5ml7XdXXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zVxoY6IXl/6MojUYRI21I/D5pL0heFwimBj6noRG9w8=; b=n6yl+42HXLYD3qaypW1nv9OtkWrqv97thje+OqSXMiK/oKCS3zE6n2RN8CUnivSjQD3zTolG8Dg8+SEe9pI1OdXiZMhPTSyFEhtHiCNCcbplmpBS6sCV3vq8E6CEkTT/TYd/l/N3vjdVWcVMc26t3L/DvULOeLzqaCCpFHyudPs= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Thread-Topic: [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Thread-Index: AQHYmnakh8+7xfqMQ0Kng4mRuadHxa2D5W+AgAADEgA= Date: Mon, 18 Jul 2022 10:11:16 +0000 Message-ID: <347aef21-e6e3-3ab3-f230-4e01339c742d@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-3-andrew.cooper3@citrix.com> <40b1ab24-5e94-ea2b-c9cc-6efa5418d283@suse.com> In-Reply-To: <40b1ab24-5e94-ea2b-c9cc-6efa5418d283@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 08812a67-df93-4d9a-3a76-08da68a5da59 x-ms-traffictypediagnostic: BLAPR03MB5555:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Z7Wz3gpcZM2Dpb8val7wVwRJlcMHOIM6oCSJeVlOWddEEQ5iTF1xvJhpBhY+3p03z41E+GBbwO/qyfSWILJTA9l5xFovtAa4Ty9pMatpZ7woEEvbP30SmglfizeM2fUWpOFA/2dN44fuRlJYip7Ck1Cn2/GJOnimpXxY1GezLyvLxs/X4h7QCkZM4hcgQ5sX7OBbMNmPPLVqVpXcTA/pFJq5gsNiJMgra/C4eE/MRscwNL70AmdSX0iNWVpzbrwh/rjPJrIPAqe+VRVqA7QO+wMg957PHmVls3y+TtjhuWnNGY0g8pqSi7u99S2X9Lmn+71/bAA33aG7MJt2tib21xtfWu/avGmFcAbt1H9J/cFm06msrU9dpUdeST5IEWDd0jWXflQIfHJqQQhTWN2Ldajx4DLBmZ81Iy0BKg1lyYSqRY9fPyo/9vsujdlEip8oDAklnLQ22n6J/vYjiruYQ3Kw4Unds7vdxitH0fsuhGXwe8CE4mywHPu6Ljy1f6T2p40sJafhQ85o6VEaKqLmqgXvRxmGMi+e0cMLSMGbPMNkx+45cw3x3W1+8QJuqxH82K5FKhyYEoyzmRhdBu3bJjvoXA3W0m0ThMNbqzA/OPGl0SebTaZgKE1tdUJ/ofkbcM7q6HiXSkYTYorqqas25ynKMWPT5CMJsjs+GTE4Nx2A0WkdVSGP//MdI8TDuj7xCenGA6g/Hga5hPrtDenC8dw3RazjfgZPQS9QmDfXQYflGMXDgHJAs963PCcCbcsJI+iHI3SLRZmWXe8qLAOyrDT18fTok0FQrRKr6Xr7PfXVnaAawJsjAw0dzQVPTLEmbrO6RnesYlSpu3U2FIfkgaC4dZ8OmhU8TSENXaLqWixNWswtZujQT5eI0foc7P9C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(396003)(346002)(136003)(316002)(91956017)(8936002)(86362001)(38100700002)(31696002)(82960400001)(76116006)(66446008)(66946007)(8676002)(4326008)(66556008)(6506007)(53546011)(83380400001)(38070700005)(5660300002)(54906003)(6916009)(186003)(64756008)(2616005)(6512007)(26005)(122000001)(478600001)(6486002)(2906002)(71200400001)(66476007)(36756003)(31686004)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?M1ZmWTBENmdNRVFnd0pRWGdVbjM5TVdhOVpFZnJva1pOZy9NVmVSRnhDT29C?= =?utf-8?B?MlZ6TTZiSjFSQllHRDFVUnFxOExYR0RybzNqMVI4bUt5ODBpWGRmaVhmb1Jo?= =?utf-8?B?b3ZDeXR3UHBPZWZwTTZNRTlQVCtNTVA3RFFyT0E5YTE5QlpObVBqdWZqTFR5?= =?utf-8?B?Mzd0WEZtNy9UTVMvZG1ENlFCcFU4WTdMdy8wRFZ0cHkyb1JoanhIQlFKRVFF?= =?utf-8?B?ck1CYlV1bW0xWTZBd2xrSXc4OWZ1VlhMSmZyZzF1ampNU043c2hscDlnUDZJ?= =?utf-8?B?ZlM4RmZ1UDJEekc3K1RJd1labmN4ckd2Q1o2Vkl1ZXZPakZjb1NaVWlWL3pk?= =?utf-8?B?djNnWjlXbnlTRkZsMU54VG1lRjhTbW9lUFA1R0N1ZjBTN0FxMGxJc1IwR3JO?= =?utf-8?B?akJZKzh4aHc2UWFucTBVNE5oOUpLNXhhbzBZYVpweFdtV252blJDQW54SkVo?= =?utf-8?B?Wm9rYUdnLzZZWEFLazlpTXAxOGhPM2ZUTzY3VzQrWWhRVjlpMVM0Y1R4SnZT?= =?utf-8?B?QWpFNFM5WFBlWXNvL2J3T2hGekxhM2hqbE8wRGc4ZWxOdXNud2w3amtzTlhq?= =?utf-8?B?U2RRMmV4alVYREw1bGQ1SmVBaUtQVU1JQ1hndENWeTRPdEt6QmFIZSt3Snh2?= =?utf-8?B?dnRsK2lha3N5VkZROXJLSHNXb0ZzZ3EvbjRoTEhHejRXUEdIWjNVbEN3dm1i?= =?utf-8?B?bEliT0RXaVpnS0tERUhuMU1kTmt1NVNlUWEyWHJQbzBVNUR5YUNiUUZaVnpT?= =?utf-8?B?QlNrY21VUUd2MUNoUThnUXoyWTFjNXRtY2RBcDNwNG1ldXBiYXlHbjA5Ymxw?= =?utf-8?B?aVg4K092MEJ1dGRHakN5WEZnRWlERHpuUGZXVjlBR0lNcnM2eTNjdnFpV2Vn?= =?utf-8?B?S2xFYmh3L09yekw4MitwZ2RPa25EK3JzV2VLcWtQbW1wQm13eUp5NjZ4SU9Z?= =?utf-8?B?c0VBTzZFZHRpSzl1ZGZYR0wwa1dmNlBCZnlHS2NkV0IzaDhJSHAzaHVnQzMx?= =?utf-8?B?alJZOU93R0VyMk1tcUQvTVc1dVZmZm9uK1lPUEdWVVBzd0NIcWYvRHJURWFF?= =?utf-8?B?K1pxVEhpT1dVdVRydlVGQ3FtL20wQ21WcGZYVmc4SWxUM0pVUG5LNk5YQXdm?= =?utf-8?B?dHVXQnpDMmwzdU5ieDBPdUVRUWhIU0xDdWdIVXVzYTZCVFpxTnUwdVJMSFZv?= =?utf-8?B?d1M1S05Da0xpL2RaS1pYcmc5Vm00VzFEbEplbnA4a0c0bXV2ZTJZZ1JQVHYw?= =?utf-8?B?QlBlQ1FkUSs0OWE2eFB2aUZLTGs1ellmTmtpdXEzYWVoeUNoNmJxUjcreUZw?= =?utf-8?B?SVJNd1JkSjNqWHJSZTlDMzVIa3E2TGk1Ujk0NkZvOWNsakNhakw3NUJnd1ow?= =?utf-8?B?U2FyREZHT1hlUllhVFVJbWl6MVd0NC9acXdsN0t1c0pHZXVUUGphdnFzUGlW?= =?utf-8?B?TjltN1k3NTcvYTltejZFTlUxdTNzYnZZQjN6MmFQODI3UkFHbExnU0ptZTdL?= =?utf-8?B?NkVWYW8yb0pSeXV3cVlDQUpqc3JhSmtiMmYwRVhvOW5PdDlZd2tROWM3NlNv?= =?utf-8?B?MmRrdGEwMThIVm9kQmNwMFhNelF5eW9YSDNyWnFHSmlBTjhZYkQzYmVIaHpl?= =?utf-8?B?SnBHMTY1bFFMRXBEQlB3QkkyVUZZNm9SU1BEaVBMNlhZR09zd3VmQWU5T2JM?= =?utf-8?B?YVhDVXFxQmdpemFTS1BZWElCbDNSeWRrMVllaFFmZnk0NGR5azRzVjViSngr?= =?utf-8?B?a1hPaHowQlJCUlpsOGJsUVd6dEJUN2o5R1pUMkJBV1NZZkZCQ1VEaGk1LytH?= =?utf-8?B?QWVRbmFQNUNiYVNiZzlhVzRqUHVaZTZkMW9kWklhSy9aWkl5cmJyZWFTcHIw?= =?utf-8?B?K05yMTI4dU9HTStKSmo1YllhdFRjR1RYeDdncGhpWXZMTkJmdkFLT0k1d2du?= =?utf-8?B?cDVjRzB5SjJwVURoc01HRkVLQTRhekxqdit1bGRSbWRsSkY4K2p2UnJpS1FN?= =?utf-8?B?Z09WREhlMDRSY0pkUjE2WnlIWU5Oa2psRW5oUzBYRkwyVjhhUFRZQzl6ck80?= =?utf-8?B?aEFlRlQ5akFmK2cyNkR6SytjSmFjSmZjaUYyMGVtVFNIeEZRd2xlcEdreVZH?= =?utf-8?Q?f3e4tXqGI2qaaFytqccoMnzyE?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08812a67-df93-4d9a-3a76-08da68a5da59 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 10:11:16.8051 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: b8YiimXkz+Pog/661bw62OzTAhB67Fi98MVX5i1jxwNpdD8VF7uwi/NhVPV+tErgY79Mr3dAQ0+bHTLkZ/tygEfNGPfnPnUDjjGENogawFM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5555 T24gMTgvMDcvMjAyMiAxMTowMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjA3LjIwMjIg MDk6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBAQCAtMTk5LDkgKzIxMSwxOCBAQCB2b2lk IGNoZWNrX3dha2V1cF9mcm9tX3dhaXQodm9pZCkNCj4+ICAgICAgfQ0KPj4gIA0KPj4gICAgICAv Kg0KPj4gLSAgICAgKiBIYW5kLXJvbGxlZCBsb25nam1wKCkuICBSZXR1cm5zIHRvIF9fcHJlcGFy ZV90b193YWl0KCksIGFuZCBsYW5kcyBvbiBhDQo+PiAtICAgICAqIGByZXAgbW92c2AgaW5zdHJ1 Y3Rpb24uICBBbGwgb3RoZXIgR1BScyBhcmUgcmVzdG9yZWQgZnJvbSB0aGUgc3RhY2ssIHNvDQo+ PiAtICAgICAqIGFyZSBhdmFpbGFibGUgZm9yIHVzZSBoZXJlLg0KPj4gKyAgICAgKiBIYW5kLXJv bGxlZCBsb25nam1wKCkuDQo+PiArICAgICAqDQo+PiArICAgICAqIGNoZWNrX3dha2V1cF9mcm9t X3dhaXQoKSBpcyBhbHdheXMgY2FsbGVkIHdpdGggYSBzaGFsbG93IHN0YWNrLA0KPj4gKyAgICAg KiBpbW1lZGlhdGVseSBhZnRlciB0aGUgdkNQVSBoYXMgYmVlbiByZXNjaGVkdWxlZC4NCj4+ICsg ICAgICoNCj4+ICsgICAgICogQWRqdXN0ICVyc3AgdG8gYmUgdGhlIGNvcnJlY3QgZGVwdGggZm9y IHRoZSAoZGVlcGVyKSBzdGFjayB3ZSB3YW50IHRvDQo+PiArICAgICAqIHJlc3RvcmUsIHRoZW4g cHJlcGFyZSAlcnNpLCAlcmRpIGFuZCAlcmN4IHN1Y2ggdGhhdCB3aGVuIHdlIGludGVyY2VwdA0K Pj4gKyAgICAgKiB0aGUgcmVwIG1vdnMgaW4gX19wcmVwYXJlX3RvX3dhaXQoKSwgaXQgY29waWVz IGZyb20gd3F2LT5zdGFjayBvdmVyIHRoZQ0KPj4gKyAgICAgKiBhY3RpdmUgc3RhY2suDQo+IEkn bSBzdHJ1Z2dsaW5nIHdpdGggdGhlIHVzZSBvZiAiaW50ZXJjZXB0IiBoZXJlLCBidXQgSSBndWVz cyB0aGF0J3MganVzdA0KPiBiZWNhdXNlIEknbSBub3QgYSBuYXRpdmUgc3BlYWtlci4NCg0KImlu dGVyY2VwdCIgaXMgdGhlIHNhbWUgdGVybWlub2xvZ3kgdXNlZCBpbiB0aGUgbWlkZGxlIG9mDQpf X3ByZXBhcmVfdG9fd2FpdCgpJ3MgYmxvY2suDQoNCkl0J3MgYmVjYXVzZSB3ZSBoYXZlIGEgd2Vp cmQgc2V0dXAgd2hlcmUgdGhpcyBpcyAobm93KSBhIG5vcmV0dXJuDQpmdW5jdGlvbiBtZXJnaW5n IGludG8gdGhlIG1pZGRsZSBvZiBhIGZ1bmN0aW9uIHdoaWNoIGFscmVhZHkgZXhlY3V0ZWQgb25j ZS4NCg0KSSdtIGhhcHB5IHRvIGNoYW5nZSBpdCBpZiBpdCdzIHVuY2xlYXIsIGJ1dCBJIGNhbid0 IHRoaW5rIG9mIGEgYmV0dGVyDQpkZXNjcmlwdGlvbi4NCg0KPj4gKyAgICAgKiBBbGwgb3RoZXIg R1BScyBhcmUgYXZhaWxhYmxlIGZvciB1c2U7IHRoZXkncmUgZWl0aGVyIHJlc3RvcmVkIGZyb20N Cj4+ICsgICAgICogd3F2LT5zdGFjayBvciBleHBsaWNpdGx5IGNsb2JiZXJlZC4NCj4gWW91IHRh bGtpbmcgb2YgIm90aGVyIEdQUnMiIC0gdGhlcmUgYXJlbid0IGFueSB3aGljaCBhcmUgZXhwbGlj aXRseQ0KPiBjbG9iYmVyZWQuIEl0J3Mgb25seSB0aGUgcHJldmlvdXNseSBuYW1lZCBvbmVzIHdo aWNoIGFyZS4gSGVuY2UgSSdkIGxpa2UNCj4gdG8gYXNrIHRoYXQgdGhlIHJlc3BlY3RpdmUgcGFy dHMgb2YgdGhlIHNlbnRlbmNlIGJlIGRyb3BwZWQuIFRoZW4NCj4gUmV2aWV3ZWQtYnk6IEphbiBC ZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KSXQgYmVjb21lcyB0cnVlIGluIHRoZSBuZXh0 IHBhdGNoLsKgIEknbGwgdHJ5IGFuZCBzaHVmZmxlIHRoaW5ncy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:25:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369517.600961 (Exim 4.92) (envelope-from ) id 1oDNw0-0002zU-BY; Mon, 18 Jul 2022 10:25:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369517.600961; Mon, 18 Jul 2022 10:25:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNw0-0002zN-8e; Mon, 18 Jul 2022 10:25:04 +0000 Received: by outflank-mailman (input) for mailman id 369517; Mon, 18 Jul 2022 10:25:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNvz-0002zH-7e for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:25:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNvw-00040O-4G; Mon, 18 Jul 2022 10:25:00 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDNvv-00013F-Td; Mon, 18 Jul 2022 10:25:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=RfLkMiU8Rc3aS7KcPMgPRlsIWsww1erp3QPFr18f9WY=; b=gucXQqQC1e7viY65H94J1K7UDj xzDcTkEf+WJgpaZgk6XdvOy5gwXwhaSPfHs0TtbFSsIus5T0c3YizYKEEh/nWx2HPpEU64oz/c3HK RGAx+BfpzqPHGytabbJ7i+JYhPkgh4hNvduj199CYhzgb+TFpGAI2JX83r87P2H0u8UQ=; Message-ID: Date: Mon, 18 Jul 2022 11:24:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> From: Julien Grall In-Reply-To: <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 18/07/2022 10:43, Jan Beulich wrote: > On 15.07.2022 19:03, Julien Grall wrote: >> @@ -1806,8 +1806,22 @@ static void _init_heap_pages(const struct page_info *pg, >> >> while ( s < e ) >> { >> - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); >> - s += 1UL; >> + /* >> + * For s == 0, we simply use the largest increment by checking the >> + * MSB of the region size. For s != 0, we also need to ensure that the >> + * chunk is properly sized to end at power-of-two alignment. We do this >> + * by checking the LSB of the start address and use its index as >> + * the increment. Both cases need to be guarded by MAX_ORDER. > > s/guarded/bounded/ ? > >> + * Note that the value of ffsl() and flsl() starts from 1 so we need >> + * to decrement it by 1. >> + */ >> + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); > > unsigned int, since ... MAX_ORDER, flsl(), ffsl() are both returning signed value. So inc_order should be 'int' to avoid any compilation issue. > >> + if ( s ) >> + inc_order = min(inc_order, ffsl(s) - 1); >> + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); > > ... that's what the function parameter says, and the value also can go > negative? AFAICT, none of the values are negative. But per above, if we use min() then the local variable should be 'int'. The two possible alternatives are: 1) Use min_t() 2) Update MAX_ORDER, flsl(), ffsl() to return an unsigned value The ideal would be #2 but it will require at least an extra patch and effort. If we use #1, then they use may become stale if we implement #2. So I would prefer to keep min(). That said, I would be open to use min_t() if you strongly prefer it. > Preferably with these adjustments > Reviewed-by: Jan Beulich Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:29:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:29:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369528.600971 (Exim 4.92) (envelope-from ) id 1oDNzx-0003mr-Ue; Mon, 18 Jul 2022 10:29:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369528.600971; Mon, 18 Jul 2022 10:29:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNzx-0003mk-Rk; Mon, 18 Jul 2022 10:29:09 +0000 Received: by outflank-mailman (input) for mailman id 369528; Mon, 18 Jul 2022 10:29:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDNzw-0003lX-7E for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:29:08 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30078.outbound.protection.outlook.com [40.107.3.78]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73d0abe4-0684-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:29:07 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB5232.eurprd04.prod.outlook.com (2603:10a6:803:54::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:29:05 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:29:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73d0abe4-0684-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ti6t73P2/CjceanZmRVgIMGz05LA06i4nHyrJR3QHCE8wXCg4VUGrKAxXdW1SGM3lFZDWDLvLMVC3zkIMKCXyryw/zibvNlhIuk9fktHQay14RdsBSZISgHxSLu7ZajsSAqGEVWlmRpVrIXLJN+k11K45wfqLzNwjLgNnwz4B4qjnl0lDO+gB6Q85RP4wvIcrfCmeb26ZZC2FltLHeCr5Uu2WniHV/LO1ZJzGwrC48VOk7ctB9egsVhYXs+/EH4/H07f/grHkquKGsPxwz8wxU8gA075E/ao/2rHLKwQWdUlEao4s1O+H6h5r31htIf1Gr3mF97KycjLdgkakXporQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gYg+CX1+LwQ1d/pqVZwdSTDwzHClvBRujya0hfw9N3M=; b=mKTeXig6ow7uWwBr+8g/GHwQ0986X2U3XLDC6cV/W/+V+ZED23S6sqDLYMzxzWoNudrKXVmp4IoG3uvLQzVA/Pd0O7G6jcj8jTENncnbk+qhGqu7Ft31gDI9+bAIvrvxwFD0ZpZzJt0gR8GUwGegEZrE0z4oFOUmzZcwVGU0VMF+dSjxX4OK0SyO1psIs52AibClDO5PA4vFcES6KS0NPSf++xxsgqoJN05ZP90PXKT63HmfnJiCQ/qXvwC+PDXAXUSo08hQk3ZwqbIN8BPhqrvlW8egLeE3mTh26T+Xr7jsPZuvMGhimNVJsQ6N1vqpIlLST6XfVu1T8fH8TJni5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gYg+CX1+LwQ1d/pqVZwdSTDwzHClvBRujya0hfw9N3M=; b=0T3eD35nTCWLO/9b7tV9So11g/FsG43WlhIWgA/RQI1pgc0nMRwxaUvo7gErKtLCacCA16764toc827cDJsKm7QcmIRe49UPkhxvgJpb8k8GMMtNYgU/IwBfA98z2CpaJwsNPIXRckWgFg9xLr/b4pJn503+aU3AXIZfPmoIjjkmtPMT1ICpPrRzazd9p45g4Jrcxh0v4Ur9LCMEEpz0PnQ2qyyeEP+61Ys3PzLs4zYjSM8hxWtSZkUDfZkYB6+K2bqbGDb4xDSMLXZF7GjXBBQbjokBsE0mP/YXekFaT58++FkJtA4ZEsGQtqJ1P6FFnBUmigTQzoIU3ZgGU8JIvg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <68555ada-e769-9565-4224-b543c9e71098@suse.com> Date: Mon, 18 Jul 2022 12:29:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/5] xen/wait: Use relative stack adjustments Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-5-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-5-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0153.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::11) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58bf87e5-d709-4e00-5c4b-08da68a85702 X-MS-TrafficTypeDiagnostic: VI1PR04MB5232:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: L58ofeD8YgPSfToB1hS8u0odymtnCOsEXwuwDrHIHDWSKahYEfW+IYTaiy1xwCdzCs4s34o4mEamsJj3MPo8NKTPJ6eZu5KHfp/wRsHslZfPJk5uYeeTN/yFSI6CGKaa+QQ+GzO9cQLVbVjoJSPHmOSRQ3Hsxp+VNw1KmeX44DYnySoyo6Jzhut8OELjlFzBDtFlkKfXVKKxD4rG18l+Bnc26/Emnx5CBTAApkbNRV9RFc+R3Jcp60wdoSyua3iOsu8nYK67I10fiw8vxk8SyMhPfkZUOhNm4TcafA/QEHwJJ7Oz7ff15xjJeBmM27lQHBfmZwuONIkkwUzwVeqhoGPtNj0aQzQOIKbT3jGuxEOpRwCoau3ncLrHsu6kvVDI++vjC5TmcXe9eLGJfCg5ts9TpAPIkU4nZLHJquUgnpjcUH9luznjXK1iNJAz/Oa/bG3UciiZsG3/UAqbR0DQaGBe+6Sak4uEuqw0K6L7+LV92iW7FQRL91S2PeQ1U9e9kS8P8R8D4Cx1khi9gDJ1cZRUaH7h0LZAWMTI9yrbPk7XXnv06EK6TYQYtpwEwRvCB5PMjqGUKOTzFZYpCT8CEzov8ZheE4bPHcEl1o1+Bx3NwosEMj76SzEwb+BA2JGoVrCIeToH/H0nAXvgT4ZDTmt0WrfiE1kHVt58XqmhNO5M1i8fmsfxV79CUvYtoYQ9WnYVBIYfXe0Jm+i9vGosGvtyDukYxTE5yIMb8axBPHB2WMsnGyJAgoOeIDYtT3Q0jNjuOvs0/QElIPVsRcnznNIVLEiXjfkm8p5Zz2txYkX4FUhUyb4vq4OMQ2TvJZYYSSvwqOTboQj4NGixP6OUb9r+KFFUSSzdh66b2FfeBi4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39850400004)(396003)(376002)(346002)(136003)(366004)(8936002)(5660300002)(66556008)(31686004)(2906002)(6916009)(54906003)(31696002)(86362001)(8676002)(4326008)(316002)(36756003)(6512007)(66476007)(53546011)(26005)(41300700001)(6486002)(186003)(2616005)(478600001)(83380400001)(38100700002)(6506007)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckZiY1lTNVpVSzg1T28xMjFzbUhaRG5tM0x0eVB1c0lCenNrU0JwY0VjQ2ls?= =?utf-8?B?NmRiUit3WGF0TlJHZHI4b1oyTDQxTWdlNW8vNng0L3FKcXBPdlk1R0RrU0hZ?= =?utf-8?B?MW4wVE0vczBHVW05dks0bDJxdHBPVkRhd2RpYzBtWjZHM21OVm5xbzV3ellt?= =?utf-8?B?QkRSNy9TcFA0U29sSjh1MkpDQ05YR0k3WjM4bjRlbGVkZkphVVQ3QXJIN3hC?= =?utf-8?B?OWtzQmsxWXhUamRlOWEwbEdrZ2lCK01TZ29pTExCRFNLSUN1dlhuSHZXMW5x?= =?utf-8?B?czR4ZUNWaldhY1l3T0VYMFRpRHVKZzZTTVpINVV6K09MdjZqYk5CQjFwNW9N?= =?utf-8?B?SVlmWEM2NGZBQU5ydHk4Z0FTWktZYzFFc2J2d2grRERocC9yTkRmbndDOHBC?= =?utf-8?B?S2pWYjVtaE1xd1I5TnlacHFUOFNhUkFvTE5OQktiMU9Yc0JrZWNzbDhkL3lU?= =?utf-8?B?eERPNW9FQStFWHMyTTFZTnFKSHc2N1NKYnV5ZHZpM2F6cTh5TytkZzNFVitJ?= =?utf-8?B?cjJwSmllZ0FTdm5qMXNDY1Y0OVJXTWFnVU5kM0dMbWZoYzFVQ1d5UmVlNVpP?= =?utf-8?B?akpVUzhKR21XYUliTUJQOFRqRkhKNEd1VjJEeFQ2YkNQQldueVIzYnRMZWtB?= =?utf-8?B?YXNIVUgxVDN4VW95REt6Sk5HWWpFcTVXNnBLdGhWamErakV2clZ6b0VrWmtD?= =?utf-8?B?L29mS0RBQUVrc0RjL3NCRkZKMDlDcUhGR1dmQktoZDU2aWg5KzdwWndkbjU3?= =?utf-8?B?UHdHNHNuS3RLWk5XRS9TUUV4QTd3T0FwNyt2ajh5dE5BQjUzZTRQbDM3K01p?= =?utf-8?B?d0xPaWt1RnFlNHM1MThSQWkrTmcya0FYblNsRjBCaGJiM0NzVm5PMmI5WXVl?= =?utf-8?B?UFovUGdMQlVCSlpIWUpzTmtzTjF4TzkvSXpvWlRRR0tGcUIwYmZVSG1NWkFW?= =?utf-8?B?TS84SUpCa0liZ3dVUXJjM3gyb1g0cGdCVy9ZUlhsd1ptc3l2TStPK1VNNmFV?= =?utf-8?B?eGFucVVxTTkxQm9wVFVHVkFWVDBCeWxKNkRrbCsrRWYzVnl6Z0h0WWpZR21L?= =?utf-8?B?c2NaQ3Jva2pQTm9KWEd3ZExEVUFtRFgvMVRoNE1NekxUWVBjMWxQQW9UVEMw?= =?utf-8?B?Rjd6NVExMFIwSDZFdEl4akxKOEdhVjA2Q0VBcldIeCsvQ3h2bkR6bktINHVh?= =?utf-8?B?aWc0Kys4enBjVkFSbnlhSGlGNk1hUjU1TXBHYzBhYzlTamYrK0RBNlB0T3FM?= =?utf-8?B?MFdBZDE0TjR4T1N2S3d2Qjc5Z3M1S0VuUlpCT1lXeTZxVGZjYjN3RlNTdnBr?= =?utf-8?B?cWgvMnlJQWVZZ2hjakowcHIrZGVwelJZRGlRVGxjQVZEV0l2MS92dkh4eHdp?= =?utf-8?B?cld1Ykx0bk9aTk9HZ1BXcFlTZzEvU0MrZXE3akVlL2wweFc0TGtDMS9YdDhz?= =?utf-8?B?ODRPTzRsT0J5cGVoM1FONStKS1pkOTBEY1hHRUtqKyswNXpwM3k3RTdYLy9t?= =?utf-8?B?TFdNc0Vmd01SQzYzbHpOTkRaVE9JRlVnVGdTS1VpbThtMGJ3UjNvU3poM1RJ?= =?utf-8?B?dVJCK08reUx4aGpiZWdxaDk3ekUrdFQ5SUl4eG5DQUE0dFVlN25vSDBZQ1hC?= =?utf-8?B?UVJhZzRCMW5XMVFPZTBBdUdMdEZlMXByMzhRQ1dkdmdWcEpwbVkzalp4Znox?= =?utf-8?B?T2FJTnp5eWc1RlZLT3pQWThubVpDcXpDb01aZjM3WTFUa3JXa1hoL241emVo?= =?utf-8?B?OEZIdmpoV0FuNlgwVXgzN1E0SkpYY3RaY24rQ1lTSEZLRmtUalk3aUp2ZDdh?= =?utf-8?B?VEE0djdUSkFNZzB2STgxVU85cTdtS2N5NzVPUzg4V0pTY2s3Mi9ZRnE2YXhQ?= =?utf-8?B?OVBHNXJTYUVJRmJNaWNZMTZiOXpyK2Q5eEErdTBhME4weDg5c1BQZUhPQVpw?= =?utf-8?B?dU5nL3REZFhvZnl2UzhqYnRQVStSUTdOK2xjZUZpRHhXZjE4TEpydW5PdXIx?= =?utf-8?B?MWp0eE4xUTlNaWk5RC9QaGppRVRpNC9vQU01c0dhelQ3VDYxenpJOHRZVUU0?= =?utf-8?B?aTJzT0xZYlgyNldyRzhWR2RHRTB1U2Z6aldpa0hCb2twT3cxcEhBNFArY1FM?= =?utf-8?Q?OooPUAD4TVvzwkak9zmxgeyDD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58bf87e5-d709-4e00-5c4b-08da68a85702 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:29:05.1007 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hhdybUli+ZJegfUEATQVKnhtpFd/3F2AQmNGSg1yolOffQfaS/xI/veTGm1mwkc8NzovMX/daqbvxFdS3LahbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5232 On 18.07.2022 09:18, Andrew Cooper wrote: > @@ -121,11 +121,11 @@ void wake_up_all(struct waitqueue_head *wq) > > static void __prepare_to_wait(struct waitqueue_vcpu *wqv) > { > - struct cpu_info *cpu_info = get_cpu_info(); > struct vcpu *curr = current; > unsigned long dummy; > + unsigned int used; > > - ASSERT(wqv->esp == 0); > + ASSERT(wqv->used == 0); Minor: Use ! like you do further down? > @@ -154,24 +154,25 @@ static void __prepare_to_wait(struct waitqueue_vcpu *wqv) > "push %%rbx; push %%rbp; push %%r12;" > "push %%r13; push %%r14; push %%r15;" > > - "sub %%esp,%%ecx;" > + "sub %%esp, %%ecx;" /* ecx = delta to cpu_info */ > "cmp %[sz], %%ecx;" > "ja .L_skip;" /* Bail if >4k */ According to the inputs, %eax is still 0 when bailing here, so the check below won't find "used > PAGE_SIZE". I further wonder why you don't store directly into wqv->used, and go through %eax instead. > - "mov %%rsp,%%rsi;" > + > + "mov %%ecx, %%eax;" > + "mov %%rsp, %%rsi;" /* Copy from the stack, into wqv->stack */ > > /* check_wakeup_from_wait() longjmp()'s to this point. */ > ".L_wq_resume: rep movsb;" > - "mov %%rsp,%%rsi;" > > ".L_skip:" > "pop %%r15; pop %%r14; pop %%r13;" > "pop %%r12; pop %%rbp; pop %%rbx;" > - : "=&S" (wqv->esp), "=&c" (dummy), "=&D" (dummy) > - : "0" (0), "1" (cpu_info), "2" (wqv->stack), > + : "=a" (used), "=D" (dummy), "=c" (dummy), "=&S" (dummy) You can't validly drop & from =D and =c. If you want to stick to going through %eax, I think that one wants & added as well and ... > + : "a" (0), "D" (wqv->stack), "c" (get_cpu_info()), ... the (unused) input here dropped. > @@ -220,14 +224,22 @@ void check_wakeup_from_wait(void) > * the rep movs in __prepare_to_wait(), it copies from wqv->stack over the > * active stack. > * > + * We are also bound by __prepare_to_wait()'s output constraints, so %eax > + * needs to be wqv->used. > + * > * All other GPRs are available for use; they're either restored from > * wqv->stack or explicitly clobbered. > */ > - asm volatile ( "mov %%rdi, %%rsp;" > + asm volatile ( "sub %%esp, %k[var];" /* var = delta to cpu_info */ > + "neg %k[var];" > + "add %%ecx, %k[var];" /* var = -delta + wqv->used */ > + > + "sub %[var], %%rsp;" /* Adjust %rsp down to make room */ > + "mov %%rsp, %%rdi;" /* Copy from wqv->stack, into the stack */ > "jmp .L_wq_resume;" > - : > - : "S" (wqv->stack), "D" (wqv->esp), > - "c" ((char *)get_cpu_info() - (char *)wqv->esp) > + : "=D" (tmp), [var] "=&r" (tmp) > + : "S" (wqv->stack), "c" (wqv->used), "a" (wqv->used), If you want to stick to going through %eax, then I think you need to make it an output here: "+a" (wqv->used), so it is clear that the register is blocked from any other use throughout the asm(). Or you could use "=&a" and copy %ecx into %eax inside the asm(). Both may cause the compiler to emit dead code updating wqv->used right after the asm(), so I think not going through %eax is the more desirable approach (but I may well be overlooking a reason why directly dealing with wqv->used in __prepare_to_wait() isn't an option). Strictly speaking (in particular if [right now] there wasn't just a branch after updating %rdi) you also again want "=&D" here. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:42:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:42:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369551.600983 (Exim 4.92) (envelope-from ) id 1oDOCO-0006J0-9o; Mon, 18 Jul 2022 10:42:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369551.600983; Mon, 18 Jul 2022 10:42:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOCO-0006It-6p; Mon, 18 Jul 2022 10:42:00 +0000 Received: by outflank-mailman (input) for mailman id 369551; Mon, 18 Jul 2022 10:41:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOCN-0006In-3x for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:41:59 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3dea0783-0686-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:41:57 +0200 (CEST) Received: from mail-mw2nam12lp2044.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 06:41:51 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6609.namprd03.prod.outlook.com (2603:10b6:806:1c8::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 10:41:49 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:41:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dea0783-0686-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658140917; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9aPR39BjsIXpC3oY56oqxK1fFSdDx3DNYMzk9a7Vygk=; b=U2kfR6pAIfL1o8A6DrMsnAm7yLisxmijt6pJ46qby3xtsZLviaEMPvnA zgIZ4Qi5x3tTGr1nkiQEl8cZqT3H7G/f4tsX+2yt3+uFS4uLo7vKyUGe+ HtZfmN8nqFlSual4uk9qC2Jfgeg1aH2IjMPdTyVla8Gh6FBslAEBh1ZMt 0=; X-IronPort-RemoteIP: 104.47.66.44 X-IronPort-MID: 75321633 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:u/CWkK3a/c16/yr7PvbD5c1wkn2cJEfYwER7XKvMYLTBsI5bp2MFz GtKCGDUMqyNMTeheN11YNmz8UpS75SDmN5kQQBopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8Uw35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6+lcHAYWGN1Ew8NID2Jw+ vkjCRYsdinW0opawJrjIgVtruIKCZCxeaYg4DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2Ce5L2EwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPCkmDcrCn37gPJtRjLYIErOYa+yt9rqkaq5WM2JU0qCWLu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslgEYc8pdFas98g7l4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9WopWm1876VqXa3JnITJGpbPyscF1NZv5/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV IronPort-HdrOrdr: A9a23:aaTp46kHW0xOfaRDbpyZQuNShyTpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="75321633" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BxYk+NAe6xJVY/w3NPHBXO0SG7ScbufxOWn88ExUYbnJTUqXGtfXDCC6EETEOsu+tmBG0acRMdc/1uYMdmd+OcJUq7h4wTW/MisN8HhriF7MQYrBRBlLjwrDm5G/ZrfjwPNOcusqtESXkmG2Qa2r0UR2Ch1F1b4sPbfMeDKXt7cqv+rCQp8ycSHRjjBHNszY2pmn+6/bNuRO7gj/drbSm6QjQfyBEMJITy4rnDFpLhJrYSxq/MESw6Ph/mjuiafk1c9tIPw8dPyBcTmAxT/kcB8T6oPxJVmRTfP/jPj7jq0TloNW0ZyJ1WQ1CrR5Bxk8sM5on2Pz5x0lxVJFm0lmBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9aPR39BjsIXpC3oY56oqxK1fFSdDx3DNYMzk9a7Vygk=; b=RAPG/95y2WLyorNIpHbz+5WWdozQXrHqgkCH7Z7Y+hc1RnqLecydnilxJjbLxl3VyVwYs1OelJFU320iC97v93hgXhrbfeKTTO6xZVoZu6+yNH840WNqrKg9szY8E8GylgvZX7MjI2A+4MbKJ0ZOx12BShtZeVn7GS1uYxeOzD0b6Nkx7Wo0nPAfgySE7ZN8kG0i6V1aS2i2vTrA5z5Hk2osch3Inc6gshq53WfLlbBZ4nxVs0ZtLpJUDrf1kQbJuNSW4WuXJnNk8lx/+v38ulyyrcPCNKPX2SFaG5YJG7tpJGqlyf2K+PYjmupBygAN1jHnn1Agm+Lqs6S/vZkCkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9aPR39BjsIXpC3oY56oqxK1fFSdDx3DNYMzk9a7Vygk=; b=StqcAeBi7RI5lI9LYJGhZbCte44ieGbTtlYpxJFR9N/boNoaBb0o1K2oerAKNemc/IxflIMlLkz4qLYKdZghwmNpSBY9YO3V/w2MDKyouIqoaQjMYkBtbCxF6JjiSN1uXV92pE1PtrgYlI3RrLyjHKPJJOHb+vUnNBUKGDCCyDA= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Xen-devel Subject: Re: [PATCH 4/5] xen/wait: Use relative stack adjustments Thread-Topic: [PATCH 4/5] xen/wait: Use relative stack adjustments Thread-Index: AQHYmnakulieGT4u2UqPhEJd4RhrIq2D7XmAgAADkYA= Date: Mon, 18 Jul 2022 10:41:49 +0000 Message-ID: <45bec79b-f065-eb98-b4a3-3be6d4b7e674@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-5-andrew.cooper3@citrix.com> <68555ada-e769-9565-4224-b543c9e71098@suse.com> In-Reply-To: <68555ada-e769-9565-4224-b543c9e71098@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5014d839-b08e-4540-9a9b-08da68aa1e9b x-ms-traffictypediagnostic: SA1PR03MB6609:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 38b6Im38tdJ5okbkMTlJQhB4BE9lh9F2MgjHmtZYCIr79l2q6GN+i5T8boYMgOj/GKltQHwHhyE1pTJzqE3DW7JlWCcoKpSbQ41OHQdU+rRXnqCtKnyORswR+sXsSLkPzrbspQcEEk85vfCD97qxST2y/5XhnQx1bYDbmCiotiyMAKNz0LFPPyl/jGs74RMmT75L1m46NPkTkHRcEqKxGvMlAM1OwWMUXh0NVbQgr3xgPIE45xJ93BXMbe0aLuzvI70LdWZPmx2fhU/oT7NDU9Hbr95B85Whx8lLbqakgkMAO2Zwwl6QyxbgvV8GSmFB1J5nMfFf3jBYneaDc/95xY6GmaVYT6coEPy4Cl+8SvS/oC1DIBO60M1UfyAkbZW6Ib5jVTpMreScEObyfTdIZnmt0iuI+3wqnZXJhn6aLO+QGglL2joPE+CNmm4YUv2lRzQRHZ6dTmY6faHDEFlCoHyK8g4SYHyg4tRloN4XENjQ20n3GVhmMM7OzLw1aaZv+i6BbtSc+nYf5W3hhPYo9kAJB75QmzHqV19LbBnE0VGdX4ox2fS156lq5SKvI67xuocS2U0D4TDbA+86ostjQQTusLFaQ1oQL2lZAqbIRTDsFMc0Y7etMpKGa+hHhyocvQtX0g2GuvaryS8JOZO8GeZ4piNwZN26gHVNVQ5cJ6UfVe9cc+oeFcgJYYkslv2C1JROw/94sWwEFq/2fCLfQwPWCIDZ+6w8xNe9fVbEExXPiRtDnzJu8TVaOH/5RSASMvzLQVWN2kG2q0zx6NDtnJHOa1nt0p8PFBxPxmm7dUjCfXa7db3OUHc+II/EYe7XMOlC+GNy0+pLrF6V8hKKSAx6mV6jKJ2d0Of/Cj8T/sV8gAUxhEcS4wkFW/dhtor4A4OvIhg69fmzTBMOxUWBgw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(2616005)(186003)(38100700002)(6486002)(478600001)(122000001)(6512007)(91956017)(966005)(53546011)(71200400001)(6506007)(26005)(41300700001)(64756008)(38070700005)(66946007)(82960400001)(66446008)(36756003)(4744005)(8936002)(2906002)(31686004)(5660300002)(66556008)(8676002)(6916009)(54906003)(31696002)(86362001)(76116006)(4326008)(316002)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?U0dRUmVhY24xS1RHZlJmVjFyaS9vMFRvZGdQR1VGSENVWU5ubS83clN0RW9z?= =?utf-8?B?eDZwSTZ2ZVBwNGVkVm1DbEIzUkk2VVJDZEtWTnNQU2JSSlZHd3FPbkY0a1Jv?= =?utf-8?B?UHRJNEZMdCsvU3Jsa3kvZTZJNS9oakZ0eGxRT080ZmJoSlNqaEdwNjdYbkpj?= =?utf-8?B?YlhFbVZNamtac0YxbUVzQ3ZxM2M2aExNNEpPMm9lUm90T1ZObkNaR0FiNG53?= =?utf-8?B?NSs2NVRxVmFFNGJhMkR4Q1licUFLNEgxT2Y0V29sUk1UNDBiQTlTSmpxSEpM?= =?utf-8?B?R3FqOXZHZGhZbEd0VHBOcGlHYjdPanhjd2NyYjQyd2psc1p6aURXbkZFV2t5?= =?utf-8?B?ZGpNS1ZZUnBUUGpnV2RWd0txSFpTUms4WHBmbSszQUhFMERJQm0wTWkydnBS?= =?utf-8?B?c01zaEhwdm1hODhUMyt6ZnIwRzUraXN0dzVhQnlIeTZ4SktwNm1qWThCVkY0?= =?utf-8?B?cnJEcUp1b3RkYVhQaGN5aHlZUkZwbXN4STZVNFBXaldlN0c2Znd4L0o5UTRB?= =?utf-8?B?bGRTOUx1V01Hb081MUJpRUJPU1ptVUZaUFRnaWFuaHAxdFZyaXJiNzdub29s?= =?utf-8?B?eDJZc2Y3RlhYcE45aG1pejVKNk94NFBqR2J2QnYzNVhaakJtNmhKVFV4S1R2?= =?utf-8?B?OGE5Yys0RjREc1lBZTZ1Q1UzZ0RxOWs0S2RBbGl4ZUhLZENMWVFqV0s4ZjVP?= =?utf-8?B?RTRVVHRyeGw4S1lEM05rRnNmKzFSL05NcFNNTjdqL3RZcE5UNUlTcEpibFdS?= =?utf-8?B?UWtwb3JDeTc4UWFSOU96a2tkRXJsM2M3WmlRbTU2SFlrbDMzRDd1WTVuSHBO?= =?utf-8?B?ZGdCcnFkaXA2L3lwbnREWndMVDNyTU1SUWhBTW5OaDh3RmdkQVpLdkZidHBU?= =?utf-8?B?RTFNaW1IZXZTYWdabWg1WWJZZXQvSmJjc01NcThKZm1rM2ZKS2FsOHpSRXFz?= =?utf-8?B?WE1IVkRUbG5WTWpkbGFFOWVBeEFxVUlhZ0JHaVIxVlVrL2NmZEpGRTNsMHFm?= =?utf-8?B?R05VdXhqS3ZmOHJIUGkvUEovbGRXZTZDQVAzMnhXcUU4MVo5QnZINyt4TVBn?= =?utf-8?B?ZnNudyswU1UvYnJLYlRzaG9vQmxzbDZlYko0S2FnLzJpME5Nb1o1UjJzYVF6?= =?utf-8?B?akkwWXBXMXphZHovcW9sQlRtRlpOcDBhNVY3azkyL2x1ejJEOXJmR21VYldu?= =?utf-8?B?MDZ5YTVvQzloNzczU05ERzM5U3JnbFpwQldnVDg2MXNNNENQSEROaStXajNs?= =?utf-8?B?OWhZbklKK1djdDZybUUxTGk2aWhkZHJmMGtsdEExNFpMU09CalZrU2ZMTjA0?= =?utf-8?B?cnVCRTVET2J1VHQvUzVyZm8yYWlueUQ3MUp4eTd6OHZDQjJtYW94aUc3cGRD?= =?utf-8?B?Ly9QYjBhQmhxbmluTTdPZVRRSlNlOVljaUx2TWU4UlRYSEJCSDJFQnMwZjlW?= =?utf-8?B?MlRTUEpLREM3VXN1N0FzdXMyVTFYaDlldXRydWdxYytlMGE4ZHlELzN6NWll?= =?utf-8?B?Q0p1cnlRSlM0VCtacEpIOHg3cmMwZFVUMHdyK2F0c0R4Sm5GSVF1aHZ3RHpD?= =?utf-8?B?cDhGM0hpR2ZwaGFaMmlGTUtsRHpqOFNPTlprZW4zVFdIa1JjMWFFV05oK0JB?= =?utf-8?B?eWRXRlZ4VTUxSHI0eHlZMElJclpGdXBBMUxuY1dIa3UrblFhN1lnSFhQL3hL?= =?utf-8?B?UEp0M2p5WXBuK1NkZUNTclQwYVlQdSt4UmI0MWFpTjRjd2s1V2xkVFI5b0JV?= =?utf-8?B?NFNkRDFEZ282ZXliQm1KTDVpTjNVU1hSUWVacExydGYxUVNLREgvZDZuWXVv?= =?utf-8?B?byt4Z0dYZnBBMmtjV2Zqb2dSKzBVV1NWZDNET0dDN2UwdXNkK0V4WTd3QWZ3?= =?utf-8?B?S3V5R2N1MkJQL1c5NWwzWTBYQjlGUFFpOFZtNXVZbk4yT2NSaUdjZmF2Vjdn?= =?utf-8?B?RzV5a2s1bGNJeFJwTUJUcW8va0hpNFlRdFJ0RWtJSVFCS2xUYkVPczM5RndB?= =?utf-8?B?Y1NkRHUwUkpYZGk3SVh4TW5QSndUZWRTU05QdERCVXNXbW85S1pGc0pzMnN4?= =?utf-8?B?anNrRlFEdkViNDNwL3orNU82ekNnVFlUQ1EzQithQmNBRElvcERsdXRqWkVF?= =?utf-8?Q?WDNN6GpucTty+F4eLV/JjHW9Q?= Content-Type: text/plain; charset="utf-8" Content-ID: <3E64302FA0DF2C48B65E7BF303B92161@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5014d839-b08e-4540-9a9b-08da68aa1e9b X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 10:41:49.3120 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nEU12KfvhRFAebq+HhpQ7SLUs6yWyGwF+k4q0VHTkJOtUkGcCeQPF9Zv1MI3FQVLJvLOXxNJ939OQHNdj8Ed5q+Oig9QxjeCX80+Tkc7KOg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6609 T24gMTgvMDcvMjAyMiAxMToyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjA3LjIwMjIg MDk6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiAtICAgICAgICAibW92ICUlcnNwLCUlcnNp OyINCj4+ICsNCj4+ICsgICAgICAgICJtb3YgJSVlY3gsICUlZWF4OyINCj4+ICsgICAgICAgICJt b3YgJSVyc3AsICUlcnNpOyIgLyogQ29weSBmcm9tIHRoZSBzdGFjaywgaW50byB3cXYtPnN0YWNr ICovDQo+PiAgDQo+PiAgICAgICAgICAvKiBjaGVja193YWtldXBfZnJvbV93YWl0KCkgbG9uZ2pt cCgpJ3MgdG8gdGhpcyBwb2ludC4gKi8NCj4+ICAgICAgICAgICIuTF93cV9yZXN1bWU6IHJlcCBt b3ZzYjsiDQo+PiAtICAgICAgICAibW92ICUlcnNwLCUlcnNpOyINCj4+ICANCj4+ICAgICAgICAg ICIuTF9za2lwOiINCj4+ICAgICAgICAgICJwb3AgJSVyMTU7IHBvcCAlJXIxNDsgcG9wICUlcjEz OyINCj4+ICAgICAgICAgICJwb3AgJSVyMTI7IHBvcCAlJXJicDsgcG9wICUlcmJ4OyINCj4+IC0g ICAgICAgIDogIj0mUyIgKHdxdi0+ZXNwKSwgIj0mYyIgKGR1bW15KSwgIj0mRCIgKGR1bW15KQ0K Pj4gLSAgICAgICAgOiAiMCIgKDApLCAiMSIgKGNwdV9pbmZvKSwgIjIiICh3cXYtPnN0YWNrKSwN Cj4+ICsgICAgICAgIDogIj1hIiAodXNlZCksICI9RCIgKGR1bW15KSwgICAgICI9YyIgKGR1bW15 KSwgICAgICAgICAiPSZTIiAoZHVtbXkpDQo+IFlvdSBjYW4ndCB2YWxpZGx5IGRyb3AgJiBmcm9t ID1EIGFuZCA9Yy4NCg0KT24gdGhlIGNvbnRyYXJ5LCBHQ0MgZGVtYW5kcyBpdC4NCg0KJiBpcyBv bmx5IHJlbGV2YW50LCBhbmQgb25seSBwZXJtaXR0ZWQsIHdoZW4gdGhlcmUgaXMgbm90IGFuIGV4 cGxpY2l0DQppbnB1dCB0aWVkIHRvIHRoZSBzYW1lIHJlZ2lzdGVyLg0KDQpXaGVuIHRoZXJlIGlz IGFuIGV4cGxpY2l0IGlucHV0IHRpZWQgdG8gdGhlIHNhbWUgcmVnaXN0ZXIsIG9mIGNvdXJzZSBp dA0KY2FuJ3QgYmUgcmV1c2VkIGZvciBhbm90aGVyIGlucHV0IGJlZm9yZSBiZWluZyB1c2VkIGFz IGFuIG91dHB1dC4NCg0KaHR0cHM6Ly9nb2Rib2x0Lm9yZy96LzR2V1A0UEtjNQ0KDQp+QW5kcmV3 DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:45:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:45:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369556.600994 (Exim 4.92) (envelope-from ) id 1oDOG5-0006vr-Pw; Mon, 18 Jul 2022 10:45:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369556.600994; Mon, 18 Jul 2022 10:45:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOG5-0006vk-N2; Mon, 18 Jul 2022 10:45:49 +0000 Received: by outflank-mailman (input) for mailman id 369556; Mon, 18 Jul 2022 10:45:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOG4-0006vc-7R for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:45:48 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c65980a9-0686-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:45:45 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CBFF95C00B5; Mon, 18 Jul 2022 06:45:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 18 Jul 2022 06:45:43 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 06:45:42 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c65980a9-0686-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658141143; x= 1658227543; bh=LMJuxnGnJ+U5QCPNRgg8fL8m8II2urSozxMf60fUk14=; b=I Jtqy5qGu4i1j+QdwrVqqjJ+TXmki2zRTyOhiOgIBcr/asFoQR+6huW/56oxHposP noAY1xLOkf0UH5nsLIMUTsyVhiaMwBQau8oZw0lMK6302Hkhwjq1k53hVyjLPfLD VeYXL0pHKJs/fUNacHHMI2TlE5kV1j1LoWEnmGpflH6q6B4unGIF+GbY6NIEU0D/ 6D/q+UTQmGgu5QlEnzle83NZ0ttCmE9yNk9H/RCh257y2sTuu1x7YmC22TrZ433x XFXJVJvOI3T6lV5xr9MmFAFsFKuE7yuY84iyORp12//PDz7jqNg6TccYPuV/plEq zqD1SQOZMVdiQ6eIJ7HIw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658141143; x=1658227543; bh=LMJuxnGnJ+U5QCPNRgg8fL8m8II2 urSozxMf60fUk14=; b=ZQ5vcDajj2Nxf9+mntGbUiiVhgIEg7PsH2pOWkWZqKg1 KVSk/+oIRu5LhKLGuqbXz3RSDhPSoyvIkA6L+XmmvLDpusbV/ovKYtuQaQ63kP1D vDyWIzBr34+LYYYYNTXreslgZJIY7klXW4K48qgQnhwAtCcJfXUtkleat9p3Jb37 J+noxCK/QVPkOiGQD9XyogRr9ruGsPmMwl4t6LJ4IGTuw5tUVSsVqO3j/XViojXh bliixe5/1fhLr7BC/ZMWFRZyHFHgy2aazDlIYN8sNOnKFPL0OxCZ0Xd0BGVMs+BG CGZOSRebywXeRBVe8VFbR6f4aQWklXT2ckV7iohrwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepieeg ueekveetudfghefgieevffelieeiueekffdtgeejkeelgeffudfhfffhjeefnecuffhomh grihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslhgrsg drtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 12:45:38 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> <5a283b4d-8d1a-52cf-d863-350e2ff39566@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Up8UBq8qqDpu2mBW" Content-Disposition: inline In-Reply-To: <5a283b4d-8d1a-52cf-d863-350e2ff39566@suse.com> --Up8UBq8qqDpu2mBW Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 12:45:38 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger On Tue, Jul 12, 2022 at 05:59:51PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > --- a/docs/misc/xen-command-line.pandoc > > +++ b/docs/misc/xen-command-line.pandoc > > @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: > > =20 > > ### dbgp > > > `=3D ehci[ | @pci:. ]` > > +> `=3D xue` > > =20 > > Specify the USB controller to use, either by instance number (when goi= ng > > over the PCI busses sequentially) or by PCI device (must be on segment= 0). > > =20 > > +Use `ehci` for EHCI debug port, use `xue` for XHCI debug capability. > > +Xue driver will wait indefinitely for the debug host to connect - make= sure the > > +cable is connected. >=20 > Especially without it being clear what "xue" stands for, I wonder > whether "xhci" would be the better (more commonly known) token to > use here. Sure, I can change that. I modify this code heavily anyway, so there is little point in keeping it similar to the original xue driver. > > --- a/xen/arch/x86/setup.c > > +++ b/xen/arch/x86/setup.c > > @@ -946,6 +946,9 @@ void __init noreturn __start_xen(unsigned long mbi_= p) > > ns16550.irq =3D 3; > > ns16550_init(1, &ns16550); > > ehci_dbgp_init(); > > +#ifdef CONFIG_HAS_XHCI > > + xue_uart_init(); > > +#endif >=20 > Can you make an empty inline stub to avoid the #ifdef here? Ok. > > --- a/xen/drivers/char/Kconfig > > +++ b/xen/drivers/char/Kconfig > > @@ -74,3 +74,12 @@ config HAS_EHCI > > help > > This selects the USB based EHCI debug port to be used as a UART. If > > you have an x86 based system with USB, say Y. > > + > > +config HAS_XHCI > > + bool "XHCI DbC UART driver" >=20 > I'm afraid I consider most of the other options here wrong in > starting with HAS_: Such named options should have no prompt, and > be exclusively engaged by "select". Hence I'd like to ask to drop > the HAS_ here. Ok. > > + depends on X86 > > + help > > + This selects the USB based XHCI debug capability to be used as a UA= RT. >=20 > s/used/usable/? Yes. > > --- /dev/null > > +++ b/xen/drivers/char/xue.c > > @@ -0,0 +1,933 @@ > > +/* > > + * drivers/char/xue.c > > + * > > + * Xen port for the xue debugger > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; If not, see . > > + * > > + * Copyright (c) 2019 Assured Information Security. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include >=20 > Please sort xen/ before asm/ and alphabetically within each group. Ok. > > +/* uncomment to have xue_uart_dump() debug function */ > > +/* #define XUE_DEBUG 1 */ > > + > > +#define XUE_POLL_INTERVAL 100 /* us */ > > + > > +#define XUE_PAGE_SIZE 4096ULL >=20 > I think I had asked before - why this odd suffix? >=20 > > +static void xue_sys_pause(void) > > +{ > > + asm volatile("pause" ::: "memory"); > > +} >=20 > I wonder whether the open-coded inline assembly is really needed > here: Can't you use cpu_relax()? If not, style nit: Several blanks > missing. Probably I can. > > +static bool __init xue_init_xhc(struct xue *xue) > > +{ > > + uint32_t bar0; > > + uint64_t bar1; > > + uint64_t devfn; > > + > > + /* > > + * Search PCI bus 0 for the xHC. All the host controllers supporte= d so far > > + * are part of the chipset and are on bus 0. > > + */ > > + for ( devfn =3D 0; devfn < 256; devfn++ ) > > + { > > + pci_sbdf_t sbdf =3D PCI_SBDF(0, 0, devfn); > > + uint32_t hdr =3D pci_conf_read8(sbdf, PCI_HEADER_TYPE); > > + > > + if ( hdr =3D=3D 0 || hdr =3D=3D 0x80 ) > > + { > > + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) =3D= =3D XUE_XHC_CLASSC ) > > + { > > + xue->sbdf =3D sbdf; > > + break; > > + } > > + } > > + } > > + > > + if ( !xue->sbdf.sbdf ) > > + { > > + xue_error("Compatible xHC not found on bus 0\n"); > > + return false; > > + } > > + > > + /* ...we found it, so parse the BAR and map the registers */ > > + bar0 =3D pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0); > > + bar1 =3D pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_1); > > + > > + /* IO BARs not allowed; BAR must be 64-bit */ > > + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) !=3D PCI_BASE_ADDRESS_SPACE_M= EMORY || > > + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) !=3D PCI_BASE_ADDRESS= _MEM_TYPE_64 ) > > + return false; > > + > > + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); > > + xue->xhc_mmio_size =3D ~(pci_conf_read32(xue->sbdf, PCI_BASE_ADDRE= SS_0) & 0xFFFFFFF0) + 1; > > + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, bar0); >=20 > Why is a 64-bit BAR required when you size only the low 32 bits? xHCI spec says the first BAR is required to be 64-bit, so I'm checking this assumption to handle just this one case. But then, the size is 64K in practice (and xue_sys_map_xhc() checks for that), so just 32 bits are enough. Anyway, I can add sizing the whole thing, for consistency. > Also you need to disable memory decoding around this (and > somewhere you also need to explicitly enable it, assuming here > you would afterwards restore the original value of the command > register).=20 Actually, this is a good place to enable memory decoding. > Further you're still open-coding > PCI_BASE_ADDRESS_MEM_MASK here. >=20 > > +/** > > + * The first register of the debug capability is found by traversing t= he > > + * host controller's capability list (xcap) until a capability > > + * with ID =3D 0xA is found. The xHCI capability list begins at address > > + * mmio + (HCCPARAMS1[31:16] << 2) > > + */ > > +static struct xue_dbc_reg *xue_find_dbc(struct xue *xue) > > +{ > > + uint32_t *xcap; > > + uint32_t next; > > + uint32_t id; > > + uint8_t *mmio =3D (uint8_t *)xue->xhc_mmio; > > + uint32_t *hccp1 =3D (uint32_t *)(mmio + 0x10); > > + const uint32_t DBC_ID =3D 0xA; > > + > > + /** > > + * Paranoid check against a zero value. The spec mandates that > > + * at least one "supported protocol" capability must be implemente= d, > > + * so this should always be false. > > + */ > > + if ( (*hccp1 & 0xFFFF0000) =3D=3D 0 ) > > + return NULL; > > + > > + xcap =3D (uint32_t *)(mmio + (((*hccp1 & 0xFFFF0000) >> 16) << 2)); >=20 > Why not either >=20 > xcap =3D (uint32_t *)(mmio + ((*hccp1 >> 16) << 2)); >=20 > or >=20 > xcap =3D (uint32_t *)(mmio + ((*hccp1 & 0xFFFF0000) >> 14)); >=20 > ? Ok. > > + next =3D (*xcap & 0xFF00) >> 8; > > + id =3D *xcap & 0xFF; > > + > > + /** > > + * Table 7-1 states that 'next' is relative to > > + * the current value of xcap and is a dword offset. > > + */ > > + while ( id !=3D DBC_ID && next ) { >=20 > Nit: Brace placement. >=20 > > + xcap +=3D next; > > + id =3D *xcap & 0xFF; > > + next =3D (*xcap & 0xFF00) >> 8; > > + } >=20 > Is this loop guaranteed to terminate? See drivers/pci/pci.c where > circular chains are being dealt with in a similar situation. Proper device shouldn't have circular chains here, but yes, adding protection against this is a good idea. > > +/* Initialize the DbC info with USB string descriptor addresses */ > > +static void xue_init_strings(struct xue *xue, uint32_t *info) > > +{ > > + uint64_t *sda; > > + > > + /* clang-format off */ >=20 > What's this? >=20 > > + const char strings[] =3D { >=20 > static? >=20 > > + 6, 3, 9, 0, 4, 0, > > + 8, 3, 'A', 0, 'I', 0, 'S', 0, > > + 30, 3, 'X', 0, 'u', 0, 'e', 0, ' ', 0, > > + 'D', 0, 'b', 0, 'C', 0, ' ', 0, > > + 'D', 0, 'e', 0, 'v', 0, 'i', 0, 'c', 0, 'e', 0, > > + 4, 3, '0', 0 > > + }; > > + /* clang-format on */ > > + > > + memcpy(xue->dbc_str, strings, sizeof(strings)); >=20 > Can't you simply assign to xue->dbc_str? I don't see this being used > elsewhere, so it might even be possible to omit the field altogether > (and with it the str_buf static variable consuming an entire page). That is an option, but honestly (as you note below), there is a bit too much magic here. > > + sda =3D (uint64_t *)&info[0]; > > + sda[0] =3D virt_to_maddr(xue->dbc_str); > > + sda[1] =3D sda[0] + 6; > > + sda[2] =3D sda[0] + 6 + 8; > > + sda[3] =3D sda[0] + 6 + 8 + 30; > > + info[8] =3D (4 << 24) | (30 << 16) | (8 << 8) | 6; >=20 > Wow, magic numbers. And, apparently, some used several times. I think I can make this whole string table init a bit clearer (at a negligible higher runtime cost). --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Up8UBq8qqDpu2mBW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVOdMACgkQ24/THMrX 1yzH/ggAiMyT1/hzBWzPSpsJDxVXO6+MhtCv6pOaZ4cGRoojehKs9Cz/nKfylaMC oEuR+NcTG8UADvOXr1PsK9thKTNNFE8Ci5MA47/aQ8I+ZR0bgHwzixSrib/VADvU aRE/UGpbKtHKGin5f/21DhNfZg87Klof1VCysVCDd5dEJI8L80BkAjEFq01IlkT2 SMJwwsP7zywJyGkmwdTcK8x5ery6lUpVU4voWJugdvTd7tSbyvKgeoHYUPWd+2rl xxjUebI7OFVO8E9gR7st+jg+QEfqlOCHyhZBZrRXcCR6GnE2xTa5x6eNIGcn4U/P oMtKlhnZG1rsxx8AWv26nSG8Lr5m6A== =Rss7 -----END PGP SIGNATURE----- --Up8UBq8qqDpu2mBW-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:48:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:48:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369564.601005 (Exim 4.92) (envelope-from ) id 1oDOIW-0007Wl-7H; Mon, 18 Jul 2022 10:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369564.601005; Mon, 18 Jul 2022 10:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOIW-0007We-3t; Mon, 18 Jul 2022 10:48:20 +0000 Received: by outflank-mailman (input) for mailman id 369564; Mon, 18 Jul 2022 10:48:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOIV-0007WD-0m for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:48:19 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2065.outbound.protection.outlook.com [40.107.20.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 21c8c391-0687-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:48:17 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AS1PR04MB9653.eurprd04.prod.outlook.com (2603:10a6:20b:475::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:48:15 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 21c8c391-0687-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=amgXt8zuA8Kbkikgd9nQq57HKgkuwY6ezXeyo+XpXbyGhl5W6pZSPUacsQxY+Bab45hZMV+cF8qO7kie3ExLz84Jt50oB66I7VQZQ+bjP9t9/CfEMtV5bXMTZ2lm1LaeV7r5afwOAXLDlhRuMq3STvaSabt7IlXP8Z/whyByZqgTKK/U13GX5B7NCwq5BXTVHbL64JnIpKYuWOFmp7QBoY77URrLJ2yZ5YMUAxE3v4HKIKim6a+27yQDTkLwbkilftVc3OOVR/UL5meS7MujcnHwVgsDHajm059j9Pd4Xw2lQIkyu6NwOUrfl1ZuUoKfPga+jsAN1XUvqXPLs4ewdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TWYiKj1v9skZopvMgCoh4nulmfHARZA6J/VFo/hpWhk=; b=hgK2eKnKBY9zZTYAR1kgY/aLZbk0WgRonErjFoAgkgotEaxqeriAv2necyhY7tEEmb03/AXFWp+95uKszIvxU+AdMKwcW8fdbk3NwxtXTzWuI9d0+IX7DdMgvHYRqbvS3x65feeCOjdGlgjV6Hy6tgpVYX7tZ5fq0xqWIYSpZoxjXMOmmlITWNQ41s/KqvH1MfkhoHTn1fDZ++tlWm0yrf9dCj9xpF6mAXqTArRql7U377uF23m0wDUOeJab32VIICGWezoQYxjKryOl0o/JmIFiqMtqyNkjvqFWMcfYvl7jd31/qd0W/QvMkucrRJxcz6iKDoVsGtbMxuFIo4M8YQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TWYiKj1v9skZopvMgCoh4nulmfHARZA6J/VFo/hpWhk=; b=lKwjz2rFTAufM7VOFXnk09PEV2BWOkJFwME4XUgoZaV3Nvb7K566HzMyh4u6oAj6C8AAKN9QPxYswUdIRc6cWSHsTW2KpG+ygc7NDEkAH+fvFOd0iHD78UD4ugxPkwZJX+WU7cmKEFAiPNM5V+CFyOsKVFjXsB2DdZ43t92geT+L+TYpYxs08I0u7ihm2HJygO1OpaTJFsRSf1+kUwRXU/ucctM6G9i8g+l5QQg1A2NBsY0aGJFzChRU/H7cc+mwFFK1P61pz7AGGaed7uaLAApoZHDCVdnqtfkCrNN4L9w0uU4kVWS4n5Jvrb/0jr7nqE1QuZOSdQR0x5lXCRIVIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <44a6e983-59e1-b60d-c86f-db2a1747ddf7@suse.com> Date: Mon, 18 Jul 2022 12:48:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Juergen Gross , Dario Faggioli , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-6-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-6-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0116.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::20) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ac8d889d-8b3a-4590-0519-08da68ab04b8 X-MS-TrafficTypeDiagnostic: AS1PR04MB9653:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NNO7W8lnnxlgI3f6RO7WSsnP/ld55lypUQBlQmUzIuS/EJXSWI4Y9k8v3cQW69Jh6KcGRFRPKsYjG0KK9/NLDMQZBwOzhfDmIv3ciR14Kxna8MOwLzepmiwiVBWcXxsMAORzrtw4eMDBHPgKq4dHDdPJRVLUtUfc6BQGiLcCQp1L8fCSbLrPKAEHOtH4qkIDeGqYYxnnhKt8kplsN23NBD1bTmj8s0veAMa6c//Dn55XkdwG4/nwNd5QwZe5/0gersZ1CMo77KgIkk8uectstFE9Lw+LsrNT7BXkQWwF0k90EZyRyx8NP6yqqFc5atCWyIGuDNHNdbUknz5V1qKqYufa4Yddd3+KkDm7XwoH6RCqjFOQD5pLhqL2RjSBq78vGrn17zyDaB8NPvq1UzYfJ4RQXyI0Ivkwm4tAnEQPY4H7l4sHE0UP3flt3CSMJenetI2RBGY1bIYOszCDoa8Pn+sG2Drlq6TnfVNsiuHIDiIoR7JtQ/BKQYl71zyVIefvFSCQFQV4O8T1fTo+hI9KbLVK6HNMAVi9IlUQyf9v6stVj+ghxpfUPvN/cVhl9Jm8WyLXqQQwgsqyw6OTA/FaDC0HVOXIt7OfJMvammd8tpCY+DJSdgaD1Y+RypsN0LgXaoU6WOBtR5jMOvnvI5siu6pwzxbAAPuJ5dE+ww17cw6HTzGqy7GaowDQpHGU6Lyw14G+1GttpmtpVbsxZ5nPyW154pCth+F55x3wa+sPEszcavPX+osSOg7Ov5PtSeQSJcjOMw56qo0VDFOOa9CXle98ApBwXB8QJlMflL+uIGTLWsMDRw74CpOk5fK+ZvH0sW8+WDnetZUYfDp4uuUFjqJXgjZoK8rVbnm5vTbrZ1g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(136003)(39860400002)(366004)(346002)(8936002)(5660300002)(31686004)(4744005)(2906002)(86362001)(6916009)(31696002)(54906003)(8676002)(4326008)(66556008)(316002)(36756003)(6512007)(53546011)(6506007)(26005)(6486002)(41300700001)(2616005)(186003)(478600001)(83380400001)(38100700002)(66946007)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZGdzbFlLWXdDSW9vM2haa1pwbldUbDJvMkhqZWJPcTlZQzBzc3FiMXMzNjkw?= =?utf-8?B?U0NCRGNBQ2YzdC90dWhhWjN2STVLWUZIZThLR2FNbjJuV0ZubDlYWTNndlJG?= =?utf-8?B?YlJ5ZFhHY2JKQVN2M0VtMnRFMTRCMTBQekxJVEFyMDZVeGNPd1M4RjRmdlJs?= =?utf-8?B?alJtSGNST2ZUTkRWODhGUStlZmdLdWhSTWJTRlBlNENQK1hrVnNTdjUxKzc5?= =?utf-8?B?UGU0L2JMYk9xQllnTnBXMlFUNSs5eXdwL2JuMm1OVnZwWjFjZWFNd1dIVmtH?= =?utf-8?B?V3MxVUY4cVNwSUdxWTZGZnRwallCME5ROWx1d3ZOcDV4TE8rV3IzTHV1ZzZT?= =?utf-8?B?T1hzM2JER3RUaHNQMmxKWUZvcTIvYVNYcDkwVlVPdHlvR3d1cDlRRzduVjFK?= =?utf-8?B?czZpaWhjdGFyb1h6UW1wOC8zVWZTR1pJZEJ4OGRTQ3Nia3RaTklGNjJaaDhl?= =?utf-8?B?bkNmbWJjN2pvVkVUeGJVUklmeG9WTWd3ZEltTEd2VWZzWlp0STZvSDhucUZy?= =?utf-8?B?eHJCUklmaWlMNng1aUljVW4yZjIzOVVPcnRmR2hQcXpvczE5OFlEb0hYZ2JI?= =?utf-8?B?cEZ5ZVBqaWZYWTZXUFduRFVlMUtkaVFhSWs5c3d1Z1FtcTBBd0ZqU1RrR2hH?= =?utf-8?B?SXBxNkVadGF2dTdLT3B2STUxNms3RWU0UE5GWkhCY0JZcVNESjJIdGFvZTl5?= =?utf-8?B?YmJXazVrVTc2Z0wzS1lHUTIwWXl1V1E3Zk9uTndOeEpvTWNXeWRkWUpRR0M1?= =?utf-8?B?NDY5QkFkb2ZUMnFJTGFSaGdOeVFMVjlyU0N1bkFCNWFSN1BoY2xYUmVOQ1BQ?= =?utf-8?B?eHRTd0hMOFpBcnB1dm1FeXZHZ1o5aUZwdWJpYnRLUnFoWThSM0tNRFRleFR3?= =?utf-8?B?emdYNGJRUE5PT1M5VGFieHFYM0ZqVXFBQlc1a1NQSDEyS2pMSnB0aEE5Q0o5?= =?utf-8?B?K0hnT2tSdU1RM0hheFdteDV1MmtCc3o0cC83a3V5TWNWeVBiZnd2eS8xWnl2?= =?utf-8?B?NDR3TWsvaHRhNU0xd3QvUHk3OFRvOGZOOFhxYlRUM2xWc0E4TTVNb2xSMDBH?= =?utf-8?B?TDVkZGdnb3VWZWhCWENVY29JU0ptSXNHK3NXdk8yZHM2M0h3VG1YRURFdUxI?= =?utf-8?B?L2pSZXhNUTMvci9rTk9lT2R3cnNzSU1WcWRoNEdqU2kyTXZTRkYwNm5Ic0t3?= =?utf-8?B?YkZWTVk5Z0dqODMxVzhUcDkraXBLNVgvQno4dUFkYWIyS2xCSHYvMlFpMjZN?= =?utf-8?B?YkE0RnhNTEVQQzIzcFlQTVBKVjZxNEp5bnZzUThTYmk3ZVhaVmtqaEZZQ2JT?= =?utf-8?B?MU5uK1BDZWpzaEVPYWFSUGJNYm1aT3g4d3kydDYvdy9XRDZ2MkJLekM4Z2hT?= =?utf-8?B?ZGFtdjh1ZHNsc0hiMUF4RU1nVWRqZG5SR29WQjVnU3dYUzNJUWVUWElQL1pK?= =?utf-8?B?ZHhWZnVDOENWMGdqTEYydm12V2lETDY4MGw5ZXVDRnlCWFB0RnEwMm5ETW1j?= =?utf-8?B?a0t5TXVMSWpPZlVyRXJGTzJsZXg5Ui9rWC9FUnhEaWJJWDkyVmFzYVZNS1Y2?= =?utf-8?B?M0VScUpCL0ZLekd6ekhQYUd5REhrb3dmeDFaa281UlJBbWI1aEc2MWlSMExD?= =?utf-8?B?UjBYcmNlYkpaSytWeFBxYnAvRFJQbWpmVEQ1K0VaU08rZG1tcU9DM1p5RVAr?= =?utf-8?B?a3V0UjJXTXp3WFBIc25HYkNrcm5VWWZuQ0E5d1ppandPSDVLVTIzZTBSNGtu?= =?utf-8?B?MVVOcUN0QWF0N1YrUWFjb3lDSDM3OXY2Mmk4by9URUwrQjVlaHUwNkQzbGg1?= =?utf-8?B?MzcrbzNRbnVWSzEyQmlxakdWejIybzU2b3o0TklsNVdlT3RHNDFjbW1oQzhn?= =?utf-8?B?ZGlrb2k1dmxjZGFWb0ovWXVGMHNTWWV4d01SSHRTKzJHbnVkYTYxbjBjSVRS?= =?utf-8?B?L1ZyM0M2N0g2UmlXQ1Bnb1dOQlB6aHJRRXNLNUhYUkRabDV2cm5oQVpVSWtB?= =?utf-8?B?WGZycytxTmZseEYvcG9KZEdPRGJtaGZZbVhlS2RDTWYwV1RJMVUwV1BTSjNE?= =?utf-8?B?SytKRzZuc3ZZb2VqSWFqdTdVQ1d2ZlgzNHEybkJZUWNFekNhZGVLbTZDSWVo?= =?utf-8?Q?zE94Weem+zqIG8Fm9OSwwER42?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac8d889d-8b3a-4590-0519-08da68ab04b8 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:48:15.5617 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pXMqTVQy6TlwLh1HN6iQF+w1w+kG+LlV7aA9oeySUYB19zzY7X87cdvVkywQ27WHh6p5xUNyyiFqj4g5aB1RSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9653 On 18.07.2022 09:18, Andrew Cooper wrote: > With the waitqueue logic updated to not use an absolute stack pointer > reference, the vCPU can safely be resumed anywhere. > > Remove VCPU_AFFINITY_WAIT completely, getting rid of two domain crashes, I understand you mean two domain_crash() invocations here, but ... > and a > logical corner case where resetting the vcpu with an oustanding waitqueue > would crash the domain. ... some other domain crash here? > Signed-off-by: Andrew Cooper I assume you've checked thoroughly that calling code hasn't grown dependencies on execution coming back on the same CPU? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:49:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:49:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369584.601015 (Exim 4.92) (envelope-from ) id 1oDOK3-0008KQ-Jy; Mon, 18 Jul 2022 10:49:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369584.601015; Mon, 18 Jul 2022 10:49:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOK3-0008KJ-HI; Mon, 18 Jul 2022 10:49:55 +0000 Received: by outflank-mailman (input) for mailman id 369584; Mon, 18 Jul 2022 10:49:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOK2-0008KB-3O for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:49:54 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2056.outbound.protection.outlook.com [40.107.20.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a7966bc-0687-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:49:53 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM5PR04MB3123.eurprd04.prod.outlook.com (2603:10a6:206:4::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.22; Mon, 18 Jul 2022 10:49:51 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:49:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a7966bc-0687-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A57o0BaYKU1zdflGsj7AoP9Qi5GlfOdjnW3N/RanhW3i52w00lcZqLN4db32mBHfQKanbUevVyYYvdtpp33+sArSezl2v+4QQGiSrQsd1pSHbYxria5yZI0Kcr5QfGbmZhTmZ7zrPit3hHdopTnnafGdLBK2ruDG4jGWt2SfHgqmE+H4RHBdz4S3Ci9z17pDnWD0w0z3kZ5IZe4hT3xMwYdZ1X0bdsov736xQaGPl5ZO943m6nCHHA1i92bJ1nm1rIzz4vKg+1Xf1mYOam32spL8iRmxsofWFp/6AO9OYJrKn9jT6wwhLln4UcfGl6rQ3ePQa2CQrEZYuR7eVW5sNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBWRsFZWoZy+aNo07PP8g1OPAChz3TVdvcqm3dh3xbk=; b=eTXPRAUmDBKYmyWV+JBDGeK89qJ1M/tDAhguPAqiE6idTZYjraGC6GiehEeM96qdaKy98FA6u8xsEnxbCAO8Q6Y+dGCoCzVV/E6gzNcGnjoxrYk2lQz41ywbQm3M2CLxbdhvlS7ymEJs+drQvxntbXLFY/5y3IH/uR+1kPaSYKrYm4Z9tWAkMHWrpg1hfjZnuT+RDB/Y93XoMWIpIOFNfNBWWXVuLGgSebfO6g15V1fLLtRqJw6VSxsMSrEWMdNg0RZDAJJ43sJzdJZ3pcOpl965yJrrD2MTRUahl5AgxrA3qZ+LNO8TtgguXlBDf3KAhUDg14uCQO842wzy96ry5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBWRsFZWoZy+aNo07PP8g1OPAChz3TVdvcqm3dh3xbk=; b=bh/gxMaMrlc2J68/BROrgt4i4+btkFHxhVKrZ18zkWH9BdIKwBQ/lHGVApDuYP0oGODS2YzGLitax3eKe5EEJQ8wz0FWIUy8Ced0oMoaORQlbG54hA5UVYxHttes3cvcOZGmhy2h2yZ1YAJsmj0DptS2Oiox+DLQNXvEKPMSOtFqj4x30QqfnnFadBIg+fbO4m5foCG8sgbV2/ujNa+8b3Ygd2X7F5TBYkHlfqF85w9EXhv6PmlaVrCg5083ottZnNJQjr3JJr/n2gH1FS0IFTvp0vBKd6ioccXD1DLbLi9vEEGQnkt20ol5DoH+fztb8A9WNmmKsiUKttftEBU0TA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <384fbde7-1aec-88be-7127-61b1f0195b0c@suse.com> Date: Mon, 18 Jul 2022 12:49:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/5] xen/wait: Extend the description of how this logic actually works Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-3-andrew.cooper3@citrix.com> <40b1ab24-5e94-ea2b-c9cc-6efa5418d283@suse.com> <347aef21-e6e3-3ab3-f230-4e01339c742d@citrix.com> From: Jan Beulich In-Reply-To: <347aef21-e6e3-3ab3-f230-4e01339c742d@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0009.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::14) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 905cedd8-5c20-45e9-c7fc-08da68ab3dac X-MS-TrafficTypeDiagnostic: AM5PR04MB3123:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: R3hGmtAioXUd3ysjG+OyRlnk75FGYuYZeZZbuc+o2FiL0+lW8I/uxeKMxqxN8FIJLTMFO6waA/TA9YZfLCrrO6P2JxhZnAA7RiTGm+JmHpdQtB3sdXk1461kDUuE5ylH2chfVEc4QNaaIJYIftdwOrPBpXmUzOw6Kd8CX4qAcagebHFOx+/Y9YR0C8QHDs3LMRACa8yhhW7zWSekTu3mmb6dnnshoCKyjfaDzvtDGVlrrr9C/eKGWgzXisoZqZZX6yNgEUTYr7J4g4f4kNsP+1RCD3C+hZhjYRFyhouPI3XVvv2ydbamoAG9LevauPpNQQh9ZmZYSdMP52DcvUWyAWutiPQfN1mv/GhKY5Yv6hN6ZX1kY1nj94tCAqfgo+8mgy7F6dfEFZdwlaRTvLK35V3lEQAJdgtoYQRCmzcz8hQwg96XfqWC5kgIHMoaidcWrrhuZ81spKJiNpQDzd1T6NgG7L0Nn06CR6dIcMpxnZcyhhDXTsSR5eDHFR1HbbasDGDZS7kRuMnyJ4TweHictOAhVDaaGMjPdoRjtErjvjNx65BGxUZpsENpUF3qFQalA8kC8SExlJX6tEC4uQOqojxV6MzXKdFkwtK8Ga+4hBgXFbX99HN/Ier3AN/ygztSMwK7NrCJHdg/4mk3OC6dKMibQ/l3Wg7pyeVCqMAEongk+VcRRKUeJApHSh0pOyBZOr4mHX4arv+JVzsAmFxo63YLfoOjR5PaJplXk0BZX6O/XHIoYgFcq2zN1vuBaHQvYjB8h4JeJQwgUBr36zhiHaRTCnuqvMH6/GEoNZ6UsrukzOKDw5xaX0SiGfkdUJLvVYETBv7jgSg3ZktHVtPZ7cNqhyegoMusPpq88hHhTVs= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(39860400002)(346002)(396003)(6486002)(41300700001)(31696002)(6506007)(2616005)(6512007)(26005)(478600001)(186003)(53546011)(38100700002)(83380400001)(4326008)(2906002)(31686004)(8936002)(86362001)(5660300002)(66556008)(66476007)(8676002)(66946007)(36756003)(54906003)(316002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dlF5M21RN0sva0VaTHVxNldXMTVrM0dtOHRCY2ZLZmdWY0J6eU9YT0o1YzRx?= =?utf-8?B?QzJoYXk0YVpwYkx0TGl2VllKMUdEMGoxYUk2bVJYazlOV05WV25ma2tBaG5X?= =?utf-8?B?ZW55MUs0bHo4cDJuNEpQZjU5U0ZyR3lSeXZUZFd0cnhRNHdxTnRQOU05UlJw?= =?utf-8?B?L01RYkIwVkYzdmh6aGQ2OFhVb0pWVlpKdjcrYU9mQlBkdmovaEtWTkNlYzBJ?= =?utf-8?B?WE13eHJyZGxQamVibFg2WW9JNm5lcWZKbGtyT2F2dmhZTlpQWFFLYUtiUGVO?= =?utf-8?B?VkxPQUUwbHpmTVpZU1JrWUlmQk9yNzNqSHJLSjZzVStLRndmTzhudkNQYVh3?= =?utf-8?B?dkZrR29id2xuYy90UGh0RFBZekFjWDhnNFJIN2hpcVpmTXBlTE5qUkJFZ3Rq?= =?utf-8?B?VmhLYTNudEUzR3RKY1BKSk1wcHRpWGkxUXM0TEFZNytmSjNCMEUzLzZleHJT?= =?utf-8?B?akNFTm9LT1RSRmpqdFdrdTFDLzFScVloNEJlcXF4WUovRmo2L2lxdTRFaEU3?= =?utf-8?B?bDc5UzdkVnl6MWtRbjZlZzJTQWtoVjZXWnhqd3gvd3l6Sys5VHNxR01RTHB5?= =?utf-8?B?dkh0K04zNFRQb0I4M3BRNHg3QWZyWFhwSXcwWTFCTWtYVGRQRVZ3TWwzKzJI?= =?utf-8?B?Nnp4TUM3bjMwNldsbGNxNHdzdFpmVW1xMWt2b3duekNqelhoY09PeUJZT2VQ?= =?utf-8?B?WExGckNkRFJnNjdTeUVjV2htbHJEeTJ6YnJJY2VscDJIbXZwTUZCTkdkRHRL?= =?utf-8?B?LzlIbmhtNlRkQk8vdFBoekRIMDVsNzNZdEVrMEJZZkdNK1hXSEJXWjRsU3B5?= =?utf-8?B?ZVVjS3VBNXdsWUkwNWpKTHBrazdsNkZZcjJXOUw1QktCMnVmYktnOEZlWVJW?= =?utf-8?B?dHpjdnNDeXJFd2sycXg2Qjg3aVFHWkN4MUhoeVhIWDI3S0s0dDZnaDFwWUNj?= =?utf-8?B?Nkl3UG93OHEvdys3dGlnRld3OXhXQk9lN3Vzdk1EbiszS0VOYW5EcHU2b3BI?= =?utf-8?B?Rmh1TkxGbHZUNkVqT3kzYzdmeDBud1JUNlVWdndKV0J3aUFJbWdQVnZQd1Yv?= =?utf-8?B?bWhUKzJ4RStNOTQ1TDJYeVpSdkIyeUtDL1FycFpRMHBtR1Y5ZW5tL0VPRWlq?= =?utf-8?B?bU03VVVZMFF0MVE0eU0vN1VON2tDSnA5WkFaM1NtQ2kyL2FNMzFldGJ3VTE5?= =?utf-8?B?eHV1NW9rYVdDR3VWTHFidVNJVW1zY3dnN1VxOUtDMXZEOE10cnUwTnUyRHo5?= =?utf-8?B?UE55dzlYcmZ3VzA3RHdjZjBXOWo5RlhGQ29lbENoNXZEanUrOVB2N2pOOU1p?= =?utf-8?B?VXVyRkdYODE2NWQ1TFp5clVGMjNBNW0rd053Q2J2dElCeXNucE85NUNVaTFl?= =?utf-8?B?aktrZGRybW9xOW5ZZGVrRDQ4dDJLTWpLeUVqTFMrbUk2WjdidGtWVVQ4RFBJ?= =?utf-8?B?cjkxeitqUlVxSEpySEhROGFnNjFvRDc0U3UxQUNKOW45WFI0Q0JFbEdNNWVP?= =?utf-8?B?UVJYVDE4Um80U1YvenZSbmc0RHBodHUyaGZraFJielBTL2lYdHVzTFFuc1JE?= =?utf-8?B?Ym44dllGSkhiQU5Oem5rSUFHaDJuem5ZQUVhRjJ0bXVpQzhkbUFwL01tY0NZ?= =?utf-8?B?N0xlczNLRzJ1MlhrMUR5Qm16QWt0bE5BcTdRMHQ0WUNoZTcxS2FGamptTkdG?= =?utf-8?B?OUtZYWlWV0ZnQVlaRXMrbklTZkdsUW1TZ2U5OXNDV1pyRHdYWVp0WnM1SThz?= =?utf-8?B?ZUlyYU1ZQ2wvZXRiZEVOZzhMckNadm1mald0aGQyRyswK2l6RHU1NWZBWFJo?= =?utf-8?B?aVpaMDRuY05ZaitqeGorUGFNVUFUZm9QZmtvQzFReXhnQ3JtNGVlbXlHSk9h?= =?utf-8?B?a2VvaTBObHIra3h4MkM4TzkrMVBvWWlCQ0Fja0VBbTlFK0VnRVJTeDVJWWlH?= =?utf-8?B?MHVmbGx0eU82UUd0WDd0NS9nbVNncHN1U2RUakl2bEcyQ3cyQ0JpQUtxd1l5?= =?utf-8?B?aVVDUEtsVXpnaDREaE5RRXdRTGFyQmU5YnVBRmJQWVYxbkFaUFZGRCtBWTlv?= =?utf-8?B?bjJFNEJFYWwyYW1GNVprcFNLRlB4WVNhMHA5NGtpR21zMmQzcm96NTgxMmx3?= =?utf-8?Q?EEQJkGOLq8TSp/0z39jVuf1Rm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 905cedd8-5c20-45e9-c7fc-08da68ab3dac X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:49:51.1026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xT4ANC3Qa/+edAEc/OQ4BGXxYKTRmZH1SDt5LwTQk8LuTFpO/LUrE+jgCvbqNimFo8sJOmjSOe/7E3R31VL9Xw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3123 On 18.07.2022 12:11, Andrew Cooper wrote: > On 18/07/2022 11:00, Jan Beulich wrote: >> On 18.07.2022 09:18, Andrew Cooper wrote: >>> @@ -199,9 +211,18 @@ void check_wakeup_from_wait(void) >>> } >>> >>> /* >>> - * Hand-rolled longjmp(). Returns to __prepare_to_wait(), and lands on a >>> - * `rep movs` instruction. All other GPRs are restored from the stack, so >>> - * are available for use here. >>> + * Hand-rolled longjmp(). >>> + * >>> + * check_wakeup_from_wait() is always called with a shallow stack, >>> + * immediately after the vCPU has been rescheduled. >>> + * >>> + * Adjust %rsp to be the correct depth for the (deeper) stack we want to >>> + * restore, then prepare %rsi, %rdi and %rcx such that when we intercept >>> + * the rep movs in __prepare_to_wait(), it copies from wqv->stack over the >>> + * active stack. >> I'm struggling with the use of "intercept" here, but I guess that's just >> because I'm not a native speaker. > > "intercept" is the same terminology used in the middle of > __prepare_to_wait()'s block. > > It's because we have a weird setup where this is (now) a noreturn > function merging into the middle of a function which already executed once. > > I'm happy to change it if it's unclear, but I can't think of a better > description. "... when we go back to ..."? (But I'm not meaning to insist on a wording change.) Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:51:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:51:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369590.601027 (Exim 4.92) (envelope-from ) id 1oDOLx-0001HP-W5; Mon, 18 Jul 2022 10:51:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369590.601027; Mon, 18 Jul 2022 10:51:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOLx-0001HI-T3; Mon, 18 Jul 2022 10:51:53 +0000 Received: by outflank-mailman (input) for mailman id 369590; Mon, 18 Jul 2022 10:51:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOLw-0001HC-Mz for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:51:52 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50081.outbound.protection.outlook.com [40.107.5.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a13971f6-0687-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:51:51 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR0402MB3539.eurprd04.prod.outlook.com (2603:10a6:208:1b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:51:49 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:51:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a13971f6-0687-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hly1XXVfpgSI4EAizWCtgT9YeG/6lV2ts3U0MmRFC1JmIIkcb+nj+aQ//+35XHdw6RcWoOl23F6/QltMgPCpTZnLwV8CB3ub58Bcj1ccGYaNGkETOHFMO1IdH08OkUg9vUAir61HJHV2S+k6rZNskfZW6W+AWfhgu5SJ2rBMrmtZeKwDzAkWQehR0UsvnU4bRo1MQ52wYk4aHICjoMqNLU0cDpPo9STrgz1FyqeTAK+nPOBfLIPBdczH/KrSrigWdtH5rm7wH/wa8JlFXWJJtBQS8BIPyh481UqkGlrAeaoWh40EpWYZFv+0wXWDbrWkQVbfCX8ot3MFhHB7LCuP6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFNdLlH9fkGFBzJpML3y3pKzJtzrXnf0vuGbLwFVDZQ=; b=c2WY11P7fY8AAXCBoOm16FdZsH5YtfbhimhEIyHEspriTNUg69jB6fU+A64+G6DkiGfSE6yfL0y2WbmNDpomHHSSfchVSpwetDzotdu6cOcq4W6UB5MMwtl9nLqRMQLAeetlwqb1YMv/Y8qAgX27pjSy8nCNSMt6m4OGRfhY1JHiMvUKfUMjlOmIuzt7Rqh+/BBl2eRVy3xljYbK6sberazrYw822lhZtf4Yh0886qc3+97skmrs3mTDDsVZ0znCRHmjO+QkHQJMKTX9b1i1efUwM2A9v7GQJVqkK2MSlDHlK2mYYJtQT4sluzXqpGytA+DtEQ1CS+BBNUk5DmGwYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFNdLlH9fkGFBzJpML3y3pKzJtzrXnf0vuGbLwFVDZQ=; b=Nt+x9wdl/tyb68JL40G6DX+gOQctsozLCdiwK/PSSzTOzkHotNZTMtkbmNsakM8Aa/jklaoHXzdG/W/ti9gGLSpJMTRafU9DsXy45O6Hy0Usj7oikYZEXPdKVbCX2spx9dFI9UIgDde4r0rhqks2rQb70sYdSq+MvkJ6FdkrrXrM+vvYQ7j0S3q9y6eaKaiufAd9d53nqd3ABe5dbhkvxo1c1h+gC9/CsSz7QrgPmbWE43qmXtnfaodtMG/RcP1W53DvvHavxEDYVnevVoFltoZxyYNbUzVOMJ8T1jCHyJpZvaXMfe8ZSe/pPY5sCDepQWnJID5mKREo6QcjRTbh/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 12:51:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/5] xen/wait: Use relative stack adjustments Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Xen-devel References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-5-andrew.cooper3@citrix.com> <68555ada-e769-9565-4224-b543c9e71098@suse.com> <45bec79b-f065-eb98-b4a3-3be6d4b7e674@citrix.com> From: Jan Beulich In-Reply-To: <45bec79b-f065-eb98-b4a3-3be6d4b7e674@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8P189CA0001.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:31f::10) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bed9666c-58e5-4e36-741b-08da68ab8454 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3539:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xhaN23jKwh6qFcmP3l/246Wa6LOlLHiyhV0Roh4Uc5N3rg3oZNlSCCDW1syIgxUpbi7tB0vihzhg7kVWjjH4Ijg7D/DFLYJs5CDNshyHIGt/A3uOUxsMmi6AnzbHAftmS+gAoYhnIiA41jLol7sUfignM0mgIaBqvkj1C8xjaVLJ1A5prkcaS+rQNj9rP5jX+Pktn5wvhvqZK/akS7r5g7WKc3tAMVIuPMT8E71D7xob63m+xuj877Nc9nalHP41amNPI/aVnOGBWHCEUtuGcGezjqXKN/SJgUJlRqqboKPQ51HY52qndtwt+wpXDMcoqmPIAT+P4lF/J14QFDV8eKJFvNmXMW45d13oQTcGw4LF7wHkbV5UOyU8LJNbfNpyzyPnwKGrGCNdBXUDwNodLnSHOiIGNAawIpiEB2lGIITm74vXI0YV9eY6wlhopjGDpCMRJWOhgSaxyivujrdPWV8ZyJDcQ/U+gd2h4VrQUBJmmdaLO7EWM/dQ0Yth/mezzZ9y51yBkwdljZWiV08VfnkxR+ty6v/DNdsilE/VknhJAYKGJ4rmvyTJTR33Be3GPhNH89KyUVXZczkHGX7tYSpdhaZPsu1+3kBbLiMApghDmqP5OLBTzp0xz3jetJh1C30qV92HgNZqYeu6GAsONCnIX0JIof2l5YJrw+gkdulATRfrvNgyqwWbsj2fBvbneaHXzJemr8LEz9sWxata5bbGqpNroWcc+GtsWSzCdurl/mLmASCDItB4huzNhpAij0CL5PWN0Gk7nrrS/mKDGyXS2/Pm787T0G1QFiiIP+xWluPFeTttG9ZIWXKeGMboM8fXkYSb0M+4ytQrAcbtOTctLRRZDHCp0RmwpPeJvWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(376002)(396003)(346002)(136003)(8936002)(86362001)(38100700002)(4326008)(8676002)(66556008)(66946007)(66476007)(31696002)(316002)(54906003)(6916009)(53546011)(6506007)(36756003)(26005)(31686004)(83380400001)(41300700001)(2616005)(186003)(478600001)(6512007)(5660300002)(6486002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDZXYkhuMno4cTRTWjJIM0FLRE4wellzWHNWOXJFKzVYalIySmFqa1ZLVmFi?= =?utf-8?B?VmhLTHl6VFpDOG4rY2FaRmgySDMwQ1hPSlRmMVFkK1hSL2JnaFJwY01Oc3J4?= =?utf-8?B?Yk54WXhKRjd2WHllZjhraVpiNlFCckhKZHRVQUx2aTRSMXdKUkZCTkY4QlMr?= =?utf-8?B?U2IzVTI1bkZyWTVPdkxCSGxrL2Zac0NTaDAvWVg1Uy9WY2M2VFNlTFpXRWZK?= =?utf-8?B?ZFVvM3E3azR0WFJUcDRLdnp0NkNMK1o3eGlEZm82aG5BYjFieldacW0rTGVh?= =?utf-8?B?VUZrdWFodHVycUFqZkFNQVlUTXZiblNzb1U3b3dFTU1zWE1WalZoMUZ0ZVNC?= =?utf-8?B?Qnd5QUtud2QyYy9wSUFQcTR1c2tENFA0WURFRXRhcHpreXpMVjJscUY3V1Nx?= =?utf-8?B?TDFiKytxQWlUQmhKU2xiUmNFSHE0NnNyakw1QXBMc3R6VWZDSlpudG9nRVBu?= =?utf-8?B?ODlEdTU0WFZXMWdtQ3YwOG9wNEFHOFlHYXphVm1lTUZyS29BcU1sL0V3ejUv?= =?utf-8?B?WGx6bWhjdGpaZkVOT0w1ZkxGWjNaWXVSSUgwOHY3aEZhOStUUlFVclVnTHVv?= =?utf-8?B?UlZpWG5NaW5LNkU4NEUzMEphWGlIVFR4U29PK2ZEZVFZM2pmTElMZDd4T0g3?= =?utf-8?B?QlVwaVZFYVF5THBDZEY3SzUzaHJKU0N3ekVzVk9iK21SdE9KcnQrLzgrcHZO?= =?utf-8?B?cGlCcS9FLzBuYmRxZEFjUTkwRFBoOGVXZGFzTGRXZkJUZkN0T0RaSDRkSmVI?= =?utf-8?B?QXZLVytGVlNoZUZYaDZhV3UzVC9YUTdZOFNlN1NzbHJ2RGdBZnZvU0U5dUtZ?= =?utf-8?B?NlhhUWxvaXdZUjVjVGpLRXFVd3NhMk1VZXhVYkZlZFBscGQrNWJodThXVXla?= =?utf-8?B?UTNDanJTbG1VaWExZUFYbjNScDlrSmtOMmI4OVBma29iNEZVM2d5UEx0a2ho?= =?utf-8?B?cDNpMUtGQUd3d0lnRDlUcVY1anhXUXQrRy9XczNmSXoxelBybm80VkM3ZW9z?= =?utf-8?B?VG92aS95QW4yaVBWaENXM0RUQTRwaXZhTVM3cHNOclc5L2RwTHllSmtHcDR2?= =?utf-8?B?WmMzdXZ4NGYzZ0RsL0lDcC9JcUF1aTRCbUhjYnVvKy80bkxjSnJqSndpYVRY?= =?utf-8?B?Q1F2YjFROWp4U0VvcUFheTJ2WENxNVB5UXhvTExMVGgvM3FybFBWZSs4REo0?= =?utf-8?B?WkpJSFB2YnVwTms0OU5lVVlualFScW5Vbms2VjVvUXRCV3hIdG43TDlPdGNr?= =?utf-8?B?aWdubTlWWDRMSC9LNkZrSHJ2T1EybjUyVi9aVUI5eFEzOVN1b0VqM0YwM3dM?= =?utf-8?B?dEpHOEJWc2N1ZHZpQU5ROUk5Y2RXWWVSVVI2T1FiRjNFNk91RHk3OHpCblFx?= =?utf-8?B?Skhjd2pYNHl1ZTNOTDc1QzdCbzF4WXNvdW1UQkM2SnJQbmMyV2dSMy83cjRh?= =?utf-8?B?cU1HdjFEZVRuQUxiM2cvZm9DQWd6aUVsbjBWUVdsUS9QUlhoYmY2c01JclFq?= =?utf-8?B?VHJ4dkRXc2dtbCszRkxCTW5jdDY3WlZGRmhDMDJRdXpHQTVFNDMrdEppNU5n?= =?utf-8?B?R290UUdpQStFVW84Zjl5a1dYaU56N3ZLaWhoczNidDIrR1BsNDR0VGhmUHFM?= =?utf-8?B?ZlIxOXRIRnBabnVMME56VWpEMlJiL1RLNDBmWUk1N0hJd3FJcU9wMUFzamZU?= =?utf-8?B?TW9uRms5bzd4cDBtMmdTYjZCN0hKb25GM1Z4T0xQUHJhWW40dXFpczFGY3N2?= =?utf-8?B?bi9NVHc0Kzc1NU1zSzhYeHpOMlhPSmNMTXJiVE5TSXJWbDNRU3NLK2MrcjRW?= =?utf-8?B?Q2dRUlVEazJBOUFZZXJtK0hYaEEzTXkyWjVheTUyMXpEajliTFZvT2N4ZFFQ?= =?utf-8?B?aVQxMmExeGg5SkNFYklMMnlEcEV3N3o2dGNGK1Y5aDZ3ZFhqdmJQYmlrZGRJ?= =?utf-8?B?M3FBWTZiYnpqbzdnVE5CS3AxdWpNS2Yxdk5Qa2RYV0NzUHZVdURBQ0tZL3pq?= =?utf-8?B?MzM2cUVmb0hCOVV1cmMyMVRvTjZJNW90UUpicHF6eEpKemhjaG5nbklMYUJl?= =?utf-8?B?emdHWVBsQWVQQy8xS2NtOWphYjZRYlJadEQyd1NaTzZENEVXTU1yVi9JZUxj?= =?utf-8?Q?a9181PBPFbRDtTk3D9YqVylG0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bed9666c-58e5-4e36-741b-08da68ab8454 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:51:49.6576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YVIv0AjddT81LsOuYuqLYWfB33hLY+1WOze9dQbOG+WzG2jTLnRGEjxVDL3+c/PguAk7PNgEBQ4eEJaTj59e2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3539 On 18.07.2022 12:41, Andrew Cooper wrote: > On 18/07/2022 11:29, Jan Beulich wrote: >> On 18.07.2022 09:18, Andrew Cooper wrote: >>> - "mov %%rsp,%%rsi;" >>> + >>> + "mov %%ecx, %%eax;" >>> + "mov %%rsp, %%rsi;" /* Copy from the stack, into wqv->stack */ >>> >>> /* check_wakeup_from_wait() longjmp()'s to this point. */ >>> ".L_wq_resume: rep movsb;" >>> - "mov %%rsp,%%rsi;" >>> >>> ".L_skip:" >>> "pop %%r15; pop %%r14; pop %%r13;" >>> "pop %%r12; pop %%rbp; pop %%rbx;" >>> - : "=&S" (wqv->esp), "=&c" (dummy), "=&D" (dummy) >>> - : "0" (0), "1" (cpu_info), "2" (wqv->stack), >>> + : "=a" (used), "=D" (dummy), "=c" (dummy), "=&S" (dummy) >> You can't validly drop & from =D and =c. > > On the contrary, GCC demands it. > > & is only relevant, and only permitted, when there is not an explicit > input tied to the same register. > > When there is an explicit input tied to the same register, of course it > can't be reused for another input before being used as an output. Oh, sorry - I neglected to take into account this adding of inputs. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:54:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:54:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369596.601038 (Exim 4.92) (envelope-from ) id 1oDOO2-0001sB-Dw; Mon, 18 Jul 2022 10:54:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369596.601038; Mon, 18 Jul 2022 10:54:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOO2-0001s4-9E; Mon, 18 Jul 2022 10:54:02 +0000 Received: by outflank-mailman (input) for mailman id 369596; Mon, 18 Jul 2022 10:54:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOO1-0001rt-PU for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:54:01 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id edfbcf0e-0687-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 12:54:00 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id BDD355C00B0; Mon, 18 Jul 2022 06:53:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 06:53:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 06:53:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: edfbcf0e-0687-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658141639; x= 1658228039; bh=sQWR+ymapTCFmzQplP+QcaxkiCDXShRilBBu23MQdkk=; b=S Olmy5OsuyHvi2HHMEKNy9KCBc4damsN8BW0aF+QEHj/G1xmo6g0lpj2TVralJkND YOS+t9suUDm0L8n9zCU2aCQ+2I+K1YqUvIBv3iQZmXabqRutNSJWgp+rWUAjkFxc Nhi5ovxHBwE01DAJXiKYV/2Kqi2vitG0Vj8dwa9W9MraLCQBxp9/ePa/qLwrAdDf vYgt7Atve2d9XzfJ+xgYsnQTmwZjt+rNDHEHOWCyFnMmoJG6UuLHn512knwvtm3D ub8spSwIU1dfCukV3saCnCXto7drmCaxAk2MWEdvLcKduO2wZGE0CeoR5gxUtGl/ Im/XdHBLnUUGMPTLGZPJw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658141639; x=1658228039; bh=sQWR+ymapTCFmzQplP+QcaxkiCDX ShRilBBu23MQdkk=; b=FGxUW+lp+3HBB8u+Hz6vHndiuglkSW53AzAl1jehqGUx 5Q7ThY2IC+Lgoj8sG816f2aKaNN8ELOgOZiQMWn/Oq0yMOg/DGI4PRD2w/n7DH/q 9lC03SoEe9Eiu5U82DCk0K3/4S0loDYZPvAkAfM+1GQSe/0SH9bpYCufafv3Qfcl Mj9PYfeuO8QH3sgGWFaL4qlER4EiUhCTTdWfoJKG2vStvPpID1UpYgxBMpQiaCIx rsjjMgATB1zKqr8LnOFy7WztuKcfBG0+psxaLT0Bxfm1KRfNUHwl5uhlKhUgEjGU qdzEpgJ7wNgJeTL900Q04ezl0QaSemRMHhx0bSvzBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 12:53:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Message-ID: References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="q3so7Phe/MZSuiIN" Content-Disposition: inline In-Reply-To: <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> --q3so7Phe/MZSuiIN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 12:53:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > --- a/xen/drivers/passthrough/iommu.c > > +++ b/xen/drivers/passthrough/iommu.c > > @@ -651,6 +651,46 @@ bool_t iommu_has_feature(struct domain *d, enum io= mmu_feature feature) > > return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->feat= ures); > > } > > =20 > > +#define MAX_EXTRA_RESERVED_RANGES 20 > > +struct extra_reserved_range { > > + xen_pfn_t start; >=20 > Why not unsigned long? Isn't this the correct type for the page number? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --q3so7Phe/MZSuiIN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVO8QACgkQ24/THMrX 1ywtYgf/XkJOy87gUCbJv6JUZD8O+3QMYQ83kXPLbSS0Ke7O17F6cwL62vDPHNgh rsNNUZJ1twrTinp8ri2aswsMTfibvxOKFySBEDqWtmdb5svthP+a1ktqWUW3ni65 Bha+zWDOPiQbfr7xAVISVk1R5bNclh1dm1bTD+4FXrVRGgt3697edWvD0gTqrSFg 8j6t1a3vIkKMJf9G7NwEtCIAWbP363TzabnJFM0q1q8tIU7OCXi+7j+g0xcXo7aw V3uGdUmbhPszIyCDo7x66WyBSpTBUWUyAieMOgIgB8Id9GBhhq7wTyVkNYXSg7Sp BYpNIVHUFpZCn1EoFuzFzYeheDgwfg== =qVrJ -----END PGP SIGNATURE----- --q3so7Phe/MZSuiIN-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:56:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:56:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369603.601049 (Exim 4.92) (envelope-from ) id 1oDOQ0-0002U4-Ox; Mon, 18 Jul 2022 10:56:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369603.601049; Mon, 18 Jul 2022 10:56:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOQ0-0002Tx-Lm; Mon, 18 Jul 2022 10:56:04 +0000 Received: by outflank-mailman (input) for mailman id 369603; Mon, 18 Jul 2022 10:56:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOPz-0002Tr-Fn for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:56:03 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10051.outbound.protection.outlook.com [40.107.1.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36b1127f-0688-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:56:02 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB8PR04MB6475.eurprd04.prod.outlook.com (2603:10a6:10:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:56:00 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:56:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36b1127f-0688-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frVI2WLFmjoMNjweFpj2TVSNNnPLwa0wT1u+xSn41d402zBY2PzBF7czE835n3ntmY+CL5MDPNWUehd+OqHB+e+OqxhRM4ntYoRDXFPrrYydT9sXhGT69+ioXZlw7Xugc87h9osCo7PvUPlyt3p0AByxQyUSYlMT0B/YN8CjRYbUtHwQG5KFSIklQtUfYbC+5XRF7+B93JevJWJ4HQ0yrkHHhHsDaKKuutItI9buiBJ3OwAJKTjnYuzU56e8jwqiMVNTcFmL9m+qFwBXH6w5MFg9RA4gcurVzNF0FTTny5IvaySR91YXmScGwY0IUvjejLWjzKy+DE27jriicz5bww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5lGpFAMlZVVIdqkRLYieMXmuA70mRMfIRSkHyGO/dmI=; b=FjLqS7UBDvTs2soFDSSk9SP0pA3mQN4UgV4n6TZ3yYUxhtlXEo7gnh51JuAVCUhKl63j9KTRwiUvr3oPR/0lVbOhlOrPKOJ0ZzM54ioK7Ua6hhHpNUgQR5S135nG9sP5nl9kIJwV7vgmhDct/83o5Hago5v7IhiX+9Njh97S3mJ2TZkeUaDodzdndx1i037JNcYi/nU6/XImBhEr3VaItEcafh3eCvzo3tvE53Jmn15BoVyDanPCIvRStRK28JQimSC0ZvUXYqxvCv449L8TVux9dBkuscy3CV9ufggc+UZFs8lGbT3Yk1xg3Gj0AT5OBG+WvfAogYlynHAKjv+lYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5lGpFAMlZVVIdqkRLYieMXmuA70mRMfIRSkHyGO/dmI=; b=DDqJ5lMy7VlUZmnhQEALfn9j7cUKb0xGLpQREvIZ78KBttI8rGtg6PR24DjHTw7IDO8/UdbjyPul+655a8FwzTaUJ1S2BzN7qcm1UHB1b7edgXYBjrjnks0HoAC4Ccbmc3SeWMXyVKrfdYrhXqumGULRxeccHC41iUVx0oSIFbMcv3MB4rHJoHxJ9XylkubK4pmlgMPzIF+gZ9gr7reJIczo2SGe1a8wZvTjTsifNrSiFliNnG3ZdiCD7KMMasEYDJF72n4Tn6WjU0hg1eChwYZTAxynhTpPTwKWFCqymmByC+tQ97w7RyRSp28EzWiik5Hv1VpLnkpnwmOOVFmCyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 12:55:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Connor Davis , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> <5a283b4d-8d1a-52cf-d863-350e2ff39566@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0015.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::20) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e08db31b-7227-4564-bd22-08da68ac19ed X-MS-TrafficTypeDiagnostic: DB8PR04MB6475:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9yL+8J6/YclUE/IDW4QmvO8r1VIBWCjdLnyhbP2m0q5tBOh/0BxFXFzRQjHHdwxe798lzvzq0vd/Sv3iwoIFoYQN8mXJTilIwPxVDUHmOFtVXUpOAZSDJRkREwBcjTCpu98AXjx8eBNXpsmWLj1ACmaKgN5BFylrwlcdhYwXiFPS+lLJVuhLHeBoTd98NO1a5TWOvpY/GgM1fQGvOKFZr3gyzm+ggASgCAI8aiHaM6dgA4Kpdh7PQfUe0XxNh0tpKHTW9yJa/OneCRRM1IxefKLTvvzDWLPcgC4lIF9w6xRa2JYq+gjU6VD62eLaf2gubMyKteABawRFNMJJ1bxhnXMihFj6cnTGsA7O3uAvdT8lIbOfPzAL/TtPYDvrKwKMtUB0AWosu5jTs/nxodXvZSqC1rrrxGMpFuLSzd1iXWTLkjdHaopU6mWsUePM4dVkQkKv2JUDwWzCk+WrFvgH0uB5r3TW4YfRQp7GcU0bjJbt/RuzFXpE/zAkeiB8A6P76fb4PwSX0vbp8/IERCKRviJgjsOsxGgEwzCAJG2znuKMJX76zrVaKiWnyR/ICg+P518cJk01zB4Whd033n5le7wL+PFKOe20YVz4G2OSKY0T5EVRZr6cV1sqO7/hI5E0zEj1FlC0jPpU/FbEE/gDKGEEC52nz46NFDeuLfkOa4dpp8RFV6xMeYgMvsubC7GQl0HHCsUYPmR0rmK69fO8Z42pBeWDvSJcLxslntAUnH/c06cwW6M8K9inZJVf8J62zEHWttDl+LWbXveDxPkc6/mlEWKVaB6CLF0EYVMaFsYVjK4hdmmF3ZUTxt63+cp5J+6uTSa2nk3EExI57ARcZzPGw6cnq8Ep1UpJNcdHj3s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(136003)(376002)(39860400002)(396003)(478600001)(8936002)(66476007)(66946007)(66556008)(86362001)(4326008)(8676002)(31686004)(5660300002)(316002)(6916009)(54906003)(6486002)(36756003)(31696002)(6506007)(53546011)(2906002)(6512007)(26005)(41300700001)(38100700002)(186003)(2616005)(83380400001)(66574015)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXJWMmtQVXZyUU93bEJjc3o2QXVXcDBtMXpZRFlrbU82U3I1QSt4YUY0RVZN?= =?utf-8?B?U0Rpc2E3UHN5dU8rM3VKUXFyYmxjcHlabHhHL2VUSm1RN1V4cGlnd25oT2hy?= =?utf-8?B?THBOTkhQY0l4NSt2WE56Z2xhT1JrSVc5eUY1LzdGU24wVWpPQlZiTXFVL2xF?= =?utf-8?B?QkdpOVRSQW95dDhqRDJHN3c5UTR5SENiK1VVUXhmVVQyR0lxOThScy95MkRM?= =?utf-8?B?QXhoV3o0dXZiUnRXZHU3YjhWVWhmS2Y2NWlHeE05Y01JNzl4SlZFRTk3OWxT?= =?utf-8?B?dmxVWmFJa1dyMUREOUNHNGdKTlhvY3hVREFTZm4vYzlwNVBwMC9ES2tvZzlN?= =?utf-8?B?NExhL0I1VDFneWZ5ditMR3VXdW51VnJpaFkrU2tOWVczei9UamJ4cnZKZk1F?= =?utf-8?B?VG1QSE5sUkIybE01QUxqQklKYXRHMVFaUzZCQjg3VnhwdU5vbm1vc0dvY1JV?= =?utf-8?B?Ly90QSs0dmR0OURFd1p3TW5BWmpScGJsMWtCd1ZpSXY4bzZLakhxeEkvVm5S?= =?utf-8?B?dWhmT2h4bDJJekdjTzNuYTdoTjBxbG1zdnoxQXJWaGY5L25XZXNPRElQRmly?= =?utf-8?B?c1dNL3ltTE9qRWlkQm1LVXFXSVBORVM0WFRCazBucHhNU2dNNk5KQlFzQ3ZI?= =?utf-8?B?SmJEcVpLRlkxSEVsVE1TL29KVnZ3VGhheDhvT3U0cmJVSXFsMityaWNIYVRj?= =?utf-8?B?TWw4SGJaajgvTVBVL09pZmFNUC9jRTZDbmlFSDNmY0RlVDk5UEhuR3RpS3gv?= =?utf-8?B?WUhjUFMxY2tuNHp0Ly9OYjFGamMwYmE1UU5rNEVVNTM2NVYrd3NqMSt1S0xF?= =?utf-8?B?cFVtTUlJZlA1ZS9Va3A1V2tsa2dpVWFmYUFYWVgwemp1OHd3cnk2TE1vSFBr?= =?utf-8?B?aUhMUDdFZTlyMWQ1SmxRNmtjb3lkdGRmcm5iSjdjS05KRUppVVNxcUhZNU80?= =?utf-8?B?Q0k5V0Z6TnVvazljWldnVkZoanV3Q2xUdU9wbVVFWU5FR3Rab3hsTWVEbzJT?= =?utf-8?B?c2VMZWorRlQ1dVF1MnhlalRRVnQ0cGFRZjNxMGpsSkxqZmJXM3dqQWFxdTgv?= =?utf-8?B?M3UrNmlGZkVjRE9iRS9JcFR3T0lJY2MxVjlQQUJhYktmWFh2cGg3Y1VEQnVY?= =?utf-8?B?M0R3TUE5QXFYMjJDMzdZZk5PN2k0NzVHT0dZdEJJeldFRXk3cW9vVE5xbElq?= =?utf-8?B?bE5wTUtNQUFXYi94MG9rbkxRNUFVSHQ1YjI1WGcwb3ZvcUNBaFFuY3FkaU1n?= =?utf-8?B?VjlGNmRRUTl0NkJDUGhKUDliYUllVGtSQkF4a3VGUXRjS3NtNEJEb2JSNUlz?= =?utf-8?B?NXZNais1aGN2Rmt1OTZ0MEZjditVb1BHVnR1RjhmNENheFYvN2l1MnVFMWc1?= =?utf-8?B?eTBmR255ZE40N1FTeGRyV1pVSlM4ZVBXM0J1YXlxekdGUmRCd1dKT01DV0RX?= =?utf-8?B?VFYvNGdtdHRqaDJXNU1sanVRbng3dVU3dGo2QlM1WEVpMkRsMmt2SEZJYndL?= =?utf-8?B?a3ZFeU41d2VHRjhJVVFIbVozTnJQMDN1ODl6blhDYWw3WnFHOVZSY2FEVGNZ?= =?utf-8?B?Sm9YRTRnRmZQTTFWenhIU1NLUmNST09qd3hzR3luZFB5aXJLMCtpYzRUUFVp?= =?utf-8?B?cmtmNW8vdklPVkRJd0ZmVUdxNGNMRk51cmlJZ3ZTK2hraTFpN1J4M1VNTWJ2?= =?utf-8?B?NTRBQldBN3RhMW5OVGV6dTFDa0lPblB0MGprMXozQnp4VVBvbWFIcXgxd09j?= =?utf-8?B?RVR4dVBrbzVhYUpsOUxKRE41QVVVeUtlakRrZkg5Z2N2Vk9KYWowY2tUZ1d1?= =?utf-8?B?TzJZQmU4REwwcWZDTDVLaXRPN2sxdjhlVUFnRWFGc05odFhXSythUVAwK2FH?= =?utf-8?B?OHlaQk1DZWUxN1g5NjVsRTN0amZ4NE5hd2FVN3J4RG1KRUROTmZaWkFhWmhH?= =?utf-8?B?c2l1MHZlc2FNSkt3eVlHdERJRjJUOU0xV01nd2xZWHNLcWtVUzZWZWhRb1hI?= =?utf-8?B?bGNkQ1hVd3V3YUZraERqUEtQNy9uVUd0VVM3N3NMdGJiQ296ZzdmeUhwMUVn?= =?utf-8?B?ODRlcU1FaVErc2k4bWtTRmRucmQvMERzUExrT2phQkRyd3pFYWUwZ0RQRndn?= =?utf-8?Q?jGkpeXf/lcZTfSnqJYqtvy+1E?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e08db31b-7227-4564-bd22-08da68ac19ed X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:56:00.6270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XnupceQLg0hdmlQD7pHP3+kH5eMvzq9sNUy018POmQxfxk5YxzQSYF+tun/sNPOmv+a9npx59kEmM6SEsFFTLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6475 On 18.07.2022 12:45, Marek Marczykowski-Górecki wrote: > On Tue, Jul 12, 2022 at 05:59:51PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> +static bool __init xue_init_xhc(struct xue *xue) >>> +{ >>> + uint32_t bar0; >>> + uint64_t bar1; >>> + uint64_t devfn; >>> + >>> + /* >>> + * Search PCI bus 0 for the xHC. All the host controllers supported so far >>> + * are part of the chipset and are on bus 0. >>> + */ >>> + for ( devfn = 0; devfn < 256; devfn++ ) >>> + { >>> + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); >>> + uint32_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); >>> + >>> + if ( hdr == 0 || hdr == 0x80 ) >>> + { >>> + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == XUE_XHC_CLASSC ) >>> + { >>> + xue->sbdf = sbdf; >>> + break; >>> + } >>> + } >>> + } >>> + >>> + if ( !xue->sbdf.sbdf ) >>> + { >>> + xue_error("Compatible xHC not found on bus 0\n"); >>> + return false; >>> + } >>> + >>> + /* ...we found it, so parse the BAR and map the registers */ >>> + bar0 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0); >>> + bar1 = pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_1); >>> + >>> + /* IO BARs not allowed; BAR must be 64-bit */ >>> + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY || >>> + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) != PCI_BASE_ADDRESS_MEM_TYPE_64 ) >>> + return false; >>> + >>> + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); >>> + xue->xhc_mmio_size = ~(pci_conf_read32(xue->sbdf, PCI_BASE_ADDRESS_0) & 0xFFFFFFF0) + 1; >>> + pci_conf_write32(xue->sbdf, PCI_BASE_ADDRESS_0, bar0); >> >> Why is a 64-bit BAR required when you size only the low 32 bits? > > xHCI spec says the first BAR is required to be 64-bit, so I'm checking > this assumption to handle just this one case. But then, the size is 64K > in practice (and xue_sys_map_xhc() checks for that), so just 32 bits are > enough. Anyway, I can add sizing the whole thing, for consistency. > >> Also you need to disable memory decoding around this (and >> somewhere you also need to explicitly enable it, assuming here >> you would afterwards restore the original value of the command >> register). > > Actually, this is a good place to enable memory decoding. It might seem so, I agree, but then upon encountering a later error you'll need more precautions so you would able to restore the command register to its original value. I think it's easier / clearer when you keep command register save/restore to within functions. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 10:57:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 10:57:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369612.601060 (Exim 4.92) (envelope-from ) id 1oDORU-0003Ge-7k; Mon, 18 Jul 2022 10:57:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369612.601060; Mon, 18 Jul 2022 10:57:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDORU-0003GX-4H; Mon, 18 Jul 2022 10:57:36 +0000 Received: by outflank-mailman (input) for mailman id 369612; Mon, 18 Jul 2022 10:57:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDORS-0003GR-NY for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 10:57:34 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140043.outbound.protection.outlook.com [40.107.14.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d06964f-0688-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 12:57:33 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB8PR04MB6475.eurprd04.prod.outlook.com (2603:10a6:10:103::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 10:57:31 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 10:57:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d06964f-0688-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apaMDCGVcOoXXJpEY2MW/izmFg5EZL+5ntK38DKu4hNwLNr3KByN+XhqhgKvWHY/DvF/UY73c/VO7hu6qHMpm/iEgVMfLxsp6lk4wIaZqPfSvefZjsh0+8lsOt30M3aMj4WStuxYE81aXnQH4M86KZy3HlRVGMNtI1ivzpR187mot4s/ijEpmvZhkZRtCeETEYhVskRiIuwi0sov7xd2AKHSvfGyEEaNgpqk+dQ22VHU7mZ3JgKTJUVBZzP3MsNREUfSAbypA//cMQR9DkO3eSE83Dz5QSQcEKy3iJURT2vfw5aIZjokCZdrLEDHvVqtdk5VyeLavK88kw4kQL7txg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EcnbUL+ktCxwJctxuLulZm0GoSCc+ICRTdW/m5MlcDM=; b=OzQBn/fnJhQXyFBfIapSD21M8cyUmJnmCvwC36LQJuRam/RreHKWsZc8wH8uH/l82FUUjeZ1s5Po97+Epv6OAlB0AndpoCXLs94uH+GPpQDtS8nUrFfIPuhsbPdwPfWrHPtUaLggnSH0A4s+DGFxsuvWNWU0CeT98EYK8OaIIW2Y7t/3JNN9nccMu6tWwdgSqZmFstO3ujprnnP9b00qqkdTeNwE/UGVrf8d7nZyz1VIYsTm7rAZ9aT7YGMWkrgzVjN00IU9rR48zHIdAz8PBOAplRHxx01lGboHhPoAkoQrl96WhQmqQWOkYQHPMR+1wS7w5DIj4yB+XUb5kS8Dnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EcnbUL+ktCxwJctxuLulZm0GoSCc+ICRTdW/m5MlcDM=; b=thxz93VySFUWuz5ioy5fN9jp8yj81kWF6eydsQzHSypedPr1ZcIl5vRBEXUs3MZuTy74lJ78hJA9VWpMVVQYxvgSWUDyVcIDfbeZkN+VgfqcFNQl67NGZ07ZD4/268KaiU9yKPwqof8LQ2CO3vEaTm/+maj4VKZ/oYN4hKOOkSFM1LglCvA0fWsiD3tmdg6A+goPA7Zc4NqZM9Xowf+Z3TdUuswADLtjK/0XFtixVQyiPswD0t11tYWJSCocBulnqKMEZoJonKwgq3l7s/BuJhKBwPk6tIlEMRUe3QmTkiMOyBCu9BN1m+zG+zVSOGNi9uAAQXxqCizp6aBC2epy5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ce96525-7533-3ae5-4bef-eb6021992cdf@suse.com> Date: Mon, 18 Jul 2022 12:57:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/3] xen/heap: Split init_heap_pages() in two Content-Language: en-US To: Julien Grall Cc: Julien Grall , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-3-julien@xen.org> <07304aef-e278-9da9-ebd9-640ac7933268@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0050.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:15::27) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 33546301-52d0-46e3-0dc1-08da68ac5047 X-MS-TrafficTypeDiagnostic: DB8PR04MB6475:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mebXUVk7rLvDiqu2sov3/vrhqaUEynopqPbGmRi523H42/5SEMw6f+//p8S3RePCzpkDEggxfNy9qT4JPLz8rAsmcixRHz6YQTtCnZ7e5qTkYoSIRzXNAwyODJvlQzzy4fXb1fP0n4knQpSUsnJ6x238pQl8q0UTjpyIQys7Qewh+aBnJkIHBOYEdK2d6KH6J25b09uMvIA0iAbDoeBEX5VoNSnAkRNyS2OmUagw87nPKk/YW8Rm6eSK45tgtCPRNc72u1FeklF0h1GFP9FfCNUt86R+6u2NoQSrDgXhqYa5hTR2V2BtHJ9AF/KHyzazeXrcWqdQgNCOvFx6x8USPV5ZsaXgvqHRhYvfMXpLtWU+9uFdt3NMnBWrEd0X8PxwiR/LbZTtNawCJGvU3yIrp+5W6GqEoBa1DaK05bqYEAdUY1RZMKx9VB0MLhNIah7cBEu5IqC4QxYMPj6VXJoBdNfxkMqkXdwRqsRdQnSBjTjHPj39tWNQfzwuUr47MWyqu/IuVtu9tzP3DmIkHvWuGP3vn9rnLPb4H+A6tnruWhFtr+Le+1PdCDwrb9kARUPVKb9NGCnkWT+i/FrT1bNZ5ZPvykuIRCPNUUtEK74dileIuvi1/UJzZL5w4gxyBh6Wx0GK7jek4Z74h/oL0dykZwdz5qa/HaO6JlK3Jd5OGj/dKvPuR/yiLAkBDeyTUh8a51cZRs7GCA8E9ugEv5va++FgWPPcVlo2migwOtAKHVJs+Nok6kif8lw+bDL5XqinJjin/VqFMy3hR7qgKdUILv/B6/wdNbsnEEYYNtegCgwnt8Lv9Y+PeZJWob8X3IlZYn3GQYCotqrANtPm+iiA/88i3DUNmCbMg/E+0MUYDdY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(136003)(376002)(39860400002)(396003)(478600001)(8936002)(66476007)(66946007)(66556008)(86362001)(4326008)(8676002)(31686004)(5660300002)(316002)(6916009)(54906003)(6486002)(36756003)(31696002)(6506007)(53546011)(2906002)(6512007)(26005)(41300700001)(38100700002)(186003)(2616005)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGhrSmRtMGVNZFllQjIvWGQxQXNJSW1wVjdESTJ1Q0VodEFUdlk5ZzNLZEhj?= =?utf-8?B?Q3ZpaG1UWC9DQXVLYThBd2pHaityUFZ5MlEyTkEyY0tGcm5jQkEwSHRORXVI?= =?utf-8?B?d0FvQmR1cEFxZnhZYUdJRk9jN1M1UnpPaHR0MXNHTVAyTmlzQWdoL3UwaExw?= =?utf-8?B?emF1ZnZLYVl0NU1zbTZndmVQUWlZUEh5SFgraThCSkhSaFIwVnpkd2RBbmhP?= =?utf-8?B?NjJmSFc5N0w1U2syOENBYVNmNlFhbEN6eEk4eExYays1UlhueCtNYXB3alp0?= =?utf-8?B?L0d2dUNOZHlZNmVabm0zeitiSFdOckdBNTdRMktvYW1IV0VwY0E2UmE2V3lz?= =?utf-8?B?ZndYMGorWjh5T2FPbkM1MlJIVVNZQXA2VGlHem5tZCtDbmhJTkUwVTJMWkt2?= =?utf-8?B?OEQxbDEydmZoczZhelZqcms4UXZYN2Z3em80OTV2ODIyeHNXWmRnNEtXZkdn?= =?utf-8?B?VzhVc0Fhc2tyY1JhR2ttdGVqZk5WU1RkeXBtR1BkTTVkNitoQkdCOE83TmFq?= =?utf-8?B?aVk0VWliMkxxbUErWE9SdGMwemh4cmJHaWx2MUdnS25EczF0UEJlekhQeEFL?= =?utf-8?B?TXFBZTFiTVVhdk5LNEUrVHhtSVREejJ6MHNCY0EwdTd1MFJGMFdXQkZFL3hY?= =?utf-8?B?UURRQmN1ZG44RlVYWjFLc1EzYmtWbFNITDlNZ0dmMjg3QlNibW9CTE9GK1pS?= =?utf-8?B?bGlRSWVQVW9iWThyZ2NrOWtqZ1JvbWV0VGZyOG5iSzZvZ2RIcHI2Ly9sUTRN?= =?utf-8?B?SGMzYjR0WnZ1SDQ1MzBzM2x6TEpYNElSeWNYUVAxNWF1RE81cCtGMVF5R3la?= =?utf-8?B?TTdGMFRmR2dYdlpOY3JiVGJYZUJlaWNxYzNnQWk3NFlBM1VuTDB0djkydlBF?= =?utf-8?B?NFlEV1VhTCtLdVBaeCtLMGQrREN3SSt4WEE5OVJGTC9hRnVGd1BZaHlBa2lo?= =?utf-8?B?ZTFhVmhYa3ozNXBnTFY3SERvK3N3Q2dVenlGVjE4MXN5UTVGK21NK1pYQzQ1?= =?utf-8?B?SjFQV0ZpUGswUWJSdTVjU040WHNuU0FabWdveGwwWGVWRmJSNE5hSnlTTDZm?= =?utf-8?B?dVlNZDl4S0pIOUxneWJ0RGVLMlZBQVRyU2FXNm10R1VJUTdsK3VBS3czRDJr?= =?utf-8?B?Rzl5eWMzQ2VlOWRBYk9ORFYrMlFHckVyMFE4c0dxdTd2RS9Va1pNVkpWd0Ra?= =?utf-8?B?K084ZktZTHZ4eGtzQURhU1A5Qm9MVE14dzlpL0ZKTGFyc1R6U1FvY0VwSmIy?= =?utf-8?B?LzJyTzFieU0yZXpSUWp6Y01zSzdBNythSEpxeEFrN2svVzA5QTFSaGdlWi9Y?= =?utf-8?B?SWFsTlFjdjAxWUkxWXlybG10ZnVFWXVyV2lBbDgyZGI4NkVaNU9nclIvYkRz?= =?utf-8?B?ZmpyTzVKNjdxeng4bWZ5bEVVWmZKUllyRmtlMVNxcDNOcDl3YnNVeDBldENZ?= =?utf-8?B?aEM0dTB5QTd2S1gxU2wvSGRMRmhUdml6YUpDV3dOeVhyOVh1Y3VINWp4NFNw?= =?utf-8?B?ZHRPNFVtUzR5aVNnWDNKd2hBaGVrbElrQzhhN2k2d3J4a1VIc05EamVOWXFU?= =?utf-8?B?YklITWp3d2FYczMzNFhXUEdETHdKQ01MQmpJSC9uU3JMZDRrTkk1U0VnbmZm?= =?utf-8?B?QlVmd21oS0dXbU9xekJieWkwczZTSEwxTzg2a2RZSEhoR3pNMEpXRzl0K3Ft?= =?utf-8?B?OXo4eGhYUkZTMkVqeEdVeDFjQzNhaXVVTE9UQ2pRWVRIbHNBSjRzQmo2cm9x?= =?utf-8?B?Vk5sVjJTblFPOFdYRjV4ZU5iTDc5dXJXV2ZkRE81TFR4eGU4c3MrR3NaRDBZ?= =?utf-8?B?N1Rvd0xUdWtOb09nMDV1czZVTURwOEhVRm9UOVcwK3cwNHcvVlJYYVFjNlMx?= =?utf-8?B?RVA0TGwrVGpTZkR2VDNXZW0wdER0d0pjK1NNaytaMjgyaFluVXpXNXZIT2Ru?= =?utf-8?B?VElRVTRVRGg3cFNjeHNrVFpXMGZuTGdPNXRITGZENDR3dk0xVldLd0hJaFhw?= =?utf-8?B?akFEdktFRnNyTmFZOHAzVFFpM25UMTltUHpabFdjT2lYMDdLYkR0OVF2ZDNU?= =?utf-8?B?Y1hTd3VFNnBvZ2xLS3l0MUhQSmR3SUMxZlVhQ3ZDMEtWOEpsRldFTjVNbFI2?= =?utf-8?Q?22As6mX0lbWUoAKW3PPasJVYO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 33546301-52d0-46e3-0dc1-08da68ac5047 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 10:57:31.7781 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dPc6+plgtEXBc27UuYeXMXQK297cndd7tSrFL6xSZxWmwmXt/WSP9YuQsY9frZF9uPdALAD5MFF/OUsXB66xZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6475 On 18.07.2022 12:08, Julien Grall wrote: > On 18/07/2022 10:31, Jan Beulich wrote: >> On 15.07.2022 19:03, Julien Grall wrote: >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -1778,16 +1778,44 @@ int query_page_offline(mfn_t mfn, uint32_t *status) >>> } >>> >>> /* >>> - * Hand the specified arbitrary page range to the specified heap zone >>> - * checking the node_id of the previous page. If they differ and the >>> - * latter is not on a MAX_ORDER boundary, then we reserve the page by >>> - * not freeing it to the buddy allocator. >>> + * This function should only be called with valid pages from the same NUMA >>> + * node. >>> */ >>> +static void _init_heap_pages(const struct page_info *pg, >>> + unsigned long nr_pages, >>> + bool need_scrub) >>> +{ >>> + unsigned long s, e; >>> + unsigned int nid = phys_to_nid(page_to_maddr(pg)); >>> + >>> + s = mfn_x(page_to_mfn(pg)); >>> + e = mfn_x(mfn_add(page_to_mfn(pg + nr_pages - 1), 1)); >>> + if ( unlikely(!avail[nid]) ) >>> + { >>> + bool use_tail = IS_ALIGNED(s, 1UL << MAX_ORDER) && >>> + (find_first_set_bit(e) <= find_first_set_bit(s)); >>> + unsigned long n; >>> + >>> + n = init_node_heap(nid, s, nr_pages, &use_tail); >>> + BUG_ON(n > nr_pages); >>> + if ( use_tail ) >>> + e -= n; >>> + else >>> + s += n; >>> + } >>> + >>> + while ( s < e ) >>> + { >>> + free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); >>> + s += 1UL; >> >> ... the more conventional s++ or ++s used here? > > I would prefer to keep using "s += 1UL" here because: > * it will be replace with a proper order in the follow-up patch. So > this is temporary. Fair enough. Jan > * one could argue that if I use "s++" then I should also switch to a > for loop which would make sense here but not in the next patch. > > Cheers, > From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:02:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:02:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369619.601070 (Exim 4.92) (envelope-from ) id 1oDOWT-0004im-PM; Mon, 18 Jul 2022 11:02:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369619.601070; Mon, 18 Jul 2022 11:02:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOWT-0004if-Mc; Mon, 18 Jul 2022 11:02:45 +0000 Received: by outflank-mailman (input) for mailman id 369619; Mon, 18 Jul 2022 11:02:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOWS-0004iZ-H4 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:02:44 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20083.outbound.protection.outlook.com [40.107.2.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25a7fd36-0689-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:02:43 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VI1PR04MB4142.eurprd04.prod.outlook.com (2603:10a6:803:3f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 11:02:41 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:02:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25a7fd36-0689-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAOQSZWkb8QyRzT9pAEGz/SUnmD1sMrS5anhoG4gTxRFV7++da3h/HfxZd4+PJzzlxYA5F3BETgcJLpW1pxsrg28HQPP9bMI1kCrvCnlOtaI7TrmJjZFhhSGrHbOFYv7E1z45AG2ZPI2oLm7z65Z92wf44FFteSSGF2nMjteMXmJNNim3ydL9z/XN2E1kSPbQVzPDy+Raj2E6wBK6/9CRww9EqUA8KTiK8Xc6JwL758IojXMnqiTsuWua4J/Fk9nhfVbTGL925CvE8vrMt/Z9xv6ylFD2Vn8j77jDA5iPtcuV1mwVQCyrO7LWHBbV6ZQi22GPJy4ISoIDj9clk5RaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=prpM2/QYpOwMABF52SWFejvfpSMK3zlK4l5+vQVVYRQ=; b=kxuhJiuQLQmZtzrMw1An0M93zzvdEu7pQcZLLLunLC6r4PQ1LurQgspj35lk0d0v8BwUf/rYSRA1mdZVY+Sie/xUFLAytmHN05g7rU+2LW6XRMLcnSPzJv801QTLcezy4Z5QTV6MH62kgTSBlQqz55gAUOQ+pr+mqqLEsZ0dubqqKm0/c0xZRL4uDgrClKrDIlvYjJJ5s3eFFo6HZSL0ZgcG8rHHJCO6fH39kndRz4Tgpa/lzkSNUAiUU5p4at7jiJx0vfKiHt7Oq305oowbYMi7MixIHQ5o/hKYUUhYW3HHzpUUZwP67H7U8Vrm2799YMn8vUXbxjoUFxVK53Y0Bg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=prpM2/QYpOwMABF52SWFejvfpSMK3zlK4l5+vQVVYRQ=; b=26MgPyYMvx69ST1f/bPTA/ZRENhe6bsCkLaa1CtT4MBzMV/c2bBAVFmF1ntLjpnek4JNmyLHSaWW4R7ARsJ50a+C8+4tDMS3X45AhaAxnd+hC4/kAwPcsI5xc9GwyRlAsE5Uo8gg46nPTixfG9QvRXVv4V0A206OQEKNUGchWfQ1Mj0Gt5jttVsejjx/uuWMkcav4g47TnV/U6ylHAPxjx0pxHI6rm1VtKHSt7On5ZD5XukYbx2VPhxippMhHYf4d+DJxA6sl5k4IcJ+Qgv5ugfY6K/wO3NC4JroF36lMWpKBZuJUwVQ0FKE5vS8bv90EZNXrfo1Xp4/jgYm95L77Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <097e8634-0c5b-35ac-6ad6-5b83d9b29f64@suse.com> Date: Mon, 18 Jul 2022 13:02:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0091.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::11) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b6f05cff-7300-4c64-725d-08da68ad08eb X-MS-TrafficTypeDiagnostic: VI1PR04MB4142:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gWHeTVN7rkklK/Z9OfIZ5s0hhcJUCjGuRp9FPHJJ9KNYikyxP/kM1vac/NgcJW6KrBFUJleTvO+YRdkld+DLobiUSuC3Fo8i/iNiLpYXHG8xPyrpvkG1xMs+5suIUDtxm53tRHWEcQOUtVLVk6toigwJboswtQekmojUpySqaXhy2C2TtPIuQKm+G5xsQDUfv7nQMdRLvqoDdjkxoocJDbpQ91WYEC7csUIKRcMWdhCeHCUcSHdgRx7zoVrC+t9i1Yhm1nLga+DFd84tSfOwK1fRX1q08pGsq56dCWU9g/NTtYam2fqSsNAQryOVR+LOIUB2O4fII1LTVklX4azRoTBI7Wp3P5So3lhifiog88wNLscxc/RdTuhXPXUgMBgJJuTGK9HyXbbO7ynMXkjuwnVobInLy5QM8y9Q31vPvmGnJV9PDepR2wjXfdkuZ7MiOZfZA7qeApI0tSlwtyHIrF0CoDcvF9csxKrzt+KBVZH5vcc/O7tcrB3OOsf5uUsMHzyE7m/RqoBKZ62xRABTUlypM2zz+o8fifRin47iagAw4Yb1YsNW4ULxyXsu0BNUjxBDlY6DR5RMPiRuW958x/67Iv2mqIidq9NUBDKpIeV6qEFAgLW0ScXjCVgxvRB68GWf3F2V7NtEHek8058xaxn9MneV/SLr62L9qJTeKvVmfBPHY5NkptJYripbYYdaGqZc5JIl+U54UNlQ14YXsHTmQZGkWvmjNfQ9PWfeJR29SA6aEXPHV3QSIIK0EdjDtjcbMwKdXYjb08PJdoI32SE440TYA+zUbYQdymSNegm6gi5zXVciG8EYEw8I92Yc5pVAhPh+pLHvqEcTuOJqYrcQguzA+eg+Al/JrKo3weA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39850400004)(366004)(376002)(396003)(346002)(41300700001)(316002)(6512007)(54906003)(6486002)(6916009)(6506007)(26005)(31686004)(36756003)(2906002)(66556008)(5660300002)(38100700002)(66946007)(8676002)(4326008)(66476007)(83380400001)(186003)(478600001)(53546011)(2616005)(31696002)(8936002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YXRkSHVYclR0SXRoVkg5Yk1OVXR2ck5WMmFsVmUwbWZlTXRyMnJNblA2aGxl?= =?utf-8?B?bDViMzA1QkJuOGJDcVJsSy9XL1kvTHJwQmFaNlJEL3RXWmVITEFZTUFZYUNK?= =?utf-8?B?alpPbjgzaFFSbGh5M3MvQUdNNFNiZ1dPaTZNSitnbnZMbTdBczVvWkUxWFpC?= =?utf-8?B?OUJkN1hnTDBzaHpHeGFEUW9HajNUVm9iTDk1OTJadExDNmUrRUMvQ0lYLy93?= =?utf-8?B?RUV1RlN0L1ZYWlBFYzdmaHE4RlFwS2pRMWdSQjE5NEtrMHJUMXlyMDZZQXU5?= =?utf-8?B?Zlc3emVVQm85dS9vUUgxQ2hvWG5EM3ZybUJyTjY1Ymprc1ErdHNSTHc4cUxT?= =?utf-8?B?QytTUEthTVNkalNqTUp0aCtrR0VrQklQWkZoREtrbW5SdFdSVjVWdjZmRWdi?= =?utf-8?B?dCsvaUV1NksvNGUrMWhiUjFONFVJNFczWU5jb0sxSkJsRUdEVkZGampaQVpH?= =?utf-8?B?NDQvK2VYNFl5Q1plYVNuYWRJUnpCZGVFSFFielBLMEJmVlhwMlZtMjJrNVcr?= =?utf-8?B?S1NtUTZ4R2JlKzVnWEltRW5xakRGNjlGcW5OOS8yTFlubmZleFk0MURtejhL?= =?utf-8?B?ejloZ0d1cHNpK0lRTkc5REU3MFpZem1RVXNTc1IxcFFzY2h6bWVqM3VvVkNX?= =?utf-8?B?aXlYbHNNZ0ZPZzlkT0FEYS82djNXbkVUVHRPZWYvQTNTdjYveFpmWXk1c3lw?= =?utf-8?B?NGdtdXdGYTZDQTZqZWkyU2c4ZnZGNDFsSFhzWmh4d1hsM242WFF3NHl0eFZG?= =?utf-8?B?TUFkMXMvaVFQMHJTWFFPejJSVlRFOENrMXdXeEJxTVpheXFQMXh0ejVhb1Fk?= =?utf-8?B?Y2ViZk52UDhNOUJxZ2lraGhWN3BhRUJhYXZ2am9QTDhxaDQycCtaZ0ZFOHlq?= =?utf-8?B?WFNjSWE2WVlEZm8wdXIvYUxyaHliSm5iK005cE1EbDVQeDBHYkVoU3VkOEMx?= =?utf-8?B?Vy9FTTA4Z296R2RPeTNjaXhjaVlnOVhNTDhmV2NsMmZVUFU2ZzRlRVpCeFlR?= =?utf-8?B?dDdzUkVrY1p0VnVOaVVldEo2dmpITkNGZkZpUWZFZTA4WktYK0xvYkZWZU0z?= =?utf-8?B?TWpKMENUbFdsNFZMaHpOTkFxa1NPQ3pnU2dEU3Z6YzZkOU5jU2daczVBTnl1?= =?utf-8?B?Tk50ZHo4SmNFL0Q1Y2YwY1pRenh2a2J6NGJINFJ4dUltYWxIQ2lTbEM0aWR6?= =?utf-8?B?UW1xZ1h0a1hlTm52VDRka1JuWldQRk5vSE9OZmdTWEZ5VHkzdW1pUnhxUTdm?= =?utf-8?B?Q1lVRXNDZHFQUjBNbWlJQlQ5WmtIK3Nvb2tGZUxoeW0vRkM3azMweWo0Yk95?= =?utf-8?B?N1U0Szh2YzA5bXo3L1N1WVJnVnVCS0QrdjV4T080N3BsYXY2Uzd2eVpDanBV?= =?utf-8?B?SHpib0kxM1RBTXNlTWlYMFFuaWVvdUdtYmpKeVBYS0VlSVZQUFJUNkRGZVFz?= =?utf-8?B?eTk2RDI3Z21kNWx6dEMySndHTnkvSWNnSFRaVEZHZHlIMnMvY1BtaVRFQ3Yr?= =?utf-8?B?ZGNndFp0aWhlZCsvOEx4NXgyZGloWStpWW5KSW5wWTYyNGdsUFQxSEhEMTNu?= =?utf-8?B?UzFPRmZvck1QVk5SL2RqZ2NQOC9qcUliOE1mUnJyVlVxK21FNVNpcmhWZVhZ?= =?utf-8?B?TTZyZmQ3Nkw2VlNCWjJnaEFNVTRpWGNwSzBhK3BPWGRiZCtoSFY4K0VHWXIy?= =?utf-8?B?eWFWK3RydVFFMWVDVjYvN1RybTlXTFVJZGxmZnBiNm5LR2NmL3BlRVorVkpp?= =?utf-8?B?QzVQQkw4UjdTdkgyaGk1OWNEdjNyWFJqSTFzWDRPOThLdjIrY3dYeWFtc2Uw?= =?utf-8?B?WEQ4cHMzU0htMGVjUk5udGVtSzFVTUtiSDlRMjc3TDcrODBJdGxiNzhrMVRq?= =?utf-8?B?aHBrSWxCUnJJUk9EclNDMEtDNEp4VHdTeWNFT2ZVQmpEcUVCLzJvcDl3c3pu?= =?utf-8?B?ME1oTTJmRlhFRlFZclA1cHppUk40YWNKWVZMQW1KQmZKUHZsTEtvTjlvaFdV?= =?utf-8?B?TURSTkRMam1QMzFYbXhjUkpQTzNNcmJINTh0MXBIS3BuRHNSSllMQjFIbmlW?= =?utf-8?B?Mm40dWdyckVIekplaldROHpRdmZtNjNFMzFLZlp5b1dsMmZoTHlITmwyYXVH?= =?utf-8?Q?uHwNW1A7Nh4Gp9njyUOv6UVoz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6f05cff-7300-4c64-725d-08da68ad08eb X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:02:41.5719 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HG9Z9AhDb5vxA9Cn16RF0KH/KTL4rd5AJ2/2+SZfKfzRPhWkl/jTzh2r5ruGsm/LVeFWd+blv8o/FrcTnol8qg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4142 On 18.07.2022 12:24, Julien Grall wrote: > Hi Jan, > > On 18/07/2022 10:43, Jan Beulich wrote: >> On 15.07.2022 19:03, Julien Grall wrote: >>> @@ -1806,8 +1806,22 @@ static void _init_heap_pages(const struct page_info *pg, >>> >>> while ( s < e ) >>> { >>> - free_heap_pages(mfn_to_page(_mfn(s)), 0, need_scrub); >>> - s += 1UL; >>> + /* >>> + * For s == 0, we simply use the largest increment by checking the >>> + * MSB of the region size. For s != 0, we also need to ensure that the >>> + * chunk is properly sized to end at power-of-two alignment. We do this >>> + * by checking the LSB of the start address and use its index as >>> + * the increment. Both cases need to be guarded by MAX_ORDER. >> >> s/guarded/bounded/ ? >> >>> + * Note that the value of ffsl() and flsl() starts from 1 so we need >>> + * to decrement it by 1. >>> + */ >>> + int inc_order = min(MAX_ORDER, flsl(e - s) - 1); >> >> unsigned int, since ... > > MAX_ORDER, flsl(), ffsl() are both returning signed value. So inc_order > should be 'int' to avoid any compilation issue. > >> >>> + if ( s ) >>> + inc_order = min(inc_order, ffsl(s) - 1); >>> + free_heap_pages(mfn_to_page(_mfn(s)), inc_order, need_scrub); >> >> ... that's what the function parameter says, and the value also can go >> negative? > > AFAICT, none of the values are negative. But per above, if we use min() > then the local variable should be 'int'. The two possible alternatives are: > 1) Use min_t() > 2) Update MAX_ORDER, flsl(), ffsl() to return an unsigned value > > The ideal would be #2 but it will require at least an extra patch and > effort. If we use #1, then they use may become stale if we implement #2. I'm not sure #2 is a good option - we'd deviate from conventions used elsewhere on what flsl() and ffsl() return. And constants would imo best remain suffix-less unless a suffix is very relevant to have (for MAX_ORDER, which isn't at risk of being subject to ~ or -, it may be warranted). 3) unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1); if ( s ) inc_order = min(inc_order, ffsl(s) - 1U); No compilation issues to expect here, afaict. > So I would prefer to keep min(). That said, I would be open to use > min_t() if you strongly prefer it. I consider max_t() / min_t() dangerous, so I'd like to limit their use to cases where no good alternatives exist. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:03:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:03:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369623.601082 (Exim 4.92) (envelope-from ) id 1oDOXN-0005Fb-2w; Mon, 18 Jul 2022 11:03:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369623.601082; Mon, 18 Jul 2022 11:03:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOXN-0005FS-04; Mon, 18 Jul 2022 11:03:41 +0000 Received: by outflank-mailman (input) for mailman id 369623; Mon, 18 Jul 2022 11:03:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOXM-0005DR-5v for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:03:40 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46684c7c-0689-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:03:39 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id AAB665C00D8; Mon, 18 Jul 2022 07:03:37 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 07:03:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 07:03:36 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46684c7c-0689-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658142217; x= 1658228617; bh=I28NGfmY7L0XQjjIWxfOFBpNNuQpQZYQVhCARMpxuqY=; b=v wnPLkMQrF+xn7jxtQC/3xkaET1ZVzN2MPm4sCXOPI2yBYTSt6voouoOkKAI4whgN 3Npo3VKpkkQtov+4uJhyV/BinXMUIL5jA9kOJxiy69lZ+O6BMVTvbwukjBJbZI8y f4UZrzj4xliNDyszIWMRiWlu32fTaRubMNlo/FihgI4w7N8VCIBUNWi7OQGkWeQn dxZm5Zc+2dRLnQj6lzHkppNeydGthEmH5Wq0iEp47O0MZsa/nTcqDRVFjOMT4Kaa 4ED4DkmrhPtgx7iRMHFYoNH7GEkmIUTC8+6cVoL6/3NUVlkqEpcNodDCVDuhXI90 NwHRrANDzSzIVHk2EzMSg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658142217; x=1658228617; bh=I28NGfmY7L0XQjjIWxfOFBpNNuQp QZYQVhCARMpxuqY=; b=eHXrExxR+/BAmzqqYQgCc9j5Q1N1QFfH/bRtJo9EGn7o Bx9KglSKGHSCt2jlATCeLUwCA4zBITl4hgqv3dIqnn6JdEECj+ZRx6W5LChwR/+B gYW1uglkPcRvlaft1I2OcZlz03VcGgrwaxIGe9bsCAN1Q7x9D03DeZfNSx2T5Fvm 5wLiSr5N2fEGYj5WF5Q32gcFG6+ls0yMk/iedCw7lXdvs/jFvDYhpiiJPr4Blap2 ncSxOs0WeuqT2Fx0zqGOA8HcQ84ec+OkMYK//fAdHbTuSLmmM/suECyM9PNnATxd bfCPilnyAmMvN3clS/xcMcXSvOIqQwYuYwbQ0YB/6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgfeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 13:03:33 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Message-ID: References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jPCNp031vxCM1vAN" Content-Disposition: inline In-Reply-To: <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> --jPCNp031vxCM1vAN Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 13:03:33 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Paul Durrant , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > +}; > > +static unsigned int __initdata nr_extra_reserved_ranges; > > +static struct extra_reserved_range __initdata extra_reserved_ranges[MA= X_EXTRA_RESERVED_RANGES]; >=20 > Overly long line. I can't find what coding style dictate in such case. Should the second line be indented (and how much)? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --jPCNp031vxCM1vAN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVPgUACgkQ24/THMrX 1yzBPQgAjUHkkreDVbtuIAfJ9BQdQkdvTLQOF0ptIqhsQVcxZxwZzQo0hlRqvS2/ N7R2RGesON2zS08i6YyGMzJtmaREki8zSV4Ha3loOHMuJufnDTR2seAXZWL2Vow2 fUDIyhD6VDI/xRIXXPM8fJe6AGG3L3m8oD2SlkBVO1Ve83Dbu8X9NZ7i99HU67qE a4SOyOmqrZnuEhFVXFVGbzBvGCZXZ+maQjMfQJfG5mm+ZQIchk8HLWXkJnvZdODS PDi7IxsoEOSMqYX8mPqbkE2mxfcwAG+eyGKz98i1XTN5V9n8zM6sfsW/mwI4l5wc Jej6MntL1gT/4lph/3rW2xxUVMh+/Q== =xtrr -----END PGP SIGNATURE----- --jPCNp031vxCM1vAN-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:11:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:11:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369635.601092 (Exim 4.92) (envelope-from ) id 1oDOfH-0006y4-0a; Mon, 18 Jul 2022 11:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369635.601092; Mon, 18 Jul 2022 11:11:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOfG-0006xx-UG; Mon, 18 Jul 2022 11:11:50 +0000 Received: by outflank-mailman (input) for mailman id 369635; Mon, 18 Jul 2022 11:11:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOfF-0006xr-Sm for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:11:49 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6aec6ac5-068a-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:11:48 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR04MB4321.eurprd04.prod.outlook.com (2603:10a6:208:67::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Mon, 18 Jul 2022 11:11:47 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:11:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6aec6ac5-068a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7EYNF0j+kg3WFo8WrkGD+n7F2diC2prlFeYd0dWR2NpHBvlPyWXcXRBFqnpO43kBuZ43BSkkmFsgg6GJujeZxWiMwzDrDx+QsRLUVFZubB2/v2/tOJOItGmex622BOyfTJ4fuoE1j29tdN3MvW1jg4Pe6OxbLVtVluI692z+OfwyDFejAbsO7Q9JyyUMUQMoDrTlenUHlPxUbQLgLUeIDjEnOhL7/zkVk4yBYsFDAaln5UKHgsKQ+gFop6YjkV3XJkShS8lnx9T3z1bA1DeBiWk6PRL9D4zHPoXPco1v26+Ax2XoS5JGJTOl2nN8cPqJtC8kbY576enJ/rSi+C9mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=43kb2Wrds5TSNOBRPSTFd3YDku/KYxEUrcx6EseKCGU=; b=DOC9C/5t0Q7ghmmFyXRFgaCEoJrVyVFMx08Oj8E28mtuwJOzbg8oQMnOaatAAPV4IO+pp5n/4HBoyNg5JCBqqCLm/tEvPw4R1IibsSiX7T6kfhyKuyxbNcjkOXrQ5d/XIRBsYy0NX8nVvFmA7j0qRbrv38+/0POuQgrJS60H7Lhx56zw8u8wZq4IGqKMwXULjH+sps/I4TS23mP0y1aOQSjBVGPtJUWgkQOMXSkVKpkFv7XsHXx3GbscCcyjqJ/JqmHvqTE9L8sQj9Ji0T3nEY1ry0keS5Zi0deQNAdk+js/rfmohFjrWKUbdp0uuaFHZBmCCJ+ilPv5HVRvPiDrsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=43kb2Wrds5TSNOBRPSTFd3YDku/KYxEUrcx6EseKCGU=; b=cKDupusRd7emRo9QAh2x+ZAAWyshec4Guzl/bhvejcYJTR3sa7tqSw+qZtPloul1RLi8u/6l+r86oPKkMZq7RVjGID1BFwMLcBcxaAqGVJQZ0GLbQdzakja8RN6sVX93wAvHaeWQDawtPaSocmiB5iheGE6fejuoF/56y0nClhg2PV8dao6ucJ5zfhdMgnb2vul71KQc21fgAl2SJLL/JB+whe/MKkiymULTqzYwiEsapYTtDBrU+S0ZAM+Dk2oCyxyMM9Fai9piju5haGxLr2NPEy5w7nW8Gcu3IugSIzUv6RTwDbHAoc2ddjIXZdDDODhcCzvmI1Zaqouv9nH4cw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 13:11:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/5] xen/wait: Improvements Content-Language: en-US To: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Cc: Xen-devel , Andrew Cooper References: <20220718071825.22113-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718071825.22113-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7e9871a-bb6e-411b-fe0d-08da68ae4e5b X-MS-TrafficTypeDiagnostic: AM0PR04MB4321:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LWQzNT1PCSjLCYPIQUVIvy8x47gdDTifpW0VDzJ+NDKzhsIUlD5j4sLgA05gXO0paDyVxOVudQg+dUNWgGtUtcLwKtFDAfoOBRDF76NdVA7XpVNbaUNcPcJqcNnBU+xx1RLQNePIUKC5RlMXp/EEPaH17A74lxrQGQmzUQDJ3JYqNuXd0xbU8NuA1G9dTZ9JyhkduYEJX3DzKPdDk0s5S05ctzMTbncT2p0GWEa+5Agh+8TXQ5PvixV5+QWDMl6X8XJSYfGJNC5vNE3pYQ6vdG1/tC3nQuJZuCJP/yMz20CRd/c/++j93ZDbvEn3TBcWcM0lLkNrAky+NR+/YgjNlo8lxmnV4G3MgbSSANCSz2S50UYmEYHQUnfkRESWgaIJNu82GRhYrJwUG+g2EjPGqMyN1lshL+/EFSwFIoi6Zo2x9ADCVHH4A5IUMbaQ13zTFU117KDJ42hgQDaxU9zrLH0BPI9tIbbl/p8aFUOtd5LodvM1UMJ82W6PKJTsutgg1+WAYI1d6OkwrgGW1e9ncKmUy8sVGPMLPhALABKpw33T7u9/R8nMm4zoD3CaScHABmSdYC+O6jMrQVJs0/JNwNo+5/oqP0/ZQZWltb37lYMXMGK+QGeY4JDK97tI69TeuGTqMKMEtuvM6orPQoj/RFpOWTw47xgAnrA3YpQK/mPgLmiOzZ8EMB+LsOAnFz4iBWtHOmB+3GpXnlSJ2DN4SfK2FuSHI6TOsBtNWwU+HkTW4MMB4PxSZZPo3X9fe+UC4GHRjStraCRP8kgBEwcG4BaupGdvUorskGBllX0dzMQVBWsRUy7/795JsB8Aa3RByoN4sLmmtuo73VEjn0xl7437iueEdoURAXF5ro8M8Ec= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(376002)(136003)(396003)(39860400002)(186003)(110136005)(54906003)(31686004)(316002)(38100700002)(36756003)(86362001)(2616005)(8676002)(8936002)(83380400001)(6486002)(2906002)(66556008)(66476007)(478600001)(66946007)(41300700001)(6512007)(31696002)(6506007)(53546011)(26005)(5660300002)(4326008)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WFpuZyttc2F1RjNacGhjSGJLSW05Tm4rdFVUazVkeWVoaVRLa0NJMElibHdp?= =?utf-8?B?d1lyUzFjbEQydGhjdm50NXBDd1Y2WjZXNTFXQjhJVUxJL0lkN0NjaUtlZzJ0?= =?utf-8?B?bXl3U0JpVFBWKzd3WFdyZ2pIcUg4VGtGL2krWk5ITXdSbHVlU2FTaVN2TFli?= =?utf-8?B?dUYvV3p2TjJUVk9VS0FkckVMUUN1QmlvQTFYajZKdGh0VlVUdmt2bVprWUVM?= =?utf-8?B?QkJyM3NCRnJLTU4vVGVLeGxHdkxVK3l2TWdoOVpOcVJjblMzRXVtUVV0VmFL?= =?utf-8?B?VlV1UDJMK0RWd0ZmTWVqQnEvNmZOYmREbDJJdFRYZG85QWNrR1lFUzQrZVBK?= =?utf-8?B?SzBvY1JXVFl3ZUFNQ2hRaDdzL3lzbi9HUmRHZGZMQVFqSEhwSUROYmwrdGJE?= =?utf-8?B?WHhhSnRmdUlrTWdJUWRiQXZvNXZ6TjVPRWpUNEhIdW1nbnBPNDE0S254WFg0?= =?utf-8?B?VXROd0dDQTJsaHg5SmFScW1aRzQ2WXl1QlZTWnZhbElDS1k1VzRoYUVNQ3Z3?= =?utf-8?B?RHVpSzZMTjViNGxVUWxiR2lzbm1VWXpJNHN1cUFRdlFZN0daSG4rV3VFV2s3?= =?utf-8?B?d0hjOG8yRW1keUlBYUVsY2YrSlFLQTcxSmEybER6bE1Oa05vUFl2Q2tuTXI4?= =?utf-8?B?VDkxbFFSYnZiQVZENEtCd0JlWlhTaEdLdk9FaU94NWUwVTJ1M2pjNXA3bmts?= =?utf-8?B?cUc3K2k5dmZXb3ZVVW9QaHVSTzhETWx0djBrbE9PRlJpT3hZUHB4bmVLbStm?= =?utf-8?B?LzU5aXB1TXVlUVB1UHZwa1dsVmUvSFIvOU81eEpCa3QzMFhybmM1Yi9lMDc0?= =?utf-8?B?aCtmVHcyU0xKUkdyREtRdVVZM3N5bHhyZ3BaS2RMclRWRURjRHNZcTIrRm1q?= =?utf-8?B?V3J3b2RoSlo5a3FOdDRSM2lXZUV0WFpYM3lDRXNOQlhPSzlwVit0cnRsVDJv?= =?utf-8?B?aUNheUdDQ2szb0kvZ2gyNU4vUm4rK2tnQ2UvQURkZkwrM05uT011Ykl2VzBt?= =?utf-8?B?R0tiS2wyNjFUYXhCU0lSTHI2WWtOWGNJUTdoSUJ0eFVwRERFRGlMdGcyRFFo?= =?utf-8?B?K2ZMN09uN083aVpQeUpqcmllT3V5M2hCMVlrT0NJYW84WEQyckIvZUh1dDg0?= =?utf-8?B?UHhLWWs4TGJBSGZmZkNjVnhLWWVXeEpEVEFRZ1cvMVJGY3pGanRMUzluMzU1?= =?utf-8?B?ejJzUW5tampMR3JkeGdzOW41MzVrZkRBR0oyaDRZT1NhMFdZQnoyT3RFYXRC?= =?utf-8?B?dnAyNk1iWm1sYnRsVG1OdmRRcEMrc1JFNllKNW00UzIvYkgrbEtTZjMzTGRx?= =?utf-8?B?VUpxTGxuSWZwL0xPeUh4V0EzLzE3MHFJdERQNWl6TGlMbGZZNThtQ29zeHNY?= =?utf-8?B?ajM4b1hURTZESjlWNWZOYlY3VFZMcXlPamhMK094T1VwSTd4bmhCRnhjdGI2?= =?utf-8?B?c2lZeHZRZXZ2U0NCZ2xPSjhsTXRGdWFtamRMNHloU0g4d2hQM1FuMmNtNjhH?= =?utf-8?B?cFIrQkpGVDZQbWVlckdYVGVxRXJjejg4SmZQWkd3Ly9oaFdncDBKVGFjOHlN?= =?utf-8?B?RTltZ2R0QzRGSzcvQy9CMEFKWVQxOWQyclNPY0Q2VE53VlpCK3dQMU1yeXJM?= =?utf-8?B?aTVLbzRYWXVVd3ZqV2FKR3BnT2FsbVMrak1mMHRqYytmVks0MVlKaWlHeUVX?= =?utf-8?B?VTdVeWlFUWM1djZFVzV6cHRlanNSUzBYMXFCSnc2RGt2WGc3a0ZXbUlXVUMv?= =?utf-8?B?d3EyV0RDNzZjeC9FL1hkY1dTVWplY3c0dVp0MWZwa1FTRGcybUx2anA3Yjcz?= =?utf-8?B?SDl4MmlhYlFmemN6d3h1bWVLNDRMVjEweE13Ym5KNGdWakJYTkM2bEkyQW9C?= =?utf-8?B?dS9xVlVKcXV3YlBCODdUVDdibFd4VElTRzR3a3paM1JEa201M2JIWnJvNE9S?= =?utf-8?B?ay9nUDFnNnMyWDNOaWhNTUZSQnFRZnZURDc5clFTZkNNWFYyVWNUWGdqREpK?= =?utf-8?B?WVpnVzVyN0d6Y3dBSWlCRzI4c21kYWNwR1locCtHNWtZU3dGZDNYZDlNSFNp?= =?utf-8?B?QnNybVp2Z2ZDTHhTcmdBYU5QdjVMbmFxVVZTMEZjMmpBWlh2TDVHYlpmZUph?= =?utf-8?Q?aFxe4QFbwIbrVoaBBHLMpmqQg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7e9871a-bb6e-411b-fe0d-08da68ae4e5b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:11:47.6002 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pcO2wluWLekgHBZJxZRVogAer5/02K/DQeo2FDrw1agPsOt9lrIet+/wxyBTtbJbExNuJYBFa+onCYo4QWRWfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4321 On 18.07.2022 09:18, Andrew Cooper wrote: > This started out as patch 2 for a different task, and quickly identified some > technical debt, long overdue for cleaning up. > > Andrew Cooper (5): > xen/wait: Drop vestigial remnants of TRAP_regs_partial > xen/wait: Extend the description of how this logic actually works > xen/wait: Minor asm improvements > xen/wait: Use relative stack adjustments > xen/wait: Remove VCPU_AFFINITY_WAIT While going through this series I came to notice that we build wait.c even on Arm, and I couldn't convince myself that wait_event() is actually not reachable there when e.g. there's an Arm-specific vm_event.c. I would generally prefer if non-functioning code paths were actually compiled out. Thoughts? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:14:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:14:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369640.601103 (Exim 4.92) (envelope-from ) id 1oDOi9-0007Yf-FB; Mon, 18 Jul 2022 11:14:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369640.601103; Mon, 18 Jul 2022 11:14:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOi9-0007YY-CU; Mon, 18 Jul 2022 11:14:49 +0000 Received: by outflank-mailman (input) for mailman id 369640; Mon, 18 Jul 2022 11:14:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOi8-0007YS-03 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:14:48 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70054.outbound.protection.outlook.com [40.107.7.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d4f879fa-068a-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:14:47 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM0PR04MB4321.eurprd04.prod.outlook.com (2603:10a6:208:67::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Mon, 18 Jul 2022 11:14:45 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:14:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d4f879fa-068a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KHasQzxO/0bkhuZYT90pYTtviNdrzVdrrRho/xH17JhPNYUrIQRC//xpKNjV6bwdOftXgrk/7+xSIHJvlOlKHiLhEcC0t9GRqzRf++ATEtf5daFgG97Pzdw7vAZTqX87QFWMt2gJ+deowuWyuIQoaVwlocVrrbz0hgFdQaMGYZH1EWENrxWkLxYbUVM+QxU6MATYAnV7cWz1pQPA+8BAyN3P/DqPmICIPBC3pvKYL6sSf+Gb9eb/DPc93xckh3IUYUGMBcKPewFIBLLp43Kn1Lh56JYfVSlcLwmCxsvV6AenT+nYxh3yWVqgnZAK95UoPAdRKXNEzk27RD42xUUZyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bxbXKbWmJ3gL0UC7Ykboo+il6m356gTipUW+r81+sLQ=; b=a0fZwkKnKlKClFzCfWTTre2ZP0+rD7D5OaXY4jqaLRylhBy7/T1YlaT1CbxfPYGGm5OeW+4M87pBvtqw4fA43ozMyu7xdNv9riZMMmikJWGomRgim61qQH6EIlk0ffW9hFFg3E+B6JlQGrnaleLqiJoZnlFhbYlv3nOdL2lCQCAQh9MG7wqxQxrsFxceIU3gqY09MG+Ms6g7pv4MTUafA9DSxocoUaGLOMUdkf+CQ/GghGtg5/f2A4/FUnvJ/sjsYAAaRT6WxTTNbphLyMBzOIu8Ls96l5oDFJ4qoCiE+b1kS8WOvbeqZ4k7YxykE91sfiyewYGTFa4EPVH9EECuyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bxbXKbWmJ3gL0UC7Ykboo+il6m356gTipUW+r81+sLQ=; b=jXxt6jS5Acm1pfC3pMp3zZ/nnVuuX2kHWLx1u5tYm27Iv9t2vhw3Cg3hCBiku+w5Pbtn1xYFXtmnlmcR9hpVdddDNZWd96ovGwMRvjA6aMJOQYoyA2KV3PB5YwnI2oUiiZtTiQFTJwq4zLV+TxvNyDo2kpuOkOTE/UKvOOkXhGvRDHerH4aepD/KiQaPAunRvxxB2ioOOL/QK8qBE+7ifJacnmXa29O4HOUNzMtkxp4pNI2xnrTkLyOFCdyQqNAUmkJPPXxaOKV5q1WA5/wLGFVkRtouQuIMdVnjYw7bmMSr5hHEe8/VcpvU5OH1PV7AREuo7YTMLNNhPSQy/gExfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 18 Jul 2022 13:14:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e09a38f9-a455-494b-ca87-08da68aeb845 X-MS-TrafficTypeDiagnostic: AM0PR04MB4321:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: anMwTbkfpGgviYTyCCS0wDpXCnI15yg7L/6h6pgWB8tTtJDtNgkT/XGvRLmIKFwniAdRKtcmoBnmI9nsD9tA8bzUjMu2PWvL9rA+aSrAVUsrEMQ+T7ruvdgPJQuj38Skts1pyfvrWvThm4HjDbQnlWiYyQJMgRWpn2Fe9d7AbqyztO8URXxfAaFE/Hssp/PCWexDz7OX7IP+2HtAS3QlgqwnZvTGhAVuukoNh8fEQcgGijlP/gkIftmWyw9uX9IVP4VittZH/JoSQWF5m8kI6MbxGB6zx0EA54xvrvG5RQAAOrDQOI1hJbN8QDSN0tXHlpWy9t5WLqp/bZGCdJFkRc9XRKs8lpQ07exnLSBx7p/QzB8lGFfBs8PqeWVnWOER1su7IMsFriWi+qxnc8KV15WFvD8qh9QmZw2ir6YVKVb51mWMl3o9ZhthexwZ3ns/2dT9oSa31+hpacBAWMcMhqSe1FWN/x9WLFbqADNpP9Xc9f8dPSn3Frxo52w6Lgk/2S6ohzjttS3sHNnMotcxhn74DRDDQc+q6rm6QOKBGMfg/0gn+wAQMbWFNu9XsXAsXXlOks2fwwPjEkpcOY9tix/mPB8VLqwx9Cz5+dmYpXoS+H1GE4g1aQ0w01sZ4m2wbCHUf5rqnPmPAJM5V4ZmwPk1tJPPMlTYKR6P11NKKmiAA/VZ5uUu5dkZ0A+2TOIMzi4qivAag1rvwTytMH+tk+ek1sFKtSTW5mkUtEmEIINCvd+hQgW678fJ07f6dAjEi9Wh/Y4M8kufHzLcNdZIv2xNgy37wMtI3FrKa4nKQ9SLvdIF54l693bN677tigLhH6mn9MbBeMkzVredNyO/yw8RpxS8R5GOmBkyK0XTo2Q= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(376002)(136003)(396003)(39860400002)(6916009)(186003)(54906003)(31686004)(316002)(38100700002)(36756003)(86362001)(2616005)(8676002)(8936002)(6486002)(2906002)(66556008)(66476007)(478600001)(66946007)(41300700001)(6512007)(31696002)(6506007)(53546011)(26005)(5660300002)(4326008)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1BCYWlzZEw2MkZvRktNN1h2RmpwZGtFNEdkMmZkUjZCTk4zU1JKOEY2Q0VD?= =?utf-8?B?S1Irdk1NZlNtbE1tRE1WYU53VUZkN1RjdW05MXdzWDFacm81bXU3QkFvYjUw?= =?utf-8?B?N0NwWDQ4dTdFejR4eFR2ZTlCQjhOVTFCZllWWGtLU0YvdVovL3NOWml5YzRG?= =?utf-8?B?NFlVeHdWMTB4OWYyZlQySmxmUlFTZ3FydzMzQk5lMWpFNTlVU01yMXZ1Qnd6?= =?utf-8?B?bUFNRWNCWUNDZU54V3RkSDZIWGwzR2tJeXV2Tm9Ga0o5UzBNQnQwNGo2T0FY?= =?utf-8?B?RnFaUENxV0pGc3Z6YldNTHE0NklHL2NmMWhnc1lVei9KcDB2aE5YQ2d4SXdO?= =?utf-8?B?TTdDeHhrRTg3YkkzRGZhbWJpa2JKT09MVnl2dytoUGRwbTdnV1dzaEVUcjUv?= =?utf-8?B?a3JtQTFWUTJrK3RpRHZ0elU0YUI4MUY4TGk0NWRwUVZIZ2VZakFhYmVqZzZO?= =?utf-8?B?M3UrVExCM1hWek9MeUlPVmdhUGxJcnpjYi9hbjZLdGZqeHpsalJJUUFhN3ZM?= =?utf-8?B?dzlHbkJKUjRmNG9hK1F6dXk3Y1FXdVZWWUM2aFNJTU54bkRIRHhtSXBYeGJB?= =?utf-8?B?ZEcya281OUJ5Rzd2NXBBMXNBT2w1R3dBaitWTHBpeTZlV2VEdk05dk9vdmxt?= =?utf-8?B?a1dkRVUybUQzN1NKNmo4NEJtSUdmQmFTa1ZvTGpjcjM3TE13VGRheXFhbTMx?= =?utf-8?B?RXRENC9GK1BNeDBpaFRLbDd0ckJWeWtkaTQ0RE40Q1FtdTFacnU4ZXlvNVpP?= =?utf-8?B?bUVQM3R4WVpoKytaNmYraU9DVi9mSGt2aWdzV2pQT2FSb1VnSFk0bjQrcmF0?= =?utf-8?B?NVZTVnhUV2w2SXZzZ1BYUGxUUlkydVhOUzI3SE1JSmVMMVl4NFlENlpCTVcx?= =?utf-8?B?VVM4ZFVPbnk1L0U3U1JZRE9oVTZvc1g5aUxEWG9KelVjaGFzK0k0dnlSTmhV?= =?utf-8?B?eGd5MXhsVlp1VU5KREQzR2RhOEpBbVJxdFQ1Znl6WWppbFl0Y2x0Q2tGR29D?= =?utf-8?B?OVBFOWtKZGF6c3BhTVNKNzFqUnRXYWZxVm5JME16d2ZRNGJBK1VlVWpjWkhk?= =?utf-8?B?TUZ4MWdjMjhWTEhPVHRHUXg4ZzNuQ1BaQzdlZDZaV2kxRStTVnJBR250YS9s?= =?utf-8?B?bHNJakhSSmdaYVlBRmZ3T0h3L0pvMnZYeW5IQ01ZNFRVRmc2a0RHZmphbi9L?= =?utf-8?B?QlZmdW0zZlJZaHQyUjl5Wm9mZUtEUXdiYXcxWHJCOWJEaGxOTFVUaFo0WlU1?= =?utf-8?B?YlhHaDYwTmh5ZDR4eWpadGdjYld0Nkk5aXlkUldacXJKOW02NFlnY2VZdHBO?= =?utf-8?B?YjJTc2dzKzB5ZWpHbDRSNEdLbEZEQlJaNXRpbERRdm1EQXltK3U2K1VYRCtR?= =?utf-8?B?ZEZoeWpFa1ZLa2JpQXhOazUyRVlDZkQvcERwb1VvcnhXVFNZc3Z0TlpEdW02?= =?utf-8?B?WjlFNFllQjZlV0xiUlpJK3hBQmk4U1RaU3NqcmJDWnp1cTZwdUN2ZzdwTURE?= =?utf-8?B?eExLZFIvWkFYM0RXdkJQRW5jUC82UEZTNWFEcXJnN2dMS2g0RUxYbUVPalFu?= =?utf-8?B?Ulh3QXFDVnptbm4wbHJFejZNWkNvRkFoamZJMFdOQ2JxVnZucE9xTHFTODBK?= =?utf-8?B?YXg3WFBxM0NidHh5TE1WL1dWRzNuSlFuQUxmWWxaUnJHeDV3ZmU3L0U1ZVRv?= =?utf-8?B?ZzY1UTRkbTArbnFqVFo0eURGbThEVHlMT2M3U3MyN1BxdXZPK0FUTXdmYUx5?= =?utf-8?B?NDE3dFR5cU9oU1V3anZxOHZMNi9KUjkxR21INWlvQmxuOERtbUIwVmh5MHNk?= =?utf-8?B?WURVQkRiNm0vNDF3dlZzazZhNGdQK28rNFJwNnBadHZqRmJabjBPL1gzWG5h?= =?utf-8?B?UnQ4MkZ1RXlRVi9tSUU3U2lQRlFjRGtUTDNUdk4vM216cjFDOTJrUFBXODBW?= =?utf-8?B?K1h0MU1tZGJiY2MzSHk0emZudmxsalh3UndyR2FhcmE0WlRCckUybmwxUHVO?= =?utf-8?B?eDByRTM1WWIvQ21hVTJQSytWUStyR2JML1p5ZWJmTkUrL1o3elViRXJiV2t2?= =?utf-8?B?WlZ3MjdnUmxUOGUxVEczL0xpalRyYytCZTY3cWJQNkNPMDArbWtyTERBUzBx?= =?utf-8?Q?fdPGWVc+3ERiUMUcxRSZyJJI3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e09a38f9-a455-494b-ca87-08da68aeb845 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:14:45.2932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HFS3cO1fn1Ul7181+kDJpCP2qvJL7P9fU9jmal5DRHHu3cRQeeZ9E1RbVUpWcqWQyKDoPbmr3mV8UgohlV03cg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4321 On 18.07.2022 12:53, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/passthrough/iommu.c >>> +++ b/xen/drivers/passthrough/iommu.c >>> @@ -651,6 +651,46 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) >>> return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); >>> } >>> >>> +#define MAX_EXTRA_RESERVED_RANGES 20 >>> +struct extra_reserved_range { >>> + xen_pfn_t start; >> >> Why not unsigned long? > > Isn't this the correct type for the page number? In the public interface - yes. But internally we (almost) universally use unsigned long. xen_pfn_t is inefficient to use on Arm32 (and then presumably also other future 32-bit counterparts of 64-bit architectures, inheriting the choices made for Arm and differing from what we have on x86). Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:15:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:15:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369645.601115 (Exim 4.92) (envelope-from ) id 1oDOjA-00087s-QL; Mon, 18 Jul 2022 11:15:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369645.601115; Mon, 18 Jul 2022 11:15:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOjA-00087l-N1; Mon, 18 Jul 2022 11:15:52 +0000 Received: by outflank-mailman (input) for mailman id 369645; Mon, 18 Jul 2022 11:15:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOj9-00087d-Ad for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:15:51 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id faa1c3f0-068a-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:15:50 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by HE1PR0401MB2633.eurprd04.prod.outlook.com (2603:10a6:3:85::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 11:15:40 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:15:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: faa1c3f0-068a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUggHbvSrTyBGEuD/wOSwf/OJFbpYlt3KxRcROzp3ZrlyuGrg5e8BB556QgzaMUAqt8Oh4J+TD7taFrqet7BEop1h7BzUJl/NI5XUtE9dgQQHXMIg6r6hH7wz7M5MwGnLIW8W/C35+J+LD6UtsKhVjmfCVB3A4ukYINT7B16kVUeinZiHgcyEfvtJYeKjbInD9d0dL5EF2qkC7IUTshOC8tZYsGUBLVdUJ+9z9H3OXfO7VilqPn1rPP/a2FgLnXaEQr9D94zgx+rPIY++YtC3o3nXFs33vxobmrMYomgrWl6pqOFLFFcr7JWUAFsAs3OOZHoU6CL/gYrkEiymqynbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xrzJzDDfQM8bY+LD7L7cRD1hqD7raNTDQ9IkFvLqrp4=; b=bXGWIgtvW+lFjyjYB8fov6uMXSVT7oypekNYDUB4cRKtLe877n2SDE5YqcEF0zKs1h9HNxgElJzErh0ql0s2SLxI8AUcl8TMIUypZvE+6wtvWWFvwfoTYtVu9t5Ap+8uqXrEA4ADvio4OEF4VPTjRp3bu5ojXRlwP35G0jrmu1V/XrVX2tSzDHFO3JBsqgolrsco6Z43E59ag4xf9u0nT4X+PiWQtR2ntSUXq4B0AnXIhwoR49WvfS6kbcgxQmGxcGXVBv0svO1hds9whvwDYRLIfuu4gBPCJCzz11NG0pfu0VoOpYSEcqmtVCw+dptIiG3+wsd+QI5EwB4QfK1kQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xrzJzDDfQM8bY+LD7L7cRD1hqD7raNTDQ9IkFvLqrp4=; b=e+9kAq5fjN4ESRmpifuIcY4Ra5Ugcn/pwcVEKp0GvMmSy8E269dMuTWa/5RmPUMOkZkOgHflUY5QNFqg2y4jSVDg67ISUncCq54r5e+90GbCX2jXpAj9DBJwFcbrpLCFn//47GvARECBMAHz0V1KJ4D8vMrv24tY44NX1DlrbSP87HdoH5PPHxxihKhEo8SIvmRyNDttSeE4zlNRJoavTOtzV784bZJPm6Rgtl4fUTED5V/nqh6GD5pfx2E1EG4MZS2QZ+7WXCBNzMd6xYSuMjtM70llqaPA+l7X3mzjpIgX0tohcVMsfm3no6siestXekIiYFXt3XIr6YqwIikLBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3c273983-bac7-ef14-efc6-5e729d1605a6@suse.com> Date: Mon, 18 Jul 2022 13:15:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 5/9] IOMMU: add common API for device reserved memory Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <2538c56f6881e4e2a3e5cee3cbdeebb88a59ccb5.1657121519.git-series.marmarek@invisiblethingslab.com> <38020a5e-121a-932e-691b-6eaf435be7d2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 09f86249-ce15-49f4-8bac-08da68aed919 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2633:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zQL9scJHUcNonCe+/+agPMiJBgYC+B4jP0ZOaV7DcNSS8fmKNx/maXiWarxFjF4bgN4R5wCVmPJWGAiAcMigEDnVk9qqZa2vImHqHEhrqgKYaFF4TLpblX5C5XuzCLJ5oeeAe700G5r8Ys11CWHIOZDIuWZvRTkRwVUrL5COArO0eJHle2WaqJzxJHte1YZKjTjVotweC/K9jl83vEEIFdJqvdTJ5INEBvpB6AHux1nJU7Z5HGOYkhHWYVx5O3i+9nu4x5fIEM7+ll3xdjkWgGpexTU58ZmBB8DCshTi9XChAW5BOwNp/6RehfHXH/ADmPGyyjVtRfcj5xQcqAuvPFezIfQGxrqBmYTl2K05fXyUV5Hb1xbw0LKysNv/KFXTOcKz6hR1fDfxX2qyhvb+WejRVBvJZSjikuV45LwO6jrq4yRqi5cTdYztwLH5EHeQTET/UJuRRI/JK0SJU1MiSmJ6jkurI3jpynHX01S9eu4YmROXi362WNxyk17LTBTg7O7ZCPm+QDD+YNkwLg1fLqSF0xMf6JxP3s9i9KzMljlS8SviUeLlwOtEEtqTSn0/fB1Z1LqGvTn1+HsoihEFEEa0B+YtWTTkr9JK+1z2hPZbSKXceuYiuJ3pVLYV/C0RH1y+L/a+Rtc7bUynTLEDtIH9e3qMDTkQ6fhBlvDRqMAPVbNNNEpCqD334GEG6HiLs7p8Yyhsyv+evwn6SgW5zlTUwY2oMnAXbzmU/OOdMfDVjDhCvqFM/HB0g95iMHXZ8ArNIfHTAOF8qqBlTwXmDmIoZ9RzHpeiQ9rUs1c2Nhr3DsbAdr65XvDpYXlPfVut+4e9WTV+G5wfMC3hXfvDKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(136003)(396003)(39860400002)(366004)(2616005)(6916009)(38100700002)(86362001)(36756003)(316002)(54906003)(478600001)(31686004)(186003)(53546011)(5660300002)(66946007)(41300700001)(8936002)(8676002)(66556008)(66476007)(4326008)(2906002)(6486002)(26005)(31696002)(6512007)(6506007)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RklsR202WStoZlRDV0JmRkxBWnRCMjNVWlVDWWViQVVjcnBFVGJFNlowY1Nw?= =?utf-8?B?VDV3Y05NcUF3aHFhcHh0RFBZWjY0MWFYM2Ivb25zcnRzcCtPTDgxdmJxaWt3?= =?utf-8?B?UG1mMXFOcmJ4Q2N2elBXMlNHTUxMa3lPamdMK290eXRrQUdrbGxZQnBQenZZ?= =?utf-8?B?WC9ITVhEMGVtd3hQNmhERmFZK0hhTTkzcHBoZkJDVnhHWFVyaDlvZHBRYmJH?= =?utf-8?B?TU9FSEdhNXJSZmpNejZsZ3ByUzZseTRDamZpaWtlMTVDbHpxbFRFMzVTbEpM?= =?utf-8?B?S0Z4T3RoKzJPcGh3T3NualZ5MjhrWUJCMlFVemU4djRlcEsxZFNpK0k3RW9i?= =?utf-8?B?aUNTSmxFcStKRmQvMUhocnptZHZEVWdNR2doZVZYeDlsY1ArcmZmVStQV25l?= =?utf-8?B?TlVYSnBJK0FhbGdoQTNqWkJmZG9zRmFPS0JMQnR3b1AzWEZ3dXBNM2RjdlR5?= =?utf-8?B?T1JKYkUrYWZVMVQxd1lvY3lacjFGVFNGaTFkWHYyM1hubjJrL0VmbXMrek1W?= =?utf-8?B?N2RuMGQ3WTgrNTFYL2hOa2gzNUhSL3Q2T0hUeXRKY3R6MlY2SGYwMlRhZ0px?= =?utf-8?B?cDZMY3VIbVc5MG1ITVVGU0RVelJUZ0R1VXFlWVdQY09JN2cvQjE2YjkybzN0?= =?utf-8?B?ZnQxUDIyZ2IwS0VQQm9PNUNhQ0FkOTRCL0NMZ29NUlB5Yjd1d0RGdlNTVCth?= =?utf-8?B?NGpkQ2FvUXVYSks2R1lQbWtGMG9Ia2cwVnZzMkEwdlZ4emFWamZtbUxYNitq?= =?utf-8?B?c3BFZE9keThIMGZ4MXZabEtmNU9rTUlkU1hMUUI3aFdHeWZkd2Z0Y2Zjam1V?= =?utf-8?B?cTJCSDJ1NFU3VE5leVpzZVp5YngwVWdxNnhCb29WUVVWcVUwMlh5ZXp5VUVK?= =?utf-8?B?UHlKcS9BRVFmMks3ZGpZUDJYbEE3T3V1eDdkYmMvTWtlR2ZrVURWdnZXd0Jk?= =?utf-8?B?MlJuMFFhSm9VSzJWU0VsVHEyVzhFZWloOVNqVGNTTzZtalpuamdtZ2FrUzNj?= =?utf-8?B?cVJkbFdNY1lvY2orTUtZYndrNUtoRCtyZkt3RkZEMGd4YS9NYkZqWGI0eWFq?= =?utf-8?B?MlJHS3R5Z29zczdDVE5ydVp4YXcxYk9rM2Jjc29UcHdIMkhiWmNRSmhBeEcw?= =?utf-8?B?UlNQYmJjTUVmOWxJbFBsMHVCeURSUFZYYW5oS0hodDdmemtySUdYSGtyQmUr?= =?utf-8?B?ZTFTQW5EU2hrcEMrNkNxMmFWa3ZMTWlwcVBqaHYwenFFWEI4UnJjZy9oVVg0?= =?utf-8?B?Zm5qTm1xcUVJSkZoWDM0Q0ZFLzd1OXBBakMzczBsTU93V2haWFBla283QzNz?= =?utf-8?B?ckZNTVo5MGZRdGhKZjZFN1JTTVBNL3BkZ1QwNUxXSFF2c05DZFNrc3lLZ3JL?= =?utf-8?B?Q2FqL2lZWEdxOTIremhjUlp3TUZPNlFIakZuUVRMaVREZXlsdFdLaURUZ2NM?= =?utf-8?B?SnU1ek5ZSmFIOE11RFpjeDM0OEkyTTRhMjd3WWFPUGpIQS9uWTJRZGVvVGdB?= =?utf-8?B?MEVQdEovS0lUcXliOXhPS0NEWldSOXBGOXllZ2lHejM4V2pnNi9ldEFXZThC?= =?utf-8?B?RFVJUGh4U1pHMlRpUkRQbGlBNzBlcGlPeTU2bWZ3bnRjNFhhQlFSblh3eUhN?= =?utf-8?B?QWs5K2MzKzRyT3FIRURTT3Mydmc1eGZWak1WMkR3S2lVWkhxcjgyZ0tmaEEr?= =?utf-8?B?c3A4K1duZWVDZ1E0WmkvaWN4dFNmY3BwcWsxblJPSExXbmtVSitCSFBWdWZl?= =?utf-8?B?dnA4OWRRYzBNMWh5YVhXY1BkSlpqRkNVSDIxSW1YY3F4b3U1aDBNTFIvcmlE?= =?utf-8?B?Z3lZcmpoQ1ZTcGl3cW1IUWxpcDNTN3JKMHBvWHQ3VjdyUjFMMUhlc0lsWlVR?= =?utf-8?B?R1FKOFBLOUJYb2pQMTlyS1c3Mi8wSGcrbkM5ZEcxaGF2eWFqMitFaHByNFcy?= =?utf-8?B?T0s1R0tCOGZiZEZOVmtVajJMYnVwYm5ROUlKQWRXYzFqM2ZZU2pMK2J0dkNS?= =?utf-8?B?TXB6S01BempWSTdyS0JIc3ZJS1MrdkNzYTRKdFRCQ3B3MDg3VTBJL3hISmZ4?= =?utf-8?B?T2lGeFRlRjBrdVFjeG0zZEJYV25DcE5WN2ZTMWNqOEdNd1psaFFzV2lUZ0dB?= =?utf-8?Q?Mnl6j3e86iOeDtMr+T7e7dqfJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 09f86249-ce15-49f4-8bac-08da68aed919 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:15:40.3368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GoscZzy3DGFgtvyIA10POZD4YEsR59VTz+ppiu1Cq2ANP863GyjDjFpHQmy++113QH6Cnz1VlWTN2y7+esFRKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2633 On 18.07.2022 13:03, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 12:17:53PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> +}; >>> +static unsigned int __initdata nr_extra_reserved_ranges; >>> +static struct extra_reserved_range __initdata extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; >> >> Overly long line. > > I can't find what coding style dictate in such case. Should the second > line be indented (and how much)? I'd recommend static struct extra_reserved_range __initdata extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:16:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:16:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369652.601126 (Exim 4.92) (envelope-from ) id 1oDOjv-0000MN-6e; Mon, 18 Jul 2022 11:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369652.601126; Mon, 18 Jul 2022 11:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOjv-0000MG-3i; Mon, 18 Jul 2022 11:16:39 +0000 Received: by outflank-mailman (input) for mailman id 369652; Mon, 18 Jul 2022 11:16:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOjt-00087d-Qw for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:16:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 154b4102-068b-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:16:36 +0200 (CEST) Received: from mail-bn8nam04lp2040.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 07:16:33 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5818.namprd03.prod.outlook.com (2603:10b6:806:119::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 11:16:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:16:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 154b4102-068b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658142996; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jQ6SV5L2fOkcTpQm3rLauT1+hLDdkCcBmrqmoMTzBcc=; b=OU9AhmleJQzStnWEuv1575OJ6SFuRg1C126hYK6ln0VsejdTSylwNtIw NgvO7gw/tL2yJvVIB529z0Kx4USGrzYPYU/aS3TVBqgjZtLOPY1rMZf/2 nhglwiEv5rfvUwuE5URzKBiboNsqurwC2qBZ7kFYC4lowvKcxlW5FtCta k=; X-IronPort-RemoteIP: 104.47.74.40 X-IronPort-MID: 76021397 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AUy3AZK1xoYNrC85lSvbDix16xW+F8HFdZcB5h?= =?us-ascii?q?dg8jSJ0ofuS17OWlPgJJ2/OuNTVsDYEmuJDyr804BonUWBagGkjRIsJxkLyB?= =?us-ascii?q?gUPdBji8oJTg5IoOlONm5VAnqaa3fnrU9O+9hKmthIrSyPTmKRarOklrvCX3?= =?us-ascii?q?EtrcbbDs7Nly4JSzgDKJLhUv7kZ2gMOFjjsehPcIPlDr4N6qHZXCUtOmbhWt?= =?us-ascii?q?jjHZJBLw2Lm9tMLp+WPJE3hTJum6BafYImgaguqBKhnr8rRLeMAaTr825Ct1?= =?us-ascii?q?/dgvNC8klSwLa+XUPYnvMj+PgS7L1BJCeHZzXhfYX4z24erEFHSrFbwWanCJ?= =?us-ascii?q?OoUU+29MXLRorzH4WwMQtB8FSw7oJ1bDN6ChWW9ntAECTv/Y9ABoDm39re/S?= =?us-ascii?q?a5OMgu+j6xDTj1rO8cmSu7ymAhWZFcK7qwhAuUExkj5IttQXD0uolhgH8Mkb?= =?us-ascii?q?bYXQ8p2A0R2A7/yuudydW4vqNs+/fEk1qm5TUcBTqhQgMoSnYz14cJaT3PA2?= =?us-ascii?q?6Zgv5rI8Sd/y2VLyXX3y2lqMoq4scXjx/dDWge+gv8Yz68tmlVpbatgKhxMg?= =?us-ascii?q?vhIKPgRBngVnlOGZOsfJgExRY0Nb//PMS35AUHiUkvHLBhBvBfbh/waaynz7?= =?us-ascii?q?pvL6buTu5oZ+KB/gPg4kCzw9A69V567IX68sbxHfcMio7dHZRpg+PsCEVE2y?= =?us-ascii?q?AWmXd22AJbjsdjNrnNTGWZLMmsU4HwJIbOaLLgXN+oz/C/1UkAydnbGn4taH?= =?us-ascii?q?cbs6mFvhADbckjBzlvyi4MER6eRYk24mKqpJmSAhbCYgiAfmoh2sOyNjUHLP?= =?us-ascii?q?Q0KMKfJjT/DLNCFyDjbjfJOO0WzTuQWncxUSiwsWqNdB6WI7UyFkHdv/ttRR?= =?us-ascii?q?xnCRAreJ6/huss2ClWXOnC7qzScJx52t0Hn8bAzcsJ4P8qx1BkP5+4J8iisu?= =?us-ascii?q?4TSa+OcKV3l8VT0Q8s2ilEcIgRoZ5TljZZqk8mWVYW+ZbN0L8Ysq0WPvHUJ9?= =?us-ascii?q?RHFpmvYDaGqkGDqV7jIObD/0IJk3IvIW8m1hYJbAGtWqsgq5Y7eDZv6Q/NDH?= =?us-ascii?q?oPGLmAG8oefkLi8Ru1kIjFG5LtH2FftOh6Y5+qgMyBoogyc/rgeOkPOiiV3l?= =?us-ascii?q?APinq+uOox0Qmhx38gAkSTrQfvNHEADKHnaFn94slp6nSGqvbrpSTYWg/6T1?= =?us-ascii?q?MFC+AypcBjquaYTfZMAsF5fcU10bfnyVkhxTfninikiJl0DxvllrLsrgvc7r?= =?us-ascii?q?vzmGFYZ0XohpR4aIDxWUmBfco61jq4e4zrBqCPpqoSR2TDpTGOEc46lk1e0X?= =?us-ascii?q?Hh7YqT+zoWuiv/59VzAGx2IBZh8eK93BWxp0XeZjQryYrgXo6NfuPRelxfTf?= =?us-ascii?q?S7NKVyyaKxYz6ahcKQxKnX2xUQnhSanfu9vIaVshOXiQ7yTAQf1miRtDWfSU?= =?us-ascii?q?BjU86e2JZpkRiypjXM3BkzTAebpxFwZ//Kkg8MpyZd8ucIBWfmV0z6rSC81m?= =?us-ascii?q?jRyUb6/moBKHjQVD0BUb9kfr+GQRUHMhQcJitKkjoNeI2pYXEn7e1jwDtMxN?= =?us-ascii?q?EVB4TvAJn1VkoW8j0OJw1hjzsEWBCKkiFjfnJC8kda6hWiNHU/DvNnVtkeAs?= =?us-ascii?q?o4A0RFdVYFDJfCDUDJWkqWLHnxs5QCXcFnHgeY//A3yj3yimWmdvp0bLeSsM?= =?us-ascii?q?U9Q5Bik8i6zcyYrUiSGCGpuDPdy/2+H9koaBvQABZPlafYixWqUqLxERPpdn?= =?us-ascii?q?jj+qC2P2KHVPBYP5KfpQ6LAYP1l6Ch+4MDnCPFfjHwJOh6Ri806IrZ/YY0KO?= =?us-ascii?q?q6WSW4N9CLnB7XFqQrnW7qoPRvUOMW4Ko7lNCIYZWVwTnYeCxVJ9XVZSpChR?= =?us-ascii?q?5bd/MXx8qRkESpQZTA70jDf+nLOwmunR50tnPYdXmOJjri3KPF4y+cJ+6mYT?= =?us-ascii?q?DyCL0IhBu4Oqr+HhZmer6t4ZdtyZMyJ3RtY5GQJuAQKu5De8w9tugNlIIXwc?= =?us-ascii?q?VeKYifdUSmZFiHCGCV9d8wQeVFogPmwSs5+BwV8MVIFvIEyHs1CE2pDCfz4A?= =?us-ascii?q?0F5v7APn9YMXxp8QamiA0NWqtmVYkJY+rc24yKeVR4JaYPD4tdDelaSxNpEl?= =?us-ascii?q?eDRA5MjthQ4SQWcGbNrWk5nSucfR2lcocJTS0PhJoiCG4jddsIbMhoiiLMX0?= =?us-ascii?q?K16oRDswsOSptyUJQuRgLoCF07OIzytca5lbxx+VpTxa9zPvh5q5LVGl427v?= =?us-ascii?q?El+wmqfjUAJ97kR4Pw3oyTFkmJc7OLY/qjeIIeS1F+pjfXGMTfI+qkbGHmcO?= =?us-ascii?q?XlK1T0sIxD0kmA47ZxX+0jczHGLDH9ElGslqogMH+7XFiDY2qhRsO/aV27a+?= =?us-ascii?q?ZmHQD7hxrEwaxbHS0XCu+m5fP9xPZq/1GAq7zI6uRF/iBvra+Bp57AVZFxCf?= =?us-ascii?q?U47GKGGGx3JV61ph3msS4EY9K5zovE84psjTKNoLJFjvtxculYW+Lb78OG4e?= =?us-ascii?q?f7aZ0DGosybxjQsrQdOChknTk6eam49Uf/3A08=3D?= X-IronPort-AV: E=Sophos;i="5.92,280,1650945600"; d="scan'208";a="76021397" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGGkaKuofrXYQgKDtboeHNIwCdlKo7jXoehLTMQaupPzifRZskFyWT4jpzV2tKTiUUHLs1PvKrqyDWK8i74RDcu8r58NshxNQgd0nDssXfZibbINRGF/Dre5LLWRsP8PG7zkPDV/SENWIR+o9rxTIjx5VjKXxko8OdT5OPFSkPqIthaMnSFrRUuzwL1An9lNm6yu0rlt/KpqhdRw3hZe1Fr4o/6Fp1xitYnKJNfaS8h+FfZVE/vg4yhTawXQwVbcpXEinhnQB8TUbdrNhbygnYkUWwl2eBIBi3OVqVvKh7UqbtPxMqY2tLVBNFUVPcS0Bbx7Qd48yGGiSktmyBEZdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jQ6SV5L2fOkcTpQm3rLauT1+hLDdkCcBmrqmoMTzBcc=; b=e7VZxjt2TRl115QqRvTImQ8TI2omtwusGDWBonAGMCmKFpvCovSL5UIOgf7674YC4i9qP9w3TONPEPvgzBaIPfDiySYyEYvyaEvB9/yLrrnwobm7Sykh7W/YXKToor4CuzN7v+U4XkYEE2CLWLIK3I7P7udJfqHvvfCGodLNwkNqLDW6eUqqJU/Xc9/0Z/b3VQCNwyqY4pVzxLiA9fHfbpcNH5pP2rKryAL4mWG7tCJr4S9T92jmSaAFr4WJjNfgLbWRnjHPwen19voiBDduogID/GIvgo2z+OUd7KSuiB0OkGZMuQm+l9wz8RBPhF0gtXjOkMc/yveOuMf3cyO7pA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jQ6SV5L2fOkcTpQm3rLauT1+hLDdkCcBmrqmoMTzBcc=; b=k5rOji2V+a4wcy+aCs0D/mZwjAR/N/+ar2BkeWOb/tSVBs0eTJYsSnyC2UWhLmfW8WwqC1c1+iWPPmB3GWhocbGINFtHSjOV5/jMCaNCCCEHxGkVsERgaocwgSqpNw4KO8IahAyiwaaT3Qjg7K1LmqzAaSGBP+fPkJQJZAgr5e4= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Juergen Gross , Dario Faggioli , Xen-devel Subject: Re: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT Thread-Topic: [PATCH 5/5] xen/wait: Remove VCPU_AFFINITY_WAIT Thread-Index: AQHYmnajnVBD/nNGjUq8LNREqaX5Ha2D8tUAgAAH54A= Date: Mon, 18 Jul 2022 11:16:31 +0000 Message-ID: <855afed1-e65a-e5b6-64b5-1ca3d6752656@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> <20220718071825.22113-6-andrew.cooper3@citrix.com> <44a6e983-59e1-b60d-c86f-db2a1747ddf7@suse.com> In-Reply-To: <44a6e983-59e1-b60d-c86f-db2a1747ddf7@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c37f678d-d2f5-46bb-f234-08da68aef7ac x-ms-traffictypediagnostic: SA2PR03MB5818:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: terVoMA37An+bBarOqUSY1wOFWzmL1zwdmaMdTZZ3Nf4FIiXhQsfZq9tGHbMrNc/ibxxJ/yvdll2LxdxBNKvFM7Qv3+VWbcXZzHLaU4b0gHvvRJC07Vs9x6V4T+DH8Yo27/4ePGX+S5Kcwck/puMVMf0GrKTIiuiJMPljqNuiSKSBbO8hTUHGNBw+VupBYW9E0/UpKc+MUYHbrn+L16J6Nz8KaM9LF1ksuYGpiCUn6W20Q9WKRhmOHcQBwMy4OghHTXbY+hhBG3EpBNmevM0scKE2AMsWeoBlLF7mA7gJT1crnPEbMDKH2AjyCM64IrZ3AqOPrBFWmle04NPJ/Z+dXCwD8I0RDCCoI6Y82tRY/aiDdjHQ+xadtrMJ7DNpbsfqfK+Mf3ehU3gbHNyhBCC+WrEkBOV6+n212NSDZIJGEKXHZCfVOYxddhj3zMUevSh2cQUwIq20FRr8B8Y5BcRZBoLShDJBjC0MFp7hwn+bFStdM4vZzwgwssEk9XrF6Zs6L4YLiXXYDqaE7WFP2vQIe/+Ykrg4KAFxpqfnnDSE/8e33MNbY2raGoCKuCh3W1IxetbesaQfQlCcqp1xpM4+cEp+Ss9F29YzxDHyMTi4IVR+fj/pH1DC43Y+J/voaOmNsTvUg4FunRaL6+AUOMCfWQs61YGq5w4+JojqrE1UUcMkEQCA0WnDnxEapi526lEIUeuq7jFNZJ91aRXqEnqMyyYawy4cofH0dUCvrlx6HO+mFBhe76R6uwFPkHpH+Q1ZsEsE+CRb8YNPxkM75ST5LcOVmmv7RC0BlATVbR77cgLQVEuKLW7lN6eNBvm4UoeslTz5+jDfZhJsgMBkMM9w8diCrZospHy/yPheXy2Q/9yQPJ6U93ApO05I2y+We+u x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(366004)(86362001)(6512007)(2616005)(5660300002)(8936002)(6486002)(53546011)(31696002)(41300700001)(6506007)(2906002)(26005)(71200400001)(82960400001)(122000001)(38070700005)(478600001)(38100700002)(83380400001)(186003)(4326008)(66446008)(66556008)(36756003)(31686004)(76116006)(66476007)(54906003)(6916009)(64756008)(66946007)(8676002)(316002)(91956017)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RGJvYld2R0pjZUVoclE2M2hxa0dlSGFzRnlnMkZSTk9RdmU5WjNyY3JsbTdN?= =?utf-8?B?WGZBOEdza1lYcG9ralkyRVBOZlBBK0FmeTRGaENPNlFwM04rVXVEZ3N4V2pR?= =?utf-8?B?V0V4QVdnM29QTnBNaUdYZEJkV25neVJsZ0RDeUM3N0FUMUV0L20vRkE3WGYz?= =?utf-8?B?RE54T1BIakJUcWFUVlUrKzNoOGJBT2lNZ1dmV1NqbEhxSVh5bnRDd09tUmRu?= =?utf-8?B?ejlqQXhCSWdMYTdOZnZGYWczQzVuSGt1LzRRRFNLekw5alRnaEdmak1OUjF0?= =?utf-8?B?eGdrenQxQlMxaHB1RlIwY0h5cDRnV1Y0dUNiT0UraTFJaGhjeXNVdk1laHAz?= =?utf-8?B?RXZOZEwzRFVjZlFYMWo0UEVjOXhlNWl5MUpsLzhJbkN0bTBnZ2ZpR0RLNWNs?= =?utf-8?B?dEc3KzdTdEVReXc0a200N1F3bGtWUUYwZjBhNVBPU1hLTzlVcEIxVE1vRity?= =?utf-8?B?RDROaXV2SzRwTjhjVDhQWEo2ekIrbWZRSC9QZmtaR2c3ZzhVYTk5N1lDb0NY?= =?utf-8?B?am94RFhTZjcrUFRlTjFKWEVJOThMQ1VwR3BRaEV2c0lsOG1JVm4ycUswdHJM?= =?utf-8?B?aTZJYWJ1eHFCNDdjWUt6eUdlTnpIZUlmNEZZN3NoSVgxcHorYVhXZ2xYOFUx?= =?utf-8?B?enlGN1BqbUd1R2c5aXVCTVE4bGd1UnUvMlo3WHBQS2VJVGNpMHNINlo0b2dG?= =?utf-8?B?NzFHdVFOVWZlRnc5Zm1TMkJNNGNlNnZMN3Rla2xOSW1yRWlUNXc3UU9wWXp0?= =?utf-8?B?NmNWNDBsYzI2MDk3WFNJUkx2N1VkUXE0dW8xK25VWVRwbnFTYTA4NFg1b2JI?= =?utf-8?B?eVZSNmdxalNITFlYbWlFVXU2OU1QS3FodWhJT0pKMWhYb3BMVW9tcEVHNjhK?= =?utf-8?B?MmtqdmpodUg0cE5pWFhpb0FNQXlldndVUjZqaUhENnh4S21VVnZVeWk0TGJE?= =?utf-8?B?R0FBbkFua3hGZzFTNDAxNDloeExCalFwelpZcExyckFUdktvRFgwK3BIUHY5?= =?utf-8?B?L1pZMUJDenBuYUV1SUJHbHRGTU5URDZKV3ZWdzdzR3BnRGVSNWhvdVI2MGJ6?= =?utf-8?B?RnJqanF4NHdXczJMa0ZwWEtMMExVcWVqczJZVkRQU2J2dDRTZnExSW9nUEJN?= =?utf-8?B?dmtQVHovaitRSXlFRFBNVEM0RUt1Mk5RNGN5Y2ZRekgzSXB3M296T1BqeUoz?= =?utf-8?B?RVZGYW5PMzBRajVZRklyRVJCWk1yVmZKa3B5Q2VYcFpIMGZCUE5Ud2dveVE2?= =?utf-8?B?TFNKRnFNZUxENXBWYy9pbnBCU0NLSVg5Vk40eWxxdVlZY00xYVk5TkV3UE5n?= =?utf-8?B?MjZyL2JUbE1VSXlQbVYvSHZGcE13TStGalVkYWhZMjZ0bVNocjE2VjAzZDBG?= =?utf-8?B?dVE5NFNWYnpPMHVOalpnSmxBYTVBL0JSb25HRXZ0L3RNU0pwY2lrZ0NoalF0?= =?utf-8?B?WDdneENWNytCY1NNdVk1QWR1R3Y4elhKcTFZeTQwZTlUV1luc0F4OVZLR0c2?= =?utf-8?B?bFB1cDA2dmVQeVFJaWd5UGdhdEhJd2ZINE5FWjhacFh6TnZxcExuYUYzdVl3?= =?utf-8?B?NVVYNHZFUE5rMlZxMHQxaGxrd3Bsbm5XV3M4SlU5MnZZeE9MM0ZZbjVXZVpB?= =?utf-8?B?c1V3QXRyZWtKRk5TUG1zRmRCaThkaXpzM2xQUDd1eDFxNElOaldtVmh5am5t?= =?utf-8?B?Z0xwb1FCYnFCVXlWTjA1VzIzUVRBaDBsZXZDRm5SUTFKek8vQ0p5cWFmc3Rm?= =?utf-8?B?aFVHcDBnTkhFTDkrcjNLeEZqL1BDWHVtTXVQeDQydGsyQ1VKNEI4elRFZVRu?= =?utf-8?B?WXd4M0NLQzQyeSt4VGdaT2FOTVhZRmV6UmIwMTZKcTJmQ2U2ZGp2OVgvREZs?= =?utf-8?B?RldMUW9CYmdCYWEzK1QzSGo0WFEvaTlKRVFQVGhnTjNzRU5USEx4OGJUZXRr?= =?utf-8?B?MHpMalUvMi9DaE42ajFxNjlBQXdlcUlER2NzSVZDQzUzQ0JQbGhrSy8xK0F3?= =?utf-8?B?TXVucFhqelZHZXpaOXFyNXpvbG1Ebml4dUpWaXFwR0Q1YmtXWGpwYzVuR1FK?= =?utf-8?B?WGEydGVoTmZpNDVIT2x2YzcxSTVwV2hsL05Yd055L0ZGL20yeTVBSlZGZ2x4?= =?utf-8?Q?Hmj0Xy9BrTn/u3tuVi6EgNTQ6?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37f678d-d2f5-46bb-f234-08da68aef7ac X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 11:16:31.4782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mVpJECeVAUHCf74z+1EdmVotEpz3sTAG9k2fZtzHAShQmaUhndbtAJYxwFdTekR6XMlu9wMkGFznv4Az9LpIOvVpz2GsaKXyWFJ4J1cVbEQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5818 T24gMTgvMDcvMjAyMiAxMTo0OCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjA3LjIwMjIg MDk6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBXaXRoIHRoZSB3YWl0cXVldWUgbG9naWMg dXBkYXRlZCB0byBub3QgdXNlIGFuIGFic29sdXRlIHN0YWNrIHBvaW50ZXINCj4+IHJlZmVyZW5j ZSwgdGhlIHZDUFUgY2FuIHNhZmVseSBiZSByZXN1bWVkIGFueXdoZXJlLg0KPj4NCj4+IFJlbW92 ZSBWQ1BVX0FGRklOSVRZX1dBSVQgY29tcGxldGVseSwgZ2V0dGluZyByaWQgb2YgdHdvIGRvbWFp biBjcmFzaGVzLA0KPiBJIHVuZGVyc3RhbmQgeW91IG1lYW4gdHdvIGRvbWFpbl9jcmFzaCgpIGlu dm9jYXRpb25zIGhlcmUsIGJ1dCAuLi4NCj4NCj4+IGFuZCBhDQo+PiBsb2dpY2FsIGNvcm5lciBj YXNlIHdoZXJlIHJlc2V0dGluZyB0aGUgdmNwdSB3aXRoIGFuIG91c3RhbmRpbmcgd2FpdHF1ZXVl DQo+PiB3b3VsZCBjcmFzaCB0aGUgZG9tYWluLg0KPiAuLi4gc29tZSBvdGhlciBkb21haW4gY3Jh c2ggaGVyZT8NCg0KT25lIG9mIHRoZSB0d28gYWJvdmUuwqAgSXQncyBtb3JlIHRoYXQgcmVzZXR0 aW5nICh3b3VsZCBoYXZlKSBicm9rZW4gdGhlDQphZmZpbml0eSBhbmQgd291bGQgaGF2ZSB0cmln Z2VyZWQgdGhlIGRvbWFpbiBjcmFzaC4NCg0KPg0KPj4gU2lnbmVkLW9mZi1ieTogQW5kcmV3IENv b3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4NCj4gSSBhc3N1bWUgeW91J3ZlIGNoZWNr ZWQgdGhvcm91Z2hseSB0aGF0IGNhbGxpbmcgY29kZSBoYXNuJ3QNCj4gZ3Jvd24gZGVwZW5kZW5j aWVzIG9uIGV4ZWN1dGlvbiBjb21pbmcgYmFjayBvbiB0aGUgc2FtZSBDUFU/DQoNClVyZ2ggeWVz LCBteSB0cml2aWFsIHRlc3QgY2FzZSBkaWRuJ3QgZW5jb3VudGVyIGl0LCBidXQgYW55dGhpbmcg d2l0aCBhbg0Kc21wX3Byb2Nlc3Nvcl9pZCgpIHN0YXNoZWQgb24gdGhlIHN0YWNrIGlzIGdvaW5n IHRvIGVuZCB1cCB1bmhhcHB5Lg0KDQpJJ20gZ29pbmcgdG8gaGF2ZSB0byByZXRyYWN0IGhhbGYg dGhpcyBzZXJpZXMuwqAgKEknbGwgZm9sbG93IHVwIG9uIHRoZQ0KMC8kTiB3aXRoIHRoZSBsb25n ZXIgdGVybSBwbGFuIHRvIHJlbW92ZSB0aGlzIG1lc3MpLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:24:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:24:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369667.601137 (Exim 4.92) (envelope-from ) id 1oDOrT-0001xl-14; Mon, 18 Jul 2022 11:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369667.601137; Mon, 18 Jul 2022 11:24:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOrS-0001xe-Tm; Mon, 18 Jul 2022 11:24:26 +0000 Received: by outflank-mailman (input) for mailman id 369667; Mon, 18 Jul 2022 11:24:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOrR-0001xW-U2 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:24:26 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c033c97-068c-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:24:24 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 07:24:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN8PR03MB4978.namprd03.prod.outlook.com (2603:10b6:408:78::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Mon, 18 Jul 2022 11:24:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:24:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c033c97-068c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658143464; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=FntpBjMvkMGMFRje2GYFr1e6BOUS7Nh45nyJstXMG/I=; b=Hthu0PjdFWWfZsQWrgI7QwgN7fl57xsCCGEKh51YlK3G2dojxNNSp1rm RSaMVZTLq/1RqgErv1dxVBbf5muSrBeuZmub1jM48oZpaThToFOvZQ5db lpTIDgrvoYEx/RGNW8RmG7XmCJEi+DVDvMz8/t0/yurrPq4haS/m/gYN5 o=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 76026412 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:zSOSOqMer8o6Db/vrR1NlsFynXyQoLVcMsEvi/4bfWQNrUpz1jEHz 2UaXDyAMq2DMGT0eo9xYITg8hhSsZHVzYRkHAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPvT8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPnz/o3IU04YrcS58ovOEJj+ NcZJgoCO0Xra+KemNpXS8FKr+F6dozOA9lavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rn2wCWmG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFaoTFl2bcqBpAgMfKwSTqdIwiNoez88FIhlm04EY2JSQZAA7TTf6RzxTWt8hkA 04e9zcqrKMy3Fe2VdS7VBq9yFaGoxodVtx4A+A8rgaXxcL8+B2FD2IJSjpAbt0Ot8IsQzEuk FiTkLvBGztrt7GETGOHwb2dpziyJCs9IHcLYGkPSg5ty9Puup0phxTDCNNqCreoj8bdECv1h TuNqUAWl7gVyMIGyai/1VTGmC634IjESBYv4QfaVX7j6Rl2DLNJfKSt4FnfqPNfdoCQSwDbu GBew5THqucTEZuKiSqBBv0XG62k7OqENzuahkNzG54m9HKm/HvLkZ1s3QyS7XxBaq4sEQIFq meI0e+NzPe/5EeXUJI= IronPort-HdrOrdr: A9a23:rGpbmqrDl5gotZUwzVrNEYEaV5uIL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnieffFmHKc7hywlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDSq5rPw== X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76026412" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGgFZAPwdLnPPIniyNl54NOC+Gy1naCSEERmTEiswCjzKlEzPAOmmmAnmUzyt8kXxuSb/P2OyCFChEOEhY8+/tqC0IeSU+TJOoLUPkR3bsWtjtp4MuLysY4r5q3GL8kR3mkj5U5/iUbKFCn1BgDu0rGPm5Nxq20JpSb8fSy/e46DerjcTE+TM4eQMOfhvS5Lo9Dx+/IzLkLKh/0h7feeVlHJC/7aC9dP09oPbNLkhYDaoiNo5nfgYbKRQrCJvXIc64orG3obWGUkp8KhFkAT+31hqv9lTbH5tY+vUhoHTCESbyjXlVNfkDF5Zn+doS/zwi7QVQkNNEXLHEbk4Y3NwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FntpBjMvkMGMFRje2GYFr1e6BOUS7Nh45nyJstXMG/I=; b=AoqP5PpvBhd/bptuNkIquBO08Nkq58z34lSDajmMZ00933IXZtZeVqKf6KPXjJas+HPCJhizxrlM5/CZ2aGRxQaJYu+a02NIbyFnA2lbVfQleWo+BEah6CO5x8lZrI99a6BP97qdyo7P4wgvelz29WMyHgWXhaXkC6YlJi08eRjH1OqOYzT91Y8Nu9dP7dBcnp0Dmy3LkEx/B0oo3yBGDuTD+6twhdSImoApraIpoRYkt4CCS0JWRCmHIsziTdHDAJLiIO1SBjoNoGBJWjs+XvSMVrwX3MW6MF6spH9SRhww5Y8dklb46oQYwC3sibNlDXvACGflxnhox2xztNmYNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FntpBjMvkMGMFRje2GYFr1e6BOUS7Nh45nyJstXMG/I=; b=iKco8SsFG0esgmBCk2K+rh13bw4+CdY4Nk6ULn2gypKFBOGiyB8/9Vophl2+89YtFEKHFuoiqcVqj5L9/GxsegdDKgXayCED3qzWsO0XY0TzTx5Zuuvkiy1YxVSZbdl0mkOp11+VJ4NtvLrVXVGpclbGXZjtx6BCvBLmXH51rNI= From: Andrew Cooper To: Jan Beulich , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis CC: Xen-devel Subject: Re: [PATCH 0/5] xen/wait: Improvements Thread-Topic: [PATCH 0/5] xen/wait: Improvements Thread-Index: AQHYmnal+A9Ge6gxZ0OfQ7bAaTJTN62D+WeAgAADgYA= Date: Mon, 18 Jul 2022 11:24:18 +0000 Message-ID: <8a262d9b-3378-ab5e-50a8-1248a69e704c@citrix.com> References: <20220718071825.22113-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2aee8e28-9ece-46c8-4f63-08da68b00e04 x-ms-traffictypediagnostic: BN8PR03MB4978:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4U3XBXe7onKlEsWZSTGn13DWwEEa1uL6bNHF0oNQ43f+JvgSitdX+pKfpzAX35ZM6zt5JAooc3GaFm7+iWnSZy6lK/CZQF33cEyE8eni2MccTeO0H6aNqvpw2rNVvkECP7B+ks/zL9w6ZRtjOPm12MYJfY5bAI3mVWzpW0wH76btxtCbWkOX0sTt4pzf13IBf7evlCDBogmXNis9vkBsEdAt9h5Y/PWJuRtNpZEQ8fTMq4lyDesVzfCv6GWXARH4IVh//6mlvKjAXJJNBENxt35SgAJygBjB3aAOukVETqBLUrEsIM/aJr7boxbMexT62sTCYmC16zMyf7vtl9s133//QFqzsDufvVRnpHgPOWkktbhkoPZPryTnitGEXUAreay/8qmchjFIRgYAuEOclnffVOEO8Uj6WpVlU/NI4BYrZvZuvbcwlPYQtDawWtKKv2qVLmNeXwX16DfImNyumcE/cveMbjq6V07Zy8aQsmfyHgC6jmFJ4ZYd/ExejLC0pJt405JOOTeCn9dc88KYRwJKKbrfX3MS+XoEW7ggtBFDUTqlSJjVtvJEvDdFZNuh5NgNbVs1uQgnypz2wy6Rfv49DSr47OmxpmhqxEtPWxyq2hYF0Oi+b0C/Ke+cW8O+XPNN6bS3Fpsdq3qVxeNlkdfWh9CwrLcLq7VbAbCUxT59jWk6W5D4s4Z+JSAn/yH+rZo8ckPR/pCZ+21JuxCMGRq84uaKI1asjI4p1EBCwfO6U1Djw0HDSMu1cGlxeAubZFTwP3faFsCiO9+HRhjiWiC86plzSrDhoyfcSEIJBhFeQAxEwtHkAnvKq+QRELsSDuXO13WntpLAsKy0cpL90JvdwKBf6EAqzUMP3Mi/usKEz2ydUf3ceuMgURFHcZp2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(346002)(396003)(376002)(39850400004)(122000001)(41300700001)(316002)(6512007)(110136005)(6486002)(6506007)(26005)(31686004)(36756003)(2906002)(38070700005)(71200400001)(66556008)(76116006)(38100700002)(5660300002)(66446008)(64756008)(82960400001)(8676002)(4326008)(66476007)(91956017)(66946007)(83380400001)(8936002)(186003)(478600001)(53546011)(2616005)(31696002)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UDRrTnhKLzV1c1FBMk15cGhDKy82QSttMjV5bWpyVGN0NVF1TVBFeCtwRkVC?= =?utf-8?B?TTdZV1lJS0l0bDNxWUxaUXo3M3hxeEZZejRxMVIzSE5oWmZTKzlQN25kUm5G?= =?utf-8?B?MCtweTAwbWRINlZzd2EyZE5iN0tHTHk0RWRlcHdBWTUxSGpNQmp4RHlHR0Rx?= =?utf-8?B?YlN3SndkZ3dMVVhzM3BRMUkxRjBvSVhMWHFtQWpMclFpakV5VzA4dGlXc2x6?= =?utf-8?B?dmUyT0Z5ZVl5ejdQamdoR0tCR1hqZTV2Zys3UnNLUzlXbmNpb0dScnBsZWpp?= =?utf-8?B?VUptUkNwMjZ6WDEzTFVDaEFaRytrZjRKUlBUSklEOGZTVWs4L09ybGhZNjdE?= =?utf-8?B?Q0NJa0daenU5eVppVEIzR1Z2dUpBMm50OC9zN1ZieFpvRWxMMjEvQmZ1czN2?= =?utf-8?B?VXNteGc5c1NEOXlwcCt1UG5oeFRGN1hKeEhsckEyMW01VjFNU3hudG5YK0gw?= =?utf-8?B?dk80dVZCTElzY3ptbmd6L2Qzd0xhNlIycmdqc2dkcEVTeUZIeDZ1Ulh6MkN0?= =?utf-8?B?OTNIL29FV0NDMW4yNUZGT2FsZWFDTmFBNEo2WlFsY3kySjJCUXE1Qk81UzdF?= =?utf-8?B?N1krSEJNU0IyQzlkRFlndEJ4TDVnTm56TURLNWR6eVBJbmhtMENoaTlma2ZN?= =?utf-8?B?OU9LRlVnbGpma0tJbmVRenlLb3BOTGM0L1VFKytETGdUdXFvSVFVTEIrRmxH?= =?utf-8?B?amlEeSthQTFyUzdTY2l6R3poNWZhV2FjeGNqMXhCVDJ1NGh3YzNwRkVJaGtz?= =?utf-8?B?Ulk4b0NkY1p0RUxhU0g5bklxZzlGeC9HY0IzQjRueVM4RGpjZ1ZnaE10NVBa?= =?utf-8?B?K1VscnRJcnh0WHlLekZLYU5WM2FySVBURHk4R2wvMVdHTU1JU0R2eWlHaEEw?= =?utf-8?B?VnhWK2MxTDNpV1lqVGFCOG90RjZRcDBXT0JoZ1lFWWdmWkZiZGdJTVRpdGk2?= =?utf-8?B?RFYxaCtlL1FLS25na3RmUWRmVCtHYkx6dXVEV1dXZ05sQy8rb3ZHRkdxRzdi?= =?utf-8?B?SjluSTRGbGtXZUwzbmJZeWVudjFiUFJtRWUxblRLdkRLRGpUbXNnK2FmdTh3?= =?utf-8?B?U1dlOEJPdEVXYnFVUnA3dmhRdTdkaWNOWXpjQ00zSjdKL1VMWE9aaG1QU1U1?= =?utf-8?B?aFgrNXJEbkx0QWJQWnlxbU5pK0dZUXM2TVZ4eUhpbGNoWnB6T1J3cm16VTVC?= =?utf-8?B?eGVBN2IyRjFuU05tVTlPdjd1cWlrQXY4d3NNWWlsTkVoTC9oc1VlVEZzaml1?= =?utf-8?B?R3ZPcG0wRWFOa1hkRjl0VkM5bkFKS2xFTHB0MEpoM3VkVmJWcWFpaC9JV2gy?= =?utf-8?B?QzVFUHBXZ3AyVnNiMFFObXFlMnArYVNyaU9zTmh1NmQyeVdlZmlYUWNOL3Az?= =?utf-8?B?Y2U5b3Q5NVV1a29mcTF0NCtIRStmaXl1b3dPenZhT1N3TlRYVkR2TjRnTWNV?= =?utf-8?B?Um9QcEJCbytsMkhOZmhFU1VhWmp6UE5lemdvU3RaV3hBSDFHVTNkSUNMWGF6?= =?utf-8?B?VGp1WjBHKytUKzVzM2VKWFRDWFZMQ05jTGxQWGFmM0hYY2ZsczBxVW40N01T?= =?utf-8?B?UkRrYXdVcXVqa21mT3NwOVFLVURROFJYcUVOL2ZVQ2dvdVZTNEs3YTFQbUhh?= =?utf-8?B?QnpTdTdrVTQxQ1NyWHUrWmp2c0h0c3ZHR1hWdTB3MzlBYS9LTml4QkNrbFRQ?= =?utf-8?B?anJOWW10U1p0cUxBU01zcnJrY2k4U3lKQXJMaHM0L0JkcDlYMGZFUXFCZnZ6?= =?utf-8?B?TjVpb2tYd3huNnFsZWVSV1dxdDRZaGs0YW5VMUVwbWFUMk1YZzN6T0ViaGI5?= =?utf-8?B?emxYMTJVTG1xU2IzVUQzMGhZVzZ5TzhteTRQT2x2d3Q0WFlxR0FEZlZJRndp?= =?utf-8?B?YnJnNUkrRDA4aXh6VUpwUGsvcTRVYVdLdkFnYklCTE5oQkJXYlpmdW9nR2V6?= =?utf-8?B?VkwxSVpQUm0yTWVxZklBSjhJSGVZM3RlYW9LTVJsa1l6amoxV0tkbEJqbFpG?= =?utf-8?B?TU9aR2pSbm9JVWM1NlhiSDVWSFBmeGRNZ1ZDUncwdEdpdVdmWlhPMDkrNVZL?= =?utf-8?B?eFRQb1hOV1NJTm9ZOENwS0twRnhBK1Vvc1hkdGJEVWZ1K2hIbmZSYm1BTTFO?= =?utf-8?Q?pM1fsPBtWir3u88YZ7Qf/90cZ?= Content-Type: text/plain; charset="utf-8" Content-ID: <3949C975853EA442AAE013A8A3BD3AC3@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aee8e28-9ece-46c8-4f63-08da68b00e04 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 11:24:18.4574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w0G3bYSK6jACZ0CESKjBFu6dCVchH3XKz6axeTtVnsAewAaaOUwJr1ImDyeebpO0O2XxsBvineRIIYw9REBakMOoxxMr7H0O2dizVyVvJKM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4978 T24gMTgvMDcvMjAyMiAxMjoxMSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjA3LjIwMjIg MDk6MTgsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGlzIHN0YXJ0ZWQgb3V0IGFzIHBhdGNo IDIgZm9yIGEgZGlmZmVyZW50IHRhc2ssIGFuZCBxdWlja2x5IGlkZW50aWZpZWQgc29tZQ0KPj4g dGVjaG5pY2FsIGRlYnQsIGxvbmcgb3ZlcmR1ZSBmb3IgY2xlYW5pbmcgdXAuDQo+Pg0KPj4gQW5k cmV3IENvb3BlciAoNSk6DQo+PiAgIHhlbi93YWl0OiBEcm9wIHZlc3RpZ2lhbCByZW1uYW50cyBv ZiBUUkFQX3JlZ3NfcGFydGlhbA0KPj4gICB4ZW4vd2FpdDogRXh0ZW5kIHRoZSBkZXNjcmlwdGlv biBvZiBob3cgdGhpcyBsb2dpYyBhY3R1YWxseSB3b3Jrcw0KPj4gICB4ZW4vd2FpdDogTWlub3Ig YXNtIGltcHJvdmVtZW50cw0KPj4gICB4ZW4vd2FpdDogVXNlIHJlbGF0aXZlIHN0YWNrIGFkanVz dG1lbnRzDQo+PiAgIHhlbi93YWl0OiBSZW1vdmUgVkNQVV9BRkZJTklUWV9XQUlUDQo+IFdoaWxl IGdvaW5nIHRocm91Z2ggdGhpcyBzZXJpZXMgSSBjYW1lIHRvIG5vdGljZSB0aGF0IHdlIGJ1aWxk IHdhaXQuYyBldmVuDQo+IG9uIEFybSwgYW5kIEkgY291bGRuJ3QgY29udmluY2UgbXlzZWxmIHRo YXQgd2FpdF9ldmVudCgpIGlzIGFjdHVhbGx5IG5vdA0KPiByZWFjaGFibGUgdGhlcmUgd2hlbiBl LmcuIHRoZXJlJ3MgYW4gQXJtLXNwZWNpZmljIHZtX2V2ZW50LmMuIEkgd291bGQNCj4gZ2VuZXJh bGx5IHByZWZlciBpZiBub24tZnVuY3Rpb25pbmcgY29kZSBwYXRocyB3ZXJlIGFjdHVhbGx5IGNv bXBpbGVkIG91dC4NCj4NCj4gVGhvdWdodHM/DQoNCkkndmUgYmVlbiB3YW50aW5nIHRvIGRlbGV0 ZSB3YWl0LmMgZnVsbHkgZm9yIGEgbG9uZyB0aW1lLg0KDQpJdCBpcyBvbmx5IG5lZWRlZCBiZWNh dXNlIHRoZSBldmVudC9wYWdpbmcvYWNjZXNzIGludGVyZmFjZXMgc3RpbGwgdXNlIGENCnNpbmds ZSA0ayBzaGFyZWQgcmluZywgYW5kIGV2ZW4gdGhlbiwgb25seSB3aGVuIHlvdSBoYXBwZW4gdG8g ZmlsbCB0aGUNCjRrIHJpbmcsIHdoaWNoIGlzIDExIHZDUFVzIG9uIHg4NiBsYXN0IEkgY2hlY2tl ZC4NCg0KSSBjb3VsZCBlYXNpbHkgYmVsaWV2ZSB0aGF0IGxpbWl0IGhhcyBuZXZlciBiZWVuIHRy aXBwZWQgb24gQVJNLg0KDQpUaGVyZSBhcmUgcGxlbnR5IG9mIHBlcmYgd2lucyB0byBiZSBoYWQg YnkgYnVpbGRpbmcgYSBuZXcgWGVuPT5hZ2VudA0KaW50ZXJmYWNlIHVzaW5nIGFjcXVpcmVfcmVz b3VyY2UsIHdoaWNoIGluY2x1ZGUgYmVpbmcgYWJsZSB0byBndWFyYW50ZWUNCnRoYXQgd2UgbmV2 ZXIgbmVlZCB0byBwYXVzZSBhIHZDUFUgdG8gd2FpdCBmb3Igc3BhY2UgaW4gdGhlIHJpbmcgdG8g cG9zdA0KYSBldmVudC4NCg0KV2l0aCB0aGUgaW50ZXJmYWNlIGZpeGVkLCB3YWl0LmMgY2Vhc2Vz IHRvIGhhdmUgYW55IHVzZSB3aGF0c29ldmVyLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:32:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:32:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369673.601147 (Exim 4.92) (envelope-from ) id 1oDOyZ-0003XL-M1; Mon, 18 Jul 2022 11:31:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369673.601147; Mon, 18 Jul 2022 11:31:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOyZ-0003XE-JK; Mon, 18 Jul 2022 11:31:47 +0000 Received: by outflank-mailman (input) for mailman id 369673; Mon, 18 Jul 2022 11:31:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOyY-0003X8-1n for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:31:46 +0000 Received: from sonic305-19.consmr.mail.gq1.yahoo.com (sonic305-19.consmr.mail.gq1.yahoo.com [98.137.64.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 324fb479-068d-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:31:43 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic305.consmr.mail.gq1.yahoo.com with HTTP; Mon, 18 Jul 2022 11:31:41 +0000 Received: by hermes--production-ne1-7864dcfd54-gln7g (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 6f21bd833f494b9154abcf7d0f4e6dd9; Mon, 18 Jul 2022 11:31:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 324fb479-068d-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658143901; bh=vU3ZLqrkSQIaJtC6Zr4tW2XgNY1XaXjXDHRa4si9P9Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=oPYNapj14JGsOS7fJFGjI+LrA5nNdtYn9td8zrCbJYSEM7TcVdxtJ/T1OCjWwgJC/5e5UVr9pYmQnbgnrkMQKF0z/y8T5cfHdrHG7lTJQCyIibosYrpGmiLiNv6QCpgqE9vb6jxUAN3iCnbzX1RdVHINPx2GVJBmVg/UXprpqf+JN9KNdn7BkXP9iZ4kEjvMnLV3MBgo14vfTRjnfn5hmfIdSwh5PDtAveYr6FXOQREts6/cYsNTlAlQEFdU0bqkbgJ3L6UhIRrN6gJemBPJnTpvsgLT3Q6ZISDSRsh7Ho0PolX2GoZYMCUJ+iDhTDRbNzUGU2jfRhxivbCQA4gwsw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658143901; bh=wwUT/2GVX9bgSP9JuL8dtb1HFyBJuTI3goTr/Edxfai=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=s71RGujzCiw2tODvXD/dVyDC7f/sqmsmHT4wIHAzxWUHncxVOZvspfoMoBBdObNQgwajcdfof2BYqO5VXTf8MFLdiP4sSxHsWotMyJZ+KMrDjkmkrM6jkN/6rMdrB+gF5WQJdUCYtHO/8F6mH5A89Q9DKhAkOmuOD+/T0VL2ZniGhhLkyf6YvDN/baYfkSkPMSmplkbfD2gVMT+3Q5YFURs5FBycKDPfE/Sc8rtHKuthcuPo+l7nqqLQBuoYwZPehCY3Od+xvVsS4JyQIoWlTo5f+DqYaNx8ofar88HOUyQim2iw7ibRY91dgyu3kZzCAJxeJbzvvYU2zVG0MQNfiQ== X-YMail-OSG: fHo10v8VM1nZLCPyFeGtx9WXzqf5ZY2n9GOP9e9q3ThLL78RO8XSSpXsabO2wJ0 Sycro7ZYBa5ROubecEAAiPDOV5XlfLhouQ5xi0NDzhj18HpT8NLRM83j8kRY3nHwZa87sN7nAmGm quvd_2GgEcDugPHGszX65Q7Cqpz_zATGtf.idGv3ekmWkWE5.wsFhkIpPACMY5K3CijVctehJxWS NH6Gt3uD7GBKtQoXedttQ5n4VRDCo7vZPwIYznn_kkWikFU2ka.RSqAwLxzN.ZCXhLkUIFb4GWa6 zKWJ26a7MeNkGkzzxRTtLvwquwDnVF2b88cTlPIeyymIbfbU.NttN46kcopVmdrv_yUklxj85bgg 7RTXwUGk8rdy2mpSNmYsXfWKGhs02.ku7sGKVreupxcRqyWuv5Oft90e0yE_yL3wcLpWB2AFhA_Q bKeA8LdZ1ybvkvl2dl_m7W7JDsbBuoqaJ0x.SLh6wZQxvI8MHQj9tRQ1gwelN7ARoHdTtZrSkiq2 resMfogYX0v6k4E8zisERd8CE1ZP5MgQ81Rslxd5v9agw9EES_I2Na7o44JsogYhWcz.XSdHM3Oi 2o13081lT9d6lGxomhGjmVUFGXlPkf1zMMtLnAhbxByNyLlL3PrjkaUzUi86afQk3tdXy.GWjWRQ wGCDZZI.r4y6ZmUzG.n3HJTE0VUcljuk7YAHRAIb.Ru9umKJ_H2hTVOaFDwCyUZnfCN5IDqz.jtZ WFE8v2IV1dWusKaBRi6o_vbl65SY8Kk4kkK4ZGY1cx.XGPQxbllJuk4ZClyw_nKQfcK7TISZguLs 27WIL6duyfnUG9tCRtjVOkgG6Rpvtp40FYn8y6M32FwkSUVQkpiYIxoSwNxhsPwbiP1sRYKESj.8 bCrYLmj3z.RMGpg3d4d8iZqKZ9L81q7A06tx8Yq80qCLsMUPUpQnSxPrzgoIjABN1wMLtj7HVA5n ml8XHBMWG3nFBc4OgFKj0N_.3rOOtdMe0ddTM7vKzJxsuNY1sncaYUFgdtSjOO2y_vnj3jKSryNc POt384.0zPfCT6pqQ6ByQGJgci53jMzY0ces0WABSJAnTU9f03bKmXYrQS0eY6uU_b6WmqCu2.O6 zvjiMjMIFecmN5HGfxVaoMs.79LEq28Ak6LT5JcjQowFDqtbM4J7i0hqhgXgsMZkS_4_eVI7zCeA hkiSdVwJzWlNVGb6DWvWOWCdsJlhjrZ8coyFJniLpLfk12Z2tlZ_4xplCODdt77lDRDFanEP5mTl k6d9pQjdDJO9YMCkp0xlyjMvWX8dtlmNhEymB7MIKxwCUfG8sKFeP4O6iNplkW0x2UQXdSNaSfli wO0FyLdfHfEO_ovQYnOWInXOToJvISFSHzUB0nJ39Svty6f0unawJsY0bxxPj13uQ3pqL1KZrCS3 QZeR.EBjbB6p6q_7dQHvVxlNZulMcBxVYAAlCYMNsTXW0NoI4MSobXk0cBFLQdLVFjFj5omygw.P VXubNv7gXd6h89aKro34_miJaBqP.R27IFsyfi.OS4iu5sQWMJpPpDoEcM4myiueEkrbH6oMBIkG 0ezBUbV9AFV6UOi3YJGHebtcSbQsN_P8b1Tn7APr6wSveVKsKLcoqnmA2YyVpG3CusMS0TZPE_4J mIbupF8W4cm97b5Z1vVUrkJ.uiAKrVcfGOd4oYSdghKM1oVYPsWe5.scEbHX.wHnwt2P6ZVkg8Ix iRJGKSU51GqIBTZAiIWj3V8sUzecqPZAEtusTHlHoCwM87jS2BQb7cet03bP5GeAhdqeP.amD8ih MnMZApqzKngK3JXKkSXDdCOIjgRiI4jCff3G3X0EtU1GAewmeCkgo5jyJeT7I_tIPNmDXv16fN6B sNbGEppApl0eJCIUT3q0b5Oe25InsXAnxsAzYvcg7eMUWklpkUFCQAimiqJ90LMkpGY99LJSqQ38 inmkB0FG5EBNf.wNCBN.ReK.yXUbsvaRfg1XJd0WxFWRNgbte X-Sonic-MF: Message-ID: <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net> Date: Mon, 18 Jul 2022 07:31:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich , Borislav Petkov Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Dan Williams , "Kirill A. Shutemov" , Tom Lendacky , Jane Chu , Tianyu Lan , Randy Dunlap , Sean Christopherson , Juergen Gross , xen-devel@lists.xenproject.org, stable@vger.kernel.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> From: Chuck Zmudzinski In-Reply-To: <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 1754 On 7/18/2022 2:07 AM, Jan Beulich wrote: > On 15.07.2022 21:53, Chuck Zmudzinski wrote: > > Two things I see here in my efforts to get a patch to fix this regression: > > > > 1. Does Xen have plans to give Linux running in Dom0 write-access to the > > PAT MSR? > > No, as this is not technically feasible (all physical CPUs should run > with the same value in the MSR, or else other issues arise). > > > 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? > > Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I > don't think there are plans on the Xen side to support the MSR > interface (and hence to expose the CPUID bit), and iirc there are > no plans on the Linux side to use the MTRR interface. This also > wouldn't really make sense anymore now that it has become quite > clear that Linux wants to have PAT working without depending on > MTRR. I am not so sure about that, given what Borislav Petkov said when commenting on your patch here: https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ Specifically, Borislav Petkov wrote on Tue, 5 Jul 2022 18:14:23 +0200: Actually, the current goal is to adjust Xen dom0 because: 1. it uses the PAT code 2. but then it does something special and hides the MTRRs which is not something real hardware does. So this one-off thing should be prominent, visible and not get in the way. --------------end of Borislav Petkov quote----------- Jan, can you explain this comment by Borislav Petkov about Xen being a "one-off thing" that hides MTRRs and needs to be "adjusted" so it does "not get in the way"? Borislav, are you willing to retract the comments you made on Tue, 5 Jul 2022 18:14:23 +0200 about Xen? > > Jan Jan, thanks for answering my questions. Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:32:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:32:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369679.601159 (Exim 4.92) (envelope-from ) id 1oDOzL-00046w-2u; Mon, 18 Jul 2022 11:32:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369679.601159; Mon, 18 Jul 2022 11:32:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOzK-00046p-Ve; Mon, 18 Jul 2022 11:32:34 +0000 Received: by outflank-mailman (input) for mailman id 369679; Mon, 18 Jul 2022 11:32:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDOzJ-00046d-3t for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:32:33 +0000 Received: from sonic309-20.consmr.mail.gq1.yahoo.com (sonic309-20.consmr.mail.gq1.yahoo.com [98.137.65.146]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4e101a37-068d-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:32:31 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.gq1.yahoo.com with HTTP; Mon, 18 Jul 2022 11:32:28 +0000 Received: by hermes--production-ne1-7864dcfd54-s2f4b (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 5f85adc2208b756781d6358a6215d965; Mon, 18 Jul 2022 11:32:24 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4e101a37-068d-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658143948; bh=vrfJ9pyqjWpK7xL7Agn/Qyz9mLq/DkPBwszWxndRwkw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=aVUgLDjdoRtoM7Su17+uh5Ph70eJ5A6NzAQV7WqnaRkupPA/5sqR7lYZ/GfTfwH3QSVNmD02omwxJ95VjQM/gSw9RmvzzqMVTWlBl0X2yPE9SpnB36O3KeyHj7SUovJbUEqUELNCYfFSkWXOSoGNzZUl/iPntFLpVVJJplwjW51eM8GVjmOuQ1CDluZ89+3963i0W7MDrCsxlz8iiVIz9HLg++fI05KFgYWHjxe9z9GSBWMCUfTbX0FEUoDv+5lWznNnAibShLyPLxp7jOX4rdua8fbwVf0Ftx4v5UIYNyF9JBpow0kchR5TO/vmJKD29DA8SdIlPz9Nf5qCvGyLwQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658143948; bh=pLWoEJP5gyWDQwvGvWcwstoh/8L5KauqGMcTiDSVn+m=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=XZZVVlT1aR25OfUfsDS9DnhEPzfZvtCkLnoj5GMGNvwv3517Ke8byGe//up3U8OEW7mn4OD6tmgaL5Jqs6eDh2A0r26+MA0YcKso2ywJeDQKbwvkBW2DHrb418VDnTq+Oj7SSOY3khfHR3v0iodl8cuxQEfUzPDtyMXjJ4AWQpXkYVID3C0LpdUpanvxvhQu6rhWaIkvFuKtGAbwTGREP5q8ohKy+4+zOpDxjwHc7zw69J+23+mYjX7GXq/A4qjRkBzuIGKSuHqeFQQlv6+33C0At0+ouTfBfBLAMtPha+gADX9s3/+AZ3SI/wKEFmFaHcJ+AVEcJ++dCxw7D0vrcQ== X-YMail-OSG: iPgMkIIVM1m_mM.C9E6stDxh6XaPikarGZGOdGjWjq355k9cvwWaGxdt3TVgK0k XOhv56ChvgvZ.8Sjtz.fBlqqScrYXUuo10KIDFycg8H39F.opllfBgwDTMnVwf0gRjE5zMcrMz6j 2PfVHi.zhWOkVapgmW1nqpVgv4rRxCqszb7hfcI1TsMaM_v.cex47uLa4Aj8nmGX8wrzndDkyHWl AWuT1uJRuXnu8ovfCEAwwD7_1f6_CO0fab7sqUYv8rCESr_7sy_KQS7D3HoIR.3VqmnhxavFfVYl GmMmkh2FH_5iqZxQHGGFePg9zPnxiK2rFF5Ha7MGv1e3AjncpknD8XIFcvAv7hDcnMYuUwiXaCTI Y.9vkmz0sM2YOxl83CcxNvQRspZxv6p_txwWViVa.Jtlc_UT57BVIiUYS7PHVllhXkDBpuopoQDU eGUIP4oskGwMIksHGne3uuniRO6JyHqz1vk2qrR6_N8vput5yhlaoE4fsWPxBijR2fseVRX1fkCq R9EwggVpjIWGQKKzB.XnmfuJoGtodtVLVndbWUlLNzH4Enap0rVVCxaFAtMoSKZ2exAk8udcvx0O bMSpI1EfmB6..KgPVF6Qqsun0QJBG0LQi0z_Jbj0.dWZc001RIHWdUPeArFWjpCjc70bNf7vveuZ RZdIOO3eKTsFabQSuKGy03zOdnRniEuCI4q9WDIVC.ue1vibg0BnirAZeOipL0zAXzb7QNM.PTHW uvj7eMuayku2T3aa9WeKyT_EeC.IdmRrK9YhKvGqCJolWLr3hChRz.tr0XC9PJjqfMd8v0ftAD5C tu6wD8jYRnWRd3eT1SkqzfegndnOVxjlvlBWkQ9IJnQTZwXiLVxfaNkKX8QKrvmwY.VBTCk_BeC. 37nkHdXVwirUsB4iDU_8t5vKmCUgGwQvc1UDWNu36.1WmneQxgXQjXEruiCLPPg7HtGuqkKLRaoF _3fUd8TE.nRcj060dlvhtkZIjEbg4Db8oZQYEG75BfPPCmat14gqV0gdH4ylKwPfio2a.8ltO0Wn cIXOkltfFiyjXoPAEFtk9GKeH.mp9CzZUpG8ENBWeDHPet5UI4ppsPXm.UT6Cl8jnhQywj.KBNNP .0FjGx7NSMJskV9dj08K6iy0u0riSwZDC.fltw1W62V5hyalbb6fSdfoCZAH02U5qr0oga8neLpx xpWbiA8BZt7gTDEXm3SmnHtzbo3Nl9VQAW2Xhs_3mkfMNdoe0KLM_CJtfYMzihUr6f_5Op9_PlpY w.ZRL3iVFubrfFMgvVn_RxLvwPsW7Df2Z0GKNxbejX47puc_rCO69LatVfC22YM8BPpdvgC3CwG. O2zgsCqvZig9j7GHYZxBRPJ7vwgh0q6dRYFGS86ljHK6btQ5dHhUksAQNs6tFCm3n1jlsdcGvB_h oRWa977CQ5TRZcOeoUj7LhxnUP_TdpX.TJSdbRpflSQ3nwI4TbD.eib1kX.AHUFEtUBI4hcAjtwu pwdAZOCK98tdHCmxYon9YA4sUk5n37CtZt72YxF_rbCBW4fDFa7ljY3UuVLUoKd2woFQ3LQxO1q_ dQVT8QUrY.KopxhO5BFdIcoF3OVkxUu7fgu8f4Xnfkx9LCqGbuXxifdANDqY2XGAIZOlF0MEEADF LIkQTfnTJzNzbuk7.7IbH2.0SDgAt32DN8_9HkWXaprAqc07h5.31G0Y5czSclilcXH_oj1KPbcJ Lk_j9ClVg3cG8FQpAA5yzXPE96Q3AH5sZjxPEhEYhIxIm2fRpkDyKLIVBzm1iZSu0am3BvEyC223 ff7ZFqR9deX8zO0Ec1om1pBIzEnrkZo.1K1sSkZlvkBCza2FuIP9WQEs.urGq3x721cHZvoNKWfg HPVYI3W4Pmfl9pbGaJb6A9d7CjDV3RrD9tEEhWYpiUkR4x3XaOC7F_Vji_8Sqi5kkwPyIys0lyXg GLP5ABzv77Vqr1sBXP32jG2JmKc6fvmJ6d6X3MfiL8RW113JV6PTJx7fUWoA0pE1y4zzJn5RxPxM u78uIorfTjXiZTxTaak_xmnN2KIetb19HD5BCLyip1vlQ8.x_vCnweRHOHEH.EGcEcr6DcfIxynJ aMxI0uDjQKa1gxPZcakZI1zDA31jYob59PeqK3HNKYPG5ciGEnWujQ9RZ041cc_s9q0wbULXq.KI 3yKCr0nG5c2aiN2U.Nwbx.75tMeP9tnzG6KzR8oua.vIG7HqeA42jnOWo.KOndi0GvODLE2vpNMs KR07HDMRIpvjZ281y6670VmNwC6UkEr1dAyb7Nc3v1brJQt2h9UkvHEiX3BuYAkA3z6mqNyD.7QM z_J9YKA-- X-Sonic-MF: Message-ID: <4ef8c3ae-b365-03ba-0e8e-9f4a2bf53748@netscape.net> Date: Mon, 18 Jul 2022 07:32:20 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US To: Thorsten Leemhuis , Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Borislav Petkov Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> From: Chuck Zmudzinski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 6687 On 7/17/2022 3:55 AM, Thorsten Leemhuis wrote: > Hi Juergen! > > On 15.07.22 16:25, Juergen Gross wrote: > > Today PAT can't be used without MTRR being available, unless MTRR is at > > least configured via CONFIG_MTRR and the system is running as Xen PV > > guest. In this case PAT is automatically available via the hypervisor, > > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > > > As an additional complexity the availability of PAT can't be queried > > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > > to be disabled. This leads to some drivers believing that not all cache > > modes are available, resulting in failures or degraded functionality. > > > > The same applies to a kernel built with no MTRR support: it won't > > allow to use the PAT MSR, even if there is no technical reason for > > that, other than setting up PAT on all cpus the same way (which is a > > requirement of the processor's cache management) is relying on some > > MTRR specific code. > > > > Fix all of that by: > > > > - moving the function needed by PAT from MTRR specific code one level > > up > > - adding a PAT indirection layer supporting the 3 cases "no or disabled > > PAT", "PAT under kernel control", and "PAT under Xen control" > > - removing the dependency of PAT on MTRR > > Thx for working on this. If you need to respin these patches for one > reason or another, could you do me a favor and add proper 'Link:' tags > pointing to all reports about this issue? e.g. like this: > > Link: https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > These tags are considered important by Linus[1] and others, as they > allow anyone to look into the backstory weeks or years from now. That is > why they should be placed in cases like this, as > Documentation/process/submitting-patches.rst and > Documentation/process/5.Posting.rst explain in more detail. I care > personally, because these tags make my regression tracking efforts a > whole lot easier, as they allow my tracking bot 'regzbot' to > automatically connect reports with patches posted or committed to fix > tracked regressions. > > [1] see for example: > https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/ > https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ > https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/ > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > I echo Thorsten's thx for starting on this now instead of waiting until September which I think is when Juergen said he could start working on this last week. I agree with Thorsten that Link tags are needed. Since multiple patches have been proposed to fix this regression, perhaps a Link to each proposed patch, and a note that the original report identified a specific commit which when reverted also fixes it. IMO, this is all part of the backstory Thorsten refers to. It looks like with this approach, a fix will not be coming real soon, and Borislav Petkov also discouraged me from testing this patch set until I receive a ping telling me it is ready for testing, which seems to confirm that this regression will not be fixed very soon. Please correct me if I am wrong about how long it will take to fix it with this approach. Also, is there any guarantee this approach is endorsed by all the maintainers who will need to sign-off, especially Linus? I say this because some of the discussion on the earlier proposed patches makes me doubt this. I am especially referring to this discussion: https://lore.kernel.org/lkml/4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info/ and also, here: https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ where Borislav Petkov argues that Linux should not be patched at all to fix this regression but instead the fix should come by patching the Xen hypervisor. So I have several questions, presuming at least the fix is going to be delayed for some time, and also presuming this approach is not yet an approach that has the blessing of the maintainers who will need to sign-off: 1. Can you estimate when the patch series will be ready for testing and suitable for a prepatch or RC release? 2. Can you estimate when the patch series will be ready to be merged into the mainline release? Is there any hope it will be fixed before the next longterm release hosted on kernel.org? 3. Since a fix is likely not coming soon, can you explain why the commit that was mentioned in the original report cannot be reverted as a temporary solution while we wait for the full fix to come later? I can say that reverting that commit (It was a commit affecting drm/i915) does fix the issue on my system with no negative side effects at all. In such a case, it seems contrary to Linus' regression rule to not revert the offending commit, even if reverting the offending commit is not going to be the final solution. IOW, I am trying to argue that an important corollary to the Linus regression rule is that we revert commits that introduce regressions, especially when there are no negative effects when reverting the offending commit. Why are we not doing that in this case? 4. Can you explain why this patch series is superior to the other proposed patches that are much more simple and have been reported to fix the regression? 5. This approach seems way too aggressive for backporting to the stable releases. Is that correct? Or, will the patches be backported to the stable releases? I was told that backports to the stable releases are needed to keep things consistent across all the supported versions when I submitted a patch to fix this regression that identified a specific five year old commit that my proposed patch would fix. Remember, this is a regression that is really bothering people now. For example, I am now in a position where I cannot install the updates of the Linux kernel that Debian pushes out to me without patching the kernel with my own private build that has one of the known fixes that have already been identified as ways to workaround this regression while we wait for the full solution that will hopefully come later. Chuck > P.S.: As the Linux kernel's regression tracker I deal with a lot of > reports and sometimes miss something important when writing mails like > this. If that's the case here, don't hesitate to tell me in a public > reply, it's in everyone's interest to set the public record straight. > > BTW, let me tell regzbot to monitor this thread: > > #regzbot ^backmonitor: > https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:35:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:35:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369683.601170 (Exim 4.92) (envelope-from ) id 1oDP2K-0004lt-HZ; Mon, 18 Jul 2022 11:35:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369683.601170; Mon, 18 Jul 2022 11:35:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDP2K-0004lm-EH; Mon, 18 Jul 2022 11:35:40 +0000 Received: by outflank-mailman (input) for mailman id 369683; Mon, 18 Jul 2022 11:35:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDP2K-0004lg-4C for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:35:40 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf04d9af-068d-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:35:38 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 018B65C0105; Mon, 18 Jul 2022 07:35:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 18 Jul 2022 07:35:38 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 07:35:37 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf04d9af-068d-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658144137; x= 1658230537; bh=0HqKLmJGSnaIm61y6IqoYDb1CsR3FlBGazWv2JPT6W4=; b=q fHyL31nPM3t0P6JuU/bMnYNz7IQq4UPZuw2Hd7Yl6ZboFAHNJgA0DPqHOKazxydL pj6aGc+f7YUjcbGHSB1LDCOiuKDFo5xfDKTqs8EZ/i0Lg7zYOFAW4FyXKfXM54km dgK+wKgnctqZEhYv6ix3GiXJp4c9Gpw6iva8fJwFL/NJCKAB1/5e2x/PRvDgtExi Vq2jUI5KsVBz2cWiqDHvoYhUATxvqE1crzUidO6znZBnaDhJaT0vn8GaD4XlLM9u dcwgo2PZqcYBplzcRlBDcILyfSMnGtYG2H3TaQOEkBxd8hURQPpGgKqYRT0kh1Ah Xz5hFf4d2MY1wKdpl0EFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658144137; x=1658230537; bh=0HqKLmJGSnaIm61y6IqoYDb1CsR3 FlBGazWv2JPT6W4=; b=GBGme8el+RDW1zONBfzcRw27UnW0TTzrMUfFnTSN6XNN ivmAq0WRRiFA5QqYxMnuIK9lCC2wwComqWr9dSxPJ73P82uaIizKhNFeMOp+sfQV a6v9qVR52wFOjNjygbYBCgn4b6D//WVaHiSoCgber5tkf06niGLEXeLUOsW5hsK7 ZvhZ4Mn0RjboCEacSExjgyCVeg8KyJHEfSRjk3b6uU3EK0HzHEr5bEeyt77PzDjf X4/wAex1Dm0TxYNhVH0TjlMNSKpOTum6r9hkMES8SEQexDQShA+oNeQJFfgFHvg+ 3Drva2Fo/LZJMhhgsMj0Y8A3lNishZygXnkrUi7IdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedggedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtroertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnheptdet vdfhkedutedvleffgeeutdektefhtefhfffhfeetgefhieegledvtddtkedtnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 13:35:34 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 7/9] IOMMU/AMD: wire common device reserved memory API Message-ID: References: <457056cbc6dcc00958b1f4e0cad35121e0cd1557.1657121519.git-series.marmarek@invisiblethingslab.com> <00c64c2e-a007-8188-469e-08e8c8cd25e1@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0J8ImBKga4SBTFMo" Content-Disposition: inline In-Reply-To: <00c64c2e-a007-8188-469e-08e8c8cd25e1@suse.com> --0J8ImBKga4SBTFMo Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 13:35:34 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 7/9] IOMMU/AMD: wire common device reserved memory API On Thu, Jul 14, 2022 at 12:22:36PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > --- a/xen/drivers/passthrough/amd/iommu_acpi.c > > +++ b/xen/drivers/passthrough/amd/iommu_acpi.c > > @@ -1078,6 +1078,20 @@ static inline bool_t is_ivmd_block(u8 type) > > type =3D=3D ACPI_IVRS_TYPE_MEMORY_IOMMU); > > } > > =20 > > +static int __init cf_check add_one_extra_ivmd(xen_pfn_t start, xen_ulo= ng_t nr, u32 id, void *ctxt) > > +{ > > + struct acpi_ivrs_memory ivmd; > > + > > + ivmd.start_address =3D start << PAGE_SHIFT; > > + ivmd.memory_length =3D nr << PAGE_SHIFT; >=20 > Aren't these at risk of truncation on 32-bit architectures? We have > suitable wrappers for such conversions, avoiding such issues. Well, this (and the vtd equivalent) is x86-only, so it's always 64-bit. Anyway, what are those wrappers? > > + ivmd.header.flags =3D ACPI_IVMD_UNITY | > > + ACPI_IVMD_READ | ACPI_IVMD_WRITE; > > + ivmd.header.length =3D sizeof(ivmd); > > + ivmd.header.device_id =3D id; > > + ivmd.header.type =3D ACPI_IVRS_TYPE_MEMORY_ONE; >=20 > Please make these the variable's initializer. >=20 > Jan --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --0J8ImBKga4SBTFMo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVRYYACgkQ24/THMrX 1yz/vgf+PWn4F5Grx2ZPVmEOqhFiQfNKTjbRDj1GOeQIjTZl+OTfdwHHFamuV6TS qv7IpAX6IJOMI3FOEtTVZhLGBDr/ThAS3pMLW9uAUZe4reyE5BApnRrQBIuBzzrl RN12+rjntZ2DPTmdlbOJ+6MDLgkHZ7Hv0Mq6JkSCdsrIdW1ZMUDpDWwwz8hnH3Ln tnZS1Si/dt51fM/W61eje1nGdlZ7mowcHUud+lJgdjo3bRSJ0O/TQ+6NN90Nu3+5 yD0k4XU42asAFvY4QSnZhuI3yAf1ylZu7SifMnAJ4wINOJRNoQd4O9tSpGMjcQ6I h87xb9mw9QvLGUwpn6HGDJdNhjhdvw== =X6eJ -----END PGP SIGNATURE----- --0J8ImBKga4SBTFMo-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:39:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:39:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369700.601180 (Exim 4.92) (envelope-from ) id 1oDP6B-0005a9-1D; Mon, 18 Jul 2022 11:39:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369700.601180; Mon, 18 Jul 2022 11:39:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDP6A-0005a2-Uh; Mon, 18 Jul 2022 11:39:38 +0000 Received: by outflank-mailman (input) for mailman id 369700; Mon, 18 Jul 2022 11:39:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDP69-0005Zw-Q8 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:39:37 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130070.outbound.protection.outlook.com [40.107.13.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4cf3f405-068e-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 13:39:36 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM6PR0402MB3528.eurprd04.prod.outlook.com (2603:10a6:209:7::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 11:39:34 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:39:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cf3f405-068e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P2Rcdv2sUyJSqoi9KLsP5BcVqPmYw3lhAwAPbaAg0EYTBkCnHdcmlAGn++OswKZ6O0Z+v2yfjT10S5ZyWR56mNHjjnrqTC2WhPWYiMAWMZql3sWvQmGlUSyYNmOfr/bWlUDAEWImoOIXEoxPUaCN4BBEmUYmClTxdHJlXyNBuLSQ4ogBJLtzM8s1vA6M7mAo0xX0s/vFrxUJvCv3lZpbjPVUpnpme77JIhrFNkjLpd8ZPItZ1nnq01YsB+TTik4kwTATkUdSLYIvr0CzFG5YHuBk8grFWPneYqAPi7syZ1Lm8iFF4lJTufm9lxiqH6TgXsMsjMtDAAdK4mCTPjjJsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SHu9F9LVCzeVwwGQ7uOZHTPSOPP/0lcAVReQrh/jTKg=; b=lyckba1Nn9yFWkQIlipWZUbGX/LEveLsbEIOfH+zdX7AgjTIj38qev7vkH65IAt4YeWT+VbD/OAkQR9qenY1fwZ0dusiHMcAHjwL4wPNsKL/4k4YHtF8r7nKVFir+xfY8mvylQTrr5T9NXqip30RH6r0+dQpd9pP41ovJgyU6w/5MEGdz/vJAdS0D657q+T6SHCbulV1D6bDsi/cfLB9F9ipe4XUYHKCci9hnPnyN+Zho9nSooxCLe2lJ76ZzTDADxa2RmyyTPkMlK1UjtcWpVNIKfa0cbxFyP/BuBlHTtHF6ge2xQwZi1u5AAJWHws6EzEI4JxTjx7PSlT+TWrqNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SHu9F9LVCzeVwwGQ7uOZHTPSOPP/0lcAVReQrh/jTKg=; b=QRZ3WSDAPLZ+aqV8oA37LuATfpv1ljxwKRiCbjs/VOZncU3kIZhAepFvA84sV8ZtoPsMk8hSi1GWGDvJr/4K5gL3uVO8ggqacIuml3MjNJs1oFtFXdRRHqlRUDiqhYMnLdNxAbwCPLS3w5p9owUhtZmcvVL/3+zkNNYWGhAm2yIDiLo+NBoiRuGgN7Eejh7oGBjnu5GVX6xo/5TEdBKKDbRLhg3OgdJsNxFw0/FY6/cmG6kDgGf+zpDHEn8Zi46m71+l0IbjO3No/4ZP8nD0FMXy6njSELKsu93XNRYFZjXMOrJuhukF7mT9vmp1Yz5Lv/t8awFpZwZ3zqTL/osEKw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com> Date: Mon, 18 Jul 2022 13:39:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Chuck Zmudzinski Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , "Kirill A. Shutemov" , Juergen Gross , xen-devel@lists.xenproject.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org, Borislav Petkov References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net> From: Jan Beulich In-Reply-To: <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3566ad0c-d80d-4cf1-bbfe-08da68b22f73 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3528:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bdDNRPWnEoUucytWPPyH5mfDdJGYkZV2okavMtXxrSmX6V4VVVWffBkc24s6mNS9afXl5413jCz1xsmh88mVbwmAihB2EIVbxYZtHqsk2Tq/i9YxSy6pB3ekh3XOEcbBEMvIIs+MH6YDPSjTfaleSyZDUc034QrYYS89un806jsgInkj85qFTcZ2RizqUtY5uJipLcrnSXSjzitMBwKHCeKyESgKDFLWSfx899D5CL+x1qBkIhqTBnK+mE+b4fR5VgcSyNC89tjC49DR6yZozmgs+v7A4zFHSpatFsaJqpHjZFRtaa0RhbrWPx0kd4xtPERs7PGY7poBNzhZ54sIaLGbhn81lZwCDBWbJ15Ws+u23ubk10/sTezEaMaMhbNpwlqjkc01ZVPlGD9qb/sTqVSIuYk/BZrfo60sLbwjQq3S49q1T2aEtmD8R3PF3OZcFd4qgCaUzfKKGcCcPFyjFL0ndjiuIDfqjW7Ljw3cS9Uli0xT//EXznr/XhIIko3vg4e8wQfWT+Pv8anyD7CoSSgsVVW4/EWq1nEXkO8OfQ+YQvkoyZpAV30nhxZgdp4HJFBfTyLnw7eiiibaDOzK+pRqITpfyiRcrXdnlfTibU9+ffWMRx5ggSKvSxYUtH06N3TPeCAhNy7nTo5vYhfQ4PC2loXdjHEjIjj/xNH4XSdxZQ09bp5m6o9p9bT04lSZCwIrzVMO3iOX7p/cW1Ll+VqPyCxRBJe3So4UwsrRiS4aGPmncyJhofX/+S+6LxEgQpgFm9GT96wllOido53waW7go8IEY0rC3I8QJAu8Lg5o5dhQIf3t25b3OE0xESy9R7VB2a4MI6DLiBaRn68sXo2JL9WmdflApfYjY7NwzxpOfG5QKWRrn8u8ZBm51t0/ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(366004)(136003)(346002)(39860400002)(6486002)(966005)(478600001)(41300700001)(6506007)(31696002)(86362001)(6916009)(316002)(31686004)(26005)(83380400001)(2616005)(186003)(53546011)(54906003)(6512007)(4326008)(66946007)(5660300002)(8936002)(7416002)(8676002)(66476007)(66556008)(36756003)(38100700002)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cnJFVTVNTHVHWTUyOCtPL2JvdkNCdGhNRHJDR25nbTNSOUdVZURkOVozM1Ji?= =?utf-8?B?NUlGNEphRkFRRFB6SG9FeHBIMW5iVmpRM20zRFNob01ONDFiSHpsY3BRRDJC?= =?utf-8?B?di9DY3Z0NVp2U0x5TUhoVWdqMHNFaWRLeWJKU2dEZmx0QXBxVks3MHlRRnJ0?= =?utf-8?B?TTJyTmVDa1NhbTFaME93a3BINjQ1aUdYMEtDcUx4TzQ0Q1E3RWRMN1FNSEk4?= =?utf-8?B?eVgrbWZiVlF5MjdqQzlWamFTRE41MWlOWDZpekhCKy9KdGltLzVXMFMxNisw?= =?utf-8?B?ZDJ3bkxQaW5lWE9RSGJaaE1wdTh1ZVR5UVQ0UEdyb2txNEdwOTlHcTc0Q0lK?= =?utf-8?B?eTVCVjZld2N6SlZqdmh6RGJNRUV1N29GcWdTQzR6VlZNUktQNjRaUmVuZklG?= =?utf-8?B?dHkzWlNEYVVQNk9jOUFEeDZYOVNOcFBSVjVqNk1MZDEyL3VoTHNRMWRuK0NK?= =?utf-8?B?WjBKNm41RlRFck5pUlJ5T05HNHR6WG5tUy81MytRaWxqbVBuNFRPMFFWY3pQ?= =?utf-8?B?Rm5YNit1RVFtbTRjSk5aRy9QRzRoSXllVEtmOW1aSGlKbFZSdGlpK29TUkR0?= =?utf-8?B?VjhBT0lLb1JJMVQzS0JxUmhyNjRpblJyVE9ZV0NPRVpXY0hiYlNQb2FSK2lW?= =?utf-8?B?a1IxV0FER0VKa0RIL3ptcGFlWDJKRHpYWHdkYmtlR3U2UVpZU2Jia1hrZVRW?= =?utf-8?B?UXFvM0hTcTVzUmgrUDhlU1NGSzJjWlgvWXltMGxRTERFS3pPZXpjVHQxWUFU?= =?utf-8?B?SHpNN0g4Y3JNL0NuQ3pIZFVQM3dKVnZ2emt3d2lLVmZvVmZ3OWFBQzZVWWU1?= =?utf-8?B?b3FFZTZ3MGhDMFg1WmgxQnlwV2gvdWx6eGtzQzBjZ3FuSDE1ZXYvQVI2V2hU?= =?utf-8?B?TzUrQTF2ZDVRdjBDM0kyQjBQU2dXaS9zTzJWaHR1Zm9TRVBhYUNIT3Z4Rmlx?= =?utf-8?B?SlJ1S09vSEF4V0xsQ2tEczB2MGJKZHVSZmtKSThwR1IxakRWTWdSTUdicVlC?= =?utf-8?B?OW8xek10bVVaNGE1ZDJ3Yk5iSWFBL1VPUEtpYWVKT25hMnpCR3lROEwyeHlw?= =?utf-8?B?cGVYWlJFb2xVZEdmcGZaeVlJcW85NGJKWXBNaTAzTEVJWHRSVXZxWGxOeHls?= =?utf-8?B?ZVVodEdmRk0yL2dDbHFTZGJSNTE5bVVqN25obllLTnBQOTZ6M2VnbmJlNVVp?= =?utf-8?B?VnEzUnRURTlnOSs4ckpzbnoyNzk5UkhZcHFQbElZNW5vcURCT2F3eFZiQk10?= =?utf-8?B?RWxJYytub2lZdmQ4RVlIMFcrY3NIZllzUmlJZ3IwZXZiZlJ4RTd4YVZZbWo3?= =?utf-8?B?K1pDL2RpRW84QU9JR0xqa3RpWnp0VEdIM2YwOTJBU085V0VKZ1Y3YjFqN0g5?= =?utf-8?B?Wk9EV2p1SUpLUnN1ZzJQVWphTDFjTDltMkZqK2FnekpNYkFDSzlUK2R6ZkVY?= =?utf-8?B?MWpDVWpoRHMvalJDUWVHYVlycmlDV3BhK0Q5bXptdlFHUTh4OHRaVXJQaXR3?= =?utf-8?B?YU9FUVd3ZFdScXhvWW9GZnlmRVM2bnptTXd2UHU3a2tOT3d3bW9FWTJqOFVv?= =?utf-8?B?Q1dva1ROQ1pPSzlNRFdFYXZVTjUxQm5KTklDMlZSOEFiL1JHaGY1RDNFSTVD?= =?utf-8?B?d3QyaGowRDJBWGpjcUxqa0ZpQUlyQy95VHdVaE5ldG5mK3VYOVRCbVpLZFlq?= =?utf-8?B?MVhENHJTWmZNcGVocG0wZGZMNDFhNnpEbFN5U2tpbmk5Tm9sbFM0QVUyYzdZ?= =?utf-8?B?dWVTelB6ZnpxTnFPSWd4eXh0TDRhbklyYkVkYTVEbWQ4YXJISXNlNkxpOGRs?= =?utf-8?B?SXpYVlE4OUFUc2l4M2ZDMGZSZmhRVHFpVTR3SmxlcFBNV1g5aFhlNytucDcv?= =?utf-8?B?ZE9pa25HNld2UFdkMGJRbDBQaHV4Q0JJM2dSUDd0N0htWGpHeVJoTWE0alB1?= =?utf-8?B?SDU4d0pLY3Q1L1hHYzNXUXZRT2tROENNbmJTWDNVWDJ2TDdEMC9QZCthZmM1?= =?utf-8?B?MjFLMFQwM0pKUDFxVVlmL1ZoZUtZTVhOYmNiRzJiK25FMmgyTzVMbm01RzJl?= =?utf-8?B?MkMwTERtR3grd2dtWi9EeDEvaWpPWUxyeXIySHBsekRPc3NwQXZYV1VRaTM2?= =?utf-8?Q?AyDM4F5P6V5WJgICtMYz3ag1s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3566ad0c-d80d-4cf1-bbfe-08da68b22f73 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:39:33.7177 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tDbxqZ0XJwBlMRvNfqi87k5mzOpTYjZsV6nqX6ZUypy+SGxxBMp1W+6wx6KBP+JJdIRCR2u8+Jo3aOmN5eCalw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3528 On 18.07.2022 13:31, Chuck Zmudzinski wrote: > On 7/18/2022 2:07 AM, Jan Beulich wrote: >> On 15.07.2022 21:53, Chuck Zmudzinski wrote: >>> Two things I see here in my efforts to get a patch to fix this regression: >>> >>> 1. Does Xen have plans to give Linux running in Dom0 write-access to the >>> PAT MSR? >> >> No, as this is not technically feasible (all physical CPUs should run >> with the same value in the MSR, or else other issues arise). >> >>> 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? >> >> Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I >> don't think there are plans on the Xen side to support the MSR >> interface (and hence to expose the CPUID bit), and iirc there are >> no plans on the Linux side to use the MTRR interface. This also >> wouldn't really make sense anymore now that it has become quite >> clear that Linux wants to have PAT working without depending on >> MTRR. > > I am not so sure about that, given what Borislav Petkov > said when commenting on your patch here: > > https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ > > Specifically, Borislav Petkov wrote on Tue, 5 Jul 2022 18:14:23 +0200: > > Actually, the current goal is to adjust Xen dom0 because: > > 1. it uses the PAT code > > 2. but then it does something special and hides the MTRRs > > which is not something real hardware does. > > So this one-off thing should be prominent, visible and not get in the > way. > > --------------end of Borislav Petkov quote----------- And then, a day later, he said "So I'm being told that it would be generally beneficial for all kinds of virtualization solutions to be able to support PAT only, without MTRRs so it would be interesting to see how ugly it would become to decouple PAT from MTRRs in Linux..." > Jan, can you explain this comment by Borislav Petkov about > Xen being a "one-off thing" that hides MTRRs and needs > to be "adjusted" so it does "not get in the way"? I'm afraid this isn't the first time that you ask people to explain what somebody else said. I don't follow why you think I could better explain what Boris said and why than he could do himself. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:44:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:44:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369707.601192 (Exim 4.92) (envelope-from ) id 1oDPB7-00073v-Ni; Mon, 18 Jul 2022 11:44:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369707.601192; Mon, 18 Jul 2022 11:44:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPB7-00073o-Ko; Mon, 18 Jul 2022 11:44:45 +0000 Received: by outflank-mailman (input) for mailman id 369707; Mon, 18 Jul 2022 11:44:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPB6-00073i-9t for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:44:44 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50078.outbound.protection.outlook.com [40.107.5.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 03571508-068f-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:44:42 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DU2PR04MB8774.eurprd04.prod.outlook.com (2603:10a6:10:2e1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 11:44:41 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 11:44:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 03571508-068f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OHh6RkuHRK78yw8ZkF5bLC164JEB11ktcMRW0fK/kahUKxzAvqE/A13GD6hAoJVVf+ipknzg7SxlylQRTap2D4GJ0WzUi1OLuDQYIV7nH9FwB0N4aciMkpA55LZ6S/aVsbddAA3TX36PMix1qVUm09AphNyefSxU1h12Si4x48jzquHjddqTe0o8/swFk4TAYs4ShIcIhSHi8LZKk7gTcwjnTswuUlFa2qEUdOhnGg9oXuEnOrSyrYW5+juzj/5F5isO5Ww71O+oDOzTki6kKexLptLR0d6ttEob2aAZXDi2bqdXCqEa1l4y7GIlbylab7lqJSfOw0tZcVZXnH/Jdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hRwopZa8W3JKHcoInQtQujPiQ1LWAhBAeND4hEXgBvw=; b=Lr8U3IghAJHLINDNKXCYD8JXbtvjO1d+DsvIfH0A81hwDg/MjuAVgKkM7VYOWVgVFTlqNDK7iOWgf6E/f+SSGW+zsrheg7r9WE1FOx9cm0GvE0WnVbgRo6BJ2lX0X/bzVJav69s9mS0biW+n/UIFnXATzD41dt7BZu2AAUmAjP7BUOqn+OiOczKhdGxNDip72qrKQqABeTu3XYch+EbyzbnziOCRKQrdL+TocdCYNKj9Zqurl51a36HiGiJGT6YlKogeHEVsWMDnn+pYia8OLWCLMBkN8YnSeApFEjbh/2rDEApfno75u7fVvXNtgB/riCe71phFwmI+5fUXLkpg4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hRwopZa8W3JKHcoInQtQujPiQ1LWAhBAeND4hEXgBvw=; b=VxGEO95dwaT6YKI9T2aadh4mbP+zcGQxuaaU0Icav2COxtggj6gpH5jDkRz+ByoQrL5u0M1qTrLa2eYuxuAgWNZMsjPPkVjt4tMcfKDdSX5wBXs7xnX+lG3T/ukY3g2M5vF3O2CUlxPlxs/BxOVB2z8jSLuCWlOLcNO4O/Zvajj4xZ+eBExEu4jvz49XSP+We6nnMAlWmEDRhV+ew2Qy/6Qe7Xt3josYWev2nPyGsx6EL2DlCYsE86INuhOGrC5HBfctLIr7qx8kyOm1jWGab7zmUrN19hhUpkl47BKJtlnYKeQD3bE20DthUKfTSiWPN+GMKkiOn2wuKFXV9f3yVA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8a5c7db7-75de-59c2-6c17-58a5276189b5@suse.com> Date: Mon, 18 Jul 2022 13:44:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 7/9] IOMMU/AMD: wire common device reserved memory API Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , xen-devel@lists.xenproject.org References: <457056cbc6dcc00958b1f4e0cad35121e0cd1557.1657121519.git-series.marmarek@invisiblethingslab.com> <00c64c2e-a007-8188-469e-08e8c8cd25e1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b79a3bc0-1bb3-4608-8d54-08da68b2e69a X-MS-TrafficTypeDiagnostic: DU2PR04MB8774:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: upVlFsjta8ss8gYWGgIaSP+zZDKMed9AnOnE0yyDDOqp/gE0i+SIoHWeX3HdrkD57LPpkzhzulkYX9OA4LL2Oz7if2uiQ4KW+FJgn6W06NAOUKsL5qEeMCHg6iulGyP2k83f1ngbyO81E7L9nrFKM/xuyoNky0rEVFhH1NurTu4HdEJBDVsE8A2BwSEVPduRkwyXW5xyBV83/PbO39ddErX7/NhqWIVrOmIXWhY6T5eVreV6vfQ71VZy1Sgm2pch/gkNuNB8pdg65IgAXo831hpD8Qu9EFSelUcRgbHKWDXqIl1pwbrhIeEd7gLcsVmPNrd8c8jY7VwHoRvXMmOjbNo+uSWlc/XVmbG9IFjNS4pqglQbS4Sc76APCYrk+C1p4jMmSnAsH1TaHoL6DeCgrFsTeoMNfrbQh6KvAN8Tk5XVuggYDRc6tLKdmTK1ZI28LtO/5r7kIreH/r+i1yh7iqIOEcPxKZ/pxEiNx+0tazAWsiTcWqxrGAZEzq4bKxGTcHsLM5gDkOQzLEpRmNwK5QViC9iJ+IvUUoHTGhJ2siQSC4eVW5xJ1r5cmJnOIDO7K0lQLDTkRPdxrQGRw0RHwlOVHC7A27A/P51zu6LAliMm+ySU217ejFoaqVzEfOKLUeMcfKGB/6Pn6Z3Sz/+ozo/RKW0FMeqHHj5vREpU6Vh0EXTvos/q7hCC/raEaW88TGY+gxAnOzpqlzp64Om6haqaRp/iBj1pLRrXya8NB/pVfCDsFtYd6JAgW5qMkd5Vs730ae4EXp8Rs+yDGK2JYZ7Ghi6CaXzyaRnMApfJ1SABvOrsGL3Q3RSK7dcYviB72yZdjfBkjotegkKfG/eEp2UGJNk4jisTDmep6hr+qKE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(396003)(136003)(366004)(346002)(41300700001)(6486002)(478600001)(186003)(6512007)(66574015)(26005)(2616005)(53546011)(66476007)(66946007)(6506007)(38100700002)(83380400001)(31686004)(2906002)(5660300002)(8936002)(316002)(36756003)(86362001)(6916009)(8676002)(66556008)(4326008)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3VUVGtVeEwrRWo1anVYZkltUUxWeEVraVlqUFBxYUtwQ2Rmd1N5eHpCYXVM?= =?utf-8?B?Z0lvNjRpRHV3NzVKSGZFMExXVU1JMWI4djI1ZjNKVFFDUDNKK2dpT2tzWkE2?= =?utf-8?B?eVVoSTFaZ1Q4Zy80UUlaT0hQK1lsaXJuRXQzQ256STBRWGNsM2VZMUhKK1Br?= =?utf-8?B?aDFmUFdlM1YzS2lGalh6QXZvNFhKdG9HdXZMR2Q3clQ5UjNMc0kxUGx6MzhW?= =?utf-8?B?aVZwVWx0bHV5V1ByNlZhdkJZQ1pXaHMxSWVtMXM3V1ZXOEs4NGpSV2o0U05z?= =?utf-8?B?Q3Y2NDR3RjYrZDQwN3lublFFbzVPcXovV3V0THhrNXZJa1d2VHhSMktKRWJx?= =?utf-8?B?M1ZxZlhSSWxvMXg5cC9VSjFHMTFRZmdueU5MTW53SUU2emtuTGFqRkI5RE1s?= =?utf-8?B?bVluZTZxTFFCditSTlgvQURSNmxqL1F5akNINzg5U0ZEVXlpY1BzUTFyQ3A2?= =?utf-8?B?NTJHZThiUkU3REN5SmR1Wm1MSGpBbUhQcW1heGtNVkl1RytVZFBGTTNINnE0?= =?utf-8?B?aC9sMzh0WDBrSGFkZm16M2F3c1BWZXd3emJSZ1h4ZEZwcitGbEhXYUNWWDJZ?= =?utf-8?B?U0hrZGd1a1BPT1FaZE1mMTZLV05xSmdhMytCTU1ZOWtmSFMxeHp1empZaFF5?= =?utf-8?B?L013Z0Yxb2QzOEVTRzlON0liTnRaYXVhalF5M0ZLdGVCWXQ3SUxmVnpqK1JL?= =?utf-8?B?dGVKL2FpY3RXVXdLbkpjczJubWJjMjFQZUxUQzNNek1VakJaR1RpamRIY0VT?= =?utf-8?B?ZmEvYmozRXV0RnZTOWFQOXA3a0N4emtiei9UWHBpd1o4QzV3RkFoQUZNRy9a?= =?utf-8?B?L05oU0JOeEZveWRPbDFQWlIxdXphd25NRStYWFpQZVo0bzBoZHF2c2t6SFVh?= =?utf-8?B?YkN2ZFZXV3lPdjJabzcyWVZYTkpPMWVEYXRvelhtQm00NXpmZjRpQlBuUVpx?= =?utf-8?B?Z1lSek9HTVYvSzFWcnQ4T2dTNmxxalVlWTU3WkxHWTRDNXhSeGJYSThlWHl1?= =?utf-8?B?ZWRSdUhvZDdTUnN1ci9iQVBzUzBod2dQMk5tclhpRW5LZXJmdHlPS25zN3c3?= =?utf-8?B?U0VKZUlFblV4dHlJVnU4UkptUXlOUXNyeUcrR25vVmM3bnU0cDA2MFB3bXpL?= =?utf-8?B?OERPTWsvbk5INE5UVTUxNld4cGR5T3FWRVJWSXhrTlc2dVVtTzFiMFBtQXBz?= =?utf-8?B?aFh6TjJEbDdGRFN5QlZTVmpGeEZYZ1Z2R2kvVms2bzE4ckJza1kxMGttRzNF?= =?utf-8?B?YzZoWm5tYkJoNUcrbHRodzNrOEI3L1VEWkNYVWlsYStPQk8yaHczZENlb3hE?= =?utf-8?B?elc3VThrQWlia0F4bDc0OEdYUDNjS05CcXpZMXNLQXp3LzJYTDBSUVhoNlRZ?= =?utf-8?B?Qmk5amU0QjJWMnhWeXpVOWNEOXFYQTZrM0d3RFdNd3VEYVQ0bWFLSVhPSHNx?= =?utf-8?B?cXl3NEJKM0h4aDJkcHhIeng2cTVDakV5U3lkTE5mV0l3aVdjSWF0c2hML0Vt?= =?utf-8?B?c0pTM1RORWZmQVRZeVdSNkhFT3NqcU45L3lvZmRMZGVMeXJuc2NZcitEdnpw?= =?utf-8?B?ME5qSlNMUmQwNXFPb3AyUkp6c3BXRjRuaWtQMWNqVjlwMkNrSXdjMGVvRGhD?= =?utf-8?B?Z2ZNOStDa3BIZFp6Uy84ckduWm5POFV6T3E4d1ZrSzl2Y0k4b2NpN0R4eEZU?= =?utf-8?B?QkZIUTBwMHJSN0NzK3lQbHVHK2pmaXllYkI3RXZDY0xsOGVUYVVwTWtDc3hj?= =?utf-8?B?UGJFZVZacXVGaFZ0NmpjYlY4cjhlTTBTMElhaGg1ejM3aEJuZlVQVlRBNEw2?= =?utf-8?B?TUhUbDU0ZU1Zd2VXdGpCd0kzbWpUOTFiOGlzdzVTV2ZObEYyclNiK1RabjZY?= =?utf-8?B?bjQ3bWJONHA1NnVLZmRtWHhsbDFHcUdLN3BUTkZzZ1hNaTRsUWkyWTFnak1w?= =?utf-8?B?SHFGaWlXTlc3dlZZS2tsdG5qNzlDdDhWN2ZsT0N3V3lqdGtKVUhTOXlvaXhK?= =?utf-8?B?bkZlVTNZclJ1NFNqMHE4WXNPTDVPQzJPWGNrZUllWXVKWXNSaUhGbTQ5TmFl?= =?utf-8?B?b1h4NUMybkR1NC9VUEhxVjdtcXNIWHlvRXg3eUNuVWliazZRSHNQN2pibWdk?= =?utf-8?Q?lPOhB4I49zXZg1OrKFB7ejxFO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b79a3bc0-1bb3-4608-8d54-08da68b2e69a X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 11:44:40.9952 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5RU0u+HTUkWSQ/Hq9cNPz+GCj0cQrdLmb8c/eExX0Zfg5OVH51osUYmxOKMlPaUxyk9E1nWy+delDXMTSxja5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8774 On 18.07.2022 13:35, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 12:22:36PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/passthrough/amd/iommu_acpi.c >>> +++ b/xen/drivers/passthrough/amd/iommu_acpi.c >>> @@ -1078,6 +1078,20 @@ static inline bool_t is_ivmd_block(u8 type) >>> type == ACPI_IVRS_TYPE_MEMORY_IOMMU); >>> } >>> >>> +static int __init cf_check add_one_extra_ivmd(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) >>> +{ >>> + struct acpi_ivrs_memory ivmd; >>> + >>> + ivmd.start_address = start << PAGE_SHIFT; >>> + ivmd.memory_length = nr << PAGE_SHIFT; >> >> Aren't these at risk of truncation on 32-bit architectures? We have >> suitable wrappers for such conversions, avoiding such issues. > > Well, this (and the vtd equivalent) is x86-only, so it's always 64-bit. Nevertheless writing things cleanly everywhere will reduce the risk of somebody cloning this code on the assumption that it's correct. > Anyway, what are those wrappers? pfn_to_paddr() Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 11:45:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 11:45:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369712.601202 (Exim 4.92) (envelope-from ) id 1oDPC6-0007dC-14; Mon, 18 Jul 2022 11:45:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369712.601202; Mon, 18 Jul 2022 11:45:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPC5-0007d5-Ui; Mon, 18 Jul 2022 11:45:45 +0000 Received: by outflank-mailman (input) for mailman id 369712; Mon, 18 Jul 2022 11:45:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPC3-0007c5-Pc for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 11:45:44 +0000 Received: from sonic307-54.consmr.mail.gq1.yahoo.com (sonic307-54.consmr.mail.gq1.yahoo.com [98.137.64.30]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2624b044-068f-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 13:45:42 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Mon, 18 Jul 2022 11:45:40 +0000 Received: by hermes--production-ne1-7864dcfd54-hwfdm (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 383384c8c23b00dfb91d48a20405cd82; Mon, 18 Jul 2022 11:45:37 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2624b044-068f-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658144740; bh=NWRgcEKrNw577wp1orU79uRjM2h9UzwL3V9kfvs9pNE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=EhGzrRlE2Yw6LdFc3Y+vidj+yJ2vCwGFx1ZHOm3AbbCcDlkuoG734dvW1txtuPbXv4DulsxiPGVoRfbEPzlQFQa5IfjOK0zn+BI1twC+Mx0EVro8HSj8WXDTV3f8bUGQgwC8khps3HWF//mpmpvAXkOd6AyG5+1HMmytla63CB6gEAXiV2Hnh86h7Q9xyq/PzEdbsRotwprDkkpl/FSSRFUq0jCwNl5Dmdecxpt2U3V1VjZtE6Pqw8J89lWJxugs5SAx3P8NR2nH/cFLiYlNaS1pYq2aAzcBD3lJ1Wkxw55o431cXiDg09+fkGH80QlcMLhM8khoyrmp69+DhTevjw== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658144740; bh=iZRE/1npaL44ct0XXAVcZyB1CdaMX8boH9OgF3My7os=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=RDIECIGAhEUsPY/cK49+TNUvAV1csZfs8R8DrpMWt/LL2N4ZZB4HQsU4yz530FfB1T/eH84Y3ms8RYdbn9nQJETKrScSo3NWriYgy44k1K2ubRQv2ZztmH7kRLhObSC9Y95FYz/tT+G4QFwJ2ewhfn4nPcpYDvQQgO+xErpP2GQb3scz1JlPxi7cItppew6BmLZgobneD4lm4mgwy8RO9abVnuw2nFRKzghW6UiZ+ysZu/PUVqJ+znfNKBAVElgP8KC41tBhfsYf1g+pHdRROV2L2WdSwedAPrdn/f5OnHcLLxCwuO71DUeu59oUgs0XbaG24uQekYOOXi3OSym/lw== X-YMail-OSG: M_JV9I8VM1mdZtbNGADi0RpaKMu5RY7DA_NHBnxKEFfMovnu_mRoNGuS8STeFaw Jy2rTJ42K_wtX1yAJ8OxMukHqdOba6hImm4eWMnDxp5ru0kEVBSe.GhdXMyE4t9BdSeFcGr1jcxc p_ry8qjrs_mHOsyZnnQZ7OxdUUP9pI_0PouzR0id81hBDfye_ZjX_hLjL3tRcO7V8zkA2hFVnIQk O0QN_NN0uV7sYU3wDmFK7QkTJM4xZt0bzDoUNpaV94tsLy.ZdiCcSpHLQR0tXAqPr9rdSFEfUMWg fG32JxLDLl4Ks.ltp9nVohpfVCGn6CSVTLbpHk8Cgx_K6kfloNjq_FIGel5om8b3upsDxLHdgDqx tPXxkMqeADDNKq3saqThomvDG8lMaZ8I2KENUCzqrfdRPvuudrHuav5vPcu57BnhpNv3pbOwH9Ys xWt79lMfAD9jqVCcJDc.KGvXyYHiyliPXor2lE2kVvwNo_KRew1VyHBzA08ZI0N59N74wwr1eqtZ J9FUDCpLf_G_yS3ZNazEyOAOW2JFImy_oCnATvMroYnQDvl0qmPkJD.zdGHWiu8FAUyzqi2qzx0J .UQPlWn.h0X5k_q.2Z4bZO.FoQswOsX9_SG.FhIMz4ytUty08gBmp0tulQeQ8BOpFstTE7CFrffo 7YwxEHcAYBxO7ZS5ZBScI86fwd1N7zGnVMPBo04WDCbiHqSIOGfmXygoebgGO1tDRV9SPMHo5kfb EOw5WqV4gMBMei2vf93IaPPC_HlWlMMpe.aYY681sNaud0QyoG.3C0E_HwY0222fQVe5R3o62Gv4 uPl1fQIUIEZlGMcYVP5kAE2WwOql1J.t3Hh.ZWzdnTv.yPjuspRvl7zuytdIbByDb6RWhMBJPTEX Ob9pCP7Tnd8Fd1Zyg4g0p3vbRy_4CsmJM0w5IywH2lAmMAVToiehagvk_LBi4B52zlwuEDhRf59n mY5TjIh2IgA4IzqZ.1WXq4ZZMEEp.XgzHxBD5zv.962APq9dKTDp9Kn5j_2YrMH6FJZHK5xDJu6D nVk0rGIsltXN.cTmJLJ2ldf9QoOh4EP7bhXS8WEJ_jzigkR8ZqxY9rb.kcNA5V0j3YCjSHyzyxmH gQ1VgUo__c2JLxy8c.PdTItoNlLGA3pGYmWLhq7KF.emml9fy2Nu5kMNgjsVNRfdb5ZfPtZw.lDw F7z1asyobNznyUOWwh.6YRt3jpehxy0WrIzckACJcxK.nwR985Tt9dfOTiCOwK6NYNiHqzxo_Bu6 4p_oKW9WsC9rbQAMz6OjqJfOZTPAToi_PDJz8QiBnih.SHbT9K23za4w1VjMkmS.CK7_nJWz29Fc RhJexfBJq0H8BcrygbgexMpN64nTh0OWrunDfrg09xuRSffCbvvX_UNKz8_7O4GEBFkb7gth72qb bm5jaK4OyVIYOBQ46TqjBI6PuI_CByrvaPaWGDsZZuuSHmL2z1dBDozA0upHG1AbQxhimZP.31c3 C9QaJHaTuBy3lgL1NJvwuZVsmWPlcvYEcRZrL156Y4S3hDqox.mIybU7Tb.wm5mmogS9RVgTZYx1 urNYyROdEta388f6930xTps_nugnxuWPXVZL7Yt4kF61LZxFgm1JlWRn0yGb5cs5rGCnZqtMcblQ 88BexPWYMLhbJWnUoNEajttm1ZmsCh9v_teksFQetuf4KWVl4IAgiIMXDv4ZxYmg.rTbF78E1vaP oXbmqfLiT0gHkBJOJ6T7npodjTWRNnK2Q8HLqRvPBry37ok_bTvAui_T1PVImE5LlQ7BhnUWDlcN 9EKgV0qJ.WajFuxiH7DTP5LRHbcJJBo9F7FZhN4QZzntSpSlB8l3EuL1HB8RzJVaXDjTRqL4nffU 7x.KINTVelGOQH6OIr5.zFNWoj7XrcQMIDa2PiMi._lE5gjvHpWDbXzOAKaTTqs7BScVmWRllLf4 zyj3Z9Xabk0o3bosUQtu9s7v6DSqCHW0.gM7GmvOKD_hD_wrfJuRPvziQo9V4AxQOw6uSKiARGZJ MyeCNiQ9nPDsA6L395nJvwfau.oMddRhYb2Sie_R5RKII9BvObQA.75Dh19uT7h_JG96N4cPHDH. mgBJSpzH8Q_Zx0nrvVmacbDLbFfgofNBFIeHeQ3I2I0HSRyQcafM_J51cMG7989_ksBTKyP1jVBw KKXp1E7Ishe_DgS9mrpdncxTJjHk3UvcIQHsTI40q.PJtFXm_76M0fJYTVDaPDyxEkxA2epkko3G JoI.ae6inUsx4MLEDZYkThqqG8epqy4GZKPqN.HN4L2H.5S8YXU1zvWGxHvrRS1l4vwNAXbBm X-Sonic-MF: Message-ID: Date: Mon, 18 Jul 2022 07:45:34 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , "Kirill A. Shutemov" , Juergen Gross , xen-devel@lists.xenproject.org, Thorsten Leemhuis , linux-kernel@vger.kernel.org, Borislav Petkov References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net> <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com> From: Chuck Zmudzinski In-Reply-To: <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2498 On 7/18/2022 7:39 AM, Jan Beulich wrote: > On 18.07.2022 13:31, Chuck Zmudzinski wrote: > > On 7/18/2022 2:07 AM, Jan Beulich wrote: > >> On 15.07.2022 21:53, Chuck Zmudzinski wrote: > >>> Two things I see here in my efforts to get a patch to fix this regression: > >>> > >>> 1. Does Xen have plans to give Linux running in Dom0 write-access to the > >>> PAT MSR? > >> > >> No, as this is not technically feasible (all physical CPUs should run > >> with the same value in the MSR, or else other issues arise). > >> > >>> 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? > >> > >> Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I > >> don't think there are plans on the Xen side to support the MSR > >> interface (and hence to expose the CPUID bit), and iirc there are > >> no plans on the Linux side to use the MTRR interface. This also > >> wouldn't really make sense anymore now that it has become quite > >> clear that Linux wants to have PAT working without depending on > >> MTRR. > > > > I am not so sure about that, given what Borislav Petkov > > said when commenting on your patch here: > > > > https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ > > > > Specifically, Borislav Petkov wrote on Tue, 5 Jul 2022 18:14:23 +0200: > > > > Actually, the current goal is to adjust Xen dom0 because: > > > > 1. it uses the PAT code > > > > 2. but then it does something special and hides the MTRRs > > > > which is not something real hardware does. > > > > So this one-off thing should be prominent, visible and not get in the > > way. > > > > --------------end of Borislav Petkov quote----------- > > And then, a day later, he said > > "So I'm being told that it would be generally beneficial for all kinds of > virtualization solutions to be able to support PAT only, without MTRRs > so it would be interesting to see how ugly it would become to decouple > PAT from MTRRs in Linux..." > > > Jan, can you explain this comment by Borislav Petkov about > > Xen being a "one-off thing" that hides MTRRs and needs > > to be "adjusted" so it does "not get in the way"? > > I'm afraid this isn't the first time that you ask people to explain > what somebody else said. I don't follow why you think I could better > explain what Boris said and why than he could do himself. That is why I also asked Boris to say something now to clarify his opinion on these matters. Let's wait and see if Boris says something to clarify his opinion. Chuck > > Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 12:07:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 12:07:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369741.601213 (Exim 4.92) (envelope-from ) id 1oDPX4-0002Ey-36; Mon, 18 Jul 2022 12:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369741.601213; Mon, 18 Jul 2022 12:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPX4-0002Er-0O; Mon, 18 Jul 2022 12:07:26 +0000 Received: by outflank-mailman (input) for mailman id 369741; Mon, 18 Jul 2022 12:07:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPX2-0002El-KZ for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 12:07:24 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d7cfe8a-0692-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 14:07:23 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 08:07:19 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5162.namprd03.prod.outlook.com (2603:10b6:5:24a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 12:07:17 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 12:07:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d7cfe8a-0692-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658146043; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=71G+fStirrYUkJ4mzyRcDJxUWxpHi1a7C+0G8jbybpg=; b=BfuyGPAIyV5zv0V04UICRUt5d5KsKcaoUKFAdRCfMtG+/m4fiG4P5ux/ IueAyoQLCBLrCDL+T1jQs4oTdZzG32zgzx+ysLygMd/dCWpT3YgUsre4Z FNvT30tKLDdRZrMacPn15KIrCboIqJc7Ri/mMuVjyZP3BN3sYHx6ehamr I=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 76025477 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A2MSlZ6gCTtyCuAC91B6zpIaNX17brhtdnwn6u?= =?us-ascii?q?qucsGbUi9Gq9fh2uw5+26WXqo9YJnHy/Jhw1uoMPFhmrcXU2MMGZ0S4wqaCU?= =?us-ascii?q?6ZbeYpXDXyySKj/mddbAKH6d1lOz2nMjEBqjBo3k4vwclWaj57F57BiDyQmz?= =?us-ascii?q?VpxU/lCn3VQ0buTWZElw7iyawxo5YFTZnw3CIpsBp8KOIVA038YH5uEYqLK6?= =?us-ascii?q?UxHJdfLjukIWiOTjwzLRQe/iTvNMJ0RP0zkKs4G3FzZwiq8MvA9PNl9k2Mc/?= =?us-ascii?q?NLta+paKIS5pKe2nNq9Dchqd6xohxXnh2rgzWEzQbjLjUEf86kRYAbHb/5bX?= =?us-ascii?q?vzWG1GwxFFfSEsaIADBe1/YU0NpyRVd9E2rTYHaGKWPAg2p+SchuGOwXNR+v?= =?us-ascii?q?fzyuNdV/rShhkTvUbfiOAk+NesarXhjov7a7PdZWwYYQwif7QzCZHZjbGK6C?= =?us-ascii?q?4D7dD2gL5me5i6ZAZ2NcDRhaO4j+bheI+EP7RsSoYNaz0q1qFC54IatEGc0i?= =?us-ascii?q?iD2UAutAWAcfoppLCiZuB1lg5Jh1cY9eN2nzc38WlLQOyVO05cf7hn5A8FHf?= =?us-ascii?q?87pAb0qkTdcKVVXm5LczZ/30klnj+NI7cmqHMtjWMlWmfK6AQwS31hQjVmTj?= =?us-ascii?q?Jc8afupcYUHQmqAdR1gWaO7e9ZUWEjw47elNHe222WnKV/TWLtl/UGMzHBU0?= =?us-ascii?q?/f0XEx1BZPy2q5epV7lvEsvVItZRZR9xK0HYPsb+ayVirAZenTnnl62hUvea?= =?us-ascii?q?gEXl+CSOQscBvjcDRK83VRGfuhgZd5/qp+Edgj1Nma8MCXDY8j30uPviLYnz?= =?us-ascii?q?VqTPl0+ApINl0g3jaCSQ7SwEbwvB0EktcN0ziNQ3mWWuXCpwWHQ9aLZUgrvV?= =?us-ascii?q?NvaQjwqZa06SmkvTpDBN0u8EhcqczNO/U6kpezKOrSDxNzILi8PmzH9uKjrq?= =?us-ascii?q?BbsfxM/PoTdzj996g0Xam/sVKROmQPteelXyrFT0MB9kt2zFJzldyxCDosiC?= =?us-ascii?q?1HtdgP7wW867EKEWK6vkzSJWgRkQo7cbj88Lb4Ht88AkmNSCJC9vCEny1Uy9?= =?us-ascii?q?BQOrW/AFv1Ma8trhfQ1H5wLIsEIEt+T2Zi8uBZ/t9dDApDOv6cuIljDUe4aT?= =?us-ascii?q?AHubQV8pJhE/vQZsC2LPfN/VhDpOmHWrqwURqLZYkKfLzEqT6nq6sI5OoiBg?= =?us-ascii?q?UAYBVeY0A8krgtC5EOBZR/FdaTtTtuyahHGAywR9vuSGNfmTXoHw08Ad38vd?= =?us-ascii?q?5EmNABAcFSmEGAKYFgOSoV9Th8Jm+0dhqm2Z4GKhAuMNxOy3HLUyR1b1bnks?= =?us-ascii?q?qIzacqOLmx83vvE1exz/39WrouiaP9631wvQoFAtwAFf3hVtI8qx7qMzQbAy?= =?us-ascii?q?z9wi7S5hx6UG/2hhF1E1GDdUTdPLoE8J9lBSG7D6Uh6Nh++t7K49WTwQiAOa?= =?us-ascii?q?0TcfIUGJrToKCDoS1jTJ+KoPL9ze5ob0OWp0FZOHokfKM37fxIdqQbttBcX3?= =?us-ascii?q?x9r8toAXg5LuDUA3asCIc8d2uCT417lVMhFaXi0JnPvhYqkJrD5KzthBWd8b?= =?us-ascii?q?7mLAFwQAQS7AO4Py0LRH6H+qgbNXv+fH+TNZq4NfJddoP9TMA+2YDr7HSuQJ?= =?us-ascii?q?GQGXmacrXWBDX+p6bYIVBvNWPBiiiY96vqYYp9vVXM7kSBPkROiJeN3DNF1q?= =?us-ascii?q?jVHYlTzE2L9W0aocsaJOKkyWT1Q+mzuYRZBTysz3+xDuuLnZK4jDUDc1pYA0?= =?us-ascii?q?9Ufkqg2kqtmYCa6P+cdaYvCjO8OwtM6ZAFG/trXCDqdDqkL8bGIZXCMTYKBk?= =?us-ascii?q?e5eqsQEr3PVxVU5e0Iwzx8l1alxXupm3FadhL9UWNDPatIL1AmA1+2zMDQE/?= =?us-ascii?q?O+Y/Epx5IP0098AeHwGKAavg3up2omZ/CrFfGr1iCM1nOwOMHaIly/0bKyez?= =?us-ascii?q?S8iP72hRy+/AnMb7QfqcqR/hoqup9Znu8vUAKQo/3FcOO+G6ojFZAwDGqsro?= =?us-ascii?q?a1o6hpirf5dsDsGmt0sBuGpPR8AhxxM0y9ll3HGUN3LqKfPFvmzRjRL7f0g2?= =?us-ascii?q?jbMsVGfoe4E77xIRM7n5+38CEWqcwx5RnnVRTFJXrAyucAwvYT+KaxRaz5dC?= =?us-ascii?q?RtDVCv+dshojfFuEUPiNEJ4Qc8f2NcQTsfplYRTvXGRpLWIyfL01BTmaiT2j?= =?us-ascii?q?q/wBuMcUUrwL6VcIvmOrnbSRMbaGS+UxXIxmd3jqqpqOR/th5wRwk/VF4aN3?= =?us-ascii?q?GFYO9HgdwRjiSpEhPgJZU4/49WQXsqGWSCJpYcJdqhDgOVx3UdwA+jOCOK/V?= =?us-ascii?q?CsKh4TQswt2pO3/gUiarvRlNANFHuKF1Z2jxUj9YJ1zi2y+zJH0rJrBCQ8sX?= =?us-ascii?q?Om6kI2lVYo1b8UgS0RAbezfxmISIRAk/feF5jXrxs1wED95mpEzM7XcU59Tp?= =?us-ascii?q?izF+APe02blUItVUvKIDhh0n/S4He3820ZFM4Xjc2dwWfPGSqNh7kMWoHd5Y?= =?us-ascii?q?itegz+VzeW0XUnVAMojTfiuY2qNu6H6u7bNjZGkV+y1fuP7YKMxkMKvgLDj2?= =?us-ascii?q?0TVonuva7ezwpyet5IbiyGWJsZGn2d/VXjaj4HO8DD35fxpwCmbjPXEkxC2Z?= =?us-ascii?q?pAFyPH5Fn4rnM5bViZAVq+3vUxaSAQywogsfYSEujLzM5YcTYe3w6uoiywqD?= =?us-ascii?q?twAwC+e8wkHJZ2NwbDZdwFWKvlJnyi4yZ7z+FEIGYPG7Uz6pVKGSHlvtG/Be?= =?us-ascii?q?mdgVU38AIeyiMjJgX4cYaZq9Q=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76025477" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RSXQyinIdFmiJBEb3vluSjQQuY+8ZhhDX3ySD+V2tpCYtxVCTL6BDNoVcXRxImniaeum6rZj4XGIsSt7RP9WbQpka9awXiH6ILHgy9LH0J7cduEHeZn9kAzStwHI0mmK7uZkljKUxeZvZvyrt9NQw8hPO31l8Th/y6L0yWzC1bTRM8ANnSCFluZ3iZduC/oFKUrcijnEAXHGE/V3zfR+rDN65RWT4YKI7+JrzO8ZvLFl13mVVmjZgr2I75nHuN53dqEGjpJhS26dEU6XsWVgcmekp5vZ1fn5GiibtZtBIz1gh64dr4lyXtlowbxQ7GhmYOlD0Gb/QmDkIabA06vIHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=71G+fStirrYUkJ4mzyRcDJxUWxpHi1a7C+0G8jbybpg=; b=n6JrQ8TJU7cVXTptCLsaTPBZP0fvCCIgefhj32r3Bq5gm1AJN71iHNcS1OKSh69uxEJ5iKM9C8SJA7eKLbAoQmssxM29Q5RcLGv3RoiPzIukT4hRD6LBwZ3ZLUvj7Nzql5rdAJQCf37pq7rYIKT9s0dxfgH1I9sYjzIWKVK3ncGnifnELnr2Jd2EWrJDl3vsHWaTifse271i2vvt6RUBpOzQhAUxymkL7tU1aOxD/f4KL+0O7/ar3jwoJmdGNOKPjDBMJenBotBmIxJ9tCTGVIiNlaN/J5RCh9ZKEzYUUtnf+ZrF3WrC4acueFP68m5ZGmtqlPJQWhqUwvR1RNfxAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=71G+fStirrYUkJ4mzyRcDJxUWxpHi1a7C+0G8jbybpg=; b=wt5UV2rjRTsOOa50oZM+JwfwbcuRhrG3PMweUVW4N+rbqzXQKXmoEBotG7euJPdPPxKDe3O6GcuqDuRxEQ3ZOf89Jfhd9tt7ojnrgJ7mRkQRrYOgOiszP4nrEXYUsleJAM6DVUaIl8Z9aUsjbxYSNmh8a9+2c6UZ3X29QlpdeRw= From: Andrew Cooper To: Jan Beulich CC: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony Perard , Luca Fancellu , Mathieu Tarral , Bertrand Marquis , Xen-devel Subject: Re: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Thread-Topic: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Thread-Index: AQHYmE6f3nf19rITF02bMhbJMzY4w62D3CgAgAAFn4CAAATogIAAJoyA Date: Mon, 18 Jul 2022 12:07:17 +0000 Message-ID: <18a3e8ec-4a64-7401-cbaa-98b00355914a@citrix.com> References: <20220715132651.1093-1-andrew.cooper3@citrix.com> <20220715132651.1093-3-andrew.cooper3@citrix.com> <465e44a0-2005-99bc-3fca-241b8c510df5@suse.com> In-Reply-To: <465e44a0-2005-99bc-3fca-241b8c510df5@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f4ce02fb-0d00-472a-5914-08da68b60f58 x-ms-traffictypediagnostic: DM6PR03MB5162:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1dkNGd8mTpB7FLd5iwrUShlX7O4y3PJBulfk+MLxGLImzhCubXUbb2FvPoiWGDXO3sTxV67NGI1vPKWfekJ2M6go+VL9a7i1MrMbAG3XVYFX5zNY0c6SzJHusqkK1WousVt9Ddos40EJpVlNrl+RFNlRrSh7AfXXSc4ilqfuIC47wGy5FTDWtxK4xHo8DY+fbj2Qx9KMKVNLFH+1Mcyj3548SAm9NUcVY4g7nbtQGsHFjCY826vPud9QcXUDPWOE9KcHi5GltTm0VU+1CRANSKB3/2HvtgQpNq7foeGzIbjGSIC8VGJQRnurS9BM2A/TXbOs8i8vIuPiOP6zdcXWWDmkn+YBbH1BsGS1r81Nyr0Ql+OL7mnrnCWJi/k+AOqA/Ou2eWjlg0E2bgU5kIhKIaAOEG4eoEyghvzqgEUrkZty4JJwxLGCWwB9BJ73JbNyPAYhpC7UzPUvn+1lvRNGQ3Sar1eVDSGzTEYy17X2nwK3yAXo5SQwK7ldANJ5Q3hm398L6D9EkhS59Ty6vPSKpBsjxs4/Z35Xz8KCcCjucGChoWaLXb6FzQGK8uqh0oNaQZ7r73lg3AJbbiUMVmuytTZxtaKzQzKy6tS8LIf+Pb7iqo7LuGS10+Nfk95TbQqJgPVPREEP80bXaTRs310wCfh1Vpez9ywMNspulbyeAKNXueWT36vDIj+JMZJytDALRQZ53o8nsWqoVyFYBKhEX51u9UTZcfkGBBFYDVXRM+U4r8+VdPCfEK6w0nryi4QSuU2BhAFtMSz9yXDGlWj4Zln+hnS6p23gVuRfGZW2ps58/UbtM+8MPSexvHR4BaAu6Z0tCQEs2Y/xRld0tlr3l6ZkIN+dKXHxnzW3F/Q44BFFjkyXvIi3SguJSNUcq2Xj699R/exS9Hea88amb4spEdqDUdLpENRHnv052kyE9F0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(6486002)(41300700001)(71200400001)(478600001)(2616005)(186003)(6512007)(53546011)(122000001)(26005)(82960400001)(6506007)(38100700002)(38070700005)(66946007)(66476007)(83380400001)(2906002)(8936002)(5660300002)(31686004)(66556008)(316002)(91956017)(36756003)(86362001)(6916009)(54906003)(76116006)(8676002)(4326008)(64756008)(66446008)(31696002)(4290200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q3BQaC9vVkE2M1NHSDFtUURpZ2lWSTd5TU5qZ3VVZzRhbEkyOE9WdzZTcDJR?= =?utf-8?B?bVk5d0lnNjJhSVhpOUUyanVObE0walZPNldpemsxc2tPS1YxNG9Fa3YwWVJN?= =?utf-8?B?ZzFMekZURnV4eGtndlN5QlFRZ1FWbHhacWp4V2RDOVpmd0V0Q1lqMDhXaFE2?= =?utf-8?B?Wk9IWlZ6Yk9Cak1aMUtLZEM4a1h4OCtkbHF5Qmx1dFJId1U4Z2dFVFYyU2tp?= =?utf-8?B?Y1BoNzkvVnlnMUVPTE1hTVlHdXd6Q1k3dXpSc2l2R2cyWjVEeGZjcWFBUk5P?= =?utf-8?B?eFdWbWR3SG5hM0lTS21zdU5CTzdKTmRFYlVaeVdxWjlzV3FoUDlMVUVCQlVm?= =?utf-8?B?MXBrRnl5RWlpZDQ5ak1LTFZRdzZaWDlOektMYnV3VnppZjdzdzNkNTNJdHdL?= =?utf-8?B?M0toQTNzUnYvVTJjcXBZN3JMT2l2MlM3Nnova2I4VElsZUdTL2hNaGVZM25F?= =?utf-8?B?azh2YnM3eHRJMmV5UWxlQzB5akNxZFFRYmpWTTFYTUpRZWYxdXNVQ2pSRlVL?= =?utf-8?B?MXZwNGUzaWxRbVZxOTAwbU8zc1QyNWZhcEJ3VFFJR0VLcXg4OFIvWXZ5MDJZ?= =?utf-8?B?djFCT05DbWFLZEFkMDN3WTVDa3VGaGF2cFpPYVdRbVpDc2s1b2tiSTRsVHpV?= =?utf-8?B?eUdZK2VaY3d0RzRiY2ZPSUxscVJTZTdSOElhQk1pcklxRUxPWHh1MGYvcmtm?= =?utf-8?B?SzJNYUxMM01XQnZ4dk9lUCtPMFh3U2d2dmN5dmp2M2h5TUhONUp1VVF2c2VI?= =?utf-8?B?TWtnT0E4NFpTN21DZUx5VzdKSnVNc24xUDJrZnJqalF1dVlmckF1a2t2TnB6?= =?utf-8?B?dWdDNzJMcW1iWTFlb0VEbUIzNDdQb2dnWGg0aGRIWDg1NEF4eXBBcHMwQTFT?= =?utf-8?B?QmZSd2dUbFJaWjNpU1NiWUtybS9UZ3JUMVMyTiswRCtqMnRVQkF3d1hHYmt2?= =?utf-8?B?Q1RIQW5ERnpxTXRucm90RXhMNmlGVXhzZC9VVi9RMlA1dzFoVEFBME1BOUNz?= =?utf-8?B?TGMyYVM2dFJZcWhQNU00MkpCRVpTU2VsWXpQdmV0ZUpDeVJET0lJUlZodFB0?= =?utf-8?B?WHEzaDlWUWZpbmpYd3lJUkVDNm5RYktMRWpRNVB1aVJZaXdMd1QxY2QwdEtL?= =?utf-8?B?VE1QbFFGN0NjbFR4S2gzVVo3K2FkYzhQZEdxMWRSMy9oUGMyYmlyalE2RHVu?= =?utf-8?B?dEhiUVRaeG5weHltbXNkS2MyYk1hQjFhRllMUWpkekRlTmVzQWdPaXFyU2dp?= =?utf-8?B?WllMcnRkcnRqUFlKZ05Wam5lTzVablk2WXNpb2VlRFk3clVQNGJOOFhMUDJF?= =?utf-8?B?V0dlVmY2N2x0bmVZRnljVFJMeEx6WVZrZHd1b3Nzem9KQjlZQmd4aHBpK1hF?= =?utf-8?B?QTZlTVQvZXVTQ3pONHBaaG5SQXpRRFYrVGcvNWkrVlorUUdpYk5IRkxISW13?= =?utf-8?B?QUNZNnRpWGlidWJNRGJWUXZNdEFNU3RXekFMYzZBQVp6NSs0SC81ZTg0Q0ha?= =?utf-8?B?Q2N6ZENrRkVlWVlSL2NCQlVjT2F1MFlkb203ZlAybWxLSldnRDFpODdxKzBv?= =?utf-8?B?T0xCWEdxbDJTVlVZa2pBcXpoRnQ5YXJ4SjRQZWF5a296RFBIdjZtOU1PbllK?= =?utf-8?B?WkRuREpNWTkrNDIyMzVSNlJjVVRCVFV0czFIc0VqRSsxd2RibFc5b2dTM1Bp?= =?utf-8?B?S1hNeURJTGtZY3BvWDNjcGNLak12UVN5aFN0OVFWZDYzTWFQYjl3R2xsQlhj?= =?utf-8?B?cnVpR2xPamt2UEJuaFlGWVB3WFJYLzdoUTQ0OG9MZXM2cUFvdHFPLzJEY0JG?= =?utf-8?B?OStDWlFtTFMrbnNKak5qT2F1MUUxV09ScHkwbEJncUZzRDhvNkdvY1BLR1Yy?= =?utf-8?B?NDl1aVlyUEZsRENLazIwRG95UnQ1dHhUUG9IS3Vsc0RCVURwclk3RVJab0sy?= =?utf-8?B?YjF3SkVPZlhIRk1kU3RIbW5MU1JkNjBZN2gydndtNEVlZGNWWVhwOUZxb1lX?= =?utf-8?B?L0cvTW82Nkxua0lSemdEeXgvMkQzMThGdUZJYWNySVpvbnBNT2VxY0NZQnl3?= =?utf-8?B?YU9hdW5IRjhYTmdESFVDYVBDZVJPckVKTTRHQ1dEMDFRYjdGODMybmJ6S3Fv?= =?utf-8?Q?nauJe9cfg/OFQAhA4XKqbFtmp?= Content-Type: text/plain; charset="utf-8" Content-ID: <87C7BBC4FCA9C7478CDBAED0720FC05F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4ce02fb-0d00-472a-5914-08da68b60f58 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 12:07:17.6662 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JPsuJw9eStosZRbfd0L/9d7tqsI+0V1onmXs2cFDKyEHIAo8p+a0aqw5lyBRgd2NCF9tipBfhEC1Uf7KbMAM/jwdz2T8sAPzrLnoeX7Yd2U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5162 T24gMTgvMDcvMjAyMiAxMDo0OSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE4LjA3LjIwMjIg MTE6MzEsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxOC8wNy8yMDIyIDEwOjExLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAxNS4wNy4yMDIyIDE1OjI2LCBBbmRyZXcgQ29vcGVyIHdy b3RlOg0KPj4+PiAtLS0gYS94ZW4vdG9vbHMvY2hlY2stZW5kYnIuc2gNCj4+Pj4gKysrIGIveGVu L3Rvb2xzL2NoZWNrLWVuZGJyLnNoDQo+Pj4+IEBAIC02MSwxOSArNjEsMzYgQEAgJHtPQkpEVU1Q fSAtaiAudGV4dCAkMSAtZCAtdyB8IGdyZXAgJwllbmRicjY0ICokJyB8IGN1dCAtZiAxIC1kICc6 JyA+ICRWQUxJRCAmDQo+Pj4+ICAjICAgIHRoZSBsb3dlciBiaXRzLCByb3VuZGluZyBpbnRlZ2Vy cyB0byB0aGUgbmVhcmVzdCA0ay4NCj4+Pj4gICMNCj4+Pj4gICMgICAgSW5zdGVhZCwgdXNlIHRo ZSBmYWN0IHRoYXQgWGVuJ3MgLnRleHQgaXMgd2l0aGluIGEgMUcgYWxpZ25lZCByZWdpb24sIGFu ZA0KPj4+PiAtIyAgICBzcGxpdCB0aGUgVk1BIGluIGhhbGYgc28gQVdLJ3MgbnVtZXJpYyBhZGRp dGlvbiBpcyBvbmx5IHdvcmtpbmcgb24gMzIgYml0DQo+Pj4+IC0jICAgIG51bWJlcnMsIHdoaWNo IGRvbid0IGxvc2UgcHJlY2lzaW9uLg0KPj4+PiArIyAgICBzcGxpdCB0aGUgVk1BIHNvIEFXSydz IG51bWVyaWMgYWRkaXRpb24gaXMgb25seSB3b3JraW5nIG9uIDwzMiBiaXQNCj4+Pj4gKyMgICAg bnVtYmVycywgd2hpY2ggZG9uJ3QgbG9zZSBwcmVjaXNpb24uICAoU2VlIHBvaW50IDUpDQo+Pj4+ ICAjDQo+Pj4+ICAjIDQpIE1BV0sgZG9lc24ndCBzdXBwb3J0IHBsYWluIGhleCBjb25zdGFudHMg KGFuIG9wdGlvbmFsIHBhcnQgb2YgdGhlIFBPU0lYDQo+Pj4+ICAjICAgIHNwZWMpLCBhbmQgR0FX SyBhbmQgTUFXSyBjYW4ndCBhZ3JlZSBvbiBob3cgdG8gd29yayB3aXRoIGhleCBjb25zdGFudHMg aW4NCj4+Pj4gICMgICAgYSBzdHJpbmcuICBVc2UgdGhlIHNoZWxsIHRvIGNvbnZlcnQgJHZtYV9s byB0byBkZWNpbWFsIGJlZm9yZSBwYXNzaW5nIHRvDQo+Pj4+ICAjICAgIEFXSy4NCj4+Pj4gICMN Cj4+Pj4gKyMgNSkgUG9pbnQgNCBpc24ndCBmdWxseSBwb3J0YWJsZS4gIFBPU0lYIG9ubHkgcmVx dWlyZXMgdGhhdCAkKCgweE4pKSBiZQ0KPj4+PiArIyAgICBldmFsdWF0ZWQgYXMgbG9uZywgd2hp Y2ggaW4gMzJiaXQgc2hlbGxzIHR1cm5zIG5lZ2F0aXZlIGlmIGJpdCAzMSBvZiB0aGUNCj4+Pj4g KyMgICAgVk1BIGlzIHNldC4gIEFXSyB0aGVuIGludGVycHJldHMgdGhpcyBuZWdhdGl2ZSBudW1i ZXIgYXMgYSBkb3VibGUgYmVmb3JlDQo+Pj4+ICsjICAgIGFkZGluZyB0aGUgb2Zmc2V0cyBmcm9t IHRoZSBiaW5hcnkgZ3JlcC4NCj4+Pj4gKyMNCj4+Pj4gKyMgICAgSW5zdGVhZCBvZiBkb2luZyBh biA4Lzggc3BsaXQgd2l0aCB2bWFfaGkvbG8sIGRvIGEgOS83IHNwbGl0Lg0KPj4+PiArIw0KPj4+ PiArIyAgICBUaGUgY29uc2VxdWVuY2Ugb2YgdGhpcyBpcyB0aGF0IGZvciBhbGwgb2Zmc2V0cywg JHZtYV9sbyArIG9mZnNldCBuZWVkcw0KPj4+PiArIyAgICB0byBiZSBsZXNzIHRoYXQgMjU2TSAo aS5lLiA3IG5pYmJsZXMpIHNvIGFzIHRvIGJlIHN1Y2Nlc3NmdWxseSByZWNvbWJpbmVkDQo+Pj4+ ICsjICAgIHdpdGggdGhlIDkgbmliYmxlcyBvZiAkdm1hX2hpLiAgVGhpcyBpcyBmaW5lOyAudGV4 dCBpcyBhdCB0aGUgc3RhcnQgb2YgYQ0KPj4+PiArIyAgICAxRyBhbGlnbmVkIHJlZ2lvbiwgYW5k IFhlbiBpcyBmYXIgZmFyIHNtYWxsZXIgdGhhbiAyNTZNLCBidXQgbGVhdmUgc2FmZXR5DQo+Pj4+ ICsjICAgIGNoZWNrIG5ldmVydGhlbGVzcy4NCj4+Pj4gKyMNCj4+Pj4gIGV2YWwgJCgke09CSkRV TVB9IC1qIC50ZXh0ICQxIC1oIHwNCj4+Pj4gLSAgICAkQVdLICckMiA9PSAiLnRleHQiIHtwcmlu dGYgInZtYV9oaT0lc1xudm1hX2xvPSVzXG4iLCBzdWJzdHIoJDQsIDEsIDgpLCBzdWJzdHIoJDQs IDksIDE2KX0nKQ0KPj4+PiArICAgICRBV0sgJyQyID09ICIudGV4dCIge3ByaW50ZiAidm1hX2hp PSVzXG52bWFfbG89JXNcbiIsIHN1YnN0cigkNCwgMSwgOSksIHN1YnN0cigkNCwgMTAsIDE2KX0n KQ0KPj4+PiAgDQo+Pj4+ICAke09CSkNPUFl9IC1qIC50ZXh0ICQxIC1PIGJpbmFyeSAkVEVYVF9C SU4NCj4+Pj4gIA0KPj4+PiArYmluX3N6PSQoc3RhdCAtYyAnJXMnICRURVhUX0JJTikNCj4+Pj4g K1sgIiRiaW5fc3oiIC1nZSAkKCgoMSA8PCAyOCkgLSAkdm1hX2xvKSkgXSAmJg0KPj4+PiArICAg IHsgZWNobyAiJE1TR19QRlggRXJyb3I6IC50ZXh0IG9mZnNldHMgY2FuIGV4Y2VlZCAyNTZNIiA+ JjI7IGV4aXQgMTsgfQ0KPj4+IC4uLiBzL2Nhbi9jYW5ub3QvID8NCj4+IFdoeT/CoCAiQ2FuIiBp cyBjb3JyZWN0IGhlcmUuwqAgSWYgdGhlIG9mZnNldHMgY2FuJ3QgZXhjZWVkIDI1Nk0sIHRoZW4N Cj4+IGV2ZXJ5dGhpbmcgaXMgZ29vZC4NCj4gSG1tLCB0aGUgd29yZGluZyB0aGVuIGluZGVlZCBp cyBhbWJpZ3VvdXMuDQoNCkkgc2VlIHlvdXIgcG9pbnQuwqAgSW4gdGhpcyBjYXNlIGl0J3MgbWVh bnQgYXMgImFyZSBhYmxlIHRvIiwgYnV0IHRoaXMgaXMNCnN0aWxsIGNsZWFyZXIgdGhhbiB1c2lu ZyAiY2FuJ3QiIGJlY2F1c2UgYXQgbGVhc3QgdGhlIHRleHQgbWF0Y2hlcyB0aGUNCmNoZWNrIHdo aWNoIHRyaWdnZXJlZCBpdC4NCg0KPiAgSSByZWFkICJjYW4iIGFzICJhcmUgYWxsb3dlZA0KPiB0 byIsIHdoZW4gd2UgbWVhbiAiYXJlbid0IGFsbG93ZWQgdG8iLiBNYXliZSAiLnRleHQgaXMgMjU2 TSBvciBtb3JlIGluDQo+IHNpemUiPyBJZiB5b3UgbWVudGlvbiAib2Zmc2V0cyIsIHRoZW4gSSB0 aGluayB0aGUgY2hlY2sgc2hvdWxkIGJlIGJhc2VkDQo+IG9uIGFjdHVhbGx5IG9ic2VydmluZyBh biBvZmZzZXQgd2hpY2ggaXMgdG9vIGxhcmdlICh3aGljaCAudGV4dCBzaXplDQo+IGFsb25lIGRv ZXNuJ3QgZ3VhcmFudGVlIHdpbGwgaGFwcGVuKS4NCg0KSXQncyBub3QganVzdCAudGV4dCBvbiBp dHMgb3duIGJlY2F1c2UgdGhlIFZNQSBvZiBvZmZzZXQgYnkgMk0sIGhlbmNlDQp0aGUgc3VidHJh Y3Rpb24gb2YgJHZtYV9sbyBpbiB0aGUgbWFpbiBjYWxjdWxhdGlvbi4NCg0KVGhlcmUncyBubyBw b2ludCBzZWFyY2hpbmcgZm9yIG9mZnNldHMuwqAgVGhlcmUgd2lsbCBiZSBvbmUgbmVhciB0aGUg ZW5kLA0Kc28gYWxsIHNlYXJjaGluZyBmb3IgYW4gb2Zmc2V0IHdvdWxkIGRvIGlzIGNvbXBsaWNh dGUgdGhlIGNyaXRpY2FsIGxvb3AuDQoNCkhvdyBhYm91dCAiLnRleHQgb2Zmc2V0cyBtdXN0IG5v dCBleGNlZWQgMjU2TSIgPw0KDQpUaGF0IHNob3VsZCBiZSB1bmFtYmlndW91cy4NCg0KfkFuZHJl dw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 12:12:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 12:12:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369747.601225 (Exim 4.92) (envelope-from ) id 1oDPcK-0003dr-NJ; Mon, 18 Jul 2022 12:12:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369747.601225; Mon, 18 Jul 2022 12:12:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPcK-0003dk-KI; Mon, 18 Jul 2022 12:12:52 +0000 Received: by outflank-mailman (input) for mailman id 369747; Mon, 18 Jul 2022 12:12:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPcI-0003de-Rw for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 12:12:51 +0000 Received: from sonic310-20.consmr.mail.gq1.yahoo.com (sonic310-20.consmr.mail.gq1.yahoo.com [98.137.69.146]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id efa3d46b-0692-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 14:12:49 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.gq1.yahoo.com with HTTP; Mon, 18 Jul 2022 12:12:46 +0000 Received: by hermes--production-ne1-7864dcfd54-5p9s9 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 78ba00f741e12bff5d9e9867188b86dc; Mon, 18 Jul 2022 12:12:45 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: efa3d46b-0692-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658146366; bh=atlZN2FUSXZXKTvDhchlBWTqI7nDGrNSzBLjMzlP6Ok=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From:Subject:Reply-To; b=QOawXelZ45CqVl1OWqXPgLoUTPoLrelvcnM9EG5ldTJ973MYeUHNUNivK4jg+edyEmF2U9+YNUwecdlVZb8AboOG/kjR1ZUc3zU21bXO8l/JySqlPB8+nL8zbFxjJOgbXwst/HJxrmvL18Xn0E+u5Q9UEvApCbMcy2odK65xdNYAVyaYVZ+gej1D5DreKOJvNRiNZQtxKC3RfFwH4J2FrK24pnYJcT61a/A58YnpRxzTt3bkT6arcTtH1q8A7ylGOZXF0gijsLe6IS8g/ZpIk81AEvExrwdySyESHALBp6EM82QGV5XY8muXL3snJmt02BJHXpl2u3nIwCkLxa825A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658146366; bh=+UuasDPfRrVExKfDj5duhoMrnEi7oPm6MX1wrmN9uIO=; h=X-Sonic-MF:Date:Subject:To:From:From:Subject; b=EVFCPysrHYL5vLJE0D6vsEGDQJkWGsSOEhOhp5T+VoImDQ2jqKsP9D3iDcB4vvUSizy5XtcOY//qLYdocAthquM7sxqMO6+mXYc1PoQkY5AWZOtNnz5hDtjEaZ7tNA8EflTD8GMjyTw3WgH8O13woFSgwnYZqKhQg2GXvfF9Ymce1jALgZwBdUmPGF0szF4pfPVdBu1q4+YVh8HsEOMooHdSForFocMYWAaMSU3Mw3yyHAikA4kfxOz4L+/U+WTWknWy61VCz1w+R2MqN52x6YkpoTqCkoLFzPzNDgGfIi7bBTt/HcjkZqoeNmPhYrXsKiO5Hj1mUH+LJRovt0FJlw== X-YMail-OSG: 1QYvBngVM1koeAkrfz803RYjbFmsXqT_d_FpYOes5XUHDyB.re2tShb2SkhmTAQ _K3hy0Kwwp2XvsWR.1OcSyctFM1f7wARVD78ZqA2FfQz0Q8FtBHO5V66SUuOs4HdMgHWlSR.0T8Z ycLxHyXP8_cmQt6q8wcOUgiSOBoW_vV8rof72p4qKnRKDWQRQDGaxYf.Q.QP7E68e.4_B4aYqn.f JrC7DGzUPp0_5UM6r2cpQoxcEcFcWos79qvxHVwUdAQDx4UqqG8qG5vzmyU.FPj4QIl5exolZzFb Ut1L6LjlBpmJ.oqgS6tUcCU7z9mfj3eefhQmCwI97zXtPnol47vq0j.6acEO8NrdNOPlDD22bZuz 4E2R_SDNKd017qnL3CGdQXhRBOpCOMe0kDptbu8ULXQl5SXDR5_76ZEvWSw_OsOrrasL2vYcmWUv Al.LJd5uL0s9yxxHx5BcL8OGyn_6_qy8m6dFKstTSC6qt0zoiLs9I96QcNVDOPFW8xjeT38a6qAk VgDIg.BH2VTgCAGV0jESfJaE1HpIs2L22YUS2udvVXP3yq6txTvjrFIL5uNZA_IwzWNCbjOpmFm4 .DY66Zh82ke6nIxsutPEjVGSwPIttFZ607iPCr.prdBbAgbA4yTD9U9h_UwmjYHL.3C.uqGIg37L zOSUY8EJ_tvEgoNHfGkNSp5tDfByKJYNXspvl3HgPul168vr2nsR0U8PVXcWq01HerJ9lsE5o.pw twlLNUAUZNLz3KhIdkm3b5yW.iXNxqUQa9lu_7xW8JRprCYGk1fsojIAZ66MUNZwJOeCBDK6DLXu abPrIekssp3_yihxLvNU4E7s7ROeVXjiv5Z7ZeI.uPAQfAvCo8iUH.EwsAnpPMyLrNlzFXtLZgGZ l2V0un1mbnEoWpUAKQ3tN6F1fSA5L6eUkjPRnfvX0l24_NSBc2kRjFkV1As3rxtiCzVdDQXFAav0 8EJAvpNBHF27uE1kJgCTc4A5pdNCNotzIULGgKn4lMx3fvdSuLSGzkfPp0m4HP1Nfk0VaR25m6Aq 5KG08aqigYzKbi7SKnFkCK3MU84S_5f3RT89N2mjQRj78KYFmAwo7S8rP4r0N2KRyH2Chx_E1_KF dsov52hDF1VgAJhK32gxhnp.mqXySNFUlNlQQ8YpDl6OybmHhOz8A8_CU6tL6NuoCWEQiB_xqpKz RHo8XOyUTf9XGAjznwAju8IINwyOffs0nHQcV88o_uVJs_1fgcfzXDNu1aVGXo0DBEiw.60r6cZH ZaeZE1P9.O.h6vaBAFZq4XGojwzXXSugPnMR4y68h3ofGYy5LoQBD0eBLrfH70Z.2wXMK0joktx1 9g65Baui19T.bYXVggiDJ2Kq38dQmTeRQMLfjBVgvbVv3x3.WQokYCeYyfZug0FKhYH3qh88lBpj ac2mpn0ZwdB6Srety67YpnscSdo.hlb.XQtIKPB9eU8d5qxXsX9vDMSZ9P2zMV4rAr_JElKo4HZT SxhLjk5yc8K07.ksNRoijfecLpaO9MU5ZTnsN4SWkwcFbFRLy8agga67vLWs2zOa4OufmhGlKdPF vTGPmN7e7ho9j_jf6FUc8aXwoHuTGUpBYP.gLfjiZ6d7tC_mlLGDd8SXNzETkOoVXs7CNxone6OA .2lP2k_1sa9eE3iB6jPJI6vtOf.zVmkSxfEFpIKWzL.JMcwimv8a75o04CRWnF93FDHYp.uc22mN FlOLpGyGlg2xtdzuuYU6HIGJGF1FM3Zf4ndSLm48Zaxi5Cnib2ZrYUtEpmOhBkVtq4oeFIG5P1pd .Oqw6sr5kZt_cy1scvBqAjcM3IDZbzhnFaFUShd6hR2sYK17wBAMgpcDc6nukTkHPi4EwzuislCn pu3O7nKt2UNxahLPE5.Wf6PC_o5Xau2k8emEygINaJD_immxf3vMO4z0oawbatArq1NhcIBu9Ayf cpy9l9lv46fXgbjtYd94Mek4Wm.dFQy_XAAVz8tYVSFEJEmXiXnxdrP2tqzRSvg6hy20w.L.Iaws BNQijkFHbF5kuphUA81hWOFRjmily5Bs6MmiP6cdEdIwXRtJNVY3lL9t89YABJu_naD2wqwEw6fG N0dOPN96H0TM__tQNdkxF4MYwv8G8RXDDW29pBZlTdeUWqzYmsGkWTJsD3DRF49PAnUNxrph3hgE THr2W7ZiTCFeQGVPrh0U.zUHbEGELJk8xu2PQZa1qMgWCaFQBmKh9fcrnHWss4AIiCINskLRkXET CqewlCMPm6E3VmSsraDZjeUip5lfWoJ1t4ykoBu6tSjCEsgOrwHsONc805QEZ2OU4Hkia.4F37J. 6HsQ1kg-- X-Sonic-MF: Message-ID: Date: Mon, 18 Jul 2022 08:12:42 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT without MTRR Content-Language: en-US To: Jan Beulich , Thorsten Leemhuis , Borislav Petkov Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , "Kirill A. Shutemov" , Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com> <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com> <5ea45b0d-32b5-1a13-de86-9988144c0dbe@leemhuis.info> <56a6ab5f-06fb-fa11-5966-cb23cb276fa6@netscape.net> <1309c3f5-86c7-e4f8-9f35-e0d430951d49@netscape.net> <764ea65f-269a-6f32-c780-cbdd7cf09120@suse.com> <8eb62e12-17cf-cce6-666a-8ebb7915f461@netscape.net> <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com> From: Chuck Zmudzinski In-Reply-To: <80b413d1-287a-61a3-656d-9ea680f00a90@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2419 On 7/18/2022 7:39 AM, Jan Beulich wrote: > On 18.07.2022 13:31, Chuck Zmudzinski wrote: > > On 7/18/2022 2:07 AM, Jan Beulich wrote: > >> On 15.07.2022 21:53, Chuck Zmudzinski wrote: > >>> Two things I see here in my efforts to get a patch to fix this regression: > >>> > >>> 1. Does Xen have plans to give Linux running in Dom0 write-access to the > >>> PAT MSR? > >> > >> No, as this is not technically feasible (all physical CPUs should run > >> with the same value in the MSR, or else other issues arise). > >> > >>> 2. Does Xen have plans to expose MTRRs to Linux running in Dom0? > >> > >> Yen does expose MTRRs to PV Dom0, but via a hypercall mechanism. I > >> don't think there are plans on the Xen side to support the MSR > >> interface (and hence to expose the CPUID bit), and iirc there are > >> no plans on the Linux side to use the MTRR interface. This also > >> wouldn't really make sense anymore now that it has become quite > >> clear that Linux wants to have PAT working without depending on > >> MTRR. > > > > I am not so sure about that, given what Borislav Petkov > > said when commenting on your patch here: > > > > https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ > > > > Specifically, Borislav Petkov wrote on Tue, 5 Jul 2022 18:14:23 +0200: > > > > Actually, the current goal is to adjust Xen dom0 because: > > > > 1. it uses the PAT code > > > > 2. but then it does something special and hides the MTRRs > > > > which is not something real hardware does. > > > > So this one-off thing should be prominent, visible and not get in the > > way. > > > > --------------end of Borislav Petkov quote----------- > > And then, a day later, he said > > "So I'm being told that it would be generally beneficial for all kinds of > virtualization solutions to be able to support PAT only, without MTRRs > so it would be interesting to see how ugly it would become to decouple > PAT from MTRRs in Linux..." What if it proves to be too ugly to decouple PAT from MTRRs? Then I doubt that "Linux wants to have PAT working without depending on MTRR." We can hope that Juergen's work to decouple PAT from MTRRs is not so ugly that it cannot be done, but that is by no means certain at this point. At the very least, this means the fix to the regression will be at least delayed considerably, and possibly this means this regression will never be fixed in the mainline kernel release. Chuck From xen-devel-bounces@lists.xenproject.org Mon Jul 18 12:20:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 12:20:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369754.601236 (Exim 4.92) (envelope-from ) id 1oDPjy-0005Dp-G7; Mon, 18 Jul 2022 12:20:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369754.601236; Mon, 18 Jul 2022 12:20:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPjy-0005Di-Cv; Mon, 18 Jul 2022 12:20:46 +0000 Received: by outflank-mailman (input) for mailman id 369754; Mon, 18 Jul 2022 12:20:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDPjv-0005C4-6D for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 12:20:45 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 09d28439-0694-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 14:20:41 +0200 (CEST) Received: from zn.tnic (p200300ea972976d7329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:76d7:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id EC8681EC04F0; Mon, 18 Jul 2022 14:20:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09d28439-0694-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658146836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=YUsHaSIKv5mhVert20B83ArzxD5bMsOqQGQm2WfFNQY=; b=Ga6lTw52ypWNCa7ANAt/KfjkmVyY188H+6CK9mutryTo0MlTHD49tBVIAgvT3rAxlb5hBH x//kdGxXjpUKs4jyHamB06xu9+kdpmUNNZGYHG5m8FEI0HMZ9vzqjGmulqnxN1BfUIp9QQ dKivWsgLjUwBv94Pm38Ha6t5kSXbj9s= Date: Mon, 18 Jul 2022 14:20:32 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, brchuckz@netscape.net, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , stable@vger.kernel.org Subject: Re: [PATCH 1/3] x86: move some code out of arch/x86/kernel/cpu/mtrr Message-ID: References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-2-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715142549.25223-2-jgross@suse.com> On Fri, Jul 15, 2022 at 04:25:47PM +0200, Juergen Gross wrote: > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 736262a76a12..e43322f8a4ef 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c I guess the move's ok but not into cpu/common.c pls. That thing is huuuge and is a dumping ground for everything. arch/x86/kernel/cpu/cacheinfo.c looks like a more viable candidate for all things cache. Rest looks trivial. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Mon Jul 18 12:48:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 12:48:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369761.601247 (Exim 4.92) (envelope-from ) id 1oDQAh-00083v-Nh; Mon, 18 Jul 2022 12:48:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369761.601247; Mon, 18 Jul 2022 12:48:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQAh-00083o-Kw; Mon, 18 Jul 2022 12:48:23 +0000 Received: by outflank-mailman (input) for mailman id 369761; Mon, 18 Jul 2022 12:48:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQAf-00083f-RD for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 12:48:22 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e602080e-0697-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 14:48:19 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4B7295C00BE; Mon, 18 Jul 2022 08:48:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 18 Jul 2022 08:48:18 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 08:48:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e602080e-0697-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658148498; x= 1658234898; bh=DBFwPKoZxjSozrATGHwXwmbzF+uzjtHJ3thc9bRxCR8=; b=a JiqYfxjKiJz0I9bh9zUTTUYUk1+GN+U3TiS/na2QDIt4XugTLo+W7hTJlMfXCp3Q nzKh0bCqTj1ozUzjTwUj0GozBgXSV2Jla9nQQQcSC8ixLC7aMUatXr9DjNgDbJKm Gref9f7gGm2SMvzjxekK0EKEXX8OjHw+LKCdGovNxv0jrCnqbOlo57pohcKV0Xrb cP7gzbAjKrOgIO831fmG1hSYxtXdLMBkzg01cZOxRX9PFYpdThsm+BQQr1w2UjTE ux7sYFvgkKYQF1YBboTwDq9Fv567eVv7sl42BeGu5V86YWY2INFrm1KyjCoBP1XE CEMJjJruY8CGnfLsggFzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658148498; x=1658234898; bh=DBFwPKoZxjSozrATGHwXwmbzF+uz jtHJ3thc9bRxCR8=; b=X8Z7X+PTdlzev2O/YTj1862oJDgBG/vjFMMLeZHq5lhs tozMRZJAcAE5knEHPcM2gu8crYUevn6qkeQ1jvnaw5YiGfOB+H5DL7TKL8sLYACa SbkG3JGf7Dwb/NpAyS6dkaUpZSxgTXjCVtj8T4/1fyL9n5FGEvRDNj23AuHsOWOP sA4nfCAyEExbF1ZeIEPyMRRdwA51KpehoaPiIhlSL2eHfdDGCK/SWNTOps100tba v/1+Wpycmy5zx3qcsM35Sb7zNxJUB2pCFbCGdzS3qkZCoFtrLy7OY8bPWym9tdvI 1nx6eeYej+HV18fhmI3kZxfQ9RWSDRCH9kmHU5R1rg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 14:48:13 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 4/9] console: support multiple serial console simultaneously Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Kjm/POFnaL4sr9zY" Content-Disposition: inline In-Reply-To: --Kjm/POFnaL4sr9zY Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 14:48:13 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 4/9] console: support multiple serial console simultaneously On Wed, Jul 13, 2022 at 11:39:07AM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > Previously only one serial console was supported at the same time. Using > > console=3Dcom1,dbgp,vga silently ignored all but last serial console (in > > this case: only dbgp and vga were active). > >=20 > > Fix this by storing not a single sercon_handle, but an array of them, up > > to MAX_SERCONS entries. The value of MAX_SERCONS (4) is arbitrary, > > inspired by the number of SERHND_IDX values. > >=20 > > Signed-off-by: Marek Marczykowski-G=C3=B3recki > > --- > > xen/drivers/char/console.c | 58 ++++++++++++++++++++++++++++++--------- > > 1 file changed, 45 insertions(+), 13 deletions(-) > >=20 > > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c > > index f9937c5134c0..44b703296487 100644 > > --- a/xen/drivers/char/console.c > > +++ b/xen/drivers/char/console.c > > @@ -113,7 +113,9 @@ static char *__read_mostly conring =3D _conring; > > static uint32_t __read_mostly conring_size =3D _CONRING_SIZE; > > static uint32_t conringc, conringp; > > =20 > > -static int __read_mostly sercon_handle =3D -1; > > +#define MAX_SERCONS 4 >=20 > Might this want to be a Kconfig setting? Is that going to be useful for anybody (who isn't modifying the code anyway, for example to add yet another console driver)? > > +static int __read_mostly sercon_handle[MAX_SERCONS]; > > +static int __read_mostly nr_sercon_handle =3D 0; >=20 > I would have wanted to ask for __ro_after_init here, but Arm still > hasn't enabled support for it. >=20 > > @@ -395,9 +397,17 @@ static unsigned int serial_rx_cons, serial_rx_prod; > > =20 > > static void (*serial_steal_fn)(const char *, size_t nr) =3D early_puts; > > =20 > > +/* Redirect any console output to *fn*, if *handle* is configured as a= console. */ > > int console_steal(int handle, void (*fn)(const char *, size_t nr)) > > { > > - if ( (handle =3D=3D -1) || (handle !=3D sercon_handle) ) > > + int i; >=20 > unsigned int please (also elsewhere). >=20 > > + if ( handle =3D=3D -1 ) > > + return 0; > > + for ( i =3D 0; i < nr_sercon_handle; i++ ) > > + if ( handle =3D=3D sercon_handle[i] ) > > + break; > > + if ( nr_sercon_handle && i =3D=3D nr_sercon_handle ) > > return 0; >=20 > No need for the left side of the &&, I think. I guess it's actively > wrong to be there. >=20 > > if ( serial_steal_fn !=3D NULL ) >=20 > I guess you then also want to make serial_steal_fn an array, and no > longer return constant 1 from the function. >=20 > > @@ -977,7 +990,8 @@ void __init console_init_preirq(void) > > continue; > > else if ( (sh =3D serial_parse_handle(p)) >=3D 0 ) > > { > > - sercon_handle =3D sh; > > + if ( nr_sercon_handle < MAX_SERCONS ) > > + sercon_handle[nr_sercon_handle++] =3D sh; >=20 > else >=20 > > @@ -1291,7 +1322,8 @@ static int suspend_steal_id; > > =20 > > int console_suspend(void) > > { > > - suspend_steal_id =3D console_steal(sercon_handle, suspend_steal_fn= ); > > + if ( nr_sercon_handle ) > > + suspend_steal_id =3D console_steal(sercon_handle[0], suspend_s= teal_fn); > > serial_suspend(); > > return 0; > > } >=20 > The commit message gives no explanation why only the first handle > would want/need dealing with here. Sure, I can add an explanation. I'm adding this comment to console_steal(): /* Redirect any console output to *fn*, if *handle* is configured as a cons= ole. */ So, calling console_steal() is about all serial consoles, not just a specific one. The use case for this "if" part is gdbstub, which wants to redirect serial output only if that serial was configured as both console and gdb. Having proper per-console stealing is doable, but IMO not worth it (it would require also avoiding duplicated output in case of multiple serial consoles, and probably few more corner cases). > One overall remark: Especially with sync_console latency is going to > be yet worse with all output being done sequentially. The help text > for "console=3D" will want to mention this, up and until this would be > parallelized. I don't think it was parallelized anywhere. All the relevant functions (__putstr especially) write to various console types sequentially. The difference is that previously only the last "serial" console was used, all the other were silently ignored. So, it was "parallel" with all _zero other_ serial consoles, but not other console types. Anyway, both help text and boot warning for sync_console already warn about it. Do you want me to include relation to number of configured console explicitly? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --Kjm/POFnaL4sr9zY Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVVo4ACgkQ24/THMrX 1yzdkwf+M9qM1IZ+SftjkcBjnIc+gJ+po49eCCo1Njcln9S6z+/t9aUHzWDS1NIo /WGStxVK3TEKz9pr5YgmjyIm6uLcnbRTwaAmCMDlrsJ2hlTuq6r7wm3MPkI1sXeF eQUinkYz2JH+lYfb3dN4ssP0RNNg4HvQ0MLBtJCWw9Nw7MmGZboSTHZIs82bh7cU t3LesRRLkYGY/CnJ8Hhx0IUZaAeJVW8nYGuJ/nFftc/GiA7lbxgAnNLkerrfl4UG NmLM55mdHg/H/p4kTjzuNEgX5QBeeJtTBmnNc3gsBrkQH/j84oJsEYkrMleV7mAw fXdSNT7mOoOKm4R/1iF7xjWGHhSiYw== =+wER -----END PGP SIGNATURE----- --Kjm/POFnaL4sr9zY-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 12:54:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 12:54:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369768.601258 (Exim 4.92) (envelope-from ) id 1oDQGr-00015x-EJ; Mon, 18 Jul 2022 12:54:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369768.601258; Mon, 18 Jul 2022 12:54:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQGr-00015q-BK; Mon, 18 Jul 2022 12:54:45 +0000 Received: by outflank-mailman (input) for mailman id 369768; Mon, 18 Jul 2022 12:54:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQGp-00015k-Uz for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 12:54:43 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ca95ca16-0698-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 14:54:42 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D4C1B5C0144; Mon, 18 Jul 2022 08:54:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 08:54:41 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 08:54:40 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca95ca16-0698-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658148881; x= 1658235281; bh=h/tbsO2KjcHtIK4HiOvFAEK0fQNBRX4FiGCbpnn/kw0=; b=B pEOUncyHQGkGqWYqIq0f2WWjWY1IiJetS6m3C4TQ9HG8csyhvSVSMn3nfBIF4JSo IpxKefD9cXHCrhNfQPDvYirJY37+fBa2wqZPQYtO+EQyLLurQ92roj7h6PYAfQJf XxFOhpvjPHAQUX0HeQMJtcNAoO41RIHERTQOn2xKNcXAPYCmUyjKwBl4taICL8Em JHUPX+Zj+2r4Pi+N9Sd9ZT1R3ryah5NYHo5nF7+TNe6hZcgmT8fqGcwlUVrMCJSV TL1MPl2lFJvLKb4JwousnIybFTXGZpmlm5nJjtI2Rdr+lzebj04gZHLw20PXjiAM aE7RSQRcmDjPtJjVzJvew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658148881; x=1658235281; bh=h/tbsO2KjcHtIK4HiOvFAEK0fQNB RX4FiGCbpnn/kw0=; b=VOUK0hl5jUaJQpn4AosK1v7N7gADKiX0UWidQWX7tmDz tqDEs99iQEmXgzyb1MMGKjheHkjKD6TA5I5esUqXZh8xXojeuklIJbSobXv+I6hr nGtDjsgltueZscUqB0ctm7yQt919Rg0XEfC3uBR4b5t6lRxRGF61T4HL+Zqzli0v R9mqq8hFFuGQWQtcId++HMt9T5HAY75vn42t/WowHWt37Lfvjds9R6mjrortS56w lMY2GQ1aM4JgFaBWzM9eXO444k8MNyQL+OrxT2jX1tHwtWoUfjEC3iVmUvtyR53Z hPsXnnZzR4Lk7DerTnekqEyfIbAqzC/5yHL7qkddbw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgheeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 14:54:37 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC Message-ID: References: <50867e92-8d35-44d6-e10f-a26f35f53221@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2WdPmEE/1HPJNkQI" Content-Disposition: inline In-Reply-To: <50867e92-8d35-44d6-e10f-a26f35f53221@suse.com> --2WdPmEE/1HPJNkQI Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 14:54:37 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC On Thu, Jul 14, 2022 at 02:06:07PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > That's possible, because the capability was designed specifically to > > allow separate driver handle it, in parallel to unmodified xhci driver > > (separate set of registers, pretending the port is "disconnected" for > > the main xhci driver etc). It works with Linux dom0, although requires > > an awful hack - re-enabling bus mastering behind dom0's backs. > > Linux driver does similar thing - see > > drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). >=20 > Isn't there a risk that intermediately data was lost? Yes, there is such risk (although minimal in practice - it happens just once during dom0 boot). You can avoid it by instructing dom0 to not use that USB controller. Having this capability is really helpful (compared with the alternative of using the whole USB controller by either Xen or Linux), as many (most) systems have only a single USB controller. > > To avoid Linux messing with the DbC, mark this MMIO area as read-only. >=20 > In principle this would want to happen quite a bit earlier in the > series. I'm okay with it being kept here as long as it is made > very obvious to and easily noticeable by committers that this series > should only be committed all in one go. >=20 > Also along with this is where I'd see the pci_hide_device() go. Earlier version of the patch set had pci_ro_device() before this patch. I can add pci_ro_device() in the initial patch, and drop it in this one. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --2WdPmEE/1HPJNkQI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVWA4ACgkQ24/THMrX 1yyiiggAh+xO28p99BDuixDOn5z+iDPsja5IhLf8vB8zEa5KAvWp5XyJPFfMjFX8 1z8EnVqmeno2EOPn8i4xDuKXR3IqQ/3FpwS3fEBZPP09mIatrKym/J/jKQu0U+RG xH4R+/zQkh5NF27itmkK2AWvMfL/JtdsTd15Hb5YtMQqFLTvhNl1xZG6w0PtcaiR i7fFrL2iFSJbBPjty8eTcGB4cgfCC9vMO6QqV2jzAlujRqDmdCPBsEo0MCJorpcI IfquuYbVlzve0UqgJYDranE7GwR6lXrfdjki9wqfp5X+lUYqTfwuWk2JeZACk3pT 4lXG1aPii8haEnsUuioq9CD7hes+eA== =+S4N -----END PGP SIGNATURE----- --2WdPmEE/1HPJNkQI-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:14:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:14:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369775.601268 (Exim 4.92) (envelope-from ) id 1oDQZN-0003jF-Ux; Mon, 18 Jul 2022 13:13:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369775.601268; Mon, 18 Jul 2022 13:13:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQZN-0003j8-S9; Mon, 18 Jul 2022 13:13:53 +0000 Received: by outflank-mailman (input) for mailman id 369775; Mon, 18 Jul 2022 13:13:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQZM-0003j1-LR for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:13:52 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75eb1311-069b-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 15:13:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75eb1311-069b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658150031; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ee8zZBRLS39bKkXaWoy0VVYK7jBHqqKvv7S7N2BBsZw=; b=EgX0jYH0Mf4V/Pn2676l1KRJgoKLKHlkEQ4DlhML+pwpYArTgopyb/8S k3NOmfgh3LWKaPzu5seeAujDkg0OZZu6ZLHRS1ao1YI9gpK7A+USCxjML 1UP64NUjE6d/GQVX10aJ1WIify0LtBLnhOgq/EgMQE3cEtI8KhsW1XGWX 4=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 78602897 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jYiueamNHcjMX6/50kZsTAfo5gzoJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOW2mCaauIZmL3eYx0OYy08UpS6JODnYVjTANprSFkESMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462i4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kpA4pJ2sxwPFtL7 OE/Lw4zbyubtbKflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oe9boKPKo3VLSlTtlepo Xvj9XXfPk4lPuGzmRi68EuxqfCayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRmkO4Ht5SN UEQ0i4vtrQpslymSMHnWB+1q2LCuQQTM/JSGeAn7ACGyoLP/h2UQGMDS1Z8hMcO7ZFsA2Zwj xnQwo2vVWcHXKCppWy16YmT/BOYPhUvKHYfQig6cwo+++uzidRm5v7QdeqPAJJZn/WsR2yvk mjb/XRk71kApZVVjvvmpDgrlxrp/8GUFVBtu207S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBN7faVUweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPuc8LbCH7MvcuMt7Z5yEWIU/ITI6NaxwpRoAWPsgZmPGvpkmCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNJmLOAGeHr5FuZd2l39W+I8mbcqkp/hR+ebBOSX9pHZsGAfmU93VG4vd/lyOr YgOaZvbo/idOcWnChTqHUcoBQhiBRAG6Vre8aS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:22xjb6tfYPNtK3y1sPr/hvZP7skDdtV00zEX/kB9WHVpmszxra 6TddAgpHvJYVcqKRQdcL+7VZVoLUmxyXcx2/h3AV7AZniFhILLFuFfBOLZqlWKcREWtNQttp uIG5IObuEYZmIasS+V2maFL+o= X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="78602897" Date: Mon, 18 Jul 2022 14:13:27 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [PATCH] xl: move freemem()'s "credit expired" loop exit Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Tue, Jul 12, 2022 at 04:08:12PM +0200, Jan Beulich wrote: > Move the "credit expired" loop exit to the middle of the loop, > immediately after "return true". This way having reached the goal on the > last iteration would be reported as success to the caller, rather than > as "timed out". > > Signed-off-by: Jan Beulich Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:15:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:15:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369780.601280 (Exim 4.92) (envelope-from ) id 1oDQay-0004IF-AD; Mon, 18 Jul 2022 13:15:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369780.601280; Mon, 18 Jul 2022 13:15:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQay-0004I8-76; Mon, 18 Jul 2022 13:15:32 +0000 Received: by outflank-mailman (input) for mailman id 369780; Mon, 18 Jul 2022 13:15:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQaw-0004Hy-P1 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:15:30 +0000 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1d05f4a-069b-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 15:15:29 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C9E185C0143; Mon, 18 Jul 2022 09:15:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 18 Jul 2022 09:15:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 09:15:27 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1d05f4a-069b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658150128; x= 1658236528; bh=qDGdge5HDpcv5FvWy7Sp5xLgHmmVwmK1YF57eXOyyKE=; b=v SweDqcbhq92p/115aL8eEWeNCtWdxJddttH+HtVI3kaOoofET+t7NrXMYsZLXSY6 qqk5rZemRG2T5slOss4XM0hPAkzGp2LRnPqohCOiIeNtem9uWu0wD2DSmXNj+xKa Jw5JQbnbvPO45JJe3FtzC1M7Xp0e//XU9xEiZuObuXoE5V4m+MBz7iv+WdGyhmFz eXKuCkZHInbbTueTVWs9i6yNyDPZbKui8kA1K+RpOJuVxvA8KDHgJLe7rQrkTb+L QCtJTIMcKnSK+Q1rzf1faDKvqmWxDMGc1TmAKxh3nufktl9z8XhZJV+QquKF9JmU agZrdPATqnSP4ZBJ5PEew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658150128; x=1658236528; bh=qDGdge5HDpcv5FvWy7Sp5xLgHmmV wmK1YF57eXOyyKE=; b=2VEM5y8wpjde0su4Lg1zz9hRj1Rszpcy1dCcTPzNYyEL ME1vy37RAOJ0tMZVKAO4Y6q10kSgRBqZ1tzIdT/ICm9Bs/W10RDQ9hZ0JBODRrRk mHkW5FIdO9zGhq4xjvO8pt6dOzMgBV3RoAcY7YvvHhy7OEYHwb/98gWqBWSOZDzo ey3GbTN+pgDKs0P3Mj0vbE2UC5Q/ArsewwRBU6koWtlMF+bEhIa5Q4yQuYvmapUx +lP5pXsuTYtxeu26kyYG+pqaR/0N7Pj/rh1VtUe211uFz2RaAeobwAQeqeC9bCrv C/1HlSP96KgVOQ5LUQSRpO9d0a9BXkVhdLsuqqfQKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedgiedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepgfdu leetfeevhfefheeiteeliefhjefhleduveetteekveettddvgeeuteefjedunecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghk sehinhhvihhsihgslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Mon, 18 Jul 2022 15:15:24 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Message-ID: References: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h6HzafAOzFEH4+k5" Content-Disposition: inline In-Reply-To: --h6HzafAOzFEH4+k5 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Mon, 18 Jul 2022 15:15:24 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device On Thu, Jul 14, 2022 at 01:51:06PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > The important part is to include those buffers in IOMMU page table > > relevant for the USB controller. Otherwise, DbC will stop working as > > soon as IOMMU is enabled, regardless of to which domain device assigned > > (be it xen or dom0). > > If the device is passed through to dom0 or other domain (see later > > patches), that domain will effectively have access to those buffers too. > > It does give such domain yet another way to DoS the system (as is the > > case when having PCI device assigned already), but also possibly steal > > the console ring content. Thus, such domain should be a trusted one. > > In any case, prevent anything else being placed on those pages by adding > > artificial padding. >=20 > I don't think this device should be allowed to be assigned to any > DomU. Just like the EHCI driver, at some point in the series you > will want to call pci_hide_device() (you may already do, and I may > merely have missed it). There is the major difference compared to the EHCI driver: the XHCI hardware interface was designed for debug capability to be driven by separate driver (see description of patch 9). The device reset is the only action that needs some coordination and this patch series follows what Linux does (re-enable DbC part, when it detects the XHCI reset). Having this capability is especially important when one has only a single USB controller (many, if not most recent Intel platforms) and has some important devices on USB (for example system disk, or the only ethernet controller - I have both of those cases in my test lab...). Anyway, this patch is necessary even if no domain would use the device. As Andrew explained in response to the cover letter of the RFC series, Xen doesn't have IOMMU context for devices used by Xen exclusively. So, with the current model, it would be pci_ro_device() + dom0's IOMMU context. > > Using this API for DbC pages requires raising MAX_USER_RMRR_PAGES. >=20 > I disagree here: This is merely an effect of you re-using the pre- > existing functionality there with too little customization. I think > the respective check shouldn't be applied for internal uses. Ok, I'll move the check. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --h6HzafAOzFEH4+k5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLVXOwACgkQ24/THMrX 1yz09gf/X58LpRLr29WTiBrEt+tJhQ3axtnrZ+r+azNLtGaRcOj0FeuFOluuSgSo jCdo/e5dgBtQE2iE2ZCAea0SDQEYXGVc78JqixycnClHX9ApvV20hg5HOADTCDxQ zEEF+bEkuy9vfdPqKdtcLO2TKQWBzlCxR5uE4cn6XWQt4uYgO2Mc5gx0VYYXEY2Z w5P61JxIrUqyIndkRGQoqO7HpoR8Lvmt8e89JaWb2xF5w3xnposzC8kk1hyrwVmx ddRi29bEqT0VMzsPVrgYm7un8oAfkDn63e0IZKwLy52Y3mxBU10yicmq8cwWAd0H q0FsKMpTYHYkLbwrD3DaRno+VSkCbA== =0C9S -----END PGP SIGNATURE----- --h6HzafAOzFEH4+k5-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:34:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:34:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369789.601291 (Exim 4.92) (envelope-from ) id 1oDQtO-00071H-V3; Mon, 18 Jul 2022 13:34:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369789.601291; Mon, 18 Jul 2022 13:34:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQtO-00071A-SN; Mon, 18 Jul 2022 13:34:34 +0000 Received: by outflank-mailman (input) for mailman id 369789; Mon, 18 Jul 2022 13:34:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQtN-000714-JH for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:34:33 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a0b7c99-069e-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:34:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a0b7c99-069e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658151272; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Id3O7hwS0P4KWg2ZgtR1vm+6s0Z3YjEYBjQ34jtLqKw=; b=A2TkDqiDMVH8r2Hxt5FLgNN+WmpIymDuDfqVVXQ20lVyCMU7XYpOpgi0 DfITTsfrcHOXQYtzceF9w6xyBiAIIiEVdkrdxYAcd+vYh4JPGvyxZR0o4 s7CJwgmZCebIZBBQaTehqxTNsqWBIrvzvcqO90Blu+qm7PeRULlyKxeHL 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75335267 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:+11ChKhTrn7tDQzLNm/lVJqeX161cRAKZh0ujC45NGQN5FlHY01je htvXW6Ab6veZWTxKd8laYnn/U4Fu5PQy94yGwJlq3wzQX8b9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur6GtB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eBqtFvfx0I3p1q OEyDXMjV0mAlruPz+fuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZCybYGOJ4bUGq25mG6Go j379FrrOi0wC8Wy7Wqa8COjrbf2yHaTtIU6S+Tjq68CbEeo7ncIFBQcWF+/oP+4ok2zQdRSL woT4CVGhbc23FymSJ/6RRLQiHyZuh8RXfJAHut87xuCooLW6QuEAmkPThZadccr8sQxQFQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PG6/tt11EiWCI8+Tujl1bUZBA0c3 RixinV5nbYxlvVWyo+evn7+2jG9/6HGG1tdChrsYo610u9oTNf7OtP5sQmKsawowJWxFQfY4 iVd8ySKxKVXVMzWynTQKAkYNOvxj8tpJgEwlrKG83MJ0z22s0CucolLiN2VDBc4a51UEdMFj aK6hO+w2HOwFCHzBUOPS9jtY/nGNIC5fTgfatjab8BVfr96fxKd8SdlaCa4hj6wwBB8y/BgY c7KLa5A6Er27ow+llKLqxo1i+d3lkjSO0uJLXwE8/hX+eXHPyPEIVv0GFCPcvo4/Mu5nekhy P4GbpPi40gOD4XDjtz/q9F7waYicSdmXvgbaqV/Koa+H+aRMDh/UqSPn+J/K90NcmY8vr6gw 0xRk3RwkDLX7UAr4y3RApy/QNsDhapCkE8= IronPort-HdrOrdr: A9a23:7v8AKqosmq21GIgYQo3FbQkaV5oreYIsimQD101hICG8cqSj+f xGuM5rsSMc6QxhPU3I9ursBEDtex/hHNtOkO4s1NSZLWvbUQmTTL2KhLGKq1aLJ8S9zJ8/6U 4JSdkZNDSaNzlHZKjBjzWFLw== X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="75335267" Date: Mon, 18 Jul 2022 14:34:10 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH v2] EFI: strip xen.efi when putting it on the EFI partition Message-ID: References: <0a2da2ea-bc8e-05be-2c4a-5f9b0841f0d3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0a2da2ea-bc8e-05be-2c4a-5f9b0841f0d3@suse.com> On Mon, Jul 11, 2022 at 06:05:37PM +0200, Jan Beulich wrote: > With debug info retained, xen.efi can be quite large. Unlike for xen.gz > there's no intermediate step (mkelf32 there) involved which would strip > debug info kind of as a side effect. While the installing of xen.efi on > the EFI partition is an optional step (intended to be a courtesy to the > developer), adjust it also for the purpose of documenting what distros > would be expected to do during boot loader configuration (which is what > would normally put xen.efi into the EFI partition). > > Model the control over stripping after Linux'es module installation, > except that the stripped executable is constructed in the build area > instead of in the destination location. This is to conserve on space > used there - EFI partitions tend to be only a few hundred Mb in size. > > Signed-off-by: Jan Beulich > Tested-by: Henry Wang > Tested-by: Wei Chen # arm Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369794.601301 (Exim 4.92) (envelope-from ) id 1oDQvr-0007jY-CS; Mon, 18 Jul 2022 13:37:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369794.601301; Mon, 18 Jul 2022 13:37:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQvr-0007jR-96; Mon, 18 Jul 2022 13:37:07 +0000 Received: by outflank-mailman (input) for mailman id 369794; Mon, 18 Jul 2022 13:37:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQvq-0007jJ-0V for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:37:06 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4bdbae1-069e-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 15:37:04 +0200 (CEST) Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IDZkin014113; Mon, 18 Jul 2022 13:36:38 GMT Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbn7a394c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Jul 2022 13:36:37 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26IBXQvi027415; Mon, 18 Jul 2022 13:36:36 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3hc1ma8s6n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Jul 2022 13:36:36 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BYAPR10MB2712.namprd10.prod.outlook.com (2603:10b6:a02:b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13; Mon, 18 Jul 2022 13:36:33 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 13:36:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4bdbae1-069e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=h3hc/7NY/DrEOQX5zwjF5UBKGhznt9ZhD2uleomkU/Q=; b=RthPlsgVOcm33mlQNazOot5Kgu1ahPp3vYsHTOuILAa1siKQUYhK2pyniVbN0m8gEOfD mbMyPMncNKnbtR6bSN7TED3prSVi3wCpTPDA1P1mM6CjHkJftptjHfIZKlzUltigd9mu 45PkmA29EvcnD/lWXPkNXkU+oT7TvR20RcDVLZ2OtdBq9NCREl10wi1pHNqFsXVEr7eQ RqgZt40RamyspvQmW4MJLqnwIAqdlTSBWz3jdqZ+AdsdbAzPFvi2TQYKjVIccX+sBgUx zFIxJzgN+xS2hMQNTJYcuTFxIiOzsK7/RbvzeDlCkpUsrPVGtxc829GuH+QOO2lNFZCg zQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WAW3qDYDmhoNYj4DjMY/6yEIkP8Lw47XR6+/45eTUWGvWLt+u12uY4UFFf8Ss1Kida+NIWjDxJoaeAIpRucNKiAz8EhpFPWqZ39Mm52PXG/+Qz4eeXz2MbMdXmq+uLvbigE2e0hG/Duod4ILkdsXkP6Xt+rO8L2Qkwg908BV5aunLpGU4pJb5CR5WyfikKNYa01ZmZrEU86CbB4Szk3ED0UiPj1AZuYUsdEebLeRq5sG/I29KUrWJs8MVrepxvpm8p3t89U5aUyIS05kuJKHLODsB/KnJ+6uXLt1tVoEyeKsaqzuAupkKloEW6a7bqblA5A0pGnbBF+GqsfGN08szQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h3hc/7NY/DrEOQX5zwjF5UBKGhznt9ZhD2uleomkU/Q=; b=k0KWLSQ2MpNwT8nrOAULnTBQN6Nohozetk2x8nfsc/++tC5p1Rqz5jctlfNzHEF1FW3bNC5ooeuXI+/ndRdXDZ6VAwYZVzxb1jZ8pmQ3N/W1Gfyl8elUA5ZJlJBbJSuNU+Ukvc0+jHDtjbLdq6YTfo3m7jt2wVhtwc8TEbEbaNo/DQYRSHDCJkMllnjdvyxoVZSv5jc/Cf8fsTXEygdx7lD8D2ytWhTvHAk3li1sLuaT8yuh0mn3iFkvaMfGez2mIPFsuICCHJHclOE+50kbTFYpT+aqkstUD9cfhoeEZt0He98ueohJxLA7anoWeGpqQcr2hfHMx5B59bQOL80Qgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h3hc/7NY/DrEOQX5zwjF5UBKGhznt9ZhD2uleomkU/Q=; b=TCEsuc0WITOrDUCTARBxngn+Rg4Aq9VrbajVSg+EHFGb0QQ5/YVTYfSi7lnSkcpC3LZ0UF2AP1opk2BlAGn8EiKh5jlUnhwbBnMu5jWnFC/LWjRtgx8KURG4yddYrSfIIVvyrmjgM4A5xTERYJfdnci3aXC/mZqpe3vDBWhgbxU= Message-ID: <7e075c90-5adb-856a-36fb-73a8d424cd0b@oracle.com> Date: Mon, 18 Jul 2022 09:36:26 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports Content-Language: en-US To: Juergen Gross , Nicolai Stange , Greg KH Cc: Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, jpoimboe@redhat.com, Ben Hutchings References: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com> <875yjxrp66.fsf@linux.fritz.box> <6eea38ab-17d2-7bdc-1277-9964a3828a9e@suse.com> From: Boris Ostrovsky In-Reply-To: <6eea38ab-17d2-7bdc-1277-9964a3828a9e@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: BY3PR05CA0032.namprd05.prod.outlook.com (2603:10b6:a03:39b::7) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 956a61a8-131d-4a9e-29b5-08da68c28798 X-MS-TrafficTypeDiagnostic: BYAPR10MB2712:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SHvj6O7548uKtIk0ulA0N2QJlcFglZwKRqKYtHJACknQLw9ah8jra3wt8r4YGesAPIfnUmYSVey97XMTUGL4R9wXo3yH36HAYRUnmkQAQt78j2mQn0NOoXGgf+Xj7ma+QNGpNpBhuW7KaH94xMMGPYsKRBaRpa9uWPHmLZnDV3FktD6p9muG94J1xWsKlgLDx0jlEueIlm0BVGVpzxnPcriaUPi7s8N/BrKRIehz2lrtUrOEeOnIpsqSA58a1EHMIfQvbhYyyE5GxU8RJakYk2aDrdT5aeUSYkZDTDFxpfMqp9kUtGNf+broONUCju2gZ5ULpx8SW637rT5Rt9TSLx6VNChdVu66oGgakH4LEf6u66XXAdQ4kdip55XM2CT2gBe7vhKDv0TXh6h6k/S11uar7gQDkDkSGkQJwEaH6M0HzU0NtyrpDHFrpVLVB4sCj6iD/kGyytVRJtQzZO3a5PKelihv4lvFlc/9feBnuG1SUvcVFt78nd3iA8xLgEz1RIX+IMR3pPExbNoU4iQyXpSVj4HB/c0jvrLr4Z4Yyk50B/iBThy8WN+f9cAq+L4b8/lfqMQIcIyyfmjp18uupbBhP8bAN6H9XN6rVePQ7eyYegGvjrE2J8EeSJjzj91AfjB4dJcRa/TY6IZRkHQkW5U+oFe3FhEzk9Tk3E/YlM9JnkpP/rnqlPEY0xtqyNxRq25uYn2Xn45eo4eHhVZl9t6O0x3KYif+dppE44frcmfO8MkJd7S+ro0jkDAo2+yjcCcmfGwzpHkQk+G82VeFH5EBaluIwIHG5M9MuStFmzj08zQhmRN2/M7svnLHBDMItjyRfD2sypHF45diS1wgI1wNgL2WX6uG6gKamC55Ffw= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(396003)(39860400002)(366004)(376002)(38100700002)(36756003)(44832011)(110136005)(31686004)(2906002)(4744005)(8936002)(5660300002)(6666004)(26005)(8676002)(316002)(2616005)(54906003)(4326008)(66556008)(66946007)(66476007)(6512007)(478600001)(53546011)(31696002)(41300700001)(6506007)(7416002)(6486002)(86362001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmxiY2s1Z1dXQXl1TlpjVjR0MVltc3A0TVRNRnlsSDFxdzdLcGhEZHp1cnZX?= =?utf-8?B?UEpOUUFiWnZEU0o2d0VVWG1PeklVeEZkd1NqR083SWR1bEZFMTV0RHY0Z3ZG?= =?utf-8?B?OVpndFBXcCtJK3pWUTBSbHVDbDBybnREQXRPL1l2WnZPekJHQVo1dW5TbzVs?= =?utf-8?B?eFJvSDV6NW4zNHpmWGlialdvSUNoUTk3VFM4Sy93WFNWN2lLTWdLcWJMZVpp?= =?utf-8?B?RXMwNFl0a2cyVDNVNGRzdS9ibXZMUXE0akpmZWkzd1U5Wlk3ZnpiZTQraU5y?= =?utf-8?B?RUliY25tZ2syUWkwK0E4WGI5TDk0QndnQjFKcHREckhPMnJQSmlxUmgxMWEw?= =?utf-8?B?cmRNMndJcWRzUityelZnQmhhblFtNE5kNEc5Wk5PRnhHMitFTXEwaE8vOFFp?= =?utf-8?B?cXJZdGs5amN6NFhqZGhsWXFZbnc0c0RPS2ZkUUZHNEpiNkd5TUZCckdtU2dU?= =?utf-8?B?V2VDcFZpM1habjRKMkl3QWR0OTN6OWVHdXd2YlFLQ2pqaWZtNGRScmJnNDly?= =?utf-8?B?OWdmeHlFanptMHBTS3g0cWFXQlN5TTJRNDY4ZEV5UEVBZFRObFJ3TjdHL2Ns?= =?utf-8?B?OEdxOTZpbFJ1clk1OTFMSjg4ZU11REVSM1JvWCtvck11MWdNT1VJbDBja2FS?= =?utf-8?B?RHhDSytXRGV0bFo5UGZPZ0RnM2E2SHhZbGx5V21HSTNGMEJUbE9zMHFkaC95?= =?utf-8?B?RytYRVpDdmR3Nkd2WkNHTUE1S2NtRFhRQnZZdHNQRkVrdVVtOXRKYit4VGZM?= =?utf-8?B?UWZuMlI1S0JmWlR0YU5CVWFmdDgwcVEvVVBGdHp2OEVoT3hldlhSbGhHcWFM?= =?utf-8?B?NVg2czhQSkplRERJeHpBRm8zYVprTnpoWllwTkh1WGhGcG52czlhbkhqbC9l?= =?utf-8?B?OUxWeERyUFVFUE1yclg1Tzk4NmgyS1VJaVlCUExCQzlnNEwwaHprZFdSMks1?= =?utf-8?B?QVI0L052YmpIWWZJNVJkeDhFUTkrWFpMakNvYU5zNTJ3U0VzVXhtTExUaVB5?= =?utf-8?B?UUYyb3U3RmlzZDVUZGJuU3l4VWU0NkJINURScXJqYy9TcmlTY3Y3NU1KVEdw?= =?utf-8?B?RFk0UnF2SlFWeXJ5L0hEVWsxU3docjhuWm9XZEU4eFpnV1VwWGdtK1A2VXIr?= =?utf-8?B?ZktlRkpKeDZBS0YzaUdHdzZJdWVPZmlCYldBa3gxaVNPUXpIREJocnVka3dx?= =?utf-8?B?cG9xOWVmVStFemIwS3JpRlRrRWhYQnliUUh6L3BMOUFLOVlKcWpmZEtIbzVY?= =?utf-8?B?ZFhWUWxMYVptU1loWHJOdzNydy9HNzBXM0Z3TUtFZTByd2kwbU1md29NRlF6?= =?utf-8?B?aUltSG9oeXlLTGJHQWI1dWxmUDBXSWY5b0VmY25kOVFtdUduNVVkOEpZbzNK?= =?utf-8?B?SFFHcEVCVGdYRXZrck5mcWs3cTg4emh0aVU5RkxWVk1EZzZlaUJTZWNmQ0Vm?= =?utf-8?B?akdSSkN4WkxTR2dTZEY1TEtrY2UrVytVbkJpS01HMmhIZllNWExOTUhYcXFn?= =?utf-8?B?cHRqQTRVa0tFVGdFVVBkaS9pOUgvVmtpcTZmd3hDRTNGUWV2dDNuNzBhUnhj?= =?utf-8?B?eGk4TW93T014cDk5aDU3dXUwZ0VxK281aW1RZjZyS1pwUTYrb2hnbWNuS0kw?= =?utf-8?B?ai9ndTkzcHdGT1BsSlVXK25LMGM2VDMzdlpmalYwQ1I4d3ZiN0lRNmRjV21a?= =?utf-8?B?MFN2Uzd1cUozRHE4d0tOclBsallJbFpZazFROXY2b1M5Y0kxaExXbFROb2Ni?= =?utf-8?B?WkN5WnpmQ1E5RTZjTGNZNnFIdWo1S2ovQjd2eC8vdnFLTWRXdEFqUElqMVNw?= =?utf-8?B?Z2NlbVJLbDNpd3ZlNkhWTFYrSkY3VXYySWRNUDRXZGMrck9NUk5UTXBVbEFP?= =?utf-8?B?NS91cll1VTV1RW5CTUlwWjMxb2lmWXZsSVM3ZkdLRmIxV01YVGRGa004WENL?= =?utf-8?B?ZndaSjhjZ1JjQW9tNTZDR3N4TDN2ZXRzbm5MYnpNVHRORUxZV1g5MXRPRjNW?= =?utf-8?B?UFhVcmNYalpyMWE0VXNPU2c4K2N6Rk85OHFoUlFzcm9tb2oxQ0VSRHVxVVhl?= =?utf-8?B?Q0h6NDRKSWMxSjd4K3Q4NEtkU0ZJVDZHNXl6Y3lRVXFSdU43bGo3Qk9YMitw?= =?utf-8?B?NzRRdkhZc2lDbG1JeGU4TUVRT0VaUkQ1YmtEMGQwV0pvUVh5OWpWeHBlY212?= =?utf-8?B?aVE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 956a61a8-131d-4a9e-29b5-08da68c28798 X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 13:36:33.5763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lK1AIdeIt6/RrX1Le4u1OKvHjz6bemHp05CeGLE9xU9mkPEjYSk5KDPx+X8Qu53WGyTWBCuwTZeUuxji5aZTIanhIgKsmCVqAyiSRkgE9/g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2712 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_12,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 bulkscore=0 phishscore=0 suspectscore=0 mlxlogscore=990 adultscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180058 X-Proofpoint-ORIG-GUID: b5XY6G6y847g1fD1OvOY8nCptARhD_t4 X-Proofpoint-GUID: b5XY6G6y847g1fD1OvOY8nCptARhD_t4 On 7/17/22 1:20 AM, Juergen Gross wrote: > > What about filling the complete hypercall page just with "int 3" or "ud2"? > > Any try to do a hypercall before the hypercall page has been initialized > is a bug anyway. What good can come from calling a function which will > return a basically random value instead of doing a privileged operation? > This is all about objtool, that's why 'ret' was added there originally by f4b4bc10b0b8 ("x86/xen: Support objtool vmlinux.o validation in xen-head.S"). Before that it was all 'nop' which is similar to what you are suggesting ('int3' or 'ud2' would of course be better) -boris From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:40:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:40:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369801.601312 (Exim 4.92) (envelope-from ) id 1oDQz4-0000i9-Sn; Mon, 18 Jul 2022 13:40:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369801.601312; Mon, 18 Jul 2022 13:40:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQz4-0000i2-Pd; Mon, 18 Jul 2022 13:40:26 +0000 Received: by outflank-mailman (input) for mailman id 369801; Mon, 18 Jul 2022 13:40:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDQz3-0000hp-DR for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:40:25 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30043.outbound.protection.outlook.com [40.107.3.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c00bcdb-069f-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:40:22 +0200 (CEST) Received: from AS8PR04CA0047.eurprd04.prod.outlook.com (2603:10a6:20b:312::22) by AM6PR08MB3622.eurprd08.prod.outlook.com (2603:10a6:20b:4c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 13:40:20 +0000 Received: from VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:312:cafe::79) by AS8PR04CA0047.outlook.office365.com (2603:10a6:20b:312::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Mon, 18 Jul 2022 13:40:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT049.mail.protection.outlook.com (10.152.19.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Mon, 18 Jul 2022 13:40:19 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 18 Jul 2022 13:40:19 +0000 Received: from ad529d77fbe9.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7E0B5B72-B17B-4C9A-B516-106F82FA60F1.1; Mon, 18 Jul 2022 13:40:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ad529d77fbe9.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 18 Jul 2022 13:40:13 +0000 Received: from DB8PR08MB5452.eurprd08.prod.outlook.com (2603:10a6:10:111::10) by PAXPR08MB6656.eurprd08.prod.outlook.com (2603:10a6:102:135::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 13:40:11 +0000 Received: from DB8PR08MB5452.eurprd08.prod.outlook.com ([fe80::4f1:335d:1b5f:feed]) by DB8PR08MB5452.eurprd08.prod.outlook.com ([fe80::4f1:335d:1b5f:feed%7]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 13:40:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c00bcdb-069f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=F1mBLisaIzBcaR7+8sZc2Hw68ctVPKDj/tcThv5OPn/2Ox7nTUs6R4Qd/Vqe9J0k6DbNeRh0NM6lZUrRnpZBo4QEhpOia4QAle4Ydbg8d8zk5Qqflc/RXW9E0+DIVIE5wjyjmRv/2I6PjokzMOwMNQ/9JfQg2bw7Hg9O6V3qrM8QJ2DBrQ5hcC06SsM7O/6Q7F4m3hGJ4MHU40LgxPSYG2oHOUwcoeeXTjKYrydx9cWEo33ob6HkPrXvEEoIrm0fGTywufzN+3ZjtmRgEkdiGu2oUYzjUiVi8Iftjg9C8moOaBtL0q39H6XQxmEVgjfQZc93PRsopP7QG/5cDkFeYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rOirScCeSzXvj4um928qzdIzv7TtuIW2pHcKkfkWtFI=; b=XPbGwoMlNSHsTkyiEJRHZQSePeC1HChncLVL5eD9hYHZNQQHbhPTkXNcO4YSL6kP3wIuJ9ZZWxKIsLccuWBb1Juk44xjcFlJvsbgbDlmYq9aHMOQx6ddT7DYTV8xNrL072E0KXwQtxsVFKPvtDK+eSaYVSI7LZ472wP9Ni/S4RxkG+Rv6etSNb+QtwtMmM/xuxPqdvVWzuNSXwyd4+TOxEI5ElD04m81JkfZZ+ubQtmEjMNrcxDrN0iB8/fnzgGVqy7QnDce2sH8DtwoYGN24bLiXUXdKrw6jxLpQBCydXZcg+AG22qeInOd7nidYNgh0dk9Zk+imhpRpEq/ry7LEw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOirScCeSzXvj4um928qzdIzv7TtuIW2pHcKkfkWtFI=; b=YKhBHLOSd9mnb2x7NLhGz3eOewPdo7D8bh5i8Pz4UF1xC38Y7hch0NLD2fzJf90Qa8Biwcz6cQaCpIEA2effDu6HqawILZb6kQXxBdkZbrQ1061BClm7KsihDyyVGpz7YVjUboe5wi4CSpEpwNrlwudSFV3o7Efhlx5nqZhYMLI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYnZptiSLpqnZX0emNTvrI+JSjSaZmRYNPjVcjoPRYs6X/bVlRX1J9P8YGKGQCDqVCTawGuadV3fHQXB7zjz1g+sUQ4KL4s6Nws6bVBmPn6vU2ZRwqp4963hUfR1Iy8+rnFqqkJB/yktCvH01syQwEfiqssd1GaB4mFgjATjVkaekqX/NtSa4+TkQYHO9C3I/3DhorPMjSfyjp+R4BuoyWVkIk2yxS4qyCICFWUZ98OG03qEg12p8b540AgZZhtqhfvI/h3qIGIKl7rvFif+T2H5/dLPMfk2elDkUQebAxt8/iRbclwZj8TgVG6PmO1jPHCU9xTWXEtnExurf0QUmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rOirScCeSzXvj4um928qzdIzv7TtuIW2pHcKkfkWtFI=; b=TQb7H/d1SHxqvyjhbycAEGuRAu1epX3CEbWD8V4xPzl3DLFVYxZdR26xkLSrgGg61ZSecJgH9W0xo4EaBkNwBdPGobHsNfON9wAt/6VBpOV9cVZXI66fr1jBwJ9TkVtAfnF/3lzurNrAFvDKp5nP9K1GTbI36pGOTulEkpfjVd1V34hSry2fwDozx0CRVz3z/+zGyRVlRnofYfGfVVssZ1Q0FsFFHTVI3YyjGyKL+xUMuB307vzE5bxgOWE2NH9EkwCEMOqwmQpQ9Ckpswgwg/UD270HBVvdHiB5yps7D/GmeIQE2paQXqOvRfFuCGWCbTKOxe1MwVLy/zpmtyCAKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rOirScCeSzXvj4um928qzdIzv7TtuIW2pHcKkfkWtFI=; b=YKhBHLOSd9mnb2x7NLhGz3eOewPdo7D8bh5i8Pz4UF1xC38Y7hch0NLD2fzJf90Qa8Biwcz6cQaCpIEA2effDu6HqawILZb6kQXxBdkZbrQ1061BClm7KsihDyyVGpz7YVjUboe5wi4CSpEpwNrlwudSFV3o7Efhlx5nqZhYMLI= From: Marc Bonnici To: Andrew Cooper , "xen-devel@lists.xenproject.org" Subject: RE: Xen Memory Sharing Query Thread-Topic: Xen Memory Sharing Query Thread-Index: AdiXcIvKzj1u3ooYRvOwLKlCsLdCEAA/89UAAIdcHqA= Date: Mon, 18 Jul 2022 13:40:11 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: C51211359E8EE44E842BCFF30796C23D.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e36ff496-60fc-4a5c-abe7-08da68c30e8c x-ms-traffictypediagnostic: PAXPR08MB6656:EE_|VE1EUR03FT049:EE_|AM6PR08MB3622:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vFiDpqT9rgJZqcP4tfU1ebFIZ7E6ZGI0vXtGAGmVnMrpXDXP+0lIH86Bi71Uxwmi/ofLNqG4dC4vf2M9Lfeb3rh2enNxUgjwnBhJp64/G4v+rEW0c89CDOO25b/N9BlXbNyfq9JdlZvCL6RGRbUQyF4OM81lV3xoKmCob85plFtIi3Zto9YSaxkf3lSPJ6nWudRqF3qin66sakOpywv+MvxwtZCDz9gUlfDa/CeNRx95prH4UksiJ55LPQJxhP6Dv/G9ZJY4xpKq9jP28CvJftkTsqxpojH8dvB6We6nVVoXS3z8r2Z9zy1NjbVVMqhw7O/YQKA3HXgC132TTwhWS3QuRloqkOAnV6qdiUfF8fUjkALIr1BXmds3csgV+5DuGO9jBxlefNm/8Ndz2Pv6hFGBwZICdpRIwxeLhxpLYl1jPGR3eny1Zg5Mw2hPl2neG97tI1qBuSdGeZEvk9FeTP3QkVfZFPkQ8c/WubQWkiKgH1kFSHt9v9dDv0ia77d3gmCB3Q3NdMdv/mG+TZQm6D2XBXOqHqXIN7EArxINnxSMUuAlrCWJiNAhrUlx3m7463+Kl3H7FbbzGpd8T5fl3NdKCEbLrQS+P2Mt2UGMEDEogQpMOC6j7/3PdY+VsFdDEnQQCfnzBPmWBnMVwliKR9FkeQuNOOuruQ77qh8sjwNveDkaBAGBBu1n7Ogr7cAuffDHYAW8heby73ekQKlB0IFBuICimuF+qmxhaHJY8SkCraN3LVHbw/X4sFTazYqM9pe/h7xTFxF5RibieIV/NIBzeXLisQStvdfDRMUNTVZaPsYnoKK/PWJqFiN82MOwsUKouERWjvcuv82WyyCTwFY9FLHmEq7Jlmm6HJ+vAxo= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR08MB5452.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(366004)(38070700005)(26005)(8676002)(9686003)(66446008)(76116006)(66946007)(66556008)(64756008)(41300700001)(66476007)(83380400001)(110136005)(7696005)(6506007)(86362001)(478600001)(3480700007)(316002)(53546011)(55016003)(186003)(71200400001)(5660300002)(38100700002)(2906002)(8936002)(122000001)(52536014)(33656002)(966005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6656 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 703c5759-075c-4180-5dd4-08da68c30976 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EPYwiV1opkiNbHxhsP56oyyqLpeNfqDqAGhDYXiPuV1gi6IeSuDV5nKzWR8ZkOHMfSLTwrnYA3HsrMRxkRMoO7y1Eeto3BCiWXB3NP1s+BkvvuVi5tIcBdRF6w1ATofVjYEES/p+SBg7t1L4YrFJ/5XvSUAYE/0QrSBHmaVBWJL6j3pBndU044yaVethr4yIlgiCdREMa7GRyJmerWlyOFq9GEpNAsbNMyNWJwkylmNUp9+gvCNuFDUOZDvk3VJFaRVfP+t1lNwcioDDH4Q2kpS+U8/jtAeioG75sZhXdRshNMaFx9dFFr8C3fybYL2sY0XXs9fkidC+PSAWwfLUn5tlzhb7TA6q5tH9KXfic4ncJMiIRXJHmoqdjgdoonv6L+oZ6Djvv+aOdXDlLXW7IVmJUmLMJloKxlAwBSfcKK18EuVMrmyF8SpeS/B6dTkpRbaNmEBK3fi72C2eJ5lYXUmTWkRjmhdzTqBJ7YH8ahis3rIbtMShptsuRQs9cLZk6WRkG6GGN/vY5nOcN78kkN4X0O1fesx2kpHGA23i7daNpU7/HqamObb/tPZiuTRZnsKFlzmxfzYzyrTaMB+eg73a4QJYLuDfwbBAUOX/N/ocdBNFPMGiyE0VlgqtUZ8hsDt2e0be2e+OMDYxk8I8V3olNv3ltHRJBOXmssM2vdQEkKz6q41ESlY0LYzmAcM7HQQcHIvsOsdjq9cjSW9dVkfBtnL458Ol22CiF7zxhJ1jmJ471kNx3FXld0ZrLBk4T3AQSih1Jum5p7MmecXbnPxbb9L+LsBMWac1aJ0ISBsyVPD957gQ6GkryBxdscj99vS0rKiBOLiYOVNY2wjTyvaRoIoCdny5yO2hmf+OLhI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(136003)(346002)(376002)(40470700004)(46966006)(36840700001)(5660300002)(41300700001)(966005)(53546011)(52536014)(3480700007)(8936002)(86362001)(478600001)(70206006)(8676002)(26005)(9686003)(2906002)(33656002)(40460700003)(6506007)(7696005)(47076005)(81166007)(36860700001)(82740400003)(356005)(82310400005)(83380400001)(336012)(316002)(110136005)(186003)(40480700001)(55016003)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 13:40:19.6795 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e36ff496-60fc-4a5c-abe7-08da68c30e8c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3622 SGkgQW5kcmV3LA0KDQpUaGFuayB5b3UgdmVyeSBtdWNoIGZvciB5b3VyIGRldGFpbGVkIHJlcGx5 LCB0aGF0IG1ha2UgdGhpbmdzIA0KYSBsb3QgY2xlYXJlci4gSSBkaWQgaGF2ZSBhIGZldyBmb2xs b3cgdXAgcXVlc3Rpb25zLg0KDQo+IGdudHRhYiB2MiBpcyBob3JyaWJseSBtb3JlIGNvbXBsaWNh dGVkLiAgDQoNCldpdGggdjIsIGRvIHRoZSBoaWdoIGxldmVsIGJlaGF2aW91cnMgY2hhbmdlIG11 Y2ggZnJvbSANCndoYXQgeW91IGhhdmUgb3V0bGluZWQgaGVyZT8gRG8geW91IGV4cGVjdCBpbiB0 aGUgbG9uZyB0ZXJtIA0KZm9yIHYyIHRvIGJlIHRoZSBwcmVmZXJyZWQgaW1wbGVtZW50YXRpb24g b3IgYXJlIHRoZXkgbW9yZSBsaWtlIA0KYWx0ZXJuYXRpdmVzPw0KDQoNCj4gV2hpbGUgYSBncmVm IGlzIG1hcHBlZCwgZG9tQSBpcyBub3QgcGVybWl0dGVkIHRvIGVkaXQgdGhlIA0KPiBhc3NvY2lh dGVkIGVudHJ5LiAgDQoNClNvIElJVUMgb25jZSB0aGUgZ3JlZiBpcyBtYXBwZWQgdGhlbiBkb21B IGNhbid0IG1ha2UgYW55IGNoYW5nZXMgDQp0byB0aGUgZW50cnkgYXQgYWxsLCAob3IgYXQgbGVh c3QgdGhleSB3b24ndCBiZSByZWZsZWN0ZWQpLiBTbyBpZiANCmRvbUEgd2FudHMgdG8gbWFrZSBh bnkgbW9kaWZpY2F0aW9ucyAoZXh0ZW5kIHRoZSBzaGFyZWQgbWVtb3J5IA0KcmVnaW9uLCBjaGFu Z2UgcGVybWlzc2lvbnMgZXRjLiksIHRoZW4gaXQgd291bGQganVzdCBjcmVhdGUgYW5vdGhlcg0K ZW50cnkgYW5kIHNoYXJlIHRoZSBuZXcgZ3JlZj8gDQoNCg0KPiBGcm9tIGEgZ3JhbnQgcGVyc3Bl Y3RpdmUsIFhlbiBkb2Vzbid0IGVuZm9yY2UgYW55IHBvbGljeS4gIGRvbUEncyBncmVmcw0KPiBj YW4gYmUgbWFwcGVkIGluIHRoZSBtYW5uZXIgcGVybWl0dGVkIGJ5IHdoYXQgZG9tQSB3cm90ZSBp bnRvIHRoZSBncmFudA0KPiB0YWJsZS4NCg0KU28gZG9lcyB0aGlzIG1lYW4gdGhhdCBpZiBkb21B IGdyYW50cyBhY2Nlc3MgdG8gZG9tQiBmb3IgYSBnaXZlbiBmcmFtZSwgDQphbmQgdGhlbiBhZGRl ZCBhIG5ldyBlbnRyeSBpbiBpdHMgZ3JhbnQgdGFibGUgd2l0aCB0aGUgc2FtZSBmcmFtZSBkZXRh aWxzIA0KYnV0IHdpdGggImRvbWlkID0gZG9tQyIgaW5zdGVhZC4gVGhpcyB3b3VsZCBiZSBhbGxv d2VkPyBBbmQgaWYgc28sIHdvdWxkIHRoaXMgDQpyZXN1bHQgaW4gYSAzLXdheSBzaGFyZWQgYnVm ZmVyPw0KDQpBbmQgZmluYWxseSBhIHNpbWlsYXIgc2NlbmFyaW8sIGlmIGEgZnJhbWUgd2FzIHNo YXJlZCBmcm9tIGRvbUEgdG8gZG9tQiwgDQp3b3VsZCBkb21CIGJlIGFibGUgdG8gYWRkIGFuIGVu dHJ5IGluIGl0cyBvd24gZ3JhbnQgdGFibGUgdG8gc2hhcmUgdGhlIA0Kc2FtZSBmcmFtZSB3aXRo IGRvbUMgYW5kIGVuZCB1cCB3aXRoIHRoZSBzYW1lIG91dGNvbWU/DQoNClRoYW5rcw0KDQpLaW5k IFJlZ2FyZHMNCk1hcmMgQm9ubmljaQ0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ IEZyb206IEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+DQo+IFNlbnQ6 IDE1IEp1bHkgMjAyMiAxODoyOQ0KPiBUbzogTWFyYyBCb25uaWNpIDxNYXJjLkJvbm5pY2lAYXJt LmNvbT47IHhlbi0NCj4gZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6 IFhlbiBNZW1vcnkgU2hhcmluZyBRdWVyeQ0KPiANCj4gT24gMTUvMDcvMjAyMiAxNjo1NiwgTWFy YyBCb25uaWNpIHdyb3RlOg0KPiA+IEhpIEFsbCwNCj4gPg0KPiA+IEkgd2FzIHdvbmRlcmluZyBp ZiBzb21lb25lIGNvdWxkIGhlbHAgbWUgdW5kZXJzdGFuZCBzb21lIG9mIHRoZQ0KPiBydWxlcyBv ZiB0aGUNCj4gPiBtZW1vcnkgc2hhcmluZyBpbXBsZW1lbnRhdGlvbiBpbiBYZW4/DQo+ID4NCj4g PiBTcGVjaWZpY2FsbHkgSSdtIGxvb2tpbmcgdG8gdW5kZXJzdGFuZCB3aGF0IHJlc3RyaWN0aW9u cyBYZW4NCj4gcGxhY2VzIG9uDQo+ID4gZ3JhbnRpbmcgYWNjZXNzIGZyb20gb25lIERvbSB0byBh bm90aGVyIGZyb20gWGVuJ3MgcGVyc3BlY3RpdmUsDQo+IGFuZCB3aGF0IHR5cGVzDQo+ID4gb2Yg Z3JhbnQgcmVxdWVzdHMgd291bGQgYmUgYWxsb3dlZC9yZWplY3RlZCBieSBYZW4/DQo+ID4NCj4g PiBJLmUuIEhvdyB3b3VsZCB0aGUgc2l0dWF0aW9uIGJlIGhhbmRsZWQgaWYgdGhlIHNhbWUgZnJh bWUgb2YNCj4gbWVtb3J5IHdhcyBhdHRlbXB0ZWQNCj4gPiB0byBiZSBzaGFyZWQgbXVsdGlwbGUg dGltZXM/DQo+ID4NCj4gPiBBcyBhbiBleGFtcGxlIHNjZW5hcmlvLCBEb21BIHNoYXJlcyAxIHBo eXNpY2FsIHBhZ2Ugb2YgbWVtb3J5IGluIGENCj4gdHJhbnNhY3Rpb24NCj4gPiB3aXRoIERvbUIu IEFuZCB0aGVuIHdpdGhvdXQgcmVsZWFzaW5nIGFueSBtZW1vcnksIERvbUEgYXR0ZW1wdHMgdG8N Cj4gc2hhcmUNCj4gPiBhbm90aGVyIHJlZ2lvbiBvZiBtZW1vcnksIHdoaWNoIGluY2x1ZGVzIHRo ZSBzYW1lIHBoeXNpY2FsIHBhZ2Ugb2YNCj4gdGhlIHByZXZpb3VzIHNoYXJlDQo+ID4gd2l0aCBE b21CIGFnYWluLiBUaGlzIHdvdWxkIHJlc3VsdCBpbiB0d28gY29uY3VycmVudCBzaGFyZXMNCj4g Y29udGFpbmluZyBhbiBvdmVybGFwLg0KPiA+DQo+ID4gQXBvbG9naWVzIGlmIEkndmUgbWlzc2Vk IHNvbWV0aGluZyBidXQgaXMgdGhlcmUgYW55IGRvY3VtZW50YXRpb24NCj4gLyB0aHJlYXQgbW9k ZWwNCj4gPiB0aGF0IHdvdWxkIGNvdmVyIHRoZXNlIHR5cGVzIG9mIHNjZW5hcmlvcz8gU28gZmFy IEkgaGF2ZSBiZWVuDQo+IHRyeWluZyB0byByZWFkIHRocm91Z2gNCj4gPiB0aGUgY29kZSBidXQg d2FzIHdvbmRlcmluZyBpZiB0aGVyZSBpcyBzb21ldGhpbmcgZWxzZSBJIGNvdWxkDQo+IHJlZmVy IHRvIGhlbHAgbWUNCj4gPiB3aXRoIG15IHVuZGVyc3RhbmRpbmc/DQo+IA0KPiBUaGVyZSdzIG5v dGhpbmcgYWRlcXVhdGVseSB3cml0dGVuIGRvd24uwqAgSXQgb3VnaHQgdG8gbGl2ZSBpbiBzcGhp bngNCj4gZG9jcywgYnV0IG15IGNvcGlvdXMgZnJlZSB0aW1lIGlzIG5vbi1leGlzdGVudCBmb3Ig c3BlY3VsYXRpdmUNCj4gc2VjdXJpdHkNCj4gcmVhc29ucy4NCj4gDQo+IFRoaXMgYWxsIHBlcnRh aW5zIHRvIGdudHRhYiB2MSB3aGljaCBpcyB0aGUgb25seSBzdXBwb3J0ZWQgb25lIG9uDQo+IEFS TQ0KPiByaWdodCBub3cuwqAgZ250dGFiIHYyIGlzIGhvcnJpYmx5IG1vcmUgY29tcGxpY2F0ZWQu wqAgUmVmZXIgdG8NCj4gaHR0cHM6Ly9naXRodWIuY29tL3hlbi0NCj4gcHJvamVjdC94ZW4vYmxv Yi9tYXN0ZXIveGVuL2luY2x1ZGUvcHVibGljL2dyYW50X3RhYmxlLmgjTDEzMi1MMTg2DQo+IA0K PiBXaGVuIERvbUEgYW5kIERvbUIgYXJlIHNldCB1cCBhbmQgcnVubmluZywgdGhleSBlYWNoIGhh dmUgYSBncmFudA0KPiB0YWJsZS7CoCBUaGUgZ3JhbnQgdGFibGUgaXMgc29tZSBzaGFyZWQgbWVt b3J5IChvZiBYZW4ncykgbWFwcGVkIGludG8NCj4gdGhlDQo+IGd1ZXN0LCBhbmQgaXMgYSBiaWRp cmVjdGlvbmFsIGNvbW11bmljYXRpb24gaW50ZXJmYWNlIGJldHdlZW4gdGhlDQo+IGd1ZXN0DQo+ IGtlcm5lbCBhbmQgWGVuLg0KPiANCj4gVGhlIGd1ZXN0IGtlcm5lbCBsb2dpY2FsbHkgb3ducyB0 aGUgZ3JhbnQgdGFibGUsIGFuZCBpdCdzIGEgc2ltcGxlDQo+IGFycmF5DQo+IG9mIGdyYW50IGVu dHJpZXMuwqAgRW50cmllcyAwIHRocnUgNyBhcmUgcmVzZXJ2ZWQgZm9yIHN5c3RlbSB1c2UsIGFu ZA0KPiBpbmRlZWQgdHdvIGVudHJpZXMgKG9uZSBmb3IgeGVuc3RvcmUsIG9uZSBmb3IgeGVuY29u c29sZSkgYXJlIHNldCB1cA0KPiBvbg0KPiB0aGUgZ3Vlc3Qga2VybmVsJ3MgYmVoYWxmIGJ5IHRo ZSBkb21haW4gYnVpbGRlci7CoCBFbnRyaWVzIDggdGhydSAkTg0KPiBhcmUNCj4gZW50aXJlbHkg dW5kZXIgdGhlIGd1ZXN0J3MgY29udHJvbC4NCj4gDQo+IEEgZ3Vlc3Qga2VybmVsIChkb21BKSBj cmVhdGVzIGEgZ3JhbnQgYnkgZmlsbGluZyBpbiBhIGdyYW50IHRhYmxlDQo+IGVudHJ5LA0KPiBh bmQgcGFzc2luZyB0aGUgZ3JhbnQgcmVmZXJlbmNlICh0aGUgZW50cnkncyBpbmRleCBpbiB0aGUg dGFibGUpIHRvDQo+IHNvbWUNCj4gb3RoZXIgZW50aXR5IGluIHRoZSBzeXN0ZW0gKGluIHRoaXMg Y2FzZSwgZG9tQikuDQo+IA0KPiBUaGUgZ3JhbnQgdGFibGUgZW50cnkgaXMgZm9ybWVkIG9mOg0K PiANCj4gdTE2IGZsYWdzDQo+IHUxNiBkb21pZA0KPiB1MzIgZnJhbWUNCj4gDQo+IHNvIGZvciBk b21BIHRvIGdyYW50IGEgZnJhbWUgdG8gZG9tQiwgaXQgd291bGQgcGljayBhIGZyZWUgZ3JlZiAo YW55DQo+IGVudHJ5IGluIHRoZSB0YWJsZSB3aXRoIGZsYWdzPTApIGFuZCBmaWxsIGluOg0KPiAN Cj4gZnJhbWUgPSBmDQo+IGRvbWlkID0gZG9tQg0KPiBzbXBfd21iKCkNCj4gZmxhZ3MgPSBHVEZf cGVybWl0X2FjY2VzcyAodGhpbmsgImdyYW50IHVzYWJsZSIpDQo+IA0KPiBHRlRfcmVhZG9ubHkg aXMgYW5vdGhlciByZWxldmFudCBmbGFnIHRoYXQgZG9tQSBtaWdodCBjaG9vc2UgdG8gc2V0Lg0K PiANCj4gVGhlbiwgZG9tQiB3b3VsZCB0YWtlIHRoZSBncmVmIGl0IGhhcyBiZWVuIGdpdmVuIGJ5 IGRvbUEsIGFuZCBtYWtlIGENCj4gZ250dGFiX29wX21hcCgpIGh5cGVyY2FsbCwgcGFzc2luZyB7 ZG9tQSwgZ3JlZn0gYXMgYW4gaW5wdXQuDQo+IA0KPiBYZW4gbG9va3MgdXAgZ3JlZiBpbiBkb21B J3MgZ3JhbnQgdGFibGUsIGNoZWNrcyBlLmcuIGRvbUEgZ3JhbnRlZA0KPiBhY2Nlc3MNCj4gdG8g ZG9tQiwgYW5kIGlmIGV2ZXJ5dGhpbmcgaXMgaGFwcHksIHNldHMgdGhlIHRoZQ0KPiBHRlRfe3Jl YWRpbmcsd3JpdGluZ30NCj4gZmxhZ3MgKGFzIGFwcHJvcHJpYXRlKSBpbiBmbGFncy7CoCBUaGlz IHRlbGxzIGRvbUEgdGhhdCB0aGUgZ3JhbnQgaXMNCj4gY3VycmVudGx5IG1hcHBlZCByZWFkYWJs eSBhbmQvb3Igd3JpdGVhYmx5Lg0KPiANCj4gTGF0ZXIsIHdoZW4gZG9tQiB1bm1hcHMgdGhlIGdy YW50LCBYZW4gY2xlYXJzIHRoZQ0KPiBHRlRfe3JlYWRpbmcsd3JpdGluZ30NCj4gYml0cywgdGVs bGluZyBkb21BIHRoYXQgdGhlIGdyYW50IGlzIG5vIGxvbmdlciBpbiB1c2UuDQo+IA0KPiBEb21B IHRoZW4gY2xlYXJzIEdURl9wZXJtaXRfYWNjZXNzIHRvIG1hcmsgdGhpcyBhcyBncmVmIGFzIGlu dmFsaWQsDQo+IGFuZA0KPiBjYW4gdGhlbiBmcmVlIHRoZSBmcmFtZS4NCj4gDQo+IA0KPiBOb3cs IHRoYXQncyB0aGUgc2ltcGxlIG92ZXJ2aWV3LsKgIFRvIGFuc3dlciBzb21lIG9mIHlvdXIgc3Bl Y2lmaWMNCj4gcXVlc3Rpb25zOg0KPiANCj4gRG9tQSBpcyBwZXJmZWN0bHkgZnJlZSB0byBncmFu dCBhd2F5IHRoZSBzYW1lIGZyYW1lIG11bHRpcGxlIHRpbWVzLg0KPiBEb21BIGRvZXMgdGhpcyBi eSB3cml0aW5nIG11bHRpcGxlIGRpZmZlcmVudCBncmVmcyB3aXRoIHRoZSBzYW1lDQo+IGZyYW1l DQo+IGZpZWxkLsKgIFRoZXNlIGdyZWZzIGNvdWxkIGJlIHRvIHRoZSBzYW1lLCBvciBkaWZmZXJl bnQgZG9tYWlucywgYW5kDQo+IGNhbg0KPiBoYXZlIGFueSAodmFsaWQpIGNvbWJpbmF0aW9uIG9m IGZsYWdzLg0KPiANCj4gRG9tQiBpcyBwZXJmZWN0bHkgZnJlZSB0byBtYXAgdGhlIHNhbWUgZ3Jl ZiBtdWx0aXBsZSB0aW1lcy7CoCBUaGlzIGlzDQo+IGFjdHVhbGx5IGEgbmVjZXNzaXR5IGZvciB4 ODYgUFYgZ3Vlc3RzLCBiZWNhdXNlIG9mIGhvdyB3ZSByZWZlcmVuY2UNCj4gY291bnQgcGFnZXRh YmxlIGVudHJpZXMuwqAgSXQgaXMgbm90IG5lY2Vzc2FyeSBmb3IgYW55IGtpbmQgb2YgZ3Vlc3QN Cj4gb2YNCj4gSFZNIGd1ZXN0ICh4ODYgb3IgQVJNKSBiZWNhdXNlIG9mIGhvdyBndWVzdCBwaHlz aWNhbCBhZGRyZXNzIHNwYWNlDQo+IHdvcmtzLg0KPiANCj4gSU1PIGl0IHNob3VsZCBoYXZlIGJl ZW4gcmVzdHJpY3RlZCB3aGVuIHRoZSBIVk0gQUJJIHdhcyBkZXNpZ25lZCwNCj4gYnV0DQo+IGFs YXMuwqAgSW4gcHJhY3RpY2UsIFhlbiBoYXMgYW4gaW50ZXJuYWwgcmVmY291bnQgd2hpY2ggcHJl dmVudHMgYQ0KPiBncmVmDQo+IGJlaW5nIG1hcHBlZCBtb3JlIHRoYW4gMTI3IHRpbWVzIElJUkMu DQo+IA0KPiBXaGlsZSBhIGdyZWYgaXMgbWFwcGVkLCBkb21BIGlzIG5vdCBwZXJtaXR0ZWQgdG8g ZWRpdCB0aGUgYXNzb2NpYXRlZA0KPiBlbnRyeS7CoCBEb2luZyBzbyBzaG91bGRuJ3QgY2F1c2Ug YSBzZWN1cml0eSB2aW9sYXRpb24gKFhlbiBoYXMgYQ0KPiBsb2NhbA0KPiBjb3B5IG9mIHRoZSBl bnRyeSBpbiB0aGUgbWFwdHJhY2sgdGFibGUpLCBidXQgd2lsbCBhdCBsZWFzdCBjb25mdXNlDQo+ IGRpYWdub3N0aWNzIG9mIHRoZSBncmFudGVkIHN0YXRlLg0KPiANCj4gSW1wb3J0YW50bHksIGFu ZCB3aGF0IG1heSBjb21lIGFzIGEgc3VycHJpc2UsIGlzIHRoYXQgZG9tQSBoYXMgbm8NCj4gd2F5 IHRvDQo+IHJldm9rZSBhIGN1cnJlbnRseS1tYXBwZWQgZ3JhbnQuwqAgRml4aW5nIHRoaXMgbGlt aXRhdGlvbiBoYXMgYmVlbg0KPiBkaXNjdXNzZWQgc2V2ZXJhbCB0aW1lczsgdGhlcmUgYXJlIHNv bWUgdmVyeSBjb21wbGljYXRlZCBjb3JuZXINCj4gY2FzZXMsDQo+IGFuZCBJJ20gbm90IGF3YXJl IG9mIGFueSB3b3JrIGhhdmluZyBzdGFydGVkIGluIGVhcm5lc3QuDQo+IA0KPiBYZW4gZG9lcyBo YXZlIGxvZ2ljIHRvIHVubWFwIGdyYW50cyBvZiBWTXMgd2hpY2ggaGF2ZSBzaHV0IGRvd24gKGZv cg0KPiB3aGF0ZXZlciByZWFzb24pIHdpdGggZ3JhbnRzIHN0aWxsIG1hcHBlZC7CoCBUaGlzIHBy ZXZlbnRzIGRlYWRsb2Nrcw0KPiAoZS5nLiB0d28gZG9tYWlucyBncmFudCB0byBlYWNoIG90aGVy LCB0aGVuIGJvdGggY3Jhc2ggZGVsaWJlcmF0ZWx5KS4NCj4gDQo+IA0KPiBGcm9tIGEgZ3JhbnQg cGVyc3BlY3RpdmUsIFhlbiBkb2Vzbid0IGVuZm9yY2UgYW55IHBvbGljeS7CoCBkb21BJ3MNCj4g Z3JlZnMNCj4gY2FuIGJlIG1hcHBlZCBpbiB0aGUgbWFubmVyIHBlcm1pdHRlZCBieSB3aGF0IGRv bUEgd3JvdGUgaW50byB0aGUNCj4gZ3JhbnQNCj4gdGFibGUuDQo+IA0KPiBJZiB5b3Ugd2FudCB0 byBnZXQgaW50byBwb2xpY2llcyB0aGF0IFhlbiBtYXkgZW5mb3JjZSwgdGhhdCB3b3VsZCBiZQ0K PiBhDQo+IGRpc2N1c3Npb24gYWJvdXQgWFNNLCBYZW4gU2VjdXJpdHkgTW9kdWxlcy4NCj4gDQo+ IERvZXMgYW55IG9mIHRoaXMgaGVscD8NCj4gDQo+IH5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:58:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:58:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369808.601324 (Exim 4.92) (envelope-from ) id 1oDRFz-0002X2-E9; Mon, 18 Jul 2022 13:57:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369808.601324; Mon, 18 Jul 2022 13:57:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRFz-0002Wv-BM; Mon, 18 Jul 2022 13:57:55 +0000 Received: by outflank-mailman (input) for mailman id 369808; Mon, 18 Jul 2022 13:57:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRFx-0002Wp-4V for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:57:53 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0124.outbound.protection.office365.us [23.103.209.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b037368-06a1-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:57:50 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1177.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:180::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 13:57:45 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%3]) with mapi id 15.20.5438.022; Mon, 18 Jul 2022 13:57:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b037368-06a1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=dX1TAUrdwhcFnIawCMBuGobnFaK5kv1SkMo++CmH92eIBRO0n9B/Jxk0UlcZ9yluPZgQQDA/Acr6JZmjusae+yjwAqwP8ZOR+jn76LzVoa+3ptSL5h7ZLZboUCofZWqWvfGcdCDkqitWlj27ThBdWdrIF5jJ77guIdUc/ZCdLMZezaRQNiSCFh/G/S0KvQz+8PrUhrNwsJlGNjizU36UXTOEo7MlpOhSHm3U1JfI8vRRTZQUZW6uL/Z92M+MnQzAs7C+g1IE83ru1eyImMxImFJ4PnPbYGyh9zr+O+2Cb3qgQACgmRTiD0q5fDT4vAgMF73dVcHkVje/C45RUcxpfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=24RKT9kuVnThl75H9PPs5Tyq4HZePs6w1m8QMRTUg2I=; b=PNir8tQFyOdYP3zxfIG087YaWzbekX5By9tYohcJpxVN1+Ie3kMBa3HeJYvbAfltCWeUdUASW0yV/kdzvUUM2aa77RXeqvnqXeg4OcOeBwL8MdOogEpQYzNpm6yMu0PotRCKpc3XGG14d4D8ER/KXyAo81SqpCzjM+nxNwJ0mpTcqvjFG2ybDeQTdykAZ9QG++EM+gMo3Nz09byLoO97GY2cxrZ5jPS17JgiFNQmj9F6ofUV1pr9OGu/rBGJ1I8dOYpdh0Jq7dJDimmCe5UHAvoHwX9ZA1Nm2351nhLNH9s1Y6qes4pEE6ppadDS6IJFuQJKVwVyljuG3pTvFDUA/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=24RKT9kuVnThl75H9PPs5Tyq4HZePs6w1m8QMRTUg2I=; b=Bl3Kfio4pkrE1Fbl8FSFE5utJHBd51AKSg9K8N94wOKaq9NwruMsnlz7hojPUFKX4CvboI8rmR7IOIWvKpgqwad9BboxcjR+cTZeXVcrNBYnI73YWp050CILbt50v79Rq7P86DcJEnf/shzotjn5QKs91Tj/iftE3naOobGWuTxyqOcNd2VvpKr55YO67FkAVS2nTKerUhCqCcDOBwvv/QsewMq6hWcMbxyhHUrBZQ19elShrMGaSNtmybi1/D8n/jxG044umYfihKD+jAMWh/asd2jPA/dRzSNya1LTNRpW12MAZC/OoMSDSN5t1cVpju1EEyTQKXKMuMXsJMrieA== From: "Smith, Jackson" To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: RE: [PATCH v1 07/18] docs: update hyperlaunch device tree documentation Thread-Topic: [PATCH v1 07/18] docs: update hyperlaunch device tree documentation Thread-Index: AQHDrne88XyYXkgxTAt6TFUls0rRYAGjSHJ6raDaj3A= Date: Mon, 18 Jul 2022 13:57:45 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-8-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-8-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 800d8fba-865b-4992-00a6-08da68c57dba x-ms-traffictypediagnostic: BN0P110MB1177:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: N1yXm0xkk571HpGCFQH9vAVTCvIwCbpkP55ua9kBy+Ut04Dt++7JEXmqzoogE0eyJNC2thyKhpnKO8NsJqWieq63nTE/4ogQl5YDY5PCbzRcCOrO+05/Wx0hrjfrjhh1BRHZLud6+JSkUF+kHay+H+WZC7ry4d9Y3a6tFW3ChO5vUarE0HqxMSsT2arRReYzXIsrzSrP8EdBFHgOD5VsrBp3nuS/d40UhP75P/5G2Xsxq5VlYTUWQhj0YryUKD7W+eSa/5DHmxTTF//W0ep2lDl+8ZHs3ULFpH5IGGbvf+6bnubRCPC/aJ6bTi5N0XCJ680ZuzEpqXbAt3gt0kclfvuc0396P0pj62fM1Eo9GQNr0yod4Kv5t+hmbRZSZ29AlFtTZqKDqzxb+6aGzCddwgBjshe7d/HfCjNIG7QASd5hjSSSd9VWG2sHN8oZw2tu5KuoZm6OR4U5KO4EX6BdnkTk+UIK0OfXRpUVqSmMOVEkX5fkNqRf66uskaT2J3/MjvDt/wR/YsO1n0deJ9Qw1mYavhcj9yY9Cfn8/daMs5Mlf9IL1PCa+kyIFuXIJXnv5FfMo9KeAob+/LEgfnMJQsWrhwQbo4B84CfpLQAKbvo70mRKjne/zqAUqsf8YCBKoyydApNJwSw2R17Tt/XgW4ytMlA+r/qbRj+h0psDRQ6bep1e2TiFAEGNpO0kPr8kF7WrjpifoCSbTk23uvj4g1VInruYc7pbLRYpgGmomngeXt0TMB5ckHOIHArSOAzWqJNnLyMKMvTSaYqHWRg3GA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(2906002)(71200400001)(55016003)(8936002)(33656002)(76116006)(66946007)(110136005)(99936003)(66556008)(4326008)(54906003)(86362001)(66476007)(64756008)(66446008)(8676002)(498600001)(6506007)(38070700005)(83380400001)(9686003)(7696005)(5660300002)(15650500001)(186003)(52536014)(38100700002)(7416002)(82960400001)(122000001)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: seev6VssYFq+lAoYg59YZCPDCLDRJkylQ8j16VbXS6WNE5/5I2mv1ReYi1OTioJNqa5aylxWkt4VyaLJdawC3Bw8dD3x5MtObxB7hasFrO8Le5Nr2d6PZOb0b4/5zsUuCHHLkWYC5JeBkAdZ7obeqRZvcdXRdMTKg9Px+N5KWNqrPHnTqidg/1CER4377FNbKwWcIdR81AkVIbEdXNh6KLfjv18qcnn0J/nq/DxolKsl34UP4iPQZyo684Nk6PBEsT+39OIMdgKrIm2eQvD7EjQS7MXi5JYt7BNh2qxG84fdB+voSKdTkTRIOdV8dhhzcvSGCgKth/m2HM3otxPHzixhSrRVCSX8Whm8cO1/CDJgARia5UGkxtxP5JrsXH1cwELkET+tBomjq9asDB7XmRNfdkWscLiaEw6dPVuQjKupnaSnsMGI8uUKKtfZ4daYEoZy/c/QyE024pZ/IiRpiXwtaRO9wDjb3sVkUuSZPoQ= Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_005F_01D89A8C.D32C1490" MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 800d8fba-865b-4992-00a6-08da68c57dba X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 13:57:45.3065 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1177 ------=_NextPart_000_005F_01D89A8C.D32C1490 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 07/18] docs: update hyperlaunch device tree > documentation > diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst > b/docs/designs/launch/hyperlaunch-devicetree.rst > index b49c98cfbd..ae1a786d0b 100644 > --- a/docs/designs/launch/hyperlaunch-devicetree.rst > +++ b/docs/designs/launch/hyperlaunch-devicetree.rst > @@ -13,12 +13,268 @@ difference is the introduction of the ``hypervisor`` > + > +The Hypervisor node > +------------------- > + > +The ``hypervisor`` node is a top level container for the domains that > +will be > built > +by hypervisor on start up. The node will be named ``hypervisor`` with > +a > ``compatible`` > +property to identify which hypervisors the configuration is intended. ^^^ Should there be a note here that hypervisor node also needs a compatible "xen,"? > +The > hypervisor > +node will consist of one or more config nodes and one or more domain > nodes. > + > +Properties > +"""""""""" > + > +compatible > + Identifies which hypervisors the configuration is compatible. Required. > + > + Format: "hypervisor,", e.g "hypervisor,xen" ^^^ Same here: compatible ","? > Example Configuration > --------------------- > + > +Multiboot x86 Configuration Dom0-only: > +"""""""""""""""""""""""""""""""""""""" > +The following dts file can be provided to the Device Tree compiler, > +``dtc``, > to > +produce a dtb file. > +:: > + > + /dts-v1/; > + > + / { > + chosen { > + hypervisor { > + compatible = "hypervisor,xen"; ^^^^^^^^ compatible = "hypervisor,xen", "xen,x86"; > + > + dom0 { > + compatible = "xen,domain"; > + > + domid = <0>; > + > + permissions = <3>; > + functions = <0xC000000F>; > + mode = <5>; > + > + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 > + 13 F0 > 8C]; > + > + cpus = <1>; > + memory = <0x0 0x20000000>; ^^^^^^^^^^ memory = "2048M"; Needs to be updated to new format for mem. > + > + kernel { > + compatible = "module,kernel", "module,index"; > + module-index = <1>; > + }; > + }; > + > + }; > + }; > + }; > + Similar adjustments are needed for the rest of the examples I believe. Also, two typos: Line 287 is missing a line ending semi-colon. Line 82 has a double space between 'node' and 'may'. Best, Jackson ------=_NextPart_000_005F_01D89A8C.D32C1490 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIRvjCCBQcw ggLvoAMCAQICCmFaT6EABAAAAlYwDQYJKoZIhvcNAQEFBQAwQzETMBEGCgmSJomT8ixkARkWA29y ZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExEzARBgNVBAMTCkRST0ctQVBQMDQwHhcNMTgxMjI4 MTcyMjQxWhcNMjMxMjI3MTcyMjQxWjBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZImiZPy LGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQDIqSfSN9vCMUNv1ClFEtVbNDtXQG2uTUIF4sxljSpofE+0R18jypVQ5sbxYAY+YetA YaCu9sDvINgjn78bMWro7PjaXLTMKob682UX2hSlfV1u9JLIc/dHZDhQm/g+moZjbJrAaphVJ1tm zAngB5e9vpNGPtiYnxOHfyJHbXvDODHkXPQHjdhx/96DWEo2ME4o+hbrmKwSv36i9P/fZnx+7dfo EJ0Xka7ivxxAvSFYwV/lfygF37XMd6iVrQ7HBjt7PYG/Xda26prtnMTaZCj3Xfk17CJ5OD5bhG5/ Fr+BmOB7N0tMEgdOEw4J9ILZ13aZ+u8KHhl8qCRPc+ZCkYJlAgMBAAGjgf4wgfswEgYJKwYBBAGC NxUBBAUCAwcABzAjBgkrBgEEAYI3FQIEFgQUsiV9iBiIVa/fqUTl68n2xTOrX2MwHQYDVR0OBBYE FP7n8qkpqNSfs/rzfTADwqy1R1BlMBkGCSsGAQQBgjcUAgQMHgoAUwB1AGIAQwBBMAsGA1UdDwQE AwIBhjAPBgNVHRMBAf8EBTADAQH/MB8GA1UdIwQYMBaAFEkkMbfTP+jwH38Z85zodUalM249MEcG A1UdHwRAMD4wPKA6oDiGNmh0dHA6Ly9jcmwucml2ZXJzaWRlcmVzZWFyY2gub3JnL2NybC9EUk9H LUFQUDA0KDQpLmNybDANBgkqhkiG9w0BAQUFAAOCAgEALpNXZbpzZFwFsfCKiwjKg8ldws18ZS3m BX6jaYuQAdwneQTtf9gFpx3Pvhb+BSN+9yGGjyJ3EZKYcGzGYRaKBK4Vco2rDgHvHckQR4rxq8kd xJtfGPlEXwsRQRQLW3C38wrdyCjI5JZA/5u4/qZqY7DXnhjU9u/2bofQOT0iAtJ9pAnI47/vdlxG uzRBAZjqHU3OIeZkQDWUB0yuCgbKRiluFn+0wOsWKwB4d4/HeXOyLBt0qbS+cMZ79MBDuC76ykbd R1NEAUsMo69BKgqFQQ3nrUN7LGPpEqPiyheFsCWMqkd6vwsmCPwfL1tSBcfOgU0tMiSohi7mPvBk SI4ODJ97kWVPcS5WZAWmB50hrRCtp46bE1LbGhNihyf7mKn4d2zsGXmbzX0m+oza/nmR4GWGIlni DF/83XexzNYV7aNBp/1qW4gjuqzwD6f9+1+gPU3jCscHHdE2++0M9yrZiG6iYnH+T0rilJSu24CY vxavpQf9G1uD/mlcC0ypkeEqenUxv31WapzGnv3EVeU63FEEVQCcJr+VEW30opb3GTQoNAvm7zTs oCfC/dc9Uohc6wcukEHDBXA6bIjbBXVISsN9Pe9p06FafqVqfr2S5V/F5EwgbMyTFPQ+SIB6Pa+9 GlGMmOWyAEJphGBG+sK9fl8Jcub47w4YX7dCqY4p5vowggWfMIIDh6ADAgECAhASPGXcwnWGs05X Q6UPq8/lMA0GCSqGSIb3DQEBBQUAMEMxEzARBgoJkiaJk/IsZAEZFgNvcmcxFzAVBgoJkiaJk/Is ZAEZFgdycmktdXNhMRMwEQYDVQQDEwpEUk9HLUFQUDA0MB4XDTE0MDEwNjE1NDc0NFoXDTM5MDEw NjE1NTc0NFowQzETMBEGCgmSJomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2Ex EzARBgNVBAMTCkRST0ctQVBQMDQwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQC80o0V oOdwWusFIsAU/r2pLJjOgnDJeR1gR0FzW4Yx541MohHpWg2T3dvELrWbw8I1bvrwszhkErdhGisO W4OhIaJSRSZCc7/4lP67uO3WqyH6Ih0lLFejnOWi5z3ifzKYj5fHIE5z0niLL+eg1NxokT9H2qC1 ENHNJ/jssmQZyyoktvKaPShw+I7yAqdwZWr7l9jCUKFgYBbqkPm0kEzZAagNHZ+HOp6LAvGEONL6 4k7a6jGcaz5LvBTVTlCYdws2DROK6deI9w8IkV0dQFL/c4jfQZ7OBbhkz4XMXgnTvnklKlgmzA40 l1lS4RlT29NufZvbyRziERP779HwczfIjpUPi1r70JgpyD42WyepcGoKXCicmBvI8mLaEPdfxEUC 60OnO8VFbU5oKw+T6j3ByuUTD6FEqQf4Q4SqyeDA9GZwRA2k5iwLwFqA0sCfcaUOi2aQkfT3OtTr JDWnzUIFRXFuenmSMpfTS4r1GW7u3DgAlWrNgKmx0WxdQpreAVt1lkCEb6NodTu4xiktEYtXfiVP i7LNfTbNS9gDS4wzOUGFc4GIthoWZXaYzSqu4e0h1tnvVPESwCz8+Ke2olwayeLGDK7h19HSE+EK 78XAlrcSuwoCQfrZfRHouSq7si9XRHdQJElFOzUy9N5QD5RL036eqSgc+l2PSBGuPVgD7QIDAQAB o4GOMIGLMBMGCSsGAQQBgjcUAgQGHgQAQwBBMAsGA1UdDwQEAwIBhjAPBgNVHRMBAf8EBTADAQH/ MB0GA1UdDgQWBBRJJDG30z/o8B9/GfOc6HVGpTNuPTAjBgkrBgEEAYI3FQIEFgQU2fLvmTrCwkM1 lhWUNB1HIO1BY9cwEgYJKwYBBAGCNxUBBAUCAwQABDANBgkqhkiG9w0BAQUFAAOCAgEAVHa8hXq9 mLpvsLYVR1Iqak2w3d71HKoEjRA67hkS5p1QSVySBnKBo4DqL2SVBnc5kt6J+3uH0hoFQF15CJwW SzMOCwX3BGA7UpkNgDqe/0sM/FZCVnGi1U56tRgMg/Ndxu26ytn13ptec0MZwGRzU46cNamtMLcW TxZyEe46ALnKxmv125IMDxEAXyo4p/9Y7xVK7SlzbF8NYUFZB/6lSjvG7BbNdZ4TQqoZ6ngXYcKO X/fFlb2Gzagbe3RoqFfNC4wRnFkO/wcr7stOB17bHXNN2EE7QZwSiR/oS3tVZ2hSTWTzfi+Mn8FI 9WeMZ/hhkK/vwu+9Leaua6WGVdJUPSJFZK47SGOdekEZ8ipJ5X5pwSO2unOM1V4pVty28Jq9KgF5 aBYiCS/2FOHvAgolQ3PuUIZOxZ87jSd4cTEpF5rUfVLd/Wb7C/i4G15cnolsNuABl+Mgkdr9xHAs 0c3bljbfN6HdYZNHTZQ8kUL6z39UX9b0VFVXoCw+fnQOD+uaNca3lfvQENKOnNpzLSvVuwyOg9LL U2qdp74brdgXidWL56iwlBj5g/7Rt1glmNCbIusxtEHDr3RWaXvmOZt86lwT1pNy6e4iKaj5opiM y5hBglp6x595DCG05IgGyQRzP9bNyqPglQMRekuqNtiM8s/BZZ0LiVtMDkna9k9jj28wggcMMIIF 9KADAgECAhMsAARwT/LbBVtfmneXAAcABHBPMA0GCSqGSIb3DQEBCwUAMEExEzARBgoJkiaJk/Is ZAEZFgNvcmcxFzAVBgoJkiaJk/IsZAEZFgdycmktdXNhMREwDwYDVQQDEwhCUk8tRFMwMjAeFw0y MjA1MTYxNDI0MjJaFw0yMzEyMjcxNzIyNDFaMIGpMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYK CZImiZPyLGQBGRYHcnJpLXVzYTEMMAoGA1UECxMDRFJDMQ4wDAYDVQQLEwVVc2VyczEWMBQGA1UE CxMNT24tU2l0ZSBVc2VyczEWMBQGA1UEAxMNU21pdGgsIFJvYmVydDErMCkGCSqGSIb3DQEJARYc cnNtaXRoQFJpdmVyc2lkZVJlc2VhcmNoLm9yZzCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA rvdaVkLmf4emLjFcvM2ukIkTQjkEoz/feXDWuJH/9BWDUowo71IysLADaoIXy0EFNblUbZZM4pR3 29XLxbsYAQKYMLDqxbudadKICnnme7PxLZ8bnT3HhNCvK4ieUxuQz0Uied92gUg/HXrSf06oCKbw smY8uvOq1BOQ6V7sr2ECAwEAAaOCBBYwggQSMD4GCSsGAQQBgjcVBwQxMC8GJysGAQQBgjcVCIWb hmWDndEtgsWVEIGmmyuDmZlRgSWH0qVDgrHkJgIBZQIBBTA1BgNVHSUELjAsBgorBgEEAYI3FAIC BggrBgEFBQcDAgYIKwYBBQUHAwQGCisGAQQBgjcKAwQwCwYDVR0PBAQDAgWgMEMGCSsGAQQBgjcV CgQ2MDQwDAYKKwYBBAGCNxQCAjAKBggrBgEFBQcDAjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgME MEQGCSqGSIb3DQEJDwQ3MDUwDgYIKoZIhvcNAwICAgCAMA4GCCqGSIb3DQMEAgIAgDAHBgUrDgMC BzAKBggqhkiG9w0DBzAdBgNVHQ4EFgQUx9iDBJcqSRZJGZfYm0qPYN5BFcMwHwYDVR0jBBgwFoAU /ufyqSmo1J+z+vN9MAPCrLVHUGUwggEABgNVHR8EgfgwgfUwgfKgge+ggeyGgbNsZGFwOi8vL0NO PUJSTy1EUzAyKDcpLENOPUJSTy1DQTAxLENOPUNEUCxDTj1QdWJsaWMlMjBLZXklMjBTZXJ2aWNl cyxDTj1TZXJ2aWNlcyxDTj1Db25maWd1cmF0aW9uLERDPXJyaS11c2EsREM9b3JnP2NlcnRpZmlj YXRlUmV2b2NhdGlvbkxpc3Q/YmFzZT9vYmplY3RDbGFzcz1jUkxEaXN0cmlidXRpb25Qb2ludIY0 aHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJjaC5vcmcvY3JsL0JSTy1EUzAyKDcpLmNybDCCARMG CCsGAQUFBwEBBIIBBTCCAQEwgacGCCsGAQUFBzAChoGabGRhcDovLy9DTj1CUk8tRFMwMixDTj1B SUEsQ049UHVibGljJTIwS2V5JTIwU2VydmljZXMsQ049U2VydmljZXMsQ049Q29uZmlndXJhdGlv bixEQz1ycmktdXNhLERDPW9yZz9jQUNlcnRpZmljYXRlP2Jhc2U/b2JqZWN0Q2xhc3M9Y2VydGlm aWNhdGlvbkF1dGhvcml0eTBVBggrBgEFBQcwAoZJaHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJj aC5vcmcvY3JsL0JSTy1DQTAxLnJyaS11c2Eub3JnX0JSTy1EUzAyKDcpLmNydDBVBgNVHREETjBM oCwGCisGAQQBgjcUAgOgHgwccnNtaXRoQHJpdmVyc2lkZXJlc2VhcmNoLm9yZ4EccnNtaXRoQFJp dmVyc2lkZVJlc2VhcmNoLm9yZzBPBgkrBgEEAYI3GQIEQjBAoD4GCisGAQQBgjcZAgGgMAQuUy0x LTUtMjEtMzE1MzczODEzMi0zNDMzOTAxMTAzLTQxMTc4ODYyMi00MDQ1NTANBgkqhkiG9w0BAQsF AAOCAQEAYaBBvBGuhKlhJ2O6JBtcYRW7CYREO4+CAep40ordLIS0gvnKuE7A3a+4YzJpqKvfSbQd +dQzeaZNz3kTpwJlZh5fJb/Bo7zQWlvDU1p/rr7a2tAnWNqSVlgQrvAk35TLqlGAmwo8tgQ1jxc/ JAkWg5Pqks6IKyO8CwKuIEOqL7vxN/THcEvpJvLnhRxm/ARosCDW1x0XTwivA8tS1AVvxxcpQAXS uo/q3WNG/XDC8oO6oJLZfnpl9LiDBrsHEzDaR3Ct3XCR6rJ4ezjwFjH4SEOWCWeWsLhk+uoOgAx5 4cKlGpprXf5oje+0nSz1bAw5kaGD8k83rXL75YVcIuRTlDGCAskwggLFAgEBMFgwQTETMBEGCgmS JomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAy AhMsAARwT/LbBVtfmneXAAcABHBPMAkGBSsOAwIaBQCgggHHMBgGCSqGSIb3DQEJAzELBgkqhkiG 9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIyMDcxODEzNTc0M1owIwYJKoZIhvcNAQkEMRYEFBtyuJiM jSrJRyZpJvMbdpeRia7iMGcGCSsGAQQBgjcQBDFaMFgwQTETMBEGCgmSJomT8ixkARkWA29yZzEX MBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAyAhMsAARwT/LbBVtfmneX AAcABHBPMGkGCyqGSIb3DQEJEAILMVqgWDBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZIm iZPyLGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDICEywABHBP8tsFW1+ad5cABwAEcE8w gZMGCSqGSIb3DQEJDzGBhTCBgjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAoGCCqGSIb3DQMH MAsGCWCGSAFlAwQBAjAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAhowCwYJ YIZIAWUDBAIDMAsGCWCGSAFlAwQCAjALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEgYB+T05y l8Q3LlYZQbFPLI9mFbfGBCdc88WEaA0/sPl9D//3fsmSPFY5vPU8BG3zZmb6nsG8MG+JS6j4EusO I0h9iKTWiyq1ruWOLBpBPN7SiqafwYOoK7PpY6NbxT0cUgf/1R3hY3m/gPlNFWuGsusWwhUL4UXn eBo+0VF3H9egtwAAAAAAAA== ------=_NextPart_000_005F_01D89A8C.D32C1490-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:58:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:58:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369813.601335 (Exim 4.92) (envelope-from ) id 1oDRGj-00032q-Nf; Mon, 18 Jul 2022 13:58:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369813.601335; Mon, 18 Jul 2022 13:58:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRGj-00032j-KB; Mon, 18 Jul 2022 13:58:41 +0000 Received: by outflank-mailman (input) for mailman id 369813; Mon, 18 Jul 2022 13:58:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRGh-0002Wp-Hp for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:58:39 +0000 Received: from USG02-BN3-obe.outbound.protection.office365.us (mail-bn3usg02on0125.outbound.protection.office365.us [23.103.208.125]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b928cca5-06a1-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:58:38 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1323.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:182::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 18 Jul 2022 13:58:35 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%3]) with mapi id 15.20.5438.022; Mon, 18 Jul 2022 13:58:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b928cca5-06a1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=GAEWm03wPPeJV/jtFy2zQEwYP5hcpBdmhHC7h265Dq2/f2wHyRDuvEPPyhJKi0hKxZedkyr3X3eG3w7cBAnEeEu4pXAiMIEmrMbJEJ3ByU00sBPNze9hma3cJ6VVL5aAKgxD06ZjGUbDUQO2/Oo1Jm+Dfpawml9cFOvPyuvVMvFZjYs9DQ8nEPuHWT9chK47+UJJq+gH4ueylUM/n+EFd8EWg+PS8aMPz44MxKTqlf1u6hmqSv7O7rmqVKLrn5G+EDOuvXaTV2LqfJJTNJSVZp9fo4Gq0HlavEv3K9WRk4DX0qzPx2bSyJZJpKnhrOww6e7c8cHEB9vJX5uczu9kOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfgsxtHOgQRRggHd/sEp2IwzSm7ATQj+oNLqHdWz+lM=; b=o6YfVnAAFYMPlGW0Q977gEAF+QiyItBC0Nw6yFiE3wC+5+oWevM3nCs5aL2n7RtQu3nOBtcGYnvIZelA3BuYSKlBydgFqe/UPlG1t/9M+2sqZLIGPCMWiyY8gZqhZStqu2rK+6SnsTx9i5TY6KsMd+3qea53W6YcbCX5fe2hck6cSvvWDouv2t+/XZ4uggJmRU3TNbp3ztQSY/vp6TuXWPjSDDklltub+IvpyrAQpuT4XyYJc/CYZEdyx1IDiIQgBfdY9dspvdLsNEeY8D/hVL/xkgmsGY5VEKvJRAFCC4DhENwx/ciBUEAyYgN9Fa3bntogs51gG1sSo5jIZJotAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bfgsxtHOgQRRggHd/sEp2IwzSm7ATQj+oNLqHdWz+lM=; b=BHYZPhnMvesqXTE55DhDjK5pHgG/HBTt/5aNWw8lWVUESECAOe5WoLuChmTbubihrt5zLVV1Q6VlRD+k7Q4G85Y7GjMtDC9Kv5GWpwgXstmzsuiBsFZs6oywAp0e++OTqAMS8y7R8QCqvAZrSSEKcL/eYuifx74hBHdfDvH8IlrPyeaScL8FX3Fvo/4g8RzK68OxgT0xIXLD1flWa2OLfMHMWd4ZPgl0iu+4rYzhW5fvcgtbXFgEy1gq9Y+MdnJJ8Q5TdvUAB3Mkw54Q1SfVsPC7rW5hDldgmyh7LxOy2jJJk4OFlzKDBAtwnsKg9gIuZ7BCMAId1sMlMZlC8Mv95w== From: "Smith, Jackson" To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: RE: [PATCH v1 04/18] x86: refactor entrypoints to new boot info Thread-Topic: [PATCH v1 04/18] x86: refactor entrypoints to new boot info Thread-Index: AQHDrne88XyYXkgxTAt6TFUls0rRYAHkVRHErZp+x6A= Date: Mon, 18 Jul 2022 13:58:35 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-5-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-5-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21e352e3-6f05-4355-2339-08da68c59bac x-ms-traffictypediagnostic: BN0P110MB1323:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cOdVEyIGcE5DsJomLy8FuojyDW5Y9WHN5EQvVmBtj7VfrcVJ8EAzLXfuqtm5BGhFkm5/hv00Y1BGp/b1h942I+0CIQcBz6UIcHi8t8R62l6jzyx7OXlprqVsylB9cAdRjar0r/PIyR4C7uquAFnbDhpkyTd7IZ9D5LETVZclt7Q8JnHG7tgFuHIPiW5WjajTgmfVcNcoSBavIOJ8gJCrh2iAIUWv7PYNrea2fRgL1W0O7VtpAd3fo47V6MObzKtNrmwW6/RHxFocSDh83d4Yey+yqm8AC0tgErWXOHbfbYF319YIN1OxukZaR3/2JQOd0+YlrBScJFfRg5U1r15s8AlGggFqXxduI1bWVXN6bBjkCSmvE5e0mQRXnwbUHdWC88N26TltNxIyqPwoVkm8gohicIlEsu3lOqtYA1ukQ/z32S8j/fTiQYc6zMlo5Kuw3jg7tNHJjIkDvjNWI50N1OIHW6w/S2S1ymDq9WAX9gULhB7epegv0OrR+uHkBODFFtRquZhYR5p1yzThpnEp3/wUDyMz3vJ96nC+oWbPFbFx6WjEYmvQF2u25sciqpB7+Sy/m3MaOmptizX264VHnpokJI/v7WW47uI3rHTPFMuciIeAUGZgqBZrSP1lXVPoRN2d2O5FBr8yy8j1JkX3mbuyx8HTJlKxkGWg6PUYZoGWQFE2fHKw9dqNmtMVSZaSC8S0akp1bWIUB9flV8Y5AQO/0TrA/VC6NokVFlUrqMKaYWrqZNgb3NHSfAm22Tdu x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(99936003)(64756008)(2906002)(76116006)(66476007)(33656002)(66946007)(52536014)(4326008)(8936002)(9686003)(66556008)(110136005)(66446008)(8676002)(5660300002)(71200400001)(6506007)(54906003)(86362001)(7696005)(498600001)(55016003)(82960400001)(122000001)(45080400002)(38100700002)(38070700005)(186003)(83380400001)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: b1YkxT8rxHNJZJBPMgcfiUs/w/LOtrMoBwZ05emJbaT5Ev9DXzUVBuvMtVx45UFYEOi8vhoU2U2YPVdiXr5zfZcEAHoHF1QS3w99/Wyfk3BAeSVUEWar56eA91CiytezmyPLNSxMMEiQ0h31VS8aSdIHxhF86kPnL2ab5dAX6dynsEfW0EnFg/xL6Vw2XY7kDluILO//lITfMwRr/ThjRfwlkCnukUgFArxt3XuN/izytOFDR5VB0cNmbH/wTQ34oOtKFeh3+i5Lr3IL/8a6tSzF7H1NjC9JwYlOaZ3fAF5F4Fo90ZMqyoRi1EN2HaFuuI108VRNtmxGuV1cIwdk7vnGK80xAbC6VNZD4Jjyvd7e8ZVcCnaCn1Tg4bWsxr1afSWhrWLx2cz9wgld22gLpndd9UMOYE8g+theV7RTeLN099bwuKcIjpGEsrSxphMOi2Fy6UO4iOqtYfHekiotsLDMx0WWwVzPBxTw9ZhCl0o= Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_0077_01D89A8C.F110D220" MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 21e352e3-6f05-4355-2339-08da68c59bac X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 13:58:35.5785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1323 ------=_NextPart_000_0077_01D89A8C.F110D220 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Daniel, I hope outlook gets this reply right. > -----Original Message----- > Subject: [PATCH v1 04/18] x86: refactor entrypoints to new boot info > diff --git a/xen/arch/x86/guest/xen/pvh-boot.c > b/xen/arch/x86/guest/xen/pvh-boot.c > index 834b1ad16b..28cf5df0a3 100644 > --- a/xen/arch/x86/guest/xen/pvh-boot.c > +++ b/xen/arch/x86/guest/xen/pvh-boot.c > @@ -99,13 +118,16 @@ static void __init get_memory_map(void) > sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); > } > > -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) > +void __init pvh_init(struct boot_info **bi) > { > - convert_pvh_info(mbi, mod); > + *bi = init_pvh_info(); > + convert_pvh_info(*bi); > > hypervisor_probe(); > ASSERT(xen_guest); > > + (*bi)->arch->xen_guest = xen_guest; I think you may have a typo/missed refactoring here? I changed this line to "(*bi)->arch->xenguest = xen_guest;" to get the patchset to build. The arch_boot_info struct in boot_info32.h has a field 'xen_guest' but the same field in asm/bootinfo.h was re-named from 'xen_guest' to 'xenguest' in the 'x86: adopt new boot info structures' commit. What was your intent? > + > get_memory_map(); > } > Thanks, Jackson Smith ------=_NextPart_000_0077_01D89A8C.F110D220 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIRvjCCBQcw ggLvoAMCAQICCmFaT6EABAAAAlYwDQYJKoZIhvcNAQEFBQAwQzETMBEGCgmSJomT8ixkARkWA29y ZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExEzARBgNVBAMTCkRST0ctQVBQMDQwHhcNMTgxMjI4 MTcyMjQxWhcNMjMxMjI3MTcyMjQxWjBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZImiZPy LGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQDIqSfSN9vCMUNv1ClFEtVbNDtXQG2uTUIF4sxljSpofE+0R18jypVQ5sbxYAY+YetA YaCu9sDvINgjn78bMWro7PjaXLTMKob682UX2hSlfV1u9JLIc/dHZDhQm/g+moZjbJrAaphVJ1tm zAngB5e9vpNGPtiYnxOHfyJHbXvDODHkXPQHjdhx/96DWEo2ME4o+hbrmKwSv36i9P/fZnx+7dfo EJ0Xka7ivxxAvSFYwV/lfygF37XMd6iVrQ7HBjt7PYG/Xda26prtnMTaZCj3Xfk17CJ5OD5bhG5/ Fr+BmOB7N0tMEgdOEw4J9ILZ13aZ+u8KHhl8qCRPc+ZCkYJlAgMBAAGjgf4wgfswEgYJKwYBBAGC NxUBBAUCAwcABzAjBgkrBgEEAYI3FQIEFgQUsiV9iBiIVa/fqUTl68n2xTOrX2MwHQYDVR0OBBYE FP7n8qkpqNSfs/rzfTADwqy1R1BlMBkGCSsGAQQBgjcUAgQMHgoAUwB1AGIAQwBBMAsGA1UdDwQE AwIBhjAPBgNVHRMBAf8EBTADAQH/MB8GA1UdIwQYMBaAFEkkMbfTP+jwH38Z85zodUalM249MEcG A1UdHwRAMD4wPKA6oDiGNmh0dHA6Ly9jcmwucml2ZXJzaWRlcmVzZWFyY2gub3JnL2NybC9EUk9H LUFQUDA0KDQpLmNybDANBgkqhkiG9w0BAQUFAAOCAgEALpNXZbpzZFwFsfCKiwjKg8ldws18ZS3m BX6jaYuQAdwneQTtf9gFpx3Pvhb+BSN+9yGGjyJ3EZKYcGzGYRaKBK4Vco2rDgHvHckQR4rxq8kd xJtfGPlEXwsRQRQLW3C38wrdyCjI5JZA/5u4/qZqY7DXnhjU9u/2bofQOT0iAtJ9pAnI47/vdlxG uzRBAZjqHU3OIeZkQDWUB0yuCgbKRiluFn+0wOsWKwB4d4/HeXOyLBt0qbS+cMZ79MBDuC76ykbd R1NEAUsMo69BKgqFQQ3nrUN7LGPpEqPiyheFsCWMqkd6vwsmCPwfL1tSBcfOgU0tMiSohi7mPvBk SI4ODJ97kWVPcS5WZAWmB50hrRCtp46bE1LbGhNihyf7mKn4d2zsGXmbzX0m+oza/nmR4GWGIlni DF/83XexzNYV7aNBp/1qW4gjuqzwD6f9+1+gPU3jCscHHdE2++0M9yrZiG6iYnH+T0rilJSu24CY vxavpQf9G1uD/mlcC0ypkeEqenUxv31WapzGnv3EVeU63FEEVQCcJr+VEW30opb3GTQoNAvm7zTs oCfC/dc9Uohc6wcukEHDBXA6bIjbBXVISsN9Pe9p06FafqVqfr2S5V/F5EwgbMyTFPQ+SIB6Pa+9 GlGMmOWyAEJphGBG+sK9fl8Jcub47w4YX7dCqY4p5vowggWfMIIDh6ADAgECAhASPGXcwnWGs05X Q6UPq8/lMA0GCSqGSIb3DQEBBQUAMEMxEzARBgoJkiaJk/IsZAEZFgNvcmcxFzAVBgoJkiaJk/Is ZAEZFgdycmktdXNhMRMwEQYDVQQDEwpEUk9HLUFQUDA0MB4XDTE0MDEwNjE1NDc0NFoXDTM5MDEw NjE1NTc0NFowQzETMBEGCgmSJomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2Ex EzARBgNVBAMTCkRST0ctQVBQMDQwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQC80o0V oOdwWusFIsAU/r2pLJjOgnDJeR1gR0FzW4Yx541MohHpWg2T3dvELrWbw8I1bvrwszhkErdhGisO W4OhIaJSRSZCc7/4lP67uO3WqyH6Ih0lLFejnOWi5z3ifzKYj5fHIE5z0niLL+eg1NxokT9H2qC1 ENHNJ/jssmQZyyoktvKaPShw+I7yAqdwZWr7l9jCUKFgYBbqkPm0kEzZAagNHZ+HOp6LAvGEONL6 4k7a6jGcaz5LvBTVTlCYdws2DROK6deI9w8IkV0dQFL/c4jfQZ7OBbhkz4XMXgnTvnklKlgmzA40 l1lS4RlT29NufZvbyRziERP779HwczfIjpUPi1r70JgpyD42WyepcGoKXCicmBvI8mLaEPdfxEUC 60OnO8VFbU5oKw+T6j3ByuUTD6FEqQf4Q4SqyeDA9GZwRA2k5iwLwFqA0sCfcaUOi2aQkfT3OtTr JDWnzUIFRXFuenmSMpfTS4r1GW7u3DgAlWrNgKmx0WxdQpreAVt1lkCEb6NodTu4xiktEYtXfiVP i7LNfTbNS9gDS4wzOUGFc4GIthoWZXaYzSqu4e0h1tnvVPESwCz8+Ke2olwayeLGDK7h19HSE+EK 78XAlrcSuwoCQfrZfRHouSq7si9XRHdQJElFOzUy9N5QD5RL036eqSgc+l2PSBGuPVgD7QIDAQAB o4GOMIGLMBMGCSsGAQQBgjcUAgQGHgQAQwBBMAsGA1UdDwQEAwIBhjAPBgNVHRMBAf8EBTADAQH/ MB0GA1UdDgQWBBRJJDG30z/o8B9/GfOc6HVGpTNuPTAjBgkrBgEEAYI3FQIEFgQU2fLvmTrCwkM1 lhWUNB1HIO1BY9cwEgYJKwYBBAGCNxUBBAUCAwQABDANBgkqhkiG9w0BAQUFAAOCAgEAVHa8hXq9 mLpvsLYVR1Iqak2w3d71HKoEjRA67hkS5p1QSVySBnKBo4DqL2SVBnc5kt6J+3uH0hoFQF15CJwW SzMOCwX3BGA7UpkNgDqe/0sM/FZCVnGi1U56tRgMg/Ndxu26ytn13ptec0MZwGRzU46cNamtMLcW TxZyEe46ALnKxmv125IMDxEAXyo4p/9Y7xVK7SlzbF8NYUFZB/6lSjvG7BbNdZ4TQqoZ6ngXYcKO X/fFlb2Gzagbe3RoqFfNC4wRnFkO/wcr7stOB17bHXNN2EE7QZwSiR/oS3tVZ2hSTWTzfi+Mn8FI 9WeMZ/hhkK/vwu+9Leaua6WGVdJUPSJFZK47SGOdekEZ8ipJ5X5pwSO2unOM1V4pVty28Jq9KgF5 aBYiCS/2FOHvAgolQ3PuUIZOxZ87jSd4cTEpF5rUfVLd/Wb7C/i4G15cnolsNuABl+Mgkdr9xHAs 0c3bljbfN6HdYZNHTZQ8kUL6z39UX9b0VFVXoCw+fnQOD+uaNca3lfvQENKOnNpzLSvVuwyOg9LL U2qdp74brdgXidWL56iwlBj5g/7Rt1glmNCbIusxtEHDr3RWaXvmOZt86lwT1pNy6e4iKaj5opiM y5hBglp6x595DCG05IgGyQRzP9bNyqPglQMRekuqNtiM8s/BZZ0LiVtMDkna9k9jj28wggcMMIIF 9KADAgECAhMsAARwT/LbBVtfmneXAAcABHBPMA0GCSqGSIb3DQEBCwUAMEExEzARBgoJkiaJk/Is ZAEZFgNvcmcxFzAVBgoJkiaJk/IsZAEZFgdycmktdXNhMREwDwYDVQQDEwhCUk8tRFMwMjAeFw0y MjA1MTYxNDI0MjJaFw0yMzEyMjcxNzIyNDFaMIGpMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYK CZImiZPyLGQBGRYHcnJpLXVzYTEMMAoGA1UECxMDRFJDMQ4wDAYDVQQLEwVVc2VyczEWMBQGA1UE CxMNT24tU2l0ZSBVc2VyczEWMBQGA1UEAxMNU21pdGgsIFJvYmVydDErMCkGCSqGSIb3DQEJARYc cnNtaXRoQFJpdmVyc2lkZVJlc2VhcmNoLm9yZzCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA rvdaVkLmf4emLjFcvM2ukIkTQjkEoz/feXDWuJH/9BWDUowo71IysLADaoIXy0EFNblUbZZM4pR3 29XLxbsYAQKYMLDqxbudadKICnnme7PxLZ8bnT3HhNCvK4ieUxuQz0Uied92gUg/HXrSf06oCKbw smY8uvOq1BOQ6V7sr2ECAwEAAaOCBBYwggQSMD4GCSsGAQQBgjcVBwQxMC8GJysGAQQBgjcVCIWb hmWDndEtgsWVEIGmmyuDmZlRgSWH0qVDgrHkJgIBZQIBBTA1BgNVHSUELjAsBgorBgEEAYI3FAIC BggrBgEFBQcDAgYIKwYBBQUHAwQGCisGAQQBgjcKAwQwCwYDVR0PBAQDAgWgMEMGCSsGAQQBgjcV CgQ2MDQwDAYKKwYBBAGCNxQCAjAKBggrBgEFBQcDAjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgME MEQGCSqGSIb3DQEJDwQ3MDUwDgYIKoZIhvcNAwICAgCAMA4GCCqGSIb3DQMEAgIAgDAHBgUrDgMC BzAKBggqhkiG9w0DBzAdBgNVHQ4EFgQUx9iDBJcqSRZJGZfYm0qPYN5BFcMwHwYDVR0jBBgwFoAU /ufyqSmo1J+z+vN9MAPCrLVHUGUwggEABgNVHR8EgfgwgfUwgfKgge+ggeyGgbNsZGFwOi8vL0NO PUJSTy1EUzAyKDcpLENOPUJSTy1DQTAxLENOPUNEUCxDTj1QdWJsaWMlMjBLZXklMjBTZXJ2aWNl cyxDTj1TZXJ2aWNlcyxDTj1Db25maWd1cmF0aW9uLERDPXJyaS11c2EsREM9b3JnP2NlcnRpZmlj YXRlUmV2b2NhdGlvbkxpc3Q/YmFzZT9vYmplY3RDbGFzcz1jUkxEaXN0cmlidXRpb25Qb2ludIY0 aHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJjaC5vcmcvY3JsL0JSTy1EUzAyKDcpLmNybDCCARMG CCsGAQUFBwEBBIIBBTCCAQEwgacGCCsGAQUFBzAChoGabGRhcDovLy9DTj1CUk8tRFMwMixDTj1B SUEsQ049UHVibGljJTIwS2V5JTIwU2VydmljZXMsQ049U2VydmljZXMsQ049Q29uZmlndXJhdGlv bixEQz1ycmktdXNhLERDPW9yZz9jQUNlcnRpZmljYXRlP2Jhc2U/b2JqZWN0Q2xhc3M9Y2VydGlm aWNhdGlvbkF1dGhvcml0eTBVBggrBgEFBQcwAoZJaHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJj aC5vcmcvY3JsL0JSTy1DQTAxLnJyaS11c2Eub3JnX0JSTy1EUzAyKDcpLmNydDBVBgNVHREETjBM oCwGCisGAQQBgjcUAgOgHgwccnNtaXRoQHJpdmVyc2lkZXJlc2VhcmNoLm9yZ4EccnNtaXRoQFJp dmVyc2lkZVJlc2VhcmNoLm9yZzBPBgkrBgEEAYI3GQIEQjBAoD4GCisGAQQBgjcZAgGgMAQuUy0x LTUtMjEtMzE1MzczODEzMi0zNDMzOTAxMTAzLTQxMTc4ODYyMi00MDQ1NTANBgkqhkiG9w0BAQsF AAOCAQEAYaBBvBGuhKlhJ2O6JBtcYRW7CYREO4+CAep40ordLIS0gvnKuE7A3a+4YzJpqKvfSbQd +dQzeaZNz3kTpwJlZh5fJb/Bo7zQWlvDU1p/rr7a2tAnWNqSVlgQrvAk35TLqlGAmwo8tgQ1jxc/ JAkWg5Pqks6IKyO8CwKuIEOqL7vxN/THcEvpJvLnhRxm/ARosCDW1x0XTwivA8tS1AVvxxcpQAXS uo/q3WNG/XDC8oO6oJLZfnpl9LiDBrsHEzDaR3Ct3XCR6rJ4ezjwFjH4SEOWCWeWsLhk+uoOgAx5 4cKlGpprXf5oje+0nSz1bAw5kaGD8k83rXL75YVcIuRTlDGCAskwggLFAgEBMFgwQTETMBEGCgmS JomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAy AhMsAARwT/LbBVtfmneXAAcABHBPMAkGBSsOAwIaBQCgggHHMBgGCSqGSIb3DQEJAzELBgkqhkiG 9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIyMDcxODEzNTgzM1owIwYJKoZIhvcNAQkEMRYEFEJrZzwY BJiQgw8BvVhV8FPByQX/MGcGCSsGAQQBgjcQBDFaMFgwQTETMBEGCgmSJomT8ixkARkWA29yZzEX MBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAyAhMsAARwT/LbBVtfmneX AAcABHBPMGkGCyqGSIb3DQEJEAILMVqgWDBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZIm iZPyLGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDICEywABHBP8tsFW1+ad5cABwAEcE8w gZMGCSqGSIb3DQEJDzGBhTCBgjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAoGCCqGSIb3DQMH MAsGCWCGSAFlAwQBAjAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAhowCwYJ YIZIAWUDBAIDMAsGCWCGSAFlAwQCAjALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEgYB4h328 rJ4q8rg5L8sVKv49pcH8YhEQ+5/TKKoEcc7F6AqAPpm7F9w4gVxtPqkNWmfApdG7Rfb7Z98mz0Av ri9DOkYkzvI7uP6wvy56yKuj0aaYeCoUhytR9E2/p9WO8WQC52Jg8KuYnLtGsLXETmmRbBGHqBls YNKyovrXqDS4EwAAAAAAAA== ------=_NextPart_000_0077_01D89A8C.F110D220-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369819.601346 (Exim 4.92) (envelope-from ) id 1oDRHM-0003hy-41; Mon, 18 Jul 2022 13:59:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369819.601346; Mon, 18 Jul 2022 13:59:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRHM-0003hr-1P; Mon, 18 Jul 2022 13:59:20 +0000 Received: by outflank-mailman (input) for mailman id 369819; Mon, 18 Jul 2022 13:59:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRHL-0002Wp-A3 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:59:19 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0139.outbound.protection.office365.us [23.103.209.139]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfe1721b-06a1-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:59:18 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB0967.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:16f::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Mon, 18 Jul 2022 13:59:15 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%3]) with mapi id 15.20.5438.022; Mon, 18 Jul 2022 13:59:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfe1721b-06a1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=tdL0rh5ApMDvZixSsTQgHXR5tF2QUyydeHVEg8OdIcv4/6XYr3trSn4c+GssqmLyvnMzK/VtPI1iVan80O9yeNZCeDpVg+T496Sr/4j6jtpXObgm98Klvue1Vd+tJabbrLmHeO777tV8AaFuc5HHaE4iVdHb02qJIAZlvOx4RZWubGNqTHq+VL56Hak0KIDVqFrPcIYBxD6IairIgN+/z91Ra38Ae3069NIBzmv3G0uZgtos7HwALp/ObFlCaIeasIheA/MfeDi9AtvWuYkK06T2XeSY/tFuRazBvrVHEwOfRKMcIwDl3DgGKHjaBx9VklWcLxxN1DfZuXTbMhroFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BymDOuYM+p3UPAbdT0Q6XQxs2t3u1E5D+WGrIRpGL2g=; b=BYi5WCaC8Cc07mooKU2BjUpK8sMjeZeYwV5RA6QEnpd8JQEoCLg5pNd3i7RJBAKHusRCdgJBZWUxnoDt7UOBnUXnfHLAAIUt9tTygy4SFGQzS7Yxzj1t5+VsGK1UqvxDW78t6mTsDlnTv9j86BB2ArUhtArBLMXytKXvYBhGR0FYkV4/24Et3WFKN1vBaNNhtPJuZWGkus8y7dMl3vNZA1gwFcDZTnbds2m/f1DsM3zzGje0nq77Pf7M9D8bPDPxsut6T0Bw/PIM/RmvVtXwe/TsvMPB8yvJkTYzOzoN0Drohg1DrUtbCEv15LARe0gCEaCQs1UYhmoMTPZHdTOE4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BymDOuYM+p3UPAbdT0Q6XQxs2t3u1E5D+WGrIRpGL2g=; b=bH3XkhiwYdoy+lHsDRqGnG9hr7wPsLBNVl9X+uu5vqWMqvNGWs4h36HYb/hWU3wNkGlghJYMHpwRs5AlziFhKKKiS/jArnzVZiBFf1NZ+iBK07e6Cp8QdJUCBrG71x9Q6nRWI8YPEYCvwlqoPfwYxBl8UQFKi8PAcHkMA2euAzgx/fjLGVH6Yny6YlnX4U2cZCWnRLhvM7vi15mCDi6karsnBq5iV/AhHZhTQdJLEdyA90cNA5646z05fL7guGAkugrb5iJh9BZ+UcV/yB5R0YObRidJzZq6dOKp0YihawfqNrGxCK0FmISGB/g9tibI0vNwJ6tQKYicoCEVorEktQ== From: "Smith, Jackson" To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , George Dunlap , Julien Grall , Stefano Stabellini Subject: RE: [PATCH v1 10/18] x86: introduce the domain builder Thread-Topic: [PATCH v1 10/18] x86: introduce the domain builder Thread-Index: AQHDrne88XyYXkgxTAt6TFUls0rRYAIuncUgrZgzpLA= Date: Mon, 18 Jul 2022 13:59:15 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-11-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-11-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a786c582-69d6-4267-db28-08da68c5b352 x-ms-traffictypediagnostic: BN0P110MB0967:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: r7auTB2zwTsP5poCHc+8uiuA/CA2wV0Y2gYaD/jAq7470RqFJUt10mQGurQ9PdaH84cMkIRoARveC6HtsVveay8rSS5WzvrPQRerddM7XAe1eTIUqd35r32pgPFS0bu2awMpibodWK789IwmNqa56t05FCz7R0afDnW/GcowJoAkMO39g3SC79aDax++s0Xt9E4wjrjCTN1sJEijpHrCuocef7UHX61yI60OHH15u6YVyvGj/Wnf2L/hHrEYsjZTDj4K9rKSdNIxwReLY6KziLdSQNxeZ5dDL+9kRMB/oWevuVjEUuj+kzBpJVwT6dj3WroLquulsDFkJT/lwoPTnoyXMT0RWU0oQ/pxvLU2ZW31bhDyqkGKb+ehuMfYlqkyIy8yk/xLt+Hcm5ov0dda5vtFqW/fz7Su5dI6edV80NdiHBQHFax+sRKO+QhXuOZ6JI4z+8N1SOlpvubC0O80A8lifdf4B995obRGHTj7ddoCxgZLQG4kiHTxy+TdCiUEqFNZ2JWrA97fESZKzVqyq4jbfS89R2SEPJGyvqc3Ty4OuHKB8BAG1VIIF5OcUsQZDnHIMICb2v7g7G0/z8SuuQ4LDTM+6NRWwmkdpBd+LrrPmVkFZ5sIke3LmlTJvrsqqDOmHdPa70f8G4gefR0IQTrXwZC0D0RbAeU4UHVBT/unJZjMD0+Eix1DkMM4EfNPmoEl7DTjOCLH3AGl9HiQPG4dXQ3nrhXFTS+rUiSnJ/Vhx6mlIctmaEYa/E7iN4lr x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(38100700002)(76116006)(8676002)(4326008)(33656002)(71200400001)(99936003)(54906003)(186003)(8936002)(110136005)(66476007)(66946007)(66446008)(64756008)(66556008)(7416002)(5660300002)(82960400001)(2906002)(86362001)(6506007)(52536014)(7696005)(83380400001)(498600001)(9686003)(122000001)(38070700005)(55016003)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: zo+JyV8SMrxTiT4/3ENCeuGC1sKz+a8CHuUXH1joZpnDFcG4tV8qw1g9w/4bKL6aYVH3Ex2wz9xM40eBtS5UgRKk2qxwr+gdKzjuVMbbWYMwC8LpUQs1BbBkADVQ6jL6V65ZKus8H3tAfs+tc1y7zZIf+fiv5z7vexmcnlcoQZz8IQFfR4SNxBM5fER0UNwfOf3dF9cqjptiu/xpRTvph+NsuLNwV8y4M2xkGP7ngoHPw34SiWXB4mAbE5+SafaepZQywmVSI2/v6tFHoypl6tXxj6zUkN9lUFrtVntz5ei9nj7T7ylDJnbUkY4vdnVZGUpBEw6NFyPubAepMNnUtKiIc67UHZrPM92QYys1txj1aRQN50hiyh8dptjVFuFwkWxSAhLwSspf2JKL1N9SypzilBs0YuyHrtw9biBSjxN36gSZG+LBYUL1thhEm+GvVT6A13N+ZzNSBwPtopA3vlgTvT0/IIsSVEAYwlaFxR8= Content-Type: multipart/signed; protocol="application/x-pkcs7-signature"; micalg=SHA1; boundary="----=_NextPart_000_008B_01D89A8D.08C84B00" MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: a786c582-69d6-4267-db28-08da68c5b352 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 13:59:15.2431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB0967 ------=_NextPart_000_008B_01D89A8D.08C84B00 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 10/18] x86: introduce the domain builder > > This commit introduces the domain builder configuration FDT parser along > with the domain builder core for domain creation. To enable domain builder > to be a cross architecture internal API, a new arch domain creation call is > introduced for use by the domain builder. > diff --git a/xen/common/domain-builder/core.c > +void __init builder_init(struct boot_info *info) { > + struct boot_domain *d = NULL; > + > + info->builder = &builder; > + > + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) > + { > + } > + > + /* > + * No FDT config support or an FDT wasn't present, do an initial > + * domain construction > + */ > + printk("Domain Builder: falling back to initial domain build\n"); > + info->builder->nr_doms = 1; > + d = &info->builder->domains[0]; > + > + d->mode = opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; > + > + d->kernel = &info->mods[0]; > + d->kernel->kind = BOOTMOD_KERNEL; > + > + d->permissions = BUILD_PERMISSION_CONTROL | > BUILD_PERMISSION_HARDWARE; > + d->functions = BUILD_FUNCTION_CONSOLE | > BUILD_FUNCTION_XENSTORE | > + BUILD_FUNCTION_INITIAL_DOM; > + > + d->kernel->arch->headroom = bzimage_headroom(bootstrap_map(d- > >kernel), > + d->kernel->size); > + bootstrap_map(NULL); > + > + if ( d->kernel->string.len ) > + d->kernel->string.kind = BOOTSTR_CMDLINE; } Forgive me if I'm incorrect, but I believe there is an issue with this fallback logic for the case where no FDT was provided. If dom0_mem is not supplied to the xen cmd line, then d->meminfo is never initialized. (See dom0_compute_nr_pages/dom0_build.c:335) This was giving me trouble because bd->meminfo.mem_max.nr_pages was left at 0, effectivity clamping dom0 to 0 pages of ram. I'm not sure what the best solution is but one (easy) possibility is just initializing meminfo to the dom0 defaults near the end of this function: d->meminfo.mem_size = dom0_size; d->meminfo.mem_min = dom0_min_size; d->meminfo.mem_max = dom0_max_size; Thanks, Jackson ------=_NextPart_000_008B_01D89A8D.08C84B00 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIRvjCCBQcw ggLvoAMCAQICCmFaT6EABAAAAlYwDQYJKoZIhvcNAQEFBQAwQzETMBEGCgmSJomT8ixkARkWA29y ZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExEzARBgNVBAMTCkRST0ctQVBQMDQwHhcNMTgxMjI4 MTcyMjQxWhcNMjMxMjI3MTcyMjQxWjBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZImiZPy LGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAw ggEKAoIBAQDIqSfSN9vCMUNv1ClFEtVbNDtXQG2uTUIF4sxljSpofE+0R18jypVQ5sbxYAY+YetA YaCu9sDvINgjn78bMWro7PjaXLTMKob682UX2hSlfV1u9JLIc/dHZDhQm/g+moZjbJrAaphVJ1tm zAngB5e9vpNGPtiYnxOHfyJHbXvDODHkXPQHjdhx/96DWEo2ME4o+hbrmKwSv36i9P/fZnx+7dfo EJ0Xka7ivxxAvSFYwV/lfygF37XMd6iVrQ7HBjt7PYG/Xda26prtnMTaZCj3Xfk17CJ5OD5bhG5/ Fr+BmOB7N0tMEgdOEw4J9ILZ13aZ+u8KHhl8qCRPc+ZCkYJlAgMBAAGjgf4wgfswEgYJKwYBBAGC NxUBBAUCAwcABzAjBgkrBgEEAYI3FQIEFgQUsiV9iBiIVa/fqUTl68n2xTOrX2MwHQYDVR0OBBYE FP7n8qkpqNSfs/rzfTADwqy1R1BlMBkGCSsGAQQBgjcUAgQMHgoAUwB1AGIAQwBBMAsGA1UdDwQE AwIBhjAPBgNVHRMBAf8EBTADAQH/MB8GA1UdIwQYMBaAFEkkMbfTP+jwH38Z85zodUalM249MEcG A1UdHwRAMD4wPKA6oDiGNmh0dHA6Ly9jcmwucml2ZXJzaWRlcmVzZWFyY2gub3JnL2NybC9EUk9H LUFQUDA0KDQpLmNybDANBgkqhkiG9w0BAQUFAAOCAgEALpNXZbpzZFwFsfCKiwjKg8ldws18ZS3m BX6jaYuQAdwneQTtf9gFpx3Pvhb+BSN+9yGGjyJ3EZKYcGzGYRaKBK4Vco2rDgHvHckQR4rxq8kd xJtfGPlEXwsRQRQLW3C38wrdyCjI5JZA/5u4/qZqY7DXnhjU9u/2bofQOT0iAtJ9pAnI47/vdlxG uzRBAZjqHU3OIeZkQDWUB0yuCgbKRiluFn+0wOsWKwB4d4/HeXOyLBt0qbS+cMZ79MBDuC76ykbd R1NEAUsMo69BKgqFQQ3nrUN7LGPpEqPiyheFsCWMqkd6vwsmCPwfL1tSBcfOgU0tMiSohi7mPvBk SI4ODJ97kWVPcS5WZAWmB50hrRCtp46bE1LbGhNihyf7mKn4d2zsGXmbzX0m+oza/nmR4GWGIlni DF/83XexzNYV7aNBp/1qW4gjuqzwD6f9+1+gPU3jCscHHdE2++0M9yrZiG6iYnH+T0rilJSu24CY vxavpQf9G1uD/mlcC0ypkeEqenUxv31WapzGnv3EVeU63FEEVQCcJr+VEW30opb3GTQoNAvm7zTs oCfC/dc9Uohc6wcukEHDBXA6bIjbBXVISsN9Pe9p06FafqVqfr2S5V/F5EwgbMyTFPQ+SIB6Pa+9 GlGMmOWyAEJphGBG+sK9fl8Jcub47w4YX7dCqY4p5vowggWfMIIDh6ADAgECAhASPGXcwnWGs05X Q6UPq8/lMA0GCSqGSIb3DQEBBQUAMEMxEzARBgoJkiaJk/IsZAEZFgNvcmcxFzAVBgoJkiaJk/Is ZAEZFgdycmktdXNhMRMwEQYDVQQDEwpEUk9HLUFQUDA0MB4XDTE0MDEwNjE1NDc0NFoXDTM5MDEw NjE1NTc0NFowQzETMBEGCgmSJomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2Ex EzARBgNVBAMTCkRST0ctQVBQMDQwggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQC80o0V oOdwWusFIsAU/r2pLJjOgnDJeR1gR0FzW4Yx541MohHpWg2T3dvELrWbw8I1bvrwszhkErdhGisO W4OhIaJSRSZCc7/4lP67uO3WqyH6Ih0lLFejnOWi5z3ifzKYj5fHIE5z0niLL+eg1NxokT9H2qC1 ENHNJ/jssmQZyyoktvKaPShw+I7yAqdwZWr7l9jCUKFgYBbqkPm0kEzZAagNHZ+HOp6LAvGEONL6 4k7a6jGcaz5LvBTVTlCYdws2DROK6deI9w8IkV0dQFL/c4jfQZ7OBbhkz4XMXgnTvnklKlgmzA40 l1lS4RlT29NufZvbyRziERP779HwczfIjpUPi1r70JgpyD42WyepcGoKXCicmBvI8mLaEPdfxEUC 60OnO8VFbU5oKw+T6j3ByuUTD6FEqQf4Q4SqyeDA9GZwRA2k5iwLwFqA0sCfcaUOi2aQkfT3OtTr JDWnzUIFRXFuenmSMpfTS4r1GW7u3DgAlWrNgKmx0WxdQpreAVt1lkCEb6NodTu4xiktEYtXfiVP i7LNfTbNS9gDS4wzOUGFc4GIthoWZXaYzSqu4e0h1tnvVPESwCz8+Ke2olwayeLGDK7h19HSE+EK 78XAlrcSuwoCQfrZfRHouSq7si9XRHdQJElFOzUy9N5QD5RL036eqSgc+l2PSBGuPVgD7QIDAQAB o4GOMIGLMBMGCSsGAQQBgjcUAgQGHgQAQwBBMAsGA1UdDwQEAwIBhjAPBgNVHRMBAf8EBTADAQH/ MB0GA1UdDgQWBBRJJDG30z/o8B9/GfOc6HVGpTNuPTAjBgkrBgEEAYI3FQIEFgQU2fLvmTrCwkM1 lhWUNB1HIO1BY9cwEgYJKwYBBAGCNxUBBAUCAwQABDANBgkqhkiG9w0BAQUFAAOCAgEAVHa8hXq9 mLpvsLYVR1Iqak2w3d71HKoEjRA67hkS5p1QSVySBnKBo4DqL2SVBnc5kt6J+3uH0hoFQF15CJwW SzMOCwX3BGA7UpkNgDqe/0sM/FZCVnGi1U56tRgMg/Ndxu26ytn13ptec0MZwGRzU46cNamtMLcW TxZyEe46ALnKxmv125IMDxEAXyo4p/9Y7xVK7SlzbF8NYUFZB/6lSjvG7BbNdZ4TQqoZ6ngXYcKO X/fFlb2Gzagbe3RoqFfNC4wRnFkO/wcr7stOB17bHXNN2EE7QZwSiR/oS3tVZ2hSTWTzfi+Mn8FI 9WeMZ/hhkK/vwu+9Leaua6WGVdJUPSJFZK47SGOdekEZ8ipJ5X5pwSO2unOM1V4pVty28Jq9KgF5 aBYiCS/2FOHvAgolQ3PuUIZOxZ87jSd4cTEpF5rUfVLd/Wb7C/i4G15cnolsNuABl+Mgkdr9xHAs 0c3bljbfN6HdYZNHTZQ8kUL6z39UX9b0VFVXoCw+fnQOD+uaNca3lfvQENKOnNpzLSvVuwyOg9LL U2qdp74brdgXidWL56iwlBj5g/7Rt1glmNCbIusxtEHDr3RWaXvmOZt86lwT1pNy6e4iKaj5opiM y5hBglp6x595DCG05IgGyQRzP9bNyqPglQMRekuqNtiM8s/BZZ0LiVtMDkna9k9jj28wggcMMIIF 9KADAgECAhMsAARwT/LbBVtfmneXAAcABHBPMA0GCSqGSIb3DQEBCwUAMEExEzARBgoJkiaJk/Is ZAEZFgNvcmcxFzAVBgoJkiaJk/IsZAEZFgdycmktdXNhMREwDwYDVQQDEwhCUk8tRFMwMjAeFw0y MjA1MTYxNDI0MjJaFw0yMzEyMjcxNzIyNDFaMIGpMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYK CZImiZPyLGQBGRYHcnJpLXVzYTEMMAoGA1UECxMDRFJDMQ4wDAYDVQQLEwVVc2VyczEWMBQGA1UE CxMNT24tU2l0ZSBVc2VyczEWMBQGA1UEAxMNU21pdGgsIFJvYmVydDErMCkGCSqGSIb3DQEJARYc cnNtaXRoQFJpdmVyc2lkZVJlc2VhcmNoLm9yZzCBnzANBgkqhkiG9w0BAQEFAAOBjQAwgYkCgYEA rvdaVkLmf4emLjFcvM2ukIkTQjkEoz/feXDWuJH/9BWDUowo71IysLADaoIXy0EFNblUbZZM4pR3 29XLxbsYAQKYMLDqxbudadKICnnme7PxLZ8bnT3HhNCvK4ieUxuQz0Uied92gUg/HXrSf06oCKbw smY8uvOq1BOQ6V7sr2ECAwEAAaOCBBYwggQSMD4GCSsGAQQBgjcVBwQxMC8GJysGAQQBgjcVCIWb hmWDndEtgsWVEIGmmyuDmZlRgSWH0qVDgrHkJgIBZQIBBTA1BgNVHSUELjAsBgorBgEEAYI3FAIC BggrBgEFBQcDAgYIKwYBBQUHAwQGCisGAQQBgjcKAwQwCwYDVR0PBAQDAgWgMEMGCSsGAQQBgjcV CgQ2MDQwDAYKKwYBBAGCNxQCAjAKBggrBgEFBQcDAjAKBggrBgEFBQcDBDAMBgorBgEEAYI3CgME MEQGCSqGSIb3DQEJDwQ3MDUwDgYIKoZIhvcNAwICAgCAMA4GCCqGSIb3DQMEAgIAgDAHBgUrDgMC BzAKBggqhkiG9w0DBzAdBgNVHQ4EFgQUx9iDBJcqSRZJGZfYm0qPYN5BFcMwHwYDVR0jBBgwFoAU /ufyqSmo1J+z+vN9MAPCrLVHUGUwggEABgNVHR8EgfgwgfUwgfKgge+ggeyGgbNsZGFwOi8vL0NO PUJSTy1EUzAyKDcpLENOPUJSTy1DQTAxLENOPUNEUCxDTj1QdWJsaWMlMjBLZXklMjBTZXJ2aWNl cyxDTj1TZXJ2aWNlcyxDTj1Db25maWd1cmF0aW9uLERDPXJyaS11c2EsREM9b3JnP2NlcnRpZmlj YXRlUmV2b2NhdGlvbkxpc3Q/YmFzZT9vYmplY3RDbGFzcz1jUkxEaXN0cmlidXRpb25Qb2ludIY0 aHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJjaC5vcmcvY3JsL0JSTy1EUzAyKDcpLmNybDCCARMG CCsGAQUFBwEBBIIBBTCCAQEwgacGCCsGAQUFBzAChoGabGRhcDovLy9DTj1CUk8tRFMwMixDTj1B SUEsQ049UHVibGljJTIwS2V5JTIwU2VydmljZXMsQ049U2VydmljZXMsQ049Q29uZmlndXJhdGlv bixEQz1ycmktdXNhLERDPW9yZz9jQUNlcnRpZmljYXRlP2Jhc2U/b2JqZWN0Q2xhc3M9Y2VydGlm aWNhdGlvbkF1dGhvcml0eTBVBggrBgEFBQcwAoZJaHR0cDovL2NybC5yaXZlcnNpZGVyZXNlYXJj aC5vcmcvY3JsL0JSTy1DQTAxLnJyaS11c2Eub3JnX0JSTy1EUzAyKDcpLmNydDBVBgNVHREETjBM oCwGCisGAQQBgjcUAgOgHgwccnNtaXRoQHJpdmVyc2lkZXJlc2VhcmNoLm9yZ4EccnNtaXRoQFJp dmVyc2lkZVJlc2VhcmNoLm9yZzBPBgkrBgEEAYI3GQIEQjBAoD4GCisGAQQBgjcZAgGgMAQuUy0x LTUtMjEtMzE1MzczODEzMi0zNDMzOTAxMTAzLTQxMTc4ODYyMi00MDQ1NTANBgkqhkiG9w0BAQsF AAOCAQEAYaBBvBGuhKlhJ2O6JBtcYRW7CYREO4+CAep40ordLIS0gvnKuE7A3a+4YzJpqKvfSbQd +dQzeaZNz3kTpwJlZh5fJb/Bo7zQWlvDU1p/rr7a2tAnWNqSVlgQrvAk35TLqlGAmwo8tgQ1jxc/ JAkWg5Pqks6IKyO8CwKuIEOqL7vxN/THcEvpJvLnhRxm/ARosCDW1x0XTwivA8tS1AVvxxcpQAXS uo/q3WNG/XDC8oO6oJLZfnpl9LiDBrsHEzDaR3Ct3XCR6rJ4ezjwFjH4SEOWCWeWsLhk+uoOgAx5 4cKlGpprXf5oje+0nSz1bAw5kaGD8k83rXL75YVcIuRTlDGCAskwggLFAgEBMFgwQTETMBEGCgmS JomT8ixkARkWA29yZzEXMBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAy AhMsAARwT/LbBVtfmneXAAcABHBPMAkGBSsOAwIaBQCgggHHMBgGCSqGSIb3DQEJAzELBgkqhkiG 9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTIyMDcxODEzNTkxM1owIwYJKoZIhvcNAQkEMRYEFLWsnCm3 EbADPL53CMXmWqn4IxdoMGcGCSsGAQQBgjcQBDFaMFgwQTETMBEGCgmSJomT8ixkARkWA29yZzEX MBUGCgmSJomT8ixkARkWB3JyaS11c2ExETAPBgNVBAMTCEJSTy1EUzAyAhMsAARwT/LbBVtfmneX AAcABHBPMGkGCyqGSIb3DQEJEAILMVqgWDBBMRMwEQYKCZImiZPyLGQBGRYDb3JnMRcwFQYKCZIm iZPyLGQBGRYHcnJpLXVzYTERMA8GA1UEAxMIQlJPLURTMDICEywABHBP8tsFW1+ad5cABwAEcE8w gZMGCSqGSIb3DQEJDzGBhTCBgjALBglghkgBZQMEASowCwYJYIZIAWUDBAEWMAoGCCqGSIb3DQMH MAsGCWCGSAFlAwQBAjAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAhowCwYJ YIZIAWUDBAIDMAsGCWCGSAFlAwQCAjALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEgYBhPc1M K95w1rwxwNgXs+3NGLIr5y/sEFqisqxkicSUSJd51uNPt0qlwDq69seIBjLhZAmoTXZLeam0V81Y b+LCh6PHOQzE8MH+wcPLSCb3TLP7kyX51EbIWZ7kjmGe9i7aRGHvmCg6CJLKr5p03lXXiufp14iP ywhn3TSYZPbkxwAAAAAAAA== ------=_NextPart_000_008B_01D89A8D.08C84B00-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 13:59:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 13:59:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369821.601357 (Exim 4.92) (envelope-from ) id 1oDRHn-0004Du-Dh; Mon, 18 Jul 2022 13:59:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369821.601357; Mon, 18 Jul 2022 13:59:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRHn-0004Dn-8u; Mon, 18 Jul 2022 13:59:47 +0000 Received: by outflank-mailman (input) for mailman id 369821; Mon, 18 Jul 2022 13:59:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRHm-0002Wp-63 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 13:59:46 +0000 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id df35679c-06a1-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 15:59:43 +0200 (CEST) Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IDZKkd028403; Mon, 18 Jul 2022 13:59:25 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hbkx0ue67-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Jul 2022 13:59:25 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26IC9WAi004030; Mon, 18 Jul 2022 13:59:24 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hc1k3ump5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Jul 2022 13:59:24 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by MWHPR10MB1870.namprd10.prod.outlook.com (2603:10b6:300:10a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Mon, 18 Jul 2022 13:59:22 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 13:59:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: df35679c-06a1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=Zden/FfAFlA7VwHfl5uNLpSbJmIbDIrWCPOjDyL5dBY=; b=VlIwYjRO6HW5jjwav8ISlcydJaKYXaMgYsrxnzbSJpMoKlrp3TtSruJFNPKLDNXneyn4 mRly5IT4oJx/mPwpzEwNvYOKR8y30ail8l87NQfst3ROfsBftvFeVRqowRXBmgsbWygu 67yHZeYoZ2/xxI179dTi/O42FL3omRoS9L67Z6ElsWkl3O94bgLu60QcSeaHBR3p3pSv ynI6hEt5PSDHptGK7oLfcjY10Rx+KIY4YQr0rVbEXMl0To3Fs4BWFmjYLA87vQs8xu/B sCqSBSK1k2oJovomPj6CJAtjLcpKUFO6f/D+PgMG7ARbxOztArrYaR1T0NM9YnDykBa9 sw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ns11Sq/7gOMCZMr+TgXaQiIXGYdEi2Cx4h5o4q4P2Vv5plqCguAvre2x0g+pVVmU/1XJtJRWTvon48Oq41Yf+dIoqODzyC72QdA43kynP5scehbHYczKjeWq9yFKjlb7j+Z4EVFp++7onk+KBSVZeymgxRdh0vQ1t2LBdGwRuhVILldNgWgzI+mEZJcZ9FO1zGNSwvXJcSzStyizfp1o72RPg6g9sdXM5ig0nF7yk/Ans/D6SszzqY9XTEm0+gca3W1XAa9ieKFkLIq8h4liCam3U5vCoEuFWsnxegMkD4gUPuoMbHoZdCPROk73ZOjpa90rKQNG6PKCEeDjOrIuow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Zden/FfAFlA7VwHfl5uNLpSbJmIbDIrWCPOjDyL5dBY=; b=NK96SJc7mTwcGtoP47V+2tnWNxRo6RBio40uG+X56NoyGOql6+dm4+dGZufwWwgctqF4ChAk6f5nbHAlE3YUP8d3m5BE+puUl8DFGHOPAzqTI+6ig8/Y+OWwiTh2b/zj3Wub9zHi58inbQarOjxD0dnMvRcxmiyuzQfYFLhqzG1Fc0Ci/aiE/MnV5SNvsbOJMhmgSwDIF+YgHnTylkNjTIaCdPThZJD6cktVtNpzTFfQqE9Rn2KbGRbLE8DAoLZjcG4BhQNptMIr45lDL/Nj0ZKABFkap61Xaq+MOwvMgzFHBGZYyg9Qk51+Wuw5ZYSFmp+swEza6hNLd49n71DRAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Zden/FfAFlA7VwHfl5uNLpSbJmIbDIrWCPOjDyL5dBY=; b=FPht56eWeUbJOO+DtWeUInG6woa9qOitlnrOlmYmtAnw4HRSIm5fTd1N+tuulipZNn2nVX/whgM85sXTiMgQyvw1WV/LA4kbkJ+qVNIwNM53iJHr3wz34P2/qDNCd44v9tb1pOeL0IyKA5lSRv7r5O46ewSx1iNTCq5MVpjCHh4= Message-ID: <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> Date: Mon, 18 Jul 2022 09:59:15 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Andrew Cooper , Jane Malalane , LKML Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN6PR04CA0077.namprd04.prod.outlook.com (2603:10b6:805:f2::18) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c3a09814-81bb-4e28-0b3b-08da68c5b72a X-MS-TrafficTypeDiagnostic: MWHPR10MB1870:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wN5IHgnhlp8M4p1iImqVIQfzB7hWLmFoCbEeYZsYEMEmh51adR12IcV2vU8XLSPK5NkzzkVIQpqMKJyXQiylNncLaP2jWggxoFBE43lHCOfHt1x6GtCSwNdYx1GIYlYjNIlAMX/ODEjCWifaUiBSyyPNwrbs7DutUF2KyOoOBNuWTJXnyRtenx13patCLgNCs9d01/K5jw476T+x/efM7XUYWWg7A4JA3gn3rC9ToszUo99Yb6aOwjO3HWC6KSFY7eZbsc3E1jpE3Kj49wfMqfdVbnK/MYyOyu0ofubb5JQ65XDmvVJZ++Dj8qmDiMRtfqKmjYebDEIoGRICcoor3350TUDRDkaBx6NsRNLX10T6yFWrWvMX81juykurxmRdHPxECPoSiSqpja/vOavO+KWGCV3pTB9aRneeynH2zMlzlQNl4H6Ius+LJCzV5kHNXXsgzD2n/ETiRlPi4XQMA32DQ1e+mEElbFGKW1Ysj7RYL6eTLKkks28bPpHtyu2KBRU3Xm7i4x8G6WxpBRAwQtUyZ9z0+SzRpjQo1Jff2Fbh0dFHgCzoIBCML4fRib4sMaKXFuI3KiuoKRk57z5s14sJd9jP0pLUNjS/Hz0qRfL8WFDTC2bBq4I9UpRHJHPP9k0XXi0NAUKZWuTitRNGz+KFnYIvhbVEIT0zk1EuRR74UBqiYabF0EOcROMj78K5gz4hbekgoETgEJrubVYcNBgmmFPrJdN82SJWUBDoIwAC+vflP0cTd5HRPpaLEMvyUPmZnL4QiL1TQdt6pH+FJyh9A99rRz4n6Xa26CpAGiE6XyOg36fxSuhU5i6cvJaCVygolBl6SKeyDzKkbIK0PESWY2Fd9kxbnf8yh3h5+NU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(346002)(376002)(39860400002)(26005)(186003)(54906003)(110136005)(6512007)(2616005)(36756003)(66476007)(31686004)(478600001)(6486002)(2906002)(41300700001)(38100700002)(86362001)(316002)(8936002)(6506007)(83380400001)(53546011)(7416002)(5660300002)(44832011)(31696002)(6666004)(66556008)(4326008)(66946007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZndlYnNWei92U2Fyd1pNeitHUDUzNTAxQUhuZmVXNEpIdkJxcmwvemJnSmlM?= =?utf-8?B?eFg5dnU0RHByQnB1ZFI3TXBua0tXem1sL0RaTlBJVTNqeGVwMmJtb3g1QW5J?= =?utf-8?B?aFZZVGJEVWJmSnlvbmF4V3RrMkttUVZZVmpGQlkxVFY3cjMzWUZGWmtlb1Rm?= =?utf-8?B?MG1jdHYwV3FDSjE5dG1kbGFYL3J6QndlRlRZZE5QanlJT0t2YWJndDBFcXFu?= =?utf-8?B?UHVnMENTb2RCb3Y3ZUhza2xBbE16ZjB0eXVMUFF1SHZGVlQ1dFBkNUZnaW1T?= =?utf-8?B?QlNsZE85Z0dpVXZNVE9NRVNQbnhiS3FsRGN2akJWZnpLbExzNVFhVEYwWHBS?= =?utf-8?B?ZGtEdVhzTnRISG50dHZYL2RQMFdhNzRYNGJ0QzZDUnk4aEZ4WHJnd0lkYTJM?= =?utf-8?B?MnVZemQ5TkprRmI0N1ZGa21MM0JtQ3JkaHI2eWxRTWVic3FDV2hONDlDQmFD?= =?utf-8?B?NUgvQkF5OHp6Umw0Nngwb0hBUG5wcFlJUHpBUjFxRXRjZGhXYlBlS0lROHVx?= =?utf-8?B?YTdtc0lsSmZtNDhwVC81VVN3VFZMb0lYSkJISnM4eXMvV2pNRnoxZStIQnNz?= =?utf-8?B?MUlYZkE2T01TNzVZSW5oa3ErSmxFaXpVcXZUSWtReElCakxxMVZQSmxvbldo?= =?utf-8?B?cWpvVkRJQjQ1OVREdWFDUnJhNEg1R2JYSFZMcS9CS0JzaWF1Tk9vSG83RDlk?= =?utf-8?B?Z1BmQVFHa1hLTjJYNVI3OWxuUEU1MDJBNGRkOFBTTERhZHRYMUtEM0FlamZy?= =?utf-8?B?dEl4cXFzVVUwOXBLL1hEQm83c0tWeHdOWWFsSWRWeVh1WnJLWlJDdUFpYWtT?= =?utf-8?B?Yit4aS9Hb09yYjdINWNEbVNVNmRWckd6UXpoZ0ZzRjYvL255NUR6MFFvSFI4?= =?utf-8?B?T3o3UGRxcHd2RFgvaG1rMktPYXAxZFgrVE1HaTRtMHFzQUhFazMxazBpRjZF?= =?utf-8?B?WXBxUmI1R2ZMOW5pa0YrM0VEa0JNZllSemxwOFNCd0I4SkNNQlVzdmJUOEMr?= =?utf-8?B?OE4vSC9Vd0hHWnN6NzVSN3ovQVZ2Zm9PeGxacGFMWGl6SXBoOHU5Q1VWT3lW?= =?utf-8?B?MG1zSkJoUlFpYjRFS0xFYStDK3pucWRTTmhaelYwV01qdmFLL2N5YlZ2NUp5?= =?utf-8?B?aDJxczY0V1RkTkNZRFNuQVVlTE5IU2E1LzJaMTFVNzZZbnRRY2dWbno3TUhz?= =?utf-8?B?Z3NOZm1vb0o2QWZoWi9IMkRMRFJWcDVZRTM0ektOU1g5bDI2SjMyRjA3czh3?= =?utf-8?B?NVFjbzhwMnVaSnRnMGtWOGVFckY1SXRIUDhVaGNjanNnZlcreHBrYzFFZTZv?= =?utf-8?B?akg4Uy85dEwwUlBScnFoMHJMQ2IwcFJ5WE5EZ0ZmMEtyL3JNY25PNElqVmVB?= =?utf-8?B?cU5BYXpuT3p2NmQxd053a205bElreTNINy9senBXdytYekNPZFhyMEZDKzBC?= =?utf-8?B?ZDFhWWttYlE2U1RLWCtpK0MzVlFzcEpjK2xtdmxZQUVzbnlkTlJzVURQc0Zu?= =?utf-8?B?c1M5VGRpRWt2eU5EL2lWQlhGNmhva2hYMkw0aGdpd3ZZUEppRmlLTzluOXZ2?= =?utf-8?B?Njd2RmFRMnRQRkRNbVdhbThsdUx6SkVEamtPOEg0VjQzdmc1SUpNanB4RW5U?= =?utf-8?B?T2NBazh4N2paTDl0bU5BdnBOcE1kay9qZC9EY0xCR1htNEtXVGFkdzFwNFdu?= =?utf-8?B?bFIzN01FbzQyZmdlVGhKOHJEVnlTOTJBd3lTWnRqUENBUG5QRzVVWmg0R1cx?= =?utf-8?B?NkdiakJVNzYwS3k1T1hrLzBvQWhBZ0ZnVzE4d2RlQllxVmZDNGIrRjFSTWNE?= =?utf-8?B?L3hCaUl1ZW5NbkR3N0tXS2tBVUs3SjZGZ28yaGZyanA4cS85aEtVRXVjd3FR?= =?utf-8?B?MWZLK3FLQ0tweXUvTkwyQ0lkVVBHcDVzcG4xb3BHSnAxK21HdkZTWGFWb2ln?= =?utf-8?B?Q3I1OGl5RVNXcjlVVFl5OGJQWUt0L3MrcC92V25XVVUzZEVSUDFWNG43WXJD?= =?utf-8?B?YmZOc2pkaFROU3BkcXFBSDZGTWEyL3BxY3d3ZkVNYWpmY1VndkVlNkE3ZERw?= =?utf-8?B?UFVCZlp3S1VnQndlRUE1WXV5dUQ0aUZPd0RLTHFxS1pYcjFkTnBKbnI4Z0dY?= =?utf-8?B?dVJFNWxxT2pIaEZlRm9INlEzODRqUlo3QlEyREMvOU41a0JiUVFnaEt1VmlJ?= =?utf-8?B?bEE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c3a09814-81bb-4e28-0b3b-08da68c5b72a X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 13:59:21.9990 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMnXgP8734lLmZuLl56Yc7mZJ2n8T1SDFvx5pODsaHy6k4/fFQn6bbuyOqGWOShAAyGURRrlmxjWTFmr49/wZCYhZ3gpoWGK0+B5k6kOsow= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR10MB1870 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_13,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180061 X-Proofpoint-GUID: Vd43k06TR7kQN9IXsX-p8kkE8x_saDG1 X-Proofpoint-ORIG-GUID: Vd43k06TR7kQN9IXsX-p8kkE8x_saDG1 On 7/18/22 4:56 AM, Andrew Cooper wrote: > On 15/07/2022 14:10, Boris Ostrovsky wrote: >> On 7/15/22 5:50 AM, Andrew Cooper wrote: >>> On 15/07/2022 09:18, Jane Malalane wrote: >>>> On 14/07/2022 00:27, Boris Ostrovsky wrote: >>>>>>        xen_hvm_smp_init(); >>>>>>        WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, >>>>>> xen_cpu_dead_hvm)); >>>>>> diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c >>>>>> index 9d548b0c772f..be66e027ef28 100644 >>>>>> --- a/arch/x86/xen/suspend_hvm.c >>>>>> +++ b/arch/x86/xen/suspend_hvm.c >>>>>> @@ -5,6 +5,7 @@ >>>>>>    #include >>>>>>    #include >>>>>>    #include >>>>>> +#include >>>>>>    #include "xen-ops.h" >>>>>> @@ -14,6 +15,23 @@ void xen_hvm_post_suspend(int suspend_cancelled) >>>>>>            xen_hvm_init_shared_info(); >>>>>>            xen_vcpu_restore(); >>>>>>        } >>>>>> -    xen_setup_callback_vector(); >>>>>> +    if (xen_ack_upcall) { >>>>>> +        unsigned int cpu; >>>>>> + >>>>>> +        for_each_online_cpu(cpu) { >>>>>> +            xen_hvm_evtchn_upcall_vector_t op = { >>>>>> +                    .vector = HYPERVISOR_CALLBACK_VECTOR, >>>>>> +                    .vcpu = per_cpu(xen_vcpu_id, cpu), >>>>>> +            }; >>>>>> + >>>>>> +            BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, >>>>>> +                         &op)); >>>>>> +            /* Trick toolstack to think we are enlightened. */ >>>>>> +            if (!cpu) >>>>>> +                BUG_ON(xen_set_callback_via(1)); >>>>> What are you trying to make the toolstack aware of? That we have *a* >>>>> callback (either global or percpu)? >>>> Yes, specifically for the check in libxl__domain_pvcontrol_available. >>> And others. >>> >>> This is all a giant bodge, but basically a lot of tooling uses the >>> non-zero-ness of the CALLBACK_VIA param to determine whether the VM has >>> Xen-aware drivers loaded or not. >>> >>> The value 1 is a CALLBACK_VIA value which encodes GSI 1, and the only >>> reason this doesn't explode everywhere is because the >>> evtchn_upcall_vector registration takes priority over GSI delivery. >>> >>> This is decades of tech debt piled on top of tech debt. >> >> Feels like it (setting the callback parameter) is something that the >> hypervisor should do --- no need to expose guests to this. > Sensible or not, it is the ABI. > > Linux still needs to work (nicely) with older Xen's in the world, and we > can't just retrofit a change in the hypervisor which says "btw, this ABI > we've just changed now has a side effect of modifying a field that you > also logically own". The hypercall has been around for a while so I understand ABI concerns there but XEN_HVM_CPUID_UPCALL_VECTOR was introduced only a month ago. Why not tie presence of this bit to no longer having to explicitly set the callback field? -boris From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:05:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:05:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369834.601368 (Exim 4.92) (envelope-from ) id 1oDRNN-0005zk-5C; Mon, 18 Jul 2022 14:05:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369834.601368; Mon, 18 Jul 2022 14:05:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRNN-0005zd-2K; Mon, 18 Jul 2022 14:05:33 +0000 Received: by outflank-mailman (input) for mailman id 369834; Mon, 18 Jul 2022 14:05:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRNL-0005zX-Ma for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:05:31 +0000 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [2607:f8b0:4864:20::834]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae746b73-06a2-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 16:05:30 +0200 (CEST) Received: by mail-qt1-x834.google.com with SMTP id x11so3090634qts.13 for ; Mon, 18 Jul 2022 07:05:30 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:aca3:a6c1:f806:b8ba]) by smtp.gmail.com with ESMTPSA id dt18-20020a05620a479200b006b5cb0c512asm10480339qkb.101.2022.07.18.07.05.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Jul 2022 07:05:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae746b73-06a2-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3uIetIDCX/BBS2dAp1PK0jCfKYau2HdeGwq2NiKk4mQ=; b=WEQfEitbA1anWI3hfbQYvtrzWIlGKUQBXV0Y6pJcdoOY9C5p7gKoS5D9BBoqC6jwxG 2rCZw5QW2Gx3s70dnFOeWN7tTFkWZKm30PU4cddEfarutZCrW+zBm87jSAQqNsWgt9Lv G8coarjuw9/35b64vf1tzLeCDIfjYKZUDOgQT+58mBQ5wY7Y2vdkm06A9Q5Wv7NhlFWy alW8F2AsjoxI3BHT9SCiKk4N7ixbJZqllisShLD+cihTMSo1kZUm8wdcfnZYsb8RL1Jg 0Z2OjL4PHt0c7XA2d5qz7h+kXfpBtDBqBr1Kx9aCva6gF/TFcZ9d4O1mUVTUK+4ehXh1 4V4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=3uIetIDCX/BBS2dAp1PK0jCfKYau2HdeGwq2NiKk4mQ=; b=AhUhfzsjXUNuQZQUKbljVwwh8Ecv/QAjSQVpMI+3Liv7ai3A6csgxrOLQP/sdC1mAq NKicGtgCbjpMKMsjeM0B9Iall6au046B+X3qo1fkNgdiTwwVHddkZNg+H5IIGzscjQyf oIAH4PKVjDxVvUM+n5bJ/+Bfw3x7Qqq93uzkd8ZDSoOPHLDxP47AKmRaFpByL2ESQVvN 5kMSm8A6nQrFAH1Hcvdom98cu4Ik3Twu6sCAC/UAtwlEJbnj1dEyOEbKWLru0MIvpY9Q incQvNqV/ybOodMEIWpukr/H0GiZ89+QKdZekoykYbKWQHdJDTqngN42DaA22Jwmkyca E+eg== X-Gm-Message-State: AJIora+4e441R2VLMK9qSBCVDlr4ouYdTdbqQCUUFWwPymH4pQ0BF+0/ HHx1f6po8UczuGSrcyFPkk/iYFxdAPE= X-Google-Smtp-Source: AGRyM1u4mUvJYIHgt7FNp6tDVtuY3ag17Hjd/OCGL3gozOGmaxWXZ6jS0OR73YV83yDLC5tkKKS8bw== X-Received: by 2002:a05:622a:d5:b0:31e:eb65:e832 with SMTP id p21-20020a05622a00d500b0031eeb65e832mr5291264qtw.92.1658153129303; Mon, 18 Jul 2022 07:05:29 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86: Add MMIO Stale Data arch_caps to hardware domain Date: Mon, 18 Jul 2022 10:05:17 -0400 Message-Id: <20220718140517.14771-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Let the hardware domain know about the hardware it is running on. This allows a linux Dom0 to know that it has the appropriate microcode via FB_CLEAR. /sys/devices/system/cpu/vulnerabilities/mmio_stale_data changes from: "Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown" to: "Mitigation: Clear CPU buffers; SMT Host state unknown" Signed-off-by: Jason Andryuk --- Should calculate_host_policy()'s arch_caps mask also be updated? They are not identical today, but I'm don't know this code to understand why they differ. xen/arch/x86/msr.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index c2c0025e3a..f1c36d423f 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -163,7 +163,9 @@ int init_domain_msr_policy(struct domain *d) mp->arch_caps.raw = val & (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | - ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_TAA_NO); + ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_TAA_NO | + ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | ARCH_CAPS_PSDP_NO | + ARCH_CAPS_FB_CLEAR); } d->arch.msr = mp; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:06:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:06:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369839.601379 (Exim 4.92) (envelope-from ) id 1oDROh-0006eS-FY; Mon, 18 Jul 2022 14:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369839.601379; Mon, 18 Jul 2022 14:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDROh-0006eL-Cr; Mon, 18 Jul 2022 14:06:55 +0000 Received: by outflank-mailman (input) for mailman id 369839; Mon, 18 Jul 2022 14:06:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDROf-0006e6-FL for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:06:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDROf-0008DC-3q; Mon, 18 Jul 2022 14:06:53 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDROe-0003pW-UF; Mon, 18 Jul 2022 14:06:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=xmahiAjJq7OYe90xJYuKF3N/m/MMwNbtWIdoIRVkUnw=; b=i+qr1YfpFFudD5omd/y0PoKGbe PdeVEfyCD0lp8LlvVl9vSmskqYyNpzwZ8PF3aKcLMqPyoh/XGN5OG3mZ46H98Jh9Vk/P+JugoPGHz 7CP8OnxoH96PM6fI0Lhkw8/o89lBuedD7l9m9rZXZkVNulFB8kjyvTIZAhYmLN5/Nn00=; Message-ID: <8c4fd536-e581-b7d5-51b7-e9a65602e6da@xen.org> Date: Mon, 18 Jul 2022 15:06:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 4/7] xen/arm: mm: Add more ASSERT() in {destroy, modify}_xen_mappings() To: Jan Beulich Cc: Xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <20220624091146.35716-1-julien@xen.org> <20220624091146.35716-5-julien@xen.org> <5CD19BFD-62C6-4409-A5A9-675D8F5FF795@arm.com> <8c6a788c-ccb9-fc5c-fdf6-870540eed722@xen.org> <48d5cdc0-3937-a5f5-5c0e-a0eee90342f3@suse.com> From: Julien Grall In-Reply-To: <48d5cdc0-3937-a5f5-5c0e-a0eee90342f3@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 18/07/2022 09:47, Jan Beulich wrote: > On 16.07.2022 16:38, Julien Grall wrote: >> On 04/07/2022 13:35, Bertrand Marquis wrote: >>>> On 24 Jun 2022, at 10:11, Julien Grall wrote: >>>> >>>> From: Julien Grall >>>> >>>> Both destroy_xen_mappings() and modify_xen_mappings() will take in >>>> parameter a range [start, end[. Both end should be page aligned. >>>> >>>> Add extra ASSERT() to ensure start and end are page aligned. Take the >>>> opportunity to rename 'v' to 's' to be consistent with the other helper. >>>> >>>> Signed-off-by: Julien Grall >>> >>> With the prototype updated in mm.h as suggested by Michal: >> >> Done. I will send a new version shortly. > > I notice you had applied and then reverted this, with the revert saying > an x86 ack was missing. I don't see any need for an x86 ack here though, > so I'm puzzled ... Sorry, I am not sure why I thought this needed an x86 ack. I will (re-)commit it shortly. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:06:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:06:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369840.601390 (Exim 4.92) (envelope-from ) id 1oDROl-0006vc-Ms; Mon, 18 Jul 2022 14:06:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369840.601390; Mon, 18 Jul 2022 14:06:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDROl-0006vT-Jy; Mon, 18 Jul 2022 14:06:59 +0000 Received: by outflank-mailman (input) for mailman id 369840; Mon, 18 Jul 2022 14:06:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDROk-0006uv-Sb for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:06:59 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70077.outbound.protection.outlook.com [40.107.7.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e27c47af-06a2-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 16:06:57 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DB6PR0401MB2326.eurprd04.prod.outlook.com (2603:10a6:4:47::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 14:06:55 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 14:06:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e27c47af-06a2-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RAYwTbiMHJt4DV48YYr0VPYbreGvT1dh1HfzyDUCUSBhmUlIhcFkyxzROzR0FMvRHxJhFgd/nrHaDRti+FV+sxvvLFP8EiT794L8ML5/4Rrk2TzSUavWmocrx0bhNE8KbwQ9rMWU42exGSMmXtGT2lJZc6mUQLy971nheiKmFgEBNKvcRkGh/0vorc1P4dpfUggKHcZlcFFdLyqsZbTO4iCFnMKP2SkvAQMuVch6OOek6QeJ6RcIPY+hyHn1h35mCKO15V+XN6d5sZ+7LUfq/bkV8ZuntdT5XAKfASKxljN8r1U1Fqa6UnjuyV8qJo2csTDCrQPB2kTDcwLEsQHzmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nvAbQAL036ySrfE+yIl7Bh0rtBusa2gvaDdFAA2XEBc=; b=JUPyUiOhSQRJ3bTX3Vgy6nppNQY08b0yJUBBteTQcM92gZ342weznjscJPT/n8U61hDQ56hb4LLSA/YPgFuiD6pobhSp4iXaUsyLZBMYVxNK9fw2/usK8ZjFTolFh9idX20e/XV8wy5GX7Ch06LKXDP33sJtnuC54V5YFI43mE6KNfbMY2WPvicyDmS+HeUoeHdnNJKFQR2kuO9fjyZy5KX5mZApl3SOw6GgN3uRGPmiQBEFJqCa5tWVkWMrxXE0/Z6vjfD11OKjeE04FUb+Qfa+xyCLVZN4t7VvkxUNn/6ksRgkFNk2mS78MZzWYnGYdrExGIUsferFlrrLbdx/nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nvAbQAL036ySrfE+yIl7Bh0rtBusa2gvaDdFAA2XEBc=; b=KlMSr8f/k6xba0W0zaZld9XDWB0X5uiHj5O3wXxOOjAEVTqQniJ6mm4xEdor2DieYNHb5Yoa9RLO/Okz0NXaix1rykcoziNfmgjnOsQixlf6/wcLtkVGOEDSy5DYz4LN+vAiymas7FQO9wp4T0u6Y5fP2h/1vvfxg2K0y1iTMWwYpLagMgPjbOFeEPgM0kduCQ/7DpbhhHh4WcfmEmEobtyR9SpI+6FxJWZMlOKFwCIXbl5rD62oeEkiyA56DTZxcOnTJUFhYzWSR+PwqTaVmMAhmreqADAQwyBGlkXZ8RykEzVxwyZi9u6IYftuTkbX2XHuNz5uY7LtnyNnZlgPwg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <62fca8cd-1434-10ae-ae89-41b9ba3b8cdf@suse.com> Date: Mon, 18 Jul 2022 16:06:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] xen: Fix latent check-endbr.sh bug with 32bit build environments Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , Anthony Perard , Luca Fancellu , Mathieu Tarral , Bertrand Marquis , Xen-devel References: <20220715132651.1093-1-andrew.cooper3@citrix.com> <20220715132651.1093-3-andrew.cooper3@citrix.com> <465e44a0-2005-99bc-3fca-241b8c510df5@suse.com> <18a3e8ec-4a64-7401-cbaa-98b00355914a@citrix.com> From: Jan Beulich In-Reply-To: <18a3e8ec-4a64-7401-cbaa-98b00355914a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6P194CA0009.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::22) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d15aa0f-fb48-4f3b-9594-08da68c6c56a X-MS-TrafficTypeDiagnostic: DB6PR0401MB2326:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mje0f82D39TrdoX1V7GyEN70M/EEzrikAHZY0dFY1ZGH0ND5J63CYuiH+2WYD7ZSvj247i8D8LQthUZCHGOdwCz7IZVvnOQpedawAAAmwPubIkCICxHEY6svg9r1jmn0pnFiA5OqeYnvmfC/5zQkbV1rSe2qpLProbpL6oIM+MZ/Zoovx/cfTIcQN/cLLedSSCZffuiK4fQc8xUp6EQ/+gYfyqNXlVDyEIqojWoXWfCvAr/DplPqnW+38Mz3sAxN+sb0qQNqvkEPRMChsQuJ8mphKyCqIiDwTF7h62KKvZ4fvYVoZwqlSQ4Y3+ilk2mOnwF38uxU7G5/q1Eoohsd+XdfzRRnMJcWuuGZbWIFnuiLHI8PgmG09NazIHxz/X3sHNuamQKrXonp6H6fyi3J01Vlr5H53KwbCNVqptAnF9hH3f3gxbfAiLWqipgzH76OnF86rzuKwq0xQsHxBeagQtQe6aXljV2qcBVH97HlUfDMW2cEyNsiMBzVwSA69UXysciGg1/yKwtDIbR5yGe5ebKV7yLU9d/o3CTfRhHmtwZAfcqKwY32nUw55JbZFdcp1y/LBzpabIY5M6z2f13GsXBJXs0W7lsHJkfLdGpST6L8xjZKRm13Mue1pgLzxdp2xb04G+d3lbfGwqxRj6Sirh7+0LVxYq9pKOvXecGWHEVyst4ZCSYkoB7OSC3lP9eBq1GYKgjfhO65txo7U/oxGfREVzxGWUbKHBZIqgj2y2iAvsl1297CpyzOeuET21yTwqE8YbDj75ipqR6SUuJlSnesb2U6qFe3TpY63iO6Wxvj3zRJsulZ9h80Qa5EQjzNOA0lM7hw1ok0ZkGEXC0iwApNYVCLCgxIYltuMeVAdq1D0PbMi9rNV1ylRUiY5mad X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(346002)(366004)(39860400002)(376002)(8936002)(5660300002)(7416002)(66946007)(66476007)(66556008)(8676002)(2906002)(4326008)(38100700002)(31686004)(86362001)(41300700001)(26005)(53546011)(6512007)(6506007)(478600001)(36756003)(31696002)(54906003)(6916009)(316002)(6486002)(2616005)(83380400001)(186003)(4290200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzhlQW9qRTZWVUNBM25PK1NsS0VHQ04vMDdrUnRMbDJGejlvTnR0bFREZGF1?= =?utf-8?B?RHhMS3BhSERVOTQzYVJRN2xBWnJkYVN3bVdrWVFYUmpVSnlXazhjZHRPK05q?= =?utf-8?B?NFhpWlNlSGdNaTg2ZG1xbzIydjRxT3NENEZ1OXVMcFhqSE4xWnNsL0ZvVmJp?= =?utf-8?B?NWlEeUtQVVdGMUVDYURLTEZXNDAvc09CQ0p0Q0NEM1dEcVQ5ZFlNN09kaTNH?= =?utf-8?B?d3BodjhEMGxIdGg5dStyQnhqcCtheXNrdElYb01scTRxU1UyZFNjR05mT2cr?= =?utf-8?B?bDFGYlhkbGl5bjFDZkVWQ3BXemxlSVZ4dGd6R1dBRFNrOEJXOTJOK3JlYnJO?= =?utf-8?B?SXNZWERBNmtvZC91R05ybVRFKzRuRGc2Zkh5MlMxbVg0aWloeVlNMXJYRmpE?= =?utf-8?B?cXFKNzRYS3gyZUdXLzVHbXJmRHA5Z2dsOS9vOVltV0NtMzUvamFoVHdySjFG?= =?utf-8?B?L09GWTYrY25jWVg2ZkxFYzgxY1U4MExyWE5sM0FtSW9TOE01U1BicDZMMGpP?= =?utf-8?B?Q1U4L0k4ZXhqeTB5Q2RUTFRZMzUyaUh2UnZuWG9NS1JZYmRuYzJLUWVwNXgz?= =?utf-8?B?b2JTSkQycGtRZUMrTGpBVHBXZmtmWGl5NktLUVpDR0xOMHRrdlFUcDdrekhD?= =?utf-8?B?YXNYckprSXlTYittTXdEOEhBcVpoUDFoRitSNVVhTXgzUElrNm0vdFloL3Fa?= =?utf-8?B?T3FaSzVpOE0vTUJOaFBBVTRFMDB2ZXh3eG4yWncvdzFCNEh2dEozZ3BMaHJ2?= =?utf-8?B?RUlmVEJLU2Q4TTdWaS9yNURHR2lvdjN1N1VpUWIxYnVkQ005Vm91R2YrQ0tB?= =?utf-8?B?c0gzNGE4N0FwdDlianQ4RHI3dEM1cTdpSDhSNDNacGVVWmYwY1kzcGhSaHI1?= =?utf-8?B?eDJZWUhLdFZ0UVczSHNZSWhRVXRsMmZGalBRUElHZFNsU3RkZmRqTzduUGVp?= =?utf-8?B?cGRySkcwT2xpVVk1dEdibytsNGNNeklCTE9MT2p6Q2JhUWtQUUJBWit2TDly?= =?utf-8?B?K00vVEVxWXdIZkt5dVEvWHZkejhmei9iZzhkcmZBQkpCS0hDaGhwUDdzMklT?= =?utf-8?B?UGVOYndmS3QzRDQ1WTRLKzc5bXhpc0xkd2xmWGxzTzV0SE9RQkhjL0lNa01W?= =?utf-8?B?LzZsRU1LL3NiQTFPOG9TRWJFWnVRVHd0aEVYeGF1UkVkY0J6QitwbENrUHgz?= =?utf-8?B?OG1QSGtrSHN3SWE3VEM0ZXBIVlhjbk01d3pteHVQKy9NS25HQ1NVcU5RcHVl?= =?utf-8?B?czAzM1VYVWNlYmhXMTEwRTFlK2tLYWpzandMejJBYzJiN3hRQlFZT3FDRFpk?= =?utf-8?B?R1ZIeXdyaU9TRDFFVmRYWTh1MHE0Qk02dHZrZXFITFJKeERHK3Q4VWYram1U?= =?utf-8?B?ZHJUV2dYYks1WnVqbEhDejJreUROTVBzN1R5Mk1zRE1FZDh2WWU5aStuc2pJ?= =?utf-8?B?K2VFQVJPOWdKaG9PVWFlZVprQTZibmI3WTNjczdabVU1SDdvKy9Wek5OR3ov?= =?utf-8?B?NXB5YzQ3NjZkVTA2R3NnUWpDVjJlcG5qSEJzdlNjbmxYd2NnU1FxV1c4Nkgw?= =?utf-8?B?UzlHQXR1MFpaSGdYSVhQdjJrVDRBejdZdjcxc1ZEeTdabW1zUnVpVUFKV1ha?= =?utf-8?B?NjU2MGtnZU5DcHkyd1NZMG5iWkNFRlZ2Zm1Vd1VXdVJIM21reFR5NkkxSXBZ?= =?utf-8?B?Tmt6WU9kOHV1MmVWVGpvNEkvM21SSFBJcVFzeTdGdkNHK25uY2hBK3FJQ213?= =?utf-8?B?bGlYbmVBbkJpck55TXNpZE9ocG1lU0N3eDcxa2h0a0cyV2ZGNHkwZ2VRc3NX?= =?utf-8?B?SVE3TWZMTVpPVkl6S1VHbUZScUVBTDhkNU9CTGJvaGEyd2NkcklOMG9DQmFz?= =?utf-8?B?MWE0RUoxa3Y3R0tuam5SQ0gyd1hQZVEybktSUm1EbEFlOC9sVloxTXVHS0Zy?= =?utf-8?B?NUVndmFTZ0VKRHJmdFhWZ2VIRk1iN3lMRSswOVpoZDRxNUoxZmFjVlh1Mzh2?= =?utf-8?B?Vitpa2EvWHRkRVhyK1lseGk4ODRPQ2I3cnpyT2Q5emZiaktYdlZoblpaemV5?= =?utf-8?B?YmRQVHhLVUJvdDVIUExmNnR4RHVKbUZ1Y0JjdHJpd3h3RGxFZC9Uc0Y0VlRm?= =?utf-8?Q?v6MEbVteO5BSg+RxfIASqkTx2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d15aa0f-fb48-4f3b-9594-08da68c6c56a X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 14:06:55.2662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RK3gjZj+Bst+F868TKW/GlJxu391GPHVj+aAkWAIB3cnkBhw0EptPVS6Y34X6q43aZDk64n0IDAoFv2vcHlqEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2326 On 18.07.2022 14:07, Andrew Cooper wrote: > On 18/07/2022 10:49, Jan Beulich wrote: >> On 18.07.2022 11:31, Andrew Cooper wrote: >>> On 18/07/2022 10:11, Jan Beulich wrote: >>>> On 15.07.2022 15:26, Andrew Cooper wrote: >>>>> --- a/xen/tools/check-endbr.sh >>>>> +++ b/xen/tools/check-endbr.sh >>>>> @@ -61,19 +61,36 @@ ${OBJDUMP} -j .text $1 -d -w | grep ' endbr64 *$' | cut -f 1 -d ':' > $VALID & >>>>> # the lower bits, rounding integers to the nearest 4k. >>>>> # >>>>> # Instead, use the fact that Xen's .text is within a 1G aligned region, and >>>>> -# split the VMA in half so AWK's numeric addition is only working on 32 bit >>>>> -# numbers, which don't lose precision. >>>>> +# split the VMA so AWK's numeric addition is only working on <32 bit >>>>> +# numbers, which don't lose precision. (See point 5) >>>>> # >>>>> # 4) MAWK doesn't support plain hex constants (an optional part of the POSIX >>>>> # spec), and GAWK and MAWK can't agree on how to work with hex constants in >>>>> # a string. Use the shell to convert $vma_lo to decimal before passing to >>>>> # AWK. >>>>> # >>>>> +# 5) Point 4 isn't fully portable. POSIX only requires that $((0xN)) be >>>>> +# evaluated as long, which in 32bit shells turns negative if bit 31 of the >>>>> +# VMA is set. AWK then interprets this negative number as a double before >>>>> +# adding the offsets from the binary grep. >>>>> +# >>>>> +# Instead of doing an 8/8 split with vma_hi/lo, do a 9/7 split. >>>>> +# >>>>> +# The consequence of this is that for all offsets, $vma_lo + offset needs >>>>> +# to be less that 256M (i.e. 7 nibbles) so as to be successfully recombined >>>>> +# with the 9 nibbles of $vma_hi. This is fine; .text is at the start of a >>>>> +# 1G aligned region, and Xen is far far smaller than 256M, but leave safety >>>>> +# check nevertheless. >>>>> +# >>>>> eval $(${OBJDUMP} -j .text $1 -h | >>>>> - $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 8), substr($4, 9, 16)}') >>>>> + $AWK '$2 == ".text" {printf "vma_hi=%s\nvma_lo=%s\n", substr($4, 1, 9), substr($4, 10, 16)}') >>>>> >>>>> ${OBJCOPY} -j .text $1 -O binary $TEXT_BIN >>>>> >>>>> +bin_sz=$(stat -c '%s' $TEXT_BIN) >>>>> +[ "$bin_sz" -ge $(((1 << 28) - $vma_lo)) ] && >>>>> + { echo "$MSG_PFX Error: .text offsets can exceed 256M" >&2; exit 1; } >>>> ... s/can/cannot/ ? >>> Why?  "Can" is correct here.  If the offsets can't exceed 256M, then >>> everything is good. >> Hmm, the wording then indeed is ambiguous. > > I see your point.  In this case it's meant as "are able to", but this is > still clearer than using "can't" because at least the text matches the > check which triggered it. > >> I read "can" as "are allowed >> to", when we mean "aren't allowed to". Maybe ".text is 256M or more in >> size"? If you mention "offsets", then I think the check should be based >> on actually observing an offset which is too large (which .text size >> alone doesn't guarantee will happen). > > It's not just .text on its own because the VMA of offset by 2M, hence > the subtraction of $vma_lo in the main calculation. > > There's no point searching for offsets.  There will be one near the end, > so all searching for an offset would do is complicate the critical loop. > > How about ".text offsets must not exceed 256M" ? > > That should be unambiguous. Yes, that reads fine. Thanks. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369852.601401 (Exim 4.92) (envelope-from ) id 1oDRZf-0000TY-Mz; Mon, 18 Jul 2022 14:18:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369852.601401; Mon, 18 Jul 2022 14:18:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRZf-0000TR-K7; Mon, 18 Jul 2022 14:18:15 +0000 Received: by outflank-mailman (input) for mailman id 369852; Mon, 18 Jul 2022 14:18:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRZe-0000TL-Op for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:18:14 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70042.outbound.protection.outlook.com [40.107.7.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7552834e-06a4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 16:18:13 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by VE1PR04MB6685.eurprd04.prod.outlook.com (2603:10a6:803:120::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 14:18:11 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 14:18:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7552834e-06a4-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hLcKxY4DT3Raw0QB1TqdPmH40fYRY3XIX97VLDFEq/8OF96++CuB2H+zpWJPH1idUteIUoTd8J+YM7qpIkElZAzkcrqUl7eRAVsKRuKJ4YvjnKrUoFnBv+fDsgrxhFJtY4vZ1ABxL0ACmB3HYmhlWDMzZxXr69zBDFUraonZhxD2M+anc9j/ktxzFVQpoMHGN3pYIZEz4riU1DzwdTvGU2cCX7262LY62ADX8I0f7kzDOHS2/mGTM7dRU2J+XJH48zA4livdSclmx4bh42K2K2cznrOUCbLgFqc4rgqa9R2iTlD0AIgeo+nffU18XUWIimqajGo6RdasdeURAKp7fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5jl2yXiaCydCHyslEEvnLSLsXVm32pHu4jDvcXmC7u4=; b=ezZrLJ0trKVeyAfnPgqHUYmdtpbrQTfAEsdHNykNT2TgyvMmdCy3HMDRd3XzCCxYg0L+OFrIOWATMl4eETZrlJMvOrbRFFp/wANh8GHSdGShBJRtBghffCJPvGKl17l/R2SJUOzBDnBQeinQa1+pDDraLvINoxFoTtqz4h1fKGL8YDFShWmhnmuMFpGB2xCTa02axmmal39ox97eF7D0ez2NHi2wB8OhfWXvKEqy+Uit6WCzbDHbkpri/rW64U20on9Bix1kA4kvQWf5KzO0MaHc6GHuOtP11dl2wiruWLnVEqCd/M94zWddYrZdlPSHilH3zot2iy+wn7oUQfwxVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5jl2yXiaCydCHyslEEvnLSLsXVm32pHu4jDvcXmC7u4=; b=YnjDn4wKBMLwFlVQgPjDF8QdB+LwmWPNnj+3cx2B36kmQEsNJkZ2vC7ByGqRQrXJO80xosUnM2cOIGYZk42f4eZtEG8zZyTIs4W0TKyugHsrn2kIL74vYHr5lhTRa4mqiX4OrARMooPxY192TPGu6aAg6uApqgBuguZUevnnByNy+5Mj9APYdoWwPJcloqAFFdniSl59+/IRqyKlvQH4PFlVUA92fyoO89i2owstuVvGW4gJlb+t0+LYBoybHU5E/pXnmeSTJIDIyeDMg1KSsDuwduiK0DLw3Rkr0nYqw1OHgiNH5u6v73Fgm+gsqsiaynL/+iRnkFq3iRxpN6cAkg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3842b4a4-c059-1eb3-c292-f53c5357e502@suse.com> Date: Mon, 18 Jul 2022 16:18:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: Add MMIO Stale Data arch_caps to hardware domain Content-Language: en-US To: Jason Andryuk Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: <20220718140517.14771-1-jandryuk@gmail.com> From: Jan Beulich In-Reply-To: <20220718140517.14771-1-jandryuk@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0040.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::11) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a9868481-b313-4a80-3ea6-08da68c85824 X-MS-TrafficTypeDiagnostic: VE1PR04MB6685:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gmOfTqYi4JVe0qXf1yuVNIlT4a0ZxQaARC3P/Fcyc4JKufZKgTfN0eXZf/8jiSgxS2W+FsmWupfbuKIttb3beua3wuAy8LxXH/N5BUhjYylTXGuTOY1ih2UsdRvgSlpWOJey7YZtZoa6fn1lqfNlEjrtkHaAwrihYegECbtcycdx0uKvQRRBafPaMnVr1F7bZMT4vqiNajxXeePGu3RqXIkgwU1jzyKYTNqcWs7ERYiZP3latlGi+EASJ92nM+eqb5GKVKuy0AnUg9anWat+4CGMqK5DJv57M+G4x9wdnnr9EQPRRJp48+XJFYrWS7vRtTJum8HOhj7DCBwRBsM+mqN1PqeMqZ3ZZTXUwxRFGiRqvEBm6+KBfs/HAaIHujN5SRd+WhMNOaiNtsHZQTQZs9F+kW+qCwIHlPK6jY8gLFBdDZVEpPxjZKDCSpF27pSeURkC7ySVUOZU44y+ilms1tki5wyjHcLz++53zhmioXqusynCBiZFgY0ji5EEEC5L9DVfjfvYiDQyfu1Gb3+eKKOCZ9Opnm3zGpJDYYheMQ4MzbD9IKx7xgID5PZPPx4500X4lx41wUSk53kryV+24W0kFgx8R+3Aq6HlNVo78fJz7c4Eekkv/p2x2jDUmstHBeneqLTpl6sTMs58NK2IsLQcag+cKvtthgt8MyyR4RusrgERcbvnTZ/BGQeGPz6IiWNA0APiWqt9YpHaD6KsEbAQMCblV5kjlPZGLBRGgsD/cgNShw+FSugbD81HgtEPy0brNVHzIF7hV4jyfF+FG1BxVV1IwuYPVDshFlcSc7yTI67qsjBOVmpDKBjC/J5zCVldxOkEO3thsxSY+dRXapfPiuovLgYXANIpjOB5h/8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(396003)(366004)(2616005)(186003)(31686004)(26005)(41300700001)(83380400001)(6486002)(2906002)(5660300002)(478600001)(6512007)(8676002)(31696002)(66946007)(66476007)(66556008)(86362001)(38100700002)(4326008)(8936002)(6916009)(54906003)(36756003)(316002)(53546011)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDZaa1hNOTh0dUJTc0lTYjZoc0YwcTM1Qm1kRVhiQVpjWUNWSHNGMFkyRkFr?= =?utf-8?B?N21URFpKVTlHNzFHVHhvblFpVzVESUNlcEh3bFRRZHRqbHQ2TUR5ay9RN213?= =?utf-8?B?UkFQOUtiLzEwWWt3cnBzajYwQkdNNlhCYWZIQ2FSUllUUkZLeEZYeitxWXk0?= =?utf-8?B?V3NmYnlvbUlCQnB5Ylhzell2VjZId1VWaEFQKzNCdnZHVkVaaVpiUjMrVkJO?= =?utf-8?B?ODJVUUZrV2hkdlpwS0lKSUR5bG54K0traUxKQTM5WCsxNU0zYnVjaFNtYy9j?= =?utf-8?B?OWEvL3hIVVdTTXRORWhlMG5ZMU1JTnR5ZTNqclh0K0dVVmRNUklZbE8wRFNp?= =?utf-8?B?OVBLZk16b1F3SWNwOCt1cVNseGk2aEFCMDlLc09DTmNtdEtWSTNZNlYveTVS?= =?utf-8?B?YnBoMFg4ZDIyUjFTcExCWEhUakJZeXdTY3dDZ2VPN251ZW1MTm1VdmFVU1lp?= =?utf-8?B?d0JHbmxJaTZVUHR5R2JXamVrUXhTeGp4RDNDUFpuenhHY0ljZEl2dFVHY1VJ?= =?utf-8?B?WjFqd3R4cVJKTCtLU0RKQjZUWVdyYlBnUVpDNlJ0U3lyZVkwV0k2bStzeTlj?= =?utf-8?B?bGR4N0ZLY29BYUNWNGFZQ1RycFI1NHJYVlBlanRpcVpmTjNhQ2NmbHRuZDJv?= =?utf-8?B?NXljbkVwdVFrVTZUbjFQWGxLUkJwenQxVlh5bkR0WXdMQlRMOXZPRWRodHBp?= =?utf-8?B?aFo4b2xhdm55aUVWRFNZc05hUGtOdk5JVzZlTTdqeExBZ3dhYXBFT3RLSWcr?= =?utf-8?B?L0hFcldhOUVmb2lEcGhMeGJ1YVNNeXdCQW80c0I5WWRJNlIyWWVGbmdZTDd1?= =?utf-8?B?RnBUdVpOUWFBTXRBbHBNRHNmc080SjRFUkt6anRIVWluc0JSeDZvU3RodFht?= =?utf-8?B?QkRIdityMkNncENaa0xjRmF1bWJ1NW5XcWFrc3UwL21uNVVPdTRTS0xqdUFh?= =?utf-8?B?MWlCNDFXS1g5bllkWmFwNEo1bWZMd0U2M0hnK2g2NmFQRmJQNGd4QXVlQmND?= =?utf-8?B?WWRjSFdPQnJMUjJPQkdYME1KbzFhamlVNVdKRTRENFllQnQ1R1JKcXBlS1dM?= =?utf-8?B?WEdBUjg5T2d5Z2lGYU5lTjQ0WlZIMzBVS1dXQzBJWHhXb3l2QTQ0VStOSnNa?= =?utf-8?B?a2JQank1aWltd002OVpZRC9uVXVaYVZJMlpXRjdKRThCMG1uTm5sTXpGRGVs?= =?utf-8?B?V0xaSVpHYlNubThDVXBvMmxQRHNvS0drdTJjWWt0cHY0RDdzdUhiMmJOcVpy?= =?utf-8?B?MEZIekEvNlJxSjI3M05SVU9aTFZFRFdrakp4SUNIVmozL1FkSWVaRVpsaDRJ?= =?utf-8?B?M3pmcFJaT1ZFUTlTeTQ0Nllnd1ljZFFwMXJyNFo2ZXJWQ1E4eEY4YlBLdTdv?= =?utf-8?B?SEJ0YVFaMFIwZXFLWjMwSk5VNmV4Y3RUTVRuR01sV2JWc2lVUThOdDArQ0ty?= =?utf-8?B?Wi9kQk02VUFUTEd4Yy9HR29HTVhzcjVueDlNekpCaEIrTnkvLy95TlNhdEx4?= =?utf-8?B?YlVhV0gxTlR2dVk3ZEJtT2JrZi9kdDdGMGF2Qnd6TWpjQS9zOUR0N1ZZOWdq?= =?utf-8?B?ZmZkY3ArNWFHL0hjcWh5S0dhcktkUXRvcFUxVkQxT3BRUVM0QUVkOVhDcVgr?= =?utf-8?B?Q3EvelpwcWxFNkRnbkwrMEpCSDQ2V05JdGRLbys0U1JrTFp0aGwrZ2pZODVR?= =?utf-8?B?L3BsaHNWK2kxOHMwRVpPZjZKOEl4VUtTekw5ZkFGUEtnWUE2SkxQNm5mWVQ3?= =?utf-8?B?YkRVWTkra2JpU2U2bG1MZmk4ZndjZk5XbytsK1gxSHZhSDlib1FqNWlPcDJF?= =?utf-8?B?UGZWdkpRQWxjeHhleEw2SnJlTURkK1RSL3JZT1E3Z3c2cnFFMWQvbVdwa2sr?= =?utf-8?B?bHlDWmpkY0tvK0VxcTcyeGhJMjJPdlNKY1IrQkU2OHlGckdZL1BzbkhJOTRr?= =?utf-8?B?cEZydTJ5UVp4RXZXREFmU2Q0TE9xeUdOVENGUURKTEY2ZGVhaStCMzlCcFMw?= =?utf-8?B?L3Mzc2hDOHdISDRLeGU2R2JYZzRwajRZcnVma2lKSEhydiszWXdzalprNXZ5?= =?utf-8?B?OEpPc2h5MElBN0ZCVlErckpFUlFKckN0YWVIcXQrMG40R0Y5TjIveGVGaFZE?= =?utf-8?Q?y4zF6NakwFaMuM0X7C/TzD5Rh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9868481-b313-4a80-3ea6-08da68c85824 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 14:18:10.9427 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6m6KFP94DJ4s8/uP1OflLWt/6Dnyr8Dr6A4ubm3UILJ4TQLM0miCTJeYiMPtrM0r3ydKe6Z+n0Ik+BwtkMIhbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6685 On 18.07.2022 16:05, Jason Andryuk wrote: > Let the hardware domain know about the hardware it is running on. This > allows a linux Dom0 to know that it has the appropriate microcode via > FB_CLEAR. /sys/devices/system/cpu/vulnerabilities/mmio_stale_data > changes from: > "Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state > unknown" > to: > "Mitigation: Clear CPU buffers; SMT Host state unknown" > > Signed-off-by: Jason Andryuk > --- > Should calculate_host_policy()'s arch_caps mask also be updated? They > are not identical today, but I'm don't know this code to understand why > they differ. I think this wants updating too, yes. I'm afraid I have to leave it to Andrew to provide the reasons for the differences between the two. I would further suggest to also consider adding RRSBA and BHI_NO, even if then the title would want adjusting. And finally I'd like to ask to add a proper Fixes: tag (or more), as it looks like the updating here was simply forgotten when the bits were introduced. Ideally we'd have a way for the compiler to remind us of updates being needed (or at least be considered) here. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:26:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:26:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369859.601412 (Exim 4.92) (envelope-from ) id 1oDRht-00025C-Ls; Mon, 18 Jul 2022 14:26:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369859.601412; Mon, 18 Jul 2022 14:26:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRht-000255-J4; Mon, 18 Jul 2022 14:26:45 +0000 Received: by outflank-mailman (input) for mailman id 369859; Mon, 18 Jul 2022 14:26:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRhs-00024z-Af for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:26:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a3860d5c-06a5-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 16:26:42 +0200 (CEST) Received: from mail-dm6nam11lp2168.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 10:26:38 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5450.namprd03.prod.outlook.com (2603:10b6:806:be::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 18 Jul 2022 14:26:36 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 14:26:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a3860d5c-06a5-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658154401; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=1QE++DKcBwCnHsMRSia20tXPlUS+rCZNxSodvgto4lg=; b=cgK3tC3eEYlRGNHg5H00vudR0HB5l01c7TJ7KYtqbg20GjIqrc1KrNAB EoLGQ8wXzDYdthB4ybk3WSEyfPrwctU5BGhrLLjLk6wPRq1J+x2RsLXbu tM7OVK63Lbq5C4vvtBwHY3wEyyQB+2XffRGGMHzjjSwhonSZvJloVb6+C g=; X-IronPort-RemoteIP: 104.47.57.168 X-IronPort-MID: 76043816 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:aHpdSqOvqmjAKSnvrR3dlsFynXyQoLVcMsEvi/4bfWQNrUol0jFWn WRJC2GEO/aOYDeme9gjOYS/pEhVvcDcy9MyTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPvT8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFO2mvdTD09oHrcDpPkvL1513 /Ayd200O0Xra+KemNpXS8FKr+F6dYzHGd1avXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr3wCChI1W0q3rMzUYzy0HVwBZ8z/7GN93Nd8bRbc5UglyZt iTN+GGR7hQya4LHlWHVqyzEaunnrAb8QI00FJmC5KBJsmCTzWFQKDAwSg7uyRW+ogvkMz5FE GQE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l90bPywOQB2xBQjsfbtUj7ZYyXWZzi A/PmM71DztytrHTUWia6rqfsTK1P24SMHMGYigHCwAC5rEPvb0Os/4Gdf47eIbdszE/MWiYL +yixMTmu4gusA== IronPort-HdrOrdr: A9a23:zS2CG6n+guyUK1yBZ++LmMxz9ejpDfOAimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdG9qeu1z+8+3WBjB8bYYOCAghrkEGgC1/qo/9SEIUHDH4FmpM NdmsRFaeEYSGIK9PoSgzPIX+rIouP3l5xA7N22pxgCcegpUdAH0+4TMHf5LqQCfngiOXNPLu v/2iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLokCs2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlawkEyzzYJLiJaYfy/gzdk9vfrWrCV+ O85yvICv4DqE85uFvF5icFlTOQlgrGoEWSs2NwyUGT3PARAghKRPapzLgpDScwoSAbza1B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/gpiuKYlGctsRLYkjTRoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4So+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSuvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9GR6svM7z94HRmyGG9fIzmZ0WS9ih33ekIhpTsALz2LCaEVFci18O9vvR3OLypZ8 qO X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76043816" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G0Z1GZgWEZfdxZgxRW1CswMSJJxVrq8vTk3SYfD/PSnYYCxaE4myrMSNkqR/YBODSeHCU4969oGMN+HMLeqQQX7EzOg8X6GPvl14ruTGB3+hLcca+hJwcKR6B2Y7dfZORC6FkXAskbGBhs8gOqQN3uNa7MpquqNlVB7GyGr2qgo1vpnIPTUm4GUEc+PytA7gcsqnYEpCLv8O+g66SQrWszbQhtB64ilP3GDVYvdL+2+ouwWtyskB6zgzT+EKdMyY4Te6Qjhq0+fER12jMjABlDJW6ampA6Bandt8m1fjw0m49hWM2dKasKUY9/U1JINYre7pJSgsJDLJuF41kh435w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1QE++DKcBwCnHsMRSia20tXPlUS+rCZNxSodvgto4lg=; b=CXxrjfIqoFONkMDxJ7EQDagJYAbKILFTQ/HrVmwHLccuuc1EWJwBbt345PA75K05JqSNeNtZjg6gjfgYKFYugX7aYrNTFUKH/U/bwtgdYgMYawvYzC2vIRAfPQRcG4p5yq6e1XMJKvham1hVaJLmZN3fehD5wSRUjxqAzQ2+FzPEHsTCHB5x2mvcjqTd1x4EGeQEvcMDU9BSgMA8E5IdkgfQiUCHSu8fbU/8F1phdslrFtKMBbK+jnQtKI9Q1ZV07YyLgAL39M97yiABZZvhv3ko9kUrkysZUBVW/OWtDSST0U8+Kkh4ZCo8eWyXOV0MNLWe8yRg4bEhEQU1663xHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1QE++DKcBwCnHsMRSia20tXPlUS+rCZNxSodvgto4lg=; b=YD8UjJJvgXGcfUK5DklU2mkIEdp1WywnjaHQecKdfIGrnA3jMSpFZFBE1jYnEf7y6avkdoCrnvPNvZ4SnsJ20vNzOpQrcimKQ4otnL3piJEA1/Xm+oV1EB/z0VFFLVVow1UBfcRrdqI46fgpeB+JOeG9fXJWvK+l3KAiOQMZ5VM= From: Andrew Cooper To: Marc Bonnici , "xen-devel@lists.xenproject.org" Subject: Re: Xen Memory Sharing Query Thread-Topic: Xen Memory Sharing Query Thread-Index: AdiXcIvKzj1u3ooYRvOwLKlCsLdCEAA/89UAAIdcHqAACSWogA== Date: Mon, 18 Jul 2022 14:26:35 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9144db0a-d5ce-4fe2-b946-08da68c9852f x-ms-traffictypediagnostic: SA0PR03MB5450:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +W7BfACObs72DvuO5PgfJ6ukMUk0BhaJ3vjkEKDn+NakXggRrFkDTlVFHqHsabct8qhKKOV2jKO6SXd0rtfxX85j+U3GihHQGIw6qqJOIstMbeiw3lIhyJsZ9vD7ioNdOQ9IfLc6kQ6Hm+bgqu/zqpGxL9D81KDtt9nFksG4NpvRij1Pz/vWENzZsHXZcTsPVMRAc5JEiK1BVYaRy8sYZZk58e2JMz6uSEukvnq86e8y6WuPu7d0+AaKX/j08bCE7lausE9uWJ4e/TnIGY/yNm5MLUq5NS1gC8dCxMbNZKN3Q5d2uqvalCm5dXFZnQehXnuXsU2CZ1b3BgGYJFqRtaMXNZCfaVotJYSErcbniH8E6znMJ3dd5UNY0fM9a1arxoGG6krSoNZHluBhrueU1KOxNdbNfnHhtlmysYHTyoTTioJZuPYyIuLJ5hQowTIBmOTxUb6rWJsZ/q1Lq6HRduo8xP4CwlIhXghI+e3MF672GSo+x+xB3fpMxqg/iDYayyJJgMlGHjVoGji8M1lJcSd+V108JrUpFkV/Vb2oF4hVTxg6qmdVzKOK4i0CZxD2E63Ye23loVIcoQd51gXEfrEi5BtkG2VmulxHpTz3Itj2iz7U37T/IlJnn52SFKK0FfOHU1gmjHSd8x3sZEw/GFjlHCFHkXjZUlFzAH5PvswzPWoS9DLi0dHCe6JmHDK2X6gAW1p0FxAZdZDgXduSOHOXdGQjD72l6ZP5N6XDw8leVHZSjKO08F7Kr1a1mWyPQyanilV+BmQZwxvp10k7rVsEtfD3hxPyUrkmUjklzX9ufjzx6pZbLGDTz5hhgZgj8coUSyviZur2n+6Lo1kN7OXaFXcvz/Lz97wkZrI9sPq1RbJo0IOoAjcExYUb7kFb x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(39860400002)(396003)(346002)(38070700005)(2616005)(316002)(83380400001)(31686004)(2906002)(82960400001)(6506007)(41300700001)(53546011)(5660300002)(76116006)(66946007)(186003)(91956017)(66556008)(110136005)(66446008)(64756008)(36756003)(8676002)(8936002)(478600001)(38100700002)(6486002)(3480700007)(6512007)(71200400001)(86362001)(66476007)(122000001)(26005)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Qk9tVmZnZTZWbnE0Z1lMb1QwSjQweEpMY3RBZzI0M2VyZ0FSSm5pajVTSkIx?= =?utf-8?B?NnBnKzZNcVE2R0Y4RjRqNFlyL3kxVXArM2g2TDB0ZFBQcXRha0hLMGlhTlYz?= =?utf-8?B?a3k2M3dPcHNaMTF0SEw1eS9CZEV2YTlUWGdxYTRtWEVmZDZwOVFFcy9vRDRw?= =?utf-8?B?VGJjM2xVWGU5REZxMmFXLzBkZFc1ZzFLaGE4Rm9nK3phWU5VejM3eWtWaGp5?= =?utf-8?B?KzVjVjM1a0RrOFQrMHd5WVNSRjdmWlQvS3JWUnBwUmlrTnlZc1NYQ3R0dTBz?= =?utf-8?B?eXZMMHppdE9tWE41aDVwYm1lOGFmNjVZK1hlUnRZY1dHY1lHT2oyWWRLdDJ1?= =?utf-8?B?YW1ieCtWQWFLcGVpTnZWVlJ2aHBPNmJPZUJraGFIOWRtd00zMzdkSkl5Z2wr?= =?utf-8?B?VmxtODZBQkN4NXB2ZjJiUWNjWkJGS2FaVzVlOUNOT3dSV2ZNUWVmVTZyaDRz?= =?utf-8?B?RVhlYzdzUVVkaWFleFpRM211Y29DWHV4ZDBkWVpyU2Q5TDU2QnQvQnpxRlBz?= =?utf-8?B?d0RyUXJWSElvcS8yTDkvL1ZoWmZYc2drc0I0T0MwaEVVR0VzT2tWenkvUzRa?= =?utf-8?B?QmJMQnpPTW11Q3JvS3p5OFh0VldKWWZqekk2aGtoQzlCeDRic3MzUktkSmRo?= =?utf-8?B?VThlNm9KQmtwbVFTUFVMZVVEaU5UZ1RzUzNrWjFMQmRWNURRQTd3bFg3aDRL?= =?utf-8?B?cTl6ZlJodXBORys4Q0xXRzJuOWY4SzYvNFh1VHNkWHg4dWlWS3RJcFVBUk1C?= =?utf-8?B?eEhHcXZOU2l5QWVXMUQxVW81MlMrQXY0QlFUaDluQVlUZFEzZjdIMERQTlc4?= =?utf-8?B?VXEreWp4MjFuZWdnNTRCT0FFczZzbzUyeDlFUmU0cGhKMHRLNDhaeGdjeVg2?= =?utf-8?B?eFMvV2kvM3J5czNLK2JVZURMbU80VjZVRXNCKzJLUjl0cDBFby9aNFpPMUla?= =?utf-8?B?Y0N2dVFlZlpkeUZ0UXRrV1FkQjcrQkJjZVRXbS9QLzFYRGROMnkwRFY5UnZv?= =?utf-8?B?aUJzRnpQWm84WTBDRFdsWktIYmdUb0FZK2poUU9OZjQ2NTFKRytLanFaZVh2?= =?utf-8?B?VXlTN0V6cU92ZXFyUGp3YVo0djgyMlI3SUpVOCt2S2ZTQ3Y2L0JQSGJrUTd6?= =?utf-8?B?bzlPcEt0STNiZ0w4a1R4Y09wbWV2bjVvZWJlcWtyNDllYjNrL1BZSnNnWW5a?= =?utf-8?B?YzNLSVRhNVNNRjBLZi8wK3JmKy9XWkVCV25ScDl6ZVQxcyt1RlBsUjNndGVO?= =?utf-8?B?YndlNUI3ZFdNaDBYeWRNZXAwc0MrMmF5b2E1YXdZWkRQQWd3MlFYRUNnakNS?= =?utf-8?B?VlRPNWlOQlA4NzQzTXZOUlZ1dm1QbHVpa0c4b1hZUDJVSStJUFhDYjJUODVN?= =?utf-8?B?VDM2c1A2bE5IWXNtenk0SlE1NnJqUWQ5a09qUUpiZmpBOHlzZ1pMTFdud0Zu?= =?utf-8?B?L0xSS05zZzM1ZjhpUVRvUEZkNDk2N3ZCUkxka2ZsVEJqdG5MRHdKeHpoeWhL?= =?utf-8?B?UWo4eFhEQ0RFQzNlTlRGK1ZGNU5Vc2toVXBTZlRvSFVnRkN1Qm9BbDQvdGRG?= =?utf-8?B?M2pSWEQ1czVXNGcxT0hnNzJGcy9MNU5hNUlycHBXY0FVZ0h1UHJ1MVJTRkw1?= =?utf-8?B?T2gwdlVOMEFscFdyanZsOXNxWVphVEJTSmFRZXU4a1U5dEdnUDVEVEt0YzFp?= =?utf-8?B?NllxNWMwZ0Y0M29MUXFHODllNnFvWURiZEp4VlVCUVQzQUlHUGlXUkcvUHov?= =?utf-8?B?T3kvUjhSK3ZSRTltK0hBTWtMbThBdDA4NTRFc2dPaEhJeG5WQzdrdmNwYmM4?= =?utf-8?B?WVE3Vm1McWYvcUhlRXBqbzJQbmdWUVN5OTFpcFJQVm9rL2tXcTdDYVlMc3BW?= =?utf-8?B?NEltNFhTQnZqMzk0ejc3cUFuaDUvdjNEcDloTDhoS3l3SHdmMUdDR1gxTGpY?= =?utf-8?B?LzVuUzIyUWU3bGovbnZvd1NEdTN4ZlkrbVZXTlhNRTYyeTVoTHh6eGR3aU5s?= =?utf-8?B?c3pwTUY1cnlQbDdadlduZFRSSEhXRFlRMlQ4Z0ptNDRsWExzK3NCVi9nWEJV?= =?utf-8?B?NmJJZ3lmS0F2RmRQWldBWDRZSTBuRG92alo3YzRtUVV3NUNJVW1RREdCQVpU?= =?utf-8?Q?RCups0Cjo8hfh3txttRY1tbHD?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9144db0a-d5ce-4fe2-b946-08da68c9852f X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 14:26:35.8246 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YhB2EwX5mptOK9vubs6Zr+isgg8KsS4bG6W33R2wGT5ZNfNw+1YmazyC9xGboQFcCuzjPl26GjmnlrxHP5LqleW1lIjAO6ONL1btzOxDNcw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5450 T24gMTgvMDcvMjAyMiAxNDo0MCwgTWFyYyBCb25uaWNpIHdyb3RlOg0KPiBIaSBBbmRyZXcsDQo+ DQo+IFRoYW5rIHlvdSB2ZXJ5IG11Y2ggZm9yIHlvdXIgZGV0YWlsZWQgcmVwbHksIHRoYXQgbWFr ZSB0aGluZ3MgDQo+IGEgbG90IGNsZWFyZXIuIEkgZGlkIGhhdmUgYSBmZXcgZm9sbG93IHVwIHF1 ZXN0aW9ucy4NCj4NCj4+IGdudHRhYiB2MiBpcyBob3JyaWJseSBtb3JlIGNvbXBsaWNhdGVkLiAg DQo+IFdpdGggdjIsIGRvIHRoZSBoaWdoIGxldmVsIGJlaGF2aW91cnMgY2hhbmdlIG11Y2ggZnJv bSANCj4gd2hhdCB5b3UgaGF2ZSBvdXRsaW5lZCBoZXJlPyBEbyB5b3UgZXhwZWN0IGluIHRoZSBs b25nIHRlcm0gDQo+IGZvciB2MiB0byBiZSB0aGUgcHJlZmVycmVkIGltcGxlbWVudGF0aW9uIG9y IGFyZSB0aGV5IG1vcmUgbGlrZSANCj4gYWx0ZXJuYXRpdmVzPw0KDQpUaGF0J3MgaGFyZGVyIHRv IGFuc3dlci7CoCB2MiBjb21lcyB3aXRoIG5ldyBmZWF0dXJlcywgYnV0IHNvbWUgZmFyDQpzaGFy cGVyIGNvcm5lcnMuDQoNCnYyIGluY3JlYXNlZCB0aGUgZnJhbWUgc2l6ZSBmcm9tIDMyIGJpdHMg dG8gNjQsIHNvIHlvdSBjYW4gYWRkcmVzcyBhDQpmcmFtZSBhYm92ZSB0aGUgMTZUIGJvdW5kYXJ5 Lg0KDQp2MiBhbHNvIGludHJvZHVjZXMgc3ViLXBhZ2UgZ3JhbnRzLsKgIFRoZXNlIGFyZSBub3Qg bWFwcGFibGUsIGJ1dCBjb3B5YWJsZS4NCg0KT24gdGhlIG90aGVyIGhhbmQsIHYyIGFsc28gaW50 cm9kdWNlcyB0cmFuc2l0aXZlIGdyYW50cywgYW5kIHRoZXNlIGFyZSBhDQpzZWN1cml0eSBkaXNh c3Rlci7CoCBUaGV5J3JlIGxhcmdlbHkgZGlzYWJsZWQuDQoNCkZpbmFsbHksIGFuZCBtb3N0IGlt cG9ydGFudGx5LCB2MiBzcGxpdCB0aGUgc3RhdHVzIGJpdHMgb3V0IG9mIGZsYWdzDQpmaWVsZCBh cyBhIHBlcmZvcm1hbmNlIG9wdGltaXNhdGlvbiwgYnV0IGNyZWF0ZWQgYW4gQVBJIHdoZXJlIHRo ZXJlIGlzDQpubyByYWNlLWZyZWUgd2F5IG9mIGludmFsaWRhdGluZyBhIGdyYW50Lg0KDQo+PiBX aGlsZSBhIGdyZWYgaXMgbWFwcGVkLCBkb21BIGlzIG5vdCBwZXJtaXR0ZWQgdG8gZWRpdCB0aGUg DQo+PiBhc3NvY2lhdGVkIGVudHJ5LiAgDQo+IFNvIElJVUMgb25jZSB0aGUgZ3JlZiBpcyBtYXBw ZWQgdGhlbiBkb21BIGNhbid0IG1ha2UgYW55IGNoYW5nZXMgDQo+IHRvIHRoZSBlbnRyeSBhdCBh bGwsIChvciBhdCBsZWFzdCB0aGV5IHdvbid0IGJlIHJlZmxlY3RlZCkuDQoNCkNvcnJlY3QuDQoN Cj4gU28gaWYgDQo+IGRvbUEgd2FudHMgdG8gbWFrZSBhbnkgbW9kaWZpY2F0aW9ucyAoZXh0ZW5k IHRoZSBzaGFyZWQgbWVtb3J5IA0KPiByZWdpb24sIGNoYW5nZSBwZXJtaXNzaW9ucyBldGMuKSwg dGhlbiBpdCB3b3VsZCBqdXN0IGNyZWF0ZSBhbm90aGVyDQo+IGVudHJ5IGFuZCBzaGFyZSB0aGUg bmV3IGdyZWY/IA0KDQpBIGdyYW50IGNvdmVycyBhIDRrIHBhZ2UgKHVudGlsIHlvdSBzdGFydCB1 c2luZyBzdWItcGFnZSBncmFudHMgaW4gdjIpLA0Kc28gdGhlcmUgaXNuJ3QgcmVhbGx5IGFueSAi ZXh0ZW5kIHRoZSByZWdpb24iLg0KDQpGb3IgcGVybWlzc2lvbnMsIHRoZSBvbmx5IGludGVyZXN0 aW5nIGJpdCBpcyB0aGUgcmVhZC1vbmx5IGJpdCwgYW5kIHRoYXQNCmlzbid0IHNvbWV0aGluZyB5 b3Ugd2FudCB0byBiZSBjaGFuZ2luZyBtaWR3YXkgdGhyb3VnaCB0aGUgdXNlIG9mIHRoZSBncmFu dC4NCg0KQnV0IHllcywgeW91IGNvdWxkIHdyaXRlIGEgbmV3IGdyYW50IG91dCB3aXRoIG5ldyBw ZXJtaXNzaW9ucyBhbmQgdXNlIHRoYXQuDQoNCj4+IEZyb20gYSBncmFudCBwZXJzcGVjdGl2ZSwg WGVuIGRvZXNuJ3QgZW5mb3JjZSBhbnkgcG9saWN5LiAgZG9tQSdzIGdyZWZzDQo+PiBjYW4gYmUg bWFwcGVkIGluIHRoZSBtYW5uZXIgcGVybWl0dGVkIGJ5IHdoYXQgZG9tQSB3cm90ZSBpbnRvIHRo ZSBncmFudA0KPj4gdGFibGUuDQo+IFNvIGRvZXMgdGhpcyBtZWFuIHRoYXQgaWYgZG9tQSBncmFu dHMgYWNjZXNzIHRvIGRvbUIgZm9yIGEgZ2l2ZW4gZnJhbWUsIA0KPiBhbmQgdGhlbiBhZGRlZCBh IG5ldyBlbnRyeSBpbiBpdHMgZ3JhbnQgdGFibGUgd2l0aCB0aGUgc2FtZSBmcmFtZSBkZXRhaWxz IA0KPiBidXQgd2l0aCAiZG9taWQgPSBkb21DIiBpbnN0ZWFkLiBUaGlzIHdvdWxkIGJlIGFsbG93 ZWQ/IEFuZCBpZiBzbywgd291bGQgdGhpcyANCj4gcmVzdWx0IGluIGEgMy13YXkgc2hhcmVkIGJ1 ZmZlcj8NCg0KWWVzIGFuZCB5ZXMuDQoNCkkgc3VwcG9zZSBpdCdzIHdvcnRoIHNheWluZyB0aGF0 IHRoZXNlIGFyZSBmcm9tIHRoZSBwb2ludCBvZiB2aWV3IG9mIHRoZQ0KbWVjaGFuaWNzIG9mIHRo ZSBncmFudCB0YWJsZSBpbnRlcmZhY2UuDQoNCkluIGFkZGl0aW9uLCBYU00gY2FuIGJlIHVzZWQg dG8gcHJvdmlkZSBwb2xpY3kgYmFzZWQgcmVzdHJpY3Rpb25zLsKgIFhTTQ0KU2lsbyBpcyAiZG9t MCBhbGwgcG93ZXJmdWwsIGRvbVUncyBjYW4gb25seSBjb21tdW5pY2F0ZSB3aXRoIGRvbTAiLCBh bmQNClhTTSBGbGFzayBpcyByYXRoZXIgbW9yZSBsaWtlIFNFTGludXguDQoNCj4gQW5kIGZpbmFs bHkgYSBzaW1pbGFyIHNjZW5hcmlvLCBpZiBhIGZyYW1lIHdhcyBzaGFyZWQgZnJvbSBkb21BIHRv IGRvbUIsIA0KPiB3b3VsZCBkb21CIGJlIGFibGUgdG8gYWRkIGFuIGVudHJ5IGluIGl0cyBvd24g Z3JhbnQgdGFibGUgdG8gc2hhcmUgdGhlIA0KPiBzYW1lIGZyYW1lIHdpdGggZG9tQyBhbmQgZW5k IHVwIHdpdGggdGhlIHNhbWUgb3V0Y29tZT8NCg0KVGhhdCdzIG1vcmUgY29tcGxpY2F0ZWQuwqAg UG90ZW50aWFsbHkgeWVzLCBidXQgaXQgZGVwZW5kcyBvbiB0aGUgcDJtDQpjaGVja3MgZG9uZSB3 aGVuIG1hcHBpbmcgYSBncmFudCwgYW5kIEkgaGF2ZSBhIHN1c3BpY2lvbiBpdCBtaWdodCBiZQ0K ZGlmZmVyZW50IGJldHdlZW4geDg2IGFuZCBBUk0uDQoNCkJ1dCBsb2dpY2FsbHkgc3BlYWtpbmcs IGlmIGRvbUEgaGFzIGdyYW50ZWQgYWNjZXNzIHRvIGRvbUIsIHRoZW4gZG9tQiBpcw0KcGVybWl0 dGVkIHRvIHdoYXRldmVyIGl0IHdhbnRzIHdpdGggdGhlIG1hcHBpbmcsIGluY2x1ZGluZyBzaGFy aW5nIGl0DQpmdXJ0aGVyIG9ud2FyZHMuwqAgVGhpcyB3YXMgdGhlIGlkZWEgYmVoaW5kIHRyYW5z aXRpdmUgZ3JhbnRzLCBidXQgdGhlDQppbXBsZW1lbnRhdGlvbiBsZWF2ZXMgYSBsb3QgdG8gYmUg ZGVzaXJlZC4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:35:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:35:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369865.601422 (Exim 4.92) (envelope-from ) id 1oDRq2-0003Zd-Fp; Mon, 18 Jul 2022 14:35:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369865.601422; Mon, 18 Jul 2022 14:35:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRq2-0003ZW-D1; Mon, 18 Jul 2022 14:35:10 +0000 Received: by outflank-mailman (input) for mailman id 369865; Mon, 18 Jul 2022 14:35:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRq0-0003ZQ-QE for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:35:08 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d216abb9-06a6-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 16:35:07 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id u19so10836726lfs.0 for ; Mon, 18 Jul 2022 07:35:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d216abb9-06a6-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OWSSskPizbv13pCfhcraXRUYiiPfqJIszhCz/Xu/GZM=; b=bwrbIdUWT6h6zVO4ORqAijm8PTDSXYzEhh5bXA1TP0ENe/tmQE5MPIe0naaSZUsdk8 SA6f23yDaktNNJjUPSy8sLIeURORxWDIsrI1207OvWQxYfIz0K8oOsIlv6sL0Q25Q89J KKc4Q+vDeCH6bFbXqjAi7Rm9j/INzrq8WCh9zSfxRQTYXxFD9Wg8PdMyaGFdYvy1oZ4J wzB9g5Tdp+8zMVKlfDVJ3EYB0jxbasp/z4UDDHirubS/pFrzKLypWQQZ2VfpBwCaqhlV e3g7t0HrqRNQPXUKhE1MyLVbcPYmdrh87cL5zXtnhrNAKlmc5Yx2cLo7w+SOgeS32o5i HKGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OWSSskPizbv13pCfhcraXRUYiiPfqJIszhCz/Xu/GZM=; b=TgmQm6E5JGIip6hBm6Yd0oiXpopVKKS9Wdx6k6iZgPQZCyTA0d1A+oKHFTioamwLCr b03bNwxJxwkbZZ7s/CMHUxTjc85ggafO6OvbArTUDqVFPAOCqR//TDb9UfGQLeUFSfWy mwUi8kwcrKro9DoUE+m/SJa7EJ5mbmWEnCa/QMmOYLvZZikwHVorOja0/2cWOYq+/zng oEOoDoHj/kvkdrixnXtBHU+NpGPN/ZpCKvdLHk73rGKGdukFGdOwGR3n8vKxpghTGM2U AaVDv2I5V85TeyjtWdSMCg74KemtNDJXSiHk0k1jtbC3N9gANtfF3DhiCCx3gIJE91Im OcKA== X-Gm-Message-State: AJIora82kFIMc5a98MKRbyng5ANXBVZ7MJ/pfeLAEpzlNetUqtuHC4rB fzIJCP63AYLQmMlpvi/ZvPzTjR0xKTkvDhNB6GQ= X-Google-Smtp-Source: AGRyM1t3EwDb6/uQHaZy5o02XXjffk7DzfQ2iFGyEQxGlhfJgT1YYKdgMtdnvqUvHHbcyoZXtGdpXT7AanUmcNfBjBg= X-Received: by 2002:ac2:58e2:0:b0:48a:1a12:c4f3 with SMTP id v2-20020ac258e2000000b0048a1a12c4f3mr10512331lfo.447.1658154907267; Mon, 18 Jul 2022 07:35:07 -0700 (PDT) MIME-Version: 1.0 References: <20220718140517.14771-1-jandryuk@gmail.com> <3842b4a4-c059-1eb3-c292-f53c5357e502@suse.com> In-Reply-To: <3842b4a4-c059-1eb3-c292-f53c5357e502@suse.com> From: Jason Andryuk Date: Mon, 18 Jul 2022 10:34:55 -0400 Message-ID: Subject: Re: [PATCH] x86: Add MMIO Stale Data arch_caps to hardware domain To: Jan Beulich Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , xen-devel Content-Type: text/plain; charset="UTF-8" On Mon, Jul 18, 2022 at 10:18 AM Jan Beulich wrote: > > On 18.07.2022 16:05, Jason Andryuk wrote: > > Let the hardware domain know about the hardware it is running on. This > > allows a linux Dom0 to know that it has the appropriate microcode via > > FB_CLEAR. /sys/devices/system/cpu/vulnerabilities/mmio_stale_data > > changes from: > > "Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state > > unknown" > > to: > > "Mitigation: Clear CPU buffers; SMT Host state unknown" > > > > Signed-off-by: Jason Andryuk > > --- > > Should calculate_host_policy()'s arch_caps mask also be updated? They > > are not identical today, but I'm don't know this code to understand why > > they differ. > > I think this wants updating too, yes. I'm afraid I have to leave it to > Andrew to provide the reasons for the differences between the two. > > I would further suggest to also consider adding RRSBA and BHI_NO, even > if then the title would want adjusting. And finally I'd like to ask to > add a proper Fixes: tag (or more), as it looks like the updating here > was simply forgotten when the bits were introduced. Ideally we'd have > a way for the compiler to remind us of updates being needed (or at > least be considered) here. That all sounds good. Thanks, Jason From xen-devel-bounces@lists.xenproject.org Mon Jul 18 14:37:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 14:37:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369870.601433 (Exim 4.92) (envelope-from ) id 1oDRrx-0004JU-SF; Mon, 18 Jul 2022 14:37:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369870.601433; Mon, 18 Jul 2022 14:37:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRrx-0004JN-PY; Mon, 18 Jul 2022 14:37:09 +0000 Received: by outflank-mailman (input) for mailman id 369870; Mon, 18 Jul 2022 14:37:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDRrw-0004JF-Ql for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 14:37:08 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10045.outbound.protection.outlook.com [40.107.1.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19624bea-06a7-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 16:37:07 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by PA4PR04MB7885.eurprd04.prod.outlook.com (2603:10a6:102:ce::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 14:37:05 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 14:37:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19624bea-06a7-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOx1L9CN5kG9XDgplRvB91ba5HaikVI6Hp8yRUsEJfpBxjqarA3eA/Bwg0XUuvD9xoAoYI+yJnERX3Oh7wlNv+0llw8wx697/JbtHQyKnEA408GtZJJbbMEK4serEkUD8QX6W0Z8S4EaAo6SWiD6VY8O4gTf6RBkKomCLOoGOwdBYZ4Cz0gcaxuyIzSM9ouhFwcmlqgaGPnuOqX8D8CMPJod5QwsIEoRW+c4lpUXs4/Yy4ni8YZ9NOV8j68eb0GYpt4AGTX/nWTwH4SRT0jpJsKm9A8ed5NVeQ51ux2MSa9eHKKyh9tIJgBx4jxx9PdYedzNdmHsBHoPvay/CYNV0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eoHIU4OiRfWL6eSBDEGpHf/53qf3JoHaxC4d8lWaUz0=; b=deLk56bhVuTHNk0x/BpzQJzZmAuTLZkExeNqpoXqKHej/1BVj/t+/+VNI27kvHpCq05YFittPXy17opm/ZMQhYDy7EECa8kIBwqN8w11cSXkx1wpAbzWI6efNxGIevh7vca3IQHD1T7K2KgNGBI5duzF8CifUdORRC0UClPjJc+6GbbY35XqWOSkUjL2QHazwhYXejyo9vSOq+uiOyQPaUfj7o0tu/xkh/PLSt/mJ7VihxtQoT/+ahbRvXDwM1yHo1SHWA2/EiY1wQo+kqQmC8P+jHTHfpkc9R5Ax4dg2kZJz/vcgT0h9V2+2MjltxDzjpVrR+zZAOFkW9PRxgo0Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eoHIU4OiRfWL6eSBDEGpHf/53qf3JoHaxC4d8lWaUz0=; b=wY9qjX2TF4j3HX0zsVcSokIrr9/wTY5vWwG23elphFnjf9muURXRz/T1m61eC84GoACJOtaSg7jQMOXOcD2MkOhYvoCgk3z7MVbZ+c5jxEWeDEk3oAMI+swfi+tfnxFAQx8iw/RVanGNCTOBByUZ74vPUTsA9E2LqqzCizehVnU4qEy41X5bnfO/Z2oV4XvdODOqLDzulAi7T+8l3rOapHCE1YLFTY2A2Ybyo5/CR/09esmf0CZQXPL50Gk1neyeifMc1xdJRGyulTsUnwVyUa6/AfE2uWeW+3sea7a+0yu/e/+YuvBKDSGGKzoqUihL6lBtIyRkywKSsD61bQCKWA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <81dc8330-909c-ad32-6543-7dd3066b3e00@suse.com> Date: Mon, 18 Jul 2022 16:37:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/9] console: support multiple serial console simultaneously Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9P250CA0007.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 07e7c606-0ac0-488b-f42a-08da68cafc14 X-MS-TrafficTypeDiagnostic: PA4PR04MB7885:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 51eo5C0O9sRIDvMagZc/XBbaD1xkaaEkscZmJiLQUNXViN0Bza0bDgJ5rEfv2e8z0GiR2a3ZKMwosZKnljESP10h+C4bqtdoGESJYxZswqI92Gf4q7eIXtgDuga88UEj3c9zBlYXcaCiww1wQDQ+2+Fi7tLVeyaMY0tkmvXfS8h4eZ1SGuA+X/84q5OA1YrNfdapSbD9Xf8d9ZcaWOPjGmT44UGHMkU2qmiWilB//ZTgjphrPQ54IWVu2D0Bo7/s0reRp0k5BVL4W3BfQynEcL7YbR0dF1tHHiujwbqaIujeWnhA8zA0d6J7R/okre95bEoRt/PKp41jz44qn1cx3vZ6bgYsCK6fi6KyOGRmFY/sqfLa82vsJG6AAha9VN7j4pVuR2LNXXwPes2aHmM/r+nPWiHTf3NWliMp/AHLx/hWu70bSRM0JfwRADzEQzmKVprUx4Phs4ruOzaHvOmxaX2k2JzRnXe++AS52MVy8TPa57RA6TND2iXFdBZVXehO3PrdPCXknnU4gNrK+AAeSilvlCO3xpvLSYpLCinRSnccPP9XZtbEq1NY/SjoBliZQTBOfl7jwnRlMT/3ieAbXJDJIFNCDiVkn/80g6Dc+g8FuyWbQFxvV9q/NkLNxAyb9bZ1TYprs02RbmfywnaDDv7YgmLwhoA25zcRnWtLQvIzD27pqn7XzFiVKBKEVzVJjqA5UIdEc56emXteIx7tff4/bBh6wuAXd1+HcJjUMOpPBbumtOiZC/nyyoe76mBA9AvYwZL+LIzcfvorVkDQL5nbTjDR3KjWuZfSnGXN2o7pIEemotzfBON1TtUoea21hZbKu1nBAtHDw0Fk2mxi38a6HBk/G4XVDU5KbnY5LzY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(136003)(366004)(396003)(26005)(83380400001)(186003)(6512007)(41300700001)(66574015)(2906002)(86362001)(6506007)(478600001)(53546011)(6486002)(2616005)(5660300002)(8936002)(31696002)(38100700002)(316002)(6916009)(4326008)(54906003)(8676002)(66476007)(66946007)(66556008)(36756003)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckRySzQ3NDhSUW5kUWtmZEhPWDRBY2xFTGJ2UUs2TWVLei9aLzZmMGhCcTVM?= =?utf-8?B?KzdVdWorMloyOHc2MEREUHFRS0plbXhsL1JpcnI3SFZXVC92dXZPYW40eXlN?= =?utf-8?B?N0EycitQTWMrTjQvK1lVNnVhWHV4b2JydEF3dVNBc0RjQzJYYUJuTGRHNFhG?= =?utf-8?B?WkpJM2trYm9oNGpuWWZOT0NlUEd6YUwvUGRjaGFacVJvWFpzYkppbUdQS0Q0?= =?utf-8?B?YitFYUxtYWlURkJFUzQ0SXAyMVhvVC9aM01MWEU4RjlRWVQ0SThSekhuaVVF?= =?utf-8?B?elZaa1V0Slh0TFFETWViQzlNR2VpSzNZK0tPaVp5RllDUGNoZmtHK1VKOTRG?= =?utf-8?B?UmdyNS9RQytpSHV1MCtFUEZmUk1HUzF6Tk5sVUF2TGJ3a3ZRNkV5RmZJa0hy?= =?utf-8?B?cXprdzhpcVpXRXB0UzJVTmJMVmtKQWp1QkNjVjUyYjVTaDU0SzlocUZkNmd1?= =?utf-8?B?UVp5cUtzTG0yTVRNL29pVEI0STlFZmFVV1NGbWxab1dGMEN4TFA0UWsyZ3do?= =?utf-8?B?YmtUa2xNMnI3TjlSd2NuWER5aEtYd2prT09SOENvc0VpUXRTazlNTGZ6MWVT?= =?utf-8?B?a3ZWUitoWG82K3M2a0h1MmxjdE96NmVPMlB1dVNNa1dLMnB5MmUzMlgxYmhr?= =?utf-8?B?U0NiQU9jQ3QwVnZ0S3pSbEdJSzNnRUwzWmJUL1NWU1BQNG4rcXQwSUtrbG85?= =?utf-8?B?TDlPaU56ODhmSlgzdjExQ2V1N1F4R2xFS2ZPd3QzdlhSM0dBMS9UM2ZFOGZM?= =?utf-8?B?MS83L2w0SjEyRTNSOWtTZWpDSVJvNk0vTHBCOXQ3QUNnb09HbktnSTI4dGFR?= =?utf-8?B?SnIxTUFWTmV5ZWhFRTBtYk9LRk1BOUlVTTZaRVJESHBkTGJ2YXdoK05jdXJI?= =?utf-8?B?NDd6aFlxdDZLbUE5cWE5NGc1U09TRzlDaXh2K3h0NFFRTkR6Ujk0b0JxTW91?= =?utf-8?B?alFrNEF2OHF0YXNvby95UkpnVmFISm5idEpvSDlZWjZWQnFHVXBHRmx0VVVN?= =?utf-8?B?R0J0T2ZNUGJVbmR3T1ExKzZaU01aVlRVdXYrMnQ0SlNETnpvZ1JNdDBwOGU1?= =?utf-8?B?RTNIdGMwY1grVlk1dGZXd2ZOeEpUeXBnWGlmQkdOUVE2OW1LTitseGR3VUUw?= =?utf-8?B?OXBDVklFamlQSGJLRmc5NDRrL3VZemxML25uSERKL1FER2NINlM0VUI5d2Fo?= =?utf-8?B?NllEaTlnbjlxMDRZclV1VDJpV3FjYjR5eTBKMWRyVStuQmdnWmdRYmc2bUdv?= =?utf-8?B?VTFVUDMyTmhtdVNJY0hrWGg0ekZjaU1HU3ZibG1wRTBjZHIrd3llSlRUUE1U?= =?utf-8?B?aWF2K09IVFRQSXQ5eHQzVjhzM2pFUmVwZ1NMNXljT1pqNmRucDJiaCtLbVMz?= =?utf-8?B?T2IzVUFJRDMrMldpR2lNN0JBVURBYW1sZVk3L0lxKy8vODYwNGViN2ZRb1Na?= =?utf-8?B?OWljdU5uSnhLUk56cXBWVlpQc0hacjhGSEw3STZ1THEyYTZocFhzTlNKb2hO?= =?utf-8?B?ZEJqYmJxNXM5VXVuWTRWOVdWS1NQRDlzV3lNeG1nZU1Gbm9LMDZreWluajIw?= =?utf-8?B?enpNMWcySWFoMGlwOVBHT0ZQcmZiM3JFZ0NDaTNSLzZZcE5CS2xpR1lzMHU2?= =?utf-8?B?WUNKLzRrUHJlYTFzaXpQZXRIQW8vOW40QUdsYXJnaTRkT3JXU2JuUkVnZ0xq?= =?utf-8?B?dU4vQU1OVVdFL2xzY3NIeXBPeGFOWldIVjU1WkhPUHJNY1V0Znd0S2psMjJt?= =?utf-8?B?QjZobFVmdW14STFRMCtJMVQyc2ZZdXlHdFl4TEszdllyb2xsT2xvN24zMTVO?= =?utf-8?B?MXpObEF4WmpqMVgvOE1vZUtTVnRzbXBJRDBFSkNPNW1EQ0lGWk4zNGEyUFZs?= =?utf-8?B?UTFSK0gyV2ZqZ3JSVDQ1ODErb0lyemZaYi9sZWYrN21NMjlhMzRGdlZUaTZT?= =?utf-8?B?MjU2eVY0SUVHOFNMc2lYVXFoRFlRQWdEY1BpZ21NLzJiWFArSmJwYWtEVXU2?= =?utf-8?B?RWRVNDF6eXdPS1dZYkI0bXQ2R1k3bmszODZIdE0xclFyaTVGTTUrRE5RbHow?= =?utf-8?B?SFlQRno3RVVIVWUzY3MrWWhFQ1FudWRWV1p0UGIvREJnUnUySncrYlBqSHo4?= =?utf-8?Q?ijhdvrAAitGBnLdsSiawLWXYw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 07e7c606-0ac0-488b-f42a-08da68cafc14 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 14:37:04.9198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VUHnuFnvkSfT2HNDzZGdLYROEkGtnS5cP77zq7kQspuLDtXOH/E3pVTwE2InBsquE2rNI2kCYm/ERnRcCVVGZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7885 On 18.07.2022 14:48, Marek Marczykowski-Górecki wrote: > On Wed, Jul 13, 2022 at 11:39:07AM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> --- a/xen/drivers/char/console.c >>> +++ b/xen/drivers/char/console.c >>> @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; >>> static uint32_t __read_mostly conring_size = _CONRING_SIZE; >>> static uint32_t conringc, conringp; >>> >>> -static int __read_mostly sercon_handle = -1; >>> +#define MAX_SERCONS 4 >> >> Might this want to be a Kconfig setting? > > Is that going to be useful for anybody (who isn't modifying the code > anyway, for example to add yet another console driver)? If allowing multiple serial consoles is deemed useful, then making their maximum count build-time configurable is quite likely useful. People may not want to allow multiple of them, for example. >>> @@ -1291,7 +1322,8 @@ static int suspend_steal_id; >>> >>> int console_suspend(void) >>> { >>> - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); >>> + if ( nr_sercon_handle ) >>> + suspend_steal_id = console_steal(sercon_handle[0], suspend_steal_fn); >>> serial_suspend(); >>> return 0; >>> } >> >> The commit message gives no explanation why only the first handle >> would want/need dealing with here. > > Sure, I can add an explanation. I'm adding this comment to console_steal(): > /* Redirect any console output to *fn*, if *handle* is configured as a console. */ > > So, calling console_steal() is about all serial consoles, not just a > specific one. The use case for this "if" part is gdbstub, which wants > to redirect serial output only if that serial was configured as both > console and gdb. Having proper per-console stealing is doable, but IMO > not worth it (it would require also avoiding duplicated output in case > of multiple serial consoles, and probably few more corner cases). And what if the one handle you pass on isn't the one matching the console the gdbstub is using? While I understand that per-console stealing may have some sharp edges, I don't currently see how we can get away here without handling things per-console. >> One overall remark: Especially with sync_console latency is going to >> be yet worse with all output being done sequentially. The help text >> for "console=" will want to mention this, up and until this would be >> parallelized. > > I don't think it was parallelized anywhere. All the relevant functions > (__putstr especially) write to various console types sequentially. The > difference is that previously only the last "serial" console was used, > all the other were silently ignored. So, it was "parallel" with all > _zero other_ serial consoles, but not other console types. Parallelizing vga and serial likely wasn't deemed very useful, as vga has negligible latency compared to a (slow) serial line (albeit I leave aside software scrolling here, which indeed is slow). There are also no commands involved in vga output which may require waiting for their completion - it's all simple MMIO writes (and hence the slowness of scrolling could only be dealt with by involving a 2nd CPU, as the one doing the scrolling can't at the same time do output to another device; nevertheless some of the latency could be compensated by doing output in suitable order). This is quite different when it comes to multiple serial consoles. > Anyway, both help text and boot warning for sync_console already warn > about it. Do you want me to include relation to number of configured > console explicitly? I think it should be made explicit, yes. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 15:07:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 15:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369886.601452 (Exim 4.92) (envelope-from ) id 1oDSLR-0008C7-CW; Mon, 18 Jul 2022 15:07:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369886.601452; Mon, 18 Jul 2022 15:07:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSLR-0008C0-9U; Mon, 18 Jul 2022 15:07:37 +0000 Received: by outflank-mailman (input) for mailman id 369886; Mon, 18 Jul 2022 15:07:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSLQ-0008Bu-86 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 15:07:36 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a141efc-06ab-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 17:07:34 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM7PR04MB7096.eurprd04.prod.outlook.com (2603:10a6:20b:113::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 15:07:32 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 15:07:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a141efc-06ab-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VUNYLuKVtvPAx2NY3HT7yAKY5y29cooOgoOr5y6Wk/bCHzVEpubaOKcYYVf8djSMhqDX858H38hYNrSdc0PJyWPAIFIRiK842mDkSUFw3NDpK8oriJULsWxopjTVzdpGFlfCJQtaS7zdAPq5iH2AOmeOpAijPMgELoyymPrGWdBsHzezWJ+4mFZUSE1dB5hkvJljE00/3fJorhQCWuIcJG5yU9srR7YaHHY8NktYfTsSjw6jVLxEyIBhakQ6CJ34SxVQlx0Hy2tqbNbsPXV6LKpEEzPSVIVMzsYII9Eii6F8dGhAqJs9rHlM9Pt4mo/NQxxoWQ0M1cJ3eII0OQqcxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cm6ZZa/2Qcsr1jyZkJxTATwz0x7fHthxNCI/xgs+aRQ=; b=anAALyRXXYOTBYx86eSWxfwV3wh45icw6PNTjm4qSE1PNZCePG9nsZ84NymHz+oc5SpqiUlTrjd/HaLLusnNR4ITz84MkzYlPEaTb+G0cuCNz4WQWf1L+uZAplzUe0NYe4GxOUOyibi9sQv3R6E3hBLzCgO1q/Ohkcdn+9ACSEjudC7Z5H8r4SzBKm8AfyjPlBVbbrvep2S/Ad7xGC77HIq3GF8TRcHNNnq8Cd29icoN5wq4Q0qg/EtCx6H5bGV+Ro7pNT7tdp1Iz8Oc1HPAE1VnQQwp41aQ++1mc87tdAmzgCjEBRQoknpGydOAOjxhdKLkVEi4WXKvBRq+qitrCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cm6ZZa/2Qcsr1jyZkJxTATwz0x7fHthxNCI/xgs+aRQ=; b=eX5jkfBnJp4zdrmmxeLK1ZhcjQfrIVWNMW70jjdlj+aeUx8+xggx6ZV+P609xVSgyS7VAIBOaAHXhT9ttlTC6pt+csE05qnFyUwyUrLNRZHfHBArA8LPROKMvB5L5cexOrnbF7qn7R9mpuTpkVhQacfj5i+IH938UFgyEpb5omoPmavzn6+OSsdoMCULo6k0/FKD0Xq2xOCg41uWJCxN/pFrchx3EWnQYalzkrOe/Lf+QwB0rWpR4+k561gVOzT3ZYrcdWXoTEgAlKxbNFgvYf3e+uKYtgkEhaqPdqFM4h3Jpjz+QYqncLTdmqYhmJIh8N6WLE3XbLf0AooMMz6x0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <80726e60-9ed7-fe59-ffaa-df8220d6fa2b@suse.com> Date: Mon, 18 Jul 2022 17:07:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 9/9] xue: allow driving the rest of XHCI by a domain while Xen uses DbC Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <50867e92-8d35-44d6-e10f-a26f35f53221@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR10CA0084.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:8c::25) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2d99cfa2-9196-4ec2-9870-08da68cf3d02 X-MS-TrafficTypeDiagnostic: AM7PR04MB7096:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SDacmPDPUojGpVPORlBN1JFoBZw0X75YXJG5gLlzfW6rkDHKSX+YH3fww+8b4doUuqH4WzROkddy3xpcJt58JUo67v05bQREQVY2esTbExyaCV8rESCqcABawuu63XjnDGYCF8gW56Gk8jOlxfvQ7GVtX3ggisESJz/sOYhUK+zknFLppf/Ezx6jlc/H5qge9c54I2lPRJR/0uqy8MgNDwKhfZkB0kxMw/t2Leng03Zoa2qdjWLeTEMX4pFAHPSXAdPcug7URY/8mTKRKbR5KHjbFNfOuwQ9jdrpYqJT9+Q/mms8uTWen8u3FHn47aeR8xbMGLY3az6lcgeyXU22ZGpQ8BNGQgyO+RtvV9+QgHQi/TYGBnXcLiz2s5p05dZ4ynhd5ePrA0cHlNr6EatoEmOIt61kmBfMuW71jtnulGJKXAfy6pMn3SgP7iTnDgPb8I6VEoiUZsVBHUN3kNWKvREvLjD+S+GNQxXH8WdOz25VLkjdpH6YCyBKaZtSbsgW4ujJ8954YRbMCPAKLxSSFUejEYSAai08SN01AdFmc87YwWx+/Pa89JCbTO6R8guC9Rc0LUJio9njj996jqqfw3rOXdQRFED+fjAMkO+dnSpoo0c/PQ1tZduZ+PVL+NQZ29CDmVMeBZSE0nPwiVhXTeknJl2OefKpaEaEr8TsuhqDmaBEmUpDSYeEPKh8SJkvlBX+y25MsinELvoA/gYHE3cpcYcSUbndeI5zX+6A2/ia/XlLO7WGJYn0h9k1UxWFXq3zzgo14iPJlBIA7iO9PJFKhf7I+bwmqsMl942pbc0byVzDsNmwEeAZniYFPeJ7N0brydrByIlhu3r2Hw8gDBtOn+4C0W9kiu4Jv7ovEL0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(136003)(366004)(376002)(26005)(2616005)(6512007)(53546011)(6916009)(6486002)(6506007)(54906003)(478600001)(38100700002)(41300700001)(83380400001)(31696002)(66574015)(31686004)(2906002)(8936002)(36756003)(5660300002)(186003)(86362001)(316002)(66476007)(66556008)(66946007)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXEvNEltRDZaSkoyTkJDTjB6ci95d0RaSWxMQkJhNnBFRjk0TW00OGprYVIx?= =?utf-8?B?Z3QyS254dFlJUVZCck4zTS9ES1ZObTA3YnQ1TDVkaEZabmtyNm5aUWpDaCtX?= =?utf-8?B?WlU3OXFhZ3VKM2plQlI2K0NQT21ueVIxNDR0MnZZU3ZkK0phZFY1aVRxVmZQ?= =?utf-8?B?OCtTS1M3bi9KT1NDR1U4NzVqangyRUNPaHVCWWZvRWFRNkhrS1lZOGkrTVVC?= =?utf-8?B?bEk1WmtSZjhUeWVvRnFyakh1WHVrbGdYOWtheG5YYWs5YUxYcDl5S2M4ZSto?= =?utf-8?B?d1BRam14Y0hmUHVXVTQvUHpQellIYlEzdnFaektEa3RmampycWNvQUplY20r?= =?utf-8?B?OG9lRjY4YXlQeng3Z2RuNmNDTnhGREt5R3YzZFpjU3RZUXJBZkNnOUo3Z0Vv?= =?utf-8?B?cEFKM3JlUXV5MVRNLzJheTYrcm9hZzZKOW5CRlVwSGZkSFBiMUxicnlZTlFa?= =?utf-8?B?bEtuY3hvQVhpUmlaQzloMFRkS2ljUVoyQWJYWmNDeVR2cERUQ3dMWkp0VXN2?= =?utf-8?B?cEZhR3lVTSswVlpUQm9SRW1Ta2NGcXUyWXViS0xsaGdsT1VLYWhTelk0R0VM?= =?utf-8?B?cWZ6eWt5QW5iMzRyMFVkRjlvT1JPa0pWdGlWOGN3RnluMm5ndXhObUd6ejlM?= =?utf-8?B?R0xiVC9aNnBwcmdiVlBUa2tKdUFtbVVOOGFBZ2paS2tvb21MeWtJUjVwSXp2?= =?utf-8?B?d3I3N3lyRUNESzNjclczUDdyQ0RTajM0b1NTOGdqVUpNVThIL2M2M2R6QTMr?= =?utf-8?B?ZmxITGs5aVNXT0hETXVSQlNhSGVUaGpBS2cvdXlLQStkMmhrdWU2YWtXbWFM?= =?utf-8?B?VGtvZ2lxZ1o1b0pldWpJOGxvK3RkZndDdHc4eVVvOHptUUhobUFZcHBOM2VU?= =?utf-8?B?eWY0c1NXakJuVzNCTWxNbFluOEUyYkJyUjhPak9aRXUxQjhSVkp1b1hyeThK?= =?utf-8?B?eGVXQTVaZUlyK2Y3TUVEdk0vUVNIb2JMay95b3FHVUJqUVZoQldtNzQrSFM3?= =?utf-8?B?TEtBekZEQlh0QXpERy9KNlhvZyswKzdCQmtRbFp5Qzh2akxBL0lzZlNmZXpC?= =?utf-8?B?T3Fya1MxeEdhcUlCQlNzY1lIM3BWUXduMGR2TEY5WU40ZzZNWWdGemNSS1R6?= =?utf-8?B?M05uMC84MWR1ejVpcW8waE5HWUxlWmJvd2NsUXI0Wk9PS0Q5RUo5bXczTzJm?= =?utf-8?B?UjQzZlFUMWlDdnl6YmlxakFYaUk5YlY0eGgvdGgxV25GalVOVDZ0cGJPYU43?= =?utf-8?B?QTdWVkNHUUd3SjRWdmVyZmtUN0F3Uk5KY3lNU3RJQWN5NnNVQUY2eW9hTUdL?= =?utf-8?B?RkhibEI4alR6NTYveFMzdjBGdHNnaDJwSU5TS1ZkVitraUpveEh3RlZZVGlk?= =?utf-8?B?UnlTeDJFZTkrQVQxanRxczVPT2Q4ZWwzUFVpODdvMFoxZnJnekVlaUFMVjZW?= =?utf-8?B?U0VnQ0ovRXJJOURPS2dneS9Rb3BJM2x6d0ozUnZWSi91eDBRK1RWR0tXTmxW?= =?utf-8?B?Z1NpYUpHMzJ1SWdLemEweVdWam5NbTNncGwwYUhSRTh1QWwvcnhNZldnTjRu?= =?utf-8?B?alFmaHRJcS90OVFxNTMwcTNDZnJ4bUw4bElNVWltdDYxR0poa0pQOUFJMHJG?= =?utf-8?B?VFhkZFNUaG9JaFArZFduV3pDSEg0MVpwWTZWQmZEakovblI2VTl6YzRZenE5?= =?utf-8?B?bGgwSUVxc01hMTNnRENrVlRoK1JVMXdEN2JTcnErZW1VNElFSG5wSjNLQ0lG?= =?utf-8?B?TFRSYU4xUitMNU80N0g1MDlUWll0Qko4cGJBZ0pmRTRlanF3SFF1cmtoK1Vl?= =?utf-8?B?Y2xYelMzWi9Gakl5NGNybVJDdjIwZHB6QWxvZHFEeEdQS3ZPelJVWmNKYWs3?= =?utf-8?B?ZGkvUjdLc0JSeFJlVXdtMFFiQ3hxbXFkOG84OHdZTm9YT1FucWRQMkMxYUxz?= =?utf-8?B?MHRXOHMya3JjaE82LzhhWmwxaUlZR1YyN2EzVzNibzZIdHVLVnZYOCtWUXdv?= =?utf-8?B?QVRvYlpxbHI3TVlhWjU4WGVEcGlKYXk5djNxTEp6UXdaWGxadDZwQkJkMkZo?= =?utf-8?B?NWcyK05Gc0Q3Y0txS0loU3M5Rkw4L3lTQndpZFJSRUNINyt0bzNsNTlSeFFB?= =?utf-8?Q?SqStCOeCIr+2eUJZ2jbriO3a3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2d99cfa2-9196-4ec2-9870-08da68cf3d02 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 15:07:31.9008 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D37oUlxbl3iJ0f9TOeiiK4nPc0NMWmcoOWONiQFcThuxJa0SK3jfrurI0wnF4o2FbJbW3t66dyrvedsGOSRorQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7096 On 18.07.2022 14:54, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 02:06:07PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> That's possible, because the capability was designed specifically to >>> allow separate driver handle it, in parallel to unmodified xhci driver >>> (separate set of registers, pretending the port is "disconnected" for >>> the main xhci driver etc). It works with Linux dom0, although requires >>> an awful hack - re-enabling bus mastering behind dom0's backs. >>> Linux driver does similar thing - see >>> drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). >> >> Isn't there a risk that intermediately data was lost? > > Yes, there is such risk (although minimal in practice - it happens just > once during dom0 boot). You can avoid it by instructing dom0 to not use > that USB controller. > Having this capability is really helpful (compared with the alternative > of using the whole USB controller by either Xen or Linux), as many > (most) systems have only a single USB controller. No question about the usefulness. But this aspect wants spelling out, and it is one of the arguments against allowing use of the device by other than hwdom. >>> To avoid Linux messing with the DbC, mark this MMIO area as read-only. >> >> In principle this would want to happen quite a bit earlier in the >> series. I'm okay with it being kept here as long as it is made >> very obvious to and easily noticeable by committers that this series >> should only be committed all in one go. >> >> Also along with this is where I'd see the pci_hide_device() go. > > Earlier version of the patch set had pci_ro_device() before this patch. > I can add pci_ro_device() in the initial patch, and drop it in this one. Having pci_ro_device() up to here sounds reasonable, but then you still want to flip to using pci_hide_device() rather than just dropping the call. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 15:11:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 15:11:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369891.601465 (Exim 4.92) (envelope-from ) id 1oDSP9-00019a-VV; Mon, 18 Jul 2022 15:11:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369891.601465; Mon, 18 Jul 2022 15:11:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSP9-00019T-QK; Mon, 18 Jul 2022 15:11:27 +0000 Received: by outflank-mailman (input) for mailman id 369891; Mon, 18 Jul 2022 15:11:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSP8-00019J-EA; Mon, 18 Jul 2022 15:11:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSP8-0000wO-Bh; Mon, 18 Jul 2022 15:11:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDSP8-0003xK-2i; Mon, 18 Jul 2022 15:11:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDSP8-00032O-2D; Mon, 18 Jul 2022 15:11:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3Fj5uakjzHJXjvoMJ7YlgLnveVuneOPsICrtdW1bZ40=; b=UNz3MpsjhJv8dRH1BGd0Yjqrl3 UbtpRax3D8lB5uHS5PKk3vqg/YIIFdJntW2jt84iX56uNryhYv/EPzSXtPuN12E8efivaLth3ceB2 e8XBLD7ejH5Dp5PHmMHcMLzzsYI5XYlZG+3gxshNDaG5imVSsysi1DQ2MibnTf1u+e2M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171668: all pass - PUSHED X-Osstest-Versions-This: ovmf=fc4a132c0e9d108d30115cb8729f8fcd5564b855 X-Osstest-Versions-That: ovmf=039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 From: osstest service owner Date: Mon, 18 Jul 2022 15:11:26 +0000 flight 171668 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171668/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fc4a132c0e9d108d30115cb8729f8fcd5564b855 baseline version: ovmf 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 Last test of basis 171659 2022-07-17 07:43:05 Z 1 days Testing same since 171668 2022-07-18 13:13:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pierre Gondois jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 039bdb4d3e..fc4a132c0e fc4a132c0e9d108d30115cb8729f8fcd5564b855 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 18 15:55:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 15:55:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369908.601503 (Exim 4.92) (envelope-from ) id 1oDT60-0006DD-GH; Mon, 18 Jul 2022 15:55:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369908.601503; Mon, 18 Jul 2022 15:55:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDT60-0006D6-DQ; Mon, 18 Jul 2022 15:55:44 +0000 Received: by outflank-mailman (input) for mailman id 369908; Mon, 18 Jul 2022 15:55:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDT5z-0006B7-2z for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 15:55:43 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11ce667a-06b2-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 17:55:41 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 11:55:36 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MW4PR03MB6380.namprd03.prod.outlook.com (2603:10b6:303:11f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Mon, 18 Jul 2022 15:55:35 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 15:55:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11ce667a-06b2-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658159740; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=MSI97MrQotepVKNN0FluTnsWY1D418cR39DIgXmWB8I=; b=P+v2dKnELucLYoFbWLbQ0x4EUU2V4+CCnvO5Anu6fIKhwfRKQi30Fj6X oqUFSbYZsHzeBqwYmICen1u5bMGVksAgFdp6O0qrBbQxqmTLrAdIZXts2 jBdOvnY5WkFaA0E8RLf1nVHij4CUrEHT7RxMHLc3Jl7jnYZLWvLk91+/G A=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 76052873 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:PY7ZUaJk89FUfXZFFE+RyJQlxSXFcZb7ZxGr2PjKsXjdYENSgjEHn WJNCDqAM63ZZmGmco1+Oti180NT6MfSzt82HgplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYjdJ5xYuajhOs/3a+Es21BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE2P5LM34OY6gj99lpEHFit uQJNxMscUXW7w626OrTpuhEoO0GdZCuFqVP/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11j+mLWwwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPBkWffoi337gPJtSjfetItEqaDz8dzhUSYy0YOOQELd3Lu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9WopWm1876VqXa4P3gTJGpbPCscF1Jbsp/kvZ05iQ/JQpB7Cqmpg9bpGDb2h TeXsCw5gLZVhskOv0mmwW36b/uXjsChZmYICs//BwpJMisRiFaZWrGV IronPort-HdrOrdr: A9a23:4bZ7T6Csvic8zuDlHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76052873" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Le7jHFR8LkExmaXEczkH2ZMbTWF4s38b0uv/G3Am6cuoyyXpCtFvBzqnBcpz0i5VHqW/SHpOqXpj8wuywUMZaG5WpBHSnkFobT3m9ReB5ObWL15tWxa5kcGUfZbon4EnoGQ2x7uWjvtmBG1YYYvIYDc/JiEzCXw9HMf8WpjvVHsAV4gWcspyUkGEmPHW1FX+rwFW6kcnJaODVR8pbQm8PZPAGHElrwlVGjf1AdzxhsG2kyBDU/ARNAJwtnU1IOkM+1O2XsAZsy584/L4D1BpXMEFqxng8/1uPtthIgXo4RhEskwWSMMXdrapT9tUEo+3hv62wzR5hN0y/yidX93eBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MSI97MrQotepVKNN0FluTnsWY1D418cR39DIgXmWB8I=; b=L3w7iSEiUIbsQKeE1qpDp4Mfi8L+2L0af5YLYLqEqq+bHMSXu5JO3uu70QARx1Mz1EuZ5LDOx8WBV0sUX4DqxSgnHZA6jMRMHmoqz3ALtL+QT8io/qvL/FprsMDHkLpSuVibX75t3/2YTXCFJzi56a7cstFbY/76XO62mIPSV/KFYyGhPHTMpGTS4zQddQ0NJiAoOO6FYtQW+YqrW6Bb+rcr9Xau5OUpzkTUajbYMJhhVx7x5Az4Ig9iiAA8OPpm98tnhw1Uiz1RJLGcOt1CZY2tF/SWs6oNnQrMhwEsJZlYXnFZhWnFDJX+VAnyxDhmzDsITf2F/neecabPF1E69Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MSI97MrQotepVKNN0FluTnsWY1D418cR39DIgXmWB8I=; b=pTftVUbRpzVR2tKpuLST1wy1d08E/2XV9QInW3i9y7I3nuBRW9VKrsuBCInVOPZjJVHPDm6OTmnr3DPv6YUup8ODQEwg148rtLQQvWT/O2RIPqHjTFy4gLf71b8Vud/XJtdJ8clpReLjphmXvWLDS3w3c1Ia4Uu69dfJ/Q/UP1M= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86: log non-responding CPUs in fatal_trap() Thread-Topic: [PATCH] x86: log non-responding CPUs in fatal_trap() Thread-Index: AQHYloTvaSPt93x0vkCi/J1tzLTyAa2EUJcA Date: Mon, 18 Jul 2022 15:55:35 +0000 Message-ID: References: <3b8c5d7c-ee0c-dad6-8659-5b4b339c2358@suse.com> In-Reply-To: <3b8c5d7c-ee0c-dad6-8659-5b4b339c2358@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cd87c3be-6bab-4fc0-d707-08da68d5f39e x-ms-traffictypediagnostic: MW4PR03MB6380:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FD4B7N0o4WZTl+Fzu/yWw6uDHNc0fDdQfiTTy7PPLiVA9f9P1jqIxM5wo6lwjtzME/8h2cFVhV1ckOwpzXRqi64/5lPj2CY46zHAS31uO7srAE/em3K4dBDlOhQ9rYU8HQ7X5z+imD1QjnYJHlOOQr5pcx/ZqQblRnZ431GB5AEwZhEkfgJZpeSg7e334Hm6w6AxZW49dRh78AW5NgyZA02wDpAT45zLye2AFwVQe9sosNjRZJWH9sZynpYz5w5LSdiXMjnlHt+7qc6rF9P/YOXEJC32s3fJagc5O1/RxGaR98Pq0yLKE2IO75+jP5r2Lr2E4MoJzYBbcZ125MqqYeuxw1ODRIhiv6TOmhwOQ8Zz3N3g+Zcvua84aPWxVgzhA6ZYErU5BEQ4vcRQ1GEH8j009ASmrWK82JNbq9uxjMIJlkeL+vl8Tkb1CXTmg+b3j4Bwhgcfs6eTXveeoeICbpslSsymCjbGhDSjH9qaRtu+6gp0a57PDrYF5IWzjbSWrLBMQEpso5hJFz+9u6Q1jd7pRVcOOcMTHODEmNj3cfO7fn3lPyccR2P3bqnIiPvq/UapXmIZ/ii+YdFKByiSuEjXko8fyAOxccskvoCUfwUBHaO3sTwZmMKalKx+PVGGbLX0Jee04787XJTTs4v/+XvaZ/JrjjrXTuCkrJQ/ZHgczJ8/PwXHCWRNdxGdNi/rDPUQ+fVhpH7Brq1khWiMIts4j1HlAIvF+UJJ80hJHy5SEnnB2/0RZjcy543XohfOxMVNo/YM6NrMr4fST37STmv9r7IiCTBEtnv7ljcHIc3Rj6129kQQptgNX9QnPA+IW/0ZrJdURBPwVLNB4DthVl4ATg63i13k4wLFfemJYKVdruhuJADVlOZ7XGO4WE7k x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(346002)(39860400002)(396003)(107886003)(2616005)(186003)(31686004)(41300700001)(6486002)(26005)(6512007)(122000001)(5660300002)(2906002)(4744005)(478600001)(71200400001)(8676002)(31696002)(66446008)(66556008)(66476007)(66946007)(64756008)(86362001)(4326008)(8936002)(38100700002)(76116006)(54906003)(82960400001)(316002)(53546011)(110136005)(36756003)(6506007)(91956017)(38070700005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dGZvSTZrclhmY1dLamlUb3JLVU4vZy9qS3FWRHFQYjVHMmJMUFh0SVVHellv?= =?utf-8?B?M282cElib0hzeWYxR283UjZlUzR3bkc5RWFGcHdOZmcwWlVla3ljTWN0NVQ3?= =?utf-8?B?R1E1aWsxRVIrV2Q1Z2Y4VCsvUlVPdFIyczhzSitaSkk2SmE0ZlV4WmZHcHhx?= =?utf-8?B?SzN5QkgrNis5VzNUR1dQK0Q0TnNSTExBZGo2WVNucTRsOTJ0NDlWSFpTOW9E?= =?utf-8?B?c0M3KzZVYTZxTkdvZDdsNEtCa3ZJVnVBT05WaXBzVTlBUnJyL0k3eFk5elM5?= =?utf-8?B?M2FUeHhOWjFOS1FxK1FOTlMzakp3Tmc4aWZ4emRnOWZubDltRzhUb1M1S2dC?= =?utf-8?B?U2lrWDZocE9HTFk0eFVERTdhdXJGdUQ0VXZOSlVmendlNitDem1uS2cxcUlI?= =?utf-8?B?QUdUYlN6aHF4MWtUSFhyNmN6dmVtLytsZ242bUpOMjkrN3g4b1QxZC9kRGt4?= =?utf-8?B?ZzUyRzhtZjJ2NnJlZ0NYRXdnZStqWlhWODBZUVZiOU5RTWpDSi93R0dNdllB?= =?utf-8?B?Nmk0VC95aXkrTlZHVkxKWVliWjFwNWJZM1hyUVhvSVJJVS9taGdWbi9GOHdI?= =?utf-8?B?endjRHJXdnVlZ3dwY3RabTJjRUhUSFl1ek9WM1B0MFBka2ZxVnNwUjZsaDVx?= =?utf-8?B?WndWV2c2aWFYWm9neEFnejVBdmF6cVNkYS82UHBoZGRUVENtTFhXY2J5ZEps?= =?utf-8?B?T1FCMjFsMkhFUFQwbW5jNU1Pb01FZXNVT1AzTEhDR3ovc2ZRclUwaENUdXZ0?= =?utf-8?B?V2NocWYwdjFudW5NSGxlZlJLdFRBVTZHeHdKQnZOa1ZhUy9CQmVmdTVEWFAx?= =?utf-8?B?YXBXbjd2QnJ6RjEzMmtnOGJXcDlpdk5NTGZpb3dOSldIQzdsYkxVZWxtdDZQ?= =?utf-8?B?NXpFV3F4YUZ6Zmd1WnVHTVFmd2NEem1lc1o1RU5DOHJHM25RUUNGelMxMDBa?= =?utf-8?B?QStLdEJTTWVkQ0Mzb1dtcWNyZWNOUEtPa0RkOEdjT1JWb0VjaFRuVFhqUUow?= =?utf-8?B?UXl6ZGZwenQ1QUZGeGlxUnMweWw4WjN6SHUvS1E0WEtkYjYxR0xkQ1haNHpS?= =?utf-8?B?aWdzWW9wb012cXFJQ0Jqamh2TXoxWHd5WGhmOWVTakc4NVZabml5RkRUNXlC?= =?utf-8?B?ZTBTU1FQVkVBOXhLNlRhakZsYXAwM0ZEZ0I3YnJyRTZKUjRaL0g4eHVJdFZO?= =?utf-8?B?Zk5mVUEyQ2U3aCtIQzM0dEJHZTZwTDlBMHN6aDZxeUMxQTI2a0czdkVjaG43?= =?utf-8?B?WXhjRWRubm1jRmdCemRjenppanp4MFpSNldLczl0TUZKN1lZOW1IZmdTZFh0?= =?utf-8?B?ZTRvZ0w4MnBFWFpuVUhxUUlzWEVDVmYwRURVT0ZCaXZYZGIrbThQNDRqWjh6?= =?utf-8?B?RCtTZjBPN1BVeGduUUYzRVRweDc1bFRFVWsrc1hMbWVueFJzcGFiK3pZVkkx?= =?utf-8?B?VktCRkxVVkcwelR2bE1teEJzYnZLS1ZDWFFDaXVZamRVTTl5a0NsLzh5VnpH?= =?utf-8?B?aWUzUTh2OE9YWitZWEdHdDB3RlRhdWMzVHkwUlJNNFFxejN3VDYzR2ZyN21J?= =?utf-8?B?VVFoNDFQa2diQmtEL0VwUmVla295TmxtUWtaRnl1MkRIUjdaaWRZSms1WjdG?= =?utf-8?B?ZVJ2M2NKNE9va0FneXNNMldmUTVTNURpM2g1ei9jeXg0V013VlhNVnZDa3E1?= =?utf-8?B?U1BkdVZ5NDNkbFBGamZMT21DUGlueklBUWk2OHBSTWZMSkhlMTVvZGFsMkN5?= =?utf-8?B?VmZGSjloRjRMYVdUMk9iU2NHYysyQWJMckVrUVRNbVJYV1hPOTM1LzlibkJJ?= =?utf-8?B?Z3NQblFKb0d1K3AyS0N5bzBqdGpmbXVNeUlic2FaNWp6TGsweVNOQ091TnRj?= =?utf-8?B?eCtrcGN1OG9rRVVsQXhqVnNmRG1NRXhFNE8zZXppSWtlNnZZeVloQ1U0MThI?= =?utf-8?B?VUp2ejNmVHJGSjdzcTFIaUU2VzFTeG0xbXQxZ2NON2p0dDJqdHRzeEp5TGZl?= =?utf-8?B?RmFXTnZ0RHNBK3d5WHVDVFQ5Sm9nZVdidWRrOGpjUHRDSkNQL3crdzJoZ0dm?= =?utf-8?B?M1grMFlaL2M4dTV3UjQxU1JWS1N5TjBvWUxKK01JWkJtbXRaN1VlUjZaZ2s3?= =?utf-8?B?TEQzdyt4WmJyNVN4K3d6YThnSENWZmJJY3JFdkYwQVJqcHBxS0h4SDFrdWJa?= =?utf-8?B?THc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <0A1357AF39ECF44E968731974C0886E2@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cd87c3be-6bab-4fc0-d707-08da68d5f39e X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 15:55:35.0317 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jufGTmXmmqaMgN53NvD/+IDTFJuilMPmoj5gUXzfzkylFP6LeGmvNpb2THuJmSlXLAvbTw+mmbNZJssPA/3xXEUtIoAurqQqprFQUbIIG5U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR03MB6380 T24gMTMvMDcvMjAyMiAwNzo1MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoaXMgZWFzZXMgcmVj b2duaXppbmcgdGhhdCBzb21ldGhpbmcgb2RkIGlzIGdvaW5nIG9uLg0KPg0KPiBTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+DQo+IC0tLSBhL3hlbi9hcmNo L3g4Ni90cmFwcy5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni90cmFwcy5jDQo+IEBAIC04NDUsNiAr ODQ1LDkgQEAgdm9pZCBmYXRhbF90cmFwKGNvbnN0IHN0cnVjdCBjcHVfdXNlcl9yZQ0KPiAgICAg ICAgICAgICAgICAgICAgICBtc2VjcyA9IDEwOw0KPiAgICAgICAgICAgICAgICAgIH0NCj4gICAg ICAgICAgICAgIH0NCj4gKyAgICAgICAgICAgIGlmICggcGVuZGluZyApDQo+ICsgICAgICAgICAg ICAgICAgcHJpbnRrKCJOb24tcmVzcG9uZGluZyBDUFVzOiAlKnBibFxuIiwNCj4gKyAgICAgICAg ICAgICAgICAgICAgICAgQ1BVTUFTS19QUigmc2hvd19zdGF0ZV9tYXNrKSk7DQoNClByZXZhaWxp bmcgc3R5bGUgZWxzZXdoZXJlIGlzIHslKnBibH0uDQoNClByZWZlcmFibHkgd2l0aCB0aGF0IGFk anVzdGVkLCBBY2tlZC1ieTogQW5kcmV3IENvb3Blcg0KPGFuZHJldy5jb29wZXIzQGNpdHJpeC5j b20+DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 16:09:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 16:09:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369916.601526 (Exim 4.92) (envelope-from ) id 1oDTId-0000EV-P1; Mon, 18 Jul 2022 16:08:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369916.601526; Mon, 18 Jul 2022 16:08:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTId-0000EO-LC; Mon, 18 Jul 2022 16:08:47 +0000 Received: by outflank-mailman (input) for mailman id 369916; Mon, 18 Jul 2022 16:08:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTIc-0000EI-Ch for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 16:08:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e4dcd6fa-06b3-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 18:08:44 +0200 (CEST) Received: from mail-bn8nam12lp2172.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 12:08:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5803.namprd03.prod.outlook.com (2603:10b6:806:116::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 16:08:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 16:08:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e4dcd6fa-06b3-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658160524; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dks+5vapLIntahKliyHNh8FCP3DBhOVe02YFjtbFDYw=; b=TYr6TlzInmdgQdGXjfus6LhRRaXXadCIlbTw1A34VsntWHRzNpwkLc8A kFN+KnKTOUM2C0Y7kKD4oCMaqtNrwCJ0xkSYnmMfJCrVWvFPXISsMxeBg +X4Fdx01jDPrcLUqZiZvdi6/7tsLRtpqQvHGmXQll++dOGM964/KgJjnq E=; X-IronPort-RemoteIP: 104.47.55.172 X-IronPort-MID: 75868735 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:rtQJSK9XjnnzKTWFzM4UDrUDmX+TJUtcMsCJ2f8bNWPcYEJGY0x3z 2UbCj2COPfbZ2fwcoogYNy/oRkF6p/VytIwTgU6qC88E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gVaYDkpOs/jZ8Ew27Kyr0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGV00kYpxEx6VMCkpO2 +YBBABKUVeRvrfjqF67YrEEasULCuDOZdlakFcwiDbTALAhXIzJRLjM6ZlAxjAsi8tSHPHYI c0EdT5oaxeGaBpKUrsVIMtmwKH02T+iLnsB9wj9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WXYoiz82bSS9c/9cL4sNoW4699uvHO4zTchAh8EUFqD8dDs3yZSXPoac ST44BEGr6I/6UiqRdnVRACjrTiPuRt0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2 TehgNfBFTFp9rqPRhqgGqy8qDqzPW0fKz8EbCpdFw8duYC8+sc0kw7FSctlHOitlNrpFDrsw jeM6i8jm7EUis1N3KK+lbzavw+RSlHyZlZdzm3qsqiNsWuVuKbNi1SU1GXm IronPort-HdrOrdr: A9a23:uwt7Uqq/D3z7rhqU8VUkRPkaV5uIL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInJy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0aVjcVaKv6/VQIO0aSSAWUR4Z 3xStAbToNOAkbqDyOISN3Wqk/dOXgVmibfIBSj8AbeSITCNU4H4ox69Mxkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pWVFZ9l/1pwKpuKuZ3IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkcoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWuKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnieffFmHKc7hywlbF/NLQgFkPsulqSRkoeMN4bDIGmEVE0kldemrrEWHtDbMs zDSq5rPw== X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="75868735" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4FhH+cWhO0+v59k/Qla1gHmbybzowQQ7f+WpjWskM5Jd7BoKIFj0dxoXirioUa3Ry2sN+oJhSHmiMXrxcZvv2PTt5PIbAhFXilGP1Uf4IGUgApTV0sHJEICHQKPbhaX0obMGtoIHAVkpZhGU8GZCZpn2FhyFMuPNSJBpl/GRNj01Vsv18XljNM+p2if1UnD0cgomKxZ5RgHYDycQxPB3eyAvalAlfy8WWnO6YnQxWnjJB5canOqb2Ctd5Kttm3G9+N6PbN7zbM9w2srCQERJWq6PpqCaMeH3jtraJ5j3KgMqUBDPZJwXoRVboRBeBgF9jsk200tkXmmsGxDeKTBFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dks+5vapLIntahKliyHNh8FCP3DBhOVe02YFjtbFDYw=; b=N7S7nKdiDujRtvadHAFuTjGWbUe7YxHE4X6V3RHL7q6jCuFPJjYwsVfREVBHFqRgRoOByso3BOiT4fieHI85QnzUtNp+hhViFCYDDuNW7iSv4m/LsnsLyaXwG8pWfyrREUNXotMK8arVOGi2EqYr3EeHQHkLm+H+ka2JyP2LZnSxGN/6aI+Ffd5wGfGT8fOey6bTPlUFEJltFPZ+8P2J38tZz8chGsJp+w9A7kH4U201oePaXvsfp8NniZg3Az3+Yccjb56ZFer8l7DSJDj5faCze8/uN8ERbLdH8Rnt9sM3c5AuqCLz5KWl6FYgwSM2dmgsqtZ0vPZ02kZigLE7Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dks+5vapLIntahKliyHNh8FCP3DBhOVe02YFjtbFDYw=; b=neNSa1a4GMNKZk/y8j6yeay/jpXruwoBxV3hs/KAaJZ8L9kQ/7Nh8jr7mgY0iOKnuEH2nHyRe5NdQWWdqjswzA7/71mXZkB9zMMwu48QbOKjj4ZotX80fGWpc5LDZHd86SMX/4WRxhGbmnwCCPuZYfKtXgE6e640NfuJuzTYdR0= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86/spec-ctrl: correct per-guest-type reporting of MD_CLEAR Thread-Topic: [PATCH] x86/spec-ctrl: correct per-guest-type reporting of MD_CLEAR Thread-Index: AQHYlo2NnhZbWocHg0SlwcRpU4+es62EVBOA Date: Mon, 18 Jul 2022 16:08:18 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 98031e47-2f70-40b3-7609-08da68d7ba93 x-ms-traffictypediagnostic: SA2PR03MB5803:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sCMlqmC02rnAHNnAzyLN7anB6yGu4n6xN+KW8/nbSXDZwCmrphhi3gBlxR0DKnOBvvK+VG8CoSeZUy+S+hg+vj4r7s+dU1C5qbrQ2WCpe6APpZG0Vbc9jmXR1zIO6UjSKUDReS17tHmMvVDDvClxY+wkBLiTcfA1MmRA9dvrON6bCIz0OKjvq5sssKXGcEYu8wc9yefAW302/n4H71CGAbSwMWlJ9tSr/ISq8F8u0VeSSdJ+YlpGs7QRdMsaSI/AyWh3YacBzD3vUpqyH2RFhohWPvAAX/DKhkNjFPFZs7qjMGrjcjLtMDkVc0IIbQq09P38pOTw7P8n4mmg/63y0N4+8TbirF1q4I8xrzESsVOwcQM0JCcm5f9of2rLcITacFcPvH1KoSESywBJYeVuVXV/zlfv9z+fDV7Gk2Gytmm4tB2J+XSwAo5Fx9pT/m4w8oc+OqcatlQIdI5Gi/uChP7vCd9zn8LyiAB1F4TeU+rXNvwWl8QMJKOk+1lKYxx022YaVltpd++jdWfpf3df0EG0/IXJt9urM5UJGBwyQbF95wIJSk6JUBO7ZyS5g7EAs+6rYIe6p0pfDgRQj3FYpVdzRjWk0r6saMr9bmQjR2iMvEFkrcbSp0qb2wCvAtAE/kf761SJQWvPVxjEgoxDOD3qFDTXQ6sWpb8FAv34y4gTq4p40SX61XzOmu06oWWiIVuMSW24sit1rnG1LO/XZk6ArOtKh3SgT7xAxF78WS+KVNUypV5uDqQEpA0dAYK0e5Wzy/GWmE+iGNans9mEVxsMCuCDCUfpHitTKduMtJD1kyC8/4Jl3jaiSsgE41jhISvkJzy/5BEfFgOyqhDcG7Gwvd843GlZnS6EfDJyaIgB4Hdoee21829/HPf173a2 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(478600001)(6486002)(41300700001)(31696002)(6506007)(86362001)(38070700005)(54906003)(82960400001)(316002)(31686004)(558084003)(122000001)(186003)(83380400001)(107886003)(2616005)(26005)(6512007)(110136005)(53546011)(71200400001)(66446008)(4326008)(76116006)(38100700002)(64756008)(91956017)(66946007)(5660300002)(8936002)(8676002)(66476007)(66556008)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?b201RENiL2NrbmEyZXB4dTIvaGR5eXI3RUErVkw3dndNUmI2TVAxc1E2by8v?= =?utf-8?B?ZkhRaFJGQWdETXpHd2tXUkNINmNJdHpPVnNQK1ArTU9NWDlYa2F5dUtzU2lq?= =?utf-8?B?NUtUSklndmhJSXpzTG1jeWFZaWJhbUFzQTl6aHhPT0hSS1R6bWZXZU5tZlFO?= =?utf-8?B?dnY0VVZxaTRlRVA0bUhoNE5xNThKd0pkVy9lR1FUSW5rdVo0bld2c1BMUjNJ?= =?utf-8?B?VkpTbjZyQmhucjhpMk4vUHZNREpBOVlMWFMwT3pGOGFKa2dueVJzR0UrKzl6?= =?utf-8?B?UkxRcXhrUHlZa3dkK3NlWk03ek96QStFc2NJNEdEeFNqRmFFeVp4NnE1ak9D?= =?utf-8?B?MDVtaStqVkRqeUR1MFJlam5UY05vaFpoa2hHQXR4Q3cvT2R2OG01VDFuVXhF?= =?utf-8?B?MmZMUXhjTXNheXBZUGhTQXdPclBEWm8zVjR2MVBNV04yMENCYUk2RGx5OHVp?= =?utf-8?B?V0JpSFkwcDhSVGNXc2NHeU5PeEVrYjdxU0dMUnVFbTAyZyt5M0JiUG5jUXRE?= =?utf-8?B?enlLOXB0Zkg3VEFPdk1xN3ZJWVJmdm13MHZkOXh2cVk4L3VjaUNRTmg2SFFH?= =?utf-8?B?dkkwcGtKajhvWXRaWWJWVytlN2UxVkViRXFMcStENmQ1UlVYdWM2Zzdqa2FK?= =?utf-8?B?cXR2akFxSnUwMTBOYzR6UTc1L2x1VDNPalA2VGo2bUhTcGJLeGNSQmpBTEtp?= =?utf-8?B?NEVkUnZyZWtrbVN2azVHbjFsNFVYU2Rmc09xUXlSTXpLT3VjbG9USjAwd1I0?= =?utf-8?B?SjJCL2x5RGhOUnlSSGlhNVg2U2FPQW15WktvdVl1TldKQzhSMFUvOHZHUXYz?= =?utf-8?B?Sk5zU1VKN2F3WE56ZUxJUldsbG5IcVBVQ01UeS9uSU1ZTTJkbUtGUlF2YXh4?= =?utf-8?B?UDhxVnVMeklBa0R3ekRIWEgrU3BNbWIvLyszQ1BtR0RBL2hwNEF1am9TM1k5?= =?utf-8?B?RitWcTJ1QldVZHlpcnFLY0lJWUV3eDdqL1E3YkhuWEdFRkZKUEVwRjkvVWcr?= =?utf-8?B?RkwyTFZYWjVkSFNQdkNwU3h5d0F3MG9Zc1dvQ3Y0TmhBYzZkWW9NTGZEU3Ja?= =?utf-8?B?aktzd1NES3FMZWxVcG5WZStybjVhcGVrN3NIbWRXT0lWVndYazBrQmtEMDJU?= =?utf-8?B?MUpwblZIYmJBOUorYS9FOE9IaWI3VDBEUnpJbzY2MW8yU251OVpwRmdiSy9H?= =?utf-8?B?L3RXSXRHMnhMWDl0cEh6RGN6enZNVW0ybEhtcllLR1hONW9FU2hySWl1OTRR?= =?utf-8?B?OGFNSFNvQUwvSTVQN0dsdUFUZzBrSldHRFBOUFNZR0U2VFRwUlE3MDRDc1hp?= =?utf-8?B?TWxWN2FSV3k5Ui9sZC9lVGJBeWVxRFA3dUpNVmN2a3hQOEV3K0xIbXZNNXNl?= =?utf-8?B?dE1JS01uV2RKeUs4RENMZUw3WUtvTE51UjZiTUs3TWQvNTFRWU0xQmVhRVdN?= =?utf-8?B?dW1iUGRGd2NLZnVUdVpjQ0p4cTY5Qnl4UU5Zc1hjZ0FXbkk5RTdBTU03MVhT?= =?utf-8?B?cUZJRXdnaUR2RHkybmNVODFIVW1nOGxmcHVCMjZaaXErdTlMUXpQVVhTV0tH?= =?utf-8?B?cmdkN1lmNnpySkh5anFBYjc4aVdYUGx2eEZsWHJiZHpqU3p3QzQyTTV6V2dm?= =?utf-8?B?SXNsNzVVZU84RGxqU2xTNlRXVkJvN1c2Y0p3VGZKZHVsQ1BrTVdHWkl6MWVR?= =?utf-8?B?Tks2K0R0RlNzRlBId0JMeEs2NEVUeDBoTGxCRkdzblZrQ0tRSGVuOU1wWk41?= =?utf-8?B?T05Nb0FhM2EvZ1BlcS9DYXNpVHVMdGFhdzNWKzgxMFJOSi9CVHc0c1ltNTdJ?= =?utf-8?B?UGQrMXpjZjFlTzJIZFI1K2JuNGxMYkdwaDU0RU56bG53bGRyV0kxU2lveEY3?= =?utf-8?B?WDJjR0VMQWpOaytSeC8vcW8xU3l6ZGRzNENhOTZrd0FxVWVzNVhlL0FVckMw?= =?utf-8?B?Nk5kTDg5VENRM0dDZGdzVUpFdm1lV01zQUErbVhhQjJkSVk4enM4Uk03ajN2?= =?utf-8?B?RUs3OEg5SGdPSm9wZDIwRTRUbG5sL05jdS82Tzd2YWRzcElIY2Z2OXJreTdy?= =?utf-8?B?YmdUM0o4dkdXZExXSDZkODQ0dXN3eHkvWWV2Umg3S003TVlLR2JyNjlFa3BP?= =?utf-8?B?a21HSUhiUGZ3aS9leXJLVFlORWk5MU1TYVFwR21nT1hueEcyT1BUT2IxdGdz?= =?utf-8?B?cWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98031e47-2f70-40b3-7609-08da68d7ba93 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 16:08:18.3517 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2R4KLajD+naYecMh6SF1EMv5/w0YvjEAHszACUOg9ubtGZBMDvsOJC8E6AK658VzfWDwRlLf9w679geUM0srMsCyBA8gzaz6u++coqsZ4cE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5803 T24gMTMvMDcvMjAyMiAwODo1MiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFRoZXJlIGFyZSBjb21t YW5kIGxpbmUgY29udHJvbHMgZm9yIHRoaXMgYW5kIHRoZSBkZWZhdWx0IGFsc28gaXNuJ3QgImFs d2F5cw0KPiBlbmFibGUgd2hlbiBoYXJkd2FyZSBzdXBwb3J0cyBpdCIsIHdoaWNoIGxvZ2dpbmcg c2hvdWxkIHRha2UgaW50byBhY2NvdW50Lg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPg0K From xen-devel-bounces@lists.xenproject.org Mon Jul 18 16:11:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 16:11:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369922.601536 (Exim 4.92) (envelope-from ) id 1oDTKz-0001f3-8x; Mon, 18 Jul 2022 16:11:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369922.601536; Mon, 18 Jul 2022 16:11:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTKz-0001ew-6J; Mon, 18 Jul 2022 16:11:13 +0000 Received: by outflank-mailman (input) for mailman id 369922; Mon, 18 Jul 2022 16:11:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTKx-0001eq-Nd for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 16:11:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b8ef15b-06b4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 18:11:10 +0200 (CEST) Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 12:11:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5803.namprd03.prod.outlook.com (2603:10b6:806:116::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 16:11:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 16:11:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b8ef15b-06b4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658160670; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=DeR1xM9clxPThvwIwRFyrGWtoRsfan4gQ1Xe+sIld+s=; b=hUSTZFTYExjvBcBsaG3R/1pXwt2A2/CjT9aSrZTQl91VFxeQqwEhh465 psa/MFv5RYqI+q/hsXwgNHK1wGT6Gwd55RVM5j/VZsShQngUAxCIa30qa GdOu4gF9S0RxhOVPBRHl1ShIfeV0x0IcuMdxRObe2lIMv3wTG7aT/UOkE k=; X-IronPort-RemoteIP: 104.47.57.175 X-IronPort-MID: 76050321 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A7Ux5yqPi5tziBiXvrXNrnJZpQ6imJRDwMBigO?= =?us-ascii?q?pGNyHHe1HtQZ0Fdl8jBgIlaPhxqb1M5WdDwY4xejPwS9Vsfw+ietHj3SKQK3?= =?us-ascii?q?JpmGPdIPltlpT3G7+RCZoHPael36cmn1uumB/ZKOT2nDS9tFgZEpQGawSeZH?= =?us-ascii?q?MqYOaYuw1QgxKcRUGBcHRnj/2Nh8u5HlXShmjky2u5fISE+050GTm+1YyHu2?= =?us-ascii?q?ZdP4rVnOBMcAn4nwfcYhAlWGQXPimHgBL4LGrP982jvWsTRKFGbCnmc2zwrR?= =?us-ascii?q?P6KOMtRhUQT3VCwS7+rcqQqrjpzJyIasH4RnfL6ev4LrFjRk7LY94pXms6dx?= =?us-ascii?q?xvt2anvRwFgjX4c3biG+xofEmWBy6Kknw40+06FrT0m+VAAJm5SwL3i3g4uB?= =?us-ascii?q?eIvCII0VICOrQDNFw30p8qKkl9imD91GoxeGMkR7iYwGQpY7nnLY/mKFTf7+?= =?us-ascii?q?73vy7FmZ2i3A8FUpGmYu3BF6Q46TDbu6eDbsSl6I1bs5G671w+NeTJs/Jcdm?= =?us-ascii?q?jcs3vDyheFNigKPJ4sHUe4SgxQ5QWT7eg35BE29t+gUIslHsHJd9iZUz2uGr?= =?us-ascii?q?pC1c0lfajnt1trfLMo3UY5wZewwNQqlx/i8J69wD1JQd1Yuisbr6GIKoOmZb?= =?us-ascii?q?o3kC4g6oltJVwl+Nt+o0ECnC46eADE3JVWNY2hMQPne46nS+k7LWnXxgzAiK?= =?us-ascii?q?n3NjNq3CBPufLdhzINkkwoFZ7zZnPBeakge2opdlmiZxySZtcuQRZYWGM/Zn?= =?us-ascii?q?wGweymfb/GIzW2Iu8HX/0OnzxHey6Edh3KstJxYE2goW1lNZdjp4mZucW37U?= =?us-ascii?q?Xj9lvN1gOju7z9bR/PCS6iMWeXO9w8+WJpPgf5Mf1+RDvVil5K7Y9vVeYEnS?= =?us-ascii?q?iJwEvxSxKZuBJfOHgShIZxETyofBB10LAWKiqDysCmlWpzU04TFg9wzYJMzF?= =?us-ascii?q?Fli2M0aS/P841b47M4Javf/wdUKpGj1XJ+7OtKJ2PF/KKvTPb7LYcm8IlTyH?= =?us-ascii?q?L2ZhPUye02B8Ym7cjTt0zHqYh1K5oaCyIx0dqy4axGXVZKyk18H7n/Ut2WP9?= =?us-ascii?q?eZu+fABmt8pLivDhUuA7Oj1OmbzggoZ/MxMEmS5xtH6Ryqva+h2O4LsKEplS?= =?us-ascii?q?P1mQOv7g4VVSrPzocdc2oPZ1NRXm9HF76jWNCwBHFFf4aPVW4PeQtvtnPFpK?= =?us-ascii?q?IeLWlwvALMGzArE0wFt6m2BO+6oCznaJ3lNRxfVqQRKlquTICdbdM/kHvMy2?= =?us-ascii?q?Jj3s31+HaATVj+unqcD+Ynsy2LY1xYVpJ+n9qmyOH3LQn4822DGRq0ouxdYn?= =?us-ascii?q?3UVjoOdadXqXhwggtY6wHHE3I5cKMm3u6TW6+R2u/6Eh5sIOHA/AksOpLAES?= =?us-ascii?q?HsGbiHjPpo+gSg3NgpT6S0xlgFdtmZ6jkJh/5k9y8mMQ6o4d98/ifzbkE54U?= =?us-ascii?q?0OrBpphSnk7AYFzdMkK1wAZrqo+SiBHJzTc8RY3K+jfkUac2vIcwYXF7aALF?= =?us-ascii?q?qEZdVJDa7s2/dxyH3rIoYjGysWaTkB5XL5eW7YLPHP+fGDU5Ky6e+nn1g6F4?= =?us-ascii?q?a81umr+o1iD7IIqPKYeIjOKRJoLqrPM0HnWfGYrr/W17eAlxZ6ceAUZVtT3J?= =?us-ascii?q?ci3mIYrVamXnsVtyGYV5ETbk/9CpJQYIsMtYR5K4Sjt+yqVdHffgRMPrZX3w?= =?us-ascii?q?0Vismhw0X2LdOn3p9AtgkMRx3MTgPqiVurKTJyglZMVVrGDhYfht/+jQNXFt?= =?us-ascii?q?ikkiKQCkCGUaMCzwphLCYwj5Jvd3KTdH2a/WqHvLFkaKY/cbFFUaQbXUEVKY?= =?us-ascii?q?zHQR9sNTst7B+UfKTSaaeqw36XIIBUksATis4paqRbl3JMXTC4n/4bn1vxks?= =?us-ascii?q?glRXiuyRXReOHr+JQj4nhU7NLp48jdHJlhugXdv77+XOoigq6DpSp3xz+lXH?= =?us-ascii?q?dHXjZwLiSjVDMUqpTIjQEFkVJUHy/ZyU31LClPB7zUBue5oWq46nuZn2uTcp?= =?us-ascii?q?gDJeXFQIpX0WqSJMFXpj5qxPqlKFWnBGIA5ngGGPQPCBtZ8v+hoU4B1mdeGr?= =?us-ascii?q?z8BjsIGe88SMLhCblMHE764TYbMAbO/+/OMGTR7bq6kd5bkbMcBayYWlrnD1?= =?us-ascii?q?Mry3zO9mWtNW3qkQgoq7FF6bUtkzXtn+ohML6d7/wEJQHSPxHXQYUefyvCGE?= =?us-ascii?q?6JvNIrnxwjaQZOF56JOSAKxLDzLN4zxX1q8oyyhlDFUI23GQVZ7DgNfEO6An?= =?us-ascii?q?hJMaiuBGF1Auw4/3s00gxyVLM40DGPGpiYQGsXtL8gvkjC0gORR8Debvw6hL?= =?us-ascii?q?bj2bTsa7iB1kgyO6x88cFhvT2ttwZkWZlDeCLfHDxWrg/jTfO0t9tvgrhLeg?= =?us-ascii?q?jQH6GtvWUjmqhFiwSxFIAw3GQSMRZI/ytviY+xIALdBujk4EBZW2IfI45qNE?= =?us-ascii?q?dHcUZEoT0VsdEu0eqDVJV8mlBoeFHRBUeMfvWyRZFKnGyxHt/mQ?= X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76050321" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iJ0e8pKS7CfV0WnGZ8KR7HYvyn2eOjKlDXXM557iWyTqwxAwN6LjpLbZOBFiqgwCnD/9qa7x4qgel87dOzrPc51736vOoIp5FznVmNk+cb+Vzg5MHlI/MHWmQp5yvFvPQ6I0OSYNij9BnBNaELu6wDt+hpuguyIuPXytlE7KcL5lujyBi8X8Uhbf9hM9RIBGbbtxna38WdVsEcS4ltxS1ObyoPhQX80mW7/rZa3pLDiVcw/ua7ay1XWKw44VhOGM9Hulrpvg+YsHx0U7co7HWjVZe8+go0MvdIDs+433TPay50j4WrapfWy1r1EVmP+6sOPyPTQkGL7ZCnmuv7WfxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeR1xM9clxPThvwIwRFyrGWtoRsfan4gQ1Xe+sIld+s=; b=OcEnG+eWXHgIIE5byKbHNnImUet6ynYyfuh+vfNwYF84hkLi2eHKivWW63FNCFcd0F7TFnUfTATXjVofOoviwxhueNUpm1MJ1fuvCuwD+zOJML9O34EW0S/34N9XEiabShHZ86XwHQHglOFzGclyT15ph7Hv40kGjlhowTMKYMkip8UgLYUmMEuouGWS6WdmwF57Bx7R4JGzpc9Wytkdz4XOiavBZa4qtrdeUG8G9dNnmxiDDwvmyJI9/5R5xg4xPGjEHaIFI3CvVgtRoYhiz4zwLDAMmRjf3p8e+hqg1KrQ/faElHD1p9K6kMO7iW5Iq4VHA9/dL9ym5J9a3I/8sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DeR1xM9clxPThvwIwRFyrGWtoRsfan4gQ1Xe+sIld+s=; b=utGzCWOwovae0guIKw+nyIL/KyK+AaW0kww74H/i6TNTQZksHQyV9mfvQJLG3sx5pv+cXPptawTj8sIhWiC8FOEgt+nP5qJp/zbyPWHC5yS72VYbLc41t3HuHlF5XRv2yfFbIYdy9qK1vkqFOTELHhw7/niD5EyXjStSorxv53w= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , Charles Arnold Subject: Re: [PATCH] x86: deal with gcc12 release build issues Thread-Topic: [PATCH] x86: deal with gcc12 release build issues Thread-Index: AQHYl1bWGTbUX0llkEufEOvvIzdFiq2EU0cA Date: Mon, 18 Jul 2022 16:11:05 +0000 Message-ID: <25b0dbef-8823-2a6f-7697-6bda89f3ec67@citrix.com> References: <2c3f0ca0-94c2-6462-f4eb-a2ac54c09554@suse.com> In-Reply-To: <2c3f0ca0-94c2-6462-f4eb-a2ac54c09554@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc8211e3-f626-4d1b-95c5-08da68d81e01 x-ms-traffictypediagnostic: SA2PR03MB5803:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sYEQ0jYsQ3hZh1FDOZaTaIg8urdZb+GjRNIfyUyZXvS4sw+Kc+OCRiiL6LFcH6dB1dWIRaV4JmH9YEbbSrXi+Z4ilVj8vqU5nM86gYipa1leoKrq5SO3Cv7EMoOj4u3XCIYpKqi0ILjJt3bQROeU+vxn/8r+kop2AwlSwvMKZbrYWk29O2+RhZgcsIQBOKnxfdyYco/D/HpY138Tu2ZlthcYk04dmqdTMsi9MtAzYW9TQJrbVXUUu7GLnD9Qw55cQvvbkgZ+M083SDpCNUZMnLysZgEbW5Pvn0fPkmHaJsIxdxaPmOh8UACwRfGetqBoaQtpa4TWKymsCyHwIUBV9Ws06MPT44Y24HLrF0OuP65CPamGR8+Q33qsIKH8O77Kgm1w7rLP7XjHkCdI+MCqJApeqHGCPV6wsxvtNAdGeMy6pPRU+I4O8dyFSif9H5Ve3kn/EssdT4Am78Io6iQ4chYVgHlQSQGlZGB98jtZEX49EwTellPGi8tKttnHCssK0B/BVAC+QDgbiZGEV4F0M03RHpK7ShIHDMH7lC0usrgR+0RAYk5JmSG/74XEHGU+hPitJhiXLEhSQ/zANC2KM+eDc2/XWSn83O5Tfnn+3k+nI4fceWQIt82RUA/0jRI/TrjhaXI5R1lLFMMzfLMTfRLMU5G/9rhiGSr1M/P4gaUKr20YsdfGHOn9BeTxF0aUkMOqikRFS1IXoBjkpLbL1zzy9PhOfXrt2CnbRDGTQZ/ALB0wHZ6/P2k0jyP6UHIGxvKVftIDFXQN++vlKVMdQJXUP0zYlXXPxMvlWYe/8pbQmSguF3RUSPbQ7dGgmSh9WbatjqYszMr/ZIiHSA1Vf2InOuuJV7PtZ4gwf7FIu6m7frFrfIJNWnnXNK43HCXB x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(346002)(39860400002)(136003)(478600001)(6486002)(41300700001)(31696002)(6506007)(86362001)(38070700005)(54906003)(82960400001)(316002)(31686004)(122000001)(186003)(2616005)(26005)(6512007)(110136005)(53546011)(71200400001)(66446008)(4326008)(76116006)(38100700002)(64756008)(91956017)(66946007)(5660300002)(8936002)(8676002)(66476007)(66556008)(36756003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L2hqMnc2SXlqZHUxNzY3MG1peWlnUkdWWGE5elFGSEVaTDdsTXJKZjBjNkpH?= =?utf-8?B?Si9zcU1FaFFGVGZRSjRKTDE2K2NCV3Zqa1Y2M3JpVEdLNlFtbXhlMzh5Y2NR?= =?utf-8?B?NUFMRG9lTStOcThrNkl6VVVoWXptYVRPQTdIeG9hRUVVN1F5VUQ0SzZXT0tB?= =?utf-8?B?NXlWL1RiNjFFR2RjNjQ1Y1FwRWR5dDQ5Mnc3cHg5OWI0ci8yNDZiVHZ3aEVn?= =?utf-8?B?R2hyYmlJOVlSMGo3OVpjRUhPYlFCbzhuQ0c2bXpUL3ZXRGRNdGhSOXUwMU9Z?= =?utf-8?B?b0FJSDZwTU1xeVdUaCtTbXdEd0hnZ1p6MjIvdTVsZjZlRGRxdDg4ckJCWkFD?= =?utf-8?B?L3hxN0F1bXB0bTFsVlFpaVhEeUxUOWxpcS9MRW91dXRpd1JVUmtmYlhhZk1E?= =?utf-8?B?Qnk5NUNlN3llQUp5cG1CK3hSSHlOdlg3ZVdHYjhyZkgxYzZaRmV5VnFNbjFM?= =?utf-8?B?Y1Vhd29TWHhKdUwyVE1rV0dlWXlNZTNJaEtTY0J0bEt4N2tGQXJCRHZiWitE?= =?utf-8?B?YWFlRDNYL0RrT1NXYmMvcnpQcy8zd3VSZW5obzg5VFNZWVlCbWNRUVgranpE?= =?utf-8?B?TGdNYnJUU0FhSXVVUFR5dkdvem5jU0NoUUt2UmJkWFlTaFVITHZrQTBGajht?= =?utf-8?B?azJtWE5EZWMzWFpLQjQwdDNidkV4czlZangzY001UU1zQmNKSys0SStBb3k2?= =?utf-8?B?OU9Ha1JyWG9nZkhzeExHV28xakp0L0diZ0dBWHFxVFZ1amZZUmlMUDA5Wnpp?= =?utf-8?B?cTZZNmdTRE5HYWN1UmRmeElYcUVyZkVZUHV1QWxma21FN2w1TnVpWTdlQWtq?= =?utf-8?B?MXFEOGRTajBERENzZ2VDSVcyN1lRWjM5VUxhbncwbjVVZTU0YmthejZmZTN5?= =?utf-8?B?UzRmMWxuYktuMmtWRzhTbE5uaFpPVU1XcEIzRmpHN25SazdPUk9pSFNpV0lU?= =?utf-8?B?S2hZQVRHNkdteTNYVjFhWjJQUW1kczY1bXpRQm5RMEd2dDZhMkNIS3JHTzR6?= =?utf-8?B?Q0tKa3lMY3RDcTdkN2NMOS9CRUk4UE1xVHE5MXFndHpNMmtmbzI4czdUa3VP?= =?utf-8?B?L0gzcm9pSURWeVQrbE5mUDlWUktaNVZoZTBER3pESVVDallWcG92a3VpeFlD?= =?utf-8?B?TDNDcVlITGs4b2NhS0FQdm9JZUJySWFtSjBUUVJjejVMOWhiY3FPaTZYNWlY?= =?utf-8?B?ZHRjL1hzc2lxdGNJaVBPVS9MYy9SMnZhakdEZzAzbmtSb3A3TEJLSGpIM0Y4?= =?utf-8?B?MU8vU29oNTVDU1ZBU2VWc2xCdDg3ZThkM3hQZWsyYVRFc0g3THdVbkFBK09K?= =?utf-8?B?QUZmMi85dXdPRFlOYWFTLzVLUXQyaWVycW9UQmJlY3VDWjNMeTBkQW4ydWtS?= =?utf-8?B?S1JMdVMvVHc5NVBMSy82aHNCYlQ1UnRMeFZFNzhjT3pKUWh1R1VlZU81SXZL?= =?utf-8?B?RFVuZHpKVy9iVXpZdU5CT3gweXU1dFZmV0dkSGs5eVVYZWZmVmVESkt0blRB?= =?utf-8?B?V0NPMW5lOXg2YSt4N2tjQUF3Z1ZBQUVzQmJDVnhHZC9FeGVBL29ONmRxOVQy?= =?utf-8?B?TjZRN3VIM1dsSitkMWV5bHRKcWk4TjVXVXF1SUJMZnN2aUtURm9DODRkd0t1?= =?utf-8?B?T0JSaDkzb1FhamlZdzA2aFpJLzZDQU5RZTFLbFc2T1Npa2xRazQ4Sk45cVZJ?= =?utf-8?B?aUhZUk1BbnY2eDVGQy9td2ZyVExKV3lDSHpBWXc0a0NDS1ZLQ25FSzFhTkwx?= =?utf-8?B?NDJnMGZUaVBrUHMxdFhVMGNDQ1RFdWVtNDVjWmgrT1VCMXlOdG1md2RBSjF4?= =?utf-8?B?MHZhbkJVMitwakpoWGVMd01JZHFmMFZJbmdGVUZoQ2NJT3lJYVVob3Y2dndQ?= =?utf-8?B?Mk0yb0hkYmphTGZ1YWxwc3lGL1lGaXpoNFFVQ3dmQ3c5Wks1UGZZSENQWHRK?= =?utf-8?B?clVSRmxmajdrWGV5V29iUVdwZUxwV3psQi9vMHdrcmVEZzMvL2R5UkxNU3Y3?= =?utf-8?B?czI1dk5YSnFGWXAyQ0JUM1JUbUZsQ2tzREt5OU1kM0d5KzV4azJBeEZ4N0VV?= =?utf-8?B?TjZKNWJoRWdmdHliMGZuWExPQW9iN1JPNUwzRUNyUUFVS1JKOWhvbkIwZ2JV?= =?utf-8?B?dE0rbDBIVXU5Z3A3SktrdWNoNGM2NWhuNFQvSUk4OHZSbGlDRXZvYysycHFl?= =?utf-8?B?UVE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc8211e3-f626-4d1b-95c5-08da68d81e01 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 16:11:05.1522 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iOg6kfnd1Va32FQe3MkHO/zRXdtP9bvE3sgBPgWz6zhq2SXArTwkrZAHPEX0zXmHt5M7AGtTc0E1Z4l2ujULOIBf4wYooZ61PTfgb9C3C10= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5803 T24gMTQvMDcvMjAyMiAwODo1MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdoaWxlIGEgbnVtYmVy IG9mIGlzc3VlcyB3ZSBwcmV2aW91c2x5IGhhZCB3aXRoIHByZS1yZWxlYXNlIGdjYzEyIHdlcmUN Cj4gZml4ZWQgaW4gdGhlIGZpbmFsIHJlbGVhc2UsIHdlIGNvbnRpbnVlIHRvIGhhdmUgb25lIGlz c3VlICh3aXRoIG11bHRpcGxlDQo+IGluc3RhbmNlcykgd2hlbiBkb2luZyByZWxlYXNlIGJ1aWxk cyAoaS5lLiBhdCBoaWdoZXIgb3B0aW1pemF0aW9uDQo+IGxldmVscyk6IFRoZSBjb21waWxlciB0 YWtlcyBpc3N1ZSB3aXRoIHN1YnRyYWN0aW5nIChhbHdheXMgMSBpbiBvdXINCj4gY2FzZSkgZnJv bSBhcnRpZmljYWwgbGFiZWxzIChleHByZXNzZWQgYXMgYXJyYXkpIG1hcmtpbmcgdGhlIGVuZCBv Zg0KPiBjZXJ0YWluIHJlZ2lvbnMuIFRoaXMgaXNuJ3QgYW4gdW5yZWFzb25hYmxlIHBvc2l0aW9u IHRvIHRha2UuIFNpbXBseQ0KPiBoaWRlIHRoZSAiYXJyYXktbmVzcyIgYnkgY2FzdGluZyB0byBh biBpbnRlZ2VyIHR5cGUuIFRvIGtlZXAgdGhpbmdzDQo+IGxvb2tpbmcgY29uc2lzdGVudGx5LCBh cHBseSB0aGUgc2FtZSBjYXN0IGFsc28gb24gdGhlIHJlc3BlY3RpdmUNCj4gZXhwcmVzc2lvbnMg ZGVhbGluZyB3aXRoIHRoZSBzdGFydGluZyBhZGRyZXNzZXMuIChOb3RlIGhvdw0KPiBlZmlfYXJj aF9tZW1vcnlfc2V0dXAoKSdzIGwyX3RhYmxlX29mZnNldCgpIGludm9jYXRpb25zIGF2b2lkIGEg c2ltaWxhcg0KPiBpc3N1ZSBieSBhbHJlYWR5IGhhdmluZyB0aGUgbmVjZXNzYXJ5IGNhc3RzLikg SW4gaXNfeGVuX2ZpeGVkX21mbigpDQo+IGZ1cnRoZXIgc3dpdGNoIGZyb20gX19wYSgpIHRvIHZp cnRfdG9fbWFkZHIoKSB0byBiZXR0ZXIgbWF0Y2ggdGhlIGxlZnQNCj4gc2lkZXMgb2YgdGhlIDw9 IG9wZXJhdG9ycy4NCj4NCj4gUmVwb3J0ZWQtYnk6IENoYXJsZXMgQXJub2xkIDxjYXJub2xkQHN1 c2UuY29tPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+ DQo+IC0tLQ0KPiBJbml0aWFsbHkgSSBoYWQgY29uc2lkZXJlZCBpbnRyb2R1Y2luZyBzb21ldGhp bmcgbGlrZSBFTkRfTUlOVVNfMSgpLCBidXQNCj4gaW4gdGhlIGVuZCBJIGRpZCBjb25zaWRlciB0 aGlzIHVnbGllciB0aGFuIGV4cGxpY2l0bHkgZGVhbGluZyB3aXRoIHRoZQ0KPiB0d28gaW5zdGFu Y2VzIHdlIGhhdmUuDQoNClllYWgsIEkgcHJlZmVyIHRoaXMgZm9ybS4NCg0KQWNrZWQtYnk6IEFu ZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 16:12:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 16:12:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369927.601548 (Exim 4.92) (envelope-from ) id 1oDTMK-0002Qc-Jb; Mon, 18 Jul 2022 16:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369927.601548; Mon, 18 Jul 2022 16:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTMK-0002QV-Gx; Mon, 18 Jul 2022 16:12:36 +0000 Received: by outflank-mailman (input) for mailman id 369927; Mon, 18 Jul 2022 16:12:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTMI-0002Q1-Li for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 16:12:34 +0000 Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [2607:f8b0:4864:20::334]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6dd89ebb-06b4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 18:12:33 +0200 (CEST) Received: by mail-ot1-x334.google.com with SMTP id k25-20020a056830169900b0061c6f68f451so9523187otr.9 for ; Mon, 18 Jul 2022 09:12:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6dd89ebb-06b4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E97tihP8HnbI/adEmvxCjiADzk+ycuYUVPz4eAZufX8=; b=lOi8HISE/WBi5tBpHSDKX3uf5I0ag7Z1hcOUqSfQsB8WgpjH3j8/f/QZYOmeGQkOhA lwozyxjT0ude+8GMBFlz/OfdEJ0fgqyxhc5hXKGWnU974ZRj8J3gJyIn088PRUPPMeli 7u63BA9EauP4odKcKxI+kNwvnSIPUFZ6ojJlctIrDF5ENk9li+0VgBVZiFLBPInvIF4l mHbO0g96xEk1O69Jnuguv9jPFqcgl0VAJKMa+LmsLgfNCl2vh04RnUvC7SYd0Yoo46ff e95p9xsn6okMoIFy90b/PqkGyFsBOzYOtX+4dc77F+bA1hApG4OKsN86g7prXbyYJ8SI TpOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E97tihP8HnbI/adEmvxCjiADzk+ycuYUVPz4eAZufX8=; b=4joaILk957IbbAwA464z4VD1/yd8FJ2RLMNItdTxzokdR1hIhc76xymwD0msWs+l5L HpMQYKwUuNYtE7ceQbOxJvDrtr2zOHTT9f7TeajqymOM71dXcjsVRiXIPQa8bynNSb43 ZCVecNRc2TmH5GcpR32AFmdrU5eI/728Ip1LeZBKrYgtsqlzQGQlKXjxf1/slWFqnxsp jfuh/yCRjqlsgnbSVEptJmbBesEMnDR3qOhJNU0xExC2h93x55kjXEbFH2ux9kvGhp7I S3OcRp8GgqgViNvcVUAPkljRwWtib5Blh+p74eUIEcas8uJOMMUmPHsBJjJKKcA+xW/U 21TA== X-Gm-Message-State: AJIora+TJSyoskauVdjsFWwka0/0t9PPHcf5rrZim+wsqlhmlSlgs5g0 CY3baqo0muJiRNHhKXeYi3SR0BW28mqlTBn5qzo= X-Google-Smtp-Source: AGRyM1u8zj1bV71F06iwCAEO/iNocAMe7lhHQUtETzV61a63N8I6/58X5nFZOsMn33gIduBYquoztm6MVS22Txbp7qE= X-Received: by 2002:a9d:7855:0:b0:61c:814f:a7e9 with SMTP id c21-20020a9d7855000000b0061c814fa7e9mr7458227otm.315.1658160752397; Mon, 18 Jul 2022 09:12:32 -0700 (PDT) MIME-Version: 1.0 References: <20220715225108.193398-1-sj@kernel.org> In-Reply-To: <20220715225108.193398-1-sj@kernel.org> From: Andrii Chepurnyi Date: Mon, 18 Jul 2022 19:12:21 +0300 Message-ID: Subject: Re: [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent' To: SeongJae Park Cc: roger.pau@citrix.com, axboe@kernel.dk, boris.ostrovsky@oracle.com, jgross@suse.com, Oleksandr , mheyne@amazon.de, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Hello SeongJae, Thanks for the efforts. I've tested backend patches(1,2) on my custom 5.10 kernel (since I can't test on vanilla) and it works for me. Best regards, Andrii On Sat, Jul 16, 2022 at 1:51 AM SeongJae Park wrote: > > Introduction of 'feature_persistent' made two bugs. First one is wrong > overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong > parameter value caching position, and the second one is unintended > behavioral change that could break previous dynamic frontend/backend > persistent feature support changes. This patchset fixes the issues. > > Changes from v3 > (https://lore.kernel.org/xen-devel/20220715175521.126649-1-sj@kernel.org/) > - Split 'blkback' patch for each of the two issues > - Add 'Reported-by: Andrii Chepurnyi ' > > Changes from v2 > (https://lore.kernel.org/xen-devel/20220714224410.51147-1-sj@kernel.org/) > - Keep the behavioral change of v1 > - Update blkfront's counterpart to follow the changed behavior > - Update documents for the changed behavior > > Changes from v1 > (https://lore.kernel.org/xen-devel/20220106091013.126076-1-mheyne@amazon.de/) > - Avoid the behavioral change > (https://lore.kernel.org/xen-devel/20220121102309.27802-1-sj@kernel.org/) > - Rebase on latest xen/tip/linux-next > - Re-work by SeongJae Park > - Cc stable@ > > Maximilian Heyne (1): > xen-blkback: Apply 'feature_persistent' parameter when connect > > SeongJae Park (2): > xen-blkback: fix persistent grants negotiation > xen-blkfront: Apply 'feature_persistent' parameter when connect > > .../ABI/testing/sysfs-driver-xen-blkback | 2 +- > .../ABI/testing/sysfs-driver-xen-blkfront | 2 +- > drivers/block/xen-blkback/xenbus.c | 20 ++++++++----------- > drivers/block/xen-blkfront.c | 4 +--- > 4 files changed, 11 insertions(+), 17 deletions(-) > > -- > 2.25.1 > From xen-devel-bounces@lists.xenproject.org Mon Jul 18 16:13:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 16:13:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369931.601559 (Exim 4.92) (envelope-from ) id 1oDTMq-00031O-Sv; Mon, 18 Jul 2022 16:13:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369931.601559; Mon, 18 Jul 2022 16:13:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTMq-00031F-Pl; Mon, 18 Jul 2022 16:13:08 +0000 Received: by outflank-mailman (input) for mailman id 369931; Mon, 18 Jul 2022 16:13:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTMp-0002yg-0D for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 16:13:07 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70088.outbound.protection.outlook.com [40.107.7.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 81834379-06b4-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 18:13:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3398.eurprd04.prod.outlook.com (2603:10a6:209:6::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 16:13:03 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 16:13:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 81834379-06b4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y6ChofG5De/JoOQ5vkuYj5B2FlArpBojsrG+w4v0AkciorWhom0zpWu3Hqe3chcoJk2Pc/ENrr7LxejxLAicCtuc371c66srkNX22y/liRG8xy6o5Wa2adACvJFp8eMEBBZ5q12G49I2CkxIfOuhC1zuOoVV3Y73Hnpd5MtOIpDXcnLFzL5ZSw4ruakty+eWz2Q4rBe86RAJEKPXX7Xno6ih5PoNQKoX2QUWLP8UKl/GCCGiJHlvJLe8vjgvyR1VMbAdWHk6hE2Wwtmns4JOhUapoGu9eUGUgsDv4qVNCo77qh8Sdw/T1lffP+zqm9Zc7Bc6IGsKlmnpzTxSgneSUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NdA7qoWakb6S4xGsnExcBDM5U822zaUdQ7MyGu7PNrY=; b=f/QJBQpRE8zXleFVu9228Liv8J1pOeaDgtu7NmkzEXNHdqGRpfoA+rf5DwiIiHYkPlQ+6SM8USD5T+P10REXUm61qbsDo4HaE/70JpaIq/EL0KWDyVT062wZxKsgppz1DuEAir8F0Hr+CsngyMPd1/s1hHY8I1pSFsGBo614FoPngcCBr/h/CgfGVEExaL/9LPfkgZBCtH/jOStx/+vXyYh1hBx6iZ6IeCW8Is2zSv8EocBgzt9xsJE6HLiXcd8ZXX8KEDFETfzoDByP7/WTVRggugH3lt/UIFk8bw9llWfGEvtVmoj5C6irkPlt5giy4UlcJ4EbYzoh/JY4UO8Hog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NdA7qoWakb6S4xGsnExcBDM5U822zaUdQ7MyGu7PNrY=; b=cab58g64W1cIXsCbXBjLjVlXpm8zlvih+XWEb3HcjbarUsLJbXudO2tIeW1aD5kluW5yxuvRVhvNR9qHv3pYkFxMHgKSLxuEQxtvcoftjaue5VBEcSBRqzq1ycJPJt0ZLSWztj3Mz1fSkCsfIRwh9ySjp9Hi7qZgSXGKJ77T/tWsFEQU+J0HyO66DodLPEa6NAM2MOpL0R/6tXH1RzI9PmJk8mDsLW6lxpUGT4/qPCIgky3WYLrIzMCZddqg4wBewsOStoQYfqPqCUCqMbY7YQUjX0fTuWn5eXz848tNrq0dkFp8UuddnGWDYuo5TMLXy7W5nA1urZmITl+qQFGbZw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> Date: Mon, 18 Jul 2022 18:12:59 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation Content-Language: en-US To: Juergen Gross Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220527072427.20327-1-jgross@suse.com> From: Jan Beulich In-Reply-To: <20220527072427.20327-1-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5230eeff-9c6d-4654-cf2e-08da68d86356 X-MS-TrafficTypeDiagnostic: AM6PR0402MB3398:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZB/lm0MjOVHRAt+1xTXp5WuZ1+URCHgKd/zPdd19zkqOf+OGMIPGmL5O5T8qEZ0YNJDU4p1OknC941rBfO1zcyFaBdYJ5CVZQvv5+palIf7MZ+Ck5aqadx/qf6IZ3DgMX9YDLeA1j9DbmX2A88zgT/MCuBEk+deAtIK4reKrFMWfGtVmOZPBne5D/TpTb0pife3MQkZgROUkMAE+H3K2fWEs68FS3sUCgDe2qoJpCB9PCrSXGKvwHjd5jF1RZJAjOcR94Qf25qYkDR103YYpEip9ylHQ3wFHHRkTlxJlBoN820mrln1G4Zm09uLjGiJMAjJrbl0uvcM4HT8WZ4VIxvaSs/Iy0VeIvFLt51dJsFjOeLh06/95eTCcRXRuni06yBBMiJQ7OEOmqm+15LXkoDEM002y9srhAhS8nkinjDtgfEX8aPzAq2cHuSn3ULArvMyRCP5Xr2Mm9LMgnPvZ+sX/2l58CAJV8ZmKwB7MQ7RVqibnI22LZ/8CpMP+9y/CkBywM6nYGkKtR5ez+bIgBMy6o9gTIkK+68ovZ7shOmd2iAPOrsJB+JKc5OeAXAVlIiby7rzicWl6PjTnFnOziBM6QgGfvvvandZGKgwmn44VHWwUjlh/aUdPG77GMxiD0/NyfR1+ZeqBJr8yRFEcBEVM0XuB54XHZd6JJ1cMhTKNlbTpwZV1IZ74Y39aCJK0kMK0JBYdkLH/ImXNvzJpoA9F+hxAjOYaPg9nGUYjFdMFgBoPxNbPHK1GXUI9q3Bee4zi9gnXs4bkb/EQBpVu/l/eEeptkgqoqY1YJtXso7Ob7QO8W9aVSETzbsqsWMMrKhCUoHEjWCPHyJnlOdLgki0XfcXuL1Zf8iOxh2KjEHGVQSMEurcA4XfD6YuX9mR/h0Hi0cdQ8/3BCbs1V7iiAn14BWhbN69GOtyEUwI05PE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(136003)(396003)(366004)(39860400002)(2616005)(41300700001)(53546011)(6512007)(26005)(6506007)(186003)(2906002)(6862004)(83380400001)(37006003)(54906003)(38100700002)(316002)(6636002)(8936002)(478600001)(6486002)(966005)(66556008)(66476007)(8676002)(4326008)(66946007)(31686004)(36756003)(86362001)(5660300002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bDlPVmVIMTQxVy9GeUdaMzdkSDVkcVJHUlV4ZG9WeXpXVEZFWFN6QjA0b25J?= =?utf-8?B?QjhVVm9Wb1lQWllSUkJtbHl0SkxBSUZ0ODFmVlp6dWhoR1JxUzRkS3VDTmlV?= =?utf-8?B?cnhORE5VZmpDOVMwaTlySDB2SGNhM0Rzd2hITWxJalZ2QjFGVzJGR1FLUENK?= =?utf-8?B?NWJXWUNmRWpPdytNV3EvRW9KN3U1c2oxZXZxQkFSRVJlYTZPenVJdGU1bG4z?= =?utf-8?B?bFBHK2VaM29TME9vUlRHQmdOYTRTM1lndnM4TjVLSnBxRWJnYytnc3N4NEQz?= =?utf-8?B?YnJjcExQdXRyd1JycVlyZWhBUlFWclRsL0x6US9ZWjcwYVhhRXlvV2pDSkhX?= =?utf-8?B?eGZOd1VjUHJ3K3FtZmVlQXlOdGJrRkpaNHZwcFJuNUpVZHpUM3ZKL2UrSXFP?= =?utf-8?B?MjgzU3VkV1dON09VYjNzTTBRN1JsSVJiRllUU0dwZ0gzSlpkUERsWXhMUDhs?= =?utf-8?B?bTB5bmhTTzlJNDFEUHdUWldJUTg1aVYvaE9VZGtwdS90dHdIQjljc0lhbGZ3?= =?utf-8?B?UXpoNDN3Tm9IWm1QWU5saWlwUG5WZXlqOXhoUm9ESlRyb2k1bFhTeTNtelM5?= =?utf-8?B?MFJId2ZUZEx1YUJPNGlCWFNLeVQ1K2p4MFdzcEl1T01ZR2tNaDhDODUvSjJY?= =?utf-8?B?WFBqVEFBRUw2L3ZUSHRJeElXUzYxR2xOT2FzcmFtUm9Nem1pcEg0eGRHZmlP?= =?utf-8?B?TWdCZFB0djJwT1NNZG02Rmkza0kyMi9obFcxaWpneWxxNVVuNVNaRkRYZmZ1?= =?utf-8?B?cEQ5dnZnZjhyaEdVeWtpblo1V0kyVEU2cis3TEh1NTNNYTFGWi9oQVF6b1BH?= =?utf-8?B?NENuTktLbHFuZlVLcTFQcktSMW5hOTRIN2dmM0NMc29kSytzQ2dzMUJCNFNE?= =?utf-8?B?SlBOZVZ0MTZjUVoxYjI0WHVCMDQ1ZWJhQUJLeXFjeC9JV3ZGbmdxM3FTNDdL?= =?utf-8?B?NmFpRjkvODVEZElQSTRzVDZucnpmYWVrSkxIVkVCWjU5OGovZVF1OG85YnJK?= =?utf-8?B?MzkzTUtaNm9vb2VBTXV5ZU85OER2b1p1SmFBUXRYQnRiZnZhVkQ0U1BpTTZu?= =?utf-8?B?UmtkN01iVW02QVFXNE43VlR6ZmtJRDJSMFp0ZDA4MGFaeW9vUldraUNUMnNp?= =?utf-8?B?T1FTZ3VUM0RTUGlMN254YVo5a2ZlL2liR1NmOHJkWWJ5SGpEYmpVY28rVGRO?= =?utf-8?B?RDhKWlhxQ09XcncvUDdUejhZTG5neUhML3dDVHBENWhuaVU4R1B2aXlJV0xN?= =?utf-8?B?ZmNkdGYxOUgwaTF0WGxPdTQ5Vm9rT0M2bDFjQlQxcy9ENDFEODdqMC8vNFRk?= =?utf-8?B?dm56Y0FHY2hZS3p3UmFGMGxUbjdPSkhReWVlaDcvQVdLNVpRTDNSL3pubjJp?= =?utf-8?B?bHFaVVhPajY2Y2wxVkRFVGo5MTFrY1MzNGx3d0ZicTBveVIrYk9SUk5TOUdH?= =?utf-8?B?NlBhOHU3ejRES3NuZitiRWJObmNHWm8xWU5pZ1ZDd3BkSFppMWNyVTZjRGNH?= =?utf-8?B?SGhKV0ZwbEJ2ZiswNHhJcVlyVmxjaXZ1WHNmSHVBZGNVSlNYemVXYVFvTXRn?= =?utf-8?B?dGRRRGZsOENGNG41c242RlZleTRBQ0V6VUM5U1RvNHNrSmJxZnJkU0xXVXdt?= =?utf-8?B?Q2dvSTNvdVhLY1pDN3hmSFBoay9hdVhVZVFXcTRDKzFjdGtVYU80Z1FJbnZW?= =?utf-8?B?bWMzWm9YNFRRVEhVdUdHVzBRMWZ1LzMvdERzZTNKdFBBWlJrNlVEN2FURVNh?= =?utf-8?B?aVA5OFNDdHVHeVhEUERlUEp6SVB2NXhPRE9FbUZuWFBwUkJCZTk0YlpqQlh1?= =?utf-8?B?bW0zb090dlpSRFVrVUlLSVllSTNIMDJXc0JRZVhua2VHZW5pRDRCTzNBR1Vn?= =?utf-8?B?NDRSUGRKb2tIY2JpemRuSEdqV0svR1NYdGxMNzByaTRjNWVTREs5bm9La1Nq?= =?utf-8?B?eHRUdmVQSGljUDVKb3R1VCt5WTBHQjRyWEdBYjBza01sdC9OWHlyN2ZOdmtZ?= =?utf-8?B?YkJ3aUFsbWFRc2RrN2RTUVJ4a0tPTS8zVWZsaWp3Wno4REpwNGdHRGdYcGRk?= =?utf-8?B?OFdub1E1MVAwcHpCWCtGRVFFTkNWZW9oVmxBZEZ2MkxJVDB2Sy8yNkNJR1N4?= =?utf-8?Q?ftEkDUGg/ak31n0DhAD/F3aWh?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5230eeff-9c6d-4654-cf2e-08da68d86356 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jul 2022 16:13:01.7704 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iS9vFNOiDOE6ZJ2wPS/sIX7cD4xv3NsjLVYnwlxJTavq1qXmWVp7H6nzFwGlG7bxDRyCcZ0HtjSPa4ZKjIElAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3398 On 27.05.2022 09:24, Juergen Gross wrote: > In the past there have been spotted some shortcomings in the Xenstore > interface, which should be repaired. Those are in detail: > > - Using driver domains for large number of domains needs per domain > Xenstore quota [1]. The feedback sent was rather slim (one reply), > but it was preferring a new set of wire commands. > > - XSA-349 [2] has shown that the current definition of watches is not > optimal, as it will trigger lots of events when a single one would > suffice: for detecting new backend devices the backends in the Linux > kernel are registering a watch for e.g. "/local/domain/0/backend" > which will fire for ANY sub-node written below this node (on a test > machine this added up to 91 watch events for only 3 devices). > This can be limited dramatically by extending the XS_WATCH command > to take another optional parameter specifying the depth of > subdirectories to be considered for sending watch events ("0" would > trigger a watch event only if the watched node itself being written). > > - New features like above being added might make migration of guests > between hosts with different Xenstore variants harder, so it should > be possible to set the available feature set per domain. For socket > connections it should be possible to read the available features. > > - The special watches @introduceDomain and @releaseDomain are rather > cumbersome to use, as they only tell you that SOME domain has been > introduced/released. Any consumer of those watches needs to scan > all domains on the host in order to find out the domid, causing > significant pressure on the dominfo hypercall (imagine a system > with 1000 domains running and one domain dying - there will be more > than 1000 watch events triggered and 1000 xl daemons will try to > find out whether "their" domain has died). Those watches should be > enhanced to optionally be specific to a single domain and to let the > event carry the related domid. > > As some of those extensions will need to be considered in the Xenstore > migration stream, they should be defined in one go (in fact the 4th one > wouldn't need that, but it can easily be connected to the 2nd one). > As such extensions need to be flagged in the "features" in the ring > page anyway, it is fine to implement them independently. > > Add the documentation of the new commands/features. > > [1]: https://lists.xen.org/archives/html/xen-devel/2020-06/msg00291.html > [2]: http://xenbits.xen.org/xsa/advisory-349.html > > Changes in V2: > - added new patch 1 > - remove feature bits for dom0-only features > - get-features without domid returns Xenstore supported features > - get/set-quota without domid for global quota access > > Juergen Gross (4): > tools/xenstore: modify feature bit specification in xenstore-ring.txt > tools/xenstore: add documentation for new set/get-feature commands > tools/xenstore: add documentation for new set/get-quota commands > tools/xenstore: add documentation for extended watch command Hmm, looks like I did commit v1 of this series, not noticing the v2 _and_ seeing there had been R-b with no other follow-up (leaving aside the v2) in a long time. Please advise if I should revert the commits. I'm sorry for the confusion. (I also wonder why the R-b weren't carried over to v2.) Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 18 16:28:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 16:28:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369943.601570 (Exim 4.92) (envelope-from ) id 1oDTbX-0004xm-Ab; Mon, 18 Jul 2022 16:28:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369943.601570; Mon, 18 Jul 2022 16:28:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTbX-0004xf-7x; Mon, 18 Jul 2022 16:28:19 +0000 Received: by outflank-mailman (input) for mailman id 369943; Mon, 18 Jul 2022 16:28:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTbW-0004xZ-7a for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 16:28:18 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDTbN-00030O-2z; Mon, 18 Jul 2022 16:28:09 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDTbM-0002lP-Sb; Mon, 18 Jul 2022 16:28:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=pXwS+1WxJf/duyq+2snTUylosff/XDWWYfBkSEfD7UU=; b=l7hRdpGuQ7PwlG2Aqn+eZFPb6D rH+U5Ng8lrl+npy+2+QQ4pixCk0DWEKo0jdQBZSKtG54aGZpvSF6JmbeBBilUPSy+qN3DVE7Xch4g Ze//vtshB9iLS0l9/onhfrYPxjLiThZ6+yegTvSFxzZ0DU3qZ9YeWRFKGOyKhmqXc1Os=; Message-ID: <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> Date: Mon, 18 Jul 2022 17:28:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation To: Jan Beulich , Juergen Gross Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Henry Wang References: <20220527072427.20327-1-jgross@suse.com> <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> From: Julien Grall In-Reply-To: <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 18/07/2022 17:12, Jan Beulich wrote: > On 27.05.2022 09:24, Juergen Gross wrote: >> In the past there have been spotted some shortcomings in the Xenstore >> interface, which should be repaired. Those are in detail: >> >> - Using driver domains for large number of domains needs per domain >> Xenstore quota [1]. The feedback sent was rather slim (one reply), >> but it was preferring a new set of wire commands. >> >> - XSA-349 [2] has shown that the current definition of watches is not >> optimal, as it will trigger lots of events when a single one would >> suffice: for detecting new backend devices the backends in the Linux >> kernel are registering a watch for e.g. "/local/domain/0/backend" >> which will fire for ANY sub-node written below this node (on a test >> machine this added up to 91 watch events for only 3 devices). >> This can be limited dramatically by extending the XS_WATCH command >> to take another optional parameter specifying the depth of >> subdirectories to be considered for sending watch events ("0" would >> trigger a watch event only if the watched node itself being written). >> >> - New features like above being added might make migration of guests >> between hosts with different Xenstore variants harder, so it should >> be possible to set the available feature set per domain. For socket >> connections it should be possible to read the available features. >> >> - The special watches @introduceDomain and @releaseDomain are rather >> cumbersome to use, as they only tell you that SOME domain has been >> introduced/released. Any consumer of those watches needs to scan >> all domains on the host in order to find out the domid, causing >> significant pressure on the dominfo hypercall (imagine a system >> with 1000 domains running and one domain dying - there will be more >> than 1000 watch events triggered and 1000 xl daemons will try to >> find out whether "their" domain has died). Those watches should be >> enhanced to optionally be specific to a single domain and to let the >> event carry the related domid. >> >> As some of those extensions will need to be considered in the Xenstore >> migration stream, they should be defined in one go (in fact the 4th one >> wouldn't need that, but it can easily be connected to the 2nd one). >> As such extensions need to be flagged in the "features" in the ring >> page anyway, it is fine to implement them independently. >> >> Add the documentation of the new commands/features. >> >> [1]: https://lists.xen.org/archives/html/xen-devel/2020-06/msg00291.html >> [2]: http://xenbits.xen.org/xsa/advisory-349.html >> >> Changes in V2: >> - added new patch 1 >> - remove feature bits for dom0-only features >> - get-features without domid returns Xenstore supported features >> - get/set-quota without domid for global quota access >> >> Juergen Gross (4): >> tools/xenstore: modify feature bit specification in xenstore-ring.txt >> tools/xenstore: add documentation for new set/get-feature commands >> tools/xenstore: add documentation for new set/get-quota commands >> tools/xenstore: add documentation for extended watch command > > Hmm, looks like I did commit v1 of this series, not noticing the v2 _and_ > seeing there had been R-b with no other follow-up (leaving aside the v2) > in a long time. Please advise if I should revert the commits. I'm sorry > for the confusion. (I also wonder why the R-b weren't carried over to v2.) patch #1 is a new patch. The patch #2, #3, #4 have been reworded and the overall interaction is different. So I don't think the reviewed-by should have been carried. I had some concerns in v1 which were addressed in v2. I have reviewed v2 a while ago. From my perspective, patch #1, #3, #4 are ready to go. Patch #2 needs a respin and we also need to clarify the integration with migration/live-update. As you committed, I would be OK if this is addressed in a follow-up series. But this *must* be addressed by the time 4.17 is released because otherwise we will commit ourself to a broken interface. @Henry, please add this in the blocker list. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 17:12:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 17:12:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369949.601581 (Exim 4.92) (envelope-from ) id 1oDUHf-00024J-G6; Mon, 18 Jul 2022 17:11:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369949.601581; Mon, 18 Jul 2022 17:11:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDUHf-00024C-D7; Mon, 18 Jul 2022 17:11:51 +0000 Received: by outflank-mailman (input) for mailman id 369949; Mon, 18 Jul 2022 17:11:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDUHd-000246-I7 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 17:11:49 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b29074fb-06bc-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 19:11:46 +0200 (CEST) Received: from mail-mw2nam04lp2174.outbound.protection.outlook.com (HELO NAM04-MW2-obe.outbound.protection.outlook.com) ([104.47.73.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 13:11:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5505.namprd03.prod.outlook.com (2603:10b6:208:299::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 18 Jul 2022 17:11:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 17:11:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b29074fb-06bc-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658164306; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=bpEeEnMoazSH37zmBTpeDyfR94GPgA7oxIZzCUgfafM=; b=bSc97eIMOOYFflSI22S+hAYir6H1rUL8RK+LkLHDjp/ZcMeGZCdg/RTA T/wMh7niPp5SgG8NNnVNWijxuPaBMAdkpiqJhBs6Ai5wLwGrzr7vHTrBi mK0KoG/T97cZnEp1kv0uODIi3/TY0GuXo+OmP15HCSRWeeHNLYRsKgup6 s=; X-IronPort-RemoteIP: 104.47.73.174 X-IronPort-MID: 76060007 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:hDZPVqiMDRiIVtqTs3JBfucDX161VREKZh0ujC45NGQN5FlHY01je htvXjyPaP+ONjP2eNkkb9ji9xwF6sCGyodjQQo+rylhFnwb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kur6GtB1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eY85C9MhFPD51r NcGcCIvXhemqevs6efuIgVsrpxLwMjDGqo64i0l6A6DSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsH8xTM+vZfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2i3y3rGXxXukMG4UPJ6Ey9dJkkLC/TEaWEYXX1mxi8mzuHfrDrqzL GRRoELCt5Ma9kWtQsPsQh6Qr3uNvxpaUN1Ve8U44gyQzqvf4y6CG3MJCDVGbbQOq8seVTEsk FiTkLvBFTFp9bGYV3+Z3rOVti+pfzgYK3cYYi0JRhdD5MPsyLzflTrKR9dnVauq1Nv8HGmsx yjQ9XdiwbIOkcQMyqO3u0jdhC6hrYTISQhz4RjLWmWi7UVyY4vNi5GU1GU3JM1odO6xJmRtd lBf8yRCxIji1a2wqRE= IronPort-HdrOrdr: A9a23:xcDFs6+DnJebvU7pRxZuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.92,281,1650945600"; d="scan'208";a="76060007" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ANnFqDytOVrpsd726MqAeRdkc+Nwox9cNhlS7ppaSca1HncMw+boW4ye7OVYqICivsJJe49Do554EXxKtiZ3pk2A47EpHwi4kgIJv+2dYCqGcDkB8PqNTViFAzUtegDkCDPPVdJG2vf4+4Xixck/IM+2T/d8sBAiw7Kbo90K4h1vk0VSk9hW8uQ6cNZEqpCt0wOxwkP2PoOjI2Rkz/lLpoN17OdkSQ+yIVn9aHjCEIDZy3xOWyiC8UiPI9mG+xktZVzW1kF2bjB0wV3NO5csQ46w439SQ/UjGiL39dxJ3jnKorDN2nqqxvMi3bHJxa+PjK9UaKEvDkZVkABJd4Jyjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bpEeEnMoazSH37zmBTpeDyfR94GPgA7oxIZzCUgfafM=; b=LnMN5HNjdRcl50njd9wNTQGaHZUGXrB2OJUMBQQO+ugErDowzAyggiEWC98P65sZZ1FcEd6nna0T0m5mn8SSDTS0ebuYrZDg+pcwkWTJPfTedJ/rvHReaGr43OQAhw6B9QpMqw4kUjCUPf/rj73GuqNCVJmzZlOB8Et3N8bgQEnb1lqlr/9MaZlJMrlq8iC5MnM1volgv8TkoM5yvzQCFRe3q8ZV5PJ+YDfUMDxJsFEEslY5ltG4mlYLyB7L32HS2Gbj/iGzBkKn/ko3Up03ZtyFT0y7IB47RT0zCwMwNpXvdF+zC6/D6q1iSRdPGvvI2fGMMX0tT2umgb81NrTLwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bpEeEnMoazSH37zmBTpeDyfR94GPgA7oxIZzCUgfafM=; b=tD/vhFsyfPhRU6yqTz2w+HXGATXddZAflvsI9UX4EnWl8hESC0QXh6ML5ojesNl17KXdrut4sjTlP5xfcQ2eLMEZZxfDoDXUvqVwWbPFm+vwBYJIFZR7m7cw46MB//wVzLKVWKTas2jcgEYDbQPavqY8yLsR1gIRblLf30PZnOI= From: Andrew Cooper To: Jason Andryuk , Jan Beulich CC: Roger Pau Monne , Wei Liu , xen-devel Subject: Re: [PATCH] x86: Add MMIO Stale Data arch_caps to hardware domain Thread-Topic: [PATCH] x86: Add MMIO Stale Data arch_caps to hardware domain Thread-Index: AQHYmq9yYQzuH8tiwky2K0QD3c10L62ELQqAgAAEr4CAACvLgA== Date: Mon, 18 Jul 2022 17:11:40 +0000 Message-ID: <508d27ef-0a8f-5436-1cec-831910a27dc1@citrix.com> References: <20220718140517.14771-1-jandryuk@gmail.com> <3842b4a4-c059-1eb3-c292-f53c5357e502@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67af4cc0-1d68-4b86-12b9-08da68e09490 x-ms-traffictypediagnostic: BLAPR03MB5505:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OH/WHOrHU+K5FPboRb8aXwEQyOS6CYJTjV53N9XiOTVmsHpQm7UYSXXVXoBbYqlcaVRzskGMKiIFuWIQR+xfOkT6dynYgh0JOgbCa0rUi99jOQHKP6eIzTf91rSH7Iw9U5c/Kno9QPXowegRZCiOj/3I5tVrV1IEIuzWcpPnXw+6CRKzndtFqEtQs8uTqbFR+HNxWqhSk7tg69Oj+CRRRYhb+ZSXHWUiK4E0fnst+3b6pxEP5ZCoZ52xbS3Iaulb5ZqA5Cg0nuZ1vl+QU2I9aX5g9QRiG6O6yu0CeInFfpmn6hI1PJ7GU+7yRg0IaeGa4jBeuyXAzcVgA9MDrZBxubmXxc/lLEHce1D8a/f6Q/gGSaPl0W6ASfEDrKY1JK61m13y3fSwdpWMs803hvoRrIdnGwFMzOZWH9LsMC/vCtTRqrz9Kq9GfiZeq7qHGlEjxnugPJlYBL7l4OoJZm/2a3f57ldm/l2w98S7Nb/5wNQPUvHwAOUTk6w73DcstbTE3AfqHkDCiq2DLzwuQSegOUIJ/rpMQMKYbqG7TASvwq++3MWEeIMGS6D6+DD8JqcABi+1qPhhstF8imsu7GiDBH3xhJIu36fZfaFNKOgjSUEwrC9IZrJIIgmbbJ9M9IvmUfL5G8s2QWmF3+iZvPWo+HopC08RPlpGAsULqzty3I1qs3inKaXGK0pEJPibj2SKgL6YUEPX0IrTtsaHAqG7kiH1UWtvY+QnSq4Fh0Oam/F/1OI6VyysK/GV1WDCfDB3SDP2/tMnlzbTMxcHLozXPbBBq6MHC+76J6XoAaqsD+GaQOducWMEfJRpucsEocW7Ozma/dLQMnIjEK3om/5NgGiTZmA2kk1gbWyKOqq5h6mP5tCGm2IH4G4DNGC9ggRF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(110136005)(478600001)(66476007)(8936002)(66946007)(91956017)(64756008)(66446008)(4326008)(31686004)(76116006)(71200400001)(66556008)(8676002)(86362001)(316002)(6486002)(54906003)(38070700005)(31696002)(2616005)(36756003)(38100700002)(6506007)(53546011)(2906002)(26005)(6512007)(122000001)(41300700001)(82960400001)(5660300002)(83380400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MW0wWDdKMFluSml6MGE3ZklyQ1JLbWlqTXNQRTZLVG1oa2tJUzV4RlhzVWFk?= =?utf-8?B?WjRpbVNBdEI5Q1JpSjRybTRhaEx1QU9MajlTWWo2dUt1b1N2UGJsSjYwa1V1?= =?utf-8?B?b2VaWTRvM0R3OGJtYmVLYnAydFZ5MFBqa0JkZkJHbFg3ZEppU0pieUNqbVFI?= =?utf-8?B?bDRhZ3ZyR1JWMk92T29xYklKcksrTzNxWFhYS0xRdEhUMmJzdE14SjY5K2l0?= =?utf-8?B?K01JVjkrcU80U212a01EeXBRcmhEMDJrRXErSzA3RVdHM2F4ZzZ3andUYzRa?= =?utf-8?B?WU54VlNwVWhUNzNIMytBaTVPMGRFN0ZlNSs2NjRnVTRpdFBrelBBdHFZL2Fh?= =?utf-8?B?eHdCdkZIc0loclBrQkhtdG9HL1NCSFlqZ01GcitDNlNiZ3p1RmdHNHpiZEU2?= =?utf-8?B?amN6N2FWY2dzT3NEWkc0OE15RUN2RkQ1U0dRQUl1Q3NublZzeFN1K1J4L0V2?= =?utf-8?B?QW1BR3h0Qmx4emUwNFVIVUtaVG5UbG45V2NKREJKbTBiVDRDSlIySjhqZ2gx?= =?utf-8?B?dlR4VWdtVWNQeWRMdFlsN1RYSkI2T05hc3k0TzN5aHlJVmRNTXVxSnRZemRp?= =?utf-8?B?cVRIUmJlYXVQUnRrWStKLzZuOEZNTW4zOGdlMlJ4azAyUlA1YUNqV21YVzJu?= =?utf-8?B?eTNBaHJNUU9MUWc2bG5GOXJKVzRhZERGdjA1RlJuK3FaT3VIZWxmb1JSLy93?= =?utf-8?B?YldYVVJsVytUVHhuYnM2anJka1VhU1IxVzVHRWlqck9VZG1BZjJMcVc4cEp3?= =?utf-8?B?eTljQXhNTUFDMi9MdjVLazNaMFNJZnpsdDNBd1hsWjJrUVZiT1BscnRUaXJU?= =?utf-8?B?ZWI1Umc5bmorSEZFREdSUWRmM2FaUUN1UmE2dWtCd0IzaG9aR3pyL2piSkVk?= =?utf-8?B?czlYQ0lIYldkL0JjVnpzYXJsMy9sSnhpa1MyZ0c5YmJ3b2ZWYXUrR0NuNW1L?= =?utf-8?B?US9hV2gvRW1vU3ZMbGhJNURoUGYzZFI3aDN3d212S3VxbkpDTU15cXAzckRD?= =?utf-8?B?b0M2ZFhBVzlONlg1OENUYkZCWTNJb3c4Y0EydWx4N0tzcXdwZmVaeHNrRXNP?= =?utf-8?B?OEt2SU5xNHYzY2VlbG0rWmxkbVBPSWV6dGZITndlSzYzWXd3dDBVeHhPMGdX?= =?utf-8?B?dUo4NzZGNkNvWkNQZkNtM0tPcEhuNXhpaE9aVU51ZWdJbFZuODQrYlg4MHJI?= =?utf-8?B?WTRwZk16aU5rc0VyaC83Qnhwa3loeGg0WWhPQ3oxWHBuRTFsSXkzR3dielZ5?= =?utf-8?B?Q2JOWGx6TkZHeXJ3WW9GVjd2YkNzUFk4R1RPZTUyZm5pVmZ2eHhYWkRJUHhT?= =?utf-8?B?TGdvT0kvVXNRalpycG1mZ0dnUHExbW93SXUvRzlmdjZKK0Exb1hYOFFJNG5S?= =?utf-8?B?N1g0aStvM3ZSNUNzMklKWW1TdXFscFM4RjEyTWVjOHpFeFNzT2wyK2ZMNXdy?= =?utf-8?B?WjdSQTFGTkZKTEZ2bDNzQWRFcndQZWZIMnFPUUVtRFVOZUlDTFhIblorWGZ2?= =?utf-8?B?eHZRM3NiSkdvYTErdFl3R1RZQ3ZYemRLV3FHZGRmeXdQWlNQZlIwZjBxM3ZB?= =?utf-8?B?bVdkWCt1Nlp1U2lZbDhobEtHTXdmMS9IUDR1RWt0WVVaU1NWY1NqMUlkTUxD?= =?utf-8?B?SnJTOTlGL2JtL1doVExsR2lVM3NVcFRLaXNxWTVPajBJVWxpVVkzeVJZUFRZ?= =?utf-8?B?eWs4dWpuSkFXL20rUi9jSUpnSFFxS01yeXIyYUFpMnE1VGJvSnhuMmlPbkIw?= =?utf-8?B?N1BPNUZNbnVnelRXakNtL3djS3B5ODU3aTIraCt2R0dQbGVRQzg3N2M0K1Nq?= =?utf-8?B?TW5TU1dPS0RkMndvcFJOOEJYWkZSSUJyUTlIcGNyNnVucDJEbXpUcGdlVkFq?= =?utf-8?B?OE15L001azBCMURyL0hoc2w5cTl3VWFkTXNnaE5kc0JoR3lQeXFzOGprYmNm?= =?utf-8?B?YmtYdTcwU2NZd3ExcjVNek12S0tkdVRMczY0RlZvYzZzN0M4Rk9kdVgrVDU2?= =?utf-8?B?RUxmOTM3dEhSQTVQWGpQT093NlJKckJPbGgwcGdvaUo1MlRkT2FlVjVkOXFY?= =?utf-8?B?enJMcXhDaDcxWXphNlRPSHJQK0FNd3JPZDQzVEZmWlp0bjFJWm5rVUczUnBv?= =?utf-8?B?NmtxcUcxaVFDcFdiL3lvd050dHB2TjRnNllWbGh0MHdidlJjREhva2ZNb3J1?= =?utf-8?B?SWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67af4cc0-1d68-4b86-12b9-08da68e09490 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 17:11:40.0623 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WEReWpVw0CQ5Ziuwis8YsCfZiH3J/xUEpyH9tlwKrEitITXntG6hfta2c0MaAm8mp10iBwSrNvh18ydZEcwQAncx31wldRn4AUmLJ7xXA7Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5505 T24gMTgvMDcvMjAyMiAxNTozNCwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gT24gTW9uLCBKdWwg MTgsIDIwMjIgYXQgMTA6MTggQU0gSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPiB3cm90 ZToNCj4+IE9uIDE4LjA3LjIwMjIgMTY6MDUsIEphc29uIEFuZHJ5dWsgd3JvdGU6DQo+Pj4gTGV0 IHRoZSBoYXJkd2FyZSBkb21haW4ga25vdyBhYm91dCB0aGUgaGFyZHdhcmUgaXQgaXMgcnVubmlu ZyBvbi4gIFRoaXMNCj4+PiBhbGxvd3MgYSBsaW51eCBEb20wIHRvIGtub3cgdGhhdCBpdCBoYXMg dGhlIGFwcHJvcHJpYXRlIG1pY3JvY29kZSB2aWENCj4+PiBGQl9DTEVBUi4gIC9zeXMvZGV2aWNl cy9zeXN0ZW0vY3B1L3Z1bG5lcmFiaWxpdGllcy9tbWlvX3N0YWxlX2RhdGENCj4+PiBjaGFuZ2Vz IGZyb206DQo+Pj4gIlZ1bG5lcmFibGU6IENsZWFyIENQVSBidWZmZXJzIGF0dGVtcHRlZCwgbm8g bWljcm9jb2RlOyBTTVQgSG9zdCBzdGF0ZQ0KPj4+IHVua25vd24iDQo+Pj4gdG86DQo+Pj4gIk1p dGlnYXRpb246IENsZWFyIENQVSBidWZmZXJzOyBTTVQgSG9zdCBzdGF0ZSB1bmtub3duIg0KPj4+ DQo+Pj4gU2lnbmVkLW9mZi1ieTogSmFzb24gQW5kcnl1ayA8amFuZHJ5dWtAZ21haWwuY29tPg0K Pj4+IC0tLQ0KPj4+IFNob3VsZCBjYWxjdWxhdGVfaG9zdF9wb2xpY3koKSdzIGFyY2hfY2FwcyBt YXNrIGFsc28gYmUgdXBkYXRlZD8gIFRoZXkNCj4+PiBhcmUgbm90IGlkZW50aWNhbCB0b2RheSwg YnV0IEknbSBkb24ndCBrbm93IHRoaXMgY29kZSB0byB1bmRlcnN0YW5kIHdoeQ0KPj4+IHRoZXkg ZGlmZmVyLg0KPj4gSSB0aGluayB0aGlzIHdhbnRzIHVwZGF0aW5nIHRvbywgeWVzLiBJJ20gYWZy YWlkIEkgaGF2ZSB0byBsZWF2ZSBpdCB0bw0KPj4gQW5kcmV3IHRvIHByb3ZpZGUgdGhlIHJlYXNv bnMgZm9yIHRoZSBkaWZmZXJlbmNlcyBiZXR3ZWVuIHRoZSB0d28uDQo+Pg0KPj4gSSB3b3VsZCBm dXJ0aGVyIHN1Z2dlc3QgdG8gYWxzbyBjb25zaWRlciBhZGRpbmcgUlJTQkEgYW5kIEJISV9OTywg ZXZlbg0KPj4gaWYgdGhlbiB0aGUgdGl0bGUgd291bGQgd2FudCBhZGp1c3RpbmcuIEFuZCBmaW5h bGx5IEknZCBsaWtlIHRvIGFzayB0bw0KPj4gYWRkIGEgcHJvcGVyIEZpeGVzOiB0YWcgKG9yIG1v cmUpLCBhcyBpdCBsb29rcyBsaWtlIHRoZSB1cGRhdGluZyBoZXJlDQo+PiB3YXMgc2ltcGx5IGZv cmdvdHRlbiB3aGVuIHRoZSBiaXRzIHdlcmUgaW50cm9kdWNlZC4gSWRlYWxseSB3ZSdkIGhhdmUN Cj4+IGEgd2F5IGZvciB0aGUgY29tcGlsZXIgdG8gcmVtaW5kIHVzIG9mIHVwZGF0ZXMgYmVpbmcg bmVlZGVkIChvciBhdA0KPj4gbGVhc3QgYmUgY29uc2lkZXJlZCkgaGVyZS4NCj4gVGhhdCBhbGwg c291bmRzIGdvb2QuDQoNClRoaXMgaXMgYWxsIG9uZSBnaWFudCBoYWNrIGJlY2F1c2Ugb2YgdGhl IGZhY3Qgd2UgZG9uJ3QgdmlydHVhbGlzZQ0KTVNSX0FSQ0hfQ0FQUyBwcm9wZXJseSBmb3IgZ3Vl c3RzIHlldC4NCg0KRnVydGhlcm1vcmUsIExpbnV4J3Mgc3lzZnMgZmlsZXMgYXJlIGxhcmdlbHkg bm9uc2Vuc2UgaW4gYSBQViBndWVzdC7CoA0KIlNNVD11bmtub3duIiBpcyBhIGdvb2QgZXhhbXBs ZSwgYnV0IG90aGVycyBuZWVkIGhlbHAgdG9vLg0KDQoNClRoZSBjYWxjdWxhdGVfaG9zdF9wb2xp Y3koKSBsaXN0IGRvZXMgd2FudCB1cGRhdGluZy7CoCBUaGF0J3MgbXkgZmF1bHQNCmZvciBmb3Jn ZXR0aW5nOyBpdCdzIHRoZSBmaXJzdCBNU1IgImZlYXR1cmUgbGVhZiIgYW5kIG5vbmUgb2YgdGhp cyBpcw0KY2FsY3VsYXRlZCBhdXRvbWF0aWNhbGx5Lg0KDQpUaGUgcmF3IGFuZCBob3N0IHZhbHVl cyBhcmUgZXhhY3RseSBhcyBwZXIgQ1BVSUQuwqAgcmF3ID0gcmVhbCBDUFUNCnZhbHVlcywgaG9z dCA9IHN1YnNldCB0aGF0IFhlbiB1bmRlcnN0YW5kcy4NCg0KSW4gcmVhbGl0eSwgdGhlcmUncyBh IGxvdCBvZiBoYXJkd2FyZSB3aGVyZSBtb2RlbCBjaGVja3Mgc2hvdWxkIGNhdXNlIHVzDQp0byBz eW50aGVzaXplIGJpdHMgaW4gdGhlIGhvc3QgcG9saWN5IHdoaWNoIGFyZSBtaXNzaW5nIGluIHJh dywgYnV0DQpkb2luZyB0aGF0IG5pY2VseSBzdGlsbCBkZXBlbmRzIG9uIHVudGFuZ2xpbmcgbWlj cm9jb2RlIGxvYWRpbmcgZnJvbQ0KeG1hbGxvYygpIHNvIHdlIGNhbiBzb3J0IHRoaW5ncyBvdXQg bXVjaCBlYXJsaWVyLg0KDQpJIGFncmVlIHdpdGggSmFuIHRoYXQgZG9tMCBzaG91bGQgc2VlIFJS U0JBIGFuZCBCSElfTk8uwqAgVGhlIGZvcm1lcg0Kc2hvdWxkIGJlIGVudW1lcmF0ZWQgZnJvbSBB REwvU1BSIHdoZXJlYXMgSSBoYXZlIG5vIGlkZWEgd2hlbiBCSElfTk8NCm1pZ2h0IGxhbmQuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 17:39:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 17:39:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369990.601610 (Exim 4.92) (envelope-from ) id 1oDUi4-0005wf-VA; Mon, 18 Jul 2022 17:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369990.601610; Mon, 18 Jul 2022 17:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDUi4-0005wY-Rz; Mon, 18 Jul 2022 17:39:08 +0000 Received: by outflank-mailman (input) for mailman id 369990; Mon, 18 Jul 2022 17:39:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDUi4-0005wS-1z for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 17:39:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDUi0-0004DQ-Dq; Mon, 18 Jul 2022 17:39:04 +0000 Received: from 54-240-197-231.amazon.com ([54.240.197.231] helo=[10.7.237.21]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDUi0-0002kq-7q; Mon, 18 Jul 2022 17:39:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lJPhKBGAbseUHfu7daN4peHCxF/nHRM2kxGLurhaQsE=; b=OUumpu6AIW/5grr1tn4oKyCA2A ehUitDkgciaCSttx203kX0Y9fvum5NPFeruUdfGKUo8PrGHUV2OpqI93wul4lqujG1KK5h9L5Umxu OepcjXXRIUtLs9+UmYFYpjR16w5VG2vV51LSNS2kbSjExG+xLmvTIvdz6BqPt2Z/Tt4c=; Message-ID: Date: Mon, 18 Jul 2022 18:39:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> <097e8634-0c5b-35ac-6ad6-5b83d9b29f64@suse.com> From: Julien Grall In-Reply-To: <097e8634-0c5b-35ac-6ad6-5b83d9b29f64@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 18/07/2022 12:02, Jan Beulich wrote: > On 18.07.2022 12:24, Julien Grall wrote: > 3) > unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1); > > if ( s ) > inc_order = min(inc_order, ffsl(s) - 1U); I like this idea! > > No compilation issues to expect here, afaict. Correct, GCC is happy with this approach. Assuming there are no other comments, are you happy if I make the change on commit? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369998.601621 (Exim 4.92) (envelope-from ) id 1oDVAx-0001JI-AR; Mon, 18 Jul 2022 18:08:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369998.601621; Mon, 18 Jul 2022 18:08:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVAx-0001JB-6u; Mon, 18 Jul 2022 18:08:59 +0000 Received: by outflank-mailman (input) for mailman id 369998; Mon, 18 Jul 2022 18:08:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVAv-0001J5-Gl for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:08:57 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af728146-06c4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 20:08:55 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 21D715C0138; Mon, 18 Jul 2022 14:08:54 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Mon, 18 Jul 2022 14:08:54 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:08:53 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af728146-06c4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1658167734; x= 1658254134; bh=Q+2bcuYbqNaeJUyXlpoGM3BHR0EjVdzO4fH/v0jEPL4=; b=K FkuLtwY8N/NT+897LsnwrmqResDCTsmeNkRGz3A4D3IKhIHhReJBdgxGEoglt8lz t61FyVx/GsuH6AmhqZ38839vURcVrFYkv20tkQA9jQ5vR7f9QOJA/SkanhWDmA/y GuPLaciVjfUAlMPq211+3XLfQ/HQ9vXP28mLMjidgW6pDnDwC6Os9AXFyBKoRe9m 1vm1GymUnpzZXWpVKRbd3jn21WapiKGr+flz0RH8GnbITVf/OsnazMtkyxCfSOzO 7+UCRRjYB9C7iCYUbRGNiNF0+izwCTRXjuyJ1OfleorZjNzEZuis1qV0RwX2A4+J 5HWGgeTxZZKdLpOJL1uZw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1658167734; x=1658254134; bh=Q+2bcuYbqNaeJUyXlpoGM3BHR0EjVdzO4fH /v0jEPL4=; b=lSA5Fe4ygcts/JbmilaClF0qUDFhO1v8zGlO49buFQIxkpBkCjc McN43T2+kEcMDKdVPi+JvNpeculuYe+NotAGpPd2mM8IAsfZHnMhvDlJhYQ0sGXg W3r8+p6wO47FwElGock0/nexZQPlWbC4sQ6+iUHnhbxtjVjHOn0w1SKR7jAFqBzQ ETeQrynfaCoi0n5T0ZbbMTMGCDt5yPOScnZt0FUHgDOtciZMET5eFGWTaKygc0AM Dlj/KIiQw11ksh9R9o49qAvzbJwNI3EC4dzbAXyxBUG9Wt/tsZjGNsC8IYplR2Vq qIcixAAgWOGO7Oi7uG+btMtCxr2ucmlxNUw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Backport of 166d38632316 ("xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE") Date: Mon, 18 Jul 2022 14:08:16 -0400 Message-Id: <20220718180820.2555-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series backports upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f to all supported stable kernel trees. -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.369999.601632 (Exim 4.92) (envelope-from ) id 1oDVBA-0001cl-La; Mon, 18 Jul 2022 18:09:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 369999.601632; Mon, 18 Jul 2022 18:09:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBA-0001cc-IY; Mon, 18 Jul 2022 18:09:12 +0000 Received: by outflank-mailman (input) for mailman id 369999; Mon, 18 Jul 2022 18:09:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVB9-0001bm-2E for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:09:11 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6cbde1f-06c4-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 20:09:08 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A70405C00C5; Mon, 18 Jul 2022 14:09:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 18 Jul 2022 14:09:06 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:09:05 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6cbde1f-06c4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658167746; x=1658254146; bh=9EVYFQs3TfjexPazUkgkLFWSM4eN+61vSya zDvU3JXY=; b=D3Otbn+w9zgEgOzUpLm3pClk07nfXG50Dt/6CcsQlNjM9PfPEz/ VbuvRVBlrYrrgZbD+HDhBHLUoywquEgh+6OfGTao9Ko1zYukMfuUyIzm1W4dcPE0 zI6dGadXxfzLNzyQLGjNjAsm2S2v4Iih7ZQ0w1p6HAYPmcne0ppKhfgnY5w3+CtZ zmZnknZx6t/1DTrpzWypMruZKd16AJGfKgK1dqcc/EUwuXkJpJANAkv/xjTNZhGb bXUrBtexNOxCB1T+y706BXIoKRvJeiBVPPQmg9eYzSqKnRhQNFORzcSYIB2zxgDA 0Yo8pmLdFhyZugbg+JrveMK5kpXQ7YmLmYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658167746; x=1658254146; bh=9EVYFQs3Tfjex PazUkgkLFWSM4eN+61vSyazDvU3JXY=; b=KWVz+WBPo4wOHR+z4RZpBCV9hQosu o3HEjIvXLc49G0rE6pJ14HFj+Idp8hNanjbdKg0w0uXReFUVX/wDKviIOcSWH2i9 q2jlTrJE/Y5bqUD2ObM+QJjd86FCL/fKGlHHzZSrJL+FsbJDXst00vYIieKZpt6G 2hXepp5R9NZul/A2G6bRv/hgb+gEhTJX3+wyoa3y7gbmh8olfLA8ZXyFwLkEnq3z UrsbW1jYLF2faP2vQpwzUjWLsKm3pFgXWC4aXq7zFHGtjdtXMMWoVKbOGdDd20qc luNBVYlkia5VgIBy1e+MojiSms9YuvlUU0PmtYZuF04vNfIDh2zKOKYYA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 1/5] Ignore failure to unmap -1 Date: Mon, 18 Jul 2022 14:08:18 -0400 Message-Id: <20220718180820.2555-2-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718180820.2555-1-demi@invisiblethingslab.com> References: <20220718180820.2555-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 36cd49b071fc ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 2c3248e71e9c1a3e032b847d177b02855cdda1a1..a6585854a85fc6fffc16c3498ba73fbee84ad6ca 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -390,7 +390,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370001.601643 (Exim 4.92) (envelope-from ) id 1oDVBH-0001z0-SH; Mon, 18 Jul 2022 18:09:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370001.601643; Mon, 18 Jul 2022 18:09:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBH-0001yr-Pk; Mon, 18 Jul 2022 18:09:19 +0000 Received: by outflank-mailman (input) for mailman id 370001; Mon, 18 Jul 2022 18:09:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBG-0001bm-E0 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:09:18 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bce05183-06c4-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 20:09:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DBD525C00BB; Mon, 18 Jul 2022 14:09:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 Jul 2022 14:09:16 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:09:16 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bce05183-06c4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658167756; x=1658254156; bh=Du7er5SQVhxuW3kUx1splIMx/vSJydk7q3s MOCxCorg=; b=4dJ5goc6lMYpkem4v7o0ERbl6Z6YhuumCMBlSRxOvFg0jvk7YwI sVMEMUjXtRtJAHJnnsgpocnodLF8ieMPtT/cpJQkpBs58UUG08qDLAU60JRP4aKm 8+u7+j35linn7XIUsqxE9e8CiDJVoVfvnkU7MCZgAO1tbAw4bObe/NRCpKtrJT/y uceV39RxjJ7zowQecrHKgZHrhOKKv/lASOluv7HC30djWqpJEJ/cyg/yC7FHPZKC Nq+BpuJMjBVW0FD+5uyAXbh9cYEFaD+tlwIgXkp1Hty7a/CftjbkcltkXt0edJQU SsaRLtNaE3TZ6tLLGIKQRA2KQm39r/3QH2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658167756; x=1658254156; bh=Du7er5SQVhxuW 3kUx1splIMx/vSJydk7q3sMOCxCorg=; b=XbBcUBFLu919Z6KwAfeQGFr4KczHL SwfOLg05B1OciMLBoBl2NHIEBcq0e609ejTlYa/gN2Ue5yUQLLTmk5rOqE7y2hO/ eS9KMQBK9E39Y6ldIZFd1E6LJ0AfOZTjUlP4OWQYe3D9gbDWYHnBCspGIpsYk9+d cgmn76Zql7XYJwYJZk05ADfpWSVi78SVhIlCzdR32o2bb9nMlgz2G1kUVP97eMvw sHasNyN3Drr+MGZfmTtiZxKWq7tlij1e3fTSmwZlrqYr/oiamgZz/mhSjIKSlWNK H4RKC3PiwWfse/bi5YjgLa0da78A9D+6Ijci8Tw/koHccbrv9egEKlKjA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 2/5] Ignore failure to unmap -1 Date: Mon, 18 Jul 2022 14:08:19 -0400 Message-Id: <20220718180820.2555-3-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718180820.2555-1-demi@invisiblethingslab.com> References: <20220718180820.2555-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 2fe26a9a7048 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 2827015604fbaa45f0ca60c342bbf71ce4132dec..799173755b785e2f3e2483855f75af1eba8e9373 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -393,7 +393,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370003.601654 (Exim 4.92) (envelope-from ) id 1oDVBK-0002He-5C; Mon, 18 Jul 2022 18:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370003.601654; Mon, 18 Jul 2022 18:09:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBK-0002HT-1r; Mon, 18 Jul 2022 18:09:22 +0000 Received: by outflank-mailman (input) for mailman id 370003; Mon, 18 Jul 2022 18:09:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBI-0001J5-AM for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:09:20 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be037867-06c4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 20:09:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C5BA65C0136; Mon, 18 Jul 2022 14:09:18 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 18 Jul 2022 14:09:18 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:09:17 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be037867-06c4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658167758; x=1658254158; bh=zetN2Gdm7SQF49L9d/RaHd27ZFZZJEqIZva 4v9uU+Uo=; b=MyGqT2z9GBTFrKYQ/kjsuueYUB/qcbvKvzqSkuRT/sH8woIPgVH As0fUMduWrZ4wCc/Nurhl17cSHwghbe+q5S+U6A9C5iSX/Vnv82sNZEBrJjNA2Or 0dIrt9jPrmG2cSDgk91g35AXwYDehPBMRIrUfY05zsu57U3gl6o9aYIslsaNpu14 wBasI0U/q0UZlyiuiMvciVFRuS2zXFSRQH6EQUVU1osNxqdMpzvvACHBb4lbMUYs /QKOSppcsUPjJd2opPcDsgwZbB17ZTc1+AX0um88hKDZgnWtob68GS9mnRvLHNvc 7LMJv45BxxcHJ92+P5KNZ27U2CHyLI7T3zA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658167758; x=1658254158; bh=zetN2Gdm7SQF4 9L9d/RaHd27ZFZZJEqIZva4v9uU+Uo=; b=hChnZsCnCeM7i5qyYiHA08uFDvtS1 RmChDdLXcnweH5uJl5gXVt5moXdW13Y3A9CsIasGtrUs828+1M5mW9qiiG0vd7Yi d7lgPt3/QJLuw5YWDn76zYgc1lnJdMGVyPj5jRSib6bB8auTuK3PqQMJxsEH4A7z HuJgU1M4RFdYoNB3CZcj9Rfl2l9MD2oUgY/dMAvtVLAr/DCu6Iqz/0Oi21M91eR1 0tAA8uIeeD1z6KjiaYvIap+7mzeihX5jNXYto3x2upBukbgOMMIMHuEiDAkgAPhm yiWqH0usd5hKx3Lq0z6GNgWoOEgvfu97NQIH+LUDEKTTUbhUH97DsbT0w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 3/5] Ignore failure to unmap -1 Date: Mon, 18 Jul 2022 14:08:20 -0400 Message-Id: <20220718180820.2555-4-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718180820.2555-1-demi@invisiblethingslab.com> References: <20220718180820.2555-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 73e9e72247b9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 492084814f55d8ed46d2d656db75b28a91dd7f06..27d955c5d9f9076266f77b9fedfa1a6a2ba08f56 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -416,7 +416,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370007.601665 (Exim 4.92) (envelope-from ) id 1oDVBM-0002cm-FF; Mon, 18 Jul 2022 18:09:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370007.601665; Mon, 18 Jul 2022 18:09:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBM-0002bx-B2; Mon, 18 Jul 2022 18:09:24 +0000 Received: by outflank-mailman (input) for mailman id 370007; Mon, 18 Jul 2022 18:09:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBL-0001J5-IZ for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:09:23 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bee64ef5-06c4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 20:09:21 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 498735C013B; Mon, 18 Jul 2022 14:09:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 18 Jul 2022 14:09:20 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:09:19 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bee64ef5-06c4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658167760; x=1658254160; bh=kIshqhgj647286FiEwZIn8F2MuAyAKY1Gro 0c4s+gcU=; b=p7zAmQtT9+CJjEyLPQ+PxSOJn5fhxPBbVLVhIAVWUZ73lievbgn CCqgqUru/ZzrVEMSEJF3C8JE0wmzWkevqvM8D2SoLWkbN6pG/A6IBvQ6KR+AZhFY c0OFwPViWbdkCD5KXHx6OfGH2rzkQsmekmjV/XkChERbIcXQ2kyi3Tkg0LjzPVjR hRsgIJli0KCFZnftCBch5X2ork23FTC+HtnyG65Ga/5KTtXAH9S+xlOx8rQC0zx5 6ZZpw55H0OOhCpIgucHla+ZeQL7Kpsw+IipYPdtMnD4hCroe9YLBMJbyI46SXlqr XChU92pdUlY3U+RakilS+oP2nrjZ2n1+dmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658167760; x=1658254160; bh=kIshqhgj64728 6FiEwZIn8F2MuAyAKY1Gro0c4s+gcU=; b=JGVp7CSheLaV6MqKByzzgQEho/X9+ KVrjZo3uBqMf9X5/vmx1BKgc5+lVGScWGKRLQ58tG9OSOyyIHXCeKdbvG89l8sfy KLlZPhmW/ocIZU7y+wKxANBEOmNhDt1SgELYmxuv6OHSNw0qJ0Ad9C8Yi0gTIjXm RmAR4zaHszLrvJx0Bay92XrxckkbfdcjQpnPIGwKS7I6/HzZSfNiBMH2Q/CpaLPM yqEcL61dihtXpzupcv7vC0CSFkK45wxpSIZwVatsxNfO8GeZlGhP5Jb4npEVGTZl OPxvEQlGc+xuiJLfBVT1kcHfs8QBzDfXU5QHVfNODSXCiiB1wAOuS52DA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 4/5] Ignore failure to unmap -1 Date: Mon, 18 Jul 2022 14:08:21 -0400 Message-Id: <20220718180820.2555-5-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718180820.2555-1-demi@invisiblethingslab.com> References: <20220718180820.2555-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: ee25841221c1 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f464793477650e631c8928e85c1990c5964c2e94..bba849e5d8a7b4d54925b842fbe3c6792e0f0214 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -413,7 +413,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:09:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:09:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370009.601676 (Exim 4.92) (envelope-from ) id 1oDVBN-0002tW-O8; Mon, 18 Jul 2022 18:09:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370009.601676; Mon, 18 Jul 2022 18:09:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBN-0002tM-Jq; Mon, 18 Jul 2022 18:09:25 +0000 Received: by outflank-mailman (input) for mailman id 370009; Mon, 18 Jul 2022 18:09:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVBM-0001J5-Ai for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 18:09:24 +0000 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bfbee6e1-06c4-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 20:09:22 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id AF2185C00C5; Mon, 18 Jul 2022 14:09:21 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 18 Jul 2022 14:09:21 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 18 Jul 2022 14:09:21 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bfbee6e1-06c4-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658167761; x=1658254161; bh=flbY27l8SG12tvSsNQqmUwpFJSmusaEnV0T 4ZJqcCMU=; b=71MPLL0NWx9kTocP1rKjbOI78zXLHdgL3p6pHwlND3ZNdqwrV95 95VlL1cRX9c+y4rO2EefucIHkGNdJEwzGdKW4wOACzAsHTH8BYQGhXi99BJInVJp ZZBqXo4JJZDnkqPDA0dumkKWUi3chW6cL37v3wJgjsZpa2ASIUM4XcJqPLWsxotD VYb4liCDOqpLPisWVO/7buk5oZfWO390LIVdAJNVtsZvVkL711oKBjH6Art06DXx 9vvTQEBVfCuxfgfDxQlthGRogmgEqlJ+iYoUaVTNAY8BB/1Tt8bg82O+lrIGj+r8 1pVfu09UxNT5qs9/GaD08V4T/twa8rWXe1g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658167761; x=1658254161; bh=flbY27l8SG12t vSsNQqmUwpFJSmusaEnV0T4ZJqcCMU=; b=SLmdhozsqJqHWicLofNrlPBBwk1gl d5lDJvHq/db4rjY4QQoQMvS7x2WQOVmPvPWy7cPeqd/JBH/r5NWKqjqHeoPjoTSu OApdh20yhL6RmK+qGR1fdLy9kWCWOqeGawqqNQnSNuiZ9sdLFSHow5A0P4d6bZj6 Jso/wGqNEYC6ZpTHGHir3YVLpBNIdsOX5Rtl+0wn88IVSuk8porrxs7LsJBkKpE3 MGrO+42kx3kcnNtXuzbhoiG3M9TH5/tFq84xaDDjoPFee4MxgThZfXnheXBEgr8r xzsMuho9Ebb4UBMbosjw2BCW/dKxNxBv9m1jUads4vxcRjm4S+Htph4lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudekkedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpeffvghm ihcuofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinh hgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeejffejgffgueegudevvdejkefg hefghffhffejteekleeufeffteffhfdtudehteenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhg shhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 5/5] Ignore failure to unmap -1 Date: Mon, 18 Jul 2022 14:08:22 -0400 Message-Id: <20220718180820.2555-6-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220718180820.2555-1-demi@invisiblethingslab.com> References: <20220718180820.2555-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 79963021fd71 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f415c056ff8ab8d808ee2bacfaa3cad57af28204..54fee4087bf1078803c230ad2081aafa8415cf53 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -401,7 +401,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Mon Jul 18 18:19:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 18:19:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370042.601687 (Exim 4.92) (envelope-from ) id 1oDVL1-0005wW-V0; Mon, 18 Jul 2022 18:19:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370042.601687; Mon, 18 Jul 2022 18:19:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVL1-0005wP-SJ; Mon, 18 Jul 2022 18:19:23 +0000 Received: by outflank-mailman (input) for mailman id 370042; Mon, 18 Jul 2022 18:19:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVL0-0005vz-EZ; Mon, 18 Jul 2022 18:19:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVL0-0004yt-Bv; Mon, 18 Jul 2022 18:19:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDVKz-0003hA-SR; Mon, 18 Jul 2022 18:19:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDVKz-0005BW-S0; Mon, 18 Jul 2022 18:19:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=BmhJPuq5aIpQDU7mNGb8YYzjsCPVcKTxiMsFQa6wggU=; b=GFkG55b8vSxDwqZE+EedUPba/h C+NombKBVvXHoYgrXkWljkGWBDUgFhpJfDPU4TPQ0MpLdLfV1UunmT+bkbJCFRSzWCqgYdNHnlvFe Fls1FJ02keXCaZt1JNSTipVsd0TEhP8nAhaG4v0vfKbaimt5B++g0mdc/kfBEQEY/ggg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171669: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0af91dc0326cba12795e0b8fa8f665776e2a9e13 X-Osstest-Versions-That: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 From: osstest service owner Date: Mon, 18 Jul 2022 18:19:21 +0000 flight 171669 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171669/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0af91dc0326cba12795e0b8fa8f665776e2a9e13 baseline version: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 Last test of basis 171661 2022-07-17 14:00:25 Z 1 days Testing same since 171669 2022-07-18 15:01:42 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a5fb66f451..0af91dc032 0af91dc0326cba12795e0b8fa8f665776e2a9e13 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 18 19:03:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 19:03:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370085.601716 (Exim 4.92) (envelope-from ) id 1oDW1L-0004Cn-KL; Mon, 18 Jul 2022 19:03:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370085.601716; Mon, 18 Jul 2022 19:03:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDW1L-0004Cg-HE; Mon, 18 Jul 2022 19:03:07 +0000 Received: by outflank-mailman (input) for mailman id 370085; Mon, 18 Jul 2022 19:03:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDW1K-0004CW-N4; Mon, 18 Jul 2022 19:03:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDW1K-0005jj-Fb; Mon, 18 Jul 2022 19:03:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDW1K-0004qJ-73; Mon, 18 Jul 2022 19:03:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDW1K-00049b-6f; Mon, 18 Jul 2022 19:03:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=S7uPKV36qN6IIf2bwEHVnC9Tw9u/xlkJwV7EsFptu8E=; b=KZB1xSFG/ebLNDU3dhUrfLeZV+ KYAGg+DO2aXaIiYlsXgsKOwyX8VDqco8Ks8Vr4WXS9SywyPGW7yaURhepAbfm8/EaxMsljR01v/jb njldpd9+MfapY5CTzf8xN6+UsJxb8xmmDzmAXA06uO4Xn0AyGHsFLuChSgJ9AOAwKi9s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171671: all pass - PUSHED X-Osstest-Versions-This: ovmf=792ebb6374f2b92e2c4b84f5b8d151a129ed81cc X-Osstest-Versions-That: ovmf=fc4a132c0e9d108d30115cb8729f8fcd5564b855 From: osstest service owner Date: Mon, 18 Jul 2022 19:03:06 +0000 flight 171671 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171671/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 792ebb6374f2b92e2c4b84f5b8d151a129ed81cc baseline version: ovmf fc4a132c0e9d108d30115cb8729f8fcd5564b855 Last test of basis 171668 2022-07-18 13:13:08 Z 0 days Testing same since 171671 2022-07-18 17:10:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Pierre Gondois jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fc4a132c0e..792ebb6374 792ebb6374f2b92e2c4b84f5b8d151a129ed81cc -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 18 20:50:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 20:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370096.601739 (Exim 4.92) (envelope-from ) id 1oDXhP-00084D-Lc; Mon, 18 Jul 2022 20:50:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370096.601739; Mon, 18 Jul 2022 20:50:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhP-000844-GI; Mon, 18 Jul 2022 20:50:39 +0000 Received: by outflank-mailman (input) for mailman id 370096; Mon, 18 Jul 2022 20:50:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhN-0007oP-VX for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 20:50:38 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 455c523b-06db-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 22:50:36 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 455c523b-06db-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658177436; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yC7Ivklf/14kVov/1I8JhhkTzzgro3S/5NGgUE9lPQE=; b=YCVVRtFC7b9TsY7uUIMEpYYkkEd+Ro1DOQfy204avQU5hpeBFMEvqbwb ntFlGDN7xZFSJx8kgteY/I5nTBRrMLNAU07ESYu9jQk/6Ebxea1AMRsBp iU1czMaa1jh54w8xRO7nwF89xsFytl+zDv/1yKwULSdWqR39uj0xL8Eej k=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76073064 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AZcyVSqzokyGBA+lJ/up6t4n5zX1e4sY/ZkZSj?= =?us-ascii?q?/bM1gqfGCHpmQ7xbLELH0zjCQM2EUT3yIhaqDbNUz4aq/+7Nahbx0wH00GjT?= =?us-ascii?q?fXMwrY/o/tueGjOdIleLRyLAEtySNUbZmKTaQ9Vkdo/FPeseATPf28m9G/Uo?= =?us-ascii?q?gv4NssvxUGUdKvorEtYhuhcQRweQZ4i60FD7Fnr+qG8YcAZNFVqL7sS/+nQq?= =?us-ascii?q?leRV/EDR+WuSxE6WBLQsA1l7vCADXk954Ixb+Oa1esjZb3Zpu+FmTxQFI7lB?= =?us-ascii?q?D+rOlVubESwtFzTuBHRSzP0Iy4/hIiu+vn35ZLuwv4NpFjRkbYdOgQ5PcrOO?= =?us-ascii?q?5BkOJj3bMf2PNPcvo99QMY+mvm3liVNDkKTHb1LDvCeyzk8M2GxvIk9FcnE8?= =?us-ascii?q?2o3ZcaDEsQNTadDO3DFpANwTGr1OCerAo3oi+NET2t2cxnVpjX0WQrf/geSx?= =?us-ascii?q?XzrSl5+IWShlJANxGpmozi2DBxERM+cdzrMWmXBjCu2muiQb8CPYoPV/Rhch?= =?us-ascii?q?ihxq37UjUI5O+2rStAkTMbDqQqFEJF8MhKpmXL/cFIJVOjM3wtEMtuNLDCFq?= =?us-ascii?q?jQ6ibzoxMeG2g8KjvSXAdh8HBTHA1Uj70kUA64r39+eOd2Yxshb8N6z/B0xV?= =?us-ascii?q?zV9NOXEqmJ7UFHiOYcKH8ieAySVcVRZVk+6HL5VxpUU7SHCM7rmnVEVaNVxh?= =?us-ascii?q?iW1Dcz/xtXHjm9kw9Rm7k9Mh0tcVv8xDpWPE96R4eDwknqS4GiGAxSe4wKwb?= =?us-ascii?q?CqhmRB9Zz0xqFgQjBHPcWUoYUhFAgyMaxbq+RBB7BLnnYrvD196X5nDKKhWT?= =?us-ascii?q?P55YYNKSWhNc15WzpmvbFedImnTa6Z6JIAKfpFKKXX3lnLoTuxV6VnGbKjy2?= =?us-ascii?q?JAjRZmpARg0oAGrLHmoCD2rdKv0LrXZNP0WJkXH+V/yTXe9sVweR4u4iLEil?= =?us-ascii?q?te5OWPw+hfvBPplQgZY4HWQckhjNPld1zy+0fnF+4o+l/ulFxKyt8FM8kA3A?= =?us-ascii?q?uIuD7IgMukcR9hJYxo+Dle5LrJw2Mo8PWm214RZ0H6oHWWg5co3UOEdQPxXc?= =?us-ascii?q?RYCR0ELA5bntnqGLgj++JYdUI46rrj5n0Zyu3MS181JNu5VX4uVXh+CY3z5B?= =?us-ascii?q?YwTP5ZeU71tPjgCj8+ewTvWJ/BDap95VxXOSccbLzTATi2MZ9M65GqaLaT19?= =?us-ascii?q?ojSi/jEzyQArl1EC39jaopTEgoeqBhZ8bwsVSwS0vge9tdJZRik2lRknRPrO?= =?us-ascii?q?0EkPrznEpRcnPbwdPp3BIqZGygkfFkZ0+/JPbGo1ap9cB9WwsdGrpGLwxffi?= =?us-ascii?q?1gklMMEgATLVjr6MdIqTECWWFbZpBn4sMfR1VrRs0Uj/Kh4u53Ba032kXyOb?= =?us-ascii?q?0ScIUoqZi2O/btd4yD1pPI1WtDJQvliA0VyTP8MotwINiU3zS8mJTM0Q+eby?= =?us-ascii?q?0a86RIfeSNCJKiJ8+BTBhKFlLaM2aezfBw20TTRjyXnWWJpd2LQnteEKMyWC?= =?us-ascii?q?/YEoUkzbtDNWt/z5DMV9erjRUNOU1MPN5ignxAWql0oyKf8vZIhIFvSkYXpf?= =?us-ascii?q?CC04V6XgMLNyf6YwJvXLjRu1hKcunuOsRtlbvs3fRjuaU7HNmdTIEhZ/O2Mu?= =?us-ascii?q?CHEKq09+z5hC2iwOo4o8Qw8zV9521l4807XgyDdiysB/X2cDOBnTN+btCerd?= =?us-ascii?q?htaMy8+OWu1YQfDMfDttr/ePyNyHeDD84ExYG6brRfde/LS5tbioeBXEH6Fe?= =?us-ascii?q?gm5tvmgLBvO8cdvtNnVVw6iv1ZtFMOcjJ3ew4p9wb9CT/n0D3748rZOa7GAd?= =?us-ascii?q?a72AS7/IFl+La2S7lIKC161Xlfv9Osk401GZxlFnBRwrXPKqP4NxtyQE6u6c?= =?us-ascii?q?IenwA0FHhyQP1wTg3LjgvISkn4IMinrqfi6XqY3RzHKao1XFNgnO68VS9cHB?= =?us-ascii?q?eYaM6EpDi7gRsaYAnSKbEA8HhAPNJ925BOdo0NJSiArr7cGGD8ofjFGu1D8S?= =?us-ascii?q?3tmzXnE3PhmURQ3ucUfR5PEXp9rMeSmtW/ii0Y+vRfJ+YVtyUjChR0rvBTVk?= =?us-ascii?q?n6Fmjxv1gzD0kpvYWO7+MI2lwUNmAUaqJ/WUC0L7ceovpTpCFMtLL1/CjoDD?= =?us-ascii?q?sgWfcBSH4wg8SbGabEJv8VEpuFsK8ljZAS2VGlWT+2oEL4jvUwcmlUAsLfvH?= =?us-ascii?q?xP7XclKZ/TBfNrw3MzCpQEIYAtCKW9WavWZOD/dC1nR53mj+P0dVXzz9IR1q?= =?us-ascii?q?rTp5J7cs5JFcFjviZwvPT/+wP71Jc6HPQNSVWeq+6SEsSXoLZen0mqYm5Mhw?= =?us-ascii?q?bhBI6HuWPSJvLbAbTY750PhRPG8/oWE+buMOj0CPg/A4OdE858f9T6m22vyw?= =?us-ascii?q?MELPQizn5+rHW1NcjocAidXfFT3nr+roYi6hY/c52NWaV6h0P3cGH0+TdI6i?= =?us-ascii?q?tOVn02Iba/GIh6FueSbYwZd1Pc26g+IprvHhiYAGSqAohBSKRGi2iF0PiE/I?= =?us-ascii?q?mhBW1hY3qHCWTWP/qmRVRNHduFn9ys/iDsjehWBOAwS908GAwsWRNiCXpKDP?= =?us-ascii?q?UYmabtAX00g1rpZisGBLdFT7o8IHXp+Lctb3S3jKEE6SnnDhgt77Pn1JJp4i?= =?us-ascii?q?9nyLkvMvDQHbFXjfNZNoHdRgKiiXuMVhvlpRw8jTj9Rz+87tgdRFwfybY1el?= =?us-ascii?q?vAFI/tM2hGioLRvkMLfUQssAbC3BZMQ7e4zRCuMMwAUCuKpztGyShNKFdTFR?= =?us-ascii?q?ZJZrBsA9FpGycVQnjdj4WH+UmPk9KNYD2b1vHoxa67ebzDZtvrGvGex8dfbj?= =?us-ascii?q?VbAq2JemmVn7ONB3EWazVc=3D?= X-IronPort-AV: E=Sophos;i="5.92,282,1650945600"; d="scan'208";a="76073064" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 1/3] x86/spec-ctrl: Consistently halt speculation using int3 Date: Mon, 18 Jul 2022 21:50:07 +0100 Message-ID: <20220718205009.3557-2-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718205009.3557-1-andrew.cooper3@citrix.com> References: <20220718205009.3557-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The RSB stuffing loop and retpoline thunks date from the very beginning, when halting speculation was a brand new field. These days, we've largely settled on int3 for halting speculation in non-architectural paths. It's a single byte, and is fully serialising - a requirement for delivering #BP if it were to execute. Update the thunks. Mostly for consistency across the codebase, but it does shrink every entrypath in Xen by 6 bytes which is a marginal win. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/include/asm/spec_ctrl_asm.h | 11 +++-------- xen/arch/x86/indirect-thunk.S | 6 ++---- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index 9eb4ad9ab71d..fab27ff5532b 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -126,9 +126,8 @@ * change. Based on Google's performance numbers, the loop is unrolled to 16 * iterations and two calls per iteration. * - * The call filling the RSB needs a nonzero displacement. A nop would do, but - * we use "1: pause; lfence; jmp 1b" to safely contains any ret-based - * speculation, even if the loop is speculatively executed prematurely. + * The call filling the RSB needs a nonzero displacement, and int3 halts + * speculation. * * %rsp is preserved by using an extra GPR because a) we've got plenty spare, * b) the two movs are shorter to encode than `add $32*8, %rsp`, and c) can be @@ -141,11 +140,7 @@ .irp n, 1, 2 /* Unrolled twice. */ call .L\@_insert_rsb_entry_\n /* Create an RSB entry. */ - -.L\@_capture_speculation_\n: - pause - lfence - jmp .L\@_capture_speculation_\n /* Capture rogue speculation. */ + int3 /* Halt rogue speculation. */ .L\@_insert_rsb_entry_\n: .endr diff --git a/xen/arch/x86/indirect-thunk.S b/xen/arch/x86/indirect-thunk.S index 7cc22da0ef93..de6aef606832 100644 --- a/xen/arch/x86/indirect-thunk.S +++ b/xen/arch/x86/indirect-thunk.S @@ -12,11 +12,9 @@ #include .macro IND_THUNK_RETPOLINE reg:req - call 2f + call 1f + int3 1: - lfence - jmp 1b -2: mov %\reg, (%rsp) ret .endm -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 20:50:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 20:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370097.601749 (Exim 4.92) (envelope-from ) id 1oDXhV-0008PA-Sn; Mon, 18 Jul 2022 20:50:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370097.601749; Mon, 18 Jul 2022 20:50:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhV-0008P2-Oj; Mon, 18 Jul 2022 20:50:45 +0000 Received: by outflank-mailman (input) for mailman id 370097; Mon, 18 Jul 2022 20:50:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhU-0007oP-H8 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 20:50:44 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 490959ab-06db-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 22:50:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 490959ab-06db-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658177442; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HN3zIYBOlpweVbFPQUz5JRML8xTBSiJhocbeZtby2H4=; b=MdZDoReswkGyu7b/BVRLEYXQapj5d0SHZJacDI+prkJKRnhO+eFjbV5R cwlqTH7XBa8SX+72zXBmB1AvrWkz3KnsT5TDl3z/nGgdsLrWLkYLDcTg0 +I/YmLxABSeHJUSk7JBladU/nd/y75NsrYKL517KsJx0tHEp3TdmuPCF0 s=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76077190 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:5+6pNqqUeqbvsDsOvqI8meoA/VxeBmJvZRIvgKrLsJaIsI4StFCzt garIBnQb6uLYmbxc49+PYyxpE8OsMPTz4Q2TFM+rCthFnxE95uZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNOg06/gEk35q6q52pI5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUW2P5ZImtsz 8VfJSBXdz24xPut44KSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8+Dp4kkfjurX74azBC83qepLYt4niVxwt0uFToGIWLIoPVHJQN9qqej n7g/UvnBBMUCNKOxSSlqFjvtsTMsiyuDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWefhSN kgV8SoGtrUp+QqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8oxGqFwsfD1U7IiIUFxIo2Jr6u6IDp0eaJjp8K5JZnuEZCBmpn W3V/XBv1ulJ5SIY//7lpA6a2lpAsrCMF1dovVuPAwpJ+ysjPOaYi5qUBU83BBqqBKKQVRG/s XcNgKByB8heXMjWxERhrAjgdYxFBspp0xWG2DaD57F7q1yQF4eLJOi8Gg1WKkZzKdojcjT0e kLVsg45zMYNYSvzM/4vMtvhW55CIU3c+TLNDKi8gj1mO8IZSeN61Hs2OR74M57FyiDAbp3Ty b/EKJ3xXB72+IxszSasRvd17ILHMhsWnDqLLbimnkvP7FZrTCTKIVvzGAfRM7tRAWLtiFm9z uuzwOPQm0wDD7ShP3OHmWPRRHhTRUUG6VnNg5Q/Xoa+zsBOQgnN19e5LWsdRrFY IronPort-HdrOrdr: A9a23:C20Bzqyj5uIhy2543J2ZKrPwFr1zdoMgy1knxilNoRw8SK2lfq eV7YwmPH7P+U8ssR4b6LO90cW7Lk80sKQFhbX5Xo3SOjUO2lHYTr2KhLGKq1aLdkHDH6xmpM BdmsBFeabN5DNB7foSjjPXLz9Z+qjjzJyV X-IronPort-AV: E=Sophos;i="5.92,282,1650945600"; d="scan'208";a="76077190" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 2/3] x86/spec-ctrl: Make svm_vmexit_spec_ctrl conditional Date: Mon, 18 Jul 2022 21:50:08 +0100 Message-ID: <20220718205009.3557-3-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718205009.3557-1-andrew.cooper3@citrix.com> References: <20220718205009.3557-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The logic was written this way out of an abundance of caution, but the reality is that AMD parts don't currently have the RAS-flushing side effect, and nor do they intend to gain it. This removes one WRMSR from the VMExit path by default on Zen2 systems. Fixes: 614cec7d79d7 ("x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu Zen3 doesn't get a speedup in general, because we use the WRMSR's to clear IBRS to avoid forcing it behind a VM's back. --- xen/arch/x86/hvm/svm/entry.S | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index 0ff4008060fa..a60d759f7108 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -113,15 +113,15 @@ __UNLIKELY_END(nsvm_hap) ALTERNATIVE "", DO_OVERWRITE_RSB, X86_FEATURE_SC_RSB_HVM .macro svm_vmexit_spec_ctrl - /* - * Write to MSR_SPEC_CTRL unconditionally, for the RAS[:32] - * flushing side effect. - */ - mov $MSR_SPEC_CTRL, %ecx movzbl CPUINFO_xen_spec_ctrl(%rsp), %eax + movzbl CPUINFO_last_spec_ctrl(%rsp), %edx + cmp %edx, %eax + je 1f /* Skip write if value is correct. */ + mov $MSR_SPEC_CTRL, %ecx xor %edx, %edx wrmsr mov %al, CPUINFO_last_spec_ctrl(%rsp) +1: .endm ALTERNATIVE "", svm_vmexit_spec_ctrl, X86_FEATURE_SC_MSR_HVM /* WARNING! `ret`, `call *`, `jmp *` not safe before this point. */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 20:50:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 20:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370095.601727 (Exim 4.92) (envelope-from ) id 1oDXhL-0007oc-BT; Mon, 18 Jul 2022 20:50:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370095.601727; Mon, 18 Jul 2022 20:50:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhL-0007oV-8C; Mon, 18 Jul 2022 20:50:35 +0000 Received: by outflank-mailman (input) for mailman id 370095; Mon, 18 Jul 2022 20:50:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhK-0007oP-QY for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 20:50:34 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 42149ae2-06db-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 22:50:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42149ae2-06db-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658177431; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=T7kJeaP2bv2ixVwBzfYJaiBnw9YXwCrF8wG9VPOu/xU=; b=LcZV69kvdHepOJq62033kahyoPEdk7w5SrKBG2DNYtuhdR+iN1MqayuZ kFwxFG1yAlT73QNLwtQwV1f7FDPECAN8MbmElNfJrSpILZLBZxTW3XS2F 6/XXs1GZWt9NwAL0nslBMIjRFS60nuHvJGc/UR801c3FINO1ObBLqStwn M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76506563 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Gtsw/6+QlY3bGFIunzsFDrUD936TJUtcMsCJ2f8bNWPcYEJGY0x3m GAaWmuPb/aMZDb0Kt53a4q+8RkPsJXQndJnHlFqpSk8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gVaYDkpOs/jZ8Ew27Kyo0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGJ38vbJQz38ZODUJir 6ZFERwJfjXemLfjqF67YrEEasULKcDqOMUUu216zCGfBvEjKXzBa/yUv5kChm52350QW6aFD yYaQWMHgBDoShtDIFoITrk5m/+lnCLXeDxEslOF46Ew5gA/ySQujuW1boeLIbRmQ+1soHqor ECa+l3FOTU7NfyG2z2PyXWF07qncSTTB9tJSezQGuRRqEKX7nweDlsRT1TTiduTh1O6WtlfA 1cJ4Sdopq83nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYVmj7+aNhhaSACQ2ATVYOBYoSRsgvsa29enfkSnzosZf/L+d14OoRmCok mHW9kDSlJ1I05dVivzTEUTvxmv1+8OXFlNdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBva/t3MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK514BvcECZCrzPf8tC25UNyjM5fK4fTgCfqmOBuein7ArLFPXlM2QTRT4M5/RfLgEzvhkZ MbznTeEBncGE6V3pAeLqxMm+eZynkgWmDKMLa0XOjz9jtJyklbJFupeWLZPB8hlhJ65TPL9q YYGa5TTlEgFAIUToED/qOYuELzDFlBjbbieliCdXrTrztZOcI35N8Ls/A== IronPort-HdrOrdr: A9a23:QDPI5q4nYvj8Nsc5pgPXwXOBI+orL9Y04lQ7vn2ZFiY7TiXIra yTdaoguCMc0AxhJU3Jmbi7Scy9qADnhOJICOgqTPqftWzd1ldAQ7sSlLcKrweQeBEWs9Qtr5 uIEJIOROEYb2IK9foSiTPQe71Lobm6GeKT9JzjJh9WPEdXgspbnmNE43OgYytLrX59dP0E/f Snl6h6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKXCSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8xPT9aw+cyzpAVr4RGIFqjwpF4t1HL2xa1e Ukli1Qf/ibLUmhOl1d7yGdnDUImwxelEMKgWXo/0cL5/aJHQ7SQvAx9b6wfnbimjsdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZlFkIP0jgYVq3MUi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwI/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFnxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIuiYfzQTObNSSj5uw4zvmWehTPYd3E8LAq26RE X-IronPort-AV: E=Sophos;i="5.92,282,1650945600"; d="scan'208";a="76506563" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 0/3] XSA-407 followon fixes Date: Mon, 18 Jul 2022 21:50:06 +0100 Message-ID: <20220718205009.3557-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fixes accumulated during XSA-407 which weren't security worthy in and of themselves. Andrew Cooper (3): x86/spec-ctrl: Consistently halt speculation using int3 x86/spec-ctrl: Make svm_vmexit_spec_ctrl conditional x86/spec-ctrl: Shrink further entry paths due to %rdx being 0 xen/arch/x86/hvm/svm/entry.S | 10 +++++----- xen/arch/x86/hvm/vmx/entry.S | 4 +--- xen/arch/x86/include/asm/spec_ctrl_asm.h | 14 ++++---------- xen/arch/x86/indirect-thunk.S | 6 ++---- 4 files changed, 12 insertions(+), 22 deletions(-) -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 20:50:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 20:50:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370098.601760 (Exim 4.92) (envelope-from ) id 1oDXhX-0000Ee-4M; Mon, 18 Jul 2022 20:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370098.601760; Mon, 18 Jul 2022 20:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhX-0000ET-0g; Mon, 18 Jul 2022 20:50:47 +0000 Received: by outflank-mailman (input) for mailman id 370098; Mon, 18 Jul 2022 20:50:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDXhV-0007oP-HD for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 20:50:45 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 496ab781-06db-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 22:50:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 496ab781-06db-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658177443; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M3ArYUh3z2ooj9dIIOMDqfshLfZAVCD2iUM3rjr1Hik=; b=ASFmpLyZ/As0yS/bsza/FcW1zz0c10bk+AqA0/9VepjC07NIhnI5QpEc T3K62C/92lSd8YODAoFWeYJZiPS0SQTBb/G9RmD2CkVJDp3iuIe9Df8PP fsYffulA3QifdXz0eQclS4jJWvlvs4hOo+o60bLovOJtY4+C6XQp8o5jF Q=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 78644900 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:sANHP67SCl2smpSr5kKCcgxRtE/HchMFZxGqfqrLsTDasY5as4F+v jYcWTzUaayNZWOgeIpybN7io0JXsJPcm4NlHVdlqi1jHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimQc3l48sfrZ8ksw5aSq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJGEUZIwBxbZTOmJl0 vFfA2oRYE+qoNvjldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESzRJNk0aF9QVm+Cwi2OkWzZZtEiUtew85G27IAlZj+izbIaEIoTiqcN9wVuG/ Diep3/AWAAcLdnG6AuG/liCv7qa9c/8cN1LT+DpnhJwu3WMwkQDBRtQUkG0ydGboEOjX9NUK 2QP5zEj66M18SSDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJgOtc/R/6pVwH2Zzk AbUwZW5XlSDrYF5V1q91O6VtAziHRMWBkgPIgReUQVayv7a9dRbYg30cjpzLEKkpoSrRG6hm 2Hb8HJWa6Y71pBSifjilbzTq3f1/8WSEFZojunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Kz6zcWNEkqQQzd6TNDhz0k5JZQahe4StlOGBiOdsedDnib Sf74F0MtMYNbSP7NP8nOepd7vjGK4C6TbwJsdiNNLJzjmVZLlfbrEmCm2bKt4wSrKTcuf5mY srKGSpdJX0bFb5m3FKLegvp6pdyn3hW7T6CGvjGI+GPi+X2iIi9FehYazNjr4kRsMu5neki2 4wPbpfVkkoCCr2Wj+u+2dd7EG3m5EMTXfjew/G7vMbaSua6MAnN08Ps/I4= IronPort-HdrOrdr: A9a23:p90dEaE+3eqWvCiZpLqE0seALOsnbusQ8zAXP0AYc31om6uj5r iTdZUgpGbJYVkqKRIdcLy7V5VoBEmskaKdgrNhW4tKPjOW2ldARbsKheCJrlHd8m/Fh4lgPM 9bAtND4bbLbWSS4/yV3ODBKadE/OW6 X-IronPort-AV: E=Sophos;i="5.92,282,1650945600"; d="scan'208";a="78644900" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH 3/3] x86/spec-ctrl: Shrink further entry paths due to %rdx being 0 Date: Mon, 18 Jul 2022 21:50:09 +0100 Message-ID: <20220718205009.3557-4-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20220718205009.3557-1-andrew.cooper3@citrix.com> References: <20220718205009.3557-1-andrew.cooper3@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is a continuation of the observation from: e9b8d31981f1 ("x86/spec-ctrl: Rework SPEC_CTRL_ENTRY_FROM_INTR_IST") 53a570b28569 ("x86/spec-ctrl: Support IBPB-on-entry") With %rdx known to be zero and not clobbered on the early entry path, we don't need to re-zero it every time want to write to an MSR. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/hvm/vmx/entry.S | 4 +--- xen/arch/x86/include/asm/spec_ctrl_asm.h | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index 5f5de45a1309..392aca42b864 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -33,13 +33,12 @@ ENTRY(vmx_asm_vmexit_handler) movb $1,VCPU_vmx_launched(%rbx) mov %rax,VCPU_hvm_guest_cr2(%rbx) - /* SPEC_CTRL_ENTRY_FROM_VMX Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ + /* SPEC_CTRL_ENTRY_FROM_VMX Req: %rsp=regs/cpuinfo, %rdx=0, Clob: acd */ ALTERNATIVE "", DO_OVERWRITE_RSB, X86_FEATURE_SC_RSB_HVM .macro restore_spec_ctrl mov $MSR_SPEC_CTRL, %ecx movzbl CPUINFO_xen_spec_ctrl(%rsp), %eax - xor %edx, %edx wrmsr .endm ALTERNATIVE "", restore_spec_ctrl, X86_FEATURE_SC_MSR_HVM @@ -49,7 +48,6 @@ ENTRY(vmx_asm_vmexit_handler) .macro restore_lbr mov $IA32_DEBUGCTLMSR_LBR, %eax mov $MSR_IA32_DEBUGCTLMSR, %ecx - xor %edx, %edx wrmsr .endm ALTERNATIVE "", restore_lbr, X86_FEATURE_XEN_LBR diff --git a/xen/arch/x86/include/asm/spec_ctrl_asm.h b/xen/arch/x86/include/asm/spec_ctrl_asm.h index fab27ff5532b..61eed8510ba9 100644 --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h @@ -176,7 +176,7 @@ .macro DO_SPEC_CTRL_ENTRY maybexen:req /* * Requires %rsp=regs (also cpuinfo if !maybexen) - * Requires %r14=stack_end (if maybexen) + * Requires %r14=stack_end (if maybexen), %rdx=0 * Clobbers %rax, %rcx, %rdx * * PV guests can't update MSR_SPEC_CTRL behind Xen's back, so no need to read @@ -184,7 +184,6 @@ * while entries from Xen must leave shadowing in its current state. */ mov $MSR_SPEC_CTRL, %ecx - xor %edx, %edx /* * Clear SPEC_CTRL shadowing *before* loading Xen's value. If entering -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 21:15:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 21:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370122.601782 (Exim 4.92) (envelope-from ) id 1oDY5s-0004DG-Hn; Mon, 18 Jul 2022 21:15:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370122.601782; Mon, 18 Jul 2022 21:15:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5s-0004D9-Ex; Mon, 18 Jul 2022 21:15:56 +0000 Received: by outflank-mailman (input) for mailman id 370122; Mon, 18 Jul 2022 21:15:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5q-00043p-WC for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:15:55 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd82502e-06de-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 23:15:53 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IImA9S005163; Mon, 18 Jul 2022 21:15:46 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hcrm7v72d-4 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 21:15:46 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6288.eurprd03.prod.outlook.com (2603:10a6:800:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 21:15:43 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Mon, 18 Jul 2022 21:15:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd82502e-06de-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hJG1DGNKi9gfpF8N52wXZBhhGY05kaI7qCegqq3FsOo+4fX2622YUdbd0M4OvqEFr2teKJyVGLoRWim9kDKopmNEqDSbnOwzHm208QAMpZ7hyVtsS/6yPfEjq5l5lHt8MgnDAQ/65R2pnjrSPod9M735RXz6qgc5w2Gv0TBItunyT536cuRN5LHHBVlb3QxMi0wrRWED4IZ/toarO9YTindgefNXIM4sMi0d62C6Ye/6Nq+RY8/FBSig929HvS3xuHQeE9NTSh6lMbCZWyi2AftmnZFjEMTb6RLyah7ZLROHLfbZAUSmBjntW/xxvHLxTYhFsWzwCLq5GyK3lfGaYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ksdanVPgWNjcEsmDWclgKo/WTZPT/811BmuA9N3cIiA=; b=cgCvelgaB24g4mDSKCvZBy22/GyMf+Wfr0bMEytInxrTK0LFsoezjff2OrwRCFhWLHvavSyJ95bsD2v4fWtqIwNo5m/j4bRlodC5QZgnTrXrJ2EA4yiSXuahQAtLlA6cGCYw5Efuc7p5ZcXUUj7piJEVs1q/BGMxp9Jsz5+KCzufySfN/IodOBgKZZPQLYs0AasIzHzgp0cRxxBaUFXSl7wxfU363gi1QYrO1cGN3T3zV9KRqm9t5IQ9t1CN983WQrUW+Q7WLrCyWqRNf1F94LNReA01SyGroctezJgkPAaMVC7wO9qMx75gAqees8VL2yrI+grb3f4XiJb0GaQbVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ksdanVPgWNjcEsmDWclgKo/WTZPT/811BmuA9N3cIiA=; b=HSHBprWcvOvJ47W6C0lBrTpdIkkJdm26woGD9bmN+V6SQJQPwN8gXcbJws5djKolitb3myJOzIc9dvaVG+/r/W+ZdP86PKOTpR/jAMHLO7Gw85QAFYy9z8NIOTMUSf4XOCOfXDRzP/eDi1Z23BGYHCJY1zcFSESu5dRijeWYk5V9X5ttaTO+1YX92YDrRIZlYi5xwxJPepMNCuPE2ZYJFi1O6pkYygrHpSVgmHuEL2eOzA2Z4Mm9nHvLs+oPfF6olWhbdlGNc627jf0H1dsSv1qLklZP52bDbHfPHMGVdH3m0GhchY8Aaqi3VccnVnIogrUs7y8B2FnAoLjDfiCSkg== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Thread-Topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Thread-Index: AQHYmuuJ09LC1x/2uEWs942YY/fNVA== Date: Mon, 18 Jul 2022 21:15:43 +0000 Message-ID: <20220718211521.664729-5-volodymyr_babchuk@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> In-Reply-To: <20220718211521.664729-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.36.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6b6ad0bd-8b6f-4062-f850-08da6902ac80 x-ms-traffictypediagnostic: VI1PR03MB6288:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wkk1l0uiIodJdZSFcOiVERfckDFR8Yr7VSL7MQLmrMwutCMorXqL/FDEo2tqgmFFGDbDnCvHwm8JrdVqF8qYNXrTwPjFRJPuUaef9puETzrcheQr5WSDtNyTvu5JpnPN6bWsG0VMd9ar2RUpftENUSRKfWtFSM0py5aa3mgWLQPitXJOYKCfpgahfXE6QEnhT0DgCUtW2hBoWklKjQA6FJ9JanwMPdx5mVHFkYV/vUnOFP70q9yVNHIbpJ0ZGzl0ckSVdPVmQdJjreGQQ9J1whxaUrD+VQCP47KR/YzfR4xsRGeNFp2VS4x4To766mpN8tOZz5dfwrGk4gmglatme3oRz0p08dddEOGAoSztgNjPZMoeeCYtfaap5rOJwjYOdePO74HttHUAbcoLvs4cTVW8XaI287AaxMFy+G5sV+JgyJ4jLCNeG/kR93LGIwXdKMqb6GvEiiCpyId6v6LKkco+YnYn/h1F5gWczSxq1owMlFgqh/nVIgJ1XM60MzMpvgL9JhtdW9heq3Duv0UHQPHz7Arz5ybnbhy0dQIZEDfGQ/0AdbhDbb+se5dg0is+L8svGks/jVCmd8VT1BVnVgwOvIf9L0M9eadBaFJVRiKdgc1eZhQavpbEDH1dmZoRBzOgST431ZeElwzopavmWyyoPKptt+cfYtLqpU0PlDn8ft58ZXgsipietxCXPaorxw6tUFpgctGARaKsP3Y4rLBHheguTiq155ntPZI68ggCkMqQdv0dd7P1qvWoPbTGdQ2/a6C0BThfCF7Lz64hPhV+M6HCnMgNd5q6GMc/qGol+yLEPT2ib4Z8e8pyMazm x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(2906002)(5660300002)(8936002)(36756003)(186003)(4326008)(4744005)(86362001)(91956017)(64756008)(66946007)(66556008)(8676002)(66446008)(66476007)(76116006)(122000001)(6506007)(478600001)(316002)(2616005)(6512007)(6916009)(26005)(54906003)(6486002)(55236004)(1076003)(41300700001)(38070700005)(83380400001)(38100700002)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4Svz0KfunChTd57mLSFOpDKd5yMV9+ZRNItyhJLxVpGCrlUMjKXHieZWf0?= =?iso-8859-1?Q?/1AUWtBlUTEfi9Stn3v8K7tKwc5aF0P6P2A9UjdGjQOEfxykEicGyxI7d2?= =?iso-8859-1?Q?tOIx/tzAk08ursWR0Zt2UFAmjDV9OR2uU8p5g6iEpmAU5idVVSHlD/7e31?= =?iso-8859-1?Q?jkWP+vPKJFZ3tM0FlxQbivzbdQi6ERKOHRubU1tzx41yw0EFQWAvzyWQHn?= =?iso-8859-1?Q?0xAsattOk3MlpDo1ZRBWrcYqfgS4987bhWXDKdbNHLO3ZIEkRol1vk5/+5?= =?iso-8859-1?Q?6FkaGTbrz0vHAfliGkIDTcoE5MFGTz3uKxQLbudxQhHolSusuihXxjQtmA?= =?iso-8859-1?Q?n06B6fow/r8ziWsI9BAdG0HvMQv8Scz017yBXw/p2zunM+4JPUEJhIVVoo?= =?iso-8859-1?Q?45YmYy0GFMVkz8fumuGjIBqvTFExPGS+MW3hYy+Jp4rb3unNCQAscObZ8/?= =?iso-8859-1?Q?NlFJKTn0Gu4hvgQb+kiCY2W7T18+RX804IgeYdibbWkoLfeiNA9DffECni?= =?iso-8859-1?Q?8KDKQFNRg2QGijWUV+EY2o9r/S2baT+N9ZyPluNgmpsjvmWKUmeIvdlYH9?= =?iso-8859-1?Q?oUz/N2HoYAzy/zhZX/mKiN+iJ1IK7aqJROxfcxRLqkAyodMWeAb8ioYjqv?= =?iso-8859-1?Q?V/zsXWBSaTke7JKDgoSpbYyKeY9oAHpUWbos6Igwf5plESv3EOuUjwFC9r?= =?iso-8859-1?Q?/V7DR49HSlBeuhlTzI/e6JEvRMd4W+WJyAI3f8gVRT39+KTCOatJA+lsz0?= =?iso-8859-1?Q?+KzVKe+E+4OuoEC2EFjdssRGBGAmxsymJ/76KMxjNsHsQx7LXecqG2Qsso?= =?iso-8859-1?Q?fCR8QkxscTK5+sboYNbaw1aKSaD3HwF7Tx9BTUp/w53nEoaq3rg1HfdYjK?= =?iso-8859-1?Q?wvWdZp3SBk7b39Ff8rtuHdjLVF4wvdXUB3iOotRX0vK24NEUjzycv/nxxT?= =?iso-8859-1?Q?z3HLXnwScczXy4kagNUF8BB4kbZepV2Xc/sVoeAtxWZBHUYPtSq7MsEDgW?= =?iso-8859-1?Q?ERq/4e8XAn2bBaq5bxOVrgSqO9GBXODG9dokbl/T13tMd8Sppm/llgqt52?= =?iso-8859-1?Q?HJWE19rIPYAGk1eG3H4gk38F6b0KB8+h7Jh3xBpCiS9AoEB0gxi9OD8zRM?= =?iso-8859-1?Q?K7GkQQ+pnezSqSHNM+zdmxzx5rSj0g23z3s5PvyL2thzdAuxjoP9bkuwTX?= =?iso-8859-1?Q?uNuUElNiylpS+bcDfmjFkOaUeC7p61AWJKtvKFeFi7wcE8vO05V+sGalRL?= =?iso-8859-1?Q?/X3a2YdIg5CKhO170bPe48FDcWYXZTXTL/sPKcMZ06QoMEeGiFQTuAE9pA?= =?iso-8859-1?Q?pzyzaJ2ZSe37FlDJvRixeTbAYZSnswZR9m9oc8TFODinBVnaee0MT4fFNJ?= =?iso-8859-1?Q?QlhdAHGT2zi2dS+y3JiwsAJQrOTE+HOHHFqS1KxAAwzEvANdrYwaDgt6W7?= =?iso-8859-1?Q?Wxxx8wd1iq0C8DHVABnB7jLE53RR5OCWoVOXqjMDA3w2Gft6V2Z2QDKO1D?= =?iso-8859-1?Q?GAtyjRT3paZsin2h4xSYQanXk86MMtRlpIw7QGy8EniE9sPVTacGxaTeZ6?= =?iso-8859-1?Q?Gc3nx8IR3Mvwq7IRDA/jzV9VDERjln6NyYEctnevDUfqXKRwLRE3H0QJzN?= =?iso-8859-1?Q?JFk48sieUo9J4DS6RdJxRIVRtsj2J/C8N8PGYSLIRyaRE3VUamyLOuhA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6b6ad0bd-8b6f-4062-f850-08da6902ac80 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 21:15:43.0705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m5Y/+4oGldBqyz6pxv1P4ShlkkJHqCi4tvgK2Y/HMUi9wdBgX0HbqZOD/ZyVSsIkPgJkj39I+WiPO+sxHvM50y8gwEYhxbuCEhi6QqHrt4Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6288 X-Proofpoint-GUID: 8Kx16ohB7z4_SSKC517HlrJP1tRIWTjY X-Proofpoint-ORIG-GUID: 8Kx16ohB7z4_SSKC517HlrJP1tRIWTjY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_20,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=962 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180089 Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to iounmap(), but not added corresponding include. Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") Signed-off-by: Volodymyr Babchuk --- xen/drivers/vpci/vpci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 1559763479..674c9b347d 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -19,6 +19,7 @@ =20 #include #include +#include =20 /* Internal struct to store the emulated PCI registers. */ struct vpci_register { --=20 2.36.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 21:15:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 21:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370123.601793 (Exim 4.92) (envelope-from ) id 1oDY5t-0004Sx-Se; Mon, 18 Jul 2022 21:15:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370123.601793; Mon, 18 Jul 2022 21:15:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5t-0004Sq-Nu; Mon, 18 Jul 2022 21:15:57 +0000 Received: by outflank-mailman (input) for mailman id 370123; Mon, 18 Jul 2022 21:15:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5r-00043p-P7 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:15:55 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cebd73dc-06de-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 23:15:54 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IImA9P005163; Mon, 18 Jul 2022 21:15:44 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hcrm7v72d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 21:15:44 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6288.eurprd03.prod.outlook.com (2603:10a6:800:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 21:15:40 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Mon, 18 Jul 2022 21:15:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cebd73dc-06de-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OC9zgu3yqwZR5XqSIru2I3ga28LlND5uf5jXSAnCRzCJFYDyVVZwm8prB6ZS8poLcdcw9WhtwNASkm2BFJ3VFsStsgZWgR7kojTUt5wDFXVmTdRuUdo0LjeV0A8i/VhSLxO91fwZ8Q8FW70YV6CXSF6j/W1MD8fmR13fWzRNCShi/McHQdpr+knfv8p0SWr4ieIoNVkX3vmWq3QzI59Ej7SV/nDE6NI27zuAk+149WFFImSxmWxpe4fwRQ53jRLNKrGqHzbgj7QbTVEgsfQ2rqDQGATZWf9Ja2VYQCPVNWNg1BKnI6MWXjre/bwo9kDcV/ctc42z05rOxQF50gj/0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DVMURCXF+8xKx1eYG9povulw9IOC6DKljZ6HILZCK2I=; b=DLCOVgrg+iBEuI5AMgjr4NTV6r4Sa25v2AEsYgSLBgbprOuWWvPGJazn7W+SXro2Qya67HG/BXgO6piK+IozL8RfG3AjqBEZwafihpDUHSq39Zdtrv28aDomKzy2AWJ+DmF2j3mSTFDLahaFh9B5leuJTxHgro9Os+eJtCU6Xc3dsBdDcDNg8+UEdOHYQhv4ESlI+41/6YjKJtU+YO4F7/aC85tfsMqGoFoBW4eT1zaSpWHEfzu4RoU5/UmHzx/fUNBxJiVJzy5L65NZjcsypaGlcxJDwn+1LsV0i3UH5AM9Kj5wem95/VOgYcRofrazbXCm7eezrWPGv3Q8By91Cg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DVMURCXF+8xKx1eYG9povulw9IOC6DKljZ6HILZCK2I=; b=dgsU0+VJRtS67V+Hxum6prE8spab9owJwsnedF11/kIgYs+OpEuJ40p47qZSqhD3m4+SG8d8j36qyMhYJemi1wnASBJZcNJGOJn1L2Vy3P1hFWLBmOHlbr/+MHRKohXpVFxMBb76rUpOBw8Lzh2k78Y4WdODW/G46chtTSCOFfnrEsXAe7BaYvGtc4mZVMTn17a4nweCjO/wucF8PRNuo5Z3TBZRrbeyo84Q38PeAtwzuNqMr14NT9hmMEWcJNLVRtzAii76nXpyfRYwTJM7YwkI5LwuYF1pX1nMSOE7d2vHNV4UWJxBDtbeUikBarJzPCjyQEtKMSzNtrt93VPwYA== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Volodymyr Babchuk , Jan Beulich , Andrew Cooper , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant Subject: [PATCH v2 0/4] vpci: first series in preparation for vpci on ARM Thread-Topic: [PATCH v2 0/4] vpci: first series in preparation for vpci on ARM Thread-Index: AQHYmuuIRfBsTERtW0qM5QZ/dvYwvw== Date: Mon, 18 Jul 2022 21:15:39 +0000 Message-ID: <20220718211521.664729-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.36.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0bde706c-97a2-4ebf-2c23-08da6902aa85 x-ms-traffictypediagnostic: VI1PR03MB6288:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3Uv1IQnqx0q/urAbgCyi/uRhSnyqgnxp3So/01+8+Bl3+dL3eOlaxuw/OuoZ44EC1x4wmvI9kNw2aB6ybmIXrgNbDITddvwDPE+/6oJW8ZkVxDzUEoEtAlNqiM4nzgPMkJFZrd23MIxewUf2TYRglUd91q+wT0K1LSOTV1/uYvQusj/1A5FUPwVhHuCLASOIVrU9VVUMKkOaLBH+PFf60rt7n9/T/LJDrCpON/yJBi+u9jcq3Ono9PZCXnzmRXDf1tPTvYNAW4b8F3Es9GFhqy5UV1w1K3zzmTfoy7wvfj+lE0lmdaxCiX0w+WVU0K0XIt+wmsX+eeoUWT62uBtF+chir2Vx08vzQzYo/pxipYlzfbmBO65sJfR4e7wU/7R+GHC0xkVjpZY3GJz3Kjk9jDus221GCP59q+adON8BKwzOE0o+7ima81FtSejz+idnj3c7+brhkz/abfC+D1sAXRPf8aDotcfUkt+XoqKbk8kif3sxqVBOciFrrT/8s3USF5K+FzL5UAekIjzZZY+Pr531XbeI4gnQhl4udzNvBCcaFqx5Bs2DTzsRnvB5Sge97xMNCWdczGJctJiSa6RB3DKUG4RbAhxr67dF7I2t4jjp5+cd5onG5tpaxg0v+/cB4YnMLiA3QKia0sjlUn2IZurqhzB8uOS73MLgIe6iveTud66M8N806QRr6LzfZQGj0LP9h0QWxzyFXR8QWXpKrzcueP6Rlu5bWWBPvz0Ynv+7ZXpW6j+YB58igyjvr7z3eP/jFskXYoA5QaF4vu1QuFk4biYiOjbyh3TcAGD0GZM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(2906002)(5660300002)(8936002)(36756003)(186003)(4326008)(86362001)(91956017)(64756008)(66946007)(66556008)(8676002)(66446008)(66476007)(76116006)(122000001)(6506007)(478600001)(316002)(2616005)(6512007)(6916009)(26005)(54906003)(6486002)(55236004)(1076003)(41300700001)(38070700005)(83380400001)(38100700002)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NmlBejc1OHdFVmR0a1loT1pvYVBUbFExcE1DbkhlRktXcFNsMVd1eDVwUU9i?= =?utf-8?B?dGUwc0dmekcraEtRK1M2dVBURnJSVkNzRjhjM1V0bGk5UHNsekJGRUxoMEU1?= =?utf-8?B?RG5BR0U4N3JLOGNRc3hTbGVCay9xYjYyaHVLaXpsRmdiTE9aTmEvaFBGUVJX?= =?utf-8?B?eVdYanBQMnErN0U3Y1lkWGR2YlI2NVhmVlpoSmxKM01seTMwcHdRVXlHcWhG?= =?utf-8?B?NG5PNzF0dmQrRzNzOXdlRjJPZVpkajJ6clJMMGE3ak52Mm9kM0JHbkx4cVJp?= =?utf-8?B?RWRuYUk2QjhJSVdWREtmcnAzMm1oSm4yYVR2WVlnQURhbGpHa3FEVEQrZHhF?= =?utf-8?B?Q0l0QStGZWdiaXduSVdOWHMxdVF0UlgyQTZpazV6VDUrTmlVMUZCTXV4RUk1?= =?utf-8?B?SkZnSGFPN1N4YlNYamgvQlk3WmZSZXEzSDc4MGNZLzJpYVNGU01pRDZKWkJk?= =?utf-8?B?VEJoTTdXU0lOVEYyZnJ1UTNqdDIweExrZWlYOWhFM2liZW1OME00RFJxd3No?= =?utf-8?B?UEluTWloVURBS21JbTlMR1dkNDc5Z29SNVFBYXhhZ3lkTHEwZ3YxUE40T2Vv?= =?utf-8?B?bnh4OXpxRUhRNkk0ZFRsbDlPZ2ozSUVqbXVYZjdCU0RGTzQ1bXAyOWRtTnVM?= =?utf-8?B?VUJMOFlneE0rTHBmQ3hnUi9nSE5LREVYNU53MWhqVG5XQTBkRGcyZlBxRDJB?= =?utf-8?B?eWVBYThNWnJFZ3NaMDlkWXRhRDAvSUpJb2Z6bmxkdXduT2VLQTh5MnJ6SUlr?= =?utf-8?B?MDhMeVg3NTZDcFI0QmxncGdIbnZ2Z2FVNENjS1oxMHZIL1FiTytWUjVNUktI?= =?utf-8?B?dDl4U2JSY0JWNnJteDRMbWltdHlkZlRSLzJlMFBsV0RsRnQ1MzJHYUJTL0dj?= =?utf-8?B?QXp5bm52YXhFQ2RoMDZXRTY1SzltbHdsUUs1T1g5Z3RzanJQb3BLMkJVTGpK?= =?utf-8?B?bnd0MUpSdnByVk1Kc0pGQnFDVFZQMjJkUFNvMUNsYjJGMnhtbGxTRURjOSsx?= =?utf-8?B?OEFCOS9NWm1WenlFTCtUa1dxWUgva1NqOEpob0NCcGhwRWxNSXdwZlBRN0I1?= =?utf-8?B?eHlMaWxhaGJkZ3Jrc0VMamIxMWhnZEF5SFlkSWI3c0UzY3lqcWkzdzlKZHFF?= =?utf-8?B?eCt0ZzgvZ3Fwa3QzN0pQSFJhZThtZWVaMlRQK1MxK1pMczhsZzcvNlVnNnNh?= =?utf-8?B?UURUSFA3TW9TN0pXdXZaV0VFalE0LzdqTlU1endVOWw0N0QzTmt1eEUybkxs?= =?utf-8?B?YUdaNUdGMThRVHRIbGFxcnZDSHh3OC9PdG5ueVFtRjRGR1c1d3E4RDBGWFpm?= =?utf-8?B?VVd4OWJaWU15dEorejJpbmExUmJ2YUp3MmwremFYRjVVZ2N4OUN5SnJONUdx?= =?utf-8?B?L3NsZ3IxUjdXV3djTmFJVUYxU0VERmVnem83NE1ZQjZVSWxaTUpGMFBvYTVt?= =?utf-8?B?b1dzamFmcFRVNGpheG5LZ05sMmFiWHBHUVI1WnZrWG5tSlNrNWs3c0tLRlZs?= =?utf-8?B?Rjl0ellIa2ZKWm1JTzl2eWc0L2ZpbzZrekdyVHJhc09nL1BBanJ4Y3pKa1VM?= =?utf-8?B?M2F3TDU0MERvcVJDSDRGbHJYZzNxNzBodjE0WDhwcGprb0E5MVhPMEZYWndk?= =?utf-8?B?Yk9KbmRpdUFHYjNmLzVSWlRmTk1UWC9laWtCbG1jVzNIYnBla01nVEVseVZK?= =?utf-8?B?MUdYNWxqZTNuT2k4azhBQTJFbG4xVXVBamIrck1XV21PL3p2Q2wya1d2RWpm?= =?utf-8?B?WUdRUHFTTVd3SUJWdmIzZEhLeVNnU29qSURqNWZYNjNsM3pQZkpFbjBvdWxn?= =?utf-8?B?c3ZyWDFVKzRsZEtKRWJnNzgwY3IvUlNtZ0RmMlNRT1piVXpUUjY4ekxGTzla?= =?utf-8?B?N1BTdzF4djZFdkxrcjVMUUJZdUh5YjVjSnFEOHpaeS92V1I0Y2JiMS92QTBu?= =?utf-8?B?RmtKa1VFOUo0dnNOUXUvTkxBajI0amdpcjd4VDRzVGZiMHlReVpubVF0TU1X?= =?utf-8?B?cnZXekRXZ3hJM3I3dkpDczlSb2ozSzlUL3VNYVkvd1V3NDBmRmFZNElkSUty?= =?utf-8?B?UHBFYW9qYUxkWUtQRWptZkFLSmsrSjFheVNFMndPbkVPdTdoRCtFanlySWR0?= =?utf-8?B?cC9LamlURHI0U0JmVjYvckE1blJZc0lzU2IxZkF6TU9JTnF5b2tHWkZMVWpE?= =?utf-8?B?Q3c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bde706c-97a2-4ebf-2c23-08da6902aa85 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 21:15:39.7895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: G9acEArmFjyJxWVHdbvKFkTMraVQNbpr7He9pt0h84Eh5cZahH3LE6xTdO+uOsWPUCZLiLS0nEYV4dWZewkNSrFJkhV6aS4ZcCe8LsdXHwo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6288 X-Proofpoint-GUID: qLpDHAfJOH0v4MFYAdU0qIyRr4MZd4Sw X-Proofpoint-ORIG-GUID: qLpDHAfJOH0v4MFYAdU0qIyRr4MZd4Sw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_20,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=359 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180089 SGVsbG8gYWxsLA0KDQpXaGlsZSBPbGVrc2FuZHIgQW5kcnVzaGNoZW5rbyBpcyBidXN5IHdpdGgg bW9yZSBpbXBvcnRhbnQgbWF0dGVycywgSQ0Kd2FudCB0byBjb250aW51ZSBoaXMgd29yayBvbiBw cmVwYXJpbmcgZGlmZmVyZW50IFhlbiBzdWJzeXN0ZW1zIHRvDQpzdXBwb3J0IFBDSSBvbiBBUk0g cGxhdGZvcm0uDQoNClRoaXMgcGF0Y2ggc2VyaWVzIGFyZSBtb3N0bHkgZm9jdXNlZCBvbiBuZXh0 IHRha2Ugb2YgUENJIGxvY2tpbmcNCnJld29yay4gSXQgaW50cm9kdWNlcyByZWVudHJhbnQgcmVh ZC93cml0ZSBsb2NraW5nIG1lY2hhbmlzbSBmb3INCnBjaWRldnMsIHdoaWNoIHdpbGwgYmUgaW1t ZWRpYXRlbGx5IHVzZWQgdG8gZGVjb3VwbGUgcmVhZGVycyBhbmQNCndyaXRlcnMgaW4gdGhlIFBD SSBjb2RlLiBUaGVyZSBhcmUgYWxzbyBzb21lIG1pbm9yIGNoYW5nZXMgdG8gYQ0KcmVsYXRlZCB2 cGNpIGNvZGUuDQoNCk9sZWtzYW5kciBBbmRydXNoY2hlbmtvICgzKToNCiAgcGNpOiBhZGQgcnds b2NrIHRvIHBjaWRldnNfbG9jayBtYWNoaW5lcnkNCiAgdnBjaTogcmVzdHJpY3QgdW5oYW5kbGVk IHJlYWQvd3JpdGUgb3BlcmF0aW9ucyBmb3IgZ3Vlc3RzDQogIHZwY2k6IHVzZSBwY2lkZXZzIGxv Y2tpbmcgdG8gcHJvdGVjdCBNTUlPIGhhbmRsZXJzDQoNClZvbG9keW15ciBCYWJjaHVrICgxKToN CiAgdnBjaTogaW5jbHVkZSB4ZW4vdm1hcC5oIHRvIGZpeCBidWlsZCBvbiBBUk0NCg0KIHhlbi9h cmNoL3g4Ni9odm0vdm1zaS5jICAgICAgIHwgNDYgKysrKysrKysrKysrKysrKystLS0tLS0tLQ0K IHhlbi9hcmNoL3g4Ni9pcnEuYyAgICAgICAgICAgIHwgIDggKystLS0NCiB4ZW4vYXJjaC94ODYv bXNpLmMgICAgICAgICAgICB8IDE2ICsrKystLS0tLQ0KIHhlbi9kcml2ZXJzL3Bhc3N0aHJvdWdo L3BjaS5jIHwgNjUgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0tLS0NCiB4ZW4vZHJp dmVycy92cGNpL2hlYWRlci5jICAgICB8IDI0ICsrKysrKysrKysrLS0NCiB4ZW4vZHJpdmVycy92 cGNpL21zaS5jICAgICAgICB8IDIxICsrKysrKystLS0tDQogeGVuL2RyaXZlcnMvdnBjaS9tc2l4 LmMgICAgICAgfCA1NSArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQ0KIHhlbi9kcml2ZXJz L3ZwY2kvdnBjaS5jICAgICAgIHwgMjkgKysrKysrKysrKysrKy0tLQ0KIHhlbi9pbmNsdWRlL3hl bi9wY2kuaCAgICAgICAgIHwgMTEgKysrKystDQogeGVuL2luY2x1ZGUveGVuL3ZwY2kuaCAgICAg ICAgfCAgMiArLQ0KIDEwIGZpbGVzIGNoYW5nZWQsIDIyMyBpbnNlcnRpb25zKCspLCA1NCBkZWxl dGlvbnMoLSkNCg0KLS0gDQoyLjM2LjENCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 21:15:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 21:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370121.601771 (Exim 4.92) (envelope-from ) id 1oDY5q-0003xh-Al; Mon, 18 Jul 2022 21:15:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370121.601771; Mon, 18 Jul 2022 21:15:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5q-0003xa-6k; Mon, 18 Jul 2022 21:15:54 +0000 Received: by outflank-mailman (input) for mailman id 370121; Mon, 18 Jul 2022 21:15:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5o-0003xU-UL for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:15:53 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cc83e0d7-06de-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 23:15:51 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IImA9Q005163; Mon, 18 Jul 2022 21:15:45 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hcrm7v72d-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 21:15:45 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6288.eurprd03.prod.outlook.com (2603:10a6:800:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 21:15:42 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Mon, 18 Jul 2022 21:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc83e0d7-06de-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOBvARjaHrV3kFe71EpnIPF63BTk02OQMSqRhEm/9mhND9KUnKZVyLrDfe+Qx48F53fZVI7qWgVjW6kEHLKalHeqhsWoSzWBQh3zoYBbXNBtjmV08r8TuII4DA/bLOM7J5ahL7SwNdOCmP1DLv8AUtPSF/0NH6SBY3wkoK/h3WhWiFBQ0B6kCoA6NcFPs41Ig02J7d+A64sqEoKdjI13zn0UXm516VNKsRttcaxV09bfNfhU3aOxJsRdfeBEE0MI1J4E9c0PAOq8EhPUExXhRZclXXDZzo2aVdzGSh5woMBCaA6bIHvHRfF0lIOj0QFY0xguM4w/K7tCFleGPYLAFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T4aVJIa9/bhaGhacjrCd+o+XlsceCPV6UM3umTjKOTc=; b=n8qkOFGJQmMVVy6/LZvbhb0O+57XTg7pVSb57KZJWjUAJEUViTphNQpaAdw/y7iMqYR7U1fDtTEBi8fxB4zDF5REXYReMoIIu1OiDgjwInmXYM7gJ6RWpYRR3U2Cx3UqEiSUlAYSslEzRXuoogQHs9ON1hweC0MtyE0C7yc2xrA9JGHFWf/WqbIl9E0+N2rYO8ZvcczDrly8foiO65IQFHoXRYPgPmX10X+ThKHKUuaagKXqbbA9DVj6JbHDqisObYcXBphNwXXlyneNLlGuzciIXAEeXrCOQCqzPqCAmPJ/cMTf2lqa02knDcMlfCH7+/W2I5eR11kkZOxLXkSSBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T4aVJIa9/bhaGhacjrCd+o+XlsceCPV6UM3umTjKOTc=; b=pLuqQgdYNZhHAHmIRlXCWNS3CQQBS5nHJxJz1tEUUk603gilKpLuCU4/X89r2H790gU+kBNmV72+OgNgfxo+vXFPJIZDFF5v2aAw/BffzXDgb/FR90iPUlJI+w9JVdVvCmPKfviNiTKi2+5ZUO9KqVRrCPANGR733SJ4fqr1rrao+pY21paHEcloIE7X70hZPVkL9EgArIcePZsMAnnmRDc2wp3OhgHeBJYv+21EfIIBu31lFgNR7+w3LnqQ2CArVWdL+HQeLd1I0biTuUUm7FM7anHkHkuDNXAgq69OCD1G7mpd0jYIeY9PVGyAus5vjfeh+SMhZ8pOGpN++XVWGQ== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Oleksandr Andrushchenko , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: [PATCH v2 2/4] vpci: restrict unhandled read/write operations for guests Thread-Topic: [PATCH v2 2/4] vpci: restrict unhandled read/write operations for guests Thread-Index: AQHYmuuJ9rK3Yz1P9ESDEYkc1v52zw== Date: Mon, 18 Jul 2022 21:15:42 +0000 Message-ID: <20220718211521.664729-3-volodymyr_babchuk@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> In-Reply-To: <20220718211521.664729-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.36.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c438cfa-7cae-43d5-c2c9-08da6902ac28 x-ms-traffictypediagnostic: VI1PR03MB6288:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0aRk/lKutfhDcHfnwhIMWg7jFqWqRhnFnjh8ea1V//kZgSesLkPYXPaAFBeqH+NreOmciL1gjH0ImHZ1LgssGVeBbAVL/hJj/20H0JHtxf1SZMXFOFMiysF3EU3CiPWLuZs5uyZjSINvDMylanO2z2zdHcNBAWvdnV1CR96Npwi3zYwZsVgmwD/OIJ9+8+KwCrtCYeSgy/xMjPHAooGiXUTedAr53LmuMGoEWyJ38/VzS0wUEdFPEoiho7VazuRQ6u3Q2gpVANGREsWdYF4e5JlW26IEttNoE4bMTQaaY47Q6unhWhZP6oBjekNnZCQN4RTCxMBqOkkR0ReMpzsvAiMXXtTIo5BOISzzla8V1Qt2vWL3i/0KcCZo5nDxnY9NgRKEXZmjZdrsii6e7jwrrdgXkaigF91CSG+SwaD70ZGCDkQuhvzE/PTKs9BYbTF7wVPYsr1iHw0328JX5bfqzO5enEZhzcRojU+bZgsT+UGnxXEHSxsPApMIa5t37LPxyjY1fJzEzf6xhFXGjbtA2urf9BXqgeHReaMo8aWcofgr8U/uMqp8mhDjtlwA4k7ZIqJlWZZYWw5v17qfKpOFBNq2IUwhXu50DLCikY18JFXjXeXEmhsRYzOTzS2RvY+JACw57YWJZnPxiI0hbEY+RGJ6dAV5wS5sUnH/bK6Z10x/aNjepzmwCs7gALZQumpawLGfMZadooQ5fkRET1IbkVErf8at6t+aSwTYMBCMdscbB3H69/zmNgHcVye9/LTY+VXQQhBYQZdihs9Owrb1s0TsUUeIN1KMdWrtoloYHFzzu+IJUrjj9/z2IO4E2bDL x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(2906002)(5660300002)(8936002)(36756003)(186003)(4326008)(86362001)(91956017)(64756008)(66946007)(66556008)(8676002)(66446008)(66476007)(76116006)(122000001)(6506007)(478600001)(316002)(2616005)(6512007)(6916009)(26005)(54906003)(6486002)(55236004)(1076003)(41300700001)(38070700005)(83380400001)(38100700002)(71200400001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RVpNRENYTmo1ZDJwUE9sdmtiQy9iSkI2N3dPSW02SUVuUGlpVjNVdDNadTZG?= =?utf-8?B?Ti9reXVIRXVwcFMrM2VPb0RjT255bGRCQjFHaHJLSlkvdm5iWVBibTk2SGtZ?= =?utf-8?B?NjVDT1AreUVMdWFIMlhUTE04UnV1SEc3SmNKWGlBTHNUZytDaU4vbXpKK2Zp?= =?utf-8?B?VWZSY1c3VEtCTkM1bVFTbnJNOEtZb0gzQW9BM0k2NHVqMVFJcWI1dUxrVDhp?= =?utf-8?B?a0pQOXpuNURqNjdGbGc1enZmRGt2MzM5Mk5JZVBhTS9hdDRUb2lNckFBRWRO?= =?utf-8?B?MXo0SEpEdXZUeFo4KzBJV2QvSVZtZTExbjVsR2ljcFRmM0tjTk8vYU9FQk5w?= =?utf-8?B?cDNIWUtqZFBqQlZWWFBTV3A0cjkwbHpyN0pWT3RyOHprNGZra1BlUURjZkZr?= =?utf-8?B?cTg1Q3hmakpxeXlaRmd4c29HMFhOZjVvNWEzb1M2TXQxSVFmd2tNaXBQdkF6?= =?utf-8?B?aGduWnYxVXQ4a01nbzlpbFp0SnJXUkNENUZtcUJHNTJaamdsVFV0WEVlcm5m?= =?utf-8?B?QktzZzIvN09SVVRNZ0k0eWQ0bWZCZHprSVh3aFpJNVg5NDFQUldGWWtQYnpm?= =?utf-8?B?SWhiOEpiN0JyOE9SRnNnKzQvNEJ2RnVCNEdncGtLeUxUTnVXbHpGZExDa3d3?= =?utf-8?B?d3JQWSttb25jQ204eFU0VmNFa0FkYkNHa2hCQ29Sa0JZQXViRUV5cjNKQjQz?= =?utf-8?B?elRwMXIxWHVTejdneCtUZFJUMFJRQzdSUG0xNTdYYTZFcnZoTTUxMCsxQ1Bj?= =?utf-8?B?TzZCTW5McFJtS1VkYVV4OWVQNjAzNVZsMGdpUWorREs2QlUvMzBZTTZwMFQy?= =?utf-8?B?YVUxRzM1VjhJcnIyVGtYbnBDZ0MzZVVJdzhNSnM1cmJSZ0lvUVJBTHZBeDFQ?= =?utf-8?B?UkE3ZVhLZkRUYlJjSG1GYkg1Qi9Ma2w1TWFVVlJ6UnJRZ3JrOEp6bzhjRFdY?= =?utf-8?B?LzBiNmpKcVNESUJ1OUFscURxRWNuUlloeDIyMDJ2OXhNamwyOUNoc1E5TlEx?= =?utf-8?B?S2RFdjBtaXRjY09YaEo2VlNLa0x1QW1vbUlnTEpuMHdhNHZlOEJQd2JRWDkv?= =?utf-8?B?OGtsNmhkbkxDSkpRWmw5U0UvdzFGN0J0RzFkd21JK3BsbDR3c1Z0eEtCNnVs?= =?utf-8?B?K1FOVFczbFI0RXU5MUcwckRKTm5ia2VpRXZSZVVlMlBpMHQ5ZVEyZkVzNjhr?= =?utf-8?B?d3RSWGFKR0F4VHZmVUVUdFhpNFpsVGt4TmlnSFVObjcranNzWWRITmRDT0dW?= =?utf-8?B?NXRLZnlPQTlVSHBaVmViMVJ5N2JtTVZqd0xjNzJNSzdibEcvSnZPN0hkbTJL?= =?utf-8?B?enZmRDI3azY2WkFOeDlyQ1c0TXpoOWRITDI2aDNFVnFXZWVnQlNiYU5MUVhs?= =?utf-8?B?MTZnK1MxcTlPRldpbmIwUStXNEJ4a1l0YzVPa0txM0lhWGMvb0lzZ0R3cSth?= =?utf-8?B?b1ppQnNZRFNheTIzNWJVRTgyMjRBOVVINWpzUk96N1I4MkpNVXRralJNdzcv?= =?utf-8?B?dzZqay9oUlJOanRCSENKYXhmdnpMS3d5cG9UdytEZlJldmtuQi9TQlgyY2tN?= =?utf-8?B?V2l2aFE5ZFVqY3QwWVhJNWNFaytnWlc2TGN1VUxNb09obmhHK0tpaGcrSmlW?= =?utf-8?B?K0NRQSszV3kyVzNQNmo1YjJreTdXanVXbitGSml0dkJZci96MVA3bStlOXF3?= =?utf-8?B?WGFHaEQ2NGg1U2tGQ3ZHRlBpQmczQTVma0ZGMEJXbDFnUld5REZUMnlXSzBS?= =?utf-8?B?NEtOaXYzTnhTMi94M3A1RkZRVmp4T3NKaVUxbHVONjMzQllEWmwraG0xUmpZ?= =?utf-8?B?SnlvRW53b0JRMkE2d3RHT2ZBa1NiVTNaa1M1M3k4VzVmWm5Cd2hJMGM5MTFH?= =?utf-8?B?NktQcEV0bHBjRktoS3N2TjFiKzdsc25OMWR3VHN6TldoZzU2ekN3aXBsVkxt?= =?utf-8?B?ZEtlRGt1Q1JqVFVMVnBPaDJVYkVQK3dEVGJPOEQ5Z1dzSjJGMEVneDQramNl?= =?utf-8?B?WXlSUGtxTG1sRFZUdGdZVE9TUXVxUVlkU1M5eC9wT0tIbzVBMXhUdU5URFdk?= =?utf-8?B?OVNSV3pZSUErTnZCbEVuNXRWM1RwVEVwUzNPZEVtc1gzaEYyd2tianpuMFlp?= =?utf-8?B?dXpvR2d6NFpuTE1zK3ZuODhkRWxPdVRLOEhQNHhaeGgvbEZPcGhqdTZiWCtu?= =?utf-8?B?dUE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <1D95F0D67B20544C809C0743122493D2@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c438cfa-7cae-43d5-c2c9-08da6902ac28 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 21:15:42.4925 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N04M2wFrNwB4re/zwa2o9dMddffbO+wlqVD1+mOHiqUwdTrhK7RtLS1z5KJp8UGlfi15Ib+Ve6tUZkJaE206t4KHIsO75qXdfDqgMkadR2Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6288 X-Proofpoint-GUID: zhFlXhG--pwUbkfipFwlwnGzJ__2JklR X-Proofpoint-ORIG-GUID: zhFlXhG--pwUbkfipFwlwnGzJ__2JklR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_20,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180089 RnJvbTogT2xla3NhbmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVw YW0uY29tPg0KDQpBIGd1ZXN0IHdvdWxkIGJlIGFibGUgdG8gcmVhZCBhbmQgd3JpdGUgdGhvc2Ug cmVnaXN0ZXJzIHdoaWNoIGFyZSBub3QNCmVtdWxhdGVkIGFuZCBoYXZlIG5vIHJlc3BlY3RpdmUg dlBDSSBoYW5kbGVycywgc28gaXQgd2lsbCBiZSBwb3NzaWJsZQ0KZm9yIGl0IHRvIGFjY2VzcyB0 aGUgaGFyZHdhcmUgZGlyZWN0bHkuDQpJbiBvcmRlciB0byBwcmV2ZW50IGEgZ3Vlc3QgZnJvbSBy ZWFkcyBhbmQgd3JpdGVzIGZyb20vdG8gdGhlIHVuaGFuZGxlZA0KcmVnaXN0ZXJzIG1ha2Ugc3Vy ZSBvbmx5IGhhcmR3YXJlIGRvbWFpbiBjYW4gYWNjZXNzIHRoZSBoYXJkd2FyZSBkaXJlY3RseQ0K YW5kIHJlc3RyaWN0IGd1ZXN0cyBmcm9tIGRvaW5nIHNvLg0KDQpTdWdnZXN0ZWQtYnk6IFJvZ2Vy IFBhdSBNb25uw6kgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KU2lnbmVkLW9mZi1ieTogT2xla3Nh bmRyIEFuZHJ1c2hjaGVua28gPG9sZWtzYW5kcl9hbmRydXNoY2hlbmtvQGVwYW0uY29tPg0KDQot LS0NClNpbmNlIHY2Og0KLSBkbyBub3QgdXNlIGlzX2h3ZG9tIHBhcmFtZXRlciBmb3IgdnBjaV97 cmVhZHx3cml0ZX1faHcgYW5kIHVzZQ0KICBjdXJyZW50LT5kb21haW4gaW50ZXJuYWxseQ0KLSB1 cGRhdGUgY29tbWl0IG1lc3NhZ2UNCk5ldyBpbiB2Ng0KTW92ZWQgaW50byBhbm90aGVyIHNlcmll cw0KLS0tDQogeGVuL2RyaXZlcnMvdnBjaS92cGNpLmMgfCAxMiArKysrKysrKysrLS0NCiAxIGZp bGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCg0KZGlmZiAtLWdp dCBhL3hlbi9kcml2ZXJzL3ZwY2kvdnBjaS5jIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCmlu ZGV4IDlmYjNjMDViMmIuLmM3YTQwYTJmNDEgMTAwNjQ0DQotLS0gYS94ZW4vZHJpdmVycy92cGNp L3ZwY2kuYw0KKysrIGIveGVuL2RyaXZlcnMvdnBjaS92cGNpLmMNCkBAIC0yMTUsNiArMjE1LDEw IEBAIHN0YXRpYyB1aW50MzJfdCB2cGNpX3JlYWRfaHcocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25l ZCBpbnQgcmVnLA0KIHsNCiAgICAgdWludDMyX3QgZGF0YTsNCiANCisgICAgLyogR3Vlc3QgZG9t YWlucyBhcmUgbm90IGFsbG93ZWQgdG8gcmVhZCByZWFsIGhhcmR3YXJlLiAqLw0KKyAgICBpZiAo ICFpc19oYXJkd2FyZV9kb21haW4oY3VycmVudC0+ZG9tYWluKSApDQorICAgICAgICByZXR1cm4g fih1aW50MzJfdCkwOw0KKw0KICAgICBzd2l0Y2ggKCBzaXplICkNCiAgICAgew0KICAgICBjYXNl IDQ6DQpAQCAtMjU1LDkgKzI1OSwxMyBAQCBzdGF0aWMgdWludDMyX3QgdnBjaV9yZWFkX2h3KHBj aV9zYmRmX3Qgc2JkZiwgdW5zaWduZWQgaW50IHJlZywNCiAgICAgcmV0dXJuIGRhdGE7DQogfQ0K IA0KLXN0YXRpYyB2b2lkIHZwY2lfd3JpdGVfaHcocGNpX3NiZGZfdCBzYmRmLCB1bnNpZ25lZCBp bnQgcmVnLCB1bnNpZ25lZCBpbnQgc2l6ZSwNCi0gICAgICAgICAgICAgICAgICAgICAgICAgIHVp bnQzMl90IGRhdGEpDQorc3RhdGljIHZvaWQgdnBjaV93cml0ZV9odyhwY2lfc2JkZl90IHNiZGYs IHVuc2lnbmVkIGludCByZWcsDQorICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBp bnQgc2l6ZSwgdWludDMyX3QgZGF0YSkNCiB7DQorICAgIC8qIEd1ZXN0IGRvbWFpbnMgYXJlIG5v dCBhbGxvd2VkIHRvIHdyaXRlIHJlYWwgaGFyZHdhcmUuICovDQorICAgIGlmICggIWlzX2hhcmR3 YXJlX2RvbWFpbihjdXJyZW50LT5kb21haW4pICkNCisgICAgICAgIHJldHVybjsNCisNCiAgICAg c3dpdGNoICggc2l6ZSApDQogICAgIHsNCiAgICAgY2FzZSA0Og0KLS0gDQoyLjM2LjENCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 18 21:15:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 21:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370125.601804 (Exim 4.92) (envelope-from ) id 1oDY5v-0004kX-Bg; Mon, 18 Jul 2022 21:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370125.601804; Mon, 18 Jul 2022 21:15:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5v-0004kH-6J; Mon, 18 Jul 2022 21:15:59 +0000 Received: by outflank-mailman (input) for mailman id 370125; Mon, 18 Jul 2022 21:15:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5t-00043p-P7 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:15:58 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cfd31e8d-06de-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 23:15:56 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IImA9R005163; Mon, 18 Jul 2022 21:15:46 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hcrm7v72d-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 21:15:45 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6288.eurprd03.prod.outlook.com (2603:10a6:800:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 21:15:42 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Mon, 18 Jul 2022 21:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfd31e8d-06de-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CWeE+wJYWJJrwDHWsMt0I0M6DEXNVrWCgbCZUPtc2jIcH7M9kDuPs4JMi3+R++xIlnT211ZBwGYC7ggerZr2CRR2fnY7iAXlm+uizigD3MANCalXGo53W2cVN/lP/uYCFXVZeNtCUPgc3dtDtQYA6hgDx/XxgwZtkr8PdChfcWoe7Bdb/Mx45ao1frW53lGukUeP4XujT5IwulzQUzXOKEsF7M1c3JgsZC0HFL8E7qjTnYJWEOD/nlqxrViiZDOguiG+tu2Y7ANgNrN+LAFNcbKRF5bpte0uWa0lGzcokVpWkOho2URIU/1fubRjvyASHJCW8xM2h4uNLXTVJqjgCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mrfxkv03rMCDP4WEfyDsnkkchTYLXSytKn95yOOQFFk=; b=AUBOxrV1zCTx1FZZ+uFs1RMb6gZ2CA7fzYn0OaON6ixOHTn96+/jCKCr3d6w9Wq6tJYz6mxDxgtzyuHVtmsqezayucPKN48CkKDt+iON5ppzZaZ7P1cMlyPa5FOnYsFRqdoaTBAMvXyrkB1pzmA6NB9C82o4wVe7yDIyJlRq5uPt1o3+NpJzDOh/4m10UZIjwqlwyASIMKRAOXwasu71Ov004haKaNgHbBZhIoKiphcVSShtGgM3ztOc2zoWK/C5wie0AYQUI3/QJEkeKOWLd1aqJcBk9fbnFfneMIWBaA7KLjv7cNNI0qr5CWGKdNOlR1Z7y9Vz7nNVjJlfQwv/uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mrfxkv03rMCDP4WEfyDsnkkchTYLXSytKn95yOOQFFk=; b=GiznS+bq9UmTyCb/84UqC7dVFvyhh8Jdsa81hYsIpiHQs3MOtUerHwZtDl9Avrxzf1XiT8WaYTHxr19al1lnNUgjH28gdab2OuQOwcAeG1041g3hg9SZ7vxQo6wwvGf7zkFmsO9He/f761gyrdKo04lEwX1jZbaeAa7HzGxEBbPuwSq6A/CZAZ3oR1fJHagb5WOpa3xGp5k1hg7p5CgZjwm2gfxkD1EHIJBQ6jRzLCxjWjG/N8FgGEcN09igRcIr7Fns02lNFC3ohMuXQr/P970rcwQE62vHTjzhqi4psantt6RzJ8EmsQ5EArKDQmNY9zwMWsAkU3jDt2pHVHviRg== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant , Volodymyr Babchuk Subject: [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Thread-Topic: [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Thread-Index: AQHYmuuJlTOCfCU2VEeylMdGd6xTkw== Date: Mon, 18 Jul 2022 21:15:42 +0000 Message-ID: <20220718211521.664729-2-volodymyr_babchuk@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> In-Reply-To: <20220718211521.664729-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.36.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9a871693-0bba-4246-9dd2-08da6902ac02 x-ms-traffictypediagnostic: VI1PR03MB6288:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wpmVIOdDNmSMgAqWHfBSsR9o2XTEriWwO6FVHDMcUKiJuHX3zDk3kmliSYz0LfpeAo9ZOc38CssGN31eLTd0UQyEAhrTjuSigTkj+ackrJSUh8/6/5KJwdHbwMK5P/36pZFLrdWUs8e4GJGdc7G1xGHLGp7PN/kVSkGR2rFC8AMLvvTj/WDE5HrspwroWyXgiX4Emu1pJzEosaDr587qfXvfSxKJpv1AyIYv05Xgyq2gRo92t3yK6jhSrScQCCzWm954dXFn0bTlavn96ETewhRKi3R5JzmHuXfxmZ2TcM4OC6hJi99sICK/WnFDjJLr3h3I+umuUq6ZORsrxfS7HfXMS9eZ5AzZ4U3osdXj2F/1W8O6R+ITtfRO5xqRN8EnhpgTbOEvFFtTy51PYgURpngk2tVE8N1PT7lUn+AvsBYn6171wMe+h9oAkfEQW+let2BLB/fb9WgZNWvmvnCKcyS47iZm8cmPWTotXWza33bQggLLbqYGwA7vH7i4c7OATwiKfn0DM+HYvCQGM1MjisWKR+LY3BqVy9K2LWtHXdKuZ21dAXUpV+GrqQBUCBnQYzWt50B6PgFjreltrqCQbbkyZsRZKbu5//QNSgXFgKCHm6l+EZneWUGA2TEi95CoroTKXs7AB3oTMdSyv/iZuEYyPxCAgAhgPOr9dtJsh20NZNBal+ru7sthQktLre3X6RHXhc8CrJX+LvLa2n3P7uWf5qRR38f5c6ccyFQqQFZcy0u+LEw1i4y9Daoq8Cjf51B9UeI7gLDLTq9R5RteS+z7VmRlGvTkMl8NCDw2HtV/A1ComHnZat5Ic19KrOYI7eX4nvsE2HMCtzweLsCUAg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(2906002)(5660300002)(8936002)(36756003)(186003)(4326008)(86362001)(91956017)(64756008)(66946007)(66556008)(8676002)(66446008)(66476007)(76116006)(122000001)(6506007)(478600001)(316002)(2616005)(6512007)(6916009)(26005)(107886003)(54906003)(6486002)(55236004)(1076003)(41300700001)(38070700005)(30864003)(83380400001)(38100700002)(71200400001)(309714004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?C7YAgEgWd29Bn7l9BkWaPKqwzZxjOJTknjR6aNkIFqKiDPtVhVXeihDT+w?= =?iso-8859-1?Q?7O8fZuG1flrcii9XbePGPvjL5MFxxvVzBz8g6mXJ8zqgYHcAxF4k7CwhJx?= =?iso-8859-1?Q?wJTqhmj+GnBq/Lxs9c7M/0mlNERt2KL1Vw9aE3AXq3vPOSrO+FcZ+KuNN0?= =?iso-8859-1?Q?zVxBPl0MzE7VwcY0OQ0TThjShqdl1/62Qzo5lPdYzglwvBSMMFIHnQieaV?= =?iso-8859-1?Q?9mvBAbcbH9J9xZ0ULs+SrjLTajRBW9gNbG5geg7SSP2H42pn+i1+0TkIEI?= =?iso-8859-1?Q?DYkiMGsl03Yyse88FJR4xjQnWA3+wWTKrJax+bGF5YT3MydMM1CQeLpi1j?= =?iso-8859-1?Q?LHTlno4EMZ9iF6u4/tUqZ8fJl9RER6D2xBGNOYgTRUBEPI/lNxme8ZP89n?= =?iso-8859-1?Q?12FJgWSC7xR21bdoJdZ9BvRGl8V4Sgera4rS5Y7hnSA4A+RRuOlNY3UEDe?= =?iso-8859-1?Q?e+BWI5iuC3dqWpuqkw5lydsX03dUbaBM2GKDHHU3PMMTHJG3QdM2wpSKPp?= =?iso-8859-1?Q?zdy2b/aaPDExZy9CRRAYwcyNFVm6OCAIKRToLZ+MSAKvRJxNicoTumcTVB?= =?iso-8859-1?Q?1+4FDyl2N35G5bxTly94JeX2We+k6GCmhoTVmr/EhtzvQ/J3nsVKEjR3Pg?= =?iso-8859-1?Q?F0MafoX2KsLtbgIAdWc87qJWtPGoACFs7OlLCWJCZ9i3DvQRYCbn9Yi0X5?= =?iso-8859-1?Q?tUbK8GXJR7TIUKd+e2TLxi5kvp2HCLB45WyzpTDX3gQ+84UQs1Mo8ob4CY?= =?iso-8859-1?Q?6i/J730Gg4kDLPkPiil1UQaO7Y03XqTjPOL/YT5JaFcSTMwU9JygtFVXzk?= =?iso-8859-1?Q?b9vD+N3QtEjv16i/XyOt4bt6C/y2asTB2IviQiSM8Y5XNArK2IJwv4Y/bN?= =?iso-8859-1?Q?Ryp85Lrpzd3qBtUZMfEh4Fu+j4Jg6qLyxkJftEXEeVt3ypwJ2DPnTCoIRD?= =?iso-8859-1?Q?Ko8Wdbw6SFFzyZyA2OepRJxF4UcD9owUkr2wdMAUOGaPjQ6insD+yDutQR?= =?iso-8859-1?Q?7hHYL8QghFOkwmmqlvOEY5iENQlcgqVrUEM9YANLScYInbiAjuhTP3Ovck?= =?iso-8859-1?Q?LRF1P/h2rD4dZfeQ8JAiRT+RVSP2dgNU9JSRCe8DSKDxW8NeSx0tRbB/g2?= =?iso-8859-1?Q?eCm9V61FVyJQSurizwZEbMT5PWXug5z+DLWmzhaA5YKTRJ1DiUeJcAnYCu?= =?iso-8859-1?Q?PxWov/c2+ef2hwu87mmFVhft7+BtfRR8y6d8l5yAUK8nHEAI/WQ7FSEj5/?= =?iso-8859-1?Q?RN0Om5ZsLIORpMyjNiW2KOV27K8lbUj5XcI/hfBZ+wu3iZIUUdTUmmea+T?= =?iso-8859-1?Q?6tNQ8Mt0U6KUMSAhHaeY+QMgYfJIr7OpWJx0/AV4EuETgzoZ1+e8eUDCyu?= =?iso-8859-1?Q?KbrApTXYeXYjxcIFetNHZvGK020YRy6jCgHqSw0i8AsyCrmHLoHOdBzCtw?= =?iso-8859-1?Q?qzDa9vBqaPQWyrUfQMnp4kwLjmTV9t+28MPmOtoJakLYugnwRMIDI9hL+Z?= =?iso-8859-1?Q?mxylJlaNzolwtDSGKzbHB7NZvrlTZNxa7zVgA+1omEqkorkHQlQzzwO2Wd?= =?iso-8859-1?Q?X3WlOfEFAgqoIF4DY15OTOYnEhg32RXrzYS4GeoRYSLPEygthU9mtGGis/?= =?iso-8859-1?Q?BrZw6j3CbRuJGKAaz8cbler5oGmvDYxf1h1f6H8cA5znpAku8vAAHXzg?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9a871693-0bba-4246-9dd2-08da6902ac02 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 21:15:42.2581 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: l9XW/h6+XsKHYBkSpQeMJ4bE7wercW/YB7tkhVo24AUPSGhaX5WkbEvowUfEI2OQfw117QAu6zCgj3VE2vwIWJ+hXy7i/yKVFhuPrHn8+WU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6288 X-Proofpoint-GUID: xxKPsVfYVFEv_UacRVeoyWL-kt6yti-L X-Proofpoint-ORIG-GUID: xxKPsVfYVFEv_UacRVeoyWL-kt6yti-L X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_20,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180089 From: Oleksandr Andrushchenko Currently pcidevs lock is a global recursive spinlock which is fine for the existing use cases. It is used to both protect pdev instances themselves from being removed while in use and to make sure the update of the relevant pdev properties is synchronized. Moving towards vPCI is used for guests this becomes problematic in terms of lock contention. For example, during vpci_{read|write} the access to pdev must be protected to prevent pdev disappearing under our feet. This needs to be done with the help of pcidevs_{lock|unlock}. On the other hand it is highly undesirable to lock all other pdev accesses which only use pdevs in read mode, e.g. those which do not remove or add pdevs. For the above reasons introduce a read/write lock which will help preventing locking contentions between pdev readers and writers. This read/write lock replaces current recursive spinlock. By default all existing code uses pcidevs_lock() which takes write lock. This ensures that all existing locking logic stays the same. To justify this change, replace locks in (V)MSI code with read locks. This code is a perfect target, as (V)MSI code only requires that pdevs will not disappear during handling, while (V)MSI state is protected by own locks. This is in preparation for vPCI to be used for guests. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Volodymyr Babchuk --- Since v1: - user per CPU variable to track recursive readers and writers - use read locks in vmsi code --- xen/arch/x86/hvm/vmsi.c | 22 ++++++------ xen/arch/x86/irq.c | 8 ++--- xen/arch/x86/msi.c | 16 ++++----- xen/drivers/passthrough/pci.c | 65 +++++++++++++++++++++++++++++++---- xen/include/xen/pci.h | 10 +++++- 5 files changed, 91 insertions(+), 30 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index d4a8c953e2..c1ede676d0 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -466,7 +466,7 @@ int msixtbl_pt_register(struct domain *d, struct pirq *= pirq, uint64_t gtable) struct msixtbl_entry *entry, *new_entry; int r =3D -EINVAL; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); ASSERT(spin_is_locked(&d->event_lock)); =20 if ( !msixtbl_initialised(d) ) @@ -536,7 +536,7 @@ void msixtbl_pt_unregister(struct domain *d, struct pir= q *pirq) struct pci_dev *pdev; struct msixtbl_entry *entry; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); ASSERT(spin_is_locked(&d->event_lock)); =20 if ( !msixtbl_initialised(d) ) @@ -682,7 +682,7 @@ static int vpci_msi_update(const struct pci_dev *pdev, = uint32_t data, { unsigned int i; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); =20 if ( (address & MSI_ADDR_BASE_MASK) !=3D MSI_ADDR_HEADER ) { @@ -724,7 +724,7 @@ void vpci_msi_arch_update(struct vpci_msi *msi, const s= truct pci_dev *pdev) =20 ASSERT(msi->arch.pirq !=3D INVALID_PIRQ); =20 - pcidevs_lock(); + pcidevs_read_lock(); for ( i =3D 0; i < msi->vectors && msi->arch.bound; i++ ) { struct xen_domctl_bind_pt_irq unbind =3D { @@ -743,7 +743,7 @@ void vpci_msi_arch_update(struct vpci_msi *msi, const s= truct pci_dev *pdev) =20 msi->arch.bound =3D !vpci_msi_update(pdev, msi->data, msi->address, msi->vectors, msi->arch.pirq, msi->= mask); - pcidevs_unlock(); + pcidevs_read_unlock(); } =20 static int vpci_msi_enable(const struct pci_dev *pdev, unsigned int nr, @@ -783,10 +783,10 @@ int vpci_msi_arch_enable(struct vpci_msi *msi, const = struct pci_dev *pdev, return rc; msi->arch.pirq =3D rc; =20 - pcidevs_lock(); + pcidevs_read_lock(); msi->arch.bound =3D !vpci_msi_update(pdev, msi->data, msi->address, ve= ctors, msi->arch.pirq, msi->mask); - pcidevs_unlock(); + pcidevs_read_unlock(); =20 return 0; } @@ -798,7 +798,7 @@ static void vpci_msi_disable(const struct pci_dev *pdev= , int pirq, =20 ASSERT(pirq !=3D INVALID_PIRQ); =20 - pcidevs_lock(); + pcidevs_read_lock(); for ( i =3D 0; i < nr && bound; i++ ) { struct xen_domctl_bind_pt_irq bind =3D { @@ -814,7 +814,7 @@ static void vpci_msi_disable(const struct pci_dev *pdev= , int pirq, spin_lock(&pdev->domain->event_lock); unmap_domain_pirq(pdev->domain, pirq); spin_unlock(&pdev->domain->event_lock); - pcidevs_unlock(); + pcidevs_read_unlock(); } =20 void vpci_msi_arch_disable(struct vpci_msi *msi, const struct pci_dev *pde= v) @@ -861,7 +861,7 @@ int vpci_msix_arch_enable_entry(struct vpci_msix_entry = *entry, =20 entry->arch.pirq =3D rc; =20 - pcidevs_lock(); + pcidevs_read_lock(); rc =3D vpci_msi_update(pdev, entry->data, entry->addr, 1, entry->arch.= pirq, entry->masked); if ( rc ) @@ -869,7 +869,7 @@ int vpci_msix_arch_enable_entry(struct vpci_msix_entry = *entry, vpci_msi_disable(pdev, entry->arch.pirq, 1, false); entry->arch.pirq =3D INVALID_PIRQ; } - pcidevs_unlock(); + pcidevs_read_unlock(); =20 return rc; } diff --git a/xen/arch/x86/irq.c b/xen/arch/x86/irq.c index de30ee7779..7b4832ffb1 100644 --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -2156,7 +2156,7 @@ int map_domain_pirq( struct pci_dev *pdev; unsigned int nr =3D 0; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); =20 ret =3D -ENODEV; if ( !cpu_has_apic ) @@ -2313,7 +2313,7 @@ int unmap_domain_pirq(struct domain *d, int pirq) if ( (pirq < 0) || (pirq >=3D d->nr_pirqs) ) return -EINVAL; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); ASSERT(spin_is_locked(&d->event_lock)); =20 info =3D pirq_info(d, pirq); @@ -2907,7 +2907,7 @@ int allocate_and_map_msi_pirq(struct domain *d, int i= ndex, int *pirq_p, =20 msi->irq =3D irq; =20 - pcidevs_lock(); + pcidevs_read_lock(); /* Verify or get pirq. */ spin_lock(&d->event_lock); pirq =3D allocate_pirq(d, index, *pirq_p, irq, type, &msi->entry_nr); @@ -2923,7 +2923,7 @@ int allocate_and_map_msi_pirq(struct domain *d, int i= ndex, int *pirq_p, =20 done: spin_unlock(&d->event_lock); - pcidevs_unlock(); + pcidevs_read_unlock(); if ( ret ) { switch ( type ) diff --git a/xen/arch/x86/msi.c b/xen/arch/x86/msi.c index 6be81e6c3b..6ce7b5523a 100644 --- a/xen/arch/x86/msi.c +++ b/xen/arch/x86/msi.c @@ -613,7 +613,7 @@ static int msi_capability_init(struct pci_dev *dev, u8 slot =3D PCI_SLOT(dev->devfn); u8 func =3D PCI_FUNC(dev->devfn); =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); pos =3D pci_find_cap_offset(seg, bus, slot, func, PCI_CAP_ID_MSI); if ( !pos ) return -ENODEV; @@ -782,7 +782,7 @@ static int msix_capability_init(struct pci_dev *dev, if ( !pos ) return -ENODEV; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); =20 control =3D pci_conf_read16(dev->sbdf, msix_control_reg(pos)); /* @@ -999,7 +999,7 @@ static int __pci_enable_msi(struct msi_info *msi, struc= t msi_desc **desc) struct pci_dev *pdev; struct msi_desc *old_desc; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); pdev =3D pci_get_pdev(msi->seg, msi->bus, msi->devfn); if ( !pdev ) return -ENODEV; @@ -1054,7 +1054,7 @@ static int __pci_enable_msix(struct msi_info *msi, st= ruct msi_desc **desc) struct pci_dev *pdev; struct msi_desc *old_desc; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); pdev =3D pci_get_pdev(msi->seg, msi->bus, msi->devfn); if ( !pdev || !pdev->msix ) return -ENODEV; @@ -1145,7 +1145,7 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool = off) if ( !use_msi ) return 0; =20 - pcidevs_lock(); + pcidevs_read_lock(); pdev =3D pci_get_pdev(seg, bus, devfn); if ( !pdev ) rc =3D -ENODEV; @@ -1158,7 +1158,7 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool = off) } else rc =3D msix_capability_init(pdev, NULL, NULL); - pcidevs_unlock(); + pcidevs_read_unlock(); =20 return rc; } @@ -1169,7 +1169,7 @@ int pci_prepare_msix(u16 seg, u8 bus, u8 devfn, bool = off) */ int pci_enable_msi(struct msi_info *msi, struct msi_desc **desc) { - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); =20 if ( !use_msi ) return -EPERM; @@ -1305,7 +1305,7 @@ int pci_restore_msi_state(struct pci_dev *pdev) unsigned int type =3D 0, pos =3D 0; u16 control =3D 0; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); =20 if ( !use_msi ) return -EOPNOTSUPP; diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index 938821e593..f93922acc8 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -50,21 +50,74 @@ struct pci_seg { } bus2bridge[MAX_BUSES]; }; =20 -static spinlock_t _pcidevs_lock =3D SPIN_LOCK_UNLOCKED; +static DEFINE_RWLOCK(_pcidevs_rwlock); +static DEFINE_PER_CPU(unsigned int, pcidevs_read_cnt); +static DEFINE_PER_CPU(unsigned int, pcidevs_write_cnt); =20 void pcidevs_lock(void) { - spin_lock_recursive(&_pcidevs_lock); + pcidevs_write_lock(); } =20 void pcidevs_unlock(void) { - spin_unlock_recursive(&_pcidevs_lock); + pcidevs_write_unlock(); } =20 -bool_t pcidevs_locked(void) +bool pcidevs_locked(void) { - return !!spin_is_locked(&_pcidevs_lock); + return pcidevs_write_locked(); +} + +void pcidevs_read_lock(void) +{ + if ( this_cpu(pcidevs_read_cnt)++ =3D=3D 0 ) + read_lock(&_pcidevs_rwlock); +} + +int pcidevs_read_trylock(void) +{ + int ret =3D 1; + + if ( this_cpu(pcidevs_read_cnt) =3D=3D 0 ) + ret =3D read_trylock(&_pcidevs_rwlock); + if ( ret ) + this_cpu(pcidevs_read_cnt)++; + + return ret; +} + +void pcidevs_read_unlock(void) +{ + ASSERT(this_cpu(pcidevs_read_cnt)); + + if ( --this_cpu(pcidevs_read_cnt) =3D=3D 0 ) + read_unlock(&_pcidevs_rwlock); +} + +bool pcidevs_read_locked(void) +{ + /* Write lock implies read lock */ + return this_cpu(pcidevs_read_cnt) || this_cpu(pcidevs_write_cnt); +} + +void pcidevs_write_lock(void) +{ + if ( this_cpu(pcidevs_write_cnt)++ =3D=3D 0 ) + write_lock(&_pcidevs_rwlock); +} + +void pcidevs_write_unlock(void) +{ + ASSERT(this_cpu(pcidevs_write_cnt)); + + if ( --this_cpu(pcidevs_write_cnt) =3D=3D 0 ) + write_unlock(&_pcidevs_rwlock); +} + +bool pcidevs_write_locked(void) +{ + return rw_is_write_locked(&_pcidevs_rwlock); } =20 static struct radix_tree_root pci_segments; @@ -581,7 +634,7 @@ struct pci_dev *pci_get_pdev(int seg, int bus, int devf= n) struct pci_seg *pseg =3D get_pseg(seg); struct pci_dev *pdev =3D NULL; =20 - ASSERT(pcidevs_locked()); + ASSERT(pcidevs_read_locked()); ASSERT(seg !=3D -1 || bus =3D=3D -1); ASSERT(bus !=3D -1 || devfn =3D=3D -1); =20 diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index f34368643c..052b2ddf9f 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -158,7 +158,15 @@ struct pci_dev { =20 void pcidevs_lock(void); void pcidevs_unlock(void); -bool_t __must_check pcidevs_locked(void); +bool __must_check pcidevs_locked(void); + +void pcidevs_read_lock(void); +void pcidevs_read_unlock(void); +bool __must_check pcidevs_read_locked(void); + +void pcidevs_write_lock(void); +void pcidevs_write_unlock(void); +bool __must_check pcidevs_write_locked(void); =20 bool_t pci_known_segment(u16 seg); bool_t pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func); --=20 2.36.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 21:15:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 21:15:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370126.601810 (Exim 4.92) (envelope-from ) id 1oDY5v-0004p4-Lb; Mon, 18 Jul 2022 21:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370126.601810; Mon, 18 Jul 2022 21:15:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5v-0004oL-Gv; Mon, 18 Jul 2022 21:15:59 +0000 Received: by outflank-mailman (input) for mailman id 370126; Mon, 18 Jul 2022 21:15:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDY5u-00043p-L5 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:15:58 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d0366d87-06de-11ed-bd2d-47488cf2e6aa; Mon, 18 Jul 2022 23:15:57 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26IImA9T005163; Mon, 18 Jul 2022 21:15:47 GMT Received: from eur03-ve1-obe.outbound.protection.outlook.com (mail-ve1eur03lp2051.outbound.protection.outlook.com [104.47.9.51]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hcrm7v72d-5 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Jul 2022 21:15:47 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by VI1PR03MB6288.eurprd03.prod.outlook.com (2603:10a6:800:134::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 18 Jul 2022 21:15:42 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Mon, 18 Jul 2022 21:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0366d87-06de-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnHiF3xqr0l7KB1cozyYzFptAwsSkKHK5kZHVvJlsRV57uV4DLvpkbI5QTwYqp7QfqhJeUEeqUfSdVX+oeAo3SmB1ZNqsklehINn51dBJTnkNVQuBr3m1Mk9sFxQwb+SRthGfLMCj0PEqTRCEAcl9HCUEVYNNl49AZsFg76RrXG9XZsceXOs3ndKI8DjBQHW8zFN6+LgzrUTgfmcrC+ZADVJ/orT8tQshcgycVuF5h7m2zw4jbYIhYL+/LfHjYM8/B6lPFXtjbpPikiyySwNGcyTzvAEK0mkkIMpWC1lxj9xoCx0WmRYl0fzEjv5BiZ04QG7Y92VVKP/UNDx6VKGBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=51uIUXejlp+stzTIoouwR0IIpUJyhvl7006kWAxwFuA=; b=B1ropvomBBjZOxibwUE6C6140HbQu5bCYX04YOgBMeDgKf9HKLirQMO3sB1bAubjl82Vwtzoada+1mHfTHOPhot3w3LynO7vRFF8rOwXFwzecKZrAua63gYQ3kZV0CYZrR4slNA4Ol/8Xt1108bU4aKy5m2r3LIrRGj7b1oXMqz6uL2Z6Ge3Ni65adXO6ne71fRDBzHEn2qsIG9Zb5sZ3j8FCes71hkkk/Nybvy1EyTTjOd0rIaL/Cf6Z4yJiWOMdpXza9tOlIagDz28R08oN0e9Fker/MWu6ZsjvGKKsKnA8l1PCvyB+VwSpPHUCos9FJUU24W4R7ITGKx59oS+LQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=51uIUXejlp+stzTIoouwR0IIpUJyhvl7006kWAxwFuA=; b=mFNZm90s75AAP+RPh1NlQ7a5VcL64OhwoOzNMmVUjyFIuHY1NtAvsAPEYBefAz9nlcy10WZMKGo4CPBuBqWy5e9FfP5BEnQJ+88HnE8PcPBqRUMkmH1HO2Ij7UJAR7uLLDM+8bLm7vtnEevgMjc0JLUAPGazXvH+NQxObfzV3tWp4kT/YtO5yZnsXIhc0RWPPKyKJSe51c9KdfK1ywTIiPjdPhKfSgEKlxUwi9gYremadqqIek5Onh8DoYZ4wAykE8TOEcPdKMvcwSXuk1Bc5c3xKlKgOujReng+mM6CEFeAgdFWkASHk+ifuOb99/yuZNqYXfohdhQRpOFo6JiWEQ== From: Volodymyr Babchuk To: "xen-devel@lists.xenproject.org" CC: Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: [PATCH v2 3/4] vpci: use pcidevs locking to protect MMIO handlers Thread-Topic: [PATCH v2 3/4] vpci: use pcidevs locking to protect MMIO handlers Thread-Index: AQHYmuuJA1lWCBgnj0iqi/IOtvD1PA== Date: Mon, 18 Jul 2022 21:15:42 +0000 Message-ID: <20220718211521.664729-4-volodymyr_babchuk@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> In-Reply-To: <20220718211521.664729-1-volodymyr_babchuk@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.36.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 34069ad9-9f6e-407a-ac59-08da6902ac53 x-ms-traffictypediagnostic: VI1PR03MB6288:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: c3xyq5Nx1U+m5MHuIrZ25mx7wNPx+WeGtDmIssKabcrgWhpEI6vwoLZWrTpn4oyVR0Gux/eolqf6cg07QDI3OSop48VZJPeEB58MeEdNETQ8n2MXb5624WlYJ7jHp/CS9zNqd2eU2I3s+Aesle3hEZMKqoeRW2Ns9Z9QtndTIzOxr7BA38sh6HkQZBZQaVPFwjzdqTEHU8YgggrkDCng12I2J5GQyPodV74nOYgjL9skm/XKby5nG8WMBHXUsPYz8s1U8FwEzwL/vemvfqEsbvSg38gwjAF0fs0A2qMOrxGN+zykdPVD5HMSkDUhfnKgP2VjTHWvzyFqAmat1sT22f+nJHCIha3W9MFLehuZUW7WNMow9Xx7Xs46bE/+ZDHqgvGztig9YXhq9SR+TFq1i5v/uf9877vu6jIikH5S+D1jajp5eoeNrSHYD4Pt+Aqs9m96qIa5D9+zHHY92WIk9pRTQmbZZUuvcyiFc6DpGF7osdmXDB3rVPX/2tn0KxNO1dPSIrHqNH663NwR6ERVn3WVAzfuRlorVFrqZHDf1lATUj7ahTrGagA17jhV7KXfY4fb/mlfslcoYgwNz8mXA5uq39V5qzxajfZCb/ZI+nc1+mIn2Wy4URwHrspA/rYXc4XIufprS5arLpu+74XYrz3WVToA7spCsPgdRVu02ic48nGrfQhOwByUtWCf7flMKVepzyAHu+YyZy0l3KBOOcH/OFm/6e5UejSPoWUf2ZyjaQOgjzTseB83IyAFxuM1CNJvxxETaoaPrzibR4GKSDmBxENIE01QUvvO6f0u5ZwPlq2+RwwY2Rj0Hz78URMg6+2AXyfW3Js10iIWNMKBjA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(39860400002)(366004)(376002)(2906002)(5660300002)(8936002)(36756003)(186003)(4326008)(86362001)(91956017)(64756008)(66946007)(66556008)(8676002)(66446008)(66476007)(76116006)(122000001)(6506007)(478600001)(316002)(2616005)(6512007)(6916009)(26005)(107886003)(54906003)(6486002)(55236004)(1076003)(41300700001)(38070700005)(30864003)(83380400001)(38100700002)(71200400001)(309714004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?f8TdYz0CSYwwzu6pGaumKlrLp1jRvmzf/2p2T+rZQQ+uS+1Cl2LFg7Ok4x?= =?iso-8859-1?Q?+rYyV1xqxg8x8Pgk724RCPILF4rUw55VJABrH0ZwGU7jnaaWDzxqBWuZhC?= =?iso-8859-1?Q?JGkWcTILFUw+muBSy0xSBAb6FaSXt2enSYZsc8/4HseIHujm+nBeU0w3n/?= =?iso-8859-1?Q?XViss9RoUJ5B511jylfgcy93ezbb+xsF5FmVfv732166O98gwHs/lxlowL?= =?iso-8859-1?Q?8t0odY3/lA09Ph7/q1gug8pg6aQxu4+Vpl/XiXMMW+P+m8ckY+5kAxDZnz?= =?iso-8859-1?Q?wZg205XM0HNUHFs+fcMnr0Ined1f6rKHrlUqTyd1ICJNDk4u3FChZyBAWN?= =?iso-8859-1?Q?jgo+vi0UjNVjqS2PxJ/OarrIFZoiyuSqgqhRJvgULJ1Cjzpnc6JSDZimBs?= =?iso-8859-1?Q?/P0p+TjkFZwdxEtp4KwTVv4F9vpNTMV1HWFSi8L3bvqwK67+uuGDx8hwEi?= =?iso-8859-1?Q?mGj88Hv4S6nKoT3Tup1CvZfqJ3DE27ma2Ua1m7d/avcXAuW9N86lgsEDNu?= =?iso-8859-1?Q?BPVVduVmk/PkosgVXb314Grn52FHkg1PRF7PfQiy8/+ARYQ5vSwn7Rppqb?= =?iso-8859-1?Q?JU97WmUc3IBr0znJbti1Yar/4etvjGipoMRiH6oWRnYX85H937FIjrPi7n?= =?iso-8859-1?Q?PjfLFtUbxO8g/N6WSqeHLUy3sXFT8dPs3j+G3RdFJYRi+dNerJY6UzwYMf?= =?iso-8859-1?Q?wPQ79QZz5j7SReuLZJ8Z2bEmmnbtbz8IkhTQiXcs61OOUfB8pTSIjomXQk?= =?iso-8859-1?Q?LxAZYbuY6X47sifKxsB5TunnKqKI1BC7J5SJ5EM1jNDu57Ah80c2Hxk6qj?= =?iso-8859-1?Q?fOPdiN8sCC76I4/3uGk4n0AYK5UOBRNxlEaIqBDM3fFGwR+ebluMmTm2dY?= =?iso-8859-1?Q?CqlbnxPkEYTV9Po6d9PvgddL2TIHLazH1ikSML/ClYZjQznT9+/Bol9jAR?= =?iso-8859-1?Q?JalNGBXD8dKZJMUcVWzkToUBTdi8outmhuV/WXKVhvIf8DAwU5zDmQd5Ll?= =?iso-8859-1?Q?QGxpka0y1q//CbapZQXRiazXuotQgst0Y5tM9c9CZQvO5l4B0jjWXjFVER?= =?iso-8859-1?Q?gEve8W2D2w7buGITuGk9gXqbDWc7wQroSIj+vv4qEabg90jUhsRxacOUYH?= =?iso-8859-1?Q?NYSuKUHdo8VzlcG35zrqL0TfgAi7/Ci50G6pBDRr/P8PXMChkf99y6QdaX?= =?iso-8859-1?Q?J+TuIPFYT6HicqoCgrZ0QQYl4zR9F7amWDuXmA4z5HEZhWOiR1abJHrD1Z?= =?iso-8859-1?Q?cup/H2pujRccUi/C6kyGXUiQv1BLo0HmgJ/eggImNUd+f2o5PU1MGgZ5+z?= =?iso-8859-1?Q?E2Q0L853PZdBNjAuvjknGc01Y0LhvQhIa5i8NC30LijuSjrB1Yb4SkMvcN?= =?iso-8859-1?Q?VSDPocG2IbhNOC+KyuSa8+N+kd9r95VEIOQbzhswvaBTfbtc1VBw+08B0Y?= =?iso-8859-1?Q?Vf4J0wA6I5bS5rTHHJMCTzriEABOKbEhAVy/45fbx3tA0vJYEwKjID9pF6?= =?iso-8859-1?Q?o7wqzTNb0nUz3D9jf721S36Ki69ZBTvHtvuDR02fTW7UcPAOrIaZRWfB6Z?= =?iso-8859-1?Q?huzWK8obtpB041tVPQgIcPqI4TyRd4jg4Nw9f5PunbrcBmPyOO7NiqysZj?= =?iso-8859-1?Q?oCy3sepBFlzK/JSKYoT7kiSkzJOA5PcDjkQ15M7r4rTxXHueIr4e8qfA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 34069ad9-9f6e-407a-ac59-08da6902ac53 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 21:15:42.7893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yEJI410boRtbdSdqHfzpNCr79plULzdsebkneEC2l5Xbr3Cn3kaBEm8AN4rqFt+WLGG3XnlStnmRf1sQ10yHZ6NX/m1nJLGElLvEf9VhFvg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR03MB6288 X-Proofpoint-GUID: z2sEGbcbuvCAHsJY7GH6nIJoabdoNh6i X-Proofpoint-ORIG-GUID: z2sEGbcbuvCAHsJY7GH6nIJoabdoNh6i X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_20,2022-07-18_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 lowpriorityscore=0 mlxscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 adultscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207180089 From: Oleksandr Andrushchenko vPCI MMIO handlers are accessing pdevs without protecting this access with pcidevs_{lock|unlock}. This is not a problem as of now as these are only used by Dom0. But, towards vPCI is used also for guests, we need to properly protect pdev and pdev->vpci from being removed while still in use. For that use pcidevs_read_{un}lock helpers. This patch adds ASSERTs in the code to check that the rwlock is taken and in appropriate mode. Some of such checks require changes to the initialization of local variables which may be accessed before the ASSERT checks the locking. For example see init_bars and mask_write. Signed-off-by: Oleksandr Andrushchenko Signed-off-by: Volodymyr Babchuk --- Since v1: - move pcidevs_read_{lock|unlock} into patch 1 --- xen/arch/x86/hvm/vmsi.c | 24 ++++++++++++++--- xen/drivers/vpci/header.c | 24 +++++++++++++++-- xen/drivers/vpci/msi.c | 21 ++++++++++----- xen/drivers/vpci/msix.c | 55 ++++++++++++++++++++++++++++++++++----- xen/drivers/vpci/vpci.c | 16 +++++++++--- xen/include/xen/pci.h | 1 + xen/include/xen/vpci.h | 2 +- 7 files changed, 121 insertions(+), 22 deletions(-) diff --git a/xen/arch/x86/hvm/vmsi.c b/xen/arch/x86/hvm/vmsi.c index c1ede676d0..3f250f81a4 100644 --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -891,10 +891,16 @@ void vpci_msix_arch_init_entry(struct vpci_msix_entry= *entry) entry->arch.pirq =3D INVALID_PIRQ; } =20 -int vpci_msix_arch_print(const struct vpci_msix *msix) +int vpci_msix_arch_print(const struct domain *d, const struct vpci_msix *m= six) { unsigned int i; =20 + /* + * FIXME: this is not immediately correct, as the lock can be grabbed + * by a different CPU. But this is better then nothing. + */ + ASSERT(pcidevs_read_locked()); + for ( i =3D 0; i < msix->max_entries; i++ ) { const struct vpci_msix_entry *entry =3D &msix->entries[i]; @@ -911,11 +917,23 @@ int vpci_msix_arch_print(const struct vpci_msix *msix= ) if ( i && !(i % 64) ) { struct pci_dev *pdev =3D msix->pdev; + pci_sbdf_t sbdf =3D pdev->sbdf; =20 spin_unlock(&msix->pdev->vpci->lock); + pcidevs_read_unlock(); + + /* NB: we still hold rcu_read_lock(&domlist_read_lock); here. = */ process_pending_softirqs(); - /* NB: we assume that pdev cannot go away for an alive domain.= */ - if ( !pdev->vpci || !spin_trylock(&pdev->vpci->lock) ) + + if ( !pcidevs_read_trylock() ) + return -EBUSY; + pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.de= vfn); + /* + * FIXME: we may find a re-allocated pdev's copy here. + * Even occupying the same address as before. Do our best. + */ + if ( !pdev || (pdev !=3D msix->pdev) || !pdev->vpci || + !spin_trylock(&pdev->vpci->lock) ) return -EBUSY; if ( pdev->vpci->msix !=3D msix ) { diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index a1c928a0d2..e0461b1139 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -142,16 +142,19 @@ bool vpci_process_pending(struct vcpu *v) if ( rc =3D=3D -ERESTART ) return true; =20 + pcidevs_read_lock(); spin_lock(&v->vpci.pdev->vpci->lock); /* Disable memory decoding unconditionally on failure. */ modify_decoding(v->vpci.pdev, rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.c= md, !rc && v->vpci.rom_only); spin_unlock(&v->vpci.pdev->vpci->lock); + pcidevs_read_unlock(); =20 rangeset_destroy(v->vpci.mem); v->vpci.mem =3D NULL; if ( rc ) + { /* * FIXME: in case of failure remove the device from the domain= . * Note that there might still be leftover mappings. While thi= s is @@ -159,7 +162,10 @@ bool vpci_process_pending(struct vcpu *v) * killed in order to avoid leaking stale p2m mappings on * failure. */ + pcidevs_write_lock(); vpci_remove_device(v->vpci.pdev); + pcidevs_write_unlock(); + } } =20 return false; @@ -172,7 +178,16 @@ static int __init apply_map(struct domain *d, const st= ruct pci_dev *pdev, int rc; =20 while ( (rc =3D rangeset_consume_ranges(mem, map_range, &data)) =3D=3D= -ERESTART ) + { + /* + * It's safe to drop and re-acquire the lock in this context + * without risking pdev disappearing because devices cannot be + * removed until the initial domain has been started. + */ + pcidevs_write_unlock(); process_pending_softirqs(); + pcidevs_write_lock(); + } rangeset_destroy(mem); if ( !rc ) modify_decoding(pdev, cmd, false); @@ -450,10 +465,15 @@ static int cf_check init_bars(struct pci_dev *pdev) uint16_t cmd; uint64_t addr, size; unsigned int i, num_bars, rom_reg; - struct vpci_header *header =3D &pdev->vpci->header; - struct vpci_bar *bars =3D header->bars; + struct vpci_header *header; + struct vpci_bar *bars; int rc; =20 + ASSERT(pcidevs_write_locked()); + + header =3D &pdev->vpci->header; + bars =3D header->bars; + switch ( pci_conf_read8(pdev->sbdf, PCI_HEADER_TYPE) & 0x7f ) { case PCI_HEADER_TYPE_NORMAL: diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c index 8f2b59e61a..d864f740cf 100644 --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -184,12 +184,17 @@ static void cf_check mask_write( =20 static int cf_check init_msi(struct pci_dev *pdev) { - uint8_t slot =3D PCI_SLOT(pdev->devfn), func =3D PCI_FUNC(pdev->devfn)= ; - unsigned int pos =3D pci_find_cap_offset(pdev->seg, pdev->bus, slot, f= unc, - PCI_CAP_ID_MSI); + uint8_t slot, func; + unsigned int pos; uint16_t control; int ret; =20 + ASSERT(pcidevs_write_locked()); + + slot =3D PCI_SLOT(pdev->devfn); + func =3D PCI_FUNC(pdev->devfn); + pos =3D pci_find_cap_offset(pdev->seg, pdev->bus, slot, func, PCI_CAP_= ID_MSI); + if ( !pos ) return 0; =20 @@ -277,6 +282,9 @@ void vpci_dump_msi(void) =20 printk("vPCI MSI/MSI-X d%d\n", d->domain_id); =20 + if ( !pcidevs_read_trylock() ) + continue; + for_each_pdev ( d, pdev ) { const struct vpci_msi *msi; @@ -310,7 +318,7 @@ void vpci_dump_msi(void) printk(" entries: %u maskall: %d enabled: %d\n", msix->max_entries, msix->masked, msix->enabled); =20 - rc =3D vpci_msix_arch_print(msix); + rc =3D vpci_msix_arch_print(d, msix); if ( rc ) { /* @@ -318,12 +326,13 @@ void vpci_dump_msi(void) * holding the lock. */ printk("unable to print all MSI-X entries: %d\n", rc); - process_pending_softirqs(); - continue; + goto pdev_done; } } =20 spin_unlock(&pdev->vpci->lock); + pdev_done: + pcidevs_read_unlock(); process_pending_softirqs(); } } diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index bea0cc7aed..35cc9280f4 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -144,9 +144,13 @@ static struct vpci_msix *msix_find(const struct domain= *d, unsigned long addr) =20 list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next ) { - const struct vpci_bar *bars =3D msix->pdev->vpci->header.bars; + const struct vpci_bar *bars; unsigned int i; =20 + if ( !msix->pdev->vpci ) + continue; + + bars =3D msix->pdev->vpci->header.bars; for ( i =3D 0; i < ARRAY_SIZE(msix->tables); i++ ) if ( bars[msix->tables[i] & PCI_MSIX_BIRMASK].enabled && VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, i) ) @@ -158,7 +162,13 @@ static struct vpci_msix *msix_find(const struct domain= *d, unsigned long addr) =20 static int cf_check msix_accept(struct vcpu *v, unsigned long addr) { - return !!msix_find(v->domain, addr); + int rc; + + pcidevs_read_lock(); + rc =3D !!msix_find(v->domain, addr); + pcidevs_read_unlock(); + + return rc; } =20 static bool access_allowed(const struct pci_dev *pdev, unsigned long addr, @@ -218,17 +228,26 @@ static int cf_check msix_read( struct vcpu *v, unsigned long addr, unsigned int len, unsigned long *d= ata) { const struct domain *d =3D v->domain; - struct vpci_msix *msix =3D msix_find(d, addr); + struct vpci_msix *msix; const struct vpci_msix_entry *entry; unsigned int offset; =20 *data =3D ~0ul; =20 + pcidevs_read_lock(); + + msix =3D msix_find(d, addr); if ( !msix ) + { + pcidevs_read_unlock(); return X86EMUL_RETRY; + } =20 if ( !access_allowed(msix->pdev, addr, len) ) + { + pcidevs_read_unlock(); return X86EMUL_OKAY; + } =20 if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) ) { @@ -299,6 +318,7 @@ static int cf_check msix_read( break; } spin_unlock(&msix->pdev->vpci->lock); + pcidevs_read_unlock(); =20 return X86EMUL_OKAY; } @@ -307,15 +327,24 @@ static int cf_check msix_write( struct vcpu *v, unsigned long addr, unsigned int len, unsigned long da= ta) { const struct domain *d =3D v->domain; - struct vpci_msix *msix =3D msix_find(d, addr); + struct vpci_msix *msix; struct vpci_msix_entry *entry; unsigned int offset; =20 + pcidevs_read_lock(); + + msix =3D msix_find(d, addr); if ( !msix ) + { + pcidevs_read_unlock(); return X86EMUL_RETRY; + } =20 if ( !access_allowed(msix->pdev, addr, len) ) + { + pcidevs_read_unlock(); return X86EMUL_OKAY; + } =20 if ( VMSIX_ADDR_IN_RANGE(addr, msix->pdev->vpci, VPCI_MSIX_PBA) ) { @@ -351,6 +380,7 @@ static int cf_check msix_write( break; } =20 + pcidevs_read_unlock(); return X86EMUL_OKAY; } =20 @@ -428,6 +458,7 @@ static int cf_check msix_write( break; } spin_unlock(&msix->pdev->vpci->lock); + pcidevs_read_unlock(); =20 return X86EMUL_OKAY; } @@ -440,9 +471,13 @@ static const struct hvm_mmio_ops vpci_msix_table_ops = =3D { =20 int vpci_make_msix_hole(const struct pci_dev *pdev) { - struct domain *d =3D pdev->domain; + struct domain *d; unsigned int i; =20 + ASSERT(pcidevs_read_locked()); + + d =3D pdev->domain; + if ( !pdev->vpci->msix ) return 0; =20 @@ -487,13 +522,19 @@ int vpci_make_msix_hole(const struct pci_dev *pdev) =20 static int cf_check init_msix(struct pci_dev *pdev) { - struct domain *d =3D pdev->domain; - uint8_t slot =3D PCI_SLOT(pdev->devfn), func =3D PCI_FUNC(pdev->devfn)= ; + struct domain *d; + uint8_t slot, func; unsigned int msix_offset, i, max_entries; uint16_t control; struct vpci_msix *msix; int rc; =20 + ASSERT(pcidevs_write_locked()); + + d =3D pdev->domain; + slot =3D PCI_SLOT(pdev->devfn); + func =3D PCI_FUNC(pdev->devfn); + msix_offset =3D pci_find_cap_offset(pdev->seg, pdev->bus, slot, func, PCI_CAP_ID_MSIX); if ( !msix_offset ) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index c7a40a2f41..1559763479 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -37,7 +37,9 @@ extern vpci_register_init_t *const __end_vpci_array[]; =20 void vpci_remove_device(struct pci_dev *pdev) { - if ( !has_vpci(pdev->domain) ) + ASSERT(pcidevs_write_locked()); + + if ( !has_vpci(pdev->domain) || !pdev->vpci ) return; =20 spin_lock(&pdev->vpci->lock); @@ -332,10 +334,14 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,= unsigned int size) return data; } =20 + pcidevs_read_lock(); /* Find the PCI dev matching the address. */ pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn); - if ( !pdev ) + if ( !pdev || (pdev && !pdev->vpci) ) + { + pcidevs_read_unlock(); return vpci_read_hw(sbdf, reg, size); + } =20 spin_lock(&pdev->vpci->lock); =20 @@ -381,6 +387,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg, u= nsigned int size) ASSERT(data_offset < size); } spin_unlock(&pdev->vpci->lock); + pcidevs_read_unlock(); =20 if ( data_offset < size ) { @@ -443,9 +450,11 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, uns= igned int size, * Find the PCI dev matching the address. * Passthrough everything that's not trapped. */ + pcidevs_read_lock(); pdev =3D pci_get_pdev_by_domain(d, sbdf.seg, sbdf.bus, sbdf.devfn); - if ( !pdev ) + if ( !pdev || (pdev && !pdev->vpci) ) { + pcidevs_read_unlock(); vpci_write_hw(sbdf, reg, size, data); return; } @@ -486,6 +495,7 @@ void vpci_write(pci_sbdf_t sbdf, unsigned int reg, unsi= gned int size, ASSERT(data_offset < size); } spin_unlock(&pdev->vpci->lock); + pcidevs_read_unlock(); =20 if ( data_offset < size ) /* Tailing gap, write the remaining. */ diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h index 052b2ddf9f..c974ebdc94 100644 --- a/xen/include/xen/pci.h +++ b/xen/include/xen/pci.h @@ -161,6 +161,7 @@ void pcidevs_unlock(void); bool __must_check pcidevs_locked(void); =20 void pcidevs_read_lock(void); +int pcidevs_read_trylock(void); void pcidevs_read_unlock(void); bool __must_check pcidevs_read_locked(void); =20 diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 67c9a0c631..7ab39839ff 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -175,7 +175,7 @@ int __must_check vpci_msix_arch_enable_entry(struct vpc= i_msix_entry *entry, int __must_check vpci_msix_arch_disable_entry(struct vpci_msix_entry *entr= y, const struct pci_dev *pdev); void vpci_msix_arch_init_entry(struct vpci_msix_entry *entry); -int vpci_msix_arch_print(const struct vpci_msix *msix); +int vpci_msix_arch_print(const struct domain *d, const struct vpci_msix *m= six); =20 /* * Helper functions to fetch MSIX related data. They are used by both the --=20 2.36.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 18 22:00:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 22:00:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370153.601826 (Exim 4.92) (envelope-from ) id 1oDYmo-0003m6-K5; Mon, 18 Jul 2022 22:00:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370153.601826; Mon, 18 Jul 2022 22:00:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYmo-0003lz-Eo; Mon, 18 Jul 2022 22:00:18 +0000 Received: by outflank-mailman (input) for mailman id 370153; Mon, 18 Jul 2022 21:31:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYL9-0000f3-SB for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 21:31:44 +0000 Received: from mail51c40.carrierzone.com (mail51c40.carrierzone.com [209.235.156.251]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 013d637c-06e1-11ed-924f-1f966e50362f; Mon, 18 Jul 2022 23:31:39 +0200 (CEST) Received: from mail51c40.carrierzone.com (localhost [127.0.0.1]) by mail51c40.carrierzone.com (8.14.9/8.13.1) with ESMTP id 26ILVao6018702 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 18 Jul 2022 21:31:36 +0000 Received: (from webmail@localhost) by mail51c40.carrierzone.com (8.14.9/8.12.2/Submit) id 26ILVasJ018701 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 17:31:36 -0400 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 013d637c-06e1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=carrierzone.com; s=mailmia; t=1658179897; bh=AhnMIb7unyr/51BuDkbbUwlmVBdp77SLUVZ/UVBF5ZE=; h=From:To:CC:Subject:Date:From; b=h5vUxeHhWWqtf8PFWaRuF8uPFgcylytZvnk6E4BfqwCF1PK6yXsTLBfjUFWLuqKeX atFruXc7Pn6pv6pMK7r9x0WyPrSG2ifqpq3mroB/TDgS8gafLFZvI2QJc6oWQC+Sgr vKgF3fZVWrigvxoygLoe7cKEt92u8PHwk/OI087c= Feedback-ID:chris@dalessio. From: chris@dalessio.org To: xen-devel@lists.xenproject.org CC: Subject: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Date: Mon, 18 Jul 2022 17:31:36 -0400 Message-ID: <1658179896.l7m1s9efz6ok84g8@webmail.everyone.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_63112eca475a6e081828f3319b62f832" X-Image-Url: https://webmail.everyone.net/api/storage/chris@dalessio.org/profile/picture X-CTCH-RefID: str=0001.0A702F16.62D5D138.0090,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: Unknown --=_63112eca475a6e081828f3319b62f832 Content-Type: multipart/alternative; boundary="=_563ba471a0dcfd21fe3daf8c5655dc08" --=_563ba471a0dcfd21fe3daf8c5655dc08 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 =09 As requested by=C2=A0andyhpp=C2=A0on xcp-ng.org forum for threadPanic on CP= U 0: Xen BUG at iommu-init.c:1419 I am trying to run Xen-4.16.1-4.fc36 on Fedora 36 on a brand new Lenovo Thi= nkStation p620, but I keep getting the following error booting the Xen kern= el. Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Screen shot attached. Version info: Linux xen-test 5.18.9-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMIC Sat Jul 2 15:5= 6:43 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux Name =C2=A0 =C2=A0 =C2=A0 =C2=A0: xen Version =C2=A0 =C2=A0 : 4.16.1 Release =C2=A0 =C2=A0 : 4.fc36 Architecture: x86_64 Install Date: Tue 05 Jul 2022 06:07:43 PM EDT Group =C2=A0 =C2=A0 =C2=A0 : Unspecified Size =C2=A0 =C2=A0 =C2=A0 =C2=A0: 203030 License =C2=A0 =C2=A0 : GPLv2+ and LGPLv2+ and BSD Signature =C2=A0 : RSA/SHA256, Wed 22 Jun 2022 03:46:22 PM EDT, Key ID 999f= 7cbf38ab71f4 Source RPM =C2=A0: xen-4.16.1-4.fc36.src.rpm Build Date =C2=A0: Wed 22 Jun 2022 02:24:38 PM EDT Build Host =C2=A0: buildvm-x86-19.iad2.fedoraproject.org Packager =C2=A0 =C2=A0: Fedora Project Vendor =C2=A0 =C2=A0 =C2=A0: Fedora Project URL =C2=A0 =C2=A0 =C2=A0 =C2=A0 : http://xen.org/ Bug URL =C2=A0 =C2=A0 : https://bugz.fedoraproject.org/xen Summary =C2=A0 =C2=A0 : Xen is a virtual machine monitor =C2=A0 --=_563ba471a0dcfd21fe3daf8c5655dc08 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=UTF-8
As requested by andyhpp on xcp-ng.org forum for threadPanic on CPU 0: Xen BUG at iommu-init.c:1419

I am trying to run Xen-4.16.1-4.fc36 on Fedora 36 on a brand new Lenovo Thi= nkStation p620, but I keep getting the following error booting the Xen kern= el.

Panic on CPU 0:
FATAL TRAP: vec 7, #NM[0000]

Screen shot attached.


Version info:


Linux xen-test 5.18.9-200.fc36.x86_64 #1 SMP PREEMPT_DYNAMI= C Sat Jul 2 15:56:43 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Name        : xen
Version     : 4.16.1
Release     : 4.fc36
Architecture: x86_64
Install Date: Tue 05 Jul 2022 06:07:43 PM EDT
Group       : Unspecified
Size        : 203030
License     : GPLv2+ and LGPLv2+ and BSD
Signature   : RSA/SHA256, Wed 22 Jun 2022 03:46:22 PM EDT, Key ID 999f= 7cbf38ab71f4
Source RPM  : xen-4.16.1-4.fc36.src.rpm
Build Date  : Wed 22 Jun 2022 02:24:38 PM EDT
Build Host  : buildvm-x86-19.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : http://xen.org/
Bug URL     : https://bugz.fedoraproject.org/xen
Summary     : Xen is a virtual machine monitor
 
--=_563ba471a0dcfd21fe3daf8c5655dc08-- --=_63112eca475a6e081828f3319b62f832 Content-Transfer-Encoding: base64 Content-Type: image/jpeg; name=20220714_180414.jpg Content-Disposition: attachment; filename=20220714_180414.jpg; size=807953 /9j/2wBDAAYEBQYFBAYGBQYHBwYIChAKCgkJChQODwwQFxQYGBcUFhYaHSUfGhsjHBYWICwgIyYn KSopGR8tMC0oMCUoKSj/2wBDAQcHBwoIChMKChMoGhYaKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgo KCgoKCgoKCgoKCgoKCgoKCgoKCgoKCgoKCj/wAARCAyABwkDASIAAhEBAxEB/8QAHQAAAgIDAQEB AAAAAAAAAAAAAAEHCAIFBgQDCf/EAF8QAAEDAwMDAgQEAwUFBAMCHwEAAgMEBREGByESMUETUQgi YXEUMoGRFaGxFiNCUsEkM2Jy0ReCkrIlNEOi4RgmNURTVGNzg/Ano7PxNmSTwig3RXTSdYSURlVW ZeL/xAAZAQEBAQEBAQAAAAAAAAAAAAAAAQIDBAX/xAA0EQEBAAICAgIDAAICAgEDAQkAAQIREiED MUFREyJhBDIjcUKBM5GxwSRSoRRDcvA0YtH/2gAMAwEAAhEDEQA/AOOHughMI8L571sSELLCMIrH yn2RjCDhAkfomQkgAEO7pgIIRWGEALLCAP5IMceyQCyRjKIxwM+6AFkUlBiRymmjCil4RjlNCJSx gJLIZyjGURjjn6oWWEIMfqhPCZHsoMccp+E8Je6BYT8IxyhUH8keEeEAZQLCZCfblB55QIhLwskA KDEeyeEYwUIF+yOwT8IPdAvugfVZYSQJGE8Iwq0xwmAmhAsI8p4QQgxx2T7J9kY4UZJI+6yPdCRW KMZTwhVS8pLIpAKIWMowsgOOEdkGB74TWRCRHKKSMJ4QQgRHCB78JoQYlMIQECxhGAghHhAkfThN JUNLwmEDuoEcYR7Jo5QLHGEAD3TKWMqhjujHKEd1AdkIHdNAkFZeEkCxwkAsiOeED6oEE8Ix7IQC AE0IFhGE0Y7oFhBTwhAgjumkgEIKaBY5RjhNGECR4TPZGOEC+iaAEIApYTQAgWE00YQIDlMjKEv9 UAeyBwUEJhAeUYR4TRWJSIWeOUIlYEI8rLHKWPsgWEDun5TwgX9EAcJ4RlABHco8p/dAsDKMfRPy njlBjhCy8peUGOMp/ZP9EYQJPGUYTQLHOfKR79u6yIz2QeP1QY4+if7IQgEJpIEO2PCZGe6ePPlA QLssTyc5WeEuECCWc5WRHCMAIMRz3SPdZY55TGEGJ7fVGOOVlhCDHHul4WZ+qCEGOEllge6RARSI 7pjj6IBwjwgD2SKf0Rj3RCPGEBPhGMoMccJ4WRH04S8dkIWAhMIPZFIDCMccJhCBHlLCyQgxATHu U0iUCx9E0wjHKDEdkYWQSCIWEYWSXY+6BYQRhZJeUUZCWOEwhAuAghMfyQgxxlGPCy90kQdKD2R3 TAygx9/qjwn5S5QB5RhM9kIrFPshNAiElkEwMhBgUll5R5QIBLGVngIWVfMjnCYTPJRjygFjhZBH jwoMfCPoVl4CADnsqMQM9kyMceVmOAkWcoFjvhGO6zA+iEHzwPsngY7LLCWOOyULpwc90iAsvoQg DhRWPCfhPukQUCwsSFml2KBJDkrIgpeUAlhZJIEhNAGCgEu3KaRKAwlj2T7IQJBTSwgSM/RZcFLC DYZ4TwljlNdnLYKPKaRQIgZSPKbvogKbAlhZeUfqmzZN4SI7rIBI5VNsShZH+iSGywl2WWEIMSEv CySxwpsID3QRlMIUVj2QnjyjH0QGPOEYTQCiEQjCaECAQg/ZAQCSaCECKMI8phAkJoQJNBHCYQY/ RNNL9lAiOEDP2TRhBimE/ukgXlMppIoST8p+ECSwsilj2TZsimmljKA7oCYQQiF5RhCfdBiR7J+E YQm12SX9Fke6SIAghNHhAj7JJlJFGOUFHlMhFIhIJlCBIT90kC8oxymhAisVnzhJNhBNBwEu5+yD LCRTSHKBFHlCYQAQjCZQJACaEBhCEBAkHumhAk0IQCEIQGUIQgEIKEAjyhMdwgEeU0kAgoR3QHlP CAhAkeE0vKAxkoTQgPCRT8IQJBT8oKBITxyhDYwjyml5QCAEY900CwjHv4WSMIMPKeOU0gMn2QBR 9Cg/onjugXlHcp4z3R/JAeEI8IHdAdgnhMJEYQJMjCfhHhBj4QAcpoQAR5Qn2QY4Tx9ks90/CAIQ hACAPbhHhGE+yBYS791l5SPYoEjCEf6oDCMYKCmeR7oF7IHZGEBAsfb6p+EfZPwgxCaEIMSM/VPC aWQgQGeUHGVkljygQHKD7ALIfVYlAkyn3CWEUeUIIwUwECwlhZICBBHZMd0iOUCKEwghAkJgIxhA ghNGEB4S8pkIRCR4R/VPuihLymkgD3QnjlCBIQjHKAJ/dCZHCWECKXlMo7Imgkn9E/qgWEFPwjCK SAhHhAsIxhM/RHt2UAEOTxz90iOFFCxPfGeyyAx5QRlDTEcBMAeeUwP1WSGmGORx2WRCYH6Jgfqm 1YoTKE2EeyMJ9wkcpsACB90IzgKBHH6pJo5zzhAsIwmgIAD7LEjlZrHHKDE+UcJkcpY4QB5CEY+i CECIOAgdsoT+6Bd0sLIpIF4Qn2KSA7I4QUggFjyskZPsg2COyaMLs4kmEIUBhJMJBFCMIP1QiBCE YwgXlLysgkVQFI90+Euyi6CRWQS8oMSEEJo7qaGKeUFBQJPCeOyMKhITwjt2QJIBCaA5QhA/mgR5 R28po7qBdggd08coCASOE8JEIBCAEIBCPKPCAHCB9UYwgd1AHuj+qaSAI5QhH6KgygcoRjhQCEeU IA8pJoKBJ8o8oQHdB7I8oQLugp/okgG8IKfhCBFGMBB+qD24QIDlMIwjumlIpeVklhFIownjCEGK PKZ7owgXCPKEIBLsOEyhAkIR4QNIpoQHZJMpIHlCEIBCEIBCEIBCEJoCEJhNBICaSAQnhHnsgSY7 pH6JgcoGhCECTR5QEAhMJYQHCSySQCEIQCEIQCEJoEmgo8IF9UJoQGUJpIGkmkTygf2ScmEHugxT CE0CITwU0IMSEwmEfdAICEBAFHhCAgPujwhNAghNHKDHGE0/CECKAUIQCCgJlBiMj7II+qaX+iBY Qmf3S+uMIBPCMZRjhAkJox90C7p+QhCASQmgWOEk0Y57IBCMIwgXdMhMIQLhB7I4z9UFDZICfKXl FBH7IA4QnhEHhLCE0UgMITR9kCRhNIoBB4R90ygXdGE0IMSE8eyfhLugMIQUIDCXlNHlAeEs8plI hAHugBH2TQIhY4weMrMoUGKMeyeM8IwgSPKZRhFIlB/mmgFAsIwmAjHPlRIXdBTx344TIRpiE0wj AygMIwsh+6R7qBIHITSQH3S7JowgSEJhAghB5R5QLylg+FkUIMfCFl3RhAgl7rLCWECJP6pdlkkQ gSQH7p8oGcoERz7Iwnj3SQLCRTyUigXnumgIwgR+qRWSWMHKBFLP0TKMINkn5RhBXVyIpALIpdkB jwjHsmEdkGJCOyzPZY4QLHCMLJIjCBDukU0IjHCSzKxxnsig9kvCaCgRCPHCAn54QYnskAskkBhC PHCPCAQgIBQIowmf1R5QGAke6aPKACOyQCagSEA8p4QJGOEJ+UC/ojCZ5CPZAu6CgJ+ECKWFl3Qg XZCEeyA8pYTTHZBimEIQCEJ4UGIKP5poQJPwhA7oBLyme6OyACXlMpIAdk0DshAiEITQY/yTQjHh AiUiVkVjjlFGUE8dkvuhFGfojv37oKAgEIwlhAITSwgAgppIBPCAgoBIphBQJHlCAgEY/ZNHdAim hHlAYQEeE88LQR4CPZCO6AQjygqAQUIKgEJ+UcoGkjKaBIT8oQCQCE0C/khNGECR+iD7I88KyA7I xyjlMhAfdBKEYUB4QjyhAITQgXlNHlNAvul3CZCBwgQ4TQhABLP7pnKB2ykgMo5QU8eVdASJT7Iw mgsY54QcrIoAymgh25R3QUx2TQQymUc+QjCaAEeUuyaAQg8BHhQCPshB5PCBEIAQjwgPZCSMd1Q/ CMZ+yO36I8KBBNCEAl9kd00CHZCAP/toQCB5R5R37IBHumg/VBin5QRhGUAAUYTQgX3KRTPKEC8J LIpBABHICYQOeyELCeOEBBRSQO6aMIEUFNHuoFhCD4R5QCMJgYQgSCE/sgoMULIpAIBJPCPsgEIR hFLHCMcp/ZCGiR4TR91AseyO6yCEGJ+iE/KD3QLwghPCMIEgrJHdQ0SEwEYRSRhPsj+iBYR3CE+6 BI8pjukgMITwkUCPdJPCMIEnjKEIMfOPZMpkZQgMJdkykgRPKEHBCMIAd0ZwlhGD4QMjJWKMp4/T lAeOPKxd491lhIjlAiSl5WWAsSECTzwhLKBlLuhCBFLpKy7lGEGySIyVkeEl1ciRhNCBFB5TcEFA ieEI8IQPCxIWSR+iDEoKyISwgx8oKyS8oEUiskkC/kgozygoA90u6PKaBITKWEB5STKMIEEJpIBA R2KPCgEZQUKgwgIQgEH6JpKBBHlH7p+EAl/RNAAQL9E89kEJBAI8JlLGEBlPKQ+qfhAkJ4QECKf6 IPukgEfzT8owgSaPKAOECQhA7oDCX9Fl/okoHjhJHOPCEAl2KaWeUDQgcBAQJCaSDHyjKZGUucoo wkU0eyKDz9EimAkgYS/khCBgYCXYITQJHn6I9keECTRhMck5QJNGOUdkAUd0YyjslCPCPKO5QEga Q7cpoWgHslhNBOECCfhH1R5UAkE/CEAjyhAUAn5R3QfCAQl5TQHdCEeEDwlnyED2QgWU8cBCasoS D3TJQUCIwhNCgQQmhAYQnhCgAEFHdMBUIoTCCgWUITQJCeUHjwmwk0gE1oCE/KWUAEIT58qbCQmU vCbAD9EDlHnsmOAmxiUJjvyE8JQkcJ45Rj2UGJTCE0CPdBQmgXHdGEx3SPKuwiEz2T8JKUGEu6YQ UGLkA8pkeyMfZAh9U/COyCgCOEeEIQGEYQhAITHukgEeEfdGPCAS8JlHhAvKMc8JpIGj3SCaA7pJ pFAJoCFALFZIwopDshNHlAk0dihAJd00IFhNCB3QCWMJ+UEoEhMpeUUeElkAhUJGE88YWP0UD8JJ oQJGFkMI7oElhZgZRj3RSCOPZMhGFAFIplHdZCwjjsn4S591YAhLCZ7pdiqDCEx+iRQPxzykEY+y CgSEIQJMJJoAoQl5QCCE0kCI/dCaOyBAeEk0EIEEuyaMIEg90c8oQCx4PdZFY/dAiksu33SAygSP qsscJIADj6rFZYSx9kG0x3RhZYSXVyYlCfcoKDFCeOOEkAgZQe3CQQNB7+yEHnhAu6E0j34QCR4C aRCBfdBR4QMjwgSMI5yhAFIJ90IEjCB3TH3QIpHsskkCST8oKASTCD9ECTSyjsgPKEJ+ECCeEJfV AFGE+yXlAIKEIBAHHKB3R5UAhHnCPogAhCEAhPwkgChCCgaSEHsgEykOwQgEBCZQLug/1R3QgAEY THZCgRSTR5QJBOEyjxwgxKY7J+UigSMJoKDHHKR+yyS8opFCZGQhFIoCEDuoHjKRTWJQBQjwmgMp pdyhXYMcpoSJ9kD88oPP0S4TJQJHYoKB2TQaEk+yoXlGOEBMKBIwjnKaoQQn5RxhQJNHhAQPwhCM oApeU0JsCB24QEeEAhIFPKBHumgIQBCPCEYwEB3RhCflAk8ITKACEdkKBD6poQqBCPKAEAjuhNAJ Ec/RPCSBoQEJsCEDsgfugSaE0CIQmUkAmllPCAS8pkJeEAmkEIAowmgIEksvCR7oDCEcoQIJoSQC Ez/JJABHhLGD3TQB+6RHsmn+6BYRjlCfdAvCOwR4QgPKfdLsjygR7oHCaQ7oHjJQhHlAsJoRhAh5 QE0kAn3TSUBhGOOO6AhFJCY5RhQLKCnhB+iBIPumE8cIMfCE0yMoMUJkfRACAISwfsnlP7qqxPdC yxlI8IDCCgoAKgRH80AcrIFAHOUCwhZYTworDCYBWR7IQIDASwQsihBj4THZBCSAPf3STzhA+qlB 4SPPKZQQoF3CR9k+6CECCD/NPCCFoIcHCCjCECR4QjsgQCMJlJAE4QjujugWEz3QEHlBj5Qml5QC EYQfCBFCaSBY5Qc5R5TQLulhMpnlBhhBWWFiRnCBA8oTx9UYQI8kJcfVNCDaoIyjymAuzkSRCyxw jCDDwgjhZEZSAQY4TKfhCmgsYOUlkhwCaGKxKySQJHZHlPwgxKE0kCwjPGE0AIEEsJoQLyjCE0Qk vCaOxQYowmnhRdsUeE0vKGyQCme6FQvCMp90IEEd0eUwgSE0ioAICaOyoEISUAeR9EAppIDKEBNA s8ITIQmggE0YOUEJoL6oQRwmgWE0IQCEBBQAQl4QgyHZIj2TCFAkIKB2QI/RHhNBCoSB+6P5oU0B LwnhBQLykUwEIEEsLIIPARdsUuyZ7oRQljKB3KagRQCmfYpHukAPqgcdk/CQQH6o7JoQIITQrsJC YQApsLPCaaAmxjlNGP5o7JsB5TwkhXYEJoQCWOUwjCAKEHlGEAhHnlCA/RCCMIQBQjymeyBIQjug M4TQE0CQmR2SQGMIHdCYQCR7p/VGFAAcp+6AgBUIJoTQL7ppeU0CKY7peUeeU0A90JnkI8IABGEI QCE/KxPKaD8p8YSxxygHB/8Ap5QB47ITSCAwksuySAQhCBeU0I+qASwmgIEjATKEAl9k0AZCBIQj ygMIH2RlHdAh2TCOyEAe6X+qChAeU0k0CKEY90ID+qPKaSAQgDlCAQg+yaBIwgpqAKSYRjhAkBZD +SAorHyhZIwECRjI7o7JjwgOyXlPHulhA+yQTHHdCACfYLFPwgRHKAPonhMopIwCmjATakR9yjH6 rLCFBjhNNGE2EhNCmwkJpJsCCmkmwIIT8chJNhYykRx9E0d1AgmEsYRj2QHc9uUimUBABLH3TQSr sY4QE0klBlCMjyg/RULyl3TPdBQLCMcppYQIlBTQUCQj+SEBhJyMoPdAI7pI8coBCMo8oBCOEIEk AsikgxIymeyMeyMIMUJ4z4R0j2QbU90ICeF2ciS7phCAwkU/CO5QY4Twgo7oEg8o8oKBFI8JkIUG KEyPKXdAFJNLuUAUsJhCBYSTJ5QhSQmUvKIYSwgBH2UoX6ITSCASIT8IQLxykn5RhVSQQmUIF4Rl HdACAQmgoBJPCMIEEYR5TKBYQmUIEjwnhJA0JBCBoSHdGUAUI75RhAyhCxKBlHhCFAk0BBQPwhAT TQXKPKaB2QJIpoKBHlIJ/wAkEfsoEeyE0JQkBCPCAQeUIQIhYnssu6RHCNEAj6p4SwgSfbugJoEU Jo+6BITSUB4Txx90vPKaUCEFCAwgIQgYSQmoFjGE/ZCCqA/RJMIVCATwhLKBlIJoAQAQhCACPKEF AJEchNCBALLCXdCATwjv7DCCgD+iO6E0CQhNAig5QnhABCAnhAYS7J/dGECBTAyE+ySAwjCaEC+6 E8IQBCWE+6EBhIIyjKoMcowgJoowjGPsgcJqIx+yEwEYQJNCPOUCwQEJlGECQAmEFAkICePZAvKf uhLuEAUIQgEk8IQJB7p+Uh3QCEIP9EAjuhCBcpoQUAEIHZAQAQglCAQhGEDwhCFkJMd0DhMfuikQ nxhHdLCAQnjlCoAgjH2RgrJBgmngBPCDHGUlkkEAj6IKYGVAvCAmUwFmqSCFljlPCgQCMZP2WRSK BFLusksIEkU0KhdkeU0sKKMIQhAkYTQgWEEISHdAz3STKR7oH44WHlZI7lAku6zHCx7IEgIQUgRH KCmE8ccrQwQsiMFLsgSEHujKASCeeEkAkmhBie6FlgJIEksliUAhCEAhA+iRKAPdCMoQIgHugfRM hLygEs/dZIz90G1STQOV1ciKXdZJYVAOSkmkgEIKB2QJJZfskUCPJ+iRWSO5QYe+c4Tx7JpdgiEe EgP/AKcpkIwRhQIpY4+yaEGJCPKyWPlAdkJpIDyhCECyhPHdJAJFNCDEcI8JoOMIoSwmhAvKEI+6 IEY4TA4QigDhBCfdJAkJoQASHZNIoBJPCEAlhNCA7JeeUykgfZBRhCASKaECCf3QUh3QCeOEIKzQ 0/CQOE0CRwnhCBIKEFAEJe6aP3QY/slhZFJFhdkFMjhA8opJJoIQJCPCPKBDtwhPsl5QCEY4RygP shGEEIBHYJ4SQACE8IQJGPdMhIIDCYHuhHhAFHhBTUCKEIQH3R+iE/CoQCMIT8qBAfdPwhPKoxHJ TwkO6ZKAwjCAmgSMJoQIJ+UkeMIDCfKEgOUDACYxhHlGeVAEYQEIVC8J/wBEICAGAkn5Kf1QhJ/R BSOEUeUIyEIDKAgJ+EAg9kk+MIFyn390IQH2STKAEAjOCjsgIGkU0c5VC7HCAU8cpdkShCEeO6gE gmjsgEYSRnygeMIRlLlA8DCAkgdkDPdJM/ohAhhIlCFQeMoT78JFAwkjGUzwEUkdkfZBRAjz9UIU DSQsuwUGKPKeEFRQhGEeECTQEx9UCCyzx2SxzwmQgXlZLHz9Uz2Wg+EsJjtwkeFCAoQmopIRhNAs fRHKflMIMU+U8J4QIcJnsn3CXhZqgJ+EgmolCSfZCBZWJzlZFLxhFJNYrIBWpQjGQnhLwoEjCP8A VCql5+qEyMJE4QCQ4TBQoEUHsmlhAvKeMJFGUAUk0IFhHCPshAEcJDKYKCceEGPlCCkVoMjnukU/ CSBeEsLJH3QYjhCaAgCl5QgIEe6B9EJ8IEksj+yxygaxPKfhCBIKaRQCWAmj/VAIz9EFLH3QbcpJ lJdnIBH2QEvuoGke6aSBYQmUlQDugoSwgEDughY/qgyWJPfCOeUHBwiESgHKSD/9PCB+eyRSz/NH ZQPv+iMpYwEDt9EBn6JZTxhY5QZZCRKSEDylkIQgCnwkEkDSR5QgPKXlB7oRT8oKQ7IBQMdkJJIM h3S7FH80dygMpkpYTCBIyjCCMoDKEEICACEeUFAeUJfdNA0kkwgaRKEdygEZR3R2QCEsIQZAphYh NQB5TBSR2QNBSQgaXjOUIQIpZTckosCEjnKeP3RR5SJR5QgP1SPdPykgEFCPCACSEdkDQjuEvKBp ITB8IBPKSEDH2QccJYT7hAscoTz4S8IDuEHuhNAvPKY7oCP1QHOEeEHhHdQBQjCE2GjwkO3CeFQk efCD7phAYQjCAgO6E/okgaSEIGCjv2S8I4QGEefCfCR7oHlCEd0AhHKPHKgB3TwlhPyqDCO3ZCMK hkcJAJo8oMTwPKEzyUkUeEITQLwmOQgp444HCgQQOE0eEBxlGEkxlAdkITQLygIKB2QA7oIRyChE JCE8IEmAM+yO6OyBeUfZCOR3UAmEksZCGjzlCOyCOE2Ef5JJpKwZePCQCQCeOU2p/ZY+FkkmwkJh L7KgQmgcKAHCEIKgaEBLKgAhPwkgAmeyMYRn+aBgLJYg4WQ91YF5QeyaCMBUIIwmhZUiCmAnhMBB jz5TwnhPCDHCYCeEygWEYTQs7GP+iaP5oQJMIQgSPCEJo0EnJpJoIDJQeEA/smUViCmjwgd0TRYQ skjhFInlJMhLHKA8ITSwmgJHhZLEqAKR4TCECx7oTSI5QA747pFMHCXbCAwjHKAjygRz7pYT4RjK uwsHuke6yKRGAmwYSPCEIFlCEIAIP1R2SKbB4QEHwkiB2SkAn3QmwsITSKSqMY5R/VB5R4VCQEHu j9UAU0j7Y7p9J9ig2vdJNyXZdnIFCB+6aDFCZ9kdlNDH6pFwynnJ+gWmvWoKO1D+9fmTw0d1uY7L W57j3SJ5xkH9VF1y1zXzvcKXohj8cZK1D9TXZxJFdIPtwuk8VYvkiaCDxjBWJ4HuoX/tHdsj/b5j /wB5H9pLv5r5j9OpX8NT8kTPk5HCD28KFzqW7n/4+l/dH9pLuOPx8v7p+Cp+SJnwcfRH6hQwdSXb /wCXZf3CX9o7t3/HS/un4afkiaAMlLq5w1qhf+0d2810/wD4k/7R3Ydq+b/xJ+Gn5ImjDiljj5gR +ihc6jux/wDj6b90hqK6jtWzf+JPwU/JE0c/oggjuFDI1Hd//l6X90/7S3fGPx0p/VPwU/ImVvYl AGRlQ0NSXYDitkCyGprs3OK2TBU/BT8kTHjsSkByeQoc/tPeP/l2T+Sz/tRd/wD5df8AsE/BT8kT Dj7ZWP2wofGqbuP/AI9k+3Cz/tTeP/l1/wCwT8FX8kS6Bzj3R+iiD+1V4/8Alx3Cf9qbuePxjv2C fgp+SJex9QP1QW/ZRD/aq7g/+uOP3AKf9rLxj/1s/bAT8FT8kS5g+UDGfdRJ/ay7gYFUc/YI/tbe CB/tZ4/4Qn4Kv5IlrOf/ALSeMnhRJ/ay8H/47/8AchIasvA/+Oz+yfgp+SJdI6eSOPolnnGO/lRM NWXfH/rI/wDCEf2uu5PNTj/uhPwU5xLXlGcKJv7W3ZvIqgfoWoOrrv3/ABAP/dCfgpziWThYk8jJ AUUDV13JwZ2j69Kf9rLsTzUt/wDAE/BTnErHxzn7IOc4wQfsoq/tfdh2qG/+FIawu45/EN/8Kn4a c4lYfXCyAyopGsLtj/fR/wDhCTdYXYEkTsB/5U/DkfkiVsYH+iGjP0Kit2srw7vMw/8AdS/thdx2 nZ/4U/Dkv5IlTIzwmO/cfRRWNZXYd5W/+EIdrK7ZBEsZ+7An4cj8kSpjjx9vKMKLP7ZXUOyJIh/3 EDWF2PPXEP8Aup+Gp+SJTOcePojpOOcqLDrK645kiP8A3ExrS6AfnjIH/Cn4cl/JEpO4IR05HHdR cNa3bHDov/CshrO6ccxN+7VPw5H5Ik/t+iai860uvSQHQD7NTbra6DzCfu1Pw0/JEnjkIH35UZ/2 1ugP/sf/AA5WI1rc+rOYf/Cn4cl5xJ/HuCke3sFGf9tbln/2H7I/tpcRyPR/ZT8ORziTO44PCXJz wo3bre5Aflp8/ZP+3Fx8xQ8/cJ+HI5xIx90Z47KOP7cXDGDHB/NZf23rz/gh/bCn4cjnEic8YCOc qOxri4Af7mDHvgpt1zX9zDF/NPw5LziQx9co84Ue/wBua0n/AHEX2TOuKvxBCf3T8ORziQSD7cLH nOMFcANcVoH+4jP6rL+3FVjJpoyffKfhyOcd8QR4KXfgLgv7cVWP/VmH/vJf26nafmpY/wDxFT8W Rzjvilg/f2XBjXNRz/s0f7rL+3E5I/2ZgP3T8WRzju84QuH/ALbTZ5pW/wDiR/bh/wD8qN/8Sfiy OcdxylwBnK4ga4kP/wAbA/Yo/ty/gfg//dJ+LL6OcdyjP3XDjXLhj/Zc+/zLL+3J5/2Pj6OT8WX0 c47Ug90+rHlcUzXQx81Ifp86f9uWE/8Aqrh/3sp+LI5x2efP80wR4K41uuG//Kx59yhut4wc/hc/ Y4T8WRzjsQnn6hccNcRf4qZ4H/MOFl/beAD/ANWef+9yn4sjnHXkgeQjIx3C5Ea5gxzSyn9Qg64g Iz+Gl49yE/Fkc468oHsO65Aa4pv8VPLn7pjW9Ke1PLn6uCn4sjnHW5PkfqnnsuT/ALcUY4NPL+mM IbrWiPeGYEfZPxZfRzjrM8o6v39lyg1vQ9vQl+/CY1tRcYil5+ifiyOcdTkfqn48Bct/bSiJ/wBx N/LlMa1oSP8Acz4+wT8WS846kFIlcuNaUB7RTfsFl/bS345ZKM+elX8dTnHT+EZC5n+2duzx6p/7 qP7ZW8EFzZCE4VeUdKSCjv5XNHWNr95R9MLMawt3/wA0A+gU/Hl9HKOjGSfonnH6LnP7Y23t/e/s j+2Ft75f+oU4ZfRyjoh7p8Lnf7Y2zPLnj9E/7XWwjiR4/wC6nDL6OUdCeEgST2XPDV1r5/vXn7tT GrrXz/eu/wDCnDL6OUdDkfRH6cLQ/wBrbWB/vHZ/5Uv7V2z/AOTPH/dThfpeUb8Izz3Wh/tXax/7 Zw/7qY1Vajx67sectThfo5Rvcp5wOFoTqq0j/wBs7H2TGq7V5qTj6q8MjlG9zhPx3C0X9qbV3NQf /CmNT2k9qoZ+oThU5RuiQjPstKNUWrIH4kH9Fl/aW1j/AOOePspxv0vJuM4QO/C0zdSWsn/1oH9w j+0lqB/9ZaT7ZP8A0Tjfo5Rusn2KB2GVpxqS14yKliP7Q2wj5atqcb9HKNwj+S1A1DayMfim5/VP +0FrHaqaFON+jlG2ymCFqhf7ZjP4pmEC/wBrz/63Fj7pxpuNp1fsnkey1P8AH7Xn/wBajz90/wCO 2wniqjz9041dtoT7BGeFrW322+apn2Lkfxu24/8AW4v1dhONNxsSfol1YXgF6tzhzVxD/vJfxm2n tVxk/wDMmqm2xygOWvF4tx/+O4h/3gj+L27PNXH/AOIJxpuNh1ZTBOOOy15u1B4q4j/3gmLrRH/4 6iP/AHgnGm494KRP7Lxi6UP/AMtRZ/5gh10oOMVURPn5gnGm3s7FC8IulF/8tRAf84X0Fwof/lqL /wAYU41dx6iUZ4wvKbhR+KmEj/nCBX0h5/ERY/5gnGpt6s88o+q8wr6Q/mqogP8AmCba2lJ+WojP /fCvGq9OeUieMrzGtpc4/ERk5/zBZNq6bq5qIz/3k40ffOUurlfL8XTj/wBvEB/zBL8TTntPHj/m CnGm33J9wkSvkKiD/wCTsP8A3gn68OP96wD/AJgrqm31zxwjK+InhB/3jcfRyy9WEg/3jefqE1Tb PIygFfP1IwOJGH/vBHrQnj1GZ+4U402+ncIzyvmJYz/7Rp/7wT9WIDPqNz/zBOJtmjKw9Vg7vZn/ AJkCWP8Azs/8ScR9CULBz4w3Pqtx9wkJYz3kYP1TibfXHPBTyvl6rAP94wn/AJghsjB+ZwPtghNG 31Cy+6wa9h/xtH6plzO3UP3CaVkmCsctPPU3H3CbXM8uH7qaNswkgFvgj91lxx7/AHTSkhPqaPzY /dIuaTwRj7qBhCXWwDhw/dHUD/iB/VNVDQcZWPHhw/dNxaPP81NKXlNLIxnqHP1SyD3I/dNBpEpj pycOH7pHvk8fVNGx3Rn3SyP8LgSmecZ4V4qeVjnlIkZ+Uj9SnhpB+YD9VdA7I7lI44HUM+eUzgEZ I/cJoBKWU/l79QH6rEuZ4cP3WdUMFCx6gP8AEP1KCR5cMfdNDIlI5yjrZj5XfzS79iP3TRtkl2R1 NB+ZwA+6Qc3J+YJoPJKWUyWY/MB+oWPUD2Lf/EnEM9kspdQPHU3H/Mm4NHdw/dOKbMnhY5SPSD8r m/ukXNA5eE0bZjBSJ9lh1M/zgfqAmTHjmRv/AIgmjYyn4+yxDmH/ANoz/wAQWIc3k9bR+oTRt9Pu jPhfN0jMD52/uEGWPjLx/wCIJxptkTznuglfMyRtPLxj7hIyxDkysP2ITibj6pL5mWPGfVaB7ZCZ mh7CRn/iCuqbjIo8ZXyMsf8AimjH/eCXrQf/ACZn/iCnGm4+wIJS8r5Cohwf71mP+YJfiYc4MzB/ 3gnCm4+xSJ4XwNXTA/7+Mn26gkaylB5li4/4wtcKnJ9wRjCfUvN+NpM/+sRH/vBY/j6THFVET7dQ ypwpyj1ZOAjOF5TX0p7Tx/8AiCxNxpB3qoT/AN4Jxpyj2ZwEs8rxm40YOHVUA/7wT/iNvJ5q4v8A xgK8aco9rRwsgxeRlzt+OauAf94FZi527PFdB+rgE405R7GN54X0x9QvD/FrbnH46Ef95P8Ai9s/ /uEH/iTjTbceOUvKYRj3XRgh9kEpkJFQCxcTwAsvK+NRKIonPccBoLiVYVz+r9QNtFKGREGqkHyt 9vqolq6maqndLO4vkcckkr3X64PuVymnc7hxIb9AvC1g6XOOOF6/HjMY4ZXb4n2SR5TXVzJGE0IE n9kIQJCaEAhCEAhCEAhCEAhCECwhNCBITQgSMJoQLCE0IEmhCATJykhABGShCAzlGfdCEASjJQhA ZPujKEIGSEgefdJCB5GU8jxnKSED6ks/dCWEGWfZAcPOcJIQPq5R1JJIMupHV+6SED6ueUZHhYpo GHfU5WQkXzwmgzEiZkH1XywhB9BJ+iC/jHdYIQZh4TY4A5JXzSQfb1Oe/CDIPK+KEXb7epjgZR14 7YK+SER9mv8AcpdeSvkkUXb0B4x3CDIPK+CENvv1jPdIuyc5Xx8oQ2+4ePOUi/8AZfHlHKG3oMvH CfUCOSvMgkobffrwO6Qd9eF8UIbegSAAID8nvjK+HKMlTRt6C76hYh3OV8clGVdG336wTg4WRdjs QvN5RklNG3o9XxlMv+uR915gOUcqaNvQHYd8pGPOSkXtHOSvilhXRt9+oHsf3QffqXwyU1ND7jHu gux3PC+HPujJKaNvT155JwgODc4K8xz+qBlB9y8/TumX5GC5fBHOFR6A7jGQkXZ8+V58n3wjKmh6 M5PCC4cL4Bx8IyT57ppdvT1nHcYSDvrlef8AdPKaR9w79EHn/Flec5QCQcppXqDh2S6/sV5+opZP g4TRt6OrkkpiTA7rzjKMlDb7+oCeCUwfuPqvP1HHHCWTjuU0ben1CD3R1jC85J90+opo29AefdHU vMHFPqP1U0behzuPdHUOnjhefqPZLlNG3ozkZyf3QXAnkdl5wSAnk4yO6aNvRkYBxjCMj2GF5w45 7rLqI5JTRyfbIB7BJx57BfHr57I6ymjb0Bwx+UIBaPAXn6znvlBeU1Db0dQCYfjkLy9RPkoDjhOK 8nqBBOcFGQR7Lzh/HlIvcR3TicnoD2AjHf6JucCTk/svL1H6I6z2U4w5PV1DHJJ/VLIA915+s9sp B5CcU29PWB7hPq+ruPqvOH/RIvyU4m3qa5uOcpF3+UkfqvN1kIDzjwrxNvQCMptcAeQV5eo4QZD7 pqG3q9QEnDiP1R14Pc4XnDyTyAjqKnGLt6XOBxzhLrAOAT+hXmDj9yn1kY91eMN16C8kfnd+6A8t 56nfuvN1p9ZB+icTb0CR2e7v3TMxP+Nw/VecvOO6ReeB5TjDb0F7jz1OI+6yEpHIkf8AuvIJHBPr +icTk9BlkyT1v4/4k/Vce73/AKOXm60F5BTibr1eu8E/3j//ABI9Z+Meo8H/AJivJ1nPKYenE5PW Jn44kd9fmKDM/wD+SvH/AHivJ1547Jh5ATicnqM8g5Esmf8AmKBPIe8smf8AmK8hlICA/KnFeT2C okH/ALZ/7o/ESk4MriPuvIJMI6+/ZXhE5V7G1EzT8sz/ANyh1VNjmaQn/mK8XWjrwpxhyez8TMO8 0n/iKyFTKP8A20n/AIivF18JdZTjDk9v4ufHNRIP+8VkKyfAxUzffqPK8IeQj1PAThF3XtFZUY/9 amx/zlArKjxUzf8AiK8XWUB/YpwhyrYCsqe/4mU/dxR+NqsH/aJfphxWu9Q+yYkPtwnCJyr3trar PNVMf+8U/wAbVZz+Jlx/zFa4SfRP1Md04Q5V7/x9RkH15T/3ysm19QRzUT/+MrWh/Bx3T9Q+ycIc q2H46oH/AMdTY/5igV1T4qpf/EVr+vIwQE+vhOMOVe411RnP4iYn/nKf4+rJ4qpv/GVr+tBfnCcI vKtgK2px/wCszA/8xTFdU9jVz/8AjK1xkIR6meynCLzr3mrqM/8ArUx+7yj8ZPn/ANYl/wDGVrzJ 4KYkPsFeETlWx/G1GOaiY/8AfKRq6jP/AKxIB/zFa8vOe6YeSeFOEXlXv/HVAP8A61Lj6vKPxtUf /jmX/wARXg6/cAo68HsnCHOvd+Oqcf8ArMv6uKPxdQfzVMp/7x/6rwiRMyfonCJyr2/jKgHiolH/ AHig1lT/APLMuD/xleESH2S9Q88K8InKvcauoH/xzNz/AMRS/GVBIxUSfqSvD6hysg9OEOde78XP 1ZM8h+zikaqYn/fyH7uK8PWgP9wnCLyr3fiJ2j/fyY/5il+Km7OnlP8A3ivH6hS6ynCHN7RUSd/X kz/zFN1RORzUSZ/5l4etHWcjKnCJye38RIB/v5T/AN4pfiZj/wC1kx914/UPumHnPHIThF5PZ+Kl B+WV4z9UjUyu7zP/APEvGXnwkHnKvCHKvYJXEf7x4/VHqvz/AL1//iK8ok8I6yDx2V4xOVer1pO3 rSf+IpGZ4H+8eT/zFeYSZzlIuOfonGG3pbM7H5nj/vFN0hPdziPuvL18cd0dZI5TjDlXo9R2fle4 fqn6mez3fuvKHEI6jlOMOT09Z8l36lIEd8uH2K+PqHHjhL1D4TjDk9IeBgtJ+qXUPcg/decuKxLj 0pxOT1Nd9/3R14Pcj7FeYPP3T6+E4m3pa8nI6nEfUpepg8Y/ZfAPPlJzj4KcU29BkGOeQl1Ant2X wDufqgvPlOK7ejLT2+U/RI4PflefqKOog904nJ6S4YIGR+qWR7r4dZWOXe5TjDksCEAoQvC9BlJM /VLwgTlotbTmm03VOaSHOHSD9yt6Vy24ziNNv/52g/ut4TtL6RITkYCb3EDp8IA7LA9zhex5iTQh VAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhCEAhC EAhCEAhCEAhCEAhCEAhCEAhCEAhCECTSTQCSaEAl5TSQNCAEfdAFL7poKBZTQmUCR9EICAQmgIEm j6JFA0fVLCZQGU+wSCZQA7cJYwn3QgSMpoQCSflCAR4QUyihLKaSB5QjGUIBMcJBCAP0QhCAR4Qh AuyAmfqgIEDynlCPKAQhCACEIQAT8IQUCQmjCBJpFNAuyeeUIQCEHlMIEhBQe6AR3KEuUDR5RhPC Axyl57JpjghAiU+6RRjjhAkII+yeEAke6E0CQmhAh3TH7I/RHY8oEQmOyEIApZTRhAk/CWDlA9vK BoRyCgDIQLjPKf2TwgBAhyhBGOyeUCCSyIWPKKMIPPdPHHKAEQk/KZ7pBAcYR5R9kkDQn4SxygM9 0FLzyjygAg90/H1QgQ7dynhAQe/ZAIR9k/sgSPKEDugD3QjKEC8phCflAijKEIDKM8owmgXlB4Ca XlAICAhAkx2R3QgD/VGeEIHZA0sppIHnlCSaAykmUvKA8poQUBhJMd0IBJNCBJoKEB90Z9kJIGe+ UigpoDCXhBQUAnnI8JJ8fZAY9kYQkUDS7d0xwl37IDuhNI+EAhPwkUAhAWQHKBYRhGDnlPCAxj6I HJ5QhFPCMI8IAQID6I/ZMrHCCwKAjCYK+e9IKDlGfZHjlAlyG5JIsBaezpGrr/quN3PcBYo/rKP6 Lfj/ANky9IrJ+qxTIxhC9ryhCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIB CEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIBCEIEhNCAQhCAQhCASTSQNA5QkgaE d0IBCaSACMIATQCB3QUZQB7peU0IDuhGUIGjykEIppI8JjsgAhIpoAlCO6PKFATIQUs4wgOyY7pJ oBCEfZAFCaXZAIPdCaBeEx2Qf2QUXQIwkmhEA7oQkgaEihAJhJNAIR4QgEIyhAJ+2UhwjKARjCE/ CA7/AKo8oS89kDR3QhAFBCEZwgBwhAQEB3TSTygWOVl9EkIGsT3TxykUAn59kkzygWEeUdkAZ7IH 9UA57pIPdA8cIx5QP6peUAfoEIQEB+ieOEcoygaSMoPCACE8pZ90B4Szyn5SKDLuj6JBH1RTR2Qk UBlL38IQhQU+UkwiDhAQgoFlA7pnjCEBhAH6I8owgMcoPCM/RL6lAD+afZAKWfCBk8JDhA+6fsgO 4SQhA0gjwhA8oS7ICBoyl2QgaPCEIEPsn3RlId0DR5QjCAQkSn3KAQgpZQPPKSDygIGkhNAkJ4Qg AhJPwgYSKEEoEmgoBQCChH08IBMJDsjygCjHCEkDR3CP5IQHZBQjvhAk8JFM9kCCZRnhCACAjwgo ApgpYQEGSEk/CKEJFCBoHCSaASyjsEZQWB8oP0SHKYXz3pHlGe6EFBj5XF7onFmgHvP/AKFdr+64 bdR3/oykaDyZTkfounj/ANky9IxPBQm4fMsQvY8poQhAIQhAIQhAIQkUDQkhA0JJoBCSEDQkhA0J JoBCEIBCEIBCEkDQhJA0IQgEIQgEIQgEIQgEJJoBCEkDQgBJA0JIQNCSaAQkmgEIQgEISygaEkIB NATx4KDFNCAMhAI8e6Ed0CTCMIPCAQUBCAR3QjGUDQnhJAdks8ppIGgjhCECTxymhFLCPCMJohJp JoBAQEfZFB4S4TwkO6BhHlHZHdAE5QmQl+qGj+yEJFA8ozhIBPwgEIR3QGUAoQgecpI8IRdml4TS KIM8IQhAJpICAR4QhAIyj7J4KBIKfKCECT8ISQPKOyAg90AghIJ+UAmTlLt7I8oGEijKEAhAQgM5 TQOD9UHGEAgZRlBQCMoQgPoln6ISQZAoBSQgZOUJI7IH2BSyhId0GXhASRhA8oQkgPKYKRTGUB2Q SgpIGCg8pBBQPwgdkvCAEXbInhYoKQ7/AHQ2aEeE0QD2TH1QB/NBQB5CMpfdP7IDukPognCQ5QPH lMeyXZHhA8lJCCgMgIHfKXlHdAx3QUI8IAIP1QOyMIBHCMIH1QCM8oPdHlAIKSyQJCEZQHdCEFAF NJCAyhCEAj9kI7oGkjsEIDugd0JoBA5+yXdPKAR3QhAIQEkD4xhAQPqkgaCjKRQPCM8pIQNCEIBC SaAQhIoGjKEIBHHhCeOOUCRyEkIH5QhCBoSKEXZoCSaBhCEIEj90wlkoLAjCflYjumOV896TWJTK OwQI+FwW6ePwlEOx9R39F3mVwG6zsxUIx/icuni/2Zz9I5Pc8rFZeDwFivY8xoQhAIQhAIQhAL22 u21FyqY4KWN0kjzgNaOSvErBfDDbKasrq+aeBj3xMaWOI5Byioz1LtxetPUlNVVzYTDO5rB0PyWk 9shY6q28vOmqClq7jCwU9Rjocx2cEjOCtvvBeayu3BukFRMXRUdQ6GIAYw0HhT5trPQ7hbeRUN5Z 61TTYa8ubyCPyuHugrlFtpeX6aF9xEKE8kl2C0Zxk/RbuLZTUMkEc7XUnpyNDmu9UYIPZSlvpfKa xWOl0zaJBFNICKiHo4MThwf3C7HT1kF52doKD1Oh09O1vWXYI+Ydj7oiutz2c1FbqdtRLHCYi4N6 myZ5JwFptV7eXvS/pOudLiKXhsrDlufYnwVNpvlXp/VMmgat7q+k9WB9NUyHD42khxa73H1UyX6n tNxkFkugic6sY50cTuC7pxkt+oyqVS6+bd3mz6fhvVVEw0MoaQ5ruR1dsrGw7eXu/WOe6WmFlRBD kOY14L8j6KyO+tBHbNnamkiyWQPhY0kc4DlDPw+3Sso9eUtNTSltPVHomj7tcPfHumkl2iWeGSCR zJWFr2nBaRggr5Ka/iis1HataUstFC2I1cBklDRgOd1EZUL4wVFYJ4J7LZWq01t0nEFDTyTzHnpY MnC3h0FqJg+az1uf/nRQcigDJW1vNmr7Q9jLjSTUznjLRIwjP2Wua0YQZ01LLUytjiaXOccAALvq TaLVVTTRzQ2/qY9vUMuAK6n4bbLSXPVE342Fsohi62Z5w4Lo92b1q6HXLorBHUR0ttl/u3QMJbIc AkPA4I+iCAL1Zquz3GaiuED4KmI4cxw5WvEZ6sYVnZbLBvBcqU3CmltNypab/aPkHzOz3HnC5PSe 0EV61RfbPPWmM21/QJGtz1coqDugo9NwHYqYNLbTVV61fcrSZgKe3zGKWZo574BwuzGxtlnqHUtN qBpqgS0MLeQVdJVbOg+xKfpOHdpCmrT+y1wrdU1trrpBCylwXSN5y0/lOPrhdDHsfaquaSlodTUs ta0EiEYLgR7jOVBXiKlfIQGgkngAd1sLxp+42inppa+klgZUAuic8YDgFMW3m3lKzU89LeLhDR3W 3ztLqSYAGVp5Bb7gqUd79GUWobPQxG4UtukpRIYWyuDQ8kDgfshapqgDJXokiLZHNOMtJBx2OE42 4cD3Qem02erutU2nooXyzPOGtaMlb6u2/wBRUNK+oqbVUMijbl7unsPdT/sfYKCg2+n1Gyna+tZH K/LvPQCQPp2XDaV3qrYtVzv1Aw1FirHEPgx1GBp8t9x9EEbWvQ18udGyroLbPNTuOA9rcg4TuWhr 5bqR9RWWyojhb+Z5YcAKyWwtZDXV+poKGQuszKsyUrOwa1x8Dxwun0xDc5a/UlPqZhfbvVLacStA Bjyf5YTSbU7tOk7rd43ut9FNO1n5ixucLO7aNvVrpHVNbb6iGFvd7mHAUy2HWtwp5btpbTNljdXs nmbDVQOAd0B3BxjnCk7bumvFz05cqbXcQf1kNDZmAZaR/wBVTalD2FpTZH1FbK+QsgutZHG3DGTv Y0ewBK8sTMSccqK3tHoy9VEDJ4rfO+J46muDCQR7ry3bTdxtkIkrKOaFhOA57SBlWx2JqKq5bY5n cJJoBJFASMkYaekfvhei3W+fUe2twj1hTMdVdMuA5nSQQCWkfqgpY6Ig4wh8RaB5U02HZW8Xe2R1 rTFC1/ZshwV4tX7QXzT1CyskYyanLulxiOen7q6TaIfTJPATEZ9v/fU12PZK+3O2xVbfSjY/s15w VqtX7UXjTEdPUVrYzSyvEfqtdwwk+fYcqKjOlt1RVFwgikkIGcNbnheaSItfg9/qri7P7bt09SVE t0iilneAY3t5HSRyq/bs6Gr9J3IT1UbRTVkr/Rc0+xzj9irpNo4I5WccZcQFkWYIX2gcGuz9UVsY 9OXCRjXso5y13Id0HBXnuFpqqMNNRBJGD2LmkZVzdtLpZr5YrXBQiCeRtG0yENBLXDgg+xXB783K x3DStwoKX0Y7rQV0cToiAH4J7j3BCSbTar3puJ7L70tFLUvEcTC557ADJKlyk2W1HU0rKiKBjmyM D24dnIIyFy+n4a3SuuKVs9OG1VPUBj4pW5BBOCP2TRtx9Xa6ilI9eNzPbqGMryCNwwffsrj7z6Ff qXTFA2z0UQqmyCQ9LQD0lvZVPuVunttbLS1UTopondLmuGCCmjbzx2iplg9ZsMpZjId0nC8T4XAk YJ+qtp8PIpr7oWamr6Knf+EcYg/oGXNI8quzLHPdNR1NFQRFzjM9rWgdvmKsxtmy2S6cj6Z+wCRY QOVLf/Y5qYD/ANRJ+y4LUFlqrLXzUNwgdDURnBa4KaXbQhhPheqkopak4jY5xHOGjJQGAeOVKvw9 zwt1zFQ1VJFUwVrfTIeOWnuCE0ItnoJac4kY5me2RjK8phcD7qxvxOtt1vNDaqW3RRTPAqGzsGOM kFuP2UM6b01X3+rEFuhMr/oFdG3Memex7pGM5Unu2n1IyMk2+U9Iz2WrtOg7xdY6p9HSPf8AhiRI 3GCCFNG3B9B9imWHPZdZYdM117uT6KhpzJUMBJaBzx3XvpNDXaquM1EyjkNRDnqZjthNJtwojcR2 X0jhL/laMnPbC7+p221BBTySmglDWAuPy+FzthlFtv8AST1NO2aOGVrpInDhwzyEq7aaejkhwXNc 0EeQvMWEHHCtLvzpyywbdU90t9EynkfJG5haOelwPBVaYYQ+djf8zgFeN1v7ZmUtsnw8BjIHIWJa R4Um6+22rtK2SjudSWupqggAjwSMj+Sjws7+cKaaebBAzjgL7RU7pB8vJ+i+sbATgjglWM2j20t8 Nljv2oAz8HIwOHXwMHgHP3UNq3yUsjG8jB+oXyMZDcgZ91abU23ti1lpM3XSAa2ppy5r4x3JHdpC gau0vcKSlFTJTSNgceHkcJo5OSEZOOCso4XOcQ0ELpY9M3Cegkq4qWR8EfLnAcBSTshtuzUmLpWd LqOOQs6fdw5IKujaE5IXsJz3C+Jb9FNvxFaWt2nL/bWWuERR1FMXuA7ZDsKHHs4ITS7eTHKWF9+n Psl0YTQ+SCvsWhLpGE0bfJMDC+nRwjoz5UNvlhGF9ej3wmI/lQfFGMBfbpHhHThB8ccowvt05COk YwVdD5YQvsGD27I6R7JofEpAcr7loQGDyE0bfHCAvq5n3QGYHKht8sFPkr6FoJTEfCG3yCF9QxIs BKG3zIQV9Qz6Jlg8obfDzymQvt0JBnHIQfHz9019TGMoMZA7K6HxSX3azuUemFB8gE+nlfTo5WRZ wg+GB+qF9g3A7JdHOUHy90gvsWI9NB8vHCD2X2DOEFmfCD4gI7r7BiOjnhB8PCY7r7BvuEvTweEH yTAX0LP0R0fzQfP9UFfQs+iXRx9kVhhAHK+hbgZwsegnlBgRygjjK+ojQWFB8vKF9RGj08FEfM9k vK+nTwn0oPl5SX16Cjpyg+YCCDlfToR0IPkf2WS+nQl0nOEHzCCF9OjhIxoMMcIws+j91kW8IPn4 RhZ9GfdHRg9kGDkivoWeUdGeUHz9kz2+yzDPYIDEHz5KZX06MJennA5QfPlHYL6emQUixB8/qmvp 6ecZSLcnjKDBBWYac9kdHgBBgDwhfTo+iZZ9EHy8IwV9OnjlBbnnsgwxwgjlZdBOE+nKKwwjCzLc eEwEHySC+jmHPHKOk+yIwR4X06PCXT45QfMpr6GMlHSfPhB80eV9OhBaSeUHzTCz6MIDf1QYFC+g bhBZlB8kEr6BiyDMIPiBymQvoRk8plo8IPkAmR7LPp9kgz3ygwAyjBHdfQs+6XR9Sg+aF9Ojn6J9 GEHz+/CCs+nnwn0oPmhZ9BymWoPmjuV9AxHQMIPljCF9egZR0IPmjGF9OjCYbwrofIhAX06Pbugs TQ+Y7p/ovp08+EdCaHzSC+nRxwjp+iaGCR7r69P6Jhv1TRt8UYX16Cn0fXumjb44TyvqG4TDcpo2 +IQvt08pFpymjb5YOUukr79PCOgeyaNp5zhMHjhY55RlfOepkTlBWOUZQHlR7us757cB5Dz/AEUg /wCIKOt1SPXoAO4D/wCoXTxf7M5+nAnuUk3JL2PMEIQgEIQgEIQgFOPw06sttnvc9Bc5fQNYA2KR x+Xq9ioNX1iJGCDg5yCgmTePRFfbtwpquoANDdanrhnH5QXH8p+qm4VtBtVoOkkrGMdM/wCRpaP9 47AOD+iqhctXX6622G33G6VVTSwlro45HZ6SOxCyu+rb7ebdDQ3W51FXSwkGNkrs9OBjj9E0qym8 On4dcaNtmo7JE01DMOyeHOY7A6frgroK6zXL/sYbbaKOVlzZA0Na3hzXBwOQqoUms9RUdmNqprvV Mt57Qh/DfPHstvHuprVkbG/2grMMAaPmHb9uUROtHoWqjbR6k1BVPmvgnga5xAALc9OCPce61/xN V09tvmlamkmdDPEZnNe04IILVC1y3L1dcaQ01XfKqSFxDsZA5ByDkD3Wr1Jqy+albTG+18lWaYOE ZfjIzjPP6KxLNrL75TyVmyYqJ3dUsv4d7j7klR18P+jq6S8U1/e30qKF2WvdwHY74UZV2tNQV+nG 2OsuUs1tZ09MUmDjp7c9+Flp/Xmo7DaprZbLnLHQyhwMRAcB1DBxnsqSOy+Jy+0V61tTMoJhL+Dg MMuOwd1E4UO4X3me6RznyFznOOSSckr4kcKK2mnL9cdOXSG4WmodBVRHhw5BHkEeQpAG+2t//l+n /wD5dqitvsmRxj+aDrtc7hXzWdHSwX2WCRtM9z4zHEGHJAByR9lyDe/2TAz4RjJ7H7IJo+GjUFvt WsX09xmbD+LjMcbncN6vbKmSpn1PZN05oyxj9PXGVsvWWBwZxg8+FTeEFha5pIIOQR3BUlUW8Osa a0i3m4smpxEYf76IPd0kY798olWx6YItwI+noa99AcAYBd83dcrt9RTUm5WspKiJzG1M3XCXD87c 9wqxVG42pJK201r7i4VlsaWQTAYcWnw7/MPutzW706wrX08j62BssMolZIyENOR4+x8hBPm1rPS3 I1xFJ8sklX6rWnv0E9/stHU6o19Vaxrbba7dQCGOZ4hlnpyOpoPB6sqDa3c/UlXqyDUX4qKG5RME XVDGGNe0eHDyujZv5rAHqe+3vOc80+P6FXZd138dPuJNr+a8xwUguFHBHHUUsb+lk0XJHB9+eV1L rZZddyVdRR0dXYNUxNBbOQWHq88jhwVbbfuLqKg1XJf6etcayUkPa7JY5ueG4z2GePZdid/dVk5M Fs57n0Dn98qDX0cVzod4qKn1LNI+4x1DGPklOS5v+HB9lNHxA6TuerTZKSzxtfJGZnkOOB4VVr5e K273aS410731T3ZDy45bjsAfp4UkWrfXVNHaIaGQUdQ6JhjE8rSZC3GO+e+PKsZsRlqG01dju9Tb rlEYqund0vYfBXgjOHYxyey9t3r6m618tZWyvnqZTlz3uJJ/UrwkHq4J4/ko2t1sbVQXfaKrtlvl ZJXMimjdDn5gXNIHHsVC+jdq7tfbzLRVDHUjYHlkr3t/KVx+idVXTSF6juNomLJWHD2E/LI3yCFJ lT8QN8nhqWfwy3RPmYQJIupr2kjh2fOEiJJ+Hey1Fkq9R0NU354ZxF1Ds7pOMhdPoq6T6vpNUWW7 5cymqpKZsjTh3QTx+ygPSW+l/sVIYJqOgrnulMj5pQWyOJOeSF4tGbv3XTN7u9bBSU08VxlMz4ZC fkdnPBC1vrSTHvb7VGjtUaWuMt8srKlkFPM9sdVGcuLc4OR5BU77NXS5ap0pcBqQmod1dHzs6cjB UGaV3ovdhNwhfTU9dQVMrpWU9Q44iLjkgH2W0uW/dyntFRSW6z0ltnlGBUQSklp9wMLOlQ3fGNZe K1reGtneB+5Xlh/3mfK+lRI6oqZJJD1Pe4vc76k8rFoLHZbwU0q4GwzZKbaqpeMskYJZGn2IaSCv fbq9+vNppayqcaeqa1xc+Py6MHn9VD2nt9ai3aYbaZrFTSOFO6B00cxYXZaQHFvSRlavQm7tRpvS Fbp+ot7KqGUSCKQSFhZ1gg54OcEpOrEvpMm8MlRFtHbX0D5IpSaf5onFrsdPPIXv0OZXbKukrHOk m9KUuMhyc+O6hzSe91VbtOR2i/WmG8MhIET5JOg9I7A8HOFnqnfGe5adfbLNam2r1MtcWyB4LSME YwFWak7ft9RDt1ZX0EkkT/Xj6nREg49PnkfVZXB0tX8ONbJXudLN+Be4ukOTkEYPKjfTu+QZpumt eprKLo+nOGzdYHU0DAyCO/1Xn1/vNHfNJuslltj7dBKHMmDpA4OYQOAB27Ka7aST8M1dUV2k65tV USTCGUMYHuJ6WgdgoH3Ko9RyGSpuZrJbXHUPMLpHEsZk449uML6bSbkVeg7nMTG6pttQMTU+cHI7 OB910m6O78GptLCyWe3mjglJ/Eerh2RkFvT7HOVqM672hRzcexQ0fMPussDKeMYx391ltYn4UWPF fdHEHpMQwtPebNDf9/rnbKl3TDPVnn/u5Xw2Z3UtWjrNLSXO2zOqA8uZPBg9bT4dn2Wp3B1/RV2u qHU+lKeaiq4sOmbMAQ54Pfg+QtSs1ZaKe2WLUtp0+PxYqZIA6Jwf/d4GRg8/RQx8QVPHFuzZ3xsa 0yU8Tn4Hd3qEZWyq979O3KCGvntVXDfoYcMlDWuY145xnOcE/wBVyO6u5Vl1hSWmuo6CeC+UrmGV z8dLmjktB+6Cd9yr7W6doNMVVAR89ayGVp/K9hYMgqNviisVvgpLReYYGx1lTMYpHNGA4BuRn6rY T716Pu1roIrvbq574WteQGAhrwADjlRxvfuZT60FHQWuJ4t1K4StfI3peXluCMe3ZJS+0qfC6wt0 jdDjGZwR9sLjvh+gim3PuomY1xa2UgEZweo8r3bWbvaW03pOlo6ylqoq1o6JxGzLXkdnA/ULhI9f 0WmN1J79pWF77VKR1wTDpJa784Ht9EwvHC4/aZTecyWF1HrqwWfUc9BWVtyjrYnN6oooi5pyARgh Qb8R1/tOoLhap7ZHJHUNY9s/qRFhIyOk/Vd9U7m7b192F2qaesFcSHEmHOCAFEe9WtqPWV+hfbqS OKmpgWslDel8jTzhw+iRUbMJJPPbypP+H1hduRa3Y/K4n+SjNp47KTtiNU2LTGoJ59QslbloME0b erocPBH1Wa07v4mrfPcdb2eCmYXvdRYAA93ldL8PWmp7FV3mmudMGVTPSewkZOD7Feq4bobfVt4p rhUTTyVMLfTY8wH8uc45+60tTvPZaLc2OopHOnslVSRwzShha6N7ScHHnCtZSA7XdgpbxLTyXmd0 8b3NdAYSQMHkZA5wvtoWrtVbfNQz2QtNPIYXOAbj5yD1cFcNT6z2wo71Lco6p76p7nOPXC4jJ7+M KPKXd5tn3Nqbra6QMstQGxVFM08SdJI9Qex57KpfTpdhaOWPdC7yyRkMAnaMjscqaLHTU/8AaHUV SY2iWOZrQ8DkD08lR7WbpaIs1HX3SySMlr5wHinDC1xceDz/APT2XJ7V7zQx3i5w6seGQVrvUZUt BPQQMdLgO/HlLd3aYyyaStRa5066V7ZNQR1TA0tfG6LJ9vZVb3B/ASbiXU2YtNA+cGHpGBjAz/PK nSz6h2vs9RPVU1wglkex2WSMJ6j38j3UEi+2iv3ONzqaY0tmmqw50TTn02Hgn/VS9zTU9p336H/1 G7cP/wBW/wDKqsQNLp2NYPnJAH3VrNwNU6G1JoiptTb9CDFDmDggl7AekcjyqowyujljlbwWkOGV 03PxY4/MYwxszyv2lXcu8asqNHWy16jgjbRxFhilEeHEtbgZPnhRI7HVjPKl3c3dGm1lom2WsUMk FbTvY6SQuBa4huDjyFEbh82VzdDjHzN+iuJSvZHsDSOf80baWNzuM8CUE/yVOmHBKn3ZLcyiFpfp PV72C3OaWwVD+zR36XfT2T52lTNt3Bb43311n6PwM8rJWBnYZYcri9przBq60XLS98o2PFMHiGcN 7sBPB+oT1HuNpvRemBBpSppqyqkxGPTOQCD3d7cEryaI1bpDS2hm3WnrIZbk+Mukgaf70PdkEYPg EptG43Eu1u250fHQUdGyapqoS2MOZlp7tcT7cHKhnYe73Gi1pbrdTVUrKKpqAZYgflccd8KTK7VO l9ztBStu1TBbrzSRuIZM8N+YAnLSe4OOy5fYWHSwpIbrX3SnpLtS1JzHNIG5b3BGf1Swj6/FgD/a Gy+AKR//AJyq/uHP3Vst4KbSmrbfNV/x+g/HUtK8QsbM09RBLsd1U5xyQrkY7nt8nswUdPZfQ9+y WOVG2HTxxhHTgfVfUhIgd1Rh0owFkjwoMelLnC+gQQibYNHKZA9lkAgobYYx90wFlgYyn9lRj0hL Cz7cJFQ2xDUADys8YCCMFDbEgZz3Sxn7LPyjHCKwDQmBgrMBLGQUGPSMoIGeyywmEGOPKOnysgmg wxlMN+iyxygBBgW8oDR2WeEYx2QYFv7IDQs8e/dGFBjhBb7rMcJeUGPSD2QWrMhHhB8+n6J9PZZk IQYY4RjPHlZgDKEGHThAbgrPHKCgwLR4QW4+6z7I4H3QYBvHZIMyfovojsgwLUsL6d0cdigw6QUg 1fRGOEGBaEukL6YQUHz6QsunHsssfsnjKD5dP0R0+6+iAOEGHSCkW/RZpoMOgEdki0Dxgr6AYR5U Tb5dOe6C3hfTCMZV0Pn0DHbum1uB2WYCX7qDANGfZHSMrMhPH6ou2HSMcd0i0L6AIIBV0m3zDeEB gHZZgcIwmlYFuCmAsx3SLU0MOlMBZ9JyghBgBlHSFkByh3bhQYdICOkLMD3Qg+YbwmAAs0DnKDBw S6cFfQBHlBgR5R0jCzKWB+qDDA9kAfRZnjCeOUGHSjpHZZ4QAqPnjHZBbz9FmeCjsO6DDpwUY5+q yTKDEjlLAz2WZGeUkCxgpO9z4WaEGB5x5QQs0YQYFqOlZkICDHHHhLAzhZ4QFRj089kg0LNGEGBZ 9UdKy7J9ygw6QjGVk7hHhE2QaEED2WRCR4VVj0juAn0hA4/VMhDbEBABJz2WYSxkoFhAA7J45QgW AEYwSeU8ZKMcoFjn2QfoFkUBqDDAx7Ix9V9AEsIm2OEYHhM4whU2RCMdlljKMIbYowssIwgWOEEZ TP1QqDwjHCMJ9kGKCFkf5ox+qaGPlHR9U0fomhOGUurnuvh6g+yQkAHfK+Tt7dPT1YR1Ly+qn6n1 TZp6C7hRvui8Gtox3+Qn+a750nI9lHO5Duq40v0Yf6rp4bvJjyenHH7IQhe15ghCEAhCEAhCEAuw 0Ho+t1TcY6WjjJYT88mOAuPHcK1fwqxNNlubnNBPWzHHZRUf642potN1tqpm3qOSWqkDJYXDEkYP Z2PIWW5e0EukqW31NHVOrIKl3QcMwWnGQuO3AuFVWa+vD55pJHR1cjIy5xJa0OOAPoFa3amuOp9A UkV4pH+pB0j+9GerH5XAlNn9QxUbK01FpOnvdXdHRMPQZ2ln5A5wBP6ZW/m2EtEFvbWzaiZHSOAI meAG4Pblff4jNUPjqKHTtI2ogcxxfN4jlYQMAe+CFKcVuobnt3baG5vYylljhDus4DjkYbn6ptEO 3HYKCnhpZ4byJYJ5WRh7Wf5jgELldwtnK/Ss0Mschq7bIekztbgxuz2cFI9qvNZaNz59FQuMlliq 45KcS5LosAHpB9slS7drpa3Xlmn7kWerXROkjjkx0yAHBA+qsKqtuLtK/Smk6a+MrmzwyFgewtwW 9QyEtJbSHVmjpbrY7nFPXRg9VGRhwI8fqpj+JaNtPtW2CMYYypiYAeeADhRR8NFVPDruOGOR7YpW EPaDwfutfG0xu0O3Shnt9ZLTVcboponFr2PGC0heMhTT8VNPBBuJA6GJjHTUbHydIx1OyeSoXPZK sIJuaSRhdDo/Stx1VXmjtEbJZw3qLS4Dhdr/ANiGsB2twP16gmhFAPus2c8dl0Ws9HXnSNRBHe6N 9P6wJjcfyux3wVzzSeofsgkPbDbqfXMtTFTVLIDA3qy8ZW2pdnr5JqaWzyt9N0Z/32D0lp7O+y7b 4Txmrup/+ZgKeae92upr5II52Gshn/CvaPzNd4BHsolUt3K0PWaIvMdvrZGS+rH6rJGdnDOP9Fxp j6T+UhWw3dstPed0rBT3Cjnq6Q0nTI2H8w+Y8r63DZjTN2t1TFaoqyjrg3MTp2kDPjuhtUrpJxwg tcQcN4U0bV6T0zdb/dNOanc+C7xSOjge12GOLTggfVdhp7Yingv1ZHeX+pQRn5HNOC4HsiK1RQl7 hkEZ8KQ75tXdrVomPUpkikoixsjg08tDjgLzapt2nbRuIaS31EtTZGPYJHAYcw9nN/RT7udam0Oy lS213OWa2tZG5kcrASWFw4z3RpUYsJPY5ymIj05IIVidotrLHqjSTrjcnysmEjmktPAAXUHYW0vo 6yH8TI2oJJgk7jp/w5VRU0sOfYoMbscAZVkbbsrQTaOuVRXSSRXSj9YHHLcsGR+61un9qLVdNrpb /wDiJY61kUkoHdvyjOFdfSWydoAETs/lQYiHg4wrL7fbOWTUOkKO51VRNHNUZzjsF6LpsDTusFT+ EqXfxRhd6YP5XY7fuo16VfHc8chEfzOx7r03KkloK+ekqGlk8Ejo3t9iDgrzs4cCibSvYtm7/d7R TV9IyOSCdge0h3heXVO0uodP2p9fUUhdTs/OWc9I91O3wzVEk2g3xzSOfGyUhrSeGg57Lp9NU9Za dN3NmrJuqJz3Brp3Zb0HIAyf0SUqmunNNV18r2UlBCXyOOO3AXzv+nK+yXWSguELoamI4LSO/wBl bPS9jteidJy3ltO6olkb1t9NnUQXZ6ePocLy6psVLuPocXl9IaK90kbn5e3GS0ZIPuDjhGbUB2Ha fUV5oI6ykpC6J3bJwvFq/bm/6Xo21dypHMpiekvHIB+qsjpe+DW+2/paSrv4feqaNrZIxgOa5o/o fdaO8auNo0TX2DcOGqdcpoZfRndH1sky35efBBSG1f8ARmibrqz8T/CYfW9DHXzjGey++pdvr3p5 9L/E6N0UdTJ6UbyeC72XX/DPV1MGvooI5XsiniLZWA8Px2z9lvvidvVcNU0tpFQ/8C2njqWxeBJk jqHsrBxzNnNUBrXfgXYIyDlcRqWwV9guMlHcoHwzN5w4YyPcK3kF7rqfZAXds7jWwUQkbIeTlpGM +653de30mrdnm6lq6dkdyhpRO17PPYEfblXj1L9m9KlBpcT0jKRbxghSjsTabJetWTUF+9MMkhcY g9waC4eOfK53dyy0endeXG3W15dSsDXs57BwzhSrLtxrR9cL7QwukcGtySeF8QD2XfbNWqnvOubf RVrcwyOPUAorC1bd36529tXSUUroTwHY7rmblQz0VRJBUROjmjPS5jhyCrmaxvVbpFtLQ2G3CWCB kc8pAyAzqLXAj6gd1zu7egLXqGptVyg9Ojqa+RsTiSAHFwyP1Sd9Jeu6qN0lZNGSB/JS3qDZ67Wv UEFAIxLHPzHK0ZH1/VefcDa+s0i22zmRk8VbL6LQ3u1xHAVRyli0feL1TmWgo5JY28EgLSXq21Nq rJKathfFMw8seMFXIsdJU6Y2r9a30rRdIKfqLOn85aQcH9MqEN+tRaf1VYrHdrWGR3Z0j46uHs9g AHcffsU11s3q6QpzzyjJ8oaME/ugo0bS7I5JwhxyUieEgcKBnnCGnByEE4QDlBk5znDIJygPJ7jC xzgpk8ceUGfUc5yVjnnKxzgJ590GRJI5JQx3fwQsSUgefZB9XyOx3JXyRj3KZVH09Q9HTk4WBPkp IzkoGSkRkIKSgA3nKyY/pd3IKSO+EH1MriOXH6JCQgYJOFgMgJgoMxK4cDJCTHuGef0XzP6oHdUf Z0ziCMnGOy+JKZKMKDEIIwmf5IPIQIfsmgDCCgEY7poPZAh3TSWSDHCEykUAgJo7oFhPkJ/ZAQJC fhAQLGCjBHZMoQHjKPCOwTQJGOEwEHsgBx3RhDRyme6BIPZPhCBIzwnhHdAvKFkBwlhAJDsmg/VN Gx90H6J4HhMAJo2xwjCfCaaGKEwE8JoIdkeU/KWOU0BIjzlZY4RgJoY44T8IwjCaCwn3Twl2UCSw skkAjCeEIF5TQUIFhHhMoQ2XhARhMBAkYWSXlAiCPohM8pIDyglHdGOUCTQeChAgO5Qml4QGOEJ4 RjnCGyQjCeCUNkghMDhGOENkUcJpfdAsJ490J4Q2xwgBNBRSIJSIysxykfdBiCgLIAII5QJA9kyh Aj3SATQgEv0WSSBITQAgQRhM8JK6AAgpjkIxwmgkH+aaSaAOfCE/CPKaC8cI+6f2RjwUCRhGEFAA cI7EoH0QO6IDyhPA4QVRiQjymU8cJoGeMELHCyA5SKGiKAOPCYQgSCsvCMobYoKyz5Sx9UNgJjuU gOVkgxKaD3QgXnskRynhGfotBJgox/JGEBygdkY5TKBYygDCY/qhAvKyPbGUJKgQEAIx+6BEfdGD 9VnnCXUglnr47oEi8+SDgIzntlfF29+no6+wCDIc4GMLz+UE5KbNPqJD6jcFR9uA7quNOAOAw/vl d1/iUf65dm6Rt9mf6rt/j/7Ofl9ObKEFC9zyhCEIBCEIBCEIBTr8Om4dBpyuktd4IipqwjoqM8Md 4Dvp9VBS+sTThBOm5ugorLrykrJapj7NeKrqZUBw+VzjlwP791MeudVw7aaUtENLGKj1XenHJkEY bgnPvkKm09bVTwxxVE8skbPyte8kN+wPZfWoraypgiiqaqaWOP8AIx7y4N+wJ4QW23Ss9Jr7Rlmv tDNFFIxzSwkjBDyAWl30K6jVemKu77atslM5raoMiAcHYGWuByCqRx11a2jNK2pnFNnJi9R3R7/l zjuvWy+XiNgbHca0MHAAneB/VBb6h0VQ6ejtNwq3GS5tqomvqZXZcc8dJPlcD8SdYaTXemJ2ymIM jcRIDjB6x5Vfp73dp4TFNca18ZId0uneRkcg915q6urK8t/HVM0/Rw0yvLyAfurEq1fxGTCfaakk 6w/rngJcDnPB5yue+H3R7LdSN1XW1MbKcNJaQchoHfqPjCrxNdbhNRNo5qypkpW46YnyktGO2ATh Kku9yoqOSmpa6qhpZAQ+JkhDXZ78dlf4kmvTufiB1PQao1x+Jtjy+GnhFMX5yHFrjyD5HKjHg91m /J5XzB9lGnttFzrbTWx1lsqpaapj/LJE7BC6gbo6y/8A8huP6ScLi0sfZXY3+pNV3zUkVPHfLjPW tgc50YlOeknGf6BaIH5gl37YR5HOEFk/hMc11TdmtIL+hvHlLTlR/wDlH17HOwX1j8jPcgDCgOwX m52GsNVaKyekmLelzonEEj2X2ferjJef4saycXHr9X8QHEP6vfK1MuMsZuO7KvIKuh/7RXUtQ6L8 WaNjomu/MQHHOF89KVF4Zf7vBe5JTA+cuoRJjBYD/h/RUurtXX6tudLc6m61MlwpRiKcv+do9sr3 1G5GrqqSGSov1bI6B/qRlz/yO9xwsKlW0beXOt3YutXOx0EMFa6o6j5Bdlv7qadUPpNU2i96bt9d ELn+GblnVy3PY/uFURu5WrW3aS5x3upbVyxtikdkYe1vYEYxwtNQ6lvFvvxvFFXywXFxc4ysOCc9 xjtj6IPVPp+402rjZaqBza8S9BjPck9j+qtPr601cux89BHC91VHTR9UYGSOlwJ/kqkXzUl3vN8F 3uFbJJcmhuJx8rh09u3ldazePW3oek69SOBb0kOY0kjGOeEnVLNzSwGwrmnaqsLT/wDJz9vlK6zS 9ZFWzWaaCZkrP4X0uc12ec+fqqeac13qPT9JVUlquT4aWpJMkRAc3JHJGe36LzaZ1ffNMVjqiz18 lO9wILe7SD/wnhWC6VG9tZaNV08Dmvm9aoYWNOSCWYA/Vc7oq2VFPs5V2uaNza1kE7DEfzAlvHH1 VX7ZuLqa3ahrL1R3F0dbW/784Ba/6lvbK2Td4NZMuwuIugFQY/Sd/dN6XNzkZHY4Vl12zljLNLH6 H/2LZgBx9N0MUgcTwWkEf0XU2Oq/FX+okZL6kTqGmc0g5BODkqn7N09Ui3XGgfXMfR1xe6WMxjAL /wA2PZeLR+4WotKSudarg4RloYWSjrbgdhg9lmTTWV5NbuJJ163vr+2a2U/+6K0ERHWMjnIXqu1Z LcblU1tRgy1EjpX9IwMuOSvKBn7q33tJ1FyPh1oZqLQkjKhhYZXF7QeMtIOFXbUOptQMu9dba651 zoWzOa6CSV3Tw7jgr3ab3o1XYbRT26nqKeSCAdDDLCHOx4Ge/C4zV2oavU19qLvXtiZVTBof6Tel pxxn7qepo93a3uqdSVOldqKW6UTYpJo4IQGyt6mnPuF7ND6kn1NtxVXWsigimdFM1zYW4bgMPhVZ uW6F9ueh/wCzNd+HlpA1jRKW4kw05HK+ui90r5pewVdnpW089FUBwxK05Z1NwcELe5xk+WON3alC 87e12lbJR6k0fcallTKxolZESCWuH88LvbvQv1fs7JNqSAG409NJIJOnDg9jcg/qoC0fvNqTTVnF rj/C1lMw5j/EtLiwe3fsvrqferUWoLPJb5GUlIx55fStLCQRgg89iFj521ZudNp8NVPLLrmCqawm FjCHOxwCQth8TFLNLuLRlrHdMlFHG047u6jwo/233DumhJ6n+HRU9RDUAB8UwOAR2II7LZ7gbrXL WEFC2qoaSmmo5fVimiyXA+3PhanR8rDtt882xZt/Q4TPpPS6cc5LgF4dfx/wXYKroKxzY6htF6Qa TgucCO3uoupPiGvUVDFDJara8hoa4nqAcR5wFwm4+4d01xVRvremCmjHyU0biWtdjBPPPKcrqT6L O7/Xr2d0hFrW/VFFJU+g6OL1Wkdzjuuf3HsUum9YV1qqZfVfTkDrz+YEZC1tgvdysFyZX2erlpKp gIEkbsHB7hY6gvFbfrpJcbpO6erlAD5HDk4GAlu1k01oOCpA2RuFPbtx7TNVSNiiMnSXOOACeFwO MhZNy0gjgjkFSqu5ruquNJqml/B0Jq6SvonUruk9nZcQc/qtLvtTTT6BtVJTF34ttRBhrD8zSG9/ pyoo0VvzcrLZae33ahjun4cj0pZJC1waOwJwVoavdi6VOuodQ1EMc0MTiGUkhy0Rk/lz7/XCYZXG 7jOc5dVa7Rn4yTTNp/jTvUr4x0ue/hxwBz98Kru81xvlRr+eK4OkidA8NpmtHSOkE9LgPf6r76z3 pvN4utDV2hptkVKWvZCH9Y6gMEk4HBHGF5dyd1I9YR2eoFnhprpQyCR8/X1CTGOMY7Z+qEWFrb5c qXZx14Ds3OKjEhLm/mcMA5Cpbc6h9TXTzPAzI8vPSMDJOeFYSD4grdNavwVdpwmN8fRIxsw6Tkc4 BHZV4rZGS1VRJC0sifI5zGn/AAtJ4C1v9dHHvbz5SWWM9lieCstABPCAjCBOCOyywjzhAEJH3WQC RCDEc9+U8c8p4RhUY4TAwsi3hYlQIkp90fVGUB5QAmg90CQAhB7IBATPZA7oBCROCmqDv3R5TQUA Ej3TCECOUdin2SKgO6EJoAJpFA7IABCfhHhAkBByhAI8oCEDQhCAwhCEAnlCSBoCEeUDQkUIAf1W WEgg90AhCEDwl2KChAZQgIAQCZR2KEAE/CWUBA/KEBPwgSaXhNAI4S8poEUFNLCATykgoBHKEZHl KF5QRyn+iSgEBHHGE/2QAQeyEd1QkBMcoUCymDhCXugCgozlCA8coQhABCB/VCAISwEyhAiEdwmg ewQLsgo7J8YQJHZCPKBhLCMoAVAgp90YUCHdCZS8ZQAQQgc9kIAcFB5CMpEoBCE0CSTQO6oEYwgo HKA7JJoKAQhCBJEfzWXCB/NAgMI8JoHdAYOEsfsm5yAgSO6fZY/yQMJlHlJAYQU/CECA90cZQfcI IVAkeyEIHyQhHKB9UCR2Tz7JIBNA7FAx7oF3CY5S4wm36oBLyme/CSBhB5KSyHCBAJHCecJKg7oR 90DvhUMoAQn4QLH0QQg9+UE8JoGPCfhY/qmUAEZQjyqGEdPKQTygRzlHP0QQllVEogc5T8pj6I7L 4T6JFGEJgKjHAJ9go91yP/S7ef8A2Y/qVIQPzd8KPdb/APxXaPaMc/qV6P8AH/2cvL6c6QhBQva8 oQhCAQhCAQhCAaMuA91Ke0m3FRq+tbLK0st8Z/vH+/0UWxnDwVb74Xsf2MrSR/7X/RFR3rjRuirR q6y22hrJOqWQNrI3PyGNOMHq7e62e6Wz1LaJLVUaaZPPS1L+iRv5g3t0nP1UNXZ8smpq0hxLjUvx k5/xHCuhtbNXVmiKFl6pmslja0N8h7e7T91PlEYX/ajSti01RXKuNTE4OiFRH1DJDnAHH2W6u+0u gbVaW3Otmq46J3TiQZP5u3C5T4hbxW1OsLbbaikMEFK4ujmDjidriPH0IU31ptTdMWpl9fGyjcYG gyY6Ov8Awg/RURvU7L6TkbbKqhqaiWkqpGsBDgQQ7yCuQ3E2WbY6+mqrUZZ7Q97WSg8uiOe5+i6H R9xrKXeCv0/TSkWFla6WnhHLGY7dJ9uT2UqXLVFtpdXt01cixklZTiSEv/LISSC0/XhBXrerbC16 R0vb7ta5pi6WVsb2P57tzkLLRu2Ng1xoSSpsNe9l+ib/AHkEh4Dvt7H3XffFQ3o0DQNAAArAAP8A uqP/AIXi/wDtk8AkNMLsha8n6yVjDLlv+IXvtqqrPcp6G4QvgqYXdL2OGMf+8tcOyl/4oWNbuZIW gfNSRE48nBUQAjARqXcMDHglMtdjhdltvo1+tLlJQ09bT087W9YbKcdQ+ikc/DzeyT01tH9+pFQG 0fdZMbk5wuw3I0JctC11PT3IxvbUNLo5Izlrsdx91x7Oe3AQSjs/t27WtbJ6khZTQkCQt789lJ8O y2lKq4S26k1HG6vjJa6Hu5pHghRPs9rur0RexO2Mz26bAqIh3x7j6hWBbY7Tqa7yat29usTLw0CY wOAIc8+HjxlRK4bT2xTKuuudFcqx0M9KR0FreHtd2cvDYNjqupv1VRXR5gghOPVaMhwPYqY9rrrd b3V3mfUEDILlGWU8kbG9I+U8HH6rdWXV1pvFf+DopmurGySQzR5HXGWe49is26huKk620XBpXcBl irawfhT6bzOG9mO84+ik+47C2xtldWw32NsTo+tkz+GHI4yVyfxIO6t1ZPpSQj+RUt6+cW/D1MBx /scf/mC6THvTNynHcU/qYzFUSxOcCWOLCQcg4OMhJgGQfZYzfmJ90m/4fp3UbTdtXtVRa0sBrY7o xlQxxbJDj5mey6sfD/T1Bljp7zC+Rhw5o5LT9QsPhPz1Xb/kauq3RP8AYijqNZWScG4GvDZo+rMc rXHljh7jCRmqz3XT0ls1bU2SoeDJT1H4dzh274yux3S2rn0bYaO7Mqmz087hG4AYIJGQvBp+/UOo N0jdL7SH8NcKkuliidnoLvIPnCl/4l7eKPQNvFPV1D6YVDWtjlIcMdORjyFcZyukyy4xAu3WnItU akhtUtVHTGUHpc/sSPH3XT7s7W1WhaWjq31DJ6aokMQ6RyHAZXLbeE/2vteOD+IZz+qsH8Vb+nSV jB7GrJ/9wFMO+lyvHSv+idI1mqboyjpGn3c7Geke6+OvdK1OkdR1Fqq3NfLG0Oa5vYtPZWM+Hyo0 vVUNO+1iWK9xxFtRG4cfUg+xWn+IKLSdXLWh9TIzVELYy2LoPS5vtn7KTvevgyurJ9q1CJzgMNJK HROx8wI91azR+0dhj0vBV3iOWWWVrZMxN6jh3jHdfPV2z1lrNPVFXp9srKumaZPTlaW9bQMkc/QK xFVmwuOMA4Q5jmDtj7q1Omtr9L6h05artQmUNkDRO1xxg9nfsVq9ydnrS/S1XcdLyudPRF5ka48O DR8w+4VN9qzEeTjqXqtsQqKyGEuDQ9wbkngcryk55HOV96Q4nae/Kip2i2CukkMckc8T2vaHAg+C uQ3D2svGkaOOsqo/UpXHpL2f4D9VZbSFJUXXZ+jpIZnNqZqTojeXcg8Y5Xy1XQiPbH+B3eoDq6qj NPG6Q5L35B7++ESqVek8HGFiY3H/AAkFWvj2a05RUFObtO6Gdww7gkEjv2XNa02Xp4HUNXYZxLRz yNjeHf4STgH90XaunpO9isRGSTkK1FRspp+Glgpai4Np7nOw+mx5AL3gdh78rid3dtLVpTStPXQ1 rGXJvT10zncyAnBLffBVk2m9e3BaA0DX6x/GMt/T1QNBOfOVy15tlRabpVW+qZ0VFO8xvb7EKy3w 126mdZJ663VrG3AOMdRC4ZAH+EqMr3p+bU29F1tsj4xUS1jw4t4BIA7JO1qLAx3GGklZRsc53QWq 0NRsvpqi9JlddI6aV7QQ2Vwb/VctetqKLTusrdFcq1sdlriWxVDuAJMZDSfqoIyZoi7TaanvTICa SABzz5DT5XJuY7t3V6jp+3x7fy2d1RE2jlhMTqgEdPSSMHKrp/2Zio3ImsNFUR1FOyNlR6sbgR0O +3kYTaIfMbwMgHhYhhPvlWldsXZmy+m65xsf/lc8Bx/RcnT7QR0uu/4Hc6gRQVEbpKSU8CXHdo+q uxA5jd5aeF88Eu9lZyj2HgJqGVVaGFspYwnjLT2UKbk6MqtGagfRVYJYfmikxw9ue6ErkRE/o6sc LAA55Vidu9Iab1JtBWVE3QLnA2YudkdTS0FzeFXfOTnt5UaC2dots1yqY4aWMvkecAAZWtaMnurJ fDBYaGso664TxNfPTyNDMjjBCpepuosvW2t+tVufW1NC8Qx/mc0ZwPdcPLCWnlXbsmoqu8amdbLh bcWispyIXOGQXsJD+fIIx9lGV62dpLtqi9UloqWRPga2ZsR7gPBIGPbKesrj9MTLclnyra5hA7Zw vvR0r55WtY0lzjgN8qX9LbPXC6V9TTVgNOIXOa5xHGQjQ1ltGld0ay0armZG2BuYpnD5ScZH7hL1 NtSuB1Dou7We1w11bSOjp5cYf9+2VyR4OFcf4gjA7aapdThhhc6J0RA7Dq4x+ip1K3Erj4WuP6zL 7Yxz3bPpgf5JBMpFYbZI8JA+EyUUIQEEIAH38ox+yWE0DICSaCqBCQTA7oAJpIQBQg9ksIBZJDj9 U1AJDsmkgaEvPCaAPKSaQCB/RCCjHCAH1R5T8JfdA0IR4QBQnlJAIQhA0IzhCACPqjyhAIx7IPKB 24QCEIQMIRhCAQhBQA4R4R3QgEwUkIGgBAKaA7FCEFAeEeEdkIDGEk1igeUghAUDST8oPdAkBMo+ yAR4QgqgzgIHZL7poEjugoUB5QhHhAIQhAYQhBQCEY47IQBQEDhCAPjuke6aXZAygIQrQEZCWOUy keygAmeUvt2TQIo9kHwhUCPCMIQASxlMdkj3QNCQQgEvKZQgChBPKCgPKEfzSQNIBGE0AkmhAIQl 2QB/mgcBH1R3+qAPbyjshBQHnhHZCaBZwgIPbCOx4QNLHPKAjyqDCCOEJoMUIKO6AR4QhA0gED7I 84QHcphIJjHKBIT8pEIBGUeU1QihHfwgqgzko8oQeTlAFMH6ICSAHCfcpf6phAeQn3bwkPomT7Kh J8YSymOUCBITGSgDn6oHdALHpWXlCCUglgpoXxI+gWELJIDhB8znqA+qjzW5zejz2YApFPjhRxrQ j+OPP/A3+i9H+P8A7OXl9NAmjHGUL2vKEIQgEIQgEIQgFNewe6MGk6l1svIAtVU4ZlHeJ3bJ+ihR eiFhLfOEE5awsWlrNuJa6+mutJVWK5TlzwyUOMJyCerHYc91JW6O5tNpKhstPpmrpKmGRxBfFIHl jWkHBx4IKqUGnGMZwsgx2OQiVbfcCfSut7BZbtLeaKnqI5IwHeqPlDiMgjuACul1hS2TVGj4bM6+ 21rGOjcX/iG4cG/qqStjfjDQen2X0DJOwaU0Loxt0np6Oxilrbc10NU1vrCZpPzDBBOeyizfu9UT N0bHVxVcMtNFBH1SxvDmtw8k8hQF0y4wWfyXzc17uHDt2VNrP/Enc6K4bfWh1HVwVDTUNcfTkDuO jvwjZSh0/pnSx1NPcoJH+mS/oeC5g8gt7qsB6g3pOce3hYt62NI7A+PdW9ySpjNb/rrd4dWxax1h UXOli9KEMbC3Jz1BvHV+vsuHIz74Wbxl3OMoPfKNRlTzS08rZIJHxyDs5riCP1WwF+urfy3GsA+k 7sf1WsKPKD01txq68MFZUzTBmen1Hl3TnvjK8zch3AzlHn6Jt5P1QTr8N0+mautrLTqCKnfUVGPQ 9cDDvcA+6lbQu21ZpfX1TcqWSJtske8MjY/JDSeBj6KncJdHI18bi17TkOBwQVtTeruMH+IVpI7H 135H81NC8WnLnQXDWV8FDURSSMbCyRrTyHtJDsj3yoT2gq4Wb2XqJ8rWvfNPgOOMnqPZQJT3C4QV bqqCqqI53nLpWvcHH7nOSvkKiqFX+KbLKKnq6/VDj1Z9898rOePKaMbxtqYd9KQ1287KQuax00UE YLzgcj3U36z03W12z1VZaePrrBShrQD3LSDx+ypjcKyruFQJq2pmqJgA0PleXOwOwyVsItU3+Foa y8XFrWjAAqH4x9srtlnyu3PHDjjpz9Q0skc1wIc1xBB8EIjAPBTlcXyOLjkuPUSe5Kwb3WNOi1nw uWaels1TcuHQVI6Glpzgg85UY79yXq1awu9rqZ52Wu4T/jY4Sfkd9R7chcBYdR3qyRPjtVyq6WKR 3U5kMpaCffhYX69XS+yRSXesqKt8TS1jpnlxA9slGdNxtZaprxrChpqXBmDw8NJ745VkPiQtdVXb axvp4XPFHI2WXA5a0NwSqj2+rqaCshqqKaSCpjcHMkjdgtPvldPW7garrKOalq75WzU8zCyRj35D mnuDwtYXjds548uns2etM131rRx0jQ58ThMRnwDyp5+KS21NZomgqoInOho5zJMR/haQACqtWa41 1nuMNba6iWmqouWSRuwQujuu4eqrrb56G4XmqmpZ29EkTyC1w+2FJdemspyd38MFzpqXW8lPPMyN 9RCWxhxx1O9gpI3G2tdf7/dL0axlM4Mb0iUgNdhvAyVVCmkkgnZNA98csbg5r2nBaR2IK6677kaq u9okttxu89RSyAB7HY+bHbnuph+m9fK5/tZb8LXOrLjWbV0s+lJ83BsMbGOiIOCDhwXOMotw5NM1 dVWX+NkwieHQTxN5bg5AOO5GVWrS2utRaXgmgst0npYZD1OYDkZ9wD2Xtvu5uqr7bJKC5XeWemkI cWkAHjtyBlNGlo9urTVUm1ZoJI3MqXxSljfJ6mnCrLBuDqnTdJcbAKx7YHmSKaCdocWlww7GeQsr Tu7rK2UMNLTXqT0YWhjA9jXEAdhkrjL3c6m83SpuNbIJKqoeZJHgAdTj5wtcrx4scJMuTXgYwAvX a4HVNfBDHzJI8MA9ySvKPqs4nyRSskjeWPaQ5rmnBBHYgqNro1rKmy7GTscXQ1dLSE5BwWuBHK9d RVMvO19sutzc19REI6j1XcdLg4An9lWmv3Z1bc7DLaq+tZNSyxei8GIdTm48n3Xhp9xtQxaPl0y6 rbJa3sMfQ+MFwBOcB3dLf1kjE6t2thubddRW+ht02k4op5ZZHer1x9Y6MDBH81o56vV0dFbai+yU H8NkqYTOGMDXR5cMfzVf7BvNq2yWiC3UtfG+CAdLDNEHuA9snwvRU7p3HVFdbqbVdQ0WxkwM/wCH Z0FzSRnODzjGQs1fnaxW4VvqqnX2k6qGMup6eV7pHDsMkYUV/Fs4/wAXsbc8GJ//AJlM9rbcBDa5 bJdIK+xua05kAc7o+ju6gf4rbpR1t/tUNHUMkmpmPjmYO7DnIyuvhy1ncsvrTGc/XGT7dP8AC3b5 6aguNXIwiGpDfTd4dg8rhL7Y62v3wr6SlldSVs1W6aCTPSe2QQf0Wg0HuvqLSFp/htA6mlpGvL2N mj6iwnuAc9lqNb67umqL9SXiq9Gmr6ZoaySmaWHg5B79ws45SY2Lcd5SrWRVgrI6ay66tT5Ktnyi tY3MbgRgOJ8H3UOb/wBlvVhNJHLcamr0+9/+yNkf1CJwHb9lr6P4gdUR00UdRT26oLGhpfJGep2P Jwe647cTcO762liNwLIqeMNxBET0Bw4zg+cLDVWYtcZvOwscFO4vfUUnpgjn5sgLmtp9G3LRmv4f 4o1vRV0sjY3gYDiMEj7qGNut0b5oujnoqQxVNDIer0KgFzWO9x7ZX01PutqC86go7tFOKOSkIdDF CT0Nd2JwfcdwrvrTN97WI1Zqu90Grza7fp+lrIj0enVSg8Ej/QrSaiqNRXHX+km3u1xUraOYyCWA ktcHEA/bH3XBf/BEXksaX2i2OlAGXkHk+60n/bdfzqoXZ0VPJT9BYKN2TG3I5IPfus/Gmsbq7Sr8 RGprrpq42aotriKcv9SRjhlr3NdkAnwoR3a3Dfr+qt881CykkpWuZ8r+oOBOVttw936nWmmZLVWW qjje57XtnY53Uwg5OAffsonJyuueXLWvhjxYXDe77TfpLbb+K7XT3+hrXR1PpyOLA7APSOQf0UHk gnjsey6fT2t7/YrRU2y3XGWKhnDuuA4LfmGDjPbIXNBnb2WK6kDhWb+E6vgdbbzQ+o0VPUyQMJ5L cdwqy8ALa6avlfpy809ytM7oKqE5a4diPY+4Psn9TLuWfa4OhJLm67xUNxojF/DaqctmB4cyQfLx 98rmL1Fdv+3hlbZy8RNp4BMW8tcznqB9+FyVx+IOqqbTNHTWllJcZY2j8VHNnDh56cffz5XNbb7x VGmJLj/EqJtwFU/1GydfQ6MnOQOO30T/AM8svtjGcZJPhZvW8lbS6avFVYo2vuLWgtGM9WO/HvhU wZHXXW+SyS+rLVB2Xl2SRg+V3Olt67zatT1VdX5rqKqGJKYu6cEDDXA+D7+68dl3MorVuPdL8yzM kt1eD1UheAWHA5Bxjv8ATynuaal1dpq3gppKnZqnhiYXvMUGGjk8cqoVUwsnc1wIIOMHwrLO+IC0 zQNiqdPyuhGMRmUEcfXH+ir7q+4U931Lcq+hpjTU1RKZI4c56AfC3MtePHD6c8ZZnllflpT3WJ7L MrHuFl1Id1nj3S+qeUCwjnKYGVkG5HZFYBNZdH0ISAwgSXlZ4QWEDsSgQ7JLM8DssUCQglLKBlGP 2QhKGUYQEKACCjyjwgEYQhAISTCAQghBQNIJhCAQkjwgfZCD3QEAjwmkO/KBgoR9kIBHcI+yEAUJ pFAeEx9UIQNJCEB4R5QhAI8IJQEAAgoQgEwUsIQNCWf1TQCDwhBxhAZ/ZL+qPCEDxwkAE0lA/KCh JA8JBPKRQMoS7JoEhGEIDhHKEIBH2QgoBBR5QgEZRlCAKEIQBCQTPIR4QBS7BA7p9v0QJA7o8oKo ZR44SPdCgAjHKfhH2QJCE1Qgj6JpfdAeEjyU0igEeEIQA+yPdHdAQCEE4PCMoDhHYo+6AgEIQgPC EijyEAhMe6ROPCACMfVMFGECKD290eE0GKy8JI7oAI/qmlhAITS5VBlCEFAFIcpoQJCPCEAhCCgP KPf6po4QAQEJIBCEeVQ+yRQUx37qgJyjKEkAhBR3QMI88oAKyH1QY48jhPHvymj2VCI4S7OTSIQZ I7JBNBj57d08JpIJTGEIQV8N9AIQUBUIge3dRnrD/wCLcv0a0fyUm4PceFGWsTm/T49h/Rej/G/2 cvN6aPwmgoXteUIQhAIQhAIQhADk4U7bIbZRX4Nu12DXW+LnpPIOOeVBUZw8K5Xw7jG2NQ7yev8A 8pQRrqWTQJ3HtNPa6RrKJknp1bm8wyA46SPbHOV1m5W0dHNdbVV6Yo2MoZiGyhp+Xk8H9Qq701PP NdeiMkSGQgffKvHt/DcodIW+K8FklSxjQHAd244/VPk+Ed600ponTNFan1VugNYZI2vpw7DpGE4c R74K3mptI6FsFqiuFVYnSU8j2tAhb1Ob1DOSPZRnvbNdpN0KCC5xsFLG7/Y3sGOqJzgefqCFPN+v VrsVttNTez0Ur5Y4xIRkMcW8E/REjj2be6IuLrRXWyiikpap5b8rstcMefYgrlNc7O0dHeKS52Wn 67aZGtqafuWDP5h9E9snVTN17k2J7/4LPUyz0rWn+6OXH5mjt29lI1Zrejt+4LtMXLpjbUU8csEp HHU7OWu++EVDHxE6Gsem7FZrhZaX0JZpjFIAeHDpByvvonRmkNxdBvgtjPwOoqePD+p2fmHY/UFb /wCLB3TpKyR8D/a3EY9ugLl/hYjcNQ1biDgwEK5/rNph+20G6ostZp+71NtuMRjqoHdLgf5EfRap Sn8SmBupXnwIo/8AyqLQPdUnc2QHVwmWlq7vavTVk1PcaikvF4htr2t6o/VwA/35PClA7MaZcCWa uoMfWVmP6qqrkO3PCzjb8w8LrtztJRaRvUVNT3CmuFNNH6kcsLg4DwQceVyI5IAUE3bC7d0OrvXq bgeuGFwY5gPPPYqR6LQO3F4vFVZKGecXKIuY5nSQQR3x74UH7U6tvOjLp/ELfHJUURIFTBg9L2/6 EKwlFDpvX9RPe9E177dqaFgkBx0kOI7Ob5B7EqJWk01snaXuu1Dd3yGeB49KVh46HflOF5dK7HQs utZFfHmSljOGOYcEg9ipG2vmvFRBdv7SEuukcjY5HFoGQAcdvC+2j9d27VFY2jow4VURkbUMP+At OAR7g8rOWWptJ31FYdaaZtOl903WmpklktTXsc4gfM1ruT98KXNUbRaLpNMTXM3CWlp/S645yMjJ Hy5+5UZb8/Pu5XY74hH/ALkKY93j0bEPHYmGDH7r0ZYTHOYuUz/SZKfygeq4d8EgEeURjLgUpMh6 GZzwubusRs/txpnWWlm1ElRKLhE4tmjA7exXTQbNaPulRV0VBdHSVdOemWMfmYe3ZeX4UgW2u6nu etv+i9u79VT6Ys0OqNL1DRdobk5ksrecgn5mPHkZUx7c8stXSvkun2UmuZ7PM/qhp6swPf2+UOxn 9l3W9u2dFoyy2y522odJHVSem5jvHy5BWj27v8dZucy4Xeijqm3CdwmjxgZee4+ylP4pbXTUmlbP JSiRjTUOZ0F5LQOkEcFaxx5Uyy4yVDm01ktmotVRW271HoRzNIjd4L/AXT737a0+iI7dU0VSZYqp 74y0jkFuDn+a5LajP9urQP8A74aps+LJ3Ta7A3/5vKf/AHIWPF++Vx+jy5XCY2fKJNrtCTavuphI LYWAOefp7rT7iaWfpPVlbaC/1GQkFkmPzNIyFZHYLUFjvFuihobe+lutNB0zuGC13jI+65ffy56W raqttrqOpbqOGSMtnDR0FvkZz7Jj23eulc2U0pH5f5J/hn+WnP2VzNM7c2Gg05TGa2mumcxryWAd XIXg1ztnZ7lpipq7bb3UFdRtdO0PA+YNGSDj3wrKbVANLJj8pXzkidGAHAgq4um9I6U1Bpqz31tG 2mj6OqYSEAdsOyfuuf3Q250/eNDVd4021kM1D6juoEFsjWfmHC18bTl3pVUnythYIIKm600VY/04 JJGte/8AygnkrXj5jkdivRSH++Ax5UVZdmw1G6mjnZc2eg8BzXkgAg9uVwm6W0tZpSgZcqV4qaA8 SObz0HwT9CrB2m2MvG01FbpZWxCppWRh7j2ORhYa0oKeHQtLpuseS+s6aWM4yCQ4Z5+ye2b7UpNM 8EjBXyML84wVdD/sw0vQUkEVVQTSytb0udFH1ZI7k4XJ6y2ctU1dbq2zl0NPJI2KeJw7FxwCom6r lQ3O6UlO2CmrayGIflbHK5oH6ArwVz5qmd0lTJJJK7kve4kn7lW2uG3OjKeppLHUD0LrUw9URxnr IyP6hRzvzo/TmmrLRNoneheR0OdH4lYThxH2IWpjb6NuO2t23l1tS17oJxC+nwBnzlcNfbXPabvW W+cAzU0rongduoFWe+HCG21OlXT2+aanuUTjHUjAIcM5aceVE9HYotRbzXC23CpYDLXS5eQGh7gc 4H1Kzj+0tnwW6y4osETzj5SOOVlFA58nTj9Fbi67d6EtE8LLoTTvkAIL2kNP69lx2odvdPaU1tba i6zgabuYc2OQH/dyBuQD9Dxyi6RvNtpc2aIl1DgNhh6XOYe5aezlH5jd1EBuVey509kboF1PVVLG WR0TWmbGR0EjCgDTugLTe9ya+32qrjrLTC1s7ZGHILT3H3CGkJNikPduAFl6bj2GFbqXaPSDagwl 7muB6QMFcdSbWWm17iPs13kIpK6IyUL/APMQeW/dIaqujoJAM44XwcC3ghW7pdlrDBFJHXPd1unc yN2e7T+X9VXvdrRkui9UPoZD1QSN9WB/+ZucKkcQMZ74W90zYaq9VsdPRxOkkkOOB2WjAGVZz4WL fSzWy5VUkTXTxSNDXEdgRys28e619/xyTth766BzmmInpyB7qJbpa6i2181HWROjnicWuaRggqZt Sbv6goNwZJqZw/A0chp3UZJ6JA0kE/QkeV1DdMWvdjVEl/pmvgt76djJWluHNkAOQcf1W88bjeNZ l3NxWQxvaOxIym6JzR24Vo4tnNM17JYLfc4pKjpJDWSAuB+y0unNmIbhY7pHWvMVfSyvjH6NyFNJ b8q5uY7pzgj3TETiOrBwp40NtTSam0JVXASllWx8rW+3yD/3l5NtNtrbq/SVVUQ1bf4pBI9rovLc fl4+qQ7Ql0vAycnPZbCx2moudcynpmOfLIcAAKw0myNBVWR/4CsY64CPqLM/ld5af14X32S0PQwS R3KSeI3GlqJKeelcR1MI47fUJeidq96w0xXaZuP4W4wlkhYJG/8AE09iufia57gAO6tvv7omK+0N XdY6mNtTQUXU2EkZc1pJPH2VWLCYf4tRmpwKf1mepn/L1DP8lqz5SZbeGWB8biCvnhT78Qml7Dad P2e5WQRtdPKWODCD1NLcgqAystxlGMuA912Ok9GXPUJcLfTF+BknHC5OlAMrQeOVdbS1PSaW0Fbq ygpQ+aeKIBoOCXSDp7/cgqb70W6m6qnq7R1z05KxlypnReoMtdjgrlXROYOxJVzp6Vmudu6puoqU Q3CjMkTzjkPYM5H3UR3raR50jR3u1yipbKxsjmtHYHv+y18bY56yuKDGxOz+Xyu6sm3V8uVtjq4K KR0L+zsYXcf9jlZ/Y+a8RvAqoY3S+iR+ZrRn+i7PTm5lTdLNbLZpm2uguTWs9XqAdEeMO9sds+U9 HJA2q9DXWw0sc9dTPjjdwHY4yuOIwSDwrqbmyQf9mNxj1LJTitdFJ6LsYBdgFuPqqWPPUepRqMPu ghCEaGUe6MJ+EoEIQoBCEYQCEeEIA9kIQgEfomkgE8I8oQGUIKPCAQhCACEfZNAIQO6EAnjAS+yP qgD9k8JBPugEhlNCAQUsp+EAhCSBoQeyAgEICB35QCEylygEykhAyUk0lAx2STwkgAn590JIGkg8 JoEmgoQBQEI/RAk0soCARlA5QgCjKEIDyn4S8oCB+Ek/KXdAFIplLxkoH9kIBQUAEYQOEZ8IFjlM oR4QH9UkylhAwkAmkEAUIyjwgSE8o8qgQhJAeEI7o7IDsjv2QhAJJhH3QH1R5QkgeEh98po7IF7d k/CRQM+UAhMhCA8I8IQgAhCSBoSKED8oKQCEAgnlNLyqF5QmUFADsgfVAOU0AlhCECQhCBlJCZQL CPPKaEAgoQqBBQg91QsIzjhP7IQGMpjhA7FCAQhNUIBMnKQTIQJMpZ4R3QCYQkEAnz9EIwglNH2T wnhfDfQYpBZ4S6clBieyjDV3/wAXqkDwR/RSgRnhRdq05v8AVZ8OwvV/je3HzemnQhC9jzBCEIBC EIBCEIDzwpg2S3Vfo2qNBdg6ayTnDwBkxn3H/RQ+vVTwueQGgn2AQTdeLjoW17m267WqsbU2aqcX 1EQjP9w7PfB8HK6vdPeCCmrrM3SFyZNQMw+X02kOaWkYHI7EKtwp5fV6BGc+2OQsvReHdPSQfbHK C1OrdZ7f6po7JcK25sbWQyM6i1hD4we+R7ZW91Pqvb/Utnp6Cu1JSCGF7ZBwcEtGB4VPvwk4IHpk Z9wV9W0NUO8Rx9kRb+TcHQtvmsjKG70XoU8rmOMYJ6Q5oAP2yFE26urrPLu/brtRVkdVQRQwiSWE 9QGHHP8AVQy6knAI9Ig/ZfD0HnA6efZWQ2sJ8R+rLDqDTNi/g1yp6tzJ3PeyN2XNaWDGR4W1251P ojR+iRdILhFPXmP54AQJg7sR0nuqySxPid0uaR9Fi6F7W9TmEA+cLV79pOvTebhamm1bqipus7Ws dLhoDRjLWjA4yecLmD3Q4nq5/qjuFGjB/dZeq4AgHssMI7oMnP6x/qkPGPdId/snj5vKCf8A4btX 2GhdU2O/tgjNSQ6KWYDocfLST2UoaL0rY9M6rqLpR3q3OjlLg2FkzR0hx7d1TeFhIHSM4XpdHK0B zmkfUppld3Sus7Dd75fhR3GESMcxjmSODDloIOM9xnyoZ2FvFFR7mXiCrqoYDKZWxmR4aHEOPAJU Bl5Y/IJB9/KxLj1Z7nOcpl+2PCmM45ckybrR0lfvlNBPVRQwTPhb67nDpGWjnKnLceyMvm19VaKS upTPHA1zCZW4f0c4HPlUpkJfy7k/XlfRlRM1uGyvA7YDiFu+S3LkzPHOPF5pM9bg4YIPKGH5x7Jk fMsQ35gSsui3nw02+Gm0m+tjqoZBUnDmBwyxzfBChDfO3V1j11c6aeYmkrJPxcYa/LXBx/qFH1LU 1FPn8NNNFnk+m8t/oVjW1E9QeueWSVwGAXuLj/NJbJpi4ze3bbM2xt31zQ0/rxxPa4SN6yB1Fpzg fVWD+Jay1F02+iqaUBwt0nrytB56ekDICqBFK+KZkjHOY9py1zTgg/dbN97uc8T4ZbhVvjeMOa6Z xDh9RlMcrLuFxl9u42GtQu2uKVrJWMkgPrNa44Lsd8KZvins1VW6SornCzMFBK50vuA7ABVV6aWe kmbNTySRSs/K+MkEfqFsqm93aqpXwVNyrZYHjDo3zuLXfcE4Ux/W2z5M8eet/CU/hh1DQ2vVlRR3 CdsBrIuiEvOAXe2VKe4+3lrq33jUF0rG0cg+aOR35DgfKCfqeFUSIObI1zCWvactI4IPhbeu1Jea yifSVlzrJqZ2OqOSZzmnHbIKkmls2uBLNUaz2xpX6Sr3Mqy2NolgkLXRlv5hkchc9cdLXy3aOqKi 9arrqaq6HNd60xMbsj8pJ9+yq3ab9dbO17bZcKukbIcubDK5gJ9+F9rnqa9XSjdS3C6VdTTuIcY5 pS8ZH3SQ0uLp/T9VBtOLPG3qqJKZ4jx2PUOP6qpD9S6j09DcLAy41UFOHvinpi7Lc9ncFFBrjU1D SxwU17r2RRANY31jhoHYBc7X1E9bWTVVVI6WaZxfI9xyXOPcldOV48WJhOVyePOAC3OO2Fs9O0pr rxS0jXAPmkbG0uPAJK15asmEteCwlpByCDghZbXV1tBPZ9kayncSyelpWjqHGCHDBBXpuVyhm23t F3uUrXCI08rp3/4T1AE5VTKzcDVFfapLdW3iqno5GCN0T3ZDm+xXnZrC+DTr7C+5TutThg07nZbj Ocfum/QuFuQ3U1XHb6jRtY6JruoyuiIIeDgtK1Vey92b+EVl+v4qKQ1EX4iGUAFpJABz5wVWiz7j attVthorfeqqGmhGGNBB6R7ZPheuk3CrrlqC11GsKia40NNJiRrsdXQe/jn3WfhJjpaXVNkqqzcn Tt4gb10lLE5r3DkcuJH8ioY+LJ2NU2hv/wB6E5/75UzWiro3Pt1bZdSxGzmNpFNLK0jp9snkfZV+ +JrUFDfNXUbbbMJfwcLoJSOwd154PnhdcM9Xd+mcsepIkz4Z7XPRabqquRv9zWlro3Dzg4KjWq0u aze2ttVwqPwEtTUPnge44JJ5bg+5IXG6U3G1Ppi2ihtVykiow8vbG4BwaT3xnstfqjU921Rdornd qoy1sbGxslYAwtAOR28hc8P0xuP2uc5ZzNcK3TXKEQWXVVtFxhZlorxyHNIwOpvv4JUFfEDpWXTN ZR1FNWSy2moe4QwvkJ9B4GSAPAx2Wgpt5NbwwRxC8FzWNDQXRNJIHuccrj9aaqu+qa4Vl4qTNMGt aAG9LePOBxlSKtfS07dU7JUdJRPEhqaeKIlpzghwz+y1G2+jZdC67EVVUxyx19M9sLhwS5vJH81X rRe4GotIUs1PZ6306eYhzo3t62g+4z2XnvOtb5dtQRXietkZWxODo3RfK1rh5AHGT591fjR/VpL9 c9bR6ymobWymbanPAjlkiDi0EDufvlaivt+p5dzNOyXz8PUQ0fVIyaBnSMOOCD9iokbvnrRrBmrp iQPNO0rQ0m6upaPUs95hrR684LZI3NzGc+zTwFNLKmP4kbveNP36zXO0zSRQtaCSOWF7XkgOHYqC Nx9cXDXVwpau6xwNlgjMTfRaQCCc88rba13Tvur7E613X8M+AvbIHNi6XNIOeOVH3Q4jgHHut5Zc tfxnDDhv+vn7hWP+FK+0cbrpZ5pmsq5yySFjjjrA7gfVV09Iv7Z/QL0W+sqbbWw1dFM+GphcHMew 4LSFzyx3G9+/6neq2rudfuJXR1UJbTyTun9TwWk57qYds7JBpesv1npnl8bHsmaD36XA4/oVA1P8 QOqI4og+KgkLWgFz4jl2PJwVytk3Mv8Aa9XSX2nqOuaUenJDJlzHR5OGkZ7DPC6ZZ3LLlWOOseKa 9lbFcrVr241FwgkjilbL0l3k54/kpStEjTXamYzHV6wdgexj4Vd37/6hGf8AYLaMgjIYcjIx7rkN N7pX+xaknusdR+IfO3olimOWvA/Ln7e6uWe7yZxx1hwWP2bo57foKupaiNzJxNM8NIwcEHC4P4Z4 n0981JBIC2RjW5ae4IcVyb9+r5/FYK1tFQx9Ebo5I2dQbID2z9QVz1g3SuNk1rc77S0tN03E5mpi T09u4PjlYnU/9ulu5dp52umL9yddNcScTjA9uQuD0bUej8R1xiLg1r6ybjPc9K4fT261ysetLvfY KWB7Lm4ulpnOPSDxgg9+Fyd31RWVWsKnUNI40lXLUGpb6bs9Dvp7qeWc+Ul6q+KzCy360sPvNom6 6r1ZK+1gZhomdzjOS7hVrt9uLdRwW6rHpONSIJAf8J6sFS/J8QN3ktZhdb6ZtW6EMNQ1xDuoD8w4 9+cKEa2tqKu5TVtRK51TNIZXydiXE5zx25XXLPcccPHxS9vnoQ6StdrnirHz0szzE1jjkNIGeP0U Lj6dl1GpNaXzUttpKK8V7qmGkOY2uABBxjOfPAXNdJPYFYdtHA8Nkbn3Vz6mWa47PWqqsfTUSwQ0 8rQ05z6bgXD78FUvIII4+ykfanc64aGllh6PxlrmB66V7+kB2PzNODj6+6k6ymX0zl3ON9LRWmZ8 ulbvV1kIpTWulqGxk5w10XHP6LjPh6gulLp6riuPWbVI0uhZIcgO/wAWPoQoq3D3hrNTW6KioacW +mAAexruonByMHAwtjJvdUnRUFpoqBlLWsibC6ZrsteMYJxjyFq3eOv65cP+S5u++ISS7U9Lb6a3 lzLPNGxkjmD8rskYz4BBXR6asds2+002se0Pqnty14bkuIaHAA+MjIUNWreWQ6KnsWo6L8fI1jmQ 1BdyOPlyPcHznldBb9/qP+D0VNcrK6WWKJrXkSAhzgME4IGP3S3ckaxx121G7MWo9UWyW/SwyMtE YyyMDAawOOCR7gHBKgeTIkI8Kw2qN8LbdtJ3Sz09nmgFVA+NrvUBa0kd8foq8OOSCTzjlRvGEUsJ kJI0EI7JoAICPKagWOU0soQCCmj7IEhNCBfqmhCAPCEIQCE0vKAwn4SwhAwgI8IQCAhHYIBCPKD3 QCPKEwgPshHhJA0IQgEk/CMoAI4QhABH3R5TQI90I8IQCaSPCA8o8oQgE8eUkIGhJCgfhI90/CSB o8Jcp8kIFwln9k0YQCMIygHnCACaSEBlGEBB9kAhCCgaSPCEBlCSEDPZHKEkAmkmgEIKSBlIIQqH nhLykU+yBHun5QllAJoCCgEkI8oGgoSKAQhCACEIQCEJIHlCXhNAkwkeSmEAjugpIDBTQkEDR5QU kD8JICaBI+yOcJ85QBSJ5Qg91QBCEggYTykkUDQeyaRHBSBI8o+6MIBMJZTJ5QIJpJoDsl3TP7IV CQjyhUPKEeOUigYWQWITygaSEKhoSKAEAhHhNAISJwj9UBlH6BBRn6IJXIQAsscfVBC+G95Hsl4T TKDB3AJHfCirVX/xeqj/AMSlcDg4US6lPVfKv/nXq/xvbl5vTWIQfCF7HmCEIQCEIQCEIQOMZeB9 VZjYfb+gdaTqS5hssUbXODSM4DRk8eeyrRD/ALxv3Vzdm3B+zU/p8n0Zu3v0lPkRnPrPTVy3Yt9V TWqCO2xO9F0jWY9YE8Et7DCkjXm1tLeNU2q7WinghpnANmawYB5yCQqvWC3VFbeYaaMOEjn44HI5 V6NJ01RbtP26kr6ozztaGh7jy4Y7fVS3s+HB6/qNPWC52GjbbaR9z9RhdEYsB8TvlJz27hdDq+K1 2OgpKmm0xBXiZ/S6KNg6mt6ckjjlQ3uZTXaHeWibdJzPC6RrqV2OGxF35f0U76s1NSaWp7PVXGIv pp5hEXNGXRnpzkBWs/DT0Vu0te6qy19poaN8E3qtkaGDLSAPlcPBBXO6s2qtw1HRXy00sYgbI38V S4+XGfzAf1Wq2ktVbQ7i3GrlikZQV75p6ZzgQ1wLs5A8cELspNeMoN0KjS9ez+4mijdTyt7seW5I P0KmxFfxQ6etNnpbDWWyjhp5ppJGSGMYDmhoI4W00La9L7o6BfbjQxUF7pow0yxt8gcO+3usfi2O bdpyM9xLKT+wXk+FeF7Ku5Pc0hro+CQumc46/qYXlLUBavsNVpy/Vdqr2htRTv6XY7EeCtGDklST 8QXO7F68kOb/AOUKOOFGp3DY12TgZyn0O6c4IUi7TQaOrpqqn1hWOonYDoZSPkPuCfdSSdL7Ruzj U8Q+5IVVXD9FmwDK6rc202S0aiEWmLpHcrfJEHh7Dnodk5aVysYORn3QTbsftqzUxFxrcGjidgt+ vspTqKTbKfUR01LBA2qlYA2ZhHplxH5erw76LH4XyDoqpIxzKtXYtutL6smqKinvBFw9Z5mgacOj cHHJx/qmP7Y3JjK2ZSIc3F25r9N6hrqWlikqKOEh7ZWtJ+U8jK5Jun7g+hNYyllfTt7yBpICu3ou zOoaS7W25Tfj3RuEfqyjJcwtOAc/Rc/s5RU0231cySGN7DJM3Dmg8YPCfG1VCt9jrrgXCjgllI79 Dcr71mmbnRxGSopJ2RjkuLDgK2GyFqoINEm4ejEybqkDpHAEADPJ+gXRMvGn6uKWnut201PTStLX BkrWHn7lFvSk9HZaytyaanklx36G5wsqzT9fRxepUUsrIweXOaQArW7YVGl6e93nT9r9AV0czzSy SEPjnZ46SO+F6NRX1tpgq6bcDT0LLRMDE2poo+sZ+oPbIU2m0A7UaDk1JfIIquNzKdw6g4jhye+2 ioNJ6mDLbE8UMkLHk44a85yFLOxusI6q+z6bpKaKW3wSPdSVT29MvpZ+UOHuvh8RGso6CWt03UWi nqmVNI1zalzsPYXZwRx4ITHstVaaMZXpogJJmD2PZecjHB7r0ULg2oY4jsUVYnXW2lmpNp2X+jY6 KujijkPs7qIBCe2m2Vk1Pt1NWVjXMq/nDZG9wQCQu71001OwUghHUXUsJGOeOoL6bIwSU218scrS 1+JHYPH+EpJuxMrrG2K3ba2KmuusqWjuDS6lMvpyOxwOcArf79aEoNH3u3i1PJp6yJzunOQHNOOC vbsDcY4dfOoqiliqYa3qYeru0gkghbn4nqKmt+p7K6libGTA5xA7Eh/sukw3nljPhm5akt+UIC1V RcP7mTJ5x0nKwlt88UjWvje3PhwxlXJ0lBZL1oq1agrLdT074YuqQ9ORho+YrVaxtGndX6CrrzZI 6eOe3GSWKSPByWc4cPYhZnra3LvSJtoNrWaqM0lz646dnynHBBPYqNdTWKSz6hrraMvNPM6Npx+Y A4BVu9mtU0WqrB+Io7a2gmiDGTBpBD3cZIUY641BYNR61tVFSWh1NcKW5+nPOSC2ZpOD9e4THuW/ DPLvSvxoZRJ0dDg/2xyvnJSSxSdL2lp9jwrZ7r6ctFJedITU9FFHLNXelIWjAc3AOCtJ8Q2kbe2T T7rTRMjrKmeSF3QMdQDQR/Mq2LMpVb226ctyI3kYznpK8roy0kEYxwru6U0xTR6dtsVfYYnztia2 R+QO3n7qAviL0ZQ6Yv8ATVdsAjp68Od6IHDHA84WcceXouUxs22ezm3tg1lpmV89S5twheRKwdw0 9iop1/YjpnVlxtBk9QU0paH+47hTf8KQzU3r6RN/1UWb6/NuhfXD/wCT4/kFrHHeNpbrKRw0c72N 6WuI+y9dHBJWztZGC97iAB3JK1wPClr4c6GmuOu4Y6uMPYI3OAPuFzVvrFslXXTSs1W53pV3T1wx uH5/cLkdB6QhuWt22K+TOoXu6mfMMHrHYfqrUX4aijvNGyxw04t9OWvcXHBcSMOaR9gFxu8lkoYt SaUvEMAirqiubFKW8BwGDz9VrSS7sjWybEWyJ7WyXIMLzhoeQC4/T3UM7p6DrNE3lsU3z0k2TBMB w7HcfcK1+uLVRXKSzPr66Kj/AAlQZ4/UcG9ZwMgZULfFBqK23F1qttHOJaulldLIG8tDHNHSQfuE k37Lfp9NL7MWzUGmKK501xy2eIOcQRhpxyP0Ua1mgayLWtXYKRwqHwSACRvILXcgqf8A4diRthMf AklP8iuN+GkMqdT3x8jQ5wjBGfGHHCSfrcmveWnppthIDTQia4ATyMBLDwQfZQduFpOs0fqCW3Vz e3zRvHZ7fcKQN7tVXqPceqhgrZIxbZ80xbwW5AOM+RnwVyO6WuptcmzzVtM2Gso4DDK5pyJDnPV9 Ek+039OGa7kKV9pNuf7bW+vlM/pGDAHHckcKJB91aP4Vf/iFej46mf0WM7x01reNv04zTmztdV6h qbdXEwthPS5+OOex/VcNuNo2fSWo5rZKRJ0sbKx4/wATT2VzrbdrdXzxyUc0b5pnvp3dPfqj5IK5 K76KodU6+q6m5s9SGnp44yzzyCR/Na+9/DnjlvWlNfwzw3JaQiGFz5OAQVbC1aP291FUT2+1Tslq g1wcxgOWEe5+i43T2zsg1VU01ZzS00nJ/wAw7/0V0ty+mvotlprnpGG50NUx8ktP6zQDkZAyR/JQ q+meyUgtPB/mr2actVBZLRX0Vrc78NH1/KT+U9JPH3GFDG0m3Fu1BZZrtdAXxvkkYABktLTlL63S bvpXeSJ4aT0JNhcRnpOVber2m0vc6GanouuOdzCWOLSCD47rmduNqLfLQ3J97LZHU874HBvJY5vf I+xSaLVa5YnAZ6SF8o2eo4N5JPGFaur2r0lfLfW0dirGOuDW5bg8tPjj2yq2imNl1QIK5nNHVBsz e/5Xcj+SaWNbV0slK4Nla5uRnDhhePGFP/xBTaWr9K2eu0/NRvqzLhzYXguDCzPzDuOVAH+iLGcQ JdgDKkbQO3Vz1QC6mZ0RgEhzuAcclR3RkCdufdXatBNj26tVRaoYxPNHAwdQ4JeQ0n+aTu8UyvHH lfStW4e2ty0oyKSoZ1wSDiRo4B9lwDoHsw3GPcq7Fqo6m/aGu1s1RHHNVUT5acu8u6W5afvyowm2 st950PSXewTNnnEYdK1pzyPzN+4SWWbSW1XYxuDQSOF1ehdJVup7gIKNhwe7iOApdqdnqKPQ01XV 1Ip7iI3Sx9RwDgdQH64K9nw26jsjrZDZvQcy9PlcS7GQ9uMg5+ilvEnaD9faVrdJXj8DcW4kcwSM I7OafK5N5OBgqdPisz/bWgB8UI/8xUD5OMreWPGpheU2yc7LcchYhBzhLwsuh+Ek0dkAhCEAjyhH lQCeEeUHugSaEIEhCYQCByhCAR9kBCATwl4QgaSEIGEkdk0AjKEHhAIRg4QUDKEk0AEkIQNLKaXZ A0IR4QCEI8oBHlAS8oHjKEZwhAIwhCAQhAQHlCEKAQCl3KEDQg9kDsgEI5QgAhBR9UCTz4CQ+iCg YTSHdCAR490HuhAeEZQj6IBLwml5QA4RlCMKgyhCDwgEBCEAjwhJCmhIpoBCMpIpo90BCISEBCBp IQgChBRhAIQjygCkU0IBHhCPKASCE0B90imhAFI9kykUDCX6prHygaCjPCYQIDhP7IyhAHlLHITS QNI90+6FQkk84QeyAHKEeEFAJd0wlnhIBAByhA78oD3KYQe6O6ASTR9exQJCPKZ44VB/JJCPCoYQ kjCDIIysVkOyARlGMoACoOUIHCEDQSln35R4QIjlZJAo8oDGEZQe6MIJaTCZHnujHC+G95YyUYGF kke6sGIHP9VEWo//AIuVpHb1SpfAGCoe1Bg3qsx/8kK9X+N7rj5fTXnwhJNet5whCEAhCEAhCEBl Sjs7ulWaGrhBVB1TZZjiaA8lv/E3/p5UXdzhbK3W6orpGxUkL5ZD/ha3JKCYqjXOj7budSX+x0VS 62y5NVC6MDpcT+Zo/wBF7dyN4xcdSW2p01U1jbbTdL3wvHp5e09/2UPRWOudWGlbSzGoA/3fSer9 l8322qjqTTPhkbODjoLTn9k0LJX/AHd0LfTZ6utp6t9RTvaZHelh8eRzg55AK3V53a27vtNTQ3Co rXx08glj/wBnPfGOyrCNO3T1GxGhmEruQ0sIJX1/svdhnNFOD/yFVFma3evRzLlZnUktS6mgMjZC IC3oDmgA4zz2UVa23AtU+8MOorc6Wot0YiBPT0uIAw7gqNm6fuXWWiknLhyR0HK8Yt1S+f0WwuMm cdIHKaEx/EBryxavprG+x1D5nU7pHSsfGWluQMf0K6TT+6ej9MaDD7G17rsYw11M9haQ48E9X81X Woo56ab0Zonsk/yuGCnV26qpY2PqIHxtf2LmkArWVuWts4yYzUfTVF7q9R3qputweHVM5HUQMduy 0x78L6uwMhfMhRsMcWlZF7uPm4WOM/VB+yDLqz5ATDvnBWGcpjk/VBK2ym58uh7kaeua6azVDh6z QPmjP+Zv/RTVBqXb7Tt4n1HaL1TvNTgy0sbvmId3IHuO+FVGlt1TUMD4YXuZ7hpKyqaKopsetC9m exc3GVWVt7Zu5pmPWl1oJ6+JlFVMZJBWg5Yfl5B9jyvvpjVejtMsNni1BRyUlYZHsmEgIY7HId7d +FTbJ7Y+yC52Oygtft3rnTloku+kK66UzIQZDT1vWPSlY8HjPgjKwstj24s8VXLUXq2XFvSXdBnb 1DAzhv1VUHF2QQEy4nnhCxZbQ1328vj6+h9U2msgldLR1k0gjd0Zy3DvBCkP+Nadi0tXUOoNTW69 0fpuc7MzXSkY5A55PsqWQsfI7DGkn27rORr4vle3B9sYSppI22usbTo/cl9c31nWV8j42vI+dsZP yuI+isBrFug71DWXm8V1FWwGmaAIpWuka0DwM5zz2VL3OOTwCvsx7vynskWxndBTC41IonOfSiVw hc4YJZngkfZeYHpIIXrFHK/B9M48HCwfSSNwHNIKpvSdNkd14KWmbpfWDmyWmUenDPJz6Wf8Lvp9 fC63dzcyk0rbv4Bpgg1Zb0vlZjEbcDBB5DgQSFWNlJJ/l4+yJYZesZBPGOVDaW/h0ho6rWbp6qsh p6inxLG2RwaHjPzYJXefE7aG1sFrv0dTA+lpiKeUNeCR1OyDwq1CCYOBaCHeCOETumbG5r3HB7jJ WscrjbZ8pl+2t/C7WkbTS/8AZtFaKetp5I56ZzWSNeCPnbx/VU4vArdP3m42z15GPglfBJ6chDXY 4P3C1ENXUQgCOWRg/wCFxCwJfPI5ziXPcckk5JKS3Wvg1N3L5qw3ws6st1NNW2OsmbBU1L2yU/Wc B5HdoPuun15pXTmlqX+0VbUCG4iqM8eORIQ7qLePJCqq2KaB7ZGhzHNOQ5pwQV96q5VtSwMqqmaV o5Akkc4Z/VT1NJqb38roahooNdW7Td5stVHLBSz/AIoYdy7gcY9+Frt16qGa12DVNPIJKC1VnrTl vdrSQDx7gjkKoNJd6+ji9Klq6iGPPV0Mlc1uffAKYudeKaSm/GVH4aQlz4vVd0knuSM4S5Uxwk0v BfGy30WK92Gu6qCB7qiQwvIErCAcHHfGDwVGHxO243nTVs1Bb3snt9MT1vac4Dzx/NV1o75daGlF PSXCrhgGSI453Nbz34Bwvi673B9A+hdW1BpHHLofUd0HnPbOO6YZcN6M8eev4sv8Llo9Gy1d1jmZ I2oJicxpyWFvv+6ij4jrNUWrcarqKhuIa8fiIXeCOx/oo+tV5uVnMn8OrqmmbJy70ZXMz98FY3i7 3C8PjfcqueqdECGumkLy0HwMqb60uu9vADxz5Ut/DPURxbkUrJHhpkie1oJxk47KIsdsr1UE81NV RT0sj4p43BzHsOC0jyClm4t6WY3Z1ddbDu3bqOnuE9PQyRwmSIPww5cQThSFuVapr1X6TjpiOtlW 6obk/mDWgnH6KnN9udxvVSKu6VU9VOGhgkkcSQ0dhle3+2mosUYdeK0mjPVB/en+74xx+i3nlycs MOOu1kfiht1VVaLo66CMugoZjJMcfla4AZVUfWL5A5xz45XRXPXWpLnbp6Kuu9VPSzN6ZInvy1w+ oXMRMLsjCzvqR01q7XV2UtE1r26jgkw41EZmYQcghzSob2hvtPoPcy5WrUB/DfiCacyO7Rvzlufo c91wFm11qm0W2KiobxWQ0sQwxjXflHsFzmoLtW3q5zV9zndUVcuA+R3d2BgZUm9aa+drO602plvm 4DrsJGyUFYRI8t5wcAD9Pqoo+IjTdr05qG3R2jpAnpz6zWkEB7Tg9uy5y27n6tt1BDS0t7q2wwt6 WNJDukDwMhcrernVXevmra+Z01VK7qe93cn3ViTHTwEYKtD8KErXWS9sz8zXMyFV4nnhdBpDVt40 nUyTWWtfTGVoDwOQ4D3B4Wcsd6/i23jljPlOG0NWW74XSm6z0GWdwbnjqHn9lNtjr4P7cX6hEjRU CGnlEeeS3BGVSCl1Nc6PUjr5SVb4Li6UymVnHzHvx7H2W2qtwNQTani1Abi9tzYwRCWMBuWjwQOD 3VveeWf25+PHjhjj9LF7VaOuentdV1bWxdNNMJQ1wORySQu/sNZDNftRUrZGOnyyToBBOCwgFVTG 9Ws3NLTd8gjH+6auYsWtLzY7+672+teyrdkOJ5DgfBHbC3yve11qai3G2lBWW7S1wt9ya4VrnveA 45Ja5uGrXbHF9NoW5W5xDa+iqZ2ujz8zHEZbkKvs28erZLhTVouI9eBrmA+m3Dmu8O9wPHstTb9y L/b9V1l/pK0RV9YMT4YOh/GOW9lnL9pr+kllt+1mNN1Gv7g+cXKejpBGAYy6IfMtXo2236iud4v9 HVxVNSax8dfRN4bI4EZI9jjsocl3y1dJBLDPWQyMkY5h/ugOCMfouY0juDftMXKpq7dWu66gf3ol +cPPuQfKSJpa+62WDVVmnnoaSeyXaMucxw4OT25HcFVDqIHRa2dTXh5dK2t9Opc88k9eHEkrtq3e 7VdbRT09RU0z45WFhxCAefbHlRRUzSVE8ksr3Ple4uc9xyXE9ySquMTt8QOibXpyw2q5WouEdRIY unwR05BCgXOVsq+93GuoIKOsraieng/3cckhc1nGOAey1g79+FG30hdh+fZXItNZ/arZukGnZ45K ymiiy3PLHxkEgj9FTTs4YXXbe65u2i7k+ptMrQJGlskT+WP+490nVlZznLHiuJZp56HTdxrb46KC auDp3Hs0F0eAPpyP5rj9iLLX2W1VlbVveyiqmFzIj2GAT1Y+oKgXXW6d51bRxU1Z6EMTeHNgBaH8 5HVz4K9b947/ADaThshdCz0o2xNqGAiTpHGD45HCzJrpJNJf+I6hudVYaWrtb3Ps4haJmRnLeCS1 32wVw3w+2Gvi1ba7saZ4oHF7RLjjsR/VctY92r1bNJ1On52wVtDJE6Jnrgl0bXDGAc9h3GVnt9vB eNI2COzxQUtTTRvL4zM13U3PcZB91fJ+00uH63bt/idtFZVagbcIoHupqekYHvA4blxVdnDBx4Uz 6o3vuV9sVfbKm20Ihq4XRFw6sgHyD9CoXzldM8+WmPFhcJq0FLPCMIPZc3UFP7oKAgEdkYQgE0kI GgIQgPuglGOEEIEE0uyYQAR2QgoAICEYQPCEIQCEkAoGgIQgfZLygoQPKPCSPCAymkEwgSEfZCB4 STCRQCZQhAeEI+yPugEZ90IQB5CMcI+yO6AQhHZAvdMIwmoMTwUwgcpHgoH3QhGUAEHsglLwgMpo RlAIHPdL+SeUB5Qe/wB0spoFlMpIQBHKeEfVCBICaEAhB7IQHlAwl9UIBLusvCRVUI8IHZCASKaP CBITwhAJeUJhAieUJlI90B2KaWcIQCAUIQB5QhCIEk0fZAcIQhAI8oQgWPdPskhAd0IR5QNCEigD 3RwhHhAJ/okE0CKEIVBlLhNCAQhNBieSmjCCgEBAQgB3QUh9k+cIBHco8IQBCOyPKRQB4x4T8JBN ABGUJEIGkmke6oEfuhHlUCAmfqkgecIyl5THBH1QZJIQqEE8Dt7J/okECxgp+ExyhAso/VMLLA9i gltGFlhC+G97HCWOFnjhCsGAyHe6hu+HN2qj/wDNCplxgk+VDF4ObpVnv/eH+q9f+N7cPK8ZBGMo QeSEL1OAQhCAQhCAQhCD6UzeqZoVs9ltK2uy6L/tPUR+tI2J0zuOR0jJx+yqXA7pmafGVc3blza7 YqeKjcJZDSTMwzk9RaRhT5PhFlu3Phue7VJeJ6KBlF1+gzpaGOMZPBd4JCmrVO3dJfdX22/05jja Gt9RrWjnHLT9VVDRVimuuoaei9KQkPAkAHLRnlXessMFmt1utstT1u6emL1HfM7jOP2Vvs+HC6+1 RS2vWmn7RSUzBc43te9zowWvieMEfyXU61rbja2W99itFNXOkc8zQuYAehoB+U+/dQdquyVtp3yp DVVEtTDPK2WF8mT0tJz0DPgFTdr3VjtJ1NlkdRvq4KuV8T2RgdbcNGC1Eeew3ixamuNrrrQ2nLvT mE8JaBJG4AfK8fQ5Wvvu3dDJqmh1Da4GRytkH4mHHyvH+YD3XObP6ZrrBrCuqa2JzIK9j54Ce5Gc kH2IyFt6XXc9Hu9cdM1bPUoZgwwuH5onlvP6FZ7WTfUR78V9NS0dXp+opaeOKd/qh7mNALgMYz9l 0O3stq3W0BNaLxRRxV9MwMFRG0DsPlcPr7rQ/FsCanTzPZsv9Qtj8LlJPBS3CWWNzWSgdJIwDwu+ ck1r5cvFlyxtques7JLpvUlfaal7Xy0shjLm9j7FaMLvN8cO3U1Dk9qgj+QXBnAPKzZ26Y3cfSKN xPYn9E3QSN7g/spI2kvOjKNtVBrSkmcHEOimjb1fcEKRTe9l3k4ZVj7wFRVbntx5CyhHPPddRuSz Tw1K92j5pZbW+NrsSNLSx/kcrl4xzz7oLKfC/U0tfBXWquoaecMHqMlc3Jb7hSPe9P6Y1jU3jTEl EyluFI1r45mN7dQyCFFnwotIvVwJB/3XB/RSppmKRu8uppXNPpup4wHeCQ3lXH/XK/TGV/fHFXDU +1d/tEtaRSPmgpnHqkjBPA8rQt0TepbGbrBRSSULQSZGjOAO5V3YR6kOoQeWlz2jPt6ZXG7XRg7R VIe0EelUAgj/AISnxtVUNNaQumoxMbXTPmEeOvpGcZWOptIXfTkcb7lRSwxvOGucOM+2VY7YjSxt WnZr6K+SnilY5zugBwDW98jyu21jT23U22lzlmmbcaU00ksUxj6SHAEgj25Sd3ULdTdVN2lraah1 pQ/j6RtVTyv9J7HfXjKmD4m9L2e26Ut9yttGynqHVHRloxlpbnBUHaAydV2okf8At2Z/cKxfxUnG gLV9akf+Rbwx3lqs+S6ksVN5ycnhfSF2JB55XzccZ9srKPu37rlHSri7QWbTmptDUlVJaYxUxtMc h4+ZwHf9UVWidMa50pVzWSidRVUDnCN72gfO3wcdwcLP4bD07dFwGSJHHH7rnLpvVYbTa66i03b6 mCvLiA2VgMROSHdj91ZL7ZuvTqtvtP6YvuiYLjJaWCWGNzZxxy5gOSPvhau96G01rDRM1207Smln pw6RheMZ6BktOPfC3myMzRtk6d7MsJlke0eRgkj9lxV03n07QacqrfpehqY6iTMYjnYOjDshxyD3 wVJ2am9Ov0lpnSV60VTXh1rDWtgL5RgE5aMux+y5nXu3entS6AlvmmInUssEb5ml4x1taMkELsdq Z4abaSCapaXU7IpXSNA5LMHI/bKx1tVNotpqio0jBHU0EkLiW5J6YnNw4jHkLWE5WT7cvJnx3r4U mLuSvfZJYobnTyTs9SFsjS5v+YZ5C8EuA7jwvtQ8zt9sq2adZ2uBPonQ0ukG3upo3xUD4BI9wHLA cZOPplVMuNNELrVRUUhlpmyuET8Y6m54P7K3N3HT8PMv1t+P6Ku+3VidVantTqqnc+ikqGscSODz 2W7jPxzNzmVudxc6zS9ylYyQUVSGuGQfTOCF5amz1NLP6NRFJHJjPS4YKt9uVqil29pLTHTWenq4 6l74gHu6egNAx4Oe/wBF69RactGoLdZbvU0Mcc5fF1Bg7tecELFmva45zL0p4dO3BsYe6lnDDzks OF4q+2VNCGmohljD/wApc3AP2V3NQVVutF/s2nX2uCeG4sfH1HgxhvGe3Ki74nKugtVmo7FHbojJ IxssNQOHRlrsH75CY43K6k/q3KYyW/PSDdJ6NumqYql1ppzOacAvA7jPZc5cKWahrJaaoYY5onFj 2uHII8KUNktZV+j6yuqKe3Or6OVoEzG5BaRyDlcLry6svmrLrc44TAyqndKIiclufGVltoW8nC6z QWmanU13jo6NnU48uPsPdcn259lOHwsOH9uXNyMGncVMrxmzW0o0+zumorfSUdwl6K6pDo2ZOOpw APH7qAtfbf3HTF7moZonvZkuikaOHtVkNWUNPXanq6j8RI2strqaaJgfgAHgnH17L2bt32g07ctM 110oxVUkk00MoABLWlo+Ye+PZbynG9uOOW+4ppHQS9XR0uLgfZd1tBoyPVOqTQVbulsTPVezs5zc 84+ysc3biwVV/iv1FGw0VREJukD5cjkHH1Civcqpt951rQf2FilguEHUyWppHFge135QCMEEcgrM btdiNrtEfxB1uFwaKwHpMTnEOyfoVAu72iajQ+oTSv8AnpJ8vp5P8zc9v0VltMaZpNJ2eS+alnMt aWiSSaZ2SCBlo6j5yMKue9eun62vUb2RhlJSl4gyMO6XHOHc+6pKjfOEF3KR90JGxlPI8rEoygyB 4TDifKx7p4UDDsJ5WBOOyQJxyrsfTP3QSsQgkYTYy6uEspBPumxkDhIn91jlLPsgZdj7oBSQE2Mg coBwkhBl1FMO8e6xzwhBlk/ugHhYlA7oaZO7e6xyhxykoGSjKSMKjLPCPCD2QOUDCEimFAu6aXlP ygMoQRwgoBHhB4S4QCYST+yA8oz+6PshAFHhB5CEDCSDwmEC4RwgoQPyjKQwgoBGUDlMhAIQEBAd vCE+6SAR5QgIGhAPCWeUDR/qgIQBQjukOEDR4SyjKBoKWSUZQNLKO6QUDBTykEBAZ5QTlCSB55Rl CWEDzlGcBAS4QPKAUeEBUCMoyhNAQUk00BASTQCCj+aPCA7I8IKOU0aAKEkJo0ZOEEpYyUEcpo0e eEJHsmeyKWcppH6oQBQUkBAx2QO3KEZwUBygI4QTwgM4R3PCSD3QHlGco/1RjH6oDPKeeOUkfTwg BlB4QCg8IBCAj9ETQyjskO6aKM8oQl4QGeE8pIQPKPogDKAiDKfhY5TKBA8p9+Uh9eyfhAI8pI8o GhCFQEoQEdwgCUIQUCzjwmjwg8FNgH80ZSIwlhBkg5QEiUBlGUHlJA00u44R2QNLP0RnPlNAijwj 9UEoDKZKQQUDd+wST7hHhXYSPCYT7KhJj6+EkZyEDyjKRSwmw+rKEgFl2VBnKMjP0Qe6RCB5584T /dYg58JcoJjxxymfogJr4b3sccowmjCsGJaTyOFCl0/+KNVj/wCSu/qprJ4d9BlQncjmvqCfMjj/ ADXr/wAb5cPL6eZ35kIKF6nAIQhAIQhAIQhAKQ9qtyLloO5CSnzU26Q/39K53DvqPYqPAMkBdDp7 TdxvtQILbTSTS98NCCR/+1G2UW5kep7PZHwU8jMVVKZB8zieXNPg9l89e7sTXzWNHerPFUUsFO1n +zySZBc0nJ49wuNg0TfZrxJbG2+YV0Y6jEWkHHuvO7TdyiuxtstJIytyGmJzSHfRBN9035sd0qrP VVNgqHyUjiZQ57cnIAy0/Q+63Fdv7pK4Pp3VlhuMjoHdURc5mWn37qD3bd6ibVCmdbahs7h1Bpb3 HuF6BthqZoybZOT/AMqqJmrPiCsTrtbamntNf6MIkZK1xY0gOAwRjvyFGd93Ipn7tf2rt9NM+jLo yYZMNdgDB7ZC55232oDM6IW2YStGS3pOcLTUunrhU3B1BFTyOqgS30+nBBCG9JD3t3IteuKizVFq p6iM0nX6jJwBnOCMEfZdOd8bRb9DNo9PW2alu/piMtkALBkYcQ4HP1Cg64WSutteKKtppIagkYY9 pBOey+1703dLPDHLcaOWCOT8rnN4K1/2zJJ1Gsu1xqrrcJqyvmfPUyu6nyPOSSvHnPCbuPHZYgpW zBIJ8oDjhLPlGOcqDNr8g5yU2nlfPPIWbRkoJ52E3C0tpagnivgnpq7qw2VjOtsjT447EKRL9vNp Ggoa+uskj6q5zAYY6MszxjPUqwWzTdzr6UTUdJLLEeOprchY3SyXC2dBraaWFrvyl7SAUSp12x3z gZLW0Wsy4Q1HU5tUxuSMjGHAfTyuqtW6WhbMHWeCulfaqqN59QROzE48EEfUFVKPyk57+Fj1u78j 3yqLObf7qaZtBummLjUk2fqf+ErGsPzMd4cO4PK3tt3I0JR0c+nP4mf4TNC7on9N3yl2Q5pHv5Cq NnPPsn1OPcEpLq7S9zVSFoqq03ZtyXC4VbpLLHO9sVU1pPGflcR7KY96dWaN1boOejo77C+tpR61 O3pcOtwGMdvIVZKGinrpDHTxOkeBnDRkorqWoon+nURvjfjOHAhN3ezW+niJyBnys43Yd591ge5W cQ6nAYKy0t5tPrbRNq0ZSQtvMFM+Rg9WCXIcx+MFVs19DQ27WVdHaqyOtoS8SRzRnILXc4+4Wujs tcGhzaeTBGQek8r41ltq4IjJJC8NHclpAWpb6Z1N7W3251boqi0RT0cV+pImTREPZK/pewuGHAg/ dVZ1TBS2nVtbTUlXHWUMU2WTRHIezOeFz7XdPCMl3Jyn8Nd7XEs+pdK0+2E9Bb73REvopC2N8oa8 FzD8uD5ytFovV9kqdkKq3/xKmir46aeMwSSBrienjAPfKqwCW8DjKA5wPAxlJdWfzti4S7n2+ZK9 9kfTMutL+OcWUpkaJXAZIbnkrxObnujBA/KClu3ReH8Rpe46DFhbf6D8NLAGNf67erpOCOM/Rai9 1GmdK6BndbqqgqZaN0czWRzNc9xa4HIGc5wqgxtk9HLRwviZXjLc/flLbZx+ExmsuU9rj6kbpjc+ yWqsZeqaCOMue1skjWva4gAggnuFsNV6ktlisdpoIqgVlQJIxE2Ah5eI3Au7djhUnZI9ow04W90t ea213mlrqIg1FM8SMB5BI9x7JbUmEx7i6Nzt9DqLUVkvlLWRerSglsLnYccnOMe6hP4unf8Ap6y8 f+wd/wCZdhS7qaLqxRXO60VTSXOMAvEUPUGuHfkHsoY3z11Bri+QPpIemnpOpkcpBDntJyMjxhb8 edxtt+tMZY71J8XbZ/D9rex6ZrLjS6jb009S1pbJ0dYBHcEfVR1r6ooanWN4ntJBoJKl7oC0YHQe 3C0YIB+qTgSVzjqwHPhdntZrF+idV0t09L1oBmOVg4JYe+PquOxz5TGc4SyWaou/TWqxauu1Dqu3 13XBPEGvYJOnJby0EfQ+FzWqLzZtwtaW/TonYPwD3Tl73YEhIwWYPkYVU4K+qpofTimlZHnPS15D c/ZfKOqljm9Vj3NkznqBIP7q5W5e3OYTH0vJVaz0/py8W/TdXVxxOewwt6jj0+Plz9CDwVzWitIQ aU3GrY5HMno66F01JITnlpy4A+4yqhz1k1TN6k8jnvIA6nHJ47cr3xXa4vmhe2sqRJDn03CVwLcj BwQeOFnTS42qtH1+pbw11dWNdaWyHELBjLCcgO98H3VdfiC0fQ6R1FRstjj+GrITJ05z0uBwQuRf fL3GOv8AH1jSf8QncCf1ytTd7jW3IsdX1M1QWDDTI8vI/daJO9tXjgo9ll05PlfaKnfK3LQivP4Q QvXJRStj6sHjvwvLg+UoQ4QE/CxwooQmEKg5Qmke6AHCEYR2UCQFkEgOVQI7FNCAQkmENBAKO6Q4 KKyKQ5THdCBFCZSB4+6IMIKaMcIGOQhJNAEo8JI8qBp9kgnnhAdkfVHhGeEC7oxhB/ZNABGcICXn JQBKeMownlAuUeAhHlAIygfVBQAQhCAHCCUJ+UCCefZBS8IMgkEDsjygO6EIQCPqhCAT8IR90AgF CAf0QCx7lPKXkIGkO6D3RyoAfRPCDyEYQGeEe/ugfdCBBPKQR3QA7o8ppIHhLPumg9wgEcIH8kZV AjP0QEggE8+yMI7IBHZLsf8A6eU0NBHhJHhDR4RnlAQgPCAhCKXlMoSQCEd0IBMoOEkB54Qc8oKE C7lMIAwhAfokceE/oljn7IA90x9EIHCA8oISJ7J+QgQHCeOEZ4SJQHuhI8lCBjyjyl5TCAKCUH6J ZQCZ+iSO6AQeyEBAYRj90f0R9QgB3TP7JAZ84T+yIX1QTlM/VAAygSyQkOPqgD/NARnlLJPZA8pF M8D6o8qhDume3shHCAzx90D9EY490EIDyhLKfc+UCzymkSjKKaQ5QCg9+EAc9k/sg4RnP0RCQe6M 9kygQCaQKPCKf6oPARn64Rn3RC8+UFHlCB+EcJIPCATR4QqBAR5QVQHhCEIEEyj7IQGMIJRzlCof hY4TRk+yCZEygBNfDe8keEI7BUYO/K77KD605q5z7yO/qpxkGYn49v8ARQbVnNVN/wA5/qvX/jfL h5ny8oR5QvU4BCEIBCEIBCEIPpSt6p2j6q4u21toNK7Yv1FBStlnjp3TuBOC7pGcZ8ZVO6V3TO0q 5ejZG6g2IqKS1ubPUGjkhLGHJDsdsJ8l9Ik0zujWVe6UV8rwwQyn0AxxH93ETw3PGce6sLdtFW68 asodRtcPU9MdWCMEAZaQqo7aaVnvGrWUMsDz6T8TsIwQAeVcehntlmNus4qWMkc0thjc4ZOADhPk +HAaw1i7/tOsFlo2lk9M4SPna4ESMe3luP0Xba2n1FA6ik0z6L3R9ck8Mo4la0AhoPg91CldpF+m 98KUwtldQzyCaJ7xwOru3P0KlzcLUly0/drLHbaQVsdYZY5os4PYAEHnB5KMjSGrbZrCtpK61ktl jgkbUQuGHxO44Pv9CvpdNF0M2qKPUNHG2GujePWDRgSt9/uFzO02j6rSd+rBVY9Osh9VgB5byctP 2XmsesK2l3pvenZCJbdNIHMYTzG7pGSEak36cL8Wh9PUFhkhwyQQvPUOD+bhdltjX0+6W3s9o1NT Nklp2+l64Az24cPYhcZ8WLOvUVkj74p34/8AEux+Gq11FusdU+pjcwTYc0kYyuvl6uMn04+O241V 3Wdo/s/qa42r1PV/CTuiD8Y6gDwVo884XY7vkO3J1EQfl/FvA/dcaPl+qzffTrj6m3qipZJG5a1x +wRJRS9Oel3H0Uj7U69sGmqWppNS2P8AHxPIdFLGR1N9wQVIDt2NtnDDtKVePfEf/VFVvcC3uOy+ jSuh3BrrHctTVFXpmlmpLdK1rhDKBlr/APF2PbK55nJUFofhWuclRb7hbJ44pKeLEjC5oJaSOeVI 1dDZtb1motK3OhYH0bh0TMaAQCMgj2IUW/Ciwie5uIOHRjB/QqTtH00se6Gr53RkRSua1jvBIatS frb8sZXWUiANT7MXqgjuFTSNbU0tI52S382G9z+y58bYX2bSpv1NT+rRhheQ3kho7nCuC/5rBqX6 uqv26CuT0Plux7z3P4OcH/wlZnZbqbVl0Nt3ddX09RJbGNeISA4E889l8tc7dXvSMMc9ypnCneek SDsD7H2VjNntOUNi0R/HnzTgSQGWUwuwQ1oyRjyui1zLb77tHdKqL1KqkkpHyxGcfMCBwfomN5XU XL9ZuqtbL3I2zXVA8QRztmeIXskGQQVLnxX2mhp9PWSrpqaKKodUPYXMGCW9IOFC21rD/ba04yQJ 2Z/dTt8WoP8AZWxEf/LLv/IFrGbtlTK61Yqo7ufuvrTnEgH1Xxdw4k+6+tPzIMe6y0u3tLNR33b2 krKm3U3rwxFpPTw7pBwf5L40tXp/U1vuFrulmit1xdSvlZTygf3jOk4cw+eVjsNmLa4OABcxr3YP YkAnC4jcatOtorDedOwytdbI3iqY1pBiBIzz5HBUiVCeqND3awMiqa2keyjmOGSY4+i+8W315nsj btHRvfREZ6288fZWR3xj/EbTwekA8F1OQcZwtxt010G0cDJWciGQFrhnx7Jllq4/1Me8bfpWKi2w 1DXUzKmnoJHRP7Fa69aDvFnqqaKuoZovxDuiMuHDj7K5t0uVu09YKCSsrf4dTP6Wh7WdQ6i3OMLj Nfaq0veNG11KbtHVVrIzLSvdE6NwkHLS04xlanYrmdsr+ytipn0EolkaXMBHDgO68Fy0Pd7Xcqek rKKRktQ4NiB7OPsFbCou1U3aGnv73j+J0lKJmS456uAc++R3Ws3CkN42Y/jtQ1rbnTQtq4ZmDBje COQp9L8W/TRbR7Y0bLJUi/UYM7w5jmPHgjgqt2t9PVWnb3PTVcEkTS9xiLhgOblXG2e1NWaq0i6u uBYahhMZc1oGS0Hkqse7urrvql9NBeKaBgo5JPSkZGWucDxgnz2VxlstS5aymKNMkjHK6jbusgoN WW+esgE9MJAJIye7TwVy+cErb6aGbxTHHHqN/qs53WNsdcdWyVbfcuzaPtui6itrLd6cE0WI3xMB cx7mnpP7qotFSTVs7Y42l8jsAADklWv38YX7UUkbf8ToB/IqL9kdMTRa2t0lzo3ikqGu9Nz2/K4j /VdZJ+LDP5rzTK3yZ4/EcK3by+uJzbJwT56crUyabrobgaOeB7ZwcdBbyrXa/wBdVumNbW2zUlJR y0tRFEXGVh6mkuLeCD9PK6e+6ctdVqex18tKz8RKXseQMZAZkfsVmzXtqZbm4pxU6Iu1Ph01HMxr iGg9BwSey0l5slbZqgQ19PLA5w6mh4xkK7L7sKzX82l6ijgdRspGVLX9OHdXf+oUFfE/fBU36nsn 4OBn4ICZs7fzOD24LT9MhWTe59EynX9cTpnba7am0nNdrYwSNiLgWZ5PSMlR89hY4tIILTg/Qqad qdY6i0jpqtdb7Z+OtcjuoucCBG4Dnt34UOV8vrV1RKGhokkc/A8ZOcLLb4KT9oNEyavrCM4ghI9Q /QqL+ysv8JDmuN5aO4a1Sju6zbbSNUw2INZFcH0/U1wIPzDIJH1B7quWq9vrrZ7xV290EkkkPzAs aT1N8FWVtlvt8+rn3GEt/iVNeJopgHc9DgMZC+GuNUQ6d3Wt8NbSsqKGuomRykj5mHrIBCvpm9qk 01jqqmX0oYJJJf8AK0En9lLGw2iLbf7hXR3jBlpSAaZxw4h3nHfgqd/7J2PTVfcdQuja2jEYm/Ln 0wfzcfqoWuNCNwNxJa7TdN+GpsCF8jDgP6Scv/UY4V+N/CS96SLR6I0Fc6ye2UTw+rw5jmBpBaR3 59wqx7laZfpPVdXanu6ujD2H3aeythWzWnbPTf4iTplrX/lB/NI4YJ58ZB/kqmbh6hqNT6knudV+ ZzRG0YwQ1ucZ+vKTWram7ykjl0imgqOpBCPuhQHlNJCBpFNCBAoKAjCoEI8IwgEwl5QgCmEI8oBH lCPKAKEYTwgCjwhAUAO3KEHlJAyllHhAQZDsngpJjJQH3QmkgPKEBHlAJJoQCCEH+aCgfdLwhHhA dkJ4SygEBCEAEDsjwgoDz3THZIBPPCBfRMdkDlIefogaEs8/on3QB4S8pnv90dwgEJJ/zQPPCFiE 0CwgfojCB3QNCSFAJ/qhGUCQEDhAVDQhGEBhB7oKSAHuccp+OEYQgEIRnhAeUI7lCKChGUcoF5R4 TR/ogR7JlJPwgEeUHskUB3TSCflAJJpeUAjsEdghAfyQUZ4SHKBhHhACWUDSJR3QEAg+UeUdkD8J BMrH7IGUEd0JIAdk/CP3T8IF5yjyg90IEE8IH8kA8IEgJ/ZLygaSEIDt3QgpduEDJyg8IHCEDHZH lDfKMYRAeAhLymgSfhCX0QH9Ex7oCAgM8o90ux901RjznkLIoScgPsnngJpHlAiOUwAgLHPPCBnB R4Q0J/YopeeUJjlI490AP1R5wjHHCflAeUimO6WOUAmO/Hslwn2CAd3CQQOyB2RB58I8p90fZAvK OMI7chCBjjujwkAmrAeEI8dkZVAl5TCAgSYQjykAfqjxlCFQwjKQRhBMyaYQviPexxwjhZEcpHug +cxIhkx2wT/JQZUnNRKf+I/1U5VPFLMf+A/0UGTj+9f/AMx/qvZ/jeq4eZh5QlnlNelwCEIQCEIQ CEIQDSQRhdpt1r286Iuf4q0yB0T+JaeTPRIPr9fquMaOp2Byu00Zoa66pkMdsg6iB3PA/dB0g3Zr qfX39qaC10lNNJGGT0zSeiT3Oe4JXj1TuZcL3rWn1JT00dHUQsY0Qhxe35c/1WNFtfqCp1DUWQ0v p18DA9zHnALT2I91rjoe7x6n/gNRSujr+oN6HcZz2OfZVKkms+IKtrKu3VUmn6MvpeoODpSQ/qAH HHynI+q2kvxGyzGN02lKWR0Zy1xq3Zafp8q4huzOpW14o30WJXNL2gu4cB3wvZ/2H6oxxRn9+yo6 So+IqqfdaWsjsEQbEx8ckZqSeoOxgg9PBBC4Go3Jqm7mP1dS0TWOfI17qZ78ggDBHVhev/se1K6r lpW0TvXjb14J7j6LnbZoi73G9yWiKme2ujJa6JwwQQg3m625X9ubrbLhDb/wUtG0gtdJ6gcc5HgL prtvzU1Ojf4VbbU23VrmCN8zHhzCMYcQMcE/yUY3zSlzsl7ZarlTOhqpMdId2dk4BC9GrNDXvTEE M9zo3x0835ZMZbn2VqSSOVq55KiV0kz3Pkcclzjkk/Ur4445WT+HYKxUaAzjysskDGT2SGOEzwgP vysmkg8LFZRjqdj9EE5bL7s2bR9lfR3W11D6hriWTwEHqafBBXX6l38s77PWf2eo6qC5zdnTxtLe eHHIOQcKB2aMvL7F/FoqOSSiA6jI1uQAsbFpK63qnmmtlM+dsX5ugZITTNSntnvi+0tqrfq2OWto Jw4iVnMjSeCDnuCusod79I0L32yC3138DmicHN6B1RuPBA55BH7KsdRTvgmfHI1zZGEtc1wwQfZf PjCCw2ht57NZjdLFcqaol0857/wcjWgyNYT+Rw88Ld0+8+jGw1Nhkpa3+ASwdLHCMBzCeHNIz27Y VXSRjnKGnI8pOrss3NVIGgtSWHTW4UtXVQTVNl9R4icB87W5+V2PdSfvHuTozWmiZ6Ollq/4hD/e UpfDgB/AIJz5Crg7lIkjhX+j5ud5/dfSGQscHAZwcrAhIj2RVtdBbu6Ht+kqajllno5DF0TQekXY djBII916KXczby16erbfa6x8Ykhla0GB2S5zSOT91UVpI/8AeX0JOP6rIsNtfu/bJ7JJp7Xg6qVg /uKnp6uB2aR9PBWw3I3loKS2RW3RsjJY3sGZi0jp7hzS0+4xyqzZJevRC31XhuMlNFWot+5+i9Za Po6PVkrqOqgI9SEtcQXNGA5pHgrWbh600E3Qslrs4irpXNMbS1hZJEcfK4E98FQZS6ZussTXxUcz mOGQQwrW3a21dum9OrgfE7GcPaRkLTOlg6PcrT9w2Ums81YILs2kdD6D2n5iMYwe3KVXuLp+67FV Np/HNiuv4QwmneCCXAjt9FWvBHKTSQHHwp9fwnqz7Tv8Pu6Fu08yosV/d+Ho6gl8VTyQx2OQ4ex9 1sd8dQ6KqNFMoLO6CtuEh/up4ODEWkE9WeeQq75Tc4uCuy9vmfK6TbyqtlNqy3uvjyy3mQCR4H5c 9ifoFzeB3R74UsWVdjUV/wBDX6zRW2r1FQCKItLXeoBy3stZrDcLS9hs9pqbRWUld+Bq2ufFA8F3 S4YcQqgMleG/RBc72x+iu7qT4Zk7t+auHfq7Qeq7nQXubUFHHMyJpYx0gBGDkA/qtjdtf22bU9np LQf4m6kImkdSvDw5jmlrsY8jAOFSwSuAxhdBorVdx0pf6a6W1wM0RwWv/K9p7tP0KU0ulQUdpqta m80lfFJWOpxEafs4NA8juO6q/wDEk/G5tX5PoRhS/SbyaZc6O6uslZHVvjxJLG1vynHIz5VdNydR P1VqeouUgA6miNvy4LmtyASMnBx9V08V4zK35crLzx16iR9ld0bLp3TNdZNRU8hY5znRPawPDg4Y IPsoSrXNfWTmP/dl7i37ZOF8wAkR5Jwubux7cqRdl9wHaF1EJ54zLb6kCOoa38wGfzD6j2Ud49lk B0jISm14qI6Tbc6nVVJcaZ7KiIVJ6XguaQMk4z3I8LirBf7BuNuFU1dZNDGKCMR0zZDj1mdR+bny M9lVlk8jGgNyM8ccJCV7HBzSWu8EFZTS579xNN3TUtZpCtnb+FmhFOJScNLwSHMz+gIPlfDayitm kb9fbD+Mp3vaWVdO4vAJjdkYH2xyqbmoeX9ZcS7Oc55W3pYqqpaJ2+o846eokk/ZW22cfgk1eXyt 7UaPobjqF9xvtyp61pb0Njc9owBnp4/VVi3vs1Hp/cGuobacUpYyZoHYdQ7LTTxV0cJf/e4Hfk8L SVrnyy9Uhc53bJySrrpJJt5MIPKywgBGtsELPp55QWnPZNKwT8LItx3SQJMhDRlw+q2MdtlkYHBp IP0VGtwjyvfU0EsLQXNIHvheRzCDzwobfMgowsiMoDSUGKMZCzDSTjC+0cDn5wOwz2QefHCMLMsI 7pEIMcJLLHKePplBijlZNYvrHA5zHO8D6IPh4Twsuk+QvrBTvma4sBOO5UHnIRjhZyNLTg8FLHuq McJYwfqs+kJ9I9k0MR2THZIcrIhQI8JJoygAco8oR7oDyhCEAjsgd0E8oD6oRlHlA0kZTQI/RCPs g/TlAv0T7/p5QeyMIGjsg/RIe6B+UBIJlAeUvKaOyA7lH3QTkcIQHhB7IR4QIIKY+qXlAICEIDyh CY5CBJ+UeEfZAYQO6EkU0eUI+yASTSJRAn4R4QihIJ4yUIDykUY5TQLwmEsp+EB5QllAygPKZR5S PP1QNLKEdwgPKM8oS/xIGUHugIQGchHhCCgQ+6OyZ4CD2QGUY4S8JD2QB7p8eUYTHZAu5RwjymPC AyFimQhAJJlJAJ+EZQeyAHKMcJJkoApDjynlJAI+qEFAd0eEIQNJCEAjwjugIAcFZLEp58hEGOUF JMIF/RGU+Eh/NAHsmMpJoDsEA8oSPfhUBRzjymUvPdAxykRymSjygQPKMcZTQgQygd0/ul3QPJwl hMpHuijKeeEf6ICBffKM5QQgEYQLH6p4yAjPhCACZ7IzwExwiMeEZT58I+6A7pJ54Rn2VAEISP7q gwmkOEZQPyhJNABCEHgJAeUIR4VAmkEZQTUB9keUJ9l8R7wsMfssysSUHwrDilnOP8J/ooMnOZXn nuVOdccUc/0YT/JQVJ+Y/dez/G9Vw8xHuhJNelwCEIQCEIQCEIQfehGalgPurnWL0NJbPS3u208Q qoqQzfMMhxGO6pfSv9OZrvYq4+m6iLW2xdVbrLKyWtFI6B0Wfma/jgj64RLekMaA3FuTNxorzc6j rE7vTk68kNjJ/KPOBlWiqNMWi5agptRAB03pD5wchwA+UhVb2e0fPctZupaqAh9G7M8MnBGDyMK1 Tb/Zbbd6PT/4iNlU9hDYeoZYMDAI7jIPCfK/COLpraW7bxWm2UE0TqWjJdHUQSZ9QPaOppxxxhSB rmnv75IqzT1cad1JHJK+J4zHN08hrvbIBUTx6Jl03vbBPSUz22qdxlif3AJ/MM/dSLuJXX+j1HaI rAxskFXHLFUskBLTnAB+hwSjMZbfazpdcSMuNJG+CWOAxzxO/wAL/ofIW4q9N0FVqGlv1OxjK+F3 RK9mMSDyD9Qub2w0gdG3WspBIJGVEQmH/Cc8t/Rc3o3U9wh3u1FYzN126eoe4RO5DXDHI9kVw3xX yFusrQ5hw5tLkEcEfMVIe01b/wBom281r1PG2qji/uRI782McH7j3UefFNE6fXFriY0ucaMAAdye sqS9hLNUae0lO65AQslcJOpxwAOO66eWauOnPG24W/Ko+r7dHaNTXO3RPL4qaofE1x7kA4C1A5XR 7jObLrm+PY5r2mskLXNOQR1Fc4Dg+EupbI3hu4y1saS11VVEJIYJHs8Oa0kL6SWOua0uNLPgc56C u42w3Udo2gmoaqzUtzp3u6mF7uhzD55wchdz/wDBA293DtGUhHn+/wD/APlRpXtzelx6uCOCvrSY 9UexK3GuLvRX/UtVcrdbm26CfB/Dtd1BrsckfdaSD5JAfqoLrbRxMOzpbI0OaaeXIIz/AISuT+Fx gFHduB+YeF1e0LxJs11MOT+GmHHv0lc58MlNNTUV1jnY5r+sYyMJjemL1Wg1DtHV6s1rf6ykeyng NU/pJHB98LSai2CvNvtk1XTvZVOiHU6Nncj6KVbfqO62DVV9hvNDJU6UqKuQtna0kwEnBPHj39l9 rpQV9vtM+oduLtJVRFxM1LMTK0tH+UHkEJTaFNI7L3TUNAajIgA7B4wSvvqzYy9WW0S18QbUsgHV Ixg+YN8kBWEtd4EW2hvNXTeuWxPnlhjHSTyMgDwucsm59FLQSVNDpW8SUY4kIe12PfgqbVC1Bsxd K+yUV0opIpqepA/L/hzx/JeXW+y1907ZpLkGtqIYuZBGMlo91YDY+dtRpi5vjEjKd1VI+KN/HS0k kDHYKPLTvtBRVd2oNVUD5mucY2OgxggZB6mn6LWrrbPLvirMe6Q5K+1wcx9bO+HIjdI5zB24J4To 4zNUxxtx1OIA+6NvrQ0klRM1rWkl3AAUyWnZmprtFV90qXGnqIoXTRNPkNGSD+i7HZzayOmhbeL6 0BrB1hrxw0DkkrV71buAiWw6XlDIWgxSzNH6fK4HBBBxjCgrme4K2+mJaeC90U1aM0zZWmQf8OeV qXHnH1Wz07Rur7vTUbCGvnkbGCe2Twgute63+C6KoLlpa2UtzpzgkEEjoIGCCPrlc5q6hsm42gRM yOkp71Efkia4CSN+QC0jvhcfbK/V2z8EVJXQx3Cx1R+SN5OGOHLuk+MjwpD1Fpy2XY2fWVrj/C1A fE6ZmMCRpIGDjyM/qkrPyrtdtsLzab7RW+sp+k1rumB/+Fx8j78r4XfbS8WbUFFa62nDH1zumB+f lcfb7qzG6n/3Q6JJ/KK9/Ptw1cp8TUssL9MyQvcx8dRK9rmnBBAGCFb1/wDTbGN5WT7ukUjZzULL oaF9MPU6OsHPDh5x9lpL1t7d7Ndo6KspXtklGYyBkOH3Votd3WtoNuYLvTTObcYo4i2Ufm+Y4d+6 3VwZHV26wz1jGyz+pCetwyfm/MmF5YzL7aymrZ9XSsEWy2opo2v/AAnyuAcOe60h25vEGpo7HPSG OrmaXR9XZw+itrrHVFn07X09LdK+ponStzEImdYcMkYwuH3I1ZaK+ntEttqJP4zSVcToZXxFjy3O HfcLPKeyTd0ham2k1BLVVFN+DIkiALgeOD2IWti24vb78+zvpXsqwzrDXDu33CtRuXqsaQ07Bd3U 4mkn6YnFp6XZIJHP3Wv07rXTerr3ZJ7XUMfdWsPqscwte1pbyM+cFXuTejrdn0qZPpO4UOo/4LV0 5ZXOcGta4d8ngj6FfXVmjrrpapibdqZ0TJeY3eHY7hTjufQSzb4WipjjJayKDqIHs4r2/FeAdOWA 4H/rbucc/kXTLHXTEz9V6doLJQU2hJo9RUTDDM0yskczqyxw/wBFXWi0/LeL7UUVtYZcSuazp7Fv VgK1Hw/1dRW7aMjrJDJ6HXGzq7huDx9lB+019ZpvXtXUz0bqmidI5swY3Lox1HDx9vZTGbwuS3ry aa120mocOBoH9Q8LnLfo25VV0kt8dK81THFrmOGCD9Vc65T3mqiiumlqulraN7RKIJGj+8HctDu4 J7fQrQaKutq1Nq641cNqmoK+CIMqY5QM9YPByP8AoptbvatztqdQ9DsUD+BnC1Fl0Nc7s6tipqV7 paU4kZjlqstbNd3io3drNNztpjQR1D2McGHrwAD37eVsKiMWbe2lioGtZTXWiL6mPHDnNccH7qbJ NqzxbZ3yoo3VEFFI4AE5x7dwuDqoJKed8crS1zT0uaRyCrtaq17Z9Iart9krgaaGod6z5i0GMBxI 59uQq2/EK6zP15+I07NTzU1RTtkkdA4OaJMnPbz2StY3aMgFYb4YhbLoyvtFypBLN/vopDggDHIV eAVP3woxkaqqHEcegVy8mXGbjthjMr2mcWbSdxvdbp51vIqmxdT/AO7Ab0kcEH3VatT7f1VPrO6W a3xOqTSuDh0jksdyFP8AqfcbTGk9XVUNdTVIurWBpljYCCC3grx7WxVWobnX6xMsUTqlroXYYS3D B3IJ9l6rJjuWPHjlcrNK16h0VdLRCyespZYY3Hp6i3AysLLpGvu0Tn0dM+UM7kDsrl3m30GptH3F lU6lracxvLJYBjDgCf0IK5TZWnp6Ta0XOOBjqlomLiRkO6ckZWJ6layy1v8AitjtAXgulY2imL4x 1OHTyAfK89t0Zc64PNPSyvLPzdI7K3mnby266Hl1PJRwMrBA/LA35XBmSAvjt9LRVWjXX4QQUj6t 75H5HyM54/QKSyulnHe76VIvOiLtQ0ElVPRytiZ+Z3TwFyD2FrufCv1JPablST0lfVWueCdvSWwS NJGVR7WdFFbtU3Wjpz1QwVL42H3aHcJUwzl9NPG35grd7Qac05qnQlJVGjBqIW+lMHD/ABDyD9VU RncK4fwwgs2+qT/81ccfoptqsLpoDTWr9JVb9PtDJ4c9J6cYcBkhVyrNFXBj2H8O/okOGnp4J+is ZNuZpLTdlrm2aQy1Lj/6pjBLiSHc/r/JbnbOeDUm3VLWXCmjbLRvJDmjOQw5HH2Vt/bTnvrapd10 nXW2Jr6imkja84BcOF9aLSNxqImyR0kroz2cGkhWvNdpzcDTN3ZC6nLad7vTLRgjA6mkjxnkfovr eq6g0RoO3XBtujqYn+nmMnpJLh7/AH+i1JvKY67TfXL4VHumma63+maqmkja/hpLeD9FL2y228V0 nqn3iA9EQALHDkhw7qTdQR2/Wm0lReWUTKR7I3zRNyHFjm/XA9l7dmdXQ6stMj2ULKWppYo45nNI Ikd79vplYzy44zL4t0sy/a4fSqeu9MSWTUlXSMY70BM9sRI4IBXmp9I3CaNkjaaUhwyCGlTLudqW g1HebdbW2r8PNS3UNkqOoH1Wl3SQRjI557lTvHZaS30dNT09JA/kgdRAPTgEYB7rec4XjZ2mOXLH c9KL3DT1XRThtRC+MuGR1DGV6YtK3AtY/wDDy9LxlpIPKt3uLpm3V1hhqqmlEVTTTxjp6cdTXPaC P2K+Wvr5Zdvqa3RVVrNU2XqYwMIBAb9wUxvK6k7XLLhJbfaoNTYaumrGwTQvY9+C0EYypt2x2vp7 npC4VNyjIe5kjGgjlpaMgrd7hah0pc9K0Go7e6Ftzo5opGUbx0veOsBzCPOB7KUNC6it+oNJ1V3t tI+CmJfmF2AchuT2WOUmUi5b43KKPXagloat8MrHNPfBGDhS/wDD3o6i1A25fxOPqZ0N9LI78/Mt JvZe7Vf621VVpoX0csUTo52HBB5y0gjv58KU/hhrae4abqrZLTltRRSGQTA/ma/x+ivlswy014/2 8fL6QFrWwstusLpa6X52U1S6Jvucdv6rx/2VuAd0mnlBP/CVLVks9PdN/q6iqwXROq5u/JJAyFLO q9S6d0zfqa0XC2vkmljY5skQaRlxI5B+oXTyawysnw4zO6xt/wDJURtiq/x34V0LzP4bjkr6s07X FzmCnkLgekjHYq0u4NrtemdX6cv/AOGD4aicUssQA56m8O/TK3mo4rDpW8QTVlIZG3SRkMfS0fK8 Ef6H+Sxcsd6n1tvvUt+bpSmtopKSZ0c7HMe3gtIxheUhWC+JzS1Haa2huFGwN/FFzXNA8gZVfnjD kzx46v2vjz5y/wAYpeyyWI9/Cw6GEeUBHcoGkE0kAe6EI8oAIQEIBLnKfdCAwj/RGUmoH3CQ/VN3 CB3ygfhCEZQCCllP78IAJEJ5RkIBHf2R4R4QAQeyEvCAQhCA8IR5QgCn4SOcIwgaSeEBFAQkfomg Mo8JeUIAo+6DwEdwgYQkEBA8pDueU8pDgoBA5TPZLHKAynnhIhBKB+Eu4QgKIPCAhA7IGkhCAQhC AQUvKCrA8pZ4TykijKZ7JDlGT90CPdCY/okgZ/ZMc90uCmgCEhyUHBRnhAc5wg90Hx7pYKBnukU0 iCgeEsJpYQNCXlHlAfbugo8pjn2QCRQhAIxyjPKOyAxgo7ozyn2HKBE8oAR4QEQfdGE0soGeRwkf CAg8oDsEIKXhA/CB9Ugn3ygf0R4SxhNUCX+qPKPHsgaQT7oxygRKAOU+xSI44QByeyAEDyjP9UDQ P0SB+qD2QCM/9E/9UIoSyCh3hIc/RAEJjsmkSR3QH8wg+EJhELynnB90JKhpJo8KhJ+Ek0AkmUig aP5oSQMowjKEgAhCQKoZ7/dLq+gR5TQTX5QnhH3XxHvIrEjwsz3WJCDzXAZoagDj5D/RQU/85+6n O7EttdUef924/wAlBh/MSvZ/jeq8/mJNJNelxCEIQCEIQCEIQAOCun0TrC86Puf42x1JikI6XscM sePYhc1C3reApL2/2vumrWudTgQRYyHvHBQfJm6Go4tYP1LTuporhLGI5WsixHIAMcj3+q8V515e rpq5upHPiguTejBibhvy8DgrprJtBda/UlwsUzooa2lYJM5y1zT2IWrpNuLkdZv07Vt9Kqa7Bd3H 0P2KDfTb8armq6SqdHbxLThzSPRJa8OAzkZ+nhbL/wCCI1SQOugtDiOQTE7/APaWLdiLuLyba+WF sjmGSNzjw8Dvj7L3j4eL5g9M1Px7Ko1L9/NTG5RVraa3h7WFjmBjulw/dcc3cG7wa7fqmlZDFXPk 9R0eCWHPcY9iu1ZsPfXVVRStMImjaHjJ/MD7Ll7JtpdrlqaaxSRinrYs5D+OyDza93FuWr7zQXWq gp6WrpG9LDCDg4ORkFbvUm9t/vemhaXQU1IC0MfNT5BeMYII7crmtQ6JuGn9VR2K6hkM8hb0PJ+V zXHAOV7Ne7ZXvR9LDVVsQko5e0zOQD4ytbSRwLz1HJJz9V88ZWTsjjyljnhRoD6cJnPvyUDwhwz9 EACf1TB9u6xC+kQLnD7oJR2p3auehopqOWnbcbXICfw8j+nod7g4P7LvHfELTQ0s7aHTLaSeRha1 7Jwel2ODjHOCuD0vtNfNQWaG5UMLJKeXscrVa226vmlIo6i40rhTvPSHjkA+xTSV12i99LtZ6iuj v1M260FW50hiJDCx574+h9l05+IK3QW6qjtenn0FQ+MiN7JQ4B2PlJGORlVzfGWuPBARjPuiJt0J vrVWinrqLUVA240VQ90jWxkMLC45c3HbH08Lo6jf+001qqYLFYp6Kokb8j+prmB3jLfZVvIAPORh IjgdzlBY3R+/9uttoZDcLFIKvJ9R1M9rWO+uCoW3FutrvWrKy42OmlpaOpw/0pMEtfj5u3jK8OnL PU3u4R0VI3rnlPS0L76t0vc9MVraS7Uz4HvHUwkcOH0SfRJ3tz7gTz5X0ppXQTskj/M0hw+4SDHZ wASl08kcqqmrWu9lReNI0VutEctFUOiEdU7OCC0Yy1wPIPOQQoVe4vdkk5J8rNsZ7c/svmRjugxz 5XqoKqakqop6dxZNE4Pa4eCOQvN5X1p2l0gGeCVFWatO9mmrzpmiptZW+okroDhwiYHNJAA6hk+f ZfLXW9lodpiK36Thm6ySHCoi6QwDBaRg+CFF1v23vlRSR1ENHK+ORoc0gdwVqdTaLvNhphU1tFNF Tk9PWW8Appi+080W9Olb5ZKB2pKephutPk/3TOprH4A6wfY4Bwtdq7Xdj3G0pT0YhqG6igkzC0M+ R3PJB+oGcKtrg6M85/ZdDoeW4R6ho5bTl1dHIHxDGQSOe3kJU9drmahqLbb9BU8uoIJJKCOKITNY 3qII7HH0KivX+9FtbQ0EGlWGYxOY/wDvmlvR0OyB9cjj6L5at3V1Rb7a6C+acohTVcbonF7XBriR yMcjyq3ukJlIH5c9s9lcZxxkjPeWVt+VqqndTb7UsNDWX9s8VbGwAsMJf0HuRnzytVq7dfRtTdbP FHSCrt8TwXzNiLJIvB488YOFCdLo+8VtrbXUdDNLTub1B7BnIXLzsdHI4SAtIOCD3CmmpFotydfa H1fourtbLnKJ4oy+mcYXD+8aPl/fsq16c1BcLDdae5W2d0FVC4Oa4f0PuFrC88jk/ZYH6K7utLJN rc6c3d0dfKOguV+6aO8xNMcjTGS3PuD7f0UObx7jzaxuDaWHobbaV+YmtGep4yC4HvgjHCioPIHf j7rZ2e3VFzkbHTsL39sNGSmzS0G1u5Gi7Xo6jp5a38HO5nTPA5hJDxwXZHgqMLNq+yaJ3XrZ6Usu WnqsgOe0Zc1rucgHuQSeFyH9iL01pLaCbP8AylctW00tPM5kzC17DggjkFXd1pnW7tby2aw2+t1x dX2y/NpjIep0TQ7ocD3HSuXq94bBbdzxV0cHVb52+hV1MfZwz8sgHuMkEFVm9RxaMchYteXHJyoq 4NPf9uY9TvvkV8pm10khkLnEjk9/HsvBBuXpK57jS1dZWtpvwcXo007yTHJhxyQR7g+VU4ueTjGA l1uaR7ppU+fEldNO3+nobvZLrBVVkZ9CWON2fk5IP7qAJHF/LiSV9JnFzR1DAXzxk4+ib2Y6jEd+ eVYP4adQadtUVZJdKyKkuETuPUOBIxwxx9iq+lrgRx9V9Gkt5AWbJY1vXpNPxGutNReqO92e5U9W asGOWON+SwtAwSPrldB8Om41toLbPpu9SspRIXvhne4BhyOQT4Kru97nAdZz7L70MD5JA2Npc4ng LeWVyvbnjjMJqLmWDUOlbERYI7vSupayN7o5fVHSHYw5pz24II9159tZaa3afutgmkH8OZPM2mrm nMUjXDkZ7AjKqHWRVFJUmOdhZI3w4YIUr7O7rDTFNPZ79A6qs8vU9nS3LonkcjHkH+SfRZO5flYJ 1DSWna6501uqGT0zIJSx7DweDlRpstrOzXfQdVpK8VLaSpa14a6R2GyMd7H3C82qt57IdJ1Vv09R zxSSBzPTlaOhzXDB7HII7+VXikhklla2IEu7DC1jNYTXuXbNtyyyl9Vbe2WnRen7bXPfcaSvYGdT mMna57QO+Oe//RVJ1G+mlvde+hc99KZnGFzu5bnjKVWZ4ZHQzNLHtOCCMELz0sD6mobDG0ue44AH kqZZXK7rWGMxmo87eCP6q52yVdY6DQtI6nuVKG1DAXtfK1rmyYw4EEqnlxt89DUelUROY7GcEYKK ad8LcMe4D2B4Wflq99Op3HoG2HWtyoo5WyRsk643tOQ5rhkf1VqNrnWim29pYqW4QGnqoesuc8Dp c4YcD9iqVTl0knXISXHySvtTVc8DeiGV7B3w1xCW7y5fLPCceLptT+vpfWFxo6WfPoS9LZI3cPb3 HI7jlWatlfZdy9t7fTsq2MdThgmjLgHRvaMYI/1VOJ5HPlLnuJe7uT3X1paqaDPpPLCe+Dhayztz 5/JMdY8Phci8zW3Se1lbapK2J8JbJE2Rrg7pLgS0HHbJ4UW/DJq6htt3rrVcJmwPrw0wuecBzh/h z4KgyavqZY3Mlnke0nJa5xK80cjmSBzSQQc5Czn+2Ewvxdkx1nc/tbjci16csunJ6+udEy4ioMsL 2nJe8ODgDjtkZC6O7C37j6Ys9VQXBkcOS4kPAdnpAII+hVMKq41VU1rJppZWg5Ac8kA/qVtbSbiK QtpnTCLJPS1xDc/bsmWVyy5U1JOM9LMbgUVo0npSmqX1D46qOWPoaHHpmLHtLsgfTn9Fu9aWS37k W203CkrYvwoD3NkDhj5gOOfKqDc62ulY2KqnlcyM5axziQD9AsKO7V9NAIqeqmijByGskLR/Iq4Z XG8omeM8mMxvwsFvXpiwaf2+hdG5sdwZ0Nh8+seoB2P0OVsPhs1FQ1mkLhp50zWXBrpJGsdx1NcO 4+yrXV11XXhjKiaSUNOQHOJ5XrtdNcaKds9L60UoHyvYSDz9Qs3HdlX/AMbj8VNm+mmrJZdG0ckb 42XVrmYaDkyDs7B+i6L4YaGCm01UXSOYPfUOdDJGCMtLTkfuCq2ahrLjVFrbjUTyuj4aJXE4z918 LRe6+1sc2jqpYWOOS1jyBn3V8n73trH9cbjPlO94mh0Rv7S3C6SCOkrHunEngNfluT9iFJOtdEM1 VqamvEdSwRsgj6C0g9WCXf6qnt5vFbdZ4pq+qmqXxs6GOleXENznHPjlbCl1de4KeKGK51bIox0t Z6rsADwAmeXLLLL7Y/HLMZf/ABWW+IO7U0VNpylfK1tRBcIpHxk4IZgc/bgr679VsbTo6YOHpi4s d1eCMAqq14vdbdpmzXGplqJGtDAXuJIAzgfzX1uWo7lcqCmpayrlmgpzmNr3E9PGP6LGM1lv+adP jHfxdrB/FnM11qsrmnLTK/B9/lCrCCt1edSXK8UVPTXCrlnigOWNec4OMZ/ZaNdLlyxxl+Ix48OG /wC1kUhx5S7JErLoyTBWPf7JoDPKCkOCgoGjCXhPwgPCEI9kCyml4T8IDyg5RlLjvlAE8p+Ed+4R jAKATWIOEIH27JrFCbD8oPdJNAYR90in5QNJCAgEs8poQAQeyXlMoDKaQKEUfdA7pgpIH5SPdAQO 6A8hBRwjH6IAlGeEk+EAD9UYQkeyDJJA5QDz4QHlHCEeUB+6X9UyjwogCEeEd0B5RlLsEZCBoKD2 +qR7K6NGhASKGgjuhPHuikUY4QQmgQ+6M9ksIz4QNqOPZHIQgMcIP6I+qSBhGMfZIJ+EB57IzzyU kHlAz7JZWQWPnygfhGOUBLz9UDzhL/EmO/KR+yAPdAHZCB7oBA7oPZCA7IOMIISQMYwhLPCYIRB5 QjCOxCAygDjKBhGfCB5SBwOcICAgPKB2S8poo7oAwj3QPqiGOyWfdNCoXf7JLMcArFAxwhHlLylD zyscrJJAIz/NNLKBeeEyMprHkgIDHKZ4HdM/zSIB7opd/wBEwMfqjgFA4QBSPITPdB+yBhBH6pey Dn24RBhCf80uVQ+ySYR2PCoRTSPdCBkoARlAygPCEHujugWU0k0gED6IKAqBH6phPKImsoKZQviP oMSl/omcZQEHhvGBaqzPb0nf0Kg09ypwvh/9FVnsInf0Kg8917P8b1Xn83seUI8oXpcQhCEAhCEA hCEHqtg6quMccuCujcKl2mNlJrlamshqoqVrwekEE5A7fqqVUcnpVDH+xyriWGupdydmaqz2eeMX FtOI3wvOC1wwf2OEEHbU6xrbZr2C4TSyObM/pnAGQWk88ewVuXWi1T3Jt+bE0ymLqMgH5mgZB+4V adjNHSza0qYrhEI6i3OxLDIOe6sKdaWWHV0emA4fiS1zS3pIDDxgfYgqfIjei1kdTb2UkVHVMntt KX/hpI29JLXAdQP6+6kTcGzV1S993tdwmoqm3QPmYWHLXluT0vb5BwuCtuhZ9P70ito6cMtcxdLH 0nIZkjI+nK63X9DfqrWNvFlmMVDUUr4KslvU1wJPB+uCeVUfXa7V7db07rl+GNPUshEUrAct688k fRdJ/DrbcLtBeacRmsp3uhdKzzg4LXfULRbe6Wp9IXSsoKOUyQyxxyjI5a4nBH8lwW2d8q2bzaot YmP4Oapkc6InIyHdx7FNDg/ipd07h0eOD+BYf/dOUp7L1LtZbYy2/UQFZTtzCPUGT0+Ofooz+JSm kr9z6OlhZ1Svo42Mb7kuKl7aW0O0VoiU3iRsMX+9c53+EecrWXVjG943Sm+qKOO36iuNHBn0YKh8 bMnJ6Q4gLWA8gLbawmjn1RdZoHtkikqpHNe05DgXHBC05cR4K1lrldNY71Nuhtmkrtc6RtVR0M00 LuA9jSQvvNoi/MYXfw2pwOfyFbvb7di/aLt0lDQNpKilc7qayoj6ug+cYK60fETqXGHW2zkf/OXZ /qo0hKaN8UrmSAte09Lg4YIKcJwcraatvT9RagqrrLTw00lS7qfHCMNzjkgfVauEZcPCgtr8K9XU SacraeSV7oI5AWNJyGk98LtrBUM1j/aqyX2FlTRU9Y+FnUOQ09v2XGfC7Sywafqnysc1krmuY4jA I4Xc6Ft8loumpq6sLY6aprXyte44AAPOVJ/rWb7qJ7bsZT1c1e+arMFJFO9sT3f4mh2OSvlqDYhj LTLVWOviq54B1Oia4OLh57eVNv459PoyvrqFkVW6MzSxt/M2T5sgceCuIsOtNW1lFLV0WkqCNrP9 4wOc1x+3HKu2UUap2fdQ6D/tHTVAd6UYklicMHBIB/bK+Widov7W6NludLUiKoYXBrXDgkDspzq5 m6v2guTLW0Pnljc18IOXRvDgS0j3CWztsm09oZ8NyAg6iXtLzgYd2HPlXH3IZdY2oB2Ishq9ZmFl TFT3ClPXEH9nuaeQu2+J8VdZWaepquliY8eoWSsfkOJwC3HcY/1XF7R08r90xJG1xbHUuLyBw3kq RPiecY7zpp54Y178nx3C1jJl5c8J6kS3WOFvzWh07sTPXWyOqrKxtO9wyWPGOPC1+tNj7jZaFtfb 5W1kGel7Wclo9wfIUu7wxz1W1DfwXW6QiAj085x9MKM9FnXtksYmjfK6wyO/vY5R1loPBIzyFz3e MrU7tjOybDVNdbIameqEMj+8ZAyFyW6Oz1x0pav4rC8VNG04lLOTH9T9FZTXV+j09pairn20XOI9 DfSBIPI7ggFcRqvW9VNt5cpJNKz09rqaZ7C8S9YZ1DGSMDsVruyVOXelQzjPCzhcWvz7L5uGPOVk 04WW139mtW2++6RtFNSSNdVRxmOeP/FGWgd/oVp94tT2it0xqXTk8jI7rHHG6KN4AMgJBBb9RyuC +FKN4vVXIQeh0WAfGQs9aUUFw+IFlHWj+4m9Jhz5+Uq+H98c7fhnyyzyYYz5fG2bGVVztNPWQVkJ ZURh4+mR2Uf/AMIuug9eU8EzTDW007XRuxw4Z4I9wrX1tVbNNXKzWiOikP4kljHxvLWsII7++VF/ xMRsj1FpiXoHX1Oa5+OcZGFrV43f1tmZS5YyerdJI3E05JrPRAomMjFTO2OUEt/K7uceypxqvTtb py9T2+4wmOaM+3Dh7j6K4Wv66rtmirZV257mVLJafBb7Z5/TC4z4mbbSVOiqK8yRNFcx7G+o0YJD u4P0V8G/J48ZfdjPkswzyvxvT7/DJcZ63SE9BVNY+Gkk/ust5Ad3H2UN6g0y+/bn3yjt8IGa2TDW t4aMjP6KXfhgidHZLmXAjL2lufIWl2zkB38vsbgPmlmIz9wufhvPx5ZX4rp5Jx8sxn01A2CupAzJ F0kZBUSa90hcNIXh9DcYiw46mOxw9vuFcLVWs7XZNQsttdTXKSpdGxzDTuBaQc4GCRyod+JnUdHe bNa6ZtDV09bDMXh9RF0lzC3GAfPKvaTKVXkc/RTJ8NMltGszS3PoDp4x+HLyAC8c4H1KhodySpD2 k0jUauqqqGim9Gopmtla4HBBzwQfGFG1o9S6mqrBqeOlrLJTm0yPZ/tvI6Wk4JPccH7KO93dvKO+ anoarTfpO/HBwn9IhzA4dnce66HQutbo6/M0hrSgjqZWh1OanHzO446geDkeQun0npOn0zrO5w0p DqOph9WFjuTGQTkKys1Bp2IvXS8HoDsHAHuuUsm2t1r7xPbxAY6iJxa8OHAKtDVa3s1PqKot0klz FdFKQ5jI+tpI5OPovVpi4229amuVVQRvYWwxtlEkfQ7rBPOPsrKzeptXSXZO+R1UUUkTR62el3jI XzodmrxPU1VNJEGTU5GQ7IyD2KsHt9dq+53bU0NymfLFS1pbAHf4G54wvntjdKm63TU8lZL6joKo 07CR2Y0nA/TKZ5cZu/ekxu8tfzavv/Y7epW1kTYR69N3b7jxj7rS6Z23ul5qpYaeBwljJDuoYwR3 CuDbLiZ5bY8xASVRlikcD36OQV8bDTQR36+GnhYwh0cnyjBy5p6v3V+L/F+VYK3ZW/R0ksscLXlj S7DeSVqLDtpc7zYKi4UsZd+He5j48cgt7qztu13Y5J5BDcKuV8RLXwugJDfHcBaHbS6U1VufqaC0 SZtczGTGIDDRJgh3B7LNy1Nt4zl6QXU7Q3z+Dfjoqfqb6fqho79PdbzZ/byatraK6VUQfQeo6N4x yCOD+ynPSF4qajX+pbLJJ1UFEf7mMgfIC3OB9FH+l7/WWbey66bo5Qy0z1Rk9AjIa7AJ6fbK1ZZL fpN9yfbx/EXoF7jT3Kz0gMdNS9NQWN5dgnn9lEWhtE3DVDKh1vj6mwY6ucd+ysbvfe79a7gyksbf VpaijcJ4zH1jBJBP7Ly7K2OCwaIde3VDoI5Y8yu7hob3yFr4nXbHrdvpAWttBXXTNPFU1kLhTyHH Xjsfqu+2V29dV11BcrhF10M0Zex2OOrwpj3AZRX7aS71LZW1kQgfJFL0dJBH0UW/DTqy5z3GPTU0 rX2+MPmjDm/M04GQD7ZWfJePj5/3S4zllcPqbab4idGOpb1UXe30hZRNij9ZzW8BxyCf6Lg9obRJ ctZUZjh9X8O5s724zloPKmbfbUN9hqrtZqSKKa0zUrWygxdTmk5yQR9goi2Tr6u2bgWuSkfjrkEU mRkFjuCCt+ecMeTH+Jb5ekifE7b7YyKyT2+KNlRI57ZOkYPTgEZCj6x7aXa6W5lXT0zi15/VS18V IaG2HDRlr5MnHJHSF3V+u0ml9p6e52qOIVAhg6epnUMuIBOFjOyZYYye4eG8sblb6ulY9Tbc3myU zaqqpnNhcenPfC9Um2V4j/BvNM4MqgOhwHByMhWS0/XO1ptXW1V8hhdK5krcMbgAtBwR3wvjoS4T 3TZ6nrqvDqqkY/0pAMEGP8p/ktSSyf26XPOY8t/Cr+sNB3WwU0dTWU72wuOA7HAK+O2emxqnVUFr e7pMjHOB/wCUZVop6pus9mKy43SGJ0z4pXjobgAtzjAVatq23Ma0oZrH0/j4QZGgjIIHcH6YU47w 5z701jlvK4X3Gv3O0nPo3UbrfUHIcwSxn3ac/wDRcgCTlSXvxeLjetWQvvNI2lqqenEPS3s5vUSD /NRo3BzysOkbjS1vddL5Q0Y4M8rY8+2ThW6tek7Do3TofdomFrenqJ75yAfvjOVVbbeRses7N1HD RVx8/wDeCuTrl1FLerPRXIMNNVNniy44Ad0ZH9Ew3lncXPzXhjjl91Em8+2NNmG8WQA09QWghnbL uB+6hm9aNulqrWU9VTyMe/luRwVaLX80tDslBNSnM1OyB0ZIzyJBjK2lmjo9wdNW+51NI2CuhkAk bjgkfmx9Ctb1jjde2JbbZPhWG06Oltd8skt/jMFtqp2xvkdwG54BP6qx1yo9HWX8HBWxs6pIx0yx tD2uI4PIXFb+6ho57e7StDTB1U2VrDlmHM6CHAg+cjjsvBtVqSx02n3WrVUcwroJ3Oje9nV1MdjA z4wQpfW2sbu6Y/EVoq30Fhor9bWBjJi1hwMZDhkFVweckjwrd/EuCNuLf6JBo3SRdPGCODj+SqHI R6hxjC65YyePHL5qePK3LKfROQTkcFYkoXF2ZEpE/VYo7oMs8d0kJBAz2R3S+qEUz24TST7og8/Z JMcI7/ZAeEse6M8J/ZAk0ICBJEE9lkjPCAPskeCmeQgoF2wjKM/ojHugEICAoDwjCPKeVQIQl5QB TS7oygAgICPKBpJo8IAdkD2SKMoAoB4QfdA+yKYR5QUdggOyMpZT7oAJHjlNB8oBCR4KAQgO6Pog d0OQNId0x34QcAhAFLynlIlENGUkfooGhLwhAyUsc5QhAfqjPt3RjJT7YVUJY5yjKCfZA0ij7J4Q IpjskmgXOfZHhCCgO6MJJ5QJHhBRz2QAQmQjx3QHhI90IKB+EDjuUk/9EAl4R2CAgR7oKyCR4QCA jPCBwgPCPKCUIAoCChAiExwmOyRQA8o+yEd0QIHfCEIDslkpnGEkAUBMhBRSTCEZGEQ+xQkU8qgO EHuhCAQeEeUkAgpdinjJQBKDyjshAxwlnB5CPKXdBkEJIJ4RR+qaSMoH4SJSz/NPwgM8p8lJARAe 6YCQR3yqGl5SxhHdUZJJJoGhYoCB+U+yx8o7lBkgd0h25TKQHlCPCFQDujAQE/0CIm1CPKF8R9Ai sSMLNYnsg1t9OLPX/wDzl39CoRHdTbqMkWOuI/8AkTv6KEl7P8b1Xn83sY5Qke6a9LiEIQgEIQgE IQgG/mC32mdQ3bTlc2tstZNS1GMdUZ7j2I8rS08fqSBo5PhTNtxs/Valon1NdKaSDGWuI4/VBxkW 4GpodQyX2G5zMucjRHJM0AdQHGCOxXkrdW3qs1E2+zVsn8UBa712gA5HY8KRtJ7PsveobraH3OAv owHMlhIe2Rp7Fa6z7WVUuup9PVz+gxP6TKwcEeCiV4X7wa0dWwVRu7/Wia5oIjbgg4zkY57LYN3w 1w0Y/igI/wCKnYf9F2UWxEbdQvtVRc4myOi9aA45e3JB/ZbB3w9xul9Bt3h9bGejjqx74VEZf9sm sm3IV7bkBP0dB/um9JH1GFzdLrO9UmqZNQUlV6NzkkMrntaOkknnI7YUvj4fqiarrKQV0TZoWNfG fDg7t/RcjpraavuGqKmxXAmjq4Wk5IyHexH0KsHIap1retS3uC8XCoAuELWtZJEwMx0nI4C9+qd0 NT6mtEVuu1Wx0LPMcYY5wxj5iO6z1HoaXTWuYtP3aoijEnS5s+fl6XdifZbTczaW6aPoIrixzau3 PHM0XPRntn6H3QiLXHqbnysTjCbuPukfoikTjlP8w7oH1SPH0yoMvPdZMzkELEccFfSH8w4VEq6E 3m1FpOyx2uCCjqqeIn03TMPU0HxkHkL2at3t1DqCzy0MkFLRtkJLpKbqDiDwQcnBBC9ek9l67Uun 6W6UVRA6KZucf5T5Cep9jr9ZrVLXsbHUxwjqeyMfN0+SEjNaDb7dnUGjqeSkpfSrKB/Ip6kEhh92 kHhdPcPiBvlRQVFPFa6GkfI0tEsDnBzD4I58LGxbJXC9WSluNHPC6KduQfb6Lx6s2WvtgtclxMbJ 4IhmQM7ge+PZXSOW0LuPf9JXqouFFMJ/xLi6ogl/JITzkgdj9lvtwN5rvquzstopIbfBk+q2F5c2 UHHBB9sLb2rY67XK101fSyQOiqGB7T34K0eutn77pm1OuUkLZadn+8MfJaPc/RQc5tvr6s0Pen1s FNBVxys6ZIZeAfYg+CF1+4+8J1vpx1uqrHBDMHtfFUNlJdGQcnAx5UOyDDivVbIhNVxQuOA9wGT2 GSpLr01ZKmDRG+l1sNiZarpbobtBFgRPlkLXNaP8JODle3U+/wBXXOxz0FutcVtfIOnrZJ1jpPDh gjyF437D6gkpWzUoieHtDmAHvkZCiK50E9vuFRRVjDHUQSGORh7tcO4V0m0zaN37rLbYobZfLXHd BB8scr5OlxaOwPHj3RrbfWa+aantVttbbaJmmOT+8EjXMcMEYI4UIGJ4P5T+iAxx4AVR8iMYAOUh 47L7GJ2eWn9l83tLDyo1Er7P7rt0LS1FJV2wVkT3dccjHhrme4PuF9909yKDVVwtV0stDNbrvSOJ dUBwJcOC39QcqIB3W3sNvmudW2mp2Fz3dgEk1tMp3L9J7od+6OqstOzUFkknucTen8RE4ABw7PAP nzhc7uBuxQax0bDSVltkZfKaRroqoEdIweTj6jwvNSbM6ilia804DHNBHPhcPrHSNz0xXfhrlTui c8dTHY4cE1tJ0myz7/WeXT9HSXqyTy1EUbWPDHAsc5v+IE8hclu/uzT6utUNvt1LJBSkNMkcuCWu acgtI9/bChuNpJIwchAjLi44OR3Vw/T0ZSZe09bT70WnTOm47bdLZP8AiYnECenLT6jPHUD5C5TV 24VNFuNFqnRsUtI/pBmimA6Xvz83bwQoudE/OcHA+ibY3kc5wpjOM1CyW7q0I3y0fXPp624WWrNd 6bQ57WtPSR4GT7qM98tyYNcy0lLbaYsoKY+oySVnTL1EYcDjx2UVdDmj8pwPKzhYZnta3nJQkfDj JAPK63bLWlbojUkVyo2CWP8AJPCeBIw9x91uLPtje7rQCppaXqY7t4K4+ttNTaru+irYjFURv6HN eMYTRas4d5NBT1zbjNQ1ba3Id1ekCQfvlcvdN+CzXlPX0cAltUeY3ggte6N3J89wfso6vO21+t9p dcXUb30zGB7nN5IbjOfsuCe0h3Yn7eVZ16Ra9m723oujrgIKtlU93U6UQAkk9/K9ugtZT6q1ndLn ZaeJ1DE1sMsYHQ+WPJLX49wqhHPfDgAui0Xqq66RvEV0tE/RI3h8buWSN8tcEkSruackt0lRcjQ0 tRTyuk6pfVbjqJPcfqoP0JuTbdI6y1Xb70ZWQz1bnMkY3qAcHHIK0ddv/equkqIRbqGL1WFoczPU 0+CD9CoVuFdNXV09VVPMlRM4vkefLj3Kmc5Ycb97TGXncv5pP+mt7Keiv0FLcoXSW6mrJ3RVUY5M b+2W/Rbql3ntVu3Iq3CR81hroI+qYNOYpACO3t2VXeo9Qyu301oq6X62NrKGB0kRJbkDyFblbv8A q2dyrC27cHbm2Vck9JO6OZ4OSackHPufuo80Jufabdurc7tXRGkt9wj6CYwXBrwOHY74K49+2eof ScRRSZaM4AXBV9LNSVMkE7HMljcWuaRggjws3Ha45aqwmntzrHbN4L7XT1DjarlGOioa0npcG+R3 +ijrV+s20m71VqSxyNqIm1DZo85Ae3AyD7KNyXO5S5PddLlvc+yTVi48O7WjLpSC5SVDWVjqXBpp mnIcMnoz25PGVyO3G7NiqqW7WW+RGgt88r5ack9TQx3JYfqFWdjnjIPYreaXs9VfLgaWhjL5ugv6 QPA7rH0XuWLP024OiWQVml3V4Fpng6o58Hpy4kOYfYjg/XKgHSWqY9CbjOrqJ34ygp53xZacepET jI/RaTU9huNhqmRXCB8QkGWFwwCudlJBUs3jwvpqdZc/lcO7bj6HNDWXRtVDWS1ELSaVwAc4AcjJ 7HB/koF2lvlit24clRdnGC2zOeYnubn0znLc4/ZRuHO6PP1Xzzg5Hure5qmE4f6rQ766g0xqXSDq mgu1PLcaMh0MbTzICQCMH6cr06C3D01qTQEVk1NUsoqikayN7ZTxI1pyC33+oVXoXPlc1o5ycALf XXT1ytEcL6ymeyOUZY8jh36q39rLfhnHGYyyeqs7cNcaS03o2tgs9dDVQnLTDGcO+cEZGe+CR2XL 7Ua6s8W1VdaK2thguEXrgRyHp6g5pLSD/JQa/TtxFl/ijadxpc8vA4C510jmykYxkfutSyST6rnn 4+fLd9rJbfa1tE2zNws8tbFDXwxzMEchwTluQQoU201YNJayobu+IywxktkY04JY7g4XKhzhkcYP HdfPoaCMnlJlrx3x/wB21Mf3uf3Eh76ast2stU01wtDJGRMpWxP624JcCTn9iFHA+y+pBP1WDW55 5z9lidNx97dVS0VXDUwO6ZYnh7T7EHIVtdH6+sGvtO038cmgorvQva9wlcACR/ibnuDhVE4zyt3p +2Vt09RtDE6R8bepwb7Jqb2mXetrH7n7h2aOopNPRPY+3ySsbO8YLWM6mkOGP1GPouj1Rr6xaFst KLZLHUhzm4EJBDgHDq5B4PScqn9eyaGodHM0tkYelwd3C+Tp5Hsa3rJA7DPCvxIzMdb/AKtHuZdd NTx2jW9DLBUOimjdPCHDqexxwePcLoquz6N1F+Gu1JV0jGyxte35wP3+oVO/Wf6XRk9B5IWcVVNH 8sb3Nx7OISxqTSyfxI6mt0miqGzU1VFNUMMUjfTcHAtGWnkeVV4+69VVPLMf717nkeScryHutXK8 Zj9GOMlt+yKSChYbGUIQgaCgBCKMcoCEggCmEIRAmeUkIDCaEIA/qkTj7o/mhqKMZTzx4QhEGUO5 QhAgn4QEHgIESgI7p4UKRT8JIzyqGEkcoQARhCfdAkFHlBQGUEphLygfcIwgpee6Kf0SHCPCaAPK RT8pd0CTxyhCBpFJNyAQB9EgmiDyn4SCFAZwUH7JpIoQhHhA0kBCARlCEAhCEDHIS8pJ9wVQeUYQ jygEykUIBNY900AkUwgqA7JH7JoQIFGUfRA4/RUGeEBHCSDLKRRjlL7oH9UxwsfCy8IEmEgjwgeO Eso8d0FABB4OEZQgCj/VCSIfZAS8JgHKA+iSZSygfZGUs5QimcICWcpg4QGP2SQhECeeMJBHCB5S KE+McopJ/wAkyfCxVQdimkUygWeE8pfZCAKYSTB4QI8FPKRR+iAQOEIQGUd0HshFHhA7I4QgXcp+ EI8IAp9kk/CIQR4TS+6ofccpdk/KWFQJhCMoEUYwg5wj2QBQO6PKMIH4R5Rn6IQMIQMFBVAOyXSE 8/VJBN4KEiUL4j3g90vdBPCxQa3UhxZK4eDE4fyUJ44U06pOLDWk+IyoXXt/xvTz+b2xTQhehxCE IQCEIQCEIQe+xgG5QA/52j+auVr+rnseyc1Xa5XUtS2GPEkfB5ICpZRTGCpZIO7SCFb2w3Wh3Z2n qrDR1LKa6sha10Tzk5byCPoSEghDZvUNXZ9c09XGJZWyuLZmR93AnnhXFlgt7Hy3oU49X0C97gwd TmgZ7e6rtsFpF0GsrhBdGiG42xwa6FwzkZ5P2UyQbiW2TcF2lmscJm9UbiWgBrh2A55BBT5EdaM1 ZJqver146iWa3RucaUSNwWtOMt9+6kbcawsqfx19pax9Nc7ZRmWB0Tvma5vUR1DyD2XN2bQ01k3l qbnSNi/h82ZuhgwY+ojIx98rodY6but21rTVNFUy09ukpPw9R0Hh4yctI9iCqjDaHVNRrG3z3Sth ZFVemyGQM7OLfI9s5XU0Ztl4qmXSkLJKmle6ndI38zSDgtctZouw0Om7ncLdbWlkBbFL0k9i7v8A pwot2buMrN29U0DZ3ejJUSuMeeCQ884UyuptJu3Tg/igydzW9P8A8oxD+ZUx7JSO1Btc6jvBFXTg Oi6Zefl9lE+/1BLdd4oaKAAzTU0LGA+/KmfSFLS7b6Dk/jNQ2ONret3+Ye+B57reU1YzLyxulLb9 Aymu9bDGOmOOdzWj6AnAXhb+YL23+ZlReK2aJ3VHJM9zT7gk4Xg5+gVy1yumsfU27rTu3V+v1rZX W2hfNTPPDh2JC9k+02qmRucLXKekZwFrtG7man0hRPorNcTFTPd1em9oeGn6Z7Loxvzrkf8A6ThP 3p2rLSLaqnlo6mWnqGOimjcWvY8YLSO4KIT8wJ9169RXepv16qbnXFrqqpd1yljQAXe+AvHEfmGf dBb/AOF17hpCrDnEsbMCGk8eF3tipaiwxX2qvNSX0ckzp2Fzi4Rxk9seAAuN+G631FDo+R1QwtZO 4SRnw5qr9uNdrzQa1vdDUVlbHCah+IXSuDehx44zjGEwnVyvw5+S/tw+4s1slNG+1Xj0Hh9L+Okd F0nLeku4x9FuNPU02n7NczqSp6qR8rnB8ri5rWOOAPtyuc2AoJ6LRBbUsLTN87M+QRwq06xvl8g1 LdLfWXCtbEJ3tdA+Z3T0k8DpzjCuMuUyzv2mV1lMJ9LTbKvMuj6mPr6o/XkazB4AJOMewXutkMlk 0hXwaqqGGL52l87st6XAgAk/otZsnQzUO33o1THMe5rnjPkEHBWGlnjWO11ZTXv/AGlnTJESe+G5 6f1GE/2u271FKK5gZWztGOn1HAY7YyikJbM0+xWFWAyoe3J4cQP3X1tjDNVxxNGXvcGtHuT2WK1F 19KVlT/2MNqfWf68VFIWPzyOlpxz9FUmmhq9S6lYaqQyVVZKOqR3cuPkq3OmaCpZs6+idE4VP4SV oZjkktOFHGk9qzSWZl9qn+hUUzmTta7gFrSC4H2XTx5f8Gr7245Y789s9PdSbJ2WlttNPebi2llk +X+8cGgnvxlabWWybKOOlr7JUtqaaV4Y8A5Az2dn2Uib8W6qvGirWy3RPmcJ2yYYMnp6MZXQWoOp ds6NlQOiSONgcHcYPUAUvqVZd3Wkas2LtraCAVNe2nrZQWsa9wHU8DsAe/cLj90dnqfTujJLvFWN FZAMvgeQOsZAd0/bKnTcilmqLjpF8LHOjirXOeQOzelqjf4uZC20WMA8GeT/AMoVwnK6M8uEn9VZ xwVKPw/Ma/X9CHtDgScg+VFxGQf6KTPh+qGRbjW1kjgOslrc+65Z71074a5Taft5dW3fTOo7HSWe pMENTlsjQ0EH5sDuF0u4Gm6PVtgt1NcA315HMDJscgkcrh9/LZWV+rNPy0kEkjYclxaMhvzAqSr/ AHCltttsc9dK2GBs8Ic9xwGk8DK659eTCT1p5fB3hd//ALSrGsNvH6V13RWeeX1Ker6Xsf8AQuwQ u3vmx76Ott7qOYyU9U7pcPLeMk/su73X0tWXvXtgraWPqhjYAJByMh3UR+ykStnj/H2WEvb6jZC5 zM8gFmOyza66Q2NhqHhrq8AkA9JIDhn6LkYtnn0Wum2S5T+nSVcZdSVHYPcOS37qaNaaoqbTqiO3 QWGKvEkbHNnJIIJJ44HhaDV9xvNz1DpeluFjNC2nrBMyZkpka8YAI7DGOESe9OYpNh4zLUw1NT0e m4AE8BzT2KjK+7eV+m9c01mmYSKh4/DSY4kGf6qfviE1NcNL2O1Vdt6S2WctmDm5Dg0NLefHKibW m5Z3Cn08yhoZKO5UMzpetrslxIHA88ELO+trPaerzUVml9vzV2mkbJW0sTHvhx+cNPzD9sqvG+t/ 0/qs2K+2JzG1UzHx1cXZ7CMEBw/U8qfNx75cLTtfLdaUtNaIWdfW3IIdw7I+xKpUx3qVfSMfM7gD 6ldf/wCXMvtxx3fJZ9LoaArpbls4ya4ETOFFJGS4ZJaGEDKrrtnt/Jq+aTod0QMd0ufjsfCsJt7A +n2aMMjS2RtNMMEc/lK5H4VZG/gr1A7HqMkaSPPZcZdeKZX3t1n7ebLH4ka+TYCR0T2sqgZMcDg8 rn7DsvVXOnudNK/0a2kf0dOO/su/0dLdBvVdmVEtQ6i9eQxtc4lgGeMfzUqULmHVl3DcAmngJA98 nlbl1E97VM0LtvPedS1VnrGmGWFrskjHIOFxm4Gl6nSGpKi1VmC9gD2uH+Jp7FXRtVqiiulruDac MqTLPHM8DGR3GVWX4oHdW5jx7UsX9StSc7lr4Yl42T7RGDk47qzPwm3KaVlxtcnS6kAErQ4Z6XY5 wqyjOeFZX4Tad8dbXSuB6JI+DjgrnXZK971NPp25zVF4pYf7PicQmoaPmi6sdLj9MlQ5ddEU+u9y dSfw2aEQNc2aN0ZBD2kDJCkfVk1RqyXUukJacholj9KoA46eDg/Yr7bX6WprDYaypqWudXUzpYpi x2HfJ4B+oXbP9fjuvPhdzd9IR3F2ir9NWltygHqwM4l6f8P1Rpnaqa+6Lpr5RyB3USHsHOMHBVjX V1JqDbe51dPFL6MsEzfTmd1kENPlcD8MTKhliukEznGLqa5rD25HOAuVv6y/3Trj3y38OB1JshX0 tjmraN3qyRt9ToHdzVxG1FwqLJuDa5YmtLnS+i9jhwWu4IU2x7ww2jXV4t+oYXx0MQ/DxmL5gOlx wS0+4OP0UO2N8F03a/EWwF1G+4GWP5cYYXZ7Jn+u5fcPHlz9eky/FRSwDS9jlZCwSmqd8wHOCzJC ibUu19Xb9Ewaijy6n9Nskgx2a5TF8UIzpWy+wnJ+392tzf4jU/DvKyIdbpKBrQBznkK5WSY/1fHe Ut+kCaT2urNS6QmutE7MjC9vRj/KouqGGKRzHDDgcH9Fc34fKeSm0FUxysLXiV56SOeyp5f8C71m P/kr/wDzFXXWyXvTGz/+uxZH+Mf1Vvt3LGLntfRNpadrqsCF7CG88d/5Kn9ncBWwk8APGf3V9p2e rp2xPaOpjHQOcPdvlYwz4+aS+m88d+Pc+3D6Et0EmyE0dZA0vZDUNPUOQQCog0xtNWahsNJdIi0R zggZ78cFWQqaEUOkr9SmMRsMs7mtAwOl2SvDQw0Wj9K2xk080cEhAYYwCASMjgrXWPjn3tyytvly vwqhrDQtZpq+wUVcwtZO9ojeRwcnC7CTZS5Nr6aDgtmBLXAccDKlH4mKNk+kLPURtD5m1LQ2XGDg tK6y13me37QUt6qW/iKuiphIeocnGAf5LXvUnykvVt+FadUbWXKxVVEZR1U1TI2ISYwGuJxz+62d Rstc4bnDS5aTKwua4A447hd9qDcyx6m2uuUE03o3dheYInj5uprgWEH7f0XcX+9VlJs7TX+KTNzp 6aOVsp75OAc/cFO+XGztcusOc9Kxa927uGlBFLUt6oJBw8dgfZSb8M1jDBUXSaISUswdA7jPS5vI Xd7uEXTYs11UA+q9CKUPxzkkZXJ/ClU1IrrtSOe40Tmh4YewfjkhSz9Zl9rjbbcb7iOdxbFFdt4b jbbcGsZU1DQwYxhxaMjH3Xqbs3dW3B9K4YLWB4OO4PCN3aiWh3kulRTPMUrKuOSNw4wQ1vP8lYLc nUNTY9HWi9U/T+LkdFG8kcEP78eVu42+SYSMcuPinkt+VYL9tzdbXd4KGWFznTDMZA4IW7q9n7vT 0nr9GWAAkAeCrP3qlgrDparqImOndK1pdjv1MOQvBdbvUU+59t0+xrDbqmiL5A4ZOQXD/Rc5luco 6XG+lSdf6Er9LU9NPVNPoznpDsf4sZwuFIxlWM+Km8zNuFHYw1n4VkbKhpxyHfM08/bCroVvPHWm fFnzm2JQkULm6goCE0UdghCEAEBPKSAR4QUFAk0eOEIgCaSYRS8p9kA+6XcIlP7IylkBNAZRnjsk AghA/Cx8oTUAEFHlCsKO6MYR45QgEZQjHCASTAQgAjOUeMJIMvHKR7oQeEIAUk0DCKEDlHnul9kA mln2TB5CA7n2QE0digxxjuhPOUeECTx5QO3CPCiaHlHlJNFCCj7JIA8lNCDwgEd0JeUDRlJCAQjC Y7IEjyhPyqDnKXlPPul3QB/kn4R3SQMeEkI+yAQgo7FA0ZSCPKBFNqDhA90AUeE0uUB90+4WOE0C HCyJ4wkkEDSTQgSf80JHjhAykmOyECKEH6oPdE0yS/mkjOEAgITB4QBOPdLyglAPsimEimByn0oj FCEFA0kIQCf0SQhsIR590yqEhCEB5QjshAz2SR3R5QHlBQe6EAgJ/dIIAhBQhAeEIKEU+ySf+iD2 QJBQEd0QJhI4QqDumhLCoZSCaXhAx/VGEA8o88oBCZWKACaWE85QMJJhIEkoGn+qSMKibUgn2Qvi PeSSZSQafVZxYa08/wC7Khjypj1jJ06drMdy3Ch0fmXt/wAf/V5/N7I90IJycoXocQhCEAhCEAhC EAM5GO62lpuVdaqltRbqqemnAwJIXljv3C8VDA6eoYxoyScAfVWC282XhudofWahe+miLC4EcFox nJQQ2zUl6iurrpFc6xle8YdUNlcHkdsEr4z3i5VF0/iUtbUur+oO/EdZ68jscqZtvdrtP6kvV6tx ujallM7+4mhP52HscLy6a2j9TXlZZbmZDR07y0TNbjqH+EoI/OvNVGriqf47cjURtLGyesSQ09wv Yzc3WYbgahuePcyZUz02y+n49UzWWqr3iR0LZ4DjBcMkEfcYXudsjpUXMW03cNrnN6mwF2HEe4Hl WREBt3C1ay4fjo77cBUlgjMnqclo5wVpYNQ3ekvRu9LXTw3JzzIahjsOLjySfurGs2Ct001fSCuc 2WINMb8cfMDjK4/Sez0tVqitsl+L6eSFhcyRo4ePBCdCJb5qK8X26Mud0rp569jWtbPnDgG9uQvR qPWuoNRUMFLe7nPWQwf7sSYyPHfz2XRai0XSaX3IFgu1YPwRLHeuBjDXdifst1uvtBUaXtkV4s03 4+0OALnt5LAex+y0RDTic/ogcpvGO5WIUUeRynkJDknA4TczzylDCyHI44WDeD5X1p+XhQSDpTdX V2m7ZFbrdcMUcX5GSRh/T9AT4Wk1pqe56uuouN4fG+rEYiL2MDMtHbOFMeitl6HU2maS6Ulyb0yt +dmOWu8hLVWxM1FZpq+zVTK2SAdT4WkElo74x5VZvTg9Nbu6wsFnht1HXMdSwDDBLEHuaPbq9ly2 stSV2qb2+6XQR/i5GNY4xMDQengHA8qb9ObI017sNLcqa4tLJmdTuB8p8g/Za/WWxtTabQ6522dt bHD80sbRk9Hlwx3wr6TbkNO7z6vtFohtsVTBNTQs9NpmiDndPbHV37Lw6X3V1JpmCspKGaJ9LUuc 50UsfUGk5z0+3dSfZti4LnZqW4U1zidBNGJOoAYHHP7Lmdx9k7hp+yvu1tlbWQRDqlazkhvuMdwo vXyhWocZZ3vPBc4ux4CUL3xSB8bi17TkEcEFYk5d9F9aeMyOw1NNJhs+/wBq2ioIaaRlDOYmBgkf EeogDHODyUXLfrUdxttZQVdLbzBUxOid0ROacEY45Wq0BthX6qif6eYW9J6XuHBPgLkdSaZuFgul Rb6+Ex1ELiCMcH6j6Jpl3Ok979S2CzQ20/hqyGHiJ1Swuc1v+XIPYLY1O9Fz1JLSUV4bT0dv9X++ NK1wJYeHAjPI8qG/Qechoy4d04IXmQYBB8qpV77WLpHbrUbPWU11s7gCJZm5eGfR3nhRD8W9XTyU dkp45mGeOaQviB+ZoLRgkexXMaB05rK46ZkdYLpWUsUbXSRxNlcGuIGSMdgoo1BX3G73B010nlqK oDoc+U5dxxhaxvHdjFx5Wb+Gk9/uvvRVU1FVR1NLK+KaIhzHsOC0jsQm6lkLeGnPlEdM8jGDx9Fn TrtN9s+Ie9R26CKvtdFW1EbQ0zPJBdjyfquZ3F3bums6KOkkgjoqUY64onEtfg5aeexH0Ucfhpef l7L5iN57DnKmr7TpM2it+LzYbJDbq+khucdOcRSTPIeG+G5C5LUO5F6u2qxfYqmSnqInZgDXZ9Nu chufIH1XDyQSNAc5px9l9KandM9oaDyVBP8AT/ETUmniNdp+mlqWsDXyiUjqI84xwtPcN+bpU6oo 7jHQQiggbj8E93UMkYc4O7jPH7LlLnttdqfR38eEf+zxYMrCOQ09nLgGsIeAO6tNJr3C3ni1jpGr s9VYmRGUAxzCbJjcD3Ax/qoi09d6mx3ekuNJ0mankDw14yDjwfoVINj2suOoNGG82zD3NDiY/J6e 6jExP6sYOQeyQ0sLWfEFQ3O1zUNfptr4Z4ix7BPgDIxkDHhV3dJ6dSXxZHS7LfpzwgxvBJLSML5E Ac+6vxpJjJdxY7TXxCUtLY6Sjr7GZJo4xHL6cgDZMDGf1Ue6f3GqNM7g1t7sVOY7bVTF0lC92QWE 56c+48FRoz5TnupL212/qdaUNTNRPaHU7g17T4z2WbOtEmruJXZ8QFlZU+v/AGdmZIT1FzZWkn+Q XGU2+Fyptey3j0vUt0oEL6YgAmIE9PP+YZ/Vfer2OvQp5DG1pkaMge6h25W2ooayamqY3MmicWua RyCFrXTKxsfxDUjb3P6lslfapI2FnSQJI5BnqPsQRj9lBW5GppdXannucoAGBFHxg9AJxn64K5xz HD8w7Jem535clWbnr5WYze3xIPupo2T3Yo9GWqe33SgfMBJ1wTREBwz+ZpyobfG8D8pTiY/u4LOm lrGb86VjqX1TbZW/iH/mPS35vuc/6LlrHvlBQ6yvL56aWWwXBxlbHx1xPIwfuCq/O6mnkHlAY7OQ CR5RP4s7R75aepbkYILfUts88RbLEWtJa/3HPII7+y8mid5dM2KOupTQ1UUYqZHQSRgHqicctDhk cjlVuDSAMghBac9ioad1vLf7RqLVv8T09HJFDNCPXa9uD6gJyf1GF4trtVU2ldXUtwuFM6oo8Fkr W/mAPkfULky3HusfT+bIBPHsre/aySTUWS3O3R0rq7RlXboW1RrGt6qZ74wA14x9fZdRtZdblTaI gtl+t0tZQuja+nfFy4sPIBVR25aOcg/VS1o/ejUFh0/S2psNJURUwLY5JWku6fDT9lffTM1Fp6CW gttsmmbCaKnkYHOEuGjkYH654VA727rutWQeDK//AMxUl6/3avOqrRHQTRw0sbSTJ6GQJAcEAgk9 iMqKZHFziSee5V9TRj72cTzG7KstoLemhl0Q+139zoLhTQmOKZoyJAAek/Q5VZPPKza7pxjlZ1Jl Mvl03daWmvm9VsrNCRshe43J9OI5ong5Li0g4P0POeU9J7vadu2j6Oh1Z1R1tLhhw3qDsDAcP0VW nyEjuRn6ptkLQrbuSVz4zdv2tFqTc3S+o9G1luqpnNq6OQmlLmnEnRy0/qOPot7Q7q6JrtMNt1RU PigqIsSQujI6OoDIz5wVUH1ThISnPH9UnV2txlmq2dzljhu1Yykl9SnbK8Ru/wAzcnB/ZTvVbj2e 67EzWn1/SukVMITA4cuLXDkH6hVzLvKGyEeU3+3IuG8ePwsVfNxLPetinWoVIZdI4GRGB3clrhyP phYfD9r7TtgtFTT3iY0tbHK5zXluRKxw7fphV59RwzzwUg8g8cJv9Zj9Lx/a5faYt/LxY7pqWiu9 gq46h07CJw3uHA8E/ouv3D3AtOodo7XFTVA/GwGAvhOQ7qacEKt73lwHumyRwaRzgfVbnksymf05 5eKXCYb6XHotdUGprNpiCy1UTrpE6KR0D8g5a09Tf5Lti63VmrKKpka+O5+k1oa5pw38xxn91ROx 3mts9wgrbfUOgqYXh7HNPYgqwFF8QVPJFSyVlnH41rGiSZsgOXDuQMAjP38rlJrHUdcr8ud+Kt4O vIA3kfgmf+Zyg08Lrty9WS6t1E+ukyI2NMUQPcM6iQD+65DK6+TLlZpz8OFxw1WKEIXN1CaSf2QM BIoQgEEoSKBoQEIBGUIQCAhJABNJBPKJWWM8I7IJSzlAIJR4SRTxlCEd1AHugJdkAqxKeU+6xT8I EmcJIQPKP04SCaBIQmEC8oR5TQgPZCMcJIphJCEDQEkzwUBlBPKSED9kFIc/ZMoDwkChAUAjKPKB 9UACgoHdA5+yB+EvCEfdAJpFGUAEeUICBpeUIHdAIT7pZ5+yoEBB5R545QPyl2R44R/JAfUI+qMI QNJA7pIGjsgcFHjKAJ/VGOEf6IzygB/VASQEDPb7pBNAQBSCY7pdkDSHdP8Akj2QGEj3TJ5SKB9w jCB7oPHfygXhMYwkjygD2R3QhEAGUICD3QhkISPdAQPlPPHKxQEB3TS7HhCA8oQmgSaSCroHZMHJ SxwmDgcIEUx2S7oCA+6E0kBlHhCPsgCUI+6EAjKEygSaSEDx9UuyMo8IoByEZyjAQgEZ4RwgIgR9 kIVgAn9EhwEBUBQhCBoHdLHCMIH5SKE0C7pgI8oygP1QeEFBQZDshIdkcKibgkO3KE18R72KCg90 INBrUBunqsu7luFEDcZUu65IOnqknjgBRCO69v8Aj/6vN5vZISTXocghCEAhCEAhCEG10wQLzS5/ +SN/qFb3emaWk2WdLSvfFIBAOphwcE4PZUzoZ3U1SyVmA5hDh+ittpnUdo3c24m05UVTKG7siaOh zhhxbyHDPcZ7oqG9kbjXW7WdNPRRPmJdiRjTgubnlXGrXx09PPc46UvmbAXlrQOp4AyG/dQDsBp2 mtmq7pRXSWOO8W9/SGdQw5v+Ye4Ug2vdCnqd0KvTVRE2nZGTC0veMOeDwWn6jwolcNtNfpNSbv19 e8ztie57oopnZMTS78v0Uj7oWuhq7VerlDKW3y3UgqIHRnEkRbktI9wVr9P6Pgs+7VyuNJURuZO3 8Q6HIDm9ROcD2W21DouS8a7ju0kzmUf4ZsD2Mdy7BPBHkcrTL5bOX6u1Np+a5XQtNY4Nie5owHdP AK6ew3O2aiYK+hcySale6CTBHXG4HBafp7Lz6boaG1XC6UFvYyJoEcnpNPYuHfHtlQzsFXti3G1F RST9D3yyERl2Oohxzx5Uy6w5fO0x7ysvrTgviLLnbp1RHcQRD+SnXZom4bTmGu/v4vTewsk5HTg8 KH94LcLvvdJbzIyJ1Q2FjXPOB+VTNUVtq2p0F6Fxmz1tLWRjhz3EYPT74yu/l1M+mPHu+PXypRc2 Njrp2MGGtkcAPYZXwjBzkr7V8glqZntz0ueXD3wSvOHY7Lndb6dZvU2lfSm0N81JZKe520QyU8wy MHkH2K2FZsLqxsT3xwxuc0ZDQeT9FHGn9Zag0/Tup7Rd6ykhceosjeQ3P2W4G6Ws28t1FX/q/Kiu PuNLPQV09JVxuiqIXmOSN3drh3CwgP8AeBfa6V9RdLhPXVszpqqd5fI93dzj5XyhwHDJ8oLk/DSS 3Q0hOcCRdJZ5rXouz3WaquMEsT5XSuDHhzwCeR0jnytZsNa5bdoaMSYcypaJY3DsQVVnX9LWWbXN 0o7gx0UonLgHZ/K45BH0TxTWFtvy5eS25yfGlsdknRu0nVvY4GF87y1x4HSSf9F6LXLbNFaTrv4h cIJKYuc4Oa4OPzZAGP1C+WzNsqLboSKCcAmVnWwjs4EHCqJqKCrtWqq6grWviljnLXNd4y7hav7b yWdaxi3e0LWTbeOj6gI5PVaHHgAEOGVnJHTaK28q4LvUNNOY3sEoHUPmaen9OyNBW+a07ZSU0wAe KWR4xzkFhIK1emJGai2VmbXu/FMFNK0FxyR0g4/ZTHXKbZ8lvG36UtqWhkz8Yx1Hsui2+pY63U9B TzDqjklaCPcZXNSk558FdNttO2DWVqdI4Bvrt5/VSus9LqVtLJprTMUen6H15njpHSPyHALXEeRl arWOlqPVen6K6XekbDc4A0S4GCRkBw+3K8m92qrjpPSlsr7TP6Uz5xG44BBb05W9hvH43beK51sz SJImySScAAZGSpqxNyox1ttXY7TqDTs1I0imr6gwTQnt2BBH7rQbtaG0/oW96fuLBIbdVVBjqocZ IaAD1D9Cpm1/SzXD+y9bRt9anpKr8RI5pyAzpb832XAfFVTS1OmbPWwRmSlhnc58jRkNDgACfuum E3l2z5LxxlntJ+hIbPT6eL9Pzie3ub1NLQeODlQNqLRenLvrigZpq6Q1TK1zxPEw8xPHPPtnKkT4 cLnT123clPDK19RTlzZGZ5GQccLR2nb12jtTW+/yVTTRvnDZA/gxl5wP5rPrG1e7nJ8NrWbbaJs8 lLT3aojp6mZvyNkOOs9jj3XgqNmrZR6roJoR6tnq/lcM8sfjj9CtxvXpy5XzUFjqbfE6SKly5xb9 XZ/oFINWD6NnYDhzJYi4LXqTV9p8OAqdmrDHWRyQgujaemZn0PYqNtxNpG6d1DQVNE0zWmpla1zR 3ac8t/UKfbtVs/jt3pfUDZH25sjW55PzO5C9FzfAW6fjqy1zZZAw9Z7u6OP1ys7EdnaLSlwpWxRO dHJIzLWkEFpIUP2HSdv05uhLp7VcwhgLf7md35Tn8pP3Vnpq+4Qa0goXRM/hD4G9MpbyJPbq+vCr l8TdPLS7h01a5rmskpmtY7HBLSc/1WpjuWpuzKRYm5Wu2HQ0tvrJ4m218XpOmJ+XpyMcqmO4Vkpt Oa0qaK31MdXRgMliljcCC13jI8jCtqyJmptnIIKR4eKunYwOac4ORn9lWTdPb+t0VcqT8UQ+lqyf SlHuMZB/dSScd77Xd56+FlNsKNsOgG1NgqY3xTQF5Y8ZDXhpyFBe02hYdYXWtkqBiKKUmRrT7kqe tm6Ge3beNppmESem5wHuCDhR58NEopNRagttRhlS0l3png4yQeFJ1jt0x7y03J2i0i+qkovx8P4j q9P0zKOoO9se6rtuno2o0RqeW21HzRPHqQSf52Z/qpp1doO73jda5VdL6tPFJP1xztyOkgDBz91F 2+FLqK36hpqHVFY+seyL1KeV5zlhPIz37hXLU+XPG79o2B5U8fCpUTM1fURRyObFJD87AeHc8cKB +59lYL4WKCX+Ovrw0mDpMZd7Fcs7qdOkm1hHR3Ua3Eomf/B/QAMefl6+VHuoduaHVeu66tBY2kfC zrczt18/zXXUl+qo93KyyOf1UUlDHM1jv8LskEhe/SVPBQ3fUFHTu4D2TdJ7tLgT+2V23xlrzT9r IjWp2RstZSyQ0tWz8QWkx4eCc/Zctt/s+2unuEN2HTJTSGMjt0kc5P3Ck+y6j1BW189PDYKSCWIk NmdkdYBxn/6StfZ59Rs1Zc79BTsADm09fbw7If0j8w9jjt7rPKtztprhsba6ugmZQVA/ElhdGQc8 +FzOj9p6S+afr4nOEd7t8z4pofII5HH1Cl6a2Ut8gqa3TEk1rvLAXM6m9OcjkEeQVzGxctwm1Zqm S85/iQe1k5xglzRjKSq0NTshQ1+n3y2+YfjhH1BoOcOHdp+ueFqtDbNxV9ufLc8xuDi0Z45HBCln QdNPT641a+ZrmQy1HXFnseBnH6hbCZv4rRV/ig5k9WpaAO4K17ykZyy448oiq/bGUsloqZbTOH1c beprWuDgceDhaKwbS0d70ZFdKZx/FROLKiMHJaWnDgR7qRtgqW40FtuUV1Mpk6mlpkcScfr9V7Nl /km1gzgAXOU48YJWcLyl/wC9NeT9Lq/W0f6j2Qgdp6Sts7+uaNgkDQc9QxlebRGzdPdLFHWVb+l7 8HJOAAeMc/VSbshUvno9RCV5eI62RgBPAaDwP5ry6KqLhZaOrp71H+L09UzSOika3JgJd2PuM/st 3Gbym/TOGVykuvccDrLY38LZZau1lz54R1Fnfqb5S0lstFW2WGoqn9EkgDu+B0nspM1BR19s0/Pd NF1XXE5p9ane3rBaPLQexx3W3N0joNtaC4tpPxgbDETC13SXZPvg9li5a01O91B+4Wyklu0/LcLS 4zPhBc9nfLfOFXuXgq8TNSyy6ara2CxTtpXRyNfG54yMNIJ/n/JUgq+kzO6e3USPtlLWsXxRlIoR oZJTykl3QZB3uEZWKFBkjKSRQZA4QThLH7oQPqGQn5WJKaDLKYeQ3GVghBk45zyVie6Mco7FAkIQ ihAKAhA8pfZNLCACD3T7BLCAygo7poF9EIQEAgITAQJGEEIA9kShNJPsUCzygJkpKKEIygoDyhHh PyrEoSQhAJ+EghAIzyUI+6ATSQgEd0YQoDwgJZQqrJJAQgPKAEIzwgPflH0ST8KAQjCOyATCSEQI 8I+6Q7IGhPsUHuil2CCgo8IAcoR5QgEYQhAIQgoDwkmhABH0SRhUZJEJBNAAjCXhM8eyO4+qAQEs JjsgX6oCeUZ/VAkICEBnjCeeEk8IDhL7ozkIQCPKfGPqkgY+qSEIBHlCPCIeUu6EIoTJSKEDB4xl JCAgPCfZIpoEgJFMHhEHlHOUIzyihCEDkog+6PKCjKoEDCEeEUITCRRAhBQgEcoR4QCEIQCEI8IG l5RhCAS+yZP1R44QH2RzhMHCQRQOQhCSBoQhEGUeUfZHhUJMI7oVAEZ5R2QEDSPdHZHdAwg4S8ox 7oBDUHhAQMpICEGXhLKEKib0HsgoC+I97EpJlJBzuuiBpyp6vIA/mokAyQpZ1/xp2c/Uf1USA88L 3f4/+rz+b2SaSa7uIQhCAQhCAQhCBxt6nAL2wGWF4fE9zHeC04KLRSOrKxkTB87z0j65VltF7Q2W j03JXavGGlheTnBYMZ49ygre2oqYp/XbLK2Y/wCNriHfusvVmfP6znyGXOevJzn3yp+2s0No3VNw vlD6zqmOOQmle75HmM9jj3C+2kNoYWa2uFBdqaWS2QOc1jzwS0n5T+yCB/4ndDM2U1dWZWjDX+q7 qA++V6BerznIuFePr67/APqrO2/bPRv9rK2ySNkkd6TZ4SCDgchzSfcFel+2+3zL8LHK58dxc0Ob G4kB2e2D2J+i0yqt/GrtHUmoFwrBUFob6nrO6iB2Gc5wvIKuthqfxkc87akuLvVa4h2T3Oe6tmNk dNVTbhRuErZGY9OXsWZHH7LkNFbPU41HcLNqaJ7hEzrhlZwJG88hRVe62urbhOKmrqZ5qgAASPeS 7jtyndL1c7lDFHca6pqmQ59Ns0hd0574z9l31507ZtJbrS2e6SSSWZkjQXEcta4efsuj3g2hjtVp ZqHSchq7Q5odI1pyWD/MPotWWdVJZZuIJcfmIyljlZEBvPusc+3n2WWgRlGeFkGnAwMfdYkHv7d0 BjK+jGl3buvkDkrYWeMSVsbT2JGUHQWHW+p7LRsorbea2npWklsTXnpGfYLW6ju9zv1wNdeKmWqq iwRmSTuWjsFYut2Poq7StPcLTI4VxiEnpHs/jkD6opNiaSv0q900rqe4GMvY7xnGQCFUQZZdxtV2 aijorfe62Kli4ZGHcN+gytLqG919/ub7hdZ31FXI0NdI7GSB2ynPZ6mOZ8fp8tJaSB5C+H4CobJ0 OYQ7wCMK6TcdPa9zNWUFrbboL1VCkawxtY4g4aRjGfZeax671HY6Cpobbc5oqOoB64eC3kYOAe2c rSfwypa75oyPbhfKSjma4sewg/ZNHTxvOTyiOR8cjXMcWuByCDggr3ttkzhktP7LBtBIXdPSQ5NG 46G+6/1BfrJDa7vXPqqWEtLBIAS0gYBz9l9LbuFqKh01NYYq9zrVIxzDC8BwAd3AXOi2zvafkJ/R fMUMryYw0gj2Cmjp3Gnd2NV2G1xW6hubxSRZDGPaHYHtk+PovJXbl6kr9OVNiqq0TW2ckmN7AS3J zgHwAey48Uzy/oOcg4IwsZYXxP6Xgg+xCelbvR+rbtpG6fjrJVOgmLeh4xlrx7EeVudX7j6g1bFB HdakFkJJHpt6M5xw7HfGOPZcN/iwvdbKKWumbHG1zjnsO6JUj2revWVuoIKRlwjkZE0Na6WJr3YH bJPdeG87sapudxoq99b6NVSHLXxN6Q7nOHDsQuwsWydZeNMTVI/uq8N6oWO7Px4UQ3OzVlBWy0dV C6OeJxa5jhyCqbdBqrca/wCo7nSXCsqRHWU7DG2SnHQek+OF677upqO+2OlttwnY8UzmPjma3pkB b2OR5+q4j8HUNBzGePosG08rjhoJPthE6SjPvhqiqsrrdXSQTtdGIzKWYfx2d1DyCAcrQa33IvOs 7NQUN69CY0jupkwjw/OMHJ85wuS/BzhhcWE474C+TKaVzvkGT9k7Xp2+gN0dQ6LppqS2zMkopXdX oTt6mtd7t9srX6/1zddZ17J7m9rWMwWQx5DGuxguAJOCRjK5s0NSAXOjIaO/C+bYJHuw1uU0dJX0 vvpqay2altwbSztp29DZZWEuLR2B+y5Gv13dHa4dqi3llDcHODyIMhpOMHI9j5C5k0U7WklpwO/C wEEjj8rcobTa34itRYBdQ257z3PQRz+6jHXer7jrC6fjLnIXYJMcYOWx57huew+i0LqWRoy5pGF8 CMEZycKEH2XfbX7i3XQs1UKGKGopqjBfFLnAcOzgR2XADupk2d25pdbWaomEwbU07+l7POD2Kf8A a15Lru3d5tdUmqKWnggqYYRA6HJLJGZOQf3X2dvLeY9cf2io4Y4PVhbDPS5Lo5AM9/ryu8uGwEkl DN+GnxOGksyOCfZV/vNmq7ZXVFHVROjnhcWOBHYrV+XPq2JsHxF14PFlowT/AIg45XG6f3fv9n1b VXcyfiYqoBs1PKflc0Z6f1Huo0FPIMZBTdDJkE5ws6aWAb8Q9VhwFkpWuc0tD2yFpGRjPnspC2BM 9wpqzUFVP60lxPTI/PPW0Y5+uMKnrY3NHIPKkXaeu1I2vNssNdUU8U563safl484TSJq3N3UrtF6 gq7ZPaonmaNzoJ2uLSWnIDs+4P8ARRVofeW82C41z64C4UtYTJJC84AefIPjPla/fCnv1Hfqam1B VPq3Mh9SCR/J6HHtn7hcNpqgNzvFHSOdhs8jWF3tkpYmKc6z4gy6kqI4LIymkkjLWvZLkg+D2HYr jdu93a7TN2uc1ZA2qiuLvVlAPSQ/3H3Xk3V21qtFx0lU5/q0lSSwOx2cBnH7KN3ROB/KcH6JNyLZ uaqX9A7vO0ver2/8GZbfcJTKxnVh0ZyT+uQvdoze+psklypK6j/H2uaZ0tOxzsOh6jnp+o/ooSdE 4Y6gQmI3HloJH2Tu237MZJNRYW7b/Qus9VBabUaOqlA6ZQ/LRzzluOcjhaXb7e6osdomtt6ohcaU O6oPm6TGM5LexyPZQk6JzcuIK+fV900uli9Qb+wT2Gqp7TbXU1VIOlpcQ5uDw4EfUFV0k5eT4zwl nHuvp6ZLeBlVY+KAF9Cx3sshE7yEht8UD9l9Hxuae3C63brR82r7s+hgkEcgYXjIzkDuhtx2OMpr u9ydv63RU9N+KIfFUA9DwMDI7hcJ2KaJS90wPuvtTQPmkDGNLnOOAAOSpY05szdLnaYq2QiIyH8h HIRUQ9PGUsFdvr7Qdy0hUsbWx5ikGWPA4K4wROAyQU0PnjnCfZZ9Dj2GFkInE9kV8/CS+whJIxnP surZoa6u0tLfDD00kZGQRyQfP2TSWuOCCvs+Mg48rHocOMZQfJC+nT+6Og+3ZQYAJ4X1jjL3hvuc Lv6/a2+Udkdc5YWGFsYk4OTjGVZN9Q3ruo6wjyvq9hDiDwsfTJGQmtLvb5pjsgg55TCgEcY9ls7N aZ7tWR01LGZJHkAABdVfttb5Z6F1VU0hMI7lvOFdJa4FC+8kJZwRghY9GAOyG3zx+qeCF6aSmkqa hscLC9zjgADJJXRX/RV3slBFV19KWQSfld35U1U3HJFH7LJ7ekkFYKNAoQeyAVUNJH3QooQjkoCA /mhLymVYlCEI8FAISamUAEIQgXYpo7jlHZKEmhAPhQIBHjhPKECCaB3R5VB5R5R5QoD7oQeyEIEI yhFAQhHlAYQOEeUFEB7ZR5R9UFFBCEIQHdCEh3QPyjyjwhAJpYQUAhCCgSYKRHKEB4Tyl9EKhk8o /okjwgB3T7pIBQB7oKPKMoBBGEBNx/ZAkZQhAIzwhAQCEIwgAEeUIHdAdkI8oRBlCAhAJnhJCKAj zyhGEBlCAEHugEIQQiBCAl5RTQhB7qgQUI8ogQUIKAR3QEIBHlCSAKaEIAnhCEIBCEHCA/0QgoQB 7IygoQNIIQijuhHZBQCEimCiBHZHdCA8oKAjwtARnlGOUAIBMd0ggIGjKWfdCAygJlI9soGkgoQZ eEJZ4Rn6IJvRzhJC+I95FLwmUgg5vX//ANz03nt/VRLxlSxuCenT8rfctH81Ewx5Xu/x/wDV5vL7 LymhC9DkEIQgEIQgEIQg3uinAahoWnzK3+oVrviFc5m0cXQ4tcZIRwcZ+ip3Q1MlLVRzRO6XsILT 7EK02m9baf3P0BLpzVFbDbLlHGOmSR4Y1zmj5XAn+YSexGuxLrnBrWmltbBI5v8AvGO7Ob5VvLtU VFNa6qtoaUT1jIetkROC8gZ6cqAtgprBZLvdaC6XGjZc6WYtjm9UBkrAfzNPYhdNpzd6GfcmvtVz qaaG39Rhhk6/kLmkgOB7chRK53Yi4y3fcu8108LoJJzJI6FxyYiXZLf0Ug7rx2qrsd+ZA9g1FSwR zxAHErSDlrmeTxnsvLpmh01aNx7tX0N5ow+oaJTGZm4PUSSWn7ra19k0/cdZ/wAdqrnQyf3TWNj9 duQWjHv2VSns9da68aQkrbnKZazhrnuGC7pBxlb3R+o7bqugFbROYainLopWH80Z8/oV5LPdbFTX G8W+irqKOT5ZRC2Roz1NPIH39lDXw93+hotXXy311VFTzSSPDBI4NDiCc4ymV1hue9rh3lq+tOC3 7y7di6YGcdA/9yFYTbIB+z5bKOppppAQeRjpKhXcCnoLpvtU0tdVxQU074wJXOHT+UY5+qlzWmq7 NttooUEJbUyVETmRRseMOyMOIcMjjOV18uXLLccfFjZ49fKmVUMTvx26jhYR8OzgLKd3VKTjuSV8 vI5wubtPSddEbM/2p05S3SjukBbM3lnBLT5BWzuXw7XH8K91JXQOmAJa04AJ9lAtFcqyjaRS1c8D TyRHI5oP7Fesaju7AC251o/+ju/6qq8Nzo5rfcaiiqmenUU8jopG+zgcFevT/NzhH1H6rX1E0k87 5pXOkkeS5znHJJPnK9NrmEFZFK44DXAlQX2jvFPp7QlJc60ONNTxM9Tp7tBIGf0ytpa7rSXe2T1d vkbNTdDnMkZ2eC0nP3Ud69uNPWbBVFRSTMkjfTRkFrs/4hws9g7nT1u2cjYpmOliD2yN6uWnpPdI lb+xaNtNPZopBbIqyWYCXBIB+bk8kLzao26tF3tLpmWz8BWUv96x2AQQOSDjuCE/WZrfbpsGnLj6 VUzojc9j+l8TmnkHHIWkqNKSWHTxrb1qWugqIj80j6hxid7A8+ey12w6p2jNPVlspI6iihjknjb0 Ox/jxlaTWW2liu9oZPTwxwVVKcOkYOHdPDgV0Go7/b7Pp+z3Suna2gbLD1St5a0EcH7LP+L0dTo+ 611HPHU0wfPN1xHqBb3Kne2vhzN7tWktE6coqq728zQve2MPjYC7JGRkFanXmjbFU6bpNVWWkZC+ jcJ3RuGBNHkZafqt9rS0xbj6CtgsdTFLH1Nka/PHDcY+4Xs1BSxUG2n8EuFRHTzTR/h43SHAc7jh dJx63XPLl3p84tLaVloaW/yUcVNTyRB0gkIDRkDGf1K1d32+0/WT2y/2uBjGCRrZWNwWyNJx444W +1FY6yr2pqrNTDNZ+ELGAH8xGCMffCrHtnrq5af1DS0FzrakWqOfpnge4lsfPJx4wVy71tu65ad9 v7oy0WS7WCttcAhkqpnRzMH5SG4IP8ytlvboeyQbYfxenpWxV9O2NzXtGOrJAIK73c3Scut4bHV2 uVktPC90we05DmkDGP2Wt37Y6DZ6sikGHMbE13/iXbGS2SOOWWUx3/VMT+b9VLPw6UFPcdaMiqWB 7OnOD4KiV/BP3Ut/DTVxwbhU0Urw0zNLW5Pc+y4PStNqE3qjqqSCxU8Jpoy1zn854PzAjyCFp9b6 EtF/vNsuEsDYquV3TJgfnwM4K5LeLWVy01uLYqelrZKeiqWN9VoPy/nIJUlahu9LQSWCetnZHHJU BvqPOAS5uBz9V04Wac5lym3B6jp9vNM3SO33pjaeqdG2XBjy3pPGc/ovD/2VWKfVNLW2maGa21Lf UDWODgCBn9iF7d0Nu6nVetaWvGDRtgbE8/Yk/wCqy0tpyh291jQxNuLDS17TEInv5jkxluR4z4+y XqMzsXyn25sF5barwY6arc1rul8Z6cO7Hq7Lx0u0dmj1e2qoZIprbUM9WNjXBwGOSPtg8J7ibbVW ptwGXGTP4Ewsjfx7ZW00XYabQesoKJ1wbJTXCNzIGSP5a9oyW4+oPCl69Lj3N2Nw/Qml2TGI29/z ccRZGD9VwtFtZarVuJ+FlDDR1bDLSscfzY/M37hdndaPV7tXTNo7k6CyvIw1rAS3jk59lpr3YK65 arobfdr51TxtdNbp24bIHjHUOPI4OF0smPyzjlcvh7rhpLRFDW/gq6NkL5HdA62YHJwOewXK2Dai 127XtRRT9EtI+P1qUEgh7c/MB7kKTKH8ZcA626stsVQzoMRqmDPX9ceM/wBVHNHoBlFraajpbs+C qiH4m3zh+Xd8Ob9ceQue266Kt0Zohlc621gZFNIegNkYWAk8DBPCq/u/o52itYTW5rg+mlb61O8e WEnj7hXEiZNfYZLbqq1s6iz0/wARGch5H+Ie3uFUne+xVOndYuoKiqfVwemJaeR7y4hhJ+XP0wiz 2jpuP2VhvhLc7+0le0OPSYhkeCq9ZVl/hStr2STXMYMT8xO/4SPdcfNvj07+PW7v6TfR2yqj1fU3 T13uo3xBhi6j0tcB3x7rjxoqzao1Hcr1J0TU0zRnDfyuaDn9eFsNO3eZu8V9tjpv9mdSxSCInjqw QSFvNKupIavUFvpS1skcheYweR1N9l68t48v/TxY47mNcNTbfaL1NSVNNaJ6eWYNPzR/mYfqtTRb TWyo0NXxVkYZcKQyt9QDnLRkLebLaYrtM3e5PuAIZOS5pPjuu1oJY6uj1LSwva6YSyDpB5+ZnH7r E1tct8dz2hmxbbWq+bQC4OjEdc2nfIJMchzQT/ovd8O8Wn622Us0L42XymcWSxEYLm+CPcFd7om3 z0O2dVap4y2sihkYY/JyDg4+qr9sNVMs+6kFJWO9Fzi6Etfx8wPAUneFv9axv76/iZN+9P2W+W+r NVVw092pqUyU7XuwXAZOB91XrZIW+XXFFBdCGxT/ACtcf8L/APD/ADVj92tv3a1vTpWSuifFTNYw g8EknhV42009UjcxlDgfiLfUH1Ge/ScFTKddGN3btMXxRRVEWjrRDI9j4jU/KQOQQzv+y8ejdv7F qrQNDdaKJn4qEATtA5Lm/mB/Rb/4oKaSo0Jbpo2lzIJ2ukI/wgjC+3wxTMdoCqAIJbK/qCZXXGT5 Wf65W/DWag2ksV50zPU6eMb5oh1tMZ7+4Kel9qbFDpiGpu4iYHgOMshwAHcAZXUbHStfpW8NDsub UzNP07r76rpJLxs+yChIe97Yx8vuHjP9Ff8AzuH0zv8AWZfbj7zs9YotO1/W+KNxDnwVDjgdiWjK qbM0slc0925B/dXM3tL6fZbGS2RkULT7gghU0n/3hx3WtfpMvswyuWeWPxBBGZXtaOSThWf232xs 1y0dRVN0p2sqjkP6+PscqtdhkZDeKSSX/dtmY53tgEZV6brUut2l7bU2akiqWSlrnNOcBpb3GFz1 bdR0t1O1d939tYNIXOgroB1WuokaCByB5Iz9sqQ37S6dfFbbrCWfwuoALnZ+UdQ+Un254W6+I6J1 dttQzwMyyKZkrukcNGD/ANV9oXh/w5zFpzigOD7EYW/nCfbH/jll9I/3O2cpqK0w3KxtzH1Bj2tO QcnA/mum2v21Gn4qW5STPgr43Nd1ZwCCcdP+i7G2VDXbNUMz3Aj04nEn/navruM6sE9gZb8/gpJ8 1IaMgsyDn91i97i2cbP6jj4uG5tFj4GRK8/+5CqwArW/FrDJLZLVPG0mNkji5w7DIVUiQHEZ7Lt5 Nccb/HP/AB96yl+3e7KUkVbuBaoahofG+Qgg8+FY/efWs2gaSmobVE1s88IfE/AIaQ/ByPsqz7QX WC0a8tNXVvDYWzhrnE4DQTjKsN8Relq7Uk9nq7aBJEyMsLhyBk5z+y5+DV8lmXrTf+TbMMbj721U uoaDdzRlLbahgg1BBK0uZj8wHdzT7H2WxGx1kDWB4cX9AcR188+cJ6J2/j0lXafuXqEyvmMU2e3z N+U/uvVvbbrrUa3tFRbWSOgihYJHM8fOSf5KTpduIu+z1Hada2ylq5C22V5LGOJxh+MgZ+q30ex1 ujudRBUueI+lr4skDIPcfout30cP7OaWcTgi4Qc+ey+u9lVJBQ6WdHI5pkr2McQe7S3kLePdkLuY 7iLZ9oqS2a9o7bVyFtHWteYHE4+dozhTjJpOl/7PZrNI1rWPiEJccDIBGCuC+JuY09m0/OxxbLHU uc1wOCD0Erpcz3bY2H8HITUz08Ya4HkOLgmWt4/1zxzy4269IMtu29FLulW6ZrpC0el6sBDgOrz+ vldpQ7E0frVUdTJJlknS3nHykcFaWl0ffrRuXZay4SPmeHtPqDOQ0HBH6ZUkb+apr9MC2y0LcxSO aZCOCCx4cOfr2We8vJcMfiOmVmOGOV91Eo2aqI9bG2SE/hgPV6gOS0nA/muxk2EoCS1sspOcd84K 7jb7Xls11qhs9FFJFLDSua9kgHYnPGO+D9FzHXfG72zDNSLUaz2+THSPP3TD95v6ZyvGyIB1/o+p 0jqF1DUctOXRux3Csvpetku2wMtTWNY6ZlHJF1Y7howFwPxaNaNVWQsA6nUzs48/Ou+0dQVFLsHV 0ksbhOIZh0Y55HCklx/yPHr1WfLd/wCL5PuKcVDf9o7+VP8AbNEWS5bESXuGKMV0NM97ngc9TDyP 2UC10ZjqXNdw5pwQp3tOmLjQ7ITXO2XGYU01O6eeDqyw54dwuvmn/LZv5bls8W5N9K9yD5iPqhvA RJjqI54KTT/Vc/l0npaD4YtMUNXYKm6zxB1RHK9vV5wACP5qVLZcaXUdxqbVV0YbBVU4qKd5b+Zp 4Ofsf/tLhPhRqY5dEXSBjgZWzOJb55HC7DQcz6ittAkp3wy2+GejlLuxIwRj9CsYZWzZ5J3qIku2 zrLlX338DJ0SUdQ6NrAM5+UOB/XP8lzOjdoKu9yVJqy6BkWWtwOS4KWLbW3ak3uvjqLqfbnzsbUN PLMdDRkfXJXd7gSTWLT9XWWOmbNN6pL2DwCCCRj27r0T9sph9vL5M748PyfCvm0WnLdb9x7vbLw6 IVNAD6QecZLTl364KlD4laOmi21pXU7W4FRGGuA7ggqucbrrdtV1FcWyyVj5OuZzQcjgA5/ZWP35 pZaraW0wwsc9/VEcAZPDCp4+v8jivku/DyU2n/3ruF8yF6KtpZK9juHA8j2XnXG+3qhFAGE0lFCO 6ChABCEIBCEhwUDSQRzwn/RVAg90kIDyj+iAjhAEp/dLhNKDul+yEeFADuml4QEDQUIHdAdggo/0 SQNCSaELsmjyhFId8IKYR5QCXlBKPCAKE0kShMH9kkFFNCQQgE0h3QgaOySPKAyhB7o8IDKEd0Kg 8oQEBAFHhGEIAFB/dCB9eyAS+6aEBn2S5T8oQCO6EIBCEIBAKEIBCEIDyhCEAhCPCAQjCXdA0IR4 QHZCO6EAgoHdCIWcJhCEAhCRIwgZQl4TPZVQjKQTCIAhAPsjCAQhCAQjwhAIQUBAefujwhBQId0/ CMpIo8J8fqhBCA4yhJNAIRhBGAgO6MoQUCymhHlEMJeUd0eVoCMoKEAjsmAl3QBGUD+SPKEBlA5Q gIGke6aR9kGQKOPqjHCWE0JvKSaS+I94PKx7lZeUuxQctuIf/hef/wA4UUDupW3HOLC72L2qKhwV 7/8AG/0eby+yQhC7uQQhCAQhCAQhCDKNpc7hetkUmMuGR74Xq03bzc7lDTM/PI8NH6q0ts0FpjR2 j3VOrYYJephJ9QgEnGcNPufCCqpje3DsH7rP0nycgEqyOy1o0Zqll5tz6Prb6pdTtm4kERJxz7gL Z7fbTw23VF0ju1E2a3xvc2ISc/IT8p/ZVNqwNgmOMgkDtlZCGb/Lx9lbzTmndHVGrLpZqe3wTxsY 2Zj2ODg0nPU0/UEL2TWfQkOov4FW2sU9S8D05HtAjeSMhod7qpVNnska75weOxXyfE9h6xkHOcg9 lddm1+mKumuVDNQ9LOvDXj8zMjgg/RcnoXaahtt4uds1BSMq4S3qp5iOHt57fVOhVN7ZJcuJc4+c nJXyle/pAc5xA7AnspUuFHZdGbwVVDVUzqmzQz9BidyWtP8AXC67efaiifZm6p0SPVoTH6k0DfDf 8w/1CtmujGyzcV1JPPkpYTf3SaMnhZaLPKD25X09Nx7BYujLT5V0EDhfWIdRIC+fleq2kNq43EAg OBIPlNDYQVFxZSOpWVFQ2lPeIPPT+3ZfOira23Of+Eqaim6xhwjeW9X3x3VudGaG0hqDSdHdfwJa 4w9UjccggZP9Cuf1vtRYNR6Omu+jyWVMDXSNDm4EgaMkH68Jtmq30FzudCZJKGrqYDJy8xSOZ1ff HdFff7tWU7oKq41ksL/zRvmcWn7jKlj4fLXY7/WVdqvlOXyPHVE7H6EFanfrQlFpPVdNBaOr8PVQ er0HnpdkgqybuoWye0bOvdydbvwL62pdR8f3JkJbx24Wdtv1yt8EsNFXVMMEoIeyOQhrgeDwvTDp e5zNDo6SYtPIIYcFeWos1ZTVIhnheyT2c3BU0dPRbNUXm1ROit1yq6aJx6iyOVzW598L7V2pr5eI PQrrnWVMbT1BksrnAH3GV82aZuT2hzKaU55GGHle/StHHb9VUUd5p3iAyNbLG5pB6T5RBT651TSR siZe7i1rAA1pndgAdl5tK19F/aunqNQPeaSaXNRJ3PzHlyn7dzamxR6HmvdjBjlha2RuBw9riBhV quNvqaBzRUwvjD/y9QxlBb/T02j7VHB/D9YsbSt+ZsH4shuD46crhd/dyqG6WyXTdlIqon49abOW 4BBaWuzz5yCq4MeQew4Xe7SWKLVGp4bfUOA6gXAHzjwkuvRZtwz4JD/gKyo556OsjqKWR8M8Tg5j 2HBaR2IVv6vbjRFqqYKa51EFPVStBbHI7HV4491Fu8G0h09WwXCytM1tqCAQOSx3/RIvaK9Ralu+ oXwSXqumrJImlrHSnJAPjK+tbrG+3Czx2uvuVRUUUeOiOR2Q3HbCmSp2dp5dtKm5MPTXxxevGcfm IHLSoHit88s3pMY71M46enkLXfuJuXp1dFulq+kpoqeG+1ojiaGtBdnAHZaLUWqLtfa4Vt0rJaiq a0MbI44cAO3b2XzOnbi1pd+GkOP+ErzwWmrqer0YXPLPzYbnCaq9Oupt3NZxwxxNvtXhjQ0cgnA9 /daO+anu97uzLnca2WSuYG9Mo+Ugt7Hjz9V5I7JXFnW2nkc0dyGlS7sVoW3asp7jFc4yXRnDT2xw ppHKxbv62ZE1jb1UHA7lrST+q5i66tvVxvTLvUVsor2Oa9srMNIcOx48qfLTspHR6nlhqm+rQj5o 3Y/M0n/RR3vRtyNK6jijtmZKaqjMrWju0g4IV479JuT28Dd69atHN2fn/kB/quXq9YXqfUDL3+Nk ZcmSeq2Vhxh3vhaqrtdZTN6pontYfJbhEFsqp4fUihe6McFwBIU0vSQ2b3606gTc8nv/ALsYXB6k u9bfrnNX3B5lnlcXE+BnngeAvm60VrIzK6GQR4/N0nH7qZNjNF2PWFrrKeua3+IU7gSCeXMPYj7I IHOQBxyut0Lr6+6LdUCzVRjiqMepG4dTSR2OPBXt3M0TLpjVlbbaYPmhY1sjCBnDXDOCuHcOk4P2 OVcsddUxzmU3Hdzbl36TV7NSRVDIri2MRucxuGuaOMEL0x7m6hj1Y7UVPUtirnxiKQBvySNHu3yo 9hA6x7FWL0NtFQ6p29gr4fkrpGEtP1HZN7SzTl3b6avcxzTNTFrgQcwg5BGCuR03uFfdO3yW42+s eJpm9EjZPna8eAQfbwph0XsnHW0lQy7NLZCSxvjBChHVemKmyaiuNsDXPNLM6LqAznHlNfSR2B3r 1Ob3Dcg+BszIjC8Njw2RpORkduD2Ue3281Fz1DVXZ2IameX1yYvlw/3HtyvLPSTxN+eMtPuW4WLK OeVmWxuOPIBKkjWolKDfTU/8H/BVDqef+69IyuZh/bGcjz9VwVh1XdbLqWO+UdQfx4eXue7nrz3D vfK1L6KaMf3jHNH1GERUczwS1hI9wCmk6SpqTeu86hsVbaq+mpHU1VGWOAYQW+xB+i53bvce8aIF VFbzHLTVIHXFKCRkeR7LjHUskRHW3GT7Jx0k0mSxhIPbhNL1ZpIWit07vpWtuT6L0nU9e8yPheCW tcSeW/urI7dXCK76LZV6XrYutxzUU0g6hHJ3Iwe3+qpS6GVhw5pBHgrd2C63azl77XV1FKZAA8xP LerHbOFbN3bPUmlpviHuDGbXzUtVIwVb2sPSOA4h3zdKpy85dldNfr3d7zDHHcquWobGSW9Zzye/ K0X4OVzc9Bx9lbd4zH6Z8ePG279vK04PCl7QO9d705Y2Wqoihr6aE/3XrZ6mN/y59lE00Loh8wI/ RfHqwfKzXVM1VvTca2yXW011FTz0NWX+m1xOYWuHDQfoey1mnt17hbtA1WlqqBlRTva5jHkkFrXD t+hUW5z5QTlTWrL9GkrWndq4U23k+lp4BJG5jo46gOw5oOCP2IW+03vzcqCxQW650UNdJCCwTvd8 xbjABHv9cqCxwl5T52qYNU7uz6h0JVWC4UbJZHnEVSXHqY0OBb9zjhQ+e6ZKxKqSa9G1xa4EZGFN mgN8LjYrGLXdqdtyhix6DpHEOaPYlQl2TDuVP6utpl1/vLX6hipo6CN1vbE5j+lr+oBzXZaQcBdd RfEHFLb6YXK1tkq2xhsrgchxHke2VW0nP3TDyOCUqaTBuluxLqttHFRwmmpoOh4jLurEjScOH6YX 03A3cdqnTNnphSmGuopWTOk68hxa3HbHHKhsn65QD4TZpL+626MOtdNWqlFM+Grp3iSR2cgnowQP 1Xr2q3im0zZJbRd6d1dQDDoB1AOj5yRyDkKFSUDIUvev4kx0sDX76Nm1rQVv4MvtMLXB8LyA8Fww cHnsQCsd0d27Tq/R9VQNo5W1Z6TC9+PlIcCefsq/EknlZg8JOruLcZeq6zb/AFlW6P1JT3OhJIae mWM9nsPcKfX776emm9V9vnY5zusng8/fhVV85T6j+iRdJG3f187WWomVUYDYKbqbASMHpJ6sH7FS zYN9bOzTtLR1lHMHmFrZ+nBBdjB74VXi4numHYz3V33L9M5YTLG4/FbXVdZT1morjUUILaSSd7og e4aTxldjp/dC52vQVXphzY5aOZr2DqHLWuHIz91HDj+iXZazy55cr7XDGYY8Z6BJz4yjwkUZ4Wdt O32v13X6IvjKyjcXQOw2aInh7f8Aqp8u+99ihtVVU2qKRtdJhwY5oxk8O598fTwqnBZl5OO/CiWL EbW7uW6hpboNQNldXTSumbOAHB+WBoBzzwWhffSO+DTd7jBf2F1uq3Oewjkxkjtj2P8AJVxDyO2E us8+U+ds3Hc0m/RuudPWjcrUk1RE51nr3EQSADLMcjj68hSpWbv6Qq6KCkqHSvhi6eklvtwqdh5B Cz9U/VXd3v5OM1x+G31rUUlRqu7S24g0b6h7ojjHyk8LRZTdy7KR7qfLUIoR3QEUIS7o8oDwmCkE Z5QMpFNIoBCEIBHnhAQgEICCiAlAQgIAfRNLKEB5STR2Q0AhAR5QPlH3Syj+qAT8JI8IQBBQjKqg JpBCgEZR5QfogOcITCSACaRQgAhHhCA+yEIQHlBQhAeyEIQCPCCkqBA9k0IBCEIBCAhAI7IS5QMo CEIBBQkgflB7o7IQCEIQCEeUIDOShJNAYR4R5QgChB7ICAQl5T4QCXhNIoGjKAkUDzlCSaIEk0Hu gXlHZMIwqbCQTQEAjKEeUAhCOUBlCEIDCEIzkoAjCCkUyil5QmhAk+yAhAsJ54SQgaEJIAHlNJCB /wCiPshA4KIEk/KBwtAST7o90BzlHdCR7oGhJNAe/wBUJBGUD8peUFCDIE4RhHYBGfqU2JvR90BC +I95FJZLE98lBye5RxYmj/5o0f1UWNGThSjuWcWRufMjVFw+vsvf/j/6PN5fZIQhd3IIQhAIQhAI QhB1G3Dg3Vdv6jjMzf6qznxOZO21u6f/AJZjz/4SqhUNRJS1LJoXFkjCHNcPBCsrpvc3TWt9Dv09 r+dtFVMbiOqI+VxA4cCOxCJXMfD7RXN+q457dI1hj5eHdns8hWm1G64ssVbLZmMNxEXVC14yHOHO CoA2P1hpLTD7jb7tcoI54ahzYKstPRMzPcHwvdoveiFuvrpDqC4Qstcr3Mhma09GGkhp/UeUH1+H aWap1ffKmrj9KqlLpJGAYDXFxJH7rsd2bhbbjp++2aEgX2L0pIoz+ZxyCHMPfOPZazT+qtv7NrC5 VlLe6WB1QBIeSWO6s5wff6LaDUW37tTy3x+obfJUva0BrnflIGAQqzW22rqqybQTpq6R762Nrup0 vLstBxnP2Wx0Bq6j1hZ2VUOGVcPyTRHu0+SPoVoKbcfSDDeadl5omOcHSNw7DX9TT2Pk5UU/D1re zWS43SivFbFSCYl0Ukpw09+MpfS4++3D70sc/de9lvcTj+isdppuNlZOr/5Rlz/4CoJvlx09X731 090rY/4RPOHNqGnLOwwSfZSPunujY7BpZ1m0zPT1sk8RYHROD4w0jDskHg+V0zsvkmXw5Y438fH5 VOlGHH2JSi4kDj48JyHJ/VYfXCxe67TqLCaI260dqDTlLXO1DTQzyN/vIpJWtcx3kEFbS6bKaano pW0OpqJtT0n08ztILvA7qtTHlvbj3X09d/uc490VlX00lHWz0s3SZYXujdg5GQccFOiyZmADyF53 Oycnz3Xqt72R1UbpM9AcC4DvjPKC8Oy5bHtpTvkBMYiLngdyMHP8l7xPSx7fVlTpdnq0/oSFrJfl JHSc/qvBtzdNPQ6Igp6W80TqeaEgF0rWluQQQQfIyvhWXexaQ29rKaW6U88LY3sa6F4ecuBA4H1I TDqzbn5JbjqIR+G7nXbSAQCzI/ddxvrTx1e6unKeUB0b4g1w9wXlcr8NlVaBfal9ZWw01bDzGyV4 aJG55wT7LqPiFLKe6WXVttqqeqjo5GxSxRyAkDJIP69l08Vkyyy+4nklsxn07/WdwtugNM0NWy1x VcUkrYeknpIy3OcrO+aes2qdNUV3moIoJm4kb08npJGWk/qvDcKmwbp6Hofwtyhia17ZHMe8B8bw MFpC9mo9Q2nR2h4qerrGStjHpt9Ih+SMEA47Zwufw3/2+Ovrva9vbJbJ/wCDx1sU8hhABDXNw0Ef dRxre+aJ1tp6nrqHFv1DTPBbA5hDnDIy0nsfopE1BDY90NKWqWjucAhjf6mC8BwdgAtIK5rWukNG 2a1278RVQ0dZJK1kUocC1xGM9RHbgoiTTbGXbRdNQSAFksTOoH2BBULfEXcdMUunHWCOnZJd4yOh 7Bh0BGCCfcEZUqazvw0zoI3Cjnilko/TI6XAh7OoZ/TCjTf622TVG3cesLa+L8ZG1ji6NwPW1xAI P1CuN9ypZdzSrJJGQF0+iJrrSXeGtsfWK2mcHtLRn+XkLmThd1szqej0xrOlqrq3NC/+7lOM9IPn H0UbsWQs+pNMbpW2lo78G0WoIvkdE75XB3ktPsfZaLWWrNR6EvlFbNSU0VzsbXAQTdHS6Rg45Pbq AXV3nQVpvWo6HUlkqII2lrH5icOmTHId+oXN/E/dKE6To6B88ZuEUrJWs8lpyCQVZNsXpKFVeKKD Qst3ipC6hbEZTBkZLeOP2UQaCo9Pax3Iq6+10L6WlMDH+jIBxICcn7HhdftRqK1a022ba2zR/i4I xDUU7jh2OBn6g4XmzpXbvXVB6dWymdWN9KeJ/AjyMsd9ichYtv45J72kx15Lb6029bftN0WtI9NT WlxrXta4SADpPUFra3TVr0vuTQTQUjH0N6D4ZYccMe0Z6h+62d10R+N3Ag1NFOxzWMYGgOGCAP8A 30azr6Ws19pmjhlBqaaZ7pY/LQ5o6T9jgrv5NTfH6cMM8v1mXzWwmtlmsF9p6CaibJBc3OMGAPkc 3HUD9MEYX00vpek0zrK4fw8BkFZGZfTH+FwyD+i2OprW+4ahs1UxzQKCR73AnGQ4Af6Jx3agqNav p46mM1cUDw6InDgDznHkfVccLb7emX0xoNV26rvtVa2yAXCkm9J8R/Ng9nD6LndcWeWv3MsszYGz 08FO4StPblx/mo2ornBQ/EtXMqJGsbPII2lxwC4gEBTPX32hodwae31kscctdTD0A88Oc1x+X7rt b+O2RxwnKS157voqz3221dBU2s07ZGkNeQCQfcYUR7HW+jg1LqDSd1pmVDYZXCOQjtg4P78KZbR6 9p1BXC51XVS3Cc/het+Q12c9P0+i43ROm3WvdLUFVK8eu5/rFnn03n5T/Jc8stYX7dMd3P8AjpG2 LTcEsVkqIIHzSdTejjIZjgkfvyuH2w0uzSW795tsBzTmnZNEf+FxOB+mFynxN09zs2qrVqShlkgY 5ohjljJBa9uT/qul+HeuqNRTVF/uFYaqtY0U83UfmaBkt/TkqeWax1PlPHbbvJIFy01bjf628XZj PRdGxhc/sR2HP3VO92o7THriuNgBFC4B3SRjof8A4h+6t7HqCjveqr1oy6xAxmBssRz+ZpGT+oPK qBuxp/8Aszra4Wxr+uNhEkb/AHa7kLtldy8vbl4dzjr/AFcrBy5v3V39j5RTbVUc7u0cRkOPYZJV H4cB7c+Fc7ZqsjqNmP7lwLo6eRjgO4IaVw/8pHoztmFyiQ9OXqhvPTPbpGSRTRiUPYQRnyD7Fc7Q 6SttXXXe5VUAkfNUyA8AnLVG/wALFyikju9IZB6sbuoMzz0nz+6lGy3KK623UNut9U1lyp6qUODT 80bj+U4VvV057628F40DYb9a56I0boZHt/u3vj6S13grRba6Lssen6qN0Mc9TSzOhnY0Aua9p5z9 xyFt7LZ9RR0NR/F7/VNmaMskP5R9SDngLUaJtchNberHcI33qKpfDcIScslcDz1AdsjkFWVd16Lz pLSep7fV2uANguDW9UXqx+k7q8Yz3Ge+F59udGWMaWfI6COeSCR0c4aA5zXtOHArpdUWWn1TpmZl 1p20FfFl0cw4AJ7fN7E4XL7bWZ9stX8U01VMfUiQxV9MX5a94OHZHgjuClpGWo9F6Y1VZayioRHB cIm9cfWBG7PjGe4PZa3aLRlJTaWdFfbeTUNldhwj6iQu01ZYoNS6ae+oiZQXWnyWSA4BPgZ9ivrb aya6bcxTWCYNuAayNzmHJD2nDgfqputSIu3y26ttLZ6e+2qIRtbKyOZjRjIccZx78rsrforTOn9M Ur7pHG2B/SA9zeoku7BbLciKpve19QyAGasgDHStHJ6mHLv6LDU9GdW7b2n+HODur0JD0nt0nJC6 4SXjuuXkzuOFuM721uodv9L0em5I6tsUMVQ7+4lI7l3LQthaNu7HbrJStnpI3EgfN0ZOCMryb6TO otu7bK/IMM8DnD/lPK6G9VlwumjLTW6VqmNleGO68BzS3HI5XOf+PftqZamV16ukebv7Y2qr0dVX S0xBlTRtLyGt6SQO/CqZJjq4V1NZRajGgLjUSVTJaltM8yQ9AHUMHPA+ipU85Py9vC3lJx99njyu WV3OiQkUlzdmWUv17pJBBlwllBQgOyaSEDBQe6WUIMgkhHlFPPCCkEFA0ZWOfdNAyUZSQoMkspeU IH3QjKSB5RlCSDIHhPPKwz7JoHlBSQgyBWJKMoygZOBysUEoB5QCPKO6EDQkjGED8pIKEAhCPCAQ go8IAIQglAJIQiGkhCBhHhIIzygfZLKflIopoR7IzygEx2SQgaSEIEn3KCkFQ0JIUDQRkIQgEeEJ d0An4R90IBHdHdAQA4R3RlJAyhCEB/ogIS88IBMIQqBCEIBCRQgaEig8hA0FLwn4QCEkIHjKCfdJ NAI8fdCPCAHZLyn4QEC7J+EkeEDQjCECyml3T8IEmhGEAhCAiDuhAQgCkeE0IpDun5QhECEIKAwj yjPCXcoGjwgoVAgoR5QGEBCEAgIQgEeUeShAFJCEUx2QAhJA0EJJ/ZAIHZB+qPCA8oS5ynkIEnlC XlENBQEFAd0IS8LQaSaEB47oRwhAI8IKAgEFJP6oBCPKEDAxynwsTlGD7oJwKCU0sL4j3kUsLI9l j3VHI7mf/EWMdv7wf0UXDJ/ZSduac2aLj/2g/oowHle//H/0eXy+whCF2cwhCEAhCEAhCEGcLS53 yhbAUk3p+oI3ln+bp4H6r3aItf8AF73T0ZdgSuDVaq627Te2ehgbtRxVPrgsbG9mRK7GcZ8ZQVKf Rzth9T03+n/m6eAsoaKeYZjY5w84GVZrYabTupbZd7TUW6JpdI58cUg6umNxOG5+gK6bbnbSDTt2 ubqyCCWmLndDHDqHRyRhBUmO1VrmdTYnke4aVn/Cq0DLo5ce4blXB0JUaevGoLxR22300tDGWvif 08tdj5m4P1XtqLjYqLUb7Td7HFSUr3+lDXFuYnuPZpOPlKrNUqnoqmFodJHIGnjqLSAvm6iqBH6j YnmMclwHZXoj0Zp+vttfQVNvhdTOlc0Fo5APkFc/oLbik0/PcrfcaeKrpZD1QSPaD1M9j9QiKax0 8tQD6LXPI8AZK8socwkOBBHBB8KW3Vdu0PvPcmMomTWuOqdGYD2DCfH2Xcb47Z266afGr9JRhjRH 6lRABgObjlw+oV/jW9TdVmPf+aSD+6GguOB3UUuEZIX1ED8flKxcxzeCCEGJX2pozLIGsBLjwviC vfZpfw9fDMACY3h2D2OEHpjt1ZHnETx+hXwnE0ZLJQ5rvY8ZV39M2uwXTR1Pd5LTH1CnMkjQBklr cnH3wuV3A2/sWtNDOu9npfwdZCx0kZIGXBoyWnCdM/KoHU4OyM5B8L7GeRzS1xcR7Ert6fbS+1Ub ZoKKQxvGWux3WtqdEXekukdDVUksU83+7Dm4D/stG45hkskeQ1zgD3wVl60jmkdROV2f/ZvfvxJp zRSiUDIGPC0l207cLLXtp7jTSQyO5AcMZH0UHipW1fSTAZAD36SV8p5py0smfIfo4kq1eyOhrZLp llwrKcSSFpL2Ec+VoN29v7FfdMM1PpIta6N/pVETe+c4wR4IKFVyFdUtiMfrSmMjBBccYWArJmwG ASyCF3dnUek/ou0/7M7+9gMdDIQee3daqn0ddZrq+2/hZG1jBkxEYOPdXRtzODkn9kgCDzwF2kO3 t8mfIxlBKZIzhzccheWh0Zdamulom0kn4qP8zC3BCaNtNTXevp4hFDVzsjA+UNkIAXxrLjU1mDVz ySlow0yOJx+66kbe3w1BhNFKJAMhvT4+i0senq2S6m3eg8VWekxuGDlDceChrqqgl9WjnlheRguj cQSP0X1rrnV17w+snlmcB0h0jy449uVv7hoK+0NI+omt8wiYMuIbnAWusumrheRMbfTvmEQy4NGc Igh1PeYoWRMuVYGMADQJnYA9lImy+uKGi1X6mrKuQBzAIqqTL+hw7A/QrjINCXyaF00VDM9jeDhv YrX0GnbjWVhp4KaR0zTgsxghLL8pue1jd8tZWO8aU/G6f1AG3SkcC2OB5aZWuOCP07qtzr9cv4gK 8VtQ2sAwJmvIdj7rdS6Gv7YnONunIAJOBlai2aeuFyqHQ0tPJJI3u0DkJ3rRNS7eOuudZXV34yqq JZKrIPqud82R2OV6rjqS7XGSnkra+onlpzmJ73kuafoe62VVoS/08TpXW6foaMnDOy5eVpY4hwxj g57hRrp0VXrG/wBdC2Oru1bK1rg8dcpJDh2IPuvs3V2oJK9ld/Fa01bWemJfUJd0+xPsuVGScAqy uwOgLbd9P/xKtibL1OLXBwzjCGkI33Ul8vNCKa6XGqqoGu62sleXAO9wtfYr/dNP1Ek1oraikdI3 pf6TyOoDwfdW4o9G6F1M2rt1vdTyztDmPDGYdGR/qq56125ulgvNVStp5JoIn/LI1uQR4WrLLr6Y 5TU/rnZ9W3qa9xXd1wqBcWNDWzh2HYHjK8OoLtXX2vNbcp3VFUWhhe/uQOy9tXpW60tMaiWinZCB kv6eF1e2GhJr9e6UVkMjaR/zBxHB+in9ampOkakEO+oXQ6Z1de9PwTwWqvnp4J/95G13B4x2+ykX f3buHS1wpaq2REU00WZQG8McDhRvo22mv1BRxCIzMEjTI0DOW55TKa7qTKZemFkv1x0/cm19qqZa apwWlzDjIPcFe+j1pfKG/T3ejr5oq+oBEsjT+fPv7qXd+tvbVaNMUF6tLGREvayRgGMhw4Khdmmr q6mbUNoagwuHUHiM4I+6vG6l+0lm3RS7r6tmgmhlvFRJFKwsc1+CCCMFaTTGrL3p2rmqbPXz00sw 6ZOl3Dx9Qe68FXZLhR07J6illjhf+V7mnBW622tTblqugiqoTLS+q31uMgNPGSpZpZqtpW7p6tq6 SWmqbrLJDK0tcxwGCD9FpdL62vul5qiS0V80Pr49UA8OI8qTPiD0Bb9MQ2q42poZHVvdE5jRxkAE H+aidmmrrK3rbQTkHkH0zhDcdJd91tUXa2zUNbXvlp5hhzS0c85Ws0lr6/6YFQy018sMc56ntzkF 3vz2K1NVYbjSxGSelkjYO5cwgBYU1kr6iISR0k0jD2c1hIKaOnaUG6+qKW4VdQ24uJqwPWYWgtcQ MZx7kcEqxmgL3adR6PgnsVwbb6luG1UBcG9L8cnHsfdU2mo56ef0pGOY8cdLm4KmrZHb6S9mpmuA lijaA0t5acEcH909JkkH4kr5SP0Iy3mpY+pcY3sc1wcHkHDuR5HdQTo/czUmmLe6httY4Upd1Nje OoNJ74ytfuFbKmy6grbdUOe4QTPYxzs4cAe632yOmKPU2pxS3SMvpjG7B8dQ8Jl1rG/DOHzZ8vNq ndTUmoLYaGvqWmMnqBYwNI4xxj6FRy4YUj71aOh0frE0FJn0JYGzsHfpBJGP5Lio7PWSRh7aeVzT 2IYcK6dJZpq0fZe59tnZII3RPDj2aQcrJtrqust9GTqHdvSchNLuNclhemqpZYHYljLT7EYXnI44 U0pJIKFABA4TSHZA/CSYQUBnhCSEU8prHCaIE0sI7FAIQg91FNHlLPKfZAEcIQhABBHhCPKAHHZC AhAYRhCEAhCECQPqn4QUDSPCAUIDwgo8oKAQgIQCEIQCAcISRDR4STQJPKEkUBHCEIhoPdCQRTQU k0CTQU0CPZA7JZT8IBCAkgaPKEYQCSaD9EB9kk0kB2+qZRlCACSEwgEJHumgEgmhWBJoQlAkmhQL wmkhUGOEeUBH3QCflCEC90eEeU0AkUZR5QAQhH+iBpBPwgIA8JA5TCR7oBNIJoFlB7oTQAQjCD3Q AOUJD6ICBoQShAJdyjumiEU0j3TQCRTQgAgoSPZA0FJNAIQUlQ0HshCAQkU0AEIQgEIP0SQNAQhA FHdBSKKaXZNIBA0BCEB5QhJA8o8pJhAIKD2QOUQBCEKgQhLyqGUinlCAwgd0A4KEAgH+aPKMIBLG UykEDSKZQAgAl+gT8I6j7IJx8oP0R5QviPeR75SHBTKRVHG7nn/0RD4zIP6KMQpN3P8A/iXBn/5I P6KMgcAr3+D/AEeby+yQhC7OQQhCAQhCAQhCDs9ppWR6ytoeQAZgOVYj4qml2i7HjsKvk/8AcVSa Wd9POyWJ7mPactcDggqwemt3rJqDRUundxYJpSG9MVVEzqceOCfYhCl8OtlrZb+2tp5nQCIZ+jx5 CsfquK41em7iyw1IguQjzE/ggOHOD9xwq97P7p6Z0tbq213N1QOiVwp6psWfUZk4J8g4wvjt7vSL Xqm5P1FV1NTb6lxDJQzJAGQ3LfsibdX8Nfqurrw6oBbKSesEdnc5/mt/uhdYdRWy+aVpKd/8Zjmj dG0NJEgBByD4K0+nd1tAW283GohNRSmch4e2Alr89+PBWxp91duaa8VNzjrZxV1BBe405PI7Y9lZ EvbqdFmot+2chlL2VdNTvz1d2va09/1C9e2Wr4tZabgrC306yMBs7PBd/mH0K4SbefSE1tvtG6rm a+YSmJ3pEtf1tOPtyVH+we5ll0tHWUN+kkgikPXHM1pcPsVbrX9Zku7v047dGB8+6t/EQJJrH4A7 qyVYDHsdVhwwfwLwQfHyqAqPVunBvBcrpcy+az1NS57JmtyWgnh2PZdZvDvHQz2g2bST45aWaPpf MGkAtIw5paRx91Z1njn9LnLl47h9q4SYGQO+VlBIGSNcRkA5P1XzecnhIHxhS3d23OosbpGl2quN hpZ7hcY6Wsc0CWKXILXeV6L9praivtlRDR6ipYKotPpvBPDscZ+irY15Cfqnt5QZVDPSnki6mvLH FvU3s7B7hfa3NLqhuO+V5CST9VsLHUMo7lTzzs64o5A5zO2RnkKC9G30zKTbGnmlj9SOOmc97P8A M0NOR+y4e3bwWS6GnstioJ6YyyCMsmALCw8Oxg+y3OntwtCv0jHQfxuCCKWEscyQFrmdTcEH7ZVV KyqbpvWk0tpqY6qGkqS6CZv5ZGg5B/ZTGajNne15bjU2+xWqlEtVTW6E4DXzNy0nAOFyGvLnpy76 ZlP8Wt8l1pR69JLE4NcHjkY+60jNwND6+0lRxX24xW+eMgyQTHBa4DGQfIXi1dqHbel0/T07ainr fnDPVpCPUj+p9wtT0ne0lSXanotFU+oLlAHvp4PUe6NoDiMDKjTce/aT11tvNXUtXS/xWl/vKduQ 2UOBHBb3wQumrNV6JvOiZbK3UlCyKopzG0ukw5uRxkeFTmbqtl1miEjJfRlLOphy14B7g+xU10vy vBtPXxV2haSqjg9KQRYlYOxIB5H3UPaFrqKq3buVDZ5JxY61wlkppDx1g8jHbg+VIG2WttHQaSpo o71SwCRgD4ZXhr2OxyMfqq/PvUOgN2JKyhniuNAyX1A6J+Q+NxzjPghWT9b9kv7d+ljtw9ZS6R1B ZbbR0NNNDWEsc545Zg4GF9dxbfT04supKWFkVyhniYXtbw9jzgtd7ha66XfQ2thbrvJe6WJ8Tepj ZZA1zD3IIPlZ6z11pMttVrq7pE+GV7C2eN4cxjmn/F7d+6ueXc4/Tl4scpvn9um1jfLTpS3C9XCE Rsma1jixmR1YOMj2Xytv8Bvd3td7tElLLPIwMlMJBy0jsR4IK5Xd+qsWqtv6qhor7bjU08frRD12 nrLRnH3KhP4fNY0Wn9Xtju1Q2npKkBoe84a1/wBfZNSYY35bm7nlv0tlWfgWTTySwAS0YbIXNaOW u4/0XH620HQ3LU9nvFBG2GuDiXOa3Ae0AEEj3GVptU7n2Ozaqq6OqnE1FXUsZZUwOD2tcCcg4W41 XuVYLQzT9ybXQVNG+QslMEgc5jXNA6iO+Ap6PbsqeBk0zqSqbQTEMHXG385BHct+qg7T9FDpDfqq tlrY02+rjD3ROHA6hnA+ykervmn6C8nVMN5pZqeSFjJWRyAno8OA78Z5Ue6+r7VZt07DquO5U09s rcRSPjkDvSwByfpgq9cb9tYf7zfpKFfUU9j1fQ0MNNG+G6l2Wkf7tzcZI+hB7fRZxaUtNNrOapgg Y2SeMyOAHAcPP6rj9x9V2ih1fpK5uroH0Rlex0jHhwb1AYJ9gt/qHXllsmrLTJVVcRoq9j4hUNeC 2N3GCfoc91vKTc/6efxW2ft9ua1FuxQac1rVWWtsjZaaCUMkniPzNacc9PnC6HRFDpi73muu+nms fBLhx/u+npf5GD7jC+dTpjTVVqqe9zV1FK+odlwfK3BC0ll1lpTS24tRZ6WpbBS1gDT1DDI5gcfm 7dLhjn6Lk6pKcKYTva+OgMPUWnEgDgM+RlVF+I3TtDYdch1p6BSV0In6WEENdkgjj9FY1mlLE/Ut Zc5K6ll/EyOe6P1m45Vad/WWuHW72WWoMtM1nTJG459OQEhwH0PC01ijVgwQrm/DQMbefdzj/NUy ByeOFZb4YNeW+npJtNXKZkFQ4l1O97sNf7tz7/1WbPS5dyz7bT4fATuBqck8GZxH6uKkWzVMV013 qKzV1OyWnZFG5rj3GWnIWGjdL0Gmr3W19PUxF1S5znN6xknk8Lw7f1cNx3Nv9bSkmGSKNvIIIcAQ QQfZd/JljlfJlPl5u5fHj9RtLC223OvuumauhY/8F/dOk8PYW5Bx74P8lxW3V3p7Frq56KmphNHT zF9JODhzWnnpP2Uh26ipbXqm73U1EY/EcvBcMgtb2VbrpragtO+0l9jl9W3yPaJHtGSGng8e4WMt cc9f+nTxd5YbTRvbqiz2cPtt+t76qKsp3hkjMfITkfyOCqybQ3J9n13bpA0SRvk9J7Hf4mk4Vu77 brBqynbc6h8NVQupupsgIdhuMk/sqxaHt9lbu/JQNq2Gi/EH8FNnAcc5aDn9lM7MsJpPFjlhldpo +JejhGhKKWHqYDUN+XPBBB4XXaFobeNubXNXQscwQtDyRnIIAWt30tEl725mZREPnoW+u5gOSQ0c r46Uv9JVbIx1lLI2Q08GXsBGQW4yMKZW2ePGVrGcZndOhumjrNeLJX2aSFhdG35Tj8ocMtKrVs3M 2x7p/wAPmiE8EkjqWQfYnDh9lZLRWqrRqGrrJ7bWRyGSkgJZnkHkYx7qv+11JS1m8ddFUzCKqjqJ JIWuOOpwccj7reXfhy+5WfHqeeb9WOz+KqlbBa7E+Jz8GZ46S7jhuQcLvNB3Oz3vRlsq4IGzTiJr JIhw4OGAVoPiZtslw0dSXCIZjt8vqSjz0kYXYbfQW6PR1vqrSyN8c0LS0tIAyRh37FM+8MTxdco+ Ouxp63WCVt3pmNbUM9IR8Fxc75ePfBIK1u1umjatHU9JXUZncxznNcAM9JOQCvVqHRjb7Z6t90eT Wxh0sT2/lDgM5A8ZwMr62+4M1noCilsVb6dQ3obI6J2HMc08tOOyxdbk21jvW6j34j9H0FHZKPUV BC2CoikY14xgkE8fzXfbMagtupLKyooKcwVLImsqG+OsDleDdqjfqja2spaN4mrKP/fMBy4OZy7K jj4V9UUNHc66z1czYpqsh8HUcB5AwWj6pnr8eNnvaePdzzxrzfEVdtO3Onnp6Vj473R1ZDz0cPGc OGf5rH4V6uB91r7VUREvkaJopR3YR3C7fdzQdpn07eLjUPiguT3SSxPecdTgMgZ+oC434WKCGS5V VzEo9eDDHxZ5DT2Kx57dbxb8OM1Zky3otkdbvZZ6GqJkgmiiaer2LjkKWb+zTOirbb2XSFrI5XGK MtYDyBnlR3v/AAus24On9TSj/Yw5kZd9WnJ/kVIG4lhh3CsNlmt1Ux1MCZhI05BBbhd98vLJfWnH HePilnvbR7nadtTNOUWrrfTMzSPZK4dIHXGXDI/ZdDeLXpy20NNqienbHQPjaJfkyQHY6f5leLc/ 0rZsxV2+eRrZG04Y0E4Lukjt7rz6/rYZtghPG4Oh/DwkkHx1Bc8veM26YX25H4hNFW12jYdSW2Ns ZYG9WBglrjx/VVckHS4hXF3jq4qjYZssLw+N0EJBBz5Cp1N+d3K1Z/x42+zC/vlHzPCSyKxKw6gJ lJCDLwjKSEBlNJBQ2EIKAgaSChA0kITQPsmUk8qGx4T8JJIp5QhJA0IQOyAQUvKEDRlBKEAgpfdC B5S8o8o+iBoS8poBGUijCAymkEIGjwkE0Qk/ul4QgaX2QjHKAyj+qEeFQwjykhRQhLCaAPdCEfty gfhJPCEAlhCaAQkhAeE0keEDKBz3SQOyBpJ5SwgYSQjwgO6EI8oBAQgoBHnhCPCATCSCgEICFQeU HvlCEAEeUDKCgEIR2QHhCMoQNJHhGED8IJ5QkUAgIR90DKXlCPKA48JlJCATSTQCRTQgPCEYCQQP KEgn5RB2SJQe6EAOyf8ANIoCAKEI7IGhAQVQfdJNAQIJlASQCaXhNAZ4QhHhAI8d0IQCEk0AewSQ hFMdkBJNAHko7JE8oQNBR5QSgCjyl5Qgf8kkJoBHJQhVB4R/VHlHjjyqD7oSTQCSaECT+qSaAPCP sgoKBfdZJDsgIAowfog9kZKCcQEeEHshfEe8seEnDhZFYlWDit0P/iZTAf8AyT/RRq3spJ3R4oKY f/NP9FGoOAvf4P8AR5vL7JCELs5BCEIBCEIBCEIPpBEZHcLdw2G4upDUxUk76YD5pA0kBbLbO0RX rUdLRTkiOV+CVaLXt0tu1ujYYIaNk0tUHRRh8YexxAGQ4ZHBB90KqfJYLi2i/GtpZnUvmQNPSvpQ WCvr4nSUlPLKxv5ixucKy/w93ug1DY7jZaukgY4lzhGG5b0OzwAfbK7HQOhoNHm4y4bJH87g0NyC 0AkYyrtFRafSF4ni64aOoeztkMOFlLo69xDL6KpDfJLDhW22wv1HqC4XoUNOwW4y+rE18YDmEjkf uvVU6nNnv00Go7bTQ2OWc09PcGs+Vr/AkHgH3V2lUzrtO3KihE1TTytgJwHlpwvk6xXGSjdV09NL JTt/M5rc4V7YLNa7lZqmkqqWCeinlkaAACC0ngg/0Wq0Toum00yvt5Yyeikd1RGRuT0nwfsnSXak FvtVZc+ptDA+Z7RlzWtzgLwVMMkEjo5WOZIw4c1wwQpZt99Git4btJQ08TqMV0kRgI+Xo6uw9lI+ /u39tvelTrCyRNpqmOMSTR4wJGf9QnzpdzW/hVXJIyk5ZFONnWcAZKjTAJke/detlHMfysP7L5Sw SRHD2kH6oPlj2Xst9JLVziKEF0juA0BeMdwu12ojEms7a1wyPVHfzyg009nr6Wf0p4JY3kZAcCMr OpsVxg6DNTStD/yuLTyry6i0baL9Q04npomVEQa+OQDBzjkH6FK+2Ky02lpGVtLEaeBgcXOAy3tn lJ3dJbr2pKzS92e0ObSTEEZGGnC1dXS1FHOYamOSKQf4XjCu/qWopNL6Zo7hbbMy60rvzemeWsIB DhjuO64Tduy6f1ltlLqO2xxQ19JGZWhhHVwR1McO/CumVaaOwXOqpxNTU0skR7FrSQtVW081LO6O ojfHK3u1wwVaP4YKuOvsdXbqumikZCeqN7hyM84UffE3U2qTUkVFRW4U1wpciWZh+WVhAIBHuOVc ZcpbPguUmUl+UKskLXcEr7Rh0jwBkuK87eykrZLTEOp9Simn5awB/wB+eykrWnKwafub4w6Okmew 8ghhOVrqhksUjopg5r2nBaRghXQ1XetN7eWqCGup45pmtaWwNwHuaTgke+FGu7mlNPats9s1VpOW JpqpW08zG+57dQ8EFLGZlL6V0Ez2jAcQDwsCOVKNdsxqOGkknjpxIWt6ulvcrmdJ6JuGpKyppKJg FTAMvjdwU0u3KukcQA4k+yybI8Nx1Hp9lJNLtBf6uKX0oWh8RLXMOc5C5mj0dcZ9RGySRGGuDiCx /CaTcc+2eRowHuAxjuvZRUVbXQH8PDLKxv8AlaSAu2u20eo7db5at1L6jIh1ODOTj3wup+Gmqij1 PPbKunEsFQzq5HLXBPXdWd9RC9QJYiYZw5rmHHS7wsDPI9rWOe5zRwATnCsZ8R23YbVxXax0R+Vh /EiMd8djhV7tdA+suUNNGQJJXhjc8DJWssbNVzxymW9fD6TMroadkkrZ2RO4a4ggH7Lys9WomAHX JIew7kq3D9NWmfaWWiv1PHDWQUzgHkYPWG/KQfqVVGxVT7deaWqaAXwyB2D2OD2Us62sst4/L6VT bhRRtMwqIgeATkLWSl80hdI4vefJ5JVy9faetF/2lqbj+EbFJ+F9ZhAGWvABVR9PW2a53imo6cNM 0jsMBOMlWY7wmfwu9ZXD5jwVFDUUzWmaKRgd26m4yvnB1tkaWZDgcgjurZbj6etVRs5NLVU8dPda aAOZ2Dg9uM/uFEu0mgJrzcaG4VUAfbnuILvYpq638G93SOn3G4Ml6ZZ5+oeHOOQp12K3RsNktc1L f3vpq+NxLZujImaffHkL1/EPtzDS0VDdbNTEvja5lUGDu1oGHf1UL/2JvP8AABeo6QvoS3q6288e 6z7Xp3O/OprRc7xS3bS1zlc+pDm1MLctDSMYd+v+ihqWR73lziST/NdRZNH3fUFFPVW2lM0UJ+bB 5XM1EUkEz4pmlkjCWuae4K1crl7YwwmPUe+gvNwpoRBBWTxx84ayQgL4uhna4TYe12ch3I598rzw YdI1XOsG31n1Fttb45oI2TyQDEnSMh2FJ71Wr1Nqqi83ySF2a2te0tIcTITx55XkgrK+jpZIKeaa KCQfMwOIa7Ix2VxtJ7Y2qjsElDWUzSXdTHOLR1A+6+M22ll1Bo9kDYWMmYXNjkAAOWnC1dMy2xTu 21ddb5jPSTSwvxjqY4jhfNlTWvrzWMll/FdfqeqHHq6vfKuVY9rbOzS81DW0jHdTS0uLR1BygrY+ G30+4tVZ7nC2aCfriY5wB6XNJx+6lmsbl8JO8uM9o+rdQ3uoopKSouFW+CVuHxukPS4fUIs1/vds pRT0Nwq4KcEkMjlLW5PdWK330tp+i06Gwxx09yD2ugDWgeoOoBw/YroKLSOltL6Rp6u7Qxtpw1pM pi6z8ysnqfabmrfhWB2ttRRZLbtWA+cSnn7rT2jU13s7pnWyvqab1j1PEby3qPurSa7290/qfQtR ctPsia+KN0sUjG9IdgZwqhycPIWdbm/hua3p0lPrW+wS1UsdxqWyVQ/vj1k9fGMn64WjpppoKmOa nc9kjHBzXNOC0jyFhSQPqpmRRNLnud0gDyVZTabaGnZQisv8Ae6RvLHD8oKi6Qfd9aX+7UJpLjc6 qogJB6ZXlwyFrLJqC42GsdUWqrlppXN6XGN2Ooex91IW7u2VXpG6OfTxukt0pzE8DtnwuNj0RfJo mSx22oLHjIIbwQro2WodZXu/0UdLdK6apgY/1Gse7IDsYyF9rDrzUNioG0VtulTDTNcXCNrzgE91 qblYrhbJmxVlNLC93Ia9uMr3RaNvcsbJGW6oLHDIIYTlNU6fXUeuL5fqSOmuldLPFG4vaHY7kYK+ cWtb03TElgdWSG2P49J3PGc4B9srW3CzVtDOIauCSKQ9mvbgle+PSF4fGHNt9Q7PIxGSmjcZv1ne pNLu0/LWyPtZwBE/npGcgA+2VzLhklbKrtFVSz+lUQPjl/yuaQV7hpS7uaCLfUHPIPplXv0u5O3O kHzwFiR9Fsqq1VUFR6E0UjJRx0uaQV7Bpi6YB/BVOCM/7sqaXcaEjCCF6ayklpZTHM0se08hwwQv Oe2FFY9kZQUIAppIQCaSEAhNCAR3SQgZQgd0E8oDwn4SJIQOFAICWeU0UYRlCEB5TS7I8IGeySMI QCYSTQIoQj+SBo8oRlAFJCZ4QJHZCMIGEkY4QgEIQgaRQhECM8IRhAIQkimhLPPCf3QCfhJGPCB/ ZHjKSEDCX2QOU/ugEkI8oBMdkihAykhCA7o7I8IQNJBQgEZQEvKBppHshAIQhAd0I7hJUNCEIAIH dHlGMIBGUIQAQhB8IBHco8IQCEZQgEeUBCB+UeUkfZAIQhAdkBAQgaEsIPZAeU0hwj+qBlL7oJQg aXlCB3RNHjlCMpFA0vKPCEU+yEk/siaJNIJqgRwkn4QCEv8AVBQHlMICEBhIpoKBJ+UJIHlAQhAk JpFFCEIQCEBCBpICaBdk0kfdAZymUkygEI+6WeUQcJ9kvKFoCEE4QgflJPsUkDQhJAJoIQEAg9kF H2QPwlhqMZxyjA+qCcQgpgoXxHvJYrI9sBYlWDh90v8A1Kl/5io4xwpG3RP+x0g93lRyPyle/wAH +keby+2KEIXZyCEIQCEIQCEIQd5sxVxU2ubd67wxjpAMk4GVPHxYwyS2DT72NJiZUP6nAcDLRjKq hTSOilDmuLXA5BB5ypx01vRTz6Qm07re2yXSmLOiOZjgHtHjOfI90Sum+HLTErqz+KOdJD0cxuHA cPIKnHWdHUXzS11prNXPpa5jSWSRuILXN56T9D2Vcttt6aDS9hqbPXW6pniDnCnmjc0ODTnHUD5H HZa/bTeafTF3rZLxHUV9HUkn5XgPafHfgpoSr8NccsdLc2VLS2YOIeD3yO62O4FRVazorxpSno3t rIKsFlQ0fJI1p4B9j/VcjZN+tNW+vuE38FrIxPKZGOi6QSD3DgtnSb/aQhqZqiK03JkszuqQ4Z8x 9+6o72B1VadqJyC6KrpaaTny17R/1C9G1mrHav0pT1tQwNrIwGSkdnH3UR3HfWx1+nb3a5aOsidV Cb0ZAGkHrBx1DwuX2V3doNGW2ot15paiSFxDo5YMEg+xC1lf0x1725TG8st+tOW1JQzV25t3bTsL 5DcJDgf8ystrlhZshXscCHNpOR7dlXnS+4Vqs+5NzvFbRyVVsrJ3vHSAHsBdkED/AEWz3f3ik1I0 W/TrpYLV0YPW3oe4kYc1wzgjsry/5ObVx34+CEH8nH1X0o5vw9RHI0BxY4Owexwey+bvzYSHKzbu 7dJ0spp/Xe1s9opXXS3zQVoYBKwQ9Q6vOCPCx1Nfdob1Z6mlYKinqHRu9KRsGC1+ODn7qt7SQEdR UGTwGvc0ODgCQCPP1XbbQY/txbAccyBcKe5K3GmLxJZL1SXCJoe6nkD+nOM/RBdndbVNTpCx2i4U gDyahkT43dntLeQVsr0H3/bqqa35X1kLmtyc46sYH81A27+6li1joWhp7Y+aO4RSskdFIzGMDB5W 3sW9lmdtv/D6l81PeoYi1gLOpjnDGDn64WreNwuP/tymNyxzmX/p99M6g1PtjJT2PUlEa6x1JxA9 xJMfuAfbnsvtvzoandp+TVmnHPpm9AdV07SWte08dWPfnleqi3l0XqWw0bNUMlgrYDl0YjLgHYxk H2OFqN1N3NO1+iJrLYHvqRUtMUnW0sMY4II9+QmV3drJp7fhXjLIq8uGMnj6jCij4jXY3OuP0a0f yXcbGbo6a07Zn0l8MtLWxnDZWs6myt+vsQuP+IO66b1FeqS8aarXTTTAsqYnMI6cY6XD78/sr47M ccpfk8mNyzxynwiT/CcKa/hfqYm63MTnAPewdI9+VCgBWxsN2rLLdKevt0zoamBwex7fcLOvh0WJ +KKhqK/Vtqjp2OcTT4GB56ivHtbt1c4brHFci+KmnAlYA4hryOf3XTWHd7R+qLLRzasLaO702A4+ mSHH3afY+y+esd8bPbKq3DT7GV8EMgeXDLTjs4YI747K+TLlpy8eHHaaKSpiiubLYa5z6qOJshhe z/Ae3PnsoZvFPHYfiIpnWpv4cVlOySVrezi7OePrhbur3V0XUPZqChuIbco4APw8oLS5o5LPv3Xl qLlYtZ620/qPTtS6WZo9Kqic3BjbjLf1ySFmaavtIGp66W1aispog2P+IPfFUjGQ4NaC0/Q8leXV GkKC56ttlyjiEdfEHFz2jBcBgj9QvVrm52O1fw2q1BUfhmxvJgkLSR1YGQf5KNtSb42ig1fQfhG/ i6CHPrTxOyHNcB2HuCP5q37jGNvymGgqIJ6+oojWRzyQjpkgMQBwR5KgbTVsprT8QtypaGMRQD52 sHYdXJx+q7Gr3M0Vba51/oLmyoll6WzQM/M5p4JA9wOcLh9V6v03ad0rXqq13BlXQ1jTHVsYMvix jDse2D2Us3hlG8brPHL4Thd7u6DXFJaJoWTUdbTuLg4djnCq/vzpGDSOu2PtfyU9Y3142DvG8HkB T3V690NXXWluhv1KJoW4acnsTnGFCO9+urVfdZ26ro2/iIaB3S7BBbMzOcg/UZ4XWcb7+nPuXr7T vNK65bPSTVwbJIaFwcS3vhnf7qklIwuq2NHJLh/VXJtevNE3DSLLe29U8MFRD0lkh6XR5GCCPoqo iWjsGu3EuZW2+mqiOpnIkjz3H6LMv/DMb7Jjfz5ZfC3V1HTsZUjz+CP/AJQqa2Golpb3STQOLJo5 WuY4eCCrijV2jbto51qZfaRsFVB0jL8OZ1DsR4IVS7TNRWDXLP4h01VDTVRZI5nIcwHHUPf3Wsev BMPna+/Nll8WLb7qhtdstcJ6iNhmdTtd1AYPUCOVDPw4avr6K/8A8APRLQ1X940PGTG4d8fdTHed SaRv+iJ7PHfqIRVMBbG71BkZHGR45VS9L32fR2sYa1jWymjnLXAHh7QcHB+oWc7b4pjPbXjmvJbf S228mra7TLaaGjt8VdBVNeyZsjSQ0Yx/qstsqSCXaT05IWGI08g6HDIAIPC9FFrfSGpaGnuUlwo+ mSIh1PUSBrwcctwfPhabb7W1okluVmdBPR26YukpZZm4bhw+ZhI9j298qWzeOvhxxxyxxy3e60vw uUrBa7rG5oLROcAj6KAN56aKm3KvzIWhkf4gkAcAE91crQ1ktdkEv8IlidFL8zg0Yz9VTne53Vub fx7VBXSasyq428sZXFUvE7Veez3KSy7O09xhaHSUtMJQ13+LAHCoq12HAq29i1har3sVU00NVEK1 lK6F8JcOoOA9vYrnhN+XCX1t08914cte0m6G1XBquzy3CjDhTmNpAd3a7/EP0K8VVeH6e22nu0bA 91M90hYf8Q6+R+yiv4atZWyHT1faK2pigqmOL2Ne4DrBPj7LqdWaitVx2fvdHR1sElTE2WN0QeOo ODs9u63hq5avrbnnvGdXvTvtH6jg1NZJq+hyaV7A5nUMEEjkH7EKq+1rS7eOI44/EyH+ZUofDdrG 2O0hV2qoqo4q2Al3pyODS5rs4LfdR9svWWuLdC4RXOeOCoEjjTvkcGtLgTluT5K528vDnj/XTD9f Pjl/He/E+7/0lpsDI/vXZ/kul3ty3Z0BvBDYP/MFoviUgp7jp2mvVHUxvfb3guY1wJwTjI91ubBf rFuZt3BR1FVFFNAGMqIpHBpa5v8AoV1mU5+PL4088xy/Fnj88nu22/8AzLjr/wDlaTP7FUprBipe Mf8A05KvFX1Vo0nt/U0hqYxRtjdGHtcHAFwIH81RqocXVLz3Gf8AVc/H14tfO3fK8vPlZ603u3ze rV9qDgCDUs/qr236hM9opaanmEDZWkPbx8wLef8AqqEaTuEds1Hb6qY4iinY9x9gDyrSfEHf4Ztv LVW2mra/++Y8Oifkhpb9FcMeeWms8uOO0i6gtbKjQIp7piqfB0tEjhycOAz+y1Ovb7bNvrNbpaih dUQzSGICMgFvGRwe61mn9VUlw2UbWxTtllgizK3qy7qYQSML26hpLHujpW0zx1THUwd6gw8Ah2MY P2WZ/TLfw56pvGjtf2+3TU7o2XKOdoFNK3DyMgEfscrpNf6htG39NQNqLeahk3UxojIaR0hc5rq3 6e0Xp6318bYoayllY6LpbzJ0kdQyPOCuh1bZrRuVabRXwVbJKQAyMcHAZyMEfdXDXPWXpPJLMZcf bQ1NRo7XzbTWUb4RXNlaHUzwBIATggj6d8qSp7XBSmOGKkZKGMxgHGMccqM9aUOnNC0loujWxU1R TSsLQ0DMzeoB2PcgHK63VFsp9Zm23S13SWOn9Lqa+nlLQ8E5wSClnZL100W6NksNK22agrII2xQV DI6jpAdhrjjqOPYrr66KkpaCnqaKi/G0skYLHw4IPC4jcZtisNJbZrpOXU5lY2eN7i4SNJwT7Eg4 OF1tooJLbDC7T9Yya1vDZI4s9TcHuB7A/wAldzjNe073XCa0j0dJebNeJ5IYsSCOpic35mZ4Bd9n d1Ilygo6CnglhtrqumewOEsBDh29lxG6MOlaPU1prbs6KJs7w2phd5DsgO+uD3XZ2qiq7Q6CO1VM dRah88cLjkhp8NPt5CmxX74kbbp+WiobxZJYPxUknpzxMIDgOnIJHhV/JVj/AIp7VaqQUtZRFkVX NIPWpxwQCCQ7H3BVcM5Vy18L4+Wv2YoHZBS5WXQwjPKByEBAeEFCX1KB+EZR3KEAhBz5QAgE0FAQ I/RNLumOEC7JoQoDyjwhCKMppIQCMo7I8oBA7oSQPyg90IQPKCkEIBHhCEABwjwgIKARlAQiGUvC O6EUZQUk0QJfqhMIEgpoCAST8JIoT8IKAgAfdCQ78poGkjymgQTSyhA0kI7oDwjwhB4RAgIRlAI8 oJQihCSaAQOUIzxhAD6oQj7KwCEIPZAJJjhJAx3QShH2QCCeEeEIEE/CEIAIQhAIH1S8poEOCsvK SM4QGMIQhAk/KEIAo8ISQPyhGUIBGeEDKOyAQUZQgEIRhAIQhAcfqgICaIR4QEYR5VAhNJAICCmE AhCEAhCEC8p+6SEAgIQgaEkyikhCCgaRKMZQgEEo9k0AjKQQO6AQhMFAgn+iQTQCEimqg8JIwjuq BCE/CBDuhNIoHhCXICO6AQE/KECTKEIAZwmkTgIygnId0BHZB+6+I95Hsk7sg/qkVYOE3T/9Vo/+ Y/0UdDsVIm6ZPoUf/Mf6KOvC+h4P9I8vk9hCELq5hCEIBCEIBCEIPRSQOld2yF1cOh76+1uuUVBM +iYMue0ZwPfC2Oy9qp7tqylpasdcTjkhWG3m1Udu9O0lvtNO1staHsZIMYaG4zlvY5BKRKrY7Q97 /gwusVHLLQ46jIwZwPdZWPRN4vVK+ottJJURs/N0DJCsV8PGpYr9pyrsVcxgc0OwPdrgc4H6ru9O 6epNDWi4TUpBDGySBpOOsNaSB91dppVCl2u1DU04lioZHMJxn6+QspNq9SwRl7qCUtHdWg2h1G/U dNc6xrXRUs07pmQuOfTLuSMrKu1XctKXlz9UCOTT1ZUOhgqGtAfTuzwHDyD7psVIvehr5aaFtdU0 UgpD/wC0AyB9/ZfOPRV6qbS+5UdHJNSsGXFoyf2V46OnpLhZHQ1EcdRR1D3gtcPlc0nj+q8eltNw aapayipR1Ubj1Rh3JAPdp+yS7Zt47v0pBp7Slz1Gyc2qEyvhGXN8rRXCjqKGpkpqqJ8M8Z6XscME FSfpnUtZpXdWvqLf0iN9bJG+HHyuaXdsKV/iL0Xbrzo52rqWIU1xgY10gaOJWkgYP1Ge61lON1fb WOW5MvtUwjnumMDsh4we6+lPC+eVrIxknsPdZafMBI8Hytt/Aa/Gfwso/wC6V5K631VKGmeF8YPY uaQCg8o747L6wRPkeGtBzlfEcHC7naa2wXbV9FS1TeqJ7uVQ7Tt/fLnSNno6V7o3ditHqGwXKw1X oXOlkgkIy3qHBH0Kunqu40232k2PoqMyyygsi6WdQDwAR1DI45XGS3Gzbu6S/h12po6DUcBDmNxj Jz3afI9wom1Rx1DvnKeXYODypnqdlrjRanp7ZWODYaoEwzAcEjGR9+Qtdd9oLvaNSw2ydhfHPkxy gcEDv+y1DekUAH3IwnlxBzkqw8fw81ksTXtnIDhn8vZcfctnrxbtSx22ojyyX5mSgcEf+8po2icN KbGOcQAPKsIPh5rpGtLajAcMj5Vztu2krqXWYslxd6U7x6kBxxM3zj6/RDaM6qx3Clt0dfJTyCke cepjgH6rVuce2Ve2r0TTVG39TZn0zBNNCY8Fv+LHBH1VLNaabrtK36e13OJ0c0YDm5H5mHsQrrrb Ez/a4tM2Rw8rttrNa1mkNSRVFNEypimIjkhecB2fIPghcIP6L70hLZ2lvDg4EH2Ky6LR7h6luWsd H1NuqNLys629cM7ZCSxw5BHCrDUiSKV0cwLZGnpc0jsVefa2sdddvKKpq4o3zsgHzFuerA4z+yp1 uNcIbzq+urKakjpBI7D4489PWMgke2fZdJN47nw48pMuLmmFw7ErbWWy3C8SOioKeSZ+M4aF1W2e 31XqevjdJG5tIDycd/orN7d7f0elq6ppwxrstEsbiOQD3BWNtqpz6I1HT0z5JLfUBjBknC5GYPa4 tfkEHnKvDYtW09z13dNOSW6BopJCzrHdwz3VdPiU0xR6b14DbmhkFZF65YBgNdkg4VSdInbI5pAa SAugtmlbxdqYVNDRTSwk/naMgrnQOforM/CfcHVMFwtVQxslO0tfGSOWE98LO5PbWkHVmkr7RUzp prfUsiYMud08Bc3I09Rz3V/4pqSs1HV2Sotsfotha/1Sch3UDkYVfNd7KVD71cJrCWPo2v6vTxyz POF041ymc6/qBPUkYAGuIx4XzcST5yeSpcuWyV/prW+thayfpZ1ljWkEjutZpPam76gp3zQsETQc APHdZb2jyGZ8ZwxzgPoVPO0O6tutliFo1BbZqmaJ39xNDgl7T4cD5C5q8bLX622+Wr6GTtjHU5rA c4XYbI7cSfjKO7V7GS0kzfk4z0uylL/HQau3utlJYqmls9HU01wHDI528YdweQcgjuqx3qvqbpcJ qytldJUSnLnuOS4/VWG+JHb6QVrb5aqcelHThlSGjvgn5v2UaaY2ovmoLf8AjKaNjIyeA/OSPdKm PXtGxByCvtBNJDn0nuaSMHBxlSNqTaK/WW3urZIGywt/P6fPT9VhYNpb7ere2rgiYyN3YPzlG7Yj uKWSKQOjc5rh5B7L2Uv4qokcyD1Hvf3DckldnqPaq/afoDXVcDXUwOHPZyG/UqXNitsnUdZ+Mu8U bzKwPhcORjGf5qek9q0CSWlmPSXxyNOPYhZ0sU9XUj0GvkmJz8oycqVviA0RNZdTVtypKbots0gI LRw0kf8AVfH4e7PPVatjrmQsmpad3RM09wHecLWWPD25+PP8k3EcVs1bA19PUOmZn80byRn7heWn rJqcuMUj2EjB6SRn7qcPifs9vp7/AGye1sAkmjc2VrR3IPB/muLte02orjQxVUNI0MkGR1uwVcsL jr+rhnMtuFkuFRKwtdI8sd3Ge68h7ruL7t1fLNLTsraTpE7gxjxy0k+Mr2S7TahZVxUzqQGR4y3B 4P6rMjUsR07uvU64VTqVtM+eR0DezC4kBb7VmibxpgMdcqYxsf2cOQuXKrXt66a41VNFJFDPI2N/ 5mhxweML7Ul4rKWIxU9RJHGTnpDiBn7LW+EdlDTZ1V6rqyFsVRVTSRtPUGueSAffCzo9QXKhp/w9 LW1EUOeroZIQMnvwtS08+yM4UXUbSuvddXRsjq6iWVjCXND3ZAJX3oNS3WgpxDS11RFG08BjyAFp M+yMoSRtrpfa+6NYK+plnDMlvW7OF7KLV96pKWOnp7jVMijGGtEh+Uew9guc/VPPCJqNzdtQ3C7u YbhVzVBjHS0yPLiB7cr30muL/S0sdPFc6oRRt6WN9QkNHgALl8oyhqNtfr9X3yRktzqpah7G9LS8 5wPZaZP3R4RQUkFCAPZASTCB+Es5Cf0SwgaPKWEIGUJJoAoQeUeEAmUkwgSAmhQJNCEUIKWU0AhG EIAIQjygOxQhBQA+yEZ5QgEI7IHIQCEfZCIEuyaPKBITQgSChCBpIQihNJAQCEJnugEfRCQQPxyg cJeU8oDygoQgEBAQgChBQiAJfdNCAKEJefogM8poR5RSTQhAIQgdkAgISCsAmEsoCB5QhJAd00k/ CBJoPZCAQUkIBGUEcJoBCSYKAQO/CPug+EAUIzwjwgEeyM/uhAZRhCSBoSCaAQO6EIBCAgIAlCEI D7IQgIAJpIVQyUkI8FAz2QkhAd00iEIGChHZJA0uyaEAOyEkIGkjKEUYTS7JoBLwjugoGkgoCAQj 7poFjKChCB90JIKBoR5QiAIQOUY4VBlCSZVCP1TBS8IwgaRTyhAk8IP8kIBHlHlCBfzQnhIjlA0Z KYSx90E5pHskhfEe8il4WRWPlUcDuof7qiGfLv8ARR4fy/XKkDdI5FGB7uUf9gV9Dw/6R5fL/sEI QurmEIQgEIQgEIQgkbYy6U1u1zQurJGxRPd0dTjgAqZvitt89RRWOuiic+jje8PlaMtb1Y6cn64V VoXljstOCpd09vNc6TSk2nr3QwXeikjMbDO49TG47fXHhIlm0rfD5pNtLRMutUCwuHXFJnAx3OVJ WuLbTa10bdqKgqv75hcWmI8iRvIH2KrJo3eiv09pqexSW+OrpXMeyKQyFr2NcCMducZXi223ZuOh 55w2mZW0k/Jie8tIPuDylgsB8O1JPR2CphrI3RyiQtc1wwQc4Xx1JTXbXsFwsM0LWR0Ne58FUTgO DScNd/1UdWr4iKihlqibDTStmldKCJi1zQfBOOV74/iRbHI50emYWOeepxbUkdR9/wAqREtaikmt m0lU5rjHU09O4BzTy1zcc/uF69stRzam0bBWVoaapjel7x/jx5+6r/dt933bTNzs1TaGBlSJBHIy blod2yMc4Wo2v3mqtF2uW2VNvbW0rjljg/ocz38creV/XGT3K5cLvK35jXWyy1V23CrDSsLy2te4 4Hb5lYveIiLZW5RSYbIKdo6T3z1BVv0ZuXJpTVlfdIqBlVR1cjnmCR2C0E5BDvcJbq7oV2uKljY2 vpbexvywF2SCfzZPkcLXkymWdyjeGNmExvwjR5+Y+y+1BVPo6yKoix1xODm5GRwvO5wcUsd8Lm6L J2bfPSzLbTtuWl5HVbGASGJzekkDuMryat3W0LqOw1dBNpuqjdLG4RyAtyx+Pld+hwq8Dt90uo4w gyxgjPOF3ezlxgt+urbJVvEcRf09RPAyuD6iT4X0Y5zXAtyPqgvxuLeIrRR2WtnoDX0JmLJmNP5W loAd+hXqntFnkpKK60VGyKUPY6N4xkAuAI/mq57b75vtNiNl1VROudGwBsUnUOpo9jnuttdt+KSW 2XC222hqKeBzGvo5C4F0UgOSCPLeBhGU363GdV6U9hNNz+jV8dYEf2/0015GD62B+yieh+IK019n p2ahtM7rnCOJoHDpDsfmGf6LT6r3tob9YKctpaim1FQyiSmqmEdJIPOR7EdwtY2S7Zyx3JPpPWtt SUVhuNJBWUdbManPpmlf08g9iuZ1hqmrr6Knp7Naq2G8QyNmpnVTQWuAPzDI8ELiaT4gdPV9DSuv 9mqHV8bcOMZb058kZWn17vzHVtoHaXp3RPhcHH8QwEtIIwAQeQRkELKyVM9Lc6bV9FBCaqqsV9YM SU7XlvzfTw4eyhzefU2pbbWUNov0EInpJmy0V0iBY9wB55z3I7hbym350pXw09TdbPUx3BrR6hi6 cBw9j3wuA3u3Toda0dLSW2mcIInB4fO0eoxw74cDyCPCLpZGrnra3bMzUkz3V8kGY5A7nqwMHKpv uaNQm7xnVBmfUhnTHJLz1NB7A+VJe0u+MdisxsmqIJamkjH+zzxYLmj/ACkefotBvruRRa2NJS2y kApKciSOWRnTKHHhwOO4PC3Mv04Oc8WvJc9oeGcr0UjS+ZrWjJJ4XwI5K+1HUPpamKaPAkjcHN88 grOnZefaCN0G2sDZAWuZByD9iq26G0JPqzUM8hb/ALIydwe73OeylTRm/GmINPQQXGnqYKro6Jo2 tBY44wSD7FchpDdGx6T1nePwbJX2GuzNCej5oZCOxHkZW8ctYXH7crhefJN0z7Ht1poy1D4oTGz5 RjJLsccd8ZxlfLZ/VU2r6auuUzjn1HNazOQwew+iqjuPr+46wuZlqpAKZjiY429m5xnHnnHZbTZr c6fQl6/v2Ge01JAqIh+Zv/E36/TyubabtCwSN341NK9rgx8vykjg8rgvi7I/tlbm+fwg/wDMVI8G 7+37Lga2KSojnkPU5/pcqAt8Naw601MKqlbiGnaYY38jrbnIOD2PK0zcfSOgeVZH4S4XMr7g8ghr g3B9+FW0c855U97Bbn2PTNumoL818EzD1QzsbkOB7g/ULlnNzTrMuKS9xd2otG6rlt8lrE0nptcJ 2vw7B8Y/99fTYfU1Zqm83mtqnO9GbDWsI4wAcfrgqH/iD1DprVE1DdtPVj5a7Jinjcwj5cfKR+uV 0Gw+6Vg09ZXUV86qWrhP93K1mWytPvjsQu/ksv8Aq83iwsn7e0m3Tde2ae1xJYLw11NTRAj1gOpp yB05HjyF2WnHUUljray1dHoP9SWJ7Bxy0n+qqx8QN507frxR3rTtb608wMdTFgjpxjpOfrz+y3+x O8FLYqGSwamcW0JBMNQASW57tI9vZTycd/q14plx/b2mDZLVNy1VQ15vTxL6bjHgjuMLm9t7xVW7 dnUGmaeTFoZO6aKAjIjJIz0+wWztu5GgrNHUOttwjjkc1xDfTIDnY4/dV8m3Ilod0KjVNsiAbJL1 uhceHN4y3Kk1xu11dyxPu+eodQWu5SUVppRU2yooyKhro+oAnI/Thdjo+Wlte2lFWzO9GKOBpkkA z0gAcrmX7taMulrkrzVRGofT5NLOMHIBPRn+WVy23e8VgrrfcLHf2iipC5zqcu+ZpjcfyH6j+aXK XXSTGzfaU4dV2GtoZmy3GOrpJAWOPonpH6gYXmv9UdPbY1tys4Z61PGXRHGQQHcfyXMnXWgrXY6u KhrKSoaGFwgLS3q9wPrhaHQW7um7vYayxaicKSJjnCEy8tkiJyAfqExsmW76ayluOvl49P7uV9fZ 69mr7E+rtcrCwTU7AA3jBzngrffDdququza21SSerR0LyKZzwA8Rn8oP2Xoq9baAtWmqyGjqaOtj DD/ssfBcD3wT5wVA20e4MGhtbSVDmyPs9Q8xvH+JjM/K77gLHl7/ANV8c17SNv8A6mvT/wCN2J1E 2W0kt/vjHksIweD91yPwy1lRSa/ZFE7+6mjLZGnkOHhTTq/XuiZdO3Gd1VTV7Z2cwtIDz1DGQD7d 1Cvw9aksNl1LVRXiVlP1/NT1MgwBjPyn2yunnymc/WOf+NhfHP2SB8SUMY13pbDAA5wB4/4wpC3L v82i9G0lfa4YXOLmNLJBkYI5UbfENfLHfLTR3iz3SmlrqCRuI2u+YtJ7gfQ4XQ6f1/pTXujKSm1B UwUtVT9LZoZjgEgdwfIK785ywuXqRwywyvjyxx97dLd3x6r2enuVZCxlR+HdUMLBjocBkYX1gucz 9oKa+yNY64UlKJmvI/MQB3+4Wj1brXTNl0DVW6groqiF8boQIXAlvUCAceRlaHTWt7Pc9j6q2Gth juEVK+F0LnYOQOD9iuHj94TL7ds98M7PqOo3Dgp9VbK1FyrKeNk/4f12dIx0ngqlE3DsK11t1vZ7 tsPUUDa2FlwbTPhdAXAOBAHj2KqfKep2V0z1PHNfa4f/ACZfWoxyl5TPCxJ5XF2ZFL/VCSDIFLyj wkgeU1imO6B5wgH90kIAnujKEIEmhA4QAQjKMoDCEI7oH4SQn/RAk/CR7phAFCOyEAUwkn3UAhLy hAFH1QShCBGUJooSR9EIGhAQgEIQgEIQgEDskhUNCSZQJCE0oEZQhQASQhA0vCEIBCMo+pQCEIRN mOUIRygSeEvCaKOyEIQCEIKIEIKSBjIS8oQPCDJLyhA78IoKEeUiiDKPPKDjwg+yACaXlNFCP9UI QBQUDlBHCoAglLsjygaEIQCXlHZCAKYKEkDT8JIwgEIBSHdAyhCAgEBII88oHjlAQUIBJHZHhAJp JoBCEeUAjCAhAk0kygEd0I8KgQPshH2RAUI7IQB7I7IQgEICCEAhCPCBhBQO6EAEkIRQe6M4CEFA Z4QhBKAyhHhHhAfVNIIQHlBCEIGl4KEFAI8IQgEJpIg7p/ZLKAgEFHZC0BGEeUIBHlCaBFNLzyhA JpJjugEs5TSwgZSyU/HlGD7hBOKSefCXcr4e3vBKX7FB47LFaEfbojii+7lwX+Fd7uifmov+8uC/ wlfQ8P8ApHl8n+xIQhdXMIQhAIQhAIQhB7bbRyVUrWRtLi44AA7qQnbT6iFiN2jpfUp2N63tZ+Zr R3OPovX8Plvp7hq6GKqjD2Y7Hwpc+InVtfpSno7RZn/h2VbCXSMOHBrTgj7FJLfSWye0MT7WX0ac ZfKWD8RQlnqHo5cG+ThfXTG1t21LbDW21gexnBae5+ynH4edSsvWmZrFcC0uY0ta08FzHdwu4mgo NA6XrJaKSCJ7GPdCJndIkcBkN+6bSxXSg2Qv1VStmhYwtJIIOcgjggoq9itSwRmRsTXtAyQM5wp/ 2YvNRe7HW19RlgqJ3TemCSGFxyQF5rrf7poS7wSXuqlrrLdKh8TA7mSleORj3acqylVr1HtTf7Ha 2XOWnL6I/nczks+pWMW1d9rNOm8W+EzxBpc5jeXYCufSmnls0barofTT5aRJ2cHHgHPvlee0WaGw W+tpaMdNKQXRs/y8HI+ys7rOV1LVKNGaBuOsIKk2ksdNT/mjccFcre7VWWe4zUVwhfDUwnpcx45U g7d32usW5Bmt8pj9WpdG5oPDgXdiFMfxN6Wt9y0YNRiJsVzg6MvYMdbXHGCrZrPh8nOTGZfapAGU /wDRI8Oxley20U1fUsp6dpfM84a0dysujxg+yXldgNv9QFuf4bP/AOFam96budma19wopoY3HAc5 uBlNDSgYcMLpdG6cqNSXNtDRkes4EjPZc4B82D5UtfDswnXtMfZpTaOavug7xYb3T26505idUOxE /wDwv+xXo1jt5e9L0cVbWwE0cmB6jRkNJ7ZVrt29MVWo5LG+jjDzR1BkcQMkAgf9FtNcWUXrQb7X IwOdKGMLT75Ct105458tqEODw4jJ/ZGT1YxlWqGwVpcxolqfTe4chzwDlcddNjKi3app6Qv9WgqO Y5B3z5H3SRu5IHAOMHIKziY5xDWjJKtIPh+tWGiSqcxxGcF4BC5Ru0MNh1rBbL1N0UlXzR1JOGvc O7Ce2UXaKq7RV5pLALw+mc6jH53AHLB7n6Llnk8DlfoJJpymGj57RM2MMlhMLnHGCCMKkm5ekarR eppbZUlr2FolhkachzD2T3Npym+Llee/Zfamikne1jQS4nAAGSV8G9/0U6/Dtoqk1BPLW1DQ98D8 BpHHvlRpGl40TebZZ4blUUjhSP7vAz0/f2XMFhaT/JX/AKz+BOkbpmtgEsdSwtkaWnDOPlz98qEb lsMGatmp2yE2x/zRPB5GT2P2VnaWq3DqP0WQyQOSrOz/AA6QPieIKyRsmCATgjK5PTeyNdUXmqob t1RNgOA5nn2P2Kuk5IO55y1Ys6u+OFZyq+HWJ0En4WseJsHp6sEZ+q5TSeyNdX3CqprpmAwvLPl5 yff9VNJyQkC4e4SIJOeVZSv+HaT8JJ+DrHesBlrXgYJXL6M2UrLvUVUVyJp3wuLMN75CujkhHHOF kMjsrG3T4dJxRSyUNW50zW5Y17Rhx9lzmh9k6y9snNe91O6NxZ0gZOR3TS8kKlzj34WJJyrD3v4d 6yK2TzW+pMk7GlzWOGOr6KvtdSS0VXLT1LHRzxOLHsIwQR3CmiXb5l5Pckj2WPVh2eyWeEkV9Otx 7OKHOJXyz+ieeUH1D3Adzj2QH4dkE9l8s88Jg84TQ+3qPxjqP7peoQc5K+WUweEH1Ezj/iOPusCS c8rHKWUNPu2Vwbgk4+6w6yDkdx2WGfqjPKD7+u9wwXEg+Eo5nM/K4jPsV8UZQeh08jxgvJBWLZnM z0uI8HC+WeEIPs2d7M9LiARg4K+R558pZQScIAnKWOUFBQHZCEdigEYQgcIBATISQPykhAQNGUJd kDRlCSBpJhHlAeEZRlHcIBHhBQgEBH2RhA/CPCSaAT8IS8oAowgo7KAKEIRQgcBCEB3QEIKACE0k BnCaSCUDQkhA0ISRB4QgJqqSE0koEd0IUAUI9k+UAkgd0IDwhHlHlEGEJoQJNIIQNCWUdygfcoSC MoBMJJoDHKChB+iBBCaEAkgo8IAoTKXKATSPhBQPwkEJoBCEgrFNIoR5QGclGOUEJ5QJGUIQBQjy goDKPCEIDwmhBQJMISCBhCEIBJNCBIymhAIQl5QA7JpeU0AjuhIlA88o8pd+yYQCR7poQCEIViDK EIQCMoCEAjKEIAFBPKEIAFNLCEDSS8JooRlAQgEISQNCCgIAIQj7IDuhAR3RNgIQn4Q2XlBOUI/Z DYBR5QhAeEDshGfdAI7IH1R5QHlGeUBB7rQEEI7IQCEIKAQmkgCgICZPhAkI7IQZJrHshBOHdB+i EL4T3sXFYu7HCyPKx4xytfAj3dD89F9nf6Lhf8Bwu33Q/wB/RD/hd/ouIP5Mey+j4f8ASPL5P9mK EIXVzCEIQCEIQCEIQSXsRqCksWtaSS4yCKne4NMh7NOfKlv4o7LVVrrRfKdnrW5jCx8rOQ3qOQT9 CquQuLTxlSNZd1tSW7TM1ifJBV22SMx9FTH1lrSMYBVmVx9fLOWO9X6WJ2U0/T2PTTLnWiMMLPVb Udulvc5+i6TV1HbtxtC3CmoJRM9hc6FzHA4kb+Ug+QVVaxbtajtGmpbDG+nmt743RASsy5rXDBAO V8dB7mag0Y2WO1TQyU8o+aKdvU3PuPIWdLVptjbdUW3S76WtidFM12HNIwe/K1lRp+7azpJ6G8yt ZS0NW+WllIPWME4B+ihW37/6po2ytbFQPD3ueOuM/Lk5IBB7L1//AAQ+qCCHUdrw7viNwJ/XKs6m ks3dp33Fllo9oaxzXdE0ULeWnsQ4chbHbu9T33QUNXWSCSYQkF/lwx5VXLxvLqG6acq7LWx0clLU AgnoIc0E5wDnwvJobdzUOj7ZJbaUU9TRv7MnaSWZ74IWpZ0xlhvf9bHbnTNVedVuqaduWRVBJdjj IKm/4iaqCDayeklmYypPp9MZcA52DzgeVW7RW4130ddqmstbYXx1DiXwTAubyfHkFeHcDXFz1lcf xdwd0sHLIGuJYwnv057ZwtXLefNeG8Zi49/5yvRbK6a210NVSuLJonB7XexC8x5JKSw6J9tvxE1s NHDHU2CgmlY0NdJ1EdRHnC8Wrd7YtT2Grtdw01RCKdhaHseepjvDhx4KhDkc5KQLs4PKbGRGD7kK XfhxeDr6AHjLTwoh5PlbjTF8rdP3anuNuk6KmBwcM8g/Qj2Us3CdLlbu6nuOnrxp1luqnwR1U7o5 QDw4cYXdVcxfbqNz3fM98RJJ89WVTncbdis1vR20VFFHSVdG8vEsTyQ4kDwe3ZbOp3yvNfpFlnqq aJtVH09FZE8tdlpBBx7q5SWzXrTh4ccsJd/acd4qOvqNYabno2vNPFI71i3tgkd10u4FBcLjpyij stR6FeySOSGTyHBQPbviOuDKGGK52ilq6iMdJmLiOr6kY7rS603yvF9bS/w2P+GGE9R9N5cCQQWn 6YW5n3L9GXj3LFhIqul1DBDbNZ0D6K9RjpMzGkMk9nNcO2fZQ5ve/U+nJqW13esfW2F0zZKOoe0E tLTkDq8ED906T4jqk0cLbrYqWpqWNDXSCQt6j79uFxW6e69XrikipfwzaWjaQ4w9XWOodiCRwsad JFonNku+1nRSS9UtRT4ZIDnkgc5VQdzdM37TlbAL968kUoPoTPJIdjuAT/RdJtfvRdNG0LrZVQNu Ft7xxvcQ6P7H2Xg3c3QqNeCCEQfhqGIh7YS7q6X4wXA48hdJlrDgx+P/AJLmjJpHUrTfCUR+CuB/ 4/8ARVYx3yu/2n3IrNA3V08cQqaOYdMsJdj9Qfdc7Nut9LYwazoZ9wp9Py28fi4g134jq7g/RdeX F2omtzwIXce/KpjfNzpn7kM1VZoDG4BvXDIeHY7j9V2Wod/56q6Wm52mifTz0xcKiF78smYccZ/Q 8rd1Mrr05YY5cZy9t7qu36wm3WuT9P1NRSsbIJIj1EMJ+3YqWdubjda91XHqJkbbpCA1/S3p6m+D j91FDviLtZlEztPyeoeSRMAQf2XI1O+9zbrZt4o4QaEfIaaTALoz/hJHt4KuWXKmOPGOpulPreTc 67y6eq54I4qhz42vcTG4e2OxUxbc3G5XSmrH32GOK6RuDJWtbgHB4OFFLPiIsfqes6xTsldycSD+ uFxsW/FxptdS3dkDX26XET6bsXRgnHP+YZ7+Vi3a4469p6otYRzXerpaaxVxqaaRzXPEgAdgnJAI 7LTxaiu8Wr6i80drldZnsbBXUpA9Rr25/vG484P6rlYfiF04JTKLPVRvJyXNc0krjrVvvWUOuau5 SwCotNViOSnaA13SM9Lh/wAQB591SxPNXSyXCnmu2h7o78dG3rFLKSWPz3aWnt/1XHaP1LqimvtX dLva432ioPp1cNO09UT28GQD39/da2Df3TEMpkhtNZE5wwXs6Qf2XGae31qbdq2tqK6D8VZ6o9L4 mtDHDHAeByAT5HlDScLrR1jqWa86GuZnkj+Y0kpLmPBHbpPY+ypxuPc5rxq+vrqukZR1UjsTRMBA 6xwTj3Vi4N+tK0rpH0lsrInuBGR0gfTI8qt2ur2dSalrboYo43Tuy4Rt6QSPOPBKtu5qpjjrLbnS MJH3WX3QVl1YhAQGp49kCwhZY4WODlAIQAVkGnCBJ4SAKyx7IEEEcp4IQUCCaCDhGCgAglLHsnhA IKeEsIBIp4SQATKAlxlAx2+6EI8oGjwl55QeyB+UihCBoHdLCEAmOEIQCDlGUkB5TSRhA0IyhAIQ hAeE0Y/ZAQNJB7peUDPdMdksIUAUFB5QUUwhLKMoDKPKM+6EB5TSKEAj7IRhA0kYTRCTQhAIRhJU HdGUBHlKoQhCiGkhCKOyPshARAUI8JoEhPCECTCWUDsgaAllAQM90kY5QgEHun4SPZA+cJBBKBwg aR7o8I8IAIyhCA8oPCEdygEz2QhAigdk8IKBIAQmFVJCaR5QCO6DyEIBCEY90QJpBCKO6aSED7IQ kgaEJFABNIIPdAzykmhAIQl5QNHhHlCAQhHlABCSEDSRyhA0IQgEIKX1RDHCEJDtyqH4STQEB5S7 HjymkgaXlMpAIGjKEIo7IQkgaEDuhAZQhJA0fZLKaA8oyhCICgIIR3QPCDwkEFAI+qPCeECHdMpB BQGE/CSCgfhASHHdCAQl5TWgFCCjwgPKEJoEhBQgEk85Qe6A7o7IQgf3RgIPIRj6fyQTf5R5R/RJ fCe8j3QO4Q7PCWe2VqCOtzz/ALRRj2a5cOPyFdvuiP8AbaM+Cw/1XEkYaV9Hw/6R5fJ/sxQhC6uY QhCAQhCAQhCDb6ftFRdKpkVOwve44GFK9x2TusGn/wCKQSMk6G9csB4cGjkke+Fn8M9NFU6mLZo2 vbgd/uur+J3Udxtt2orLRzmOhmpxK5rRg9QcRwe/buhXF3TZm5Q6Wiv1BI2ppyzrfGB8wb7hevSm zdXqGxGvpZWtkb3icMZUs/D3fjdtKus9zBf0AtZ1Dh7T4yuq1xdKPQ2jah1HK2kqXtc2lJZkOeOQ 0+E2yh22bAy1tDHVRVYIdw4cfKR3Czq/h5rYovViqWuAGSD3UwbO1UlfpF9TUY66hxkeAMDLic8e FpLvcKzbm9W6MTyVtovEkkb6Z55gcMfMx3sersrsqFNZbL3ayWlt1pT+Mow0Ola0fMwe+PZYS7L3 Kt0iL1aZGyubGZHQngkAZOPqraRVFPT2un/FOY2CUCP+87Hq4AP3XyNBDarRcIKdoZB6b3NZ/l+U 5H2RNqdbd7aO1zbao2+tbHXU/eFy4XVFhr9OXeott1gMNTCcOB7Ee49wu52juFXb9wqV9HM6Jz5S 13SeCM9ipl+KmzUVVo+lvEkLRcInta2UDBLT3B9wrhOWfCLlZjjMqqOnlBPK2enbPPe7lHQ0mDNJ w0Hyo01meElKR2Z1P4pRj6lc1q7Ql70vC2e50bmU7z0+q3loPsSg5NuM/ddbt3puPVN+jtjqgQPl HyE/4j7LkcHn6Lrts3O/tha+hxH983kcIJkPw61jXY/Ek/8AdXBbl7T3fRdM2tePXoXHpdI0fkJ7 ZVxbpRTXSwRwQ1M1PM9rD6sbsOb9VFj9WU12udbt/rRvqVUUwjZVsHyztHLSR4OEZ+VQwx+fyn7+ y7PbTRo1ldH0DKn0agNy0Efm+ysS7ZvTNvrvSuAaKWpP9xMSQOr/ACn6+y5t22s2hNyLRV295ktV S/DJAeWOxnBVn8TaJdy9tLtof0ZaoerRzEtbK0dnDwVwHzYA5K/QPXenaTU1mgo7mzrpi4Oe7/Kc cFV5vm0H9nNdUMMsLquyVbj0SAZ6fcH7J1V9IB6T3A7J4LvdW7rdjdMXKhkjoJGxVTmksLTyDj2U c7cbd2yo1XctL6mhMNxgHVG/OA9vghXUNoL6D7FYdBLhweFbml2U01681uq+mKqAzGS7Be33HutD ZdiYoNRVVNcf72mb80ZHGW+6WMzLas2HA9jhZDqHfurby7K6QqJX0UdVAyrOWhgm+cH/AJVzmmti GRXusprvmWCN3yOHGWnsUa5K2EOIHfj2TjYTIPmxn38K3NVsPpyeKSCnk9OY5DSHZwVG9i2Wrmat nobi0ingdkPA/O3wU0cmpi2XvFXpxl0oJoqlr4/UY1o/NxngqJqqOSnqJIZmlksZLXNI5BHhfoFo 6xN05ZX2+CcyU8YDmMJyY8/0VG9xABre9YAANU8/zWphvC5fTnPL/wAn43OtBz34Uo6L2nump7HF cqGeExvOMEHj7qLW91ab4Rqqc0lypi8+j1A9OeAcLG9OtR3dtk9R0VvmqWNZOImlzmRg5IC8um9n 71fbVFcKSWEwvJGCDkEdwfqrb2t9yj1NcG1buq2kdUORwOORn2Wi2+Yyk1ZqWjpCG0Jm9VkbTloJ bkkey3Zrf8c8bvStF92a1FbLdLVhrJ44h1OawHICwsuzt7vFpgrqQwuimGRyrcWx1cy+XWK4v9Sg LiYQ8DAbjtn2Wk2zayluuo6GncDb4qx7oY85a0EA8fRT42Kral2f1DZLZLXSQslijGXCPJIHuozc 3pJC/Qu2Cskq7xT3kB9EZHNhDxwWKjm51DBbtcXqlpGhsDKhwYB2AyrJLjazM/34uYijL5A1vnhd vfttr5ZrDFd6iAGieAS5pyWg+65C3j/aY/8AmCvTcrQ+97OPoImNfPNS9DA73wFnHVy1a6ZW448l RLZtze7ppt95oYWyUzQ4kA/Ngd1xT4iwkOBBHhXr2esFRYtGS26vYPVYHHtxySoe03tDQatir681 T4HNqXtLBgAc9+VvHCXG5b9VyvkszmOvhXIN4TwVLO5+1NToyppp3OdLbJnNaZcct55XYt2JpZaO 319NXufb6kNJlwDjq7KXDXtvHOVXXpPOVudLadrtR3JtDbYxJOWlwBOOApb3C2OrLBaP4hbpHVUL D/eAAEge4wtvs7thdYJqa+Nm/DTxOD42kfmHkFZ/rXJDmrtFXjTAifdaYxMkOGuByMrPS2hb1qaj kqLTSiaKN3S49WMFWc+KKBjtuoJJYmCYTMPA7HnKj34VLhPFqist4cDSTxB7mEcdQ7Fb8mMwwxz+ 2PH5Lnllj9IMvlnq7JcJKK4QuiqI+7SvXpjTVy1JUyU9ppzPKxvUWg44Us/FhSxRa8pXxMa1zqRo dgYzglbn4W7G8y1N5ppWyOZmCanxyGnscrOc4Wf1cM+ctivt1tlVaq+WkronRTxnDmkcheXpPI9l OW+Fsp7xvJBRNIohURxRPe9uA1xJGT916X/D/cWXRlMatgY9hcx/T+bHdazw43SePyc8eSBC3GEu n7qWtXbO3mw19JE1v4mOpPSyRowM/Vb6T4f7r/D/AMRHUMe7p6iwRrOm5lEDO455WOFKW4O09z0l YIrvNIyWncWh4a3BZ1dsqLiMOU0sspEcJLJYfZRT8ppJhAFCEIBAKQ7p+UBlCEIBA7IwhAwl2Qmg QTKSaBYTCEIGl3TQgEvKEDugeOEvsn2SQMoKPCFCBBQjsillNHYIHZAeUI8o7oD7IQUggeU0ijwg aSAmiFlPwl4QgaSMcpoEjujKEAEI88IKA8oCE+yBH6p+EJZQAQU0igYSJQmgSOyEIGOEeUkIHlJA QUDwkgIQHZAR5R4+yASQPqn5QA+iChCAHhHjhCCgCjsEIQGSjyllMdlQJpI/kijynlLwjwiBCEZ4 QCEIQNJHhCA7oQj3QGUeUIRR2QhAQATSQUDyjKSaBJpeUIGkgoQMISCaAQhIoGkgoIygEZyhNAIQ UIBJNCACXlCfhVAhCPCAQkmgMIQkimhJAHKBoHKO6EAkgJoBCPohAIR4R4RB5QO6MIQHlPPCRR4Q AQEsJoGUs8pBNAIKSaAQAjumgSaSEAjCChaD4SQgZQCPCEIDCEZR4QGOUIQUACnk+5SS590E4hHZ JBC+E95FLyCsisSPHKuxG+55/wBtpR/wH+q4s/lXZ7mn/wBIUw89B/quMIw1fS8P+keXyf7MUIQu rmEIQgEIQgEIQglDYfV1HpfVkT7o4spZcMMn+Q57n6KVviS03UXSa16ooSyptTYRFJJGc9AJyHfb lVciyOQV2Fr19qS32KWzwXKU22RhjdA8dTQ0jBAyiVbPbiiodKaIFxqHtdStjEvqtbktHnsvVfI7 Zuht/VMoyx7gS6FxP5Xg8OH3CqPQbgalobE+yw3KQ2xzSwwvAcAD3AysdK671DpZksdkuMsEUn54 8dTT+hSxFxtp7ZPbNICirWYlDOkjvnghaeh0fW3i1sZqGoc8UL5JKUEfNGcZxnyOAq30W8Os6SMs gu8jYy4v6SwHBPJx9F6Hb2a2e0sddQWuGD/ctCQWN3hqDBtJNK1xDmiF3UDjnqHK3OlblJdNtxUz SmV5pHjrJ5PyFVBuu5epbtZJrPcK8T0MhBLHMGW4OQAfZfLTm5GptO2ya22+4EUMgIMUjQ4DPBx7 LTOkhbKaQkul5F1YQWQyEDHg58qQPifulIzQ0VukmaKzqY5rP82ODg/RVz0rrm/aTrJZ7HWmD1vz sI6mO/QrVal1BX3+vlrLlMZJnuLiBwMnuQFcbxy5RcseePGtLJgnjuvvb62e31kVVSSviqIXBzHt OC0hef3SWW0y0fxBawhp2RvdRSFoAL3QDLvqV4dUb03/AFNY6q1XOCglpp29LgIcEexBz3CicHKX IOQgyHGR+ikDZy2S3HWFL6JGYXCQg98D2Ufec/utrp68V1jukFfbJnQ1UJDmvb/Q+4QX41Yy4f2Y hNokdFWMfEQ5vgA85HkKPdYaJEF/teq55miufOxlSAMNfkYBHsVELPiE1iGAOdROPY/3I5Ws1NvR qPUdpdb6407Yy9rw6JnS5rgcgg5Szc0xjjq7Wn3CcDbbECQG/i4yT+hXo1vTSVMNjMLer052uIHt 0qo143c1JeLBDarhNE9sLmuZM1nS8FvY591tP+3XVjqOkhdLTGWmLSyX0+Tjw4djkLphnxkn0zlh u2rT62qXwOsHoyFnqTljsHHU0sGQVt7myCW4WyGcNIcX9APuGjsqc6r3m1FqSigp6ptPA+CUTRyQ NLS1wWN93n1LeqKgjqZYoaiikEsVRCOl3UBjJ+6w0t9S19Q3V0ttlhibSei10T/TAcXYOeVF1XA6 H4iQ+QFvq0jeknzhRPVb/alrLeIJ46QStAxOxhDw4djlafVG7t81BU2mtlbT09ztri6OphZhzs4y He447KzLUs+zX7TL6Wr1M8f2908Cewlxz35aukkf/wDDGG9Q/wBy7A9+VTfUu8t/vc9qq3Ngpq63 uL2SxNOH5xkEHxwvRft7tQ3WstVfE2GjrqEk9cOemUHGQ4Hxwrnd2OXjwuE7SRrDQF7ve6FxrKOo kooy9r4Z25GHD2UobbC8Urqu36kqn1Nwhblr3nlzD2KgZnxHXzAdJbLe5/vg91yFTvDqJ2rGXynn 9KRp4hJLmdJ7t+308LFdNLPi96kl1HXUUNroRBFI4RTyNcC8Z45BW/0xXVNdXVrbrTx09wgawOjY T+XJLXDPg8qurfiRu+Q51poS7v3cFyLN5NRw6vdfYJgS44dTvJLCzOej3wPHsqlls0thoeoqqr+N CuL3TsncwdXfoDj0/wAlSLchj2a2vLXtw78S84P3Up1vxDXeaenqaa3UlPNE/J6HHEjT3a73+nso y3I1QzWGo33dtFFRySxtbIyM5DnD/F910mesbj9sY+O85n9TTlm/mCtf8KVuno7fUTzRljKg9UZP kYVTurDgpV2u3jueibfJQGmiraUnqi6zh0fuAfZcrNu7u94txdSaY1vcLfQVr4qQgODC0Hgjn9F3 nw4Nqn2ypq61vS6pJew4wCCPCr7uxuFBr11FUm2R0lbCXNkmY/PqNI4BH0OVudsN6bjpC1/wyoo4 q2mZzC8uLXx+4z5C6+XKZ3ccfD4748dV1W7W5uptO60udro6rpowSAyRgOWuCkj4dmVX9nqieva5 sk7usF3kEDCrhu1rem1zcKWvZb20lZG0ske12RI3xke455XUbZb5VelbIy111AytjiP91J19Dg32 J8p5MplevSYeO44++1k9O3GTUVNqC1156o4KmWna8Hnp/wDeyqRbhUjrfq67Ub5HSmCd0Ye45LgD xlSbYN7qiyarutwjoxLbrhKZXUzn/Mx30d/7yizW14jv+qLjdIYzFHVSmURk5Lc+EmWsbiY+L95n /Gst/FVET26h/VXrutzns2z7rhRP6J6emEjXfYBUMa8tOR391NdDvQ6p22qNMXmkc6YwuiZVRuHI x8uWnz+qzjqZy108ktwsixm02oavU+i3XCvc0zPDhkADtlfQR0en9HuuMNJ67CQ50bDg5LsE5Vad o94pNG0FRa7hTOqqGTmNzCA6Inv37grd6N34NojrbdeKJ1fbHSOdTHqAexpOek+4WZ6u78rZOUs+ kw74NjrNnaqWGP5C2ORg7lvzZX12kPq7NRNeS5ppX8H7FRU/fi2VEdztlwtktRaKpn9y3IDoiQQW +eB3C0u2W88Gm9OVlhuVLJNTfOKaVjsENdnhw+ivLcxjlMbOX9T/AKBnfVbXtkq3GV5geSX8kkA9 /wBkaur57HpK1zWyNp9Z0ccgxkdLhhx+igbb/euns2ma2x3WmlkYRI2CaMjPS4HAI+i2ei9+KSCw C16ronVToDiKVmPnb4B9iFqWTLejPG2WS6d18TDS7a6mIJd88eT38KNPhZppDrKafpd6QjLevHGe OFsbvvNYtQaXutivNHMYHNeKOVuHOAx8gd9QfPkLkNj9z6bRT6mku1M+WjlPXHJFjrjf+vcFZ8uX PxY4fS+DG4eTLL7b34smn+3FI7B6fwgA++SvZ8Jf4hmo653zinkjDT7EhaXfXcLT2ubbSSW6CaK4 08n53gYew+P0Xy2L3UoNGU1VQ3ilfJC53qQTRY6mnyD7hT/I/wCSTXw3/jz8csr0fEeXM3QdIMj/ AGeLB+oJU96wrail2bFfBM9lXBBHJHK12HNII8qvu+2uNOaxit9ZZWTsuUby2UvZgOZjj9it7PvF bLvs9NYatskV2EHpD5ctcQRg5+uF08mcyzmXw5+HC4+PjVgawir0naKiow+Uvgf1Hk5LhlazWVyr KHcDTFJSSOjpagvEzR2OOyjTS+6dv1RpG3ae9Z9De+qONjnDLC9rgWnP19lLktR6txtjL3b5fxrC AJ4gCzJ/xZ7j7LGF4+/pc5vKa+KiH4s7rU0kFHbYZOmkq4yJY8cHpdkFVUf8zsjsrMfGE8fxCzYI PyPH81Wd3fuu3m9Ya+mP8adZW/ZFJMhLsVwekIBS+yaBpFHshAIQgoGeyQQmEAhLsmgMoRlCAKE8 pZQGUwl5T8IBCEIBBQgd0B90J8IKBJ/qhAUAhCEUJBNAKARwjKEB7IwhBQCO6EBAIHCEeUQeEeUe UeUDQhLKARlGUIBHfuhCBoS7dkIBMJJoBCR5RhABCAgoGUvKEIBNJNAJYQUeMIAIRhHhAFA/kgoQ AQjnKPCBFPwl2TQCEIQHdA4QCgKgwgBHlCKPKEIRAhCP1QCEIKA8oQUBA0ihCAQjwhAIR2QgEk0I aAR5QgophCSEBhCaAUCRhCaBI/qhBQAR7p+EvsgE0kBA0kdkIBNBS+yACEDsgqpsIKEIGjwgIQJC B3TQIphCSKaEimgEEoQgSaAUvKBoQkOED8IR90d0QAJBNCBJjhJCBlJPKB9UAhCfCASKeUkAUBGf CAEB90d0YQgEBCYK0BIIyjwgPomEsIQBwjCSfjlADsgjCMIJQAKePokscn3H7oJxKM4WXlIr4T3s SscrM9liVRGm5hBuVMPZh/quOd+Tj3XX7mf/ABYh+kf+pXIH8i+n4v8ASPJn7rFCELowEIQgEIQg EIR5QdTorTNTf61kNOwuaSOo47KXtTbK0tpsMdz/AB8cMox1wTHHUPPSffCy+FiNkl0qOpoPHlfL 4mbtXM1nFbG1En4BtPHIIc5aHEnkIU9SbKCHSUd9stR6wDA98J8j6FbPS2ylNetPNrS8xVTW9Rjd n5uP/eUgbA3Spr9JC23SF7mgf3ZeMtc32Wz3Z1DFpLSnoUpnpqmq+SnlhGOkgg4J+2U2zXE2vYyx 11sjrY6v+7LcuOfy4759llUbB2mWkNTQ1rZYwCSWuyDj6qSdrpfW0LHLUEASs6pCe3LTkrlbxJNo PU1nhs85mtd6D2VFM45ja4Yw9h8ZyrsRrrjYua222O6WR5qYQA6aLHzNb/mH2WN42SZNob+N2eoH 4iOEzOjecBwAyR98Ky9TcKW10dG6tkbFDL0Qhzu2XDgH6LX6up46LRt3jp2hkX4eVwaO3LT2+i34 5yymP25eXycMblPhVza3bq068stVFHWinu8QP924+PB+oUbaz0xcNK3ue13aIxzxHg44e3wR9F3O x808GvaQwPczIOSCpd+LSgpZtIW6vkiaaxkwa2XHzdJHI+ykluXGOlykktVIKOnj6rIjk+Vv9F6e OprzFbYp2Qyyj5eryfZZbc6Gkfqg5HhTqfh8vmOJ4+P+Aritf7X3zR1K2srYvVoi7pdMwcMPjPsl gj/HC2NsoZ62pZBTsc+R5wAAvAPlP0U5/DLa6W5aiqPxUbXdAaWkjkcoMqHYq5V+ln1lM7Fxa3rb Eezv+EH3URvtNVDcHUc8T4qhr/TcxwwQ7OFfW8y3W3V1JBaKON9K0tc+QEg8dwR+y5Xca0abtt2o NQ3WkYxtVK2GctZkgns77gq499Ri5aQHdNmbhDoh95pn9U8DPVkjP+JvnH2UVUFFJVVUcLBhz3Bo H1K/QGufa6fSUz53l1q9M9bunnpPfhVzslToi07kmCnlbW2Sta10U4Z80EueWke2ccq/+PJnl+1x c5qbZy42vRZvkLjI+BofPH/wnyPsol9JzhkAr9CL261U+kZ/4jJ/6K9PEjy3s0qBtCWHR1br64Wa n9G42ueMTU1QGZLHHuw/b3WfjbW+9K4+m4ckHCcbC+UNweVd1m1elYI5Keqo4egnDHdIycqu+6Gh m7ea5pXNY2otU7/Via7yAfmaVZN+jlI2o2Vmr9CMvdoqfWnERldE4gZAGSB9Vr9p9tKHXFBUn8Y+ Oshdh8XHA8FWQoqJkO3dRUaeqDTMko3SNjezqaHdBJH0/RQn8MBd/bKtd2LmNJA+pKut48meX7cU Xbm6IrtD340FX88UjfUhkHZze37rkOhx5wQr0bp6EtuvDLRvmEV2p4uuEkeCTj9MhcLoHaK2Vumq y332jbHcYXujdIByOeCCmprZMu9VVHpcPBwt1pixVN/usFDSty+U4+ysnovaSx3PTlxpKuNpqoJp IhOG88OIBWv2OotOwXmrtdQWQ32gncxjyP8AfNBxkFNbly+lt/aY/KHty9urjon8HPUf3lFVAhkg GCHgcghcJhxzhpKvZu9aLFebDFQ6hrIqMOLjTyyduvpHn9lHO1+z9oq7S+ouTIqrJcOscjj2+6k1 ra8lV3McDkjAWP0Vy7nstpW62+aCgaynqS09DmAgg+O6qXqux1WnL9WWuub01FM8td9R4P6p/Ysr VN5OO6nLRuyT9R6dpbpR3EPZK3J6W5wfIUGRH5xxwrhfCo9/9jahpcegyuPTngLO9VbHBVnw8XIU 0j6etY+QAlrSzuVBV0ttVa7jUUVVEWTwPMb247EK62uL7X6Dnivs076uzzVXo1NK45MbXH5Xxn/R aObbSwahqbjqG6Y/D1chqGyPJaA0gd/Zb+t/LnMvf8U7c13BIKRY7/KSrV6h2TsVy0/PVaUnhmqI h1N9OTra/HjK+WmtoNOag03SXCla9krD0VMZceoOHDgUs1Nry71FVywj/CeUYcPGArW6t2Htb7VL PYyRUwYe6Pqz1N9v2Wl1rslSR6MhuljY/wDFMDXOjznrB4I+6ai8lbsO9kNDnHgHCsjpfZegvmgn 1fzw3VjHk5PZwzwR+iy262jsN90zFU3MyQ1oc5sgdJ0g4PcfROJyVrOeeCmQ4f8A2lM+7O1DNGV1 FXQufLZZntEjhyWc88/ULv6XYyxV1Nb7hQ1Mj7fUMBJDsnkcJZrSTKXevhVgdRPIIPddNofS1Zq2 7Ggt7mCfoLx1nGQPZTBuTsT/AAq0/wAQ0+59QIyRLFnqOPot5tHtPPbmU95qKmSmrYyHs6eAB5B/ 1T+m91CWvNA3jRjYH3RjRHOS1r2EkZHhcQcjPJVw/ivYHbfUJkDS8TtJI9+kqnjhytZYaxmX2zhn ytn0RcSPITa4jzgrE+yFzdWfUfJyl1ecrAFGUHogqHwSB8b3Nc05a4HBB91Ndh+IK/0Npp6Ssgp6 uWFvSJ5M9TgO2fqoN/nlAJz3V0mna7ja6uGta8T1rumIEubGOQ1x74XFE8oSVtt9kknUPKRRlBUU gU0sI8oH5R3QUBAI8IQgMoQjugE0sJ4CBJ9ggICAKEJ5QCQTSQPsgd0fVHlKBCCgoBCEeEB4T8JI CgfZHhHhA8oABLHhNLyihPykhA0FGUHwgEdwkU8IDuUI8pogSR5QgaXlNBQGEk0kB3Qj7oQ0PCQT QEAmkjCAymkjsgBwhCQQPyjyg8I8oBCEIDwhCEAjwhIIGhLymgSfhJPGUB4R2QUd0AjCEBU0O6Ch IoAJ/QJIyihMchCaIQPCEIQCAhHhAIQn4QLCOwQjCARnlCEAjjCAjHKAQjyhFCChCAQhA7oD7oym kgaR7IQfdE2AmkgIppFBR2RAjygoz2Q2EFHlNFJPwkAkqjIIS7IQCPKaXZA+yEggoBNIJnhAeUJY QEIaWEJooQjyhAeUv0TS5QNASymiBHdCEAhBSQCaPKEBhAQhAI8oQgOyWMJoQGPqj7Iyg90AhPyg 90C7oQE1oLGEYWXlJAkYWX2S7IEjCaAUCQeU8oQLH1R0j2TCxQTkhCF8N7yPssHLNYPB8IIy3L/+ K0Hv6eP5rkDyxdbuWf8A03F/86H9SuSJ+Tjsvp+L/WPJn7rFCELowEIQgEIQgEIQglHYvXVPpDUb XXFrjRTfK5w7sPupW350u28zUGs7ZMystXpsjqPTOSxmeHj3HPPsquRA5BHut3S367QULqKK4VTK RwIMIlPRg/TsgufY6y3aP27/AIqwmehZE2QOjwTjtwlUS2zdLbmYRyR5OHNfj/dvbyD7hU0hv13i tz7dHcaoULxg0/qEsx/y9k7Tf7vZ/UFtuFTTNkHztjkIDvuOxTTNXo0NbJKDR7aFwBJhLGuHLTlp Hdae16LEFlZ/GZHzPpQ58XUc+ke/B9lUKk1xqelZ0U15r448k9LZXABfZ+4GrCHNdfa4scMFpkOC PYpoWg39nEe29PM13yNlhcXD255W6bXC57RSzwy+uHUTwHA57MVNqvVN8rLaaCquVTNRHH9y95LR jtwsLbqq+2qilo6G51MFJJkPha89JyMHhdMc7ON+nDLw8plN+04fD9pOCvcLtFIHyxHpIByWn6he z4otVWurstPY4ZhJXQyB7uggtHGCD7EKvtl1Fd7HO+az3Coo3vGHek8jq+61tzuFTcKqWprJHSzS Eue9x5JPcqbsvKO3Hc1XjdjJ+6+lJUzUlTHPTyuimjd1Mew4LT75XyB45SPZZbSNBvFreGJsYvtS ekYBOCf6LyX/AHR1TfbVPbbrc31FJMMPjcBg+fZcJhBQB/Mp8+FWsgj1RUwPe1srw0taTyefCgPx yvbarjV22siq6Cd9PUxHqZIw4LSguduFrCvsW5tmt8VaYKGqj+dpIwXZK+PxJ1LYtDUEziSBVRuP 18qqepNX3vUslPLeKx1RNCMMkIw4fqF97xr3UV3sjLVdLjLU0bMdLZOSMdsFdec5TKT4cPx3jq35 XM03UUOsNtGR0czZYZovTf0nlvbIPsVXXc/QH/Z9drbdIahtRb5Jm9bA4F8RBzyPYhRvpPW190rJ K6yXCWlEv52A5a764PlfLVerLrqirbU3iqNROGhvVjHA7LljvHDh8OuUlz567XdpfwOs9t2xUsrZ 6WqiDHFhzjtkH2K4HRm2UmkNdR1VNUsno3MIDc5czt3Va9Ia+1BpNsjbLcZYIpOXx92k++Cvc/dH U5vwvEdzfHXdIYXMwGuA929k+NHHvawvxPVV0tdFaLvaZZoRTzODpYycNzjGf1Cgi7a1vO4FdaqG +VET3xydMcpaG4LsA5P6L56g3Y1RqCzVFrutayejqBh7TGP0IK4JhLSOkkEdj5Wsst6jGGGva/1l t80GgHUAaXT/AIV0bQO7iWEBQP8ADd/smvbjSVI9KoYAwsdwQQ45GFwVo3m1pa6CGkjufqRQt6WG WMOdjwMrmJdY3d2qpNQQVHoXN8nqmSIYHV54+qSyYcU4fvz2vJV0c43BhuBB/C/hmx5+vUT/AKrY 0tTC7UdfAx7PVMMbukHnGTyqhxb86zA+athJ+sI5XLjcXUEepP43TVz4q3qLiWn5TnuMdsfRS9tW bmlzND00tG68U9QwslfUPlaCMdQLs5Huq3acq47DvpK26u/Dh1VICX8D5j8pWort8NXVb6aV1TEy ancXMexmM57g+4OFxetdW12rryLpcxEKv02xudE3p6g3sSPdXl+mWP2zw/eZ/U0uhulo/wDtrQ2+ lbOYfTL5GvbyMlo/6L7bY0b7Rpyps0rh+Novlc3PPYlp+xVVtPb26rs9oitwqYqiCIdLDMzqcG+2 VqrNubqO0ailu9DVkTS8PY75mFv+XHsPHsszqRrjrf8AVqbJV63rPxDax1FTyRk9GYRlw+6qhvNU XGo1/cjeoGQV7MMkDOzsdnD7hdpJ8Qmq3sLXiiAcCD/dckfuojvtzqLxcZayrkMkr/JOcDwP0W8s t/Gkww1p4ou4zx9VdH4b7VPa9INFQ0D1syNIOQQVSxpIPupP0JvLqLSNpFtp3Q1FIw5iEwJMfuAf Zc28u5p1e9WtLrHc71pW4tElEKoVFO5+euMZzgHyFOVpkbetlC22uEzpaQsb0HOXdOMKou42uKnX Fzp7hX09PFVxR+m58Qx1tzkZ+y2G3G5980QJoaB7JqOXkwTZLQ73HsV05f8AJjn9OX4t+PLx/a1O yFsrLLpB9Lc2GOoDicH78La7aUE1BQXWGpYWPfUSSAH2LjhV0rfiBv1ZRTUzqKiaJWlvUwFrmnwQ Qe4Xw03v5qS00LKWpipa3pJIlkaQ858EhTPLl/8AUxw43f8ANN1Du7fNKa1u1DX9FRSul9JzZRzG 0HgjH0KsZSSMuOkaOejLXxvLJBg5HT1An+So3uLqp2r9SOvD6SKkmkjayRkRyHEZ+b7ldRtxvBfd IW2S3N9OroTyxk2T6fvg+yZ5cstxcJxx1VxqWBtK28emwMikBkZgYBy05WjrpG2bRtNWW+iiqCSz LC3IAJ+YhVxqt+b3UaemtxibHOSRHVRuIe1ucgEeeOF5dE743rTdvkoKuKK4UpPVGJTgx57j6j6J P6WW+k878U8lz2vLaWLL5HRFrGDsc+FtNGwVNv2mjhIfHVw0zsDy1wHCgOHfutLLhS1VuhqKCqBL I3PIMLiP8J9s8geF7LF8Q9worZDS11rpql8bQwvDy3rA8ke6u98f4zMLMc59vdobe2sbM6yaip2S ieYt/EZ6SC44OQpn19UVVFZ7J/DAfRlqGNn6BkGMjnKpFqu7su2pK+5UsApY6mUyiIHIYT4H6qWN Fb+19qsEVrvNHHcWwDpZI9xBLfYqyyZbW4W4yJR+KZrpNuKF8YLmCVpJHt0qnR7qcrvvcy+aZudj u1sZLSTF/wCHcH5dED+UfofKgw91blvDHH6XDHjllfsikO6yP6pEecrk6sU00EHKoWU0gE8eUC8o 8oz24wgoApJpZKATQjxlAICB9EIAoQgcIBLyn90YQCEIBQMISJQEBymEkIGUBCEBnlCCgIGPqllH dHlA/uhHlCATSKFABPKEigaSEdkAEIKEDCEuU0AEYKPsgoAFGUe6SBoQhAeUIyhAI/RCCECzwn3Q kgeUBLwsggRRlBR2KACCmkSgMI7BCaBICCjCAQjAwhAd0ZRlL7oH3SR3TQHlCEIA90HsgpIH4QkU +VQFA7I8JIo+6fjKSYQJCEwgRQg90IGRymEucJH6ohoQEFAIykD/ACTxlABCOxSz/JAyhCO6KAke 6EIGgo8I8oBHhCM+yIMoQjPugYSCSaA+qPKM8oQCPCEkAmlhNAI8oKMoDKWUIVAj9E0vdAJ5SKf2 QCD3SQEDzyjKDyhAAp5SCEAChCaBJpJoEUeEIQAQmhAIPKSEDSQhA0I4SQNHlHhCAQgoQCEI8oAo QjwgPumjHCRQNBS8oQMI8ICPC0AIR5TCBI7oKEAhCMZQGUIHCAgEs/ZNLAQTijCeEcr4T3sSllZL EKwRZuUc3xg9ox/quUdw3C6rcg5vrff0x/UrlXfkHC+n4/8AWPJn7rFCELowEIQgEIQgEspoHcIJ E2x0TPqaraQzqgacOUq652y0tYLbSVU1W2mqy9oEDuRMM/MPocL7fCoB6NT27n+i4z4hJ5n7lzwt e8xCNhDMnAJ78LeOO5b9OeWcmUx+3a6y2YtkulYrzpyRwkDWudEOWuae5W6sm0FjqdNNq6uL0quK MvdkcOwM4/XC6vYyau/sjDSXKIuj6MxvPILfYrX796gnstggt0FNK1la5oZUxvwIy1wPSePI+qmP ZneM2Vu2p0hVWeK4ekBH6fXJ8uenAyV827Q6OuVvFwtb454Bk9TOQcdwfYrudFvjZoaF9UemL0iZ HewxyVw10ldpnX9pi088C03em6qhrOYnuH+IDwcLO1jmdd7H09NSw3TToMjWYdPTHyzyR9V5tb7Q Wo6Bfe7X/s9XDEZS0jh2O4Knq83uksLbca94jhqXiAPPZp6eM/Rafc9jYdvbuIQBGYHOHT2OfIXb w48s8ZfVcfPnxwuWPwr9tNonS2vdPz0Ukn4a9xN9+T9R7qKNfaRuGjr9NbLpGQ9nMcgHyyN8EKQf h6DhrqMjLQIzz+qkj4vYIn6cssxjb67ahzQ/HOOntlc7/tY7S9bVOzhMAk9kzj9V1e3GnqLU9/Zb aysFK6UYjJ4Dj7ZKjbk+l2cYykQrMO+HFx/LXSY/5Qo53U2jumiKNtwz+JtxcGveO8ZPbP0TQi3s vRR9InjMjepgIyPcL4AYPZfWnH940fVBa/RW02k9T6UpLjTsw6Vg6hkgtKgvc/RH9l9TzUVum/G0 ZaHskj+boz3a4jsQrRfD9n/s8p8/5R/VRtt1XRSbt3y3XCBtTSVE8uA4flIPcfut4Y8sLl9OOWdn kmH2ru221T2FwhlIHnpK+Yo5nMLmseQ3uQMgK99Tp6yWe6QUk9AyWkuBIhw0ZY4cuB+nIXntu3Nl tl7qo2Usb6OsaXek5oPQ4DnH0Wdx07UVhppJXYY1zj9BlZR0crnFvQ7q9gOyszpzSVstW91xt0EA dRem17Y3gENJ7gLtL3t9Q27XlFX2qiYYZmuFTCQOk4PBHsVrLDjdVjHyTObimclLLC3L43AdgXAr YaZho5b3SR3Lq/CPeBIWnkBXhve31g1BbZ6KrtTqf1GkNk6R8rvcEexVMNSWGbTOrqy0TOD5KWbo 6x/iGeCsOk7TfrXY23HR8t007UYmjh/EDrdkPaBkj7quVFCJaqKNwOHOAKvS89O0kuD/APGbv/Iq Z6OrmW3VdFUSQsmjbKA6NwyHAnlamO/HPI58/wDly8f0lnV2zVHFt+NQWKcukii9V7HHIc0DnH1U GUUAlqY2ua4sLh1Y74zyrt68oY3bVXCe1zz0sZpi8MGC3ty0j6qLdjNtaavpIrzXMZKyTljXDIaF q4z8cySZ38lwvw+lPsdab9o9lwslU8TSR9TC45w7HYjwq7VlBNS1U1NK3EsTyx2O2QcL9CLFS2+j oamG24ETWgkNILefbCg/abSzaq+Xqe722Oejmne5jy0Fw5P8kxxl8dyvuJlnZ5JhPWlXHRuacOGF 1e3mj59V3yOjid0sPzOd9PorQbjbSWbUGnKmS0U4pLlTtL4j0hodgHg491z/AMO92sVbTNt0lKKW +UZ6XOaziQZxnPusX1tuXd0hPdrb2p0NdoGF/q0dSzqice4I7grgPScRw0q7O98elqyjNDqac09W 6JxpXhmfmxx/PC1O2G2VjOlKaqrqSKodMzrLnMDjnC1lJNMYZ3Lf8U6Mbmg5avmeyu3qLaTS9+tF RTUlKKOqLSY5AzpLXeFTXUVrnst5rbbVgCoppXRPx7g91musu2vYVIez+j6PWl8kt9VVup5ujqiA x8/uFHY4CknYnJ3EtQBx85P8lPXa6dvuBsXNp+xy3K31L5/Q5ljcBnp7ZH2Xr0tsLJc7RFU1tW+n meA7pABGD27qRviTrp6Sy2MU8z4zNUGN/ScdTSBkH3C6LX076HZuqngcWSx0zelw4IOQuvD1r5ce c1cvpBGvti66xWSS5UEzqtkPMrS3BDfcYX00Fsn/AGl0zTXRta6P1gT0gDhThs5VTXTbNstc8yul id1dZznuFwGw+u3NrKnS0kXMcznU8g7dPUctIWPWFy+mp3nxc9efh9q6SglqIK0yemOpwLR+Udz+ yX/wPU1Vb46mjuQe2VgcxxZkHI+6lrdTXzNGXmnpayJ0lBXU8jHdHdjsEA/ZevREz27QNlZI4kU8 jmOzyOCQt3Gy4y/Ll+WXDLOf+Kl9TYZrfqp9kuT2wSxVH4eR5HDecdX2U1N+HeslhjkhubXMeAQ4 MyCD5ChW9VtVc7zNWV0rp6iQ/NI/kux7q7WjY6iu2mo4Y5S2ofS9EbyeWnHCxl+vkmDrLvx/kVY3 M2ku2jKFldIfxNIThz2tx0n6qLXDn2V7daQGl2lq6K+yerUGnczrl56nAcclUUmHTIQtZYaxmX9Z w8nLO4fQjb1OA8Kb7XsHeLhbKeriqoemZgeB0k4yMqD2cOBV2dg9fw6osVDbmMMdXSRmOoYeQQAO lwP1XPlxdtb9K8a+2cvWlLG+6TuZLTRkCQtaQWg8AqLHMLXYKu1qzU9Fer3ddB3RjmyVPp+g8chz TguB9iMKC96ts6fRd4t7qWUvpKx3T0nuCDyvR+Pd18vLj5upfioYDHE8AlZdBzghWcvmzOn7bbrX dJppI6OV0bZ8u7deAD+5Wwm2GsVJdR+KqnsoZmAwyF4Der2JP07LlZOnfHLe1Uuk57EJEZbnB/ZW G1ZsTLQ6ioIrbL6lBVnAceS0jkjP2XWO2AsLOls1ZKx5aCQXY7pr5OSpjhnB7JHhSnvRtbUaFqop 4XGW2z8Ryex9iorxjgqWNS7LwhHlCimhIIKAygoR5QPKSO6EAhNIoBNLCEDTykEYQNJACCgeEIQg E8JJ5QJGUFPsgX3TR3QgEeEIyoDsjwhCAwmEvKEAU+wSQgaAkUIGhHCAgSE0kAmkUBA8I7BGeEID KO6OyECCAmkgaM8pHlAPCDJIpJoBJNJAwmkCgIF5WSxTQCEIQCD9UvCaAAQEgeU0B2STS7fdA0vC EKgQgp44RQe3ukj6IQMdkuyZSQCEeUIBCMpnsgWVkeyxCaIDwEHskjygD2TCEgeUDCQ7rJJAZSJR 7oCKeOOUHhGUeUQI+yAjygEgmUIBCEIBHhAQgSEI8oGhJNAIKPKPCA7hCXlCoaRSWSBJpIQA7oPd GEIAIQhAZTzwkgoBCAhA/HCM4KQTQCaSaAykUBMlABI8oyhAI+yEeEAgIxlPCBJpHsgIGhBRlUCE FIDlQPhCPKO6AR9kICof2SPdA5SQNCAmgEBCFQeUDsjwkP5IGlkFPHlIoH2CEBCBpJJoDyj9Eufo mgnId0FPCMFfCe9iVj91meVgR7LUEU7i/wDxdGR/gGP5rln/AJV0+4v/AN0JH/zNq5l35F9Lx/6x 5M/dYIQhdGAhCEAhCEAhCEEo7Jbh/wBib038Ywy26Y9MoHdn1ClbdqxWi71NDri0VkVXQHpFXE1w LgzP5gPp5Cq9C1xHZeuOSZrSxj348tycfsruyajNxlu12KrVFt0vtz/FbRNDUwNjYWsbIM88Ej7L Fl0s25m3knrVMLXtAe7LgCx7eRkeFSpkk3SWB72tPdoJA/ZfWCWogJ9GR7C7uGuIz+ykhe/a+9gh pn6NbRR1UD2TQOY17XgjluPda236ctdksH+0GJ0kLS4PLwQ0jyDnhUiZVV8bcRTTMaecNeQP2TdX 3EfKamfB8eo7H9U0LZ/EFcaf+xVoqoZmSxNqo3kscDxgLa3260l32Xq6ignZOw0h/K4EjHcKmElZ VOhMTp5TH/kLjj9ljT11ZTNcyGeWNruC1ryAR9l0wzuFxs+HLLxTKWfazXw82K1VND/EKWdklWw4 kbkdTD7YXMfExrq3X4U9locvlopS98oPGcYLSO4IwoLp6yqopDJSzzQOPcxuLSf2XlqZ3zzOkme5 8jyS5zjkk/VZvvbrJ8Pi7GUQyPhe1zHOa5vIcDggrE9kh391GnSRa21HGwNbe7iAOw/EOx/VfK4a tvdxo30tdc6uenkx1RvlLmn7haEFCA7knPC9NCWCpj9UlsfUOo98BeVoyeF9mRuxkDhBfLZyjp6X RFK2hnZPTSRjoka7IKhKzRnS2/FRBeiKczyufE55wHB5+UgqFLTqK82uH0bfcauniznojlcB+y+V 3vFwutSye41c1ROxvS18jyXAe2VvHPjhcZ8uOXjl8kzXo15X09JeNLyVMrY43VD2tcTgElrccpa5 1hSaTvVlqLp8tDVPfE6XwwkDB+ypBWalvNbRQ01bcKmeniOY2ySEhp+meyxuOpbvc6SKluFfUVME X+7ZI8uDeMcZWI3lLdaXih01Qv1TJqalnbKypja4StORgc/thYW7Xun7nrF9pjq2fi2twzqI6ZM/ 5T7/AE7qlVs1rqG10gpaK7VcVO38sYkPSP0Wq/iNV+M/Eid7Z+rrEjTgh3fK1lbl3WccJh1H6A28 1Fvv9aK2V4pKuUmAk/Lk/wCH6FVh3dsRi3pkjubxTU1weySOZ35SO3f7qOKvXmpaqmEFRd6uSPIO DIe4OQc+68F/1Pd7+2D+L1stWYAQx0hyRn6rPw3J3temptU0u3k9spx1zOpnNZj/ABZbwqWaatDZ tcQ2uvlbSStn9N3qcYcD2WNu3H1VQ0sVNT3usbFE3pY0yE9I9lztxuVTcLjNXVMrn1Urut8meS73 +63Mv+Pg5zx2eS+T7X11Faqir22rLZTN6ql1O5rW/wCbjjC474dL7SVGmp7K5/pXSiJZLTv4cMHv hVlot0NX0tPHBHe6oxxt6Whzs4A+60tJqS60l6N3pKyWG4OeXmZhwST3z91LlvGY/S8JzuX2vToq jktdHV2ysyyof1Oj6uPUGTyPfGQtbtjW0/4a5WV5EV2onvD4ncPAOcOHuD7qo9Vudqyonp5prvUe rA4vjcHY6SRg4+68M2vNQS6hbe23GVlzawMMzDguaPB905XVn2cZLLF4tOy1j7TVUFzkc+4NY7pL +7xyAR7qsO1dwh0nu/U0t6cKYvlMJL+A1xdkZ+hXG1O6mrqirp6p12mE9P1dD24B5HIPuOFzWpL/ AF2obq+5XOUSVcgAdIAATjsT9VL3jcVxmsua7G5ehKTWlTFLUzGIQxkxvDsDnyfovXpIOGiKi1W+ qYbhQtdB1McCWuA+U/Yqolt3Z1dQWttBFdpXU7WGMB4Dj04xjJ+i0+nNb33TtxkrbTXyQSyDpfzk OH1BV5W2W/DF8U1cZ1tb+02/WMtvldX3p0NVj5A9oLf14VOtxXVr9ZXb+KOY6uE7hK5n5XH3H0K6 up3q1jUwSQzXPrjkaWuBYDkEYUb1cslTO6WV5e93JJ5Ktu2vHjx6fAe3lS58OdpluGtI6qFzcUeH OaTzg+QokcC368La6X1DctNXWK4WiqfTVTOA5vYj2I8hYsddra/E5BK/TNpro2OdT0lR1SuAyGgg DldNeYxrDZ0w2aRkxqIWhhacjORkKr173m1Ne7NVWu4VEMtNUxlkjfTAyFq9C7j6h0dHNT2mrIpp T1OieOpoPuPYrpM7Ljfpw/FNZY/a4G2lql0/ob+H1uGSxxkHJ45yoI2EtNTU7hVdxjDXQU0r2yc8 gk+y5S8b16rulvnoqioi9KUDJbGA4Y7EELktIa0vGlby+42mp9OaQFsjXDqbID7hZt3hcPtudZzP +LAfFTQVFRdLJJGzMTyYmv8AHUTwMqUNJWqopNrBbXtzUtpXM6R5Jbwqrau3cvmqbJJbLoKd8L3N eCGYcxwOQWnwtlZd+NWW23U9IZKecQtDBJIzLiB2yteTPlcLP/Fyw8XHDPC/+SRKDZGnm0XWT1IL bs5hkjd2LXD/AAqU7Tb6yDab8DG1wro6UtaBwQ4DjCrpUfEBqeenlikZSYkY5hLWEEZGMjnusbX8 QGqKOhgp5m0lQ6JoZ6jmEOcB2zz3WblvOZ323cf+O+Oelg77FNLsvVQ3QufWCkd1+ocnrAyqJzu6 pPcqWtW72ag1FaH0M0VNACeJIQQQCMEfXIURu5PC1ct4TH+phhrO5Mc8qznwkWuphqau4vjIpZ29 DH+CR3VYieexUjbY7rXjQkM9LSNjqKOUhwjlz8jvcfdcs5uO8ukuauP4H4j7dNVf3cUrowxzuAeM f1XTfEVYrhe6qyChp3zNie5zi0ZwFEd41u/de+2O31sVNbqlsxayraST8w4H7jjlWO05R6ro6Olo 7pUUlZFCA38QWHrI+vjK9E8s/Jz/AJp5PwX8eOG/V21W7jSNqYGEYINOCD/zBezc6lqarbaijoY3 uma+Bw6ByACM/wAl5d0LhRXOGl0v+JiZXVUrAw9mlzXAluO4z4XS6tq7jZ9GfibXTR1dTSRAyQO/ xNaOVyk1lhpZnuZ3+vRc3BkFgDiG4mizn7Fc9uPqm52TUdLSUdjbcoJogTJ0kFh6iOSPCrhr3ei6 6hjp46cCi9JwP90T3actI9iCumt/xI1jaGnjuVqgqaiNga+QvI6/r24W8bMNStZTLOdXXbd/Ehdr u/RMFNd7bFTwSSt9F8b+sNcBnGfsqtO7KVt2N2qvXFFHRspxS0YwXQ9XWOodiDjg/ZRQTys276bw w477Dlj4TSWXQI8oPdCBoCMhIcIGUFHlHlAdk0ihA0YQkgY7IQgFABCPCCgYSCaEAPukjKaAP0QU FHjKB44QgIUB90IR5QGEIwhABCEFAIKEIBCeEkDIS8po8oBJPylhAf1THZJAQCf80kIBGUwl4QAQ go8IBCEIBMlLsEBA0kDun2QBSTBKXYoGQgdkHhCBY5TKRTHZAkFHZMoAICDwlnlAykEykqDwhCEU J5+iSEDSJTQECRhCaBfVCMI8IBCEIBCEkDTKSZ/kgO6EFLKJo8o7JfVPwhok0sYTRR2SPdNI9kDx wgoBQeQiBJMn+SPCA7oQOPKCUAllCOUAml4QgfhCB2QgQQhBVAhCAgEIwhAIQmPCA8oQe6PCBJpF CBkpdkJoDCQPKaX+qBlLyml2QNCPHKCgEk+yECIwmjGUBABNJHZAFCChAIHBR4QEAee6PCM5RjPZ aACmlhNQCEIQHUmsQnk4VAThLv3Qe6eEAjsjyn2QB5QEIwgAhLt3THZAcIwke6fhAICSED8oR7o7 DKAwj9UDlPCCcsJ900YXw9PexwsXD2X07rE4w7OOyuIiLcI51ER7RtXNv4YF0e4H/wB0kn/I3+i5 p54C+n4/9Y8mftihCFtgIQhAIQhAIaOpwHuhDfzD7oJk2Z2//tHK2rlaHwsOMY4Uh7jWDQ9gloA4 MjuvqAGOLpLXNBHUHgfl78ZXs+Fsg2SXHu5RXvU2Sbdm5sZ1HL2gfRaxxtlrGWWspil7W+01lu2n qS66eiDKkdDnen+V7T3yF0DdA6eo9Mx1NdSQRVcUfWCQ0eoQMgc98rcbPQ3Ck0nT0twIkYG/3b/O PYrl/iAudxo6a229lK02yplZ/tAzmN7Xfl9sEKY7t6TOzHuuoh0hpWWwx3M20CP0vUe0MBPAyQB5 XjptGaLvltbc7TTxPaw4I6QC0+Wub4K6qzzwUmjIp6vP4eOIukxyQ3yo/nkFLudS1FhkAtNwpGCU w/7uR4zyQOM9vqptp5dd7MW2YQXPT0AZPE5r5qfHyys4Jx7Fa7dXbWxSbdTXqlh/C19NF6jXMbgO 55a4KX9R6hptPVdpbW5EFdKYOod2ODQQf5rRbz9LdsL2WEFhhyCOxyQuninLKSufkvHG2Id2ismk tfaWls1xpm093ib0iRoAJ9nAqGdyNFXDRGoZLdcGlzMl0MwHyyt9/upO+GyJ7dXucQejoAz9crov jAaC2ynAyHPwf2WcJzys+m/JlwmP9VhPZDW555TJzngLudqrTYb5exb9QVP4b1cCKQu6Wk+xPhRt w/Q7HYpFqte7YjS5AxcmAEcH1xyos3k2pGjqSK52urjq7c53RIA8F0ZPY8eEERtHPCsH8OekbTqW kr2XWlZNg4a4jkcKvzTyMq0PwlzRGGui62mTqyW55xhS3U6Gqpdt7TaN5n2V7RVW58AmY2QZLcnt +i8G/wDtlQaaqrdW2LIZWvdG+nA/KRyCFKFfTyO31NR6Z9JlIxpdjgErW/FNUPpaCwywu6ZG1L3N PsQAvR+Oc9fx455srjL914NM7X6d1PoAMkhFHcmRf7wtw4Pxx9xlVzk01cvWqGQ0sszYHmN72NJG QcK7emIaS/6BimraWMSSUvzloxz0nkexUPfDvXZ1HdLRVRtqKQuJ/vOSD1EZysanG5O8yvLigF2n bo2EymiqegDOfTOAFudDaRqb/dqaGSGVtO9+HP6eAroXGfTlmuUVqrhTsdUn+7jkwA4E4wD2XEPd S6F3IgtlPSsqLPdwZIm9jBKDyAfLSs2aJnLekcby7RUti0rTXe0Nc2aLDZYwMh7SPzfdQYbVWOgN Q2nldCO7w09I/VXt3N1FQ6b01HVXGgNdRSEMdDnBwQtBtPbLJetMVboKEfw6eVzo4pACWtce36LV x/SZM4+Tedx+lL3WurFN+IFNKYPMnScfuijtlVWdQpqeWXHfoaTj9ldvQ2mLVNYLpbpKSN9JHPLE 1rhn5eojC4rZzRs1rv11mjiZJbHzObHE4Z4BIGCszHct+mrnrKY/arFbbaqiI/EwSxdXbraQuk2y gtVTqyjpr9GX0cx9M4P5SexVxtbaBtWqdN1lLWUDaacNJhlbyQ7HBVN9N0jqLW1HSvOXRVbYyR5w 5Sy8eXwsst4/KZ96doLTZ9HTXyxH03U2HFuSRI0nCgbSdDHXX2iiqmudTPkaJekchvlXH3sPTs9X Dx6bB/7pVe2duAtuuKAvibNDM8QyMcO4K1cdeOZs4Zcsrj9JE3i2ktlm0dHqGwOLI4w31Y85Dmu4 yFBIt1S/lsMhafPScK33xEUMEO2c0tH6kLcs+RrsNIJ7ELPZ+u03fdHUzBBAa+mb0SwuaA4kDuPf KXHWMy+0xz5ZXGfCnklvqYwS+CQAeSCsY6GZ7ctjcfsMq+t6tem6aySVVzoIoYCwkiTADhjOM9sn xyvDpDRWn6ezCot9Cx9NM4vjY9oLsHnys7je6opJSSx/7yNzfuMLfaJoKKt1HRQ3Vsn4J7+mQsPL c9iroak25sOpLPUUdRbhSTFuY5Q0ZDvBXL7f7Y2rS9vlqrwIX4OHyyfl7489lZ36S5OA3R2ToLZo 2a+WOdzvQYJSC7Ie1VxcPmHCvvuaIRtFdhTAth9BwaD45/oqFSj5/stXGfjmf9THO3O4/RR4ypX2 P0fZ9aXGpoLnO+KrA6oQDgOHn9VEoUvfDdn/ALQ6T26HFcrdTbvJyunU7n7K0+nrdHW2uqL3Nkay SKR3OHHAI/Vb6ybBW19qhlulW+KZw+b5gG/zW5+IiV7dW6aY0kB8oa4DyOoLpN+Jn0214licWPb6 eCO/dduP/Jjh9zbwTz24ZZ69XSLtY7EMtkdLW2yofNRulayYZBLWk46hheXXGw1Va6KCts0rqmF5 HW13cA+VOWgnOl2ipXynqcaYu5+y6iou9FbbbbW3KRkcVU1kQLzhpcRwD91jHLlJp6c/0t2rm/YE tsMNZ+LeJwW+s3AwBnnC1Ottiq+ztpam1SPq6aZwa4EctJ7H7K0N9qIpNJ1j4T8jWFg+hBwvtU3C jo6S209fIxn4tojYJOA5waDjPuk77NK0z7BPgs9NXGsd1FzWysI/LkgH+q4vdnamfQrqKcTmekqn FjXEYIcOVb/VMzJNJySQ56epg+ow4BRR8Vmf7MWIY59c/wDlWsZyZyy4om1rszUWTQzNR01SZo2x tklYW4wD7fbKhdwweFeXcIf/AFA6lvvRs/0VHJeHqcd+OZtzL9ricUz4ntfG4te05aQcEEdiF20G 6mr2Rtb/ABurHSAAQ7k491wmcFBPCw23121Nc7rcm19dWSyVYIIlzhwI7HPuujbu1q70HQvvFRI1 wLSXnJIIx3Ue5IQTlVH1lf1PJPk5KxyfdYZJTyimXH9UvKEZ4QGUJDhCACEJoEgo7FAQPwkOEJoG l9kDlBQH2TSCCgaEeEBAIykj7IMkvohGUDTSHZHlAykEICUBTCB9UKATS8IQARkIRhAIAQhAIQQh AICEIBCE0C90JkcFLCA7oQUIHhCOUAZQAQEIQCRTCCgSEIQAQhCB5SymEvKA8ppeU+6AQhHdAdkD ukR2TCA/0QDnCPKSAKEBPAQBSQhUCEeEIppIR4QAQhCA8oQjugEFMpIAo8IygoBHhCOyAQfqmO6R QMcjCXZAQgEeUI8oHhJB7JIGmAkhA0FIo8IgygI900AeyQTKSAPdGcIPIR5+qBoS8o9kAeyEdkIB HhCXdWBoQTwhAeEIQgEdkIQCEJlAkZQUIBCEeUAUeEd0BAIRn+SED8IQOyCEBjlGfCAOUZQB7I/Z HlCA8oRhCIEIR5QH2QhCAI5QchNCqkUcJpduyoaRSx2QoGeOOEcYRxjKMZVC8phI8FZN7FAHnCAU v8XCBwUGRQkeUeED4KEvomOyAQeyRT8IFkFH9U0eUAeyR7JnORhIgIBvZPKWOUZQTv4QnjhGPK+I 95eFiR3z7LM/ZYuHB98LUgh/X5/+GN//ACNXNydguh16erUcwHhoC56T8oX0cPUePL2wQhC2yEIQ gEIQgEeUIQSbs5uTPoe7tMzTNbZTiWPy36hSfuPVaPrrrRazstypJ5C5oq6MyDrc08dQb3yPKrZT wvlIDGlxPgDJXpZTT+r6fpP6z46TlN6Sza32ptzLNadDMqtMXKjqJ/kBgEo62g98DvkL7M1tpPW+ h2NulypmVMYD3QySBkge3kHB7qnf4eWOUtdGQ/t0kYK9H8PrRIB+Gl6iOPlOSrOvSWS9VeGk1Hpa q0v/AA8X+3dEsPT807QQCOxBXyhuukbNZPThudteYwDlsrT25yFSqO3XAjmmlHv8hWDqKrD+n0X5 9uk5TSrR766utFRZ9O1lurqesiiqvVd6MgcQOkePC9+t9YWO/bOVzrfcaaWR0A/uRIOsEOBILe6q OIZi70+h3XnHSBySsJIpYHmNzHsce7SCCVcbxu4zcZfa0Wxtx0pDY/xDK6mgrom5lhlkDZMj2z3C jD4gdwKfWNzgpaJn+z0hcWykYJJ7gjJ7Y7qK5IZ4miR8ckYPZxBH8145HEk9Xc+VPXcasl9vmcjO Csmux5OViO6ZUV6W104Ab60mP+YokrZ3sdG+WRzT3aXEj9l5D3TA4QHnsuo0Jq24aQvcNytkha9h HWwnh7fIK5kL7Mp5Ht6mtOB3ODgKi7+ndyNL6isDtQF8cVbTR4qac462/p3I+qr5uRuPHrHUlNHW ZZZoJBhreSPBcPPIxwoqp2ztJ9MvyRg9OeyZp5iM9B478KzKudwxq+uhKi1u0jBFQ3Cnlp5IemN4 kHtjn91F20NpoLDr68UVVVxsukcpcGOcAJIycgtPlVhgmrIR0075Q0c4aTj+SZqamWYSGSQy/wCb Jz+6b60Sd7Wa+Ku1z1dso75QysfDSu6JQxw6m9R4P7qA9J6vqrZqC31tbNNUxU0nV0veSQPOMrSz 11xfA6OaondEfzNc8kfstWQQcjgpnlc9bPHhMPS/UVTYNw9LUUsc8NTRuA6mFwy047EeCFrNDXrT Ng1BV6Xt9fGCDmNrvl+bPzN58qkdDc62iJ/C1M0Ge/Q8j+ictdVSVAqHTyGbOevqPVn3ym7xmPxD hOVy13V/bCyKyVVVS1c8QbXTvfA4OBySckH2PPHutHoa80lrv9z0rcpGQ3DrM8DXkYmY4kgtPv8A RUpkv10ka0S19S7B6hmR3BHlfOe83CpqY6masnfPHjokLyXD7HurLqWLcd3a++n2izMltlfVMDqk u/DlzsB3kj+YVWqTTbbdvS623uZtK/8AEetE9xw1+TlvP1UaT6ku9T0CouFTJ0HqYXSklp9x7LzV lyrLhO2esqJZp2gND3uJOB2GVd/rcfis8P2mS8+6dlqL5trX22j6XVPpBzW5/N084Cqds9RUtbr6 jp66YU0jH5jD+Op4P5fuucj1ZfoI2sjutY1reAPWdj+q0bqmU1RqPUeJurr6wcHq75yly/SYGGHH K5fa829Fkqr3trV01Cz1J4WCQtHkN5K82ytstDdG0ddaWxyPe3MgaRkPHcH25VP4db6hhb0tvFbg jBHrO5H15Xxs2pLzanSfwy4VNOJDlwjkIBPvhS5W4zH6THx8crl9rv6h0kdVsqYru50YeOmIRO4a M8ZA8j3Xz0/PDctIXDT9urWNudvLqZ4zhzHAYDsKnDtwNUAjN5rc+/qnK10Grb1SXSW4U9xqIqyX /eSteQ53391nHq7aym5pcah0rdaOyTOu+oq4VMYLhK6Z3QPuPb6r301RBrLbuvt1trYp61vVDKQ8 H5we/wCvgqnku42qaiB8Mt4qnxyNLXNe/III5WusWorzZJ3zWqvnpnyDD/TcQHD6hb5avJjh1xXV 1JQzXXa65WanANxig6Hwk4cDjI4+uOFRCrjfDUSRSNLZGOLXNIwQR4XVt3C1PDcnVrbtVCpewRud 1/maOwI84XK19VJW1s1VO7qmmeXvPbJPdLlvDi1jjrK5PgBklTr8LtoFZqOSvZKzrpRgxZ+Yg+cK CRzwtxp29XKwV7ay0Vc1LUtGOuNxBx7LnZuOm9dxaX4l6eemq7FfBG59FSzt9VzRnp5BGV1+tLeN wts6WOxTxStnDHB2cjjuqmX3cjU97tctuulxknpZcdbHAc4ORyvLpXcDUWloJKe0XGWGmkOTHnLQ fcA9lvneeOf1NPPj4ZMMsPu7XTsVC6ybeQ2qteyOeOExEk4BOFxnxJSGHbKgcw8tkjwf0Vbb5unq m9W91FcLk+WncQ7kDqBHsfC8l23Cv13sDbPcq51TRt6ekScluO3K34cphlF82FzxulyNNTNrtpKN 4kDy+BpLs5yeMrkPicm9HQtme1xBZOwgg4wQ1Vq07uTqKxWeW1UVc78A8OHpP5Dc98eyx1BuFfr/ AGSG13Wr/EU8PT0Fw547crPhvDW2/Ljy6i5ENZGdpaOqmkBYI4nveT9QSVpd9NMVusbDZm2YNmax 5kJB4wWjCqtaty9Q27TUlhZWepbXBzRHIM9IPgH2Wy03vJquwWuK30lf100WfTEgyWj2z7K45TH1 7TKcvazu6TTSbIVlPMQ2ZlM1pbnnIxlUZlPzld/rLdPUGrbfHSXSdhijJI6G9JORyD7qPnHynL9J hFxxvK5MT3GUimeTxygg+yw6FlAQE0AhIoKBkpf6ITCAQhLOSgfhHlCPsgO6fhHhCACWEwOUeUAE Hwg8FHcoBMpZwhAfZNIJoDCEk0B4QUIIQCaPCEAjCEJQ00u6AoAhCAhAI8oQgEIKPKACaAllAIQn 3CA7oSTygEggoQCEI8IDsE0gmCgSeEZQBwgSB25T4CPKAKSEFAIQmQgAjKMICAQgoHflAHkoR5QU DSKMoQJPwkmgSYHKWOU/5oApJlLCsAhCaKSAhCARhNJAYTwkmgSEFCAQgJoEOySaCgEJJoBNIHlH 3QCD3STQCEIQCD2RkIQB7I7BCEQcoCaXnKBpFBQOyARnn6oQTygEIHdA5QCaSPCBpIyhWAQhCACP CEu6BoQhA0JIQCEIQHdCQ7JoBNJNAse6PKZSQCeUkwEB/JAS5TJ4QLymEZR4QHlCMoKIPCAgoQHC AjyhAJpD+aaKXlH0TWPlaDzylnlCP9UGWOOEgePqgco7d0AjyUv1TQPgfVLygchCAGcp+EA5T8IM crLPCWPZHZA+UsJgpcoAJpY5Rn90AmEuU/CAyjKXB9kZQT1hIrLGEYXxHvY+UiSGlZYWLuy1EQtr f/7par7j+i0cmekLd61I/tLV5PYgfyWkk/KF9HD1Hky9vmhCFtkIQhAIQhAJtGXAe5STYcOBQWF2 E0DT3SmZc5mh/PAP+HldRuHd9G2nU9BSMoopblDL0SzRjHRyAQ8Lb/DM9r9JgN5wMFQtuVQzV27l 5gia4ukrCPlHIHupPSWp/wBa7c2fUttt9ztdNGypYWuL2cdTfIPutvebTZbRp+mfcoKdlYD0wOcP zuGDjP1C2e21HVW7TFPTVUxlY1oDC7uPouB33N5hvFki4fY5ZmkYbyyVp5z9wm0qRJqK1xaeFyZa WyubGHGFuMnwcLw22l0vqC3fjrdRxCaOQMlicAHxuzy1wW6fXRWzSTauojMkMTR1NB5wXAZXA0jH T7qm7W5rxaq2niaXNBDXPH+Ye6u0tezWe1Vrra6lvFnpmQ19K8OkjA+WZn29wtBvpo6zu25lu8VI 2G4UgY9sjRgnJAIKknU+p49PX2z09Swmnr3Pjc4d2EYwf5rnt/C07W3XpOWv6OkjzlwVxu+kyunB bRf2d3B0lLYr5QMFZE3o9UADPHBHsVA+6mh6zQuo5bdUZkp3fNTzY4ez/qFLfwyU0jL1USva4McW gEjgrH4vR/6ZtQP/AMjdj91fFOdyl+F8mXDjr5Vx8eyYBceBwg+cKQ9of7KT3Z1Jq8CKKTHpzudh rT7H2U02j0xO7gZWJBB8hW1dozah7f8A4q2wj/58P+qiPebRum7LHBcdJXmlrIHu6JqZkgJj9nDH hBFDBl4Vn/ho09brvp6qZcqWKYF7gepoJ7KsMfDwfCtb8J1bTvttVTCRvrteXFmecELOe5Olx1b2 8ul9G2u1b0XK2xQNfRiNr443jIbk8hS47Qmmxc3U5t8RZUMc4tLRxhcrRW6pbvXca58bhTmNjA7x kKUJYyb9E/8AwiF4BXfyyTLUeXwZ3LCWo8sW0Fms9+qZoqdstJKepjXjPT7tXhr9obJ/bFlbRQBs JaHPhIBaHZ7rsLJrKKu1ZcrD0ObVUUwAd/hewn+RC6AA/wBoaj/L6IH8yufcuq7blm4j28Wvb+K5 wWK5RUsdVVAsaQ1vT1DgtJ8FV53X2muWl77Um2QPqbSf7yKRoz0NPg/ZT5Xbf6Z1dqG51BqiLiyp cJYxIQWuB7gLtdMWiWipai2XKb8cIWNDHy8noPYFX+M3LU2om3S14ktrrhHQzupG5Jka3IGFjZdM 3S9tebZSS1AZ+boHZXc2+t1IbTdqf8PGadtTIwRlvAHUeFyG1OjnWu+3i4UDmx0stQ8NjI+QDJ4I VuOtpj5OSql40xdrQ1rrjRTwMccBz28Er6QaSvU9EyrioJ307/yvDeCr03uwW3Vmm6ykucNHLDIw hr6c56T4IPcEKPvh6eamz3CzV7GVEFJM6KJzxkgBJjvG5fDVz1ePyqtX6TvNBTGoqbfUxwgZLnMO AjSlunqLzTOiozVhjw50WMh4B5BV2nXzTFTd59M1zqczhha+OoAb1AjjBPBXh0jt/ZdNTVtZSMDo AXSBxAJa3GcfUJcbLqszOZTcrnrrtdpfUOh5amnoRRVP4cvBDAHMeBnB/VU4nYYZ3xuOXNOCfsv0 NdWU9dpKvq6NjRDJC8sLcgOHSfHhfnzdx03Co/5j/VauH6cmcM7fJxePg8EKS9jaWzV+r46C/Uon gqW9DCRnod9lGeFIOynO4Vp8j1P9FxtehO28G1ekrbpOeohdFbqsMLqeTGGvcBnpP3VTg0u+/ZXG +KjP/Z/QhvczN/8AKoA2v28rNW3JpMbm0TT88mOD9Au+WEnjxy+3m8eduWUvqNDpbRd3v0Uk9FSv khiwXO7cfRWT09s/pe3aYjq78xrgGhz535xz9l28bLLt5p+KMCNhcPTYzy48Z/ce6+e58g/7Hbk+ Phr4ct+gLgsePHnlMY35MuOO0d6y2UsF50rUXDR0jPxUTS+PodlsmPCqxUROhmfHKC17Dhw9iFeT Y7P/AGXwknJ9I/r3VK9U/wD3QXD/AOfO/qVqYS4XL6OWs5i81opRXXGmpuoM9aRsYcewycZVr7Xs tpa32CCovzxGcDqme/paSfr2VSqPqE7DEXB4II6e4KtZtnuPb9R6b/sruA0QzdAEVRL8rZQO2c9n D+a5x0yajcrZCg/sw+76Qk9R0IL3RhxcJGe4VcKmjmhm6JInNd2wRyrnVtPd9BwUsVpcy4aXqnBv zEl0HVxwfLTn9F8d1dIWeOm09cY6WNk4rImuIAw4HuCt44y9OfLXamTqZ/V0uY4H2IwVkKOXJHpu z3Vsd/8AT1rslosl/o6OJtXT1DOpvSOmRuMkH9l1tVZtOnTNJq3+EwkMgEk0XSOWkDOPGQkxusb9 nOTf8Uf/AA784LSCPHlIU8hyOk59lcbcTRthqNNUmsbNRQtfRdM5jcwBs0WRlpH2W7uentK0dkh1 Y61RfhvRaZ4gxpPScYx4yCVNbXelHDC5pxggrJsLyT8pVydbbU6dvlLbbxb4BTMc9oe1oDetrjgZ A+62OpLHobR9LQx3ughHrf3cbhGD1EDyfCk1eluWlJBE7JHSViYXn/CVbncTQWnrK616soKGM0Ub 2NqabpAD2OIGQPcZXZu220jDN/FPwVOKWoiBLHgAAgZGPul1NJM97/iijIXlwGFLWltmq6+aJrL2 6YRSNiM1O3HyuA7gqU9xtB6b0tXWzV0FC2WzdTW1lMAPyu4D2jyR7KXbA+xv0Q+a1kmyuje4DGMN xzgK6ks38s5Z3Vs9x+eU8ZjeWuGCDghfLOR7KTd76XTMd/p6rSFQ2SlmjxNHggseD3wfcKNCFM5x tkbwyuWMtY+UFNLCy2EYQnyqBCeEYQLKMp4RhAJBPHCMeyACaOyXugO5R4SQgAVksVkEAEIwmgWE duyaAgQGU00IF2Qn3QgQRhPHKEAhCagWEeUIwgSaAhAeEeE0kAmkE0CQE0j2QBR5Qg9kAUIQCgEJ pIAdkI+iY7oBBKSaBJhLuU0CTAQUIDsgIwhAu3ZNCOUDCSPCaBdwkmeAgIBMJdkZQBTCRQfZAIQU IApFPukUDKSMoKAwhCFVCD3R3QgPujPKCjwgEIKEAgI8oKAQhPvwgWEIQgCgIHCDygEeUIQCEY4Q iDHKEIQAQnnKQQCRKflB47IDKEJIH+iMJIQAT8oKOx+6APlAH7pJlAk/KPCCVYAIS5QED8oQhAIQ eyEDS8oR2KA8oQjygMoSwmgEI/0QgPuUBCBygCgIQUDCEkygAl5R5T7oFlNCXYIGhA7IRBlCPCED S8ppIppHskO6YWgkylhNAkycpI8IA8JpLIFAcBGOEjz2RghAdigFMjhLCAHjhBPKSeMoGAmThIBN AspHIT7JZQPPH2QO6Q78oPvygySTzwscn2CCfcITwkviveXhYuGQffCzKxcOCVYIT1lg6jrf+Yf0 Wjk/KFu9ZgjU1X/zZWll/KF9LH1Hjy9vmhCFpkIQhAIQhAIBwcoS8oJI2n3JrtDXJrm5mt8h/vYM +PcfVSdrbWmiqm90GrLFOTcOpoq6QswZGnzz/iHv5VerZbqmvkbHRwvmkPPS0ZXujsdyNZ+E/BTC p8RlpyiVZjXW8ln/ALLU0ulK9hqQ9vq07mFruk9xyP6LYw7saO1HpWBt5qGtrYsOMMrT1NcPIKqm +2VsVX+GmppGT5x0OaQVsRpe9+qIzbakPIyPkPKaRbpu5+g6yy/gpb3G2J7AC17HAjzjsvnNuhoa htrYqO8U7ixzD0NaQSAR9PZVQGj9QE//ABMq/wDwFfN+l74H9Jt1V1e3plBPO825FhuE2nLhY62O tNJUOfLG3IIBAx3/AFXu3G3K01qPa+aCgr4zXOaw/hngh2WuBIVZ/wCFV7qv8L+Gk/EZx6ZaQ7P2 Xzr7ZW2+oENZTSwSnkNe0glan2lkvtZravcHRdv04wz1UVFcImHqgkBBc4DjDvqVDG8evpNbXz1G sLKSAn0g4DqGe4JHdcdW2mvo6dlRVUs0UT+z3NIBWqeTnlSdel1v2w56sphxB47ISBRp9BM5vkpP mc7jJWHlPCAB5BXRaP1PcNL3iG5WmYxTxnJHhw9j9FzrBk9itjT2usngM8FPK+Fv5nNYSB+qC31l 3s03ctMPu9S5kF2gZ0S02QHuJ4y3P5gO68O2e8lpud2q4r3VMo5nOcY3ynpY4fTJ4P0VUKOgqqp5 FLDJK4cnoaSV6HWquZE6R1JKGNPJ6DwqxxWIt+ubNZN7rtUVVXEbfWOb0VLHAsHnkhdfrfdm26c1 hbaulqYK+01MZZOYHhxYQe/H3VQoqSpqciGJ8pHfpBK88rnx5Y/IIOCDxhW3d3UmOpqLuU970lDd JdTWi70RNQ0SzQumAc7HJIz5+i+zd0dMQ6njikuUH4Svp2OiqA8dLXDPyu/ynnyqNNmcOAcA/Vey mpqmpafRifKB36WkqHH7Xmt2otOaemljkvNG+lr5SWvZKCI3E55++VptMa0s+ndT11guVdTiKpJn pKtkgMbw4n5SfBBVOX0VfG35oZQB4LSvFLLJn5nEke57Jbb7McZLuL4We9WKwF1FPdqMwVrnenK2 VpAPfDvbvx7rUbc/wDTtzuNLHdKQ1HqGUgyj52uzhw91SdtTNwDI7Hfkr1YregSYlDcfm57fdJlZ LjPSZYS3lfaYfiVtv4TVUF8oauGopaz5QYnguje3BwfbupN2N3GteoNMOsVzqmU1zZEY/wC8cAJG 4xkE+foqjz1MsremSR7m98EkpU4m68wh3UOR091rLyXK7qY+KYY8Yvnap7bbbQdOVFxp2vlie2CQ vADxjGPuMqkGu7VNY9UXG31BDnwykBzTkObngj7ha+WqqWuAlkky3kdROR9l5KmWSod1PcXOPknJ S52zS4eOS8nyPB5UrfD422P1tCLjVNppm4dTl5w17vIz7qKgCso5HscHMJDhyCDg5WNOq73xAWs3 /b7qoZYpZKEid8bXAlzWjnH6L5ad1PprTO2tLdqCSAwmPAa0/wCMAZaf8pP1VOWXu5FhYK2o6SCC PUPIXxjkqTCYg+T0XHJbk9JPvhbyytxmP05Y4TG2/bt9d7iV+qNQOrpZHCBjwYouwDQcjPjOPKs/ p+8Wnc3bH8BSVjIpnMbHNG4gOYRjwqQva7qXrt9fV0DnOo6iWAuGHdDiM/sphbjdxMsZlNVfDT1H SaG0XLS1lS0U0DOn1T2Gc/8AVUS1JI2S+1z43BzHTOIIOQRleqbUl3lgfBNcap8LhhzXSuIP6LSu +Z2cq87Mbj9rMP25PbY6ttBdqSpkZ1thla8t9wDnCuJcdN6d3Q0XQ1lhfTxVDekl7QOqM/4mkeFS 3HsVtbRqC6WYP/htdPTB/wCYRSFuf2THK43cPJhzmqvbHHBpnb8Ud1nY6OCPo63nIJxwMrz3RkGu tIWeos1THK2GaOYhpyct7t+6pLW6vvtwpX09ZcqmaF+Opj5CQVjZ9VXm0scy3XGpp2OOS2OQgZ91 mWz0vHc1VvN+KCXUm2nqW3Er6OQPmY3lzenIcMfRdDbLXLednYLfTua2WooxG0ntkgKn+mdeXKku 4fcq+qloaiTNXH1k9QPDj98K2NJqvSNXottsor/TwRSQ9MUgfgx8cZ9iF0x8l/WfTln4+sr9stbi OybPzWutlaypNMYmA8dbgBwP0WxntE182gZbaUtEtRSNa3qOB2Cqo/WNb/akWzUtznr7TT1RZIWv 6h0g46m9/HsrRVGotNV2jHWy2ahpYnPhxBKyUdTDj5cjuE3qyT4q2axyyvy2N6qoLDoijiuUrInR en1ZOM9LhnHuud3i0lU6+pLNLZ5o3QRuMvqA5BBAxhVQ1jq2/wBdPJb7tcZKltNK5oBdloI4JH3S sm5eqLLRMoqG7VEdOzPQwOyG/QLOFuGW4uc/JJtcTcG2ur9CQWYSxR1kvpRta92OotIzj3Xn3btd dV7U1FLQNeauCFpIYfmHT3x+yp/fNxNR3v8ADC4XKaR1O/ridwC13HOR9luWbvazbD0Ou8r29PSe oA5GMd0xy42X6S+Pcs+2urtw7/XacNgrq989v4aGycloB4Ge/CtBsfW01/2e/h9JMx9THG+GRgPz NJHGQqV1EhkmfI4cuJPAx3W80jq+76UrnVNlrH08jx0vAPDh9Qs3fKWfDpxnC4/aUt79q2aUscF3 o6p0rS8NnhcOWdXYj6Z4UGPXV6y13etWsjF3qjKGDHHGfv7rkiVcrcrurjJjNQJJpfdZaMJgJICo yQRlIlBQNI8FCEAgoyjOQgY7I8oQgR4QEI7IDGUx4SyjygyQllAKBp8FIcI8oGgIQgPHCfhLOO6P CATSPCMqBoST8IBII8o+yB9keUk0Al4T+yEB4CMIQEAkUJ+ECPdCEFA8JeE0igChCEAmEj90IA9/ dMJDumgWU+6AEIEVkkhA0kFMIEn2QUIF3SWSWEB+qaQTQLKPKO6RQPsjwkmfogSaPCMcIDsUIykg EBMIxhAkYTS8q7BwgowmENkhPHlJFGEBCAgEIQgAhJP+iAKEeUBE2PKEd0e6GwhCENhCAhAI8IR9 kAfCEJIA90/CEdkB2Qkn4QCXlH0TwgSaB3SPdA/KEkFAJlLymrAh3TS8oygPCAnwkgaEIQH3QhHl AIQhAvKaAEeUAgIQgZKXKEIAJlJMcomy4TH1KRHJRwhsZ5QSgowihBQjPugAmUJfVA0iU8pFA8o8 JeU0AeUkyUYV2BJMhLygf0CP6pZQqBMAo9kZ5QA4KZ/ksR3TzwgY7JchGeMICABwsligcFA8+Ews TymOyAJ4WOFlkZwjsEAB7oH8kDkIzzjhAZ9kun7oRn6hNJtP5GEseVmkvivoMCk4gA8LMjlYv/IV RCOsudS1n/MP6LSy/lC2+sDnUdYR261p5ewwV9LH1Hjy9vmhCFpkIQhAIQhAJxDMgB8lJZRHEgQW r2E0VRyWSG5FoL3tDnZHPKx1pruzU+u6SigoIHfhJjHLU46HtdnBafDgus+HieOfQ8IicHOa0NOD 5CgW9Wea77rXanLH4fXPe8AchvUrJubYyy/bisrqnRVq1VDarpSQRMngcH+o1uC5pxkH37L06qqL dY7Xb4auGM1k8nRTv6OOppBwT9Qtxo+jFqsMED5y6IABvUfy/RRru/Q3ePW1infUOls0sjQyHxDI O5/Uf0UheknXWR0Nh/HUNup56npa4QuGA7JwRleGz3G0X+m9SCljgroJWsqKaRoEkTs8gjyPqvbd rl/BtMR1hp/xLY/TDox3IJwcfVcbZLdPJuVVX9kcraCubG1vWMEOA7FE323Ordv7dc7jTXeggZDc qV2flGBI3/KVxnxFWag/sCytbSxx1tO+MslaMOaSeV3OpNUvseuLVQFhkpq5jw8f5SDwQuX+JVwO 3kpZkh8jMfuu/hwvPWX04efyfpvH7aXZy423X2kJrHqGgikkib6ZlDeXAjg/Qqvm7mh5dDapltzn epSyD1aeTyWk9j9Qpw+GKgnpvxM08bmMle0tJHdcr8XBP9rrfn/5WGP3K5YTlvfw73LVk+1fyDgh ZNjLhkHCQPKk3Z/UGmLbWvptXULH00n5ajo6y0/UKOiNfRd7r5nIOCraG77OObn1KY5/+9yFDe8l Dot09PcNE14kLyW1FN0dIb7OCCM4wXOCt18NFspKzRz21cDJWuc4EOGchVFjOHeytv8ACpdqSewy 0DZmfi4y4ujJwcHsVnLeumpr5YaF0/brdvJqC30lMxtIxzS2MjIGTyB9FL38BtJuk9I6ihMb4y5z enhcdp+xVdJute7nURlsM0jQ047j3UhhvVfp5OC30Q3I+/K6+TUy1Hn8Vtx3k5Wxbb2WxXOplo6V ggmcXhpGQM9wq3/FDp632TWVNLbIRD+JhD5WNHHVnGVY7SWr5brqu82WaP5rfVOY2UdnszwCPcKC Pi5/+6+gHj8OP/MVrx47tl+Eyy/118q/jurD/CxJbJ6uuo64QvqHEOYx4GSMeFXnyuj0LPPT6ot0 lPI+OQTN+ZhwRyuTsvlVWexRUplqKWnZAeC5wGBnjlVh3V2qqKjXddHpSjzTFjJSxpwGlwJ4+hU+ 7mPcdork/J6zATnPJOQua2OsNVFZIb1UV8z5JoQC57i4NYBkNIPst8dYTKucy3ncfpV3Uuh75ppk cl2onwwvOBIOQD7Eqy+wEFs1PooU1yt0LpYMx9fSPmA91JV7t1t1TpKvp6x0FdSSRuPW0ctIBwfu FHfwxwtgs9fEwkiOd7QT9liy8eU9NzKcuP8AFf8AevRT9K6trPwlPIy1yvJicRwM9wjY6rp6TXFJ FW0sdTBUkROa4AkfUK2U9LQa8p7/AGC9UrJIoJXRslA+ZvHBH1GVV7T2n3aa3jp7S6T1RTVfSH/5 m+Ct+THq3GenPw57sxy+UpfEroiy0+k4rtb6VsFWx7Q0sAGWnwVXy0aGvt4p/wARbqCWWLOOoDhW s+JLjbmn9/UjC67RNJRW3RFHUs9Kmb6QL3uHyjgclbyk/HhfmsYeS889+pVH77ou/WWlNRcbfPDA DgvI4C5oNIOCv0DuFw03dLXUUN2udqqqaoaWnpcBwf5KjGsrfBatUXOio5BJTQzObG8HILc8crnr rbtjnu6a23sY+pibIcMc8NcfYZVzNP6F0nYtDxXG4UUdXShge6QMDnYOOVTClY6SVjGDLnHAH1Vj 9rtcXfRNsjtmtaCol07UDojfIwn0yfH1BSWS9+kz3q8fbsdQba6S15o2as0qyKCqjBdC9rQ35h/h cAoR2dsME+tmRXejM9FG4xT5Z1Na7tkqd9UWKpp9Mu1LtZXSQBzfUmpYz8srRz+XsCOVGPw7Xyq/ 7QaqCYMkirup80bm8dQPcDwrnZjLYnjmWd083xE6DtNguNtqtPtDRVl0b4GYIBGMEffKi9uib+Wh 38Lq8Ht/dlWB+KOGG2Xew1tJE1srJC4gdndOCFLGi9Q0mpdO0lVRURZKWtD45Y+AfPKvlkx1r5jn 4M7nLv4qjdfpq62+My1dBUwx/wCZ7CAnBpu6zRNkit9U9juQWxEgq7m4F5sVupYLfcKSnnkrXiEQ 4yHEnBwfcd1v4LVRWq2UsVNFTNBAwJeM8dgVh1uWvb89bhbau3yhtZTTQOdyBI0tz+622jtJ3PV1 dLR2eJsk8bPUIc7HCuHu/o+1am0PWmWKniuFLG6aGSIgkEDOOPBVWdpdSXPSmqm3G10T63pb0Tws aSXMz9Oy1cf15JjnLlcfpyWobNX6fuktvulO+Cqj/M13t7j6LwxzSAYDjj7qRN89X0mtdSU9ypqK WjljhEEscnfIJ5/mo2BwVh0jd6dtdTfLtBRUY66iZ2GglWo03s3YqHTkMmonkT8dUpcQAScY+nKg HYkA7k2fP/yQn+St7uTbqW8OpbdUVEkL5Y5DGGv6Q5wwRkeU8f7Z8XPz3hhMr8qubybVV2kLqZqN j6i1znqikaMlv0Kil9NI2Qh7C1w8EK+mu68WbbCKuqIGVLqRsTix/IdggEfqMrm5NBaW3CprRqe1 Uoia4j1YgOnI9j9j+66dZTbnLceoqjoXTX9odU0FrmlbTCpd09b+M/QfU9lZap2V0RbxBDcaoU00 gwGyzdPUfOM91rt+IdMQWWC2WuJgv8MrRTvpgA6N7SMh2ORkYwV0G2ukbnVUMF31xVSVkkLS6NlT 83pjHOSe/HlYyljUzlQrvltKdE+jc7XIZ7RNgZ7ljv8AoVC574PhWS+Incahulufp619MtOwhpeO R8pyHNIPIPbH0VbnjldPJjMZPtPD5L5N34HYJIB9kLk7jshCCgYQUk1QgU0ihA8oKQ+qPKB9whCA gE8rEpoBHdJGSgaAUu6YGUGQQsR3wskBlCClygeeUwsfKYTYeUwscpqBlJNCACEZ5+iD2QHlCEFA BCEIMkikE0AkCnhGOUUsJ+EIRKSPCD3R5QATKCkgaMpIHdAz3STSCACaXlNAIygIQCEIQNCX3TQC EiUfRA0JI8IAoCaEC8oQg8BAeUHullNAZ5TSQgD2QEICBdk8oyl5QMJd0/CPKBIKaMcIBJCZQJHh HlGFVCCg90IBCAjCAR44Qg90QIR3CMoD6IR90IDCPCEFAAI8pDOE0AgJHlNAI7o7lGeUC7oCPKZQ A7IRnIS8oH3CEJFA/HKEk0AEJJqwJCflHhAI+6EkDSQjCACEDumgD3Ql4TCA8IS+qaAR/qjwUeEA gI8coQCPsgBCIY7JITQLugp9kkBnlCAg90UZ4QO+EJ+ECwjAR90BAyhBHCR7IDKaSf2QCPKByhEI d0wf5o8JYVD7fdA7pFCqhCEIH48pBHlNAsp+UkwEAE8JpZQLsUeUEpgcIAeUvHKfb7JfbKAS/dMc J5/+nKqaWB8cLFZEYS7L4j6BLF/5Ssz3WEnDT7KxKg3VY/8Ahkrf+daeYcBbbVRB1HWkdhIVqpiS 0Adl9LH1Hkvt8kIQtMhCEIBCEIBA4IQjugkHbLcS5aIuTZqNxlpXH+9gJ4cPopI1Puppirvlv1JZ aKeC6tIbWROaOmVnnn3HuoT09p24Xuf0rdTumkxnAW1i0Pf3XI0DqCRlTjIY4YyPcIlTNuFvfRXK 2W06XdVU1TFL1zRyt6WvGB8px35W7g3105c9P00V4oqn8dG5ri3pDgCPLXfUKuc2mLtTXUW6ejlj q3Hhjh3+y3TNttS+u2N1veHOGW+xRKsad89D1NCKaobXiPjLDD2I575SrN9dIxU0YofxTyx7SWGL pOAff3Vf27VarOf/AEbIcfVeR+2+phMYv4bN6g55VRJm6G7FoumoLJeLB60jqUu9WKVnScff9169 0N2dP6u0IylojPFcGOjeYZY+Dg8jKhBmmbtJdTbfwkjK0HBieMFfO66bu1pro6S4UkkU8nDARw77 LUyyl2xl48cpq+lg9Eb06Zt+mGxVUMlLdYozhgi6o3uA4wR2yoL3G1rX6zu7qyvdlrSREzOehpOc Z9l5L3pO9Waljqq+hmipn9pOn5f3XPP7rLpHz8obwe+MrIDJx7rb2TT1fe5zDbaaSd4GSGhGmqD3 jgFYlzh5XY1G3OpqaJ0klpqMNGeG5K5OaB0T3Ne0te04IIwQVB8c458rdaW1FXacu0Ffa5nw1ERB BB4I9j9Fpugnss4Y3PcGtBOeB7qi11N8QlqqdKuqamEx39jOgxDgOJ46g7tx3wV5dqt7ba38TBqm Z0E73FzZ+nLX59wOxVc7jp27W2kZVVtDPFTPxiRzT0/utayOSR7WxAlxOAByjOlhdObm2fT+616q 55fVtddN1ioZz085Bx7crmPiS1LadTakoKux1jKqnEAa5zeMHPZRRcqCrt8zYq2CSF7mhwDwRke6 8fJ4Wpnd2pMJqfwj3PC6fbu7W+z6opKu8QOmo2u+bp7t/wCL64XMjnstzT6bvE9I2pgt9TJA4ZD2 xkgrLa4V311obUWkJ7T/AB+nijqIi0OcSC0ntn9Vw2ze69qscNTpnUlTHHDC50cFa05Y5vI5/wCq rCfUY5wOQQcFp4wVh6jifqrcrZx+GJjJblPleG37gaMtMZtzb3TSUVWHBr2Oz0HHY498rjdrtZ6c 0dqa7WepucBo5JTNT1Yd8j2uHYnwQqo+q7PC+1OySeRrIg573HAA5JV31xNavJeai1ho201VfX0d 8o3vnLpXR+qMl2Ow/ZQNZ9X6bq946q73R74aOd4dFK48RP8A+L6fVQ7X0Fxo2B9VTzxR/wCZ7CAt aXO9kuV1Z9pMJuX6XS3Zu2mtW6GnoaLUNv8AxcLfUi/vRh5aM4/Vafazc6wai0W/TuoKplvq2xmI l7w1sjcYyD7qpDZ39PT2/VZxskkcBExznnsGjJKcr+s+k/Hj+39XQhp9v7PYamndW0NXAGOcWiRp kI7nB8nCp3qV1Gb5XG2yPfQmVxgc8Yd0Z4z9V43yyjLXEgjgg8ELznknPdLbfbWOMx9PtSyuhqIp W46mODh9wcq4ekdW6T3J0D/CrxNT0lZG1oljlcGkEf4mnz2VNhz2X1ilfFjodg+4KjVi99tuNg0X o6empbhT1FNDGQGsmDnY58d1B2wNXYP7c3GarrWU1X6jnUxkcGte0k5GfdQKaqZwOXvPj8xRGZc5 jB6hzx4Vt3hwYxxuOXOLefERT0VzoLdeoKunqIbfM108AeCXMJGSB5Uhabudjm03SvsdfSxRSxfK Q8DpyPHsQqE/i6l7Oh0j3A+C4lfSGWsgb0xySMbnOASFMrctb+EwwmG9fK7N+01Yqm0S1NXVQT3S mBnjqA8Zc5oyP1OFhW1Vl3Q0VSMpboymfG5vqgPDXxuA5H0/1VK3XGvaS01M44/zlYU1XWU73Op5 ZGdX5i1xH9Extxu4nkwmePGraa+0hpyz7fzn+Iupq2OMhlXHJnqfjgOwex7KB9i9YW7SWsTUXoH8 HUx+k94GQw54JC4KpuNbUMdHPPK5h7hzicrx+m4jIGFd7x0uGExu4kz4g63T9y1nHX6Xkikpp6dp lMYwPUBOePfGFFjTkjPZfSQHGCvkODysurf6Rvk+nb9R3SlDXS08geGns4eQrlUNfY917LartR1Z hqqKTMkPX0uYSMOB/wBFRkHC2Nsuldb3ONDUzQdf5vTeRn74SfrdxjPGZTVXS3OvdlloqXRlRVsZ JWubF1udgx4ILSc+D2yt4y5WXbLTdLT1EoZTFwwM5zk/MR747qiNddK2tqBNV1MssoAAe5xJGO3K +1dfrpXwxQ1tbPPHF+QSPJDf3V3daZmMl39rd3jSlL/2l2rVtPURVdnrnBsmSC1r3DDT+q7HXtjv V2EdLZq9lNQdIbI1v5+D4IPkcKi7NTXdtv8AwDa+oFICCI/UOAQcj9itpFr3U7GD/wBM1vHY+qc/ ut/ly5TJyvgxuPD4S1v3tZbdM6ZivNpkcHteGzsLs9/P7qup4XTXnWd+u1C+juNxnqKd+OpsjurO PuuaI5z5TLPnJv26ePDhuT0xCE+c9kd1zdWKfhMj3KMZKBBBPsn9EgqAJowg8IDCCsgCU+nglBhy hZAYCMIMfshPCy6Sgwyjus+lBZ9EHzwmn08pluAgxzyUwjCA1QA5TKZBS6UAgJgLLHHKDDCyCMIw gAhZdJSwQgEll0+yZGUGAHKflZdPCAxBgn4TLfZGPdBimEdkeEAChCEAhBQgEsfVMoCACEIQHgpd kylhAYRymAhAk0FA7IGEFBSQCfhCSACZSQgE0kIGlnCEIAlNLyhAIQhAJpDhMoDCMJJoEUBNIoFn lNCMIBH2QhAiE0HsjGUAEeEIQIoCPCYQJCPKPKoChCEAgo8oQHhHZCaBIQUDhADshBQEBkFCMco7 oAHBSQhAITyhAfVJNAQCSYKMIEhBH6oCAQPogoQNGeEkFWARnlGUZQCMZQgIAJ5Ql9kB5KaAhAuE FCCgfhHlAKEAOyCEI7Ig78IQhAIR4R5QCAhCBpIQEBhBCEIDCYCSMoAowjyn4QLwjyhCBlJMoGEA hHlCAQEI7KhHugJ490iin4STQO6oSY9j2SKPZAFCaX3QMHhM9lj5Qf2QNJA7oQBTBOMIPJSCB5wk goQWEST7BLOTyviveF85eGk+ML6FfOTlju/ZWCC9Ugf2jr8H/wBoVqZRho+q2epQf4/Wjz6hWsl/ K33X0sfUePL2+aEIWmQhCEAhCEAs4G9UiwX0pz0yhBcbY/S1DS6Vgr2xj1HMa92e5JC5S87sMqdx aWBtNHHQ0kpi63NHX1Zw459uBwpD2PrYa7QMYpHte9kQaWg8g4UAWbTFRdtzK2nqIHYiqXPlY4YO CThbxkuFt9uOWVnkmPxpaK+aZoNTOtd1Y1glg+drgBlwOPK+WsLxFZTaKD03moqpMQzNAw3oIOD9 wVurBBBarVBB6nTGekNa7jpPsov3F0/XU25lmuTJppbdUOIdESS2F4HceBn/AEWJW70lS+TXBlob Nao4H1x6C1so+V2e4+mfda+x6go78/0vSFNc6WYR1VK8Dqjd5wfIPuvVqG51FosUFVSwieQOjaYz /iaTyFzembLU0+tK2+SRujguUjXBjiMsI8KDd6l0hQXO4092ggYy50v5ZAMdbf8AKf8ARR18TtNC zRNDO2JjaiOdvS8D5mnHgrrr1qWotG6FHb2DrpaqlBkYe2cnn7rmfihb16Mo2xgnrqBgfovT4Mbz 1fpw8+U4Sz7fPZW8R650TPZtR0sVUxgMJc5vLhjz9fqq5bw6NbonWFTbqeUy0jwJYCe4a7Pyn7Kw nw4WmptlvkkqoywTO625+yi74qiP+0CPH/yqz+pXHGbltdLlZnJPSEm91ZL4XbpZ3PkttYWR3Au6 mF2B1+wBVb2j5h9VLm1e3Fy1NbjdLRXNgq4nExtHByPr4UdaslfNU1un9U/hbzbIG2J4b0VojJxn v1ewUfbq7SUGsaz+M6NnpjNK0mVsbgWSH3GOxXT7ZanvlfXVel9dUEcslOPT9RzPztPHPg5912+l NO0+ma2qo6Diif1SRMJ5ZnuPsrllL6jl48bPd2p5pfa263y91tpkIpKylOHtePP/AEXlq9A3Wx6y pbJcmtgqJHtMUjj8rxnggq50dpo4r1JdGw9FW6oET3gfmGeMqFfiZBOtLF6eesMyCO4PUrhjz3/F zz46/rv7zSsptsqqj1FbfVDaZwMscYe38vDsdxhQzsjtwblVU16LoaqljJzGOSD44Vhbq979sKl0 jiXfhHg5746VWn4f7vW0Wt4qOmqHsgmaTJGDwcfRa1L4pkxjb+bLCpp3z27Go9IU4s9FG640rvUY QMOLcctVetJ7S3/UIkMMYp/TcWlswIOR3Vn966y/UWnaOXTMk7KwyfMYRklvSM8L1bSvmqdI/iLg M1rsulJGCHZ5WbjqS/bWPk3b/FbbpsLqiho5KiNkVQWDq6GZBI+il74a6mSt03PbLlTsf+FeY29b fmbgdiuUo9yddUWpbj+GgludFTzPYYXMJAaD4x2Uk7MXeLUF0ud0jtwtzpn/AN7CM46wMOPjup5J wumscpnNxE28u0ldUXyvu+naMGlx1SRR9+rHJAXB6W2m1DqGlM9LThjM4xIS0n+SuPY7m6r1HcaQ xtaICWuI7SAgEZHuOV67fHDSwXB0cXQyJzj8nBxgk4Ws8t5a0z4p+ku1M9QbMaos9BJWSUolijHU 4RHqIHv2Xh220lebjeoKm0xEyQPDw5w+XI8K21FuFp58cjm1tfNDgteJKcvaPoSB/VbCyUdptllq 7raYI2wlr52tYOkHjIx7LPv0vLXdrWaksNDeNvqtl3t0LJ20zutoHZwb3H6qh1Qz05nM8A4X6CXG 4OuW3lZXOBBmp3vAJyWgtzjP6r8/rh/6y/7rpx/45b725ePO3y5Y/D5RND5A3OMnCsxsRtfJS1jK ++0rC2RodA48gZVZWHDh5yrafCxqu5XSjmtVZUGWmpQPT6uSAfGfZcbdPTXBfEdt4+0aiddrTROZ bZo2+qWN+Vsnk/rwuGsu12pbtRCqo7e50LuzicKfd6NW3yh1K+yQwMqLNUMYJGujzgnvz+xUg6hr ZNNbYzXK1hsdRDCHN4yCcjwu3C7mP282Pnlxuf0phqfQF/01TCpulA+OnJx6g5A+65PGO6vrpSpb r3bV8l+gilFTCetvTgeVRm+0rKK7VlPHnoilc1v2BWZjvG5T4rtM/wBuNfCgpn1VTFBC0l73BrR7 kq1Oze0VPbaH+JX6Jskr2EuY8ZDG45Va9E/Nqe1j/wC+Wf1V9NRfgBpmJlxrnUEEjWgzNf0Y+mfq s495cYeXLhjyVx3e2u/sndINSafibUWR8jZTGB1CM5zj7FTlZLXp2v0XBfJrRCM0/qyRhgzwMnC2 jaCibt3W01PO2toPw8npuPII6SfK8WhKmKh2opJqiP1IY6cl7PduOR+ysm7jpxyysmW/hw2523Fi 1XoM33T9O2kqoYzNH8oHW0DJacLifhmis94lrLJd7ZBNKP76OYsBIzwQV0Grd69PQaUqLbp+nlEp BjEMrfl6SMHBB4x37LlvhUHVrmpd49D/APGTy2Y4T7234t5ZX603u+eiNNvutttdlhFHfHyN+Vrc Mljdx+hBXYaf220xpHSvq3+limk6S9zntBc4gZOM91ot13D/ALe9Ng9umP8AqVuPiskezQ9t9MkH 1x2/5V2/HLlMfuOU8mXC5f1xe7W3mmb1oV+rNEOjZ+GGZomYAc3yCPBCrK7lxx2XaW666lsNjqZa U1MdnrswyEtJiecdvbPK4zHz4XC+3qxDRkDgqa/h607bbleZINRWl1RSVQAhqHMJbG8eP1XC7V6f h1NrKgtdU4thmceoj6K69HDZ9JutFjhhjFRM4CJhZwcfmIPg+Vnv4LZNb+VcviF23odP3u3nTlPJ mqY7MDBnlvkYUOssN0e57W0NS5zO4EZJCtV8QN3nsmttK11MGOfG85a4ZDmk4IP6KSb5NYbBRC+V sENO2eNoeenLckZbn9V38uM3jjJ3Y8vi8l43LK9S6fn7PSzU0piqI3xyDu14wQp4+H7QNi1TbLlH qGmPr5a6B7hglhHdvvyun+IzT9huekKPVloEInHQHGHBa9rvfHkLovhiuEd70XNR1lLE59uf6ccw HzFp5wfsueU4THL7dplymWvhV/Wem32fV9ztNCH1DKadzGdIJJb4XOmlkEpjMbxID0lhHIPthWY2 8oIT8Ql5hkYJIg6YAP544Xn3ksNvoN7LEaGnZGyf0XStaMAu68Z/ULVkueWOPwY56wxyy+Vcn0M7 H9EkUjH/AOUtwU326paMugkA9+kq+ep9D2G53uwyTUMTZgXuy1oGcNBwfcZW4qbLQx1IjbZ6OWLj Lg5oI9/lIWemuVfne2mkLsNY5zh4AyVkKSYty2N5A+nZXK1HpizaQ3Hs10pqCN9JepDR1FOWjDHn kPH+oXVVtl0ppmZ8VVR0rW1kwfHG4AZc4gOxn98J0cupftQN8Za7nISxhTp8TGhKHTN5prnag1lL Xl2Ymjhrh3x91BvcfTKmU1pccplA1hd2GVm2IkgYJUo7BXmw23UstJqakjmoq8Ni9V7QfSdng/Y5 VgbdstYrXq+ovPTHJaSwTRMfgsZnPVke2OQUmt6MrYrxsvtx/bq9Tx1E3p0lK0OlDThx6u2P1Ux/ /A+6ZmkdTU946qnJb6YkBIcPBwuV1vPHR7lwnbB76are009RHTjMbsdnccEYOc/RTDozTtPpOkm1 Dqaoa+6S5lfISO4GSR27has1dOM8m+/hULcHR1do7UNRaq9uHx/NG/w9h7ELmDE4cEK0tBcWbkbt wV77QK2100L6Z3UPlc3ktJyODz2Xeai2l01f7LWwU9rNuq+nMc3p9OHeP0V4yXVrU8luPKKOiJx5 AKzbE7BOOysNsNpnT11ud603qGhZPXMLnRTYzgNyHD9OCpItWgdBVFfLpWeha67U0JDn9GC5uOH5 Hnn+SlmrZfhrnOr9qZtiLnYxypg1fs6bLtxTaopq0zNdDHLLGQBjqx2+2Vo9S6dpdF7imgrw6qoa SpY94HBfESCf1wrF7wUVPDspVPs9RMbc+KN0cUhyOhzhgc8hWYX8swqZZz8fPFS0sPUQGk8odG5v dpCsrsRtdZr9p2pvl8YKiN0j4hGRxGG4OfqSunpdB7Y6phqqGyyRMqvTJa4OIc0++D7LMkvpu3Xt T8hAHK3usbFJpzUlfapnB76WUs6h2cO4P7FaZgy8D3U0u/kugnsMrIxuHdp5Vj9otp7BW6GfqPUz vUp5GF4OSPTDXEE8fRdG/arQOp7NXQ6Vron3CNmWOZJkNPjIytcfljnN2K6bdaRk1jqaC0R1MdM6 Vri17+2QM4/VdJudtTctCU1JUVc0c0FQ4sa5owQ4DOCFprBT1Ni1vS05c6KqpK5sTsHBBDwCrIfF S0S6XsjSfm/EuP8A7gqeP9vJwrfk/XxzOfKnzonh2CEekf8AKVYe9bVWeHZun1NTmQVzaaOaQE5D iXYP9VjqbaizUm0NNqakdKysFPFLICchxceft3CSS61fZLe9z0ryWuH+ElMRvP8AhIVndCbJ2Or0 XT3bUFW5hmHrCSJ3ytYRw0/bylqnZSxVGlai46QrRVTU+XHEnUHtAyR90mO/TNy1dVA+jdJXDVd2 joLbGS9xHU8j5WAnAJP3Xi1FZKixXWst1aA2oppTE/HbIVwditM6dtlGyusdYyomq6SN08fVksd9 vHOVHHxDaQs7H1d6oK9k1fLWAVEIIyzq47fQhTCc9yfBllx1L8q4Fpx2QWEeCrO6a2Ftv9nYKm/1 roamU5yw/L0kAjx9VrtwNkaG0aa/i9krXVMMLszl2D0s4yR9vsk7W3XtXJzHAds5WGCO4VqKXYC0 V38LqrdcJJrbUNc6WTIJA6flx+q5TdXZRmndLm92WrdV00OTP1Y4bnGQfuml3r2gEhYr6yN6Hub7 L5njsooCEuyEDCEZSQBR5TSQCEJoAJIBTQJCEIBNJNKBJCYQCEFIIADBQmhAvKE0kB5TCQQgEI8o CKEeUHujuiBBKEIBCEIpnsllAQQiD6oQhAIKChAIKEFAYwhLwskGPdNHbskgAU/KQR5QHlCEKgQU eUeUAE0ghAITS7oEO6E/KEAhHlLygPKZCEIF5TR4QgEd+6EFABIoTQLPH0QMITQLymEkYKB49ku6 M+E1YDykgo8oHhLwnhIIDKPKRTQCZSQgPsjuhCAR2KE8IBIoT8IgQj3QgEIKCUB5QmkEAhPykgE0 Z5SCA8owgoQCCcIPKEDS7oQgZKSMo8oDyhNJAJjsg/VCAS8ppKg8YR5RlAPuqoP0Qn3S8oDyU0kA oAoTSQGEI7IzlA0soQgEIHsmgsB1gecJFwx3Wv8AxAP/AL6RqR7r4z3Nj1gBfKWTDCPce68X4rjg 8fdfN9S1w74VkEO6l/8AugriO3qlayX8oWx1D/8AF6ux2Mjv6rXTdgF9HH08l9vmhCFpkIQhAIQh AIBwQUJsaXOwEHbbea8uui7m2qtspMZ/3kLj8rwpDvu89HWX6gv1rspo7rF8tTl4LKhnseOCPdRr pLRV11M8tt8PH+Z3AW9p9qdSuujrfNSGKUDLS88P+3uiV1mv97HahNrmtVFNbqmke5z8yBzZM44w APIXRxfERTz2inhrrJI+riLSXCQdLsHnxkKHptBXym1Ay0VVI6Gqfy3q/K4e4K6P/sY1QahsLqaM F/5XZOCrEqVf/gjLJPA2OosFW5ox8vqt4KxrviMtnTC6ls9VmN7SWvkbyPIyo0OxeqgflhhP0yf+ i8rtmNV+q6M0kYcASPmPKaRutd7vw3fVduvlnpJYJKaPodHMQernPcL07mbyUOsdN0VNBQ1FLX08 rZPnIcwkd1HlHoK9VF+ks76V0FdGMlkgxx7/AGXwv2h71YbvBb7nSOhlqHdMT3DDH/YreOdl3GMs Mcpq+kxWPf8ApKLSxpZLZLFdmxlrJY8GNzvBI7hQTqm/1uorpLXXKV0sshJ5PDRnOB7BbrVG3t/0 5b211dSE0jsf3sfLW57ZXGuz1fdYdJGIUh7UbkV+g7oHxD8RQPI9WAnuPcexUe/yW2sNjrrzWspa CEyTPPAA4H3RatAN/NGzVIq5LXXtqSBlwDc/1WjqPiFMeq46inpTLaBwWOb0yEHv58KMJ9ntWwwO l/h/WAM4Y7J/QLyWbbHUd3gfLR0Yd0OLXNccOBHfITTKf3/EPpv8Wwtoqx1K8EvBY0OY7we/Kirc HdaK+a0obnTUjJaWjcegSNwXtP8AhIz3HuudrdptWU0DpZLa4taM/K7J/Zayn2+1DU2l9fBQSSU7 M9QH5hj6Ky2ekurraxNLvxoursn4Svp66JskfTLF0BwGRg4IVb33uOxaymuOl5pRTRTufTmQYPQT 2cvnp/Rl5v4mNqpTN6XDvGPovlRaSvFXc326Kjk/GMOHRkYI++U71o1jvl8rLWH4hNPVdrpv47TV NPXRjDjGzrYTjGVpbP8AEBQ0mqKwVdIDZpT0tdC3pcMdnY+oUE6k0VftPUwnulBNDATjrxkA/Uhc w7qxweUaXFot39vKR0stIZ2SS5Lv7jgk+48rX6U3w0nTV9a6rpXUchkJa+FnyTD/ADY8EhVIBODk nKXUe4T/ALNLXWvevT9u11X1DnSvtdWGubM1nLHY5BC2Fv340/FqSvo6v1DZ6gdUdQ1nIJHLSO+P qqiMe7OM8LpLHpC93qmM9uoZ54hxlo4T3dmtTXwtLQ7n7cWulqG2+foMgc4xvgy17vr9ytNozfTT 8rq22XyAUdBKXenJGCWgHu3HgKul40ffrRT+vcLbUww55e5pwi2aRvlypxPQ26omiP8AiYwkKyfT Gpelp27raFgo32Q3Fz7XLGWNkawkx8YIP0VStXw0cGoa6K2VAqaISEwygY6mntlem8aZvVpiEtwt 9RBETgPewgZ+68tssFzuz3Nt9HLO5oyQxpOE3daWY4zLl8tOpG2Y3CfoLUIqZI/WoZsNnYO4HuPq FxNztFbbKj0a6mlglIyGvaRlZ2ux3G59X4GkmnLe4jaSprbdq5F13P0HXWqqq21dLVSSRdX4eVuH EgdgfBWn0tu1pHU2mZ7LqKQULQelrZHHD2eOfdVLraKqoJTFWQSQyjux7SCvGZHDsruy7Y4SzWul 2f8AtC0VpfTU9NZ7nBPGxmGQNdyR5wf1VM9QVUdbeayohz6Usrntz3wSvAZHEckrDqJSZaxuM+V4 Tly+W10/Wtt13o6twJbDK2RwHfAOVabdPXun9S7TyC13KB9T0sd6Bdh4IPIwqiAnxwvo2VwcBnhM Lxy5J5cPyY8auPtbuJpyr21FsrLhDT1kMDopIZXdLiMEZGe+V0tj1Ro2XR7bRDfaRkD4SwBz8OYC MYOfZUVErmnLTg/dP8TLnv8AzWcP10ufjme5flu9Z0Edp1NcKKGpZVQxSkRzRnLXtPYqb/heu+m7 fJUOr6xlJdmngyuw2RnsPqFXJz3OOSclZMkc0gtJB++Ey/a7q448ZqLP/EdNSC4WzVViutPLUwOb E5kbwXMxy1w9+V0Ng1lpfdvRTbZqeoiornTYLg5waCR/ibnuD7KoTqiV/wAr3OcPqSU4DKDmPPV4 x3WrnbZfpmeOSaW83XqdJWjaurs0NRSSieIsh9FzXFsgwQ7A7fdU9PfK9c0szx0yucfocr4the4f K0ke+FL21Jp022mpI9Laut91mjMkUMnztHfpPfCuVV1dm1VW2TU9tutOW0bXSNiLwC7I5GPdUMDH MOCvZT1VXEzEUsjGDnAcQEm56Zyky1v4XG3Sttl1jLYb0brDFb4JA2UkjqaXHjI8YOAfZb7de1Ra g26nt9DWwOqIYg9nzjD+kZwD9VRw1tUWlhmf0OOXN6jgr7NudwZH0sqp2t+khx/VbmdmWOX053w4 3G4fd2H3KrbHJSmeUQE4dF1Hp7+yt38MdLbKHRP4ukr45XVR/v2FwDopB3BHsqZSdReS7knyV6qG 41lDn8JPLDnv0PIz+yxe3bWpYnvWd1qds96jeMMqaWqJmHSch7HHDhn3GFM7LTpzcC6WjV1HVNlb HH0mLqGQ4cjI9wVSCsuNXcCw1c8sxZ263E4X3oLtcaFhZSVc8LCc9LHkDPutcryuU91y/HNTG+ou lfN0NP0Ou7bbaucMbCXNM5Pytc4Yw4eOfP1WWr9EVmoNVx3SlvjoLc9sfXBHLgSAdyOccjyqSVNT U1VQ+aolfJI45c9xJJP3Wzp9U3uCBsUVzq2xsGGt9Z2APoMqS0vj3ra2V40hbo9eWSCgvk7ZKZ4q PwFTKXjLSCHNJPGRn9l5fiotVVWaRp7rR4MdveXylruWg8ZGFU+o1FdJqyOrlrqh1TGAGSeoeoAe AV9qzV18q6SSmqLlVSQSDpdG6Vxa4fUdkwvG8jLCZST6fO96nu14pIaW5Vs1TBCcxiR2cHGMrRA4 7JlYnkhZdZEtbAaMg1jqWUVU7Wx0jWyOhBw6QE4yPsrazagsxrWaTlrGNqJacwNd1AEuAwW48HHK oDZrxXWasZV2yqlpqluQJI3FpwfHC9dbqW51twFdU1cr6wODhL1HqBHnPuk6u0ynKaW32f0ONJ60 v9HcmxzVDGxzUkxHzGMkg/8AvrZao0bqDWGoRDfJ44NPtLgI6eQhzsZ6XYPY884VTxuPqf8AGRVZ u1S6piYY2yOfk9J8Z8he5u7Orh/+makj6uz/AFW5nZbflzy8cupPS022ViotEarvWnhVB8tTHFVU /qH5nN5BH6LodFw3iirrrT36oc/8TIXUge/I6QTkAfbCpPXa9v8AW3emuc9xmdXU4xHN1fM0e32W wqd1NU1ctPJNdZvUp5PUjcDgtd24/RTndaX8e027R2mps++10pq1hjm9KaQA+WuIIcPoVJFt03cK beKvv8seKCWlETXg55DfP7KNvh+1PQ3281d81Hdom3yBnoASkM64SOMe+DlPfzVt107XU9x05fuq iqyWPhieCGOA8j2IW93yXO35cc8eEwk+HDby0zrxvDJSUbo3vrTEyNxPynqGBz91Pe4Wn6+fZZ9p giMlZBSxtcxvOSzGcfsqT1l6q5rp+PdO4VAf6jXtOC12cjHtyu8j3u1k2nETro54DeklzQSQmfk3 5Z5J8Onj8dx8P4r97T/8NlVFV7b3GgglYauOaXqjz8w6gMHC4XTGyV8nulVPcqt9sDG9UT43fMSS c59uCoQ0zrS7aau0lxs9W6mnkyH47OB8ELsm766ve1zH3APa9pa4OaCMHgrnheMs+3Xyazu3Ha+t tVa9V3GhrJzUz08pjdNnPXjsc/bC0UMTvUbkYAKnva667d3PTrm6xY3+MNmeXySDPW04wcrrvS2Z Lvl/D58kghN/KTqabva9v8Y+HyShtzmy1PozRGMHkOJPB/dcBobaDU0r62qmrpbPI1oDMgkS+wPP vhaPVOtKTQerXy7a3AG2VdO100WSWCQEg9/phay4b8aorqCekqJad8crSwj08d10nlsw4f1x/F/y fklazTViuly3IbQ9Dp7lFVl8wJ5JY4Fx/krBfE7RzS6UtdTHE50UE5MrgMhoc0gE/qqqaZ1fc9O6 jivVvnLa5jnEudyHdXcH3yu71LvdqDUNhq7TXGnfS1LOh46OffIK54Xhnzj05XlhMPqp7fRzXr4d IaS2s/EVElFHG1kfzEuDhkcL7autVW74fpLbHE59ZDRsY+NvJDmkEj9MKtGgd1b9oyCop7bOx1NM Q4xSjLWn3Htlb+n341DDWXCYfhyytaPUiLfk6sYLgPcj+initw47+Gs7y5f1MG2MN/0lpSCpqB/G tP1sYf8AhYW5fCXDsMk5GeCFs9a6bnqtKuvGjPXtNUyH+9oyCwPABJBb/mwTz5VfNEbyX3SdHNR0 skc1I95e2OUdXpk98fRbTUW/d+vNononNgidJjE0WWubz/qOF0x8nH4cPJ47nb27X4UJs6gvMfXx +HYQ3PnJylrzbW93a86iv8bgKWOre9sD8hxa3ByP5lQLpXVVx0xfIbna5jFPG7P0cPIP0KkjU+/F 7v1oko/Thpy85MkXBHgj65C54Xjy/rv5NZ5Y5fSx+rb3c7JoqzVVjo2V0jmxtcxzC4dPR3457gLi 9S3zWdw26uVZUWagioJIXMlijJ68E4Jx3z5URaN32vum7LHbXiKsgiP90Zcktb/lznsvrqrfe83y 3tpYWRUberLjF/j+hHkLXjymGunHy4c7e+k7WCK52vYYspWyxXSCmeWAfma4OyFBFx3ir5tA3DTF wpI5fxLXx+uD0uAcc8j6HK3VN8SN1joY4ZKCjc8NAe7kB3GM4+qgm+1wuN0qatrGxNmkdIGM7Nyc 4CmNmOOlsty5beOZ3U4n3K+BTJz5SU22SaEIDuUI8oKgRQj7IwqGEsoQEAjujyhAd0eU0IBCEFKE mEITYEIyhQCSaRVAhBQin4SRhAQHZCPKEAgoQiBCEIBCEIGgoQgQKEIQNLPKZS7BAeEdwhAQCMoK EAEe6EIBJNLwgPCEHhHhUBQn4S8oDKEYQUCTQhAk+6SEAUeU8IQHZCSEAj7p+UigMIKAhAeEIKO6 AQUIQCO3ZCPKAR/RCAVYDwhHhCBhJB7owgO6MoQgD+6EfRCAQj9E0C8p+Uscp+UAhHCXdEHlNIDl PsgEFCEB9EI7I+iAQmlwgAhCCgEykhABMhASQCY7pJoBCEIEgJoxwgRKAhHZABCPshUCEeUz2VUv KE8pZQB+yMYTx90igD3STKEAU0JIBGEyjufdAkJpYQSwZyc/MViZ+O5WubKfOEGTJwvl8Xq294mz yViJx1cn+a8JkOOCsGvL3YzlWYFrhL9/8Wqs57vK103he+8f/FaqPP5yvDP2avZj6eevkhCFpAhC EAhCEAvvQgGob1dsr4L7Ub+idpPbPKC8G1dloqHScNVDE0PEfVjHGcZyoog3ara7cSnlqGiKhhlM TYieoNOcEg9+cDhS3s/c6W86DayjlZJIIuhzQeWnpwoL0Joqrn3Eq6WupyH00xL4njk5PBVknG35 YtvLXws5X2ihv7qC6loMkYy0j2PdaXVuo/wt/tNnpQ1zpXFwnY/5oizGQR5z+i6WjlobRBT0pkER fgBjiMg/b2Ua6o0jLQbq0d8o2yPpKwEzDGQyQDvn2KkWpM1E26T26N1mqGxVoLXDrGWu47H6LW6W 1OzUMhgqIjT3OinMNTFnIDhwSD5C9OrK2voLfQTWprXzGZoc0jIc3HlanSmn6i16hrblP0t/iMrp XR+WO/6IjdXrT9Hcq2C4NjYy5U3DJR3LT/hd9FFfxVYbpK0uwA9tVkO8g48FdbWX6roN2/4fE4Gl no2PfGexwcZXLfFLC+fTlohiaXF9S7AHfPSF18M3lquXlupHt2NvEmr9CyW2/MZWQAOhPqDPU3Hl Vn3h0rT6Q1pWW+ieX0nEkQd3aD/h/RWd2CsVTYLCG1jC0yZeR7ZCgT4lHtduNO9pDmOhYQQc+6zh NzK34ayyszxk9VE7B84Vsvhr05QS6ebXmJv4lxdlxGSQD2VTWn5gVb34XLrST6bNFHMw1MZd1R55 5XPLcnTt0y13vOdKazZbWUnVSUryypbwS8HGC0+COV1ujL9Z75qX+JaZnBp6xg/ExAYHX7lvg891 Eevtu7jqfdS5/I+Gme4O9THcfRdps9omu0TqeqpKx3qRStZJFIB3H1+q7eWTG/q5eK3LHdSrUT10 ep2Q97c+MH5m5HVnlfShooKSur2U0TGRPDZCABguJOVEu+u4t80Zf6SmtEsQili63CRgcM5K7HZ+ 7zXvSv8AEKhwdNOS92OwJPICxlLjrfyxcplLpy+z1PFHrjVjYWNawVzgGgYHcqQ22KhdqKsuIgjF Q2JnUQ0AkcrhtpYJINb6qdKxzRJWuc3IxkcqS6ch9ddGMcDJ6cYLR3GAVvyf73SYdeOf9Odpauk1 hLdLJdbU4URb0BszMF3cE5VSNbaPodKbk/wmomLrY6Rrg48FrHHsfsrf6NulTcZD+Oo5KaWCV7Oo /lc3wVW7fmg/iW8EdCXiP1442BxGQM55VmM/f+MzyXeGvltN1NnrPb9Bu1Hp2cgQsbI5mepr2nvg qunn7qddwtCav0fo100N5nq7GQBND1kBgPb5c9lBR/Nx2XJ6obAerurR7O7qWmDT0drmtssV1Yzo jMUYeyU44J9lV+BvXI1vknCuDsptzQ2Szw3iu6XyPZ6hkcOGjGUpUjWb171Ypm6noKRtPKx2Q1uB 045JB7cLhLLrrTen5azT1FSyiqp3uZTmKMSxTD/Ccgry7r6rvFdbZKTSNNUupc9EtRG3s0eQQeQR 3BC9G0m3dJYbZHebqWOne3rMjh8rB3/RJ6ct9u3o6duodMTx6tt1HHBM09QaOAPrntj3Xj0rpK0a OstRVUcLpImlzuqNoc4gfTzwuK3V1jdqmjfBpqldJbIXYmqWDOMHB7cOaR+2FJFPXeltvFXUjRP6 cQlDWn82MHCqyubvmm7HuppWWT8MKWtp5HCKbo6XcHAyPYjwey9GjtKWrQ2lzVmn9QNH945jepxO cHjyum0pXU9zoKmtpYX07KmJrixzOkh3Ofv915b1WPtO37qtrDM6F/UWjyOrlawnKyJnlxlridaa PtG6ehn19BAylulP1mKTpxnGeD9Dj9FTK4U8lJVzU8wAkicWO+4X6F6WqqatstZV0cLoYZ2CToc3 pIJBzwqC6v8A/ujuX/z9/wDUrdxnC36rOPkvOY/caYc8pfZHZeq2W2suc/o0MEk8uMhkbclcXd5c 4CO6+9bRz0c74KqJ8MzD8zHjBC+lut1VXyOjoqeWeQDqLY2lxA9+FR5QUs4K+lRTzU8z45mOZI04 c1wwQvrR0VRVEtpoZJXAZIY0kj9lDbzpjlOSJ8bixzS1wOCCMELAIr00kElRM2ONpe9xw1oGSVZn YzZ/pMN3v0Q9Q4MUTxwPuPKgXbq60ll1dbK+4s9SkhlBlbjPy+eFdyi1dpfUMVFTWe9wBz3NLY4+ SexA9wp6Soz3w23tVfqTTsNtp46SqrpHRPcwYDgBnt7rsINL6P0Np+np7vS05cekHqaC92SASPfG V0uu6Ojnvmm55qkR11NU9UMRH+9BwHYPuAvBuVVWQXGlodQek2KphkbFJIPyuGOx8Fd8NeTKY/x4 8sr48d2+6iPcXY2OXUtHVaeLRa6946m+IyeePoVI0OktFaOs1HQ3qnow9/S3+8A6z1HGee4B9l2t R8lksbQcj1oBn6Arn9xWWKqvjaHUAha6akc6lfIekh7STgO8Ht91md+/p1u56vyhrXGxDotZUosr wbPXvy3/AOZeS39R2Kkn+xmg9M26htt8pqMzyFsYL2gu+Y4BOee/ld3WdRp9PDnPqxA/+ErktxYL HW6sfR3p0TKp9G19G57ukl7Xk4B9+3Hla8WM8mmfJlcda+1dN9trZND3T8Zb/wC8stU4mJ3cxn/K f9FEZ+6uV8UI6trqYu7h8Z/XBVM3d1M8NY45fbr487lcpfhL3w26et2otay0d3pmVNMadzuh4yMg qYLt8P8Abf7Z01VQ/LaJfmfDjhjhzj7FRx8JQ/8AqgSHvimf/VWDvm4kdo1lLp6oHTUTNidSu6ch xccOaf8ARcMbbv8Ajedk4z7aWu2f0mzU1vIt0YhqYpGvi/w5aAQfvyoR1HoO22nfKiskMXXa554n GM9g1x5arZXPnUdl/wCWb/yhcTeZdFybiRRXEPGoA9giPSe/jBXSZfrlb9OWV1nhEL/ENtfbtPOt 9VpulexsvU2SJgJAx2Kg99guTR/6jU4/+dH/AKK9mur9bdP6jsz7wwvpahssRIZ19J4IOFtKU0Uj ZauopKKO3Y6o5COklpGQSDxytZ2WY/bOFs3cr0/O2qppaaUxzxvjeBy14wV8FM/xF6hsV/vkBs9K yKenJjdMwdIlZ3GR7g5UMn6eVjKadcM+c5QeEwsMozyo2+gITzyF88phBn1e6CfqsEFB6IKiSJ3V G4td7jhfSorZ5wGyyvcB2BOcLyDgIyiHn3QCsQUIrIHlPKxyjKD6B7gODhZes/y8/uvijscoM3Pe /uT+6YPusEZRNM+Cm3usM+6YPCKz4BymO6wzwhB9CeEmrDKeUH0SPZY5yhQ2yBKZKwzhPuignAS7 jhCX2RAUvCCgFAFAR5QgAgoQeyAST8oQCXhNCuwkYT8o4UAgoRhAk0BBQAKD3QkUDQjyhAISTVAh HlLuUIPKZR25QUUk0JIDshP2QUQkITQCSEIaCEIygMJo8ZSQCPuhCBnshLCOyARjlCM5QGEIQAgE j3QUIGkhPwqaCWUYQgEIRlAeUIQgMIKPKSBoR4QgD3STSQCfYIQgXhGU0kAhAQgCjwj7oQHhHlGU BAIyhCsAUZQUBAIOMoQgAU0kIAclBR5QeyAyjuhCAwml3KM8oH4QEZyhEAQgfdAQLsmhHhAZQhCA KEeUd0AUZRwhAE4R4QgoAplJCATCSaAQEZSQPygISJQNLCaSB54STSxwqQIQjsqoQl/JP90D8oPI 4QhQJPHCD3QmwvKMcJ8owmwkJ+Uj3VAUcp+EZHuEHfduP0WRGMcgLXNq24HIx55T/GN9wV4ONejl GwLeOCMrGBv983PYrwtrG578/dfSCrBmbyO6apcnHXgYvFWPaQrwTHsF770c3eqI8yFeCbwvTHKv mhCFWQhCEAhCEAhpw4FCcbOpwCDrdE60u+kLi2rs9QWH/FG7lrx9Qu4uu9V0rb5RXmC30lLX046Z HR5xM3jhy0GiNsrrqiLrgIgYfyl4Jyt9SbI6gddpLdVllPL09UbsZbIPoUSvPrLeC6alr7dXMpmU NXR9WHRPJa7OO4P2XTj4h7zJRQRTWyjM0RaTJ1HD8e7f/fXF/wDZZe6XVIsddEIJnN6mSYy17fcF dWzYG+iqZDJPE1sn5HgZDkG8HxJ1z2Br7BROx/8ANXYXxqviPuMj4Xss1Ix0bs49Q8jyF5v/AIHa +cj8VFkf8B/6rwyfD/qIPfGZYg/BLMg/NhEabUm7tyu2r6bUFJTsoqiGMR+mHdbXNHgr07gbzVur rbb4nUDKSpo5BK2WN+cux7Faa2bW3yq1NNYqqM0lXG3OXg9LgexC8mott7zp2/0lturGwtqndMNQ eGO/X3WpU1HcRfEDdWabdbxboYq3o6BWRvwc+CW4woXu1wnuNXLU1TzJLI4ucfqeePZdzrbaq/6Y tguU0X4igwC6WIEhn1P0UdP4P0UakfPK3ulNSXDTdzhr7XO6GeM54PB+hWiI5HlZBpzwVFWYt/xK MdDEbnYWy1bGgGWOXGfr2XjoviLqI71NPVWxtTQu/wB2wv6Xx/Z2OVXcNxyhzT/hyrRM27+6tp19 aYoxZn01wgd1RVHqAkDy08chaTazdi56EqHRsZ+Ltrzl9M52MH3afCjMNJA6sr32i01d3rI6WiiM kzz0tACXv2zqLLM+IyxtcZY9PTxyu5JEgyVHs+9t4j1s6+UeGxn5DAeA6MHhp+uPKj7V2j7xpSWB l4pXRNnBMUg5a7HcA+4XOkceUTS0Ff8AEbbqi1TiltNRTV8jPz9TXM6vqFXe+agrrxdn3Cqneagu 6mkH8vOQB7ALUDhuecrYWWz1t5ro6W3wmSZ5wAArskm9u1uG72o7lpCXT1yfBU0j2Bhe5nz4HblR tkA8dlutTacuenK/8Hd6Z8Epb1NyOHD3B8rSAfQ/so1H0Yekg5wfCsxtzv5bLbpiG2agoJ3yRN9P MWC17cYVZvGU8EpoW/ot+NEUkRZS2+sijd3YI24KxofiA0r+FqKSqo6r0XPd0gNBa5h8EKoOC09z hZZ4SGlwKHfLQlFA6CCjrIYHDDmCIFpH2XAaL3ug05qW5UskT6nS9TM50UWADCCf8I9voq+Occ/d MuHHH7Ks8Vqtcb7WZtgMOlQ8Tvy35mdBaMcEHPgrlNsN8pbT61u1Y19da58knGXMJ7/ooAByPOVs 7HZa+91raS2U76iocMhjeShx2spr/fS0N01+H0i+QTyfI4PYWOjHgg+eVV2vq5KyslqJiDLK4vcR xyV7L5Z6+yVjqS6U0tNOBnoeMHC1o748pu60TGb38sT9V3Wzmq6TSGsKe4XGEy0bh6coHJaD5x5X Dnx3QOPuo0mT4ib7pfUtwt1y0w5jpnNLJ+lvSSO4JH6rntkNW0Oj9ZR1t1jLqOVhikIGS0E98eVH pdnIykRjtlW3aSaS98RF00zfL/Q3PS0sL/Vi6JxG3pJIPBI91rdh9XWzSmr/AF70zNHUM9Jz8ZDO e5CjIudxnhDiQMjP6KbWRK3xDVenrlq6C46WkifTzwj1fTGPnBPOPsopHCbSXDB/mtlR2S41kPrU tHPLEP8AGyMkfuita0kHupb+H2/2K0apLtSSmFpAdTzk/Kx49/uopkgfFIWvBa4HBBGCCsDkH5Uq Lh726ssV109TXSw6gpxeLXJ68DY3ZL+2QvppbcvSGurRQS6qkpqS80LgcTflcexLfcH+Sp418juM k54wPK97bXcgOo0dSPY+k5WWy7jnwx1qrMbwby09HLT27TMrH+i5snqNw5mAQWlpH7ELqdN7haM1 /brfXX+WkpLvQ8PiqCMc9y3PcH+Spq+KUPLXtcHjuCDlfZtJVjkQyD/uFL2sxkWb3X3nhorhT0Om 5GPbSvaevgt+U5BDs8g9iF19m1XoncCG13u5T0tPdKUFkkM7gMZ79/GeQVS2Rsgdh2c9jlZxtnjb 1AODT5wcKy3H0nCfKwHxHbk0d3pTp629EsEbhl4cDgtPcEdwQq6nkrObqLsuOfqvn5VuVskrWOEx 3Z8pk+GK+0Fk3BabnUMp454XRte84HVngZXX7w32hpd77NcPxMT6OIQufIx3UGgOOeyrax5bjHBH kHsvs+olmOZnveRwC52VianL+lluWN+n6D1eqLJLebFUMulGYZWyta/1W4yWghQLuJd6S3fEJbK2 oqGMo+uF7pM/KBnGcqu7audrGsEjuhvIGTgJTzzVDuqV7nuAwC454SXWOWP2lw3lM/pfy/zWC46k sctfV0rmYe6neZAB1jB79uyeqLc2+SQU0lzo2WkOBkgY4NMjc5xnPj6YVB/4lWdLGOmkLWflBcSG /Zff+NXHGPxcwb/zlWXVlc8/FM5xqWviV0ZadNXC3VdiJFNVNLXt6+sBw8g/ZQc72XurrhVVUbY6 meSRjTkBziQCvAOCrllyrp48ZhNQil2WRGUYWWyBTTATIQIITAKMIAcI7oDSU+n2QYnsllZAIxn7 oEhMhGOUAhBOEIDH3R9kJ4QMcppxtz4TLDnKDHHhACzwmAgwwgBZ4Tx/NBigdk8EHsf2WR4HKgw/ RBGFlkccpkFB8wksiMFIoFlCE0CwjsmEIA9kk8pIBCaSAQjuhA0vKE0CKEIQHZCPKEAUeUBCA8oR lCAS8p4QgEI8pKkCaSCihB7IRwgaXhMlARCQnhL7IBCPKaBAJpIRQjCEIgQj90IGhLCEAQhCOw7o BHhHlBwgM+UvKaD2QJCEKqCgIRhECE0vCACEFB4QJHZNGOUAhCQQCYCSED8oQMYSQBQhCAQhCAQS g/VCA8I+6EeUB3CMIQPqrAJJo8oDsgo8oKAQhCAQjwhAFBTS7oBMd0k0AfokmkclEHdNGEFAIQgo D6IHCEFAI7owmgSChHZAIR+iEAEIQgE/CSEAjKEx2QCSMIQMJIT7oEhH1QqQeUIymqpdu/lAQeyC gE0k8cKUBKEsJqAB5QCl2/VMZygD2SCZKDyqArHAWRR+oQer8TJ7lH4l/YO5XnPdHlcGnpFS8D5i vTRVJ9YBxPK1v6L0UIzUxnnuoPNdf/inUE/5l45+wXsu3FxmPkuyV4puwW4PmhIoVQ0IQgEIQgF7 7K1rrhAHcgvaMfqvAvVbZhBVxyH/AAuDv2KC9+j6Knt2jxUU0bWSMgc4ccZDcqA9JbmXWq1/FWXC VzoXv6fSYCWt+oCm7bO+0Wq9DSQW6oYakwOjLCcFri0jlRBtRoOrpdaVdPdYgyso34MTh+YH/EPo fBRL7WPnt9Ddn0ly6A6Ro4ePY9wuQvOqWz65obNQVEUtNFH1OLCeuORpwQf0XXfxa3W2rprY+Vsc 8jQ4RZ5+64W56Mdb9z477QRE0lXGfVIOQJM8nH1USu91Pbq640lP/C6x9LVRO6g8ZwcgcEeRlanR Opn6kzFVwiK4UEskE/Sctc5vGQvZrAXNrLW+zymKQSnrdjIx0jGR+68+ltO/wO4z1HW0yVsj5pWg fleeSR90ZybqqttJcaqOpwz8bTHAeO4B8H6KFfitcDarEDw4TvII7jgLsKS71NNvBXUTZSKeSnjJ jPYntlcp8T1HNcG6fpKVnXJJNJgfoF18cnO41x8mVmOOU+XQbFXKfUWghSXjFVCWviIkGctHGFVv d+wUum9c3Kgt4LaVruqNp/wg+FbTZmwzaa02yKrIADS9x9s8lVd38qYKvcW4zU0zJoXYLXMOQnjm 8Mtumdv5MZPSOWDn+im3aXbmwa7sckQrXU94YOWk/wAwPIUJDuFPXw9aXub7pDeGdcdO0Yae3Wub rW301sA51bU019kcOh2GOjOAR4K91s+H2j/iVRHU1xnpWn5HxEfL9D9Qp/vwnqrNVi3O/wDSTac9 GDhwdjj+ag7bCl1zbqutvEMorw6Uisonuw4uHc48OWvjbncu9FWfD3ZKqCaO13dv4wAhrTIHYPsQ F6NoduqCzXqdlVUNivdIemWnlOCQezm+4Puu6rrPbdYQzV9mNXYdQNbkSdJjIf7OHnlRRoeuv8e7 4odYzPN0gjMYdJgGRuflIPkeyz8NbSvvNoqHWWmY6BtRBTVMLjLCZCAOrGMKvm2O1tDqSauo7xVS 0dZTSujIaPlOOOD5U/b4aWuWq7RQUtoLRURSOlGTjIwOF7ds9ORWvTRbUUzBWxtPqte3IL8eVr4S XdQXuBsLUWOzS3Sxzur4qcdUsQ5d0+SPsuw+H3RtnNNDebfXR1M7mhssLsBzD7YUy2WsNx05Uyml jp39Dg5kZOOx8FV32Bk9Hcm4wF3RknDM47OPhW4/pyMct58Uj7+beu1hb4paGaCOroWOcyJ5ALh3 wP2UVaK2HlvNpbVXGqdSPcM9JAwB91KW+elr7qC5Uc1i6/7hp6wxxBP7d13enHy0Wh2Okj9SoghP XG7y5reQf2Ws56jh48tS2xXrVHw6VtPaZqqw1zayojaXekSPnA8Ajyoj0RRUA1lSUmpGGKkEvpzt k4LD2wfblW2s2urvW0L623aOcI2Zy1k2HnHsMcqttbTQa43Yq4nMfbjW1Dg6N4HVG/y0/XKxZZdV 2xy3Nx1+/e19l07pym1BpyQNiLmskiaeppBHBHsq/kkKZ94tv79omz07n3Kass05DMOcfkcOQCPZ Qufzc8hR0lfaCN00sbGjLnEAfcqdtM/D7c7tbIqmetZTPeASwtz3+qgyga6SeNjPzucGt8c54Vxt u9Q3O0abjtO4lFKLe9gbDXtBcAMcB5Hb6FN6KhzXmw1+01Z5blSvFfBCOqVjG4c1vuB5wvp8N1jq qzU5uFvmhNRScmnecF7D3IKmjWcepNIWCS86LrTebM5pdNS1AMro2/5mHOSMdwof+HyeSo3NNXEw RRzdby2MYa0k5wPopldTZj3dOt+J2nF2rbBSS0LqSrfKWCZ7RhwdgY6h3wVz8fw33aSFj23CE9Qz npP/AFXa/FWyWabT8VN1fiPWcY+nv1HGMfqpB28bfpdK0/8AaadmYmBzntbhwaB5wu/l6mN+48v+ Pd8u/lXm+fDzqS30MtTTPjqnRjqMbQQSPosLR8Puobjb4qkTQxF4yWPByFNevdX3M11uprJT1Itp qGNmq+ngDq/wuB7Y7ggLttY3236bsFNW3KGZ1MelpdAcOBPYrNwu5GsfLLLVN9w9pdQaJo2VtdG2 eiccGWIHDD9fZLZXRlv1rqeW2XOZ8TRF1s6XYJOVZPV2v7JU6KrIqy23RtvqoHBk1RD1sJI4Oc++ FWfazTF41FqVzNOVgo62lb6rJckEc+4WbOtumOW7Y+W8OgXaB1OKBs5nppoxLC8jBAzjBXBHhSBv C7VEF/bQaynfPV07MxyO7OafIPso8GcLLpj67dTt1Yo9R6st9smf0MqJOkkeArp1EFk230pTsdSs cwcNb0ZDsYJyfBIVRdjpGR7k2QvcAPW7n7K42491p7c+0MrIXy0tU58Dg1nXjLR4WvHOWWq4+fyX x47k7RpvLs/R6lpYNR6XaymnqA0yQn5Wv6ux+/KrzqXby/6ducFDcKGRs1RxEWjLX/QH3CuTuJKa LaKsfQOez0ommIjhzcOGF9Nt5ZtX6JttTqWmDrhTu4e5mHZHGefcJr9drvd1FWLToSt0Pd7VetZ2 t01idIGyOid1dGezj9vZWBue4Ol6KC2/wi2tu1PUfL1Rs6SweCchcR8Qms7lU1lVpC30bjFgCRsb S4yN4IwPBHuFoNp9zzpmgh09fLK2pDZA2J7x0vYHHsQRyMrWWHD254eT8npM+rtuNOXi82S8Oo2Q vkc1kjGNAD8jLSfqCjW9+smj7vb7ZNYmVRqGN6XsaBjnHK6nUNIayWyPZUSwQPkaDDGRjOMtIPgg /uuc3J1pb9OaittvuVpjr31LGhszgMty7H9VrHXVs30W3ep125/cvZ6y6gu9sr7extFNUPaJmMAA kGM/v9Vv6yk0XpWOgsVxpKYvlAYWujBIa7gH6jPddVdYpBf7FPHK5tO9wa6A4wD0kgj2K5DcCrsX 9rqq33pkf4uakiko3vHIe154DvBzj7qYyWGeWU/+qvvxBbWjRNxbcbWQ6y1bj0N8xO79P29lDGOP qrkfFhk7d0XV39Zv9FTbymWGsccvt18efK2fT1W2hnuNZDSUjC+omeGMaP8AET4XT1m3GqqKCSWe z1jWRgud8mcALe7C6Vl1PrSH0ZjE6iLajjucO8Hwrp0VVTyXeS2SXKGoqY48yUxjHUGkdyVybyun 582XTd0vcksdpo5qmSJvU9sYyQMr30mhtSVUL5ILTWPYxzo3ERnhw7j7qdabp0h8Rf4OyMbDR1r2 tlix8uHDJ4+/Kl7Ul5Ondc2O3UUEXoXeZwmDhwHDyPqVu4ayuN+O3OeWcccvtRGWhnp6h0E8b2Ss d0uY4YIPthWj2F0faLtp19s1LpssrYCXsqJoseqx3PBx4XfX3baw3TceC4yUzRP6XqvZ0/K8g4yR 74XS6dv9HXanuFno4yw2yMRyBzfPgg57Y+imU16WZb6qj+71ipdP69u1vt7S2limPptP+EHnC4sj jPlSX8QPO595/wDnv+gUaHHHC35cZjlqJ4crljuvVb6Cpr5xDRwSzynkMjaXE/oFsjpe8NBLrZWg NGSfRdwFLXwwXqw2zUk0F7jjZUVHSKapf2Y7sWn6FWK1BdrjY66aetsdPU2GMAvqKfmQNPc9OOce ViTfprLOY+1IdOabq71cKeCCnndC+VsckrGEhgJ5JUy757TW/Suk7LV2eB76prjFUOYD/eNAyHEe 63dp1zY9ObhTU2l6eKqst4dGXMe0t9CYuIOB7EFS3vDq2HSdno5Ki3srYah5iLHY4+X6/RWY25cW c/Jxw5KH01DUVUjmU0MszgMkMaXHH6L6VFrqqXpNRTzRdXAL2FuT+qsP8PWnZ6vVdxv9DSxR2hxl iEcvzAZ5DT9lOOoNJW3VGm66iutFRlhBMctP3a4DII9iFLNXSzPc2o9o7S8+ob3QUTQ9kVTOIjN0 ktbn69lIW+221Fot1p/hbX/3lPifPI62nBd+q6fYfWcNju40tV26GpjnrP7mbs9jyQDnjnsFLG9O rbXYHQUd1tTK5lbDIwOOMszxxn7rr45Odxs25ebKzHHKXW1IGUskjiI2OcRycJuopmgudE8NHc4O ArffDhpG0DRc92fTMlq55ZYnGXBBa0/KPopFl0xab3Q1NHcrRQR08rC0uhcHH9wAuUsrvlvH2/Px tJI84awuH0SfSSMblzSP0VyNo9LaVt1XqG0wxw1V5pJ3RvZOMlzBgsLfpzg4XuvL9K1tLWWfVmnm 2WOYOjjqZGDpeR5a8DjHdXjGblx9qSxQvllZFG0uke4NaB5J4C29+0teLA2I3i3z0olz0OkbgOx7 Feu4wxWPVMrKORlRHR1WY5AeJA12Qc/XAUrb07mWvXGjbZS09LNBXQSCSUPbwPlwQD91nLGzKxuZ SyX7QHjCzjYXOwk4fMV6KMD1efClumpN1M2z2zM2q4f4heXSUltc0lhAw53GQ7HsV7t1tlf7P2qK 76dlfW27p/vfJb/xfZTbBPLT7I2h0FQ+mkdT00fqsOC0Oe0H+RK2e39tfb7HqCz1czqqngqJGxmX n5HMBA/mtY94zO+qxl1nl457ih8tO6J5BGUQwPkfjCtVp/S2ktyNDPorbTxUV9om9LiGgOLm5AJ9 wV6a7Q2jdGaBkptQxMdXyxF5kAzIx7hgYPfAKk1b0mWfCbycdpTYOnqNMUtwvt1bSTVJDmhpHT0E At5PnuvPrzYttn0u+8WG4fxNkJJla0A4aO5BBOcJbY2/Veu6WG0VNbUDTdK5rZHv5x0nhrCecjPP 0Uo631PZ9C6fbp6gDJZpW4ljyTnqBaTnPByFqa+WJu5anyiHbjZGq1FbJrldqk2+lAHpZbku55J9 lqdytpK3SV1pYxIZ7dUua1tQB+UkgEFWe1PSVFZZ7BaqGsdQivDo5ZGNByPQJ7H6gLQ3dtRNsPXi 6y/iaylp5W+s7v1RvIafvwE8es/Xy3nLhOV+Efu+HGijjY+S/iFr/wApe1o6uM+StDrvYV2ntJV1 5huoqG0zA/oDBhzc47rWWu76x3GqKKwx1b54oXZEjh0+mAMEl3ngdvKmbdSrodKbNVGn6ms9WqfT fh4iRy92Qf04WeOW+K8prl62pdK3oe5p7gr5FeisP984jyV8FlpiEIPdAHugY+qCjshAkYTQgRQm hAvdA5TSQMBLCE+yBIQhAYR4R2R5QAQjygoD+iEvKaAR3QhAHgoQkqGjyhCgEeUvKaA8IKMoQHlB CElQI7I8IRQhCPqUQfZCEBAI88IR3QGUI8IBQCEI8IBBQg90CwhMpIH4STOUIEEI8oVUITKSAR5Q jKBZ5R5RhNECQQUIA4R4Qj7IBCEYQCEIQCD3QhAIQhAeEd0ICAQhBVgPPKEIB5QLymhCA88IQEIA BBRhCAzhHlCPKA7ppAhMIDyhCPCIChCAgMcoQUDlAIRyjygY5Qe6EFAgUHlHlHhAIR5RlAJpI7hA dkIKCgEI8IQH3QUeU84QHZCSfhAI8JIQCEIPJVUFHhH3QgE0k1AsozymkgEZ5QEeeUDylzlCBygE YHun4WKD6uGD7JDuvrI3C+ZC4tAr0UOfxUf/ADBechemg/8AWYx7uQeO7f8AxQlx4K8U3he26n/0 jN9DheKbwtQfJMJIVRkhJNAIQhAJs75HhJZwMMkga0EklB0WldT3XTVwZWWeqfBM3vjkO+hHldbV 7u6nqr1TXR00EddAOkSRxgdbfZ3uFsdBbQVmo6MT1MrqUPGWfLk/qt7b9hqt90noK2uYyUDqiewA hw/dEtcPqPcy/wCoLtSXCrljirKYYjfA3p4+2V0TN+NXtjgaZKUvixh5h5P35WEGzlyg1e+y3J/p sDQ9k7BkPae36rsWfDw9tUyGa5gNmJ9JwaOceCibaJvxDas6RmOgP/0H/wB9fCo3+1XLLFI0UbHR kkdMWAc+CMrsR8N/+H+Kku8DpH/VeF/w51XW+MXFoeQSz5c5x78ppNozue5t9r9VM1AHxQXFjWsz E3DXBvbIyvvrLdi/6rjofx4gimo3F8UsDS12TjOefotxZNm7lPqiost1eaWSMZY8NyJAexBWt1Lt fV6Y1TSWy8VDIqWrdiGqHY/Q+xWpLvovHrb1Ve+GqqrTxtUzqcAtDfxDGlsnH1BUV1M755HySuLn uOXE+VKm4Wzd50vaf4tSuFfbg0OkdGPmYPfHsomcMduQVK1Cbw4KR9vN1r7omndS0YhqaU8iKcEh v2UcNBLsePdSxt5tDcdWUTasyimhf+QubnqQrKLezU0GpX3eCYDrOTTuJLMew84Xsk3zvTNRC8Ud HTUszx01ETM+nNjsSPf6rd3X4cb1BRyS0VXFNK0ZawjHV9FB92tlVba6ejroXwVMLix8bxgghIid v/glLm781koCT5DnAqKtUa4ut91GLzNUOjqmOzCWu5iGchoPsFx4jc0dkBhz8qKnyzfEdeaS2Q09 fbqasmjb0+sXFrj9futTZN99RWy+1Va7oqaec800p4aPABUMlp8pgOxxkImlh3fEdWR1MctJZqaF pz6sYeS14P8ARRbfNcSz61fqKxwfwuoc4P6In5Af5P2PsuK6c9yn0dsoSLF0PxKVZtjYq+0MkrAz pM8cvTk474wtPpT4gbxaaupNzgbcaSdxcWOPSWk/VQYePddboHRVfrSrlpbXJC2eNocWvOCR9ELE 1SfEjTNhkbS2AQPc0hr2S9JaccHtyoBveoq256invMkvRXSyeoZIx0nq9+PK3evdub/osRSXemxT yHpbMzlufY+y4otwfKvZqO31NudqTUun22e8VTailaWkFzB1ZHY5XDOKzK3mmNK3LU9aKW1U/qy+ SeGj7lRWijd0EOyRjnI4wp+2537darC206ooDcoIwBFICOrHs4HuoPvtmrrDc5rfdKZ9PVRHDmOG PsR7herSunK/U1zZQWtgkqHAkAnHCG1jLh8QlnZZ6mntFqno53tPQThzM/Vv1Ua7VboQ6Qv1bU11 tZUUlXIZXCEBronH/L9PouF1dpS76Urm0t6o308jh1MdjLXj6HytDwOeUSLH7mbxaZ1baIxDRVMd 0pZGzUs7gMNcCDg+4K6K1/ETp+a0U8N3ttUahrQ2QR4IJ+h9j7Kpox9UdQb3BCu7eqkwk9Ldzb9a ONqnooaKrZG9jg1hY3DSQcH91ptM782Os0+y26wt8lRJAcNkY0FsjR2JHgqrocCeMo7FNrxnpaXW W+OmKjSNVbLNQSOMkZiFPURgxlpGD2PGFAOiNY3HRt/judocA9vDo3cte32K5hx4wkeybXTuN1tw J9wK+kraukjp54I/TPQcgjuFwRPHfCzH6rb2LTl0v7pW2iilq3wgOeI25LQeyiyaa+gqZaaeOaB7 mSxuDmuacEFWf2630tNbYobfrqNzqqlLXQ1Ibnqx2z7H+qrDVUs1FVSU9TE+KeN3S9jxgtP1Xrob RcK+mnnoqSaeKnb1SOYwkNHuVfSXVWQ17vlbaq8UdHRRGpsQcDUADpMjT3bg+RjIK3Grd97Hb7LS s0m9z5SQS17S0sAxjPvnsVUvJx7rYWix3S8NldbaGeqbFgv9Jhd0/dT+MzGe1i9W7m6TvVJb9UWx wp9VUXSTA9nyzN7OYT9uxW8frXarUv4S63aJlPcQ0BzfT5aR9vr5VSZWyRSOY9pa5pwWnggr59bv HC1u32k8cnpb7X29tloIrabBLFXCKRrh3BZ09wR9QV7rprfbPWX4G6Xas9Orha0ta7IMZBzj68qm Yef/AKSj1HD3H6qbq8JvdWw3d3itraShZpetE00LmSRzMPLXN7hwPghb3TW6WhtU09vuuoX01He6 Vhje2Ycc9yD5B7/RUzDnEjK9BinFOZ2xv9Hq6S/pPTn2yru6icImj4gN0Y9UzPtFu6XW+F3Ds5BL f8QPsR4UG+U3AnPK+7KKpfAZmQyOhBwXhp6f3S5WySrjhMd6+Ug7G67h0Lq6OtrYjJRzN9Kbp7ta fI+yszUau0ZRXx+rqG9QTTyxNjlgDhl0f0HcEd8Kj3IWbZZRgDsPqp/+SzetrPbhXfTdLuXp7V9v u0FXSyztFSxjsujAHfHfGCuj3M1rYHax0fd6e4wVFHT1BdI+N2egHyR9lT/1pskE8fUrL1pMcuP2 WrneVv3NOc8U1jj8S7Xj1Fufp606ptNWK6CooKpjoJJYng+kSQQT9FnT3jSmm9QV+oo73TzNuUjW zgSA+mDgB31Ge6oz678YJ4+6YqZcY6zj2ypcrZp0mHe0ufEnbqOLWP8AFbbXQ1lJcWl/VG4HpcOC OFDvsvtJK+QNEjiQO2T2WPpOLOOylyuV3THGYTUS/wDD3cdLNudXatWU8Lm1nT6FRIBiNwzxnxnK s5peGls0kkcmqYq+3ub0Npp3tf0N8AHOf3VA2dbHAg4PuF6/4hWAfLO8f94qy2dMZYbu0p7n1Vjs m6IqdPZdRwysmlhHAbI12XBv0OFZeSr0puTZbXWVNRTT0bepzqaV4Dg4jGMe4Koa+WSV5fK4uee5 JyV9oa2phaGxTPY3OcAkBLby5fLfGXDguTtnqLStn1LedM22oFNDUv8AVgEuGhr8YcwfbGR75XUa OpqHSLJrPVXWGYXCR8sEpcAM45bjxxz9VQ4Vk3qh5eTJnPVnnPvleuS7VsjWdVTKek5bl5OD7q3L bMx0kWuDdAbvsNc71YqOsbP1x9nxk5yP0/orO3+w6W182iu9ZUxVdvbTudH0yYIzznjzx2VE6qtq KuYSVEr5JAA0Fxycey9VNd6+liEUNVNHGP8AC17gP2SZ2ZXKe6mWGOWMxvwuLtRddPSWq96Tstwb lkkr4C84JjeO/PsV59NbV09vZWVF/vctawMDm+hKWGLp5PIOTwqew19TBUCaGV8cw7PY4g/uF7/7 S3hrSDXVPPGfUdlJlrozwmd5VZ7b+zadu89z/gF6mZqihqHmKqfISZWZy1xB/MCOCpGrLY+76Rra DXbqSpDWuf61P3aPfGMgj3VDaW6VdHUetSzSRSjjrY4grYSatvr4yx9yqXNcMEOkceE5fJcdzT1V /wCDturnMbK2po6arGJGjIkY12c/qFL/AMQly0hd9IWms01LROq/VBkbDgODXN8jv3Veepznkkkl ZEuIwe3ssW7yuTpLrGYvmeSV9qZ/Q8ZXz6eUYI7FTTXpcPbO/wBq3I2vOk21Jo7rT07Y+knk9JBa 9vuMgZ8hdUa6k230WTfa51RVzsBkc5/U6R+OkkE98cfoqRWi7VtorI6q31EtPUM7SRuLSPfkLY3v V14vTImXOtlqWxElvqOyRnutS6xmPwxnjyty+atds/pml0dY5dUXSsYH1cPWPmwwRnloz2zn+q+O 7diZuHpek1Jp2dsxp4XdUWe7c5cPuFVk6zvL7ILS+vnfQAANhc4kNAOQB7BZ2LWt8sdLLTW24TQ0 8ueuMOy05GDx9kwvC2xnPDnJL8LowW6stu3Vvg0bS0wmmhY5zXHpHzMALgR5zg/ootve09dDpW6a hv8AXPfeouqofGDlrg3B7+5GfChG37l6nt9FFS014qhTxDpYwvyGj2GV9qndXVNRTzQT3aokilaW OY92WkEY7HhbnkmuNnTnfFZn+TG9rTOq27jaCt1ZpO4mmulvex4aHYcx4GHNd9xn7r47kVtFpXaq 4WavrRLW1MEjWF2A573fNkjxkk/sqjaa1fd9NzyTWeulpnyjpf0Hhw+oWGqNXXbUtWyou1W6olaw MBdxwP8A7a54f8fWLtl+01VlfhUET7VfpGtb6jZGYOOR8pUB7mahrrxqOrNfO+V0bzGM+zSQP5LV aU1retLyTus9bLTiYASBp4djstHX10tdWTVNQ7qlkcXOPuT3WsM7jjlPtnPCZ5zL6fB5y4knJWAT ysVh0IJpIQP6JpeUkGRSKaECCE0j3QCSecpeUAgoQgaQCEf6IBCEEZQCPshBQCPCPCMIBLymgoBG EIVCQmUKAQjwhAJJlCASKaRVAgIQhsdyhCEDSQhAIQUIGhCEAkglCAQjKPKAS8poCA8I+ySEAhCF VNJNJAf0Qj6oygEJZTRCKCmkgPshCPCAQhGUB5R3QO6EAUIQgEeUI8oBCf0S+6AKB24QhWA8IR4Q gMJeU0AIBASTH0QHhCEIBHdHdCA8oRlAQPCSPKMoh55QhGOUAgd0coQM9kkIHdABCEEfqgPKD9kB Hn6IBA7IwmgRQhNAh3T8IQSgSYQhAkEZKfdHZAkIQUAhCaBIygI4wqbPykmUlAz3Ql4QgD90I/oh FCEFCARlHdPHCugISz7o4900PdUsw44C869tWMEn9V4clcGiPdeqg5qmD6ry5Xst+PxLPug8Fx5r pf8AmXimGCF7bh/69OP+MrxzeFqFfFMJJhVDQhCAQhCAW30o0OvtGCAR6re/3C05Xvs9T+Dr4Jxk +m4O/YoL3RYtmg56ulAjnip3va8DyGkj+irntfrS6HXjaypklmNU7+9De2ffCnXQl/t+udBTUNDU sbVvgdEWOPIJbhR5s9oWa0aoroLswR19K7obGezm+HD3BV3OOvlxkvK2+lgDTUlcaevdE10vTgOx z9io/Zqlt63I/h1HUerRUjfydOCyUHDguxk1NbqO+w2SR4ZUujEnR24PYj3XNP0f/Dtyje6GNgpq yMdYZ/nHc4+uVlp1mqLI67sp3QVUlLUQdb2Sxn5mnA8eRkchanb3Uk+o6QPrGAVlI+SGR7eBIW8d WPGV7tWUVwrK60yW2okpxE9/qPZ5BA4P04WemrDBYalzaZxPrdcjx/xHkn9VStoYaO6VAlZ0mrpH 4JA+Zv0+xVffitcfxtl8H5z/AEXb6XuE8O7t7p/XLWP6D6eeD78Ll/iPtk141JZKOnwHydQBK9Xi kxzzx/jxeTK54+PPXuu02Lq5rvoGnir3evE6MtLZOcjthVP3cs9JZNe3eit8fpUzJj0Rjs36D6K4 e3FoZpDS0cNVKGxRMLnOdxjjKqFvHcaa6a+utXRTNlp5JMte3yuOOuN37eu75zXpxLPzKznw7bmU NNSxWC9lsB4bBMeGn6H2KrGz830VnNq9ttLay0OyVr3R14bh0sT/AJmP+y5uySLnBqHR92rb5QmW 92GVxmfTtfmSIHk9P0C0Q0/pDeGSW7RQy09a0Brg4YcSPfC320dsvunmVdrvVQ+enjlcyJ7+Q5ng 8/0W20rZ6O0a4vEduhbDDMGTlrfyh7gc4Vnpyyt2j6o2L0xcqaoo6SWSmucTcEEk9J8H7Fa/R+wV C2CVt+LpJWuOXR5Ax44UzW6CSPW1xnkYRFJCwNce2QOVtKQOMlx6JMP6W9IB5BAKb1dNY9zaE7ls Dpm4Uc0dornw1gB6S7JGfYgrW6R2DoBQyHUTniZjj1OY7gYUgWu56+rn1OIrZGY3FrGzQ4c4D65X ZWl9VU2OrFbG1taWObJG3sHYPb6K7TaEqzYnTF4opxpq7MfWxgkBsnWM+xHheKu2BoTpN9bFPJBc YGF0jHnLSWjJC8GnNtdZNram4Wyvkt1S15IjLi0vGfKsBRMqZdFVcVTl9Z6D2SDuS7px/VWe9OeW VmO57QBdNh6OfQv8XtVS9la2EzFshy12BkhR9sdJNTbh24ROcxxcWuwfp2VtaNjm7XvYGn1G0jml vkHoVWdk7fUVGv6eeKJzmQPJkIH5c57rNn6cm8M9+ThU5fFGPV28g6uXOlYf1woq2u2qserNPfiq +tnpqpriHAjDf0PlS78SQ/8AhIoHEZibOzrPgD6rprbFTWTb5tfaKWGVzIg9sZb1Nd29l6LN+LCf LhjlrPyZX1Fct0dlpNIUUN3oZ3VtoLgJy0ZdEM/m47hTTsZpSyWy2NrrHXR1sNS0OcCQXNOPbwui 3Em/iG0twlZCxpkgJLIxwPdRZ8JlQxz7lEZAXMcMNzzjC4548fHM59u2OfLO4fUfL4kdvTc31eo7 fVwSVFNG31abI6ywew+i4z4aLJHcdRyVNPXimuVNh0cbm5EjT3XY76bf6kvl+r7tZ4vWgZGA6MOw 4gDnA8+Vxvw10lSNcsn9N4ija5jzjAafYq+br0x/iftj27r4k6asuldpu2XGmiiEtQWtqYn9Wc4B BaRwuC3L2RqdKWBt5oa38XSNx6rXjpc0HjI91KfxKVDKS76Xq5siGGq63nGcAYyux3Igdqjan/0J irbM2MtMfORnkrWU35MMfixjxZ3hll8yoFt2w9VdtGU96tdc19RJF6hhkGB9gVtrT8OklXbYaiqu 34eV7cuYWDAP3KnnRlDJa9uoKCqLY52U/T37uweyy15qAaa0fS1s1u/iIaGNMPkk8cLMx3dR0zz4 91VncvZG66RtX8UpZhX0Df8Aelg+Zg9+O4UPOGHd1djUWuK4aJq5ptKVDLbNA4O6Xh3QCO5H0VK5 y10ziz8pJI+yy64ZbbTSVmk1Bf6O2RyCN1Q8MDyMgKaLj8N95pYY5YK2OZhIDiG4LQfOFHOzADtw 7IP/AJuFfKqmkjrrVG12IpWvbIPfDRhRq3Sj+5G0d70NTRVtR01VvkPSZ4xww/UeFKHwt2GspoZ7 1QPhqWSkw1FOHAPaB2PP3Uv7juNbtJdzVta4+k8YI8B2Aog+EYzNvN0DuoQmNvT7E85Ws8ePjnk+ 7pjDPnncPqOV3kszNS7zx0EbG26epYyNxmAA6ucHjvn3VhNq9AR6X0m+31kED6ktcHStHEgPv7qv HxMOc3c+SRhLXNhZhwOCCPZWB2MuNTdNrIaitnfPMWOBe92Txwuvmms44+G78O1Ud2dBXLRl8P4y nLKOpc50EjeWnntlTT8LdirrbaZrqyCKroa8Yc1rh1RubxyCoj3Odqtwa2/CsNsExNO6YEsz9D9l MHwfzzfhbzA97/Sa5pa0njss/wCRNeTTXhtvjlRJurY5L1utcKayUL45ZpPmgDcFrvJwPHle6v2C 1bS0H4oRQzNABLY3EuAPnspKtMbX/E7UlwGPm/X5QpSvdxqoN3LHb4Z3to5qV5kiB+VxBOOFvy4y 52T4jPiz4+PHfe1RdWbS6j0vFRTXGKI09VI2JkrH5a1ziAOrjjut9LsBrFlOZI4qaX5eoBkmer7c KwO4lA/UO41q05PUOZbZqf8AEPhxlrnMdlvHhdhRVdBbdUUmn2SVgqvw/rNHXmPpHGMHt2XPLHWt N4eS5e1HNMaEvGodRTWSmiEVwhDi+KY9JHT3H3VrqfbOmi2gqLN/DmCvlgHUwj/2o/xAqMPiRqJd N7oUt1skhoq00wkMsPykuBPJ9+FNz71cZdm23Vs7zcXUYkEje/WrjjcfJjPtnyeTfiyy+lH9TWCu 05ep7bdIHwVEXPS4d2nsR7gq1GxVi/hO3dRTaitTZKWoaaiOXpEjXMcOQcdsKuev71e7/fIqjUjZ BWMjETTJH0EsyceOVaf4bK6qrNr3MrJXyiGV8cfUc4b4H2Uy6z1/Wt2+Lf8AFSqjTk111dU26wwG UPnc2IDsG54yfAXSu2U1qwE/won6NeCVK/w8U0L9z9SCSNrgGuIBH/GV1tw15e6beyDTrJx/DZJW AsLRkZHPK15cP3z1/wCKYZ6xwl91WC17eaiutyraCjoXuq6P/fRO4c1euh2p1bXUz56a1TOYx7o3 A8ODm9xhWr1fi07waWqLeBBLX9cNUW8CVgHAd7491sdRXqrtG6On7bQuaykuYeaiPHDi3/EPY/VZ uHfX1tMfNvX/AHpQ64UNRb6qWmq4pIaiJxa+N4wWkeMLzDCsV8Xtoo6bUdvrqeBkdRURH1nNGOsg 8E/VV2HATPx3CS/br48+e/42mn6IV90padwJZJK1rsd+kkZV2ZdNaL0Zp+1091t9MaSdwg9eWMEt 6hkdR9vqqkbR3iKya4ttVUUrKqIyek+N4yMO4z9wrdb9VlqptvXxXWne+CoHRE5oBdE/GWu/dTxY 885iz587hhuK4btbZPtOvzbNLwyVtPVwfjII4xktYTyB7ge64e9aJv1opHVVfa6uGnacOe9nAz7q b/hztV0v17F7nuEhjtTTSjrcXOa1zcgDP+H6Kfqc23UlsuVJLWU9zpjmKaMRgdB8gqa70uWcj8/7 PYrhd6kwW6kmqZcZ6Y25OFtKjQupKaOSSWzVwjjBc53pHgDuVaX4drRRUlFqCWKBnq01c+GOQj5g 3GMZXP0e/ppNQzUOordE6ha98TnwjLvIBwVv8d/b+Mfmx3J9qw2+3z1lbFT08T5Z5T0sY0ZJPsFY /cvRmmINm6e401FFSXmnhiJHT0PLuA4EeVFOrLtaqbcRt50b1xUrZG1UbHsx6cmcluM9v+qsjvhI 26bIurp42etNDDNloxhxwThPD35JjWvL/pyVL0fLQUmp6Ge7UoqqGKYGaI/4m+VYHfnQGl7ft/Be LDQtpZC5j2OaMdTXDsVWyj+asH1KttvtxsnbwP8A5HB/5Vf8bvyzG+mP8q3DxTKfcVLs9FLXXOGn hifK5zvyMaSSByeB9Mqe969EaYt+3tsvNhhjhqXOZ6gY7OQ5vOR4wVD2hbxUaf1bb7lQtY6eGYAN eMgg8EH9CrNfExTU8u3dDVRwRxPdPG75ABw4cj6qf48mXl43+t/5G8MNxXzazQM2rtU0FHUMmhoZ S57pvTPS4NBPTn6kYW83/wBCUmlNURx2alfFRSUzJHYyWseSQRn9FIvw168dNUUGkpqGF3pGR8VV /iDcE4/fK3nxDa1preazTdda46iOrpA5s+R1sJzj9iPdc8Jztk+GvLeEl17Va0xb2XC+UVNIxzo3 zNEgH+TI6j+ymT4g9vNPaXtdqrtPt9P8RIWPZ19XHTkFcHs9ejYNeW2pNPHUNlf+HeyQZBa/AJ+6 nT4qbdTMslkfDE2N3rPb8oxx05WvD3ncTyTWGOWvlVVlFLOXejG9wHB6WkpSUU0WPUY9mf8AM0hX d2n0zabTtxbqimpKYvqoY5pTU4wXnuckcd1uNR6QtGodO1tFc6SiGWl0T4MAggHB++fZc5d9umU1 dVQllFI/8rXEfQZSlo5Ih8zXjPYuGFdXai26dG32NO0NNX1cBJqaeZw6zNjDskjjOBjwtZrI6S1B p2ptmp7a3TlxDTLAHsDTnHBaQAD7ELWmdqh2i0Vd2ucFFQQPnqpj0sjb3JXq1Fp+5afqxTXajmpJ y0PDJG4JafK2+iL67S+rrddo4xL+Gl6izOOodjj9F1O/muqLXd0t9ZQ00tP6EBic2Qgk/NkFY3d6 as62if8ARBwsSUs8qsss8JHlIpIrLulhCeUC7BJBR/ogB2QmhAIRhLwgfZCXlNAsppBNAk0kFAFP ul4TPKASTS8fRAIQEZQHlMoCSAPCMoQEAhHhNAkITQJCAeUIBHlBTQL7o7FJNWA8pJpJQ8ISR5UB 5TwhCql4R4QgIhpI7IQMJI8oQHdJMoQGEFCAgEFCMeUCQhNVS4RlNIoDyhAQgEFCECymhJAeU0BB 7IEhCPqiBHhCEAmEkIBCChAI8oR4QCEI8IBCPojP7KwHlJCf2QCM8IJQgSaEY54QCEIQA7I7lCO6 ATHZLsmgWUBCPKIaEk8oDKEeUIBCEHsgAhHlCAQeyf3S8IBPwkjKATSQUAjHshCAQmkgEd0IHfKA 7IQhAZTSQgEJoPbhAkFCAgaRQj7IBBCEfdFGEHjsgI7kKg8cIynwkqDGViss8IwPdBt60YyFrj3+ q2lePmOPda1w+ZeetRhjC9VvGahp9l58L02//wBZb90Hgrx/t0p7fMvJUeOy9VwP+2O4Xkn8cKwr 5eUBJNaQ0IQgEIQgSzj7rFeihpn1M7Y42lznHAA8lBttP325WOqFVaquWlmH+JjsZXQz7j6pnucV fJdp/wAbG3pbMMB2Pb6qRNv9km3e2ia7vkilkGWhv+FbGybHW2quldbpboyd8Z+SWJw4+hHuPKMW oevGtb9eLtBcq+4TSV0IAZMMBwA8cLfM3e1n/df+mpy6L8h6W5H8l2Nq2VdDrKotN1e59IxrXMnj 46gf9QuxZ8P9khrmU9RcJMTZMRzg8eP5pERX/wBt+t2j5bs79Y2rzy7zazknZN/FniVmcEMaO/6K ZX/D1YBM2J1yeyV+ehpeMux7DyvI/wCHO3kyQ/xGQSkExuxwPuFRA1Vrq/VGof44a57LlxmVgAzj tx2X01PuDqHUslHLdqwyzUhJika0NcCfqFJGntj5X6kqbTfpHQlozDLGPllb7j/otBqfbGDSmuaS 03mvaLdVcx1A4I+jvbnytSW70luM1toLrulqq52I2iuuBmpcAZLB1YHb5u64SR5flxJP3U1bmbJV unbOLzY5f4hbmt6pWtGXsH+b6hQnJ9OyzXSRjkjthdLo/Wd50lW/ibJWPgefzNHLXfcdlzARnhRU 1N+ILWRwHT0xHn+5aVOWxNay6W+a6ur4qmoqXF8rQQCwnxj2VIw4g8LYUF1q6Ek0lTNAfPpvLf6K s3FbTfTXOrNEXCCa3GmfZqlvS1zow4teByD7KCLNu3qe0XeevpasudMSXRP5ZyewHhcbU3ivuTWx VtZUTszkNkkLhn9VLkWw9fX6Tbd7XWtln9P1fReMAjGcAoknGMJPiJ1W5jmSQ0Lg4YP91z++Vz2n t4tT2O5VFXT1QlbOSXRTgvatpoDZqq1jZZauKsEE7C5ojc3PI91GupbFWafvNVbLizoqad5Y7HIP 1CuqksS3N8RmqJI3sdTW8BwIyIyCM+3K0Gmd6tT2CsnlhnZUxzEudFUZcB9uVFoacnKXpuPujWon M/ERqEVPrR0lCzIw+MNPS79MrirZuRcrRrCpv9ojgpJKl3VLTtH904+eFwAbgZOVvdIWMagvlNbn VDKczu6Q9/bKGp7Stf8Af+4X2yVNruVmoZoJ4yx3cYyO4+oWj2+3pv2j6A0DGxV1CPyxTkno+gK9 euNir9pmxy3WKWOtp4m9cgYMODff6qIHM55yl3pNTdT2PiKufqTNfaaR1JM3pfTknp+4+6i+z61r bBquW92DFE50peIWuyzpJz0n3C5PoH1yjpxk84TfWjU3tP8AcfiQutZa5YGW6Knqns6fXikwQffG FxG3m6lz0fdquqZDDVxVbzJNE9uAXn/EMdlGwac+UAY5ySosTluHvbDrTTU1srbHCyU4dFOJeY3A 9xwtFtbvFdtDMfSOYK22v59B7sdJ+iivg/5kBufdXZMZPSbtxt8arVFrjo6GmdQx5/vGtdkEDBbj 2IOey2uj/iHqqGyx2/UNtbcjFwyUuwSPrkKvOceT3TyfqmzjKsbqr4ho7jp+pobVajSSSNLB1ODm dJ4cCMeyrpI4Oc4gAAnsF7bHbZrvdKagpSwT1Dwxhe7AyfcrtNUbR6p03a5LhXULHUsfLnRO6uke /wBkX05DTF5msN6pLjSgGamkDwHdj9FPOqviFdc7Rb3WqmlobrSvDi7qDmO4wRhVyLAOV02jNF3n V888Nkp2zSQtDnguxwU9Je00VW/lJedCVlmu1A+Otmjc31oiOkk89vutPsrvHRaKtj7fdbaZmhxd FPFgOGe4Oe6hq92euslzmoLpTvp6qI4cx4wfuPovBjnyrcrx4X0zjjJlcp7qY979e6c1z+FrbXR1 FNcoiWyOdjpkZjgH6hZbL7xz6HElvuUTquzyZPptOHMJ8hQ0RnHC3lr0pebrbKqut9BLPTUreqVz BnA98eVLbfazGYzUTZu/vJaNUaU/hFoo3elIcPbOwZZjBaWnPBynspvJYdJadbQXa3PbVREgVEDR /etPYO+oVduQOUxgHypf6utLKzagtest1bVdtD1LqG7SAiRtSAGvI7ffI4/RTpTVcVTqmhZebHUw 3drMMq2DqiHuA7xk+F+ftBXTUVVHPTyvimjcHNc04LSPKm+2/EfqamoYYaino6h8bQ31XMPU7Hk/ VatuV2zMJjNfDu/iC1TV6P3Gsl1oS0yxQfld2eOo5B+69su9mjK58V4EdRTXxkPS1xj6gD3LT9D7 qtWv9bXHWV0NXcncAksjBJDM98Z7D6Lleo+6uefLWmfH4+M7T3vtrnS2uLTQ3C2OmivMWGSRubwW HuM/Qre7R712qk0t/ANYMf6UAAgmY3PU32P1CrO1x7Lp6bRGpJ6eOeGzVz4pGh7HNhJDgexCnK3T fGSWJP3/ANwbBq5tFTWWnjf6B621XT0OGRgsI8hSNtPu1om1aOpaSdz6CqDA2eLpyHOAwXAj3VXa TTt2rauempqColqIP95G2MlzOccjwvcNG6iaf/iRXD/6A5TvZqa0lK36/tGh92Ki6WGY11jrAPWG MOYHHkD3IPP6qVXaz2tqdQs1C+u6bkS14eQeCO3HhVKpLJc6ueaKmoaiWSHiRrI3Es8c+y9MmmL6 xhLrZWtaPJhctcrbb9szDGST6T5rjdiyVO49huEL/XordL1GaP8AxMdwePcLY663P03Jr3S19oqw VNHSucJegfMwO84/VVgioKuaoEMMMss2SOhjSXcd+F6pLBeGMLzbqwNHJJhcrzvv+aYngxln/e0x /E9qqzanntFTY6+KrjaxzXBvBbznkKA8rORrh+bP6r5ntws553OSX4dMMJhvXy7faWqsdJrOhk1P 1C3dRy8HHQ7/AAuP0BVlt4NR6Q1hoOpoaPUFL+MgZ6sHzYDnNHb9VT2jpKioB9GKR+OD0tJx+y9L qGvHH4eXHt0OUwyuOW4ueMymqmr4dtyLdpavrLZez6NFXlrhUeI3j3+hUx2TVWidJV8gor7TzUtz lLpT1gmJ/JBOPBzhUncyVjy0gtIPIIIIX0eZ2D5g4ZGeRjIT1NM5YzK8qtrovWundIa1u9jNygmt Nyf+LgrI3gtY92csd+y9lj0/ttbrxVXM3WhrXyh3VFM9rhknPAPZU9jM0h+TqJ+gK+kgnH5sg/XO Vvnl3/WL4cbq/SQdSv0zV7rdVLmmsE1Qz1mt+URA8OAx4zz+qs1rSXTF+24m0/TagomdNOGQvdIO S0fLn74VIGxyOJIBJ88L7htS1vyudj9VmXWXKe27jLjxre6KgtsusKGC+1H4e3um9OaUHho7Z+2V bXcyCxag26ks9He6N0tPC0wu9RuHlg4HfyqRvc5rv6rL8XOBhkrg326imGXDLlFzwmePGuv24pbX Xa0oaa+1go6J0h65T2Dv8P25Vqd5KK36m26ko7bdqOSppGCVgErT19De3HuqRsLicg4XvFTUhnT6 r/bhxTHLhlyhljPJjxruNmtVUelNeUFzuAd+GBcx5H+EOGM/orPaytmi746q1BeJqS4Qmkb0Ma8F 7WjPIGc+c/oqQCN+e47r1CqqmxiMSvDcYwCVnC8ba35f+TGT6SJtlZ7Tc90YKN1yZTUMU75KeaTA 9ToOWjk9zhT58R9DBd9Fsrqatgc63O9V0YcCXNI6Tj7ZVOmNlaQ5pwQcg+y9L6+tfEY5KiQsIwWl xIK3M+OfOTtjLHlhML8LeaGuls1ztA2xUlyjo6ynhZTy+oQCwtIwcE8g4Xwi2705pnSlfPfbvNUS NLnCrhmczoDhho6Wnwf6qo9NV1VPI4wSOjJGCWuIyvrNc698bo5KmYxu7tLjg/osS6mm8ryyuVWq 26sNprdP0120JeTb7zGxsNYZHdTXHz1NP7hdZuXb7Vc9vpBqyrpzUwMw2thx8r8cHAPAJ8KkdJc6 ykc51LPJEXcHoeW5++FnUXu41Eb4p6qV0b+HNLyQfutcu91iYe9Oo2zu1vs+vrXXXfpdRxSkSEty ADxkj2XUfEhcdO3TUdBU6ZfTviNN0SmBoA6g44yB9FEIY9xyOyZY/s7OFzmP7XL7dbluSfT4ke6X lZ458piMk8d1pl8yEdK+pjdjsgRPwOFB8+lLC+3pu8grAsPkFB80wssJEZ7IpFGFn6bh4KfpuI5C uhgR9UdJ919fRcG9j+yPTd5Cg+XSljC+3puAyQhzCBlB8SEdlmWuz2P7JOYe5yERhhLsmljhAJlI J+EAhJHdAJoAyl5QMoKPKPKBIR2QgE0d0IDwkmj6oEE/5JJoBJBRlA0JZQgEk0IEmhCBIPKE1QvC AhAQMpJoQJCE0AhIpY8oGhLymgEkIQCE8pIAoR5TVUkIQgEIJ4QgEk0scIBHhNJECCjwjCAQjwj+ iAQUEIQCAjCEAhIfVM89kB3R5QjygPKEIQCPsgIVAjt2QUIAoQhAeEIQgPCEBCACfhLKCgMoKYS8 ogx7oKaPKBJgpdkZQPKMo8pIGEIHKaBZT7JDGUdkBlMpdwmCgCUsJpZyEAn4STQIoHZCaBFCCjwg EI8IQI90/CaR5QCeUJIGOySM+yM8IAITSQBQUJoEjyj3R4RRnKXlMBHhUGR7JceyYTwg3Vf3dx5W sPlbOsOQVrnd+FwVj5Xroces3jyvJhe2gA9Vv3/dFaq4Z/GvXjm7heyt5qn47ryT/mVg+KEIWkCY STCBpFNIoBdJoAB2qLcDz/fN/quaWzsNcbdc4KpoBdE8PwgvPqWaS2baVdVRuMNTHTkte3gg+6rv svf7rHrU1B9WpdOczuzknJ7lTbo/Udq3I0LNaoaoQVskJjdG4jIOO+FzmzmjBp691tFcXNZc4Xdj /jZ/hcPoVvc/HJ8uGsvyW/Cbw2CdkdX6OZOk+B1fZRdpvU/9pNyqtkD5xR0oaxsMwwY3g4dgfcD7 rsJNZ0FPq8afnaYqgMDyXYAd1dsLyU+lhQ7gTXenLOmsY0vY1uOW+frlc46WN3qezUt2MZlnfDUU 7ZJIHxv6XsOO498cLV7ZX2rv9pjqbgGuqYuuJzgMdWDjJHuvdqixVF0u1tmgkkijgDw5zHEEh2OC vXY7TSWaoMFGOlrmFzhnuc8lVPl7aeWiuk0hiLXVFJJ0uH+JpH+ird8VfOprUc9oif5qRNF3AR7s ajpnT9LnShzWF35sk+Fym/tnF93Cs1CJWRepER1OOMc8rv4bMc88f44+XeUwy/qQdkZpKzb2ibVP MrXRD5X8jBHZU/3Uoqeg11eoKOJsMDal/TG0YDefCuhYIKLQmkmirnbHTQR5y9wBOBnjP9FSrce6 U141hda+jcTBUTuewuGDglc8dcbL7dNZc59OV7IbxlBKXlYdmSYWI7IKo9dFkytH1X6AbewiXQNP F1BnVThvUewy3uqAUTgJmE9s91frRD2O23YY3B/+yntyD8iT3NMeT/W7Z7baTdpammhFQyeORzpO tpB78rhZtGWLUmrr0++2ueVwmIbMxpcP2C2fw+VBmsVV1y9b2zSNwTkjnsu/pyH0N2dQECva6XBY cHqxxn9V1yzuNyl+XGYy8ckE7mbHWuKwy3jSvWyalBkkppAQJGDk4zyCvfoXavRurdJ0VxpqaWGc tzI0uOSfIKllzq256Eq46jrkrzA9rmuGHdRacDC0WyFrqrRpBlLXROimBccO+/ZZsnCWeyZ253HX Uchqj4f9P11nmFieaW4sb1MJcXNLvYrQ7XbJtYTU6hY5k7HfK2M/lIPce60eqtwtRaG3Lu1JHUPj pJJ+v0ZW5b0O/wAQz/op/qas33beWptjhPJNH1sdEckE4PCzJ3p05ax5aZa2hji24rY2ymWNsZZ1 EYOMgYUMa02KoHaNF10+ZG17WiQxOJIk9wPYqYNTMkn2uqWxte54iy9uCXDsTlbm0uFx0hQyUL2S DpaeCMY4yt53/jxn9csf/kyv8QFpTY21X3RBqpjNTXZrD1Ek4DxnghY6D2k0tdbGJLuKmCtjcWSH JLHEHuCPCsZDTupxcC4MZHIxpbggZODlaevM1p0eKqxwNdU5aSxreoEdXzcfbKmOU42Wdt3ly3vp WjdTZuLSX4W70EslXYXvaKgNPzxDPcHyF29r2D0zdqCjuVvqp5KSZoJb1dsqSd34pbptXVCCP1ZZ Ws+Vg+vK9m3VLPRbbxU8jHMqGU2OnGCDg4V49Sxn8n7WX4Qnrb4d46eh/F6YqjIWOxJFIc8e4+y2 to+HmyttVPLda2eKdzR1EH5c/Rc7o/eW+0N7NkuropaaSf0XPmBD2AnHJU/a6vNzs2lqaqsdJHWy noaI3NLmkHzwnC3PhFvk44zOq7bp7DPslhfeNNVD66CEF00WMuDfce+FX4jDvorp6g1HryLR9TXP sFulpXwOMscJcHsaW8np+gVL6lwfO9zRgOcTj2WLLPbrjlt6bZK+GqjkYS17XAtcDyDlX9ho5b/t bFTTudLJUUoa49ycgKglkpJq2vhp6aN0k0jwGtaMklXwrKiptmzsk0D3wVUFJkEcFrgAr4985pjz 6/Hdq2brbL1elLUy9W2c11tP+9wMOi+v2Xb/AAu2H/Z5btablH+PGY6mklbwW5+Ug91KerJHT7I1 Ekx6ny0fU8+5IySou+EqlqIrrcp5I3tp5GNEbyOHEZzgrflx/wCP8n9TxZbzuH1HM7yW2O/bz09B fHMtvrRsjdMw9bec9Lv1/ktq74bnRV/TVXpraORoMM4YMF3secDxj3Wp+IwObur18jMUQaf1U/7g OLNnZMdxDFj9wr5v/kmP8Y/x/wD491Xe/wCxdTYL/QQ3K4sZZ6t/piuDeI3HsHDsMnyrLbdaNg0x pH+GB0MpDHNE7QMPBHlaLeUA7MTl3OIYjz9wvvsnK+q2hgc55e8xSDJOfdYuOsZl9tzO25Y/St2u doLvb9aU9DSCOeC4vc+GSPsMHLh+gK61vwz1zmhzb1FyM8xYI/mtPLpPcOg1LRVVHDVB5ldJSyep lrT38nAyP3U5xXm3arpqW1avFRZNTRjp+Vzo+o/5muHBB9irnNZaTx5W4bqqO5+2130DXxxXJolp Zh/dVLB8rj7fQrudgdudOa7tFzZdpJGXCB/ydEmCGkcHHnlbP4gKvVlnoP7PX10ddZnuDqWsdHl3 Hb5v83uua2a25vOqbdXXSxXj8BUU7vTDWktLuM8kHss548W/HnzlqNtbWR2m9UXG0uk9X8LM6Nr8 Y6h4K0YW61jHXwahroLw9z7hFKWTOc7qJcOM58rSZ4UrePp9Yhl+Crx/Djd6m8baMdW9EjqVzoY3 Ec9IHAVHIDmQBXT+F1hZtjUdXH9+9Me7E8nWNR5pzWVTUb8w1EFNBA6qk/A1LWN+WUAn5iPdWD1V dKm13yy01JSRSU9XN6czjHnpGRznx3VUdDgv3wpODxcST+6tLrLU1VadX6atsEUT4bhOY5C8ZLQP IXXzTfnzxnqOHjy4+Dx23uub1DQ02md1rJW2yBjBe3upqtmPlfgZDse66XUV4ltmsLJbIbfBJR17 nNkkcz8hB/ZcpuFSOZu5ouWOSQskncXxl2WggdwPBXZ3nUjLdrmz2aogbJFcGP8ATfjJY9p7/bCu tZet9MY53Kf+2gbpLTVr3QbVCCGCqrYTJE3AH94D83T9x4XmuGs32bXX8Hvtlpqe1SOwyu6T09J4 GTjA5XKbraJ1dedcCWyVwkjhYKmAOf0uhOcYB+4Xv2/19Lqm7S6O1taon1oY6CR3TkOc0c5+/dTK TH3NyxMMrn/LKhv4nNMWmyaqgrrD6QpbgwvkZE4FjZM84x2z7KFwOR4Ur/EBot2jdUNpIJ3zW+dn rUweclgzgtP291FBaSMDuueT14+lgvhQuLRqWpstRTQz01ZGZcvbksc32++VO+pL7bbDfnU1wscR tMTYzNXBoIhL8gdQ9sjuq7fCkD/2lwg//K0n+imneTWtsoIb/py5BkFRU0IdTy9ORITn5T+vZXxY 88tOXnzuOO45XV+1NLq7dMVFv9OK0PgjlmfAAWuPJxx2yPK6fXu2GntUWU2my+jT3m2Qt9AgAFzD 2DvcfVeT4WJXS6OubpXOcGzhjcnOGgdv5ldFt9Ho6TVVRJp+pqH3RrXiRr3EgDPI+mCry5byvwlx ywymE+ZtxPw66MttLBdjdKON17pJnRSwy4PyYGOD9fK6rT920vqm7Vun67T0NFOGvY5ksbW9RHfH vwuN1tTartG6Fx1Npajlnhpw1s7YxxIA0FzXD7eV1Niu+nt37dWQR0z7beoWiZsrOJIz2Dg4d/Zb y8fC9/LOPkuclntyu1umLLY91tTWapjhnpo6f1IBKAT0Z6uPfCl+rsukI6eknqbdQsiqXNbG8xAZ Lu2VTjU8d307reqpaqrlNxpZDH67HkEjHHPsQeysVvc8x7LUL2uIeI6chwOCDgcqY4zLz8DPO4eG Zq1bzW2ms+498pKGMRU7J8sY0YDQQDgfquHXtvFfU3GtfPWzPmmdwXyHJOPcrxBcLe3oxl127Lae 4UNr1pbqm6UMddSl/pvheAQerjOD5GVZ7ePT+i7HoaZ8tmihdVt6IJoYml8b8dTTzjyPdVJ0nk32 h4/9uz/zBWu+KHjb21Dz+IYP/clPF+3m430eb9fFynvbw7B2rS2qdGOiuFhpX19ud6Usro2kyA5I dn35W6h0ZoXXVovNJZrW2iqaWT0jOIwC14zgj3GQtJ8J/Fp1E4jj1owP/CpD0VcbTdqS/u0rTGhq Y5iyYvYOl0nPOAe3dXx3lN/1ny8sctT6cdtLpTR2oNLPbVWGnNfbHupah5aP7xzeerP1Sl290Trr TFy/gNAbdWU7i1swaAWuAyOAcEFe74eS4WjUskwHUa5xcB2zjldFb6ql/sNcq/QNJA6pJcX07z0j rH5gfrglauPdn9Jlubv04bTW3WkNO7eR3jUNEa8OY2WWRrSXNzwQAPAKwr9t9F680XV1mk6f8DUQ l3RIBg9TRnBHsVz23m5Ffptktu1hQVUmnqwOdC58RzHnJ6Rnu0/yXYalssztHm/bV176amfGXz0k TstkABycHs4Dup//AK/LW+uXwp5VxGGoczOcOLf2RTRiWYNJ5JAC+leSagl3LiSTn3XzgDhKCFit yrZUG2OhdMaKoa7U0MlSZulxqG546mggYH6hazXu2GlLpt3PqDRrXQmkD5T1ZPqtb3bg9ivltnuK KfTR07uJR1Dre6Ppp6iWI/M3H5ST7Dyuk1fY6yzadiuGh690umagA1FJkPaAcAuBPg+QtTKTusWW 3UR3s5s4y+yG66kjLLSGkRxk4MhORknxg84Wg11tXUaQ1VSU1QHTWqqqGNhnbx1NLgC0+xwrR6ut Mlx0zSUdHdoLQJAOvrA6ZQW4x4585+i8Opra5m2DILlUsuNRTGItqSAS4iQYcD74SZTKb+28JZlJ e0d7h7DUJtsNRpRj2TtkAkjeerLSRz+i+esNmNOad0F+PqDMauk9IzytfgPHWA448ZBUuax1pRaQ ltguuWUtW50ZlAz0ODcjj2K5zdC5/wAZ2MuVeAB+Ip2vGO3LxhWX9pjflnGe7Ptz1btPt3TWJl7k dUstr2te13WTw48fXyuP3a2v0padupNRackmcA5nSTJ1NILsH9VLlpitk20tiZfXiOiMNP1OPbqy 0tz9M4Vft5b7WW686n03QvYLJUTskETR8jHYDst8DldPFJZMqz5cuGdxQjM3pkeO4BXU7X2Gm1Jr K126uLxTTyhknQcHC5pwy52e+eVIWxLMbkWLHmoavD587j47Y9Xgx5ZaqT9d7CGmu9sZpx5NFUuE UrpXZMZ5PV/QL06v2Ht9HS2SG1zPbWVVQIZXSOyB8pJx+ymXVetrZp+8i33JwjmdSmqgJJxI4Ejp +h4/mvtfp21dZpaYDDZaoSAe3904rvjdybcsMble50iS4bO6CtMkNLdbvNT1b2NPQ5+Dk/8Av58L QX7Ziz2LWdpjr6+Runa8mNsuQHiTpJDSfYnHK9XxHvc3cW3BjiMUsB49/WP+i7H4hD/8LuliO4ro yP2CuVuOfH+bbw8XLHHL7ungm+HzTDJI4XXWpbNMHekx2PmIGeFFdt2uhpNx4tPaqqTR00vUIZwO JT/hAPYZU2761k9CNHy0kr4ZRXtAcw4ODgEfzXh+ILAumjy0D1XVrWh3n8zV1wx5XV+tsZY2a/7a e4bC6UoKiGGrv8tM+Y9MbZOn5z7Dsow3w21otBzUAoqqSoZUtdn1AAQQVafVthtF5ulIbk5j54op jFC7u7IGXD6jAKp7uZrW5akpaCjuXQ91B1MbN/jc0nHze/but444e79PLzzt1PtG7wA44918yvo7 z9SsCOCvO9FYhNCEDx7pBMIQJCaSA7o88oTQIoQhAFGUIwgaSEIAITwl4QCEZQgE+ySZQLyhAQgA g90IQJBTxgIVCCEFHdFCEykiGhJCA+qB3QhAZQfohHhAApJ+EBAJJ4SCAQhCAQgo8qqXdNCPsgSE HshENCSZQJCAmgXlCCmUC8oQeyO3ZAeUeE0YQIIR5TwgSCjHKPKAQEI7IAoQgoBBQEFAIQhUCPKA goBCO6EAnhJM/RAJJ/shEBR2QUE8IBLymhAICYQgSEeEIBBKMZTQJHlHZB78IH3CQ7cIATQJM9kH kJIGhJPugQ7YQE0kAPqhHCMIAITSQCPCPHCEAmRnukU0CR2CPCAgPCEIH1QHlCEIQIQhFHZHKEZQ bSeTLvovITys3O74XzXFoZwvZbz/AH7SF4l7bb/vcoNROczyf8x/qvNP3HK9E3+/k/5j/Veeb8ys K+SEIWkCYSTCBpFCECWTDh2VithZ6CW41kVNTs65ZHdLR9UH2ttxrLfMJ6Cpmp5fDo3FpC2b9U32 SrbVyXSsdVAdIlMzurHtlT5oPZG2VFnDr9G90jhkuacFp+i+mltotH3Sur6CnrH1YiJaJOrDmHnL SPcIm1equ/XWsrW1dVXVMtUwANlfIS4Y7craM1zqYGMm9XAlnDCZjlv2UzWDZOjpdW1dvufqT0II MUnIOD7rsm7I6Sp7m2lm9X+9BLMk8fRDauUe5Grm8C/XA/8A0Ur5O3B1UZ2yuvlf6jc4d6pyFZaf ZXRDKxlHK8xVMoyxrnEF32Xnm+H7TknrUwkmjlIyyQHlv6eVUVddqa7uuxuRrqj8eTn1w8h2fusr vqq9XeoinuVxqKiaL8j3u5b9ip30tsZSQ3yttmovVeM5p5mHDXs9x9fcLkNTbd2bR241ParxUumt FUwPjk7FmTjDvp9Uxlu9JbOto9umttQ3S2ChuF1qqikAAEcj+oDHZcs45Jyp83T2R/hVjF90nKa2 ha3qliHLmt/zD3UByDBRqfTBJMpFRQsljjhNB9IvK7XTm5GqNP291DbbnNHSkY9MkEAfTK4+ijEk 7GOH5iArDVGwMFVo3+K2uvc2rbD6pZIPldgZwrGbZJ2iLT2vNQadrJKm0V8sD5SXPAxhxP0W3pN2 dV0t1qLjT3ORlTPgScAtdjzjtldptzsrTav0y6tdWyU9VlwAxluRwoj1TYanTt9rbVWdLpqaQsLm 9nY8hXtOq7gb46zFQKj+Jf3oHST6bcEexX0pt9dZUpkMde0h5Li10YIBPsoq6He4KRjcR4UXUdTr jW901nWQVd5fFJPCwsa9jA049jhbLRG52pNIU7obTWuFO7n0pB1N/QHsuFbG4ErpdCWOk1BqKnt9 wqzSQzHpEuM/N4CDtxvxq4VMk7J4AZGhrm+kOl2PovBYN5NT2OSq/BzRejUPMjoHM+RpJ/wjwuj3 H2Gq9M6clvFurhWQQjqkYQAen3ChFzT4zkK2dJJNpXrN8tU1lpmt88kLoZM4IbhzPsV8dJ726p05 Sup4KhlRTk5DZx1dJ+hUWdBJSDSDhF1E1R/EFqVr6hroqN8E4+aIs+UH3C+1u+IrU9HA2H0aSVje B1s5x7d1B4bwkAc+cqJxjodY6kdqTUNRdpIIqaafBeyLgF3k/qpD0XvxqPTtojt8ghrYIhhhnBLm j2zlQ30EIDeDyVV0m3VPxAXy92iaiipaejdIOn1ocg48jv5ChKV/XI5x7k5SIHusTyose+xXOps9 zp6+heWVEDxIx3sQptuHxC3G56dntVfa6YsniMbnxktOSO6gVozjCkHb3a6+61ifNQNZDAPyyS5w 8+wVxuruJlJlNX06iLfK4v0VLpyuoo54TEYmzZw4DHC8m1289x0RQvoPwkFZR9RfGH8OjJ74Psue 3B2w1BodsUl1gBp5Ths8eS3PsfZcIWnODnC1c7cePwzMZMrlPdSzuvupBr6Cjc+0RUldTP6hUMfk ubj8p4W6qt+Km46Efp+4W9rpTEI21DH47YwSP0UF4A9zlDWjqzys77lakk9Jyv8AvlLftAS6euFu HrGIMFRG/GcdstWp2m3iuOheulljNba35Jp3Ox0n3CiUN54yussu3+orzYKq8W+gklpaZvW7j5nN 8lo84TlbOLPGS3L5qVtbfEDU3amporJA+gMTw52SCOMFuPZbyj+I231VJAb3p6OorGNAc8EckeRk cKsLhg85S4znlRrSa95N4Y9b2mO30VG+np+C5kmHYI7EFcLoLca+6HmndZJwxk3+8jeMtdjzhcd+ 6xP6n9FbeU1UxwmO9fLZanvM9/vdVdKprGz1Lut4aMDP0Wqxys3AcJNcR7/spba1JqdMoflerSbd b96fsel6Sgr7VLFUxxiOQwYDX446se6q2Bn3ygkD3SFm08WncfStk3Tqr9Q22Sa1VcYLo3gB8Mmc 9Tf1UnV2/GhrhU0tTVW+qknpndcTnNALD9Cqc5x2ymC7yrbbd/LHCamPxFqqjfrT9VrCKoraB9Rb oh1QyhnTJC/278/cLX623msdfrHTl9tcc72297vVieMEtPkFVlDyEw89lrHOyn44thet/bTFqe23 O1MklpC0w1cLwA4NzkEH3C2lPuxtnHe3XdlLNFXvPUZxD8xKp9E10kjWRt6nOIa0DuSfC61+3+q4 2Fz7HXhoGSfSJGEuW9JwkTHrKmr98rzUTaaFM6G2/I10jixzmOyQcc/Vcz/8DzrMH/dUh/8Ao2P9 Fx2hHavoJ6ir0pHcA5mI53UzCQPo4Ls/7V7qxMe98l5EbRkn0SQAP0S3aT9Y7nba2wbNVElTrmiM T6g4payH5wDjDmH7jlc38QmqtJ6sipLpYKp7rnG4RzNe3HVH4/UFcXdr3rXW9pdBO2vudHHICemE vDXD7DgrlajSt8jY98lrrQGgl2YHcBO56WTl7TR8PW5tj0vY7lbL3K6nfI8SxSYJa7wRx2Wq2p13 aNM7oV9dc5z/AA+p9RgmYMhuTkHHsohorDda6AzUVBUzQh3SXxRlwz7cLOfT93pmOfPb6tjWjLi6 JwACzLZhcJ8lxl8nO34Wotu8+naHW1yp6ioa+zVzWyNqWAnof04II9jhevTGqdrtK1lVW2W4Bk8z CHAkkHzjtxyqbu6gcFIvdnuf3WrnbT8c1EpXzVVkvm7Lbzc4JHWmWZpqGNdyBjBIx38FTzrnVGgt UaEmssV+ijDIQIHEHhzR8uQqeUlHU1JcaeGSTp/N0NLsfsvvNbq6GIyTU8rIx/icwgD9VJbM/wAk 9rcJcOF9PFUcyu5BwTz7rEDheiGinnLjDE9/T36Wk4+6zNtqyCfSfx7MK5/LTqNpZLFFrW3u1RK6 G2hx6pASA12PlJ+mVZPee/aR1ZoWWlo79SPrKUCaANfkOc0dv1Cp+yGRzg1jS4n2C+zmTNbg/wAl rD9cuU9pl+2PGrY7D6j0ZYdIMe67xU9bUcVUMz+Q9pPI+mCFv7VqHROirZe6u13qGs/Ev9d8DZWl +eeG/uqYRtmI4OCvoBP2f/RMZxmouf7XdXG2u1Foy26dqX0N7gZLWudLNDUPDXNk5zwfoR+y0ux2 rbFRWe/2+tudNBUmqke1kr+nraRgEE91VE+rk9BAWH9805JwVcv2mv8A2zjNXa3tr1FpDXeghYbp cYbbUUhbGTK5oILTw5pPgrZ2+76T290DW0dLeI6+HL3n03Nc8l4x2BVKRUTMf8ruc85K+7KubqwX EAjnlT5lrXerHRVukb5M4TNtFwEbz1McYHAOB5BH6LCDSV8ppBLNaLgGgg5dA4BSfYN/9QW61UtF JS0E4gjbEHvBBIAwCcH2WzPxF3thGbZbXt8tHUtXu7Zl10kKok0zuZoK1xm5QWyrpXtEjJC1skb2 t6XAg+D7r111wsGi9thY3XeCrY7qia9rw4jqOcuA7BVO1HeZLvf7hcoYmUxq5TL6UZPSzPgLVST1 DwQ9xP3JU9E97Wn+Ie90FRoiwuoK2CbMwP8AdyAnHpn2/RbLTt9t9RsRTB1fA6aJjWyNMg6gRICe O/ZVEdLUOja17yWD8oJOAs4pqmKN0bXODHcloJwVL3Mf46Y3jb/VoficuVLUWawy0tRFNGZZOY3B w5Z9PutxNUUVy+HqjpmV0DWyQQQvf1A9BL2g558KpEs9XJG1hkc5jeQ0kkBfIVtVHE6Fsj2xOPzM yQ0/omV3ljl9GN443H7q8eotL01220j0zT3WmaWRRxtn6gQekg57/RcHuxpG1WTZ6Sltwjq6tk8T 3zgh73yEgE578+yq2LzWx/lmlAHtIVstPawrrRd6StGJxBK2T0pT1Nfg5wVvDyXHU+I55+OZ235r Wz26cPd/dSNyfLSF3uyUX4LcOySVP93GJwC9/A+nJUix/ELa3DJ0tSNB/wAPBH9AvPd99bFcrZVU cmlaaJs0bmdTC3gkcH8o7HC8vl8X5MLi9Hj8l8d293xPVDG60spEgH+xgZz/APNCpW1Le7fabfo+ uramOOlbMwF+cgB0RAP2yVR65XSprZA+omklcBgF7iSB7cpy3uulpI6eWolfDH+WNzyQPsFvHDWU y+ofksxmMXD3Q25qdZ6no7tQ3GlipfQiaC456sPLsjn2K++7NDBqK4aZ03BWQx18c4qC15x8jW5z 9c4VQINU3WGFscVbUMY0YDRK4DC+D7/cX1UdUauUVEYwyTrPUB9D+q3bu8r9aZmdkknxdr3610nF qWpsTqtw/C0MjppMOwchvy4/UBR5revo9wdeWSzWOojdNbZTUve5w6XBuCQPORjsqwxayvsYwy5V TD7tlcP9Vr6W9VlLXNq6epliqmkkSseWuGe/IWsc7O//AEzlbV2tz9I3bUl3sdXZKoU7aZzxNI2T pcGOxnHvwCP1UIfErpe16eFggtsTGOFO6OR4HLyD3P15Kisa6v8A3F1rOoefWdn98rV3zUVzvXpi 41k1SWcNMry4j910x8v/AO18TTz/AIdXeP21D+CfuvmVk48+FiuL0WljhCPojCIAOE0kBAITzlJA BNJBQBT8JIQCaB2SQpoPZJHlAJpJoAIQhAkFCaBI8poQCWE0eVQJITwgQ7oCYRhAu6SySxygXlNC ENjwknhGECR5TSQ2E/skhAIT8oQIIQhAJJ5QgSE0KqSEYQgAhNJAIRhP6ohHgJoHZGEB5QhCAQhP CBY5R54RjlBQJHdA7coKACEdkYQCEYwlhA0IQFYDyl5TKAgXlCaAgEI8oQCPKaB3QIoTSx7ImgUl llI+6BZTwjCEDQjwhDQS8phCAQO6MIQPwkhNAkJ4KSA7IRhCAIR2CaSA+yEfVCBdk0HhIcIGkjyj ygMYR2Qg9kAhCSB+ED6oQgaXlCMoBCD2QihCMJoEeyXPuEyhB63eVgs3dlhhcWqS91sGZfpheMAF e62cT5xxhQaKU/3rj7klfCb83dfUEuAyvlN+ZbgwCSYQVUJNJCBpIQgF2O1wzrG2ecSgrjltNPXK W03OnrIMepE4OAPlBd7cyR9PtVcJYXFkjYQQ5pwQc91AmwlfdYdV9dO0zxvx6xcefvn3Uu6S1bY9 zdD1FlqqoUlXJF0PYXAEH3Ge/K8ez1gt2mbpV2yqqYf4pE7qDg8Ykb/hI/6Le5wk+XGY3nbfSZnO 6ofxLYszNjJ6fJ47fyUSbcX59/19d6h0csDQ9rfQec+m4Eh37rqo9wKNmuprBVOjgezp6XOeMSZ8 hemjsdDQa2qrnT1EQfWBrnsLgOR5HusR1e7WVuoLjDO2okDa6CCSWHDul4IBIIP3C8O1l2rbxp2C puT+uoaz03OIwTjjleu/6cgvN8pa2olBjijLC0PxnJ7rZWyno7dUvp6X0429DT0g4BPkqs9vvb7h R3Z8whLXT0cro3tz8zSCqy/FM4jWtHjj/ZQR+5Ulbe3Onp9yNTUk9Qxs76tzmtc7Bc36LmN67NSX vdK101dUxwwyU7Q0k4DuTwCumFmNyjllLbjUl7TZk2/pRIepvotBDuQeFSzcSGODWN3ZC1rIxUv6 WtGAOVdauuFs0Bo7rqJWNgbHhjOr82B2B+qpBq+5Q3W/19bAxzIp5XSNa48gE9lnDrx2X3tcpb5+ U9aaMpFB7pLDuPCySRnIQbG1Y/HQj/jH9V+gWl4YpNDRRTvDIpIOlzj/AIQW8lfn1bZAyrhc44Ac M5+6vxY6mKo2yfJTPbIw0bxlpz/gVm9zTn5esXp26sNBY7c6C1V8NZTFxd1MOcZK5Gh0rbLvqC9S 3jT34xv4l/RM0AuIz5BX0+Hepjm0kWxytfKx7muaDkjldvHMyvtF0htczP4gx8rcNdhzXFXlZuM8 fVRBu1s7Zf7PSXvTtJ+Cq6QepJTyDDZWDkjHgra6E0Bo7VelKG5NtMcFT0guBAwT5yu/udJW3PQN VbXudJdDTljmvOXEkLx7SWWpsujoaKtZ0zBpGPrnsmWpjLPdZmeXPKWdOW1PstpK/wBonZZ4mUVw jHyTREFvV7Ox4Wo202dt1npTUaijjfUNPckANIPglRnqLVeo9Bbl3KmdVVNJTy1HqviJ+V7HHuAr IVc7dV7bl9lmZUulaHAsPnIP7q8dZcdt8rx5a7Z7hwwDbmphjJfTu6Y/mGDguAwov17slZp9INrr DA6G6BoLQ08SHyCFJ+roZqnbiWGnic+aINL4wMuGCCeP0W4ts8N201RT0E7HRtLXE57YOSD7Fayv /HjP65z/AHyqGdO7J2K66DzXUr6W7MhJfI0nqa/B8I0Jtdpeq09D/HLPOatmWvmjaXB+DjPHZTi8 ClprlLLLGIpm9THF2B2K1F0dVR6Qgn06T64dGXeic5bn5uPssR02rxu7tDbtJy0V/tofNYjKwVVM 44cwE92n2PspBt2yei7tRUd0ooZG0srAXRF+ByO+fouq3poau/7aSxUEbp55CzIaORzzn2wtppu3 VMG2TaF0ZFU2kLekdy7o4wt2TjK5c8t5fxFOt/h9tE9Eyq0vUGFzH9MjJCXNc3yR9ltaPYXSVLaq d1yhqDMWgOkjLj1H3wOyjPQ26V9s2oW2K61ZZbxUGGVk4yY+cHk9lYzcC436n0vR1GjwJ6lxbjpa Hgtws4zllxjeWfDHlYgfdzYqjtmnH3vSb5XsgBdNBJnJb7jPOVW5ww4hXP1s7cRmiKuskqaOpjdA 4zUwg6HhuOcc8kKmcxBkPuUskn9a8eVtu/R07Q5w8c91fPYmwOs239NCZI5mSM9RkjDkHq5VDaf8 7ce6vbsHR11FtvBTV7Hsl6S5rXex5GFme2s+sbXH3LUVXfam7bd6poj+NmcTRVHGCzu3v/UL4yfD 7piCnjdX1tXBK8cg8jPnnC4LS90qHb905u078x1L4m+s7lo/wjlWC3U1FqGxMtx03b213qucJQ6M vDBxg8dl0zwv5LjHn8fk148csvlXPdfZOTSkFNdLTO+utD3BsuB88eT/ADXb2vYXSt0oKeSC7VMM szARHJgEOI9iFIkdTq2skoodU0NqNlqntEjoCcsJ/LkHtyuivNxqLXqqx26Cli/h8+WyTPZnoI/K AfCzMbXS+TWtqnVm2MWmtxYLJq6qNNa5yRFWs/K8f4Sfb6+ytlpHT1DZdE/w+jrIpaVsTmNqW4x0 kdyoZ+LmJ/4izydJ6AHDq8Z9lI21DnVeylM2NwkkdTPb3zzjGFc5MMsJPlnHO+Tx53XpB0+ytNUb iQWxl0jmttbG+WOopyCWuH+Ej9VjNsQINxYdOy3J34WanM7JwwF3HghdptXoHUGktwqKtvDG/gJ2 vbHIx/U0OOCAfY4Uk3aF53rtExaRCKF7S4jjq6jgZW7JbkYXKTHau1XsvT27ceLTN0uwhgqYfVpq kNHzHsGke/ddVTfDORNUNq7w6IMcPTkEY6XNPb9V0m9NJUz7waYfBDI9jBGXFrScAPOcrrt/9R3H TWlKSttcnQ4SgOBblrhjsQszDlZIt8nHHeUV9uOwt9pNYRWjIkpZfmZVgcFmeePcey65/wANMQkE Q1JGJf8AKWNB/bK7/aHdR24F7p6Sqo2U1VSROeS1+Q/Iwcey2OtNeS2nWzLLBpyK4VEgYY5nODcl 3jOFnHG5b01lnxsl+VeJdjNQQ62FimH9w7D21bW5aWZxkD3HkLsZPhkqeosZqCnL/wDK6MA/tld/ qy+66uN4trLbpySguVETO0mcPjnYeCzx+vK3JfZda1sIqXVlk1RGzBYCWFrx/J3Ksk+UueXxFP8A Xuirnoq+vtt1iw4cxygfLI33CmLa7abS+tNsJK51Q+O9R+o1z2yZ6XDluWrmN+q3VbbjT2fV7mTf hnOfTVIiA9Vp4yD/AKL3aA2uv9z2/fqTT96MMj2vcaVpLOrp8ZB5OPcKXq6bxu5tCFfAaaqlhcfm jeWn64OF8Mr613WamQy59QuPVnvnyvkOVluPTQvMczHtJDmnIPkEK+WjtSVk+zVNe5+h9Yykc7qI /MWjjP7KhlIMys+6uxpHMPw6R9QIIoZMj91vxTfkxjj/AJNuPiys9o++HnVNXW7pXKNkcMNLdg+e eFjcND29i327qcZrxcm7lxWYULDZ5KT1HT+l2fzx1Kt3wwg/9qMJ8fh5R+qsU/U9c3dyPTo9M0D6 L1+WfMHD6+yuc/bInrFz2mootPb0XCxW2JsdtuFJ+OdDj5WSA4Jb7ZXSMvNXLuHPYpqKI2z8N6gk MXJJHbPZcpbadtL8Q8jIi8xm3lwD3E9JPcD2H0Wl3a3huejdWy2+lpKaaFrGuBkHPI5GVq427053 P/WfLe6DbDYt1b5piip422uWEVzWObnoeeDj6FdFQXo3LXd101W2uEUMUHW2VzP94COQoh+Ha+1O pNzLjcKwkyGkcG5dnpb1ZDc/RS5Y9VVNw3OvGnpqeEU9JAJWTNB6z1eCVMcsbzsnS5TLHhLe1QN6 7DSac3AudBbmdFK1wexp/wAIIzhcIw88+6kr4gYPwu5FyhdK+XpI6XPOTjHbKjNucBa/yMZM+mv8 bK5eOWrg/DLbbQNv6isoYYZ7yS9szHEEnHLQR4XQ6X1FQaxmuli1PYaa2f3ZYY5QB6nh2CQM47qB trLRrbTlnbrTT8LZLc3Pqxh+fVY0/MC3/VTZZK60716WrqaqozQXWmPUJIjywuHyuDhyfqucnrbp le9xzeylFZtOaz1va5TDJDTOaYA8guexuT8vvjKmm5tsFG2j/F0tHGK13pxvdG0AkjIBP1VJZ6Kr set3UNRK51TS1ghfIHHLuRk/qFYr4nHOj25tZYSHCdhBHcfKUn7ef8Z5LrwzNDFmrqbSu9c7o6OG WmbXvpvRcAWhrzj/AFU7/EAbJatBSU8tohc+vzFFKxgDoXgZa738KqGlJXz6otr5HOe91ZGSSSST 1DlWc+KnP9k7MO3+1E/+4K54W5ea79N5SY+HH7e3YCa3ai0N6NdaKJ01tP4f1HRNPWO4P3XvobXp zcbTF4ppbJDQvgeYg9jAHNcAcOafuFovhWJbpW8kc/7QO/2XbaGvlPqawXl9vo2W58UronGEAdTg DyQseDLlj39r5pq3X00u0NPY7zocGoslEZraXUj3GJp9ToGert5BXwl0zpncrRFc+GzxWuePPpyR tHU1waHA8dxys/h4e5mi7vJKA9wrZS4f5sNC4bUG+9BQ2atorFafwFWSQOkN6M5wcgfRdNd2T7Zv VVnuUPoVLo88tcWn9CsKUepMG5AyQEqqZ1RUvld3c4n9yiAEvw3k5CKuVR6X0ho3bagrayxtukLw yWSVsbXyDqaMknyAV5b9ozSuvduZLpp+3R26aAvdE5jAHEt7h2O/C5DbnWl80PYorTrWzVU9gq2l tO6Vn5cjPTzw5pHhdXr6wNuGihqLb2pkp6J0RdPRQEtZIAME9I/xDsffCs+GL1d1sKjSejNDaIoa m4WIXSBxBfOImueOoZBcfbPHdajXGitJXzbgam09b2UYpcz+m1oBka12HMdjPstRobXNz0rZv4Hr 6zVc9knb00z5Ys8dy3nhwxyFst0dNtp9Fu1Doaumi0/LH6lTRRSkRFp4Lmt7Z9x9FmXeWmrv3HSw 2LQEuhBqt2nIG0pi9V8YaOoc4I9u65rcPQuk59CUurLLQ/hIKfomkha3AmiLwC0+x+q63SVVRW3Y elqLvTfiqGOnJmhH+Jpfz/VfHc6WCp2MqZ7G1tPbnU7HCFzcnoLxwOeMLPgtzmO/lry/rcp9M5tH 7djTNPqKpskMVFM2N5OSOgPIAyO3BKh7fXamCwxfx/Tpa6yz4JY05ERPbH0KlPV/Hw3Rt/zUUA/9 01fDcjj4cqXq7/hafv8Adq7+LDlcZflfLOMy18VTl46XOCwPdfWq/wB67t3XxXKztmBPJ90spEor LKAsR24TQZJOKSSDLPKPKxR5RGRKWMlJCBFJMpd0CQn5R4QAHKAmEkAl9k+ySARj2QUIA+Ed00fo gXlCCUfdAIITKXhAdkBHnCYHuhok0ihDQTCQTV0aH2QgIQAQhCbB5R5QOyE2BCAUZwUNBAQhDQQU IwgWE0I8IEhP3SHZAIQU+6DHHCEyjHKBJpFAQCEIQCE0lVHlIpjugBEJNH2R5QASTSwgaOxQhAJ+ 6EeEAEDkpBPKAykU0kCwgBGPumgRCfdP3QgRGUYTQECwlhZFCoxxyhNNNjFCflCbCTQmmwkFMICB BGcJ8YWJQMpeUFCBoSTHZAJ90gE/KAKWOUx3QiDCEFNAk0I8oBLGUz3SQHlJPyg90B9EihCAQjKE AhBSQMpHuhCACEBHlAJJoQASQmEAUIQENBCM/RIdkUxlLumgDCASx9EZTQewHIWJ4TaUHkri0xWw tvDj7YK8C99v56h24KDnmD5cL5TfmX0YflWEw5ytQr5pJg4SVQIQhAIQhALOP8w74WC3OmbRNebp DR0+PUkOBlB5o55IH9Ub3sPu04K+wrKgy+oZpRJ/m6zn91anSu0enKDT5fqGnjkaGZfI84P6FfPQ Wg9A3819JRRmqhY5zQZCA9v0z9PdE2q46rqHSCR8sjpB/iLsn916W3a4DH+11PHb+8PH81ZvTOzN ooNT3CCupH1NB1D0TIMkNP8A09109LtfomO7uoW0LZMjjsS13sSrKioYvt28V9YMf/NXf9Vg6+XX 1Mmvqw8efVdn+quFVbcbfR3NltqKMQVUjQ5mRgOB+qxn2R0hUCej/CyRu6QWyA/MM5Q2psbhWGf1 zUTevnPqdR6v3RU3KtqpGPqameV7PyukeSR9iVaHSeyNrornXW/UEAqo3OJgm7Zb4/VcFqDR+mdF bostV0bJUWiaJr2l3eMuPY+44Q2hytvFxq6cQ1VbUzQt7MfIXAfoVrJHfqrGbsbKUcVgGoNEudNA 1vXLT5zlvu37KukjS04III4IPhLOtrLPT5EJFZErE57hRR4TKAjzyg+kfg+V0dq1ff7ZQupaC6Vc NM4EGJkhDSPbC5+mifLK1keS4nAHurD7VbIw3W3ir1G17WyDLWNOC0IVC1l1TebLK+a1V9TSvecu MTyMr102vNRUtdLWU90q46mU5ke15BcfqrAag2B05crZWt0rcHC50+R0ueXDqH+Fw8Z91We62mst ldPR1sDoqiF5Y9mOxCI6b/tS1d64n/jNZ6uMdXXzhfWm3W1hAHiG91bQ5xcR1ZGfdcP6T84xjH0Q YZAM4JH2Qmm31Nqe66lqo6q8VT6qdjelr39wPZe/S2vNQ6XjdHZblPTxvOSxpy39iuYEb8YIx+iY jdn/AN5FSBHu9rFtTJO28TiSQYf2w79F5LRufqi0uqBb7lLE2ocXyMAHSSe/HZcRh2cePK7vaLR9 FrHU38NuFQ+njMZcHMIBJyqzqMq7dXVVba5bfV3OWWlk7sIHH2KNN7paq0/TGntl0mZTnkMd8wH2 yvXvLtlNt9c6drKltVQ1OfTfjDmkdwQtrsxtpaNf088dRc5aavid/umgYLfBCtnH2k1fTXs3p1nG Z8XI9M/529AIPuce6+9LvrrWmgbFHcg5rRgdcYOFrN39uanb6+R0rqhtTSzt6opMYd9QQo9DHZ+i WWe0nG+m21Hf6u/3qoulwLHVc5zI5jQ3J98LtdKbyas05bY6Ciruqmj/ACtlb19I9uVGvScfVd1t Ro2i1pfHW2suP4KQszFluQ8+QpppstV7yao1HbH0NfUsETvMbA0j9Qoveep2fdSxvBtBXbf01PWG qZVUUzujqxhzT/0UTkY7q2X5MbL6NhLDlTDpjfrVdltUFC18M8cLeljpW5dj2yofb7KR9p9s5twn VsdPXNpX0waRluerKjTS611pWaqv/wDGKuOGCs6WtLoB09RHZx+v1Xf2L4hdU2y2w0kgp6sRDpbJ K3LiPqVGmt9L1ukdQ1NouPSZocHqb2c09iuec0+Oyve+2JqxLWr98NQakpY4JfRpQx3UTT5HV7Z+ 2FuaD4iNQRWplHW09JVhrej1JG/MeO/3+qgrGOUIuol7WW89w1ZpOSyXWippBkGOoOethB4IPutZ tru1e9DerHQvbPRycmnlyW59x7KNG91m1hz5UJ16THq/fS/X9tOYGtoHQuDv7lxAOORx9Fv4viSu slubBXWulmnDOn1wSHZ9/uq/FvHlLpGfKGk/S/EVcZzRTTWujfW03AmIPzA/mBH1WWr9/wBuqNP1 VquNhp3wTsLc9ZBYccEe2FX/AAPGUYHHJSXXoslmq32lNUXDTF7p7laZ3RVELsgg8EeQfcFT5D8S 0cjGPrNPQPqQBl4cDk+/bhVmLR47oDQPfKQs2nLUm/t4uOoqK429ppIaYhwgLuoE9nc+xHhdbH8S lDIWy1WmonVAxmRrxnP6hVfOPqgYIxyhpJe8W59Rr+ugPo+jSQfNHG4Aua498H2+i12jN0dSaRtc 1vtlZihlJLoZGhwGRzjPZcGSAfKPzDHKpJrqPpWSmpqZJiAC9xcQO3K+YPCyZG55AAJPYDuVv7to 69WmyUl1rqGSKhqSRHIfceD7FNbXbT2+pNLVwztaHGJ4eA4ZBIOeVae2/ERp11hjoa2xSsa6Pplj jLegkjnA8AqqAGO6y5xnwkuu0smU1U87Y7q2DRmpL1I21PkttVN6tK/j1YPdv1BUin4gdGuuTbg6 z1P40M6BPhvUG+yqADgpgnuVLd21ePUi0Gnd+7PFqavr7vanSucemmqIg0SBnbB/RcXvzrnTGthQ 1tlpqiG5scWzOeAA9mOP1BUP22jnuFZDS0kZknmcGRsHcuPYLr6nbHV1NTyzS2GuayJpe89GcAd+ FZazxn/0SBsPuhYNFW+op7zb3OqvUL46qIDqc1wGWn7YUkxb3aDguc90p6GrjuMzOl0vpjLhjgHl VioNH32vtMlzoLXU1FCwuDpo2EhvSMn9l8bHpq7XyaWK00VRWSRtD3tiaXFoPGSpvRcZb2925Opj qzVNRdHRtY6Tg44DseceOFyoOCD3XUUehdR1kb5YLNWvYyR0TiITw8dwfqF471pS72SOOS522rpG SHDXTRloJ9hlayyuV3THGYTUTDsfvDRaes0undTQufaXB3pyRty5vV3BHkFSDZd0dt9L0ta7TUL6 WeZn/wAiJa5w7ZGVVC1WutuVbHSW+mlqKl+emOJpc44GTwtncNKXygpnVVZa62CnbjqkkhcGjPue ym/g1PbrbNrC1VW6R1BqKhMlvnndLLCx2ekkYDh74PKmfdDcTQes9GVNrZXTMqWM66ZzoyMPaOM/ Twq10elL3V0rKmntdbLTyDLZI4HOa4duCvnW6du9FTOqKq31cUDSA6R8Tg1ufcpMry5/JcZceN9O g2nutitetqKr1PG99vZk5bz0Px8rsfQqdd5Nf6G1jomelp7i/wDiEGJaT5CMvHg+ORwq1U+m7xNC 2aC21kkTx1NcyBxBHvkJ/wBn7vh3/o6s+UEu/uXcDzlPna3uaWa2g3I0Hp7R9PSvqJKOse0CpY5p d1PHd2R75Wzg3J0FpSxXL+ztQ6eWd5lMBJBe498EjhVHpaOqqZRHTRSSvIyGxtLj+wX0qqCupB/t ME0X/wA8YW/1WZOPUW3ftbbbfcTQFn0rHAy4fhnzZfURSZJDzwf3VYdzP4Y3V1y/gVQKi2uk64X/ AEIzj9CtJFSVU0YfDHI5pOA4NJBPkLGpttXEwvlgla3uS5hAVHhPZZ0knpzhx8EH9lg4YOEgEXS2 9DrfRG4Ggbfb9TXA22qpegOZ1YIc0YDgcEYIXtumudHaT29mtFjuLa9hD2NDXfMC7z9eVUiGnqCw Pax3SexwcL7PgmLerx788KzKzX8ZmEmVynta+fVuhNxNH2yLUFzFuqKZ2TF19L2uDcE9u2Cnq7Vu jrRtq3TdtujKymnaabqjfl0bSckkY+6qWRMwjHdZgykZ6gP1WNTfL5WrntvGgqrb/wDs5DqSn/Av i9MOL8PDc57LR691ZpGi28g05R3RlTTTdFOZGOyY2h4JLvpjKqY4zM44Q1s0gz1Z/Vax/X0lm97+ V2qq56HrtHQ6fdqKhFHG2MAukHzNY4OA598KLN/dy7XNYX6UsDYpKbDWOkYQWhoILS0g/pjCr04z hvT3XydFJIM5GVcbZ3Ft37eSUdUj3DsTlfMhet1PIPb7r5Phe0ZPb6KD44S/RPuPZNoJKilhGPsv Q2neWA4xn3R+GeCRj+SD4AJhv1X1MLmnnlP0XeyD4Y59kY+q+phcOcfyR6TvsiPl05S6TlegwSD/ AA/yWJidn/3kHxDfqgjC+4p5OP8AosZIntPbKD49JSX3ETlg6MtJyCEV88JgeFlhZMYXH5Qg+Zae 6F6BC72Pb2Xy6T1EY5CqPnhMBfURu4R0Oxx/RNK+WE+lZ9Dj4PH0SaOrjyoMC0n6JFv1X3ET++MB Y+m4HtlB8ukoDfqvr0kHsgMJzwg+WMI8L6+m4dx/JfMjlBihCFQuyfdJAQNCEZShJpFPwogyjyll H2RRnKEeUFEPyhJGVVNGUsoQNHlJCIAj7ISKBlIIQgaEvCEUIKCjCIEI8o+6AQfZGUFVQO6eVin9 0Q1iE8pFAJ54QkgaYSCYQCSaRxhAieU8rFCDIIQhAdwhIH90wgAmkO6PCB90JeEIGEIyjKAS5Qmg PKAEIQCAglCBhI9kZSyqBLymhAgE+yAUIBCPCEDQEZQgPCaSaAQUfZLKIaSEeUDQl5R5QNL9UIKA KSfhJAFCCgIEO6aMcoKBI7ISQNB7IQEBhId0/CO6AP08JDuhBQPKPCQ7pooR4QkUDQUIIQGE0j2Q g9TfGUysQsvK5NFnBXuoDgSH2aV4uy9tEB6cpPhhP8lBzzB8oXzm/MvrGOAvlL+ZWFfNCELSBCEI BCEIBd9s5j+2tvJx+ZcCttp26T2e5QVlK7EsTuoexQXP3tkMO09f0ZyWRgY/5god+Hlt3bf3zUWD TDAka7yfGFIenNe6Y3D0dLZdQ1UdFNJH0v6nhvSR2cCfYo2mqNLaZlqbZJeKJ1VC/InEga2UeD98 eE+GJLvdTPVvmbRvngiDqhsZIZ/xY7fuon2iudTeNV3usrqc01S6pw+Hn5XDv3XuoN2bX/bestdb W0scDXBsUof8jh457ZW5tk2maHVNXXUt4o2PqyJHsdO3Bd5IOVCvdr02qpo7hBUOYLm2kdJAH4By AenpPvlY7Y19VXaUp6ivkfJUiNrXOf8Am491lc6fT10vkdxqblRPLYwwMMzfHnuvdS3mxU1RPTw3 ChiBa0hrZWgefqtT2zlvVse2xXujvsExiLTPTSuieD3aQccKr3xLOd/2jjGcilZ/qpI2r1RaKPVV /oqu4QRSOrJHNL3gNcCfB7LmtyYLHeN4qdtzuFOyldAzpf1AtcQTxnstzUuUnpzx5Xjal/b0F238 QdzmmbnP/KqOayjazUdxDcBond2+6ufqzWFn0FpAOhmhnDm9EbI3BwOB9Dx3VJtQVzbjdKurYz0x PI54ZnPTk9lcLMfFcb721Zb5+U9aas90IKS5O5hBQEINnYsfxKl9/Ub/AFCvrUudBtnNJEehzaV+ COCD091QCjmMM8cjSA5hBH3CuRtPuDatcaUfp+6TNpK8xGNwzjqBGMtytYWTOWuP+Rjln48pj7QB ovWl+tGp4qujrJTLPIGyh56g8E+Vax9ss9u03U365W+CrLmmolBjHUT3OMrT6U2ysWk6GrmuAgqm jL3TOAPyjzjxwt/DV2nWeiay22SvgcHtdEPm5A+yvV8nfoy5Tx3j7aan0tpLcDTDa2mtDKQkB8b+ kdQP6Lf0midMSWKE1ltpMfk6vTABOcJaJtf9jdJfhLjNH0QR/NI05GAScr31ddQ02jhV/iGPpGH1 HSMPUOnqznhTLW7prDeu3N6h2t0xeLTMylo6aCvpfmZKyPAyOQHDyCvlp7Rmm73pyKvdZqNlXC35 /kHQ/Hfx5wuwsN0t13o62ttlXDUxTRtDXRuznAK1228Ln6Nliz0vcHN58Ekq4zc2mVu7P44TUu2G ltcaOmrLPQstVcxhdFIxoADhnhwHccKPfhrgtrr7WWi60EclXG4vZUM4c0g4wD7ZU+2WD+zWjJoL s9kXSxwL85bznz+qhL4dbQ+fWdzukU8L445HRFgcCe+c/ZXySTC2e9phlbnJfWnj+LChdRVttDKm aSEhx9OR2ek+4Wq+FAH+2dTzwImn+a7P4urTWS0VBc4YXSUURLZJG8hpPbK0vwn2SY3CovDJInRf 7pzA7Lhg5yQn+TrKY2fTH+JuTKZfbffEVamX3cDTltkcWMqB0Od7ZJXdU20ekqS2QNnsTat4aMuj aCT9SFze/MUtq1tprUNTG4WqnkDJZgMiM5Pf27ru9btvF90nRT6JrAKhxa4SRPAy3Huuvk1ncZL8 MeK3DHK63do63H2Is9xtLa3S0Jt9bH+aB4w17f8AQrd6A2ssWlbfSVNxjBuQOWyg4dnvgDyveLRq GzUVJX3bVs72sINTS1YaGkeQ1y6PWFJPdodPVlrH4ingqGzPdGc/JhcZN3Vdrdd6cf8AEnZ6i+6c tFsogHT1E4bH1HAJ6eFXyTYnWwH/AMT4z9pR/wBFYL4lG10miKK42kSH8JIJXPi7sAHdV5h301tT xtjbeHFrRgdTQcrr5O/Hix4tzLJpNT7Yan0tQ/j7vbXx0oPS6Vp6g37+ynb4W7fZa60SyUhqKS9w fLNJG/AkaTkcdlDt33n1beLdUUFwro56WdhZIx0QwQVNnwm2SrorbVXKRg/DVgHpuac9uDn2XCvR 8OF3EpqF2+DabVjn19C7pjc9vyOw7tnHchSPdNl9C2b/ANIV3r/wqYNDSXEmNxOB9wc/oo335oai k3ZgqaiJzIZ3xem8jh2CM4KnrdgdW2URB4D4D/7oL0eXX5pPjTw+PLKf4/L52gPfXZmn0pbGX3T0 zpLYcCSKT8zM9nA+QoDIw7CvN8QGHbQTexbGqNyf7wrncZwmX29Pjztyyxvw63a7S0OrtV0trqKp tM2Tn5uOvB/KD4JVj7psnt9Z3wx3evnoZJR8vqSkB30B7Kum1FifqLVtPQU9wjt9S4dUMr/Lx2A5 HKuFb57oIqfT2vbEbnE0YbcomeowjGAXDuD9QubpUZx/D1b49XxMdVSVWnqmIuikY4B7H98H3GOx Wsg2Mtce6EtgqaqaW3yUv4iJ7fle05xg+/3Usae0nW6U3BhfDcJZ9OVLCIIpZCTA/wAN58ey2tTR zRby09dJG5tI6gMQlIw3r6u2fdamtXbPe5EAT7QWG17qN03da+b8DVwiSllbw4OJ/K7/AKrrT8PW nqKqdTXS7zxGaTFK/gCTP+H7he7dankZvvpeVzXCOQxNaccEhxz/AFUi7mU1RPetIvhje+OK4B0h aMhrcdyrqctfwlvGWoIbsVR23XbbNfK2ZlBWMJoKqMD5njktd9cLfQfDvZYqp1Fc71NBUvefQOAB K3xjPcjyFJ26hJ1XogNGf/SByfphfXcaCom1pot8Mb3RRVjnSODchowO6cfX/W2Pyf8A30r9H8Pt 0brp9pqJHG1geo2qZjLmE44HuPIXW/8AwOmnTWOo2amd+LBx6R6erP2VgajP9qqTPDTTyYye5yFC NRbrifiMhqvws4ovVGZug9P5ff7rUxlxt/hc7Mpj9uBtOxDTrOt0/e7kaWYM9SilazLahuTk/Qj2 XR0fwzRupz+MvLoan1HMa0MGHDwf19lKesKeWTd/SUzI3mKJsvqPA4Ge2T91y/xA61vGjNQWartr swdJc+KQZY8g9vocLX493r6254+b7nzpGGktmWw60rLVfrmyhq6RzJqYPaOmqZnuCfsp+3V0ZT6m 0ZDaHVdPRYIc17gOkuAVa9YboP13qWyVMtGyinp5GsLmPzwXDyrD722W46h0db6GyN66qR7SzDsd mnyng1fLNXR/kbnj79qT6is89kvtXbKvpM1NIY3FpyDjyD7KfaDbTSF92U/jFvcG3uKmL3OZLk9b e4LfqoS1pYLtp6+Por7TvgrA0Ow856m+CD5ClFm0VfBtW3VNqvUhc6nE8lLjpBH+IAg98Ln6z9O+ 94bQVI3pefvhJpRMcvP17rFpWL7bnptLHVy0FxgqadxZPC8SMcO4I5CvfqTU1dbtnf4/G5rq5tGy Ulzcgk4zx+qoXbGvkqWsaCXE4AHcq7G4LS34d3t5BFBCD/JPH35JKnk6wrP4byyfQFS97GBslbMS 3GG84yuh0xoKi03rStu9nayOirocPiHZj85yPoVy/wAOgxtbVZ7Gon/oFjsBrisvzK6y3FvW+h+a ObPJYXEAH7LnvUtv26ZT9tT6bjQN2qZNyNX2glv4OCVs7W47OcBlZCotu4lVqjSV8o2vbQS4ZK3A IB/KR7EFa3boE7wa5d4JjC9G2NBUw7i64rZYXtpp6hrY5COHFvcA/qvRlJ25S9yfxWinFVt7ui+K 3zh09BWeg2QjHW0kDkfUFWV32v8AJZ9vBI2CCWOtAhmjkbkEOb4+oKrluWOveS64Gf8A0i3+oU5f E0P/AKm9ub4M0Y/9yseHv/Ik/jP+T/8ABNfbH4Xr5UXDS9fbJ2tMFte1sJxyA7JI/ddbp6uk1lTa jtuoLbCKON/osaYyOpuSOc+eAuA+FBvRQaiePyukix+xXfabv7tcaf1BQsfJR1tJK6nNRHwe56XD 9lPB3ju/aee3HK6+ng2PuElRYrra54oy2z1LqaAluT0ZJAP2XptGsXes2k1hQUtvbXB4o6jI9OUD ILXZ/K7HhaH4cmyx2/U7qh/XMK0Ne/8AzOAIJXI63uVbuxbqW32iheLjapJpJy7iJ2Bx0u9z7LtJ 3nufLnu246vw7bReltPbf6ZrNUVI9T1cymUtz0NccBuPIBwtLZteaX3Ktty0/qWlpKWctc+nfkND sAkEE9nD+a3esI5ZvhzdGxrpJfwEYcAMnIIz/MKr+mtE33U7auaz0/qspo3Sue49Id0jJDT5OPC5 d+3pymsrIsT8O9xs1HoqahqnU8lT/EjGYiGl3z4DTg844Uh6ymskcFZZqqnpGS1NFJJGHsaA/AIw PqqkbLB3/aXYg4cmpbnP0Kk34uZZI7vZjG5wIp39jjHzK+C8vJZ9ds/5F6xv2rbWBv4h3TwA4r4t /MB4ysjjJz3WOR4PKmWXK2tzqaXM+H11in23s0E0NJNWSTSxHLA5wcCSAfI4XV6/pNNvst2tjqOi bXx0zagM9NrXYzwQe55CrV8M0kh3MtrA5wYRISAeCek84Xc/ELNJHulbCxxafw0IOD3BkIwszerf p0wx3lhPtvPiTsltj0vY54aSngnM5a6RjA0kFh4J++FtLbp61T7H2yWpttK6drIfnMQ6gRKPPddX upqqm0rYrdPV2yG4iaToayTGGkNznkHxlY3C5xXfaeCvhp200c4he2JvZuZW9lxurcLvtN2bmkZ/ E/p+20dPZJaGjgp5JJJGvMbA0uAbnwuip9L2SbaHT9XLbKQ1A/Bkv9IZP940HP3BOV4Pinz+HsIH /wAklOP+6urpGkbNaeB9qL/7I1ezyTvD/r/8nisy8OX/AG8W7O0Vu1BbjVWClgpLlTtOI42hrJW/ 5cDsfZajWlgsmnNvdPXOaxUgrKV9N6sbogOvw4OHnPPddVuLr46K1ZZWVYL7bVMeJmju3kYd+i1+ /wBPDXbf0lRA7rgnqYHMP+ZpJIWvFjrOS/MeLLyfryk+Wi3i0pZ6/QtqrbDZIIKupmiLBBEGu6Xg 8cLS776Us1r2utNVS26npK5hiDzGwNccswQf1Cmqxy0MWldPfxFzGZigbEX8Dr6RjlV7+J06iZd2 MuGf4Sc/h3xg9BGSQD/xALPhy3x69Rry7m5v5V4eB1v47FdvtDpmi1ZrW3Wu4SmOmkLnP6e7ukZ6 f1XEuzl2R5W80dHdH3qmFiZUPuLT1xCAEuGOc8fRcL/Hqxs32tTqqj290neKW1V+lGOdM1vTM2IB hycdz5yvtXbTaaptwrNVQUcRt1Y2Vr6NwywObGSHBeDT24Fq1GLfp/cS0OguzT0epOzDckfK4eQT /Vbqzacu1g3RtUc1wqK2zPZO6m9aQuLD0ctI+g8rpdX05S2e0Kbm6WtdBuuLbb6RsFC6enBjb2w4 jqC67fXbm10dZZKfSlpZDU1Lnte2IYDuRgn913esb/omn12aS62eSovDXwsM7WjALiOnnOcjI8Lu Lm1smubO1wB6aeoOCP8AlC3bOV1Phjx8rjN1FNs2FtDdHm3XCdo1FODM2cf4SBywDy3/AKqOtv8A R9ptW4T7Fra2PmfMRBF8xAa8nhw9we2VOt5tVJUa9gqjrCSmqoZgY6EkfKTwWjzgrT7sQsO62hpM APMzWkgckeoP+q8vkt4XXuO+OuUeq6bYbfNuLLM6gZTVtVC58LvUOTzjjJ7hRvpPZNg3Cqrbfj10 VKwTxgcfiGE4ByO2FIO5zy3d3RIHlw/+yLvWjO4Up/8A9Y3/AOyOWp5P24fyLMdzaLafSe1dVqU2 CGhmFyEjoi0l2OoZzz+i+Vk2Y09FrG8W+5wuqacQR1FNh5b0BziCPr2XNadd1fEN9f4lUf8AkKnm LA3Drf8A92QD/wCuvXbL9PJcWbjrxzL5qsGhtEWi5btGy10Ln271qhgYHEfkaSOf0Wm380nbNK6q fQ2aN0dP6DJOlzicE5/6KwWmtNUNDqmxXqCBzK2orq1kriScjEmOPCh34oDnXk4P/wArx/0K3lJe d+ozneNwxQQwEkcKePh60dpLV0NXSXyOpddWO62Bsha0x48Y85UHDglTt8J+f7cS/wD6o7/RePyZ WYyu2EltlSTHtPt5WXmtstJ+LFygYS5hkdhvHBz57hQlLtZcZ9c1GnqNvqvp5eiWZoy1jeD1EfYq x121FozS2tLnX1dVLFeHsLJQ4EszgYHbjIAWW0t1bqa1agvlPEylnq6yQNeRktwxoGT5x3Xef1y1 +tv0iTcnYwWmw0tfpzrqTBF0VkYPU4vGcuH/AEXM7Q7Tz6wuP4iu64bPTuxJIDgyHy1px48qyG3V ku9trbm6636lukNU4yPijx8rzwTjwMeF8bfCym0lrOCmxBFFV1gb0jAb8gPC1qcuO3PLLWHNwb9n dC3eS52yyXCf+L0jSCxz8hjvGR559lB+nNMWqHcGO0anlkiomTvp5nwdw8AhvjtnCmLTu02o6Wpp 77YtSUbKpzBKHYcchw7HBOR9woavrq0awrZK5zTXNrsyuj4BeHjJCvlwmPjzs+HTwZcvLj478po3 A2e0fp3SlVWNrKplQYyaYvdnqcMHH6ha3Smydq1HtzT3ShqJxdZ4i5oeR0dQdjH2wF2fxBOI0PYx kkmZoP1+RbfbK6ssOyNBc5WF8dPCXuaDjI9TB/qvDfJly8c+3bjOGWX1UT7ZbN0V7ZeI9QuqYKuk kDGsacDGDz+4Xm282VN9uFTUXV8kFnic5rHg4e/GcED2VnLPU2+5W591tro5GVceTK0cuwMYP1C4 S++t/wBiuKaQxTyNYxj+rGC6UDv+q9fix55cdueV/W5aR7cdjdO3Sw182kLxJVVlMSCyQjpBHJB8 jhVoudMaWpfC/hzCQfvlWq01t1rnSlZU19rrba5j43Nli63dLxg9xjuqw6ia/wDHymYj1eol33ym U1WJWlKRWZHKxKyrFMplIjlVSTKCl2KgE/KEY9kQkZQhAsp+UimgPKSaFVIo8JlCiEhNJAJpIyqG l5Tyl5QCPKZSGUB5R5QjKAQhHlAkeEFCACaSFQIzyhGEUxygpI8IAJpFGUDQe3CSMogQghBQGEvK EwgSeUYCMZQCPuml4QH2QhCAzhCCkgeUeUeE0AkUinjhA8oSKAgYQUJffuqGjwkn4QCXYIR90DB+ iPukmUAn4STQARlJCB90dwhHlEId00IUUFII5yhUBR4TS8oBGUIBRAkn4QUCRn2TISCAByhL9EeU DSTQgPCSaRRQjKPCO6ARn3QgIGCgJeUAoBPzlCR7oDwjAQU0HpCyHdJMZXJo/C9lMP8AZKl3/wAy d/ReQDyvZB8tFVfWN39FKOdj5bhfOXuvqwfKF8pvzLQ+aEwkqgQhCAQhCAX0jBz5XzXS6IsMmoL1 BRRkNLzyT7INOOrvyvoDIOcuCuLb9E6X0tpNz77R0z6dkfzGUAFxx7rzba2jQ+qaCsgo7bE6m6yP TlaOofr/AKozaqKPVzklxHuvq2SbGA5wHjlXA0jtRbLNfLi2e3MmoXSExeqA7DD2GV0Vu01pCW8V FFTWyimawYJa1p6HD8zT5Q2o8JZvMj/3WLpJRyXvz91eKusWiYru21V9np4HytDmSuY0McT4zjgr KbavSVbHVUUlphYzAIc0YIznsVU2owZZG93ODie+UnySu5e9xx5Jyrh6R2gtFrra233eijrIHuLo ZXt56fbPuFF91temNF7uS2+poRLZ5GMPpyfN6ZdnPfwtYzctnwzc5LMb7qCpJpHMw57i32JyF5nc lWe3d2Zt1bYf7QaHjw9rfUlpmnIe3GctHgj+arHKwxuLXAgg4IPGCprrbpLN6fLukmhZUBCED6IM 2cfdeulnnge18L3MeDkOacEJ2lsJr6f8R/uesdf2zyrWXHZzS9+0E2vsEb468Q+pHJGeoPcB2I+q ukt0rG7UN2LSx1wqyCMEGVxyP3Xxo7zXULy6kqqiB3kxvLf6K0Ok9ldO1ejw3UFLJTVxZkzh3SWn /wC2q36i0vWWu9VtHBFPUwwyujZM2I4e0Hg8Jq+0mUt0+U2rL3MwskudY9hGCHSuII/dfJuorqyk NKyvqhTEYMQkPTj7dl4JqGqhcGywSMcewcwgn90xQ1YOHU8oJ8GMqNdN1prUlZa62IisqoqUvHqs hkLctzyrh6Q19omLTLadl+hia+PBErsPacefryqOTQzQu/vGOZ7ZaQvm2V4GFZdJZuaSbujqK40l +rrdQaikuFpl+ZhjlJYWnwR7hcLZtQ3Ky1RmtlZPSynu6JxBK1fU5x+ZfUQSkdXpvx79JVtuXdTH CYzUdHdNeaiulFLSV11qp6eQYdHI7IP6LW2HUd0sNQZrRWz0kju5ieRn7rWGOQeOfqE2wSu/Kwn9 FF6dPetwtSXqgfRXS6VNTTPx1RyHIOF9bDuFqWxUYprZdqqCnHLY2v4H2yuTELs4d39sKatptl2a xss1wuFTJBG4ERmPu0jyR5ROp3XC3rcrU17oTSXO61FRATnpeQV9LDudquy0gpbfdqiOnH5WZyB9 srQalscliv8AW2yR4kdTSuj6wMBwB74UobXbKSay07Pc6mrdTNc0/hy0ZAcP8w9ldWXVSZTXKenI T7p6qkoamikuk0lLUhwkifgtPV34XBnOeQtjfLZLabpVUFQWmWnkdG4t7EjypH2Q21oNwJbjDXVs lNLA1pjDMHOc54TWuqsss3EUAkc9l2mjdx9SaRpn09luMsFO89Rj7tz7gHsvhuToyo0TqqotFRI2 boAfHI0fmae36rlix/cf0Sw3LHY6x3Hv+r4IIb3UicQO6oz0AOafuF7KjdjU9XpsWOsrTUUQaGgP aC4Adue6j8tcEzE/GT/RO6nGa07277qajuumf4FXVnr0PSGgPaC4AduVH57p9Dk+h3n+ibutfSyS Xf2+1FVS0lQyaF7mSMPU1zTgg+4UvW74hdY0lHFAaiGT02hvW9mSce6hoAlfVlLM9hkZG8xju4NO AmlSHqndzUWo6qnqKmoEM0OOkw/ICR2OF0I+IPVktsFHUmmlw0N9RzOT7H7qFXAtKYPKlJFmttdb 3jc7UtqorvNRCW2SNqYi5oa+THBAPvhTdvDf75pnS5u2n44pvwx6qhj29R6PcD6KnWzukqrV9+kp LfdY7dWRM64i7IL/AHAIKmuq2Y1zJTPppdVtkikBaY3yOw4e2CVcfbOXpq9t9TXrczcekq6qppoh QFs5puogPAOCWj391M+9Gp75pDT7LxZKaCop4Xf7QJG56QexCqtS7f6ksW4tJYDK+33CZxbDVMLg 1zcdwR4Uo12z+41XSS0lVqGKop5BhzHzPIcPqFZ77Ys1OkX3zefUNfqWC8U8oppYSHNiYT0Z88H3 8rsGfExfDGDJa6AyAcuweT9lGm4e3N20Tc4KW7ekWzjMcrD8p55/ZdtS/DlqaroYqqkrrdLFKwPY 4OOCCMpcbL2uOWNm4wpfiBv0OoZbkKeF8UrcOp3kloPu32Xj3K3on11px9sr7VSsf1B0czCephBU Xajs1Zp681VsucXpVVM8se0HI+4+i1nHdN2VdY2PrHKY5A5pIOeCp00V8Qt4sVkgt9wo4bj6AxHL I4hwb4GVFWhNI3DWd8ZarSI/xL2uePUdgYHdSUPh01mBn0qM+399j/RSLe3B7ja1rda311wrPlaC REwnJY089OfZZ2vcvUtssD7LTXB5tzmuYYXgOAB7jldTS7Eawqq2spYqalFRSuAex82MgjII45Cj /V+mLnpS8y2y8U/oVUYBx3BB8g+Qr37JJJpoHcnKYBHKz6eecp9/Cy22Wmrs+yXuiuEbGSSU0rZQ x4y12DnB+6shUfEha661yUNdpsSU0sZY+MSDGCPbGFV0DJ8ptxnjOU9XaVPG2m9sOkLLW2ie2uqK KSR74XNk6XMDvB9/C0G1O6TdD6lrq19GaqkqgWuYHdLhySDlaDTG1+qtTWdlzs9uNRSPe5gcHjOR 3yFyd4tlVaa+ehr4Xw1MLiySN3BBClxlmmt97WVsPxBWe311ymdY34qpjM2Rrh1nIALXHHOMd189 W/EPR1Ngqqew2+WirJSTlxa5rs8En6qsPAx3THsrvbMjuNEayZZta018vNILmwOcZWS/MXZGM8+R 4Uza+3r0pq3SlVaZ7TVtLo/7iQlp9N4HylQxZds9U3m1QXG32ieejnaTHI3BDhnCLxtxqqzUElbc bLVwUseOuRzPlarjdXlPaZTlON9Ja2o3osGltLw22vtMjKuMdD54OkeoM5BP15Xw263htOmbrfxV UtRNR18/rRPYAHN5PcfqosoduNVXGhhrKOx1s1LM3qZLGzLXD7rOTbTV0MLpHafuAY0FznCIkAD7 KYfpOOP2ZSW7qddI736RslDLDFaaqOR8jjI6NoAkGSQ4/XBXut29+hbVTTx262VlKJiXuaGDBce5 4KrbZdGX+8wPmtdqq6qGN3Q58UZIa7GcFeubb3VUUT5H2Kv6I2lzj6ROAO5VuV3azxkSbtrvQyw1 dZb70yStsE7nlrcZdHknjHsfZdZV716PsumKuk0lbZKad2XMhfEBG4u4dyD7KAKfQepZ6eKeCyXF 8UrQ9jmwOPU09iF5LvpW9WmJslzt1XSRuPSDNEW8+3Kd3tqOz2b1hYdN6qmrtR0kssbm5hki5MLw 7OcLtd8dfaR11Yo3W01LbtTuHpF8eA5pPzNJ/moUoNK3muphUUNtq54C4tEjInFpI7jKyuFgu9qj Yblbquma84a6aFzA4+wJ7q4TjeU9s5yZSS/Dv4thdZ1FPFPFR0z45Wte0tqAcgjPt9UO+H/WzWl3 4GDA54nBJ/Reah1BuRbLfFFBNfIqWNgEYfG/pDccYyO2Frnbs61geQb7V9QOCHO7H7FTS8vh1mxt 8sGgtSXN2rop4LjB/dxFrer03AkOaR7reb0610hqSttN2s088lwgmaJ2lpHVC09WPbOVCUsd21JX Vlw9GprKiV/qTyRxF2HHycdl5Kq119KWfiaeeMPOG+pGR1H6JPmOmFuNl+Yn7fPcmwar0vaYrLUm Sphm65InNILQWEf1XvoN09PN2bhtLJntu0ETGNge3gua4Hv7cKuM1FU0zwyohfE72e0grI2+rEbJ XQysjfjpcWHDs9sLN8cllpPJuWRaW6bg7c66tNvk1XUTQVMAPVC3qBa4jnkeEaq3V0jR2K0Wux1B qaKGaHqwD1RMjeD578BVfba69jy0wTB3t0OyvPVU1VT8zMewH/M0hatqY6k6Tj8QetLLqass9TY6 1tQ2JkjHjBaRnkcFddd9e6KvW3un6GvuLj6Dqb14WAte3pIDuceFVJ0jurgnA+qPWf4P80vku5fq ac545Jx/u1qd49daZrdC0lDp+6MqJaSaItYMhxa3IWr3p13YNR7YWumt9wjmr2GJ0kRz1N+TBz+q rWZnOHnj6oa97+CUwzuNn8MvHLLPszy957gldvtBqyHRmtqG7VMBlp4wY5A04Ia4YJH2XGNpphkn A+6+jYJG85Gf5LMdFuNRT7aaqv1Pf6jUkUdQGx/I12PynIyMZW0ue6Oln66ssDbjF+HgZI81Wf7v 5mYAz4OVThrJRk9TcfdJrJfcFW272e5pMe5mobZU7ui4UVbFPb3z0sjpozloDS3P7YU8VuvNLO1h aKhl7ojEYZ4y8P4aSGkZPjsqTBk2eXNyg+r9Crc7lds44zGaia9Valtw3yNeytifbm10MhqGO6m9 PS3PI8ZUt6quulbzr2wVs+oaSOOijM0bmSNc17w8EAnxwqcBsmchwwsJJJIyORhc9btt+Wp1JPpe e73PRlVfYb9VXehnmooCImCUZaQerI57+Fwel957RcNyKh9wzTUU8Qpaad3AADiR1e2SVVA1EvYH H6pNkcXY4yFZqXZurj23TelqHXp1P/auifKZ3zinL2jBcMd858+y+9v3M05LunVQSVQiZLTspWTS OAZ1se4kZ7YOeCqdNdMW8Y491j1S9f1z5VyzuV3S22a+l8qfWdjfqWrt8lwtjIYYo54ZDI1vUXZD sE8Z48e6rNvfcItXa1qqmxRVNVDHE2KQxxlwDhkdxnhRa0zk58+/OVIW2e5Ny0PTVkFNRUlXDUOD z6w+ZrgMcFawy1LPtm47sv04T+BV7pPloqnI8em7P9FYL4ZLJTW2arvFwroaadoMH4aU9Dg0j8xz 4JXgHxA3ccyWK1PZ4+U5/quH3L3JqtbNpDJbqajkpw4B8OQ5wPg/RYyxmU1WsctOo+I6gp6fVDLt SXCnqoK85LYnh3Q5oAwcfRdx8P1xpG7U3iJ1VC2o9WoPQXgO5YMcKqtVPMTiQkjxkkr5xVdRCCYZ HMz36XEZV/8AKZfTUy/S4fayvw13ZjtUXSOepa3qpm4bI/HUQ45xkrrtP60s79W6o0de5GxNrayX 0purDZOsAFufB9lT2GqniPU1xa73DsFDqyZzi8vJeTnOec++Vu57yuX2zlJljMb9aXV0TYbfoC61 bKi8074ri8QUkZfgtxlwB579/wCSgRtnbqHdyqtRq4aUy18rvVlPy/KerH3OOFFT7rWP6OqeQhh6 hl5PSfcLAVU/qiUPcZM9XVk5z75Vvk3hljf/ACZwx4eSeSfC6W+VqNfoWGWnqYT/AA0+s4dQy4dP ScfutNbpYm/DPJ0SMd00ZBw4HB9TsqoG51j43MM8nQ4YcOs4K+bK+rjidDHK8RuHLQ4gH9F58sJb jZ/4usz/AFuP3drWfDTWiWx6gY+cdLZwWsLh8oLe+F7tH3uz660pWaOqZjS1sIc1o68F+HEh7fsc cKoVLcq2leTTzyROPB6HEZSiuNXBK2WKZzJG9nNcQR+qvhl8XcqeXL8i8O3lqqNLWettd5usdZWT mSaPDyfkA5Az58qk+qZPVuk/Tgjrd/VDtQXOWRj5K2oMjQQ1xkJIz3wtc7rkfk5JK3d32xXmIWPT wV95I3B3IP7I9M+x/ZB58FGF9/Sdk5BA8cLD03O7DlFfLCC36r6iN47tIR6biOGk/og+Qan0nC+g jf8A5Tn7LJkLzzgj9EHnIKS9Do3AHIK+WOMoMELLCMZRCCMLMBNrHO7NP7IrDpKXT9V6Ogtb8wPP bhJzCPB/ZB8A0o6QvuIj35/ZIxu6vyk/oqPjhGF9/Sd3x/JYOjdgHpP2QfLHCWF9SMcdisS1EYIJ /mnhIhAk8IwmAgPdGM/RZt7rIsPV2KD5EfqjpK+mMZwmP1QfDHKF9cZOOc/ZBYR3HCD5pL6FuEFq pt8yEFfTpQRjsivknhZEYGUsZTYWEHun2KRQMHhGEN/mvo0ccJtHz6eU+k4+q+hHTyeMpjGP/eRX xwUAL0BpxnBWJZycf0RNPjjCRB8L7+ngHOViQB47oPmEvKz6f0TwG90HzCCP2X16fbkIIDRyEHx7 fZZBfRo47JiM98cKj44P2TX0HJKZH34+iD5FJfbpJxgfySLMdwoPknhZgArLoIHbuqPkQjC+uCT2 /kkWZP8A7yD5oWRbhLGBlBiFlj3WTSO2OSs+k47FTY+QCeCVm4H2TzzjyqPkQgBfXpLuPKA0+xH6 KD5Y5RhfYsA98oDcHz+yD44OEYP6L7d8gAlIhw+iI+SXlfb9/wBlgW4HAKbGHuj3TxkFLwqoygoR lELKO6MI8oGl2R3QhoBBCPCENAIS4Qho0gkEx3RQUJoKDE900YyjsgEx3+qXdHZAyke6D3QgO4Rz 7I7BY4+qD2juFkAk3ss2jhcWtgdl7WAijqf/AJ07+i8gC9zeLbWntiI4QcxHy0fRfKT8y+0fLQfZ fGX8y1BiEkIVQIQhAIQhAx3UmbFEf23pBx2d/ooyW307d6my3GKsopCyaM5BUouL8Qny7YTjPcxf 1Ub/AA50V0F0mqqaTppsgFh7OI8robFuppTWWkJLRrSUUjnM6XOLSQCOxBC9G2uuNFacgmtsl0hY 2BxEdR0ECRvg/dK5yaqb7p+K/h0slEGfihGSwO7deOAfplRXslU1tXc7xPdIxFXfin+qwcAO8gfR eGw702kasr6a518QoTIRBUBvyuZnjK31n1noOhvlZVUd7pI/xBEjvmOC490XXbbbiXG2y268WzgX Z1IHRAtz1nkjHsQVsNvZan+x8UtY57qpkLOovPzZA7FaeXVWg5rubjJfqAzlgZ8zvAXo/wC0TSJF XFHfKJrntAb8/B4K1jN2bYz3MbZ7dFpHUdJqS3OkjwJ4XOY4EeQeVVT4gMu3QqukHIijH9VI+0Wv dOWquudHcrjDTONTI5j3n5XAnggrndSXLSdy3hfV3K4QyUJjYY5WO6mEj3K69TnjPTjjjlcsMrO0 6aUaG6AAd3/Def8AlVDNSD/0zWn/AOaOP81bzcHdOw6a0t6Viq6aumnBYwQuD2twP8QyCMqnNyqj VVk05aGukcXYHYZKmOUniuPzt2mN/Ly+NPH5SKfcJHuuTsAsmrFZfdB94OXDCud8Nct2ZpaOKvY0 0Lsei7yB9VTmzSQMuFO6qGYBI0vH/DnlXesmqLBaNvXVmn6ykkMUBeyAyDJIGenHfKsm6zldRuN2 6ypt2nGQxUnr0VVJ6U7m5BjBxhwI+q99jsNDbtPwmnjp8lveoGR+pXNaR1xZ9d6Pnp6+ughmcMOj dIA5hznz3wvY652XVuj66wwXaCCZmYHuc4ZBB74zz2W7lvGYuUw1lcmwvum7LfrW+G4wW6OoZ88U tO8FzHDkEZ5/RY6btlDddOtqZqKlFZTgj1hGPmx5x9cLhrht7o226Znfcq3M0TCfxVNUfOD79Of5 Lp9r75apNDup6W5w1EkUZYXOcGudgHkgnuVLOpomWrdx5L5pGx7gaDnlqrdBS1IYXMmiaMtcM8j9 lSG5Uxo6+enc4OMTyzPvg91e/Qd2t79GVFLHVwmeJrmOZ1gOzz4VGtUZF9rs/wDyZ2f3W+M45X6q zK85PjTGwOo2Xaldco3y0YkBlaw4Jb5wrzadobDPoynr9NWqlusDWDpi4a/6jOO/0Kozp6Wjiu9L Jc4ny0TZB6zGHBLfOFcrRWnrfFaaa6bZ31tHFLgy00zvUjd7ggnLSuTq1t8tG3+tTFR1tGbNfY3g iAx9Eh+h8OBUhU+irRQW2nigs1DUgNAAeA0/vha/XtLZDQ0N71G6CluVA4OZVRYOT/lPuD9ey+mq 4Br3RdN/Zq6xRSEtc2ZsmC3HccchRlptwNv7MbSy+Udrpqa4W/M5i6Q5kjQOWux3BC6Lau72y9aW bXWm2ihjIw6FpHT1DvjH1Uc6+0JBZ9FT1Mmpa6krmxnLn1LnxyOx+U88Z7LL4YdV22p05LY5KhkV xjc5wjecdYJ7j3WrrU+3O7trid0NTaOGrIaunsxF0o6giojeA6OdvYg+x9lP+2l0tF10m2vslCaO leOYuAM+cKIN6dqbHT2uuv0dxFJcy50vTK7LJT36fp9Fvfhp1JbK7RjrI2oZHcYQQYnHBIPke635 Mpc+vTOGFx8Vnyh7feu0fdaszWOino71HM4VHA6JR/1BUk/C7FaLvZJoH29sNxoz0mqhPS57TyMl avevaS1W6y1l7guZguJcZfQmPyS+S1p8FdF8J9klo7JUXMywvhq8cNdksI4wR4U8tly/X014JZ45 MvaPtfmjtm98TLxAbnQZYx0c56jh3Hf6KYb7t5oSyUrbzU2SJ9FL0sczp5YXHAIH3KiTf2z1lt3Q pLlWRFlHUSx+nMfynBGeVOm6UjHbYMe1zXM6oD1A8Y6hzlb81mXmknrTj4bcf8ffztx2qdh9O1V3 ttwteaSlle0S0+Mtdnstvdtr9AtuNHZZ7YI7hUsL43xjDT098rvL1cKWjtFpqqqZjKUTQl0pPygH sc+y8N4s9ZVbhWO807RJb4YXse9pBwXHIP2WJOu3XLK76+0Xa22v0BS3q021/wD6MrpnBwP/ALKY Z5afYlb3UO223VgZC67WaVkUnHrxguYD9SOy1291nt1+3Bsduu1xdbopoSI5wAcPzx37Ls7BR6rs UlPZ7lBBqCxtaA2scQJQ32LTwcK+THjrXyz4c7lLv7V3302ys9ioodQ6QrIZrTLgSQCQOMZPYj6H 2Wy+HzW+lbLp+utGqomBr5C9kkkYe1wI5H0X3+JTQFNYH/xey1LY6OocDPQF2DGT2c0exPjwvjsH pPRWq9M11NqF0Qucch6SZehwaRwR7rNjtLtDG4P8N/tfczZC02507nQdPA6T2wueb7Lea5tMdj1X crZBKZoaad0bJP8AM3wVox4WW56STsM9w3JshBIzOAVdDV1mqble7DU0tUyIUlQZJI3P6TI3jge6 p/8ADrZqy5a+oaikjL4qKRss2O7WnIzhWw11bLhV6s0pVUUUj6anqnGoczs1pA7qY75XfrTHls44 /wDbg/iC1PBYdQ6brqaNslwoKh0hje3HWwjsD+6kjRGqv7V6OlvcEboWSh5jY8glhA7Z88qIPi29 N9PZZGFplbK5pI7j6KRdmLTWWvamGhq4XR1PQ9wYfPUMjC6eSayx/wCnLxXeGX3tXDePcOn1pHbo HwPiuFE5zJjwWPHuP+isFs7USSbG00sj3FzYJQHZ5AGcKmmoaSog1PVU0kbmTioLDG4YPVnGFdTb Cz11u2Yit1ZTvjrGwStMZHOSDha8uW/NJ8QxxmPhuvdU9nsWodYXOtqqOkq7lLG/EsjQXEe2SsTt vqxowbBXj/6EcLbaV1/fdu77cf4W5rDI8snhmbkEtJwSPddn/wDBLapAwYqEn6MKnlk51vxdYRyO 119m2219BV3i3VAdECyWFw6XhrvIz3VwqjVcsm3E2o6QDq9J08QcP8IPAP6KmGttb3HcK+UlVWUt O2tDRA007cF+TwD7nJVrm2+rpdgnUUkEgq46BzHRdPzA+2FPFN+XGX0nntx8Vs9tFoDXNPrTduCt thmhhfbiyohdxl7T/MDPBXs3P2mpdeaonqKutfR1PoBtKQ0ESYHIP2OFGfwr0FWNcTVv4eX8KyF8 Lpek9IdwcZ91MNLcKqbfWaifO80kVD6jYifla4jBIH1WvJLjctfBb/ptD2lPh8dc7ddmXSukornR zOiawNDmPGAWu98FeDb/AGNg1XpivrpLm+mraaeSFrGsDmEtHGfPJVnrKeq76h5GfUjwM846FyWx 1NNTaVvMVTE+Kd1dK/03tw7pIGDg84Klx1jf+4c93/0gLbfZui1lY7g+O8/h71SyPYaboBbgflOe +CcrpY/hzintzzR36N90ZH1OpnNHyvx+U/TPlbX4bGOZuFqVjwWuYwgtPGD1ldzoUuO9Wrhn5BEw gfsplj3lr4rVzs4z7jlPhgbcrVd7/YK8yRspOkmBxyGvJIJH34Wv1Ps3U6517qK5z1QoKL1cMkLc 9bgAD9sBd/t5TyN3b1pO6N7YnljWvLThxAGQCt5q+Sp1HYLxRaTrG011pZHMkj4Bccdj9x5Uwx45 3H4p5c94zOTuKK6wscmnNRV1rmlZK6mkLBIw5a8eCFp2HDhnstlqOnqqS7VNPcGPZVxSFsrX9w4e FrO7hzjlZs1dNy7m1wfhMu9ZV6XuVDPKX09I9noMP+DqySFI2m5bnXOvVLqaIuoj8sYnjAa5pc4E fXjp/dRd8JEckNhvUjmFhkdG5pIxkYIyu60VeJdd2PUtmvQyKaZ1P6zDhzmnOPsRhWY7ku/l5/Ll ZnqfTz7E1tU6i1BbHvJpbfWOipmH/wBm0k8Z9khrO5aTqIWa7niNuuRe2nna3Bgc0n5Xj2IxytZ8 O1LJQUWpoHuc4sqg1r3d3AZAP8lyV4jve79vNsMP4c2meYmueOpshAPSwjjBPuuuE3c7Z1KmWUlx xn09mx+u7PaG3q3ula6qqLiHU8Y+UStc4Ny0/TvhS7rPWdq05V01DeJmwR1sUgbK78oIHY/fKptt vTyRa+s8Ujfnjrow4DkDDwCpm+LEO/EWE+Op/wDos+DCZeTKZf8AbfmzuMw189JF2QvdXedvpZJi 2R9LLLBBhuctaMt+/dfe0MqtY7b1zdbW9jajMoEb4ugtDRlrgD2+65/4bXvh2urJW8PbUTOaSPZo wVDWpd5tS3iOe2VMsTITJjqjZ0vGD7hcplubevy4zHLUThqa/P0BtVa6uy08EbnCIFhZ8pLm8nHv wvlDXf2+2YrbjfaeB08frPjMbenocwfK4exWu3tGdoLL/wA1Pk+B8qy26d6fw+XBzz2jqj/VenH/ APl6nt4M8rx8l36b7RmqKybZn+NVAjfVU8EgB6eHdHAz+ypfquuN01DXV5iZEamUy+nGMNGfZWy0 a0s+HCpGOfw9R/UquNHoK9XLTNx1DBTEW6iZ1ue8Eeo3OD0++Es14eve1xv/AOou71pIvwoXqek1 fNaGtYaeujL35HILAcYXTb/XoVmt7TY3U0LRSTwTtmA+c9TsFv2XEfDFF0bn0ePEMuf/AAreb1jr 3sph/wDqrf8A3a4+Gbxzt+I9mN15vHPtOm4239s1vZTBPGyGujHVBUNaMtd7H3BXPauthsGyLI6q mhNbbYoi3qaCA9jwQQvrvRrGu0bUafraE9TDJIJoj2kbgZH39l9t2LpDedk6+5Uwc2GpgjkaHdwC 4cK6u8Zl8s4Y63ZOttncL7ONvqO+UtrpqquqGREQuaOkueQO/juo83ovFvvO1N1imp6alvVBNG2o psDqjcHAEt+hB7rsnag/srs/Zbm+nbOyKCnD43DPykgHH1VeN4rdXXuruWs6OmlbYaydsbHvHS7I aOS32J8rfil1MtMeWznlPhD0gxI7tjKxyus0foW96xqamGxUjah8DQ+TqeG4BOB3WhvlpqbLcqmg ro/SqaeQxyM74cF5pNOjwHtwu+2Ws9svWvbXRXot/CSOJILukOcBlo/UrgF0WirNcr9fKags0Tpa 5+XRta7pPyjOc/oq1jdXetrf7gX+3aLuNDSSaVo5qGZjQ2sIa0A5wW/l7gc91qNxKLT2mtT6b1PT 22lqBWS/hZYWhpa4Obhrh4yMrW6Y3HrrXWUWldyLUHSsIZ+KlAc4BwwwlvnyOoFaHdzQcemNSWiu tsrzaqysj6IHOJ9J4cCcfQhbsu/7pMdW4z4tSzrip09pQ2h0mmqKqFfUCDIjaCzPnkHK5LXli0/o zcKy3htpgqILm8001K9gLWuOAHtB4zyut3b1jS6Pt9rnrLRBchI8hgkIHpuAzkEg4Kge+7j1Gu9a 2MPg9Cljq4THF1dXSS8Bxz+i1MdTll60zynLSddYx6d07cKGAaTp641Ie53o07SY2Nx1OxjwCuU1 3t5Z9Y3vT8un4aWCimhdJK+ABgewEcDHnBK7/XGq7Xpy6Ucd3a1jKmCYMqCCSwgDj7FRX8PtHcqX VjjXwzxU81AZoPUBAc0u7jKx5MrhJZE8c573fTeague3Gj7nQWWts9HO6LFPLMYgTCQBgvHngg5U PfEbpa0WG90VZYXN/B3OE1DWsx0N5/w48Lyb6h//AGl6g/4qgEfX5Gj/AEXCampL1RR0MN5ZVMZ6 AfTNnJwIz26c+MrKxoiCpM2R27dru+vbUymO3Uga+oc0/M7OcNH7KMwcgKzHwhZ9XUR8elCP5lPn RbqWutuLtrbXqWl0/U2m3l8jeh9QGABj+2HfXj+a5Cg27sVt31pLO+OOstU0D6lsMoBABY7Dfrgj hRJuM2STWV26Mkuq3huO5+bjC8ldXaitt7glr566muVKxrY3yEte1mOAD3xgldfNjPFllj70ngy5 4y35XBO3+gmUH4z+D0Ipc4L8HH5sf14XH2bSuiH7lXjT0lhjc8MZNG48tb8gLgPpyF6WVEsnw2yV EjiZTSB5dnnPqA5XBfD9XVNx3QfPWzSTzfhngvkcXOIwAOfsF58fJvxc9e3XLw2eS479bSPBpPb2 v1XW6disDI6+CMudKB8vYHjnOcOHhczt7oPSTdT3/TN2twrq6lnMsVS8kZjLW4bgdsZ/mpStctgq NZ3gUUEcWo6dvRK4k5kaWgg/bkD9FG+10twm3l1C68RRxXARuEzYzluflxj6YA/dTzZXDG2fxx8d tsl/qK/iGtmm7Xe4aDTlEaSan6mVLR2J4IIP2KhyNrnyNY0ZJIAH1Ut77081VuXeo4I3ve6pDWta CS49LeAPJUYSU0tHVuZPG+KeJ2HMeMOaR4I8LvZpZlt1eqNstR6bsNPdrpTRto5+npcyQO7jIz7L hCMKZddbiajvehaG03a0/haVoYGTmNzfV6W8dxjkKGXkl5yst6fSLBkaD5VptvdodOak2upat0Lo 7tUxOxU9ZIDg7j5e3hVbp8CZn6q6m3lzksOw9Jc4mhz6aAy9J8jr5H7Lz+XOzyYyOmMn4sr87cXt ls/apKq9Ueq6CR9VTFvpnrLR0nPzDHftlQJqKxvhulVDRxyOjjkc0dIJIAP0V6tM3+3aktH8Strm Fz2YkHHW0jwf1XE0baLSW2tbf4LfBU1Lj6z2zDIcTJ0+3HBXfx476+WM7qcr1Ipg+3TxBxcyQNHu 0heN+QMHIV2tHV9Buho+7R3i0UsLI5HRYi8EAEEHAIKptqOmFJcJY2flDiB9skLOOUy9JZpr4WmS RoHBJwrP6Z2k0jZdCUl31hPO+So6XmSJxDWhwGBj/VVghOHtPsrL7Ubn0r9NO0/rtj5KER9NPUOj Jy3GOk8ePBW4zXq1FtTpK86KqbxouaTqpS9znSucQ8MGXN58rHaTaXSuo9HQ3C5/ifxck8kfUybp BweABhbzWtkuGn9G/jdva6V9hmic6opgRJ+YHqeCfpjIUdbLX+6nWFjshqnm2mpfOISOzuk559vo tZ/rhMl8E/JncPpIusNkdKW/TN0qaR1SKungdKwulzggZGR7KLNltF6Y1Teq226gknbVlodStid0 hwGS79V3nxE6kuVj1FLDQVBjhrLc2KZpGQWl7v5/VcF8Ocxfutaz3zFPz/8AQyr5Z+OT+s+O8t1t N5NBaT0o63U1rnqXVTph+IY93UWxHuRx913Uezu38emxfjWVzbYYxL6rn9mnA9vdcN8QRI3Dqc5x +HZj/wAJUv6S/h9ZsJRt1BK+K3OpGiZ8Y5DesYx+uFvzSYZ44T5if4+WXk8N8l+LpG+udpNP0Wn6 PUFjqppLT1MdUF7h1GNzgOpvH1XR1GzOgqayMvMtxrIre5jXiVzgRg9vGVvtxmwUuyzoLE317S+F jRLI7DmsLxg4xyc+OFsYqe1VmzNqj1DUPpqB1JD1yN7g8Y/mmOM1jftMstctfCGt19orbadNw33T dS6ehLA55kPJDjwR+6r9VwGKQjwrba51RYbxp+16M0/Vsn9d0dO2aVxaGYPGePK46q+Ha91Mmf4h bAe+Ook/0WLMeMvyuOVtu/SubmEJAKYdwdmLro+xOulXVUk0TXBhbET1DPlRCR0vxhYbdDoPTNVq zUdJaKEtEs7j8zjgBo5J/ZWIrdmNDWWWGlu2op6aqe1p9N/Tk547491XjQ+oKzTV+pbrbHNZU07y W9YyCDwQfuFa2Kv0luxR2t89WbffewjGBJlvOOeCM8qzXe2crrWkf6u2LdR36101knE1JXO6GvlI BaQCXH9gt3cNldE2uqio7jqSWnrHgERyBuTngY/VfTcHVOstLXq3C5Mp5IKKUyU84iw2UFpBaT2B xldM+TSm6ooJ6e4igvZYHGFuPUPTzg57gEd1qY6v7G9zcR1etl7XaNYUFFcLm+C01hLYqhwHUX4y GnxyV0Vw2I0rbHwsrtQzU5nd0xh7G/OfYLU7lXLVDr5a7XqJkL/w9ZE+GeOLp6wZGj7dlL24NqtF wqrO+63UW+ZkoEILc+qcg9P7gLpcZLq/TnMrqVCdbsrbrfrOO23G7Glt1S0mmncwEyO4+X2BXTz/ AA8WVsnoR3mU1LmF7GlgBcB9FuN4ZZ5dZ6WhfAWRx1LSyTqBDx1tGceFs906qen1vo78NK+Ivm6H FhxlpcAQsZTvX826eP8AaT+3SqGu9HVumrvNR10RY5jiA7HBHuFxz2EEjB4Vzt9NH12sb3bKO1si dMyB8jutwbxnCiaX4e9WOz/c0eD/APNv/eVzxk1Z8sePK3cs9IHIWJau83F27uuh5qWG7siDqhhk Z6T+oYBwuI9Nx4XPbo+IBz9FkGrItLSeoJtPIP1CbVIu0O2dbr26FrZBT2+HmafGSO+AApbp9gLL UVLqaDVUUlQ3IMTA0uyO4xler4RRi0X36OaP6ry7WymTef0zn5ZKp2fsDhTHKZeLLyfV0meNx8s8 f3Nob1boKtsOoX2yWMmbrDY/+PJw391vtdbTz6P07a6urnL62r/3kIbxHxnGfKnbV9ZpSLcOoZqW innqMwCB8Z4aSRjPI84XR7sVemKalom6oppp2O6vSEf+E488henHDH8nHXWv/wAPNfJb45ZflXHa XaeDXFLUyyXiKknhk6Pw5Zl5bjPV37LnNz9EHSeoqi2xTfiGxAHr6cdwpT+Hh0Z3Mq/w2RAaeQta fA6uP5KWbxo/S991dXw3UMq7hUt9VjWu/wB00NAwQPOeV5/Hljyzxy+Hq8uGWPHj8xRV1NLk/KSn +Gl79Jx9VbXR+ytlfe7w+6g1tPSymGOEfLzgHP14K6iLabR9Y2WJmnp6R3SemSU8Z/Qrdkl0z3ra kXoP/wAhJSMEg5LDhWu0LtrpOquV/sNxpjPd6OUlszvyiMgdOB910TdptCzPltFPTh11jg9R7w8u 6TnGSPHPhW4yXTH5P15RSp0bjx0n7L1fw6pjp/VkglazwS0hdbrPT7dOatqqEuDxTTdJIHfGCph3 L13pW+bbwW+1gCvaI+oGENxgc8/dZ8mNw8nCtePKZ+PmrI8YP2SAXpnLXSu6ffC+WOFlp0O3+m/7 V6oorOKuKj/EOI9aQcDAz/NTPqP4f32GxVdwmvdO8QRl7W9HT1EeByoP0g9zbxSFpIcJ2AEfcK3n xAPczRVsAJAMjQee/wAq34Jz8vBPPfx+KZ/aKNFbFS6o09TXWK80rRM0kxNbkx4JGHfXhe64fD7P Bbqqoo7tBWyQNyY4WgnPsuz+FyV81vvzHO+UStA9hwV3uiLM3TdJfZfxsVwE8zpS2m+Ys+hHuseD yTyS2/F01/kYfiut/G0D6U2EqL7ZYK8XelYZASYg3LozkjDvrwvtdfh9qqS21VXSXSCtfC3PpRNy SfbgqUti3GZuojlzWvqSQHDGMg91s9M09Fom03uW4XWknbJKZnCF+S3PGCPfK1hlyyymvV0526xl 37iE9N7A1t7stNcG3ekZ6rcuiDSTGc9j9Vlevh+rKO01FXS3GCtdEM+nC3JJ/dSnsFUCutWoXRux G6rd058ZHdbzRlnOk9O3l81Yy4CWV0pFL/eFufGPdbmrlqfaeXeG9/W1G7lQvoqp8UjcPacEEdl4 w0PlDfddTrhzX3mpeAQDK48jB7lcs09L2u85V82E8edxieLO+TGZfaeNL/D5cLtYqS4svFGWVMTZ AGgnpyM4P1Wd+2CrrbaJayKuhrDH/hhGf3Ul/DQX1O19Wxzz1Goe0Od2Ax/RdNpe0v0pom6NqJ21 4ke6TNL8/cdsKeK8tX+s+bO4Wz6iErH8PVbcbRT17bvShkzA/AGQM+Mrz6i2FuNrtUtbT1sNY1nd sIyVMeybHVWhLvCXBmaqVjSeABjhe600Q0NoKvZeKhkrZ5HFj4ckO6hwFuTWev6zlnlfX0qZpLQN 01PfW263RfN1YkkcD0xDtkr1a026uOlroaSqb1jOGyhpDXK1VstR0loRlVpe3OqbhWsbI4gZfl4z nPsE6u3zat0PNJqm3OpLhTBwa7GHO6Rnq+x9ldY2/wAa5ZTq+4gG6bF3a3abjun4mKcPY14ZE05A IzyvLpXZm4XzTtRejWwxQRF7TGWku+XurXU1fR2/S1qdcHtbDLBDD83bJbwCsZrVR2fTd0jt7cQT Nkn6RggZb4+i5YydbjeWV3ZKqXofZ656sqKl0L2UtHB3nkHDznsFvNSbD3C0Wp1bFWRVbGkAiIZw Pcqa9e1T7DtVSSWnppjJHH1hg/N1Nyf3UKaQ3Tr7HRV1qlidWUlS0sja6THovceT2OR9F0yw1PyT 0mNuWf441usNmK/TOnI7pU1sEzX9OGxsIIyM+6+OmNm7he9JS38VtPHTsDz6eD1fKcFWX1rYJNS6 Ht9Gypgpstjc58zsDHQvPZbH/Zva24UH4iGp6WSu9SF2WnK5yzK+Pj83tjO5YY+Xd9elH7pQmmqH xk8tJH3XmpaZ007YgeXkNGfGThb3VgIuZx78rwWQf+l4AR/7RmP/ABBXzyYZZSfDp/jZfkmO/lJe rdmK/S1ghuNTWwTtkA4jaQeRlfbTWzFfeNIOv4roGQBjneng9QwcKyWu9OP1JpWhpI6mGmw1hL5T gflCVjsZ09tdU219RFUGOKTMsRy12T4XO5Szx2fPsw5b8kv30qVpLbi7aovX8Pt7A1odh8zgelg9 yvlqzQFdp27fgaoDJIa2QjAP1VvJ7fLpHSbGaWt76isnA6ntGXgkZySBzzwtdqu1N1VoGS4323mi uUEbnFp/Nlvv9CuuPDLPj8J5LlhjuIfo/hzr5aVk38YpHMc0OLmj5e2e68Gpti6+y2s1kdZFVRg8 lgyGj3OFOO3FK+v2hFIyRrXyMlja55wB8x7lZXCJmj9sJbfdp2vmka+NpjBcC5xyB9lzw/bKT+r5 N4b79IfpPh1r5oGym7UjmuAOWcjBGe65LXm0lfpeeFjpWzxSYHq9OGtJ+qsFpKV42Rle1xDhDMQf b5ivrRTyXvZ2epuxFTUMhlw97Rn5Tgfrwt4SXVvzdMea5Y8pPcRDR/DpcZaZkv8AFqNzS0O6m/lx 91jX/D9WUtBNV/xOnkjib1HpHCmjbmldXbTtpWvDXStlYHOOAPmK5TV15foIS6fp3Pq6OqiHQJX4 MJJGSMDkfTjusYftL/F8l4WT7RfqfYy5WSyiv9eOo4BLY2ngYyvHZdla+5aQdfnV1OyENc70+klw DTjn9lbWsrqOmoaCK4ECOqDYQHD5SS0Hlay82untGiLnS0gIg9N72jwOrnA+i149ZXGX5rPlzuMy s+FBLpQ/hKh7O/ScLXEYC6bVrR/EJh4yVzTlry4zDO4x08WdzwlvywQUkeFzdDyhJCIB3R5QhFLy hNLsgCEBNY+UDRlGfCEAjCPCfZAghCEB4QjykED8pZQjCBowPqjwhB7mhfTCAw54wsg0+VxrRN7d l638Wms/+drzhvb2XqlB/hNbxwGhQcwz8o+y+Mn5l9o+2V8ZO63BghNJVAhCEAhCEAvrEDnsV812 W2mmhqW/xUj3Bseep31CDnmwVHR6ojf6f+YA4/dZ/h6gRCUxyCP/ADdJx+6ufX27T2gtHF1ypIHw BuAx8fUHuxkD9fdebaqXTeq7JURR2yCONziPQe0O6foPommd7U6ZFO9uWRyOA7kAkL6imrHNyyCY j/lOP6K6uitvKPTldXtNJA+nlkL2AtBAaTwAtxYG2SuuVdTUVFSywRHpJ9PHS4ZDgmxRJ0FYG/NH MPu0r5vZO0fOHgfUcK+NXJY4Ly+3XGzwRQEN6akx/wB2S7s0nwV6ptFaeulJV0dTaqV9OQB+UcZH g+FUUC6ZGguw/A844XzHWc4yfsrxaO22tdhmqbfPRQ1VI/qdE+WME9P+U/UKGpp7HobeSupP4dC+ 1yuaDGWg+mT3x9M+Fccdy2fCXOSzG+6r/I5/v918Hd1bLeXaC236xHUOjoGU9bGwyyU7eGTNxk49 nD+aqjM3oJBBDhxg+FNfLcvw+J/ZCEgoo/RZEpIQZMJ6hjK9kc0jG4a9w45wcL66fpIqy6UsFQ7o ilkDXO9gSroWvQektO6L/iNbaoq6CGLrc5rA55Hk/VWTfUS2SbqlTKiZjsse4fYpisnY/qZI8O9w Vb+67Z6L1/pCWt03Ssoaos6oZmADDvZwCqvetK3e0V5payimbJ1+m09Bw858e6SXW0uUl01T7hVO Ba6aUjz8xWMNbPCf7qSRn/KcL31OnrtTSxx1FuqonyHDA+IguPsFm7TN6bP6LrZWCU8hhhdk/ood NeLjVMcXR1EzXHklryCvI+QySFzyS48kk8raVFkudPM2GeiqI5nnDWPjIc77BZv05d2v6HW2rEnf pMLs/wBFV21DcjJC2NDeK6iYW01VPC09wx5A/kvnU26rpXhlVBJC8/4ZGFp/mvuLJczGHihqekjI d6TkUVN9uFUwsnrKl7Dz0ueSP2To9QXOhZ00lbUwt74jeQP5LzPt9U2X0nQvEp/wFhB/ZAt9YXln 4eXrHdvQcqJp6a7UVzrojHWV1TLH5a+VxB/TK81FXVNHO2almkhlHIex2CFj+AqTL0GJ/X/l6Tn9 lP8AtDsrbtSaYnuF8dLmZpEfpnpdCR5+qJbJ2g+5aovFzgEFwuFVURA5DZJC4Z/VeO23Srt1S2oo qiWnmb2fG4gr0aptDrJfKygc8yehK5geRjqAPBwtQDytZY3G6pjZlNxvrrq29XanbBcbjVVMLTkN leXAFZWPU95srXNtVwqqVj/zNjkIB/RaFjS54ACshs/sjbL/AKZZdb/LI+KdvW30nEdA9isrpB97 1der3CyG619TUxxu6mtleXAH3C+7db3/APhf8Ndc6l9CW9PoueS3HthSdvPstFpa1MvunKg1VpOP Ua45LM9iD5ChExPbkZGFUmklbf7l1VBcKWm1FLPcLFwyWme8kBvuPsrRWC6aXFwo7laNWtiofT/9 QlqAW8jjucjHsqIsjcw5GML7h8oHyu4+hRLInD4m9X269ahpWWufrkpcsc5hBB5yHAhcLQ7v6xoa WOnjvdT6UY6W9RBwP1XAylxJLzkr4nkcZWss7lraePxzCdOn1XrW96q6HXitkqSzsXYytBBPLE/q je5jvdpwVImyO31Jr++1FBW1MtMyOL1A6MA85+q2uo9pmWTc+g01LWulpKt7emZrcODXZHb34Um8 t6+C2Y2S/KIZnSTSF8hLneSe6XbxyrSy/DPSR3WGnN7lNPMxxYfTHUCO/wB+6jGv2pdQbpU+kqmt HRO9vRUNbz0nODj34TV1bF5SXVcTpDVN10rchX2Wqkpqjp6SW9nD2I8rvf8At71wODcQf/oYUgu+ GaNl3/CuvrhFJGXRv9IZyO4Iz9QuRg2Cvo1qbLWHooh8wrWNy17CcZA9x5Cio21frK7aqr/xl3n6 5S0NwBgcecDyuvsu+usrVbIKKKvD4oWhjOtgJwO3K8e8m11Tt3XUzHVjKylqGkskDekgjuCFGeOx 55Vu57TDjr9XQ6o1NW6lvsl2uHQKyXHU6NvTkjz91INr3+1nQUUFKKqKRsTAwOfGCSB7rxbP7Tzb i0lwlhuDaR1KWgNdH1B2fr4Xn07tZWXTcWo0nU1TKaphLw6UN6gS0ZGPuotcZqi+VGor7VXSsaxt RUu65OhuAT74WqP3VgoPhtuktxrqI3WmbJBG17HdBIkDs4+3IXL6b2Q1BdtSVVoqmfgn0xLZJntJ aD/hI+h8FL3Sak0iqiqZaKrhnp3lksTg9jgeQQcgqZ6X4jdWxUjIZRSSlg6S58fLvuuC3K0HcNB3 91suRjkJYJI5Y+z2nz9FxvQc+VfRe+kq6O3mvelq+5TWyKmbT3CUzSUxb8jXe7fZfWTeq9nWjNSQ RU8VYIvRczpy17fqFEuPZZek4DPOE5W+04zpL7d8tQxatdfoBBFLJGIpYACY5AOxIz3W8n+I6/yV lPVR0VHHLGC1+GnEjT4PPhQGOePKeMfdLdrJIly37x3K263rNS0VDSwzVsYZPAM9DiPP0K9Fr3ru lt1lXaghpKf1axgZNCc9Jx5C12gtm79rWwNutqmoTCXlhZJJhzSPcYW7uXw9awoqCap9KjmMLS70 4ZSXOx7cd1ZlZvXylxlst+G2tXxGXahqKt7LXRyR1Epm6SSC1xAB5/QLS2Pe+52fV91vcNDTvbcc GWnc44BHkFc9oraXUmrG1DrdSiOOF3SXVBLAXZwQOOSPK3d62D1jarZPWyUlPMyFvU5sEvU4jzgY WVnSPNc346n1TX3d0IgdVyeq5gOQDgf9FonEDkqUtObKar1FZ4LpbaekkpZs46p8OBBwQQnqHY3W NltM9xnt8UkEDep7YZOtwHk48obdDt5v1PpbS1NaJLTTz+gOhsod0lzc5AP8159C72P0vdb3My2s np7lL6vQXkGM5P7jlQpIwsdzngrDOT3K1vrScZbyWS0/8RcdqpX05sEDh1uLXRydJ6ScgHjnGSvf T/ElQU0Ukcem2RNkzn0pOnJPnsqvZ55z+6B+6m7vZxiTdvtw4dKa0qLxJbY62mmLwYZCA5oJyCDg 8grst0N6LVrfTU1BJZHRVeWuhnLwfTIOSoAz9SlkZ7lXlZeRwnU+lm9HfELa7JpuitrrBh0EQjk9 J4DXkDGcY8qEdZX2iu2qa+5Wyl/CU1RJ6jIM/wC7J7gfquT5Pussn3WJNN223tYnSm+ludpOnsus rObmabAjkBGHNH5cg+R7r3ah33tD9NSWzTtldQNJwY39Jjc08OGB24VaPr5Ta7JweVqZWaYuGN7s 9rWWnf7Ssdgjtc+n5mwGPoliYW9BJHzYHsV4tQ716UqdEXDT9stdVRxTU7oowMdLSfp7KsPVj8uU urP3SWz0XDG3diaNj9x7NoirrZbtbX1MsuDDPGR1R8EEc+CtrutuTpnU11tF2tNDVRXGmma6ZzwA Hxg5A798qBOrA4R1nym73/W51ZfpPW926lo1vbrQy1QVUNRTPc6VsrRjBbjgg88rdRbxadn2tpNP VVHVuqoWRRyMIBY9rXAnnPkD2Vay8lMP47qW26/iy2Y3H7W/q969v7lZBaay315oA1rRF6YwAO3I K5XdfdHSuoNu5LDZIqmF7HR+k17Pl6WkcZz7KtZc4jGSjrPbPZawzuFljGWMymqtL8NM9hstiuV6 q7vTtrpS6OSlc4Nc1reQQD3yoJ3RvFLftaXq5UJcaaqqXSRlwwcYH/RckJ3taQ04z7HusOou7lc5 jpu3fsyV1W3GrJdHaqorvDE2UwkhzT5aRg/yXJ5TBTWyXXpbi7672p1Nc6W83j8R/Eo2Mxw4BvSc gccHBJXm1VurpC/6ts1NcPUksdITUfiGtIIk6SACPYEDsqpskc0cEp+s/Pfutbt9s6Wm3p3A0Nq/ RM8dJXyyXSnAfSt6CMuyAQfphRFtBctN0Gsaeo1YZW0kTS+J7CcNkHLSQOSo2Ep8p9ZyPolts1TW lytT652w1RV0NTdbk6R1G4ujaWkNOcHkeey5Xcbd+3UWo7HcdH1bJ4qaN0U0IaWtc0kHpx9lWAzv J/MsTI4nJKTL7ThP+lvarVm1eqLtbdQXSobDcomtc6JzOCfZ4xg4PlR/uxWzbqanbFo61zVlPa4P RL4eQ5pdkHHgfRQH6rweCQPuum0Xrq96Oqpqix1hp3TNDZARkOA7cLMabiXaXWPB/gFeMf8ABwuw 0BctSbQ3SOru9oqo7XWERTslZ09WPLT7haz/ALftadPNyiz/APOWrQ603V1DrC2xUF5qo5YI5BKA 2MA9Q+oVNLCm4bT1WpYNSuuNKKrp6zA5p6esjuRjuFC272qbXqrcP8ZSvcygDY4JJBzw1xy4fooo dO4k4P8ANYmR2c+Vr8l7/qSTHWvhdhuoNvZdAO0zBqOnbRmARNLn/OOQRnj3Ud7B3DStmu1xuFyv bIK+KR0UbZOGPiIwCDjvlVubUyAY4Kfrv8rlxnGY/Ddzttt91a/T+srDTb4XisnudOyiqIiI5y75 XHojGM/90rc6Tv2jqXXupb1Pf6dlTPP6bGl3yGPobgg455BVN/xD+ruExVSt9j9yrljM97+WMeta XSpTt7T60rNRTahopqyof6jA+UAQuwBluPOBj7Ktm7Nxo6jci9VdvfFNTOqzIx8Z+V44PBXAOqpM eF8pJXPHzYCtu+lk1dp63W3TsOrNu7daqKnnir4HRucJGDALW4OCoEccnKWSR3JSPZJNdLt9YHf3 zf1VtLLqGyu+HWSjFypRUNonMMRkAd1dWcY91UXOCCOCvrHUPa0gE4+6mWEyymX0TKzG4rVfDfqG 1U9tv0dbcKemlfI1zWTSBmR0kZGfquns17sGtNvq7Tpu0VBNH/dPfI4cAPyHDkZBwqYx1MgJ+qyF ZMw5a7B+hwnjn4/R5MvyTVXU0oNP7aaTuvqX6nuLHyOme6JzS7JAGOkH7KnWo6llZcppYyehziRn 2yvAa6Z4IcePuvg55c7JVxknpN7fWBzWzNLuQO4VwaZumdxNsrXT224W63VEHQH+sGtexzW4cMZB OVTjx8vdeiCqlhHyHBPscLU6u0s37XLq5LVoHaautdTeYKx8jJWMdEQSS9uAAM8AKLfh+oqOv1r/ ABOe409KLc3qbHI4NMnUCDgk+FBMlfPK3pkeS32zlYx1ckRyxxB7ZBwrllyw4p45+PyXyT5Wc+KK 3Ry/g73DWQSxOaKb02OBI5Jz37crnvhgtlLLqea7z19NB+AaWCGRwa5we0jqyT2UET3CeWPokkc5 vfBJKwgrJYHZie5p8lriFM8rnrfwuOOvSynxCWZhvtLd4aynkp69zKUOa8ERO7ZOD2wcqUWaYgdt L/ZWG60bpDTiL1+sdPcHPdUfkuc0rQJpHuaOQHOJ5X1ZfKxg4nfx2+Y8LWefPKZX3DCcPH+Ket7X E142itu1lHpl9ypjVzNhpY5GnLS4PbknB4C22ptNm4bXR2CkraZ1RTU8YyHjDizB9+OypFLeayU/ 3sz3gcjLiV9P47XEEGpl/wDwhVw8tw1r4Z8njmcsvy+97qZIbi/5yHMfgEHsR7JnVF0DOn8dUkfW Qn/VaSaV0knU45918yclYtWTUbit1Fca6lNPU1c8kWc9DnnGfstRnP3WHbsmDhRXebLVdmpNfWx+ o2wut5e5r/Wb1MBLcNJ/VWR1ntZJcdS2+7aVkoKGkYI3ktd08h2SW49wqbRP6Dlbmn1PdYGBkVdU Ma0YAEhVls3PtMsZdX6XV3AudgivmmKC/S00obMTJHMOofMwhrj9MrndW7W1lRqulumkjRUVIwxy YY8tIcDyRj3HCqLU3usq3iSoqJJXjy95JXvi1bd4wA24VIxwD6rv+qnqaaW+3RoW6l1HYLTQTwGv gk9eRj3YIY0g5+vZbbcTStwv1zstTbjCRSyAy9T8YHU08e/ZUmk1NcnVbap1ZO6ob2lMhLh+q9jN bXwkE3KpOPeQn/VdJ5bL/wCtMcItxr2iOote2Okts8LqmgPrVDHP6SGh7Tx79l0uqtKsvWpLRcai Z8UFtBlBaRy4HOCMdlRk6ruTa41bayc1R4MvqHq/det+ur89pabrWEEYx6zsf1WOe7v+aak4zUTV vpuRDLf4hp+qlZJSsdE6eJ+A7Jzxjwogl3L1L14F5r/0lIH9VyNXWSSkl7suPc5Xkz+6XK3SY4zH 06O8amueoJ4XXasnq3MHQz1XE4BPYKyW3u31nOztRWXWzxi5GOV4kkYQ/A/KVU6CV0UzHtOHMcHN PsQpXvu92orxp5lpqHxRsDQ10kWQ54AxyszcymXw1e8bEcX2NsNZIyMDHUQB7LWAngDg5X1qp3Tv Lndyc5XwBx5Vt3dnpaT4R7jSMhvNBJOxtZKWujiJ5cADnC67Qugb3aNxjd62CNlEDO7rDwSevtwq f2W71lpq2VNDPJTzsOWvjcWkfqF1A3O1Q0f/ABbrRnjJlJUwx44XD4q55XPPn860lnd+5Ub9zWSt qIzC2SAOcDw3peCc/bCmTX2kGa6jtL6erayhDHOdUMHWOkjjHPKo7W3aorJnTTyl8jjkknklb607 h6jt1JHS0t2q4oI29LIxIS1o9gF6L58uXKfWnnw8GOOPG9rKbP6KdYtw7tU0NUyttlNGaf8AEAjJ eQD0kD2W50+T/wBul8HgU+f5NVUrXr6+2sy/gLnVQCR3W9rHkBzvcj3Tj3Avsd1fcm3KobXPHS6Y PPU4ex+i4ZSZcv67222W/C7OnKiM3rVVJFK38YKovEecOwY24K4W1aV17W18/wDE79WW2kYC5j2y 9ZPPbHjhVih3Bv0VzluMVzqGVsoxJM15DnD2PuvbPuvqqaIxyXmrLHDBaZDjC1ySzay+0Nkr6fWm pLjPVm4Urj+HbWOIzK4EEnA/ZRzvBcL/AKK1pXXKjqJaMVziWOY78zVEFq3F1DZ4nxW+61MMT3dZ YyQgE+68GqNZXjUhidd62SpMQwzrdnAW55L3/XO+KdfwXG81F5vDqq5TGSWeUGR7vPPJ/ZThunpj Rlu29pa3T/4X8c/o6nRTdRILeeM+6rcZS7B8rP8AGTdHS556fbKkus5nW7jLhwjGcNbM7pIWAWDn ZJPul1ZWfayadbttZay+6poqK2xGWYyh5GcYa0gkq2m/dnra7RlIaaIvbTEPlx/hAbjKpnpy911h uUdda6h9NVR56ZGHBGe67Ot3b1VWUM1JVXaeWGZvRI1xz1D2WvDl+PPmz5sfy+OYfSxPw2WSut+n 7pWVUBjgrnh8Dv8AO0AjP7rodsrNX2Cm1BLeIhTRTTmRhe4AFuDyqo2XdbU9qo46Oius8VNEMMjz w0ewXpuO7Wp7hRS0tXdZpaeUYe0nghcscJjLJ97dPJlc7u/WloNmrXVU1su9VLGWxVk7pIHZyHt5 GR+qrfuTBcLPf6imq2vhc57n9JJGQSVrbXuzqi2UUVLRXWaOniHSxmcho9guc1Nqy46jrjV3SpM9 RjpLney7YeThMpP/ACcr493G/S2Hw6We4UGh6uetgdGK95mhyfzNLcArZ7ZWmu05py/Ovkf4X1al 8rTIcDpI4OVVqzbt6ptFBBRU92nZTQtDI2Z4a0dgnd92tTXWjkpay5ySwSDDmuOVjx3hNN+bfk3f tpNbTNfdqgtwWmV2D+pXNMj65Bj3WdXUuqH9TnZXwa9zXBwPZdPL5PyZXJz8Xj/HhMV19hrHcLTt fNBV0zopahzpYmn/ABNc3gr3beWyr0/oO8Mu0RpXukkeBJxwW8KsNq3h1dQ0kFLFd5hDCwRxt9mj sFld929S3WkfTV9xfNA7u0lZwy4TX9TyeLnlct+5pZzbO3VVt26uv4mF8Tp3yTM6hjqaRwVjt5M+ 97bXBl1catkD3xxiQZ6Q1vH7Ks0W8Wq46NlILrJ+HawRtYeR04xj9l5bTuhf7XQy0lDXuipZSXOj HYk91b5N/wD12Txau79aWt17dayybYUFXbah1NO2KEB7e4HSOF8tuLzX37bO41tyqJKmcumYHu79 IHHZVWu+6N/ulqFtrrg+WkaAGxns3HZfGx7mX+y2t1uobjJHROLiYgRjnulylk1PTUwu8rflaTdp 3p7TUDj4ZB/5V99tLpVXTaapqK6Z07mNmia5xyelowAqt3fc+/3e0NtlbXOmo2gBrHeMdl87NuVf 7RaZLZQ3F0dE8uLocAj5u6meW+P8Jhq5X7WouscOv9toaeyStdLThrXxu4dlrcEYUfad2hho7Jcb vqcujlY0mniLujocDnJ98qENObiXvTtRPLa658Bm4k6exWzvW7Oo7zRimuFwdLCHdQa7HcLd8vXG ekmOsuXysrvW8xbbUDm/KAYv/KsNv3ufshVSOd1EsnOf1VZL1udf71aWW6417p6VmOlrvGOyz0/u Xe7bbRaGXCQWp7v7yEAH5XH5sLPKf8fX+tYywtx8kv8A5NNqUPfWvLRkA914rFC/+K05c0/7xnP6 hWCpqvZqpiY+YVZeQCQ4Hg+V92SbNRkPidUMc05BGeCnnynkytny3/jY/imMvw7je15g0Nb3g4w5 n/lC+23r3y7LGRxLnOjlOf8AvKve5W4tXdp5rdSXCWptEb/7n1e+MLQWrdDUdptX8KpLg8UByPSP IweVjLvHCT/xXDHjc7fmrY7t3y4WDSFHV22pfTyZYHObjkdP1Xz0/c6y+bOT1tdK6epmgl+d3cjO AqqX7c++32gbQXOvfPA3BDXY44Rad0NRWuzfwqmuDhQYI9I8jB5IW7lP118Jwv7b+VqtPUVVa9na qCsjdBUNhlcWu4IychfO1yyX3Z99Rc8VNQ2KToe8ZIw7AVaJ959TVFFJSTXN8kL29DmHHI9l5Lfu tqG32l9upa57aIg5iOCOTk/zWcbcdWfe1yx53K35Wp0zZq+LaN9ukp3srHwyARkc/M4kfyK89y9D R22D7Tcqhhq5Y3sa1nJc5xzjH6qt8W+Gro2BgukmAMBaHUO4t5v9THNcKt0skf5Xdlccta/l2nkw 5cr9rd6VtVfTbTuoXwSR1zopCI8fMCXZC5GbQtddbLU3rV000tbBEG0zCen0w13ZwxyoQg3t1fFG 1n8WkJaMZICxq96NV1VPJBNdC6KQYc0juFJlZNGXj5XdWK31kMWiqIg9Ja5uD7fKF99MXGrueyz6 y4TOmmfA/L3d8A4Cq5f9zr9frc2iuVcZ4AQWh3jC+Vv3N1FbbI60U9fILe4FvpHkAHkrUyk4X/8A Zcr47x8k/wD2mj1U8SXCU54BP9VzZ5yvVWVbqh7nk8uOSvJ3WvJnzzuTp4sOGEx+iSTJ4SXN0B7o QnhFJCaXlAIQjHCASTHKMIEl5TwgBAITxhLCAQngJY/mgEDughGAgDwl908AIQIfVLH0Czxwlyg3 fpkY4R0LbfhDj2WLqMg4x/Jcdt6rWNbgr61bS2zVmO5aB/Nes0xB7FfK6NDLPVjGOB/VS005GPIY vjL3X3Z+X9F5391uJSSQhVAhCEAhCEApa+HtzRrKMOIH92T+uQolW30/dqm0VsVXRSujmjOQQpRb b4mnOOhqUNBx6rST+i5f4brRXMfJWsnfHE88MPY/VZWTebTOodLOtOt6eQOLOlz2R9Yz7he3Qu7e i7DRPoJHVMcMR6YZhDkub4JHuumeUyxxn044YXHLK/acdRRVs9lq2WuZsNcY/wC7eezXdxlRzsQa sw3E3H/178RJ63bHVnlcnpTfK2QX64MvNTNJRPld6MvTnLM8cfZdNat3NAUlyqZqeqfF6p6i4REB xPfI91zt601Me+ToNwrpT19vvGn4Yn/xKSJhi6W5Duc8nwQt7pM1FLpLM4c2phiHUHdwQ3/3lx0e 6u3jbhJXfxF5qHgAl0J8eyVRvPox1PXRi5PBlaekuiPzEghanubTLcxuvbudD6lh1PZxOwFszSWu 4/NjyqobwsfLu5WBgJcZGN4+67/aHdXTligqaK6VDoAJXlkvSS1wJXPu1fo+bdmuudykdNQSlpin a3IafOQuuOUxmeP36cuOVywyqw1GMaAmH/3q4/8AuVQC74/HVGB/jP8AVWh3Q3qtFJYvwWkKhlTJ M0sMgyBGPq0jnIVVquYzSvkfjqeS449ysY5a8fF0xwv5Lk+Dkkykeyw7GEHskCmg9lvjllnYyBpf I44aB3JVlNtNxL5ou2x2/Wdrq5bPIOlkr2flB8ZPBCrhY651tudNWRAOfBIJAD5wrh2LcPRmt9Em 2XurhoZHsDZGS4BB+iJZtt63SUFRQ0t+2+rJaFr5Gyz0kTyIp2Hv8vYEcroNaUlPLo+KeWBj5myR Oa5zR1A9Y8rRwa10hpHS0kNFeaatjhjwyJkg6yB7e5Xzodw9Jat0x+Hku8VA/qa7pnIBBBz2ykrE xkereKGGm2ylrGwxGppxHJFIWjqY4OGCCt3puoF00JT3KqjiFSyn9XrDRnIblc7rO+aZ1VoytsTN QUMNR0Dof6gLXEcj9yuj0BCwbdwQVTwxhp/Tkc3kD5cEj6Lpbjwn25ay55X4eSego9VaIZca2mij rIozPFLE0BzHtBII/Zeq3uZVaIju0kEP4yKnMnWGDDsNzytNXar07pnRtRRNu9LWFsTog2J49Qkg j8uc+VvdKxRTbcRQzyiKKSmLHSHs0FuMrM1uNW3hftrK2wWfWOj6SuvNupjKGiYGNuMHGV8ddXik 0HpOjraS3QVMZLG+nIPB+qK/VOn9J6LFPLc4KxkDBGPRe0udxgfLla/UdVpnczR1HTQ3ynomgtcQ 9wDhgdsFdMOPL9vTn5fyXD9PbZaostru2lINRtooaa40jPxMckbB4GS0+4K3IbZodPRX6uoII3si 65HRxg5GPbytRf73YbXoxlorbvT9ErBTiaNwcBkYyQD2XsuItlw0DNaae80XXJT9DJPVGO3BPKxh q8Zl/wC3TO5yZXH/ANOc1fTaZvGnI9UWMULblQB08L4mty8Du17e5BH7Lq9tdQxah0fHdIqGGlc9 vzMj7EhUUvn4yyXmroJJsPhkcwljstP1HuFZv4bNd2afTA0/V1DaWujBx6jsB4PkFW3Hek45XHf3 ET79aqs2oqg0tNY46K5Uc7muqojxI3tgjChjyrU74aC0XR6bqbjFV+hd3kuZJG/rbI7vhw8ZVVHc OTyWXK6b8ONxwky9vbbDE2thdUNLoQ8F7QcEtzyMr9BduGWr/s/p3Wp0jba+HIDvzMGOV+fNsjZL WQRzSCKN7w1zyMhoJ5Kv/t7b6a3be09tguFNO0wdMcoeAHZCxPca8m+N0h/R1wkuet63Rbrkblp2 Vxmj6m5LeQQOe2D4Ug6yqdI6Tu9ttlbp2lqJKwhrHsia3nOOVBmjK1m3u87xqI+nGHGP1By0Bx4d 9lO+4ei362vljvNsuFJ+Ho3CUZdnrGcrvlMOeX/7nmlzmGGv/bUa10Tp7Tl9tuo6S10/o1EjKaop HRgscHnhwHghdRdNH6HsY/F19soIoalzQGyxjpDj9fGV9Nw46W6RWi0uraeCsM8c0bZHYEnQckA9 iV4N+rLW3vb6ZltDZZqcCVzGuBOGjJwmHHLjKmd8mPLU+UO/EntjaLRaYdTadYynhcQ2aBn5Oezg q3A4cAt9dNT3msozQ1VwqZKQcei+Qlox9CtB7FcLXrxlntYf4QRnWlf9KYf1Km3VmlrHc9xrfdam 9MprnTFnp0rsfNg5H15UH/CFPEzWlcySRjXupwGgnGefC7HcmpFP8Q2n/UeI4nGLqLjgeVfFjf2r l58v2wie7h/8X7OB4ZMT+zVAerP7z4lrRxyHRD+RUhb0aum0Y6wXanYJYxM9kjSeHMIGR/Jfe2s0 fqSaDXlO6N0kcYD3OPMZHIz/AJSP5rcmsLPtjO3LPHKfDr6jqOraPP5BTSkffLV8I9U2qS9SW31G fxCGVsXpEjrw7s4eSFyOgdd02s9b3KOkc009FDiLIAcST83k5HHdRtPMB8UFO17g0Fw7nGfl4Ct8 f65X6MfJbnjJ6r4fGITizjxhyq34bj3CtD8YhIks48Yd/VVdP5R1J5//AB/6P8T/AFy/7q2fwbj/ ANGX4+fUZ/RGkGl/xNXGQjjqlH7NCi34f9zGaGvLoa5gfbKwhsxH5mY7EK0FFY9MW++VGuoatr46 qP1I3dfyg4+bHvkY4+i542TGx3yluUrpqQn+2dzB8UsP9XL7UN4tdZWAUr2PqXvdA/px1AszkO8/ ZcpttqqDV94v1fSdPpQlkDHD/E0ZIJHg8qK9p53u+IC9wlxDQZzjPBOQrjjvG36YuWspj9u61lt/ atb7lSC8zdcNNRsH4drul7sk/MD7Ahcw/aXbCe6zWVtRVUt06SGxyyFpHsRngrqNW6Xud23LfcrB fIqC6UVMwtgkYT6rOTzz2J4PC2jLdJri31du1lpx9urA3DKyE55H+Jj8ZGD4Vt7XH0pnuNo2q0Tq qotFY9soaPUilb2kYex+/upo1Fd9vrvssIKZtFFfoqRrWj0+iQSN78+VEW6VgrtNaunttxqzWFje qGfrLuuM5wfp9lKmrtrNMM2cZqWx1MgrmUzJ3j1etrzx1DHhTKaaw7m1cCfmPCYOSPPKTsBxx7rJ g5GO+VhtaP4Op5XVN6hL3ek2NhDc8Zz3U1WC2XW16s1Dc7pVNNpmAdAPUz0AcnI8KH/hAtdZTwXO 4zQubSVLWsikI4cWnnCkzQl2qbjrfWdnq3CSip5mljHc/mHI+yuO9XbOXvp4dE67sVyvd70zFUth fLUSOpZ2OAbIHAflPuCtXR3G/wC1ktdVawfWXmxzvEcVTFJ1uixnBc0/lBBx3WpuWzdrrqC+XGzV dVSXSlqJjTxxuy1hby0Y7jK32yEmorpYrraNcUc8tIABGK2MkyNcPmBJ7hauvhzlvz7fLYW7Nut6 1jJRGRlrfUtnp4HcCPrznjsM48LrNKUl7tUuoqjUsznUEknXTh8nWGs5zx4GMcLmdj7C6xXrV0MV LLBQ/iGspy9pAc1pPYnvjK2W1st2lrNWNvJqTTirIp2z5wGcjDQfCeOWbl+2fLd+vpTDXwgGqroK UsMH4l5YWdsZ4wubzhdJr5jYtV3aNrQxral4DcYxyVzDl08815Mm/Bd+PFkXI6lgjK4ur6ApE8pA 5T8oMur6J9X0WCZQZdSYKw+qFBmTlGVgCmEGWU8rFBVgyBwsgvmEx2QfTOUsrHKMqDIn3RlY5908 oHlAP1WPlPwgz6vojKwR5QZgp9QXzTQZ9WEZWAQSgzJRn6LBMIMs4QTnwsUZQZZ4TyscpBBnlPqw sOUIMy4foguGOF800GQck45SKRQPJRn9UkuyDIFMHhYoCDPPKCcrFLKDIFMu9lgE8oGXEJ9SwPPd AQZ9XHCAfdYoCDPKMrDIKEGROSgLHKEGXAR1LAn9UuyDLKD3QkgeUiUFBQNp91lkLBCDPhAd7LHx lIIM+oFMH6r5poMiUBywzyjKBuKQOPqgpFBkDlB7rHPCMq6DJOUFJCaGQPKYOV8+/dNBnnlMnHZf PKRQfQOynn3XzHB+qEH0JS6sLDPKSIyJyUOP6rFIoMspdSWUFWEMlASCEVkCsutfPKCUH0BB78Jl +fPAXzz7poMupBcMLBCDMH6pEjhYlHhAyeyMk90kFEPOOVkH8Zx3WHCEGXVlMEBYHCWUH0yCg/df Pwhp5UH1a7CC7nI7r5nv3QqMur7LLq44XyA5T+yI+oI5wsM5KXlJB6BO9gAa4jCXryk8yEr4E8pj sivt6jnAglYZ5ySsMlBQfTq5yn1g9+6+YRxlAwOSss+MrDISPdND69QHlIu54XzCPsmlfQuQDhfL ysuFdIz6sdliSSO6xQU0An28peOyAjwgO45QglJA0JJkcIBIJ5SQATSQgEIKEBhCEIA9kJJoAoQU IBAQkUDQjwhAeEYSTygkswjAyOVgYhjtgr7h7SMZHCXU0nkry7ejTxOj+Y8LXajaG6fqT5Lmj+a2 kkgDjx5xla3U5zp2bH+dv+qs9s1w7B8pPbheZ/deiM5Dl53/AJl1c6SSEKoEIQgEIQgF9oWdXZfI KSNm9M0+o9Rxw1XMUYDy335Qck2y3JtJ+K/A1IpiM+qIz0/usjaLg2iFUaOpFMRkTemekj7q5etr vbNvNJNL6USOlBjib6Yc3qxwCM9kto71btW6dkZJSQMc/IdF0gtb9APZWyybrEyl9Ka0VnuNWwvp aOonY3u6NhIH7L1x6bvT2h7LfWFp8iJyu3o/RtNph1YGMjML3ueGhowAecBevSV1or1UVhpadn4Z jnNw+MBwc3g/zWdrFGJdP3mMFz7fWNaO5MTsLx1NvraaMPqaaojjdwHPYQD+qvlVXiGhu01Pd7bE y3FwayqEeWgnsHey2b7HartQVNNVUVNPSSHHSWAgg+ypt+fLLfWvpzOylqHQN7yCMlo/VfOmpKmo Lvw8EspAyehhdj9lfLSGiqLTwqbeynZPQPJdGZGh2Af8JUCU1/pdE7x3Omp6GE26eoEboQ0YZk+P 18LeONuNynwxc5Mpj9oAmY8Eh+QRwQeCF5yFb3fDa62aj08/UWn4YqK4wxmSRjR0smaBk5+qqHK0 sdzwfIWddcm5lLbj8x8z290h3TchRoeEBA5TQZsznheuNkpAcGvx74Xs0lTUlVfaKK4u6KV8rRIc 4w3PKvAyyWLTeiXXCls8FwggiD/TbGHOI9wfPCCijnSN4d1A/VfMyuHn91dK5aQ0huboyWooaOmo qtzcxyRYDo3DwR/oqtXrbvUdprzT1FsnOX9DJQ35X+2CibaSwXd9sulPVdDJmxPDjE8cOHsVaS0f EFpKKytpJ7bVxh8fTJE3BHbBwq21uhNR0UsUdVaaqJ8pDWAs/MfovQdu9VNmEP8AA631SMhvpnlN JdPdeNRWmn1265WeCSa0mUSCnqRk48t+oVg7bv3osWQUc1FWRMdGWPia0EYIwQCqw1Wj7/SVsVJV WmriqZTiNj4yC77e69H9g9Ttm9F1lrRIRnpMRyVU1NPNrStoJdR10thfObbI8uhbNw5oPhaSOtlZ +SR7fs7C2N209dbVKyK5UFTSvf8AlbLGW9X29162aH1JJE2Vlkr3McMtcITghFmmjkrZncOkkP0L kxXVAbhs0gHsHFbGXTV4ZVspJLZVtqXj5YzEQ4/YL6N0lfTKY22mtMjRkt9B2Qml6aNz3SEueSXH ye5WcM8kR6o3uaR2wcFbD+A3Q1zaR1DUCqIyIvSd1H9FZDarZWyXHRU1VfYJJKqaMkggsfC7HhJN 3SZZSTasVTcKmoZ0TTSvb7OcSF4uexW41Ran2e9VVG4PAikLWl4wSM8FacFayxuN1THKZTlGYcQM tW0pbzcIIRHDVTsYOzWvIAWthYXuwFa7aTZrTdXoyK7aghNUJY/WJ6i0xjGSFlbVXKqtqKiUS1Ek kr8Y6nuycL20uo7rTMDIK+qjYOA1spAH81M29+z9vs1qh1Fo6Yy2yXAkgJ6i3PYtPn7KD/4bWtbz TTNH1YVbLEmUvp6KjUNzqJI3zVlS90ZywueSWn6L7v1dfHMLXXStLcYI9Z3P81q/ws5cR0OJHcdJ yEjSTkfkJ/7pRXle8veXHOSe5Sz7rKSN7CerjCw4IWVe61XCrt1S2ooZ5YJ2dnxkg/uthcr9dLpU sqLjWT1E7AA2SRxLgB25XY7Gae05qXUzrXqX1wJ2gU7o34w72Kn257D6BoKqkp6uqrYpat5jhBeT 1O9lqfxm2T2qtddVXu6UjKS4XGpqaeM5YyV5cGn6ZXwt2oLpb6Welo62eGnnGJYmvIa/7hWTtnw7 W2LVtdRXOeeS2SRCSkljcA5pzy1w8+FHg2ut8G8jNKzVE0tBI75ZBhr8EE4/RWYXW58M88dyfaML PqO52Sr/ABVsrZ6WcjHXG7BIWddqq7V11ZdKmtnfXsx0z5w4Y7cqQ9+9rqLQFZRutVXLPTVDSCyU fMwj6+VEAbkAe5TKZY+/kwuOfePw3+ptYXzUsMMd5rpqwQnLPUOSP1Wg5LeymnYbai3bg0l1fcau emdSua1hiAOcjyvPpbaiGu3VqdJ3CreIYS8CeIAEgDIOCs6uXf01NTpD7OppyAV0cWr73FYHWVtf P/DS7r9AnLQfp7KwsHw12594rqF15n6Y42SROEYzh2Rhw+hC5bTvw9XSr1XWW27TGChp+RUxjl4P 5SAioo0pre+6UnmlsdfNSumAEgach2O2QsKbWt5pdRvvtNWyw3Jzy90zOCSe+VvN4dvXaA1R/DGV P4qCSISxydODg+Co/LHt+yTcTqu7qd1NT1F+hvL7jILlCz0hM0YPT7H3C3Y351uWEOuhJPH5Aon+ YnC9U9tq6eFss9PLEx4y1z2EA/Yps0+t6u1VeLlNXV0hknlJJPYD6AeFhHdq2KmNMypnbTuGDGHn p/ZeEAg4WYGSAlu+1k1NAHOfdDSc9uymjavZZmvdO/xGmvsMNQ2RzJKYxZLAOxznyulufw01zKKo ktd7pKyqiBPodHSSR4zngqey3XtHehd3NT6Otf8AD7TUs/CBxeI5GBwBPfC+tr3e1JbNS117pJIm 1VaQZ29HyOI+i3eg9ib3qaCslqpG2xsDzGPXYT1OBw4fTC3tz+G27w2uoqLbdqKuqIm9QgjGC/6A 57rU2lscdad5dTWq/V90pZ2CStd1zRublhd7geFvav4h9V1VLLTzMoyyRpacR4IyFno7YO46msTa +G6UsE/W6OWmlY4OicDjDvr+i+t8+HXUFvtFVWUtbR1stO3qNPDnqd74+qasTcazTW/eqbFbW0LH w1ETSS10zepwyc916br8Q+qLhQz0j46NjJWlpcxhDh9QcqGKqB9PM+OVpY9pIc08EFecnlO8aalj 0V9XLWVUs9Q8ySyOLnPJySfK8hKCUipd27rUmpoIxygBMd0ULJYphAwhAKEAE0kfZQPwn9UgjOUG QQl3CAgEwhHZUNCWUIMh2QkmgO6EICBhAQEEKA8oQOyD2QHlGeEZQgPZM8BHlHhAk0vZMIAJ/VJC B5R5STQB4QgnlCAQghHlAIyj7pIHlCR4KaAQkmgSaEIBCYRhAkBCEAEdkFCAQhCAKEBCAQjwj7oB CQQgE0k0AEIQeyBJoQgWeUAo84QUB9kIQqEeEIQOyBoSHZHlA0JIQCEBNEYjuglMpIDugcIR4QCE ZSQB7IRnhHhUho7ISCKChCO6B+UZSxkIQNGUkIGkjyhA0Z9kiEkRl3KPCSEDyhLshA0eUgjKBoz+ yCkUDygnKSOyBgoS7hBQNHlCeeVQd00kBNBhGUkIEDlNAQgEBCMoBAKEeUAhCMcIEn44QO6OEAlh MIKBeEIQgMIRlCAQhId0DR5QhAkx9EvKEAn90eEeEBlCSYQJCMo7IDCf3SBQgMIx9U/KWEHbCuPY nP6pfjfrx91ofXPv2WRmJHdefTpyrcuqi53B4Xwvs3Xp2oyeetn+q1rJPm7r7XN3VYp85/M1Ndm3 NR/lLvK87+69Dfyled3ddIzWKE0lUCEIQCEIQMd1M/w4zxM1U4PcGlzABk4zyoXWzstzqLZWxVNH K6KaMgtcCgth8U0L36Stj42ksFRhzgMgccZXk+HPTlRS0bq6SSWJ0pz0ngYC561b6Wu4aXfadX2q WrD2dJdGQQfrgr36R31sFptrqGagrRHH8sL2hpIHjPK1llcpJXLHDjbftPOraKpumnrhTW2rNLWu jIZKOS12Mj91xGw0NTFZ5o685qxJI2UnuXZwSox0NvrTWisrI7vHV1VLJK90T2uBcGkkgEE+F1tu 350fT1U8raKtj9R2ctY0ffIBWLNzTc97dNrq5Taho7vpukophVmRgjmAAZgOzyV11p9W36Rk6gWT U8LuoeQ5rVG0e+uh455KhlLXeq/8x9Mc/wA15avf3SklBWQGKuBma8NPpg/mBHutdWszGyJS0DqT +0lhiqHtLZmjBPh2OM/dVR19Ty1e8tY2Bhe41jThoz2K7Pa3euy6coJKO7Q1AY1x9N8bc5BPGQtN Z9ydMU24tyu9VSTy0VS/qZLgdbP0XTCyYZY35c8sbc8cvpYe9fJtvVjGHCmfkf8AdKoBXAfiHnwS rE7t72010tYt+lHPZBI0tke9hY5o9vqCFXKd3W4uUlk8UwXHC/lyzvqvk5IoPlLwubuaZSCYQbCz 0lRX10NNSMMk8rg1jAe5VkdC6v1ftpQRU2rLPUT2VxDWyk9Qjzxgntj7quOn7lJabpTV1OAZYHiR uexIVtLNu9ozVmkf4dqqV1KXsDZYsEh36oldTc9G229x2/Uul80FRG9s0sURLGTNPJBHbK6PWjGv 0xRyFoLvWhwT35cFwtXu1o3T2mpILDX/AIt0bOmOBwIzxj8yVu3e0ZqKwQU94rjbpmFruggnBHIT bMmm431mdRbcirh+WohdG+N/kEHwunt9W+o0E24TO/2mOlMrZB3Dg3I/mo91trXRmstLVNnN6Ecz R/cvawkOI7Aj6rv9PspztzHHXvLKY03TI9vcN6cErpylxwjz3ljl5MnxqQy/beMuNxja+rjpzURy NGHMeG5BB8L6ur3v2+bdpCBWQ0xka8D/ABBuVxl+3H0ta9IyWm0XCO4PMZgbE09LwCMZ59l2tLFR SbbtiuUhho3U/TJIO7RjuszrOSt55W+PKyvlV0tFqLR1vrb1SQVEoDZRlg4d7j2Wp3T1LNofT9tq LVFEfVlbG5j25GDjstTftz9K6f0rHTW+4w3P0sM6GHD8dgcL4XzVWgtw7BQx3K9x0ToiH+m52HAh dMMsZlvL0xnM8sf1rptcQQ1Giob6+JjLjSdM0UsYALScZ/RbqvudJbNKNvtdAC+KIOkMYAJ9/uuM 1VrzRzdNxWh95ingmIifJA4F0Y4wSPZevUGpdH3nRE9nj1PRN9SHobIXjjjyFnG4/rL/AO27ynK4 tZrXUumLppiPUFnraNt7ogZYCC1kmfLXN8gjwuz281FPftExXWojhjmkj6j6bcAqg94L6K61VO2o ZMIpHNEkZy1+PIKs98Pu59jOlxYL1UMop4mdLXyOw1zff7qbkv8AGrjbjde6h7ezXB1ZUilqbVSU 9RSSuAqYRh7h2wVFGFZ3fe37dR6ZfNb3wOvDzmGekeHEuHcPbnsVWI91fLlMsrZ6Xw43HCY1sLFJ FT3KnmqIhLCx4c+MnAcAeQv0G0jNa5NvYp6SB8VtfTFzos5LW9PIH6L8+LGynkudMytkMVM6QCR4 GS1ueThX10rcNOU+h4bVS3+hfE6AxskdIAcFuORlYn+0XPfG6RFthWQXjcOu05S1tRVaYb/tFPFK MFjuocfoVJut9U0mmdV2eyMs9HUtriGl724LMnGfqq/6EvdJtzu/UNuc0c9J1GEzwuDmhpOQ4KeN YWGyax1HZtQU+o6KJtGWyNZ1NPXg5weeF1txtrnjLJjr/wBvprLT9osOorRf7fQwRT1kzKWoh9MG OVrvJHgj3XQahi0tpaJtTWUVJTsq5A3mEFnV9fb7rVa4u1iutys1qku9PBUwzMqmPJDmP6fGQeCt Zv8A0MepNBSttlwo3VNN/fCMSjL8DkD6phxuuSZ3Ob19ov8Aig0Xp+C1Uup7AYIpZXCOaKAtLHgj Idgdiq0YAPHAXsq7hUyNML5ZDHnlpJwvEVy9vSknYXP/AGm2P/56rj7gzaeoq6z3HUdc6jdSTGSA 92udjkHhVS+Gi1U1w13DPPXwU0tHiWOOTj1fcA+MKcvihtM120hHW22WKUULjJLG14Lun3A8rXi/ 2u/Tj55eM1Pl2+mdZ23VWr5obS9s0NJT9XrsdkP6j2x9MKJ6hpd8TtMcZaCMn2+VQVtnr+v0VqCO 4UbuuMnpmhJ4kZnsrdWe/wCi7jQSa7pzA2f0gJicF7XDsCO4OfK3jlJjlj9sZ4XnjnPhFnxhkZtQ +jj/ADVXWnlv3Un74bjSa1uwYxrW0kDj6Y7n9/ZRaDgA+VfPlLxk+In+Lhccbb81bb4OAP4XfyD/ AO0Z/RY6MJf8TNyd3bmUfyChrZXcqp0FfPUwZbbUECoi9x7j6hWxoq/RtHS1OuaOSn6Kpgc6XOMO A7E+Cey545SY2fbpnjblMp8OopD06zuZPb8LD/Vy81m1labvcvwNLIw14kkilh6h1s6PJHsVyu0W s2a0uF/rssb0vZHEzgODBkjPv37qNtq52R/ENemSODCTPjqOMkkcJr9bUuV5zH4qR79pjTup90pY 756U9RBRt9OkkaCJGnOXfoVoa7TG2cd5ntF104bZLggVEremPkcEOzhbTVemKO/7oPmivM9svlNT MfS+nj5wM+/jPddJbrbe73b621a7t1DPSvb0tngP5h7lvg/Zby4s48vale52mKTSmrZqC3V0NdRO b6sMsbg75Tng48hS3fNzdJX3ZZ1hnpXsu8VK2KPqiBAe3GHB3hRVurp6l01rSrt9HWsrKVvzMe12 S0HPyu+oUr6p09t5XbLfxGzvoor7BTMePTl6ZHPGOoFp75XLKarvjeU2rTIf7x2Fk08D3ysHD5ys oz8yjS0XwdkuuN7yTgQs4/UqcrDp8WXUN9vrquOanqQXFrG/Mzp5IJ8kYUS/CLYayltVfeJWNFHW ARxODgTlp5yPHdd3txcJ5tyNb0EkrnU0crXsiJyAXDk4Tx48ZlWPJJnnj/Gk0nufYrlqS86fq5fT oa2Z7qapJ6Q7qABBPgr4w2q87S01xvNoLdQWWYjrhDz6kDAT8wdz1d+V9LltbpjUdFqN9DAI71HU zdPoyY6H8Fo6e2CthsTY9RWGz3Ok1XG+Kky0wRyvDgAR836LrK55Y/8A1a34erv/AB676vuDGGKO pnZM2PqyG9WSRn9F12jLBUacrNS1lVWR1UNVL6rGROLzGMngj35Wr2e09NZrvqqeOBkVBV1IdTFm OktBOcYX020tVys1z1dPd45IIKiqEkD5D8pZzyCre7f+3HK9evhTXcUxS6vu8tO7MT6l7mnGPK5X yus3IHTrG7t9ql54+65Ry1/k/wDy12/x7vxY1j3+yEEcIH3XB3MIwkj/AEQZJJBMpAwhJM9kD5yj yl3QoGn9UICACflLug9kDyhILLKoEBCCEDHZCXhNA8oykmgBwmkUAoGnjKxyjOE0HwgJZwnnKgaP CPCSAwn4QkgYR4Qkgy7IWKyQHdMeyxQgySQkgaEvKMhAIHI5QUBA0ggcplAI8pYyj/RAyjKEdkBj lHlH7JIMsDCSEkDSHKEIDsmhCABQeEFLKBo8oCECTQjwgSeeEkBAITHHdJAZQEYSQM90IQgEJBHZ UBRjKYSQCP0TykeyBkpZ91jymiDKO6RKfhAFCEj3QHhCEIBBQjzhVQSkE/CRQMIKAhAIQkgZ4R4y gowgAnlJCAJQg4SQMISQiGhCEAmEkwgCknlJAFGUFABQMIGEDGEIH3QeySY7KgQhH+ibAgo7BCbC QnnBR4TYWE0AoTYEIKE2EUwUdkeE2BJPsgdk2EgoRhNgQhATYEk/KE2DOUIQU2BBQAhNgyl4TwhN hZyjsgoQMpBCPCARlATQJGEIQPCMhJGEHvB908pBA7ri0+jO69Fx4sM//M1eVpwQV6bjj+BS54/v GhCNARwV5n/mXpHA8rzv7rUKwQhCqBCEIBCEIBfenic9wDQSSeAPK+IGeylzYLTdJfNRZrGdYhAc GntlByLtFaibbxWG01ZpSM+o1hcAPrjssZdH3+G2/jnWyqNH09RlDCQB7n2Vtd19W/8AZ7pykZQU wfNWOdCx3HSzAB5HnuvZs7qGHVWl+iZsTZntLZGNAx29kY3tT61aSvt1pjUW+21FRCOC6NuVsIdv dVSx9cdmrXNPkMV1dN6dg0vTVAgILGl7w3gZ7kD6eyx0HezfoKipZG6OJ5cRG4ctI8Js2pTNoHVM IzJZq4A/8BWvuWl75bqYVFbbqqGDOOt7Dj91eWqv9RaLnUC+RMFqM3pRVAAy3JwOoLdsoqK6W2aG piiqKSYub0loIc0ptdvz9j0zeZrea2G3VUlIP/asjJAXwtljulya82+iqKkM/MY2E4V+9MaZh07D NR07Q+hJzGCAekf5SPoq4WrVkmlN4btTUsLBQ1FYWuiaABknuFuY7xuX0xfJrKY/aAquGanmdDPG +OVpw5rxgheY9lcPfrb22ak0s/UdFEykudOzqcWjAkaPBVPZAQ48Jr9Zl8NTKXK4/MfPCE+6x8rD Z+U/KWOU0H2gjfK8MjYXOJwA0ZJK9U9JVUr+mphlhceQJGlpP7rZaIuLLRqKhrpoxLHDIHOYfIV1 NQaWte4WhYfw1NTiRzWyNk6B1NxzwUjOV1FHvwdYWNP4afpd2PQcH+S+jaCvZ/8AGtQB/wDOz/0V 6q6ntek9F9V0p4ntp4w1rzEHHqIwP5raW38PNpH+ImhpDNHAZMemMOw3KJyURsFxqrFeKesMQc+F 3V6czch30IKsPR/ENTfwoUtVpoujLel7WycO49sLvda6UsmsdCvuFRb4aeqZGZmSQtAIIGcfVbvb 3+z9005QmGCind0hhLWNJacYwfZXVkmTlc5nbgp3UahgotcG82ygZFSer6kdJP8AMAD3CnJvxCWm az/gqrTkroXs6JIw8dLuOVIG6do0xVWC6UM1JQsro6d0jG9Ia4cHBH7KPvhiqaO722qtVdbqSdtK 4dMj4wXYPPJXXKakzrnjlLb458K2aqq6apvlZPbIH01HJIXxwudksB8ZWndPJgfMVYn4qDYqKqit 1PZ4IK9jWyMqoflPSe7SB3VcSclZzxs9/L0eKy49PqJ5P8zk/VeBw4hfFgyVaT4ftqqB9ri1DdmR 1Xqs62se0OawfY9yuftu3XaruS7nkrNjnDseysnrbTukdc60o7VpelipathJnmg4ZI3y3p8Ef6qQ r3aNC7d6bhivdrpJ5A3DWPY3rf7/ADHut3Cy612x+XHXJSl8j3fmJIXzDScnC7HWsdqu2q5pdJ0U 0FHUOHp0x5LXHuB9FPuyGykEMLbjqaljmkeOIZWhzQPqD5Wa3Kqi4OYQQCvv+Nma3pa9/wBgVOHx P6Os2m71RPsdI2lbMwmRjPyk58DwoJDSCFrPx3DW/ljDyTP0+nrPc7qLiT7kr0NraljfkmkDfYO4 Xd7GNtL9awU19tsVfS1Q9INePyu9wpj+Ifa2xWzTEVz05bTT1DX/ADCLJBb9QpjjcrqLnnMJuqvP rp3OBMr8jt8yzNwq3sLTUSkdsdRXwMJ9Tnt9lZTZvRGj7noeVmrqBtPcQ5zhNODEeg9iCe6km7pb lJN1WRwOee6XOOy6u9acd/aevorRHJU00Mxa18TS8BueCSFPF+2Tslu2hlrWtkfeY4xNHOzIJJx8 pb5C1cLMuHyz+XHhz+FYaaqlpnh8T3McOxacEL1z3uvqIyyaqnew8Frnkgrx1MLoZXNcMEHBBHZf MeFmxuXfbMEk5aDleuCrq4onxRyysjePma1xwfuFKfw76f0xqS/z2vU1HJPLO0Gne15aGkdwVPNw 2f22o7zR2qaiqmVdYD6QbKSDjurNpbJ7Unla/OSCViAfZXD0/wDD9p6LUN3orsJammw2Wke2Qtcx pyCD7kFRnpXbCz1G9Vdpiu9We3Ql/R83S7tkc/RNfJuekEBzmOHde9l3rW0ZpG1M4pnHJiDj0k++ Oykz4htvrboTUdNDZXymlqIuvokOSw5xwfZRGD+yXGz2Y5TL02tuv9xtb3SW6rqKeR3BdE8tJ/ZE V+uDK/8AHNq6gVhd1esHnrz75WtZG5/5Vn6Th3IyovTey6zvs1bFWSXKrfVRDpZKZD1NHtlbUbma sEXSL7Xgdj/elcd6T848/ZJ0Mnbj9lTT61tfUV9U+oqJHyTSOLnPceSfdfIyy46ckN+63OkKCgqr /QwXqSSOgkla2Z8f5mtJ7hTvutsZY9PaEm1BYrjUyekGydEwBbIw/XwVPZbqbVqHdMEg/VfaWEte Rx3SELlB1Gltf6j0zSuprNdKmlgceoxsd8vV74XopNxdSUV5qLrS3Ooir6gdMsjTy8fX3Xi0HaLZ d9TUVDfqx9DQTu6HzsAJYT27/Vd3vHs1V6GiiuFumdcrHI0f7T0jMbj/AJgOMHwVUcrbtytTW+81 N0pLnPHWVAxM8H8/3HlbWo3o1rUQSQzXmZ0cjS1zSAQQVHAje54awEknAAHJXprrVX28NdW0k9OH 8NMsZaHfbKK7TT27Gq7DRNo7dd54qZpJDDggZ+69lw3o1lXUktNU3V0sMrSxzXMbggqMM4OV9YwX uAV2nGen0nkfNI57yXOPJJOSV8cfRWH0HsBR6s0vR3al1IxpmjBkjEHV6bvLTyue3R2SuOjbXHc6 SpZc7aeJJYmYMfsSPZTfLtepEMH7IDefZeh0Ja5L0jnsor4FuUEL6GNwKyELieUR8g32QWqVds9m r5re3zV1PJDR0reI5JwcSHyBj2Xg3Q2uvGgqiD+IBk9JM0FlTED0dXlv3VWVG4TX0fH0kpBvCBNC MDjtldToDSFZrLUENot0kEVRI1zg6c4bwM4+63+5O0970FT0tTdzSyQ1LixjoHk4cBnnhNCN0yMY XXaA0PctbXo2y0+gycRukJmOBgLw6x0zXaVvtTa7m1gqIDhxYcgg8ghNbm58JbJdVz4CZCy6D4ym GEd1FfPysmgFZhn0ytxpTT1bqW901qtccb6ud2GB7g0ds9yg0hHsmBxypD1vtTqXRtrjr73RxR0z 3+mHxSh+DjPOOy4B0eeOybGHGEKSNPbPatvlggu1utrJqOZpcw+s0OIH0XBV1LLR1UsFRG6OWNxa 5hHII7hXW5tP48eCgtX0cB9R+iRbngf0UVgB4RhdnpHbjUmqbc+tstskqqZkhjL2uA+YAHH81oL/ AGatsdznoLlA6Cqhd0yRu7gojVYQsnNSAwikswEBuV0GmtJ3nUZmFlt1RW+gA6T0m56QeyDQBqRb yuzue3GqbbQy1ldY6+CmiGXyPiIa0fdcnJCWHkFB8AE+lPjqx2WXH1QfPGE8YX0a3OPqtxatMXi7 UstTbrbV1NPGSHyRRFzQQMnkfRBo8Z+yWFurZp+43Sd0Ntoqiqla3qc2GMvIH2C8NwoKigqpIKuJ 8M0ZLXse0hzSPBB7Ia08ePdGPZZ4TZGXu6QCSVBgAjAW9l0xd4KN1VUWytigaATI+BzWj9SMLUCF /X0AEknAAGcoPj05SLVs62011AwOrKSeAE4HqRlvP6rwEKj5Ac9inhZ5+qMcIMQOcZQRhZBhLuF7 n2es9MPdBKIyMglh5Hug14CfT3X0fH0HB4WcNNJNn02k478ZQecjASXrmpZIf940g48jC8/YoMML LCyxnkL6RwPkcGsBJPsEHwwkV65aOaPl7SM/ReYtI7oMEwMplfSOInsg+eDlC+z4Hx/mbjPuFgQR 9FNrp80YKzI4WcUT3ngZ+iqPkG5GU+n6r6OYWnBCGsc48DhB8w3t4RhfYQuzjynJBIwcjP2Qebsg hfToB47JFuEGCSywfKZbwgwwnhZdPdZtid0k4OFR8cFCzc3CXjlAgOEdPCzZG5/5V9m00mORx9kH nDUdOV6TA/OOybaWQ54P7KDzdKC0L6vjcDjCyFNI4ZwR+iDzFqWF6Pw0hHA/km6klaOoj+So8hGA gL7GFxdwOyRicP8ACQiPkUvKzc3BWJCQ0SEJKqE0A8JFA0eEIygSZ7pJoEmhJAI+yPCOED7oJSQA gaEijsgPKEDhARDR4QEigYQkEdkDQhA/mgAE0ZQgEZyhAQGEI90h3QZcpeU0eEB2QkjCBoSQgEBB TQCPKxx9VkgOwST7JZ5QMFI90FCBgoyl5QgeUkJIGgpIQAT8o8pd0DQO5QeyQQNCSEBhCEdyrAHu hHlCAwjuj9UIBCEIDyl+6aX7INgPdA/mkshyuLVNowQfC9FzGbG8f/NW/wCq+LB830K+t0+Wyu9j I0qfJGiA4Xnk/MvQ0nB+y8z/AMxW4Ukk0lUCEIQCEIQNvdTn8M9XBBqSaKWRrHPDenJxnBUFrZWi 4T2+pjqKWZ0U8bg5rmnBBQWq+KWiqai1WSaGJ76dk7g94GQ0kDGfbK2OwOknWq2Nq6kPjnkw45OB xyFG9r38kfp51r1FZ4ri1zQ0uL8A/Uj3Xrs3xBCgs0tA+z+q0hzI3er+VpGAD7pe2McZisNrW1DU umLjQ01U6KZzCWuiOfmAyBjyCua2Ohmp9NCGpyJ2dTZARg9QPKhLQW+kmnWSw1lCauFzi5obJgtz 4XWUfxG22GSVzrFJ87s5bKAf6KGvl3msJ7pqmS4afioW9ENU0sqi7AAa7OMY8/ddXUyTW7Q9U93y TQQPzg5w5oKh9nxH2SOR7mWCdjnnLi2QDJ9ytfdfiGtlbZ62gNmqP79j2tcZBgFw7q4ybm0zluN4 py2/v7tQ6YpauduJS0dR91VC6UNRXbzVbaWJ0nTXlx6RngOXSbc760+mrR+AuFufOxnDHROwcfVa fSm7Ntsurrlc57SZ6arlMjeR6jcntldcbJ488ftxuGX5cclkNdR9O2Fe13DmwO489lQapA9QqZd3 N5Z9WxMpLOyeioMYcxzvmPvyFCsjuonCnKTxTxuuOF/Ll5PtgUuMoQe65uoCfnhJMINjaqeWrq4o IGl0kjg1oHJJV8NnLNNp/S1LHUVUkjejLg//AAcZVHtEXoWDUNHcXRes2B/UWe6sRrHfWzXLRj6W yuraO6uDcYbgDB5GfZNbZyup0674kqO7Ps1PW2+r/wDRvU1s8H+bJ4K76yVjrft2yqY1rzFTl/S4 ZDsN7KI7Bvppmt0m2g1HTzPn6Oh7Czra76rdUe9mg/4GbdJ+MjgdGYyzozwRgjKuWUyuNvw4Tx5Y 45Se6jTWW/NdcLVU2uit0FE45b6sLsDHnhbv4TZ5J7vcnSOJGWY9lAOs3Ws6lrnWGSV9tc8uhMow 4A+D9lNGwe5Gk9KW0w3eGamrQcmZg6hJ7cK53fr06ePx6m77ZfFnO+LWVL0Oc0+g0HBxxytv8IgJ rLq//N0f0K0HxC6s0drOnp7hZaupddIiGlro8Nez/QhbDYPcXR+lrQY7o2akrwcPkaC4SfX6Lfny mcmvhjw4XCXbSfFo4/28jHj0GqCG88lTv8RmoNI6tNNdNP3CaW4tPRJE5mGlvv8AQhQRnBV82Uy1 prwYXDHVZx8OV8tkyDtRRlv/AMrD+hVCmnBypz2L3hfpORtrvbjNZn8A9zF/7y5TqyumePLGxsdk +d6J/vKR+4U77naislrvVqor3Zoriat3pxueAeg5x5UIai1RpPS+vKHVOjKxlVHM4irounHQDglz T9fZSLe9Y7a6yqbZcrleXU9VS4exnI6TnPIx7rtlnjl5csr6ry/jznjwxnw3OodF6N05caTVclFF RRN6WyxtZlnzHh2PBHuF1Fo1Hp/Udwpo7JfY5TGQ4QMbk8fXuFDu/O5+n7jo51mtFWytdNgCSM4L Me65P4c9SaVs1bUVV8rZKO4g4Y53Mbme2PfK45a1Pt3wmW7tLW91h0reLxQHVF1dRhrSOgcEgnuC uDO121Up6m6tLf8A6KMrD4lbvpvUVphudnvsMtdT/KKcd3tJ5wqzmqkLuHE/quvlylk1fhjwYXHe 57qydPoHTFi1ZYa7SmpI7gW1TRJTvcC7B8jCsPqi9C0yWaGSBs8NbOKd7XD3HdUO22vkdn1ha62u e4U8UzXSHvgK5F41XozUDbVOdS0sJo5WztHUOSB2IXPDW911z3Z0hb4lds6HT9ZHqCzEQ01Y8tmp Q3AY/v1N+h9lMOxdzm1BtjA+6MinfGDD1Fg5aOBlRr8SmvbLebTSWq2VLKp7HCX1YnBzT4I+i7zZ +/aOs2h6akpr/D0yN6nNnIa5jj3B/VdLqTGz38uP7ZTOf/RX+x6xqtC7kXSa3xwmGWd0UkL25aW9 XHH0yrZar1FJatu33pkEL5BC2QxFuWHPjCpnuzRUtp13VPoK+nr6aZ3rslhcCOT+U/VWb0Zr7Smt tCQUF0rYKSRjGsmgncBnGO3uCr5cpfNy+Ewxy/BMfnSo+5WoYtUajlukdvgoHSNAeyH8rnDzj3XJ DuFNHxDW/RFFWUzNHgMqwT64ieHxPb4IOeDlQsP5LlbNvRjNTSY/hjAdudbP+EP/AKK0m4N/0rpz UdruOo5J4qyFrvw72AloB75Crf8AC1DaGapfXXG6Q0dTSjMUUuAJAe/zfRd98U1LSXi0093tl1op /wAH8skDJQXEE9x7rfj1u7cfNMuuM+UqbcaxpNaXu81dB0up6cNhjeMgubyRkeD3UZ6Nie74lbpI WnpHqc447BQNtduFcNDX5tZRvLoHkCeEn5ZG/wDVWxZuJo2DTs2saR0DaipYGyNABeHgcAjuO+Mr HLqx04dyob+MU/8AwzWwH/5B/qVXEDsPqu23W15Xa4vZqqohsLCREwHPSPbK4lrsY+615M+Wv4eP DhKtN8K2jLLX2OsvVfSMqKuOQxASgOZ04HgrutI3rSusdTXHTkmlqFnoteHP6GkOAOO2OFxHwo6v tNNaKywVlQ2nrJZDLGZHANePYH3Xe7eaB/stri5X2e70NRBUteGxsd8wyc888q464X7c8+X5Z9aa 3RGlNO2zWd70ZPaaWsozH+LhkmjBfGHcFufp4W4tVo0jWakr9HzadopDS0wcZzG0EtPAHbuPdavS d/tVdvrdJoKuPDqIQ4een52nkcr16cqoIN+762aaNhlomBnU4Dq+y3nJJl/6ccc8/wBN/O1ZdzNL 0+kdeVlropHOp43B0fV3aDzj9FZ/drH/AGDYce9JCD/JQrvFaxet8v4aamKmFU6NgmkPyjIVhNxt OVN32qltFE+GSrip2AAPGHlgBIB+uFrLjj5pr0uNyz8HftwW0OhtOXzaB01ztVNLUn1h65YBIMdv m78Lk/hp0fZb1cdQRXi3U9ayFrAz1m56eT29lIHw63q31+gaiwMmbHdIDKHwScEA5wR7hbTZLby6 aIrrxLc5aeVtX09BidnsT3/debesdfO3syn7bnrSq26lppbFuReKC2x+lSRVBEbB/hGAcKzui6l1 w+HgPuJ/EZpJWkS/NkDsOVCGu9OTaq33uVqp54YJJ6ktD5X9IGGg/ufCm/Wlxsu2m2X9n6idz3Og cxrMjq+byPfldscZPLj9PL5srfDde1NqGcUV3hn6eoQzB/T2zg5wpv3v3P07rfQ9FR0VLPDcYJGy fOwYBxgjKhC1S05vFO+sA/DCZrpARnLern+SnLf236Bfo+3XDR7qBld6rfUbTuwSwjy37rnnZcrY 9OG9TauxOSV9IT84x9F8wMuK+0H+8H0WWlyfhQz/AGFuWTn/AGj/AEW82Zqprvo7UFPdHmpp46ua JjZfmAZj8v2WHw26frLNt+XVjWD8a4VERa4EFrhx2XutMFDtfom4yXmrHVUyPnc3AB6ncdLffHC5 +CWYX72nl7yt/jjKDarRFg0ZLfNWwOqYnuE3qRlwLGuOA0NB5wvlWbTaJ1boqoumiWSU0sfUY5JH HBLRkghdhqCkfrbZNtHpl8dZLLDG1oDwOWuBIOe3Zeva6zVmkNsp6HULI6So6pnHqeC35hxz2Xoy u5y+XPGXdnw5y37H6LrdLUUropaerqadvTL65x6jm98H6+FrNWbD2Fml/wATYn9Fxo29UxMnW2Ut GXD6FSBX1EVFpHS0tTK2KnjmpXPkccAD7r70ErX6S1TNTvbJG6oqnNc05BHSOxWbj3J9ry628l/o q7+xNkt+namK2y1Yiic/0wW4cw9WQtTWU09y2UudLqUMrKqjZPE5zhn5oyQ0g/tys6qpqNd7cUM+ ibg2K50JY4NzhzXsGC0+3+qWqqmLSe1VbSajuDJa+qjkc94bgue8Z/L454XXxyTLCX4ebzS3HO4/ KkVQAJSB4KKeB09QyONpc9zg0ADkkrGd+ZSR2JW20g9jNSUDpXBrG1EZJPAA6guXlsmVsezxTfHG rHbU7O01ktkN91bUT0tU17HwsheWmPn8rh58Lb/FwP8A4WbE3Of9pdyf+Vddu/bLjeqLSxssck8T K1kkzojlojwDkkeFy/xW0M9To611lOx0lNTzF0j2jIaC3AJPtlPH73fpfJNYzX2434XbXb6q5VlT FcZ6a9w5DY2tBY+IjB4Pc5XI7y2iruW79XbfXZLUTyRxMkkAYPmAxnx5XWfClbas6pqbiKeU0bYn wmbHyhxwcZWr3usldU7xOha30DXvjbBNIelueBnP0KeHfDOVx82vyYOuqth9IWO10k2pNQ1VHO5j RI49PpF/nBx/UrjN2NnIdN2envunax9fZZGtEj3YJaXHAcMcYPCmugnvlktNJYNcWY6hpXFojq6V hmHSD/jbjOR7+VrNVaAFPquzV1LPK/TFRUxCot8zyI4cu4AYeA0nHGOCucda43T+x2k7na7bIb9c IKqrhY/03RAAucM4GR/qo41foy47ca3hpDOfztmpKmN2C5nVjJ9j7q2F/uV3testPWy2U7RZpW4n f6eQzB4HV2HCiL4oaac6tsdR6LzA6D0hJjjr9TOM++FM5vHL/prx3WeO/tKut9MU2ttFWy2XKudT Pm9N7ZMAlz+ntz+qqBuToG5aJvrqK4MLonHqgqAPllbn+R9wrR7usr/7B6ffa2zmeOeA5hBJaOnv x4Wj+J+P1NvrI+XmUVLAXHvzGcrHituOM/hn1vKfbxfCnXVUun71SSzSOp6ZzPSY45DeoEnChVul K3WO41ZbLa1pmmqZC5zjgNaHfMfrgKbPhUpJo7HfZ5Insinez03OaQHgZGR7rndmIXw73zNlYWPa 6qyHDB5yvR4OvBlP68/k3+eX+PRJ8OlsiqPw82rWRT8YjfAATnt5CjXXe0140vqKG3NiNYypcBTT RjiTJxz7Kf8AcHcK/wBq1m+z2ewQVpHpiOWWFxJLsf4hkYz54W305W6muOtKCPWFnpKIxQTGF0J6 2vJxkZzjKxlOPVd8LM+48myu39y0JG1lZdhIyrh9SShxwyTjJHvjtwq7fEYA7c2/YGMSNHH/ACBW O05ca+q3tv1HUyyOo6WHMDH9m9TWZ6f1BVdviBheNzr11scA6RpaSO46RytYYz9p9Odztyx18ole Mdljj3UzaJ2Yk1ToGo1JHdGQujMuIDFnIYM98+VD9TEYZSw+Fn426fLDwMcKa/hdu1ZR6+p6KnlL aatY4Ss8O6WkhQpyQpe+Gdrnbm2vpBIayQn6fKVjyXUdfDJcu/7/APZZ246leN0otKVkDKi33Cg9 UBwBDXDr6s+4IaoO1psw+5blVFq02RBRvjE7pJWkshJBPTx744Ut11uq59/6Cujic6mpbdiR/hvV 6gH811NlIdrPULgQR6MGCDkflK9Fk7n8c9dSq7f/AANt+ax5F0tryAS0MLjn6dlz2ltjr9qH8f0S U1I+jm9CSOckO6sZyOOy7zZeonfvBVxulcWH8T1N6jgEHjhTbZHubqHVJacBr4iPv6XK5T5/jWWG pL9xWOk+H3VMkteM0TfwshY3qe4GUdIPU3jtzj7hTD8O9BLbtvrtSVkTopo6mZj43jBb8oyCF3Nh u1XUzafbNIXNqqF80vHdw6cH+ZWNhA6tXHt/tcgP/wCDarx7hjbjjlEK/DQA3W936eAaQHA/5you 3+jDdx78WtAzUHsPoFKvw2Rka1up4PTRgHB7HrKi3f4tduLfwSOKkjH6BZn+2X/bfm94/wDSMCMH C7DbjSF21VfIqaywh0zCHmV5IZHjkEnHHK5MY/EMB7K5G0jYdObHzXe3U8MdaIJZnP6fzlpOM+6m 5ymP2xrWNy+HUahhuI2durNRsgNwZRPEpj5aSBwVUrQenK6/6yo6S0RRyVTJBP0vkDB0sIceffAV om3Ce67DXGtqj1Sz0s7nf+IqrWlaqqotZW+WklfDM2qYxrmOwcFwBH7FZyynDa+KX8uk2/FDPJU2 GyR1VvlppRI7Lnlrgfl7Ag+6hzRu0mptW0Tq210bRS9XS180gj6vqAe4+qnf4pnNNosfVz/ePP8A 7lfPZ3XTpNLssmrIKmgpGRBtLceh0bHMxwC/wfY55Xp8nWGH9n/5csO+V/qGNSbK6q0/a5q6somO p4hl5ieHkD3x7Lw6P2m1Jqy2OuNnpopKZsjoiXyhpyMZ4/VWQ1G7UukdOOq7FXf2js1QwulfVgyO jB4y0g8twlpS12rQ22dNdLi6tqDWFlQ8U8hYQ+THAAIGAuelVo1bt3e9GVVOy9UwiMzetj2O629+ 2ff6K0u2FbJq/aGQT0dOKj05KPoa0YcWtwCfuvHvpUQVW1dFURMd0SSQvj9XlwBBPJ98LzbNTSUG yl1qICRIyWre0jwQOFrDG/rlPlzzylxyl+FcNwdDXXS1ayK6UpiMzethByMZPn3XbfDBdXW7Wv8A DHU0MsVxYWuc9uXM6QTwpgqzHrrZWqrr9AySrpYZXMeOCHMbwf1UL7BRdO69px2Am/8AIU82N48/ 63/jZT8l8WXxNt98UtBB/a+mbTwRRH8G1zuhoGfmdycKPLFs/qu82+KuobU59NMOpji8Akfbx+ql b4jB17hUOfytp4B/9eP/AFUz6yv1qsFot77vJWwxycM/CEtJIGTnC35J+0xk+GpNYc9/KmeqtuNQ 6WiilvNBJTRyHDXZBGfuF2WwljvkGoYbxRWJlytzXfh5zK0EAO7ubn2Uv6o3B0tqXSk1lg/Gzunf HEx88fIzI0H5s5BxkZW/1xd/7D2+x2WwU7IIaiVkQc0YMbA9oOPc8rnxt9G+5Ee/FRb6SCC1OpqW GJx689DAMjj2VW5eXH3VrfipyW2kf8En+iqpN/vCu3mn64X+f/l5f8bK257+3zjZ1PAVjPh027td fbZtW3xzZqelkcyOEjIBaMuc4Hv3VdYxmVuDhW/2Hb/9Qq5+kMudJVcDzwuOPeUx+3byZccblPhF m7tTQ631fR2/SVojbKxroI2wNaz1+S7OOAOMqONQaOu1hqWU12oZqaoe0ObHIOSCcDH6qQNqg5u6 1gJHJnd/5Cp53R0xQagvlZUVok9ehtbZYHMPZ3qO7jz2TKSeXLD6dMN3DDK/KpV80HfrDSRVV3tt TTQSHDHvHBOM8FTb8ONipqW03CqvthfUQVTWupp3UvqgjkHB8LtfiBAO3NmD+T6rM58/3ZXl+GG6 1tXYrrQVEzpKajLRA13PQHZJA+i4ZZWZY/1047wzs+Ffb1p2a9avrKSwUUkznSvdHDG3kNB9vop5 sm1NDbtna4G1OlvtVThzxIwOlY/I4bxkD6KHLjfLhpjXVXcbPP6FXHPMGuxkEHIIIVlqbVFzk2Tb qB8+Lj+FbL6oaO/UB2Xf/Ik/PqOPg3//AA8zVz0BSU2lNw6en1JZY6pj3CndBVRglheQGuAP3Upb +6Eo52WyHTdlYyqeHktpYuSBjwFF1RqC4al15a665SMlqDV07S5rcfK2QYyrN7g6lNkudlpaeHNX VzNY2bP5Gl7Q4Y85ypOssl1y46UlrtL3GmuzqCWknbW9fR6PSerq9sLanbLVQ/NYriD4zCVc6us1 tl3CoqqSigdUupnvMhZ83U1wwfvyuFvO4N7pN1obIyZn8PfXNp+gxjPSRnus3KYzbePjuVkirUOi r3UV81DDbKqSrh/3sTYyXM+48JU2jbzU109JBbKySpg/3sbYyXM+48K88dFTU+4cs8ETY5ZqAOlc 0YLz14BK4rbvjeDW/TwD0/vlbk3NueV1dKo23R91rLjLSw22sklgcBO1kRJjBOOfZWB1/tRbbVtn Rw2e3vmr/Va90wjzLgt5DiO652+6wumjdwdQ1FnlYz8TU+nIHMDg7kY79u/dTVuXqq42HRdDcqAx ioncwP625HLcnhPJjMPN+M3b4eelGLtQyUFXJDMxzHMOC1wwQV4cc/RdLrCvlu13q62rDfWneXuL RgZ+y5wcj7pnJLqGFtm6nX4aKPTl2udRZ75aIa2pnzJDM8Z6Q0cgqaxp3Qb9XO04zTcQqhH1mUNH QB05985UD/C0D/2mUg8CGU/+5U8a013pvSurppau1SvusUYH4mPHII4B/Rc/FvPnPpfNrDLDv24S l2PparXVZD6vTZqV4e4kDJz8wbj2wumbbdrZNRmwOtNJFO8dMdQPyOd7A+Ctvs1qSXVUWo7nPgPf P0AAYAAZwFWbV7qr+0Un4X1DKZf7voyXF3VxjHOV0xsz3Z8J5Mb47MWy13pe26L3EFJMz8ZboZWy PjPBdGeS39lO970pt7b9FsvpsDG008LXR9I+cdQ48qrmoJrvJdJv486p/HtHTJ+Jz1jA4Bzz2VoN agf9g1rLu/4Wn/oFr/Hkz80xvpy/ycr4/Fc57cbsZpzSN/8Ax9tvFnjqbjE4zMlf29M9h9MLrrxt porUdLdrbYaOOiutDIWOH+LIGffscrkPhowdbXV2c/7G3/zFd5oM53q1mB26G/vkJjlMrlfp28uO uMnzFaKO00mmtdQU+p6M1FFTTltRCDjqb2/99S/uVtVYbtpWLUGhWxtp2R9T42HII7k/QjyFwG9P Ovrxgf8Axwf6Ka9og5uw1UXd+mo/qVf8jU/yscJ6rl48rf8AGy8l9xTu4Urqd7gQcg4K15XTanGK t/SMt7rmnjBU8mEwzuMbwy5YzL7YpeE0llQmke6EUeEJpFAIyl900AgFCEDSKAgoBCSaIEeUFJA/ KaSCgMoQjKAR3CO6YQCPKEd0Ae6B2QEFAJ9kvuhA0BLsjuUDzhCPCEAOUIQgOwR4SQgaCUgUygMp 5WITQHul4KeUFAkZQj2QBKB3Qn2QLymUkAoABCZSQCD2QjhAAoQhAIwhHsqAoCCeUIEU8I8p+ECy jykmgED+aEIBCEv0Qe8chZhYM4CyzyuLT6R8kL6XjizNB/xSD/VfKP8AMvpex/6HgJ8y8fsVPlY0 vgrxu/MV6+wJXlf+ZbiVihNJVAhCEAhCEAvZQ0stTKyOFhe9xw1o5JXlYMuAU6fDdYKK6XeSarjD 3xuDWk+EHHHazVwtv41trkkgxkmM9RaPqFhV7Y6rpLX/ABB9qmfSgdTnRfOWj3IHIVjN8taVWjrd TW+0MET6nI9UHHSB4x5XRbPamh1VpNsM72GoLCyZrTg5IweFrLG4625YeSZ74/CqFj201Pe6H8Zb rc+WE9i0jJ/RbSPZzWcjOqO1lwzjl4BVvqajoNG2WofDI1scTXvYJHBoJ5IasNvbxNe7Y+sm6meq 4v6AeGnPOFNdbWZzelQp9n9aRtHVZ5j/AMpBWovW3uprPRmprrVUx047vA6g3747K5tZfbhp2te+ +P67XPUGKN3Z8eT8vHkLpoIaastb2VQZJTzF2escELO2tqE0+gNTTWsV9PaamamI6uqMdRx9hyvP Y9GX+9xzPtlumnERLXgDBBHcYV87RYorHRz0tNxSHmNufyj2VYtH6trtPbsXCnp3Zp6mtex7D2z1 d11xx3hc/py/L/yTx6QfdLfV2yrkpbhTy09TH+aOVpDh+hWvd2/0VzfiE0TbNRaMkv5jFPc6VnU2 Vg5cP8rvcKmbxz+izq8eXw6yzdn0+flBTwllZaATxhILIIPVbqOorqhsFHC+aZ/DWMGSV0f9htTA ZdZbiB3/ANyVr9HV89qvtJWUrzHNG8EEfdfoBb62eXRgrWtDqkQFzcNyS4NyOPuiW6m6oDU6du9N UR09Rb6uKeT8rHREF32HlfC42m5W2RsdfR1NM535RLGWk/bK/QFlPHeNO0tZcKdhrIx1jDcOY7H8 lwfxF0tO/Rlte+Fhk/ERYd0jI5HYrWOPK6jGfkmE5VTiustyo6ZtRV0NVBA7tJJEQ0/qtdktOMq/ OqaKmm2nqm1EEcg/DHhzQfCoTUN6ZnNHg4V4/pM/gnklzuH0+lJBUVkoip45JZD2axvUT+gXsqLP c6aIyTUNXHG3lznREAffhbTbW61Fn1bbqmkIEnqtYQ4ZBBIBCvJrCvit+gKm6OoqWaRkXUWSRgtd 9CpjOWUxnyueUwxuVfnpI5xyCSV9qagqaljnU8E0rW9yxpIC2NdJTXLUMkrmMo6WefLmxtyImk84 HsFdjZnSmmbdYIxaZ6avD2AudwSfuEynG6axy3NqIiFxkDOkl2cYA5z7L2NttW3/AONpx/3D/wBF Lu7NNbrPvWyRsUVPTRyxSSBjQGgZyThWx026w3a3wPo4qSpaWZD2sDgeFryYcLpz8Xk/Jjyj88DT VDHYMUgPt0nP9EvRnBwWSAfYq+Wra2x0jWyUNNbzWw1LInxOY3qw44PHdbTUzKe2W2GqoLBS10ri 3MDY2hzge+OO6nC7kT80k2/POdsjTh2QfC+bXlvlW139g0zedtprjbqKmgroHjqaGBksbs4LXDvw qju/N2TLDUlbwzmW2b5Xu7uJC+YPPuV77Pa6u71sdJQQOmnecNY3yu0O0GtWjP8AZ+rP2AWG3ARF wP1X39WRg+VxCl/ZSlfp7cNln1DZo3uqgI5IKuH5meQ4ZUs/EXtpRVdloZ9L2JguJlPUKWPBLcc5 AVxm+mcspO6qA6d5dyTlMVDxwHEfqt0NMXZ16/hIt9R/EScCnLMP/ZbGt261VRU0lRVWGvihjb1O cYTgBNLtycj3+SST9V9IpZGj5XEH6FZMp3ySsa0EknpAAySVbbYLSNruGnDQao0pEyphHUyongwZ WnnuVDaoUz3vd85J+q+TRkd+ylPd7R0dHuVX2vTdDIYyeplPE0uIOMnAXLO0JqRgJNjuIA5J/DuW 8sLjdVnDyTKco5tkr4yOgn9PCzkqpnsw97yPYlbKj03d6xsxo7dVz+icSenE53QfY+y89Jaa6rqj TUtLPNUDOY44y53HfgKaa21zS7wV9RLMGloc4MPjPC9jrXVxVwpZaeVlVnp9JzCHZPbhWSh0Loao 2hFTWUsVHfmUx6nyuMb/AFB9D7pjjcsuM+Wcs5hjyqrTsk8oxx3W0js1dURyy09JPLDGT1SMjLmj 7kI/gdy9ATfgqkw9PV1iJ3Tj3z7KWaumpdvDTVUlO4Ojc5pHYtOCF7m324f4auoH/wBEK88FBUVL umnifI7vhjCT/JZutVaJDGKab1AMlvpOzhCsW3GpZMZmzStk79Ydz+6+hvFY6cTOqpzKOA8vPUP1 XldBI2Toe0hwOCCMFdZqLbXU2n7FFeLlbJI7fIGkTtIc0A9s47ZVOnNTXSpnlEs00skrez3OJI/V bGHVN3/L/Eavp7Y9U4/qufJIcs4vzjPZZNLB7U0+3lXp6Kp1De6+231r3CQsmLARngjAUrz7k6K0 VpWb+A3L+JVbAQA95Mrye2Se+FwmxG3ejNcaUDqwVwu1O4io6Ji1pBPykcLba92Is9dp+ql0LUzP udFI5slPNL1eoR3b9D7e6sS7Vw1PqitvWpaq8yPMdTNL6nVHwQfcLXXi+3K7OYblV1FSWDDTK4uI H6rGut9RRVUkFRG6KWNxa9jxgtI7grzGF+e4I+iW35Sa10+PURznkJvkc5uC4rMxOdw0hNlM9zwO DlRrb4tBI7JtJDuQQp02Z2Ul1Yz+IX0TUtpLT0Fvyvf7OGe4Wx3T2Gis9g/jWj6mouNNFk1ELmgv aB3Ix3x5HdDaKrPuHqe0UDKO3Xmugp4xhrGSEAL4ag1rfr/BFHdrlU1TIzlgldnB91zb29DsLDlF dZprXeodOwyRWa6VVLHIepzY34BPvhe28bl6qu9vfRXO71c9NJguY52c4OQtNou1Ud2v9FSXWqNH QyyBss4GegHypd3c2Ut2jdIi9Wy7zVjeto6ZGNAc13YghawxuV1GMspj3UZ1u4Go62wts1Tc6ia3 NDQIZHZAA5C+lk3E1LZLZLb7fc6iKjl6uqLOWnqGDwVhtzpWPVer6Gzz1BpoqhxDpGjJHHhbjenb n/s8v1LQRVprYaiD1myOZ0OByQQRkrnM5cuM9xu46n/bRaY1zftMVUs9jr5aaSUYk6TkO+4Xx1br S9asqGTXusfUSMb0gnjAXP8AQ/wkWuzzhb2mmAys2Eh2ef0TaxxPC9tpoRW3CnppJWwMllax0rhk MBOMn7IO507vDq+x2mK20dzeKWEYY17Q4ge2T4Xyue7OqLlp6qstXWiWgqAWvjdGOxOcA+OV2etd g5tOaOrL/BfYK2KnYJAxsOOtpI5zn6qDHxkSY5GFN7V3WhdztR6Mpp6ez1nRTzO6jG5ocA73APZY 613Iv2sRS/xqdkhpnF0TmRhhaT9Qt/tRtBNuBaZqynvNJSvilMboHsLngYHzdxwuL15pio0jqaus 1TKyd9M/p9RgwHDGQceO6S/R/wBu5tG/WsrdQwUjKyJ8cLAxrpIgTge58rTa03Vv+rhTtuk7R6Jy 30W9HOcgnHsVHoaT2BP6ILPlyc5UNJgg371dHa2UMk1NNE2L0+qSIFxGMZJ91qNU7sag1JYaW13Z 8D4KdzHxyCPD+pvYkrw7Zbd3DX9ZV01sqqKCWnjDyKl5Bfk4+XAJ4Xn3O0HcdA3aGgub4ZXyxCZj 4SSMZx5+oT+JrvbuKD4htW0dDT0wbRPZCwM6nR5LsDHK5DcDcy9a3lhddZGsiiAxDFlrM++M91wJ KXlJJJqNe/aY9Hb66j01YKa1U8dJNBTgtYZGZd05zjK0F+3Lul11jFqSIRUFxia0B1MOkEtzyffI 4Kj3C6jb/R1x1rexa7SYBOWGT++f0jAV3rqJrvaV2fEjqLpb6tBbHvA/N6Zyf5rlb1vBqK5ampry 2p/Dy05BjiiJ6B78E+R3W6l+HfWUcb3CG3v6Wk4bPyceBwoeulvqbdWTU9VC+KaJxa+NwILSFOyd JuuHxGX2rpmsFBRQzse17ZmB3UMEEjv2I4/VcbuVuZPr2ro566hp6aSma5nVF3eCc4KjktaMHDuU BrPrlaNaWXg3h0tp3bFlo0zSy/jJIumWCVp6etzcPPVn9VWurk9SUuPnkrHpJGMEhdZojQF91p+K FhpY5zTBpkD5A3APbGe6e5ocgFI+0G5Mm3tRWyRW2CtNQ1oBeelzCPY+y0Nr0Td7nqX+A0lKDcg9 7DE5waAWgk8/ovhrHSd10jcPwN6pjT1HQHgdQIIP1Cl/+y9zV+023T4j6mqt9THT2eGlrZY+htSy T5me33XEaA3bu2lr/UV8h/G09US6ogcekOJzgj25Kif9/wB1kwdTukZKe0Wap/iFoIJnVEOlaaOc gj1I3hrufrhajSm/tTbH3N11t4rHVbupr2v6XDjAB48DC4G1bS6wuNqhr6W0PfSTResyT1G4LcZ9 1w00D45XRvaWvaSCD4Km17TJoze+vsl0hkuUIr6KGN8UUQIa6NpOcA/oFtrNv26h1Pdq19vdJbK9 /X+ELwS12AM5x5woouegtRWvT8F7rbXNFbZ2tcyfILcO7ZweMrlHBrfzA5V7ptZmLf3T9CJ32rSb aOeRhaZYXNBJ8ZAaPP1VfdXX2p1Hequ41pBnqX9byBjlaYEHtn+aCQCFNGxw0gnwps2n3l/s1p+e w6goDc7Y4ERsyAQD+ZpyOQVCROeB/RdfaNu9VXe3RV1BZayekkb1MlY3LSPurrd2b60nKHfiwxR1 FtFhkNifAI2U3UPlPPUPtjHCibRmrLPYdei71ls/GW5rpDHA4jqZn8p58jhcFUQSU0jopmFsjSWk HuCvTZLJcL5XCjtVHPV1JBcI4WlzsDuVNa6N/MT/ALl7x6Y1hpSoozaaqOuABppHlpEbsjPb6ZXl 0JvVbIdKCwaxtbq+nhDWQljQQWDsHA+R7qF9RaWvGnxELxbqij9QEt9VpGcLQtIa0HkH7pbetk/i 0tw3109R6aqaHTtrnppS3pijlw6MA9xjPHGey1elN6bHNpKKx6ytctYyAhsZhAw5rfy5BIwQq2tf 1Z7j2XpoKSprqyKmo4ZZ6iV3SyONpc5x9gArL8p3Vl7hvFpO8WCvsl3ttS6hBLaLoaMsYG/ITzwQ fqtftZu7p/Tej5rLeqOqmD55Xn0wC1zH+OSoQu+lr5Z6Zk92tdZRxPPS100LmAnvjlaFxLTjKS3U 0zqd9LLam3h0zS6Mns2kKGaBkwe18U7Pl6XDBwc91xWyOuNO6UvNXXX6llkqekfhpYx1Fnhw/VQy +Qn6rHrIGOyu7rVJJLyntYTeXcTS+rG0NbZYapt0heA50rcAsbkgd/ddPHvBozU2nqKm1lbql1VA PmbGMs6sYyCDnkeFVVsjh/iKDIQc5KW23e2vjXws5rzdzTj9I01l0pR4ZG5gAnjx6TWuDh0nPuMf qtvLu9ofUlutsmpqapFxpcSBrGnpbIPqDyMgKpj5nE5JyiOZ48n91N0WU3R3L0nrHRXTIKht+hb/ AHQaz5Q4nkZz2wq2zv6pCfCxc8nlYOKu7dS/CTGTevk84I91MWxu60mjKk2+59U1jnJL2dzG493A f1UNZQ1xB4JUNJ81lrHS9t3BtuodGMEjGH1p4nNLW9ZJBwPHClmbfPSEooZR1SGfEdUHRZMbME/r g+FS8SuxhL1XgfK7Cmu9t3K3GY/SyO+W6do1Jbqa3WX+9po3CX1C3pIdgjpx9luNltf6E0zpcCeq nprlOB+LEgL8uHkY8Kq5lc5vJ7IbIWjgpZLZb8HLqz7SfuxX2Co1LJPpqqfUUk2ZCXtx0uPcKU9r d0dL1GgG6b1W/wDDMga2LgEiVoII/mFVz1HOHJ5TbK5v5ThXLeWXK+zCzDD8c9LW3nXG3t21pbhU wsgt9EDJHWQjo6njBAc0DkZH7r57nbiacumodO1ttrvXhpJgZsMIw3rac89+Aqr+vITy7+aPXkI/ OVftJ1lL9Lk37ePTVNqe1VlBUiqpix0M7uktMYJBz9V8Ky+bYVuq4tQvvE/41kwnAAPR1AY5GFT/ ANd/HzHA9yn+Klx8rj+6zZLNVZlZ3Fu6reqxQbhskx12z0fwrqlru3zZDsY7eML3U2u9AWC/1d4t 9yfUT3OUNqTk4jH+bGOypoamUkcrI1MmOHH91d1m9pn3ouWn5dRxV2m68Vkc5FRKCOGvDs4/kphs e5eiNVacth1BURU01K/qdSSjqBcG49uQqaGofjk5P1SE7h9P1TLeWXO+1xuseHwlDe+96fu2oOrT lDDS08LfTLouBIc91FoclJK5/Du33WAOPsqifPhouOlrPcKm6Xu6fg7lCSyJkn5Hsc3B8d8rafEB X6cuckd3sd2jqaqZwjmhb4AHDlXKORzT8vCzNTI7hziVcLfHvj8s54zOy5fCaNkN0G6Ouj6O4N67 RWSZlIHMbiMdX2UzUx2wp9TyagbdqV0+OpkTnfIx3fqbxwVTASvHYrM1cwbgEAecFZk16dMry7qX dc3+yav3MFZM99NbaidrJZAQSG9ursp71Bc9GXXQzLCzUdMI4IGsjkzyS0ccfoqSGV2c9S+jK2Vj SCftytY3hlyntz8mMzx45elodgK/S9lNwudyvUMFwke6n9GRwA6Acgj7rt63VmkNLC83q3V9PX3C ukLz0O5AI4H1AIVJ21rwT0nn3ysnVtQ5paX9/qk6tv2t/bW/hJjLtb9XbhwPv1W2joqqcmeYcBvn 9AcAKZ9wtwNOaU0i2xaSkp52TRnqMR6mtB4P6lVEEjgeDz7pvqZXN6S7hW3ln+S+01Px/j+Htu1a aiZ784z4WrPKZ+pysfCW23dWdTUBSTQoEhBR5QgQjOShFCEIQCEJeUAmhCAQllARAUBNLKBlCSAg Ex2RhNAIQhAISTCA8IR9EIAoQUIDKEI8IHnCRQgIAIQhAfZHlHhCATKSEBlHlCEB5R5QgIBCEIBH dA7o8oGl5QhAIQhAIQhAeUIQgCkmkqGO6EIQCEkygRTGUdu6O6A7oQUIBGEDukg9gOFn4XzHdZjs uLT6RH5l9r7zaaZvj1T/AEXwj/Mvre//AIl04/8Amh/oorSnPSV5XfmK9XYcryuOTytxKEk0lUCE IQCEIQZN4cFP3wx3SlpbvNBUStY+RwLQT3woAC2Npr56CpjmppHRSsPU1zTghBZ/4n7NcK19pq6W mdLSBxYZG9ml2AM+y7HZXSsWn9PxT1LBHMW+o9+cDPfuoLpd+L6yxvttZSUFbG5vQXTtPb7DyvTR b+3qnsrrcbfQSRuYY+ol2QCMLWeVy1v4cvH4545dLJ68s9LrTSVbTQOMjiC+P0nAZeORj9V5Nn6W aj0vFTVTHxzxjpcHDBBB5VbtE73XbTFGaVtLTVMX+D1CR0j2GF01F8R9fAH9VmondTi7Ie4clS5b miePWXJKl5p7/rKeot0zII6KkrPUileHBx6TwPsuo1XUT23b6smjOJqeNxBHuO/9FBh+JWqDXdFi pAXdyJCD/Raq+fEFWXSx1dtls1MGVDHMLvWdlufPZTGSZzKnkxyuFxx9rH6KvU970fBVVOC8xA9X vkKrNhs9bct16iSlhc9kNc573Y4x1L2aM32rtPWUW6a3w1MTWhrSXFpwtbpDeSbTl2rqptrp54am V0oY52C0k/5sLrhlPx5Y35cb48vzTP4kWR3acItqq+KRzWyGHAaTgnHsqGzcOUmbpbq3HXEjWOb+ EomjiBr+oZ98qMXHJypc/wDjmH074YWZXP7YnkLErIFBC5uhDssgOFj90/sg2VkaX3Gma0EkyN4/ UL9AaCslt23pqoCGyQ0znNyOxDeFQnSF5/gN8pq91PFUCJ2THIMghWSj+IvT77P+DqbFOYnM6Hsa 8dJ45Vn+0t9OflxuWFmPtpLRvhcrlqKjptQvp4qES4dJEzpIPYZ+imXdWyz6y0jbhZHRzRiaORzg 7jpBzlUm1VcKGtv1ZVWmB9PRSyF8cTzksB8KTNpN663R1OaK4skrLcB8jQ75m/QfRauWs+WLM8fL CY5LKa8qoLTtlVQV88cUjoHNb1HgnHZUIqXdUziPdSDuxuZXa2uLyHPit4P93DnHHjKjkkuJP7K3 KcJhDHx2eTLyX5bnR4LtR27A7VDD/wC6CvLuMx0m01Wxgy90OAPqqT7eXyl09qWlr7hRsrKeM/NG f6j6q0Mm/uiqq2CjqqGrdAQMsOFnDLjnM/pry4c8LjFdLnttqWhsBvklCTbh8znNOXNBPcj2VgPh ILnWi4F5JAk6W59sLyav3v0jctK1NsoaWpBe0BrXsGCAex5Wehd5NvtP29gorZU0M72/3scbct6v JTOTLsx3P10in4jiTubXOb/lb/RTN8JMj5NNVZkJOJSBnwMBR3vBq3brVluqau3QV0N/ODHMW/Ke ezhnGF0eze7uj9MabhpaykmpaxrcSGL5mvPutebLnluMeDx3Dx8b7c/reWR+/wBHGJHBn4tgxnjG eVZXWGp6TStjpq+4x9VI0ta8gZLc+Qq73rW+30+41NqCKGrqGvz6zXjp9Nw5D2+/2XYa+3X2+1Vp aotNRV1kfWzDC2PJDgOF18mWGXkmXxpxxwzx8XGe9q87wahpb7rS5Vtqle+ineXNyCM/ouC85X0q nN/EPDHdTQ44PuF8z2XLPLldvV48eGOkjbLarbpHVDKyajZV0rwGzNLcua3P5m+xVxqusr9S2+ku ug77CCAHOpZsOY8f5T5aVTPaDWsWi9Rtqqqliq6KYBk8b2g/L7jPlWPo9fbWMu7L3Q1sturXNAc2 AFjT929iua14LlqtmoNyrJb7zp0W7UFBUYdP15Lm48cctPcKYNXXr+GXGx0zYg6Ssn9JsmcFnGf1 yolvm6W3921jbqysxIaRpdFcI29L2n/KR5Cz17u1pOsuunKyhrzUso6r1JWhpDg0jGVvCS3tyzt1 NfbvNeaHpL5qyxXKnH4e4QPc588R6Hloxxn9V0NorIHXmqtLrpLV1FPGDLBLGOAexzhR1ft79K09 ytVVQ1n4mIudHUNDSHRtOOQsmbkaAoL9U36ivPVVVbWMmiIOC0eR7EKTWu29XfTVaf2607U7w3uR tG1jKTombEOWBzu/ClDT+oWV+qbnZoITEy2saHeQ7q7Y9lFs+6GkLLrcXm2XNtZS3ICKsja09UPS OHj3HuPot3R6+0Hab5W3qivrZH15YJ4iPA4yPbHsumVwu3GY+SaezRNvpKzdTVdVNAx1RTOjDJCO W5Hgrz2zX11q9459MSCE29hd/g+bgZ7rSR7k6T09ruW4UN2iq6C8YFR0jmB7RgH7Fe2ium3FNraT VMOpoxWyEksJ+XkYKtzxtytMMMpMZ9JCs9qobfrG7fg6dkX4mFk0oaOHPyRnH2XF2PQ9HQbjN1TS yhprJ5aeSn6QG+cEfsvBHvbpmPXssUkoFHJGIvxYdlvBJB/mumi3H0IKtsP8Wo2sY7145evjrOc/ b/31z26WW9oV+KRzbbuBaa+jYyKpjhbIHtAB6muJGf2UwXyrN92Plr7hFG+eegMjvlH5sd1AW+er bJq7cCh9GZ4oIC2CaZhDgWdXLm/oVO4vuipdA/wCHU1I2nNP6LZHuAcAR5C7TPGeTC/TjlhnfFlP lF/woXeofeblYpWxy0EkRmLXtzh3YqZrbc2M3BqNJto6YW6OiE4BYM8nHT9lX7YS7WfSO51xhuFz gFN0Phiqs/I/nIOVKMGsdPU+9ktbJd6P8LNQCNswkBbkeCVzz1vKul5fq6zRmibBY77fKm3UDIph KPqAHNBIx7LPb+4U+qLbV3mst1HHW0s0tMHRs4c0e6+Np1ranaqu9N6uaOpaySOuj+aEkNwWlw4B Wx2/tFDZtNXCG3XKK4QSzyTGVgwAXDkd1bJ6Z7/231pSvdS8R3rW9bWxUcNI7q6HtiGGuc046se5 Xb6p3kulz23dpe62UMZLA2JtSephIbjBwRz2UV6ocBqOuce/ruP81Oe4G6GkNTbR/wAGbA5l4ZBG I+uAfK9oHIcn+RqeSyOng/8Ajm1an/nKyi7jnysHn5lnER1DK4uy2fwcf+q6g9wY/wDVSBtTI6Tc DXzS4kNq2YHgZC5L4Vqa02nSc1wdeKUz1xxJTvcGuiLT9TzldzV1+ndv6S9378XDLVV0plkMcgeC f8IwDx7LeN6sYy3yl+HzpNN2Cz0OotRVFthqqqSaWSX1mh4PQTjGey02j/7JbrWC6QSacpaNkeGF 8bWh4J7EOAyML66P1hadf6Gu1tgrIaK5TCXrjmdgDrJII9wvttbpuDbmx3V9yutFO2UiUmB+cBo9 u5WrJxl+duMuUzs+NNjpbSWl7foenZcrXRzxQdUDppIGue4B5aCSs6rbbRldZ6ywxWynZJC0f3zY gJY+rJaQ/uV8zerbJtbUVVLWRTQ/PKOlw6sep1du+cL1aG1RZ9RV96rbXXRyxSthwHHpcCGkEYKl xjrbZHjq6cUuzMVJ60jGNjbAZGO6XdPqBpIPjhe/bmyN09R3y2Q1U9XTNlEkT5ndTgHNzjPn7rld I6mtGs7Rd9EXWU0lZG6SFpDsF7erIIPuCtjNV2jZ7QMn4urmq55RkCSXqMr8Y4PgY8JlMZ+v1WJL lbl9xSzVbWtv9d0gAGd/AGB+YrVwM9SbpHuF6bzVNrLlUVDAQ2SRzwD4ycr5UL2x1LXO7ZCnksuV sdcJZjJVrtsdrdPaX0j/AB3Wwp6h9RGHtZLyxgIy0A+CVu/iKlik2fp3UsfpQPMJYzv0t8BbSuo2 bj7Q2+n03UwSzNZCD1Ox0ubjqB9kt19P1WotqX262mOWst7GiWMO/wAUbfmC7f41xxzxyteb/I5Z Y2SfKEfhx/g02tH0N4t/4iWqaBTTdWDC9uSTxzz7rZ/FTbWU+tLUwTy+lJSjPqvL+gdeCRn+i8Pw yWSoueu2V8LoxDbh1yBzsOPUCOAuy+LCwVclztF6c3FtbGKaSQcmNxdnJH2Xj8e5nlv09nlm5jp0 Nh210LbNAU1zNrdqCLo9SSpgH94R3Pyg84XH6/0Xt/eNFPumk5Ke1XGny8000nS+QDu0tJzn2IXd aK01eNM6eoqzbu7svNtqsPkpqvAaPctIPB8FffeDSVquNso9SV7YbTd6ZzHSBxGJgCCWEjufYrrj rfbFlvUrntsdsdM3DRVsqbtpOaWte0iSUycu5/NjIx9lxW/O2Nu0dUUVysmYqKtcYjTOyTG4DOQf YqfdXx3a/Wuw1ej6r+4/EtlqHwy9IfFjkfX7LkfiUoZrvoahuVA0S01FMZZiDy1pBbn9CVjXXbeP V3XQaeFrk2Wt0eosutslLGybnHBIHf7qA98toxpofx7Tp9ewy4Jweowk9ufLT7qbhZay/wDw/wAF stjQ+rnoY2xguxyCD3/ReLdKM2X4fp7bcXMirG0kcfQXDJcCM491jwz9JHXyycsr/UZ/CZ1N1fXs yQPwpyP1C0u6VjfqTfOutkcrYjVVUcPqEZDctHK7L4VLHXC4117MOLfIx1Ox/UOXDBPC8+saSWx/ EFSV91b+HoqqsjlimeR0uaMAnP0Kz48rjh5b/wDRz8kl8uE+HZP2M0XQU1LHVW+6VMwYBJLA8kF3 kn2XC7s7HQW9tvrtHRTOhnLYX0kriX9Z7OGf5hSru5LrgV1udocVD6Z8R9V0HSR1Z4znxjyF4I6H VFoumn6nU+p6esppJ43S08jBE6JxHBHPPPGeF0/1m6mFmd0+O1m19o0W+0VlyqZTqB7z0hjyGnqH 5S36cqNfjAIOr7YD4of/AMcqaNS2a4z7u2C8RxuNppqZzZps/K1xJxn9wol+Li2VLr9a7gYnGjdT CASY46+onH7JrV6TdsitJac8ArF2Qp42C20smuKe8uvjajNP0CF0UnTjOc/dRDrC2Ms+o7jb4XGS OmndGHHgkArU3rZub004Oe66/a6rnpNaWeSlkdHJ+LjZ1NOCQXAEfzXHLt9p7bWXLWdrbQU0lQ+K pjleI256WtcCSf0Uqrbbq6ir7Dq3SZt0gb+JnMEjSMh7XFowf3XPbybZQav1paHUEUVPNM1xrJWn pL2NI5x5dgrp9zNLV2odVaYnomjooZTPI53DQA5pxn3OCty26UVZuHBSU9TG6ppqaUSx5w4Fxbj7 9l1tks/6Yw7naH5dktC/xY2oaprI7j1dHoENJ6vbt/qtTafh/jk1jcLTdbhNFSMhE1JPCGkyDqx8 wPbC3dbYbwd/xXGgqTRGvbIJ+g9HSGgd/uppdzr0H2t+P19RZynG6bx7m0MN+GyjFzkjdean8D6Q Mcgjb1epk5BHtjC6LZHRlXobVWo7bWPZK10MUkMrePUZ1EA48H6LpaWrqHTx9UzyP7QSRj5uzQ38 v2+i3sWTuFWDP/6Nix/+Ees72lx62r/oAh3xCyOAHNZVf+QrVfFph2uoB26aJv8A5nLqNA2W40++ stVNb6uOlNVVO9Z0LgzBYQPmxhcn8WTx/byIf/ebP6lei6vk8v8A1/8A8b8n+nj/AOkChddt3oy5 6xvUVFbIjgu/vJXD5WN8n748LlBgPHsVbf4TmMbo+7uZjqE+QfI+VeLPO46n2uGMsuX0krbrTk2l dO1NnnupuLYCRHkYMTS38pH81TE0EVx1i2lnqWUkdRVem6d7SRGC4jJHlWv2SqK6rtOoZ7k6V9Q6 reMy/mwG4HflVKvUMjNQ1UTmO9X1XNDOnnqyeMK4/MTLu9rJbw0l1suzcVtknoK2gjbDCJ4muY4t B4cBkjwPKhzbXaC566p6qubUsobfG4sbO9vWHuH5hjPhTVupBMNhbXGY3l7Yafr4/Lgc5/VcZsRX 6ssdDPX09ulrtKvkeJmNcCWOGOpzW5z/AC5Xsyk/Djfnbz+PLeeUeWo+HWofRTvtOo6C4VEbSfSY zGT7ZDjhcPoXa2o1Ld7lbqy5U1oqqEDqZVN5cc4I7+FYU2eivlurr5tpXS228l7jLFnpEnu0sPA+ h91ht9bI7Xo2/anuVGanUErp3VQqeSXMPDceO3heed3UdbdTaF9b7IXLTNh/i9PXwXSnY7++/Dsx 6bf82cnIUr/C9da6ssFzttXUPlp6NzBAHnPQHZJGfbK6asuv9oNkbpXspIaZ9RSSgwwj5Q7tx+y5 D4X29MGpMDA6of8AylZz9Y5T7WXfPGz1EcbwbUXeyfiL4x0VXQSyvc50GSYwXEgu/dcdtRea3Tmt rdU0L+h8kzIHjuHNeQCP5qz20NdVXah1Jb7o/wDE0kNQ5jI5RkNa4uJbz4VaKCnZDuJSRRMw2O4x hoA8CQLeWVy3fmOXj1jJE0/Fg31oLJH5zIf6KMdHbGai1PZ2XRklJRU0hzG2pc4Oe3HDgAMYP3Up fE+1xqrGcfIGy5P6LtzfYdP7N2a41NC2tjZSU4MDsc5AC9Hlx5TCT6//ACx4ctTK37V71VsPf7JZ pbjFNSV8UR+dlKS57R5OMeF59m9B6mu92bd9OvipfwMgIqJy4Nc4d2jA54PKmq3bl1tysNbJaNE1 DLaQ9j6inlDmA9PJwGjtnwtrq+4TaZ2ntklkZHTGVsTXhjBjDmku49yvNfH+ScXeZ8dWPL8RDJXb XwNrOg1AljMhHI6sHOFS+pb6cjvqrk75h0m0VuznqJiJ/wDAqbVo/vXeeVua/FjI5yWeTLbz5WOU HgpLDoaCVihA8jKZd9Fge6CSgyLki7KWUFAJ5WPKPKuhmHcoysT9UZ4RGRKM48LFCaGfUjPssMoQ Z5RkLDKEGZdkoWCAUGWUZWOUsorIkpJZQSiHnlBPCSEDyss85WGUZQZdSM8LAlMFAyhLKAUDTysS kgyJSyl5QSqGl4QjKgPHukO6D2SVDyhCCil5Tyl45R90DSTQgEimkgEJpHuEBhCRR4QMIS8poBAQ FkEQk0dwl5QNJAQgE/KXdCBlL7ICEDykhGEDygpBPygEIQgEBJMIBAQhAIKMoQHlBQjKAQhJA0ZQ hAFCEIBCMoQCChBCABSTQgM8IQj9EAjuhJUNGUkBA0I+6WeUDQkmgChBQmwJfqmUuE2PaBwmAgjh MLi0yj/MFnfeLdS4/wA5WMPLis9Q80dB4wX8fsixpyPlXkPcr1k4aV5D3WolCSaSqBCEIBCEIBbO y26oudXHTUkbpJpDgABa5uMqxfww2eiqpp55YWumbIGhxHICDj37H6v/AAAq4qeCWMjJax/zD9CF 8bns1q2gs5uf4aKemawvcIn5c0DvkKYviH1jc9PVVHa7ZN6EUrQ9zmcO4PghdvtDqGn1ZpCOCrkb LK6P05WngnIwVcsbjrfy5YeTn6VnsOzmqL7bG1tBDE6M/wCFz8FbSLYLWb4w+OKlI7cy45/ZWhvd RbtEaYnkhligLWOEDZOznAEhv/0919duq6W66ebWTnD5sSkDsC5LLJuk8ktuM9xVebYTW8LS/wDB wP8Ao2Xn+i09/wBpNWWS3murbeTSt/O+N3V0/cK2dfdK7SlbE66zGqoK+odExuCHxEnLceCOV10I ppbS1lV0mKTIPX2IJ7Kbb3VGoNptWVdn/iVHQNqKbp6sRyAuI+y8emtstS6kpppLXRNeIiWuY54a 4Edxgq80Vrhs9qq4YABD05Y0D8vCqttrqi4Wnc+op6eU+hVVLmuYeR3zldJjvC5/TlfL/wAn4/4h u+2iusdxmoLrTSU1XEfmjkGDj3+31WsxlXN+I/SlrvOhJb5PAI7nSMBimZwSCeWu9wqaEfN+ixq6 26zKW6e6y2irvFfFR0ERkqJThrQcZXQai261Lp2Fk92tk0NO8gCUfM3J7AkdlstkWg6+t3n5j/RW n34LW7dtBAI64gf3W/FjM8+Ln5/L+LDkqXXbZ6ppLQbnLaKh1EG9bpGDq6W+5AXGdGD7hfodbYHT aB9GMAufTubz2OWqA3fDm6oiFRNfYKR0hz0SR4HPscrGOssdulysy46VsIIW+05pW9ajMjbNQzVZ j/MIx2Ui7h7G3vSVtNzppo7nRNGZTC35mD/NjyFIPw0WC401vkudpr6GZs3MlNICC0jj83/vIu1a b1aq6zV76O50s1NVM/NFK0tOPf7LxgZHsrG722at1XuTQ2y7CktdSYw2OUOMjXA9ueF4z8Nd4bIP UvFCyB35JOkkE+x9lrLG46jOGczm1fMY+pT6Spf1PsTqexVFM1kcNZTzP6BNBkhp+oW7Pw3agfSs lhuFEXuGTG7IIUa3ECHjkFMlx/xceFLWtNjdR6Zskt0c6lq6aFvVK2IkPaPfpPcKIzwcKEME4x1L PqOMB2FtNLaer9SXSOhtkLpZndzgkNHufopdj+G3VkkbXtltvIzzIQf6IbQYS493EpsJz+ZSTe9m tVWm9U9tqKAOfOcMljy5h+58LpIvhw1k9gcwW8gjuJT/ANENoettvrbjKWUVPPUyAZLYmFxA/RO4 26uoHhtbTT07j2ErC0n91NegdO6k203Mt1Jcqb0DVkR9Q+aOVufB9wp3330hUaw0pBRWymp3Vsjw 5jn4b0/r4Vwx5XTn5PJwm9KGjuc98oI8KQbjtZqih1FFZqq1vbVS8scOYyPfq7LpP/getb+n1Cgp HA9sThSOnKIbbkH5SthBRVs0QkhgnfGf8TWEj98LdX/RV509ehbLlb5Yq1+OhvTkPz/lPlWu+HjT l/sdjdb9Q0EH4B395C4gOIzyQSpejalshfG4h2WuBwQe6XW48h6sPvNt1cNUbl10Ol7dB6kUDHSM aWxg5zz91Gdt2o1XcblWW+ntThV0mDLG9waeexHuuuXjuLl4/Lj5JtwolfkDOV9ZWztb1FsgHnqG AthcbTX6dvZo7nTPpqyBwcY5G88HIP1Cu7oWK3at2thrLpaqGR81O5rx6LecDGVjXfFvlNclDDI/ gFxCC9zTnrwulj0pXXzUtTbbDRvneJHdDG+Gg+630my2uWtJOnqkge2CrnjccuNMcplJYjsPdzl6 HSkD8y6y1bcanuz6xlus9TM+kd0TMDcOY72IXqi2m1nUU/qw6frHsGc4b2x4WGnDid3fqKf4l+CM nCyqaGalqZIKiJ8U0Ti18bwQ5pHcEeFKkux18/sIzU1PVUc1M6AT+jkh4bjJ+islt1C2SbqJvVce clZtqZCMdR4XwkBYcfukzlwH1UvXSvUxz8ZyV9mPeHghxB+6sx8L+hdO3jT9TdrnTQ11W17o3QTA PaB4OPC7bTNPoDVd+uOn3aTpqKrga4O62BriO2WjutTG2bjGWclmNQ5shu27R0U9rvUDquzy5d0t ALmOI5xnuCpDr989LWzT9bT6Wt9TBVTZc1sjB0Fx755XZ6R2e0rTWy52yut0FZ0VDwyeRuJAxwBA z9Mrx6I2IsNmrK992hZco3PIhbO0EBncfqk6Zs3NKX3aaStuE9S9oa6R5eQOwz4XgLJCOcq7ekNG aJrNS36wS6cpXPoZfVbK4Zy1wHH6L6waD291Ncr1YYtPNpamjHQ6dnykE9i058fVazxy3bUwzx1J FGS0juMFMA+OF1G4umnaT1bcbM6YT/hZSxsgGOpvcE/XC5qNvU7HuubrK9dLVVMbcRSPaPYHC+s1 TUyNxJJIR7EqfNhtnKW7W/8AtFqtsZtBaTFCXYDx5cSO2F3MegNrtXtulm0/E2lucIIZIyUu5925 JyFdW9pcpOlRoayeA5jkew+4OCvu+6Vj2kPqJyD3y8raal0pcLLdKqlmglIglMQl9I9LyDgYK1Mt trIWF80EjWg4LnMIAPslmrqrLLNgXGrZF6bZ5hF/lDiB+yKe4VMDiYZpYyRyWOIJRDQVc4Jhhe8D uWsJCwfSTxE+owtI7gtIUV9ILjUx1HrRyytlznrDiHc/VZ19zrKxgbVzzytb2Ejy4fzXt0hS0k2o aFt2jkloPWb67YzhxZnnCsTu5tDpC1ba1OodPxVMcjGMljL5C4FpPkH6Fak3dJbqdqsDqPjKeXNd nBC6/byx0N31lbKG7uLKCWdrZSHdPyk+/hdx8QO3tj0ZcbcdOTSGmqYyXsfJ19Lge4d9kxnLcnwm WUmt/KMLdfrpbY+ihrqqBhOemOQtGf0XoOrr20SD+J1g9TPXiV3zffld3sbtk3Xd8m/HSdNupOl0 zWuLXPDuPlOD27rkNytOx6a1jdrVTuc6CmncyJzu5b4UVqbTe6+1TOlt9XPTSOGHOieWkj9F67vq 29XanFPcLlV1MIcHCOWQubkeeSueAIJ7r2W2jkrq2Cmix6kr2xtz2yThRW/s+sb/AGmj/C2261tP T5LhHHKQ3J7nCLtrK/XambBc7nV1ULTkMlkJAP2U+s2N0jYNO0U+srzPR1Ux6DIxw6C7GcDI9lzu 5eyFBa9HDUej7lLcaKNpkmEuMln+ZuAO3smxFVq19qW10QpLfeK+npmklsccpACKjXeoaq2TW6a6 1j6KYkvhc89LsnPZc06B8bjyAF77HQwVV2pIa6b0aSSVrZZW8lrScE/sg6G17j6qtdBHR0N7r4ae MYYxkmA0ewWv1HrW+6iijivFxqatkZy0SuzgqZNyNi7PYNC1WobJeaqpbE1sjGStaWvaSB3GPdV7 kiLHcIf9um0xr7UemqaSns10qaWB7uosY7jPusNS62vmpfQN7rpqswZ9MvOS3Pdc16chGW4/ZHS4 kBwygkC2bu6yt1HFTUt5qWwxNDWNJBwB2HK1OpNcXzUlRFPea6WoljGGE8Y5yt7s/t9Q68udVRVt 3FumYxphb6YcZSTz3I7Jby7cHb2901DFXfjo6iD1myGPoIPVggjJWdz1F0UW8GsY7cKL+LzupxH6 eCAT04x3K1epNxNRajtVPbbvXPqaSAtLGvAyCBgcrj+l4PzJgEqmk16N3ufpnQhstHaIY69rXNZW RkNzzkFwxyQocvFwmudwqKuqf11E7zJI7GMk8lTToHYlur9KwXel1JAyR7T104g6uh3+Uuz9vChq 9W2S2XKppJS0yQvdG4t5BIOEw/bHlPSZal4321wC6LROrrto67C4WWf0Z+kscC3LSD7hc+WO8f0T 6H45ComH/wCCB1o9rmmsgIcCMeiFwdHq660d9bd4KuVle1/qCXPJPt9vouaLSO4x+iXbuixNrfiI 1kCC6ejP09EBaeg3m1NQagq7vHPFJUVQw9r25aBnOAPCirgHKfftlSo7+Lcy/Q6kfeoqromfUGpM PeLrIwT09uy3VVvXqWp1PT30SwxVUMQh6GMwx7ck4cPPdRSG5HIKYjH1RqX4TmfiN1Zx0w24Z7/3 R/6qJ9X6krtT3aavuchkmkPAzw0ew+i0mAPf9kFuPcq7Kw7n7Lt9t9w7voavfPa5AY5BiSGTljvq R7riMcrsdA7e3zW9XJFZqdpbEPnll+VgPt1e6l1rtJv4SVJ8RGojW09QykoG+mHBzACBICOM8+O6 jy7a7qq3Xf8AahtPBFWCdk/ptGWZaAP5rs6r4edZxQPeyKglLWk9LJuTgdhx3UQXOiqLfVSwVUT4 ponFj2OGC0juCFCp1q/iMu1ZQz0lTZbbJBMx0bmO6sYIx2yuQ243Yu+h31MdE2Goo5z1Opp8ljXe 4weFFwPtlAb1n6K7TSxU/wARdx/DStp7NQU75GlvXHkYyO4wcrndFb3XvT01a6oay4RVTjI5kxOA 89zx7rm6DarVVXpOW/xW/wD2FkbpCHPAk6W8k9PfGOVwDh0uIIKgsKz4iaxlVM/+D0hppYww04cQ wOycux9Rgfoud0BvDLpGvu8sNsgkhr5PU9MOI9M5PA+mCoc+X6rEtbkE9Stiy69LEXX4hqmW11VP b7TS0NRMOJo3cg5zn6qN9Ba+/sxq03mpoYLh1h4eyUDOXf4gfByuAw1zuckrHgHyoJ63C3uptYab qLfPY44pnYdFN19RjIIOR+nCx0PvlLadOMs17tkV1pocCIyEcMHZpBHOFBDi1uOrOFsbDaau93Wn oLXCZ6qoPTGzIGT+q1yqakT1fd/2yafmoLBZorU5/AdG4YAPf5QAOQvPpbfcUunYbVqGzRXZsLh6 cj3gANH5QW4OSPdRnqjbfU2l7cytvVskp6Zz+jr6g4Z+uFz1jsldfrpBb7VTPqKyckRxtIBdgEnv 9Am9E7vSc7tvrSXbT90tN0sYqYpy8UzvUDRC0jDRjHJBzzkKvNY8OncRgA+Fv9VaWvGmKuOlvVHL STvYHta/y334+y8Fi0/ctQXFlBaaSSrq3guEbO+AMkp8aT521HflYkfRe2pt89JNJDPGY5I3Frmu GCCO4K6y0bYauudDDWUdhrZaaZvVHI1oIcEX24YYx2SI8Lq9S6Gvum2RPvNsqKNsuQwyDg4+y+Vj 0TqC+0U1ZabTVVdLC4tfLEzLWkDJH7IOXISwvVV0slO8tkaWkHByF5lRie6E0kQx2SKEcoDKM5Qh AJIKEB4THCR+iO6AzlNLCPKB54SR4QgEeUIQB5KEJBAwUJHlNAZQhIoGllCR7oMspeUIQCAgozwg ZSOEJFA/6oQjCBIwn+qWVVGU0kIgQcJdsoAQM9kJJ5QBQEEoP6IpIKEIgCPCE0Uk8JJhAIQhA8oy khA/PZLPKChA85RnhJCB5QkmiBAQj7IAhHcoQgeeUJIQNCSPCBpIQEDQhCAQUIQCD3QhAZ4QEFLu gaEIQCAgpZQNCSaA8pJpFA/KEIQBR4QjyqF+qE0IoQkmgSaEIBJNJQCeEs4T4Qe0LMBIDnhfRcVO IDqWOoXZp6EDz1n7dl9YRyvlqEfJRjk8PP8ARJ7WNQ78hXld3Xrd+ReR3dbiUJLIdliqgQhCAQhC Bt4cFYj4ZL9RUdbJSVErY5ZHhzQfKruF77dWS0czJqeR0crDlrmnBBQWg+JDSdyu1zttxo4vVoyP TdI056Se2VI22NgptLaYilqGsiEbA90n9Sqywb26titf4B1RTywlvSfUiDjhfX/ts1QbK+2ulpnU 8jCw5iycEY7rWeVzs38OWHj4b0tNrO1UWudHVMVN/euLS6Eh2MOwekr7bZUs9DpSGnqo3RzxRhrm keQOVU/S+9GpdO0QpaWaCSEcASx5wuhpfiJ1TAzp9KgeM55jKlytkl+FmEltTebJfdU1AF0qI4rf RVTpYB0fPjqyAf2x9Fv9wKuW3bdVU9O7pnhaOkj36lXg/EfqV7S38NbmH3DDytRqDfPUF5sdRa54 aIRTDDnNYeoc590x1MpaZ42zUWs05Xz3PRQmqiHPMHfz+VVf2307X3LcWStggcYIKlzi8jgnK12n 989RWWy/w5sdJURBvSHStOcfovFo/eG86YmqH0sFNLHM9z/TkacNJPhbmWvFcPuud8dvl5/xZLfq qgp9rq2mnlZHNIxoYx5wXEHnHuqOE5d7LsNwNfXbWleJ7k8MjH5YIyehvuQFxp4Kzy/WY/Tphhq3 L7SLsZ0/9oFv6iAMk8q0m/Mb5dv42xsc/wCePPSM9jlUgttfNb6uKoppXRSxnqa9pwQVOVi+Iq9U Vujpa+30dd0AAPkzk/dXx5cMuTH+R4r5sOO1mrSyR2iWsgz6xgIbj36VydvvkrrHFaNxrTNEJP7t lUG9TCfB6h2PZQfqL4hrvcrcaagoqe3vJB9WFxB+2F77T8SFwht0dNcbXSVrmjHVIe654zjHXX27 Ld616s0zYjWaSu1TVafdGRPTnEjo245cCQctx39l4fhQ9Qtr3PDvTdIOkkcHjlcRrLf+43uyTW+j t8Fv9QFpfE8ng9xjGOQvLtvvfVaQtjaN9rpqprfyu/I7+S1U06z4hXO/7WrOGktIEQ/90p01U9zd uJnAnqDRj9wqs7l7wxazFFKbJTUldSyCSOpa8udx47chdBP8Qk9Zpc2uotcRlLQPVDzjPvhdMs5n 5McviOWOFx8dxnys8cs03TOjHJLR/MLX6w+TUenAOA6SXP3AbhQ5oveWbVtPBp98dLQVjwGsqXSH BcO2B7qYIKi9iroae9WmjrY28troXk9J9y3HBXO10RT8XVVLT2S3CJ7miWRzXAHGeAqinlxVrvi+ njfaLaGSNcWynIB5HCqgSCSV18vrH/py/wAb1l/27jaesvtv1NDVaZp56mrjGXxRNz1sz2Kt3Hdr XrejpaS4VFZYdQNALW9Rifn7dnBUt0Pqmv0lfIblbJCyVh+YeHN9irDj4hdOV/4ee86cE9ZEOJRg kH6HuuT0WJNsVTqmj1mLLqAx1Nua0OpqoRgGQZ8n3XGfEZf7xaNQWeGwT1ENQ/Lg2Du857YHdcrq f4jHVFVROsVI6CCF3U9k2D1D2B8LcS7/AGkrnJTVV20++SshA6X8EtP0K1LJ7ceNutV4bZuBqu86 gslo1VbGwAztLJJaYseSPIJ/0U562ulRb22SGn6emqqGQydQz8pHj2UJXf4g7NW3WjLrO+W3w89E uC9jvdp8LDWe/Viu8VufQ0VSyWknbKGyEYOFfFZL+x58crj+qxVa1puNq6mNcXdQc4jJwACuK13r uwab1LHR3GnuElYWtcxtK4nP/dBUa3z4jbbPFb5bXRVDKqB+ZGyEdLmkYI916Jd7dv7hdILrcLJU fxOIDpnABc3HscrM18tZTL4SLZNQ2TXt8p2G1VUNRQD1WurIeh/PHGeVuLVe6io3Cr7MGsZSUdMy RvSMFznZznweyhK9fETSjUlHUWuizQR8SiRoEhB78+Vu3786LZcHXWlo6tlxexrJHYGHtHg8pNau 2bjlbLK7jTJ6t49SF3+GjgA/mstJu692NTgjhkMIH7FRhct8tMU+pYL7ZYKoVMwEVbHIPlkjHbHs Rz91tm74aFp7jLdqGCsbXzBrZct4c0eF1vkl3/XDHwZTj/Noh+I8dW51YcZIjaP5KyOyo6NmaLP/ AMheT+yrnvXqzSOqLrR3axNqjWdQFVFMOlr2DwCpe0pvdoG36Ygt4iqqVnp9L4OnqDcjkA5U82Uy zmUdPD48sfFwvt8PhdpoJqrUk8kTHSNqAGuIyR9l3t63E0zYdQTU1fdK+OeJ3zQ46mfsoH0PujZd E68uJtBmn03XvD3B7cPjP098Lv2a/wBqDqV9/f65uMgw572Et/8ACeEzyxyyuTeOOWOMkb3TOrrN ft1IJdMzEw1MDhVgMLA9zexI9+e63WvtyqDROqKCguUZjop2GR8zB+U5xyPKjqz7saAbruqus9Ea SSNvp09XAzAkae/U0efquU+IjWGjdZWyGss1fO+7QYa1hjw17M8g+xUmWNv7fRccsZOLlPiLvemN QaqprnpaSKR0sfTUuYwt6nDsSPJ+q9NNe9zbNt42F1LUHTrosNkfEHtDD9fZQr6o9T6Kc7dvv6W3 X9mK61Mn/wBnNOJmyEfLjAOMd1nCyZRrLHeOkETnqkJ8klYR5Dhj3TkPU9xHbKGHBH3WcvbpOomD Z2u1fpo/x+wW2sqrawls/QwuY9o5cDj2CsFYq7S+79BWvpKV9r1AxgP4iP5ZWex6h3HuFGPw5br2 nTdqmsGoHtp6NxMkdQATye4IUhaNv21+kbpcLlaL6fWqwetkhJb3zgcccq43Xe3PKW307TaiiuNn 0fcKO5zGWvpqiVhkLi7qwAWnJ+4Xk2s3Ek1ncZqN0Bhkooj65yCJHZwCPbsVpNMbxaSqaK7/AIuu ZR1EsznBjskO+UAEH64UZbAa3sOnNV343ivjp4qkYilP5XYJ8q5643XvaYzLl360l3b3nd/Wzj4b EP5LT6r3Z0vorUt3iFqlbdXZbJNHgiQgcEr16W1loWg1Je7ub/E2prpMODj8haAOkjjv3VfviOFl qdUi76fu8NdFWgmVjDzG4f6FdMrjbaxjjlOMR7rzUc2qtS1d2qmMZNUO6nBgwFoqbHrDPuF8CcuK zif0PBXGvRJpeHR7vS+HOIt4/wBjk7fcqplorrrR3sVFnlqmVjC54dT5LgPJ48YU17CbrW9lm/sn q0xNtzmlsUz+AAe7XfT6rvtJUG3OgZrpdrfeqStml6nxtc9pfGw92NPkfddZnPxTD52888eWPmy8 nxY9Ww15k1poqsg1FFFVfhpQPUc0dTvIJ+uVuHak0hrSG92W4upI4IsRFk+GPJGQSD5wRwtbtTd9 HW61V1dQ3umhZcpnTOp5iI3RHJ4xn2KrXu9DS2XXdaLbcoK+mqf9obLC4ENLictOPIWJrjd+27yu UnxpbXQmmLNprRYNtFLCHjrdUVI62k5wCe3cLK8Uem9SafrLbqCpskzJGnD6ZwYWkDgjJ4IP1XE6 E1dp3XO1LtPVN1jtdXHA2CUzOAPHZwyRnK8EGiNu9Padrp7zeIbrM3LhLFP0vaMYAa0HBWN79u1b fQehtObbaWqtR3IsrHSM6xM6PIaw/lbj9ufqtnvZVit2MqqlrGsbPBG/paMAAkHsvHbbzpvcHa+T T8N5ioHMibA585b1ANIw7BIznC92rG2XUG29bpenvlCyopacRh75GgP6RkHv2OF18dxmUtcspldx X74d7pHRbgQ0tRRU9VFcCIHCZgcWc5BGV1nxW2+jor5Z301NFD1xEFrGgA4dxwuY+He10dVr6Oor rlT0bqAiZrJDgTHOCAVIPxV26nudso71Q3GkmbRf3ckTJWudhzuHDC5/4/6553L1Yn+RN8NfFdn8 P+tKTU9FNTwWemt9RRxRskkgAAlOMZ4CiL4kdX2m61VwssdjihuNHVYNc3ALsd88c5C+3wsastdn vlfQ3KdsElb0iJ7zhpIzxldpu3oXRAs96vd1uAZc6qR8kc0MoeA4j5QWg9vCz47ZLt38uMutKgZy T3Xrt9RJTVMc0LiySNwc1wOCCOQV5X8O47LY6elp4LxRTVbQ+njmY6RpGctB5CqVaXRm4enNw9IN 09r1zYaxnS2OfOC53YOaf8JC9Gu7TqbS9opbBQ1pr9H1zmU/rOjDpYQ5wBaXDjHsVuNX6KsO4emL RW6RktNE9ri/1egM6gRgtdjnutzqappdHbW0VuvVdHJOwMiD2nq6y1wPH6KX2s17rT6ztGhNs9PW 38dpmmuYkcYhJJG31DgZy445Ue7k023F80a28aYkpbbd4Gh34KMdJkBPLSPceCpT3W0yd0NN2efT txpBAx7pRJI7ggtxj7qNtYbL2TTunaJ4vEn8eqHxxMZK4GKR5IDsccDn+SuXU6TH2lyOK2TbO25l 8mZFQClhfI6QZa7GCAfvjH6ridf7TaYv9tst3s9MLSamWKOSOBo6Xte7HbtkZ7roN2bc627ET0Mj 2vfTU8UZcw5BLSOy2NfcKeg2w03XVEjWwQOpJHvzkABwyV0wxnHHa5Xed+mDtptI0VPSQM0pBXSR xhrpw8MJI4y7nuVwu7+ydBUwW+t0pSRW+skkZBJS9WGO6j3z7hdnurp/Uuq32ur0XcY4oPRd1PFQ YwcnIIwDlaastEWjLlpyqv8Aq+rmmbMx09NVydbHeCW/Y/yXKXonvtstB6E0voKaz0lU2OfUczi9 s2cP5HPHkAjC1O6Nnob/AL3aVt91gbUUklI/rjJIBGT7fVdXqbT1XXbj2DVEEkbrTR0zhK5rsnkk ggeRytVrynFDutpXVFVNG2ziJ1KZurgPcCW5+hz3Wdd1vw2bnL+uHve2el6bfCy2aK3N/hdTRulk pi9xaXDqGe+fCjb4hNIWnSetIqOw05pqV9K2Qx9RcA7qIJGVZW+aeq3bsWnVgMRs9LQuikk6xkEl 2OPb5gof+LGzVbb/AG+9dINBNCKdrwf8QJP9F3xmN3v6Yt6xk/8A77dD8JeTYb71E8PYP6qL9KaK i1vupVW6qnMNOZpZpCBkua1xy0e2VNPww6frbZo+rq6uNrI7gWyQ4cDloyMnHZcdtfTP03vjPR3r FJO8TCMSHAf1kluD5yvN4MrPBlP6vlm/8jf8d/LszoWOr9F2n7g4cYkZISzn9VxN22m0pp7cSjpb 0J5bLdAWUrGSFropcjhxHJHsfquv1vbtya7W8sdhqpqWyPLOmZsgDWDAzx3POeFpLzpDUz9w9PRV V7F9jo5RUPyWtfC0OGctznkLvljxlrjhlys6bF+x2hLRJJ/FvXkZUVIFOwTkOa12AG47nBzz9VBO /W3UegtQxihlEltrAZKcE/NHg4LSfP3U2fFA270MdovVuErIKRxD5o//AGbiQWkqtGttbXrVpgN8 rHVRgyGEjGMqWakbxu3LHuVK+weldMauvNTbNSOqW1EjAaX0X9IJH5gf0UUA91M3ww2isrtw6Wsp oC+moml00g7MDgQFjLeunTCS3VS3T7B6OpvTo7pVVZrqiZ4gcyXGW925GPYFcnYdgQ7X1bbbpWF1 op4xM10RxI9rshv2wRyt78SFwvWndXWW92t8sETaf0mzN5b6nU44P6Fbn4edYVura+9VN3qWS17I oo28AEtBJ7fqtMS9beeHYbRU07qZj72JSCA97SGgge/Thc9pDYO1z118or/U1D5aN7RC+B+A5jmk hxGO66mGr3UrtU1FDC/8DRGSToqainBiDQT04IyeRhb3b661tFqy72PVdbTPvk7I5IpYvyTMAPI7 cj2S6l1WsbvG1X3a3bi3al1xUWi5yztpomyEOiIDj0nAXQ19+vW02orrpfS84qKR0zfSE0fW/LmD tjueVJe12grrpnXN2ulyMQpInSMa/JzI13zdQ+nj9FttI2Wx6h1lfdWRM/GSsnEcBcMtHTG0ZAPY 5GMq2Y97Ylyutf8At8NtbXcNMWWo1Lra7TtnljLnQTSZZEw4IBz2dn+qqxu5fKXUWtLndKFpZDUy BwB79gP9FOuuLXrjdC7S0MVGbTbYG9TWVfUwP57EgHJVcdbWKr05f6y13Do/FUr+h/QctJxnI/dY mOlc+M8qQ9jLZSXTcW0U1xgZUQOkJdG8ZBw0kfzUd5PjupD2MutHaNxLRVXGZsNO2Qgvd2GQQM/q s+WXj06+DXPtOvxJ6puFljpdP2yT8PSVFKHyFmQ4jqLS0n2wAo/2x2W/tRY5r5fribdbSCYXR4cS AcEuz2C7f4obDWVktvv1NH61tZTiF8jOeg9RIJ+hyOV0+ionz/DnJFTNMkrqOVoazkk9R4+6eS6y xk9Vy8XeOVv24Cr2CtNZaKyo0tqT+JVkDepsJa3BPsSO3H0Xg05sVT6g0rHcLbei66NIbPSvjAEb urDm578DPjla7Ruj9fVrq6fThqbfG3iQundAZPOAPKlv4bKSvprBenXCKaOZ8/8A7QEEnBz378+V c7x1prGbl24jUXw6tp7XWy2O8msrqbBNPJGG57EjI7HHIWr0dsHLcrELnfrq21Necxj0xIOk9iTk Y5WMG7OoNKXe80bo46ps0zuv8SD1sIyO/wBsd1OM1+q7Ts/bbpQ0gq6j8LC70ujrznGePK3Ju6jH LraFdUbASUlinuGn7tHd3Q/M+NrA0lo74wTytTtHtReb5MLvDVvtEFM/qhqSzqJc3k4Ht9VK1n1l uDeLPV1VLpuiFCwPY7rBjfgN5IaSCtvretq7btLZn210kJk/DskdD36XDDu37JMeV0uWXGbeL4hW PG19LHLMKl4ki6pvDyGnn9cKG/h7sMly1qaukuFLTVdABJFDMwn1eoEHGCDwFLu9rHjZy2ANcQPQ 6jjsOg8n9VDGwjZHbpWkxtcQwvLy0ZwOk91ry5f8GNP8TD/n8k3/AP3p1PxPxVk2qrRHcTTNcaRr RJEHBoBkcMnPspM2Q28pNIx1tSy50d0lqmMLJYWAGMe3c98qPfiuc7+01t+U9Iow3P8A33lbn4T5 XS0F9y4np9MAZ7d1jybwuP8AVmssMv44jeDQv9l6+K9/xCkrRUVzneg0dsHrAdz57FdXSbuai1fL RWfSNsFvqgfmMZDmhuOTjwB3XH6r0HqW4VVTcn0b2219UW/iHOBDQ6Tpz05zxkKZ4aCzbNaMD4Kf 8Vc5gQJenJlf5Of8Iwey7eafte9uX+PZPHOi3lqaSg2rloNSVMFXeHRBscnQMukBByB/h4UK7E69 rdOajgtTCZrZXzNY6Bx4a9xx1BeHcW26yvFC/Ut3oKn+HSAObKcdIaeAcA5/danZyxV911zbX0dO +ZlLMyaYt7NaHA5Xl80vDc9vT4rLnrL07v4odIW203WnuFtiEL60OfLGAA3qB7j2yq5v4OD3VqPi zqGeramNexxax4cAckEkd1VmXl5PhenOSTH/AKeXxW3e/t80voml4WHUIR4S7IHlLymUsoBLKfZA CAQEeUIBCEIBGUBLuqBP2STwgEJIQP8ARL9EimiGUu6EIDugoQoBBQhAIQhAJJpFA0keElQ8pJoQ IphCXhAJ54SQSgEIQgEI7IQCEk0AjuhMIEjPKeCjCKCgIwhAIQhAIRjlGEAhCMIBACaPKIEu6ZQg EJJoDshCEB4QPKEFUHlCChAY5TKElA0keU/KAS8oCfhAISQUAEZ5QmeyBFCE0CQjyhAdk8JYTQCR KaSoAhCeUUBJCYUCQhHlUHdHYoyhAeEIQiBPn2SSyUVtiP3S9lk7kLHyvOr7RdxwvhqEkfgh/wAL v9F9Yz2Xn1Dy6jz4Yf6haixq3H5V5T3Xqf8AkK8p7laiUJIQqgQhCAQhCBhb/S+n6y/1zKShjLnu PJxw0fVaKP8AOMq0Hwu26nkopp3xNdIZCOojlByNb8P9/hoY6qGupHsd+ZjwWOb9ueV5b9sTqG2W U3OGopqqFrepzW5a4D6Z7ruviL1VcrdqCkttNUOjpWxtl6R3znjnx2UpbUX+m1TpOKGqHrZZ0vY9 vcgcq5S462545zL0rvYdiL9ebVHXQVtKzqHV0SAghbeD4cNQTQh8dzoC3z3U+6+vVHorSrzTyilm lzHTEjI6gM4W00BJJWabZNNgyStDne2SOVPjay96Vrn+HDVMTeqOsoJB/wAxGFz+ptktV2G2mvki gqqZv5zA4lzB7luOysxW11Xo2st9PPM6qprlK+MRnvERggh3kEHsu6ifTst0YqHAMeOk9XblF2pZ Hsfqqosf8Vpfws8Xp+oYxJh2MZ8rwaR2j1BquhkqLU+kPpktMckvS7I8dldWsoI7dZa+KnAbH6Ti 1o7N4Pb6Kqezl/rbfuEaanmcIaiR3WzPBwuswn4rn9OX5L+Th8Ij1LYbjpy7TW670z6eriPzMd2P 1B8hag/srkfE/YqCv0KLrPTs/iEHT6cwGHAE8g+4VN3d1i43jMvit4eSZW4/TEDJwpJ0dtJqbVVr ZX2hlNJC7sHS4P7KOI/z544VpvhNnlfT1kbnu9Nsgw3PA4WfTohPXG2WqNG0jKq9UBZSOd0+tE7r a0+x9sriCHBWx36EV117brBcbhNS22qiHUGcjqyccdl4ar4cbPBCypkv9QKN3d/pjLfut54cLJ9u WHlmWNv0q6PmHK63Rm32oNXwyy2OkbMyM4PVIGnP6qQNztiqrSloF2stabpQN5laWYewf5hjuFIv w46ekishrbLe4uuT/e00sOQHY++VLjZN1rlPSsGobDctO3SS33mklpKtnJY8dx4I9wtpYNCaiv8A b5Ky1W6WohjBJ6eCQPYeVL+69q/j27cNBqqvpaL+4aG1ETD0kZOBg9irEaD07Q2TTDKSkqIJomxd InYB2x3KZY3G6rMzmWPKPz7jfNQ1P+OGeJ3IPDmuB/kVOGidXbqXq09WnZqmqp4B05+Xx9+Sue3u 0LHp66uuVNdKKthrJnEsieOtju/IUz/DxYKyg0yKuyXakqYp/nfDLGQWOxyMgrOX63TWGXPHatW4 921Dc71K3VJnFfHw+ORvSR+i47POMKYd36Sou+7E9Nen09FK9zY3SxZe0N8O/wDeXU0vw5sr4GPt 2q6Gdz25a30+T/NdfLhwy0x4c5ljtXhrcuwByV21LtlrCooo6yCxVktO9vU1zG5yF49b6MuejL5J brtF0vBzHI0fLIPcK3HwyXKpuGgo21Mr5GxucxvUc4AXKyzqum5ZuKTVlPNTVMkFQx8U8bi17HjD mkdwQt3Z9Hahu9vdW2y01lVStyDJEzqHC6PfFrTudeHYAJlOTjurI7H2e92DRERt89tulJMPUYA8 xkZ5wTyt+TDhlxYwzmWHNS2oilgmfFM18cjCWuY8YLSPBC+WSRjqU21WgrluTuRqCOL8NbqqKXqk jeS4AkkcEDnt3W2d8Md+6i1t0theO4GchTLG43VawzmU5RXv5uoYcVvKPTN8rLea+ltlbNRjJMzI iW/uuy3A2gvWhYoaq4vpZ6WR4Z6sLs9B/wCIeArJ7S2u/aZ0A2mdTUNypCwvjfBPgkEZwQRhJN2Q yy4y36UhkD2vIJIOcH6LHLuxcpVtu39x3C1de2Wh1FSTRzl7oJ34PJ7DHdbqL4cNWS9bQ+2se3ux 0pz/AEWs8eOVxTHPljMvtCOTx8+UiTzhxUj0+z+qJdUPsT6EQ1DBkyPB9PHg9S6Kp+HTWUMkbPSo Hteceo2bgffhTTW0JkuJHzFNrnf5uF2G4G3l90NUQxX2laxk2fSljd1MfjuM+65Brc4+6zYSy+n0 hbLI8NZ1Oc44AAySti6x3VrXOdQVoAGTmB2Mfsp3+GDby3X6Sa+XEmR1HL0siI4zjOfupP1RvLZr BrNllqaRrqON3pVD3xg9PsQfISY2y2Jc5jZL8qTPc9p8hfPrc4cuVld0tpotXXyS8bbx01TSzMEl RFHK0BrzzkDxn2XAx7C64lpfXjtMbmjOR6zerjxhRraJCe5SGSu4sO2mpL9dqi3262vNVASJGSno 6SO4yfK6KfYbXkML5HWUOawFxDJWknHt7ocoiYN5wvt+GkDOotcB35GFv7TpW5XC9stdNSyGuc/0 /ScMFrs9j7K8OgrHLLoFlFqux0UNXDEYXD0mnraBgHOO6sm7pLlJNvz+j6m8AlfXEgHOfpldQbBN cNbSWu0UxlkdUObHC3Azg9lZXeSltMWz5p6zT76KvjijayU0wHQ8Y/xhbvjsz4fLH5ceEzVB63nj JWLnSAcH9lMOzm1ldqS822vuVtnksEkhDpmnAOP/AH1IHxJ7buBoa7TVjc6KnhIqX00X+Fvkgd+F MMeW59Ln5Jhr+qwtlkwAXFYva9475/VWT2RvW21j0m+S8shfen59WOpi9QOx+XpyOMqUtIUOmdxr FXmp0dT22ie3pjqBE0F4PctcBxhZ01yiiRBaeUA57Lp9xrFDpzWF0tVNKZYaWd0bHnu5vhcy0E8D uo0zY9zPykhfVtTIP8Tv3W7sGkL3foZJbPbKqtZGcPMMZd0k+6+120LqG0Ujqq5WWvpqZpHVLJAQ 1ufcoND+KlA/O7918+t0hzklbu0aVvd4jdLa7XV1kTD0udBC54afqQvRW6Qvdsg9e42mtpqcENMs sDmtBPbJ8IbaOKSVnLXEfqsn1Ep4c936lXC2o0dorVu30VVPpulbVxRGnlkOcuc1v5vvyqt6k0xX 2yome+iqYqT1CIpXxkNIyccpP2lsS3V1XPx1crScSPb9jhZGtnz/AL2Q5/4l7qLTt1r4/Vo7fVzx 9RAfFC5wyO4yFjcLDc7aGuraKppg44BmiczJ/VB5IZ5A7qa4g/QrOaone0tke8g+CV0+29HRu1TQ uvFvkr6EPHrQszktPGVOHxA7caXsuhqe6aetv4SoMjMEOJ6muB4IK1hjc7xjOfkmE3VYYpXxu6mk g+47hfaa4VM0fRLNK5vs5xIX2qbXW0waZ6aaIP8AymSNzer7Z7r5z0FVThjqinlja78pewtB+2Vn 26PIA5x7ZT5YTwQpv+HPS+ldU3KttepKSSese0SU7myFo6R+YcLTfEFou16R1qKGxRvipH07Zehz i7DiSDyVZN718JevaN6W7VtNGI4KieNg56WvICzqbtW1TQ2oqJpGt5Ae4kBfBlJO9uWRuI9w0lY+ hICc4J9sKD30l/uNJCIqesqY4+/SyQgBfOrvldVOaaiqqJOg9TS95OD7rx/h5Q7px83tg5XzkjfH +YEH2wg2lRqW6VELoqiuqpYnfmY+QkH7hN+pLnLSilfWVDqYAD0nPJbgduOy0pPOEwQUHSU+tL9T RMigulayKMdLGiUgNH05Xmumo7ndpGSXKtqKl7BhrpXlxA/VaTqGUs4QdVHrfUEdK2mbd68U7W9A j9V3SG4xjGey+VbrC9V1DFRVdyq5qSLBZE+QlrcduFzQcssjwg687haldR/hH3qvNN09PpeqenHt heW96wvd7ooaW53KqqaeA5jjkeSGnGMrmS5Iuyg7Ozbials9BHRW+81tPTMz0xxyEALXXXVN0ul0 bcK+unnrGhoEr3fMOk5HP0XOg57lPKH9SNFu7rJsYa2/VuMY5kJK1sG4GooLy+6x3WqZXvHS6YP5 I9iuLDlkXcIO3v8AuXqe/wBslt10u1VUUkuOuN7sg4OR/NcVI7Ll8yQUs8IM84XUaM1tetHzzS2K tkpnTANk6cEOA7ZBXKZTyrod9q7c7UerLeyivVcainY8SNaWgYdjutLpfVFz01dY7haKp9NUtGOp vYj6jyudB45RknymhMB351t6fSbo0g98xNyuGm1TcZLwLp+JkFcHiRsgOCDnPH0+i5rIxyjr9lNC VbvvXq+62qagrLgDBKOl3QwNdj7rx6M3X1DpKllprVVNEEj+ste3qAKjUvJCA4lUTa74htY/4ain P/0IKL9W6iq9TXuqulxLXVVS7qkLW4GcY7fotHnCxc7lQZ5yso5Oh2QcEL5Zyl/RUSjbd4NR0mjZ 9OOminoZI3REys6nhjhjAJWG3+6190XHPDa5mPp5jkxzDqa0+4HhRnnA7rIO4U0JwuvxB6ouFtqK M/hoTK3p9WFpa9v2OVjYfiA1LZ7RBQNbSzthb0tkkZlxH191CLXFMnJV0Ov1tq+p1XfprtWRQx1M waH+k3AJAxn74XY6C3t1BpW0fw0GGtpGn+6FQC4xj/KPooeLvqUwf0UTSddQ7/6gutrlomx09L6n HqQAhwHnByvNozfa/adtLbc9lPXQRnMZqASWt/y5z2UJg/dM4QTrPv3d6i23Giq6CiqKSsLx6cgJ DGuGOkc9h3C5TbTc2t0LXVk1DTU84qmta5soPGM9sKNeMfRGR9VSfxMO5271XrqzwUdZbqSB0Unq NliznsRjk9uVzW224Nz0Nd3Vdtc18Ug6ZoHnLXjx+q4Muz5P7pB2FL/VieNXb9XTUFtipGUkFJG2 QPeIycSYIIByfcZW+Z8SFTPE1tXY7fL09urJ59+Sq1deB5/dLqwcjP7oJ/1tvtLqTS9ZZZLVTQxV DQ3qY45bhwPA7eFo9r94ZtDWqroILbTVDZpXStldw8EgDGR37KG8hx57j6ph3HdXd1o/ro9Zapr9 SXSasr5i+SRxJXNZJKD3ykTlEB9limEiij7oQjwgPCP3SQFdBo+yEkAgIQgEICPKBpeEIPbhAIGU k0AkE/KSA+6fkJIQZd0iOEkZRDQhLyoGhI9keEBlGeUJIA908oQqBLyhCBpIQgaSaXlAJoQgEJeU eEAPujugoCB+EkeUAIAcrJIJoEQl5WSRHKBozyhLygCgIQEDS90JoBCChAJFNLygYQjuEkDQhCAQ hCAST7o7+UAhCEB5RlH2QgED6oQgaEgg8qgCflA7JY5UAmhJAwkhGEAEygJIBB7JpKh+EvZNJFBQ hPwgSPKP5oHKAQmUvKAQmkgChCMog8p/r/JIoyitkCUwsunCOng5GV51ZRjlee//AO8pfPyH+q9E bSCvNqLipph7RA/zKsWNa/8AKV5XdyvU/svKe63EpITSVQIQhAIQhBk08hWO+GjVNvopDbaqQMme 4luT3yq3r2UVXLSTslgkcyVhy1zTghBajf7Qtwveobdd6XElC9ohkc3ks9ifopR0hRUWkNKslqA1 kMMYJe0c491UOPdrVzbeKM3iU0+MdJAP+ic27Oq57W63yXRzqR7egsc0HIVyty9sY4zH0t5q22UW vNFzRwxxSvI9SAv/AMLvBB8LY6Gpami0s2nqIy2dkYa4DnJxzhU1sG6+q7JRtpaC6SNgaMBrmh3C 3MO+2s4WdLLkMf8AzsKfGlk72sbbtK3K6PgqNQVkr46KR8lPHgDp4/n2Wy3NqZqPb6WaF2Jo/T6S OP8AEFWJ+/WtXNLX3JmDx/umrWX7eHVV6tUlvrK1jqaQYcBGAf3Q0uJbaqar0S+WZ3W/8McE9z8q rjsxo+4VmsDdREWU0UjsOd/iJK4u2byauttq/h9PXxmnDen+8jDjj7rzaZ3a1PpxsjbfVtMbySWv aCBn2XSZf8dw+3OeP9+aw/xLXWjp9BOoJp2tq5OjoZnPVg8qmch+Yre6s1RctUXJ9bdJ/UmdzgDD R9gtAT7qZZ7xmP0vj8Uwyyynyyj791az4UaKopqOpnnieyOWQOY4jAIwqog45Un6F3h1HpK3to6K WGSBvDRM3PSPZY9ulSl8RET/APtRsMnS4Md0BriOCernlTXqMkbcTBvL+gAfuFUfW28V71dSwU9x ZSM9GQSxvjjw4OHsfC2H/brqV1iFsk/DPjDekyOZ8y65Z8s8c78OH4tePLD7Wc198m0lafIpz/Rc D8K9LNBaah08bmNfISwuGMjCiG475X+v01JZqqOlfA9nQX4+bCw0Vvjf9K25tFCymqIGfl9RvLR7 ZTyWZeOYT3tcMLj5Ll8WNv8AEy5zNx5H4Lf9nYB9xlWK2ld6221L0u63OpmjOc89KqRuVujW69hp 23Kio43wHLJY24fz4z5C++3G7990TTmmpHR1FJ3EU2SG/ZPJnzylnwnj8XHDhXr3J251Ta5a281l A91v9QvdKwh3SCe5CnL4VYZYdKuEzXtJkcW9QxkKD9f71XvV9u/AyRxUlMfzthccPHsVs9Fb+XjT NniofwNHUtjHS17hh2PbhY8l/JlydPHjwx4pHisVDed/bi25Rh/pNa9gPvlS2+qit+saS1RW+kEL 4uoTGMB4IOMAqpWq95Lhe71Q3amoqa319KSRNBkOeD4d7hdcPiUuD6eNtRaaKSoYMeqc9Q+oXTye SZ5bscfH4csMZN+q2vxdM6rta3EfKGkZXd/C1C6DQTWvaWuL3uGfYlQTuJvO/W1h/h9daKQTAgsq QSXtI8hbzRfxDVen7LBQz2mllMTQ0SM+UuA9wp5M5nx/jXi8dwll+a4XewuduXdyRjMx/qrOfDQC 3baIOBDsu7/dVb3R13BrW9RXKO2QUNQ0Ye+N2fU9sj3UmaP+IqWzWWCjqLNTSPjaGl7HdHVj7BTy 5c8+S4YXHx8DtMOpKreS8/2YqJKWVkzhNK0ZAaTxkeexVha+vi05b2z1khr7y9uGsbjrccew7KtV JvpDRa0nv1vsdPTGpjbHURteT6mM4P0PK6eT4kbXNUNqZtMwPqB2kLvmH64ynkymefJnw+O4eOY1 HO8dx1Rcr/62pKOroqd5PoRytIbgfXyVZT4fpHv2qozISSGEc/qq/btbyw67ttFSNtgpjTy+qCZO sH6Ywuu0x8RtDabNDRyafja5jQ13ouDWu/TCm+5WpjbjcWm2meWb5PDSQHzTZx9wrC6vmfHr/SrI 3uaJHzB4BxkBoIyqnncuho9zItUWW0Clh/8AaU5fkOJ7key7jUO/9Lcb/ZbnTWt0bqF7i9r3562u GCB7FdLnMvJln8VjhlPHhj9LPPP/AMMkbQ0f7gkn9eFyehqmWo19q1kkj3RRPjaxpdkD5ecBcpo3 cSv1/eY63TENLC+kb01FLUT4MrDzxxxj3Xf6Tq/xV5ub6qwutVaMCSUuy2b6g4AKzcpJr7XjbZfp UL4krjUzbgV9NJNI+CJ2WMLuGnHgKJWEnA85UmfEUc7mXTBBBOQQVGDTyOcLf+Tf36X/ABprxxcT 4PpGO0vdGdbev1wS3POMBQ7uvYbled37nQUFNJJUzT/K3GPlPk/T6rkNttdXHRV7jrrbKcZAkiJ+ WRvsVYuHf/Rc1ZFdKuyzsujY/TMzQ0nHkZ9lyxy1LPt0yw3lMvp4/h+05ftG7h1FovbHQCSk9UNY /qjfzwQQu83F3Sj0VrmkorjAX2x0HqOMfDw8kj7ELg7P8QNhdqSsr7rbZHEfJSzR4Dms/wApC4jf jcPSeuaSnqLXT1cV3hcB1uA6XM9jyphxm9mUyuuKzWgb7a9UR116tEfTTylrcuaA4uA5Jx5XKt3a 0tQ3WohAvMk8bnNfG0OkaCDg4GVA+xe8DdFetbrrGZrTKS75B8zHfRSRaN29sLLc6q52y21UFbU5 9WQMyXE/QlXG46u/bOWOfKa9JL0OzT18rLjq20UYZPMRE572dLj0/wCZvvlezb6/1OpNN3GvrA1j vXkiDWk9IDRjjKhjTfxB22K/3GO40YjtFQ4lhhYGuz/mI9yt7aN7NAWNhorWyrZQSue+Vjm5IcfI 5VmU137Zvju+vWlbpq6ot2u5aqke+OeKrLmvacEfMrab6yvn2VlkmJe+SKFzifJODlVor7vo9m6c dxgiqarTr5A+Vj/leCe+PfBU7ar3b241BpSey1UtcKZ0XQzpi5BA+U5z4XTLyT83P4ZvjyvhmCPP ht1bd4tX0NhZWy/wyV7nGAnLQfOFIvxI60vumKqhislW6COohcJWhocDzjt9lWXRGq5NI6uprrQg SinlOA8Y62/9cK0zt7NA10Ar6tr31zoOkxSwdbQe+OfquXjsxytvy6eTG5THXwivY7aOfU8zb3qB vpWdp62tzgzc8nPgAruN691oLBbn6e0gGsexvpvljGGs8EDwePK2Oj95tFy6YmoLmXW4zPkDoIWf K1rv8pHZfLT2rNntONqTRyeqaggyGoiMpP7q42Y9s54ZZWT4U+uE8lRUPlne58jzkuJySV8qcZl+ y6HceqtlXrK61Fha1ttlnc6ANb0gNPsPC5yFwDs9lzvb0Rcv4bdaWeu0s3TzWQWy6xMIEsQaPW/4 vqR9VvtV6g1BpG0Vjda26DUFjqSYxNDhvS09vUbjHKjLavXOg7hokWXVlJTW6sgaGNqoYul8g8OD wMgqQjuPoKyaPqbay8PvNP0Fraar+cuB/wAOcdlEbqKqpdI7My3jTVJDRkUoqGMDcjk8Z9zg91Fd t35huFmrbZra0tuEdQOken0taQfBBXR6W3Q0XqfQ9Vp3UE5tlN0egGBxyY88YOPC8kNbtBpXTVcy kNLepXZc1lS0Pl5GMBxHAWpev6zZd/x1nw4+jHoCufAwmAVUpYxx56cDAW9sM9s1/oa5tq6JhtvX JFHC8cs6R7/Q55XL7ba00Fp/RLaWjvTIfWDpHRTHljyOWjjstTs3uBpi16KuFBcbrBTVInmc1rzj qDuxHus4Tjjfu1v3Ul6eitmmtvaA089PaKf02OMrmBzQ4+SD5K1GqLvozUul6q13y9264Pe1xjLQ GOa7HyloGcHK5Wk1jozXG3bLHe7uLW+PpjcS4dR6ezmn2K1lfDtRpjR8zWSU13rG9RbK1wE5Lu3I 8Bb1Nf1z/bf8dTYLfYdotBMr/SdPU1YaHTBgLnFw+UHnsCsPiAkMu31qkeG9UlVA44GBzyvCNUaM 3D2/oqC7XplqlhLOoPcA4OZ554IK+24N90tqnQ0lHDqCkjnt7w6PqcMSujHH6Faxsxssc8scsp39 s9+KeD+xeni+NhLauEA45GW8rVfFJSwf9ntocImB7ZmAENAI+Vbesv2ktxtH2oVl8itj6eRkj4nu HUHNHY58fVa7ee46f1lt1UMoL3Rsqre4vZE+QAyFgxgfcdlPFqcd/Rny1f8AtF3wtt/+qfTjtinl P8lu/iApIrlvNQUlQ0mKSOCNw7ZBfgheP4XDZKe/Vl3ud4p6Kpph0RwSkN62uBBOSVvt/JrPDq6y 6pobvS1o9VkctPC8Oc0MPUHcHt3WMesMp9x6rZc8b8ROklqtthtFFSUf8KooYm9DPxjAQQPAJIXC bv0Wm59KMvTv4VJd7W9k0DqdzSHkOGWkeQfZfbWQ03unpi1yw6kpLc2JxlHqdJOSMEEFwwuJ1tpT b6z6co6SmuUQvE72RMrGT+o3PUOpzm5wBjKs1Izl7SvKdNjTtJrC722ljc2lDnOEQIAdjgjzyoy3 2tOl9R7Xs1PRNpIrhBGx7BAWglrjy0tC7/UtDZ7lthPpmn1Bbw5tKI2zGVpB6RkEjPnCo5camZks lP1kta4tcA75TgppcvfTWTDDzj3WGcrJ2T3WJCiEmDwkR5SOUDynn9Vj4RlA8oBR2SQZDgoSR4QM FPKxTHIQM/ZHdJHlUMJrHKaDLKMrHKYQMIWKYQPynnCxTJQPPullCSDJIoQUAOE0keEGQPhPKwHC MoM0ZWOU0DTJ4WATJygeUZWKMoMs5RnjlY+UZQZZ5QSsUBA/KCUkEomzykllGUDQEIygChCXhFHY oHKO6MqhpeUBHdAeUDuhJA0BJCBlBR4QEC8JoSKAQjCEAj7IQCgEFCEBnlBSTQGOUIKSJo8JJ4S9 0AmhJA0vKEeEAjuUYQgEIQSgChJBQPwhA4SQPKPPCMcIQCY4CBylz+iDJGUvCWUNMvCxymUghpkh YhNDRoSQho0vdCENA5TSykENMkJHhCBpIJTQCXlNGEAhIIKBhCXlNAFCEIBCEIAIKEh2VDHdCAgo DsU0kKAQeChLyroZIS+yXZNB5QChBTQEZR4RhDQ/ZAHCAgd0UFCCgoGkgBGUAj2S8phAHGUfqjyj sgSeEBCARgpeEZQbvCCOEIyvM0yjHzcrw6hP+2wD2iA5/Ve1h+YfVeHUf/r8OP8A5GP9VrH2Nc44 avIvVJyxeVbiU/CSaSqBCEIBCEIGF1uhNG3DVVeyCjYRGT88hHDVykQ+cK23wx0kIsHqdALi53OE K467/D5JQUUNQ2+wjrc1pimj6SSf8pzyvNqnYGutVgN0obrFUtYAXRPiLTjyQQccL2fENqG4Q6+i pIamUU1PCyRsQdwHZPKnTay9N1FpeFtZA4FzBlsgyDwrlLj7c8M5nNxBdk+HqoudojrBe2ROLeos dDnHHvlbOD4a3zQCVuoog3GXZg7fzUs7q6kptLabNLC6WnqqsenTujb5BGcn7LpdIM/E6Va2U4M0 eHOx/mb3U2svavs3w0VjYzLDqCB8YGSfS8fuud1dsDfLJbhX0lZDXUwwXhkZD2A+ceQp/rqyXSF4 tNtp5XVFJcRI0h7shpAHb27rvTNTQUlPHUkBjw2PLhkEnjlTZLtUWp2AvH9nHXSiuVNMWxGV0Lml hwBkgHJWr0RsxX6vsprLddaRkw4ML2nv7E5/0VvtR00VDpe5spx0x+hI4N8D5T2+iqtsDdaum1sa eGZ7YZQ5zmA8HC6XU8fNnHPfk4Io1Zpy5aWvM1su9OYamI/91w9wfIWjcMlXD+Km10dRouC4SwMN bG5obLj5sHuMqnzh8yXDWOOX2uGfLLLH6b7RWmpdUXhlvp6iGnkcMh0p4+yl7/4GvUnphzblbi08 gknCifQMjo9U20sJBM7R/NX0rKGa46NEFPK2KV4GHPdgcH3WZrelzvGbUw1/tHqPRNKyruUUM9G8 9Pr07uoNP1HhbLSWyWoNUWSK42ysoHRvb1dDnkOCsju3cqK07Y1NJcqiP1pIzGOk9Qc7wuS+FR7n WKpa48NmcGj9ArnJh45n/WMfJcs7jr0rBrPS1z0jepLZd42NqGNDgWO6mkHyCtAeo92qeN/qSGu3 cjhqGSvgc2NrhEMuwe+F2tu2L0XcKaP06y6wTSNBxIw4BP1xhb8uEwumfB5fyYcqqkGk9xhd1p3a 3VF+sslxttE0wNaXBr39LngDPAK7y6bS2vSetoqPUlfKLLUf+r1LQAer2d7ffyrRabtltpdKmno6 oS0fpdLZunkNx3WNas23c9y3F+dssL4pHRyNLXtPS5p7ghd7pLaTVeqKFtVbKSIQu7etJ0E/yW/3 C0LaINV00enb9T3B9bMWvid8ronH3KtppO1z27RcVL0NFUyDpYQRjq6cDn7plNZahM947qieuNDX 7RlVHDf6J0HqD5JGnqY77H3XKuDge2QriXi4S7j2+o0bd7W+nu9M9vrSHpIZg/mb9wtDU/Dxpqlq IqWr1PLT1Uo+SORjQXH6e6uWNxulw8kym4qw3q8tQ8uzjCshVfDrDQ39lNcL1I23TgCCpZEMl3lr hnj6LcD4YKYOf6t/kDP8L/QHP81nS84qsCQMEEpEHPlWSh+GqcX+SkqbxikcwOhqGRA9R8ghe+T4 W3ioAGoOqNw4d+HwQfryml5RV4ggd0g4jycKQ919sLrt/XMjrcVFFL/uqljcNcfYjwVHZHAU0ssr Npc53HPuujqNIX6nsLL1NbKhtsd/8cdOWjPv7LqtltEUGrri78Xeaagmge1zYJm59Ud++VcLV+l4 Lnt3UWVlRS0jJohGZj+QfVWTdkTK6m355YcH911lNoHU9TZhdoLLWS0Bb1eqxnUOn34WWqdKSad1 abNXVdK5pe0Cqhd1R9Ljw7/qFb/SNr1BpzbcUlFNa7pAyncY5Op0eW47eVZP20zllrG5KY6Z1Fcd MXWOvtFQ+CojOMjz9CFIs/xA60lpnwvqoS17S0/3QS0FtJX7iy3Kspq2no/TmLXMe0u57nsui/8A gZNQfiJI/wCJUOGjLHdLsO/6LWePHLiY3lJUBXWunuVVJUVLy+V5ySSvERhvupftOxmp7hqeps88 LaT0O9Q9pMbvbBHuumk+GW/FrhT3a0yvH+AEgrN77rU1J0rwAc8ZX0PUBnrUy2LYPUd2lr6YTUNL XUbyx9PM4hzh4c3jkHwVs2fDTqySl9QVFsEmD/duc4HI/RRdoG6znhyCXHyVstS2Gv05eJ7ddad0 FVC7DmO8/Ue4K1eefsorJmQeCQttWWK7UdK2qq7fWw0zgC2WWFzWHPbBIwstH2ea/wB/o7bTPiZN USBjXSu6Wg/Uq5G5zrpRbLVdDeLTGRFTNidNDM2RrccBwB5Vxm7qJldTdUgycnJQXHwVIWhtqdQ6 3EslopmtgYMiWcljH+4afK6Wv+HPW1LSSzNpqOb02l3RHOC52PA47pZo2hYuI7uKBI7P5jhfWupp aSokhnjfHLG4tex4wWkdwR7rzNHI+6ivsxrnPGO/07r1VNJVU4aaiKaIO7dbS3P7qW/h101pq835 9RqSvhidTOaYaWXgSk+c/RTf8U1BSDbiIxwR5jmYI3hoyBj3XTxYfky4xz8nk/HN1TAF47Er6vgq BCJSyURns4tOP3UpbObUV2uLoJp2PgtETgZJiPz/AEH/AFVotbafs1u2nulFb6SB9LBSva35Q4gj vz7grOGPPKYnkznjxuT8/X/m5TZ24X2qmASEeAThYQfn5wlmrY3LubeiBkpHyh36LNwlB+ZxP3Ks 7ttrnb/TGgWso6H1bwWB0sM0Qk63+T1EcBSHpuOxbs6BrzcrFSUjC8xgwNAc0gZDmuxnIKnzpLdd qPAyA4aXfohzpDwS5WP2I2zsddfaq4XWtp5xQ1LooqN7gHEg8OcD3z7L3fFXZLdTTWR1HRU1M9/q Bzoow0uA8HC1PHblcfpjLyyTG/asrDJjBJH6rL+8yOT9OVdSjsmmtAbS092/glNcGthjme2djXOc 5+M/MR9VlDp/S252281xjslLbnAyGN0DG5a5gz3AGQVh02pUHPOQCSfugdZIBPP6K8lz2s05qnQl HAy301HWfh2PjqIYgx3X0+cdwUhtfpiybfVNLNaaSeohp3yPnkYC/r6cn5u+MhWTdkS5aijhc8Hg 5P6FJ0koH53fbKtbvzpGw0m29rrKC00dJWB8Q9WGIMJ6m85x3/VfTTWiNP1mwRqKmzU0teaaV4mE eJS7PBDhytTC7xn2z+WSZX6VL9eRoOHuysDUPcMEux55XYTbdap7ssFzLDyHfhnYP6rWXTRt/tdE +rr7NcKalZgOllp3NY3PucYWbNXTe99tGydzCCCcr6iokf3c4/debBGV0e39BDctXWikqmCSCaqj ZI09iC4ZCitQ2eZowHPA9gUxLM/y8/qrE/EloPTunv4RLYbdFRPnMjZRETh2BkHBXS3bbzRtt2ot t+mssRqYYqeaZ7XOBlGR1A845C1cLNT7Jd43JVb16rp6TJL0/wDNx/VeRzH9WSCVda+aI2ztmmIt Q1enGCmlax7Wxl2fm7cZwuV3F200bbaOzaqo6AxWnrj/ABNG1xHqsceCD4KkxtFUvTeezTyvn6T+ rlvZXXvu3u2dn0/BeKmwSOpZ+jpEJcX/ADduAVw+7ugNF02ibfeNL0oiZNOxvWyQuyHcEHPYhXHG 5emMs5j7VfdG72KRYRnhXjtOy2gqi3UnXbOqoMDJHgTOzyO+PvlRf8Q22mltM6RpLppuB0M34r0X kSl4cMHIOfIIWMbym43eulaSMLFfWQYJ+6+WFQ0IwmgE8JBMKgCPCAmUCJQjCB90AOyfZNLCA8IT CECCaEIAoR7J4QCEIKAwhNCBITCPCBI8oCAEAU0kwgEITQIIQhAuyaRHKfhAISQgMoJQEyiEnhCE AhHcoQLCEI8IQI/RJGVVGEIAQgEFHlHdAIQhAdkHsgo8IAJpI8IBAKCjCBlII8IzygEeEFL7IGhH ZJAJoKSAKE0kQBNJNAkdk0igEIR5QCRT+6EAQglAR4QASPCEIHnhHdId0wEDH3QgfdNAkIykimhI 8oQPKEh3QUDQhCAQjyhAJHsmhAIQhEoQhPCAQhCBJhCECTSPdPKAQkU0C8J+Ek0CKaEIAoCEAoDh BRhCoEIQPZABHdCEAUZyhLCKfhNLshAHkJJoHdAdggI8peUDQEIQBQjyhAk0AIQGEI8pIAoQhBuO vAAKXX+q+B6s8o5XmaeqMgu5K8Woc/jof/nQ/wBV6IGn1MnP2Xnv/NbF/wDOm/6rUGukPy4XlXqk wGLyrcShCEKoEIQgEIQgzjOHhWU+G/WduoWi01r/AEpXE9JJ4dlVpC9lFUyQSNfG9zXtOQ5pwQgt Zu/ttVXrVtHf6aZr7bK1sc+BzHg8H6jlSrQvo9I6TFRI3rgiY3LmAZHjKpM/XepH0zYHXmtMLezP VOP2Srtd6irKA0VTd6uWmIwYi89KuVuV3WMcJjNRdPVFsp9daLkih9ISPAkie9uelw5BHtlbmw0V TT6YNK6M+t6JYMHgnpwOVRq27hamttIKajvFXFCBgMa/jC2sG7esIWBrL3VNA+v/ALyi6Wpsuhpg 2Gsv1VVVNVTBxga6Q4iz7Dt7J7xVM1Jo6mlp3FsgmhGRxg9QVVpN3tZPaQ6+VX7j/otXd9w9S3ij /CXK7VE9McH03HjjsrjqXbGfj5TS69fLJJt7Vve90jvwrxk88dJUEbBaGrXXf+NSfLCMtaO+Qe6i Rm5eqYbYbfFeKltIWlhZ1eD4WGn9x9TWCnfDarrNBG7ktByFdy4cNJPHZ5LntYD4o9SW3+zUdmFQ 11cHB3Q3nAHcH2VSnHkr33y71l5rpquvnfPUyHLpHHkla7Ktz3jMfpvHCY25fbsNrbbU3PV1Aykj c90cgkcB7A91dfW1PVu21q4aaOT8R6JwGg5yqG6evVdYq+OtttQ+CoZ2c09/oVIb99dain9M3Mlu MflCmGXHOZJ5cPyYXH7cJdrhXTVToq6adz43EFkriS0/Y9la/wCGC21VFp10lRC9jZnGRriOCCOF T+53Ge4189ZVO9SeZ5e92MZJ7ld5pXd/VOm7dHRW64kQMGGteOrA9uVnyfu1jjxmosDcLdAd9/Uu kAEUsI/DulHyucMZwT5H+qle61NbQ3e1Q0Qe2hkLhKQ3LWgYx9vKpLqfdfUmpH0j7hWAupX+pE5j QC13vkfZbqm381nBSNpxXxloGAXRgn91vPPnd1x8Xh/HjMZUs/FjDMKG11LI3mJj3AvA4BI45Uo7 flldttC2CRr3PpQ0Fpzz0qoepN5dT3+yS2q4VMD6OUAOHpjJwvLordfUOj6d0FrqgICchkg6g37J lluy/S4eGYyz7dbrPabVVlmfdPRiqKd8nUPQkzI0k8fKrQ2YVMe3RDxIKkUp4OeoO6f+qp1qLeHU 99qaaeprWxugd1N9JvTz9cd10kHxF6tgp2RddI8NGMuZyUue8uVXLxbx4x13w31Us+vrw6ulJqT0 g+ofmyHHPf2XfbmUdZNuxpyaCCd1Mwf3kjWEtHfueyqpPru6v1c/UUMrILg93U4wgNafuApJp/iQ 1SyBjXNo3kDHzR91c/Jytv2k8PWM+llNese8WAsa5zW1TC8tGcDpPdc7v7fLhp3S1vuFqe5kkUrS SBkEY7H6Kv1Rv9qZ93ZXh1M1zW9JjDPkI+yeoviBv19tFRbq2jtz4J2GN4MeeCMK+PyTHW56TPw3 KXV+U5bIbi3HXtXN/E4aeM0eADECOrIUgXB1S+a5GKR4AdF0gH8vPP7qjm3O4900JWzz2sxubN+a OQZGfC6C4b36hqtRMuzHxwPAaHQxk9D8e4WJpuzLc0mb4vnA6StoI59UnP6Knn0Upbm7vXPXlpho rjSU0TYndTXR5zlRWPfyt55S44yfCeLC43Lfy6LRk7otQ28MdjM7Aef+IK8+5NvrLrtlLRWthfVT MY2MNOMlfn3BM6F7XNJDgcgg8hTroz4hL5YrNDQVVNBXCIYbJKT1Y8LnjlxymTXkw5zSPNZ6Sv8A pm4Mjv8AQz00kwPpOfy1/wBj5KubtsHwbPUoeCHMpHdQPf8AKqj663Ru2rb1TV9V0Rx0sgkhpwep jXe/PvgKS7f8S1bS2+OCSy0jyG4JacA/om/25Fw3hxSB8LYH8NvpxgmrP9ApRpp6txgd67yDXPYQ f8gJGFVHSu+82nrxcqqjs9Iymrn+o6BhIDXeSPusaTf29U+p5LgyNhoHvLzROcS0E9yD4K3nlyyu X2zMdSRb2me52p61v+FsEeP1JUU1m5b6fW1wtdn0iK640zyHyQuAe4Z7qMJ/iOrnakhuNPbo4ohH 6csPqEiQePthbWL4kbfFUvqo9MUzKp/5pWOAcf1xlYa1XfaH1NW6h3aldcrPUWmeKi6HQzZy4ZOD 2Xk3a3Tq9Ca9pY5IBVW/0OoxZwcnPIKjq0fEbLTXarrK60w1JlOIXF2HxM/y9WOQuV3p3Xtu4Ntp o2WVlNWwuyKnry7H+X6hbmU+WMsMrrV9Oc3t13Ta+1HFc6WjdShkIiLXOySck5UbDusnck+ViBk4 WLdu0muo22nnvjuVO+Ilr2vBaQcHOVebdJ7nbGVTnkucaNhJPPsqSaGvMNh1JQ3GppIqyGCTqfBI MteFZK5/EVpy5WWa21mnZX0kkZjMXqDpxjt2V8eXHOZM+THljZHm+HzWl2sdu/BXO3Vk+mnucW1L IXFsJ/xHI8KTKu310VFW6i21vf47qy42+Z/qRO9w3PLT9FA+0+9h0fHVWytpX1Vie5xhg6vmiDj2 ye4Xc0PxAaPs8VQ6zaefSyyAnEXS0F3uR2Vyu7aSdK57k3qsv+qq24XSmjpq57umaNjOjDhxyPdc oDgrodeaim1TqSsu1U1gmqHZPQ0NB/QeVzw7rNajqdDueNQ20NcRmdgOD/xBW3+Jx3TttTjv/eR/ 0VedldXaU01JVDVdkbcHPc18EwALoiPbKmq/b56Av9t/A3e1VdTSjGGOA4x+q6eDOePycq4/5GF8 mHGfbw7ZbzaZtGhaKyXOnq2VELDE90IA6hnuDkFS2+usk22Elc2GofZpYHyOjc/Ly0n5uSe6o5X1 1oj1fNU26mkNlFT6kdPIfm9POeklWZh3x0AdNNs5t9XFQGL0zTtAw0HuBys4axylvpfNjc8LJ7VW 1LFSSX+tFnbKaN0xEDXcu6SeB91r5aKopn4qYZYX+0jS0/zXTUl2tls19FcqCOV9sgrRNFG/h3QD nB78qUd/9zdMa5slrjs1LKytglL5HvjDSGkYxkd+VM7LlbHTCaxkrg9rdV1mhr4LkLe2pjkjLCyd h6SD2IKuBt5qP+3eiKyqNM22uc50f+ynpIwO4PuoW0Du7pWv0MzT+vLe2RtO1sbHxxg9bR2+oIXR jeTQmltKVdFo6CoZKcmOGRh6S48d8rMl5S7TObxsRRtuZmbs2+J0j3f+kel7u3UOo91J/wAWGTU2 LI4xL/ouP2l1Zt/QPkuGp6aeK9sqnTxzscS3B5AA+nK77XW4O1us6dgu89W+SBr/AEXMaW9LiPoe V2mUx8mWX245ePLKYfx3NzvEOjto6Ctmpv4lAyCHMVQerPUAP2Xo0xdmas2xqa63QizhzZcMpgAA WjnxzlRnY91tF6h0NHYdZPlY2ICI+mCPUa38ruOxXsq92dD6V0VNatIPlmB6mthkBP5uHHqK59am nbu27dtrXU9TpLb+z3WkHV6foNdEeA9pHIP3X0tF/l1XtVdLxM0x+uyoLGE56GgHAyol3a3L0xqD bOlttqrnOro/RPomM92jBGV7Nu9zdL0O0rrJca10Fd0StLOjOertgrcsnCucxv7bSjuJfLdYdEWy ou1rhucB9JghlxjPT35CUt4pK7Z+e626hjoqb8M+RlOzHS3B+g+iiXevcjTeodB22hs1d6tXHJG5 0ZaQWgNwVsdIbkaUbs/FZbhXiOrbE6J8Lmkk85+2CpLMc/Hfj5TLG54Zz5+Ek6D1dctZ0VLUU9FN aqCIYlnkIJm4wOjIxjIUbfEVuxTi21mlrN0VDpmGKqlcAQAe7QPddlX6/wBAXPTcVrjv/wCApXRh pZTt6SBjt2OFw2vq7bBu2Vwt1qqKKpujIT6FQ+P+/c/OQS/GcqXXuNY85lq+lV3H5j7rr9qB1a4s mO/42L/zBcfMQXnC6Tbq5QWvV1pq6p4ZBDVRve72AcMlc67xdLeS+aXtP8Mbqq0NufqOeYWkA9GB yeV5N4Z6ebY6ploYvRp5YITFH/laXDAUXfEnq6xX5lkls9xhqzG6Traw8tyPK6686y0jfdqLbaZ7 3BG57KeOZgPztAIDjj6L0frjlhZXLHdxu/t2F2uFmtu0drm1LSuqqAU0AdG3uTgY/moc3O3Ztmor DTWKw0r4qIdIeJm4LA0/KGnKknWVz0RfdvX6dbqekjEUDWwyF4JJYPlyPrhVT0ZFbarVtFS3qtFJ QPmDJZxyGj3XPcmE1/s1N87v0u6bla7TpOwS3glsIEAa/OAx3TwT9FU/de9VZ1Le6Sgq5nWCatdJ E1hPoOfwSW+M/ZWK1fLozVGlaaxzaqpYI4fT6Zo3guPSMdvqFwm+U2laba6ktVgraKb0KlsgbE4E 5xgu/VMZJJJWN3duUbD4XbzXXiW9vuNTLUOpoIYYzIclrQTwoQ3c1HcZ7/e7TLVyut0dfJIyAnLQ 7PcKavhqm05YtNVNzqtQUrKuud0S00rgwxdJ47nJ7qFN/Lbb7friqltdzguFNXD8SHxEHocSctOP sni44YZY323nu5yz0jBx+Z31WB4WTuQsD3WGgmkgdlRkO6MIQgfdCEHugAhId00AU0k8oBCEBAJ/ qkmgE/CQRnlAYTSQOyB90ICPCAHCaXlCAARj3RlNAk0u4TQBS/VMpFAISCaASA7poQJCEeEDQkDk IKIaEd0IBCD2SQBCSaPKqhJCPKBpIQgEdkIQNLKaSAQUIKA8I8IHZAwgEeUI7BAFIJlCBIR5QUD8 oKWeEHkcoH5S8oQiU0kI8oBCEeEAjyhB4QBQUuU0UIKM8pIDKf1R3CAgCkO6eEuB3RD7oHCE/KAB QUZQUB5Qlz2QihNLumgEISQMoQOUIF5QhNAIyhL7IGhCEB5QhCBpf1Qj7Ih+ELHCfKA+6AhGOUDP ZLsmkUDSymEFAI+yWU0BlGMoQqDwkmhAIKAhAICPCSKflGEI7IDwhCSA8poQgEdijygoBHlCEAUi mgnhAJHuhCA8IQhQCWUwjn6IOhNN9OUCl+g/ZdEKEf5Ufg/+HK8X5Hp/G0LKY9XPAWlvgxccE9mN wu4NIA04b4XE6j6Td5OnnAAXTx5brnljprpfyFeVemXhq8y7RzoQhCqBCEIBCEIGOSpC2z28rtX1 rGtY+Okz80gHf7LgIceo3KuR8NUTRpWI4Gfm5/VS3Q42/wCwtktwpB/H5oZpTj0JWg9fv0u8fqF5 9Y7AQWuxC5Wq6zzOBbmF8WcgnBwR7fZaLe271lPuhP6cshbB0dDA44B84H1Vk9srm+9aZg/G0z2F 0eSHj6Lfkx4XTj4/JfJjyQ7a/h5tlVaWVU12qoZA3qc3pBHZe+H4crHLSNqP49VtZjJJY0ge/hdn vVqYWW20trhimZLWSMDJmcNaAeRn69sLubHFHNpgRzu6Y5Iy0u74yMZ/msLMu0HS/Dda5YBUUuop pIiM59MELndX/DzWWmjirLTcTWwkj1GOj6XMaf8AF9cKY66ql03qm12e2PLqGvpy5znEuaSO+M9v f6KQ6qtpKJtLFVkBs2GDOMdvKd+lmU1uqr33YH8LpZ92o7yS+OIyOiki4OB4IWv0JspS6vsP4uj1 AIqvsYvSDgD7e6s5uJDFSaGuzYBiP8O8gZ4GQeyrP8OVdUx6vfBHK5sT4+pzQeCcrrcZ+OZOWHkt 8uWF9RFOudJ3PR98mtt2iLJGnLJAPlkb7hc4Oyt98W9LTv0fQTuiaahs2BJjnGPdVDcMOKmWFklv y7YZzPevh1W3OlodV31tunuLKHqblr3N6uo+wCm93wxzmIOj1HBgj5S6nOD/AO6ULbWZGtbRjj+/ AV4tTzPptFtljPS8OZgjv+YLEm7pcrqKRblbe3jQtyFNdIw+B/MVSwHokH+h+i41jHEcNJX6Fay0 /Sam0nDR3SKOZspZhz25LSTjI9lx8ux+iYGxslstbK53BdDK4gf9FNm1KRE9xADSpQ05sjqK96ef c4pYYMMMjYpQQXADPfxlTNqLZzR2mXx3ieCrFsYQJI3SnLCTgFTHY4rXFpYijdMbc2In5uXdGPH6 K7Tk/Oeqpn08zopWkPY4tI9iF88OH+Aqxj9ttIau1w2PTNwqn07XF1XBKOxJ46XfdSDUbC6Hp3sj kobsXkcuicXtVs0sy3NqYku8MKMOx+Uq1V5+HG3t1FSPt1VKLVJ/vIZT84PjBwvfdtoNsrPWwUF0 rKylrJgOkOm4JP1wklvpbnJ7VJZG57gA0kngAKRKXaHVFRpeS+NhhZTxs9QxyP6XkfQFS9W7NaR0 3d4q+tuVRJaHub6TmyNyx+eM47jOFOV0pLUdDTQVNS9ttMRa6bGHBuO6uM3lJWPJ5Ljhco/OmVrm OxjzyF8z1HjoPCsLaNn7FqbWT49P3l9dZ2AOlPT0vDj3aCu6qPh70WycU0lbdmTOHHy5aP8AvYwp Zq6axy3NqhBpcO2FJ+j9ldT6pskNztX4KSCQdQa6fDh9xhdZqb4fLnbtWU1Ja5jU2moOW1DuHMx3 BH+qsLthoSk0PT/hqaumlMgyYn4IBx3BCkLl0oxrDTdx0vdpLdd4fSqYxkgHIIPsVoAMqZPid/8A zi1I/wDmbVDg4wuvmwmGWo5f43kvl8cyrptE6LvOr640tlpfVePzOcelo+5UgO+HvXrWcW+nP2qG rUbPbiXzSdb+Cs34eRtVIAI6gDp6zxnPhWZ0NbtfT6wbddRmnZbpI/8Ad00+WZ8fKuTraqnb9stT 1+oJ7LFbnsuEP+8ZKekD2+btyulk2B19Gzm1RnH+WdpVxILtaJdXz0TamnNe2MF0RwH9/Plc9abV qqLc2trKyR7tPuH9y0S5AP8Ayq617SZbnSmlp251Lc79UWemt0gr6f8A3kch6cfqeF0UuxGvIoy8 2YuDRn5ZWkq6DJqGLVs9O/0W1UsLXtbgdTsE5K5XTVFq+Hci5TXQymwP6jTgyAjOfbwrpnn2plZt BaivV3nttvtk766nJEsbsMLSPByugqNkdeRQukdYpyGjJDXtJ/qrB7s7iVOgdZNitdupKh1XC17g 9uD1ZIzkeSuj2xk1RUR1OoNWVn4akmaXR0J/LGO+clXLGyyfZj5JZb9KH11NPRVUtPUxvimicWPj eMOaR4IXmAJPupZ+I+8We86/mqbK1mQwRzua0APePOR3+6iiA/MB3Uyx43TWGfKbdbpvbfVOo7e2 us1mqqulcSBJHjGR38rau2Z1yP8A+m7hn/lH/VWk+GVmNqYDF+YyPxjv3XDaguW8lFU1UlJT1rqO Muc0tY13yj+fZJN47S56y46V8odvdTVl2qbbS2WufXUwBlh6MOaD2K99btbrOipZaip07cmRRNLn u9LIAHnhSzpHfq52/wDER3S0w1tylPR+Ib/dyZ8NPHOCpw22qtSSWqou+sqmOKkmaXMp3jHot+p8 5Cki8lEbPZK+7VzKS200tTUyflijGXFe/Uei9RWCkFRd7RXUcBPT6ksRDQfqVdzROndM0guuq7HQ x9U75HtwAB8v+X/Lk5WOmblJuFQ3qz6ssjqeAgObHMM9UbuxB/1V43Sfkm5H5+OBz8wOUwMldbuh p6DTGtbnaqR7n09PKWxl/cD2K5mmaDJj3Us1dVvG8puNw3Sl8bahc/4XXCgcOoVHpHox75RatOXi 7QyS2231dXHHw90MReG/fCvbtHS08+01mpquNj6eSn6XseMggroNMaatWmaCSjtEEcMbnFzg0AHk 8ZSMXLT886rTN5paE1lRbK6KlBwZnwuDB+uF8aGw3Ovppaiioauohj/PJFE57W/cgcK9uoYJLhtL dYYYTM98c7Wxtb1E/O4DAXNfDZZquz6LucNfRTUr3zkhk0ZaSMexXS+PU3v50z+XuzXqKRSBzXY5 BWDiccuKsLedgtT364VVyt7LeKWoldJG183SQCT4wtRV/DfrWGnkkjht7y1pPS2o5PHYcLGePHK4 t4Z8sZlUIskI7FZGRxGOo5WVZTS0VTJT1Ebo5o3Fj2OGC0g4IWELDI8NWW2fU7w4rLrdj85UoM2L 1k6ho6ttvp3wVXT6bmzg/m7Z9l8dUbL6s01bvx1ztrBTBwa58Mgf0598dgmk2jdsjgfzJukcf8ak 1+x2smw0UgtTHsqyPTcyVpAyMjJ8LXav2l1XpOhZW3m2enSOd0epE8PDSe2cdkHB9Z/zJ+of82FI lh2Y1hfLVFcLfafUp5CQ0mRrScfQ8rw6u2u1PpKhiq73bHQU8jugSNcHAH2OOyJXEmRx/wAafqHH 5iu/smzusrxao7hb7M+WmkGWnraCf0JWt1Tt1qPS9PDPfLVPSRSu6WudgjPtwiuRMrwDh6Rle9oy /IXfWnaDWV1oYq2isU8lPK3qY7IHUP1K0+p9C6g0wYf47aqiibLkMdI0YdjuARwqOV8kptJDjyu9 t+0+srhRw1dLp6tkgmaHseGjDmnz3Wo1Rom96YmijvtsqKJ0wJj9VuA/7EKK57rcTnqWYne3sV2N LtVrKrpoaim05XywTND2PazIIPYrT3/SV509Usp73bqiile3qa2VuOofRBqDUSu4LjhYB+DnJXX0 22esKqmiqINO3CSGRocxzYicg9itdU6Mv9Nd4rXPaKyO4yjqjp3REPcPcD9EGkFVIzs5yUlU945J 4XRjQWpzWy0YsNx/FRsEj4jTuDg0nAOPY4K095stws1UaW60c9HUYDvTnjLHYPY4PhB4xVSMPyuc PsV85ZXSHL3En6lYHjusSgCVj3TS7oGgJeE0D+6EkBXYyyhIIQMIQkgeUDgpJoGgJIQZZSSTygaC l4QeUDymsQEwgaEsoQPuUZSCEDyjKEIGEJJeUDTS7o8IH3RlB7JIGjKSAgf1STKSAQEeEDugCjPC EIgTS8IKAQkjwqoTKQ7IQCPKEeUCTCMcoPCAQjwhAIKEIAIRlGeUAOUJFMIDHKCgdkIBCPCRQBQe yEBA0eEkIDyhCETQR4R/JHsgMI7oQEUIQjHugD2QjH8kFAICPKAgO6WOcJpImj8o+yWeU8opgIPK MpHugEeEu6yAQJNJA+qATWPdMcIGjyhCAS8poQLwmhCBJpJoBJNCAQOEIRD7hCWUZQ0fCXnhGUBD RoSyjKGh5TSQho0JcozyhoeU0vuhDRkoyllCpo0FLyhNqaCkhNhoSyjKBoSyhNgR5QjKBo8pFAKb DPdCWUZTYE0soTYEISQNCSfhQCEIQTCafOMfql6AA7fyXuxwljhfI3XueB8A6Ccc4UXakAF8qOke yl2XiJxKiLUjSb9UjJwHL1f497rj5Wun/IvKvVUcNH1XlXqjhfZpJpKoEIQgEIQgzjOHglWX+HbX 9BRNjs9a4Qv7McTw7KrMvTTTPicHMcWuHIIOCE9i2m4+28NfrKk1HDWMkoZnNE7CRlhH5SPcH+Sl CvutNpHSzakASxN6WgNcBgnjKoe7UF0ka1stdVOaOwdK44/msqq/3KrhENRXVMsY7MfKSP2VzyuV 3XPHxzGaxXo1Jb4NbaQDWzRsdlszH4Dh1NOf5rdU1DOdMvpGuYJnwua0h3YluAqDUuqL1TQNihuN UyMdmiVwAXrj1vqKPHTeKwAeBK5ReK5entBU9qp2Vlxc6quTGkeq6Qkt+x9l497J3w2WzTRSdJFX GHPB7cqoUuutRvbh14rSP/nrl4rjqq818bWVtxqpmDs18hIWscuN2xn4plNLw6weajbGucx3qH8O 7sc8YUTfDzoOamkN8qJWYkGGtac4Cr2/WV9fRGkddKs03T0+mZHYI9lja9Y322U5goLpUwQn/Ax5 AV5fpMDHxa8lz+09/FNrG1V9DFYqaQyVkL+pxaQWjxg+xVYc5K9FdVTVlQ+aokdJI8kuc45JK8xI HYKXK5SS/DpjhMd6+Uh7J2epu2taM04BEDxI7Jxwrv3m2TXDTkdF0lri5hOfGCCV+d1lu9ZaKttT b6iSnnb2cw4K7Fu7msGx9IvtTj/mWf6tm11LlfrZRVFDZ6urjbWOc0tb1YPykHkd+VqdzaXVddNb 26QqZaeNzj600bhho+3lUgrtVXS4XEV9ZWyzVYwRKXHqGPqukpd3tYUsLY4b1UBgGB82SppnjtM2 7dl1jaNMme66tZXUZI9WllaInOGfA/xYUwaBqYLrt9FFQzMkL6fo+U5/w4VG9T63vmpTGLzcZqsR 8tDzwMr0aY19ftMxuZZ7lNTMdyWtdx+yqcFrtuNvXaF1G+rrLrTT/jCP7vBY4c5xg9+63m5bday3 2jj0nNLBSSMxJMG9TWOz3wqd3fcnUl2rIKmuu00s0DuqM5xgrdwb4a1giaxt5k6QMDIzhamRw6kn wtjpWj1La7lCzVWoKW4tfgsaG+m8H/lXDb9aDver9XW02uF4pxH0un6SWt5zyq5Xbc3Ul3rqetrL nK6pgOY3g4IW+i331rBE1guziAMDLQr487h3PlM/Hz03eutub/oqOirbpdaaspDMwFrZHBzORz0n wrNz0v8AaLbR1JQSMe6og6GuByASO/Co5q7Xd61XUMlvNY6ZzBhvhbnSO6+ptL0IpLbcHNgHZruc KY5ccplDPxzPG435Wb2X0HX6DudVFc6mkl/FHqj9KTJ4HkEcL3a6uevm6zZbtLsbFQOja41E8WYw 7yOpVUrt0tSV16ius1weauL8rm8AD2wF0kfxBa0a0D8dGcdiWBTe7b9kw1JPpabRLdURXB0er6mg nkwTC6mcP1yMAhOwRTx7gXt80crIHtj9NzwQ08HOPCpxV7samqb+y8Pry2sYOkFowMfZdDN8QmsX xNZJVwYaQciMZOFZdTRfHyspfE/TzRbgVEssb2xvYA1xGAcDwoXHgLu9wty71rilghvT4ZGwu6mF sYBB+64IfRb8mf5LtPB4vxYcEi7bbYX/AFvSTVNhfRf3DsFks3Q/P0GFOmyFNq+062Nr1IK5sMDM ZkLnR5HbDuxCrfoXWV00fdBXWmoMUo4c0/lePYhSr/8ABLaqA5ZRk/Vi5adXd/Euy4x6ptNTYoak 1oid/eUkZMnB928//bWy+H86xrbo+r1DLWmjY3pDapzmu6v+U+FA0W8WpItVOvzKlhqCCDGRlmD4 wuqrviQ1PVUckPp0kbntI62s5HHcLpnlM9fxy8XjuEv9db8RV5rHa4oTpmonfW08REopAXPZz5AX UfD7UaxuNwnrdRzVr6BrOlgqHEO6v+U8qtmkdyLxprUst6pZhLUzAtk9X5uoZUg3H4kdRVVBLTim o4jI0t62NIcPqE8mUzs/iePx3GXaxdXpO06k18b5UOZUigY2JrB/hkBJP7eyj3cu/wCptaVdTpvR dumijhBErpP7rPg4J4IUPaH3yv2l4qmNhhq2TyGR3rDJ6j35XVM+Ju8NcXC10BcfIBBSZ6L499fC FdX6Zu2nby+33ykkp6zHV0uIPUD5B8rc3bajVtnsH8brLW4W7pEhka8O6WnyQF89ydfVeuL/AB3W vhhhlYwRgRA4wDldjct+brcNESadqaKldFJAIDLyHYHlYvbrOpp6dsqXcyl0ua3Sbao2klxxFI3x 3w0qZfh41VqHUVZdYtR1NRMYAGtZM3pIPkYVeNrt3bvoQyRUvRUUT+TBKT0g+49lIZ+Jqra15hsd DHI4EdTcg/uppUv2nbSzf26uupquCJzY3n04g3Aa4DJcR5Uf7j6s1FuDU1Vj0PQTy22lwJ3RYaXD w3BK5LTfxI3S2U00NZQwVfXI5/U5xzg+M+Vt4PiY/DlzoNPUUbnfmLD0k/sF1597cfxzUiXtqoqi HaU21w/9K00c0UsDvzsk5wCP2Xr2pulyusFTPdbUbcKdjYA4uP8AeOb+Y89sFVhod77lRa6qr/Rw tiiqiDNS9RLXj/quh1f8SFbdLFPRWu3R0E02czMkORnvxhZ5XWl/HLnM6jjfiVsu5t6exwe0znDg cgrgaXiUH2Kxq6l9TO6SV5c5xySfJWEMnQ76KZ5crt0wx4zS99lkdF8PsEsZLXst5cCPBAyF8vh/ 1HX6ps91r7pN6s7HRwNdjHytB/6qEbXvvHT7bN0xU2r1Htp3QCZsmBg9jhePZzeWPQttrqKooBUx zvEjXB/SQVq2fjxnztw4X8mWXxYs5X3OexbW19fRuAngbM9jiM4PqFeDZbVly1dpStrLw+N8scxj aWNwMAAqEr7v7R3LRVbY2Wh7HTte1sgkyACc9sLVbQbz02idPVlrraB9SJZDIx7H4wSPK1ncbJZ7 2cct5f8ASbtuv7U3xlZFeJWwacjmcIiWdMrwHZwD/l/muf3m17cnWmotOiKGrmpoWllRVwxucI8D loOOCFp7d8RdiFnbQXCyySRgdPR6gwR+qzoviH0rbKGamtunpaeOTJLIngNJI7nhYuU53KfK44Xj MbfSqFbI+aofJK8vke4uLicklFK4iUL73qpjq7pUzwt6Y5JHPa3GMAnK+NK0ukGAc5HZZrvJ0vbs TWTVOzMMtRI57mMlDS45LQBx+y+22lfPedoKmou8rqpzxUNc6Y9WQM4HKNhKKeg2ipoa6lka/Ejj C5pDnNIyBj6hR7qTe6yWXT9VZdP2WShqGOdGYJGgMbk4cD5BVxvoz+dJE2ku9TFs+24VTzNLTtmL es54aT0j7cLibLvXabxp6ptd+gndcat72gYDox1H5Rz2AXy0/vvomg01DbDa6mGH0+mSFjQWkkfN +6rfqK72/wDtTV1en2yxW/1/Up2S/maM5wf1U9Y9eyf79+lv967vX6e0BbJrLUyUk7pYmF8RwcFp /wCi9en6qW/bLQ1d4P4yWWFz3mYdXUQeP6KNLdvTpHUekqW3a6t0s80WOpsY+VxAwHcELLUm92ma DSLLPo2kkYwZYIp2fK1p+uVvHKax3O4xMbyyv27vfq/3DS+iLZUWOofRzPnawmPjI6cqMbDu7ddQ UNBYr9bIaxks8bDVyNcDy4Yd7ZW7O8ehtV6Yo6PW1FNLPCcuYwfL1AY6gchePWO8mk6XS1NadI0O WMc0Bs8YAjDTkYOSc5XOdN6/bab9c3+zaXt1E67z1lLFI4tj/CZBJAzggKM9e7r6Numk5KSCR1dX ROZJTsq4fzPa4EZK8FZuxt/rXT9FFrKnqPxEOXGOPIAdjBIIIK1evd3NHxaZt9q0vb4qkQPZ0+vG B6QYQW4P6ItSpZtUwa90kw6duzbNdmdLTGcYY7yOnyD9FHu62tbrYYaOzaw09SV00UjJqevcfkm6 XAkjI4PuF6JdzNtdSwW+tvbJaS5QgOJp2lha726m4yMrw7n70aZq7db6e007LqYZmS9VVHks6SD3 Pv2QSdQX4a30vTVOjrxHa61vS0wPaCGny0t7/Yhcveb5NcdY2TS+r9PU76xlRG6OtcetszQ7lzRj gH28LWO19tlfpLfdKySot1wha0kUoMeHd8Hp74K8e4m9WnBUWl9jhZcqiklbKJ5mEOjweQD35Cl/ hP66DfDXV30ferPR2WVkEE0Rc9oYCODj9OF6946z8DprT+o42ht2hmiayoaMOAePmH2Psue1Pq/a 7XEltr79cKiKqgj4YwloZnkg8c8r5a83M0Re6mzWKaolmszHtklqYiQWFoIaMY5XS3H4+nGTLff2 kjXur4dI6Vp71PAH1NQxkRkbgEZGf2HPChT4kdU6U1VpC2VFtqqeovEb25c1uHhhHIJ+66vdfWeg dVaGmtkd8LZoGddN0MP52jAByOxVQ55A6TIwsYyTCfbc5crv0+MrMEngfqviQQp5+Hu56KpKK8wa yjonSS9BhdUxB+Bg5wccKHdUijbqC4Ntpb+D9d3pdPbpzxhb47x2vL9taadJZFJYaJCO6YQNJA7J gIAoTwgDCoSE8eUYQJPyjwjygEd0D6oxygE0f6o7KACaSeD7KwHhAQnhAihNGECxlNGMIwgSaPCe ECQn9EsIBCaEC7oWXSscIAhCMIKAHdGEAJlAkd0IQCSaEAglCETQwkU0kU/CQR4QqH4SQhAFBRlC A4whCPKAKAjujCBFA5TSQCPKE0AEuUwhAFJMpeEAO6OyPCPqgEIQgO3lJNCAKPr3QhEA5QSgIRQh HhAQJPwg8BHhABHhHhCASKZR90AhHlHhABBR5TIQYjumhCA8oPdCEAmkjygCU0Jf1QNJAQgEIKaB ICEAIGhCEC8ICaMIBCEIBCEIBCEIBJNCAQhCBBCaEB4QhCAQhCAQhCAQhCAQUIQHhCEIBJNCAQEk /sgEIQgEk0AIBCP0QgPCWQmhBOCxI4X0WJXx49z5Sfkd5Ch+/HN8q8nJDipgm4ZyMhQ5ej1XmsPb +8K9X+P7rl5XinOWBecr0TflGF5yvXHnoKSZSVQIQhAIQhBkB1EAKWto9rZtWTMqK5r2UGeAMguU U02PVbnsrs/D9GG6OpeBn01LRwupdn9DW+5UlIyvqoayQ4NP6oc1w889wstbbCWejtkFbYZa4v62 iSLPW0tJ5IPcYXA7o3Gpg3buE0HU6WOcdDc/yVq9v6uqr9PU7q6mMUhjDiDzzjkLflx4ZcXLxZ88 eSKqfYbS38GiqaySuhlDcuAkwHfuF7f+wTRH8PFY+puMcHT1F3qZA9/C2m9V8qaaqs9qFI8U807H fiBkBpB/L+qkSljp3aXbHVktpzGQ4+wWGpl2iKT4f9IVNC2qobhXvhPIcJAQf5LndYfDxDRw09TZ ayokiLh60cmCQ0+WqRnXCOh3AgtNmlj/AIfLSh7xGctc77Z4Kke4XOnoJ6OCqwG1GWjP0A/6ou1a 9X7D2i2aMmvFHcats0MfWWPAc130+i8O3+zOmtY6bbUU95qY6/p+YNwQHe2Cp83hZHDtvdxCQI/R JGFX74ZJ5P7T1UbXu9PoaSAeM5K7XGTxTP525Y538mWN9REe4Gjblou+S266RkYJMUwGGyt9x/qF yqtr8YETP7P2hxaOozO5xz2CqWRysZY6krphny3/AAsZKePC6fQmi7hrGufSWt9M2VoBPrydI5Uk f/A46xIGBbD9fxHH9FltCAyn2UzS/DvrOJ4a6K34JwHCo4/os/8A4HTW+f8A1egI9/xA/wCiG0Kk 85RnlTDN8Pmt4pGsdRUfzHAd+IGF9P8A4HjXTT/6hSH7VAVTaGT/AEWTeO6luXYPXMcoYbXAOrsf XbhZn4ftegf/ABJgP2naoqK7fTmqq4YGkAyPDAfbJwrD0vw1TVFqjrX6lgga5vUQ+nOB+vUo7rNt NTaPuNuqL/bHQQPnY1srCHNzkcEjsrbaxkMW01W5pwRTnB/Rb8ePPOY/bl5s/wAfjuc+FKtx9GSa MvIon3Ckr2Ob1NmpnZH2I8FciDjuvVcZ3zTOMji52fJyvICMqZTVsbxtslqUNptqazcOCpkpblBR +i7pw+Mu6jj6Hheluzd4brt2mKmspo5gwSidgLmlp7ce6+3w8asdpzVkcT3y/haghpaw5+bPfCuo KO2zSNu5p4/WEefU6R1Y+6zO1t1FF90tqLxt+ymluFRTVVNUOLWSQ5ByPcFR10SYx0FXFkssG7er at9TWyy2Ckk6GwflPXj5ufZet2w+hZKw034C8sd29QPPR+66Z4cLpx8XluePKxSt2c46SsQxw/wn CtzRbC6Uo9SS2y6urJWz5fSvbLg9PkEY7he5+w+g4bnHaqiW4itlBfH0y5HTnzws6rpzim4yDghZ dyOVM24mxl/sd+lp7FRz3Wgd80Tom5e0ezh/quSO1OtGd9M3P/8AAkqVqWX04hjHOz3+6lHR2yeq tUWj+IUcUEMZGWtqHljnD3HC7vZHZSprbn+P1VSvgjgdltLK3DifdwPhWitMsIE9DS0z4oKcBrS5 paHe+B+iRnLLU2/OC/Wqpsl2qbfXNDKmneY3gHIyPYrX5zyu53mppqfcG7sqInxuMxcA9pBLSTg/ ZcJz91vyYzHKyJ4s7nhMr7euhpJ66pjp6WJ0s0juljGjJJUh3vZnV1l02691dFGaJjA9/RKC9oPk tWexeqLVpbUhqbvbmVnWAInk4dE73Ctpu1Vtqto7lVRtLGS0wcGnwCp48eecxqeXPhjcoo3pfSt0 1PdWUFpp3TTu/RrfufC6zVeyustM2Soutyt7PwcAzI6KYPLR74HhWV+Gmx0dPoJlyp6eNtfO5/VJ jk88ZXFbl6K3U1Ga93VEaFzSPw8NT0h7R46fJKvGd9+mb5LLJr2qgeDjKQJHuvRXUs1HUyw1Mbop Y3Fr2PGC0juCF529wudd3sttDUXCripqWJ0s0h6WtaMkldjq3bHVWlrVHcbzbXQ0b8ASteHgZ7Zx 2XX/AA53/Tlh1A917oHT1cpa2mmDuGe4x9VPfxOPa/a+UtHS172ED2HddfDhzy4uPm8v48eSjJJB PPOViST5WUvDyvmuddghCyaMnCgyZnHdZtznhTfadgq296Ei1BYbzS187ovUNG2MtOfLerPf9F6N GfD/AHa7WOW6XOsgtDWctiqYz8wHknPy8p7S3XtG2mdv9T6kpDU2W0VdXA09JfG0Yyvvf9utVWCg dWXay11LSsIDpZI/lGfcq51qglotpfQ0gIH3OGmDG/hiOZBwf/pKz0X/ABeq0FXR7hxAyvc9r2VQ aAWEcA+E+dJb1tRmwaXvOoKt1PZaCorZmN6nMibkgJaq0te9MyRMvltqqF0oyz1mYDvsVePTNgot FaGkrdKWg1VbOwSCNpBe8u8B3sFWjet+4F4oo6jV9sq4LbTSExPdEOmMu4wXD/VXRKhE/mX3pXlk oI7jlfJ7CxxBXqtUH4msjj7dTg39yo0n7R+8O4ddRx0VmozX/hI2tPpU3qOAAwM4UU7jy3qo1PV1 mo6KWjuNURK+OSExZzxkBXIs1np9uNu4n6Ws81dWyxtc4RDMj3OHcnyAVWfeOq1pqKoo6zVtoqaU R5ihc6lMecnOM+VrWptiZy3X0ihnW49LcnwvddbDdbXBFPcbdW0sUv8Au3zwuY1/2J7qyWxmz0FB TDU2sogxkY9SGne3sMfmcP6Lq/ivbHJtvSdDQYxUNLOPHScJhjzukzz4TalvW7Jw4hIyu/zFKUdL z918xysuj7NkJHdZBzj/AIl5wV9oWl32Qe630tXWy+lSQTTyYz0xMLjj7AJVlNUUj+ioilif36ZG lp/Yqefhr0pq2ju8OoLbRxNt7j6Uv4h3SXsPctHn7rqPi6pI6p9g9CBrqlxe0FrPmd2wP3W/Hhzt jGfkmGv6qwx5x+bCzibJJIGM63uccAAZJUrUeweuaumhqIrZT+nK0PAfO1pwfceCvI3SmotsdV2y tvFvEUjXiSIkh8T8HluRxn6LDaPJ6app+J45Y89g9paf5ryl7j/ix91efd7TVZrnbKnitNDBJXzC KZjeG9ORk4J7d1UJug75Nqs6cbQk3brLPRJA5AznPt9VqycZlKzMt2zTlvVeB+cp+q//ADldnV7W apo9SU1hmtRFyqGepFGHtw5vPOe3heDUehr5py7xWy7UD4a2ZrXxxjDi4E4GMLLTm3SOLcF5XxHJ yVI1fs7rOgtjq+osc34doBJY5ryAfOAfqtZqDbnUun2UZutonp21cgihLukh7j2HBVg48E44dhfI jnvypNbsrrsk/wDwu1PH/E3B/mvDLtLrOK4Q0cmnqts8wc6NpA+YN785wg4HjCWAV3lPtTrConqI ILBWPlp39ErQ0Za7APv7HuuVvVorbLcJ6G500tLVwnD4pBghQasBNAQgOcr6NYeCViAcZViPhV01 Z77V3oXq201c1sUZYJmB3TyeyW6axxuW/wCK+mJ3cBYlpA5CuBPsvbbXujb66Ghiq9PVLniSmkbl sTy04GPb2UdfEXoikotdUNFpa1em6ekDvw1LGT1OBPIaPoE2mkCABGMnC6p+gdUNY55sF1axoJLj SPAA++EaS0hc7/cYoaWhq5YfVbHNLFCXCME45PYfqrv5WY7unKlpHcLAjlWX3z2noLBpay/2XtM8 1XH1NqJYmOe57QM9T8dvKrZKwtcrZqSsvnjCbRk8J/1K63bzSFRqm/UVGGSx0s0wjfUCMlrffntl Zt4zdWTd05Po90Y5U9/EJtvbtKOsv8BpHsb+F6ah7QSHuafzH2JUIsoJ5er0o3v6cElrScZ7Zwns ePH0TA5wF7qi2VlK1rqmnlia/wDKXxlod9srO0Ujai5U8czSY3PHXjw3PP8AJLdTbWGPLKSNaWuA 5HdID3ViN7tDaOs+jrXcNMNjbUyyhsnROXgtLc9vHKgUUMrml7QSz36Tj91NpZq6eIAZR0nPZesU TwSSAMcHg8Lvdntv/wC2+qWUNRP6NLG31ZcDl7R4Htn3S5Sd0mO0cObjuMIa3+SkbeTSFJpfXNxt 9tDmUTHAwteckAtBxnzzlcEIHk+APcha9JNV5yPYJEewXqNNI3vgj6BdJt/b7PV6qoIdSmZtrkf0 ymJ2HDIwD27ZwiOS6HBuSCFh4VlN7tpNN6X0hS3TT5qhI+UNPqy9Yc0tJ/Tsq4SR9LiPIQfHCzDS eQE2tyeeylvZbTGidRRVcOrK6ppq4ytbTtjf0hwPHt3ygiTpdjJBwsSPYKet9dp7VoaioKmz1VVK 2dzmvZOQcYGeCAFBL+CeMJZZrfyR8ucox9MLMlLn2QY4+iMLPHCRGEGBCF9P9UsHPZBgUlk4c4KX ZAkIKEB4QjygoEhNCoEkeEwgSEIQB5QjyjPKBBPwjwhAkfsn4RhAsI7p+UigaXKfhCAQUYQgSEIQ CAhCAR4QjCIEBGUIAoRn2R3RQhLtymgEIRjhAI8d0Y/RARAhCSKZ7oCEYQCeTlLymfZAgjCaQ/RA +ySEBAeUk0IBCCjygYQkEIBCEIBNCSA8poQgEkyRhCASTQgEISQCaEkDQhCARlCMIEmjshAIAQhA JFPHCCgSaQTQCEBGEAhCEAhCEAEeUIQCEI8oBCEIBHKEkBlNI98oPZIGhCFRORWJWR5KDyF8Z7nx l/I76BQ3dfmulYf/AJoVMdSP7l3fKhm4km51P/zx39V6v8f5cvK8s3DV5yvRUdl5yvXHnoSTKSqB CEIBCEIPpEel7SrM7A7lUVJFHaLi5sJA6WOJ4IVY16YJHsALSQR2I7hBbbWGh7FNruDUkNzp3QVD uqWB0o6g/wAFv0+ikPU2raHS9jpXU1RTPDnNYR6gyAfIx7Khz6uocOp8j3kduok4WT62okA9SRzg OwJJwrbu7rEx1NRfPUEdu1fpymdLWxsexzZo3NkHLh7hbaqpWVml5Leysp2vkjLQ/wBQeV+frLjW MaAyolAHYB54XpF9ujQMVtT9vUcoul5LHpKy2GiaY20prBj++6gXA/Q/VaPeavhi/s7KKqJoZV5c Q8cAhU1kvtyP5quc/eRy809yq53NM9RI/HbqcThaxvFLhyXi3NqIajaitEM0by6Hw8ZwuJ+H7RdL ZqA3mWsifJKwE9LxgNHICqtNd6+SH0pKud0YGOkyOI/ZOnvNwp4DFT1lRFF/lbIQP2Vue8JgzPHr O5/aa/ic19b9QVUFnt/97+DeXPlB46iMYVfieVnPI6R5c8kuJySe6+fhZtbxxmPp7LZcam3VAno5 5IJR2ewkFdHHuHqaMYbea3H/AM8K5DHCeMjtgqNOuduDqVxBdea045/3hX3ZuVqpva913/4QrjAP fujvnuhp2Mu5OqXvDnXqt+Xt/eFfZu6mrG//AKarf/whXD+EsD6/shp3L90dVue1zr1Wkjt/eFfc btawGP8A03V/q8qPsHHlI9u6JpIkGur7qK626nvFznqYBOw9EjvlHzBXL1HbKm8baT0VuYJZ5Yel jc4yvzzjlMbw5pII5BC7Wi3P1TRUjYKa81TImDAHWVrDLhlMoz5MJ5MbjWn1npm6aWu76G9UklNU Y6w13OWnyCufAzhbXUWobjqCqFTdaqWpnAwHyOJIHstOHYOVMru7ak1NLHfCtpCO43GW8yvjd6BM Yjc3PPfKslFrO2u1YdNtY8VDY+pw6cNx9FQTS2srzph732WvmpXP/N0Hgr1P13fX3xt3dcZjXtGB L1c49kmtXbOWNt69L06ZskWntUXIM9CKKud6sTGDp5wAePdcbf6Tcev1zV0tnrprdaODHUPYHsH0 x3Kq5Vbr6qqquCpnu07pYTmN3V2W0/7cdahuBepf3XS+Te9uU8OtavpY7S9v1NRbkwRamvVNdmMh d6b4uCw5GQW+P3XV3Nud2bc49hRuH69SpRHuLqFl/N4bcpRXkYMgPcfZbCp3c1bPdIbhLdJTVQgt Y/GMD2WcctW1q+O3SwXxC68u+ir7Svs1QYjNF83kcE+FETfiE1mf/j1n/wCDCjzWmt71q+WKS+Vh qXRjDCQBhcr1YVzymVmvhfFhcJZU10+/esfxjpRWsD3AA/3YxwrS7Q3q+X3Sja3UDHtqZDlgczpy 3wV+eUby12cqVrHvnrC0W+Kip7iHRRN6W9bQSAFjbVx6Y79V90uW4NVDd2ObLC7oh6mdJ6Cfl+4X 3vWxmprVpN2oJJqGWkbEJnMY89YafoQuM1rre6awusdfep2zVEbehrg0DA/RdJPvNqibTBsc1YyW jdH6R62Au6cYxlbuUyy3fTGGGWGHGOb0dYLnebg0WuiqaoxOaX+kwu6RnzhXZ3Eo6qo2bqKWmgkl qTStb6TWkuzx47ql+gdwbxomtmqbLUCP1hh7HDLTjscKQW/EhrAD5pqY/wD0MKY5ccuUazw548as PsRDLTbZNppGOjqo3yB0bhhzTnjI7habYh18N61AL22tbE1/9z+IDgCMntlV6o989T0t+qbrHUQ+ tUNDZGdADTjsce/1W5m+JDVkkL2A0o62kZ9Psky/Wz7Zvj/aZfUar4haMVW7NbDTMb6kzmAY4BJ4 Wm1js7qnSdi/i90gpjQjpJdFN1EZ7cYXHVt/rKy7G41Ezn1Jf19Z5IOcru9Wb0ag1Ppf+CXEUzqY taC5rMO4XTPPDPPd9JhjnhhJO60G3dqra3UNDJSU1RMyKoYXujjLg35h3IHCtv8AEbSVFVth6dND JK/MfysaSe30VW9sd1LxoFtTHazC6GoIc9krcjI8rvpfib1I5uPwlAfoWH/qseLP8eXJfN4vyY8V fqqN0crmvBDgcEEYIK+C3GrL3LqLUFbdaiOKKWqkMjmRN6Wgn2C06xe3YL6Q/nH3XzWcbul4Kgtl 8JFJfGuqaiRszLK5hA6jhpf9Au8+Iw3b+xEUli9X8GHk1Xojjox5HtlQFa/iAvFBo6Kxw0lMx0cQ hbPHlrsDsePKz0l8QF6s1pmoK6GG5wyZx6+TjPcfZaxvG7c/JhzmljLjVy2DY9tfZx6NVHQRvY6J uCXEDnhLaK61mq9tqiov7jVSvdI0+q3wBwoB0n8QtystFNR1FDBV0heXRRyEkRt/yj6L2374krhW WeoorfbKahklGBLESC1ZbTvre71un9nxX2uQxVMNPGGOHJHICx22r5dZ7UTTaj6K4ziaOQSMBa4D 6KA9I/EPcLVZhb7rQw3KMfldKfHthe2/fERWXKxzW2zWyntj5flE0bsdGe5x2Wt9aZ42Zb2r7dYm xV0zGtwxkjgB9AThenTzc3WmwMEyN/qpzpfh/ZdaSCsGs7VmoYJSCzkFwyf8S9MPw5yU0jX0+sLS XN5Hy4P9So1tM+6mpa/Su3dFX2uVsUzRE0kgEYI+q+VBcXas2bdc73FFUVHpvlHU0cOb2IUXP3of pWObS+q7dR3qW3yGL8R1BzZAOxwQR2Wm1n8QQuGmn2vTtqitnWC0lmOkNPcBuMLpjljOO56efLDP 9tX27ah30s16ho7XXWL1TlsY6pcjq7ZAwuv+Ie4W6j23ey40AqY6gCOL5sek/p4cD9FUbbjVtPpf VdNdK2hir4YuoGKQZHI7j6hS9uDv1ZNWaVq7VUWBznSMIje6TiN2OHDjws+OzHPfw35sLlhqe1bK rHqnnK+WcLKU9TjzyvllZvt2npkuv2yt8Fx1nZqSqjbJBLVRtex3ZwLuxXHg8rcacu09nudNXUr+ iop5GyMcR2IOQoL1bkXebT9XpeyWlrKalrKpkRDBgta1w4H6LTbwRtfuJoQFuc1Zz/4guLh+IDTV 0oaCe/WQy3alb1Mk4IbJ/mb7crW6y3wsl8s1HO2gkj1DRSNlp6gYLWuDgT+hHhbxy423+ac8sLdf ypq3M1lY9LTUbb1FWudKHGN1M4txjvnBCjLdrcazaj0Y23RW65wzufG+nlqoCGnBzkOPuPZeWu3o 0HqakoX6rsT6qsgb34LWuPfHPZc9uzvNatR2Kmstjo/TomlhcZWjLOk8Bp8LOV1P19rhjd/umvW9 /rNM7a2Wut5AlaacHPbBHOVtLva6GsvGmNQPp2tuRkY31GcZa5pyD7qLv+2nQt20rR2vUNvqZ444 2BzMAjqaByDkLVa139pPxNsZpmDqpKVzXkTt5HTxgHPssydSX6dMf9rtImpsHf8A000//KLz/Ny+ eoomS/ENp3raHdNveeR/zLn5t7dD1VRT3mWjnF7ig6GP6AejPJb37Z8rGbX9u1lquxV2jKKSbU0A PXHMQ1jouk9Tck/U4OFbUw64/wA27q5XmuZvZbbK2d4tstvdK+D/AAlwLucfoFEnxMXasm13bLMa z8PRsEUrSeGxPLsdf6Ka6ae1VmvqOess9XT6gbTFjZX4LGswSRkHHkquPxXzFm4reBn8GwDP3K7+ LV5X+M59aiYKaxarFMz0t0qFzAB0l0DTkffrXO6mqNW6c1Hpaet1ZT3enmrBD/s7Q0s6iAc8nIIK qs26VLOGyvAH/EVu9IahFHqK3VVe974IKhkj+STgOBOFyl03VyN09RXDT+o9Mw2yQQx3CqEdRhoy 8ZA5/QqKvjBoqZtVZ6psEbZ5A9rpAMFwHbK+26m6emb3e9MVluqJJoqGrEswLMFrcgn+i5n4ktd2 HWEVqNhqnTugL+sFmMA9l6MMsZlN/Tz+XHLWOvtX9ww4491isn/mJ90l5Xdmw89laL4PBmpvhHiO MfzKq2DyM9lYH4Y9bWPSs12ZfKoUwqGM9NxaSCQTkKWb06YZalTxorcGO6atumnLiS2tp6mRtO8d pGjnH0IC3kdLBLuNXVEsLHTwUEPpyEcty5+cFVo0nrKzUO9892q6sNtjqqZzZwDg9TcA49lLj93t L0u4UjvxrZbdV0jIzUtziN7S44I/Vbzn73XpizWM17YaE3IvV73OmsNWIXW8STs4Z83yAkc/stHq bU9ToPdeW2aejhho7lJA+aItyOtzsEj2zlbTTtbtjYdUS6gotQPfWvMjuh78tBf3wMKGNy9d0V33 NjvdBHmGB8fyl2Q/odnI+665XC89fXTn4plLOSw+++uLhom2W+W1iIuqXPY4SNBHAVIrvMamtmnL WtMry8howAScq6MmutvNXUduuF7q6QyQxuP4KqaHYcRyCCO4xwVVDdKustx1fXVOnKRtJQSEYib+ UEcEj6Fc7ZqSN6cgOCD7Kfvhy3BuVurqLS7GQvoaip6sublzS7APKgALrNt9QM03qy3XOaMyxU8r XuaDzjK4eaZXC8fbfj48v2Wz3115W6Wlp6CmpqWphraZ/qMnbkdyFxvw02G6UdFdr+2empbdUN9N pezr6ug5cSM8AZXd3u87casjgut7q6Kra2m+SCY4Lf8AF48+Fz+2ut9H1FlvenPxDbZQPlmMHrOA HpyeB9Qus105as26zce12zUu2Fznq30txEMMk8FRAzoDXNHBHJ5VT9urzNpjWtBcaRkb5I5Ogh4y C13ykfsVaG03LSNBpuq0idRU8tPJTuP4oua0YeSCOOMj/VVz0rZLPNuiy13G7xRW6Gd5FWCA2Tp5 bz4zwr5NXxXGe2vBvH/I5Zf6py+J6KF+j7PU+kxrzUckNAOCztlfTYWrg1boCe03ejglgtzmxRu6 eSB8zf1BC+++kti1FoCQUV9ozUW8evHGJAfVwMdP3wua+GO+WqgsV6gra+np53ShwbK8NJGDyMrz Z45csNO0s4Z//ud9putotyrFfqC922lMVPMYA5jcE4GQ7PggrS7K6wNdcWaa/AwMjt8Dmxztbhxa 12AF5ti7/Z6Wj1JHUXKmilfVufiSQNy3HB5UbbSaztendyJ5bnIWU9QXwCUHLWkuJBP0UymXGz+p jxu7/HW7/axjmmummZ7XTSBrmObVFvzsIwcj+Y/VSRoDTNrse3ltNBTUDH1EUc8r6xvU1z3AZyVo ddWfb+oF0vl8q4K2eV3Wx1POOtnAAGAeeeV9KOvseutraS0Ud8pqCaJscTnTEdTSz/hyM5XocpG4 1tprTmo9J1dJcnWoVMbXSxPoy1ha4A4xzkrnNJaQ07tlox9zuzY62trQ0epLF1AkgFrQ3wMrUV2i dE6V0lUTXe9fxK45cWVFPIA4OI+UCMOIxkeV0twns242gLVDQ3qkpHQPY57Z3AOBaMFuM/zSTftq 8ZJfl5/iQkbLttQvDQwPnYQ0eAWHj+apjUf755+qunu02g1RtrPDbrnStmtzi4xvkGXljcFo+uO3 uqV1WBO7HZMf9e2fmvmCuk0G8s1Nau//AK3Cf/rgXMdXKmTYjb1uqJm3d14pKQUFUwup5B87gMHO SeAUvpUy/E5Rur6WwUzHsY6aoMYc84DS4tGT9OVHR+HDUUjuqK72V8ffLXPz/Rdr8VVYwWmzyQSs e31HjLHA4OB7KtP9qboz8tZOB/zla8m94/Wv/wAs+PXG/e0nXj4fL/bYoppLlapYnysiJZI7LC44 BOR2yvafhq1MT/d3O0OPsZHg/wBFD9Rqi6VLAyatnezIOHPPccj+a+zdX3oY/wDSNQf/AKIVK10k m5/D3qagko2yVdrIqJvSLhK4CMkEgu47EjH6r3D4bNVgf+uWnPt6rv8Aooon1deJgxslwqHtaeoZ kJwV9hri+tYG/wAUqgP/AJ4VDSQq/wCHzVFFW0EE09tzVyGNjxKelpDSeePOF7D8Nur/ADNa/uJj /wBFF02s71N6fqXGqd0O6mkyn5T7hfePXuoWDAu1Zj/56UG53F2kv2hrfBW3b8M6CZ5ja6GTq+bG eRhRs4AEgLoLxqm7XeAQ3CunniB6g17yQD7rn3HJKqMSl5TQgSE8JfRA1j5WXlLyqApJlJAJoRhA kisksIAfVCAEIBCEeEAUBCSATR4QEAl2TQgSMIQgEYyjwgoBH3QhELCaEfoij6o7FHP3QgO6PHdH ZHlAIRnlARAhCEAkUFNFJZY4SQgMeUwlnjCEB2TS7IQB4T8JYQgEIQgEFBQUDSQhAJpJoBB5QkgE 0IQCEIQCEIQCEIQCEIQCEIQCEJIGkmhAiU0I8oBJNCAQhCAQhCAQhB4QCAkE0AjCB2QgEIQgEI7I QCWPqn2SUAUDyhNAhyjCEuVdidQhZFIhfHe58ZgBE7P3UK1nNfUn/jd/Uqaqv/1Z/uFClaOm4VQ8 eo4fzXq/x/lx8rz1HZeZeifloXnXrjhQhCFUCEIQCEIQZNGXAe6nXZnaUagjZcLwwmkdjpj9x7qD qb/ejIyr07KADRdIW/8AyJv9EEe37Qe2tPqektEUT2VxyXsbMSw8jgjwV7db7GWB1PRVWnqOoafU aJ2iUub0+Tg9lE2rZ6r/ALYLkaFpdUCud6f7q3mjX1k9ji/HxtbJ0jGOfulYlRpLsvoajtcE1dRP jndgczkB5P0yvbU7N7e09t/HT26pZCBkkTuK+W7VxurdV2KgfShtpdKHNmA56x3afbhSa51I3TjR cP8A1YN+fnHlDaMBslt/W0baujp53Rkjls5I+xWi1h8PdmikpKqyfiGQtd/tEDnlwc0+Qe4IXW2y 6wzbkT0lpqYnWswRENgILC7nPbjKkS53ymt9zo6OsLQyp6gzPkhO05K/bjbLaXs2hp7xQirhqoWt d/vOprueQQV8tBbT6G1lpoSUs9XFXFmOps3LXY8g8d1K2/ZbHthdfTx0FrenHbuoc+Fx73XesYSe kFhA+5W/JJj4pl9s+PK5eS4oY3E0Tc9FXySgucZLMkwztbhsrfcfX3C5Qd1aH4wDn+EDx1PI/YKs OBxjlM8eOl8Pk/JLXTaD0hX6vu8dHQxu6cj1JMcNH/VWRi2D0ZQ0EH8arauKoeAMiUDJP0XNfCXG 01leSOetv9F7PiwramkvdqME0kfyk5aSOQe6eLHnbPpPNncNa+Xuqfh907R3WKR9fWvt02A35hlp ++OVtrh8POi6ZsXrXG4xeqcMPUDk/suD2j17fr7qChtNxrBPRtBOMcgjtyrI6zqLPS22iqb5Vmki hcHMkHbOOxWJ3dR0t4zdQqPhstMd3DJLlWvoZW/3ZBaHA/suMvuy9vt249Jp+O4VElJPF6vWQA9v 09lZWwautuprnHHaJmVNPT4zMOOSO2Fwmrx1b82po8UZ/wBV08eMy5b+I5Z52XGT5Q9vbs1RaFsd NcrbcKicSP6HRTNHt4IUPQ6cu9TRmrprXXSUw5MrIXFv74VufiycW6KoP/nw/ouC223vtmnNIstd xtssksbOgOjIIcB7q5YSY437XDO25fxWt7SxxDgQQcEFYrcarrornf66upojFFPM6RrD/hBPZaZc 7Jvp1nrsk0kKKFkDwsUwgyym05CwX0i/MPug7DbzQ1y1nd2UdvYRHkepMW5awf8AX6KZbv8ADHco LbLNQXyCqqmM6hTugLC7jtnJUg/ChSwt0L6wiZ6hkdl2Bk8ruLHZ7rS60q7rUXV9TQVbi1lM5hAh weMHykZt10/P68W2ptdfPSV0L4amFxbJG8YLStcrDfF5R08es6WWGJkckkI63NGC7k91XoreeHHW /lPHnM5skZSQsNnlGSkhA8oyUkIHkoykhAIQhAJpIQCEIQCEIQNGSkhBlk+6OopIKDIPIHCbZXN7 FfNCDZRXerY0NE8oA4ADl9P45W//AC1Pj/nK1KEH2nnfLIXuc4uJySTyVh1uKxKEGXUR5QXn3Kxy kgZOShJCBpglYpoPq17gc5KzDne5K+AOFkHIPuJCB3wkJCe5Xz6kZwg+3qEDuU/VcR+ZfDKMhFek Sn3W205qCtsN2p6+3zPhqIXdTXtOFocp5Q2sfH8TF7bE0Pt1E+QNwX4IJ/moX1vquu1Xep7jcpC+ WTgDPDG9wB9FzOf3+6WVZdI+nV+qA45yDhfMFMFRdvuJHdySkZSRySvllIlEZE5PdJYhZZQNfRkr mYxnP3XyzyjOUHpE7h5OUxO7/MV5lk04RdvR67wO5WLpCT3XyzlPPKI+4qZMYL3YXye/qzlYEpeU GWVmx5HIXxB/ZZZwqPWKl+OHHCYqXtPDiP1XlDsd1l1AqD0/i5sf7w/usRUO6gcnK85cEFw7IPYa 6V7SHPdge5WLKuVv5XFuV5QU+rlB7GVszCel5Ge/K+f4l4cfmJC83VyjKulj3m41BZ0+o4t+6cNw mjz6cj2n/hJC8BKA4obbOW5zyDDpHEfUrGG5TxElkr2++CQtf1JF3CI2ZulQQ4NleA/v83da+RxL j5WIdwkTlNB5/kvbRV89GS6mmkjJ79LsZXgTDig2NXd6qqb0VE8j2g8BzsrwdRyee6x79xlCaDym CseyO6DI8+UErFGUGQwOcpOWOUFAz3SQhAscIT8I7hAkIR5VAEIR5TYEj2TQgQRlCAoDwgoQqBJP CSB+EgjHCfdBj5KaPCB2QBRhBTxwgXlCEIBId00vKAQgFCAQhCA8oQhAIQhEJMIz7oCGwmkQhAeE eUFCKEISQCaAhAeU0kIBCEwgXlPCOyPCBd0HsmhAY4STzwkgaQQhA0IQgCl4TSQPwjlJNAIQhAJe U0IBJNCASTQgEIQgEIQgEIQEB5QgoQCEIwgPCSaEB4RnhHjsgYzlRCQhNAY5TI49ks8IygOUI5Rl AFI9kJnOECygJ/TKSKE/CQTPKBIxnCMoCAKfUPokjP0CCeMcpEd1kQUuxXydPc89WP7l4z4UJVBD quc+TI4/zU2VhxE/jsFCMv8A6zMf+M/1Xq/x/VcfK+E5xx7r4L0VHJXnXqjhQhCFUCEIQCEIQfSF 3S8Ky2xu6lHRQR2m7vbC0ANY9x4IVZh3XqjcQBg/ZBbG82jRkev479BeqQ/iCXS05eMtfx8wOe30 XZau3Hs1jpbfFbrpRSB8obK0PBLWnyqQl78ZJ/XKRkf5OVKzpe+83HTeorXRy1V0pRPC4SxkSgYP 1W0u09ku2nH2x16o2tkABeJAeP3VAWTytaOl2P17L6trKnHErv8AxFE0vjbP7L2WhZBRVtAJAWkv ErSTg8rk92NQWiS+6ZLLjSu9Kd7ndMgJaDjuqcvq6l2Myu/8RXyfNKT+Y5HuSrKcJV095r1a6ra6 qgiuFKXyhjQ0SDPf2Wt2Ys2n9L2D+JPudNJI9vqPd6gHbnCp9JUTuaA97nAe7iUjVzhoYJHdP+UO OFvLLeMw+mcfHrK5faVviB3Bp9YXtlPQtDqSlceiXGC4nghRBnsQh5LnZKXbgKXK5XtrDCYTWKW9 htfQaQvhZWgClqCOqT/KR7qx+t9Iaf3Hltl0fcIwIcEsMgDXtVGInEPwFtIbtXwsDIqmZjB4DyEx txu4ZYzLW/hdw2DS9BV2+mtTbfBXQHq9RgaCW4wQXBeX4gLU++6BfFQ1NL6lN/eua6UDqDRyAfdU rF3rWS+o2pla/wDzBxBWc97uNRE6OarqHRnuHSEgpheGXKGeEzx41P3wxaottBX1VDWTCKomf1M6 uAR2wpkvGlaiu3GpdR09VRmljpxEWmXDvvhUQhnlhka+N5a9vILSQQtm3VF4YzDbhVD/AOiOUls3 r5OE6/izHxX6gt0tkorZHUMfWNf1ljeQBjHdajbOv2tfomKC/U9tFeIumUzw/OXY5Id3Vaq2tqKy b1KiZ8snkvcSSvK6VwC1crZJ9GOExts+Ww1Syijv9c21HNCJnehzn5M8LUFZPOTkrBYbCEIQCEIQ NZxHBXzTHBQWz+FbXNsp7adP1bxDUl5cxzjw7J7KYbLpyusup7lday8STWqQmWKBxPRFk5PnC/Pi 3101DOyamkdHKw5a5pwQurqtytU1NE6llvFW6Fw6S0yHkIzcd3bsvia1ZbtTavb/AAtxe2mb6T39 2uI9lC/cL6SSOkdl5ySclLsPP7LWWVy9mGEwmo+WPZGFmR3Rg47LLTBJZ8pEfdBihNJAIQmgSEIQ CEIQCEIQCEIQCEIQCEwkgEJ4RghAkITQJCYTAQYoWeEAZPCDFCeDlZdKDBPCZbhDQgWEeVljCMIF 2WQQEY7oEE1kAgBAkZymW4TwgxCeUYwUIBPshGEACjujCMcoBH9EeUH3QMJpZymAgYQjHCeAgAgp /pwgIAFHcpI85VBhATwcI+yA7JoAPsmoEhPCeDhAkk0groPyhCEDSQE/ugEeUEcIwUAE0DKMIDyk O6y6PdHSUC7IKeOUkAmjGSnjlBijyssFJAkJjwnj3QYoWfTxlLp8oMUJpIBCaSBIKaO58oFhHOEy hAvHKE8cox9EQkFPHKDwgxCCEyEYV2pBGE8JIEgpoQLwhNAQLyhHdCA8IQhAkd0+6MIF5R5TR5QI IT8oKASTSRB3CChCA7lCCkUDQU0v2QJNB7IRQn3+iSZyiEmTlIplFIpjt7JeU8oApeE+5QgEIKEC T8IQgRTCRQgflJNCAQgoQCEkIGhCEAhHhCAQhCAQhCAQkE/KAQhGUAhARlNoCgfRJPxhNmwjKOyB 3TYEePqgpJsCfdJNQJCYCWPKAT85S+6aGiTKRQhoeEDk8p+UkUIR4RlAJ/0SyhAJJlHZAZSymjj2 QT4QsSvphYnsvlPc8VcP7iTx8qg95Pry/wDMf6qcrgMUknP+E/0UGuGZpD56j/Ver/H9Vx8r5zjC 86+8/wCb9AvgvTHC+whMpKoEIQgEIQg+kbetwCsjsrtFSVdIy63yJk0bgCI3DLQPsq6UGPxDM9sh Xy2zaGaKiA7ek3/yp86ZzvGWo4rbTttNrWG1UNppGzRHEjmj5XO9sdlutY7MafqZ7bVWSzxMb6n9 +IyQC09shQGx9c/cyqFt/wDWRWv6Se35sK6OlRWfwaIV3R6vSMEefdXOccrIx48rljLUfXXbnQVq paUV1lo/xUrg1g6SesjGV7rhtvoCgtv46fTVMYvlyGjnk4Wj3HnvX/aJYYauOMWgvcYHNwT19PzZ /kpSuNZRUNiZPcgPw7AwuJ8cjB/RZOThI9qtvK+nZUUdlp3NL2ghr3cZPYjK0WrdhtPCvpa200Zi iid/f04cS2Rvvz2IW601c/4juPcJqKV8lreIzE4NLWuPnxyV3tfqOnodRQ22qc0eswke/wB1ZLfS c5NS/KDt4tr9JWPQzrpQW4wVUZYcskIByRkEL6aG22281npUfhqN8Va5haZWynqY7HfHbuux+JVz RtrV9JBa58fTj7rgPhXLjLXh2en1Wrp5JMfHMp8seLO5Z5Y34QRuTom46Hv8tuuA64+XQTtHyyN9 /v8ARciT2Vj/AIv+kX22tb/8jJVcTwQmeEx1/wBOvizueNtS7sNpzTOorpJR6hp5Z5jy0NeWjH6K f7lsvt3QmAT26pb656WAVDu+FAPw3j/4emDx6RVy71T26oktjbgHCQEmJwdjBACxGsvSq29e0Nt0 fNRXW1yyizTSNZNTvdl7fq13sQpH0nszoC+adgrm0tZ8zA4u9cjOVrPioud0jpKOgNGP4UcOFRjJ 6wOykfZzDduaQ+9O3+i3nJjx18uGPktxzv0h6wbebd3PXFdaIf4jKyEY6HSkdLhwcHyu4r9idvaO emgniuDZKkkR4nJyR3/quB2pc6Tem7PPZzpD/wC6/wDfU/bgXmwWM2+t1DPND6LnOhcz3wM5Vzw1 ncYmHlt8eOd+VTd99qG6Dqoay2zOfaqg9LWvOXsd/quHpdvtUVds/H01krpaTHV6jI8jHupQ+IPd Ch1k6mt1paZKKB3qes4YJcRjGF7dH7+S2LSzbbPamTOZH6Ye1+ARjHIWNfbtjbpXieN8Uro5Glj2 nBa4YIP1XzK2F8rP4hdaqr6BH60hk6QcgZPZa9S/xueiQhCihCEIBMJL6QjqeB9UGTWEgFfUwvIB DeFaf4ctrLDdNONvN4pY66WbOI5mgtaM+FKzNsNKVT5YKjR9ugiOQJWOBP7DkIm1RNqdr7lruvaI 2vgt7T/eVBH9M91LOpPhlbBaKiWw3p9XXRN6hBLGAHfTIU96K07S6Wt9ZbKDmniPVGSOQDk4+uFr 9Eacmsl6qK112nrYrh1P9KQcREexz25W5jLNuWXksymMio+3m0N51VfZaKohloYKd5ZPK5vLT7AH upF1T8M81HZKipsF4dX1sIz+GfCGdY8gHPdWUtrmma7mNjWOY4AEDBz0rndA6eqrLdKmoqLtPXsu AMvpyNwIiPAOeRylxhPJfSte3Gwdy1NSS1N1qza4WkgZj63EjvkZ4XRj4baOvp6j+DavgqqiNpwz 0Bjq8AkHhWMtMz6h95pX0xgp2vcBOCOk5HPHuFy+0+nLdYJrs+2X2O7uleXuY0AGM+3dOMkSeS7i jOpdPV9gvFRbLnAYayB3S5vv9R7grWTUc0OPVjezPbqaQpa3furRvBNW1dHLE2CdjnwSYyQ0/tgr vN390NJ6o28/htBSPbcCGFhdCB0Ef8Xdaz8cxy4rh5LlhMkNbWaDl13qNtpirGUZLC8yOj6+30yF KGp/hxkstuqJn6stxljjMjYpYTF14GcZLl4/hQAO45wP/YH+q6H4vqqWK/W6Jj3NY6DJAOM/MU8W E8ls+jyeS4Wa+VZpISyRzeDg447LqdM7eal1NQyVdltFVWQMOC6MD+We67HZXaqs15cm1EzTFZoX 4ll/zEf4Qp+3H1/ZNstPfwPTTIjXsZ0BrP8ABxj5iPK5yW+m8s5j7VS0toG86g1P/A6elkirWP6Z myNIMIBwS4fRSjqH4aNQ220T1lHc6Kulhb1GmjY5r3D6ZJ5Xb/C5RvvF+u2qKyvilrpXOZJCT85z z1FdXvJrC5bf6hivNPNT1VFVRiCShdJhwIzh+PZXCcqmefGdfKpejdCXfVOoRaKCBzahrsSl4OIh nBLh9FI+qPhw1NZrPUV0FXQ3AwDqdDB1B5H0BUpfDRQtul6vWqhPTsdVSOaaVpJeznOfstrurrK7 bealkuHXT19ruDPS/BmTpfG8D832XSYY3KyXpjPy5Yydd1U/Rehrrqy/Mtdtgd62f7xzwcRDOMuU gar+HfVVgs9TcRJRV8cA6nx0rnGTHkgEeFLvwyWn8TVXbUwmpwKxzmfh2uy+PnOT9OV7ty9bXLbn UtVNN6VfaLm0tZCJcPikDcHI8BOGNt1fSZeXLHjLPaqmiND3bWN6bbbRCS/I65Hg9MY93Lu9XfD5 qvTloluTzSV8MPMjaQuc9rffpxzhTP8AC5ZC2C56gZNB6dc9zPRa7LmYPn91sNd65ue3+p6yKuZH X2e5Nd6LWSYfE/GDkLExl3r4by8nGyX5QRpbYDVeoLNFcovwVJFL+WOqkcx+PBx09ivPrDYXVemL Q+5Tx0tZTsPzije6RzR74x2VqNVW246r23pIbDUfg6pzY3A1BdFwO4PGQnb6ar0ptTUU99qDUVUc MvXLD1SjJBxzjOB7pMZda+S+Sze/hVzTXw/awvtohuEMdJTRy/liqZCx+PfGPK1+u9ldU6OtH8Ru NPBNSh2HvppOvo+p47KQdO6v15uRNDp+3zCOlYW+rUxxkGNg7Eu9+FLG4t8t+hdvzY6uoluFdPEY mtkd1PeXefryrjjvLjUy8lmO4pxonR1x1fe47VaREap4LgZXhjcD6rote7Rak0RQw1l7gpxTyv8A TD4Zg/B+qmTZrZmWGlZqK/1VTbXtcJKeOMAODc/4h9VIfxA00VVZbBTTgSQy18THA9nBTGS5a+G8 srJNKq6G2i1TrKilq7NRMNMw4D55PTDv+XI5Wm1xoW9aMubKK+0pglc3qY5rupjh9HK7uuYrraNP Wyz6JipaeeZ5YGyHpaGtb1HB8HhavXdk/tptEx17pYn3dsQMbhwY5c44KzJbNnObuM+FIbLY6283 GGht8D6iqmcGsjaO/wD731XSa32x1HouClmv1GyCOocWxuZKHgkc+OytbtroG17Y2uG4XGJtRe6k hmWjJbngtafYd19d/bbHd6jSNLUQmWkfcWtl446SQMEqNb70qtpHaTVerLca2zW31acO6et8jY8/ UZ7hc1qbTFy01dprbeKV9NWRYLo3eQexB8j6q9evZrxZLdbrVomigDmNLy0uDOmOPBwM+/Zc7vFp mDXO3NBXvomG+ObH+HePlIc8gFpPsrO7J8lupyUusVirb5coaC20756qVwa1g+vufAW61Vt/qDSt dDSXu3S080wzFgh4fzjghW8200LZNtKCjFw6Jr5XPbGX45y4gYGfAXLfEdeJ9P6r0tdooGSGlL3N bIMtccjj9lrx48tuefl43GfaC6bZPXFRTQzxWCofFK0Pa4Pb2IyM8rmdY6JvekqqOmvtBLSSyN62 dWCHD6EcKy9NqrcfXNHQ3XTdtbR27qMZdDOMPwcHIJW3+JaCOo0Bb6erdAbn6keOsjrHHzEecfZT x487pryZcJL7Us6CPBWccZkPbCsfQ/DrTXGCmfT6xoXzTsa8Reh83IzjHVkrU6G2qFv3dp9Panp3 SQtD5WuHDZmgZaR9OOy5zLc3PTpJu8Ud2XazV16tsdfbLJV1FJJktkZjnH3K5apts1LUSwVET45o nFkjHjDmkdwQr3aw1HcdNXmgt9itPXbKRkclU+LADGPJaMj24zlebWm2+mr5rax3Ksog2oqHOEoj PS2XpZ1AuHkrWzWlQbdtnq25W9lbQ2GvnpXt6myNZwQuRqKWWnmfHIxzXtPS5rhggjuCr6am1Zcd P6lpLbbLT1WmlMYqJWYDQ2T5WjA7YPK4Df8A2ogvF5tdXpukEdxuEpjnawfJgDJeQPZWyz2k77VF 6fpykWEqxTfhkvQmcyS+2gHPy4D8n7hcBqLRdz211jRsv9FDUwxStmjf0kw1LWnJHP8AQqCNPSOM 9/snHGXHCt9qfQml92tFtu+iYaWhu0DcmGNoYOrGSxwHn2KqtcrdVWi5zUlbC+Cphf0vjeMFpCDZ QaC1NPTxyxWG6vjkaHMcymceoHsRgLQVtDPQ1ElPVRSRTxHpfHI0tc0+xB7K4vw2a7u2pWTWy5yM fFQ07GxlrcHA4GVX74gWAbo6iLRj/aM/+5CzjlMt6azwuOpUYkcp8L6Obwuh0LpKs1hf6e0219Oy pmBIdUP6W8DPdaZc4GlZdPHCmW9/D7rK02qpr3RUNQ2BvWY6eUve4ecDHK57Qe1N/wBaNq3WiOmA pSGyevJ0EE+MYTa62jsN+qOjn3Uws2B1nLWVdO2jpg6mAJc6XDX5GR0+64a26TutVqAWiGimdcev 0zAGnLTnBJ9gPdNrI1MNlr5WB7KKqe0t6wWxOILcd+3Za17C0r9Bts7VerZogW3U8FOJqWMwxmMh 3VGG4GVRHU8TYrzWMaAAJXYH6lIZSS6aXCzY0nwmQt1pGz1V9vlJbrfF6tVO8NYwuDQT9ylsxm6k m+o1ktHNG0GWKRgcMgvaQD9l8QzA7K3O/kTodqLZQ1VqfTzxmNnqYa4Mc1vIyPfCr1pLb3UOrxUO sNudUsgx1uc4MGT4BPcrev1mX2xjnu3H6cYGp4z4Um3bZbWdqtk1dV2dwghb1Sem9ry0eTgHK81n 2h1feLNFc7baDPRyguY4SNy4D6ZWemkd9I8I4XdVG1uq6axOvE9nnZQtGXOOOpoBwct7jlei2bRa vuVtiuFHZZX0ssfqsk6m4c3H3QR4R24WOMZXcXLbfU9stAuldZamG3kA+vwQMnAzg5HPuvjcdvtR W+yw3astNRHbZmtcyowC0h3bOOyGnG4BP1WJGF1130DqGz2aG719pqIbbMGmOowC0hwyO3Zcs9mD 9k+Nj5gL6NbkeyXhSl8P1jF01zSVFTa33G30uXVA9L1GsyCGkj7pbpcZu6RgWEDI5+yWMd1O3xKW e1U+raBljt7aPrpWh8UcHpdTi4gHpwM591Hc+3WqYqunpZbDcGz1HV6LPROX9IyceOyJquNTa0ns Fv7/AKRvdgEJvFsqqJspIY6aMtDiO4BUk/DpYKWs1S+qvNnfcLYyN8RcaYzMa8jIyADys5ZzFZjc kMFpacEFHQ7vhSnvPY7azcKsptN0npxOexjaeJhBDyB8ob3Bz4UobE7R0UtkuNdqu2TOrz1wx09V FgNb08OAPOc+V0yxuN1Uw/fHlPUVacD5yljjsul1fp6tsF1fTVtJNTE5cxssZaS3J5Ge4WutdmuF 1e9ltoqmrewZc2CJzyB9gsjWY7YWfpPx8oyV0ultI3C+6mp7JBEYqySQsc2UFpZj82QexCtJS7eb e6OttttmpKSlq6ypdgzTcPGfJx4yMZU33pZjbJVNS0gYIWIHCnXebZ6XTdxiq9PxyVdrrHH0mRtL 3xuwT04HcY5BUO1Npqaad0M8MkUox8j2EOGfom0a1rD4GV9PQe4fkKkDbjRlNctWUNJqid9rt7y5 zpZ2FgeWjPTl2O6nq4WjaCjvMVA2ztnkkLGiWne50eXHAGepNqqP6Lx3aUjC/wDykq2d82Gs0uua MUdSaa11GZnUvR1Y6MZaDnsV7LnpXaqh1MLFU2SQVvqMiyxzunqdjHPV9VUvXtTx0ZaeRhY9HHKn HfjbKl0le4ZLMSaKtBdHCQSYiCB0g+QohqLVVQHEsUjP+aMhL0ksvpqy1MNwvvJA+M4cOfssqenf PI1jGlz3HDQO5KivOGZHbKyMbh3aVLOitmNQ3bUsNtuVM6hhEbZ5ZXEOww9sY757Kbq/ZXQlVFVW i2vkhvPoB8chnLw05xnHnkHIVFNun6FYEFdprXRdz0zdZqK5U7o5I3Y6sfK4eHA+xXLGleHYxnKg 8wae+Mplj8DLSAps2H2ytOrTV1+oaxgpKYlhpmydD+2Q4n2Ul2ja3a++XCe32uevkq2McekyuAGP PblNyeyS1Ucgjx3Rjjsu73G0NU6S1BVW2R7ZRE75ZG9i08j+S459HIHd2kKmnjDT4GU/Tdjtwp42 K2htmsLXV3W+1pFLG4xthgf0yNc3BLncHjC7q37O7d6i/GUen7rWvr4Y+rl+WtPYEjHIyiaVLc3C x7Lq9d6XqdLX6qttX0mWB5aS3kH6rliMKjD7oTISRR5QjwjugO6CE0igEsJoCBeUFCCgEJoQJNJM oEEFCEC+6PKaEQkDsmUsIBAQj+aAQhHlAHun45R5Qe33QCRPGEJ4RQAl4TykTygyASKQ7e6EDKSa SBoQghAJBNCA8oSTQCEIQCEkygEJYQgaEIQCEICAQhAQCEIQCEkDlEP+iSEz9VAJJhAQLHCZS+qf v9ECCeEfp2QTkoEgIJTxlAJJ9kj2VhD7eUvHlCEUFCE1AsBHZHgpoEgoQR4QAHCAMJ+EvJQMc91i Uykgy91j+iAnn7IJ/PZYlZLFw4Xy3ueG7D/YZSO/S7+ig/8Axv8Aq4qbb3kW6owcERuI/ZQg0Zc4 58r0/wCP6rj5Hzn/ADr4r7T/AJ18V6o4X2ZSTSRAhCEAhCEH1gf6cgd7Kyuy+7dLRUrbbfJWxMaM Ne78pCrMvVE8taDnCJYtU+4bcUWuW3eguMHq1JzKwDDGH3B7crpNV7t2KkrrZT2i7wvgc8/iA0ZA HGMHwqaNc93OQU+p/OTlE0vBeNXaKvUVDJWXekNXC4Pjd1ctz3/ktledRaNvdn/h1Tf6X0XFpJBH ODnCoe2R/wDhcBj6rL1pB3kb+6Jxi+UOrdG22CGmpbxRMDXNOA/HA+ij3X2stPT7iWWqgutPJFE1 7XuY7IGcYyqn+rKe7wR91iXO75yVrHLjLr5Yy8MzuNvwt1vlqnT160L+CpbxSulc5nytdkgA8nC9 G2dfovRmlhUx3amfN0+o/wCYBziqeOe8juEGR5GM8e2VblbjMfow8UxyuU+Xfb0a9Ot9ROnjYGUk OWw8c4+qjjvjKbnZKRUyyuXt1xxmM1E5/DXT2qO+S11ddIaadg6RG/jI98qxGrNS2GW42UMvFGTD I7IbICewCoXC57SCx2D98L7umn7lxP6pjlxTLHktx8RV1s93sNqpIbnSfNOA8h4PS3GMnC7zQE9m tekIKJt4o3ARBod6gHhUJdPM/HqOJ+5yvuK2qawNbK/H/MQmWW5Jfhznik5f1afQOn6G07k3Otkv 1vkDiXM6HjGHHJyc91s/iZgpr7oxs9FdqAPoiZDEZBmQY7D6qoTKupbJlkjgT5BKVRWVEzemSV7h 7FxIVvkvLl8mPhkxmHxHmMmX/N2Vo9Hbg7cxaFZRXOlpzOIehzJKcOJOMKq7wAfr4TBcB2WHTT73 s07rrVOohimMjjGMYw3PC8OF9MZJ7kp+k7Gef2RqPjhJfX0yfBScx3sUHzQmQhAL6wcSBfJZMJQX Z+GHUNtqdEx2xlSxtZACHRuOD3WVLtlfa+/3KpvmopqS3OkLqdtHUZPT9QeyptbLpV2+X1KSeSF/ bLHEH+S3D9Z3/oLTdKvpPH+8crMtTTFwlvJcvQOqLHabxU6UbdjWSRn5aiY4c93lp+oW30/p6n0T PdLrXXd81LITI0SEYjb3wFQmK61UdQJ2TSNlB6g8E9WffK99Zq++VlO6CouVVJE4YLXSkhWZWTTN 8e7tdPQW5th1PeLnbqd4gmkeQ0udkScYyFstN2Jmg4bpc7teJKilcS5nqdo2+wVCKC5VNHUNnpZX xTMOWuYSCFt7jrS/XCkNPV3Kplgd+ZjpCQU5VZ45O169Eaitmq7JcX2mdjpJnPzH1cg4wFoNl9JX fSTLzJf444hNKZIy2QOHT9fZUssmqbrZ5HvtlZPTOfw703EZW0qNx9USxPjfeawscCCPUPZOV1o/ HNyur3aqrXc945pZahklufOwSvaeOnPzBdzvNpnbmj0F+M0y+kjug6Sz0pyXOB75blVsfPJNK57y XOJySfKck0hbg9RA7clXLPld0x8fHHjE6fCX0ncSTkZEBx+6kD4o9D36/wBZBdLTQuqaSlpyZSxw 6hgknjyqt2G+V1irBV2yokgnA4ewkFdHXbn6trKWSCa91jo5G9Lh1nkFTDO4b0uWEys38N3s7uTW aDvTcPe+3Su/v4CePuB4KnvdDQdr3U04zUmkpI/4oGdXSDgS/wDC72d9VTRshz1HJOV1Omtd6g07 TywWe5T00T/zNa4gJLozw5e0/wDwq6bu1v1Dc6yto5IKaNpp3F3BEgPIwtD8W9tuMeqaa4SQyC3y RtiZJ/h6xnI+6iqzbl6otE1TJRXepjdUPMkvzk9TvdebVm4OodU00dPerhNUwxu62secgH3THLjt MvHyst+E+/CJabiyWvuckLxb5WemyQnguB5XI/FRQXKn1oyrqIpW0UzQ2KTHyEgcjPuo20juVqPS 9I6ks9ymp6cnqMYPy5Xy1juDqDVsMMN8uElTFC7qY13ZpPlXDPjLPtnyeLnljl9LCfCJbLhFBca+ eGRtBO3pikP5XOB5wo8+J6huNJr6WarhlZSVABgkI+V2O+D7ri9Ibp6l0rb/AMDarjJFSglwjzkA n2Xi1xuDfdZCnbe6w1DICXRtI/KSrj5LjLPtcvHMsscr8LHfCNbrhDbbhWzwyMoZwBC89nEHnCjr fumrKXdOSStZJHTTSMdE94w1wBGcFcRpHdrVOlbUy32u4OjpGElrCMgZ9lrtbbh3rWUlO691Xr/h 8+n8oGM91nx5fjmUnyueHPLHL6XB3YprlddsaUadjlqZyISG05yS3zjC9ejaSup9nPw16ZLT1pp5 WvbNw4E5x3VUdLby6q07ao7fb7gfw8f5Q8A4/dfbUe9Wqr9QCkrK4CMODvkABJH1Wud1J9Mfi7yv 2tOy2t252/aNJ2eWtrpWgkRty9znDOXY7gKH37a62vVUzVt8lpx0yiZ8EznNla1rsnAxgcfVcZS/ EFrKGnjiFbE4MaGgmMEnCxuW/wBq6uoZqWaqh9KVpY7EYyQVLluaamGrtZjdymr62yWNtpimnYau J0nognDPc48Lw78gxWSwVjmPNNSV8Usz2gkMaPJVcbBvtquy2qKgpqmOSCIYaZG5cB7ZWFy3y1PX WGqtM8sDqepDmv6owTg9wFOXprj/APfa0mv5brdrHZ71ol0FXJFL1An5gWub0nj6Z5Xm13cjpTad 4u1RDFchH8oaeHSdWcBVX0LvBqHR1HLS26dj6d5yI5eQ0/T2Wj19uBeNbVrai7Tghgw2NnDB9ce6 m7qQmE3bPlPWgN7NT6k1FR238LBK172h5jiJIZnkn2UobyX59nisjJA1tvnrWfiZnNyIw1wIOfHK pntzru46IvL7haiwyuYY3B4yCCuz1hvrf9T6eqrRXR0v4eoADiI+Rg54Tq+2vlZvcmW+PZarvpGC CtaQ6F4ccgskwAe/g+fC8W5l3OkNsKU1E0Md0p2wujjJyHvaQSB7qt2h989QaUtf4CF0VRA0/IJ/ m6PoFx+4W4F11pczVXOf5R+SJpw1v2CTUy5HxpYzbnem86u1TQ2yagpjFJIA97IiSwZ758LZ/EUb leTatK26hinfcX5ZJIACx7T4ceBwq1bXbj3DQNxqKq2shlM7Ax7ZBkEDsux1ZvxeNRW+Ommp6aB8 crZY5o24exzTng+FcLxtrn5MLlZq+nsp49f7a1tLZ55K2kppnCRkcL+uI5ODgjgH6Ky2rbNS6htu n6a7w+vG6eNz8nBJ6TnlV6o/iUvcdNDHPRUczmNDS5w5djyVzert8L9qCupJ2SNom05DmsgcQOoe VjCcbuu170tXUXp9q3AtGnaahiFFPSmQzdHLS3IAz+i5fVEsVHv5YJ6qRkUL6F8bXvOAXEnAz7qI 3/Epd30AhdRUvrdHQZec5x3XM7hbz1esrVRUlTRQQz0sgkbURk9WQP5KzqaN9yrH6+kv0Or20tqt Ta2ju9KyB0pfj0yxxLj+x8rp79V01NqXTMVRPFHJ1yANc4A/7sgKtmm/iMu9ss9PR1lFBWTQjpE0 jj1EKNdV6/umodQuu1XUPE4dmMBx/uxngBC3rS1mt3XluvP4dT2g1NJdBF0T9WAz0yS4/oD2Xd3S WM6pssIe0yNbM4tzyPl9lWyxfEjXUlop6e42+KrqoW9InJw4+M/dcIN2723WTb/+JcZ2nAjJ+Xoz +X9lrLO5e2ZjJNT5dvvPcL1TbszR2qSobUudF+HbGcdTsDH81yW7ly15Vigpte00sDWFz6frjAB8 HDh/RSCfiOpZpmzVGmqOSVvZ7jlwP3IUf613eqtT6ot9wrKSJ9BQzCWOik+dp55yfrhM8uWW2fHh cMJilj4cNDXeyUz9S3erfQ0U0ZLKfrwXN79Tx2xjsos+IfVNk1RqwSWeljY+DMclU3gz89yPovbu ZvnXaqs7LZbKYWykcMSMjfnqHgduP0UM+rl/U4Z5yc+VJdRbjuy/SyXwhtzeby4cj0Gf1UXb/uzu fqEY/wDjjx9gpN0p8QFnstspYYdNQQTRwsjkfAQzrwMZ4ChDcXUbNVaruV3jhMLaqXrDCc44XPHH j/7d/Ln+SyuXP75VhfhT0hb7zdK+6XFrpHULW+kzPy5dnJKr4PfCkvZrcyp2/ur3+n+It84xNDnB PsQVpz3VvdE3223W4XmittB+F/AvEb3deevkjt47LkNjG9N21n8oaBWYxjHly42L4g7HR1cctqsL adsshfVhpa0y5HHIHfPuvNaN9dPWq83eqo7LJFDXtY4xskA/vBnJPHnKuWrNT7Zxlm7fmJ0tF5q6 mSyNkLCKo1Ak48Mz04XntFuohrTUVzbSwiujEcYmDQHY9POCfKrxpXfOSgvlPJc4BPbqczekxhw9 vXk4z5W8t+/lFS6vrqw0sjrVWNHXCSOprg3AIKvXbeXXpLG1F+rdQ2O911e8OkNTJGABgANaAMBU i1W3/wBL1TnDkyu/8xVl7bvvpe01McNqs01Nb5S91RGwjBcezh9z3XC1G2VfubXXHUOj4qGmtc9Q 5raeeYhzCAM8AHgkp81j6QThbjStVPRXmlnpXujmjkaWvacEHKld3w360b2/hbz7Ccj/AEWmdpOf a7XFodre3xVdG4eqY4ZOpr25weeOQfCznOWNjphdZSp739kfPtXajKS58ssJcT5JYVltjUSWv4f6 qso3enURQVUjHjuHNLsf0Wg1hu9oXUOlZ7TUUVYYvSIg+UZjeB8p7+CuW2l3etdn07Vae1PTumtr g4R9Dcktd+ZpVl1MJ9OXC68mvlJGwWo7rqB96bd6yWqZE2PoEhyB1E5/ouztda60aCnq6VjAYZpS 1mOMesRj9lF9t3V2/wBMW6t/srRVFJUzN7Ob1Bzh2zly8bN6LFNt5VW6WOaO6Pa4hoaCwvL+rvns p45xll+a75WW7TrR3H+IV92t8sDBDTsj4x+braScrTWy4Gy7eUtTAxp9JzWBp7YMvT/QqKND752g VFyqdRRPp6qdsbAYG5a4NBA79jysrpu9pyTbyS2075hXs6XRtc0YJEgcOc/Ray18M5etRN0VUy4v vltngjdT02IwC3hwczOCP1Uf7htaNiYmNaAz0YQB4HzBcvore+yOju89+D6asq3dWIx1NOGdIx+y wse6mkrvo82HVjZBBHhjfTyOtgOWng8FXG8cpT1dxud0mdXw+ULcf/G9P/QKnVW3ExHZW6r9y9DX rTFdp2sdMyjaDFSdLTktDflP3BUKSbLa0qY4qmnsjp4JWh8bhKzPSeR59lZl/wAeOH0xr9rftFP5 RlTX8Ll4rKHXlPRU7+mnrWkSs9+lpIWjk2Q1yxpcNPSkeQ2RhP8AVdDsTW6f0bqqul1i2opLjSfJ TgtPyO5DmkDyueUt9Onjsl3l6dV8Ubnx66tkjCQ9lG17SO4IkeR/MKU7XqKul2Uj1DK9r7lFSmVk rmgkODsZ/ZRN8QeqdK6lpKCvstW+W5xkxObggGIgn9wStpaNw9Nf9h77G6t6LkKR0PouaeXZz3WP LvLy4WevlZZ+G433t2mrpG6p2DnuF4ijnqvwwna8tGWvDwAR7FcB8L92qoNS1dna8/gpYnTFh7Bw A5C2Dtw9NybHS2WOuAuX4T0RCQc9XUD7LQfD3qHSVglrrhfK19Pdeoxx9WSwxEDsAO+crl5MMssZ r4rfLGXL6rS75VU1t3ar62jeY6iKaKRjh4c2NhB/kp92V1hctXaMq7ldXRmpilfGCxnSOBnt+qgX 4gbhpq53aO86fuP4qapOKiPHAIAAI/Qdvot78Ou5Fms1prbFfJRSxyvdKycng5GC36Fe3zZc8pY8 n+Ljw8Vxy9/Dhd09Z1+sK2Bt0MLvwnUxjmMAdgnn+invYHT2lbZG+t03cpqurqKZhqI5HA9B8+B5 Ue723vQkmloKHT1LTS1rS0tq4mhjhjj5iB82R7qKdB7h3XRVZPPaJGN9ZoY9r2gggKZWX064W4yr J1Vi09Rbs0V0tdyD7zLXObU0xAwA5pz+owFs91G2KW+1UV99AT/wtrqMyHDvUEjvyn3zhVgi3DuT tYf2i62iu9b1sAYaT2IwrI0GsdB67orVdr/JBFX0uQYpfBx2PuMnIXPKbrrhnMeN+m53SvlTpuwa eudGGumhnGGu7EGMgj9sr10dh07r5lk1bNQM9ZrfU6XNB68ZADvsexUcaw15YNX6vt9hrqkU2noH nrmaRlzw045/yngfqumvG6+mtKVVqtdjEE1rbgSmA/Kxhz2+oPKxrLc16c7ZZftGu/mu4dQTwUFH ThkFI84e9oDg/lrhn24Xv261Ft7JQWWmuNjnbeWmOJ0wJLXydWA7vjv9FsdWHbyj1bbr7G+juNvr HObVUZw4RuI/3gHj6hbKTR22st+gu1r1DDQNZIyYUrHgx9TTngHkfuuuWt9MYbk/b2k+6xXB2tbY IauFkIileA6HJx8oLSc/zXK364aKduCKS42uR98M8bRUNPHXwWnv9R4Xzv26mnaHWVua6YSQsD4n zxuBaA7GD+45Xnuln0fctZs1H/aqFk4mZP6Ic0sJaBjnv4Uy7l0vVs36dbdbU2v13Q/xMR1EMUL5 qfALTG4OHB9//fXGan3YdprWNVbaq3U77fBN0OLG/P0Y7+y2Fw3Q09Br6mjfUZhZG6ndO0gsBcQQ c+y1160joq+atkvVy1HS1EEsnqPoy9oa7jsSDlS7tW61JEK7z1GmL/foa/SdPMySpGahnp4BkJ/w j3Uo7M7ZUmjbcdU6tdEKtrOuGI4IhGO+fJIXv04zbm0bgVdVbW01O2hpMx9UnymTJ6nMyeTggKLt 5d1JtS1r6a3vdHboj0saDjqAP5iPdJET1t5qyLV2rL3U08bWQU0EcEZHdzetxBP15Wp07arVFrK0 3KkmBuctfVsqGiUngNdgdPjwoP2J3Ki0nqCRlwaHUFb0xyv8swTg/blWCp6DRlnvlVq2C4QOeWGV sbZR8riMOIGecg9lq742Rn5eXUuqKKy7nmkvFJFNRVdPFGZHM6jGSSAfsScL10m3WldIXO46mkpw YWs62sc3qbEDwcN88lcdZprDuNreovN5r6enp6DpZFSl/QZgCS1xJPg+AuzOvdNaludw0zWztjpZ Y+hsj3BgcR3Gc/QEFazstmkxlk7V413qOiuet5K+lpfwdG6SNszabLS9gcA530JCnTauLQb7++o0 jPVyVxhIImcSA3z3XF2DRGiP7TXOx6jqo6mqz6lJVsqelhjLe3BxkfVdZtnoK36L1FPcxqOgq6d0 Lo2sa5ocOc8nJBXDy8rOo7Y2T5dDaNPUNz1Xf7peqGCorIJPSax4EkfR0Ag4I7rj6LX+iqu4z2++ aft9BD0uaJBE1wJ7Y4aMLrNH6ysVy1Lf6OGsax87+thkw0OAaAcfqFyNv2csb7vV1d+vMFdTOBc2 Onl9JzTnOeCc8LrvtnpF9Npia+a5rbXoGeZ9r9QOExc4NijIHLscnnICm6aaxbR6XMMDBLdpWZe8 nLnuxg5d4Ax2Xq2hisFutV8p7DUwxx/jZBDJK4dfT0t6c55IBWoG1tNe7vVVesb7FXiUZY2nl9Mh 2fPPPCRKq3uDqGbUV7qa+sIM0rskgYXGuC7veCw0mm9XXGgt7y+mhk6WdTskD7+VwhOVaywST8pF RRhIJo+6oSCmUIF5QhCBeU0fZCAwjCSeUBhCM8pojEoQmEUJFNIhAAowgIPZECSfdGf2UAkmhUAQ fdAQUBjlGPCYOUkCwUYWSR7cIowjCExyfoiEkQsisfKKaEI5+iA7hIEoQFAEo5KO6aA7pDhHYpnk IEjyjxwg91UCaRQoDwmjskUDQl3QgChMBCBJ+EkIGEeMoQeCgMcoPdCSBowUBNBj4TS/RCqgd+5T 7JFMIBASTxlAd0FBOEkAhPsEvCgED+iaECQO6O6P6oBNIozytQNL3CEh3UoZ4QAkUFQPGEcJd+6M ILAHkrEp54Scvlvc11+x/Dagn/5E7+ig+Lwps1ES201X/wA6fg/ooTiXq8HquPk9vnPnqOV8l9Z/ zFfJelwoQmeEkQIQhAIQhB9YInTStY0cuOFbDZjaq2UVsbc7vBHVSlocfUaHNHnGCqtWYD8fBn/O P6q+uj3BuinEc/3P+iTu6ZyupajahuGg7tro0VFZaEGA9JeKZrA855GPK6bVW1NmuV4tlfbrRRRQ xuPrNjjDQ4HGMtHBVcdH0tfUbhkULiyQTuLnHwM8q69hjqI7XC2peHS4GCP6LXkx4Z3FjC8puuJv endG2uWip6ix238dL/u2imb84bjOTj6hbC76X0pbqFlS/S9uk63Mb0spm5+Y4z2XFaujuzN3bd+P nEtuex7qYDuztkFSpqG8UVktMVZc+KZhYC7GSM+R9VLNXtZlLNxzkOitFXAQzU1hthcXhhaIGgg+ QQtHqXZXTUl6p7lR2ynjbGf72na3DHj3x2yvVoConuOsrrcGw1LLdUVAdA6VpaHDPhdjV6nho9Wt tVTJzJEHhvtz3CnxbCX1v5Q3v1onS9m0rS3GkstLTzh7ATC3oLge4IHH8lsNGaN0FrrSDWQ2ilin LC0ysbh7HY75HkL2/FSf/hFjIOQZm4K0fws9RtU5OQ0ykj9l2z1PHjZ8uHiyyuee/iq8bnaKrNDa kmtlYRJGfngmH+Nng/Qrjx+yn34tzjWlIPanBH7lQJ3WPJjMbNO/iyuWO6m/4d7Npq+Vs1HfLTHW z/mDpDkAfZT5dNs9vqKppKeXTVM51U4tbgkYIx9fqoC+F8E6vm/+df6q3d3/AIa6vt0dfHmcl3ou yR0uGFif1rJF0+0OiLVqCnbLZ45YazqDYnEkMIxnHP1XrvW2m21pqqWCt0/GDUEhrg52AR+q215f djuVQR1jGfwtsZ/DuaRnr46s+fZdHq++WWzASXmWKB3pvEckhwBkdlu49yRww8u8d1wVRtLt7BcK RjbG18dT1dJa9xacY+v1XA796F0HpHTz/wADa5ae4y8U745CQD9QT2X22VvlXe9wrl69dJU00XMI LyWAdR5aOw4AXq+LYF/8Ija0uPW4kAZPZXxYzLPLG/ETzeS4442fNV+0Dom4axvDKSijd6YI9SXH DR/1VjLv8Otlk0u+G3l0N7DOqOZziQXDwR2wVt/hgtzafS4M1P6cxc5x6m4d34K7q3W5zdbVlSNR Mm63D/YS3mMe3f8A0WZN7drlqyKvbcbKXW76jlp79A+kpaZ/TIPL8e30+qmGXaja+G6MtUsDxXub yG1Lv6KYoCGailjbGGgw9eQO5yoZ1FtadTa2rbnbtVx0NYJSRE2Lrcz9chJEuTx2r4dLLFqSqdVy yVFrdh0EQcWuaD4J8r0UO0u191vFZbKOnr/xlMemRvruw0rX1updR7V6qhptR3X+M2+VgJlDC1zB 9ipAtw09rxsl60zWPpLs6Po9WF3Tz/xDytcddVj8m+8fhU/enbk6F1QaOml9ejqMvp88vaM/lPv9 1parbTV1LZzdJbHWChDesyhuQG+5HddDu6dUUGrGxatmlqKiB2YJXj5XtB4I/ZdxWb/Vc2jJLRJa oS+SExGTqOORjOFnLHV06ePLc2rqQQVnG0k4CJTmQnHlZ0/L8e6y6Jh2W2hqtZ1Dau5NlgtI/wAQ PS5/2KljUXw66arLPVt0xcKkXSJuWiSUPZn2IAXdbDNDNraJw4/uQcj9VtdA6etlkr5ZbXVyTmrL pJg+UPw7/RamP68q5XO8+MVo2z2Nud8vk8eoYZqKjpnFshHBeR/lPt9VIGp/hysc9mq36UuVS+4x DLY5ZGuaSPBwFPVE93ReOrIDHHB+nSud2603Q2CpnfbK2WqZWZlkD5A/pd9Mdu/Zb4zVrH5MpZPt WXa7ZC5aiu0zb9FPQ0MDix+OHEj2z4Xdaw+G+2fwOpn0jcqmor4RkQzOaWvx3GQByrBUjy6gvDs4 6XyAH2w1aPbzTtLp+acUNbLVRVbRO/1HB3Q898Y8LFblqru1eyFy1RXym9MqLfQQuLHux0vLh3xl dnrb4cKWCx1FXpG51NdVwZJp5+nD8dwCAOVYuIuksl1+boPXM0OHGOO60+3WnIdOfiKelrqirima JSZnA9Lj3wR4Q5XelWNqNkrhqyrlkvDai3W6MlrnFvS8uHsCus158OTKDT8tdpO5VFxqIMl8Eob8 wHcAjHKsVPGajTV0j9Qwue6ZgkbwW8kZXh27083TcdbQNrp66J/RMHzkEguHI+3CWdbZmd5cVVNp tk7hrGaWa6/iLbbmZb6hYA8u+gK6PcX4d5LNYXXLTNxnuhhJMsMjGh3SO5bjyrI1bDPo6viZIYDI 6SMSM4LcuIyPsvNt/YX6apq61yV81wiYWyNlm74cDkfyV46kq87uxVPafZG46y9SpuMktutzcgSF mXud9AfC3G5fw+VenLEbrp+4S3aGMkzx+kGva3/MMd8KzFcx0+hpYqeQ0zpy6MSRjBZlxGQsdA2S XTtqrLVPXy3FsTw5ssw+bDhnB7q3HrbP5LvSp+0uyNw1vDJWVs8lut44ZKY+pzz9j4Wx3O2Ar9KW QXW0V7rvSsJ9doh6HRt/zcE5HurQXGF9ToAQUkpo5KhrYxJEMFnU7GQE9EWiex6crLZW10lxMBd0 zTM6S5pGQCOVmyxuZd6VO2q2OuetaSSuqqr+GUGP7qZ0XWZD9sjhfXdHYm56Os7LnRVou1Fn+9fH D0GMeDjJyFai6Us9XoCmo7fUmgmqmxxCaNvLOogEgfZfTSVrqLbpGttlzqDXOpzIwSyt/O3pyOCp pZl3pU7a7Y2660oH19RVi2UBGY5ZIi8yY78ZGAvhursjddD0cNfHUtudtdw+ojjLPTPjIyePqrZX ujqa7Q1Db7XVm2y1TYovWjZksB74Ax4WenLdNTaEq7bdp23F9MJYjJI3h4aODg5UvRMlUNs9ibzr O3Or56plroiMxSSxF5k9+MjAWt3V2bvGgWw1UszLja5QB+LhYWhjj4cMnGfBVutS0VZV6Ptlss9a bZLVCOP142Z6GlvPHC8go5W7V3KivMjLjJTRzROkkZ+fpzg4OcLcx3ZPtjLyXGZZfSn22W19413c DDQD8PSM4kqpGktZ9MeVjutttXbe3qnoKyshrGzReqyWJpb5wQQVPvw3a9M76bSooaePoD3CZgw5 wHv9Vr/iMpmVe6WnIpWh0ZZGHA9iDJhZ1rlv4dLb+uvlGu3Gxt+1jZ5Ll+IgttNx6Tqlrj6g8kY7 LUbhbTX/AEVcaenrWNq4akhsNRTtPS9x/wAPPYq4Gvbfcqiz2yz6bq47bLO4t6+j5Q1rScYH2Wv1 Kag7O1E906KivpKdzvUP/wAkYcAg+/C1hhymNnyxl5ePL+ICtPw36hqrTDWVV0t9BJI3PoVAcC0+ xK5ncTZbUejLQ26VMlLXUWcPkoy53pjwTkdlImh5tbbrVkNLX180dlpXgyzY6e3+EHuSQpF3Qvds orFTaCtUrZ6ytDaQeo8u9NpOMuPkqTHd01llqKgaR0rctUXqC2WuF0lRK7GcZDG+XH6BdRuZtPe9 v46SS7TUc8NS5zWPp3k4I9wQFbPRejKDbSyQst1C+tutS5rZZ2MLsnIzzj5RheDeq0vuN50i+alN RQx14E+W5aASAOr6FXCS27W5WaVw0VsTqnU9nZc4X0lFTyH5RVOc1zm++MdlwWu9LV+jtQ1Fpujo nVEQB64nZa5p7EK8u6Fhv12tNPbtMXGktsOC2X1T08DsG4VUN3drdT6TYy53qWO4003DquBznhh8 B2eyXHqUxz3tEhPKxJTeME+6wKw2y6j9QssnPdfLPKaD7gnHcr7QBzyAMn2+q8rD4UwfDbZKG8bj 0MNzpo6iBsb5Oh4yOoDIKlumsZyuoNObGa1vdohuNLQxMhmGWNlmDH49yCOFotR7a6n0/fae03C3 P/GVIBh9I9bX5/4gMceVYL4jNe3XTd8t1ntUv4aEQNqetnBJDiMH6cLd7ZblQa8utip56csudKJX TOwOkjoxkKs7QWz4fteujDxb6bBGf/WmrRM2n1Y7U38BNuLbj6ZlDXSANLQO4ceCp43R1Xd6HeO3 W2irp4aMin6omPIa4ufg5H2Ux3hjDqqwS9I68Tt6sc46Oy1njcbqk7xmShd20TfLVqKOyV9DJDcZ HtYyNx4cXHAwexH1Wwv22OqLDcaGhultdFUVr/Tgw9pa52cYyOFdrU+nbPq6SEyOjFxtkzJGStGX RHg4PuCFG/xBXantd80hW1LXOhp6oyu6RzgEZwrjhcrYxc5LJ9oLbsTrwEtdZXceROzH9V4X7M62 F0FvNlm9cx+qPnb0lucfmzhXI0Xq+HVlluFzt4P4WORzYS9uCQGg8j7qLv8AtLh1NrrSMNrlliqA 8xVjAMNOTyB79lxucmNyvw63DKZcb7QdNshr1jw02Gc58tkYR/VeOTaDWkdwdRCw1T6lsYlLWuaR 0k4znPurj60hv4ukFbaK0UtFR0z5pmuZ1tmcDkMIyMZHlcLa93LXdNd2YU7mRMqaf0KoyjAjfnIA PldJNzl8MTKW6VRptJXqq1AbHBQTvuoeYzTYAcHAZI74XsqNvNTU+oILJNaKlt0nZ6kdOcZc33Bz jwVdam0BZqTXs+rWEiWWMP8AzfK1/OX59iFDmodx7d/25UVxuAbHQ2sSU3qw/P1A55/mmv1uX03h rLLVRENm9ckZ/s9X/bDc/wBVyeo9O3TTlcaO80c9HUgB3pzNwcHsVfqn1dHU6IqNR0zWugYySRgO R1NaTg/qFVL4htT23VuqqSstUvqMFK2N/GCHAkkfzUk5Y856Z3+3H5Q382c8o6j3yrCN2x0hLslJ qGOZ4vTaYyBwqMj1Afy9Cr3M0B/AWMcuU23lON0YJ6hgn9102ntHahv9G6rs9orq2nDjGZIYy4B3 suXacOVnfhFvFaayttXrE0IjMwjPh3HIWfJ5OGq1hjyl/iul0pKu11klJXQy09TC7pkjkbhzT7EL 3WbU93s8borfX1EERPUWxvIBPurFbqbN33V2rL1d7fJRtDn5bDM4te8BgwW4BHJBHKjWybHalvGn 6y6wOooDSySRyUtQXNlywAnxj+a7WacpdztyLdwtSZ5u9acdsyFai96jul9kjfdayepdGC1hkcT0 jvgZXVbebY3XXVZWQWySkhkpWBzxUOIBycYGAfZdFS7Bamq7fX1VPJbXyUkr4n07ZHF7i0+OMcqT tqyxD5e4jHUUAkHLXEKZ7l8PGq6S0TVzHUFQY4+v0InOMjh7AY7rRaK2b1LqyKolpKeOkihcG9VY HRtefIacc4REbhzj3eSsuo/5ipdvvw/6vtFrqK50NDUxwN6nMppXOeR5wOkZXgotktU12nKa9UUN JU004aRFHJmRoJxyMeO5QRcCQfzlNz3O4DypZ1HsNq+y2uevkpaaphhHU9tNIXv6fJDcc4Wou+0W pLXpCPUc0NMbc6Nkh6JMvaHHAy39U0lR8HO6cdZWcLZ5ZmxReo97zhrWjJJ+gC7nSO1Oo9V2Wout ohpn0sLnNcJJel2QMnAW12M0/cqzX1JU2+kbP/DnNmmjdI1h6c4OM9ysZ5zHG5N44W5aqPKmKroZ BHVRTQyY6umVhYce+Cu0tm7urqClipqe8VDYomhjATkADsFJHxXn8TfLSJKJ1PKymdh5weppcfI9 iOyjzT2zer9QWmO42+2MNPKSGiWURuI98Hwumta2xLv0+x3r1mDn+MTErgbzequ8XOor6yUvqah5 kkf26nFdfq7abU+lLcyuvNuZFTPf0F8Ugk6T4zjsvRY9l9Y3y0w3G32uJ1NLnp9SZrHnH/Ceyio7 dK4j8xSEr8Y6/K7jUm1WqdOtpX3a1iJtTIIYy2Rrh1HsCR2Xuk2W1lHX09G6zETztcY/7xvSQ0ZP OcKiOXTPwfmKx9Z47OIK6rWGgdQaSbCb5bZaVsuQx5Ic1xHjIXIOBb3RH0dM5wwSThJkhjPBK+eU iUH2knfJ5K+eT+qwyE88IMmkg5ycr6sqZWfle4fqvOHElZAhB6DVSHnqOVmKyXHJJXkyjPsg9YrJ DjJIX1bXytGOp2PuvBkZT6h7qD2OrZHHkn75WbbhOz8sr8fdeDPCM/VB7XV87j8z3H9V9Bc6ho+W V+B9VriUZV0Pa+vlecue4u9yV5nSueT1OJXzJCxzyivq15YflJC9sV1qRH0iV/SOAMrW5QCiNg24 zxkmOR7Xe4PdBuVR6nX6khd3yTyvACCnn6ppdth/Fakv6i92R2OV9/4/WgANnlAHs5ajqHukXKaN tnHdKkS+o2V4ePIOCvT/AGiuABH4iX/xFaPKM5Q228F+rIHl0csjS48kFep2qbjj5aiTP/MVzrj2 wkSfKG3suNbLXymWokL3k5JJ5XhKDyg8/dVAUk/CSBFCEBAFCEeVdgSTKECQO6EIAoTwkgEk0IBD UIRAknn3S8IppIT+6IOySOEFDQR9UHhGUUeUI8p+UQicBCMco8ID7oHbsjsg5xygCgIR4QNYnunn hJFNIoCeUCGf0TRlCiEmf1S7JlAIA5RhBQBPCWU8JIGhJBQCaXhCDI9liEdkx3QB78IKSYHCA8I8 I+iPCABx3T4SJ4RjygeUh2ST7IF2TCSaqhLx4TQECRj9UZ5+6DwgZCQynlLygCPdHdMIQJCEyoF2 T+yO6X3QHhNCAUCQke6YQCPCOxR90B5QUI8DlAAowhPj3QT6QsXe5WRPusCvlvc1Gpj/AOiak5P+ 7P8ARQvCM4U0anP/AKFq+3+6d/RQxBwcr1eD04eT2+U/5yvkvpN+c/dfNelxoQhCIEIQgEIQg+9L MYZWuHBByFYzaLeWmt1GKDUTumNo6Q8jIcFW0d16YmveMMBP2GULNrT0Wstt6LWMlztsojdPzN1N w0H3H3Wy1JvXYjfrfFa66Y0Tc+thmGg8YwqkiKRzsNByO4AOVk3qyR59vKW79syaXRue5mgrnLSS VVew1MRBEnRy33+ZbG77h7f3ejjpq27sdCwhwHHccj+io7l4OM/uvr85/wDaAfqhqLxN3S0NA6CO nusLGRuzw3A+/Cj/AFJuPpmq3MorhBcGvpmQei5+MAHJKq4HO5HWD+q+bskHkFXepZ9pcJbL9LT7 6a60vqSxUNvpbkyQ+q10nQM9LfK3GltcaC0XpAOt1fFJO2PPpgfM52P9VT8EnsRwk4u6e4VuW8Zj 8RnHxzHK5fbq9z9a1ettQSV9S0MjGWwxj/A32yuOB7ZQ/PnKQJ/VZdJNdRP/AMN1bpy1VMtbdLsy lqj8vRIAAB75U1ai3C0pUais7473TuEDndWDwM45z+io02V7T8vCzM8hOe/6qy6TLHa+Vw1dpK43 6gqxqClb+HDgQD74/wCi4H4jbjpzUmmmVFDqClNZSZcyBvIlz3Cqb+Jlx3/mk+SR/wCckgfVamVl 25/gx+VivhqqLBbnzV1feIqeqccOifxgA8KZ9Qy6Mv16o7hX3ujeKbJbGSCCSqGxTSRn5OP1X0/G VB/xH91nHK422fLWXjxz1v4foNR6u0rT1uILxQiNjOnAeFFmktV2SLeC9zSXOD0Ji0xv6vlOCfKq X+LmyfmIz9V821L2vLgeR9VZlqWfaZeKZZTK/C9t83RsVr1pSQMrqeaGoZ0uexwPQfqvvRjSts1L Uago71TM/EgOkgfLkdWc5HPCoYamVxy5xJ98r7CunPAkdx7uKkysa4T2v6NZaVq9QyQvrqGV0kTe XuaQPotNpKy2LS+pbtd4L/bjT1snq+gzDBH9ByqNx1c4PUHHq98r6Pr6rHMz8f8AMU2kw+kw/ERq 20ai11TS0DjNFR4ZKRgtdg84Pld1fNz9AVu3M9tbSM/EvgLGM9BpLXY4/mqslz35J7rHpd3KW7ax xmM6fN4HWcdsrKJ3S8FMNJ/KP5JFjgeRx9lGlsvhz3NtzrRFpu6uZA9jeiN5OA4ff3UmW6DTG31L dLsLm18ch9Qh0wcR9AFQimlkhe10bi1w7EHleue5Vk8fRNUSvZ7OcSFd3WmLjLd/K5+2+8Fn1Rc7 hb6ropHSvPpknHW3tnnsVvrbT6c23t9zuTroZYpHGTpdKHEewAVC6eolheHxOc147FpIK9FTdq2p Z0VE8sjfZziQm6cF1Ntd17Pqypr7bUdFHNM5xZ82Otp4zz5W5tlPYNr7Jca2a5umie4yZklDz9Gg KhUFZPBKHxPcx45Dmkgheqsu9dWR9NRUzSAeHvJCbOC7G3W5tl1rFcLZI4Uk8xeA3q5c13GQT5W0 t0Vm2t03XVVVc5KiMuLx6sgcT/lAVDaS4VNJKJKeV0cg7OaSCF6bhfblXRCOqq5pYxz0ueSE2cV1 dBa+su4NpuNpc/8ABVE3qDo6+el2eQStnbm2vavSVVLcLlJVDqLgZHgl2OwHsqH266VVHMJaWV8U o/xMcQV67lqG6XCIR1tbPMwchr3kgJcrZpJ45vfyuvojWdl3D07cLRFL+DqJA9pZ1ZIDv8QyvdSG g2t0dUyXW5Pq3lxcHSOGXEDgD2CojbbtW2+b1aOolhk/zMcQf5L1XTUd1uUQjr66edg7Ne8n+qvK 60fii62jtU2fcfSNXaaSoNHUlrmloILm5OQ4L2wT0m1mh5HXu4vq5iS7qlPzSOxwFRW1XyutU3rU FTLBIRjqY4gr03jU92u0bGXCtnnY3kCR5dj91ed1pn8M3tdfSuobXuToSotlsqzR1YZ09JOXsIOQ f3XsdXUu2Ogn/wBobjJWVLuolzz88jyOwyqL2bUFys9QZrbVy08hGC6NxBIX1vWqrveSwXOunqQw 5aJHkgKbrfCLtWa7UG5G3j6GxV7qOtYxobz88b2nIP7r1VVypduNAObqO4yVdXIHFznn55HuHIGe +FRuw6outjndLa6yamkcMExuIyFnftVXe+SMdda+eqLPy+o4kBTZxXZoK6l3F29ZBpy5GiroGsLH d3xvb2yPqvtcrvS7daAMOpLi6qrZWu6nH88j3DnGe+FSCwatvGnpnyWqtmpnP7+m4jKNRauvGoZo 5LtXTVL2DDfUcThL37Jjpdp9Q3cPQNO7Sl0/B10AY5jhy5jmjscHjK8+rbnS6D2zlo7/AHB1VXVE T2udgdcj3jk4z7qmendZXvTjnm0V89N1/m6HEArDUmr7xqKdk95rpqp7BhpkdnC1MtWX6Yy8Uyln 2sD8NWir5S6jpdR1FH0WuWF4jl6gSc+cd10vxAadvEmr7VqOkt01VbaCJjqh8RBLA1+Tx37Kt9h3 R1TZLfFQ2+7VENLH+SMOOAvVc93dYXCikpaq81D4JWlr2l3Dge4Wbbbb9uuvX8W71E+r13o+33PQ 1zbBWxOD2OJ5GRhzT7EA/qstTyUln0VSadvdaKmurgKZzgMOkc48nHgKmOltwtQaaZKyz3Canjk5 c1jsAr43fXl9u92juFxr5ZaqLHpvLvy47YVmdkk+mL4pbbfldvVdBc9K6Kjt239oE05BjHQQCzj8 x7ZKgXU+1mq7Hp2fW1yu0LblTAVUkHQetpzyOrOMj7LiI99NZsYG/wAYlOOOSFr9Rbv6rvtpqLdc Lm6Wknb0yMx+YKba4pX2n3M1tqrVdHbxUvqadrmun6Wj5WZ5JUzbpVNxpq/TwiLm2l9Yz8Y/A6QA 4dPUfAyqP6M1nddI3N1bZql0Ez29DiOxC6m/7y6qvlslt9fcTJTSEdTcDnByEx6LjvSx/wAQNm1D daizS6dpamqYzrDzT/4c4wV9d9I5IdjHU9WcTiGFr2uPORjKrxbN99X0FFFTRXD+7iaGt6gCcBc5 rrcu/wCsoYorxWGWKM5awDAz+i6zy6yxtnpynh1LJfbh5/8AeOPuvkVk8knKxA91yvbuSPIT/RBC gyYeVMnw1XihtG41HPcZ2wxPjdEHO7dThgKGgF6qOofDI1zXEEHIKlm2scuN2tj8TGiL3ftSWu52 ikdWU0sLaUGLnod1E5d7N57rf7X7XDQWoLFWz1r5a6qiliqIzjoaenI6SoU03v8Aaosloht7JYZm QjDXSNy7HtlafUO7uob3fae6zVQinp8em2Phox9Pqre2JEyboWK6VW9lBWU1vq5aVrqbMrIXOYMO y7JAwp0u4zqiyAeGzu/9yAqsRfEnqZsYaY6MkDuY+60rN89Qf2mF7c+F0zYzGIi35MH6e61nlzu6 uPWPFLF31bXWTfmWjoX5hrHwwyRnsctAzj3Xw+LNw69PAeHyE/yUE3ncC4XTWTNSvbFHXMeyQBo+ XLe3C9+4+6dx1yKL+JRQRmmLukxtx37rvPJjPJcvjTzzxZccZ8yrJ/DtTTRbW1XqRvY6WWV7A5pB cC0YIUF7SUszt1rWwRSdUNXmUFp+T5vPsvfp/wCIi+Wm0UtCKWjkbTxtiBLcEgDAytJYt5LlZ9ZX TUFPTUpluIAmic3DcjsRjyvDl4uWHF7r5N53NY7dW/363ajt9rsVMKo3OmfB6cmQwOJI6s+CAo10 9spVW3cG2QV8zbhQGJtTU9I6PTdkgt78jPYrXf8AwS13yC630RPjgrxt+Ie7Nvbrj+CpCXQiEx84 IBzldbd48XDHHjdrMfj7PUVc2m/XY55p+l0Yfz0nLS33zgKmG6emZ9JazrqCSN8UDnGWnLnZ6oyT jlFJujcaTX79UxRxCZ8rpDAcluCMEL57l7kTa31HRXaalhgfSxtjaxuS12HZ5yk6xuM+Vxx1lyWS 05DJ/wDA5PjDHeoaGX5cc9yqbVZcakjKsFS/EnWMoGxSWijLg0B3SSA7jHIUAX64tuN3q6yOFkDZ 5XSCKP8AKzJzgfRPF+ni/Gzcd+W+T7S3PtLdKbah+qmXxjoPw4qTRCIjgkZHV1d/0UJzD+8K7CPc bUbdKu08bjIbY5npmE8jp74XHHLjlSOt99MfKsd8IjD/AGhr3BpwKfGcechVyA5+ymvZ3eBmhbFJ bn2uGfqkMglHDznHBP6Ll5vH+SSNYZcZf6sLpe+V1fu5qG31EvXS0TOmJuB8oIacfvlby3f/ABD1 Zj/5bqf/ACBVssW838O19dr+23tdHcBh0Jfy3AAHP6LvtDa31hcKu6Xe2aXnuNkr5nOETXt6WP4D u/daxnHO5M6/WPh8LkLmXq/kjGY4/wB8uXa7V1Ejtx9cwOeTGycODc8AknK6rSlSKe1TXG5WWjsJ IJdG0BryBzk4GD+65XZ6nlqNV6tvcbHG3184NPNjh+Cc4Xbx6mOV+1zsyu/4e1VVPLrnWUMkr3xx ygAOdkA9Tu3txhdLSV8Nu0JcK2rg/EQwPne+LOOoCR3Cj/XW60OjbndbezTgo7g/JFSOlhkzw2Tt 8wOPfwuC0Zvq6gpa6i1FRC5UtQ5zmtLgAOo5cCMHIUt3v+sbSPYd1KKWGobYNI3CUM/3v4c9QHGe SAvv8PNxfW2q/wA3zNj/ABReyMnhmQSQuJdvzZLXaKmn03YI6GeQZaY+lrQ73IA5S0TvvZLLZGU8 tjLKpxLp3QFrBI4k5ceO6zZbpfi/dbK0b2R2+uvVNfaaSaSWVwjfEQGgAdOCP0XXa1jfc9hwaGJ0 zn0sTwyMdRwCCe3sqrbkaht171VVXGzUZoqechxh6sgOxyf1Xb7O7yT6Tifbrsx9baXA9DAfmYfY Z8LpM5jnyjEw/SS+00/DvRzUe29caiGSJs00ssfW3HUwtGHD6KENpKqal3WtzaeV0YmqCyQNOOpu TwV0W5W+LbpZGWzTdO6gpy3pfyMgDsBjsuK2c1tZtK6kmuF9t5rC5g9GVv5oXA5yPuvP5sOfjuOP y9GPk/flUn/Fa7F6srh3FM8g/wDfXZaB1i2+aQjtuqhVWasEYZDVOa+ES8cOYTjJ+ijLeLdDTWsr RT/gaKZlzp5AYpn4yG+R/qttYt59PXXS1Lbta2t1bNAQA5o4IAwHdxg4Vsy3P5HPGSY2Ou17Wal0 jZ4aSadl7sVYRG6rljzJGXHADsHGOxBW13rvFdZdHWue11UtLI+ZrXPid0kjo+i4XVu9djOl3WzT dLNGHDoLKhoc1rceOT9F9KPeLSWodM01FrS2OqJ4jhzA3LCQMBw59lrLdq4ak7+3X1dfPdvh8fcK 17par8IJfUdyeoPGDn3W4t+oqqh2cpr9IRNVw0rX9UnJJyAf5FRnrDd7TTtJwWPTlFJHRFzY5YpG gBsQIJDeTzwt5NvDt/VaZdZpKaqjoXRemYAwYA74HPuphjZjJTPKXep7aDWm6GntQ7V1Npr3SPu5 jbj1GA4eHA5B+yq7UkOlcW9lsL9URPrpvwriYOt3R1d+nPGVqSumnO3ZJIKXdAIH1SITCAz7p9kJ 4QLKYQgBKDlA7ppZyoDymkeyYQPKWUBZYygXdGOE+nIQAgxKSyLUsYV0F4RhZDkJ4QYJhBGEwOUo SQKzwkQoF5R4QRwmG+yDApeV9OlIghUY4Sws+nKMFBh4RhZ9P0R0knsgw7JLMNIR0/ugwIRhZlpC McIMEBZdJTDSgwx7owsy0o6SgwwgrItKRCuwkJ4SRAeyRTSQCXlMhGENjwl3WSWENkUYT8oRS8oT KEQJJpA5KAPHZHc/dBH7IKBFMpIwoHgJcYTQVQk/CX3TQIp+EJKA/mmTwkhA+3KCjj7oPZADnhHl IdvZM90AOUBL+SEDKDyEs8I8IBZAJDt9UvCB+UZR4QgPKEfdA7oDCO36p+UigMfL9UygdsdksoDw jujujHKqjsgpJnsgWOUFH9UygQQO6BlPslAUvKZS/dAxwPuknlBHCiEg/wA0FCKflJCEAUIJTKBe UIPdLHKB+EfZGEBAFLP/ANOFlxjysP1QT+Vh4X0KxK+W9rR6rJFjqyP/AJGQVDcIJI54Uxax4sNX /wDOyoeh8L1+D1XHye3ym/Mfuvm3vyvpP+cr5L0ONM90kIRAhCEAhCEHstlKaythhacGRwaD7ZVx tptu7Vpmxi41cTZ5wwyOcRnsMqoulcC+UZPb1W5/dXvt7gdCTdPzH8M/GOc/KUSo80zrKwal1xK2 O2U0YiOGO9Joc8fXHddpqHbyiueprfd6empWMjGHsbEATnzwqx7XWy4VuswaSQw+k8l7iM+eyupb opIaCFssge7A+btk47JfbMctep7Nb7vR2wW2mdVvZ1hxgb0lo47+62d/goLfBTSR2aknMrg0tbTt J5HhRtcLbcKLeP1K6p9enqGGWDv8gz+TH0Unav1FTadt9NPVxOljc4N6WNy7OOMJotealt2nrlLC YLZQiXqLZIzA0OafYjC0t62tsD77FeKS0wNmb8r4mRgMcPfpAxlefbOKskvlzuVTSzQU9bUyTQeq ADgnOF0x1OyHWk9mmyQYmSADxnPIV0zynW0T/EPZbHZbZZ6+G0UbJWz/ADdMQb1DGcHC3emLLpDc bRgidaKSNz2dPqRwta+N30IGVrPixJ/stbAMnNQf2wvv8LzenTILhgF7/wBl082sfHhZGPDu5Zbq sO5uj59F6mqLVPIJWN+eN47uae2fquR8KaPiieXbiP8ApA0f1UMt8KeXHjlpr/Hzvk8cyre2TSN9 vsJltNqrKuMd3RMJC2DdudWOa4/2fueG98QHhTV8Kd1rDUVFB6h/Ds6S0fc8qeNX6yt2lbhSxXKQ U8NScep9R7rnjvK6jeecw1v5ULp9MXievdQw22tfWM/NAIj1j9F7KzQupqOF8tTYbrFEwFznGndh oHklXShoaDU2paa8aeqPTaWkTTRgAvAPH38rrrc6CpnqaM109W6PLHslaMfbgIcq/PK3aZvF0p3T W22V1VG3u6GFzwP2XwpbDcqurfS09FVy1LDh0TIyXg+xCtfpzU7dN7q3HTlHTtZQvlJjazgNPcj7 cqW6m02u1msv8VDE2qfEZZC1oBeQM9/dayx45aZx8m8eT88q2zV9DWMpa2kqaepcQBHMwscc9uCp Dl2O1e2wuuv4elMDWGQt9cB2AM9sLzbta/rtYambUPaI4qZ2IGgZI59+5XXS7lbgs0k6mdap/wAE 6ItM7qR2C3HJz27K8ZLqkzuWO4gd4LXEHIIOCiM5dhZVLzJM5xx8xyUoR84wsfLpE77FbO/2pa27 XxoFt7siz+f6lTBUbUbb6ho6632Okgjroh0GWGRxcx/2ytz8PzMbaUXuYWrbaHp7BFdqh1jMJqHS v/ElhJJdz3W8ZLja4eTPKeTjPSENvvh+mOoKr+0/S+gpnYYGn/et8E47fZd5cNndvtQ2+uo9Owx0 9wi+X1Y5XO6XfYlS3Q9X8QunfpDWY++Cud0RDY23SWWxyxyTuc78T0PJwecAjx5Uy9tY5XU2grbn 4fpZb3VO1W3NFTuLWsacep/xZC7a7bKaC1Faa6n0uG09yiGGzMmLw148EEqX6Pqc68epkNBwPt0l c7t7btP0VRI7TsjHvkLjVBshd8/1B7FamMstTnluRBO2WwM1TdqmTV8RjpKdxaIwcepjzn2XZ3vY 3RF+sla3R7xDcoshsgnMjQ4eCMqZaIufT3cSfKOpwH26VoNu7dY6CSUWCVkvWC6fpl68P+vss6al qA9rtg5q2uqJ9YxPp6SFxb6TXYL8dzkeF12pth9IXmwVbtFyOjuMWehzpjI0uH+EhTXCeu03cTnp Z1StJ7YbhaTbm2Wi2NmbYpxNDI0PkxL14cVZj1s5d6VB292yrL/rh9juYNIaY5qGnuRnGArA1/w/ 6HkZLQUpq4bn6XU0mckAngHH3Xv2/dZ37talEjZTdxL8pB+UM/8At5Wp+I/UUGm6ilq7fV1dLqAs xE6P8hZnnK6XxTncZ8Oc836zL7Qno/aWpu24lTp2qqWCOif/AH0jM5e0HHH1U23b4etGT09RQ22e rguzIutpfN1AE9iR7ZWr+GK40F4utyrq6Wol1DK4uke4/KWnsf6r3fEbqWLTN2pK2011VS6g9MMw wAxujye/1WJjM703n5LhjN+6hbQG1FVfdfVdgrpmsjoHkVLmHBcAccKaL38Oek56KrpbJWVlPd44 w5vqzdbQT2y3HYr5fC/V267Vl1udRNPLqGd5M5cR0lueDhejf3UkemtS0tbZq+pgvr2NjljaAY3R HOCfrlYwlzt0uWfCTbidtPh+dXT1s+spJKajgc6NrYX9JeR/iyfC9e5fw/0VNp43TQ9VUVbocmWC Vwf1t/4SPKnuqiZcdu4oq6VzGVULGyyB3SfmIyc+O6y0VZqPT1kraC2zyT0kbi5j3vDzyORkJprd Vs2k2IN/oZLnq51TQUOP7tjSGP8Auchevc/YCC1WJt30bU1VfDHkzQyEPd0+7cD+SsJfKZlw2/hp aqZ0UVUI45HtOCA5wzyvpo21QWHTddb6OpkqqandJ6ckjg44xnGfOFdM7qtu1Owpv1tkumqpamgo nDMTGENeR/mOQjdfYMWGysvOkamquVG0ZnikAc9rf8zekc/UYVj77QsvGg6ShqJpIYqsRRySMd0u AJ5wV9NLWxli0hXUFPPLURUxlbHJKQXFvTkZKLuq1bWbBO1DaHXTVFRU26le3qhbGGh5Hu4OC827 WxUmmbdFddM1FRc7bjMoc0GRn/EOkcj9FZPU1sbfNG223y1UtJHUmJr5InBrsEdgfqvtYKAWvQtb QCaSdlMJo2SS8uIAOMq6nVY53dit22GwEuoLO+6anq6i2U7x1QtY0dZHkuDhwFq93djarSMMNxsc 81ztTmjre5o62H3w3uFZ/WNn/jun7Ta3Vk1GyocxrpISA7HQThY26kfbduKqjmndUupWyxiWQcu6 ScEpqbk+1mdu/wCK7bafD9Nf7I+6alrZ7VC8AwtYwF2PdwK0G7my1fop0NVbpZLnaJQB64YA5j/Y geD4KtVrmzO1BZ7XahXT0LKgtDpYMdXDSccpR076PbaSmqZfxb6eN0fqSN/P0uwDj9FqYS6/qfku 6rptx8PdTfrG656jrpLVG/BhY2MOd0+7s9lzG7+zlx0HNDUU8j7laJsNbUiPBa8/4XAZ/Qq2W4dp nvtBabVT11RQRzucXyU4+b5WZAx7ZTnikh27ggq5PxMsfTE6R7eXkPAzhYk3W+Wlcdvfh5rL9Yf4 pfrkbSyTBhj9MPJb7uyRhcXvFtNc9vKmJ75DW2uYYjq2s6QHf5XDJwrfbn2mpvcNstdHcJrex7nv e6FuS4NbkDH3Wm3Np3O2GuUde78RNFR4dI8ZJcDjPKcbrZPJLbPpQk5HdYOJz3X0qBiQ4918ll0P KAeVihBn1LJvzdhlfMLr9s6azVOrbfHqOKSW2OeGytjd0k57cpbrukm+o5j0nkfkIXSaC0pJqvUl JaW1kFCagketOCWt4z4Vs59idv6Rz7nPHUMtr4WlsLqgjpdycg/UY4XD7p7WW7R1TZr7peR8VBJN HHJBK8ucCTkOB+3cLNt47xizW9VH+6Wx9z0HYYrtPc6Sup3SCMtiY5jm5HB5JyFELonA4xlfoprK z2LUGm7fbNSvc2mncwMIf0fP08cquV52itWk9xaaLUwml0pWOcIaiJ5Ba4jhrj9FMct4y/afOldw x3+XCWHA8NIVq9SfDjR1mobbLpir9OxTtzN1vL3MxzkO+vb6Li9/NC6N0ZT2+m07POboX/7RFJL6 g6CO/wBDlbnZuIKDXD6fqgkjgqwuwN70PbNPXeDVUFGauRwLHzwB5LcYwCRwoK1H+HN4rTQgCm9V xjx26cnCsm8bklusuLwNdgL10FPNVVEcNOx8ksjg1jGjJcT4C8LOSFYb4S7XSVesameqp45Xw0/V GXtB6XZ7j6rGWUxnbeM210Hw7azltUdY38B1Pi9T0HSuEg4z0kdPdRTLYq9l0NvfTTCu9T0jTlp6 +vtjCuzda3U410ytpqin/gdPVtonw5PqfN084xgjJ91vZ9OWf/tHhuZt8H499K5xl6ectcAD98Hu t3HTM2q3/wDA860FqFYyOjeTF6noeqRIOM4wR3+ii4WWudcfwIppjWep6XodJ6+vOOnHurtNuOpX 6+FX61N/A21ptxiGQ8cA9RHY8nGcrcR6as43PluQt8ArvwjZDKG89XWR1ffCkWKsT7B62hs7q51L TOa2P1fRZNmTGM4xjuo0p7NXVNe2jgglfVOd6YiDT1dXkYV2LfedSS7jl8rqf+ByVElE1gJ6x0DI cRjyeM5W1tumbPTboXC4Q0EDKo0ccvqBvIcXOBI+pASyy6qTKWbiqt02K1rb7LLcpqGJ8UcfqOZF MHvx/wAoCju32irr62KipIZJamR3Q2Noy4lXdsV31LNuAJa5kAsNa6WmhDXZIMWTkjwSc/svbYdJ WS27k3m50lBDHUugif1Aflc4u6iB4zhTV3ol62qpeNk9bWizT3GqtjDSwN63iKdr3dPv0jkrgLZZ K26XGGjt8L56mZwaxjRyf+gV3NMXjUlRrXN0ipxZa8ywwhjs49LPJHjP+i9WktI2O0621DXW+gih qGOYWuHZpc0l2B4C1cfbWqqfftl9aWK0T3K4WsfhYB1PMcoe4D3wOVxdoslbd7jBQ2+B01TO4NYx vnPv7BXc0bd9S1up5I7/AE1MLXcIXvp+h3Vw045HjIK+miNI2Ow37UdZbqCOOojly09+kFgdgDwM qa+SKl6l2k1dpq3yV10tL2UrPzSMeHhv1OPC5ay2StvF0p7fb4XT1U7g2NgIGT9/Cuxoa8X27Xar otT0kJt9wpjU04B6mlp4Lf28LPb/AEnZdMDUddbaJgljqZWAu5PS0Bwb9uVJ3Vylx9qm6o211TpS iFderVLBSBwaZWuD2tJ7Zx2W7211drKiMVi0rPM8yvL2QNaDye554Cstoa5Xi/1F0tWr7dCKWrgF VFGSHgxPJHT/AC/TK+OgdL2XRds1JcrTR/38NRO0Fx6j0MGQ37K63dRN2e0I7l3Hcmnskf8Aa2Kp hoHvAD8NwHexLTwtXtzrbXEbYrDpiWec5dJHA1gcR5PJPZWI0fW3HVUd5smtbZC2OWNtRHH1dYMU hIAz9MLy6E01aNEaVvF2s9IX1jHTYMruouDHENbnx7LOP7elss6Vy3cg1rVzU1z1pRVELiz0IpJG NbwDnHGfcrg9P6dut9uLaG00k1XVvaXCKPGcAcq6OnKir1xar3Y9b2lsLoy1wjPJDH5LSD7j3C8m jLFadBaFrbvaaH1q0FwLpDl7yHlgAPha1rtnSo+o9HX/AEyyF19tlXRNlJDDM3hxHsQV5bBp263+ tNLZqOerqMdRjiGSArm2aN+v9LXaza1tfpVFM/ocHfmaSMtc0+445HdebSFmtu3+3LrpZ6D8RWyN aSXOHW9znBgw7HHcKS7m4ulP9S6Qvem5YWXu3VNE+YF0YlGOrHfBXw0/pu732olhs9DU1k0bep7I G9RA91c6lo4tx9C11Dq62GKuo3vicXfnY9oyHA+O4+6+GlLVQbfbdUtZYrc6prqtrM4x6kj3jA59 s+FZN9Fmrqqd3/Td4sM8dPeaGqoppGdbWzNwSO2QlYNOXa+yzRWagqa2WJoc8QM6i37q4dXbqTcz buok1HQuprpQOkic8jD2SMAJx7A57L0WS20e3mgaV2nbY+orq3p7H53yOGck+QMdkk33DSmF4sdz s1SKe6UdTR1Jb1COeMsJGe4B8cL6WWw3a8umZaqGqrHxAOkEEZd0Z7Zx2VvNSWWi3P22FwvVG+iu tE14D+nD2OZ+Zp+h9l7oKKk210dSU+l7W+pra04aWgGR7unqJP8AmwAVrjb6TK8ZuqW3i1XG1VX4 e5UtTSTgB3pzsLHYPnB8LC2UVbcqxlLQ089RUPBLYomlziAMngK3u5dkt24G1v8AaKspXUlzpIHS scAOoFpw5jvpkH7LXfDlbtJUNHBNQ1DZdRVDD6rJcF8ZA5DeOG4XK5am117/AIqjcaart9S+nrIZ YJ2cOZI0tc37grwPmkxjP6qa/ihja7cKoIA6vSjBOMeMqEH8FejPx8LJ9uXj8n5JuMXEk88pErF3 fhCw2eclJCZ5UDasuFudHabr9U3yntVrbG+rn6i0SPDW8Ak8qQY9h9ayXCWjNvgbJFG2Qu9Zpa4H I4Pk8KbXSJQFlwB9V2uoNuNQ6fvNPa7hbn/i6jHpCL5w/P1HsupZsDriRnV/C6fnkH8Sz/qmzSIP 2QApAi2o1RLqZ1gbbQy5NYZOiSQNaWjnIceD+i1lw0HfbfqAWWrt8sdxLwxseOHZ7EHsR9UTTksB Y/ouz1lt9fdHvp236hdTtmz0PBDmux4yPK7HbLZiXW2lKm9RXeOmMUj2CAwdZPSM98jGUXV1tDiA F67jSupap8TgMtcQf0XmHhXSEAT4XobASOxUq/D/ALd02ttQTOuEmKKhDZZIhwZckgDPjkKx76vR d3vtRox1tpeqSF0RcIWh5e0kFucZyAM5TW5sUa9B+efCZgcOMK0Vj2HpI9w6inuFQJbRTsbURxjh zw4kAE/Qhd9NHoXUd1rdIfw2iEr4iwSxwNY8ObnIDsZBGAcqSVVHDE7ng8fRZCmeR2VntJbFQxa5 qo7vPHPbaF7ZAxuQ6UHlpdx9OQu/dQaD1dXXPTcVroo6gxgtmipwx/1IOMjBCb11TSkAgk9kGB3n Cs7ofY+Jmr63+OSxT0FvlwI2nl5wHNcRjkY8ZXdPse3+uW3SxW63UdNVxNyyaCEMd/zDA8HuFN69 lxqk/ouznkrJsLj2wSPAOVZrbvZCEakrptQyRSUltmLBE3n1HAB2XAjluD2Xa1Gl9A6/prlarPRU lFX0xPpzU0YYT7O4HIzwQr/U+dKYiN3+UodA454OFZnbTZanN5r6vU5Y+ktk7o/SBy2RzQCS4Y5b grsrhofQuvbXcLfp6kpaC4UjiYpqdgb1Y7E+7T2RVMhG4/4f3WRheD+VWZ2p2Yp23WuuOrI4ZKCg e+MQ5y17m/mLh7Adl1V22+0RreyV9LpOmpaK40Uh6XQjhx8Z92lBTsMcezSUOgd36SrM7WbLwx1t RddYRQOt1KXtEHV1NeRkOLvYBdLfts9Gay0/Vf2Jggo7jRvcOmMnDyPBz4PgoaU/DHEflP2T9J+P mYQrM7VbL0oL7zq9kf4GIOAp3EEO7gl2O2Cug1LtXpLWGmZqnREMVHcKZxyxriQ8j/Ccnj6FN6RU VrHHs0rIxvAyWEKzG1GzNGIJb3rJsYomA9ED3DpI7ZJB4IK3WrtptM6p0x/EdDRx01TAHdULXEiT HcHJ4Psm1ssVMEbnDhpSdGW92qzm1OzNCKCa8a2hjbROb/dQufgdP+YuB4OeML3642f09f8ATDLr oKNkb4mkvhDurrx38nBCqKphpPjKbo3DktIVm9qdlLd/CJb1rRjfw0jcxw9fT0t8OLh79sL76/2c stx09De9BtBiYw+pB1l5cB3OT2I9kFXRGT/hKTo3N/wlWc2w2Xtws0941xGGQSNzFB6nQWt79XUO 5PsluNszaaiwwXvQmZKVrMzQ+p1kj3B9x5CaP4rGGk+CUOjLcFwIVm9tNkbcLPU3XXAkiiLf7mBr +ggAZ6s+cjwvlubsxbmWaC9aJD56EMBli6+t3/MCf5hD+K0sY4nAaSgscOC0hWa222Qtxs1Rctci WBrx/dwteWOYBzn65C8W6ey1LbrdDdtIGSqtpaDIwu63N+oPsgriI3HgNKxdGW9wQrO7fbHW5tjn uWuxJA1zQ6OOOUsdGPOeOcjnjK027uykVkoG3bS7pKu1Fgc/J63M+uR3H1RL0ruRgpL01cDoZCx4 w4LznKoxTSKDz2QB+mEEpgc5SIQHlJNBRSTR5QgEk0IgSTQgWOUwjwkgaWE0IEhBQeEB9Sl3Qnjl QJMI8Jdz3QMYCEAIBQHZLym5JFMhAR/omT9EQkYGUxn2RhAsJDlZI5QLlHZB7p4CBZ5T8oR3CAKD 2R2QikgcJpBUB7I7J4SwVECEYQqpY55TQmgWEk0IAJeU+ySB9kZykhQGUyllCAQUfdBOEDQEJFAf zR2KM4IT5QLPfCEeUkDTwfol3KMFBP6wcF9CFi4L5j2ud1pxYqz/AJFEEPYKXNd8WKq+rR/VRHF4 98L1eH04eT2+M3Ll819JfzH7r5r0ONCEykgEIQgEIQg9NHO6CZr2EgtOQQrD7W71wWqhbSX7rcxg wCBnIVcB3Wwt1BWVbiKSmnncO4ijc8/yQWbtW6eg6HUs9dRUktP6x6pCWjBd7hO674Wir1bTS0r6 llBGzpdkcZ9+FWllquD53xNoqp0rPzMETi5v3GMr5ikqxUegYJRN/k6D1fsjOlw6reTQ9dUU0lQZ TJFz1lnI+x7r3V+7u39yZCKyaV4iIcwOHYhU4FpuRf0fgqvq9jC7P9FkbTcW/moqr/8AAv8A+iGl xn726LbPCI55WsjyRiPjlcHVbr6bm3O/izJZRRmFsRe5uOQq3mhrnFwFNOcdwI3cfyXmZFK6Qxhr i/8Ayhpz+yu04y+1l95NydJasp7XRxTTSxwzdcpa3jpIAW9h3b0ZpXSXo2HL6pseGRhuecKpj45A /pLSHf5SCCsZY5GcSBzfuCFeVskvwTCTevlttZajrNT3qe4XB5dJITgZyGjwAtC08hDgQcJFS227 rWOMxmp6WI+HjUulNOUzpbtXPgrXH5sjjvxhb/f/AFdozVFha+ju0r7nTnqp2RtBa4nv1fTCq017 28tWRke7GUls9M5YTLW1ldgd1bXY6L+G3qQQBp+WU8ggqWKTcjQ1BcKiop7yC6pdl4IyBn2Kok0k Hglff1H4/MFFsXFp79tpHrCt1A67tkqZzk+oOGn/AIVsaHevS1xudXQVNRGygDehr356XjzwqTmV /Azk/dYerIPbCb+U4/CTd349LW7WMVbo+r/EU73erJB04bG4HOGn2Kkep3/tcmi5LZ/CpXVEkJjI 6wG5IxlVmkc4kZKwycck8rXK+1mM1pnO7qlJaAMk8IjcGvBK+Z5THfnsstLKfD7u3T2iCOyXuRsd OB0xyngAexUuO1hoLSUFwultrqV803zmKNxJLue33VFmPLR8vH1X2fJK6MdRyPuruyM3GZXfytrt 1vvS3G/VdPfOingnf/cvPA6fAP1XZP1RobRVHcbna6ymdNNmQxMkyS76KizHvBz2+q+j5JHN5dn9 cqWpMJFu9tN8aK83WtpL96dMyZxMbyQAW9sH6rqXak0LoC2XCvtddTyPmcZPRjlyS4+yovG+Qct4 K+kksz2jrJP0JV2cFwds967dfqyst99dHTes53Q4/KHNPGCffC6M6h0TtxY66qtldDM+VxkETZep xcewVGYpXtcS04PvlZzTzvb8zs/rlNnFcjbTeK16mNba746KmM5fg56Wua7gj7rey33R+2GmKyW2 VkU7nOL2xNm63EnsFRWOaZh6mHB+i+0tTPI0eo8kexKS04rWbFXCiu+qrtqy43Sjp6iocWGmLukg Zznlar4raOiuUVLeKO7UcphAjNO2QF557hVogq54s+k8tP0JCVRU1Eo/vXOdj3JK3PLZlcvtj8M1 JPhZj4U6CjohVXiputJG9/8AdGne7DgAe5Xw+LK3U9XVUl6pLnRSt6WwmBsgL+CeR+6rjTVtRCD6 Mj2A9+kkZSq6uomx6z3Px26iThYxvHevlvLCZa/i0HwoW6moaWqvFRc6RvrD0/Qc/Dm4PcrWfFJQ MZfKS/wV9HNDI1sHpMkBeCOc49lXOkuFVT5FPK9mf8riFjV1tVUkGole/HbqJOFccrjvSZeOZWb+ F09s9cWXcLRL7Fcp20lU2ERPAeG8AcOBK2lzv1g2o0QaeGtFZM4u9NrpOp0jz5ODwFRmhrqmlk66 eR8bvdjiCvpXXKrqyDUTySY7dTicLMrdi7GjdXWPc3Rc9mqJxRVHR0PY1/SW45BBK9N71BZNqNCC j/FfjahwcI2OkBMjyOScdgqOUVxqqVxfTyvjefLSQf5JV10rKwg1U8kjh263E/1V2nFd/S2o7Luh oKS1Gp/BVDWBrmNkwWFv5SD919dRajs21ug47e+qNZUOYWNa54Lnud3JIVH7dda2hJfSTyxOPBLH Ef0SuV3ra54dV1EsxHbrcT/VNpxXdst0s+6mgG0VNWuoqqINy2N+HMc3t+iNWaltG2WhYrVPUOra l8ZYGuflzi7uSVSW23mut+TR1EsBd36HEZ/ZYXO7V1xkD6yolmcBgGRxKsy+2b4/peCmrLXuvoSK K3XB9FVw9DvkcOqNzR/Qr5631NZ9utDw2eed1XUvj6A1zh1Oz3cSFSi13y42zJoaqWAnv6biM/sv ncr1XXKb1K+plneOAXuJwnK9Unjk3/V5HzUO62iac2W5Po6uEtcPTI6mOHGD9CF5dfantO32jaax 1FQ6rqjGGBpcOsgnJcVS206judq6xb6yaAP7iNxGf2Xnud5rrlN61dUSTS4x1SOJOFZ5L1/C+OLz 3M0+6WjqKo07dH0dTC9r8xuw5nhzT+mV5twtV2bQWlqOy1VQ+qqAGgDI6yA4HqKpbZ9U3i0RvZba 6enY45cI3kArx3W+V91qTPcKiWeXGOp7iThZ21xXp1BCNzdM26v0td5KOohf1Exuw4B2A5pI7cZX N79altWldspdMvqDUV89OIGN/wAWP8zlUuxazvdjgfFbLhPBG45LWPIC1l9vVfeKl1TcKiSed3Bd I4kpsmM3tq5zl5wfK+SyP1WKjYQhCBhdfttaay+aooKG2xerUySgtbkDgHJXILa6evVZY7jDXW6d 8FTEcskYcEKZTlNLLq7i8u+Nuucm14bbInvqKUMkkDDyGtHJ+qrE3cC/aiqLZbLpcZJ6SOePpjd2 4cMLXV28er62ilpprxUOjkaWOHV3B4K4SCqfFOySNxa9py0juCtb/wCOYMY48c7l9r67s2O5XvTV mitFM6okiqopHtaQCGgcnla7fmyVuorLZLRaQyS4vqQ4MLgCGhp6nfYKsVPvXrKGBkYvEoawBref Za+fdXU819huzrpM6uhb0Mkz2b7Lnw6k+mp1tdzTjKbS9js1grq+J1aY/TaScdRHPYqoe/ujrxpr Vk9VcOqWhrJC+nqBnpOeS36ELkr1uBfr3dorjcK+SSqiA6H5x049k9Y7jX/VtDT0l7rXVENO7qja 7HBxjK3j+mPGM3GXLnUp7D7eaU1Zpa51WoJpBWRSFrOio9Ppbjg488qCL/StorrV0zHF7IpXMDj5 AKwpblVUoIp53xg9+lxGV45ZTK8ucck8klWaksW7t38MWDJ5Kn/4VL/b7RqyaK4TNidUxenGXdi7 KgAZyvXRVclLMx8Ti1zTlrgcEFYyxmXVal0vjV2DU7twHPgqIDp2eWOtcD36mkZb278A5Wxm1bZv +0aC3urYxUNgdFgnjrLgcZ/RVUo99tYU1sZRMrwY2R+mHFoJxjHf3Ufvv1W+uNY+d5qS7q9TqOcr Vtou3T2HUse4EwL6Y6edUCvyR83UcDpBx3+UFbOLU1pduXJQisjFQaUQ9JPd4eTj74VWYt+dXNtb aP8AGMIEfp9ZaOrGMZz7qO2agrRcvxgnf6/V1+p1HOfdSbNrrWezaki3FqmVRhbYYpnV0T+nl5fx 0h307kfVbWh1DaptzK6hjrInVP4OOLozz1Nc4kffkKr0u/WrZLSaN1VCW+n6Zf0fMRjGc+6juk1J W09zbXx1MgqQ/wBT1Mnq6vdW21mYyTUXN03bNUQa8dTXFkIsVFJJVQy45f6gcA0H3BJyPqt3aL9b KrX93ooayJ85giYGA89TS7qH3CrDW7+6oq7TJQumgAfH0GQM+b7591HFt1RcbfdmXClqXsqmP9QS dXJOfKcu7VkXM0lQanj1g+C7U8DLRbpZpIZm8F4kzj74W503ebbW6t1DS0lZFLUSem4MB54YQf2K rLdfiB1PX2iWie+CN0rel0kbcOH2UdWfWFytV4juVHUvZVMd1h+eT7g/ROTXv2uJt/TanGopYr7T QR0FrEkUUo4c8OwR9xjyt3pm6UFyvGpKWjq4pKh8mQ0HnHQB/VVovXxAalutpmoiaaD1m4MsYIe0 fRR9pzWtysF8iudDUubOx3USScO+hTe/ZFvts4dQ/wAQl/tDSQ09La4n0cMgOHPwQSSPbGOVudKV 9JdKXUtLb6mKed1XMQGuzw5oAP7qteo/iB1BeLRNRdMFP6owZIQQ4Dzgrg9H67ummbyy422oLZQc va4ktkHkOCk69GVuXa3W14v76urqtR0cNLFQw/gWOaSC7oOS77c91sLLNDedO6pprVPFPUSVNT0t Dh3cMNz9Cq5at38vt8tEtCxkNIJfzPiyDjyFxmhtxbppO9CuoZsk8SxvJLZB7FWWS7iXd9rabaS3 msqa26X+jiomQwNomkOwT6bjlxHjuvvb5W3nQN6p7PJHU1fXUAMa7/EXkt/fhV51nvxd7/aHUUMM VF1n53QkguHkLkdvtzbpo+8GrpZPVY8Ylheflf8AdTG69LcqtjtzVXSsZcLzqCiZb+uOOBuTjIjJ Bcc9uT/JLBuu2NdDZzHV1THPc2NjgcuEvVj9lX3XW+111LZxQRU8VExx/vHQuOXj2K5vbbdK5aNu L5aciamkBEkDyelx8FXK7mqS1bDQdfXXC3XO93yhbbDUhuA52A5rQR1HPY+F5Kl8tbtIx9naysnh ZHI2Njgc9EgcR+wVf9f75XLU9nFvhgjo4XH+89Mn5x7H9Vpdst2bloqpka0CqoZcl9O8/L1Y7j2U xuuoWrR6Cqqmq07dLvcqQW9lc907GOfkdPQGg5PvheO8y1X/AGYWmts8IrJKL0J3Rt5y1hy4cKAd xN76/UlrZQUULKCm/wDaNjd+YdwPotfthvHcdHiaCRorKCT5vRkJw13uFqZWXdS9rK6RmqJ9D3q4 V1L+AdXSz1EcTnZ+V0Y6Tn64RqmtnptBWm622m/GtozDM5jD/hAw4qvO4u9FXqeiio6GBtBStADo 43cHB4+y+W2e89ZpSkmoK2EXCgePlikd+Qnv+imN4xZlr0sZaZpn7eXWprac0U1V+ImEMjhkBwyO fPdfPXVymtFhsF6paN9fFRvD5GRH/C6Isznny5V63O3mqdV08VLRwijo2gZjDs5PPK9O2e9tTpy2 S227QC5UJGI2Pfgs9x2OR9FrnWc5zmqna4iWHZi6GsgdSzSU8zzDIRlvU4nH81B/w3uP/afE3qy3 0Jj/AO5Ws3V3hqNXiKlpGupaFoHVEHZy76lb3bneaxacslHBLp2nNxgZ6bqmINa949y7GVwzmdkn 9dJZ3k0nxMNP9v6vJ49OMd/+EKD5O+O6sPubuxprVum7hSnT8TLlUNaI6o9LnsLSDnqxnsMKvM2C 847L1+Tyfksry+Dx/jx4vkfKQQe6Fydj7LIeFj5WY7IOg0bVz0N9oaijkfFOyZnS5pweSArrbqam qtN6No6umPzzObG9w/NjGeD+iprtlebZYdW0Vfe6EV1DGT1xH3I4P6HlWD15vBpDU+kqq2Poagud GRC52P7t+OCPsuVxv5OTtc5wknt2WmdwrPrbVWnYKCKZtXT+q+T1WjgekQcH7rk99NZ3vT+smxWq tmhibFG/02OIBP1A75UDaE1jUaT1XS3aj6XuhcWuY7s5hGHD9lP1duxt3eqyC5XSzSy3CMNw97Qe kjkc5/0XWeq57724rVO69/udXap5qAW+40Ty+OURuY94IwW4PcH2VlrD03mz2u9V1I1lxNP1EFuC 0kcjH38KDb5u9pa9aut890tvr2uka50bjGPUY8jjnPIyAsr3v4xupaWa2tJtcRw5jm4c5p7555x4 WZOy2aRrvLrC5aluz4q4lkdPI5rYecMPY8HsvVtbR7hR6Xq6/SRnbaOp/qAStALmj5iGnnss99dU 6U1RV09y09C+KvdkVLi0ASdsE/VePbbeGu0Vp+os8dJT1NJI90jS/ILS4cq/Ky6mkW3mSV9a8zAh +T1Z8FeMDkfde27VX4yskmAA6nErxAk4VrKznwf9Jrr+Qf8A2EQ/905d7Yrlb6nXlNbhGW3WmulV I7LP8BYec/sFV/a3XVfoe+srqF3VE7DZ4Sflkb7Ky8e72hyZr1TN9K8yU4aQY+XEcgH354yrMuMs +yzd2kyLnWVV7igiH/1yRR/p26Wqr1pa6CNgbeKSsq/VJjw7oLXY+b257KJKXeu5Q61/i8jjJTOP pvgzx6WScD7ZJUqS7q6Hp21d4t/SbpLGD0mPBc4DH6HnupMtTSTekg24H+1F9J/+RwY/8JXGaLuN lrNS2uKhjibdIGTsqCIulxGPLvPKiOyb019HrF9xqj61HMRHLD/wAnGPqMqTpdydCWyO4XWymJ1y qAH9Jj6S52McHuFnK7b3p3lqGNQ6kP0i/f01xu3tTZ6zUls/hoibXwUMkdX0x9Ls9Qxn3UWaZ3rr KDVstVcHCegqXBs0eOWjsCPqApKO4ehLDR3K5WB8Tq2oJlMYj6S5xABAPgecK27WZadzZR/f6pPn 8U4f/W2rk9uJbHU6hoX2aOFlUy3FlUGM6T1B3HV7n6qMNF71SUOqKl92d6tBWyZmGPyHt1D9FIUu vdDaaobjXadfDJWVD3SlrW9JJIAwDjgecJlqzVZnWW3ZW7/1LV5A/wDjub/7G1aXbiWy1F/MljbT sP8ADYxO2FgbhwefzY8qL9v95W0moKuK/Fslvr5S6R4H+7ccDJHkYC7mbXGitJ2u4VGnJqeaqqHu fhowQT4z7D2S6sn8J1t19F0jTmqCcdAnqc57Y6VqNvTY3ahqJNOCnbG+3xGdsIwBJ1HOR4OFGm3W 8VPHe62i1EWuttwkc5z8cRuI5yPYhdlPrPR2jLJVS6Zlpp6id7nZZw4Z5GT5AVuW6ldazA0HeDIA W9dR1Z9us5/kvHt1DZI7xcX6dMX4SSnic9sZOGv5yOeyjPbbd6jkr6u06lew2+sc9zXuAwwu5IP0 K6+t1dpHRGnp5NMzwT1MxI+V+XDyC7PcDsm+27k6GrAG2t06vydUuc+3qnP8kbfU1opq29HT74jR SMidiNxIa7pPUPoo4233at1wkqrHqd0Qo6jq6JHcNGeS0/RdPcNW6T0NpeZumqinnqZjjLHAku93 fpws3tnf7Wt/Xemdqqn1cCPo+fPbp9UZ/kvltxS2+ldfm2d8LqRzmuHov62tcY+QCuF233QtN3pa nTmp3RRU8ocIpXcNIPJafY57LoK/VOl9BaTkhsFRDU1Ugx1sId1u/wAz+fZPjTW+q3d69Nu0kYqC PSMcYeSfHqDP8k9s6Wjo6S/R250TqYzlzfTk9RoywcArhtutx7NqKzT6Y1Q+KKNzC2KQnDXN74Ps QfK39x1PpzbzSP4Sy1MNVPICetrgfUee7nc8HC68pw467cMcbMt7603l1ZTO20trK4gUrjC2Ungd PVysdCUdFb7JqWntTxJQtq5fSLX9YA6BwD5XHbea+smq9O1Gm9RyxQFrMRyOPSHN7g59wVtLxqTT 23ukzb7NNBVSzNLnFruoPceCTg8FYlbsum/1BBTT6Bs8Ne7FK50DZCXdPynvz4Xz0jQUts01qakt 7i6jiqJxF83VhvQOM+Vy+hta2TW2lZ9PX6aGlnjZ0tcXdIc0flIz5C99/wBQWHb/AEl/DrRLDPJO 0l2H9TXOIw4nnhbuXqE6dJqemo6rStjp7k7po5HxNkPX0cdB8+OV8dNUUFBou+UlI8vpoZahsZ6u rjuOfK5bSOrLJuJpKWx3qaGjradoAJeGtcBw1zc9/svZqfUdj0FpUWq2vjmfMxxIEnWORgnP38LH /ltfdb/VVHS3Gw6eo7k8spJpWNkd19HHpnHP3wvnYaRlv21rqOJ5kigdNGxxOT0h/HK5zTOprJuT o91ouNRFQ3Cma3BLw0HHAcM/zC9Wr9R2bQ2kWWahcyV8jScep1gZOSc/dWNWzbe62oaS50GnaK5S OjpJ5g2Qh/Qf92SOfuvFQUoo9prnRCV0scDJ4mPfyS0OOFq7XfbHujpI2+pqWUVwpuk4c/pwRwHD 3BHH6pa71DZdD6M/gVE4TCWJzQPU6sA5yc+eVnvnjfiOdn65z5qoGqImtr3ccrn38Ld3+pbU1Uj2 9ieFpXLpnd5WxMJrGSvmUspnujCypZTSTQGEiml5QCEIRSR4TQiEO/KaSaAR5RlJAIwmUs8IBBRl HlAsc+UYTHdBKgM8JJpIMu/hIoBSQPwkn5SHKKEBCaAz2TPZId8Jk8IgwkOEBNAsppJlAgclMlH8 kFAFJPsjuqpJ/ZCEATwg9kIRGJKaZSOUUI7JjtlJAI7hCCgXZPPugp90C8pFHYo7lAIQmoEmkeyE AeCj39kIQBQO/wBEfZCAKE0cZ+qDH+aOfdMpILArErJJwyvmva5jXbv/AEBU5z+UKJYTyCOwUr7g HFgnae5xj91FEPuOOF6vF/q4Z+3wm/OfusAs5vzn7rALu40kJlJAIQhAIQhBtLBb/wCJXSmpurpE rw3PtlXR0Ppe1aF0g+4RwdckcRe4jguIHuqg7fkDU9B1HDfVCupf2vqNtattODI8078NYMk8Lfix mWcxvpx/yM7h47lj7cTtxuLTas1TUSy07InA4jBAz0+PupCuWiKav1XT3w+lxGGlvQMj658qsex1 jra7VfWwywtpzh+GkHOexVxqeNsFJFAZwXY/VZzmstRrC7xc1cr3DFqmls8MAMrYhK6QgYIPGFuL 9Vz0MlGKWjZP6pcJAGjIAAP+qiy2WaptG79d+IqZKmKeMSxPe0jAcfy9/CkbXOpzpyCixSyVbqpz oxFH3JAH/VZXb10FRb7tUwmmZEXNL2yt6RlpA7H9VrK/QVtOo473S0UTavhsgDQA4e/3Wr2stddR vqZ66EQCrmlljj6gS1pOQD9cLa2rVIfrO42d7SfTLSR4GRwQtTG2W/TGWcmUxvuoz+JKSjsztPVj aOB0jJ3l392AXAAcFdbYaWw7laHFPVUUXpTR4DmsAcw47g/RcJ8Wx/2ayMGc+o8/yC6/4cYXwaPp fVaW5a7GfK15seOONnyn+Pnc+XJUrcfS7tJaprLT6wmZEcsfjHynsuVAyFKfxGYG5dwx26WhRdHx ha8+Mxz1F/x8rl45cnW6Z261PqSjNTZrVNUw4yHAgZ+2Vt2bPa4fGXt0/VO6TggObn+ql/4VK+on jnpXyOMMTmhrSeACpb1tuBbtKahp6O6Ex00reoOa3nOey5443PevhvPOY638qSUunLnFf222S3TG ujfh1M5vPB7H6K6u3enaSXTFPHdtNUVNKIxlslO1x/fC2enYLBqS6C/W+lY5zmDEjmAE8rbafuct ymuPUGtZBK6JoHsDhNMZ5aine4O296uGsrzNpqxTy0LZ3YbTsAa3nwFwlu0Zf7nXzUdDaqyaqhd0 yRtZ8zT7FWe0XrOsg3RvVmeOulfUSOZ/wYPZS5qMUmnbNcb5S0cX4oRGV2G46iBnldM8b+Tiz4/L J4ZnVALhpO7228QWu5UNRR1sxaGxzt6ScnAP2UiXbYHUdu0xLenVlA+OKMyPhyQ4ADJwcYXL621n eNWaqbcKh7zUMeBA1vJZzwAu8vl+3SOjZG11FXNtRjxJKYeOnHOVjWrquu9zcQM4YKcY6ndkSnqe TlfSmHzrLay+wWztJX0kd+1HGyaAt644XDLen3IUmTaH291xa6+htFsooJGksE9NEGPa4exC3uzo DNtaPq7Clbn/AMK9WgZ7HPOf4A2FpY54n9NnTl3ufdbwkuNrjnlZnJL0ifbTYOlt91qqrVAirIad 59NhGWlo5BcPddZX7ebfa4s9fS2Kgo6aojJa2emZ0uY8KTbeSILs+UHp6nHn26Votv5LHI9x0+yJ sYDhN0Mxl/HJ9yplO2sbdIj2v2FprfWVVZqwRVMUDnBsfdpaPJC6e6bYaC1xYqtmmaOlo6pmRHUU 7cYcPcdsKUac9NsvD5j8ofJn/lAWn28Ngcxz9NNjbT9OJfTBAL+Mnnyhuoc2x2FpaOWprtZRxTxw ucBEeW4HcldHe9ptC6007VHSNNTUVZGSI54QcdQ8EZ7KVx0Gx3X8QcR9c3Uf+H/7S1O3bbD6L3aY EAoywdfpZwX+T90sTd3pC212wtLSsqbhriOKSOIuHo9WWgDuSQuh1Js9onV+mJ5NFQQUdZET6c0R cQ5w/wAJyexUszmH+zV1Fc4Np+qYPJOAGZ5/kvBtxHZGUMv9mzCaAgH+6JLeryeVddbTl3pCG1mw 9FS0tRc9eRsdHHkeh1HpaB3JIW81dszpHVGlZKrQTIaerjJLXse57Xkf4TkqWq4Uz9H17boQKRxk EpdwAzPK+O31PZqa3Tx6aMbrZwWmNxI6v8XJV4zW2PyXlpCW1uxFDTW+e6a8Y10YB/uOshrAPJIW z1zshpi/6WNdt/GyKriJcA2QvbMP8vJ7qX7gKeXREzbmQ2lfkTdXADC7n+Sw0NTWeis9TFpksfbR zGWPLx1YOcE/VTj8unP4QZtXsTb4bTNd9fRgRdJIgLy0MA8khe3cPYyw3fS4um3Y6amLLjF6pe2Z vsCTwVMl2jpqnQIZdHBlI8ATlxwA3q5yV9dG0lrodPVUGnnNdbm9XpFknWM455+6WEzu9II2t2Jt 8dllu+v2ljHNy2AvLPTHuSD3X13J2Js9Xptl229Y58keXPg9Uv8AVb9CexCm3UFNSV2g4ae7PDKO X0mzEu6fl6hnnwvtpSjt1BpasprK8Pt7DIInB/WBxyAfPKzpeVQPthsPbWWGS7a+L4mvb1Nh9X0/ Tb7kjyvlunsRbv7Px3jb9ss4aOp8HqGQyN9wfcKdNSUlFctFUNJeH+nRzmFsruvo4+/henTdHR23 RtXTWx/XRQiYRO6+v5QPfyrrrbPO70gXbTYS1t0+btr98kfqN6mwtlMfpj6nySvDuzsPTUlphvWh DPV0nTmWmc/1HY/zNP8Aop71Zb6C76WtlBeZDHRTmISOEnR4zjPjlfS2U0Ft0DWU1ueZKaBszInF /Xlo7c+Us7k+yZ3tB+3WwlqGmzdNfSywGUdTIWS+n6bf+I+SVpd4NjI7PR0940UZ6y2vAEkGfUe3 P+JpHcKwuuLXb7zaLRQXeV0VFI9nWWyennDDgZX0gp46Db2eCieXwwMkbE4u6iWgnHPnhdPx46lv us3PKy6+EI7fbAWn+zhuWup54JZcOjjil9P0x7Hjkrm95NjH6fjgumkfXrrXIA18RPW9jj2IPkFW O1/aKG+0tmt12ndBSSPy9zZAw8MJAz919YoG0e3bKeneSyFvpscTkkB+Ac+Vjj6/rUz3v+IQ0D8P tsGm/wAfrmqqKaaXDmRwyBnpj2OQclcnvDsdUaZlgrtM/iLhaZulv+d7HHtnHcFWX3IslHqAWi2X Kplp6d7nuL45Aw5a3jlfRjfwu3lFEJHS9Hpxh57uAeACppre7pB2hfh5tn9nGV2t62ppZ5iC1kLw zoz2ByDyuK3b2Pr9JV0U9jFRcrPUENjfjqkjefDseD4KtJuRYKbUcltt1bVTU0GJZMxP6SXNaMff Hf8ARfWbrh0LbGlxe5rqdvUe5+cDKzub0u0FaL+HO3yachrNY3Gro6qUgiOAtAYD2ByDyo33s2gr tAVIqqR0tbYpSBHUkZdGf8r8cfYq2O4+nodSVdHSVVZUU0UUMs7fQeGkubjGfcBc9vTl+wtUJT1u /DRgk+Tkcrcx3ZE56ltUPeMOIWK+s35z7r5LDoEIQgazYwu7ArBd5tD/AAY6yoP7RULa6gc4sdC4 8EngH9Etkm6sm7qOKETwfy9/qs+hw/wlXpum1m21nL7jcLRTCCoYyOOB7iAHDJ+Xnuc/yXKa42N0 k3Ullq4Jja7XUv8ATlpxy1zgMjBJyM9ik7m2d96VC6ZDx0FHS4nBaQrval2/240x+FNbpIy0856f xERc5rT7uwcgfVQnv3orSllkorpo2upzT1LvTkoo5Ov0yBnqBznH0RWu2m2afr7T9dcjdhReg/oZ H6PX1nGeTkYUUXiidb7jUUkhBfC8sJHYkHCujsTQ2Cu27ZLaYammnEYiqi2Zw63478FU81Yz09RV 7cl2J3DJ5J5K349ZeK5f1yyys83D+NQymmkaXRxSOaO5DSQvgR0nnyrK7Ebj6Y0zoiutl8gd+Ie9 zw4Rh4eCMYVebyY319Q+AYidI4tH0JJCw6vCOVt9PWatvdygobdC6epmcGsY1alo5wFZr4PKKF93 u00kTHPZEzpJGSOVnLLjNtY48t/x5P8A4Ga9fw0TNvdGaow+p+FMLg7qx+XPVjvxlQ9TaPvNRqL+ Bx0MpuYkMboSOQR3J+iuEyO+/wBvm3lt06rb/EjbzSdHZmAc5zzyV2MNDSt3BqKhtPEJzRMc6TpG T85HdX50aVprfhr1BDaXVFJdKGpqmxeoaQscx+cflByRlRJadH3i56h/gtJRym5B5jdC4YLCO+fb CuPbYr63X7btJcmyW6oq5aI0vSQWMaCW8+ec+OF0lJb6KHce41UdLC2pfQwudIGAOJ63DOffCbm9 J8bVruXw36kpbRLVU1yoqupjj9Q0jWua930BPlRPZNJXa9X+Oz0FLI6vc8xmNwwWEfm6vbCuTp7+ PDXFNcq25snoLhJPTfhgzBjEfUW8557HwujtFqoabXt7qoKOnjqHwQuMjYwHEnqyc/XCutWw1dKy Xz4c9UW2z1FZHV0NbJC3rMEHV1uHnGR3UXaf0tcr3fIrVbqeSSskd0lnT+T3J9gFcnSr9Qxa2hrr hcGVFuufrRMha3Bj9Mu6Qf0B5W/05abbR6r1HV0lDTw1H93mRjAHcsJPKtx1LSXar+pPh91bZbVU 14fQ1zIB1GOlc4yEeSAWjso101pe5aivUNstUD5amV2DgHDBnkn2AVz9Fv1GzVbZ7vVxT2+5wPkj Ywn5ek8AjHBwfrlbfS9mtlnvGpam3UMFPMZ8l7GAHlgJH2z4WZKt6m6q/qjYXVdgs89wd+DroYBl 7aV7nSAeT0keFH+lNI3TVF6ittnhdNPIeT/hYP8AM4+Arjbb1WoZb0+W91EE1DdIDVRNYSekjAwQ QMcEe63Gj7NbbS7UtXbaGnp5/wAXK3rYwA4DQcfbJKastiY2Wcp6VW1jsfqvTNmdcaltPUwR/wC8 FM4vcwe5GOy4rR2j7vqq7st9ngMszuS4nDGD3cfCuTtlW3upuFxptQS09TBVRCqY1mSG9XdhBHHG OPqvXo61W/Tdl1NVWmjgp5WVdQQWtxnpALQfplaku9U3PhVbW+zuqtJ2ltxuUEMlMHdLzTSep6f1 dx2XM6J0VeNX3cUFnh65ekuc9xwxgx/iPjKuPt5Nfamru9p1a2mnhnhbVxhnzNLJCQW8+OOy+mlr ZR6V0Vequx0cENSJKhzT0/m6XkNB+iXHRO/Sqet9ptU6OtjK670kZpHO6DLBL6gZ7F3HAWg0Zoi8 6wupoLJTGaVrS57nHpYwYzy7sMq5WhRea6C9WXWkVNUxua2VrW/M10cmeP0wvhY6Cl0htvcKzTdH BT1LesNyMhzhIWjqUkq69qp642u1Po2hiq71RtZSyO6BJFIHhp+uOy1mitC3vV9e+ksdL68sbep7 nODGt+hceM/RXH0fHcb5Zb7YdbQU1Q+B/Q5rfma5rmlwOV8LNRQaO2t9bTVFDFVPDMA/43ueGZP1 wUss9lmlSda7daj0cIXXyidBFNwyRrw9uR4yOxXn0Zoe+awqZaexUhqHxt6nFzwxo/U+VcTT1PVa o0ldrNralilqKSR0Lh3zhuWuB9+e6wtELdJbX0DdM0UIq6lsbWNPAdJIcZJ90k30mrvSn2tdBX7S FRDDf6J1OZxmNzXBzH+4Dhxn6J6O0Lf9WyTx2GhfVegAZD1BoGfGT3Vv6KidrDbi40OsqOOWrony wOPch7GghwPvz3CdHSu0dt1bqfSlDCaqqLGhj3dIL5By4n78pjOU3Cy6U91joi+6QrIaa+0TqeSZ nXGQ4Oa76ZHGfonpHQuodVfiDY7dLViDHWWuDcZ8ZPdW6qaFus9sqqPV9Gw1lEZWEtPzNfGPzA+5 XqqaWXSOibdQ6Mt8ZqavDWsc7ByWZLur34TRJaphqfSl30xXCkvdDPR1Dm9YbJz1D6EcFfLTenLp qG4tt9mpZKuscC4RsIBwBk8nhW71vQw612cnuN+omsudHDJI0gYcyRhIP6HHZaT4c7hpSmpYrfQU 8keoZ2uM7njq6unnIPgYUvUmSf8AlcfmKt3/AE/c7DcZKG8Uc1HVxgF0cg5wex+q6S2bWayuNJBV 0lgrZKeZgkjkGAHA/cqT99BDJu9SOqGt9NrqUP6u3T1jOf0KmncmTUn8MtrtCt64yXep6Bbw3HGM 8YXfPxTHKY7+Ns+PK5470pdq3R1/0v6Iv9tqaH1s+mZQMPx7EcZ+i5d/srubvQPqdknjUUcTroIo 3H1AC5smR1Fv1+ypPVt6Z3AdljjeMyavVseY90kykshg8LILELNvKDJvJ7r7NLu3W7H3W+290tNr LU1PZqWpp6aaYPLZJyQ3LQTjj37KU6b4ctTPrqmnqKi2wMiDXNnLnFkmfY4BH7KKg8DB78rd2SwX i8Qvfa7bX1jGO6XOpoHSBp9iQOF0Gutt71ou6x0d0gbIJSBDPACY5SfAJ858Kxfw+6K1TpCAOucl My2VjPVfTBx9SN+OMjGP2UyysnSzV3tUmvoqqiqpaesjlgqIzh8cgLXNPsQV9bfZLvcoJJ6C311V DGSHvhgc9rcDJyQOOFKPxHQN/wC0i5SNaMu9POP/AJ21TLsNZLxpzb14qKamqqauaauJ0U/IDmfl cCO4x7rp5MeGUn2x4c55MLnVNJOoH5iePCwOfZbnUjA68zBrOn+8dx7cqXNr9nLZrPburvc1xqqe 4RvlaxjA0s+UZGRjPP3WK0gkn3Sz7L1XOlNJVyQkg9DiMheVFeqjglnlbHBG+SV2elrAS4/YBbVl rufpFwoq3oA5PoPwP5Lv/h91Tp/Sd+qqy+0j5qhzAKWVgyYzyCAPqCrCaP3DueotZst/8GlitUnX ieWnc0hoBIyTxypaKaQwSyva2Jkj3nJAaCScDJ4H0X2hpqyQEsjncwd8MJA/krX3N+jtvdy6utqb c6KeaFs0L4m5DXOyHAN+q2mh9w6jVWrn2qa1Rx0fS89ckJY8ADgEH3VywuPtOXypsyCZ7/kZI4nk dIJP8gsy2oaOnEv1BaeP5K1gqtE7f68uxloZoZz0ujexvU1vU3JaG+2Tn9VutAa/ZrPUVVaKi10w phE5wcY+cDjBB98qZz8f+xhlM5vFTL05c5y455X1aZsYe849icK11vk0Xtzq2+RVFG9tQ549J3T1 joc0Hox91vNvtZ02uLnW2upstIylbCXE+mOQeMEEeyZTjO2pN9xS/pka4nJHPHK+/XL0gFxwrV2F 2h9uL9qCCohcyqM5ZF6jfUb6WAQ3nsM5W/291RbNfzXO21FioYYGRDJjaCHB2R7cFNaSbql5Dw7P UR9V9jJIG/nz+qtNpw6E29ueoKeriArxO9jBOz1GuYMFoGeAug0JetP7jxXa3PsNBDCyIBz4mNy4 OJHcDgjCaRTMGUScEhfb1ZncOe4j2yrP6YG3+hjeIq2nZJdGTSRdNSwPDmtPyhvHC6PRlTpbcmhu tC7TtBTNZGA6SKNnX8x7hwGQeFb1eJtTYukZJnqIPccr0GpqXMx6hIPGMqz2l4dvNF0NzjrIYau5 Mkex8dZG1/V0nA6cjDRhdJpODSe49jusDdO0NGwAM9SKNvWM8gtcBxyEy6uqvxv4U3jMrDy4gk8c hfd09Q5uHPJ/mrOaVo9udKWOrFdTU1wuzHOEkNZE17i4OxhhLeARhdDpu06N3E09dY6bTdJbZIz6 RfHG0PacZBBAUy3j1SftNxTpj5mPz1EHPBzheh9ZUSR9LpHOH1dlWe0vbNudM6aqH10NLc7m09Us NWxrnl4OOlmRwFu7Rp3RG42mLk622CntksTjEXxRtDmOAz44TpdXW1P2PnY/+7LgR5X3nrKqSPpe 95+mcqzmmbPttpzSRdcqekudyafUljqADL1Zxhv0+i3VFo7RG4ekK2otNkhtcsL3RtliYA5r2jPO O4+iumVRqeadrstLg4ec4X2qKyqkZ0ySPI+pyrMWDTm2tg0eya5wUt4rer1JGvI9VrjwWgZHAPhb OfQuh9b6Kq66xWttrfTuf0Ssbh3U0ZII8hSTd0b17VNp6iqjkDonPBHYg4K9VRX1kzMSvece5VlL DprbSxaRiluUdLeql5D39RxK0kD5cAjsV7q7b3ROsdDz3LTdv/hjoXPIeAckt7gjJ4WtWXVOU1tV WCqqopOqJzg76HBX1qblWzR9Mrnn7lWatukdtNO6Xp5boynvFQ45c4Hpk55x0g+Oy+162z0bqbQz 7xpekdbXs6nh7snqDTgggkqa70bk7qrdJXVkLsxlwP0K+9bdK6doE8j3Y4GT2VmKTRm2en9M0092 bFdJz+aRjyHnPP5QUaj2u0fqLQ38a0pE63lmXhzsuDgDggglTerJfa/G1YKW4VlO/rie9jvcHGVl XXasqm4qZJZMcDqOVZ4aC2z09pyjkvQbcZwOl80EhLnHvktB4Xk1htVpK86CN/0ex9KI2GUdRJEj RwQQexWt96T+qoyOJceruvk7vythdKY01S5h8HC17hgq1GHlBTKx8IhpBNH3QIoIQQl5QPyhAQih HOEk/CAQhCIRTSKB2Q0Mo8pYymB5UCKEI8e6sU0JBNUAQOSgJFSh9kyOFiDyss5UGKeM8eySaAHf 7ISTVB4TKSYQIBGOEIKAI5TQkgeEI7o+6AR4R5QgEI+qEAUNTPbhHlBj+iOyZQgXIT4x7pFH1QPw hH2R2+qBY4SWQKXKA7peU/sgoF57BCExyoEEJkJHlAwhJH+JAzwl4QjIQMpJ90jwgM+Al+pTKMFB YE9zhYnuFl5WLvK+a9zktxj/AOgp/qW/1UWQjA+qlLcg/wDoKYfVqi2Ls33wvV4v9Xn8nt5pTl5W Czk/OcrBd3GhCEIBCEIBCEIPVQ1L6aZskbi1zTkEKfduN722W3imvccswaMAt56gq9MGXLd2ewXe 7NP8Lt1XVgf/ACGMu/ohrawto3s03RXqprKe1SUzJT1ENwep3krzu30oanV5r3088NEGBjWdWe3l QazSWo3zugbZLi6Zgy6MU7uofphfAWG7fjzRfw2sFb/8gMLg8f8AdxlGdRaY78aVqaqCWakqCYs/ MR3Xsn3z0XVSwy1FLM+SEl0ZIJLT7hVaOjdUdfR/ALoHe34Z/wD0WR0dqdvewXXA/wDvV/8A0Q0t G/4gdLiqbIIKkdAI7d8rhLZu/ZItwa68vgnjpqjoaBjJ+XyoQOltQhxDrJcw72/CyZ/ovDHabhNV GmhpKl9SO8TYnF4/7uMqzKyWfbNwlst9xO+6O6Gl9XXe0ddLUvpaV7nS5IAdnHC6G9b72G1aXNHp Wme2r9PoZkANbwqyVdrr6WdkFRR1MUz+GsfE5rj9gRlKvtFyoYg+toaqmY7s6WFzAftkK3K32uOE x9HfLrU3i4zVldK6WeVxc5zjla9vfHblY9sg90vKltvdak1NRY/YjXukNKWoC4OljrODIfBP0WO/ WvNIaqoY5rWal91jI9N+cMxnnIVdmucD7plziOe6Y5XH0mWEy1v4WT2S3jt1jtbLdesxNiGGvAz1 BSPRbxaFt88xpaqZoneZJCRkZJz+ndUupaOsmjL4YJnsHcsjcR+4Cxn648tdkPHg8EKQuMq3No15 tlab3cLvSOk/FVTvUe546iXecZ8fRem0b86dudZW013xFRE9MYezIcz7KnHXJ5SL3DsArbbd/KTC ScfhI+5Fy01Ta/juejRI6lDhNJE9oDQ/OT0/RdvqLf8A/iWjZ7O21tD5ojEXOdwMjuq+uJ56liT9 U21qeif+bKzid0kFYJeVFWV2L3jgtVKy0aikDaZrelkh7dPsVJd13V0Npe01lRp58L6qXLmwxMwC 4/0VJIy7PylfcmQj5iFZbGbjKtTtjvtBUVtRTankbHHM4lrzy3B/wldZd90ND6Qs9bLpuSCSqlJc 2KId3H6+FSlrntORkfVZPe9/5nD90t2cfhbLa/fKkrpaii1TKyJspcfUd+UtPgrorzubonRNiqna Ykp5qiVznNhi4HU7zn2VKupzSA1Prcf8TftnlNnFbfa3euhu0dTQasliiMpcS5/DXNPhb++bk6L0 Lp2dumZqeeoeXOZFEfJ8n6BUqa57fynBQ5z3DHW0/QFNpxi3m2G8tr1BQ1Nr1c+GJ0gd1OeMMe09 wtze9w9H7faVmi0xNTzzPLjHFEfJ8lUqYZWnDTg/fCye+R3Dn5/XKcqnCLf7Z7uWjVNoqbRq50ED 5GuD+vhj2lbXUG4WktvNJSU2mZ4J5nl3psjd1YcfJVKWGUH5ThZOdKQeo9Su76Pxz2uNtxuvY9X2 Ce0apkgge5pbJ1fK1wPsvZqXcHS23Wj/AMFpmpgqZ3ZEbGO6sH3KpVDNK13ynB+6zllmcfncT7ZO VOV9Lwi5u3u5lh1xpiaz6jlhp5SzpkaXdDXD3C++qtf6a250fHbNPVMNVOQWsa1/VgnuSqU0800b sscWn6cLGeonecyOLj45ymziurofcHTu4OkJrPqCaKlk6eiRpf0A+xC+msNfac250ZFabDUw1lQ5 pZG0P6xz3c5UmhqZWE+mSCfqvpLNNL+dxcfqU2vFdXSustNbmaIfaL7NHSyhoa9hk6BkdiCsdba+ sG3OjoLLZJ4quoMZYxof1jBGCXcql0VRNEcxPIP0OEpaieZ2ZXFzvcklNpwntdjT2ptN7p6I/h10 qW0k7GhrmiToLXAcEFfDcDXti270hT2OyyxVk/p+m1nX1jB4JJyqYQVVTTnqhke0/wDCSFhVVdTU O6pnl5+pyrtPxxdu23vTW7Wio6WvqxSTxFpewS9Ba4DjHuF5dx9f2HQGmKWwWqWOrlEYYGdXWA3y SQe6pfSXCrp8mCVzPs4hfOqrKiod1TPc9x8k5V530fix7/q80Vy07u5oynE1eKOeFzXODZQwscP6 gha/cncOxaE07SWC2vZWTNY1vR19Qa0HOS73VL6a61dG0iCaSPPfpcRlfKqraiqf6k0jnu93HJU5 VeE+F6pqiwbvaQo5BcDRzQyNeeiTocx3+IfqFrNztxLJoezUNioXNrJoywFpfnpY0g5J9+FTChu9 dSAtpaiWLPJDHkBfCurampk9SeRz3nuXE5U2vFe+u/gW7WmLfUw3F1K+GQPPRL0ObnHU0/cLVbn7 kWPRtFQWOlIq5YnR5aH56GtIIJPk8KmFvvlxoo+ikqpY2+QxxAXlrK+pqpzLUSvkkd3c4klNnFe6 7Uln3VsVtr6G5vpnROBPpyBpAOOpp/RcL8SGuLTa9Hv0jQv/ABFQ+Nsbj1f7sN7E+5VV7fqG6UMX p0lXNCw9w1xAWvuFbUVkzpaqR8kju7nEklWZ2dpwl6eWU/M76r5Jk5PKSy2EIQga7/Z2wVeo9Z2+ ioDGJA8SuL3dIDW8lcAtjZ7rV2mrZU0M74J2flew4Klkymqstl3F5/iEstxuG3wdbG9UlC4TyBrs HpaOcKvG312qNcakoLNqXUlZTULQTG7ryQ8D5QM8Z+64Ct3A1FW0b6eputTJC8YcwvJBC5unrZIZ hLE4te05BB5BWt/rMfiMTGS2/b9C7JRans1ZTW9z4bvY2Rhv4mVwZN9iOxx/NV5+J7SFo09daeus 9SyOSseTNQD/AAHv1t9gfZRbBuhqmKNrG3iqDQMY9Qrnb1qGvvNWam5VMlRNjHU92ThRpdP4ddPV 1m26H4xjGmsPrxhrg7LSOMqpG59krLFrK4UdzhMVR6hkA7gtJJBCLXuVqW2UUdLR3iqihiHSxgkO APZc7fb3XXy4PrblUPnqH8F7zk4Tx/pjcJ6rOWPLyc/lYPY3TGgrxoCrl1J+FddA+T5pJixzRjjH KrrdWMirp443BzGPc1pznIBOF8o6qWNpax5aD3wcLzucXOyUaZN4cCrCfCzqy22K/wBXSXKT0TWt ayOQn5QQfKryF6qSpkgkD43FrhyCFnLGZTVaxul+qbSd3h15NcDdc6ddIK5sOMgyHuO/GMA5XypN wNPP3Mnom1g9R0DabrOOjrDicZz9VUuPdnVotooxdqj0Qz0wOon5cYwuPZdKiOo9f1HCTPV1Z5z7 qovVbNLXmk17U19RdA/TrHmshiI49R4IcPoB3z9Vha9cWCq3MrKOOtb6r6dkDScBrntc4kA/qqnS 7vaultponXWYwlnp4z4xhcZFd6mKrFQyRwmDuoPB5B91f6a+F5tO6bvdu1nVVFyuDH2Ome+ppQRx mQEOGfGP9Vlp7WtkuG4V1ooKxhmkijjjJIw4tzkA/qqnVu8Wray3Ooqi6SmBzegjyR91xdJequkr 2VUEz2TMd1teDzn3VuVvdF39Lac1Ba9VVFRerjE+y0bpJKUEY/3mcnPjHsvTpTV9luesr3Q0lW0z TdHRngOLWkHCqndN59V3O1S0FTcXOhkb0uwOcfdcVbNQVtuuEdZTTSRzxu6mvaeQUtvySaXc0TZd R2q81cuoqyF9routlLzyWO56u3HtjPhfbSGqbPfL9qChoaxjqiSXqaDxkdAHH7Kql83o1Zd7XLQV NwJglADwGgHH3XGWfUldaLlFX0NQ6Kpjd1B4Jzn6qbW7vVXY28sl+tFVUS6iqIDQ0LHU9MBwekYP X27EfXwvvorUNqvz9Q0FurGOqJaiWRo7fK5oAI9+Qqq6h3q1Te7VLQ1dcPRlGHBjQCf1XH2DVtxs V0hr7fUPhqYj1BwPdLlbd1JJJqLpbbWy+Wx9fVankgjipWfhYQ1uCWMAJeTjnIx+y+mk7rbtT2jU 1ttdZG6plqJyPoHDAd9lVvVG9GptQ2p1FV1QbC7l3Q3BP6rldKa0uenLtHX2yodFOz9Q4exHlJbO yza5W3lNfbeK+46vfDGIYRSR4BDumNxPUeOQc8FZ6Zr6TU2jrzbrLWQyVfXO1uTwOpxLT9uVVzV2 82o9SW38FWVDGxZyTG3pJXN6N13dNK3Ztda5+iUcOaeWuH1CvO0nXpcjQ4vNDQ3C76y9CnJiZEC3 jDWEjJH6r42uePUu3FzobBUwz1jXSANLsYPqFw/cKsmst5NRaotjaKsmYyEHLhG3pLvoVoND7g3b SV0Fba5+l5BDmOGWuH1CkouJoZ1zobNdL1q409LNVdLndJx0hoLfmHgr4MkdqHa58Om54Z6+ENIb 1dnseHYP3wqxa43kv+q7cyjq5GRxtOT6Q6er7rUaA3Mu+jq99Rb5QWvaWvjk5a764Vt2W79rd6On uFDpi53jVvpUlRWEzOH5QwdAa0EeDwvLIam87W0EmmXxVNbSCGRrerjqjOSPv9FWPXe8V61ZSR09 ZIyKNvdsQ6Q774Xk273Tu+i55XUMrXwS/mhk5bn3A91J0vLva2Gm5quh0JdLhqcQ0M9dJLUFucBo cwAA+x47L43iorK/bi1V+mRHWT0jopukHOegfMMeT9FWHX+8F41dCyGqcyKFn/s4uAfuF89ud3bx o4Sx0jmzU0vJhlyWg+49imP6zUOVWnoX1NFt7cqnUQp6GorfWmLQ/LW9beBlGqa2tdo+z3nTEcde +jLZOlvzBzenpPA+6q7uFu5ddY+lHUOZBAwf7qIkNJ55wvptxvDd9Hwy00RbPSv5EUnIaforu6Jl pZe8GWh2guIvQhpKuenme6IP46nEnpHv3UJ/DlTTSbkUk7Y5DCyGUF/QQ3lpxz2XI7kbsXPWj4RP 0U9NEP8AdRk9JPv910Git+rjp6wUlrNFSTNpm9EchBDunwFmzckpvu5fNb/eyne7dyldJFII3S0g Di09JHW3z291Jm+uobvp2hthsss0LZHPEhibnsOAoe1dvvPqGwVNtnttKwzdJEzc9TCHAgj65C9d o+Iiup7ZT0twoKarkib0+q/Jc76n6rtl5eV5a+NM4Y8ZMfpJm5T5LlsGyquTeurdTwSOe9vzBxLc n6FUrr+Z3fRTTuVvZXarsf8ADYadlJTu4kDD+cdwCFCEzup5OfuszL9Jh9GXeVsfI8JJnvykFkAX 0HCw7rIIOi0PJJDqK3SROIk/EMa3p78uAVzt6dQ1mntJW+amfj1ZA2Qe4ABx/JVA2u1RFpHVlHdp 6KKtjh6gYpP+IEZHsRlTTrffO06o0pW2ups7eqaMiN5fn03eHDjuFmTvbpct4TF3+jtwrZuPqm10 j7a1j6MSSlspDxnoxkcLfUd7rp94p7TM/wD2Kmpy+NoHlzG5Of3VP9E6yrNKakp7rb34kjOHNPZ7 T3B/RTpXb/WyWN9XRWeKC6uDQKgkOdgEZBOM4xkLV9WOVxtylcb8RQxuLcD3OWcf/Q2qXfhoqZan bWrbJI57Yp5I2AnIa3GcD91C2724Vn1s+lqaO1/g65mRLJ1ZMgxxngdl3Ogd87HY9N0VudZRBJDE 2OV0TgGyOAx1Yx3K15cueUy+l8M/H4rhflAurWht8nPb5yf6qQtudH60uWia28aer2QW5rpOqD8Q 5jnlo+bAxjt9VxO5V7t961TW19pp/wANT1EnqNizkN98frytxojdm96S0/NaKJ8LqKRznFr2ZLS4 YOCs5Xd2smppH906/wAU4S56urnK8q9NwqPxM7pM8uJcvLnlRW903bbpWTme00dVUvp3NkLoInPD CDkE4HHIVotod2bzqjU9BZbnT07CWPEha3DiWtJ/TkKEdj9yH6DvMzpovXt9UA2oiHfjs4fVTPQb r7fUNydc6CwmGvcXOdM1rQ4k91LDbQ79WqtZrs1Nqp62oMbI5z6cb5RG4HI7A9I4z+67PaPdO56v 1FFbLhS0rB6Tnl8bSDwFyVq3zig1rVVdVF122paI3NaMEBuek4/XC3Vo3I23tN1ludrs8lJXy9XV KxuAc9+M4/kt+XLnZ/Exkk05DeWlrqTcepnt1PV1PoPjmGGulDS0Nf354UnbTbn1usr2631tHTxB sBlD4s59lxti3ygg1RVyXWHrtlWMP9NvLSBgHGfIwCt1Ytx9tLHWTVtotslHVSNIL42fmzzgjq/0 Wf8AJyy82uPwz4PHPFjxriN25Kuy7mT1tM2eoNNURyxmQOeMtaD0kjwpa2k3IqtbXKrpaiggpWxQ h49NxJOThcNpveu3tvlxZe6Zr7dWkl7mNyQcY5HkEDC2+n9f7Zacqp6ux0clNUStLXPazv5xyfdP JblJp0xkxllcJuTcKnTO6dTc6dzpn0dUHR+tlwcOkZaT+pUw7Ta+OtK6ugfbYaF0ULXl0Pc5JHdc HpjeOzvuF4p9RUrHW+4vdKQ1nVgkBpBB8EALc6b1xtrpT8XPp2GWmnnZh2WlwdjkDkqXdJ04HXVz qdMbsz3OICpdSVTnAT8teCMEE++Cpk2q1rDrKe5Rx2uC3SxRNc58GA53UT5x9Fwmlt2bBWS3qk1R SxfhK+R0vDOrPVgFpz9luNNav230iyun0560NRPHgtd1ODiOQOTwrvtmzrSNb9e5dNbqS3WambXN pql4Mc3AkyC3JOMZ5U47WarpNXwXJtJa4bXJG1oc6AAOPVnBzj6Lg9N7n6Yu0F1t2rKOCOnqHuex 7Y+okOOS3PcEe63WnNX7d6Po66TT08jZ5mglshLusjsPornlMs+UZmP68UU1d6ZpzcuS4XCliubY J5GvhmwOvqBHV2xnn2U+7XamoNV225utVtjtXQQ13ogA5I+3hcBYNxNHagoLlbNWUVPFG97jHK1m XOBOe+Mgg+Vu9P6s0Doq0XD+zlVLJJL8/pyknqd2Ayp5crnlMo1jJMONRM2/w6a3Dlnu1HBdoWSS Mkp52tw7q4DhkEAhT9thqC2ansdxksVsbZmsf0ubCG/mx3wBjt9FwOn9a6H1LZKu16qo6aB4cemY R/O4E5BDgMghbywao0FoiyXFmnq6SZ0rvV9KVxJc7GMA4Ty5XO7h45McbKiS336h05ryeovlsp7t TOMkb4pWNPJPDgDwp/26vNr1Jpe4y6bt8dla2RzC2JjQOsDvgADso/septv9Wafmt+paSmpKthwZ msAkeM5Dg8DOV0Fj1HoXQ+na+DT1e+f1HGUxSvJc5xGO5CzruVvc42VEGntQWyy6vrH6jtUV2o5O ppikDT0uzkOAI/RWC0FdrZftF3CfS9AyyxMkewMZG0DrA5PSBjlR3Zrzt7qzTYo9QQU1vuEJDTPG 0B7sHIcHAfvldJZ9R6K0TpSuo7JczVtc50pY9+Xuc4YOF1tlrnJ0h/S9+slq1HXnVFnZdKSUFjWk AmNwdnqwfdTzpi42u6bd3KfSdIy10zPUaIw0EdQHPH1XCW6o251jpqOC6sp7TcoSAZ4WtZI4j/Fn HOfqt/R3vSWidE1lttF0/HseXuPW8F+XcFSWTPfwznjyxsiHdHXmwWu+Vo1XaxcaSZmGAHmNwdkn H1U+2ipttbtrXz6QgFvowJcROb1AkD5vPGVw9FFtvrLTMAq/w9muETgHywgMk6gME5xyD9V0VLeN LaH0NPbLfdm3KF7nn5nt6x1d84HK1c5fJy+Gfx3hxQ/oi86fo7zXjVluNfTPYPSDe7HA8+VO9LNQ VW1tTNpCNtHQ9ErhDIC4Hk9Q78Z5XEw23bXWen4ZWyU9krmO/vXRYbJ1Ywc57g910P8AGNMaL2+N oobq24xDqYD1jr+Y5OcLFt/LMp6buMuFxvtEOhrnpmjuVe3V1DLUse0GBzCflOTkcEe/8lN9VNRS 7S1M+kmMpqAQvc2KRucjPI78c+VxbdP7cawscNTRVcVkrOrMxD/mJxgggnGPsuiq7npvSG27rNS3 JlfGWuiHQ4FxycnP0S3/AJcctdLnN+K477RDoS7aWiqa6PWdHPI13SYHxFwA7gg4I+6nK5SUbtoq iTSjGR24U56I5Ac9OeQDnuuKqdJbeaxs9NVWq4Q2OqJ/vcO6iTjkFrjjv5XQXW6af0jtg6yQ3SOt xCYWPY4Ek98keFrPLflmUnSTH/huNvan+p//AF6Rx8u7LQPzlbvUczJq6RzOQ45C0r0zu8rTGakj 5lIplJRQkCmhECR7p+UEZQJBR5QUUIKSaASKO6M5CAH80eUllnhAAYKD2SKZ5TQxCaCOUc44QJNG EDumwkDkrIoUC+vZHlHKPugD3RlPwl5PdAE5QQgdkAqgwmjCEAkO6Mcp4QCEJY9kDPdA7plGUCPC PCEBAd0d0I5QB7Iz7oCPKACB3R5Qe6APbHsgHhHlA7n2QPwsXc90yUd0CA4SxhZHAKXdAfZI8p45 90kAVkOyxTyT3UCQnlGEAEIAQSibCWMJpIpjhIlHhGECT/UI7Z7o4+qCwR7rB3dZlYu7L5r2uN3J cf4K/Hl7QowhHCkvcwkWcD3lao1h5aPqF6vF/q4Z+3lk/MVgsn91iu8cQhCEAhCEAhCEG/0ZaWXm /wBJRyktjldhxHsroUFBb9AaClr6GlaTDF1EDgn9VUPawtbq+3ueQAH9yria9gluG11dDb2OnldD hrYxknnK6eGS+STL05ee3HC2e3GbRbgnUt7qZKxrWVJOBzyGk8DP0UnO0hSHVRv/AFEzSRta7JGB 09lW74f9MVVXfnVUzJ4mQksc3BaSc85H0VrwadkbKITZeWkBpIzhc8v9lnpyzNSCr1sbVTBpFOGl 0rXZz1eMLe3yruVLXU34GL1IC17ps8Y6ee/2yoz0bp9+ndy7lCTUPgncySKWZuC7JOQD5xwF2Wvt U11lrKSkt9A6umrGvaI8kAHGMn90+ek3+s23ViutJe6iOejkDgGuDiPBH1Xnk0nQx6jF4pIIm1Ty BKQAC8A98+61W1tkrLHQiGva1ksnVJhpz055wvtpXVEtTqy7Wt7SWwzdOc/zV1eNyOU5TG/KLfiL vDbDqqw1rIo5HMDieoA8cf8ARSFamWzcvQwp7lTB9NPFkEjlp8EfVRJ8WbXOvdqaMk9DuApW2Mp5 aXRVGKhhjxEM9Qwunn6uOvpx/wAe24Zb+1MtxNPN0vquvtMUpmZTyFrXkYOFzYGcZ7qQd83B2494 Oc/3p5+ij9vhPNjMctYu3hyuWEt9pA0rtLqzU1ubW2uhidARkepM1hI98FbuLYbXJiMgtkJaD2/E Nz+ylv4VqqoqLO9k7y6OOTpaD4AXda83Mt+jtUMo7sHmndEJGiNuTyuU7auUntz/AMPjamlt81nu VBHT1FI70nscwZOPP1+64/4mdAXW43dt5tNrElHDABK6LpBBB9u5Uqbd6oodX32qudshdFTgBgDu 5IHddTDWvqNW1tufh0DYmOwRnuDlSJc5LFI7DtLq+/W78dbbU6SnIyMyta7H2K2D9jtdfhXVDbM4 saCSPWbnj6K3emqSG36vuVDSAtpmhsgZnIBcMkD6ZXtt1U+XWVwpS7MEcbMN8AkHKtujHPen5/W6 wVdVqCK0SMMFW+X0XNkGCx2fKlvV3w/Vlg0bU33+NQz+hH6joPw5bkewd1H+ifxAQyjdkC0RFtW5 jOgRNAcX5PK+WtaLdGLRz5b6Kn+DhgMmJWn5fqAV0z8fC6Z8Xl/JjyQW4dJx9UwM490P5efum04P Zc3ZLfw+6QoNTatDbrGZKeEBwZ4cc+VbC7UGkaKpjstfa7cyOeEgOfC0ZHbGcKD/AITLuwVFRb/w kPW0h3rY+Y5Pb9F0/wAVOojb6CG3R0sBdUc+uR87MHwe4XTxYc7Xn8/kuHH+1x2kdt9P1m71woIi Km1Urg+NocHNOT2PvhTtd7JoyKr/AIFXWi2RerD8rnQsaSDxwcZyoi+FO9xyzVdF+FiM7XBzpyMu IcVsfit1F+AjpbfHSwmadvUKkj52AHwVvCTyZXU+Gc8svHMZv3XJ7fbZ2Gu3VutA4mqtlDIDE0kO Dsk8E+cKcrvpvQzq2Sw1VmtcMjoAQ/0WNdg8ZBUZ/CpeYahtVRGjiFSxwc6fGXPyeM/ZP4qtRtop qa3wUkQqXtDxVdntGe2fZMJj5Mr10Z5ZYY4zfdcxtrtdZLhufdqKUmqttvlxE0kEP5PB98KbrxpH QVTWVGn57Pa6ep9AOD2wsY/B4yD7rgPhSu8FTR1NL+DiFVG/L5/8T8+6+PxM6hZS36gttPSsZWkM f+LaSHgE46fqFnx4zPKxryZXxya+XY2vbbRujdIVdZU2eluTYQ57n1UTXkgfUhOy6R0Pr/SM09Pp uhoWSghskETWvafcELpYpI7Jts+puZdcYmU/VIyUAh3HZPQ1dRX/AEW6ay0jLTBKw9Ap2gdB9wOy STjLr5YyzymWU38Iwtlr2p0ZZJ4a+KhulbESHNqIw6QkLpY9A6K1nomWqZpqC0CZmY5WxCN7fYhc ntxtR+L1DXag1XKZKOOdzohKA31CD+Z3hYbv7ptrZW6Y0xIIoHOEMtQ0ccnHS0Ld8c53XqH5bcJ9 1DGhtP08W4X4Srtkt4oqaVzJI2Rl3GcBxwrFbrbb6Sj21rqu26fpKOtLGmJ8bOlzHEjC6LTtjtm2 WhHV1HT+vVODTJK/8z3OIGSf1Wy3UldNtzI+T88hhJ/VwWLq57np03Zjr5Rlt7s9pvS+mH3rXcFP UPc0Pc2YZZGD2H3S3L2Z0/qbSYvOgqaClqY2l4jjOGTNxyOeAVLmsRa26Qp/496f8NBi9YSflI+q +2mRbm6TqjZQxttPqGAM/KG48fRZ1OMrXK8rFP8AaPaK4axvP+1xvp7XC/E0hGOojwFL29e1Gl7N oZ0lhtEcVzD4445WucC4k455xypItuoNMx2OC12i9UlFM8BpDAC7J78e69m4tuoavTFPFW3AUzI5 InRyubkvcDkDH1WvHrl25+e5cP19oo0Ts3pbTGl/4nuAyGeeUAlsjiGx57AY8p672R09cYrdedJw sgog5pngY4lr2Z5IJPdSvruGzy2u2t1IYm28SM6/UJDc9JxyERS0FFt5UyUODb445HQ9ByOgZxgq 44zeM+2L5r+1t6jh9V7e7YaTssNddrCDE7Depkj8kkfdRrqao2ZksNYy3WSpjrTG4RPaXAtdjg8n 3UgXzdfQmpLZHbr9QVM8IxljhgZHGchfe+bSaKvGmqO6Wm3uoI+psri17nGRmeQck91mydT5dccs u7b0pv8AwyqfGHx09Q5h7ObGSD+uF5J6WaA4kZIw+OsEf1X6PT0lDpyyUdLQ1NFa6WPDW+vEHNIx 2HI5XE7rUGm9W6PfRuqbfV3RuPwphLWuMh4GB9VJN3Tdz0ou2kne0OEUpHghhI/fCwML2O7HI7g+ F+hGkbZXae07aKO7Vdqhf0tiELqfBcf8oOeT+ijr4gdurXedSaekoYmUlwuNR+GllaMNLQOCWjyF nX01c5EIbDae07fNT/gtVQTzxzt6YGxuIAf9cLvd9torPYpLJT6PoZxW1szoiwyl4dwMd+ym21Wy xba0VlsdBTNfWVszY2yuYCXO46nE+F8NzcO1/oaMjvVvP8gtYT3v6c88/Wvtwmmdh9JWXTtO/XEr 5LjO5oJbOYw0u46QB3wo+3Y2JuFkvEMulIpK61Vbg2JoOXROPYE+R9VYfcezWa+XWmgvk3pCGnlm h/vvT+bjn64W7J/9A6fYT1AzU4J9+Usksn8Zx8lu0OaZ2B0la7DRHWs8r7nORnoqDG0E4+UDzj3U R76bQ1Oha51dbOup0/Mcxyd3Qk/4XH+hVoNxLFZ77fIW3qV0bqakklgxN6fzg8H6+FzPxEE/9jLA 456mRZP6LeHjlymLOXlyxnL+qQOGCVivpN+d33XzXF6ghCEAvo1pcsFJexFVbqTXdB/FbfBXwTf3 HpTNDmgu4BwUEdiI4ByP3CbYn+3Huv0Bv+mdCaalFZW2K2epXvZDHG6nZ09QPjjA7/yXJa32s0LH rWx3GrbHR0lS4sdTRYbFI5oy3I9igpb6ZJ7jI8ZCy9Jx/wAOFffUen9M2Oop2/2Coa2hm4NRTUrX mP3LhjOMeVH4tm2tNuNQTWiko7hHcs08tEYw6OFx7OAPA+yCo4heDy1Yvjd2wVem66W0FpfUVFQS aZo6iS8T/IHxNcI3cA4z2H0UGfEroG06R1BSVVjZ6FPXhznUwHyxuB7t9gfZbx8dt1GL5MZ7QzQ6 du9fSPqaK2V9TTMz1Sw07nsGO+SBjhatzcHCsptLvBadKbez2K40c75R6vS+MjB6hxkKutwcJKqV zRgOcSB7ZKw6aeUBemkp3VEzI4xlziAB9V5vou62kttuumtLbTXaq/C0rn5MmM8+B+6x5MuONsXC S3VTLpH4bmVmn6Opv96fQ19Ty2GJjXNAIyBk9yok3B29uWj9WOslURM5+HU8rRgTMccA/Q57hXF3 Vgig0I18d1FBNRtbLTTHgPe1vDT91XW2aj/7Ttx7GdSzxULYIxGJIxnqLTkZz7lLcp4+dPHZn5OL oNN/DW6qs1NNer4aOvqAS2njiDgOMgdRPJwod1loK66V1WbHWM66h5Houb2la44B+iuPvKXUWkIr jS3RtDVW9wmpy449VwH5f1CgGxX4bo7rWeo1BNBQ+lG1gLBxIWHIHPklXG3jurjq5avpurH8M8tR aaaW634UlwmYXfhRThwa726urn9lC2oNGXSy6pdYaunIuHqCONo7SdRw0g+xVzN75prZpeG8W+5R 0VbbX+tE15wJ+wcz9lA+l7i3c/dyguF2mp7ZJG1rwGguEjmHIAz5K3JNXftjff8AG0tvwzVc1vhf Waijpa6SLqNN+F6sOx+Xq6ufvhctovYi/wB8vVdR3SQWqCicY5J3R+oHPxkADI4I5zlWH3xrJ7La KW/UNxZS1luf1shf/wDHDSQHNH6JbOaol1db7vXT0ZpxNMQZWkFhIaBj34Uz1jJb8rhvKW/SJG/D cagTNodYUVRIxpIjZT5yfAOH8crldF7Dai1DXVsVwkbaKele6J00kfqdTx4ABHGDnKsHtpoym07q GurafUENz9SNzTDGBlvzZyfmP28KK9Xax1R/2kXayaZlqIn1VT0Np3AA9RaASc8AfVZxu1y6eOo+ GyrfTzm26ooK2WNpcImwkEnwOHHGVBdystVbrpNQVsRgqoZPTkY/jpKubpu3W/ajSctx1BWme6VD eqQl3c4GGNbnsD5+qjLR2g3boavuOq7xD+GskkxJYH4MpAwQD4AVv8I564/D/coNJPvdFfqCribT +uYhE5pI6ckB2SFw23W3F211d5KO2dEMcQzNUSglkfsDjnlXAqqO1Wva68Uth6zRU9POwdTy89Qa QeT3C0m2EYt2zLqu3tZBVuhmf6rWjPWHEAn37Ba1OM+7XPG25ZT6QBuDsVf9J2H+KCqgucDD/fim Y4GMf5uTyFFFNQzzVMcMMbpJZHBrGtGS4nsAr27fUV4o6i72nUVbHcGPjZUsd04aWyE9QwfqCua2 12vtdputZqarhFVKZ5DSwxty2IdRB+XyVLNTbU3tBd32Q1HadETahrZ6VjYoxK+k+b1GjOMHxlc/ txtreddV8kVt6YKeMEvqZmn0wcZDePJVydwIK28bbXWCKlf+MmhIbCBzw4ePsMrRWMS2PZmjktDI qStfDE3q6P8AG54aSR5PKjWM3KrHuNtDqHQ9BHXV/wCHq6B5waikLnNjPjqyBjPuo7paSepqY4II nySyENaxoyXE9gAr36JpK+TTl7smqHwXAUz3QEluWyMLOoZB+65TabbO16Wt/wDaWuhNdWytL4GR xl/psP5QBjPV9Ul36Mpq6QDqrZ3UemtKRX25OpBTuDOuJj3erH1duoEAcH2K8e3e1l/11HUS2lsM VPD8vrVJLWPd5DSAclWp3hpKy+7bPdHSTeo/05ZIACXNA5PH0WyobVXx7Y0FJpH8HRVj6aMgyNIZ y35icefqumUxmOOvbljbd7U13I29vGgq6npryYH+vH6jJIHFzTzgjkDleLQWirtrW8tt9mjHUBl8 r8hkY8dR8ZUo7pbX6zobYbveJ4rlDFkPEEj3mJvfOCOykP4UNOVFDZLheJHwmCuLY42NOXNLCc59 sqcettIP11s9qjRtqFxucUMtL19Ln0zy/o+ruOAuY0Xpa46sv8FotXpfipWuc0yv6W4aMnlWR3B1 dX6XdqLTGoYvxNLc4nyUMkZBLGvJGD9iOy0u0+0UlLC3UmoqqqtgjLZKcQv6XAZ56xjjKeSTCe+z DeWXfpFOutqtRaMpqaovMUPozvMbDBL1nqxnGMZW3s+xGtLpQU1bBR0zYp2hwbLUBj2j2c0jIKnj 4lJzR6ZsszHfNHV9TXHnkNJB/cLk7JqLcDc20ddldRU8dJL0PkZP6L3HHsM8LPw3ENa12t1LpCKG a7UQ9GZ3Q2SB3qDq8A4HBK3Fu2J1tX0MFVBb4PTmaHtD6gMcAfBBHBVnNRmS2bcUVPf5Q+va+nDn YL+p4kaTg++AUbmW3Ut3ht79IzBjWh3qf33pHnGP2WpJYmXV0p5rvbvUGivQF9oxC2cEsfG8PaSP GR5+i4d4wcK6u+LTT7MRUd8kjfdAyIEu+YukBHUQffuqX1YxKcey1cNYTL7YmW7Y8xQEO7pLDRjk pjullZN7oM25HZfQEjyV1e12k6fWOqYLTVXFluZM15EzmdWXAZDcZHdTLB8M1T+JqRWaggpqeMt9 KX8N1CTPv8wxzwptVeKGknrqqGnpo3STSvDGNHcknAH81342e103h2na77hzSP6qXtr9updA7qsg vHozUskD/wANUuaA2Q8cc9j9FIWppdcR69jbaY5zYTLF1OaGlvRgdX1HOVmZ7tlmmrNa1VLr3Zq+ y3GaiudPLTVcJ6XxyDkLWEvHHOFZv4rqakkrrbPE2H8SGOZIW46u4wD/ADWo2e200nqvQFbWXZz/ AOKsllaC2fpLQBlvyrrlhx1/XLx5/klv0rsSfOcpEr2XWmFLWSwtOQxxaCvASsNs85QEgVkB2Qfe nic+RgaCXuIDQ0cknsF1Ffo3Ulton1lwtFxp6WMAumfCQxoPueylf4V9H2u8XKtu1yhE81D0+ix4 BaC7IJI91OFBqmW8aplsVxs8otFZHJDE+ZuWSFmernsQQOyzLMpuNWWXVUZjhmfMGt63Oc4Na0DJ JPYBb2u0xf7bSPqa61XGnp2Y6pZKdzWNzwMnsFanR21WnrTru51TYTOKMtfBHKAWs62k9vceCt/a tTjVF8rLDdbPKy21UDjCZ2gska3h2Pfla1Sz6UejhmfM1jQ98j3BrWtGS4nsAPJWyr7DebfF6tfb 6+ljBx1TwOYMn6kK1+gtrrDYdV3itDH1D6KX+4bKAQxpaHcfUe63do1FS66qrjYL1apGUk0Xqwes 3HVHwMj357ELNuvZ3vSkkMU8k7Y42yPkeQ1rWjJcT4AHde+4Wi729odXUFdSsccAzwujz9shWu21 2usdjv15uUokqp7fUujpy88RgNDgRj/Fzhb23Xeg3FN1sN9tcjactE1OZWdJdGeA4fUHPIWkUmhj nkkbHG2R0jzhrWjJJ+gHdeqst9xpI2Oqqerga/hpmicwOP0yOVa7bHbWz6auV6vFZ1Vk9uqHxQFz cem1oB6h9SCQugp6q2bm0l1sl5tk0Ucf97TumiLHBh4a8fXOeR3SxOSk8LJ5JAxjZHvOcNaMk457 BfeSCsigZI+Odkb/AMrnNIB+xI5VsNqdt7XpWoul/qnGrno3yxRAsx6bWZyR9SFumS2Xda13W011 E+GWleXQyPj6XNB/K5TTXalsInfIGtErnnsGgkn9Avq91QB8xkA/4gQrY7XbdWrR1NWamrnmrqKY yBmG/wC7DSWnHuStxPBYt29P3CjmpDTVdG8iOYxgOYT+V36juE18Jbq6UxidO6TpjEhd3w0ZKze+ fBy54I8FWx2u26tGjbXPqW6uFVUxdRBDTiIAlpGD3W1rrdp/d7S9Sz0RT3Cic5jJ2MALHdx9wR3C i6qm0b5urgv/AEC+j5ZwM5efurY7YaCtGidPz6jvBbVSluero4Y3PT09J78+V77vY9Pbt6Rkmo4o 6avpC5rZI2AdDhzg47grVmptj50p4JZc5y5p+6z9aYjJcSrY7XaBs+iNNTahvZirJZo+ol0eWsYe A3pOc8+V9tR6WsG6ejv4lZoYKO40oc0enGGtDhyWHHf7ov8AVRGzTtOWvLfuV9X1dSWf7xx9uVa/ bbQNj0RpWTUF/EVXUVEeXF8fUxrTjDek/XysdW6O09uXpAXjT0FPRV1I0tc2OMMacclpwP1BV1Ta p0VTUNOepzT75wvo+qqXD5pXH9cq123+31g0TpSW86kip62oqWA5kYHsDcZa0Ajg/VfHXGgrBuBp SK/aWgp6Gqp2EOjZGGMcByWkAdx7qXfolVUZUTxnLHuBP1X2NZVOjIe92PorUaG2709ojS01z1ZS 0ldU1HYvb6rOkjLQMj5SvJuHt1YtXaWi1Bo+CmpJImYfDGwMY8DuCAO4KaXarsVZUxuy17gT7nC+ s1fUubhz3fZWl0btvp3Q+mH3HV9LR3CrqABiRokZ7joy3LeFr9ytsLFf9Ow6i0ZBBTsa3MkLG9DX NzgnHggqfJ7Vmp66qb+V7hn6r6y19WRgvfg91aTS22ml9D6WdcdW01Lcamoa3LJ2B7Q7viMkZHHj 6LU7l7WWK52WHUmkGxQUJaHTxR/lDM4Lmj3HsrJUvSt8Fxq489L3D9U6m41kkZbLK/pPglWjfbtq 9N6eo8W+ju8jWhjncOlccZy4LHX22Wl7zoB98stsNmqI4jN6fQWlw/yuaexVku9G9Taokji92XE5 XndyVsLlTmnqnMzkBa93dLD2xSPdMpEKoOwS+qflCIEIQEGKyPKRHsmcYQJCEIoR2CWUFUBPKAgI KBYTHCPKMIGeQllMJO4IUBlAHlHb7pjsoApE5TykUAO6Psgd0HCAwjCyCR7oMUwnhYoMkfVIcJ/y VAjsgd00CCYCXujKAQUHujhAd0BHdHZAwhLP6J9kC8o7o8IOEARlLsmhAh3KaAPZGeEATwkPKflL ygDjCOyZKWUDSIxygFLOSgCml5+hQoGjKQTPZAIKWeU+6IXhPH8kfdLCKOyEFMIFg8rFZDuhBYM9 +Fg9ZlYOXzntcPud/wDEcH/5o3H7FRtDw0fZSTuhxaYx/wDNB/RRtH27Y4Xq8f8Aq4Z+3ml/MsFn Jy5YhdnEkIQgEIQgEIQg9lvq5KWdskTyxzTkEHsp10JvnLZbb+GuVM6pIb0jng/dQDE3qcup0/o3 UOoGF9ntU9VGPLBjP2ygmyy782+hrKioZZmw+pk9EWA0n3Xgt++AGrKi6VdG5sEvSPTY7OMeeVGM G2+rpqmSnj0/W+tH+Zhbgj9yvDT6P1DNdpLbHaKo1zPzQ9GHBGVjGfELZZa2Oaa2SZYCGkgHuvXN 8QmnJJmSyWtz5WflcW8t+yr83a/Wnq+n/Zuv6++Oj/31k7avW7Qc6ZuQ+ojz/qip5f8AEbZ21JmF BKXBpaBnuuN03vVRUOrbjdamhe2Oqk6wGHJCi5+3GsA4sdpy49QHI9ErVUOmL3XVj6SktdXLVMOH RNiPU0+xCu+tM3GW7Szrjdqz6l1hb6+qtjzR0wx8xyXH7Lfay+ICnk06bfpeldTyub0+oeAwY5wP dQRV6YvdJXsoaq1VkNW/8sT4iHH9FhetL3yywsku1qraSJ35XyxOa0/qrbb7MccZ6auvq5qyqknq HuklkJc5xOSSvgzl3cBYngnKB9Flv0sptBurpXSNgjpZ6SdtQAOtzRnJ8nK5/fLcXTetGU77Xb5W V8ZH+0vcR8v+XCg7rIPBKzDs/dWWxnLGX2njYnc606QpZoLq2QFzy8OaMg5UpP3y0bBUTV1NTTur HtwXZI6sDhVDtlruFxcRbqKpqiO4hjc8/wAlspNMX+Bpkks1zY1vJLqV4AH7J0zcYuNs5qCbVNdX XqeP02zvLYx04+UdlnrTcXTmiL1WfiaWcXFzcmTw/jhQLpDfW7aZtMdDFRUpbGA3t0nj6YXLbobo 3HXccMddBBFFC7qb0NHUT91rHXfJzuF64vPqzcGpu+vG6jbGwSRPHpNIx8o7ZXTa13zuWotKS2V1 HBFFM0Ne4cnChVx6nZcsDlMs7bt0x8eOOPGG45cShpwR90soB591h0WC+HrWGkdKUr5bxJOy4Ody f8OB2wtpv/rjRmrbUHW99TLdWEek4cNHPOR9lXGIuJAbnJXoqKSrjb1yQStaecuY4D98LeGVx7jl 5PHM9b+E/wDw9at0hpSilnu1RLFcXn5yexAPGF9PiH1lozVdviqLbUVE11YQ2MgDoxnnKruzr4A7 n2WUsUzW5ka5o/4mkKY5XG7hlhMtb+Fivh51bozStvfPcqyaK5Sn+8BHHHbC+HxF6p0dqmCCstNZ US3VmGgBo6C36+yrw3rBwDys3Nkxk5/YpjlcfRlhMtb+Flfh21Vo/S9pknuFdJDcZTmQOHA+y8Px C6n0jf6uhutmrpp7pG5rXM6fkLAc8+QVXdhIPHdN7XEZLh/0UxyuPpq4zL2uRprdXSOpNEfw3UFX +DL4/SkYDg/oV77buHoTRelfwNjuLqlsYwxjzkn7lUrY57RgOAx7lPrkIwHg/YpyutFwxt38ryz7 h6IvelnW6rvQgZUR9L/TOHNzzwVoLTLtDYbW9rHUNZK3L/WqYmySl3uHEZyqdCSQDAeAfqViZpD/ AIwT9CrzutHCb2u9BuJovVGlnUFyuopoyQCM4d8pyPf2X11LrzRN60pVW6W/NiY1o6XtAL8t5Bx5 5Co2yaQE8jH1Q6RzjjqafoFJbPRcZVydGbp6a1Rpya0asnhAaDGXTDAkb4OPda/czd6xaV0nHZdE yRSyOj9Nro/yxtxjP3VRRI9vnH6rCZzyOrq6k2vGJM2mqqG4a4ppL9c/wNMx3qmQ9nOByArN7kak 0netLuij1HTRS0xE8Tm/Nl7OWgj6lUWhkOflyvQZnkYL/wCauOVxu4zn45nONXP03r/Smv8ASYoN UzQQzx4Dg93Tlw7Obha/cjdPTmn7XSaesZiqaUgMlDOWiPyP1CqA2WVp+V5H64WEkkjnZcQ4++VZ nZdpl4cbNVbyq0vtbqzT9NPb6umsdQ75jLA4B/bkOB4K6fUWt9MaU0VS2yG5MrwxrYh6bh1EDHJV HYqqZo+VxA+5TlqZnfmeTj6rO+9tcdzS8etKjS25Wl6GN+o4bc0OEo5aXA4xggrmLpHttoSgts9O +KuuUUjCKiKUl+QclxGcKoUddOwfI8gfRyxdWzSn55HO+5JV2cV+r5ddOaqZYro2/wBNTMoZvxQj c4Ev47HnheDcS+WCup7Lf47vTE2upE4ga8EyA8EfRUciralrOlsrw32ysJayoLcGRxH3Km/o47X2 vtRp7UtVYL4L5SwNtzzUiNxBL8jseeFz+7l8txoLRqq13WjfU2qT1mUznAmUOIBA54OFSuK41fT0 iWTp9uo4RNW1LmBpkeW+AXEhWZVLhF4Z5dHbqWe219dWNhmgcHdBl6C05Bc0j2K57c3eG16duFut NnEdSyklY6V2chob2APlVCp62thZiOZ7Qf8AKSvNUzzSP6nuJce5JyU5fZwk9L1VUWkdz6C1Xaor xE6EjLBN0HGcuaR91F/xLbj2ue1HSto6J2s6RJKDkM6ewB8qtcNxrYIumGeVjfZriF4qmaSV5dK4 lx5JJyVcc7O2b4ca+Mhy4/dYJpLDsEIQgalHYKxG+a+tzBUw04p3eu50rsAhvOB9VFy9lvr56GUS U8jo3js5pwUvay6u4vB8S1A+46CbW0FVT9Vtk/EPb6nzOGMfL9VX3amW36q1dBRavu1WykLSISJi P7w9ufCjSq1Hc6yAw1FbNJG7u1zyQVrqeolgla9ji0g5BBQ0/QyyW6+2a5MgjudLXWBrA1raiTEz R9TjBUVavsWn7ZvTp6axStbUT1LTU0rAOhhzw4e2fZVpj1lewwBtwqT/APRCpE2JvVlGtTcdYXCS J0DRJA9ziQ5490/if1aDXGlKu86v01daaWFsNtmMkrXuwSODwoL+LW50VTdrZT09QySeAOEjAeW5 OQuo361tp+66YFVYr+9t0pj/AHUUJIEgJ5yqoXS4T19W+apldLK7kucckrtj5Lj3PrTz/imd7+Lt YzaV+3Ltr52ahhthvGJup9RGDJkj5cFVoren8Q8R/lBIH2ysfXkAwDgFfBxJJJXF6WWOV3G0tjqd Q6yt9DQvjZMX9eXuwMN5K4de+z3GqtdZHU0Uz4Z4zlr2HBCzljMpcauN1dxeD4gtP3C67a9FvYHy UQE0jQeS1rTnHuqs7T2Ss1Drm3UdAWCRrxM4udgBreStVW6+1HWUslPPdqp0Tx0ub6hwQtHaLxWW mujqqCofBUM/K9hIKtm/HPH8Rnxz8edznyuh8Stmr6/bpstGzrZQO9acA8hgGCR7qtOztlrdQa6t lNbukvikbUPLnYAY05P6rS3HcHUdfRS0tRdap8Erel7DIcEfVaSxXuuste2stdTJT1DQQHxuIOD4 UkmuLWNuN5Rcj4o7TWVugG1dI3MVDJ6s+Dg9B4z9VXXZOx3C967oGW3DjTyNqJC52AGNIJXP3XcX Udzt8tFWXOplp5Rh7HSEhw9itNYNR3KwVwrLVVSU1QAW9UbsHB8K3vpFtfiltFbVaZo7jAzqpKJ5 NQc4IDiADj7rL4Yqunn0JW0UU7DVevI4x55AIABVZLzuLqS722ahr7pUzUsoAfG9xIPOVrtNaruu m6s1Noq5aeVzeklhxkK+S3OYy/C+OcMcp9rbbMaLv+mdQ3Wqv0LYoJIi2NwlDwfmJz9OF2Oj7ZQG 46jvlDBDNcKirfGJQc9bWtbgZ9sqnz93tXSMc195q8OaQcvzwfC8lk3N1HZIHw265zwxPcXloecE nysYzWy25LB3zbbWG4F9qZ9S1bbPTR807GgTt79sdQwuv2+srrft1eNOUtSyqrqWWogJbhpc4/lO M8ZVXxvPrAnIvNUD/wAxWstu5eo6C51NfS3KaOqqTmVwd+c9+VuXV2zcdzS3umLBX0u1NXY6qMC6 PppgYeoEgvzhaXayqp7zt9WaUbK6ivNMyWCWOQYcxxJ+YDyFW4bwatFW+rF1mE7mBhd5LRkgfzXP 0GuLxR36S8U1bJHcHuc90rTgknvlZnx/F1vf9XL0vTV+krJXXXWd2bNOWCMdQA6GMJ6QD/izkn9V ADd2tRxXaahsla400lQ4Qs6RklzuAP1K4PVe5uo9S0LKS618k0LT1BvYZXIUldPS1MdRC8skjcHs cO4IOQVu3ljYYzjlyX7rHaiG2T3tDv7QinBIGCevIz/LK5/TNXHrTat9stNW2K7Qxta8PGHRytcH dvuFXNm+msGwhj7k53GMuAXLaa17d9PXZ9wtdUYaiTPURyHZ9wsTHU01y9rkafdWaW0jcLlrWth/ F1OZZS0Y6T0hobjyePCgWxbtaqdX0tms07pWl/owRtYCTzwOVH2stzr9qulip7rVmSNhyGgYXKWi 81VpulPX0UroqmB4kY9vcEKyJbu7q9Wta2/023bKmjjebl6TDUNDMuaCPn4Wn17TXO6bUWsadifU zgQOLIeXFoHOPsq+zb8asmppIpK1gbI0td8o7EY9l4NK7w6j09bvwVBWt/DhxcGuaCR9OVuZasc+ G5rayGlae5U+y9xgvMU0Nd6VTlk/DsYOO/0XMfC7SXCGmu75YpmW94Z6L3A9Lngnq6f5KGNVby6i 1BbDQ11Sz0XHJ6G4P7o0jvLqLTVnjtlBVMNMxxcwPaCW55IS5/px/uzj+1y+3u3M/HQblVEN0ErH Cra6IyZGYy/IIz4/6KxG7NNcq7T9hjs0c8zXVMfq+iCR0YGSceFUfXeurjrC6Q191e188UYiaQ3G Ggk/1K63S++GpbHZ4bdDPHJFEMMdK3qIHtyp5cvyZ867YZcPHMPq7Tv8SFtqLjpG1R0zC5oqmtc/ /Czq4BJ8DJURz7d680JNG+h9SohquC+2Oe8ccjqGAR91objvRfq7T9TZ6l8L6WYYOW8gZzx+q99i 361LarbDRtkhmZC3pa57cux91Pc0xv5WRqhUna+2m5dYrAKUy+p+YO9Vmc5/VaDfOa9xG1/wIV5G JC/8GxzjnjH5Qq+az3kvupKaGGqlZE1jur+6HTk/Vbq0fEHqOht9PSv/AA8wiaGB72/Mce/urvU1 Df7Spe3hbPLsZAbg15qhFAZPUB6g7znPIKpfV/75308qTtxN27zrKkZT1j42QN7sjGAfuoslf1PJ W+X/ABzD6c5j+9y+3zKSaSw2AFk3usSsgg63biKebVlpZSse+T8Ux2GAkhocCf5K3XxBXqts2nrd JRuc2J0w9UeDgggH9Qqi7Zaun0TqWK70sccsjGuZ0P7EOGFKesd95tT6XrLTWWykLKloHXzlpBBB H14Vwsxy3Vvc0lTbXcP/ALQNV0sFZRwRPpYZHADJzkAeV59W6xvVv3cis8FXNHRSVELBF4c1wGSP pyVWLSerK/Td9hudsmMU0R9+HDyD9Cpyh+I+aRrTPaKZ7h75PK5XG3e13N42fD3/ABXQM/EWeRrQ 17mvBd78jC4Xbza656m0XVagt16jpBHJKz8P6RJd0D/MD5+y5rdDcir1ncPUn/u4GnLIs5DOOcLV 6W3Hv2mbdNQWuvfDSSuc50fcZIwf3XfLOXj/ABy8eHGX+uSugfHUubJy4O5XiPuvVXzuqZnSOOS4 5XmWLrfTZBfRo6hgd1gmCVBaj4QJIzR3uLqHq5YenPOOV3ula+vn1fT2mqtU0IttTPI6ozlvS9ru nj657qoehNW3DSl6huNtlLJGH5m54ePIKsFU/EPTT22Y09tFPXyRhvqhwJBHv7rGOPHG4t5Z3K7T VaS06rvrWuaXOjhcADyR0kLk9DXSpr9SxUM9rqac2ps0Mk7uWEnkfYkKtlo3Oudr1SLvDMfULvnb nh7SeWkKWbl8QNDNa6s2+3mlrpmjEnWD83AyeOeF0uV+DekyWnEl61GGuDi5zAAD/wDMwFyW3N0q Lte6WCS3TUwtNNJSSyv7OdkcduDjwq8ad3Rudk1ILnFM6Tqd/fRuPyyNzyFK1138tsloqv4VQOpa 6YdXX1Agu7Engc4Wcu6S97S5Yh1P1QxvLnVbyAOTzG3C53be7G9XkdVBUUz7dSfhJnytwC8Oz0j7 DH7qvGjt17jp/UhrfUdNBK7+/jc7PUM/1UnX3fe1G0VTbLRGmqpyXOc7ByTwSceU6vtJbEqW1jpL dq1jB1PdVzgNHJ5jGFqNuLyy/XyWojo6mAU1EylldKzDetrySAfOMqv+g93a7TuoHVE7n1FDUO/2 iInJP/EM+VIl/wB8bNHZ6qPTtO+nnmc57i4DGXdz90urraasSlQtJ01qMRgud69TgNGTnHZavbi8 0+oLtPXUlJPA2Oijp5HSMwHva45wfOOFAe3e79Vp6+yS1hdUW+peTPEXZOT/AIh9VIGpd7LLFYJI NMxPgmkc5xDmgAdXJI9uVbdruzpJbGvZoG6dLS9zHzu6W9ziQnC+OgL1RaguNyuNuppYI3RRMf1s A6ntzkgjuPqoC213jmsF4lbdC+ottS4ukbnJa4+Qu61XvTZItNuptMRyQSuJBBb0hoPPykHjlXfa Zd3aQqnqbtrcj0l3S6R2AMnAlz/RLQF0o75U3y5W2NzIZfTaepvSXODME/8AvqD9r95HWe5TUt8e +otdQSXeTG4+w9j5XY6s3lslJpv8FpZroiQW8jp6B3yMH3Ua5e3e3g+ntQ9/SXBkTHEAcnEgJ/ov ntnWUtwivtXQF7oZHgl7mdJc4MwVDu1+8zLdNLbdSOfUWqbOHH5jGT4+xXV6s3fsdv0yyh0i7pAb 0DIwYx7jlauV48XKYSZ3N3V0mbTbV0s8jS+KJsT3gDPyiQEr67eVdFX2+/1lrH+yT1b3NPR05Ppj PH3UPbX7xU1JFNZ9Uf39skDgx5+boB7tI9l0ert2rHaNOx0GkXgNDOgHGCz/AK8Kb6007q71EVFt vbKioYX08ToHyADOWh3PCw0JNQ1Vj1RU2lrW0c1XM6MNb0j/AHYzx45UXbYbv0H4Gey6rJloXtLY 3kdWAf8ACVudZbpWSzaeit+kXMEZZ0kgYLfHPvwtcutJpIGoqmlotFWeormtdRxugMoLeodOMHjz 3Xx0nNQz6U1FJZxGKF9RUGIMb0txjwPCjPbfdm119mqLDrBwdTdOIpSM5b/lP28FbPXm6NltVijt 2k5IwxzMOcxoHjBBHk48qb7Wbd9qqekptM2Ce5hrqJksXqhzOsEFhHI88lfHS/4Q6Au5tnR+DMlS YgwYAGfA8KOdA7p2a8WKaw61c0xNaBFMW56h4H0I91sNebnWa02KO26UfD6To8OewAAeMY905bat 7d1rGWgp7Jp2S8sY+3tlYJmvb1DBjIGR918bE2lbtnXttrmmjLp/RLe3T1nGFwOhtzrHqbTk1i1v IwGNoDJnD84Hb7EL1bg7k2az2CO06Ykg/DuZy6MYAHkY91ie9ry9u71xJbobdpw3tsTrf6oEolbl uDGe4+68NCynbtBXsoQDS9EohDeR09Zxhcdo7cjT2stMyWbWbo45IunpkP8AjAPBHsV69wdxrPbL VTWnTz4DSO6Q4x4DQzqGRjwt7m5Wcu8bj9vLtrtwynaNRaq+SOImSOmeQQB/xgjIIPI5XO7x7mS3 ESUNtPp0rQWnpP5v19lKWo73pLVdmp4JdQfhoxh2YnYJ47Fcnqi07cN0NXQUb6CW4RQER1DsCZ7g e+fdawy421jyY89T6VIucrpZy53cnK8Divfc2htS7pIxkheByzWp0wKSyS7IEhGUFAJd00IgzhJP ygnhAu6EJHhVQn5SAR5QDu6XlZHlLjCgE8peUYVDKAEk2jClA4ICDykD4UGRWPn3ysu6xHdA8I4T 8pIAISGQU+3KAJSATCSB+EwEgjKoPKEs4KeeEoMZ7oR/NCATHIS8oBQBQn+6SAPCCcIQgD3R5QhA YQhCAAQUd0IAdkDlCOwQBKWMc5RgeUzhAvCQ4CePCeAAgRR3QR7I8pQh3R3QhQNLsg9keUAU0kzy UC8Jg4CSf3QL9Uce6Eufp+6CwpWBHCzIx9Vj4XzXtcFul/8AEyP/AOeD+hUdtPyn3wpD3Q/+JsHt 6w/oVHjexP0Xr8X+rhn7eST83CwWT/zJLs40kIQgEIQgEITHdB1m29mhvWp6SkqeYnuy4e4CuLfJ 6bQG3VRXWuliDoIgWjHk8Kp2zUkcOsqN8rg1oJGSrYbqUM962tr6a1RmpmMTS1jO56SCf5JPbOe9 dOU2T1y++zzive38SX/MXHkgqU4NL0FLf57wwf3kwBe4n29lAHw8aSmnrpLhWRzRsa7pDe3burJS TUM/Xb2yg4YWOaHcgEYx91E25WzakfdtaVlHA6I01M5rGyRn82c5yt7f57nS3ET0oH4CKF0knUOO OSM/ZcHoDTrtM6yuNHHFK2mMofA6Q56wSfPlbrcK9Xpt1bZrHSNqH1kDmvL8lrAQQTx55Sd1bdR0 +nrpTX0tq6TPpujyfoU2aepIbybjSQxMle7+9LRjq+v3Wr27slRYLXHQVT2OmbG0ktzwT45Xn0Xq Geuv13oHDqjhqnsGT257om0Tb93+TT25Nqq4Wh3RCMg+2SpTp6eh3D0MYLtTiWnmiB+bktyO4+oU H/FLFJNruiiiDnPNO0NAGTnJU67WwPoNE07appixC0Hq4xgLt/kXWWGvpw8Ev48lGdaWiOxanuNt ge58VPM6NrndyAfK0oGSPfK6rdGVkuu7y+N7XtNS/BacjuuWYcvCz5dTO69O3ituEt9pT0lsjqbU 1pbcKGSgZG9oc1kspDiD9gVvoPhz1d6XqPktvGcs9dwP6fKpX+F2aaTTLBM5zg0uDQT2HhbLXe7V PozWEtDcoZJohE17OjwT3XPHeW9N266rebS6YpNM6XdFT0kcVfEz58DLi7HP3Wx0LerrezVR3qlk gAkewNfEWhzR2PPcFV+r9+ri/UM1XZaeOGmdgCOQkk/VTztJqu6aptQrLmz0wQeOnAWrdTi42W5c rddKz7raRpJt4DabWGUkVSWl2Bw1xzkgLfbhbFW3Tmham+U15qZKiBjXGJ7G9Ls9wMcrUb0RVdy3 elgtJL6p/SIyx2MH7pbg6J3Dt+kH3C/Vsc9sja0uY2pLnNB4GRhd/PjJl05/4uVvjlqDX8FYrN4+ ZYELzvWO6yY3JCwX0Zy4DGUE7fDLpChvt/kq7jTmVtOWhnUPlyrO6lulioa3+CXiKmjpJoMAytAa 4diMqHvhNvEklDJb2xRtZC4fOByc+6Piy1JUUstJaI2xiGRokLy0F2c+D4XTxY8rduPlzuOtPFtb oTTdw3NvD6WMVFtpJ8U3OWcqbNS1mnIqmWwXmGkippIAR6jQAQcgjKiz4Ur26pt09AIomiFw6nhv Ls88lav4stRTw1tJaI2RhhYJevpHV3908WMzt38M+XK46k+Xn2Z0Dp64bg3qaOL8RQ0VQWU3zdTM f6qatSz6YlmrdP3mCihhMI5e1rcgg+fdRz8Kd7dWWSah9CFggcQXtbgv85P1XMfFTqedl6hs0ccT Y2tbIZA35znxn2TxyZ22/CeW3CY4z3T2M0BYLjre8zmIVNJRVBbTZPU3p8H6qZ79FpK6z1+mrrSU cOI2nHQ1hII4IK4b4Vby2r07LRNpoYzTu6XSNHzP85P1XNb+6hlqde2+zQxRwGORn9+wYkPUcd/b 6K4Y/k5XXpM8r48sMftKQ0/p7b/QdRW0FppqhsLOs+qwPc7nySna7bp/cXQL56y0UlPFUx9X9zG1 rm+xBA7rb3mubpTbuStew13oxNJZOeoP5wstOVjdV6CdOIhQtqIyQKU9Bbx4IWcdWTcaztnLVRjb 9SbcaOsH4G3W+Gvr2H0/SfA2R735xySF2t00tp7VOgKia9WKktbZYi/qZG2N8fGQerHC4/a3a+js ck+qNVPDnNeXwtl7NGeHHPkrk9zNzX60v9Ppq0zmC1STNikcw4c/Jxx9F0z8c5Wz0zj5LxkvuuA2 dsU39ug+OyfxmjheWODow9rRnhx8dlP++GjrQ/QhFustvpa2aSNjXxwNY5rifcDK6V1PQbc6JpW2 SkYC98cRc78xLzjqJ90btuedL2wOJLn1lOCf+8nhxvOX4Y/yPJPx2S9zTktK7d6R240eLjqqlpa6 pkAMkk8IkAJ7BoI4Wt3Y2rsGrdJR3/SVNTUM8cRlAiYGMkaBkggeVKWu660W+z0U2oWRvtrZGdYk Z1tzg4yF9Keehm0LPUUTGNtz43vY1rcN6CPA9sKSauPXtcvJbykvpV/ZDZebU1WLpfYjFZ4jkNPH rEf6KUd+Nu7HHpahg0/Z6GmrpKhkUckUYYTn3IXbUOtNIXChpbRbroafIbGIoB0k/wDCtruFBbn2 61itmljeypjNN0AEueOwI9lPHZM/Tp5N3Cdo809tvonbnSUVVrGmoqyqmc0PlqYw8Bx/wtz2C5ze 7aKy3LTbdUaNigpfTiD5IYgGxyMHkAeVMm4s9jpYLa/UzInUAkPErOtvV0nHCdxdQO26e8BjbcYu oYGG+nnPb2wtYYzeO/ljPyZTl/Fadi9l5dTVLLtqGF0VmYctjcMGY/8ARdZ8UGhdOWPSVtqLHaKW hqPxBYXws6ctx5x3Uw0+p9LXaOitdrvLYQHNDYYAPmx2aeOy+u51otN3bZaa8PPNW30YcZErvLT9 MLlJLe3e266UNpdG6gqoGz09jussDxlskdK8td9iAtnYdHSN1DbaXVEdXZqKpl6XT1MDmcDvjKuP vRrGp28sVqfZ4YhHJKYujp4DQAeFD25+71h1loh1BPanyXXAMUrzgRO8uCmmtusuVFs5pyko6Z1s oblK8Bpc05d/zOOfK1u+m0umKfQJ1HpuiZbZqdjZDFECWytcRwcnuFye02pdC0doho9R6eirLn6h /v5AHZz2x7KyGtWUM2mqGWukZBZg6IzRPblpYSMAnwAmM3dJldTauGxmyMuop47xqWAx2hpzHC7g zff6Le7wbY6TotZacoKFsVko6wuFRICS3AP1PBU6svVmulZbqOzX2lZHE9p/DQAEyAdm5zwFGnxQ 2OC6UFBNDUn+Lxu6Keka3Lpw53OPbC145Lbv6cvNlZxs+3xuen9n7M6ioXWyGvqZA1gNPI5znHtk gHytbu1sPbaunoavRNK2iqXlkbqXJ6XgnuSTwQFv9qtvrfoCxf2l1g9guDWdYDzlsAxwB/xFeXSG 49RrjdqlihJjtkIeYo/82B+Y/Vc7lxnKu0lyuo9Nq2c2805abdb9VRQVV0ndgzSSOYXOPgAHsFCO /u0cmiLg642gGXT9Q7MZ7mAn/CfcexVldwbfYa3Ur3X8xetHRsNJ1vLSH9ZOW4PJzhc18VHG10Ad 5kj/AKLt4/HMrJ9uWfkuM3r5UjdwSkvpKMPP3XzXJ3CEIQC+kcZccAFYBS58OV3jtO4NE11LDUGr IgHqNz058hBFrad3gFe202qrulwgo6GF81TM8Rxxt7lx7BfoBqOq03pSvhdLQ0jKu5zgdTom4J4B JPjhQb8RdJaNO6ntGodNSQxXOWQukMDwRlvY4C3PHaz+SfDoNG/DjZodLuk1W6ea6ujL/wC5lLGx ccNx5wVAWitC3PVWpjarS0kMfiWYjLYmZI6irhbO6grtS7dG43SUyTvMjeo+wCi/4WWY1NqJ+O7B +3WVxuWpt0uPdjoW7EaJMbba+sqnXb0DkiowOrGM9P38Kre4mirnorUM1sukZDhl0UwHyyszw4K3 0Nkt79bOvbZ5P4q27mAs9bgx9I46P17qLvjDAF/sp8/h3f8AmXfHDk45Z8ZP6gig0JqS42KS9UVn rZ7Yzq6p42ZaOnv9eFy7mdJIKsHoneaHT+20mm5Lb1u6JGNla/A+YeR+qgKrIdK4gYGVnU47+XT5 0+Iyu92r29uevb42joB6dOzDqiocD0xt/wCp8LhIx8wVvPg9jDLDfHjuZGf0WS3UZ3j4cdMzUFTR 2a51kd6jhEjBLIHMye3UMdjjwq7jQN+dqz+zpoJRdevpMfScY/zZ/wAuOcq3ulLLT0uq7deYamof V109VFUNdL1Nw3PSAPGP9VGe8+o67Sm8Yulre1lQ2kaCXDILTkELXHrL+LO7JPl5dXbAW3T22tZd pq6qfeaWASuDSDEXZGRjGcKKts9trlri+MpaNj46NhBqKgt+VjfIB/zeytbrC6TXbYasuFUQ6aoo Q93GBkkLSfDC3o0XdpGjDvxLh+wXnvk/XHKfLfHXKX3HK6n+G61fwut/std6ue604BEFUWFp84y1 oIyOygC16KvVz1CLLTUEzriJPTfEWken7l3sB7q42grCLZqClucNfU1AudNJJNHK4ENeCO2Puom1 1q+t0ZvNeq22CP1JOlj2ubkFpaP55XXV42/TF6zmP21+4+xVHpLb03llzqZLlC1nrwuDTEXE4PTw CP3K4PazbC5a6u4ihD4LdGczVLhgAeQ33KsvvNVur9lTWVAAkqI4JHAdskgo+HsentRKW/LiWfBH hdMpOGN+1w9ZW/CONZfDrBT2GoqdJXOor6+mcRJBN0gOwOQMDIKhDTmjLxqC/i0W+kk/Fh/RIHjA i9+o+Fcba+1T2m9TdddU1MdZRsqHCY5HqE5JH05x+iiK5a1rdE7v6mdbo4i2sqhHIHtz7YIXLP8A SW34ak3ZJ8tButsnHofSVJdIbnLU1DpGxzROYA0ZH+EjnuFzm0W1Nw15dHF5lpLRDn1arp844DQe Ccqw/wARcv4nbq3vkHMtRG4/q0lezbQPptio3U7zDIYJS17eC09RGVvGTKY2f+TjMreX8Q5uNsDU WKwPumnbjJd44CfXiMQa5jR3Ix3x5CizROh7tq+9xW60xOeScySEfLG3ySf9Fc3QFpqbBW3e3TXG aup3xRVLDKOWl+eofXkKDdD67qNIa2udBRU0L4q6vEbst/Jl+Mj91bhrG5fRhnb5J4/nTnd4dnf7 AWugrIrqa5lTIYjG6HoLOM5znn9gtftLtHc9dzPlfMaC1xD5ql0fUXHHAa3IyPqp4+KUh2m7M13m od/5Ct5bnz02xVuNFMaad1LBGJWd29Tmgn9iueW8da+Xbj+lzv2gHdLY+v0hZm3a3VpulCP965kf SYx4PBOQuH280JdNaXuOhtrelgIMs5GWxt8n6n6K5mgLdU22132yXCrdcIqWQsjkkHdjmAgEfqoX 2Z11Jp++/wBm4aWB9PWV+GuIw5hc7BWbnxx5UmG7qI43e2un29rKKN1xbXxVLXOa8R9BBB7EZK9e 1mzN31zSy1zqhtstwyI6iWIv9Rw74AI4+qlP4qmtkuFjbJ+X05T/AEUkXCCq/wCzmw0FprDbpKlt PB6rGA4DwAeOF6MsZvGT5m3n8eWVxuV+9Kxbq7PXXQkUFWKhtztcoGauKIsEbz4cMnAPGDlaPbXb 28a5u/4O3AxU8fM9U9pLIh4+5+ytra6acbZ3+23edte6jNTTCR7MBzWt44Ocd/dRr8POuzR1FHpT 8BD/AH0r3Cobw4gjPI84wsan4/yT064XlncJ7Q5uvtzVaBvNPb6qtjrGzU4nErGFmOSCMEn2W523 2WvesbZLcDUw2ylbj0pKlhIl5wexGFJHxORsk1xYxI0H/Z48A+czEKWNa0lbVWS0Wez1bLc6sLmO eGZADYy7GB9lw8nkmF7dJ47cZl9qi7l7Y3rQdXHHc+ielm/3dVCD0OPlvPYrHbTbe766rnU9vLae mjB66qVpLGnGQOPdWk1JFNdNjLgL4I6qrhp35e4Z+djyA4fsuc+H3XMNW2l0vHb4oJYIn5mZx1gD IJ+qY+TlhM/tnXdx+YrXrvR9bo/UNRabjNFLJDg+pCT0uBGR358rt9DbGal1RZo7mJqW3wSH+7bU 9XW9p7OAHGP1XS7tUsdXvZEyoY18ZqaVrmkZyCGcKcdxaW71X4K1aeq4aGP03zPBBAIYQQ0Y7L2Z +OTPjPp5fD5LnhMqp1uDoa76KvBoLtFnPMU7M9Erfcf9F7duNrr/AK9jqJbX6MFNFwZ6gkMc72aQ DyrJ7uNjvWyUFxuMUclX6UMnqFvLSSAcHwvpsJreivFvjsNHbG0b6GmaZHsI6ZCOM4A7nhcs8eGM yvp3wnLevhUHWGnqzS18q7TcC01FNIWOLDlp88Lnj3UufEYAdyLyR39b/wDFCiR3dAieOVj4TKXl BkOyyasAsgEH0b2WWHHjldrtFpmz6q1XFbb/AF8lFTStd0PjwCX+Bk+6neL4bbNTSVjrne6uOlEw FM9oYCWEAAO475UVVcdR75C7/TG1erNR2N12tlvBoxkgySBhcAM5APcLfa625G3esqH8awXCyvmb JGXYDnsBHU1wHlWq0PqK06i0nJPZIDBRQNdC2MjHSA3srZZqX5THuWz1H5/VNPJHM5kgLXNPOV2N o2u1Xd9OPvdHbHPoGBxy5wa4hoySGnkhZ089uo9dQVF2pfxVvjqMzQg46m5VxbNfLVftvquqskb4 6COCSFjXDBHS3CT/AHmNTO8cOSgM0RjJaQQRxgr5tY4jstvfIQy5SYGPmKnTb7Ruh7xs9V1dd+F/ jzIpv7wzYkY4ctw3P2WvJjxyuMTHLljtXMgoC9FdGIqh7GnIBwvg0H+aw29dvppaqoihp4nSTSOD GMaMlxJwP5rtbxthq+y22avuNkqoKWHBfIS1wAPngqWPhN05bqp1wu9VTiWspXhsTnchoIOeFLVh 1FeLrquS33a2sZZ62J4hJ+Zr+jOf3HhYwy5y2N5eO43Sjj4i445GF2VLtpq+ptkNfT2Gtko5Y/WZ KzBBbjOcZypE1Ht61u7xt1go3S00VRFUOiJBDWfK53fwMlT5rzUFZpE22sgpDLZmkx1TWN4YCQAe O2F14/txcZnLjMvtRantdXVV0dJBE99RI/obGOCXe33W9vmhtT2G3/jLvZq2kpOoN9WRvygntn2V stAWzTN0vl81Ra6SOR3rFsbiwADDQThuODnPK9Omb7U6quFxtGorQBb6qL14BLhzXRnjH+qxbrt1 uOrpR5scnWQQTzx7rqf7BaqFtdXGx3H8GGeoZfSy3p75+2FKVr2+FLvZ+BtlKam20NV6kgeA4MjP v7jJU7ay1S3Sdztza6lJsVRH6Er2ty2J2TjjHbHhYltzuGlykxxl37UattqrbjXw0dvhkqKmYkRx MGXOOM8LYXjTF9skLJLva62jje7pa6eMtDj7Aq3G32ntM0RvurLTRxyvdPK6J7Rw1rRn5B/hzyvZ a61mvae8WHVFpkiYAJovVbg9Dvylp9wc8hbkutudykqj7RIZMAHJOAB3JW/qtK6io6OSqqrPc4qZ g6nSvp3BgHuXdlLO2+iIod5RRvovx1to5JRI6SPqa0YPSXeAc9lO2rtT0tjv0Vqv0A/gVdT9Ale3 LGv5y0/phbyx43VXG71r5UcobfV19bHS0VPNPUvyWxRNLnOwMnAC9NztF0tzGm4UVXStecN9aIsy fpkK3mgtM6d0tZ6/VVqp/wAQ6TqfHyCWt6iAGHuAQey9kQot0tO3K1363S0tVSvwDI3D4yeWuH6L nznw1cLN/wAUmiZI6VrWB5c44DR3J9gthWWa700T31VBXQxs/M6WBzAP1IU0bMaNiG5z4q2kFXR0 hkb6pYS1rx+U58HhThqnUdp/jNZprU8UbaGpgDoZJRhh45BPvnsUxu7Z9M5Tjr+qOUdFV1M/o0sE 88uM9ETC92PfAC+tdR11IfTq4aiB+OrolYWOx74KuJoLTNh0HpSTUcMMk887OvraMu6XHDWNHkdk 6+2WvdrSVQbhSPorrROdF6pZ0vjeBnGDzg+xW9J936Uvg9UkNa1xcTgAc5XrqqOuijaaiGoia78p kjc0H7ZCnD4f9K00+vKp1dSetHSsJilwQGSB3gjzjx9VMepbnYbzV3jSup4IWBgMlMXjpDh05Baf cFZ3+1n01cda/qkgbIzsXA/ROobUMGJPUGRkdQxkK42hdN2TbTSU18ka+pmrGtLpBHksa4fKzGeR nz9V5NX6es26eiXXekhbSXKka5oeGgDLeS048LUxt0xllIqBAZRjpLgV95HTPYPmcR4OVP3w3aTo p9VV9ZX03qS0MbXQOPZrySD/ACUkapl0zq+jvdjvFNT0ddQPeYXYDHOx2c33P0Tjbv8Ai3LVk+1N GuljPLnD9VlNLMR8znEK4eltL2Ha7SklyqwyqrKoAGVzMh2eWtwey1m5Wi7Lr/Rw1RZYo6WsijLj 0swJWt7tOPI8FTW9LevapUUkwfw4j2wvrPJPIzhxd+uVYH4aNJ2uuvlyrbjTCeooQ30evlo6sg8e V3erqPSutdPXejNLTUV3tjz0ljQ0g5wDx3B9lJ3uz4L1ZFQYJJoyMPLT9+6znqag8lzjj6q3tj0f pnbHSX4u+U1JXVs2A58zA9rneOnqHy8eFz27W3dm1Fpsat0syGFvp+pLG1vS2RvbIHghamNukuWp tWOKvqe3W5oH1WU1bUuaQZXkH6qwPw26HtVxmuNzu9E2plpX+nHHM0PjLS3/ACkYz9V0u4OmdIar 0Vcq2z0lPb7lbMmSOCMMIIOMEDGQfdTD996a8k4dVUOd5JOckj3XnK2Fzh9KdwHYHBWvKutMbJJM peVVCEdk0CKOyCkiAlCEFFAQU/CXhAIQUKhJjhCSA+6Mp4SIQCeUgmgMeUEDP1SBRhTQCfZLwnhJ QMLLysR3TQGUHkIxyjHKAzn9EiE+Uncq7GSSAcBBGUB3QOE0Ihd+yOMhHZHlFPwl2KMcoQNLygI7 oDygeco7IAQATykjsgEDkI+yD3QHY+EeEeEeEB5QPdGB9UIBBHKCP3QOyAzykeT5TQDlAsYQe6Cg 8BAihPjwkoDsjyj6oQB7o/VH0TGMfVAkZQmgPCePsscIygsIViVmfKxHcL572o/3TOaKm55Mv+ij 1vDT9l3m6ZxBSt7/AN4T/JcE3lpXp8f+rhl7eR/LkllJ+ZYrs40kIQgEIQgEIQg91tq5KSZkkLi1 4OQQVNmkd9a+y24U01MKh7R0hzncH7hQQzPUOMrvNNbZaq1FSiottsL2EZBfI1mR+pQSZat/pKEz yx2uESyEuwwBrMn6LWWHeyopdQVVzq6NrpJyCWMOAMdhyuSotodaVUs8UNnd6kJw4OlaP255Wut2 3epq+7z26mtchq4XFsjHEDpPtk8IzqJuh+IqE1XrS2gFwGB2IC9bviNoev1DZwZB2cWNyP1USM2Y 1y6V0bbIetozj1Wf9Vm/ZHXgb1fwF5+0rD/qgk9/xIRh8ssVqBlIAHUcDjsuX0lvX/CLtcK+qt4c +qldL0xngE+OVxj9ndbtDz/AJ8sGS0OaT/Vaa1aF1JeKueloLRUSTwktkYR0lpHccqmokC87vU96 1rBeq+1xmOFoY1nc8eefK9e4u+1Xe7L/AAyyU/4CJ46XvacOx7cKL59D6kgvItM1nqWXBwDhERzj 3z2Xx1PonUWmKeOa+2mpo4pDhsjxlpP3CXZJPhz0ri95c4kknJJRFgPDjyFgeEBRpZTbTeqw6VsM VH/DHNkaMOLR3PuuK3s3IteuX0zqK1Mp6iJxJqc/OQfB+iiD1cHAJWWQ7uCk6TSWtp9W6RsNOf7Q WKGtqASRJIwP/keykbU3xBW+CwzUelrd+FlcOlruwb+irLSQTVErIaeN8krzhrGjJJW9u2j9RWqg FbcbNW09Icf30kRDee3KqXXyxpNUXCm1C28tk66xshk6ncgkrsdZ7zag1Pp51oqvRjpXgB4Y3lwC 4qzaWvl7aTarXV1gHcwxFwC9tZt7qymgfLUaeuccTG9TnGndgAeVd2+ySTqOQccklLCzezpJBWJ7 LLTHys298rBZN5QWK2J3H0ro2zdFdBMK5xy948n6Lz797i6V1rQxfw6imNyYR01DjjpHthQfbLdW 18vpW+lnqZP8kUZef5L73ayXW2ta652+rpA84aZ4XMB+2QrLZ6ZuMutp72K3H0jo+x9FbFOy4O5k eOcn6LVfEBrzS2s4KaS1Us/8SY7Bnc7A6PbChK326trZfToqaaok8tijLz+wX1uNquNv6BXUdTTF /wCX1onM6vtkcpLZ6S4y2WrD7F7h6O0dp8R1QqGVr+ZXEZBP0+i5j4gNZaT1bLTVNjhnNzDsSTOd 8pYPGFDdDRVdW4x0lPNO/GS2JheR+gRW2+toy0VdNNAXdvVjLM/ukys9JlhMrLfhZDYvcTRWkdOs jqXTxXB/MxPOXfRc3vXrbS15vdtu+nYqh1zhlDpXyH5HtbyBj7qEaKiqqqQtpYZZnjkiNhcQP0Tr KSrpnAVEEsTj2EjC0n91ccrN6LhMrLfhbm17x6P1FpEW7UxkYJGhskTQR2+q9D94NF6c06y3abdK 5jcMa2TJ6W+Tz9FTymgqp3dNPHJI4ckMaSR+yJ454X9MzXtcPDgQf5qba0ujcN09vtQ6c/hd1q5v w72gPa0Fp4+oXlodwtsNPWSSmtLGEMaSwGIOcTj3PKpvCJ5MiMPJ8hoJwm8yx5D+oEeHAhN30nCb 3FzI919Eah09TwX2pkjLHNeY28EOacj+aWrd0dDXvTctPNcJw+L54fT4eHN/Kf3VMmeq/LmZI84y k/rH1crMrL0zfFjl7i32jt3tL6g07/D9YuieY/lPrMDg8eDz5XObxbz0EVlFh0U4NgMfQ6VowGtx jA/RVkb6pH5gFhIHH6pMrC+LGpS2SuNkg1jFV6nrJIIIf7yMjs5+fKsNuTuJoy5aeL4Ly9tZSH16 b0W5PqAfKCPZUoj6gPldj6rJ8khGOoHH1Ul1dt3GWaXL03ulpDWWlYqbWD4G1EZHU2UZy4f4guO3 u3koDaBp/SDm/hjH0SStAADe3SAqyAuHPUAsJepw75+ysysZvjl9pg+H6vscOsPxmo7g6kbTAPg9 nu+pVg9wdwNG1FNQ3Bl4ZLVW6cTwxR89bu2D9MKjrOtp4Iws3yyds8BTemtLs6zvG3+41nt7bzfD Tthd6oZE8A5IwQcgrlNXXbaeyUFvo6K0W24EPYHSNjb1AA93O85VUmTSD/Hj9V8nyyF2eouKbXS4 V1sW02oRQ1lLWUtofHh5ZSBrOrscOGF5d/tydPjQ/wDALRVCtmma1oew8MDfJVS455w3Bk6R7Er5 yvkJ+cknwUl1dpljMpqp6+G2e0N1NJdL1dm0clHgxROOBITnOfsp21DedJVurbJeHX6nEtG5zPSB Ba5rvJ9sKiUJkYSWuxj6rJ1XP1AdZI+5SZWeky8cy1v4Xk3EptJa3NKKvVYpoYe8UTx0yc+crnNV 3DQmgaChu2k2UH8UgkawmF3zSMPDs+6qGaqdrf8AeYPsSvhJVTv4c5xH3ype+qsmvS9hvGg9cQ2i +XOqpWVNKeprZJOkj6EZ7Z5UIfEnunSaiP8AALMGvoKd2XTf5nDjj6KBWVU7GYZIR9A5eOZ7nOy8 kkqy3G7hcZl1XyecuJWKEKNBCEIGFMPw32mkuWu6aasr4qNtFicdePnI/wAIyodXppKqWmeHwvcx w7Fpwgud8TsFDddHNudFd6YVFud1Nha8EyhxAIHPdVc01Tyam1Pb7bVXAU7KiUR+vKepsYPnC5+o u1ZUs6Zp5Ht9nPJXljnkilDmkhw5BBVuVvtmYSen6FbdWi26S0gLELzSVPSX/wB61wbnqHtkqJLF NT7N66ZHV3KkuNturMOkhOHQ4ccdQyfdVmivtyDflqp8f85XmnuFVUyB00r3kdskkrPGa01u7Xzi sGl4tVv1iLkw9cfrCP1x0h2OX4z7Y4VZPiE15S6x1VGaFo/C0bTEx/8An5zlRg27XD0fT/EzdGMd PWcYWrmeeo9S1jdembjL7Wa0Pq7Q1NsvLaLh+FFzdFK1zXwhzi89jlVkqcCV2Dkc4WHqOCwJJPKv K8eLUx72yY7pcFYv4Ydwbdp6qqLRdCIoq1zS2YnhrhwAVXJemlmfEQWk57ghZWxf236asml7/cdT y3MupHMMkbHS5bGXZ6zjznhQFqTq3h3Umis1TT0cbacsbJUE9Lg3PPHuoak1LdpqU08lbO6FwwWl xIwvHQ3Opo6gS0sr4pRwHNJBWuV1Z9pJMbLPhfe46TlqtqnaXiraVtUaVsAmLss6hjn3xwo82gu8 Wg79cdEajmpxPJIJY6mJ+WP6h257KsrdZXwNH/pCpH19QrWT3itnrDUyzyPqMg+o5xJ4+q5cJqT6 b5W237XosWmrdoWa6Xytu8stIOr0mvcOmOM4PTj3znn6qvtVa6rd3cm8T2CSmp2cSYqZCOpowOMD vwokqtU3itp3Q1NdPJE7u1zzheS13mttlV69DUSQygY6mOIOFudSz7Ys3Zl8xerXWjK2/wC2sOn6 KeFtZFHE3LyegluM8rkdmLzS2Vtx0DfHMp7jDNIA9r8tk6hyGk+VV4681Ccf+k6v7+o4LVG+1xrv xhqJDVdXX6vUerPvlW5WyT6anW/6u9piyU23VDc7lfLrLMwExwulkyGwt5a0Dwe6ga3afrt1dwb1 dLC6nip2VDJ3iokIJaSMYAHJwFE121debrTiCur55os56XuJH7LzWfUdzs0z5LbVy07ngB/puI6h 9VjKcpZWplZeS726+jrnqjR1HbLWYBVQPY8+q8taeluO4BXO7TXGjuGlazQd1caS6Ugkp5GtcMnJ OS0/RVeG5GpS3H8Uqx/9EK01LqK40l0/iFPVSx1fUXGVrj1Envyrj+sxk+HLhO/6utbaOPbnTtfc NR3aSrmkAb/euBPS0npDf08KAtBaNu2ttX1F7sscBt9PcWSyGWUNcB1dWA3zwoxvmtL1e6dsNwrp p42nqDXuJAK+enNX3iwet/C66amEuPUEbiA7HbK3zvG4/Zjhx8n5J7i5e+2j7rqyyUMdliillpnu kc18gZkFpHC1m39wodb7YHTMFS6julJC2F7HYLmuYQQ4e4yFWQ7p6r6CG3eqGRg4eVorRqi52ivN bbquWCpOcyMcQTnuueXdl+nXlrG4/a6lHLDt1ouoqNT3KSprpwXyueepz3kY6WnyAoM2f0Veb9qm i1LRQRm1Q1xL5HSAO+U5Py9/KibUWtr1qFjG3WumqQz8vW4nC+umte37TlO+C03Cenhe7rMbXEDq 98LOWEuNxMc7jdrS/EJo28ajdQVdppRPFSQymX5wCB34B79ltbNVxbgba0cena/8NcaJsZAP5mSR jgH2BPlVfm3e1bLDIx13qS17S1wLieCMFaDTetLxp2okqLRWTUz5Bh5Y7HV91136v05TCSa/9rh3 WaHRG3VbDqK4/iK6tEj3u6QHGR7cEY9gR3USbBaMvc2p7TqUUrf4Qx0o9b1W5PBH5e/cqGtT64vO o5GSXaslqHMGGl57BbDTG5mo9PW9tFa7lNDShxcIweAT3S39OHw1h+mdzntYT4jdNXaqudHfqOjd PbqCBhqHMcOpgbIXEgdzwV2N1lm1xoy3XPRdcI6+leHsBPIJHS5p9uCVVy5bv6pr6CalqrnK+CZh Y9pPBB7hafSuv73pky/wetkp2y4L2tPB+q53GW7rczvGYrY7h1dNpXamqtV2rWy11RC+NrgMGR5O SceO6jv4dNIXyi1RFe6ygfFbp6dximLgQ4OHHZQVqrWt21NUtqLvVvnkY3pBd4C3umt3tUWW2w0F HcpRTRDpjYeekeycJcZj8M77t+0sbv2S62zcX+01TQzOssVRTSPqGAENDSwHPtyFKWtIrpqGhtN6 0TXRkYMbiOQY5MAkj6eyq5qHd7Ut8s9RbK6vL6SoAbIwgcgEH2+i8mkd0tQ6Wpn0tsrXxwPPV0O5 AP0XfLyW5cnHDwzDDgsbvLUUlj2pbYp6tj60RxxgN/xFpBP2XP8Aw06Vvdpu1XcrnQSU9HU0rfRk eR84PIxhV41VrC46jrn1VynMkr+T4C66yb4artlvp6OGsb6MDBGzLQSGgYHhZ8mXPGYX47dvFb4+ WvltPiQ01dYdWXO7zUUrbbPUdMc+PlJwFBjxg4Uoa23bv2q7M62XOoZJTlzXkdIBBHZRe/kkqM6Y kcJeUdkIG0YWbeCsAmO4QdttXRVlbrK2MoIJZ5W1EcjmxtJLWNcC4n6YVqfiLrq+12e3V9EZGxRS 5kcAekHILer9Qqmbe6xr9E31lztbw2XpdG4OGQWnvkKQdW743fUunqu0VraYwVLQ1x6cHgg8fsku izbx673FumvJLfT1dMx9RE8tjEDD1PLvAA7qwPw9Wyvt+29ZBcaSopah88rhFNGWuwQMcHlU4s93 qLVeKa4Ub+ioppWysd9QcqcKb4jdQFoMkVIfsxS22y34bxsxwuEntGmpbPcYNROpJ6Crjq5XdUUJ hcHvBJAIbjJ7FWe2XttbRbNVlNW0lRBUudUOEUsbmvwRxweVA2pt3rnetSWm9OZTx1ltz6TmtxkE 8g89l10PxH3pw+enox9AzP8Aqpu/k5sZYzLDihvVlDVUF2fHW080EpHU1ssZYS05wRnuFKOlNp/4 ptVPqenu8rKpsUkgphGOg9B5BOc8gLjN1dw59dXCkq6uCGKWniMILBjI6ief3Wjs2ub3Z7VLbaK5 Tw0Umcwteek578LWd558qmM448Y524DoqnNOcgkFfFvj7hE8hmlc9x5JysR3TW2lrPhGqqc2280n qsFS57XiPPJbg8hd7ouS/SarFBcba2CitbpcVHVy7rBxx5GPIVOdHakr9NXeCvt0zoZ4nZBacZHs fopwuPxDV9bZp6dtHDDPIwNE0biHNPuueGH45Y6ZZ3K7bbXN5not6oZbXUOEj5YI3OiOQWuw1wOP C6j4kbvXUVip6OnkLaWrDmTNxkOwQQP5KANGbk1OndVG7Ogjqy9rmSMl5yD5+4K7bXW9NPqzTNVb Kq1whz8GN/UcscDnIXbDyf8AJzynTy5eK8JjjfSRvhonZUaHusDJGuqPxUhMfUOoZaMcLdbZy3Kq vDxW2w0sdviNK+Yvz1vAAxjxwB+6qroTW9fpG/sr7bL0uyBJGT8sjfYqYL18QL6y0zw2+hZR1UvJ kY7PPYn68Ll3rjHpzvLPm2z7vVUO/cjLbP8A3dVU9EwactcwtHf9Vs/iSvFTS0tJb2vApZ2CR7SM /MHcYPhQ3t3uZ/ZfUFVcaqkZWmoYGEvOCwg5yF0W6G7lu1np38G62MiqmvDo5g/Jb7hMNzyXO3pP LqzGY/CVdkpDWbOTRU2JKkmoaWA89RzgLcbdXOrvNyqKytt0lE2npGUjnvPyve15zj279lV7bHce t0TefXgzLRynE0BPDh7/AHUoan35hrbLLBaKQUk0hJcRjByOcj3XXfWnHLG5W1tdD3qooN7q23Qy AQ1tRLHMzvnpb1NKPiTvdTFXUlsLmmm9MVAGOQ7kd1HG1u5lLpi911bcrdHXTVPSWTEgPjcM5wcH uCtru/uXZ9Z2iBkdv9Cuhfls2cnp9s+y3c5crlZ7JjZx18Jb0CXz7DwGBpnlFMT0MOSSHZI+/C3+ 3l0N9mul3FDPSRTsjDfVGOrpBBIPkKsu0m6NTomvdFKHVFrmP95B1Ywcdx7KQ9X74UdVp91HYad1 E5+WuGcjpPt7LyeLC4YzF6c8+Vys+W42ivFXDuTdLUx+aKodNM5h8Pae4Wn+Im9TPvjbc8RiOmaJ GOA+YZbyM/dcxtJubaNNVNdPdaA1FZM/qZUtIDwCMFufZLejXdg1dBT1NupHwXBh6Xvcc9bfAXfx 2Y55W/Lh5cN3DXwnCkqHs2TtNVFG6d0NLTylsfJPS5pP9Ctht/cI7xQ3u6QU09PBVzdcfrM6S8dA HV9eR3Ve9nt3ZNLMdbLt11docD0szkxn2GfH0XXa23ooJdPtoNORupGY6cdi1v0KvXTW7qz7bnYW 9VEeprtZPldSu6qocctd1FpH8lznxB3ySfUb6R0bA6jBayRow7BweVr9mNytO6airn3ekeblLKXC pYclzCB8p+xWr3w1fp/UtRT11la5lUR0zZ/xex+652XLLK2+2rZNa+E+XOv/AIbttY68skkZAyml eIxkkADKWj6mnr9MajrKOJ8VNU1E0kbXs6TgsHOFCuzu8UNotslj1OH1Vt6S2In5iwHu3nuF0O42 8FtfZWUOmHvZG5gY7PBGOMZB54wumF4yY/Tj5JcpXRfDzeJZDdrQ5jDFTn8Q1+Pm+ZxBafpwo/3u vprdVzCOCOGWmeIepnd+HDBP1wtlstuNpfT1rqTc45I7tLIRJK0ZD2Zy3z4yVyW9d+05eLw24aed IHTDM4dwOvPcLW8dZz7axl545X4WG1RcIbVp7Tlxrer8NTyMdKQM4BjIzj7lY2qalqNtLnNbx00s n4h8Y6cYBcT2UUbXbwW+XT8ti1uTPA1oEUxb1F7fY/Ue62G6G7dBPao6DTcuIHNw93Y+2PthcfHv GY4/Ea8vcyk+XV/D/eXVdprrc+GJv4EjokaPmc1xJwftyot3SvrazWz308DaaVkrIZDHx1kSD5j9 cLqNmte6Nsdicap8tPdZctqXH5hJgnpI/QqOd4rlYptR/jtPVMj4qhvXIHcdL8+P6rfhsmGcy930 55y/mxynqLHbjVlHQ02nam6sD6JszhJlvUMGIjkeV4mei/ZirNIMU5gkMYAx8vVkcfZcFoHdWy6h 0wbLrwNe+INDZiM+oB2P0I91nupupQOtf8K07IwUkrcPc1uOPbC1jnrjPpc8NzKT5dhsJeIK7TVR SR0kMEtC703yRjHq9yCfrhQXu/qCM6irpbZB+CEuY5WRu4eQeSfupS2c1foqx6YjDq18NwqADWNk JPzjjj6YUL72/wAIffZZbDVmppJz188FpPcfZY8F4zLl8p5pcvJjcfWkW1chkkcSc85yvK4L6Pxn 5ey+ZRtiUsJlJUCSMoQCRTQUQIOEI7hFJCB3QUBlCEdlQJeUFA7IBA5QEYwUBjBTQhAsfRPhCO6A CMcoHCayBY45WSBwEGJKMoPdPHCAzwkQc8LIBBQYt8p85T8JKg8ppFBQNHnhB90eUCCDyUc8owgA mlhMIAFJPgIPcIF3QnhIoAoHKBlCARjlCCgPpyjx5QEFAIPdCM/qgEDumUuyA8oSP+iZ7IEDz2ST SKgEJpFAI8J9whAscco90I8IBCEce6CwvhYkY/RZLFy+e9iOd0jhlGPJeT/JcG3iMrut0iOih/5n f6Lhc5YT4wvT4/8AWOGXt43/AJikh3dAXZyJCEIBCEIBCEIJA2esVNedWU8VawPiYOvpPYlWs3Mv DtD7fma0xsjlw1jTjhueCVWbYipjptWMdO8NBZgEqyG9lorNS7fPbZ4xUSRhrywHkhvJwt+PVy1l 6cP8i5TGcPbT7GavfdqZ0dbK31w7Dy7kn6qU4bFbLVW1V0aGs9X+8kdnj6lQt8PGj3xQvuVwgexz j+V3BA+3upyqai23VlRbnPbLH0mKRmfGMEfssOnw5TRWpHaj1FcHxyskpIp3RROZ2c0Hhb2/SXGg rKm4sla23U8QcWOGQ7Gc/Zcntpp52mr/AHKj9B0NKJ3Op8nILM8cr769mvl0vtRYLR0R09RTtEsr 2ghoOcgfVRJvXbstMXCG9wyV0LSI5GN6R9cL7QWSljuBr6RkYdIT6nT2cfft3Wu0hZzYbPJb3Tic wRsw8N6fHtytRtnfqi6uroZcemyokZz9D4SS8eTOWU5cEO7xamn07u8KindgNgjDh7jJyFMslBR6 20NLFd4GyxSRdXPcEjOQq+fEBRz1u7X4enidJJJFG1rWjPPKsbplv8H0OTcSIGsgAc55wBhq9H+R P+TDTl/j2/hy2oPqKjjobzWU0GfSilc1uTk4BWvjYZHtYO5IAW11XMybUFfJE4OjdO4tcOxGVrYO JAceVnzSTOyO/ituEt9po0v8P13vtpZWw3ahie4dQhc0kn9QtrL8NOoWUhlbdqB0oaSIS1wJPtlS 38NsskmkaX1HOcQ1w5P1Wp1hvH/ZHWFwo6ilfUBn5OeB+ixjjcpb9LlnMcpjflyGxWmbBZb5LFqJ jm32F5b6MjR8uPLc9wfdSl8QphZttUlrP7kmP5ewxlQXpHUkmrN3WXaSFkAmcT0NJwAOynL4hI3T bZvij5c8xtH3J4XTw2fl69PL/lcr4u/e0aaJ3iobNZoLVY7C415HQ3pwMu/Tkqc9NVtyOmXV+rnx RhzC57Dw0DHblRzsntjQabtQv96DZqosMnIyI2jlcjurqzUu4Bmt2j7bWz2mI9Ln07Cev/3liSW9 +nbK2TU9o6rLBZtYbs1VJaXtprbPK5wLBgADvhdXvNs7p3SGjRdrTcKp1U0taYpXtcHZ8jjIUW6e sN8qdUx2ujjkproHlpbISwsI75Xbbr7dau09p6K56gudPWUuQOhkri5pPbghTLut4frJKhcjnC9d oozXXGnpmuDTLI1nVjtk4Xl8lbvR+P7R2/qIA9dh/msui6W32kbXt1oWW40tKamsbGZHuA+Z5A7B bast9Dubo2anvNFJB1jqYJWEPjJ7EArbzVf4bQvrwQvqXRs6hHGMl36BfXR1zfd7VLcJ6Z9KJGNb 6cmQW4znuuk/1lcMrvKzbktGaRs+2ej6q40kDqypY0kydPzyYOMBe662e27oaMcy7UT6d2OuMyNw +InyFvbjP/DdFzTei6pMXU704x1Od82fC+mk7m68Wea4PgfTCZgAZJwRgH7JbNek3eXtyWk9K2bb HRk9xpYDVztHzSBvzvOcL06g05at09Gn+IUrqaYN64pHNw+J2O66G81QtOiTUvgfU+gQ90cY6icO yvtpi4fxewz3BkLoG1DctY/uOCsOjjtKaXs21mipbjBTmrqGtBe9rfnkJOOP+i+mrNJ2ndTRrZ6i H8LUsBfFM5mHRnHIIXS3+vbZtER1ktO+obT9D3RsHUTg8r1afr23fTlRXwxGBtS1zmMd3ALeFrXT O+3FaX01Y9qtDm4tpzVz4aXyBuXSOdwsta6Ns+6ej4610YpKtjC+Kfo+Zhxkgj2XTanuUFj0XTV1 bBJPHT+m5zI29R4+i99krG3XTE9ZFE6JlUx8jWOGCARwppZXCac05YNp9EtrnUxqqh/T1yBgLnuK W4uhLRuZpGC5QsbR1rWdcU/RggeQQMcLqtW3em09pOhrbhBJNFC6PLWM6iDjuvdb6gXLR8tTDG5g qGOexpGCARwtzGTVc+VtscRZLDpvaTR0NTPTCoklLRJMWBxc4j6+F59z9vbRuLpunu9CI6OsDAY5 gzjp9iBjhdfrW8UGntP2+tu8D5qeIsBDWg4OPqvdBKK/Rr5qWNzWVDXPYzHIa7t2V1Jo5W29uKtd j0xtBo2GarphUSTOa2WYxh5e4+TnwtbuntjZtf2WmvlpEdDW9DT6rGANez2IC7rXl6t2nrZba+8w ulpmODSAwOw4t47r1ukFVowS0kRYyYdbGAdmk5HH2TjNS6TllyvbjbZp/Su0ekad9bSxzyzuDZJp Iw8vcefPhaXdnaa0a4tVLftPiCgrHNbkhvTHIw+4HnnupD3AvNssFJa669xGSmY4twIw/BLR4K9r yKjSUElKzpjkLHsZjGGlwOMfZc7HXbiKHT2kdptLUcdwpIJ5ah4Y+aSIPL3eTz4Wg3c2bter4KK+ aaNPb6iToEg6emORhPB6R/i5UiblXe0WZ1rqr6zqhy9rP7sP+YtA7FbOUB+lqIwt6WOfE5oxjA6g QMfZa4zUrEztys+HDUumtFbVacoYLnR0081RIGGaeIPc93GTk9gua3c2Tt+pZKK86YNPQPncxszQ 3DHtcRhwA8qSdx7tZLTU2+TUEbHxuZK2HqjD/mIAxz9FupRnTlt9PgdcBA+mQs2aaxyttcDBprQW 2dlttvu1DRVFRUO6fVqIWvc93HUckcDlcfuvsVRXq6UV00r6FGyqc1s0WMMwezmgKTtwrrYbZdKc 6jjieJIJGU/qRB/zkgcex7LoJQRbrIGj5fVhz9lrjqxJlbtH0Ol9vdvLfa7VdbbQVFVUHp9apga9 zz2JyR7ridz9gqa46ho7hpV8NJR1sgE8DhgRk+WD/RSjr25afo79FFqKOCSSSmcKUSxB+Hk44z2P ZdLVNeI7G0eJY8/stXGSz/pMM7fn5R9FpTbnQdLarNd7dbqisn4ElVC173k9ySR2yuC3M2Aiq9V0 lVpZ0VNQ18gE0J4ER75YPbHhShr+usFNqp0d9bTOqpKJrKT1mBxDi935c9j2XZ1rf9osgOciQf8A kKcJNJM8spb/AFHMOjdt9GU9rsd2ttvnrZh/vamIOe4nySfqo73C+HkzaypZNNyxQWuufl8bu8J7 np+mFK2vqnT0WqZ4r4Kf8c+libR+o0Fwd1n8vtzhdvXZF0sbefzPz+jFz6dZbajWHQ22ulRa9PXa 2UFTXzN4kqIwZHE+SfqVAXxE7TN0NXtutpcDZax+GsJ5if36ft7KxmvZtPDVdTFdvw5u5ip/wXWP nB6zy325XLfGEP8A6n9uB7/ix/5SppdqWnuksn/mKxUbCEIQC9tvt1XcZTHRU09RJjPTDGXnHvgL xhTh8LV7mtevYqWBrHNrgInlw5A+iCKINPXSdzhBbq2RzXFrgyBxwR4PHBXr03pa5X2/QWihg6q+ WT0xHIenpd5znthX51Nqu06Vu9DQzNip33CbrdKQA3vgk/VV6+IertFu1xbb1pWeBlxkBfPJTu7u B4cceVv8d05/mxvrtIVp2D0tZ9BzR3qkFbdmQPlfUhxaWu6ewwcYBUKbHaCsOpdRVTtS10UdHR4x Tud0mbOfPsFZLb271V42bluFymdNUSQzFz3HJ7FUrZVOgubHZcI+sdYaSCW9XKsm/Hy/rUv78VqL doraG66idYqK0+pVgkZbK/pOO+D1KBd+tvYNB6wNHb5TJb6qP8RA135oxnBaT5x7qxO0tw28rbzR /wBm6B8d39IkveXEjj5u5wos+Lg1Ldc0TahzHx/hA6ItbjALjkH/AKrnGqimPbLVMukzqSO1yPtP SXmVr2kho7np74XEPaWuKnm27tXCi2uOnnWrqpXQugFThwGD9eyguo/3pW7jOO/lmZW5as6fMDJC lbZfays19dGvkzBaIXD15v8AN56R91FkIBeFc/4TGBuhLi8d3T/6LjllqyOsnVr53fYrQt0objb9 OSSU16iYCx5ndI1rvYtzyD2US6B2NvN41bNQ3yF9FQ0UnTUyf58c4afYjyrCaGstoodRUFdbZC6t qmT/AIoesXgkHjLfB5XX2skXPUXsHsx/+DW/is3pEd62J0XdrXcqXS00sN4g/I905e0O74x7Hsos 242Put+1JLDfoJKK30UpZUEnl7hz0tP1HlWB24s1st16oqu2Sl01ZROfVN9Xr+fqHOPB7rrbQMDU bwf/AI4f/wDY2pSekNai2D0ldLRcGaMqpY7tTEgNknL2lw56SPr7qN9rtkbrqC/y/wAchkorZRy9 FQSel0jgeWNPj7qf9srNQWy601Rbah8j6y3iWpYZesB/V3+mc/yXUWx5ZZtTPbw4VVRg/wDcCk96 MukM6x+H/T9wslZLoWqlFzpXEGGaXra8ju33B9io92m2UuOp7xI6+xTUVrpJDHPk9D5Hju1pwe3l WK2yslHZbzL/AA2okliqrfDUSh8vX/eEnJ+mf9FtC50eldUOjJY4VFUQR3HHdak3dM26m0O642Cs 9Rp6pqNCVM0lwo3uD4JpesS47tHs72UHaI0NW6n1hBYWn8JUPc4SGYEGPp/MMe6uBtxaKayX6tp6 GWZ8E9DBUOEkpf8AOS4Eg/XAXBbT0lrk3n1JNUveLlHPJ+GaDwc56v5KYazwyynw6TUy1Tuvw7aY loKmgtdxq4r2yASMMsgc3JzgkYGQSCoF0ft3Xag17Hpt0jIJWyObO/OQ1rOXY+uOysT8QWoRpO8W y82etdFe2N9J8J5Y6I5wSPvlc18NFRQXrWF1utwmeb44l8bBgNLXA9RwlmozK9t/+HXTz7bXQafu tX/F4WB7W1Egc0ecEADghQToHQFdqzWDbLE5kRjJM7ycdLWn5sfX2Vgt9dRDRepae8WGuxdpWmKp pX8sLOnDXYWs+F5tsrrrdLlNO/8AjbnO/u+OksdySP1Tz68WMv2nj3lu/EY6l+HW0fwm4f2XvFZL dKUZ9Cqcwt7Zx8rQRkdlyO1WxtTqVk9bqN01BbmghhYQHuI88jspC3f1GdG6y/iFiuPVW1UToquk eMtbhoDT+xC76uY6s2ts0Ynkp/xLaZj5Iz0uAc4A4P6rpcNWT7Ywz5Y7QLupsZ/ArNDeNIz1Nzt4 Z1Tsfhz2j/M3pHI918NpNjZtVW6W5ahmqrbQFuYOgAPf56iHA8YVitAUDrfpa821881RFTVE0Mbp jl3R0AgH91hd6Z9boOyULaiWlZUup4XyRODXNa7g4P2XOS326fPSuO7eyc2laGG66dqJrnaHMHqO IBew+/HghenajYubU1omumo56m10Lm5p+gDrd7ucHDtjsrA6VpX2/Qd+t8076llHLUQRvl5JYGjG f3Xq1LbzctN2S1isnpI6ksjfJCcOx6ZOP3V10e5uKwbv7NVOioYbjbal9wssjQHTloDo3H3A4weM FbTa7YqfUNmlu2oqqW1UTm5g6QC9w8lwI4HsrB2uikpttLhb66Y1Zpm1EPXIPztaTjj9F9daUTrt bbHa21c9HDWOLZHwY6sCIuA547gKWeiXrdVf3b2drdDyQ1NLNJcbTNgCcMw5j/ZwHg+Ctzt1sLVa gshut/uD7RTPwYWemHOcO2XZIxyp/jbIdqfSrJTUyRn0zI8cu6ZsA/yXo3It093gtlohrZaNlS9/ W+LGT0sLgP3AVmNt0nks8ftVTdfaW5aGrWuBdW2uU4iqWt5z/lcB2K6XQPw/Vt8sTLne7p/BmyEG KN0HqFzT2J+YYOfCnyuZLU7UU4uDhUVLDCHPeMkuEzRlencm21l7dRWmjuMlvjfHLM5zG56iwAtG PvhSTbVmrpUndDbG66GvH4ao66mhmP8As1U1uBJ9COcH6LtNE/D5cr3YIbheLq20OlI9OKSD1D0n GCfmGCfZT9XtNx2+sL7h0z1DpaRznuAJ6vUbkpbkWuvvdXR2633N1vYyF9QelnV1OYQWjGQrMdzZ 2qLuVtxdNEXw0Vc181O85pqpjcNnb9vB+i73SHw73a9afprjX3aG1yznLIJIes9JHynORyfZWEuR /H6c0vNWtZNM6elcXPAJy7utfuZRXSurWMtFzdQNoKP8Z6bW5D3NecD6dlL0TvSnu42h7nom+zW6 5Me5oOYajpw2Zn+Yd/2XFv4OCrofEbCyu2roKmqY19QHRuD8cglhJVMqgYkICurxmTHLduP0+Lgk E0uxUVkAn5SBQ3uqPrGCewyvoA7OC0qQNk7Fp2/6tZQapNQKaVhbEIn9GZPGT3Vgx8P2jLe6okul RWugknApwJsFrXYAaeOefP1WJnLbJ8NZTUlU/Y0uPPAUp6c2Y1RedJSX2AU8EIa57YKguZJI0DOW 8Y5+63G4egoNrte26sZDHcLNJKJ4YJuSA0jLHZ7/AEKsnpXVNPrDQtZcKGmNLAxkkIjzkDpb4/db neUlYy3JtQqaF8chY4EOacFdvt1tff8AXENRPaWRxU8PAlqCWsefIacHJC6PbLbsa71fUxTSiKhp XCWoAOHPaSQA04PsrXabFHbZ/wCB2mifBSUkQJk9MsaXZxgcc8c5V8smGdxhL1uqA6hs1XZLtVW+ vYG1NNIYngHIyPY+y1RafAUp74UM9PuBdDUwyRGSZz2dYx1NJOCPcLv9KUugbhsrPDWRWxl9bBIC 9zQJhIDkEO7+ynk/TPi3jOWPJWojHdC9NexrKhwbyMkArzsB6hn3CRG0sdqrLvXwUVvgkqKqVwax jBk/c+wUiX7ZbWVktNRcKy3xvp4G9TzDMHuA9+kclSl8JNqozarpcXU8ZrYpelkxHzBpb2+yknSN 11BVanMd5jgNsuFO6SHoOfynGCPGQQuWHk/JLZ8OmWFwulKbNZK27XKGgt8L56mZwa1o+vknwPqu y1HtJq/TltkrrnbQ2lZjqfFKJOn6nHhWo0Vpay2bUmpKi30MUVQ2UEOHhrmA9P2zyvjoq73u5Xmp o9RU8T7fcac1MHOR056S3/3vqt2a9pr6Uxs9hrbvdKeht8JmqZndLG5AH6k8ALpdV7Yaq0rbxX3i 2vipOoNMjJBIGk/5sdh9Va3QWmbRpyfU9XbqNjZY6p7Gk8kMDGuDftklGjLndrzX3C2aooovwtZB +KiYcPaY3HHT/LspbJO2N23UUss1juN6ucNBbad89VKcNY3j9yeAt9qbbfVGmKBlZe7ZNT0zndHq dQcAfGcdlbDb7TFo0ozU9bbaUNmiqZWNJOT0NaCG8+Mr76UrbjqCW7WfVtviFPURCpjYXB4MbzgN /TCuj32pXY9P3O+XOO32mllqquTJbGzGSAM9zwFuNSaD1LpuijqL1aqijhkPQ1zyCM/orZbf6VtO krTernaqTNYySZodI7JLWE9LfovrpyqrNXUt5smsbUIoyBJG13J6H9sH6e6ur6S9e1MbHYLlfLpF b7VTSVNZKCWxMwCQBk91sNSaK1Bp2Nj73a6ujZIelrpWjpJ9sgq3GhdNWjR2mrhdLbR+pVsfIOuQ gud0vIAB8L02R0utrPeLLrC2ekYncBw+YNdktIPuPcKb71W+NUrstiuV6uDKG10stXVOBLYo/wA3 Hde/UOkL7p8Rfxq2VNF6uegyt4cR4B91bbRVgtOhdFVV2t9J69YMlz5CC5xDugYOOO69Vr6Nf6cu lp1ZbDFPSv6T1j5hkZa5p8HHkK3GybZ33cVL7JYbpd638LaqOoqqnpLvTibl2PfC9t/0zerD6bbz b6qjdKOpgmZjqA9lbzRGn7VoTQ8t4oKQzVb2B73OOXuJd0gA+B24WdLFT7k6Tr6DU1ufBW0b3Ruc 9uHseBkOH6YU1WtKa2WxXK71L4LXRVNXM1vU5kDOpwHvgL6XzT92s0jI7rQ1dJI8dTWVEZYSP1Vw NEWK1aA0G27W+kknrZ2NL3cGR7nEANB9s44WbqGj3R0TVR36gfTXKie+LrcMPY9ozn7HI4V43W2N /Cm9os1yukro7dSVNVIwdTmwRl5A98BZ3ezXG2TtiudHVUkzm9bWVERjcW+4B8K4ejLFatvtCMuN vo3z11S1pdI0Zke53Ab9Rnwvnc7Zbt0NDzz3ijlpLnby+P1HN6XxvaMkYPg+yaqqc260V9fM9tvp KqpewBzxBGXlo9yAvrc7ZcLfI2O4UtVTSOHUGTxOjLh74I7K4ulrJbNtdGCtttJLVVdZ0lz2tzI4 ubkDjuAV59R2i27o6FdX1lM+kudGHsD3Nw5rm/maR7K8bo/intFQV1Y5/wCCpqmd0Yy70Y3P6R7n A4WNdS1dK/oqop434B6ZGlpwfoVczTdmtu2Oj2TW6CarqqsD5xGDI4kdQBA74Xh1pp60bm6IjvzY nUlwhYR6nSOr5ThzT7hZX50qDRUdZUud+FgnlLBl3pMLsD64CwqY6qNxbKJWu9nAg/zVz7LZrRtb pFtRbaeSorKpoHqBmXSHHUMge3PZarX2lrPuRoyLUlJEKOvYzJf0/mAOC13v9CrDjVRqSCsmJNPH UPLe/psLsffAXznZNlwkD+ocEHuFc+2Wmz7VaPjdSUz6msqQAXhpcZXYzkjxxnt7LUbk6Ms24WlI 9T2wNpK0MDi/o4kbkAg/Ue6a17ZnfpUiCObJ9MPJ7cAlYz+vg5zkdwroUNrse02jo2sgNTUTYJe5 vUJXgZ6iPHH9Fod0tCWjXGnYdV2Xopql7Wukd0cSNJA5A8j3V4ipcUkzCfnIKxqnzOz1uJ+6uhTU GntptIwwOpmVVROQ57nsyJH8ZJz24XJb06CtGo9Lt1hp9jIHPiEsjQ3pEjTxnA7FamFuv6zc57VM dlfM+y9tfAYZnNPg4XjPdZs1dLLtiVie6yISRSAT8ISQCCjugqhA/RMJY5T8IFlCEIAIKAkqBNCS A8ppeU0AhJAQNAHPHZCflSgSCaQUD8oxzlCEAjwkOQjsEDzgJD7IGPKaBf1QD4TSVAe6B3T/ANUu 6ACOfdGUIGexSH1QTgICBo/qkgdkD8o8pe6YQBQjuEvOEAEY4QjCAQO6Mco8oGeEihH9EAUH+aPK PsgEimgoFjjlPCAeEIMU8IzjCZ5QY+E/CCOUY9lAZQR9UeEA+6AKP5IKXlAzwlz7JkHKWR7oLClL jPJxlMnhYuHH81897EZ7pnElDjI5dn+S4hvEbiPZdvunzNQc5z1f6LiTxE5erD/WOGXt4nfmKAg9 0Lq5EhCEAhCEAhCEGwtlZLSTNfE9zHtOWuB5Cl+w753i1W1tM2FkkjRjrecj9lC8DHPcAwEuJwAB yVJWnNm9WXu3itpaWnjiIyBPL0E/yQdXQ7+Xejim6KWAyyEu6vAP2Xi01vXcbXX1NVUU7Z5qh7pH YdgZP0WroNkdY3Bsxp6WkBhcWuDqgDJHstbY9rdUXi4VVHR0UXr00jo5C+UNb1Dg4PlE1Eo0nxF1 cU0kkluaXPAHBHhet3xJVWPltrMn6tXAw7Ea3kkfGKKi62YyPxTV9JNg9c920NF//NNQ6dZP8Rld 6M3pW+ITSDAJwR+y57Re9VRp99S+WjZK+d7pDjgAu5PC1Dtjtbhsrv4dTkxDLgKhpP6e60li2t1Z fZ5oqG1/PESHCWQM5H3VlSyb26cbuyy61df663wSSEBrWtGOkBfHc7ea66uoBQQsFHRf4msPL/uu YZt1qWXUElmZQB1fHjraJG9Iz2+bsvPrbQOodGsgffreYI5iQx7Xh7c+xI7LWW8bq+0x42fr6ck5 3UeVnTPEczXOGQCDjwV8z7FLusNrI6M37o7BZ4KOO0jDGhuWgKOd3NxGa6uFPLFboKRsGT1taA95 PufZRr1eMlZjp+qbNbTNtNudZtIUDYqizwzVI7yloJP6qR634ibRVwelPZY5m+Gva1w/YqrlrttV catlNQQSTzPPysaMldNqDbzVFgoo6262eeCmeQBJwRk9uxVm/hjLXyn+k+Im1x0joZbSWxkn5MAt 58YWLPiGslFTuZb7K2L2DGBo/koQt21etbjRx1VHp+rlhfy1wxz/ADX1l2f16xnUdMVx+wB/1RdR 4rlr2tdrmq1LRsZBUyyueG9wAV9tc7p6g1ha2UN0qG/hWkH02jgribpQ1VurZaSugkgqIXFskbxh zSPBXjc3jPKLogSvvTSuila9pIcDkEL4ZWQxwoqw+1e+rrBQCjvsctQxgwxzecj2K9u5G/38Vs/8 P07TupGvJEj84OFXm2UFVcqplNQQSTzv/KyNuSVvrpoHVVroH1dwsNwgpmDLpXxEABXaWbTRthvw 2y278Hf2STtYMNc3nqH1RuZv5/FbSLbpuB1JC/PqSHuR7AKvdtt9VcKplPRwS1E8hw1kbSSVuLvo rUlppH1NyslwpqZv5pZIXBo/Xsm2eMTrtlv3Ba7X+D1FHJL0DpDm89Q+q8+52/QulqFt0zE6kgd+ d+ecewHhV5t1BWV9Symo4Jaid3DY42lzj+gW0u2ktQWukdU3OzXCkpgQDLNA5rf3KLqLBba7+UdH aBR6jjkkLR05aMhw+q8G6O/LbnbmW3TMbqanPD3+ceAFXehoaytqG01FBLUTO/LHEwucf0C99x0x fLZCZ7haa+lhB5kmp3MaP1Iwmzishtzv5b4rJ+C1OyR7mjpJAyHDC1G6u/H8Too7dpUPpKYDDpP8 XHYBQTQ6ZvlbAJqOz3CohPZ8VO9zT+oC+dw0/d7fD6lwttdTRZx1TQOYM/chE4rMaA35tbrA2j1V G90jR0uw3IcPdaHdbfYXGmit2lA6mpG46pDwTjsAoHpNOXuqgbLS2u4TRO7PipnuB/UBfC5WW6W5 jTcKGrpmuOGmeFzAT+oVOMWj0LvxZKjTzaLVbHGVo6SOnqDh7rnd1d9fxzYKDShdTUceCX9icePs q60lJVVUwipYZZpT2ZGwuP7BFdR1VHP6NbBLBMACWSsLHY+x5Ta8YtrozfPT1w02yl1Y3+9aA1wL eoOx5XK7q77CulgodLGSChh6XF44LiPH2VeqO3V1XG51LTTztb+YxxucB+wXnqaeoppTFURSRSAZ LXtLSB9ipupxi32kt79MXfTkdPqvHrtwHNc3qyR55XI7p78Gsq4KPSznQ0cJDi/sXkeOPCrfTw1F S/06eKSV/fDGlxx+iJIJ2TelJG9sv+VzSHft3ReMXD01vTpO/aegi1Z0CpYQSxzOrkc55+y4/dTf c1ddT0ulpXRUcDg8vAwXkePsq4/hKwNJEUoA7/3bv+i+EkEzB1Pa8Nz5aQEOMXMsO72jtS6fpf7V CL8VEQ/oewOw4c5C4rczfp093p6fTLyyhpnBznYwZCPH2VaIxM44Zk/QAlYmOTrxnB+vCHGLqWfd fQ+prLRTam9AVkJDumVgcWuBzkH7rg9xt+3y3+ni047ooKR4d1dvV+n2Va+mRo5cAvk9r/Lh7qbp xi7Vs3O0Jqi20FbqH8N+NgIcBKwOLHD/AN9cBuBv492pqdunzi30kmc//JFWdvqAfmxlfNxcCeo5 +yu6TGLw0m4+3+pqK3XG+upPx0GHtbKwFzCPv9VHeu9/Xu1ZT/wTItlI/wBv954yqxskf/mAwg9Z dy4FN04xeWDX232pIbbebxLSCvpx1NEgBc0qN9Zb/OdrSnfaMfwykcW+5k8EqsrXSdPyyNA+hXzJ dn8wJ+ii6Xrj1vt9qD+G365z0ja+naXM9QAuafY/bwq9fEHuqda1ot1AA200zssJHL3dupQ2JZA3 AePtleaYkn5kNPm45JKSEIoQhCBhTf8ADBFaG6vdX3i4so3UjQ+EO7Pd55UHr0QVEsBzE4tPuEFu PidqLBd9NR3OhvML7hSHpZAx2fUBPP2wq86AoKXUWrKGgvFy/A0krsPqDz0/uuRlq6iYYkkc4D3K +ccz4nAjwtZZ3KSVjDx44b18v0C02zS1i0SdOQagp5IDG9nqveA75h3UT2DR229g1fLabzVQXqKs ha6KolcAIXZOR8vbKrG26VOMCR//AIkNral0nV1nI7HOSkyvHj8Nam9ro6K0TozR+rH3y3aki9M9 QjpXvb0sa7wDnJwoQ+JnVlu1NrWF1rk9WKjg9Bz/AA53UTkfRRIbnXFmBO/B9nLXTSPe4lxJd55W WqsrQbm6Wbsa/Tcoc24GldCWdAILie+VWac5fwsS9+OVhnlauXWmZjq7fSN2HKxnw0bmUennPsV2 6Y6WpflsufyuPHP0VcM45XoppHNcHMJDgsWNL8UlLpDRVVdtRx3CN5ly9rBL1dAPdoGfJXH6A3lt ty1XX0lxayCCueBHJnAzjAz+iqTLcq58XpvmkdGfBcSF5op5WShzHEEc5ykqL3W+j0pt3Hd722vZ L6hLmtEvUWNOPkAz7+fquX233ftd2v8AcLfcQynjrpi6NxPGSAMH7gKpFTda+eHomqHvZ7FxK8UV TLHIHMcWkc5B5Cir3W+l0xtrQXO6GvZL6rnFoEgcWs7tYBn38rmtsN1rTfrlc7TcQymFbM+SMk4D uoAEE/YKodTd6+oiLJqiR8fs5xIXlp6qeKQPieWvByCO4V38nv2vVbqXTW11sulx/HiV07iWgy9Z DBy1gGfHPP1Wg203Ks2q3XSyXEspjWSyPb82A8P7jPuqg1l5uFVF6dRUyPb7OcSF5KasnppWyQyO a9vYg8hXl8pxmtLx0UGn9qrDcK6St9eaZx6cydRc0EljceMKONhenUO5d41L68NPDG57vRc7kmQH t9sKt9bfLhWRBlVUzSMHPS5xIXytl4rKJ7nUk8kTjwekkZWpnZLJ8rMflY34tLPJ+Mt97jqIn00o /DljXZIIyQV4/hNsjpL3V3x1XAyGmaYDEThxLh3+ygO53u4V8YZV1MsrQcgPcSP5rC03mvtrnOoK mSHrGHdBIys23Luknwnn4q7DUUt+pb368clJWARNDXZLXNHlbP4TLHKZK2+uqIBAA6nMfV84OO+P ZV3ul8uFzY1tbUSytacgPcTgp2a+3G1BwoamWEP5cGOIyp5t+bXL4Tx4zxyyfKbPiUslVatXtur5 Y5KS4N/uy05LHNaAQR/NStoG+WncvbeOwNqHUdwpoWMLQ75g5mOlw9xkKnt2v1wurmfjqqWYM/KH uJwlaL1XWqo9WgnkhfjHVGSCt5eS5XbGHixwx4RdmruVu2x0I6muFY+qr5muc8vf1OfI4YJz7L4a dulr3L0CLZRVjqW4UrW4DXfMx7Pyu+oVM7zqK6XUsNdVSzdPb1HHhY2e/XC1TerQ1MsMjh0kscRl Y9Oml0r3crdtxoOS33Cqkqa2pY9z/UeC5z3jBOfbKVHV0W5+gY6ez3B9HcqUMc0sd80b2jAz9CqZ 3nUlyuzmOr6mWdzBgdbicIsWprpZnvfb6uanLxhxjcRkfVXYubq+8W7b/RAtVXVvqqqZjm/O4dZ6 u5P65X0fNTblaLpZdO3GSluFIWub0P6XRuxggnxkZ5VLb7qS53iVr6+qlmc0YBe4kgL7WDVl3spe bdWT05kGHem4jP3S9kuulyNfXm1aH0TFZp6p885ADetw6z83UXH+fK+17azcrS9FX6VuZp6ynk6h 0P6XNyMOaSO3BKpdfNS3K8zNluFTJO8DALyTwvVpzWN4sJkFsrZqcSfmDHEZSXj6TKcva4O4V8tO jtGQ2WepdNUAxgAkdRDXtcS774K9eoKZ+4Fhtl10ndPw9TG7HU12CGOwHg/UBUqv2pLleao1FwqJ Jpj3c9xJK2Gmtd33T8D4rZXzwRuOS1riBlTa7u9rc691HadHactdnnqTUVFPJB2x1YY4Ek+3C2Gp aCp1nS2m76TuxpxgxvezkiN+Orz3HsqUX3VFfeKx1TXzvmmdy5zjklbTTm4N/wBP0pgtdxqKeBzu roDj0598Ky6mhbXXep7PpKhstsrKkzTUksLj0Yzhh5JHhevVNprtWSWq66Xu3oUk8X4eoczn+6JJ zjyfGFSm/amr7xXSVVdO+ed5y5zjnK3em9ytR2Ch/CW24zw04PUGB3GVL2TaxHxJ3q3Ueiqexioa +tYWHA9gCOfYqnlQcvdxhbnUuoa++1slVcJ3SzSHJcT5WhJyM9yrPWk13tiUsIPZGUGQTHBSBTHK CR9kLTXXTXFvNvgdMKadk0vT/hYHjJVifiQmutsitV1oGvEFM89UjezHZBbn9lVXQ+rrno+7fj7P UGGYtLHeQQfBC7HU+8WodRWSotlwqWyU04HW3pHg5Cz4pcM7n9r5sZ5McZ60z1LrXUG49db7fURi qq2uLIY4mgFxKshsxYLpaNrK233Gjkpq18k7mxPGCeocKl1jvVVZ7rT3CgmdDVQPEjHtPIIUuxfE DqhrR6lUwu8/IFqXVlL3NPJT37Uu2GpKjpgkop6qMF0c8eQ9mTgj9cqfNjtYag1hFV1d2jd+CDQI ZfT6WvdnBAPnCqzuFuBcNaVNLPdXsfLAwxsc1uPlJzgrb6E3f1BpOzNtdDOw0jHOexrmgkZ78pnl c8uVNdabz4hrjcazWssV1icw0ocyBxZ09UeSQfqOTyt7p3aq0XTZ2XUcVZVsun4d8uA8GPqaexGP ZRfuJr6v1tWU9VdHMMkEfptLW4+XJP8AUrRUGp7pQUMlFS1s0dLJkOjDj0nPfhZ8tuecynUawvHC 4tTXNLahzT4K+PZzfuFlO8yPLnd8rAAHgrUZWt+Em5UhtN2tpmYKx8vqNjJwS3GMhSFoal1GzUUk V5p4GW+2CSGGQHDnhwBB+o+qpZpe+1thucNdb5nQ1ELg5rmnH6fZTDc9/r5cbTLRyNgY6RvSZI8t cPquXj8f45ZPl0zz5ZclitMXCirNSaigpqmJ80jmua0HkgMA/qtPt5TX8XiYXymjhpbWx9JC/sX5 Id1fUY8qpFq1tc7Ve2XKjqnMqGO6s57+4Kki8b/3i5WmWldFFE97cepGMELrbtjdiw+l62kuM2qK WkqYpZn1T3ANdnhzGgH9wtXtz/HJLnVS32ijpobfCaJkgPMhacl2PbB7qpum9fXOxX2O5UM5bK13 zAnh48gqRNQb+XO7WmWlZFHTOkGC6PIKlxl1tJuelgNPTwXOk1VBRTxzSvqpsNa4H8zAAV4NuJrx WV9VW3qiZSR0lOKEP6uXljiSSPHdVS0luNdNN3wXCimIJOJGOPyyN9iFIWpt9628WaSmhgjpXyfm dGSMqmk9WWeO5aav9NbpWT1ImqGhrT/iJJb+hXj29rLrcJqm43uhZQtjgbSh3V+bocckjx3VV9Gb l3TS98FdSy9bHnEsTj8r2ru9W78Vd5tDqSlpmUr3HLnxuPzDHYpL3sylqdqEtuOiLtT22RlTUCSb DGHPzdZICx2+uFxuUdddbxQC3h8bI2ku/MG5BJz2OVVrQe6Nw0tejVRPMsMnE0Ljw8e/3Xb6y32n vNldR0cDaQvPzljvzD2U+dtbTQ6N1w23rYrf01M7S8hjHAnIk6sfsFnt9VVVfRXG611CbfHUNY2N r3Zy1rcZz91Wbbzdiv0rd3zZ9ejm4mgccA+xH1XX6130ku9kdRW6BtG1/D+g5y32+i1llbNMcZyu XzU2VXXUbVvFC0VE0cIIYw5JLXgkfyWO3lXUXK23O61NC6hiq8Oja5/VloZjqzx3IVb9tt3K3Sla 9suamglJL4HO8+49l1GuN7v4tZhRWin/AAURGHhvYj2Hss7tmmupv7TJXPlftZTT26P8TLTtjl9N vJPQ8Ejj7L07eVUlfZLtcpKSSkZWTumjZIc5b6YGQfIOFXTbDeCp0vUSwVQNVbpckxF35Xe4XRa8 3sjulnFFZ4PwcRHS5o+/j2W5n+vFjj3tMl1lkg23oaulhNS6m9KYsbzkNdkpaMqH3LTuoLg+kmpW V00s0bJRglpjGCPccKA9sN5JdNiajujDV22XJa0nlhPf7g+y3W4O9NPc7PHRWaN1LDjpc3+mPZZ3 6a71pM2pax1HoS2XCGN87ab0ZHNjPPSBg8rHTFSa7Sl7rPw81NHVSzSxsmbglpaMH9VBO2G8hsVP Nbb1Ca22yA9Derlme458fRbbcfeWmudsio7I10EAbhzT3H0z7YW5l8VLbrSYdUXH+E6Zsl19B9RD Svje8R/5Swtzn9UWKX8ZoC5VEcEkLKh08jI5B0uAccjIUI7ZbyxWq3y2rUETqy3uH92CeWe7Tnwv fuVvJT3K3x0ljL4abpw8OPJPtnyFmdNW9pe1ncBZrFYbpLC+ano5WOlEYyeksLc/uVhapI6jbasn gifFFM6WRrHt6S0GQnBHhQ7ttvNTUtrmtGponVdHj+7JOTjP5TlevdDeGnuVBFR2F746ct+cHg57 Yz5CfK3LqxLmu7pDYqOw3OqikkpKeX+89NvUQHRkDj7lee2uZLtfUyQMdHFIHvaxzcEAyZ5HhRXt 9vJQmyS2jWDHVUDQBE8jJcM9jn2Ruju/T3GjZR2SV0dK5vzY4J+nHhT3YzOt/wBSxuNc4bLBZa6q D/wzXPY9zBkt6oyAceeV86AxybTdUTXNjczqaHN6SB6gPbwoy0JvFaq2wSWfWjDUMYAI5QMlwHbP 1HuvPuju/T11OKKxzOZRkDJHB+x91u5WyY/DOtW1K24tzo7RU2WpuLXmlc2SNxazqx1M9lr7l6Z2 PcIgREaX5QRjjq4XDaJ3esl30+bVrVpmdEWmObGS4A5B+hHutbu9u1TVtA63WKQCjcMHjHUPYhdc PJq479Rxz8W5de6rxqAf7ZIeBytMV7rlUfiJS53JJyvAVyyu8rXXGakjElLwme6FlovskUykEAOU IKSATQhUJHlNJAI7oR54QJPul5TCoSMJoQJPHHsgpJQELILDysgVKGhCQ7KB+fokmkeEAOAn90mp +UCQB7powgPKRPIQeyMKg7poS/RAYQmjyqDyljn7ppEoDGCjKeUeVAZSCEZQNCPCXZA0vKff7oQJ GEFCA8ICEHKACPogd0IEEyjyjygPohGUFAAIPAR3CR+yAOPCM8cpJhKBJH3QoGmCsUIGVjg+6flZ YCCwZWLvCyKROF8960X7ou/2qhbxwHH+i4r/ANgSuw3Q/wDihRM/4HHP6rkAP7or1Yf6xxy9vG78 xQE38uKS6uRIQhAIQhAJjukm3uglTYazUty1U01kQl9MBzQewKsTvpfarSeiIG2siITuETsDxjnC gP4fa6no9SudUSBgc0NGT35U8782Ou1bomnNljFS6neZXMB+YjHj6rr4dc/29OXm3xmnl2M1a27W xsNVKBI3hwPKkx9DadL09fc3Njp4jmaV2Ox8nv3Ki/4f9HutdpNbcKcMnfy5rxgt+mPdShVVFt1F SVtuw2eEtMbmvBw73C44e+zybmN4+3ObZ36bUlbWVj5BJGZHiIhuAWg8cfZbfUMtbZJLheJKgCig awiLGS7wfPHK0e1FgqNMy1VBPGA1j3lhacjpccgZ+y8+raDUWo9RVllpnimssjGGaUtGZPcAlay1 Mrr0z498Jv27vTday6UM1b0GNkgaQCc44X3orZTx1P42lLQJBl2G8O+vdeK00YtVjrKWN5cIYyGk 9+GlaHaa81d0tsgqHfK1zvHsUk65f1q3vj/EE651FVaf3lqJaVx6D0NezwclT/c7ZRas0LUQ3iBk sL4S7BHYgZzlVw3MttTdd56ilo4nSSdbCekdgD3P7Kyc9RBYNBTvukzIGiAguceBwu/+T35Y83+N LPBqKAXSFsFdPFH+Rsjg37Ar40sBnqGRtIBc4Nye3JX3usjZbhO9hy10jiD7jK+VISJm49xhcs5O V4+nsx3qbT5pz4dpbzZ2VkepI2zOb1CJtKSP/F1LYV3wy1kNDJJBqJktSGFzYTSkAux2z1KXdhut mjKL189ZiH5lwGsN56nSeqrvb20YnfHKQxzzwB449lgtfLYe26f07WyUlzpXf2gjPTKx+CQR7fRd 78QPSdO2zpYAH1cfH0yoS2pu9TqHc6e71TQ105c93SOAT4UxfEsJ26KonUzXGUTs6S0ZOfC7f49/ 5dfDzf5eNvin3t3bW1cOhnutMZdWCI+kG9yccKBtSXrd6gt1RUVNvqoaaNpLpGtDi0e/Bz/JfChu u69BY2Vv4SX+Gsb1F/HUGjzjOVOG3Vwmv2km1VxIlkfGC4O57hc5dTj/AFuy7ue/hTnQNli11rVw 1BWP6ZSZZXl2HPJPuu637240fpHTtHU6eneK58nS6N9R6nU3HfHhczNpisv+7F0t1kkjo3fiXnrH AYM+AF7959sLvoy0UdwuN5Zco5nmP8jmuYcZ8k5Vzx45WOnjz54zJCxGHJtGXD6JHkn3Wcf5+3B4 WHRbP4U9KQRWx91qqEGd7jiV7f8AD4wpL1hrG22t9fQaphfHb5GlsbpIz0ScdgexK5f4YLtV3DSk bKh3yxZjA7cAcKJPidv1bVa1dbZqhxpKcB0ceeASOSunjx3jlb8PN5srM8ZPlJXw46at5mr70ygw JpnmCVzMYZnjHsu01rrCz0kV0tmrYXso5GObF6sRLZeOzfB5Wj+Ge8Vdx0nGypd8sWY2jHcDGFDH xJ6grqnW0tvmmc6mpuYmeGkjla8WMymWV+GPLbM8cJ8pT+GvSlDDTVF4/Aj1JZHelK9n+DPGF1uu dX2SKkvFs1ZEGU5a9sbZoyWyjHGPfleH4b7zV3XRkP4ojEeWNAGBgYwoF+I7UFdXa9qqGeZzqald iJntnurhrLllZ6XyblxxlS78M2lbfFbprx+BAmle705Xt56QeMZXb32/Wa7TVun9S07cve5kUU7O JR4Iz3Wt+Ha8VV10TAakjEYLGgDAwMAKJ9XXeq1BvrTW2umcaSmqfTjaOOkdzz+iuEnkmWV+Fzyu OWOM+U4azra/Smi6Z2k6ASStLGiGGIv4xzw1fe8tpb1t46p1TStcBEZZI5W9BBAzjnsV4N09SVWi tHU1XaGxtk62Mw4ZGCOV6NSxf2h2sqJrhGJ5n0xlDRkfP05GMKY47uG/VYy8lkz4+44AbvtbboKD RFhq5RFhrnRwOe1n/hC7fcGgg1FtdVS32nY+ZtO6Voe3BY/HGPIKgDROttWbfUEdHLaJaeikkJbL PA5hdk+57qwWvwy9bUVlTXt65PwxlGCRh2FfHJ+aT+r5rfw2ue2C0npmzWplTRVEFbd52h0kg5LP oPZcBvvpoap3ltdra9sPrwMa6Tp5AySf6L6/CS57rpdg8kgNbgfuug1f83xGWgH/AA07XH2/xLGN /wB9tZ73h/Xbuis+02mLfS2+gfKJn+mTG3LnEDJJ91ym/WgrRqjSn9poQKSvhiD/AFQ387fZwUh7 iaih01Dba6ejlq2Oc6MCMZwXAAZ9lqN039Ozlye4em59N1dJ7jJzhXwyZZSVvzZWY2z20+w2idOa es7KmhqKevukzAZZm8kfQewUYbgXW1WH4gIbhdoWupIY2lwDQefBwt78Jcr5P4uHE4aW4H6KMPiW y7cur6e3ptC345+ubl5Lb5fGm26b52aatpKXTtG2pkmeGOc6MdyccLod+YIJ9o7lJJBCJXRsOegA g5C4b4bdt6CkskOrLoRUVL2l8EZHyxD3+64TeXdqo1Hd/wCHUg6LbBICYz/7Qg+fouXhn/nfUdfN b/pj7S/8PmjLTZtCsvIo2vuNTG6R8kjcnAzgDPhLXEu3+p7NQXq/CBrqWUAta7ofwfmaQO4+i7rQ V7fc9u6O5mKOM/hy4RtGAMDthU5uJvG424U8FuhZ+JqpeGMHSxgBwXFTGbxuS52zKYrG0e5lmuF4 t9j0dZo65pAb/uQBG0cZ+y9+7enNFufbLtqumhikhcB8hDC4eQQO4Xms9u07slpEz1jmz3aVmXvP 55Xew9hlV/vNw1NuzrRkELHl8rsRRuyGRM9/2STXdW3l1Knyj3EslyvlDZdJWKC4xkBpd6LQGN9/ sFyvxWaXsbLJS3WOGGnu4LY2iPDepnngd8LsLVQ6c2S0e6ape2e7SMy+Q/nld7D2GVGe38zt2N0T U6nDpaOFrpYqbPyDB4b9QrjZLuplLdSN38LenKukt87rlpyM0VaettZPG0lwHYYPOF2dTpiyu34p v/RlH0i2dfQIW9OeojOMYzhdg29ug3CpdN00bIqSOiNRhox5IA+3CjHdnXP9ht3KavFMKgOt4jcw nBx1HlZkdJlNNtubrfT2h7y23z6coJeuMSdXoMA5/RcI/wDg29N1t9ptlnobVDTvM89RDG1ry3/K On3+q6fT29Ft1XfqShlsdM6Woe2PrkaHEAn6hSWzTNqtWtqW526lZTVFVC+KURNDWuDQCD0jjPPd Xr6Z7ny55lPt/pu5UGkv4bQGoewM/vIGuec9suxkkquPxH7WQaJusdztL2i2VzyGw+Y3dyB9FYa/ XOxN1lV2+qjZ/HZqim9Bxiy7pGDw7wO64r4y3f8Awu2Zp/8Ak7z/ACXSYTlxcsPLlZuqfEYOElk8 5cfusVwekIQhAL12+gqbjVxU1FBJPUSu6WRxty5x9gF5WjJVpvg2stFNPd7lPTxyVcHQ2KRzclmc 5x7IIMftpq9rcu03eP0pXE/stbb9JXy41NTT0NquFRUUxxNFHA4ujPs4eCrV6k3trdObh3G21sIl ttLOY8MGHYwCvdt/r6i1HuoX2OhFHT1sH+0g4zK9uT1HHnnCmzSqNJobUdTG+Snslzkax5Y4tpnH Dh3HbuFIGx+0smtL7M67dcFuoH9NSwjDy/8Ay4Pb6q1mo9bWzTOqrfZ6ox0sVQ108kp4bzn+eQs9 Iy2eq1Be6qwOgdTzMidK+Hs6TnJ++MKxLdTbkajQG2Woait03SW2iir4osetTjpkY7nkfUYVTNy9 DVuh9T1ForXNk6R6kMrf/aRk8EjwfcK4OkTYnaltv8N/DfxYS1X4sxt/vMc/mPc+MKC/ix//ADix jyKRmf3K3MN3KfTEy9b+XBVG0OqINDu1TJTwfwxsYmP98OvoJxnpwo4Iw7Cnip3E1adqDaJ7PKbM 6AQfjXU7wzpzgfMRhQVN/vFyx3rt0vsmN6zhTbsLtFJrOrbc7niOx07/AJ+eZXDnpx7e6hWD/eD9 ld34YI/T2pkPkyyn+SznlZZG8cdy157ttJt5qq33O36bp4aG6wcMnie53S4c9icEeCo12w2Gra7U lQ7VbGw22glLHtDs+s4c4+gwpr22pbHDd6OayugNXLQu/GCN5J6+ru4Z4PdddaTmi1A7z+KmH7MC 3O/bN67RZeNodA6ttFxpNJxQ0N0pXFrZonFw6gOARnBB7KPNq9iKi4Xypn1bGIbdQyujfGHZ9Vze 4yOwU07X0dmprqySyPiL5KBhqWxydXz5zkjPB5K6KheGWHVD3nAFTUkn/uhXXekl3Nox1Fs1ovVF hrItFMio7nSSFvW15eHED8pyex91wm0Oxstyuc9dq2IRW2kkdEYCcGVzeDyOwCmvaugtVDd6j+CP iMctDC+YRydfz5OSfYlbh/y6P1J4BlqufYJjN3SckW6t2X0nqTTlTJoJrKe5Ukjhj1C8Skf4Tk8Z 8Fchs7sgbnVzXPWUHo2ynLmCnc7BkcOCSQeAFN229stdqv1fHY3tdSyUVPI8Nk6wJCTn7ZGF7Jg3 /s4uxdwx5qC49sD1Dn+StxJdos1tslpm+aYmq9vQGV9K92YzKXiXHBbyeD7LmNntjxcnyXXWcT6e 2RAhsDndJkPIJJHYAqddv7Za7RdbvFYnNdRviglPTJ1gPPVnB/QLG6n/AOpbX9Ti1pc8E5xgGXB5 +ykx3Gt62ivXWx2n7rpd9z286vxkDnF0LpS8TAd28ng+y0Oz+x0dyppLxrZskFt6T6VP19Dnf8Rc O3PhTzt/bKC0VeoaSznqoRJG9g9TrAJacgFee+RMl2nbFO4sikMbXuBwQ0ygHnxwmU0Ij3F2PtNR plt429L5vTBdJA6TrMjfp7Eey1+0GxcNxoZL1rhr4Le5mYKdshY4jGeskf0U6aAttHaKHUNDa5TJ QRTuMRL+vpBjBIz5wcr4XuOKp2xtdNVSGKnn/DRyva7pIaXjPPjhMe6X6QxuhsZQtssF82/MlRTN YTLTukL3Ed+ppPt5C2umNkdIWrRNLd9a1dQZpg2R0kUpYxgcB0twpc0Hb6e16avtBRvdJRwVc7Ii 5/VhvQ04z9Mr4XGK1z7bUEerniOgLYuYXFpyAOlSd+kt0ifU+yWmLxpCe76BrJjJB1OxPIXskDRl w55BWt2t2KpK2yz3fW0k9LCQfRhjf0Oa0clxOOcqa7VHa6Lbqs/sbiWhAld/fOccnHzcr76qt9Ld NP2K310j4qWeSNryx/ST8hOM/da49LO4r7vBsrHY6CC96Q9artBjHqxlxe9n/GD5HZbDbbYijqdP zXXXM1RSRvaHRRRP6HRgdy7IOchTbaKIUG3FyomvdJHTioja55ySAXY/bj9llrG2wXqi0/a66aWK mqXEPMb+knERIGfuAmtRcpxV83O2PNgraGssM09XY6iSNkjiQXxAkAkkDGCD3wu/uexWgLLSRzXS 53OCOU4a58w74z/lXewsNHtJLHNI6UUzHsMj+SQ2UgH9gtfq68aG1faKejul5LGRnqHpOLXA4x7K aNamkN60200BR6ZrqnT+oKurujADBC+QO63dQHSAGjvlbXQ+wFAdPNuWtK2opJZS0tjieGiMHgB2 R3ytrqHaSgs0Np1Dpi4Tz0TKmGSZlQQS5hkbgtIA9+ylDcezRX2roKGpqaiCEwzSYhf0lzmgFv35 VxxmV0lVj3b2gr9HV7Zbe2evtFQ8NgkA6ntceA12Pc9iu20X8PdHNpqCu1dc6q31kzgRFEWhrGuw Gtd1DOc/XypnqA+bbmymocXy9dJlzu5PqN5Xz3HsTdRV1JQyVtRStbTzTtMTgAXtILcjyArxTtWX XuzF2sOraW2UOKikr5QykqHnA58PPYEKRX/D/pa20VI2+6krKOtkYOpoczoLvPTlue67TdKombsx RVL5HfiWNgk9T/F1e+fdR/oCgsmtLM2s1VqutjukUzomxOkbhrRjGOoErOU44zL7Mbytk+Gr1XsV QWK+Wh77xO/T1Y4Ry1JDRJG4gkeMYPHheDd7ZOj0ZpiC7Wm61NaHyhjmzNaPlIJBBH2Uwb7udS6I tlLCwy0/qRhtQHDuGnGR9R5XX37+ByaXtNLqanjmoagRx/3n5WuLeCVnLq4/2GOW5f5dPz4naWkg 54Xwwpw392pGjqqO6Wl/qWSqfhgJy6J2Cen6jHYqEX/mP0W52r5nugoKAlNGmAk3lZg9lAxkdhlf VrHns0lSdsPoCj1zqeSC4zOZS0rBK6MNz6gz2z4U51+jtpKC+Os9XbjDUh4iOZXAZP1z9VmZy2yf DeWNx1tT9rXdX5DlZhj3uPynKtDS7XaKte47rZWEV9tucXVRsbKeqB4PLSQefoV1lPsdoO2y/ha+ KWearqHGDMxDmsI4b9QMHlSWW6Zs1JVMRG7PzNIUpbZ7OX3WtunrYporfSsH91JPGSJT5Ax2Uq2z YW3wbkyQTVJls8MbauOBw+ZzS4gNLvoQpztz3Q1UtBSUD6ahgjAa8s6Q52cHHg8YWmc8tS6fnvqO 0VFlu9Vb6vpM1PI6Nxb2JHstZ0nGfCk3em11VDri4iugfC6WR0jOocOaScEe4UjWW+aJq9kH2mtF GLy2ldE3rgHqB+cgh2M/zV/yJ+PyccfVXw/v4+d9q0uygZ7r71rWidwb2ycL4DuPuFFbzSen7jqS 7RW+0wPmqJCBhoyGjPJP0Ck/Uuw2q7JaJbh10ddHCMyR0znGQD3wRzhSX8JVJTx6Wu1WIY/xLagt EuPmx0A4z7LuNCVl+dqTru08M1BdKd1REGZ+UtwMEY4OCFiZcpctN54cMuG+1OtN6WuWo7xFbrXC 6WoecduGDPd3sF3OqdkdWacsz7lUtpqqCM/3jaVxe5g9yMdlZ/Rtlttru+qaqgooIJfxTgHsYAQP TaSPtnlazbu4XurvlbFenwTUddCKqNrOenOAWkEccY/ddeN1tzuU3pUDSukrrqa8RW60w9csnd7i Qxg93HHAXUaw2d1VpS1G43Gmhkpmu6Xmnk9Qs+pGOytLou0W6wxarqLZRwwSx1k2HNbyQGNcB9sk 8L46DnvVVc7pQalZBLS1cDauJrT1DpecFvPbt2TXybU40npK56pvEdutEJlmfyXO4YwY7uPgcYXQ 6x2q1TpG1tr7tRMFIXdBkhlEgafHVgcA+6tTomzW7TNm1FPaaOGGaOonAdjlwby0E+yWi5LtcJ7r Z9V09PNTVEIqY2g9bXRyEgj+R4Sxf6pvpTR941RdhbrPSumqCC45PS1gxn5ndgt1q7bDVGkrcytv VAIqZ7+jrjlEgafrjsPqrWaQstBpXSV1rLJRxRVIdMAe/UGvIaCstIG6XimvVl1lRwPjwHtaCHNc x+Tj9FONLuKb6T0peNU3T8DZKUz1GCTk9LW4GeXHgLZ6t271LpWnjmvlufTxSHpa9rw9ufYkdla/ SVot2kdDVtZZKNjKhpeHFxJ63NeWgnPnHC+umTWaltN7smsaONzoH46TyCxwy0g+491PV01xutqb aT0hd9U3L8DZaUz1AaXFpeGjA+p4Xv1boPUOlWxG+W6WmZKSGPJDmkjxkcZVtNM22j0bt1LV2Sii FSfmwT+d5f0gk++CvpYo59X6bu9k1nQsM1M4xu5yTxlrgff6q2am2fmyfCnGmNK3fU9c+jslI+qq GN6y1rg3A+5Xp1Xou/6XdDHfKCakMwywuILXfTI4z9FbzS1tpNE7cRVFjomyVMoaSHHmSRx6c5/Z FspzrfR1wtesLe0VdJK6J+SCQ4DLXAj7hTR3rfwpzprSt61HPNDY7dPWywt6ntjx8o/Ur66k0nfN OPiivdvqKN8repgkH5h9Crf6YttHofbyCfT9CJaqp6CWud80kjiB3PZfKOmj3A0JXU2qqD066gkf E4/4mvaM9QPjutcLrbPJT7Tmlb1qKomgsdBUVssLQ+RsQBLQffKy1Dpq82CaOnvVvqaKZ7eprZm4 JHurhaetVHoPQUEum7eZayr6XOBdl8j3DHf/AEXlrqOn3D2/qX6iojT3Ogc9nX04e17RnsfB9kmF 6S56m6qhYdD6kvlH+MtFpraymDi31ImgjI7hF70fqKzRNku1qrqSN56WuljIDj7BWKse4NzrLEyz 6RsLm3ClY0ymlaOkDt1dPHfC7iiNZe9uakazpBHWgyERzsDSC3lpH1+yvGy6qyy6VGj281aQ1zdP 3TocAQ4QnBB+q+Fz0RqWipJamss1zip4hl8j4CGtHuSrn6qrrzQaSoprBDJPV4YHNYzrOOlQ/qLc HWUNOaG/0ElNS1h9DM9P0h4JAIBPGcFYm6t6vFX202C7XV0jbXQVlW6PBf6ETn9P3x2XyultrqCc 01fDPTztGSyVpaf2KufBR0W2+j4G2CikqKuqOGkNBke7HV82BzgZWs1zp207j6Ip7/JC6kro2hwe 0Dq4dgtKS7my9b/iotqst2uZkNsoK6rEfD/w8LpOn2z0jheW5QVlDO+Cugnhlb3ZK0tcPuCrvMtl Ntpo5kGmbbU1M8gx1xxGRznYz1PDe6rZu7XXbUV5iq7vbZKapc0Rt/uHM9THbgjkqztNoqicRz6u P1WUsr3nBcXBStadhNX3O3QVsVNRxsmb1iOaXpePo4Y4K8162fv2na23tvEDGU9VM2IywO6wzJxy qI5o6OtqPmpIKmXBxmKMu59uAvnXxVMb3R1DZGSMOHNeCHA+xB7K7DmWvanSlJQWyhkqJXjJcyLq Mjhguc72OFyW9OjbPqvSDdY21v4aqdC2Vw6f9608c/Ue6swtsk+WL5MZu1UJ335WBK9dwgEFQ5q8 RUs017BSJS8p44yihCEkDWKaQQNBR3KMKhdkHhB5KZ4QL/VCAn3QJCCgKwCEICAR4QgDhKDCaMIC BdkwkmU0AoSymfqlgMoR9EvsshoSzymO6AIygIQVoA7IQOyEAeyO6EBAJZ5TQgPCEDhJA0fRIJ+U Akn2SQNCP1S7AqAPKEfZNAeUd0EJeEAhPGEkB2R2R4Rj6IDOQhCXdBkEncJfRGMIBGMIQDzygSEy koGBnyksgke5QGfqln7o7o/RBYYrB3ZZrEng/ZeB60U7nHN1ox2IjP8AVcl2iK6rcwj+MU3f/dn+ q5XP9wV6cf8AWON9vE7uUBDuSkurkEIQgEIQgEIQg2Fsr5aKdksDnNe05BClS1b3ahoKAU0Ba0gd PWeSoloaeWpmZHCwvkcelrQMklSzZditUXO1GvM1vpI8dXTUOc0n9mkIPVTb5ahpqGWGBzWySEky Y8n6Lz6X3lvNh9UsayZ0ri4ueccnus6DYfVFbQzVUdRbGRx5yHSO+bHt8q1eldoNSakmnZRmiibE 4tL5pCGuI74wCmvli2b07aj+Ie8wue51MwufycPwvQ/4kLwG4bSsBPu5aSm+HjV0skrBPaA5nHNQ 7n/3K+jvhz1hziezOI8Codn/AMqivvXfELfJaKeGKCGJ8oIL85PIx2Wq0nvZc9PUj4oKaN73EkvJ xyfoib4f9YthmlAtzxECS1s5JOPb5Vp9ObN6rv4l/DU1PCYyQRPIWdvbhU+Xus+7lfRapqr3UU0U 9TUEEkYaRha7cvdS862YyCrcIqNhz6TPJ+vuvhRbV6jq9QT2eOCmFVA7oe50oDAfutfrzbzUGiHR fxunjEcpw2WF3W3PsSrd77MZNdenGvOTn38L0W2o/DVkMzmB4jeHdJ7HC8zu6SjSxdg+IaW1WqKk ZbGgRjAwRhRdufr2r1zeY6yrghhETSxvQ0BxB9z5XDdWfdA7ef2QTftrvJFpCzso47TE5wABe0Dn 6ldfW/Ei+aAhlpiL/HWAQFWNpAPlZt5PlWdJYsfZ/iJlpoXsrLY2UuOeCOn9l8NTfETV1dompLTQ x0j5G46w0At+2FG2mNptXaloRV2y19cB5BkkDCftkr7ai2b1pZLZNX11pDaaFvU8xyteQPfAOVdp ZNduatGrLnaLy66UlQ4VbiXOe7kuyfK9OtNf33VsMcV3rXyxRnLYwflB98Lk3Ar5EYzwpbtZJGIX 1hP94Mr5D6LOMfMPdRVjttt77bpWww0DbPhzBguYByfdcTvHuNT66rKV0FrgpvQLneqG4kfnwT7L lNK6K1Bqou/gVsnqw3u5uAP3Kx1ZojUGlXQ/x61z0Xq56HPGQ4j6hXfxGbJbupr243vs+ltPQUDL R6b2NAc5gHzHyVH28W4dHri5U81La4aX0iS6Vow+TPuVyumNGah1N1GyWqprA3glg4/cr56o0hfd MTxRX62VFE6UZj9QcO+xCTKzqJcZbLU8be75WHTOnoKCO0ujcxoDi0Dk491GW8Gu6HWt7jqqG1w0 nRnrkb+aUn3XK6c0XqLUUbn2S0VdYxpwTG3hfHUulr1pqoihvttqKGWQdTBK3Gfseysys6i3GW7q wmgN8dN6Z09T0FPanxOY0B/SO5xycqO9e7mUt11zTX6x22Ojlgd1Of5lP/EuF05o3UWoo3y2S0Vd bG04LomZC8uotN3jT9WynvNBUUMzh1NZM3BIVxzuO9fKZYTKy34WWZvzpm6WanptQ2j8YWYLmysD m9Q8gFePVXxC0n8Nho9M0IpmtcOrqGAG+2FX2waN1BqGJ8tmtFZXMYcOdFGSAvJfLDc7HV/hbvQ1 FFUdIcI5mFpx7rO6cYtA7fXSd3s8EGoLUasswSyVgc0OHkLn9yN9aC6aeFn0/SOp4JB0Sk8YZ7AK CbDpLUF+hfLZrRWVsTDguhiLhleC8Wi42atNJdqOejqAA70pmFrsHzhXHO43cTLCZTjVm9A7uaD0 xa4o6C0up6ktHqyNb8zz9T5Xk3C3g0bdoJKyjtJffQ0Nhq3AtfHjtgqvll0tfr1C6W1WmtrIm8F8 URcAvBdLVX2qsdS3OknpaloDjFMwscAexwVNtcYtTpP4gbK+wRQaiifLUMAyAMgkdio33f3gk1nV xUNMHwWRjgXRtPzSc85/RRVadMXy7QGW12murIwcF8MDntH6gLyVFlukFyFBNQ1LK44ApzG7rOf+ HuktnouMvtajQm6m3WlraxlqoJKWVzQJHY5eQO5PlcrvDrrQOprRVz0VsdJfJcCOpJwWYPf68KC7 hpi/W2ldUXCz3Gmp246pZad7WjPbkjC0uXl3SCU3f/qlwlst+Fqdvd6NO2DbiG11AmNXDCWdIGAT hVtFbTT378RVteaV83VIGnnpzzj9F87fp+83GAy2+111XFnHXDTve3P3AK11VTzU0r4p43xysPS5 j2kFp9iCm7rj8Lqb5fK59g3m0HbtNwWyn9aOmZF6fp48Y5UO6C1rpuwbwVl4p4309nk6hE08luVB frOAQ1785SXU1C4y3l8rqak3F2v1NVU096jNTLT/AO7LsgD9Aef1Wxk3p0THUULKeQtigPBDAOkY xhUdEz85zhY/iJMclN04rraj15tbqWtpqu85qZqfBjLs4GDkcZwU77vZpOinths5D/Skw7DAA1hG CqU/iHnyf3TE0hPBTZpeCq3X0DHd23yOd7rmYhB1eAzPbGfqtHqjdHQ39rrZfKVoq67pNPK97ctb GfYe6qRHSVksXrMgndH36xG4t/fGF5nGTwf1Ta8VzqjU+1FbqGC/Pc2O4xdJa+MdA47ZHYrnNwt+ aYaot50+eukpCS+Q8F+e4+yq0yOpLOoMkLfcNJC85dIX8nKbTivDDupt9XGkvVa6Bt0hjJB6AXNJ HIyq1737mVGvLvhh6LbTk+jH/qo09OYt4DiCPYryvzn5inKkxjE8pIQo0EIQgyacEKwXww7g23Sl fV0N1cIoawtPqns3AVe19I5HMPylBdqrt21NVq2fUVbcI6mpmeZXwzPDoS4jGekj6Ly6U1Bt8dxK y7UTqa1iliEELIWiOOXk5d0gYyqctq5unucfdDKmZrshxH6pqG9LN/E/dtOXilt10s90E10jd6Ji Ycgx98/Qgrkdh91P7I3V1Jcz126qcOsk8tPYFQjLUTSH5nE/crFhdnI4CC9ztTbf6cnuOpLfPTOr KiMFzY8ZJGe3tnPKqZuhrWXWWqZrlOGtb0+nG0eGg8LjHTyFuDICPbK8smes9X7rXKszGb2sfdN4 rHW7Mu0uKaYVrqRtPn/CCMcqt0xy84SLyOM8LDKy0zjd0vBKsj8Oe6dNY4xYLyWtoZXHok/yk+/0 VbF6KZ8jeWHBClm1l+F8f4xoXQVBcrtbZ6d88znPDI35cc/4R/w55XE7X70Uldfq6gvYZFT10zns f2ALgBg/TAVUZKmd8eHvc4fclfGGWUO6mktI8jwkmhedt40TtxaLnXW2pglmne6QMY8Fxz2aPoD/ AFXJ7Xbv2y63C4Wu+iKKGulfIHH8uXcEH6Kp0tXUyNAfK54+pyvjHLJG8OaS0++VfSaXibd9H7Y2 O4VVuqoZ5KiRz2hjup3/AAt79gua2s3Ztd9mr7Nf/ShZVvke0u4a4O7tKqTU1lTMzD5XOaPBJK+E E0zHBzHEEecoXtd43PSO12nq6ptdVFPPUvcR0v6ifLWnnsFpNqtz7RqaCssF89KFk5eW9Rw1zXEk gn9VUWpraiWPEkrn48FxOF8aWomjf1RvLSO3KGl26m66Y2t0tUPt1XHU1M5OMP6i8gkjIzwACtPt nuHZNZ2er05e+iD1Q/GXdIc0kk8++VUOprqqZn9/K5w8ZcSvjSVVRE8PikLT9Cgu5XXrTW1ejnso KiOpqZeMiTqMjvc88cFavbjXFj17peo01eXsp39BaPn6epoOQQfcFU+rLjVztAmlc8Dt1ElfOjra imf1wSOY4eQcKC7F4v2ntq9FmjoallVUyg/+06jI8jBceeF5NvdXWHcHR7tPXKQU80UYbjr6cgfl cD9Cqb1lzq6oAzzPeB26nErChuFVTP6oJHsceMhxCvr0q7F81BYtr9GC20dQyqqZAcjr6utxGHOP PHZfSrit24+19FRW2601MR6YLpeekt7gjIVKqu6VdTj8RM95HbqcThfShvVdSMLaaoljb3Ia4gfy SZa9JcdrsUsdu292zqbdX3WCoPTLiSMAZc4cDpyvFZrxZt0tDm3PrBSV1OGjId0lrgMBw9wVTWtv twqYuioqZns74c8lYW68VlI4vpZpInEYPS4jKbWdLna21LY9vNGx2KmkE0r4i0NL+o4dnLifqcrO iuFl3U0ZDDBWikraZzXfmwWOHH6gjIVLLldq2seH1cz5HdsvJPC+lsvdfbw40lRJCXcHocRlN2F7 6q5O5OorHpHR8emY5XS+vGIj8+XMYXZc7Pk91zN12as97tlHcNF3n0mS5c91VJ1tII4xjsQqt198 ra2YPqppJn9up5JK9tBqm7UdO2KlrJ44weGtecBPZtcvV01NpDamnt9dVxS1ELImMLTxI5j2uOP2 WVyZQbpacoK6z3B9NU07wXBknS5oOA9p+4zgql1x1Hcq9rWVlXNKB2D3kgLK1akultDhQ1MsQd36 HEZSXj6L3d1cDcvWdn0lZaGzU7/Wlp5IcNLslrWOB598gLaXOhody7VbLrZrjJC6J2HiOTpPQ4jr afY4VIbleKuuqDNWzPllP+J7iSvbZtVXW1sMdDWTwscclrHEDPuryqWbW33NvOmWUNv0dcKqQQOf HFLKxwDomt9/quSvew07a+kq9G3SKSie1rn/AIuQ9XfJLSB5CrTc7xWVtU6erlfLI45LnHJW7ote 3+npo4oblVNjjHS1vWcALOX7Y8b6XH9buLTb5Sw0mirVbZ5oxVMkiJbnuA0gn910WutM1uqNIWil tj4g+J8UhL3YBaBzhUpvOrLpdXtdcKqWYtHS0vcTgLa0u4+o6anjhjudT6bB0hvWcAKXGda+JpJ1 v/vax/xP1FPBoGioJJWfiWytd6eecBpGftlU2nILyQt/qPVFxvrmm4VL5i0YBe4nAXOOKuMmM1F2 xKxKZSVNsgVk08hfNZgoLCfCRW00Orq6KaVkcktP0xhxx1HPYLttxtq9Ram3EnqadrILZUzNLqnq BMbQBz05yTwqq2e6VFrroaujldFPE4Oa9pwQVJMe9WrBx/Fpycdi/hc8fHq2/beefPX8Szp3bK6a d3Ts7Ke5Nu9LTN9eeXpEb4uSOktyfot18SNRdbJV2e+W4yRRQt9IzMP5X5JGfuq80u6OoKW8z3KC 4SsqpxiR4d+ZGqt0L9qW1GhuVa6eAuDulxzyFZhJlyjNvUn033/bJqY3QVv495qBH6JIAGW5zj91 YXYu96l1Da6m6X5z5KSYD8MXEEHBwTwqP+o7JOcLv9H7q6i0zbGW+gr5GUrHEtZnhue61pm+tOm+ IKpu8us52Xtj2viy2ny3GYsktIPkZyuqtG3Wmbhsm69xSSNvQpTJ1io49QO7Fnbtwoc1xre5auq4 au7TCWaJnptd56ck/wCq0lNfKympX08NRI2F3dgcQCteb/kymX0vjvDDg8VYMTO57HC+DTyPuiSR zySR3WLSpoWx+E280BsVytD52sr5ZTI2N3HU3pA4/ZSNoSx6gt14mdfJYDb6Bj4KXp4JacHq7cjx 38Kj9gvdXZbhDWUMzoZ4XBzXNOOylC7b56jutploqidgZI3DnNGCpjjxmo1nlcsuV9rOaNvltuV7 1HR0lXG+aacyNZ2Jb0AE/uF4tubXfaGvq5b8Yo6Wha6lhHTguaMHrzgZGMfsqb2rV1wtd1juFHUv iqI3dTXB3KkG+b5X672d9FUyMAeMFzG4K3yvpjjN7WS0nc6C9P1TQUVVG6aapkc0A/4XMAB/cLz7 c0t/pquuqNTNjjjpIhRxOAw57WnPV9Rg91TzT2tblY71HcaCpdHOw5yDw4ex+i77Ue+N8vVofSSm OMO/xM4KlvWjjFkNLXCivVBqOit1VFLUPnnLcHw4fKfsvNt+L62WsuGqIoadkEApGFvBIY4nqI/X uqh6V17dNPXplxt9QWytOHNPLXj2IXcam3yvF8tLqOQxwh3f0+Cfom9qsbYqynvelLzQWmojlqmS TtAz5c4lp+xyvnoGW8ugrbnqaGGlaI2wtLTg4Y45Lh45KqLozcS66XvX4+hm+Y5D2O5a8exC7XVe +dzv1oNG4MhycuMeRn6FXZbVhrbJHetDXSjtE8U9U18uGh3Z3WXBLQM90koLld9R08VE6ZrQPm8N BGSPByqm6I3Kuelrua2il6mu4kjdy14+oXY6x3xuOoLR+DDI4A78xj46h7FZvtvndWLBQk3jbeog s7456uNuA0H/ABNeHYP7LLQs1xmtdxu9/po6F9WGua3q7NDcAn2KqpoHdK56TuzqinkEsEnEkLzl rvY/ddXrXfGu1BafwkbG0+T8xjJ+YeyvVjHzan/Mlftez+EllRUwxtc1rTn5mPyR/JZ6Gqa2exXK 63mmjovxsjpmND8jo6AAT7HhVc273XuWkbhI6M+tSS/7yB5PST7j2K6LXO9lTfraKSlY2ki7OEZw CPZN3WjfWk81bpqra+kntDRVT0wjlDGHOSx2SP5L6aNfUu0vebncqZtEa+R9Q1hfkdJYAOf0Vatt d3a/SdRIwYqKGUkuhkPAd7hbvcHeqW/W1lLRQCkjAw5rDwQtTK60xxntPd1mndt3QVlojFXLSiKb oac56fzD9Fhpx9TPpG9VtxphQy10sszY3uBGHNGCD5yq6bZbwVmlTNBO0VVDLz6UjuGu9wtrr/ee S/0EdPRRNpYQOWsPGc9x7KcrvZljyxuNfAO1ft5XyXaClnpKWqAjMzmhzHDuPspw0ndJtY7U1Fbd SyadwlAdgDBb2IUTaP34FPY2W6/0Ude6I4ZJIckt8AjHf6rYX3fSlmsz6S00TKJzs8xjAOforlly y5HGcdM7tr3XWlqKBtwp5oKYjojlmjGHYHGHDvwpEoKxus9pG196hinlcwyAuaPlc13Dh7FRnp7f SjfZGUGpbfHcXRHDXyAHI8ZB8/VZam3st8unHW2y0LKJjgWljQOnpPcALlxvKWXUb3NdztLWurg+ 0WSxXaGlfVxUkrXvaw/4SwtznnyUUjZRtpUvngfTSS9UnpPGC3qkzjChLbnetlnoZrZe4TXUJ/3T Sc9HPI58LPcjeIXuOKG2F1PTtw7p6snP1W/5C3qz7TRurqmt0pp+iq6Axh73Bh6xkdl46uSLWG1t JeLnDE+rDGTxvAx0ODhyFwNq3usV0sVNS6otUdbPEMO62tc1xHHVgjhYap3ltMumxbbBSiji/IY+ C0N78e3KXvWmMMbN7qXNfX62WG3UU12p3zMeelvpv6SDhchdtwbXdLBHRx2u4QRTSRiCaWImPPWM HrPC52j3k0zfLLTQaqtTKqoh7hwDmk9uoA9l4td7vWar0m60WWlbDA4BhiIBDWjkdPtyruLqpT3A vsOnKq111XTzzUz2vheYhkjqAx91p76z/wCoi7Mbov8AZc9D24LR19iPC4DQu9Fuksf8K1ZE6qEJ b6UoOSQDkZ+oI7rS7v7tMvUP4W1yFtIW46Tx+h9108eUmeOX04+Xx3LG4xA1/aPxjzx34WnPde2v qPWlc4nkrxHusZ3eVrtjNSRiAmUfdCypI7IQUAlhNJAIIQgqgCXcpoQJA7IT7IEUIKFYBB+iAnhA gmhCAPH1QhCaB9ksJhCAwhCEAhBQpoLCAOU0lIGhHlC0Ad0FHblCACD9EJeUDQEJeUDSKaMIEE0I QCD3QkUD7JBNHlAihCagSE0KgRwhJAJpeUKAQeyfhLzwgPISPdPyg8oFhGEZ4TPGEGJGE0ZygDJU C8oP0TSQNPj3KRRz7ILCHhYnz54KyPPZYk4B+y8D2Il3IP8A6dhHgQ8fuVzB/wDV3BdJuOQ6/wAY HcRjP7rmnH+6K9WPqOGXt4j3STPcpLo5BCEIBCEIBMJLJvdBNfw32ikrdQvmqYWyOjLQ3qGcZUw/ EXfayyacttNb5jBFUyuZIGcZaBnCiT4dLjTW+8TfiJA0vLekE4zhTBv3pi4av0zRVNjDJXUT3Sui /wATwW4wPqEnvtnLfw9Gx+qY7rZoYKqQF5HQ5vfPhd/c32nR1mrq8sbT07AXO6GgYJ9h91w+x+k4 9P6fjqK2NvrdPW8kcg9/5LtzU23VdurKUxMnp5Gub0ytBB+4+6kStFtNdZ71TSV1RK6Uylzg5wwc Z4Xv1FUVGmzXXmWYuiE7GtiByOlxxg+y821dlqbDSy0U7D/cucwOaDgjPC1d601f9UamrKasqJqb T4mD/TaCDJjnuRjgq/J3p39iqhV26SrkAYJHF+PYeV96ajp45DVU+AJRk4Awfr3Wrka236ZuLIS4 sgilDSTzw0rUbVXKpuOnIn1LznoHH1RLekA3rUVVaN67i2neeiWq9NzT2+inzWFupL9t1Vm6wMnY IHuAcOxAyCq9Xix1153wuLaOB7xHW9bjjgAFWB17dKTTW3NXHdJ2ROfA5jRnJLi3AGF18v8A/kT6 cp1/ja+VB6hvQ8gDsSF9KGmkqqhkMLC+R5DWtHkrGpcHSOIPGSuj26DXattgdj/ft7rnfb0T1Ey6 N+HmOtsIuGo7pNQ9TerELWkN++VtKr4cbTU26SWyajqZ5gMt9WNvSf2wpj1VFLNtjVsomOkmMJ6W xjLifphQJpjS25tdbD6DjS0XltRL6TgPoDyrx/SZOf5L+S4a6ja2z4a6WstzX/x2f8a04ka2JpYP svTUfDtDaIvx1uuz6+sp8SfhpYWhriOcZypj25hnpdMujquJ2Mw498kZzj3UJV+8F8s93rrHRULX VRmLGGQYJ744KYTc5GeesuE+m2setdb3+kksunLPFA+nJje/qa0NI4IBPCl60tq7bpCeTVBbHK2L +9Jd1Dtyq7Ulg3Ms0E96iijjpp3mZ7YpWucCTz8gVhtGzy1ujJJbgSZHxfMJB9OeCm/3mmct/ju/ aqOhdOWDU241wZdpGC3CV0jGB3S14Lj/ACwtn8RWltFaeoradJMijq3yOEzI5S/5cccErRaU0fU6 v3AuNDSVQoo453F0gGS0dWOAvXvrtg7QdPb6l15luYqXuYfUiDSzA98nK355ryZf9teH/TFDWO66 TQNmiv2p6C31BLYppAHEd8LnB5XcbPzRQ67tj5nhjBJySceFydV0vwLNFaIhi0zb2vqMMZHG1uS4 k4XoutgpdYaRlp9S0XS4NJew4DmOAzwQvtqmrrW6SbV2GmFZVRdDgwHwOSvdQVMjNLS1N2DKWWoa 5zg4gAFw7K66lccbd3bRTU7NF6LpWaWtolmf0MZG0cu6lnqHTtDrPRxj1JRASMHU4f4o3AeCvVqm qrqTSFNU2WkFdUQhhLWnsAOSvdBO5ulHzXLoppKhhJDjgAuHZb1OMc93lWmqImaJ0hQwaYtgmkeW sbGwcnI5OVjq7TNu1tpFv8fpOmVnJPZ7CPqthq2trrfpijqrPR/j5YSzLW84aByV7C/Gky+vLKeW cF2HnADneFnrp071WjuIZoPSlBT6ZtZnc9zYxHE35iCOSvnrbSdq1xpWOS+0vRPHgl4GHtx3GVtd a19bbLDRVtponVz4i0OawZw3GCV6Z3OOk81jmQTT/MQ445POFua1GbLu9tTXtj0Hpu20embUZ/Uc GCKFvzYxklePX2i7PrrTlPVXqm9KqjIIkaMPHPLSfb6Lda4ulZabXQ1tsoX172ODSGchoIAyV7Kv 5tLsFU5sEkuDhxxyTnC56b20lydFoGx2u36ctRnMrugRwt+bAGSV4txNC2TXdkoqy7U7oKphbiRo AeASMtP/AEW23Du1VZqW2VlBbpLgQ/oPp9mZAGSR4W0rfl09TMqC2GV72Hoc7HPVkhb1NRjvlWju s0O39otVt0/aXzNleWdEDeWtaAS44+61m5O3dj11Q2+4XKEwVTXtzJHgOcCRlpPst7uFfaixC21N JbpK8SPMRLASGdWACSFtq8YsdIyUtjkdIw9LjjyCQs6alu60N1qqbb632m12O1SSxzOLOmBmS1rQ Mk4+/dabcq00VL+B1jSwtiuUDmN6g0ZeHkDB+y6HcG/y2Kot8kNuqK1tS4w9UTSWxkkYLj9Vrt2P k0LDE7DZHTQDpJ5/OMhdPHJyjj58rMLY9W6Onq7Vu309roDH+KqWN5kOG+6qtpfaCuk3Hh09qFpg jHzufHktkaPDSrX7gXWptGlaSqo3dMgmgb+hdhbW4UsEtTaq6WNhqWOa0SHuA7upO8ZK3MrMrpzt dd6LQUlosFntEz6d7cf7PGSGNHBLsfzKjT4lNubbcqBmobZD6N1lcyNzIwAJy48Z+v1Unaz1E6xa hpoBbaqqNfH6LZYmEtYSccn9V69bWBl/ttrts0pib60bnFv5sN9l0mOMs39OVyzuO5e9qqQ/Djre enZKyK3DrAcGmpwR9+FHty0LfbdqV1gnoJTcw/oETMkO+oOOR9VfSCe2W3VdHZYaWQ1Tqf1hM6Qk AA47e60VZDHJvhRlzAXMtxcDjt8xXHHC6ty+npvk7kiszPhy14+Jj/wlEOoZwaoAj78LktS7Vap0 /faW011te+qqsej6B62v+nUOFYb4hdbXfS2ubWy1yuEX4cSOi5w49RC6bazW191fqKGO+2iWhhgh MkRkgczqceMgkc8eyw6bV8j+HXXro2u/h1MOoZx+KbkLabfbGXGbXsdp1bCaWCKMVDhG7rErf8oc OPurH6513p/TWoGUd3iqnVJjbI0xuOMEnHAK9OnNX0up9Q0zKOhrKZsMT3GSphLA/IGAM91dM8nz fqKx6YvtBpOkoOiIsawlsfyNDuGgn/quB1VsFY6/cCjraaX8Nb6pzpKija3gubyS0+Ac9l2t9v1J TavlsjqOoNbXSwujlEfydIxn5vphdpXN6r9bT4DJc/sEy6uiXc25H+0mnrJqKk0jT0IaAwR8RAtG R8rcqO778P8AZKzcWCohqHQWufqnmomt4JB5wfAOey7m6Xuih1nPYnU038Qq6mGVsnp5aWtDec/T C7SoaTqijcPyinlH82rpljJdRzxyunKRaj0zbtSU+joKBjSyMQgekOkAjgA/ZVf+JLbuh0bqBlXa n9NJXFzxBjiM+cFWXlvttZrGawugeLrNXRztd6fHQA3nP6FRL8ZOC+zj6P8A6rph48blZ/HLLy5T h37qq5CSbu5SXmewIQhA1t9OafueorjHQWajmq6t4JbFGOcDytS38wCt18G1vp2WW81xhYakyNYJ COQ3HYFEt1NoNGzOvOguGmbjgeMNz/Vaeybe6mvc1ZDa7LXVElG7ona1mDG72OT3VgrnvldLDrm4 0tYwVFBBM6MR9jwuk2o3B/tbuXUOoqSOjo6im6pI48fO9ufmOPPKuU43VTHLlNq0UW1GtKuD16bT txfECQT0Adu/cqSfh7otF2ua4V2snRi6U7jFHTVLAWtGMH5T5VgdSbiW/Tut6azXB8dJSCIyvk7A kg4GPuojvGiaXc7dKau08WQ2RoYKqojj6QXDkge5PurcdTtOe/SRdFVOkNZVtXT0OkLeKVgcHVX4 RgH0GcZyVVjevSlFpfXtbbrUT+EIEkbSc9PV/hVlNxdb2bbHTDbDplsQqw3p4xlv/E4+Sqh3q6VN 3uU1ZVymWeR3UXE5XSSY43cYluWU16dvftktQWfQY1VPU0ElF6LJ3RMc71GtdjGQRjz7qJ3DDsKe dTap3Ck2tZR3a11Een5IGNFS6L5Szjp58eFBEn5yuLsI25eArGfDts9TX+mj1PqIsktsbz6VOeQ8 t7l4PcfRV3pseq3Pur1/D8ANk4enjInRXhuWg9v9xLPcaPT1FRUNfTuIZPSxhpDh2Jx3BXD7RbFQ xXGruesvRkpqGZ0bKcYcx5b3c7I5ClfbF1hmurn6ebTtLLfE2p9FuPn6j+b6rcNydK6nP/zep/oF nC3KyUz1PTg73txoXcOwV0Gl6ajt9wpXuEc9KwAdQ7dQHdpXE7PbHQx1VZddcRwyUlI98bKcOyxx bw5zvp7KXdtHWd98q3WAUwg/AQCUQNAHXl3fHnGMrYzlsehb+5/5A6qLvtkrpjOV0zenAah2y0Tr 3TFWzR1PR0Fxo3uEcsDQA4jsHe7SuT2e2TpYPxN713DA+kg62spnO6mHHDnO/wBFLm3DbN/Gri7T wpxSupacSCAYb6gLs5+uMZXprehm2Vy9cf3X9915/wAvqHP8ljx3lLv7as0j3VW1WjdbaTnl0NT0 1FX0r3dJh4Dz7O+h8Lmtn9k6OnhmvuuY4XUbA5rKZ5y0+C5xH17KZtv4LNFcb3/Z0xfw5wgOIjlo fg5x/JfK9dA2uq/XwIXOd1k9ukzc/wAlrKamzXekda02g0tq3STq/b6GCkrqclwY1xLZf+E5JwfY rS7R7JW+C2vv2u2QupQwllM93yge7iPqpn2/gtVPJqBunjEbaZWOjETstDujkD9V574IDtTEKsht M4QiUnt0mUdWVPjZ1No213s3pzVGlG3fbyGGkq4Glxha8lkwHdpyTg+xWv2n2VtdLZH37XjInwyM 6o6dzsNa3wSR5Ux6Dp7ZTUF/jsLojbfxL3Rek7qaMxjIB++V4r+2lk2xtUVxc1tLI6nbIScANLxn lXGbukyukX7l7L2W9aYivu3kEcLoYy59M1xIlaOTyTw4LDarZS0UWnJb3r+KKRs0YfHA55AibjIO Qe5UvaDgo6XS98htz43UTamcR+m7qaG9DTgH2ByvlqOGin0bp6nuxYKKSWnbL1nAxjsT4UwnLpNo f3U2XtVbYINQbewgQNjzLTNdkOb36gSe48henbLZSy2zTMt43BZHIZmBzIC8tETe4OQeSVKmlYKa j0HqCC3uD6OOeqEJDuodPSMYK9OqaW31djsFLdun8BI9jZA53SD/AHZwCfutXEl3NoO3f2WoYrRB qDQUT5KDoBmpWOLzj/O0k5+4W2292Ssdn0xLddwR6k0rciAP6RCPGCDyTlSvZaWnotuLhTULi6li /EtiPV1fKHHHK+mtKagrqfTtLeej8BNIRKHv6Af7okZP3ws2etLj62gzeHZOloKOnveiI3y254aJ afr6i3JwHgk9uRkLd6F2OsNo0065bhZdUS4IhEhYIRnGOD8xUo0kTINrDBGS6JhMbCTk9PrYHP2X 13It9vubrNQ3d4ZRSPl6iZOgZEZI5+h5Wpju6Ty5fjm0Bby7KCyGK76RY6ptUxa10IdkxEkAEHyC Sur0XsVp+0aaFfr50jqqQtJYyUsEOeOnjvye6kuRgj2ogiDzI1vpNa4nOQJmgH9l6dxLbQXqvttB dnltO6OeRoEnRl4aMc/Tv+ix9t670rru9srU6fr467TbX1lnqntbG1vzOhc7ADSfIJ7H6ruNJbD6 ctem4KrXUsrq2ZzciKYxtj6sANwO+D5UoPaTtrZmucXEGkHUec/3jV89wLNRX69UNHc3vbCKaeVg ZIWZe3GD9cK4TlNp86iue7Oylfp28xS6dikrrPWSBsHScvicezXHyPYrv9J7CabodOUc2sqmcXKd wyI5fTDOrs3H+qlNxc7SOlw8lxdNSAk9ycheTcSy0d9uohrZpInQ0D5oeiTp+cO7484Sz0TvSuG6 Gzl209qWKCzU8lbbq2TppHNPU5p/yuKkfTGwOnaaw0TdW1tSy61DsAwzdDckZDcEKXazL7Zphzjk ieDk9/ynK0G5NnhvV8qBJUzQzUdubUwdD8AvEju488DCl6m2p3qK46/2bventUxW63wSVtLWPxST NHcezvYgd1Klh+HrTsFmo4dTV1Sy7Tkt6oJsNLsZAAIUw1f95PpX1OXmTqOff0XFcruRaI7leqyq dVVENRb6SGenDH4aHeockjzkDCeptJ3dKpbrbb3TQd4dT1bXTUMhJpqto+WRvsfZw8hR68Y47q6H xURtl2+txfgkVAOT/wAhVMZeHkKs18kjyU3JIABNY54TBQZA/VZAn3WGUIPp1H3QCVgmOEGRPKMl Y5TzgIHnKAUghA+U8rH6J+UGQKyDj7r5por6dRT6jjyvmgIPqHFHWSOSV88p54QZ9Z+qASFhlGSg zDsHOUw8+6+ZQFR9eo+5R6h7ZXzzwlnhB9A85WXqH3K+QPKMoPr6hPkpmQ4xnP0XxRlB9es44S6y cguOF88oLiobfQPIGMlZes/GOrhfHKCiPsJXe5CYmcDjqK+H3QqPsZnDJHdL13EcuK+SR7KD7CYj seUGd5HdfBAKD0NmcD3P7rL8S/OMnn6rzfVHlB9xO9vIcR+qZqpMY6if1XnJygdkH2EzmnIcQfus ZZ3SDDiT+q+SR7oDOM+yXdCCqApd0IQCCjujwgWUeOEd0dkAEFCCrABIpn6JAIHjhCP1QgClhPHK D+qoOyMpJ/sgEIQAgEYR5wgpsCEIQCEICAKEIQCEIQCAeUeUeUAkVkeySAQksse6BIKCjugEIPdC AQhCAQQjwkDz2QMJFNCBBHn3TQEAhAQRwgSM8oTQCSD37oQHhCE/PKgSB3TP6JIAhLlP6FCBAFJZ IKDHlNBPKCc5UB+qM/dLHCP0QWEKxceHfZZnuvk8/KfsV4XtRFuHzfxjnDAued/uVv8AcE//AAxu B8Rgrn3/AO6+i9OPqPPl7eJ3dCD3R2XRyJCEIBCEIBMe6SEGztlxmopmSwvc17TkEHCkWDePUsNC KWnn9NmOkluckKN7Tbqm5VkVLRROlnkOGtaFM1J8P92dY3XCtu9HRuDOr05YnEfYu/8AeRK0w3l1 KLe6kinMTXAhz2kguyjTm799sdP6VKWu89TiQf5LdUnw/wB2qLLLXtu9A0saXBhjdh2Bn8y1uitk 71qendMytpaRoyB1tc/q/ZVOm4pd/wDUULSOhhJOSepy+r/iF1IRgBrfr1Er603w23uZzx/G7a1z XYIMb1m/4ab7g+nfLU9w8dDxhDppbvvnqOtt81L6gjZMC15aTkg915bBvTfLHbBSUbWdsB2ef2Wx rPh41PDQTVMNbbZ3RdWYWdfU7Htx3Wu0xsVqXUFI+dktHRlpx6c5cD/IHCbOnj09u3ebPdKu4ODJ qmpeZHPdwclaHcHcC8a0qmyXSdxiZ+WMHgLbWXaK/Xi+VlshmoY5KaQxulkeeguBxxgZ/ktTuJt1 fNC1Ucd2jjkhkGW1EGTGT7ZIHKursljjHHK9Fuq5KOqZNC8tkYQWuHgrzHv9kmgjwstJ403v5drT QMgdTslLQB1dWMr73f4hb1X03pMhYyMn5h3yPZRLo/SF31ZXtpbPTmR/ZzjkNb9yu7vuwusLPapq +RtDUMib1GKnkc55/TpRHVUfxG3KloGQR0TPlGB8yinVmurlqPU4vVSWR1TAGx+mAOkDkffuuRlY +KV0cjHse0lrmuGCD7Fei12+ouFdHSUcZkmlcGtb7oXV7Trpz4hLhbLfHBPRtke0AF+e68utd/rx fLNLQUkYpWyjDnt74+i08OwetZLf+LEFAI+nqx+JHVjv2woqq6eSmq5YJhh8bi12DkZBV2mm3sOq blYq11Xbql0UzvzO75WGqtV3XU0zZLtWSVBZ+UE8D9Fz8gOcN7LEtLRz2UWAL70sz4JWvY4scDkE HnK84OVkwFxwEVPuhd+q6w21lNWQfiywYDie4+q024u8931Y+NkbjS0sZyI2HGSuY0ZtjqjVlMai z271IP8A5JI8MafsT3Xj1poK/aPqY4b9Reh6g6mOa4Oaf1HCsZ0lTQ2/1ZZra2luFL+Jc0YDyeCP suf3G3mu+q6iIRE0lLFgtjjPc+5XLaP2z1RqumdUWa2mWAceo94YD9s91r9Y6Kvmka2Olv1EaZ8j epjgQ5rvsRwmzUTJoz4gZ7VaGU1wozUysGOrOQQuU3I3luuq6yL0SaakhILY2HGT9Vy+lNsdU6po zVWe2PmgB4eXNYD9skZWp1ZpC9aVuAo75RvpZnDqbk5BH0I4Q1E4aO+IV1utMdLdKM1D2jHUTkLj txt5rrqmvjMLjTUcRHRGw4Gfcrk9J7a6q1RSuqrNaZZ6cf4y4NB+2TytNqrS120xcvwV8o5KSo6Q 4NdyCPoRwm01E96R+IdtBZo6W7UbqiZoxkkFpXFbj7y3bVF1ikp3mlpICDHEw8ZHkrj9Mbbar1NR mqstnnqaccdfDQftkjK02pdN3TTtzNDeqKWkqgA7okHce4TZqLDaU+Imno7NHT3ikfPM0AE9wSFw W4m9F11Nd4pqZxpqSBwMUbTxn3K43Te3Wq9SUhqrLZamqg7B4AAP2yVpL9p65WO5PobxSSUlZGAX RSDkD3TZqLI6W+Imjgs0VPeKN087AMnGRkKPNwt6LrqO+R1NNI+lpKdwMMTTxn3K4mwbd6rv9J+K s9kq6qnzw9rcA/utHfbHcLLcH0V2pJaWrj/NHKMEK7NRZ7S/xFUEdliivFI+WoYBnjIyFG+ut4qv U+qaSqka5lspZWvZA098HOVwli2/1TfKFtXaLHXVVO7hskceQf5rQ3i1V1pr5aK5U8lLVRHD4pBh zU2txl9rZnf/AEtXW6KnuFufNGOk9MjcjI7FcVuPv0+6PpaexRGmpoXB555djsFD9k0Bqq829tZa 7HX1VM4kCSOIkFc9crbWW+tlpa6CSnqYXdMkcjSHNP1U3YcZVsbD8RNmdaqcXakkfVxgE8cdQ9lw tZvzW1Guo7mWYoIz0Mh8tbnv91E1q0Hqq70DKy12KvqqZ/DZIoiQfsueq6KpoqqWmq4nw1ETi18c gIc0+xCbOMW8qN+tJPqYrg2ge64tZ6YmI+ZrT3AWu1Bvxp592t9fb6F34xh9OSc8OEfkfZVxtmid T3SgFXb7HcKmmd2kjgJB+3uufqqeopp5IKiJ8M0bi2Rj2lrmkdwQeybOMW/uW8G3N2rqe4XS1Mqq 6AARzSRguZjnhae8fERTu1RRm30/TaouHdQ+bnuVXSg0dqW4ULKuhsdxnpnjLZY6dxa77FaKogqI J3xTsfHJGS17HggtI7ghRdLg3Hdrbe6XOC6XK2NqLhEAGTPblzccjC43Xe/z6vUVE+xsMdDSO6gH d3+6gel0nqOro21VLZblLSkZEzaZ5YR9DjC0ksMzJHNkaWuacEOGCCrtOMXUg380lNR09ZVRONfF Gen5eWkjkAqHa/fO6z62Zd2OLaZjulsQPHRnsomg0tf56RtVBabjJTOb1CVtM8sI984wtI+N4cc5 BHfKHGLsN330dJTw3CeNxuMcRA+UZBI5AKhx++d2frgXfqIpgekQ546M9lEUenr7JSfiI7TcHU/T 1+oKZ5b0985xjC04a/JPj3TdOEXc/wC3HRb4GXKQZuTISAA0Zz3xn7qrO6+u6zWt9kq6p59IEiKP w0Ln2WG9Op/XZbK50HT19Yp3lvTjOc4xhaSQku5VmVnpLhjbLfhgUkIWWwhCEGTTg5Vhfho3Mt+k xU2y7kR09Qev1fYgdlXhfSN7mn5UF2LfedpqDUU1/geDcpC57nyEvGXd8AnC8ejtwdDSa0ut+mMV DUBraeAMb0tcwZy4geTlU6E0gHjP3TbLICS0/wA0vd3U1J1FiviT1Dpa/wD8PuFiqnS3PJjmwflM YHHHvldH8OGvtPWXR1VRXetbT1Dpy7DvIwqnvkkJ5IX3gdIBkZI84Cu7fZJIulbKraqhvcl1FWyo rHZ5qXeo0Z74B7Ktu89ZZqncKtqrD6P4B/SQIm9Lc+eFH8lRK0HDyvM97nYLjla53Vn2zMJLLPhY XV+9dBfNqjpltC5s7oGROeTwOnHI/ZV4ecuPskXE8ZOFisNvpE8NePZWS+HjduCxwtsF8cBb3u/u 3nswnvn6KtTe69MDnN5acIsXiuWvtE6HslfUadfTyVVTI6ToiABLnf6D2XHbUb00tTcKu36kMbaa rkdIHuHygu7ghVWdLK5uC/P6pRue05Bx+qC7V211ozQNhq5NOvp5aqpkdIGxgZ6jzz9B4C5XafeK hr5qu0andGKapc97XvA6fmOXNP0VU3TSyDmXr9ucrCN0jTkHCbqaXZu+ttH7e6ZnGmpKaWome5wE ZBOSc8nyB4XObV7uWy9Q1Vi1QYmwT9Ra6T8pDsktP7qpz6iWQYdIXAeM5WEckjX5a7HsVDS6181p pLbrSckOmZYJZ5nEtDXdR6vd3vhaLavdO0ajtlTp/VBibE9rsGTAa5p5IKqVLUzSfnkL/wBey+cU sjOWuLT90NLr6i1rpXbnSDqbTc0M1RJkNDHdRJ/zOWn2v3Ksmq9PT6c1OYYx0FoMhw1ze/7hVDkq J5B87+oD2KIZpWPDo3Fp+iKulqXW2mtutGig09NDUTvaWgtdnqdjBc76rXbc7gae1vpSXTepXRQO ZH0AuOA5o7EH3CqBU1VRN/vZXOH1JKVPPNE4GN5affOERc7V2t9Pbd6Njs1ikhqJnxlo9PGCSMFz vqV89Da109uBox9j1BJFDLHGGZc7HYfK4fUKnFRVTzcySOdjyTlY01VUQu6oZC0n2OEnXoXK1vre waB0kyyWOWKeSSMt+U5HIwSfqVnpXVundzNEvtF7njpqmFrWkl3SQR+VzfqqZ1VXUTnMsjnn3Jyn TVVRCQYZHMPuHEJs18Lk7i64sWiNMRWGxvjlL4yOlruoNae5z7nlemy6i05ulo9lFcqllJV05aT1 Ox0kY5HPII4VMKusqZiHTPLj9SSsqKvqoHf3ErmHHgkJe4s69Li7n68smkdOw2GzelIcDDWO6msb 1Z7/AHXupLxpzdrSMMdVVto6ync17vmALHefPII4VK6usqZ39U0jnH3JJX0orjV0uTBM9me/S4hJ 1Okva4W6uvrJpmxxWC1enKW9A6WuyGNa4OHP6LbMrNO7saXpZpK0UtVA4F3zgFh/xDv2IVI6uvqa iTrmkL3e5OV96G611L/6vK9gPfpcRlN69L7XA3Q3Cs+mLbSWO1ujm9B8Zx1ZDWscCBnPPZbmf+z2 6litteK5sEsDx1tEnSQDjrb+o8qkVZXVNVN11EjnO9ySV6Lfd7hQtIpJ5GA9w1xCSppbrc3ca0aZ bbrPbAyoNHJG4guz09BBAz54W9raOw7n2+0XaG4ej6LgJWNl6CW93MPtyqQ1lxqKicyTvc955JJO V7LffLjRRuZS1MsTHHJDXEDKXtVudyty7Tp24W23UQbUfgZWuf8AN+XpyMfXhb24Wqxbii0X2nuB jjYOiVrJekvbyek/UE5VHK+41NRN6k0he8nJJPde+26iulBD6dJVSxM74a4gZQ2t3uDuhaLBqG00 cBE/4GTMrgfy/KWkfsVvbrYbNrqttOoKe4uFIG4mZHL0+o0ZLQfs4qjFZdKmqnMk8he9xySTytpb tUXahphDSVc0cXJ6WuICu6mu9p/+JzW1trrbBYqGT1XwS9bng8dsYVWZSOo48917bhWz1k7pJ3l7 3HJJPdeByDAoPZBKR7oGEDlCYCBFPKYCyDc+UGAWWE8fojygWELIBBGQgxCaeEeUCQmBygBA0Ixw vo0IrBA4WbsIHKDEBBWaMZ8IMEws+lMgY8qj544Qs8D6o6cpTTDCS+mEigx7BMLLhHB90RgUBZEA FGAUGJQsjjCAAeygXZCyAQBnKDFLKyI8IxhUYpE+yzHISAGUGKMLLHOMJ4woMco91kWpYCBJLLAS ICDHukV9AOEnN5VGCSyKSBHuhNIoDPKSaFQh3Qe6EeFAIKEKhJownhAkFNCBZQEYT7KhFCZSKAAQ e/dCB2SgxyjtymhZCQEI7rQEIKAgEIQUAhHKEAQglCEAgoCEB5R5QgoBAQhAIKCkgaeEhlBKAPAQ EBGUB2QhAQB7I8JkJBAuU0IQCCj9UFAvKflLumgEigoCaB3+6Byml91Ad0FH/wBOUs8oGEeUZ5Qe 6AKxWSAgCMhGD9EylgeyaFgVg8/KffCzXzkwGOJ4XgexD+vPm1NJ5HQ0LQyD+4K3muSDqWbHYNb/ AEWkkOICvTj6jz33XhPdHhBSXRzCEIQCEIQCY7hJZR/mH3QWD+GS1U01bLUzRNdIJA0EjJAXY/Et fq22z2yhpZ3RU8hLnNacA4xjK4z4cb3R26ofDUPAkdIHNBPdSLvnoav1jBSXSzTMkNMPmhLTktPc 5+i349S3bh55bx4/be7KajivNjgimcXvx6ZbkYz2XV6xulv0Zpusq2x+k3Ba0RgZDnAgY7eVpdqr BT6U0pFLMGOLGF8hDeeOSVvDUUesbBVwthjfHPG5rTI0OAyCAcY7hc3S+mv2jqpq+xiqqHl8sreo ud355WepKk6Wa64ioMrqir6CwOy0dR4GML07bWapsdoNHM3rMJ9MPYOHYK0X9i7tftRVVRfJqiO1 xVRlp6VpIDhnIJSs9u9ts8f8GNVUcBznSHH1OV6IaSnjifUUoOJgHfLjB+vA7rQalL6LQdydStd1 QMeWZ5OB7r4bd1s9dpOOWdznP9NpwOcEhawxvWTOeXWU/iuVqv8AWUO79whhkIjnrXtc3PY9RU77 qUlPcNra2ashjmcyJzmF7QS047hQRpnTlyvm7lxnpYXGGGte9zyOB8xU2b1Xy36f23qqCunAqZ4i yNg5JOPZdt8f8mW+tsScv8XU9qNP7pxjqcA3vlJ/BWVPxID7LlfdeqLofDZp2S16bZNKyMPeCTg/ Nz2W81pqmt0xczHJBDUtrepkMYlHV1Y8jwOVqvhy/Gy6Zp5qpsnTg4JHjwot3yp76/dKM0sFQxso a2mkcC1hcOTg9k8c3MtuPlussdOqp9g7PcoKm86ir6uCWdxlc2kLSGdXPkFfKfYu0W+ifctK32rf WwfOwVLmBpA5IyAD2UkaNdqK16fjN6ggq43MDXNp3F5II8twvLuFpE3vTZqLJK+1TxAyGJ2Y2PHk OB+yy1f46vRTHzaUDalwD/T6XOHPjlVq3k2Xks9DLf8ATs89fTFzpKiNzQXMB5y3HcKyGlWvZoWR v/tG07gMc5d0lfK0l0O307q0FkggcCJRg/l+qs+mcsrj2qbsVYNN3a9zO1P6T44yOiKV2Gu9+F7P iMt+jqCtt8Wj4aWGUB3rtp84+nleHa3QQ1rqSqimrnUlLG/5nR46jk+M8J7+bfUOg6+gjt9xnrWV DSXCYN6mkfVquU1bHTG7m0QrtdqLDT3/AFdQ0daC6BziXAeQFxhGAVJOxlTDTa5oXzvDG8jJOOSs tLj3yOs09pq3UelaOL1HObGI+AOnHPPhPUNiodS6QMWpKRkvp8uaTnpcPYhfXWE90ksVHU6cjjqJ YnNLg49m45Xpq52UelmsvE0cE1QOQfLj4W76xcZv9mvv7azTunLZRaToY3Okc1gj4aA3HPPhLU2n 6DU+kGt1JSRymE9Rb/lcD4K9GtKi6tslDU6dgjqnxub19R7NA5I9166ydlJphkd0lZBNU8Yce7jz hb3OMZk7rw6hFXp6y2qh0vQxu9R4YWcN6W45OV8dXaatWrNLQHUFIyR0Tg4eCHA47r164q7pDbbd VWCmbVlkgEmcYa0gDK9dxkjpdNww180cE0rgQHHgnOcLm21+onVmmrZaaHS9ubL1uLXRtw3DGgEn JXw1ppSz6w07Rvv1I1743tc0jgg5xjK9mvK2601JbKuw0jav+8LJDwQxrsDK99xfHTWOjgrJWRTP kaQ1xxkh2SAg1eon1mmqK0W7S1rErHuLHRxgDpaAOV5dcaOsmsLNQVF8ow6WORha5vyu5IGCfIWw 13XXak/hVTYqIVbXSOjldn8jXYAOPK2FykjprNRQVcjIpnSMwHHGSDk4TSRqNQ1FVpiO0WzTNq9W J5IkbGAOhjccry670RYtX0dtq7xSNM7JGYcz5SckZaT5C9+vLjdaKa2S2a3mtjmcYpXjnoDsAFbS 5uigtlBT1EjIpTJHgOOM4IJwro20N+uVTpmqtVo09aHS0zmkv9IY9NrcDK8mvtBWDVzrZWXakb6z ZGfOzguBPY+4Xu13dLpb7jbv4XazWxVR9KSUdowTjlbq6elFBbYJ5WRvEjDhzsE4PK1ZOnLG3v8A 7aK+Xaq01crVZrBaHS0ZZmQwtwImg4yV4Ne7cac1bcrVcblSgT+o3JZx6gPh3utjrS63W23uiZb7 Y+rgrG+i6YDIjJOOcfRb24GOB9ogllYx7ZGu6XOAJACtk61Gsbdd/bQ3m9y6auttslktEktIIw57 oG8RNzgE4+y1WutstOaqv9rudfTBtQ94EnQMCUd8O91tdY3a5WzUFJDQ2uSpgrwIXVDeRH37roLi I2VloifMxj2Pz0OcASAPZSyTRjbd7rRXa+P09eaCx2e0ySUccbXSuhb8sLScDP04K0mutp9Nam1V a7rVwenUPf8A3rY8BswAz83uVt9WXS4UGq6alpLVLUw3ENiNSPyx4znP6LpLi6NtztMbpWNexziW lwBx047LGnXbnLnqP+z+o6LT9stTzRRwtdI+FvyxgkgA+3ZaPWu0OmNQ61tt1qoTHLI4maKMANm6 RnLvqtrqi61dJrKG3Q2maeO4BjBVAfI3pySusuBaL1a2F7Q5vWSCefy47LWUnTnhllbdudrdRiya mo9O0FplNBHGwPljZ/dxh3DQfA7Lm9V7N6avOvaG7TxOZ6vU6anYAGSlvIJ/dby+3upptbMsrLXU PbXujcKoA9ADRyM+4/1XWV5Yb9bW9beprZCRnnkAdlix0ltcvNquK2atp9M0lqmFExjGOljj/umd X5QT2C5W+7LaauG4tLcpYyyCUOmlpWgBj3Nxz/NdDcL5PDrR1hFrqXGsnjlbV9J6OloBPPnGP5rr qjB1LSYc35YJMjPPJC3Z3qOeOVvdrnBq2Gk1Y3TUFrmFFE1sRlbH/dNLhwCew+y4uv2P01UblR3L pLaWQGd9CB/dlwPf7Ensulkvz2azfp/+F1fXUVTJ/wAV0ERlrQ0nnzjC7F7M6qheCOKZ4Izzy4LW UktiYZXKSudg1dTDVrtMQ2yYUcYEBlEf90CR+XPYceFw8mx2mpNyRWBhFEWmodRY+Tqz/TPhdPDe yNcu0/8AgKkTOrfxRn6D0FgA8/ouyaP/AIbSRjilx/7pXLGT19GGWXW3PU2rKGfVculm22YUkbfw /WYj6Rdjlue3ZVT+JbQFv0bqhktnJZS1oMnoY4jOecfRWdt+oI363OnhQVIq21r6p0xZ8gZjg5+v ZQp8Zb2m82lvHUIjn91PFjLbv6XPOy46+arKkmUlxegIQhA10ei9G3rWNz/A2GjfUzgdRwcNaPqT wFz0Yy4K6Hwj0kUGg66oaxolknILsc4AT50lupagao2J13T1NPTvs5Mk/V09MzSBgZOT4Woj2n1c /U0lhbaZTcmRiVzOoBoaex6uyuRtJd627W29T3GZ0skNa+Nhd/haOw/muB2w3JazWF2obwwuEs7h +KDSejBIAJ8BbuGpb9XTlj5plZPubQgdhtfRxve+yOw0EkCZhJ/mph+FKoibS19iqrbA2oge6V75 Ix1g9sHPspZrobvSPrbzp64tulOG5Zb3DOT5w/Pf6YUd7IXk6i3O1Lc30YpJXwtD4gMFrgcHP1XP LqbdZd9Iu+I7QF3i1VdtQU9rc20fIXTRgYyRjOAoJipnPlDG8knAX6EWW+uvWsNR6dr4WTUsIBAe Mjpc0Zbj9VTfduxUunNwrtQWthZTxzZiZnPTnnH7rrlvK3+OXiymMmP23utdi7hpjQDNTS3WCoZ0 Me6nbEQW9WP8WfGfZQu8dLsKeNf1u5LNu4GaipJWWB7GASHpPH+HOOR4UEycvK5uxxNLngK0/wAP G1tqZY26x1MY54m9ToYXNy1gb3c4Huqu0mPUH14V6dsiIthI3FpeBSyktAyTwVcZvKRnO2Y7jCv0 7o3djTtbR2+lp6WopZHelLBE1haezXHA5B9lyu0G0Fs03FW6h1S+Gq/CukYxhb1MY1uQ5xB7qRNt 660XG81tRp9rG0zaOCOToj6B1gnP3OPK9tQ5o26uz5AOn/aS8fTrdn+S3MZbpmZXTj7xpHRu6uk6 qGwU1Hb62lkcYpaeBrMO8dXSBkFc3tBtBbNNUlVqPWBpqr0A5rIyOqOMAkOJB7qTNvay0V9zulRp 5sTaT0Kdh9NgaC8dWTx55HP0WVxcyLa24PqP92PVL8+3qnP8lnOSemscvtyOodDaR3R0fM7TVNRW +vpnuMU0ELWDq9n4HIK0W0m0dp0zaptR6zZS1Tw09Mbh1xxjJByCOTnypP29qrTX1l+qNPiAUDnx BvosDG9Qac8DyvlfXQxbVvfU4MALXP6uR0+qCf5KWdNON1Vt7pXcvRbqzStLSW+upy4sfDEGAuHd r8DnIWp2o2jsml7HJqXWTaWrc6PLY5Wh8UbTx2I758qUNBSWyeLUM9h9IW582WCJvS3q6PmwPuvl e3Use2FI+4Bpo2iB0wcMjo9Ruc/oporgNcbYaZ3A0gLvoqmpKGuhBcBE0NY/HJa7Hn6rx7UbS2DT GmjqPWraarlmj6hFMA6KJh7DBH5vqpS0I62yWe/TWT0v4c+qlMfpDDfyDOB7ZXgvbqRm3lkdcww0 LZKYzB4y3p6ucj2Uw/YvSPtw9p9O630nHf8AQsFLQVcTC4xxANjlaOXNIHZw91jthtNpzTGlDf8A W8NPVVE7A4RzAOjjaeWgcdz7qTdDOon6VvxtbojQmrqDEYhhmC0Hge2SVjqI0Eej7A67tiNCJaf1 BK3LcfUeyeP95LZoy69Iu3R2kseqNLxaj0HBT0k8UfU+CPDY5GDkj6OC9G3+0emNK6QddNe09NWV VQA8MlOWRjGQ1v1KkXT4pToK+i2en+CMtUYPTGG9OOMfRenWH8MbaNPNvjYjbzKwSCUZb/uzjP6q ybkq49oh3c2gtF4sNPqTQkEMLGsHqU8WGse33H1HlbDRe0Wl9H6TkuWvKemrqioaD0Sn5Y/YNPvy pLssdLHtpWx0Ba6jDagQlvI6ep2MLLW0drki0/FqAQ/w5z3CQTHDc+kcZ/VNGU0hjeDZa2zWum1B oKKNlK4NEtM13y4JwHNJ+p5C6HSO0WlNG6W/Ga2ggrqmo6epkvZp9mn9V39NHFDtWI6Qh1OCWxkH I6PW4/kvZuBDaZZ7JFf/AEfwBfL1CY4bn0zhSxZJ8oN3l2VpIqeG/aHYwUMpY2SkDvlb1EBrmk+M kZC6nTe0Gj9HaYin1tBDW18rm9fqOx0uJx0tweQF3ksccW1VLHAcxNEIYc5y31m4/kvpuTBaqu42 yC9GH0TFO5nqu6W9Qbwc+61hjyuqxnZjbpBu8myTaOop7vouJsltq3sjNMHcROcQGlpPgkrtNPbP aO0tpalOtoI6q4yvaXvLyOlxwOkYIyApCewDbazM6urDqQA+/wDeMXy3ForPcrpR09+9P0fwlQ6I veW4eMcg+6a0qBd29kKi3XenrNIRfiLXXPa1kXV/uXOOAMnuD7rv9PbNaL0zpujj1nHHVXKoeOqQ yOZ0udgdIwewPld+cjR+lmEk5mpAf3C8e49utVzuohvLmN6bfI+Al5aQ8O7j6q4470s7QLunsfW2 nUlL/ZWN1Va7jJ0wDIzA8jPST5GBkFSPYNl9FafslDTasxV3SpeOqUyFmHOHYAHsMd1JdQ3Fo0xn lwmp/wBflK53cq32643ypZc3tbJDbPVpT6nQ4SCQ4I9ys2fCetf1Be42x1zteqaen05Eau217j+G JcAYjgktcT3AAyCpMseyGiLNbKCk1K41F2qflMpmLAXEZwG5wApQreozaV6u5lBOf/nLlye5dqt9 yv1VLWzmOqpKGKWlHqdPz+o7x5zjCRfnSAtcbH3q06wp7bZ4zV0Vc8/hZs46AOSHfYc/VS1a9h9E W23UFBf3yzXaYFplbUOYHOwTw3sFKtyGbzpg+fVkP/1ly4bcC10dffbrXTzyMrre2ldTASYGC75u POeyfFt+EtVh3e22uOgbwYZwZrfK4mmqQOHt9j7EKN3d8K4/xcNDtJWskcioOP2VOpvz9lqzUl+0 l2+aSELKn3TAWK+gHIQMN+mF9GxnHcfyU4/C5oy06m1BX1V5g9cUDGviidgsJdkHqB7qe7bZdFaj 1LWW1um6CGeyy5JZCxrX5yMEAcj7pO/S3r2on6RI4wR7rIwuH/2wrh0Fh0Fet2ZYJLXSU0tHD6Md MGNbFM8OOSW4wTgrpbzaNHWm4Gju2iqKChcMmvZStMTQeB1OA+U/qlll1Ull9KL+m4eFi5hGe37q 3GituNBjcWrEFTDcad0Xq01JLhzB1ZDm/XHBC62tseh7ZdJqG6aLpqOnI5rfw4MODwMvxwSpFqjP pHsQV75bLcY6EVj6CsZSEB3rOhcGYPAPVjGCu03X01adOauqKawVjaq3Pb6kWDkx5/wk+cKVn7o2 Gv2V/s5UQTNrm0jYACAWlzSMHP6K6RWTGE19akD1XY7ZWDWguGe2Qiu12x2/uWu7yykoGmKmYf7+ pc35WDzj3P0Uq6v+HWptlinrLDdjdqqnP97AYQwkAcgYJ5UhfC0PR2rrHt4IqpnA/oF0e3VHcqC/ GSsuUlZT3OkFWWPGOiTOCPrxhJdza5frlxVU2720uutL0aOlifT00L+mpqHtyIvpjyfou81x8Plf YrFLcLLcxeTA4+vAyn9N7WjuR8xyR7KxVgY2ho9WOpmiMsrZ3t6RjB9Np/qtbt7Q3G2X6thr7i6u grqSOtHUzp6XucQR3OeAOVUVM222zumuby6kpM01NEMz1L2dQj9hjjPK7HXewV205YHXK33CO8Mi JE8cMBY6No/xD5jnB7hWRsEEdv07f30TGQPFRUua5jQMY5C8WgaK42u63GhuVxNxgqIGVjC5nTgv JDhjJ9lbjpm9Kkbaba3LXd3fSUDxT08QJmqXt6hHwcDHkkrqdwNi7zpWyfxKKriukDHH1vw8RBiH uck5VmbTDHbtEXGW3xx08ofP0uY0DBEhAXw0FSXOlqLxar3VMroSGSsPTwQ8HqGD9fCzquvGqi7a bbXPXV0fT0TxTU0YPqVT2dTWHGQCAQeVvNwtlb7o61i4yTU9xouz5aVrv7v2LgfH1VnaJgtG3VSb SyOlljLmMc1oGP73Az790aGpbnDTXyy6imirWQkFh6ctcx7ScYP9FbOtsd7sVG262zvGua17KACn pWZDqqVpLA4DPTwtnuJs5ftF0UdbVvgraF5w6opQ4iM+OoEcZ91ai3Qix7Zl1nZHSy9IDHNbwCZM ZPvwUtGQXKS1XqzaldDWNgcY2nGWvY5mex+6li3Hq1UbbzbC964km/hQhihh4dPUEhhd/lBAPOF6 twtpb/oimhqLkIKikl49emJLWH2dkcK1lNH/AAHbGmdYYoKWV7I2ghuBlzg3Jx37/wAktFR1N40j drVqMQ1Yp5X0+cZa9vSCDyPqtcLrl8MTKb0qTt7the9cuqDaBCyGHvNO4tY53+UEA8rLcDa2/wCi fw7rtFE+GYfLNTuLmA+xOBgq29LEbJttQR6fhgpp5Wxxt+XDS5xxk4/qvPYIai/6IvNq1XDDUS0U slOT3B6WghwP690kNyKl6B2yv2uPxBs8UbYYODNO4tY53+UHByVjrzbS/wCiZYWXqnYGTNyyaF3U wkdxnHf6K3v4d9j2+t1PpuGnppqkRsAIw3qcMEnHn6rz2+ml1HoC6W/VtPDPU0T5IT55YMhwPv8A VXis7VJ0LtpqHWgqHWSla6KD80sruhhPsDjkr4a327vujKmGG+Uoi9ZvVG+N/Ww+4z7/AEVx5qaW x6Kt9FpenggmquljWH5W5czJOfHZeI0R1dtnVQaspI5KulMjHDy17PIKxO112qTozbXUOsmTPsdF 6scPeSR4jaT7AnuV5NX6EvekqxlNfKN0D3t6mEO6muH0IVy62nk09o62W/SNJDBLUkMjjzwCWlxw SeF47lQM1lti6TU9Gw11OHg8YLXsdjP64VOKpWjdt9RaviqJLFQiZkOOpz5AwHPtnv8AotbqjR14 0xX/AIO9UUlNUY6gDyHD3B7FXUvMdRpzStrtmkqSNks49OJnVjpAb1nBPbsVrb/b6XXO2TKzUFE1 tfC3OQMOY4PwR9j7KfxJN7VL0dt3qHVsU8tjoDURwkB5L2t7/fv91q9SaVuunrk+hu9HNS1LBnoe O49wexCu9f2VGmtN2+16SoY/VlaWRNBDegNHV3/+nutPq+0UOutuKe53qjEVfCwODm8OY7qAc3Ps eeFdHxtUrTG32o9UUz57Ha56uGN3Q57SAAf1K1Oo9MXSwXCSgudLLTVUf5mPHOPcHyFd7UD6jSmn aC06QtwfIYyI2tOC1rR1E58/++tXrnT1s11oWgvN0pTFWNbG8lnDgC4BzSf3VuNmrWZnL6VE03t/ qTUdG+rslqqqunY703SRgEA4+pWrvGn6+z18tFcqaWnqozh8cgwQrx6hfLo3TdFbNJW0vLYz0NYB lrW8kn34Wj13py0a70paL7X0hiqn+kXFnDi1zgC0lWYWpynpUqwaF1Bf6N9VZ7VV1tOx/pufC3ID u+O6093tNZaauSlr6aWnqIj0vjkbhzT9Qry36eTQ1hpLbpO0ulbHH1YibkhrcZJA78eVxu9unLZq rQdNqgU/4e4GFryQOXA+HfZXDx3KzGfLGflmE5X0py5vKxXur4PRmc3HYrxEYWbNXVdZdzbFCZSU UIQhXYEinwjHuoEB7plJNAI8oR9VQeUIQgEsplLCAwgoQrABAQgIA9kDv3KEFTQDlBQhUCEIQCEI QA74QjPHCAgaSaSA8oTQeyACSeEuSgEICCgaQKAjygEI8eyMoBNJCAQhCAQhCBJoQgCOUfdHcoQC MIKM8oBJBTQCEBCBJYWSWEDSKPCO4UCKP6JlACoO6OPYoRz9EFgV8p/925fQr5yj5HH6LwPYhvWx /wDhmn48D+i003+4/VbbWXOpqrn2/otTLxAF6Z6jz14UJnuktuYQhCAQhCATHdJNBs7XcZ6GZk1O 9zJGHIIXcndXUr6QQCrLYwMENyM/flcZpuyVt9r46O3xGSZ5xwOB9Spon+HuWisP464ahZTVHTkQ mkyC7HA6urz9kSuLrd09S1VuNF+LfFAR0uEZILh7L72TdrUFnohT0rwGDjqyQV1snw+VDNLzXU39 nqxxOk9AUuQSBnHV1f6LzaH2EuGpLS2sqLvHQlwyI/wpkP79QV2mo81NvlqWKMAOYR35LllLvvqe Rv5mj7Fy6Sg+GqarjeW6oga5ri0tFEXef+YL6j4ZZnMcYdVU8hbwR+BP/wC2hqI/vW8Oprrb30T6 gxQScPDCckJ2/ePUVutX4ClkZEzp6etuc/suruXw43ans89ZSXemq5owS2nFOWl2PY9XdeLTnw/X a8Wp9XUXSnons7wuhLz++Qku6XUltcxpzdO92B076PDpJnFzpHk5JPcrl9Y6sumqrgay71L5pMYA J4A+i7PRmz9w1LX1NOLlSUscL3MEj2F3UQfbK0G5e3V20HcWw14E9LIMxVTGEMefb6FXKWXV9mPG zc9OIJJWcD+l4z91hykBystJq03vje7HbY6Snij6GNA4JHZc7q7dK+6mrqaeqqHNbTOL4mA8NJ7l aXQGi7hrG4GkoZYIQCA6SYkAZ+y7LXex180fp6e8VVwt1TTRY6mw9QdyccZCqXXy21l3/vltomQC Jjy0YJ6iMrwaq3x1Df6Q0rnejA4/M1pzlQ6G98o4+qhpOtj3/vFrt0dMynYQwYBz3Wk1zvbqDVFs fQOf+Hp5OHhh5I9sqJME85wPqsPHcH7Iaje2LU9zskzpLbUyQOd3LT3Xkv17r73U+vcqiSeTsC85 wtYSU2ML3cdkUsfVemiqpKSobJE4hzTkEHspG0XstqrVlB+No4Kanpzy11U8s6vqOCtPr/be+aIq oorvDGWyjLZYCXM+2cDlJ/Etk9pB0lv5dbJa2U0kLZ3sGOtzuSuU11ure9WXJlRUzmKOMj042HAa stHbMas1VQfjaGlghpzgtdUyFnV9uCtHrrQF70VXx016gY31G9TJYiXsP0Bx3ROkm6T+IC52a2Mp p6Zs72tx6hd3XH693WvOq7nHUzymKOHBjjYcBpHlLSGzerdT238bQUcMUB5aamT0+ofThc9rfQ96 0bXspL7TCNz29THxnqY76B3uqaiV9LfELcbTa2U9RSieRox6nV3XE653XveqLsyrlqHQxxEGKNhw G/VY6U2c1hqa2itt1vjZTO5aZ5BGXD3AK5nW+jbzo24/g75S+lKR1Nc13U132KGombS3xEVtstTK aqpBNM1uOvq7rgtb7r3nU17irJKh0LYD1RRsOA0+6i8OOfI/VYuHOfKbOKy2mviMqLfaWQ1VJ6sz W4LicglR5rbdm86kvrK507oWwnMUbTgN+qiwPIGO6TnZKbOMWc038Rr6K0xQ11H6tQ0YLzyCfdR1 q/dm9ag1E24/iHxCI5hjacNb+iihriRjKZdjumzjFobD8R34a0xRV1D6tSxoBd3GVGerd2r1fdSN uhndF6TsxRtPDR7KKgcHOSnkDnlNnGLT2X4kIoLXDHW290tQxo+Y8jKizVG7l6vWqW3UTFnpOzFG Dw0eyiv1T25wlkdWexSU4xa20fEjTxWmFlZQGSrjb3ceM/RRXqPeC83XVTbs2ZzDG/McQPDR7KJ8 k9srEHnk8ps4xbW2/ElQx22EVdA6SrY3ue2ceFE183fvVx1eLyJS3od/dx54DfZRH1nPdZN6nvyM ps4xbug+I+2i2xGpoXPrI2/md4OOVEF13jvNbrP+Nes5vS7EceflDAey5227Wa0udvZWUWnq2Wme 3qa/pAyPsTlcfU0NRSVcsFTE+KaJxY9jgQWkeCmzUW2pviQtP8NifPQufXMbgE+DjnlQ9Xby3mfW P8aMpHS75Y88Buey5eh2x1nW0Laym05XyUz29bZAzgt9+64+ammindFKxzZGO6XNcMEH2TZpb6P4 j7H/AA5kr6OR9cyPjIxyRzyocG815drT+NvlcWl3+6B4DPZcjBtprOaiFbFp24vpnM9QSCLjpxnP f2XJPjkEha5rg4HBBGCD7Js4xcJ3xGafbRCcUkj65sZAJGOfbPtlQ1Tb0Xputje5ZSWOcAYweOnP ZcU3brV7reK0aeuTqVzPUEohJHTjOf2XHyBzHEHIP1TdOMXOl+IjTjaJ1VFSOdXiLpBIwc+2fbKh m271Xin1q+9TyF7JHfPHnjp9lCvqO9yl1uznKbOMXUqviE0xHRSVtPTONxMXSHEcn2H2yqrbhavr tX3yevr5C5zyekZ4aPYLlS92MZKxJz3SWrxgKSEwCeyikhbyi0pfq6jbVUdmuM9M/wDLLHTPc0/Y gYWomhkhldHMxzHtOHNcMEH2IQYx/mCt18KNfeGaYrGMoPXtUcp+drwHF2OwB7qog4OVKe0W6tx0 G+SKECajfyYndgfdC+tLl6IfaHW+5vsdDNRMNQ4zMkbjMh7nCg3a3c206Wu16tF7iZHTyVMj/VDe XEnGCtJqj4jLjcbLU0dFTMppZW9PqM4IVfautkqJ3yvcS9xJcSe5W+Wsbj9uM8es5l9Rdi27obfW KOeS1zTRdQLvTDiWk/YnC4PbXdWyR7iX+8XUimbXNaG9IGOP9VVx08jsZdwF9Kf1pZWsia5z3HDW tGS4+wCx8addLwM3O2+tlwuF4pZnfxCdmJHf58dhjKqfuDqluo9a1l4DA0Syh4b9Aubq6KupW5qq aohHb+9ic0Z/ULxxwSTShkbS97jgNaCST9ArupMYm7cPelmqdumad/AiJ5axrn5/y47fsoHcCXfd e+qt9VTYFTDLDnsJI3Nz+687YZHnpYMk9gBklRp84z0uBVkNgd34rPTtseoXA24jDHO5DfdV2lo5 4cerG9gPYuaRn90U7ZOrDQT9hlC/S6Oo91dJaT09UM0l6BqJ3uf0saAA53JcuU2k3rpTPPbNTyN/ CzOc4PfyBnkg/dVfmEoaOvIB7ZGMrz+s5p+qM6i6Gqd0dKaS0zJBo8wGomc4j0wPlJ5yVz20u81B UsntGqXM/Cy9RD3jLeeSD91VCSqkdwT/ADWLJ3sILXK7WSLo6p3O0rozSf4LR7oXSvLg0MwOnPOT 7rS7T7v2u40E9j1Y6MUz2kNdIMtIPcFVMdVyP4Lj+pWLah7OWnH2Ki6XS1huhprR+k227SL4nvc0 tb0AYHGMn3OFq9qd3LTerRLYtWuhEQYWtdIAWub7EKob6mV4GT+5yiOeVpy12PsUFz9b7nac0dpO O16TfE8lnQ0s/wAIxgk+5K8O1+6ti1Fp+Ww6qMTAxhY10gGHNxj9wqgSTyv/ADOJ/VJlRJEMg4d9 CguVrzc3T+j9Lx2fSjonkx9ALMYAxgk+5x5Xz283L05q/S0li1Y+KN0bQ0F5wHN7Aj2IVOnVcs3+ 8cSfGTlDauSJ3ykg/Qq7FyNyNzrFpXTsVl0w6F4dF05jAwBjB49yvrovcLTWvtJG06rfHDNEAMud 0k47Fp8EKmUlXLLy5xJ+p7JxVcsIy15b9jhTfWhcfc/c6y6asMVi0y+F7TH0kx46Wt9vuvZpjXOl tx9Jfw/U8kUM8JaT1uDTkdnNKpbLVySkF7iT9TlfenqJouWSFh984QW93a3Os9is0Vh026F7ekZM fLGNByAPrkLbWPV+ltztJx01/mip6qBzXODnAYcD3H0I4KpbLUTSDL3lx9+6zp6qeIf3chb+uEFu t2tzrPZbXFYrEYXsaWE9HLWhpBAH6hbqi1HpTdHTNI661MVLWU72uPUcEEdwPcEcKlM88shzI4uP uSvrS1dTT/7qUsz9cJOj2tvuxula7PT0tmsRie2nkY49PLQGEFoH7LoILzpLdDT1BUXOohgqqaRr i17sEEEFzfsVSWpqZ5nZkeXE85Jys6a4VUGfRlLc9wDhBbXdHdS3WSWjtVlEUkdHIx3HIHQcgArq Iq7SO5dqtN0r6iFktLIHOY5/ST/maeeyo7U1M8zuuWQl3uSvtS3aqpWFsMz2A84DiE2Lbbl7r26y 3S32+09EsNDI1zjnI+XjAPthdX1aR3EgtN8qKqJroOHxPkx1Dn5SM+CcqitRXzzydcjy5x7knuvT RXqrpWFkM72MPgOIUs37Wbi3O4m7lus+oLbTW1rJ4qCQFzs58FpA/QrrpabSuvJ7RqN1axvoj5o3 SY6wMkNIz4JyqIz1808he+QucfJK9VLfa6kj9OGpexnsHHCs66Fude7vWy2artkVEGzRUUhL3fdp acfoV1lXaNLa1rrbqT8c3oa3qfH6oAkAHAPPBBVEJ66eeX1Hvyc8knuvdR6huFND6MVVKyPw1riA m0qe/iX1/b742Gz2/EjKaTqMvucYIVbJHZeV6KmpkqXufI8ud5yV5T3V3sIpHlB4TIUAF9PZYcZC yCosd8I15oaC93WlrJ2xS1cbBF1cAkE5GVPWkdLT2jWGo7vJUwSxXFwdGxh+ZoznlVb+HbV1n01f qmO/U8T6etY2P1ntDvSIOf2KshTaz0XZm1lZQ3MSSPYSIh298Dj3CkuuouXaOtP2Kz37de/wXWvq aOtZMX0joZQwlwcc/fxwplsdDfmuq6HUslDcLU9hYyQcOc3/AI2njkKmGtdUOrNX1t0t73wuknMj C04LV8W7haha3/4pVH/iK15MuWdrMmpIsNZtAaXO4lbT0F8rIaqECWkbFIGmN2T1N7fNjjv4KlG1 0V7ngq7fqtlBXW+VpYJIzgub/wATSO/2VEWamuMVxFdDUyMqsk+qHEHJ78rdt3I1G1vNzqc+/UVl Xv3jsdDp/WNVR2uq/EURHXHn80eRy0++D/JSfV2fQddsfHPSR26O/Mo2Eysw2X1ARkH+arvcLjLX 1Lp6h7nyvOXE8r4CrkawsaXAfsmz4081SMSu5zyvmP8AVNxLic91iCirY/Cxqq2O05U6aqZRFWPl fIzqIw8OAGB9VJOjtO1WkpbhX3+6GanhLoaTqd8rYMAj7HORj6Kitquc9tq46ilkdFNGeprmnBBX bXPdHUN1t7qStuUskLuC0uU9TRbu8r7Wr0Jqyz6gr9RWuCo6JaqokljDsAua5obx9RhevR9mrtJi 4V+orp60MTPw9OHdhE05Bz7nJ4VJbbqGst1dHV0dQ+KeN3UHtdggrqb3ulqC8W/8NW3CSWL/AC5V 2i1Oh9SWrUsF+tFJUhlRLLM5gdjJa8dwPOF6dI22v01S1ty1VcxM5rPQja4AdMbHEtwfOcqlFo1T WWi4xV1HUvhqY3dTXtJByurv+61/vtuFJXVrnxZzjKuz2tLo6927VNhu1mt9UI6rrm6c98OcSHAf qvVpGluOm7TV3HV1e2SYsDMeWtaTgZ891S+wasuNjurK+3VL4p2+WnHHsul1JuxfL9b20ldWF8ec gZ8qba3VotOXK36u0lc7Ra6sNq2l4+buCXdQdj2yvZpSC46fsddcNXVsT6iZreogYLA0Y6fqqY6b 1rctP3Ntdb6kxTjIyDwQfBXSan3Zvuoba2lranqjBz8vlLfhN7u1obFW0uq9AVdttFWz8ZG0swe7 XB3U049uAvRpaO4WXT9bcdW1UIqqkCR+G9PRhvSG4/RU40nrq6aaun422VRilwQ4Z4IPghdDqvd2 86ioG01ZMA0HPBxlNru6sWboZWar2zdR2GpYa2FjRg92va4OA/XHdezSTaqxaUq63U88TKmqJmeG s6fTy0ANI9+FT3Ru4N20tcDVW2qLS8Ye3OWuH1C6DV27l51LSMhq5WBrfLOM/da53XH4YmMl2stC 52pttYWadqWGupehzRns9hzhfbTgrLTpG51eqJYYaque+d3SCOnqaAAR4PCqdonci7aUrZJrdPhs gw+Nxy131W41ruzdtTUrIqt7WtaMEMOM/dOXwaizEs0l/wBuaebTU8c1XSBj2gc/Ozu3HusrN+Mt mj7nU6mfBBU1z5JfkJwOpgABz2KqtoPc666SqJXUMoMU3543cjPv91stcbt3PU9OyOdzWNaMYbxl XkLLXioqbpoShuGmHR1NRR9MrW98lrcOGPfuvrbzUW7QtbJqB0FPU1XqyHpdlvzjgKrG3+6t20jL O2lkEkE35on8gH3C9+vN3LhqiGJs2IWMGOhh4dz3WfVa3VkdRVNZVaKtd10wI6yeic2UAHOcN6XD H6lfaN0tDt3Um9+jTVM/qSFrXZblzsjH7qsO327N00i+WOB4lpZeXRScgH3C9Wvt3K7VEcbcCJrR gtYeCfdWFyqyGsqiudpm03nTkcda+jcJOgHhwLek/tlNzZrdttO28tipaqUOe6MOyA4v6sA+VW3b neS56UhmpXOFRSv5ayQ56D9FluJu5V6nbGGj02NbgsB4J91Nbu0l1v8Aqyeva+vp7Jar1p+mZXtp nBzmA8Oa5vT4+pSqhJb9tHRXYR01U9mXM6gQCXgkAque3O9Vw0zRSUNSG1dIfyMkOej6D6L5bjbt 1OpjGI8xRtbgsB4z7qw3daWP3Cr62gorRebNTCujiJa9rXcFr29IOR9SOV963qt+2kUNyDKeo9Nn WwuHB6wSB7qu+3e9tXp62ut9dE2tpP8AA2Q56PoPovJuJu1UakePSzDCB/uweMpbvTEx1tYrcetr aGK03O20Yr6cdUcgaeCHgAcjtzjlZTNNBt3bIa5oppmmHqjeeW4kBI/RQTt7vjPZLSbbdIW1tM3/ AHfqHJaPb7LWbk7ry6kf/s5MUHiMO4C3M/UvwzfH3ue1iNw7tXWee13C30Br4JA6BwaePnGG8+OV p9cNkptm44KmMwztp29UTuC3nkY+iinb7fGS1WYW28U7a2OMj0nSHloHYfotBurunJqZ5EDjHTns wHgfRa8OcxzmV+HPzePLyYXCIkvTwauTHbPC1RK+9VN6shf7lecnK55XeVr0YzU0CsVkksqSEIHd Ad0IRhAkwcJeEBA0IHZCoEeUICAQhJA/sgIQrAYSPB4TPZGUCCPCCEIDKEIQCeOEkDugAhHlCBJ+ UIQPIQl5R5QNJNCAyjCAMIKAPuknlH3QJAQE8IFlJZeUFAkePujyhAIx3QjKAQnlACBI7I/VB7oB NYgcp9ggYWOeU/CMIDCEco8IF3R4QU0AkU0YQIhGclHfuhNBoQkgYQlynkIJ/JXzl/3bisRK3wcr 5TyDoPI+y8D2yIe1cQdSVX3H9Fq5h/chbHVZ6tRVR/4h/Ra+Y4jC9M9R58vlr0ITW3IkIQgEIQgF nGMuA+qwWcX5hngILN/DDbKcwmpMbTKZcFxHOF9PiWvdZRapttLBO9sLYRL0A8E5Wv8Ah21FSUEI ppZGiUyFwaTjhdlvXt5U6vrKS+WyqaWxsbHJE5o4bnJOc/6Lr4tbvJy8m9zTrdob9FerHC1wLyWh pz2B85Wz3PvdPpPSVR6DHNfOXRRmM46XO8paGoKfSGjRM/DmRs6nYAHZeyobDrjStXB0iNs7SA4t D8A9jjjlcpO+2st66fPa8vn002SV4fI5rHEu5yeV4r5P/ZSOgmpJXyvq6l8bi4kt8EcH2W50HbKi 2WE072k9ADWkf4unI/Rcxatva2svE9z1LUTSMilc+mpg89LATkEfXslSb0kCmnigskU87QQTl2Dj GT9lnNBDDQVEtOG4kYT8p44B+n1XN67mkotv6ySHLJGABvuPmH+i++kZpKrRrpJXF7jDnv56VrD/ AGieS/pkrLt1f6ul3HqKSF59KaoeHNz257qdN86eCp2kuMlTEyR7Ig5jnNyWnPcKGNp9I3G76/qL hFEWU0Ez+p7h3JPj7KTviL1PbbToSexSTB9fUsDWMb3GD3I9l08k/wCa79OeEv4ppTN/BK+9vpJq 2qjp6aN0k0jg1rWjJJXwkGXFSJsgyL+21KZcYGTkrk9KdtmNqhp+3tut9nfDK5od0Md0gff3K7be y3m7aAdQUhA9cxta5/1PldJqSnlr9O00VuYZn9cZIZzgDutRuvbrjcdIR09liL6xjozjt0gHkn6B a8et9vL57bj1Ec2bYHSlHYo6q+yV9TP0h0j6eQgN/QDgBabXGyOlm6ZqK3TNfJBVRjrb+MqMtIHJ Cl7TkOobRY6f8d6FyD2hrmwNc7g+4K5je3RUd40jLW0c4tMsEZe+OQ+nG4Y5BA8lMMZldV0zyuM3 Ig/Yeh0s261E+qG00ro3DobMA5uPfB4K8nxE1mmKu/UjdJ09NDHHGfV/DxhjS79F9dlNv6DV9ZK+ 8Vb4qaJ3T0RPDS79T4Xg3+0dZtHX+lpbBUyTQyxdT2ySh5ac+6k/W1v3pFX+JSLslY6W96zpoK6M SRMHqdJ7Ej3Ud/6KUdga2Ci1vDJUSBjXMLRk+VltcHVkVzpLbaqHTbY4nSPDXA8DpxysrzaqW8aU Z/HKeGofC7JDhkBwPhGrzdbhaqGp0yY3SxSAvDjz08A4X3u1ZS2uwQ0t2qGR1E57Z5JJyuu/1xef W7lKw1Qy40VutVHpyOFjpH9Lg49LQ0AFK/WmhvWmIv47Sw1Do3ggPGQHAgcLHWRutZbrdU6aMb5I pB1hx56TgcL03itpLZZKajutTHHUzOAAzyTnJ4XN0efVouVBSWmh05HC0SPIeDw0MABWOo7Jb77p +jffKOGokilaQHjIDuoDhPWz7vUU9rqdNsilayXE3UeQ04HC9d4rKa22uipLhUxsqZJGkDPch2St fCfNeHV8t2t7rPQabpoTC9zvWDj0hrGgdlym/too7ptVVVlfTsfVwMD43+WOzjIXV60kvclRa6jT 0UU0HWWzOcRkNdgDAXJ/EFdaW1bX1FBWVDG1k7A1rAeXHOSuvjkuWLz5WzGqMS/K8/dYEr6TEF5P 1XyyuGXuvZPRHuhJCimuj0PpO5awvkNstUfXK8jqcfysHuVzgHKsT8IbGf2qrnnAPps/qUG8/wDg ZKWBkLKvVXoTuaC5n4UO5+nK5zVvw53q3XShgstUK+lqT0unewM9M/UZVg9zNdVumLxR0dDan18k 7ctDIy7nPbPhaG+Xvcarqbd6enI4oHSB2BOzJ+/srpjkjc/DDFD6UdVrCKGpeM9BpM/t83KjzdzZ y56AEFSagXC2SYaapsfR0vPgtyf6q3lRXUVyfS23UlK+nr2ASN+bHP0cFX34oLPqSgdBNPVy1Wn3 OAiOeI3eGn/qt4Yy72zl5LLJIWxO2ejr9pOa56nInne4hrXTdAjAPjCgnXdFRW7VlzpbWQaGKdzY cO6vlzxypf2f2mu2r9MzV8d9NspS4hjGsLy/3JGQAoa1bbn2jUVfb5JfWdTyujMnTjqwe+E1+t6J f31tpgMlTv8ADBoe2an1JLVXeP146LpeyI/lc73PuoJHdWh+DiaJlZdQ97Wud0gAnvwuddU3z6ju VPrMWmjtLv4RA1jX1DBhrS7wfovBqDbDTFy3AoLtU0LfxRDnuYOGPLcYJHkr1XKvu7dbx2uO0uNB UObIazORhoGQupq54H6ko4/WjE0cbyWdXPOMcfou2cm+nl8eVs7c63U1wGsX2mK0uFohLYjUtHyh zgDg/utRcdqtL1m4tPd5qIet0mV0Q4Y5zTwS1bCe5XUa6FlFoeKGaUVBre7SGgcffIXUOmidqqNn qs9RlO4FmeRkjH9FMpq3prC24zbn4tUV39tH2dtpkFqjxF+Ja35A4jsVoZtpdLzblNu0lEC8M9Yw 4/uy4HvhbVl1uf8Abo2N1plZRvmFT+MI+VwGO36rqGyRv1b0iVheymILOrkEuz2WspN+vhnx5XU7 aOl1RVTavmtAtcv8LY78OKgN/u+rHIP7qr/xUaMtem9TQVlpj9EVzTJJE0ANa7PgeFZSjuteNcus ZtU0dN6xqjVuaelzc8YP3UGfGTURvvVrjZI1zo4j1NByWnPlXxYy3KX6XLK7x/7VmQhC870hCEIB dhtbYP7Ra0tVC+ndPDJOwysaM/IDzn6Lj1Lfw6Xmez7gUApgC6qIgcSM4BPKC5V9uVLou3WuOKk9 O1dXoyCNvyxNxwT7DKrJuNt47X+6dUzQsNOaV0IknnyWxNfznJA7lTP8Tt/qrLoJsNK4NFdIYJDj J6cZ4UcfDPrGuooqiglt9TU210mX1MURcGE/5itzLUsc7P224yT4aNasY93XbSGgkYqCSf8A3KiG 5WmstNzloLhA+Cqid0uY8YP3+yv7PSSyitvOj7n683TgUj3ZiLh3+oKpduxdrpetb1VXe6f8PXgN jdF0dOAO33+6zrrbUvekiat2MobLtQ7VEV3qpK6OmZO6BzGmMl2MgefKr1Jw9T3rHTW4tFteyvvF XC+wthY50Imy9rTjAIwoEl/OVGjiHU8BW1+GbbW1Q6fj1hdB+IqSXOhYRxEG+R9VUyl/3oyr6bDN B2VpGMBc4xy/KOTznhJ7L6e2mqrHuvZrnaLnQP8ATYct9SPpc1p/K9v/AFC5PanaWy6Onud7uUn4 6ajmkbE57f8AdtZ5x74XZ7bXmG+XGolpaaaBtJSx0snqs6fnaTkfotiGF2ldRANc8umqcNaMk/TC 1qXLTnysm2iabBu5p+42qvonMbG7MZfH0PjBz0vb/wDTyuX2k2rtGhxcr/dZhXVFJJKyJ5jwI2M4 JA9yF2u296pb/dKurt8MscEFLDSuMjOnL2k5H6ZXvqAP7F3s9DnguqT0sGSeT2WMN5XVaysk6c7V U+nt3dM19vqKUwvgeTG8x9LoyfyvC5vaPbGz6Eo63U90m/HVMPqNjf6eBGxpIJA9yu329u9Hf7jc K+2xSMpmU8NOS9nTl7c5/bK+1Q709ta9/SXhomcQ0ZJHqEn+S66nyxyuq528W3Tm8Oja2nZAyCop 3n05WsAMTvB49wqR6jtrrVdqqjkcHup5HRlw7HBxlX70PeLdqCovNytDC2lc2GI5b09Tmg5P8wqN bkn/AOG66/Wof/UrWOMvjyy+mOdnmmHxpy2cLAlM8hYLi9DLKAVimEH0blzgBkrs9N7b6r1HbW3C zWWsq6MvLBKwAAkd+5/muVtcYlqmMd2Jwr4ajuU2kdpbVLZg2ne2OBg6GjAyBlXGcrpnLKYxUD/s t1gaSrqW2GudDSPcyZwaD0OaMnjOey+Ng221VqG2ivs9kraykLiwSxgY6h3HJVxdztRVdl20hr6b obNVMjErg0fN1t+b919NstVW3UejY6K1VEVrr6eMMMbQGgOAwHY8gpr9Zl9pjnMrlJ8KYak2+1Lp qgbW3yzVlFTOd0CSVoxn24Kw280bWa11RTWSgnigmmDnCWUEtb0gnnHKtvuvqCu05o2ah1Vb4rxT 1cbmNqms+QOI4B9iPBVXNsam+0es6KTStPJUXNvUY4mdyMHI/ZNNy7fHdLb247e3mG3XSeCofNCJ myQ56SMkY5+oXDgqT97L1qS7X2E6vopaOvihAbG9vSegkkH685UXjuoNjaKCS5V9PSwY9WaRsTc9 gScK5Wm9u9H7ZaQZPqalpLhWTlvqPqIw/LvZmRwMKp2246tY2YA5/wBrjyP+8FercCos9JNZ36hE Jof74H1m5b1GPATHvLTWUkxlQ/vJs3ba+jp9R6LZBBBMWCWAcMIcQA5vt35C6yxbd6K220vEdSUt Hca2oc31JKqNr8u4BDMjgDK62VsY2soxBj0f7jo/5fVbj+Sy3EktMV1thv4pzSGGdo9doc0PIGO/ nupepampvSG95NlaSZ9Nf9FNijpat7GS02eljS8gNez2HIyF2tn270Nt5pijbqWio66vmc31Jalg cS84B6cjsPZdi1g/7N7IGnLAaTH29Rq+O4Rsrb3Qt1CKb8O+kqAwzgEB3GMZ8q+P9pLSzvUQ1vDs lDJcKO7aMETaK4SMY6nJAZG5xw0s9gfZdtadt9BaI0/bqTU9FR1lylcHPlnGXdR4OP8AhC7Yt/8A hS0qO4E1IP5rw7ix2Oe8iPUAg+a3yfhzLxh/V4PurZ6Sdq/fEJtTBpiRt/0+Wmz1bh1QjgROIyOn 6FQM/wCU4V09+ow7ZqjDxyGw/wDlKpZPw8+63cZMMcnPDO3PLG/DApAhYk8rFc3R9gVl3XxHdZNP hFfVgLuACSTgALYMs1fIS2Oiq3OHcCJxI/kuu2RqbDSa6oZtTwCajDvlz2Y/jpcfsVdu91N3a6mq rDRUVxoXjqeCQ1zW98tPnhQr87PwkrJTE6OQSA9JaQeoH2x7r6PttU2T03U84k/yFhB/bCtvebpt 1c9xrZcKyhcytLiydzm9AZKCOlzh7gjCla/Vd1pKmCW32yluNse3re5uA5jRzx78dlUfnU+B7Hlr mkOBwQRggrq7Ftzqa+aemvdstklRboi5rpGuGR0jJ47qQfiEk0vcr7BctNsMVXNkVbOnpBcPOPBX o2t3c/sjoupsc1AJ4XvkLZM4A6hghWT7EFSRmN3S4EEHygDsvXdZGy1kkjB0hzyQPZeUEZCWd9Dv dp9B3TXV+FHbyIoIcOqKh3aJvjjyT2VlblslpKpoprVb6qphvbYOuOR85eA73LexGRyuP+Dlg9fU bx5jhH8ypH0/a6RmsLdd4Z5HV81dVwVDTJkdIa4tHT4xgFTGSy0tqvVg2f1DddayWGtgNL+Hd1VF QRlgZzgtPnOOFMF22C0jU0NZb7PVVMN7ZCHxuknL2tOeMt8g4IUuRDp1fcHNHzGjh/8AO9cXp600 1Pq21XWllmdPU1FVDODIXNIAcQMeMYTKTGbSbt0rnpTZ+/3XWJs1bTSUkUEmKmoLflDRzwfqOyly +/D9pqot9fT6drqkXiJgcxs0vW0E8gYx2OFL9sz/AGov5HGGQf8AlK5LR9nhpNVW6609VPJJWxTs nY+Tqb1NzjHtj2WuPuxpWvRe0d+1BqiS2VFK+lgpJQ2qkeCAMYJaD7kdlKmqPh4sk9tr/wCyVyqz dabBFPUSNcw8Z6eACMjscqa7QOi+akxgfNG7j39MLldB2b+H6ht9wirqiYXKje+aKR3UA8Ecj98Y XPO8fRrdUivNrqLXWz0tZC+CohcWSRvGC1w8LXgYU1fEzTRs3Cr5GtALy0uIHc9IULlvscrdmkl2 xWTXEFYkICivp1ZTB/VfMfmX0YMkBD2+kYLjy3K+pDgMdJVmtlNstMv0A/Umo6Rtx9aNzjFKMCMN J5aRzyt1TaY2q1Tb66ht9FDbano+WUuIc0+CCScrOOXKcp6XKccuN9qk/Nn8n80ODgfyYVsNsNoN Jm1VlRXelfalj3MdFnAYWkjA58hfWp0BtpqK33Git9GLLdI2kB8jnNcx3vgnBGVpLVSW5cQMcr6S xuiyHNc0jw4YK34oxYtVRRVBbK2kq2l5ZyHBrwSR9wFMvxAar0zqywW6W0uY+shdyegBwaR2z90k lvab0rkTkrIHHnKUgHW7HunC3reRjxlFMdTnYDSs2MeRjBCtTtxsdpyTRFFcr/FU3Gqq421A9BxY WNcB8oA74917tU7E6dqNOTz6chq6GuhBe0VLy4PA7ggpraIO2z2qvmvIKipt0kFLSQnpE9Rnpe7j LRj2C++5G1N70RHTy1ckdZRyj/1iBpDWu/ynP9VaSnp5bXtpaaWymGkqZY4Yg4Mw3qcACThfLTkV TX6HvNs1K2KrkopJac5GQQ1oLT/NXRelWtt9rb5rmGqntr6enp4OPVqSQx7vLQQDyFhuDtjfdFSw C5sZNBOPknpyXMLv8ucd1bO4U9RQaMttFp1tNRz1IZGCW4ZlzeScf1XjtENTd9vLhR6nZFUVVG+W Jx7/ADM7OB9/qrwTf2rppnYnVV8tTK8SUdCJDxFVlzH48Ht5Xi1xs3qfSdoNwrW01VSg4e6ke5/R 9TkDhWkvtDWah0TRw2aqbSVADcPnJYDhuMZwvM+lq7DtbWUmopo56j0pGvljLnsIPbkgcc+yzjLc pj9meUxxt+lEZg5pIJIOV8up3utrqCJrKuXo7BxwtO4rWWPG2JjlymzLneCmJHYxlfLPCCVGmfWf dP1CfK+ZP6JD6IPp1HwUF5Pkr590IPoHkc5P7pulcR3OF8v1SPdB9RK5vZxQ+VzgcnK+RKEA45KS EEoBCEkAU/ujsEIEjKMJYQNJNBQJPuEkdkD8o8o8pqhBCEIBHlH6o8qwBGUAITQY+Uf0RjlPz7oE QhM9kkAhCDygPKEHuhAAIHdGE0B4Qj7IQJHdHlNABHlL7JoBIp9ikAgP6p4QhAkwgpDygaQPPunl BPKASKfdLB/RAJ+Ein90CKAnjhAQJGUeUDhAFCCj6oEmknjhAjyEEcITQHhLHKZQgMpJhAQCXhNH hAvKaQTQS+Kwe5Xymq8tdgrS/ifqVjJVfL34XhfZ/HI47Ubuq+1J9yD/ACXgqD/cNyvVe3dd3md3 zj+i8k/+7AXoj5efuvEhCFtyCEIQCEIQCYSTCDbWq5z0M7JoHFkjDkFpwurm3Hv00bYn1bvTaeGg 4Wm0ZpS46ouLKS3RFxJ+Z+OGhTJdthbbarJFJX3+eK5S8MjEbS0u9u+UKjO47iX640YpZ6x5h/yg 4yvda9z7/b6JtPBOBGO3CkC5/D/T0Oj5bpHeKqWtYzq9JsLS0n24OVjo74fRerF+OuN4mpJHNDgx sAIHHnJCI5aDeXUjGdInaQPcJTbz6mkZj8Q0fQAqRrf8Nltqacyf2lqg4fmApm4/ql/8DVQTRPfS 6pmeW5/+NW//ALSGkR3rdDUN3pxTVVSfRBBLGZAP3X0burqFlsNBFVOihLek9PBwu+vnw4VVLZJK y13k1lU0dQgdThgcPv1FfGzfDvU1lgkr6u9tp52MLzCKbqHAzjq6v9FZ76ZutduB0/uXerDTvht7 w0OJJdznlcnqG+V18uElXcJnyzvPLnHKkzQGzL9V+o6W9w0bWkhuIC8u/mMLk9z9v7joO8fhK3M1 PIMw1Ibhsnul3vslmunFk+691quM1vqo6imeWSsOQWrXuycre6Q05Vamu8VvoSxsj+S53Zo90bSP Qb5ajpKVsMRYOkYyCQUVe+GpqiB0QmEYdnqLScnK+uu9jK3Slkgrxdo6ySV7WCFtOWYJ+uT/AEXs h+Hy5u0tJd5rxBG9kTpfw/oEk4GcdWf9FrjdSucyxytj4UW/WoqOBkMYi4H+Yhc3rvdfUGq6L8JX VBbTHl0bSefuo8MZzkg8d1jI0dx4WNt6bS1aguFs6jQVUsBd36DheC519Rcah01ZM+aZ3d7zkr4j BbxnP2Xz6SCSe31VVieV6qCrlpZ2yROLXtOQ4FeYoBwPukE16d34vlotzKZoY9zRjrLiCuS1XuNe tR3VtbWVT+pmOgA8BcIGj6pPA9yFU0nHT+/l6tFtbTCJsj2tx1l2FxeqtxLzqK7ivrKl/qNx0AHh q4QAFuOUHBGG5yUNJ1sG/wBerVbG0/oxyPAx1lxyuF1RuPetQXoXCrqXiRpBYGnAajbjbG+a6c82 t9LBE0kerUuIaSPAwCVnuZtledv20jrvNRytqCWtNO8nt75ASbvpLqa27yxfEHeLXbG07oGyPaMG QnkqLdf63uesLq+suUzn54YzPDQuVf54K+Z/VTa6jEnIKxCy8oxlRWCF9P0P7JEfdBiF2e3WsqzS F3bV0hy04EjM/mC47HPlZAAc8oLTR/ExII2h1tGQMZyCuUum/wBdq3UMFcGBtPFx6IOAQoFz908h XaaWpb8TTRG0G2/MBg9lEG7W6Nx15VxioPpUcX5IWnjPuVGRJJ4yj7gpsmLu9O7n6i0/Z/4Zbasx UvOAByMri7jVy19ZLU1Dy+aVxc5x8kr4HGUiM4wm6aYhdLonVNdpe7xVtvlc17SOpueHD2W60btR qzV1tNfZbZ61MDgPkkawO+2e65zVenLjpe7SW67wiCrYAXMDg7AP1Csxtm4bkullI/iVibawG0Bd WBmA53uogbuvehq43p87nyl2XN6uMeyjDrd7lLPuSptOMW0d8SlKLbllATWdHSHEdjj3UQUe7V6h 1cb0+d8kjnZc0ngt9lFjA9xAbkrMxPY7Dw5p+oITZxi2k/xJ0QtxMFAXVvp9Ie4djj3UP2rdq8Um sDepZ3vfI/L2k8Eey02mtrNYahtbLhabNPPSPyGSEhuceQCey5W92euslznoLpTPpquF2HxyDBH/ ALypqLT1nxJW8W6R9JQE1xj6WvePP3VYdZ6krdTXieuuEzpZZHE8nhbyw7Yaw1BbGXC1WOqno35D ZBgB2PYE5XI3W11lruE9FcIHwVULul8bxgtKnZqPAhdvZdrtZXq1R3G2WCsqKST8sjWgZ/QnK5Su t1VQVs1JWwvhqIXFkkbxgtI8FRp40LtrNthrC826Out1grqikkGWyMZwftkrUWzSd6ud6faqC3VM 9wYSHU7WfO3HfI8INApN2K1PZdK6sFxv1OZ2sjIh4z0u914DtFrsBzjpi5BrRkkx/wDvrQWbTN3u 12dbLZb6mpr256oI2Eubjvn2QWP3f3l0vqvRVZbI6IzVMg/uXv8A/ZO/zD6rl9h93abRtDNartGX 0LiXtLe+T3yo6m2t1vGxxdpm6ANBLj6JxgLinRSslcxzS1zThzSMEEeERcml3v0RaoppbZbjDK8E /IOnqP1VYtw9Wzas1bU3ioawPfhrQBgdLTwsINAauqKBtZDp65yUrmeoJG07i0txnP7Lmaehqauq jp6eGSWeRwYyNjSXOd7Ae6uzSWtW713LUGhBpyWnjjgdG2N7h3Ibj/ooZcepxPuukveitSWWkNTd bLX0lM0gOllhIaM+58LnQx3VjHKilGS12VOuxO7smkZm0Fze59rce3+T7KJLfpe919vfXUNrraij bnqmigc5ox35HsvFQUNVV1EdPRwyzzSHDI4mFznH6AclBb7Vu+9ht9iqGaXiDaudznE4xhzu7vuu G2l3vktFylgvz3SUUzy8uJyWk+VBd309e7TE190tddRsccNNRA6ME+3IWqBIJAzlNmlwdX75WC22 CeLSjAKmdznE4wAXd3fdchtFvh/DKyWk1A8vopXOeHdy0nlV+baLrJbvx7aGrdQ//LHouMf1+bGF hbbVcbgZP4dR1NT6eOv0InP6fvgHCJqbWy1rvbYLXpyWm0kOmeZzicDAaXckj9VzO0O9sVDJJQai eXUb8uDjz0lV8uFhvVFSuqK6218FO3vLLTvY0fqRhaYvew48q7vo4rf7g71WG1aYdR6QIE0nUOBj ozzx+6qPeK6S41s1TOeqSRxc4rzeo8jlfaioaqul9KkglnlIJ6I2Fxx5OAm7rSTGb38vIe3ZYkL3 Vduq6VwbVU8sJPYSRlpP7rCmoaipmEVPFJLIeQyNhcf2CjTxkIwvVVUU9NIY545IpByWSMLT+xXw xjGe6D12p5jqWvAyQcgK9lPXUdy22tsetbbVU1K6OMh0fLeAOkkjsqHU7zFI1zePIVldCb/uoNMw W680ArXwjpDncgtHbhEs2kv4gnQxbY0v4UH8K2SEx9X+XBxn9FrtOa30LqHSVBBdnMt1TAGtLID6 bgWgDOR4Kh/eHeKXWFBHQUcApqNoHUweSOyhU1kufld/NbyuNxxk+HLxYXG5W/K6O5m5ekoNB1Vu p5WXQyxmJsczusjI4Oe/CrPtPrCPRmtaS8SxerHEHMc3POHDC4SWple35nEr4MLiTgrDtOkp7769 pNe6hprhSQmJkNOIcHueSf8AVRSD9V9nxuA+bhfNreUGxsNfJba+CqhPTNE8SNP1Byrj6S3J0rr7 SUdHq58MdRC5pcH+XNIOR7dlSrpwvRBPNH+V2PsUVbbd7eCgpoobTp10Zp2FrnOYMN+UggAeMELo 7Fr7SO4WmIYtTPhiqYHsc5r+PmaQcj6HHIVKJJ5XOy85+5yvpBUSs/K/GURbHdzd+go/Qtenywww PY4uZjp+UggAe3C6a1a00XuLp+gm1BJBFWUsjXOZJjPUCCR9QfZUollkdy52SsI6yaEYjeW59igt jutvDR0dZS26w+kYaSVjw5uOnLTkY+i6+g1NorcO0WyvvksEVXSvDix5xyO7T7tPsqPPqJZT1OPU fqV96auqIW4jlcwe3VhW00sb8RG5dDcaN1gtHQ+mjIBe05BI7Y+mFWaU5dnuvRUTPldmRxLj5yvK 4cpbbNJMZPTA90l9ekYQWgBRXzCyHcZWXSEyAOyCQ9k6nT0Gs6f+1VMyooJGmMB/YOPYlXCtdPbb Zc45rPqeKC3gYbQvIkjA9m5OQvz9hc5jst7raxX6vjaGipkAHYdRCKtxrSbbyp3HpX3SnjlnnaY5 5WPLWOdx0uOD37jK7yzU9Paa/rotSxm2gYZRyHrDG+wOVQWa6TyydUkjnOHkuyvVFqO4MZgVUoH/ ADFETD8S4067VcVRYy1tW8O/FhmOhzvDvuui2V11pe2bWV9hvL2+tI+cuje0EPDhx3Vbayumq5S+ Z7nuPck5K+OXj8nGUH3u3p/i5PR/3fUekfReRvKyfz35KxACCb/hs17SaSv89NcgG0leGxul/wAh Hb9OVZKj0/p61aiqdVMrwWOYZWx+rkNeQQ5wHnIKoJE90ZBacHK6CPU11/DekayfoxjHWcYTdgtf bN4LRLuDJFUFsdJMxtMJs9i1xIJ+5K6q36bsun7/AF+p3V/XAQZY2iXIjLgQ7jznKok6rl9TqJ7n Oc8rc/2ru34X0TWzmLGOkuOMJaulrtPbtWafXlZTVBbFBWFsbJs8dTQQM/ddNZNM2vSt0ueoJLk6 WnOXxNMmRE135hjzz5VExXTCbrD+c5znn7rdyazu0tKad9dM+JwwWl5wQm9lWy0jujZq7WNwo5iI WVrgI5CeC4Dpx+oXQ2HTdv0dVXK81N0kkpwXGJrpMtiYcHpx75VFoq+cTCQPIfnIIPIW9qdaXqoo 3U01dUPicMFrnEgqe+qOg3x1JTal1bVVtGCI3HHf2GP9FGAX3qJHzOJcc8r5HgrQwITA4TacpjPs f2UGOD4C+kRw8crHKyx7d0vo9drp7Jyw3vZYWuhmjfWNilifHnHSSTjK4+xbG3J5rajU9y/h0TB/ dGmeH9Q8l2Rwq/6V1ddNNySOtdW+D1Bh4a7GV0dVutqKop5IJbjI6N46XDq7hY8ePDDj8Gd553NP 22ejau0UE1y0zqH8ZcY8xz0bmtEUjgcd+44588rttR6f/tfpWRmoqb+F3GFpLKljweg+4I8HyFTr T+v71Yp5ZLdWywmb84DjgrcVm7mo6yllpprg90cg6XAnutyJY0c9EyLVzKOvlY+MVjI5Xhxw5vWA 459sZUq7/aR0xZrXbavS7YouolkgikLg4YyD3UD1VXJLO6RxLnE5J8r7TXarqKdsM0z3Mb2a4k4W scpLvSZTemslGJXD6r6URHrnPtjK+bgeok+UNPS4H2WVXvtE9xm2cs8mmD61c2jhawRuGcgAELUU NDuJPZamsuF0p6GRvUBTTNyXNA/zA4Gfsq1aH3Nv2laJ1Jb6uRtM49QYeQD9Fu7xvHqG6W+Wkqak ujkGD7ha5daY497WOoKg6v20hisFS1typQzLCcFsjOcfTPgr1W31dO6OuE2payM1lb1zSYGCHOaB jH0wqj6S3Bu2ma6SptlS6J0gw9uch33C2Ort0rvqaKNlwqAekYAHCm2tLSz1EmqdBU02laphrqXo c1pOD1NHLT7ZX1p3T6e0VWu1LUQCtqzJI4s4GXjgYPsqk6L3HvGlKqZ9tnIbKMPY45B+q2Ost0rr qeKMV0v5BjDexGcqynftZvcaC4Veg6H+BslnnHQR6BySOnwvnp6CvbtDUw3yKSKs9GYOZL+bucfy VdtIbzX6wW0UMM4lp2nLA/kt+n2Xo1NvVeL1a30lQ9rGnyzgqf8Aljd+ks3jlPtF2pAPxsw8BxWj JC9NfUOqZnPcT8xXkd2Vyy5W1cZxmmJ7ozwjv90sKKEIRhAIQj7oAJu5SS7IDyg9keU0CPZIBMlL zhAwml4T+6BIQUkDKSCEHurAIQhKBLKfYJe/CgYQl2TCoPCEd0IBHdPCSoaSaR7IA90f1Rj3QgD2 Swn5QUCPf2KAmAhAJBNCARzlLlP+iA8oQhAJYTxygpQIQhQCEHhCAyhIjlNUJATSCA+6MIKfZAk/ CPKECIQEFAQA7p+EIQHZIJpY5ygCjKCjwgB3QUIQHHlA5KDwgIApJnshAJjskgcIGkn4SQJHCZ7I QdT6pwl6pdwcYXmLieE2cux7leGPv5+mnvGP4pL4wGj+S8s3EY9l6bwf/SspHsP6Lzzf7v8AReie nxc/deFCChbciQhCAQhCAWcY6nAeFgvpCcPyUFsPhkoY4rQ2YNHU/JJxyuZ+IG81VJuVAyOZwZBB HI1meMknP9Fsvh61PRUdDHRPkaJhnLSecFdBu1t0zVF8pL9R1rOzY5o3EflHbH7pGMpvt3u1d5F3 sjOqNxa9vd2cL4bwX4ae0s2npYHk1knpB7c4j55JW0tctLo/RzZWvY4Na0dPUBk9l9LhBHq/SVTB M9sbZWh3VkHkc/6JC+np0FH1aY6ZHkdbAC7ue3K52+Vo0zWWWktsvX+MMrZHHyAB4z9V1OmKOej0 46B3SZCzDPnHPBHPPC5XS23zqSV901BMKiuY1/psL+oMyPHKuk7d6KiGjtVM6f8AJhrTzjuvneYo 4bHXuhx0vge7IPH5SuU3MqJKbQTHxuAkD4fP/FytnSyF+hax735caZ+Mn/hKuM1lK5523DKKzbL3 qqZq99G2R3oyOcQM8DB/+0ph+JaKM7YPL2tc8ujIcRkjlRrsFoyvrr666vAipWEgOJ5dzycLpfif 1fbmWJunaeUTVZLerpP5APddbZ+a5X0x5Jb4sZjO1UiPmK6jb+9PsuoKeqYekBwDj9PK5h3c/ddh tdYHag1RS0zcCNrg95PsuD1rv6UqKPUthhEzBMzpDgXDI/T6rk95KqSpgpNKWl8lNUVQHVI3gNj7 FdXNWUWjdO0UT2DD8RtIaMAn3WV8oI7tSUdzibHEYCXuJaMuGPB8LeFuOtuGcmV6R9R7C6Rp7XAK +grK6pIBc+OZzc/oF49Q7BaTbQMqqOnrKJkbuqVrpnOJb7c9lIm4cuoH2Cjdo6A1NSXgOwQAG47r jbtY9XNtNPV6g1FTwNL29VF6Ry7nt1dXP7LDq8M+xeg222G4OhrIqdozIPxDj1fr4XJbrbJWCh0Y +86X9enfCOt4mlLw9v8Aopv1E1x27IZ5Dc/bqWr3EAZs5XecU5K9Hiwlyw36tcPLnljMtfCgzhg8 rp9vtI1esL9Db6RwYCQZJD2Y1c3KMSfqVNvwv+nHq2V8haAY29/uuOXVsj0e4lJ2xOhLLQ0ovctc 6ok+XrbUFocfthaXWPw/2SpgpH6Trn07zIBK2olLy5pwOPqF3XxA2K+6ht1oZpmmmqJI5nOcYjjp BAwSV5dutE6i03PTVmpLxFOH4AgOQ5pz7nul6jlhnbbtpJNidB2iCjhvlVXmsm+UObP09ZHfAwub 3O2CpaG0U9do1073dQa+Gok6i8EgDClXdizXK7aj0zPbKOWpggmc6V0YyGDjBK72u6YrZRxylrH9 cfyuODweVcpJrTHi8mWe+U9I32h20Zom3001zrpfxkmCImuw3qPgBaf4hNJ1msdR2C1UbgzqLi+R 3ZgyBlSTf6eqm1taJoo5ZKNkZ63NaS1pznk/ZfO+wSnXtrqfTeaVsRDpen5Q4u4GVrx/rb/0z5P+ Tj/KjH/4HXSVJFDHW1N5lnLR1GE5bn9G8KON79lKXR9kZebDUTvoWENmjqnZcMnAI4Cn/c2/6stl 1o4dLWyaujlb87mNJa058nwoo38brb+xJl1FVW6OieWl1PFI4vJzwMEDskw1e1/NcvX2qy5uCeOy 3Ok7OL1fKWhfO2nbM8AyOGekLUk8n7qc/hZsNBdNVTVVwjZIafpEbX9snuVyenbv7d8O+kqyGBrL tevXc0FxDG9JP0y3suIOxcNLuE+zXO6uhtxb6kT2gGV7SePGMq1EtbXR6wgoYIpG21sIcXhnyZ54 yoz3FoK2XenT1RDTzupvS6DI1hLM8nBP7Lp48ZlvbjnnZZr5c+/4Y7Cyd75L5cW0fQC13ydWfP8A hXK6o+G6spr7QQWCufUW2oGJJqnAew+cAAZ4U1b4XSusmmqCtoIJJnQShz2sBOGhvJOPC1Ozm4dV rq4vNW1sTKUABo7ZIS4axmX2uOfLK4/TjJPhw0rTzR01XqW4MrHNBLA2P+XC8E/wzMbqaKnF3nNo kjyJixvq9XkY7YXc6wornJvpbJ46aqdbxTAOkYwlgPPc9lLlcD/FLaARhvX1f+HhMsZjpMc7lLtV iH4fKSbX8tjjvNQaGGnbK+Uxt9TLs4A8Y4XnZsLQO3BmsTr7KyiihbJ6pjb6rnOzwB2wrCWelmZu reKh8TxC6kha15b8pPzZGVwN2hq4viLo5DFK2llpwA8tPS4jwD7hb4Y6yv8AHLHy524T7c2Phjtk Nc+Os1JUMhfgQYiaHOPnPdR5r/Y+8ae1JSW+0+pcaasd0QyFoDurz1Adh9VajXLv/hw0kwdjPLn/ AMIXS1kYdqKgf0AlrJPmI7dliySf9x0xzuV/6rjtodE1uirHT0dfcxO8s4gDMBnuAfKqz8TuDubX Y8MarY6ckqZ9xtQicyGGFsYiyPlALecfqqpfE7BKzcitkfG5rHNaGkjg4Hhd/FOOOc/jFy5eTDJD R7r70dPJUzMiia58jyGta0ZLifAXwK7faPUFHpvWNFcLhTsmiY7HzDPQfdeR61hdk9oLfpS1t1Rr ZsYqWt9SOCX8sI7gnPlcbrq+Q7pbo2igtVvjkpaaUMHRGAXszyXEeAp41haqbdDRX/oqudFOY+uL od8pPsR9f5KruhKe86N3UpqGoifT1wmEMjcdwT3HuFu6mO44S5XOy+lxb/LVad09Rm1UgfHTdIkj jGOmMDk4+irtuLVWvczdLT8NlpxVdHSKkhvBAOTk+ylv4hbrX23beWSgfI2STpY8t74IOVVvZa71 lu1/bzSOIdUPET/sSuv+vimX2xhvPy5d9RdDUtVPpmxUclto+umpi0TRxN/LGBycfRV415/Ctyd3 7G2wUzamNjW/iulgAcAcnPupX+I+7V1r26e+gkex0zmxvLf8pByqybG3mst24NuFG49VS4RP8/KT ypl+vil+avjly8mW71FzdS10ml7RQy0FGXUVO4NmZE3hkeO+PYKu2tIbRuHvhZzYaVtTStYz8X0M AB6SSSffhSf8Td4rbVoJn4KVzPXeI5CDjLSCq6bAXmtodxqJtM85qnCJ/njK5eWcPFMvmunhy5+S 431Fw9VXQ6Tt1vlpqNxt0TgyoETeImYx1EDwF4tEyWC63W6XqxRUpkm6Y/VYwBzsDlcr8T12rLZo aBlI8sZVS+lMR5bheb4XqaKPb6WtawGokndlx74C1NcZ9sZct229R0ugrtq6u1PcoNRUElPbo+oQ vLeH84GD54XIag3A05t/q27titlN+NmDXGaBrQTx5I+q220mubpqbVd5t9wka6Kkz0tAxjkjB/Ze cbW0F/3Mrr7dGMNupSwMpmjDZHgZy73C3nOMzcscsrcNenRbYX3UF/t0131BEyktsjSYWP4Jb7n2 CrZrnTLNa7v1VJo6CN8UpaHGNuGMI/M448KT90tdXLU1VJpbQtHUVLGAiY0zecDjH0C7PYbTv9nt EVM9bQ/hry58n4gyN+cY5AJWZZjjr5rrN5Z7+I7LTFuuNq0eKG8TQTVEEJj6oc9PSG4HdRZsBoGz UFvqNV1EInr3Sy+mXgERNBP5fr9VIO3Nznu+hKivrX9csr5y4n2GR/otds0Ora9sbMOkLp/lHJ5c cLE9O1+a9Wn7xT6+ornbL1apG0krS5rZ2cPjdwCMqv1m2HkuW5F0oGGWPTlFUY9Z/Dnt79IP091Y Hba6y3isqXOt09HHQxNpS6UYLnj8wH0GB+65yv3ZsmmbvdrVXROkkFU8ktPBBwlk30zhbqb9uymt 1ste31wt9jZHHR01NJEBHwMtbz+qjTYfRNm05pWXV9RD+JuDmySNcQD6bG54b7EqT7FeLZVaHlut JRiO3GOSUwjBDgBk/utNp+aOu2sq57ZT9EczJ3xU8Qz0gk4aAFvHuTG+tueV423+PjQz2/dPTtwt l+tcsOPmYJ4y1zWuz0Obn+qgLQWx0181vcIK71WWC31DozOW9Jn6Tw0f6qxG3d3Ooa+vuDaGopIY 4IqTE7cFzmZ6v2yuYZuvp6xmss1yie6VlRK14B4OXFTL1W8bdzt0+trdbaDaa7UNqhiZQw0kjGMY OARx/UKKdrNf2HS+imUFltkst8e0ukZFGXOkf7nHKmWa5Wg7cy3D8GDaDTOkMGc5Zk5H6qqGkrtd tH6mqdV2qy1JtLjI1kjoXGJjHHAHXjCvV8X/ALc8bZ5r/wBLO6Ku1RrvS1xZqe0Oip3n0jBUQlnW Mex/qqp23Zy/6qu13Om4KYUVLUuiBlm6ccnAHHsrWbY6rk15pitqq+MNYH+kWtyPHPK1ulbFa9D6 OuN4qTUTwTyGd7C/HSM4AB+3usb/AE/u3fGftu3rSp+t9pdUaLpYaq9Ucf4WR3SJYJOsNP8AxccK y20ujbJtzoVmp543T3Cana98vTlw6sANaPbJC6fdWanrtmrhUU8Z9CWnY+NruSAXDC+9U9sG0lun 9J80cMFPK9kbcktaWk8fYLF+25Zpp9R6fs27+hpJqqndSXCm6gyUsw+KQDJBHsfZeHbnRth2w0UL 7URuqrhMwOfMGZcS7gNaPbK7PRNyivNjvN0pYnx09XPI+IPbgub6bQD+uF473Vst+3tprZonyw0r oJpAxuT0tcCSt4zlWLWi1ppKzbu6G/GyRGjudM14jn9PD43tGXMcPb6FVgsOy+sdRURrLZbA+m6y wOklbHnHkA+FcjRVbDdNL3a5UjHspqueeaPrb0ktLQM4+uFz+496qtNbUUlZbXelOyOIAt+oU8eN zsiZZTCbVM1dtHq7SFu/iF6tvRSNOHSRSCQN++OyljYjQ+hdZ6LlorjB1agy/qm9QhzQfy9IBxwv nBvhdZNH1lFc7W6uErHxmZzC5nIxye3GVGG1H8el1nRx6Ya81j3jIbw1rfdx8BRt4t1dB3PQuoJL fcAXwuy6nqQMNlZ4P0PuFwLuDgq++9kdmftrJTaydFLWekTE5gw5svTwRz7qhdSMSEd0GDTyp4+G nbOh1Zc57veXB9DbnNIp8f7x5GQSfYKBmfnH3VwfhAbnSt9x+Yyt4/7qT3EyusbY4/4ndT2S7ijt NqpIRLSSlzp2MAceMEceFGln2g1peLbBcLfYp5aSdokjeHtHU0+Rkr6apt8113EqKBv93LPW+gC4 flLn4yf3VyLXS0GgtOWS1XK41TngNp43NcQHu+3gcrp58ZhnZj6cv8fK5+KZ5e1ELnpK82q+Cz3C 31NPci5rGwPby4u7Y8HPut/ctqdZ2yFstwsFdFE57Yw4hpHU44A4Pkq1W+FDTy6i0fUGFhqG1zR1 9I6iOtvGfblSXcK5rbnDQywskZJDJN8wzywjH9VjXenXfW357ap0TftKywx3+2VNEZgTGZAMOx3w QcKV/hn0/Vfxw3Cq07/EbVN/s5nlhD2Ru455/wCisJr2gotY6Dt4utLG9tVPB2HLOp4B6T3HC+t0 utNo6u03pm0UzYIKqVsbOkdmhwBH1JBTjfacp1tB3xcWK3UFXaJ7fRwUrnRPa70YwwEA8cBVpdw4 hWo+MVxElnA/+RvP/ugqryfmJ8Lp5JNY/wDTl4Lby39hvcBWT+FfS9DV091r79YxWUcoayCWan9R hc08gZCrbER6jSrhfCLfKms09crVK7NNRFr4h7dRyVydr6V33UttNBr+8QWuAR0/4pwjiYzp6c/4 QPH2Xyj2y1hIwSN05dCwgEO9E4I+6mbTdsprh8SNVFWQsni/FTv6HjIyG5BUn7qa+uOlNW2q20IY aeoZGXAjJBdIWq5dZ3H6XD9sZftTc6Pvn8abaTaq4XNw6m0xiIeRjOQPbAXol0JqSKrhpZLHc21E +fSYac/PgZOPfAV8rxRUr9Xaar3QM/GdU0fq4+bpMROM/cL13W801NNXSS04kfbhG4O8/wB5xx7K f0fnuNK3d91NsZbax1xAJNO2Il+AM5x9l9JNG35lZHSOs9yFTKCWRfh3dTgO+BjnCvxcrVRx67st zjp42Vckc0b5QMFzenIyvTc7xSU1RWTy03XLbnRsD88/3oHb90XT89YdOXWa4vt9Pbq2WuZnqp44 XOkbjvlo5Sh09dJ7hJQxW6tkrY89dOyFxkbjvloGV+gNRaaGn3Ao7jT0zI62oppWyyNGC8N6cZ/d cTpiBjd/tRSNaATTjJx56WpdzG1m2TKT7UkraWajnkgqYnxTRuLXxyNLXNPsQeQV8AfZTD8TVNHH ubc5WMAc4tLiB3PSofx+6qy7jJoyR5Csvt1oLSdXs3VVeoaCOK8OEzmTzF0b2jGWEZxwq2UhxM0+ QchXn0ZejqbZJ1XWRRlwpZICMZB6G4ytePXOSuXmtx8eWUUmkts7qiZtPBLMI/zGNhd0j3OAsWWm sfCZm0lS6IEtMgjcWg+2cYU8/Dfen23cGe2NjY6G4tLHZGSOjJCn99zp7Jru3aYpKOFlNcIpKp2B 2dyTx+ieSSZ5SfDrhjeGNvzFAGxEEZz7KyFn230nW7JSXOaD0r8ymc4ymRwcHh3GWnj+S0fxF6bt umtf0tTaKZsDKhjal8bfy+p1HJA8dlOldXs1HsjVXGWCNkk9C4npHkHGf5LlnLPNhjb7W3/hyynt S222ee5XaChp2vL5ZWxZa0kNycZOFM+8+01s0foqy1NtZI+4AmOqlBJEvGerp8LxbKa4j0pd6igf SQziunjaHPHLHZxx+6sbutqyHStop56mjiqo5i5hbIMgcLpw3lZE5axm1A3gtOMeU44XZBIPPZSH o7SNNr7XNRb2V8NohlEkzHPZ1jjnpAyP6q2Nz29ttdtlBpuWSlBhgZEytMQ4LTw4f/bWVVZ2c2ur tdXETzZhssEnTNLnBeRglg9uD3Uxal2G0tcrTXR6OqZYbtSn8skxe0nGek59/ddnsvpx2lLJfrV+ IjqRBVvxNGMB4LAQcfqs9v7TS0F9t9ZQ1Ej3VtC59SwydQ6w4c/Tv2WbuTbWUkz4yqVXu0VVmuU9 FXwugqYXlkjHf4Ste6M5A7K7kFwsFRr7UGmr3QU0jq6fqje+MEvJYAW5x9FjYdttKbew3a518MdT HK8iP8Q0Pa2Pu1uD9c8rTKF9jtoLTq+wVV51DXPZShzo4oqeQNe0t5JdwV3Y2O0LfbdVwaautYLh GzLHul62td46hjkZ9lHVHqC1P3LmYyae16arqlzpoqZ/QGZbjgDgDKsVtnZ9K2uaufpOtlq55Ix6 nqyl4xnjx7olqGNvtg6esprnU6uq5YoIHOjYaSTBa5pIcTkEEdlun7DaQutqrm6ZvdXPcImZYZHt c0O8BwAHBUuaXdJU2C8sucQgpZJ6gPcx+S0EkO8fzXg25sdgs5ub9M3CWvmka31GSvHy47dhwrrV 0XqdKP3q0VFquNRSVTemaB5jeAeMj2K8IGB2GfuFde2aQ01FartqW72mnrpJnSOkiqI2vDOl7gek kcLRUlPtfqq03G2i1W+1TObgSNa0Pac92ux7q5Y6ts9MzLX65e1RA445C9FDQ1NwnEVHTzzy4Lui Jhc7pAyTgeAt7Npepn1RJZrSx1dOZnRRemM9QB/N9sclWl0JoWybT6bfdbtIJbvJH/ePOOCRgsZ9 PupJu6buUntB+0m0FdrZ0lVXvnt9raMCfpHU44yMA9wtvudsZPpyzMu2naua60TWkz9TR1NGfzAD wp+nqMbSsqKB5h9SFhY5vBaHPA/oV9tu6KpoKK822sqZKuCJ/wDdGUc9DmZwR+qtx1jyZ5S53D6U Lkgka/HTx7oZE5x/KrbUegdF6709VUlBTxUOoKfLXTsJ6uoE8lucEFYUG1GkNIaJkk1hE2quT2ue 6UOLXMcRjpZg4ICz7uot69uE0RsFU3jS8N3vF4ZazOBJE0RCQdBAIJORz9Fnq7YGutmnpblZLzHe jFkyRRwemekDkj5jkj2Xo24uFdql9Tpmo1K63UFPFmn629ZcAcdIyR2Cm/SlkbpXQ9wp2XB96aXS PMkcYBbkYxjJ7fdXXekqiklNJFK5pYQQcEYWAikfJjpIzgAK21Ntho206ZF11XC6rdUvEvWC5hYH NB6cA+OVpNR7Z6Ivuk6i4aJmbSVtOS4NlmJEmBktIJyPoQtcL8emL5JN7cppf4frvdNPxXC43emt U8h4p54S4dPcHrDvI+i8ut9irzp3T7rpS19Pdo4yfWZTxFpYzH5hknK3WhLlrLXoi05DW/7FStAl qHNyYmjgD6nwpZ1leLVoLRr7QyQzTSRlrmvf1EkjBOfv4Tjq6Xn1tWXbDbar15VV9PR3KnopqZjX tZMwu9TOc4weMLm9Y6XuulbvLbrxTuhqI+3+V7fDmnyCtzprUNVY9UQV9qlMUrZgD0n8zSeQf3Vi /iQoae5aAoK2eFhq2uaWyY+YAtyRn2WMN5eT8br5Jw8c8l9KcyNJP3Xyc0jOQpI2dqbTbdxrbUX5 kTre0va8SsD2glpAJB+q3nxDR6fqNSRVem207YpIR1iBoA6gfb7Lcwt3/HPLKY6/qF3d0vKzf3WC y0aAUvKEAUeEIQACSfdCBJ+EIQCRTSP8kB4R9kimEB2QEIQBSTKSBJpDumfoqAo+qAghQLymkOE0 B9UIGAglAeUFCPKoPCaEiqD7oJQghADsjymkcIDKEFLCDJYoymgAhCWOfdAFNLzymEAOEj/NNCUH hHugBCgCkE0EIDKEJKgCY79kkwgEJFNAIQkMoBPyhCAR2QhAhyEBMd0IEkAcLJIIAoCD2QUAUBHh A7cIBLymhAI4QgIEU0IQCMD2QhBuyVkw8/qviSvpG7LgvHI+7lempuXNym/T+i+Ev5F9rif/AEnN +n9F8J/92AF3j4+fuvEmkmtORIQhAIQhAJt78JLId0G2tVzqKCdk9NIWSt7EFdDUa8vlQWGWreeg 5aCcBY7eaFuOsLkyno2ObDn+8mxwB9FL+odjtN2ekp4XXq4C6zkBkZLHN+pxjKiW/aILjri9XGNs dVVvexvIaDgLY0m5V/p6ZsLKt3ptGAOFJ+qNhLdb9KPr7XcLnNXAMxGWte0578AZXp078PduqbB+ Nu11r6efo6sMawN7fUJtEcs3b1GxgYKoAAdsf++sZd19RyDmrxjxjhS9QfDpp2poGzuvt2Hy5cWt jwOOfCR+HXTs1HJPR6gubw1pPzMjxwPsqILvW4F6ujWMrKuR7WEENBwM/ZfSs3K1BVW38C+skbA4 dJazjIUq6m+HNtNYRU2O6VNTXdIcYp2NDHDzgjlfGH4fKVukZrpWXmpZVxRPk6GwtLMgZxycqze9 RLZJuoxtO419tdF+GoakRMxgYHIXIXOvqLhVyVFXK+WaQ5c9xySVMe22y9Jqqi/EV18lpy78rIYg T/Mrg9ztB3DQt7fSVgdJSOJMFRj87fGfYq6qyxxZK3ml9RVmnqwVVvcGy4wcrRHukstJBu+5d8u7 4XV1SXCF3U1o7ArZS7v6ilpWU4qSyNuOB5UWjGeV66Wnlqp44adjpZXuw1rRkkrW01EtU2+GooIG xNLMDzkrR37dHUF4qIZKupcWwu6mMyekH3Xc6Q+Ha43e0NrbvdW2wuAIj9D1D+vzBcfuXtNddF18 EcZfcaKow2OoZF0kv/yloJwobj6Ve8OpKyjjpnTBkTCD0tzg4914dUbragvtnda55wylcMOazIyP ZdvpT4dbpd7Uysul1jtZcARG6n9Q8+56guD3W2yuWgq1jZ3GroJB/d1TY+kE+QRk4VmViWS+0fPP dbrTF/q7FXR1VFIWSMP6H7rRk8nK9FHTS1c8cNPG6SSQgNa0ZJKi1NFJv/qOGIMDWEAeCQtJdt4t R3G4QVM1ScQnIjGeldPpX4cr1drUysuNzp7a94BbE+AyHB9zkYXBbg7a3jRt8it9RGalk56YJomE NlPsArtnTtoPiD1HFC1gZEMDH5iFo7rvJqG4XOGsnmOIjkR5PSug0x8Od9ulqjrK640tudIAWxPi LyAe2TlRvuToS7aFu5orrH1ROP8AdVDAQyUfROzUSM34gtQ+g2NrWgAY/McFeK4b8agrXwscQ2OI g9AccOwoWac+O31X2o6WarqWQwMdJJI7pYxoySU3pqyJ6j+Iu+RxBggYOkYGXFRvuLuHeNazMNym Pos5bEDxld7Yfhy1Jc7TDWVNdRULpRkQytcXD27KNtYaFvOl9Q/wivpXOmc7phdG0ls31am2dRyH b7rqNCawrtJ3MVVEcg/mYTgOUl2b4cdUXO1Q1klVb6N0oyIZ+rrH7DCivWuk7npC9TW27Q9ErD8r wD0vHuFF6TPL8Rt4dCxjKZjQBgjqzlY//BF3h1RFI+kiLY/yjq7fyVewR5Xqo6aWrnjhp43ySyOA YxoyXH2CSmk26x3/ALzfrNUW+OFkDJ2Fj3Dk4Ix7LgNBa4rtIXT8TRnqjdjrjJwD7Lt7R8O2sLja 4qxz7dSmRvUIZ5HB4/QNKjK+aVu1n1A+z1lJIK9r+lsbWn5+eC33BTdJInUfErcRGAKFoIHHzZXL Sb53ubUrbpN80bR0+kDgYStvw8azrrXHWE26m629QimlcH/bAaVE2o7NXWC6z2+6QOgqYjhzSCM/ Ue4VlNT5WBm+JOukY1raNoHkZ7rS3PfyvuF8t9bJSxGOjLnNZ5JcME5UB5BJCGtJdgYwptOMT7dt +62vv1vuElI0x0fUWR58uGO69lb8RFxqrrS1Rp2tihz/AHYPfP1XFaL2S1fqm0tuFFS08FK/8hqp CwuHuBg8LktcaMvGjrq6hvVP6b/8MjMlj/sccrXK04SdRO0/xK1D3M6aFrWZy4diVFu8m5tRuBLS iWBkMVOSWgNGST7lffSOyOsdUWplwoqOCKnf+T8TJ6ZcPcDHZcXrXSl10ldpLfeqf0pmdnNyWO+x 8qS2+l4yXtzayY4tcDlYr12+hqK+pip6SJ808rg1kbBkuJ8BZaSdtNuzcNFTenIXz0RHEZP5T9F1 FfvdBcdeUd/rLZE9tLEYom9I6m5Oc591zcmwmuobW6tktkLYmx+oW+u3rxjOMe/0UXTUksUzo5WF j2Hpc1wwWn2KqdVZTV/xERXaw1VFFbWF08ZZ84BAyMKItptZ0mjtUC51dE2q6Wlrc92E+Qvfp/ZX W9/tUNxobSPw0wywyytY4j3weVwOoLNXWC7VFuucDoKqB3S9h/qD5H1V5XWvhJjJdrFa6+IOlvmn Ky3w25jnVEZj+cAgZHdRVs/rOh0Zqb+JVlG2pIZ0sJGek+4UcEk917LVb6u510NJQQPnqZnBscbB kuKXK2a+CYyXcWO3F37otR6YrLbFbWF07CzqkAPTnyPqoy2X1tQaL1I+5V9KJ3+mWxkjPT7lK+7N a3s9lluVbZnClib1vMcjXuaPfpByuDtNrrLlcIKOggfPUzODI42DJcSlts18JJMbbPlYvc/fa3ao 0hWWqG3tMlQ3oD3jPR9R9VzWy+8X9i6N9vr43S0WS5gHue65DUO0GtbHZ5rlcLLIykhHU9zHteQP fAOVHJyw8FTa6i4DPiE09TMlkorXHFO4H5mxhpJ+q8ekPiDoaOkqW3SF0k8szn9Q9j2CqX1EHutj aLbW3eugo7fTyVFVM4NZGwZLiU2nGRbil3/0tSSvlprWyKR/5nRxBpd9yFqrL8QtFDerg+sp3fgp 3dTWDnB7cqCdQ7Z6w05bJa+72OppqSPAfKSCBn7FcvaLXX3W4RUdBTyVNTMelkcYyXJtdLZU3xC2 CmndFT2/0qLpOI2NAGT34XCaa3sjs2tK+qhgEVnqpS78Ozsz7BRTqXbrV2nLca+9WOrpKMENMrwC 0E9s4PC4uR7gcZTa6Wy1n8QtCbFUQaap/Rq5ySX4xgnufuq2OvT6u7CprHmQOkDpMnlwzyuddI53 cpN7qbNLm2nfXSFHYIbfHRdFMyIRmHHykYwRhcNoPeqCw6nuAdF0WSomc+OFo4iB7AD2VcWudjGf 3WzsVnuV7uEdFaaWasq3glsUTckgeVqX4TjFm9f7/UDrBJR6VhME8pd1PxjGe5H1Vc6K8NkvsNVc uqaEzNfMCclwzkp6l0jqLT1PFLfLTWUMcri1j54y0OPstFTwSzyRxRsc+V5DWtAyST2AUv0skXMb vdol+n/4caN34P0vT9DGGluO2FotJby6aFgqLLf6NklvBLI4CMtMecgHPdV1uehtU2m3yVtwsVxp 6OMAvlkgIa0Hzlcy8uz+YD9VN/Bxm9rgTbz6NsGnqmm0pRRUsjgSyONoa3q98LyaP3q0/XaYkteq oGyx/lLD+Vzc55VRi9+fmKQlkaflOE2aXRl3m0ZUWastdTADbwz04YMZHSBwP3XJbU710dshmtN8 Jfb2giInkhv+X7YVWxM/PJ7rY2i23K7VPoWyiqayfHV6dPG6R2PfAGUVaDczfC3ssMdr0iPSY5vQ XAYDG+wXn2n3vo4bZJa9UOL4A0taSM5B4x9lWm9Wu52eVsN1oqmjlcOprZ43MJH2K1jZXM7OOVdp pbLcre22xWaG1aVxHAWdBI4w3tgLa2PdrR2o9HQWzVcTX9LQ10R7Hp7FU3M7zy4p+u8HPCbsNRb7 VW6ejrJoeos+laaH05WuYIekFo6hgk5Wk2X1/ozRei55RGGXuQuMziMl+PygfRVcfM9+OcfqsfVe OCU2aSDuluFcNZXaWeplcIckRxg8AKO3HqPKbup5Wwp7Jc6mlFTBQVckB4EjIHOaf1AworWjg5Uu 7F7mTaIu/RMS+3zuAlZ7eMqLqq3VlLEySopp4o3khrpI3NDiO4GQvM1xb27oLM706n0hW3qy6j09 0G7R1DJKgt4D2twW5+uR3UmzbkaG1XaLdVXqcsqac+s2MPx0vH688hUdEzyQCthSRVczSKeOaXHf oYXY/YIkmlx9Xa/0lfrTbayaqxcKSpiljDTjGHjqyPPAT11vBYKGvoqy2TNrD6MsTm9sB2P+ippJ LNG4hxc1wOCDkEJNfLKcN6nv+gyVZdGlyLjubp1u31sbS1jH1VOYJPS85a4Ej+S3FXrbQ18ktd7r qofjqJplhaHYDXd8H35CpBJJLH8rstcB2IIKwbWyNHDjj7ps4z5Wv3pqrLuRp+3/AMCnNRfstbFT sxg5OS05UIz7Ma8Bz/ZqtcPdpaf9VymmtS11ku9NX0MpbUQPD2nPlS+z4gdUFgc6SAeO5S3fSY4T HevlH9ftNrS20M1dWaerYqWBpfI8gHpaO5IByp9+Gu86T07o90tRXthu1Q8ioa93gH5cD7KObrvz qSut1RSyujMU0bo3Ec5BGCofM8ocS1xaPsQo0sXqPUmn9Kb20V/tdR+Lo54y+oAOeh7stcR+mCpL 1O/b/WFwoLrcbsW1EAYY/TlwPld1AEfdUhlmlOXdZcR5ym2vqWAYkcB9HK/OydSSL03TcTTz9YWW lZWxmGDrkdPnjJYWgLmNabjWSlvV2oRUNmiuDKfplYeGlp5yqeuuMx56z1e+Ufi53/mcT9cq760l m1+67Wen5b5ZZWXSAxt9QE57ZbgLhtV7hWSkvV2tpnEjK6Wmc2ZrstHSR1Z/ZVDiuNS3hsrh/wB4 ofVzSO6nyfN7kqSrPtefUmvrBb9Q2arbWxTRvbJE8scPlDunB/kg12lbRqiq1PFePUqKtrIJIQ5p aASBkcZ9vKo0+41HDXvcQO3Kf8WqMBvrPI9i48JbuaS471fpPnxH6eZfNSwXHTAmuklRHmoipmGQ sIOAeB2IULyaF1LG757DdwT2BpJM/thdBtrubc9GXWSqpz6zZY/Tcx54IzkKVW/EddXNB/BQgffC hIgGr09c7U6F11t1dRRyO6WvqKd0YPvjIGVdXb+l07att6ey096hlgmic4yOcAR1jJ/ZV83M3fqd bac/hVVRRMaJGytfjJBHsVF0VyrIY+iOoe2MdmhysuruJljMpxvqpd21jo9N76RU9RXRPp4J5Y21 BOGvBaekqZtS3i3f9t2mar8bB6LKOSMv6hgEh+Bn9VS6WtnE3quc4yZz1E8r7PvVZJI18s8jnN7O LiSEtttyvy6S6kk+FgvibqqO4autYhqYnROgaxz2nIbl5BP6A5U1Wq2WiPboaep7tA6J1MY2zdQ8 85VE6i5T1ZDpZXPd2y45XvgvVyihDG1UoaBgAPOFnPWWWOd9xPWNw+K2RH8F1kG1D2ubR1rXOc08 ENeDx+gVzLvT6Z3Atdsqqyrimt7AZDCXgF2W4weeMKh1RNJI8vc7L3HJJWxob5cqOARw1MjIxwAH kALUysu01LNOt3PhtFh1zUnSc0kdG0h0bermN2OQDnt/1XejfAVO3osc1MRVthbGJg7kkHOVANZU STyl8jiXOOSSvgHuA4Jwoq0Pw/7l0cE1RZL1IGCrkL453Hu4gDBUq2iz2LQz7nd3XD1Wvc4xtMmR GwgYaBn38qidNO9kjXRuIcOQQecreTamus9MYJqud8Z4LXOOE/7N9rTaCt9r1dqqu1tV1MTRDOWw 0wfhzHMx8598jwutrblZNxLVd7F+MbE9ji1jg7B7cO+vKpNQX240AeKOqlha/wDMGOIBTpb7caOo M9NUyxynguaSCVCp+0ltNpu80V5tVxr5YNTUU74/VbN8mOCxwb2IUg7Q6EqNvv4lUXW6UdQ2aNrQ YsgANJPk/VVDh1Pc4K51Y2rlbUP/ADSBxBd917pNfXtzHMNxmLXDBBeeQrtnS5elbrQX+yXu3UNV F+IMs7fmOAA8nB/mtZtfpGv0Oy7VN7rKSSKZrS10DiQA3Oc5A91Tu16quFumklo6t8Ln/mLXYytn NuJepYXxOuEzmPGHAuPKu1q4Nkno9SaOutstlXE6fqmYeo4x1PJB+3KjW07GiCmuNXq+5mJrPmhf QzcNb/xAtHOVXy1atudsmdLQVUkLn/m6HHlbKq3Ev01O+KWvmc14w4OPBCvPrTNx3lyWW0BYdNbf aYOoZJvXrJmnM0hGSQSMNx2BHhQhuduRValub2+oRTtJDWjso/qNVXKa3iikq5HUzSSIy4kArRmR zySTyVMbpu99rlbY3u2672vbp2CpNNcIaZsDgTzluCHD3GQF09oij0FpSWo1BXy1FbM0OmL3dRLg MYafYBUj05qCvsVa2pt9Q+GYcZYcZC3971/ebxA2Kvq5ZWt7dTiVrfWvhnX7XL5qzG0emDZhVauu lT6bKtrnRRggtETjkF3scr2bp2d+vdGR3DT0zZJoAXGHI+YeRn3VXafcK+x2cWv8dK6jDekRuJPS PYLOx7iX2yQSxUNZLHDIcuZ1cE9uyxJMbbGsry1tJ8Gy1VW6Wob3pq6mtuEnS6SmcGxhn+Zod3yD 7qXNtbRdNMbe11PqfohqXPkcMyB4DS3AGVVax7l3uyiVlBXSRxSO63MDsN6vfC2F03Zv9xoX01XW ufE/jGVqe9s1ZnWNvqNT7W09PYmtqpjHGA1rh3AwQopptn7/AAaaqrjcLsy11QJP4Jw+VwGO7we5 H0Ua6c3Qv1ipnQUNbIyFzurpycZXrvW69+u1Gaatq3OjPPc8LfO64uc8U5XK/K0cFpm0roiGLSNs 9WokaHPYH5dlwBJBJ91Euptr9TX7T1df7tcGQV8bXSfgJYiSQPHWHYBx9CuBoN6NTUtJDA2ue5kT Q1pJOcBfWt3r1JVUssElSHxyNLXA+xWZ/rxW4/tyjTbZaEuOsdSilpMR09O4PqJ3c9AzkDHkkhT1 8Q1yo6fR0Fq9drquMtJAPgDBVctI6/umk7lU1VqnEZqG9MrT2dzkLX6p1bWahrJKmsl6nvOSAU8W sM7m35bc8J4/hvdpbLbdS7hUNtvD3toZhJ1dEnQchpI5+62e+mj6PR9/ZBaZ5ZaKWISNEjuotPYj PlRjRVs1FUNmp5HslY7LXNOCF7b5f667Bhrp5JiwYBcc4C1Mtb/qZTemkeMnKwIWbj90u65tPmey PCZBz90sIH4SPKYGe6eEGHhZYTxxlBGQgx8I8J4TwgxwjCy6UYKDHCWOVn04RhBgnhMo8IElhZdO UwPCDDCXZZ4wUi0+VRj2R5TPCSUB5S/VMI/ZQJMISKDJJAPCFQIKEFUBQkE0DSQEIGsSFkhAscIC D24QgEx3S8oQMpFGUJtNjPugjKEIbAR5QOyFAI8oQgMe6E0KqSSfZCBJoR5QLHKaEFAscpo7IQB7 oQShAIyl5R3QNIplJAI/mjKPCA7I7d00HlAj9EFCEC5CYQhAeUIQU2gQgHlPKbVtAF9YgS4fdfIc BfaF4BC8j7eXpqbgMXKcfUf0XwqT/dD3C+1xObjOf+If0Xwqf92ur5OfuvGgpLInK25MUIQgEIQg F9YG9UgyvkvrTn+8CC43w4U0cWnaZzWAFzCScd1Fu694qaPdupk9R5bEWYbldjsFrCip7bDROeBL GMOaTjhbHcXb2gvGqqa/0twiayV49eJ8gLj2x0hb8eWscpXHy425Y2JP24uZu1ljd6L+hzMlxBHj suf3ovk9utlHbqSklMVTK1r5gCGRjIwM+5XQS3ai0npiIwSxnPSxrfUAOTx2SvdNTar0uY6qoZHj EoIeAS5vI7/ULm3W103G2TS/RK4ta6Nwc4eAW8lchdrlDZ9R2602l7RBU05c8tdnPjnnyF1tDSyt 0q+lbNB+Jkgc1v8AeDAJaQMrmdKaAorDTvrblOyqurmYMheCG8dhyqzdu8q6yChpKITloa8MZznP bv3Wp14GQ6Muvo9PQaeRwI85B+q5rdutdDaLKYZQHmeMHDh2xythqabO2FeTIzq/CvJy4Z/KV18e OvJh/XDy53LxZ9ekAbA3aqlvjqP1Hel0h2M8BSH8V8LRoOkcQC71G8+ey5z4dtE1TZzeauRkMDmA BpcMke68vxRa6t9xgh09QOE74Hh0kgPDSOMLWFk8ltbyxtwkitb/AMxSKHfmJykuMekw3J+6mb4b bZT1eq3SzxNe6JrejIzjlQ03vzlTF8PV6pbTqF34p4b6nSG5P1QWw1hR1NS+0wUdQaeMSOdLgd2g DAXtqYGOsdMZmiVwkaMuGf8AEAtffKCbUsVuqbZXOgNO8uc1rc9YOM85+i+eoNS2qymhtFRUtfVF zXEdQBGDnlK4zfy9GsKKrqq2109FUmniYXvl6RnqAxgLmN8YY37RXR0zQ97Yhgkc5yulv9vqtQm3 1lrrhAIXkyMAz1NdjPOR7KOPiP1VbrToaXT/AKwlrqhjWgA8jB7lbw1b2z5LddKbyN+bjhTh8MFm pa3U8tTUxNkkhLRH1DOMqD3HJKnP4ZrzR22+TMqpA2STpLQTjOFzy9dPRFmdV0txqr9SRUFYKamg idJI3GQ8jGAtjc6enqKa2SVUMcshkjw5zQSCStdf7VcbxdKGvtFe2OnHyyx45LT35ysr7qK0UFwo LVNOx1TG5pwCOOn3XS/GvpwnrufL5arprtU6kpY7fVMgooITJIwg4cR2AwuG+JiGGXbISyxMdMTG Q8gEjPsV3eorXdLveqCvtFY1lJ0+nKwckg9yov8Ail1JbabSbLAyZslcSzhpz049108WpnLfWnDy 424fr72qEeHED3U/fCnYaOv1HNW1UDZZIC1sfUMhqgAn+8JVifhVu9Hb7hVR1EjRI9zS1pPPZcL7 e74WE1G27yapaKOoZFbqaFsj2EH5ic9v2W1utsoKuvs9RVUsUtR1Dpe5oJHGe6199td3r9RUlZbq mMWyVnRMwdxgd/5r0XTUNpgv9Bbn1LTVQfMWNI44wq5a+3i1F/Gn6s/2GeOO20sDHyNeTkkk/lx9 lGnxb0NK7RdDWGCM1RkDRKW/NjGcZUnXu2Xqt1TTVVuqYhaZ4wyZuTkYzyfvlRD8W2o7c+x0dkhm a+tY8Pc1vIAxhdPDZMu/THklsmlS8/MRjPKsd8JOnaGuu1XcqynZLPA4NiLxkN4zkfVVyyA8lWe+ Eq60VG2ugnla2Z8mQ3POMYXH/p3qbLhPfn6ykMD4WWimYzLXE5cXd+nj+q291sVrqNU2quqaGCSt a14bM5gLgAB5WqrrfqCfWsUtPJAbHOwdRGeppaPP3W1rL9bHanpKP8Uw1NO1xc0HOOoYW8/fTj47 ddtLU1eoX6zqBmBllp+hoBJ6nFwHZRB8Ytso4qS01kdPG2rfI5rpQOSAOymKpotRSa4HQYDYpQHF zfzAtA7qFfjAv1vqmW62087ZKuF7nSNbz0grtNcr9acJLrH/ALVcPHVhddtfYptQavttHDGJAZWv kDuwaDzlcee5XcbQVNZDrW2toev1JJWscGjJLcrzPcvjeoqq36YjZbREHwNaT1ODW9Le/wDJV21n qGDdLW+nrdbqXrfRzdUxJ4IBGc/RTDvSLiNrqttujmfVem3LYgS7Hnt9FUTaasrafX9uFIZPVmlE bw0EnpJ5XS9Yb+3Hx3fku/heHUDKy2adhNsEYfTBrnNJAHQ3uM/ZVB+IzXdBrK4UIomEPpWlj3e5 Vj9+TcW7ZzC3MmfP0t6xECXdODnsqGVby6UkkkreP/H45Z8sY2+Ty5b+HxaMuCth8IukrbNQ1N+q YWy1rJDHE54z0AeQqoMx1DKub8I9ZTN0dLTmVonfM49GefC4PSkiy3K/VOrKttbTRstBmdBC8OGT 0/T6qItyNA0tbvlZWW63x+nM0VFUAMNdhx5KlqwnUL9bVlJcKSKK1U5M0MrSCX9ROMn3+n1Uea91 AZd9LNS2eb1XCJsNR6fJb8xJC6zKS1xmO9WpU1hXVlitdJU0ULXU9MQagZA6YwOSqa/Ebqy26v1h T1lpbiOKmETzj8zsk5Vjfieq62l0AwUZkHXIGydP+XBzlUcqHl8hLu6uUk8cvyz4srfJlPiMGDqc ArgfCdo62U2npNSSQiW5SOLGPdz6bR/l9lT+MgPGeyvH8Ls8Mm2kNO2Rpm63Etzz3XKe3bLfG6dl pC8Xq6XCobeaFkNFO54p3dQIe1px28Lw6O0Bp2w6rvN4t1CxlX1AAnkMyMnpHjK+2iZr/NqCppbv b201Fb2lsUoOfULuf6LfWSppqutvP4WeOUukAw055DcH+a65a3Z8OM7kvzpptG3u7Xuqqor3bWwU c/Wackgh7AcdlTff+w0Fg3Dr6a1QiGnOH9APAJ5OFcTQ9Veqq8VMN1two6a3M9GJ3/yQnz+yqV8S VXBV7j17qaRsjQA3qacjI7rpjMbjnWN2Z4RE8bep49ldD4YtFWq1aKbqZ1OJbpO1xEj+eho8N9lT GH/eDKvxsBJHNtFQQQODpRE8dIPOTnC8r1txpC71mp462i1HaxHBNH6sYkALZIncDC1u3232ndIz Xq622kBqGyyNa55z0NaM4b7LY7e1d0rqyrkulvNDFRxilZ1H8xafm/05W5tL2VVovLKV7Jnvmm6Q 05zkYCRmbabSdyn1dRV9BqW0+nDLH6jWTAEPjdkAhUf3csFLpvXt5tlvDm0lPOWxhxyQ3g4z+qvD tzX3C6T19Vcrc6gjpmNo2B5/MWfmP2VMd/p46jdG/SQPa+N0+Q5pyDwEn9XaN1u9K6euOpLvBbrT TOqKqU/K0dgPc+wWlVi/hR1VZbHc6mkr4o46yrcAyocBkD/KCipR0noLSu02jJKzUMNNW3WZmZXT sD8nw1oPYLcbe2Gx6X0vcNX2+3MFZXB9VhrR8rSeGMHgfZcl8Suk7zWxM1Ba5pay2sj/AL6BpyYv +Me4+ikLTQkqdmKJtDH+InbRNIiaeXEYOPurvWeM+GLbcMqcbINx9JV9t1PapIHtx1Mlbhzc8tc3 /qoQ+HfRUH/aZcJZ6P8AEUluL2RySNy1rskA+2VPuibrUXynul1qqF9Ax5bExknBwzIJP6lRn8P1 6qP7aX+0gg0z5pJ8+c5IXa478eVnvbjMrPLJ8aSLqfUtJSXKvs+pqdrbXPD/AHUkrf7uT5cub9So U2JOiKu43i0XW20M89RUOdDLPGHEM7BrSe36LXfFXqSvk1LHZ3P6aSnaHsAHckcqI9vLVeL3qmjp bAyR1Y54Ic0cMHlx9gE8s4yT7Xw/teW3ab9bP1OiKuS6WkOn0/M7LXAZNOT/AIXfT2KhQ5BwV+hm srrbdJbeupdVTRXB7qf0nxyAESuxg8Hxlfn5cTGayX0QBH1EtHsM8Lg9DCii9aoazyTgK923WlbZ ttt5Fcbbb5q251EDZZXsZ1yvc4Z6Rgdh7KjVkbm4Qf8Azwf1V/NW6in0ptlRXKlDTJHFC35hkYIA WsMeV0znlxm1ZN+LzqPVc9JVXqy1dDTUuWMfJAWg5PkrXaS2H1bqeyR3OkhpqaCU/I2qkLHuHvjH Yq1Firma82vqay800Upe2UhjmggFo4IWxvt6t2m9EW6pusRkpuiKMNacclvCut+vaXLjN1T3W+x2 rNJ2Y3Kshp6iBpw8UrzI5g9yMdlFLmkFXovO4trr9E3Ntstde+kfDJH6jWFzAennn6Kj1aAKl+O2 SrcZx38mOVtfFg6nYAP6KWdL7Da01BZYLlTUcEMEwyxtRL0PI9+nHC4LRcIk1JbQ4Ag1DBj3+YK7 O+t9rdN6FoKi2yOilMrY8t9ulcOX7cXWzWPJV3Um0eo9EMo7jqWgjNsM7WyOgl9QAZGerA4BCsPS 7q2C3Wq2WrRFD6sriI20zG9vouAm3L1NqHQU1nmslRUU9aPw344xO9IkkD85GM5Uj7b6EtO1ljff tQyxvur2dyciPj8rPutbZ+NvfvfaKO87SVU+oqWnhukUJlhweWS/Q+eFRGob0y4CnXevXl71YJZo KWsZZIjhsgid6XfHLuygmRxMh6u5VSXbb6Psz77qGgtrJPTNVOyLrxnpBIBKvFFBp7aPTVFbqOl6 5ZCC53RkyEEdTz7HCp9suOrcOxg9vxbD/NXU3CvNHYrxQ1NyjkMMlPNC1zWdQ63YwP1W/HJldVjy WyTSLPiL2+tF004NbWdrYKpzWPla1vE7XEAE+xAPdbX4YdJW6i0VNe5qIOuEzngvlGQWDsADxhb7 c8GHYljXNLXCCAdJGCOQt/s3ff4ptrSVPotj/DMdD0tGAegJnjJjLHTDuVF2/cOndXbbfx6OOKK8 URbGA3DXDn5mkeRyqkOH94QpC3U1NJdtT3OWHMNPPKXOiacNz27foo7Lj1Z+qzUjqttdKyax1ZQ2 Zk4pvxDiDIW56QBk4Huri3Wp0xs/pSltsNHFIAOsiZvUZCeCSfc4VbvhlAdulaj5HWf/AHJVpdyN d02lr7QUNTRRVAqYw4Oe0HGX9OFzxtuVnxHTKamOvlVWzT6bve634y9QinsdRUumdFGelrcjLR9s qy0etNOS3iks+mbNS3F8jBj04m5A85P2Wj3425p9RU9or9P2+KO8zSCIiPDGvZ0k8jtx7rc6VsFk 2d0q+sr5WT3eVmZZT3Jx+Vo8Bb3ubjHbgfiv0bZqS0UN9t9JFSXBzxFMyIBoe3BIJA8g+VVVzuSF KO7+v63WN0kdLJimYcMjHYBRa4juVdD7UlPJVzRQwMc+WRwYxjRkucTgALvP+yDXLQB/Zq5/+EY/ qus+FK20tZuSx9TCyUQ08jmh7cgOxwVMO5+61y0nrWSgj6fwcYY4txyQQCUnct+mblrKY/aANvdr bpqDXH8BucclvfB/eVLZRhwaMZA+pBVpv4Pt7Z6+i0xNabbJMY/SDpYGueDjjJIzk+68m32tbRrb WrKu3UjIamOmeJH4+ZwJGMrPUE9mdqWtpqlsH8YFypnwFzB19OWdj3x3Uxm7XXU3Irfvztp/YK+B 1DJ6lqq8vgB/NHzy0++PCicfUq2HxfMDqW0E+Ov/AEVTZDl+VvyYya04+LK5b39vXbqSor6yKlo4 XzVErulkbBkuP0CuHsxsna7VY/xWrqGCvuVSA4wzNDmxN7gAHsfdRP8ACzW2G36nr5746COZsLTT ySj8pzzj69laiw11vut6qKuhu34xzY+n0mgBrGk5XN0y61pCWi9rtP3PdnUsdZTB1BbpeqKkAHpn q4wR7LrqS27aXDVT9Mt0tQCrY98fUIQBloyeRz2Wh1Pq2j273Wqa6nm/F0dyZ/tsWPmieCe38l1m jNZ6N1LquI2q2Qsuspc8VHQA/ODnnGey3ZJ7Zl33Fb/iA2+pdDaqbFa5HOoKuP1443DmLLiC3Pkc KJ+w5PlWY+MAZvtq9/w3/wCM5Vl7jH1RZU9/DNt1adVVtdc77E2qpqP5G0zxlj+pp5P2UrWTTG1V 7vstno9OQtrB1g/mx8vfBz4XPfB/HILVepOsCIPYHMx3OCpF0lXaPqNZyx2i3CC8D1S6QE/Xq845 XPxXljbfs8365yT6cNpDYiw02rrobm819BTEelTSN46XNJGT3yFtbNovazUNyntlDY42VbGuzhzu McE916rjuHHpLcS40V7LXUczWf3jG4I+XI/rhbjb+4aJueo5p9NUbYrkWOc+RpPIPJyM4WvNLhU8 ecznJUXdTR/9jdV11qbMZoI3dUTyOekjIz9VxQ7AKbfidAOv6s+ehv8A5QoSiGSMfT+q6eTGY3UY 8Odzx3Vh/h42rs2pbDWX7UbfxVP1OhZTglvR04JdkHupCtG3G12pzWUNnontqWMILxI7LD2z3S+F ZsrNtat9Q9hpPxMuGhuHDAGeV2G3bdI/xWuOlonR1pZ/el5J4z9/dc53jt2zx1nYj3RGzujobZdK fUw/E11HWSRmT1iwlgALeM+xW0sO1e12oHzw2qmqHvhGX4qHHH7lRnuS+9126NfarYSaypqC1rI3 dAcen6/QKZNF2C2bU6ZlrrtWOmulTH1TOdxnyGhuewPlaykmXCe3LlePK+lUNz9Pwac1hdLbRdf4 WCYiMOOT0+2Vx+cDIC7fdC+xai1RcLjG3obNITjK4hnJ6QmepldNYdybfVkZcPOVkxnzd+fqVbjY vS9jsm1v9opbfFU100TpZTMA/IaTgDPbheiLVWgdW0Nwtd5t1FQ9bMB7Ymh+fdrsZBBXPx5c8eU9 NZfrlw+UTbK7Py6rkFz1AyansQaS0h3Q6bIIBafYFdRuNsRRQaeN00PUVNYYeozU8rw9zgO/TgDk eylmywRUWzwgo5XGnZGWRyZwej1MZ/Ze7QFojsdffqKmqZJ6Tqjlj9R3UR1NJIypLbJW8sdW/wAU JqoXwSua8EEEggjBC+beTgZXX7mQsi1Vcg0AAzuIAH1XJ0/S6QjPhdMseN1XPHLlNxNezeys2rKY 3S/OnorS5uYuh3S9/GQ7kHLVtdztjmWazRXjSFRU3Gia3M7JCHPA/wAzcDt7hTNRsJ2UsjBK6EOp KZhew4IBc0HB+xWx29oTb7Te7cZpZ6aGdzYvWOXBhYDj+a3wvDkxMt5XH6V42k2Vm1XST3C/S1du t3T/AHDowA9579WHA5anursrLpq1RXfTlVPdLX0ZmLwOtn/EOkchWCuTXP24tkTJn04l9GMvjOCA XYOP0RoeilotMX+11M8lTFS1EsMbpQMlnQCAf3ThuSs/k7sUOkzG/px+qWCTjK3Oq6dsV0qGswMS OOP1Wst+XVTAQPzN/qufl/49/wAd/FPyan2mLabZer1dbJ7leaia2UAH9y7oHU8+SQewwvPuztBW aHihrqSpdcrPKAHVHR0mJx8OAyMHwVZe4QSVGjrHRwVL6QVTY43yR4BwY+f6L5WCknZt/dbddJhW mldPB1vb+Zre3CeO3PGZfZlNWxXXbHZev1hbprjX1brXQAYheYw5zyDzkHsFrd1tpbnoVkVSKg3C 2yjH4lkfT0O/yuGT+6tLqaGoq7BZqGkqTRurXNjdIwZx/dk9vPZa+CmnqNp7jRXp4q5Yo54XPeM9 Qa4gHn6BamNuv6xleMuX0onIC1/Y8FYAF0mB2WzvULYqt7WjADijTzGvvdE1wBaZ4wf/ABhMpwtn 0YfvZr5Shtxsdd9W2p1xrK1lopnAOhdNAZPUHbP5h0/qtDuVtfd9DV7Yq7pqKOT/AHVVE0hj/oR4 P0VuNb0VZV2u1Wq1VYoPxLiHSBnUMBpOMceQF4qqB142nc2+sZU1MbMOc4Z+Zr8ZCT4XXv8AiuOg djb3qu0i4yVENspn4MRqIy4yNPkYI8rldydubtoW5/hrk0Swv5hqYwQyUf6H6K4mtqW4VdHb7TZK qOgbNG5ziWZGGtBAAHblaTWNN/HdlJZLzHHPVsp+oyEch7TjqB8LUwtsn2zctY3L4ijr29JwVh08 LYXOERVDm48rOxW193vFHQQua2SplbE1zuwLjjJWcpxtjUu5t6tJaXuOqLrHQ2uF8kriOogEhgJx k48Lo9wtr71oY0wuz6aVlQMtdA4kD6HICtXoTR1u2y0/Tx0tHJU3OfpE8zWlxJOA49XgY8Llfico 5JrTQT+m4wtcQ54GQCey6eDCZ5arh5/LfHJqK87fbZXvXL6gWgRRxwjmWclrC7j5QQDzytFrDS9w 0teai23NjW1EDul3QctP1B9lb3YXWNpuVqprFQUDaSqpacGboAAkI46uPJUJfEhEDrqveBzkf0U8 WMz5fxvy53DLGa9oQxhZMGXLJ7eSux2it1NcNf2OmroWT08tQGvjeMhwwe65Z5TGbrv48L5MuMbf SmzerdS2htxoKFjadxw315PTceM5AI7LkdRaauOn7pNQXWnfBVRHDmkcH6g+Qrsa7rbzahTUumKe Ix0cAqHsLsHpacYHvwuY3+s1JedD0N4mp2C4gMxIODhw5BPsumGFysn245eSY43K+pdKyaL281Br Ez/wOhMzYW5c57gxp5xgE9yvPrPQl90hURw3yidA6RvU0g9TT+o4yrh7Qadr9PbafgqiNkda/wBS WMscDw7lvIUY7o60p71ouez36n9G+0c3Ty38wHkexU8OF8nZ5fJMLpV9zMHB7rZ6bsNfqO8U9stM BnrJyQyMOAzgZPJ+i8lTj1Tn3XRbd6kk0nqu33mCNsjqZxPQfIIwVL03HRs2Q1y4c2Koafq9v/Va HUu3epdNQNmvNqqaSFzulr3gFpP3BKno7tXzV16t9JpiF8NRIQ0xA8OxyST44XafEAPxGhKaGbpN UXsJZkZzj/qteLGZ5cWPLbhjyVJ0zoe+6mM38Et8tYYcep6ZHGe3deLUWmbpp+tdSXiimpKgDPRI PHuPdXV21s9wsG10ULqURXVkTy0ADqPOQMjuov3j1NaNXaLidUQtgvlK8tkY5uHtIGDz7FY8G/Jj ys015LMMriq85uDgrAhemqx6rhjjK86Kx8pnGEvKECTTSQLPKfdBSHCDIpFCPK0BBQgoAJpeEDhA 0soQgEJpIAoR5TKBICChRARyhHhCA8oQjCAQhA7IBCMo78IBBQUKqEIQEBhCaECKaEkAUIRjCAKE IQCEJIDCMDv3TRhAijwmkEAhGEID7J5QhEJCfhCgXlPCRHCMIPf145CyheXStC8Zd2X0pyTIOnhe eR9TLybj41/zVsx57j+i+M/MYX2qf/WpD9l8Zz8h+y28GTxoSTPhbcyQhCAQhCAWTDh2VimBkoNv arpU0MzZqWR0crezmlbp2sbu+ZkstXK97exJ4H6LbbXbbV+ta1oAfBQA/NKByfspU1Ps/o23yUts pKys/iriC8+sHADySMcKxLUKV+qblXysfVVUkjmflyeAtjHuDfWRtY2tf0t4AwMKX9a7F2qi03DU adbXz1rnMDi6TrAae5wAtjbtgtOR6cbVXSruDKst6i71WtGfAAwm00h1m6Go2sH+2OwPoFjJufqJ /P4wkhTtBsBo19sZVuq7uxnR1OPrDH1/wr5zfD9o+pt7qi33C6dsh3qtcP6IK8XHWt3uE8ctXVSP dGflyeB+izuevL9cqEUlTVuNP26QMZH1U16t+HalpbTDLp2uq5KrLTI2pIILT3xgZyvHfdiLTbdC 1F2fca/8dFEXlp6ejI8YxlXGXKyT2ZZTHG2+kQ0uv77SUJo6WrMUGOk9PH81ytZUS1MzpJXlz3HJ cTklTxttspZtR2cVFyvFYyqe3LWU4aGg/XKjDczQty0RfZaOsieaYnMFRj5ZG5457Z9wl6WWONPd LwsjyF2u12hJNa3n8M+p/DUrCPUeAC7nwFFcW37L1W+qkpJmvjcQ5pyCD2Km7cXYpmn5LQyx11ZW GslMcvqxDEfAwctWeudi6LTGhKi+G8VL6yFjXGB0bQ0knkZ7olyk9uQo93tRUdKKeGpHSBjPlctW 6puFZcDXVFRJJUl2esuzhc8+M9RJCPTcrDpJ1LvHqSloxBDMAAMZycrg9QXysvda+qr5nzTPPLnH K1YY7KRaR7KVdMD34Xutlwmoahk0LyyRhyHDggrw+CnjKglym3r1HS0DaeKZowMBwzlcVV6uulTd jcZqmR9SXdRcTyubEbsZWcTHOIABJV2iWabe/UlNQCnie1oAwHZOVGmor3W3uvlrK6Z0s8hyXOOV JOm9lLtdNIVd/uFULdTxxOliYYut0mBnnkYyokljcDzwfKurrfwks3x+WA/qtlZbtUWiuiqaWQsk YcggrXtaR3QWEqNJoZvzqOKgFPE5jQBgOBOQuCOsbq68/wATdUyOqy/rLicrlOn3C73a/bet13Wu ihq4aKnZwZpWl/PsACE2mo69u/mo47d+Gi6WENx1gnP7KIr9eKu8V8tXXTPlmkOS5xypI3b2eqtv LZR1ct1gr2VEhj6WQlhbgZz3OVEjhjvwFbLJupjZfRHlbjTd9q7HcIquimMcrDng8H6FacrOFhe4 DBJz2A7qRU6//BCagFvFNFGxh6cdYcVHVJrq601//in4l7qlzup2T3+i3Ttor/DoGr1VW+lTU0LQ 9sDwet7T5+ijUt+bByVdmonqX4iL862mmhibE/pwHh2VCd8utTda+WqrJHSzSHqc5xzleAt54Bwg gfqoafNdXtxqyXR+oGXOCBk0jW9IDuMfULlsYHn9kgAT5/RRVhr38R96rLZPTU8DIXSMLOsnPcYK i3brWbtJakN2bA2eXBAz4yc8LjAB7JHAPlE0sRqP4jLtcLTUUtPTMidMwsJODgEYKrvM/rlc49yc lDuR5WB7oaAODldht/rSv0jdGVNHI7oyOuPPDlxy+sEbpZAxjS5xOAAMkn2RVj7z8SFzqrRJT0lO IJnt6evOcKPNutyZdL6onvNRCKuplaR1OPIyeVt9PfD9rO8WaGvbFRUzJW9TYqmUtfj3wGlRjqnT 1x0zeKi3XWndBVQnBBBwR7j3B90RN+vfiBqtQ6bqrbDSMiFQwxvLgDwfZV4JyUeEld/BMZOx2KkH a7cWv0VcmyQPc+mJ+eLPCj7CAoqzOqfiPqq+yy01up/w80jekyDuFHm3+7F001ezVvkfNDI7MjCe 6isHA8rH+SJxWa1j8RtRcLJNS2yA000rekyeQPoq4XKtlr6l887i57zkknJXkJJQrskNpwcqVdoN 1a7RFW2N7ny0B7x57fZRThAUVaLW3xFyXCyyUlngNPLKOl0mcEDzhcVthvJW6Wub3VjnzUshJczO eVCof7k/ujqABxlBZ3XvxEOuVhmo7HC6mlmBDn9iAe6rTcaqSrqHyzPL5HHJJOSSvOXk9yf3WJQJ euhq5aWoZLE8se05BB5C8q9NBRT11VFT0sT5ZpXBjGMGS4nsAEFlNut/o6HTrqDUMJqXMb0jIyHD 6rxbeb4ixXatZVRYtk0jnxxNHEeTwAPZRrdtpNa2e0y3GssU7KSJvW9zXBxaPfAOVxdBR1NZVxU9 LE+aeZwZGxgy5zj2AVTU2sjuTv3Dc7F/DtOxGmEmQ8t449gtRsjupZNH0FYLjSddfPJ1Onx8xb7Z UZ3za7Wdltc1wuVhqoaSIZfJweke/BXH0FFU11bDS0kb56iZwZHGwZLiewCHSZd/txLNrhtv/htE yKeF7nST9OHOBGACfIWx2L3O09obTlYypoQbrI4kzhvLm44GfZRnqDbbV9it0tdd7FW0tJFjrlc0 Foz9iuWoKGpr6yGlooXz1EzgyONgyXE+Altvskk9Ow3M19cNY3aWoqpXelk9DM8ALgXHJyV2Oodu tV6foDW3qx1tJSggGV7PlBPbJB4XxsG3uqNQUP42y2OsraTqLPViZkEjuormqGYwTteO4OQrZaQ3 x09W6Sp7fqmjjqHxtDHRSMDmuAHHB4VdNQbe6o07Qfjb1Y62jpchplkZ8oJ7Z9lnYdC6nv1v/G2a y11ZSdRYJYY8gkd0lSzayGpd79O0WmJaDS9LHTF4LeiNoa1oI5wBwsrLvRpa66XpqLVNHHUujwDH I0Ob8vY4VatRaL1Jp+kZU3uzVtFA93S180ZaM+y09ot1ddK+KittNNU1UuQyKJpLnfYK7TjL7Wh1 zvVp6m0dPa9K0kcHqsdH6bGgNAcMHAwqnTuDpCR2XRah0lqCwU8U16tFbQwynpY+eItBPtkrxWLT N4vzpm2e3VNaYQDIIIy/pz2zhNrJp5bJXOt1xp6qP88MgeP0OVbqg3i0bqbTFLTaspI6l7QC6KQZ AIGMqo93slxstYaW60dRR1IaHenPGWO6T2OD4Xnpmyve1rAS5xAAA5JPhRVu9U7xaXpdPU1p07Ax lKHtDo2jhjAQeFv7ruzoC/0UUN3jZUxt+YMkPAOFTu62G82iOKS6W2so45SRG+eFzGvI9iRg/oi0 2W8XZkptVvrawRY9Q08Lnhn3wOEFodyNy9G1m2NzsFnDWNkp/Shib+VvIIwqfzH+9OFsK+Cro530 9XFLDMzh0cjS1zfuCvHDBLNM1kTHOkecNa0ZLifACD2WC5T2q4wVdM4smheHsI8EK32jd6NOag03 T0+rQ0VULmu5HdzeQ775VP7jaa+2ytbcKSopZDyGzRlhP7r1WyzXa4RF9Bb6yqjBwTBA+QZ9uAno 9p73v3dj1C42q1PxbwfmIP51Ju3+5ehrNoqgt8c4gaIR6rMgkvI+YnnyVSqsjqKaofDURviljJa9 kjS1zT7EHkL0W+nrawmKjgmnkAyWxMLyP0AV2Rvtz5bbLq+6SWEk258pdDnuAR2/fK48DK99yoay il9Ktp5qeXHV0TMLHYPnBC+FLSVNSHGGKR4bjq6GF2M9s4UHW7U6nGkdX0F1c3rbC4hw+hGCrW3n VO2urJqK5XqQS1UUbejLyOjnOMZ91SmaknppOiaJ8TyAel7S0498Fe5lHcGQ9bqepEf+YxOx/RTW l3ev4uZdN3NNt1PZYYahpoYOpzpc9iWloH816NSX/bjUtZDV3ar9aWINDcSEN4ORxnCpJIZm8OLm 45wRhfeP8YWFzWylre56HED+SekWJ+Ja/aWvmmLeLK6B9ZDPkuYwB3T04wSqvvOCvZUSyOB6nZI/ kvFnnnKolDYXWVPo3WcNZWNzBI0xPP8AlDvKsjf2bYamv0V4ulV69SwtcB6pDDjtlvlUgY/pOQcL 1NuEwADZHAfdEsm9rV663Qsli1jQVenKemaYMsmkhZ0+rGcfKcKQqXV+hLpU0uo5ZqYV4hx8wGR9 /qPdUOkq5H8ucSfqV9G10jW9LXkfqipf353GGsLj6FPj8LA4iMqGHHyThOWYv75K+Wcoensoqh8M rXMe5pHkHBVs/hqu9gtumJK6vunRcqh7mSRyP4DQflwqgZwvbTV0tOMRyOaPoUFj9xLRpe6bvUDK m8yfwi4sdJPJE4AxyYOAD7ZwpH0TZtBbftqrhb7mK2oDPlfO4Oe3HsR7qlzrjM9wc6Qkjtyvo+71 TmdHrv6e2OorWWVyu6kknUSNvjrv+2F+9VgHpQAxx49skqLA7GPusZJS9xysQVNqsv8ACtrG2WkX G0XGZsL6pwkje44HAPClXTemtMWDV8+oKXURlkkEmYJHN6W9XfBABVG6apkgeHROLXDkEHkLZNv9 fj/1mX/xlTH9ZZEynK7vtYLU9PYdxN1paaourrfSmI/3wAOXNA45+ykrR9j0jtpba2uguQrqkAkz SOHX04x0gDjCpW25Tep6nqHrznOeV6HX6tliMclRIWngguJV8lnku8oz48JhjxjsN3dVs1TqWetD QGn5cjzhR6zAcCPdKWYyPySvn1JllbWsMZjNRbj4XdT2t2jayw1NQ2CrEr5PnIAc1wAyF2+g9KWz RV1uNyOoIats8fSIyxrOgAk+5z3VHqC4T0Ugkp5HRv8Adpwtt/ay59JaauY54/OVJ1NN3LvfzU3x Xq31/wAQlLXwzsFK6qJD3HAB6CMfut18VNzaH21tLUNcHQkO6HZ8lVjNwmEwka8h4PUHA8gr63K8 1lwY0VU75S0YBc7OE3+/JLq4zG/DxzTOeXZJIKxidh4XyJymCpZsl0uhsfdbdqHaM2KGrihrIonw yCQ46ck4P2WvsmzFooKe4VerLoyqaPmiNJKWCIfX3OVVWz3yttTi+infE4jB6XYyFuJNb3eaJ0cl bKWOGCC48qePH8ePGejPWWXP5Wq2w1FZLvYqrRdRVDMDXQRSF3SZWZOHfQhb+kbbdt9M1M9XXuqq iUDqe+Tq6yOBj248KkVHeqmkqxUU0z45WnIc04K2F01jc7nTiGsq5JWDkBziVqyU3fl9NeXCO5X6 sqosdMshcB7LmoHgSfyWMsxkJyV8eytu/aTUnS6m19/tW4G2cWnPXNLXU9M2Ajqwctx0uH6gLpKV 9Ht5pB4ulbJUVkreqV0knUXPxjg+ypBYb9W2WpbUUM74pQMdTTjhbi8a2ut6iayuq5JWt7BxWpld cfhnjN7ntbPTNytm4ehH2anqnU9dTtAADhkOactd9lsPVp9AaLqG3irfPWVAMkpe4El5GDg+RwqY WTU1fZ6z8RQ1L4pO2WnGR7L3ag1xdb3C2Kuq3yMb2yVZnfXwz+Ob21+qallTc6iWE5a55IK1NHII 6hrj2BB/Yr5TS+oe54Xy6jlc8/33v5dcLw1r4XlsVwptxdt6eOw1n4e5UrGYGcOY9oA/Y+62NfNT 6J0bUU11rnVNTUB73OeR1dTxz98FUv0lq+56bqXS2yrfAXjpcGuwCPqtpqXX111DGwXCqMnSOkZP hXD9cZjPUS93a2pqG670LTu0zWiK5UnS5ozgte0YwfbI8rK+1EGkNv56K7Vvr1UzHkuIALnP5PH3 VQdK66u2nKh77bVviLxhwDsBwXp1ZuBddRtb/Eagv6W4HPcLUurtMpyln25y+PbJWSFpyOo8r42a dtNdKaZ3LY5WPd9g4H/ReGaQvcTnOeVgx/S7qH/21nK8t2rjOGtfC+d5mm1no233TRtawVkBbJH5 PIw4H2OCUaing0toF1uuVW2Wpc38wGC4l2SceFUXQu4l40m2Rttqnshk/MzPH3Xo1buJctRva+sm cXAY7q43Xsu/hbHVX47UunrXedGVkZqIDnHclrh0uBH09l5tczwaf2ymtNwqo31b4CzI46jnOceF VzRW6N50tHLFQVLhDIclhPGfdfDWm4Nx1NJ6lbKScY7reGerLfhjLDc4z5cneXNfVPI/zEL4Wmtk ttxp6und0zQvbIx3sQcheWeTrdnK+RKxleVtrcmppaXbndvVOqb1TUMUBma0tdOY2g4Z1AFx+nK7 X4h7jW0mmmwxxddDUEsld05DT3HPhVS2+1rcdGXgV9rl6ZHN9N7T2c32KkTU29Fx1BY6i31wjfDO 3Dh0j+q34Lwz5Vx8/j/JjqO0+G2wXWi1bU19ZQVEFFLRgRSyMIa/JyMHzwub+I+01zdT1ldJSTij e4NbMWHoJx2yvHprfW9Wm1U1vJikjp2CNjyOekdgVjrHeet1Jp2qtdbDC+KZuAccg+6njv47l/Xb z68txvrihGUdLiHd12W0NdTUGvrHUVcgigiqAXuPjjC4ydwfISiCV0EoeDwueePPHi34s748uS+O vf40Ljb6zT8cNRT1kJpZHOPyhrjnJPgfVaret7KfbuGjmkY2qa1hLM88DlQjoDe+66cszbdMW1ML PyF/JaPb7LRa53Hq9SV5nc4sbnPTngLt4s+GUt+Hn8nj5YXCfN2sltNVV021JfVGYVEYlEfWD1Bo /LjP0VUNf19RV3Womne50pceo+Sc+VLNk+IOugtcFPVUtO6SNgYX/wCbAxkqHdf3yG93uqr6eJkX ruLyxv5QSniz4eLLD7Z8ni5eeeT405IkkknJKyidiQAHusHHKxZw8Fca9E9rk7CWuhs2138fp6cG vkje6R7iT1dJ448KHtw9c1V7usj5pCGtOGtz+Vezb/eBtk0M/TtVSh0Ya5rJAecFRZW3Pruv4hvY SB4B+hyun+Lfx/49l/2rl/kYc/8AKmU/1i5egb1cKzaBlxq5HurI6d+Hu/Nx2VTNc3WWtudRPIfm kcS4jjJU42jf+hdbY4Km2Mb8nQ9oPB4weOyr/ry5UdfeauooIxFTyuLmsHjKf4//AB+C4Ze2fNjc /wDI/JPTlpXdbsr5lZO+ixKzXYu6R4TQVAsoR5QUAUkI8qwCYOUihA0ICEB5QgoVAhCZCBIQeyAE AhHKagX1R4QhAIQhECEJhAJZQnlADshAKSAR3T88pYwgEIKFQIQhAJowl3UAnhLlCA8oQjsgPKEI QCXdPCSBoQhUIp+Uk0CHZAQmoEEeU8+EkAn+iSf6oHjK9FICZmhfFjSSvbRsAmaT7rht9Di8NUc1 Uo9nYXxqv92F9arirqP+dfKr/wB20rbyZPEmUkytOZIQhAIQhAL7U7S6QDwV8V6KU4lBQXV2Egjg 0rSdLQCYgTj9FC2urxNSbw3WZr3kR1XSBnPy+ykTZHWdE21Q0fU0PY0NcCVnq/QNmq9axXyluMXT USepPAZcuLvcfRWdOeWO7KljQ1VJcbFE+amc1hbkZb3yuO3ku9fBW2a3U9K9tDLM0vnDeAf8v/0+ y6K86koNOWejp6OpgdJIRGGiTJHHdfTUFPSai0/TuqamFtRE/wBVg6wA5w7ZWW25o44JNI+nVOc2 B0butw7gLjaq7RQa0is9rkYaF1KwvbG7Izz3+uF1dXSGo0jJbYq2mjqJYS1r/UHykhajTWkrTpq1 vc2WnmuMgHXMXgkn6LTPy7C418NI6iZNw2X5TnxwFyu8AbFttefSx0eiSMduStVupdImP09DDVRi R1Q4kNcCcdIWe6NTD/2S3Bjpo/VdD0gdQySSt+Lry4ufmm/FlEQ/Dpcaie5SU75HGMBrgM8ck/8A RdB8XwH9nLK3z+IeR/4V9Ph50e61Ucl3uVRFEHgODOoZAHbK4b4mdfUWo66ntNs/vYqJ7i6bPBcR ggKY3WdtM8bZjpBGMkqQNpL8bPf4SxxDHuAcB5UfA8qWdgdNR3nU0c8zmthgcCc9yVizp3XH09NH dLTFNLEQ1vSQXjv9VF+5FDNrrV9Pp6YTU1tgfmZ3I9X2AXfXzU1NYqi322FzXPl7YcOAML6XOlgf cqK8yTtY5hDfTbjkE9yc+FrC624eTHlY5Z2z+jaRkcLNLUdSQMOkfIWk/wA1qNR7PaLppqSuNpig Y14D6aNx6X5PnldFuJa9UXi4UcmmaumipefVdJIAQPcDytDdtOG0XC3SVuo6msrnkf7K5jej/iII 9lM5xnTWGVyvrT73Xarb+g9CuqLBT+lJhgiBcASe3lRp8Qe1lgsemGXuxUzLeWdIMMYJa8O98lTp rpnq2m1Ma4ECaInB9s5/0XE/E2R/2YNw5pwYxjK7eHGXW/pw8vkym9falhHPZSNs9oSHWV6Da+oE NDER14/M76KPHHLnfdS5sHZK26Xz1Ke4NoIWEB7unqLvsMhcHsT9ctptv7TDT/iNPetE5oHr+q8A n64K5277ebd2u/UFdCWRxZA/BNkOHO9ySpfo4LzRyRU2BXUQAPqkNbn7gkqFd9tNW23ajtl0p64x VcsrQ6jzkHnJdnP+ism2bdJuq2Wn+xkzZoSy1iMh7A7/AA+eVUy7WDSGoNw6ak0/ST01sDcTNa8u L3Dvj2Vo3Uhvu381uoZGmaaIszntnyuO2z20t2grux1VcY62vlGXdUXSWj2HJWpqeOfe3Hv8tuuj otk9EVFPGx2m52ZaMyOqHc/XuoyGwkEu5c1rjqnNs7WifAB6gCT8mf07qyDY7g3Vr53tcbZ6LQ1w PAdznj9l5I6V9LruWumb0UtRAxkbyRguAOR/NSzUbmVtRtUbVbX0NxFsnoZDVhoc7NS4H790W3Rd o0hri3P05WsFFVNLXUfWXOYRj5snwcrw7qbf6s1HuKKuyMMFC6JjDUl+A0jOeO5Xr0lt5cNN6yon 1N6/i9QWO9RvplhiHHPJOcrXkxk9OXjyyym8ncbraFbrptqoahxio4ZXSTPHfGBwPuqwb/ac0Tpl 1JQaVZKLixxNQ8zF7S3HHfscq5d5ucdHWUdLIDiq6xx34x/1VQviX0BFpi6w3Okme6Cue4em8kkO HJOf1Vn7Y93uLy4ZST1UFDv9FMvw/wCmdOXW5ir1HUEvjePRp2uxyOxPuoaxjK7La2Ut1ja29fQD M3PPhcnpXr1lR2SfQ89LeHvZaHRgPIODjxyq66J2y0LqbWNfHBPVyWtuGQwiTDurySfZTzr+x1Gq 9vnWq2SNbNUBjQ/uGc8kqO9rdtK3RGvQ2a4QXD1Isv8ARYWiPB8gldOpj/XHHlcr9PW34d9E0s72 1b6x/quxCwVBBA/1Ud3zYy3WvcWmoZqyYWWo+dkbSTKQDjpypQ37vd50xX2+82yndJSwNLZXkHpY SeMr07KXn+2LnX26lklWMxxB3PQM+Fu4zHVvzGMPJlnbrrVad3w9aLq4JWUkN2im6D0PlkIaHY4K inQew9VdtZV1BdqgC3UEvRLJEcOl+g9la6wT3N93ubbiyVlMJCIC4Ya5vjC12i6SWhvt9NUwxGeq dJH1cdbTjBC5a6rru7n0i9uxW277jJRR1VxNRGel7DUZwf2XJ0nw4Mn1zPTuuIdYGASN9N2ZcE/l J7ce62GrNGa6uO6l0msUU9JSTy9TKt/EQCmTa6zV+n6SejvVdDWV35nSRuJznxymiWo8b8O2h3VJ hjfe+sHGS75f3wq4bz6Bk2/1W63+qJaWZvrU7s/MGZxh31Vsai/6/qtWVdBa7O6OibI4R1VSCyPA 7c4Krf8AEq29t1hTt1HU0c9X6A6RTPLgxuexyByrZoxy2h1Sh8PenZL9uFQlsbHw0pEsnX2HsowK lz4cJqtmv6SGjDy2YYlDRnge6w6Lh69uVTYbbTXCAximpD1VAc7HyY8e6ieo0dp7e+7yXuprqimc yEQxMp3NycEnLsgrc/FQK7+wtOaNkro2yZnLASGtx3P0XG/B/HO+pu8xa8wANaHY4B88rplqYT7e fDlc7v02VL8MVg9ER114uP4p3UWiMsA47eCuO0t8NtbVanrqa+1bqe1Ux+WaAjrkB/L3BA+q7zdL Xl10LuDPVGmkko5omshe8EMyB82D2ypI2xvsmpdIuusxDpqnLiB4HYBXLDjZNrM7ljcvpElP8N2k K10sdDqS5zStB+Uenwfr8q1GkPhmhrBWfx+7TwvhlLGNpmt5b4JJB5Xc/D/Q3am1BqKS60lXBG6X ETpo3NaRz2JUrW4novb2Hj1D0ke4YFMsJjbJ8GGdyktQEz4W7e59WZb3WCIZ9ABrMu4/xce6rRrP TdZpTUFVabiG+vA7GWnII8FfobaDL+ItILiQKRxfz/iyFS34lgP+1K6kDHLf6K44yy36W52ZzH7R OBk4Vgtrtg6TWejI7rLfHwV8oc5kDIw5oHjqPdV/jHzhXH+D8Tu01cHyh/pCTpjJHHbnC5OzSf8A wLVMbcB/aGcXERdRj9FpYXY7e4GVymhPhyu15fXO1FVi1QU8jo2ujYJS8t7nGRwu/wBW7t1Oide3 unqqZ8zXvAiLuAGgcY+mV1O1GpNS3Smqr3cLd/6IqXOkaQ4dWPo32WrjpiZbR5N8MVvnpJza9UPq KljT0tMDcF2OAcHhafTfw11VysEs1ZeG013jc5ppmRh7W47ZOfKsDWUEV5s1VV6QqDQXKUmRxIJ6 nY7OBIAz7rnfh5fc3Umoo72Sa+GtMUuXZw4DnB9ldam0592Itqfhi/8ARMslHqNtRcImZdC2ABvV jtnPuuK202Wk1ZNdI7nd4rVJRS+gWdHWXOHfyOFZ7an1zctXGoD/AP4oODOoH8v0UVaWqNHUerNV HVMzhUPrXCNnqlgDR54I5XSYSzL+MTyXcn3Gtm+GSkYwuGs4OBk5pAMf+7R8M+iXU24dzqpGMq6S 2l8LKrpw1zs4BA58Luprjtb6En+0Pf8AKeDVvJ/T5loPhluzn6svVut7nm09TpmZ5xk4GT9lzy1M dt423LV9JX1bq1mnLxPHfmCOz1EQEUruWl4By37lQ18N2nYbhuFeL+ykY+ghe9tPIWjDXOJ7fXC1 fxZXmtfqentz3OFFCxsjG+C4jlbr4QrxVym420k/hY8yjj/EVvyW4yYz5Y8eO7ztS1qvV8NjulfR akiEdqnh/uJXjLXnHLfvlRD8MWmIKjVt2vwomuo43OZTSuaMNOT2/Rc18Ul+r5tYfw+ZzhS0wDom ngctGV2fwh3qrqaS4Wx+fwkGZG8cdRKn+R+mon+P+8ue0mal1fT2ivult1VCI7dNG408kjcskb08 t++fCif4W9KxSagu18koWupGOdHSzOaCAc5PT7cELlPifv1dU61kt07nCnpcek09sFoJIUgfCNea qqtFwtr8/hqY9bfbqd3U/wAiTGxf8e24W1IupNVUVJV3iz6qpw2kkjc6mfKwOZK0jGB9QV9Lm6us O3FH/Y6hbLOxkQbDAwHIOOrgKvu/1+ra7cZ9vncRBSyNjiHbg4U9a7v1To7bairbY1rXMbC0nHAB HJXThrKSOf5LfHyr3UxqrvtpVSaxoY21D4pC+CoYCAMHHBUb2/dinp7Rb7Bo+2Fta0NiZHGzjI78 Lv8ATt1l1ZtPPcK8Mkkmhm7jI4BAwud0FpWybW6ZdqC9yNluM7Q71XD8ueQxvsuc7wmve3e2y230 6HWpj/7MKputPwz6mWBx6C0HpeRwAD5Cr58PugtR1N/ZqK0+hS0tI4sEtQCBKDw4NwPAW21jctV7 g3CO5RWurfp6OYM62N+QNBGT9eCpq3Br3aV0jaaWzsZTwzSx05axuAGkc4Uvf/Hpep+2/bS/Elbm 3XSNqpKjGZK1jcjwSCMhbmitdFtjo+kodN2189ZUHpHQ3L5HYyXH3wAV4d9Wn+C6b9hcYSfsF0uv Ln/BYrTdjTS1NPTSOL/SGSOphaD+5WMu+K4er/24veTSts3B21N9/DOhutNCZYHhuHkg4LHe4z4X IbF7PQWRjNTayiYHtw6np5BwwnjqcPfPZSzcJ3UW1k1TWRGBwjMzo3cFuX5wtBBuzpi+1FNb30rp pC9oa1x4Ds8JpqvH8Stnjvdv01RPPSJa8Rh3kB2AV0EsNt2r0zRW2wW6WV8jufSZ1Pf08uc7HfjP K9m7FZRU9DaqaqgD56isjEEh/wDZua9pz+y+m4l5Zp+ot9xqaWeelDZYnOibnpc8AN/c8K9e0iPN /dC2nVmiv7W22n9K6MjZI3028ztcQAHe55Xg2O2bpdOwU+o9WNb+OcR6MEg4i6jhuf8AiypMvlQ2 07WU1RWROjFOyB743DBAD2khaqi3O0rqa60FFHC6aoMrREHOxhxPdZncW/xyvxE6Zj1LqjSlC53R +IkdEXgcgFw/6rsbtU0m12lqK1actM87g3LWwQl/WR3c7Hkr1bg1Nu/tPpekmgDri+sY+GXt0tDh 1D9V5d1tfz6NraGOCNj2zsc5xcO2Dhdst2y36efGyY9X5U53QnrLrrSvuVxt81BUVb/VMMkRYcYx nBA9laP4cNOU2n9sZLuaDputQJJHvc35ntAy0fZfL4i7XR3jQFuvM1PH/EWOi6JccgO5I+y7PbjU cldtbDdHxtD6eB7Q0Dg+m3j+izw/1v26c+sv4if4gZ7Dq3QFFeI44mXqCVsRPaRo/wATSPbJT+Ff TGoLK+ouM9uay03ABvXIQH4b2PT3wcrkNBvg1pvRG25Qtko6ieSZ8HIYXBuRx9wrHXS9yUO4Vg07 TsaymkhdNx7Brhj+QU8l1ncJ8OmGGXGW/KMt64NO0e8Om6zUlKx9vFITKMYBIc7pJ98FdFX7tW+G 4UdPYqB9TSSlsYl9E4yTjGcYUffFpDNUastEdPG+WQ0Zw1jS4n5neAltRuvPYrVbdOVtu9OWN4YH SRkEhx44PKkanuJa1noHTt81npy5V1BGah8jhJjgSdLC5vUB3wQsdYa5bp3WFLaGWlsrZRGBMIs4 6jjuui1BSCfVOmpnSSgGSUFrXkD/AHTj2XM603HZYdaQWZtFHLJIYmiRzckdRx3W8cdy6jll7iNf i20na4aa332lpWRXGeUxTPYMCQAcZHv9VGm02zE+4Vkrriy7soBTvMbWGnMnWcZ5PUMfzUyfFzCR p+1zNe/mYtLSfl7eyi/Zk6+ZZLjJo+mEtAHkSkyNaOoDJxk+ynlxkxxsvtfHd8txCVzo30NdNTTY 9SJ7mOx2JBIXjWzvs8tRcJpZwRM97i8Edjk5/mtafdYaHhLwllMFA+yPKQR5QZDlMLHhMFBlnIQO Eu6aATCQTzygaeSkhA8p8+6xTQZBCQT8IGCmCseE0DyU8pIVGQ/mjPKSByoMgU8nPdY9kdygzB57 pZWPhPygeco8peUZQZdk8lYhNFPqKOrhJCAyhHlCAysus47rFCu0PzlHVknul3BCYHCgEJZQCgYO E+o4S8oRdn1H7IJJ4JSSKGzykUdwjCqDKyD3AYycLEJlBkHkA8o9R3bqOFhlCB5RnlLwgoMg8g5B Ky6yT3JXzSyQUH2Mhx3IwsHPLu/KWVigbillIJoMw4jyQjqOcnuvmmg+rZXAH5isHPJ85WOUsoA8 oKCkgEk8JIBCChAvKOyy/qkVdhI8ppBAJgpDujHCBlCAgoAco+iEIGUkygd0AUJIQHlNLyhA0JJ8 IF5QgoQPHhJGUygQQnhHCIEk0uyA8poCSAR2R3R3QGUJgJIBCfdB+6BITSQCDygIQCPCEIBA+qEB AIR5R3QGeEI7JIH90k0IFjHZGQmhB6mt84XspGf3jQfJXzaMNX3gP9437rzbfXsmmnqsfjJx/wAa +NWflbxwvrUH/a5uMfOV8qsYYF0j5uTyBB7oCCtuZIQhAIQhALNjsdu6wWbG5PCDcW261dC8SUsr onjy0rZjVV2EwlNXMXjsSV1+0u1VVrCZtRWdcNvB5cOC77KRNQbYaFiu1NaLaKltY0j13/iC4Y9s HsUSoIqdSXKpnZLPUyOew/KXO7Lax68vzOkfjZXAdvops15sfZYLVRSaYp6oyvkAmc6YyANx3wRw tmzY3SdFYIJbl+M/FuwOr8R09R+gwiaQazcrULRhtU/H1AXzm3Cv0nLqx+fsFYsbG6DjtYrJIbk2 MDJd+LP/AEXnm2I0RVUHr0JuQ+Zoz+K6u59sK7TSstVqm6VNYyqqKmR8zDlriey+l11jdrnAyGsq ZJIm4IbnAU960+HugjpaZ+nJamFzXf34meZC5p/y8cFeHWeyOn7Jt/NdYJq818TWnqfKC0kuA5bj 6oIZ/tzem278GyqeyDHSQDg4+65OeR8khL3ZzySrG7f7LaZvtiEtdX1z62RuWmOQNa0/bHKhjcLR Vy0ZfJKK4RuMJcfRn6T0yN+h91ZNruTW/lynPfhdBpvVFfYXPdbZvTc7vwudIwUEqNOvl1zd5rm2 uqKp8k7RhpJ4AWyn3Nvsz43Pq3fJyB4Cj7JR1fortNJSG7+owwNbUDt3x/760kmvbvJc2181S59Q 3sSTgfRcQHHsjPKhpItVujqCpmiklrMmP8rcHC1GrNb3jU0ccVxqi+JnZjchv7LkvtwttpuxV+ob pFQWyB01RIcYA4H1PshqNWck9u/lb7TGpK/T1WJ6CUsd5HgqwNp+Gqg/hcDr1e6qCveMuZCxhaPp zyoq1TtPfbNq7+CU9NLVCZ3+zTBvyvZ7kjgH3QtbD/tq1N6XSJmDjHY5/quJ1Bqm5Xy4/jLhUPlm 8En8v2U92r4aqU2uB12vlRBXvGXRxRtLQf1US6k2sv1o1l/AYqaWpfK7NPM1vyvZ7k9gR5CbTp6b Fu3qC00ApoJgWNGAXZyvG3c+/Nu5uDql8kpGMOJwpZtvwzwutkT7pfpYK+QZ9KOJpA+nJUSXzbC/ 27WX9n4qWSeV7v7mUN+VzM9yew+quy69N/JvfqSQD52ADxk4XkfvHqKatjqJZsmP8reekKRbf8Mz XW+J9wv74a17c+jHACAfbJKiS57aX+i1gdPMpXzVLnf3TwPlcz/MfZNnTqXb76l9MsBYDjGQStZb t49QUNfLVNeJZpO5eSpBo/hjlNAx9ZqH0q1zC70G0wIBx26ur/RRBV7dX6DVztPNo3yV/X0t+Xgj /Nn2TdS8dt/PvLqCa6RVsrg6SPPSwkkBcxr3Xd31jNE+6yksiz0Rg8NJ8qZaf4Yak0DX1OomR1rm dXoCmyM47dXV/oodn281BHqs6eFC91eX9LRjgjP5s+ym6uo4stwV96Grko6uOaFxbIwhwcPBViWf C/W/gA+bUELKwxlwgFLkdWO3V1e/0UODb++u1Y7TwoXm6Nf0lmOAP82fZSRdx3do321Dbra2liwS 1uOvJyvlZd7r5bqyoqTiSaZ2XOJOV1jfhjuDaAPkv9OKsx9X4cUxPzY/L1dXv5woKu2nrlar5Laa 2leyujf0GMDlx8Y98qp07bcDdu96vtrqGrcWUziC5oPfC1m3u4tz0dK40hL4jz0E8ZUg6a+G683W z09bcrrT2ySYZEDoC9wB7ZOQoz15oC7aO1G601sRlc53+zyMbxM3OAQP9Frup+sSU/4hb8+Vsjom lreQzJxla6Pfa/fxx1wm/vMt6RGXHDcey2Wmvhvvl0s1PW190prfJMOoQPiL3AHtk5AUX630PdtK akdZ66Bz5i7+4cxv++aTgFo+qTZ0lSo+I2/OjcI4GMcRgHrPC56w713u33SetncZnSu6iCexW605 8N+obrZoK2suNHQPlGRBJG5zgPHbjKi3WGi7tpfUsllrad7qjqxCWt/3zScAtH1U3V1EvVHxIXl0 LhFTBryOCXZUG6sv1ZqK7z19wlMk8pySfH0Ux2L4bNSXOywVtVX0VDNKOr8PK1xc0eO3lRPqbRt2 09qN9lr6SQVod0xta0/3gJwC33BUpNOZAXf7T6/l0HcZ6qnpmyyStA6icEALurH8NWqLlaIayWst 9HJIOr8PN1dYH6Duopv2krtY9RPstbSSNrw7pbGGkmTJwC33BRdxKevd+bnqbT1RavSEUVQ0sk7H IXn2x3oqNF6fZbaeiY4NJLn5x1fdei1/DZq2vtcdXLU26le9nWIJnO6x9Dgd1D2o7JX6fu09uulO 6CphdhzSO49x7gp3Trbvt2N16/XraWKpaI6encXsYP8AMeCV79rN46/R1GaRzPXp2jDBn8qh4Y+q +kETpZWsjBLnEAAdyT2CbNLLV3xLVslLIympOmVww1xI4WptHxA3C3WGWjZTh1RJ1Eynnk+VqqT4 c9X1VnjrxNamsdF6pY6Z3W0Yzg/LjP6qE6mN0E8kTvzMcWnHuDhXaaic9G763KyVVZPWM/FPm4bk /kHsos1/qafVepKq61IAknOSB4XNZXpt9FUXCsipaOJ81RK4MYxgyXE9gAnKnGb287HYcCrEbab7 RaT0rSWltCMQtwSPJ8laH/4HHW38KFZ6dF1GP1DCZiJBxnGMd/1UUxWa4vu4tkdJMa/1PS/D9J6+ v2wstO33i3Dk17eaerkibEyBhYwAYJBPldptXvnUaXsrbfXRGeKMBsePb2Wnn+HvXEVr/GPpqMgR +oYmzZkHGcYx3UW09muFRdW22CkmfXGT0xAGnr6vbC1u+2ZJOostefiQfU26aG30vpTvb0tcQMN+ qkb4bqWvGkqy6XBhDrjOZmknlwx3/VVxq9hdc0FofcJqKlLGM9Qxsm6ngY7Yx3X30fuTrKkbS2G2 +q+VmIY4A09WR4wm+jU2mLdvdq66QnrbTLQR01RK0uhkYQephJAdx5VSLtdZ6+umqp3l0sri5xz3 JUz7j7Z7jXWOa/X2lin6YwSGTB72t9g0LhtGbTar1fTTz2e2ZgiPSXzuEYJ9hnvhayz3NT0x48JO 77cM2qd2c4/qVN2yO7VBoSz1FLPRdc8snU6UDJcPAXO3/YzW1jtFRca22Q/h4G9T/SmD3Y9wBytb orarVmr6CSssdt9WlY7p9SV4jDj/AMOe65urqd8t06TX0FBBS0jYRTvLy8tw5xIxjPstpsju3bNC 6dlop6IOqHyl7pQOXA9guQ1JstrWw2ae53C1NFLAAZDHK17gPfAOVwlntNdd7jBQW2nfUVUzg2ON g5JS9pJpKG+m5dFryS3mko2QmmyXSY+Z2fBPsui2S3etGidMOt9RRA1DpHPdKBy7KifXGgdQaLfT t1BRCmM+ejEgdnH2WGitE37WNVJT2ChfVPjGXnIa1v0yeMq5bvtMZNdO4303EoNdVtDJRUrYjThw MmMOdnwSus2T3fs+jNKC21NGPxHqOe+QDl2fcqHtZ6G1Do+eGLUNukpPWBMbiQ5rvsRwsNHaJv2r qiWKwW+SrfCMyOBADfoSfKW79rJJNR3O9m4Nv1jfaGttlM2B0DCHPAwXnORn3Um6T38tUmmqej1D RtqJowGubIwOacduFXrV+ir/AKTq4aW/W6WlllGY84cH/QEcZ+i3NRtLraltBuM1inbSel6pf1NO G4znGc9ld21nWOMThqnfq1yWP8BZaVtO156XBjQ0BvkALbt350xVW2CCuoWzNY1o6JGB4yBjsVTn L+rBzkLt9P7a6wv1qjuNpsdVVUchIbI3ABx9CVO501qVYe778ac/s/U0VtoxEXsLWMYzpaCfoFjZ 997BUWOngvtK2oqIsH52BwyOx+6rjqjQup9MUsdTfbPU0UEjuhr3jIz7cFebS2jdQ6oM4sFqqK/0 MGUxDhue3cpunFYnWG9tgv8Ao2top6brrHg+i5zfyOz8rh7EL5bdb70EVjNu1Mz1/SwGFwzkD3Vb tRWG66frzRXmhnoqsNDvTmbg4PkL2aX0bqLU0cr7BaqmubEcPdE3gE/UqGktb1b0P1NELfZyY6HH zY46lx2zGq7ZYNZRV9+hE8DI3dIdyGu8FcLqCx3Sx3F9BdqOajq2AOdFM3DsHsfqPqvdpnRuodRR Plstpq62Nh6XOhjyAUVZTdDeTTWoNJ1FLSx5rgWvp5Hd43gg5B/RZ6F34tE2n2UWqIxLLFgZcMh+ OQefqqsXq13C0XGWhudLLTVcXD4pW4cFsdP6P1FfqZ1RZrPW1sDXdBfBGXAH24QSzvdvG/U2aC1P LLeO+D+b7rn9h9X2bTmq312oIhI0R/3Lj/gf7hRfdbbW26ulorhTy09TEemSKVpDmn6hbKyaR1De aQ1Nns9dWwB3SZIIS8ZHjhBaHX+7ul66GirbcwSXSknZLDITnoAOSP1Wwrd0dvtSQUk2oKGCqqIm 8es3PQe5x+qpzXwVVBVS0tZFJBUQuLJI5AQ5pHgjwvMJ5B2P81bWZhIs9vRuxZ75ZILRZ2h1KHNL vp0+B+i7bS+7GhaDSlLbI2iKAQhskXABJGHZ+6pWJpHuwt5bNO325UYqrdaq+qpsloligc5uR3GQ MK8rqReM7n27q36wodL7rzXqyMzbmVDjGwnsxwwR/VWHq92tFVDoLz0xOu8UPRFI/GWA9wP3KpXU QzwTvimjfHKwlrmOBBaR4I8La0VivdXQCrpLZXz0vIE0cDnM47/MBhS3d39tS2ST6Wn1turpn+J2 O/W3pluVM8sef/mZBBH81s6zWm2V8uFPd7hSwS17A0iVww5pHI/YqmTzK15DuoOBwQeCCtpTWW81 FCKyG210tKcn1mU73M47/MBhEWo1ZvbaWamtTrbiWlpnFxcR/mBaf5Fba5at2yvt2p7vcQJK+Lpc 15OOkjkefCpY50nVgHhbKktd3qIPXpqGtkh6errjge5uPfIGMJvXpNbTf8R25Nv1RHSW61nrhhd6 nqfX2Wm2b3dj0RYK621FP6jZZDIxwHuMKFpXSPdkklfeO31r4+tlLUOYR1dQicRj3zjsmV5a38LJ x3r5F+qW1tyqKiNvS2SRz8e2ST/qtb08L6vYSc5/Vfb8FUAAmKQZb1DLDyPf7KDxlqOn9F9Cx3V4 X2fSyxgGRjmAjI6mkcIPN0JdK+xjI+yzdTSAZLSB9WkIPN0p9PKzDHdZ7YX0ERJ+n2QfENTwvp6Z 90CMn/EEHzA5Tx7LP03Z4wn6fH5mg+yD5gIwvqI3ZwgR8/mbn7oMAOUdKzLCDjCy6P8AiH2QfMBP Cz6SPBymG54yM+yD5EJhZFpB+b9EYQJAWQafCyLD9FRgELItQAoEmAs2tymY3Y5HCDDCFn0n2WRY R4QfIBGOV9Okk8ApFjh4QYYTwV9BGT4R0kdwQivmAnhZ9J7jP7JFmDyCgxIQAvoGZCCMe4QfPCeF 9GtJQW8oPljlGF9MEeEw390R8sIwVmWj6/sjCDHCWF9MfRGMIrDCWF9cful0/QoPnjCZCzx45SI/ dU0+eE8LPBHhIj2RGGEYws/3/ZPBQYY4QRwsk/CivmOUwn04TI4VRgkVkQsEDHCEDskgEJjhCBIR jhBQJCEFAIwhCBI8Jjsg9kCQhHdAd0Ht9EH6JHuqBMpIQCPKfZLCB+EJeUwcoH2CPKSeMohJoQEN hCaxQ2ZwkmUDuikU0j3TKBLLusUIH5Qj6pIGeEIB/ZJENJNJAIT8oKBeUz37JDHlCAQgIKATwkU/ CACSEIBCCfohA/CRCPCEBhGOEIQCCUIQCD3R2QgEk8poNgTyvvTnMjce68TnfqvrTP5HdeaR9bK9 NfU/+tzHz1lfKq7fovtN/v3fUr41X5V1fOyeQIPdCD3WnMkIQgEIQgF6qJuZACOMrzBeqicGzNPt 3QXi2fhbDpaLpaAehnj6KvldeJqTde6SxlziK97enPcZ7KWtpNbUctrjputjeloDgTgjC8l00Vp3 +38N6pbjE5tQ4ySUrTktfnlxd7HPbCMWd7THo+WWsskbqinw3pyzLQcqP90rncv7X2SgdSlls68t mAx1O4yP0XRX/WFvtEVvt9BUwPfISCM5wOF9r/HbL3baGaephFXTydcYD8AE4ByPsotdA+Kkl0sx leM0+Gl3OOxyuIob3FVa/q7dbZmOt7Gw8ROy3qx9OF1F+o6e6aVktMd0poXyNa0y9XYA5PC8dgsN i01bRDQy0zqh8jHSTdQLnHqGeVUdPcLlBTXCnp5sBkmQcgf6riN+nNj2tvHpEBvSwN6eMfOFrNyb rTO1fp2Olq4nEOlMjWu5AIGMp741lNNtTV00VRE6olETWxh46nHqB4W7JLNOXjyyy3uOC+HOsnqZ 3xSPLmMkaByvL8XpBrLU0DhvUV1+xemqbTNlkuV1rImuf/eFnWB04Chr4hddU2rdQNioAHUtISGy /wCYnur4dY5ZW/MXz43Lhx+Kh9x5ysSUE5P3QVh3JCPKSACySBTHJQZxDLuVZ/4ULdCGTVXpt9Uv LS7HJAVYY85Vk/hq1LRW2I0kr2icvLsE+CiVN96t81Rq6eqdVvjip6dhjiHYuOcn9gF01Uxv8QtQ wCXB2T5GGhaWusTLnf6e8xV5ZAYwySLIA+XsvHVa6tL9VQUEErJH02QXZ4yRjCtu3GTiyu1vqajW FTVOrHsgghj9KIDguOer+gXS1cTBdbZ8oyQ/P6NC0dZYH1+poLxHcS2jfGGyRcADp7efuvPNrqzz 6qiooZmSPpeoFwPkjGP5KNSfb53CjrpdY1NY6tcylgbG2OFreHE9yTldRUwsF8t5LRlwk5xzwAtD Np6ap1THeY7n/sEjB6kPTgDp7eV8zre0VWrGUkEzZHUoc1zg7yeP9FvLV9MYyz2xrKKufrGprXVr m0kXpsZAG9ye5yuknghZqGjeI29ZZJ82OeMLRTafq6jVwvDbkP4bI0GSIjABb2xzysGa1s9Xq0Ut PK2SSna5pcHcZP8A9pYbsfD8FcXaxq6+Sv8A9jjkZGynDPfGTnK6WSCAaop3+iz1jE49fSM/utG3 TtadXPuwuRNsk/vHRFuA0jGPPP7JU2srNW6tfBTzB8tO0xkh3GSuudl9OXjx17Ytork/VVZcJa4C iZMyKOm6cnnGTnPH7LfPpaf+1kT/AEGet+HcevpGe/utOywV51dNdH3HqtcgEnpluAwjx35+/CVH rG0V+rJIaeZr3wMMRcHcclco7PhS0tzOqqyvnrQKQVAhjpw05x5OVvxSUo1cJfQjE/4cuMnSM98d 1p6OwXJmrqi5T3DrtT/71sZbgMIPbvz98J23V1nuGqZ46adr3xN9EkOGO63b9Mx57ZTXU6pq62qr M0jqr0YoA08AHyVxm5GnY7pvDp57GwxCKP1ZHkd/mwPuu6t9lu0Orqquq65rrOT60bMEBpz2/wDf UY6iv7dUb12ynsLnTR0jDHO9v5TyT3+6uGv239M5S7x19pU19ObXp+Kqjq4qdlLiQl/Z4APA+6gS 0Xt26O69trC2KKltzAC53n6qUPiKtlxuG3L47dE+SSIiSQN8NAOVXH4f2VtRr6mjog9zCMyhvbA7 ZW8v18WNntz8cuXly2t1uBVmz6firW1UcEVH/eO6zjrAHYfVQHYbu7dPd233FrI4aa3xAEv88nHH vlSX8SduuFbt4G2+KSQwuD5enw0NOSVXr4dG1tRr6COja90eMy9PbA90y68WNnyuG75MpfS2+4Nc 6y2GKvjqIYo6Q9bg846xjsPqoH05dX7pbwUV2ZHFDS2+ENJf5xnH6qQfidobjVaAYbdDJIIX9c3Q M9LQOSVAnw2iun1/FHSdboiwulDe2B2ys5STxy/Lfjyt8mUvpbPcO4OsdmhuQqIYYaQl0jXux1jH YfVQTpO4HdDeenvLIo4qWhhDMu8kZx+q7n4p6O4VOg4HUEUskcEpfUFn+FmO5+ihD4ZX102vWQ0w eYC3qlDe3HbKxZrGN43eVi1e411fp+0wXUTxRQUZLpWvdgvBAGB9VBGiqlu5W9zL/DFHHTUcTWnq PcjOOPddl8WNPcZtF0z6GKV9PDIX1BYMhrcYyVDvwwurX68ZFTdbqct6pQ3tx2JTLrHU+Uwu87fp aLcW8Tadpqe7erCyjps+q17sOfnGA33UO27bql3e1RV6qvRlp7S+MMjihdh8mPOVufiwiuD7BQy0 0Ur6KF7nTvaD0tzwM/quz2IIZtfb2xkGUQ5AHfK3n+uE18seK7yytcU34ddE1TZY6Z95jk6T0uke QAfB5GCot0hsTd59fT26pk6LdQSh0lW3/EO4A+qnGyXvca63Copjam0EMZOKiryGuHuMArtdNw1c WnK5tVLHPcndfqPhOQ52OMLnNenW2+3rt9JT23TdVT0lRJUsije0vkIJJDfcL84dQDF2qseZHH+Z X6EaJpK2DbsQVsUjK0wvyx4w4uIK/P7VtJUUGoK6mrInwzxyuDmPGCOVrUmNTG25NMrB/CTpl9w1 fJd3xMdT0bMBzv8AMfZV9Csf8INRXO1JVU8fWaJret+Bx1duVzdVhde6ml0lXx3SrLP4T6fRJ83z deSRwog2VoW6r3hvuroIGNouslpd3DiPH6L4fF9JXsqrd6bZf4f6fzOAPR19R8+613wiVVa+/wBb TN6zRNZ1uOOA48Lp5sZxxkcP8fK7ytTrr3U7tI3Btwryz+EyxiM8/MHjJ7KI9g7c3UW6N81XBTgU JkeWOf3Dney8XxfzXCO525obL/DjFjqwejryeM++F5/hBr66S8V1H85oWN9Q4HAceO6mX+kxjXi3 yuVTjrzVY0dcxW3XH8Jnj9MEHnrGT2USfDzahetyL7qiCnDbf1PET39w5x7D9FqPi/qbg2+UMZbK LeYh0nB6S/JyM++F6PhAuFbLcLhRnrNFG31O3yh54xlTKax4r47u3JNOsNWSaRvBnu7Gm0VTPTid 1c9YHII8L1Qmet26lOmmsbWyxF0IGGgPJz9lAnxT1lxbq2nhk9UW8RN9LIPSX+cfVTXWTVFp2XbL a2vNTFQsLBGCXF2B2wt548bGcMtytholt6t2l6qTWZibUBxJIcHNDMfT9VGNl3DvF8bLpzRduikq YQ4+r1hjQ0Hvz7rvtoLhcbvoiWqvbJWVD5HAtlaWnAA8FQTDpTXejJbjqez07BQyk5EbuuQsLuMM HKanC35Jbz18LFaPbeabR9Q7WDI46wl/U3qDx0Y45CiT4eTpS31dTIGsffp6l7GnglrSeAPZShtX da69aCNZeGPbUPLw5sgIOAPYqtOyVPUSbv07ooZXU8VRJ1vawlreTjJ7LnvpvX7bdv8AFrA2ouFi idx1dQ/mpQtlvj0Ht1QU+l6CN9bOI2NaeDJI/GSSo8+KKkqJ71p50FPLKGlxcWMLsDqGTwpXvstW dIW+ustOyulpRHKI+oDIaOf1Xp8mrlh/08nhtx8eX/8AU89wtlNrfQFVS6oommWDra9vVksewdw4 f6LzUFDDoLQFDR6Wt4fU1HQxjc8vkf3cStpp6eZmg6qtvETKKWrbLO6MnhvWOB/RPUU9RDpS33C2 U3419J0TGNp7hrTlebxbv+z0311Wp1TQQaq24qJr9RsFXRB7wM5LJI/IP3C9WjXTan2rhFVKGyVV O+MyO5DRy3Kwmnmbtbcqq6RNpJquGaYxl35S8HAWt0U+Wn2LY6AOMjaKYt6Rk5wSumMvHC/O3PPW 8t+tK8662drtFajtk08gr7NUzxh1Q2PpDSXctcMnjHlWg1d/F7bpO3s0VR+q9jmtMcOAAzHfwvLa ZnX7aOGoubGzSSU7nEPGeQTj+i+G7upavRuj7fVWz5D6jY3YHAGPK55S39nfG6mnq1BTvvG1rqfV MDYqupi6ZIpMdTXk44+qwqaOLb7S9Ba9J2syVEzulrIwOtxA6nOJ8nAK9ArDe9r6S41oDpZYmTEk dj1Ar07gXGW1U9tu9PRyVsVO9/U2Lkjqb0tP7kLUm5Dftz25GmLPr/Q1JcrlSuiq2FjmSAASNy4N c0n9+Fs6+CHbzTdutWlbW6WSV5a1kQHUekdTnE+TgFeuubJT7eQNrIxTzvMbnRE/lJkBI/mnuTdJ LRT2+4xUclZExz4z6Yz0l7elp/chZ1NlupuOc3R0lZNd6PobrW0xhq8xuZK0dLwHuALSfPdbS7Og 28sNttOl7Y573nhsTfmLWYLnH3OFsLrE+n0BRw1TRDPmAOjJ7H1Gkj9F5dyrpNZKiguLaKWrp/Tl gcY/8Ln4Dc/creElvbPkys9Od3W0NY9eWC13mWD0KqSWH+9jAD3Me4AgnzwVu7tVU23dqttn03ap HswXFsDMnoaR1OOPOPK2FZE+i0TZqeqAilbLTNcwnsQ9pIXj3Cu8tiuNJW/gZ6uCWGWmBibnpe8t Dc/fCTGJnlrWnM7qbfWDW9PZr26F1PU1MsLHPiwDIx5HDvr9V0V1r6bb2gttm09apHwtb6jhBHnD GkBzjjz9V7qmB9NpvTUM7Sx8dRShzXcEEHleHcO8yWG7wzmhnq4qulfSMMbchsjjwD91cZFtuoiz 4o9HWqv03TauooRT3B/QJCwACVrhnLvqPdVMxh2CrtfEDGYdpKaOQFrmNiBaeCMNIVJZXESEhazw k8eN+XPw53LPPG+o7jZrSdNrHXVvtVc97aSUudIWHBIAJwrn3S+0GgDa7Fbbc8UcbGul9GP5WMJ6 QTjtyFVn4W3D/tTt5cQAGSd+P8JVn9wLmLfqGemfRVFQ+6ULKWAxsJBcHkkfoDleWW7r2XGaxc9u Js9p3UmsrPcS19N+OeRURw4Akw0uz278crrLlfrboaottgobc9tC1rfU9KP5I2OJaCT2GSFvrizo uumWv4LZHg59/RK5DcC5No9RVVvloaieW6U8MVM9jCWlzXkuGfoOVu7105XW+65zXeymn7xru1V0 XVS09fI41UEQADy1pdke2cYK7et1HatI11Bp+koHsoYw1knpx5jiDuGgnsMn3W/u4xf9PD2fL/8A YiuG1rXNp9QXK1SUtS+ouf4c0zmREtd0EF3P0wrPVvyX37czrTYqw3HcK3VVK40lFWPfJU0rG/KS 0Z+X2B8qQarUdq03dKLTtLQuZRxtbC7oi+SMOGGtz2GV0NzwdTWfkZDZv/KFwuq7jDFqK6WZ0E7q yumpZIOmMkFrOkk5+mCrqaK4/VGw9lr9xqSWllNLbqrqnmpWN4y0gkD2BypIqNR2Oz3qi0qyjaKb ApekR5a0kDpbn6hdBVt/+Gy3E9vw839WribzdaUaqqrHNFIa+W5QVMPy5HSOnLv/AHJSyNY6vtw9 32Bs8+5MT4J3QWiZrql1M0diCMtB9jlSab3YKW8waQ/Cxml9P8KI3MBAOMBv7Lo6tudV0R9qWX+r Vw89zojqySzTRvFxN6jqoiWcdGG85/QpUunCybAWk7lECciyuZ+KFL08j5sFmfZScLxpx14/sWaS N1MYjTmN8YLSQMdP14XSHH9sgPP4Hj/xlcLDcqF2r32l4IubLy6pblvZhaBnPseyny1jJeq4Sl2A tce5r2On67GyNtWymIIdy4jo6vYEKTf4hpW4XefRpo4HRvhMJZ6Y5I7jP2XSx/8A3cTf/u5n/wBk cuDstZRS68ZRNLhcIrlUSvj6OzS3HVn9gtYYzKXbjcrMsZIrvurtg3SevqW2Ub3z0FaWyQjB6mNL sFv1x7q0NJbdN6E09aKQ0FOyjlcInSSMDnAkZySfquN3gvDLFuxpi4SRNmayAMLHDI+Zzm5+4yF1 W+N4p7dt7OamBsjKlvptz3YcZBH1XKb/ACa3075deKWRXTeTRFqt+5lHSWRhFFcXRvLI3ZALnYd0 +3Csn/B9K6OtNnt9RbaMUk3+ziaaNrnAkcZcRnkqrW1urH025FprLk38WwOMDWyc9PUMAjPtlWW+ IG601BoKWKpp2yGo+WJx7xuHII+q6dZ56xZ3rxzauW52gLdZ9z6e2WtzjbayWM9LXZLGudhwB/dW ZqLFo7S1NZ7PWWmhdTTNMEc08LXuBA4y4jOT7qsm02qxBuRbqy8MFaHk07fWHV0l2ADz7ZVhfiKu 9LQaNME8DXzznMEp7xOaQcgreMmeWpHDK3DHuq7a80Fb7TuvHZaEv/hlRUxNA6uWse4AgH6ZKs5U 6Z0RYf4ZZKyy2/05onQxyzQNc7IGOXEdznuq57N6qY3cqkqL1E2uNQPw7HSgOLHEgNIz5U5fEZd6 W36ajimhBqnu64Jh3jc0g8fdTCTyZ8Ynkyy8eMt9q+6n28oaDeBum6aST+GzVTGs5y4MdjIz+6sx VaM0Haxb7HWWW3h88BijmfE3rOBjvjv9VAWx2p4pdy4Z73A2tnqmiGOSQAmN2RgjKl/4krpS0Nhp muYRcA71KeZpwWYPI/VcfD+/luG/Tt58vx4S/aBqzbijg3k/st6srrcaoMDmkB3QRnGVZGv2/wBA MFNp+us1BHPNTYiqBG1j3Y4zkefKhLYPUlPVblGW9xCqrKtjWQzP5Mbwe4Up/EjdKShtlD0sLLrG 4S087TgtGcFv6rOP7eXKS+m/JrHDG/atGsdv6626wu1ltNPVXFtHJgOhiLnBp7EgfdaOu0hfaGkf U1dmucEDBl0stM5jQPuQrjbAOiqtAy3upw2tqZpTNUkfM4NOOT5xhdcbzZp6WenuV3paummYWOjk aACD3z7rpqsS7fn7aaCWqroIooXzuc8H0mNLi4DkjA+mVby4be6Mu219ZcaTTsFDVPpHPa7oLXxv aO/uOQvdt1onTumBddV0sIk6Hy+jnkRsaTyw+MhdTVXj+O7Z3K4YAbLBN04/ygkD+iuOP7SX7Y8m XGXXuKDV1OIJ3sz2dhecMyQFsr4MV8jvHWV4oBmbCZzjbI6+P9pN/KwGxuzVPcqJuo9YNjNqcwuh py7iRpGOpxHbBXW652Z05f8ATDrhoCGKlrafJMIeS2bHdpyeD7FdXpT5Ph+o8nA/CNye3HWMroNA UFFb5r9HaXh1E8skY1ry9rSY+QD91nx7y8fOrnNeXLD4iE9odkoKunfedbRtbQ4PpUvV+Yf5nOHb nwtvuHsrZLrptl22+ibFJA0l9P1lwlAPPJPDgpSvIDdqTk9LTEzqOcYBkbn+Sz28oKW2018pre8P pPU64w1/WG5YCQD910uEmHJy578lw0hbaHZGnrbe+8a1h6aKRmYqf1C09PhxcD/JenczZO2Tafjv W37SYomEy03qF5eB3IJPceyl+5CM7XUccziyJ7YWPcDjDS8A/wAl9dB0FPbbdf6KjeX0bKuT0gXd WGmMHGf1U11tv4QjtLsjTVtqfedbBzKSVmYKdshY4Dgh5cPfnhY7qbJ0UVlgvugmyzUbI/8AaKYy F7sd+tpPt5Cmm6xRT7fWiCocWU8joI5HB3SQwuwefHCNG0MVrsOpbdTPfJS09VMyLrd1EN6AQM/q tTGal+WOVQntPsfS3Czz3fWwmgpnj+4gY/oeAOesnzkeFjuzsnTW+0wXvRAmqbc2PM8JeZHj/jB9 vcKdL3BFUaLs1LUOeynlMEb3Md0nB47r46UoRa9I6gt0cj5YaaeojjMhyenpyB/NS4tS/aFNrNj6 W42WpuetTU0kTxiCJjuhzR36j3zkLwbv7LR6ft8F50mZ6y1dA9Zrndb2/wDFkeFYLU1NFWaesVFU TPhpp3xxyOY/oOOg8Z++F59O0Ro9vrpb5JHTNpn1ETXPOSWgnAV4fK970hHbHYyC4Wie5a1dU0cL 2gwxxv6Hs57nIIIIwQtPu5sxJpSGK52CWevsrwOpz8OfET2JwMEH3VkdTUrLjaLFQzzyQQ1TxHI9 juk49Mkc/cBeS10z6bbGqo55XTmD1oet/JcBIQP9Fznd0ukI7b7ER3GzS3LWM09FA9odE2F+Hs55 6gR9lod2tmanSDmV1mfPcLLIBiRwDnxOPh2ByD4KstrCj/idvsNudPLBHVP9N7ozg/7okfzAXko4 pWbWz01VIZ3wB8XW/ku6ZMA/yW+Jr3UHbfbCNutjNz1XWTW+N4Do2xEdTR2IeCOD2XN7s7QVei6t k9C+Wts02BHOW5cw+zsDHPgqzu4VK6vorRbxUzU7Khzg50X5j0xlwH7heWOKR+1BirpDUTRMDS94 5JbIAD/JSzU2xjlLbPpCGgdgzd9Pm46lrp7V14dE1jQcNPHzAjIOfr5XIbpbUXHRFwHSX1trlP8A cVIbzn/K4DsVajcKhmukFut0NXLStnbIXOjAJJazIGPuvhLE+r2ppf4gfXnjZGXOfyS5rwMq3DU5 fZMt2xBOhdgZrxp4XHUFwktD5XB0TPTa/wCQjjqBwQc/VcRubtfc9D3X0Zg6qoZT/s9UxmBJ9CPB +itpr621N4FHbqOudRNfFJIXNbnJaAQMfdeecPr9trRLccTVQMDnPcMnqDwCU4+kmffaBdD7AVl8 09FcrxchanTEGKMxB/yHsTyMHPhcNuTtnddEXk0lYDUUkh/2eqYzDZR7Y5w76ZVudf2ytu5paC21 5oMRPlJazqBLcEDGRjlYVg/imhrBNcQ2Wq9WncXOGfn6gCVeHpqZW+1e9F/D/c7/AGCC5110itfr uBiikiL+phHByCOT7LhtxNu7loi9uo7hiSE8wVLW9LZW/T2P0VvdwaC4V74qKz1zaExU7pg3p4cW ngcYwvrdIY7nprTtVcYo56ls1O/qc0HDjwSP5qcfRjd3SuOj9grzqLT8VxmuEFsdK7+7hnjLuthA IcHA+crhdb6Dumj7y633WIl2f7qVo+WUe4VwtwKa61DxT2OrZSfhqY1IZ08OLXdhjsvRqGkprnbd NVlxp456lk8L2ucwHDnDn9OVmTem5irXpXYG/X+xMuDqunt0sjiGQVUbgXtxkODgTkEfRcBrDRN1 0reJLdd6cxzNPyuHLZB4LT5CuNuA28yVTYLDURU4o6b8V0OGM9LsYGO3C9eprfR3mDS9VcqWGecT xuBe0Hu0kj7K3H0zheas+ltg9SX2zR13q01C+Q4ENUHNdjuDxnIIUd6u0nc9L3Wa3XendDURn/uv HhzT5BV09w33qOojZYJoohR04qTG7I6sOxgfouX+IS209129o7jPAw1sfQ4S4+YAjkZ9lcMLllMZ 8s55cMOd9KXvGDjCxXtro+iYj6rxO7rNmmp2xQeCn4QgXsmhCASQgqgCRTQgQR5TwkoD+SMoRhAs p+UvKCgEiskigEeEJeVQI+yaSAQUIAQPhMHKSBwiMiEuwQCmgSEEIwgaSPCCgDwgIQgAEk0yECAS T8IQHhAQQkgOU0d0ucoH490YR4TQYnshMpIBAQEIH5STSxwhAhCEAhCf1RSR5QmiF4Qj6IQBQhCA S8po7KgyhCfT9Qg+xOe3ZZ0zj6gGeML4udnhfSB2JGkBeeR9DLLp8JuZP1Xxq/ygr7y/mXnquWrU 9vJXkTKAgrbmSEIQCEIQNZscWuBCwWbW9WOCfCDcW66VVE4Pp5nxu8FpXtbqK5tnMwqZTLjHV1cq S9n9nn6lYK++h0VAMER5wSuxuugdA1WpKa1WukdGKd3+0vZO49fbj+qsZqAJL5cJagTSTSGQchxP IW0h1pe4yD+Lndj6qdde7JWiR1o/sxQPgidI4VUjZS49OBjuffK3Ndszoi12mmbWUc34uRzW9X4l wL+ecD7Kck0r23XuoMZFXNj2ysH66vxdn8XN1fdWaqtmdvqO3CrntdT6Zx/8dP8AK+FTsfoSpp4p KSjqWh0jWktqnEjJ7cq7NKsy6iuL7gKyWZ5qB2eTyE7nqi63F8bqyofJ6f5cngKw2tPh+tLZqZ1h FTT07Hf34Ly8uH0J7LV7n7Q6X03oyOuoG1cdYXRt9SScuHJ54xhXHeV1GcspjN1CVTq+9T0P4SSs k/D4x0jjhcxLI55Oeys9o/ZnSF308DJJVy3CRh6ZTPhocRwekfVQLr3SFw0dfZrdcmHgn05QPlkb nuEnfpvenLFGU3AZWJ7KNEhMd0EIEn/VLCaDMEgLZWm6VFtqmTU8jmPacggrWNzheq30stZVRwU7 DJLI4Na0eSiJBn3V1HLSGBtSWsxjLeCuYodR19JX/i2Sv9bOerOSSp20T8PFJV2Ftdqm4VVPK8Ah lMW4bnwcjlcJu3tJUaOuVCLZK+st9a704C8j1OsDkEDjCbTpr592NRz0Zg/FdDSMZbwVydFqOuo6 8VUUrxKD1F2e6nfRfw701XY2VuprnVUssgBDKbpwM+DkFcBu1tPU6MutIy2yvrKGtd6dO55HqFw7 ggceU2dPFUbtajnozTfiSxhbjLeDhcxQamrqGvFVBM8TA56s5z91OGj/AIc4Kuxx1mpbrUUs0gBE dO1pAz4JKjzdbaus0VfqWmpJH1lFWu6aV7seoXDGQQOPPdN/JqemFdu/qWpoXUwqA1hHSS0kHC5S 06ouNBcm1cM7xM09Wc9/upx0h8OLKqzw1eo7vPRzS4IigY0gZ7AkrWv+Ha4nWRoYqsfwc4cKl2DJ 0+R09soajka/ePUlVRuphOI2OHSXMODhcjaNU19quTaynld6ucnJz1fdWCPw46ddVupm6nrfWB6S z0WEgrk//gebq/WMlsbVBlraeoVb+nqLf+X3Ts6cxct5NSVlC6m9cRNc3pyzIOFyNj1bcLRchWU8 rvUzk5PdT874bLE+o9CPVNUJQcFogaef3UJ7nbf12htRut1Q4TQSEmnl4Be33I8JNl1G/uu9OpK+ 3PpRP6TXDpJaTnC46w6uuVouQrKaZ3qA5IJJDvupf0L8PEWorBDWVV/fTVLx1OiigDw0eOSQo6G2 VyrNwKzTNnLqt1NMYzUOZhoaP8TvZXv2nW9Nvet69SXG2vpBL6LXN6S5jjnC5rRWu7hpW4TVdHh8 kuOovPKmOs+GN0VukdDqAy17Iur0RTgAux2zntlV6vNmrLTcpqCvhMVTC7pcwjz9E1fZMsd6SNqj erUN7tslG+X0opGlri0nJB8Ll9Aa3rdGVs1RbmsL5QAc9+FIG3fw/wB21TZjcrnWfwqneAYWmLre 8e5BIwuHtW3F0vOtKrT9naal0ErmPnc3DWtB/Mfb7K9638HLGZcfl0Oq96tQagtUtBM4RxSgtcWu PI9lzW3euqzRNZPPb2sLpsA9RweFLF3+GWspLRNPR31lXWxx9X4YU/Tk+2eoqvtwt1RQ10tJVROZ PG7pcwjkFTvX8Jljbr5ShrHeq/6ks81umcYoJR0vw48j2XObba/rNEVU81BGHOmABPYjC7TQPw/3 zU1idc66rZaonDqhjkiLnPHueeFDt6t5t12qqMu6zBI6PqxjODjKurZv4huctfKU9cb23zU1lmts jvSp5m9MmHE9Q9lzu2e4lZoaeokoYGPM2MuJwRj6rgQx3sVJm0+0N53AdJPA9lDbmZBqpWFwc72A 8rO2m013vZe9U2Oa1zAxU8wxIA4nqHstFtduPVaEkqX0cAeZ8EnseApOk+GCtdHJ+H1LQyztaSGC ncMn2z1Lj9IbC6nv14q6Osay2RUpLXzzMLmud/wgHkfVAtwN6Lxq6ySWuZoipZcF7Q7PVg5C+G3e 8V10lQmkYwTRN/JlxGB7LspvhiuZhldT6it88rGktjbA4dRA7ZzwoDv9lrbFdai33KAw1cDul7D4 V7TpOdy+I29T0csNPCI3vaR1dWcLT6M3yu9hZK2Vpqeo5BLuQoTAIHYrq9vNC3jXF3bQ2eEHBHqT PB6Ix7lTa2RLh+I+7tmkkFM0kjDcu/L/ACUGauvlRqPUFZdKw5qKl/W8/VStrj4e9TaZsstyhqKW 5xxcvjpmu62t8nBHhQnI0tcQRyhNMFLez+60ugqCop4abrMr+pzh3KiRbTTtmrr9dIbfa6d9RVTH DWNH8z9FFSluzvHW64tLLe+MR0weHlvGSQvns/u0/QduqKaOlEnqydZeO547FbSu+GvV9LaJK0T2 6WRkfX+GY5xkPHYcYyontembtcr82zUVFK+4l/pmEtILSO/V7YV/qSJH3e3fqdeWynoXQiOnjf6n 16uy+uz+7v8AYK0z0bKQPdLJ1l47njsvrdfh01hbrPNXufbp/SZ1mCJ7jKfoB04z+qi+zabul4v0 dooKSV9e9/R6XSQW+/V7YTV1tJZ6SNvFu5Ua+oqSjdCIoKeT1QPJdjC9mz277dCWSWhFGHl8heXg DJ+6+d8+HnWNos1TcZRb52wN6zFBK50jh9B091GVg05c75fobTbaWSauld0iPB+X3LvYBNfK7npJ G8W7MmvaeipxCIoaZ5kHHJcRhdRoH4gZ7LY4qGviMz4x0h3cEDsuY1JsBrKx2eouM0dFUwwN6nMp 5HPeR9G9K1mitltW6st7q6gpYIKUHDX1chj6/sMFXaST4STqv4iZ6+zy0lBD6MkowX+QF89G/ELJ a7Qylr6d00rf8XGMLh9T7DazsFnnuU1PSVMEI6ntppS9+PJAx4Xj0fsrrDVdrFfb6SCKmccNdVSe mXfUDHZNmkj6w+Iie5WWajtkBgllHSZO2AtdtdvZSaS0623SUgdL6rpXPxy4k91yGqdjtZ6cs81x q6Onnp4Rl4ppfUcB74wo/wBN2Kv1Deqa12qETVdQ7pY0nA+5PgKbXSy96+I2kqbZUww0QdPJG5je pvAyMLltst9JtN0clFcmunhH+784XB612h1Xo60vuV5p6ZlKxwaXRzB5ye3C1WhNutR62dMbBQiZ kX55JHhjM+wJ7lW7k2zNX0kPdPe6q1REyjoeqCkHLm9slbPbHfiWxW11FeGOniaPkPfCiLX239/0 RVQwagpBCZm9THsd1sP0yPK5qhpp6qeOCnjfJNI4NYxgyXE+AFNrqJu3Y3pqNVRMpLf1Q0YHLRxl dXt7vzbrJpOitVXTF8kDOk8ZBUMav2z1NpO0U1xvlA2ClqCGscJGuOSM4IHZfPQ+3OptZRTS2C3O nihwHSOcGNz7AnumzUTVrjfyCusoorPB+HBPOBgY9sLcWH4ibcLTBFc6cvnYMOJGQq2640de9G3B lFf6Q08z2h7cODmkfQjjK01vo6ivqYaalhfNUSuDWRsBJcSm10sfuLv1BdrJ/D7LF6LX8PIGBj2w vtt9v9BQ2YUV9jMzo+GkjPChDWW3mptIUdLU363mlhqXFkZ6w7JAzzjsjRm3WqNX001RYLY+qhiP S55cGAn6ZPKbOKR91t6qrUtTHFbXOgo4yC1oPc+667b7f+lgsTaLUUXrSR4AJGQQOyrZqmw3TTd2 ktt7pH0lZEAXRu9j2OfK9OkNMXjVdwNFYaKSrqA0uLW8AAe5PCbNJc3V3qqdRV0bLcTFRwuDmgHG T7rtdC7/ANCLCyk1DD6skeAOoZBx2Vd9Y6K1DpF0LdRWueh9bPpufgtdjuARwuXdI5owFDSet1N6 arUNxY23PMVJC4OYAcc+673RO/1sdYYINRRCSpiIx1DI47H7qo3VnuSSvdaKGsudbDSUMElRVTEN ZGwZLirs0nDdDeaqvt1jdbpDHSwu6owCpD0bv9aJbHTR3+IOq4CCC7B5HYj6qsGp9KXvTVVDTX63 T0U0rPUjbIOXDOMj9VvaTazXFVSRVVPpq4SwStDmPawYIPY902ajpt7d059Y1j4Kdxbb2nDG/RQw 52XErc6m07eNOVjaW+0FRRTub1tZM3BI9wtIltvskk9N1pa+VVgu1PXUMjo5ondQIKt3pffrT1XZ qOa9Rj+IwAkE4+U4xkfoqVjuF0emdM3zUPrCx22qrvRAMnos6g3PbJUVMOut66y5amiq6CQtgp35 iA7YUt2DfXTdba6SpuzWi4QtJBOMtcRg4+4VOr7Z7lZK40l1oqijqgA4xTMLTg9j9l6tP6evd+Ev 8GttXXCLHqehEXhuffHZNmkyay3srazVMNdQyFkNO/8Au2g8YUu2ffDS9fb6StuAa24QsOM92kjB x91TK7W2utVa+kuNNLS1LOXRytLXBeux2G9XtkjrPbK2tbGcPNPC54b9yBwrtNJm1VvXXVWsIa+i f0w0zsMaDwR5UxW3erSddSUlwrehlwjjIB4y0kcj7KlNfR1dBWSU1ZDLBURHD45Glrmn6gr32mxX m7xPfa7dW1rGHpcaeB0gB9uAU2aTTf8Ae+tk1jFX0r/7iF2A0Hgtyplod5NIVVJFdJ3MZXth6Sf8 Q8lv2yqUTUFZFXGklp5mVYf6ZgdGQ/q9unvn6Laf2W1EyToNkujX+xpJM/0U2aTJdN76x2sWXGB5 MEbsBmeOnPIUyUW7mj56dl3c5jbgafpJ46sd+n7ZVJJKGrbW/hnQSirD/TMJYevq/wAvT3z9FsH6 d1BC8MktFzYT2BppAf2whpNNTvlVs1u25MJNM09Bjzx0ZzhTLButox7XXlksba99OGO7dWByG/uV RupjmgndHMx7JWO6XNeCC0+xB7FeuCluMtL68NNUupyS0SNicW5HcZAwip6G+dVHrn+JcupD/dlm eOjOcKYW7laMi9e/U8sYuEtOGvIxlwHIB+qow7rDiDkEHnPC9r6avjpjM+CoZAMZeY3Bv74wqia2 a8tmr91rfW6pdi1QucGjOA0gEt/TKlTd7VWkNS6Ar6NtwaamOPrp8EZ6wOP0VMut4PfkL1ROqZ43 +m2WRrfzFoJA+6nu7a3bNO52cNkbuDb36kf00MZfICDgdYGW5/VWH3s1HpXU2gq2KKuD6ynb6lN0 n/Hxx9chU4Bd1BwP6r0Okm6CC8kdiOeFZ1dpbuarv9lBYXbgUrtSvLKOMOkjIdgCQctyp834u+l9 S6GqTDcGOrqYdcAa7ucjI/ZU6a5zJAWkhwOcr2PqpJGdLpTnyCUxyuN3GcsZl1UkbDNsDtdRyakm dHHC31YCHYHqA5GVM/xD3HTuoNHPqKa5NfW0pzExp/MCeQVUlj3seHA4Oe69LqmeRpa+VzgfBKnj v48rlDyYzySS/CUfh8bY/wC2/r36oMP4dglpz1YBeD5Ur/EjUWW+6VZWUVyY6spXfLG3nraTyPuq nMkkjkDmuwc+F6Zq6eVnQ+YlvkEkqYThlc57q+Wfkkl+EsfDqyyN1u+rvdWad9KwSU3zABzs859+ FKHxKy2e8adprjQ3GN9XSvDfTByHMJyf1VUIppYpA6N2CD3XtnuFRLD6ck5c3/KXEqY4zHK5T3W8 7ykl+Fn/AIe9Y2V+hqjTVyqBTSxuk+ZzgOpr/b68rprRpjQlgiramatbcw9n5ahwPTg5+XHZUzpa maF/Ux5Y7tkEhe110rXR9P4h+DwQHk5XTbnxm9/K4WgNV6cuunrlp81ApIGmVrcvGfTe49ifIyt1 Z3aeoNOy6UjugkgbA4Nme4dRa4nvjjIKo7T1lRBJ1RyljvocFek3auDw78S/q9+o5U2tx5e301pR soNQV9I2UTNhnc0SDs4eCtFGcSZX0rJnzSl8hJcTkk9yvh4S93da9TUWy2F3Atd60q3SN+9OIxxG JhccB7e/7rvKy66d270pI2gmjlkf5D8mR3bLufbj9FRuiqZaV7ZInlj2ngg4K2dXeK2qjDJ6iSRv 1cSpqSaS23dW12715ZtZWWp03dnNhcWFjOcdTc5GPqFu627WDbbSXoUs8c8zmYLgeZHdi488KlFH WVFPK2SGVzJGnIcDgr1198r61oZU1EkrW9upxOFdz5PS2+3WsrJrbTM2nbk9sUjWFgHVjqaDkEfU Lb191s+3GkvwsNQKmZ4JLy7JkeRgk88KlVBcqmknbLTSOjkH+JpIIXsuN/uVbEGVVQ+Ro7dTiU2i 2miNS2XX+kJbBWzNp6iFnQPmwePyuH2K2F1uFp250c+jjn9eedpc5zn9XW4jBP07dlTK23SrophL SzPikHHUw4K9d11Fca6NoramWUNHHUc4WpkzcFttKX+0bi6Jkss1SKWsgYG/nwQW/lcFsL3c7Tt7 pF9F6xmnqGFzup/UXucMOdn9FTK03mst84qKKd8UmMZacZC9d01Jcbo1orql8vTwOo9lN9rpbeyX i1bl6KNvZV/grhTBvZ2C1wGA76gr16iulr0Fo91udOZpJWOOHPySXDk5+6pvab7X2uoMtDUPieRj LXEZC+941Rcrp0muqHylvA6irKuu9reW6423czRTKeirfwdwpi0jDsGN7ex+xC9Gq7pbNE6L/hcl Q+eV7CAXvy4lxyTnHPKpvZdRXG1TOmt9TJA5wweknn7r0XvVdzuwabhUOmLRhuSVN9r37W9jqqLc nRcAtNaaS4UrmuADsOjeODz9RnlfTWFztuj9GG1PqHzyvaQC9wLiSckk+eVTyxaqulmkc+31MkLn jDg08Ffa+6tud6LDX1L5XNGBkq7+0va3Ne+DcnSFLPp+vNNX0zw8BrsOY7sQT44zys9Y3K26R0Wb VNUPnlc3pBeQXE5Byf1VRNPatutie91uqpIev8waeCstRaxuV6e19dO+R7RjJKm9+0mMltnytzdm s3B0vQ1+ma/0K2ncHNHVggkYc0+3GUtZ3a36U0Yy0z1Dppmsa3PAcSCDkqpWmda3ewGT+HVT4myf maDwUtS6zuN6c2Sunc9+MZJWpn9pcfpbm+079cWG2XXSlx9Gqgdng84cMOafqAvnq+60GlNJUdrq qkzzw+mOrABd0uBJIVUdLa+vOnY5GW6rfHHIcuZnIz7r46m1tcL5UCWtlc6TsSSkz77T8f0t5qSC q1faLXdtH3L0pGuw5zeT0O4cCPcey+WrbrQaV0vb7bVVImnpnxEkYBd0uBJI8Kq2k9w73pyN8Nvr JGQvPUWZOM+68uqdb3C/VPr1sxe/yUxs+Wrj9Ldaop7hqektN20hcGxgnokeDn+7dwSR5x7JarvF BpuxWyirqgPmpnxF3TxnpPPHhVW0huZfNN0z4KGqe2nc7q6OrgH3C8Oq9cV9/qzU1krjIeTz3KSy Ell3FutXUl1v0druekayL05W+lMTyPTd54749kasvFvsVrtFNcZ2mWmfG5/T/wAPBVXNHbp33TlE aWjqSacu6gxxPyn6LWat11X3+sdPUyZc45PspjqVrdnpbXWFBdrxU2y46WqYjBURmCZx5Hpu5ycf t+q+uq7rQ2SCxwXCoY2SnkY5/TzgAYJVYdGbuXvTtB+Cp5i+mBy1ruen7fRafV+va2/Vzqid5y45 IB4ytb+2e56Wz1pR3m4XC2Vmm5YX09XEaeZ7hloYeQeMrQb61EFPoNtA+VgqWgHoBzkAYKgvRu8l 70/bm0LZfUpwcsD+S36D6Lm9ea6rNR1T5ZZDh/JA7BTx3hlM9+jyTnhwcTc3A1Dvcla8r7TOLzk8 /VfErN+2mJQAn3KCoEhA7oKAKSaEB5S+ieEsKgR2R3QgEvKaXlQGOUHujyj+qAHKCEDumVRig90Y R4QB5QhCABQhCA+yEimEQD6JpIQMFNYpoBCaSATQhAkJnskgfZHlIIJQBPKChCAHt7I8/RNJAFMd kvujygRQcpozlAk8YQmgR7IBR9+yEAkmkig8FA7J8lBRCIQeEIQATSwjKAQgIVB2QjGUIH2CWCg9 kZ+qDAEnuvrCcPS9Phemmj+YccYXF6LXmlOXBfGpHyr7ScuC+VV+RIxfTyN7od3SCbltzYoQhAIQ hA177QwvrYQf87f6rwBbC0zCCrikdyGuBKC9O30Yj0k8t4wwf0VZdL3WopNfzOZ1PMlS8EdyfmKm rbDXVFVW5sBlY1mAHNccELwU2k9LUev23O310bmzEvkpxwInZ5IySTnP8lqZfpcXK4/vyTPpgzS2 dklVGGnA6Wkc4UW67r7pLuba6SsgEVuYHmmcAP7w4HUT9uF0moNdW+kuNBa7fVwu6wS/Bz0gYwvX fo7PePwFTJUwNuEDgI357BxGRgfZSa1ZTKW2WV0lwfQxWGB1xA9BpjLiTjBzx+i4vTl6F011cYqW VslviqGiIs/Kcey6DVdHb7/YDaTdY4GOLS57RkkNOcfqi1UthsVJTUtvmp2lsjXOdn5j7lZ038t3 XXWlgvrKKYM+dhPLRknPHcKNviWc2Lb13QBgzx4x2xn7L5ayu9LPuVbxS1cb4xARJ0u7HPGV5viI rKSu0NTUNLUxPqpJow2MO5PK9GEmHkn1p5M+Xkw7ncrT/DlUy1MAZK4uEcvSMnsuP+LvpGraBrQB iDP7kqUNpbTbNF6ZNwulwh9QgyPb1YwVXbfDWjNZ6sfVQACnhb6cfuQCeVjwWY8rfmPR5JyuOkbH ukVljCxPHdYdS8oKCjygAjuUI/0QZAdx5Uj7JWqC4awpnVUgZFCQ4+5Kjlp5Uk7J0VTW6vpmUvDW kF7icABSi6GpJaOi0bPLPUPho4mdXW1oyMKuth1NNr3Wlugrqki3W+Uvi6gOo54z9zhTtuHan3bb qutUFTTxzyQ4D3yANGOVVPZ231U+uIYYSwmnfiRwd8vBx3Wpf018uExvO2+lwdVSUdBo+aWepdDS RMDvUA5GOyrpYdSVG4OubZFX1Abb7e8vj6gOpxJxn9gpy3TtFRedt6y10s1O2d0Qy50oDcDk8/oq tbNUNXV66gjpmg+i7Eh6sNHOO6vXDX2Y7vktvwt5rJ9LQaSlmqK00tLC0OEgbzx2CrxpzUtRuHrq 3fxCdsdFbnExZb8zs8Z/kpr3gstXeduam3UEkInDGuJdIAMN5KrBshSVddriBtK35Y/96c4A8d1M pPxyT2vjt/LbfS3GuZKWh0q6eau/DQU7A9r+jOSM4Hfyud2k1XU6ojNSYnPDAWFxOMDK+m9djrL1 t3UUVA+ITxsD3dUgAw0Enlc98NVVTw6XjjdI0SkkEZ85Wta8eP2zjbfLk7G22Cgg1rWXCO7PfUzS AupjHw057Zyo13v1ZqG3aypbdZ6VzJKhnTGWHqdLz7eF3GmNMXqi3Au1zrTEbfPMHw4mBIH28Lpo 6C23LWb7i5kcs1LEI2OIB6Tk5wtcphue9xONz429acfouzs0RYZL/rGtc+vkHqOD35DPIA+qjY2i 4b266/iEjTS2Gjd0NkI+Z4z2C7LXuhNWa71O6KurIaKwxuIZ6bw9xb4PT7rttvtPUejInWOGsdUd LQ4Pe0Bxyfpws3WOOp7pOWWVyvpttJ0NptUUtvs7T007Q17sk5OcEfdaDbWggiuGoatkbRPJWvDn 45OHYW60nbai11Fz/HBrTU1LnxHqB6mkkhajScwst4ulsuGGVE8zp2nqBHS4kgqY9SxrLe9/x9dN UVwjvlTV1tY6SOoqHiOHp4Y0E45Wru221s1BuebzcWNfDSQR9MPTw5+SclbuzWSrtF8r7hcrkJrc Myw5GA0uz1Dv44UG7kbzSwatqGadf1QANiJzw4j2V+bpnDHWt+1lKB9S988TqM01JGA2IHGXe54X I7a2AWQ3h81M2GrnmdK44GSCTg5+y922E9yrtMxVt0Y5ss7Q4Nd3C8miq59JWV1uuziy4OeXHqI/ KSen+SY/6rnP3386ZaLo7pBWmqudcJ21b5OmINx0NB45zyufdthbb1ulU6guMTHwUrGCOnDQA5/J 6j7rotMWa52K4V9XfLkya3xfPA4t6cAjnzxhQhrfemopdX1cen3dVI4tYSCckjjhbvvNjCf6dLLU Uk80dSx1GaaBmGxNdgE+6rxovYmC66ju9z1ix4pxM4x0jXFpdkk9RIU3beVFxrdLRVlyY9s87A8N ceey+eiWVjLPWQXIuFxLnFzHn5sc4WcMtY3H7dM8f25T3pG1s2q2tu3rx0VG5rmZaXmpdhp/dcba 7xerDqU6D0zcKV8TRxUgnpY3z+wX20/tPriqvlcJKs2Shc5zvVJ6y7k4HSCP6pWXYu7PudbWUeqo W1MRPpvZA4mU48nq45Uz1MrMfR4+VxlyTRtvpqvsIqHXO9xXWV+XARsLcfTklb6x1Yrf4q1kMsD/ AFHNJkbjpOFxuylp1Ja6WqGq4pGTNcQxz3Agt912dtcyWku4pZGPklkeWhhyT8uAsujRbcaduFgb Wm53aG5Oe4uZ6QOWj25UTf2Asut9ztRVd/grHxMk6G08RLHA47nH9FI+y1t1Bb6S4O1RTzQzOlcW GVwPy8Y7fqups8MEVHeaigbG+qlkkeHMwXOOOOVrepYxruVC2uPh+04zS9XV6eiq6SsiaZB+JkLh gDJGF3W0top9N7SxzWynYyrfTulc8D5nvx5P3XUUzLlVaAqI7hFJ/EpaaQGN3LuoggBa7QhMmhGW djxDcoITC9kg/I/HkJJOv+2Lb+0enQbLqYJqXUUkU8kkTZsNBxh3cHPlUe3opIKPcu/w0sTIoW1J 6WMGAPsFdzRkV1strrq/WFTEJWEsDhwPTb2P6qjm7lyp7tuBeq2jd1QTVBcw+4Vy+W8Pccb5Vmvg 801JLdq2+yNYIY2+lGT3J84VZR3Vo/g5fXy1ddHh5oIgDnHyhxXG9u86TLuPq1+ibj/E62WI26WM RiLq+frGTnHsoz+HO2m+a6v+rvTZHTzyOEeTzk8nC0fxfx3Ft8oagslFtMQja/Hyl/Jx98L3fB/P XTS3CJweaGEdQOOOorWd605+LctyqVNwdXSaIustwuTonW2ojDI4w75+sD29lHfw1Wg3LVl91WIW spqiRwiz35OThcn8WoubdUwSyRyi3FjWRvIPSXYyQPquh+ECqr6htfE9sn4GH8rsfL1HuF28t1jM Y5eCd3JJ2vdYSaKuNRU3Yxvt1WzogYHfN1BvOR7KPvhisjqvUF81P6LW0873MhcTz3JOP3XEfFW+ 5t1gx07JhQFobC9zSGFwHIB7ZXY/CBVVs9JcYpOs0UP5Dg9PUe/KnmupMT/Hm5c6krV+rn6NudSb wGut9aCKYB3PUGgEEeAtxVwVlx25ZFpt8cVY+JvpOeehoOQTzhVy+I91y/7QmNqhMKFzmNgc4ENP A6sHsrBavfX0e1BdYYpZa2OnjETIWlzieOwCz5tzOT+L4LL4+TYabguVn0XUDU0rJqprXmR0WXgt xx4UJUe6d8vopdNaVoS6rJ9NrmdmtBxk+wCmPbma5VG3hkvkckVc5snqNkBBHHHBWo0hpy2bcaNm utDb5q25VDfUkdHGXyvLuQ0Y8D2WY6NlfLtDonQLhqGsFTWOic1+f8b3DBA+igrYnam51VedUVVT JbKRpcac9PzPB5JIPhe28aS13uJWm819PHTW6OU/7PUvLHhreSekj2Uvbkfj6bQtvhskcpJkgjcy FpJ6PPbwrMeV0zlnxm2p+IKmjqdC0lPI8vjkqIYy7sXZ4yt5V0cukNFWy1aSo4hUSuZE1vblwyXE +/Hda3e6klfo22Niie8RVcDn9LSelo7k/QLoNXVVeLDRXPT1OyvlpiJejqxkdJBx+67TuYf+3n9c /wC1qtYWyPVu2NZFf6KJ9VDHJhuc9EjMgEH9FxWy+11BoO1t1HqYMkusgzCzuIgewH/EVIFXVy2v bOoqr76dPVyxSSvYTwHuycfzUd6f3zbc62ktdPRB8rnNibhueey55T/jn/bvh/vXS/EJQx3jTFnp 5GEwzVsfVgflBB/6roLlTy6R0zbLRpGgYZZXdDIwQOzcuOT9Avpundn2yxUbfSa5lXUMhkc5uQxp IJP0X215WVtHbqC72WlFd+Hc7LGnuHN6QR78lYt3I1Jrbnt0bHT622rlnrqJjrgyIvh/zRyZxwVz uzW11v28oWX7URbLepgGxs7iEHw33J8ldzqCsdY9r3S3UMiqWxB74+rjr6uogLjNP71099utJb6e iDpZZAwZbnH1T4ajY/ENaor3TaXoahpMM1xa1+PDTgH+q6nUFDcNNaVprfoi1te9g6A1hDekAd8r DdG4GmZZaQQteKytjjLyMlmHA5HstLvpqu56WorbNag/+9e8P6QfAGMq4Y8qZZamlXd6bHq1t6F4 1db3076n5GPyHAgeMhWQ+GXTEli26bUT0jYq2sLpmuIHU5pHy8r37uNbctiquqq2NfUOpIpepwyQ 4lpOF6tirpV3DbSnnqs9UXVHHxj5WgAYXLO/tI6Yz9bXHbp36DU+hbhpm4U+NSCVsEcLmgu68ggg /UeVwNH8Mdc+jpprlqWioppWBxhdTlxafIz1DK12k7nUXvfejmr8+q6t+bq7/L2VjNzdb0OkpqJt woo6gVAd0l7QcEeAV01u8Y5XKYyW/Kq24Gw2odKz0RontvFNVPEbZoGdIa49gQScZ91YHZja61be UNJV3gxzagrC1uSP92T/AIWj6e6+2rtwKmjstvuNdYKiC2tmjmEpA6cd2/bK9Wkd1rRrDUFHRU1G x05dlr3DJZ9R7JcdSUmcvp4dzbZR3HeDRzbhFHLCI35EgBbwSR3+y6PcC56ntdyt7NM2yaroXMAl MIGGHq/phfTWNXSz6603aZ6Rkkj3mdsxHLekO+XP1wtJu5rut0nqG1UVGQ2KqYMjtyXY4WMr+3/o wv6uZ+LGhpqvQNDU1Ecf4+KRuHEDrALTke+MqmDh8xV1/ipjbJt1R1Tmj1vVb83uC08KlL+XHC65 a446Y8W+WW31pInTVDI2Auc4gADySr8bY2R+kNo4fwVvEVzEJle1rMPe7OefJ4VD7LO6luME7PzR Pa8fcHK/QGk1LVf9kTb90g1QozMBjyvP3fLji753j4rkh34irjZdW6asdXRRxG7mcxuAaPUwQR0n z38KVtCWh2jNp4DQW8R3FsDZZWMZh73ZGc+5wqaVuoKh+qXV5I6xVCYN8Ah2Vdyr1JUxbTuv2P8A aRRibGPJwteST80kqY5X8O/lB/xH1Vj1PbLFcbZHE65SyFkgY3+8ORgNPvyph0dbv7E7U0klutvp 1jII5Z4o2fM52R1EjycZVMnX6dup467OTFUidrT2yHZV4LxqWen2t/jrWj13UrJMePmxn+q3nrLK SfC42zxdoD+I+KxahNku1kjiNwrPklETf7x5PYEDuc8KbtO0jNC7WW+S22wxzRQxSVEMcfzOJx1k j3xn9lTClv8ANTappq0HJp6kStaeww7OFdfWGqai3bXC+Ma0zS07HEEZA6hz/VdJ++Ux0439Mbdt bbrRpPUmu6PUNHS00tY6lMjngc9WRgn/AIu/K9NRrG7N3CbYv4ZN+DdO2MVHpHp6cAk57e6iT4X5 DX6tu0kuSIoQWgHGMuUoSbi1Ddzf7M+k3o/ECIOx4IyvPc/2yn073GyT+vBrWLSWltyaa+3S3wio np+r1gMESB35vvjhbbR2varVuoZqe1UXXaInYfUuGGgewPk/RaPdjQM2tNd2iCGYwUrYDJUvDuQ3 qI+XOeV7NV6jte2+nIbDp6ISVgb0Mjiblxf7kDyV3ymPWnDG5d7Q38T+nLdHriiksUDTWVjCJ4oR kvlzxwPJCmnYOwXzTejI7XfqOKGEZliIeHElxyQR4XG7CUU141peblqSilFxp4o5YfxMTmOj6y7l odz2HdSXpDUs981pqClkaGQ0DWxNA7E9Z5WePzGt9If0ZtraNSbtahq7iwOo6GoMn4bGGvcXHGfo MZUuMvdi1Fd6vS1RQiSkljdB/eR8PLc9Qz5wAtBtAP8A4eNbf/Pm4/8AE5enTt1pavVVstkcUora GtqnzZYcBrmuwSfrkLvnJllla5bs4yK/612ZrabccWDTpM8NQBKxzhgQsJOQT5xhWW2429s2h7I+ jpI45q58Y/EyOGS884OD2Xzu2qrRpvXtd/FpBE6akh9N2PYuyFu9KXKzXZ1fX2iSWXrc0Sue7IPt hcc5rKOlu8eqgbanay133Wt4utzDXUNvq3dFKBgOfkkE/QeylyoqNLa/fctM1dJDK3o4IaA4Y8g9 wQV9tvmW3+J6okswIp5JmuLSez+k9X814NF3W3XC/wBppqdpbcKOnnjny3B79s+U1u5Wrv1FZ7pt FdmbiTaYtxFR0vDmz4wBGcHqI9wCrVaK26sWlNJPtEdPBVnoJqHysDi95bycHsvgNUWayatvkV0l bDM58bmPI5x0AcLotLVVrr6OtqrZUSTxSPJlc92eceP0UymquNtx2r7sntTa7tdq2+3UNmoqKoey GmI46m89R9x9FKVVbdH7k0F0sTaWnjdTu/u3wsDHN44cMfVe/a+ChhtWo22lznURrZHRl3cZY0kf vleDbWrttXd6T8A5jqiC3iGfpbjpIIwCfJ7pxmrWrf2kk60rHHtPe6rXtXpujaJHU0vTJUgEtYw9 nEfY9lZy3bZ6e07t7WWuKigqZBA8zTSND3GTp5OfHbsvfa9R2Oz37UcNxnjp6x9a49RGHFpY0Dn7 5W9tD7XU2a4z0lTJUUc7numke7PPSA7B+yYTWUrn5L+lUs280nSX/cOgtFa2R1HJK4SBhwekA+fb KtlddKaJDo9MVdnoITU0v93I2FrHuwcfmAznjKiXaCqtdl3kudDTxCphqpDFSyuAJYB82c/r/JdZ 8Td5ht1FbmRs9O4scJoZ2nBaMkFv2TPDf+Rl9Oly14sOkM2Lb2gqN4hpirfK+3sqHscWnDi1rcjl WPvOitCzvdpiostvp5qilDopo4Wsk4OMhwGcjGVDfw2aghqdwKtlyhE9dXR5imcMljm5J/cLufiU vcNvNsZA10V0iPrR1DDhwYcgjP3W7JnleKZ3jjPt6NA7XaX0zpu5XG6UMV0c10gf+Kja/paxxHy8 ccL12bTW3+vbNdaK22Gjo3MaGumhia2SMnkEOxkLbbYV+dpYrjdS6qhkikfLG/kEdRBXv25udgut Fcf7M0EVvLceoY2gZJzgn68Lz+LOeScvjbXl3hlZ8xSDV1oNkvdbQOf1mCVzA/H5gOx/ZaRg6neV 2W5vWdX3P1XAyGd2TjuVyNPgykdl18s4ZWRjx5c8ZaslsbtBb3WiPVGrxDNSyRl8VO/Bj6CMZdkc HP1W+13tHpzVmmTdNAw01DXU4dmGPhkuO7T7H2K6+xBrdg7f6nEf4SHr/wCXrbn+S3ehYLfTyaib Z3RmhdMHs9M5aCYxkD9VJN47ds8ZLlJ8Ii2i2at0NmdfdcxRvZKzqjpnkFjWHsSffK9m4uz1jv8A ppl60BBDTzwsJfTsPyygd/s4KSr36Y2rpfXwIumHrz2x6jc/yX127pKejtt9gouj8MKhzmNY7LW5 jBIH0yV0/HOHJ55nvK4ol2j2ZtkdjkvWuYY5Yp2dUUBeQGM7gkjz3Ruds7aK/T0V90DG1jIo8y0z XFwe0ckjJ7hSreG0x24tLK0gU7jA2TJwOkuwefss9E0VLb7HqSjoXh1FHVTCIB3UA0xg4BWeM1Kv P3ETbU7L21ljmvOu4WPjnZmGnL8dDMAhxIPc88Lzbr7NW91ihv2gYi6mYzM9KHlxLe/U0k9x5CmO 9x08mhbLFW4FM51O2TJwOk8d189JUsNv0tqOjpXF9LBUVDYcu6sN6AQMrVwmtpyu0TbV7KW9tjqL tryP5ZW5hpg8tLG8Hq6geSR4Xi3c2ZpKS0Q37QjJJqFrMz0weXuA/wA7ST+4U4algpp9NWOmrndN LI+JkhLukEFnbP1Xy03RxW7RV5oad7pKenlqGRlx6j0jkDKxxdOkP7Z7IW82SW6a89WMvH93TNeW GMcHJI/NkLWbu7MwWighvWjhJU2wtHqxdXW5v/ED7Kd9UUtPXWSw0ddI5lLUPayUh/QcemeM/fC+ NkpBRbaVdI1xlZCZ42lxz8oecc/ZJj1tbNIg242OoXWOa5a89WESAGOCOQsdFg9z/mzwVo93Nmjp yGO66YdLWWd4HU0nqfGTwDnyCrBatpIbjbrBQ1kr4qapkDJC1/ScekSBn74XmtlMafa6opHyGYQ+ pEHOOSQ2TAWfnRJ7RHt5sZSOsUly1y+WASAOjihlLHRDOCHcclcvu7s7UaUkbcLG6atscuMO/M+I nw4juD4KsjrS3xXSGx26qlkjgne5r/Td0k4jJA/cLx08Tm7VyQTyGYxtMfU7kkCTAK1cT4tRBoHY mll0+blrSompXSBr2RwydJjaeMPGO/bz5XJbu7Q1mkaoVVqM1dZZiBG/HU+Mn/C7HfPgqymvrfHd RaqCqqJYaeZsnV6bukuLWZAXxbG921MbKp5mfHGwFz+SSJAAUuOpKxjlu2fSG9CbC09Xpxty1dW1 VBLJh7IosDoZ7PBGc59iuL3Y2nrtH14fSerW2qcj0Jg3LgT/AIXY8+ys9r62OvH8Pt/4qanZJHI7 MRHLmtyAR5GV55GPn2tt5rHerMwQkvd3LhIBla4dS/Zz70hjQ2wUdw01HcNUXCptk8xDo44w35Wn sHBwyDn6rhtztrLloy8NhYJKygnd/s07W5Lv+Egf4lajX9rkvT6SgZXTUgfDJIHR45c0AjIXzeHV WgLG6sPqz+pTkvcOS7qAypx9Ey70hHRGwJumnIa/UdxntdRO4GKOMNIDCBjqyO+fCj7czbS6aKvI pJg6ppZj/s1Qxv8AvR7Y8O+itlr61z3iWKgpa2SjPoPlaWAEFzTkAhOqBq9H6enrAJahs1O7rcMn qyAT/VSY+m52gfRWwFTddPwV97un8MmncDHEIw/5CBjJz3+ij/cfbu6aJvP4OuzNTyH/AGepY3DZ R9ucH6K2O4dvq7nM2kt9eaIw0zqhoa3Ic5ruB9F6rk0Vdi01U1jGS1LJoHhxHIeRgkfuVePUZx/a 6V+0dsBcrzYoq+43WO2yzEGOAxdeWkAg9We59sLitR7Z3+y6rjsLqcz1U7sUz2nDZh7gnt9lavcW juVdL6FprRSGlpfxQb05DiHdhzx9169QNEtv01WzwevVsmicCMBxJbzgrMm25ig1nw61jaOJ02p6 GnqHsDjDJTEYJHbPXzz9FxG420940Uad88ja+knAAngYQA7/AC4JP7qzO5Glqi/1FJU0d4itksbM dEox1c57g8LbX9jOrTlDURic+sz5yMscQ055Wrj60xh+07Vu0tsFfr3ZY62eugts0hPTT1ETi7Hc HIPkeyjHWuk7rpa7S2+8U7opmdnd2vH+Zp8gq5W4TbxJXdNlqmwCgphVCMtJ6yHYwD44yuc+IW3Q XLb6jraiFhq4y1wkx8wyORn2Vxw5ZTCXumd4Yc76Uwk44IwvmV66yMskePYryFYViAgp+UHugWEk /KWEB3QUI7hAICElQ0k0j3QHhJPyg90CwhP7pDugO6E/5JIBLymUeOUCCCn9kY8lAiMoKeUDsgWO EJ/ZLuiBCaRQCEeEIBMI8JFA01inlAz9Ej3QjygAmj7JeUDCX3TCEC+yPKaQQHgo8I8pn90CHdHZ HlA5QGcppcJoDCEJeUAEY5Qn5QLKSfhLCATRj3R4wgEk/ukgYSQEKhpZT/VLsgEuE0YQbNsPH1X3 hiDckjsF6Ww5Of5L6PaGRP8AHBXllei4uUid1YSq8BoH1RT9kVfOPounyxfTyt5KTu6B3QVtzJCE IBCEIGF9GHGMd8r5hfaBjnvDWjJJwAg2tDc6mmP9w97T7tJC9sd9uLXFzZ5Q4+Q5TBs9szDc6cXT Uw/2YfMIScDHflbw6N0He9YQUtttsUNFSO/vTHI7pmPsRlEqABdqwTesZZPVHPX1crYwaru7Hhwq pi/3zyp+1xspaaq82o2C3NpaF2RUGN5PVnHT3P3W9ue1GgrWyip6i0MNU4tziV2Xgd88qbSRW8a0 vpz/ALXUD65Xzk1feiTiqn6vJVprrtTt7b6OOpqLAwRyEAYmeO/6r4zbM6ErWUktHa+mOR4HyTv5 +h5WtmlTWaguMdX+JbNJ65/xE8pVuoblW1DJqqeSSRn5S49lZPV2wlkdc4J7WySnom/LLAwk9X16 ieFpd49rNLab03bZrbTvpZ5p2xvl9UuJGOeDwrjLldRnKzGbqCblqe7V1H+HnqZTDj8ueCudeTnJ 8q1OntndG3jTHRDFN/EXx8VDp3HDiOD0jhV01vpet0lfp7ZcGEPjOWPxw9meHfqk7a6l1fbQdgsS mEj3UaYnhATIRhAkDumUYQPGVv8ATWoKuxVHrW+ToecZ+q585wtjZLbUXS4QUdEzrnlPS0IOvu+4 9/udI+nkq3+m8YJHBwtNp3UlbYal01FIWPd3PdWG0t8PNkZY4p9TVtU6pkxn0JAxrSfHZRfuntVU aY1VS0Fpcammrj/swc7Lhjv1cKyb7Y3Oo0t33Lv9ypXQSVj+h4wccHC0mmtT1+nat81veGvfjqz5 VhNNfDtZmWanm1JcKz8XKBkQODWtJ8DIUU7m7WVmltW09strjVQVpzSlxy7GcEO+3urJbNr1GtvO 5mobtSOp56stjeMEM4OFpdL6rrtN1T5beQ1z8Zyp+078ONq/g1NLqK6VjKyUAkQFoaCfHIUU7i7X V+l9Yw2ihJq46z5qVxPzFuf8Sn9Hmve5+oLtRvpqmo6Y3jBDDjIWs0rri6adLvwUpDHd25yFOlg+ HG2GzUsuoLrWxVsoBLafpDBnxyFoqL4dK2bWFRRVFeWWdmHMmbgyuafp2ym0+XGT7x6hkjLBO1uf Le6+Nr3avlva5scwPUSSXHkqXmfDxpOeodTQ6guj52O6SA2Pg/suUtfw8Vsurauirq8wWqHDmzt6 TI9pzjjsChdOZfvXqMAhsrB+i19Juzf6etkqzUdckmAepS9H8O2lp5nQ0+pLk+YHBAjjP+igjcXQ ldo/VrrNO5soeQ6CTP5mE4BPsVNkkdMd6dRF/X6oJ8ewWjj3JvQvrro+YvqSA09R4wPCljR/w8Wy 86ejq6q/VTasty9kMbS1v791F+mtsLnqXWdZZrX1upqWZ0clU9uA1oPf2z9Fqbs5T0l1Lxvt6NQ7 uahvFufSTVHpQuGCIyRkKPYqySOqZODl7HB4J9wcqyN4+GmnhtFS613upqrnGzLYXRta0n2VdLjZ 62guUlvqoHsqmP6DHjJJ7ce6nellnpJ9HvjqCmoW08ZYGtGAclc9Sbm3mnvkl1dMX1D+CCeMKQdA fDnW3ixOuWoa6S3F7eqKBjAXY/4srgNHbYXXVmrJ7Tbs/hqeUtlq3NwGtB7/AH+id62bm9PbqjeL UF9tjqOSUxRPGHdJPKjqmrpIa6KoHL43h4z7g5Vh9TfDQ6js1XUWO9SV1fA3qbTPhDQ73GcqvE9u qoK91FLBI2pa7o9Lp56s4xhO13Ev0u/V+p6NsEbQ0NbgfMRheK07132iqp6gHrllOXEuK6PR3w5X G66dNyvVwNtkMZkjpxEHkjGeTnhaLbLY266xdUVFVUi22yJzmtnczrdIQfDcjj6pKdPtct+tRVFL JBGRE54ILg455Ws0nvHetPtexpMwJyOpxBCkE/DHT1EcpotViaVrSWsFKOSBwM9XCrxqOx1tgvNV bLjH6dVTv6XtTdNRL9y3/v1TRyQQ5iMgLS4OJK1ek96bzYGPjaPVyeCXHIUQiMjuFL21WyF31zQG 41FSLXbTn05nx9ZeR7NyOPqps4trdviAv9ZRyQRZjL2lpd1E8Fa/SW9l4sMD48eqD2JdghdfU/DD N+GnkodTw1UsbCWxilx1OA4GerjlV6vVqq7Rc6m310Riqqd5ZIz2IV3TjE2N+Ia9sfLJ0ZkeMA9W elczprd68We91dwLnTGpeZHtLv8AEfKinodld3tftletwLg6K3NEFJH/AL6qkaSxn0+pSVOMjodw N6r1qmgNG4ughP5mtcTlRFNIZHlx7lSzu5s9Jt9Z4a6S+UlcZJRGYWR9D28d8ZPCiJS7+Wpr4Cl/ avd+r0NZDb6Wla8F5cXg4Jz7qIFv9G6YuerL3BbLNAZqmU/91o8uJ9gortd1t17hrylp6WrZ0QQv 9QMzn5sYytltTu/UaHsrrfBTBwLi4uHBOfdbu/8Aw06ittknrKa40VbUQs6jTMYQ530B91EmmNIX bUWoorNbaVz657ulzXDAjA7l3sAtauts7m9Ow3a3Tr9exUsVVGI6encXsb9SMZW32s3lm0Tp8W2C jDh1l7njucr36k+G/UtpstRXU9ZR18sLeo08LXBzh5xlRTpTSV11PqCKz2qmc+re7DgRgRjPJd7A J37Jr07HdzdKr1+KOOpYI4KVxcxv1IwSt7tXvO/RWnW2uKjBAcXF7f8AFn3Rqj4ctVWWzVFfFUUV wdAOow03UXkecAgdlGOkdJ3bVF9itVnpnS1TzhwIIEYzyXHwAosk07PdndKs11U0LpI/SjpCXRjz krttHfEJV2iyw0dZA6WVgx157j9VoNW/DzqywWia4CShuDYRl0VKXF+PJwQOy82jdg9V6lssV0aa OhgkPyMq3Oa4j3wAeEttSadZqr4g6u6200kEToWvI6znuPZbej+JL0aSGH8GR6bQ3jHgKP8AV2wW rNPWWW5E0VfDFy5lG9z3geTgtHb7rHSWwertR2OK6RCio4pT8kdW9zHlvh2A08FXaajv7p8SL6i3 zww0rmySNLQ7AwMr4ae+Ip9vtUdNUU7pZWDHUuB1psVq3S9lfcpm0dZCw/Oyje57mj3x0jhcJovS 9y1bfYLTaWRmpmyQZHYaAPJKdmpU6Xb4hn1lgrKIUpM87XDqOCB1LWbd771OnaA0ddGZ4x+Q5zgL itw9n9R6FtMVwvD6J8Mknpj0JC4g485AXl282m1NrqlnqrPTxMpYj0iaocWNefZpwc4Td12kxx30 3m7W79frRzYI3GGiaPyA4yud2n1pFo7Vkd2nh9boYWjIzgnyvFuJt5ftCV0NNfaZjfVb1RyxHrjd 9OrHf6Lm7Na6u63GCit8D56qZwayNgySVLW5IshrX4g4L1pust8FN0vqGdHUQOPr9149u9/X2S0C jujXT9HDHd+FF2vtrNSaHttHW3yGnZBVPMbDHJ1EHGeR4T0HtPqrWtDLWWWiZ+FYcCWd/QHn/h90 2adDu5u7WayeIoXOho29mdlqNmNcwaN1O65VcQmBjLG5GS0nyuc1zom96NuDaK/Uvoyub1Nc09TH fY+609jtNbeLnBQWynfPVzuDWMaMnP8A0UVZbWnxA0t1s7qalpg2Yua5jyOWkEHI/ZbS2fEXQGhg bXU3VOxuHPIB5Vfdb7caj0X+E/j1LHH+KJbEIpA8kj6BdFadidd3O3QVlPa4mxzND2iSoax2D7g8 ha7ntOr27Hdne9up7R/C6BnRTSf73x1fTC6zSnxA2e26doaE0vQYIWx4a3A4GFXrXW3mpdF+i7UF B+HZLkMexwe0/qF5dDaLvuta+WjsFL+ImiZ1v6nhgA+5Uv8AVjotQ689Xc2XU9sYInesJWtHA4GF PFJ8Q1lqaGAV1I2SUNHUJGA8+VWXXWh79ousip7/AEYp5ZW9bOl4cCO3cI0Poq/60qZ6fT9EaqSB odJlwaGg9u6WWJNWdJV3t3ij1ba47XbGenScF/gZHZabYLcO26IuddPcoBI6drWsfjJbhcHrHQ9/ 0jc4KC+ULoKmdnXE1pD+sE44x9V09Nsdr2elhnhsT3RytD2kSsHBGe2cpu+qcZ8Jh1vvvaq38BPb IQKummD2yY5aMEEZ+uVvWb96arIInVtLHLKGgOL2Zwqu6o0VqDS9xhoL1b5YKmZodGwfN1Z44I8r o4Nl9ey0rJ4bBPJG8Bw6Xtzg/TKm006zfnd2HV9DFb7czppG4cR9VAROTn3W+1dpq76YrxRX2ilo 6osEgZJ5afOVz6u1k099kniprtSTTtD4WStc9p7OaCCQrjw75aSksX4J1PG2n9L0/Rx8uMdsKlS6 jSmjNR6ojlfYLVU1zYsB5jHAz91NTfL5LNzV9M3V1CNX/jDEDbxWCUxnkdHVnH7K2Tt79IS2R1GY GGmMRZ6JA6cY7YVOb9ZblYbnJQXikmo6yPBdFKMEA+fqttpnRmpNSUz57FaKytha7pL4mZAKXu7W TU1PR0VbbodYQVU0fVbm1YkdGexZ1Zx+ytlVb16MqbDLRGJjqUxFggI+XGOBhU2vdouFmuUtDdKW WlrIjh8UgwQtvp7RupNQUTqmy2itradrugvhjLgD7Js/j6WWut9NrGiqayMSW+OqD3sPILA7OFa6 87v6JuGnZ7fJGx9MYixsJxgccYCppc7dWWyvmo6+CSnqoXdMkUjSHNPsQtxY9J6ivlA6rtFprq2n a8xl8ERcOoeOFZdXaWbmq7rZ3cGLRWr5Z3tJoan+7efZoPBU+P3I25fe2Xk0lMbm09QqsDrz91Tc 2uvZc3W99LOK8SekaboPWH/5envldCNBaxYPm05dxnwaZ2VnU3b9tbqzts3rsc2s6uepk6KQQCKJ 3b/FlbF+4G3brwy6GnpzcGv621GcODsYzn7KmzbbcX3E0DKSoNd1mM04YfUDvbp75W1k0fquOPMl gu7B7upHj/Ra2zpaSs3k0/Ta7hqoJA6lmpWwTO9i1xI5/VbCLc3RNpuRq7Y2JkldLmqeDyRjg/uq WVDJ4JnxVDXxysOHNcCC0jwQey2dHZL7WUIrKW2XCelOQJ44HOYcd/mxhXfwmlgr5udatObltuum uaGqjH4yPOQ92TyP0KkafdfR8ENVd6N8f8RlhAd2y7HYFUlPqh5a4EOBxgjnPsthUWa8QUb6mpt9 bFSs/NK+B7WDPu4jCtvfZqadRuHrip1TfZayV5wCQ3nsFYTZTXGj7NomihMogrnsH4rLs9Th5VPS SD25Xut9HcKtkjqGlnnbGMvdFGXBv3wOFLeV7JjJNLKt3MtWj9yas2eUyWSuLXyszkMee5CkOv3M 0haaC43K1yRGqn/vXAY+Z+MZ++FSEGV7h/iJOBjvleiohq4A4VEU8YHBD2Ob/VNkx+HV641lVajv s9dM7lx4+w7Kzm0msdH2rQlvpYaoRySRB1QHOyTIR8ypW4kv+q9EMkzW/wB254APjOFLd3tZNTUW f03uRbdHa7uVtgnM2n6qfraSc9BcBld9Xa80hpe1V9XZHwmaokMzmM8uIAJ+nYKkfrSSHklx8e+V 9JZqhrAJHPGewcCP6puE26vWGranUGoKq4SvIdK7JwcK1G3990bb9C01upq/EVRD1TNkk6ndTmgO 5VIPUfnuvZDUzxM6RI9jfbkBJe9pcdzSxG2jdL2zda7zVtc5sNG7NA8uwDk859+Dhbf4mKyx3zT1 HX2+uZLW07xH0g8OYcn+RVX/AMVKJOrrII85OV9JauWePpdO5w9i4layy5ZXL5ak/WY31EzfDRLY qbVdXcLzV/h6imjaaXLsAk5Dvvwuz+JmazXa10N0t9c2WrjeIXMaeCw5Of3VX4ZZIpCWOLSPIK+8 lXNK3pkmLs9gXErMuu4ZftrfwtdslrKw3Tbs6bulQKaSCN0T8nBc0knI/ddTpVmk9A226TW26yVI nAkc2Z7SeBgAYA4VJIKuaBxMbyx3uCQvZ/FKhzMGocSeCOsrnhhMJqejK3K21tdwLhDctTXCqpzl kkznArlo3dLslZTPLn5K+TjwuuV5W2pjjxkk+FstidxbXetLN0pqH04/ThMTHO/K9mP6rtbvqLTu 3ulDDanxSSOb05B5ecYyfqqRUM8kDw5jy1w7EHC2FTc6uoi6ZpnyAdupxIU3qaa7u6tlttr+y6vs M2m746OMhhYzqOA5vgj6hbq8agsW3Wk20dskilkc3BcDy93YuP1VLqapnheJInljgeCDjC9NbdKy pjDZqh8gHYF2UmUZ0tnt7rGx640tNp29GOKWNnQMnGQOzh9Qtper5YtvdJGgoZWTSSMOSD+dxGCT 7KmVFXVNNIJKeZ0bx2Idgr1Vl5rawNbU1D5Q3t1OJwryTjFtNEaqsm4Gj5rFc5W09TFGGDLsHj8r h9QvfqG92bQGkzQUcrZZJmkvJdnqcRgu+mcKm1HX1VLMJaaV0cg/xNJBX3uN5r6xjW1U75AO3U4l Xmn44tzpbUll3I0ZLaKyobT1cDA3PVggj8rgvZqa82fQOkf4bSSCR80Zzl/V1FwwTn7qmttulZQT etSzPik7ZY4jIXput/uFwY38ZM+Tp4HU4lJZvbWlurFerRuZoo291V+Dr6cN5DsFjh2cPoV6dW32 16J0h/DIpBI97Dw6TrznknP3VN7Te6+3TerRTSROxgljiMhem76kuFy6fxk75CBgdR7JL2WWrd2+ 52rc/RTaeKr/AAdfTFrsh/SY3jz9iMj9V9tY3u06O0gLTHMZXvYQOp/UeTknPnlU6tN/uFrmc+hq JInOGHdBIyPqvtedTXC4gGsqHykDDeop0Lf/AIq3boaNhFFXGkr6ZzXZa/pMbxwf0Iylre+WrSGk haI5TKXMwOp2T3znPnlVAsWpLlaXufQ1MkLnjDukkZX0vuqLjdi01075S0YBJ8KzKT2ll+FvqqWj 3M0nTVFmrjTV9M4OAD8FjuzgT9s8o1zfLbpXR4tLZXSvDQ0dTsk4cDyfPZVCsOqrpZ3Pdb6mSLr4 cGk4Kd+1VcrsQ6tqXSOHHJU39kxk7i310ZDuPpigrtP15grKd4d0h+CM8OaT44zgr565vdt0tpSC zvmdLJGGNGSM/KQef2VStO6xutjL20FW+Jr/AMwaeClqHVtwvDw+snfI/tkq4561tLh9LfXiBuv7 DbLnpy4OhnheC4MeAQ08Pbn3wvhrO92/SmnKK1vnM81M6MgnAJ6XA8qp+m9b3ewNkZQVT445OXMB 4z7r4ai1dcbzP61ZMXvxhJlo4Lh3ymk1tarXdtL3J0D2uw8sIyGO4cD9QF59Y3u36XsVvt1TUGom pXxOLuAT0nPPsqpaU19eLBDJFQVUjInnJZnjPvheXUmsbheqn1quZzpPJTGye2tLfajoqjV9Nart pa4+mxxEczmO59N35vuR7FYaxvtu07arbQ1VR6ktK+JxI4J6T5CqtpXca9aep3wUFVI2F56izqOA fdeHU2s7he6p01VIXyO78qzLXtMZxu4t5qqhr9TC1XPS1e1sUg9Gcg5Hpu5zgd8HwvRqC50NBPYL ZVVLBPHNGCc4HAwqo6R3OvenqM0tJVPEBd1BhJwCvDqTXFfeq81VVKS/Ocg+Vma21uxZveOx6hul fQVGnqeWdjGYeYngHOeO/cLo9U10Vntdhqbk4sNNLG6QdyPlwT/NVqtW9eoaWhip31ReImhrSSck DstVq7dG56hhY2reCWjHynuFq5bs38M4y4zU+VotZ2273evtlZpqqiFNVRmCoeW9Q9M5cD+/C5/f WtpoNEtt0kzTUsaCQD7DCgnSW8F60/b/AMDFMX0wOWtcc9P0H0XNa31zWahqXyzPOH9wDwpheOXJ c5zx4uOuJ/vnc8ErXuX3meXOJPlfErCsQkUyjuEGPYoTATTYxQUFCASCeEigaPCSAgEIQVdgKPKP KCmwj3Qgp+ECQjyhAFGUFGEAe6D7oCEAjKEcImi7oTR5QL9UFNL3QMI7lJACAQgoQCEIQHlARhPy gDwhCXlAITwMpHugEIQVdABJTSQmgIymkUAhAygfZNA7IyjuUJoCEIymgIyjshNAKSaSaBk4JQPK EeUAjKD3R3KAOcZQgpfqg7MM7A8BfKsb/s8mDghp5Xq8Ly3A4pJ+ezCV4p7e3L046AcD6pVvdOnx kEZWNWfm+69E9vNfTztQUN7pHutMEhCEAmkmgPC3WmGepeKNp5/vW/1WmA5W1sNUKS4wTHsx4cQg vNplvp6Lnxx/cP8A/KVWLbS7VcGqQ2MOe6V5yPflTbt9rmhrLayGolZ6Dm4c0n3GCvBY9PaPtuuJ LhbKwOgecuhIw2I5yenycq76052fttNVk9f+Fwuqx0ydIwM5wFE2o6m6ybrNiuUYZSNjP4Ygg9Tc 910N71/RG+09ut9VGYmN6nOAxg+y997ksd1rbfUGugFczpaZAMkN/wAQWbOtNy9yukvlTb6Khop7 o5rYY3MLXOdgNI8/zXFaBvIvOq7hNE8vo21r/Rf/AIXDPcLd6yoLNqegp6Oquwihic1x6G8ux4Xp oqiw2uCgo7dUQMgpznDePC3MZMZr2xLlcra2891gZfXUNQGgGNrm5x3KiX4qX9Okbd0+aoEY+xXr vd9o63dFv4WsjfTMpmNcQeA7JytZ8RtVR3qz2a22+rhfVOnz0B3ZuMZK6eG8ct/xy88uUkfX4c55 Kq0RmYlxaXDn6KJfipI/7Rhj/wCVYx/VTjoNtj2+0X+JrK+OSZrOpwBxz9FVvdbVb9YarqLkWhse BHGAP8Izhc/D+mOW/lvyS5+TGz4cWViVkSFj9VHYkDKO/KAgAEJowgyaMlSx8P8Abaar1ZHPVvLG wkYA7nPdRQzupa2BoZ67VUJhLWQsPzOccDJ8KUi2W4NbQWvSMlVVzSxU0TQ5pbjJdj5VAWhL7Lrn XtLVXipcYKEYhj84KmHeq1fxrb+egpq2likjaJHOkkwMNBOFXPYW31NbrBkkbmMjiHTI4uwMnst+ TvwzXtw8P/y5b9RaTcquorVpJ1ZVVEsMELQ5hYBlxAOAoK0FfJdd68p628VHTDRN6ImY5wVLG+tp kvO309HR1dKx8LPUcXygAhoJIVe9gqKqr9Xskg6Wwsbh7nOwMnstXrw469p4f/lz362tDufcKK0a VbWVNRJAyAdUZaMlzsHAKhDb69Sa817T3O7T4ZRs9OJmMnBUnfEBZ5bzt8+CkqIGPpwJn9UgAIaD kD6qAvh7oaut1W18GGwsb87nOwM+yZSfhx17PFb+XPa0G6NdS2jSgrZqp8AgHVFgZ6nY4BWu2k1D V6jtgrpYwSWta55OOAfC1vxDWqou+gOijlgBpXCaQPlAy1o5A+q+Pw/1lMzRVPCJGmXoAxkd0yn/ ABY6THf5M7f/AE6jTtltNDqOurKW5VVTVzTOc+J2OhjiTkDj/VRNu3qHVMm4TbHZKX0554m9AjcX EtyeT7KStD6ZuNn1FdK641FMaaeZ0kWJskAnyPC3top7fU6luF1jbFJOI2RMlOMgDOQE3JuFltlr lbBR0e2Ok33DUVX69ykHW8ud59go203pat3d1rLqS9j0LNBhkTRwZADkD7LqNRbbai1xqiSXVF0h prMwkRR00gc8jweeB/NSJoe00OmKaSyUlQZWxNb0ueRk/fHCzZNcYuO/9mw00y1wUU9LZow2nhw3 qBJyVzu0tJDT2e4zQsa18sznuIHJOSttoe2VNmt01LXmITSSOczpeHZGSVqtB1LLPJVWWucxlUHd XyuBGHEkLUkksn2llt3fen00JbqyjnZPWV7ql1U+R3QRgMA7eVr6Hbu21m49fqOuibPJAGthiI4B xnP3W007aJNKvuFwvFzEtCwl8RdgdIPfyoE1bvHWy6uqW2E/7NI8MAB5ce3C1bvl/WcMNcf4tLSP rZoKo1VOIGYxEzqBOMeVy+3VjNhsVfE6FsVV1ue/GM9Rye/7LYaIFfJpJs1e0tqpourp6skEjstb oStFLFV2i4ODLgHEv+YHk9lylutO1nbLQtBW0csUlfXmqfVNdIWdGAzHjOee60tr22ttRuPddVV0 YnljcBTwdIw0gd/ut3py1TaUjr6++XISU8bnem54xhnf3UBaj3lr36sq47G4/hZpQGNHJce3C6S7 mTOtXFaKN9ZV22s9em/DvcHNjjJBOMeVWLT971SzUcujm1EdtMbiJpCc+m0nvwrF6X/iMujWyVTX NrpYS4AnkOI4/moJtOzN3utVcLpV399FfC95MEcYfk+AXZHdMbJhZWcpec0mPbvTrtPwVAdeP4q8 5cP7vpI+ncqLaDQtm1fuLqOt1Ba6ipd63SIA/pDcDyR5UhbN2S+2K0TjU7S2cEnqLw4dP6LorWWO tN3da3RvqppJZGFp5LiPlWMbdabv2ifX2xulpNJ1lRZ7c611kLHSB7nueSAM4xnHKi3RGu9W3Gmp NL6dizKWiNvRnDR2yfYK0UdJcqrQlRR1rCLpLTvBjc7JyRgcrm9p9ERaJ0jPUU9E2W+yBxkLsZLh 2aD4C1ZLhJPe2McrM8rfWnojq6Xa/RQkvlcau5OaXOJPL3nwB7LiNI7Q2rVz7hqzVkL6ma5SGWOm ieWhjfHbuSvLcdsdZbh3iet1TWNtVOwj0oQ31cjPYAEAKXqWnqbfoaoorSfXrqaJ0cQHBc4DA+yX GbmKzLrlXBVOwejK2hnjo7TU0VR0n05ZJXHB98ZXZaT023T+35tVnkjpZmNcz8QW4Af/AJiubsVP uDcqWoddqiOzRMHDn5eSPJ4PC6atgrKnbitprbIKm4GF7WuYcdbvf9VMZrOQ8l3hUKa/2U1He6Gp r3akguksQLxAIiCT7A9WFVy4UktDWS01SwslicWuafBCv/tTR3e16PlOqI3QVWSXeoezfCo5uI5j tZ3d0bg5hqHkEdjyV0ykywuV9ys+O8c5hPWnNAZOFa74OtOPjjr75L0Bsn91ED+YgdyqpDurbfB9 +PkoK0yMf+BjPTG4jjJ74Xneq+kgbla0foW4VFZWSxS01UzpigB+ZrgPI9lx3wvWd1VcL1qaVsbW 1chETf8AFjJz+nK4D4rKW5xauZVzxytt8oDYnn8pcBzhdx8IbrhLa64ztf8AgoyGxOI4J84Xo8+X GTCPL4JynOu03F1tJoW41c1fJFNS1jMQRNd8zXAYOR7LlfhbsJ6rvqOQMArZCIh/i6cn/UqNvilp bpBrU1FTHK2hlwIHn8pIAyApG+EV1wlsdYagP/BRnphcRwffCee8dYw/xpvHlfbr9wtcv0LXVjrm +OanrGu9CNp+YHGMELmfhZ086GnumoJGsArZCIh3cG5/pyoq+J+O5w67lfVxytopceg5w+V2AM4U qfCPJXzaarHVLX/g2O6IXEcHycLn/kY9yR0/xsrcLa6/Wes3aPutVTXN0UtPX59BrXctzwQ4Le6j orlc9CQU+mZ4qeqLY+l8pLG9I78qt++Lbh/2uwMro5W0ktRH6BcD0ubkA4Vgd0HXaLb+H+zUU81Y 0xhjIAXOIHfstzH95I5zLfjuV+2xpmVVh28mF6lbU1UcLzI+DLwSQVDFp3F1LrOqptP6bp+gx4Ek w7RsHGSfCl6wNrpNrcXtr4a6SmeJWyjDgSCOcrxWeyU22+heuwWuasr5QC/02dcj3uHc45wFi94y T7bssytvp8twL5R6Q0FJbrlU/ia2aAxkE8ucRgn7KLthdp6ula/VF5qJrcxwzTRt4cW9yXAjsUVG gNa6ruEepb4IIKWOYSOpZ3OEvQ0g/lxj+al7c+GuksdlitEUsjTVxCRsLScRjvnHhayksmETG3He V+Wn3+oIblp+zUc56opq6KMn3ByF0N/p6mxWC02XSsEELpXem1p+VrWtbkn+S1u88EjrbYXsjcY4 LjFJK4DIY0ZyStzrmSvks1Nc9Oxx1c0GS1h56g4dPH7qe5iTc5aabcK0R6t2qqBdKWOSsbEXRg8+ nIDjIK5/aTbe27bWxl2usYnvdThoIGfTB/wt9vqus1PXf2d2zLrvJHHWCHLgD3fnJAXBaV3tm1Ff aO10lIXSSyBpIbnA8lS/66dMf9q6XfqzNvtLpqllgdLTOuLBLgcNaeOfYeFv9UNrbFarXadKUcIy 4j089LWsYMnlPdC5zUEFoibGTS1FYxtRJ05EbQ4EEnxyvrr+qudPQ0lzsFO2se3qjLe/D8AEDzys xcrdac3u9YoNZ7VGeopI33L02Opye7JHEDv+q8O1W3Np2ytsFdXs9e+VXSwuxktJ4LW/RdLre5M0 ztvE64PjbUQtiPRnhzmuBIC5DSG8p1Rf6S3U1IC97wCejPSPJ+imvldvN8SFULXcdMXaSm9eGknL 3ZbkDkYyvpSas1lrygjrdIUEbKONxY6R8wZlw7jHdbD4kHXCu09S2K2UnrvuUgj6sflORjnwoptN PuFtjBTWmWic+lmkL2mma6XGTzyF28neON/jl4rrl/2lff2nNRtIaS4Brri9sYa0ckyecLm/h42w ummII73cK38G+rLQaUtyXM/w5PglSveIPx9jsX4yPrkdUU5f1jkHPK1urq2rZuJpWgh6xRyOdJIA Ply3sueX7ST6bxvH/wBod+L2lfVXOysijdJIY3ANaMk/N2XR/DrtndtJ0sd3uVW2lfWkddGW5Jb3 bz4K6fXtIyr3e0lFPEHQmN7suHGQSVudSXCrZudpu3M6hRPifK4AfL1DOFryXlZPqOfgnGX/ALaD XdNSVG9elPxrWFjaZ7gX9s5K3uv5tWw3mgGl6M1FvLAJi14aGnq9vson+Kiuq7Vqay1tIXRuZAem Qds9ROF4NEbpayv1zobXBSSuklIAJBaC3ycnxhZzx1qt+LO2WVP+paOlnuWnJK+KJ0kdRkOeASD6 bs8rUa4qdWwaioG6boTPa3xt9V7XAdJ6jnjPsuhvIa676fjlIMglc4tzzxG7n91wO6Gtrlp7Xlot lCSaerbEHNH+Z0hb/RZdHNfGBSU82irbM5kf42OoGHYHV0lpz+ipke5V1vi7iadCW+XAEgqcZ8kd JVKj+YqK9Fvpn1dXDBC0vkleGNaPJJwAv0D0naKrSe1VJDbqENuUUDHPjjADnOyM59+Mqgun6qSj u9JUw/7yGVsjfuCCF+gFyv1ZBtE68gObWfg2yYxzk4/6rFnLORu3XiukI/ERcrTrCk0+63RRuukk ha5oaPUyeA0+e6mzT9uqNIbXUUVvoeiup4Y3SRRtGScjq7dzjKpHDfqlmqYrgDmSKoErQe2Q7Ku7 qjUdVRbSm9t4qnUrHn7uxn+q7bnkzmMc+8PFag34iqi0arNgqbOyOS41BLXtjb87ieAD5zlThboJ NE7ZW3+G28smgihM8MTPmPbrJA84yqS22/VNNqumuDDl8NQJWNPYEHKuxrjUtVbtqReWYE8tPGXH GcdQ5/qtz9s5i5W3HDaC/iJFo1RdrFV2KKOWuq4+mQRNy97ieAcdyp3pWu0Tt1av4bby0U8cRqIY o/mxj5yQPKpZYNRVFv1dQ3CI5dT1AewHkd//AH1czcvUtVa9t23SED1Z4mB/HbqacphrPyTGRny2 +Px8rWFjpdMX3cBl7oKakkrHUTZHSNYOoOLuCfrjyvRDqa/u3AdaZLXUNtfqloqjGQwgDPdRP8Kb jWX6+TSku9OJnRk/lySpJotwamfdV+mC1vptle3OOcAZXHL3Y9eU1r/p4tY1mltHbksvFwoYG1VR RgiVrQCHhxHV9yOFtNvdb3HWd5qZKOlLbHC5zfxEjcB59m+/1Wl3I27brfci3slndBQQ0Ylqgw4c /wCcgAffHP0X31xq6j0faotNaQpvWr+n0mQU7clpxzwPPldLJ1pwmWV3tDfxJaboqvcaki05TsfW VcYbLFAOTJ1HkgfTHKnnZnT980zoyOz36OnDIG/3Rif1ZBOeeFw3w926pn1FfrlqKhlju0bY+g1M Za9gcXZIB7ZUiaFv9Tfb9qIVHDKZzYWtHGMFymtdxnLPq4/OkS7Ybc2m97j3u7XGNs0FBUFzKct+ UvJOCftjKlamv9t1Rda3Ttdb3Pt88bo2erGeiXpz1AHzhaPZMNF11d0/m/FDP7vXs0peIbjqK3W1 kE4qbdLUesTGelocHYyfrkLpld3K2fLnh1jhN/Cveo9lq5+5kth0+1zqFzhJ6rxgQsPJGfJHOFaL Q+jLLo2wOtlqhYXsZioeeXSOI7u+pWouGsbRpjWV1iuzvTMscLoyfI6SCui0fdbReKWtrLM0+mXj 1XFxPUcf9Fz8mpl6dcLeHtB2y22loumorpfbg31IqKreIqfHyh3cO/RSqa2wbii6aduVIJYQ3qZ1 NwekcdQPuD5WW2Qt726llszOikkq3EM9ndAz/NePQV1ornfLfBSscKqgopKepJbgh3UPl/1/VZ77 detdVW6fZm7T7jVenLbmSmgl5q3DAbHwc48nB7K1OldFWTS+iqiyUMEMzGROFQXNB9R5bySD5K1j NYWfT+pdQU10lMU0lQHNcPLehoXSaVrLTX2etqrY+WSmke4yvkdkuOOefsrrVZt+kHbCbZWqd9Xq a5hszKaoeyCHBAjLec/VeLfvWlrvWn6mz09vjaGSh8MojDcY8qX9rXUVHpy/SWsF1Cyumkia7n5e hpx++V8NE6ntevDc7XPbaYQMixIz0xhzXEha9buk/wBvSo+0mnINR6+tdvr4XSUb5MytBI+XHk/d XJvFNpqlmh0tX0NIymrKTpb1MA6ucYz74CiHa9lFovem62WjgBp6qU08XVyYw35uD+q33xQXllDb qCmZGBWBwninBw5uCQRlc8Mb+WytebLXjx4z2iPTehLbU71fwF7Hy2uOpf8AKHf4QMtyfbOFZi/W vSstS7S9wt9FG2rpMtf6bWudg4/NjORhQP8ADPqNo1/UU9VEJqi4R4bK7lzS3JPK7f4nr7HQtt8E UYZXR4mjnHDgMkEfZdNTPO8fR5Mrh48cb7qJ9E6CttfvP/Zyu9SW3RSynAdgkNBLQT+yshf7Do65 VVVpW4WuhikmpQ5kjYmskI92uxkEYUM/DFqGOTXNZT1kTJqyuj6mTuGXNLQScH6rp/iY1DHQVVBF TM9G4wH1RUN4d0kEYz7LUk8mV1OnHLK4SS3tFe22grfc93m2G59c9DBJKSM4L+gEtz9OysXetLaK vNTcdMVVnoaapfAHNljiayTtnLXYyCCFFXwvX6CbVtxpquBktfWD1Y6hzQXN6QeoA/Vbn4kNRx22 40goG+jdKc9RnbwSxw7FTHGeTLLUTLLLDjLVZtTWs2m81dF1dfoSujDvcA4ytUB1OwvXcq2Suq5J 5nF8j3dTifJXnhGZMe4XG16YtHsjtLaLdp2LU+r209UKiL1IoZWh0TI3DjII/N9fqtnr/avT2tdN NvWh4Kagr4AcxRNDY5QMktcB2PsV2ET4I9jrK6qx+HFNSmTPbp6m5z+i22hI6COn1CbQYvwT6pzm CHHQMxjOMeMrVnUuk61e0W7S7Q2e22H+P61igqXTM6mQS4dFGw9icj8y+25W1Vj1TpiO+6FgpqWp gYeuGIBrJWjkg47OHupEu4pm7b2h1cGmla+nMocOC3rGc/RfbRUFHHZ9Sx270/wRq5TEI/yhpYDg fRdJhOPJz5W3SK9qdn7Nb9NSXrXdNDUOqGB0cL3fLGzAIPH+Ipbm7R2a86dgv2goIYPRj/vKeP8A K9o5J+4Uo3oUf/Z/Zhcgz8IXU4kD+xbnlYaMpqaj0zqWmoSDRx1U4iAdkBpYDgH25S4zScrMtVGe 2Ozlot1glu2vIIqh07Q6KAvPTGzAIORjkrx7r7P2yexw3/QcQFOxgM1K1xILf8zST3HkKYdTR0b9 L2KK5BpozJC2UOOBjpxyvlpWlp6TRl8paQ9VJDPUti5z8uMgJwmpW/lF22mzFqt1iluuvI45pJmg x05cQI29weoHkkLWbubN0MVpi1BoSIvoegGela8uOP8AOwk/uFNmpYaOey2CC6dP4KSVjZep3SDm M4BP3wvhY6WGi28uVJTPMlPC+obESc/KHHHK5zu6aupdIt282VtNvsMl0120SSSDLKcPLREPuD8x IWm3e2Zp6Gkivmi2mW3PaPVp2u6unPZzSfHupt1jBSVdp07TXN4ZRTShsvU/oBHpHHP3wvjaqdtJ thU07HukjiMrGFxyS0SkDn7LXHUlTe7Z9Iu2/wBkbTR6fkuWvWv9SQdTYGSFnpDPkg/MT3XPbvbM iytZeNKNfVWeXpDoQ7qdGTgAg+QVPutqWmrqewUde8so55S2Q9XTkek4jn74XmooHU211RTOeXiE Oja53JLRJgfyWbNaMbvf8RdoTY+00unHXDXfqtnkw4RRTFhhHbBx3PY5XJ7u7OS6bmbctO+rV2Sc gAZ6nwk8AE+QfdWI1zQU93fZbfXSPjppy/qDHdJJEZIGfuvHDC4bTejK8ylkYZ1OOS7EgAP8lrj6 Jd7qLNDbG26KwGv1vLJHJL0vZHDKWGJp46XDHJz5B8rjt3toKnTFY2ssnq1dlqCBGeXOicezSfIJ 7FWO1rbae81Vrt9dJJHBLHIQGP6S5wbkf9f0XydG521lGJneo+NkWXO5ziQDKmWMmmccrdoh0PsN bhpyO4azrKmnqZsPEML+gRtPAa4EZznzlcVu1tPWaRubZrY2Wss9S4CB4HU9jjwGu98nsVZjXVqj vdRQUE9TLBHJFK4GN2CXAZH35Xke18u2tnFS4ySB1PlzuSSJBytTCdFyRFonYShqdMwV+rq+soKy Zwc2KFzQGsPAa4OaTnPsuF3R2puOkLw2KlZLW26pd00srW5cSezTjyrP6/tJvk8FAa2WlzTySMMZ HLm4IBB7hZAun0VYJKgl8wkpyXHvnqAJU4xZbvVQtojYGCs03FWaor6u3Vk78sjhLcMYcYDupp5z lR5uXthc9G31tK7rqqKodilqGNyZP+Egf4vorVa/tcl5qPwkVZJSuZSvmjLMcvacjOfH2X1rOqo0 vp2ap+eYTU7i4jJ6uxKknpuY7ukH6N2B/HWCCr1FcZbfVTu/u44ukgNIGM5HB+ijvcbba6aMvoop mPqKed2KWoY3iYeBgdnfRWo3At1Rda38LS10tGYaMzx9AGC4O4BHtx4WwuwFRatNTVQD5mzwvDiO Q4twT/Mq3H1WcLyukC6P+H2oudliq75dXW6qmIMcEbA8dJAIyT5+ijjXu3t30jezQVsb5o3n+4mY 04lHjA9/orYbi0Ndcal8VurX0r6Wk/FMDRw5zXdvpwtjeWNqqbTFRUsa+cTxu6iMnJZypI3MdxAG lPh+uF0ssFZcrvHbamU/LTOg68jGR8wd5HjCjXWmhbtpS+PttzhcXk/3L2DLZhngt/6K2O41Lc6y 4Obaq40jqKlFW1gbw8h2MZ8cLb3ymiuDtK1FTEx84nY4OLQSMsOVcsfWmMLy7qvemPh7u12sUVZW 3aG21UucUstOXnHcfMHAcj6KK9aaRumlLtNbrtA6OZnLXY+WRvhzT5BVw9worrNcXm01wphQU7al sfTn1D1YIznjj7rnviGoobjt7R1c0TDVMLSJOnkZHIz7K44csphL3Uzy4YfkvpTJ/ch3GF88r2Vb QJXcY5XjPflYrU7IpDgplLKgEinlIoBIoHdNWBIKPKECQU0IF2RlBCSBpZ5QhAICE0AUlkkqEhNC BIKPKaBIQhAIQn2QJBT8JIgwE0k0GJQOUxyg90BhLCBwmUCAT8oQgMo8IR9kCPKEJoEhBHdAVB5Q mgoEgIQgChCEAhHhCBJj3R5QgXlPyhCBFCySQIoz38oR4QAR90IKAKf6BJGfsg7Yn6dl5bkc0NQf /mZ/ovueMleW5nNBP/yEfyXix9vZl6cnAOG/usavv4WUHHT7kLGs75Xont576eUd0FZLE91pgkIQ gE0k0DC+kRwSvkvvTROmlayNpc9xw0BBtaW5VMEfRFI9n2cQvvBdqyFzi2aQZ7kOOVO20mzdvdb2 XnVkbJmAdYhf+VoHPK2Nv07obUuri6ltVLFQU56OhmQ2UjyRlGbYrxDd6yOcyslf1/5s5K2MGp7q z5mVUwd/zKxGrNmbZXaqoZLXbYKa2FgEkcJwHHPfHfst5ddt9B2+roqM2SkNSQC9oLsuHueU2isY 1feQM/iZs/dJ2q7xj/1mcE/VWuvG2egLdHS+tpmjJnPS3BfnsP8Ai+q+Uu0WhaqehdT2WERvLstb I/nA8/MrsVFhvtfT1LpoppBMe7s8lYz3uunqhUTyyPmHZxPIVmdS7D2KS909XQwugt4w2Smjecff JOeVod6NtdL2GjsX8MpBQuqKh0cr2uLi4AA+SrO03ED3LUNyr6cRVNRK+Mdmk8LQvJJycq2NDtBo +9aTfT2+k9K5uj+Wpc8ucD74yAqzau0/V6YvdRbK8D1YjwR5aexSTctnw11LJWjP0SWQHCSjRLE8 LIj2R4QIJpJlA28OGP8A7a6HTuoqyxSmSgkdG7zhc+1bfTVmqr9dYbfQgGaU4yewHug3t515e7tT OhqauR0bhggcZXh05qevsMjn0LzG53cjurJWT4ftLUdmpHX59ZPVy46nsnLG5PjACiDcLaqqsWvY bLaXtmp63+8py52TGwnGHHHhO03HOX7Xt7u9I6nqal5icMOAOMheHTWqq/T73GgkLOrk8ZVkbN8P emaWyUpvs9ZNWyD5nRzdDc/bChvXW1lZZNfssNse2eOqaJqdxOSxhJGHH6J2m40d+3Avl6pXU9RV vMThggcZXg0xq2v07I40L+jqOTwrGWX4d9OUtopf47V1slfKOXRyhrM+wGFDOsdrq+z7gDT1C5k4 qAJoHZ/LG4kDq+oRWr1DuHer1TGnqqh3on8zW8Ar4ab13dbDG6OhmLWE5x3CsBafh005DaqX+N11 c6vlByYpAxucZwBhc9p/4c3VGqK6K7Vzm2iE5i9F3948HOMkjAwrtEdVe7OoKiIxmcNaRglvBSt2 698oIfSilHSe+fKmeD4f9FV7pIaO63WSZuR+duAR+i5nTfw8umvlbFfrkIbbAT0OheBI8eM5HCqd OJfvJqHoLWytGfPK8NDurfqOeSVs/W9/fOVM9N8P2ja50kdDerrJK0HADmYz+yr/AKr0XV6f1nJp +aRhlDm9Mh7dLuxKk7mzrenQu3i1FkuEwBPHGThaah3DvNLd31/rl0z/AM3UeCprsPw72G4WAVkl 6uLqgRdThGGhnVjPGR2UVbe7U3LWWoZqWnL4rbBIWy1RGOAew+qs3raWzenk1Ruhfb/QmlqJyyA/ mawkZ+64qhuElJWxVMZzJG8PGfcKyGqPhvoIbLWS6du1ZU3CFvU2GYM6Xe4yOVXOSz18Vz/h8lLK Kzr6BF0nqJ+gU7s2u5vSSYt6tQsohDGWgAYByeFobVuTeLfeJbg2YvnkOXdTicqU9MfDk+p0u+4a guNRR1npOlEETWkDAJAJPlRxtptVdtb3p0MAdBbYn9M1U5vGAezfcps3Hz1burfdRUZpaiYshd+Z rCfmXEWy5yUFygrY+ZInh7er3CsLrH4cIqOx1VTpu7VNdWwjq9CZrQ1wHcAjnKrwy2VklxFAymld WF/piENPV1Z7YQ3EqjfTUQpfRaWNw3AIJ4Xjsu8t8tj5XdYkdI4uJcTnJXY2z4dJW6Mku1+uc1HX NhdN+HjjDgMDIBJ8r6aH+HanvemYbpdb3NSSPJJbHEHBrfHdO9b+yWXf8cpd98L/AF9E+AH02vGH FriSQvHpveO9WWnMUZ9QE93OOVJEvw56cawn+187ceTTtP8AqsbV8NFFVUc1TNqWVsQkcGObTjlg 7E8q7p040b8X8F5wMu4z1Feil39vcEPp9ALc5/Me67OD4Y7ZVNd+G1VO/HcimacfzWvtHw1QV9NU PfqV7ZI5XMwymB+UHAJ57qTd9F1Pbnqn4gr46BzGNLS4YB6zwtdZd8r5bWPaQJOtxcXFxGVGWqrP /Br/AF1tZKZm00zoxIW4LgD3wpW202CuOq7F/FrtXi0UknMIMXW549yMjAVy3Lqpjxslj5ag33vt 0tz6RmYWPGHFrjyF8tLb43my0IpsGYDyXYP6rrLx8M74bRUVVo1CLhURt6mw/hwzqPtnqK0uiPh2 u98tstbeq+Ozxtd0xtdH6jnY7k8jAU79tdPBqrfe+3i0y0MY9BkgIc4OOcKFqmZ9RM6SQlznHJJ7 qxd++GeqpbFVVlnv7LlUxN6m07abo6/pnqKrrV08lLUywTtLZY3FrmnwQl3omtviOCpi233jr9H2 FltpYGmNmT1BxBP3UOLqtvNGXTXF/itloiBcSDJK4fLG3ySstN7ufuXcddOpm13yw05JYzOeT5XR bc70Vmj9PxWuCnBYzPzAkErf6o+Ge7WuxVVZb7tFcquAdQpY6foLh55Lvb6KJ9B6GuustQttNrix ID/fSPHyxNzgkq2/aTXw2+6O5Vw13UUxrQWQ0+fTbnPJ8rp9ud7KvSGnYbVDTZjjz8zT3Wz1f8Nt 4sljqq+hucFzmgHUaeGAtcR55J8BRdoHQt21rf2Wy1w4OR6srmnpib7n/ooNvunuNWa8rKaSrGI4 ARG3uRnuuv263wqNJacp7VDTfJEMccA/VfXWnw53zT1iqLjSXCnuZh5dBBEQ7Hk8nwo32/0Dd9b3 sUFpiwGketM4fLEPc/8ARXd90mvUbncncmu1neqWunyz8N/uh36ecqQdM/EJcLbaoaaohMj2DBdn utPrb4eNRacs77hS1VNdGRH546djg9o8nCek/h31JfbBT3SorKK3CYkthqGu6w3weOOUTpsdU7/V 95poqdkZjiDw93PLsHOFvqf4k5mQsYaR3yjHhcRrfYDUmmLMbjDPS3OJrsPZStd1tHvjHIXo0v8A Dtqi92SG4zVVBbxLy2Gp6g/p8HgK201HSXz4i6qstc1PBAWPkGOo+EWf4jKijtcdO+AukY3HV9Vx evdiNS6Sshub5KWvpmn+8FL1FzB7nI7Lwbb7Mal1zb5a6hbTUlGw4ZLVlzWyHz04BypskdrqDf6p uWmai2NgLXztLXPOPPdfPQe/lVYbYKOtjdN0cMdnwo03J22vugq6KC8RMdDK3MdTDkxuPkZIHIW4 252Y1Nre2SXChbT0tGD0skqy5ol9+nAKbNRnupurcNaVGHPdHSt4bGDwtdtDrpuidROuT4vWLoyw HuW5Xh3G26vmhblHS3mFvTIMxzxZMb/cAkDkLebf7K6p1nbXV9BFT01JnDJKtxYJP+XAOU2qQNd7 +/x7TtRbYoCz1gAXEDwco0L8QUtotDaS4Rvlczhru/Ch3X2hL3om6mivcAGRlk0eTHJ/ykgcro9B 7Lar1jav4hQQQU9IThj6p5Z1/UcHITZot1t0q/Wld80jo6Rv5GA8LDZbcCLQ99qa6oi9X1Y+hp79 PuuY11ou76OvL7feoPTkb+WRoJjeP+EkcrqNC7Kat1daRcbfTQRUrnYYamQxlw9wMchBJ+sviCZd bdHBRw9DxI2TqxgjpOeFuKL4jqRtHA2opy6VrQCSAeVXDVWkLzprUDrPcqR4rA/oYIwXCUnt0Hyp Aofh511WUVPUtpqJglYHiOWfpc3PgjHdNmnU6038lulZROt4dHHA4PIxjJXTj4j6U25rPRP4jox1 EefdQLrfbHUuj66mpbtRdb6kD03U2ZGuJOOnIHddNSfD5ryopIZ20NI0SsDwx9QGuGfBHgpupI73 VW/VPcKO3tpIyKmnka/1CORgY4K3cvxHUZtoa2I/iekDPT5Vc9wNAag0NWQ09/pWxOmZ1MfG7rYf p1DjP0X10Jt1qbW7J32Cg9eKHAdI9wY3PsCe5VtNRKW7W79u1jYqCgEGXQzMlJI547jP1XbWj4hr JS0MUbKURuYwNAazHYKCa/aPWFDqWksU9s/26qYXxYlaWEAEn5u2eOy8evNsNU6IoIK6/UTIKeZ/ ptcyUP8AmxnnHZTayO7uW91wqNaw3cPIhidhrAezVKsHxE2R7WSSU49TpAJ6clU0GXO8qSrHs3ra 9WOO6W+zl9NICW9UjWuI/wCUnKbNOj323Z/ttFFSUoLKWM9Qb9fdQgV6rjR1FDWTU1ZE+GoicWPj eMFpHgryKK2umauGgv8Ab6qqYHwwzske0jIIByQre1G/2nJrRJTOp2OjMZb6Zb8vbthUvAJIx3Ui W3aHXNdao7hT2Kc0skfqscXAEtxntnKDS2q50VLrOmr5og6hZViV0ZGR0B2cK1Ffvxpiqs8tI6nj kidGWiJw47cDCprLTzRTPZKxzHsJa5pGCD7ELuqbarW09pjuMen6t1I+P1myDHLcZzjOUnV2W9aa vTVxoaLWNFW1kLZaGKqEro3DILQ7OFae9b36UrLDUUckEMkT4i0ROALe2BwqaPikbIQ4OBBwQe4K 7QbY60daWXFmna19E+L1hK1oI6cZzjOeyu/lNPHpC6W+2azt9dcIWzUMNR1ujcMgjPH+itDqbebS V101VUUkMcrHwua2MjIBwQMKm/pvB7c9l2J251i20fxI6frzQ+n6vqhmR0YznHft9El1dxMpMpqu s2T3FZojUs7phmhqwGSf8ODwp6buzoQ3MXMUdILh3/EBgD84x+bGVSprHl/AJyeF1lToLVlPaXXG axXBlExnqOmMZ6Q33+yW7u2llrJvfZnauuNVXu6YXxNihIPGA4n/AFW4j3T0Cy5/xFtJSNr8k/iG saH89/mxlUqYJXvaGZJcQAByST4XSV2i9U0Fukr62x3KCijaHOmfC4NAPnPsm00s0d6bHDrw1MTw aKop2xSuz5aXEf1W2p929HW2uDrdHBAKqRz6h0YA6zjgn9VS1vrSSNa3qcXENaByST2AW+uWk9S2 yjfV19luNPSxgF0z4HBgB93dk2nFN9x3Utmn9yXXHTrR/DakNNTG0/K53OXfdSXXbxaWpqCsuNv9 MV00YLjxl5HbP2VJmCWSQNaC5zjhoHJJPYBbit07f6CkfU19nuNPSsx1TS07msbngZcRgLVy32nC em71vrOq1JfZayaQ8nDeewVkdpNxtIWjRdBStcyCoMQ/EDq5c/ySqdtie+QNa0ue8hoaBkkngALa 1divNsp3TV1rrqaJuA6SWBzWjPbJIwFm/td1qdTjPSw1DunbdK7iV38Md/6DrJQ98echriACQpCu u7OlbTaq+sszovxU59Rwbj534xk/XhUnibLNK2NjXPke4Na1oJLiewAXvr7XdLdHmvoaulbnGZoX MH25CbTTeaw1bVahvk9dUPJdIc/9FabbTXmjLVoe30MU7IcwD1m5HLyPmz+qpZFHLLM1kbXPkc7p a1oJLj7ALYVdDcbYG/jaSppS7hvrROZn9wm1kWw0FuFpmyXG92Mytba5ah8sD8+HAAtyt5YL/t/p MVlVZHCKWZvzkv6urGSByVSmJ88kgaOpz3HDQASSV6qqG4Uob+JinhD/AMvqMc3P2ym1nSw+gNW6 crt1bvfL04Qud/eUpzgB3Z38l6/iTvGndQ6bp6y3VgkuFO8MaARgsJ5GPuVWSN8xkHR1dfgN5JX1 qHVIja6YSBjj8pc0gH91PnfyX9pJ9Jj+Guu0/btT1tffZvSqYI2/hSXYGTkO/kuv+Ji4WC+WeiuF trBLXxv9IgHILDk9vuqzwOlD8xk9X/DnK+0k8z24c8uHgElXG8e4Zftrfwmr4ZajT9v1FXXG9zmK up2t/CuL8Nw4EO48rofiaqrFd6OiudtqxLWh3pPaDwWYyD+6rfTSTMf1Nd0u+hX2nqZZY8GUu8nJ Wsc+PbGWMy1v4Tt8L9Tp+hulwuF2qPRuMGGwdTsN6HAh3HuvZ8TUlnrzSXS2VgmqX/3crAcjA7FV 5pppY39TXFjvcHC+lRVzzNLXyl4HjOVfHnw3Ymfjmdlvw8JPJ48rKN/S4H91iVj9FzdVs9kNx7Ve 9MM0rqb02iKH0mOf+V7AOP1C6/UOrtPaD0m2jsbonEM6QW4+Y9sn3KpRSTyRODo3FpHkFe2e5VM7 OmSoL8dml2VqXrTFi2e2+4Fk1fp+bTmoPTY5sZY3q7Ob4I+oW21Lqux6E0my32l8MhMfSXNABccY JP1KphTVU8LhJG8seOxBxj9V6am51VU0NmnMmOwJyky0nHa2m3ut7FrbTM2nr66ON8bOhuTjLR2I +oWz1TqWyaF0t/D7ZJG90seC5p/McYJI9zhU0pauogmEkEjmPHlpwV6a251lW0CoqHShvYFxOE5d 7OK3GidX2LcDSctlvUjIp4mBuSccDs4fUL2au1JZdDaWFttj2O9Vh7HIJIwT+uFTaguFTSS+pTyu ieOMtOF6K68VtcAKqd0hHAyc4Vl1TitzpbU9j3J0dJabnM2nqoWgE9WCCPyuH7L1611NZtGaW/hl C5j+thGA4kc9zk+5VOLfcKqhlElLM+J/bLXYK+1yvNdXNH4qd8mO3Ucqbku11VurDfLJubo5tBV1 LaWspuk56sFrh2cPcYX315qe0aP0sLTRFjutpAHV1dzknP3VPLXd623yGSjnfE8jBLTjhZ3O919w IdWTvlI4HU7K1LN9mUt9Lg2262XdLRzKc1gpK2nLXZB5jcPOPII4/VY671HZ9I6V/g1I8SBzcAF3 VjJznP3VPrVeq63SmShqJYXOGD0EjP3X1ut/uFxe01lQ6QgYBLlnr3RcGOqtO6ekYPRrDSV9MQct d0mN3Y/oQsNfajtWlNKNs1PIJPlDBl2SBnPfyqh2bUNytUjn0NTJE53B6ScH7rK9ajuFyIfXTmRw 4GSVqX7TX0t/UPtu52lqWot9d+FrqZwdgP6Sw9nA/cZ5WOv9R2zS2l47NA/rcxrWtBdkjpcD389l USxanuVqc51DUSRdfcNJwUXvVFfdJA+snfI/tlxU2cNXpcKuFHuTpqgrbPcDTVdO8OIa/BHhzT+m eV5te6ht2ltPU1njkMj4CzHUeflcDyql2DVt0spf+AqXxB/5gDwUX7U9xu0gfWTF8nvkq45yXsuG /S4N0p6fcSy2u5WO5mnlieC8Mdg9J4e36HGV5ta6it2lLLQ2v1TM+kfGck4J6TnlVP05rK72IPZQ 1UkcbzlzQeCfdfG/aqr7xUepVSuc89+VmZReK4d6o49eW+1XSwXJ0PS7pl9NwB9N3Dm/cLza21Fb tM2u22+ab1n0j43Eg4J6D5VUdN66vFhifFQ1b2RPOSzPGfdefUGq6+8TmeskL5Hdz4VmWqs3O1wL 7b3aygtV209cjHC4iOcxuGTG7uPuD4K+WttR2ywU9ro6mb1H0skbiRgH5eOVVPS+4N609TvgoKuR kDj1enngH6Lw6h1hXXmpNRVPPUe/OeVZl9pJq7i3+prZVarfabppy5dFK8enUFh7xnn9TnwsNa6i tlibZ6aqm6n0sjHOx7AYVVtKbl3zT1KaeiqpBTk9Xp54B+i8GpdZ1t6rH1FRIS93JTHUva8r8Lda rtFw1FV2y56buDGUs7PRqHAZHpnJzjPPOBhfTV+obdY5LNDVT/PSSMc/p9ukj/VVZ0lule7BQ/g6 WreafOWsLjx9lqtTazrLzVunqHkvcckc4Wty+2ZueludX2i53yvt1bp2ujZSVcfoVLg3qAj5cD39 +Fze/FwpItHx2x0zTUxhriAeOBhQPpPdu96ft34KGoc+mBy1rifl+g+i53V2say/1Eks0hJfyRlM MpjlyvuHklzx4fDka1wMzj3ycrxr6SHLskr5Lk3OmPZCZSUC8oQn5QYlBWRCWOVYMU8IKCUAhAQg AkmhAvKZ4QhAsBCEygRTSTQLyhMpYVCTQAjwgEvPKCmgOyEijKAQmMpIBBT7pY4QHZHdCYQLwjCa XlAvonnCMICqDyl4TxyjCBJoxyjsgZWKPP3TQCSCn590CCD+yEIAdk0vshAZQhNAkBNJA0vKP6IK BFGUI8oAjyjwjwkgZQhCA8o/VCP0Qdjn3C8dyyKKbHlpC9YGV5Ll8tHOT26SvFj7ezL05iDgA+yw q/K+kHYfZfOrXont576eYJFPwk7utMEhCEAmEkx3QNdFoiNsuoqFrgCPVb/Vc55W70xWNt90pqh3 eN4dhBdiqc6HbOvMfBFJKeP+UquW0Fzq2X6GGFrpPVaPt91M+idd224WYQVkjPQLelzXDPHkELw6 Ut2j7TrCqr7bOPwzz1dDgA1hzkhoHhat/WRxmOsrltNtB64tsH4o/wB708jvj2UOyOur92axt4LQ wMaaYNOR6ZJx+q39XuFR1mpvwdDWMNNCwEu8Z8rY3Gp09cLzRVcdZG2qa3pkkA5LRjA7+FnVb26f Utxttrio6i6ujZGDlr3nhpAGVxm1dykudfNVOL3U5nmMJcCA5vVwR+i3GqYdPanio4q+4/3VM8yd DG8OyAMH9l7ILrYqF1DDR1MMdPTteOkDAHAwmhs47zCL3U0ErgC1rXN8YyFDPxXSmO2afwf/AI4k Ix/yhbKHUFFW7p18kFU19IxkTerPHUBytF8RdVRalrNO2y2VkT5xLI6TnhjSAMrph+tcc5bp1Hw+ SyVVhp5ZXEvdGeSVX/4igP8AtMuAH+Rg/krEafuOn9uNDiSStbNMyPt2Jd7BVK19qGXU2pKu5zgA ynDQPAHZTxXhjlL8uvlnLyY2eo5xy+Y7lZArEd1l0PCRCaCgxxyskDul5QZNU1fDjbaOXUX4ytfj o+VrG91Cw4PZTd8OdvlqtQGf1GRU7eC558qZTpZ7WO3eu1DY9JNrqmSZgYMQCPy7p4yoZ2pur9X6 1F1vtS974GCKKPyApG+IWghvGg3xx3Cmi/CD1iHP5d0jsAoa+HSgnrL++f1GRU7Rgl5xk8LvlJ+H Gz283j3+TLaxG792o7JpNtbPNLG5n+4DMfM7HAKh3aW5O1hrY3q+VDnPhjEMUYPIAXe/Edb2XfQJ /D19LGaM+sQ9/LwB2H1UQ/DbQT1V/kqOtsVM1oBL3YBP0UvXjkhhvnltYPeG80di0uyvqJpo5I8/ h2sx8zscAqH9obi7WOt33y9zkysjEMUbe4aF3PxLW7+L6Ea+nraSL8E71XNfJy8YxgfVRR8NNunq b9JVdbY6dg6SXnAJWMusZr26ePdyu1gN3LtSWLTcVfUVM0UsRP4cMA+d2Bwf2WW1t5qb7ZzXTx4b IwdTnHnt4XJ/ErbH3fRUM1LV0rBQPMr2PkwXggDDfqt3svW0p0bT07JWh5iaO+BkBYs3jFl9troi 0WW3V1VLaauonlle9xa8gtB84UMa2uerrvuVV6ftTPSll6ciIktaw+XHwpY2203WablrJbtW0kjH SPe1zJM4ae2QV0GnYaCS4XW50rYjUTOAEpwHEAcD7LvctcpHG4XLLHK/DlGyWrabSDprhU/ibk5n Jc7LnOx4+ij3b7Q024Op6jWWqmhtDkOjh8uDeRn6LfVu1F01bqWes1neI/wAJ9GGklGfpnI4Uk6Y o6O1WurstFMHCOMsYXOH+XAyVz9TUbxlvdbG2yULrJW/wyJsdNGxwHSMZw0rn9r6ZlNomZ0DAxzg 93Axzytnpm3SW3TclsqpYTUPjeAWvyDxjk/qtVoWsio6OXT9VIxtREDG57HAjkYyEl60t97ejQVv mofQdUVUk8k8Re8PxhruOB+68Fi0FbGa3u2pqiJs9Z6hbCx2MNwPH1+q91ooqbRFDX111uZlhY5x jMjgXBngKvV43dudy1dPFZh/s9RN0xxg8nwrv2nHuVaeVtdWWOuZOyOOeVr2xsa8EAEYGSud0XaX 2XQM1JG1kVVG2QO6TkdeO+futpZYa06MMcjmitlhcR8wwHObxz91p9HV0ctnnsVRK2KujLopHhwd 8xGCQk9Riz3/AF6dv7fU0UMTa2sfVSTQCR/UAAHcZx9FqdKbeWyl1bedTywCouEtQ8RNIADMe339 1sLLDHoWyV1Zfbh6vQ53Q5x/wD8o+6r/AFW79yuGrZaa0BxiqJz6bAfcq5Xe6uE1qLO3eC4XLS9x gmhbHVzRyMZH1AgZGBytHZYIItD/AMFq6yOmqWxugkc05LTjGQtk2muc2hJIoiBcpYD0Zd2cRxyo hte1d4uNlqKmfUtUy9tc/NNEGmLqHYFx5/VJdYy79Vmy3PKa6seqr2iqp6KaS1awrp5mAuZGYx0E +Afp+qier3B1fHWO0w3mrjkNOY4QXOc4cHCsntjabppvTErdTOY2duS53qB4xn3UVbLUVHcd49SX MBkgZM70n/cnkLOeV4XL5bwx/fjPWko6Gjm0VoNtXqqpa2qLet4J5HkN+6e0NY252m5VrSTFUVL3 syezSeFDHxXagrYNTUlqjnc2lNO2QtB4zkqUPhuJk25pznLnDP8ANXXGST5JbZcq0O5m0Nk1LaJ7 lpiBsV4jlMjz1E+qc8g5OAuO0HfdR6pq5NMyXCK2U1G0tmlwXYI4AABGeynbRVvrLJZbg699MXVN I8EuyA0uJH8lDztoLnJT3G+6dvpdcZpHPZSMjDWuHVwC4n2W8pjrK73duXjmW5qdaTLpG0v05pue L8e67yNBd1BnST9OSVBFHqvVusr9LpzTzXQwtkPqyHtE3PJPj9FN+3NDc7Jo8/2m6YqsDMhLgR+6 x0/YW6a0jV1Om6Jk1zqi6U9gZHE+5WMMv0s+XW43ny+Gq1RqC3bX6K9GoqzU3Ax4y88vd748BUQv lX+Ou1VVAY9aRz8e2TlWquuzeqNcy1ly1VdP4c8ZMUAb6hIwe5zgKp9xgNLX1FOTkxSOZnGM4OMq W6nGN4T5eYDJVwvhC02KGxVV3mcwS1R+RnnpHGVT1v5grl/CPHcH6YnnqWPFIHdELj2I+iw6X03u 5mvToSvrDUTxVArA704Wnlny45Wr+FnT7aa13C9vczrrpC5rf8Qb/wDSVEPxRUNypddyVNXG9lHU HMDj2dgAHCl74TI7g7Sc1RVB/wCF6uiBx8gd128+tyR5/wDGtuG62e5evToasuEVVJFU/jWu9KJp 5ZkYw72Xh+FnThoLFWXeUxh9dIXMaPzBvgn+ahf4maa40u4NRJWxyMpqj5qcu7OaODj9VNXwosuE mjZJ6xjxTdXpwOd2IHsseWSaka8Ntx3Xp3P12NEvutJWSxVIrWOMMbTyzqBGCvn8LWnf4dpepukh jElfIXtaO4b4yoJ+JaludNuJWGvZJHTzkyU5d2cztkfqp5+FYV8mh3TVjHiEu6IXO4DgPZZ8mupG /FuS2thq7Wg0tfqiz180U/8AEH5ha056A44IP1XVawtdwvWkqWnsNbFQTgscJJQcdI7hVx3Hpq2P finZc2PZFNWMkgL+zo+ruP1U/brRXqbSVKdLwS1FQ2RpLIu/TgreM3dMZXUem6vm03tvKblJ+Lnh gPXJGMhzvf7KMdL6i1TuVSTMs9VSW+moyGdcziOt3sMA9gpHrqWsm2kfSXIGOumpDG9snB63Dt+6 haDbbXmiLVFNYKplxhqH9UlPTNPUzI7891u2fi/u3OTL8l36Txc6Z9JoFtBdiKmaSMRSuYMtcScE /ZLU9NW0VutFn0y2npjI4tAcOljWtbnx9k+qWHbum/igMNSI2GRsnBDuoEhZaydcqy0Utw0z6UtR GT0g9z1ADI+y4/D0T6ebVFupNR6ChbfqSGoeSzLXDIa/rAOFnq+Out1DabVpqOngaXO+UjpY1jG5 xwFnfp4rPpOio7nURtqXujBPbqd1An/VPXTrpUWumrtNMjqJRlmDyel+G5H27q4++2M92ajy6ttt HqbQlGb5RxTvL4XYc3PS7rAOF9tZG4W6ntVr01DBEz5nOB+VrWMGccDhfXUM9PZ9L0FFcKhjZy+J uc/mIcCSvluA+7voaWv01FHVPwYnDuel5AyPt3UntbvXTz60tFBqrRttku9JFO90kDh1Nz0kuGcL LWktzt7rVatNQQshDXSOafla1keCAvZf54LRp600NdOxsxlgb37lrgXFeLcH+NYpK3TkLanrjdAc ckdZGCB7Lp45N9seS3XT4a4sNt1dpyyVF2o4ppXTwEEjt1OGR9l6NYVN0t1RbbZpqli9CON00jMh gaxhGAD/AKL1XuentFqsFFWTxxzNng4z36CC5eHX5vsdRTVenKZlSKiI0zjnJb1uGDj2+qY/0zt1 0+up6O23GHTl5uMEP4mKeJzZXDlgd35Xw3FoNV19XQyaTfB6HT/e+o8Dz3Hvwud36qxZts6eAztj rIzF0tB5Jb3wo10ZqvcC8V1BRtt9V6E3SGTPic1pb79R4xhX/XGZRN3O8b8LB6jZHHBYzcOgGOoj Di7kA9Jzz91qNwaPVtTdqGTSrYnUfQBN1yBvPV4/Rc/8Q9zNp0NSgThtcyRjgAeTgEE/uo30Zq7c C9XK3UX4CqEcxaGySQuY3o/zdR4xhZzmsca3hlcrcfp3/wATtJ+I29o45mh0oqI2+5zg/wCq6PbX T1bpvaWnt8MLGXEwOkDQR+dwyMlc58S9THDo2hp3yt/EioY/pzzwDz+66Wy3S4v2cZcXtkFwNE+Q DpPVnBxwt63+OOPK44+SuM1fuHDMbDSjEd7p60Rys4yzPykfzXf7qaIptf6dprVV1TqYiQSMc0ZJ cAqZWmsqK3cejdVEmeS4R9QPfPWMq4+6FfWW5mnZaEP6nVzY3lo7NIwVy8v/AMtxnp6fHv8AFMr7 qvm2ez8lq3jitmqKT1qSBj54XEfJLj8p+/0VhL9qS4WzUbKaio2m1UjYxUSdWOkyHpaMecd10N6M UWoLFK/paeuVnUeO7Oy5TVcF1OpX0NNQiWnukkJE+fyCPl2f0CnerZ7SzdnaJfjE0tbYaW332kpm RXCaQxzSNGPUAHGfr9VVJXG+Mapi/sxbYA8eqJi4tzyAqc+VvOakMbvaZ/he0hbtUa76rvCJ4KOM zNjPYvB4yrXXHU1dS6pjo4KBxtcErKaSVvDQ5+Onj9Qq6/BrLGzVtyEj2tLqfAye5yp8ukl0Zq+S 0Mtrn09bVxVYqc/KGR9Of1+VcsN/tt0yk3NPBedrdMV+5lLdaihBlex074xwx72kYJHnut/Pqarg 1ZFQxUDv4SJW0ZmAHSJDjA/Yrc1MkR1hSNMjA8U0g6c85Jbj+i5WeSvbrE2f+HSmGW4tuAqMfL6Y 6QcH3yFuztz36a2t2m0vU7osuktECXRGpdADiN0gdjqIXSN1PKNWC2toHi1er+C9YNHR6mM9P7Fb p80R1iyPrb1/hHDGefzLkYnVv9s5LObdN0G5fxE1H+ER8AH9wmptuNUdotLu3Ukuv4IY9EVX4f8A 9n6nUR1dP6dl09Lqp1Rq99nNC4W3rdRh/SOgyNGSP2W7jez+2szeodX4Bgxnz1uXGWl1U7cOa2mg lb6NZJXOmPDfTcMNI+5GFrCSy7cs8sueMnpr6PaLS0W6lRcGUbelsDattP8A+zbIXOBPT28dl1NH qVtx1VNZZqB38Nf10rHObmNz2DLh+y3EL2nXVSA4E/w+MYz/APNHrkLDVTy63htUlBLHNRVU9VJK RhvpvBDT9ck4Wccdy2tXLV001k2e01Qbp11wFP6kUcTKmGmdgsY9xcCcfpwuroNURXrUlTYau3PN snD4I3SM/u5HMBLx7Fb6Atdrauw4dQoYQRnn87yuN07XTT6soLQ+hqIp7dU1E0kjm/L0PD+k/Y5W 8ZNXbNtlnbQ6R2c07aty7pWeiZqemayangkALWOfnx9McLs7fqSn1HequxV9ukdbahjo4zLHlknT nrGTwVubYQ/Vt8aCC4RU/n6OXKaVubqvU9FajSzMqLY+d07nNIADwen91nKdNS9uc0Rs3p2z7h3S t6HVENGWSU8EoBazqBP8vC7W3aho9W3GvsNfb3voJ43Bnqs+SRreHYz3wVubOP8A4Zr/ANjlsOP0 YVy+ibm2vv1DQtpZ457ZFNFO5zeGkngfr3V1O2pq6crt5s3YbJra7XCTrqY6GbNLFKARGC0EfqDn ldtR3e3a5fc7DdaFzqaWMujErMB7O2Rnvz5W7tDc3fUnTyXPYAP/AKGB/Vc1oS5x3O80EEVPNHJb aN9NOXtxh/UOP5Lnl1Wuq5Ha7ZyyWLU94uFSX1ZoKgspmyAYY3pDgf8AmGe67OKutG48F1sN3oHG HHXF6rMEs7B7c/XPK39hGZ9Thoy/8W4YHf8A3bcLnNvrlBc7tSx08MrJKCg/Czl7MYeHZ6f0/wBV bNej247afaOzadu95ule41sluqnQ05eMem1rQ7q+/K7Jz7FuhbLlZLpQu9NvzwuezpcGn8r2n755 C3NoYXUerQ0EudWzYA7n+6YtPt1daa83hktJDKz8Jb2UkxczpAka7Jb9xlW+nKX9tWuN2e2ntOmL ld7xcpPxk9vqZIoHObj02sAJd9yCusq4bBunaLlZq2k6XwnricY+lzAfyvC3dA0/wbVuASTVVOMd /wDdhazb66Ul5vz6qgY4Rx22GnkJbgdbXHI/TKsxmtrcu9OI2Y2st2lZrjqC6zCrqKSWWKElmBG1 nBd9yF09yt+nN2bDcba+nZFPTvJila0NdGf8LuPddDR/Lo/UBaC7MtUcAZPcrW6Audvu+oKqrtbc MFBDFKQ3GXhxz+uMD9FrhPbNz1XEbM7U23STanUt4mbV1VO6RkQ6MNiDSWk/UnldJfLJprdvTlbT RRRQVtI8iOeNoDmO8E47g+y6QZG39yIBJDqgkDv/AL1y8u39wtt0vV2rbV0mKSCASFoAy8Ag/qs8 Z27XXtwGze1lt0jSTamv8jKqqj6wwY+SIAlp4Pcn3XQal0xpvdjStR+CZFTXCkc4RVETACx3scd2 n2W/uLSNs7gR4Mp4/wDnxK+mgquguFffK21uY6CZsJJYMAuDSCf5K3Ca2xbvO4/CO9ntq7XpW0ya l1KYauo6SWBzMsiGS0jB7knyt1q7RunN1NJPqLVHDS3Kl6mxSxtA6XDnpdjuCunvBa3aqdz/AMrW Au+wlGf5L66DkoKmq1BVWkxmllkYR0YAz6YycLHHXy1fdUIulHJQ1stPNw+N5Yce4OF5QMLqNwm9 Op7kB2FQ/wDquW8cq5TV6TG7naXPh00dbtWatfHd4nSwU0frNZ/hc8EYDh5H0VhNW6I0Xqilu9lh ttHQXOjHUx9NE2N4wMg8YyFwfwg3GjFPdLb+HYK0SGcTY5LSAMZ9uFj8Qmpm2zVcclq/2a4RRmGa RvHWD2z+64/48uWWVt9N+fLjxkjjdg9C2zUWtquG8MdNFb2+o2Pjpe4OxhwI5GPCmjWu32jdUWe8 W6gt1JbbpbiXMfSxNY7IbkEgdwVz/wAKt2oqijudEaZguLZjO+ox8z2uxwT9CtRv/qZlq1gJbMXU 1YI3QVJacCTyCR57rpj+2VsPLjx1HJbB6BtuptWVjL210sNAwSNi46ZHdRBDge4wpX11t5o3UGnb xS2ahpbddLWXOD6dga7IGcO9wV4/hXuNBUWq50raZjblHMZZJwB1PY7GAT9FzO+upo7RrGaSxudT 1D4zBVgHAkOe5H2K345u2/Ec/PbjZjj7c58POgLZqfUtdLfIvXgoI2ubAfySOcSD1fYKTtY7YaN1 FpyvZpylgtlxt0jsmIcnHh30KfwtV9uqLBcaeKANuMcrpJpccva4/L+y5bdXUkdo11M6wPdAJ8RV cYPyvf1d8LUkymWXxElvPHCe67Kn2y0Lo/SlNJfrdFcXPPM8ww4kjOOPZavWW1Gkb9oT+MaUpmWy SPMoewlzXtBwQcn7qStST2mHSFENTxNrKZ4aMO+Xnp+i8lcaI7VVbtNsZBQNgeWR8uGM8gH91y8d 5XHfqr5LZMrPhxNNt/trp/TVDLdoIrjI5uDUF5BfnnJAOFrtfbRaZumh3XzRsIpJommQMa4ubMM4 LTk8H6rktrrzpyWpuNHrRjpowGmm6nuAHcOHBU9XE0rdti7TrI4reGfLGQXfL1jODldLjJlxJdza MtEbMafs2mvx+uohNVSgOMXWWiL6Ag88YXL7x7NttIZedJRma0ylofA12TETgAgnwSVOm4lNSVsd ipbgcUs0j2uHX0ZPpOIGfuAvjSRCPaZ8PV6jY29DSTnIEgAS46krOGe8sp9I40TslY7Tpl1br3Mt VKQ/045HM9EYx05B+b3yuP3d2bksNRHctMNfU2aoLQ2PPU6Jx4Az5B91YLXdFR3Sez0Nye5tNMJQ QH9OXBmRyvO2H/6k9PHI4yGOKMBxOScSAAq3GSSry3vSMdG7GWSh04KvXTnyVUxDwyKV0fogjHSc dznnK4rd3Z2o01XsrdPMlrLJUuAiaD1PhceA0nyCexVjdbWykvdXbbfcJJGRSRSuAZJ0Fzg0Y5Xk 6Hna+2MmcZHs9EFx5JxIOVnjOoTPaLtF7GWWm01BW61mnZWzkPEcchj9IHA6XDyc+fquJ3Z2jrNM XSOayxy1tpq3BsHT8zmOPZhPnPgqyGurVDfK2ioKqaWGN8ErmmN/SS4DI++O+F8A18u3diE7vUeJ KcFzu5IkAynCdLLtFGjtibW7TVNV6wrKumrp3hwjhkDAxrsANcCDzlcbrvZm52XVVLQ25wlt1fKI 6aoeThhPYPKsZuBZ23ytZRSVc1NilfLH6bgMvacjI8rz36vNFt1arlODLJTCGUk93EHlWYb1PtJn 85I6l2J0lQUVG283e4Ula6MGT0pWlpd5x1NPGfsua15sZLQVdqfpiqfV0Va5sRdUOAcxx5DsgdiF Lupv7La8oKGpqbxLTdLcgQuaCM+CCCtxq+qgsOj7ZUBzqinpHwkO7F7Rjn9lnDHd01cpj3l6RTLs PpqhgpmXW+11NVyMBcxrmEA+cEt5GfouF3d2hl0bS09xtlXJX2qUBrpJAA9jj2yBwQfdTzquk05r iGgrXXqWmAYC0QuGe+cHIKW9NNEzbOOHrMkUfpgPPdwAxlaxxmWWOMcuWUlt+0EbS7QO1jaqq63O skorazLInxdJc57T82QQcBeXdzaOp0VDT11FVOuFqmw31S0BzHnwQOCD7qyG2Njt9u25ZSUNcaij qGulMpABaXgdQ/QqLXXGa+3Nu3t1q/WgfUkQVbBklgGR3+gWfHrLHlW8rZnwiJdrNurhri8CCn64 LdHzPU47Dthue5zhe/dHbKfRl5go4qt1eyeMPY5seHA5x048q2tps0elqShttit+KUPHqvByAD+Y 8nPflc9rS2TP3P0rWGEOpOp0bn+zsOICuMl3tLldyIa038PNdc7NT1VwvbLdVy5xSup/U8ZHzdQ8 fRRPrrR910heJbfdYi2RvLHgfLI3w4fRW83ChulRdZXWqs/D/wAOpm1LY+nPqO6sEZzxxlaT4hKK G4bfUdTPGw1DC1wfjkZbyMrWOHLKYy91rLLjhzvpTKQFfMr1VbeiZ7T3yvIfK5tMTlCaR7KASPZC EAEFAxlP7oFjKx+6yRhUYhPCaO6BIPdNIoBCeEigEimhAk0k/KAQhCBHlCEZVB2KEFACAKSZQO6A R5QjKBeUYQmgSEeUFABGE0IBJMIVQh3QU0vKBeU/CCEDhAYS8J54SCACE+36o7FAvKaXlCATSTQB SwjyhAIwhCASzwmhAggjlMoQLsjwjwhAJ+EHskgEv0THKOn6oOxC8d3BNDLzgYXt7LxXYg26YZxl eLH29mXpzEQ4GPK+dUF9IcgAHuvnVdxleie3nvp8BwsXd0xlDu60wxQhCBoHdCEAvvEcOznlfEL1 26lkramOCBpfK84AHkoPfT3GpgjLIpnMae+DheiG81sTC2OYhp74PdWJ2v2ns1msZvmrIoaqUN6/ TlAdHGPOR5K+umbNo7Uurpriyz0DKVgEUcDYgGHH+ItHGVe9bZ63pXOlu1XDKZI5Htk/zA8r2R6k ubXZZVSh3v1KyV+2coLhrmGsit1LDaTG0GGEdDSR3JaFvblovRUV9oqBthtrpoxmRgiwOe2fdTbO lWP7V3dox+Kk/U5XxfqW5kH/AGmU57/MrgXjQ2ibZLSsm0xbHGcuA/uM4xjP9Qvm7a/RNZc6J0Vi oCwse4sawgcY7jKuzSnFNe66lldJBK9rz3IK+brvWSVf4iSZ5mHPUTkq0t42OsL9UwV8NPi3ucBJ Rt4jHtjByc+Vym9Og9MWm9afpLfQxUEc7n+sYcguAxgclaxly9MZZTHW/lA10vlfcWBtVPI9rewJ 4WnfzwrbSbRaQv8ApaSntNBHR3L08sqGOLnZA85OOVVzUtlq9P3eptlc0NqYHYdyD/RSdzcdJZLp qisRwnjCR7qNgIKEH6IFnKYR5QgzacFdFp/U9fYgf4fKY8nwucHddDo3TlVqe8w0FJhrnkdT3dmD 3Qey96wu95p/SrKiR8flucAr52DVdfYuoUMro+o54Cs1QbCaNoLXSMuzKqorJBzJ65YCe/YKFNUb V1FHuSdO2uUPhma2eORw/wB2xxOAfcjCu2enLX/Wt4vdMYKype+E929gV89OatuViY4UEpjB57ZV lqHYDR1HbaWK6GrmrZQf70TloJA54/VQnftqqym3Ifpqgka9j+mVspzhkbjxn3Kb+U6tc1qDWl4v lP6NbVOkiznpHAWOmtaXHT8RZQydAJJ91ZGh+HvSVLQ08FylrZa6Rp/vWzdIJA9sKD7ttZXxbjv0 xRSseCQ8THOGMPv9Vf6Szemk1Brm83yARVlQ58Wc9I4BX107ru72KExUcx6M5DTzhWFo/h40pT0E MFdNXPr3tP8Aetl6QXY9sfyXPaS+HWCS7XD+0NZI+ggJEYgd0ucO4JOFNk0i6q3U1BUxGM1PS0jB 6QQs6Dda+0cAhimb0j3Cmum2J0Lc2Sx22puZlDTgmcEAj9FzGkvh7gNfWO1RcsUkLnBjKd4a4jwS SOFf+i6cDLu7qF0ZAma3PkArx2/dK+UjnujqPmeckkZU3U+w+ibnHKy11tzfKGnpLpQQD+yg+k2r vlZruo01SNEkkEmJKhoJa1vuU71s3N6el27uoR1dM4y4YyFqbTuFd7fcJauOdzppDl3UeCVJe7ey 1p0ToQ3KCrrJrixzGu63DoJJ5wMcLj9o9pLhriqFTP10lnYfnnxgv9w3P9Uu8ZLflJljlvXw0uq9 xL5qGm9Csnc2Hy1p4K5a03Se2XCGspyPVid1NJHlWL1r8O9ujsVRPpOvq6mvhyfTncC12O4GB3UK aN2/veqNRm00lI+OaJ3TO6RpAi55yp37Xc9OifvLqJ9N6Qla0YwMd1prHuLeLTXTVUMpdJIepxec gn3UhbubK2/Q+kae401fVT1pe2N7X9PQSe+MDI/mt5or4fLPctKQXG+XisgqnjqcIC0NaPHdWyyS /aSzLcnwiLWG5F71JT+jWzEQ9+hp4K5aw3Wa1XSCvgx6sRyMqz1N8OGla+Iuo9QXV4HchrMf0UH0 O29bd9w6/TdmcZGU85jM8oA6Wg9z9VPjayzfH5bybe7UD6X0Gua0YwCCV5rNvDfLbG5geHBziSXE 9ypRr/hnt8drlbSX2rkuzYg5rHsYGdX184z9VoNC/DvJXUFVWatuTre1jiyNlN0uPB5JJTdOnG6h 3kv94t76P1vSjeCHFpPIXPaM17cdKT1EtCQXzYySfIU13L4b7VLZ6qew36rqqtjCY2yRsDSfrhcF tfsjdtW3SpF0L6C2UznRyTgAl7hxhme4+qXeia30jvV2qK/U10NdcpC+UjpH0C7DRe7l201aGUFM GmFnA5wuw3M+H1+n9OfxTTlfUXQROPrxyRtaWt9247rnNpNl7nreZ9RWult1ojyHTlvzOd7NB/qp tRqHeq+3WgdS9XpxO/N0nustP713m0ULaZmHtHkuK3O6WwU+mdPi66frp7rDGT+IY6MNcxvgjHda PaPZa6a5c+qrHvt1ojBzO5nzPPs0Hx9Vdp0+183vvd0pRTvPpxZBcGknOFsaPf28U9MyJrctaMD5 iEt0tharSljbdrJWy3WmYT67TEGuY3wRg8rU7SbLXPXQfWVcrrbaWD/fuZlzz/wg+Pqm11Gwuu/1 +qKGWCFrYi8EdYccqEKqV1RUSSu5c9xcfuVNu6+xFZo+ytutprZLpSN/3390Glg8EYPP1UHEYOFK ss+CBwVMuhd6rjpewU9spYB0RN6QQ7GVDbRkqYdpdkLvruldX1NR/CrXg9FQ+PrMh+jcjj6qLXLb j69uOtq6Ga4H5YQRG3OcZ7rstC72XLS9gp7ZBDmOIdIIdjK+G7Oydx0NSRVtLUuuVA788zY+noPj IyUbU7IXfXFFJcKioFrto4jnfF1mQ+cDI4+q1d+6xLj6jk9ydd1+trpHV3A59JpbGCc4BXcaJ3xu Gm9P01spoD6cDekdLsD7rVbt7M3XQUcVWycXK2PHNSyPp6HexGTx9V6Nq9jrzri3PuM9Qy124cRy yxF5kPnDcjj6qd+1mvUcruTrqt1vdWVlfnMbCxgJzgLv9E77VunLBS2yOmPRAwNGHcH6rn92dm7t oEQ1HrfxG2ytH+1Rx9AY72Iycfdeva7Yy9a2t0lxmqGWu3jiOWaIuMp84GRx9UXcc9rvcKv1RqeC 8TFzZoABFznpAOcKR7J8Q1wordDBLEXuY0AkOXEbsbQXbQE0Mskn463StGKtkfSA7/KRk4Wy2y2L vmtbVJcZKiK10QOInzxlxl98AY4TaajY6031ut+gihhDoWMd1d+5W5s3xEV1HQxQS073OYMEh3BU ebq7U3fbyqhFURWUMwHTVxxlrery3GStxtrsXqDWlqfcXzwWuk49J1Swn1PthNmo9+vt8LnqakZT RB0ELeTg8kr3aK37rrJbBS1LHyubwHA+FwW6O1942/uEcVeRUUko/u6pjCGOd5C6HbrYjUOsLS64 mWC20zsek6qaf7z68dk2ajW7hbp3XVNybPJI5kbfyMBxhdnorf6ts1nZS1THSyM46s+FG25m2950 FdW0t1a2SCQf3VTGD6cnuBnyuo0BsPqXVtnFxElPbqd+PS/FA5kB88JtdRrNf7p3XVF1FQ6VzIm/ kaD2Xc6L+IGstFmjpKyN0sjOA7OcqK9xNvL1oW7/AIO8xNMbuYqiMH05PfBPn6LrdDbC6p1VZo7l G6loaeX/AHYqi4OcPBwB2RNRr9fbp3TU13bVeq6NjDlgBxhd7o/4hKm1WaKlrYnyTM4Lu4Kh7cHQ t40RenW+8Qgc/wB3MwExyj3aV2mithNV6psUN0hNHRwyn+7ZVOc17m+HYAPBTdOMazXW6Vz1JehW OlcwMdmMA/lUkaQ+IiW3WWKmronPnYMF3cFQjrrRV20dfZbZd4eiRv5ZGg9Eg92ldxo3YTV2prBD dKdtHSQTE+myqe5j3N8Ox0ngps4xp9xNyK3V18FTUucadrgWx54xlTFafiMp6W3U9OKZw9KMMAAw BgYVdtY6Ruuk77Pa7xAYqiM8EA9L2/5mnyF32kNhtY6ksMV0p4qSmhlJ9OOqe5j3N/zY6TwU5Go1 WvtyazVeoG1dW4up2PBbHnjAKma2/EfSQUMUP4ct9Nga0dPbAwq16t0vdNL3ye1XimdBVRHsezh4 c0+QV3+ldhtZ6gsUN0poKWnhmBMbKmQse4e+MHgpu1ZJPTw643IrNTakZW1bnOgZIHCPPGAc4U0U /wAR1vitzIfw5HSwNA6c+FWLUmnblp29T2y7U7oKyI4LSOHDwW+4KkLTmxGtb5YornT0kEMMo6mM qJOh7h79OE3dpxmtOSm1I12uTfGsABrBU9I4/wAWVZan+JC2OjYHREEDnLcqpt/s1dYrrPb7pA+n qonEOY8EfqPcLqtDbWao1pbqius1E00kP/tZndAefZvuru27XqTSQdwt76m83mmnoXOZDTu6mDtz 5Xd2n4jqNtoiFUzNU1mCSM8qptdTS0dXLT1DemWNxY4exBwuz0DtfqbXVFUVWn6SKWCB3Q90koZz jOBnum/s/pbma8rdY3SSaokd6WSWtz2XDLc6r07cNL3me13eERVcOA5oORzz3WmTLe+zHWtx0Git TVulrzDXUEha5pHUAfzD2VpaL4jba61RumjH4sR4OR5wqeRtc97WsBc5xwABkkqUKPZLXVRaWXCO zYp3xeqC6Vod04z+XOc/RZVsK/eC6zauF1jlOGuyGk+Mqa6f4ibV/CmyPYPxfp4ORz1Y91TySkmZ UmF0bhMHdBZj5g72x7qRG7M66Fnbcf4HIad0XrZD2k9OM9s5zjwrtNNy/eG6f2x/jDZHEdXLM/4c qbG/EHZjbfVa1v4wx4ORzn7/AHVODTzCYR9DvU6unpwc59sLvKjaXW9LZ/4k+w1DqT0vWL2ODiG4 znAOeybNOmbvJc4tY/xdsjiwuw5ue7cqanb/AFj/AIY6oYGfjTFjPTzn2z91TRsMr5Wsa0l7j0ho HJPsu3q9q9aUdmfc57DUijZH6jntIdhuM5wDlNmnXUe81xp9Zm7dZdG52HNz3blTPVb+WAW2SqgY z8cY+kOx832z91TSKCWWZkcbXPe9wa1oGS4nwF2Vy211lbbTLcK3T9bFRxN63SloIDffgps07a07 z3Ck1kbtI5zo5HYe3P8AhU01m+enm22oq6NsYrnxgdQHzH2BKphBDNPNHFExz5HuDWtaMlxPYBdZ dtvNX2a2y11zsVdT0cYDnyuZ8rR78FNpxSBp7eatoNZSXKZxfBM7Ejc+FNFw3v05FbKqroBGK2Rg yR3cQOM/ZUtghllmZHE1z5JHBrWtGS4nsAunvWhNVWW3vrbpZK+mpGY65Xxnpbn3IVuW7upMdTSS 9Lb01dv1hJX1TnPpp3YkaT4Uw3XerTVLbayqtZjbWTAOJBGXHGMn6ql0MMs0zI4mF8kjg1rWjJcT 2AXQ3jRuprNQuqrrZq+mpGEB0skRDW57ZPhORxSvoveiptur5KutcXUlS/Eo/wBVLN53m01brXW1 Fl9MVc563dP+J2MZP1VMIYZZpmRQse+WRwaxjRkuJ7ADytzdtNags9IJ7ra6+kgJx1zRFo57c+E3 u9rpMugd6ZrZqqeW4PL6SrkzJk9jwMqVL/vBpy12esmsfpipqHGR3T/iceC4/VUoBIf9VtqW0Xat oH1lLQ1U9GwkPljjJaMd8kJs0nbbnep9v1HOLrIXUVXJ1OJP5T7qTb9uxpqy2StlsLohUTvMrg0j lxGCVS+lhmnqI4qdj3yyHpYxgJc4+wHlbG7Wm8WuJjrnQV1JG84a6eFzA4+wyE2cU87Zb0/gL9UR Xh3VR1che5xP5XHypFv+5+m7DYKt2n3xtlne6UtaR+Z3chUqa9xd8pwVsWUdxfQGsFLUGizgziN3 Rn/mxhN97TisPtTvMyjvFRSXp3+xVUheHE8Nce677Uu5enNPadn/ALPOja+R7nYbjgu5JH6qntNa rlPT/iYKOqfTgkeqyFxbx35Awvo623V9OZfwdYYRyX+i/pH64wry73ThvpYraXeSCG5T26+P6aOo e5zHuOQHHkj9V3Gp9ytN6a009lgdH1nIa1pGRk5/bJVMqZk8koZAx8kh7NY0k8cngLKSSflspcD7 EEJy3dmvhZzafeGllqp7XqCRopp3OcxzzwM5JC7HVO5Gn9K6XFNYZGHALI2jHyjOf9VS+ASPkDIm ve/uAwEnj7L6TSS4w95z7OyE3u7NVaXafdyhuH4iyajLBBJ1emX8tIPdpXT6t3GsGkNKspNPyRnp Z6cTWkEt/wDpyqXwySCQemXdXcYHK+s9TPI3Er3HH+bOVLWtbfXUdwdcrnUVTuDNIXn9Vqs4Cbjk 98rHGVlpZr4VqvT1tttdW1tV6V2dKYi1zhgx4BHH3ytT8TkdrlvtJc7ZViV1SzEzAcgOB4I/RQPR 1UlOcxvLD7g4K+9VWz1Qb6szn47ZJOFMcZjbr5MrvW/hZT4XJ9P22011wqq307q+V0T2OdwIxgt4 /dct8TEFvOp4LjbaoTtrI8ytBz0uBx/RQlSVk9K5xilMee5BIX1qq2eqaPWnMuO2XZVx/X0uWVzu 6sz8Lb7HbNP1lwnrei5zyuikjc7hrRgtwFw/xI0FHT6sbXUFWJ465nqub/kcDjCh6kuFTS59CV8Y PfpcQsqyvqato9eV0nT26nE4W5bjLJ8ueX7WW/C0PwwxWa36YqLpJX9NdVOMM0T3DDQ0/Lj9Co/3 5oae2a2FVRVYqYKvpqcD/AQ7lv8AJRBbrlVUmfw0z4snnpcQvpXXKrrnNNRO6UtGASc4THKzG4/F NfvM/mLly1Gn9xtB0Ebrn+FjAaT0kdTXAYI5X0qprHo/bh1qZXGqpwx0Ye5w6jk5OcKmlBdq2haW UtU+IE56Q7Az9l96vUFyqIxHNUyPYecF2RlYmElxv0ttu/6s3U7eaE1hZqS4WWobZ5SSXuiPX1HH IIdwOV1VzqbVpHbT+Ftr21PpxGNj8jLnZzkqndDfrlRNLKaqfG0nJDXEBfSu1Fc6qD0qipfIzOcF 2Vrc5cqXetRbehuli3R0kymqar8JXUzmkkHBjePI9wR/VY7haptGltMizUBY5paGgB2QBkHOfuFU K23qtoJDJSzvheRg9LiMp3W+11wLXVUz5SOMuOVdzaaXDgrrLulpKAtrBS1tO4HIfgxu7H9CMr5b h6qtWl9MMstIQ/pa1gHVnABBHP6KolnvtwtjnPop3xF35ukkZTu+oa+4vDqqV8jh5cVZZ8nH6XCk ltW5+mKOppK78JW0zg75X4LT2c0/QjK+G4Op7XpfTsNmpndfo9AALsn5XA91UezakuVqe40NRJEH j5g08FK9ajrrm/rrJ3Pf2BJ5TacNdriVgt25WnbdXW+4fhqqCQOIa/BH+Zp+48rz691Na9LWSktM D/UNO5hHU7JHS7PfyqlWHVN0s/WKCpfG2T8zQeCvne9SV90m9Sqmc+TtlxSVeOvS41xp6HcW02q5 Wy5mnfE8dYY8A9J/M36FaHeK+W+06OOn4ZeuVrBGCTyMe6rBp/V92srXsoaqSJj+XNacgn7L4X3U 1ddqj1qyYvf5JTHLjds3x7mk16V2gv1ZLbq6outHHa6gNlc2GRwk6CM8ZBGV3O9F6oLdpJlhZMZJ mMawOJ5+XjlVztG4l+t1JFSw1r/RjGGA+B7LWX7U9bd6j16yUvee5WsM5jlyTy+P8mPFM2lNotTV VbQVFbXU1PZpumVzoKgmQtIyMAjAPZdzvfeKKl0k2xRzGWpa1rQSecjjn9lXm0bl3630cVNFWPMU Teln0HstNqDVlbdqgz1chLyck+6xjZjnz+Wssbljx+Fu9r9PXC27bPoK5rBPMHyRBj+odLxkc/qq uajrLjYNUySOfJT3GjmOHA4LSD/TC9dm3W1BQ0UVM2se5sTQ1vVycDsuR1VfJ77dZq2qx6kmC4gd yr48uGF8bOWG/J+SLB7May1RrDU0THSCWipcPqvnwQ08DA88rv8Acy61Nh1Rp+5VTHmyxy9Mrm/4 HnIyf0KqNorV900pWvqbXM6IyN6JAM4cF1Gpd1Lnf7YaKue58ZIdyexSXVas3ZVntVWS4X+5W246 fr2Noapno1TgM/3fLgRzzzgYXNb9XOkZpBtsbK11SwAnHbgYUEaU3XvVgoPwMNS40wOWtJPH0XO6 v1hV32pfLNIcu8ZWscuN5fMM5zx4fDk68h07zx3XiK+shJJySV8j3XJ0YpFMoUQvCSaSATST8dkA j7oQgR4RhNLyqDhI900HugM8JEJpHugEFCZ5QJHlBRlAd0I+iEAkmjygB3QUIVCPZB4TSKACCgJn sgSEIQCEH6oKA8oQkgEyEeEKoSE8coQIoQRlA47oDyU0sZKB3QB7oQUkDHZJATOECQhHlAIQhAIR lCAKPujwhAIQhAFJPCBwgR5R47IPKPKBjslkJpc/RB2JPnK1135t832Xuec/ovBdDmimAHcLxY+3 ry9NBEM4z3C+FVy5fZjsEAr5Vf5h7Feie3C+nwHbCRQEj3WmCQhNAIQhAx39l2G28YfqqgHH5+Vx 4XRaNuDbbeaepdyGOyUFxdcP9HaG4dPBFM5QVspX1ovbaenYXtf0knw1S9pzW9or7G2C6vhkpJG4 6HgOH7FeLREej7FqOtrLe8NpJD1tD8Za7knA8D2W8suXjmP04zDWdyTTCJ47bGZiDP0nODxnwoX0 0Lsdzbm2+PDqgOYW9JyAw56R+y3se4NJcdUyx09YG0ULQ1pP81t31+nKrUVNWR1TWSMa71XNby7t 0gn9/wB1JdY2aMsbcplK6HV19tti9Ge5vYwGOQse7uOACB9+FzGz1RPVwipqRIOtjywvBGW57r2a kbpbUVZRS3Stc9lG5zmRYAa7OM9Xv2WxZqKx09bE+GrjZTxxOZgDAC52V0jY2+/RTXusoXyYdG/D Tntx24UCfFPK+O82XpPIa/H07LqNL6gt9XuHd6yOraaR04LXE4+65XfeSj1brSz0duq2OEbXes/w wEr1+OzG5a+nj8mOWUw39pG2LlfU6eppZSS90OST+irDvuf/AKqN8x2EvCsu/Umntt9EsFNUCoqG R9LBnlzsKoGrLzNfr7WXKqI9WoeXFcvHlxxyl+XqstyljTHukVkViQsOheEYTSQATJS7poM2gkgK wHwz26iNwNZVkufnAYDhQBGTkKfvhpoJZbi+qmnjgpQcAvP5iO+EonLeu/0mntLxVUxl/EZLafoO PmwO6jDZGtZqPVc15vMr5akgRNbnPSB2XS/EvSUt20bFUR3Onidb3mT0zyZcgDA+q4H4a7fLLdJa ySaOGnGB87u5HKeT/Wcfbn4pbbzTLvZqCk07pyKrmdKKxrnClDDgEnGc/so02OqhqPVk98vM75Ku QNiY0HsB2z9Fv/ieoYLlpGOthuFMz8A4v9Mu5l6sDA+q4v4ZbfNJXzVckjIqYEYLzjJHda8knCcW P8e3leUS5vfqKl01aI6yR8orWkimaw4BJxnP7KO9jKj+0Oqaq/3mcy1kxDWgeAOy2/xRUEdx05Fc Yq6ma2hd1GLqy6QuwMBcr8MlvmkrZ6qSRkVMCMdZxkhTy/6SQ/xty25faWd67/S6co4ax0kza5px TtZ2JyM5W728uFRd9Py1dUOiKZhL35+bso4+Ju2/xC20lzhrKYRURw+Iv+Z/UQOF3e21dSzaNFJB NG2R8JaCTgA9OF08muOOnPwW7y39vdoW22W2tmbY5qmd5Dj/AH78jKhK7XK43ncu5Wa7XD+H0Mcu Zvw7jlzfYE+6l7buxzaSo5zdrjRztAc7rikJ/qFyE+32ndY3a63gVtWyuqHuMbmShjG8Ybkdyp48 pMbK6Z425yx3ugrVaLRTvisdRU1J6TgzvB/nhRZaNZT27dO622SKOKrmnIcYzkH9fspG24sk+jrT I293Gkn6GkmSN57fqoh01YKjVu8F21Fb3xMtrJ3FkkrunrOMcLnu8bG5P2ld/wDEcfW26hEnPqzR B31yuk0pRCi2wENEBGRTuDcDsenuvhu3pip1RpWmt1BUUrZ45Y3kySANw3vyvvpivpqmyT2CWZrZ og6nc+JwPOMHBK6XVnj/AI8+O5+Wa9vZoS3mgj9J1S+pL6dkrnPIJDndx9uFFmmtXi2bmXu00zAy WareXOAHP3UiU8tDt1pqqqLpXeu8F3RlwJLR+UKENsrHdNXbiV2qadkEFE+Zzx6smC7J/wAI+itn 62tY3/kkiRPilm6du6WR5+b8RG79cFQFaNeapvhprHbet7pMMYyIHJ+/sFZvfLSNdrPSMFstctM2 dkjXOMsmGgAYUT/DLp9ls1leWVvourKOX8P1tOW8d8H7qeTL/ixk9xrxT98tpfsDo9u9BNm1FVB1 X0dT257nvgLkNgqKnr7/AHvUReBLXzl8cY5w3Kj/AOKy/VDNX09uZOTTina8tB4zkrrvhRpayS3V NZOOml6sR9R7/ZZ8s44zGHhtyyud/wCnT7yawj0TWR10NWX1swDDT44DQOCo00Nqi5bh3Wejrbo+ 221pLpHRcvJPYDPCx+K6w151BQ3IvjNLU4p429Yz1DyR7cr3aR2TP9kvx1rvk4vLm9XpjpbFn2Pl az1PR4t2dpz0ja47Dp6eKgq5bq5o4MgDSfusapko0BI2hIhmmyAR/hJdglfDQFFWaY0mf7SSRNlj Z/eOa/qHlZ2urpdSaXmt9FVGJ56gyRuCe+QsfGnR7dKUclDS1lJU1BqxGxp63DGcjOF5LjFMNvnR 2xwp5pcNa9o/Ll+CV8aaoi0NpMy36rbNUvGHZOC4r6W6ppdUaQdRW6pMEjmZY9uCQe4wkK9+mqOS jtddS1c5qvTbjre3GQW57Lw3OGZu38UNseKaWUsYHtH5cuwTgL5w1LNFaO6r/WCWrlbh5JALnEYX 1ppYtTaMNHaqv0JxGDG8AE5HIRHt0/SSU9krqSsmNUYgWl7246h0+y8Vzpp2aDpaa1PFNLL6UbXt H5QXc/yXzZVx6N0W3+P1QfWyt/vCTy5xGP5L6NeNS6Njp7NWiCqYxpjeB1HLe37qzW+x7LTSOj01 X0lbIKoxNewvc3HUOn2X5y3hgjulU0DAErsfuV+gd0ukOitAyPv9WH1kkRMmTy55HOF+fd1lE1wn kHZz3OH6lS+msfbYaMoWXHU1tpZRmOaoYxw+mVf6/wBDVQ6WtdsscraNz3xQhwbw1vngfRUL28nj ptYWmWZwaxlQ1xJ9sq+l1E2ptKRu0/WthrI2h8ZxnJA4H0z7q+PXLtPJ6en8L6uja6luZZVGISRu c5vDsDvg9l477S1Y0vZbdYZGUjpXxx9XT8rWYycgIq66LTGio4NQVLXVs7MSYPJe4c/zWd4inv2k oXadq2x1cDQ+M4ySQMY78Z91rG69sZyXen2npvW0XWU9z6KowiSNznM4djzg5WGoqWrjsFnttjkj o/VeyPq6fla3pyeAvjX1kOmtGw0l8qWurKhvS8jy93c/bK++oY6y+aYgl01UsbVwgOZnkk4xj6KS 6kjWjracVmhaqC4BlSWNcwlzeHYPfBysdS0dZHarPbLBJFSGR4aT0/KGBuTwF87tWQae0fBR3ipa audoa8jjLj3K+up2XC86ep6nS88Yq4Rloce+RjH0T4L7rK5Usdz0JJFc2MqSB0kubwSHYzgrHVtH XMoLRa9POipetxB6hhoa1uccfZYXqtptP6VpKC6VTfxMoa0ntl2QSV9NYMuV3sVPV6WljNZEfla4 9w7APPjhYahXyjhvGg44rvDHOXdAcHDI6uoDjKNY0twiprTbNPOhpupzurqHyhrW5xgfVY6graax 6ZoaC5VMYqpCwEjjLg4ElZ60ZdLraaWr0vLGaljsYPlrsA/bA5SQr56goqe+aGpf4tBFO4uiJD2g 4d1gHGVlrNlwjda7bYnRU7MPkflvyhrACBgfVPUNXS2TT1vt1fUsFQ90beDjJDgSVjrmG7V9BS12 lpI3T/7stIySx5AJ/Qcp8Ix1RbqPUWjbebrTRTudJA752g4JcM4WGtP4rHVWu22AQwwhj5ZOoYaG sxgcL06jraOzWa122sqIxUdcQHPfpIJP8l5teRXqqjo63TLmSF49F/khryOf08rXinfbPk3rotXW ui1HpizvulLDO981O752gkEuGcJ60ku0NZb7fYGwRwRxPnkDuB0sxgDC9Ooa2ks9vstvq6hjZhNF xnuGnJK82vo71MyjrNNdEvrD8PJ5Ia8j5vsFfhphrCz27UtnsMl2o4KiR9RAQXsBIyckfZfTWdTd oK+iorDHC2GGB1RI0npHS04AC9GoayktcdhoqqoY2Zk0ZxnuGjkry68hvj6ikqtOCOVlSwUspPJa 1xz1fZMPU2u2OsLFbNR0+nqi7UUE8pnhw57QSM8kfbhZ6wq7rTXWlprGyAU9JT/iZWOPT8oOMD9F 7L9W0dufYaOqnY2ZkzHdOfDWkE/utdrukvctxp5rFHFLDWRtpZXHksGSS77YKzl3Im/h9dY6YtGo 6zTtXdKGConbMzDntycdJOPtlYawud0o71DT2iOH8LQ0wqZmOOCW5Iw364C2t6uNJQ3GxUc87Gyt fktz4DCP6labXFHepb5TmzQxSQXCNlNJI7n02glxP2IKs18ra9OsdLWXUN705VXS3wVFQ2Q4e9oJ 6Qwux9sr46sut1ob/FDaoIjQUFOyaYE4IDiWgD3wAtveq+kpL5YaeedjJWOcS3PjoI/qtNrOmvb9 RQxWqnZJR3JkcMsxP+7DSSc+2QVnS7fXWOkbJfNVadrblb4J6lkjsPe3uAwkA/qvnqe93Wh1LFDb 6aN1too43TuJwR1u6QAPOFu75XUsGorHDLOxsjXPcWk9gWED+a0GraW+O1I2nt9K2SguTomyTZ/3 bY+XZ9sjstY6+Uy24L4odOWeYafutZTMEhrWxTyAYLo+5BUq6HrrPV6b9LT0McVDTtDGsj/KOOwU XfFpWRO01bKON4NV+J6+gcnHSQtt8M9HW0e39Uy4U80ErqhxDZWFpIwMcFZ+YZX9KqXqWyVl517W 0Ntp31FXPVOaxjBnyf5K4GyG3dToG1QQ1lxL5qhhkkpekYD8c4P0XA7G2aaHdq6VlZRzRfJKY3yx FoJ6vBPfhSjaaq4VO8FzgnbL+CpqUekS09OXAZwf3XXyzeeV+nLx56wxx+1WPihaP+02vcPIZ/5Q oeU0fFFTyM3DrZHsLWPLS0kd/lChZa/yP9v/AEn+J/8AHE7/AAn6Tt2oNYVNXdIGzihjEsTXdg7P BVnn6juDdYNp20eLSJxRCXIx1nB7KA/gxnhjvF5ZI9rXuiYGg+eSpuLLp/bT+EGhH4R1cLl+IJ46 BgY++R2Xk8du7t7LI+NRtrpyfdJt4fQRmf8AD+uWgYaX9WOrHutpFqWtfrH8H+CItPrGiEvHT6gG cfst62qhOsnReozrFGG4zznrJwuWg/iTdafwh1C78OK91yNRkY6CMD9cjsujk8sO2mm2brS3ZlCw TfhhUdH+ASFxBdj9Fu6HUVXPq6ShfRdNrdI+kjk46S9gJIx9ltop4jrmdokaXChY3GfPW44/mubt z6/+3LbU+geyCnqZa51R/hLXghvPvnIRrprbbtjpuj3Xq7tBRtbKKZlQ2P8AwNe5zg5wH1wt5atT VFw1W+3zUJZbJHvpY3n8rnMBLhj7LcU8sbtb1jWvaXChjaRnnPW44XKWCWtfrSC1TUD2CgqJ6p83 joeHdJ/Xq/kt4SWXbllleUkeCw7Xaat26dwucFE3qjhZPFEeWMe8uDiB+i6G26kmumpZbbV29wtl T1wwueMteWA9X9FuKSWN+tLm1j2l7aSFpAP/ABPK5TTtTVTavpLXJb5YXW2WeaWV3bpkDukj75Sz pMsrvpqdIbVactO5l3uMNJ1fh2slp4nnLY3PB6iAuptOoX3u+1Fqr7c8W2qY9kJkblkgbkOW1tcj X6rvzWuaX+nAAAfYOyuX0nXVVRqiltc1BLE61mcyyEcfOD0/oQVrjNXa79NPoPabTVk17d6+KnMp pXNdAyXBbF1tJOAuttN+Go7lVWi6W1xt9VE4xGVmWSsHDse62tlLXai1B0uBLvSGAfZmFzmi6+as vtPQPopYXWqKWGZ7hx1OwR+4GVyymq6bc5tztJp6w6zvdwbEZzSTYpo5cObE1zAeB75J5XXWi+Qa sqq+z3W3ONFUxOfEJmZbLH2JHvytvYS1941GGODiZWDAP/zMLmdAVjq+70dOKSeL+FUr6aZ724Ak JHy/stWTsaDbPabTunNS3u6NiNRJR1DmU4lwRE3pDuPrz3XU2y60Ou2XOzXi3ONNK31Imzs4dGeA 4Z+ueVurCOqTUzW/M41bsAd/923C0O3txbdbpAIqWaL+G0f4OZz24AkDslv6f6rGXRv9leqPY2ru O5FxtVM5zbJR1GHTu4JZwekHHcZVmqOy2mz6GrrRaI4m0tNA+GRrWgZcG8k+5K5o7gWfTd91DQXN wEr61zxlwGWljRhdTpi62i46brbhboGtoep/qtB6g4gAn+S1jNZSs53cRP8AD5oSz0VqqtV1NOZ6 9k0jIgW59IN/yj3OVz+/uqbhqLTktBJZauOkimErZpadzQ0DzkhS/t3WU0GhbrXWyL06VtTUTQx9 8DAOP3Xw271ezXn8Ut9fBHJTxRBr2OaCHA8dl1ymt2z5c9/vrfpVvZ3a2t13emmVksNmhdmefGOr /haT3+qtlerBaLVthdbRbIYm0UdNI0tA46gOf5hc5pPVmnNI0Nw09N/cNp6uZrWA4HS45H9V21sq rRPo6eqhiza3tkc9rnF3UOzufquUlxz1WvJZcbqua2lItOztPU08QcYmSyBobknDz4/RcvV7ymlg lfNaJ2xN+V0rqchgzwMuxheDT+5rtK2WakgtlSbTTzyCGo9Fxja0uJwXdu5wu+0RqWh3Is11p6ul jkpQ1rJI3N/Nnn/RTCcLrJvLLl3HNbT6Osdqop9ezta+apD542huBC0kggffK3F7sun93tK1UT4x FW0riI6hrQHRP7j7g47La0lGy3bTS01O0+nTRvDWjkhrZCcfsF6dCXCiu1wvlwtePw8whOQMdTgw glSb+XSyXbgNodtrTomyv1Nensqa0NcQ7pw2JuS0jHnK3mpdN2DdzSMr42tp7jSFzYqhjAHRv74I 8g+y3d4+XauofgkNb1kD2EoJ/kF99CVdDcp7/cLX0/hp3MOWgDLhHgldLJx25b/e4uF2i21s2i9P O1FejHV1kkfUXvb8sbTx0gHg8+V79YaR0/uzpA1dE2KmudK1wimjbjocOekgdwf9V0l6e2PaQPkH yNiic77CVpK+m3lRS1cN+qqEh1PNP1hwGA4+mASP1CnHrbe+6oXc6SSiqpIZQA9jix2PccLxrpNd AN1DX58zvx+5XOj3KzlNWxMbuSpl+GjR9u1Pq2eS7wOnipIxLG3Py9efI8/ZTxrrTGldVWq9Wb8D SUdfbyXxOgY2N2Q3IPHf2XF/CHdad1vuVrFOwVEchn9YD5i0gDBP6LVfERqX8FrAG14p6uKMwzOb x6gPOT791f8AHx5ZW2+k/wArLjrGfLQ/Droe2X/WFY68wmdtva2SJhx0Od1EHqGOePCl3XmjtI6p sF7t9NQUdvuVsc5zH00TY3dQbkZwOQfZaj4U7tSVNpudCKdja6OYzPm6eXtdjAJ/Rcnv5qf8FrKU 2n/ZqgRmnqejj1Oe5Hk8rp48ZnlcviM+W3CTGe61Hw5aFtWodTV816iNQ23sa+OJ2CxziSD1A91K GudD6P1Rpe8wWugpLbdLU57mvpYmsd1NHZ2ByCvN8K91o6mxXGhZTMZXwyuklmDR1Pa48An6LjN8 NTi26yqH2X/Z5HxmCqa3gPIPcj3wrjMct34jGdylmPzWu+HDQlq1BqS4z3uAVMdBG0thcAWOLsg9 Q84CknWe3ejtSaYrxYaOnttfbpXZNO0B2QcYPuCF9PheudBV6Xq6aGmjjuEEjjPKAA6QOORlcTup qMWzXUjbATTtqHNiqWNPDn9eM4/VZxxmUyvxG95fkxw97SE/QmhNE6Vo33azU1cHkNM88bS8kjPJ wtRrPa/SN+0IL1pujitbo8zB8IyHtzhwOf1Uj6tqrRQaVo/7Swsr6Z3SAJQBl3Tla+8SUsm0lXJp +KOmohTPLIm5cOnPIBXLD9ssZflrO6lv05FukNsdOadopK6ipq8lvSZ5Dlz/AKlazcLafTN10QL7 pClbQTsb6jWMJLZgTjByePuuQ2sv2m8V9HrOmbVctdT+r2HcEKebsad23DX2BkcFvaxvTFjPydY4 Bzwutxky4lv67iPNH7O6Y07pltXrenjq62UB7mudgRn/ACtxjIxhcjvHs5HbnR3vSEQktc5a11O1 2fTJIAIJ8HKm7cWno6uWz01x6TTS+qCHO6QT6ZI5+4SiiDNpo4urrbHGxrXHnIEgwVMsdSZMePyX LLKX4R9pLZnTdh002o1xE2prZSHkeoWel46Rg8/dcRu/s46y1MVz0rG6otFU5rRE05MLnHAGT3BP lT/rujt9yqrZR3R3TTyRy/4y3Lg3jleZ8eNq7c17i8sbCMnnOJArw9Ly3bEd6R2S05aNMsn1wPXr pyHkMkLPRyAOgYPOD5+q4bdrZqp0/coqvTcclZZqt7WxNBy6F7uzSfIPgqxGubbQ3itoKK5Pc2F8 MpAD+jLgOOV5o2uO3VkjlcXuD6cFxOc4kCnH0c0baU2P05b9NU0+tJZjXzlri2OQx+nnA6MecHz9 Vwe7Wz9Zpy7xS2CKattNY8Ng6fmdE49mOPkHwVYvXlrpL1cKahrpZImOgkcwsk6CXDt98LFwc/Q2 nxKS9wlpgXHuSHgZVmHpvG79ot0lsTYINN0k+sKmqZcJ3BxbHL0BgdjDSD7HyuJ13sxX2jV1JQW2 UPtlxlDKaplyRET/AIXkZ/Qqwm4NqhvVw/CVFRJCWUbpYuiTpy8HjjysNT1xt+gbPcpB6j6X0ZTn ucDlSYbsn2zM57y9OAqdkNFWyipIrxcK+mrXRtLzHMCC7yRkds/Rczr3Yv8ACVlpdpWqMtHWubC4 1L+WOIyHZA7Y+ilXUsmkdc0NDU1d1mge1gLRA8Bw+hBBW71pWw2LS1srGuM0FG+JwJ4LmgYz+yzh jyumsrMe76RfVbG6Qt8FNDdLxcKaskYCQyVp584y3BGfouA3h2gOjqWnuVpqpay1ygNc+bHWx57Z xgYKnXVlNpbXEVBW1F3mhcIx0CneAeecHIPKw3xp4httFCHF8THRgOd3IA7rUxmWeOMc7llMbahD aLZ7+11pqrteKuWjtzcthfA5pcXA85BB4Xo1vsXX2u7W2Gx1Zr6GvcI2yy4a5j8ZwccEYHdT7ttZ 7bb9um0tvrXTUM7HSeqcZYXAEj9Co605q2ui1dQ6YnIuDKatcaebIaXtDT3z7BY8c54c3Xcnk/G1 03w+WSlMTavU9RBM5o/u3Rs7n2P3+i4PdDaCu0fUU8tDLLcaCpIbG9rPna//ACkDv91YncLS1Hfb tRz1V7dbJGNb/dBoJfz75/Rbq+kR3HTNOWOc0VAxLxg4jP6rpcZ1pjG7m8vtAmm/h2qK60U1Tdr3 /D66YEimEAkHuPm6h4+iiPXejrrpG7y0F1hLXt5jkA+WRvhwKt5uHT3Kpucz7bWmmdQUzKlrA3PW erBH04XP/ETRxV2gKKpmjaZ2Frg/HIy3nlMcOWUx37XO8MOamjs+e6+ZXsrGBsrvuvG7uubbEplI 8p54UQkinlJAk/KEIAoQmgQR5R54TVUkYQhAiOUEHKyQgxQUwEiiDhIpoPfugRQmUiEAhCEAhCFQ so8JpIH/ACQgoQLuhPHKRQBQhHY8hAJJ90FAfdCB5TVQkIQAgD9EuU8oQLymgpduEDKWEIQCP0Rl A9kCQU/skgfhJCEAhHhGCgEIRlAeEI8IQHhHcIQgPCPuhHKA7IQkg6l574XiriDSydR8L7udkLy1 vNO9ePGdvVlemobgleas/MPbC9DDl59156s/OB9F2ntxvp8QsSsliVtgk0JIGhATQNfaFxb2XwC2 NooJrhVxU9M3rlkdho9kHpbcaiNnQJCGfdfaO61DYuiOUhvnDuFZrQO2untIaZkvmpIYa2ZkXW8z Rh7Gj6NKx0DbtMag1JU3OSz28slHpxxfh29DR2Hy9sptFaqW6VdO4uhlc0nuQV7otQ3CNp6al455 PWrM1Gz9FV7hOuUlBSC0kNLKdkQbGOkDOWgY5W8qdM6PfqyCihsFqe+IFsjPwrQ0E/Tz+qIqg3U9 yLcNqpB/315qjUNwc0xuqZOl3f5+6uTd9MaQt9ygpHaWtMhlaXktomktA88BKPbzR9XeYpIrFa3M ELnBrYB0848K7NKX015q6TLoJXMJ8grGG8Vban8QJHGbOerOSrVVGyenxrFlwFG2ShkcCaUj+7Yf oB4XEbvaM05R6/tVDT0UFFSvhLnsgb0B5z5W8MblvXwxllMbJflBF0u9ZcHA1Uz347dTs4Wrd/xc lW8u+1Gl9SaQNLY7fT0FfGwOjmhHzOcBwHEnsT3VUr7a6iy3Wqt1c1rammkMcgacgELDbXFCDwUi UUBIp+EkDHKePZIAYT4+6KyYf3XTWDVNxs0Hp0U7mD2C5oeFMWzG0NTrGdtddeuntDDk+HSfQfRK jgr5qi6XhnRWzyPjH+E8BfSw6tuVmiMdFKWAnPCsteNkdGXS11lLYITTXFo/u5/Vc/kfQlRtt9sR cbpfJ26i6qW30z8Oxw6UD+gRKjG/aqul6YGV073xA5Dewyvpp/WNzskJioZixmc4xnCsbfdjdI3G z1sGm2OgubW/3c75nPHUPGO3KjnbfYy5Xi9zN1Ix1Hb6VxEgBw6THsfAVRGmoNW3S9sDK6d8jAc9 J4BX207rO52KAx0MxY084PIVhtR7FaVr7RVx6YEsNxY3Mcj5y8Ejxj6qPNtdjLlertKdSskoqCme WSNBw6Qjvg+B9VBHOodZXa9taK6d74wc9I4GV7LDr68WmnENLUEMHg84U76p2G0zV2KsGk/WZcYx mN0kxeCR3GPquB2v2OuN+ucsmpGS0Nvp3lr29nPx3wfA+qu06chc9yr9WQGGSqIY4YPSMEhfOzbi 3m2Q+lT1B6R2DlNmsdhbBUWKqfpCSoFwhy5vrTF4djwBjyuE2u2QuOoa19RqGOWgtsDi17T8r5CO 4B8D6ptenI3bcy/XCmfTy1JbG4YPTxwvjp3cK7WWD0qN4Dc5yeVNettgrG/T9RNpGWpNfDkhskpk D8f4QMdyuI2r2QuGo6l9TqJktBbYXdLm/le8juPoE3pNzenOVm7WoZ4yx04GfIC1dk3Bu1qqJJoJ i5zzl3We5Uza72AtQ0/LVaOqKmStiJJjmk6xIB4HHBXHbUbIV+ppZKvUImt9siJaW/le8jv37BNn U9uE1Vry8aia1ldMTE3noB4Xq0xuPdbDRNpqJ7QxvZS1uD8P9vg08+t0bUVM9VCSXQzO6vUA8NwM 5XKbTbIV2qJJazUInt1siJaR+V73ecZ7AJu/JNfDR127+oamndF6oZkdxnIWg03rq52CaploZP7y d3U8u7591MO4ewFHRacdcNHVVVVTwuJkimcHdbR4bgd1FW2+2l31pf3UUEMlNTwuxUzPaR6fuPul vW2pZvTmNRXysv1yfW3GR0kzhjJ9l1elNzrxpy2R0VC5piYMBdbvjtHa9AWe21NurKueaokLJBMW 4AAzxhefZzZSr1nGblepJaCygHpe3AfIfduRjCtlnd+Wccpl6cJq7W911PLG65SktjOWNB4B910N g3bvtpoI6ZkgcxgwC48ld1uVsA202EXHSVXV3H03H1YpunqI8dOFnoP4faer08bnrC5zULngOZHT lp6B/wAWc8qNdOC1Bu5frvQmlkm9OJ3BDD3Xj0pufeNPsc2nf1g+HOPCl2+fDpa5bBV1WmrxW1NZ G3MbJw0MPnkgKHdtttrnrXUv8NgHowwvxUTHkMAPOPcpunT5ax3GvOpnt/GTERt7MDuF69HboXfT cBjgf1s8BzsYUt6p+GujgtFZJp671VTcIR1NhnDA0+TyOey12jPh1iq7A24aqvEtBK/5hHTta4Af Unyp2nSKdYbi3jU0zXVkzhEz8sYdwF79Hbq3nTcBigeZGeA5xGFJ2q/h0pINOVVdpm71NZUwt6xH O1rWuA5PI84XKbU7E3DV0D7hep5LXbACGODAXvI8gHwnZ047Wu4941PK01czmxt7MDjhbHRu7N50 3TelE8yt8ZdghdFu3sdPpK3R3Gx1M9yoQMyl7QHN+oAXz2o2IuGsbcbnd6mS1W0jMbvTDnv+uD2C vfslxvpxOv8AcW7aulH42VwiH5Yw7IXCk5JJU1bv7IVWjaOO4WiomuNv6cySOYAWn7BQqRhLL7XG y9RlE8xvDmkgjyFLGh947vpygFNkytbw055x7KJFIe0e2Fz3Eujo6V/4aghx69SW56c+APJUlaGu dybtqmsElXM8Mbw1meAt9o3ee76foRTZMrR2Jcuj3H+HmbTenJLnZ7o+5GAkzNdE1ga0Dk91we02 1tz3BuUkdM8UtBD/AL6qc3Ib9APJVu5NszVuo+et9ybxqiuE1VM9rW/lYCcBdJo/e672G3imLTN0 8Z6sHC2m5fw/VWldNG72u6m6tiJM7TCI+hg8jk5XGbTbV3TcO4ysp3ikt8H++qns6g0+AB5KXZLj 6fLXG5d31RXieplexjfyMDuy6nRm+N1sFtFLL1TdPZ3Vg4+q9G52wNZpHTJvNuuf8WhiJNQBCI/T b/m/Mc8rlNpNqrpuJXStpnikt8P+9qnNyAccADyU3TUr5a43Ku2qLkKmoleGt/I0E4C67Re+l0sd sbSzNfMW8Bwdg4+qz3D+Hu66atMFdaK0XkOk6JGMhEZZnAB/Mc8rc2f4ZK+az09Td9QU9uqpBkwG DrDfp1dQyf0U3V1Eb663Ku2p7kKmaZ7A0/K0Hsuy0dvxcrLaW007XSvbwHdWCvjuFsBeNMW6mq7b VtvDZHhjxFD0dGcBp7nOSVurZ8MNyltkFRdL/SUFTI3qdA6Au6T7dXUP6JumojjWu5t31NdBVzTP aGn5Gg9l2+kd/bjZ7UylqY3yvbx1A91pN0Nj7roa1RXJtZHcqQn+9fFEWiMeO55ytloD4er7qayM udfWQ2mKXBhjmiL3PB7E8jGU7iTV9OT1rubdNR3j8ZJK5nScxtz2XeaU+IGvtVojpaiNz3tGOrPd RluTt3d9B3z8DdIw+J/MFQwEMlH0+v0Xd6G+Hi/6kscNzrKyntUc/MUU0Zc9zfBPIxlN01HJ6x3L u2ob3+Nkne3pdljQeykXSvxCVtrtDKaojdJI0Yz7qJ9xdAXbQ19db7rHlpOYZ2t+SVvuP+i77RPw 8ak1JYYLpPV01sZOcxwzsJeW+Hewym6ajltYbmXW/wB9/Hvmewtdlgz2UlaZ+Iaqt1njgqY3PlYM E+6hrX2hrrou/S2y7REOBJilDcNlb7hSFo34eNUahsEF0fUUdAyflkNR1dZb4PAxym11HM6t3Put 8v8A/EHTOZ0uywA9lJ+nfiIloLPFT1Mb3zNbgkc8qDdbaNuukNQTWq7QOZM0/I7Hyyt8OapF0n8P GrL/AGGC5iWhomz8shqi5ry3wcBp7ptNRz+qtz7retQC5Omex7X9TADw1Snpz4i5KWzxw1UTnTsb gkcglQjdNv7/AEGr/wCzklDI65Of0sa1pw8Z/MPp9VJkPwzasMTHPr7Qxzhn05JXAj9mps1HIam3 Rut31F/EjM5pa7qYM9gpXsPxGmntEUVTG50zGYJxnlRJqnZ7VWn9RUdpmovxMtWQIZafLo3HyM48 dyuzZ8NGr+kE1VoaSMgOncD+3Sm11HJai3Uu1y1ILmJXNLX5a3Pj2UvWf4jo4bPHHOwmoazByM8q BNxtvb7oO5Mpb3A3okGY54suif7gOIHI9luNu9ntU62t0ldbaeGCjaelstU8sDz/AMPBymzR3vce qvesqa7XEmSGGobKIzyMA5U603xIUAjaHRuHHloVfb5tVqm0apgsU1vdLVzkCJ8IJjf7nqx48rtz 8Net+wNrOPP4gj/8VN/aajq9Qb/Qz3y3VVJHiOAnqcG4JB7hbm5fEXRSRxiFpBL2lxAwcA5wq3az 0Ve9JXw2u60zvXyGxujBc2Qn/KccruKP4fdc1dnir46WlDHxer6L5umQcZwQR3+iuzUG/e5NNr2W gFNEGinB+bpAJz4UPL0VtLPRVUtNVxPhnicWPjeMFpHghedS1ZNOk0Nqqu0neY62hkLcEdTc8OHs rPRfEbQmzA9JFX6eMFv+LHuqhU8MlRMyKFjpJXkNaxoyXE+AFKY2J1220NuBtsXomL1en1R1gYzj p9/oor7s3fuserjdjI4gu+ZufGVNR+Iu3fwkua3NT6fHHnHuqhChqXVv4YQyGp6+j0g09XVnGMe6 kit2Q11R2U3KS0g07YvWcGSNc8Nxn8o5yrtNPfTbw3WDVpu/qOcHO+Zue7VNM3xDWs2h8kQH4v08 DjnP3VQYaWeSpbBHE90zndIYBlxPthSHdNm9b22xPus9ncaRjPVd6cgc4N9+kcps021u3hulHq83 YyOLXu+Zue7VNFX8QNoNrlmp2NFa6PAd08/uqfQUs087IoWOfK9wa1jRkuJ8Lv7rtHrW1WOW6Vlm kbSRN63lj2ucG++AU2adBZN4Ljb9YuurpHOZI7+8bnu1TNct/bKLZPNRsYK18eOoD5ifuqe0lHUV VXHDTsfLNK4MYxoyXE+Au3vO1WtLPaJrjcLJURUkIDnuyHYB84BV5W3dZ4zWnVab3juFu1g65TPc 6GV2JBnwpmu+/NjjtlTNQCP8ZIz8zW4cT4yqcUtNPU1UUFPG6WaV4YxjRkuJ4AC7C/bbawsNtkr7 rY6uno48F0rgCG5+xV5b9nGTp3Ok95q62asfXVDi6nmf/eDPhTDed9bFT2uqmtojFXK3OQMFxxjJ VN6WmqKqqigpo3SzyvDGMaMlzicABdVftvtWWG3PrrxY62lpGYDpXNy1ufcg8JvfdOKQ9Fbz1dq1 XJWVbi6lqH/3gz2+ql+/b3WCktNXLaTEKqb5iW9y7Hc/VU2o6aeqqo6emjdLNK4MYxoyXEnAAXRX /Q2qLBbvxt5stbSUgIBlkZ8oJ7Z9lORx60lDb/eeptOqJp69xfR1T8yDOcfVStqbe2w0NlqpLL6T aqYlx6cZc4jufr9VTmipKmtq4qalhfLPK4NYxgyXH2C3d+0jqKw0jKm9WitooHu6WvmjLQT7Jvd2 cfhnf9SVF4vU1bUvJfI7qPKtbozdLR9JpGjoY2wxxiBrZYwQA53Th2R9VTe3UFXcq2KkoaeSepld 0sjjGXOP0C2160zftPwRy3m01tDFI7pY6ohcwE+3Kb+V49aWZ0Lupp22S3izzBrLW6d74Gk8Fru7 fsugo9w9D2CjrJrHT0lNPI3LvSABefGfdU3t9LW19XHTUUUk9RIcMjjblzvPAXsvFjvdojjku1tr qNkh6WOnhcwOPsCRyrcts8G61bqT+Masqbi4n05Zw9wHtnn+StXYtxdFs0zDQRGKOldF0uh6xjkc hUpo6OqrqplPRwSz1D89McbS5zscnAC91baLta4Y33GhrKRkhIYZ4XMDiO4BI5TLLleVJhJOK0mh 9w9L/wAKuOm7s2J9tbI9sUcpyHsc4nC31r1lobSdprTpyKClc9vUWNkJDiPuqaUcNXV1IhpIpZ5n Z6WRNLnHAyeAvvW0VyoY2OrKWqp2SHDXSxuaHH6ZHKm41ray+2m8lHFd6u33Z4FFPI97C48Nzk4X Vax3TsVg0yILA5jTgtY1h/KO/CpkxziQG56s4GPJX3rI6umPp1UUsLz2bI0tP803upfpZvaDeGml kmtGoHD8PJ1GNzjxg9wuq1pubZNN6XZSaeewANLGNac9AVMoJH9Y5Oc4GO5K9lWyri+WpZLH/wDP Gkf1TlrtMsdxZ3aPdyhraeax6kLRA4OEZkOQWn/Dyuj1vuVZNLaWjotOvZgM9OMNOS0KnjYqhjmu 6JeR1NPSeR7j6L41FVNJgOe4j6nKTKTtZjbNPRfa11fXzTuH+8eXfutckSSSeeUlN7u61JrpZ/4W 7hpy02Srq6uo9K7vmdG/LhgswCOP3XO/ExHaptSU1ztNR6jqqP8Av25yA4HuP0UH0dRJD80UhYT3 wcL7VVTLOB6kxkI7ZcThMf19GX7at+FmfhgrtPWvT9ZV1FUWXWSZ0coc7joGC3AXEfEjBbhqyKut dT6rayPrlGeGvz4/RQ5R1c9MSYZnR57lrsLOrrZqvBlmMrmjAJdkrWOXHcnyX9rLfhZ34YZ9P2nS 9RXT1np3WokdHOxx4DQflwFH3xD0tDBq0VdsqvXirGeq8f5XZ7KI6OvqaXPozPjB7hriFnWV09Xg zTGUt7EuzhXHLjLPtLjLlMvpaT4ZjYbXpKW4Org241bi2ojceG9JPTj9FG291NSW3Xf4qgqvxNPU FtVj/KQ7kZUS0VxqaNrvQnfED36XELKprqmtLXzTGVwGASScBMcuMuP2nH95n8xc+sqdN7k6IoGT XF1NCC159Mjra4DGOVlda6w6T25/hFNVmpgbGYml5HU7nJzjCprQ3Kto2FkFS+JhOekOIGV9aq9X CeP05ql7mexOQsam5b8NW73/AFaGr0DoDWVopq+1zMs8riXSPpzkuJ7gg8Lpb9X2fSW2wtVPWCoa yL0o3EjJIOclU7ob3caRhjp6l7GHkgO8rKsv9xqovTqKp8jM56S7IWpZvdS746i3VBeLDuhpOKOq qRS11M4EuHdjx3OPII/qvjuNrG16c0+LNQdHQGhoAOeAQRj9QqjW69VtBI51JUPic4Yd0uxlFzvN bXODqmV8jxxlziVuantjX0uFDW2LdDStNIasUtdTuB6gcFjvI+xC8242sLXpqwxWej6XNiDQBnOO kgjn7qpVpvVwtj3Ooqh8XX+YNJGUrrfK24yB1VM6Vw8uKsuva3H6XFfU2fc3TNFUw1zaaqp3guw/ Baf8TfsQvFuFqy2aas9NaKIhwpywty7OOkgjlVLs+o7janPNFUviD/zBp7rC76hr7k/rqpHOcPJK zLJ7S4fS49V/CtybHba+luApp4JGucGydJA/xN/UeV5Nf6stumLTSWqlIk/CvYR1OyR0nIGfKqZZ NUXO0tcKOpkiD/zBp4KwvOoK+6SddVM55Hck8lXHKT2XGz0uLXU9t3FttqulDcjTPicBI1knSS0/ mZnwVzm8+oaC36SNggkDpGsDASeRjsqy2HWF1s7Hx0VTJHG45LQeMrz3rUVZdagzVcpe498pjlMb tLhy6TnpTZ27zTWyuq7xRC1zhs0jInuZJ0OGcNPIzyuw3sv9DSaUNhhk9SVjGs6nH245VcrTr+92 +ljpoq2X0oxhgJzgey1t91LW3af1qmTqce6vizmOXKr5sLnjx+E36S2g1DUVdBUXK4UUVokxKfw0 7jIWkZGARgHsuw3xvVBDpZljim65mdIyTz8vGCq9Wjci/UFHFTMrHmOJvSzJ7D2Wo1Bqitu9UZqq Que48lZkmPk/Jfa5TljMPhb/AG407XW7bN1tqzGZ5RJJGWP6h0vGW8/qoG0VI61byW2O6uELoKuS OQuPY9JA5+q5mz7p3630kVMK1xZE3pbzzjwMrmL1qGe43OSukf8A30juoke/up4/18d8a2f835Vs d2tI3/UF3oauwCN8LGAPzIG/4s5x54XRaxudPY6WwVFe4B1LMx8jR3A6ekn9MqsFt3ev8FLFBJUu d6bQ0OzyQtdqXcG4XxrW1UpcGjHc8reWdy1y+EwwmEsnzdrVaqsVdqK42+42C4tjoqmP0astAOYu XAj35wMfVcrv9dqNmkWWxsodUMAJx24GFBmmN1L1YqD8HBUOMDeWhxPH0yua1bqyrvlQ+SZ5Lnd+ eExy4Zcms5znH4cvXlrqhxHkrxP78L6yOPVnK+PlcW2IR4TSHZRAkmU0GPZA7oSQZJITVUh3TST7 oEhCaBIQgoBBQg90CCPKEIhZT8ITQLCEI8oEEHumkqBHlBQO6AR4QeChAJHlNCAS8poKBBCD3R9E ABymjyhVKSP6J+UjygO6AmkgEu6ZR5QCEI/VAh2R5QUBAZSCD3QEAEJpIH2STzwlx3RQEfRCaIR4 R4QRyjygD2R90eUIDuhCAgO31RkeyP6owg3y89Wf7l3svtleer5idleTH29FvTVR/nPlfCr/AN5+ i9LMdZwvNVHMhyus9uV9PiEnd1kBwsXFbZYpoCEAmkmgBkrvNqIw/VVJ1AHGSuEacLqND3YWm8Q1 LuccfZBbfdUlmzdzwMH0G5/8Q/0yof2Mra6W7upqNpLC4ODs8BSjp/XNprLKYbu+OWllb0lrgHcY 9uy8W3lXpLTlzrZ6H5KV7i5hdguB/wBAr8aZs7TQWzR0QaXNNSWHBz3djuoc2+ZXN1/dG3WYTVba gBzx2I8fyW1tm4NJctS1EjKwtoo39Lffp8rcwXbTb9R/joZRF0gucY2gdbvc+6s1JZWMpblLL02m u9RWywCd9aQ2aamkbG4DLiSCA0fqVrNoHVBt7Zaxr2yOh46wRws7ydJXm80tyuc75ZKYERscB0DP 0Wxdqyxw1rpxWMZC2LoAxjHKmm9tpa75FU3auopH/wB5HM5reeRz2Vc/iflkh11bXNJBbSggj/mK 7jRepbfPrC83D8QBTPq3yRk/5crjt3Tb9bbmUDKSsa2lghDZ5CO3OcD6rt4bx5b+Y4+SbuN+ku7O ky6dikkOXOjbkn9FULdk9W42oT3JrH/1VodS64sW32jW09pkE9YY+mMZ5zjuVT2+XCa63Oqrqp2Z p5DI8/UlcZNOvuvAeCkU8JI0SAn4SHdAA/MsvKXlAQey3RiSqiaRkFwCvttbAINEhsbQC2LA/wDC qGWuRsdVE4n5WuGf3VztqNZUVXZo6Yvb6bmdDhnBHGEsNun0JRUVI+m/CvdJK+KR0xLs/Nx+3lby myIr5gYc1zgPp8hXONrNPaGt9bXCra8uJLGdecZ8LyaM1xR3uOf1HMLagkPGcYzx3+ysjNbLQdJS Uhpm0kplkfC90pL+r5uFvKYE0d8DRh3VI0H/ALpXOMqdP6EttXW/i2yuySxodnAPYfVfLRWtKK/0 1Q17mBlSXB+DgjqGO6mqPdoGjpqRlO2nlMrnQl0ji/qPUcLcwtP8JvRb8ri+YAjx8pXPtqLFoG01 dU6tEvJ9MGTJA8BfDR2rqHUFDPDI5vpVJcXdJwR1fVXSVsNv6GCjbCyGV0xdTh8jnO6j1HC2rmn+ z986PlcXVABHj5StHDPZdvrPVTvrfWOXem0ydRAzkNXy0fqmg1Fbainkka2KqL+roOD83flNfKfx stCW+noGtjp5Xzh1Ox7y53Ueo916qsO/stdvRcWPL5w1w8LUx1Vn2+sU8s1b67y49GX5OM5aF89L akoNSWeelkf0x1JcXFjsEdXflJ1ZaZd46bHRdDDQsdDTyvmaII3ue53US4k5X2qmn+xt0ELuh5dK GuHcc91qoqq1beadnkqa0VEjnHpy4E4z8oRpe/2/U1hmo3Sem2fqyWOAI6jkrV7rMnbZaMoo6AT0 0Mz54xDG/reeolxzlY1bXSaDrxC70pHGQBw8fN3Xhjq7bt9puR1VWiedxIaS4EkA8BGnLxb9U6cm oTN6TJ2uyWOAIyc+VnCXFrP9mx0jQtoIqiljlknYI43db3ZJJzkrGrZJJoOpZATHI9zg1w8fN3Xh jq6Db/TL319a2edxIBLgeoDsP2TsVyoNVaZlt7agwMlacPYRkZOVcruGM1dtnpagFBBV0YmfMxsb D1vOSSc5UQ7T6vEOpa2zUzQxzp3l5A7nqOSpDrbnQbdaNmlr6ts1SQQPmB6iOyh/YXTFxuep6vUz xFBRySOc0SPwXdRzkBXevDlPm1Nf88y+NOx+JmBlUzS9NK3qZJXFpHuMBSDXUbodu4qSif8Ah8tY xrm8dILgCR+i0W8Ola3U09knt89JHHb6gzymaXpBHHAxnnhbu3VdJqjTD7ayqMDunpD4yMghazu8 cYx4ZZyn9bDTVIKKhrqYTSTRxgYfIQScjzhQFo2sqta3etobpdpaC0U0jmYhI63uBPvxhTPPXU2i NJenXVYqK2UdHLh8zu37KL4Nn2T2OS5acvM7bxNiQxyPDYeonJ+uFMbJhZfbWWNuUs9JetlJHZ9J VcVokkr/AE4yQZnAF2Ae5AXDfDlZIqG11dZJK01VTM6QsA/KCe2V2NjY7S2g5f7QVMIkjhPqPY7q BOMcLkPhzp6w2SprqnDaeWV/pZOCW54OFnf66WY6y21u7mv26Hvc/wCDqjPPVA9cJbxHxjuuR2+u dduKyeO43h9st8Z6R6WC5x/XsuW+I/T1x/7RGSvdGIrjIGwHrBxjAOfZdvbtlKmj0vBV6Vvc8tzc 1rnxSkMhLvOD3H81vy2bkjHhluO6my30TbTo6Smt8j7i1rHNL5HBpIxySvHqGkqZ9JWqitk34Z0z omF7R2ae6+9qa/T+hPTvU0bJ2ROa8h2R1EY4K8lTG7VWj4KezVpp6qJrXNI5JLR27jGVMLrVq+SW 42RsaOl6dJ1tNUv/ABHoiRnW8fmAHsvFqOjqqnS9norVOKR0j4mlwGcNxzwsLnc6TSOkIaO8VLX1 kzOmTnkucMErK5wyao0lDFYq38PUwgOYRySQOBnIxn3V8d1ZsynXRXmAt26usFS/13RRSx9bm/mw O+F+eVW3pqZGjw4/1V9dfXel0fttNR3Wpa+tlgc13Pd7hz/NUIqndc8jvdxKuVn45P6eOX8uV/6f Ngy4K9nwy6ebY9vonPkY6oqSZXtaPyg9sqikf5wr5fDfT17dvKeava5plH931dy3wuHy75eq4vd/ Xo0vHdrCKptaa1rs4GPTDs5b+i7X4crAyy6AjeZGOmqSZXBo/KDyAVV3fW23G07iVsdzBDpSZ4/m z8hJwrTfDxTV7NuqaSvY5rpRlnV3LfC6+W/txnpx8e/x8rO3Bbua+Zpyiuum/wAUyufVtIJa3HQH H8vc9l3/AMPWn22Tb+EmRjpqkmV4aPy55AVT96rdcLTuBXQXNnTLI4ys5zlhJwVbTYGCubttRy1z XCSRmWh3cjwt+a6y4y9M+Pf4+Vnekb7va7bZLVdtLvqmVjqoEdbRgMDj289lJHw+aebYNu6ZnqMd NPmV/SO2eRlVE3horhbNd18Nya5krnGRoJz8pJwrg7Ew1424opLgxzZZWdTQ728Kef8A34z0nhl/ Fy+XPSaxZRalZpSqqI6t8kzXdbBwBnIb912+4diqr/Q0LaS6Mtb4nlxMjc9QI7cFVr0xRVdBv/FB emOjlbM6XDz/AITktKnneWg1HcY7S/S1O+pLZHGUMcB8pxzynlxn5bJ6b8Vv4sbfde7cm5HTe25l f1TugYw+qwZGQRyuC0vJqHci2tun8cgtlLE/pjjewuMmO5JyMD913u5Vrfc9s3WeWRsFVVsjh+fw cjJ/RRNJtnrbR0dDBp6tF2pHvy8RM6AwZ+pWJZxn23q7v0mvVNNDJZLZbK2L8SyWWJpcBlhLXA8/ dfDWLbpLdaCitM0dNTxwvnky3IPTjAAC9moJoqGw201rhG+OWEkOPOQeV4Nc0t6rxQ1emZYy2TEM uRkhjiMn9AkZ9afTVFuo75ZrG65U0VQ588DsvYDg5z5WGtHXV10o6SzvihgggdUSBw4PScADC++o rnb7T/BrfVVDRMyWNwA9mrz63o71W1NFU6ekiMMzRTzHuQxxyT9sJj1rbV/j6antNDfaWwPuVLDO 4zwuzIwE57/6L56zluzLxTxWd8MdLSUxqJmO4yA7ADV6tQXS322pstBU1DRNHKx+B7NBC8mtaC9V lwpZ7C+M01U1tNO7uWtyST9sKZeoSvTqiy0F7k09NcaOCof67DmRgJHykrx6yq7xFfY4rOYGUtDT NqJWPyMguI+XHsAtlfrxQW+5WWhmnaJmSBxaD2AaR/qtdrG23urvlNLZXQmirWNp6lxySxgJJPtg 5wor16r09a75ddOVFxooKiZk3U1z2AnAYTj7ZXj1bXXiDUQbahEKK30zJ5WvOMguIw364W1vV1oa O+2WlmnY2aMucW57DpIWs1fb71V36nFpMX4GuayKokPJa1pJP75wou2z1DDb4dQWG51UUTZw90Ym IHVgtOBn7rT6vst/uerKGqtVdRw21rWCVkkhDnYcScAA+FyfxJ39ttstrpqOb/0g2pDmsbycYx/V cvt7JuFeNRUUF0ttZSUXUHSTTxljekc8HzlXXRtOmoJaeC82KSqLWhskgDj4Jaud1JZNS1mtaeqt 9ZTxWgen6jXyYc4AnqAGPK5L4lNRC20FphoJibhHUdYY3vyMBc9txV7hXrUtHBdrZV0lEHB8k00Z Y3pHPfyVbvGMbmVbv4qbYbraNP0sbQ6WWs9NgPu4YUiUVlq7RtzSWug9MVdNAwDnDctIJUb/ABNX dkP8BhpXh9ZDU+qI28nOOP5rvNTTXJu0cssMUpuRo2noaD1B3GeP3UzneP8A03L+l19tfpXV9v1L qmgYB/ttLTv6+M4ccAhei8WnV0uvI6mjfTmwmSMvBkw8AY6hjyoY+FOc1Wt7vJMT1sgP5u+S5SNc rnqIbvMoYaOsdanTx9UzYyWBuBnnt4W53LXLL3jHZ3y1Wq9a5tIrYI556GKSZoe3PSeMFeeovd2G sHNigZ/CoqhlGZM4PW7Hj9Vu618MOsKB8jmtLqeVgz5JLcBc7UU95brRlvZSNNtlqxcHT54AaAOn 75AUunSIE+MTT9BR3y33Ojp44ampY713MGPUIPBP1VbSrR/GRVQy1Nrijka58bXB7QeRyquFXyyT Wvpjw22Xf2sX8H+mbddr9crhcKdk81G1hhLhnoJJ5H14ViaW/XOTWRifStFpM7qJkgI/O0ZOR9lC HwWTwsmvsb3tEjhGGgnk91NNLFdhrhtudRtFDFVPuDqjPBa4ENH3znhcJt6c9bmnyo9Badp90qm7 RW+IVf4Vs+cdnl7gXD6kBeu2agudTrJ9PPSNbaZZZKWGTPdzASchbimqoH65q42yMLxRsZgH/EHu JH81z9obdRrWK3TUIZS0ss1aajPDmydQaPvkldMN6rjfcee1bfaet+6VbdqehjZUClZO0Y4a9z3h zgPGQAtlZNRXGt1Q6CqpGstdQ+Snp39Weoxgl3H/ANPZbamqIJNb1zWzMc8UcTMA85D3kj9iubsT bl/bGmt1RRenDbpJql02eHNk6g3Hv3Uy3x6nZJLd7eTT23GnbVujdbvSUTWzNhjkjZ/hY95d1OA8 ZwtxZdQ19w1I+nrKPptlU6SGBxIIcYwerj6rb2+pgm1hdmRyNL2wQtwDzkFxP9VyumJ7jPq6C21F udBHa5JpXyk8OEgd0kffK6SdVm5dx5NIbZ6bs+5V4u1JRgTQtjfE0nLY3PBLiAt9Y9QVd21BPQ3C 3ubbqtj/AEHuGWvDCQ5bSzTRyaq1A1j2ucRCAAfZhBXPaRqrhU6kgt1Rb3wR2tsvqSO/xF/5cfQh Yy6barQm2Wm7Lr2+XKnow6anc10Ify2Pqbk4C6KwX+W/XWqtl1tzm0VVE58JkALJGDg4W1sj45NR 6i6HtLiYhgHniPB/muc0NV1lXfYaOe3y04tMMlPJI8YBc4gjH0IWrrstajbva/Tlg1ffblT0vqS0 02IGyfMIgWB2AP1XR6fvn9pq2ttl4tzvwdTEZYfWZlkkfY4/VbWwPbNc9SNY5peZ2gAH/wCZNC53 b2apqrnTwS0M0DLVTvpZZJPMhI4/YLOUnacrbPpptstr9O6a1HfrlT03qSU1S5kHqnqEbS0OwM/d dJYLxDrF1xtV5txNJPH6sTZmgtfEeMj9VtdOkPl1M1rg5xrHYAOc/wB21c5tjLNV3I5o5YY6Gn/C SPeMf3gxlv8AL+a3xnG/Zcrcp9NTtftnp/Sl01BdoYTNNS1UkUJkwREwNa7A+vPdb+03Cj3ApLnZ 75bnei9vqxiZneN3DXNW2tDTJQaqZD88j6ubpaPOY2gLTbZV5utylmbRzU7aKlZRSmRuP7xpyW/o s6nH+s8rzk+HP7Sbb2PRzr5duh1RVUtRLEx8nPpsYAcD2PK6Gjnt+5FruVmv9teGY9WMTMwQx3DX t/6raW9jpbJqlsIL3yVVT0tbyTlgAwtft/c/4zeJaqOkmp2U9DHRyGRpA9RriXN/TKuutnLvTl9o NurLouiut7ew1NbBNMxkjwMxsYSPl9iQt+BbNzrFcbNqC3yt6T6jPVYWua0n5Xsz/VbehaZdG31s TS95lqwGt5JOTwvJoW6svt1qK2mp5ooIqOKkLntIBexzuoD7ZSya9Fve5XKbRbc2bQltuF/kDqqr jMjGyyAEsa1xHy+2Vv6intO6em7ja7xRvZLA7LS5vS+Mnlrhn6Lbxhx2+uQiaZJGmoPS3kk+o44X z0NdYb5cblcaWCWOB0MUfU8EBzm5zg+cZAU126dOK2m2+tGgbRVaiqHuq61oc31HtGYwHFvy/dby 6W2zbs6SraO4QPiqaV56JC3pfE/uD+y20/UNta7043SuYZXdDBknEpP9FloO5Ut5qb1c6CNzKao9 LBcMdTg0grXGRjL/AGuqgTYbb2yz6nrqu/1LJJLZP0RU7wAHnnDj9iF1XxcUEElmtNQI2CVshaHA c49sqK3V9TQ7nSNpZHMa+4MjcAeCDIB/qpi+KzH9nbYD2EpP8l18WMx8tx/7/wDs4+TLfjxyRH8N elaPUGu+q6Uv4ilpozI3IPSJByP1VmtSzWHUNRddLX+nhLRGHxhw6SRjIIPuD7KIfhKvZZU3KyGN uC41IdjnsAvn8Smp5IdRQUtIfSqaYdPqNGHFrhnGV5P8aXyZZ7vp6PPnw4yfKV9paikvmhjQOpon somuovmaDkAEf0KqJuZoe7aQuxjudE6CCdznU7xy1wyeAff6KzHwvzOk0BcpiSXmrkOfrgLe29tv 3K27rae+UrZmwPfFnyHtGQ4HweVqTe7HTyzjlpRIgg8oAXtvFL+Er5oRktjkc0Z+hK8gSzV1WZ3N px+FvStBfdV1VXcoHSiija+En8ofnnPvx/VTTruy6Z1jZb9aJqampK22vc6N0TGscHBuQeO+Vy/w iXeGSxXC0iBgmhkMxkxy4Ox/0XMfEHqf8NrR4tg/D1McZgmczj1B3BPueVvwSXdrn/kW7xxx628n wy6Nt141Vcaq5xGc21rXQg/l6iSDkeeP6qUdf6c0tq/TF8o46Olorna3PdG6BjWODgOCcdwVrPhS vEFTYLnbhTsbVQTGV8oA6nh2MZP0XFb76oFNrSY2nFNJ6Zp6jo49Qg5yfqumExyty11GM7ljrGXt 5/hp0ba71qO5VV2hFQ+gja6JjuWdTiQSR54Uka+0jpPVej7y230FLQ3S2Oe5rqeNrH9TfDsdwfqv n8Ld1panTFXRRUsTKynkLpZg0dUgccjJ8qP97NVfg9YVRsuKYyRmCpa3gSOB7ke+FMMccuV11Ezy symMvdY/DVoa136+3KuvVOyqFA1ojikAcwlwIJIPdSNrXQWkNT6ZrXWmiprfX2+U5NMwMOQcEH3B X2+GG50VXo6amgpYoqymcRPK1oDpckkEnyo+3K1GKTcGWOyk00VS9kVTG08Of14zj3WMMecyy+I6 XPj5McPe0m1mktDaE0vQC42SjrGOPR61TE1z3EjPLscrR65200lf9CsvthoYbW6P+9D6duA9pcA7 P81I2s66z2vTtGNSU7K+AkACZrSAcd/uvDqGSnqtpqqWwRinpDTkxwtGR05xgKYyW4y/Jlb+2vhy jdNbZadsFD+IttFceOn1ZGhz3n3J91pt2dqtNVWhpNQacoG2qpp4/VMTGkCRucEOB7FenanbuaOJ l/1a9wp4iZIKSR2WgcjLgRwQee/lebdTcFt2qGWWhd0080jYHFv/ABOA/wBV0xwx5fyJllda+ah7 Zu2W2p1pBHf7VJcLe9ronARlzY3kZBJHbspG3925sdoZaH6Yt0dJPPJ6JZGTh5J4zn6lSy2ms+2u nqWhoIW+vUua0yEcyPyB1O+vK1O+ODV6ZzwTWRn/AN21XCbyu/WqzllvUl+Wh0vs7pXTul4n62p4 6y4ykPeS8t6CeOluCMgKPd7tpItOYvmmwX2ObBdGDn0CfY+QVYPX9HbrjcLdS3UgQvhmIBeW/MBk crX3Gmgn2it9PXEPgLImSEn/AA9YBOfsphhNY/1m+S7s+lc9ntqq3Wleyqq2vgssT/nlI5lIwS0e wPuup3v2utdkr7PDpWkkjkqcxGIyFwe7PBye3dWE/CwUVpoLbp2tpKWniLGhpd8xaDnAI9+3K0e5 tqdWXTTla2aNppq6MOjd+ZwLxyFifLru8sY4PSmyWmbVpymk1kXT3Cdwc4tkMfp5wOjHkA+VHG8+ 1EukKl1faOuexTkGN2cmEn/CT5HsVY7Xtsorvco6S4TPiZ+EkfH0y9Hzg8H64XwvtFTXTbm00l0c XU83oMleTjgkAnKY4et/LVvzFatntrazW1d+InzHZ4JAJX5wZcHlrTzg484W63o2to9O3y00mlo6 iZ1azpED39Zc/J7E/T+iszDb22qjoKCwuo6eljewPy8Nc5oI7Y7khc3uJZ559ZaVucUjPTp6oMc0 n5uc8hTHV3v6TVtkiNdP7HWCh0xFU6yqaqOueQ7NPL0BrSB8paR3ByoK1tZYLNqOto7fUOqaNj/7 qR3ct8Z+qufuLbbHcvRhvdbU0xLcNELsZGfsoH3o2th09S0d2s9TLLb5elkglOXgnkOB9lvCY8Z9 sXly3fTx7M7R0mrbBV3q+1U0FB8zIvw7wHtc0/MTkEYwvNvBtE3SVHS3Ox1UtZapQGudKQXtcfPG Bgqwe2dqs9HtpFTWqokdbpY3Pe5zsua5wHVz91E1NcnXm9M0FcKmSptktW5sdQ3Af0AZHfKxP2w5 xub/ACfjiuckb2HH+qw6SRggg+6vVPt3pmCKOGPSltq2NYA6VzWtcTjGe2cqJ9+NsbPardRXqyUz aFnW2KenjGWgH/EPqFMJb6Xc+XKbT7Ov1ZYpLxeK19Db3DED4ulziQcHII4C+ustj7par9bqSzz/ AI6ir3BkcsnS1zHYyc44IwO+FYPRNkt1v20it1BWuloHxOc2c4yOrk/sVHOlNYVkur7VpypxWyUd Y8wyjgvYGnufsni/fDnTK68n441cvw9WyncxtRqmWCQgH03wNPJ+vHlRruvtbX6GlimE/wCNts3D JwzpId7EKy+4WkKbUF3pqqS9fw6ZrGgxmPq6uc98jHstF8Q4Y3RFLTPY49Lh0ycEHAXTDCZZTGfK eTLjhy+VM5m4eQvkeF7K0YncPGe/uvG4Lk6Rh3TKChRCATTwlhAvKSy8I7KwI90IxygcIpJo7oQC EIQCSYSwgEimkgPCaWEZRAhNCBIPdCZQJJPHKOyoWOUwhAQCEYQgSAhAQCX2TQgWU0FIBAyhAQiU ucplIAhNUCEYQgSMIQgEvKZ7oQLugIQgChH2QgPsjsjKECwmgIQA7lCB3+iEAgo7I8IBLKaRQBQj HCEAjKOSnyg3JPGe689T/unL6ZK+U/LD54Xlnt6L6a6MYkPPdear/wB7+i9LOXnv3Xnqx/erpPbl fT5sGeVg/wDMVmMYGFg7utssU/CSaACEJoGOAvvA4tIIXn5PhbWwWyou9who6VuZZXAA+B9UH2Fy nYwMZKQPbK+n8VqQzoE7gPbqVqNJ6H05t1pR15udPFVVbYwTNKwOwT4GfqsNsqaxXe91d2mt1E+q qXYa30WkNHYYGMBXaa7Vdp7rV0wLoZ3Mz3IdheqPUlaxuW1bwf8AnVqINpKB+4VVd6qjppKSST1I 4vSAY0e3TjBK3cVq03V6xNJBZrc4w/3Ts0zMB3njCbTSoX9pq9zcfi3jPnrXymvtbLGWGreW+3X3 V0bpaNN0d4bRu07bHt9MSOd+EYeke/ZOHROlqu7zyR2O1PYIWu/9WYQM/TGMptNKTQXmspWObDM9 gd7OxlfOG7VMNR6zJHCT/MDyraU2zNhpdZm5OoWVFLM8vEEjQY4yeSA3GMfRcBudpTT0G6lNR/gq emojTRyGCFoYx5JPcD7LUS69IFuNzqa9+amZ0h9ycrwH7q3mrNrtP6r0hixUVLb7hC3qjkgjDQ52 OA73CqXc6KS319RST9PrQSOjf0nIyDg4TVs3CWS8fl5XLArIlIj+albII47BB9kKBhA7oATQZscW kEYW+smpK+1uJpZXM+x4Wgb3U6bK7NO1K2O7ajDobU35mxZwZQOefYII0vGqbpdA0Vc8j2DsM8LG yanr7W8upJnMJ7jwrLaj2a0fe7RVxaZpWUVcwExSse52SPGCcYK4PbPYeruFfLUatH4aip3kOia4 EyY75I7BN1npE971ZdLq0Nqp3vaOcE8J2PVNxtDnGkmc0HuMqxup9lNKXayVbNKwfhbhGCYpBI54 cR4IJ7FcTtdsVVXOolq9XNdS0ULy0wNdgvx3yR2CuzpFN91bdbuAKyd72N5Dc4CVi1ZcrVn8LO5v 08Kw+rdkNM3KxVJ0hD+Hr4wSw+oX9RHjBPlcXtbsVU3d0lbq5r6OhhcWmBrsOeR3yfATZ0i+/awu t4w2sqJHMHIbnhKw6xudmJ/BzOaD4PIU/wCsditO1mnZ5NGskir4cuHXK6Trx/hAPuuS2q2LmvDp a/VzX0lBES30A7Dnkd8kdgm6dIuv+sLrecfjZ3uaOzc8L6af1rc7M0tpJnYPg9lOeu9ibJPp2Sp0 S2RtbCSSySYv9QDwM9ly202xk96Elx1c2Wjt8ZLRCHdD3kd8nwFDURhqPWV2vRb+NqHua3s0dl9d O63utmb00k7gD4PKmvcDYa1P086s0OZ/xcDiXxTSmT1R7D2K0G02xc17ZLcdXCWjoGZDYWu6HuI7 knwE7JJUXaj1pdr08GsqHuDezc4AX303ru7WRhFNMQPY8hTNuLsLbhp41+iXTuqYCXSQyy9fqt9m +x/qtDtLsVLfYXXLVnr0VubnpiB6HvP1J7JssiMdTa4u9+c38bO5zG/lZngL1ab3Bu9khLKWb5fY 84Ut7k7DUMFg/H6J/ESzQkmWKWTrMjfYex7rTbSbFzX+B9y1YZqG3AHoiaeh7j7knsmySIw1PrK7 aie03Goc5jezM4H7Lc6c3Mu9lomU1O8CNg6RwpJ3O2IpaHT7bloo1FSYSTNFK/rc5vjp/mtVtHsZ PqKmddNUumobZj5Iweh7/qcjhNr05O67tX6upnw+qWBwwS32Xi03uTd7Gwsp5C5pOcEqSN1NiobZ ZGXTRhqaqOLJnild1uLfBbj9Vr9ptip9RUhumqZJqC2kH042/LI76nPZXZ1Ec6k13d77Utlq6h5D OWtzwFvbPu5e7fSNga/LWjGSV2O62xTLNZ23TSElTW08QLp45D1Px7jA5Xm2o2IqdSUJueppprdb XNzGxmBI76nPYKbTpxeqN0L1f6P8LPKWQH8zWn8y9ent2rxZrdHSU3SWMGByuq3a2M/s9amXTSst TX0jG5mZJhzwP8wwOUtqdhp9S2s3TUtRPbaF4zE1gAeR7nPYK9m4i7VOsblqG6R1lbKeuL/djP5V 11p3lvlDSxwB7XNYMA8rf7t7FyaZt8Vy0zNU3GgDf74SYL2/UYHZfTarYOo1JaXXXUdVPbKJ4zC2 No63D3Id4U2vTjdU7rXu+04gmlMcPlrXHlfTS27N4sVL6MTutvjLuy6Pd/Y+o0nSRXHT81RcbcW/ 3he0F7T74aOy9e1ewU+pLM666lqp7ZSSDMDWNBeR7kHx7JupqI21fr+7akqxPWzu+X8rQeAug0pu 7d7FQiBrjJjsS5bTeHZKp0bFDXWOae52tzR1ucwF7XfZvhbPa34f6jUdldddS1c9qpZADTsjaC9w 93A+Fd01EX651xc9V1fq18ziwflZ1ZAXHk5Uyb07MVeho4K62TTXC1SNAdK5oDmu+oHhQ0Rypftq a9Q2nDgfYqbLJvlc7XaYaKCMenEwNADseFCjGlzsNGSfCnzbH4fKvUNhddtSVstpglwYGNYC9w93 A9khUUa11TWaqvRuNwd1S9IYMnOGjnCkqxb7XS12iGiZCPTjaGtAcQOAtPvHs9cNAzwT08slfaZg A2o6MOa72IGceMFdNtn8PddqKxG6airn2mCXH4eMRhz3D3dnsibiJtZaoqtU351yrjmUgNAznDR4 Uo2Xfi5260xUMUXyRMDRhxHYLnd3doLhoGshfFI+utk3DJwzB6vYgfyXVbb/AA8XDUNi/il/uDrP FJj0IvSDnuB8uyeE7h1fSJtYamqdS351zrjmU4H6A9lK1o37uNutUVJFEQ2NgaMOIHZcnu1tNc9B XCPJfWW2biOpDMHq9iAuw29+Ha5ahsTbnfLj/CGy4MMRh63OB8u5GFd2mpEa3XXVyr9W/wAfe/FX kYI9h4UpUPxCXCCljjdG7LRjLXlR9ultfc9CXZtPN1VFJKf7mcNx1/TC7rQXw53PUFjjuN5uQtHr YMUToetxaexPIwl3PaS42dNJqfeq8Xqup5OpzGQnIaTnP3XS0fxD18NOyN0Dz0jGQ5RtudtpddB3 s0lW109K8/3FS1uBIP8Ar9F3uhfhyu1+sUNyu1zjtHr8xwug9RxaexPzDH2Tsmr6c7rneG66lkhA e+KOI5ALucro9Ob/AFfbLUymlY90jRjqDu6jvcvbe7aFv7qCuY6aB5zT1LWYbM3/AEP0UiaI+HC7 32w09xudyitRqOY4HwGR3T4J5GCfZNrJPhHmp9xLve72bhNO8ODstGeykrTvxA1tutMdPM17pGtx kHuVFm4m3130TqJ9sr4XyMc7/Z52swJm+CO+D9FJWjPhuvV7sFNcbjcoLZJUctp5IS9wb4J5HJ9k 5U1HA6l3Iut5vpuMkzw/q6m4PZSXp34hK2gtTIJo3ula3GQe5US6/wBBXXRupJLVXwvcS7EEoZgT NzwQPf6KTNJfDffr1Yaa4VlxprbJPktp5Yi5/T4P3Psps1HCak3Hu13vxub53tkDupoB4ClCxfEP U0Vpjhmie6VrcZB4yoX1tou66S1JJZ6+nkM3ViFwYQJm54LfupS0v8NuorzYaevqa+kt80wJFNOx xcB45CbNOHv+5V2uuoTczO9rw7qaAeylK0fEVPSWmKGZjzO1uDjsT7qDdV6Pu2mtRy2a4U0gqw7p jAb/AL0E4Bb7gqUtPfDdqi7WOCumq6KhnlBc2mnDuoDxyAVdrqOJvmv6y86rgu1c4yCKZsjWE8YB zhTIPiPxTENZIHhuACOMqveotKXawagfZrlSSR17XBrYw0n1MnALfcFStZPhs1XcrPDWSVVBSSyt 6xTzdXUPpwO6mzTi7puFV3bWFNd7g4yNhnbKGeODlTO74kGtpHBrHmTpwOB3Vcb5pq6WW+yWmvpJ Y69r+gRdJy8k4HT7gqWbX8Nurq60wVjqi3wOlj9T0JHOD28ZweO6vK32mpPTj6vcOruGsqa9V5Mn oztlDCcgAHKmqq+I+OS2yMjY4SlhaMt84VZrnYbhbb3JaaumkZXsk9P0ek9TnZwMDzlS5RfDhrOr tMNZ126J0kfqfh3yOEjeM9JHTjKltvdWSa1HJ7f7gzaV1XJcoW4imf8A3jW+2cqeGfEdRYBIcDjs QFVSts1woru+2VFLKyvZJ6RhLT1dWcYAUtUvw5a1qLRFWhtAx0kXq+g+VwkbxnpI6cZ/VNpo9Vb0 19x1PFcaZzmxxH5W58KRmfEdTizhrWu/E+njkecKrc9pr4bq63SUswrmyekYOk9fXnGMe6lhvw66 3dZm1wiog4xer+HMpEg4z04xjP6ps1pHmt9VVmqbtLV1khdknpBPYLm19qymmo6mWnqonxTxOLHs eMFpHcEL4JbtZNOp2/1fW6QvUdbRSENyOtueHBWTqPiNpDZiIgRUlmB8vOce6qXRUs9bVRU1JE+a eVwayNgyXE+AFKldsLrijsTrlJQwOjbF6piZL1SYxnHSB3RWNt3culHqs3YyucHvy5ufCmms+Iqh NnkMH/rJZgDHOfuqlU1tq6ivZRQ08j6t7/TbCGnqLvbCkq6bGa3tliluk9tjdBFH6rmRyh78f8o5 ym00+9m3cudBqt11dI5zXvy8Z8KZrh8Q1tdZ5X02BVGPAIGDn7qpNFQVVZXR0tJC+Wpkf0Mia0lx PbGFI142T1vaLFNdKy1N/Dwt63iOVr3gf8o5KvJOM1p79O7u3G3asN0kkeWSP+due7cqZbt8QVsN rnfR4/FOZhpa3Ds/dVHoLfU11dFS0kL5qiZwZGxoySSVIF72d1rY7NUXO4WnppYQHPMcjXuAPnA5 S5W91OMnTc6X3guNr1Y64zPc6GZ/94M+FMl6+IC1fwid9D0/i3twC0YOVUS32+qr66Gko4XzVEzw yNjBkuJK7fUe1GstPWie43SzyRUkOC97XtdgHjOAU5b7q8Y6jSG8NfatVur6iRzqeZ/943Pj3Uv6 g38tTbNUOtvR+LkbwQMFVDt1DVXCuhpaSN8087wxjGjJJJwF2Gp9r9X6atslfd7LPBRxkB0oIcG5 +xTkcXZaG3irLNqeSrqnudTTvzIM/wA1L2oN97PFZ6l1rMbamQdXyjBz7qoNtoqq4V8NJRxOmqJn hkbGjkk9l1OqNudV6Ztv469Weop6MODTLw5oJ7ZweE5bqTHUSBoDeWqs+ppZ62QupKl+ZAT2+qlf U2+Vmp7LUutBjFVKcnoGCSfJ+qqDbqCruVfDR0ML5qmZ3SyNvdxXRai0FqnTduFZerPV0lKSG+pI 3gEpyOPSTdtt5Z7PqOZ9weTR1T8v5zgqTtWb3WelstQbGYhVTEk+mBkkjBJ+qqNaLZXXa4RUVupp KmqlOGRsHJW51Do7UunaNlRfLRWUVO93Q18rMAn2Tl3s49aS7tfvNNab9M27P6qSocXEk9ipH1bv NZaKwzix+kyeYlxEeOSe5+6qLZrXXXa4xUNsppKmrlJ6IoxknAytnqHSmoNPwRyXq1VlFFI7pa6a MtBPsCnL5OPSaNp95RarvNT3ZxNJUPLsk9iVIOr94LLbtPyssZjZJI5xIjI7nuVUK0W2uulfHRW2 mlqauTPRFG3LjgZK9990/e7IyN15ttZRtkOGOmiLQ4jwD2KvPvacJ6TrtPvO233SWlvTv9kncXAk 9iV3es93rLbNNuhsTo43OzhkZHGTk4VQbXQVtzrWUluppqmqfktiiaXOOBk8fZey72W72hkZulvq 6NshIYZoi0OI7gE8FOXe149aWA2g3ljpK2agvrh+Emc5zXE8Anwuv1xuzZ7Rpo0unjGwEFrWtOen PPCqLbaKtuNWymt9NPU1DgS2OFhe447nAXqudtuVuLW3OjqaYuz0iaMtz9sqzPV2zlhymtps2Yve kZqm41eqqaGa4CpE0Esh5bwDx+qmHVWq9DanofQu4hqWMa4sDnD5SQeypZbaSsraoQUEE09QQSI4 WF7iB3OByvrXQV9BKIq6Gop5CMhkzCwkfYrPLvk3rck+lgvh5v2mNOy3d1Z0srRUObFM53JiwMD+ q1PxJ3KxXeut9ws8rXVTgWTYOeoDkFQhQQ1tVU+lRRTTzkZ6IWF7se+AMrK4wVlLKI66GaGUjq6Z mOace+Cs4awt4/JnOdlvwsn8NWtLNadJV9uuU4jnNS6TpJAy1wC7ufWektK6ZrorM8Na4ukLS7qL nO7nuqWUTKmSXFM2R8hHaNpJx+i9FYayB/pVbZmPI6umQEHHvgqy69N5W5d1jqKobVXOeZn5XyOc P1K1g7hN7i5xKxPb7Jbu7qTqai0Xwv3fTdm05V1NVN6d2lncyUud/gwOkAfuuR+JL+ET6pprjZpj IaqLM4zkB4PcfooYop5ocmKRzM98EhZ1dTNOPnkMhA4ycpLr0Xu7qznwx3DTln0xU1U9SY7tPK5k /U7jpB+UAfZcB8RMVs/tc2stExkZVx+pKCc4fnHH6YUR0lVNB80cjo898OIWVVVT1ODLM6Tp4HUc 4WscuMs+2MsJllMqtJ8NVVpuz6QdVvq+i6VLnNqA93HB+XA+yi7f+mt8GsXVFrqHTQ1bPVcD/hfn nBUXUtZUU3EUzmA+ASEqyrmqgHSyukI4GXZwrhnxxuM+UuHLOZfS1vw4yaetGjBVtrXNr6vIqmyO yA5pOMewwor3jio7XuB+Kt9SamnlcyqwR+VwdkjPlRTRXCpo2uEM7oweeHEZTqq+oqyHzTOlIGA4 nKniv45cZ6rWc5ZzP5i6Fwq9MblaSofxNxdTxDDyI3fM12MYK+l1udi01oOKzUVWZoQ0Qse8jP5g clUwobrWUYLYKl8TTzgOIC+9RfLhNH0yzvkb4y4kJudEnvXyvDqj+F6ktEFO28mkZgEuiAcXDHZc XqXR+jaDShno2QS3Ki6JG1LiRI8teDz9VVmDUdzjjDBWSBoGAOrssptTXR0RY6rlcx3BHVkFWZa+ TXyuJqCCy66tVprY7q2m9B7ZwAA4nGD0n25C027stHetI016t9ZGJ7dI2obESD1dLhkffhVSotR3 KljMcNS9kZ56erAWb9TXH8M+ndUSGF/dmeCrM79scItzDX2Dc3TFHUS1TaWugcCSHYcx3+IfYhab d3Vtrs2lpLDREFjY/TbznGOQqt2q+19vc40Uzo+v8wB4K+V3vNXcZOurlc93uTlXHLjdpnhMkvbO V9bqPV8VPUXf8NDTNE4a859TpI+Ue3CmPeWZ8FFQXygqoXG3zskkh6uXt6geFTe2V9VQVTaiklfF K3s5pwt3W6zutVSvp6qqkkicMFpPCSze116/i2038H3Is9tuUVc2nmheOsdeCR/ib+y5/eHVNutW ljYqOTljQ1p6skdJ45VY7Nqa52kv/A1L42vOXNB4Xlvt+rLlKZKuVz3nyVfHlMbu9mWPKaTdsrdL nqTVbWSXWOKGhDJ3smP+9bnGB9VLW5TjRXqw3p1Sz+HU87WztDuRknDvsqZ2S9VtqqxUUM74pMYL mnuPYrobhry63CjNPVVDnxnu09lm6tta+v4tHuppOq1iy31dnuVHA1jAczPIDgTnjGV4t65IINva a2SysfUhkY4OQcAAlVvoNwb1S00cDKt5iYMNB8D2XjvmtLjdmNbVzFwbwEwuspb8GUtx4rZ7Y6cr LRtr/DKqendLMHyRvjflvS8ZaoC0u51i3htwvDxEaasfHK4nIGQQDn27LmLVuTfaGkZBHVvLGDpb k9guevd+muVxfWVBJneQSfqpjlx8d8fxV1ry/l+Vxtw7NqK7V9JU6bqIY6f0wHvdL0nvnjg54Uf7 02aps2mqcuvE1Y6V7Q+nm6cjI7ggDPPuojt26V9p6SOA1TnNjaGhx74C12ptc3C/NayslL+kYB7c LWOf2xcItfoPT1xtu1jbTV9BqzE/pLXZGHcjn9VBG3k/8O3htIuTvRfFUyxyF5xhxaQFoLVu3fqO kjpzUOeI2hocSQcBchd79NcLvLXvd0zvd19TeOfdTxSePxfjXOcvN+Va/dXSeor5eaWqsLGvha1n UfWDOzs9j34Xw3/LBoWnhkcBOwglh78DlQlbt475FRRxS1DnPjAb1E88LQax1/X6gi6aqZx4wckn K3jnZlzvwueHLDhHCV5BmcB4K8Ll9pHdbifdfIhcHRjhGE0ggPqgppKISB3RjlAQCSEK7AEY4QhF CEI+qAKEfVCBeUeUI8oBJNCIAkmkgaCgpIDyg90I8oDKEHshUCEIQCXZNCBZ5QmkgEJhId0B5Qmk e6BIymjyiBCEKhIHKZSQCEIQJA7oQgCjCPKAgMo7ppeEBnhHhHhH2QHugITQIoTKSA8Jdkyl5QHf ygpoQJGfojyjhBs88/dYTn+7csgfCxm/3Tl5Z7d76a+HuT7leep4kwvRH+Yrz1P+8PC6T2xfT5c8 rA91n4WBW2AhJPCATCXhMIMmHupH2ZjEmqInEdm8KOGLrtAXoWa7sqDw38p+yC0m+xczaOfoBB6o e335Uc7CVFfU15gpshgcPnPhd7Q64s9fYjFd3MnppWdJBwSRjHnsvjt1d9LaYbVTUrRFTPeTGC7r cB9SifKZa1s4pXx072CrdGQ1xPHVjh3v3URbUQVtNqy4Q3SYT1kVW9r5ATh3PcZXp07uJS3K/VdT NUuZSiQhozz0g8LoaK+ac/tFNcYpSzLRkBoGXeSfdNVH13M1PQWSmuFPMMVlRSFsXQ3L3Eghoz7Z Xo2rbUx2pprmPjnfEwkPGCvHX1OkLhfo7xXOkmq4mBjOvBY0Dt8vvyvc7WlipampqpKvpi6GAcey aT5baxXyK4TVNM55M0czmgkkng9u6rb8RdQ+LdKIsJBbRQgEf8zl322WpqD+JXG4T1AZFLVSyM6u /SXEhcXrxts1ru4KhtV022CGOOR+OXFpJwP3XTGdVjLfKWJu24ydKOceSWt5/RUi1kSdTXU+9TJ/ 5irVa+3GtGkNIC3afcH1cjOlp/y8dyqiXCofV1ks0pLnyOLnH3JKuFmPjuPzSy5eXn8aeYjyElke yxXN1HccICMICATz7eUscphBs7DCJ7pSscMtdI0Efqr66RgbFoOVrfl/2d448fIqF2KoFNc6eV/I Y8Ox9irn7b6wobpZGUssjfw8jCx3OMAjBTSOi0HTUcEcDaNwf/s4MhDs5ccf++tuW/8AoC9nsS6o GfbDThcvV3rT2gLLUzQVDZZHOJjaHc89gsNG6wor/bZYqiQejUl3qAHpx1d+VWG30BSUtMyKOkd1 t/DtLj1Zy491sJ2H+zF7DT0kuqGg+y5ye76f29sdQ+CpE0ji7oBdk4zwFjpHVVFqK0y008jfSqer r6XdP5u/KaG60JRUlK30qN5kj9CNznF3VlxPJX2rmk6Su4Y7oPVM0O7Y57rST3exbfWGZ0dUJ5HO PQC7PHgfojSuprfqKyy0lQ9piqQ7r6XdP5u/KSasplNzTa6IoqajikipHuliEUbupzuokknJyvpW tMmirmGksyZR1dsDqWnqLvZNvtOyYqm1EzyekOdk4zwP0WWmdQW7U9glo6iRohqM9Ra7p7nJ5Vy7 MZqtxo+ip6WOpp6RzpIQyM5c7q5PdfK4MdLoKpY1xjLi4FwOCB1YytZU3e0be6bLTWNnnefl+bOc dh+iysF4t+qNNyUEkwjinafma7GM891nGaavfbdaQoaakFVSUr3SwNZHhzndRJIOeV5rjGZtCvY1 5i65OlzwcYHWAefstdUXe1bf6bLX1gnqXnAJdnPsvpY7nb9U6Yfb5JvTjlbw5jsEc57/AHVvojba To4KOmraWne6SCNjcFzuong+V5rqx02gwwSGEyPa1z2nBaC8An9lrq28WvQOmRHLVtnqZPlz1Z6l 97TX2/Vel3W4ziJkjctc12MHuP5qQrZ6ZpIqKjuNNC90sMbQGuc7qJ+U+V8L5C6bQ0MMchg9UxBz 28EAvGefsvBX3e2aF0z6NRWNnqXt6SerPUcYyvrbqyg1ZpU271/Ta5g6XtdjBHI/mhWz0/Ssorfc qaOR00cILWveck/KV5L9A+fQtPTxSOhMxhDpGcFoLhn+S8VwvNt0NpdtPVVbZ6qRvS4lwPU7GCV9 aOpo9WaT/hzJzFmMdL2OAwRyOfukRtrFSspLNcKdkhnii6mNe4glwDT3Wt1HTS1Oj7dTwSug9V0I c9pwQ0nlfG4Xi36I0uykq6wT1MjelxLgepxGCUuql1dpRlDT1ToXta3pexwHLRxz91vDq9ufl3cd RuLRSspbDXUwkdMyIyRte/kkBvleK/001XpG201NM6n9UxNc9ncNPfC8tyvNBovTEVJW1bZ6qRvS 4lw+ZxGCVlKYNW6OZRUVWYJ2taY3scBggcfosyNSdabKipRBpith63TNi9Rge/kuaBxlePUtJPWa XtNLSTuphK+Jrnt7huOcLz3q90Gj9Lw0VfUsmqpWdLzkcuIwSs6xsWrdIRUltq3U9RG1rmOYR3A4 89l0xutMZ48pZGwghEWkayGRxlbF6jA5/JIAXw1JRz1um7RSUk5pjM+NrntHIbjleO83eg0npaC3 3KpbJVSs6X/NySRyV9rjHHqzSUdPa6t1PUxgGMtI7gcZ7cLE6jcet9P06OrYJ3esITIzqcPzAcBf PVNFNWWizUNLUGlbJIwOe0dmhvZeHUF4oNLaZhttwqWyVUzel/Izk9yvTeYP7XaWiZaawwVUYDoy 0juBjn6K3/XR83T1GIN0bWQzu9b0utgc4fmwcZXz1dQ1FdR2ago6k0okeA97RnADfZeHUN4oNLae p7VXVLZKmZoa4k+T3P7r0X+nk1Vp6nNmqzDUxYLenBz2HJU+I1K1uu4SNn7yyd/rOjp5G9ZGCcHG V+fkoxI4eMq9u8l7odMbZ1VpqqlstXPAYxzg5PlUSlOXn7rdyn45PnbOEvO34d1snbIbpuHaYahg fG2TrLSMjjkK8etqKpqm2mioqg0sZLi9zW54a3IGFSTYmugt2vqGoqXBsbc8n3V1dV01Vqex0s1g rPSqYng8eWkgHn7ZXGOtfe507KjRccdU0THqYCXN7kPAyvlrikrqmW00dvqTSMzI+RwbnhrcgY+6 +Wqrvb7DaqG1VVQHTuc3zg8EHJ+6er6Ku1JbqSq07XejNG7BaPLXEB3PjAXTDq9uWU6em7U8dZo+ m/GMbK4SR5LhnnrHK+etaS4Vlda6O21X4SINkkkPTkENAwMfdfLVN4t1kt9Baqioa6YuZ5x+Ug8/ dZaxobjf6GlqtOVzYpWkNc3HJa4jq5zxgKT7q/x9r3TxV+kqE1sbJXepCSXDPPUF5tb01yrLtbqS 2VQpYGRSzS/LkHpx0gD7rPVN6ttno7faqmoa6cuZ5APykHn7r560ttyv0FFWacrWxyNIje3HdjiO rnPgeFfHdXtnyTfT0X+lprlp+1SV0LJnmWE5e0E5yCvlrGG51d8oKW2VLKWnihknkJYXZ6SMAAEI 1TeLZaI7Xa6icGZr2HAI/wAPv90tZWy53sUNZp6sbGciKQY7scR1HOfA8JL12sk2++oKOmutosr6 +COZzpoT87Qee68+sY7nU32lp7bVNpaenp3zyZZkOwcAAAhfbUd5ttqktVuqJ2maORjuMdmr46yt t2u1TQVen6qNkL+mGcdOT6ZdknOfA8K4XWtrlI9N+t9LeKWxOr4GTEzROBeAcHBK8ur3XN98jitt QyClpKb15Gluer5sAD2Xov8Aerba6y026eoBmjka7APhvC+Gr7XeLncqOosdRE2kn6Yag4yQzJJK zl3IY9PbqC20l2/s/JXU8czvXY4F7QSPlJWr1lJdv7QNbbJo4qWhpmzyMcD82XEYGPoFsr9e7dQX W00E07fVieHkDHYAj/VePVtpvFxvNJPZ54xQ1QZFUnGS1gJOf5qNbbDUdqorpcNPyVlLFPI2bqDn tBIw0lanWEt3/tC426ZkVHQU7JntI79TiMD9Atpfb3b6LUFopJJ2+rEXOIB7AtwvBq2z3i43ymlt FRGLfVhsdR/wtaSc/rnCzZddK9+pLNb7nftPT1lLDNNHI5zXvaCRhpK1Wq6y7Ramc6hkYygoYYnv ac5Je4jj9Ft73e7fTaktVJJUNE0RcS3PbLcBa7VFovFdqKmfbZI/4ZWFgqT36Ws5z+vZNdJWw1HY 7dcNTWCpq6SGWoifIWvcwE8Nz3Wn1DX3duqZn0sjGW6gELXNPcuecHH6LdXe80EWp7ZTSVDRNF1l wB7ZGAtTqC03qfVUAoTG61VsjH1DsflEYzz9/C1/41nL3Gx1Bp62V+rrFWVVHBJURGUtkcwE8N45 WpvlxvI1dK6nMbbXQuhY4HuTJgHH7rfXS80EeqrfSyTsE0bXlwz26gAFo75bL3LrCKKkDHWmtkZL NJjPT6YHB++OFcPV2uWXp773py1VuvLPX1FDTyVUUcrxI5gLsgAA5+mV4rpcrx/a6V0AjFspJYoH En5svxnA/Vbetu9CNZUcBnaJY4XgjPlxGP6LUXa3Xo6vjhpmtdaaydlTLIBnp6AOCfHbhas+2d/T 1XLTFnq9wrbcp7fTPrI4pHiUxgkkYAOfcZXxqrneBq6R8Yj/AIXDUR0py7Dsux2HkcraT3Si/tnT wGoZ6scD2luexcRj+i1FdQ3saxhpoYmPtM9QK2SUZ+Xpx8pPvkLOTeNfWu0jZZtyKS7SW+nNYIHy ep0DJcCB1fflYC73Z+sXFojNsbVCizn5gcAk/blbiS50btZxweuz1I6dzCM/4iQcfyWjFBeGa2FM 2Fn8NdUmvfNj7ANz7/KlS19ptHWOXc1l5dboPxwpC8ydPJd1YDvv9UU13ukusXlzI/4YKk0QPV8w cBnOPbnC28dypHa1fAJmeo2lDCM/4uonC0tNS3dmuPwZp2C2id9e6b3zwG598jso1FdfjGsVDQat t1fQ07IZqqAuqCwY63Bx+Y/XCrurL/GTW0897tccEjXvihLXgHseoqtClWb+VnPg207QVdZd7vV0 8ctVS9DYHuGTHnOSFO9lvl1qdYSMqadjbZPLJTQvzyTGCTwof+DGphbbL5C6RomfKzpaTycBS3ZY by3WMFFU0TY6CidNU+vnIf6hcGgH355CuPqpl7j5WfQ1it+6Nzu9PQRNrDTRytdj8rnOcHEe2cL6 6ev91rNVObWUrWWuqklp4H9QPUYwc8fX/RbyiraafWlyjjmY6QU0UfT9Q55I/mub0227/wBr4LbV UPpUltfNUetnhwl6unB89+VrH1XPK/tHy0voKw2rc293aloY2VAjjezjhjn56iB4zhbPTt8udfqB za6lay3VbpI4HdQOfTznjxlbS0VUE2rb2yOVjnFkLQAecgHIWg0o66yaoZb6ygENPazI8zE/n9TP Tj3Uz3q69t4yS+3l0ft/p20bg3y7UVBGyoj6Cz2jc8EuIHjK2umr5cLnfJYbjRhtDWMeYCSCHNbw ePGVtrHLDLqO/iORji8xAAHyGYK0GjZbnPqCOiq6B0ENqjex0juOsuJ6ce4wrdfSe7K8OhdvNO2T W99ulHQsbPDI3088iPqbk4HhbjTd6q7zdKmiu1B00dVE6SEvALZGA4PC2lhlimvmohFIx7nSMAAP tGB/VaHQk9fVXqOmqqF1PHaYHUrnu/xPJBH6Yws5e297azbvbfT2n9UaguVHRt9aGcti6uRGC0Eg D9VvdMXmfUFXWUF5t5FJVxOmhEgBbJH2OP8A6fK2unZY5q7UbYXse81PAB/+ZtH9Vz+gKiurLpHD U0ElNHaqZ1G6R/HU/IJ/TCU3Gs2z2509pi9ahuNFSZliqnRx9Z6hG0NDsD91vdNXY6pNwtt7t+aW pjM0TZmgtfE75eP1Wz0+5sw1LHC5r3PrZC0A5zmNg/qtHtzVVdfciJqCSmittN+Bc9/GZAQXBLOt sy/tpqNsNu9P6TuGornSU5fLBVSRRmQ9XpsaA4Afut7p65x60guNrvtuP4eZnrMZKMh0TjgEfzWx sg9eh1THTkPfJVzdIBznMbQP5rS7ZVU1wudTO6ikpo6SmbRPc8Y/vGkFw/T/AFWpJcbb7S5XlJ8N PtfoCw6N/j93pqfrqIKiWNrnnJYxgBAHst3a6mm1/bbnZ9QW9wjez1Wtlbz6buGub/1WxoWmq07q ZlNiSSWpqQ1rTkkloAWu25r5LtdKir/By00VNRx0Ti8Yy9jiSP0ytTGcbb7c7nfyanpz+02grLom 13e8xwGasilmaJH8lrGE4DfZb2lNHuNZLnZdR257AP7xolbhzWu/I5p/1WzoGPqNF3mOlAklfJVA NbzklzsBeTb+4m83Ktrm0stPDHSxU2XjALmE9Q/QlLJr+tW9uc2n0HZdCWS4XxkRnqw6VvqyDLg1 riAG+3Zbx8Fv3K03crPqG3yMdGcgSs6Xszy1zSRxx5WyjY+Tb2vZA31ZQ6chjeST6rjj9l89DXVt 8rblc4qeSGndFFEHPBHUW5Dv2WbI3le3J7UaCs232naq+9Lqqtw8OmeAXABxbhvst7V0Fr3Q0pX2 y80kkc1O7GXt6ZInYy0j2Xvla+TbatEDDI9pkcGN5JxKXf0X10LcI7xNebpTwvip6j0w1zhgPLWk Ej39lmybrpZHH7W6Hsu3ul5L+WPqK9zCXyuALh8xbhvHAORwtndLTad19IVVNdKZ0NZSuLRI5uJI X9xwVt7g10m2LzBG6UtYHljBkkNkBPH2BX10PXw3Z19uVLG6OnqXscwubjqwzGVbJIxf9q5DazQ1 k290mb+9r6ivkj6nzOA6hk46W8du3C92otP2bdvSEv46B1Pc6UuYJSzEkTxzgj2PHC3lxDhtbE9j HSenHFI5rBkkNkBd/IFfTQtTDXw3yvpWPbT1VQZGFwx1j0wMj6cLF3Najckstcfthoyy7daMF9nZ +Ir54w58xGXfNwGge3ZerV2l7Ruxoo1MsZpLrRhzWT+nh8b2jJaR5B9lu7vKKfbG31D2OfHD6Ejw 0Z+VsgJ/kvboephrrffq6ma5tNVVb5mFzcdTTG3kfTIK68Zw2473le3F7ZaQs22+i23qqb+KuFXG 10kvRn83ZgHtlPXmlLNupok3Kna2mudE1zWTNZgtLRksI9l0t4qY6Hbm0VVQ1zooHU8j8DOGh4ys tIzQ1dg1LU0od+Gnq5pIyW4yDG3kfrlWYzUc8s8ple1DK2F1PO+N/wCZri0/cL5RNL5A0dyQP3W2 1K1outSBx/euXhoQPxcft1N/qufnkwuUnw9Xg/fjv5XF2y0VZdttGfxWvc2qrq2Jr5Jns4AIBDAD 4BXh3T0FadwtJR6j082CluVPHyWtwyVo7tdjyPdd3ea2C26S09V1fNPE6EvOMgZbj+pWGnH079D3 x9C0CmfPUujAGAAfop4pywxt+WM7JnZty2gdDWTbTSLq+6+nV3CqaDJM5uWngENaD2C1W723Nq1p pRmqNLsgpq+KPLgxoaydoPIOPI91ImqqqloLTpupuBaKSOZhkLhkYMZAz+uF8rGIP+zav/BY/Dl9 QYwOwHqHC6TCai9brlNEbe6f250ma29w09dcZwC+aVge33AaCOOFpd39sLVqWwR6n0o2GlqA0GRr W4ZI3OM4HkKT9XVFJTUmnJrp0CjbN/e9Yy3BicBn9SF5LcyJu2FU2lwYMy+njsG+qcLnJ3F05LSO 3WmdvdKms1DT0dwrZ2gvkqWB7c98MBHy8Fc1vBtNbbna49TaNZDAx7WmaFnEbgSB1NHgqXdaPoIx pw3b0vwRlc1/qDLeYiBn9V4aOONm1EkcJBhHUI/+X1eP5LpMZJDW5a5PSm2+ltAaZE+pKajuNfOA XuqY2vb1ezMjgYK5beXaChqKNmpdGNiip5en16ZvDPmIAcz278hTDrl1vZWWIXj0jRuL2n1RlvV6 ZxleenjYzaYMjOYxGA09+PUGFjKaskntjC75b+HIaW2u0pofS7KjVFNS3CukAdK6pYHtDvIZkcBc XvRs7TsZHqDRkcbKOoLfVpWkBjS4gBzPYc8hTZrgW019nbehG6lcyYASDLS7o4Xmljb/ANlNK1p6 mtji6SfYSDC6TCdb+S3ccTpvanSekNKQSauo6avuMmHyOl5DXHu1v0C4rePZ2KjlgvWj42Ot1W9r XU4dgRucQAWn2ypy13T22rrrbT3gRmnkhmAEhwOrpBB+/BXmdGBtjaGZ6g30AD74kCcZqMTK22OH 0xtHpXTOlqd2sqSCruMhD5C55AY48dLSMZAXC7vbNvtlfT3HSLPWtda9rBDn/dPccDB9ip519R26 4XCipbuWiB9PMW5eW/MBkHI8hfNrQdu7Cxx6z6lMOo8/4xypxmpW97unA6W2c0tYNMU/9soGVdyq HBz3dZb6ZPHS3B5AUf7sbNVNku9PUaWjdV2mvkayJmeYXu7NJPdp91YPXlBb7ncoqW6PDI3UkhjP X0kPHIIPuEH5tF6d9Q9bvVphk85+YcqcfS4zvVRzpbZbTFn01Su1gPxNxneHPcJDGI84HSADyAfK j3dTZussN9gOnYpK21V7w2naDl0Tz/gcT3HsVYbXlvorncfw1fIY2fgXvjIk6cPDuD+i+9Vl2ltO F/zO9an+Y8+Ryph23jju6RdpfY7TVv0/Su1fJLJcahzSS2QxiPqA+XH0PlR3uZtDcdO6igp7LFLW 26vf00hHJa7v0OP2HBVh9wrZT3a4SwVM74jFQmaDpf0/OHcfdbS6H/0Zplz/AJnCaE5+vT3TTOMm VRPpfYnT9Pp+n/tbVVAuczsh0Mpja0OAw3pPsow3E2lu+mdRw0dBFLX0da/ppJWDknv0u+uFZTcO 3MutdPE+okgkp6EzwFr+n5w/+fC2d1BkpNMGX5n+tGc/XoWZe43MZUR6X2Es8djp26qrJ47pM49L qabDcEZAwR3CirX21l50vqSK3MikrIat5bRzRtJ9Xz0n2cB3Vl9fWx1yutUG1EsElJRNqISx2B1h 5HI88cLeXVpm/ss+TBk9drsn39M5W7jJZ/XPC8puob038P1sFpp3akuNRBcZjgCnkHQcjI7t4OPC ijXm2t50vqNltdBLVMqHYpJYmE+sO+MDsQO4VnNxqKWtvMvo1csEtLSNnh6DwX9WOf0C3t3YJqrS kkvMgqAc/UxFXhrW/lrrW0Lad+HykltVI6/XeopLjMSPShLXNce4wSOOPHKifWm3l50xqH+FzwSz OldimkjYSJh4xjzjurM7kRVlRfnOoqqaGSkgZURtYMgnqIOfYYC6e9xNnuGkamUAytqM5x7xnK1l 4+Ov64+PyTyS2fF0hDT/AMPLKi00ct4vctFcJwcwNia9pPcYPHj7qHNwNG3PSF4lt90jIIyYpAPl kb4IVrdxG18t+lloa18D7fDHOxgGQ4l2CPpxlaj4j6KKu0LQ1EjGmdjg5rsc/l5Wp4t2T7SebeNy nxdKcP8Al4PCxK9VY3EhBHZeQ8LzvRCCOyMoQJLwn5R91EJCaB9EGKMIIwUeUAE/KAhVQkgoQJNB RhAJFNHlAkYR5R5RAkskkAO6RT7IQLynhLCaAKQTR2VgSPKaECRlCCgMIxyhCA4KPPsjsUIEjPKf dIYQCMITQLyhGEKoEk0IF5QhCBeUJlAQJNCEAhH2SCBlLyhAQGE0eEvKAKPCEeUAljj7poQIp48o R90Cz2TR2Syg2PlYzf7sj3WfcrCo/wB0V5p7d76eFv5ivNVf71eiL8zickLz1PMhPldJ7Yvp8yOF ge6zb257L5u7rTAQhCBpICfcIGPqvRC4tdjlfABbrS9mqL7dYaKlA65HAFx7NHugxbXT9PQJH9P+ XK+v8RqBH6Zmf0D/AA5VrbdpvT+1ejv4hJTxT1rmAGaRoJc4jgco2phtNdVVlxdRUz66uk63P9Jp HJzgDCvqbY3LVU4bnUwcMmc0Hvzhe2O/Vkbflq3j6dStdYNqKOl1zcr1WwwVDJ53TRNdGCG9RzgA 8cLcWmCyXLV1WyntlE4DEL3Op2k5bn6JyNKdf2krXcOqnf8AjXxqb5VSM9N9U9zMdi9Xcrqe0w3m SjkstCYIo2vkkFKwhuffjhZUWk9P1VfcJo7Vb3tcyNvUIGkdj24wnI0o9DeauCEsincxju4DsArC mutTBI6aKYteR+YOVvbNtHZLbq6e4Pt0NRTzhzhHMwPaxx74aRgKM9YWGwt3lngqaGnZSRRxObTM YGRuOPIC1juy36ZuUxsl+UDVtfNVu6ppC93uXZXi8+6t5r3bKyaw0gZrHRUdur6UF8b6eFsbXcch +ByOFUeqhME8kT8dbHFpI7ZBU1bN/DcvenyPKxWRS8qNDul9k0EIF4TakOyyBRH0Y4tcD7Hhb+ya kuFsDm0sxY13f2XPxtLnANySeMDyrBbO7JR3SkZe9WjoocdTKfOOoe7ldmkPXnUdxuTg6qlkeB2B PC+9l1RcrYCKSZ7M848KyGqdntKX/T8/9laWKgrYSSySPLurHYHLsAFcrthsS2Zslx1phlNE4gU7 H8Ox3JI8KbTpC151Jcbm8Gsme8DsM8L6WXVdytQIpJnsB8eFYnWOzGmrzp6V+j6VlJXREkODi/rx 2byeAVy21exf4pklz1q30qSIkNpmux1Y7kkeFdp1UN3vU1zusgdWzSSAdgTwF9rJq65WtpFLK9jT 4zwrAa42V0/dNNSVGi6cU1bAS7HWX+oPbk8Lndq9jG1cElz1mPSpWZDaYOx1fUkJKdIZvmqbndZQ 6smkf09hnherT+s7namFtHM5mTyDyFO2vNkLHXaafVaKgdDW05Liz1C/1R7cnhaLajYplfSy3XWg fDRgEMp2u6SfqSmzSIL/AKpud4lD6yZz+kcNzgBeqwa2utoh6KWZzR/lJzhTXuHsbap9O/jdDxPZ VwEl8TpS/wBVvsM9itVtZsVHX0jrrrT1IKMD5Kdruhx+pP8AomxD1+1Vc7xKJK2d7+nsM8Be2w67 u1mhMdLM4tPOCeymPcfY62nT/wCP0NFL68GXSQPlLzK36Z7EcrW7V7ENuVE6660MtNR9PyU7HdDj 9SfH2U7OkQ3/AFbdL3OJK2Z7uns0ngLY6f19d7PT9FLOen2dlSxudsdQw2Btx0PHNI6EkywvkL3S N+nsRyvNtTsK240Bu2tHTU1I5uY6Zjuh33cfH2TZ1UP6h1fdL3OJK2d7g3s0HgLaad3Du9mphDTy ktHYEnIUn7q7G0dFZGXLRLKiYR5MsL3mRzh7j7L5bWbDtuNtF11jJLTUr25jp2O6HD6k/wCivZuI k1FrC53yoEldO53T+VueAtnp/cm72amENPISB26lJG7OxsFqtEdz0Y2pqYYxmaJ7/UeR7jjsntZs I252r+K6xklpqeRuYoGO6HY9yf8ARTdOkQ6j1ldb7OJK6Zzuns3PZbjTu5V4s9MIIZepo7ZPK7zd vY1tltsd00eamrpWtzLC89bwPcYHZena/YRtztH8W1jNPSQSDMUEZ6XAe7s/0V2dIk1LrS632qE1 ZO4hv5RngLbad3OvNlphDDIXtHbqPZd3upsRLaIaau0caiupZMNfDI4Oe0k9wQOy6awfD3Y6HTdL WauuNWytl5d+HeAxuezeQmySIH1NrO7X+qE1dO49PZoPAW703ujeLLRiCKTrA7dRKlLXfw/W6HTp r9I1lVLUNOS2pcC1w/QcL72j4eLJSacpKrVV1q4q2Y5cIHNDG5GQORyncmzrekF6n1rdr/WCorZ3 Et/K0HgLoNObr3ay0YgDy8AcHPKkLcnYS3WrSEl40vX1M7oAXyNqXDpLAOcYHdcNsztJVa/rJJ6u SSktEPDpWY63u9m5TvW/g63pyuqNbXW/1oqaydxx+VoPAXR6d3cvFnom08Z9QN8udypA198O8Fvs TazSdfUVk7JOmSOpLQMduMfVbC0fDlaKWx0s+pr1VwVs3dsAb0D6DITdOkG6n1zdL/X/AImtmcCP ytB4aul03vBeLPbhTB3qdIwHF2F2G52wcFh0sLzpuuqq5kbszMnAHy9h047nKy26+Hl13sX8T1XX VFsbLgwRQgdWPd2QpsmkN601jctT1hnuExcOzWA8BcoTkqXN6toazQUkdXRPmrbNIMCoc0dTHeeo DgD2KiJRqPRR1ElPM18Ti1wOQQpe05vVeLRbGUpy9wGOrqIJUPQRvllayNpc9xAAAySfZWI27+HW W72Jty1VcJbYZcGKCNgLsH/NnsVZSop1Lr263y5/jKid3UDloB4C7XTe912tdubT4L3AY6urC1O7 W0ty0RdGimbNWWyUgRT9OXE+xAXb7ffDnU3axsuGprjJazNgxQxxhzsH/MT2K12z1e0V6l1/dr5d jW1E7uoHLQD2Xc6f3yulstjIOkve1uOrq5K5vdbay56HvfoMZLV0EzsU8wblzvoQFIGhPhwqbtYo a/UV0fa5ZsFkDIg89J7ZyeCpdxJxvcRVqbXt1vd3/HVE7g8HLRnsu709vndLXbW05DnyNGOrqwuT 3R2vu2iL+6ldDLU0UjsU1Q1ufUB7AgdipG0T8NlXdrFBXahuzrVPP8zIGwh5DT2ySRgpurNIr1Hr 663m8m4Tzv8AU6uoDPZd/Yt+Lnbbayn6C97W46g7GVxW5e2d30PqE2+aKSpp5XYpZ2s/3o8cDsfo pJ0Z8NdddrDTV18u38LqKg5bAIBIWtPbPI5U3V1EW6j1/drxevx807xJ1dTfm7KRrDv5cLdao6eR j3Pa3HUDxlR5uRtveNE6kNsqoZJ4pHf7NOxnEwzxgeD9FJ2j/hquN1sNNXXm7stlRPy2n9D1C1vj JyOU3TjEXX3cC7Xa+m5TTvE3VluD+VSZZt/66jtbIHteZGNxkHglRjuHt3d9G6mdaqqGSYSO/wBm laziZueMDwfopR0t8NN0udipay6XeK21M/IpjD1lrfGTkc/RNmp8Izvm4V1ud+NxkneJerqHPZSX afiBrqK1Mgcx5la3GQeCVFWutBXfSeqH2argfLI52IHtZ/vmk8EDnn6KVNNfDPd7lY6atuN4gt9X OC4UroS4tHj5s91ZTURreNxLvcL6bk6dwl6+oc9ueyk+1/EJV01rZC6OUTNZjIdxlRDrDQ130xqd 9lrKaR9QXYhLW/74E4BA+qlrT3wz3m42Knq66609BWSgu/CuiLiB4GQe/wCib0moja6bi3at1D/E 5J3CXq6hz2Up274hqmntLIfTf6rWYz1cEqDdZ6WuWk79ParrA6OeM8EjAe3w4fQrotqtsbzuFcHw W/FNSRgmSrlaSxpxwPqU2uir9yLvV6i/ibpnep1ZAzxjKleh+IeaC0tg6X+s1mBz5UNa70LXaU1a bC6QVlV8oaYWH5y7sAFJtu+G2+zWSKtr7tQ0E74/UMErTlpxnBd7rVmWN1WcbjlNyuBrtyLrPqQ3 MzOEnVkDPGFLFL8RU0NobCWSes1nSPbKrZWQPpquaB+C+N5YSOxIOF3W1u1973BqpGW1raeljB6q qVp6AfZZ21qM5tyrs/Uf8U9Z3qdWenPjPZS/B8RhjtLYhHJ64j6e3nCja0bJ325a7uGmGVNK2aib 1PqMEsPGRjyusd8MGomvIde7R+7s/wAwrbflJJrpwT9zLqdSm6+s7rLs9OeCPZS6z4jfTs/phj/X 6OkZxjKhfdHbO57eVdHDcqqjqxVNc5j6ZxIbg9jkDldHorYTVWqrBFdYn0dFDMf7tlU5zXvb4dgA 8FTa6jURboXVmpv4r6zi4uyW57hTC74jGNtBYxshqPTwMjzhV411o+66MvstrvMBZKzlr2j5JG+7 T5C7zRuwmrdT6fhusH4SkhnP93HVPcx7m+HYDSMH7pupqNVS7pXWHVBuhmcSXZc3PhTJUfEXGLM5 sQd+I6MDjzj3Vb9Z6Uuuj79Par1TuiqI+Q7B6ZG/5mnyF3uj9hdYamsEN1p2UlLBMT6cdU9zHubj 82MHgqba1I4HWGpKvUl1lq6yQvc4kjJ7LQLdas03ctK3uotd5p3QVUJxyDh48OafIPutKorsNt9a Vmjryyppnn0iR1tz3Via/wCIqmfZZWwZ/EFmBx5wqpWq3VV1r4aK3wPnqZnBrI2AkkqU7tsHra02 Ge5zUtLJFCz1HRRTdUhH0bhWJXxsO69zt+qXXN8rnCR2Xtz4Ux3b4haV9mmFKP8AaHswMNwc491V W2WutuFyioaKnkmqpX9DYmtJJP8A7ykq+7Ga3s1jqbnU0MElPA3rc2GXrfj6N7qypxjPTO7VxtWq XXGSRxjkfmQZ8KYb38QtE+0TGj/9Yc3AIGD+6qjarXWXS5w0NBA+erneGMjYMklSJftk9bWOyz3O ttsf4aBoc8RSh7wPcNHdOXZxbLSe7twtOp3V80jnRSvzIMqXb/8AEHQvtE4oCDUObgYGCFU+0Wqt u1ygobfA+oqpnBrGNGSSu+1Fs1rawWeouNwtbRTQDLzFKHkD3wFeX2cW60Vu/XWfVD62oeTBPJmQ ZUu6m3+oP4NN/D3D8Q4YBaMFVLs9rrbtcoKG2wSVFVM4NYxoyTk+fYLttUbS6y03aZrjdbWWUkOO t7JA/GfsVOScXT6F3grbLqWSrqnudT1D8vGVLOpt+7abHP8Aw57RUvHHSMHKqZZ7XWXe4wUNvhfP VTvDWMb7n+gXWat2v1dpS3GvvNpkiowQDKxweG598dk5Lxdrt7vFV2TUUk1Y8vpZ35eM9lKmp997 Y2yTi1lgqZc/kGDkjuVUyzWqtvFyhobbA6eqmPSxjfJXTar241Xpa3Nrr3aZaejJ6fVyHAE++Oyc k4pC233jqbNqCR9dIXUlQ/L8nspM1bvjaobHUCz+k2olJJ9MYJJ8n6qptktFferlDQWynfU1cpwy NncroNUbf6p0vb2Vl9tNRSUzndAe7BAP1x2SZd7OPSTdrd5ZrNfZRc3l1HUOJcc5DSVIust6rXT2 KZlk9KOWVxJ9IYyT3KqlY7Ncb5c4qC1UslVWS56I4xycDK2updG6k01SxzX201dFDI7oa+VvBPst TPvbOXj3NJc2r3kfZbvJDdHE0c7i4knsSu+1lvTaqWxSxWT0mSSEnpi+vcqqFis9wvdyit9qppKq slyWRRjJOBk/yWy1HpbUGnIonX211lFHKemN0zMBx9gU597q8JrSaNpN5P4VcpaW8SZo5nFwcT2J 8Lt9bbxWmk0+6CxmJheSOmM+/J/mqnWW1V94uDKK00stTVvyWxRNyTgZK99/05fbE2L+NW2romyk hhmjIDiPAPbKTPvaXx7mk7bQ7ysoayWivT/9lkJc0k8D6LsNcbw2mh086lsJjZ1AtDY3ZAB9vZVL tFsr7rXNpLXSz1VU4EtiiaXOIAyeAvXe7HeLL6bbvb6qj9TIYZoy0O+yly3dta+Fgtot5YaWaW3X xw/DPyWEngfRdRr7du027T34WwOjY0tLQ2N2cD6eyqZarfX3GsbTW2lnqqlwLhHBGXuwO5wF97zb bnapWR3WkqaV7uWtmYWk/ukuu0uO1jNnt46eNklrvrgICHdBceCD4XR7gbtWq12BlFYSxrSzoa1h /KPZVNtdDXXCqENupZ6moIJEcEbnuwO5wOVldaK4W+YQ3KlqaWYjqDJ4yxxHvgpubXV9LLbSbwUc tJJaNQFvpdJDersWnuFudwt0rVZ9ORUGn3sazo9NrWnJaPZVLt1LWVc3pUUE083cNhjL3Y+wX1ud NX0UgguFPUU8pb1Bk0ZYSPfB8KzLV2mWG5pZ3afdq31tslsuoS0x9Ja3r7OafC9+5G5dssmmorfp 5zRH6fQADyB2wqnUcdRM/FOyV8g8RtLiP2X0uMdZSuEVdFPFIW9QZM0tJHvg+Exz45cky8cynF8L nUfiKmSY/me4uK80LyyUPHBWJOeUs8LFvK7rrJxmotvtNuhatRaVdY9T9PUyIRuDj+doGOMrZblb j2yyWNlusjmhr48EjueMc+/CqDSSyxnqhLg4Du3PA/Rfeeqmm4kkJx4JK1jZixljtbPbzcay6u0z NZdTFnVGzoPURlw8EL7bl7jWyx2QW6ylnQ5mPlAGVUamnlhd1RPLXAdwcLOprJ5h/eSufj3OVZlJ 2XHa3GhtfWHXOlH2vUhYJImgODjzweCEbm7h22y2QWyzmMROaBhoA49lUWmq56eTrhlMbsckHC+l VX1FSMyzF+Pc5U3N7XW1vtJa109r/SRt2oHMbNEGh3VjOQRgj9l8NztwLZZLI202gxCEtxhmMY74 A+6qPSV09I/rimMZ9wcLOsr6mrcHTSl/sScqzKSpZauDp3VmnNx9KNo729jKiEtLs/mDge4/+nyv Luhr+22ay/wm0iMRloGG8DAIPA8chVJo7lUUTy+Gd0RIwcOIysq65VVXgzyl/sScpMp8nH6XBtOo dO7maTiiukrYaqBzSXf4mOB7j6FeTc/XVus1obaLb6YiaAAG9sA5GP1VTLdc6yic400zo+rv0uxl FyulVVkGolc8+5JKTOSpcNrh0V209uZpeldW1DYKyme1xcO7HA88exHC8G5et7bYrXFabd0GOEt6 QDkDpII/mqoWq811uc78NO6Pq7gOxlY3G8Vda/rqZnSO8E8q45aS4bXGhr7BuXpqinqKttPVQPa5 xDsEEH5m49iFrdx9a23T1rprVbCzop3MLBnOOk5Cqfar3X20uNHUPjDu4B4Kxul6rLhJ11Upe73J SXV2a+lyfxVj3IsNvrTVshqIJAXDqwf+Jv2IWs3D1nbtO0NHbLeWvbSuYWgnOOk5AVT7PqG42vqF HUSRtfy4NJx91hdr7W18vXUyOe73J5Kks9rJd7XKm/g24lotlyjrmwSRPHqAPx1N/wATP1Wu3A1n bbBTUNvpSHtpHsIBdkjpPHKqjZNT3O1NeykqHsY/ktB4yvjeL/WXCf1KmRz3n3KY6na976XIrqe0 6/o7Xdae4inETsSgSdPW092fTleDXutbZYf4fSRkS/hHtPJyfl4CqnY9XXS0xOjpKmVkTjktaeMr xXnUVXcp/VqJXudnnJ7pLFksu1zLrQW7XcFpu9FczTxsPTMGydPWwjlv3yvBrzWdtskttpmOEv4O Rjic+AMf0VVNPa1u1op3Q0tS9kWchueAV4r1qWsuNQZZ5HOee5KSz5Lb8LjXuz0mtZLTebdc3QwD 5ZwyTHXH36fvnC8eutZW6y1lqhDhL+Dla4/NjgDH+qqzp7Xl3tFKaemqZGwZ6g0cgFeG9anq7nUO llkc5575W5l9sya9Lg36xt1fV2u72q5PipXD06kRvx1R8nA+ucLya21bbLPcLNC55e2jmDnHPjpL f9VV/Tu4l4stMKaCod6AOQPb7LWX7VVVdaszSyOc5x8qTL7PjUW71Hp+XVNztl0s9x6KGZnp1QYR kxjLgR784GF8NZartlpudjhkkLvwkzXPIPjpLf8AVVn01uTeLNQikhqCYQSWgk/L9itHqDVdTc6s yzPcSTlamc/8mOOusfS3WqNOVWobtQXOx3BrKKqYIaot5PpjLgR784GFy2/12ojpdltZKHTxY/Xj GFCGmN0rzZqBtHHUEwt5b1Zy36LmtU6pqr1PJLM8kuPk9lJncbyvw1wmuMcxXEOnf9SvIV9ZD1Ff Jy4uzEoPZIoCA8oCR7oCiGgIQrAkeU0jyihHZCECKD2Qe6CgQT+6SPKBoS+yMoGhCPKAS8oKaBcI 7ITQpI8oKAiBCChWBpI8ICAS8poQJPygI8oF3QjCOxQCE0vKBBNGEu6AJSTPhGOFQIKR7pogQkUe UBhHlCPsgQ5TQEIF4QmjygSaEggEJoQJCChAeUvKaEBlBQkeSqBCE1RsfKxn/wBy5M9l85ziJx8h eSe3e+njg7ke3C8tSf70gr0weT7ry1H++K6Ri+mGOCsSswPl+6wPK0wxTATwgFAYRhGU8cIG3vlS nsdG1+pA7pAwB/VRY04Puu126vv8FuzJTw1w6SQlFkfiQDht7SlgJxPHnAzgYK5HYGa4Vkwhpz0R Md+ddfBruyV1idTXvpqaeVha5mRyCMHkr56A1LpnStBVOgY1kBe50bWkEhueASfotZZW4zH6csce OVv2l+8wzz2+emoZ/RqnRdLZMZLSRjOFFuzEM1NdqyGrlM08VRIx8hGOsgkZ/VYaU3Cpa2vqqyuq HCBzzhmfGeF0lp1Dpxl7q7jE8x9bWgBuAM45OPcrMla2+O6OqaS30tytDI3OuNVGxsIiblznH3XQ 7cMnprHIysY5k4a3qDhg5wtO+5aRffTepml9d0Bge8ggAdsN9196jX1ioIq+pkqD0uALQMZOG4TS t3pW+RXWlfEXF0zHOAPfPKrFvPUvZvDVFhIwIRx9lJ20+pbfRQVFRV1IaxznkZ7gE5C4G8Q2rV+8 VVcZKostLXRgns55aOcfRdMesbPtyzm88anvRxxouoceQYyf/clURvH/AMVKo9/7x39VavdXc226 e03/AAjTZAmkZ0lw/wAI7Kp1RIZJnvd3c4klMbx8fBvW8+T4lYlZOSysOgCCmkUQgsh2S4TCDf6O gZNqCia4Aj1Wgg/dXopomjbmZnV0M9B+XZ7DConpWsbQ3emqZOWxvDiPsrl6G1dQXixNpKmRhpZW FjgTxg9wpZdnxp0ehaajhjkjoOkwiGLLgSeonOSsrqzr0Nc29RaCZQXA4wOpaG66nsGgrC+OgqBN USOPSSefp+gRpXVFDfrJJR1ckZgqAeo5wOeT2Wseu3PKctug0TTUlPBNDQHrgEcfPVnJOcpV7RLo OsDnGNrusFwOCB1LQ3PUti0Bp8xUVSJp5HHBJ5+nHsF9tM6it+oLDJRVT2GCYEE5wBnk9lb2uPVb 7RlLSwwVENCeunDI+c5ySDlea6gP0DM2R7mNkcQ5zTggdYC0111NZNAad9ClqhPUSHg5/wDp7L7a evtv1Lp59DVPjEMrfzB2APP9VJKt9t/pOlpaenrYaH54GsZgl2c/Kc8rx3eP19AGN0hhEjgHvBwQ C/nlam6ajs2gtONp4Kps9TJ8vV1ZyvvZLtbtUaakoKiRjYpWcODunB7/ANUsvs23WmYIKS33CCl+ aGNo6SXZz8p8ry3uIT6EhjdJ6TZHRh7gcYBeM8rUXfUVn0JptlKyrbUVMo6S4uznwvXabjbdU6aN BUStZG9gDXtd04I5HP3UkNtzp6CCnt1yipsOhjbhhz1f4T5Xlv8AC2fRFNC6V0TJXQ9b2nBALhnl am76itGh9Nx0bapk9RI3oJ6s5OMEr1W+st2q9MOt80wYx0YDXh2MEdufurpL23Fgpoqaz3GKEl8T A5rSTk8NPleK/wALajSVBA6R0bJTCJHtOCGk88rWXnUdq0VpyOhNW2oqZG9JcXZySMEr1UtRb9Wa ZFC+cRf3Y9ORrsYIHH81Nd7T4029ppYaaxV8MLi+KMyMY4nJIDeOVrdR05qdN2mnMz4IpHRCVzTg 9PkArw3zUlr0Zp6K3vqmz1D29Jd1A5JGCV9w+g1fpdlGKgxPY0em9rsAEDgldMOrtjybyx1G2pIo 4NO1sMZL44zKxhJyS0DjleXU9KavTFsp2zOp2SPjD3MOD045AK11/wBRWzSGn4bdJVNnqHt6XOJB ySMEr0zPo9XaVbSR1HoysAMbmuwA4DgrnjNajce9sLYNKVsTcuZE6RjS45OAOOV59VUjq2xWamE7 4GSSMD3MODjp7ZXh1FqC16U0/BbJqhs08jel3zZyT3K+9cyl1lpiOCmqzTzxAOjLXADIGBn6Lpjd aYzm7dPcOik0dV5LiyAvDS45OB9VqLxU2LVmn6Slrq6WD03B39ycHIGFqt0NS2/R+gpLZ67ZquWE sAzklxHfj6qJ9A7faxvVJSXGW40tLSSOz6UsxEnT74xj+az1x18t47lv0sRXNpbZoaf8PI+SniiJ Dn9ytLe5bJq6wUcFXcJqb0yHj0HAHOMc5BWm3c1NQ6V0FLamzCWrmh9MAHnJHdRXoLbzWl4paK5P uFLSUMrg4xyyn1A3P+XGOfutZSfjn2xLlzv0nTW1LDBtRdYKWR0sYpnBr39yvHsXaKe06DpooZQ+ YtzJgdieVq939R0OmtBS2cTNlrKiL0gAecnyttspSVVHoOldXdLZZWAgFwypf9Mcf6dzLK/xyVRr GOj1o7TlLUOqo5XBzjjHzE56f0Uha1tNHeaC3Nu9bPbzE8uZ6BHzHHY5BVebJbKizb8Pju74y5xd UNLX9QDXHj9VOW59lu2pKS0O0/PA1sU3XKZJOnLeO3uteST8lnwz47fxzpu7zCINL01NA38TTOex rpXkA46hg48rDWtDNW1FppYql9ND1SOeY8ZIDRgc8d0r/VwWfSlNDXysbMCzABzkhwK+Wp6ObVVs o57TXehNDIHYae4JHVk/bK5advjTnt42B+xV59TD3Cm/N9Q4cqhEgw8hXg+IbUdusu21ZYmziSpq IvTAyMjnKpBKcyEo1Em/DvbILluTQfiWB7Yf7wBwyMg8K42uKSurrvb6ejq3U0DI5ZZOkZz04wFT /wCHa5U9t13DNVODW9BaM+TlW+1Za67UrKGssNeISxwbI3tlhI6snPgeMLfj1LdseWW609d6p46v TVudUsbIRJCSXDPPUOV49dUlfW3mhgoas00EUMk0mBnPTjAWWrL9a7ULfaZJw6UPYSMjOGn/AFS1 dZq3Uj6CusdcIgw9EjMcOYT82TnwPGFrxXjrbHkm/X29d7p4K2y2eSrjbI71YTlwzzleXWdFcK/U NHDQ1v4SCGnfNJ8vVnB4ACeqL7a7ZNbbVNODKx7XcHt0o1bZ7hqCe31tir2wsBDJmYyCwnJ5z7eE l12tn/3eu8U8Nwt9kfVRNkcZonDqGcFeLWdNcqzUFPFQ1n4Wmp6Z08g6OrqIPAC+mor/AGu11lrt ks4M0UjXcHH5fCWrbNcr9WUFXZa5sUBxHOAO7M5JJz7eFMbqRbNvdd6aC40thfVwtkcZ43AuGSCQ VrNZMuVRqGNlDVimpaSl9d7ejq6z1EAD27L03+/223XG122SZplhka84PtxhfPVlmud5udBV2WsY yll6YqgYyOjJJJ9/ss1qVsr1S09cLC6riZI/12uBc0Eg9K0+r/4pLqQihqWwUtFStncwtz1uLiMD 24C9l+v9torza7fJM0zQuD8Aj2xhfHVVmud2vVBVWira2in6Y6rjOGNyf17rMXbZX6gpK6u0+6qg ZK9s3U1zmgkHpWm1Z/FX6ke+iqBFR0NPHK6MjPWXOIOPbhbC+3+3UmoLXRSTAzQkuIBHGRjC8uqr Ldrnf7fU2mraLdPhlU3HAa3Jz9c9k0bbS+W2jrb3YJqinjklje5zXOaCR8i0eqZbp/aWSWjqBHRU EcLnR9OS8ucQcHxwtrd7/bqfUtspHTt9WHqJAI4yMLwaksV3rtTUdRbaln8LqS38U3HYMGR98pJv Za2t9tNFWaisNRPTRPmjdI4Pc0E/k91ob9U3U6oqZoKlrKChMLPS6SS4vODg+OCtzdr/AG2HU9up Hzt9aIOJA/4hgBay+WO8VeraaahnYbRVOa+o4/L0YI++cK2W42T2zlf2jSb17fw66r9PUYMcD/Xe 6Wbp+YsDeRldlpq00OmI6SxWS3uipY4yXy9GATjj5vJyuI3n3DpdK1lvdTSh1XC53U0HwQBhfbZz XNdrepqKhzJBSRDpJP5er2UvqN7fKj0r62+dTdbhRdULacGmke3ILg0A4PuF7dx9M6k1HVyw2290 dDTFoaxkjSXcjnytzRSXE7mVba5j20DKcCle4fK4kDqAPuuTuFPqc7vMLKOodZHSMcZmty3AaPP3 C9FttuVvw8mpJhgg217DXuq3GFovD2togfWkq4wemVnkNz2Ktlpm20Gm46exWegdBSQx8yBmGkjt z5K4XeTWo0bdbfVx8uLHNIHfle7Z3W1brU1VVJHIKOMdLXEcFy5+THjq/bv48+crLSlBPR7uamqa qIxRVETHQyOGA4DAOD915tWaY1ZX3+qqLPd7fHRyuyxj3nqbx27f6rVauh1bd9x56C2Ojo4I4eqG efIa9vAIaR3OV5dHQ62pNwoaK90kslujec1bG5jdjscpn72zhuzjfhDGurBqi6bk0FivrQ6QyAQy f4HMzy4Eq12oKaqtek6VtvfG19Exjjk4Ba0cgFRT8QU00G4OlpaBpkq8Fgazk5LsY/ZdrvUbjFtm 91BHK6dkbTIGAkhoHzLXjx/5MZ9seXPXiuXyhLdC40+5+vdO0Nu6DPGBHI4njGcnKsfqeOqtOl6a ShdG00DWvcCcBzWjkBUY26ra5mvLdJRNdJUPm6A1oyeTgq4G+8twp9tnvoWSGRob6nSOQ3BySmE5 eefTXlv4/D0hnc6rpt09ydOUtsDDLHGI5CTwQD1FWN1W6ps2mqSooQzFAGukbnGWAYOFR3a+vr2b hW11E18lRJKI8NGTg9/5K3HxCVNdSbavkoWSFw6fU6Qflbjklc8MZfN36dPLlcfF17Vs+JrVNBqv VFBVUGOqCmETyD3OSf8AVQ15X2q5XTTvc85JK+KmWrenTGWTtaj4N9PUT6a73ueBklZG8RQvcMlg I5x91M2l7vd6vUrjcIGtoKt8sUJ6u/p58KMPg6nh/sndIC8CZ9Rw3PPACkzTEF7GqoqSvoxHQ28S yNmzw8yZxg+Vcf8AS/blnP8Akj5aS0XZLVuLqC6UVDDHUBsfSQ38hcCXY9sr16WvN2rr+7+IUrGU FaZGwO6geoMyDx4W0sNVTzap1AyKVjnvMQAB/wArMFaTSIvL9TMoq6jENJa2yAS/5y/kEe/C3fVP p8dGaGsFo19qC60NBFFUsLOggfk6mZdj2ytlpW7XO4XaSO50sbKKsa98J6gepreOR4WxsFRBPqHU DYZWPLnxgAHv0xgH+a0uinXabUH4auofw9NaoXQeoeOtzjkEe4wueft0leXQugtP2LWGorpb6GOO dswDPIYCwEge2crYaTvFddbpUUt2pA2krInTQk8tezgYW109PBUXXULYJWPc+YYAPfEYH9VotBPu VReTBXUYp4rTA6kL8/mcSDx9MYVul28m3egrBp2/6juNBRMbMypc2M9+hpYCWj6ZP81tNJ3WqvlT VUV6owKashM8YcMtfGflW005NHUSahjgka97qt5GD3BjaP6rS7fy3CpurmVtEaeG2U5ous4+Z4IJ /T6rN99ErX7b6DsOlrlqS4W+kaJWVT2MJ56GBoPSP3W30tc59Rmtt99oQIKqD12MfhzXxOPSPt2W x0+9lTDqSOF7Xvkq5S0A98saB/Najb2orq26Svq6J1NFQUwoC5wx1PaclX4T57arbXQth0e/Ulyt 9KPVjqZWAu5LWNAIaP3W503Xv1VFcLXqC3gU9RF67WSAODo3nAx+xXttTfxVo1NFTObJJLVT9AB7 5YAP5rXbd1tVc7lUVNRROpo6SlZQlx4y9pyR+mVbOnPlef8AGl2w0NY9F0uoLpRUvVPHUTNDnnJb GzkNC3VkqhrKguVn1Hby2OWP1RHIM5jecNIXvto/F6b1HFSFsss01SGNB7kjAWv27rqi63OrrpqN 9NDT0zKPLuPmYcuH6ZWtSSlyvJpNrND2TRNpvF5pKYvq2yzNEjzkiNhOGj27LcUHoa8st0supLc4 DHX0SN5DXH5XNP8AqtjQh1Xom6xUeJZnPqQGtPcl7sD9V5dAXKW73CuuElHJTQxwRUuXjGXMLur9 sq2dbLe2g2t0PZNCafuF6poDNW9UrfVk5cGNcQAPbstw2no9xNPXSy6lt72uidnpkbh7Orlrmn/V bGCN9Tt/XRUg9aYunIa05JPquP8ARYaEuTrxVXS6GlfTQSRxRtL/APF0Ag/t2WLO3W1y22GirLt5 pSqvUMRnrSH9c7wC7AcWgN9lupqKg3I0vcrVqG3vZJAQCJBh8biMtcD4OF7KqJ9RtpVR07TLIOtw YzknEvVj9l9dD1oujrxc2QPign9MMc4fm6WkHn6K2TX9Zt/a/TldsdF2Xb/SEt8hhdPXPjJfM/Bd +YtAb7DtwtrX2u27naQrKG90hZVUxLS57cSRPAyMe3hbKua5+18jYWOle1gcWMGTgSAn+QKy0NWN urb3dYYnxU9W9ro+oY6gGYJ/ks6dOnJ7a6Psu3Gi3X1kL56+WMOkldguyT0hreOByOFsL1Y7Vuro yZlzpnQ19KXNErm4kikAzj/3ltbsHt2wp3MifKYmQvcxjckhsjS7j7Ar06FrI7nSXu5QQvip6ucy R9Qx1N6AOr9SFrUmG3LlvyVye2ukbLt1ooXpsbp6+ojDpJiMuy7gNb9O3C9Gq9N2fdbRkktbC+C5 0fUxs/R0yRvaMlpHseOCtzcnGLbS3TiN8jYPQle1gyelrwXH9AF69ESx1trvddEx7aerq5J4y9uO ppjbyPpkFYtss6bmrLd9uQ210lZ9udDsvHpGouNVG0yTdOXEu4DAPbPhZa40zaN0tEPrZInU90oW vayYsw9jmjJaR7fRdFd520W3Voq5I3vipnU8rw0ZPS1wJWekZ462xakrIGPbBVVM00XW3HU0xt5/ qunWp05Xf25fbfSdp210KLrIPxNfWMa6SYs5+YcMA9sry7jaWs+5+hTd6dop7lRRuDJw3By0ZLSP ZdhqCrjt2h7JVztcYYH0739IzhoI5Xn05LBVaR1LPSxuZTz1E8kbXNx8pYMcKzGbjPlzuONsvaiN VEYJXRv/ADNPSVjBE6aZkbTguIbn2ycLY6iAFwqOkcdZ/qvPZxm4U4xyZGf+Zc/P+nLXw9H+PefH fyuNt5o6ybXaOFyqHCor6xjTLM9vcEAhoHsFrt29AWrXulY9T2BsVPcoY8ktaA2dgPLTjyM8Fd9q KtprZYtO1ldxSxSM9QkZABjIGf1IXysr6d+3VykoQPwz5Kh0YHYAvOFnw6z8eNvumWuX8c3ovRVi 2w0mayuEdTX1IHqTyNyHeQAD2wtLvBtvatZ6cj1Tpz0aWtawF/S3DZmA4OQPI91IWsaqmoaHTVTc HBtKyYeoXDI5icBn9SF8bc2MbX1IpgBAXTGMY/w+qcfyXTjNRJe7v05rR2hdPbaaVFVdIqesuE4H qTTMDgT3AaD2GFoN4dr7ZqW0x6n0x6VPK4AytaPkkbkDOB5Ck/Ws9JSnTktyLBSCZzX9YyOYnAZ/ UheOhbGNq5RT49H5vTx26fV4/ks/MJ3a5fS2g9NbbaUFRfIKSurpwPUlnjD2l3/CCPl4PZcvvNtR b7pQR6n0iIYGydPrQgYY4EgBwA7d1Leu32+Kp0+bwIzRl8gd6gy3PpnGV5YmRjabph5iEYDP+X1B j+S3xkkp7lcnprbzSu3el45NRU1Hca+fpMklVE17S72Z1Dgcrkd5tn6OWGPUmjmRRU05aJ6ZvysH UQA9nsOeQpi1s63NuVnbemwupHMlGJmgt6unjgr4tia3aanYDljY4+k/T1BhZymtOeGVu+3Hae21 0noTTMMmpaWluFfOWmR1S0PaHdiGZHAXHbz7QU2Yb/o+ONtJVOaJKZp6WNLjgOZ7D6KbNaR22W42 yO8thdTPhmaPVGR1dIx+vdeGaMN2utbQeoNEGD9nhaxxxtm0tv24/T21mktH6YpnaooqauuUpa6R 83Ia48EN+gXD7x7OspauC8aPia+310jWOp2nDY3uOAW/RTnrultlZWUNPeug00kE2Os4AcACD9xy vMI87b2Jrj1YfTjJ/wCcKSTpqW704jTm0ek9MaXphrCihr7nM4Ple9xHQTx0tIPYLhN2dmJLfdKe t0hGJbVXPaxsXVgQvccAZ/ylT3rulttdcYKa7lohdSylmXFuHDkEEeVgB16E091fMfVphnv/AIwk jet9OA03tBpXT2maVmr4Iqy5TuDnvLi3ozgdIweQFH26uzFTaL1TTaXidV2qveGxMzzC89mknwfB U/6+obdcLgKe7SNZGaJ7osydBDwTgj6r6TBx0npvqPU71acEn7hSTejHu6R1pnZfS1l07SjWAFVc Khwc53WY/TyAOkYPIB8qOt1NnK2w32nOm4ZKy2XCQMp2g5Mbzz0Enx7FWE19b6K6XB9PcJOhraB0 kR9ToIkDuCPcr21+f4DpouPU4Swc+/CmPaybukW6Z2S0xbdP0o1a+WW5VBBc4SGMM6gPlx9DxlRt uTs9ctP6igprLFJXUFc/ppHA5Iceelx+3lWH1/baa7XKaKrnfC6Cg9eAtf0/OH/zW3uo66XS5k+Z wmjOT79Cukw/ZFGmditO0lipm6sqJ/4lM7/eRTGNrcjOOk+yi/cLaW7ab1FFR0MUlfS1knTSSsH5 s89LvqArIbh21lzuFS188sMlNQCohLH4+cP8jzxwtvdAZodLOk5f67HZPv6ZWfnTcx62iXTew9jh slLHqisnZdZ3HDqebDeRkDBCibXu1160xqSO2xwSVsNW/ppJomkiXzg+xAHP2Vlde203G81LhUzQ y0dE2og6HYHX145HnI4/Vb67sM0ulXy8vFQ12fr6ZXS4SacsLym0Qab+H+1fwal/tNcKmC5ykj/Z pR0HPLcZbxx4/mok11tretLajbbHQS1bJ34pJomE+sO4GB/iA7hWa3DopK271Biq5aeWipWVEPQe C7qxg/TAW9vDPVr9JSycuE+c/UxFSY99r1x3PtDen/h7o32qldfrvUU1xmyPTh6S0nuMZGeyiTWu 3140zqNtonp5J5JnYpnxtJ9YfTHn3VmdxYayo1BK+jrJYH0ULJ42sGQ49RBB+mAV0l9ibLd9I1Dw DKJ8dXnmI5W749a/scsPJM5bPi6QnYfh4jqLRRyXm9S0VynBBgYxr257gA8eFDWvdG3TR93loLpG QW/7uUD5ZG+CFa/cNlfJfZ56GtdA6gjjnYwDPWS7BH04ytP8SFDHXaJop3tBmaQQ7HPLeVqeHdk3 7T8368v7pTt3nPC+buSvTUs6Xkd15iF53pYH6oCaSAKQT8JFQPKPKWEKxAe6PshGAgB90fdPyllF 2Ej9EBI90B4QEH9kIDyjHKAn5QNL3T7I8oEUDsg8oQJB+iaECQhCIPohM+EKgS8ppFAeUJpeUAEe UIHBQCEFHlAkz3Qg90GKaCgoDCAjykVQI7JgoKBFLHKaEQIKSaBJhLsfdBQCSAmgEICEAhJNAk0Y SQB7ICEFUHdL3TSVAksieEsfdBsj9F8qjHokeSvoe6+VQf7s/ReSe3e+nkh+vdeWo/3pXri8+68l T/vSukc76fPPCxws/CxK0yWEishgpHKBLLwkE0DC9EEhacDOV5wDnC6LRmnajUd4hoqf5Q8jqeez Qg8sdRUSDpYXuA74BK+pq6h3y9byG8dI5wraT0Nm2k0PH+DgY6rqMNMrmgl78Z5z4HsstoYrfJSV kkUETquvkMszxG3Diee2O3KrPyqXFcKmPIZK9o8gHC9TL1VtbgVMgx46irb6J2vpLFqe53WdkUz5 ZXSRuMYHSHHOAOcALcaVnt911HcvwlFTiJ+GF3pNy4tyPb3TaaUzN6qnNwap5H/OvPUXaomAYahx aPHVlXifUUcV5qqWW3QClg6Q+UQNwC7tk4WVs01ZZprtNDbqM+o5rC9sLefl+ybXSjLbpUxwemJn NYfZ2MrGlus9KXPhmLSRjIOFcTS+1FksepKqr/hsc0MrS5vrM6ww+cZ4UUV1qsce8lzFZR0zooJG +nAWgRjA/wAvYrWMtlv0xbJlMftBFVWS1Ty+SQyOPck5XlJy3nurcbnbc2rVuk3Vtmp6WhraRrpG PjiDGuGMuBDRzkBVJeMEg8Hyp/WpZvUfM90lkQsVGqPKEBBQAGUwMdklk3lWD6RvcwgtXQ2jUlfb WltLM5gPJGeFz0Mb5HtYxpc5xwABySrJ7P7LUQtJvutImSRFvUymf+Vo93fVNmkE3a+19xeJKqd8 jh7ngL1WjVFyt0fRTTPaCc4BVita7Rab1FpmWfSFFBRV0JJb6I4f9HZPZabazY+jgoJbtrlrJGtB DaUOPSPGSQm0sQLd7/X3Kb1KqV7yO2T2Xrs2q7lbmEUsz2j/ACk8Kweutm7BetNvqdGUUdHXQEu6 GOJ9T6HqK1O1+xtIygfd9cgOiAIZShxDfuSE2mkEXfUFfc5fUq5XPcOwJ4C9ll1fdLdCY6Sd7G+3 dT1uDsvZLrpo1uiaRlLWU5LjE0l3qj2yTwtdtbsbRttzrxrgZjx8lJ1EAfUkJs0gu76iuNxnElZK 95HbJXvs2tLrbIfTpZ3BvseVN25GytprtO/j9D0wgqoMudAHFwmafGSeCF49sNiqM2w3fXIIjLcs pWv6cfUkeU2IOvOorjdJ/VrJXvI7c8BbGza3u1shEVNO4NHbPOFM26GylulsDbloenLJYeX04cX+ o37k8EL47Y7E0j7UbvrrrbE5uWUrX9OPbJHlTYhC96luN1nElZO95b2yey2dk17eLZTejTzuAHbP OFLe6OyFC2yNueh4H5iGZKfrLy8fcnjCNs9h6KSzC664dI0SNyylY8s6R4yR5+iu6m5EH3vU9yut T61XM95HYE8Bbex7gXi004ippiWeASeFKG62yNPR2tl10TDK+Jg/vKcuL3OHuCfZenbTYeimsgu2 uHyxtlGY6WOQsLR7k+/0U2s1fSEr5qm5Xer9atmc4jsM8Bbix7iXi005hp5S5o7dRPCkbdvZGG2W +K6aMjlmpA3+9gc8vf8AcH2Xv222Eo5rELrrZ8zDKMxU0b+gtHuT7q7p0hK/arud4qvWrZnEjsM8 Bbuw7kXe1UghhlJAGBknK7vd7ZL+D00V10cyapt5aBLTud1vaf8AMD5C2+2mwVHNYf4praWeEzAG Knif0Fo9yfdN32skQnf9W3K71hqKud7nDsM9lvbJudeLXStghlJaB57rtN39knWSKC56Rjmqbe8B skJJke13+bPstztvsDST2I3LW808D5sGGnhf0lo9z7lN1NRCGo9V3G+Vwqa6Zz3NILQTwMLrLZu1 d6GiZBGGkNH+Yro94tlpNOMguWl2TVVre0NdGSXyNd7/AGW824+H+nqrF/E9aVE9KZcejBC4Nc0e 5yOU2IU1Dqy4324tq66Vz3NILW54GF2Nv3gvNFRtgYGYaMDk5W23h2YqNMPhr9OtnrLVKA0tPzvY 73OPBXR7efD9BV2H+I60qaikdNj0oIXBpaPrkJs6QtqDV1xvlzbV10znuaQWgngYXbUe893pLe2m jYCAMA9S9O8OzVZpKeGssLJ620S4YD+aRj/rjweF1W3/AMPUNZYm3DWNbU0UkuDHDAWgtH1yDylp 0hap1fcajUJu8kp/FZHIPYDsF3dLvZeIoWx9IPSP8y+e7+zdfpCuiqLOyevtM5DY3dPVI13s7HHJ 8rsdA/DuyssTK/WFfUUMsuCyGDALQffI7pvZ0i/VO5l3vksfqyuaxnLW58rd2TeW72y3tp2/OQMd RdhfLdvaC46Mucb7c2avtdQ4NikDcvDj4djjk9l3WhfhzjrbJFW6tuVTQTy4LYIA3LQfBJ8pdpON 9IK1fqq4akr31NfKXkngZ4C5onlSlvLtTXaCuDpYDLU2d5/u53DLm/8ANjhRaVLL7reNlnT1UFXJ R1DJYXFsjTkEeFMFk3tu1utrIOkvc1uOrqwobpIJamojhgjfJLI4NYxgyXE9gArKaK+G78bYaar1 Rdai3Vk3IgiY13SD2Bz5SUqGb5ri6XW8Gvmnd6nVkDPZd7Zd8bnQW9sBYXOa3Adlc3ujtXddGahN JHFNV0UzsU0zW5LwewOPKkvRnw2musFNVakus9urJ/mEEUbXBrT2Bz5V3WZpDd711dLpeTXz1DvV 6sjnsu/s++Vyobc2DpLntbgHP81ym5u1120Zqb+HejLV08zv9lmYzPqAnABx2P0UoaR+Go1mn6Wq 1Fd5rfXznPoRxh4Y09gc+U5U1PhDl51zdblejcJqh3ql3UOeykO0763GhtrIOlzntbjPVjlcVuVt jeNG6n/hr4ZaqGV3+yzMZn1QTwMDsfopS0n8NM1bYaaqv93fb6+o5FOyMPDR4Bye6bpqIiu+vLrc b0bjJO71erqHPZSLat+rjRW1sDmOMjW4BDvKj/cLbe76P1SbRNDJUCV3+yysZn1gTxwOx+ilbS/w 0VNdYaaqvl4NBXz8inbEHho8Aknups1ES3XXl1r7265SVDhMXdTfm7KSrZv5X0lrbAY3+o1uM9XG VGmudvLxpPVRs01NLUOldimexn++B7Yx5+ilvTfwzVtfYqaqvF6bQV04JFKIevpHgF2eSrs1PhE9 x1/da6+OuL53eqXZAB7fRSVQb/V9PbWwBr/UDccO4z9lFms9A3nS+qnWSoppJp3OAgLG59UE8EAe VL9g+GS5Vlip6m53uOir5gXGl9Dr6fYdWe/6Ju/JqIqrtf3aqvxub53CXqyOeyk+j+IGugtbYQ1/ qtbjg8E4UR6n0NerDqh1iqaOV9YZA2JrW5MuexH3UwWX4Y7rV2aGouF6hpLhIwu/Cej1YPt1Z/0R ZJpFlXuDdZ9QG5vnd6pd1AZ4UpU3xCVkVpbAI3iYM6ch3Chm/aMvNm1K6x1dHJ+P9QRsY1ufUJPB H3UzWn4Y7xUWiKetvNPSV0kZf+F9Euwcfl6s/wCit38p1fSFdV6nrb/c5Kqtkc5zjkDPYKSdqd3X 6NsH8PZG785cSD3yo2vOkLzatSOsdXRSC5eoI2xBuesnsR7gqaLV8MV5ntUU9ZeKWmrJI+v8N6Jc QcZ6erI/ostaee5b71lXe6WrId6UOcDyugb8RRxkibt7qvtz0td7fqJ1jqKKUXISemIQ3JcSeCPc KZaH4ZL/AC2yOoqbrSQ1T4vU/CiMlwdjPST2V2zqI23I17W6wuxqKhzhEPyNz/Nd5tPvINH6bZbD G7DXFxI8klRDWaau1LqB1lmoZf4m2T0vQDcuLvGPopmg+GXUb7SypfcqFlQ6H1fwvQ4vDsZ6fZLb faySTUfev32lqtS09cQ704R0j3wujZ8RcYycSk44GFW2XTt2jv5s7qKb+JiT0vw4aerq+ymJ3w1a qFobVtrqAzmH1TSkOEgOM9PbGf1Taaaefdmes3Ap79VAlkDiWNPPTx3Xeal+IIV9iqqaFpc+WMxk EcYIwVXZmn7m++mztopjchJ6Rp+k9Qd7YUwVHw26tjsxrI6m3vmEPqmk6nCXOM9PbGf1TldrxmtI 6231OzTGsqa6vYXNiLsY7jPlTdqzf+K5afqqOFpLp4zGQQMYIwq602n7pPehaYqKY3Eyel+H6T1B 2cYIUs13w46wprJJXerQSPZF6ppmvd6h47AYxn9VJddlkvtw21+qWaV1nT3Z7SRGHAfQlTVrbfun u+mK2giaS6eIxkFo7EKudBYblXXplpp6SV1wdJ6fo9J6g7POR4wpUuvw8ayoLFPcHmgl9KP1DBFI 4ykewHT3TZZKhh56nE+5WK+s0MkEr4pmOZIwlrmuGCD7FfJRp2+2WuqzRt1ZLC934dzgXsyp8vXx DQS2aZlL1Cd7cDjlVdsVorr7dae32uB9RVzuDWMYM/r9gpQ1DsHrSx2SpuM0FLURU7et7KeUvfjz huPCsqWbfLSm7FwtWp3V88jnRyvzIM+FLuoPiEppLNM2iJ9dzcA4wquWSyXC9XeC322nknq5ndLY 2gk/c+wCkfUmxetbDZ6i41FHTz08Dep4p5et+PJDcc4V5M8Y++i926+0alfWVD3Ohmfl4ypZ1J8Q VLLZ5m0Lv797cDAxhVYsdmuF7u0FvtdNJUVczuljGDP6n2CkDU+ymtdO2ea5V1BE+nhHU8QSh7gP fCu14tpofdyus2o3VVTI4wTP6n89lK+qN/6SSyyst7h+IeMAtGCqsWCzV98usFvtdO+oqpnYaxo7 fU+wXb6r2f1lpm0y3C521opYvzuilD+n9AnI4t/oHeCss2oXz1UjjTzPy4Z7KVNV7+0b7HM23yD8 Q8YHSMFVWsNlr77dYKC10756qZwDWt/qT4C7DWG1OrtJ2s114tpZSNOHSRvDw3747Jy+Ti6zbveG ssl/fLWyONLO7LueylDVe/FAbHM22uaKiTP5Bg8qq2n7LX3y6Q2+2QOqKqZ3S1jf6k+Auq1jtnqv SNsbXXu2PipC7p9Rrw8NJ98dlOScXcbabw1NlvshuEhNLO7J5zhSNq7fK3CxTstRjbPKTn0xgkny VVnT1luN+usVvtNM+pq5jhrG8frnsAui1dt1qrSlujrb7a5aele7o9TqDgD9cdlZl8pw30kPbDeO ex3qQV7iaWZxJ+hKkbWO9luZYpo7SY2TSZJEYxknuVVbT1kuN/ukVus9LJVVspPTGzucc59gt3qv Qmp9L0UVTfrVUUkEjukPfggH2OE597OE1pKO1O8clmu0sVzeTSTuLuTwD9V3mt96rdFYXxWUxMke TkRcd1VnT9kuV/ukdvs9JJVVkmS2OMc8DJWz1No/UWmoYZL9aqmijmcWsdK3gkeOEmersuG5pMG0 u8ptNfLT3aQmllcXZJ4BXba63ot0FhNPZTGxzs/LF25VVtP2a5Xy5x0FnpJautkBLYohkkAZP8gt jqfS2odOMhN+tlXRMlJEZlbgOI9j2Tlu7XXWk3bR7yi31MlHenf7PISWknj7Lq9e7xW6ksBpbH6b A8FoEZ4Gf6Kq9itFxvVwZRWiknq6twJbHE3JwByV7tR6dvtgMLb5b6qj9bPpmVuA7HcA9sqzLXaX HfSeNoN5GUcktvvTx6DslpcePsum3B3gtlHp/wDCWExsDmlobGeAPb6KqlmtVxu9a2ltVJPV1ZBI ihaXOIHc4C9OoLFebG+KK9UFTROlHUwTM6er3wpv5XV9LCbPbxRQB9tvkgMJBLC48fZdDuHu5baK wto7EY42FpZ0sPAHsPZVQs9tuF0qxT2ykqauowXenBG57sDucBei92y6WiZkF2oqmjle3rayeMsJ HbOCky+UuKx20O8VMKWS135zfSDSGlxwCD4W63D3ZtltsEdDYHMaws6A1hBwPZVQtdDcLjUmC20t RVTAdXRBGXux74HK+91objbJ2wXWkqaSdzetrKiNzHEds4PhNrpZbajd2hmt01pv3S5haQOs8OaR jH7LY7jbo2216fit1jc1kfp9Aa12cD2yqo2+lrKycsoYJ55QMlsLHPOPsF9rpS3CjlEFwp6imlLe oMnjcx3SfOCOysy1ds3HcWe2p3ZttdZprRqHoLQ0tAeeHNxjHK9G5+5tttWnmUFhLRGYugBpB4xj GVVeloq+WH16amqJIuro6443OGfbIHdO4UtfTRsNdTVMDXcNM0bmBx+mQmOfG8ky8czmq8tfOZ5n Pd/icSV8aaQxTNew4c0gg+xByvk7J790s+Vi3ld11n6zUW82s3QtepdKvs+qCwyMjDHBx/OBjB5+ y9m6O5lBbbQ2gs7xh7MHHc+OVUOjmlY8GEuDjx8vcr7z1E0uPUe4+2cq42T0lm6tvoHcOy6v0u+1 6l6S+NoDg48nHYhY7o7k2+2Wptts7m+m5uCG8KpNNUzwSZheWuPse6+lTVzT4MspeR7lbxyku0yx t6W80Zryw650q63aj6C+LpDuo85B4IK+O5+49utVpFstDmemQM4AHGVUmlrJ4JOqKRzCeDgkLKqr 5qrPXMX9PgnKz1vZ2uDpbWmntwNKGi1B0GWLp6w78wIOQR7dl5N0dw7dZ7N/CbP6bYukNAYMDHfs qkUVwqKV7nQyujPYkEjK+lVcKirdmSYvPvnKbi9rg2PVGm9yNKxwXpzG1EJaXZ/M1wPcfdeTdDcC 32i1C1Wv0/TaAAG8DgggY+4VSrfcamjkLqeoMbj3w7CyrrjU1b8zTF+D5OVdszCb3FxLZqDTu4+l 6dtylbFVQOaS7/E1w7/oRwtdujry32e3MtVt9MRR9OGt7cHIwPCqhb7rWURJpZ3Mz36ThKvulVWu 6ppi93uTlXG6u1uC4lHd9O7kaZo5K2pbDVwPa4u8tcDyMexHC1u5WubdY6CC02zo9OBzC0DkDpOR hVQtl7rbc534Wd0fV3we6Ljd6quk6ppS4+5OUlkTiuPHXaf3H09QVFTViGohka4kHBzn5mkexC1u 4mt7dp+hpbbbCwx0rmOaM5x0nIVT7VfrhbeoUlS+NruXAHgrG6Xqsr5euokLne5KTUpq/C5Rnse4 dmttfJVNhkhe0v8Amx1D/Ez7FavcLW1usNNR2+h6XtpXsIBOcdJ4VUrNqe5WprmUlTIyNxyWh3BK +d2vtXcHl8z3F3nJTqE3LuLkVH8F3Bt1suYrWwGB49QdfT1t8s/mtbuDra3WKOhoaXpeKV7Dy7PD TxyqpWPVV0tMbmUlRIyNxyWg8fsvjeL/AFlxn9WoeXvPflMZJWt32uPX01q15SWu7U1w9ARkNlAk 6eth7s/fC12vtcW6xz22miIkFJI08nJwBj+iqpYtYXO0wvhpKmVkRPV0h3GV5rvqCquMxlne5zz3 JKaiS1cm62+3a4itV2o7j+Hib8s3TJ0+pGeS375Wt15rW22SrtcDHCVtHK1x55wBj+iqtp/XF1tE Bp6aoeISchmTgFeO96krLjUGaaQlx7kqY6latq4t7stHrSa1Xi33MxU+OioayTHXH3wPqDhePWus 7ZZ6+0w9fqNpJQ4nPPYt/wBVVrT+vrraKb8NTVL2xZ6gAfyla+9amqbjUGWolc5zu+Vrl9ucnH0u FfbCzVtbbbtbbg6OjkAZVBjwOqMAkAfrheTWerbZaLnZYnSF7aSYFxzzjpLVWHT+4t1s9F+FgqHe kDloOfl+y1N81VV3KpdNO8lzlZftfjUW61HpuXVF1t11tFw6KGdojquh2D0DJBHvzgYXy1hqm2Wu 62OOWXq/BzAvOcYHSW/6qtGm9zbtZ6AUkUzjE38ocT8v2Wmvuqam51LpZXlxdyclXlv2xMOPWP8A 2ttqjTdVqG60Vxs1wDKGqaIqvp5IjGXAj35wMLlt/bxR/wBm2W+OUOmix/TChPTO6N4tFvbRx1Dj FH+Tq5IHsuZ1TqiqvNQ+SaQkkpjnZd/S8JZxjmLgW+u7pXiK+sjsucT3XxPhcHckvKZSQGeEkwhA kIR2QMICSZQ0OyP6o8o7IhYRj9EZQi7LGUsfRNNDbFZJd0wUCTQUIApEJoQJJMo+iAQUH7IVQvKf ZCP5oBCEeECQmllAHv8ARCaXlAIPdNLygPKPKEigD9UBNB4KBJdimmgSCl5TyqEhHlCIEFCCgWOU I8poMU0/CSAHKX3TRjhAIzyhCAKSfukgEA5TSVgCjKCMd0uVQFCOShBsSvjVcRFeoN5XnqxiL6Er x4+3evHEOF5Zx/eFeuLkn6LyTf7wrri530xxwsO6z8L5rTJpE8p9wke6ATHb7JLIHCBs4PdTBsHG HX1zsZIDf6qHxgfuu6231F/Bbj1Z6Q8jJHhBYH4oA8aSs5jBIbVEuI8AMHf9StR8Pv8AEK8Nax5Z Az/F7roDr+xXDTctFfGtq4pmdJYTgH9VhofWGnNKaemZEwMJyWNYeQPAyVb2zrVSxqmmnuFlrqO2 1TaWqLMCTGS3j2GP6qO9imPhE0U5LpWF7XuIxkg8leXQ+4FG901Xcqk9MhJ6OrsuisOqNOwXCuro 3Fr5iOkAtDQMc8DyVNK8O5up4WQV2naCEvulRJE2KOFgBPIJJXZaObNSabqm1DXR1DBlwPcODSVz tPe9I095nvHpE18oDXTOcCcDjj2SuW4dkobXc5PWLvVa4taCM56SAro26XSF7iutua1uDI1uS4ef qSqtbhzPZvNcSwkZqWtPPjAUsbS6pttqswlr5wCWEd+y4Cgp7TqTde4XiuqC22CfrYwEdT8e/wBF 1x1+PKX5ccpfyY34T3bh06ArD4/Dyf8AkKoZP/vCQrQ7x7p0lJZXWPTZDA9hY97fDcYwqtvPU4ns sesZGscdZW/bFYrIrHhZdAhHnhBygEwUlk1UdVt1A2bVNAHAO/vAVdy4RxDboxynpic0BxzjA6gq N6Jr2Wy+01XJy2N+SFcfSWp7ZfLF+DuD2OpJGY5OAFmwdTpRtG2Gt/AdH4UNYG47HgkrxXdkcmgH NqHlkTyA9wOOOsZXP37WVj0Rp9lHbZ2yzSnHV5Xq07qK26hsbqK4PYaaVvftjz4+qSJbt0el2UsN DXii6fw4a3pwc/4SvJeo45dAMbUP9OJ7meo7OOOsZ5WhvmrrJomwMorfOJp5Pl6s8/deux3y2ais LqG4PYaaRnBJ4GOf6rWkdBp6KmhtlxbQgeg0fJg5H5CvFf4opNBQR1DiyJ5h63A44LueVo7/AKvs ui7DFQUdQJppfkLie/gleu03a26m06aCtmAgcwBrg7ABHb+aJW/sEVPFabiykA9FoIZg5H5SvHqC nin0XQQzyGOKR8AkcD08E88rR6g1bZtGWGG30s7ZZpG9BcTnPGCV7bfX2zVWnRQ1kwZF0Dpe12AC 0cH900l7byzQQQ2G4MpsGFnWGnOeA33Xl1FTRVOk7dBPIYoZHweo4O6TjyMrRai1bZ9IWOG109QJ pZG9Dnk98jBK2EFZbtV6eFDVTCNnQCx7XYDSBwfqpojc2iCGPTleyHmJnqBhzngN45Wu1RSsrNP2 eCWV0MMkkXqOa7pPTjkZWr1Jqy0aRssNqgqGzSyN6HOJznIwSvYZrbq7TcdJNUeiWtBje12ACBgH 64W8ertnyTlNRtaSKOPS1U2MZYz1A3nPAHC8+qKRlZYrPBNK6GnfLH6jmu6TjHbP1Wo1Nqq06VtF PaY6hs0j29JcTnORyV7ZZKDV+nY6Z9T6L4wHRPa/pAIGAfqsadMZpsfTZDpGpbGCWMMgbk54Hblf DVlIytt1kgmmfDTukb6hY7BI6c4ytVqrVNq0zaqe0NqGyyyDpc4nOc9yvdWsotX6fgiFX+HkhIfG 5rsDOMLV9SM67r3+kxujqtseSyMvDMnPAPC+WrqJtbR2WnlmfDA52ZCx3TnDQQM/danVOp7Vpy20 tnE7ZHyDpeS7PfyvdcoqfWFkpwyrFNLA4Pa4HDT4/wBFnV1puPa5rGaOlAHU1j3Nbnn/ABYC+esa EVwstNJO+CDL3OLHdJOGAgZ+61Wq9TWmwUFJZ/XbI95Adl2f1yvbd6en1jZqYw1gpp6d4e1wdgEH AP8AJNJXqe0f2OIeOoNf0jP/ADALHWlB+OdZqU1D6aEueXOYQCcMBA5+q1mrNTWqxUVJZxO173kZ y7PnPde2+UkesrRSOpawUtRBIHtcHYGDjP8AJNI9MzerRkYf8xL2jJ/5wF89Z0Jrq2zUZqZKaAvk LnMIBOGjA5+q1+rNTWqx01JZxOJHlzc5cMjBBXr1BRRawttHLR1ppp6eQPDg4AYJAd9+FcZq7rOU 36eudvXo+nEgDiXsbz5+cBfHWtBJcLhaaVtTJTU/9657oyAThowOfqvBqvU1rssFHZ2zCSTqbnJH GCCvVqOh/tbRUM9vrfw00EgcSHADpJHV/IJJ9rvfT11rRLpShMgDyXxZJ9+sLxa4oai4Xi3U8dVJ TUzGSSv6Dy4jGAvjqrUtqtAorKJmyPDmk/MMgNIK+mqbVLqptvrLVXmndC8dbQcAtJHVn9Fvx2S7 rHklskj23SNsunbc6UBx9SEnP/Mtfrehqa3UVBHDVSU9LHDJLIGd3EEYCWrNT2q2S0No9Vr3h7Ce eR0nOFnqm0VGp5bfX2iuMBhID25GC0n5snPt9Fcctd1Msfr7ch8Q7PW2ame/lxZGST37qjsn5irl /E3qa3UeiX2CGUPncGt78jCppJy8pn/pjGvFP2yv9TD8MFqhr9w4pp2BxpwHsyM4Oe6tjrGjrbhq OmZTVhpqenpnTPAGS8g8BVU+GS601s1fLJUvDeprQ3J78q1+qbNV6jqLdXWet9JrSGyt7gszkrlL rbrlHtuVPFWUtiknja95mjPIzgkFa3WFNW1uo2Npqo08FLSmZ2GdXW7J4/kvpf8AUtsttxttsdKH SwPa48gfl4wnqey1l/uFvrrPXenDkMmbgY6e5JWviMabG5QxVkFhdURte8zMOSMnstPq2CvqtSuN NVGnpqOlEpb05DnZPH07L73zUdsoLvbba+UOlgcHcH24wlqayV17u1BW2qs6aV+GTt8dAyc/X7LK tndoIaqSwOqI2vf6zXAuGSD0rTaqiuE2qXOp6ow0lJTMlLA3PW4uPH07L1XvUdspL7bbe+VrpYHd RwfpjCw1LZLhdr9b661VvTQyAMqWgcdLcnP17oNreaSCquFgfPEx72yFwLhkj5VodTsuM+qJn01U YaSip45DH05DiXHI+nAXuvWpLbT6jt1C6UGWAknB9xjC+OorFcbnqKhrbbW4t04DKpgHHS3kH657 KpW2vFFT1N3sEssTHSMkc5riMkfItFqQXR+ppp6apEdDQxxOMfTnrLic4Pjhe676ktsGprdRGZpl gyTg+4wvhfrDc7hqWjrLdWt/hdQR+JZjgBoyD35yUk+2vptLzbqWfUFiqJYI3TMdIQ8tGfyrn7rJ dX6srKmOqEdBROgZ6PSSXl3fBzx3W2umo7bHqigozODLB1E4PuMLxXWw3Wr1bTVVJVtNoqCJKhoH bpA6fPOcK98bPlzz/wBsW3utso5tV2eplp4nTsEpa8tGfyjytFcpbrJqurqWVLY6CikhiEXSSXl+ OrnPHdbO4ahto1ZR03rD1YGv6sH/ADABeO5WS6z6vp6ilqWGz1DhLOA3sWgdPPnJCT/Wz5dJ1Z9N jdLTQza1tVXLTROqWRylshYCew8rTVs12dq2rqm1LWW+lqIoRH05c7qxnB8d1s6vUNtdrGmp/XBm hY9rsEYy7H/ReKvs14l1lHJDMz+DTuE8uB2LQMA/stb1O3PrcsbK4Wmhn1zbaualifUxwylshYCQ eB3Wrqai7HVVRV/iGNt0NUymbFg9RyBk57Y5WylvtufrKKD1m+rDE5h5GMuIP+i8M9ovLtYtLZIv 4LLJ+Jc4ZPzADAP14WbXSemwq7Fb5td0lwlpIHVTKd5bIWAuByB3/VaoVV3dq+SpEsZtrav8IG89 Y4Bz7YyVtjfLfJrBkAnaZIoXRnnjJIP+i1zbTem60BDojZHSGrc4H/HxgfdLdo902n7ZJuFFcnUc BrG0hIk6BnPVjOVrqWquz9XOqXyR/wAO/GOow3J6xgZz7YytrFe6CTWUkTZ2l7IPSPPnOVr6a13p mtXBzo/4KHmr6h5cTgN+6y1Hq/s9a37ivuZooPxrKMH1egZ5cRnPuvDbqu7v1dJUSuj/AIc+rfRt bk9fyjOfbC2tLeKGTWdTEydpeIGRYz/iDif9VraO3Xtut3NlMYs0T3VYf/mc7IDfuFNG33g05a/+ 0mqubaKAVn4NhMnQMklzhnPvwvLaqy7SavkmqHx/w+WqkpI2/wCLDGk5+y2tDdqGbWlZHHO0vFOy LGf8Qc4n+q1ttoL23W7o6hjG2iBz6pkn+dzyRjt3CaX2+lLpm0xbk110iooG1n4SM+oGDOS52T9+ F49P3K7VOqnS1gYKGonlp4ufmIjBOce3dbqhudFUayrmRTtL/QZFjP8AiDnE/wBVpbDRXtmtDBWQ tba6MyTxy44eXk4APuM8rpjrjduWe7lNen1tOlbTSbj3W5wUMDKr8NEQ8MGQSXZP3K+OmbleKrU7 pa9rBQVUksEQB5xGD4W4tVypKrV91ZDM1z/SjiAz3LS4n+q0+nKW9s1f+GrYAy20XqTMlxw8vzgA +Tzyr8Xad8pr0q18VFnpLXuI40MEcDJoWvc1gwC7nJULqdPixq4KvXTHU7w8NiDDjwQTlQZ5WvPr lNfTXg3x7W4+DnTlFHYLjfpIGPrjKYmSOGS1oHYKXNJ3S61l4P8AEYI20lYJDEQcktbxyP1Ue/CL UQu28npw8es+d56c/QLvdHsvJ1C+C4UggorbG6JkniQuxyPfgLz426u3XKd9PjojRljsmrtSXK30 EMNR6rcOaO2WAnHsDlerR11ulwukjLpTsbS1kb5YjnPU0Hp5HhbTT1TT1V2v4gla90krQBn2YAf5 rS6G/isl8khr6QQU1rgNM1+fzuJzke4x5XSs7fHQeiLFp/UupbnbqGKKf8QQ0gfkBYCQPYZOf1Xs 0dcrjc66eG70rG01bE6eLnIezgdvC2unKqCrqtQx08rHvfUktwe49No/qtJoB10mu0jLjSiCC1wm ka7P5nZBJ+owO6zTbz7e6JsenbrqS4W+hijmFU9rHActb0A9I+mSvbo+5Vt6qKuivVGwU9XAamME 9QfG44x/7y2um54aoagip5WPfJVyFuD3BY0Z/dafQEtyqLvUfxCk/DQ26AUIJ/xOByT9ko8O3Wi7 HpSXUtfbaJjJWVUjWuPJaxrQekfTJWx0lcKq/itt2oKFgiqYBUBjiHB8bzgD6duy99leysodRwUs jHyy1MxYAe4LGgH91rtvJbhWXOrnuFF+Fjo4G0PUeOpzTkn+fdMrZOozveTWbcaNsejYtSXG20jW zNqZmhx5LWNAIaPotrpusn1JT19r1FQtENTB64jkw4OjeSB/Qr22fprbPqOGleySWaoqCwA9+poA /mtft7WV1yuVbWVtF+EipYGUIJPdzDl39Vr4Xf8AWn2z0XZtEWu/3O20uahs84DnHJDGcho+i29h qH6roLlZtSW/EckYlMcmHdTHk4IXutf+2aWvsVGWyzSy1IY0HvnIH7rxbf1tVdK+tr6qjNJDBAyi HUe7mEl37ZVvpzt79tNtdoqy6Gsl5u1DTdVT6sw63nJDGEgNHsOFuLWW6ztN1smpLeQ3pDiyQZ+V /LSCthQt/G6KuUFHiWZzqgBrTnJL3ELy7f3Ce7VlfcZ6V1NE2KOmBcMZLCerOfbKWR020G2mi7Lo LTdxu1BTddYXSAyv5d0tcQGj2W4hpqfXmn7rZdS24t6MdTZW4c0u5Baf9QvcI31ega6KjAlnLpS1 rTkn+9Jx+yw0Lcpbu653SalfTQyNjYwv46ukEEpZNpll25vbLRlm290fU3ekg9auc1xfM/lxw4tA HsFuHUVFuJpa52nUVA5skJ6XB4w+NxGWuB8eF65431O2s8VK0zS4J6GHJP8Ae5P8lloWrdcmXe7P p308NSWemX9nBrSMqanbbltuNJWfbnRMt4p4TPXSMzLM8Zcfm6QB7DkcLa1NBbty9H11vvtG4TU5 6CZG4fG8DIIPhe26RPm2uLadhle2Nji1nJw2QE/yBX10DUfjqK73IU8kFPVPDoi8Y62tZ09X8lq4 zhue9uXK/ks+HNbcaSs23Wh3XmlgM1dLGHSTO5e4k4AHsORwvdd7PbNz9F1MF1pXMrKYuZ6j24kj kaM/p4W0ubX/APZdAYonzGOOJ5YwZJDXgnj7Ar66DqhX2y73JsL4oKuZ0sfWMdTegDq/XCzqSbdN 725XbzS1k230ILzBA+auqI2vkldgvJdwGj6duF6tSWC1bqaGmfcKd0NwpOprZXNxJE9oyR9vottd S5m2dtmZE+ZsHoSvYwEkta8F3b6BerQ9Uy4Wi+3GOGSKnrKmSaPrGOppjaOofQ4W9Tjtz3ble3K7 eaYs+3GgY7rDTme4VMbXSy4y9xd2aPpnwstaaatW6Wh31dXA+mulCHNZMWYkje0ZLSPb6LeXef8A B7fWWqdG6SOndTyyBoz8rTkr7aQqG12nNQ10cUkdPV1M08XqNx1NMY5H0OCsX3Oje99uZ2/0vats 9CR3KOA1NxrGNMkvTl7i4DDRjxnwsNfaatO5mhnXN8Rp7lQNcGzdOHNLRksI9uey6i/1bLfoqx1j 2udDA6B8nT4aB3Xy01I2u0fqGpgjeyKpnnliDm4Ja5gwf1XSSddMZ2yWyuPsOt9PaX0VQUNihY2X gOib8xc8gA8e5K6TWVpptUbZVY1LRQxSOjMsHbLHdOWnI7FcztRt9Taapn6l1O5n4gnrpo88RNPI dn3OSuL3m3HrLlTzR25kraBjiwyNaegfc9sreHjlyv1GMvNlqT5qudZF6NQ5mc9JIz9ivgO6+1VI ZJC4+SSvkwAvAK8+Vm7p6sfXaxHwl6ao669XK71tN6ktGxopnuHALshxHucKSdyqPT2tNHXyGogi iudsc8xPaA17XA8ffI8LyfCteY6vRk1ubExrqJx6nAcu6iT3Ua73askOsaxtCBB8vozBgx14PBP1 W/HjLjcr6jj5M7M5jL7bj4W9I2+tutxu9wp/VqKLpFN1flHUCCceV3W59p05rLRF3d6MUN1tRe6O SMBrmuB7cdwR4X2+Ge9RV+iXUbYGRy0R6HuA5fkkgkqJN4tVvGrbi23gU7ZR6U7W8B5Bxk/XC5/4 /wDy43O/Dp5bcc5hPdbz4X9HWu4VNwvNypmzz0pDYA8ZaAQQTjsV126dh01q7QdyrKOngguls6i1 0TQ0hwPLTjuCPC3Hw33enr9AxU0MDGSUbfTkcBgvOSclQzu1qj0tT3OO2tEEVR8kzGcBxBxnHun+ JrPHLPK+qv8AkW4+SYT5dB8MmhrXczX3i70jaiamf0QslAczBacnpPBK7DcTROl9XaZFdb6eGirq SVrH/hmhmQXAOaR9luvh2vFJcNAxQ01PHFJRgRSlowXu5OT7qKNXam6NxH09qHoU1VVRsmiafl6u sNzj6rP+Njc8cs78Nf5Gcw8kw17SzfLNozQtqttPVWK31EYZ6bZKiFr3HHuSOSue3M250zqDSNv1 DbaWK2uHpvcaZoY10TnAOyB9D3Ug6/udptFJQ/xyjgrWEkNNQ0OwcfVa3cCb8VtOam1sbDA+FpbB EzgtJwAB48dl3xwlyxn28/5LjMr7aGstm3On6C3wfwW21pEbYw+SJrnv9ieOSVz29m2tiqdExahs tvjtNZBGHOp4ogxsjSeQ5vgj3W52u2/Zabc2/wCrpOqoLS+Gnk5ELfGQf8Xn9VpNw9as1Teqaw08 jmUlTM2mJYecOOFMcZvv06ZZWzr2jTYm00FTqx38ds/8RoJWei0viLmRyZBznsOF23xAbd2ymulj i0xboKSeqPolkQ6WvJOAT+pUvBtt29tlosVrhYx9TKyMydIBkJIBc73JHlafdxoOs9HDwaxn/nCS e7Z8Lvdxn9aPT20+kNL6YpWauo4a64zPDpHyOI6CcDAIIyAo23x2pZpiVt50/wDNY6gjLM/7hx7A fRWE15S22tuTae8Oa2E0chjJcW4eCcEfVfC901JW7d2WG5hr6Rxp2y9Z4LcgFZ8c3ZtrPr0rzspt LUatq23K7xOjssTuA4EeueOPfGPK3G922VvtN+s1JpGhMb6xhj9EPJDn5ODlx4VifSpoae20Vlra amp4XMAj5y5oI4B+3C0G4lr/ABGqNMVwnYHw1bWGI9yCTyFJerf4mrcsY4jTOzOlLJYKdurR+JuF Q5rnOMhj6MgZaADyAc8qL96Nq5NG1ja61dU9jqHf3bu5hcf8JPkexVjNwKGjuFwkir5fTEdvdLCQ /pIkDuCPdZ6woaO6aRsdFdsOpJnwtlJdjjHfKuEt1/Vt1Nq37J7Vza1rhX3DMdkgeQ8c5nI4LQf8 OO/6L7b97fW3R12ohYWyx0s0OXMe8v8AmBPIJVpo6X8H/D6SyzUkVHG5vW0HDngceO5Ufb56PqdT 3Oyx0tTDD6r/AED1gktzk9WPKuPe9s3fWkF7IaU07qm+1lt1I+dsrommlEUvQerPzffhfffDb+g0 deqWGzOm/DSw9REr+o9We+VYfTlk0/oia0Walo4X3CZ+fVe0Ofkj5iHd/BXM7uWejv25WnLdciRS TgteWu6Tjk9/0V8GF75fSeW7uPBDWzm1tTrW6Nmr2zQWWMEySt+UyHthp9wcFfXdXbFunNU0dqsL qmtFUwekyTDn9XnkD6Z7K1lNQyWw2+hsUNNFboyPULXgEgDwPK5fVlpqDunpa5jpNMHOhdz8wd0u I49lfFq72zlu5Y6R3p3YC0ttNINSXCphucxIxTyAsJxkYy0Y48HP3USa421vWmNSR2owyVX4l/TS SxsJ9Yd8Y9wO4Vl9wKOSrvtVIyqlhloqZk8AYRgu6sHP0wF0V5Z6lz0lK8dTvxB5P1iKvDWpfmNY 5cseU+0NWL4e7e+10Rvl3q6W5TZBjhLXMLu4xkZHH3UTa02+vWmtRC0T08k0k7umlfG0kTDxjHnH dWV3GjqpdRSSUtY+B9HFHNG1oGHEuwQf0BXUX+Nst80jM8AyCc4PnmMq5eKzX9c8PNM5bPi6QrYf h6jns1FJdr5NRXGYEOgZG2RvV3AB48fdQzrrR900heprddYiC0kxyAfLK3wQrYbgsrpL5PPRVroP 4fHFM2MDIeXOwR9OMrR/ElQw1mkKGeVgM0bstdjnsmPityk+1vmnHlPvSnjx78LBy9VY3olcF5eQ uD0xjhLCyKxQAS/mn4QgSE0iiDyj6IRhAIKCkgeUDskhA0JDlNAiOeeyfYZR3TRWPdMJeU0AUuyZ P80kDzlJBQiEmUYQO6BpIPdCoD3R4QhAJJoxlABLymDhJAI7p+UsIA98oKEeUB3Syn2SJQHcoKAh AkwhPygSEyMJKoR5R+iPKEAkhCKEDujHKB3QB4QgowiEU0Y/RA4QJCaX2QPwhASKsAUimQjwqEU8 /QJJ/qg3PTheSvGIRwSc5XuK8dw/3IXjx9vRk8MB/NkYXim/3hXsi7Lxy46yus9ud9MRnCwPdfTx wsFpgJHhPKWEAO6YHPKSaDIL0Uri1xwT75XnAJC63QGlZ9U3mCijcI4S4epJ7BUa2A1dSD6LJ5uj uWMLsffCybPVy5DfWeGfm6Wk4+/srZ6gdatqdGw0NohZHVVmWB5aMuIHJd79169oIaB1jnpqWFgk qep8r2tADiQc54+qm0VCirJwwNbI/HsF6m3Kra35Xy8ffhW72322o9HVtfXvLJXnqLZCwBwHc/Zb TQlXR3W63KampYY45XlxcGDJx7nCu0sUxddqsjDp3/qSF8Km51EoIfM4/TPCvMy5RtvFZFVUkTKO GX0fW9NoGT7nCztmn7ZU090LaKnfHPK6MubG3LmkY74TaaUUF0qWQ+l6zgzw0FYU10np+sxyuaTw SDhXM0VtdZ9M3isnjoIZY5MmN0kfX0DPbJCiWC32Sm3hvclXSU8vo1jhFE9oLG4x/hxjKbNIEqKi Sdxc9xce+ScrzH+itnvLt9bdTaYffbc2OkqqSFz8sZhrmtGSMD3VTHZz28ZWvjZMpu4kexWGMeVm QseyjRJnwhBQA5wsgkEwg+kTixwLV0Vn1RX0EXTTzvZjxnhc23Jwpl2F2yg1bc21t6GbfF8zYf8A 5IR7/RLdGkbXG81dfN6lRM57vq5e62aruVBH6VPUPaB4yrT6k2x0XcaG426mtlHb6mNhInhYGvbg ZznKhnZXauDVN6lqLtI51sp3HpjHBmwfPsE7idIyuV9rK+Yy1Eznv8ZPZe+16vudvi6Keoe1vtnK s3qfanRVfbLnQUNvprbVwsLhPE35h0jPkqIdkNqItW3R9XenEWyFx6YhwZsHz7BNmkZ3S+11wqPV qZXvd4JPZbK06yutvg9KnndhvbPKslqzaLRldaLpT2uhhtlbTMe9s8eXOHQCSOTjBwop2R2oi1dV /jby4/w6M8RN4MuPc+Am00jO536uuNT61VK97/GT2W2tGtrtbYBFTzO6R2zyrE6s2a0hcrVXU9ip GW2ugJxKwl5y3xgnsV87fs7ovTWlqWfUdKa+okI6pXSFmXO8AA9lZbfRdT2rNedQV9yqvWqpXvd4 yeAtvZ9eXe30whhmd0AYGecKftUbKaXu+lpKvTtK22Tsy5spc5/bwQT2K+Vr2k0DZbDTfxsfxKtf gvk9Ut5PgAHsps0rdd9RV9xq/Xq5Xvf9TwFurTuDdrdSiGGZxA4GTyps3B2b0w/Q89009TOoJIGu l6i50hcGjOMEqINn9HW7U19b/G3SGijxmCN2HP8AufAV1dcvhmWW8flzF41JcLnV+vWSve7xk9lv rNuLd7dSthhlLgBgdWeylHffarT+m9M2+q01QzR1k9QIw31C8uBGccr37f7D2un0824a3MhqZwCy nZIWCMe2R3Km2pEBXnU9wudaairle9/jnsuhtG5d4ttIII5nOaBjk8hdnvRs3HYKFt70q18lrDcT Qlxe6PH+LJ7hcZtTtlctfXX04g6ntsZHr1PT2+jfcq962dNDedUXC6VhqamZ7nk8ZPYLorNuhebd Rfh2PLmgYBJ5C7jfXaez6Rs1mdp2CqfW1FQYXh0heX8DGB75W80FsFa4tPNrtcSTiqmwWQRSdHpj 2J8lLuJLL6QPeNVXG51pqamZ735457LpbVujerfQiCOTIAwCe6kLVewccGpKB9olkbYp3BsvzdT2 Y7nqPuu1uWxWgbXFF+OfcWdfAxUkZx38JN3ouorHedV3K6XD8XVTOdJnjnsuqtW7N3t9AKdjurAw CSV2O6W32gbFo+uq7PNXi5MA9APn6wTnsRj2XIbJ7f2/WN1eL5UTR0YHS2OF2HPd9/AUuWvayb9O TvGq7ldbiaupneZM5Bz2XW2ndu82+hEDXh2Bjq6iur3Y2Zo7NdLNbtL+uZ6yRzXuqJOoNaMcrrqf YHR1voaaO83StfWPHzOhlABd5wMLVlx1tnHLHObivV31fc7nczWVMzzJnjnsuutO793oKEQNPVgY BzhdVuzshT2CzU1y0q+pqIy4Nkimd1PcXEBvTgLeaM+HWhfYoanV9bU09bPgtigcB0Z7A5HdZuWv azV9IKvGsLlc7o6uqKh3qE5HPZdna947xQ28QNcHFrcA5OV8d19n7ppK+MjtcVRcLbUPDYHhvU4E 8BrsDCkbSHw40L7DT1GrLjVU1fPz6UBaAwHsDkd0lq6iCrvrG5XK6GuqJ3mUnIOey7a2b0XeioWw AdRDcB2V4t0torrpDUDae3wz19BUODaeRjcu54AdjjKkvSPw3Uk2n6WfVVyqqS4znq9KDpwwHs05 8+6WkkV51VqKtv8AcJKuulc97jnGeAtD3Uj7wbZ12gr1IzD57Y85hqCM8f8AFjjKjdSy+2pZfT3W qvloKqOaB5ZIw5BBUwW7e260luEIHzhuA7Khq30dRX1cVNSRPmqJXBjI2DJcT4CsvpT4bIJrBST6 nu1TRXOc9XoQNa5rAewOfPukKhO463uldePx81Q8zF3V37Lv6DfG50lvbAGkua3APUuV3D2uvWld WC1MppquKd3+ySsbn1QTwDjgH6KV9MfDVHPYqWbUl4no7lPz6ELWuaweAc+U2zqIUrtb3SrvRuEs 7vVLuoc9lIlDvncqa2iDpJeG4BB8riNfbZ3rSurP4P8AhpqoTO/2SWNufVaTx24B9wpb018NAqLF SzagvEtHcpwT+HhY1wYPAye5V3SyIYrtd3WrvRuD53et1Z7/AMlI9FvvcYLYIOlxka3APVxlcBrj be96X1WbM6lmqXSuxSyMZn1Wnt27H3Cl3TfwzSVNipp77en0dxnBP4aOMODeOBk9ypskiHanXV0q L4bi+d3rF3V3/kpJp9+rhBbBAGP6w3HDuMqN9W7dXvTuqzZJKWWeZ7+mncxmfVB7dvPupgsPwy1F RZYJrxfPwlxlBd+GZEHBvsOrPJ/RXdh1pD8+u7rNfDcnzu9Uuz3Ulwb+V8Ns9BjZOsNwCDxlRfqb QF7sOqv4HNRySVb39MHS3PqAnghTHZPhirKm0Qz3W+NpLhI0u/CtgDgD4HVn/RO57JJfSIpNfXSW +fxJ07jKXZ7qTot/q6G1+i1rxIG4BDuFEd80Re7Pqf8AgVRQyur3SdEbGtz6mTwQpqtXwxVs9rhl uF+ZS18kZcaYU/UA7H5erq/0Vu57Jq+kSHXt1N+NzdO8yl3VjPH2Uox7/wBZFavRa2QSdOBg8dlG 9q2q1JX62dpn8IYKuN397I8fK1n+bPnhSwfhhHqmF+rIWy5x0/hPP/iTdXURAzX90F//AIiZnGQu yRnjHspVb8QFVHaTDGHiXo6QM8KMddbV37S2qobM6ndVuqXYpZY28TeO3hSbR/DHdZLYyWpvcENa 6H1PwzYC4h2M9Ocjz5Td+UkxRdT7g3WHUH8SdM4vLskZ4wpWk+IOobazExsglLOkc8dlBVVpO80+ pjYpKGX+KCT0vRDeSfcfT6qaoPhivLrY2aa80zKsw+oaYQkuDsZ6c5A7+VOS8Yjij3HucOof4kZX lxdkjPhSrP8AELL/AAt0MQk9Us6RzwoGfpa8N1GbE6hl/inqel6PTzn/AKfVTS34Zr5/ChO670gq /R9U0oiJcHYz05zjvxlNmoju3bkXSm1AbiZXFznZcCfClep+ISX+EvihbJ6pZ048dlAMOmLvLqE2 WOilN0EnpGDp5Dvr9FMc/wANOo47O6qjuNFJViH1TSdJD84/Lnsm01HDWrcq50mozcnTOcXvy4Z8 KV6/4hnutT46cP8AWLOkZVfKLTV2q9QfwWGimdc/UMZp+nDgR3z7KX674bdUU9lfWQ1tDPUMi9Q0 gDhJnH5R4/fCbXUchZNzblQ6hNxklc7rfl4z4UsXL4hvUtMkUAf6pZ0jP2Vdbdpy63C/ts9LRyuu XqGMwdJDmkHnPthS3dPhw1VR2SatZVUFRNHH6hpWF3qH6DjumzUcxYd0LjQajNwfK5we/LxnuFLF 5+IYTWeWKmL/AFns6RxhVytGnbpdL9HZ6OklfcHyen6XSctIPOfbClW9/Drq+22aor2y0FUYWdZg hc4yEewBCTKpcWh01uhcbbqI18sjnMkfl4z4Ur374hWzWWWKlLjK9uBxhVus1gud4vcVqoKWSSuk f0CINOWnPOfYBShqD4edY2ey1NwJoapsDOt0NO9xkI+gLQnK/K8YizUN4qL1cZaqrkc97znk9lql m9jo3ua8EOBwQfCwUrUSHtRuBV6NuTAJHfhHOy5ue31U4aj+IKGayzR0biZntx7YVYdOWO4aiu9P bbRTPqKuZ2GsaM49yfYBSVqnYbWWnrLUXGeGlqoYB1SMppC94Hk9OBnCRLH00Ru1XWfUL6qokc6G V+XjKlTU/wAQME1kmjoXH13jAwMYVYtOWG46gvEFttFM+oq5nYa1o7e5PsApB1ZshrPTdnmuFVSw T08IzIKaQvcB74x4VlZ4thoHdussuoHVFVI50Ez8v5Un6r3/AKeWySx0Lv8AaHjHAwqv6bsdx1De ILdaaZ9TVTOAa1vj6k+Au51dszrHS9ofcbhRRPp2H5/w8nqFo9yAmzi323u71XZL86ase51PK7Lu eykvVu/tNLZZY7e8eu8Y+UYIVYdOWG5agusNutVO+oqpThrR2H1J8D6rr9ZbS6u0ja/4hd6BgpQ4 Nc+GQSdP1OOwV2cXV7b7v1Nkvb31r3Gnld1O5Uj6w34pZLJLHbntEz+PkGFWDTdiuWobtBbrTTvq KqZ2Gtb2H1J7AfVdTrba7Vmj7WyvvdvEdI53SZI5A8NP1x2CnI4/DtNs94Kmx3l5rnk00zsu57KQ tZ76UbrHNHanME8h59MY7+6rFpmw3PUV2ittnpn1NXKflY3gAe5J4A+66TWO2mqtJW2OuvludDSv d0dbXh4afrjsry+UuPWkgbWbwzWS7PbcJM00riTk8LvNbb30QsckVqcwSyE59MYzn3VYNM2G6aiu 0dus1LJVVkmS1jOOB7k8Bb7WG3+qNJ2+Krv1tkpqeR3QHFwcAfrjsky+S4daSZtRvFLZ7nLFcpCa aUl2SeMruNcb3UX8EkhtJY2STOfT4zlVOpY5Z5mRRMdJLI4NaxoyXEngBdJqjRepNM0lPPfrbNSQ znEbnkEE4z4SZbuy4/CX9pd43Wqvkp7vJ/s8mSCTx9iuw1/vTQNsRp7M6Nrn5GI+ByqvabsVz1Dd I7fZaSSqrHgubGzvgDJWw1VpHUWmWwm/2yqomTEhjpG/K4jwCOE5fJx+Ez7R7x/wyolpLu/qp35I Lu32XV6/3lt8Vg/C2R0bOoEdMfAGVV7T1kuV9uTKGz0ktXWOaXCOMZOAMkr26n0xftNeiy/W2poh Nn0zK3h2O+D2ynL5Xj8Jz2g3ibRF9DeXj0jktLu32XR7h7wUEFhbR2R0cYcC3pj7Ae30VXbBaLne 64UlnpJ6uqILhHC0k4C9OpdPXvT0kMd8t9TRvmBLBK3HUPorMtdpcd9LA7R7yRUsb7feHj08Et6j wfot3uPu/QU9ibRWQsYHM6eiLAAHt9FVqx2i6XmrNNaKOorKgN6jHCwudj3wF6NQWa8WOaOC9UFT RSyN62NnYWlwzjIU33s18LEbQbw08VJLbb2W9AB6S48Eey3G5G7VvpLCyisZZHGWdPSw8AewVWLL bLndakwWujqaudo6iynjL3Ae+AvrfLbdLTMyC70dVSTOb1tjqIyxxGe+CrMvkuO1k9pd3qN1umtl 8ILekhoeeHA8YXv3J3Wt9DY47fYy1kfphgaw5wPZVZtNuuNylcy2UtRUysHU5sDC8ge+Avpd6O5W 6ZsF0pamlm6Q8R1EbmOLffB8Jy1dlx2sztTu1QVNomtN/wChzQwtDZDw5uMY5+i9+4e6Nuo7RBb7 Q5rICwNIa7OG+yqlb6auq3uFDTT1D2jJEMZeQP0TucVfQyiK4QVFPKW9QZOxzHdJ84PhJl3s4roj W+lL1pmkpbgWTRek0Fhk6eQMeOV4K+/aOpdDXO0W6OOKmmifmPr68lw5PKptHX1DGBoc4D6OT/iM +CC84+6TLVS+OZXfy+Ne1ral4j/KHED7L4M4cChxLiT7lAWbd3bpJqaW1+HW96Xsmio3mT07lOSK lxd3IJxx9lFm/wB/CTrH8TZJHGOojD5QTkdeeSP5KL6CapjY78OZAO7ugE/vhKqqJZ35keXOHHJ7 JLrGyfLNwlymV9xa/wCH28aas+h6ctlLLhOP9qy7OXAnH27qHN9YbdFrKae0SukgqG+oQ7w/z+ij ajrKin/3T3t9+nI/olWVU1S7qmkL3DjLiSU8dnjxuM+Vym85nfcW22BuemrNoSl9GoLaypZ1VPU4 EdfPb2UH720tDTa0qX2uoM1NMPUAPPS49xlR5RXCekyIJnMGckAkBFbVy1b+uZ5cRxnPZTCTx43H H1UznPOZ33FudhavTdn0LSehVOFVVxiSpDjn5+c49lCu5bKKyblOnoZ/Xo/xEVU3PcYeCR/JRtQ3 WppGhsU7mNHYdRAWFdWzVcplmkMj/cnKvi148bjPlPJOeUzvuLnagk0vr+zW6avr5YmAdYETsckY wVlqW/WS0aWt1mpakSQsdFG1zjyGtcO6p1QXuupYRFFUvYwdm9WAsqq+V07QJJnPA7EuJW+STCTe vldjVws2paGKB93lpmAcmHBz98rk9R2HRtnsVFW0MNM642+SKRtS1vTJJ0uyer3JVW49S3IMDfxU mAP85Sl1JcJYTFJUSFjuCMk5UWxci+iw6qZaLw+5GCSkcKiNrcEEgg4P7LRbt11HWWS1akoalgqb dOycQk56hnJCqvR6nuFNB6DKmRsQGA3rxhYTakuMlK6nknc6Bw/KScK7/qaXAir7BuFY7fWVFSIp oXguw7B/4mn6FcxvHrG3W+w/wS3uHpxtDWnqzjHbCrLaNRV9uDm0s72MdyQDwvhdrzU3CTrneXuP ckpjZjdmU5dJp2SuU191cPxl1/Dw0TWzhrzxIerGFKe79WaGS06goaqKVtDM0yQZ5c3PcfbKp/aL nV22pFRSTOjkAxlpxx7Ld3DWNyraT8PVTvfGecEqS97a16W3qWWXX9DbLm2t9EwuAkb6nT1txksP 7rl96NXUNHY22mieMwhvS7qyR09sFVrsurbna2OipaiRkRPVgHjK8N8vlXc5jJNI5zj3JKuFmN2m U5TVTnsdcq/UeqXPnuTI4KBrZnMlP+8BOMA54Upa/kbQ6q0/fJKuP+HQy+lM0HJaSDh325CpzYL5 WWaqM1FM6Nzh0u6SRkLf3TXNxuVH+HqZnuZnJBKSzey7uv4ttqGzfjtWWjUkddAyjoY+p7CclwOe 2PuuB+IWCoiNt1FQytMUOGhzH4c09wePuoNptwbwyj/DOqXmLp6f0+68131vcbnbfwVTMXwgYAPK 1jncbtMsJZImTZG83jU+qWyS1jDT0TWyTCQ4LgcgALu9yqypsWq7JfpSJbTDKGSBruWkgjOP1CqZ pnU1dYat89DK6Mvb0uwe4XQ33cCvvFD+GqpupuQcErON47Msd2X6Wlv2n26ur7ddrXXubRygMqgx wHVGMkY+ucLyax1bbLXeLJG+TqbRyguOf+Et/wBVWfTu491tNGKWGYmJpy3Pdq0961PU3KqdLNIX Od3ytTL5prrUW41Jpl+p7vb7ra68topgI6rpcM9AyQW/XOBhfHWGqrXb79Yo3yEto5svPtlpb/qq 3ae3Mu1qoG0kcxdGz8vUeR9Fob7ququNQ6WRxc8nJ5Wpnv8A2+HOePj1j62trqrTdZqC80VfZ68M oKkNjqy3khjcuBHvzwuV39vFFJYI6BkgdPHz3+mFDOmd07ta6BlKJyWs/KXZJA9ly2rNUVF2qJHy SFxd3KY+S491b45rU9OVrndVQ/2yvKSvpIck+6+R+i870sUgFksUAUJnsgoheEuyfbukEB5QhCAQ hCAKRGU0eUCQjymgEZSygeEDwmjKSKD3SPdP2QiFlNJCB/RI/VHshA0DuhIlAHsjHdGE1QkYQhAH goST8oDykmg90CTxykmUC7hGE8JFAu6PKaECTBR5QO6AKX2T4yl5VQvKD2TPCEUvCPCXlPHCA7lI J8oCAxyhCMogSRlNAkIR2VCyn90ghUBT+6SEAnn6peeyMIN47uvHcv8Acj7r3lvAK8Fz4i+5Xjx9 vRl6eCAcZ8LxSf7xy9sPDSF45OZCuscr6I9vssFmTwsFpkeEDlCEAU8cZS8p5QZsA6uQVNnw8sD7 wTj/ABNUIt4C7/bjUbrJVj5ukOI5QTZ8VDJfwun5ImuMcck3W4AkNyG4yV6fh9huFdA17pPSpo// AHS+tZuBYbjpme33iFlW2ZnT0OdhpPg57919tK68sWltKOpoW/3oYekNIHOOFdIlDXFHNc9N3Olo Ks0kojcfUa3JGATjx3C4rYVpFtPqAh4Y7IPcFa3QO4VCyJ89znc8yZOOrtldBYtY6dpaisq2gskn kc7h4AwfbhNI8G4+pm11RUaYtkEk11NYzAjAw1rTkkrtrK+Sg0dVmZpZPCyQuz3a4NK5yh1LpChu 1Vc4oAK2pdmWXrBc79+y8Wo9wrLTaZu8TXl01SyUMAI4LgQE0O40reorzbY3s5kDRl2Byqp6nmcN 6Lv0OIBuTx+mQpe2u1harLp2J1dOM9AzhR3pOGzXvcu6366ykUTqt8sUIPLsngkpro32nDUBDNor lkd6SX/yqi7z2+yshvnujTz211isJDKcs6Hlvtjsq2k8rX/hMWMZedy+yKxWRKxxyo6BCEf0QMJr EcLJB96ZodI0E4ycZV0vh+hoqXTscNI3qkLMmUnv9lS6lBdIxrRlxOAFcrY8Udk01E6urGNn6MFo 5AysZS1Y4bfnWJpdSOtdtHoTNy2eUOOXdQHdSTsNBRU2nmxUzeqUtLnSnz7qDfiFitMmsIa+01kl RU1uRPH0gNZjAaQc+VNOygpLLpiE11awTmPDm9wMrr5bLZxcfDLjjrL2jvfXWX4XU01rtg9CUZZU SdR+bq91KWxcFFS6biiowS/oLnSk9/soB+IKntrtcNq7TWuqp63Jlj6QAw8AYP1U7bLMprNpeB1d WRifowWDnH6p5NW9Hh3Me/aON8NaCk1NU2m0kwSOLo6l/WcOJ4OVKex9NR0mlqeGl+aRrMukJ7/Z V539o6Fm4Dp7ZWGrkrsyyMDcCN2cAAqwGzUVPZtJ0346sYJiwBzP8v6qZ/xcNyduY1dquOPcx9qt Ubg4EtqPmyHPzyVJOq4rcdPUbdRt9eEuYWMY4sAdjhQfqNtut+9RrIK8VLKsGd/GAxxOOn69lL+r KKi1jZbfCLqKH0JGyZ6OsnAxjGQrhJvtnybuPUevVEvobb1ktjxTQxwvOHDrOAOQOVFm02jrtqT0 r7qqWSC0x/NDC4kGTHk+wUq19ZbaHTTLT+KZVvlBjzjpBz7hGraOO76dgtlvu8NuaGgF7W9RxjGM AhTH/XjWtXdqM92dZOv87NI6VA6H/wB094/KB2OV2mjNIWjbjTtM2OJs9yquHzvHLnYzgfRa2x7f 6X0rQisNUay7NyTUveQXknsG9l2V6jpr9BaZW1sVM2mkL3B/JdwBhXK76+DHGTv5eXciJs40+HtB zUF3bz0he3WtHFV/wOColMVP6ji8B3T1YaMBeHXVZRzW+grRWQRiikc4se7BdwBwsrh+C1nZaYSV QppYHCRkgdgeM/yCxdtx9r1bYrlt9UUT8iGQlhOeenq/6L1Wm1UljsdLbNPSUdNE383Ufmd29h3X B7wa+t+l9Ots9tkEszm4Jzlcdsvf7nqq9E1MzY6aHBL3ngn2C3u8eO2et2pl15ao66azVEj4Wikn 6g13d5OB8v2X01nQR19XZ6aeZ8NO10jnlrunOGggZ+68u4U0LGUFeKqnDKOQufG5+C/OAMfss7rD S6xt9JI2rFLNTvEgeHYGDjP34Clnquc29tQ9kGjYpJHdLGOaS4+3WtHrZmmtWxU0NfWVUXouLmGm k6Dk8fVePcG82+Wip9K0dT0NlLRLK05c1gOePqVpbhtlEam21Wm7oYmxuLpxWzuPWOMYwPumPXa5 TbldzNnG1VtoZtOVdSWukDZPxcpfkOIAx445Uj6H0bY9u7fSUMcTai6TkF8rxkuPGSPYLobxW0dD baKimnjdMXMHyOyPlOSsL5QPueo7VcYKiBtLTNcZOt+CckHgfolky7phbjqf1FnxMXqax3Wy1FOc PAent9RUmo6GnuepLtUtqSQ6KGFwDWj2PHJW93s0bDrKus1RNXMgoYX9MvSfncHH/CvANp3Wm426 XSlzzQtd1TR1k+Tj6YH8l08uUsx19Of+PhcZlv7SXfWuZDa4YY2y0fqRgvefmznjheLWlDLX6ho2 /iXwU0NO+VwZx1OB4X11RdqG1UVuhqZmGdr4yGtOQek+6+eorS3VEtuuFBWGCSFwEg6gGlhPP6rn 8OuM1b/29tcwTW2yOkaC4yRdx5Xg1lQzV2paYNqnw08FM6VzW/43AnAXx1Hqy1UFzt9pZK174Htd y7/L4Xo1HZv7S1NvuNvrXROjIbI3qAaWdz+qY24yGU22NdE2eksb5GhzjLFyR2Wr1fST1upB6dU6 GKmpfV6W/wCNwJ4Xz1Bqy2UF1t9rZKx74HteTnyOML03+ynUNfb7lb68xBuGSsyOks7lS96ax6R7 8UTPU2mpnvHz+pGcnv2KpU7urd/FTqegGmIrDTytfM1zSSD7Korj8y6Z2cMYz4peWVTv8JlpgrNb SVU8bXPp2t6CR2J7qzGqKaqq9UzOjqpIYaSlbI1jQCHuyc5/QKtfwsXimtV+qzUPDXP6ekHyrNX+ w1F8vdvuVDXllI4dFQwYx0jkH6nK4x0ybW5QRzVVgdKwOeJOoEjJB6VoNVQVk+qJnx1L4qekpo5A wDIe4k5z7cBeu76pttPqK30Ala+Sn5JB9xhF8sNVeNQ2+40VeW0D29FRGO2AMj78rUn2y290p4pr lYnSMa57XOIJHP5FzepIq+bVVTNHVuipKOGJwjAz1kk5+y9111VbYdS0NGJA99PnJDh5GFjerBW3 TUlHcKKvAtsrQ2ojA4AaMjzzkqzpnKbsba6UcMt7sUskbXSNc8gkcj5Fz1+iuMuqKqojqjHR0bYc RdOesuPPPhe+5aptjNUUVEJQ6Snzkhw8jCwu9guFw1NSV9JXD+GTY9eNowAGjIPfnJ/ZMdT219Nr dKGmk1FZKiSJjpW+phxHI+Vc3c2XSTV1ZVMrOigozC0Q4yXl3fnx3WyuWp7Z/ayjpBMHPpw7qIPl wx/JfG4aeuVTq2C4UteDaZ/mnj6cAdIHT55yR+i1v9a55d5Y/Ta3OhpX6ss08kLHTsbKWvLeRwPK 0NwF0k1XXVjaoMoaOWGNsXTkvLgM8+AvfWaktbtYUkAmBlga4HBGPmXwr7BdKjWUFZTVoNon/vJm BuAC0Dp885P7JvU1W5e42dxt1JJrS11L4I3VDI5S15aM+PK0lS66O1XXVv4oMoqWoigbD05LuoDP OeBythU6jtj9YwQicGSBjmHkYy7H/ReersV2m1k2pjqmfwec+tIAOA5oGB35PCu/tmSfDb1Qgg1p RPEOZ5YXjqA5wCO/0Wlk0zVP16+5vvUQpi4EUfQc9vJz/ottTXShuGsA2GRpkpYnMJzwS4jt+y5A WvUh3ZnqXUcv8FL+psuR0/l/6rN7bnU07Cemp63W8ElRSn1aWncY3yNBzk92rTRS3N+qqisfUN/A tq/wzI8Eu4A8+Byt9W3Gkp9XU7ZZmh5gMeM9j1Z5Wojsl4brR0rpozZXONTkf5vb7/VS3ftGyfZ6 CTXzK11NEaplJw/pGfze61FK+6v1W6tknaaD8Y6lbHz1AAf0ytjT323zaymY2dpe2EQnnzkleSmt F5j1q98krDZA41QPu8nt91ityvcLJbnbgyXA0sX4ttG3+86Rnlx5Wqts92fq51VNKz8A+rfStZz1 ANGc/ZbSjvdBPrGqYydpcIWw9/IJP+q8VFaLvHraSSaRhs8RNTGeRl7s5H3ASRL7eunsVuG4dXcm 0kIrPwjMydAzy53P3WutNTdZNWmpqJGfgZqqWmYzHzYYMgn6La0F6oJ9YVjI52l3oti/UEk/1Wut VrvUOs5fxTozZ4S6pifyMueTx9wlxuul6eql0/bYtxK65R0kLao0keXhgByXO5+/C1+nqu7Tan/E 1kkf4Kpnlp4mAfN0szgn6d1t7fd6Gq1bWiGdpf6LIcfVrnE/1Wo0/b75DrKaKvawWml654pPDi8n gH3HldMJ+t2xnd5R67Vpy1024d2uUFHAyrdTRZe1gByS7J+5Xk0zW3io1Kaiu9MUNTJLDG0H5sMz jI9ltrTdKKq1Xcmwzsc8xsiAz3LSc/1Wo0zR3yLWE8FwjYy10XXLFIAcPL88A+48pZ+tJd2R97Dp q1Um4N8uNNRQR1XpRN62sAIJySf1Xw0rXXip1F61wEX4GsdKyIA84ZkchbaxXCjqdT3gQTtc6T02 gfVowVqNMUd7h1XJBcI2tttAHuikxw7rz2Pn6rXWqm+4+ml9LWi3a71DcaShgjqS2IdbWAEZaScf dfPSFyvFVfgbk2P8FWiX0sHkhhxghbjT1fSVWob2IJ2udI6MAZ79LcFaTSNLe4tSyw3OER2+3Ne2 KXw/rHg+VLruVre+1TfiTstJZ9yq5tvhZBDIGv6GDABI5UUeVMfxPVcNXuHUSQSNewsaMg+wwocH da88ky6+mf8AHtuHa4/wj6eoaPRVVfPQYa+WR7fVI+YNA7fZSboq4XOtrpGXWKMU9bE6ePpOct4G CPHGFxnwtTwS7Wx0jHj1y6T5c++Quv0Cy6uu1SLlTNgprfH+Fjfn854yR7jjuvNjv5d89b6fLQWj rLp68aluNtoIYZzVODXNby0dAJA+mSvRom43C51M8N3pWNp6yE1EfPUHtJxg+3HhbTTVTBV/xyKn lY98lS9zQD3BaB/ULT7fPu0tyqhdKUU1PbovwjD/AJiCCSPccd1tl5tAaPsumanUtfbKGKOf8XIA 4DlrQ0HpH0yT+69mi6+vvElXSX2jjZDVwfiWNzkOY445/wCi2NgmiraW/wAVLKx8s1TK5gB7gtAB /cLXbfyXaouFXLdqRtLDRRCiYc/mLTkn7fVX4c++Twbe6Qsuko9R19so42TtqZh1YyQ1oBDfsthp CsrL2ytt+oaOMR1MAqBG7Dg+N5I/07L32Z0dwtWoIaWRkkk885YAe4c0AH91rtvZ7jWXGuqrnSCl jpIm0LT/AJiw5J+3PdXd011tq9vNJWbRlt1FcrZSMZOJ5x1dyGM5DR9FtdMz1OoaOvtepaFgjqYB P6TyHB0byQP6L2WnpuGnr9BSPZLNPLUdLQe/UMBeHbyqr7hWV1dcqP8ACR08TaJue5LCST/NXL10 zbvL21W2WjrPoex3y422mH4j1pz1uOT0MJw0fThbawPk1LQXK0akoh6csYlMb8Oyx5OF7raRW6Ru 0FGWyzvdUBrWnuS44/deLb6srLjU19xrqT8LFHG2lHVxksJLsjxjKVrfTS7b6Ps+hNOXe622lzVP kl+dxyelriGtHsOFuLUP7XWe7WbUlv6W9ILo5Och+SCCvbTtNboa4QUWJpyZi1jTySZCR+4Xy0Nc ai6m5XSrpTSRFjIGh/B+Quzn9SlZy13UE7H6f05Y9e3mW5sElVRTmKia7kMGTk4913XxXwMn0Zbh jtU5H04KhGtqZG7uStpnu+e6Rj5PILwp0+KFpdpG3Z7evk/+ErrZMfPcZ6Sbvhxyo2a07a9F7Yx6 ip6UPuVVA2SWV3Ljk4AHsOV1X4Ki3A0rcrRqW3uEkJ6XNlbh7HYyHA+PuF4tPQOrNj7dDRt9aVtJ C7oaeT0ua4j9gVvNE1ctxprtdp6Z1LDVdJj6z+ZrWkZXm8eP/H37dc7fyWfDmdutJWjbvQst1oqf 1a6RnVJK/lzj1dIA9u4W0qbdQ7iaOr7dqGhImgcY3eoMPjeB1Ag+PHZe+vY6bbENp2GZ7Y43FjOT 8sgJ/kCstC1Dqy13W5yQOp6erk64i/jqYGBvV/Ja1IXuuX0Dpi0bb6C/ilFTerWzMa6SV3L3FxwA D7cjhe+42i3bmaIq6a80jhVUpdGXvbh8cjQDx7d177yyR+19MYY3TGNkL3MYMnDXtJ7fQL7beS/i LBc7h6LoYKuV00fXx1N6AOr9cLpxxmG/lx5ZZeSy+tOa0Hpq0bbbftutHTumrahjXySnl7nO4AB9 u3C9GobDbN0dCVBudM6Kvo+pjZXNxJG9oyR/PstreOtu2ttljhfOIPQlexgyS1rgXfyC++hqj8bp y9XAQvggq55ZoxIMZaWAZ/XCmpxl+VmV5WOc0Fpq0bbbfxXKlpnT19TGx0sxGXvc7ADR9M+EtXae te6mg5qitgfT3KhD2smczEjHtGS0g+Mnst/eJzR7e2ep9J8zKY08r2sBJ6WkE9llpGpFfprUFwbC +GKsnmnjDxjLTGMH6q+pvTNu7XP6G05atstAQ11LTOqK+rawySBuXvc7GGjHcZ8LDXWl7VuhoZ1d URPprnQNc1k3Th7HNGS0j2+i6PUlWy3aMsdbLG58NO+nkf0jOAB3T0xMKzSWoKxkT4oquaomjDxg lrmDBWbPXTe+725zRGmrXtdoQVsETqmtq2tfJP05cS4DDePAUCb9Xip1FcaGsq7fPT+nGYWyywGM PGc4BI5VotW6hfprRVDWMaDxEwgjPdq087LfuFtfNV3WljlaHPfHkYLHMOMj68Lcn6Tr2zvfks30 q1prZ3WGobQy5W63xilkJDPWlDHO+uDzhePWe1uqdH2tlxvVA1lI5/QXxSB/QfHVjsPqrrXKut1l 0xQvrmYpy1jR0u6cHpHn9Fyep9V2Ct0LdqVjXPppIXtLnu625P8AxH6rljjcrp0yymKjeMHC9FDA 6pqooWYDpHtYCfcnCdYxrZ3Bn5Q4gL16eGL1Rc/+3j/8wWc94y/x18U5ZSX0uLpbStj2o0oyd7G1 FfUhoknc3PWe44PbHK028e3dr1rp6LVVj6Ka4Na31HNb8szM45A8j3Uga3raa2t05WVzg2lilcXk jI5hcB/MhfGk9J21sr6XBhf1Ojxx8plyFrX64X7c8cv3yl9RoNN6V0/tZpOOSojjqK+oA9SaVoIc 7vwD249lzW9W2ds1RaY9U6eMdNVP6PVLW/LK0kDOB5HupJ3GmpqY2KWse2Ona6UOcRkDMTgOF8Ym xnadghOYugdPHj1BhdJhjMcanK22ac9p3SGndr9KxNroaesrZ8GSaeMODn+4B/KMLkt69rKC80cO qNLGKB1Q5nrsxhjw4gBwA9lJ+401LBW2d1wLBTlswJeMjJjICAxh2ngbFzGGR9H29QYUuMmq5YZ5 ZZZT6c7YtGaY200nBHdaakrayctMslTGHte/yQHdguJ3r2mo6xlPqTSTYoYqp7GzQNGGfMQA9o8f UKYNcS26K52l15bGaYxTACRuR1FuB/qvLUtaNrrY1nLQ2Dp+3WMKzGdLcr25mxaA0nt7pmBt7pKS urqgtMr6pge0u7HpyOB9FxO8m0FNNJT6g0e2KKkrXsbLTj5WNc44a5mOw9wpp1u+2NuVA29eiad0 EwaJmgt6sDHfz3Xj6MbaWUd2g04/TrCzx9NTL+uUsO2+kdD6ZomaioKSuuUrmmWSoaHjrPBDcjsP ZcNvHs9Gyrp71o9kbaOulYx9OOGMc84a5vsPopt1222SXGmivLYjA6ll6fV7B3HI+uEmNDtv7ADy PUphk/8AOFJG524iw7X6Q0jpmhh1RQUtdcpXB8sk3OHHAIafYLg929mTTXWluGkmsdb7hK1ghzhs T3HAx/wqcdewWqquTIb2WCE0bzGXuxh+eCPqs5BnR+m/OJqYZP3CshJu6cHYdp9IaY05RQarpaat uMzw58kri3pJwCBjuAo+3W2Vntt6pajSUfr2y4yBjI8gei93YZP+H6qedeUttrLm6G7va2MUD3RE u6cPDuCPqvtV86Z0yCcn1qcZ/ZZx/ZuYy3SPNN7PaT07p6lj1bFFW3GoeHPe9xZ0ZwOkYPIBUd7p 7M1tnv1MdLxOrLZcZAyBueYXnnpJPjA4KnvX9HQ19zfFcntYxlA6SFxf0lsgccEfXstlcCRadM5+ ZxkhyT/y91bNRjD9rpGmnNmNKWSx0rNVD8VcZ3AvkMhYGEgfKBnsCo23M2ar7JqCnj08x9Zb6+Tp pxnmNx56SfbHlWD3BoaWvrpmVkpi9G3mWFwf0kSB3B+q2dxy6j0wH8uM0ZJPn5FJ6dJhv2izTWyW lrbZqWLVTpJrnM4ZkbKYw3IzjH0UZ7gbQ3bT+o4aO0xvrqKtf00rh3B79Lj9ArAa+t8Nyu9WZppI n0tA2aAtf0/3nWR+vsuguTTKdLdfLvWacn39MreU1pyw/abqK9ObFabpbJSRaomnddZjzJDOWNGR kDpPsoo17tNedOalit9HE+up6yTpo5mD8/npd7EBWL1/QC43WuLp5YJaOjbPA5j8AO68ZPvxwt/d W+rPpR0nLvxAJP19IrPrLi1JvGZIl03sLYoLRSxanrKgXWYn5qebDeeRwRxwol1xtdfNNaljtccD 62KpfikniaSJR7H2IHf7KymuaE1t6r3/AImWGWhpGT0/ScDq6sHI88cfqt/eG9dy0q9/J/EHn/6E Vu4a0545cpv+oi09sBaWWmkZqO41MdzmJaRTyAsJ7jGQCOPBz91EWtdtr3prUjbU6CWq9d/TSSxt JEw9vuB3Cs1uBTy1N6qnxVUsElFDHNCGEYLicHI9sBb29s675pKV/LhM7n7xFSY3fa3KTGWfekPW P4fbe610X8bvFXTXKbLXRxdLmF2M8cZHHvnsowuG1l+o9eQaadG0zVDj6E5OGPYOSc++PCsZuIyq kv8APNS1kkL6GKKVjGjIcS7Bz7cL5b3VD6Gy2i6U56aunkBa/HIy3n+q6Y+G2yfbl+aWWz4unFT/ AA/2Snk9OTU9XBIQPlfC13f64Ci/dvbGt0NVxvbMau2z8RT4wc45BCmPT9l/tharZe6rVUtLVOIM sHpB7ctd2zkEZAH7rYfEgWO0vTQPicSHZbJx0nhY8WPPPjW/LnwxmUU9lBaTwvkvTU8TPB7ArzEY K5O8YkpLJJAgskBCISXlZeUvKBYSTPdCBYRhZHulhAklkAljlAsIKZCCECT9kuyfhAIQgIBBR90I BI900IBCMfVHY+6BHlP7pc5T8oBJNHZULHsmhHlAk+ySCDnKB55S8oIwmeeyBBBQe47oKAPb6JBP 2CSB5wkUwkQgPKMpeUHurA8e/lI/RCD27IBCAjCIMcpHkplJAIQglAIKEIEmhIoDyg8ICCqDKEsJ 4yVQvCE8du6RQCEyEsFBvytfcwegZ7ZWyOVrLqSenyvHh7ejL08UXYrxSH5yvZGOCvI/83Pddo5X 0Q5WB7lZrA/RVkYQhH7IGEEJLLugG916qd7gHEOII7fRecNBK7na7Rh1Zf4KaV5jpOoeq4dyPYIN DSsuFTC+aGGplhj/ADvZG5zW/cgYCyiFdVRSSwQ1EsUQ+d8cbnNb9yBgK12vrlbtvNNU9jssLKeS rYWNIA/L2cT7lbHayloZ9Hy2y3xiJskTw97QBkuGCfr3V2yqHSy1UrxHT+tI7GemNpcce+AvUypu Ds+mypcGnBIjccH27K3G3WgqLQNDcKyUte9oc4ydI6iwDPdbbbyvgvP4yeOGNkEsjpWgAeT54Taa Uvlrq4HDxPx7sP8A0Xllrp5OXPeR9cq81PdG/wARqW3KnYyibUOgjlc1oacHH3X2oLFbq+w1UDqS J9LUyytc1rAOppP29k2aURNxqAwRtlf0/wCUHhJlyngDgyUtJ474V19B7eWzStZXCnoYfTlcHNe+ MOOM/lyfZQtpCOz0e5N5q6mlglmbWyhglaHBo6j2bjCsvWxA0875yS9xJK8+P0VqN+dv7feNMP1R bmR0tTTx9UnSzAkYPGBx+qqyeFe9bMbN6YlYlZEpeVlogEwMISQMD+SYSamqPrE8xuBbxhdRSavu lNTiKKrkDQMDlc7b6Oetqo6emjMk0hAawdyVafbnaCx6Z07/ABnV8MFbVvYP7uVodHHnsMHz9VN6 FYqy41FXU+tNIXyZ7k5wt7S6wusNOIo6lzQBhT9uVtPa9SadjuOkaOloquAF3pxNEbJB56iPPHCz 2+2dsOnbB/FtXww11VI0ERSDLGZHAA9/qm0VjrLhUVdV680jnS5z1E5W/pdbXempxEyocGgYwVOW 520FrvNkZdtGUsNJURNyYIwGxvHn7FejQWzNhsGnhc9ZwxVtXM3IikOWMz2A+qu0sVmrblVVdb+J lkc6XOQ7PK6Ol11d4qURMqHAAY48qZ90tmrfX2qK7aLpoqZ7R81Ow4Y4efsV79DbL2Cx6cbX6ygj rKqcZEb3ENj+gx5U2SK2zXqrkr/xUkjzNnPVnldDTa+vEcYaJyWjgZ7qWt1dl6Oe3w3bRNOyJoGH 0zXfKR7gk91tNEbJWKy6ebXayibV1tQMtiLiGxj2GD3WtpYg5+uru6qbM+Zzi3sPC9zNyL28f77O O30Uj7s7LQspae7aJp8QOAZJTNdwPrklb3ROyNhs2nm1es2CrragDEXWWtj+gx3PKm10hGv1/eak gTVDsD2XobuNevSa1s/bspB3a2VZSxQ3bRcJdSSYZJSg56T26gSc8kro9E7GWG1afZV61DqmvqMY ibIWNj+gx3TdTpBl21xdrhH6VROejvgL2Wrca70NIIIpC4AYGe67zd3Zb+HCC6aNgfLRS4Y+mByW HgBwJPkldVorYqx2ywsqta9c9dPjETJCxsf047ps1Fbb7eqy61bp6yRz5Hd8nstxpHWVw080spHf IecexUk7tbKTWuop67SED6mgnIYYAcmN3g5J5Bz/ACXX6N2EsdvsLKjWjpZ6+cjEcUpY2P6cd0lX rSFb9uDdru0MqJSGA5wF7LdudeaOjEDJepoGBnuuo3Z2ZqrLcYKjStPJUW2oIYIw4uMbicDk+67b R+wFjobHHNrKWaWvmIIZFIWCPPj6q3cZlmXpAcusLlJdxXyTOM+c5zwuop93LzG1rQQ7pHuVtt2t ma7T90hl01TzVdtqSGMa3LnRuPABP1XeaQ+Hyy0dlil1jPO+4T4PpxS9DY8+Pr90lrXSGK/ci7Vd wjqJpSHMPyjPAW3/AO128mMNDgMecr2brbN3HTd7i/s9BNWWypcGxY+ZzHE4AcfqpD0j8PVmpbLT yavqah1xnwTHBL0Njz/h7fzTkmOr6RFXbo3eqljJkAEZ6uPK2kG8l4ZGAWs+XjPUUt0dnLrpq/tj ssMtdbap4bTuaOpzSezXf9VJGlPh4s8FmppNW1lT/EZ8ExwyBrWZ7Dt/NTa3SEr9uBdbxWMmqJy3 oPygHgLoaHeG7UtA2BpDsDAcXL3aw2KvFv1pDbrR/e2uqfmKpeeIm57PPupJ/wCwPRNDHTwXC517 qssHWY5G4J84GOE3UkiulZq64Vd2dXzTuMxdnOV21JvLd6ahEDSCQMA5OV7N8dn4NEUlNdbJUyy2 yXDHtncC9rj2Ix4Wy2m2KZqSwOvOpqqejpX/AO4jhwHY8udn38BLbNb+VkmrZ8IrrdX3KpuxuE07 zOXdWcruKbei7U9vELQC4DAdldLrj4e6ilu9tZparM9BVkMc6ocOph7k8dwuml+HjSdH6NPcL1cW 1pjaXhhbgk+wwm6ais2pb7WXyukqqyUvkcc8ngLR+VMe+e0X9gWUtfbql9RaZyIw6YjrD8Z8eFDh Cz7ajaWO6z2usZPTyFj2nOQVLtPvhdILcIenLgMAhyhyz22ru9xgobfBJPVTO6WRsGSSrM6e+Gmk fZaZ2oLxUwXSVpJhga0tb9OVZ0l0g2fW1zmvP8RdUO9Yu6u/8lIcG+VxhtogaHdYGAerhcVrDbC/ 2DVjbMyjlqTM/FNI1uRID2zjgH3Ux2D4ZoH2emkvt6nguUzSTBC1vSD7ZKu0mrNxCEuuLpJeTXun d6pd1d+PspEi30uUVvELWu6+nGQ7hcDqjbe/2PVosRo5Z55X9NO5jciQe/0+qmey/DNG+0077zfJ oLlI0kwRRtLQcduoq22e069oTGuLm6+G4OnPqF3UeePspIbvvXstvoMDhIG4B6uFHOodvb/Z9Viw uopZauR+IOluRICeDnt91NNp+GMSWuF90vslPcZIy407Imlodjt1Z/0TdhqWbiFm65uf8bNwdO71 i7Pf+Sksb8V0ds9BgeJenH5uFFt50Bf7ZqsWCSgkkuD39ETWjIfz3z7Ka7d8MMktshdcL+6C4vj6 jAyEOaHY7dWU5UkiHGa6uYvv8R9Vxk6s9+Meyk3/ALea2O1mKJsjZenAOeAonuGhL/QaqOn5LfK6 5GToaxo4f7HPspsofhhqJLfG6r1AIbg6LrNO2nDgHY/L1ZHn6JurqIhp9eXKK+fxB0zi8uyee/0U nP38q22sxRh4l6ekfMofrdE32k1S7T8lBKbmJPTEYbkHng59vqprg+GGtdbGPnv7I68w9ZpxT5HV j8ucjzxlOVOMcDpfdO4Wq8y1kznPEh6iM9ipBj+ICblzhL1Y4PUoNk0be4tVHT7qGT+KiT0/SA7/ AFz7fVTZF8MVx/hokkvsLa4w+oaYU+SHY/LnI8+U5HFwlbutc6rUv8RL3EB2eknuF3dVv9Um1Pij MglLekAngcKEho69u1ObC2hlN0bJ6ZiA85759vqppf8ADLdRbPVN7p/xoh9R1MIDkOx+XOffjKcj URratxblSX78e6Vzi52XAnwpRrt/6h1qdDAJPVc3p5PCgun0neZtSmxw0MjrmJDGYQOxBxk/T6qa Kn4Zr1HaTUR3mmlrBCJHUnokHqx+UHP81ORpHtn3IuVFfzXulc4udl7c9wpRufxASvtL4oPUErmd Iyeygii0peK3UZsVPRSPugkMbocctI7k+wUw3D4ab/BZH1VPc6SorGRCQ0gjLXE47Aps1HD2Lcq4 0F9Nc+Rzw52XjPdSfc/iBkltMkUHqeq5uBnsoGtWlrvctRCyUtFK65+oY3QluCwjv1ewCl+7fDZq Kksk1ZTXCkqqqOMSGkDSHE+wP/VNrJHG6f3MuNvv5rpJHOa9+XDPdSfeviCfPaJYYPUErmdIzwoB s2mbreNQsstFSSOuLpDGYi0gsI7l3sApavfw4amoLJUVkNbRVc8LOs00YcHkewyryTUctpjc24Wy /mtllc5sj8vGVKd9+IH8RZpIqcv9V7enlV4sWnLner/FZ7dSySXB8np+njlhB5LvYBSvfvh11Zar LU1zaihrHwN6jBAXF5H0yAnL7XjPhoNJ7oV9rv5rJZHvZI/LxlSlqL4gfxFmlhpS71XtxzxhV10/ py536+w2q20sktbI/p6MH5fcn2AUoan+HvV1ks1TXtko61sDep0VM5xeR5wCB2TknFqtH7pV9ovz quZ7nRyOy8ZUnam+IAVNjlhpXO9Z7ccjCrppzT1z1De4LVa6aSesmd0hgB+X3J9gFJWq/h/1hYrL U3BwoqyOnHU+Ole5z8eTgtHZTa6iK77dJ7tcJaqpeXyPOSSVrkEEHB7pKNJO2h3HqtH1zY3vJpCc 4z2KmPVe/wBHPZJIqJx9d4xwMYVZtL2G5akvEFts1K+pq5XYDWjgD3J8Ae6kTV2x+sdN2eS41VPT 1EEX5200he4D3xjwkqVsdv8Adursl8dNVPcYZHZPPZSPq/fyKosksVC4ieQY4GFWrS+nbpqS8Q22 z0z6iqldgAdmj3cfAXba02Z1fpW0m4XClimpmHDvwzzIW/UgDstSppvNuN26qx3l0lZI50Ejuo89 lI+st+oZ7HJHQv8A794x8owqz6V0/c9SXeK3WemdUVUh4aOzR7uPgLr9bbS6t0haRcbxRR/herpc 6CT1On6nHYJtNOp2z3eqLHd3urZHGCRxceeykLWe+1PNY3xW94Er/wDIMFVp0tp66aku0Vus9M6o qZDwBwGj3J8BdNrbavVmj7Y24XmgDaQu6TJFIJOk/XHZJktnw7bbDd+ayXV4rpHGCRxcecrvNb75 U0lkkjtr2iV4PDBjv7qtGlNO3XU14it1npnVNVJyAOAB7k9gF0Wtds9VaQtkVffaAxUr39HW14eG n647Jy+U4pA2s3hms1ykZcJD6DySSTwu11zvfSvs0kNre0SSZyIxjOfdVo0rp666mu8dtslK+pq5 MkNbwAAM5J7Bb7We3mqNJW+Krv1ufT00ruhrw8OwfrjsnL5OPwk3aneOS0VskVykzC8k8nhdduFv ZSSWN0Nqe0SSZyGcZyq0aW0/ddS3ZlusdI+qq3AuDG8cAZOSeAttq/QupdKUsFRqC2y0kMzi1jnE EZ9uOysz72lw3NJL2T3CtlhqbrNdooXVdVMHiSRmSABwAfHKl657yWCrpiJm0swAJAkaHDOFULS9 huupLsy3WWlfVVjwXCNvHAGSeVstVaP1LpWOF9/tlRRRyktY5+CCR4yFOW7urrrUTVtju7TWavqa Cdwbb+pxiafyhvgLf7ibz0X8CFLZnRt6mlpEfAwqyabsd01DdG0NlpJaqrILgxnfA7r3aq0rf9Ne iy/W2pohNn0zIOHY74I4ymzVThtHvI2gZJRXeQFnJaXngrf7i7yUTLGKOzOjaHN6emPgAKsWn7Ld b9X/AIOy0c1ZVAF3pxDJwPK9ep9N3zTkkMd+t9RROmaTH6rfzY9lORpPe0e8cdLDJRXd4LOS3qPB W63J3hoYrG2jsro2Nczp6Y+AB/oqxafsl2vlYaezUNRWTtb1FkLC4gL7aksV5sE0cF8oKijlkb1M bM0jI7cK8vkuO1hdo94oIqSW33ktLMHpDzw4ey2W5e7tFFZG0Fj6I2OZ09MeMNHsMKsdgs91vVS+ Gz0NRWzMb1OZCwuIHvhZX+03Wyzsp7xQ1NFO9vW1k8ZYS3PcApMonFY7abd2k/h01tvZa5mCMPPD gRjC9u5W61BT2OO32QtjiLOgMYeAPH6Kr9lttzulQ6K1UdTVytHUWwRl5A/RZXmhuVsqBTXakqaS oLeoR1EZY4t98HwrMtJcFmtqt2aCos8tsvxa9oYW9Mh4cDx/RencjdSgp7NHbrM5rIugN6WnIAHh VbtVFcK2VzLdS1FQ9gy4QsLyAffC+l2pbhQTCC5U9RTTFoeI52OY4tPnB8Kcp7XittZtw9M6n0hT 0t/iinDQ0Oic7p5bjBTvOvdO2LR8tDY444IXdQEQd1AB3dVGtkVfUF4o4Z5ugAu9Jhd0g+Tjsvpc WV1JIIq2OeF5aHBkrS0kHzg+FZlInFby3a80vqfSlPT3xkczWYBjc/pAx2Ws1lrDTNq0DVWyyxQs p5WuaYi7r/N37/VVUovxs3qCjZPKGjqd6bS7pHucdl8queoa0xT9YcOel4IP7FJlJdxbhy9vFVEG Y498p0cxhqWSNOHMcHD9DlfBxJJQOD9Vm3ddJ16XH0FuPY9YaT/Aaka1z2Boe1x5yDkEfsvjuxuh R01vbQWqQdBABA+h7Kp1vnnjJ9Fz8+egE/0WdVVyyk+o8kjvnuFrHUYs2uBpLXth1rpb8FqJrHuZ 09QOOrIOQR+y8G625VHRUbbZanNEQA4bxnB7KqNFWTU7iYZXMJHPSSE6qtmqHZkkLj2JJyVZZLtM pauDprWuntd6YbTagax8kfTnP5g4HOQfHZa/dPceht9Ey2WtzBC3HDOAQDnGFVCiuM9K53ozuZnv h2Mp1dfPUnMkhcfcnKbi6XDs2q9O6+0pFDenMMsbm5PHUHA5yFqd09w6K30kVstfpiGMtwGgAYB9 vCqnQ3Wooi70ZzHnvzhFbc6irIdJIXn3Jykyk7ZuO1xbdqDTm4OmaX+LyNFTC5p6uOoOHf8AQ9it XuhuFb7XRw2y2emIYnNcAzAHynIwPCqlbrxV0WRDUOi6uSA7GUrhcqird1zPc8nzlOUOHzFyKG96 d3B09RzXCYR1MD2u6h3BBBII8g+QtRuVuBQ2imprdbSz0oHtcA3t8pyMKqtrvVbQBwpah7GnuAcL 53C61NZL1zSFx8klSWQuNXKp7np3cCxUFVW1DY54HtJcDye3U0/Q9lptx9e2+yxUdvtpjMVLIxzR nP5Twqq2u/V1va5tLO+NrjkgOwF8rld6mtk9SaQud90lk7XVna534yw69tFvrqipbHJE9vV82Oof 4mn6FaXcbXdusooaCh6XRUkjHDnP5e2PsqrWfUtxtzHMpqh7GHktB4Xwut6q66Yvnkc957klJqdr urlTPsevrfbLlJVNiNO8eo0v6RI3GS0/TlancHXtBZZLfSUXS9tI9pHzZ7cf0VWbPqq522Ew0tTI yMnPTnheS7X6qrZeueQucfJTpO1zKyKza7pLbcxWiL0iBI3r6RIzGS36clarXuu7dZ6i3U9P0vFJ I0/mzwBjv9lVeyawultgMNPUPZFnOM8BeO76gqq+YyTPLnk90ki8quTX261a3jtt3hrvRa3DZmiT AkZjPT+5B/Ra3W+ubbZ7ha4Y3NkbSSA5z9Mf0VW7Dra62ulMFPO8RE5xnstddtQVVfO6SV5Lz3yU SWxcq7Wa262dbrrTV7oofy1DWvx6jMZ6f0OCtdrXWdutNxtELZBIKOYOJ/7vT/qqvaf13dbXSfh4 ah4iByBnstZd9R1VfOZZJC5x5OSn/bW+tLhXuwUmr6y3XeiuD46Vw6KljX462DJA/fC8OsdZW22X mzROf1Mo5g5xz/wlv+qrPYNw7ta6NtNDUH02nI84WmvOpqi41RknkLi5a5fbnw11it/qLTo1Xcbf dLbXFtHKAyrDXAEsGSMfrheHV+q7bbb9Y2SSEto5cuJIHdvSq36f3IutqoRTRzEsZ+XPOFpL5qeo uNUZZJXPce5JSZfNW47ki3GpNMy6lvFFc7XX9NFOBHVBpGehuSCP1wMfVarciW16iq7XpyWrMDXv 6XytwS3DfYqv2ndzrpbKFlKJS5rPy55IWkumsKqpuIqzM4Std1NIPIK1j5LO/pj8UnU/7TJPtLqi y3tkdgnFbazIyQSPkbG4DILgR2P6LqfiIMZ0vTxFw9Zh5bnkcKIKTd+7iFvqVBLwMZJJK53WmvKq /wAf+0Pc53bk5Cx4suGXJry+P8mMxR/W49Z4HfPK8pOSvrK7rJPklfErm7xihMJlAgkmOAhEASTQ gSSZ7oQIoTQgSEIQCEIQCChHlAvKDwn9UvKAT7pYTygSAmfCSA8oP0QEz2QIpJhNAvCPsmkVQZQh B7/VAI8pHvygd0B+qFkljlBjhPCCgd0AhB7oIQCEvKaBI7oQeVQIz5Ql902gHdA7owhNgd4STPKS BhJGMJj6oaJATKSAQEIQCPCEKhIRyhUBSTJR/JAH6oyUHsj9UG/7nutZdBgBbI91rLryWrxYPRl6 eSIEMK8buXHK9kZ/uz9l4nd12jlfQdx2WCzPblYLTJdk0ykgY7pjukn+6DNgyR4wp9+HBgNzBAxl wUAs791Ie3Op32adoa4tbnJ8fqqJT+KNtQL1Z6hkbzTMicwyAfKHE8AldT8PtLW1dGypmkLIGDIa R3Wvve4FgvOmZrfdII6x8jMNa88Nd4d75BXste41m0/ow0VK0fiPRLWdLgMOwtZXlrXwxjjxSHuZ QTXrSNzgoawwdDXPc5jSS7pBPR3HfstLsaP/AEFh7SHBmCCOR9Cue0HuFbqWh67jKZJXjt1cfVb7 T+ttP0MdQ9jSJZ5XSO+fnk9lnStVrzUkuoLlFpy0Uss1fBcHeoWjhrWkj9F3oqXW3QUsj/kfCx/U c9iOCtBbtX6UtdTUVNHStiqKl5kleHZL3E5JJWh1puBZ/wCxFyt8L+qoqGva0Z7FxWpO5v0xlvXS TNN3iK8WyKaNvzNa3J8FVFo5nf8AahW4J6XV8vH/AHipt0Fri0WPTTBWylz+gcAjnHhRvtnBY5tX 199vDy6N1RJJDAD+XLiQSmP+tlSy85fhMu5IA2VuIA5FMT/MKkD/AM3A4Vg9+N0GXendZLMQyhDc SFv+L6KvrnZPHsm/1mLWOP7XL7Yk+PZJNIrLYHZGEIwgbU8fVYjhZDuCqO/2ahEmr6YkA4B/0Vw9 YCnbp63CtwKT14fU6uxGVS/bi7x2e/w1EuA38ufZW4tGpLXqCyCluz4jC5mAXAEjjAI+qsurtjPH lHT2tsB05cXUrQIMy+mAOA3C8WrY6Y6atIry0U3qwl4ceDweCuR1huJaLDR09mtL29BAa52fHZbm hvlq1JYBR3WVgi6QWu7kccELGlldDSthGlLgaVrRCXS+mAOA3xhePWUNK+y2SO4ODaYzR9eTgH5e 37rldY7hWmxU1NZbW9pYW9LnZ8LcU92tmqLCyluUzGtaA5jzyQfBAC1rRe28jaz+x9S6AARh0haP GM+F59ZQ0ktDYY7k/opvVBdk4B+QcLltX6/tNip6WyW2RrmFoa9x9lum19q1VYY6e5zBjo/mjkB5 H2/ZTSzpuGtjbo2o9HHpAydH26hj+S8+sqekmjsMVe7ppvUJcC7AJ6RgFcxq7XtpskVHZKCVrmkA PcT3C3b6m16rskUVwnET4XB7JQeR27fsrpK2koa3Rf8AdgFvUQ37dXC+GtqamqJbFFWv6Kb1HFw6 ukOIaMBc7q7XlptH4SyUcrXsyOpxOVt6t9s1baKdtZU+hLA8SRyA4x2zgfYJpNtpI1o0jGGAFpkA H26xhfDW1JTVFXZIq1/TA18rsF3SHENGFz2q9dWi1yUtloZGOAI6nE57HIW3rf4Zq220zqqoEMtO 8Pa/qxwSM4H2CaS9tjKxv9k6drRx6jAM8/4wvhrijpqq4WiOreWQsMzsdXT1ENGFodV65tNtqKSz 0kjHBrmkknPY5C2tyhturaOmmqKn0J4Hh7Xh+Bg46uPqApYjZ1EY/svRgD/HHg/d4Xi1pRQVt7ts VVK6OBjJX9If09RGMLT6p1xa7fW0lmpZGHpc05Jz+U5C2l1o7dqynpal9UYKiBwcH9WMNyOoY+oW 8P1uzLuTXw2FTGw6et5Iy4vhPb/iXj1jRR1l/omVEro4I4ZJOhrunqcMYytRqnW1poLhR2imkY8x OaS4nP5TxyttdqGh1WyirPxjqaaBwOQ7ALc5cFKYale6rwbJay4Zc50Pf7rXaxoY6zU9GKid8cMV M+RrGux1uB4yvBqbWlro7nRWmnex3pOack/5ey2F7ttJql9vrmVZglgcA49YALD3GFfH+pnN176w B1vs5ezLi6H914NX0TazU9P68744YqVz2sa7HU4E4yvFqPWdrorvQ2qF7HmBzXZJ/wAq2F7tVNqS eguUNa6J8RDXt6gAWdysZTemsP122FW3roLG9wy71IsnHutVq+j/ABeqWGWpfHFBS+o2Npx1OBPf 6Lz3/WdspLzQ2qCRjzTuDuT5avZfLNDqKtt91p64xFmGSs6gAWdz+qepo/6c9vXdprNoGhrqfiYS RjOfcFaPazTt1uTBqnWc74KQDNPTP4Lh/md9PYLtb3V2u/XygsRbHUU1JI2WTr5GW9gvhuhY79qC KOhsVfR0lJ0hry+TBHvgD6Ldy3McfpjHGzdnyiDeXWEGs79SacoHtFGyZvU7PAwp4pqSkotAejFO Y6YQYMoH5eBkqA9xdqaHSNPZa2011VU3WepbFI17wWnI5IHcKdq22VE+289sZLE2slpixpLxgEhW SZeTG30xnePhyk9uJ2/1k69aldbKcmojo5SI3O4yO2Suw1JZbXW6ogra25VMFYyJrRBHjoI55II/ 1UKfDmG2zWF5hr3sE0EnouIOQXDIOCpY1Lpq83HcClulJPTC2tia0sfLhxPOeP1V8snPL6axt44u H+Lt0v8AYq2w+kPw4mBbITyXdPbCpwe6uH8XtwpjpC20LZWmpZUB5aD2HThU9/xLnbuSOuE1tYv4 QLTBLqGrr5Yw6aMdDHEctGOVPV4grJNVVdV+LkZT0zIvTib2c45zn6KCPhSvdLa6qrZO4B73cDPj CsLW6dmr9SU91huGKCQf38fYANHy455yUwuplv5Z805ZY6+G6uFJC+/WaSSNpkYZC0kdvlC5m6w1 z9WVlWatzKSlMTWQgfmJ7knwvbXatth1TSUrJWudB1ZIPkjCxrNN1lZquG6wXDNslGZouwHSPlxz zkrWGpLv6J7n03FfSQu1RaZnxtMjRKGuI5HyhczcIri7V1fWGrLKOlkijZCBnqLsZ58LY1mqrY/V lPA2UOdThwJB7lwwsa3TldV6uiucFcDapfnljxgAtAxjnnla31ZfpyuO7G4rqOnOrbXM6NpmDJcO xyOAuero7g/VVdX/AIrooqWaKNsAbkv6sAnPhe2o1Ta5NXU8LZQ58DXNyD74WNbp6vqdWx18NaDa pf7yVnTwC3t55ysy6mnWdem1rKGmOsqCofEwzCGTpcRyOy5+pjuL9UVlw/FhlHT1DIWQBuS7OMnP gcr3yantc2roo2ygvgY6MkEY5xyvlNp+5S6v/GsrWfwiXMr2dPAcMY890qabapttK7WlJVOhYZxT vIcQM9wtAf4i7U9XWuq+mkiqhC2HpySDwTnwFshqe3TatbE2UZhjdHwfcg5/kvN/Abq/WT6r8U02 Z/8AfEY7Oz2/99S/1vqem1qLdSP1xBUvgjM7aU4eWjP5vdaGnNyfqeorpaoCjbWGmjhDckjjknwO VsYtSW6fWDmNlBdHGYeCMd85XnprHdWa0mqJKkGyn/aAP+I+Pv8AVZRtDa6J2u/xZp4/xLaQfP0j P5j5Wmof4o/VD6yapBonVr6VsWOQB5z7L30uoLdNrCoa2UFzYhDnPGQScrz0tmusWtZZ5p2mzN/2 hnt1k8j/AN9RqNg21UX9vJ60U8f4gUjQX9IyfmK1FsddH6pdVzTA0UlXJTNjweoBvY59u62FFf7f UauqWxzAn0mw9/IcTn+a8tDZ7tDrSaeeZpsseaiM9vndnI/T3VkS3t7qezULdfVle2miFR+DjBeG AH8zlqbNPcpNTiqqKgGjnqpadkWOQGjIJPt9FtKC+2+q1ZWNinaT6TYu/lrif9V4bTZrvT6wnfVy sNnhzPC7t8zicj9FMsbcer2ss29tJY7fDr24XCGlhZVOpIwXhgB/M7nK1mnJrpLqBtTWTtNLUzSx MiA5DW5xk/uttbr1QVeqawQztLjE2L9Wkk/1Ws0/bL1TauqPx72G003VLC/GAS7PA+o8rpjP1v2x ld5R67TYrdTa7u1fT0kLKp1PEC9rAD3PK8Olqi7y6gFTcJI/wtVJLExgznDM4z9FtLPdqGq1TcfQ naXFjYwPq0nP9Vq9MUN8p9W1TLn0NtdIHSQvAIDi/PY/TymU/W/aYWSzb1WPT9so9d3y4U9HAyqd FEDI1gB5BJXk0nVXme/CouLovwdY6VkbRnqw3OMra2K50VVqS7CCdpdIGMAz5aMFavS1Fe6bVFTF dOgWyiDjBJjAd1+x/qtT1d+zfcejS2m7VQa0v9fS0VPFUuEYL2xgEZbk8/XK+elK27z3pr7gYzR1 nq+mG98NOMH9FstO3Kiq79eBBO1xlLA0Z/ytwVqtKUd7p9SVEd0YxltoQRBIOA7q9ljL23jdR99K aYtFq1dqGvoqGCGpcWAvawAjLcn98r56PrbrPd83IRmmrWPkj6Tk4Bxgj7LaafuVHWXe9Cnna98r 29Iz/laB/VafRtPeor7Utu0bGUVvaYoZOwdnnj3Sm2ei9K2iy6i1JcKChghndNgOa0AgdAJA/VPR Vbdamv8A/SjYTTVsTpYywnkA4w4HzjC2una+lrKy9Mp5mufLMS0Z8dIH9VptDQ3iO7VIu0TIqO3s METu3VnBJHuOFKbU6+IKz0ln3Ou8NBAyCndIHtjYMNGWgnA+6jYBSv8AEjVQ1m5Nwmp3h8bunBH2 woob+YLXl1vpPDbcZtdT4WdP0Nr23deWU8f8QnL3OmI+bpHYZ9uF3uh664XKWop7zCwRVUH4lozn qa44wf0XOfDtLFUbR0tHBI01Bjk+XPvkBdHt826mrq5bxTsp4qJn4Rngu6eSfqPquWH+vftryd59 enm0FpSz6WZqOvtdFFFOamY9QbzgAHp+30Xr0XWV14/F0d+pmNjqYBUBhIcHNeSP07dlsLFJFcLZ fYaSRkkk00zmgHw4YC1+38l0mrbhU3ilFLHSMFFH/wAQYck/bnuus1pLd1rdBaUs+j7dqSvtdJGy cVE5L8c9LRkN+y2GkKitvVLW2/UdHGGVEIn9N2HB7Hkj9O3Ze21vZcbHfoKN7JZZ5Zyxue4cMBeP b2e51VRX1l4pRStpmNo2fXo5J+3PdL6c7u5tbt1pS06Lsd/uFrpGNqDNOerGT0syWt+y2empKq/U lwtepKKMRTwNm9JxDw5khP7duy9tqLa/S94go3NlmlfUdLQe/USAvHt/VV9bLX3C6UopGQsbSNye SIySSf3S/wAdOr7afbnSNp0Npq9XG1UrRUukmJeeSWtcQ1v2C29h9TUltudo1JQt9N0bXOjeQ4Pa /JC9lEPxujbjTUTmyzkzdLWnOcvJH7r4aErKyvdX3O4034Rga2AB3B+QnJI/VL7RotudIWfQelrp c7VSgVT3SEvcckta4hrVubWz+1llutn1JQAMDQHxvwSeoE5BXqijNboWtgosTTkyENaeTmQkfyWO ha6or47lda+D8KyTpYA7jAZkHPss326Ob280laNAaMrbnbKUOrXh/VI7lzgHkNH0W6o6aHWunLpZ 9S2/Ajw18co+YEjIIP8AQr0yROrdATwUWJphl3Q08/7zqx+yy0RWz3Clud3q4DSx1JHSHccNBGUv tK5nb7SNo290RUXO20wfWPaS6V/LnfNgDPjutzDQ02udMXK06loD1Qnoe2RuHscRkEH9uV66ljqv bh0VGz15msa7ob3PS8OI/YJ6HrZrhRXS8VdOaSOrcHMDjgFrW4z/ACUVy+hNNWnbnQD7pb6X1ayR oc+Vwy9xLukAH9QtrNbqLcPRlfbtRUR9WncY3eoMPY8DIIPjx2XquTHT7ZRtpozUSRticY2ck9Mg cf5Ar7aEqH1tmud0qKc0sVY/1Yw892hgbn+S6cZw38uPLLnZ8Ob0Lpu07c7ei5W+l9WsmY1z5Hcv e5xwMH9V7rnZ6DcfQ9bTXyjcKilc6LqeMSRvaAc58dwtjdg47bUboYnVHothkexgyS1rgXfyCz0H UGp07crlJCYIauV80fXxlvQB1frhZ4yTbdyttc1ovT9q2227juVvpTLWVDGOkkdy97nYAAPt9F9t Q2O3bnaBqv4pTGOtpOtjZHNxJG9rQT/MrbXsvZtvbZY4X1Ap/QlfHGOo9LXAnt9F9ND1H4vSd4uL oXQRVk0s7A/jLSwDP2OF01OMvy48sr5LPhodFafte2u3kNdQUrp62qYx0kmMve92AAPp7BGr9O2z c/QdRUV1O6C40Ie1kxbiRj2jJBz4z4W8vMn4XQNnqPTfMymME0gYMnpbyVnpao/HaRvleInwxVk0 88YfxlpYMH9cLNknpvld1odFadtW2egYKukpjPX1bWGSUNy973AYaMc4z2C+euNL2rdDQz62rhdB cqFrhHP0Ye1zRktIPjPhdHqaqbb9I2StdG6SGlfBK8NGcADujTM/4zRt7rGxPhZVyVE0bXjBw5uQ nGalal7aDRmm7XtfoWOopYXT1tZ0mSXpy9znAEDjuB7Ly7iaStW5eh/4qWGnuNI1wjnDcO+Xu0j2 +i6/U9fHatPWSvnY59PTvjdIW+B0EZ/cr52ORtRoK51DY3RxTmeVjXjB6XchYn+2m/lz2j9O2naz RTJaeN89ZWlvXN05e9xAIHHgLXbpaMtW42ihfadn4e5U7D6cwbguDTgtI9u67XVVfDaLRYbhVNca ane10mPAMZGT+pXxtT45tta2WFnRFJ672N9gXkj+q1JOi620GlNNWfanSDJYWumravpEk5blzyRn GPYLRby6HtWu9Du1TbWsp7lTRGQSNHEzWnBaf+qkXV9dT2ilsNwrf/VaeX+8OMgZiIH8yFrI3xy7 RV8kTemGWKd7W4xgF7iFnHVymLOV445ZKHzRmN5BBznC+tvpnVddBTsIDpZGxgnwXOwvrdR/tj8d g4r06UGdQ20Z71UP/nCeScbdOni/aza4mntNWDarS0XVFHNXVAAfO9uet3fOPHHsue3o23tmrrNF qmxGOnrHBnqODctlaSBkgeRnupD19UU1FNYqiscGQMMoLiMgZhcB/VYs9N21Y9D/AHRa3p+3qjC1 qTj/AFxwtuWUs6lc/YdLWDazScLamKGqrpyOuaZgIe/3APbhcnvRtbb9Q0MGp9NGKmmqCz1RjDHh xA6sDyFJu481LTT2ia4Foga2YZcMjqMZAXzkaz/snpBHywRxdGfb1BhbmGOpS5Xd6aGx6S07thpS ngroaesq53AySzxhwe/yQD+UYXGb07UUV0jg1Ppb04BVOYJ4gMMPUQA8Adu6lncCaggrrXJdgz8M IpvzjI6izA/1XmmYP+yy2NYctDYMH6dYwszGdJMrbWgsWiNL7caZp4LjTU9bVVDg6V9TGHh78YJG ewx4XCb1bSUtWabUekWxRQVsjGzU4GGAvOA9oHYe4Uza5mtkNytzr2IjS+hMAJW9Q6sDHHuvI5oO 21iDeWdVNg/TrCkx9N2uZse32ktAaapIb1R0ldXzua6WSqYHgvOAenI4H0XDbx7PQy1VNfNHtijp K+RjJKcfKxjnHAc3HYe4U0a7NsFypW3oQGnNNJ0+sAQHccj64yvnE0f2B06M9TfUphn6dScfRvvT jrFtvo/ROmqGLUVvpK65Sua6WSoAd85wCGk+B7Lhd3dmmtuVNdNJNjFDcJGtMH5WxvccAt9h9FNe 4UdrmuDY7yIzEaKT0/UOMPz3H1X2kZnRunAef72lH6dQWZNrO7pwVh2v0fpLTdBBqmhpK64zPD5J Ju7XHAIafIC4LdnZiSjvFJW6RY2W3XGQMbDnAhe7tg/5VOWvqa21VwMV4LBF+BcYi846X9XcH3Xq qiRpzTIHP97TjKsmzHu6R/p7abSGmdO0dPqqmgrrhO8PdJI4tLSQAWgg8gEFRzunsrV2u/UkmlWf ibZcpAyFhODA884JP+HHlT7r6kt1bcJIrs5rWNt7nwuLuktkDuCPqvbcCRZ9MA85lhyT9gpj21JL dI403s9pGw2Skh1RDHW3KoIL5HOLOjIHAweQCo43P2YrbPf6YabYau3XCTpgbnmJ556ST4x2Knjc CipK26StrnhjYqAyRPL+ktk6jgj3PZbi5c0ml+rkmWMk/XoWssdSVnD9vaM9N7MaSs1mo4dUt/FX OocOp/qFgaSAcYz2Huow3I2buVi1JTwWFhrqCvf00xyAWOPPSSe4x5VhdwLfS3C4ztqpDE+Cg9aB 4f09MnXwfr7LbXNnqxaW6uXCdhyff0ysY37dJjNbqLtN7I6WoLRSQaoe+e6zHmRkxYBkZx09uOyi vXu0V3sGp4aC2RvrqStfijkb589Lj7gKwuuLbHcr3XGWV8UtJRsmgc12MP68frnt+q6O5t9Sp0sX jLvXz9v7orpcda/6ccf2x5In05sTp2ls9JBqieZ12mJ/vaectaMjI4Psom13tTetOanhttPE+uhr H9NFNGP9556T7EDv9lY3XlD+Pu1xd60kU1DSsmpyx2MO6gDkeeOFv7sz1LhpRzxkicnJ9/SKzJ+3 Fv8A8ZkinTuw9gp7VSQ6kq5/4tMSHOgnw0nuMAgY48cqI9bbYXzTepY7W2CStZUv6aOaJpIlHfB9 iB3+ysprmiFVe6+b8TLFNRU8c0AY7A6i7ByPPHC395Z1XfSj3jJE5/8AsZWrh6kc8ctzf9RFYtgL PHa6Nl/udXHc58tIgkBYXYyMDAI48HKh7WW3N703qVtofBJVPnfikkiaSJh3/cDuFZ7X9PLVXqrm hqpYJaCKKaJrOziXYOfphby+xh+o9KSOALhM/k+P7sqY4X1TLySSWfekOWT4faB1roheb1VU1znB Doo+hzC7GcN4yOPfKiHV2gb1p3Uos9RTyTTyuxTujaSJhnuP9VZzcKOrfqCoqKSrkifQtikYxoyH 9Rw4H24yulv8bH6p0tI5gLxK8ZI5x6ZW8vDrX9csPPM96+LpClj+H2Oa2UZu17lornM09UDWNkaH dwAePH3UMa30nc9JXqe3XaItkacseB8sjfDgVbDXsNc+91VZRVjoTbRFI2LpyH9RwR9OD3Wi+Jei hq9L0EskYMzHZa7HIyOVZ4d2SVfz6l396VBeOSvme69NUOmVw9ivOVweqF2CEk8ogSKaQ5QCQTSK BoS/VCBYQmghAJFPwjwgSPqnhLsgEk8o7oBCAgIDylhPzwhAkFM9kkAE0vohAEJowg90CTR5QRyq Ee6CgoQBS8poPJQCXlB7lPsgSYHujCCeUAeUjnKZKSBdkDlNHYoFhNCAgXlBKZ7pd0QkJlBQLz7I TwkVSF5TQhFCQTQiEUd0FHhAFCM84R44QHhIBNCoRCEHujsFQ8hGAkn1fZBvccrV3Q5eFtD9Fqrn +Zp8nuvFh7ejL087CAxxPsvA78xXtZ/uyV4jy4rti5Uz25WHnC+ju3CwK0ySEZTQAT+6SY7oMgfC 9dK9zRwSF4xyce6knaDQ7dXX2GKreWULHDrA7u+isHMUtDdaqmfVU1DXS08bSXTRwOc1oHclwGFl BTXSoo3VkNJWy0rQS6ZkLixoHclwGFZ7da/Umk7ZTaWtUDKWKeEB3QOBGcg8e55W/wBE0dJetv5L LStMFM+ndCS0flDhjIHum0VDt/8AEax5ZRQ1VQWDJbDG55aPc4C9LDdTkxwVxDSWktheQCO47d1b jQ2kqLbfS9dLKWvLQXvcAAXNb2ytxtrWfxa2zTODWROlLw0DgdTlNpYpg511DgfQruO39y//AKLw T1FXJl8nrEA4JLTgfqrw2++Oc0m7x+jTyyvZC84DXdJ9u69NPYaC56TNFLSxPpakvLo+kAOye6bT SiLq6dzQwSPIHgcoFfNEwtbI4Z8Aq7mg9DW/SNFW09NSxBr39QeWAlw9ueeFBu1E9ttuqq2rmp4X 1L55AHvaCWguPDQRwtY7s5JucuKCppHvJL3HnnlefPZWd+IbQVBWadk1fQgU1TC1pmaG8StJAHAw AQqyHAOE22xKSyIyEjwECQnlHYKBNHKzxx7rFvKy8KwfSN5a7jghb+g1PcaSIMjqHsaO3zLU2q21 N0r4aShiMs8p6WtVrNE7U6b0ZpuOv1RT09wuM7Rn12B7GkjIDQeP1T/pLqe1Xam6VFTMZZJC9x7k nK2dDqq5UsIZHUva0DAy7wp/3T2it9+tEN40jT09JUNbh0MbQyJ7fPA8rZaP2m03o/TcVZqimp7h cZwM+uwPY04zgAqbNKvVV1qKip9WWRz3k/mzlbai1Zc6eERx1LwwDGCpx3V2forrbYb1o+CCmkwA +nYAyJw9wPBW50ftFpvSmm46rVlNT3G41OCfWGWM+jR+qu0VfrbtVVFQZZZHPeT3JW4o9ZXWngEU dQ4NAx3ypp3a2dp66lp71oynhiBAZJTMwyPH+YfVb3R+zumtL6dZU6up4bhcanHyyZLWfRo/VTZp WGuu1XVTmaaRzpCc5JW8oNb3elpmxR1DiwDHOVLm7Gy8MkNPd9F08ccUhDJaZnDB2AcMnPcrotI7 L6Z07p+OfWELK+vqCPlc4hrPo3B+qstFZq28VVXVGeaR75Cc5J7LoaHXt5p6YQx1DukDH1Um7t7K iM0900XA000xEclK04azsA4Ekk5PddZpHZTTGnLBFLrCNlfcajGWucWtjPs3B8ZU3TpWetvlZUVZ qJpHulJySTyujotwbzT0gijmJbjHPdSJuzsk+nqYLjouFr6OdwY6mzgRk4AIJJJBXX6U2O0zYrHF JrBorbjORkeoWNYfYY9lZadK1Vt8raitNTNM90xOeoldLRbj3qClELZcgDGSDldvurspPQXKCr0n D61FUuDBAP8A2ZPAPUTyCu30tsVpqy2SF2sOqsuUxGQ2Usaz6DHf7pbZ7Zmsu4rZV3+tqa81U0r3 TE56ieV1NJuZeoKQRNlzgdz3XV7rbK1dpu0E+lYTU0NW8MbCOfSJ7ck8hd9pnYbTNps1OdWvkq7l LguEcpY1hPgAe3uktXUVuq9QVtTXuq5pnmYnqLs9l1lLufeYKIQslzgYzzlb/dHZi4Wa+xHTcLqq 31cgbExvJjz2BJ7qQ9ObB6atlmpv7VyT1NzmwXCOYsawnwAPb3Vts9k1fSuNVqOvqLh+LkmeZi7q 6srrqbdW8wUYhac4GOrJW33K2Xudk1FGzT8Lqq3VjwKcAkmPPYOP+qknT3w/6doLTSjVFRUT3OUZ eIpixrc+MD+qm6dK51Wpq6ouJrJZ3mcuz1ZXX0+7F5ho/Ra8HAxnle7cvZq62HU8cNip5Ku21r/9 nLcksz/hcf8AVSZp34fNPUdlpP7UVFTJdJeXtil6Gtz4xj+abXUV2qdTV81x/GyTvM5dnqB7Ls6f d28xUIha4E4x1ZOVluLs7erFqplHZ6Z9XQVb/wDZnjktz4cfp7qVNPfD3YKay0jdS1VU+6S8uEMo a0Z8Yx/qmzpCdl3Gudtuc1WZS98py7JXRnea7E9XS0/94rXbgbQ3uw6sbQWuklq6Oqf/ALLI3J4P YOPuApW0/wDDtY4LLSDUldVfxablzYJA1rc+MYV2dREF23QuVxuFPPMc+g7LW5yMraV28t1lojBH xxjJd2Ws1vtNfrHq9lpoqSWqhqn/AOyytBIIPhx8EDupc0/8OVmjtNM3UVxq/wCKSjLmQPaGDjtg hTZ1UBaf1hXWa7yV0EhEkji5/P5iV3rd7bm1mSzBAxw5c3rDajUNk1g2z0tHJVMqH/7NKwHpc36n wQO6mCy/DdaW2imF9utW26yNJc2BzQ0H25Ct/qbivettXV2p6109dKSOzW54C5Mrsty9C3TQ96fS XCNzqdxJgqAPlkb9/f3C41Zrcss6brTt5ntFbHUU0jmPac8HuFLH/bbcxbvRZkO6cZyoi03ZK/UF 2p7daqd9RVzHDWtGcfU+wVmLX8NFuNthbdL3VMuTo8uiia3p6sdgT4VlSoIh1pcm3f8AHmdxlLuo 8qQTvjcxbzC0EP6cZ6lw96201FbdXNsIoZZ6mSTphe1pLXj3z248qbLZ8M9IbfCLjfKmO4viJMLI 2lvXjsD3xlN00g2DW9xivP48zPMpd1HnhSK/fKvFv9KMHrLcZyo6ue3eoaLV39nhQSy1rpOiMtae lw98+3upvo/hlpnUETay/VEVydD1OiZG0s68ds98ZV3Z7TUQjS64uUN6Nf6zjIXdRGeD9FI0u+te LcYo2PD+kjPVwo1rNvtQ02rf7O/w+V9yMnQ0Bp6Xf8We2FOFN8MkTrfG2qv8sdzMPU6FsTS3rx2z nOMqcjUQtQ68uUF6/Heq4vLuo88H6KR599a020xRteJC3pz1KLZtBagh1cdOfgJHXTr6AwDgjP5s +31U3M+GR5tzRLfyy5GHrMIhBb14/LnI4z5TlTUQ/b9e3OmvhrzK4uLskZ4Kkmq33q3Wt0MfqCQt 6e/CiP8AsVfRq52mxQvddmyen6YHHf8ANn/L9VNx+GSf+HtL7+BcfR63QNgBHVj8ucjjPlXdNRE9 r3AuNLfPx5lc4l2XDPhSRX791j7Y+CESCQt6Rl3Ch+PRl8dqs6dZQyG6iT0zHjjvjqz7fVTXJ8Ml Y22dZvzHXAQ+oadsH+LH5QSffynIskRfZtwrjQ3s1rpHOc53U4E91JNw37q5LU6GH1PUc3pGXcBQ zQ6NvdVqk2CnonuugeWOjx+XHBJPt9VNNX8M1yitbpor5FNXNi9Q0op8Hqx+UHPv5TZqfCNbHuLc aC+mtdKX9TsuGe6ku67+VMtrfDB1iRzcAF3ChO26QvNx1L/AqWhkdcw8sdERjpIOCT7BTLcfhpvF PZZKmlvEFTXRxeoaQQ9JJx+UHKbLJEf6f3HuFuvhrXyuf1Oy9uVJd439mntL4YPV9Rzenk8KDrPp O83bUbbJQ0Uj7kXljoyMdGDgl3sAphu/w1Xyksc1XS3Wmqq2KPrNI2ItJPsDn+qciSfDh9Obk3G2 3w1skjnte7qcMqS77v5LPaHwQGX1Ht6eSoJsWlbxe9QssdDRyPuJeWOjcMenjuXewCl69/Dff6Cy T1dHcaatq4WB7qVjC1x+gOf6ps1HIaW3MuFsvZq5Xucx7+pwypLv2/klTZpIadzzI9uOVAuntLXa +6gis1upHvr3ydBjIx0Y7l3sApZ1B8OOo7ZZamsp6+krqiBgcaaJhDj7gEpyOMcxpLc+utV9dVTS Oex7suGVJWot/XVNkkhpnv8AVe3HPCgDTembrqC/xWi2Ur5K97+ksLcdGO5d7AKVdS/Dvqez2Oqr o6qjrpIG9Rgpw7qI84zhNpxjQ6Q3PrrRezUzPc6OR2XcqTdS7+mpsckFI95le3HIxhV50zpu56iv kNqtVM+asld09OD8nPJd7AKT9U/D5qyyWapr2zUVf+HHU6GlLi/HnggdlORxjXaJ3SrbPe3VE8jn RPdlwzypJ1Pv9+KsksFI93qvbjnjCrtpfTlz1HfILVaaaSasldjpA/IPJd7AKS9XbBat0/Zam4Zo 66OAZfHSuc54Hk4LR2Tkunx0JurWWe9Geplc6J7up3PYqQ9Xb+GqsksFI4+q9vdV20tp66alvUFr s9M+oq5XY6QOGjyXewCkTWOxGrtNWWa5StpKyGEZkZSvc97R5OC0dk2a0i69XKa6V0lTUPL5HnJJ WvTPBSWW0s7O7l1OkapkUr3Gl9s/lUq6x36bVWaWKif/AHrxgEDGFW/R2nLpqm8xW2y0zp6mQ+Oz R7uPgLt9bbNau0lZv4jcKaCWnDsO/DPMjm/UjHZWdJY3+227lTY7o51ZI50D3E59iu91rvxHVWV8 NA/Mr+MgYVcdI6auuqbxFbbNTunqJDz4awe7j4C6vXO0erNH2ptwu9LC6lLulzqeT1Oj6uwOArtO Lrds93qiyXR346RxheSe/ldxrjfWGosr4aB49V/lowq4aQ03ddUXiK2WamdPVSH7NaPdx8BdNrna vVejrXHcb3RsFI53QXxSB/Qf+LHYK7Ti7jbHd6Wy3FwrpCYXkknvgrtdeb4Qz2V8Vte3rfn8gxnP uq4aR01dtUXZtuslM6oqXAuPOGtHuT2C6HW22WqtIWyOuvlCI6V7ujrZIHhp+uOwU5HH4SDtZvDL Zqx7LhITE4k5PIXX6+3vp57O6G2PAkkznoGM591XDSOmbvqi7st1kpX1NU4F2AcAAc5J7BbrWm3W qNIUEVZfqAw08r+hrw8PAP1x2V5HH4SdtXvFJaKh8VxkLojkgnsur3A3tp57O6C2yN63g56OM591 WzSWm7tqi7tt1kpXVNU4F3SDgAAZ5J4C2msdB6l0lSwVF/tz6WGZ3SxxcHDP6Js0lvareU2yV9Pc pB6RyQXHgrptxd6qaazGmtj2hzxg9HHCrXpTTt21LdWW+x0r6mrcC4NbwAAM8k8BbDWWitSaUbA7 UNumpWTEiN5Ic0keMjhNmky7U7yfw0yU10k/uuSCTkFdBuJvPSvshpbO5jeoYIj4HKrTpbT911Fd G0FjpZKqqcC7oZ7Dk8r3at0lqHS3ot1Bbp6MTZ9NzwC12PGRwm118Jv2m3iZQtlpLq8FhzjqPBW7 3I3ipf4KKO0GNjXN6emPgAKtGmrFdtQ1xpLJRTVdQAXFkY5wvTqrTd801LDFfrfUUT5m9UfqDh37 KzJLE+bT7xR0kMlFdnjoAOA88FbTcneCj/goorO6NjHN6emLgAeyrRpyyXi/VbqeyUVRWTsb1OZC 3JAX31NYb1p6aKG/W+poZZW9bGzNx1DOMqcp7OPwsJtJu9TxUU1Bd3NLcHAeeHcYXt3O3ao2WRtD aOiNhb09EfAx4wq0aesl3vdRJDZKGorJo29TmwN6iB7rLUNou9lqWU97oqmjne3rayoYWktzjKTL V2lx30sftVu9Sm2y0F5LXNDSOl54IPC9G5m7NHDZmUFnLI4ujpDIzwAqy2G03W71EkVoo56uaNvU 5kLC4gfZO9W652qobTXikqaOdzetsdRGWO6fcA+E5T2cVmNrd2qGos01vvZY5oaWljzw4Hj+iz3M 3Xo4bPHQWYtZF0hoa12cAduVWGz0FzuEr2WukqaqRgy4QMLiB+iyvFJcrfUinulNVUtQWh4jqI3M d0nzg+FZknFaLbPde319jlt9+LJGhvSWSEYcD91jufutRwWplBZyGxhoaGtdngduVV6101wq3vFv pqidzAC8Qxl/SDwM47J3OGupJ/SuEE8ExaHBkzHMd0nscHwm57XVWo233Ttl2sMlvv4ZI0N6XRyH h37r5bp7p0cVsbQ2l4EfSBgOz2+qq5bIa6oMhoIKiYxjL/RYXdI+uOyVwdWRP9OrZLG/GemRpBwf oUmU3s42rYbfbnWm/wCnXW/UAZKGgNcx57858/otbvDufTR2x1utbh6JZ04BVYrcytlL3UUVRJ0j LzEwuwPrjsvlXVE7nObMXdTe7XZyP3Vxz43l8s5ePnNV8KyT1JXO9ySlb6h1LWRTR8Pje17fuDkL zkl3JKQ4PCxbvuus6nS5uitw7FrPSjaPUTWvcwN6mk8hwOc5/ReLdjc2kpaVtDbZAYxglrfOD2VU bfVVEBP4Z0gJ79GT/RZ1VZNO753kkd89wrjqM3dXE03rnT+tdLNp9QNZIW9OQcdQcDnP0Wm3X3Kp KSmZbrW5npNI+VvAIB7Kq1HXz0xPpSlufYkIq66aoPVI8uPnJ5VmUlSy3pcWyau09rvSscF9LXPY W5/zBw5Wn3S3IoqGmit1rLBDG5pAaMDjxj7qq1DdZ6Nx9GdzM9wDhY1lxmqnB00hcfJVlns1VxrV qbT2vNMU7bw8CeJzT1Z+YOH+h7ELTbobi0Ntgp7dayxsELmkBowPlORwqsUN4qqMFsFQ5gJzgOIW Fdcqird1SyFx9ycpLIlxtXIor5pvX2nKOS7SNFRC5rg7z1Dkj7HsQtNuZuJQ2qOnt9rMfowPa4Na OAGnPA8Kq9uvdXbwWwVDmAnOOrC+dxulTWSdcjySeScpLE4rlwXXTmvbDQ1FxmDJoXNOQeTggkH6 HyFo9ydw6K0so6G2Fhhp5GOAHb5Tx+yqzar9X0DCymqHxtPJAOAvjcrtU1knXM9zyfJOUmpV1VzG V+n9eWe31lbOGSQvaSQ7HV2y0jyDlaTcbX1BZzRUNAWelSyMcMHOOnsqs2nUVwt8Zjpql7GE5LQV 57ld6mrl9SZxeSe5OUmoslna5s09g11brZcKmoax8L2lw6sCQeWn6crSbh6+oLPLQUlEWuZSSNI5 yOOyq3aNUXK3welT1MjI85DQ7svJc71U1svqTPc5x8kpNTtd1cucWPXVJa7nLVNiMDh6jC/AkbjJ af1OVqNwNe2+z1Ntp6Toe2kkaRzkcDHf7Krdl1fc7bB6NNUPbHnPTnheG7X2qrpzJM8ucfqnRuxc yvpbRrmntlzbXGD0yBKwSdIlZ3LCfHPOVqdca6t9orbZTwFrxRytJOc+Md/PCq7Y9Z3W2U/o09S9 sQOQM9lr7tfqqvnMszy4n6qSSU3VybjarVrX+HXaKuMMbRidgfj1WYJDfpgkH9FrdZ65t1pudpij cHtpZQSSf+Et/oVV+w65utrpRBBUOEYOR5wtVeNQ1NfUGWWRznE+6t/qeuouVdrLb9ZS2+6UtaY4 D8tS1r8GRgGQB7c4Ws1jrO22q72aLrD20kwJJ7/lLVWOw6/utsoxTxTkRg/L7ham8ajqrhUmWWQu d7kpL81d9aXAven4NWXK3XairnMpH4bVMa8DqYASMfrheLV+sbbb9QWWP1C6OkmJefu0t/1Va7Fu LdbZRtgjmPQ38vGVo7zqWpr6p0ssji4nPJ5Wpl9ufCT/AFW+1Bpwapu1vulurnNoZcNqwxwBLG5I x+uF4tXart1FqSxtc8ltHKS85x3aWquGnty7pb6JlMJcsj/L1dwtDfdUVFdVGWSRznOOUxy77S4b motxqXS8mpbzRXK2VobRTANqsEcNby0j3OeMfVfDVuqbbRansjZJM/hZT1kH3aQq6WDc+626jip/ VLmRj5STyAucveq6i4VrppJCXE5Vmf2z+KY39VtNU6crL5fKWttdYBb6sNZUuHPQ1vLSB55XI/EF d6OSzRUccgMsJ9+/CiTT+610t1BHTGQvEfDS4k4C5DVup6m8VD5ZZC4uPlMc7jdr+KXqOXr3NNQ4 jjleLPC+shycnknuvi5cHpJHdB8ICBlJBR4QHcpeU0IFyhHhCAQhCAxyj7I7pIH90cfujuj7IAhJ ZJHugSEeUFAIQhAIQe6CgSPKf2R5QCCEIJ5QCZHCByhUJLymUkDPdIoKO2EAUkygd0CPdMYxyjPP ZB7oApJ9/sl9kBhCAjCARlBQgPKWOU0eOUCCOEZQEQiMITISVIPCEIyihCSflECXZPugIF90DKEc oGkhCA8fVI4x4TQqEUsfdZE5SVG9K1dzOXDHstm9aq4928crx4e3fL0+DSBEV4f8S9uP7k+68Lu+ V1jnWZ7LBZFY+FpkkI+yEDHZZBYjvhZBBkz87furG/DW1oqmuJAw4KucX5hhSJt7ql9mnZ6buloP KCRPiaZUDWdDUiKX8MKJrDKGnoDupxxntnCkPYOgq5bVFXVUxEIwWsI4P3XM6m3Dsd902KGupoqu fGWmQ5DHf5gPde6TdC127RZt1vAFT6fQ3DsdJ98K2bZd3u1b5L1oupdR1b2tp+qQsjYXGXHHT37I 2YH/AMLAJbg4aCCPK5HRW41roLT0V0nqyuGeXLeaf15p6228siaQ+R5e89fOScqSVWj1Pf6nWV2t 1pslNJJNQ1Mj6mQcNaO2M9vCkW4Vn8P0AZ+3ptGf/GAuatWttK2aOcW2lZA6dxkkLXZLnHuSuc1z uHaZdDT2qld1VE2Gg9Xb5gSf5K3FJUs2i6x3ixvqY2gODeT2B4VPdFSuOuCzPymd/H6lTnpfcGzW PSLo6h/qS9GcBw5OFHOzYsFBdKi83x4km63GKLIAZyTk+5W8Lrx3G+2Mp/ycp6S5vaA3ZG5NxgmF gH/jCpU7/eH6Kbt9dzTqUutlA7otzDyB/iKhEnqWdOkLwl3TSQJNLymoGO6yCTU8ZCokrZCMSati JAy0E/zVt9cNom0ljdc+n8MJ2kh3Ynp8qmu2F7ist9bPKQAR09R8cq2FBqCz6jsbYLy9ha0Za7AL h9R7JLq7jOWPKadIwRnRlS6FoEZMhYAOAM8Lz62bQimsX8UDTAJM9LuxPQMZ/VcRrPcq2W91LZrS 9op2gBxC39PebNqazRw3qQZjw5js5I7dlNNSx0JDP7EyuiADCXlgA/4hheXW7KI/wEXIt9EPd8rj wT0DC47WO5Nst8lLZra5ogaB1Fb9lzsuqLNDHeZWt9Fwex+fmHbt+gV0za3j+kaMaIwMOcen/wAY wvPriKidU2NlxLTD1y4a44BPQMLkNYbjWyhqKWzW57PRZguPhdAa2z6ptEAuszWPhcHxvz8w7Zxj 3AwklNtu5gbpKBrR8pkaB9usYXx11BRPr7Iy4lpha6bDScBzukY/muS1fuNbKOsprPb3s9JhBc77 chdBNU2jVVspnXOYMkp5BIx+eeSM9vfCsiXttnsH9l6TA7yR4+g615dcU1JNc7SK9wETfXc1pOA5 wAwuY1ZuHbKS50tnoHsEbHAk59jwt9WPtGq6OkluNQYZKZ4e0h2CQT8w/XCllSNxKxv9m6HA7vh/ m9avW9LS1F7twrZAGMZK5rC7HU7jH3Wh1RuHbKa601poXsDIyCT3/KchbqvjtWqY6OrrKr0Jadwc HB3JGckfqrhNUym9abSojb/BraXDnqh/m5eDW1JT1N/ovxby2OOnkexgf09Ts8ffC0mpNf2unvFN a6N0ZbEWnJ5/L2W6uFLa9Uvoa+qqvQkpyMkOwS3OSMfVTKbMJxjZVwH8NtBIyeuHn7krU6wooKrV UJrpnMjipHPjYH4DngnGfdavUmvrZBfKW10royICDk88t7Lc3Oitmp5qC4y1foSwEBx6u7c5IA7c rWF4pljts6xoNJZXOaC4yRArU6to4KnU4dWTPZHFSF0TGu6ep2T398cLXX7Xtthv9NbKV8bm05BB JzyFtrnbbdqOsobq+tMD48Ne3rxlo5xhYs3G8emzrow6lscj2gn1Ywc/ZaXVVIyp1TNJUTPayCka 6KMPwHPyeT7rxXzXdui1DTW2nkY4Uzg4ZPkcLaXK00OoLjQ3c1pg6AGys6sdTR4H6pNyaTUltjcV TWvbYS5oJMjf/KtBqmk/E6nqZpp3tZT0rHRRh2AXZOc+68151xbYtSUtvppGPFL8zST5xhbO52aj vt1obyK4wtYOiaPrwHtHYAfdNK21Yxsk1i62gkuzz/yhc7qek/Eapq55KqSNtPSxPiia4APcSQc+ /wCiwumt7azUtLQ08jHfhc4ye5xhbC52Slvd3ory2tMTA3omjLwA5oHGB900NvWRtdV2LqaM5J/9 wFzGoqWSp1NW1Dql8baanhdFGDw9xJzkfb2WV11tbhqako4Xtf8AhsnOe5IwvbcLFTXi+0d5ZWmK EN6JmF4Ac1oy3A+5WvhjLuyt1WwxvutlLmgkdZBP/IFy98ppp9T1tVJUPjZTRQmKIHAcScHK+tdr S2u1RS0kMjHupg7nPfIwvVX2KK56jpbyyuMdMWdM8RcACGj5cfqpJ9rK3FbCx17tBcwFzTJg+3yh cpcaWqdqytrJKl7YIfSbFC08En82V6qzWltdqmnpY5GvNP1c55ORhfSfTxrNVRXpteRQubmWMuAH yj5cfr3W/wDxscrjblj/ABEfxjxN/gFmOBls78fsqlY7e6sx8WWqaK6fgbXSPD3wPc9xB+irQO4U zvUn8dPDLJdrPfB3a4PxVdcXMBnyYw4jkDCmaemqv7V3CtdVOEMU0cccI89WMkqGvhTvdHbqeeGd 4Ej5CenPIBA5U6zadmn1Y27xVp/hsn95LGcYy0cY55/ZTG6xs+1zx3lL9NrVU0X9r6KVzG+oI5Ok 458LnZ6etk1RXXB1Y5tNBUMijgA79WASSvWdWWyfVrI2SNc6FpbkH37rKfTdTNqz+JxVo/hkg9WR pA/MOwHKvLSyabWeigOs6acxt9X8O8h2PqFzj4q46lrbg6q6aeKqbCyANyXA4BJPgL3t1bbKjVzY 2SgmFhjyD7kcrF+nKx+rHXAVoNqePWc0gYDh2xyplbUk16buakgdrGnm9JvqimcerHPdczHDXv1P U18lURTtrPQbD09x2zlbCHVNuqNWFrHtzEwxZDvc5yvnHp+v/thLWmrzaXD18EdnZ7D/AKrOmttu 6jpn63ExiZ6zaX83SM/m91z1LFXv1PPWzVWKb8YYGQhvOOBknK9tJqS3VOrpumUEtj9Hg8d+6wgs VybrKWrkqwbPj8Q3jjrJ7D9u6I2Zt9I7XTqowR/iG0YHX0jOOo+VpaGK4P1O+tmqSaZ1c6mbD08g Dzleyk1FbqjV1QI5WkiMQnDvYk5/mvnR2S5xa0nq56kOsw/2mPjA6yTkf++ix72WykGu6isbBGKg UbAX9Iz+YrTWhlydqQ1tRU9VLLWSU7YenkNHY59u62NDqG31OrKsRzNOYmwk58hxOf5rz2uy3Sl1 fU1FTUtdZWD8RESMYe7ORjPj3Vx6l2mXeUr3Utqo49cV9ZHTxtnNLHl4aAT8zlqbE64v1EKuqqeu nqKmWBsXSchrexz+62Vtv9vq9U1gimaSY2w9/LSf+q8dkst2otV1UtdUsks8X9/A4jGHOzkfp7qW W4pjqV76K0UUOuLjWxU8TKh1LGC8NAPcrVaYdcn3ttVWVIdBUzTRsiDSCGtz0kn9/C2drvdvrNUV whmGTG2Lv5BP/Va/TtqvFHqurkuM7XWmDMkDiMDLs5A+y6Y/61Mr+029tnstvpdb3etp6WFlS+CI Oe1oB7leHS8l0kvbKmuna6nqpJWNiA5AbnGSthY7xQVWprj6M7SXtbGAfdq8Om7beKPVFYbnI3+G UuX078YB6s5A+yzl3K1hqe3osNkt9Lri+1tPSQsqnRxNL2sAPYnv+q8Wj5rs+9NnuErHU1YZWsYA cjpJxn9ltNP3ahq9R3U087S6XpaAfdowtZpW33qk1NWfxYsFto8mnk7B3Vnt9lvl1Yj2aZsFtodX 36tpaSCKpcI2ue1gB7Z/1Xm0hU3aS7xyXF8T6asEnphvcBpP5v0Wx07daKsvd29CZpMxaAD9Bhaz SFDeqO/1YvHptt9FkU7xwHBw5wVjLutSydPVpfT1stmqdRV1JRQRVDnMBkawA/lz3Xn0fU3WS7Md cvSdT10TpY+jOcA4w4HzjC2mnrnR110vDaadrnTPBbn6N6f6rVaNpL1T3urN6EbaKhzFA8cBwPOR 9FB99I6ZtNmv+pK+30UENQ+UZexgB/Ln+q+eiqm6TVzXXP0jT1sLpmdJJJ5xhw98YWx05cKStq7w ynna500pc3/w4/qtboemvEFxqzd2sZS0XVBCRxlvByPccKUPRul7RY7vqW4W6ighqZJzl7GAEDpB wPplLQtXc6urcLo2I09ZTmoYGkknJwQ7I74W003W01ZJeGU8zXvmlc9oz4xharQMN3irq195iZDT 0QNNCf8AM0YOR7hXRfY0Vpez6frdR19roYYJ31LyXMaAQA0HA+mU9C1tfcJ5obvHGYqmATtAOchx xg/XGFs9PVlPXwXmKlla+SWaR7RnwQAP6LV7fRXWKprpr3CyCOkH4Zh/zBuOfqPqnWqzZblPpS3f az09l3QvtNRRNhpvX6mMYMBoIB4/VcAOSpN+IarhrdzLvPA8PjfIMEeeAoyj/MFmuuK7nw66fodP 7T/ximp4xcaiKSWSbHzOAyQPsMLtdG1Fbd4q2hv1PH6c8DZ+juHNef5fZaTZotrNnKSio3MfUmlc 0Nzjlw4W82+ddJH3CtvdMKQQNFKwYwS1nJP257q4/wCk372553/ksnprtBaZtejbBqCvtVJGyo9a dxdjkhvIb9lstKPrLzSV9u1HRxiOeFs3pOIcHMeT3/Zeu1ObcNMXeno3NlmlfOWtzjPVnC8239Tc ao3CvvNMKVsIFK3PGWs5z9ue66fH92m9tRoHS9q0Tpa919opGMqDLM4uxkkNJ6W/YLc6d/EXy33C 1akomenLE2R0TiHhzX5/6fovvbwK7R9xpqJzZp3GYtaD36nEhefQFZX1rbhdLxTikY0CnaDxwwnn 9ymWiNRoDS1r0LpC7V9npWNqHvld1HkkNcQ1v2W2sYfqW1XS06koWdBY3rheQ4EOGV66cfjtE1lP Q4mn/vCGA98vLh/JfDQdbWVsFwu10p/wjHYjaHcHDCckhYb20WhdLWrQOjLhcLPStFU8v+d3JcA/ DW/6Lc2uAassd2s+paBvS0BskTxn8wyCF6Cw12g6mChAnnHU4MB7n1OoD9lhoSvqa6juN5uVOKRs 5AAcccNGMn2Szs3257QWlLVt9oWquNppWurZASZHcud8+Gj+a3NHRw6z01dLRqag4jPpvjlHzAkZ BB/ZeyRjq3b58VEBNK1od0A8nEgcR+wWGhq6auttyvFdTmlFS4OHVgZa1uM91K105zRGmLXt5oCW vtVMH1r2hzpHcueS7AH8wtu230uutKXG1amoD/cu9NzJPzNdjIIPhe2qjdV7dtjo2evLHGxxY08n peHEfsE9E1s1dabldq2nNI2rf6jQ892huM/yVnqOdt25rQum7bt5t4a6204kq5GBzpHcue5zsD+q 2c9rpNfaMuFu1JQn1IHOiIf+djwMgg+DyvfXB0u28P4aMzvhZE90beSelwJH7BZ6IrJK6yXG61cB pWVkrpmh3GW9IGf5KRu35cro6w2zbbbpldbaUyVUwaXvPL3ucQ3g/twvdc7RQbj6ErKe+0Z9emc+ MOeMSMe0ZznwclbG8tcduqF8MLqj8P6Mj44xkkNcCf5BfTQ05n0pcbjLAaaKskfOxrz3aWgA/rhd ZJxl+XDllfJZ8Od0ZYLZtrt1FWW2lM1ZUtYZHk5e97uO/wDovtqGxW/crQVV/F6V0VZSF7GyOGJI 3sGf6rb3jrG39rmihdUimMEskcYyelpyf5L6aTqHVejrvcZoXU7K2WadjX8fKWgA8++FNTUa5W2/ Tn9IWK17abeU1Tb6UzVtU1hkk7vke8Y7+3sEav05bdzdBTzXKnfDX0IeI5SMSMe1uSDnxnwt9f5T Boi0VLY3TR0phlkawZIDRkrHS1Q6s0Vea50ToBWSTzMa/jIc0Y++VeM1KnK8q02kNPWzbTQNPNb6 QzV1WGepIBmSR7gOOOSPYL4a60ta9zdCyVtbC+nuNCHiKfpxI0t7td9D7LqtS1Qt+l7RXGJ8sNI6 OV4Z4Ab3+nK+NgqBV6GvFYYnQMqn1EzGv44cOPuueu+3Vz+lNP2ra7QsMtDTumrazp65Q3Mj3OAw OOSB7Lz7jaSte5mhm3SRhprjShwhqA3Dh0nBaR7Zzwus1ZWstdhslwlY58FK9j5Okdh0Y/qVhZpB U7f107YnxNnM0rGuGDhziR/Vbkmoemh0rp21bX6KhNHA+asrOkPmDcvc4jPjuAtZuhoy2bj6IZfI WinudOw+nMB+YNOC0/Tuu31VXRWi12S41LXup6Z4dJ0jOAYy0Z/Uhee3ObNtpUyxxmJkolka1wxg F5IXOe+1+Wj0vpu1bWaOi/CMfLWVeA+fpy5ziM8gdwFpt2tB2rX+kmajog2muUTeJWj/AHjQ7BB/ mu91jXw2ilsVwrATS08hMhAzjMRA/mV5aUtk2vkfE0sZJ1vDSMYBlJ/orPgaLTenLNtTpaI08Rlr avDXzluXPOM8j2HK5zfLQVq1ho2TV9qaynuUEPqFzW8VDAcYd9fYqSNcV1NaX2Ovrv8A1SB7+s4y OYnAfzK1tWWP2ZrDGMRuppC0EYwC4kBSd544/bncrJlfpQ+ZhY/n3XotdG6vuNLSMIa+eVkQdjOC 5wGf5rK4tDah4b26itjooA6rsw/+/YP/ALIFcpxtjpjdyVb2yaa0/tTpaCF0UU9bOQHzyt6g9/vg 9uD4XLb1bZW/Utvg1Rp306apnLPVHT8sjXEDqwPIUk7i1VNRV9pnrSBAwTAuIyATGQP6rGYM/wCy ulEWQzpi6ft6gwukxn6vPh5LlcpZ6aGzaa0/tbpWmp6iGCpq53DrlmYHB7/Jwe3H9Fx29m1lDeYa fU+mvTp3Vb2NmjAw13UQA4AfdSjuLNRQVtslufSIBFOB1NBHUWYHB+6xnYP+zC1BvLQKfH26wrwx 1KTyZW5RobLpHTe2mmKWlrKenq6mocDLJUMDw9/YkZ7DC4XefaOkuBpdSaTEcEVdKxs8GMMy8gB7 QO31Cl/XlRbqe6W995bG6mEEwaJGgguIAHB8r5PaDt1YmjlnXTc/TrC58fTpMvhzVm0TpXbzTFJS XWlpayrnc10r6qMPDn8A4z2GPC4TeTZ6nqailv2kBFBT18jGS0+MMa55wHNA7D3CmbXUtriulML2 ITTupZWs9UAjrPbGfKXQH6C08M5b6lLz9OoJppx9j290joXTdBT3ygo625TOa6WSoaH5ecB3ST4H suE3i2bj/iFLeNICJlHcJWsfT/lZG9xwHNx2H0U0a/8A4X/E2NvPpekaN4jMvYOz3H1xlfV4DtI6 aA5Hq03P0yFZCd3TiLDtrpDR2m6Cn1HQUldcZnB8kk4BIccAhp/yjHZcBu1sw6G70tw0kGGguUrW +j+VsTndsf8ACpv3Bhtk9fIy8emGfgHGIvOCH9fdv1XqrOdN6Z8j1qf/AEUx7rckt04LT+12j9La boqXU9FS11fO8Pkkl4LScAgHyAo63T2WqLbfqOfSjRNbLnKGRxk49B7ucZ/y/VTrr+nttTcJWXct EbLe58TnOLel/XwQffsvfcs/wnTA75lh5/7qSMY/tdVHundpNI6csVJTaopoa+4Tv63SyktLMgZA x3AIKjjc7ZartWoKU6Zb+Itlxk6YWuPMLzz0k+RjsVPW4NHb6uvlbc3Bvp28yQOLy0tk6jgj6rZ3 JvVSaXB5/voyT/3FmXbpjJvVRrpzZ/SFjstJT6ojZWXGdwLpHOLOjIBxwewKjLcvZq4WXUdNDp2M 1lvuEnTT5dj03HJ6ST3GOxU8a+oqasvc34l3SYaASRO6+ktf1kDH7AfquhuDTIzS4fy4zMJJ9xGV 0zx4yf1y8Vufd+KjDTey2k7RZqKDVDTVXSZ2XyCUsDcjOMewUXbh7QXSxalp6SysNbRV7+mlcDjp J56SfoPKsHr6ihrrrVCaZ0T6ehbNA4P6cSdeP19lvLi31H6XMgBd64JJ759Irnj71XSTqVFendkN K0Fro6bUz5p7pMSDJHMWNGRkDp+nZRTrnaS8af1RDbaCN1bT1j8Ucrf8Q79LvqArD64oIq+93CSS d8UtFSRywFr8AOL8cjzxwuiuzOu6aVc8ZcJic/X0iutw1r/pwxvKcv6izT2xOnaW0UcGpp6h91mz mSnnLWZIyOPGPqoh1rtZe9OaohtUUb6yOseW0c7GnEo74PsQO/2Vkdd0QrbtcpvWkjqKClilp+l2 BkuAJI88cLe3lnXetKF4BLZ3EH2PpFYxnfGuls4zKIo0/sRY4bZRw6irKgXSXIcaeX5M9xwRx9uV EWsts73p7U7LQIJKv8S/FJNG0kTD/Qgd/srJ69pzNe62ds8sc9FHC+AMdgZc7ByPPAXQ3xnVqPSr ngOImdz7H0yt3x3pynkln/tENi2BtLbfRMvl1q47nNlpZC4FhdjIxxkfrlRBq7by96f1SLNLBJUS yvxSvjaSJm/9QO6tBrulmqb1Vz09VLDLQMiljY3kOycOz+i3d+Y12q9LyOALhI/B/wDoZWZjtrLO STX3pDdn2AojbaJl3vVTT3OcEOjja1zOrBOBxnt91EWqNBXvT+pf4PUU0ktRI/pgdG0kSjwR/qrP a9hq5r7UVdJVyQvt3pyNjAy14ccOB9uF0V/hjl1dpaV7AZA+TBI/4Cul8etOePl3v+VC1o+Hxstr ojc73NRXWZh64GsbIwO5wAePGPdQrrfSt00neprddoSyVn5XD8sjfDmn2VtNdx1zrxV1tJWuh/hx icIunIeHEAjvxwVzvxNUUVVpy3zvjBmjJIdjnBHbKY+LlZJWr5pjN2KiPzk+F8yPdemoYWyOBGOV 53A8rjXoYpFNH+igPKEIQJCMcoQH2R5THZHlAk0j3QgEeUIQNLygIQHlI900HlAdylgphCBJlLyh ABCEYQMJeUAJ45QJMI4CFQJJo7oEkU0IBJPujygD3R5STQHlBSxyssfsgRSxlNyXhAihM/ugjKBF GE8JDgIDsl5TPdAQCXnKfdACukLwkmOyWPZFA5KCE8FLGO6A8I8J/okgMoykmiDwlhNCBFLv5wmS gIA5KB7IRnlUGcDlLI9ishg/ojj6KjcSFau4H5s4K2D3ZC19f3b9V5Mfbvl6fAf7orxEfMvaGn0S vG7ly6RzocfZYErMrA9lpkBARhNA/KAjyjwgyb38r2wSPYB0EheNn35Uq7K6Eh1bfGG5OIoYiC5g 7vPt9kHFQUdzkozWRUlY+maCTM2JxYB/zYwiKluTqQ1opKt1IOTN6Tuj/wAWMKye72pKazRw6Pt8 LaejMTTKxvALD2GPquvslupNU7cSWZgNPSSQ+lhmMjzkBVNKg0DLhWF34GmqZ+j8xijc/p++AvRH Hdns6o6SvezJHU2F5GR3HZW707ZaLbTQdS6Qte5rfmxgF5zgZ9ytxt1Vms02+eXEbQS4NHA55SU0 pa+K6hvUaWvAHkwPwP5LwyOrOgzujn9LOOssd05++MK7ltvz/wAABfGCD8U1/pBxA6wPGP1C9TtM W676MittVTRmlmYSWAADOeE2mlFmz1c7Xem2WVjO5a0uA++Oywjq6gN9ON0hJGcNyThXe0lpCj0r pa5UUEEbW9D3dXSMuHSe6hDY2ut9puL5DBEamUkGQtBfgnsCeybNIHme93Emcg8gjBXwP0VkfiP0 LQMtDtW0eKeoLmNmjDc+t1HAJOeCPoFW9wAWtXW0xsvpjlGMppKNEf0TBwgjhA7KAB5WWeUghUfe J5a7qBW9pNS11LB6bKpzG4xguWv0/aKu+3SGht8fqTyOwM9h9T9FbHTW2+mdBaYhlvdJS3G5VOOu SoiDxng4aD2HKmxU+W5zSymR0pe/OerOVtafU9xgiDI6p7Rjt1Ket2doqW+UNPe9JwU9LOcMkha0 Mic3sCABwVv9NbZ6X0PpuF9/o6S43Cox1SVEYeM+Q0HsBlXbKqk9wqJ5jLJIS89znK21Pqu5U8Pp tqnhuMclTjuzs/T3WCmvWkYYKd0haySnaAyIjgAgDsV0em9rNK6MsEJ1FSU1yuNSR1PqGdQB9mjw BlNoqtPdaiacyySuc4nJcTytxTaxulPD6TKt3RjHJUy7s7Mx1pprvo+GKJkzmxyU4wyNo4Ac0e+e 66nTm0uktI2KH+01NT3K41BHU6duWg+Q0ewym1VZnulTLOZ5HuLyc5zyt9S64u0VMIo5yG4xz3Us 7sbKCSemuWjIY2wTuDJKbhjGZwGlvJ+uV1mnNn9JaVs1OzU9NDcrlOR1OlJw0+Q3B7BJS6Vdnu1T LV+tLI8yE56s8roYdc3iKn9FtS7pAwD7qS91Nk3tudPWaPjaaWqeGupzw2POAC05JI75Xb6f2b0f pu1U0Wp6dlxuUxHU6RxAaT7AHslthNWdKvVF3q5av8Q+R5lznqzyuih19eW0vpNndjGPqpC3R2Rq Ka7wVGkYhJRVbwPRzgRZ7YJOSPdd3YdldIaftdLDqaEV9ylwXvMjmhpPgAHsElpqKwzXiqdVfiZJ XmXPV1Z5yumg3FvTKT0mzktxjODldruZsnW0WoI3aXiE1BWPHpx9hFnsMk5IUh2LZPSVjtFJT6lj /HXGXBe71HMAJ8DHgJtZJ8KwzX2rlrTVSSv9bOerPOV1EO5V5io/RbNkYxnyur3K2TuVt1JGNNQG ot1a/wDuQDxET2BJ5x9VJFi2N0laLTR0+pGurbpJzI8SlgBPgAeAm0ulZZL9WurvxbpnmYu6urPO V1ce517ZSeiJTjGOod1v9x9lbradTxxaegdVW6tk/uCP/ZZ/wk/T3UnWTYjSdstNHBqQy1d0k5kc 2YsaCfGB4TYrPJqGtNf+LMz/AFi7q6s85XXM3SvTaP0WyDtjq5W03C2Yu9o1ZFS2CnfVW+tf/szx 2jz/AIXH6DypSs2wulbfaaODUMtRUXWQZe5kxY0E+MDwpsVrdqavNz/GOlf6xd1dWV2LN17y2j9I PHb82SvXrrZm92rV0dBZ6Z9TQ1jv9mlA4bn/AAuP0HlSvZvh/wBL0VqpYL/UVMt1kbl7mTdLcnxj 2V2l0rcNT3AXP8aZ3mbPV1ZXZt3dvDaEwAjOOHA8p6y2bv1r1fHbLXSvqaarfinmA+UDvhx+gUt2 j4etNU1rpYL7VVUl0kGXOjl6W5x7Y7KS06VxbqqvF0/HOmeJurq6srt/+2C7Ch9FvBxjqBK8erdo L/atZMs9BSvqYal/+zThp6ek+5+g7qYLR8O2norXTU96r6o3V7SXOhkAbn2wR2V3o6V2g1ZcI7oa /wBd3rF3UTnuu3dvHdvwJhacO6cdQctVqLaLUVs1kyx0tLJUiofinnDT0Ob7k+MDupktnw42GOgh gu10rXXN7MkROAaHY8DHZN6qyTW4rzBq6viu/wCO9Z5m6uonPddzNvLdTQGFgwcY6gVz182q1Fb9 ZCw09HJUSSv6YZg09Dm+5PjA7qa7d8N9jbQRQXK7Vf8AFXRkuEZb0dWPH0yrbZ7SautKu3y5T3Kr knqZC+R5ySStZldVuDoy56NvU1Dc4XhrXERThp6JB9D7rlVmtzWum+0rf6qx18dRTPLXNOcZ4IUq VO9tzdbzDG0teW46upRLpXT9x1LeKe22endPVzOw0Ds0eXE+AFZaH4aLZ/D4oqi+VTbr6OXMa1pZ 147DyBlJSxBFDra5U93/ABomcZC7Jye6kCo3uuLrc6FuWvLcdWVwVTtzqOHWH9nG0Ej7gZOhpDT0 Ef5s+ynCP4aKH8AyKa+1IuvodRjaxpj68dvfGVeSaQfbdcXGkvP48TOc8uyQT3Ug1u+FfJbjDEHN eW4z1KOnbeaibq46dbQPdchJ0cA9OP8ANn2U4N+GamFvayS/Ti6iHrdEI2lnXjtnvjKbTUQvadeX Kiu5rfWc55dlwJ4KkKv3yrpbcYYupry3pyXKM26A1E7Vx06y3yG5h/QRg9OM/mz7fVTbL8MzG23p /j0huoh6zEIx09eO32ymzSH7Pr65UN6/GmUuJdlwJ7qQ7nvpWy2wwQh4kLenPUotptCagqNWHTsV BIbm1/Q5uPlAz+Yn2+qmmp+GeSO1kx34vujYQ90AhHSXY7A57Z8ptLJET2TX9xoL1+N9VznOdlwJ 4KkW6761s1rMEPX1ubjOeAoloNE32t1YdPU9DIbmH9DmEENbz+Yn2+qmit+Geqitb3wX1s9xZEHm nEAA6sds57Z8q7+KanuIwsO4VxoL0a10jn9TsuGVId631rJ7U6ngMgeW9PLlENt0ZfLhqr+z1NRP N0Dyx0Z4DcHlxPspkuvw1XCls8k9HemVdwji6zSiDpycdgcpsuojnTm4lwtt5NW+Vzg92XAlSJe9 96qotL6eAyB7m45PChux6NvV61M2x0NE83HrLXMcMBmO5cfYKYr18NV1o7JNU0V4hra+KPrNIIOg uPsD1f8ARLfsmtbjgdNbjV9rvJq3yOe17suGVId+34nqbQ+npzJ1Ob08uUL6d0her9qRtioKOQ3A uLXscMCMA8l30Cl6+fDZeKCx1VTQ3eGuroWB/wCEZD0l3uA7q/0TdNRxOk9ya61Xl1VJI5zXu6nD KkPUW/M9VaHwUrnl7m45PZQjpvSd41BqNllttJI6vc/oewjHp4PJd7AKXNQ/DffLdY6mspLnT19X A0ONLHEQXe+CT/opyXTktH7l11pvJqZpHOY93UeVImpN+Zaq0SU9O97nvbjnhQXpfSl21HqCOzWy le+tc/pc1wIEYB5LvYBSvqT4dNQ2mx1VZTV9NcJ4AHGngjIc4eeT9E5HGOc0dudWWe7uqJnvexxy 7lSDqXfmWrs0lPTOf6jxjlQVpTS111Nf4rRaqZ8lY9/S4EHEYzyXewClDVHw86ksljq66KtpbhJT gONPTscXEee+OwTkcWo0VuhWWi7Onme50bzl3K77VG/MlXZ5aele7reMc+FAmlNMXXUt/gtNppny 1cjsOGDiMZ5c72AUmav+H/VNgs1TXxz0lxbBy6Kl6i/Hk4I8JyOLx6F3Tq7Pd3S1MjjG85PPld/q zfl9TZ5Kele4veMKANJaZump75Da7PTPmqZHAO4OGDPLnewCkbWGwurNO2We4udSVzIeXx0rnOeB 5OC0dk5GhoHdars93MtS9z4nu6jzyCu91fvz+LtMkFI93qOHthV90fpm66rvcVsstO6apkPJ8MHu 4+Au/wBZ7G6t0zZZLlOKSsijOJGUj3Pe0eSR0jsrMix6dvt2KqyXYyVUjjE53Vn2K7nW2+5q7JJB QyEyyDHbGFX7SOl7rqu8xW6y05mneRk/4WD3cfAXba32T1ZpSym5VkdNUwB2HtpXl7mj3Ix2U2a0 jS8V0txrpKid5e95ySV4QcFBGChZbTNs3ulPpaVkFU9xpgPl54H0Ui663zZWWh0NFJl7h4GFXfRG lrtq68x22yQGWd3JceGsHu4+Aup15tLqvRlnZcrvTQupS7oc+nk9To+ruOAtY3TGWO+nY7abuzWa ucK2QmMnIOV2OvN84qqzup6B49Rw/wAIx3VedF6Vu+rbwy3WWAzTuBJcThrB7uPhdDrjazVejrbH cL1RsFI53QZIZPUDT/xY7BXl8nH4d3tdvBLaKxzK6QmNxyCTkLrdwN74qizuht7x1v79Ix3Vd9H6 Xu2q7wy22OmM9SQXE5w1oHknwt7rfbTVOj7bFXXyiEdLI7o62PDw0/XHZOScYkba/eB9oqHR10p9 M5IJPC6jcLe6KptBp7bI3rf36eO/uq7aO0xeNV3dtusVK6oqcFx5w1oAzyTwFuNbbd6n0hRQ1d+o DDTyu6Gva8PAP1x2TkvFKO1e8LrXK+G4S5YckEng/ddJuNvVDUWc09ulb1PGD0cBVx0hpm76qvDb fYaV9RVEFxAOA0AeSeAtprXQeptJU0M1/t76eGZxa1/UHDP3HZORxS7tZvGba51PcZPkPILjwfuu g3G3rgqLQaa2yMJe3B9M8KuGkNN3fVF1FBYaV9TU9JcQDgAAZ5J4C92sdG6k0n6P9obbNSNmyI3k hzTj6jhNmkz7Ubx/gGSU9zkAHcdR4K3W4281PNZ/wlse0dQwQzgYVb9Kaeu+pbl+BsVI+qqcFxa0 44H1K9er9J6h0tJDHqG3z0ZmBMZfgtdj2I4TcTinPareNlHDJS3N46ecdR4K2m4+8dLJZhR2pzGg tx0xcAKtumLDdtQ15o7HSS1dSGlxZH3wF69U6Xv2mZIY9QW+oonTDqj9QcOA+oTkutp62p3hipqa Wkuj2luDw88HPC9u5e71I6ziitRYyPp6eiPgY8KBIdv9Xm2R3OGxVrqOSL1mysbkFmM9WO/ZcrLL JIfnJ48KzLXbPHfS0G1e79NFb5aK6ua5vPyvPDgeF6Nzd3KX+EsobSWRxluOiPgAKAItC6sbbG3F tir/AMGY/VErY8gtxnPvjC5eWd7zhxypL8nH4Wl2t3fpDa5aG8FjgG4LHnh2eD/JZ7mbs0wtUdFZ yyOPp6QyM8DHZVftkFXW1cVNQxSTVEh6WRsGS4+wXr1BbrrZqltNeaOpo6hzQ9sc7CwlucZwVeWu y47Wc2x3aoqmzy0N66Hjp6SyQ8Oz3Xz3Q3XpWWyOgtJZHGAAGsOQMKqkdTIzkEg+4Kzlq5JMdRJ+ 5U33tritlttuxbq+ySUN86JGhvSY5CMOz918t0d1qSO3x0Vqc1sYAAa05HCqlDVSRuyHYP0Kzmq5 JTl7iT905fJcVuNvN0rXdbDJQ3volYG9Lo5Dwec+V491d1KVlC2itT2tjAA6Q7Pb6qs1ttl5qKb8 XQ2+vmpycerFC5zTj6gYRcqS508bJbhS1MDJDhrpo3MDiPAJHKbhqrV6C3OtN80+aG/BkrAAHMee +Dla/dfdOmjohRWt7RE0DgH2VZrfQ3eSH8RRUVbJAe0kULnN/cDC+dxiro2tfWw1DGvOGulY5oJ+ mQrLJUuNq2OiNyrNqPTP4O/BkrQGgscecg5/0C028m6FMbY+3Wt4Mbm9JAP6Kstu/HPL/wADHUPL OXGFrndP3x2XxramaV7hMXdbeCHZBH3U3JdxeO5qvNWSdc7vqcr62qqdRXCnqYjiSGRkrfu05C8R OSSUgefqs+2vS6elNfWDWmlWU+oGiRzenqbn5g4HPdavdXculp4o6C2vb6LCCQ36HsqqW+vqKf8A 3Ej2Z4PSSs6mtmndmWQk+claxsnbGWPLpcSx6x07rbTMMF9DZHMLc9urqHOc+Fpd09yqSkhhoLYW CCNzThvGQD2wqs0dzqKXIhmcwecHCVbX1FV80khf9yrMpLtLjbNLiWvVGndc6Zp2Xp4MsbmkOGOr qH+i0u5u5FHQR09Ba+gQRPa4NZgDDTkcKrNDd6mkyIpyweQDhYVtxnqn9ckhcffKu4cauVQ6g07r rTtK+7SASxPaQ4d8jkg/Q9iFotzNyKO3GloLYWCGB7XANGB8p44VWaC91lCOmGodG0nOAcBfK4XO orH+pJIXOPnOVJZC41c2kvWndcWKiqLjMGzQvaeodzjBIPuD2IWh3I3DobY+kobd0ejTyNcA36Hj 7KrVtvtdQt6IKhzBnPT1YC+FfdKmslL5nlxPdxKssiaq50Vy07rq0UNVcZWtkhc3JB5cOMg/Q+y0 G4u4VFa5KKit/T6VNI1zQDkcdv2VW7XqG4UEZjp6h7Gd8B2F57ldqmskMk0hc73ykslXtc41Vg11 a7fWVkzWPie3q+bHWOMtP0K0W4G4NBaKmgpKEtMVI9pGDnGOAquWnU1xoIfSp6l7GZz054Xkud4q ayYySvLnHzlJo7i5s5sOuaO2XGoqGsMTh6jerAlbjlp+mStLr3X9Baa630tH0uZSyAjnPYYGP0VX LPqy5W6D0oKl7WdwAV4rre6msl9WaRznnuSkkXdXJqqax63itl0fVCMxOHqs6sCVo/wn9TlanXev qC019tgpix4pJAe/HbHf7Kr9l1jc7dT+jBUSNYDkAHstbdr7U1s5fI9xcfcp0m7PS51fQWfW7Lbc 21xiDMCVgfgStx+XPjnBytTrbXVvtNztUMRbI2klDjk/8PT3+yq9Y9a3S2UwhiqJBGDkDPZa263+ prqgyyyFxJzyVJJF5Vce5We06ynt12hrnRRgj8RGH49VgBIb9MHBWt1nrm3Wy+WiJrg9tLL1OPn8 pb/qqx2LXdzttMIIZ3dDe3GcLU3fUFVXVBmkkLnk5JJWrd+6zJJ6XHvFiodXVlvulLWuZTvwKljX gdbACWge3OFrdYaxtttv9mj6+ptHLlx+7en/AFVZrFuDdbbSNgjnd0M7A84+y0141JVV9SZpJHOc TypLq7rV9aW/v2nINV3a33SirS2jfgVLGvAJa3Jbj9cLyau1dbqDUtmY6QFtLKeonvy0j/VVssW4 1zt9GyATEtZkNzk8LR3nVFTcaszTSEvPuVqZ/bn+OT1/2uBqDT39pbtRXK3VuKKYBtW1rhnpby0j 9eMLX6s1TbqPVdkDn5FLIeo5x3aQq6WLcy6W+jjg9UuawYBPcBc9etU1NfWmZ8hdIeck9lMeu2ss eUkW21Npme/3qkuFtrS2gqQ1tVjGQ1uS0j35wCvlqjU9upNU2QPkB/DSOBII8twq7WLdK6UFFFA6 QuEY6Wkrmb1qmpuFaZpZC5+er7FamX2x+OT0trqnTtbe7zTVdtqw23VgAqSOS0N5aceeeFxPxC3i jms7KJkgdLFnkHuotsO69yoaCOB8pf6YIb1OPAwuJ1Xqae71D3yPJLjnurhnxu1z8fPpzNWeqV5P uvITlfWQk9zlfI9l53oY+UFHlCBeUZTPdHhAJfzRlPwgEI8IQCSaEC7o8ppIA90JpIDumkgIAHKC hNAihBHKECQO6Z/RCA/RMJJnsqDCxWSXsgEeeE0FAvKMoPCCgOMplY/yTHdAj2yjynlJADCAj2Qe +EARyjHKPKMIEe6aXkpFA/P3QUd/qmVRihGOUY5QCf6IQgQ7+6WAn5QECzhLymUY4QJHlLysvCBD CSaAiUBB7I8IQJCD5R4CA7oAQslRj2P0R0/UpowfdUbJ5yvBXHJGF7Se+V4Ks/MF5Mfbtk+YJERX jXsyPw5C8Y7rpGKTspLJywK0yPKaSaAymEkwg+0LQSrMfDY1rHF2QAD5VZoTgjnGeyknb7Vktknj LZMMB5VHW/ERHPDuP6743iCamibG/p4cWg5AKmHY23VMNgbX10rmtLfla7gAYXCat3BseobLBSVV JFPURuDmyyHJjPGSP2Wwve69vbpEW22jpnLWt6gfyjKWbTbtN57Y68aO/F0lRMfwrutsUQyJMkA5 HPbGVttqSI9Gl54LWgn9AVw2lNzLXRWB1PUH1Znt5y7HcLb2LcLT1uszKKGLpaRh49Tl33/dNU3G hul7rNfXq1NstK98NtEr6mYnDcHHGffjspN1Dc/4VoeCsBwI3RfzcuRt2u9LWa3y0drpIqaKQOJb G7AJI7lczuJuHa7ho2OzURzM98eXE9g05V1U2mNlzbdNL1tU3/5Xkz9T0EqoO1r3P1TA3ktz2/VT XRbj2e06IqKZzuud0DmNHV3JaR/quF2Rm07YHPul4Pq1v+AOOGsH28lNdaTaR/iNb07RPB4PXAPr 3VPHfmUt73bjy6tq30kDum3xu+Vg7HHYqIwSTyrvqRMMZLf6CkglInnClbGco8oQoG0LIeFiFl2V ErbBQg6nzgZDQrUa5NBFNYJLm1joWvf0teMgu6BjhU/2tvrLJdxK49PV8uVaWj1HY9Q2WOO+OBEZ DmnjqB4/6KaL6dI7nRsfpjALwWgdsF4Xw12KCOssRufQYgZi1rxkF3S3HC4PWe6FBDX01qtrgykj xkjAyV08N8seorREy+yNJhIezGC4Hgnn9FdVnbfOGdI02OGuewjHsZAvPrptB/FLMLn0mICo6GuH Bf0jC4fV251BHcae1W1zRSxEZI47dgunZdbJqS2wm9PZ1QubIw93A5BPPjOMJpL23rmf/CtRccF8 WP8Axrxa3joXXu1/xMsMXRP0Md2LukYXG6r3NoG3iC1297GU8TgcjsSDkLpn3Cy6ko6eW7ysa6B4 kaf8XuRnwCliT23hi/8AhZt/GSHQ+P8AiWn1vBRSamonXBzS1sEpjY493ZH81zOqtzaBl5htdvex sETgcjsSOy6Keay6mjo6u6TNikpyCCCeo85I745Vw/W2mc5SN3LHm32g+74ARj6lavWsNFPqSmNc 4fJSPMTCcBzsnB/Rc3qPcqgGoILbQPYIoCCPqR2XR1hs2pjRV9dUCCSnxyCSSO5H6rOUt0uEkjbV bQKOy9WPzwg8fdaTWNPRzataa+TpEdGXRM6iMuycLS6h3Gt/8fgttG5no07gW+ckdlv6+Ky6llor lW1AgngIBw45c0c49hlax/XSZTbdVbB+HsryBkSRNP2xlaPVlJSVOq3vr5S0w0fVAwOx1Oyecfst NfNxreNQw2+jeww0xHTk5yRwugrqazahqKG6VNSIJoeH4dy5vt9Fmy1rHUbisGW2HI4dIwE/oue1 TTU9Rq2okrJSDDSNdBH1kAuyecefC1l43Dt51HDb6R7DHSkEZOeRwt7W0Fqv1woLvNVCB8Q6ZG9X L2+B9OVZNJ8tzWAGaxBzRhzx/wCULnNTUsNRqyrlqZiHQUkboY+vGXEnJx58LwXXcG3u1NT0FJJG WUvLST3PZbqutdqvV0obzJVCExjplZ1462gcDH3U0Vu6hjX1VjBA5JP7MC5nUdJHUaqraiaZzTBT QmGLqwC4k5OPPheS5a+tztTwUdM9hFLnBz3yMLcVtptl4u9Fe3VfohjeiaMyY62gfKAPurobqrY1 1fZMgDl38mBcrfKRs+pbhVSzvDqeKD0Y+rAJJOePKwr9e25+p4aSmexwpM+e5IwVtKqzW66XikvY q/Qa0ETRl4+cAfLx45V1qMZTeUrdVkbXXe0fL2Mnj/hC5W70zp9TV1XJM8fh2wiGMOwDk4Jx9kVW vLdLqmCmp3scKbPn3GD/AEWwq7JRXHUFLfG1rooekieIvGHY/LgfdZ17bx603VdEz+P2o9IyPVA4 /wCELkayklfqm41klQ/EMkTYogcDkjJP7r6VOu7fPquGCF7HCnDufOTwvfPYaWr1RDfGVpZTluZo 3PABI/LgLd7xscssd5Y2fDdVDGf2moOpo6umQg+3AXL1tNI7U9wrHVL/AO5mijihBwB1EZJCzdrW 2z6rZFE9jjACMg4Jz3XslsMFRqll6jrC2je3rmjc4clv5cKR0nWm3qoo26uoT0Dq9GTnH2XKyUkx 1Xcq11Q8CKpYxkQPGDgHK9B1pbajVzWxva70GlgOfB8r0nTgfq3+MxVxFDI31JWOcMdQ7YVt6s/j Ex7iD/jKjHrWYgeHlVdI5CsL8VeqaO+XakpaN4caXqBI9iq+tIyOMrXls1jJ9L/j43GXf2td8H1n p4qKruHptNTI5zS8jnA7BStFTVLtR1dfJVP6G1ohjhHYNOMkqKvhZv1JQ2R1PI9okL3AjPbJUxRa emGq5bp+NH8NePWLSez85wAuOnat06ngdrRkvQPVbSn5sc/mXNU9NWO1BU10lU8x/jjC2HHAb75X pptWW6p1ZL6T25Yz0iQfr3WcFgqWatnuLqz/ANFuaJgDjh+ScD6K6TbbClpzrZ8/pt9VtIB1Y5/M VztDBVv1LNVzVTjGa10LIscdORzleyh1TbarVdR6cjSQwQ56sjg90Udhq4NX1Nwmreq1kCoZnsH5 OQB7D3SM1tG0kA1rUTNiaJRSMBdjnHUVorZDWu1K+rnqXOhkrXwMix2aPOV6rfqe3Veqqr05R/u2 w5z2wSc/zTt9jrqXV1XXVNZ1WkYqI+MDrJORjPjjlNE9thFQU7da1tSyJgl/CRguxz+YrQ2OG4HU BraqrL4JaySBsOPytHYk/wCi2Ft1Jb6vVNYI5W4MbYs58gk5/mvjaLDcqHVdVV1laJLQ3/aIsjAD 3ZyMZ8e/1WvHJMbKmfeUrY0dvpo9aXCpjiY2Z1LHlwAyfmK02nm3A35lZVVQfBUVEsLYenlrW9iT 5+y91q1BbqzVFaIpm8xtizn/ACkn/VfGyWO527U1XU19a2S0R/30LsYHU7OR38DypnP1uvZ49TL+ ae23Wqkg1rdKqKCNtQ+miy8NAOMlarSTLkbtHWV9UHw1cs0bIQ3lrW5wSfPZbC0X231mpq4wzD5o 2xZzxlpP/VeTTdmutt1HWz3Ora+1wZkgcR0jLs5A58LrL+tjF/2le+yWmgpdY3mqp6aKOofDGHPa 0A+VrtJfxN1yiqrhUtfHVvla2EN/K1ucEnPK9un71b6vUdyMMwzIGs5I7t4Xm01abpbtRV0t0qGu ttPl8DyMA9Q5x9ljLuWR0w1NPXp2zUFJrC+VlNSwsqXsja6RrADjGf8AVa/R77obtHPcKhr4awyB kQHIDScEnz2Wy07ebfWXy5up5m9UpaBk/wCUYWu0ra7xb77WSXmVgoKQkwOxw4OB7fbKtu9pJ6e/ Ttmt9DqjUFZTUsMdS8MDpGsAdjpz3/VeDRsl1/i0T7jMySnrY3uY1oORgnv+i2enbvRV93uop5R1 TluMn2GFrdHW68UF2rHXt7BSUZLYHdgWu9isZd1uXp7dN2K223UWoq2jo4Yqlzm9UjWAH8ue68Oi pro+6RuuT2PgrYTKwNyTjJHzfVbTTt1o6+vuzaeZpdO8FuT/AMOMLXaLoLzQ3KrffDG2loy6OBwy AWnnIz4U0j76UsNstN51JXUNJDFUPl5e1oB/LlefRE10fcG/xMxOhrYDOzpJPGcYOfOFsdNXGjrq m7sppml08hc3P2wvBoiivFHV1ct8dGynpC6CEjjLO+R9FKu310jp21We5akrrfRwxVEk7svawA4D Rx9l8tDzXOasxdPSdDWU/wCIYGnOQTgh2fK2Omq+lrX3eOmla580rntBPuMLX6EpbtS1FbNfPTjh pOqnhPbLBzkfRNIWj9OWuw1Go6220cMM8lTI4uY0A8N7fZLQtRcqmd8d2EZjq6f8Q1rTngnBBz5W 009W01fFdoqWVr3zSve0ZxkEYC1mgqe608tbPfGRwxUvVTRc92twc/ZXXSZd18tH6btWm2akuFso oIKh1RK4vYwA8DOPtlZ6Hqa24mqpryyNzKiBtR0DkEO7g58rZ2Wpp7jb7xBRytfJNJK5ozjIcMBa 3QEV1idcKq/QspxATTsPbqa3HP2Vxkk/plbb/Hk0fpu16Vteo661UcMNQZ5nFzWgHDRkD7L06Nmr bnDV0d9hjLJ4Gz9A5BDz59l7bZMy42K8wUMjJJ5nyuY3PHzDAXj0ELq2OurL9AKb0W/h2ZGC5rec /b2Plbyn6/3blbbnZ8aUe3atkFp1/eqSlYI4GVDuloGAAuPaMuwu93slZPuHeJIyHNdOSCPK4SIf 3g+6vn/3unXxW3CbXg2OsVJpTZ03Whp2fxGeF08kpHzOOOBn2XZ6aFVerdcLbqOlidHNE2R0TiHB zX57rV7dtFds/S0dCWyVH4QAMz5IC2ugqi4TU9dcr1B+F6QIADx8rPP81mX9P/aX/etTobTVs0Po u7VllpGMqHvkd1Y5dh2Gj7BbixMmv1tudr1HRxmN8bXOhcQ4Frxlfamb+P0XW01CWyz5e4NB935C +OhK2sqaOuu15gFJn+6weOGecfqpfbfw0midNWrQuirjX2WjZHUyFxLu5dh2AFubLEdS2a62nUdE wsADZIXgEYcMr7tZ+O0NUU9F0zTgucGA9z6nVj9l89C1lVVW2uvF0g/CCbgB3HDcjOPCX2m+2j0T pm2aA0FWV1lpGCrky4vPJf8APhoz+q3FtpG6r05dLRqahHSz+7kik5PIyDler0zW6CfBRgTzMAd0 A98P6sfssNEVtTWWevvF0ibS/iTkZPcAEZ+izW9uc0Vpi27e7fz11npWmtlblzzy55LsD+q29HQw az0nc7VqSg4jcYXxyD5muxkEH9l7po31m34io2iaeNjHdGfLXBxH7BY6IrZ6mx3C7XOEUn4t5kAc fAGM/RGL7c5orTVt2728fV2mmDquRoc57uXPcXADn9Vt3Wum1vpG5WvUlIH+g8xOB/M14aCCD75I Xtq43VW30baVnryQsjcY29z0uBI/YI0TVy1Nhr7rXwfhG1khmAdx8vTgH+Szd7mmtuX0jY6Dbrbl lXaqRr6qVrC5x5c9znY7/qtpV2mk15oq4UGo6PqfA90ZDvzse0Agg+Dk+F7ri18u31I6mi/EPpxF I6NvJ+UgkfsF9NFVj6vTdddayE0rK2R07Q/j5S0DP64XWScZ9uOVtytczpCx27bfbeKrtdJ6lVM1 rnvPLnuccd17rpaKLXuhquC/0eZ6RzmfN+dr2gHv+q2V1Dv+z+glhidUfhvSlexnJIackJ6QqDU6 Pr7lURfh2Vr5J2h5xwWgA/rhXU66Msst5NftbM+87aGOR3ytElKzq7BrR0qrW6+1900RVw1sxZU2 2pd1NniB6WEn8rv+qszs+TFtTVOHBEtSf5lfewzM1TtTVvuUUdQ0iZjWvaCB0jA7plj/AOE9bXLO Y5XK/TPa+sk1LtPGZHAepE+nbns0AdP7KqO6m2d20RVQy1oZNRVPzMqIQekEk/KfqrQbQt/AbNS+ l/7MVGP0yvtA2LV+0dY66RMnAZK1nUM9PSMAhZ8ONmMwv2nmzkzyyn0jz4W9O6dgtcd3qsS3yokc xgfg+m0HAx7HgrWfGDSMfebNL0jr/Dlucc46iuc+Hqpkh3Jt9AJCY8yEszwMA4K7n4pGCXUdgaW5 BYB+8mFMLrPLG/EdM/WFnyirS2x2q9R2SO5xNpKOGQ/I2re5jnDAIdjB4K8Wt9ndU6Qs4udfHT1F J1dL3Ury/wBP6u44CtNuxc5bDt9Q1FGelzCxo+3ThRhT7g3W7aKnpH2+qko5cwS1PpExcnBHVjHk LOP7SZVbdXURXpDZvU2q7DFdbc6iZSykhomm6XHBx2wVp9XaBvGirvR02oqdrYpnNc2WM9UbxnkZ x3x4VwaC2WvQej7XTzxvqGOcGNJOCCRnx9VzfxP0LazQ1B6ceZBUs6B5BIx3W8MeVTLLidDryz2m xW63aYga15wGwQt6urj2H7roNw7JQ3/bsjVEELar/eR5xljsg8EecLm9p9BUu39oF81HJHJc3t/u 25y2Ljs0+5B5XA7v67uV5ilko4aj+HMd0GZsbiwc47jjOSs49rbpJMWtLTYtP0lLpmjxDC35mQxm QMH1x25Xt11Y7fr3axtZXQMbVmP1YZQ3Do3F2P6eFCu1Gt6nRQrWXGkqGCreCySWJwBwORzj3VhL xUi+7cQ3PqIc5rJW9JwOXgcj7LU1ykXd9xpLJYLLtXpuGOlgD62pw18xbkyOHOSPt7Lkt+dAWrUu kn6ys7W09wjjEry1vFQzOMH6jwVJmvrhS2qusldX/wDq0RlzxkZMZAH81rr4GO2UqA0YaaR3SD4G eFrHCbxn243yXWd+lE5W9DyCOV6rPQvuV0pKKIhslRK2Frj2BccZWNwaPXdjwSFuNANzrSxg/wDy 9B/5wsZTVsjtjdyVbm0acsG1elaakkjhnqpnAyTSsDhI/wAnB7cLjt69rqG+wUup9NllNLVvjbMz p+V4cQA7A9lKe4dVQ0dxts906fwzYph8zQQSW4A5+5XyqGj/ALNLQGctzB0/brGF04zp55llblPp pLTpfTu2Wl6WjqYIKmedwdLJPGHB7+xdg9uFwu8+09HdDSak0qI4GV0sbZ4cYaes4D2jx9QpY3Cq qCkuNHJdhGYBTTAB7QQXEY7H7pOaP+zvT7Ry3rpf26gpwnTfPd052z6R0xtvpuko66np6qqqHNdL JUsDw9/AJGewx4XCbx7P09bV0t/0iYqenuEjGzU5GGNc44D2gdh7hTFrua2wXSB94ERg/CStYJGh w6zwMA+UNjH9iNNt7j1aYfp1KcfTc9uVtGh9I6B01Q0l2oaSsrJ3NdK+qa1/U84DiMjt9FH+8mz0 UlfQ3nSDYoaW4ysjlpwMMjc84Dmgdh7hTRr19rbdW/xoQmL8DII/VbkB5OMj6r7TYdpTTPYgzUw/ TIWZ21Ju6cZZtvdH6L05b6O+W+jrbhM4PlkqGhxLzgHBPgeyj/dzZgi8Udy0iyMUVyla0wk9LYnu 7EY7N+imnX7bbJcpGXcsEYoHOiLv8LuvuPYr2VfNh0wBzmWn/otSbTHVuq4aybZ6P0npyho9RUFH XV0zw+SSYAkEgAgHyBg8KON19l5qO+UdVpNrZLddJQxkRPSIHu5H/dwpz3Agt09fOy69HSLeXQl3 dr+vuPqtjcz/AOi9MDGcyw/+ULMaxkt1Ue6f2q0dpmwUlDqWjp7hXVD/AFHyTcOYSBkAjGQCOFG2 52ylTa9Q0btLj8Ra7lKGRMceYHHJ6SfLcdipz19TW+outSLmQ0R27rgcXFpbJ1kAj+S3Fxb1QaXH fM0ZJ/8AoatmnPC8r2jrTu0ekNP2empNSU8ddXzu6jJIekty0EgY8A5UZbmbMV1n1JSx6bH4q23K TpgaTgwuIz0k+W47FTxuFSUVVdJ/x7g30aD1IXdRaWv6sAj69gt7cIw5umA4ZPrNJP2jUxvrbpjJ ZtGmndm9H2S1UlLqSIVtxmdl0rnlnTkZxgHsDwot3F2cuVm1PT01iaayhr34pjnHQe/ST9B5U6bg 0UVZf6gTOLHQ0bZIn9fT0vLiM/yA/VdVcGepNpnr5d62ST/87K3njxk79xw8dvkm/qot07srpK22 uip9SMkqbnMfmlZK5gBIzjGcYCinXu0F5sWqae32mN1dTV0nTSSA4x56XH6BWE1/RQ1l4rHTSvik paNksDmv6cP6v59sLf3JvXXaVLgC71jz/wDQisYzvV+nXj+sv9Rdp7ZLSlFbKKj1I6ae7zZDpYpn MbkjI+XwB2UTa12nvmn9URWmkifXQVj8UczBw4d8O9iB3+ysLragZW6gulQ6eSKegp4pKfpfgdRd g5HnI4XTXlvXfdLFwBxO85/+hFdLhqyT6efx5W47v2i2wbE6cpLXR0+oZ6l90myHSQTFrckZBx4/ XKh3We19809qmO0RwyVjKqTFJPG0kSDvg+xA7qy2uqFtXdblVetJHUUEEMkHS7AyXAHI88cLdXpn VqXSrnAEiV/7+mVnHHd1XXO8cZf6iix7EWGGhoqe/V9SbpMC13oyAN6sZGOOP1yoh1ftvetPaobZ vw8tW+d+KSSJpImH+hA7qymuqI1F8r6qOplimoGwvjY0/Keo4dkfZdFfY2nVel3kfMJJMf8A4Mrd 8cmu3LHyW7/7RDa9gbQKCgivF3rIrrO0tcyJzTH14J44yP1z2UQap29vtg1R/BJKaSonldinfG0k St9/08qzevKOae91lZBUyxTUHpPjYBlrg4gOB9uPK6K+RtfrDTEjgOpplAP/AHFOGtdtfk/+6GrV sBRm3UEd0vVTT3SdpD42Na5nXycDjPb7qH9T6GvVh1I6zVVLJJVOd0w+m0kTDPdv+vsrP66hqn3q srqarkidb3RuZEBlrw4gOz7d+66m+QRTat03LJG0yj1QHEcgdKuWGtJh5OW4hC0fD42W10Yud6ko 7pNGS+FsbZGB/PGeD2woU1npa56WvE9tu0JjnjPDh+WRvhzT5CtvreKudc62vpK0xC3ujIh6ciQO IB5zx3XMfE7QQ1Njt0z2D12dRD8c4PhMPHcrprPycJuqkn2XzPlfedvRM4exXwI7ri7l4SR4QUB3 QgIQCaSWUDKPCAj7IBHlH0QgSB7oKYQLyhGEIBCEIA9kdihCAQOyMcI8oBBQhAI7IQeyoaO6x+yy B5QHhAQhAvKOxR5QfqgR5KaSeMd0C7FMpeUIDklGOT9U8cJHugeOEs+yfhIhAgn90wPql5QB8ISP dHnKoY7pFBKOfCBYQnjul5QNIDGUBHdAgUFACeAgxWQ7JEIAwgX1QgphELshCD2QIpo7oCA7eEE9 keU8cqhFCaOVR7HPBcOQvJWjD8KU7bSWeipg0UML3Y5fIOo/zUZ6jc196qnRtDY+r5WjgALx43dd svTwuOIl5fK9j+IHcLxjOV2xYoPZYeVm7ssSqyEYQEBAJjul91kgyacL1xSPaMtJC8zBnjOFMuw2 39Jqa6Csu3z0sB6hDjh5HPP0VSo9bary22m4m3Vrbf3/ABHou9PHb82MJPtt3ZQivkoK5tEcYqHQ OEfsPmxhWC3d1ZG24M0tTxtit0HQZo28B4GCBj2XfNtNLrfbiS0lxgp5I2hojIyC3kcfcK3c6rMu 5uKg0NPdKqOSSjpayeOM/O+KJzw37kDheuCivc0LZobfcpInch7KaQg/qAraNpaPbjbmSLDHuwGF vYPc7I7eVvNF1UsmiXVIJEkUR6GjgcNJAx9wps0pc+hvjGOc+3XNrGjJc6mkAA+vC8M0de2AVL4K oQnGJXRODOe3JGFdSC/Sm0upr/8A3FXU07nsYXZLgRjt4WxuelqC/aRgtVwhY6nfA3DSOGuxwR9Q rs0oxEK2ojfJHDUSxsGXOYxxa3HuQMBfKKapmd6ULZZHYz0xtLjj9FdWHTlPpzbi8W+GONrI6SfH SAOoemeThQ/sJdqG0OEQhi9abAc8NHU79U2TtX6YuL3NeHBwOCHcHK+PurB/EnoOgtsbNTUP9zJV SBssQbw9zueolV8IWtXWyZS7kPyscLLwsc8rLQTAS4KfZA8J555STHdB9YpHMcC0kYW9g1HXRRem KpwGMYLsLz6U0/W6lu8FvoGAyyuwXO7MHuVbKzaF0pt5YKWCvoqaur6ogPmqYg/qIxnGRwOU2zYq PJWzSS9fqFzjyTnK2TNSV8UQjbVPaMYx1YU97qbPRXl1Jd9LMp6QzODJYukMYQSAC0AYyOfuuqs+ 32kdCWWlp7tQUtwrqlwD5aqIPLiO+M9gMptFSX18r5vU9RxdnJOVtotV3JkJiFW8NIx3wpw3W2ab dKukuuk2QU0dQ4MlhIDGNBwGuaAPvlddaNt9H6JtNNS3ahpLhXVBHXLUxB5J84z2H2SXa2KmSXGd 0/qOe4uJyXZ5ytzHq25shEYqnhmMd+Spj3S2T/FXSmr9Ithhp6t4bJAflZGT2LAPHfhdva9s9GaP tVLR3ihpLhXzY9SWpYHEnzj2Cb0km/Sp8lynNQZXSEvznqzytzFrK6tg9NtS4NxjBKljdDZGWS9Q VmkWRMo6x7Q6FxDWxE9i36fRdzadqdFaWtdHRXyip7hcJcGSWcHOT3xz2SZLxVUdc6g1AmdI8yZz 1Z5C38Wtrw2H021RAx+qkvcnY+rbqKCTSbI/wFa8D03EBsRJ8ecKQrXtLonTduo6G90cFwuL8GWa bOST7c9k2aVVfd6ptYZjK4yk9XVnldAzXl4bTmITnpx39lIO5Gx1dBqWA6WjY+3Vz/kDjgQk+PfA Cka07PaJsNsoqG+UsdwuTsGSaRzm8n2weybpYqybxVfi/wAR6zzLnPVnldG3X95/DGJs+BjGQOV2 m4eyNzpdVwxabibLba92YiTgQk89PfOAFJlo2X0VZLdR0N8gFfc38yzPkc3k+wB7JuppV1l7rWVw qRK/1c56s8krp3bj3htKYfWIBGMjupNqNkrda9dMfcA+fTtQcwRMPSeo89BOc4Axz9V5/iD2zsGl tJ2+t07bnQTyT9MhD3P+Tpz5+qbXSEWX+rZXirbK/wBbq6urK6s7mXo0piEuBjuO6jssc3PV7+Qp 12U2Sl1NCLvqdkkNsI/uoAS10v1J8BORqImj1BWxV/4v1XibqzkldW/dK8Oo/RbIBxjIXy3y0vbt Ja5kttmifFRinZJ0ucXHqOc8ldlsrshLqaIXbVDZYLW4f3ULT0vl+pPgJleHVTHWU3EUwairoLh+ LbK/1i7qzldbJupeX0hhDunjHUCV6tc7aOO6R01pGlkERYw/O4uDM93EnwpetuwWkqa3wUd1nqJ7 q9pLpWS9I6v+X2W8t4+2JljlJYrVTamroLl+MbM/1s5JJ7rr5d2by6iMLXBvGM5K62w7HxU2uJKH UsszrUciAwHpMpP1PstX8QW29l0LS2x1jZUNdM94lMshfkADCk3bqNXLGa38o2o9U19PdPxjZn+t 1ZJz3XZz7vXd9CYGuDSW4yCVEz2kcg/qgZcR8wGPqs8muLqKLVtwproKxsr/AFQckk9121RvDd5K F0LSGHpx1ZWh2k25rtf35lNG4wUEZDqif2b7N+qnV+w+hhcHUP8AELp67T0lokbnP7JMjSutv1hc aS6/jWTP9TOTk912lZvHdZqB0MWWHp6erK6St+Hmt/t6220dVizu/vPWecyNYDyO2MrrXbBaK/Hm hF2uhqGnpLeppOf2TZJFVbtXTV9VJLO8ve85Lie68CkXebb6XQGozSeqZaOYF9O5x+bpzj5lHRUs s9tSy+nR6R1JV2CtbUUry3B+YZ4Kk+u3quM9vMMQc15bjPUos0Zpe6asvcFss1OZqiQ8n/Cwe7j4 CsZL8NVtbbhE2+VRu7YepzA1pYX47e+MpKlQhZ9c3G33f8Z6pc4nJBPddzc967jPbnQxdTHlvTkn hcNT7balm1g7TrKB/wCPa7pc4ghgGfzZ9lNk3w1UTbaY2X2pfdmw9RYGN9Prx298Z+qvJNRCti13 cbZd/wAYJS9zjlwJ7rvbnvbXVFtdDEHNcW9IOVH1HtzqSr1c7TsVA8XBjul5IIa1ucdWfZTTWfDV DFaniG+yy3VkPWYfTaG9WO32z9Ul2l1PaHbBr64Wy6/i/Vc8uOXAngrvbvvdXVVtdBEXNcW4z1KN rXoDUFx1YdP09E7+INf0vyCGsGfzE+yme4/DV6NomNLfJKi6RxB/oeiA0ux2znsrbq6pqWb+EU6c 3AuFruxq/Uc/qdlwJ7rvbzvhW1FsdBD1B5b08u4UYWXQV/uurDp+monfxBrsSZBDWN/zE+ymS8fD XPS2WeWivRqrnFF1/hhCGgu9gcq7vo61tF+m9wrhbLu6rMjndTsuBPBXe3rfGsq7U+ng9UOc3HJ4 UVWHQ98veqhYaKkf+PDumQOGGxgd3E+ymG9fDXX0dkqZ7fehW3KKMPFJ6AYHH26upS5a6pJLNxHW l9xa+1Xd1S+Rzw52XDK72+76VVXaZKaAyNc5uOXKJNN6Lvd/1OyxUNG/8f1FsjXDAjA7ud9Apg1B 8NtyoLJU1FtvDK+4QtDvwgg6Or3Ad1f6Jump7cDpTcautF1dUSPc5r3dTgSu81DvnVVlpkp6f1A5 7ekknhRBpTRl51NqNlmttI81hfiTrBAiAPJd9lLeofhuutuslXV2+7xXCtgAd+FZB0l3v83V7fRO S6ji9Jbk1toupqJHuexzsuBK7zUu+lTWWh9PTvkBe3HJXKbZbJ3LWtHVTy3GK2Pif0NikiL3Ox3J GRhcLuFpep0dqars1TM2okgx/esaQHZGVZu9p1vTr9Gbm1lnupmme58b3ZPPYrutT76z1lqkpqZ0 he9uMkqENE6Wumrr9Ba7NCZZ5COpx/LG3y4/RSxqv4eL7ZrJV11JcILlNTgE08MRDiPPJPgKcjTn 9FbnVlnuhlme58bj1HnsV3Wqt9pqu0Pp6V7y94xyVXelo6mprY6aCJ76iR4jbGBlxcTjGFOdJ8Nu opbXHUVFzo4al8Pq/hRGS4HGeknjlTkvFz2ht0KyzXR0tQ5zo3nqPPYruNWb7S1lokp6R7y94xyu T0bsDqPUNDUVE1VTW58MzoXRTNJdx3P2W6Hw13+R/TFfLXJ/yh2U2ajnNC7qVlmubpKl7nxuOTz2 K7rV++r6q0Pp6R7y94+2Fy9q+HfUlwNYW19vhFNO6A9Yd83T/iHHZemX4cNSDll4s7h/zuz/AE/1 SZGmq0DuxVWa4F9S9zo3Oz9iuz1nvq+stL6ekc/reMZ9lydm+HvVNziqpYqq3RtgqHQZe93z9OPm GB2/6L1yfDhqs8R19okI74ldn/yq7TUeHbzdiostwLqp7nRud1A+xXZ6230/G2t8FI9xe4Y9lXbU 1oqtPX2stVaW/iaWQxvLDkEj2WsMriMZz90t1e14ypv233bns1efxj3GMnOc9iuv19vka2zyQUTz 6jhgHthQ9txthqLXUNRUWmKKOmh4M1Q4sY93s0gHJXT3rYLWVutdRWvFvnbC3qMcMxe8/YYTaakR Fdq2SvrJJ5nl8jzkkrxtOHAr6VEMkEz4pmOjkYSHNcMEH2K+KzW4nPZzdebTjW0tZITCwfKc9l3G vt8G1dqdT0L/AJneW8eFXzQekrvrG8Mttjg9WYguc92Qxgxn5j4XQ662t1To22xV96pI/wAI93R6 sMnWGH/i9lZdJZtIW2G8MlrmfHXSHp5IJXRbh72x1lqNPQSDLu/Twq/aJ0reNX3cW+xU5nnwXOcT 0tYAPLvC3WudtNUaOoIq290bW0r3dIkikDw0/XHZa5JxSVtfvE+1SOir5D09wTyF0W4W9kdbaTT0 Egy7v08AqvejNK3nVl1/AWKldUVHSXHnpa0AeSeAttrbbzU+kKKGqv1CYaeV3S17Xh4B+uOynJOK Vdrt4zbC6C4SgDu0uPBW73H3qjq7UaaglGXjB6OFXrRmlbxq25mgsVKZ5w0uPPS0ADPJPAWw1toL UukIoZb9QGCKYlrXhweCfuOybXSX9rd4/wCHMfBcJMDuCTkFbrcfeiOqtP4a3yN+YYPRwFXXRumb xqm6fgbDSOqajpLiAcAADyTwvbrTRmotJOhbf6CSlbNnodkOaf1HCu00mza7eRtFE+nuEmB3HV2K 2O5O8sNRaTR217RkYIZwMKu2kNN3jVFyNFYaV9TUBpcQ04AA+pXp1jpHUGlJYYtQ2+WkMwzGXEFr sfUcKcouvhOu1m8LKWmkpri8EeA7kOyvXuRu/T1FpFFbXMazHSWx8D9lXbSmnLzqWtfS2Kilq52N 6nNZ4H6r66u0vfdMTxQ3+hno3yt6mdfIcM+4VmWu2bjvpYDazeGGnopKS5vBGD8r+Q7PdfXc7d2n ls4obUWxtLenojGAAq66X09edRVUlPYaGetmjb1ObEOwX11Rp6+adqY6e/UM9HLIzrY2UfmCTLV2 vH4WQ2f3Ntlt0SygrjEX9b3Pa89+onIWz1PutaKLTM1JZ46an6wcMhaABnvwFW2PQ2rY7SLmLJXC i9L1vVDeOjGer3xhcvNWSv46ifukvylnLpbHajcqz0WjG2+q9PIc8va88HqJyPsvZqzdKyUOlp6O 0R08HW0gRwgAc9+Aqtabs15vss0VloqiskiaHPELcloJwF87/brrZ6n8JeaSpo6gtDxHOwtJafPP hTlq7jVx37WG2W1XpWy2WCSelpP4p6skrqgtHqfMcYz3xgBdVrzW2lL3a5XVtNTzzsb/AHUhd8zD nIIP0Kp3HVPiPykD6r6Gvlc3D3k/qpL3v5LOtLh0W4mnb5pqGkvkUFWwDlkuMccdlr9Ubh2C16T/ AIZZIKeCmccGCLBb055GPCqrbPxtbUspaGOWeokOGxxjJd54C+l0huNvn/D3KmqKSYtDxHOxzCWn zg+OFep0nyuDQbi6cvlgpm3iOKp9PDwHux0uHZfDVGt9O33S34atcx8gka6J5cMsd1ZB/QcKqNst l8q6P8RQW64VFMSQJIYHuZkd+QMLGvp7tb42OuFHWUschLWGeJzA4jnAyOUli9rlXLW2lbtQRU9x jjqIgMhpkHBxhai/ao0rBoqqtdDDFFTFoayMO6gPmB8/UKqdFT3uqpfXpKKvmpznEkcL3N/cDC89 Y6508TBVRVMMbyQ0yMc0OPnv3SanSXdWyn1Lo/VlloRqGkgq3RDqb1EAtPb+i+es9fWS1aQZbLO1 jIGtDGxg56Wg5GP1VVKGO7TQh9LTVssWPzxRPc39wMLzV9RWxgMqWzRnnAkaW5/dWa3s7vS2+l9w bHqfTjaS/BswaWjpJAOQc5yua3p3Mp30D7bbJB6Rb0lo+2OVWSnuM0IPTIW574OFhV1sk/L3kpjn xu4mWHKar5VUgdK4j3yV6bLXG33SkrIvz08rZR92nK1xPzcozjn2XO93br6i6+ndb6f1ppSCG/AP LS0kZAd1DnutJuluXTUxgoLa5ohic1wa3jsqs2641FO3phlewHnDSU6ytmqH9Uz3OcfcnJXTHKRz uNq49q1Vp7WmmaaO+Fr5GOaerI6uocrQ7nbl0lC6mobaWehA9rulvAwO37FVcorrU0gxHM5je+A7 Cwq7hNVPL5JOo+ecpjZvaXGrkUGotPa307SG8PHqxPa5rgR1ZHfP0PkLQ7j7k0dBNSUVtLBBA9rg GcAY7ceFVqhvVVRDEVQ+NuewdgL5V1znqpC+SUvcfJOVek1Vz6S96e1rY6Ke6SATQPa4OHckYJB9 wfIXPbjbj0duno6S3logp5GuaG9uOyq1b79W0cfRDUvY3PhxAXyr7nUVT+qSUvd75yksnbWqudDd NO63tNDVXKRolhcCHA8u7ZB9weeFz24W41HbKqjpLeWiKme0t6fAHYqr1s1DX0MfRT1LmNznAdhe a4XSprJC+WQuPk5UljNlXPFZp/W9tt9bXytD4Xg8H84wMg/Qnwuf1/uLQWysoKagI9OkkBGOQMDA VXrVqe40EQZBVvYwHsHcLx3G71FXKXySF7jyTlJIdrnSSWHXFHbq+rlY18EjS5pdxIByWn6ZP7rR a83DoLXcLfT0nSWU0gI5zjAwCqvWjVlyt8IigqZGNHYArx3K8VFZMZJHknPJJzlXpO/hcyqhsWuI rZcp6gMdC4GRnVxK3H5T9M8/otLrvcGhtl0t0EDmubSSZznPjHdVgs+sbnboBDBUvDG9hla253qp rJzJLIXOPckqST21urmVlDZNafw66OqzH6ZHqxh2BK0DIaT455/RajWOvqC13e2QROaW0smc5z/h x/QqsVk1rdLdSiCCocGN5AytXdb5U1k5lmkcXE55KvV9p36npcy5W2z60NvuQrTE1pAmYHY9VgGQ 3PjnBytPrLXFutt6tMTC1zaWTqJJ89OP6FVksuu7rbaZsEM59NvYFae66gqrhUGaWQl2c91JJLtr dvS5F1slt1dX2+6wVpZCf/WYw/HqNAJaP0OFrNX62t1v1DZ4w4OFLKS4k+S0t/1VaLJr+626lZBH MS1vbPOFpLvqKprakzSyOc4nJWuW/dYmEx9Lj3ux0eqrnb7nS1pFI4gVcYkA62tBLcfrhavV2sbf RaoszWvBZSyuLiT3JaR/qq22XcW6UFGyBsxLGcDq5x9lortqWorqszTTEvPPdMbr2uU3NLf33TcO p73Q3SirsUkmBVMDwCQ0EtI/XC8WrdYW6k1VZgXZFLI4Ek+7SFXOybl3Wioo4Gy5awYaSM4C5u86 nqa6uM00pc8nPda5fbnwk9Lg6h02dRXijuNvri2jn6RVNa4Zw3lpH68Lx6q1Vb6PVlmDnAime4E5 75bhV0su59zoaJlO6QvDBhpcSSAuavOqqq4V3rySHqznkrMrdm1t9S6Yqb9eqWtt9b026qwajHPT 0glpA88jBWOpNU26k1ZaGyPBFO57SQe+W4Vd7JutcaGgjgc5z/TGGnq8LlL3qqpr6315JD19XUOe y1y37ZmHH0trqfTtfdr5DVW6s6bZWtH4gjnoLeWnHnOMLiPiHu9LPaoqWOQOkhyM+/hRnY92bnR0 MMMkpeGN6QS48DC4bVmpKi71DnyyF2TnGVcc+HfyZePl05er5mefcrzfdfWTJOcr5O8rzvSSEkIA IKY7Ix7oEeUgOU/shAYR4TSQA9kFHYoHJQCSZS8oDwgIQgZSQUIH4ykhCA90IQgOD5QeUIVBhH6p 90kB2QEFLJBQZd0YS8JgoEeEJn2SwgRCyz9EkZQB7oQO6RQM5yljlPyjygaSEIBJBz7JIGRyhHj9 EjjIQGE0vKPKoaxKeUkAmOAkjCAwlnvlM5SI7IAJlIeU0GKY5QQkiH4SQj2QA5T8YR9klQ0ieeE/ HKRVACfbCEHggJoO9lkJaRnkrhbuf/SUo5HZdJbq0TDpm4kH1XN3jAuMp755Xj8c1XbKvO/iAheP yva8D0crxDuu0YpntysVk9YqsgJpJ/ZAJpNTQfWD84B7K1Pw3hsdC85AHSe/lVWhcGuBKk7b3WM1 jmic15EYPIT2Xtt97oaqm3KrZZYZWRTlphe5pAkwAD0nyp82dtstv0yK24TOaXtz0u4AaQo01huF ZNRUFLFLSRSTwyskEsgBc0A5IB8ZXt1XutR1emo7bbv7uTqYHOB7ALed53dYxkwx4x1299okummo LnRzTymle3+5jblrmuJy4jnsF1OhpxSaBfUNP+6idJ/4WEqO7NufaodNSUEwL5JI3RuJd4LSP9Vu 7buNp2mskdujp2Cn9L03N6j8wxg5+6zpXPyXKv1/qSgudspXi32+mLZ5nOw13OTg+SpN1nev4Lp6 21Yd0j1ogPrkFchDuJpuhtMlutlNDTQlhaGRnAGR7LmNztwbZe9PUNrosdUc0b3OJ7BoI/1WsZN9 sZb10lvUFwFx2/u9W3IDqKb/AMhVWNnuqTUlKzk8AhSxX7lWqn28rLZD89TLTPiA6vLm4XLbK3XT ek6J1fcgJbi5vDnnhg9gFm47mmsLq7dj8VGG6DtzcjP4hnH/AHSqlY+bKkzeLXtRrC5PDndNFG7+ 6YP6qNMrpcv1mP0zhjq2/YKxWSxJ9lh0IYTSTwkDCeDjjusB9FkCQEE0/DrE12oy7p5y0Kyeu5rd T3ezOujWFpZOIw9uR1EDCqTtRqEWO5g5DXOxgqz9HqSwX21wuvgje+FzXt4HVkc9/ZTXaV072/8A wr0Ix/jhxx/x/wDReDXL7fFfbc65tYf7ucQh7cjq4/mo+1XutTTXmGitzwylhcMY4yR2XWxX/T9+ oaeW9+m6SFzXtOB1ZHPf2SxJXTyM6dPWxuD1dUHj/iWn1v8Aw9up6U3IMc400oha8Z+bPcfVcTqf dWkmvsdDQPaylgcMdPkjsutN40/f6Wlqbw5hlgcHNOATxzjPsrjNVMu9OgqGOFtswxn54ATj7rT6 2/h/9qqc1/Q5/wCDeIWu5HVk+PdchqLdCkk1BFRUL2tpoHDpx5I7Lq5Lhp6/spK26yMbPTkHI5Jx zgn2Uym1w1jG+qWO/BWVuOeuEE/vlaLWraF2qgaxzTM2kPotd75PI+q5e/7oUkupI6GgkAp4HDpx 2JHbC6uao0/fvwVxuMrI6mncDkclw9j9FcdyaLdugrWD0rIBjIljb/Jc3q6Khk1bUGtcPWbRt9Fp PnJ5wucvO5tHNqZlJRvAgpz8nnkcZXU1TtP32eiu1bK2Kog4dg8vHgH6Kaullb6t4fYWY5MjR+nS FzOqoKOXV1U6qe0zspGegwu85OSB+y0l23Lo5tURUtI9ohpiAzJzz2XT1TLDeqqhu9XKIp4Bh/PL xjgH9VdJa31WwGrsTOPzZP6NC5bUlNSS6wrZKp+Zo6SIwM6iMOy7Jx+y09z3LoptURUlI9vpUvDf PPZdJUQWO7XGivVRUCKaNvTIOrl7QOAVdJvbHX+Wu0yweZzn/wAAW51LWU9Ky2xVEbZGTksw4A9m j3UcXrWtNf8AW1DbqRzRS0Ly4O+uAD/Rd7qOmpLvLa3x3CGJtI8yOB56gQBj+Smi1HVXs3p6HX1N eqgAUNQ4yGkd+T1ByXH6HPZSxSfNcadlJU0zaKJpAgj79lDnxA68goGW2jtcwdUxPLnOaeMEALbb EV1TcaE3W6VEUYP5GuPLgfKXEl2+mp9urRe91Ke8XqoZLC2MD8IeAC3sXe4+ikyiy64Qx0s9M2ji aQIY/wAx4UDb8XebTt+p7nQ3GKQVhLPQZ3Z0gck/XK7HYqsqa+3OulznjiD8hjHO5cPdPLju7Tw5 ax1p01vs8NNuRU14fG+apiwWgfMwNHleB9Ex+pLpWyTPM8dREyKPqwA04yceU664w2TW8lZ+KhmZ WcNja7JZgALYmy2qbULL62sMbHNLpo3ScPI/Lx9F08l3jlPtyxx/bC69PlrYtbq7TjW4yXyZ/wDc rY6ritNXc6Whu1JBUeu1wb6kYcW+OM/dcTU6rpdR7i0UFM5vpURJLs9+oj/ouxv9sdcdV2yuhqqd tPTNcJA5/JyQeFz8eOr3fh0yk1j18ois+wVqptxnyVrvWtAzLDSu8kHPzHyPouwq49HUuop7W+w2 kGJ2HONOzI/ku1feaCTVcYjnBMcbo3YIxklRfqvbC4XzcKousd5pYLbM8Oka1/8AeY8geAtcZTeU 1p0un6vTWndRSCxiOKGckytaAGtJ9gFs6G22GbV8l0p6+rkqppATHkFmfGAoH3B07+C1xb7Lomrq p6uYETvnlBaznuSOwUrbYaIuunq+Wv1LdqOoYwZaIHk4x7khY03KkSqklGroG08bXl1Oesk46R1d 1oILNZ260nrY6+qNa6XL4XEFgOfHGV7LJqCiump6iaORgDWGFvPfnutLatMXan3Br7rNVUkluml6 2MEvzNGfbClghH4w5JZNR21k0YYGxHoIOcjKriW8hWH+L6401ZqmgZTSB7oYSx+PB6iq8s7j7rp5 LuRnwzUu1vvhItEFNp2pro42/iJj8z8c8HgKSLPTzOv8lXNUyOc+ufCIuOlrQf3yo3+GK/UdJpmO kc9vqE/Nz25UqW6wuodU1t0mrs21wE8bSRw856uPbssYTUsq+ScspY2rKWIavrJmsaJfwsYLscn5 itBZqapOpH1c9S9zZKySJsWOA0L72vVlvq9UVhikbyxsWc5x0knP81narHUW/U9bcqu4B9s/38Y7 Ye7PUMZ4ACSG93baU1FCNYXCdkbWymliBdjkjqK53TcFb/H/AMXVVTnsnqpY2xY4a0Hjle606pt1 bqesMcgDXMbFnPA6Sf65WNlsNVadS11fXV/XbP8AfxZ4w52cjGTgDj7rpjZMbGMpvKVsrbb6eHV1 znjiYJpKaLLwOSMn/wB9aTTUFd/HY6urqjIypnljbF04DWt7ZPleyx6lt9bqSt9KQDqY2IEngdJP /VY2KxV1p1BW1txrWyWxmZYSePmdnqGMnAA/dZym5WvHqWf9PbZrdS0+rrzURRMbO+CIF4HOOVpt Hw3EXWOrrqsSR1ckrGwhuOhrScEnyvfYNQW+s1DXuikA9QNjBJ7dOV89PWO4We+11Vcq1r7ZETJA SMcuzkYzxhdOWpY53Huf9Pbp620dLqu9TwwxtndHGHPAAJGCtZpGK4C5w1ldViRla+VjYQ38gbnG TnlezTl9t9Xfri+CUZlDWjJ7Y4Xw01Z7jab3XVF1qmut8Di+BxbgHqHOOeMLnn3a3hNSR7dO2uio tU32op6eNk7gzLw0A4xnutbo1twbcqeor6psjK0SERNbjpAzjJ8le/Tl8oK293MwSAOnLQ3JGBgY wvHpS0XO03atqL1UtNHTE/hyRgEOHOPotW7STUke7T9qoqDUGoqqnpomVDukue1oBPy5Wv0X/EW3 GGS4VDZY62N0jYw38o57nyVsdN3miuFyunoyj1J3DGT2w3GF4tIWq6WuvrJr3KwUtKS2BxPDmkeP YLGW66TUmmu0mBFulqCmiaGRRhha0DAGW5K0W6O01k1xPdaimc+G/tA6ZC4kZAzjp+vZbXQVdDc9 y9RVlM7qieWAH7Nwt/Y6O4RbgXqpqoJGUUgb6Mh/KeOVvO99Ock6t+HJfD7pFuktH1pqKZsd16ne s4gdWQDgZ9l0uhzcvx4/ikkcjKyD12huex8HPlbayVtNLW3ijjlYZZJXEEHjkYWt0Xb7tbp6uov0 rBBTOdFAe2WDz9ly06bRBZdGw1PxG3WohhiipaWQTBuAAHFo7KXtxrw/T9RS3UzxNpomlskbnYc7 J7hRppq5Pue+10dbeqSkcRI4tHsAF8fi2/HxW2ingY/8J0lkrx2BJ4BXbw44/ktvpw82WUwxk9tZ dN7IqWavbQceu4u47AkcqS9lnXOWxy3u+t9CGYExNk4PR36sfVVZ2HstPf8AcWhhr42zU8R9VzHc h2CMZVhviK1hNpeGjoKQiOKaHIa3gDBws4Tnlp0zvCS1JtkljqrRc308jM1EshjJOO4wCovr9La6 ho55KeuttR0MJ9OKRxeceBxjK5vb6DWl50a67W2Wm9AdXRA5zvVeGjuBjz45UkbMS3yeirqjUdDU Uc2QGtnYWkj35WZ1elu9bqJ6DeGoslqmttTFJDWRktkY8YId5z9VLmzk9yqNOz3m+MdBFUcxCTgl nvj2Khezado7/wDEVcI6uNs9LHUumMZ5a48Yz+qkP4h9XzaaipLZSH02SwZaG8YwSF01Ms74/pm3 jhM/twNPt3Z9f7laqq7pUVbKVso9H8LjLjjknjsjcr4frfatJS3fTNTWPlpsvljqhjqYO+B3BUu7 S0LLXtc+40cQfcqiN87ngZe9xGWhb24TVt32xuLqqCQVktLIPSLCHZLeBhZn7Z7vrbWV44XXuNFt NQmPZunobW0MqTA4tJ4HWR7/AHW50JQXm2W+vk1J6XXgYEUnWMBa/SMM9v2Z9OGN/wCLjpnHoAPV 147Y98pbP1lzrrRcJ7xTVFPJkNaJmFuQPIyFbj1P+2bZyy/6Ur3Ujjj13ePS/I6ocRxjuVycbep4 Huuw3Xb067vAHiod/VcnS4MzfuP6q/5H/wAl014P/ji8u0dio9G7PMuNtp2C4VEAlkkxzI4kYB/d dbYoX360XO0ako4nM6B1wuw4FrhkLxaTZ/Edp6SloemSdlPGQ3PkYP8Aovdoerq5LTWXa8xCmdKO nB44bwDjwuUdN9tLpHTtu0Ft9V1djpGMqZMkuA5eS/AGf1wtxaaX+0tiulp1JRRuY35Xwvw4cjPd ekMNdoN8FF0zTxgO6Ae5D+rH7L46Jraqey1l3u8IpTUDPJxkDIzjwg0WjtN2/b/byerstKwVcgy5 2Ml5L8D+q3FvoY9V6Yulq1LQgtjcYnxP5I4yDlet0ZrdBehSATTRta4sz5a4Ox/JfPRNwqKqwV13 u0QpXVR6sOOOAMA/TwibaDSGnLfoDbp1TZaVn4uRrS55GS9znho5+xW1htdPrHSdztWpaMOELzC5 jjktIAIIP3K900bqrQLGUbRPLExjiwHuWuDiP5LDRNZNUadrbtc4hTfi3GUBxxxjA/os231F6c3p WxUG3u3DJ7NSNNVKGlzsZdI5zgP9VtJbVT620bcbdqSja4wvdEWnlzXNAIIPvkr3V0ck+haT8EwT y04jkLM/5CCR/JZaMqZJtNVl0uEYphWPdPh3HBGAf5Lpj1jHLK25Wud0nYqDbzbiGaz0gdUyhhc4 8ue9xAzn9V7rnZqXXWh6+i1FSAvp3vj5PzMe0ZBB98lbK4h79BUktLEKl9MI5HRjnPTyQjSNVJU6 PrblWxfhvxrnzhrj4cMD98LPcs03b1a5zS9lt+3G3FNLa6T1KqoDOt3dz3v4zleq92Si3B0DWRX6 jxNTOexpd+djmDOc+62l7e+PQlBUQQmpNH6czmM5Pycn9lnpaofVaKrrhUxinFc6WdrSccOGB++F 11OMvztyuVuV+nP6SsVu2427pZLXSGSqqWs9R45fI9w91lqmyUGvNv6iW70pbVUPWGPc3D2vYM8r e3x8kOiLdVQQmoNGI5XsZyR0jn9l8rJUurdAXKvni/D/AI0zTNa7jhw4/dSSXTWdsxunl0A9+oNq gyRw/vY5KdvV2a0DpH6Kqe5m1t30bcqQ1HRPRVjgGVEQ+Vrifyn9FaDbF7qbZl728PY2oI/cr2Wt 0Oq9rnVFzhjn4e9gcM9JaeMfsllk4z1tJr8m79PDpmx23bTQlE22UZlqqvoEjwMyPe5ue/nnwvBu bpm3bg7bTXKrgMFzoWPMMwbh4c3u130Psuw1VVtt+n7VcnRGaCjIlk6ecAMI/rheehf+L26uE0sb oW1frSNY7g4ecj+qxjO5K6Z+rIqjpLZfUOqbLHc6Kqt8ET3ua1k7y13BxngFc5uFt7fNC1kEN5iY 6KdvVHPESY3HyM47q40VHbNDaStkMsHrte8DL+4Lhk9vquX+Kemjn26pX9A/u52vb/w8K4YXKmWU xaT4YNJ2GhtNPeJnMnvtSD09Qz6LeeG+2R3XJ/FFRQnX1tfKB0OiY1//AC9XP8srzfDBcZ3bgU1C 6RxgEMrg3PbDeFsvimikn1fQxxDMjomtaPqXYH9Vvxasy39Ofl6zw18pBpdwLTbLVbbVpina17gA yCAZz9gP3XQbkWegve33RqaGEVRw+POMtdkHg/Zc5tZoak26sv8AG9QStmusjSGDOWxjHZp+oUfb q6yvGoiTb6aqfQ9QjbM2J3p5LsAdXbucLGE3OXw6ZWy6ntJLddWq0W63WzTNM0PI6WU8Leo/YD+a 226FhoL9oGM6ihiZXNw9h7FrsgkA/ZabbXRFHt9ahfNQSiW7SM4YSOmI4OQ0/YqN91tb3XUExZQw 1Boy8RNe1hDCScAZ7ck4THV7ZtsuvlJ51tZrPbrbbNN0rCQAyOCNvWR9Ast7dO0V822fPeKaOO7w xl9O4cOY/OcA+RjwvPtzoai0DbGX3UUomu7mZa0n5Yzg5DffhcTrLXFRqLVdtp2iQ0Jq4mFwaenB eB9kx1va5bv6ottOzms7tQw1lHaSYJm9TC+VrTj6g8hc7rPQ2oNHGH+P299MybPQ/Ic0n2yOFenV 9wtlsbSMuBljYc9HpP6O3uo43g1Bp687e1tva4SSFmYi8hxa4cg5Vw8fK6Zy8sxnSmyAC7hfSdob K4DsDhKH8653p3nazXwu6Ptslhr9RXCjE1U2R8cRlHU3oDR2B4PPlbTeqzWLVGgTeqWGGG60IDR6 QDeM5IwO45Xc7E3eC4baU3oxRtjpIxCekdyGgnP6lV43L1M6e83KnowIaaaQufEzhvV24C3/AIvj lwueTj/kZa8vDFIPw1aPtztOXDUFfStnqut8TBKA5nQAD2P1We9mnbDqHQ7NQWuGCluNHiNzYWhg I7kEDv3Uj7LXSlrNtad1PDE2KljETg0YDiGjJP6quW42qTPdrhS0QENHPK57omflBPBAC3/i4S4X O+oz/kZX8vDH5SB8N+i7RNpa5ahuVIyqqfUkha2YB8YY0A/lIxnPlG9+k9O3jRdPqOx08FFXUwDH xU7GsY9p5ILR5Ge6lDZ+40dZtlTvpqeKOCCP0nhrQA8taOon6kque4WpzJcbhS0Z9Khlkc/0W/la TwQPpwr4cJcbll6Ty52eThi734dNBWOr0hX6iu1FHWVPqSQtZMA9gY3B4BHcnytzrjbXS+rG2Ovt MMVuc6ZlPPHSNDGvaeTwBjIz3XebS3Cgqdtad9FTQx08EXpPawYD3NaOon6kqHrLqR9TunQW62uM NFNWl7YwciPIOcfsuNmsL5PiO+F35JgkHUdg0PpKKgoa3T9rmPpACSSFoc7HGScclaLcvafTdwZY rpRRMtNPI5kdQymYGh0ZBOe3f6rutxK2xU1RRQ6goYa6QMDmPl4848Lw7yfiXaHon2xrul5Y1sLB k4I4x5yF0mM631ty53VvtprjYtubXBSUL7Jbq15Y1jX+mA95wO+OSSuJ3/20tNtsFFf9P0zKHAay WmjbhpaRnq+4XcbYaQ/s/QO1Fq5wdXEA08bnZELcAg/R3cFczqzUbdwNYUGnvWfFRVMpjc6PGQ0A k48eEw1P2y9QvLLrH24P4fdP2e83qsg1FaXVtNO1sUMjmHoY8HJw73xjyttvHtnSU2trTa9JUbIH VsfQIQ75eoZ+bJ+gU6Wz+GaOr7Npm1QNi9Z/U7jgnHJ+hOMrTavYH706VDu3Q8/+5ckx1MrfpnlM ssGo0/tHo2x2mjotQUzK+4SnqdNIS0jIz48A8KGd5tr5dE14q6F5nslS7+7d5id36T7jHYqwu4VJ T1V7qvxDmsdDRNfE8vLS13UeR7ngD9VtNZ2yhutv07SXdjX0b5m+p1HA4Znk/dTjrU+46S8seX9V 82O2lk1TUsut9jc2zRk9MRyDOexBxyAO/wCiz3Y2xp6LXNFatJ0rx+LiGIXPyOodzk+MKzbWxi40 EVDXU0dLEQfQYPmfxjvn/wCnC5rUtqDt1NN3ETMPMkboccj5HYd9k8fq8vemLl+2LjLDsvpG3W6h o9RNkqbnKSHTMmcwZIyPlz2HZRne9mK63bg0VmdVNZaa6R3o1pbkBoBPSfrxhTrr2hjq7zcZpJXR S0lNE6Ah2PmLhn78DC8m980tLpm2VFOSJ45AWkd89OFrDHeUxXPLhhM/60NZtTtzQ1DaerbVmVwA yypOMn/6fZR/uhszNZb3Qs0yZKikr3enHE89T43eefIxypT2+0nU05bqLWj8yNHVBTuP+7PIy4Hg kjBC9FHq9l93Ss9DC4GGJ0hGDnkMKzouVutObsexOnKagoqa/VVTJdJeoOfDN0tJ5IOMDA+hz91D 2sNr75YNVRWhsD6sVMhbSTRtJEo+vsQO6sxrehZVXW51fryMqaAQPhDX4HzOAOR54K3l+ja/V2ln EZIfKR9+gpjO9GeWpKii1bD2CGioae83GqF0maWvEcgDC/BPA7gffKg/X+iLno2/PoLg0vY539xO 0fLKM8Y+v0Vo9c0Mk94uFdDVSxTUHpOYxp+VwccOz+603xGRMdZrTUOaC+KYPafqCCuuHi5WSOWX l4zdny4LbrYx95sZrtRVNRRSSjriijx1NHPD2kZByAe/6KNLRoa43nWo09ROjM/W8db3dLelvJP3 x4Vr9qtYSastte6f81M4RjI+hVb77dZrDryprqYkSRzPwfoRgrl4sp5PHllPh18kuHkmCR6vYrTV LUilk1JXQS8Za5jHf6AqLt2ttK3RF1AZK6ptk/8AuJyMO+ocPdTVY7XRaotlpvVRqaogq5mNlkgD GuaDn8o8jsup3P0/Hqu62iy1QdFE7qkbMMHq6RnGPqmPa3cVw2p2zuGtap5fJJRWxgIdU9HUS7HG GnGRx3Wi3O0dNozUtTbX1IqomYMc3T0lwI8jwVdWipXWiehttvoPStcEZb1NAw0YOAPI5Ve/ibtU 8eoGVskRFPMzDJO4JA7fda8WMzl2xnnccpJ8q8u/osCvrK0Bzgvl4K5PQQRjlA7JoBCEeECSTQUC 8ppIwgMITSKAS+yfZCAR7Jd00AUsJpFUHhCEygX2TCSP9UAUBB7oIQBQmhAkHjsmhAkeEIQCeVj3 KfYoA90ZGEeEAIDyme6RKMoDymkmgChLnP0TQJId00eUAUsIz3zwjugChB7JDPUqApBPKPqgMcJB ZJIAoRlJAeeEDthA7IKDHlNPKESl4STJS/mgEzwjsgoD+iEBHlaC5Rz7fzRhPAQbCrJhlbPCcNJw R9Vrq1/qSdZ5JX2EpfE6N5yPC883cBeaR0KT/cFeMcFeyQf3S8Y7rcSk7vlYhZvWKrIQhA7IALIF YrIcoMmk5+hXvikc1vBI+y8LWklTz8Pm31Deqv8Ai14aJo6f5o4CPlJHkqiKprVeKW3Nr57fWw0T sYqHwuDDntzjyia2XeloWVlRQ10FK/HTNJC5rDntyRhTzunrBlbqltgcwNt1BMBJEOz3t7cfRSNf LDBr/QLKB0hhb8j4w0jhzRwCPZW9MqhUVHdqmmdUUtDWzU7Ml00cDnNGO+SBhe2K2X6SNr47ZdXs cMtc2lkII+hwrYXs0ugdvY6GLoc97fQa3sCXDk4W/tFdU/2GFYwufUthPptH+YNGAApsUtmt98iY +Sa23ONjQXF76aQAD3yQvHPDX00TZainqoY346HyROYHeeCRyrnz3h77VJb72RHcJoA4Rl3USHds hbLVuk7fqXTsdtuMTXxem3oyOWO6eC3nurtLFGWtrpIXVDYKl8DckyCNxaP1xhfKJ1ZVPLKZk8xH dsbC/H7K5GrLPHY9m7vQRsZG2KkkaA3A49+FG2wt7pbZC2gjhja+Uguc1o6nH6la1+vJMbu2fSus /UXkPyHA4IPBB+y+X7KdPiV0HQaenpL9bT6QuEpbJAB8vXjJdn3OVBeB391GoCsXfRMpHuopZTKO 6fcpAAJjlY/ZZDlB9qeV8Zy12D4IW3bf6xsXpuqXAY7dS+2iNLVmq73BbqEhheR1yu7Mb7q11v0r pHb230dtkoaaprKgjrmqIg9zz2J57JO7qJdT2qF+Olc8P6iSTnOVsP7RVrITGap7WkduvCnrdLZu K7Xalr9OFlKKyRolYRhgDjwWgcBdpRaN0foWgo7ZUW+kq6ubBfLUxNkc89icnt9lN6Zx1lvSoP42 X1OtryXd85W1GpbiIDGap4GO3VhTjubsoK290tdpl0VPT1sgEkbuAwu8tA4x9F21FoTRejKGitlZ baKsrJMF81XC2Rzie5yew+iu10qK64T+v6ge7rznqyto7VFx9EsNU8DH+bCmfcrZB9TqamqdLmKG ir5B6kTsAQknuwDx9F31Bt9onSVFR2uuttFW1zwDJNUxB7nE+efH0TZpUd1ymbOJQ93XnPUCtydX XP0PS/FPDcY/NypZ3G2NqH6op5dM+lHb7hJksdwISeT0j2+ikO37a6I0xSUVruFvpK6vcA6SaoZ1 OJP+ibNKlMulQ2q9VsjuvPV1ZW8OsrqKYxfiX4Ix3wVJ2vdja5mroG6dDP4bcHlwLiAICeSAB4A7 KSaDa7Q2nqOjtlxoKevuDhmSecEuJI79+ybqaVNju1Uyp9b1HB+c9WeV0L9cXc0vpCc4xjgqQdcb F3GPWMEOn/TNrr3lzHPwPQ8kY8gA8KTqHaXQlko6O2XKiirrgRmSeUuDiSPoeybppVKK71MVWJ2v f6uerqyugk13eZKcxCocG4xx3Xcay2Lu0Gs4KOwhklsrnF0Urzj0fLgRnOACMe6lK37P6Es1LSWy 5Uja24vb888kjgSffAPZNirlu1FW0Fw/EQvIkPcu8rpDuTe3MwJQBjHYrpdVbG3eDWsNus3TJb6x xdFO4dIiA5cCMk8A8e6leg2X0NbKWmttwpzWXJzT1zvlcCXY9gcYTZpVS73equVW+orJHSPPk84X TWDX11tVE2np3D02jA8LpdRbIXyn1rFabY1s1HVOLo6gjAjb5yMnsP3Ut27ZHRFBBDbq9j6q5OZ8 07pXD5vfA4Ctuk3PhWHUeoqy9VDX1sheW56R4Ge66GwbiXa10bIISCxowCc9lvb7slfafW8VloGC WnqDmOqLcNY0d89+ymCj2L0RRwRW+t9apuZjIdN6xaOvHfp7d/CnJrX0rtV65udTcm1T5SHsOW88 Bbap3QvM1IYQ/p4xkEr1XLZbUcGtWWGnjEsMrssq8YYGZ5J+ymWm2F0XTU8dBVOqZ7j6ZDpvXIHX jv0/fwrbZ7SSX0rhYdXVtoubqtjy57/zZPddfJu5dXNOMA9s5K8lZs1qWPWzbBDAXskeSyrx8nR/ mP29lNEewejoadtDNLVy3MRYMvrkDrx3x9/CbXSCKLce6U1xlqjIXueeclbeTdy6ujd0NAJH5g4r wT7QalbrY6djpy9xd8tV0n0+jP5s/wCimpvw+6TjpRRPqquS6+j80nq4b14749s+E5VNRX2h1vX0 17luLn+pNLw4n6LpK/d26z0jomH0+oYzla7/ALI9Su1qdNtpj6odn8Tg9HR/mU0u+HjTLKM0ja+t fdRD+Yyjo68d8Y7ZTa6QdpzcW4WipfIHF4ecnJXSv3ouRY7pjIcR361zdPtPqabWTtOtpHidrsOn LSI+jOOrPspqn+HOwC3upYbnWOu7Yc5Lx0F+Pb2ym06Vl1PfKm918tVWSF8jz79lpc9lu9X6buOl 7zPbLvAYqmInnBw8f5h7grR4JCzXSOp0Zqmr07WtmpXnp/xNzwVIl23mudXb3QRBzCW9OerKjjQW j7rrK9x22zwlzyQZJCPljb7kqwdf8N1tZaZ2UV6q5LuyIODCG9Bf/XH6qxnLXyhPT+ubharoatsp cXHLgT3Xa3neevq7a+niDmOLcZLsri7LttqO6atOn4qN7Ktjv7x7mkMY3P5s+3spmufw20sdnqBQ XuoqLvHGHCItaGF3t74VuWrqpJL3EO6a19cLTdDUmRzw45e0ldrfN6K6strqeDraXN6eSuEsG3Go bxq52n4aNzKyN2JXuBDWN/zZ9vZTJePhtigstU62Xqequ0UfUIHRta0u9s903Ymp7RJpnX9fZ7ma nrc9rjlwLl2t93qrq22up4ethc3GS7hR7pfb++6g1V/AqakeyqY/EznAhsbR3cT/AEUxXz4bTTWW rltN5mrLnCwObSuja0E+3VlS3V7OMvcRdpfcKvs9zNQZHPa85cCfK7a/72VVZapKaD1Gue3pySo3 0poG+aj1QLHSUr2VLXYmc8ENiaDySpd1D8N09JZKua03p1dcoWhwpTEGh3uOrPsrypqfCOdJbi11 ouRne9z2OOSCV22oN7qmstclNB6jXObjk8KL9H6EveqNSCz2+ke2pDumZ0gIEQB5JUtah+G+uorL WVFqvIuNfA0EUvoBgd7jq6vb6Kcji4PSe5NdZ7qZ3udJG45cM859122o98Jq22yU0DpQXDHzKJ9G 6KvOqtSNs9upnip6umUyNIEQB5LvspX1R8Odyttkq6u2Xdlxq6cZ/DNg6Ooeeer2+ibOMcho3cut s1xdNK5z2uPVjOF2Gqd76q4WuSmp3SAuGDk5UT6K0ZeNW6gZaLZTu9fqxK57SBCM8l3/AEUo6s+H a62exVddb7pFc56fk08cHSSPPJPgfRORqNNtpuhLpuoqXyF5fM7qLh3XeVe/Tvw0gifL1kEYJUF6 J0ddtX35lrtUBMpd/evcOIhnkn/opM1d8Pd6sljq6+juUNykpuXQQwkOIHfknwE5HFrdM7sVdvvM lTO4lkjs9+y6TV++VRcLVJTUkkmXjGSVEGhtHXbWN8ZbbTATIT/eSFp6Yh5J/wCikXWfw/X+wWWo uFJWwXMQcvhgicHADuefZNmpHg2r3J/sxX1dTL1OnqD8zxySPZbLd3dg6s0++2NLnMe4OId4IOcq ONCaNu+sb2y3WmBzjkerKW/LEPcrvNb7Cak07Z5rjBU01ziiP95HTNd1tA7nH0Ta6ny4/arVTdJa kFwcDgt6MjuOVut4tfnWtfTSAuLYWkAn6rldB6Mu2s7y232eEud/7SVwPTGPcruNc7Fal0vZH3My 0twhjOJGU3UXsA7nGFJdejLXy221e7h05am0c/UDGOkFvsF2Vz36abfM2F8jnuaRgqAdBaNu+sr0 23WeIF3eSVwPRGPcldnrzZLU2k7IbnLJTV1O12JBTZLmDyTx2Vl1eix8dBbhGza1qb3U5658gnvj lYbz6/8A7aXSmnaTiFpYD9M5XKaD0Zd9aXkW+zRAux1SSvyGRj3ccLqdebL6o0hZRdK78NV0ocWy GlcXGMY7njsnK72anp3G1+8n8Fs0dHUucDG0NBHPAC61u+9M18svqHrc3pHy+B24/VVz0Do+76yv IttljDn46nyPyGRj/iIBxldHrzaLVOjbS25XKOCak6ul76V5f0fV3AwElNJW01vhDSGpEz3NMkhd +Xj9l779vzA60zR07y572kDAwq76D0jedaXptussQfJjqfI/IZGP+IgHC3uv9qNU6MtDLjdYIZKN zugyU7y8M+ruOAm004bUlyfdbtU1kx+eZ5cVrGO6XApOJ6uVipbvutyaT9s/u5LYYG0tdISxgw09 +F1O4e9zbhbPw1A/JPcjhQHoLSN61ldPwNgpvVla0uc9x6WMH1PhbrXO2up9GUMVZfKVgppHdPqR SdYafr7JKliUNsN43Wzqir5cDwScjlbfcfetldbfw9BMDnv08BQFojSd61fdHUOn6UzztaXOcXdL GDHl3YLY63291Lo+nhmv9EIoZT0tex4eB9yOy1tnSWtst5TbWOir5P8AlJPC2u4+9UdfazTUMgy7 g9PAUA6K0ne9XXJ1FYKQzzNaXOJcGtaB7k8ZXs1toXUekGQuv9EYI5s9D2uD2/uOElTSZdr94xb4 nQ3CTA8F3IK2O5W9EdZbPwtvkaSe/QcBV80Xpi86suTqGw0pqJ2tL3fMGtAH1PC9OtNG6i0hLAzU NC+mEwJjd1BzT+o4Ta6ThthvGyjp5Ke5SAccdXIOV6dyt44au1/hLfI0NxghnAVftIaZvWqa59JY aR9TMwdTsHAH6lfbWmkr/pOohh1DQyUpnHVGSQ5rufccZ+ivLSXHfSedsN4oqWjdTXKQEYxh/Y5X 23K3fhntoo7a9gZjHTHwAPsq96S01etTVklNYaKWrmY3qcGkDA+5X11fpe+6WqIae/0EtFJK3qZ1 chw+4U5LxT/tjvDBFRSUlze0jGOl/wCV2e6Ny93aeW3sorYWMjAx0x8NGOyr3pTTl71LUzQ2Cgmr ZImhzxH/AIQlqjT1605WR01+oZqKaRvW1sg/MFZlrsuO1jNsd4KVtukpbo9pGMFknY57r5bpbtUt RaxQ2pzGMx09Ef5QFXvTOn71qCeaGxUE9bLE0OkbEM9IJwvnqWzXewVjaS+UU9FO5vW1krcEt91J lq7hcd9LO7V7lWmh0PT2+tdE4gO62vPByeQV7NVbqWmg02+ktLKeBpGAyHAH14VW9NWe83yWaKx0 NRWPhaHSCFuekE4GVhf7fdLNWfhLxRz0dSWh4jmYWkg+fsryOPe1nNvd2KCotD6O7GN7MdJjl7Hy vHuVuvTOip6S2ljYYy35WHjAP/RVw0/aLveZJmWaiqKt8QDpBE3PSD2yvnfKG5Wmr/C3elqKSp6Q /wBOZpaS09jj2U3N7NVbug3J0/erDSsu0cFT0APxIexHb9Vrdfa5sN+0LXW+rEcpexwjJdyw+CPs quWSgu92MrLTSVVWYgDIIWF3SD7+y+d2guVuqPwtyhqKabpDvTmaWkg9jg+FZlrss2sfsjqDSth0 7QONHSC6Ma4yVXAkJceQT3XQ6+1LpG8wGSppqeSuLmCKckF0eHA8e3ZVTstHdbi6UWmkqqoxgGT0 Iy/pH1x2WNwkr6KcwVscsMzQCWStLTj7FOi92X6XOuWttL3agigr4oamFoz0uf2PZa276r0yzTAt VFFFDTlzGsY12Q0BwP8Aoqk20Xa4CQW6mq6oRjL/AEI3P6fvjsvhU1dZDK6GoMsUrDyx4II+4KTU ml3d7XSvOrtLXmjgiuUTKmJnzBpkxg4wtXe9R6XGmIbVRwxx07Hx+mzq6ugNeHefqFUigddq0Sfg IKypDPz+gxz+n747L4zXCqY8xyOex7ThzX5BB+oSaZ93a6d/1Ppe+UcMdyb68TeekS9Pf7LVam1J pqLR8VFRtZFFA+MwtyD0dLg4Y/ZVIpKm51Yd+FjqZuj83osc7p++F8J7hV/NFM+QOacFj8gg+xCd Re1xbrfdK6ttNE++MMr2t6sRydOCVyG8OpbBDoEWS2xxmMx9EbXHqczByCD91W2nrq13yQOlf4ww E/0Xlrq2okLmVDn9TeC12QR+6sy49xnhL8NdUEF5PlYwnD/0WJ5JJWTOD9Vy9u0ul1tnblpyybe0 FJDIWPmiEk4LgSXuHzFVt3XpqOi1pcBa5TJRSEyR9R5bnuP3XMUN5q6aEMjqXsA4x1EBeStqpKmU vkf1E+ScrWF443GeqzlJllzvtcnaWs07Zdu6Kjhmcx00IfP1HOXuA6lWPc6lpaDWNxjt8plpHP8A UiLu4B8H7LQUd9rKWIMbUva0DAHVgBeKtqpKmQySOL3HyT3WsMuGFwnqsZYzLPnfa5u102n7Nt1R 0ENU4etCHzFxz87mjqwqu7k0kFv1bcYaOb1qTrL4Xeek+D+q0tJqKupImxtq5GMAwB1kLwVtVJUy mSRxc4+Sc5SZ8cbjPVW4y5c/lc/a7+A2bbult0VaQ2aH1Jc9w9zR1YUB0clJpjeimmbP6tFBVOey Q8Etc04yuBodTXGlhbFHWPY1owB1LX1ldLUVHrSSF8nfqKnvG4fFXHrPnPa5msrXpzWjaOrrblPT uZGABDjyc4OR9V7rxqC2Q1mn7dHUhzI5W5kJxw1uOVT6l1Vc44msFU9oaMY6l86jVFe+ojkdUSF7 Dlrs9lr/AL+GZ+vpcbWlttWpImxyXqWmi6Q3piwM/qQVztzsulNOVdiudtip21FLPl8jBhz29GDn 9eVWca1uxaAat5P3XxrtXXGqjbHNO9wbzyeVNTWr6WW43eK3t4pLVXaktupTcmh1FHltPjAeSD3d 47+y0G5ddTUN+sOq6Wqjk/DO9N8Pchrgec/TKrO3Wd0MHpmpcWEY6SV57nqyvradsE8z3Rt7NJ4W t29WsTGTWlv6qlsWs/4ddJaos9Mj1I88TNAyGn2wef0XD7z64poqSKgongOgILSDk5Ax3UA2nWd2 t8LY4akiMdh7LTXe71NfK6Sd5Lj3JKmOplMmu7OKfdibtVag1S6prbk2KGgaHmN4z6pcCMZ8Y7ru 9xKxtm1jZdRR1kctLG8xSQtPLctI6v5qp2m9QVllnfLRSOYXgB2PK2t61tX3OFsVVMXNHhWVLjOv 4tvdLTZ9YVFvuX4x0cYI9eMOx6rQCQPpg4OV4rrfrdctbWO1HofFFK9x68EEhhCq7aNfXS307IYp j6be2eV4mavrY7yyvErvXYSQ4n3Ck1Ltb3JFuNd2Ouv8ohoLzS01L5a4dRH8+Fx9x0zadvtS2K+0 FRNMBM+OcSSh4Ac3AIxjHKhgbmXU4Jlz/NazUGvK66wMiqJSWt+qm/gut7Wrven6TU15t90pa7FL IR+KjEgBc1oJaR+uFr9Waxt1Hqy0DrB/DPeCSfJGFXG1bj3Oho2U/ql0bQQ3JPA+i5q66kqa6tM0 kjnP75yrPe6zZuaXB1Hplmo7zQ3Gir+ikmwalgcASGglpH6+Fwu/l7pa+lpbbTODpWyBrSTjJJAC iGz7m3Oko4oDIXCNvSOok8LmrzqWpuNcamWUukyDnPbB4XTx+ThduefjmfS1eyuj7jpWgucNykp3 y1Mge30X9QAwQox1BtpUza8hi1FUiitteZHMqICHkOHYEH3XMUW69xYwCR3UcDkuK8F93GrblJTm R2DC7qaQSVx8WP4sbjPVds7zymd9xJLNrNU2O+xwWKsZV2eOVjmOmlDHBmQSOn9+y7beq8fwltsq qeQCppiQRnkZGFCzd27gXNMji7/vErmNa63q79L/AHrz0+2cqz9bs9rAbPahvGqbtJUy9T7fTh0c juvOHlvAwuW+Jk1sVXGydj/wUjcxO7tyP6FRVt/rys0u6eOBz/RlcHlocR82Mf0Xs3E3Dn1LRxwT EkN7ZOcK+LLjtnyY8rL9IxnPzuPnK+B5X0lPJ9yvl4XN3ATSCO5QZJFCECxyknlCBITwhAkdkeUI AoR2KPPKAQgoQGMlI90eU0CymEJKhlL2R4R+6AQmhAkIQgfKRQUwgRR37JFNAeUYQjKA7IKCjKAA QU0FAk0Ix+6AJ4QEHhInhA0u6YS8oET4KBwl3TxygaXnwgoQIFHPhPykO+VYGEk0kBwkmjwgSCMp pIBCM/ySB5RKChPwhAkJIHZA8oIQjGStASyPdNNEfPJDuOyVQcP9shBOCsZz1OJAK87oyqOIQvEP ovXUf7poXl7EYWolBSTKxJVQI8JpIBZAJDun4+yD0UgBlAI8q2nw59LLJISQC5uMZVSYCGuBz54U p7d62msNVE4vPpeRlB9N0Yaqm3QvBmhljNRVOkh6mkdbSeCPdWV2vtz7NpSKpuM7/UkZkhwwAO/A UR6s3Bsl/qaCf8BEaimkDjUOGX4H+HPsvbrfdelutnpaK3j0+l7S9wJzgDGFdbZ9On32szquiobx Ty1EvpvbG6OMZYGckuPt4XbWeuFs26/GgnEED5ePoAVHNNudaZtKutk0ZkMkZY8l3cFbuPcvTb7Q LaaVhpDH6ToyeCMYIKmqfDRQ1VfrTVrNRUlK6O000DIXyvOA8juR791JWv77/AYLHU5x1TdH/uAu Pl3I09DZzbqGmZBThvSGR8Bo+gXI7qbiW7UUFopaIEMppvVe4n/hxha47N6iUd0awVm1N5qm8CSl ccfsq8bKB0up4WgE5xgDupA1juRaqvbaps1NzUTQmIZPbJC1O0WotM6Nsj6qpYJLo8ZdI49voFr/ AMJizjOOVre/Fz0jS1iBI6vxL+PP5Aqrnsu+3W1vV6wujpp3Yp2OPpR+AFwCnxpqBCEu6lUd0BCP skDWTeTjysR2WQ90E6fDVAP4/wBWPm6mhTxrqe3U+rqf8c1hmfSPbD1NBw4u8KsG0+pf4HWhzXdL iR2OFZaDU+m7zS01XeGxPngIcCWjOR7nvhMP1yt+2fJvKT+OoqGH8DZgGknrgzx27rSa2fbodVM/ HiOSd9E5sAeAcEk8j6rgtSbrR1WomxULw2lgf8nScduy7WPUGmr1TUlbeBG6ppyHA4BPHgk84Wcs drjdbdPVRvEFkZ3/ALyHJ/Q5XPazdbmatca0MdUuo+mAOGek9R5H1XF3/daGo1KyGjf00sLsMAOO y7Jt401em0VxuhZ+LpzkOGCT9D9FZNQt26ivZ0xWHjL/AFYwfr8q5jVn8PGrqj8Z0OqjSMEAdz0n J5H1XI3ndOGq1Q2KkkAp6d2IwD3xxldk+4abu0lFdrg5jayDyP8AEPY/RNUljo64O9WwNHfrGf8A whcvqhtvOra38V0urfwsX4cHuDk5IXLXbdOnqdUNipHgQQOxHg/ouyfWabuslFd697G1UAOcd3cc Z+yqWujq2k1dia7k5cT+jGrk9SQ0D9X3A1Ra6sFND+Hac5acnJAXPV+59PVaqZHSvAhp8tZ/RddL Pp241VFeauZjKqEEO93jGACfoppL26GpZm5WRrscF5P/AIGrkr/T0b9W1z6gh1YIYPRBdgt75IC0 VRudTVep2RUrmelTEtbzzzwf6LqpP7O19xpL5VTNbURNIc3OerjAz9kkHR1bB/F7RwDxIP8A3IXF 3GlpX6uuE07w6rAgbE0u5aPJAWsl3NparVDY4HN9OnJa39eD/RdK+HT1Vdqe/wBRUBkzGEPj6j8+ Py5+y1OpXPPHdldDUxht9th4P+9H/uQuPr6SmfqyuqJZC6sbLC2Jhd+VvkgfVa1m5VJW6pDKdzPT gJa0eTng/wBF0b6OxT3qPUEtWGSBpL4+rPXgcZ58fZJuV0xupG8qWtbqSiIHJZL/ACAXJTUdOdW3 KokkLqxtTE2JnVw1pxk4Xgi3Hoq3VBEBj6ISWj3OeCuifQWSS/jUL6sMcWFz4uo/M4dj+it3pjhO v43c7W/2opvlHUYpDn9QuZfRwO1NXVUsrjWCrjbHH1YDWZGTj6rW024lFW6od6RYRFlg55we6338 MtB1CdQOrukFnW+Iv/M4dv2WNOuN1G6kY1urITgZNO859jlcwykh/tLV1kkz3Vgrmxtj6+GsJHj6 rx0e4FFXapeYiwsiBj+uCVuI7Ra4tSy351cBA9vqOjL+S/6/QeFcptnHqN7I1rdWwnpHNO4/zXLQ 0cY1FU1r5nuqfx/piPq+VrcjwvNQa+oa3VUro3MLYx6Q556crbQWWgptST319wH4aUeqYi/kP75/ 95STUaboNb/bFxDAXClznz+Yrm6aiDdQS1zqh76h1wdEIi7hrMjBx+6+Fs1zQ1uqZ3xOaWgelnPj K2dPZKOj1LVXx9wBpZGiURF+SH8kn7YwiNyI2f2vqHhgLxSs5x/xFc1bqHF/fXvqXvmkuD4vSyMN YCMcd1hatb0NbqiqfC5paQ2In6A5WwpLJS0GpKq9yV4/CPAlbGX5IfkknHtjCaG3ZEz+1lZI1g6m 00fIHPLiuaslC8Xv8dJUPfNLXyRekSMNYDxx3WVo1pb63U1W6JwLSGxE57AE/wDVeu32OC16jrbz NX5oXgTMjLgSHnPVx7dlcepYzZvLauHxkRAa7t7x3NEB/wC6Kr40ZcApo+JvUlNqPWcclIQWU0Po 5H3KhqMfMFK3j6XM+FW0wUOjJamOMCafDnuxyeV2ulKWoZeWVNVUPe+eeZojyOlrBnH6rivhxv1H BpSCjdI0PIAcc9jld/YLDJY71X3GuuAfQH+9hBIyHOz1cZPC149Y4ZS+3Pyby8kvxptbTSxM1NdJ GsAlfBFl2OSMlaTSlLVMvENXVVL5DVSyt9PHDGtzj9V6NPaqt1bf6xzHj5g2POe3TnH9U7DYqix3 q4XG4V3Xbh/eQB2AQXZ6uMnhTKb2vi6k/wCmxslJDFqe8yMY1szo4w5wHJ4K0Oi6etZdYKutqjJ+ LklaI8YDWtzjnyvdp3U1urb9XuieB6oazOeBhYac0/VWC711dca4SW5hL4OoYOXZzxk4C6cpxsY4 3lK2Vho6al1HfJoomNmc1nU4Dk8ZWq0fT1rLhT1tZVeqK0yNEXTgMDe2TnlejTWorfW3i4OieAZs NyTwMDAWGnLHV2K41tbdKxr6GIl0JIwfm78ZOAueXddcOsZGxsFBS0l+v08MLGyno6nAYJ+XK02i oK+KupqquqhK2tEhEQbjoA7ZPkr26b1BQ3C6XMwvANQ4AEntgYwvhpayV9jrq2rvFY19HC4mAkYy D388Bat2zrWo2VioKWku+oKmCFjJcjLmtAP5crUaIZXsrqaavqRMKxj3dAbjpx2yfJwvdpi+0Nxr 7m2J4Dql3GTwOMYXw0paLhZauuqr1UsNLTkiDjGWkd/oPosXdbe6wW2ko7lqGqpoI45nSZc5rQCT 0rWaGjr462E3GcSisgMvQG8N+58le7TF5orhU3NkMgD6l5IJPAOMYXn0hbLlZpq2pv1Q0wU5dHTk +We/0H0RHp03aqK3VOoqqjgjjnfM4uc1oByGrxaHZXtrW/xOdszaun9drQMBufB9yvbpi7UVe+5x QygPqJHOaSeORjC82jbdcrO6tqb/ADt9KBzooCfLB2P0H0UqPvpu0UNpOoKqgp44pX1EjnOa0Akh q82hm3A1fTdXslbVUwqGgD37g58r26bulHcWXOCGUdU8j3Nz2+YYwvNo2iudpFbVahlYGQl0MRz3 jHYj6H2STprc2NP2iisdJqGqt1NFBK+omeXMaAchq+ehzXvqHxXZ7ZRUU7agDHHPBBz5XtsVdS3W iudNTygSTyyObn2cMBeXRdJc7ZFWVWoXsaIeqCM5OSxvYj6Hwlxuo55d5bYaes1Dp+16gqbbTxQy PqJ3ksaAc4zhPRRrpjNBdzHJ61OyfoAyMOyCDnzwvbZ6umutsulNTygyTvkczP8AxDAXk0VTXKgg rKvUBbGIswMJ4JY05B+3stSdf+2rd7282nrRRac0/f6u1UsUM5nnkJY0AkgZA+y+ujPx1VDVU16E UomhZN0AZHzHBBz5XstFRDdrHdaajlaZpnyOaCePmHC82hIrjRUVZV6gAiewmFueCWtPcfT2Vz/1 697cved360+GlbJb9Maav1VaaWKGd0s8hcxoBJHIH2Xo0m2sraetor7HFIJYWy+mBlpDvfPleqzy Q3Kw3SlpZWullfI5oP8Axdl59FG4UtJXV+oWiFzf7luRglrT3GfCdO1u48GmLNQ6T0beqqy0sMM5 lmkJY0DJzwF7dLMqrpQ19v1DTxPbLG17oj8zS13uvTZ/TuWm7hSUkrXTSPe5oJ45OQvjoqWvgo6y 46gi/DOA9IB3BLWng4Vy12xN2tZpSx0GjtE3Wps1JFDUOkkf1MaAXHqwAtlpplRd7fcbZqKmiex8 bXOiPzNLXDPK+9D03PSlZS0cjHzF7nAE8cuyF59EVFdHbau6agj/AAxI9MZ4PS3ODhS3ddN9NXpW xW/RWg7jVWSkihne97stby49WAFsrFDLebPdLVqOlicwsBfCfmaWuGV6oGNuei6ikonMknBcQ0nj 8/UF5tG1VY60Vl2vcYpnSN6MOGDhpwOE95M5elA9YUDLdqS4UsI6Y4pnNaPYZK1MTC+QN9zhdNuM 4O1fdXNIINQ4gj7rn7fg1kOfL2/1V80nO8V8Vtxm15tvrLS6H2jhq7XSsbWywMdK4DmRznAZP7rp bbQjUumrpa9S0bHMYTG6J/P+HIOUqBv8R2zp4qANlmihjd0Z7lpDsfyXp0bWVUmnam7XmNtK6qHU WnjjsM+yxj/rN+y/7X6aDS1goNA7c+tY6Rjal7WlzscyOc8NGT+q21HbYtWaUudr1JRscInuhdG4 5wQMg5XrkY6s0I1lEGzTwNY4sz5a4Ox/JY6Mq6iTTdVdbtGKV1WTKQeMDGB9lPhqOd05ZaPQO28c lkpIxVShmTjl73OAyf0K2bbVBq/Rtwtuo6NjzA90TmE5LXNGQQfuvZcRLUaFp3W9gqJqZrHmMHuW HJH8llo2qmk0xU3S6RCldWOMxDuMZGF0k1jHG3eVc/pmyUW3+3FO6y0jTUTdHUe7nveQCc/Ze6us 9LrbQ9fQaipWvNO58eCcuY5oyCD78hbG4iSXQtK+iYKiSlayQsB8s5IS0hPJJpCquFxjFKa0vm6X cfmGB++Fzsu5p161ftzunrNR7ebcUZstIH1NQYw4/wCKR7+M5XuvVkpNcaCraXUFIDJTmRgyfmY9 o4OfdbG9vkboahqKWE1T6PolcxvJywZP7LPTU0lToisrqtgp3V3qTAE4/M3A/ddpJxlccv2yyaHT VmodutuKT+D0hfU1PQHnu6R7+Ccr66jsNFr7b6qjvlJiemMjWE8PY5g4OVub26SLRNvqqeE1Joui ZzGcn5Rz+yLBUPq9C1tdUsFOa4SzNa4/5hx+6x1uOl3qtBpqyW7brb6hbZ6Iy1VX0B7hy+V7h3yl qvTlDuHt7O68U5ZVUvqCN+MPY5g8rfajldS6PttdDCagUHRM5rOcdLf9CsrHUOqtB19ZPH+HNb60 rWu4/OOMLepqVN9tFpuxW/bnQVFHaKPrqassEjhy+R7h3yvjrfTNu3E2/kqLnAYa6k6xFKBh7XN4 wfp9F0eqag0WlrbXtidPFRBssgYM4DWH/VY2mY1O39bVSRmA1nqzNY7g/NyFyk77brR2Gw2/bjQ1 BBaKMyVdY5jXvaMySPcM5z+nZeXcXSdt3F2+NdXQGnuFIHGGYDD2lpwWn6fRdTq+rbbrDarl6Tpo aIiV4ZzjDCP6lYUbzNt1UyviMBqeuVsbu/zOyB/Na0lvbTWWxW/bXR1HS2ikL6ireGvewZke4tzk nz2Wu3O0fbdwtCfxWaI09xp2kwzNGHDDsEH6d+F12tq+O12q13WSN0tPSEvd0c94y0fzIXyhJfts 9zmOidNl4Y8YOHSZ/oVlWmtljt22Wj6Sms9M909W8NfK1uZHOIzk479lqt1dF2zX+h4722MQXCFv VHKBy4dWCD9O67PXlwjs9FarpLE+WnpHuc7pGe8ZaP5lfOMde2LT6bo/Ub1hjhggOlzjH2K1JNRN 9tLabLbNstL0tJaKeQz1TsOkY3qkccdRJx37LQ7vaFtuvNIwahpmfhri0NIkaOXtLgCHLvNd3CGy fwu6VUb301L1lxaMgFzC0c/cr5Ede2UXSwsDmtcGuGCAZQcfsp8xmd2tHbbLatrtN0lHaaWR1TVO DXStb1PeQMlxA78ZXObybfWzW2mYNS25opLm5rD6jW/71pcBh31HupC19cILNLbLnWMe6mpxICWj sXNwP6r5SsB2xpQ1pb8kZDSMED1AcLU+Jpr+tJbLPadrtP0dFbKZzqupwHytaXOkI5JI+2Vy+9O3 Fs1fZ6bU9raKO4S+n1Oa3Ima5wHzD3Ge6kXX9yprNXW241zXGnijkaS0eXAAD9VjVxgba0AaCOIc A9x84U13J8MS7taagslm2v0zR0dDAHVE5HXKW9RkcO7iPfC4/erbWg1RQ0mprKG0tZUujbLhvErX uAyfqMqTNwrlR2iqt9dXtJhjilaBj/EQAF8a6Mt26tTWtPHocY/4gtYybhlWmoLJZdsNN0dBDCyS aUgySvaCZHD8zjntwo8+Ijb23XCxDWlkaIJnta+aNreJQT3+hAUu7h19DbbjRVNzGYBBKwDpBBLs DHP0Wk3BhB2SazHApWfsr48Zc8cb6rjn5MsZlZ8KQSNLXELYactkt5vlDboCGyVUzIWuIz09Rxle WtAbKceCuw2bZ17kafH/AN9M/quGf6709mH7aWotmm9Oba6bo7a+CGeadwfLJUNDvUdwHHntwuA3 i2jpLpV0F/0v6dLDcZGMnh6fl6nnAe0Dt9lLevqy30V2jkurWugNG9jQ5ocC4kgcH9F9ns/+FTTE YwW+tTj9Mrpx9Mzu6c1atKaX2909Q22qpqaaonIfLJUNDvUdwHHntwOyj7d/Z2CsuVBeNJ+jT09z lYyWAjDWOd2e0DsPopf17NbYbm994bGYzQOZH1tzhxcRx9V66pubBpcDketT/wBApi1JLdVyVq0d pTQlgoLbcKKlqamUiSV9Q0OL3HAccnx9FHe7OzImvFBctJCKGkukrWPhPysic7kOAHYfRTHr19tZ c5nXb0w3+H9MReM9Ly8jI+q99dkWrS7QMgywj/3KsZx7unG2bQmkNGWS3W270FFV1kvzySzsDi44 AdgkduOAo33U2WeNSUFXpX0o7fdZAz03cNgcRnIA/wAOFNGvm27+IVH8U9Pi3/3BeOWv6zyPr2W3 uIJh0w3uDMz9hGsStY4yuDse3ejtK2Sitl7oKOtrJj6kkk7AXDIGcHGSARwoz3P2VnpNS0D9K9L7 bdZQxjHnHoOIJ/8ADgKaNeMoJLtXtuRY0i3tMBccFr+s8j6roK5nUdLtPP8AetP7RFdMpqOeP7I/ sW2OjtN2eitl9oqa41kx9R807R1tyBkAjGQD2UX7kbJ1dt1RRM0yfWtdzl6Ig92DA4gkgny3HYqc NexUM10rv4gWtcygYYHE4LZC/wAFdDcYw6bTDXc/32c/aIrE3LqukkslR3Ytq9F6dtlHbr3SxXCt md1vlm4e3IzjjHAPCivcPZevtuq6am060T2+4SdMHW7BidjJaT5AHYqbNe09JPqCuNW4MfFRsdC8 ux0v6j2+vGP1XV3SMOuely7BIlJ/+tFdc8OOv7Hm8Wd8k3fio7su0Wi7LbqGhv1Kytr5fzTOcWkZ GfHgHhRHr7Zu6WnVdPQ2NpqqK4PIpnF2Og4yWkn2HlTtuDTRVF/rTK4NkgpY3xOLi0tcXHJHueML pLkwOvWliRk+q7/7EVjDHuS/TrvrevlHNk2c0ZaqKgodQU5qrlLnqm9Vze4zyM9vCiLXGz96s2r4 LXaozWU1c8ikkzjA7kO+wU7bkQRz6iqnlxZPBDCYnB2MEuOePPAwuvvDA7UOlnEciV5/+tFdMvHq T+uHj8tz3r4ukbWfZTR9voaGjvzJKi5vBD5mTOYCeTnA4x4UOa02mvdh1dBaaOJ9bBWSYpJmD8w7 kO9iArGa9ooam73SokmfHU0kUDqfD+nlxGePPC316YHao0uSORI8/wD1srnjjLdV2zy1Jf6jOzbI 6VoqOio9QSzz3OQEPkjmLWk8kHHgeMcqG9XbWX2xasissULqttU8iknY04kb5z7EDurIayo46i8X esM0rKqhEBgDZMD5nDqyPPC6G9hrtaaYJGSDKR9+grf4+3OZ35+0W2nYrTVPR0NLequqkucjS2Qx S9LOrBPA8D757KGdWbZX2w6sbZGwPqnVDyKSaNpIlb7/AHA7qyut6D8TdLrXNnkjqKExGJrXYBBI 6sj9V014ja7VunJC0FwE2Pv0LEx706ZXSI7bsJYIaShp7tcav+KSRkSiOQdBfgngdwO37KGdTbcX 2x6o/grqSWpnkcRTviaS2Vue/wBMeVZjWdHLUXe5V8FVLFNQPj6Yx+VzXEB2fryusu0LJNW2CQtH qCObB8/lWrjpMbtDlv2AtIoKKK5Xeriu0kR9SNhaY+vk8cZA7eVDeodA32zamdZJaOSWrLsRGNpL ZG/5gfb39lZ7WdPUS3O4XCCrkikoJY2tiHLXtcQD+vK6i7wxyauskjmDrbTzHOOcdKzppC1v+H6j dbqKO4XmoprvJCTJGwNdGH8nA4zjt5UM37RV6s+pXWWrpJPx3V0sDWktkGeHNPt/RWm1hFVvulZc qWsfG6hnjj9HHyva4gH7HldTd6eOXV9olcxpe2mmOSOcYCcde1kqD6D4emut1KK29yU10mhLnxBj XMa/ngdiR28qDNY6cuWmrxPbrvC+KphP/dePDmnyCrc6rbXG8VVxpqtzBRVUUJhPIc12M/Y8rlvi loYai222Z0Y9Zgdh+Ocey3jhcrqOeWcx7qpzlivrM0NefuvkuTvCwhCOcoBCO6aBIQgoBCXZCA4K EEIQCCgoygaxKY7o8oEU0FLyqGl90FPKBZTSPsgIGhCECPZCZQECBQEyUFAsI8o7JoFz7ox+yaR7 oAdkITHZAvKaXn2QUASjKPKMIAo/0STKAzgIST+iBEpcpkJIBHlCEB3KAUYwkqHlGUIPZAkfohCA ynlIpeUAgIKaBJHsnlCISM8oKB3QBRlBQqHlHP1SRke5VR8wM9xhYv4dxleykpJZSPUYWj6rzVDe moc0dgV546MKrPotXlHfC9dRzGF5WrUS+wUk3d0lUGUBCMIAclMJJoMm56gAvex7+OnPtgd14Ym5 cArFfDxt7b7g4Xy6sE74nf3MLhloPufcoIZqbTebfSR1Vdbq6mp5CGsklhc1ryewBI5WVXa7tb4G VFdb62mhkPySTROYHeeCQpt13rgXfW0NDMzNvttSWth7gvacZUo6z0vDuHpOgikldE6GQTRgHIzj GD9MK70z7VFp6G7y0bquG3176Tk+s2BxZ/4sYXrZZ9QhrS20XYhwyCKSQgj37K1mt66n0bo2htVO GOfMfRY3OA3ABJwuldXVkeiGVlL1yVjoh0NGSScgYx+qcjSlFTbr3TRmSptlzgjHd8lM9o/cheSt prhQsjfV0tXTsl5Y6aJzA/7ZHKuhWXcVNvktd26W3LEbjFnqByQR/JbDXej7dqu1R0dxibJ6WHQu IyWHAz08ptNKNiK4Gm/FOp6r8Mf/AG3pO6P/ABYwvlE2uqut1NDUSxs/MY2Fwb9yBwrf7n22O3bJ XGjaxrBFCxvS3GB/eD2XGbEX2mpaIWdkDG+qfm6WgdR9z7q7WKzSEkkuyvmpj+IzQ1BpO60VfbD0 R3IyF1OG4bG5uMkHJ75UOBCEUkykQimEgMd0BCQMBMcYSA4WTcfYIPRSzOikDmEhbZ19qvS9M1JA xjHUvdt5o6r1jfYaCkcIonEepMR+UfT6q1lNY9JaFhoLJHb6aSZ4DnSTxNe5+eCSSPcKbSxTr8bM 2QPa8le86grfT9N1U4D26sKedyNk/wCJaqpa2wyxU1JcJAZoyPyOJyS0du3hd5DprR2jYaCyG20c 9Q4AvkqIWyPeT3OSPcJtNKfGulbK17XuznOQVsXakr3RemalwGMY6sKbdwtkHVeraWpsMkdPQXGT Mkbu8RPJLRjGPopAp9K6L0lHQ2SS10NRUloL5aiBr3uJ85KuzSof4+ZkzZGuOc9weVspdT17oPRN U4NxyOrCmPXexs8+saZ9hkjgtlxk6ntdwYT3d0jtjngKRafROh9Mx0NkmtNDVVWAXy1ELXvJPkkp tNKjR3CdkwkY89Wc5yts/VVzfB6TqggYxgOwpZ1vsZVP1lTNsUkcVruDy49WAYfLsDtjngKSKTb/ AELYYqOzVNto6urLfmlqIw55JHfKbNKkx3KoiqBMyQh4Oc5W2l1hc5YDF+JcG4wRnClHVexFd/ba np7PIxtnrSX9byA6HHLgAPHPCk2k230DZ2UlmqbbSVdYW4dLMMvJI791dl1PapcF0qoKkSxyOD85 yCt5LrK6yUpi/EP6cY44Uhai2JubdbwUVoe3+E1Ti5s0mA6EDlw6ee2eFKdJtfoG2R09nqrdBVVr mEGeUnrLsd+CpyXSqFLeKqmqRPHI4SA5zlbuXXF3mpjF6zg3GOCu4vWxF2ZreG2Wx4da6gl7al+A Ymj8wIye3j3Us0m02gKAw2mooI6ivLCDNJI7qLsd8Aq8k0qnS3qro6wTxSOEmc5J7rf1GvLtPRmJ 0zwCMcFdbddir0zXEVpo3h1umcXCqcAOho75GfHhS/BtBoKmbHa56Ns9d6ZYZ3SOB6sdyAcZypzX iqtQ3yso60VMMpEmck57roarcG8T0Zi9YtYRjgroqzY++t1y2y03NFI7Iq3Yw1nk4z3UxRbMaEp2 ttktM6avERaZzK4Hrx3xnHdW5WJNX0q1b9Q1lHXCoikcJM5OT3XS1e4t4qaQxeqWMxjgrcT7Jag/ t3/AYWH8IXdQrHD5RHnv9/opjGyWh44v4Y6OWS4CItM5mIPXjGcdu/hOS6Vjtupa2ir/AMRHK7rz 3910VbuTeaijMLZOluOnLc5K2A2W1GddHT4jPog9X43HymPOOr7/AEUzf9hmimwm3t9d9xEXSZjO cdeMZ6fv4U2mlaLVqett9eKmGY+p5z2K6e4bnXeooTCJOkEYyCey+kWzeo5dcP0+IXNYx3Uawt+T 084Dvv8ARTPJsPo5tOaGKSqfc2xY9R056evGM9I+vhNqrdaNV11trvxMcri4nJye66m47qXaqoXQ NcWAtxkErCj2e1HUa2dp/wBBzAx3U6qLfk9POA4ff2Uz1GwOkjRvo6eoq3XRsX53TZb1474A9/CS 7S6ntXayawrrXcDUxyOJJ5ye66e67sXWsoXQMJjBGCcryWvaHUddrSTT5gdF6TsyVLm/IGZ4cPv7 KaK34e9Mut8tNRVlX/FWRcOdKCwvx3Ix7q269pNVXvT+tK603E1LHud1H5gT3XU3ndu61tA+njLo 8txnOVrbPtHqW46zksDqV0D4XZlqHtIYGZ4cD5z4Ux3b4drE+1TwWy5VZu8cYIL3gsLvqMdk2vUV YuFVJUzOfI8uc45JJ7ry5IOVttT2Kv05eJ7bdYHQ1MR7EEBwzwRnwVqD2Wbv5bllm467RWrqvTlV 6lO8mM/mZnhd3e94bnX290ERdGCMZ6srhttNDXTXN9joLZGRE0gzzkfLG37+/sp4vXw521toqxZr vVTXaJnU2OTp6Cfr5SVLENaW13XWevdP6jnhxyWk+fddXfd5LhXW99NF1M6h0kly5TSW2eoNQas/ gbaSWnkidmole0hsbM/mye+ccKYL98ONHHZqt9ku9VU3SJgcyGQNDSfYkK8kk+kR6X1/XWa4Gfrd Ixx+ZpK63UG8tdX259PB1sDxg5K4vRm3F91Nqn+DQUskD4n/AO0SyNIETc8nn+Sl3UPw4xQ2atks N5qKu5QNy2nlY0Nd7jqH0TkaRXpPcKus1xdM57nseckErrtRbzVlfbX09OXsDhg5K4XRO3d91Vqf +EUtNJC+N2KiSRpAhbnkn6+ylnUnw5OprNWz2O8y11fAMtp3xNaHe46s+30TkmkcaR3FrrNcHSve 6SNxyQT5XW6j3orK+3SU8Be3qGPmKj3Q23971bqMWmjpnxPY7FRLI0gQgd8/X6KV9T/DpPRWWsqb JeH19bTjP4d0QaHY7/Nn2+iSmo4HRm5FZZa90kznvY4579iuu1RvTVV9ufT05e3qGMkqN9CaCvOr 9RC10MDo3MdieV7SGwjzn6/RShqz4d6y22WrrLRd/wCI1NOMmn9EN6gO/Oe+Porsscdorcqrstwc +aR72OPVweQV1urN66m4258FO6QFwxlx5UYaC0LedZX8Wy3QOjc12J5ZGkNhHnP1+ikzWPw9XGzW OqrrZdW3OWn5dAyDpJA7859klNSOc0TudV2euL53PdG45+xXUat3rq7jb309M+Tkd3FRhoDQl41n fBb7bC5ga7E8z2npiH19z9FImtvh/u9islTcLdcY7qYMl8UcJa4Adz3TaajSaF3Oq7NWuNQ9z4nH OQeQV1Wsd7ai4W11PTPkHV5ceyinb7Q131re20FqhIYHD153N+WIfX3P0Uga52CvenbJNcaKtiuj Ic+pHDGWva0dzjJ7JKung0HunVWWsd+Je50TjkOz2K6bWm9s9xtzqelkeSRySSop290Ndta3n8Da 48NZ/vp3NJbEPr9fou415sRf9NWR9zpqmG6RRk+qyBhDmADk48pyNR89v91Kmy1TvxT3OYTkEHkF dRrbeuS4W98FLK8lw8nsoh2+0RdtbXj8BaIwGt5lneD0RD6rs9e7H3/Sll/ijKiC5U7HESinaQ6M e+PKci46erb3deezVDhVPd0E5DgfK6PW+9r7jb3QUr358EqINvNEXbXF5NBZ42jpGZZng9EY+uF1 mvtldR6Ssn8Umlp6+maSJfw4JMYHk58KbTTa7d7sz2ioc2skcWk5a4HkFdDrze19xtxp6SRxzxk8 KG9vdE3fW95NBZY2/KOqSeTIjjHjJAPddNuBs7qXR1nbcqx1PV0od0yOpiXen9Tx2V5LxdFtzu7N Z5S2skcWZy1wOcLoNf72uuVt/D0byc+cYUL7f6KvOtryaCyRNLmjqkmkJEcY/wCIgHuug1/tLqbR tqbcblHBPRl3S+Smc54Z9XZAwE5HF122+70tpkLK2R3TnIdlb3cDeo3K3Gno5Dj37KE9v9FXrW93 NBY4Q4tBdJNISI4x/wARAPdbrcDarU+jbbHX3SKGWjc7pMtM8vEZ/wCLgYCcji7rbbeB9re5lbIQ 3/C5bXcres3K0upaCUknuQMKFdBaMvWtbuaCxwB8jQXSSvJbGwY8n6rba/2u1Noy3MrbvBC+le7p MlO8vDP+bjhORr4cBcal9VUySSOJe93UT7lfCF/TKDnGDwVi4HJzyUgOVh0WL2k3gdZ6ZtLcJCOk Ya49it5uRvQ2vt/4ahlBz36eAoH0Ho6+ayuDqOw0pnkYOp73HpYz7u91sdc7e6j0dFDJfKQMil/L JG7raPuRwFqVixL22W8YoIzFXSgHwXdl7dyN5211D+GoZAc9yzsoG0PpG96vr30dhpTPIxpc5xd0 tbj3J4yvTrjQ2otIOhbf6IwMmHyPY4OafpkcK7TSadst420NO6C4yhp8F3IK++5e8rK6hFNQSgjs ejgKB9FaTvmra99LYKR072DqcS4Na36EnyvrrXRuoNITQxagoX0/rDLHhwc136jjKbLE47Z7xRUl M6C4SgHGMP5BX03L3hZV0IpbfI3pHGGcAKBNHaUveq6ySmsFG+pkjb1POcAfqfK+utdI3/SVRDBq CikpjM3qjOQ5rh9xxn6JyhpPW2O78UNE+muMjQcYLZOWlY7l7vx1FEKS3yNawDGI+G8dlAmjtLX3 VNTNBp+hkq3xN6n9JADR9z5WWs9LX3S1XFTX+ikpZJW9bMnIIz7jyryNLA7abw07KB9NcpG4IwWy ctOe6+O5m7sM9Eyktj2hg4DY+GjHbsoB0npm+6mnmi0/QTVj4QHSdGB05OO5Rq7Tl701VxU1/opq SaRgka1/+IKcocasXtpu9S/w11Lc3tII6SyTlpz3Xn3O3ahnpGU1tc1kbMDpZw3jsq+6X07e9RyT x2C3z1roAHSCIflBXy1NZLxp+rbR3yinoqh7OtrJW4JafKsyiaWW253bo5rW6kuj2PBHSY5OWn3X j3Q3Zglpo6W2ua2NmAGsPAwq86ZsN6v800VjoJ618LQZBEM9IPAyvlqK03ayVoo71RT0VSWh4jma QS0+R9FNz2uqs5t9uvQVdndR3YxPZjpdFLy0+crX7obrwSxxU1te1sUeMNaeOFXjTlmvN7lmZY6G prHQgGT0W56c8DK+N8t9ytVYaS8UtRSVPSH+nMwg4PY/ZXcTVWk0FupbrjZDR3b05WYDXRS4wfK1 W6m68UjIaa2uAjjIw1p4yFXbT9pvF3fKLPRVVWYQDJ6LSekHtlfC9Ulwt1Yaa5009NUAB3pzMLXY Pnnwm4aq1uh90LbdNPiku4jmYQGOik7cc/1Wm3S3Wif6VLbXgQxlp6QfIVcrHQXa4ul/g9FV1Ziw ZDTxl/Rn3x2XmujK2mqXQV0UsM7eSyVpDgksnZra2uitz7VeNPikvIjmjOGuikI7g5/qtHulurC5 0VLb3gRRkOABz2VcLLR3auMv8JpKyq9LHqfh4nP6fvjsvJcXVcdQ+GsbLFMw/MyQEOH3BTcXS3Oj 9yLTfdPCkvLY52Dpa5j3Acgg5/daLdPdSB0kNLb3gQxkOLQfZVttEF0qzIbXS1tR6f5/w0Tn9P36 RwvNWyVAnkjqQ9kzTh7JGkOafYgqyyVLLVvtMbgWbUOm46a9NZOwFvyuODlpyD+657dLdSH14aW3 vHpRuDukfRVrtYuc5eLdFVz9P5hAxzsffC89ZNUetIyoD2ytPS5rwQ5p9iDypuGquBp3Xdk1RpqK mvbWzNa5uASAct5B/dc/ufuhC2eGmon/ANxG4O6Qe+PBVZrbNX5P4MVD+nv6TScfsvjW1M75SJy/ 1GnDg/IIP1Vlk7LjauHZNaWHVem4Yb21swY5jgCRkFuCDn7ri97txqept0lroHj0SMdLeOMdlXai uFZCAIHy98fJnk/ovNX1ksz3eu55eOCHdwmOfG7jN8fLqvJVkOkJ+q2ujLs6yaioLgz81PIHhaVx z3Qzh3C527rvrUXdtuqNPaz0/SPvOHvie17S085Hv+q53cXc6lo6+jpbeW+hC8ODW8YA7H75VXbf eKqjZ0wVDmN9g4hYVNfNUv8AUkk6ifJK3LHOy/C51DftPays1FNeMPkp5GvYW4yS3B+b3BOeFzm4 e5lLR3Gkp6ItEMDwWhvAHsVWCivtZRsDYah0YHs7C89bcJql/qPeXOPknKTRqrnQXfTusbVQVV3c 10tNI17SMZdjB+b3BPhc1uBubSUVzo6ekc1sFO8FvT4HYH6KsNBf6yij6Iqp8bR/h6sLyVl0nqZe uRxe4+Sc5TpO1047lp3WNvoKy5vaZKd4c3HPUAOzvcZzwua11uXS0N4oaejc0RUz/lI8cYz+yrDb tTV1DGGQ1JjA/wAPVwvDXXOpqZvUkkL3nuSU6O10vxOnNY01BXXBzPVheHAD/wBoAOzvcZ5wub1x uTR0F5oIaVwEVM/jHOOMA/sqyW3VNyoYWxw1LmMH+HK11fdp6qcySuc55PJTr5S7+F0pv7PawZbr lVyND4X5LO4kAHY/TPK53W24lHb77bo6Yt9KleSOc44xn9lWW1auulDAIoKpwYPGey1tfeKmsmMk sjnOPclJre6u7rS59RBp7V0lvulTO1jo3ZfHnIlaAcA/Y8/oud1juFR0Go7ayIs6KV5xzkZIxn9i q1WrWdzoIWxRzkMaO2Vp7leqirqXSyvJe48la3Pliz6XRr6Oxavlt90nq/S9M5kiB4maAcA/Y8rn tX69oqDUlrjjLOikecHOeSMf0VarRra7UNOyKKoPptGBnnC1F0vdTWVRmlkLnE85Ux1LtvK3KSLl XG12bVtwt12dW+lGzJmiDv8AegA4B9sHlabVuu6Ki1Ra2MLemle7GfcjH9Cq22vXl2oaRkEcxLGN w3IytFcr9U1dSZpXue8nJOVrl9ucwk9LmXe0WvVFfbrn+M6IerqnjDsGRoB6R9MFaXVut6Gl1Tam tc0/hnuIJ9yMc/oq4WvcG60dLHCJcsY3DerK0F11DU1dZ68kji8nPJWZqOmUuXS4d40/b9SXq33a OuApnEOqYRJguDQS0j7HC1mqNa2+l1jasEEUxeAT7kYVc7VuNdKOkZCJOpjRgZJOFzlz1FU1laai V5Ls54PZa5fbnwk9LjXvT1NqK8Udyp67/Y5fmqI+vB+UZaR+o5Wv1NrOgpNVWxrXNJpy8Ak4zkYV crTuVc6Slig6+pjGkDqyucu+paitrjPJIesnPdSXXtuxb+96Zjvt6p7jS1o/BzgPnYH45aCWkD79 wvHqXWNBSartjeoEQB7CQf8AMMKu1n3NudJSshe8vYxuBz4XL3jVFTWVxnc8lxOe6sv2mqt3f9Mu vl7graOt6aGoAdOGkZBby0geRxgr437V9vpdX25rnNcImPiJ6u/Vwq8WrdG401HFA5xcGt6clx4X KXfVc9ZX+s6Ql+cjnspIt38LaX7S9Rd7+yro60i21DRNN084c3luB5zjCyverLfS6woGPeCGRPhJ z36sKvdq3WuNLQxQyPc8Mb0g9S5G7asqa65euXkOByDnla9+1m56Wxvmma25X/8AE0VaRaqoCokx yOtvIGM85x3XB/EbdqWqoaenikBfFnKj+z7tXCnoooJXvd0M6Rhxx+yj/Vupp7vUufJI5xJJ58Jj lx7Zyw5dOYqcmV3tlfA919HnJ48r5nOVwdyR5R5QEB5SWXv5SPdAkICCgChJNAkBCEB5QhCAykn5 QVQI8IKEAe6SaSBpYR4T8oEmhBQJMIyjJygCkE/CSBjul5TykgaSaRQBQUIQH8kI8Ix4QB+qEHsg oEg/dBT7BABHZJCAKDlHlGeUCRlGEIDKBz3QO6FQkJ5QgCkhCAPKEFHlAs900eUH2QIgIR5QUQkD unhCAKXlNLyqDCMpHshUdHcKvokc2CMFvbK5mckzuce5XTSNDmk4yuYlJdO77/svJhdu2U0U5wxv uvMOF6an8owvMOSusc77Dlj5TcjsFUIcphJMoAZWQSCY4QeqjaDKzPurg/D+WR6YA6hk44zz3VPK R/Q8E+FLG3GupdPTsL3Ew+QCiVqtT09XDuBdIJYpI6iSte9jXNIJDnEtIHsrYaCoP4BpOndcJ3+r I0F3Xxg8cAKFtS6/sV3v9ruTaCJs1K4mSYj53jAwCfYL1a+3Tp70LdDbz6cULi55B5Pbj+SuXfaT qOi3yschuVqvEMlRNFI/05GAZZGGhuD9MqQ57oLFt2y4OJ6IIeo49sgKOKjc+zXDTcduqIjI09Pq ZdjOHA/6Lc1G5emq61/w+ooo5KNzQ0wuPykeyklXbT2l1x1PrF+qo6R0FmAiha6R2OsgBuQPIz5U ha/1CdP3WwuyemYysI98Bv8A1XJVe51gbbY6KlpxDDGW9LWcBoac4C4vc7cG36kudjdTAshonve4 579WP+iuqyk3eqoFTtDdp2ggSMjOP/ogUIbDB8uq2AAnyMeF1e4249ru23U1loOZ5gxpJPbpcCf6 L47Was0zovTckgjDrpI3L5XHknHYfRWzpWPxeuHVp5uQeZiR+yrf4XY7lauqtWXh9XWPJa0kRs8N C43wrbvTOGPGEUlkkRyo2SYSTQAWYWAX1YR7IRYH4YogLy5+OetvKmbV1VbafV8za1jH1c1GGQZa D05J7E9lWnanVJsFUPTdjLgrIM1Vpm6QUVwuYjdVUx6muwOCB5U0V11e13Vp4gdpW9X/AIQuV1XN bodY1baoMdXS0jGwBzQS3k8j2XCXjdZtdqdv4V4FLC7DADx913jdRaXuRobpcjE6rp8lrgBntjn3 wmjbqq5pFXp//m5/8DVyeqHW9usKxtUGGufSxCHqbkjvnHsuLuu60dbqdop3htNA4iMA+O2V3Bvm lrg+iu1xMZracHBGOeMc++FZGdurrBm4WHq93f8AkauS1EbcdWXBtSGm4OggEAcOWjnJC464bpxV eqWCnePw0JLWAePC7l120zWy0l4rnxCsgDsFoHPAHPvjCaS9uoq25utl6h5kP/uGrkb3HQO1XcDU 9Jryyn9AEctAPOFyVZurDWaojEDwKeAkMx9eD/RdrJXaZrKimvla+IVULTjH+LjjPvhNErqKtmL1 aSR4l/8AK1cRWQ0B1VcXSua65dcHp5PLQCM4WhdulFWalb6Tx6MJLWAfXgrsDNpmouMF+qpYxVRs OWjs72z9lr4sYyx3ZXSVMZGoreT26ZccfQLj6ynojq2ufI9rrgJ4QwE8tbx2H1Wgi3RgrtUH03AR QktaM+D3XWk6dlu7NRVM8bZ2sJLW5+bjjPPhY13tvGSSRv6kEappcAdPoyHP1XJVFPRyaur53PBr 21UbWt6uWt4zx9Vpabc+mrdTOMbm+nGSxo+h7rqXQ6edeRqKaoayUML3RgnDjjgnnxj2Wqzx9fxv pm41bAcd4JD/ADXLtpaN+qq6okfmuFaxrG5/K3Izx9VpqLculrtUvdGWmOPLG8+CeV0xpbCy+v1C +rDHGPrdEDw5w5yTn/RZsrpjdTTeSxtGrojgZNM8k+5yuVpaWjOqa2qklLq817WNb1flZn2Wrt+4 9LXane9paY2ExtHnpJXRigscN8k1A6sDQ5nqOh6v8ffJVu6zJr03rsf2vPA4pSc/XK5aio6dupKm qklLqw3Dp6Or8rM+y11t3DpK/VMskZYWt/ux79OVvIbbZ6LUNTqCSsAjkYJDD1H8+SST/LhJF23z QBrGUhoyKYEf+Irl6CigZqKerfMXVbrg5nR18NZkY4XhtO4FFX6oqJGFhYMRf90FbuC1Wmg1DV35 9cPQmaJBCX9n8kn+nCaP63cbG/2tq3dIy2mZ493Fcza6KFt/dVunL6uS4PaY+vIYwHjheWza8oq/ U1U9haWkCL64BJC21JZ7bbdRVd+krgKeVolEJfktfyXH+ia6Z+dtxDG0asrZOkAiliP/ALorm7FQ MZe2Vpnc+omrpY3Rl2Q1gPHC+Fl1zQV+pat7S0scGxfoCcH+a2lDZrfZ79W3x9dikkAlbAX5LXnP Uf6cJhNSwy7y22lJGwanuLwwdX4eHnHPcrn9NUZZeoquSd8k1RVTMcwuyGsbyBhfOw60oK/UNY6M t6HhsXHfDScf1Xuttno7FeK+8y13+yPHqxxFwJDjnqP29kzx5Y1PH1e/ptqOJjdSXORrAHmCLJxy eSub0fQuiucNVLO+Waomla5pPDWjJAws9PayoLhfa17XN6ZA2PIPbpzhfaxWSDTl1uN1q7h1Ubj6 kLHPBLSR83C1/wCFkZsvOW+tKwfFXEBuSX4wTTMB/moXj74wpT+IPUFPqLXU1VSkenHGIuPOMqLo Sepa81ly6a/x5Z45Ku18MNqgt2gzLGwCScB73Y5JXSaGop4LjTVNRUvlfUmXqZ4a0ZwFzPw+3+jb pKlonPAJjDSc9iux07ZDpqvuFfXVwfQtJdAHEZHV38rnhdYWNZ95ytpY4Iqe83t7WAPwzqIHP5Vp 9GUdRT1tLV1NSZjViQlnhob2H3X00vqe3XC6V5Y8A1BDc+BgYRp+xy6crq6vuNcJKGPJgBxnnupl N1cesZG1stNFT3S/yxsAeSCXAcn5crSaJpqqnraWeqqTL+LY9xZjAZjsPuvTpjUlBca+4dD2g1Ls ZzwMDGEtN2ao09VV1bdKsOo43EwdR5IPdW3aTps7NTQQVt/ngja1/V8zgMEnpWl0RT1cFXSTVlQZ TVxOeWdOA3Hb79169LagobjVXFsbw38S/vnIBxhfHS1nqtPTV9ZeKvqpYHO9AuxlzSO/0+yml22V joaeln1DU00TGSvlc4kNAOelanQcNXHVQPrqgzOqoTIWdOA3258r2aWvtFcn3CKJ4aamRzgScgEj GF89KWqssJrqu91YdDC9zIM+WeD9M+yI9thoaWidqCopYmMlfO9znNABz0rWaDgrWVUZuMwl/FU/ rYxwPp9ThezS15obk+4wxS9LqmRzmknPcYwvhpC111gFfV36qDooC6ODPlg7H6fZPhNdvZYLfS22 K/1FLCyJ76iVzi0YOQ1eLQ8Na2o6blKJhVUwn6ccDPg+5Xr03dqK6Q3CnikDTUSvc0nkfMMYXm0f bq+wx11TqCpDmRudFAT3MY7H6Z9knpfk7Rb6azWu/wBRQQsikNRO/LBjkNWGi4qts74bnMKj16Zl QR04A6uCOe69FkuFJeLdcaWnlDXzySOaTz+YY/kvjo+huFlpKuq1HO0mMuijce5jaeD+vsrlN49X 5c73nfoWS2UtisV/nt0EcMhnnkyxoHOOEaNbVn1YLpK2czU7Jy3p4BdkEc9+y9NmraW72250lNMG vnfI5pPI+YLzaOpa600NXV6ika0sLomE8EsaeD9iknXX262zt8bNbKWwaVv1RaoI4J3TTyZY0Al3 hejSEdXJDUUt2eycyQslLQOB1Egj+S+tpqYLvYrlR0UrfWnfI5vV2+bsvjo2Kvtlsq63UTwyVpMY B4Ja08EfQ+Fc+8evtyned39Pjp200enNJXue0U8UMxlmkyxoGXeF9tLQ1NTT1tFePTmbJE2Xpxkf N4K9Fjkp7pYLhR0kzfUle9zer6r5aNbXW+2VlbqLEUrSYwMYJa08EfRXcdbdzVeDTlpo9L6Ju89n pooJzJLIXMaAXO6uF79LwVNXT19uvjIpmSRtkMfdpDvdZ2r07rpeuoqKZhnke9zeo8cnIXz0Y+vo bZVXDUbfQlH93h3BLWk4OPqs5e2Xg09ZqHSehLpLZKWKnmdJI/qY0Al3VgLYaap5rjS3K13+KKaM sBMZ+Zpa4Z8r7UJZd9J1VJQyMM5c5zeo8Z6shfDRstfR2mpuOo2+hK4dGCMEhp4OEvbptr7BZ6LS G39fLYqWKCZ73uyxuOpxdgZWy07TyXO3XO06hghlZ0jri/M0tcM+V9KfF00bUUlA+N9Q0ktDjgfm 6l8NGzV1PZam6agaKd8rOnB74HAOFNMytZp6y0ei9uaqWx0sUMzyTlrcFxL8DP7raWKldeLLc7Xq GnhljA6XRH5mlpGR3X3gb/ENDvpqFzJahg6gCeMh3Uvjo2oqodO1FzvjG08k7eR24GQOE0tabTtl otD7bTTWSmjimcMktHLyXgc/uttaaMX/AE5dLbqCmiljYeh0R5GMZC9DGfj9Cup6IsmnjaHdBPGW u6sfyXz0fVVEWmKi6Xljad1QOpwPGOMDIVnpjve3586hoxQ3msp2D5Y5ntA+gJwvHSxGWdjG93ED 9yt7rstdqe4lhy01DyCPuVrLEAbnSg45lb/VZy+dOuHxteXStnp9C7X0ZstJG2rlji6yBzI95AJP 15W5Za4tV6Pudr1DTMf6LnRFh5ILRkHK+s/qVug6V1rDZ5qdkcgZnuWc4/kvRpOpmGl6i53aMUsl WTKWu4xkYH2WvHNeOb9uGf8A8mTQ2O00uhNuKUWKkYJ5RG08cvc84JJ9+V7prPT6v0TX2/UVIx/o OfGWE5LHNGQQR57L31zZJ9E0slAxlRLStZIWZ8sBOEaYmmOkKq4XOMUr6zqm6XcY6hgLNllmnTrV t9tBYrVS6D25omWOjaaioMbTjvI95wTn3Xru9jp9Z6DraLUFM0vgdIwDOSxzRwQfde+8vmGh6Koo YhUy0QZK5g55YDlfTTdRLLoqqrbhGKZ9aHyhrjjHU3AXWTUlcsv2tlaOwWaj0Bt1QQWOkBnqDGHE fmke/guyvtqCw02ttAVdPfaZpmpjI1uTksewcHK2t7dKzRdDVUcX4p9EGyuY3n8rTn9k7FK+XQ1V V1jRTPrhJKGuOPzt4XP1Zp1vqtFYrNR7fbe0EFkow+epMYef8Uj3jk5T1Tp6i15t3UtvNN0z03qe mTw9jmfVbrUU0lPo6grqWE1JoemZzWDP5WnP7LK0Tvl0FV1VUwQOrWyytaTj87eF0mtRnd3WksVj otAaCt9NY6MOqKtzGvI5fI9w5OV89X6coNf7eSPu9MWVNKH+m/s9jm8clb/U1RJR6Wt1fTQmpFFi VzWDOMNx/JY22V82gKyoqGeg+sEkrWnj8/IwsSdt2tNZLJQ7e6Ft1LZKIvnqy1ry0Zkke4cnK82u tMW7cPbx9RcqcxVlL1+lKBh7HNOMH/ouj1fVGh03bbnDEZ46EtleG84AbjP7rChldPt7VTSsMDqo vlax3B+Z2QrqJtqLPY6DbnRdBSWWiL56t7Q9zRmR7iMkk+ey8O4uk7duFt6a6rg9C4UwcYZgMPaQ 7Bafcd+F1Os6z+HWO2XRsRnioj6jg3n/AAFv9SsIpHSbdzySRmB1QXSNjdwfmeDj+azoaa2WOg23 0fQ0dlpHGerkDXyMGZHuLckk+ey1m52jrZuBoJl2nhNPcIG9UUrRh2A7Bafp34XX69ro7ZarZc3x OmgpHFzunxmMtHP3Kw5O2p62GJ0o6wx3B+aTOP2K1ro3209vs1v220pR0NlpX+tVuDXPjbmRxx1E nHfgFabdbRds17oyC9mH8PXRgOZK0YcWlwBBXZa9r2WiG1XSWJ8sFKXl3QM4LmFg5+7kTAjbeIOY YnPDSGOGCMyA4/YpOmfd7aWitNt2z0zRW+y0r/WqnYdIxvVI8gZLjjvwCtBu9oS2650nTaggZ+Gr wGu9RoGXtLgMFdxuBco7I62XWeF8tPTdeS0ZALm9IyfHdZSt/wDqbU7egsLmx4a4YIzIDhXGSSNf O2hobTbNstP0dvstJIZ6k/NIxvU95AyXHHfjK5vePb62a0sFLqOgYKW5SenmRrf941zgPm+oC7/X 1yhslVb7pVQvkpoWSNJYM4LgGj98oqIyNu6BhYWHEOGuGCPnBxhZk1ZHPHu3d+Wno7Rats7DQ260 UhNTUHDpGs6nPLeS4jycZXJb07c27V9po9S2topLhO6MPc1v+9a9wHzfUA91I24Fxp7NV0FxrGPd DFFI3LR/idgD+qwq43N2/tLelwIMHBGCPmC1j1ZNdLl33vtqKS02jbOw0NstlMXVE3LpAzqdIR+Z xHvhcdvVtrb9VUVFqWzhtHXVLo2yENyJQ9wGXfUDypI3AutLZbnRVtc1zohBIxuBn5nEf6LKvhc3 QVnZ0kdLqfIPcfMFNas66Je7209FZ7RtjpyitlFC10khDpJXMBMjgfmcfrhcPvRtfRakioNR2Hpp KmtkiZMA3IeHnHUfqAVJ+4Fzo7TX01VcBmH8O+NoAzlzjjC+lVHjRtgZg4EtNn7ZCYzd7btaGis9 j2y07QWqGKOSSRwfJLKwEyOz8zjn6KL/AIitu7e61s1lYWtgbOGuqIQOH9XZw9ipo19X0Vtu0U9x b1wupHxAdPVkuJHZc7upGP8AsUiYeR+HjH8lvxYzLOSuflzuGFsUneOlxC2mlrPLf7/QWuncGS1c rYg4jPTk914aloEhC7jYyP1N0NP8cevn+S8/ltxlserxyZWbWdtmntNbc2CgtTqaGWaZwkmfM0OM juzjz9B2XA7ubOQ3K7W68aVMVLBc5GtnhcMNa53+NoHbjHClbXtTb6a8yPujWmF1udG3qbn5nOI/ 6fsvfV//ABH0s1vLTJCP5BdtTUccf2unLWrS2ldA2OgtVVSU01RMRJM+docXuwA45Pjjso73Y2ZZ UXy3XDSxip6W6TNZJERhsbnDPU0DsPope3Akt8dynddAwg27oh6hkh5eeR9ey2lyBNLpdrR/7aP/ AMixvpuSW9uKs+jdJaItNDarhQ0lTVSuEskk7A5zjgBxBPjI7KOt09lurUlBVaXMUVFdpQwxu4bC 4gnIx2GApf14bcbtWfxQR4Fva2Eu7teXnBH8lvq9vUdMN7gStI/SMreU1I44Xl7cNadDaP0jaaC0 3O30VVUTHrkknYHO5aM4d3xkKMtzdk5YNTUDtLOjFuucoY1rzgQOIyf0wpl12KB12uAufpj/AGFg gc7u15f4Pgro66Pqn0w13P8Ae5/aIrn3Lp1xxmpXAWXbzRelrVQ2i7UNJXVcxL5JahgMgyOcOA5G Rx2UWbi7J1FDqygi004Ptlzl6IxIead2C4jPkYHCmjXQon3q6muLGvbRR+g53cP688fXhdPco+q4 6X6hn++J/X0iutw1qfxxxvKSuCs22mitOW+itd2oKavqpjl81Q0dYyM9x4zwop3A2Trbbq6ipdOu E1tuUvTD1uwYDjJB9xjsVN+voqKS7XI1xaJY6OL8OScFry/x9V0d0aDedMdQyfVcf/rRWMfeq6X1 Kj217X6HsFHQWu80UVdWy56p5eHDIzk4xxnhRLrzZe52vV1NQ2ICqobg8imc5wBjIGSHZ8Adips3 Cgin1JWvke1kkMERiJdggknOPuuwu7A6/wCmCRkiV/8A9iK65eOTX9jz+LyXPe/i6R3adpNFWiit 9vvlK2rr3g9cxeWnkZyQDjHhRFrbZy7WnWNNbLQ38VS17z+FkJx04GSHfYKedw6WmqL5cJp5PTqK eKD0D1YwSefvkcLory3/AOGjS+Rz6kh/+tlZwx77bzz1OvtHlr2g0Xa6Ogt98hNTcZGkPmErmc4J yQDj6KINZbQ3qzayp7Rb2Grp615/CT9h0jkh31A/dTzuBBDPqCvmklcyopmQ+hh2OS7njzxldbem tOrNMZGXdUpH/gK1fHrX9Yw8vLf8uka2vZbR9vo7fQ3wPqLm9pEk8czmBx5IPTnj/wB5Q3q/aa+W TV8VnponVcNU8/hKhreHtHJz7EDurE62pYai7XapkleyqpPQ/D4kwPmcOrI88FdReQz+1enOpuSD K4fQ9C5yXenbK6iK7VshpSjpaKivUs89zkY4SSslLWlwBOenx9ueyhrVW1l+surW2SKB9Z67iaWa NvEjAeSfYjz9lY7W1Iya6XSu/ESR1NHJC2JrX4BBI6hjzwV1l3ia7VlgkLQXNjmI/wDCrYRE1t2J 0zTU1FS3atqn3R8REjo5MML+eQO4Hb37KGNS7aX2y6sFk/DyVMkrj+HljaS2Ro8/oO6sprSl9e5X OvZUTR1FHNE1jQ75S1xGQR+q6u7RNdq2ySdIL2wTkf8AhUVEVv2GsMNHQ090uVWLrJCfUDHj0y/B PAxkDt5UL6h25v8AaNUOsrqKaeoLj6T4mktkZn832HlWa1bTyS3G43GOqkimoqmNjY85a5riAePf ldbdYmO1daZOkdbKWY5x4wFdLJtDNBsBaxbaSG4XitivEkBMjGFhiD8HtxnHbyoYvegr3atUusc9 HJJXZ/u+hpLZG/5gfb3PhWg1bT1Mt0rLnBWPjdRVUUYhxlr2uIB+x5XV3WGN+s7ZI5jS9tHL82Oc ccKTtJN1CtJ8P9G+20kVdep6a7yQF0kbA10Yfg8DjOO3lQteNFXq06oNiqqR5uIdhjWjLZATgOB9 vr4Vp9TQ1b77VXKmrHxmjrIoTD3a5jsZ+x5XV3SCJ2tLc9zGF7aOX5i0ZxkcLWtGqg+j+H7rtVMK u9yU91kgL3whjXMDxngdiR28qCtVafuGnbvPbrpAYamI88cOH+Zp8gq3Wom17r9UXCmrCyOjrYqc wY4c12Mn78rj/iloYZaa2TiNpmY1w6sc4z2W54+XTFz46tVXJ5WJX2nbhx+6+K4O5JJlId0AEEcp 4QFdBeEIQeFAJeUDlCA8I8oQgZHskAgoQCaQQqAlCWEIGhCECQml5ygPKZKPCWEDHlBHsgDKflAk FB47oKAPZCOyD2QCR7JgIwUC+6D7JoCBcnGEyjCCAgRKCmfukUBhBCEeUCR4TKEGKAn2KEASkE0f RAvKB5TCXhUIpo8IQJCaQQCEfQJIGhBS8IGe6SE/KBE4R57oPCMIgSPdNLGVQBHCEKo6OU/LkE+6 5iRp/EPyc85XRSO4JIzwucf/AL1xzzlePxvRmKjhgK8oznK+9T+QL4Bdp6cr7IpJuS8qoEwl9ghB kEx3SCYQZNJ48L3RPkJa2Pqc53Aa0ZJP0C8ULetwHc5Vm/h82+tzaMahuUbamqbzE1wy2P6/dWJU EXC13i3R0/8AELdXU3rnpi9WFzfUPHAyOe4SrrddbW2J1yoaykEuegzxFnXjvjI57qZrxroai3Ao ZqpoNFQyubBETkB3AJ/kP2Ur690XT6/t1onklLJKV5kaAQW4djqBH2CbRUiKgu4pBVfw+v8AwryA 2YQP6DngYOML2NsuoWjP8Hu5GOP9kkP+itRuDd4NNWm1WWjDTJK5oZn/AAhpHOF1V3rbhFpeGpt4 fLXSFgAHnqOD/JN0kUoqrfe6WD1Km23KFmQ3rkpntGTwBkheKthr6AsFbT1VO54JaJonM6vfGRyr p1F2jrmMtlY5v8RiqIhLEHdWCDlfXcTRFt1ZTNjromOnp3l8TyASMHkd+xxyrKaUlfTXBlIKt9LV CmOMTOicGc9vmxhfKKOuqYpJaeComhjGXvjjLms+5AwFbXe+jjpNnZqUta0Rup2lrew+daHY2+Uc 1pFh/DRNje0sc1rQA/Iwc++Ut1Npj+3pViR2cHOR7rBShv7oii0ZqaJltcRT1jXTCHHEWHYwFGHb lXTRJJ+yR7qBfRMIxhCBpgkdklkEHqpJ3xvBaSMey2T71UFha6oIb7dS3O2GiKnW2oI6KN/oUrSD NLjkD2H1VpoqDSmkpKDTkFupS4NDnGSJr3OyO5yFNim7a+SORr29XPkFe598qnR9HruDfbqU7632 NFbrSkntNRHTWy4yF0sePmjOAXFvjnPbwpCjs+j9NOodNx22ke8NBcZYWvecjuSRzlXbN0p42rlZ KHteSfuvbJqGrMPpGpIbjGOrCm7V2xjqvWtN/C546a11zi+RpHzR4GXdPjnPHspHg01ofT0lJp4W mgln6PmfNA18jiR3yRk5Ta6inkNfNFO18ZIPfIK2Uuoq18JiNS4NP+HqUyan2Kml11TxWyeOCzVh Mjv88eMFwAxjnPCkmn0noSzS0tgNooJ5wzBkmha+Qkjv1HnKu2bqe1QoLhPFOHMcQVtJdT3CWD0X Tu6O2OpSxf8AYaq/tzT0tunYyz1Ti/rcfniaMFwx288KUKfQ+grZJBYTaaKao6C10ksQdISR36u+ VOTWlRqe51ME/qxvcHZzkFbSXVdympzE6ocG4xgHupOuewtd/bqK30VQBZpyZPVcfnjYPzNx/RSr BoDb+hkjsTrVRy1HpmMyyNzJnGM59+UtrMVIprpUU1SJY3uDs8rcVGr7nNS+j+Ic2PtgFSFXbC3M a6ZbKWYC0SEv/EOI6o2DuMe/spYi2z0DTvFlNspZKr0zGZngl/VjGc57ptrSp1JeKmkqxNE8h2e+ VuKvWl0npvRM7gzGODhd5UbD3Y65baYZOm1uJf8AiXEFzWZ5491Lce1e38bxZ/4bA+rEZj9dxPX1 Yxnv3TaaVRob3VUVWJYnkO75J7reVmuLtUUnomQhhGOCV17ti7ydeusrHdNuB6/xhxkRZxnHupe/ 7JNA82dtE11a2Is/EGR3V14x1Yz3zymzSq9sv9XQ1frRyODieSFva3Xl3qKUwuneGEY44XTR7HX2 TXj7DktomHrNYQMGLOM49/ophfs9oMxutMVKTWtiLPxBld1deMdWM4znnCbTSr1r1DWUNX60Mha/ 2J4K39w3Bu9XRmIyuYzGDg+Fu6LZK/z66lsLwWUkRD3VpHBiJIDgPc4PCmKbZbQ0kL7ZTQvFwbF0 +uZnEl+MZx758JsVjtGpay3V3rQyPBJ554K6K47j3esozB1uYwjGQStnbtldQVeuJbC9pjp4SHPr CODETgED3OOymSo2P0U+mlt9Iyb+Isi6RO6YnL8Yzj7+FZS6VqtGp6221n4iGU9WckE8FdDc9yrt WUZgEhY0jBwfC9lm2Z1DcNaS2KSMwQQkOlqyOPTJIBA9zjspjrdidHyUU1Bb31DboyLDZXzEgu9y 37qW6uiavcVwsurK2113rxSO6ieee66O77n3asonQB7mNcMZB5wvpYNnNRXLWU1imhdTspzmapc3 5QzPBHuT4UxXLYHS1RbqmjtdRUsu0cQ6ZHy9TS/3IV2XSvOn9X11prXTRSOPUfmaT/NdFe90bpXU Bga5zGkYJDu4Xz0ttDqG9awlsc0D6VtOc1FQ9p6WszwR7k+FMd5+H/Tc1pqqayVlSy7xRgsfLL1M LvqMf0U5a6pJLNxX/Tms660VpmY9zge4JXR37dO63G3up2udGxwxwfC82ktpNQ33Vz7LPTSUjad2 amd7SGsZnuD5J8KXb58Plhls1ZFYq6rN2hYCwyyBzCfqFeVLJFWKyZ08rnPcSScledpLXZWxv9pr LLcpKG5QPhqIzy1wIz9R9Frlmyy9tSyzp2miNZVmnJ+qFxdEe7crr79u5crjQOp4i5jXDB57rlNr Nvrrr2+NpKFhjpIyDU1JHyxt9vupr1H8O1ubZ612m7pV1Fygblkc5aWuxyRkfRXZpEGlNe11mrS/ rc9pPLSV0mot3rjcaB9PGXRtcME9WVzmg9sb7qvUxtTKaSlbA/8A2qaVpAib579zjspX1P8ADtSR Watk03dqmruFOMthm6Q12O4yPOPoptLEV6R3ArLJWOe57pGOOcE8grptS7wV1yoH08LnMa4YOTyu S0BtrfNX6k/hsNPJTRwvxVTSNIEQB579z7BSvqv4doqezVlRpy7VFbX04yIJmtDXAd+RznHbhXaa Rno7cSsslYZC9z43HJ55yul1TvBXXO3vgic5gcOeVx23u3F61lqH+HUsD6eOJ+KqeRpAhHkfU/RS lq74eHUVkq6nT12muFXT8+hIxoDsdxkdjhXZqOA0ZuNWWWrc57y+NxzjOCCul1TvJV3GgdDC57eo YJJ5XDbebd3rWV+FvpYH08cb8VM8rSBEM8j6n6KTdafD1NbbJVVljuklxqKfkwuja0EDvz7pssji dFbk1dkrHGZ73xuPUDnkFdLq3eWquVA6ngkf8w5LiuA2928vOtb9+AooXQRROAqZ5GnEQz/M/RSP rT4fay0WWets10NzkgJ64vSDDgd/KbTpy+h9zauyVTjNI58ZOQc8hdHq/eerudA6CF8oyMZcVHe3 egLzra9/gbdEY4mOH4ioe35Yh/qfopA15sDcrDZJbhabj/FvRJ9SNsXQ5oHc9yky+CyRptCboVNm qH/iHvcwnIIPIK6DWm9FTdKE09PJIAf8zjwo4252+vGuL0aO3xmKGIj8RUPb8sQ/1P0XcbgbD3jT lmfcrdWsu0MRPrMji6XMA84ycqcjTxaE3RqLLUFtTI90ZOWuB5BXQ613onudA6npZH9J8kqM9uNB XfXV3NFa2COGPmeoeCWRD/U/RdnuFsbedK2I3SkrY7rBGSJ2xRFrox79zlWVddMdAbpz2eVwqZHF hOQ4HOCt7rfeae50BgpZH49yVGG22gbtrq7uo7W1scMYzNUyNJZEPGfc/RdbuDsjfNJ2MXSOqiud Own1hDGQYwPPfkKbSR69vd1prRIW1cji3uHDut3rnemW6UPoUkj8e5UV7b6Du+vLuaO0NayNg6pa mQEsjHjOPJ9l1G4ezF+0dZW3N88Vwpg4iU07CPSHuforMlsbfbzdma0Pc2rlfjOWub4W415vPJda D8PSSOPPc8KKNutCXjXV3NHZ2NYyMZlqJAfTj9skeT7Lodw9ndQ6OsrLnUyQVtN1dMrqcEiMe5z4 TkcXSbd7ty2l5ZWSuAHZw5+62uvt6JLpQ/h6OVxAPfsoj250Letb3V1FZImAMBdJPKSIo+OMkA8l bvcLaXUmjLVHcbh6FVSPcWvkpS5wj9i7IGMpyNOx243dktPUyulIx+Vw5W01/vQbpbvw9JKXfphQ /t7oa9a1upo7JC35B1STSkiNn3IB7rcbg7Wak0Xb4665xwTUjndLpaZxe1nt1ZAxlTkad3tvu8+1 h0VbKRj8rsr37h7zOuNEKejl6gO5Chzb/RF71tc30ljgDvTBdJNIS2NnHk+5Wz3C2w1Lo2jiq7tD FJSvODLTuL2s9s8DCvI0kbbbeAW1joq6UsPhxPC++528rrna3UlDODngkKHNv9EXvWtydSWKnD/T b1SSyHpYz7n3Xv3B231HoyCKovFOx1O//wBtA4va37nHCbNOFuE7p6l8jzlziSSvnTSmKZrm8FpB BXyf+Y590D2HdYdFlNp94DbaIU1wl6XNAAcexC9u5W8f4+kFNRSAg9yOAVB2gtF37WNXJT2Ck9Yx t6nve7oY36dR4yvTrrQ2oNGywMv9IIhM3qY+N/W089sjytyueU+01bb7xR0cBgrpQ12MfNyCnuTv EK+lFPQStIHHy8BQhofRt+1hVyw2CjdOYhl7y7pa36dR4z9FnrrRl/0dUQw3+kMHrN6o3scHtP0y OMpuGqnLbTeGKmpHwXCRoOMEP5BXy3L3fbW0zKageOkcYZw36KDtGaRv2rqiWGwULql0Qy9xcGtH 0yeMp620hftI1UNPqCjdTvnb1scHBzXDPbI4z9E2mk+ba7wRQUBp7hI0HHSQ/kFefcrd5lXTMprf IA0DHSzgDCgrRmk7/qqomi0/QyVToQHSEENDc/U+fostaaWvmlKyKlv1G+llkYHsOQQR9xxlNrpY Lbbd2mFvdTV8jOR0lknLT78LxbnbtMqIY6a3va2NoA6WcNGDwoJ0jpi/anlnZp+gmq3QAGTowA3J x3K+ertOXrTNaylv1HLSTSN62h/OR905Q4rGbcbuUzra6muMjDx0mOTkH6rw7m7tx1EUdNbntDGY +Vh+UY7KBNJaav2pZKhlhoZqx0DQ6TowOkE4HJXy1PY7vp6tbR32impKhzRI1kg7tPlNw1Vk9vd2 aSa1mluT43ggNdHLy37rXbn7rx1DIqa3Oa1keMNYeAR2KgLS2n75qGSdthoKisMABk9IcNz2Xn1F arrZK80V4pJ6Sr6Q/wBOZpBLT5H0TlEsWd2/3Woauz/hbo6N4wGujk5B85Ws3O3YilZFTW9zRHHj DWHjIVfNM2K9X2SZljoaisfCAZPSbnpz7r4X63XOz1ppLvSz0lSGh3pzNwSD2P1CbhqrSaE3St9f Y/wt1MUrCA0xS8jjn+q0+6O6kcroaegeBFHghrTwCFXrTlnvN6fMyx0NVWOhAMnoMJ6c+6818o7h ba19HdaeamqmgOMcrcHB7FJlCy1azRO6FuudhFJdTHMzhrope3Bz/VaPdHdaKWWGnoXgQxEENB8h V50/a71dTL/BqKsqxDjr9Bhd0/cjsvHdo62jq301wilhqWfmjlaQ4JuGr6W10buZbLtYBS3YRTR4 DXRyEY45/que3P3VjkmhpqB49KIhwaDxwq72GgvNx9R1moa2r9LHWaaJzw3PvjsvHcBVQ1csFayS KojOHxyAhzT9QrLCyrdaT3HtV60/HTXZsc7flBjeRwWkEH91zu6O60L6mKmoXgxRkO6QeyrnZKa8 VgkdaaStqREcPNPE54afr0jheKufVMqJYqgPjmY7D2SAtcD7EHlTcNVb7TO4Nnv+m46e7tjqGNLf kc7GC3BB/dc5ubutCaqCCifiKNwdhpVcbNDdaoP/AIXTVk/QcONPG5+PvgLx3GSpFQ+OpD2TMPS9 jwQ5p9iDyrLCyrg2DXNk1Lp2GC8sZO1jmuaCcEFuCD+65vczdOJtbDDRSZhjcHdLT/VVstT7lIXC 3sqpek4IhY53P6LzV09T68jajrZM04c14IcD7EHsm4mquNYtaWTVGnIIbyxk7WPa5ozyC3BBz75X M7k7oQsr6eCje30YXBwaP/p7qtFuq69gzTeuQDgmNriM/ovPWVU75Xeu53qA4cHcEH6pLItlXHtO rrBqvT1K28tZOYnte3nBBb2J/VcFvhuHBV0T7XQuaYCMBrfA+qr5RXWrp8fh5pGjOMNJ7rx19XLP ITM5xfnnPdWZa7icd9V5ak5eT5yt5oK9Gwaoobh5hfn9xhc84keU43EOB8rle3b0vBQ6h09q+yUM 93Ie+CRsjC0DJLcHn+fC5rcHc2nprpSQUTmtggflobxj2KrDbr3V0bA2GpfG3PYOIC+FXcJ6iUyP kLifJOVqVzsvwuhTXrTur7fb6q6ua6ameHsLcHOB/i9xnwuZ15udT0t5pIKR7RFTuy3p8cYBVY7f qGtoI+mGpdGP+bheKquVRUSmSR5e4+Se6skS7XShuendX0dBW3MsM0EgezAB6sDs73GecLmdc7mU 1HfKOKle0Q0zvl6T24xn9lWSh1JX0UYZFVOjaOMdWFr665T1EhfI8uJ5JJV6TVXVFZpzV9Nb625O b6tPJ1tA56wB2dxyPOFzOttyaejv9BHSuaIaZxIwc44xn9lWa2apuVFEI4ap7WNGA3K11bdampnM kjyXO7klNRZv4XQe7TerPwF0rXRiaF/WW4yJABwD9PK5rWW41LR6kt7YHNbFSuOMHPJGM/sVWq2a uudDA2KGoIa0YAJWqr7vU1VSZZXOc4nJOVds3G/C6VQNPatktt1q5mNfC4udH3EoAOAfpnlc1rLc OkpNTW1sJYGUrjjnIyRj+hVbbZrK5UVOIopyGNGAMrT194qaupMsryXHuUx1Ltq7ulz6uk09qurt t3qKhrHxHrfEDkSgA4B9sHlc5q7cKlpdUW5sZYGUrzjnOCRj+hVbrZrW6UVMIoqghjRgArTXC9VF VVGSV5c4+cqyz5ZuP0ufcKCw6sq7ddZqv0/TPVLEDxKAD0g+2Dyue1br6jpdUWwMLA2mc7pJ55Ix /RVvteurrQ07YY5iY2twAVpLlfamtqjLK8l557pjZOzKclyLtaLPqe7W27muEcbT1Twh3+9AB6ft g8rS6q15RUuq7aWFhbTOcASfJGMKuVr19dKKlZC2UuY0dPK0N1v1RW1ZmkeS4nPfstcvtmYSelx7 xZLXqS7W66Nrg2EnqqIOvHWACWn6YOFp9Ua6o6bV1tEZYRTlwBcfJGFXO17g3Okpo4jKXNY3Azyu eumoaitrTPJI7rznvlZlk7q5S1cO8adoL/eaK6xVo/DSf3k8Pq4JwD0kfrjIWu1FrqjpdW28MLSy AOaCT5PCrpa9xrlTUccJeXNY3p5K5q56jqaqtNQ57i4nPfsm4Sa9Lh3nTdLfr3S3KGuxRzD1J4g/ BLgMtcPpkdl4tQa2oabV1CxrmkRMfGHE4/NwVXK27l3GmpI4XuLmtb08krmbpqeorK/13yO6yc5z 2U6atq3950xHer1HX01b/sc4EkrQ/B6m8tIHkcYK8991lQU2r6JnU0iON8JOe/Vj/oq7Wvc6409I yF7i5rWdIOe65O6amqaqv9d0h6s5HPZOl5Vby96Ydeb7FW0tcW2+domla0j87eWnHkccrC86ut9P rCiDnB3RE6EnOB8yrxa906+no44ZHOIYzp7rk7pqipra81DpXdWeoYKSG7PS2130xPdNQispa0i2 VAFS7pwSJG8gAeQcJXbVduptaULXO6g2J8JOcfmIVfbVupXQ0UUU0jz0MLQQSuQuurKmruX4j1SH ZyOVZ/Tdi1930xWXDUf4ujrcWqoLatxAz87TwMeQQO6j34jrtS1VPTwwSAuhBBPuuGt27lbBb4oJ XvPQzoGHH+ij3VWpJ7xUufI9xBz3K1jnxu2Lhy1HMzOy92fdfHys3nJWB/muD0EUkIQPKSOyZVCS 7lPskgOyPCPPZPyoEhCD3QCMoQgP1RhCFQIR4yhAIQhAFB5QPqjucoBB8IwhAISKCgZQj+iPH3QC B3QAjCAzymkhAI8JeEwgMpZ+iZ90j3yEB/VM+yDz2SQHZP2SR5QCOyD9EIAhIBNLKBAcp+UI7Kgw hCEC8oKYSQGEIQgAOEkIQHhCAgoDCXlNJA/CRQgIgRwhLsqDCefokUKjdSHqaR28rnyP7w4PGVvJ DhpPuFpHcSH2K8mDtkxqewXwAyvtUePZfBvZdY532R7pFM8pYVQJ90kxwEAAshwVj5THKD224NM7 AfdXN2XLW6GDQR1FowB37FUwpXBkjc5yFMW2O4Uun5GMqXF1P7Aqpe5pydPRVzNUOonRSw1pqCPT e0hwycg4VxdJUYsOm6WGsqHOmeG56+Dn2AUGXXX1hq9Z2+9RUEcZga71ZAPnkJxjJ+mF9db7pwXm 6259FmOmgyZADy7JCmkk1NN3vBZJafWlousb6maCofiUkZjhIIDQD4zypP1BfGad0VBcZM9EYjDs HHBOFHdbubYrpa6WkqIXSQskjke0u5PScrb3HcnS90oPwddRMmpMg+k/8vHI4TVI1ekYLledb1Oq 5KUwWusna2LrOCewBA9uO67fWWpjYtZWyFx+SoheCPf5sLmqvdOwmGlhhjDIYJGODWngBvYLg9wd eW/UGsrVXQnppqVha7nk5dlWRLUh/EPL6m188je0k0B/QuKjD4d2ul1QCGkhuCfotru5uHbNQ6Ib Z7ecyOfGSc9uk5X22/1rpnRWkXNooeq5uaXPkccue7H9FcpcsZDx/rbWh+LYg6rteCDincOPHzFQ HyF1evdS1WqLvJW1j+p5ccD2HsuUH0W8st6/hhjofdI8J590sLDQTHZCMccIGAs2jOPHKwHdfRnB CCyHwvQtbWSuDfmLgpQ1LVUEWsK2nma38fNTwtjJZkjvxnwq7bT6udYKkNa4Na488qxQ1XparbR3 WuETqyAHpcMDuMc++FmQrsapubnY8jj+8P8A7huFxt/ktzNW1sMrWfxF8cHp5b83SPb2XCVm67qv U7ZI3htLEeljRwMdlIP9pdK1DqS71bYfxtO13S4NAJyB39+y1piyXt2FW3/0vZyR4l/8jVxl4dbf 7WVscrYzc3eh0Ety4NGOx8Lhpd1zVanbK13TBG4tY0Hx2XfG/aVmlp73VNhFXCw4LQBnI8+6kmlj rq1o/j1rAB/LLnj/AIQuKqzbRqmva8Rm6Olh6cj5g0Y7fzXHjddtXqoSNeGwsPSzB4x5Xdm7aWkr Yb7VGIVkbHY6QMOJ9/crVYyltl+nU1jT/aagAb2jmOf2XHzst51bX9RjNydUwnnlzWgjt7eVyUO6 jKzVIkDg2FpLWgHwe67Z9w0wbkzUE8kTatsTuABhx+vPdY43bpLqOkmDhqyA449CQ9vquREVu/tZ cCDG64mtZjP5g3I7LmaTdKOr1OX9QEYPQ37E9l2Xr6Yiu39oZJY21IjJc0Dhx75791rKWsyR0cjS NXRHx+HeT+65KGntr9WVsrS03H8eMknJDMjgfRc7b90Ia3VD5Q4CMZYBn/Dnsuue/TMF3dqJ87Wy +mXGIHgu79Xfunbcupp0czc6ubj/AOVXE/fqwuToaagOqaqVrmm4m4/N8xJDM9sey0Fq3NgrtTSS kj0yegc89OfddS5mnKS8zai/ENZI+PrMQPBd36vummY6Inq1e/gfLTZP/iK5O3UtCNT1M7Xh9e64 kO+Ykhue2PZaWz7k09fqeeYOAYT6YHnpyulZT6foL5U6g/FNBkYHmHJ/OMku/VNG3QsAdq+pOAOm mb/5iuUtVHSDU884kDq03FwcOrJa3PbC1dn3Gpq/U08oLfTcRGMf5QeF0EVJYbXe63UBqWj1mCQx dXZ4ySVZNJe+3QU7AdWVjsD5aaL+biuWstFTN1K6pEnXVOuEjXjqz0sB4GFrbFuHSV+pKiVpb0Px GcewJIW+p6KyWW81t9NWPTmYHiLqzh/Jc79VLEnvbeQMa3VVe7pAIp4vH/EVzWnaCnZfm1IkL6uW slEmXZw0dhheCxa/orhqGpky0RyBsXB8NJx/Vbqkt9nsN4rr4azMErBI2Evz0v5Lj+qY7kM+7tuK NjWamuLg0D+4hPb6uXO6Xt8MV5gqhK+SqnqZhIHPyGtGSAB4Xj07ryhuOoKp7S0RydMXHfDScf1W 0t1qtWnLrXXo1xdBIA9kRfnpcfzFMpuU8U43+N3bGNGprmenn0YSePqVzmkrfHBcaeqM75aqeaYS hz8hoGekAeF8NM64oK++1b2ljWSYjy3jhucL32u023TVxuF3fXZpn/PHEX5LXH8xWperKmruf9Nx ZWNF+u5a0BxZHzj6FaHR1AILjS1TpZJJ53yiTqfkAAZAA8L4aV1pb7heKwsLWiUhmWn/AC8Be2z2 qj0xW3K6T1xfTO+aFjnglpPdc/Jjy9N+K8ZJW1s7WtvN76WgO6WE8f8ACuf0JQGmrqSofPJLNUiQ yBzshoGcABZ6U1fb7ldKw5az8QQ0lp7YGF9rJaKbSdXc7jU15ko8l8DXPBIz34W7bqxiY9y/xVL4 mGBu59aQP/Zt/oonjGXYHlSHvfe4dQa6rK2nI9NwDOPoo/gGJByunnylz6T/ABpcfHJV4/h5tsNs 22BgYGukiMjiByXFp5W90PSSUtbSzSVMkz6mJ75A7s0jsAud2KvtFJpKlt75A3qiDCc+cY/1XUae tA0rJcK24V4kpmud6Ac4E9J91wdrW1s8ccc+oJomAO6zkgdz0laXQ1JLT1NJLNUSTOqoHSPDsYaR 4H7r6aS1LQXOauiY8MFS8nOexIwstOWg6XFdW3Kt9Snjc70g4gksPv7K6Z22Vnp4oG3+WnYGvdK8 kgck9K1Og6OogqKeSqqJJjUwGRwcMBp9h+6+uldQUVz/AB0McjY/xT3Hq74JGMI0xa5NMxV1Xd67 1I43vbCHEH+78fZEe600sVJT36WlY2Nzp5XEtGMnp7rWaCpqmKaN1ZO6Y1NP6pBHAPt/NejTF8or tHXQRShhqJXuBPP5hjCx0ta5tNUtdVXqsEjY3OZETgZj8fbK18aY1+23rtVLHQ2+/wAtKwRvNRO7 LRj5ula/Q8FVHP0V05nNRTCd2RgAnwvVpy8Ud2pq6lilax1TI9zXHkfMMY8dl89LW6o05S1tRfq0 SdDnRxE8Exjsfpn2Ux6as3RQ0cVpsGoJqKMRv9ed+WjBz0r5aJpaqCR8FwqPxBqKZk54wAXcEfVf exXGjvtuuNHBO2N9RI9zXH5sdQx2+iw0rb6vTlDVz6hqxIWF0cRPBMbTkH9fZayu8dfO3Lh+9vxp laqGCzacv01BEyKT155MtGMuwsdH01VEaimuU4qDLTsnPy4ALuCPqvrYa6kvVquFHTztY+okkIce R83084Xz0zR1VhtlXU6gqA6QF0bMjBLGnIP6+yknWp727W7mW/p8rZQQWTR17ltUTIZzNPJlrQMu zwvvpGmqYmVNJc521LpIWTEdOAOrII+vZOx1NPebDX0NJO1ks73lrnDOOr+qx0pDV2S11VXqSfMm TG3IwSxp4P6q+Tudfbjq3Pf8YWegprJo69T2mGOCUyzSExtAy7K+mlqaofFWUV1lZUiSJsuOn5R1 dxj9F9LNLT3fTtfQ0U7RLM57ml3bk5Xy0m2ss9nq67Uj+mUExhpGCWtPH3ysz275XceazUFLYNCX SWz08VPKZZHEsaAS4u84Xt0nT1E0Ndb7s5lQHMa/HT8uHeMFO1OhvGlqyioJW+q9z3Dq+pysdIis tVlqK/UThHUHLOkjB6WnhTLvKpj6jx2u3UunNAXCSy00VNM6R5zGwDLi/HOF79M08tVTXO13kR1D AAS3GWkEfVKhLLxpKporfKw1BLnNLuxPVlfPSL6y2WKouGoz6VQ8dJDuDgHAT23t4bVbabSu3NU+ yU0VPK55OWNx1OL8c4Wx05SyVtDdLVfI4powBln5mlpGfKypui76NmoqCVhnbkt6uxId1L56SkrK Cw1Nx1BiKaZoBB4PHA4TTO2tstqpdIbazPslPHBI45ywY6iX45P6raWKkfcrTdLVfooZ2M+V0eOp hBGR3TgAumiJKO3yRvqGDIDu2Q7qWGkZqui03U3HUHTDLM3n34GBwppWqstrptHbZudZKeOGV2Dl ox1Oc8DJ/dbWy0LrtYrpbL9DDMxhMbo8dTSMZHdZhpuehXU1udHLURtBDXHglrur/RGkqippNNzX C/dMM1SA5wxgg9hkK/DHy09ltNNovbZv8CpoopXhuekYL3OfjJP6rZW+gF+0xc7ZfIIpmRl0RYR1 N/Lkd19nsfctCtht3RNUQtaejP8Aiac4/knpOonptLS3G+BtPLVfO5p4wSMAEJF+WgtVsg0TtxT/ AMApYo5niMOwMdbnOxk/XlbGChZqPRd1t9+p45BH1xlh5AwMjlemvjluGhYW2prJ6inDHdBOOWnO P5LHTs89PouquN4YKaWraZHMPBGRjstyTjjr3tyy5csr8Pz6u1KKW4Twtzhkjmj9CsLfTfiKuKId 5HNaP1OFsNS//FmrLcY9Z/8AUpaYaP47QdXYzs/qs+Sd3T0eO7ktXhtFqh0LtxbKexUjBPN6THAD Be9/BJPuvZdrJDq7QtbR36nY58BkZjv0OaOCCvde5Z5tF0dVa421MtIGy9OcflBWdllm/sRUVdya 2mnrQ+UtJxgvbgfblbwmsMXDP9sso1NntNPobby3UlhpAZpyxpA7yPeOST7r6X2x0+sdv62kv9Kx 0sBkYATkxvYOCD7rZ3uSZujKOrt8YqZKICUtB8taU7NJK7Q1TUXANgmrWvlAPAy8cLn/AOUdr3K0 lqtFPoTb+2UdhpA6Wpcxjsfmke4cuJ91nqOxUmtdu6uK+Uo9Wn9QN/zMczscra6hlni0hb6yghNU +i6ZHNaM/laQf2WVrkedB1M9aBBJWtkkDSfLxwF066YvtqLTZ6XQehLZRWCkBlqnNa85+Z73Dk5P lfPVdiotd7czi8UwE9P1+mezmObx3W61TUS0+lbfX0MJqjRYkLWc4w3H+qdDI7+wVVNVNbBJWNfI 1hPl44AWJ7brUWqy0uhNEWyh0/RAy1Tmtfj873FuSc+/C82stPW/X+3Ek11p+ippw4xvHD2OacLo NW1clDpy3XSkhNS2hxK4N5x8mP6lY0jnf9ns76hvoSVQdI1juPzHOERrLZZKPQOjbfb9P0OZapwa 7pGXyOLck58nheDXumLdr/bo1dwpzDWwAmKUDD2EHGD/ANF0mtK19vsVuu1PEahtEfUIZyPydPP6 lYRF3/Z5J67PQkqMvax3f5nA4CmlaygslHt/pG32+w0RMtW8NcWDMj3dOSSfPZazcfSlt17t7+Pr IPSr6cF0MwGHtIIBB+n0XU68rjb7TbrpDC6ojo3eoenkct6Rn9SsSXf9nT/WjMMk3zCN3B+Z4OP2 WtTUSXvtqaGzUO3mlKC32KjJlqXgOcxoMjz09RJPnsVqdz9IW3XmgYrpPB6FwjAdFM0YePmAIPuO /C6zcCtbbaC23X0XTw0pc49PIy5nQOfu5OUEbdtEsZhfJhwjdwRmQHH7FTUZlu609JaLftzpmgtt hpHCWpdhz2DMjiB1Ek+eAVpN2NF2zXejKW9Oh9Cub0ObKwYcWlwaQT9l2O4lbHa6a3XOSF00NP1j 5BkAub0Dn9VlUNMe3VPHIwxPcGfI7gjMgOP2VxkmMXd3200Nut+3GnqG1WKkeJKh3L425e4gdRcc d+Mrnd3dCWzW+mKO+xRCmuDjGfVY0BzmucAQf0XbbiXKOzPt90mgfNBCx7MsGQHPHSOf1X0q4yzb +gicwxuJi+RwwR84OEmM6c5u27+2pp7ZbtttP0FssdI4SzH5nsbl7+nkk47nGVyu8W31r1lZaLUV JEKW4yuiDnsHMjXuDfm9yAVIG4V0isc1Bc54JJYYmSR/ICQHPAaOf1Sro3R6DtjCwtcHQfK4YI+c HGFcJOnTL7aiK32vbWyUFqstI4SzHLnsb1OeW8uccdzjPK5Lefbe3auoKDUVta2juNQ+JsjmtyJW vcBl31APdSFr67QWK4UVxqo3yRthkiHSP8TsAf6rOvjdHomysLCC2SnBa4YI+YKTHWmMbu3v5aqC 12vbexUFptNN/ey4c+RrOp0hb+ZxHuQO64rerbW36pp7fqO0tFJW1b4mSkDiVrzjqP1APdSPuBdq Wy3ClrKxrjGIHxtDRnLnEDAX0roXN0ZY2FpBbJT5BHIwQmPt0y9NPS2u0ba2ChtFuhHU/D5JejqM jh+Zx+pHGfC4feja+h1K23aisgbRVNbJEyfDch4ecdRHuAVJO4VzpbVcYait5idTGIDGcuc7svTX RkaQsEZB4lps/QAhSHy0dNbLNtpp+gs1JEwufiSSV7AfUIOHOPfkhcHvHtPRagqbdf7CW0UlwkjZ OzpyHdZ/N91J+v7lRWu6xzXEdUUlG6FrcZy5ziML01Uf/wALemoyMD1qcH9wrjN3tqRoaG1WLbWx W+zQQscZSJJZJGhxld2cTn3won+I3bmihoItYWFogjqek1NOBwS7/GPb7Kadf3Chtt49S6NDoZaA wsBbnLnOIH+i0G80Yds1C09vSj/ot+LGZZSVy8mVxx3FKHDDiFuNH2ObUmo6C0U0gjfVSCPrIyGj yf2WtrABKT7FSD8PsYfulY8jgSOP/uSvN5bccbY9PjkyuqstabBpnb6z0FnNNC+WQ+rM+Zoc6Q4A ccnt27KPN19nI67UNsuGmHR01PdpWsmicMNjc4E9bQOwx491J+v6ihhv0huJAa63iOPIyetz3Yx+ uD+i6Gsb1R6Vb49Rp/aMrvnjJJfuPP47c5f5XIWzS2ldDWq32iooqWaWQ+pLJMwPc44AJyfqOyjb dHZds2qbbPpl8dNRXWUMexw4icR1FwA8Y8KXNfvt7LpVtunR81C1kBcOQ8vPb28LoK9nXPplpx/v c/tEViV0mM6u3C2zSOjtH0FBZKy30dTPJ88klRGHPORyQ489wo03I2Tc3V1vOmnRxW66SdPTJnEL sFxx9MBS3rg28Xu6C5Fge6ijbTlw5D+vx7dl1NyjzcNMZ8Sk/wD1orpnjrU/jjhbl3tw1o0RozS1 voLNXW2iq6iQl8k1TG10nIyfmwCeeyizcPZKan1nQRabeP4ZdJS1okPNOcdRH1GOymDXQonXe7fj zGJBSwtgLhyHl+flPg8LrLmwG76Z6uSJXn/60Vzx6y1fp0mrjMpXBWzQWidL0dDZbhb6StqJMukm qY2mQAjPfHPPCinXmyVZRayo6XTzg+23GQiIyO5hOMuB9wB2Uza5bQOvt3/GGMTingbTlw5DuvPy +3ZdXd251JpokA/3kn/2Mrplhr/6OGHkuV3ftwlt260Vp2moLVc7fS1tS/PXPO0dYBGck+eeFEOu tlrjbtZUtBYSJ6C4yEU7nuwYsDLmn3AHYqbtwYKSa+XJ1S5rahkMAgLjyCTk4/bC6a8NB1RpjI5E kn/2MrOE77dcstav9cBbdstC2GKgtd2ooKuueCHTyfm7E5Pjvx2US622Xutu1pTWyzBtRRXB5/Dy OOPTAGXB32HZTZr+np59RXF0zwyoiZB6BLsHOece+RlddeW51dprgcPlP/1srpl45Na+Y4ePy3Lc v3pHtr2l0RaKaht14pWVNc5pEk7nkHOCckZwoe1hs3ebVrWC021v4mlrnu/CzE4AaOSHfYfup317 TU1RebrNM/oq6f0BTHqIPLhnjzkZXW3hg/tfprqGT/enP/cWZh9uuXk+vtHFBs9om3U9DbbxD69w LCJKgSuYS7k5IBUO6q2hvdp1nFZaNhqYKt5NLUAcFg79X1A/dT1rmlhnvF2qHPc2rp3wtgw/Hcjq 488ZXZ3ZjTqvT7nAHpbMf/cq3DWkxz5W/wARhQ7L6NoKSgt94657iYy2WoZKWdTuT1dOePA/RQzq vaa+2bVzLPTwPq453F1NUMHD2A8kj3A7hWF1tTQTXK7Vj5HNqqWSFkAD8DBcOrjzwV2F1jadVWN5 aCWRTkf+FYbRXS7I6Ro4KOiuc1RJcHRESStmLWl4BOenx/7yhfUm1t/tGrRY46d9WZCXQTMHD4we XH7Z5+ysXrCkbUXS6V7aiRlTSVMUcbQ/5S0kdQ6f17rr7rE12sLVIWjqZSzEfsFbCdopoditMwU1 HS3KtqzdHQH1HMlwwvGecdx44yoVvu2N/terHWQ0sk73EuiljaS17M/m/TyrJaspjNdLhcGVT46i krIo2x9Q6Sx2MjHvyuwucTHaxtry0F7aOUg/sppZNohpNhrAyioqauuNYy7Opz6gZIPSMmDzjGQO 3GVC14281BbNUmxSUcklUXf3b2NJY9mfz59vdWY1NTSvvlXco6qSOWlrooRHn5XMdjPHvyusuTGO 1tQEtHW2ilOcc9wrpZJUOUuwNqNtpYKq7VcF5fTkyNa5j4vU5925x28qF7toS+2zVBsNRRyPry7D OhpLXtzjrB/y/XwrQagp6h98qrnDVyMdS18VOYf8LmOxn9eV1dfGx+taIlo6/wADIC7HOOrsl6Zx /ZC9LsBSOttNHVXqogu74C58bQ10YfzwOMkdvKhm7aLvVu1QbFPRvNwDuloaPleCcBwP+X6q0F7Z VO1FUV0NXI0U1wjpjF/hcx3Tn9eV1lZBC/WtJIY2mT8C8dWOcdXZayx4pLubQfTfD56lqg9e9viu kkBeYBGC0PHjPchQXqmw3DT12qLddYXQ1UJwQexHhwPkFW4uIrjqKavhrHiKmuTKMw+C1xBz/wC6 XFfFLQQTNttQI2iURuHUBzjJV/HvLizM9SZKvnIHPKwPdfSVuHkdwvmQuL0F59kdyjHlJA/KaX0T 9lQj2SWRWJQCEwke6AxwjsjKECQU+6CgEBH1QgEfRGEFAk0IKAygHhHhLwgaCeEspoDvwl9E/qjP KBpISQPsmkmUAgoQUCPZHhHlCAznvwjKOAhUB5SwmhAk0JFAI8o/RCgPKMBLOSmgSEIVAe6D2R2/ VHhADCR8ppY7oBGUIHZAfZLymeyRQPCSAmgDyke6OyEAkhHZECQWSSoEZHskEZVGzmJ6DzjIWmd+ d3sFt5ndMR+owtQMdZ5zkryYOuXtjUduV8GjAX3qh2XwBwOOV1jFIpJnul5VQwjyjKED+6BwlnhP HCD6xEh2ee62EHrSvbFA173vOGsYMkk+AF4YGdbwAeVabYzQtts9gfqaujFRXtjc9nUMiNoBPH14 7qivNZbLvQzQwVtBXU80/wDumSQua6T/AJRjlY19HcbW9jbjSVVI54y0TxFhcPpkKaqLXLNQ7lUl 0rGdccBMdK0nPQCe6lPXWgqfWtxs1zlnLX0pGWnBaWE5P68BTaKmNt93bSxzut1e2GQgMk/Dv6Xk 9gDjnK9LbTfw0t/hV1H/APCyf9FajX+oI7PX2WyUgaZetj89+kNOMYXV6irLjTWyidamOmq55Y2k Z8EEkk+FdppSWoobvAAZ6C4RBzg0ddO9uSew5HdeGr/F0bvTqoZoJCM4ljLDj7EK7YuVNda6hpJX MdXQVYbLHnq6C3OefuvPr/Qls1RUU9VUwsdXUzg5jyAS5oP5Tk9inI0pa+GtggE89NUshfjpe+Jz WnPbBIwvnH+LnhdNHBUSQtB6ntjcWjHfkDCtL8SFO2Pbu3wYDWipjb0jsMNKx2avFDeLAzTstNGI Cwxuia0BpBGDn7rplOMl+2Mby3/FTZDlxOTzyvmeV3+9ej6bRes5KCgkLqWaMVDGkY9MOJ+UfQYX ALDoXjlHdMlJAJhJNADkrPnCwAwsxyUqvZS1D4XgtB4XvkvUz2Fhm49srptpNv5tc31sEkhgoIvm mkHcj/KPqVZyCn0nYK2l0vS26kDgzBDomudyOMkjOSptPamzK2Vjw5pJ85yvTNfal8Xpmc9Pt1Kd L5sSyfXdNFRVAhs1SXSSM5L2YwSAfrn9FJNPbNHWiqh01T2uhy1nQeqFrn8jy4jJKvpiWVTuKtlj eHtccr1y3ypfF6TqjHjHUptu+wxk11BTUdQIrJUZkdz/AHjADy0eOc8eyk2Cx6Jt9VHpuG0UBkaw xlz4GufnGPzEZJTkvFTyKtmikDmOPvnK9kt/rHxen+Id09sdSmG4bDTHX0dFS1IZY5SZS4n+8jaD y3/oVKMWldC0lY3TrLNb3SCMxOe+BplzjGervnnurbpJJfSoVPcJ4Jg9riDnOcr3z6krpYfTdUEN Pjqwpaq9hKo68Zb6epDbI8mUyE/3jGA8t+/1UpRaN0HFVO09DaKB0zYzC6R8QdJnGM9XfP1U5LxV Fp7lPBN1teQc98rY1GprhND6b6p3R2x1KT/+waufrx1sbOG2UH1PWLsv6M/l+/1Urs0LoD132KG0 0JqGxGH1iwGUOxjOffzlXkaVKpbtUUs/qNc7Oe+VsqzVNxnpjE6of0EYwHKRodiLg/X8lndP02hh Ev4gnL/SJxjHupZG3O38k77HT2uk/EtiMZnIJk6u2e/fynI0qdQXqppZ/Uic4En37rbVurbnUUxh M7xGRgjK7yi2Ku0mvprLLL0WyIiQ1fBcYieOP8yluTbDQMxlstNb4BVti9L8Rkl4fjHV37jukyTW lVbfe6qjqRIxxz55W3r9Z3SqpfSdO/oxjAK7O2bF3io15NZKiX07ZARI6s4y6IkgYH+Y4Utz7TaC qo5bRR0TGVjI+gVPW4vDu2cZHIKcjSrlsv8AV0VR6kT3Ak8891uLjra61lKYnzODCMfKfC6uzbH3 qs1zPZal/pW+nIfJVjGXRk/Lge5x+il6q2g0JVU09qoKUR1zY+kVPqOLg7sTjPdOR0rBatRVVuqf UjLs5W4ueubrWUpidNIIyMYB8LpbDsle6/W9RZapxhoqZwfLV4HzRknpwP8AMcfopcuGy+iK2iqb ZaoDDcmxgNqHSueer36c8pclnas9n1LWW6p9WF5ye63d31/da6k/DmVzY8YODyVu9ObKXy5a1ns9 W11PRUrg6arIHLCfl6R7n+Sl257IaNrbdVUFla+K6Mjw2d8znDq9yPKbqXSt1j1RWWuqMsT3ZJ5B Pdby8bhXWuovRdI9rCMH5vC2ektmr5etZS2esa6mpKRwdUVPT/hPbp+pwpcu+xWka221lHYZJobr HGPTmkmL2h31b5S3V1STc3FdrBqyutVU6WGQkZwQSt7etyLpcaIwdbo4yMHDicr2aN2dv171jLZ6 6F9FT0rg6pqCOOnx0+5Kly9bDaWrLTWU2npZ4brG3MUssxe3q+o+qbNK+6e1hWWmqc+J5Oe4JW8v m5V1uFGYPUexhGDgnC+2htn79qDVclrrYJKGmpX/AO1TubwG+zfckKW77sFpuqs9ZDpuqqWXOMAs fPN1t45IxjyptZigXTWtq6zVLntcXNd9cLc6j3Oud0oXU/qvYxwwcHunoXaS+6j1W+2VcElHT0r/ APa5nN4aPZp8kjspX1L8P9instaNMVdUbnCMs9eXqacckcDymzSrVTK6V5c8kknnK+AJBBC9t4t9 VarhLRV0LoamJ3S9ju4XiGcjCjUdvofWtbp5+InOdH/lzjC6jUm6tzulEYGuLGO4PzZXPbU7dXXX t2bDSNdDQRuzUVThw0eQPcqX9V/D5Qiy1b9LXGqqbhTniOoc0tcB3GQM5x2VjKJ9Ka+rbLUOcJHO aTkAnkFb7Uu7FxudC6Bj3Rtdw7nutLt1tfetX6gfQ+jJSU9M/pqp5G49PHcDPcqT9W/D1TQWOqn0 xdKqsroDn0Z+kNcB3AIGc+yu06Rlo/cGsstU4l7nxk578gre6p3ar7pSGCNz2NdwSSuf252yvWsb +aJsMlJTU7+mqnkaR6eO7RnuVJetPh8ZSWWoqtM3OorqqAnqhmDQCB3AI5z+6vJNI80duHV2WocT I58ZOe/IK3uqt3K66URp2Oe0O7kuyuY222zvOs76aSGF9JSwv6amokZgR47gDy76KR9cbAPtthmr NOXKe41EJPqRSNa0YHfGPKmzUjitF7j1dlmPqPdIzORzyFutX7v1t0ozDE97Q7gklcntrtnetaXp 1LTxPpaWF2Kmoe3iP6AeT9F3uvdgqiyWKSvsdxkuj4SfVjdGGEAd+xSZLZJ7cxofcuezTOEz3lmc g+QVt9ZbwVl2ozBBJIGnuSVx+2e3F311eXU1Ix1PSQuxUVL28R/Qe5+i7jcHYWu09Yn3Ky3B939F x9aP0gwtaByQATlOXwmo0Wh9zKqyyFssj3x9xzyFuNZ7w1l2o/w8D3hp9z2XF7Z7cXfXd3fT0TTT 0kX+/qntyGfTHk/RdluHsRctMWA3O215uzI3ETsbB0GNo8j5jlNrp4NCbn1FmlLaiR5Z4dnstvrT eGpu9EKenkcGZ75K4TbLbi7a7ur4KEfh6SHmeqkYS1n0x5P0XW7ibG3XTFhF0oK4XeFjiJ2xwdBi aPP5jlORqFoPdGos8hZUvcWd2uB5C2eud4am60Yp6d7wzPclR/tnt5d9d3R9NbgIKWIZmqpGksj4 4H1K6jcbZS7aSsLLpBWNukAcRP6MPT6Q8HucpyOL1aA3Wns5cypkeGj8rhyQtlrreOou9GKelleW +5UdbZbe3fXl1fT2wNhpohmWqkaSxnsOO5XRbjbM3vR9jZdBUx3OmDiJjBEQIh7nlOSabfb/AHWm tBLKqR+PDgeV79fbyTXeiFPSyP6Qe54UabZ6AvOvLo+mtYEUEYJlqpGnoZxwOPK3+420F80baIrj NNFX0rnESPp2HEXsTn3TkadDt7u1Lassq5HN/wArwvfr/eSa60gp6WVzgD+ZRjtvoC8a6uclNaWN jhjBMtTID6bPYEjyVt9xNpdQaKtsVfWPgrKRxIfLTAlsft1ZA7ps06/bzdt9qBZVyEEDhy9W4W8k t0oxTUkpLR57KLdvNB3vXNxkprNG1scTS6SolyI2ccAkA8lbLcTa3UWiqGKtuLaeoo3npdNSlz2x nx1ZAxlNxdO6243cfa2OjrZS1w4DvdercHeR90oxT0spc0dyom290FfNcV8kFlhaGRgmSeUlsbfo T7r37hbZai0VTxVF0jhnpZO81MXPYz/mJAwm0vXtJG3O75tsZjrJCHDgO75Cy3E3kfdKYU9LKS0H kqJtvdC3zWtbLBY4AWRDL5pHFsbfpn3Xq3C241DooQyXeGN9PKP99TuL2NOexOBhNmko7b7wfw6I x1spY7GA48gr47o7wyXahNLRSkggguHAUUaD0RftaVkkFipw8RDL5ZHdDB9Or3X23E2/1Bol0IvM DDHM3qEsJL2DnGCccFORqOKrZjLM57iS5xyfuiimdBOyRpw5jg4fdec5ycob/NZdVnNrd4GUduFP XyhrmjpPVyCEbkbwCvibDRyDpb/l4HChbQeib9rGadlhpPWEAy973dDB9MnjKz11oq+6PqYIL/Si Ezs6o3sd1sP06hxn6LUunOzadNut34aejMNZK0Ox04fyMLx7lbvCuibBQyt6W4GGcDgqF9E6L1Bq 6WZtgon1DYAOt5cGtH0yfKx1xo++6PrIaW/0hp3zM62Oa4OaR7ZHGfom4aqe9ut4IYKAwV8jQ7HS WvOQR7rwbmbusrIo4KCRoY3AAZwAoW0Xo+/6rdMLDQvqfQAMjuoNaPpk+VhrTS160nWxUl+pHU80 jBI3nqBB+o8q8k1Vgtu93YGW409bIzw0tfyCPda3cvdttWxkFBI0RsxgM4AwVCWj9Jag1UagWCgk qvw4BkIcGgZ8ZPlefWGm71pivZRX6kfSzPYJGgnIIP1TcNVYzb7d2l/hgp66Rh7AtkOW/darczdx tY6OGheBGzBDWHjIUG6S0rqDUxqP7P26as/DgGQsIAbn6lfDVViu+na8UN8pZKSqcwPDH/5T5TcN VZXQG7FJNavw1c+N4GAWScjjnP7rUbm7ssqjDDQPAjjIIDTwCFA+lNNX/Uj6gWGgmqzAAZDGQMZ7 d15dSWi6WOvdRXqjnpKrAf6cowcHsR7hNw1VntCbrUdTZhTXF0TxgNMcpyOOey0m5u6zKp8MNA4C KPBDWnjIUEaV07fdQmYWG31FZ6IHqGIcNz9V5NQW65WavfRXelnpatoDjHKMHB8/UJueyy1aPQ26 dDW2MUty9OUcNMcvIGOc/utFuduvHPNFBQvHREQQ1p4yFAmmLHfL4Zv4HQ1VWYcdZhbnpz7rw32j uNtr5KS6QTU1UzBdHK3B+6m4mqtbovc+33CxNprmIpmcAxynI4wf6rnNzd1mVNTDDQvHpxEOAHYH soD07Z75efVNjoKys9IgSGnYXBuffC8F4grqKulpLjFLBVRn545BhwVlhZVtNHbm225WGOmuQina MAxy+MYI/nyua3M3WZNVQxUUg9OJ3UA08eyr9p+2Xy5iR1loK2r9MgPdTxueGn64XhujKylrZaav ilhqYnYfHKCHNP1Cm4aq3Ok9x7Zd9PxU9yZFOwFv9289i3BH81zG5e6rJK6GGkkHpxO6ukHgKvdg ob1cBI6z0VdViM4caaJzw0/XpC8Vy/Ew1UsNY2WOoY7pkZICHNPsQexVlntbLVutOa/tF90/DT3a OKpaxzXBrzjBbyD98rmNyt1YnXCGOjk/uondQaD2VebLT3isY/8AhVJW1IYcO/DROf0n69IK8Nwd UsqJIqlskU8bul7JGlrmn2IPIKm4mquDYNd2bUOnYoLvHHUMY5rgCcFpbgg/fK5XcrdKN1wgipJP 7mJ2QAfCrrZ/4tMD/DIaubB6SYI3PwfbgLx181SKiSOq9RszD0vbICHNPsQeQrLCyriWPWtj1Np+ CK7sZUdDmvaCcFpbgg/fK5XcXdKMXKCKkePRidkBp7KuFrqbkATQtqXtz05iY4jPtwvLW1FQ6Z7Z i9srXYc14IcD7EFNxdVci0axsepLFStu7WTmN7Xs55BbjBPnvlcluJujEy6U8VG4CGF2WhvGAq20 VxraeMGCSYNz0gtBxn2+68tXV1EshdK93Xnnq7hJYaq5ls1XYtT2ejfdmiZ8EjZYyPBb2J/mo43w 3BguFJJa6R7fQx0hreBj/qoForxXU0YME0jW56flzgn2Wvra6eolLpnEuzznurvXcJjv28lU7qmd 55XR7cXw6e1VR3AZHok9vGRhcw8lxyso3OBGO65e3ZeOkv8Ap3Vdvt1XdA181O8SxluPA8+4+i5b Xe58FPfKVlM8Nhgd8vScY8ZVZbffq6ihDYal7GDjGeF5ay5TVL/UkeXO+pW5r5crv4XTp7xp3VVL bq25hrp6Z/qMIxzgf4vcfRclrfc6Cn1BSMppAIadxDSPtjP7KtNv1NX0UIjjqnMaOAMrw1lxnqZf UleXuPnPdWSJ3V1BX6a1TFQV9yDDUQP9VpaAc4GMO9x5x7rk9Z7l09PqGibTua2KmcenBz4xn9lW q36nuFDCGR1T2tAx0krXVlznqZzI97nHuTlXpnV+F0/xOm9UG23O4dHrQOMnTjIfxgB308rltY7k 01PqWhbTuaI6Zx6cHIBIxn9lWu3aquVJEGQ1LgwDAaT2C1dZdJ6icySPcXk5JJTr5WS/C6EztNan qbbdq18YlhJe5mMiQAEAO+x5/Rczq7cemptUUAgc0R0ziG85wSMZ/ZVtt2rrlRwtjZUENaMYJWpr bvU1U5ke4l3kkq8vupx16i6VUzT2p6y23aqnY18J63xdxKADjP2PK5bV24VLBqq3mJzA2mLunzyR j+irlbNZ3Ojp2xxznpa3ABK0tfeampqnSvcXPJySSpNTtct1cutorBqi5268T1TGGL55Ic5EoAPS D7YPP6LQ6q3CpafVtv8ATczpp3OAzzgng/yVb7bra6UcDY2zEsa3pAcey0dfeqmqqzLI4lxOScrX L7ZmGvS51xttj1LcLddpawRhhL5YQf8AegZ6c+2Cuf1Tr+kg1dQdBZ00/UG58EjCrnbNd3SlpmxC UuY1vSMk8BaCvvVRV1hmke4vPJ5Ulk9rlNrj3Wy2fUV2oLv+NDI3fPPD14L8A4P0wVqdSa+pKbVt CIywtgDmjq+vBVcrbr+50tK2H1CWNb0gErnrjqCoq6wzSOcXE57pufKavwuNdrHbb/d6G6x1wEDw XTwepjqIyWn9CtZqHXtHTatomsLCIWvjHUf83CrjbtxLpTUjIfUJa1vSM57LnLlqGoqqz1nPcX5z nKST5W7+FxLrp233u9U91jrQKaVvqSw+pglwB6XD7YHC1l+11R0+sKRrC0tjjdFkn/MQD/RV3t+4 1xp6VsTnFzGt6RyVzFfqKpqa4zukPVnPfsk18na4dz03R3m9wXOOv6aKYCeWP1AHF7fykD245C8N 61xQ0+s6MNc0hkboSScd8KvFv3KuEFIyJ7yWtZ05XKXHUlRV15ndKeonOc9k1Pk7XBumm4rvforl DXOZRStE72NcM+o3lpx5HH0Xku2s6CDWtJkh3TE6EnOO5VeLfubXwUkcL3l4YzpzkrlLjqepqrj+ IdKQ8HIx4Sa+Td+Furjpk3LUTbhBXubbpsVT2gj/AHjT8vHtgL43LV9tp9bUgc7qDYXQdWcDk91X 6g3Sr4aKOKQuPSzp4cQuPuGqKmquPrmRwfnI5Vknym7PS2dZpaeu1P8AxCCvd/C5iKwtGD/etIwM eQQE6/VNtp9a0rXPyGwuh6s47nOVANv3UrYaOKGVzyGM6chxC466arqqq4ipbIWuDsjB7LW9+0/m lr6rTFbUalFZT1wNpmkFaQB3e0/lx9h3Ub/EddKWshp4oH5dCC0/XJXH0W7NYy3xQyPkHQzo4PdR zqvUM92nklke45PAz2UmWrukx5ST4jm5ziR3K+BWbjzz5WC4vSX6pgJICgZQjwjwgSMIKFQdijwl 3QUAn4SHdCACEFCAQDyjymUCQjuhAIQO6CUCKaQTQHsg9+EDhCA8IA5TSycoGkmEiEB2KaSMoBCM oQA8puSKFQH6oKEFAIQhAJeUyl5SgQU/KSgB9EFHYo7IDykhMKhDun4R2S8IDHCPCAjygPCSy8JI DuOEsJjgJcoDuhCEC8oKaRVAkjKEQ0sZR5R5QBCP3Qlj6KjYVBzGQMcLUDAkOAtrIR6blrAfn45X lw9OuXt86or4tHC+1Xw8D6L5M5C6RisD3Qh35kDsqh4QhCBhNIcIzkoNhah1VLB9VdDRjSdrp4og XSupHhrWjJJMZCpZQSCOVrs558KbtsNyTZMQV7nPpx4B8IOE0vRVst+pqCNkkVYJBGWFp6mEd8hX PsVOyz2ekpKioc+ZwAy/uThQLHrnT7Nwm32GhihaWBrnMGC92SS4/VfTVe58Fy1XR1NO9zKKEAEA 9znKaT02O4tnnt+6dFVdc89PV4kL3D5Y3Fx+UFSzrDUkWlrHQ11QCYjJHG4A4zwSuAum5enrs22t qofUhp5GyEdXJIGP9VsbruLpS7QxQ3CkZUQxvEjGP5DXDsU0keHbeius+sJtQ11MaeiudW6Sna84 ccnP5fbC62+ao/hG4EVC8ksnp2HH1yVoazdWxPqaEtHTHTydeAceMKO9W64t923JpLtE7/Y4YWRH nyCT/qrqrt2/xPO/+EagIPD6tp/9yVyHw1MdJfJZCDhoGfosd79d2zVOnbfbrcSXRzCRzs9gG4W0 0przTWjNFejZ4v8A0gWZe95Bc93uVvK7kn0xhONv9cT8U7g7cSLBBxRRj+ZUL910GtL9UaivE1dW yF8zz+w9lz6jZeUEcplYqAymkgIGO6+jfH1KwBX0aQMZ5xyhFnvhcgawTkDOQc/su/uFRbxq6rpS 1n8TfLC/JaMlox2KgLaTWjtPTsY1wDCfmCn4ar0oZIr1MITXRsd0uAA5I8+6zJq1b727GqZ/8MlE QP8A2U3OOOwXHVMlrGr7jThkZubqqJ3UW/MGjHY/uuCi3YNRqgVBeGwA9LR9PKkD+02lBO2+SCE1 zInYcGgZJ9/crWUtcpHX1YcNV0oaDj0JTn9Vx75LZ/bG4QtbE66OrI3FxaC4NBHAP2yuGpd1zPqk 1Ej8RZLQAewJXfPvmkmVf9oHel+OEbuQBgk85P1U13t031p1c7Maui4PNNJn91x7P4Z/a+tjY2I3 M14c52Pn6QRxn2XHUG6oqdUGd7wIiekc9m5XcPuulKavfqEujFYYjkADBPfP3Sy1mak06upGNYR9 P/yq8n/xLkKVtu/tbVNh6DcjccyOx83RkcZ9lx9t3UZV6pfO9+InHpA/4cruH3HStHXzaiErRVPi yWg/KT3z9ymq1uOlcCdYyY7Cl5/8RXKWyK2f2nmMHpm5/wASd6ru7unIwPsuTs26MdXqeWeRwEb3 dIGf8Oey7Q1OlrddKjUTZmColjy5gPHUMnP3KaqbdKz5tY1JxwKZuf8AxFcnaYLb/aV76fodc/4k /wBV2cu6S7gfZc1Zdzoq3U00zyGxyHpHP+EHsuuE+l7Vc6zUTJ2iaaMOdGDx1DJLvucq6qbdHE3q 1ZW9uKePx/xFcnY6W3t1M+SEtNxNwkMrurLunPA+y0Fg3NgrdSzzOcAyUho/5QeF1GNNWe51l/bO 31Zow/oBPDhkl33KsljNne3R07c6qry0AEU8POP+IrltOUlC3UpmhLXVrq6T1ndWSAD+XHgLR6e3 Jp63UdRK9zWslIZx/lBOF0cTdO2C41+oGVOZJ2B/pdXAdySfuVNEne3RUTP/AIZ7ieAfw8PP6lcr pSipI9QMmikD6t9TN6x6snAzgY8BanTe41PX6hqJHuaGS9LODzgdl0FNBp/TdfX3xtX1mZoeIc8N dz1Efdbl1LGcseV26C3RhmobngDPpQnOPuua0jRUkN5gngf6lXLNN6568kAHgY8LVaV3DpK++VLn lobKQ3g44b2W7o6Wx6Vq7he21Ye2Voe2Hq4a7nJ/XK5Wbtbx9ab21MAv104A/u4iePuuY0Rb6amu lPURyGWqnfL6xL84xnAx4Xl0pr6irr1UuPptbMQ35cDgdv6ra2+hsulJ7jeBV9TJPnjiL8hpPf8A ddZlrGz7Y49yt3Yg3+MXcsaAcR+O/BXPaKoIIK+knimfJUzmX1+p+QMdhjwvHpDXVFXXaq5axszg 0kd+OAtnbLfatJTXK6OrTLE49UTDJnpz3/Vcspu2uuF4yRurR0tul79NoyAw5x3+UrntE0ENJW0l RHK+WonZIZyX5Ax2AHjC+GkNbUVyuVX1Oa0VB6SR34GF7bPbrdpB9zuM1f6sLiXRNL89IPday7Zl 603lsjEVXqDoGCMYP/cJWg0NQx0dbRzMmkllnge6YufkAjwB4wvlo7WVFc6yrY97WiqcQXA/TC9V ltlFo5lxramvE0OSYWl2cAjsfqpZtqWSNzamNjm1AWNAPUeQP+ArR6GoPwdfTPE75n1FP1ydbgcO 54Xy0fq2iuc1bG57WiqcckHzjC+9kt1JouC4VtZX+rEHOMILwSGHx900kVH+IiMN3UvLmjHzj+gU bRNLn4Xcbw3iK+63uNwhI6JX5/kuLpOJW5PGVvyWW9J4pZjqrzbJ26O2bWsZSsDXOhc8kDkuLScr b6Don0tTA51RJP8AiKUSP6iD0v8AIC0uzl+oqnSNNbvVa3qi6Osd8luFvtPW6LSFFW1dxrzM1r3C IFwPyeP1XPGWTRe7t76KnZTW6/SUrAyR08xJA7u6e61mhaOSmlYJah87p6YSv6yCA72H0WemNQUV 4p6ymZK1n4mR7g7vguGD+yz07bxpG311Vda0TdL3NiyR/u/8I+638ac8pvK34ey3UzKOzX2SlYGP dPO7IGD1Y7rwaGpZYJXx1E75jNTtlf1dg498LPTF9or1Q1tLHI2M1T3uB746hj6dktOUB0jbK2e9 V3rPDnMiyR/ux+X9VJNRu+q9FFTNt2m76+jY2OT1535aMfNjuvJoWmqaZ8sNZO6d0tOyZxc3gOd3 AX00/d6O+2uuo4phE+pe8td3x1e32S03QSaVtFXPfawSSdTmRnPdgOW/qf5LeVnHWu3C4ZctyvtR UzLZpS+SW+NscvrTv+UYy73Xw0bR1MX4qlr5/XMkDJScYALu4X10/caO92iuoaecRvqHPLX46h83 0+iVgpJ9L2eqqL/VepL1OZGc8ljT8v8A9pJZJZ87d8u97+mFDTR2rQ94fa42RS+rM5paMfNlfXR1 JVU4qqW41AqXuhZMT04ALu4WOnqulvdgrbfSziOSdzy1x5/N7DjslpmCo01Zamq1DUF8xJY0HuWN Py+VM+5f+3OT9v8A0xoKSCz6Guz7VE2GQyyuHQ3GXFy9OlaOoijrKG4TtqeqFkpPTgDq7jCwsk9N edOVlBRzsbLM55a48jJOVhpptTp2xT1mops1BJYG4wS0Hjup8uvw+VBSQWXQFf8AwiJkEhlfyxoH zFwGSvbpSlnayvt9ymbVfI12enDfm8AL42uSG96UrKC3zMbPIXOaXcjJOUtMir0/p+au1HKDVu+U tPBwDxz57rOfeRPTz0VHDY9vKt1nhjp5XyuwWNx8zngZK92lqWYwXK23V7KrpaCctw3B8YWFvMd6 0jUUFvnY2pJLmudyM9WVjpo1dk0/UVuo5AKqQdLge/HA+6Xut9PHQUMOntuJTZYY4JXuOCxuMudI BzhbHTNLNLRXS2Xn06no4cOn5SD91hSdN50XLQW6ZgqGglhdyCQ7qCem3VVl07NXaieG1UzfmB7j wFGWut1tg01tq7+Bwx08jyMFgxkukAycfdbLTtFJUWu7Wu9tiqBESxzcdTCOnPlKANu+iX0VvlYa hjcjqPGQ7q/0RpyWptOmZa7UUgZVVDMvHnPYD7pYNZb7dBpbbYNsMEcEj+nloxkueBk/utpZaF9d ZbrbL5HDUCMmNzSMtIxkd0o2/wAU0QaW2SMdUxNBaHHjLT1f6LLTc1TbNLPrtQuaypqWhzwO4J4A wtT0xrtp7fb4NJ7axMsNNHC94YPlGOpzn4yf3W1tVAbtpq6Wy+RQziMvicwjqaRjI7rKRr7poZtP ayySqiY0gE/4mnP+iNNTVFt0o+tv5bDU1Let7fIJGMELMnWmvnbS0lDFo7bekjsFNHHI8Rtw0Y63 Odgk/utjS28XvSVwoL1FFUekXxFpGW8DIxlfSuZNctEQx2gMmqoGscGk/wCJvK+unpai36Rkq74G wVNTmRzOxBIwAR4K6ySYTXtxy3llly9NPRW6HR23NFFp+kijfKI2kNbjrc84JP1XrFuZqHRVwoL3 DHMYTJGWn5gCBxheyubPW6Hg/hHTNVUzWuDc93NRZHz0mjpqu8tbT1NWHSuYeCHOGMEeCsSa1p0v crTUlvi0bt3boNP0sbHzGNha0YL3P4JP1+q+tztkWpdv7nSX2nZI+n9RnSeektHByvfefxE+hqSS 0tbUVFIGv6fOWg9h5KwpJZaXb+sqru0U9RVsfKWHgguHGR4XWSax/wC3LybvN+flbD6FTJH/AJXF v819bXSmsr6enb3lkawY+pwvtfAP4lP0/wDyR39V7NFAHU9s6uAKhn9Vz8knK6erDuTa71JbI9Ea BtFv07Rs653MY5o4L3OHzEn3+q+mo7HTav26rKe+0zHSwF4GeSxzeMgrZanlqDpShrrTD+Kko8Sd LeezcdvKdDJJHoSeS44hnrWveGk+XjgLU1qMWd1rKG1QaK0Nabdp6kb11DmtIBAL3EZLsnzwvnqa x0ettt6mO+UwMsPWGH/FG5vAIPutnqmeop9K2+4WyL8S+iHWQOcfKR/qvpSPfFoKofXAQTVYc9rS fLgOFz+Wq1VDZ4NE6JtNs03Rj1KpzWuAPzPcW5c7PvwvPq6wUOuNtpn3imH4iDq9N3+JjmnHdbrW FXPR6Zt10tsH4t1Fh5DRn/D0n+qIHOZt9KapoglqwXtYfd2DhUa6ls9PofSNstenKMF9U8BwH5nk tyTn34Xj1xpug15tu6e5wBlXCCYpAMOY4EBdBrSslobDb7tRQ/ifwZ6yG8jlvT/qk0Oj0A9lQ0Qy 1B62sJ8ucDgLI1sFmp9DaUt1r09RZfVP6XdA+dx6ckk/otbuDpi3a926FZcYAyshHVFKBhzD1AEL p9cV8lvs1vu9HAakUh6sN5A6m9H+qxkBj2+9Oob6Ms2HCMnnlwOP2VRq4bPTaF0vbrXp6i+epf0n 0wOtx6eoknz2K1e5Ok7drvb6G4VtOIq6LDopWjD2/OAQT5HddRryvfbbdbrtTwGpbSku+XkZc3oH 9U52Oj29ZFUM9GWTBEbjzkyB2P2TST21UNqpNB6bttp0/R4fUPLfkA63kN6iSfPYrS7p6PtuvNDU 10qIPRrmdLo5WjDgC4Agnzwus3Crv4XSW67shdPHSlx+UZGXAMH9VnVtMe3sUczPSkeGERu4IzID j9lrGSaTd320zbfRbf2C32iw0ha6oJBcwDrd0jqJJ88ArR7saLtut9IUt3MAguBMZbMwYcQ5wBBP nhdTuVWttcdDdHU7qiCEPaekEjLx0jn65XrrYzFoKkikZ6Tz6XyO4I+cHCupjx18ueFuWV5fbV/w +i29sFutVho3NdMT80Yy89I6iT78ArmN39C2zWunrfe2Qinr5HRdUjBgua5wBB9+F2u5NyZaG0Ny lp3zwRtkjy0EgF4DRyPfK+lxiMeiLZA4em/qhHQ7gjDwUwk6aztax1JQbd2a32ixUbmGTJ6o25c7 p5cXY75GeVy28O3tr1jabffaeEU1xnfEJJIxgyNe4D5vcgLt9xLtHZKqiuE1PJNC2KSIFgyA5+AO V6LlE6LR1nic0tc18GWu4IAIU4yWJhbbdtYaK27d2S32iy0bg5/PVGzqe/p5c447kjyuK3m23t+r 6K26ht7BR3CqfCyVzRxI15xl31APdSHuDeIrHW0lwmhfLH6D4W9IyOp5wOV9rhA9mkbHEWFr2yU+ WuGCMEJjO3TKbjUMorZt1Z7fZrPSlrnjrc6NmXSFv5nOHkkDuuK3n2zoNVxWzUNsAoq6slhZOWtz 6jXnBcfqB5Ug7g3aCyXWnrKmJ8jHUzoWlo/xOd2Xsr4nDSlijc0h7ZafLSMEYKnH0srStpLVtvZb dZbbTgfL6skgjyX9P5nO+pA7+FxW8m11Bqd9sv8Aaemhqq6WJk+G5Dw8/mP1AUh7hXWmtF1jnrA4 slpDC0N8uc48fsvZXxkac07G4EFs1PkHjGFcZutdNLBQ2jbmy22x0ELR1D1ZHlmTIRw5x+pwuF3c 2ooNQV1rvlmIopbjLG2oa1uQ7qP5se+FI+4NypLbdC+vY57J6L0IxjPU9zzgL3VsbhZ9MMIx0zQd QPGMBJEmttFS0Nk22s1uslHC0dYEsr3NyZD2c4/U4XA7u7QUl7u1qvGn3sov4nM1lVH05b83PWB7 /RSXuFX0luuj3V7epk9B6EYxnLzIVs65pNu0s1oz/fRZ+3Sos1XN0FBYNurTbrHTwszJ/fSvkGTI exJJ98KIviO23ordTRassbRFDVuH4mmA46nc9bfb6hTLr+voaG+T/wAQLeia3CFgIz8xe7H+hWn3 5jDtpKdh5AbH/QLtj45bJ9uHOzG5KWuGCVvtCacm1VqigtFNKIn1L+kyOGQ0AZJ/ZaSqz1uHHdSb 8N7OrdO0Z8CQ/wDuCvL5bccbp6/HJb2sXabNpjQlFb7GaWnfK8erLLKwOc/jk5+4Ub7m7MRVOrLX Pp2VlJR3SXokY5pIjcQXFzfbI8KSdwZaOO/Vf44tHXQsjjyOS4ud2/kuwr2A1mmGnsJSf2iK7Z4z CTV9x5fFlc5u/FcbbtO6S0VR2+ySUNJK946pZZ2Bzzkcnq79wov3E2UaNYW5unJWwUFzlLS14yIj 09RI+mFK+vn29l4uAuIZ6klLFHTlzckO6iePbsupujA+86ZyORK8/wD1orGPV1/HSepk4q26V0dp OGhslRbaKolcC+SWoja6TBHfqxk8hRVuBsjNDrSgp9OyNbbrnIQBIeYCB1OH1GOyl3XQtzb7dfx5 YJ3U8LaYkZId15OD47Lrbq3OotNnuPUk/wDsZXXLCdSfThhlbq2/LiaDRuitK09BZay2UVVI4Evm qYmvkAIznqxnuon1zsjU0utqKjsEjTbblIfS9Q8wYGXD6jHZTHr38AbzdhWmMVToYG0xcMkO6wT0 nweF1F3H/wANWmc/5pR/9bK5446vGuuVmplK4eh0PofTDKCy11to6ydwd6k9RE0yAEE5Jxzzwok1 rsnW0WuKS32JzZLfcXn0XPdgxYGXA+4A7KadcMt771eDV+mKzFOymc78wOQThdVeB/8ADdpvj/FN /wCRdLhJr/pzxyvzflwtDt1oawx0NquFtp6qpIIknmGX8g8n9VEOstlLlQ63pLZZXNlobg9xp5Hn BjDRlwd9h2U365hoprvdX1LmNrIzAKYk4OeoEgfcLq7w0HV+nCRyPW/8hWMZu9uud1JpHlHtloWz MorRcqGCprC0tkqJHEOJwT1HnHdRDqzZe8W/W8NotQE9FWuc6nnccdLRy4O+o/mpv1xBRyXq6z1D mtrInwimPVg/mGQB54JXaXZodqzTxIHDZv8Ayrdw1pjDK3cqOKPafQ1qjoLXdKZtRXemWy1Bkc0l 2D8xGcKHNUbN3u263is1Cz8RTVbnOpqjsOgcnq+oH7qd9bQUk12u9RM8NroJYGU+H4PLhkY8jBK7 O7Ma7Vdjc4fkimOf+6sabqM6TaDRNup6G13WL17gIi2WpEjmFzsE9Rbnj/3lDepNoL7a9aMstKw1 EFQ4up6nHBjHcke49lPmsaemmud4q5Zuitp6iFlOBJg4Lh1DHngldndI2HV1oc4Z6KWY/wAgrpZN oypdmdF0VNR265epLcPRIknEpZ1OwfmIzx4/ZQtqTafUFp1d/BYIH1TJSXU9QxvD4weXEe4HcKwm raWGa63SuNQ+OspquGOFokwC0lvUOnznK7O5xtOsLY/AJZSSkKJJtFdPslpGmp6Sgrp53XJ0JD5B MQ1z8d+nxzjjKhW+bWagturjZGUslQ556opmN+V0ecF5+3n7KxmpqRs16rbh+IkZU09fFE1nXwWH pz8v69119wa1+taJxbyKGQ/zC1x0sm0U0+xWl46WkpayrqxdDTn1HNl+Qv55x3HjjKhW77a3+26u dYPwkk05dmKVjSWujzjr+w8qyGoKb1L9V3BtTKyenuMVP6Yd8pYeknj35XYVgbJrSjJaPUFE/nzj qWbdM4zkh+DYaw/w+lpau5VkN5dTkv6JGmP1MHnBGcZxxlQxcNvr/QatNglo5HVuflc0EsezOOsH 2VmbxTSS32quLauRktPdIqb0s/K5h6c8e/K6ypYx2s6V5aPU/AvHV5x1dlq9bJ2hym2EtT7XTwVV 1q4L0+n6ntY9ro2yc+C3JGfqFDFdoO/UOqTYZ6R5r+oNaWg9Dmk4Dwf8v1VnbnDPJqKouMdVK19P c46X0f8AC5hwT9jkrrJIWO1vTvcwGT8A5vVjnHX2/dYyvHaYXl2hin2ApDaoWT3moiu76cvdEA0x h/bHbJGfqFDNdou9UmpjZJaN4uIf0Bv+AgnAd1dun6qztZ+LdqiWthq5GiG5spHRf4Swlpz98ldX LDH/AG1il6G9ZoHAnHJHqLpnOG5S9zcQnH8PoNqYHXuRt2dTmQ05jHSH+2e5GVBOpbHcLBdJ7fdI HQ1MLsOaex+oPkK28n452pH3CKrcI4rm2jdD4LDg5B/VcN8UlBC6ot1Q2Nol9EguA5IyVZ47zuDl j5epl9qzO7rEr6OGOr7r5kcrk9bEcppLIdkAgoCEGOEdwhCBJ+ShLygaEIQIpoQUQI5SwmhsIQki jKZCPCD3QAQe6D3R9UAml4R2QCEFMoDykge6EAnhCRKA+/hPukhAIKZSVB7IKAmgxTx7IKEAO6Ey kUoSMITCgSEI8oAd0DujsjHKoEIKXdAZRlCEAjwmEigPCCOUIygPZB5TKRCBE8pFNBWkJCEeFAk0 YS+6B/ZHPuknlUeiU/KQVrmjLsrYS8NK8DPzdl5cXW+3yqSS7nwvmztwvrUDlfILpGL7I9z7pDhP sjwqgR2R2QgMrId1j5WQQfRhPHgLZ0jZ6idkNLHLLM84bHG0uc4/QBeGkhMsjWt7kq1+02jbVozS MmpquMVNw9F0pkcP920DOGoK21NFdKerjo56GtiqpACyF8Lg9w+jcZXxroa23yiGtpqinmIDuiaM sdj3wQp00lrGO+bnC71rPUlcBDBnuxuT2/dSRq/bin1LrO1X+WYn0mtZIxwDgWt5GPrkq7ZqqBpL rC2ESUVcz1jiPqgcOv8A5eOf0X3/AAF7bw623Mf/AMLJ/wBFanWmpI6TVtms1Oxhmh6ZC88loIxg e3ZdbqeruNK62RWqIzzVEmHjOAGhoOSfHdNmlIp4bnGWMmo65jnnDA+B4Lj7DI5Xjq3VVKfSqI5Y JeD0yMLXY+xV3IbhRXu7WkMcyWop5ZOtp+YxkNAPP7rW6428tuoLrQ3cwMdXUzmkkgH1GjGAc+Ak qKaT/jKcNfUQTxNf+V0kZaHfbI5Xzcal0AndHN6B4EnQen98YVm/ifp4m6b060saWiqcC0diBGOF s9s622au0gbBUUkTqURdDoenDcYVt0siobslxJ7pLrd0tMQ6Q1lWWmmmMsMYbIwluC0OGenuey5L yqS7BS8dkHskopoCSyQLwvoPosAsm8oR7KSpfHjpJaQve67Tvj9N0x6fbqXYbNbcP1xeAax5itcB 6pSD8z/+Ef8AVWTgptJUtwdpinttGA2N0BaYWl3Ix+YjKm10pwyrkY7qDsfXK+0l6mkZ0OnOP+ZT fJsO124IohUdNhyZsZ/vOkH8mf8AVSdHadGMr36ZgtNBlsZgcDA0v7Y/NjOfqrtlT6OrkikD2vOV 6Jb5UysDHVB6e2A5TM3YRztwXULqnFhH98PmzJ0Z/If+qlKOxaKfWyacp7Tbg9sTqcn0GmQHGM9W M5+qmzSoMFdLDL1seQ73Xpqb9VTRdBnPT7dSmCHYaY7gyW91QP4G3++DurMnRnAYfr9VKLNL6Gnq 5tP09nt4lZEYC8Qt9UHGM575+qu00qHS3CaOXqa8/Tle6r1BWzRGN1Q7o/y9Slah2HqXbgS22eox ZIsSiQH53MJwG/f6qVRozQdXUz2CmtFAydsZgMrYh6oPbOff6ps0qTTXKenl62uOfuvdV6krZ4BE Z3BnYjqUo2rYitm15Na6yfps0BEnrA/O9hPDfoeOVKjtCaCr3z2SltVEydsRi9dkQ9Rp7E59wrKn Sp1HdJ6ebqa8le6u1PX1NP6T53mPtjKkmx7EV82u6i1184baaYiQzg5fJG4npGPB91KlRttoG6Cp stHbqaKrZF6f4hjcyNd2z37qcjSqlBeKmln643uz91sqzVNxqoTE+d5Ye4BUg6e2JuVTreqtdymD LTSkPdO0jqkYT8ox4JHdSnV7XaCukFVZ7dQQwVrY+gVMZJeCPOM4ytS1bqKt0F8qaSbqY8g5WyuO rLlW0/oyTP8AT9gV3WmNjbnX61qbbcZPTtdI4PfUNx1SNJ+UAeCR39lK1btNoS60dZa7TRxU9exn S2pa4ucHe+MqXLXRJvtWC3X2popiY3Owfqtnc9Y3OspfRkncI8Y4PhdnpLY67XHWdRbbo4w26jcH S1AxmRh/KAM9yO/spTuG0Gibtbqy3WWmbTXBrMMqQ9ziHe+CcJul0rRaNQ1dBP1xuOfYnutpddbX OtpzE+V4jxjAJXVaK2TvF11hUW+7NNNbqNwM0/GXtPYN+6lW7bMaNutrraGwxCmujGD06j1HPwRz 2JU2SK22bUdVb5vUje791trvrm6V9P6T5nCM8cHC6LQ+y95vOq5qC7RupKCkd/fzY/OPAb91K142 R0hcrRW0mnmup7oxv93O6VzwHDn8v1V2alV0seqay3VHVG5xP3W4vWvLrcKUxSSvbHjBAJW60Bsz er5qqWiu0T6KhpH/AO0y/wCYezfv7qVb5sfpW4Witg02ZYLmwZilkmdI3I5I6fqps0r5YdV1lrlL 2Pdye2VtL7uFc7jSei6V7Iz3GTytxt/s9etQ6llo7rDJQ0VG/FVKR3x4b9x5Uoag2K0zXWaui0tJ PHc4xmN8sxe045xj6q8k0gTT2say1SkxyFwPOCVtr/uPdbnSGFzyyM98Fe7brZ686j1JJSXSGWgo aR/TVSEYJx3a39PKlDU2w+n6ixVo0pNUfxOIZZ603W12OSMY8ps0g/Teta20TEh7nNP1wQtlqfcm 53akdT+o5sZHPzclenbfaK9ao1BJTXCGWhoKSTpqpXDB47tb9fqpN1ZsDZpbJWP0lU1L7jDy1tRL 1tdjuBgeU5JpV+plMshLiSScr5MJa8Y7r1XGjnt1ZNSVkLoaiFxY9jhgtI8Ly4yVl0+HdaI1pV2B 3Sx5dH3AzjH2XQao3RuV2pDCHvbGe/PK120O2Vz15cOpvXTWqJ2JqnGM+4b9VJ+tvh/pIbFPU6Tu FVVVsBJdFO5pa4DuBgZz7Ky/TNk+UYaS1/V2WQlz3ObnI55C2mqt07hd6Ywse9jD3yV49stqbvrK 8OiqI5aG307+mome3BBHdoz5Ug652AiorBLWaTuFVX1MDj1xTdOHNHcDAzlOTOojvSG4dXZ5CHOc 5h5HPIW11XupX3alMDZHtYe+StXtftbd9ZXh8ckUtFQQO6aiZ7cFpHcAHyu91/sG22aefXaZuFRc Z4XH1YpWgfKO+Mc5VmRcde3D6O3Gq7LIWue57O7TnkLY6w3XuF4pfRje9rD3yeVqNrtr7rra7SMc yWit9OcTzubgtPsAe5XbbhbDSWTTrrjp+4VF0fC4+vG+NrSGgdwBySnI1HJ6M3JqrMXCRz3DuCDy FstX7s1t5pPQbI9rPqVotq9sbpri6Pja2Skt0BInqS3HSf8AKAe5XXbj7FVGntO/xWxXCa6iJx/E RuiDCxo8jBOU5Fx67aHRO5dTZXdMrnub3aQeQtlrLdqtvFL6ET3hn1K5varbG667ucjY+qkt8PE1 U5vAPsAe5XV7i7GVum9Om62m4SXZkTj67PQDDG0eRgnPKbJJ8NZojc2eylzZ3Pc3u1wPK92tt2qu 7UvoQyOEf1K5fa7bS668uMkdOTSUEX+9qntyGnwAPJXS7kbI3HStgbdrfXG7U7CfxAZB0GNvv+Y5 SZGny0JujPaGltRI4HPykL2633bqrvSCCKV/SD7rkdrttbrry4SNpHCloIgTLVvaS0HHAA8lb/cj Ze6aUsTLpT1jbpTAkTenD0+mPB7klNmnq0HunNaAWzyuAHZw7r0a73bqrxTiCCR7Yx5J5XGbW7cX XXlfJHQubTUUQJkqntJa044AHlbvcrZy7aPssV0ZVsudKXFsroYi0RDwe5ynI02egd1ZrQ0sqJXA AfK8HlffXe7tTeadsEEr+nySVxG1+3F215XyR28tpqOEEyVUjSWtOOB9VttyNob1oy2xXGSeO40b jiSWCMgR+2c+6sqa+3RaA3WktUZZVSODmjDXA9wvpr7d2ou9O2CCV/SO7iuB2025vOu62RlvxT0k bSX1UrSWAgcBbPcfae+6KoIa2pkhrqFxw+ana7EZzx1Z91OUXTrdvt132uMsqpXNIGA4eQnr/d+a 7wtgp5H+mDySo92325veuquVtsAgpogeuplaegH2Xu3H2rv+iqSKqrvQq6OT81RTdRaw546sgYym /pNfbuNvt2jbIiyqlc0gYDvosdwt3ZbvAIaeUlvvlRzt1t5ftb1MotMbWU8QPXUTEiMH2zhencfb LUGiooZ7k2GopJBn16UucxhzgBxIGMpMovFIu3e7pt0BjqpS17RjJ7EL47gbvyXaNsVLIcA9yo12 92+v2tppW2eFjYYh808xLWZ9s+6++423F/0Q2B12jhlgmb1CenJcxpz2JIGCrssSdt9u/wDw+Asr Jel4HTk85C+G4m70l2Z6dLKegcZ7KMdvtAX/AFq+b+Cws9KH800x6WZ9s+6y3E0BftFS07LzFG6O ZvU2WAlzBz2Jx3U5HFLG3m7zaCmMVZN0OA6fm5BC126u7T7zRmmo5cjGCRwMKNNBaBv+szObLTsM UH5pZnFjM+wOO6w3C0JftFTwR3yBjWTN6mSwu62H6Z905Lx7cbVyGSZzndycrO3VL6WpZMw4exwc D7Fed3JKQ5Ky6LP7a7wspbW2GvlaHY6SH8gheTcbd0XPoio5AGMAHy8BRHoHQ2odXCodYaT1I4AO uR7uhufYE9yvnrrR180hWRUt9pfRfMwPY9rupp+mRxn6K7YsTvt9u/DBbhDVStBA6XNf2Wr3J3b/ AIg5kVE8BjMDDeBwoh0RonUOrGVBsNC6eODHW9zgxvPgE9yvLrTS170nXRUl9pXU8sjA9pDuppB+ o4yrKzqrB7e7vQx0AgqpGAjDS15448harcrdr8dJFHRyDojI4aeAVDejdHai1U2ofYKB9Q2nx1u6 g0DPgE915dX6bvOmLgyjvtI+mqHsD2gnIIP1CcjVWJ0Du7ALaIKyRhIwC2Q57eVpdy92xXSRx0Um I4yOGnjIUNaP0hqLVLah1goJapsGOtwcGgZ8ZPdeLVdgu+m7h+BvdK+lqi0P6XHOQfOexV3DtZHQ m69LJaWwVj43AYDmSHI45z+60e5e7IrZ4oqOQenGQelp4ChXSGldQalbUHT9BNVinx6haQMZ7d14 NSWe62O5Pob1STUlW0B3RIOSD5HgpuJZVm9D7q0lRZhT1zopAMNMcvIGORx91oNy91xV1EUdHIPT jIIa08AqENJ6Z1BqMzGwW+es9DHqGPAxnt3Xh1DbLjZbg+gu9NNSVjAC6OQc4Pn6hNwWh0VulQ1V kFPXGKVoABjl5Axz2+653crdcVdTFHRPBjiIIAPAPZQfpXT1/v8A6xsFvqawQ4EhhHAyvBfaC4Wq 5SUV0p5qarjwXRyDBGUmUi2WrUaK3Roa2xtp670pg3AMcuCBjkcH6rmty91hU1kUVI/5IyDgHgFQ Zpuw36+NldY7bV1rYiA90LCQ0/Va680tfbq6WjuMElPVRHD45BghJlImtrYaP3Mt9fYI4Lg2Gdox /dy4IGOQcfdcpuRuq2puETaOT+7iOcA8DwoL07ZtQXaKSSyW6trGMd0udTxlwafY4Wru0NbR18tL Xxyw1UTumSKQYc0+xCTKQuNq2+ldyLZdLFDBcmRVIaQ4Mf8A4cdv5rldxt1GTXGJtLJ/dxuyGgqB tP2u/wByifLZqCvqo2Hpc6njc7Bx24WquTauCrmgrGSxVETumSOQEOafYj3TlDVW/wBO7iWq8WCG G6MiqAxwcGvP5S3t+uVyG4u6bZbpE2lk/uonZwCoAsdDeq+Nz7VQ1tUxh6XGnic8A+3C19xNTDUy Q1bZI6iN3S9kgIc0+xB5CSyFlq4Fh17aL5YYIrpHHUBjmuaHHlpbjBH1yuQ3D3Ujku8TKWTMUTsg Dx9FX+zQ3mqj67XS1tQxp6SYInPAPtwFr699VHVSRVTXxzxuLXskaQ5rvYg9im4aq4tm1xZr/YKZ t2jjqOhwkZk4LS3GD98hcduHukx12gbSyYhidwAewVerZLdnRh1BHVyM6unMMbnDq9uB35Xirpqk TvbUdbZmO6XteCCD5BBSWL2uPaNZ2TUNnpDdmMnfA8SxnOC0t7H75XHa+3RZ/F4G0zwIYXfKGnGA f9VXS31Vy9LNIKh0ZPSDG0kE+3C8lXUTmZwm6mvacODgQQfqrLDtcu16wseobVRy3RrZpIJBLGQe QW4wVxuu90YxeadlK8CGBxA6TjA/6qudBdLhTw9VPJK2PPTloOM+2ffleKqq5pZCZHku8k98pNHa 5tu1XYtQUFBUXICSankE0bmkAgj391F2+m4Md0p5LbTOBgHAaDxj/qoRoLxX00H9zLIGfl4zhaqv rJah5fK8kkpvXcOO+q8szupxP1XU7Y37+zmq6S4g49PqH2yMLkXZI+iyiJDuFyvbpLpealvmnNSU 9ur7mxj6inf60bgAewxz7j6Lkda7nRRaiphTSAQ07iG9J7Z4z+yrVbtQXCkgDIqp7WAYAyvFVXGe eYve7qceclbmvlzs+l1IbvpvUTLdcbmyN1VTu9WNwAOeMDq9x9Fx+sNzIY9S0n4d4DKYkNweBnjP 7Kt1DqWvpIgyKqc1oGOnK19VcZp5fUc8lzjkklJqdndXUNfpnUb7bc7gyI1NO4yt4B6uCB1e/v8A dcjq3cuCHVFEIXtEVM8gYOeTxn9iq20WqbjSQiKOqLWgY6SVrKm5TzTmSRznOJyTla3GeP0ulLPp rUdZbbxWlnr0+X9OOoP4IHV9u65PV248EWqqIwuaG0xcG/QnjP7KuVDqy50kIjjqiGtGA0+Fqau5 1FROZZXuc8nk5V2a60udUt01qK5Wu9VUjGzQEyOZjIk4IHV9jz+i5fVW49PFq+jdE5oZTlwb5wTw T+yrlRavuVJA2Nk56Gt6QCVpqu71FRUulkeS8nOVZl9pw16XSrINO6iuNtvFRO1kkWZHxdxIMHHV 9jyuX1RuNBFq6jMTmBkHU1ufBPB/kq5UGtbnTU7Ym1BLWt6QCtJW3ionqjNK8ucTkkqTUau6udW0 On9RXGgu81S1haDJJHnPqcHGfbB5XPam3EpodVUfpFnTAHNbk5wXcH+SrlQa4udNTCITlzA3pAK0 VbeqioqvVe9xeTk8qzRNrlXG12PUF0obu+sEbCOuWHq/3hGcE/Y4Wj1FuFTQasoxG5nREHMGT78F V0odd3WnpWxNky1jekArnq++1NVV+tI8l+cqTS3a490stnvl2o7v+MayJzTJLCX4L3c9J+mCAtRf dwKSDWFIGub0xsMYz/xdwVXWh1/coaZsXWXNY3pHK5u4X6oqqwzve7rznunSdrkXCw2m83ynvH44 NppWerJAZMFzxnpcPtgcLVXvXtHT6xpcFpbHG6Hk+CVXWg3DuUFKyFx6gG4ySVzNw1DPUVxnfI4v Jzn2Ukhurj1+n7fdb7Dd21wbSyt9aSL1MEvH5SPpwOFqrrruii1rTYDS1sbock+CVXmh3HuENEIn OyGs6RyVytdqSoqa/wBcyHrJz37LU18m6uJX6co7re4rwyu9OklAnfGJAD6jT8rseRgYxwvBcdcU EGtKc/K5rYjD1E44J7qvFHuVcIKQRSEuAb0ghxXJ3DUtTU3H1/UcHk5BHhTUvtJuelwqzTcFfqFl 3jrnMoJAKpzA8D+9BBBx5GAvFV6yt9PraAEhzRD6HVnHc5yq90W51dHRMimcT0M6ctJGVyddqiqq biKjrIOc9+Qr/wBpd7W5qdMGo1J/FGXF4tshFb0BwH96CMZHkYC+M2r7fBreFpPU30fQ6+rHd2cq v9FufXMomwyOk4Z05B7rkK7U9VPcPxIkcHZyOeynGXdqzc9LZzaWml1ObnHXO/hUjhW9LcZ9UEcY 9sDulUart0OtYWOcCPQMIdnjl2cqA6TdOs/BMikkcOlnTw4jP3XGXDVdRNc/XbIQ8HIwVq995Hrq LXP0tW/2jNbHWg2iSUVxwP8AGCBjHtjnKjH4jbtSVwgZA8OdCCwnweSuYpd2KsW9kLpXjDOk4JCj bVN/lutS98jiW58qzPVuV9sfil1r4c3Mfmd918j3Wbz3WBXB6iTCSMoAlH2RhGUAUvKfcJdkAhJN AIPZIdk0AkUFNEGUFLyhAIQgoGgd0JIbMoQjwihBQgoDKE/CSBpIKEAjGU0igCn9UeEgqA9kIKB3 QA+qChNAkBJMoBCEIF4TQhAkIPdAUAmkg91Qu6eOU0kC7oTSQPHCXhAJQgCcBAQOEZQHjhB7IQgS RKyS8rQMJIdlH2RB4RhCAgPCMfZBRj6oPtJ+U/ReCPHVle6U/ISvG38/0K82LtXyqeXcL5gcLKc4 kP0SHZbjnWKSbks8KoChHdBQA7/VZjlYLNnfCDa2NoNZFkY+ZXFropJtm6unpGuknko3taxgySSA MYVM7fN6UzTnByp62y3PjtdL+Gury+Jo45VxurtMpuaR9oOjrK3U1LS03XHUep0u4OWYPOR7q51A xluoaOkknL5cYBd3ccAqvli1rpy3bgV15hoo6eGZox0eXf4nH6lfW8bmwVut4qxkjm0DGtaGtPkD ul7u0np675aZ7ZvEz1ZJp4ZyJWSvbgcjJaD9FLuvdWQaRgt1VUgujleWho8lrQVwV03G01dLlaZq iMvZRlzhl3+IgD/RbO7a+0heTTOuNMypFM/1Ig85DXe4/ZNDx7RW65wXyS6XOnNPDcpJJqdrj8wG SeR44IXTzarbR6+qLTLyHxROA+4Wnqd0bDJc6KYOLWU4eOD/AJgB/oo3uWs7dWbqfxouLaQMYwYP +UYSRHT/ABUnFg06B/8ALUv/AJAvD8MrXGWtcQcDz+hWm311jbNWRWWloX/JTyufI8HOA4Af6Lob Xr/Tej9C/hdPsArOjkuOS5/uSlm+l2ir4jHB259f2P8Adxj/ANyovxytzqq7TXq7S1tU/rlkOSVp gt5Xd2mE446IoPdCRWWgPZZJDhPyqBfSIZe0L5hfaHAe1KLV/DDCGWupPuHf0C7CCptg1ZXUjGxm 6Or2vc7pHV057Z79lB20GuP7Pysgc/picfmU4Tap0nS1Ml+/u3XAxYzgYz3/AHWNLt2MrMaxJHP+ yHP0PWVx9DLa/wC11VTwtiNz/iJfK7pHV057Z9lwlq3XdPql1TPJiJ56cZ4xld9JqDSVHWS39vpm vfF/hAAz3z9yfKumenWFrv7aS4BINL7eepcnbX2s6snip2xm5/xJ7pXdI6unqxjPsuHtG6pqNUS1 EzwIpHYx7DPZd4b7pG31tTqBhZ+Pliy7GMdQ5yB7lNVduqYC7WNVwf8A1Zv83FcnaDa/7VSx0rYz c/4lI6ZwHzY6u2fZcZZN1RUanlqKh4Ecjg0c+AeAu4lu+k7VW1OoGSR/jJYwXYAxkZOR9T5KaqWu pgBdq6r4/wDjaPx/xFcpZGWt2p80oYbn/EZXTuA+bpJ4B+i47T+6TKrU8s87gIpT0j/lB4XayXTS tmrKy/xSR/ipowXBuOnIycj6nPJSxI6elZnVdwPn0IMfuVyemYraL7F+G6Dcvx8zqhw/N0k8A/Rc tprdCOr1NUSzuDWSkNHPHSDwuufXaXsFVXX+GSM1U7A4saflDhkkj6nPKs3OmbO9umoWn+1FywBn 0IPH1K5fS1PbW36J9IWPr3Vc5qHg5dg9gfouZ0zudDV6jqJJ3MayYhvf/COy6ltTpjTc9ffoZmOn nYHemDwCO5H3ypZ2s9OloGkahug8+lAf6rktFUduhvEMlG5slW6ac1Dw7LuewP2Wj0puZBW3+okm c0MnIb38N7LpIHab0rPcL5DUNdLO0ERAkBp5yRknk5W5erGLju7dJZm4v10LQMlkP9CuZ0VS0MV1 p5aRwfVSPmM7urJ+g+wWl0duRBW3yo9Ysa2YgcccDst9TM09pGS5XqGpD5JgHCIOPS0+SMk98rGU 3a6Y9Y6dFZsC83k45xH/AOVcroChoaWvpZaN/qVMvrOnPXn7D6YWv0duLS113qfWLA2c4J7Hhbqk isGjv4jdoqoSGX5mxdXDPfGffK3yurPtm49yugsw6Lley1oy0M8d/lK5rQlDR0dZSz0sz5amZspq MyFwBHYY7Ba7Rm4NJX3WpbOWAVBwTnB4GFtqOnsWjI7ldGVgkDzmOPryGA/1XPKbdMbqab+0t9Ot v/QPmGMf+ArntB2+ko6ullp5XSVE0UjpyX5GfAx2C8Gi9e0dyuFUyVzG/iDyQcHthbO20lm0VFcb ia4Sh5LomdXDQfC1Wceo31sb0TX/AKQA5rjj/wABXPaEoKeiq6WSnmMs08D3Tkv6h1Y/kvJonXFH c6uqZM5rRVE9RB84wvda6G1aKp7hWyVwmBe50TerPS0jgfdTTW29tbQP7QdDQ1/W4f8AuCtDoGhh oaqlMcr5nz07nzOc/q+b2+mF5tFa0orpUVcT3NaKpzskHByRhe20UNr0RS3CtmrvWaXudE3rz0tP YKptuaBjWUuoHsaGu9SXkD/hK0uhLfHb6uH0qh87p6USS9Ts9LschfDRmr6G8Oq6dzmgVL3uODg5 IwV6bLQUGh6Gvqqqv9fL3mMF2elh/K37pWfnbb0bGxWy+yRtAcZZxkDyGrUaEt4oKtnTUvqPXpGy yFxzh/kL5aN1VQXiOrpXOaG1L3u4PPzDBX0tNJRaEtVfVV1w9f53mPLgcM/wj7pJ1o+1QN9o2xbq ahxjBqM/yC4Onj9SYAeSAur3SurL5ra6XGIjoqJesfRczQECrj6uAHDKVvH0vNttbxbdoooqNoY/ 0HEEcfMW9/3W00TQyUcksLp3zmSmjlcXnPzk4OPotTtteaK66OitTZvTc+LoD2kZ5GDhbaxUsWir LVTXSvM8pe4Rlzg49A/KD9VMJrCT52xnq3K/b7sg/B6QvJowI5fWncCOMO918dFUctG6pgkqH1Ln QRyOc/t1E84+iw05eqK/2msoWyiN1S55Dm4zl3dZ2Kmbo2yVM15rfWmL3BhJB+QctB+q1ldzX9cr h+1v8fangFHou8/gWiOUyzlpA/xE91ho2impm1lNPO6dzoWSOLhwHO7gfRY6du9FfrNWUEMvpPnc 8tcOfzeyVip3aNsNVNe6z16hzi1mTz0D8uee6S9a18uuU3LP4yhjbQaCuht7RHIZJSC0Y+Ynus9F UVTSmspK2oNSXwxykkYALu4XzsFfQ3/T9Zbaab0nzl5a7g8k54CysEEmjrHUVN9qhLUPJa0Hv0t/ KO6Z3e/+3OY3l/NFFAy36AuAt7RFI6STpLRj5i7GV6NI0M9KK2grqgVZMbJOotwPm8YXxstXSX/T VTbqWYRyzFxa489znhKwMl0jYZqu/TiSpcekNPBIB45S9212vrV9PnDCy17e1v8ADI2QyGRwb0jH zF4GV7NI0c9Myuoa+cVPyNdnpwPm8YXwtNRTX/S9Tb6KcMmkLnNcfcnPCVgZUaV07NWagma+rf8A KW9jgHjnzws5byvaR8oaVtr24qRao2QyveQ0sGOS8DK9ulKaWKmuVDcJRVdAB6unAIcO2OV8rVNB fNJTW6hmayc5LXHnnqzwsLH+I0zpqaq1DIDVyjpc0nkc4HPlFfCGlbaNtj/B4mQSyEBvQMDLpAOc fdbDTFHIKG6W+5SCq9MYJLcA5Hgey+Nvcy96Mkt9unDKlrSWOPPIdnhFkfPpzS0lZqSVv4uZuHjP I8Dnyg8kFCyx7atZZI2QSP6WtLRjl0gHOPuthpqjmktl1t14LKgxFzDxlpGPAXzpHNvWjHUNumay qjaCxxGcuaeof0RYZKmw6XkqtSSt/GTtHWAeeo8f6rNhHggoW6f25ghsUccEknQ1pa3HLngEnH3W xsNC6rsd0t15bHUmJ7oyC3LSMcYBSa3+NaKFJa5mishYCwnn5mnP9QsrHJUWLSz6rUUjW1lQ0OkH kOIxhaxmpIxe7Wshomac24pYbJFHDI8RNHSMAlz8En91s7TQmu05dLdeWxVJic+FwLctI6SRgFYy MN40S2ntUrDVwsaW58lpys7DLNZ9JuqtQPaysqW9b2+Q4jGCpr1pqX21UdENNbd0EFhhjhkkETAG jGS44JK91LQfxHStyt16ZFU+iXxuBblpAbkYysq1st10VDFZnsfVwNa4A+7efC+tokltekXVF+c2 Orqh1vb2Ic4YwR7rrjNYz7cs++TWxUDdNbfW+msMEcT5BEwBrcAlx5J/ReiOhF60XcaG9RQ1HpGS IgjqbwOCMr0V5nr9Ew/wUtlq6drS1p8loPZFsfNb9FPlvRbDWVTC97DwWucMYI8LlJrTre5WtbRM 0rt9bKTT9NGx83px4aMdRd3J/wCq+01sZf8AQtbR3uGKZ0BkjII6g0tHBGV6Ly2qrtFUr7H0T1dI GvDT7tB8eSsqGSWi0RI+8YgrKwOe5h4Ic8Y5HhdupjPtyy3blv08UdCzSugLXR6fpo43zGOPpaAO ouHJ+6d0tEepdva6jv0DJZITIwg89Lmjggr23r8TU6NpZrMGT1NGA8Nz5a0rOkllpNDTOvAbBV1j XvLD3DnjsfZc8Z3K65dytSaJukdB2ah05SxtdM6OPobx1Fw5JPv9V8dUWuLUu1dyjvdPHLPTNl6Q eeh7RwQVtNSuqn6MoaqysbUz0WJOkck9LSDx5Xwq5paPbCufdemGpqopJOgnsXDsu2Ml4z+uHlt4 5KB1UfpTFp8OIXrsVD/ELtSUmSPWlbHn7nCwun/rUh/4itxt6A7WFp6sBoqGZz91y8muV09GN3Jt dn+GN0ho6z2nTdIwGdwY5gOC49OXHPvwvjqux0Wstt5Re6dr5oerpPmN4IGQVtNa1VQzTNHc7TF+ JkpD1dLeTgtx2/VZZdBoNzK0CGoqvnDM55dg4WVrwG1R6Q0tabTpujaDUP6SwHBPyZJz+mV5Na6e odbbavfd4G/iYgfTf/ijcHAd1uta1s9Jp+hu1sjFSaT5uOcZAZ2/VEnVBoExVgEFRUkODCc8ucDh EeF9qj0dpa12jTlGAah3SWs4cfl6ic/oVrdd6aoNc7bipuUAbVxjqikAw5h6gF0Ouq+egsVDd7bD +KNKc8c/mHRn+ac4NPoBsVUBDNLghhPkuBRGsktsWjtO2yzadogPxBIIZ+bhvUTn9CtbuDpe3a62 7hrbjAG1jA10UrRhzPnAI/bK6LX1bPbrXQXi3wfi/wAN4byPmAZn+azqWmm0BFDVNEM8nTiMnyXh 2P2UqY9e2tktsGi7Da7Pp6jAM7i3DPzHDeonP6Fajc3Stu1zoCluFZAI65vQ6OVow5uXAEfYhdPr +vktlFb7xR0/4oU5OAOR84DR/VZ1rDT6Bp4KkCKZ3Rhjjzn1AcfstYzqQ33utVNQwaJs1qsmnaPp E7i35PzHpHUST58rR7paQtuudHUVzqKcRVuY3MlZw4BzwHAnyMLqNxq99qit93p6c1EcHU35eQOv DR/VemuZ+H0LSQVDRFKfTwxxwQesHH7K6k1pyxtuVt+2qqaOk0JZLZZ7BRlnrE4MY+Y9I6iSfPla DdjRlu1tpe3XV8IhrXOi/vWDDi1zgCCfsur3LrzaoaK6Np3VMcYfHloyAX4aOf1X3ucZp9F22CRv pydcXyO4I+bKuEkkbtt3trKmmo9A2a22aw0b2epkgxDLyG/MSffPOVze7WhrbrXT9tvLYhT3CR8I MrBguY5wBB/RdbuTcjZ56K5tpn1ETI5I8tBIBfgDnwvVXwmDR1pgkb6bw6DLHcEYIJU4yac8csrn d+ttfUUtDoCy220WKkezq5zG3qe4N5JPvkdyuS3j29t2sKC1XuGMU1fPJC2R7BgyMe4A5+oC7bce 6sstVR3J9O6dgidC3p7Bz+ByvVdIzFpayRPHS9ssBLXcEYPKuE1p0ytu9tXUQ0GgLXbrLZKNzR09 f90wucQ3lznY75Hcrj94NtrZq2C1X6lYKSuqpIWzPjaP7xryM5+oHldzuFdY7LcqaulgfK19O6na W9up5I7r23SIs01YYXjoe2Wny13BGO6kk6XG7taeeC3bf2y3WWz0Zazo9VxjjyXdP5nOx5IHJXH7 xbZ2zVbrTfqQfg6uslijnMY/3jXnufqPdd5uDdorLdoqqeJ0rJqQ0zA3y5zjwvbcY+mw6dikHS4T QdTTwRjupjN3tvUaZ0Ns28tNvslrpS2NrPWkcxmS4DhznfU47rjN3NrLdqestN8oMUVRXyRsqOhu RIHHPUfrjyu73AusFpuwkqo3vZUUf4dmPLi88fXhbOujItGmWSAgtmh6geCMBIk1vto2Q2vbq022 x2+DDQwSyPDMl+OHOd9TjuuH3Z2modR3K03u1OFFJcZWNqmtbkODuS77qQdwrlS2y6H8Yxzm1VEK eMAd3GQ8LaV0bvwOl2HjE8XUD9Go1JHP08Vo25tdusdFBiMt9aR5GevnBJ+pwuC3X2go75fbTdrL IKIXOZjKqMN4+YZLx9cKQ9w6+lt11l/HN6mVVA2nZ/zeoSt5WsJj0s3wJWZ/RiunPHu9ucpaeybc 223WKkhaxj2+tK5wyZPBJ+pIUf7p7NUd21DaLhYJG0MVznDKqPpyASC4vb7HxhSPuFcqK3Xadlw7 VVvbTxjGfmMhK31az59Mt7j1Qc/aIrPw3jpytvpdP7fUtBY6anY1jv72VzxkvJ4JyfcgKG/iM23o 7M2PUljaIqaqkDZ6YDAD3DPW32+oUx68raKl1FVx1x/9ZomQRtAyS8vJGPscLW/ESxr9sqdp/wAz D/7ld545cscfuPPj5LwuX9UxIxnPhdHt1peXV2q6GzQzCD8Q4l0hGeloGStBM3Ej8+/+ilb4ZWA7 o20nnEcp/wDcrzeTqdPZ45MqsJb7ZpbQ8FvsTKOmc7BfK+Zgc8gjkhx57hRhuBsrHLrW2ssMwpqG 5ylr2uBPpkAuJb9wpF3BNKNSVorHAOfTxMiGOS7qcePbnC7W5NB1BprPh8h/+tFejPxzGTV9x4vF 5MvJ3lNarkqOw6R0bDb7E63UchwXSSVEbXyYIz+YjOcqKNc7IuZrqgpbDM2K23OR2A8ZMOB1Ox9M dlLm4DqBt6uLa7p/ESRU7KcuGSD1ZOPZdRd251Xps47Ol/8AsZXHCTev47ZXqX+uNpdN6L0qKCw1 Fsoah4aeuWoha+TBBOerGc5UTa12QqINd0VFYZmi23GRxjMp5h6Rlw+o9lLuuH2xt5vIrPT/ABrx Tspi4ZcD1AnHt5XXXYf/AA36d47GX/yLpxkutfDljlbrd+XGU+kNEab/AIfY6q1UFS8NIfLUxNfJ yCc5IznKiLWWydXSa7o7dYnh9tuL3GJ0h5hDRlwPuMdlMmtzbjeLv+LMX44up2UxcMuHzAnp9l11 1b/8N+njjsJv/Is4zvVds7604Sj0TobTz6KzVVso6ifpLZJp2BzzkHB/dRDrHZK4UeuaW22Rwlt9 e5zoXyOwYmt5cD748KZ9aMt77xeJKkxivbLTtpifzfmGQP0yuzurAdX2A45DJv8AyrfGM47+XAU2 3ug7I+htNZbaWepbEWSVEvL84OCfrkqHtV7KXWi1vBabU5s1DWOc+CZ5wWMby7P1HhTZrSOiku13 kqHNbXMngbTnqw78wyB+hXa3WMO1XZjjkQTnP6LnG6jqm2x0HaG0dprqCGetERbJUucQ4uweSMqH tS7L3mg1vFZ7cBPSVRc+nqHHAEY/N1fUKcNXw0ct1u8s7wK9lRC2n+Yg4yMjHkYJXaXRgdq+0uI5 bSzH+QWtaJNo6g2o0Lb46O1XClbPWtgLZKkvc1znc/MRnGeQoY1Fs5fbdrVllpAJ6afqkgqew9Md yR7j2U66tp6Sa73Splm6LhDWwtgHqYJblvUMeRgrt7mwO1jbSRyyjmI/opIYzaNoNodDUcNJa6+E y14gLZKn1C0ufg8kZ45IUMXvaC/27WosdNEaiCXMkNUB8piBwXEe49lPepqWCW93GtfMWVsNfDHE A/GWZbkY8912dwDXa0oDjIbRSn+YWrNEm0ZQ7NaKpYaS3V3qPuJgLXzesWhz+fmx48cKF75tPqC3 auNljp5Klrz1RTsbw6Pqx1H7eQrBaho4p75XXD13sq4bnDCxgfgFmW5GP1XZ12JNZ0OG9qKQj91n 57ZwnLaLINkdIMpqehqpqn+KGDDpBNhpkx3x458KFbjtbqCj1g6wtpZJH9XUydrcsMWcdf2HlWLu 9GJL/UXEVEjKiK7RwBnV8ro/l4x9yuwnayTWdMXAdX4F3P06lq6m4vFE8Wxul/wNPR1NbVx3d1P8 72zjoMnIz0ke/hQvV7Z6hptXGwOpXuqA7ImDSWGPOPUz7KxlXSulv01xZPI2aK7tpizq+Ux/KcY9 8ldlIxr9aUz3NHUKBwz5x1rlc+8sZ8MYby7qI49iLE+2QUstyq4b0afLi2UOj9T3wW5xn6hQrPt5 qCDVztPvo3iuDuH4PplhOBJn/KrL1MEsmoX3JtTKHx3dtIYs/KWcHt75K60xsfrWKUtHULeW5849 Rdb1tqzraH49g7W60xwSXapivRp+pzQ5ro/U7dunJGfqFDMugr/Fqo2CSif+PDukEA9Bbnh/V/l+ qsu6Od2o5LiyqlDo7q2kdFn5XMOD++Sus9Bh1qyYtBcLeG588yrnnlceU+mfFlzky+EOM2BpHWoR m8TMu5p/U9LA6A/27ZIz9lC02ir3FqU2OShk/iAeGYA+TBOA7q7Bp91Z2N1Y7Vr61lVJ0sun4R0W Pl6ODn75K60U0Y11JKGDqNuaCce8i6+TG+Pe/pLl6s9VCp+HzqtP93fH/wAVNOJRTGIdIf5HV5GV AmoLPXWS5T0NygdDUwnpc139R7hW5pX10mq/xzKtwiFyNE6EjjoABzn7lcB8UlDEbjQVDY2iT0Ol zgOSMlMcLlncL9bZx8u5jlPVVwdwMeV8zyvq9uM+y+XhcnqLymEspjhXYMeEHhGUeUAllCX2QNIJ hJABHYppBAeEBBR4RAUee6EID7plIdkIBHlH2QO6AKaSaKCjKPKMIDCAgIJQNLuhCACO6EKgQUIQ CPKMI88oDyjyg/RCAPdJNBQJHlNHlAeUJFNKBIppd1AIQhUNJBTQIJJlBQHZIjKaSBkJI8oQCEIy iAoQkM/oqppIQVQhyghMIRCRj7oKMfQoPpNww/ZeOLuF7JuWleVvfAXmxdq89R/vDwsQsqjHX7pN 7Lo51h90IKOyISZ4QgIAd1kFiO6yH0QfaA4flbOjbPUStgpYpZZnflZE0ucf0C8VBTOnqI4mEdTz 0q2WgdMWrbjQ8uoZoxPcDD6kkzhy0EgdLfYcoKxyU1wZVfhJKWrFUQCITE4Px/y4ysJhU0kjoamK aKUY+SRha4Z+h5U+7Z6oiuu4dXda6MOraoCON2PyMAwAu7vG2sF03IptRSyNfEIwJI3NBAc0YaR/ NXaKpGnuUfpskpKxjpPyAwuBf9hjlfX0LoODRV+frTv/AOithe9RxDcK3WuljYZadrg+Q4Jb1AcD 2XT6mra6iuVup7dAZ2yiR02CB0huOc/qU2ypHJ+Oa9sckFU1789LXROBdj2GOV5JpZoyWPD2yA4I cCD+yu/RVdBer/bqmmMUrooJfmABLCcef0Wo1HtzbbhqqhvzKRhq4Xj1MtBEnIwTk44+ynJdKbSv niA9VskbjyA9pGf3WD5Kh0fqYk9P/N0np/dWH+KGKAXTTQkjY6IOlLm4A6gC3hdfpEWjX2h32aop YhA2INDWtADC0cEY9l1zx46/rHjymcqnzznPlYLf66sP9mdVXG0et6v4WTo9TpxnjK0Cy6DykmkS oBNJMoALJhwc45WIWTRkgKjYUlU6M5z2Xrku80rOkz8eAXLvdk9sv7aXL8TciWWmA/M0d5T/AJfo FYGKi0jX3Co03T2qhAZGachsDeoeCM4zn6rNop5FVSxPLg88r0SXiolYG+ucAdupTVa9hXO3Ano6 uoabFFiZrWuPW5pJwwn+pUniy6LudXUaegtNvDmRmDLadvWPBw7GQfqrKzVQYq2SJ4cHYP0K+816 nmb0mbI9upTPZNhpHa8npLhUNfZICJG9J+eRpPytP+pUmu01oe71NVp+mtFvZLHGYfUjgaJAexwc cEe6bNKjU1fLE7qDiD916Km91U8YY+Ylnt1KX9P7ETya5qaK5ztNmpiJA5rvnlaT8rT7HHdSe7SW hbvJV2KktVAyZjPT9WKFokaexIPuElOlSqe4TRPy1xGOxyvVV36tqIgx07nNHAaXKWNN7E1Uut6q iu0w/g1KQ/rYfnlaT8oPsfdSdUaG0HfmVdjorbRw1EcfQJ4IwJWH3B9+PKciaqqVPc5onBzHOB79 16azUFZURem+Zxb7dSlPSOxVZPrOsor1KBaKMhxkY4dUzTy0cduO6k2r2+0Hfqess1vt9LBVMZ0t ngbiRp9xz348q7S6iqlHdJ6eQua4g5XurtSV9VD6b53lnbGVJmi9jq6s1jU0t8eG2qicC6RhHVMD y0Y8cd1KFdtvoW/0VbabXb6amrGNAZUQj+8aR5HKluuiTc3FWLfeKind/dPIcvdcNTV9XD6Uszyw eOoqSNDbG3Ct1bU099IjtVE7qfI0jMw7gADtx3UmV+1uhb7b663WSigpa5rR0VEZcXNPfsSrurpW CgvFRTO6mSEOB4wV7rjqq5VkHpSTyFmMYypA0Hshcbjquogv4MFqoXZkcCMzeQBjsMd1Jty2l0Vf rZXUVhpYqO4NGY52OLiCOexOMFTZpWa2X6qo5upjn5+62F11dc62n9OWV4Z7ZXcbfbKXO66ong1C w0ttonZmcCCZcc9Ix4x3Kk28bQaMvlqr6TTlO2kuLW5jmEjnYI57E4weycjStdq1BVUcnWxzg4/V bC76wuddB6UsrvT9s912W3Gy11vOpZ4dRRuordQvxOQeZCOelv0+qku+7NaQvdproNNxfhLjGMxT eo5/I5xgnGD2TkaV0tOoqyif1xSODgVsbzrW6XCn9KWV/p+2e66rbfZq6XzUdRDfoZKK20MhbUO8 yEc9LT7Y8qTdQ7L6Vu1mro9LtfT3GMExyGVzwSOcY7YPZWVNK+2PU9VQOLoZHA/de+9a4ulxg9KW V4Z55K6PbLZy63/UE0d+gkoLdRSFtQTwXuHdrT7fVSRqTZLTVws9d/ZQyRXGMEsc+YyB2OcY+qcj pAti1ZVW6VxY9wwfdbK+68udzpvRfK4Rnvyclb7bPZ67ajvsrb1BLQWujkLal7uC9ze7Wn/VSLqv Y3T9ZZKw6QfO24w5LRJOZA7HOMY8pMjSDbBq2qtsp6HuBznuthqHcK53SAxSyObGe4z3W52v2fum pb1J/GoZaG2Ury2dx4c9w7tb/wBVIestirLPYamXR0tQ64QEn05pusPx/hHHcq7Tqe0Mad1nV2yT 5JHd88FerVW4NzvNK6GWZ4iPcdXdbbazaG66pu0jrrFLb7ZTPLZ3PHS5zh3a37e677Xew9sNgnqd G1FTNXQEkwzSdYkA7tbgcFTkupO6rPNIZHknvlYM4d1ZOV9K2nmpKmWnqY3RTxOLHscMFrh3BXxw Twstu+0drirsjekPfgY6SDyttqjcm5Xen9IzPEfnlLZzauu1zUmqqjJSWWI4dOOC8+zc8cLvdf7E UtFpx9w0hWVdbUQOPqwzEHraPDQBnKsy+mbPtHOlNf1docR1kjuOeV7tVbmXC8U3pPkeGexKe1G0 9x1jcJn3Bk9Baqcls0pb0uLh/hbn28rsdwtiYrXpx1x0tXVVwlhcTLFKBktH+XHOVeXwmnC6R3Cq rR8rnvLfceF7dXboV94pjF1u6B7uXy2n2nuWs6+Z9aJ6C1QEiWYtw4u9mg+3ldTuRsU6xacN003W 1Nz9JxM8b2N6g33aG9ynIuLk9IbjVVoBBcT7c9l7NYbo114phCJHBg+q8m1G1dy1pXyPqRLQ2mHI lqC3Di72aD/NdNuNsbNYdO/xWw1811ZGT68b42tLW+C3BOeVOSac7o3cmptBLXOc4eMHlerWO6lb eKcQiR4YPqtdtNtZctb1csshfQWmLIkqXN5LvZoPf6rotydkKnTenhd7LXy3WGMk1DDEGua3wRgn KvI01miNyqizAtlkd9CCvtrTdSsvNOIY3vEYPutTtPtbc9d1T5S51Faogeuqc3ucdmg91vdyNla3 TFiZdrVWvutO0n1wIg0sb4IwTn9klNPPojdCe0McJXvyOxBX01rutV3qnEMb3Bg8k4Wj2p2uumu6 uR7ZDRWyIHrqnMzk44DR5W33N2Zr9J2SO6UVa66UnViYsh6fTHg9zn9leUNPvobdKezx9Mz3hw4D mnuE9b7q1V7jEUb3mMHnK5/ava+666qJJIX/AIK3RNJdVvj6gT4AHGVs9y9obpo20RXGOsbcqInE skUXSI89j3yf2SXfovTZaG3UmtLC2aRzSOzgecJ673Xq71C2GKV3QOck8rl9rNr7vrqaZ9NIKK3R A9VVIwuBdjsBkZ+6925m0d30Xboq91RFcaB3Ek0MZaIznjOU5Q06DQm6stqhLJ5XCQDAcD3Xy15u xU3mFsUUzyPcrltrtsrxrmSSSlxSW+MHNVIwlpcPAHlffc7aq86JpoayeWKut0nDqiBpDWHPAdlX aWfbq9B7rS2uHonmLXAYDge4Xx19uzVXeMRRyP6B5zyVyW2W2N71wZJKPppKFgOaqVpLSR4C+m5e 1l80RFDUVb4q2glH/rNOD0sOeA7PbKzylXTtdA7svtkHRUSObIOM98hebcHdiovAEdPI4tHnK4vb bbW+a4M0tvDKejiyDUTA9JPsFluVtnfNDtglrzFVUco4qIAelrs9jlXkWJA2/wB3HW2mMdTIWyN4 znuF5twN2ZrvhkMjzGP5rhdudtr7rhs81sEUFNDwaioyGOPsCAjcjbm+aHdTm6CKennaCJ4MlgPs SfKnKHFJe3+7Zt9L0VU3RIOD1HgheDcTdia8PY2mkJDeMg8LgNvNuL9rZlRNaWQx08PHrVBLWOd7 AgHOFhuLt7ftETU7LwyJ0UzcsngJdHn2yQOVeRxSroDd8UFL6dTKWSAYOexC1+4m7ct3ka2nky1o wMdlHu323WodaRVEtnhibBBwZqhxaxx9gcHJXn1/oW/aLqYYr1AwMmb1Mmhd1MP0zjupyXjUwbe7 uto6Ix1MoZIB0kO5BC0W626r71GYKeT+76ek44GFwOg9vtQ6zjqJbLAwU8HeadxY1x9gccleLcLR N80ZVwwXyna0TM645Y3FzHfTq9/onI4uQqZBJI4/XK+9pq3UdXHPESHxuDmn2K8pQzAH1WW1pNuN 3xTWlsVXKBKAAQ7yAtRuPu0+5zMbSP8AlZjAHACivQugtR6vp6iosdIHwwYDpJH9DST4BPcrx600 retKVzaO+Uxgkkb1Nc13U0/QH3WpWLKsDoPd+KG3iOpla1wADg88Y9wtDuRuw651LGUkoLWdsHgK KdF6G1Fq2nnlsdCZ4YMBz3PDGk+wJ7leDWGmbxpavFDeqZ1NUOYHtGcgj6EJtNVYrQm7cMdqbHUy ML+GlrznGFzu5W67rhVMZSy/LH2APAUTaK0TqPVkM8lioXTxwY63l4YMnwCe61mq7BdtOXE0N6pX 01RgOw45BH0PYq7iatWT0Ju3T/wlsVVIwuGAWSc4x7LnNyd2DX1kbKWTMcZyA08ZUQ6M0dqHVMVQ 6w0L6mODAeeoNGT4BPdazUlnudhub6C80stJVsGSx/ke4PlNw1VmND7r0slobBVuieRgFknIGOy5 ncndU19bG2jdlkRyADwD2UP6R0lqLU0c8lit8tUyEgPc0gAE/dazUNsuVmuUtBdqeWlrI8F0cg5w fP1Cssnos37We0VupR1NlbDWGKXGAWTAHGO3BXMbkbp/ja6JtNJ8kRzgHgeFDWldL6h1FFLJYrbU VjIndL3RjABWrv8AQXG0XOWhulPLTVcZ+eOQcqTKJx30tRo7dKhqbJHBXejMG4+SXBAx24K5Tcfd X8XcImUsn93Gc4B4HhQvpnTOor/TvnsdrqqyKN3S58TcgFam9UdfbLjNRXKCWnq4jh8bxghWWRdb 6Wv0hufQVtijiuDYqgNI+SbB6cdu65PcPdX8Tc4hSyf3UTsgA8KEdOaf1FeKWSey2ytrIGu6HPgY SAfZaq7wVlFWy0tximgqYXdL45AQ5p+qm4mqtppbcq3XGwxRXKOKo6XAhsnPT09lx+4W6X4i6xin k/u43Z6QeB9FCGnrNqO60rp7Lbq6rha7oc6CMuAPtwtTc21dNWzU9aySGqid0yRyAhzT7EKzKQst W605uLbLrZKdlyZFUljg9of/AISOx+643cDdT1rvGKd+Yo3flB7BQZYbXf7jTvms9BXVUTXdBfAw uAd7cLVV/wCKhq5YapskVRE4skZICHNcPBHgqbi6q31g3CtF4slO25xxVBjcHt6zywt7EfVcZr/d Ns94j/DSf3MbuAD4KgWzUt6rIfUtlFXVEXV0dUEbnDPtx91rrg6oiqZIqlr2Txu6XseCHNPkEe6s sNWrhWXXlmvNnpf4pEypdE4SM6jywtxgj68Li9ebpNkvcQp5MQxO4APYKA7Q28TQepbqesmi6izq hic4Z8jI88rXVs1S2oe2cPZMw9L2vBDgfYg85TcNVciz65s16tVG+6MZPJC8SxkuwWkdj91w+u90 g+9wimkHowkgBp7A/wCqgG2SXY0/qUMVXJFno6oo3Obn2yB35WsraioM7hKXiUOw4OBBB+qbh2uZ adb2W82+hmuTRLPA71Y3dQBaQMf0z+64bXO6LXX6D8PIBDC7DQ3jAKr9bqy5sphJTipMWenqYwlu fbOMeVrqyqnklLnOPV1c57pLIWVc626xst5o6GquDRJPTv8AVieCB0kDH9MriNbbpNOoYDTyAQwn Denx9VXihulxipswun9IEt6mtcW59vZeCqrJpX9Rfk+SUmjuroUOqbBe4bfX3CNslVTu9WN4IyOM c+6iPfPX8d3jkoIXgwt4a0dhz3UOUN5uNPAPw8soj/LwCR+609dVy1D3Okd1OPc5Teu4cd9V5ZHA kkc5XXbV6gOm9VU9e04LQW57YzwuN+y+kJLXZB5C5+3X0vPT3zTN/FvuVwiY+rpyZY3YB8Ec+/8A 1XEat3Nij1VSmCQNipyWtIPbPGf2VcaDUdfTRCOOrexoGOnK8NTcJp5etz+onnJK3K5WfS6jbrpm /vt1zuLI31VOTK3gEH5SOfdcXqvcyKPVVI6GQNZASG45AJ4z+yrnRaouFPCImVJAAwB1eFrqi4T1 Exke8lxOc5Sai91dB9Vpi+1ltvFaI/xMOZcdIIfwQOr3x3C5DVO5cUeqqZ0MjQ2nJa3HjPBP7Kud Hqq4U0AiZVODQMdJPYLU1lzqJp/Uc4lx7nK1y+2Jjr0ulLJpm+V9tvVU9gqIcyFhGWv4IGfsuU1P uTEzVlIYZGtZB1NaR4zwf5KuVFq+408AiZUfK1uACewWoqbtUT1BleSXH3Km4uqufVR6avtxt16q ZmsniBkdHjIk4OOr6jvlcvqPciKPV1KYntayEFgPfGTg/wAlXSj1lcqenEYm4DenBK0lVdqmapMr nEuJyTlWWLq/C6FZS6cvlyobzU1DWPYDI6LPDzg4J+o45XNah3Hhj1ZTem9gjiaWAnxng/yVdaPW tzgpxF62Wtb0jnlaCsvFRUVJlc8lxOck8qTRdrmXC36fvtzorxPVBnS0vfFn855wT9RwtBfNxqeP VtP6ZaGRNMYJ54J5VdKLW9xgpRF6hLWt6QCVz1Xe6mer9Vzz1E54V6N1cyttdivN4pbzJVtbG5hk fCXkdT+7XfpgLR3ncSli1jTFhaGRsMQz7E8qutFru5Q0wic8uAb0jnwubrL5UT1vrOkd1k5zlTo7 +Fy6+y2a73qC9urAyJ0fqvgLyCXjlrv0wOFpbpuBRxazp3Do6GRmEEnnBPKrxR7gXKKkETnZAZ0j krmKy+1M9X6z5D1l2c5Vml3Z6XKrLHabpeoL3+MDKeRvrvhMnSTIOzv5Dhae5a9o4taU7o+gsbGY QXHBwTyq8Uu4dxipGQueS0M6c5xwuYrdQVM9f+IMjs5zweymmd2elxKrT1vuGoIb6K4spntE7oA/ BMoOQ77YHZays13Qx61i6Q0xiL0OrOCR1ZKr1R7jV7KMRPcS0N6e+FytXqSomr/W63dWcg5V1Pk7 XEm0xRVeoI7yyuLKJ2KoxCQA+qD+bHtgdlr6nXFvi1rEPlMfpegHZxx1Zyq+Uu5VaykbHI5xwzpy FyVdqSpmr/xHqEO6sjlTW+6Tr0t5LpaGXUjLw2veLe4ir9MOA/vQ4c49iAvI7WVBHrdjSWuj9H0A 7OOOrOVANLuZWNoRFLI7IZ08E8rkKvU1TNXioEjg4HI5Wt/NW7vpbZ+lCdTfxaO4P/hbnCsEYcAf VyOCPIwvn/a63M1u1rnAxmAQB2cD82cqAabdCsFH6Uj3hwZ0kgrj6vVNTLchM17gQcg5WLjLbb8m M49RbFulJ26nN0bW5tTpPxzW9j6pIBBHtjysP7WW7+3Lml3yvpxTh2eMh2cqCIN0qw0Ihkke09AZ lvkLjKvVNRJcfxDHkFrsg55XTe93L5Zst1J6Wpj0nWx6oNxbXj+DmT8cAB/7QkAtIz2xzlRX8Rl2 pbjUQ+g7IiZ0E+60VPuvVfw70Xyvb/d9B5KjTUl+luk7nvcSwHgJjlxtz+b0zj4taxnqOdl7kYXn cCvq93Ucr5uyVwepiskkwgAjwl5R54QCEEYQqBJNCASQeEIDKEI7Igwj2QCjwgaEkZ5QNJB7IQCa QTVAhCQ7oH9EeEIQCEIKAQDygpoEUIR5QNJCPKATQhAJHujuUYQBQkmigf8Avo8oKXlA8I8o7oKA +6EJIBMIQUCQhAQCAg90DjugPKZ7JZ5KaoXlBCMpd1EHlAQUeUC7owmEeSihL7p9klUCfHujPGEv 0CodRxG5eVh5C9c/+7P2Xljx1BeaenavPOcvSb2WVR+crH/CtxzrAJpeE8KoE8JAIKBgLJh55CQK ePKDe6VYH3ekyO8jf6q2u48ckmy9bFTsdJKadoDWDJ/MD4VP7TUinqo3tdh7TkKw+3e6lNTW00t5 cXNDenB8hIlRztbSVly1VSw0Tywl2XPAJ6W+VcSJraenipPXBnEZALu5x5VftD6x0zY9V3SuhpWU tPOT6bWeBj/qvu3c2nn14+tllc235DWgHwrZ2MrPa6i1byS01TNLUfN1Nnkb09ecdvspa3A1fT6W lgbUtc/8THKGNaO7hx/qFx1Zr7S9dqehuE7Or8NG8McHY5cRyV7rnrjRt0raSruEUdRPSOLoXPdn oJxk4/QJqsvNsjarnbHOdd4HQuqGPlia889P1HhdLbtUxt1rdbNLy4SAN/Yf9VqTuZYDeI6p0uGt hczg98qM6DWNvG69depn9NJNJ1N57dv+ica1LHt+Ko4utib7Nl/qFvPhqGbbVkg455/RcTvfqW2a t1HaPwkpFLEHCV7Tzhzh2/RdhLuJp3SeiW0Ol2AT9Abk8nOOSSuvl/a46+HHwy442VC++hH/AGn3 3HP9/wD6BcAFtNRXCW63SesqHdc0rupxPutYs11k1NEkU+6MKKXdNIeyaAHC+9MAZACvgvvTkdbe fKgtz8NUAZpqTpHd3tnyF0Niktb9WuhpWx/j23GR8xDfmwXHz7KHNm9eNsZjpJXAQOPOTwphqdUa Ss89VfYDH+PmjGekDBI54HuSs6HZUjT/AGsrie/4eHHHnqK5DTslrdqj0qMRmvZXyunIbgkE9iVw und1jNqWSese0Ryux34Azwu6n1DpOyz1l8pzEa6eMZDQMZHt9T5VkZv27CjZ/wDDRcODn0IMffJX J6Xdan6iibRiM17a2Z1Q4N+Y5PYn2XEaa3VFRqSWWqcBHMenGfAPC7aW+aUsU1bfKUxmsmjGWjGM j29ifKaWXTrqFv8A8Mly4/8AYwePqVyOjxajfoG0TYjXComdUuaPmOfc+ey4/S26TKjUM8lU4CKc 9OCeOkdl2L7vpXTbq69UjojV1DQekDABHt9/K1j0zZ3t1dqbjUN1OO0cOOPuuU0XFaxeqd1AYnVf qzmpc38xyOAf5rldJboR1GoJ3VD2tZMenk8YHZdb/E9LaZdcb1RyRmqqGgljcAAjPb75WM8ebeGX GOntIIvV4456Yh/IrldCwW2K50poHMfU5mNQ5py4k+Cuc0bubDVXqf8AFPa1kxxn7cBdMKzTOkzc rxTzxuqKgBwjBwGnzjnzlb7YsldJZMtu964AwIx/7krm9BU9thuFLJQlrp3iY1DsknOOAfstBorc uCsvNSKotDJzgntx2XQRz6b0ey5XelqGvlnwREDgM98c/VYylt21jZMZHS2lxbcb6QOGhuPr8hXM 6BpbdT1lNJb3tkqXMlNQ5rsknwCtLorcalrrrUtq3Na2oOCc4yMYW8gfp3RjLjdaapa90wy2Jp4Z n25W72lrpLWPTq9QY/wkAf8AgK5zQFFb6SqpXW5zXzPhkNQ4Ozl49/ZajRG4VJcLlVR1RYBUn5iT jPGFuab+z+h4blc4KgPdKSWR54bnwFmy1qWadDbAfV1CWj5g4gf+ArndvaKhpailfQPEkslO8zu6 85d9Vq9D6/pLjX1UNS5g/EkkkHHcYW1oY7DoeluVwiqxL6jnPjZ1ZDAfAV0m3QWz/d6hcBhwkeP/ AHBWg2+t9JQVFOaR5kklpnOmcXl2X/6LXaI15R3Opq4Kksa2qcS7BwTkYK2NvhsmhqK41wrBN1vc 6JnXwxp7D6pxNuhtrMUl/cxuHmWUf+5K0GgKCmoaqL8PIZXTUxfK4u6svx/JeDRGt6G7T1dNUOa0 VTnE84PzDBWwt8Fn0Jbq+rNYJup7jE3qz0tPZqmkbumZ02q/PaMOMs7Rjx8pWl0Bb4KCqjbTSOl9 WkD5HF3V868ei9Z0F5NXSTlrW1LnOIzg5dweV7bZT2nQVsrqh9YJ8ve6MF/V0sP5W/orfWmJO9tx CwR2S/OYAHGacDA7HpWp0JbordVNbDM6YS0jZHlzurDz3Xk0brC33tlXRzOa1tS97iM4JLuCvTa6 W2aDtlbUVFcZ+p7zE0uB6Wf4WpjNTTVu+2xli9LTd7NOOmR01QGke68eh7fHbKuSGOZ8zX0scjnF 3V854cvJpPU9u1DR1dDM7obUueSAcH5u6+1nprfoKyVMlXW+u5znen8wdhndoKuU3J/25WXlb9th 6RZpK8ilHTK6WcNI7grzaNtzbfNUQNlkmD6aOVznu6vnPBXk0tqG3ahtlXb3v6BUOe7LXYPzd8Ff ShbS6C09VT3GvE8rnO6SXA4YD8o+6a6n/bpbdZf9KZbrRhu4N9I4Bq3n+a5ikjMs7Y++SAt9uBcG XXVVxrYvyTzOePplae1kNronHsHD+qvlsuVsa8Uswkq9GlqFtu2fjgowInCnw0gdiccrYaMoXUJr aZ076kGGN5c/n5iecfRazQd1oL/o9toM5jLounqaRle2yxs0Pp2aS7VgqKh7nNYSc5aD8uf0XLxz WOm8ru5f19gwQaAuIpf7t5kkAI4w4uHK+mjKCShdW0ctQ6oDo45Ot3u7OQPovLp252/UVhqbZDL6 Rlc4hwPPJys7M3+xGm5qi81bJ6pziBz3APyrWfdtc5N1k6L8Lt9WNocRSOkc1pHGCX4yvTo2hloD X0VRUmpHSxwe4Yz1DleWw1tBqPTVRbYaj03ydTmvB5yTnj9UWZrtF6clnvVU2WqeSAM9wDx/JL32 3bsSMNNt5U/gGiKV8ha0geS8DK9Wj6OWihuFDV1DqkMa09Tm4/MM4wvLZquk1Fpae20s/pSu6i1w POc54WNpEmkNLyT6gnEtXIMFufY8c/ZSztmCWA022z224CGWVwDS0YxmQBezSVJLSwXGirJnVIY0 O6nNA/MO2F57TNT37SUltoqj05Q3LHDk5BysbM2XSWmJKrUM4fVytw5uRx7c+eCrVYPpTb9tAy1N bFI8tDOkYx1SAf6r26SpJIaK6UNbN+JbF2cW4GCO2F8LdJDqDRslut9QI6hrPkdjPIOR/NFndNpf SxqNQzB1ZM0B4yM5zgc+cIz8vO6l/hW2kcdpaIZHhjWlox+aQD/VbDTVE8Wu6UFxc2o9LLckcEFp 7Ar4Ufpag0a+gt9S2OqjZ8jsZyQcjH6p2iSbTekzPqGcGumZ84J56jkfr3Us6Meu68clK+07dUcF lDYJJBFG3Ax+Z2Of3XvsFC+Sx3SguxZVGFz4iS3hwx4BWEQbftHCkttQI6yGMemcZy5vI/cp2qWX TukjNqKZv46cZkAPIcRj9VvHrGRm97eJ9M6z7e0EFma2GSQRRt6RgfM7B/kvfZaF1Vpu6W+7BlUY nSQkuZwQG8EAr4uYb7o2OntM7WVkDGlmecubyP3XotUsmn9JmXUErW1k7et7c89ThjC53C/rZWsM urv21k1M6ybf2yksjGQSSCKIdIwPmPJOPovbR0IrdJ3GhuojqjC6SIlzMg4bxgFY1kcl70ZDHZZm /jaZjS0O5yWg8D7r7UD5LNpDrvz2trKhpe9ueQ5wxhdpP0xu+3PPduXTxS0brJoK1UljjZC6T0og GjAwc5J/RfeOhbctF3Cju7Y6kwmWIktyOBxjK+lw9W6aLhbZJGurKZrS0YySWg9llRvdatGk3t4j qqphdI3sQ5wxyuWtXHTrveOTX1VG6waDtNFp+GKJ0pjiDQMA5BySvtJbm3jQlZSXqOKodEZIzlvU 0dI4xlfe8MqbjoundYXskrKRoc0HyWg9vqnRyOtmhiL04RVdW1xc3GCHPGOR4XbrjP8Atyy3bl28 tRQusOhrRQaehiidKWRBoGAcg5JWdbao79oKtpb7FFM+EyMOR1BpaO4yvvexU12jKaaxFs1ZRtDm s8uIBHC+kMz6DRLm3kiGtrGuc6PyHOHn2XDWrHfK7leGqozp3Rdmt+nYI4nTOZGGNGAct5J/6rG7 2iLUe3VXTX+CKaSH1GnIyGubxkFerUf4qp0dS1NixNVUbQ4NAycgY4HuvrHI+g0O9l4IirKtrj0H ghzh59uV03NRm914qujOnNHWW26dp2M9ZzYxGBgHLckn/qsL5aqfVG3NVDf6aOWSEvbg89DmnGQV 7NUyVcmkqOusYFRU0QDg0DJJxjGE/UkpdDPZdeiGsq8uLM/4nYKx8tWvLW0H9nNJWe1adpo4/wAQ 9sfQPlH5ckn9lqtfWyDUuz10N4p431VNHIYzjPpvbwCCt9rOeqOl6O42VgqJqMh3SOSfl6eB+q8G oZH0W1FwZc+mGqqYXnozn5nDOF0wkuU25eS2Y3XtQqZpZKR7HC2OmLb/ABW/0FE7PTPOxh+xPK8d eMVDx9Sum2sDf7dWYvI6RUMJPtys59WyOuHqbXPrbcNL6atFm03SNYJ39IjYens3qJz+hXg1rp6i 1pto2W8QNNU0AsfjBY7qA4W715W1NLYaO8WmFtU6mPbvjqAbnH6p1eaXQjKesxFUTFpDCc5JcHEL M9J6vbw19ANL2K1WbTdE1jZnFvQzg4a3qJz+i12v9N0OttuYKm6QD8W3pdHIOHMPWGkZW819WVdF a6G82mFtUac4wOfz4ZnH6r6VrTS6Bp6erxFUSdGGZ89YcQP0VrnL8tfcKIaUstrsunKJoExI6WYB Aa3qJz+hWq3D0xb9b7f0VdcoGiraWOjkbwW5eAR9sLodwK2poKGivFthFSIct4Gfz4aOP1X2rY/w uhKSmqsRTu6PkJ89YJ/kkt3J8NxrbhTt0lbbTZNPUYAlyAGYBAaATkrT7l6Vt2uND0FdXwBlbmIx ys4c3qeA4Z9iF0O41dUW2KivFDTfi44ss45A6yAF6K+L8Loihp6nEU2Y/kceeHgn9glnc+nPHe+/ t4q+kj0labXZdO0Yb6nUGhnBw3kkn91z26ej7drfStsuNVCGVpdF0yt4cA5wDhn2wun3HuEtrjob tSU5qmM6ogW9gXkAfuvTc4jS6PttPMBFKHxZaT2w7J/Zaxx1pvL01tzig0bbLZZbBRlocDgRjnDO Tk/1Wg3V0TbdbadtlynhEVc90X97Hwelzh1D9l025NfJanUV1hpjUxhpiBb2BeQBz9V7bnD+G0ra YJsRyMfDljjg4ByU4yWac8bbbtq7jTU2ibTbLNp+ie1nSXARDLsM5JPuua3c0HbNZ2m0XZ8XoV0s kLXSR8Ese4dQP6LrtxblJZ56S5xUxqY/SdCC3sC84ByF67pEYdMWSGQdErZIMtdwQAeVMJ3Numfb V1sNLoi222yWGjcxgYX/AN0Muwzkk++fK5fd3b216yobReuj8NXzSQtkfGMdbHnkH648rrtxbkbR X0twbTOqI3QGnDm9g55IHK990j9LTNjhk+SVssBLXcEAHlXU6TG7vbVVsVJoe3W2y2Oic1jIzIfS bl2G8kn3zjkrk93ttbVq4We9xM/C1tTLFHM6PA9Rrjzn6j3XYbj3dlmuMFW+nfNHPTGlaWj/ABPJ AWzukfRZNPRSfLI2aDLXcEAd8qYzvtutNVih0HRW6x2aiLImxes70mZyG/mc7Hkgclcju1tja9VV NmvdKwUdXWyxMqDGAPUa7kk/UDyu03CuzLPeIZ5YHysqqT8I0tHHU5zuP2WyubCy2abhf8r2TRdT TwQAOUkSa209T+A0FRW6x2qkLImRes4xsz1AcEux747rjd2trLbqe42a80f+xT18scdR6YHztdyT /wA31Xbbh3SO1XYGaF8orKNtLH0jOXF54/Zbi4MLaXS8buC2aMuB4wA1Gpr5aGZ1u2/oLZY7fTdE DIvVeWtyHDOCXY8k+VxW6m0lu1DfLNdrd/sb7jMxlUGAcggkuH1Xdbh3KG2XZwqYXyNrqJtLHgZH V6hP9Fva1haNMMPHTK0uz9GFGZq+3Ol1r2+oLbY6CAMgbGJZD0/nHYl31JHdcHuls/QX7UNmulqd +CFymayrY1vBBHV1D6+F3u4Vxp7bd5Y6xjnCuom00WG5HV1k/v5XRVrD6umR4EuT+kRU+dLHMQPs +31NQWKhh9OFoE0hxnqzwc+xJC4Lc7Zuhu2qrTXWaQUUVzn6auIN4BwXF7R4JXc6+r6ahvtbFWRl 342jip4eM/P6hP8AJdZXsBuGmwfEjif0iK3lNdOWF3d1y9L/AALb6G32KhgZFFj1ZSRkvzwTn3JA UeblbL0Vx1haqmzStoqe5zFtTEGZDT0lxc3njPbC77XtbS0V6r4q0EvrKOOCHjOXdef+i6y5Ma66 6bz3Erj/APWisa1dfxufFcnSjT+hG0Fgp6WJjA31JS5uS7PHc+5ChL4idtqPTr477Zf7qlq5OmSn A+VriM9Q9s+ymDcCqpKfUtwiqs+pU00MMIxnLuon+uF4PiYj6tB0jXf/ACRv9AvTPFLljP48mPmy 1bZ8qcD5SR7LqttNKS601bR2aGcU/rBznyluelrRk8LmZm4kkx7/AOimH4WWg7n0nuKeX/yry53U e/GbT5T0WlNGut2n/wABSv6WEvdLE1z8EHnqIzkkfzUV662QDteUEFjnEFuuTnEtdz6RaOogfdSH uJJSN1JcmVJAnkbTth4yeHZ49l3d1H/w3ad4/wDkp/8AcLvn45jrXzHj8Xkyz3v4rlIbRpLSZoLE +20knS3pc+aJr3gOzj5iM91Eer9j5YtwKGhss4bark97m9fLoQ0Zc36/RSxrqW3tvd2hq/TNXK6m bTlwyW4cCcey7G6DGstPcZ+Wf/yLljO9O+V9a+3Gw6d0Xpl1FYpbZRTGNha6Soia+Q5zg9WM5yVE Wr9jqmDX1Fb7LMP4VcHucx0h+aBreXNPv9FLusZba273ptWIvx75qdlOXNy4Yc0nB8cZXa3NmdX2 FwGcRzf+VauKS7cPFpLQ+n3UVkntVFO5kbmPlnja+TkHBJI5JJUP6s2QrqXXdNbLNI19trnOkifI 7Domt5cD78dlMWsjb3XS7/ifSFf+KgZAXD5u7SQD+pXbXRnVq6zkD5m085H7LOm64SLROhLHLR2a otVFPM2IxvmlYDITjgn3JJUPao2RuVLrqG12lzZLfVl0kUjzgsY0/MD9vCmTVrbe67XaSocwXEVk DYMnDsZbwPpjK7a6NzrG1kD5m0sxH8lbEnbgItvtA2qSjs9VbaWarZAY5KiQZeXc4cfqcqHdR7J3 mk1wy0W0sloajqlhnc7BEY75+oU1aqioH3a5zTOAuLK+FkPzYJbkZH2wV21yb1a0t/HLaKYj+SaW do+ZtloOgFJZ6yghlrGQenJUlxDy7kBxGcZyVDN82VvtJrttjoumWkmzLDVu4HpA8kj3Hspx1JT0 T73caiaQNuTLlCyH5sEsy3Ix5HddrcGh2tqEY7UUhH7hauJJtHbdq9CUsNJaK2mZJXNg9N9SXljn P5+bAPfn+She8bN36j1wLHTs9ankzLFV+DFnBcR7j2U636kpZL7XVcj+mvjusUcQ68Es+QkY8jkr t6vDtaUeBnFDIR+6zZIzheSM49odD0lPS2qsZ13Iw9Dp/VLS5/POPB7KGrptDf6TWwsUMTpoX/3j KoDgxdWC4j3Hsp6vFLTzagrKwyFtZFd4oWDr7s+TIx+pXaVADtaUpwP/AFF/P/fVynHZO4jKLZrR kdLBbqkym5in6XziUgGTtnHg9uFC9ftNqCm1qbDHC6UH521IHy+lnHXj6eysBVUcUt8q68yubUsv McAb1cOj+Q9vuSuzlaH63pX9IyKB3P8A31zzvG2fTPj3nOVRcNkNIuoorfJU1Lbv+H+aYT/KZO2e kj38KFZdrdQx6yfp/wDDO9Zp6vX6T6fp5x6n2ViJqVrtQvuQmeKkXltN0dXDo/lPb7rsnRtfrVsn Th38PwT/APRF0zlx3prXW0VjYvTL7fHRPraqK8/h8ue2cFhk7ZwR2z4UJy7aajZq52n3UjhVtOfV IPp9GcCTPsSrGQwOkv38UE0onF3/AArmZ+Ux8cY98rshE12tmSOHzC3hufp6i45ZXG5SfCeO8pMk THYexPtbaX+J1MV6/DBxxIHR+p27EcjPthQsNvdRf2sdp91E5taHYLyCI+nOA/qx+UqyVNDMdRm4 tqpRILwaR0eflMeAe3vldaIQ3W8kmPmFvYM/QyLtlLjuJctSX7RG7YS1OthgjutRHevw/X0dQdH1 9vbkZ+yhf+wl/GrP4A+ikFf1huSD0dJOA/q7dP1VlaVlRJq5lb+KlBF0NK6PPy9AGR+uSuviia3X kkoHzC3sb+hkXK5WXKX4h48+er9odm+H+lNreyG9Ti7/AIcSCBzW9AfxxnHIzn2UKt0XfHak/gn4 KX+Iep6Zbg9I8dRd2A+qsxSurRrT8aypl9I3N1K+PHy9AAI5+5XYUtLGNwqmYMaHfw9gzjnl67Z4 3C2X6SZ7ks+doWk+H/NpkEF9c+7fhxK2mdEA3r446s8jOeeFAV7tdZZ7lUUVxhdDUwu6Xsdxz/0V tqB9e7V0df8Ai3ei+4upHREcdAGQc/fwo9+KOhiN9o52Rta/0AHOAwTye6Y4XLyXD6m2cPPLjjl9 q8Hj9Vis5uCeMYXzC5vUDwhvZLPKY5QNLHKCjygD3KWcpoygRR/VCaoQ5CEYOE/CBH+iO5Qgog8I KChAk0eEIBCfhCoEkeE0AjwhB5QCEIQCEBHlAIPCE0Cxyml5RhAFNJCBlCChAJeUykgEFNY+EU0k 0d0Ajyj7phBie6aEFAHsjwhA5QIICE0GKfhGOMJoF3QhCoPdJNCaTReUyhCaAEu6B2TCikhCM/oq gSz90FGFQpT/AHZ85Xnj/mvu8/3ZXyZ48LzR1rzzfnPlYgcd05uZDnugDIW4xWGEZ9kwgqoX2QhB QPyswsO6Y7IPtEcPHC2lIJ53+nTxyyydw2Npcf2C81mo5K6shp4sdcjg0E9lbDTtgtG1mhpLv6Qq Lg9jfUqHDkl3YD2CsSqudFY6oMDYpzM3vEIyXD7jGUSSTMl9N7ZGyA9JYQQ4H2x3Vidmr1TXHV9z uNVEx1zrnZMgaOBxwuqg2yiG6VTqKZ7JYJCZgx7B8r88Y/bumzSqnVVMcIvTnD3chvpnqx9sL6GS sAwY6kD6xO/6K2f8cpardM0VLTRl8LDBJNgF2c+D7Lob3c57ff46WnpBLSCAzzPAALACQeT9ArtN KSyTzghjvVDjyGlpB/ZfF88gJbl/Vn28q79tjt1y1Oa6lZDKRSY9QNBIJPbOFz9VtnbW6+p9QQU7 HdT8yxluR15z1/Q/onI0p+ah4bl5II554XzdVSP8npP04U7/ABIQUkO4VnfJAx8IpQ57MABw6zwV IdNa7JuRocUL6eJjGRhsbo2BvpOAwCMe3srtmetqdyHlYrZ6ltTrHfq+2PkEzqSZ8JkAx1dJxnC1 zBlwHfJRpjwCAssADv8AurKfDXQWZtNMJKaGW4zO+Z0jA4hueByt9pvaRlNubcbvcIIJ6AymaBpY OkOcc46cY4U2qpfng5R5Uwb4UrdQ7mNotL0BllZCIDFTxgZe0nPAXLO2u1qO+m7hn6Rg/wCqbTbi Vkw4PHdby1aQ1BdqyqprZZ6ypnpXenOyOMkxuBxg/Ve2j2+1XWRGWl0/cZI2vdGXCH/E04IQ20lL VOgxhxHleuW7VEzA10pLfbK1tTDLTTyQTsdHNE4sexwwWuHBBC+GSD3QbWGuex3DiDnPC+896qZm BpmeW+2VrrZQVl0qmUtuppqmpdyI4mlziPst87Qeq2DL9O3TH/6u5DTWQ174XdXWV6J77UzsDDK8 tA7ErwUlvra2t/BUlJPPV5LTDHGXPBHfjuvfW6Wv1tpnVNfZq+mp2/mklgc1rfuSptHyp7jLH8zX EFemovdVUR9DpXFo/wCJPR9LRVF+pGXVjpKPrBcwHHV9CfZWS3R0ZpuDaS43K3WWipapsLXxSRRg OaeoeVZSxWSluE0TupriCD3yvXV36rqIwx07nN9upGjKWhqdRUrLqx8lH1gvjacdfPY/RWK3Y0Pp mk2ouF0tlloqSqbGx7JI48Ob8w8pv4NK2Ut0lp3hzJC1wOe69NdqOsq4umSdxb7dWQucdnqIzzlY tyc8nKu103lFd5YX9THuDh9V7a7UddVxiN8zyz26uFjoHSdZq++wUNKHsgc8NmnDSRGPP6qSN+dv qHS1LZI9P255LGPFTMxrnufjGHOx+quM5XTGeUw1/UY0l5npHdTHkY+q9Nw1XW1TGxSTvLD4zlc7 FTz1DHvghlljZkucxhIb9yOyyjoKqSIyR08748dXU2NxAHvnHZTbWm5ob3PSOD2vOc8HK9Vx1dX1 zPSlqXuZ/lJXLRRySvDIw6R+M9LQScfYLKWCVjS57HtA4yWkY/dTZpvqC+1FJIHxSuDvfK9V01hc K+L0pJnmMeM91yTQ97sNySfABJX0EMhHDX8cn5Sm106K2aiqKJ4cyZ7Hdxgr13bWVxuEHpyTuewe CVx3nDeTjsOUhx5wrs06m0ajqKN/XHK5rgfde2966r7hD6UkxLO5HUVxI7gNGT4AHJXQ3vReorJa IbldrTPS0M3T0Svxg55HGchNpp67TqqpopOuKUtP3Xpv+urjcYmwzTuLB4z3XDh2DwViXlNrp2dl 1ZUUJBjkcHA5BBwvZf8AXdwuUIZPUPLB4J7rgA8/qsS7PKbTTurBq+rtruuKQjPsV6NQa+uF1iEU tQ8s74JUfdZx3SLj7kJs4u9sOtau1u6opXfoVnqrX9xvdN6E8zvT7kZUf+oRxysC72TZxfWeXrfn usI5Cx4I9+F8ycpeVlpI2kdcVVnjxHKQR257L3am3GuN2hEc0x6B2+ZRcHcY8Jl/1JWpU0krTGv6 q1jMcpaR5Dl6NVbl3C9QMhdUOLRz34Ci0O48o68duU5JpKOldw6y0j5ZTkDuDyvvqzcu4XuEROkc 1g/4uVE7ZSPplP1D3zlNmkraT3GqbQ3/AHjgeMEHuvpq3c6tvcTYXSODW891ExefcoMh7kkps0l3 SG5VTaG9Je7qHHUDhPWW59ZeohD6hDR3OVEHqOz3QZD7/wA02cUxaM3MqbOw9crwRwCD4T1nujWX ljIvVcWD3Kh0SlpyHEJGTJyckps4pp0ZudUWdhBkcH9vzdwvlrjdGtvLGxNlIYPOVDglcSj1Dnur tOCbNFbpVVni6XSlru3VlfLXG6Vbew2P1j0t/wCLKhkTOHYlIyHups4py0PupNaow2WUggYznwvj rzdapvXRG2ZzmN8k8qFBM8dkjKXd8ps4p50NutLa4QJZiHAY5J5C8e4G6dVfMRskJjHue6hNsrvD kzK49yf3TZxT5ojdiW20wEkpDxwee4Xh1/urU3otZFK7pHuVCQmeDnPhJ0zie5KbOKwmht2XWyj6 Z5ix44znghazX261ReXhsUh6R257qD2TuGMOIQ+YvHzOV5JwWH0Ju2630hbNMWuHByeCFrNwd1Z7 1M0RynobxkHuoLE7h2dj9UOlce/Km141Y3Qm7Zt9EGTS9LxwcnPC1e4O6094mZ6Epw3AyOM4UEMq JGng8JPnc7uSAnI41ZTQO7hoqLonl6ZBw4H2Wj3F3Wmu87RDIeluMY4HCggVEnGHH90nTucOSmzj VmNC7viioGxzTAP7EO7cLld2N0Zb838PBL/d4wQ3gKEW1DmnLXkfRYSTOc7Ljkps4/bKof1SOJPc r1WatfQ10VRCcPjcCCteSTym04+6y2tTt9vAILQ2OolaHjghx7YXO7ibry3WtjFPJlkZ8HhV/ZUy MGGOIWUlQ+Tu7n6LUrNm1qdC7uxwWtsc0zQ4cFr1zO4m68lzrGCmk+SPng8ZVfo6uRnZxwsZJnSc lx/dXcTitfondyGO0siqJGFw7tkI8dlyu4u68lzr4/w0nyRngA8BV9ZVyM/KcJPqHPHLufum4cat jovdmnNoZHUujeW92yAHGOy5TcPdR1wuEf4eT5IznAPCr5HWys4Y8j7FKSqe88n9U3E41bTSG6tJ LZmR1npTFuD0yAENx27rkdwd1HV9yj/DvJjY7OAeAq+xV0sR+R5H6rB1S55y85/VJZDjat1pTdKj ms8UVZ6U44IbKAQ3HbGVyG4O6hrrmwU8v93G7IAPAVeY66WL8jnAeQDwvm+re485++VNw4Vb7Sm6 FDVWaJlc2Ko6SCBKAQ3HbGVxu4G6jqy6s/DSH043ZwHcfZV5irpWcNcQsJKuR5/Nk/dWWQuNq4Ol 9zrfW2aFleyKp6CHNEnPSR2wuK3B3UNVd4zTv/u43Z6Qew9lXiC5TRNIZI5g+hXzlq3SOyXOJ8kl NxeNXG01uTbLhZ6dtfHFUGM9bPU56COxH1XD6+3UNRemGnk/u43cAHsD4VdoLnPCMMkc0fdfOWsd IclxJ90lhxq5Fh3FtdytFMLlHFUPid6sZeeWEdiPquG1zup699jfDKfRjOAAewKrxBdp4W9LJHjI 8FfGesdI7LiSm4caubZNwrTc7VSOuUcdTJC71WOd/gI7Eex4XB643TE19idBJ/dRHAAPYKu1NeKi AFsUz2sIx34XwlrXSvJc8k/dOiyrn2bX9oulso5bjGyeaB3qxuLsFhxjj9P6rg9bbo+rqCJ0Mn91 E7ADT2GVXenvVTTM6I5nhvsCvLNWySPD3OOSeSSm4mqurateWa50NDPcWNmnhPqxPz+Q4x/1/dcB rXdH1dQwugkAihJDQ3jAVdaW+VdO3pjmeG47A8LzTV75JOouJJ5ypNLq1dW1a4stzpKGquLBLUwO MsbwQOk4x/RR/rHdEO1NA+CUCOF3SOk9gq60t/q6eLpjne0DjHUvJPcJJZC9zsn7qzKRm4Vdi36y sV1hoK24MbJWU5MscgIHTxj+i4HWO6AOpoHwS4ihOG4OAM+f2Vc6bUNXBH0RzODcYxnwvFU3CSR4 eXEknnKbkXVXXotVadu34C4XCJslbTEyRvGOMtxz78KGt9NeNvhfSRPBhYeAO33UO0Wo62mi6I53 NAGMZ7LWVtdJUPLpH5JKuOXHuJcOXVeaZ2XOx75Xa7Saj/s1qeKuB6D0GPPsCuGLsrOF5Y/Le65+ 3aL0RXrS15mt92uEbH1sAdIw4BHII591w+qdzWt1ZTOhl6Y4ctaWntnuf2VcqPVNfTQiNlQ7oAwA T2C1s9zmnkMjnnqJznK3Mvty4Sel2P4tpe81Vvu9a2P8XADJ+UEOJGOffC4rUe57BqynfFI0Rw5a 0g8DPBI/RVxpNWV9PCI/XPSBgAnK1tRc555zI95JJ7pLIXG1dOSr0tea+33qr9MVcAMhb0gtecED PvjwuPv25rW6ugfHKGRRAsbjxk8/uFXSj1hXU8HpCYkAdIyfC1FVdp5pzI+QlxOc5V5RONnpdWeT TF3uNBe6l8baqNrnuZjLXkggE/UeCuSvu5kTNW0743tayMFgPsCef5KuVLrO4QU4j9XqAHSMnstN U3Waaf1XSEvJz3U6LKupUM0zeblSXuolY2ZrC90fcPODgn6jjBXK3rcqJusYHMc1rGNMYPsCef3V cqLWtwgp/RMpc0N6Rz2Wkqb1PNU+qXEknJJKssNVdKqg05d7pS3uonY1/plzoieHOySCfqOFzN23 IgbrKnexzQyNpiGfYnlVxpNd3CKn9D1S4BvTyewWiqb1UzVJlLznOc5U6NVdGqoNP3e80t8mqGtI jMjoi48v7h33HC5247i08etIXMLBG1nojPfpJGVXKl19cIqURGTIDcZytDVXyonqvWMh6s5zlali 97XOqrXYble4b6+paxpj9R0BfjMmctd9xgcLQ1u4dLHrWFzekRtj9EZ74J5VcqfcGtjpxE95JDen OVz9Rf6iar9frcX5znPZZ1EkvwuVPZbNXX2K/GrDI3R+s6AyY/vM5Dv5DhaWq3ApGa2iLQz0hH6I JPPTnJ/VV1p9w6xlIIpZHHpb08Fc5U6hqJqwTmQhwORytTXymr8LjzadtVVfor6ys6KYtFQ+EyYP qg5Dv24wtVUa9oo9bREdJi9L0ATwcdWSVXWm3FrhStie8n5enOSFzVXqKolrPX9RwcDkcrPGeySz 0uNJpm3Tahivza4ikDRUmEPwTLn83njHGFqzrqhGtucei6EQB3Y46s5VeafcmrFH6Ukjgenp4Pdc vU6mqH1omDznOQQey1e52tl9Lfs0rSjULb3/ABF34AD8UIQ8A+sT3x7Y8Lwt1tQDXIDiDEYRAHZx x1Zyq90+5dY6k9N8rs9PTkHC5Sp1NUPrxO2QhwPUCD5WbjvdrOOPHUnpb5mlIm6oN6/HuNt4q2x9 QyJSRnI9sLxxa1t/9uZA4j0nQtgDs47OzlV+h3NqnUQjfI4Hp6Tg4yuUl1NO+vE7ZCCDkEFa972t luv4txHpUx6ofePxxNryK1rA4A+qcA5HPGF54dXW3+3L+p4DHQNgDieOHZyoBh3QqnUZidK4ZZ0k g4XH1Oq6h1cJ2yEdLuocrEwne/lZ+utLZR6Snh1X/FRXj+DB340NHcykgEH6Y5ysKbVltdrubqfh j6dsDXdXGQ4nKgeHdOqfb/TdOQejoIB7ri6nVdR/EBURyEFrsjlb97t9pZvUnpaum0nXwaqNe6tb /BY5PxoGPzPccEd+wHOVEnxGXSmuNdG6mdn02emfqtTHuxVS28xGZzSWBp+ZRpqS9y3KVxc8kZTC 8crn81jHwzUx+I5yXnPUOcr4lZyHJK+a5PUSyCx8p+UDSynlCAQgowgEBAQVQIxjwhCBZT8I8oHd EL7poTQY4x3TAQgoAoAT8IVC/RNCQ5QCaPsgoFjKAmEeUCQExygeUAkmhAk0IxygEIR2QCEIKACC j7hAQHZIpkoQLCaPKEUgjynxhJAdygoGUIgQEIRQhJNAIR4QgXZHlNJUCaMcd0vuqDyhCEBwkn3R 4UAUk0u6IXhLpWR7pKjBx+U+wXzby5N/+7+6xYF53R55uX5CP8CJTh5CQ7cLUZrEJhNIhUGOUICC gFkFjhZNRHVaAb1aioOM/wB6P6qzm+nX/wBk7hCC754HO6RnABJKqjYq11DWRTRnD2nLVY/R+51q qLE+jvuHsdGWOjd/iGMEKwR3svS11fqqCKhlMbeoGR45w1WyqWF9PLRxz9E5iLevHLcgjKgXa/Vm mdOXC7yRxNpoZZXGFmfyszwMleiwbl08mtqurrJ3MonSHob1eM8KWdg21o6i37tXCjqpXzyQzOYZ XDBkw782PqpE3L1dTWQ1ltma989XRSCJrByXOyB/NaOHWWlpdZOvEjv7xsDY2EO4yCTk/Xle2s1R ouuvlPd6prZa2nb0xPc/PSM57dldIy2Tt9xtdA+C7xOiqnRNkDXHJ6XEYW801qmKs1JdLTIcyw1T 2N+wdhaiHcawR3qoqjMQwwtYOR3Byo10Nqy30+5F2utTL0U1RUPkYCfBcSmk28nxPvxra2N9qIf+ cqQPh2B/svIT74/mFGe8F3tWq9w6CWOdzKGOBsMkjcE/mJOP3Xdag3EselNIQ27SrA1/R0j3HHc/ Va13tL6sV93P/wDu/v3t+Nl/8y5mPl2P1XrvVU+tuE1TK7qlmeXuP1K8sQzIAcYPdW3dJNTSZ9gm 3Gq1FHFb3iNowZHntj2Vor1DUVFrqaa3yiOudH0sf/lccYKgzYe96f07YXy1cjGVkpDnO4zgeMrb 6L3Ggn1RWyXKrDaUvPQD5GThZm5drZuabbZOyxROvNXURsdc3VDo5JsZdkOwcH2XRnUun6StlNRd KgvjeQ5j3gtBB9sLUW7XllptUVkcD44qSVrSHAADqHc4WupqPb2hu892fK+ed73SOZO8Pj6ick9P ZL3bUk1NNhpW90l13ErobP0/wx0LHODGgBz+cnAW5prlNJuHUWZuBRR0zJegDA6nAkrgNFassp3A uNya2Cio3MbFGyJgaD05GcD3ytxRaps7dzq64fimimfTRxtcfJaCD/VLP1rPfL+IO+Iqigo9y6gU 0McTH08Ti1jQ0F2Dk4HlRfG3rcGjypP+IK60l415NU0D+uEQRs6vqAcqNKX5ZW4591vLu9LhuY9r Y/DXpygodLy3FtOw1s2OqZwy7HsD4C8Fv3gbT3CpiuvU6Fj3MAaeDyQvRsdrC20dgbb6iVseG4JJ X2oNIbeWq5z3OoqTXSO6nejUlrmAn/h/6rGOuN37XK3lNenz21sz75rO56ltEMFttcjGsBiYA9xA Oce2T3UoQU1vvllrIJpTcaV7S2RszR0nH0XIaD1nYmTVdJTsgoaZ5wxjMADuOAtrp+6aesEElvpb iZY5ep7nykZafYfusrfXSodoh9DU4iA+VlSWgewDlandP5djq8DzTtH/ALoKCJLJbf8AtYko6Ktx bhMJfXkxwDyR9eVYXWU+nbnoaqs9RdAyB0WOtpHVxyP5gLX/AJJq8VQdLcXylH/zQf1VrN3T07JV jR5iYP8A3QVZ9u7cyu1ZSwTTshibJ1Pkf4aD7K1GtxY7roSstFRdA2IxcOaBnLeQP3Vl/bdTLG2a ikM3Ejvuk0ZIGM5KdR/vnj2cUo85zxnwo2sr8PmqWwRU9kpqeKJpILnNHLj7krvt69ayaUEVJCxr nVsT29RGSB2KgLYy7QWzU0dRVnDeAP3Vi9WWvSup6uG636aKpgp4XdFOXYGTzkkFXxamVuTl5d3j xct8O/4eqsNTbfw8Yp2td1fLy8kc5Xd01ws4rquyenBBSUsboDGQAMYxj7YK5/aWns9sbca2knip aWolcYKbqJ9Nh7clRTvjUttWsjUW24+uK8Ole2PgRnOMZzypI3t3O2ejGW3WGobhaKamgtfqvbBU Pb1HpAzhvPbuu31fY7fqLRFyjuQgrWNifIx7G9PS5rSQQe61e116oa3Rv4B1S2OV0Tmue7nBc3BK 3dojoKWwzWF9xjk6onA1HYfMMHj6K4+5tjPlrpw+xujLXYNFy311Kya5vje90sgzgNBIAz2C9Ns3 EsV3paiK8RQMhkYWFnQCSCMEdl0Wjqq3M09WafbWRl0XqQCc8BwIxkBcRYdprBZ3VFVfr0LjCxuW RszEBjnnB5WMJddulvfTo9rtBadtdFW3a10UWamV5jdMOsMj7tHPhdUaG31lNUQXQ2uWnkYWYjYA cEYPjha/SlwtdbpuqtlvnbBEetkRcc9LSMD9lzVt0NSWyKpn1FqL8bTMZlrIS6I/Uk5Of0Wmd3at 94obfp/c+sipWB1to60mJpOR0jkc+V2+725VLqvSUdpp4w3oe1+fq1cXVxW2t3Fna1zhanVh6epx J9PPYlShv5eNO1ugqGhszKdtRBIwtEbAMNAwQqK1n8xCCssckn3WLgo2WfZLwnhBCgxQD7oIRhAH ukUHujCDFNGMhMBAu6P0TRhAcgo+yWEwgAhLynjKBrHBWWEEIMclCeEiM90D+6Egg8op5/VBP6Jd gn4RBlAKWE8coGCjIwlhJBllGUsIQGfqhCYVCKMcJoUAEFCSoaPHBRjlHYKAJQjHhLCB9uUvKPom gXhATARhAZwfdZZ84KxTQZAoysQE0GQPKCUuUFA01j4THCBglPKXlLBygyJ7IBQjCDIOSzk90scc IAQZdXCOrHlYjkp4QNHVlY8+EvKDPKYcsMLIBA+r6J591iAmgefKCVjhNBkHYTz9VgEHsgyBR3SH ZCB9SOpYnumED6iQnnlYJqB5ymOFiEd0VnnjhAcccrHKOUGYcn1/dfPsUvCD69ZR1rDxylnCD6df KOsL5poPp1n3SLyvmnlB9Os58cpdZHlfMlAPkoPsHk/RLqWGUu6D69fHul147dl88jslzlNj6h5y U+or5fVPP802Pr6jhkZICQec8lfIk+CjuVdj69bs9+FkX5918fCM8YTY+wcR2cgvJPHhfHP3RnlB 9xIR2P8ANAl4xkr4fVPIQfYSd8Z+vKPUPucL5ApZwg+7JT1cFMynPuV5ge6fZB9/VOCQVi6QnjJX zzhJAyVjnlNLzwgP9U0kwgO5TQEIGeEvKAUIAoQUeVQFAQhEo8oQgoDKEkIH37p5WJPKYQNIn3QU eVQ/CQCEIGUIJQTwgMoSTycoAIPdA4R4QH3R5QhAeUI8IBwUAhCfhAkd0fRCAKeMJFMoEg8o7IKA QUfZLuEDHJR5QkihCYR9kQkIKMIAISPKaKEYQglAeEvKE+60BJNHhAJISyoH3Rn3QEKASTPKXYqo D9U8BLul/wDT3VHwJyw8pR9yk3/dlZR8eOV523mlH959EAcJy/nT/wAK1ErDylgZTASd/RUHcZTw hCAwmBxlHdA7Yyg9EBwe/P8ARe+nfK4lsTZHu9mgk/yS0/a5rtcYKOnID5XBoJ7D6q1VPabPtHol tVDCya4T4a6d7QXPcRnH2VZqrDZZ3SFjWyFzThzQ0kj7rJtS9r/8RdnGB3yrKbEVlDU3C51D4I3X KtmdLI/pHYuzjstxpXa2O3bjXK+VXpzwySmaAOYPlc4kkAfRBVoVcrcDqeHd8YOV9Px0+PmfIB9i rbWG60Fz3IuFPS0kB6WNhklMbeolpIIzjst1XXBtLqOWk/h7DRQwslkmEbcN6s9yQrtNKVPrXk49 Qn6LB1S5vzBxyVd20W62VeoLnW09NTSExRNEgjac/TsuYt+11st24P8AGYqSKSCbLjE9vUI39y7n jklNio76t/T+Yg/VfJ9W+QYJLhjjlTTvZT0FNu7TvqKWJ9K2mhc6INAaTz3AUl3/AErZ9yNER/g4 YKapgb1QSxsDQxxwOcdwrrV0m5raoZOSSe6GOw7K+1xpnUNdUUsjg58MroyR2JBxleccFWzV0s7m 3uZWysaA15H6r6OuMrfyvOVrsozyoNsLnNgHrdlN92mcAA8484OFqC4oznuhptf4jKz8r3Z++E33 SYsGXnI+q1XdIlDT71EzpjlxJ+6xgdh2QRkLstp7BS3/AFfQ01ez1abq6nxns7Hg/RWK3Lp9F6Nt 7Gz6cthfUNeGD8O0YwPfv5SXd4xMrx1b8qq01wkgwY3ub9ivRJe6qRuBI7H/ADd1pZwDK4jhvUSB 4wpd2n2fqdUUjrpfpZrfZwwmMtwJJPqM9ghpHsF4qGPy1xafcFfSovdXIPmmOfvhdNTaIorruVJY LRWzPtjZQPxDwOvo89uM+FYo7f6HtZp7NLZqJ0skLg2aVgdIfHVn3U3u6i617VGjuEok9TqcJM98 8r0VF7q5mdL5pMYxjqXXS7dRy7qVGl6aqeKOKbBlIy4M4OPvzhT+7bTQtuMVomtFIaiSEtbNIMvd 46s57qTKW6i2am6qLS1j6WX1Gkh58he2qv8AWyxdDp5C3tjqXVDbgT7pVOlaeqcKSCfpM5HzdHH8 +cKwM+1uhKQRWea00/4iSAtbO7PWfHVnPfPKcu9HHU3VNJSXSOPk8pNB9uykml22/Gbn1Oloqpwp 6eoMbpyPmLBj+fKsBNtNoWme20PtUAqnwYbUOJL88jq7988ptddKk2+rkp3gtyCOxC3L9SXEw+k6 eUxn/DnhTtobY+yW03at1E51zgppJGRsdloDG89Rwe629l2+291VSVTLTZ2QuDHNErZHEsJHBAz4 V2x8q7xapr4YuiOaRoxj5XELUXC41FbIJKh7pHDsXHOFPmkNo9M2p9ym1XWtrzBK+JkLnGMBrT+Y 4PJK6G1bbbfano6oWe1CJ3S5ombI89DscEc4JCbNK5W/UlZQsDYZpGfQOwvbJq64nkSv589RXgue nRbtaVNinqHGOmqjA6YN5c0HuB74VhLltXoz/s9qLpR22Rs8dK4skfK7qLw38xH3WsZcrMZ7Yzym E5VBEGrK6J/VHNI1574ceU67V9ymi9N08nT5+YrstndpJtUlt2v/AFU1jj8Zw6cjv9h9V3mstmdP 3PT8s2iozT1sDnHBkMnqY8cnysy7uo3ZqbqDqPV1dSNAhlez6glZXTWVxq6Z0L55HMI5+butVbNO 3a538WWjpXOuXqGN0WPyEHBLj4AU+XbZCyWHbasrbj6tTeYKd0plEha0PxwMewWpLbx+WLlJOV9K 4RVT2SmQ56j2XzrKqabPqEkfdSvs9tDLqs/xa/F9NYou3PS6cjvg+APddruDsjZ5tOSVeiS9tZTO JdFJIXiUf5R7FZl31HS/rN1WVwWPST4W7tWnLnd72y00FI99e55YY8fkI4Jd7AKfL7sVabBtjWXC rkqJb5BAZPUa/DOrjjp9ldd6+U5TW/hWbB8cplpHhWD2y2XtFTpt951nVyNEwDooYZQ0xt93HySu krdjtJXfT1ZNpeoqxVsbmOSSXqbn2Iwp/Ft1N1VZI9uy9lxpHUNdPSzlolheWO9sg4XwazJ4Id9k s1dUllm3ywmBwph2a2em1gHXS+GWjsbAcPael0p/4SfAXSbl7GU9t0226aOkqaswkunilcHOc3x0 49lFV5HCCDjOMKYtn9narVz5LhfDNQWSMEdYPS+R3/DnwFvNytjGWjTrbtpKapr2RZdPFLgv6fBb jv8AVBACF9TH8xBGD7HusSzwUVgUvK7vRO12o9Y22or7RTwimhyOqaTpL8DPyjyuOrKOeiqpKeqi fFPGelzHjBB+yI8uM4TII8Lv9p9DU2srzJBcbh+Ao425L2gFzneAMrvNz9kaDSmjqm90N3qql0XQ WRyRNDXAnGcjn+ST9rxntMspjN1AaHE4WfSQ53tlOKJ00jY4xlziGgfUq+lfPBTLeOVY7T/w6Udz slLWyailY98QfKGQBzWHGSMkjsvBqr4fX0Wnqi42C8G5PiaXiJ0QaHAcn5s+30Unabk9q/I5Wb29 J7YSKa0pIWTW58LINIPsqMEHCzLSUhH2yoFhJwx7rodE6ZqdVagpbVSyshMx+aV4yGNHcruN0tm6 3QdjguclxgrYJJRFhkZY4ZGQfIx+qTv0lsntEyMp9OMgeEsIpeU+3gro9B6UrNY6ip7Rb3xxyzZJ kkz0tA8nC9+5mha3QV8jttfNFO+SETCSIEDkkY5QcYEzkL6AHHZDgg+Y5RhfTB9kNafZUYHwj2WZ CWPblQY+EiOVnjjOOFjg+UCx7oTwghAIIXQ6J0lddZXltsskLJanpMh63dLQAPJXw1Rp6u01eai1 3WIR1cBAcGnI5GeCnsrSphNwx7/smBlBimFvtHaUuurbr/D7HTfiKgMLyC4NAA+pXl1FZK3T95qb ZdIfRrKc9MjMg4890Gr7Iyt5pbTNz1NVy01npjPJHG6V57BrWjJ5/RaZ7C1xa4YI4I9kRiEJgc9l kAUVihdXprQOptSUBrLLaJ6qm6+j1G4Az+q0t4tdXaLjPQ3GnfBVwnpfG7ggoNd3T8JkYPZMtyfo ECAR3XY0m22rqujhqabT9dLBK0PY5rAeoHscZytPftN3XT1VHT3q31FFNIzrYyZmC4Zwg0wT8rra XbrVdRTxVEFhr5IZWh7HNi/MD2IWnvthuVhqWU94oaiine3raydhaS335QanCWOVmf1WKACY7pjK yDOyDBNbWi0/da6k/F0dtrJqbqLfVjhc5pI7jIGFrpInxyua8FrgcFpGCCg+aeE8YQMZQLynjC2b bDdTCJRbK70zyH/h34P64XhqKeWnlMc8b4pByWvaWn9ig+KMcLLpSGM4ygRCAML1GjqMHEEvH/zM 8fyXwewtdh2QR3BGFBge6AhCKAjwhBQCaEFAu5TCSaA8oSTQCPCChAeUI7phAsIQEFAfZBKB7p9+ 6BZQjCECCeUkygEDukU0BnwmkO6aA+6EJoEOU0JHuqGlnlJAQZZQlnIRlA0IHZCA8oz7IQgAE+3K E8ZQJZBACMoBLyhBVDSRlCA8IR5R4RKEkICATSKPCA/RPwkmOFYBJNGUAjKEIGllCEB90I7oPdAZ 4QOyPAT7IEhH6p/1QCB+qMcoHdAIyhHdAIRygoAoKEc4wgSAnhGCgEIxyjHCABQhGEB5R5TSHCAS yhNAkIH1RhUB8+ySyHZI4VUin5QQjCAQgBB/dAkIQgEFCEAhCFAf1R+iAUKo8gGIu2AsmJv4j+qw Z5+y87bzPPzFNx+UJPHzlZLTJBHlCFVCEclCB/dMc+6xCzacOCDudqowdU0OO/qeVPvxLOI0Nauj sKtpcR4HRj/VVn0zc32y4R1MTsPYchWPtW4NhvWl5KLUfTMx0eHRE4LkSuG2GprhW6kDKWUxRAAy nvx4Cs1dqeWst1RSUdQIKl0Yb6gGSzOOVCe02qtN6YtlcOIpHyuc0dyG5PSMn2C++htyKZ2oK2W6 VThTveTGM+MnCJWGxsM1Pra6Q1Ti+aKVzHPIwXEE8/r3XX7qaqpqOiu9ka1zrhUUzWwNjGSXO7Lz 2nVGl4dV3G6mXpkmYxjMEADAwT916333RL9Rm+TOD7iGCNsjnAhoHbA9/qtaZe7Z+kraGwyQXOJ8 NWAwua/kjPIXu0PqiG9melODPDK8Z+x/95ayk3AsENZcah9SMSBhaPsFG20WprbbNQ3OeuqBHHI9 7mZ85JWc5bj17We7ty/xCPJ3LkxxiliH8lNGxDT/AGFHV2IH9Sob3BntGp91/XfVGO2lkbXvHcho 5AUg603Ds+mdKRWvSgaPk6Glp/KPf7rt5LvKWOeGN4carRqbm/3A+TUSH/3RWsXpuMzqirlleeXO LifqSvKs5Xllt0xnGSHlLKRGSmfuooQjPsgIDPssmnlYrJo5wgljYNo/tnSH6E/0Xf8AxZSObNY2 Dt/ek/uFH+xNVTUerIJauRsUbR3d91Nm7Vs0prCmFTcrrLE6jjkdEIccuIyM5+oTxfrnllfmMeWX KYyfFQvsdo616h1EJ79KDTwEGOm/+Su+v0Utb9ahulitENHb6b8PbpP7v1YuzB2APgZ8Ku+lr7PZ q2OWB5a4HJ+qstp7VVj1tpeW36gdC5j2dLxIRkcdx9Qo30j74eTb26jklqYzLWyfLGSeGj3+67z4 hb7DZoKeONmLnIQYpgSC1odyAuT2ks9otGu7o5t0BoKOQx0zpMdUo9yvf8SotV0tVLdKev662meI 2QtGQ5rjzn7LXi1jncqx5ZcpJPhrNhaqkr9Vz19wDp7nKelrnO4aPf7rr/iJvdPaIqb0mFt1JDop g4gtYHchcF8O9FTi8SXGsrWQMi4Yw93n/ot98TEduulDT3Wnrw6pp3CJsDRkOa53JJ8YU8Op5Lcv Sf5G7jjJ9vDsHU0ldqqpr7gHT3OY9LXE8N+v3XW/EPforN+HFPlt1IaY5Q4ghnUcgLhfhyooG3Oa 41lbHBHGcMYe7iP9Fufiaht9wp6W701wa+ohLYRTtGQWkkkkq+PWOdtPLu4yR8NgJqOv1PUXC4dU 1zmd8rie3PJ+67Lfu9xWd9H+HHTdC5rmSgkEMychcH8OFFE2vluVZVRwxx/LGwnlxB5W5+JOGirf 4fdqa4skmYRTeg0Z+UkkuysSdusuokTQtXJUaCfXXdwdSyxyOkY0HPTjnJ9yF99vv4C6kqTpemFM 1zeXElwz+pWl0Fcrbdtvv4P+KbAXQOiLzzjqbgnC92i7bbNCWupD7xHWNwXfl6D9u61Z+s+3Hvnb 8Iij01fdY7k3mihlkjooaxzaqqAw0DPIaPJP8lI+s9VWvbywNsdga01LG9JPc5Pcn6rrNP1VFNp+ pNLVQ0s1VLLIH9yOrzj3XF2/bCwSXCer1JdxdnyHLQSYg337E5/dRtqdr9D0cNJUa51MBU1UhdMy MjIYBzk+5KkXUNYy5bZ3OqYxrGSQS9IAwMdPC89rltly0xcLBS1McEbTJA155AaeAvRBR0Q0jNps 3CFzhT9H4g8A5GDx+nuumFmNxy+ZXDyY5Z45YvJpimDNo2Rt+TqpiMjxkAZXr0JQUtumq4aB5kp/ Qif1F3Vl5/MVp9D36grLTPpuslb0wl0HU12OsA4zn64XqNRaNu9MTltX+Ikc5zh1PyQM5Ax9Fywx 1/8AV6PLeUrLRWnLVYzdblS/h23atqZHSSSnkDPA+gW+vdsfdNE1tFVVcWZ2PDpueloOFWFmrK66 6hMdFK9rqqc9LA7AGSrLz0gm0I61ur4GVMkJaZC7gE4K1es7lHPXLHjY11DQCm2rdRRODQ2Mxdbe McgZC9WjLbT238fSUkkktP6Mbup7+sl578/stVpG8UF5sdTp2vlDCzMTnMdguweTn64X2bUW/bvS Unr1bZ6h5dgl2eB2CxjNX/2653eNn2+egNJ2yw01xudIIDda2d7nSyu5A6uAPYLodQWue8aFrrfU VELZp2OaZf8AAOQq0UesLjcdQtpqCVwZUTkNZ1YAye6slc6KebQEttirqeOtfCWiVz/lB4OV0y/3 uUc5JcZjVctDzNuN+ms9/ustPbaXqY8RO5kcCQAD4HCsRo632216fqotOyS1DMZzM7OSolsu09qu mlX1FHcZG6hyeuZ8p9Hr6uR04zhSboOhk0XpaZl8qqaR7f8AFC8kH9xlZvvbd7ljhNrNH0tRHerh W2OjmNRUuPrVbQQ75iMNyOy9u8O3NkqdDvuEFvpKOqoj6jTSsDA7JAIdgc8LtomC86DkobRVQx1H +F73YAPVlfS+22S6aBqrOKiH8W2Mdbi75TggnB/RMrcrupjNST6eUUXo7U01LSn0OpkUYLOOkFwz j9FsNHULbdS3WiE0k8MfLXyHLiCD3Wr05cKLVWkH2czmnmZH0ZY7BDm9v5hZxVEGhNHltyqxU1sr eg8/mPbj7AqaXb6V9P07bMio3eh1ljQ5vBaDIM/yyvbpGgFBTXej/ESVMUZ+R8mCcEE+Fr7LW0Oq tIS2qCpMLwzDHNIDsjkfzTpJYtEaR6bnVfiKyZvSee7u3f8AVEcZYtt9J6b0pU3i722CvM7vVeZ2 hwaC44Az2Xjuml9u7/pOsbT0FHa5XN6mSwMDZGkcjB9iV3GoqCTU21strs8sLqp8TGN63dIyHZ7q M6XaOal09W1eqry6iMbXFjaUh7eBxkn3KumZa5fZnWrtO1DaKR2YWu6fbjK7veDbOh1xZ5NR6dYy K6NZ1uHZswHfJ98dlH+xu3FRqW5G6XYmGzU7zk5w6Zw8fZd9vNuTSWq1myWFzYwG9GWcYappravO hq2aku1PFG4sc6YNODjHPKtLvgM7NP8ArFH/AFVa9sdN3LVGrY22qASei8TSuc4Na0Zz3Pn6KzO/ MT4No5Yn4Do2xtcAc85Wv8bH/wDUY1z/AMu78Gvnak82RI4fUr7W4htW1x7NIK+c/wDvXfdZ0jS6 oY0DJJGAEy913x9RenaJv4nbSASPLfUjcC884y08r61UcOkdvahtVUOqYnh3TIB36gQPssdA0FTb trYo5mmOQUrpAPOOg4Rp+R112snkrMSkwyY6hnHynCz/AI81Md/bh/k3dz4qK3NjW1kob26yR9sr yNaScYXsuIxVPB4w4hevTFG2vvlFTP8AyySta77ZXTydZV1w7xiwWz+1mnbto2mq7xaKitqZXlxm DnNAHHAAI4C8O9uztvsbbfcdPNNLTTOZTyU7iXHqJ/NkqebnS1UGjrXBpmIExmNpbH4aBgrx7qW6 ouWlreKeIzfhqmOSbp5LQ3uT9ljGS3tMrr05A7D6QfYKQehLFWSwNaJTK7l5b3wuf1/sTY6XRjqr T73x11Gwule5xf6paORjwcqbLz0tp7E57wyJsjCXE4GML5Fnq6RuhZ87XSTOb5yMphJ1sztu9IQ2 W2mFutv9odTvfC+UD0Kdp6S0d8k/X2XXfE+xsm2NH0Z6fWZjPfGCuv1xRVtdpmxts8L5zHPG6QR+ GgcrnviJoKiu2vZ+EhfL+Ge18oaMlgaOSfsteLLjnKnmx5Y6iksgw8gBYj7L7zM/vHfVfPpJwMHl ZaWC+FWyUc9xrK+ed7KwgR07WHBA/wARK+PxO0M1TrygpYy6WQ0zWsz5Lndl6vhRhnl1JO5rHGCB g6nY4aT2XUbzWud+7OnqmSB4pJXRxNkLfl6g4kjKzj3M/uRM+vJhPivBaNidN2zTFFUatrKptfOc l8EvS0ZAIaAQV49c7EWtmmoLnpKpnPTIPV9d/V1sJA4+vKlPe6irq7SVsZaKaapkZMCWwt6iB04/ qttRRTU+11PDVMdFUdDAWP4dnI8KY71NtW92I0uPw5WR9jaLfW1cVwe1vQ97wW54JyMe2Vz+vPh+ prdZqWr0/VzPcyRoqfWdnLSQD048jKsZcnCO5WcOPQwGQkngf7taefrOgpjIcn1e59vUCWsonuPw 4Wc2c/w24Vba9wb6ZlcC3uM8Y9srn9efD/DbLVSVVgrJph6rW1PrEcNJAy3A75KsfcnmO62oOd0s /vTknj/drUT9Ttv8yHLutvJ/+eBXbWPftXDc7Zej00LEy01dXNJX1Ahf62D0g45GB9Vqd8Np6LQN ut1Xbq2pqBUPLJGzhvy8cYIAVjt0qCorLpph8FPJNFFWB7nMYXBo45OOy4n4sKeWXTlBIyNzoYpC XuAyG54GV28eEyzk/jy5eS4SZf3SonTzhGOfsvpIwh2ORyhree2Vh6lk/hO08XNrrsyqZFUvPpRR 9OSWgcn6Lk96bRNdt3n2+aZrZZXsjdLjgNPd2PoF2fwjukfcK5uD6UUeM44BOSuc32ElLuxU1PS5 uenocRweADhXxzWGd/jl5f28vjja1nw7U0NVSSt1C4WqRpdLO+IdQz+Xp8HJXJbq7MzaNs0V2t9c 64UHHque0NLcnAIx3Vh9fvMOzsUjSQ5sMPP/AHgvFu9D6myJ6gCRTxHn7hP8fHnw38p587hMtfFc B8KWm3spq68x1MUdRKTFHG5nUekdz391xG8Fmnve8tRbnyRsqJpWRvmxhoGBl2PoFIXwqPkdcLjD 8xhiZhvHGTkkLid9ZJbfuzX1LQWOOHMdjGRjGQtYSayPJbyx0n3arQNDpDS9ZQ01bHW+sXF1SGYP Ix/RVc3j0HHpC5wPpbjFXQ1Zc49AwYznOCrPbM1clbte6qlcXSPEhJ+wI/0VcdxNO6k/AtvF1t87 LW5zemYuBGHHA4zkKeOcvHbUt4+TWmk2o25qtf3eekiqvwUMUXqOmdEX59gBkf1XrptupKXdiLSt wmMsDaoRmVrej1I++R7ZGVZnZrVFvuFuhooI4aeOjgbE1wABwAvndtS0Vbr6ktfoU/VHP6gqA0ZA A9/ssarrbdxuL+/+ykVutFgoD+GgpzKWxD8rWnyuP3z0HR6usdputO2Omuszoo/Wx8vS45PUPK7H ci51FpuVNV01G6piqoRSNcOwc5xWu3fndbduqEdXRPCYiWnuAOCteLGZZaqeXLjjuK2bgbO3zSlT RCItudNVkMZNAwtw8nAaQSf3XRUu01Roeost/wBQzUdVTiRj5aItIc044BzwQCrI7fOluWkLfU3d mJHu6ohIOcf4cfooM33rb1WavFnEE73zv6aSNreZBnjH6rGE5b/i5ZTG6jvp9YXu8RRz6atdTJQx u9IvhZluRjOPtldPrewWu8t0267wQvqY52PPqgdQGOc58ZUNaW1ZfNEUNFZLrSzUDnEOaydvS53U 7Gf3/op41DSR102mZZY2ue6oYHOI5c3pyQfoou+mn1/X3i1V1BFYKOaejdCAfSblo+bH9CuV+IvT 8d60RbntpBLemyRiPpaPUII5b74yt7uhrGo0zfbfR07+mKaJvy+Cesj/AKLqb1TMqqvTM8jQZDOM uxzjoJx+63Zx7rEsyVbj+HrVEtLDN+LtkLpGB/pzSODm58HAK4fcLby96FqII7vFG+GduWVEBLoy f8ucd1ZHfPUNRYtTUHoyGOMwNzg4zhxXAbq3q/6nsduts1pqzHUSt/DufCR1vxkdJxzwpx0uOW0D 2+iqK6shpaSF81RK4NjjYMlx+ynyzbChsGnm3qqkbW1lQfxUUbhhsfTkAcd8jBXb7VbfW/bmzOvm oxFJeZW5YDyIhjIDfY+5X10fq9+pd16QOeBDFHJ0tHYDBx/VLjvG1Zl3p1dVc6LRTqKx26kdHR08 TXyem35cO+UZxwMnCjTfPaSK5Xe3XDTMccNdcZfTlhJ6Y89OevPhSFr6vZQ36pp5qWaWS5wxU8Ja 0kEh2T98J703B9qstoqondL45wf06Uxx3nxY5SYSql6n2/1Dp28U1ur6EuqanHomHL2yH2BA7hdz pTbWq0hqi0XLXNFTyWp7ndMbZOr5w3LeoeO/8laHSjY77ZbXda+nb+JZ1Pj62YczIx/RVx3i1RcL vqB1B0SmSJ7msiY0kkDPOB9FrHDlLZ8GXk42T7SrW7iEV8UVnpHPo3FsXX6RI6sgfmwuW+J/SdNW U9qudDR5uksnouMTfmkb08Agd+V89vNyJrda7ZZmwNjewsiPW0hxc49yP1UxXihZLrawVDslxdLk E8cRnHH3WcNcrtvO3rSpg2O1zIwPjtcPSRkA1LQU9D6Pbp7cqko9d0Do4oW+t6Rd8rz/AIeexAKm jdPWFXYtbugZOWQNax3TngjyuV1leqzce62i12ijYa8Oc5khHTgAfNz7Ac4WsvHcdbc8fLMu4ktm tGXHUcNtsNDDUF5wMsHAHc5+yjX4qNMWqGSlutHEyK5yP6ags46m44yPf6qSqOktG19gLg5k14kY BJM45JPvjwOT2VdN0NVzX6re6WTqBPvnCYYzVtMsruSIucOkkLHysnu6iSPdYrm7hCfhJA0ISQPh H2QkgaEZ4S8IGhId0IGgoCCgEICO6oaPKPKD2UCKSPKCgMcoQOQmQgXsgFMcoICAHKPKMYTBQMIS R4QPHKRRlBQLwmOQhHZUCfCaQUAUIQFQIxynhHKACY7peyAi7NHlIoRDCSPCPCoEZQeUggySykmi BCEIBHBQEBAeE0kBUNCEkDyMIKXhCA8poSKB+Ek0ZQCEHsjCBjshLKEDQEBB7oHlLHCEfdA88pFC EDS7HCAjzlAzwjPCMpE/sgySQhAIB5SBR2QBRlH9EIDyjuhBQLPsjKCjhUPyke6MphUHdLyml+iA P2Txx3Ql3P2RQf6oxwUJFAIQEIApD3T7hIBQBRymhVHxmPyDsvk08Ffaf8oP1XyaPlK88brzP5en 3asXHJWR7BaSkOEFCAqgCCn59kkUA8rIfzSHdAByg9EDiCSO/uvfDUPAw3JP05wvRpOxz327U9BS kNfO4AuPZo91Z6uoLFtLotsVPTxzXCpHT60rATI8YyefAz2RKq2Kt/8Ahcsm1T24PWeVZ3YiK0yW msjjpoHVk8jpJXmMec8du3PZejbPapmndRXG43NsFSAT+HLoweDycDsPZNorE2veGgmUfushcpCO Z/8A3Stnomps151ReW0dupPScQXPMTSXFrcey2z5rey+VlHPaKUUdMWtdP6DOkFwzycK7SxTSWvl wCJsn/m7r4OrXtcCHfzV2LPpqxzVd7mit1E4TSMYXthbyOnxwuW0ltRa7BrCqrHUcdTSSscYhMzq EfuOeOSnIVOfVvJ6urB98pPq3Stx19X1ypc1tSWig3pqm1VHAaKF8ZEPSAwnpHcBSRr7QFq13pJt dZIKejrqZpfG+OMMaRjJacDngLdlntJdzap7sApeFlIC0uB8ccLAZ9lGjSPKaMIEmUh5TUAFkO+V imO6o2FHWPhwWEhw8g4Xtmu9TNH0ulPT/wA3ddRslpmh1HrCmhukXrUrD1uiJ4dz2P0U2bqW/Quk aSeldpy3tq6inf6LmxY6SQQCPqCpPekvSrHWA/q8r2wXSeHDYnvZnyCtYWY4PccKYNstmarUNsN1 1BUyWy2lvVH0tBkePfB7BBHsN4qIXdUcr2uPcgr5110qKxoE0j3t+rsrrNN6Ch1BuJPY6Ose62xV DmmoIAc6MHxjjJVgara/QrJP4N/CadlSacBs/PqZII6u/fymzSqdJdaiiGKeRzc+xRW3SqrWYqJX vbns45XX2Tbk3Xcur0zHVOFNS1LopJ+n5iwHGQO2Sp7q9qdDNcbK22RR1RgAFQS4v5GOrvjPlSVd KrW+8T28EU8rmE98EjKyr7vV1wAqJHvbnsTnC6rT+277ruXVaabVEUtLUuikqOn5ixpxkD3Knq4b SaIcX2eGgZBW+gOmo6iX5Ix1dwCVdppV+3Xqqtzemmke0HuGnCdZequuI9d73DOQCcrpNM7dy3zc Ko042qLYKWofFLP04cWtdjIHuVPNw2h0Q9stnp6EQVzYG9M5kcXZI/NjOCeE2aVoo77WUhAppZGN 8gOIyvZNqm4zYa+WXo9uo4U06N2WsNtslfc9WONwEb3gNyWNYxp78HuVtKXa7Q2qLTVfwGhNNL04 bOJXOLSfOCU2zpAkGrbhE3pZNIG/Ryzk1dcunp9aQA+eolS1o3aTTNstlbV6vqxXyiRzGsa8xhjW nGcA9yt7FtTofU1jq3adpn084b0snMrnhrvfGef3Ta+puoCh1bWwPzHLI1x7kEjK+smr7jy4TyAk dwcZWqjszGanktVdVenDDUOhkmDcHpacEge+FPur9qdIwbZV15s1NO2oipvUildM53URjkhXvekn faDaPUlXBOZYpHNeTkkE5KV71RcLjGI6mR7mDwT3Xe7QbRP1FC68akL6azNGWNDul0x98+Auq3B2 WtU2mTXaJZJ+LpyXSRPlL/VbxwM9j3SX4i2a7qA7bXyUtXHUNcWvYcjC6t+vLq+AR/iZOjGMZ8Lm dP6bumoL3HarZTOkrHOLS08BmOCXewCnXV+ytq01tdW3F755r3Sw+q6brIa45GR0+yXrqk77RDQa srKWpMsT3h5OSQcZK+epNXXC7Ma2plkLW9gTld1tBtI/UzJLtqL1aSyMaegB3Q6Y+4PgBdBuPsnQ s02y46J9eWaAudNDLKXmVvGOn2I5U2aQZZ7nNR1zKiNxbIx2Quwn3Du8sQYaqUN9g4gLkdO2G5X+ 9w2q105lrZXdPSRwz3LvYBTfrLZW3aZ2zrLm+aee9U0bXF4fhhPUMgNVlRHFv1xcKQvFPM5occnB XouG4FzqYfQlneYz3HUeV3egdl7ZNpZ141jWTRGYB8cdPKG+k36nByVt7jsbYLlpuqqNKV9W+tYA 6N9RIHM45IOB7BNrpFtv3BuFBH0U87mtP+EHhZ1G490LXBtS8NeMOAPdRvUtMcr2SEMewlp58g4W ETHkgNJeSeAOcrSaSHaNb1dvlfNTyvje454PBXw1Frq4XdzRUzOcGdueFImiNkaKfTIuur7lNSOl AeyOncPkB8HI7r237Yi11Gmqut0pc6uqq4x1MbUOb0EDkjIHfCmzSMtO65rrW7qp5nNPkArK/a9r rtO315nuDOQ3PCj2Tra7y1wJBCx+bnBPKm00lS0bk3Ohh9KGocyPHZeTVG41yutEaV9RIYzy4Z7r a7S7Q1usKd1wu8s1utAaSx7WjrkPuAfH1Wj3i0da9IV1DFZLrNcI5mu9UShuYyDxyMf0TZp9LLuD crPZ/wAHTVBa0jGAVw93uc1fUvkke5znHJJXUaU2z1Rqewy3a1UcTqNnVh0kga5/SMnpHlcRUQyw TvimjfFKw9L2OGC0+xCba07bbzV1Rpl730j+j1D857FbjXO5Nwv9udRSSkwO5cM914NpNBxa0ral tbc/4dSRDAe1oc57vYA+F1e6+zcGjNKuvNPd56sB7Ghj4wAQT347JjbvU9plqTv0hF/LiTjk5Xpt MohuEMoGTG4OwfovIeXFOIPMgDQS4nAA7kqOicKjdu4utIpGyuALeg8+Mdl437oV9JYP4dSyFsTm lpHtlbbSmw1bctO01yvl3Frkm+ZsXpB+GkcZ5HK+GutjauzadfdLRdP4q2LLpGiIMw0DJPcq8viM eu6hKukE07nDjJyvtZ6l1HXxTxnD2uBBXid74Q13Klt+Wk9Wnd6voqKOCOQ4a0AjK9X/AGuVjojA HYiecuaeclRHoSw1Wq9QU9sp5mQeocumkGQxo848rud09p6zQVmpbk66RVsU0vpENhMZbkZB7nIV mmbttdUbrVlwpGUjpflbgANdwF6mbtVUFnjofVwwtwR1d1BL5HueepP1C3nHKu4z2sHb94Kujomw Qyn02jjlfC47oVl3pP4SJRHT1bvTkOeAHcEqK9v9NV2ttRw2ihmZA54LnSyAlrAPcBezcbSlZoHU cdsrKplS50LZhLG3pBySMYyeybgmSHbba+SniMstaZOkdTm1RAJx3Tl202sbG534ivaQO/4oqAYr /UxtwJHDCU2oqqSJzfUdz5ymou6lDQGsYtDVl1obc8mmfUvLHk8uaOBn9Fnrfc+ov01GyZ393TSe rH7h2MZUKPqJHnPUeVi6oc53JyQnSWWrI2zeapp6OKBryA0Y7rz3zdyS4zUjHvHpxP68Z84VdxUy NPBysRUOJ57q9GqsFq7duoukMUIf0+njBB/dbKHd3Nop7e7BjyC76+f6hVs9Z55ySV9BWSADA7J0 mqsFrPdua5xwQxv6THjBb3+q9dVu4Xacit/V8rgOrjn3VbnVMhfknn7rJ1Q5zfmcQfum4Ta0NHvN LT2+OFpDg1vSCe+FqdRbgf2sszdNENbFWERueeeluc5/RV1bVS4wHu4+6+9FcZoKhkoc5rmHg55S Za7S479rCP2J0hLh/wDaiva0+OmM/wA8L5VGxOlIoJJW6qrAGtLgHMjOTjjnCiOPV9YBxK/j/iKw qNW1s1O+MSyAP4OXKNbqUdnNcxaNtE1vDGeq6Vxc/HLjnH9Fqd4NcRatr6DqawGldw4DnB7jKiE1 ry45Lgc+6+MlQ9xzk5SXR3uVY3VO5sNx0VDaPl9N7WNP2aQf9FhrvcuK5aCFnAaQ+MM4+nZV1FTI 7ALjgfVZvqXubh7jge5Vxy4618JlOW9rBbMa9pNLaefSNYwTSSuke49yTx/TC5ffLWUOrK6ie2Nr ZaYOZ1AckE5/quD0pZL1qF9QyzU75vw8TpZXdXS1rWjJ5PnHhaujgqrpcaekpY3TVVQ8RxszyXE9 lJ9w3u6Tps/uQLFY2UMha6Ng6el3bkklefejchuoLQLbD0sgIGWN4HByFHepNB6p0lbjW3a3PpqX qDC8SNcMnt2K42pnfISZCSU60rqNL6uqbJ67YXuAf7FfWi1ZVR31lwfI4vB7k84XFE55x/JZB3A6 cg91NrpbvTe7NMbRCysYyYt+YF4zgrjr/uJBe9W0j6/E1FDJ1mJ3LTjkAj2yoBhr5WM6A94b9Cl+ LeH9Qcc+6ssiXdWk1DuzHJWUbaVzYYY+AxuAB7ELz6y3IoK42qf0YjXUkgkiqMfM3wef1KrI6tme QXPJ+qHVsrwMucen6puHa29RuJYrj+GNyt9PUyxtDWvkYHEfv9V4NS7pxS3OhFKRHFCcBoPAPuP0 VXW3OoGMSOwPdeq3iuutxgpaKKWqq5jiOJgy5x78J0W1a+u1/p67SwPulvpqmWIANfI0Ej9VrNS7 owuu1AKMhkMHYDwe2f2VfL1bNR2Gnjmu1urqGGR3Q180ZaCcZxlc7NcZnydRlPV91dxJtbi7640t eXwPu9spKyWMANfKwOIx9VrbpuRb59WWt/Q0UVC10jWeA/pIBH6FVeF5qWgD1T+6+JuM7n9bnku+ 6m4dpg3V3Hlu9VIyGU+kOGgeAuE0XqeWzagjreog/lJz4K5Cad0jy5x5JXz63ZyEt+FkXWt25Nnq 6SiqLhEyWppwZI5CeWEgjj9Fw9w11b9Q65pDeGsntlOS70T2cQD05+xKrtTXipii6GykD2z4Xybc JmziQP8Amz7qTULFtL1ujTtvNHHQuayni7Dvz2/otXqrV1ibrC0XyghYy5wlzXy/5muGMH6qttHJ cri976SCpqXR4LjDG5/T98DhfG4XCtZP0VIkZK0DLZAWke3BV3r0i2Fwu+hbne4bnX26KW4MLCJu rBBacg/VK/bl0o1TQupiz0ochpPPLuD/ACVU4r/VYyZAXDtgr5S3apkkEjnkuHnKkkXdW21BcNC3 27RV13ohUVTS3pcXkYwcjhYO1zaZtwaGUNjEFJC/pfgdWXDGMqqo1DUk4Mp/dfFt8qPxHqiQ9X3W tz5Zk+ludQ3HRN6ubau6RyzTgjBExA4ORkBRx8Sd0st6tFudbwwVEDyeoAZ6SMYyoVfqKr6g71Or H1Xjut3nrgPWf1eMLPXw3Gkkbh2Fifuvr0l2T3I9l8vKw6F5TyhBQLwhMBPGUCQO6yx4CWPdAgMp fRfTHHcD7rEjHPhAkJpFAZQUwCfsjGO4V0EgJ45TQLHCRHhZduUd1BiAj7p44TA8IMQBhBTPdCAR 90fZA7oDyhZEIHZAsIx9Ez2zyhAh3Qjsjv8ARABCE8FBiU2g4WWMeEclAsBCywkAgQT/AKJ44Twc qjH7IwmDnOPCfdF0x8IwgoxwiEjwn4ykgAAj3TSQJMp44R3CuwghPCQRAhNI/RAJ+Uk0AUk0eVQJ JlMjhBiml/VNAvsmjGUEIDKEYR2QJNGOEkDTSCCgMo8oOUIGjwjwhAcYQhCAQSgpHsgeeEFY5WQ7 IAFHlJNAkEoJRj2KAzwjuhGOUB5R3yUyEsHOFQvqjx9EFCoefZGUgmeOyGx3RlBSRQn4SQAgEx3S TAQJCMIQCEv6pY+6JphOB0D7r45w1w+i+0w+Uey+ZHynPZeeOjxkcrPwFiVmT8oC0wxCEwlhUPGe 6AgcI8opjvyshwffysU2nBz5QSZskwP1fR++SVK3xTPc2m08G5x6kxOPs0BQLou8SWa5RVUJ6XtP j2ViK3WWmtUaMlptQH1D0ZDGnDurxg/dSFcr8PcVxq7xKKeT06aPmQnnP0U+6sp6ut0/cILVUtp6 os+WQjIb5I4+iifanU+ntN6PnZ6jWVWHOdj8xODjlevbjcGmlkqxeqrDXZ6WnnPCrLzfDn1OmuLp M9fOc/ZbzdfU1MLTdrDRg/xaSaJsccTfmccgk8fRevSt70vbrrdqyKoEclTLlrMANa3GMABemnqt Gwakqr96nXcJxy95yG8Y+UeEK2e27Kmj0fOK5j46yMHra/uHBpK9WhtRQX61N6TmZjfm+v3Wnbre xwW69PfVDMznvY0EZ5aQP6rgdjNQ2+1wVf8AEapsZcCACfomkR1vW4/9qV5I4xI0f+5CsJtlkbZu ceT6Dic/8hUG32O1ar3erKirq/Rtcs4e5w7uAA4CkPcncS2WHTjbNpnoAdH0AtPZvZdc8uWW2cMe OPFVyqGKh/tk/wBV8V9ah3VI4/VfHss/LUNJBQihCCEIDssm9/dYjun9+UE2fDXHjVzf+VvP6rcf Fc8/2ptbCT/6qT/7srUfDpVU1JqT1qqVsbA1vLjjypE3wsGn9SwS3ia8uiqqOle2JkYa4PIy4A5P umF421nOcpEb7C6HtuoL1+PvkjHQwOzFTf53e7vou9381XcrU2O0U8DqWjkZhr2dnDkYz9vChDQ+ p6ixV8UsUhaMgluVZQ3DT+4ekTR3yWGMdORIeXMdj8zeRyFlpw/w2toG3SZ8kRkr5SA1xPDRn+q6 H4g9QxWWelbRAx3fDXiYOIIj5GP3Wm2JtVHatQ3SomuTDT005ipy7h0rWu/Mfbheb4mqehq3UV4p a5stQCKcwNGR08nqz90x9lev4eJaKqvlVW1IfLdKl+S8nhoz/Vbj4gdQxWSro/wWY7selxlB/wDZ 88fuud+G2hip5p7nWVcUTQQI4yeTzyVj8T9LR1Etvu9NXNlmJ/Dugbz0tAJDs/dWJWw+Hl9DV3qs r6gvlutS/JcTw0Zz+5Wz+ILUkdkrqM0DnxXbALpGux/dnOBj7rQfDTQsgknuVXVRRNBDWRk8nB5K +HxPUNNLW26701ayWR4/DOgHJaByHZTGJbW3+Hc0FTdKy4TufLdql/U5x7N5z+5W23y1BDZbxRPo C+O7dIMjw7gxYOBj7rn/AIbKBsIqLnVVUUTM9McZPJweSvl8SFDB/GbZeKeujkdMPwz4WjlgbyHZ +uSpDvaWbG9tRtxJPfej8FNE4yMbkENOM5PvyvtoiC0w2WpZpOP0W8fNI4vGc/UrU2SpodSbaPtE NZHA+SD0vUfzjOOceey9WkKKj0Lp6oZU3SKsJ+YdLek5z7ZKWddM6tqG7Fpy9641vc6Zj3w2yGpf +IqP8I+Y/K0eSVImvdV23Qun47Bp4NFQ1pDunkj6k+6662xwO0ZJBa6qCjqZ3OeH57Euzkri7dtX aHy1VZqa7fj6qU5a5r/Taz79yVb76b11p49rdCUNotlRrPUgbPWzgytb/hiaT/U5Xda3nZWbT3Ka NjWRyQuw1owA3qC+UH4O9aBqbLRVUML2t9EOkdxw4f8AReq5UMNdoaqsDK2BkjIQwzPOGnkH/RTd 3skjzmmH/ZNBTtcIeqNjXOHHSC4ZK9+irfBQw3Gjo3ukp2taWuc7qJJHPP6LR6Wu1v1LpiosFZL6 TmtMRLTg8Hg/uF9H19BtzpF0clWKiqfn5i7Of/ewpGstWXbPQGmbbp201lXaxTMudZI50k0x5/Me Pt9Ft9V2ua66DrqCepgEkrCHSknoPzA/+8q42fVVzu2o46ShncGzzHpaXYaAT3+ysfe7fJUaGfbo 66BlSGAmVzsN4IJ/ot5W27rGOtajwzUf/wBS6Cljd6Ic2OMuYcdI6wCR+i9+i6CK3091ooZHzU8Z yx0h6iQQfK0um7pQas0nLZZ5hFIGdHyuxhw7HP3TNfSbeaPLKurbU1j2kE5/Mf8AphZa+GG3OkLb pqzVNbaWU5uda5z3zzO55J4B8Aey3Os7RU3nQFbbjNC2oki5lcfkJBz3VdrHqy53LUMFvt87+meX pa0uwGjP9FYjV1uq6zQVRb6KrhjrfSGJC/A457q6Y+OlfduKqPUVdNQ6gu81LboW9PRG7Be72GQR gfZWB0xQ0ln0rVxaekkq2hpIdO8c8HPIH+iiS1bQ0FfpNtXZ7k917eGl5meBCH5+bgDOPZSlo6jk 0nouaC91EBkDS0vjcSDkEeUVwG1GirdPZqutrNPUdU6pmc8z1rW8gk8N6hwF5d9tCWa3aOjvlsoa ehqKORp6aVga14c7BzjupNdE+66DiorPNG2oaGDJcGhuDkrybhWN+o9vZ7RBLEZow0SuLwB8vJwV vx2cu3PyzLX6oO2+ZqTX9VHbIaiZttiI/ETH8jAPA9ypb1pqe2aJsMdisZa6qcPSGTk+2SfJK3tr ssll29p6PSkVNDVOib+choJP5iT7rhKLaOorfXuupbm/8bGXSsigcHMwBkAk/Zct29umtXTaaO2k 05b9PRzVtpp7nXVDRM91Rju7kgE9gvTfNpNMXDT9SI7PS26dmJA+EAn5ecZ9iujvLK686GgZpuZg rGsjDS54aBjuCfC52l03eYbLLVajvhpZGOP93CQ9hHgE8dytyfrLfbG95WfDqK23wTaIo6I1rrdC YIwJWN5b9ByoV15svFJp+qu1ku9TcaiEF5ZUBoa5o5dggDBwpZ1hbazU2gKemsTon1AEfd4aOO4z 4TtlFNYNsqikvL446hsL2vIcCMlpHdMZ3jPtm28csp7lQtsnr02YQUNS7NMcNAPYLf73bX0mpKKX VGl2sZWhhknj7NlAGSSff6rmtkds579Vfxe7j0LLA89LSeZiD/IfVdXvVuTBSUD7JYy1sbW+mS3s B2VykmVkdN7kqCdvK+WC80ccL3NbJK0EA4zkhWX+IsZ2lhB/zRf6qve0umLnqHU8TrXTGSKke2SV 5IAaM9vurDfEk10W1scZ/M18YcB9FP8AH3+eX4Z/yb/wanvamLvzH7raaYkZFe6OSUAtjka4g/Qr WScvefGVsdN0prb1SUzXdPqyNYT7ZKl9us9Lq2u6WrW+khb6ioFPI1o6HgkdJxgEAEHj7rSa5uFf oPRhoJmm4UEkJjFV0dOXOBGCMlYX3QLaHS1rqNFU0s1exzfULJSS8Y5PPHddDqCGb/smq4tRMEdY +neOh+Dh3TwphN5yM+S6wtUXqWhshHseFhC0vfhoJd2AHuvpUtIkLT3BXQbe0rKnV1sjlALDO0uz 7ZWs5q2LjdzaftmNqWWayi/6oe+KecAwU7T0lo7jJ8krsfiLo467RVopnPMcT6pjS72GO66jXNFW XGw2YWeJ8/pzsc8RkcNAWh39oqqu0HSS0ELphSzNkm6OS1oGD+xKmN12mePKObi2M0hcrXaq+kNR DTN+apcZSTM3p/lzyue3O2YsdNoma9aTEsUtH1SSCSRzxKwdwM9j5Uw0NBW/9kX4OOF4rXUuGs7H OAq+X/cu4wWGaxSdbeHQyNdwR4IIVk62xbd6kbb4W7NRyVlbVyzyMrn4ZAGHGGjk5+68G/lrlum6 dDb/AFXEyRRxh57jqccra/CzTzS6gq5o4nGnhYA5wHDSfC2+7NDLT7v2e41EL2ULuhomLcNJbkkZ WfHbcfJ966Xyanl8f18uQ3w2vs+jNM2mss7Z/Xml9OUySFwcC3OceOVsqTZW3S7SfxgPnN8fF6jH ephnUSMAt9sFSnvJYJ9baJpP4J0zSQSteGZ5OcBbqsYyy6FobNVSt/FvayNrR5wQT/RXH/Wfa7u6 i+zbCWKlsFK/UElfLXScvfTPIaM4IGMLVbgbFW6gscFysE9SyKOQfiRUuJcWEgZH1GVN24dzutst tDLYqaWoc5+HiIZ4wOSuF1nVaun0NUVdc2CKkka0PgcSJTkgcNx9UpvtpGfD7p2rNsq6OurGW0h7 qkukHU4Y+XpOMDn6LmtyNjaW2adhuek556gNeGyiofkkOIAIwPBKnG5QVsW0Zip4pPxjKZoDAPmy MEqG5Nyq6ut9Np+lb1PmcImjznPlWTrab7eyi2C0/b9P09RqW5VrKkj+9kp3D0wfuRwPuuS3X2ao tO6VF903cJaumi+adtQ4FxaSAC3AGe/srAQSXC3WWK26jt4uFLL8rnwgyMaBg88Lid6dLV82n4qj TUwNBOWxyUjj0gdRAaWj9eQoqqdltFbebnBQW2B9RVzHDGNGT9z9ArF1eztnsG3klJcZozfK4x5n cATEQ4E9PsMZXY6I0fZ9qLDJcrg5k15lZ87zj5T/AJW+wUPa717UX6+DMp9JrsNAPA5Vl13STdkd XV/D7aIKijqo79VNsrmF00krW9fI+XpIGO/fIXLbrbNN0tYYrzY66atoRj1fX6QQHHDS0gDPP0U9 6yhqJdpIY6SJ8kv4eLAY3J7jK9t+tsd024tlFUM6oZRTtkafbqGQs49zG/bM3vKfVQppTYyy3axW 6pqb/WxVM8TXSRxxNc0OPcDj/quA3I2xueltVU9qpQ+qhrX9NHI4gOf4+bHAVub5VOsVfZLbbaZv 4eU+mMMyGNB/l5XB/EBFVnUOl5rfC6SYSFkZaOOpxwOfC14ced1TyZcdWOHh+HihpqCkfedQTUlX JGDKxrGuaHeQCuX3I2QrdOw0VRYKiS50tQ9sTi8NBa5xw3t45Vh31ubdT2fVtC/1CQ5rmOy3DT36 guU3Itt+tVTRTWFzqu0TysbGwH/dOc7DRz4+vhY224iH4doIaCkfdNQupKp8YdKwQh7Q7yAchaLV 2xdbZ622mgrhV2yoe1k1U9ob6OT3I9sKwU9dHLbqaz6uoXNqHEOBDsjAPfqH2Uf72w3iwUUc9HO+ fT8hGDnmIuOGg+SPqrOzLp3e3Oh6DTOjaq2UdY2qjmLy+p6ME9TcfyCr3qTSjNvNb2qqt9yjrWS5 c17W9JjcTjHf2Kn3ayqdUbTuqZHFz3sldnPPYj/RV91Tp3UkDqK6XOhmbb5ZoxHMXAgdThjIB4zh XH/4cnPHHX+RpYbdHTlTq3bqjt8BAllMTnyEZ6R3Lv05Kr9qzY66We9Wmngr46m21zmsdXCPpbET 7tyfH1VhtybjPatvaCaneWOc6KNxHlpGCF5N4JJKfb+0uhz6nqwtGO/Iwt+KXLx4YmesMssv6hqT 4crq27iCK807reYPV/FmE/myfl6er25zlcruBs7fNLVlujpHfxWCuIZHNDF0ASHPykZPgZyrP7kX OW0aAo6qB3ST6THH/hIwVz9i1rTanvtjtTYm/wB08SdX/KFznc269b0ieL4drn+Fp31OoaGmnkjD 3wyQOywnuM9XOFo79sjfbVqO1W1lTFU09eQ1tY2MhjHYJIIyT2Hupl39uktu1PZ2QymMSwdOM4BP X2/ZSTcI2yDTIc0H+/bzj/5mVLTSo1/2hutr1za9NNrYZ5a+MPE/plrWcnORk+y1uudt7tpbU1DY 2PbX1dXEHx+iwjJJIxgn6K0GpoBJvjpwlvDaN5J+uSvPqKkjqN9tPmRgPp0r3A+3dbympb/HLlq4 z7QlVbA6jp7SKttdQPqDEJPwhy2QkjPSPGV6LboK87bXGy3+sqKV0ssgjbEzPXEXN4J/op3vVS// ALYbHRtcfQNK57m+OoF2FHu/9RJ/bW0UzXH0+mI9PjPq4z+yYS5cp9TZM+8J913O82l6nV2j7db6 RsYmfM2QyycNZ8vJJVVNxNv71oiqhju0bXwzNDo6iHJjJ/y591bvc+7z2nTVsEDsComZC/6ghc78 RVrlu2h7bR0sJmqXVLBG1oySenwsy9Tfy313/wBqf22hqbjWwUlDC+apmd0xxsGSSpO1ztLPpTRl praif1LxU1HpyxNOWta4fLjznPdS/tloW3baWV97v4ikvUoPTzkRDwG+x91oI69+5u49FbaiZ7KJ hMrhH3AZyB+6t6nKrO7pw8OwGrZomvbNbCHAOAE5J+2MLiLNoe93TV403FTCG5/NlsxLQA0E5zjt wrq0dZbqfWMVkipv9pbF1iXqPbpJ7fouMjo4/wD4IhkzWgP/AATgSPo0q2WY5X6c5nOeOP2geo2R 1jBX0VM6lp3mqc5gkZLlrMNzlxxwFyOsdH3jSVyFHeqf03uGWSMOWP8AoD7/AEV3rxdZ6ae9elgC lZB0H6ucAf6rw6x09QX3UunY7jTxzxslkl6XNyOprMhYxtrr9I3+GfTN6stIamro2w0VwJkc57sS YaCGjp791HHxO0cce4c8zGgOfCwOx5wrGwXqZ+6UNkaA2np6d0gA9+lQN8RlHNcNxvwtJE+aokYx jI2DJcSvR4sNTLl9PP5M/wBsNIOt9HUV1XFTUcL5qiV3SyNgyXFStedkr5RUtjjo3/iLrXB/rUxI a2LpGeHfb+alfa/b23bb2z+Paic2S8OYelnGIvcNPnhc3ddwKm6a6oBTylrXTsiaB4Bfg/yXL1La 7ycspEY0m0msKu4VtHFayJ6Qt9QOlDQc9iCe65m76Yu9p1AbNXUM0dx6g1sOMl+exB7EfVXE3Vud Ta7rYG0chj/EzhkmOC4FzR/qt9erRR1GvbBVTwMfNHFP0vLQSOFm/H9m0w/bevhUkbL66LjiyP48 +q3H9VxF/slwsF2ntt3pn01XF+Zjvb3B8j6q025Os6yw64mp2TFtM1zXFueMYHCi/erV9Hq51AW0 8bKinJ/vAMOIPcH9VZtrpIHw+6fFq0HU1N4tLpRcC6eN7og8GPpIHft5VZtSU0VNeKtlP/uRK7p+ gycK4Ow10kum3chnPUymzAwHw1rOyqXrOIMvlb04AErsfuU8UmfiuX1WMrcfLwc75X1pYH1M8cEL DJLI4MYwDJc4nACwI4ypC2Q0tU6n1nStpnsjFIRUvc72ac8fVZ9R0teCo2x1hTse6XT1eAwEuIYC AB37FaCzWK5XurNJaaKerqGtLjHCzqcAO5wr7W+ejdeqmhjrZ5qmFjuuKQgjt9vqo20LZ6Sg3z1U aSFkTHQ9XQ0YAzjOArxurUmXelZJdDakhuEdDJZq8VkkZlZD6RLi0HBIH3WkrrfUUVZLS1kL4KiE 9Mkcgw5p9iFfiouUJnnqnU7DNT1ooGuxzh2Cef8AvLmNa7eWTU24luqaynaJI6czy9IAEpDuOoeV LLKzMtuB+HvSNsqtOmG+6filllLqmOoqYAephwGgZ8cKId6LJS2ncC8RUEDIKcy9TYmNw1uR2A8K 3tkvkdVq2tslNGIqe3QBoY0YbnIxgeO6q3v+3Ovbm7/5ocrr4vH+udyc8s7+TGfaJXeyWM4CyeMH GVnA0eoCewK5PQsVtVonTVRtVWVGpLbGLhJ6skU0rCHBpaA0tPt5UA1dC5la6CEOkcXdDQ0ZLjnj AHdXO27un8b2gnfM1pjhp307W446WsAUUfD3YKKv1rc6isgbI+kiEkBOQWO6+4/Thbx1PBc/nblc rPLcfiTaC57FcoQPUt1dH1cDrgeM/bIXmZQVMkr4208zpGfnaGElvjkY4VzINdSya8FhdDEGOqTE MNxx3W1tGmrbbNybjWUdO2N9dRNfMAPlLjJ3x9VzyvG5S+4uHkmclnqqPyW6picWS08zHdPVgsIP TnGe3ZfNsDndRaxx6PzYB48cq/EUlnfdDWso4xVPm/hheGjkAh2D9MlaawaVtNr3Iu1RQ0jIjWUT HzMA+UuL+SB4ytasl/i3OTpSF1LIDgxvBIz+U9vfssWwl2cAnAycK+lNFYproa6OhjFZJIbYXhoA Ib8/I+602nNHWe1bkXaWjpImiqpGSyM6QWhxfyQPGVnvVMfJKpEYyRloz9gvngnsrcbVWKgO5usx +Eh9I9OGdAw3LznA8dlXzde3RUGtbw2mjbFEZ3EMYMAfYLp+PLvfwn5JuT7cV4TY0u/KMlZY+X6q a/hl0fbtQ36rq7pGZRQNZJGwn5S4kj5h5GFh0QoWkN5W50dp6r1TqCjtFvdGyoqXENdKSGjAJySM +ytTDcNGi+vtlTYLYzEro3SmBuRjznGVr9C2jTWnd1JGWZsU7K9oMQOCad3JPSfZTOZYwxsy9Img 2O1NLeqm1mSh9aGBk4kEh6HBxxgcZyoxu9tqLTcKiirGdE8DyxwHIyD4X6AUMsJ1ZW07YWidtMx7 pR3LcgYVTd+hbptWzy2+D0HglkoHZzh5/VdfH47ljbfh555rvGfaJM+6yaMnsm5vJwu82Wscd615 boqq3mvo2ucZoiMtPynHUfAyubu4PpIT6eFcx+0elbrbK2mbp5lukljxHOx5Ja7I5HKiraTRlhOr LrYtSUrK2br9KncSQB0k5P7JbqNSb6QSWnHZItP0KtnattdD2+9x6euFC+pr5XOeyRzyPlOSB+g4 Wl05tPpy26+uNlvkZrIqhjXUQ6y0xg5Jz78K3Gz2xMpfSspa7OcJgH9Va62bTaIorkyyXSnmqLjK 9xZIJSPkOS3j6Bc1p7YqE7h1lBcan1rRStbN0NyHSNdnDSfGFGp32rxg+xXd7Ybc1evTXCkroKR9 MG4bK0nrz4GFNdFtftzWXMW6Ntaal7zGAJzw4An/AEWn240vV6F3mhsrpxNSy9T2PHHU3pJbke4V 1dWxNzclQ1r/AERcdFXo2+4uhlcWCRssOelwP35XKgYP1V0Nytv7Zraur2mofFeI4GiHn5QfBI8q pt30/WWi/m23OF0MzJAx+R4z+YfRXKTW4njty6roqPam/Vuif7UUzqV1GIjL6fWRIWg4PGMKPpI3 B+MEe6uZU2htr2nq6eyXGSWhjpP7psrA7yMjI8ZJUJbV6AtetLhcILtWTUszCBA2ID5ic57qeOb8 M8tvykz35cvH9IfLSO4KThhWQtewtoke2iul7qIroXOaI2MaWuHPSfpwoW1vpG4aRvk9uuTOWnLJ G8h7T2Ksa25fCYxnCZxkgZX2ooRUVkMRcG+o9rckdskDKVXTQbfajn0wdQQW9z7WIzKZQ4H5QcE4 7rli3HfhXG/hFVp/aOrt0NRTVtNT0ha14YR15IOPoeVXjRegLhra/OpKPEELXf3s5b1NiznGR9cJ hLl4+bnz/e4fSPulIDOeFO7Ph6r5JfTZqG2ueTgARuJJ9u65zTWy9+vNzulvlfFRVNDjPqtJbID2 LSPBRtFPft4R4XYWTQtyuesWacaYoax8rout5JZloJz9uF8deaKumi7t+Bughe8sD2vhJLSD/PKb +BywCMcfVA549167fRzVtTHT08T5ZpDhrGjJKD7UtkuFXTCemoauaH/PHC5zePqAvCWdOW4IIPOV dTY+zXey6ejtV4p4WU8MYfE5jg7qLiCeR91X7W+kqm8bh1tDZKP1Jp53dLWgBoPOcnsFYbRWE+nI ypJOzOtC0uFmJx2/vWf9VotOaFv17udZSUVtlfPREfiI3ENMfOPKbS3TkunntjPb6pEEc+ytduBt rTjbuitthtRlqIpBIOlodI1xaOr5vbOVWtlhrqi7C2w0krq8yGIQdOHdQ8YV1+syZxz5NKewQBld bLt5qpoJNguI+ohJH7rQwWyrmrRRRU8r6ovLPS6T1dXtj3Ua28JZ9e6WPot/LpW/RNJfZq8AeTTu x++F4KS2VVXJI2KmleYv970sJ6OcfN7cptWvDSc/RLHKsJq/au1WTayOrjaZbkXsm/EYw4Bzclp9 wCoDqIPTkcD44WtXW2cc5ldR5sHqR24WRHdMNyM+VlpjgnsEw0lZdIAB6gD91nGwveMHKD5dPdI/ upjO0Hp7XHUdTUubXSdE0LGEFjoiDwfIOQokkgMbi09wUHnATzhfT03f/SFj058/yQYkJYJ+izLO e6yDc8BUfLHKB7LvrRtjebpo+q1BH6UVPEz1GRyZBmZnBLT27+CuGfCWOLXDDgntNx8yfokFkQQR xhZNYXcDnJ7YQ2wxykpEsG0Oqr5ao7hRUcXpvyAyWUMeMe4PZcdd7TW2mtmorhA6nqYj0vY8c5UV rB/JBPssy0BNsRLg0DOThB8yOOO6WOV2bNttWyU8czLBXPilaHsc1mQ4HkELR3qwXWyVDIbtb6ij keMtbNGWlw9wqNSQgAY5W2odP3a4U5qKK21dRA09JfFE54B9sha+qp5KWZ8NRHJFKw4cyRpa5p+o Ko+AGEz+iyDf/pKWDnsUC6eEdOMcrPpdk47eT4SIz2wfsgxAS7LIdWeQEFpJ9kVig/RZdJxxylgg nKgQTx/JIhxPbhPxgd0GJ+ieD/8ASUO4RhUfGoJ6Qvn/AITlZ1BwB918ySGFeeN15Xcnt2X0cOyw OAcfVZErTJI8JpZ4QCEJj68IhLID6pJjI/RFj0wkgccL3MqnBuOsgfde/RGmqnVF6prdSuDDK4Bz z2aPJVidTUOndstH/wAMo6OCe4VUZb6s0Yc55xguyVSq0NrHgfm488r6NrZGuyJCB91ZvaGxWOq0 HNRU9HTPq5WPEkskYcQ4tIHJHjKx2n2up9MMuVZqGmp6h8fU1jpGhw6AM5APZGVbmXSRh4nwf+Zf R13ld2nyffqVqtAUOnbzW3g0tmoDCah0gc6BpJz7ccBbCipNO1N0raaXT9vjhgmMHqmkZ0ucPrhU VAkuUpwHTZz4Ll8jXyQ9pC0n64VxbToTTc9Dd2stFEBU1EretsLSWg8fKccfTC5vQO09rsd9uX46 iirYSM07qhvWGtzw3BGMptNKtfjJA4yGQ5791856ySZuXPLne+cqVZqKxUG891ZcaKF9DDWvEdP0 gRg58j2+i7jdzbS13rTZ1BpuGmopKWFz3xxMDI5GNBJ4HlWX4OvatDjnv3WJTHIyl5VUIzyg8o+6 AyMoQjuFADusm8JBNvfCsGytlfNSu6onlhHYg4Xtr73WVUfTNNI9p8F2Quy2K0dQam1OG3aL1qaM Z9I/lcT7qR93rJoPTNsr6CnsVLHc5KcuhkbkFhI4I5U2VW8SEP6hwcrZ0l7qYo+mOWRg7Ya5aUdQ AH+imDb3Zarvlkdd7/WutNG4Axf3Yc9w9yCRgIlcHT32ppnEwyyNz3wcL4190qq/Amke8d/mOcLp 9Bbff2o1vPaW1ZFBTyuD5w3DnsDiBgeCcKerltDoqqhntFFRNpbgIm9NQHOc5pPZ2M4yiKxUF7q7 e3pp5XNBPZpWNyutVcAPxMr349zldRoXbmbU2uKmzSVBZS0cr2TTdOHODXEcDwThTndtndHVVJUW q3UgpbmIm9FQXuc4E/4unOCps0rVar5W29pbTTPYPZpwsLpdqy5EfipXvDeR1HK6bQm3c+pNb1Fk lqDFT0kr2TzdOHENJGAPBOFOF12Z0jWUFVbLVAaW6Njb0Tukc8g989OeUl+iz4Vtteoay2M6KeZ7 W+zXEBF1vtZcek1Mkj8cgOOcLf7d7ezar1lNaJZzFTUsjhUS9OCQ04wB4JwpvvWy2k6q3VlBZ4jS XZsYMc75XOwe+enKuyxXq26lr6JgZDNIxo8By9NVq65ygNfLIW+xcTlS/pDZqxW3StRdtZyPqX5z iF5Y2NoOPHclbOo2f0jqDTdXJpeOWnrAMxTyTOeARzghNpIhKHWdzjYGMnkDR4BTl1rc3NDTPMB5 +c8qUdG7Raco9NOuOtKoz1EnIZDN0CIe3HcrcT7NaTv+m6qTSpngrQAYp5pnPbkc4I+oGFdrpCdL rSugcfRnlZnuAcArKo1nc3MIE8jQ7v8AMcFajTVojuGo6aguMzqaAylsrmjkAHkD6qbdydqNM2fb urvNmbVmpjax0T5Ji4EFwByO3ZJ3dMohtuqKujldJBM9jycktPdYX7VFddmhtTPI4D/M7K77abaI 6gpn3fU3q0toDT6TGnofIffPgLZ7kbMUtLp1t10X68/o5dNFJIZHPb7t+yba0he1XKWiqxNG4iRp 4IK62fcG7S0vpOqZCwjBBccLmdLaeuWpb3FbLVB6lTKeTjhg8ud7AKYtxdnbXpPbua5NqKqousIZ 1PL/AJCS7DsNx2wrjOXUZysx7qNLVq+toZ3SU88jHk8lpxlYah1bX3jDamd7wO2Su32n2gk1JTPu uonS0dp6T6Yaeh8h/wA2T2C9u52zLLTZG3bSUlTW08QzPHI4PeW/5m4Hjypyi6RNZ7nNbLjDVQuI ew5XX1W5F3lhMf4mToIxjqwuM0xYrlqa8wW20wmaqlPAxw0f5newCmHcbZyh0joN9yjq6upusZja 5uR0OcXYdgd8K4zfUZysxm64u16+udCzop6l7IiclrXcL6XTcG41kZimqZHR98ErudHbIUDtORXL V10mpp5gHiOne3pY09gcjuvTqTYy2v0xVXHStzq6iphBe1tQ5pY5rRlwyBnOFJYvpH9u3GuVHEIo Kl7W4xjPdfc7lXZuQahwa7uMnBXG6NsbdQaioqGeoFJTyPHqy4yWt+n1Up7s7S27R+kX3i23Ktnc HsDWTBpBa4+4AIWsZcrxntnPKYTdaiHdG6RsDRVlrR4B7JVW6F2mhdCauQxuGHcnkLgtD2I6h1FT UEtU2khkf/eTOGelvnA8lSruns/R6S0yy6W+51dW90rGNjlY3Dw4+4xj+aT9rqL69tBb9y7pQM9O mmcI+/SHYXyvG5FzucIhnncYs5IJXYaW2Mjm09T3DUl2nt00+HBkbWlrWnsCT5WGsdjW0On5Llpu 6TV74ySWStaA5o5OCOxUl36Lde3OWvcy60EDYoagiMeAV4tVbkXO8Uf4SWoeYicu55K7PTGxjajT tNX6iu77dUVHzCONjXhrSOAc+V5td7HfwnTkl1sN0kuPpZdI2RrWgNAySMKb3dRr13XJ23ce522y ChhmcIsFo54wuAutxmrap0kj8lxySSumtG3Op7zpw3mht/XQYcQ4vAcQ3uQ3uuJe1zHlrgQ5pwWk cgpV077bzWVXpgPFLKWMkdlwHle/X241w1DQ/hKiUugznB55Xx2m27GtRVSVd0bboIyGxkND3Pd5 4JHC3G720X9hNPUt0iur65sswic10QZjIyDwSkv0tn2h135jwvXaqg01bFM04LTkH6rwknJ+6+kL HvkayNpe5xwGjkkrKpvs+7NzoaaOnZM/oaBha7XO59xvdu/CyTuEZ7891u9ObCXKr0/S3C63iC2T z8iCSEv6W445yOVq9x9lrjpjTRvNHcY7rTxkmcRw+n6bB/i/MchN/TOkOVDhJKT/ADXusVY6guMU 7DhzTwVrXH+aGEtOcnIVaT/at4bjS0MdOychoGMEoqt3K6anNJI8GnccuaexUYbc6Vrtb6ijtdDN HTktLnzSAlrAPoFluTpeq0TqI2mqqY6l4ibKJWMLAc54xk+yssc7dXX2lqq3rr4aIRxvzgYHzcKD L9cXXC51FVIfmlkdIce5OSta6RziCTlIgZB5RZEt7WbhTaVtktPTnpbI/rcc/mP1X03A3Lq9SCnh ncCyB/WzHuokEpjA6ScI9Unl3hJSxOuj916u00QiEpLce61GptzKq73uKofIelnYZURes9gOMAJN lPfHda2mqsZRbz1lNSxwxyHoaABzgrWak3aqbtU0TJnAwwSCTpHkj3UDCoe3kk/TlY/iHdecn91N ymqsxXb31TLe4MPzFuFBVPenxahbXRO6HiUyDHgkrnZap8jMe31XyEh78hNrpZy0b01MFFDCQ0hj cA55Wu1Du5Nc6+jL3D0qd3X0+Cfqq+R1bh7/ALodUvLsk4ym4mqk3cPcWr1HJ80pDcYIB4XEafhn ut9o6SnYXzTytY0Z7klaQuc4OLuSVtdLXOS1XiCshyJIjlp/RZy7mmpNdr7yxV9BpKGOh9J1ZTxN BBcMHp78/ZQNq3diorKimj6hH6bjkDyvJYdU6q1XDU0tmLpTFC6SRxPS1oAJxn3OOygq51sstTI+ TIcSSR7cphjMcdM5d5bWXg3mcyjjjc1he1vSHuwSOMLVal3ZbXWuChaG5Y5rg/uR0nIwfCrmat54 Dj+6H1jyRlxytTSXa1FFvNGKeGOWNjixoGXAErm9abtyXGtpBC8MZEQTj7qvf46XI+Z37rCSpe93 Vnyp0va11NvLC+nhjngjeWgDqcA7P15XDbv7kHUdC2hbgQ8ZaOBwchQd+Ol6gA4/fKJah8zj6jif 1Vmi2/KfdqNym2OxiimAkijHSGnkdz4Wy1NufBdrzbmTRxmigeJDDj5SWnLSR9Cok0poPVV/tgr7 NapZqR7ywP6g3JHsDyR9VzV7grrTdKijr43w1dO8skYTy0hXpJtYjcfcqmvljht/Q0NMjJMjjHS4 FbC77nW+4U1tpqmFkkdO9sgaRkEt7ZVXJa+aTpLnO4+qy/iE2WkvJ44SWQva1Wq92LdV6eqqSSni eySIx9BAwARhQVoTUz7Nqenqw8joBaD7ArmLc24Xqtgt9DHJU1cxwyNvJKyv1huum7iykvNFLR1L 2CQMf3IJwCp1roWkm3TtFYYvxtJBO9gDQ57QVptSbrNqLxRGmcI4YeAAeAff9lDdNobWs0EU0Ngu EkUjQ5rg0YIPY91z2pLfdrHXtpr1Sz0VUWh4jlbglp8qTS7q0NZupa5yyQwRfjGt9NswA62g98FY y6zi1PqKzU9qZDFc2OP+0vGC1uOcn2VT/wCJzZx1Z/VbvS+oqigvEFS15yw4zlWyaT52ulHPO/VF FHXWdhnbHxXMbkAc8dX+n1UY7p1VBSbt2eruUbJ6Wng6iwjILgTjI+hSs24mprhQiooLfV1NMPkE sbT05HjKg7Xmpaq53ieao6xKHEOa7ILT5H0Vwut7+WbN5Sz4TVufry33qktlLGAwQ1LJeD4B/wCi 6K57nWuastby0YpSZcZ7npIAVR57jM/GXdu3PKyddpyWgvd2x38KdXX8a7iVd1dxJb1VSCGTEQ4a AeAFodpNU/wLV0Va44c5hjyfGTyuKordcbzJL/D6OpqzE3qeIWF3QPc47Lwwvkin5y1zTjtgg+y1 bvok12uNV7hWE1hroIGR3R7RGKjyBkZ/kvlLrewP1jQ3SOINq443NkeDy5rhjH6KtjbfqMxNk/hV 1LMZDxSvIP64WtqayupazoqWywTgD5JGlrue3BUp8yrGaq3GpJrxUR0uBBVPjZKfcNIK32otxqAX G0z0bgJIiS4k5GHDB/kqvyW++yP6zbLkT36hSyEf0XgrLlVxTFk5kZKzgteCCPuCpJGu1tK3W+nR df4pSsa26vAiE2ezc8gj7ZXguWrNMnXNFfegfioYHte4HJcHDA/ZVWN9qfMhyO2Svm69zvkLy4jj BwVdw0lndLcSe61MjGSn0gSGgHhcJoCSWu1vZmtDnuNXG7A54DslchUVUk0vUXE5Hld1szqKDTOq P4hNGx7xGWM6hkDPf+Sxn+2Oo3heOXJbfX7bGyotk9/ifJ6T+uEtcQGuHuuQu+5VIdX0j6ctdHG0 taXHsHfm/kuV3F3Sp7rpqajdDG8ygdL8csI5BBVfqq9zOqS5rzkHIKTH1tn16Wr1E/Qd/vcdyukb pKprmuBEhAyDkZAPP2Kiz4gtRW6/V9HHQwxA0wcGytABLTzg/qopOo6jIPqH6rW19xfVTFzn5PdX oW52lu2m7BoaipGTOEk0QfUZdnqe4c/ZQNrvTD75r2vpdIQy10b8zNjbjqaPP81yVu1DU0sAjEhD R2+i3uhdZ1Onb3NXUz8Syx9BdnnBOUxkxxuM9VLN5cr7ed+1etAf/ucrz/yhp/oVJOylrvOgLzNX X+0VVJTztbAJJWjAyfJC+g3nueB1TkH75Ws1XutX3WzupJZAY3nJ5z27Jr7WpxN307btQVF6oqqR 9bWODHxucOjBI6iPbgL5UVbYKLcWsu0FYc1tKBK1xGA7PGP0VTpNUVBlBD8YORzymNU1IqTIHkEj GepW9s6qzFTq23i8TUAkaY6i6Cr9TPZo6f8A9ldNdtW22n1hRSxyslbJT+g45x05dnKpxLqCpdV+ qHng5BzyvVUarqpKiOXr+ZuPKWSklkW3gqNP2fUlVeaWufLVV7gySNzgGhueSOM8fdQrv5YGXLUg qdPGa4yVDDJNFEwvcw58AeMKNpdW1Zex/VktOe5XVaB3Emsd1qawFrpJohH83OBnKu9b79nCblqP JdK32J+H2W6A+xpX5/ovNV2a5W7odX2+spWvdhpngdGCf1AVjxvXUkYww/yXI7n7lu1Lpv8Ah00M Ra54f1dIy0g8ELHFvabNtKK1WjbaG1fxFrjUwl8jiMdLngZH6LgdoZaPTG4V+oZ6pksUgEUMw4Dm 5JyoXt2sqqmp/SEsh4wB1LWQ6jnhuf4mN7g7OSfKuv0uHwxZvK5ffS1kGjbUzXMWom31rnNmMvo9 AAyeO/OV0VqvdBWa2rXtmYxsVM2LLncEh+eFUsa3qg4OZO8H7rCm1pVQVbpGyuaX8EgpcZbcr7rO OEwkxnqLK0N4oG3qGidMOs3eSoyPy9HT/wC8uspaumOtqp4qIw00Uberq4yHk4/ZU3OrKhlaJ2yH qDshwK20evKoT+t6z+pwwTlbve1s3rfwsRbLtRR3umonTgTG7Sz5/wAPT047ro23Kjpdfu9SZhE9 GyNrmuBHUHE8qoLtWVDLiJ2yOD2nIOV75db1T6yKp9VxePOViYyXaY46kiz2k7NFp3VV1udRXQSt usgaxkZ/JjnJP7qu+/ljktmrJZnSxyxVZMrHMOcZPY/Va+XX1Z6zJPXcS05HzFc9q3UM96qBLNIX YHGTldLne+/ZPHN436SZonayxX3aWovNXLNHeMSPjc2TDR0n5QW+VuvhYnp7bc7vTVMjWyzhjWg+ SCVEVl1lWUtkktrZnNi6SAMrxae1JUWi6fiYHlrgfBXK47jtvSxtVtXcLlrOWtqLhTx2qSd8j/Sk /vekg4xxgHOPdffRdtsmnN0HUdLO6vdPE1sclRgvheAS7BHvwodO5NwLw5lS4fc8rRRaxqaW+MuD JCZ2nJdnnlXP9/dYx/Sai6FFJANV1zBGwS/h2OM3VyRn8v8AJVV36dQTammfQw+i7JbI0Hhzh/i/ VOHc2tZVun/EOL5QATlcDqm8yXKudNK4ucTySVvHLjLHOeKbl+ki2DZ6lu210mpv4hPHXei+VkHQ Cw9LuOe/Iyuq+FAQUdZeo6hzWzy9DWA+cZUYWPXtwpdMm0smIha0tAz2B8LW6S1XUWG7fiIXlvzd +yxxdlvdGw3Siv8Aczej0U87yylzJ1dRznj24UX2O21Vs3+po6uF0RlfLK3PZzSw4IK4ybdK4Oqo JXVJPpEubk9jjC1lduNWyampru6cunhHSxxOcAjBWcsLlNNYZcanO7Nxv5Z85x6Dv1+QovHU3fqz jJwYSfv/AHZUK1e5FVJqGlu5mzPEMNOeQCMFZ1u5NQ/UtNePVLqiJvS12eQMYXfPLlNfzTzY+Pjr +VNF5B/7drMDnHpE/wD1srs6B7I9e3UOIDn00TWgnk9yq0VO5lRJqSkvDpCZ4h0td7AjC9s26VUd Qx3L1cvaMd8+MLlZbdu06xkd7pew3im3Zpqqe3VTaL8RK4zdHyAFpwcrbXFrX79WuRjgW9BGRz/7 Mrg/+2WvY4ls2c+5XKU+4E9PquG7l+Z4yTnPbIwrOscp9sZY8ssb9J+r6ev/AO1yimhp530D2jrk awlgww9z274UQ/EhCz+2jJmAHMLRke63H/bPWY6hIMEeSoq1fqp94uzamd/V0vDh7cHKb1L/ANNY 4SWX6WJ09SVZ2T/DzQyCsFI4OjIPVnqz2+yiXZGRzN1bdE3IDjKXD7MK6i3b1zGmHUGghoHP2Ub2 DWQtOvxfQxgcXvdhowB1AgrlhLj4PxX7bk/5svL9p8vEhG+VqY3I6mc+x/uyov8Aiei6tUl+DkRN H8l9Kzc6ObWtHfHMaXQN6R+rSP8AVbeeho92q2tq625Mtwgaxrf7sOLz+67Y5SW/9MXG2ST4Vne3 nOMFZwZbO13Yg8Kf5NgbfIcxauib9DTB3/4wXJ672uGi4qG4Q3eC5RGYCRgZ0FoBznvyOFizc03O rtOFhfJLsUXT5MppD1ZHOeoLR/DOwCo1AQASTFz+6+9Fu9bJKL0n00PQWYLCODx2wuB0Jr6DTmqq ySBghoamUuMbe3nA+3KvjnHwTxfVc9X8uXkvy6/SdzldvBTUEs5cwVMnyF3s1xHClm39LNdXVuQC 6nhA5xnGVHcG5mnoqwVQt1K2paS4SiMdYPuD3C4yt3Nl/tW24MeQA4dz48Jpps9MWiri30in/DSl kU0j5HdPDWuaQ0n6EkLUfE7EJNQMlBBAhaARz4Ug1O6doZFUVkDGCskiDfUB5OOeVFbrTe90quul tZp3mmx1iaXo4d2wr4/1tyZynLU+kJluDwFP3woWWkrLpc66oha+opGsMDz3YSSDhcxLsVrMv+Sn oHD6VQ/1C73a61Xvaqd8uoKaJlFWPDHvikDwCBx27LNam0oaHvE111deGyH5IIwwD6h+FptsoY5N cakkcwFw7HHI/vCsKPWGmLTd/wAVbmiKWrf/ALS71Mhw79vHK8NDrCw2fXMs1vf001axvrZdkBw5 JB+pQjp/7SWKiuDnTT1TJmPwWmXLcj6f+8o81trWmtmrfxthkAdVRMimc3guweMkLq4Z9Ei9tunU 81bJPUBMuW5x5bnH8lD279/tt01LDNQxRNMTQx72DHWAeM/Va/8AGz7TW8pb6Txr6+Vdm03R1lK8 iV7ml31+QFcHsRJHftX366V0cc9SGMex5AJYevGQfBXWWXVGn9T2W3S18jAYHhwiIBGQ0DDgfC1l g1Zp+2a8qBQ09NSwzwtge6JoY1xa7OcDyszrx44/Kyatdiy6UNPXOdJd5Yw12HQkDH2ytVZrTp+v 3HqrjR01LJM2jbJ6rW8tk6wOoHwceV4pLFpipvouNRc5ZCZOswPwYz9PsvhYNQ6dtOupobfFDTxz wCB3QcNJDs9SfA89fuObZqV1FVE/hmSlr3DuBkrna/XFjsGr57lYYAyWvgEVUWjhx6s5+66ev0Np 25akF1rLoZWGX1HUpYAx4PguB7fook3ho9P0N8pm2CIQBgAmYx5c0kHORnlMpvel8V1/usHqa+Ot OmKG4hgJkDHOBHgtyqibjXCG7alra2Gnjh9Z5cQwYBPurUUktr1fpK2MNRE2BnpiRjnfnDWgEZHZ QNvfYNPWq5U7dPh8byCJ4+vrbnPcZ7Lpjf8Ajk+XPHHWdvwh945JUm7AW2zXDWB/jreoRx9VOCR0 mTqHceRjK6ravbvTup9vK2tujXtuIkkZHI2Xp6Q0ZBx91ptmdP2mXWNZR3iomYY2EUzo39OXh2Of 0Wb6dflPt6obbQVUYl03Q1FJJyJo6Zpw3Pc4C4K6W/ROn9Z/xWKjpJ6augc19MYx6cb8jDmjxwFK FugvFvqnQfiKartYb0Ma+XD8H3HIUJ77WWgtV3hqLbMWmVzvVgx8rT7j7rM7Z+U21tRbjoSjmnpI jbngEQHloaS7H6KtWpLbZrluPB/Abd/sL5Wukp2ZLcZ+b7BT9bYo9R7U2yio5A+T0ImPwQCCAc9/ K0Ok9HUGjNeZbdXVLaqlkicyWMNcx2RjtwQVMusdz2s7yrYS7ZaSrJnQS6Thhaeoeqx+Mcdxg5UR WzQdksG509pvrDXWtzXNi6iWnJ/LnHkdlPjIbnSa2qZ6oObZyx/TJ1ZaXEYAI8d1H24em7rV7kUs 1JSSSMe8SMLexDSC79l2wk1ltyyyymWOvVe6t2f0ZbJK2asoy6lke10LPWcHMGMEA+eee65nUO0W nbDrOjmqXTDTlT1tMXqHrieG8fN5GVIm9IrY7LDV0cT3MhcXSFo/KOruVBmstx62/UcVLUux6Z6u +clcpjbHWXvSw1vtdmptAR0FI+b+CthLGku6nBpeSefuVV/djTVqs+oBHYaqWeCUA9DwC5rj4yO6 sNpQSVuy9I2HMszqUfK3k56/ooS3M0Le9Nyw3Kskp6indKB1RPJdGeCA4FT/ABuvFq/bllLPLden p2r2gbqVlwbqRtwt0kPT6Q6AOoHv3Xm0VoIW7dm3Wy6QmooDUOa10jCBIACR+qmjarcJmo46k3OZ kUkLGAA+TkZ/ovENaw1uvLVb6iSIxU9UXiX9CO6W10l7dBrCvudFdA22QNkp6GJlRLl2CG4A49// AHlpd2tGWzU8drlqOmlq5nsjNWBnpaWg8jzyVudayXGC7Sfw+kFQy5QspGuzwHYz/T3Xx3XeKfR8 AD+idhjIbnn8oCvL9oxrrf8AUA612avNjrqSG3yC509WQ2OVjOjDu+CCf5rcxbXVug6q0akq62jr YYJmPmpXRlpAI5GDwcFT5oL8ZNpyidf4vTqvV+QSEHqGB0kfoot3ObdrzrCl06C6AVUvTC6QENIO efsk7btbyn19VX65U1v0vTkENHqHkNjGcZIHYAkLea+s9vvlhtdBfGRvrpHsZ1t5cxxOHdJXxttF Z9tbA0Mz+OlZ1SSOI63EjkBw5xkZwo/feLzc9e2SoraOshopatgjkfE4MOTxg9il6xtXD9spKkqu NPoDTtPRWikkIDc5iYcvIJGXAecBVq3Yu1Re9QyVtXRPppHt4D4ywkDjPI5Vn9xNTTaajppY+WyB wxjueorR7jWii1XtjT3WsgD6wRNkie0Yc0uJ44+3ZML0invQX4Dc57fVSbp/aG7XPSzr1POylYS1 0cb29RkYTgu47Y9l3W1G1EIay+ahj/us9UEJOOOcPJH1HZdNr3XMH46ntFuc3D5Wsf08DHUOFbVl bWx6Zs+2ukRFUMinqJPmllkaC2R4OAek9uD7+Fzm6e3Fs1PZP7RaeZDTziPqc1jQ1kgHHAHnKkzW dRR09ztMlz9P8H1SB/qAFv5cDI+61VC2M7WTGm/3HpyOZgf4fVOFmd2QzusLkqNftK3mxFputtqa ZjzhrpIyGn7FeensFzmoxVx26qdRk/78REsHOOSBgK22l6ym3C05V266RCR0LGgucMkEuAaQvhr2 80uj7O2zUETYWyxhrY2DDcOAycdhkpu9pLqyX5cvoLaiz6esctZqyCCsnljH93KMsZ2cC0j3Bwoy 3fo9KMq6d2l6MUruk+s2NxLCfsrOamkt0OnaY3aETUrmsBBcRj+7Hso8vm3OmNWaUqq6w04oqqIu c2Vri4O6Rkgg/dPHlyx2uV1dId2X0RBrPUc0VdIG09HGKh8WP963qALc+O/dS3qHZvStzttfDYYn 0N0picEylzTgdiD4KPhwoLfRNuI9Ii8s62SPDjh0WRgY+4X03P1LFpm8yVVrmlZWTNeydhPy5zgE K4byys+mc8uNk+1Y7vb5aCrlp5cF8bi047ZBXh6fqVtL1VPq6uSZ7sue4ud9crWYat1qdvPUdwvg 7ljh7L71POAviR8jj48rzx0rzYweVm//AA4WB5PuvoRxhaRiAgdkBCBhLymmgPKyZ38LEDCyaMOQ S/8AD0wHWcBAHH/VdV8T8pbqGygHA/Dv+2S9RVt9qF+n7tFVRHBBwfsp01nfdL6t0VK64yA1jIy6 HowHB4B6efbKQrwfDo25VE8xY4MoWEF2f8R9lK25LK6bR9yFpmZFKxjnPJ8sDSXNGPOFwehtT2HT e3fRTTsbXiJxIA5LyPP6r2bc67oq23VLb5WMDj/gd5z3SIx+HRwltFVJ/mP/AERuvqOGa1PtFnDj dhcWtEMI5OM57e63OhrlpqzC4SQVrIzU1D5BGMBrGk5AAX2tY0dbb9W3llUJa+qeZHSSODujJyek eFZ0NtpyeWg0A+eYOZUQxyPfnghwbythpS+U9+tsM8JBf0jrwc+y5a7aotDNFXpgq2GWVtQWNB5+ YcLm9jtQW232OdlbUsZJnIaTzjhXXTPyhfciRw3Mv7xwTXSHP6qxnI2VrMjJNDL/AORQjR2+16l3 YuVRcqwQ2x9Y+X6vHVwF3u724NvoLAbDYS0xPiMbi08BpGMK4dZzJnKcsdKxSAdeFh4X1m5cfvwv iVbd3bU6ZeFimEIpYRjlNHlABZt7hY4+qziGXeEFgPhfYDfah30C1fxOSk7gNaCcCkjz/NbL4aam npLnUSVErIxgDLjhbvf3SttuUdbqZl4a2pggY1lKGgiTBx3z9Uw63tnLe45jYHb233qr/i96kZKy E5gpO/Ufd3/RdLvrrOvpaj+BQQvpIAwHjjqb9Coq251jUaduEZZIRCTy3PCsJqKnsW5WkGNrKqKk qY/niqDyY3eTjyOOyyrmvhrht7PxUgDn3KXBc4nhrRnhfTfbVMdjvVP/AAoviumB68gccFmPlGFj 8PFsFudcK2qrIQ0PMcbTwXgEjq+mVzPxLW6Bl7obtT1rJn1bTE+Bo/J0gYOfrlaw1q7Yz3uadd8O 7aCR9bVEukulS4yOeTw0d18d8NUR2O9U5tL3RXMt6ahwPBZj5eP3Xy+GyhbTUdVcqqqija/5Y43H 5iOeVzPxJWuKG/Ul1hrI5fxmYnRN7s6AMH9clXx61lyM98sdenZ/DvHQyS19Y4ufc6pxeTnho5J/ qvjvhqdunrzTutEr4rk8FtSQ44LcDp4/dY/DbbzT0dRcqmeJjXjpjjLucc8rkviVtrYNRUdzjq4p m1jTGY2d2FgHJ++VnwzXLZ5beWNjufh1goHxV9b1ukudU4vefDRysd3NSx2LUVObTJIK95LarDuC 3A6eP3Xx+Gu3upbZUXGqniZHJ8sbC7kjB5XNb52v8HrakuTayGWKvdgxtPMfRjk/fKYSay2mdv5M bPSaQ2mqtunM1GOihljaXtiPSQC7tn7r06RprfS6cqI9K8RAZDpnF/PK1dWyHVm3L7ZQ1kEMj42t Ekp4BBz4X30vBFovR9RDca6nmk5DXRE4JOQBz91NdNze0J6I0/etdX+enMs0NngkLp5uenGfyt+p /kpG3D1fQaOsbLDpsNFQ1vT8hyR9z7rraOgdDoRlFYqimo6p7MiRx4DieSccnK4m1bT0XoVldqi6 irr3dT2Ogk6GNwMjg8nlB59t9A23S9nk1RqRjKiunHU1rhlsXUeBj3J7ldfuc5tRtnM7oDWSel8g HABf2X3qaaPVG3wt9FUxRzYY0ukOAC05K+2p6Jt00LPboaiAS04b1Pc7DSWHJ/oumFmNlc8pbDud F6m3tHRseYWyCBpe3gtHVz/JezSlFHQWu70cMj5YInPDHPPUSC0+VqLHcKLWWkH20zehMIw3LXct c38pz7ZXzrrpQ7eaNMFRUiprHx9JOc9bsEE/blcsZqadLe7T250lQ6U046SzsgdcaoB0s8zgCSc+ fYey9+v7NUXjRT6R0kBlDWvle4/Kekknn6qA9J6nvF31BT26kqHH1JMAF2AG55JVhtZUM9To+Smp pmetC1j3O68AhnLhn6hdMLxrGePKPJeqB02hqCip5DTskEDS9pwWt6uf5L1afoRRadvNGyR00ULp GMc85Jb0nutdQVdHrbR7qGOoNPMIwAWHlrm5x/NfK43Wj0DooU1ZVfiK18RDjkHqeQQVyxmtT6av e2G22iqHSGm/Us0Mc1zqmh0k8rgDz4z4A9l6t0rVW3fQs1PA6L8VExsry52AS3k4KhLSWrbxd7/T W2hmc4SPwG9WAG55KnHcy2XGu0NLSWueNlTHGOt5kwOloPVz9l28fWbl5t3GaQjtw/8AteZae/Xu WkoImgMjafmef14ACnajo4LPoWqp7M+SthbE8B0rhk/Kc8gKI4tnGy6bpK7TF1lmuD2sMjJXNbFk /mxjkY+uVLNmpX2DQTqO6zxNmDHMLmnqGSMBc8Zqu3uI62x20temrSL5qZrJ6ufDoYnflYDktH3W 9+IVv4jbOJkEfEjowxg/kF0eo7ZPqDSVsp7S+Nz4pInOJcGgBvdYbh2qa8aVpYaEseaOZj5Rkdmd 138NmOUy+e3n/wAjG543H+xHm1O2Fv01Zo75qoCSuqAHRQk/KwHloH1XZ71GM6Ktr+nEf4mF3T9O +FtdVW2o1Fpe0x2UskMc0T3fMGgAd1rd6bfVXTbx0dsDZZKLErx1Y4YDlc/BNZY2/O3TyW2XU9V9 rpJatZ6PpqJtz/A4LT1NaHEY8YyFtqeghtWg56WnqDVRRRPPqluOo49lXTR2k9XX+3wXC2U4/BSu IY6SYMPHnHsp/rZoNN6Rp7NX1LX1csYY8+AXDBK1h+tk+IeWXObntnqa1R6i0TQUtVVm1NPQ4SEB xwB9x3XwvVHHZdrKyjhmNdEIZGum6cdx37lY7iWyuv2iLfTafYJ5myM6gHhvyhuDylcqWW07S1NF dSyOqNM9pHUDl2PdY8WMnlwv9a8//wAWekWbN69ZbTHbK1wNNgNbnsPovlvttVDVQSar0rGCxwMl VAztgDJePqvHslttNeHMvd8Ho2eM5jaTzMQeT9At3vduLBHQvsNkLG07Wem4t8jsVryT961jf1iH tr62aPUVvp4pXtjfKMgHgqwvxQgHbWiA/wDk7P8AyqC9mtNXO86mjqrbSulp6KRrpHjgDPhTr8UX ybd0DXcOFQ0EH/lU8VmOe6z5pbjqKcOb8xwc8rd6MmiptR0M9Q0Ojila8g+cFaVx+Z33W50hQOue oKOja/oE0gaX/wCUZ5Kxfboud+KoNe6OFLFVtpapgBikB4a7GOw7rl90LxXaR0NLZLhAKmkqKcwt qg35XEjkL66n0LJZrRZ6nQ9NUTTtf/f9MvV1N6Rg4JA7roNfQGp2Zr472wMrDTOwJAMh+AePqkSq NyNDXuHgFY/ZZzcPIPfKwHcIfCyHws2ehkNZVSTyNuEhDYhG7HS0d8/dc78QVsnuG5kVDATJO+KO NnUfJJ7rovhQpZ33eqnaxxp42AF+OAStxuHaqgb22mtqIHspJHxsjkc35XFuSQD9E8f+nk+9Ofk/ +bxT4FNsnpCx2ChOqJql9fJnrmimLGuPBwB2wMrwa12Os/8AB6C4aZqJooTM0TmV5eXscQPl9iFI e+tquV3s1pbZaWeqLJXF3ojOB0jn910LoHQbdUNNUNMc/wDdNLHd89Tcpj/rLWu7vSPbv8PWnX2z 0rdPVQVjy0skfL1cAgu4+2Vz+uNiLfSUNBPYaiYM9ZrKkyvLi5rnAZb4yPsp5vEnp3yg6nBkYim5 JwM9IwtZM150HB1cuL2c/wD0QJdpMt2I0u3w8WGS3GO2VlXDWOLSySWTqHSCC7j7ZXP652EoqClo KnT1XMYDM1lSZ39Ti1xAy3HGf0U/3c+lfKFznhkYimJycf4VraoOOhaHq7l0XJ/+eBMfXbcsV73K 2ct1kvenqGzz1ZbcKgxyumcHFreO3H38LSb8bZ2zQcNtltE9VIJ3ua8TuBxgcYIwrFbiW6prtWaX mpaaWaGCZzpHsYS1o4wSfC4H4sqWSe022eOJ74InEvkDctbngZK64YzLySfHH/8Ae818lxxn/wDU qgfzH+S9lnt1Td7nTUFCzrqaiQRsHjJPc/ReR7cPI5XR6AZWP1VQNto/2t8gbH4GTx3XN6U8RfD9 YKC10sl/vNfBUlg9V0XSY+r6Et4H3yua3G2PNno6Ks0rVzV9PM9sb21Dm9Qc4gNLS0DjnnhT7BUV dPb4LVqm2iqDh1dcQL2YHnIHC1V70/VUmo7VW2+d0likma6SFzv91k8YHt/RQntHlN8PNop6Cl/i 95r4awxgzCFrXN6vOOOB+60OtNjf4NPbai03KSW1TPayomqQ3qiBdjIwBn7KftyNR1lgqaM0NJJU iVpz6cRkwcn27LgNzb7qSfQz6quoWQ26QsLnkgPbl3HHccq4zftMq7nbjSds01peoobTVmpp5HPc 6ocAXHIPtjsFXLWu2FLDraz2yyXY1UdykIlc5ozCerJ4H0U+bQTPn2tMvUXSPbI4eT2OFG2itIah pNYWi9XSmxQvlBDy8EjqyBkeFcP/AI7XPG/8mvhx2utmf4FrSw2Wgr5Zo7jw6WRgyzBwTgfRfLXe zo07rKx2amubpae4jL55YwPTwcE4H0VgNwKd0u6mlC1hcGMeSQMgclcf8STnw6m07NGCMMLQ4e5d 2/ZXHHeWv41ctYz+1ydw+HltPdIQb702l8Id+JdEC7ryfl6c9sLi93dpavQtLS1tNVOr7ZMA105Y GFrznAx7Kx27T5otvrU6n6uv1IAS3vg9/wCq8W/MMcm1lEyVoc0PhLge+Exxl49+0uWt/wAquW1W 2VZr2rqmfiX2+CCMP9V0Jd1EngAZHhezTu3g/wC1ePTdzL5qSKoLXS9JZ6zG88d8ZVjNodW0l4ov w3pw00VJE2JoGBkALzy6spbhuFBavTgDaad0jZmjk4B8/ZYw5d8ms/8Abpt9U3Co03NQ2yx2/NFS 0wmeI+PTYHdI48hcvvdt/RauobNcITFR3OaSON1QW5HQQScgYzhdPuJW1lDead1HRmpiuMDKLrHY EuJ/1Xg3qq/4boW2Rtf0VMckR6f8WAMFapP6rxr7Zu+6auNBT0TnXanrOlkc8UXRiQ5+UjJ8ec+V 6NW7K3iwUFskirY62trHtjNG2MtcwuGe+eQDwrT6FfPU6Ttst3b01Uh62CTuMjIx+iiDVGp6yybr iS9xvEMPU+nbIOHNJIaQrjNy36Zt1ZHV7Q7e2zQdLSG4Fs1/r8B7j/gHfpA8ALzaztFFcN8tPOrW RuhhpnOIeBjIJwt7pXXtFqTUdLTxUsJlOcSdI6gPuvZqCppqvcyx2uSlYXMYaj1cckYI6T9FPeOU /iXryY159d1OoqW80cenqOaah9Joe5jflaeoj+mFx3xR2+kqNFW+ofHGK+OVhDiB1hpGCPfGV0O5 ur6zT2qqCgppSyGeNgxnjJdheL4hbRLeNM2qKhgMtfNUNY3pHLh05wfongkuUmSZ2zHpUe1Wusut yhobfA+erld0sjb3P/vKwNk2LpKf+zkF4qXm4VE7n1bI34Bj6choHjkd11+gNGWva+wuu14Mc17n by4/4B3DWjwvJoPVsmpN1IZppAIo4nhrc8AY4/qlm5XSXt2N0vkWlK+ks9toXtoaWJsknpN+UB3y gH9QuC3r2sivl4tdTYhBR11dIYpC75YyA3q6jjz9V2Gt6l9JqiWlNFNObo2KCFzWnHykk/fHdY75 3B1rtNmmjf0vZUDODyB0/wDvLcxnKSfTjjleMtnyrDqvbTUmnr7S2yqpBUTVRAglp8uZIfIBx3Hc r1as2svul2W2S6yUphrJmwgwyElhOOSCBhXG0sHXOxWquucAFaAZG9bcOaSPH6Kr29GpbhXaikpq zrj/AA7/AJGOGOAeCs442y36bucmUl+Vh9q9N6f09YHUmn3CV3T1TykfM8n3PlQPtdpqgum9lSy4 U8UtLDLNMI3ty0uGccfdSd8M9VJW6cuksji4h4aCT7BQzFfpLBr+uqYnEEzvBH06lrxzfjyMrryz 60sBqvUt4terWW630FQ+kcWNMscZcADgHJA8LwbnWbTtLq6xXy80EUxa54dkfnIHyk++DytRZt16 26XWko4GB0kzwwBoy4jyf2yV6/iQbPNQWiOkjklmMriGRtLnEdPPA5TDvK/9M5dcX3fuHV1l5gis 9DUyUUsjYxKIHFoycE9WMYXEfFZpyhhfb7vTQNjrZXGOV7ePUAHGfqthoXcuopqe02JlO2L0nR03 zNwRkgHI/Ur6fFZB00VunDnZe5wcMnH04U/x9ZZ3G/TX+RvGY2farLzgn3HC+ZcfKzl/O5fInlc3 Y+rhfaCZ0ZBaTx7L4IacFBspa+SRgbI9xA7crxF2XE+6+eSe6SGmZdwcFYkpIRWQeR9QsusB2RnP 3XyKflNj0ipcOSTlZGocRjJXlRnjug+pdyEdfK+WUE5P1TY+pefdLq+/7rAFLPKbH06vqsopHRnh xXxygd02PWaqQD85H1WMlU90eOSfuvN1cIz7d1E0y6znPlHWSFh5TV2r6teQBzgoEjs8nK+PZGSm 00+3XxgpmTA78L45OEJtX29UuJ5R6p8lfId0Jsfb1HY4KTnkhfIFGVBmHEeUw/nOeV80BB9mvOMZ Pv3R1nPJyvjlGfqrtNPR6xzznjtysHSEkk8r58hLJymzT6Nfg8Ep+oT75C+WcoyU2sj0Nndnlx/d MzE4OTlefPKM88counqE5DQDymZuBnK8oKMq7TT0mdxGCThBmJbgEg+68wz74RnCbNPWKl3HUScJ OmySS85+68wclnPKbNPa2rd0gdRIHlYOqHE85K83UcIz25UNPSKgjs4j6ZSdOXOBJ5H1Xnz+iRPP KD3GpkGOl3H1W0tOoKq38QzPYD3IPdc+Dn9ENeWjGVTTthrGvaMmsmI/5itdedRVVzjayoqJJA3t k5AXNl5IwSsc448Jse5lZLHyHn7ZWDqpznB4Ja4cry9RSyU2mmzFfLx85P6r5vqpDz1H914CcfdM vOO6bNNnHcZQzpc84+63ulNYV1gkmNFKWCXHWPfC40Oz9EwfHKbNJbZupeByagrXam3Cud7omU81 S4xNOcA9yo6EpHIPZYiUc48/VXZY3T7rPnPUSsHXWdzurJyPqtR6hQXk55V2mm7jvVQOHyH9146q rdM8u6jla5zvdIkkcHGE2SN1R3ippWFschA9srI3eYyiQSO6vfK0jSB5T6+UHTs1LVhv+/f1Dz1F ef8Ajc4nEjZHdYOerPK0JfgcJdXHuU2adeNXVwbzUSZ8YcVprjc5aqXrle5zj5K1XqcLEvP1KbTT q7Nqy4WyD0qeoexmc4DuF4LxdpblMZJpC9x75OVpA8EDI5QXnHsm106ey6puFppJKWlqHxQyZ6mg rxUt2npK9lVBI5srT1BwPOVoycjuU+vnglNqk+Lc67NYCap4djyVzmo9TVV6qPVqZXSv+pXLCTI5 QX88KxEhaV3BuVlpDTQTH0s56T4SrteV9XdWVrp3GZpyDlR914IPlHXg8ZBUNJjm3auVTTiKWYYO C764X1l3buUtZTTmT5oQcc8c91DAkGe+FkJOM54Q0mq97u3C4WiejLgGyt6DgnsoeqagyTOd9V5P WwTj9eUurOeUlNJZ263PrdNUX4Mu66fjpBP5V59yNwp9U/ISWxDu3PkKLusgDJPCfqlxxnhJNGm0 t93qaFznU8r2E98FfaG9VDa1lS2R4kaerqzyCtIXI6sHOVTSyGkt5GQ2qGK4sEs8fPUQCf59loa3 c41GrqCtlAdSU8vV6Z5GMEKEGTFpyCsvWJOc5IU1DSxept3WVEtKbfljIiHYzjkLZXDdCzV4s88k DH1lJMyX1COW4HIB+qrIagkDLj+6bah4/wAfCagtjcdw9KXZrP4jR09T0jA9RhOF8b/uPYjp+Gno hh0D2OhjaeG9PbuqsfjphwHH90zWykYLj+6agtdVa00pqO20n8cgjqHtZyHPIwSST2Xxv+vbFR2m 32y2OApGvY3o6uroaHZ8qrLa+Vn+M/YIfXyuOXPOQpqJpYjc3c+nEL6SyvAjIIDmjGB7cKBX3qU3 NlQXkyNeHgn3BytXNVPk7uJ/VfAvOePCuiLaaU1rZ9Y6aFLfnMErWhpLsE5z3GU9wNcWy1W42q1O jbHIOgtjAAa04zwOFVajuE1MCY3lo+6+tTc5Z3B8kpJz5UmLV7W1prlp3RmnXutNQx75GY9Q49R3 IIzjvg5Xk1eyxa50wbhJUx09bTt62SZ5PSB8p+hVWpLzUPiDDK5zfGSvpDfqqOAwtle1ju+DwpxN drcV01v1rpCGCK4Mo/yguLevGGge49kWWKi0ZourpZ7hFVxkvIkaOk/M0eD9lU6k1NWUrOiKZ7We wK+ldqmuqqUxOne6Mnt1Jjhxmol7u1gtjaSEVdyvbayH05i+mMB4LeQQ7P1XI/EJaZaa6fxATxSQ VRcWhrvmHPkKKrJqmvtTHMpZnxtcckA45Xy1BqKtvLmGsne8MGGhxzhXxzjbZ8pljMrLfhoJRg98 5918F9JHd18+o/RaafCfuvk4/wB24fRfSfnsvifyleeOleccYX0Pj6LAd1mfutMsc8ppA+yfcoBP +SEJoMhPJaUuyYBcfdUemJ5aAWnBC9zK6QNDeoj6ZW2290jUatvsFvpnCNrjmSQ/4WqctwLdpbRW k3WCjoKaSvqIS0zyxh0nIx1Z7oK+fjpAMNeQPPKGV80b/wDeED3zhWW0hoywXbbOSkt9BQuuElO5 v4mSIOcHkYzk8r57X7Z27Ttira/VdBS1E4zkzMDw1jT3APbKIry261AH++dj/mTdeJ/ExH2crR7d 6b0reqOqkjsVue0VD8OfTtcSC7jv2GF6rRY9H3OedjtO26Fscro2vNM0BxacHBRKqZLdKh4wZXEH wXLAVs0ZwHuaD7HCthRbY6VrtNzR/wAJpo31D5P79jPnaM8dJ8YWo272ks9sdcIr7QQ3CUSD0pZm 5HRnjA7Zx3VS3SsP4yWN/W2RwPvlfOqqpag5e8n65ypK0hbtPRblXJl6pIp6SOqlZDA/iMfMQMjz gLqt7Nr6KO0u1LpmOGmpoY+qogYOlnSPLR78q6suqT1tX49z3WJ+yZ7pFXSgfsgoPZNAuyChBSBh ZM4P2WITKDbWu6VNC7NPK9h92nuvZcr9XVsJjqZpXtI7E8LvNg9CW3VN3nffIzPTRMOIuotBOO5I XS7w6c0Jp2x19Fbba2G9BrTE/wBRxLTkHyfZTe2agMSFjupo8rcUuoayCIRQzytZ2wHYC0fc+Spa 0jspcrvpx94u9cyzwlvXFHLH1Fzcdz/lyg42h1NXUTCIZ3tB8NJGV5rleKq5FrquR7w0/L1HK6Xa rb2XWmojTzTejQU+TNIBy4A9h91M9/2W0tWWyvo7HE6lukTcslfK54BHPI+qkor5bNTV1ti9Klne 1nsDhfG73iruxY6rkc/o7dR7Lotp9vZta6hNNNJ6FBTnM7x3OP8ACFMuodlNM1dtrqWwCSkukPLZ JJXPHHOC36hIICtOp7jbYBFT1EjWD/CDheS8Xmquz2uq5HvLO3UcgLotqdv59b6gNNLIYKCnOZ5B 3OP8I/6qY9RbIaamtFwh0+6WmucA6mvllMgHSMkEfUDCsppA1o1XcrVB6NLPI2P/ACg9l8Lnf6y5 ubJVSSPc3t1OzhdBtRt/Ua3v3oyyGC3wHqqJB+Yj/K36n3Uual2Q09LZbizTsk8Nzp8ua6eUvb8o yQR9Qps0hO06wuVFEI4aiVrAPyh3C+9ZrW51DA2eZ7o/8pKlbSezFlodJtuesqmYzy9L/wDZ5Sxs QPYduSvRfNltP3HS9XV6VnqRVsHWx88pe0gckYx5C1tEVU+v7rHE1jamX0xwAHdljUa9u0jHMFXK GnuMqS9K7MWOk02y4avuD/xEoDg2nl6WxA9hnHJX2v8AsrY6rTFXXaVqql1VE0va6pl6mENGSOAP AU2Ist+u7lSMLI6mRrHHloOMrKfXV0dFI38S9kbxhwDjytHoixw3/UdHR19SaWke/wDvXjv0juB9 SpX3Z2psOlNGyXe0zVz5fUYGiaXqb0uPPj2WsZcrxjOVmPdR3ZtZV1tcXUszmE+xXl1HqquvD2mo mc/A4yey77azZx+oKF131NJLQ2xzcwsZxI//AIjnsEt09njYLc27aZlqa6gYzMzJT1yN/wCIYHYD uszLbWkZWO8z2usZVQvc2VvkcFdZV7j3eendH+KlLHDDgXdwuT0np66apu8VttEBlnkIycfLG3/M 4+ApT3T2kotFaLjukNdVT1zXxxyNcR6ZJ/MRxkLWMuV1GblMZuuMsmtK+1PcaSZzM9wCvFqbVlbe 3j8VM9+OwJ7LuNr9nZ9R0El11FPPbra4ZhDGgSP+pz2C+O620U2l6aK5WCWpuNsLMyF4DnsPv8o7 Y/ZZ21pH2nb1UWevbV07y17exHcLr6zdC8VUTopKp4Y4Fpx7LitK2C56ovENttEJlqJSPm/wsH+Z x8BStuFstHpbTlBV0twnqK+WaOCRjwPTLnDkjyMFWfRXM2rce6W6EQ087xCOwz2WV03EuNxb6M9R I6P2JUkR7BWmmtlLUXO/1kLpGNLy1rOkOI5AyP8AVa28bM6dioJnW7U9RJVhp9JsrGFrneAccpKa rkaDcu70UAhhqHCNvYZTm3NuksT4HVLhDJ+Yf/SV3rdgbXDb6Wet1FUxPfG0vxGzpDiOcZ8fqvPd 9haGGyVNfQ3+eT02OLC+JpaSB5x4/VWd+kvXtxlFubdKGEQw1DxEOwHhfC47m3SellpfxD/QmBDg Tyc9119x2NpqbRs14ZfZZZYqYyuDIWlheBkgc5xn6qA42zTzMZG1z3uIa1rRkknwEnrcX50k6w7l XW00cdJT1Dm00Y6WMHOAvBfNe3C61bZaiV7y3tkrudP7Cvl0/SVt+vRt1XN8zoBGHhjT2GSe/uvB rvZGrsdiZc7FXyXdocfVZ6QYWtx3GCc8ps08Vr3XutLTsgZOWxtGAF4NV7lXK8Uwp6iZxj8/N3XT 2PYepqLFTVt7vTbbVTcmARhwYPAz5K1e5GzFVpjTTbzbbibpBG4moHpBnpt/zDk5SX6Sxq6fc66U VibbmSlsLWdAAPACjm6V0tXOZZHl7nHJOVvm6D1LV6Wdf4bXK+1tBd1gjJA7np74XH5OQOylWJJ2 615XaZpnw0juiN7upw9yvruBuJcNUUgo6x+YGO6hycZXz2t20qdb01TUG5wW+GJwbH1t6zIfPGew Xp3b2rqNA2ugrZLmytbUyGNzRD6fTxkHucpO/S269ork4c72zwvfZKt9FcI5mOw5pyCFr88n2X1p o5JZ2Rwsc+Rzg1rGjJJPYLKp2tW8NypKSKASP6GjHK0mv9z7lfbe2kfIREO+OMrc2XYa9VVlp6uv ulHbqiYZFPNEXdI8cg9/0Wh3L2iu+kLBHdPxUVwpskTugjLREOME5PIJVRE8xDnud3CwaRx7IcD2 SaMD6I0mHbHcWp0paHU1PhrHHqODgkr1ar3NqtQ1tG6pdgUry+Mt7gkYUNNme1uGuKBK7rDiTn7q xmxYm270XCnp44Gv+Vox7L43XdupuFZTOkeA2BxcAPdQD+MeD3wPusvxbldxO046q3Wrby2FjpOk xngrbxbvTm2QUcgaIowCR3yRyP5qurah5cSSV9WVT85JPP1TpnSctV7rVd4ELfW6TE75ek8r21m7 dRPaYrecNiAGcfRRRobRt51jWTxWeEFkLHSSzSEhjcAkDOO5xwFzlRUSRvLX5D2kgg+DlWWF2sVB vTVQ0Ypw4YDekE8nC1d71y/W1FT6XqHMhoqh7WyS5BLGA5JH14UBirfk9TiV6KS4SQ1Ae1xDgOCD 2SXXcSzftYY7LaFeC7+0VyAPb54z/wDir1WrarSdiqf4hQ6lrBLC0lpkMZAOPoAoHZqSsbx6ryPf KVRqKsfF0iV/P1U1F2n6i3nnpYWQSta50Q6ergk4Wh1Nu1U3OsgPqdDIuwB7/dRTpTTl71dNVC00 5kbTxuklleeljekE4z78dly76mQTc9x7+E6JbbpZ2m3rLaeKKSJrywYBIB/quF3T3OqNTUbaPJbD n5gDwecj+ah78dLzlw+y+Ek7pHfMVNtaqeNsdzH6dtbaZ2Hxtb0hp8LZ6k3ZnudxpXR4ibDxgH83 KrxFVPbgA8Dysn1j+vq8/dE1VpW70AwNhkiBcG9PV3K02p9cP1vBbtP09N6tQaiMxu7uyD3z9u6r sK+R5yXEfUFb7SeoKizXqCvgeRJHkNJ8ZGE/6X/td/UtTV2nTEE1PSCqdBGPVZgHpaBycKt+7u5L 9Q0raVg6IWgAtHbjlfG+bu3Sot74BP8A7xvS7nuCFDVwqnTyFziTk5Vx1jjpmy3K10dl1VVWtkog lLA/6r62vVM8N4ZVmQiTPLieVxvqFwSjcfUOOE2ti2Fg3hhjtkMVUxsrmDPU7kgrkqrceOv1zS3C vInp6d5c2N3LQfHH0Ub6d0Vqu+2tldaLRU1NG5xY2RuBkjv3K5e4Mq7dXT09VG6GohcWSMeMFrh3 CvSdrHag3a/F3SmNM8RRRYAa3sOe65reLcGi1PZaSCOJn4uCQPbKB82MYIz7YUHGrkJDg45CxnrH z8HOfdToTXsdrCi07UVs9ZGySolw1jnclrR7Lu9T7n0NVdKGppIo46qB/wDvgB1dJ4Iz7Kuuk7Le r3JM2yUM9Y+EAyekPy5OAijpbtcLy23UlLUTV5c5op2t+fqHcY+mEmj2s9U7nWGtmifW2+mnmZjE j4wSMfVa257qUkup6SokA/C0rHFkeeOrBGf5qE/7E62ByNOXTHuIlptQWi/WRkc14ttbRMlJax08 ZaHHGcAqzUO3a7m7g1F9rJOiQiPs1oPAC5LRuoprPfI6pryHHg8+Fp7PZrtfpJhaaGorXQgGT0m5 6Qe2V5Ljbq+1V5pbjSzUtU3B9OVpa7nsm99JrS3Fr3Ytb6OmfWxMkqYR1NkcMlpIwce3C4iXXtFe NdwVV6aypoIMlsD+Wl3+EkfTKieLTerPRHTYrqWEZDm07iCPutBcG1trrnQ10E9NUtGTHK0tdg+c FTf0vfys5dt1o5b3TOo3enTRcNHt7n9lxe8l909qqstMsVPGyqbO01EwHL488tKg03GbrDus/TlE tbNLI1xccjyqlne6t7pXXek7LRPjs9FDSRP5c2PgE4UVbq1WlLpdLS+10kdNKKkSVb2cGRhPIKjW 2xXyejE1HQXCemIP97FTvewgd+QMLSVNbLJL1uJKkvH01e+1qdP6k0FZqwV9ptlNTVTWHD2cEZGF zbtzDJr2CufIHMjyxueQ0Hgn74VfYrrM0EdWOPJXxjrZvXDw89RPGFZlpL2tpUX3Qdbf2Xaot0Lr jlrvXzh2R2Jx5Udb/wCtKfULoqanIMURy33B8qK4zdi4tFHWEt7gQPJH8lp7nPNNO5swcHtOCwgg g+2PdTG8e4ZTlrfw1dR/vHc8ZyvljC95oKsSFn4Wfr8t9M5H8l5JYnMe5jwWvBwQRggrDo+YT7L6 QwSSjEbHvI79LSf6LF7Cx5a8EOHcEYITasOyPCzaxzuWDP6ZWJBDiHDBHcJtSQjCEAhCEAgIQmwI QUvKgaEjlACB5/dCEIDwgIPZAQGU0sIQNHhJGEAEzwkhA0IwhAvKfZHZCARlHZH1QCP1QEd0Dyll HlNBisgkgIGjOClyhFNHhAQeyACZSCB3QPwknj3SzlUNGc/dIoQNCXdHlAwcHKCUkeUDRnKEsIgT HKSMIGUs9ghCB+PugJZSHugyz7JrFPwqBAPKEBWAJ5R5QkiGDlNYj6IQCY/dJHlA8oSSBQZZwEke EIAoQkO6B5578pkrEhMfdUZIySl90lBkCmSsM4R7oMzx+qxz9Vj5T8qh4GU+AsQcFJx5TY+hOfJS Ljj3SHZBVBlZAgDjn6L5numFBnlMHhYIHCozL8Hsce6C7A4WCETTP1HY5S6uc8lYoz+yKzLj4ISJ ylkFIlBmCffCM5CwJyfdCD6lxPKxLiTjKQKWcfdBmCc/mJKfWW8L4FxJAys+rICD69fGQsMnJJJW OfZIqBl3slhCMFUeef8AMOF8nD+7JX2n4evi8/IV546V8R3CbuDhYt4fys3d1pli38yZSHdNUNIp oKAxwF9GDkALALNhQTn8NMYOpXPIxhiXxHSka/gaMj/Yo/6lcfthqp2nLpHK3AjccOUv7o1Wl9U6 UbWyzgXONuYXRAZLjxhx9khXp+HR1ymoZi/At7Dxnu4rsN4jcP7EVb7bIxkTGudUZP5mdsD65Wis +pLLpnbVrLZPEKtsOAG9y/6r2aJ1bbLvpiaO+TxPDuHROweoZz2RK+mwR6tKyPPJc8f1Wk3O1FDP RWi36fz+PbWPLoacZIHY8D6rqNvKmx2CxGGK4RFz5HPIPAaM8DH2S05Q6S0/W1tfBWNnrKlznmSU hzm5JJDfYcpiX23MNwFr2+ZXOyPRhMjvB7jK3FluVPdaKOqpnAsIBdhR/rK/21m11fSx1cb55InR ta05OS4FfLZzUFvpdIPNZVRte12S0u5V9MZTfSul0kcNaXBzSQ78bJ/51ZnXIxsfcA7zREH9SFCO g7Db9Qa+rKi7VjIKBk75cE8yHqJA+y7nfDXtHHY5NOWbBikYGPcDx0reV5ZbJNY6VqkBDiPZYZX0 kPzEr54StGkUI+igAeEIQkDACzaPy4APKwAX0j/MMJRZL4Xmf3tcfp/ouA+IKRztyrizOWtZGMf9 1d/8M1RDTx1Znlazq4+Y48LXb96OhEtz1Uy7wvcXRtbSBmS4EgZ6s+O/ZXxaky38uectyxsfL4f9 t6K4vbf706Of0z1U9J3yR/id/oF7d79dVktZJYqeN9JFH+dvYuHj9Fxu1eupbBWRwvkzTk4wTwFM 24Vgs2v9LfxCOohpa+nYZIp3Y9slp98rLVjx/DhR0EFnmkic59fKep5zw0Y7BajebVv9ndRuZZZX sq5A5tSS7I7DHC23w522Sgss9bXTxR+sS1sZdyB2yo1+Ie2mi1l+OZVRTx14Lg1h5jxgYK145NW1 jPe5pJ/w60lvhtdVPDIZK6cmST2aCOy028erRprUj2WSaRtXMXiqyeM4GMLbfDnbnUdgkrqiaJrJ 8hjC7nGO5UafELbX0Wtn1wqYZoq/MjWsOTH04BBUx13tu7uU16Sh8OdFQQWmeohkL62oy9/s0e33 Wn3i1b/ZnUL47LPIKmoD21YJyBxgY/QrafDhb5KPT8ldVSxsbO49DC7npxwVGfxD0ElHrh1X68Us VdmRgjdksxxgrMaySt8PFBQU1knmgldJWTEvkHhoxwFrtxtVN09rMw2maWSWpc4VURPAPAwPuCvb 8OdumpNNyVtVJG1s5PQwu56ccFcFuvQSW7dVtVPNC+nr5mzxljs9IBAIKnxT5icLtTUVfoaODURN PRvbGT6T8EeQM47rK2w01t0RVx2BzpqdkTyHVD8nHSc8gey8OrLc/V+iIqO0VUEUmYyHyOIb8vfs vTa6X+z2hZaC5VED53RuiDo3ZDi4YHdbxk4y3253e6hLbmyXzXlcGTzzxWSF2ZZjwDj/AAt+v9FI O42sqHTVn/s7ptodP0ej8pzjxz7krspbXU0miae3aYdSUs3pNblx6WjI+Y8eVwdu2lhgpZbpqG5u nuUTnSgQPBi45AORklZakLbjbq1aRsjbxqSOOpuM4BbG4BzI+rlrQD59yum3hYyo0ZQNdGBHJUQD oxwAT2Wwv9C7VGlLdFa5Y+pkkL3FzsDDe6NwKI3PSbRTSRn8DIyWTLsAiPJIC7eGzHKZVy8uNyx1 9V6dT281Wl7dQwzPpmyOha57DghoyThY0VD06HulG175Wt9eFj5DklvTxk/qvPJNBrfR7Ke31bqa oa0GNzSOHAcZ+i8+ob3R6I0V+Dq6pk9aYiHEHPU8twSP1Xnwx42a+HXLuVloDRtJo7TEcdjgjfX1 DA6WokIBJI9/Yey++6FmmvWlqeB/pl0Ukcs3U7g9PcD3ULaF1dfL5qGkt1PM54c/BycBrR3JU6bi x1J0tE6nkZ/szmyzfOBljR8wXaZay2zlOUGqqGSq01aqKlndTNlfE1z2dwwNyQF8/wAA52gLlRGR 8pZ60DZH8kjGAT+6+VYW610fFHaKs09TGGujLT2IGADyvNqO70ui9D/ga6pE1c6I9R8l5HJ/dcsJ ZlL9N5/tjotv9E0miNMxR2amZNcZ2h0tQ8gEkj+g9l7dzrZVXPTdAI2sdJTTxzy/NgAAc4UNaH1p fb3qCktlNK6XqcBj2b5J+imPdmnuk+jo4rSR6zHAykuAAbjBJXTlZltjKbmj1bHatT6dp6H+MNpA 3pd6keHEEDtglRhq/bmqsVjF70/dqivEBL5fV6WtDAMkjC9F12vujbLRVOnbo+5Tyn++jeRGxoIH LTn3Xe3iB1n2iqaG6PZFUmlewguByS33WMZvKT4rWV1jb8oEtGotRa2uNPaaR8s73YwASGsb7uPg KddWVlPpTbw2erqGvrJICzIPkt7/ALrlvhgtkNJYq+o6GiollAc/yQOw+yinc6/1VdrO4QVEpc2C pdEBnwCty8crfpnKb/WrJ6VbB/2ZUwrwHwGLEoPkEAFQ9urtpT2aOn1Zo+JsdJAA6eBnZnT/AIxk /XlS5bKWev2gbS0jS+ompulgB5yQF8bvb5afaKW1XBzY6yeAwgPPdxAWPHNSS33W/Jd22RFuiXXb cK3zfxO+soaaFwbHkdTnkd+MqWtQ/wDoDa+ojhkdViKFwNQBjGAOT+qh+p2jvljt9vqdPXB1zklP 99FGwRCPgHIJPzDOVMVypXx7YC2XMenU1Mfolh7knGVrLq9JO52h/Rsupdxrgym/EyMt1M4etPjh o9h7ldpu7qe2WDScmm6VwldJGY5Oo5OCOc/VdReLdWaY0XTW/Rlt9V5HzNYQHctB6snucqFda7ZX waPrtTXauDa6JplkonNyQ3I/xZ7/AKIfxv8AZzXkMdLFZ7iQacARsz2A9ly+/O1MdtZJqfTcYNtf l1VAwcRf8Y+hJ5C9mxG3dRcS3UF8zBamfNDGTgy48n2AWy313CpqiglsFrI/C9PRIW9nfRPaVGWz 9fPHqe3Uscr2xulAc0HghTN8V7WnSNrafE//AOKol2QsFzumqoK2go5ZaOkkHqygfK0nx9VLXxWg jS9qBBA9c/0Wv8f/AOS79acv8j/XHX2qWRgn7rpNu6qGg1VQ1lQ0OZDIHkH3C5x3Ejse66HQdr/j GpqGhMnpMmla17/Zvk/ssV6FyLoKbX2kohb61lLXRkOieXEAE4yCByeFxO7t+qrHoOfTV1pARUQG FlS0Hok7cgnyvZqjRtZpiK1T6KgrqsF7vWAeXgNwMH2HK3G8FKK3Zitfc42trhAHt6wOprwQeFGL VKJR0uIHhYhfSb8xXyzgKtjnKeSgA59kH6oD7rYWK1VV6u1Nb6FodUVDwxvUcAZ8n6Lwf0XT7fRV k2qKGG3cVMkga05wBnyfognyLYbS9qtEEmoLlcPxHQPWljeBH1H2OOBn3Wj1jsfbaBlurrPdJzan yNbVOncHODCRywgDP7Ka4H3Cit0Fr1JbRcYZAMyQsMjAAfPCj3fGy1dotAu1sqXi0FzfVpnuI9Mu IALR7fTwptn5SRttpmy6d03U0tglklpHFz3SSEFxJHuAPCq9vRo+z2S50j9P18tSapzzMyUtPQ7O RjAHHKsdszK6bbbIJdI5j3Y7k8FRNR7WXibUFuuV+ZD/AAyWdr3x9ZMmC7gEeAtT/XbN96erTWxu mrjZ6CWe7XP8VLE10nphpb1Ec4+XgfuuE1btTJp/cKgss9YWWqtf1R1LsFwjB+bI7ZVprxWz2rUd ltdtp8UMkZDnMZlsbWk+fHCjX4j4JDqDT88MbnAf3Yc0Z5c7hWTq7+kl3ljJ96aeT4eKB1zgdT3i r/hDoDI+R4aX9WeMYAGMLQau2N/hdbbprdc3us0xaJ56jHVGCe4AAzwpr3ImqqHbWCSlEglY2LrD Qcho75+ihvVu6cl108y0dAawBo6vPB4Uwlvjmd+VtnO4/SbdAaTtOntHz2y1VRnpH+oXVBAJJcDk /oFVbejRlu0nc6Q2e4OrqeoY50nUACx+e3HjCs1tfI+baYuBLpXRSuHk9iq27jaM1Hb7Q293Sn/2 GTpIf6mXN6u2R4V8ffjt/rHry3GIvJW70XYXal1JR2z8Q2mjmf8A3kzhnoaOSceStHzzkLcaYqJq a6QyU/UJeoBvT3J9lmuyTtwNkbnYKug/gEkt1o6vpj9UtDSyQnyB4x5X11hshV2K0211JXtrLvUv Yx1IG4wXcEg+wKsroBtS3SNu/jXy1cp6gJO4yOFHsrbo3fGkp7ox4pnOfJTk8tLcHGD78dlrCblr Fy1lJpxbfh4hhpqf8fqVtNVPjDpI/wAOCGnyBzzytHqPZC4WfUNopae5NmtVcQ11e6Pp9J3JILc8 8DjlWA3K1pHpa6U0EtMyVk0XU3qaDz1EY5/RcbuPqK8VVptX421upKKaoiMUwI/MeQPpwszbV04q q+H6siunpSaghZbTC1zKt9Py6Qk5b0dXbGDnK4Pdja246BNNM6q/H26cACpbF6fS85+UtyfHnKsv vFNJTaSshhcWvdVQtJH1C1/xCwQv29toqGB0YqYiR7jCt6kqSy7V22p2wrdeOrTHVCihpmtPW+Iu 6yT2HIXq0Nt9HWbrjTl3LpKenme2QgdHqtb2/Qqyu0+pbdd7ZJHTwU9HDTtbGA1obnH/ALy8FDqe 33PceChjgp4vwkr3mZjQC7jHJHdc8uWum8db79PfqC8TacuFLarRbyaCigZLIIm4DGk9Iz9Fyu9+ 2tHqmos1db/QobjVSNilqC35CzpJy4Duc+V0+uKitoNTCGmoHVDLrCymbIOwIJJ/kV5t8K023S1p 9N/TPHUR/KPzY6cf1XbLXWnDC3XaumstodRadvVFQQsNybWACKaFnS0u5yOSew5X11rtHcNJUFrq a6408oq5mxSRsYWuiz5OTyFbbR5lrNO2ua7RdFYfmAkHIOB2/RVh3xu10OqZqO6B8fpu6omuGA5m T0kfRZxm5tu3V0sPtNa9PWnTgodOMaWsaHSy4y57jjknzyod2loY3b8XCXpBLZJ3A+3K7P4YpnVG nbo9xJIkDefsozsN2rrVulcDaaeSprppZWxxRjLiM5OP0Cvh/fw57Z8l4ebH/pM24V51Lar2GWS2 1dVSGJpJijJAdznlQPvDq27XuOCz3yjlppInNmbFLH0uyeAR91Jo3Jvsd9gt1wp56SeSRjTHI0td hxwDz47qQtTaWtd01npyrraSKaaN0rsuaDnDOM/Y8rEy+GpNacF8Omkr5p+lbVVscVNSVxLnROOJ SAPlyPbytVuGbPQ73w3C800dRBBTDEbxlvVzgkfTKk+O61D92YrT1YpYKYyNb9S1RTupp6u1VvCy 121zY5JImh0j+zGgZcfvhdvHjxmfL6cPJlvLDTsrRrq5an1NFQachP4cYMr3E9Mbfcn+i4z4qaG2 SRUNRA2IXNkmJXNA6i0t4yfuu6rKuzbX2A2uzjruD25kkd+dxPk+6r/rVt/v96hhkoKx9RVvLYWu icA89zj7DuphOM5VvK8rqI7tluq7ncYqOggknqpnYZGwZJ+v2U82fYeNt007Bc6yQyTh762JuCB0 jIDTjsey7fQGirVtbZTeLw9st7lZznBDD7N/dPbXVMupdznSzyD044H9Lc8DwprWNrpLLlp09Tfq DTN1prBQ0TmUtMGxObG35WB5AaD7DJUTbvbOvn1jSjSUTIn3Ivc6BzumNjmjJIPjPt7qSdU3GCn1 NcLW6CV9ZcamAxlreOlhac/yKx3xustlrbDWQEgtkcCR7d1nx9+S431o8nWONlVUvGjL7atTNsVV QyG4ucGRtYCWyZ8tPkDyfCkbRugX6I1dRVmvqOI0hY50DWydbTICME/burN2qlgulLabxWUzDcGU 5cx5b8zOoHI/oq7agnvm4WuBaKUD1WOd1Bxw2JoPzOx9v3TGbm0t1dJTt+u59Qanbb7BStnj6gXv cAAxvnJ+y+t+0Fpy8bpUFdLTMfUtjfLUNbwHOaPkLh7hYVE1m2u08aK2hslxcP7yQ8ue/H5iPfCi Ki19WUWrDWTvkaXcEOyCRlSRrf2mG/6xkodcGxso43tMzI2uLM/K7GT28c/sou+KTSNvortQXShh EVRVh3r9PAeQeDj3XeWbdJt6vVJStpYnSSyNb1OYCRk4yF2es9O0OoNY2aC5RerBBFJOG5wC4HIz +qsn2vd9I/8Ah105XWmyehdLUI6erzVCaRoOcjDR7jsoa+IG1w0+5d1fTMDGvc1xDRgZwFaO132S r3Fr7RgNhooj0hvAIIC4A6YoNTb63Ztzi9aGlj9VrM8F47Z+yzbMcbtLbcpr0+Xw5afrLfp8093s 4bTVmatk8zGuDgRgD3HZQtv9baei3KvBpY2xxyPDixowAcDOFa20X01m4Fws8bGxwUEJAa0YBzjH 9VWT4h2tdr+6HH+Mf0C34sNzLfwmees8Z9ohIx3Qeyzk7gBYHhYdSQEeEwoBCaMKhYQmUlAIQhAI yhCAHdGUD6oQJCaMeyBfyWQS8p5QGEgmjugSf80JIGe6EH6IQCPCEIAIQEeMBAf1QU/CAMoBIpoQ MdkiPZCEUY5QEBCA8o8oRjIQGUI+6aoEJJoF2JTCEIEn2QjwgEihMIMU0d0e6IRTRjlPsgSAmEiE B5R4R2RnhUCEvKfhUGUJJ91NoPKEkDtyqH9kkICBlL79k0sIGgfdCOyA5S5T7o7eECHsmUJIHlLu hCAQhNAJJpeUAMoKEygP9UeEDujP81QEJDthNAUAjyhBCoMozwkgoGEeEgg/ZAwhCPKoPsnkpfZN AsITwg8DlAhyEY9kdk00BJMdkJoLOUYR2KfCaHwnAJwV8Xf7sr6zn+8H2XyecsP1Xnjo+A5cFm7v yscYPCyOFpliE0kwqGhJZEcd0B2TCxHdZAZKg9UDnNaDkZXvZWy+n0dZJ+pW9230VVaxvMdHA70o B80sp/wt84+qlzc60aS01p6PT9ut9M64vaAalzAZGjOerq75Kogltwk6SwyH7ZX1p7jNEfkeR+uF Yk7eWC7bXPisNvpX3EwDpqS35+vOT83dPb7bax2TRc9fqu3QS1Lh1OdOOoxjsAPZEqvzLzVNPyyu H6rM3uvwOmd4/wC8rMaE0Po266cbO2w0kjYy4OfIzLnHnPOfovpadIaEvdFNJBp6iiIa7pywgnGe Qcq7RV6S61L2lj5Xlp5ILuF847lURAhkj2g98EjKs2dotN1+jI4KaiZBWyRdQqRkvBycdyvDt7tF ZILDWN1BQR1lwa5wMkhPyjBx088KorY24zQydUMj2O9wcLz1dbNUuL5XFzj3LjklSLtJZNOVeop4 9SQipblzIonnDBzjJ91td7dsIrBEb9p9jWWp2BLCDxETgAt5yQVVQy7lYp85SygCcFB7I7pkZUGK YSI5TCB+Fk04P2WHYrNozwqN5Z75WW4f7LM+Mnw0r73XUNfcYeisqZJGd+kk4Ug7Fbc2zVstXU3w SSwRjpZE13Tk+SSOV694tKaJ05ZayGyxTsvEUrGgOmLgBn5uD9EL0hhkxZI1zTj3W9ptU17KY04q JBERgtyubDXF+Rz4xjupTs2zV6qtKTXy41NPbY2xOljhnB6ngDIz7ZSMudtur7lQNLKapkaw/wCE Hhay9XususzX1j3Pc38pd4XU7Q7cz62vH+0yGC2Q8yub+Z//AAj2+6k/WGylgFguM2m5Joq6jDnk zzF4wwZIx9QFBDNr1lc7ZTtgp6mRsbRgAHGF4L3e6q7SNmrJHSOZkN6jnuuo2i27n1xdeqZxp7ZD 80r2n5nf8I/6qSNZ7KWWLT1yqNOVFQ2spGue5tRL1tw0EuHAHOEgiOx61udupmwU1VIyNowGg9lr L5fKq61AnrpXyObwOo9l0m0m3NTri7j1XmC2Q4dNIOHO/wCFv1+qkbXGyVpg09XVemqupNVRh8j2 VMoc0taCXAYGQVRFVm1vdbVTCGmqXtjA4GV4b3qGrutQyepkfJK3s5xzhb7aLbmp1zdcyPMFrhIM sgPzO/4W/wDVSJrbY+3xWOpqdK1lRJV07nF0dVIC1wb3AwMgrOxG1o19daKARMqXtY3sMrOt1/dK rAmqHkA5AJ4ypI0/sfaKTTVLW6sudXBVTYc4U7mhjMjIbyO/1Xy1bsjRRadkuOlK6rqpmZcW1Mje lzQOQMAcqypY4iHcq7sYG/in4H1XzqtxrtK0xuqXOY4YcPKkKxbH2iDT1NV6qu9TT1ko6nNp3t6G g9hyO/1Xh13stR0Ol5rtpevqakwB0kjal7S1zAMnGB3TZ24qh3FutFH6MNS5sftzwnV7g3aopJYH VTzFKCHNLjg5Wh2807FqfUsFFW1ZpKQjqkkAycew+qkPeDau36J01SXO3V9ZUGWoETmzBuOkjORg KmnI2HXVxs7XtppnNafGVrNTarrr3L11UrnkdsnK7/bjZma/2h111HUzW2jlH+ztYB1uH+Yg+D4W o3b2rqdGsirbZLNXWh7QDK8DrY/zkDwps1XHaZ1FVWO4Cpo3lsuME+4XXXLc67V9M+nkqHFkjS13 Pgri9I6bueqbxFbrVCZJ3/mcfysb/mcfAUh7s7VQaD0xb7lFcZ6maWf0ZmvYA0fLnLcc902NHYdf XGzNLaOpLWH/AArVap1fXX2o6quZz+MDJ4XbbdbM1Wo7M+7X6rltdHIB6Aa0F7x/mIPj2Wp3S2pr 9IVNLLbnTXO3VOGMl6AHCQ/4SBnjtgq7XTmdLaiqrDX/AIujkLX4wcHuF2Fx3Vu1dTvhlnPQ4YIB XSWTYQfwKmq9QXt1vrpuTCxjXNYDyBk9z7rW7hbMSac02bxZ7k+4wxZdUCSMM6WDHIwTlE01dp3T utBTsgjqXek3sO+FrtWbiXS+QehVTOdEDkD3W6262br9TWmS6XarNro3YEGY+pz/AKkHsFpd1ttK 7Q08EomdW2yYAMqvTDSHeQ4AnHjBU2aGm9w7jYLeYKGQsa4klclc7o+tuclXJl0sj/Ucfc+6kTb3 Ze5ansz7pcqwWulfj0A+Pqc8eSRxgLQ7n7b3DQlVCZJTWW6cAR1XR0/N5aQCcfQq7HRWXdm60FDF Ttm6Y2DAGeF5tSbm3C8NjZPO4sYcgZ8rRbZ7eXTXdc+Kld+Hoof97VOblrT4AHkrx7gaPn0pq7+A xzG4TujjcxzIuguc7PAGSk+58FurJXbW3du7UdLHTslcY28AE8LC5bo3K4zQvllP9yeprcnAK2lp 2DuM1npqq6Xmmt1VIMmnfCXho8DqDhk/otFuPtFctI2Bl2hrWXOkBP4h0cPQIm8Yd+Y5GSrKum7b vRdg0N9UEAY+UrVai3Yul1oZKGoeTTyjpc3PcKOdJ2C4ahvMdss9OZqmU9s8Nb5cT4AXW7qba1eg aS2z1dwiqjVuc0tjjLQwgA9yeU9+kt17bA7p3SDT7bVE/pp2s6GgHGAo0uFfLVzufI4uJOSSVtZd Iaibp7+OS2qpbasBwnLeMHjOO+FzLgcKbXSVdutxq7Stv/CU3EDndRwe5K825O4dbqumZBVkGGJ3 U0fVPbPa256ztU1dHXUtDA1/REJgSZfc4HYLx7p7c12goqGStrKepFU5zR6LSA3H3Vx3bqJlZNbR 278xPutrpyufb7hHURHEjDkFan3+6+9JHLPPHDAx0ksjg1rGjJcT2ACjafbXvRdKeljhJGGDGcrm dxtzbhqKiFLNIWw+RnutnadhtTVNvgqaiuttI6VocYZurqb9Dx3XL7k7YX7RlBFW1zoKujeSHzU3 UWxnPHVkDujCOpXBzyfdbTSNrgvGoaKjraj8NSSSD1pfLW+cfVacnn6L70c3oTdeSPsjW1mWbU7a Ob1Nudfgjj/aBx/JIbRbbnn+LXD7fiG/9FAEd8nYwdMr+PqsxqCfH+/dn/mKJtPrdoNuyc/xi4f/ AIZv/Remi230PZHvrqG+1rJ4mksLpGkZx27KvrdQ1Jx/fOP/AHl7rRUXW/XKmtlA50lRUPDGtc7A H1J8AKU3U10W81ZSwMp3ta4xjp6ie+FxO5e5lVqimbSSOxCOS0H8y1mtts9SaTtElzu34N9M1zWk wylx+Y4HcBRlI/qfnJB+6fG2Zdpp263MqNO0noNIezGGgnstlqPdisutdATN6bYz2HY/dRfoPSF6 1pXTUljjic+BvW98snQ0DxytVqG31dhvVXbLkGtq6SQxyBjsjP0PsrNF2sJFvZMKVtOGtLg3o6jy cYwvNWbufjW0tNUwRyRU72vHVyQ5vLSq6/intPUCcr36fpK293enobfGZauocGRtzjn6k9lbpJtY e/71Oktc8BiYTLGWHqGRgjBVcKqqBn+V3y54XY63281PpW2CvvVLE2m6xH1xyh/JUeudkqfDSe9s tzn6dtbaWYdcYaAAT2/RfXVeqJtzrvRWITso6OZ4EryOGtHOce6gaKqcxvSXEey9VBcpaacSslIc OxB5QTy/4frI7/d6ukz7mBp/ln/VbPTu0Vo0lcI703UDK2SjBkZHLCGtLgOPP+qhQasrxjNQ/wCm CsavVVfJF6bqmQtdwR1HBVkTaYr/ALtS11bBJGTCyLjpHC9F73dbcm0cYjayWneHtl/xZxjv9lBl qs13vlPcKy3UklRDQxmWoeOA1o/qfoFo3Vj+vqycYVmk7Wsj3opnxxslgY9zW4JIyuJ3C3J/tDWU MWAylhlY8szwSD3UG/xCUH6/TK+b6kukBc5xd37p0drF633MpL/b7fQ9AAgmZLn/AJV4d2ty6fUO mobbGwBzHNfkeMKA31kjntPURj2Xznq3yk98/VNxZ06uy6rq7ZDNHTzOja45IBX1smqaimvLa1sh 9Tq5Oe65232e43S33CtoaSWemoWCWpkaOI257laxr8O+UnlTcNLb2feGjjoKdtYxks0Q6g93JB+n suLduJTXDXcNxurW1FPASY4n8tB8HH0UFNuEojA6sgcZWDKqQPLs8q9JdrM3vdv8TeKWSld0QRYA aPHuf2XM7u6ysur22qI0zBLBO18koADizs5ufZRlZ9K6lu9IyuttpramleSGyxs+U478rna2aZk5 ZIHMkY7pe13BBHcH6rO4s2tnp7c/T9voi23UNPSsIw4RMDc4HnC5q+bgWVl8t9ZZqGnpauCRz3zx xtDnBww4E/ZV1iuc0YIDj0kLE1UkszS1x6sgADuforJJEva1024elK+sjqay10stU3GJpI2l4xyO e68F53Wjm1LSy0zgyGIANGe2eD+4UEs0zqvgiw3UgjIIp3EfutFcvxturXU9bDNT1DMExytLXDP0 Uki9rVVW5dhfWGsgp447k4BhqAPm6Qe3+i88u4Wnn6tpLtHA1tVFG5sko7v6hjB+yrHb5q+vqGQU kc1TUOyWxxNLnHHJ4C+dbUVtBWPhqopYKhv5o5AWuH6Fa60nytPc9a6MuNcKm4W2kqKnIIke0F3H ZY3LcmxPvtBW+mC6jY8sJxnLhghVU/ikzj+fJ+pWMtymkdnqIGE6O52kvcvcCe9Vjz6p9MZDRnsF zu3+qpbNfG1TXkdQw457jOVzDbXda+ETwW+uniIyJI4HuaR75AwtV1vjka5pwly2kxXQpdyLBO2j rq6Nj7hTscGSeWlwwVwsOsbbftdNqdRH16GmBdFEThpf4JCr827Ssb09RH6r4suMrJOvqyT35WZp tbCs3Whk1HD+Ge0UTflHPg91nBqjSlPrv+N0cbY6mSndHUOBA689j9wFVH+KTmUOa/AH1X0jvNQ2 X8x585V6RbG8XfQt0ura+4QerUhwcHGQjkcjgHC4jee72LVF806I3BscMnTO8d/TJyRlQiLnVOwW h5OOoYae3utdWXWZ8oc52T7qzQtVp2q2+09WuuNophHUtYWt6nF3f7la607mCXXElRO8GN7fTbns 0ecKtLLzKxvS13BHuvnFdJo6gStk+YfVTo7XDk1LpqivdRd6CQtuVWWtlL3ZaWg88eOFrZ9T2K3a +F2tsmZq2L06kOPA+bOR+nCq27UNQXB3qYePYr4m+T/iPU6/mJ91LJV7W+/jumaHUFReLfM78fVl rZQ5wLS3PP24UI/EWbRWXuO42mYulnb/AH7Cc/N4I/RRr/aCoa4OD/5rW3avkrHh0jy7PfnKsvHe vk47st+GseOSfqvmVkTn7JEcLm6EmkE0DKEk8qgSQl9FA0IQEBjhCfhHhAseUJoQJNBQgSaD9EIE gJkJBAJhLymEBwjGUBMdkCR5TKR7IDKEBCAHlMJZQEGXYJJZT8oDKB2R3KEUd00h9UIBGUcJIGU0 h9UeUDHCCjKFQAI8oQUAUJIQCflLKYP7oAoxn9EZQEQAIwjwhAAYKEA8pZ4QBQgozygSO6ChUPwh I900ShGEso7lAeEeyfdCoaSD2SP0QZJd0hnCeEB2QhAQCSMlAQBQjgoQBRlCEB7oxwl7+E88AIDK aSED7JFPv9EYQGOEZQkeEDKR74PKXhNAFCPuhAJoHKPKoE0ifolk9yqGmFj3TCDIJFGeViqAfsn2 PCPKf7oBBS4HPuj7oET4ynj7fugLJB5qgZevlJ+XhfWbPWvnJ/u15o6POD8yyzysWjCyPdaZGUIa ME5QqBPsEuyYQMH2X0aOV8wOV9WHBClFhfhkjH46rcB/7M/0XNb8TvbuTWtBPSIosD9F4toNYN03 c2tkIEMpw4+ykTeOj01fbbTXeOpa25hzWgREH1GkjId9gkvSX26H4fprjPp95mja2hacMPlxWx3y muMekC6iLG0II/E88kEgNx+q+E2pLTpbbyNlmni9YRtAa05JJ7r22i+WvUWhZYrxNA/rYQYycngc fzSD07NY/sGHO5GSXfbByuP3F1HE6q07S6dk+UCQTRQcgNyO+P1XbaA/htm0fBQ/xKF8jmEvdkYB IPA/deLTVg01pahrZYKyOprZmPHrSEdQBB+VvsFR0tZc2WfSFLWHhjGxg/YlbKKrhq7bLU0rgY3R udke+Co63Nu9G3ao00NSx1QWxNAac8g5K9e3l5o4NvHuqqpgeGOJBdz2K1IzVY7FK9mpISwkf3/O P+ZWS3sGdmKnq79EP/mUP7OaWpL1qN1XdKuOGipnF/QXYdI7OcfQLrt+deUdXa5NPWwtdAMB7hz2 PCvyfCub+CfukDzwh55PnlIcIplLt3R3CeMjlQLuhACOwQAPOFmzl7fbKwHdfRmOpue2UFpfhjZi 01h9yf8ARRBvdK+Xce+syS0T9OP0Uw/DS6OOyVTpJGt6nHGTj2XDb7aOnt9zuGpTcaSWGrqhinbn raHefZXFMm42E2xpZY49SX4Nnc35qakHOP8Aid9fYL47z7gVFwrJ7PSh9PBC4sewjBOPdazaHcB9 mmZS1EmackDBPZd3vDo23ansb9SWqaGmroIjI/Jw2ZoGSOPKhY3Pw+26hpNMF9NKZayXLpT2aM9g Fx+7Gr3af1NXUFomeWVUbhVdZyA9xIIH0wuv+Hy3zUWkhVVb2MFQS5jC7kN4xlQpvrQTW/cGtdNN FK2sP4mP0znoaSR0n6q4pU4bAW2iodM9VLMZKqUl8uPytBxgBcZurrA2HUFwoLTO97KtjxUBxyGv dkED6YXZfD9baih0kKmrLWfiDljS7nHhQfvfb5rZuBW+rJG9tW41MfpnOGk9j9eEx1JUstsTl8P1 to6LSofTy+pVSnql9m9sALjN1dYnT1/uNvtU7pY61jxUNfjDHOyCAuz+H23VFFpNtTVFrW1B6mAu 5xx4UGb32+otm4Ff+Icx7ao/iYy05w0k8H6rWHcuzLe4nfYG1Ulu0mw08wlqZXdUuOzckYC5zVGr BZda1Ftt8slTT1bszMJGRI4kFoXR/D/b6mi0eyerwwVDssBPIHGMhRRqS3zWfeL07g+MsmnbVsc1 2R0OJwD+yxhP0u/Zd85pPOrrXR3rSdFTXyofQRdTS10RycgDA5+iwuwjs23FSy1E1NPFBJ/eyuwc Bvdefca1VuqdI0EFifC6RsrXkvf0jpDcHn7r01FIKDb1lpuj2evNG6Ehjs5JASX7M930hrbm23/X 88ZrKiaKzQOAkmJwHY/wtXaboavpLTav7LafjEsj2egQ3nPUMEfddlfrZcKDR9JbNHxQRP6Q0tLg 0NBb3++VwVv2rdb6Nt8vtykddYn+s6JmHR9xgZ7n90XXw++3O21r0ZZYblqBrai61RHS0nLY/Ia3 688ldNvFTxVlksEMrA6OSujw0jI/KCttqy3z3+2WJ9scxzIalsshLwAG9IBXl3LidPp+2VsID4bf UieY5Aw1rQDj9VFvp7dZ26Wtt1loKac0zZJQHvZ3DQwdl5LtbXVu2Nwt75PVe5ssAkeO+MAHCyv7 H6x0rTPsdYYaqIh7Ok9+AMFePWl7pdJaI/h9VUtkrXRnJHB6iAc/uEnss3H10Vo2n0PpqGnslM2e unANRUOIBccA5P0HgJbsWZ96stoD4Wyw09U2adpIwBgD9eVF+3+tb5qHUNLb4ZDK0cuGcANHupc3 KdUQWe31UbSaeml66rnGGYA/qtfKfDPWlvnrLfZKChqTSNklw97RnDQwHGF4r8+SDaa4TSu9Sani fh7hyS0jBX31LHUaq0zSS6dqhHVQuDmgHBIIAwT/ADXy1Yaaj0nFpusnEtXXN9J3Twfmxk/1UnV2 XuaiJNBx6k3IrGNqJpYrTTOHqzngH/hb7lSZqy/W6m/BaToemUSERzZORg+P5LZ6it1wsOj6S2aM oWlwHS5rXBvSMDnJ75Kjyh29uVmpm6pv1wH4yB4mlpQzOG5H+LPfn2VqRJWtrfUz0dkt1snFI2SR we8DIDWsB7LCvpmV23IZcmidxPQ8uGckPAylqxlbqPT1FU6anAqYn9QHVguDgAefoOU9R1tJYtNU 1sr6hpqZCM4GOcgk/wAlFPW9DWTU9kobXUCka5zy94GQGtYCOPutRr2AVuytwNaRJK2nOXkeQ4DK 22sY6+/2Ggq9NTtbUwvHygjLmuwDz9BytLurW01j2zqLNVTh1ZPAY244ySQc4VnseHYrUdNV0MFj oqaOCOmZlxaMFx9z9cqKt8a11s3bNbDgSwRRlp9jyu1+HCxXOkq5rpVUkkdDUR/3UjuA7utDvjoe +3bWslxpaNxoZBFF+IdwxhJxk/Tla8Nkmcrn55vPC4tppP8AtBuLa3VdTeaeghhd0RMfkmT3PB4/ mpG19bZJNsJbK3/aJqmIU4laPlySBkqJ5dstVaWZQm01TrpFK4+o2laWtjAAIJyec/6KXtXVUlp2 uMlR/d1UUbXBru/UHArEbrzaG0TS7fWNkVtpH1d0qen16kMznnnnwPYLkPikt81TYbbVNhc+mpJS 6V4HDAcAZ/VfLQO4131JqCnt8XU8d39Hho7krbfEvPXxaUbHTxPdb5HdNS8N+VoJHTk/ddfD1btx 83dx01+0GuKO62ltmuwY5nR6Qa4DBGMYUW72bVy6VqHXizRulsUhy4t59Ek+foSV1OxG31VVSC/3 wPprWwdULDwZf+L7L7797g01db5tP20NNO7DZMduOw/kuUj02uJ2Pu1X/aigoGSuEBfy3PCkT4uG B1JaO353n+Sj3YGzV9Zq6nrKallkpad+JJQ35Wn2ypD+LVwMFoA93la/xJfy5X405f5WuHj172q7 2JXXbXVlNb9YUFbVAOjhf1YPbPhciTycZ7rqttbKb/qu324y+jFJIDI8dw0cnCy6Lh3+mOtdP09R Za4U9W0jGX4acnnPnt2Ueb36k/DaIqdNXOke2oe0ME2D0PLcHLSRythqTTt00Xc7b/ZSO411HJ1e q0AydGOxyBwF7fiBoI67at9ZVQt/iEbGODnN+ZpzytYTeUjnnlruKbvw12PqjhOT8xz7rDKy6G12 D3WWeViQfumDjum0ZdXPkldJoaslpdQUssLix/WGgj68LmvOeVv9GsMmoKFrAXF0zQAByTlS+li5 +v8ATrtVaEpLf6jY2OEb5ZHf4Wg5J+6rpvFtKzRlFTXWz1UtVbJAA90xHUHOPGMDsrCbp1c9BoOh MDnMe6SGN2ODgnBC0fxARtdtLTgjgGEhdfHOXDDL08+V4zLPH3tovhp09+G0zNX09W1ldVPJezoD sMHAz/NRDubZ66+bt3Kgo2CeunqREDjpBOO59gpj+F7rNJcycmMYa0+O3b+a1NlpP/yiap00ZaTK 57eoYyMcEKeKfrlb8Onk68kk9PFU/D5R09FDFLf5WXV8PUIvTaWOfg8DscZ+q89ftq3biO0XOG6u ku73RiWHpAA6uHdJ74ypf1U2R27mnw0OMH4ZxdgcZ6jjK4n4gnuOudPRMBOYx8o8n1FLNS/9N42c o7rc/S8urtFUNuZIImudG+WQjPS0Dk48qtG8G1NRoWGmrqWqNdapw1pmcwMLXnPGM9sKy26dbNQa PtLqd5YXzxxux5BB4XPfEhC121VI0jOHx4+nyp4pc8MZtjyawuWU+1N/C2On7RW367U9utcJmq53 BrGjt9z9F4Xjpc7I8rtNon17NZUTbPCZax5Ia0DnGOVltKn/AMD2yKCBtZqdtPVPY1z2GDIaT3A5 58rQX/ZK42rUlqoWXJs9rrcNdcHx9IicASWluT4HHKsBWVtuuraO06qgkpriwNlGXdP25H2KjHet 1+sU1OJZzNZZnj8PM3/2bsZ6T57eVNrJNpN0toikse2tTYqWpjkEsb2vqgzAcXcEkZ/1VUtytBv0 nqOlttJWsuLKmNrmSMZ0gPJwWnk9uFanT00suy75g4md1M5wPnKhnSe314u2trPNqqjnjtszy5r3 EfOQMgfTwr47/wAW9/LHk/8AlvTGl+HueengMeqKQzPa0ui/Dn5SRyM9XP8AJcEzbK7DcEaWqZY6 WV2XiplaekxgHDsA+cdsq3jK6Ci1nRWGKlhY007ZOvpw7z5/QKJd5g+Ddu0SREse+OJmRwSC/stY Te9pvuT4co34eLz/ABGpgfd6ZtLFCx7al0JDXuJOW4z445+q0dy2TvVDq6is81XF+Eqm9QrzGWxg gEkYyTnt+6sbu5eJbLpy3TQu6WPna2T6t6c4UVbi7m098oKOmo2mKWB4eHjvnGCpfSy7Sdp/QFNZ tqavTsD6b1J4XMlqenDXudjk+VUjcfR9Ro3UH8OmqoKkGJsrZYfy8nt9wrf0lTM7ZV9QHEzupC7P kuOFVvVNqvEF1oK3VNBVxUk0rQHzNwJGg5IB+yuOO8dly1lphtltnddewVs9vqKanipukF0wJDif AwvZtToSK/7its156hT073idrHYLi3xn2yrQ7W3mz3O0Ty2ukpqKnbgObG0N6iAO+O/C0ul7xabj uDDFR0NPSz0xkdLIxoaXkjHJ8+FnKW42xqWcu2wuuomacu1NZ7dQvZRUkbDJ6YAa0PPSAR91wO9W 1EN81FbJbCKairq5z2yuk+WMhrcgnHnPC6/WUzodXy0IoJpX3IxMjkDTg9PJwfOOSvnvtcZLZHYp 6d2JGTngHn8vC7cMZlJj9PNj5MuMuX2rXqXbXUli1FS2aaj/ABE9XxBLT5dHJ7848eVKu12z9Tp3 XVvqNUGgq4Ol7o2McXAPA4JBCnzTbDW2i11lwiArhGXfOMOaSOcfoq56s1zc6XXErqwyRvgfgMdk fKDwVyktjrbqpf1Pfr/Qazit9voKqS3udG0zMicWtB789uFxHxL6V/ilRZJLVRerdKiV0ZMbcueM cZ+gXp01utc7zeqK3wMLnzSBuGcnp8n9ApC15e6WwXqz19Y3rYxsre/ILgBlPHf2vS59yOd2e22t +iPRkq3ia/1UZ6nHB9PAyQ32GFB/xLwAbj1krRhxjYCffAVkNJ6ntGodRg0UOasRuJk6jwMeyiD4 jKWC96pprbaaJ0l5Dul/QMmQEcZH091vxdzLbHktmWOlfLRbqy6XKGit0Ek9VKelrGDJP/vKerZs Ixl507Bcq6RxnjfJXQgAgOaMgNPse3K7TQWi7TtVZDdbs5s97lZySR8h8tb9F9NrtTTal3Fq555M sZTuDR4GThZ1+u3WXvTpqm/27T14pdPUlIWUtMGwdDGfKOrhoz47qIN3dm5Havpm6Sgb1XASSOp3 ODGRlvJIJ7Z9vdSdqW50sGp621SRPfWVlZFJEQ3PytLDn9Oko3rvM9kulmqqc46evI9+QcJj2mXV kVPu2kL3bNSCxVVDILkXBjY2jIfnyD5H1Xr1Nt9qPTlwoKS6UQbNXPEdP0PDg52cYyOyupQ0dPc4 LXfKulYbhHSOc17m/MzqByP6KFrU6s3F3MiiqJjBDbnOnxjJaW+APGViXc21fekYS7L64hD+q1NL WNLiWztIwASf6L4bQaDdrPVrrfWvfTU9M0yTjp+Y4P5fplW9tVVb3alqrbTumdU07XdYe/Ixjv8A zXD6HoI6ffDVboWBoczJAHGSArZ+tsT3dN3Jd7Da7xBpeOljFPCwUojLAe/AGfsVXPf3byHRWoI5 ra/Nurup8cR7xEHlufIU73evt8epa23SgfxGW7RzsJH+EdHOf0K5H4tGB4tBOMBj8fut+PHd0xnl ZIq6Xcnwl1HwVi8YeUlh1j6B/f6o6sDuvl3TCivp14HdYudngrFHlNgHYoSQoDwmkmijKRTR4QCW UfdACBppdkdygaEkZQNAS8IzhA0JJ5QH80JJoDyjwkmEAj7oSQCyCxTQNLwhCBBCCgIH4QgpIH2Q gIRQE/KWEIHlBCSEB5THIS8oQAT8oxwke6DJCXZA7qhpeUIQHCEIQCCjskgflNLPblL3QPKCllGe UDQkjCIaSEZQH80IQgPKEYRnhUCB+yQTVQJ44QjugSEeEfZA0ErEp4QM+UggI7YQNCQ4PuhAZQEB CB4SQhAj3QEDvwhAwgI8oJ5QAQjKCgEJIPdA0FCMIDuhAKXlUMHhCSMKh5yhHhBRAmCl90eFRkOy EgeUHGUDKR5KM4PujP7oGhLPKWUNmT7LL9VhhJDb4yfnXzk/KvpJ+fC+bz8q80dXxbwU8pDumRzy tskUfRMIQGE8pfdHhAx7rNp5WA7LIfyyoPfBIWgEZ917jXzOja0vcQPcrf7ZaFq9aXlsETvRo4/m ml9m+w+qkrdKxaQsttp7DaqGEXHrYJKr/wBo1oPOT7lEQz/E6gxiMvcW+xcvrBdqmnHTHJIGn/iw p/1NtlY6nbgP0zboHXFjWPFRkl7scuGfOUab2x07a9vpKzU1Cx1bJGXGSUnqYSOAOeFRBMN9rmDD Jn4+pWT9QV/+KZ/P1VjtM7daIq9LRXB1lieyOIue97nFx6Rkk8r50+gNB3ax1VVQ2iFjhC5zT1u6 m8cHuiK2T3esmi6JJXuZ7E8LFt4q4YfSZJIGO7jPCsZedlbHUaRiZaaf8PcvSbI2o6i5znYzggnG CtfpzaSyQ6Brqm8UhmuzI5iXueQGOa04wB9VqJVf6W5VFK4mGZzCf8pwvHV1UlQ5znklxPJPKk3Z TTOmrzXSt1IHVEjhiGEuLW/UkjnK828u28uka59fbm9dlnd8uP8A2JPZv1SURe7gfVI5wg/RARR4 T7BCMID+qPCSAgQWbXeQsRwUyg6exaor7VGG0lQ5jO5aDhY3/Utbd4uirqHSMzkAnIXNA45TJyqP TBO6F+WHByulbrC5OojRPq5HU5bjoJ4IXIZQDzx3Qd1bNd3O3wCCCqe2IDhoPAWlvl6qLtViprJD JLjGSc8LQEknunnyiad5aNf3W30jYIap/pt4AytHfr5UXisFVWSOkkAwCfAXP9RQHHPKFSDZ9xLt b6RtPFVPDGjAGey5/UN/nvNeKutlMkwHT1OOThc653hHUqmkjWrce726jZTwVOGMGBklaO86kq7r cxXVUpfUAAB2eQB2XLFxPco6yoJQtm5t3pKdsLal3S0cDKwrdyLnVyMdLUOJjOWjPYqMus579ky4 +/KCXWbr3b0mtdUPyBgcrzXDc+61kHoyVDzGeCM8FRZ6h9yl6hPBPZBK9HuldqWmFOyod6YHA7rz XTcu519E+jkqH+g/hzc8FRj6h8Z/dBkLiMqiTNP7kXOzxmKnmd6fYBaXVer6u+VBlq5nOJ9yuN68 +cJZz9UHZaN1ZVadr3z0LyHvAB5XU3vdS63Whko55CYnjDgDgH7qJQ8t/KcI9Q47oaSvpzc652am /DxSf3fjleKt3Ar6q7suEsrnStPynwo1MjiO6frOHb+SbE3R7y3boa18vbjgrw33da53OidSSzOM LxhwzwQofMjiO5/dL1Hccn90Evad3TullpvQgf1R/UkLR6l11X3eu/EVMpLuMAHgKPvVd2Lil6hJ 7/umxMem92LlZ6L0I3kj6nhczqzWVZqCuFRVyFxHYZ4C4J0p7ZKxa8g8klDScbLvHc6C3xU2Whkb Q0AccBfC/buXK7UbqaSTELiC4A8nBULiZxCTZSBwoJ2tm9FzpqWOAvBawYBLsFc9rncu4ajpmwSy ERN8AqKxM4djhIyE9zyrs0kLb3WlTpSvlqaTHVKACc4P7rptY7sVmo7TJbarpNPIR1jvnByoXbIR 5QZXE5zyps0mSr3auLtONtjHCONrAwdJxwOyiqtr5KqpdJI/OTnla90rnHlyxzzyhpM23W59Tpaz MoIGNbE1xdkcZJ8rT7oa9qNY+iKjHTDkt/VRoJnAcOISfIXdj90l16LJfbD/ABEd+Vu9J3SW0XOO qgdh7T3+i0YHlZMcQe+EVZKg3vq2QRxvAHQAAc5XHbl7m1mp6T8M+QNh/wAQB/Mol/EO4PsvnJIX cuOVU0xmIc8u8Ld6IsUWodSUdBVVIpaV7szS+WsHfH1WiznuvTQ1L6abrY4gjyFFWQ/7EtCu5bqK 4Nb/AM8Z/wBFj/2G6JLvl1JcB93Rn/RQdFqSra0Bs8hHjLivr/airxzUPH/eTSVNrtjNGu4ZqavH 3MR/0Wyse2Ol9JVrbvQ36WeppQXxtqOgt6gOOwCr+NVVuf8AfvH/AHisajU9bJEWGdzmnuCSU4pu po1nur/HqKKhnY1rGSNkPPlpytduFueNQ6YbaHRgMAbg59uyhCWsc55PUclfF85c7JJ/dP79JpYL bjdKHS+m4rZHAAGEuJA/M49yvpT6rm1tuRbKqGWKikjZ6Jmx2ZnJ491X0Vb+jDScjyVtLFdpqGtj nieWyMOcoq87ZL5Fd6SnaI6u3FgLqjpDSO/GMlRhvDfKS17k2W5f3U5pIHNLHcgP6j/PlRxBvBd2 QhplxgYHKjvUeoqi7V8lVVSl8jjnkqz1o/qa9cbpwX+ipqN0YayOVsuR7t8L0XvVg3Mho9Mteylj c4OdO4cMDfOPKra6te6TPYfdey33iamqBNDK9jxxlpxwk69F79pxm+Hujc4lur48n3pRx/7pe+x7 Vf2GmfeqHUsFTPAwu6TAGEjyB8x7qHm61uAHS6skz/zLz1usa+aHoNTI5h4I6lNHJYmPeeikY1s9 IxzmgAkgHKjfdzcY6qZFSRgMpYyHdPjI8hRC64vJJae68slS57iSU1F3VjNud1YrTYY6GtYJY2tD A08jAWd73ZfW36mmp8xU0HDWA9vc/sq6x1r4xhpSjq39fUXHOfdJIl3VsKnd+2zsyynibUuaGGXo HWB91rrtubZbnerVVVFFFJNQuLw5zQSSW4/99VmNyf8A5j+6xFe889XP3V1EWa3C3TtV30vV298D H+szpaSMlp8EfVVslq3OqPznC8s9e+TguJH3yvIZOe/dLV0tDt7ulSUOnYqC5NbLE1rWhjuRgYXE 716/i1QYKaBobSwO62t/4sYz+yh+KukjYA0nA+q+E9U6VxLjlIV2+ntY1trt0kNLOWNcc8FerTOr p6O+fjfVJke7L3E9/KjoSnpwCsopnMdk5/dNppcW37uWp9JTy1cTJKyFuWyEDLSRg4XE0+vKC6a8 ZcL81tRSwtJjhfgtDuwJH0Vf23KQM6Q4/usW1jxJ1dRP1TaaWjum7LJNRQSUrw2ljwGjyPf91yO7 WodOaru9nmjhYyWOdrqqQDBkj4y0/soM/iTuvq6jlYvrnPlB6jj3TcVa2w6z0NZ5jWWe00dNUhpH qRNAcol3L15Pfbo55kJjB+UZ4CjEXJ7WkdRAPC8s1SXvy4k/XKSyFm1iditVWexUlVVV/wA1wlfg OJ/KwDsF19ZrrTLNYx3uOEGqjgfG94PLy7t+yqfQXKWmcel2AV9ZbnK5xy/OR7pKukmbma/qL3Wv xKTGDhozwAtLtvq6Sx3oVEchHXgO57gFR7PO57u5OeCsYZjHID2x2wlpJ8rrQ7h6bqfwtxrI2PuE ERa1/kdQ5C4KLV9r1Frf8XqN3qUNOOqGHqwOrPB/RV8Zd5On/eE/qvi24yCXq6iTnuk0bq2dTupT P1IwQuaKIDoHPZp7rySas07bdctu9mY1k1Uzoqz4dznq++OFVo3Sb1urr49srL+LyibrEuE1DdXD /tdpqmu8t1oHdNfVOaJXuOR0jvx9lyeqdXWu261iu1jkIkqW4q29XDiDwVXD+NzdQcHnP3XwqLpK +TrMhz37pqHa4x1ZpeepgvNSyM3KKAsDsDHPJ/mq97zayk1JcCHuDo2k9AB7fZcJ/HJTHguPIWnr Kp8shcTlXevScd+3mkPznCxCCSSkDlc3Q0JIQNCXhPylCQeyaCopJhCPCAQgIQCSaRQNCAhAI7I7 IQJCEIGhCEAgISQNGUIQPsEkJZ5QNGUIQNCSCgflGUkD+SBhAQjwgAgoR4RQjuhCAyhCEAhBSQZB I90IJ5QHZNLKFQJ+EvJQUAUBCeUCwmUsoQCO6DyjygYSKChAePuhCEQZQhCAP8kJJoFlHlBQqBPK R4TB/dVAChBQgMoJQgoDKEvKfYIFlGUk0DB5R5SQgMoQhAIR9EDsgaEkDsgEIJT8IEjwjKDygB2Q kEeyug/CeUs8ICaAl5TR5QCMoP3QO6oB3TSTIVQHsjuPugIQLym7gpEpKDIcBGUvCO6ofhCAhAIz 9Cl37IwUHxlP94eOF85Py8dgvpKfn57L5ykCP3yvNHV8W/mCyJzysW8prbIHdCY+iRQCYS7JqAC+ 0bcnHjK+LeCV9Y3YHf8ARBZf4ZIgKO4OxzgBRxu5UvG5N7bkkNnwP2C22yOs47DV/hakhsM2MuXT 7w2LT1wq6O8UlaxlbPK1kkcZBEjSeXO9iFYWdu82Oqa+t0mw1cPRTN+WJxPL/qtfv7V3GCwwRwsA trpGiWQHnqzwPsthftSW3Smi6WC0TxdRDWNDTk9uSvtcKu2aq26kZcJoXyPjJY3q5a8DDT+6Rmtl tz6bdtoDPzEY3l49245XCa81DHDqiy0NklH4N1KGTRxdgOrscfRSDp+lo6TRMVo/iEJc6nMbng9i 5uDj7LT2HTNj0vp+ra2siq7jLE5rqmTHUeOAB4CEdddbpFZ7VQTTECJzo43H6ELDUMsR0ndJYCPT dSyuGO35CuE3qudONB0MUNQwz+tEcNPOA05Wwo7lTDaOb1qlnqGikBHVkklnAW/Hrc25+TeulatB TPj1Jbw1xGZGg4+6n34kW/8A1MoPf8RD/QqNtkNHxXS8MulzqY4KOkOQzqHVI7/QLc/EJrakutIL HbnB8UMgc5w9wk6y2tm4r8QMJYT4wkFGwEFHlGUAkPoskigPqg9kvKePqgaQ7pIP1QM+UgnnjCSo f8k8pJIHlAKSDlEp5Q1YrLygZSyjPKQ7oHnlCSYQGU/CxS7FBl3KPKSBwin9kdkkjyPoiHn28J5W PCEGXbHKFj4RlCGUFLJQOyimDwjKQS8KjJGeEkkQ85R590u6ROCisgUeFiCmgfhCWcJAqBjhMFId 0YQNCxCaAwmDykE8hA0kZAS4z2VDKAeUeUIjIE+6C4rFIlNjMO9yjq+qxyj6IjIuz24RnhYhHdFZ BybXHPHH6rAoyiPR6zwMZyFgXud3Xz58pZQZk8pArHPKefdBl1cI6sjKwRhBn1Z8pErHKCeEGeUZ x5WOeEZ4RWXVx3RnhY/okgzykEuPPdLPKDLOAjP0SKPqgaZKQSI5QZg4TyfJ4WGeEIjIlPPCwTKg y6j7lLqWKYQZB31WXUcYXzwjKKyzz9UZyVjlCozyQOEdR/VYeE0GfUjqWH3TRWYefdHWV88pqbRn 1lYk5WOUZUDKSXcp4RTQkPKYUAmkmgEI+qEUIwhCAQhBQCSaMIBGEI8IBCEkDSCfhA7IBBR3QgOE sJo8IBCEkDQUIKAQhGUAnhJCATSCZQGEZRhCAyjuhJFP7IQUHugCjwgo8oBCAgcIDwjyhCAQhH9U AhASCBoST91YEn7o8o7IEmPKAhAdkk0igPdA/ZPwkiGUvCeUvKAQmkEB3R+qaSoEJfdHlEPuj6IC FQBNJCAR4R2R5QLHugp+EIEE0dgkThA0JfVNAeUimEeECBwmhAQBQOySAgZSTKRVDCEs8IHdUMgp d0ZR90DCCkgoH37oJSQEDPAyUH+iPCX0QMIJCSOyA7/ohPKOEADygoPI44R2QA7pnskjyiAeD4WX Use6eVR5pfzn2WMv5Oyzd+YhYyHA915o6PgO6yKxZnIWWVpC7Jk+EFHhUL3Szyn5TAQDc54WbO/d YhZDuMKD3U8r4wC0kY7YWwdc55YwHSOPT2ycro9rdv6zWl0azJit0RBnm+nsPqu73K01pCgqaCyW WljiqxMwT1Iccho4I74yUESPulRLEI5JXua3sCcr7018rIYzE2WQNPjPCm/cfa60R6MgqdKW5n4y NzXPka4kuaBz919aXarTlq29/F36nIub4ifVc8gtcRwAB7KpUKRajuEbekTSYHjKyOpbi7I9aUDH +Y4ViKPbHQrtOR3N1sJp2wh7nmV2SAOSeV5Kza/RNfp2orLZRvid6fU1zJnZbnscZRFeZ71V1UYj qJpHgdg4khNl+rmUj6b8RJ6J4LMnGFO+tdkbadOxP01G+K4RNDyXvLvV47Y7BayTaWy0e11ZdKyO Z93hp5JC/wBQgNe3xj2VlSoSo73V0ZeKaaSNru4a7GV4aurknlc57iSe578qVtm9D6b1G2oN/mll qTgR07HlgaPckd1zG6mgarRV3d0tdJa5nf3E2O2eek/UBWU04Rx5SGfKyKxCqkn5R4SUDyhIH3TQ CM8J55Cx8oGO6R4S7ELJABHlHhIFA0IQgCgIQFQihMpY4QAQkmiBNIco8IDlH80sp58oDshY5Tyo poPZH6oPZEIIR4R7YRQhCCgXlMpfzQSgEAITCBIQhAYSPJTQgWExwgpZQPyjshCATHCXlPnCA8JJ oQGOyMI/dCAIRhM90kAeClwmUfdAk0Jd0Q/CQR900AUvKE0Cymjv2QBhAIH9EsFZY4QJGUwUKgKS aSgRGSn4RyjKA8IyhH3QCEd0eUAjwmhEAwhCPKACaSaEH2Qkg9kU0HskCnjhAwkUs89kBA8p9wkh AIQhA8oSTQPlHdId0BFMoBRlA5QHZJPyhQIfRZAJdk0BhAQl5UGSPCEID7oCQKaAR5QE0Ukh9Fkk gEIKECTSTQCSCgdkAmEI7oAoCPKSBoSTQARlJNAIKEIBHZCPKACMJ4SygaEIQHlH2QhAiEwkmijy l5TR3QCPCPZGOUCQjCEDQkhAxyUkBCAKEFNUJNCaBJJowgAjyjshAISTQHhIBCfhEIJnugJFABCE FAJZTSwqGOUk0h/NAwhCPsiDygoCCgSaB5R3VB4SR3Rn3CAyjuUYQGoDxwn5Rj24R2P3QHhILJA7 oMU+6ZQgRQBlMoQJJZJZVgSCskFUY44TTCECSwn2RnlAu32RjlNMBAh3QRz3yjsmUGITTR57oF+i EyjPYIEhP7IP3VCRgpoHZEJLn3WQKfP0QeZ/5jhYS8MWbuCvnL2yvNHV8mnlZDusI+Cs/K0yAl3R 2TTYSY7oQe6oa+kIJfjHHuvllfeB394OOEFp/hpj6bBVnHd7VDGvKt/9u707qPy1kgHPgFdvsZrW C0v/AIdUEMZK7Icfde3dHSVldqiguFDWMYa6doqIW8jGcl2fdT4KlPaSsq7jpGmkraf04gAIyTy8 e65D4gq+4xQ0NM2Istjnj+9z3fjt+y6TVup6HSenaKltckbs4Z0g5IbhLWcdBqvQLH1MkRqcB8LQ /HS/sEiVu9Msp3bc0bawdVMYP7xp8jhcBqrUAi3ApbVa5R/DpIYWvZH+UH2Xfut0cmg/4JHXwslf Tel6ueAT5WmtWlbTpnTkrWVEVVcZOn1Kh5HU45HAz2CDsr3dIbU63ioIbHO/0yT9GjC1O4xjbt3f TFj0/wAG8jHbkLj9/rhC2xWdsE7fWFR1YaecdHf91sdS1sJ2Xq+uZvqvoS3k8kkdlqM5K+bX1Mke raBsbyA54B57hTB8VLAdH2jwRVZ/9yuP2I0YK24/xy5TxwUdKfkYXYc93v8AQLP4idaUl8MFqoSH xUshcXj/ABHGEntq1BGOSg/VM+ViqlBQUJnhAiE0soJQMY8pHlA7IQIFPnwjsjugXSSQmPKOf0SQ Pyml4TKoPKEZSKBhJNJAHuhHhLKIaM8I9kFAvKCjHGE/uoEj7phLHKpsBHlHb6ZTAUNg9kk0ihsd 0eEFACKAljhPwlygfCSMphAuyD39k88pIAI8o7IKBn6JI5QRkoDsjv5RhHKBhHlJHlA8oHflCBwg CjPCEeEAEzyl2QgEz2SBwn37oF4SPdNJEPygpBNABGUvPBCeECKY7po+6AQhHhAgn2R4QrsCEBCg MJELII8IFjCRTQR7IhBBCfhJDY84TSTQIJo7lGENBM8fqjwkRlAICMJ4RR2QlnlNAk0FBCAQgDCe UCHdCEeUB2QOUIQNCSYQMd0fVIJpSBMJI8qKeUJJoDwmkUKBhCSM8IDCPKaByihH9EICACPCOyEB 4QjykUD7pFPCECTSTCBJpYwU0AhCEACljKf1SQNCEigEJhBHKAQghCBlIBCAEDzwjKWUeEB5TSCZ KAQUBBRdkjujuUeUNjymljCaAwljlGUIBCEeEAhBR2V0GhLKEAmkPdGEAUD6owmgCUZSQEDRlBS7 oAoTKXhECAgIwgAOUI7JeUDyhJNAIKX0TVB90JeEIhlCSfdAJJkJq6GACyxwgJoEOyPPKBz2QOEA jCAeShAIKPsj2QHhPxyl4QeUCWSQ4KMoBH6pJgq7DyllHdB8Kh4QllCA/kjyg4x9UZ4QB7oKByhA ZR+iRWXj6IEE8JDshA+yX1T7oCAQgICqBAQEZQB8o/RCMoPNIPm5WEpw0L6Pz5XzlHAXmjo+Te6y dwUmfmTPdaQkzwkg/ugfdHhIHlMJsCzHBznCx8pjk4ycqjYwTvi6XRuIcO3K2L7tWTNaZZpHFvbJ JXS7Wbd1etLkC8mC1xEGabyf+EfVdhr7SmkmagtdksEQglbMG1c4kJy08EcnGURFs12qqmMNmme8 t7dRyvVBqCvjpxC2eXoHYdXClvdfay30Fit9VpGgkMjZMTuDy7qaQADg/Ve+s2n01adCQ1F39SK5 va0umMpBySMgDt2SFQ9Hq26sZ0NqZR9nFD9VXN7Ol9VKR55U+v2m0NBZBcZaepFMGBxf+Idkj3Xg uu0OkqjT5qrQKmOR7mBr/XLsAuA7fZEQLXX6trg0VM8sob+XqdnCHairn0X4SSokNP26C7hTNuNs lTUVojqNKiU1EOTNHK8vMg47e3la/UG09otO1ct76ql11jgEpJfhuSRx0qiJqPUVwoo3Q09VMyJ3 drHcFaqrqXVLnl7iSeVLu0m3Ng1PbKmS71c5rScRxRP6QwY7n3Ufa/0dcNG3h9JXtLoHuPoTgfLI P+o8qwcw4cpJk/McIPCAxwkRxwsgB45KWMOOSgQCCE8D/wB5LxjygAMp+EYx2KeP3QY+fsgBPp58 oI490CPCQWQGfCA3CBdkFPlMjjPZBh2KZ5TxwjKoxQO/Cz+nlAQYlGE0IjH3QG5PdPGPCf8ALCBH sksh3QUGI4+qYTx4TH24QYEeU8YWRIIS90GKO6y7I8dlBikOMrPwgIRjjhGE+4RjlFY4Rj3TJAKZ 57IMQOeyZR5RhBiRlPGFljjlCDDwmsu6eOOyDEpFZY4SKBI8pgcp9/sgx/RPwmeeyWeUBjARj2Tz 9EgUBjj2Sx7LPwl4GUCwj7LInhIYKBIx2TTCBY+iQAWX9EY5+6BFIg58LNI8Kox/dB5KeUvKA7IT OP1QgSaMIwcIDGB7o8I7J+FEL/RGMpo5ygWELIJ44QYYRhZY5SPCDFATxyssKjDCMLPCeEVgEeVn jCX3QYpLLCMIMUJowoBGUIQCEEo8IDPKaSYQJGU0IEmgoAQA5TCSaUgCXlP7oUUfVCEeEAnlJP7q A8oQhCGgpZTBRRlHlIpoBAR3R4ygOxR5QUeEAjwhCAR7IR5QCEI7IBCEdkAhH8kfZAISPsmAgP6p lLlPKBIQgIGl27IQUAmkEZygeEscICZ7IEmkjKBjujHKEigaQKY+iXnhAI8IQijCAhCoPCZ5S8p9 kCKE+6CgEkIA90D8I7pIQCPKEIAoTHZCBIPZCEQBBQkgaSEeUAhNLBQNJPwjsrAkwE/skiGkO6aX YoDynnCEYVAPoklhMIEn5R3QUoPKEfdCgPIQjHKSoyHKRQfCD2QIoQgdkDCX0SGU0DHZBJzwkSgB UNGOUICoEZQkgfKEIQLynlCEDPZLuhMIBHlCPCIEkwhUCEIKBfZNARz7IPK7uecrGbkDCyPBKxk4 bheZ0fJvcrL+qTD82UyVoJHdBTHbKIAjsjGEDlA88r6Qj+8H1OF8x3X2gcGyjPY8qi2nw7RhmjZj j/2nhV/vddI3VNwlLySKp5Bz7OKlTYvWdNR0f8JncGB7sgk4yvDrjRFog17bn0NbGaWvlzNBnJjO eTn65U30X2mbbmsnumkqSergMYLQIw7u4e6jvfy5V/8AE7fRyQOZb89Ucvh78cj9F2OsdV0elqG2 0FufG5rj04B5a0L47j26k1VpSinL2fjGvY6nAdwC4gHP6JEsdJSwUs+haKG4c0zoYw8ZxnnjK4C5 38jcwWKhlZ/DS6I9MeOnIHK7q+Wl1boj+DUtdDFUGJkYmJ4GDnK01s0ra9N2WEMkiqLlJPE6Wpcc uceoZx7DCo7O8XOnorjS0tSWgVReAT5xjj+a5XeJjItrryyMDoETQ3Ht1Bczv7cWx12nfwk49Rsk riGu5APThbfdOqjOztUHSNMkkEYxnknIViVB2zFVNHrOiha8hkj8OAPC774s42fhLA7AyJZf6Baz YTRz5aw6iuMzIKOnz6bSfmeff6Bav4iNXUuo7hS0lCeuGic75/8AMXYz/RQQsSeeOy2mm7NUX67U 1BStLpZnhvHge61uOfZbfTNwkt1yjnjldF0kZc3g48qqtJHtHp6r0oy2S2+CmnaGg1UODLkdz1Y8 rwav2ltTtKQ2rT1qpG1eW5rZTiUAHk58krCHdy00dkgit/UajA63POT9V5tZ7o26tssIt0rmVhc3 qkB5YPOAm6abYbPadrtJw0D7fHQ1bGtDqqF2Zeodz1ecrxav2jtR0sy26dtEBrcszWPdh4APJz5J X3i3ZtFHZoY7eXvn463yHJPuV59Y7n2ysssRts7xWdTcv6iOkZ54RHrOzWnK3S0dCaBlFWNDQaph DpSR357crXaz2gtQ0xHbtOWiM3DLM1r5MPAB5+5K20W6lmorPCyjmL6g9PW55JOfJXk1jubbqizx G11BFaXNDng/lbn5uERk/ZbT1fpeKkZRGgrgGh1UHlz8jue+OfstfrHZq1s01DRadtQkuJcwOrHP IcGg/Me+Dlb1m6dmorNA2jkdPUceoXnPPkrzax3Kts9nhda6wtrHOALmn8jfPCsK+D9kdP1mmIqa KlfQ14DQ6pLi5+R34zjn7LWay2YtsWnYKLTtsfJcupnXWGTGGg/MSCcchdYNzbNQ2eAU1R6856et 0js8+SvDrPce3vtcLrVWYq3uaHODuGN88Kdjwz7HWKu0zDT0sD6C4gMDql7i5xI/NxnHK1mtdmLb Bp2Gl09bpp7p1MDqoyHHSD8xxnC7du5FnorRB+GqBUzuDesuOefK1+tNxKA2yCS0Vo/Fuc0O5wGj ycK7GlqNi7LXaZp4aKOaguQDPUqJXF5OPzcZxytfrXZW3Qaep6XTtBUTXTqYH1XWSA3PzHHbsu+G 4tlobTB6FUKqoOOsu558la/We4dCy3U8tnrR+Ke5ocP8LW+Spsc7VbD2as0zDFbmzUV1wzrqZ3F2 cfm+XOOVrdabKW+i0/T0+nqWrqbv1s66jqJb05+Y47KSf+0Sx0dsp/RrG1M7sdZecnJ7rW633AoY bfBNZ68Gqc5rXNGC1o8kpulcvXbDWms07A20+vSXQBnqTVDiQcfm+XsMrXa32Ut1DY6eHT9NWVF2 c5gkm6i5ob/iOFKDtwLNQW+nMVUKuZwHW4kHB8rW6z15Qw0lPNaK5pqZC1jhwWtHkpupHG3DYO21 WnYG2mWoprp8nqS1JJB/zYaOy1ut9k6C3WOmh0/FX1N2c9gkkOXM6f8AEcDspafryzUFup+msZVT ux1knye/6LW601zRUtJSzWu4N9eRzWObwWtb5KbWuFuWwNvqLBTfwOongumW+rJVklp/zYaOy8Gu 9laC3WalisEdfU3Zzo2ySfmjA/xOwOyl9+trRQW+mzWtq53dPW4uGBnv+i1mttc0lHS0s1ormOnk c1jmcFrR5PvlNkcBdNgKKpsFMbHU1MVyPSJX1Z+X/iw0YwtTr3ZaktNno47CbjV3Vz2NlIZ1sDT+ Z2B2x+qmx2tLRR2+mzXMq5n9PUcjAJHP81q9ba1pqCGkltdax08r2sew4LWtP+L3VlpUc3b4f6Wa x0jrDWVDbien1XVfDDx82ABkLU6+2XpbPaaKOxSXCru73sEuW9cYafzOwBkYU6SawtNDQ0xkq2VM z8BxyAAT/otVrjWkNBT0ctprYnyyvax0ZILWjyVO1RfePh/hfYaWTT9dO65Hp9b8Xwzx1YAGQtXu BsxS2S10Udmmr6u7PcwSjo6owD3dwMj9yp+l1da6GhpvVq2VUshHUQcAZA/kFqda6xit0dFJbKyK R8zwx0RwWtHuSm0qJ7zsAyWxUcuna6Z9wd0iYVXys5HJAxkLWa+2XprDa6Flnqq2su8r2NmYWdUY B4LhgZGD7lWDk1XbKKiphNWx1E0hGek4AJH9Fq9a6xhtkFJLb6uKR0zmsMfBDQfJKbEQXnYDNko5 tP1809e8tEzakBjBkDJHGRgrVbh7M0+n7Vbm2mtq6y7zSMZLE5gLA0jlwwMgA+5VjJtUW2goKP8A EVkdRLI4dXRgAEj29lqdZ6uhtcdHLQ1UUpneIzEQCGf8RKpUNXr4fpG2WiqNPV8tTXPIEzKgBjBw MkcZ4P3Wq1/s5Dp2221ltuFRV3ad7WTROj+RoI/MCBwAfdWSfqa3UNDSfiKmOeWQ/N0YAbkDx7LV ay1ZFamUT6Kop531Dwwxd+n/AIlNiFL38P07LRQz6fuElbVSECds4DGtyBkt4zgHPdancLZpmm6G 2MtlfPXXOokDJojH8rAR+YEeAVZibUdBQ0NIKmqjmnlIz6YwBnH8lptbasZaXUMlHNTTipcIzERn o4/MTnsghTUXw/1UVlt8+na59dVyuDZ2ygMYwEDLh54K024O0EelaG2No7lJW3GokEc0Rjw1gI/N keMqz82obfQUNKKmpjlmlOD6eAGnA/ktRrPVMVp/BOpZKaoFS/0/Txks47k5+qCDL78P9dDaqCo0 9XGvqJXATteAxrAQOQe+AVqtw9oBpagtn4a6fi6+pkEc0TmdLIgR+bPtlWhk1BQUNHSNqaiKSaU4 xGQAMgePZafWuporQ+hMBpqn8XIIhGQCWfU/RIqCL7sHcIbVQVNhrhcppXBszOkMazIHIOeQCtVr /Z2XTFHa/wANcxW19VII5YfS6WxZA+bOe2VaWS90Vvo6RtVPE+WU4xFgBvA8LTa11HFaJKEwikqh Uu6Ax3dv1J9uUEB37YS6Ulroaix1rbpNM8NmYGCMRgjvkk5AK1ev9opNK0dr9O6Nq6+rlEckBj6R FkDDs57ZVrJL1Q0FHStqp4TLKcAREADgLSay1BDaZqFzGUtT+Lf6YbgFzPqfoiK/X/Ya8UlsoKmy 1rLrJO4NlY2P0xGCB82STkZWs19tDUaTprX03SKsq6uQRyQiPo9LIGCTk5Gcq2Ul1oaClpmVUsPq SnpAiIAHZaLWd9p7RPRn0aOpFU7oaCB1N47n6cobV6v+w17oaChqLRWR3V1S4NkYxnQIsgfNknkZ P8lrddbQ1mlqe2AXKCsqqyX0nQsZ0elkDBJJPGcq2j7pQ0FLSR1csPqSHpDYSMDstDrO9UtpqKIP pqSqFU/025ALmn3P0RNq9ag2Jv1BQ0E9rqIrqah3TI2JnQIRgfMSScjn+S1evdoq3SsVrAuUFbVV svpOhYwt9LOME8njKtw65UNvpaaOqkga+Q4DYiMDgYWh1hd6W2VdH6lJR1YqXenGTgvB+vHAQ2rp qLYrUNspaCS2zQ3V1S/oc2FnSIuB8xJPIWu1ts/cdMMtfVcaerqK2X0nRRtIMWcYJ57ZVvP4lRUN NTR1UkTJJOAyNwIC5/WF1o7XW0Xr0dJUmqf0RuOC5p9zxwP1SG1c9QbG6htVPRPoZIbr+Jk6HCBp HpdvmJJ7f9FrNbbT3TS7rZFJXUlXPXSekI4gQYzxyc+FcA3Cjt9PTR1UkTHyHpayM5C57V1zobZc aMVNBS1H4p/RFIcFwP14yENq4X/Y3UlrjoDRuhuf4qQscadpAiHHzOJ8c/yWs1ntPd9Ly2qCSspK upuEvpNjiyDH9XZ8K4v46jt8NNHVPjjfJw1jDwub1dX2+23SiFZbqapdUv6IZDgvB9+3Hf3SFqtW oNktUWg0JgbDchVP6C+myWxduXZ8crw6y2qvOl6m2wVFTRVMlfL6LBA45aeOXAjtyrkCspLfDTRV L44XP+VrGHIHsuZ1lWW2iulE24W2mq31MnRBI7BcHYH7Km1aL/snqm0vohFHFcG1L+gOpckR9uX5 HA5Xh1jtXfNL1FtgqZqOoluEvoxNheeHf8WQrmNqaW3w00VS6OF7z0tjYcjK5nWFXbaC7Uf8RtsF TJUS9FPISC4Ox3+n3U3Sqx6h2X1VZpaNjIIq8VT+gOpSXCM8cuyBgcrxav2tvul6u2U1U+jmkr5f RiEMhOHcfmyOByroiemoIqeKoc2F7vlawHIC5fWE1qpbxRC522KpmqJemneTk9XbP07pupuqw6g2 b1XZamhhdBFWmrf6bXUhc9rDxy7jgfVeHV+2F+0vXW2lrRSyyXCX0YPRkz831yOFdQS0tCynhncy B7vlawHP81y+sJrTSXik/idujnqJ5C2nf1AuJ7ce3dFVc1HtDqmx1NJBJRsq3VL+hjqUl4B93ccD 6ryar2v1Dpqst1LWxQSS18npQiGTq+bjg8cd1dcPpqOKnjmc2JxHS1mc4PtnK5bVzbRTXylddLaJ 6mZ5FNIX8k9uPY8ptFWtRbS6psVVR0s9C2ofVO6I3UxMjQf+I44C8mq9tNQ6ZrrdSV8EL5a+X0oP Rk6gXex44V2g6lpG08VQ5kL3DDIyeog/fK5PVxssGoaM3a3maskeRSv6zye2R4B5Ta1VfUG1WqbH X0dJUUHrSVTumM07utufqQOAvNqfbXUWnLlbqGvpozNXv9OD0pOoF2cYJ8d1d0fhqZtPHOWxPIwy NxDiD7ZyuT1ZFZIdRUb7tQvkrXvIpX9R5PbLfZBVLUG1+qbFX0VHWUBfNVu6YjCetuc45I7L5aj2 51Hp662233CjYai4O6Kf03hwcc4xnwrvYpoBTR1HRFIRhjH8uB+65HVsNkj1JSOu9FM+uLj+FcHk Zzxlvsm6KoX/AG11NY7pRUFdbX/iKs4h9I9bXHOOSOAvlqPb7UOn7tb7dcaEtqq89NO1jg4POcYy FeItpozTMqAxkmPkY8guB9srkNWU1hbqalku9JO64Bx/CO6zzk4y3CuxU6+7dalsdzo7fX22UVNW cQiM9bXHOO44C+OoNAaisN3oLbcqBzKquOKdrXB3Wc4xkK9BjpmfhWzhjZMfIyQ5cPC43VVJYRqm ilu1NUm5NcTSODjzk4y1NrVSr5t/qKyXWit1wtkrKqsIELWkODznHccLC+6D1BY7vRWy426SKtrT inYCHepzjgj6q9LoaXqpPXawTBuY2y4LgeR391x+p6SxO1PRSXaKqFyY4upT1Yzk4+TH1TaKiXzQ mobHdqK23G2zRVdYcQMGHdZzjgjheXVuk7zpOohp77RPpZJmdcfUQQ4Zx3H1V9H09KXUhnYwTtYD GJsF45I/dQj8StDa57MX1Jnbdo39cHqH5S3OCB9FZdm1WgkVm4YcQfCRCisUJ4wljlAFAR+ifZAv ZPCAgIEmhCBD900JoEmkmlAgIQoBNJNFHKAhB7KAQEf6pBCGEeUJooCPKAhAeUBBQgPPCEIQH80f ojwhAE+yEYQgWU0IQCXhMI8oBCBlCACEYQUB4Qgd0fZAIQgoDHCYS8JoEhBQEAmkjCARjlB9kIo7 Jnsl5TQLHhAQjKASTQO+UAEIKFQ0JeEIDygozz2RhAIzyhCB5SyhCAQeUeUIAI8oR3RAO6CgBGMI F2TQmgQCMJoQLwmkhAYQe3CE1YEE0s4S91UZLHz9EyUkD8IJwkUeEAeU0JFAIQByhAJo7pYQCaQT QI90ITxwgXlHKEFAIRjsn2VCwhNAQHhCEdlQj2whNLygeUZykjsgaEkIBMJJjhAdkZS85TVQZRnC SfKAzwnnlJGPdA0slJLlB8Hd/wCqxkzjjGFme/1WE3hed1r5N5JKyPdJvdPlVkFCEeEAfdGeUHwj H6oMhws2dxhfPGeF9GcnhFbCmq5ad7XxOc1w7EHGFsJrxVyyMldNIZGdnOccrp9rNt6zWdYJpiae 0wn+9m8u/wCFq6bVekdKy60tVjsIfBE15bWTeoXB3bAGfPf91RG1be6yrLHVEz3uAwCSvXFqi4th EX4qXobgj5jwpJ3b2tpbXHa5NKUkxikcWTu6y/k46T/Vbi7bQ6ctOlaKa5T1MNxkcwPf6vufmw3H sjNRTHrW7tZhtZNgf8RWEms7rJgOq5TjnJcSp0rtn9E0drFfOK5lPhp6vxB89vC8V22X0062wzW2 eta6WaNgcZg4AOIzxj2QQXcNQ11wex9VUSSyMGGlx5C+lVqi5VdCKWpqpJYRwGOPAUo7l7Lfwumi qtMulliYcTRzO6nY/wAw48Lza52ntundt23qGpqpLiBEXAuAYeo8jGFURtQ6oudLSOpoauVkDhgt aeFo6yoMziXEklS9trtZadUacmqa641Dbi4u9OKFwDWccZz3UYau05cNMXaW33KMse0npkA+WQe4 Qab+pTa8t/LxnukR/Jb3RlhGor/S0MlQ2mhkeBJKe7W+cfVNq1jahzflLu/1WRqHFv5v5qwdTsDY qaATzX6ujhJABcxnOe3K4HdTax+jqOG4W+qlq7a7DXulAa5rj2xjuFRHLapw46jj6Jiqe3OXEgry E8nAxhAJ4yolez8S7w4gI/GPwASV5Dn9EurHfsiPa2skAIa4ptrJMdLndue67TavbOs11JUyuq20 NJCABIWdbnOPgDI4XKaqtDrDqS42p0om/CTOi9TGOrHnC1B5vxr8YD8/TKxFbKQfmdj7rx/blGUG wjr5Ixw4j9UOuEnbqJH3Wv8AHullFbEXCVv5XOA+6f8AEZHcOeT9ytcD+qAefCDZNuMw49R2Pun/ ABOQHHW4tP1WsLufKO30RG1Zc5x+WR4HtlJ1zmPDnOP6rWHjv2QMk+TlFbRt0qGtx6jg37rIXSdz cOkJP3Xe6e2S1ReLPBcC6jomT8siqXOa/p8EgDyvFX7Q6motTU1m9OCV1Q0ObVMcfRb7gkjuFE05 B13nbgeo/wCnKP4tUO4dI8j/AJlJUmwOq2EE1FqIPn1nA/8AlWhrNpdUU2p6Wyfh4ZJp2hzZ2OPo gecux3CDlW3mpHy+u8geC7hBvFQ4EGVxA5yTle3WGjLvpfUEVnrmRS1ssbXxiBxcHBxIA7DyF7tZ 7b37Rtno7jeBTCCpf6bWxyEua7GcEY9lUaVt7q/Er8fUrI3uocculcT91o+on3S+p7KGm+/jtRwP WcQfcoffKh2A6Zx9vmXT2LZ7Vt5s8FxpqSCKGbljJ5eh5b74I8riLvbaq03GeirojDUwu6XsP9R9 ENNj/aCsbges8j6nKZv9VK3E0zjjsCVz+ee6CcqmnRu1HWdIBmfxwOeywfqCref72aRwHbJzhc/1 HCC4/VDTo3akrXNGaiQgdsklKTUlZJjrleceSVzgceyCSUNOm/tNWEgGdxA9ylJqareR1zvdjsSV zIJ98I6vqi6dZ/a2vJHVO92OBlx4WMupq+ZzTJM447c9lyufumScJtNOsOrbi4t653np7ZOUpdVV 0zmmSdzy38pcc4XKdRxzlMHCbXTr3axuB6fVqHPx2yeyxm1bW1DmmSZ7i38vUc4XJdXKOo4PsmzT sX6wuTiOqql+Xt82cLGo1fcZ3sM1Q95b+UuPZcf1H3KfUSOSmx239srhJ0mSoeensS7ssKnV9fUv a+onfI5n5cnOFxvWRxlMSEDvymzTtTrm4vc0yVEhLe2SlVazrql7HTTucWH5eey4v1HewQXlNjuv 7cXKUgzVD3dPYknhYVWta+oljdLO95jOWdRJwuJDijqPkoO7l15c5Cx0lS89P5cnssarW9xq5GOm ndI6PluT2XC9Z90dZQ0792vLnI6N0lQ9zmctLndl86vW9yq5o3z1DnmM5bk9lwgfnB7p+pyiaSE/ cC5SOYZqiR5Z+XLuy+VXru41lRFJNO57ojlnUc4XBCQ90/UPlDSRZ9xLlNIx00znFn5eey+FZru4 1tRDNUTueYTlnUc4XAGQ+380hIfJVNJLfuLc5nRvkm6zH+XJPC+VXr641tRFLUTl7oT1MyScH6KO vUwOENld9vskNJOl3HucsjJJqh5cz8vJ4Xnq9wbjWVcE887nvgOY+fylR16rj3KPU4x2+xV3DSTq ncy41E0c00p9SL8uHdl8azcO4VtbT1E8pMkBzGSTx9Qo36z5TMhPf+qhpKU25tynqI5JpXPdH+U9 XZfCu3FuNXX09TPMXSwHLDnsVGXqkdiQj1T3JOUEry7n3OonZJNKS+P8pyeF8azca41lxpquomc6 SnOYznlqi8yE5IJ/dIOPuefqiVLc26VyqamOaWVznR/l5Xmrtyq+vuNPVzvJlpzlnzdlFrXkZIKD I73JKvSaS9Pupcampinmld1xfl8rz125dfXXSlraiUvkpjmP6KKS9xxkpiQgdyhpMU+69xqq2Kpl kJdGPlGV5LjuZXV94pK+Z/VLS5MZz2UU+qfc/uh0h7D+qbhqpjn3XuFRXRVU0pMkX5R1L4XHc6sr 7vSXGZ+ZqX/d88hRH6p9yj1T4JBTa6qaJt2rhUV8NTLIS+P8vzL4XHc+sr73SV9Q4mam/wB2Seyh /wBZ2cnugyknOeU2mqmup3cr6mvhqJpS58X5RlcluLrmp1W+J1Yf90CG85wCuBdLkj3C+cjy45Pn smzVJ/LiVhlZHusSstBCQ7rLCihBHCEIEjCaEC8ownhBQAQUAIxzwgEfZPwkoEmOEBCAQn5QihNY +U1AHujt90IQgQmgIpeE0jyU/sgPKEIQCEIQCEIKASyn90j3QMpJpd0DSWQ7IKBA5CAEBPKBBHZN I90C5ymjyhAZQhLygeeUFBQEAhHlCAQhCBJpICKfhASTQBKPsjHHdLKBhCAgIBB7oCD3VAhCEAjh ACeECCEwEIEgJoQIDlBGE0IUDsjyhLGUQ0k0kDCXdPwkgMoQEIBHhCXhAwUIQrAFId0wjlELCMIT yqAhGPCEsoGjPOEso90AmkhAeyZSKBygYSPdNBQJBT8BI9kBnjBQOUkIDynjKQTWgJnvwgJIDPuh CEDCEsozygaSE0Ae6XhCeUCT5QO6O6IM4SPdCMqgTP0STQJNJNAFH6lI8IyPog+BbyvnJ4yvo8gP IXzk7BeaOrFpymViwJ9uVpBhBR3QQiABHlMIyga+0GMj7r4Dtx3X3pvlfl3goq3OxkYj28JAxy4/ yVcG3GWO9yT9ZLhM45zz+YqZtkNXUotP8FqHBhdnBJxnIwtFe9BW2k3Kt9NTVkT6Ksk9R8Ydkxc9 ifqrPSWdp00VUPummKGoq4CwlrS0PHJA8qJ97rpXTapoKKaB8VJGSYXkcS8jJ/Rd3rLWFNpqe122 jLHsdw7pP5WjGAV5tzbJS6jt9pq45WCvZKxsXzcBrj82VIadfUUtJVaZooLgCadwiy3OMkdgfoo8 pdQvn3OksdNIw26Kpa5jWdsgf9V22sLTPd9Kfwu31sMNSOjEpJwOn7LWWTSds0zSW9sTmT3B1TG+ epcQXOPnHsFUdZcbhSx3WO31PT/tDHOGfPOFxO/YbHtdXMaAGiSIAD2DloN7Lk6DWGn/AMLNhwY7 q6Xe7gtrvtMw7WOaHtL3ui4zyeclWTaWop2FrahusqalEjvSeeW54K3HxXsb/GLGWgZ9GQn/AMQX s2C0lJFKdTXKVlPSxA+k0nl3uT9FyvxBaopdSX6nbQnqipGujDv82TlZi1EnkroNFOc2+0vSSP7x ozn6rQZAyut24ttRdNUUNNSsLnmVpOOwAPJK18LFu9S26C66bpKeqq/wkQMchkxnOB2Ud74Xi2XK xUmnYJ/We+SMudHyQAew+pXU7wUVdNt7LHb8etTBsr8Ox8rW/MoU2Vngq9cUc1eWuEfzNL+efCRl Ktn2t0pLS0jZdMgksb1SSudk8dyM91GWodurHYN06Sjri82ipHrtp28Y5x059lP9c25HWFHURnFo ZDmV3UAOr7fso43stdVLrGwXRsWaIdEHq5H5i7OP2SFem77V6JtVVHcqyiLKOYNijpw93T1nnPfO Vwu9m2ds09b6W82Vn4ame5sboOSCXcg5J4UvbtAu0zZmg962H+gWn+Ivjbqla3zURf0SkfLYa2UB 0qz8LPKahxJmLXEDJIwMBRBd9HTap3cudppJfTaatwkmdyWtB5P1KmP4cqCop9MS1E0bmxTSf3ZP +IAjlafS9vmtm+VwfXRmATOdPGX8dTCeCFcbNJZ2+1ftjt7Z56WguEMrqpzAeozOBf4yo53x27tO mKSlulhmZFTyFsZpXPL3E8nrz7LvN9NM6lvOqqGo09Qy1EQpwwyMIAY7qJ5Ud7saPvOnLBRz3q8Q VjpXBgp29XUwkZJ58DstWJN/KJwuj0FpOr1jf6e20jxGJDl8pHDW+f1XOYyFNnw0tazVoc8gAR+V mtOzrNotBWyeCirpqz8W5jSf78jrPbOMLUag2Us1v1LbJnVk0NhnIjfEXZkL8ZwHeAV0+49lu1Zu Za6yho6iajbExr5GNy1pDsnK6jdgs/B6dh6gJRXscW55x04VymvSY21wtbsfpW33QT1tZWR26VrW QRerh3qHkkux7Y4Ueb2bZQ6NZS3G1SSOtk5EZZK7L2vxnOfYhWB3Y4tmng3v/EGZ+3SFyPxQNzoK 3tI7VLT/AO4THsy6iqQOcg+FLHw86fo7vrSF9whbMyAdbGOGR1eDhRV0jP08qa/hvq6ej1Q588jW Ax4GT3Ky07zevWlXYdRUdBA/ohZC2bA45z/7y8ku4sOpv4FSUvWypiqWukdnGc8YXh+IjSt4umoL fcrXSuq4po20wZECXBw8n6crzW/bOfSD9L1VTUvmutXVFs8DMFjBgEY8kjnJUE3axoLhcKS1stb2 sdHOHykuwCzpHC+1dNA/UFnpGPBqIiXyAHsC3C5PfC711m0tR1Nuc9rmzf3jmg8N6RyfplcTsZea i86vkqayUyyCI/MSr2y+G6cTZd7bOSAS2CID9ytz8UTQdDW1h8VQI+/QvNuNRTybzW2aOCR0QihH WGnHBOeV6/ihONH21vB/2jkf91dJlLnfrTnZZhPtVLwcH9VK3w+6Yor9rKF90hE8FO31GxuGWl3g kKKAMuI+qnb4ZZ4qfUMzpnhmYwBk+VyrqmbUd3utLqUQUNOx1tpI4nSu7BvXxx7qOfinsVE21Wy7 Q07G18k3pSSgYLmdOQCpF1N/Fv7VQ0dJRNkobi1odMDy0sGXZ9guM+KCqhOnrdSte0zMm6nMB5A6 cZXTx6t7c87ZpyOxeidL3Gx1dfqaKGpne7DGSOwGNHsB5KhbU9NDR6huNPSgCmZUPbGB2Dc8KWtp Nva/Vtqq6t11fb6ZjgyJrBkvPkn6KI79C6nu1ZBI/rfDK6MuxjqwcZU2016Tu3CEEJtosoyg8d0u 6geT2S8ozgoKBg8oSR+iB59ynn2S7o4ygeUZ/VJMDCgD3RnnshMKhE+E0iENGUB3WQ7I8oA4QCEd vohA0sIQgPKRT7pKgBTBSxzn2QgMpZ59k8JFA0ZSR4RDCROEwOEZ5QLOUxwEnDyEHlA85RnlLwhA x9UE8eUsoRDB4TyUgUZ4TYZSzyjwkeUDz+iCkeEDBQPOT9kzn3SKPHKA57J54SBQmzZ5QTlGUFAf dJCPKgE0BA7IoQhGEAEf6p9kIBCPujGEAe6flLugKBoSwhCBMAI8I8IpYRhNCAQeyB7JqDFNNH+q EYhCf6owikmRlBygZQCaSPCAQEJ+ECST7lBQCPCSeeEAeEBCOUD8JIB8IQCB9E/CQ7oA90JH9kwg EI8oKAQeySaBJoSzhA0JeEIDyjPKaWEAmjCOcIpJhGEYQAKPPCyHZIIEmEFCAISwmEfZWAQgIQAQ gFCACaSED8JIQgEDKO6Q+6FCfhCSIOUJpDsgEIQgEBCCgChHhAQHgpBMo7qwCOyEkQI8ppKgQjyj CAP9EY8hA9kdggO6PCCllBkeyQ/mhAKAwhBQgEimg9kCQgICBgplY9k1QZQUsICoaEZRhAJd0x2Q gPCEIJ5QCMoJQiBB7oPZHhA0vCPKFQIykAnjlAeEBMFJA/CEv6I6grofB3Lie/K+cvAX0cfmKwm5 8LzOlfOP27JnhEZ7pkqmy+qCglARACgo8oyqDB5X1jJyFh5WTB83hF22dFXT0kokgkcxw8g4K2D7 3WunbOZ3mZvIeXcrqdqttqrV9V+KrC6ns8R/vJexf9B/1W7vGjdNVu4Nvs9jklioWktqpPU6uo58 EoI8rL3WVUjZJpZHyDy53K2LNW3UxNaauU9H5cuPC7jdLa6Kz3O1t01T1LqSp/u3vc4vAeT8q6K9 bQadtFrthq62qiqZZGNmcZRyD+bAxwkSovi13eunp/GzH7uKxm1xeHuaXVcvUw5B6uymmv2a0bb6 FtZVVFxihcQA71x3PbwvFd9kbF00DrdXVwbUVDGO65A75DnOOO6IhS46jrrhUMnqp5JJm/lc45IX 0uerLndKMU1dVSSsjHDXHhd7uJs5PZpYZ9PyTVNI4hkgmIL2E/4uB2WG5G1dFpTRVLdqetqZqt74 2SNfjpPUOceysSuFptYXWG2/gW1copSMdAdwFzlRMZpCXE57qXtF7Q0eo9KGtddJm3V7XOjhj6Sw H/CHeVFN+tNZZLlNQXKIxVETsEEcH6j3Cg8AHut3pu/VlirRU0UnpydgQtGD3wul0Hpt2qL/AE9B JUtpYHHMkpGSB9B5KK6K7bk3q6W+SkqKp3pSAtcM9wuRtt0nttYyameWPYcghTdVfD/QwNa+TUk8 cbjhpdTtOT/4lyO6O1DdD2KC5xXV9Y2WYRdDoQ3GRnOQUHyk3Yvk1KIpKgdLRg4PdeG87h3W7x07 Kqcu9BwewexC+2jtpr3qKwVF1/8AVIegupmObl07vbHgfVcSy0Vzrt/DnwuZWiT0ix3HS7OP2Vg7 W67kXe6QU8dZL1eg4Obx5HlfHVG4Fz1JQRUtweHxxEODRwMruIfh6rn08T3XyFj3NDnN/DE4JHb8 y5Dcza2s0La6aunuUVVHNL6WGRlhacZyeUR7NPbs3m02+Kiic30Yh0tHbAWouuvLhW6gZd3Sn8Sw Bo57AI0rtdqHUdgqrvTR+lAxpdAx7T1VDvZo9vqtPpHR9x1LqL+ERhtJMxxEz5hgRY75HkqiQW71 3gRNBDOpoxlcDrnVtdqipE1wlc/pGGtzwF1+q9lrnpyw1l0qLxQPip4y8MDHNc/6DPCiPqLgCVUC 3+ltQ1Nir46ileWvaeeeCFz/ABlem3Uk9fWQ0lKwyTyvDGNHklRU6M3wuXot/u4yQMcrmLzuPXXS 7wV1Sep0JBa3PAIWxZsFqn0GOFTbA5zQS1z3ZHHbgLx1+ymp6StoKZz7c99W5zQWykBnSM5OR/RF e2+7r1t6bR/iGgCmeJGtB4Lh5Wo3C3Iq9X2qCjq2tZHC7rGDxnGFtXbEara0f39qGe2ZnD/8VcFr XR920fcGUl3iaesZZLGS5j/cA4HIVlSuZJBz5B8raWO6TW2qjmge5rmuyCFtLNoK/XjTtXeaGic6 hp8cnIdJzz0DzheTSWl7pqi7C22iFpnwXOdIelrAPc+FOk2mW0b4VUFvjhkhY6Rgxku7rXt3dqDq Rl0mjbK9jeljTyGDzhaUbG6yY3/dW/8AWo/95cTq3Tl10nchRXiARSloc17D1McPofOFFSrrbd+S /wCnKy2NiDGVLOhx+ijzROrKjTVyZUU7jjy0HGVxzpHH8xOB9UvUPHTwtCyrN93FgxTNBxzkqMNz NfVOrZAZziIflaDwFHYld74WBeXDBJIQHGSVvdM3qe01kc9PI5hYQeCufJ5TzyDlEWXt++Xp2xkb 4AZ2tx1nyob1lqir1BcJaiqlLuo5AJ4C5ATPa3g91i5xPJOSUSu701uHd9P251DQzlkBycBcTc6g 1dbLO45dK4vcfqe685JBSPPKgX8kFIc8rZ2CyXLUNxbQWekkq6otL+hnsO5RWsPsmOy7g7Ua1HLt P1f6Bv8A1Wi1JpW96bEBvdumoxMSIzJj5sd+yG2ixygpoGEUhwOUBPygd/sgAme31TA88LYWe0V9 5rBSWqlmqqgtLvTibk4Hcpsa4IPde+ptVdS3E2+oppY60ODDC5vzdR7DC2cmi9RRV8VHJZq1tVK0 ujj9I5cB3I+yg55H2XtqrZWUlwNBVUs0VaHBhhc09fUewwvrdrHc7M9jLtQVNI54JZ60Zb1Y74VG twnjhbyi0rfq2lZUUlnr5oXjLXsgcWkffC1dZST0VTNT1kMkFREel8cgwWn6oPOmttT6bvVRSCqg tNdJTOb1iRkDi0t9847LVYI5QI9kAcLaRWC7z0oqYbZWyQFvX6jIHFvT75xjC1mCgWElsorLdJab 14rbWSQ9PX6jIHFvT75Axha/v2QY4TwF7I7RcZIPWjoat8XT1dbYXFuPfOMYXjAzj6oMUFe2K018 wDoaKpkDhlpbC4gj34C8ksb4nuZI0scw4c1wwQfqtIxWJPsmOEYUGPdZIwkAgfH6JpJgfREJGE8I /kikUITCBICaMIhIAT+yECxyjGEwhAIQjnKAQl3QEoflCP0QoDKEDhMfVAh3RnlNLygM8phJARTz whCEDQgI8oEmOQhHhQCEDumgAhIJnugPCEJ4RQkjCfjCAQeyEFQL+iYR4+iEIEIB4KAEUD7IR4QO UB2T4PdCMcIEhMIKBYRjKD3QECxhCO/CaBfZPPCPHCO6DFPKeEiOUAghGM5R4QHhLssghAkICYQL wjCaSAxwjCaOyBYGEJpIGUZ4QEeUAgoQijyghLsgoGjPKQTQHhA9kkIGUJBPyrAISTQCaSEAhCEA EIQgEeEJIU8e6SCjuiGkSgoQCSYQgM8JJpIGkmhAJdk0H2VgXdNAQiBL6JpZVDS7oRnwgChBSAQN CPI5TQJLymUgOUDQEeUkDylnKZKPdAkZSynlAIBwhCoBhNLKYQCSaFQIQEfRAIR4SRDRhBKEByjs hJAJ5SxyjgKgyU8pJYwgzCSRJTCAxx3R+iClke6o+DvzE+SsJT2ws3Dn3WEgXmjqwHdBOChqCOVW Rn6JlLsUygXhA7pkJDhBkO69FM0GVufdecd196c/3jT4BVFt9r4xBtNKYxg+jKR9+kquNmustNdY qkPcXB2Tzz3U3bN6qo6uw/wSpcGjpLTzjIIwuUj0FbqDdGkt7KuOW3zOM2GnJjGfylT4PlYHTE7r nY6Kpqqf03EBzWvGSBjgqF927xW1mu6SjmhfBTwkCIO/9oM/mUh6r1pT2G7262UvS5hA6uk9gOAF r9y9OU98rrHXQytbX+qyNo6uAw8kkfRJSu5ulHR11tt0NxyYeuNwbnguxxn6KPNNajmrdyZLMx7T RUtW8xBvbHhddr+0Vd70/BQWqshp6lkjXeo52BgDB+q8Vj0rbNLOtLacskrXTgz1DiOt/Bz+iqOo rKyjkuZtlVjqkj6gD/iyVH/xGYZt4xoAAFXGAPphanda5y0u5VoFLNjMDWu6T5Livf8AEZI07fUk fUC91RGcZ5OByrErgvh7uNQ7VMdH6rvw5BJZnheX4pImt1rQObgf7GAcf8xXUbBaUlt8btT3SRlP T9J9JpPJHklR9vxqOm1Hqxk1EcwwR+iHe+CSsz0qM8LrdunlmpaANcQTK0d+/K5P7LttqbdUXLV9 BFSxl7w8SH6AeVfgW8v1qhu0NrgqpDHFHKJMN7vPSBhRnTVcettUM05dIxJQ26rkcWk59ToPGV0+ 8U9zodJx1loa4yUrvUlLTgtZ04JUYfD9UGr1lLO4lz3sc9xJ7k8qiYbzPeqa9UlLarb12uNrR1MI AH6fRcNvjbaCyzWjUbaYfjTUNjkI46gBnn9VsNb6qrbduPR2mnlLYZY4yQPJK83xLfLpK1+R+KGf /Ckm0vTsdttRO1RS1Fa5oawdLGt9lxr6in3D1LFYrpEH0lBVPke3P5y08Z+i2nw+0lRTaNdNPG5j ZpMx5H5gPK0G2NDU0O694irIXwykvlAd/lcSQf1TDvG2mXWSQbnW3KgvVJQWyzyPtcTGt64wA0fT 7BcpuJp+ltOp7FeaJphqa2pEE4ZwHAAHOPfkr06t1ZXUG4tPZoHBsEjYy4Y/zLcbn00tTVaVip4n SP8AxrnYaM8BoyVF/wC3J/E3O+HR1DHG4gST4cB5HSqpkAdlbr4gtP3LUNltdJaKV88wqCXdI4aO nAJ+ihbdbbSHQ+lrNUunkluVRK5lRz8nYEYH0XbLWppyxl3dotwPAXR6HuENr1BR1szepsUgcQO5 wuc+6+1Nn1Bgnghc66L0aF1E3U9HUVsTS2D5WsafHdR3dtbNvOoLLbqfLZaSrcJXf5snBH8lu/h8 jkj0P6kzXNa95LSRjI5UQaXpapu7P4eaGVsn4p0hY5pB6SSQceymPrst7WN1fQV9bPaBbXhjIZy+ YF2OpmBx9ey53cbTVu1pfbLaKp5EdK988zWdy0tGB+uFutbXWW2XXTrYP/jmd8bv2C2NVRQQ6uoa qOMCeaKYSP8AJAAwpKWNHNeqazXmksNHb5GUUbAxpjjPRyOBnsuO1Hpqm0nr+z19nc6Bt1ncyeBv DeMcj75XR3fWlRR6/bYIWtDHdPPnkZT3KjdLqjSLGNLiKl7uBn2W9bl/6c9/tI6HVlLcqmqtH8LP THHM41PzdOW8Y+/lRF8U8tNPbrPTxPYZ4pnueB3ALQF1+/Ooa7T1rt9Tb3vZ1SObIWjgDAxlVe1H qCsvdWZqyQvefJKmHrdXL2lzZjROkq7S1VXaljgqKiRx6RI/HptGewB7qB7pCynudVDD/umSuaz/ AJQ44/kpj2r22rdTaeqblJdX0MQJbFGxuerAOSfZQ5c2uZWzseepzHlpPuQSMpGnmByV2m1mg6jX V8fRtqPwlPGwvfMW9RHsAFxIz/JWE+F58UNwri94aXxgDJ5JVpEbaj2/qLZuH/ZakqPxEhLA2ZzO kfMPI+i6zVOxdztlwtFDbK78fUVznh5MXQ2JrcZcTk+6kO/aarpd9Ka4MpXOgmAc2TxhowVK9S+O TVNIxjg58UEhcB3bnsmWp6Zlvyr5J8PbY3em/VELZ/LDTdj/AOJcdetntQ0OrqayUjfxUdTzHV9P SzpH5iRk4wrA6p1/T2TVM1rbbfxFUHNDS1g6nk9sFbqxV9xuOpIzdLZJQdEDzG1+DkeeVjbWkJyf DvUNd0HU1M2T/KaZ39er/RRjuLoW5aHujKauPrU0ufRqWt6WyEdwB9FLG6Wpbrad0qiC3GR7yWNi iaCeokeAuJ3krdTVv4D+1lDLSEdRg6xwe2VtJUYH7KUdltYUGjrhU1VRAZHzMDOoeAovC9NHG+Wd kcRwXEAZUVaPTW4lfqfWENJb4/8AZXnLmtby1o8laj4smxvoLI1rmmSOWQkeQCAux03a7dtntw+6 QQ+rVuibJNM7lznO4x9APZVt17qqq1HcZJ6qQvy49Lc8BJ6S+3FAYJysTyfopH0XtPe9XWGou9HP TU9PH1dImBy/pBJxj7KOpGGN72n8zSQR9UaY/wBVImymjv7V6rhE7GmhpiJZurscdh+qj1uPopn+ HKmranVANKeikiHXMScA+w+6losBUaCsL9SUlcLVRNZDC9oZ6TfmJ84xzhanSekaewbn3etpoqeO Csh6o44xgx4HIx4yu8nikffYKgFohZTvYQTyScngLnrRRVNNuJdp6iRr4amAviaHZLABgg+yg82o dBWu6ajob2ynjbX0soc5wA+b36vc+y39TCw6toZC0dX4SUg+RyuXotWejuLc7JKMh8wDPpkBdbVc aroxnOKKX+pVRq6rRtkqtURX6ajhfXwggPLRkuPk/VRV8TlIyruOnGOAP+8zn2yF1U+qal25s9gB xT/iGvPPOcArQfEgM3rT/jDXn/3QWvHJbZfpLvlj/wBu21Bdv7KbdU1ZSsaPQgia0Y4weFCehNMQ bm7i113vP/q7MTTRt/8AaOHYH6cKU95iW7TgD/JAP5rlfhiGKq7lx7tH9FqY/wDDjlfbnjlb5c58 RJP9oaWn1F/AYaNzaSEimIaz5GkjtnsOPC4K57KWefcqOUZjtb2OqZKVo4LgeGj2B8rr5LrSnV01 mbFJ+LdXfii7p4LRj/ouxqCHawYQRxRvB58lxwubs5xmoaGHUR09DSuZTQ4pQxrPkGR2z2HHhR/c tk7RNuUx7XGO1PjNTJSNHHUD+UewK7E3Wk/tbNZ2xv8Axrrh+Kc7p4LRgZz+i7GfnWIPGBRPH6lx wrUc8zUFvh1D/ZuGm6KeEfhhGGfIOO2fHCjuv2PtU25TS17mWh8Zqn0rRxkO/KD7Fdp/FKT+10to ax/4x1x/Eud08Fox5+y7Gb5tZuIxgURH6lxUHOsv9thvv9moaYNp4W/hRGGfKOO3sOFXbfDQtFpD VkBof/UK4GYQ9hHg4LR9FPRuVI/VctpaHGt/iJqT8vGO3f7KPPiqGbnaD5ETv/MtybS27jvNn9Ux 6mt34VtMyKChiaxrQBgADAVbN7KYRbk3wsaAHTZwPspj+FsYhuxPf5VEu+Lv/qgXrnH993/RXx94 5MeTrySI6P7JZ91kQsSsugQEIQMIS8p90AhJH2QP7ICEFAeEykShIlCPshHhAiU0dkDtwgPCRTSK AwnhCOyAT7IwSkQoD9EAcoCaASKAmgQT8owhFGE0keED7IzzwhI8IGEZQn/qoFlGeUY9imgEI7IQ gCEIyimEIHKBwUAjwhGFAAIR2TRWPlNCMoDymkmgM5SR4R4QCPCBwn4QIjhMBB7JIA9kIQgYR2KX hAQM8pIQgEkEd0eEDQkUIH5Ql2H1R5QNLugoQNJNIIBBCAg8IHlGeUiU8coBLP7J9wkEU0kyjwgP COySEDykgcIQNBPKOyFYBJPwkgYR3QOEIEmjshAJfdP+aEAOySEIUICEIgRlCSBhCQTQHhASS7IM vP1SQEIBCMIzgKwAQEBHZECXH6p90KwCWE0h3QMJd0d0DsgCmBhAIQgSZS8oQATJSymgEijlBQIo 9kd0yEAjyhLygfhGfZBSPugySQE/K0BB7o/VI90QxhLwhCA8IQjCQHdHhPygqhBBQn3KAwlhHsjw gBwUITQI/wAkuPqn3CWFR8cn+axm8FZkZ7L5zcFeWOlYNRlJiy4/VaQeED6oCMKgzyhIlNAx3X1j OOwXyHH6rOPPVxnKg2tBcZ6N/VDI9jvdpwva2+Vjan8R60glHZ/Vyus2q21qNWT/AI64k01liOXy djJjuB/1Wym0Xp657j09ps808VpaMTvdL1FzhnPScIrgqi91dTOJZZHukH+InJWzGsbr8hNXMXR8 NPV2XWbj7YutOpLdSacgqn0VW1rDI93Xh5Pvj2XVXzaHT1qZaWzV1VHLNI1s4dICXDHOBjjlEqNo tf3pox+NlOf+JYS66vLntkdWSdTPyku7KXrjszpK3wRz1Vbc4WSODWkzNOSR2/KvJddj7S2ptrKO 41/p1MvS4yOa7DcZ4wByqiGq/UdbWVjayad7qhuMPJyRhZXjVlyvFPHFcKh8wjOQHHsu03B2hrLF cab+DOlqrdMQwvlILo3eSccYXz3T2wptGaft9dS11RUT1EojkbIB05Lc8YVg5Vutrt/DP4d+LeKU NwGA8YXLVMplcS7P6+VLmmtnY75o7+IwXV/8Wc0ubTta0sB8AnuomuVHU26uno66Iw1MLul7HDGD /wBEHwyO3ldDpXU1Zp6sFRb3+nLjBIHcLnUdXTjhBJOoNyrtebXJRVExEUow8N8haHSuq67TVWZ7 e8MdjBP0XLtODwTyEOcQO+QibdncdZ11be47vJIHVbMEOPjC9Oqde3HUlPBHcZA9sJy0eMrgy7hM OwDlDaWbFu9d7fQxUkZYI429LccLwwbk3Kl1DLdo3B1VK0McXeQOyjIkOPJI/XssuvPvhFd5cNb1 tXqNl6lcDVtIIz9Oy6v/ALZLlLUwVMjWGSEEN54Ge6hdr8ds/qgSd8gIieDvjcC0fIwlcPuVr6r1 jSwRVRAjgcXNaO2SuA9TGPosHOB/McArQRK+9JIxkjS4ZGeQvh2GQENPKgnfT29dRbLTT0UdJG1k LA0BvAwFqqLc19HrKov7oWyVM7AzJ/wgeyiBr/lP7J9Z7cnhBN1+3Zlutdb6uSMYo3mRjPqf/tLb yb4SyVcNX+Gb1Rtc0NJ7Z7qvnqZbg8rFr8EnJP6qaEoV24D5tat1BJGDKCCG57Y4XcP3sZNcKetk pQZIWuawZ/L1d1Xr1cnPcper5zytVNJu3F3X/tPpqptbIWsbOAHHgng5UIGQtd74KxLye/jysQVE rt7FuNebRajQUc/RTkEdOFxtXJ61Q+U93uJK+DiUxnCqERn7rp9IaiqbFXx1FK9zSwjIz3XMhMOI 7KKs9BvjSi3tIps1YZjrIGcri7HuhU0eopK+pkdIJD/eD6KGhM4YwmJXEec+6C0jt57KJDUigjdO e7+hvUf1XMSbwSO1OLhJn8PjpEY7geygT13AALEyuJJzkppdrRS7wafdP+MNujdUEZ6yxvV+/dQx u7rKTWNxjndlsEOfSb7A91wYmf0kdX8183PcQOo5CqMPK2FnlZFWxSSfla4Ej9Vr+5WQcR2PKKsL rbdK3XrQD7NSsc2V0bWEn6KB4mmaqbGCAXOABPZeX1X5BJSdISct4IUFtrNqGxaK24ipKWrZU1Hp fM0EcucDn9OVU654/HzFn5XPLh+pX1FdN6fSXHBHuvI95e75spTb5s/dSTtFqlmnb3HLO8tp85c0 Huo37LON5YctOMpU2uC7dqyOubaxzz0CIxhn38rQ2Xc+2U2qrncat7nRVAxG0HPSMKsrKt+AC/8A ms3VLy3HUobTZDrShduk+/SEtpnydeB3HACkyTdSwvvLa1z/AJRCYhz7nKqO2eQeefusjVS9s/zV VNLNY0H/AGry397sUr39WP0AXq3d1rbdUXO1S0bv7unBDifq4FQV+IkPk/ukKiTPOCPuppYtpUa+ 0ld7BDRXVraiBrGh0T+xLVEdo1jTab1vXTWWNtPappupkTTw0e32UVCqkAwO33WDql5Pbt25Wpet M672t7JubpvpFzwx9xZD6Yd3OO+P3Uawbp1J1O6tlkJY53Lc9goRjrZABl2PplfIzu6y4kkn6qai rgu3F01kXUBjri2D0g8jnHfH7qNafdSoOqTVyyZjc7GM8AKDW1s2OHHH3WBnf1Fwccqi4Em4WmGO /i/yOuIg9MO8474/dRvR7qTnVDquaT+7e7t4AUFCtmxjqOPusTUPBznn7qC4cmu9Lseb0HRPuIg9 PqGM474/dV63B1RNq2+B9RJ0sDsNJ56QSuG/iEpb0tcR7rzmd/USe61EW10FddF6Ytkf8Lk9N74m iZznZL3Acn9VXXdu4Q3PWV0rKU5glk6mn34XNfxCWNmGvIJ9ivJPM+X857/qkvGaSzd285S7rPCx 84UaYnhCzwkRzgKDEpj2QR7oVCKBz+qYCCEAl9UwMp4HKiMfCPCywPKXAVAM4S+6YJ5QG58oFhMJ lvCOyBIKyACCFBiEBP8AknhAvskf5JoIGEC8pnsngYQRgIMU0JYQNGEgPomihMICCgAjCaAgSaaR 7qAHdCEFFNLymEIF5TKXlHlAwhAQgE/KSFA0eEIKKXhMJAoQMpIQgCknnhGOEBhCB2QUDSPdGUID KEk0CP2TSPdPugfhJCRygfhLwn4RhAeEfdCPKBZ5RnlB7ICAR3RhCAymkEIBCPujugOxTSS8oGhB +iXjygyRnlYpooKPCEFAIQEIBPsUvHujurAfyQjyhAJpHuhAFA+qAkgf1TSQgaQQgoUj3TyhCISa RQEBnCCgoPZAIHZAR5QBQEYSQPOEfojCPKsAOyOyD7J+UCRjPCYS7Ihdk0vfKFQeUfRH6o8oFjlZ LFMoAnlGOEin4QACf9EslGUB2R4KPsg9kCQj7ox3wiBNJCKaEk8IAFARhGfZUNLsgFBVQJ+Efsln hAYTHZJAPKAHdMpZ5QSqBB7oHdMoEf5oCEkDzz9EYQllUNGPqjwnlEeYHk4WMqzPBIWEn7ryx2rB vOfZAQw4ynlaZGUIwgKhHugplJAwOACvTSAGRp+q8y9VGQHtLuwUotdo8fhtl5nR/KRSyuyPfpVe 9M3aajulPUBzi4OBPuVNe1epKG6aZ/gNWQIzGY3DOCWnuuRsuhaGh3Pht0lZFPbgfWDmnlo8NP1U +FWEsUhuFroqupg9OUtDmtcMkcd1CO4F5q6/cunp6iF8EcD2tja7/E3P5v1Uiak1xT2rUdFaafpe wNBd0n9AFr9xNMw3PU1huNNK1tY+RsbwXcCMDOf3VlTTvb3Q0VeLbHcT/dRyte1pPBd0+foo70Tq aa7a+ktpe00lHPN6QByCMkArqNx7PX3+1UlLZ66GmlZKC97nYy3GDhfCx6Wtela2zxUQa6pLnmad xBe/LeSfplVHS1FTR1NzltdSG9QY14B855UafExxo+2Dz+M//FK8uvLnNT7u0baabDHRRMdg+cnK +3xNSNOlbSxpBJqerA746VYOb+Ha51M19fRSSEwCMu6fGVzHxKRNbuLlgA/2SLOPPdd9sJpmWzUM 2pbvIymp3sPpNceen3Kivey/0+o9Zy1lHn0WMbCD7hueVBwC6DRGm6jVGoKeghY5zHHMnT4YO60I C7XbO+Ps18hkE/4eJ56ZHjv0+VRNd72OslwgoP4YHWwsdmckl5kbxxyeCtLrnaCiNVaqbTdrqWRt k/2uoEmephxwAT3XdT7oWWnfSwUkofGfzyOOcLT6u3Bo3XWgjtNaY4nO/wBok4x08dvbyptNNffd h7TWx0Bs75bcGu/2j1XF7nt47ex7rTa42eo47haqbTdurvS6v9sqA/qBbx2BPfupJqNyrHTOpYKS YStccPlec4C1GrNfUTLtbYrZXERyv/2iTjpa3jt9e6so0N92Gt1W2gNhmmoWh3+0/iCXl7eO3se6 0ut9nqOC52ml09TXH0S8itqHHqaG8Yx9e6lep3BslK+lp4KgTBxw+R7gcLT6p13SMvVBBaq8elM7 +/ecdLBxjH80HJ33YKjqX0DrDVS0sGf9p/Ekuc5vHLeOD3Wm1ts7RUt1tVJp+O4mJzyKyd/zNazj BH17qZajX1kpZqWljqWzdfDpSeAtJqfXNPDfbfTWyvjMNQ7E8jgOlg8YPuko4e/7AwTS0DtPVssU JP8AtP4o5PT7twO/daTW2z1LQXa1UVikuL2SPIrJ5Y+pjG8YLSB37qdJ9cWWmnpqVtU2dz+HSEjA Wl1HreCmv9DSWuujdFUO/vnuA6Yx4xz90ojy8/D+x81AbFcJfw7nf7SakDqDfduB3Wk1ns/SW692 qhstRcJmSvIq5pYx0wt4wQQME91P02s7PTT09KKpk738GTIAC0motZw02oKOjt1ZE9tQ7+8cQOmM ffPJSURje9gHOnoTp+5SyUz3YqHVAALW+7cDk/otHrLaWC03+1260VtbUNncRVTSw/LCMjkEDB8q xkmq7TT1NPS/i455H8F4IAWj1Dq6Oj1BRUNDUwPbUOzI44xGM+/lKIlvmwNQ2roRYbi+opZXYqH1 DQ0sbxgtx38rS6v2kZadQ2m2W24z1H4l5FTJJBhsDRjnI4PlWTl1RaqepgpXVbJZZB+cHAC0eoNV R0eo6Oho5aeX8U7l/iMfUoIdvWwVfHW0LLHXmqpJXf38srAz0h7jHfytLqzaT+E6ltlqt9zfVGpc RPI+DpbABjkkHnyrPS6gtlPVQUr6pks0nHU0jA+q0N91PHR6ipKCmdTTOqnZL8ACMfU+U2iE7zsJ c4bhQxWeubW0s5/vpnMDPSHv35Wl1TtLJadS22z0d1FW+pJErzD0iAZ7nnlWnkv1up6qClkqWPne OC08Ln77qKGj1LS2+FtLPJUknr4wwZ8lNmkF3rYW9U1woYbRWMrqec/3k7o+gQj378rT6o2ons+q LZZae6w1UtWcSP8ATLRAOOTyrXSXq3QVENLJUROneMfI7gLnb7foKPU1LQRQ0dRNVOyH4B6BnycJ s0ga8bEX6luVDBbKqK4U9QcSVDWdDYRnueeVqNS7UVtn1TbLHDdKasmrMl72MLRAM4y7kq2r7tQU 9RBSS1MZneMAMIwubvt6paTVFNQNpaWoqKoktkwD0DP+I44Q0gC7bG6io7nRUtDLFXw1Bw+pY0tb EM93Z+i1upNqrlZ9T2yyR3Gjqpa4nMjAWthwcZdn6K277nQ09TBSyVEfrvHDWEYC5u9XWjpdUU1A aGkqKmpOY34BLR/xHHCbFebvshqaiu1FR0boq+Oo/NUxNIZFz3dla3Ue1l1suprbY21tJVVNccdc eQ2Lnu7Kt+64UcNRDSyzME7x+VhBC5e+XCgpdU09E63UlRWVRzHJwSB7uOOE2WK6XjZTVFBd6Khp xFXMqe9RCD6cXP8AiytfqHa282bU9ushq6Kqqq3s6JxDY+cHqyOFcU11JDPDSvmjE7mjDGHIXK3u uttJqumopbdTz19ScxSAgkDPcnwm0Vvu2zOqqC80dvhjirW1PaogJMcfP+LI4Xjv+1t7s+prbY3T UdRV13LXRPPSwZwerI4Vx31VNDUQ00k0TJ3N4Y12Vyl7q7VS6qp6SS3RTXKoOY3ggnHbJPhNqrZd 9ndU2+9UVuZDFVmp7T05cY4+f8RI4Xiv+2N9s+prdY3vpKisrhmMxSEtbzg9RI491ct1TTQ1ENLJ MxlQ5owxpyuTvc1qp9WU9LUW2Oa51HMT85OO3J8JsVquu0WqqC+UVrFPHUvqhls8BLomDOD1HHC8 l+2xv9n1Nb7FIaWetrW9UZiky1ozg9RI4VzjPTxTQ00krGVDmjDAcrkr06zQatp4Kq2Nlus3MUg5 OM4znwmxWS7bTaqt19o7V+FZUzVQy2WAl0bRn/E7HGF5L5tpqCz6ot9hmZTS1tcOqIxSZbjODk44 wrqOnp4ZoqeSVjJy0YYDkhchenWaDV1PDVW4vu03MLwckj378BVFYrxtVqm236ktDqMT1FSA5kkJ Lo2jP+J2OMLz3rbjUNo1NQWKeGGSurGh0Qik6m4zjk+MK6rpYIpoYZHsZMWjDO5XH3ltlg1dDFU2 9z7tMMxPDjktz378KFVhuu2GqbZf6S0y0Pq1FSMxuhPUzv5djAwvhfNvdQWjUlDYqinjfcK1odE2 OQOGM45PhXVc6GKWGKRzGTdIIYeSFx95jscWsKdtXRPdeXjMLwSXdJPg54CCrl0231PbL7SWie3l 9VUjMZid1M7+Xdgvjd9v9RWvUdFY6mjabhVgOiZHIHAjOMk+Fdp3oRywseWMm6R0tPJC428U9hj1 jT/jKSQ3p7cwu6j1FpPjnsi7VZum3eprbfaS0VVuea2qAMYjd1tIzjl3YYXyu2gdRWzUdJY6qhP8 RqgDExjw4OBOM58K7jxTtmiY4xicNBa08uAXG3imsLdYQfjKaf8AjRGYHdR6i0nx9Fdm1WLlt/qW 136ks9VbZDW1IzE1hDmnnH5hwF87roXUVt1FR2OroHC41beqGNrg4OGcZyFd4xwNmha7obP0/KHf mC4y80ViGsKaasgqP40BiAhx6i0nwPZTZtVW6aE1Ja79S2ertsorqoB0TGHqDgTjuOFjdND6gtd/ pLLWW+RlxqwHwxNId1gnHcK7zo4RND6jYxOGjpD/AMwXH3aisX9sKeWrZUi9AYgOT1Fp/wAv0V2m 1ULnonUVuvtNZ6q2Tsr6gZijAz1D7jhY3PRWoLbfaWy1lulZcaoB0MIIJeCcZyFeIwQetC57YxUh o6ev8wBXHXSisbtZU89Y2p/jTR0wcnJaf8o9lC1U65aL1Bbr3T2irtdQy4VABijAz1A/XsvncNHa hoNQU1kqrbUMudSA6KHgl4OeR+yvI6kpzPA+SOP8S1o6DIPnblcfc7fY3aygqao1QvYb0w9+rpJ/ wjHZXZtUy46Pv1Be6e0VdtqGXGcB0cGMueD5Cwr9H3+ivlNZ6q11EdyqGh0UBb8zwfKvM+jpnVUM 74ovxbWgMc9vzgf1XG3G2WN2tIa2qlq2XtjemEHv0H/KMdlNrtUmu0jfaC8w2qrtdTHcZwHRQFuX PB8j9kqvSV8o71BaKq11UVynAdFA5vzOBzgj9led9DSvqoaiSKJ1WxoDHvA6wD7eVxtxtVjOtae4 1VTVC9sb0QtJ56T4aCO3dE2qPXaVvdFeIbVVWyqiuMwDo6dzMOeDnkfsV867TN6orzBaau2VUVxm AdFA5mHPB7YCva+30klZDVSQxOrGNAZI8DraD/NcdcbTZJdawXGpqqgXuJnRE1wAIac9gRn3TZtU Sr0xeqS6xWyqttVDcJQHRwPjIe4H2CVVpq80d2htdVbauK4TNDo6d0ZD3g9iB57K9b7ZRy10NZJT xPro2hrJXAdYB/muQr7PZ5daw3Woraj+Mwt9OJpaAWtOfytIzjvyqWqgVNgu1JdI7bU22rjr5ACy ndEQ9wPsE6nTt3prrDbKi3VcVwnAdHTvjIe4HsQP0KvY+00MtfDXS00L66NgayZ7R1tB/muPr7JZ pdb015qLhKL1Cz0omloGGkngAjJ7lTZtUCew3WmubLdUW+qir5ACynfEQ9wPYgd0VNjulNco7dPb 6uOukAcyndEQ9wPYhvc9ir3SWehmuMNzkpYn18bA2OcgdYHsP3XH11ktMuuYL5PdJBeIWCGJhAAa 3nAA7nueVdpap/UWa5U1wZQ1FDUxVjwCyB8Ra92e2Gnkons9yhr2UM9BVR1rwC2B0RD3A9iG9yr3 Pslvnu1PdJaSGS4wM6Y53AdbQfZcjXWO2Sa2p7/PdHfxSBhghZ0ABreeAO5PJ5U2qnlRaa6mrWUU 9HUx1jwC2B8Tg9wPYhvcpS2yugrGUU1DVR1bwCyB0Tg9wPYhuMnsr4SWC2z3eC7S0kD7nCwNjnLR 1tGPH7lclV2K3Ta4g1BNdW/xOnZ6MbfTA6W8+PPc8ptLVO5LbXQ1baSaiqY6pwBbC+Nwe4HsQ3Gf CxfbqyKsbSy0lSypcB0xPicHkHthuMlXydp22z3qC8SUkMlyiYGxzlo6mj6fuVyVVp63S67g1HNd Yv4nBH6MbPTAAbzjjPJAJ5V2u1O5aCrhqm00tLOyodgiJ8ZDiD9O6xNFVMqhTOpphUEZERjPUR9s ZV8Habtk99hvUlHE65xMDGVBAyBjx+65GfTVDJr2HVEt0g/iELPQjb6YAaOR798E8ptNqeGkqG1A gdBKJ3doyw9R/TulLTTxziB8ErJjjEZYQ4/p3V8DpW0Tagivj6KJ1zjaGsnxyBj/AN9clNpijm1/ FqiS5UhrIY/RZH6QAA5Ge/fBTaqeGmmEoidG8SH/AAFp6j+ndJ0MjZRG6N4k/wAhac/sr2nSFnl1 JHf30MTrnGwMZNjAAx7dvPdcpNpOnn3Bi1U6voTVQx+i2H0h0jGRk4PfBPhNop4YZA/oLHB/+Ug5 /ZYPY5jiHAg+xGFe86Os0mpI9QOoIjc42dDZcYGMYzjtnB7qAPiO041tZBf2VNM58x9B8MDAOkNG Wk/Xwk7EGoTIwjHCqljCaAmO6ikUYTSQPCEk/wCqAyhB7o8qBoAQkSin5QjwjwgD4QjukEDQhCBp ICfdAkFPCX0TSgIKMpqAS8p+UggPCEHlHhAk0BCug8cJeEHtwgKAR9kZSQNHlPKXhAICPshAHCXl BQUB/RNLKEAgI8ICACPsg4wkgEwgclB7oAoKSCgaD2RnlJAYTKAkgCmhGUUH6oBQkgaQ+pQChA/C EIzzyrAISKAUDS8o5TQHdCAhADCMpI8oDyhCEQIyj6JeUDQe6Dwg90AgoBS5ygY5QeyPsjKBIR5T QAR4QhWAQkl2QZJFBQeEQcpdkA47J58qh+Uj3SRlA01jlMIDlJCYCACEIKBpZSyjyibCMoPdACBe VkeyB/JI/uigdu6ZS5RhA/CDwgdkFVNkT9U0JZwqH/RCQOT9EwEAUkykFQ/ugY/ZIo7IMvsl4QSg lAu6Z48peEApABA5KYHnyjxwiDAyn+qSfCDz/wBF85fdZjl31WEuched2rAHlNDexTVZHsgoCP8A VULwnhILIBAL6R8HjsvkvpHy7AHKDZ0FdU0bg6nlex3bLThe2O91sVT67J5BL2LurldltZtpNqUm 5XZxprLFy52cGQjuB7D6r1UmkNPXjchtstkk0VmYP7xxkyXkd8HwFF24Sa8VUlUKh0jzMOzyeVtW azu3Wx5q5eto4dnsum1/to+26wordYYKk0NU1rWyPPXh/wDi5+y6y+bRadtdVZ4JK6rY+Z2KjMgJ cOn/AAjHHKSJtHTNwL0Bj8bL1e/Uvk7Xl59Zsoq5PVb2d1KWrnsxpa3thdU3G5Qtmd0szK05Pt2X iuWyFtZc7VBR3OuEFS5/ql5aSGgZ+XA7qoh+q1LWz3EV8krjUg5688rO9arr7y2I187pvS/KD2C7 DXG01ZZbzSQ2x8lRb6lzY/Wlx1Md5LseF8t2NtafQ9utc9LXT1L6qR0cgka0AENzkYSJXNS62u89 qFA+qf8AhgA0NBxwuWmmMjick5UtWzZ03TRYulDcnSXRzOsUwA6Ptnv2UTVVNNSVUlPVRujnicWv Y4YIKUfLKzjeQ7IJGF8zygcHnhB7RVSNGOopmskIw5xP1yvGD9UE4CK9xrXhoBe7I+qDWvIOXH6L wEp9XGVUe78fMW463fqUfxCQ8Fzv3Xh6slBd2xkoNgbhPgAPdx9UC5TcFznnHbla8lLq/VBszdaj HD3g+OUnXWoeAXSO6vfPK1nUjKDb/wAXqcAeq4kc5ym68VLiC6V3UOxytQDyEZKDc/xurOCZ5Mjs eo5TlvdVIWl07y4dnF3K0pJz5R1fRUbwX6uyD+Ik6h2PVyiS/wBa54e+eQvb2PVkrSZx2KxDj3Qd CdR1ri1xqJOodjnlJ+oKySRr3TvMjezieQtB1c8ozlNDpTqa4OLXGok6x2OeVjLqWufK2V9TJ6g4 Durlc5nhGfPfCG3TnVNxc4P/ABMvWP8AF1cpSanuMszZX1MhlZ2eTyuZDk+skhNDqjqu5Oe2R1VJ 6jezs8pS6ruMlQ2d1VJ6zez88hctnHuservglB2J1jdDI2Q1TzK3s7q5WEmr7jLUtqHVLzO3s/PI XJtcc+EdWER2LtbXZ0rZjVyGVvZ2eUptaXSSpZUuq3mdnZ+eVx+f0SJ4zlEdoddXV87ZzWvMzezs 8rGo1rdJquOrfUvNQwfK/PIXGdRz7rIOQdwdeXZ87Kh9XI6dowHE8pT64uk1aysdUv8AxLBgPJyQ uI6sdkdRCNO7O4V3dUtqHVbzO3gPzysZtd3WaujrnVLjVMGGyE8hcL1/plPq8EoJA/7RLvJVNqTV OM7eOrPISn19dJLhHXPqHGqYMNkzyAo/zjnhPPA/6oJFduPd3VLal1W51Q3s8lfObcC7TXKOvNQT VxjAkzyFHwcRymH48lE0kh25N4kq2VTqpxqG9nEr5y7g3We6MuT5yaxgw1/sFHfV98LLPkH+aGkm O3MvElW2skqHGobwHZ8fZfGXce6S3VlzfN1VjG9LZD3AUcB/1KyDzjvwhpKDt0bs+qZVunLqhowH OPAXnm3Iuc93juhlDqyNvS1/sFG3WQDzx7Ia93goJUfund31bat02ahowD7Lz1G5FzkvMd1fIDWR t6WvPgKNC8pB5CqJWO6t3krWVhl6p2DAJ7AL4T7l3Oa+RXaR7fxkbehric4CjDrd4KfWccqGktf9 q91fXNrHSdU7Rgc8L4zbnXGovkd2kcDVxN6W/QKKw8tT9Q5VXSXXbuXR1wbVvkPrtGAB2C88+59w mv0V4cQ6rib0NJ7AKKuvn7o63e+FNJpMJ3duclwbWPfiVowMHheebdCvmv8ADeX4NXE3oafACiYv dhAkcPYoaTMd37i+4MrXEmVo6QM8Lyzbo1suoor1IGGrjZ6bc9g1RJ6pCPUJHKaE0neC4PuTa6Rw MjRgAdgF5Jd0qqXUsN8c1pqYmdDRjIA/+kqIfUOAPCPUcAqaTb/2w18l0bXPI62N6QzxheKp3RqZ 9Uw3x7Wmoij9NrfACh4v5zkp+ofdDScjvHWuuTa1xy5owGDgBeB+6dRLqqK+vYDURM9NrT2A/wDp KhwSOz57+6DL82e6Gk7jeSqfdG1zwAWjAjzwvBPurNLqyG+FjfXiZ6bW9hjn/qoW9TkHnKyExQT1 /wBs1S66trXgANb0iMdl4H7rPk1dHfXsHqRs9NrAOAOf+pUJuld4OE2zuHHKCfDvPUOura0j5GjA jB4XhfumZdYR350bfVjjEYjHAA55/moQ9V2e/KBK4nucpqCwv/bPM+6trHNPSG4EQPC1jt1Gv1lH fZIm+pEz02x+Pv8AflQcJne6freP6omlhv8AtnkddW1jwQxrcCMdgtcN1I36xjvzom9ccfphg4HY jP35UFCZwJw4pCZ44ymhYwb0E3cVjgREBgR+Fq/+1CB2tI766IfJH0CMcDtjP35UEescck5QJ3gY 6iQSrqGlj27z5uwq3ZEIGBFnhao7oU7tbMvbom9DI+kReM+/3woGM7scEg/dIzEj8xypoWTbvOx1 3FUcinAx6QK1bdzKN+tRenxMETYulsQHHVjGSPdQC2ctPByUCdwJwTz9UNLLt3lj/i5qSCKYNwIs 8EqKt2NXxaouzqmmZ6UPQGmMdsjz91Hv4h6+UkhI58pDTAk5P3R4WKYRo0BCFA/CWOU/CWUAmmki goHZCMqACEeUf0QCaEIBAQj7IAIQhAIQUdwgEIQUUI8I8IKgMo/0Qn4QJCD2QrAIQe6WUDyhJCUN CWE1AEJZ55QgoH2QjCR7oAoQj7IAIRhCA7IQhAJBNJAJ+UkdigCUITJ90B3QEkZQNJAP7oRTKEDs sc8oGn3HCQKEAAhId0wEDQQl5TQLyhH2QVQ0vuhA7IAIQhAJJo8IhJhGEZ4QB4KPKRTCAPKEvqjl A0kJoBJB/ZBQGEHkICEAEZQUgqHlLv3KEIGn3CSCiEO6ZSQqAdkeEI8oBCPCP0QHZZA8ZWI7oKBn hJBSRKEAo8oQGU/CQR90BlPukn90UwkUuyaBjuhJHdVDS8p+EiqAJpBLuqH3TSQgfhIoQgEdyjuj sgPKfhIFHlA+6OwR4RlEGP3WOVl4RhB5wVjLxhZu7rCX2K87tWDShJvJTVZAQhHCoPuhBR9kD8he mjaPWaT7rzDvwvVSODZQT2CC0tvP4XY6d8J6XNo5HAj3UB6WuklFd6adjnHDhkDueymbbnUdvvel jYK4gRmMxuGcZB7rktK6MoaPcwUE1ZFPQw/3vW04A8hpz5CirEWk/jaKiq6qAMn6OoBw5bkf9FBW qbvV3LdSFlTC+D0pGsYxwx8meD+qkS/68hodVU1rpix8LA3qLT5PGP0Xg1rpymrNdWS40czRVSuA my4dIY0ZBSVHe6goqCuqLcbk7DYXOdG0kBpOBnP2AUfbc6jnvesXUszw6CiMwiA7YyQuj3KstbqO koae1VsNOY5CZZHPIy0jHCxsOm7Vpe62ent/QZCyX1piR1P4HJ/VVHSyVFJWXGa3ThvXEGPAPnyo q+J12LJY8jn8RIf/AHIS1NdZId42RU83928QtODx25WHxPva+2WNjHAkSyOwDk4wEg8Pw8XOoqa+ WjkeXQxxucG5XAfEHE2Hcuu9NoDTFFwPspS2L07Jp2z1GorzI2nhlj+RpPPT7lQ5vBe4NRa0q6+l GInYa057hvGUSuJ8pj9kj+VAPCBn90kxgoQHlGUijurA/f6oS5QgO3skjCY4CBHsjwhA+yDLz9kk dkHsgAUiclCRQZJLEphUZfqgZ91j27JkogBKYSCQ7oMuQl27IJ90kDTCxJ+iB3+6KyBQHZ4WIKMI HlMnOEkIBAQUIHnCMpIQPKSEiM8oMvogrFqB37oMuU1jnlMlBkPZPssQMo/VA0wfCwccD6phBkey F8xwUwUGWTnjsmkjCIYGU8peEhwisikMD7lIoVRllLKRRlQZA8IJykl3KDI8D6pApIzhBlz7oz9U s5/VLlBkeUZSBS7IGSgduUuyWcIMs5CQKxJ/kgfTsgzOT2KCcDnusSgcIMiePZAcsTkoQZdX0WOc I8o5VDBKeeVjnlGURlnnhIH7lIH3S75KDPP1QCPKwCPOSis88p9isAAUyiHkoJyEJFAI8IQimmfC XsmoA9kd00coEhGEIphHlCMIBHdCFA0IRhAeEI8IQCEIQCEIH8kAOyPCEIoQfpyhGPZAdkAowj7I BCEIBBQgoBCEkDR5QUDsoApc4TCEByl5QEID6oQjsgPCPKEu6BoS/wBEfZA0duEvCPCAQPqg8IKA CEIKAJ5S+yaCgSYQUu6BhB7pBNFCEAIygEBCXZAyUD2CChADuhB78JIGTnCMpFAVDR90kZ5QHlNJ PwiBJHlBQGEI7BCARnlCBwgXlZfdL7oygCePdJGf2QED7p/ZJA5KBJpJhUJNCPsgEieEIH8lUPuk e6EIBAPdH3QgChHj6oQCE8IKBFCHJIgR37oQgEBHhMcd0DyCkUvKEBhCBnsjCKE0J9/0VgEZ90vu gqoEJDwnnhAvKaEKg+yEimgPCf3SR5QCEIHsgM5Ql5R4RD/+koyfojHHdL90HxP5lhNnI9ln5WMp 5wvPHVg3uUihqfZVAEY4QEHsqBCSfdQPsvpE7lfMLOPPUPqg2dFX1FG/qhkcx3gtOF6mXmsindPF M8Snu4O5K7ba/bd1/jN2vr/w1liBPfBkx9fAX0tGldPX3cV1FQmWGyMac5kyXkex8Ap8K4f+M1L5 /wAR6jzLnJdnnK2TNXXP1RIaqUyNGA4nkLptZbbT0mtqa22ennFBUhgZI49WD/i5+i6q/wC1WnLZ ebRSfjapvrdXrtMgLjwMY445SJtHbde3kDislJ9+pA11ePUE34mQSgYDurlStdNndK250Iqq+5RG d3Sweq3k/svJXbKWtt6tlNTXGt/D1DZHSOJaSA0DGOFaiIZNRVj7iK/1Xmp6urrJ5ysr3qauvBjk uE75nx/lJOcLrdXbU19n1FSUtHI+e3VUjY2TuHLCe/VjhefdnbqHRP8AC20lZPVOrOsOEjQA0tx2 x91INBV6zutZbBRT1chp2jAb2XLzPMjsnnKlin2gkrdFC5224GounQJDS9IDPcjOc5wonqIpKeaS OZjo5WOw5rhggqjDhId+yeeP0XX7caEq9b3OamhnZSxRML3Sub1fYAIjkQPYZR2Xf1m1WoIdWRWS GIy+pyypxhnQO7j7YXi3J0FVaFqqOGprIqr8S1zmujYW4wcefug4s90J4wkXcIAnujCM8/ZIqg7p 4QlnsEDKSfCAC5wDWlxJwAO+UCyj+q75+0+q47Q65SUcAp2w+u7++b1BuM9vfC4HOeyAP2SPCYPC R/mqEmgpjsgWEJntwjBygMITPdYgog7owSO6f15SHhAY5QF7JLbWstsVwfTSsopXmNk5b8rnDuAf 1Xkdwilj90FCAgD4RlNA/qgWeeEee6aDjugXZNPwl37IFlB7J4+6CAPogR+iFl6ZDOvpd0eHYOP3 QCCew+6DEELLGQjHfBSzjnlAAnOEycIHdZY+yDHzn3QO6DnGc4H2SZkjOUDx4TGPukho9kSnnwmk SMcnCyY0uLWsBeSQBgZJKEIFC21205d7LTwz3W21NJFOcRulZ0h5xnhaocoBY5WWEYCDFGMrLGEI MU0d08IEEY55wsscLEYzz2QCEeffKfAQJCaEC7pY/msuEshAsBLGCmSfb9U0CygJvY5h+Zrhn3GM pZygCl44Tx9UYygx6lkOQlhMBADH0QUcYRj9ECOM/RCYHP2Qe+VQkYTAymQgXP6p90EcIzz90QJ+ UePKPH1QYuQEyCQmBz2QHYBPynjugcKKSAnjJRjPA7IQYQgJopeOUZQgqA8JpeOUeUD8ICEygSED uhAIQhAIQhAI+qAjz7Io/ohGUYQHjugFCEAhHKPHfKAQUIzwgQTQEfVAH9UIJQgEYQkVAYQjlL7I H5wjCYWJQPyjP6I+yEAhHhJAJoykgEBII/ogfZCEggaAkeyO5QNxSS5KyKDH6nwmjwjIRQCg90BL KBk8oRlCBo7pIQNIoygoBNLOEKgCEZCEAU/KSEQFCE/HKA7hJCXlAAoyhCA8oQg+yASCflJA0gmh UCAUDnuj7IBMJZR3VQ0YSCWSCoGe6Ed+UKhJ9gknlABCWeU0B5RlGUsoGUvKDwEYRAhHhAQGeEZ/ mjygoD7o/VHfKPKA7oyhHdUCflATVUYQUFLKIEHshGeOEByEIH0R3QCAUFJUPKSaO6ASR2KEQ3ck JFB+yEAj9EBH6oPie5WMqyzkrCU8rzx1rFoxlCGjhCqBHv7ppFUIhPCMco8+yDIcnsvTRt6pm55G V58cZX2oyGSh315UFmpP9m2LlMR6cUrsEfdQhpO5y0V5p5W9RPU3gefopd0LqCgvulzYbgQITH6Z BOOFymjdLUFLuWaKasiqKGmPqiQHA9w0/ZJ6FiLbmooqSsqoAyp6M4I5blQRcbpWXLdeM10L4HMm axsbhjDc8H9QpAu2vY4dXQ2ylMb6dmGkh3BceOfsvJqnT9JVbh2evoqiP1pT1VB6vlDWY6UR3upa W21NbQyXQ4MAkdEHOAb2GSVH21moKq+andHUSdUdMyVsXsBlb/cuyVWp/wCHxW24QU7Y3OEzi7u0 47fVffT9jtOm71a6S2GPLYJfUkyC5x45J+6tR0ZqqKtuk9vmDTLA5rmg85OM5UP/ABPvIbp845zK f6L63e6vj3ofHBMDC+SNpLXcdhlef4n5WSvsTYnNe4erkA58hSK+3w8XKesqamlleXRRxFwBPlRh vjC2Hcq7tjaA3qYcDjwpd2UsY0pp6p1Be52QMmj+WMkZDfr9SoT3MvEd/wBYV9xgHTHK7gfQcZVL XKN5B8hWE+Gdg9e4H/5nyq+RjlWG+Gfme44/+RjCCZ3XGhZVujc5v4kSiAN4LiT/AKKK977NDetZ aXoqtzxA4OD+j8xBd2C+ENY9++M8PWfTFUMDPHYKT6yClk1xTTVQYXxUhEZcM4cXePqlTSOjstpi pjmZT0dygk6CGSSSnpDscHt7qNtC7cUNZrG42XUc8pNM70miB3SXu98kKxNkluR1PdRXxyR29rum mc78rsnwoxoaOqot+J31ET446qo9SIuGA9vuFNtafOLZfTNJcDRXKtrH1FRITTMZKAQzsM8clay1 7HQSaxraG4VcwtjIvVgMbgJCCcAOJGFJOpyf+13TQ5x6JP8A7orq2lo1lISQOqjaBnyetalZ0rxp baGju+tL7bamqqW0FA8sjc0jrdzxk4x/JciNFxO3Jm05+JkZRx1JiMxAL+kfyyrJaGo6im1pqiao gkjhmnzG9zSA4F2eD5Wj0Tp+nl3Q1LcK6n/v2y9cHWMcOOMhRXKTbF2apgnFtutxNQ1hLGysb09X jJwOMqEp6Cosd7mpKxobU0spY/ByA4K5WmrrWV19u9NVROjp6aXpicQQHc+FVvdGF0W4t79Rjml9 S57cjGQfKvwRYvTtQ+v2gnnnPVI+jlBJ/wCVU6laGuwrg6RhkZs8YXMPqGlkwMcnIVQathjqHteC HA9JBHlSJ8vgc+F3e2W3s2t6ioabgyhjiA6SY+svJ8AZC4dnf6KY/h0kk/tdCzno6SXAduyqyPTR bAXGUSOrLxFTH1XRxD0C8vaOx/MMZXK0e02oKrWMtiLPTjjPW6rLfkEZPDsZ8+ymvc7WjtL61t3q Nc+mbB1hg7Fxzn9Vv9t78zVFZcrm1gZ1NZG0eQAptNIeOwdR63ps1JRufnGPw7s/+ZchQ7W6iq9X zWJsBjdF8z6lzfkDD2d+vsp4k3GpotSzWuktj6itZK6NrI2DqcQV5qHUV+k19ORY6qMiJnrQhvLW c9JP81diO/8AsCunqlrL/bnEePTdn9lx1BtlqKt1bLYRTGKaL5nzuafTDCeHZ9jhWddDQ3evnrbP Vvhu0cYjDHPwwO+re5K+O20dxlul7ffGFteDG0kjgs5wR9FNiEXbDX4SdEd3tT3Zx05eD/RarSu0 94uWo6qgrmxU8NC5plMjiPVaT/g9+ApvfuHaYNQS0MFA+auZI6MNjblziPouH1Lqm4VO5NMPw89u 6xGwwyNLXObnuQr8Du90tBOvmiLfZbGKWl/CytezrPSzHSAeyqVcqSSgr6mkn6TLBIY3Fpy0kHHB 9lbrfKtuFHpW3i1eq6plnDOmMEucOn2CqXfKarpblKy4089PVHD3RzMLHc+cH3Wp6GvXWaJ0JetY tqXWiOEMp8ZdM/pBJ8Bco0cg5KnL4bKub+0ppOo/h3RlxaOxOFmjmKDZjVtbSmYQ00LQ9zA2WXDj jyOOy5m36Jvtx1HJY6eiea+IkPB4a0f5ifYqzurtbw6d1xTUlc/poo4BJgdyXZW20JX0V+u93u1F GGtkbHF1eSBlTYrq7ZHWLW5EFET7CoGf6LkrdpC9XHUD7JTUMhuEZw9h4DR7k+31VqHa505Q3GRj /UNQx5aQCSSR3wtnoSopLxfrxc6en9LrbFHlzcOIGVdisNZtNq+lqqWCS3sc+pcWM9OUOAIGeT4C +cW1erJrrU2+K3NdUU7GvkxK3pAd2591ZnausmulVfJKtxe6KrMTCfDclfPaWZ1ZVahqJiHSGs9P J9gThNkVYsGhNQX+prYLXRGV9G7omJeAGnOMZPdaF1DO2vNHIwicSekWjk9WcY/dW52Up2Rv1G5r QM17s/X5iq16gf8AhNcXCeLHVHWuePv1KwTzc7XFZtjaq1vt7mPFIet3SOHOIPUSq76b0je9SCpd ZKCSqbT49RzSABn7q02oZ312yVXUTHMs1EXOP6hR38NtbI29z29pAgc0yOAHc4TXSS96RbQbb6qr 6P8AE01nnfF1FuSQDkHB4JWitlhuV0vBtdvoppa8EgwtHIx3z7K3d61jR2bWUVsrHsp6SKHrc7GM ly9OiYLVX3683e1ww5mDI/Ua0AnAOVF2q8drdZtbk2KpIHc5b/1XKfgphWGlkY9s4f0FmPm6s4xh XNZqiwUlS8z3F3WwkFrncZ+y0+k9N2G/67uGpYII5GxBkcDekBodg5dj3S0ffaSwQRaRpqS4WSOm dC0czRAmQnkuJVUdXQNp9T3SJjQxgqH9IAwAOo8K5uh747UD7nOW9McM3otaPGMqnWusHU9zPfNQ 8/zViNCOV9qCknrq2KlpW9c0zgxjfqSvgO66vbRoOsLZkdqhp/mip5sejbBtnpF1ZfYIK25zt+d0 rA4F2M9LQfAUO7c2D+0G4cDadkbIGzmoIdw1rQc4Uy/E08s0za8Z/wDWHf8AlCrla73W2mczUM7o ZSMFze6b6Zl7T38TlbR1Flt1DFI11TBMZCByAC3H+ir3arLc7sJja6CpqxCB6hhYXBmfdei6Xiru kplrJ3SvPcuOVNXwyXFwrau2MaBDI0yvdjlxASrELUemL5W05qKS0100IJHqMhJbx35WvpKGprao UtHTyzVLiQIo2kuJHfhXOtlydFuBUacgijjoYacTANGOSCSvnpPSNot2tb9cKakjZUFzGhwH5cty ce2VFqop0tfmgl9luQA5JNO4D+i8VBa66vMn4GjqKgxf7z04y7p+/srY7f61qNRaqq7bMxoihDzk dzgkL7aVhprRudebNb6aOGnniFTJ0jGXYTaRUynst0qoPXp7dWyQHI9RkLi3jvzheWmpp6mZsNLD JLK7sxjSXHH0Cuoy92216ibYY2xUtPBEXvzgNJdzgLW6E0rYqTVF7u9rp4i5z2tic3kMyPm6fbJT aqlGwXgNLnWyuDR3JgeB/RS78P8ApnTd7jraa9UDK2ueeoeqOGMA8fqp7pK2BszjUXSB8ZBBYWgf ucrgdBUFvot4buLP0ChdTF7QzsHEfN/NTZEM74aWg0/rGoFpoHU9s9NhBY09DXEc89u6jyCKSeQR wxvlkOSGsBJP6BXYuElvv94uumLnAyZpjDnMcO7ekHP7rl9qNubdpa+XqYf7RVQydEEjxzGwtzj/ AN9XaKrG3VoHUaKqA9zE7H9F5443yyCOJj3uPYNBJP6K4OhtZM1NqGqtppmMbC1/UcfmAyE9F6Ds dp1ffLhS0jfWZI1sQdyI8ty7H3KbVUE0dS3OaacAdyY3cfyXpsdqqrzcqeioo3Pkle1nUASG5OMl W10VqyHU19q7aaSJoia/qPSOQMhc3aaq2aH3CuFht1Cxorp2PD8ZLSR2H07ptLdOC3i22odJaYsj rbHJLVgvbVTDJ6+Mg48Lhtr7E/UGs7bSshMsbZBLIPHS05OVafdLVMelaCCSWnZOZy9gDhkDhVc0 7qeo0reKittfSx8mRyOwJzhX4SJe+KClomWu0inZCyeKV+QxoB6SBjOPsq4jueV0+qtVVeo6l09d IXvI/Rcy4jvlNKxB5WXlJvJ4U8/DdYLLNJUXG5Bk1zDiyCOQAta3HJx7lKRA4xknPKOM98hXQqHU NDW1LLxY6anpGDBqhTtLCD9ccLlNsrRpmPUd8tlsooKmlnLp2SSsDy1vTjpBPYZymxVlxbx8wH6p lpOO5VyLFa9PQX6o0vDZ6Q/g4S4yPiaSWkZ74z5Wl0LtdZbTqy91Zh/EMp5PTp4pQHNYHNyeP1TY qiG47IPAySAFdyDTVqmlkFTZLS1jmkdTY2lxyD9FxWg9qbFbdS3ysmiFZTwTGOnimAe1rSzJ+5yr sqrAcCO4P6pgEkBvJVr7XcdD3OrmpZrPbIOkFrnPgYPpwcKCrzZrRZ9x/QpJTUWWOdsjSSDluclv 78Ik7dhfNq7ZQbUsv0dTObsIGTOaXDoyTyMfZQ/b6Ga419PR0zeqeeRsbB9ScK2O59LSy7VVtXSx CISQxyMaOwBd2/ZQlshaKat13TSVsojbT/3rfdzvAV30Y9pEodhrLHRUsFzuNW25viJd6bh0dY9g R27KB9V6erNNahq7RXAGeB2OpvZzTyD+ytju9XC02uC6RzmOspnf3UfiUF3zBVzut9ZqjWtNcrww BjpWesG9i0Hsp8bJe9Ol1DtNRW3ayPUUdbUOuXoRzPidjoy53IHnsodxgc8K3O6FFSP2sq6mij9J skUb2NB4ALu2Pso+2K29tt6pqq93qBtTHG90MVO8AsJ6eXFPc2bQMOFkAScDyriQbeaYqHPjl0zS RMc0gPGD48cqLNP7MibX1fBNOTY7fLnr/wAUnHUGqVNvRpbZK1XjTFLcHXmpbUyQdcrGMaWsfgnH v7KGLVaX1Woqe2SP9MSTiJ0h/wAIzgn9ldPTMNrp7fXxWWFsVLG57T0nILukqnl6f6F/qJIz0ubK 4g+Ryrjqym7vTt9zNoZtN2tl0sVTLcqBrczZaA5g8OGO4UTZ7K3uz9wnuu3sk1a71XAyR/NyOkNP CqheqUQXGdrMBge7A/VNdbWZS3TwpJrHystMkkI8q0PwhCFAeUeEIQCEZ5RhAD6FCAhAIR9EHsgE FCDyikmOyOyEAUeEIJQASIJTQgO3coQjuiBJHlId0U0coCMpQijnCaSgee3uhL2ygoH5SQUIAo+6 OcfZLKBhCP1R5QIoGShH6IA90YR9UH3QGeUApIB5QMBBHCEeUUFLvwn5SQPxhLx9U0vKIAhBGOyP oUAgpAp55QBQhHdUHdCYH7JBAx2RlJBQMfVIoR90AEyl5QgPKEJK6DQjujCaAhGUIBHdCEAEeEJK BpZQhWAyhHlCoY7IISBQCgYQjujsiEhCMoAoQj7IBA8IKPKBoPdJMIESjHlCZ7IMU0ifdMcFECEJ fyQPKAkmqAppdymVQIwlnCEB90FMcpFABA/mjxwgIGjskCgoAnygdkZ5wgqheE290kwUQeUeU1ie 6Bpfqn37oQfAYJKxlWQ/MsZcYC88dWDUwk0J+VTQTBQQl5VNAoQfohEZA9llHnK+fOfZfRndBsKW unpT/cyOZnyDhfaG61MUpkjle15/xA4JWsz9Vlk9gUK2YulSJhO2R3q5znPOVsm6quge1/4iTqAx 1dRyFzeeO6A847lEdczWl24H4uU493LFusrqJjI2qlEgGOrPOFyfVlZF/HCJpum36pFcKxsj/wAR nq6885WV31HW3WRktbM+aRnDS45wtBnB90i8+6Dpq3V10rqJtJU1L3QN4DM8LnpHl7iXHOV8s/XK OrwUH0acHuus0jrGu04ZBQv6OvuuQHumDhFjsabVlZT343WN+asuLi4+5W6l3LustyZWyy9UzBgZ PGFG7X4HfumXnvnlBK8u7V3kMby8HoPUBngla2r3GuE2oKe7zODqmEdLB4AUch+RwUy4/sppdpNm 3MuFTfqe7S9LqmAdLfYBe2bda4yXiO4SOPW1vT054AUSB2EFxyeokhVE1y7zXB8kb3BvSw9XTnGV 4/8AtXrnX8XRw6j0hvQDxgdlD/WSMePCfUQMZP6KaE6VG9NXLLDIGYYx2S0HuuD1nq12qNRxXOta 0CNrWNZ/wg5wuG6/BJR1eO4VE/U+97oaGKnbSj+7YGt7Y4HCg/UNe+53mrrZcepUSGR2BjkleH1A OywccnKBtOOylHafXNHo8VDn0/qTTADr9gFFmVmx3T9kIlzdXcOLV1vpqaKnaz0pPU6i3ntjGV5N r9wTpeZ8cmXQPIJaPdRf6jvuPun1D9UFlP8AtgtMMrqiG3xmfnD+kA5++Mrm7BuoaXUlXXVoLm1O A9o9h2H6KEGyH/MefqkJDnkqizke7tip3OmhoIxKectYASfqVz9h3a9DUVVV1pPoz4y0eMdgoG9c 44d/JIzOcc55USrLs3P0tTVT62ntsH4s5/vGxgOJP1UR6i1dNddXuvMxHqNcOhvhrQeAuE9V2c9R 5WBkz+Y5yqLQ0G7tkntlM+4RCSrgHU3I5DsY4KgLcbUEup9Sz3KfAc5oY0DsGDsFzgmIGGk4WD3l 3dNgaSTgeVNGxupLFphtVUXE/wC2SYaw/wCVqhUd/bC+jJHNBwUomne7VVk1G2hmtcQNZG4iSbyW Y4b9l6NmtwqbT0clJXkNgk5Jz5UI+q8jlxISbJzwSoLSUmp9A265vulPSQCu+Z3qtz1EnuvLpfda lGoq2WsLY4ZyMY9h2CrSyokI/Of3X0gqC1wLic++UNrtaEmtMsdXPZIvTilk9SR2ThzucqLdA64p dN6hu1DcD6UctQ95cffJwtPpLeCnslhp6BtKAIhgkeT7qMdwNRHUWoai6Na2L1A1oa0Y7K6NLF2v W+lrJVPjtsjI4p3ulneXZy4qC9afwau3DkfbHGK2TPYZHl2STn5iFwZqZe3V4XzMzj3ccobW8l1V pF2lf4VJUh1F6PpmPq5cPZR/slW2GwV1yra2qEc75CyBrncCPJ/moIbVvDcdZR+JfnLXkfqgmjfm 6WS51lDW2qUyVxJZO4Oy0sx8vH3W42M1zRWujloLhIIg5xf1uP07Kvzqh7uHuyUNqHs/I4j9UFpq Gm0BbbtJdfU9WoJc7+8k625PfDSstF7hWhl8uDOmGkp53hzQwBoGBgcKrn46Zww55OPqkK2TOQTw fdNC3li1BpjT80tLQVQDKl7pZHvfkBxVad04rfHrKtdaZHS0khDg4nPzHuubdXz9GHOcefdeead0 oHWf1KsHxzz/AEW40zcXWu6wVTAC6JwcFpT98rNjukghBas6h05r3RT6a/zNjc1uc5Ae1wHdqq3W RiKrmja4uY15a0nyM8FEdbMwYa44PjK+T39ZJd+YozoNPP1Uz/DpcKW3agnkrZmRNMRaC44HKhYc HvhemnqZIeY3OafoUsai1dsvdv8A+1+vr/xMf4Z1KImvJ4JAwugtmrbUzVd0h/EM6Zy1weSMfK3C p6LlOHZ9Z4d75K+rbvUNOfVfn3ycqaFqNI2HT+lr3V3iO7mR0wdlj8ANBOThGk7lbrlra66hdVMh BYIIo3EfMAMEqrL77Wuw10zyP+ZJl5qo8ubM5v2J5TSbTFv/APhor1S3O31wklqctljb/gDQMHK6 vYjVFG20S0VVOG1DnFxc4/TCrZU3KapGZpHPP1OVjTXKelOYXub9jgpo2tDQaHsdLdZa66Xs1lKe pxppMNbk/UHlavbettcO5d0kt5bBbjCWQtc7OD2PdV/fqKukZ0uqZCMdi4r4QXepik64pix3uDhN LtcamoaCk1lW6ikuMX99CIvSx2AGM5yvNpfVVtrb5dmxTNa6d4eMnAGBhVOOp7iWlrqqRzex+Yrz x3ushlL4Z3sd7h3dNC02htJUWlb9W3V14jnZM146CwDpBJPfPK22mNUW2uvN2bHM1r55A4ZPHDcK pZ1PcpB0vq5SPq8r4wX2shkL453Md7goLS6G0jT6UvtbdJbvFOyVjh0dHT05JPfPKjLUd/oard2O 6MkH4ZsseXf8vBUXy6suUkZa+rmIxj8xWqNc9z/ULiD9USza42q7PZtZw0FRcpw6gha+QsD+ku6v r9FVHcakttFqmuisQc23Bw9MOd1Ecc8/dfFuqbpHD6Layb0cY6eo4Wlqqh07i555Pdahp53ZJ4KX CR7lH3TZpl259lPXw/2SgrqKoqqitmjuDX/3LGOwGtA7n35UCAgd1urJfq21OLqOd8R92nClVcq1 09fJSVNNqSaiq6d7XAuBPLceQVHu09HRUG5d9gtMj5LeyF3ouecnGOR+hyoQk15eZm+nJWylruCO oqXthau2UNHVXO4VrWVcxMbWE8BikSpMobLNSbgXS+yyxCmng9MDq+YYGOV99N3ajrLnemU8zXPm l628+AzH9VEW9Wo2U1bBLY7pI/8AE9XrxtdlrcDjCiei1dcLdM6WlqHMe7gkFXSLEWnR+oDdZnXm 9BltDXEfh5SH58dxwt7t/PRwR3a30tY6pPrudHJKR1Ob045/VVpqNxL3NEY3VsvSRg4d3Xgturrh b5nSUtS6N57kFXRtL1s2erqi/VEt8uDIrYQ9/wDssnzknt3HCi2/2WOn17LZ7NPJVwOnbHBJIfmO e+fscr7VG5F8lidGa2TBGDgrmae8zQ3JtZG4ioY7qD/OU0TpbrV1jqq3bWSzQujNU2law5dxluSV X7Zu21dw17SNpwAKc+rKScDpaeQtZNuVfJYTE6skDXDpPK1Nk1NV2OskqqGUxSvGHOHlNdaWdLAf EhR1NRp6mr6fpMFKSJeefmdxj3Vb7LBLW3empoB1zTSNY0e5JW9v+vbteqB1LW1LnwO7t8Fc5arj JbrhFWUzumaI9THexT40nztcHV9kq67bV9pgDHVTKZjSOrA+XJPK0Wwc0bdFTUoc0VHqyuDM8jgg fzUIybqXyamMbqx3I6XYOCtZY9Z19lnfLb5ixzu+DwpPWjSwFpsms6m6Sx3G4CioMOIlY4SO+gxl dFoEMp6W8UbqwVdR+IkLZTwXjowD+6rvNuvfponRmpLeoYJyVq7Tr24WqpdNS1BbI/uiaWb28ttX ZrBVUFxAZVSyyytHUDlpaQCqs6ptNbDrGptToT+NdUem1gPdzjx/VdJJupe3zCb8T/eBuGn6LmJt TVU19beZHh1a13UH/UeVYLLaXpYdu9vmw3idhnLXPexp/wAZBGB7qqWopA+4Svj5Y95IP6rf6m13 c9QRtbcKgvDBgALkpXl5BKfGlk+XySQTykstH4R5SQO6DJH3SJRnKBoSJ4SQZJBAKFTQCPKG9ke6 gaCkmEBjhCEIo7oHdH7o4QGUk0YyECCY90fRCIPCSaECQUFJFCCjwjhAAcITceAkmg0j2QjCaB90 /CQ+qM8JoHYJBAQE0Ds5HhNYqBpBNLCBk8fRY90/omOyDEowssJFAvomfdJM8FAZ8oykhA8pZR25 QcIHlI8FCEAhGEwOVQigFP8Aml2KB5KR4QOEIDKM/TCCOUvKBpkoycJBAHujPKD3QUBnnhCEBXYf lHcpITYDyhCMpsGUFA5TTYSEu6XnyoMsoPukmrAJH+iYPsgqg8oKOwQoAIQjwgPHshCArtNBCD2Q mwIyhJNhp+FiU0B5QeyEHthAvKaSaIAkjshAJpHhHlUPujPCRRjhU0y8JIR45Q0EAoCENAlJNCBJ oSzwgMIRlPPCoSeEkZKIZOEiglAQPxnssf1WRSyEHxHfssZBg+6zPcrCXtyvO6sQOeEIahUCD4Rn hIcqhhCEYRDWTe6xWTe6D6DhBKX1QgYPCOCVjnlLKIz8/dM4XzyU0Dygn5eUkFAwPqkOEshGQgyB GU+/ZJo5RnlBmOB90ZPPKxCMoGDhMHysCfdGUH06kB3P0XzB4TyUDR1E9/6JZSKB/wCJBKQwjKBl HZYg5TP9EDJSPZCXlA8rIHH1WCfjwgZJzwjqWKeVQwfdMk+FijKIMn9UysUZ/dBkhYjt9EHKgyBT J9uCsG8DHdZdwgefKWQUjwl5QZjATa8/ZfMfdNB9fUPIJWLnktI5/wCiwJ/ZLPsgz6v3RnJWAPuj wqMs+4ymDz5AWKB57oMkZ+qwyhB9Oo85T6uPcr5oHCoz6licFL+pQiskuyxAwn9kGRd+qZORkd1h jHlCgzz7p5IxgrAFPKIzDvdAd3WAPhBQfTqGUF/C+WVkCSgz6sDvyseorA8uQ7tjyg+gdg8p9Wc8 r5jjvyhpQfUO4+6XX+yRII7LAlB9A8k8lLq547L5gpg54QfQPwhz8/ovmcdkgUGZfkcZCRPCwHBR lXYy6uUdyl3QD+6Bnumx2O4WGc/qjKD0dY4PsvVBXTQgCKV7R9Ctfx9UB5HGQQiPfUVss2PUeTj3 OV5i7nkr5E5PPZIn9VVfXq+qXUMeF82kfqn1DPA5UZfTqGEg/K+Zcn4+iKzcc4x+qyLsZxyvl1HC A4/uhpn18Z5TDuVg0o7Kj69Y4TL/AKlfLA7+UZx3UV9Q8+5QXfovl1cJ9XZB9Os9iSjqIB54XzyM I6uCmxmDwglYEjHugHCgyR5WITyimllLKYQMISynnHdEBQUf0S+iBhPukjCKB9088cpZQCgaEkHu iGCjOChLKKaB3SBTHdAAp5QcI7IlCWUJHlA0d0vsjOEDS8oQihASKQKBnujPKPKDhAeU8rHIT4wg MpeeEIzn6IGUJAoP1UDSJSwg/QoAFGUI/mgEIyEBAykkeyMoGgpZ4SKDLuhYglPKBgo8pFHhA0eU kFUNIFJH2QBz7p5ygY8I8oDtwUIOEjgIMu/1QkEA89kBlPPCSEDQCke3KO/CBjugrEd00DQkllBk hL7dksoMkspYQOEGSPCSR+iDIJEpdyjurAx3RnJSTKoCkThPKWUDH3TcUkFAZTPZYn3R3QZJBLKP KIyPdIjhGUZUAke6Y7pqhZQhHhAISQiaMnhLPKMcIAAQ0aWeU8IwgAgICXlVTGUBAwE02ApFCD2T YMj901j4TVQ8pe6MecI4QCB2R7IA4TYMpHKfYpElVAeUwkhA0v0RlPI9kHxd3Xzfyvoe554Xzk9v C88dSbwFkeywBTyqBP7JBBVQxwgpZ55TQPKYJyscoxwUH1Bz3SJBK+Y4THP2QZ5GeSgr5nv3RkoM 8ozj9F88oyUNPoCM8J9l8hyg9kTT6dkDIXyBwnk+CUH1B5wn9V8gSEAnIQfYI7L5dRxwjJKLp9Dy juF8snPdBcfdB9c98o79l8gePqgE4QfXulnA7r55TLsIMwU+rC+XUfdHUShpn5TyvmCco6ips0+g PsjK+fVjsjJ7qozJymD9l8wUdRzwg+iAV8y4kIyfYIPpnhAK+fUfsjqKDPwmFgH8JFxBQfQcJkrD ryl1fREfTKWVh1I6hhFZ5RlYdWAmXIGe6fKw6kdbcImmeT4SJ6fHdY9eUF2ShpkE+3ZfPq5T6kV9 MpeV8+r6ph4zhUZoPZYBwyjP1QZjjhMFfMOGEycIMs8p5WAdwguVGQKYPKw60F3uoM8oysOrKfUM IMxwjOV8w4J9XhBmDyjPdY9QxygOHlA+yYccdlh1g/ohrkR9OrB5RnngLAuB544R1DwisskHGOPd APBWPX+yOrxhDTIHhMeF8y9ZDB7lDR/ZLsUuoZwEE59kQ+6fhY9Qygu5+iKEBY9XPfKeVdoyCO/2 WPV7YR1DCDJB+ixDsIyM8oMweEur2Cxz7IygyBSzlLI90cIaZDgI9kvCQOfKDMDJQcjuSsOrGeU8 5QMFZgr55T7+VA84PCyJ4znuvmO6eRjlUZ9SCcrDqHlGc+yDMd/6p9lgSR7IBQfRAKwyE8j3UGWf qgrEO+yeR+quxk3PSn5Xz6lkCMZzyimn5WHUEwQoMgcd0/1WGfqmCMclBl2S8JE5TygE2nOVh4QC AUGZ7oSyn+qIEJZ5TygDwmsfHHdMcDlFHhNInlLygyKQzhB+iPCICUHKCfdJFMnAQOQkD9kZP3QN Gefose6Y7IAoR3Qe6gB2QeUh/JHlA8JIPJ+iFQfdHhCD2QHYp90s8ZS+6geUj3QhFAKZ+ySCeEAj xhLKBygYCD3RnlA57oDPKOyXlNAkeUZ4SQMlGUkAoBHlA7lAQPKXlCR7qjLv3RnlJCBp4yOFiUso MuyEvHKEDKPHKx8+6aA8prHKecIhkoz+6RKxJQZk9ksoykO3GVFZZz4R5SHZBQMIJ/kkEKgzwjKE j3RGWc90BYoz7qjNI9sJZTBV2AcISQED8IykhSBnkIHZJNXYxLsHnssuPul3KM/VAIHfKEZ5QMd0 O9kDskgecpDsn4SJ4QNLuUd0A4QZHg4S+yxJ5T6sFEPx2RlBKOyAR3RlLKDIpZCTj9eEIMhjCD2S RlAIykfokUGWUZx4SygkeVQ+pMn2WOUZ57Khp5S8JA8ohoR5QO/KAARj6lPwln7IPj2XzcclZkFY ELg6F/NNLBHKZCpos8ozlMjlHSmzQRlB7o6VUGcIBR0/VZFimws58oR0+yMIMUweUsEIDc/RAIWX SkAqECgnwjCCECJTB4SxyjCB5THdLCYUDzwkSjB9kEHyqDKR+qMcJYOUGQRlLBxymgD2SPAQAcoQ CCf2QUY9lAFIIIKYB8IBCOfKMFAu3dHlGDlP7KgPKPolzlGUAn4S5KWcIUY5WSxTHZEMIykUA+yB oQki6NASSJQZFJLOU0QJ/qkTgcpZRTKAeEk8ogQkjsUDxnyjx3SBTzygDnwn4SyjKKaPCSAgMJjv kpZTPCB5S8oQgEBGUZQPykjwglAIz9EIPCATHCSRKDIlMdlihA8oyT5SCaBI8oyg90D8oJI7JEpZ RDySEE8pJ4QLJ90BBTGEAjPGEkFAyj9UkZVAU/1SQgMlPKRQgZQCUIQGSguOPOEDshAw4oyfdIoQ Mk+6MlJCgfUfdMH6rDzysggyDil1HPdYnunhF0yDin1E4WHlCGmXUR5TLligcoH1nJ8J9ZzwSFjj KEGRe73TDzjkrAoygzMhQZCRjlfPOEDlB9PUKx6neeUvKEGQe73wsvUIH1XyTCDMSEnvhMyOxjOf qvmUgg+vqfc+6RccLBCDPrKYkK+YPKM+EH0Eh7IMv3XzdjASQfXrITMmPdfIlBPCDMyH7piQ44K+ YxhA/wDtoPr1uwl6h+5WHjul5RX09Up+qSeOV8hyjODlDT6+oT34S9TlfPygoaZiQrIycjuF8uBh M9vKGn0Mn6oEi+WUA+yI+nWUF5HhfMnKOpFfT1CB2QZD9l88oyhp9TJx9UdefZfEHlMnKGn09TPl HWvn9ksoafX1O/lMSZHZfIlA7IafXrH6oLxjK+RykEH19QfqmX8ZyvkOySD7daOvC+QQSg+nWCmC vllGSiPqXYKfUvlk5Rnwivo13PPZMuGeF8TjKAfZEfUuCOrkL4pgoPt1goLhhfHhGThNq+3UjIx3 7r5Z57pHKI+vUCE88L4jKDyg+pPPCM47r5J5yi6fUOHdGQV8gUZRH2z9U/C+AOPsjqOEH1zjynkH 6L49SQKD7/qhfHKOoq7NPslkZwvl1E9kBxz4TZp9specjyvkXlAeU2afXygHn9V8+vhBers0+pKA vl1I6/bhNmn2zhMkYK+HqHOe6OvKmzT69whfISH2T9Q/RXZpnlCw68ngJmQeU2aZJ5XzL+3CA8eQ mzT6ZR9Vh1j6oDx9k2jPKFgHplwHdXYyyhY9SOsDymxl5+qYKw6hlHWMpsZZS79ks8ZKA/P0TaMv ugcJF2B3S6wmxkeyQKXUCFkCO6bB2KCeUiR1ZyjjHKBo8pA/onkDz2QB4QDko7jvhIYBwqMs85Sy MpHjz3RjlBl1JJfpynwB5VDB4SyUf0WOT7ImgeQsCMphB+q4Oh4SIHcoymQqDpB7IwEYSQZYH0CM JIQPHlAAKYCRQPpAwscc/RA4TxkcFAFgWOAnk+TlBOUAceyQaMIKEB0hHS1CPIUQFoAWPSFlnj6I H0QHSMo6QmEIDCAwZQgnKbC6eeEdP1QDgp+VdhdGfKXR9VkUs/qikY/qn0I/kkSgCzjujGPYoyfK EB0H6FHT7phBJQLoygt8YT8Jh3GOEGIbnhBZhZf0RnKDHpygNA8LId0kQgz2QW8p54QCgx6MIA47 LLJTzyg+ePogs5+q+mfASzlBj04CA36LPKM4KD5huUdGBkjlZhPJ7Kj59OCjpPss+rKM/XhDTHp9 wsen6L6n6JEoPn0+4R0jPZZ5CZOEHz6RlHSCvpkZSJyoMOkDsEBufC+nVg8o6snsg+XSAcp9C+gI z2RlB8+n3QWrP7plB8+lHSD5X0yl+iDANR0/ovoMJgAnlB8ulMN919DhHbsg+RCA3PdfXAJ5RgA4 QfIjHlHSfdfXAz7pEDwg+fSkGHv7L6jB7rLDePKD49KOjC+oAyhB8+nhLpK+hHZGAqPmQcJYK+oG UEIPnglGF9ekfdLAQfEhPBX1LWk8IwPJQ0+XSfZGCvt0jBwViByhp8+koLSF9cJ44Q0+GPojBX26 chPCGnw+4QASvsWowrs0+OCEwF9SEAJs0+RByjBX2DecgpYTZp8sIP2X2Dcoxz9k2afHBPhA9vK+ 2P1S6cps0+YCS+vSQUGM9+FDT5DlHK+vTzwgtwg+QHlC+wBx2wjpUHw7JhfboS6fCD54RlfRrT5T x9EHxOUL7YyeyOjJ9k2Pkkvt0Y7co6PoqPj5T7L7Bv0R04HYKD4HI+qF9ejxhPo57JsfFAyvqGhZ BuEV8RlBX16UdOPCGnyCCvp0Z7DhHRhVHyTX0Dcnwn0ewRdPlyjuvqWJFh9kR80l9unntlLp57Kb Hzyj7r69IxwkWIunzKByvoG4zwmGhNj5dkL69IIS6PKbHzCPKz6cLLpCbHyGU/PK+gaCCl05Co+Z SX1wE+kY7IafHsmvp0DweUFnshp8yUBfQMyE8c9kNPkhfRwH6o6eMoMELINBKCxDTFLKzDDj6IDc d/CKwynlMgEo6eURjlM/ZZdGEFoARWHlM8p4A8JluUGJPKFkWAd0ulEY5Tysun3R0ojAoHdZenz3 R0oF5Qn0E9kdJyi6LKD3TDCUFvKlCQSnjlLBygAUEIwfsmGnKBeOEcJkFGDxhAkkyDygghAv3TH8 0du6R7qh4ykE8jCAgCscpko7/VEPGEvKOUFAFMJFNAkyPdJGeEBhHZCCfdA/CPCSO6AT+6M8YRlA iUBA7pk8IBJCEAhCEBlPKXlB7oHlLugIQP6IBxwl27oQMISTP0QIp/6JIQMHHCA4/VASKB+e6ZJy sQeUZQPOAjOUso8q7GRJHlGT5KxR3TYyJOBnwjqOO54WOP0QU2M+sgY5R1u/RYAoHdNjPrPvyj1H LEI/VBmEZTwksKAn9kkx+yBeU0YyjCA+6BwUIHf7IGg90ZQOUDKQQmUCSxysiseDlUCSaECPuhNL uFEB/ZHlHhY+eUVmOyAecpd0BUNCPCECIQmkSgfdY4wmO6PKAyl4TRj90CQmhAI8oCCgP5JEJoQI JowgIA/zQgBCIMI7IwkgDwU0YQgEJJhAYR2OSgoQGcpIHdNIFhCCn2QL7oQEFAIQgIDyhHjlLuga XhM8IQGUHjwjCCqDKPshCgSY8oQEB2TByUDlJA88oS8J91QZ5RlHhB7cIDyg/TyjKaDFZJYSQNCO yMoAoQDyl5+iB4+qRT8JeFAIQhUHdMlIZRhQCEdkKh590eEu6MIGjKxTQPOUHgpJIHlPykmeyA+o TBWOfCY7IDJRko7BCA8J55SPbCOyB5Sz+yXlH9EGQQPKP9EIBASJQoHlGUeEkGQKCUkIpg8rIFYg JkIGSQglIcBHhAyfcoS8IQPJz3RkpBCACMnujKDyEDDsoSHCZygSEJngYQIJ5SQOyBgp+FihA8hL JyjCEAEFHhCBkpFB7fVCARn2QAhAyeUkIQCAhHZAz2SQShAJhJPwgPCXlPygoBCSQRWWOEFAR9VA EYS7nlPn9EiECITwAnhHdAAA9yjAJ4wkEAIDGMgBMDlHZCBAfRPAH3QhAHnukAMpoQBAKOkICCgQ AHdPHsjuhAsJdI91kg9kCwjpCE1ULpRjlCEAAMoOEI/qil05R0crLKB3QY9GCjpWaWeUGBaUg3ns voQkBygxDfojo/RZj6oQYdBB5R0fZZ+D9UvCbNMej6DCOgkdgs/COwQfPoOOEdGT2X0ykUNMAzns jo9xlfT+qMoafMsHsgN+i+meEu6IxLfpwl0D7L6gkeUkHyLD7IDT2X1z+yM8/RNmny6CkWkfZfcH A7d0ZBPKbHnwUdBxwvvjn6I4HZNmnx6SjoX1IH6pgtx25Q0+XQQl0/XC+xAHZHCGny6CkGZ84X2B HbyhDT4ln1S6T2X2xnKOn9ENPl0EeQgjx5X1wAgta4+QmzT5dHCXT7d19w0D6hLCD4490BpPK+vQ ChrMcJs0+QCWCBwvuG4yjpzx3TY+GUL7dHKMfRUfH9Eue2F98YQQcoafINOEYwV9eUFpKGnywjH3 X0wR4KfKGi8I8II5S7LIE8ZCMIQCfn3R9kv3QB4CaSYCAQEDuhAeEIPCaBLFZFLyqAJFPCR5QNBS TKAIWJTzlNAkYT7oCAKaCEdkCRhId00CBTSCaAS5TxgoQLygppBADkp4QOEIEjKEBAjnKflAQEAg +4TQiFlATSKBFMJhCBYQeEwkUB45R5QShAgmUkZSA8p+UJKgHdMoR3QIo8JpKAQjyjygO6ChCAyg coTQL9EIRnlADungn7pfZNAsJ8Iz7oKQJMIKFQICEDugPKRTyhAI7FJMoApIPdCBhJCP8KAR5Txw hQJH6JoVCR4QQQjtlQJPhJPlUHhGUIQCEeUeUAgBHhPwgTe/CY7oHCDwgR7ITCEAO6CjthHlAghN AQARhGUIGkmEIDwjKMIUUJlIcJ5VCH6oHZHdNAwmkEH2UDSQmgX1R5R2CCUDS8oR9kDCWfZNCBJ+ EihAIP3RjBTCBI7I8LLwgWPJRlGEAIDKSZSQGEFMpIBCeAEvKAQnhJAIARhNAvKeEkygEYQhAeUi mUIDKR4T7oKBeUeE0eEAhHdA9kUI8oKPCgRRgYTTQJNIJoEkhNAAIQhAeUI8o8oAFGEIygAhGUIG sUwhABGEBHhAISzkp9kB2QhBKA/qhGcIyEAUIKCgEIQgEBB4SzygyPPdJGUdkCPZA/kmjPCoXbsg FNCBDlMIygoF5TH0SKAgM/yQn4S8oDCYHCRKB/NAJkpeOUIH4STWKBpY8p+EkDQkDk/ZNAAcoKPK EACQU88JFIHsgZSTS8oGmeySAgBzzlMJDCMoMiUkkEohk5KM8YSRnlAFASKYVULIfzWKM8fRAyUZ PuVinkfVEJ30SygIAWQdkJjug8FAihMICAR4KEAe2UDR48JYyn3QJGOE8oHZBihNJUCXhM9kIEO6 aEgEB2RlB7o8IH4QO6AmOxwgax8J/wAkIF2CEeUIBCO6ECPHKExyhAIISPdCATQgIEUDsmUeEAUJ FARAUDuEyhAI+yEggflLCeUDwgPCEIQJNCSA7IQUAJAIS7JqhJpYT+yBZTQfolhQNLygj3QEAUeE EIQMIKSfhAISKaAPdCEIBCEeyA8ppI+qoPKXZNCARlLygoGe6D2RjCM57qBf0QmUeEAgoKXYKhoy hJAwhJBQNJHhA7qA+yE0kAUJ+ElQeU0kxyPZAsoHZHhPKAQlzlA5QCaB/JJBkhJGUAUJIQZIz7pB M8oAIKOyFFLlNCO6A7ppFHhUCaSfCACaQTQATwkOyD3UDSwg8ICB54STQgEI7IQCCjwgIAd0IQgE I7IQPujPhLlHhAEowmkgEeUJoF5QhCBDuml3KeEAgd0/CR7IBCEIEUdkygBAIIQgIAd0ZCEeUCJT yhIoHhLymEiEUeUITQLt3TykgIbCPCEIDwmkgIGO6R7JgoKAA4STHZI9kDSB5wjwjt90AjygI+yB pHshNAI/qlj2TzygEJFCA/VCOUIDyjCAeTlBwgO6aQ+iZQJCaX0QB7IQUZ5QCZSR5QGUIKAgCgZw gpeUDQjPKEAE/KQTKASQSgFAJBMnKPKA9kDumEEIFhHdHcoQLsmkmEB9kJeED7oGEFLymgPCCOQj 6JIBAR4QO6AQcIQgCfZHOEEZRj7oEskseyWOUGSX1T7IwiFjynlIhNAiM/RA9lkVj5VU/ul+yaWA iF/qgHCPumAsqR7I8hMo+6ICMoxwkE/KAT+ySEDCOyO/2TQYkITS7oA8BCPCX6KhhJNJAYTIWIKa BeUygIQIFPHnsgI4QPwlngp+EkByjJTBQFAj3R4QQg91QeUBCCgEsoKEAn/NCEAjHCPCOyIQB90w lhNAvKY78pBNAJJ9yhABHZBQEC7J90vKaAPKPCO6PqgX+qEeUFIBIDKaQKBhHhA4KfhBiE+ySaAS T8oKBZTRhHhAdkJBMIF5QmjCBICE0AUYR4R2QB7o+6O5900Al5QjKoCOUYwmgoEUduEFHlTQPHCP CDyjwmgIS8plUCRTTKDH7IT7oKgO4SBQmEGJTwnhI+yAzyj7I8IQPwhCFQeEBIo/mgPKaX3T8IEn j3QEdkCTBR3QgSaRCY4QHumkEypQJI8JopZwn2CEIBHZGEDyqH+iMcpZ7poAeyaAjPKBhLymkoDs go7oQGfZNLyhA/CQ5KMoKACf8kAoHCAPb6I+qZGUseUAUBMpZ4QGU/ulj3TCASP1QjCAQhCAQghC AQg90IAoR+qPKAQgoQB+iMoCAgEH6IRhAZQgIygCkEJhAIKaRQJPuUd0kDSTRhFIo8oRyhowhJHs gaAf6ISwgY7IwChCBY4RlPukB9EDPZLymO3COP2UC7ICM8oyqBPHlLKecIEUI8I7lAvCy8JJoFgI Ql+qDIJIRhAICWEIGUEoxkI7IDyj7oCEAUJpFAykhA7IEhGOe6aBI8LJY90DQgcIQHZBSJTQLKy8 LFMIBGUJAeyB+EuyOcpkccoBLKBn9U0BnlCXlHlAIPKAhABB4QhAs8lMchGUIBAOEvKaAQMoxgIH dA08+Eu/dByiF5R9kFM/RNAQjCRVU0sj6oKSIZ4OEfZIZ7p4WVCPoj/RH2RAhGEBAd0DhMhBQMII ykEdkAEZT7pFAErFZdkiqEhMhH9UCxyhNAQL7oQgIGgd0AIA5QMhLCeUHkKIWPqkmgoDjCB3STVU JEJhBQLwhBQgCUeyEKIEICaQLKD2TCFRj4TCZGQhAkdkz9EkAhBTygSD4QAmgSEHv2TxwgxQUDhP HPbKQJHlCYCBA4Qe6fdLCAQE0kAAhH3T57IEUHhB4R4QATR3RjhAkwhCBBCflLygaXlNJAJpBBQN JCAqGllBQgD2QmAhAkFNCBIT8JIAoCZSQACEIQJCChQMfdCXhMchAin9kI5QCPCPCAqFyjlPCSBp HuhNAJhLCYHJQJCaSA7ZQEJIH90ykAjypQ0eUEJIplGUk8IDwgYKEDjuqHwhLHCY7oDygpjuj7oA Jo8JKAQsil2wgR5TSTCA8JJpBAeUwUFCB5SQE8IF4RzhH+qPCAHKY4S88oQATSTAQCXZMIQI9hhG E+6SB4QUgn5wgSEyjHCKSfZIHCeefdAihMBLHKIEIGUDugEI7oQCPKYQeECQgcoKKCjskUIGgoCD 2QCSMc/VZIMe/ZNAHCEAhGOfsgKAQjCRCoYQjgIUBlLHJTR2CoAEHsgFGUAEu/2T7IQJA7IHKyQJ H9EykoDykBlA8IVDP9EhwhCAPJS+3dPsjugaRRnhLuUDSQn3QLKYSI/dP7oBHhHZCBJox7IxgIAI ST8IF5TQkgaRQe6EAnhHhJAITKMIEU+rhIoagB2QmgjAQCEAJeUDST8JIAo8BCMoAd0HsgIQHhAQ UIBMd1in5wgfdCP2SxkogCY7oSQPwhJPhVR9k1iUfsg//9k= --=_63112eca475a6e081828f3319b62f832-- From xen-devel-bounces@lists.xenproject.org Mon Jul 18 22:03:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 22:03:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370159.601836 (Exim 4.92) (envelope-from ) id 1oDYpy-0004Vw-Hi; Mon, 18 Jul 2022 22:03:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370159.601836; Mon, 18 Jul 2022 22:03:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYpy-0004Vp-Ey; Mon, 18 Jul 2022 22:03:34 +0000 Received: by outflank-mailman (input) for mailman id 370159; Mon, 18 Jul 2022 22:03:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYpw-0004Vd-U1; Mon, 18 Jul 2022 22:03:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYpw-0000Ur-RT; Mon, 18 Jul 2022 22:03:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYpw-0005Hl-Bv; Mon, 18 Jul 2022 22:03:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDYpw-0007ff-BF; Mon, 18 Jul 2022 22:03:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2+umZy9ism5fSBpbQ8GMpUUWI3IZe9uVHW2tYMZvlVc=; b=PooihaTr0FreSWWPgCXR1q0ZQy I/1xCdV2ZbtfgT3RIeoUj9oYS15dIy+0IgsGty9KTN6+FpDvJkvGHe6gi+YrHUYOKUxufbQXMthj0 6c70mUEMpIWZW4nrSMi1JWDOe7C7Zq6BEEHUaLjmzNvQWOp8iQ+UyHgzIg7COMFd3yXA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171673: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee X-Osstest-Versions-That: xen=0af91dc0326cba12795e0b8fa8f665776e2a9e13 From: osstest service owner Date: Mon, 18 Jul 2022 22:03:32 +0000 flight 171673 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171673/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee baseline version: xen 0af91dc0326cba12795e0b8fa8f665776e2a9e13 Last test of basis 171669 2022-07-18 15:01:42 Z 0 days Testing same since 171673 2022-07-18 19:00:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Henry Wang Jan Beulich Juergen Gross Wei Chen # arm Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0af91dc032..0e60f1d9d1 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 18 22:11:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 22:11:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370169.601848 (Exim 4.92) (envelope-from ) id 1oDYxY-00068x-B5; Mon, 18 Jul 2022 22:11:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370169.601848; Mon, 18 Jul 2022 22:11:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYxY-00068q-89; Mon, 18 Jul 2022 22:11:24 +0000 Received: by outflank-mailman (input) for mailman id 370169; Mon, 18 Jul 2022 22:11:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYxW-00068g-Sl; Mon, 18 Jul 2022 22:11:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYxW-0000ej-OP; Mon, 18 Jul 2022 22:11:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDYxW-0005eQ-7T; Mon, 18 Jul 2022 22:11:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDYxW-0002ui-6z; Mon, 18 Jul 2022 22:11:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DkVOeEt0n+2lpwD/xeBdGS5oiWREa5qvsR+FDLw5c8M=; b=lCcYxkndkMVhOPDIZfF+K/lvCk fXoTLSMzhwNj+DVAbHSznwYFsJLv4GC79OY7TCJea6MihT/cC8PdVdYQSXirCozQgmj5Wj+lLt2RH jkpnAzricAFI1kB4aDYA1gSuwztVxhJ4WWpAXTvdsx5Z6KqJFQL+lNbQCAZKArqLFuvY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171670: regressions - trouble: broken/fail/pass X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-pair::broken:regression qemu-mainline:test-amd64-amd64-libvirt-pair:host-install/dst_host(7):broken:regression qemu-mainline:test-amd64-i386-pair:xen-install/dst_host:fail:regression qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start.2:fail:regression qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=20f55423960ef9f351b49d171c29d257021d75b3 X-Osstest-Versions-That: qemuu=0ebf76aae58324b8f7bf6af798696687f5f4c2a9 From: osstest service owner Date: Mon, 18 Jul 2022 22:11:22 +0000 flight 171670 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171670/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-libvirt-pair broken test-amd64-amd64-libvirt-pair 7 host-install/dst_host(7) broken REGR. vs. 171648 test-amd64-i386-pair 11 xen-install/dst_host fail REGR. vs. 171648 test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail REGR. vs. 171648 test-amd64-amd64-libvirt-vhd 20 guest-start.2 fail REGR. vs. 171648 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171648 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171648 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171648 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171648 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171648 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171648 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171648 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171648 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 20f55423960ef9f351b49d171c29d257021d75b3 baseline version: qemuu 0ebf76aae58324b8f7bf6af798696687f5f4c2a9 Last test of basis 171648 2022-07-16 03:15:54 Z 2 days Testing same since 171670 2022-07-18 15:38:37 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Kostiuk Michael Roth Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair broken test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-libvirt-pair broken broken-step test-amd64-amd64-libvirt-pair host-install/dst_host(7) Not pushing. ------------------------------------------------------------ commit 20f55423960ef9f351b49d171c29d257021d75b3 Merge: 0ebf76aae5 e8cbe5842b Author: Peter Maydell Date: Mon Jul 18 14:33:57 2022 +0100 Merge tag 'qga-win32-pull-2022-07-18' of github.com:kostyanf14/qemu into staging qga-win32-pull-2022-07-18 # gpg: Signature made Mon 18 Jul 2022 10:14:09 BST # gpg: using RSA key C2C2C109EA43C63C1423EB84EF5D5E8161BA84E7 # gpg: Good signature from "Kostiantyn Kostiuk (Upstream PR sign) " [unknown] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: C2C2 C109 EA43 C63C 1423 EB84 EF5D 5E81 61BA 84E7 * tag 'qga-win32-pull-2022-07-18' of github.com:kostyanf14/qemu: MAINTAINERS: Add myself as Guest Agent co-maintainer Signed-off-by: Peter Maydell commit e8cbe5842bad80bc2df692dea70134da0d13c556 Author: Konstantin Kostiuk Date: Mon Jul 18 11:52:28 2022 +0300 MAINTAINERS: Add myself as Guest Agent co-maintainer Signed-off-by: Konstantin Kostiuk Acked-by: Michael Roth From xen-devel-bounces@lists.xenproject.org Mon Jul 18 22:25:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 22:25:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370177.601859 (Exim 4.92) (envelope-from ) id 1oDZBU-0007os-LE; Mon, 18 Jul 2022 22:25:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370177.601859; Mon, 18 Jul 2022 22:25:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDZBU-0007ol-Hb; Mon, 18 Jul 2022 22:25:48 +0000 Received: by outflank-mailman (input) for mailman id 370177; Mon, 18 Jul 2022 22:25:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDZBT-0007od-58 for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 22:25:47 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f6a5ee6-06e8-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 00:25:44 +0200 (CEST) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 18 Jul 2022 18:25:33 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6100.namprd03.prod.outlook.com (2603:10b6:610:bb::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Mon, 18 Jul 2022 22:25:15 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Mon, 18 Jul 2022 22:25:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f6a5ee6-06e8-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658183144; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=O8s/22epmSW0ROXxM5/s93Lxh4l/wC9Iu7I+xmdXSzA=; b=Pzvw9SxsZGj2ZpwIKjFvjA+hQycvFkVMz31mOjD5bE1EFH0KXhjY3Ifm B7ZiN82uvsDI2yz3pIS0cPMTT4XQGqKWlf51yT/QupErwQO9u07pxKWSd mYjPJFD00l3Ksukx3Vw9L/8IEthnHALDxdVTVe0LueTFgtwC2ZO9ryIxk 0=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 75377829 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:eDWjwaJ9pkXkn6FLFE+R6JQlxSXFcZb7ZxGr2PjKsXjdYENS0DBRn 2QYUWrTOKncZmukcttybYrk9EtVuZCDm9VrT1NlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYjdJ5xYuajhOs/3a+Es11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TEw9ZBNHMkLZQkpLhwHVlT5 8c6Bw4AR0XW7w626OrTpuhEoO0GdZCuEKZB/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H12T+mLGUwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPCkmXaoij97gPJtRjEUYRDKuCxzdNNoHnPwDU2MyM1UVTu9JFVjWb7AbqzM Xc88So0rLMa+EWvQ8LmXhr+p2SL1jYMVtwVH+Ak5QWlzqvP/x3fFmUCViRGatEtqIkxXzNC/ l2Dks7tBDdvmKaIUn/b/bCRxRu3fyFTPGgfYyAsQRYf49Dm5og4yA/MJuuPC4awh9zxXD31n TaDqXFng61J1JFTkaKm4VrAnjSg4IDTSRI47RnWWWTj6R5lYImiZMqj7l2zAet8Ebt1h2Kp5 BAs8/VyJshVZX1RvERhmNkwIYw= IronPort-HdrOrdr: A9a23:rHpnk6n6jRK2FHwrVC/4uXtvdFvpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.92,282,1650945600"; d="scan'208";a="75377829" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fPdppAFAdizetjHaAmWub+eM+LyQ8c2m7sTwJrRTD72hKnqbYy63j+qEZY89tNXzZUYGdZqh0t0grmLQOBTbJZg19QnbWURkcek4hFVyK/tCUIg3B4EPaUNeTo2LZUifut/vxGFYKljUZXt/KXWArx2UtezG++7fBD1ZOPbKjyNbqoeMxAvMdgRydfBAXYFNKYtu0sekPjZmv1TjcFutUWP7YCs4xT4IMFdve37rvD0zWmwyAOS/NhgynYQlyN9+SDKPt7POK98m0gvd/eMbekIRxjNIKH6boFZrgx9mww1Ziszsbcj6sMotyPNsONYUeu/eoAAmUALxu5TwqB7LqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O8s/22epmSW0ROXxM5/s93Lxh4l/wC9Iu7I+xmdXSzA=; b=AdsXfP08HxH7bKXjw/N8yB/UoWS+VusrF4TQj6GkgRHLZK5d9Q1sSp8VtkFiNYoagU7l5+Lqn0dW7wZilUuQ92g59E1EmtmHLMOsmyv/KUgr3Z1FfdatTWl0WmTohSQ5CiVsR1CT22F/N4RK3RzB97zLmNxs7yB/1124+RoREQ+dVkAl5KnCSjCRXXVZr5yb2uu4WMNkis+/9HRcWGSyUSlKRiAQyJWKDR7JwBSO2QRBhAJzG1lrC9mPY0zoWFgIAIVkldfwk7Oi35WCElGVsFtNwqLyjzkep+oQ4EYV7XyRhaOBZnC+y+qMQT/2fqMIR3Ho2HNT/1aEJe6kmqXtCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O8s/22epmSW0ROXxM5/s93Lxh4l/wC9Iu7I+xmdXSzA=; b=Qsdu+lU5TPpgNI0tUPVmPb7fvdyXagVXGUtZDR//wH5OddvY3F38kX5+JsK9CAg4S2k5edTsMfb7CIUL8ZpvvbOkiJDX4UTePYauduYkL5mhEhHLgPRwQNEwkdP+YxTyZca0M6A35Yoco9sg/fYdcn7vWJdNL/XftOWMIbpefpw= From: Andrew Cooper To: "chris@dalessio.org" , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Michael Young Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Thread-Topic: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Thread-Index: AQHYmvJAgpD4dPs1E0ycG7IdcXuLNK2EtJsA Date: Mon, 18 Jul 2022 22:25:15 +0000 Message-ID: References: <1658179896.l7m1s9efz6ok84g8@webmail.everyone.net> In-Reply-To: <1658179896.l7m1s9efz6ok84g8@webmail.everyone.net> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9d9bcb8d-0884-4ed0-86ac-08da690c6344 x-ms-traffictypediagnostic: CH0PR03MB6100:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wQoJaktqfsItUpzRMrerR3FxPWb4SXAlFQ/F0G+5+hlVJRaziySpwd7mMkZC+MiXuVGTz89BUmV4BRDOdx+d4WM37jOb8/F5u86oaRal/PPeeUroDwnCI7KALMxPiPjZwRdpjl7/L71Zm6yUHZkWgQEGoM4M2P4vi+FhL8UFHtuZHdBhKmTGt9iDCiOLwHm5G1z2Yqe/LVinVSb8Q2lCJBt0WihQ6JtW5uJPlgsIAYejfrJdcoEBb971O/mR9nngttxGanuRH7qQkRmDsGk7M2XKVigSHTpsBb+aUJ7mTbZLOAY1OeQ7z4Oopbj8BSWhNSeqb66HAQNyk8kVjG8xQR5/99x7S+fcMfaVwTJXp0b5GfLHZRe8mTuQgXIrHKtA1/9IBjkw1omSNaWdZZ5tyuAZ+gRRo4ymsQ5Yrd1RmyYFImkxUEAINtLe8jkob0WMiP0FxwUQIECeEJuv714L0FFuCZnKmhANHkv0plJzkxOL1vOHHCivrQF/r1zUMywxK16QSzAZQrgcXO02DTon6OSNOpjNUfBrrvbCuW/LqGdp+e/y7fUC1C8SkU2qgMV/c5g/Gzu4RnGFlPdSHSkUV6sfs9mq3Cmc+8shJDIT/NMBPvuL+LiyYd0Np09uwhMgQNluK5u0mnlIKRUXJYopAeX93y8stKCARJbGu9GXrFWnFPoUhGL4v8kM5oHvgQhv3NW4HaibyFcVwueK7EYgl1TIQZPevVWspHtUARyEby3Zm1c/Zdvkfw3NR7HJBXNxq9ePWscWCmrX2C6+QllZkWbIsFitgYLUL8mWBtbqXJATCyUdrGAGxZj45s8YwX1ixKVcxiweYIqD36NLkpy4S/dcZZsiDbRAFGj+MrIlXUY+uyBOzZfWBXI4hOPaxPSWxC2PV/6kUx4fjoQu5AwRCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(39860400002)(346002)(136003)(396003)(5660300002)(86362001)(8936002)(2906002)(54906003)(110136005)(31686004)(91956017)(4326008)(66476007)(316002)(8676002)(64756008)(66446008)(66946007)(76116006)(66556008)(36756003)(53546011)(122000001)(38100700002)(6506007)(6512007)(82960400001)(71200400001)(31696002)(478600001)(966005)(6486002)(41300700001)(186003)(26005)(38070700005)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L3ZNWWQ2OTRua0o4M2duZ0djVFFJTDQvNGY5RTE3QUNMRXVCSEVGbDViSUNL?= =?utf-8?B?bjRFMCsva3VhSC8vZ1BnOGJkb3VKTHFVaXdMOGpiOGVDSXJ0OVI1MVU3Q0Ni?= =?utf-8?B?TFBFcFZ2YURMRVFBa0hidU8wNmw4YWw2OWNiZHFLbzB6c0RYZnZBcG50L2tB?= =?utf-8?B?NlNNMHhEbVVlUFRFUklQeUFQWHRqbmRCZFhETi9LQXdQUm5yWUl4MVFWYVhm?= =?utf-8?B?TDBiZWVDNXJWOEdjK2lsblpyWW9HRWhXc200cGQxZko5aGFUSno3b3VGcWFO?= =?utf-8?B?cTM4MVFDM096ZHNpVkljM1d3TXEyK2JnT1BUQ09KUUlKTVk0dzJuWlJWWUFR?= =?utf-8?B?aUsyU3IwSXpaTkdzdW5Bem5vU1E1SGIzME54eEVMbWRZWVJXei94ZzFRMnRT?= =?utf-8?B?TG1JMnl3SEdBZloxdjVtNTVKOXFTNmN1Rms5N3VRUkRBdmYvSU45S29ZOGNY?= =?utf-8?B?WFppMXBLbUZ0OGU1SmVXNjZmZWVxQ1lGblVteWFRbG5tUkVwOTBQbHBDYSt0?= =?utf-8?B?c1JpUE5TQzdRNXR5M0FnNlVqOVpVWWs4ZEZSZHlrYWMzVlVSYWNVUCtkQ0Fm?= =?utf-8?B?TUhLUUtPWFVvT0VTT2lOZGpGc29ONVNzckEyOEhhR1cyRHIxYkZnTzYxK3hE?= =?utf-8?B?TmE4WWhsZmxGajlZdERnQlFJRWVqd2xQSkU3cWkxeGhzRTNObGF2eG9CSnBh?= =?utf-8?B?bUlWRFVua0Z6UnFCRWZlMXZQUTVrRnlGVGJXZ044QjUza2NDWElQNlR2RzZ6?= =?utf-8?B?Zk1pSVVCT2h0SjlTWDk2ekxXc1htbHdDaXJkYkZ1eFpsS1c4V1ZKbEQvNU1z?= =?utf-8?B?R0lNUG5idVlWNnNEWDF1VFMyWEI0Kzdqc0VSR0ZtQnZDRW80UFVEMVNGcFBN?= =?utf-8?B?QTlyS3BKTmRYKytFb2NXdXkxcmZvNDVoYUo1T3Exd3l6b0E5cVhINnRFcGNN?= =?utf-8?B?Q2hxL3o5OFRvZTJFRVJnVnVwYStSbm05KzlxU2ZmWGdSckhhWnVkNnZHMTZ0?= =?utf-8?B?UHU2VmNtcWVCNkRvVmVRUUZLRFNqWjBiNTc1Qzg0M3dMYjFBdWkvYUNrUU16?= =?utf-8?B?MFZlS3V4ZHBCVlYvLzBRQ05PRzFTTHQyTThSMWFUaC8vT0w5d21yK2hqUkQw?= =?utf-8?B?NUMyMHhocHJjOVY1Qktkc2lzZUUrMTFqZVhKMFRFSCtLQmRPWG84RmxxYlhS?= =?utf-8?B?citaWlNlZ2k4YXM2Z1RyYXhCa3RzdTNNRFpwczZoNGhKczdoeEgvdWljaFlD?= =?utf-8?B?em5Ta2kxNmtCdXZadHdQb09lVlVkZVJHTUNJaDZxM0xaaG1qbUIrTGpuWVMy?= =?utf-8?B?eEJVRm1PRnhhWGJ0WU1lMTVRd2VUUnYxeitsV3cxbVllMWtUNXVqYk5ob0s3?= =?utf-8?B?bFFlUjBwM0hsb2Uzd2J0VUJUcEd1Q2U4RmxoYzRtWDVBanVCd1hCQlB5RkF6?= =?utf-8?B?Zk1kaWtqemVvV1ZTblE0a1U1TmJFUEtnVndkaFltd0liaXZjQ3NLdzRxcjhp?= =?utf-8?B?UlpaeHhueUhKWnJ4THA2VjdtSUVvOEFrc0RFNS9hZFhyQWpGTlprTWEzNWRN?= =?utf-8?B?Wkl0WXpSeXhnODdLYmZqcWxyYjJNdStzdCtPZVFmL2twZy85Z0NMZThGS1J2?= =?utf-8?B?eFpNSS84NjM5bXZldzg3WWNMeHlldFFva3hES3l5K0kzWDFWWFNQVlBQSmhK?= =?utf-8?B?aUx2bWtxbkd3ZVFIalBQTlliRkJGYWpkSWJRQWZ6dDRwaUFtc1dUcXB5RWRl?= =?utf-8?B?ZDFHeFBLV1pjNWlzUXYvWkJtU2IvL3R1L1c3dUprcWVndXlWUjJwZGo4OTAy?= =?utf-8?B?c29uT0xnUWgxM1RHKzVJUmlIS2xhbk5ELzcvd0w0ZUovZ2ZVU2s4aXFmRDFQ?= =?utf-8?B?dTVmR1lGNkJKZEJsaERFblhoTTY3bEJackZCQmJ0WmlUd1FIakJKWGFHc1Uv?= =?utf-8?B?Z2lwb2cxUm15MXhPa1NhM2tHeXdsekZwenAybnZHNHE2YWpWZEdIUjdaRnpE?= =?utf-8?B?RVk4bXlMdGxRdk1VYmhjeWNKWkZXejNTK3JMR09JVmJoemJpc0toZ054czZr?= =?utf-8?B?cEhFdzlUc2hOQ3NpYmxYTzc3RjI4SDdTNlQ1N0ZERzluSXNLNmluVWtHaXll?= =?utf-8?Q?QT8OYO8smPw21k4WNR278KAtC?= Content-Type: text/plain; charset="utf-8" Content-ID: <0BDF62F3BDC99841B1068B30DAFBF4EC@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9d9bcb8d-0884-4ed0-86ac-08da690c6344 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jul 2022 22:25:15.1680 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7CBBaWmmqkMjpYHtpFbSTNaou5LcpmPIoJrekML+nnxHEqpH0YdH859FRBM1I+prSi7RMEWguB7AE1RYUuZVPk42eZ4P1lcKi/G7IsLz79o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6100 T24gMTgvMDcvMjAyMiAyMjozMSwgY2hyaXNAZGFsZXNzaW8ub3JnIHdyb3RlOg0KPiBJIGFtIHRy eWluZyB0byBydW4gWGVuLTQuMTYuMS00LmZjMzYgb24gRmVkb3JhIDM2IG9uIGEgYnJhbmQgbmV3 IExlbm92bw0KPiBUaGlua1N0YXRpb24gcDYyMCwgYnV0IEkga2VlcCBnZXR0aW5nIHRoZSBmb2xs b3dpbmcgZXJyb3IgYm9vdGluZyB0aGUNCj4gWGVuIGtlcm5lbC4NCj4gDQo+IFBhbmljIG9uIENQ VSAwOg0KPiBGQVRBTCBUUkFQOiB2ZWMgNywgI05NWzAwMDBdDQo+DQo+IFZlcnNpb24gaW5mbzoN Cj4gTmFtZSDCoCDCoCDCoCDCoDogeGVuDQo+IFZlcnNpb24gwqAgwqAgOiA0LjE2LjENCj4gUmVs ZWFzZSDCoCDCoCA6IDQuZmMzNg0KDQpTbyBodHRwczovL2tvamkuZmVkb3JhcHJvamVjdC5vcmcv a29qaS9idWlsZGluZm8/YnVpbGRJRD0xOTkxMTgyIHNob3VsZA0KYmUgdGhlIGJpbmFyeSBidWls ZCBpbiB1c2UsIGFuZCBsb29raW5nIGF0IHRoZSBkZWJ1ZyBzeW1zLCBpdCByZWFsbHkNCmRvZXMg aGF2ZToNCg0KZmZmZjgyZDA0MDQzOWM4MCA8YW1kX2lvbW11X2luaXQ+Og0KLi4uDQpmZmZmODJk MDQwNDNhMDBjOiAgICAgICAwZiA2ZSBjMiAgICAgICAgICAgICAgICBtb3ZkICAgJWVkeCwlbW0w DQpmZmZmODJkMDQwNDNhMDBmOiAgICAgICAwZiA2MiBjMCAgICAgICAgICAgICAgICBwdW5wY2ts ZHEgJW1tMCwlbW0wDQpmZmZmODJkMDQwNDNhMDEyOiAgICAgICA0OSA4OSA4NyBjMCAwMCAwMCAw MCAgICBtb3YgICAgJXJheCwweGMwKCVyMTUpDQpmZmZmODJkMDQwNDNhMDE5OiAgICAgICA0MSAw ZiA3ZiA4NyBkMCAwMCAwMCAgICBtb3ZxICAgJW1tMCwweGQwKCVyMTUpDQpmZmZmODJkMDQwNDNh MDIwOiAgICAgICAwMA0KDQpTbyBoYXJkd2FyZSBpcyBjb3JyZWN0IC0gdGhpcyBidWlsZCBvZiBY ZW4gaXMgbm9uc2Vuc2UuDQoNClRoZSBiaW5hcnkgaXMgYWxzbyBmdWxsIG9mIC5hbm5vYmluXyBz dHVmZiB3aGljaCBhcHBlYXJzIHRvIGJlIHNvbWUga2luZA0Kb2YgR0NDIHBsdWdpbiBmb3Igd2F0 ZXJtYXJraW5nLg0KDQpNaWNoYWVsOiBBbnkgaWRlYSB3aGF0J3MgZ29pbmcgb24gaGVyZT8gIFNv bWV0aGluZyBoYXMgY2F1c2VkIEdDQyB0bw0KZW1pdCBzb21lIE1NWCBsb2dpYyB3aGljaCBpcyB1 bHRpbWF0ZWx5IHdoeSB0aGluZ3MgZXhwbG9kZWQsIGJ1dCB0aGlzDQpwcm9iYWJseSBtZWFucyB0 aGF0IHNvbWUgb2YgdGhlIGJ1aWxkIENGTEFHUyBnb3QgZHJvcHBlZC4NCg0KVGhhbmtzLA0KDQp+ QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 18 23:05:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 18 Jul 2022 23:05:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370189.601870 (Exim 4.92) (envelope-from ) id 1oDZnU-0004CA-R6; Mon, 18 Jul 2022 23:05:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370189.601870; Mon, 18 Jul 2022 23:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDZnU-0004C2-Ny; Mon, 18 Jul 2022 23:05:04 +0000 Received: by outflank-mailman (input) for mailman id 370189; Mon, 18 Jul 2022 23:05:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDZnS-0004Bw-Pu for xen-devel@lists.xenproject.org; Mon, 18 Jul 2022 23:05:02 +0000 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ca8e159-06ee-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 01:05:01 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ca8e159-06ee-11ed-bd2d-47488cf2e6aa Date: Mon, 18 Jul 2022 23:04:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658185498; x=1658444698; bh=IGug+KbOsdsSi0jYks7QeMEj+QIc+CTE7P3VJe6QcAE=; h=Date:To:From:Reply-To:Subject:Message-ID:Feedback-ID:From:To:Cc: Date:Subject:Reply-To:Feedback-ID:Message-ID; b=UAzMzqJj6VWzsEuMzeTEl1E9PrpTNpWetCvi+epIyp86TxPAVfp6ax3fk2K0ugZcv PlC03dFV6lr6B+HAHeoJNd3MbWwb+NPEaFZRyjy51x778B0UQGfyIyJu7sKV0C+ovc bmA6zY0mGZ3fnjWsRdcWcvsebmijWSXt+DEbuWAJghZlwvbHzhWiCutFq/jJpH5TUb rvy+Wby7YpjlvF3mfx8CGbRq/IZEqZ6/yWI9wJFon9FTESD+249UcUVg0E86Uy2seA fSFbYG1RPGzNe96OB06mxGAZheFhP8GCAaPDtUv5CbJn9bBghkJ9+y7xX+gDTIVz5G O6wh8RlLHiguw== To: "xen-devel@lists.xenproject.org" From: Dylanger Daly Reply-To: Dylanger Daly Subject: Ryzen 6000 (Mobile) Message-ID: Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_NT4Tmx9hN5ylRijBXw7q4o1wHJjCp2qxR1MkXg6Qjg" This is a multi-part message in MIME format. --b1_NT4Tmx9hN5ylRijBXw7q4o1wHJjCp2qxR1MkXg6Qjg Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGkgQWxsLAoKSSdtIGhhdmluZyBpc3N1ZXMgZ2V0dGluZyBRdWJlc09TIHJ1bm5pbmcgb24gbXkg TGVub3ZvIFlvZ2EgU2xpbSA3IFByb1ggKEFNRCBSeXplbiA2ODAwSFMpCgpGaXJzdGx5IGluIG9y ZGVyIHRvIGJvb3QgdGhlIGRldmljZSBhdCBhbGwsIEknbSByZXF1aXJlZCB0byBhZGQgYGRvbTBf bWF4X3ZjcHVzPTEgZG9tMF92Y3B1c19waW5gIHRvIGRvbTAncyBDTURMSU5FLCB0aGlzIGlzIHNp bWlsYXIgdG8gd2hhdCBJIGhhZCB0byBkbyBwcmV2aW91c2x5IC0gaHR0cHM6Ly94ZW4ubWFya21h aWwub3JnL3NlYXJjaC8/cT1SeXplbiNxdWVyeTpSeXplbitwYWdlOjErbWlkOmYzaGVsNHlqMjVx aWxhYnYrc3RhdGU6cmVzdWx0cyB3aXRoIHRoZSBSeXplbiA0MDAwIHNlcmllcywgaG93ZXZlciB3 aXRob3V0IHRoZXNlIG9wdGlvbnMgYWRkZWQgZG9tMCBuZXZlciBmdWxseSBib290cyBpbnRvIEZl ZG9yYS4KClRoZSBvdGhlciBpbnRlcmVzdGluZyBpc3N1ZSBJJ20gaGF2aW5nIGlzIHVwb24gYm9v dGluZyBhbnkgVk0sIGp1c3QgYSBub3JtYWwgc2ltcGxlIFZNIHdpdGhvdXQgYW55IFBDSSBkZXZp Y2VzIGF0dGFjaGVkLCBpdCdsbCBzdWNjZXNzZnVsbHkgc3RhcnQsIGFib3V0IDEgc2Vjb25kIHdp bGwgcGFzcyB0aGVuIHRoZSBlbnRpcmUgZGV2aWNlIHdpbGwgaGFuZyBhbmQgcmVzZXQsIGl0J3Mg dmlydHVhbGx5IGltcG9zc2libGUgdG8gZ2V0IGFueSBsb2dzIGF0IGFsbCBvdXQgb2YgdGhlIGRl dmljZSB3aGVuIGl0J3MgaW4gdGhpcyBzdGF0ZS4KCkZZSTogUXViZXNPUyB1c2VzIFhlbiA0LjE0 CgpUaGFua3MgYWxs --b1_NT4Tmx9hN5ylRijBXw7q4o1wHJjCp2qxR1MkXg6Qjg Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+SGkg QWxsLDwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTog MTRweDsiPjxicj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250 LXNpemU6IDE0cHg7Ij5JJ20gaGF2aW5nIGlzc3VlcyBnZXR0aW5nIFF1YmVzT1MgcnVubmluZyBv biBteSBMZW5vdm8gWW9nYSBTbGltIDcgUHJvWCAoQU1EIFJ5emVuIDY4MDBIUyk8L2Rpdj48ZGl2 IHN0eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250LXNpemU6IDE0cHg7Ij48YnI+PC9k aXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+ Rmlyc3RseSBpbiBvcmRlciB0byBib290IHRoZSBkZXZpY2UgYXQgYWxsLCBJJ20gcmVxdWlyZWQg dG8gYWRkIGA8c3Bhbj5kb20wX21heF92Y3B1cz0xIGRvbTBfdmNwdXNfcGluPC9zcGFuPmAgdG8g ZG9tMCdzIENNRExJTkUsIHRoaXMgaXMgc2ltaWxhciB0byB3aGF0IEkgaGFkIHRvIGRvIHByZXZp b3VzbHkgLSZuYnNwOzxzcGFuPjxhIHRhcmdldD0iX2JsYW5rIiByZWw9Im5vcmVmZXJyZXIgbm9m b2xsb3cgbm9vcGVuZXIiIGhyZWY9Imh0dHBzOi8veGVuLm1hcmttYWlsLm9yZy9zZWFyY2gvP3E9 Unl6ZW4jcXVlcnk6Unl6ZW4rcGFnZToxK21pZDpmM2hlbDR5ajI1cWlsYWJ2K3N0YXRlOnJlc3Vs dHMiPmh0dHBzOi8veGVuLm1hcmttYWlsLm9yZy9zZWFyY2gvP3E9Unl6ZW4jcXVlcnk6Unl6ZW4r cGFnZToxK21pZDpmM2hlbDR5ajI1cWlsYWJ2K3N0YXRlOnJlc3VsdHM8L2E+Jm5ic3A7d2l0aCB0 aGUgUnl6ZW4gNDAwMCBzZXJpZXMsIGhvd2V2ZXIgd2l0aG91dCB0aGVzZSBvcHRpb25zIGFkZGVk IGRvbTAgbmV2ZXIgZnVsbHkgYm9vdHMgaW50byBGZWRvcmEuPC9zcGFuPjwvZGl2PjxkaXYgc3R5 bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPjxzcGFuPjxicj48 L3NwYW4+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXpl OiAxNHB4OyI+PHNwYW4+VGhlIG90aGVyIGludGVyZXN0aW5nIGlzc3VlIEknbSBoYXZpbmcgaXMg dXBvbiBib290aW5nIGFueSBWTSwganVzdCBhIG5vcm1hbCBzaW1wbGUgVk0gd2l0aG91dCBhbnkg UENJIGRldmljZXMgYXR0YWNoZWQsIGl0J2xsIHN1Y2Nlc3NmdWxseSBzdGFydCwgYWJvdXQgMSBz ZWNvbmQgd2lsbCBwYXNzIHRoZW4gdGhlIGVudGlyZSBkZXZpY2Ugd2lsbCBoYW5nIGFuZCByZXNl dCwgaXQncyB2aXJ0dWFsbHkgaW1wb3NzaWJsZSB0byBnZXQgYW55IGxvZ3MgYXQgYWxsIG91dCBv ZiB0aGUgZGV2aWNlIHdoZW4gaXQncyBpbiB0aGlzIHN0YXRlLjwvc3Bhbj48L2Rpdj48ZGl2IHN0 eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250LXNpemU6IDE0cHg7Ij48c3Bhbj48YnI+ PC9zcGFuPjwvZGl2PjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6 ZTogMTRweDsiPkZZSTogUXViZXNPUyB1c2VzIFhlbiA0LjE0PC9kaXY+PGRpdiBzdHlsZT0iZm9u dC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+PGJyPjwvZGl2PjxkaXYgc3R5 bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPlRoYW5rcyBhbGw8 L2Rpdj48ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jayIgc3R5bGU9ImZvbnQt ZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPg0KPC9kaXY+DQo= --b1_NT4Tmx9hN5ylRijBXw7q4o1wHJjCp2qxR1MkXg6Qjg-- From xen-devel-bounces@lists.xenproject.org Tue Jul 19 00:59:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 00:59:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370262.601916 (Exim 4.92) (envelope-from ) id 1oDbZt-0002H2-K0; Tue, 19 Jul 2022 00:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370262.601916; Tue, 19 Jul 2022 00:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDbZt-0002Gv-HS; Tue, 19 Jul 2022 00:59:09 +0000 Received: by outflank-mailman (input) for mailman id 370262; Tue, 19 Jul 2022 00:59:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDbZs-0002Gl-AN; Tue, 19 Jul 2022 00:59:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDbZr-000416-Rq; Tue, 19 Jul 2022 00:59:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDbZr-0001gz-GY; Tue, 19 Jul 2022 00:59:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDbZr-0006VG-GA; Tue, 19 Jul 2022 00:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=HZbLSOFMPGEjkQggdDF1Khy/oifzeOC/IUZL5vDgfOk=; b=uqq6TnMaduu0dqgiuoYdKgc2Kq kNM2psdbmUoJvz33Jv7hvz6NV6zhzMBIHj3AU3TcUcG7LJas6AIyX8SBU2Jf06hu1NQ5qW5+yfzkG HIhZs6IjGV/i2ATnrm1NgyDyb3Qzv+7tygF3pXzte1gJO8g0RdtYRfVQhXLewBEWpXcg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171675: all pass - PUSHED X-Osstest-Versions-This: ovmf=586b4a104bfeae277ce16687f852c4f26c4a3b73 X-Osstest-Versions-That: ovmf=792ebb6374f2b92e2c4b84f5b8d151a129ed81cc From: osstest service owner Date: Tue, 19 Jul 2022 00:59:07 +0000 flight 171675 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171675/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 586b4a104bfeae277ce16687f852c4f26c4a3b73 baseline version: ovmf 792ebb6374f2b92e2c4b84f5b8d151a129ed81cc Last test of basis 171671 2022-07-18 17:10:27 Z 0 days Testing same since 171675 2022-07-18 21:11:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Nate DeSimone jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 792ebb6374..586b4a104b 586b4a104bfeae277ce16687f852c4f26c4a3b73 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 01:29:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 01:29:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370271.601928 (Exim 4.92) (envelope-from ) id 1oDc2r-0004Gf-Sn; Tue, 19 Jul 2022 01:29:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370271.601928; Tue, 19 Jul 2022 01:29:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDc2r-0004GY-P2; Tue, 19 Jul 2022 01:29:05 +0000 Received: by outflank-mailman (input) for mailman id 370271; Tue, 19 Jul 2022 01:29:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDc2p-0004GQ-Gr for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 01:29:03 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150051.outbound.protection.outlook.com [40.107.15.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a2e0f5c-0702-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 03:29:00 +0200 (CEST) Received: from AS9PR06CA0049.eurprd06.prod.outlook.com (2603:10a6:20b:463::24) by AM6PR08MB4849.eurprd08.prod.outlook.com (2603:10a6:20b:c3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.15; Tue, 19 Jul 2022 01:28:57 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:463:cafe::69) by AS9PR06CA0049.outlook.office365.com (2603:10a6:20b:463::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19 via Frontend Transport; Tue, 19 Jul 2022 01:28:57 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 01:28:56 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Tue, 19 Jul 2022 01:28:56 +0000 Received: from 047afa700790.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 38CA9D0B-21DE-4F5B-85F4-4C3302DE0880.1; Tue, 19 Jul 2022 01:28:50 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 047afa700790.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 01:28:50 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by VI1PR08MB3983.eurprd08.prod.outlook.com (2603:10a6:803:e0::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Tue, 19 Jul 2022 01:28:47 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 01:28:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a2e0f5c-0702-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hDaR7wb0xXXzKSmqoz1NHJItPMqVg6FHa5mfuRLXrW4XCmVade7n6uSm7YhzVGaIsXs4g4AK6PYIi5BgEGBER2y1dJhlMiVX59YIaEdJ9utOysgWYXpxqHotURpsfBaId5awD3DlJDTRNyzfzf3xGltLZnY7g9w2xw1DJsmCYP2tWB+/Bpw/4vdEIDOp9W0BLqzdxO0+EphweaIy0XiEq7FSmSqrdFoTEb3h71yzKTAdbiHTQrETE6+nzUTXdWTSnG77cssM9W/15vb4mOxuTgzTxtQUZRtVZi1qmUFq2p+2rItFxAXcNHRZbR7L1cYKBkAzamXnUs/P6R2PnmnxHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=aArtn2jVJUDQ9SuTUnASFYlNf7Wq4XkKXsR0FGe12pBB4Yl1Py6guNcapbpY328/z2iDoFFk1+UgpkvH8Bj5JyWimUoGqSNbTDKbe5fy/4KVal0LmnzeZ+FqdZ5rXsyL8eX/T128CAeB3Iow0Glk3LkgDHgFD9epgkbds/yV9wLvSnBYnVMvr2NoCBNE9UG2O3tQaACbO6NIUJJDMwDS4uHfG4d+R6eQ0sgBwX5CgCNwD/EwMyP1j7N52fn4AqfnmHfQYE88asVGkK/YuMBiWQ7h1AnBvn6+sCvmY8p0HUS6NYcvkAfvRu4EdB4UkL34b+rEfVCFDMvsFvujoCesUw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=P5d2mOh8GaLQm7/BhCAADJD2gjBEzV8RBRfchAakT9E3r9GhBBY9eQSeQaft3OquUbhEgD8ffFXsUgiMjUT6wHayLRLNIJ/1TVtWi7pHdU9fWJu8fPcUngkDunLLpbKmyIEyEvmziJkixsHCA5CY4/+KmuN/VyzxRhda/y4oIUY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YWmXGKsCRn6XMZUU0aakAw3vXFUwaVNrv4fWtNRsXDo/sHHdy69Z7w56P8e92GgIz0CmQ0/WpqPjXaybwEotleJ2RPegNUZME6wOyesejo3T47x23BycyG7Pg3q/681vBUAwUuDPLZDjxCOPuTo5s6XqcawG2DOHHg6J5aSgaUPmS9tV+wXa/AdCtHSE+zzonMSYA/174RKjc5581cdeZcmUZZ1KA1NJYy8MKaVajs+OXtrKytz52cE4imHAzkzfU5WyOn1pd8sHV423xjr2UxQJKH4jofzIEhQmWUDBzjFFqN6iter4GhPgHDvVnlrnd/5ZtcdhQt9sdVHxwhEurQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=nwJwhx8P/u3IYv/jHvfLVzPh1zSZdXpglEVaYXaMBT43kk+oF7HOh02V7S1OqiLRHgZSxJW1biXyXnfLBvJawlP+KV7RMYhxsy+RJhYy/4ZmmW7ZybjNkS5uNCaW4Qxv+WCY+TQCSIsAMk60P8fH16jFiBpU+a8H3tSi5sAz5KALFVUR/xKnh1eJcDZaMYdWzACB1RwERoOfYQrkgU3HV7wS6xBhKdTFirpWcmuIp8RFjznh04eBR6bgsE8yxLShnWsAqMGyk2YjotKYxMtpD8eIHumHGL1v3w4e+rObOGaHzmkXwwUIuMvorCfkn8gyxp49NrE2y4lg+ipD/rGzNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z5tcjebPwgcJX/ifsKTVqAV3Ng3khA/KYOBCcGg8hXA=; b=P5d2mOh8GaLQm7/BhCAADJD2gjBEzV8RBRfchAakT9E3r9GhBBY9eQSeQaft3OquUbhEgD8ffFXsUgiMjUT6wHayLRLNIJ/1TVtWi7pHdU9fWJu8fPcUngkDunLLpbKmyIEyEvmziJkixsHCA5CY4/+KmuN/VyzxRhda/y4oIUY= From: Henry Wang To: Julien Grall , Jan Beulich , Juergen Gross CC: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation Thread-Topic: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation Thread-Index: AQHYcZr+xugQmCaBT0SxSahY0q90Lq2En0iAgAAEOQCAAJWm8A== Date: Tue, 19 Jul 2022 01:28:47 +0000 Message-ID: References: <20220527072427.20327-1-jgross@suse.com> <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> In-Reply-To: <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 49BA7CE902C7F34D8BB445F8598DE316.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 8a1dfbbd-57c5-47ce-1640-08da69260c80 x-ms-traffictypediagnostic: VI1PR08MB3983:EE_|VE1EUR03FT064:EE_|AM6PR08MB4849:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: B3v1BdGwmR674biz8fvTY+fF/nnVStP13Hh7vXgBugMGdGofW3YtwGgvF3flEOHv0mNfy/G9YbMhYA73YSzmTLypdOuQ/KNnLQFNoSf/CP6+SRuXbqp+9RStvU9qjHNmwUwc02Yj69zBj5QAgCWQIPnZbMnD48PFqMQOOp9QI+IYZa5xtmnIso5ImJh1C5UcbJcDMOJNpIA4EVtx/0s9K5TxxDKfl2yzou+eu4lWXyjGb/6tXluSuOw5RQlFyA8IiTi33MWxXShlGviRSo6nxRd4fLlydUhATo5eTmLCg2XsmOobS6GVAVn1sqyYNK8JGbIjpjBZgo9TqGmh/X10wRfCufaTQHkCgJ5HlAvLnFXX40J/eArT4I3eFcd+8qkftUw4ALD30boqM7QG+be8Ycs8C3qhM1nCpjK4dbn+uV+yxsSiwLnO9WD/1Etv1vqU4eKktRTU2uQO5zgIko7rU9C7YducZgYaIqcu21hLvcXRnhcg9cQeo8P5HWXNeLwgppzOE8V4/c5SDc4JNRZ/yI2P7TtamoKdOqZ6g1S6S4vzj9UNoO328YnzGTr7cHruqyzJUVtwZaowQOxFZ9FX+o6VFDNyVSpU0SgtnizryYqsl53e1Ja6q4tPRjS8g4lQwDKnlXyQqSR9LLPbjxarTvqzkZKXSyhDoS9/tE4M7S/Sby3RJGqobupGYebXQPBFBAU/hS1Sq9ZJgQAXjyI71IdpRPVKD1l5AUCOxxvbScf671tlKKitXT88Dg/rAa5n/oUYpmvgwXyb1hYj+qXwDXV7CvWS8+Z1BH0uvrJloaAVI3cDi55e3dtOGMzaDk4b X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(366004)(8676002)(66476007)(66446008)(64756008)(186003)(83380400001)(478600001)(66556008)(52536014)(26005)(6506007)(4326008)(9686003)(7696005)(8936002)(53546011)(38070700005)(54906003)(5660300002)(71200400001)(122000001)(316002)(2906002)(76116006)(38100700002)(86362001)(110136005)(66946007)(41300700001)(55016003)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3983 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6a08cbe3-bf6f-4406-72b6-08da69260725 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8KyFALseBuZTSiCCEJP8Q3yb/0gwJlWdqa5y18djZxxtmqx29bqLdDbF+75TkCfxyH16cSt3kIAO2IN3c6G4h5mPcAplKqURoS0BzRpH8+fjTVjYc4qeSVgumObMNl2wMtbS7CDKe/q9OOTQR33Iys7gubDHF28fqdNp6mNBJPmkbpUBSkxYH//k+7Y169ywMG3DrX7Ce10N1SsotQHKKgGmW70LFZkrpjsUpI9ZFov6xMlWETuJyCFyQoZnlH1rdq5JGHGusufJGUpJEbsfNx9TgSaUlL1R31nhJULfqNGRX98Ui9y9FRDCcIv9s3cq1YRu1Uk6y7umev10yONGDw60ekeKPDDTaETIEIhDc9WmO34pYuchi9jGNy6GM8c1DnbVeJlZTseVjFcZAUpQff6LykK+VG4O4quTqaDIayWQEE/VOHr6TwKrdSNvgNGX+M3KjfHqgT7Zh5pS5Vfn2wPvYgeXC1ChPs7ZFLil1kXXv+c4FubnDJSKRI3Yn0l3powDKN/cFMGtGuMH3wljUB/UnEHuUATlE1bqBOW4mi0Vg+1DMIiX+E0rMeiVlLN8QqzD3zTHV54o+U0zmGEWWf9Hskx2hnA37YZp2PjZ2IvHFqNilZLqkb53B0Axwhc5SiZHfl2kjDFJSIEqH41FLtFIasnD1p5L3efRJTC41Q3cBuuTo4xQK9V9VkD0oDKHsKm5feWoN/a4SuitfLt8l6hmXYbcX1qExZuK9GIwtnHSjM3WKRXhaYYUUpvcQY/cOw2BlFmEPjSOU1pFosV6n+FzrTQPQQlLks4jxZToEEjjeoVOE2YMfb9HT6CQsDb6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(346002)(46966006)(40470700004)(36840700001)(33656002)(47076005)(9686003)(186003)(8936002)(41300700001)(40480700001)(70586007)(81166007)(55016003)(7696005)(4326008)(316002)(6506007)(26005)(478600001)(8676002)(82740400003)(86362001)(356005)(336012)(52536014)(54906003)(40460700003)(53546011)(110136005)(2906002)(83380400001)(82310400005)(36860700001)(70206006)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 01:28:56.4647 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1dfbbd-57c5-47ce-1640-08da69260c80 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4849 SGkgSnVsaWVuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEp1bGll biBHcmFsbCA8anVsaWVuQHhlbi5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggdjIgMC80XSB0 b29scy94ZW5zdG9yZTogYWRkIHNvbWUgbmV3IGZlYXR1cmVzIHRvIHRoZQ0KPiBkb2N1bWVudGF0 aW9uDQo+IA0KPiBIaSBKYW4sDQo+IA0KPiBPbiAxOC8wNy8yMDIyIDE3OjEyLCBKYW4gQmV1bGlj aCB3cm90ZToNCj4gPiBPbiAyNy4wNS4yMDIyIDA5OjI0LCBKdWVyZ2VuIEdyb3NzIHdyb3RlOg0K PiA+Pg0KPiA+PiBDaGFuZ2VzIGluIFYyOg0KPiA+PiAtIGFkZGVkIG5ldyBwYXRjaCAxDQo+ID4+ IC0gcmVtb3ZlIGZlYXR1cmUgYml0cyBmb3IgZG9tMC1vbmx5IGZlYXR1cmVzDQo+ID4+IC0gZ2V0 LWZlYXR1cmVzIHdpdGhvdXQgZG9taWQgcmV0dXJucyBYZW5zdG9yZSBzdXBwb3J0ZWQgZmVhdHVy ZXMNCj4gPj4gLSBnZXQvc2V0LXF1b3RhIHdpdGhvdXQgZG9taWQgZm9yIGdsb2JhbCBxdW90YSBh Y2Nlc3MNCj4gPj4NCj4gPj4gSnVlcmdlbiBHcm9zcyAoNCk6DQo+ID4+ICAgIHRvb2xzL3hlbnN0 b3JlOiBtb2RpZnkgZmVhdHVyZSBiaXQgc3BlY2lmaWNhdGlvbiBpbiB4ZW5zdG9yZS1yaW5nLnR4 dA0KPiA+PiAgICB0b29scy94ZW5zdG9yZTogYWRkIGRvY3VtZW50YXRpb24gZm9yIG5ldyBzZXQv Z2V0LWZlYXR1cmUgY29tbWFuZHMNCj4gPj4gICAgdG9vbHMveGVuc3RvcmU6IGFkZCBkb2N1bWVu dGF0aW9uIGZvciBuZXcgc2V0L2dldC1xdW90YSBjb21tYW5kcw0KPiA+PiAgICB0b29scy94ZW5z dG9yZTogYWRkIGRvY3VtZW50YXRpb24gZm9yIGV4dGVuZGVkIHdhdGNoIGNvbW1hbmQNCj4gPg0K PiA+IEhtbSwgbG9va3MgbGlrZSBJIGRpZCBjb21taXQgdjEgb2YgdGhpcyBzZXJpZXMsIG5vdCBu b3RpY2luZyB0aGUgdjIgX2FuZF8NCj4gPiBzZWVpbmcgdGhlcmUgaGFkIGJlZW4gUi1iIHdpdGgg bm8gb3RoZXIgZm9sbG93LXVwIChsZWF2aW5nIGFzaWRlIHRoZSB2MikNCj4gPiBpbiBhIGxvbmcg dGltZS4gUGxlYXNlIGFkdmlzZSBpZiBJIHNob3VsZCByZXZlcnQgdGhlIGNvbW1pdHMuIEknbSBz b3JyeQ0KPiA+IGZvciB0aGUgY29uZnVzaW9uLiAoSSBhbHNvIHdvbmRlciB3aHkgdGhlIFItYiB3 ZXJlbid0IGNhcnJpZWQgb3ZlciB0byB2Mi4pDQo+IA0KPiBwYXRjaCAjMSBpcyBhIG5ldyBwYXRj aC4gVGhlIHBhdGNoICMyLCAjMywgIzQgaGF2ZSBiZWVuIHJld29yZGVkIGFuZCB0aGUNCj4gb3Zl cmFsbCBpbnRlcmFjdGlvbiBpcyBkaWZmZXJlbnQuIFNvIEkgZG9uJ3QgdGhpbmsgdGhlIHJldmll d2VkLWJ5DQo+IHNob3VsZCBoYXZlIGJlZW4gY2FycmllZC4NCj4gDQo+IEkgaGFkIHNvbWUgY29u Y2VybnMgaW4gdjEgd2hpY2ggd2VyZSBhZGRyZXNzZWQgaW4gdjIuIEkgaGF2ZSByZXZpZXdlZCB2 Mg0KPiBhIHdoaWxlIGFnby4gRnJvbSBteSBwZXJzcGVjdGl2ZSwgcGF0Y2ggIzEsICMzLCAjNCBh cmUgcmVhZHkgdG8gZ28uDQo+IFBhdGNoICMyIG5lZWRzIGEgcmVzcGluIGFuZCB3ZSBhbHNvIG5l ZWQgdG8gY2xhcmlmeSB0aGUgaW50ZWdyYXRpb24gd2l0aA0KPiBtaWdyYXRpb24vbGl2ZS11cGRh dGUuDQo+IA0KPiBBcyB5b3UgY29tbWl0dGVkLCBJIHdvdWxkIGJlIE9LIGlmIHRoaXMgaXMgYWRk cmVzc2VkIGluIGEgZm9sbG93LXVwDQo+IHNlcmllcy4gQnV0IHRoaXMgKm11c3QqIGJlIGFkZHJl c3NlZCBieSB0aGUgdGltZSA0LjE3IGlzIHJlbGVhc2VkDQo+IGJlY2F1c2Ugb3RoZXJ3aXNlIHdl IHdpbGwgY29tbWl0IG91cnNlbGYgdG8gYSBicm9rZW4gaW50ZXJmYWNlLiBASGVucnksDQo+IHBs ZWFzZSBhZGQgdGhpcyBpbiB0aGUgYmxvY2tlciBsaXN0Lg0KDQpUaGFuayB5b3UgdmVyeSBtdWNo IGZvciB0aGlzIGluZm9ybWF0aW9uLiBJJ3ZlIGFkZGVkIHRoaXMgaW4gYmxvY2tlciBsaXN0Lg0K SSB3aWxsIGtlZXAgdGhhdCBpbiBtaW5kIGFuZCBzZW5kIChwcm9wZXIpIHJlbWluZGVycyBkdXJp bmcgdGhlIHRpbWVsaW5lDQpvZiB0aGUgNC4xNyByZWxlYXNlIHByb2Nlc3MuDQoNCktpbmQgcmVn YXJkcywNCkhlbnJ5IA0KDQo+IA0KPiBDaGVlcnMsDQo+IA0KPiAtLQ0KPiBKdWxpZW4gR3JhbGwN Cg== From xen-devel-bounces@lists.xenproject.org Tue Jul 19 03:06:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 03:06:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370281.601939 (Exim 4.92) (envelope-from ) id 1oDdYv-0007C8-13; Tue, 19 Jul 2022 03:06:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370281.601939; Tue, 19 Jul 2022 03:06:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdYu-0007Bi-S4; Tue, 19 Jul 2022 03:06:16 +0000 Received: by outflank-mailman (input) for mailman id 370281; Tue, 19 Jul 2022 03:06:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdYt-0007BY-9q; Tue, 19 Jul 2022 03:06:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdYt-0004v3-5c; Tue, 19 Jul 2022 03:06:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdYs-0008Qn-LJ; Tue, 19 Jul 2022 03:06:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDdYs-0007Gp-Kt; Tue, 19 Jul 2022 03:06:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=p1W9/9c2Bci/GRf4pnRy+ZekpZ4b5++YODGP0HV941c=; b=ppiYSZnx0+TDzLcAlQOJnpxlkD oOYOuWmtoTJ8cxPZBhQO+p4kW7FKrLdVjCYWEv1uRgTmrrMWHbdVeY5L3SUPbsX3LmB0vgxkZHpe0 F/5hmKquIynOX1AU3Er+gHGTESK1muuVA5Ao6oGr+J2FMdujzUH44d1vt5G2V9pnVckE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171672: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0af91dc0326cba12795e0b8fa8f665776e2a9e13 X-Osstest-Versions-That: xen=a5fb66f4513c2c2d222dcc3753163b15690bd003 From: osstest service owner Date: Tue, 19 Jul 2022 03:06:14 +0000 flight 171672 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171672/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171666 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171666 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171666 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171666 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171666 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171666 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171666 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171666 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171666 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171666 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171666 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171666 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 0af91dc0326cba12795e0b8fa8f665776e2a9e13 baseline version: xen a5fb66f4513c2c2d222dcc3753163b15690bd003 Last test of basis 171666 2022-07-18 02:05:01 Z 1 days Testing same since 171672 2022-07-18 18:38:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a5fb66f451..0af91dc032 0af91dc0326cba12795e0b8fa8f665776e2a9e13 -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 03:11:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 03:11:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370292.601958 (Exim 4.92) (envelope-from ) id 1oDdeC-0000UZ-Qy; Tue, 19 Jul 2022 03:11:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370292.601958; Tue, 19 Jul 2022 03:11:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdeC-0000US-OB; Tue, 19 Jul 2022 03:11:44 +0000 Received: by outflank-mailman (input) for mailman id 370292; Tue, 19 Jul 2022 03:11:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdeB-0000UG-Hh; Tue, 19 Jul 2022 03:11:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdeB-00051D-Et; Tue, 19 Jul 2022 03:11:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDdeB-0000Ch-0w; Tue, 19 Jul 2022 03:11:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDdeB-0007WU-0P; Tue, 19 Jul 2022 03:11:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+uhPXi5UiKrhT400j8X4MzCYPP3/ptAipKsX3ixNTmw=; b=RK/ytLt47Yc5QVM/NUCRe+xlcg yx8JkVtq2JMJZKw53ZlMlmJsBOp4P1d5RP5qVVgjENnlCBtfezIoroWsdV8JJE5CA6AtZZYjhIdd6 OVnp72xco3ZVP+SSbgMFKshrVz8Qxqjhup2Zqm26YHSGVP1uG7m0iu0uKIP3HwabVMO8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171677: all pass - PUSHED X-Osstest-Versions-This: ovmf=e21b2039112eeba9a93fdd7b70329a07a79c8f0e X-Osstest-Versions-That: ovmf=586b4a104bfeae277ce16687f852c4f26c4a3b73 From: osstest service owner Date: Tue, 19 Jul 2022 03:11:43 +0000 flight 171677 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171677/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e21b2039112eeba9a93fdd7b70329a07a79c8f0e baseline version: ovmf 586b4a104bfeae277ce16687f852c4f26c4a3b73 Last test of basis 171675 2022-07-18 21:11:53 Z 0 days Testing same since 171677 2022-07-19 01:11:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Guo Dong James Lu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 586b4a104b..e21b203911 e21b2039112eeba9a93fdd7b70329a07a79c8f0e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 04:35:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 04:35:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370302.601969 (Exim 4.92) (envelope-from ) id 1oDewY-0001Lb-RE; Tue, 19 Jul 2022 04:34:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370302.601969; Tue, 19 Jul 2022 04:34:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDewY-0001LU-O0; Tue, 19 Jul 2022 04:34:46 +0000 Received: by outflank-mailman (input) for mailman id 370302; Tue, 19 Jul 2022 04:34:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDewW-0001LO-Uz for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 04:34:45 +0000 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [2607:f8b0:4864:20::e33]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1bfe23fa-071c-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 06:34:43 +0200 (CEST) Received: by mail-vs1-xe33.google.com with SMTP id 125so1928204vsd.5 for ; Mon, 18 Jul 2022 21:34:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bfe23fa-071c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KxN37o8r5lialnTPBTEdzc7ULFbJA4Z5yiyB3T51vkw=; b=G3ktOcJmo8PVJOKfYcjNdXVYvWx5S8QQjxLle6d1sGKgfhjzxZHOkhdQl2f1dIwEh7 N57cTovsIcLwo7/JcqYqxQHr0qI8aru7cjmHQ+eicraepSXgW0hG4OFzHoDRCKfTI6di mHQNH617iG3rCCYeJTblB53/vdyXYLLHNU3puMud+hy2fgjrSvhQQbbaICcH+DATfmY+ wes7zW7XSnQlqFXh4+Rtv7joEW4/aLvnIMOQHBgKoIvAVcR6XfrxPg1OnOl9sdRjCYFp M09b+wSyNg7MM8wTnYruvyyH4KKkGO+AEed6LRPBmy0bvG6Kl3FRXeFyed8X6yArnCfV l3QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KxN37o8r5lialnTPBTEdzc7ULFbJA4Z5yiyB3T51vkw=; b=ByrcQwBPMZm4c7xiRyLRNWx+OTJstF4J+yDC3h+C8kFB5qqk0ni1oLdC5knbu4ZNYa CxXc6kjKmNqRjnteGTCfVNmhpX/F6CCy80ZWaObIF7gGruHWVWtDSPSjDoEIOsUIaXvB KnTyYE1pc5d8mL3liNjyPSLpNP6+KzUxvn0SmzTN3+qv4OgSEu8Dvm6wtCPWJPwjpXqS yuqvPWBODFiYs4pCBHpnlbyb9zsg3Qxl84cr5/2v8ttXhAPsteD9/l0LZIy3iO082Ein u2jxP/8xefTzwUYzBspOvjwFAKMZmLRlQUjvxHYVZRbE/n7dRwFcUk6xjkDGUOtiK+1R Mtkg== X-Gm-Message-State: AJIora/tMen0wmWEZvQUIsYPimKlq1fB5lK6CJWDgmI6kHPUoy/UFhrq Bfb5PmTxeOLNkep8I1vL3adPyGZyJ2xqwn+HTnulicbKmCY= X-Google-Smtp-Source: AGRyM1up8TFtlPSzJY427jNjcd2VXBEu852uUcYdftZ8D+462MF4KQ9oZpvB+DN2LhQbRvP9K2OrJXO1+zUewLRar18= X-Received: by 2002:a05:6102:667:b0:357:6577:a994 with SMTP id z7-20020a056102066700b003576577a994mr10446945vsf.77.1658205282412; Mon, 18 Jul 2022 21:34:42 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christopher Clark Date: Mon, 18 Jul 2022 21:34:31 -0700 Message-ID: Subject: Re: [RFC PATCH 0/2] Yocto Gitlab CI support To: Bertrand Marquis Cc: xen-devel , Doug Goldstein , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Thu, Jul 14, 2022 at 3:10 AM Bertrand Marquis wrote: > > This patch series is a first attempt to check if we could use Yocto in > gitlab ci to build and run xen on qemu for arm, arm64 and x86. Hi Bertrand, thanks for posting this. I'm still making my way through it, and should be able to speak more to the OE/Yocto aspects than the Xen automation integration but at first pass, I think that this is work in the right direction. A few quick early points: - The build-yocto.sh script is clear to understand, which is helpful. - The layers that you have selected to include in the build are good. Might be worth considering using openembedded-core, which is poky's upstream, but I think either is a valid choice. - listing the layers one-per-line in the script might make it easier to patch in additional layers downstream, if needed - The target image of 'xen-image-minimal' is the right start; it would be nice to be able to pass that as an input from the dockerfile to allow for using this with other images. - Possibly worth mentioning somewhere in the series description that this introduces coverage for x86-64 but not 32-bit x86 guests - it's the right choice given that this is just booting to a dom0. Christopher > The first patch is creating a container with all elements required to > build Yocto, a checkout of the yocto layers required and an helper > script to build and run xen on qemu with yocto. > > The second patch is creating containers with a first build of yocto done > so that susbsequent build with those containers would only rebuild what > was changed and take the rest from the cache. > > This is is mainly for discussion and sharing as there are still some > issues/problem to solve: > - building the qemu* containers can take several hours depending on the > network bandwith and computing power of the machine where those are > created > - produced containers containing the cache have a size between 8 and > 12GB depending on the architecture. We might need to store the build > cache somewhere else to reduce the size. If we choose to have one > single image, the needed size is around 20GB and we need up to 40GB > during the build, which is why I splitted them. > - during the build and run, we use a bit more then 20GB of disk which is > over the allowed size in gitlab > > Once all problems passed, this can be used to build and run dom0 on qemu > with a modified Xen on the 3 archs in less than 10 minutes. > > Bertrand Marquis (2): > automation: Add elements for Yocto test and run > automation: Add yocto containers with cache > > automation/build/Makefile | 2 + > automation/build/yocto/build-yocto.sh | 322 ++++++++++++++++++ > .../build/yocto/kirkstone-qemuarm.dockerfile | 28 ++ > .../yocto/kirkstone-qemuarm64.dockerfile | 28 ++ > .../yocto/kirkstone-qemux86-64.dockerfile | 28 ++ > automation/build/yocto/kirkstone.dockerfile | 98 ++++++ > 6 files changed, 506 insertions(+) > create mode 100755 automation/build/yocto/build-yocto.sh > create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile > create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile > create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfile > create mode 100644 automation/build/yocto/kirkstone.dockerfile > > -- > 2.25.1 > > From xen-devel-bounces@lists.xenproject.org Tue Jul 19 04:38:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 04:38:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370307.601980 (Exim 4.92) (envelope-from ) id 1oDezr-00026v-A7; Tue, 19 Jul 2022 04:38:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370307.601980; Tue, 19 Jul 2022 04:38:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDezr-00026k-6R; Tue, 19 Jul 2022 04:38:11 +0000 Received: by outflank-mailman (input) for mailman id 370307; Tue, 19 Jul 2022 04:38:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDezp-00026W-EH; Tue, 19 Jul 2022 04:38:09 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDezp-0006dQ-9i; Tue, 19 Jul 2022 04:38:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDezo-0004ZW-GK; Tue, 19 Jul 2022 04:38:08 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDezo-0000zU-Fx; Tue, 19 Jul 2022 04:38:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4AA5SvJNCrPRNBWNS7vCAENp78kjFYuNbqUPlq3YmFY=; b=X7gNHM1yPiSDP7Z4Nc2S8BaApO 90QrZ6w/GIYu1581vDHBUM9c4O4rCGLS0rgqtCHHYCFOnF/ztDonHTfEqpBb6Y/yPKVE0G0AtUQsb OEAsMTSbWsWu4UvDbcojP0TnnYp3hPTFWnBBf/GlyBs+et8xE+FJEEUlNIWFd1VwLG9E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171674: regressions - FAIL X-Osstest-Failures: linux-linus:build-arm64:xen-build:fail:regression linux-linus:test-arm64-arm64-examine:build-check(1):blocked:nonblocking linux-linus:build-arm64-libvirt:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit1:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-credit2:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-seattle:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:build-check(1):blocked:nonblocking linux-linus:test-arm64-arm64-xl-vhd:build-check(1):blocked:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=80e19f34c2887a8881084b7bb7480e9544d56b91 X-Osstest-Versions-That: linux=ff6992735ade75aae3e35d16b17da1008d753d28 From: osstest service owner Date: Tue, 19 Jul 2022 04:38:08 +0000 flight 171674 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171674/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64 6 xen-build fail REGR. vs. 171664 Tests which did not succeed, but are not blocking: test-arm64-arm64-examine 1 build-check(1) blocked n/a build-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-xl 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit1 1 build-check(1) blocked n/a test-arm64-arm64-xl-credit2 1 build-check(1) blocked n/a test-arm64-arm64-xl-seattle 1 build-check(1) blocked n/a test-arm64-arm64-xl-thunderx 1 build-check(1) blocked n/a test-arm64-arm64-xl-vhd 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171664 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171664 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171664 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171664 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171664 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171664 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171664 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171664 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 80e19f34c2887a8881084b7bb7480e9544d56b91 baseline version: linux ff6992735ade75aae3e35d16b17da1008d753d28 Last test of basis 171664 2022-07-17 21:11:10 Z 1 days Testing same since 171674 2022-07-18 19:40:02 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Shevchenko Bartosz Golaszewski Dipen Patel Linus Torvalds Thierry Reding jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 fail build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt blocked build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl blocked test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 blocked test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 blocked test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine blocked test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx blocked test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd blocked test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 80e19f34c2887a8881084b7bb7480e9544d56b91 Merge: ff6992735ade 85ff37e302ef Author: Linus Torvalds Date: Mon Jul 18 11:47:04 2022 -0700 Merge tag 'hte/for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux Pull hardware timestamp fix from Thierry Reding: "A single fix for an out-of-sync kerneldoc comment" * tag 'hte/for-5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux: gpiolib: cdev: Fix kernel doc for struct line commit 85ff37e302efdf173cff6d1a310c2f7f38f1d069 Author: Andy Shevchenko Date: Fri May 20 19:47:26 2022 +0300 gpiolib: cdev: Fix kernel doc for struct line Kernel doc validator is not happy: gpiolib-cdev.c:487: warning: Function parameter or member 'hdesc' not described in 'line' gpiolib-cdev.c:487: warning: Function parameter or member 'raw_level' not described in 'line' gpiolib-cdev.c:487: warning: Function parameter or member 'total_discard_seq' not described in 'line' gpiolib-cdev.c:487: warning: Function parameter or member 'last_seqno' not described in 'line' Describe above mentioned parameters. Fixes: 2068339a6c35 ("gpiolib: cdev: Add hardware timestamp clock type") Signed-off-by: Andy Shevchenko Acked-by: Dipen Patel Acked-by: Bartosz Golaszewski Signed-off-by: Thierry Reding From xen-devel-bounces@lists.xenproject.org Tue Jul 19 05:58:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 05:58:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370317.601991 (Exim 4.92) (envelope-from ) id 1oDgFc-0002x6-43; Tue, 19 Jul 2022 05:58:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370317.601991; Tue, 19 Jul 2022 05:58:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgFc-0002wz-1K; Tue, 19 Jul 2022 05:58:32 +0000 Received: by outflank-mailman (input) for mailman id 370317; Tue, 19 Jul 2022 05:58:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgFZ-0002wa-Lj for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 05:58:30 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150075.outbound.protection.outlook.com [40.107.15.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ce4cbeaa-0727-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 07:58:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4181.eurprd04.prod.outlook.com (2603:10a6:209:4c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 05:58:23 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 05:58:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce4cbeaa-0727-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mP22CRoj6w8u0c+0eOIaKeSl29rrJjifQV8HZmPcz94R1//Xt5goPgOm/arAxDcZixm44f+yNZaICepNjrjlddMTaZ0r54p6VzOmLFCEqW7XCkMBaaTKRPfSRBaRHPj+Er//OhA6ibAnp9lU+RW/o78E6y/o9jL0tXR/kjHyuySjl3V1WuhV+GU+z159v2Lxfz8RAHIKn602/YrbwhoS8DnZRUiudPOkHOKNFnncgacvvF+MjkxSBUGLYJxK7k3nDOdub6cXpJxjmHZQCs5Ta5d4EXSq4OdhEzjgzdnhBtGNDjuUxgBv9xes4oUa/v30REOUH7ckf83hWa+ihewNgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YwFHMVkJvvS8l9UJzU9hvb80WzO1QSLx7B3tDdkxNCg=; b=Yxdj/4GowEZFeLX48vDjEQzQ5Z+NGOHHNkqy1k4jS6Na/6w+xHeZciG8Bdfbje5A40S1qhorvjuxcSWXQ7gvyt/sGdRUOJPA8I6TfNsOL9p4tXlC+TB7tQQTv7TtRJB59Jpyr+ZNIIKwwJszP6hd770Melkbxq2Kv06qGwVlrOuTiwlXSTsOCUpi0hylJJCMvU2HtpQFJzpcfYZJ7yHmXBzlJHFnG3enEYCJQ+oSbNlRVGIFE2sSoiBdoHsawlC97OWKd7qGAGLJc8nxTa6AuG0yzEocI3BUKK07OS0vCl05dqBcJUhKTmHlqMBgZSoMdroDbUFzYkhp65iJudWPmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YwFHMVkJvvS8l9UJzU9hvb80WzO1QSLx7B3tDdkxNCg=; b=PC/bgUb1vsaBnp+Y3Xd7HnasvlchWFYdAaoBlotLWAnBJuZC29x/v5vK6j25NdIHyVD54W4EeRop0Zd/4F8xzBPLCnGpGQxzF4MCw0+ZjbDZGIIY4lyuE9s2RPlix4NdxGES7SMAoNP2iAwG/lC2KUW9BYqcW7yfjIdvxa0vNyG7JbXw4pOpaywI9B0FkBaQhWDTrynQJIEFPbWtOf+5fw5BkftYfnJ4bD5JcX5wmDc4Z3UB3uF4d9ezL+RUpq1U6Tg8ATyy6dLiK5hrcs4mcc955cpp+tV4pFcjGM0qnDozdDWTdEOZBx/IL/JjBRojgRzeVr3qnlql5Ny1psfYgw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 07:58:21 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation Content-Language: en-US To: Julien Grall Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Henry Wang , Juergen Gross References: <20220527072427.20327-1-jgross@suse.com> <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> From: Jan Beulich In-Reply-To: <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0524.eurprd06.prod.outlook.com (2603:10a6:20b:49d::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f924d74-ea6a-46d6-7e36-08da694bb08a X-MS-TrafficTypeDiagnostic: AM6PR04MB4181:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Sdjekr0C+FSn079VCXtBszee9YTUDjb8zp1nN9rZfKVhY9czcSjUioE4tmaPuf4DpnYcMEjsIJwMjAuskykRQQbEZeuCcn7z1DfUP3f9afyekcMX/QhLkUlPyi6Co12QuFk3nL4kJV7TlZOIYwblJQ/3EScCiGwp1f5s2keQtA6YnGg/6kJZKYMFhZ//IlBPyU+XYOwhWhDe8Xb8RYGWjm/CW+721+1jd8mLbmkLJfpux7yu8KrCBibKlK2SZ2nrR2qd/+/IyT/fqhJAL2kooHQQqyL0VZch6WB3jKmJ5LzpfzR2+kEiQlX6XjhJDFNFASJNmfRgg6TAMibro+DC4+4gRQngE7PtDnUjRH9Zayt5y4skdm+b5/B2q7okjDVb1y3bzpXnyuxJCMIGymhr5EvAERHT5PL3Raeq/kVFMDqWoGZxLsY0wONXPsFsuqUfDyqKjlnJ+9GCJina9eK+Vu4HUdsIHFTtrrEwE+A04lg/c4JT97Vxv/hM9jRMhYSTuE341QVYHgob6kpsUkbnsdSER30NrXHwIDUrgqmKtTonkqKKtQ5SWTCGnc2G2brGk/t7QpmFK9CzYH1ussX4mj5nVOtxfuSBbrAizmXFBqxQczM2d1c79Nx2fjGDVKNFvpoMSIv7rGzqvKht89tTjEi8wPmdNwg2XTN88M/cAjR2X4pIPfKHtkHdIsShGfg9vnuIh0POKGTcMD9HAUtUq3PU+M2VYOFCKrz2pP4m2BZ0rJc1DWYU24wrmdk6WYob3psoH9t2JeDbjW37tcE0AbHb/mX/J2G6uD0TPY7UEgAOf0JkScyynKDujFkpffDsZnjYcNdhcCfe32t7y4XtUzB+CjYhsuX6nza72ywaB3K3Eicn4mkWptq+gt3ZGae65mZcDGQ/ZjEJAGH4zBKoPA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(366004)(396003)(346002)(86362001)(6486002)(966005)(53546011)(478600001)(26005)(41300700001)(316002)(6506007)(38100700002)(31696002)(54906003)(6512007)(4326008)(8676002)(2616005)(186003)(83380400001)(107886003)(5660300002)(8936002)(66946007)(6916009)(2906002)(36756003)(31686004)(66556008)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3hEbTNtbUUreHcyUyt4Q2x5b05MZjRiUFpyblpWdkNuaTRUOTdLVVdjT2lT?= =?utf-8?B?c0hnUVhkVVhNcFB3N0xTYS9BOCtFQVRLK3JveHJXOVpJWjg1V0d2dksrbzBx?= =?utf-8?B?REQzM29yUHU1NTdhTXppR0ZJeWg3N051bTF3THhRVnlwYXlURXBvQk1FYlhC?= =?utf-8?B?emYwZ21rRm1xQVVkK2hmZVQvdVVVWGtET21uOHYxWEZUQWxMRFhaR2hWd0pB?= =?utf-8?B?SU4zZGxWMVFwMXRqaDZDWmF1UVRhVXdadHhxMHhNMTYwdjMrL0pEeGFYMTZG?= =?utf-8?B?TFJtMUQ1SVpnaDhzOFU2UlpjS1VPeWJaTkhyb2wzeGhUM2pkMXVpN2xzbnRI?= =?utf-8?B?SWFsNDl0NFFMUUtjTFoyNjJGd2U1all5RlVuQ0oxK1ZUTm50RkxyaXgvVFdj?= =?utf-8?B?MVFqTGNINDBtemlGY1FjNDdadWN4MnhMRW9uVzRiYk02NEdoN2loKzhHN3Bo?= =?utf-8?B?UU1XUVo0UEhYVDFyTzZMWGdDaHFVcC95R3puakg2Q3RXMUxNeG0yYkREaUN0?= =?utf-8?B?cXFwanVVNDNXc1R2eVBDNVYyakI0S2laNW9LbXZCS0kyTHA5Wm9KZ21yWVJW?= =?utf-8?B?b3I3NHdjRyswUUJGVm83Tm52YWJKMnZEM2orWklHQnpmcmtpRmhnS1NHRzNh?= =?utf-8?B?bUdWSllQZUQ4djJZUEhMOFhjcmplUjR2SGw3YzczWExGZHVuV0dsS1JDdUcx?= =?utf-8?B?N2ZjaDNjRjcrNGtLMzlXQ2YyUlh1QWZvYTNvc1cyWXNkWkxxT3ZzTXAzdGt6?= =?utf-8?B?YnJ5bnptQ3VPZHh1eHM2NlJPQ21SWjZmdDBqTDZUQm9qMTR6Ky9tYUNRM1Z0?= =?utf-8?B?TzJWMUlKNVZmS0w0VEcxajNXSi9NdUU0WTRJbmliQS9lTnhWaXNoNWtrRDZq?= =?utf-8?B?OGY2OG1jaTluWVJJcVk2S2oxWGN2V0wvcXRTS0lLVDM2b3VOWS9HOGRSMzJm?= =?utf-8?B?Q25WRWVpMDNQMVovbFJSMW5ibjdESE1JUTV2Vk5zRUVyNG1NQjJvU1pBdFBr?= =?utf-8?B?c09TWVA2M0lNTm1IOTYyaktZaENNdXZaOUhMY0wxNnk0UmRLdmROaWh1K3hy?= =?utf-8?B?UUNzQkk0UGt5Sy9TYmR5V3puME5Va0RXbWVwbkpTUkh5dGVUT1JGd3FDaVJW?= =?utf-8?B?ZUpvTWJwZzg2TVBEblJjZjZXNlhKMTdJZWpmTkdwMklzYzNYTUo0aXZwcC8w?= =?utf-8?B?V0xkMFkyRURNUUxybXBYQ1BneHZDUS9Tc1lidC9oMXNoZDNFWUhycmx1Y2RJ?= =?utf-8?B?dCtZRkp1SEJxSGZxd0FjMmpuOEJuZ1FUWlRNbS9MWHgwd1RxN1JRT3dDN0hB?= =?utf-8?B?VE1ldUZnNmI0QlFiU2hEMDg0b2dNRlVkUFpTOWw2V0h5UmNXa2xSUitTbnow?= =?utf-8?B?MzY3NTFxVGhHNzVSWHNjNHlhR3EwQUhvbjRNSGpVS0Z5UkFJcWo2eUhRMXBR?= =?utf-8?B?QnpZMkVVaFdad0VVcU9TRUs0K2RHcis0M3ZBbDhIZVRSVUxEK3FadEs0bjho?= =?utf-8?B?aVJ5eUN0RXA3M1BJVEdzbyt5SDU2WWo0QndaVnJrdzUvelphYzJHTUhHZGpv?= =?utf-8?B?M2VIMG1ETXg4cVRGdENzZWJ2T3F5ZmR0b0RsTlNuVS93MkNzQVY0akpUalNm?= =?utf-8?B?Uy9mVTlRbnJQb3RrQUYvdzdBaEl3WEtiQjkyWXJEYjVUWkVLZFJVUzJ2TDlY?= =?utf-8?B?ejVRY1FjWUYraDhDejdrM1loRUJyMENiSVROVE9jN3VlZmpvWW1qcE9NbkUz?= =?utf-8?B?YkRRRm9DeHlmSDVOVFdzZjU4MkJHQjhmY0xDSCsvU2M0OWhGVDJyWTFKYVVB?= =?utf-8?B?TGRoZ3VydENXQjdXT05COHFFa1cvbnluRWpWd2NCaWlZY2ptQnVEL3VVOEpr?= =?utf-8?B?cThNZVNCekNpNlJMbm1UV1JvcHA5K2lGZWwxWkcvelZacmZqVG9HQ2JIdEpi?= =?utf-8?B?bFBHZ0NtS0V5YkdsQVVnaE0vVEZzYzZWVUw2azNZZ1NwcFh1OXhJbDBDT3ZL?= =?utf-8?B?Rjh5Vm9hZGtXSmgxMkVBd1JoQTBWdWQ5OElSWVNWYnkzbWdVZlAzNjU3ZlNh?= =?utf-8?B?anZ4d0s1M0ttVFJBZnNLcFI3T2lNTDdSQUsyWVRDdVhmYWZBekdBQVk4Y3Nx?= =?utf-8?Q?Tx3Z0iLnatY7e/s/1WE7WxriV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f924d74-ea6a-46d6-7e36-08da694bb08a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 05:58:23.3707 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EmAzdLEA1GXjDSPxpRKHyepCdlhmUm2xqjs5cm32tK2pn4NmsxHxRwYMOylkAaFZbds5h2XmEFsqyJ6t6uFzaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4181 On 18.07.2022 18:28, Julien Grall wrote: > On 18/07/2022 17:12, Jan Beulich wrote: >> On 27.05.2022 09:24, Juergen Gross wrote: >>> In the past there have been spotted some shortcomings in the Xenstore >>> interface, which should be repaired. Those are in detail: >>> >>> - Using driver domains for large number of domains needs per domain >>> Xenstore quota [1]. The feedback sent was rather slim (one reply), >>> but it was preferring a new set of wire commands. >>> >>> - XSA-349 [2] has shown that the current definition of watches is not >>> optimal, as it will trigger lots of events when a single one would >>> suffice: for detecting new backend devices the backends in the Linux >>> kernel are registering a watch for e.g. "/local/domain/0/backend" >>> which will fire for ANY sub-node written below this node (on a test >>> machine this added up to 91 watch events for only 3 devices). >>> This can be limited dramatically by extending the XS_WATCH command >>> to take another optional parameter specifying the depth of >>> subdirectories to be considered for sending watch events ("0" would >>> trigger a watch event only if the watched node itself being written). >>> >>> - New features like above being added might make migration of guests >>> between hosts with different Xenstore variants harder, so it should >>> be possible to set the available feature set per domain. For socket >>> connections it should be possible to read the available features. >>> >>> - The special watches @introduceDomain and @releaseDomain are rather >>> cumbersome to use, as they only tell you that SOME domain has been >>> introduced/released. Any consumer of those watches needs to scan >>> all domains on the host in order to find out the domid, causing >>> significant pressure on the dominfo hypercall (imagine a system >>> with 1000 domains running and one domain dying - there will be more >>> than 1000 watch events triggered and 1000 xl daemons will try to >>> find out whether "their" domain has died). Those watches should be >>> enhanced to optionally be specific to a single domain and to let the >>> event carry the related domid. >>> >>> As some of those extensions will need to be considered in the Xenstore >>> migration stream, they should be defined in one go (in fact the 4th one >>> wouldn't need that, but it can easily be connected to the 2nd one). >>> As such extensions need to be flagged in the "features" in the ring >>> page anyway, it is fine to implement them independently. >>> >>> Add the documentation of the new commands/features. >>> >>> [1]: https://lists.xen.org/archives/html/xen-devel/2020-06/msg00291.html >>> [2]: http://xenbits.xen.org/xsa/advisory-349.html >>> >>> Changes in V2: >>> - added new patch 1 >>> - remove feature bits for dom0-only features >>> - get-features without domid returns Xenstore supported features >>> - get/set-quota without domid for global quota access >>> >>> Juergen Gross (4): >>> tools/xenstore: modify feature bit specification in xenstore-ring.txt >>> tools/xenstore: add documentation for new set/get-feature commands >>> tools/xenstore: add documentation for new set/get-quota commands >>> tools/xenstore: add documentation for extended watch command >> >> Hmm, looks like I did commit v1 of this series, not noticing the v2 _and_ >> seeing there had been R-b with no other follow-up (leaving aside the v2) >> in a long time. Please advise if I should revert the commits. I'm sorry >> for the confusion. (I also wonder why the R-b weren't carried over to v2.) > > patch #1 is a new patch. The patch #2, #3, #4 have been reworded and the > overall interaction is different. So I don't think the reviewed-by > should have been carried. > > I had some concerns in v1 which were addressed in v2. I have reviewed v2 > a while ago. From my perspective, patch #1, #3, #4 are ready to go. > Patch #2 needs a respin and we also need to clarify the integration with > migration/live-update. > > As you committed, I would be OK if this is addressed in a follow-up > series. But this *must* be addressed by the time 4.17 is released > because otherwise we will commit ourself to a broken interface. @Henry, > please add this in the blocker list. If you hadn't answered, I would have reverted these right away this morning, in particular to remove the (now wrong) feature bit part (patches 2 and 3 have dropped their feature bit additions in v2). If you nevertheless think an incremental update is going to be okay, I'll leave things alone. But personally I think this mistake of mine would better be corrected immediately. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:01:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:01:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370323.602002 (Exim 4.92) (envelope-from ) id 1oDgIs-0004Yn-MK; Tue, 19 Jul 2022 06:01:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370323.602002; Tue, 19 Jul 2022 06:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgIs-0004Yg-JU; Tue, 19 Jul 2022 06:01:54 +0000 Received: by outflank-mailman (input) for mailman id 370323; Tue, 19 Jul 2022 06:01:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgIr-0004Ya-Vb for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:01:53 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 491515b8-0728-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:01:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4181.eurprd04.prod.outlook.com (2603:10a6:209:4c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:01:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:01:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 491515b8-0728-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VcmWj09X9hHaXFeTU73RgL03Dgu2Ftc/+DudZhd2pxPzeGSwMlbjxgce7+rbZxTDQOo4AnEmIAWdlm2hH/RF23jPqpIqnCPHnkUZT2X31MBxOXNLA+rXBVy2n2tKdwbSeq8X3SNeO4CqiYOSCgMquQmGsKOxXOl9CezrY/6DSeO14lFxSipCWfxMLPYemCzQ269vCeo6Nv9Ku+FnJ4X+HG7G9UOAnTGXWpJ1APVkB4+GZrJMGTLX/D1GQ6ew9d5poA+1WigRE6/ZPp/GDl0AydkJSijIoRaYyJeadlnWM9j6W3CIrp455sAjO6y5uqHDhRbeihSfih8fqAeMZZSPpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JWtTCuPicoezP/G+P6t0Ki2TwDIoxh3zWYKsjWIG8wY=; b=haPytklIX+VfQy2mOwudqT/MmVxZVbFPct/BlIQ8iqAqJX6WmF4rUKVQHvqx4sAZGtLbVPZ8h4uH+YYIm44oT4fbdOHWiUMWt9uPADb/Fl1OUu0lpiK0hqyZ7JZvZrpDf/UBPJQF/caJ7B2p1k/YHjZ38uvE6HO5ZIYH6vBJEY/p6BBZg9UmEk5BH1XfHNwnWZOzfe2+HE93EZjrtWo0jXtmYJxq7a2HRqTTnuK+gFDBsKNz9+3aiLIwCy4CVLaRX48jiFLD/FUxOQtamtYT+Csul1QtPEYb+BRCDHJ4XG7WlMr09Af3ZCqHYucoH13N1CCvnuoOQbV7h5XRtRRRNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JWtTCuPicoezP/G+P6t0Ki2TwDIoxh3zWYKsjWIG8wY=; b=mKwA0ZPuKBk7UDTpPDYTgbt8/9Iowg/aojCChDw80Ar9RLQuI/LcvBUh3++X64k6DR4aDQi2j2ZIjT8b0UcvC/hqRA8VOVQUqq0HrwBOa0Yg+BaOuVwYnAcBxHk9oSR8ic3RLz3j+bQralSsxG9RzKU4rF3KLg9B5/dcGlRkPGUbrYtpyt/X3nI+072IHSnWsnZqVaHH5t6gZ6eNf3okunZDqbVK1eduYThlTdheaMTIMuz5gGWLAKc5Iob87gOwnXAckmF6ANBQY8cMAeH1z6Pzf1NTRdjeXVRtGuDWHfZUsG64g9zfQJ3twy9gHQYibwT1o2i4KZhV0KxNtHO1Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4904ae1b-19ef-533c-fc2f-baec570bfcca@suse.com> Date: Tue, 19 Jul 2022 08:01:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init Content-Language: en-US To: Julien Grall Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> <097e8634-0c5b-35ac-6ad6-5b83d9b29f64@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0141.eurprd04.prod.outlook.com (2603:10a6:20b:48a::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6877c03d-adf6-42b9-293d-08da694c2c53 X-MS-TrafficTypeDiagnostic: AM6PR04MB4181:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4QXZoTpJoSYnvyNCjHrPosxbn2QXtq5e5Fw7MwOi0yVNAyv3ezK6nNsmpzSBo/o1iqtDoa0C9ffry9KPlAA9XAyUfKXQ8mUh+ztNVlTeufC4tH0z/7rbeC/dUylye6SFIyM0fECw7J6SBb2eZLjdm9QCvdwZ8T+A4ULoV0CbAyAL0CGawW8R7srQhW5PexYO3ffO+9uA7GqN9HP6OE4baC4rYXAi8cDG266TtzLxAbstjKK0dBV2rptHhG+jbyBiHcFAcE46xvjg+dZpjQgr1DQEHa5tbUd8ueei/ARj2OyP0MAyeWBbH4W/wQv74V70CDVSFulCEhxByrs/QB367PMqttPTQGOGisutkMw/3WDXmm+YwoMkG4PqWW2Mc9uiFX1oVmINaUi94qOCWqDFi9VwvVeog1YSAr4uEL/zmvJ3M/pdXbUHOKfaz2fCan9lnWUqQ6brWm3CqxKsCVcATuR9XkbM7TzY9FB6h2mBq0QNkH/jSRcj6/Rdy1E5+LH/a0qKiCV6eY8jLQy46l74JADUt8hpi3MQytG2bc1lbq0ubr47S22ZWnyBCbkVZnJiEh1bEW1NdU7zJZmj9dfS1Qk5Tt7WaqKXydZiqxL1/KLVkEc3pa++v//+LQiJ4g6R68Zsa6gbUWongVp0tyb1NzVr4m93uO1tYxQQyKCneSG+j2mL/ph11LOF71mWrGDkxnGs6lEXGcvJ9ikrbtKTwoP+Rsr0pCOnwtBMc9RScXwpBHlJop0tz9j8886fuosUw1b+V2H8oszktMPvAFj6uiZ4qdlpBKxWAME0x3yMyfjR0VheZaQW7UXD9FM169+395P8Lztw3ZUuM3aTcR7lhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(136003)(366004)(376002)(39860400002)(5660300002)(8936002)(2616005)(8676002)(186003)(83380400001)(31686004)(2906002)(36756003)(66476007)(66556008)(66946007)(6916009)(4744005)(6506007)(41300700001)(316002)(31696002)(38100700002)(86362001)(6486002)(53546011)(26005)(478600001)(4326008)(54906003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enhnalQ2Q1NNdHcvMFdEU2I1ZXNhU3Q0cEk0cWxLYU05TEVpZDlMUElOTUg2?= =?utf-8?B?VDdxZHNSTWxWVEYrTWt3bTI5d2crcEdmVGU3NkdtNHZoUjFLbnFhc2pVQ3hP?= =?utf-8?B?YWxZQ0VUQm90WjltTFFyeS9QOVh6SVFYMmdyUXFSZ3NNa095QWR5ZE8zQVFZ?= =?utf-8?B?dVYwWlE4NjdGQXM5WndXTTQ2bGI3WHI1SWIzSi9LdzhVeVRmb2d2ZmdONnU5?= =?utf-8?B?OWR0REJweS9QK1hHWFc3MmI5RGcyUTFaeE0vdWwwMUVZczBKOHRSMXYvWEJn?= =?utf-8?B?b2N6bTE3eFh4N0dJVTNveEhhNmhwd2I5SjJCWU5PNDRDcVBwUHNIdFZGRVJT?= =?utf-8?B?NWkxU1VtWDZ1WWxmOFF2b0NORnN3aFRhRTlYSmtTRFhRdXJCeVI5a3VWby9X?= =?utf-8?B?QU43YVFBZjd6MUh6dVFsRkZPWHRxZVlhUEJNZmVPclYxRDE3dTBIMVlNRFdh?= =?utf-8?B?c2VNVnc5NVpuR3RjdjNzaWZVOG9jaHNzNUJ0M2FUVlVWamtzSkhDNnFEa08v?= =?utf-8?B?ZzVldHlNVUpiRmRoRnJsZkdUUkFjeFo2WU1hNVJSL2Rzb0pzMGZLTmttY1RL?= =?utf-8?B?d3hGeUJNYTVubUR5OVluRHU5bkNKeVI5OW1KWHpIYlRKYVozakJYSUNNaTds?= =?utf-8?B?V2ZEYnN0ZzN1d0dRZlEwZkwyWHZuemhBajFvTlFxWGV0U0h2YVlMeEZWY0lv?= =?utf-8?B?aE4yQkRRUVhON2poWHBMajh5MzBSblJPcFRtMmZSZFIwVklxWmNJWUcxZE8v?= =?utf-8?B?dCtERXpZemt1MEFmQXdPa211QXM4ek9qT2dwa1dQdStWVWhCa2xMUEtMQWEy?= =?utf-8?B?Z2x1TS9wZWJ1ODhEOUdtNUR3dy9PczRXVmpGTnFTbk5KMHRKMlhJM2J3S0ha?= =?utf-8?B?QzdJZGtrK0ZVUGtMTGtxOTRSOVFCcDdRTFFmOWJhb01SaDlRR2RBbDNHb3BW?= =?utf-8?B?bnhEbDdkcSs4dmxUS0s0UThCMjYxOTlwODRKRUFJMHhiSStya2NMSHpNRzRR?= =?utf-8?B?SU9RTmY4OHVHYWlIVytTVG8xbVpkVUViSlBjU0lrZkpHSkFRVFpMREw2WWlC?= =?utf-8?B?QXJFOGsvMTBYNkRKTzVLeWZkbC9CZWJIekFEbmF2TWU5Zlo4Q3FyV2JPd3Fi?= =?utf-8?B?Nmc4QWFBdjJ6dlZyK1RZQ3hlRjFTTG0wRCtyMVFsQ09CQzNjZmJCdGlNVkR1?= =?utf-8?B?bDdoallUNGlNdWRzM202MWxzOGt2R3pFNTVTRm1rOTV6U1F3MHZnOW13S05W?= =?utf-8?B?NDZSOG1PNDdHMkplcXBRekRobEZyS0pnRXRmbno2c3JSck5na21EM0xvYjNm?= =?utf-8?B?K1I2Wjc2Zm5OaWxzWVJPN3BmenNrcEFiMnJTUmZUYkUxNzY4UG95TnlNZm9p?= =?utf-8?B?WGhxZmhiQmUzblcvWHpTdjRHajAveWRzTXZ3M1ZhN3dUeUFUZUwyWVBzd1Ba?= =?utf-8?B?L2tPSmF1OVpEM0U0dWdDcE50WDVoYVpQVERPT2praktLWjBUaXQzdDFCQ0pr?= =?utf-8?B?RU9Ta2x0YllFcW5XWlVrcHpyUnRidnlyM3VjSHdSdVk0cHVxY082dG1vL2d5?= =?utf-8?B?TEx0MklMV2dHcWJqMlZSZ0tHcldpanRrK0h5TGhGaXRCK0lHekY2ZXRpSksy?= =?utf-8?B?dUY1S2hYWFRYMXd1ekFma0JNY3lVeVM3clNDcFZLZ01Pc1d2bUNGTGE4T25q?= =?utf-8?B?QU02R3RnWEs2R2IwOCt1M2F2blZxUi9OdDB4VlN0bmI0UGJPbTBoSWxrb25p?= =?utf-8?B?OHIvQUpGSGgwTTM4KzFkZHJUeFF6aFY2SFdsbmw0SlljcUdXS3ZiZC83TEtx?= =?utf-8?B?RVFqVHYvdTJ6NVB0MmQwWmQ4b3VpV2pQS2R5dkczYllQa1Zmc0RCUVZHUTlh?= =?utf-8?B?dk5iaVFpS0krS0lEL2o3ODlCaFRxLzQ3ZGpuYWFmQy9Md0p4MyszSktIZkVq?= =?utf-8?B?dWpxVnM5SXhzRGFUNHhabms2OTZaQS95RUpFUDE1RDJTZ1lBOU50Y2JZL3R6?= =?utf-8?B?VGhKZWsySWRkTVFJdW94T21IRy80YVJHK0ZHZkl6U0VmT21PWHViL0dWN3da?= =?utf-8?B?NEF2U2pxWTdBZStoQXZGcXRNb1B3RGV1akIrM2dLZzA3S24xVU12MzUwWkNH?= =?utf-8?Q?IIoP9HYIqUpEtUvYWUm/OXxoC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6877c03d-adf6-42b9-293d-08da694c2c53 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:01:50.9831 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KKfYZ7yWNhtjFDOeiHZcryEUrcyhpdL0Cd9vO4fcXv5X4Hw1qafKjpM6B1xYLuzx37z6ewZBe4XAKcw6Kw7/9Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4181 On 18.07.2022 19:39, Julien Grall wrote: > On 18/07/2022 12:02, Jan Beulich wrote: >> On 18.07.2022 12:24, Julien Grall wrote: >> 3) >> unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1); >> >> if ( s ) >> inc_order = min(inc_order, ffsl(s) - 1U); > > I like this idea! > >> >> No compilation issues to expect here, afaict. > > Correct, GCC is happy with this approach. Assuming there are no other > comments, are you happy if I make the change on commit? Sure - iirc I gave my R-b already. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:07:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:07:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370331.602013 (Exim 4.92) (envelope-from ) id 1oDgOc-0005NW-Cs; Tue, 19 Jul 2022 06:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370331.602013; Tue, 19 Jul 2022 06:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgOc-0005NP-8F; Tue, 19 Jul 2022 06:07:50 +0000 Received: by outflank-mailman (input) for mailman id 370331; Tue, 19 Jul 2022 06:07:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgOa-0005NF-R9 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:07:48 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80055.outbound.protection.outlook.com [40.107.8.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c7d9292-0729-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:07:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5315.eurprd04.prod.outlook.com (2603:10a6:208:c3::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:07:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:07:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c7d9292-0729-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GkV2uZaTgPKxF8AHDiZq8QsVvhAgErg8jXuCthJ3h3YMWKPqzgR3YgTuDic56kmfSL/SUlkxPdJLMgKCnfTDfDbMDrsxeTOMZgfd2qe4Md3CNET+YAsQ5f7QieTqD+rvHZYcnrlL2FOlgKsrL0gRBSGZX+5Dw31pg+wrXEg0bhzOEsShsCbY1an8iVyjk9U9i2appZ+1XTNvin5N1hT88QUyFWXlC6oGUtGpD2Lf3rDNIKExZardZNfaF14QzQT04l3UUxQniI9dxsVBbI1NM4C9l7pgS8nWAByYDgtYRis02vlE2mwKCidgMI5lWldJVtiNfTb0CMxZSgwHGZInEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RQiFIUr281ETQgWNQUgPPgBy/1k1F/OjfygX0OKBCsE=; b=jqIcxH9HJm1dC6VzxQa/jgeqh5h6F4PUD0Ehsxzed7JDFPP7g3V43Nid/6gHOgO+iR4bLo6GMkcuX51EU0e4c1kxKfN4/AX8w4iL1JGacyoE9QtnMb8wha1jfNJ8uqjKx/PiulZ4mui2j5XnJ2uGR07cztiSR0WOfxVqtrYXMnT9vKQ+docHK59XtXAQCybvGsqgcweMhDKo/EPJ3JGhRtglmJEMi4jud6yghSDo0mW2Zj8fLM+VfiF5+8xtQzvu3AFAYs4eTzL4AMlVxFTMikCSo1JTdZ2WbAgkGyqggxIvsU88ZxxnwEv8oYt5hvGFGEd3dYgoI0jJDFbXwycK3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQiFIUr281ETQgWNQUgPPgBy/1k1F/OjfygX0OKBCsE=; b=3GxSdJ+tO4FVD0RvUm1jWzfvsmv+bo2ttAMzl6X9UW/3vxO60WS0MuktOEIBMEgFELxHp+jiu4zZtwOdkxvY9o+Ob+58CK62eZt8zLo8YUzVTNhs/ZUFm2pJDNlWA4wQVHYJ7WJjj79YP34qRGKl1/qWtyZdtGTm/pAXH1ewmFzSVvmydnsLLxUOLbfXhJulRHQUt5G5nwrsmrgGVPPmEShyrNJo5RA38Z781YZIPqlWItmBRCKaFQlV4soe/vfjwSKuG+9+QODf8ZGRqTfzzigkn4ZwA6r+x6YzomOXaJ3zsXyupxpwjpfplAAI160pMde+jgpXrs1vyvPdF74A4Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 08:07:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Content-Language: en-US To: Volodymyr Babchuk Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> <20220718211521.664729-5-volodymyr_babchuk@epam.com> From: Jan Beulich In-Reply-To: <20220718211521.664729-5-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0701CA0005.eurprd07.prod.outlook.com (2603:10a6:203:51::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 43db62fa-1bac-4730-1109-08da694cffc7 X-MS-TrafficTypeDiagnostic: AM0PR04MB5315:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5M/cQYaqPs8qewFon2advmA02AiFNPpCL0y1ANFcHCBZULamDYVHOI3t/TbTKW3AHNrBr7gDfaO7KoRZ6zxt866XIf1vU9hr9IfsLpNXDs27tDTkNqtehkRhm+eTEu5JcarE/aUDUMPfCc0APJWzT3X6nRxw0ZlqYtNvC9OeIz2JuGVyor7B0T4GCiuUulm9tJNmExfAP5VtWTM6oZhvp9BrqkZa4m2yDL0l4NrWa3g96UuBCU68Mu1h1uLBby+dusv8P8u/+TzWARhrZmLxHlXNY6Zt4xXEGkkxkGDwrtJ/JS1i0PtXRLkMiHzlfMHs598x1aJcAm97NBPaIJ45OmKhd2LPLYVludaWB8m3YjDscDaHV18SoRCcWR6OnJzSjzpxUizwKj1No4vuB731KxWatdhmJn2vzohWjMZJSPI/yxWaxRw5SEwyM9KIYGDwJ0L2DpUaAiOPk3bJx6iraDCxr9lVVU6KfIYAtpAGVVjintcL15+1dLoDKRKcP6oZA5+vvrcROUdExn8nhG0E0MwxMcMGzRpZeJT/Jp/kqX/+bczKVmqBoTz8fHAAC5EYD/EbwukMbG08ciSnUY5VSGerIvqSZffQ2ZrdMxg6T62Qhw5Thsymhpe3uaLTwt9mZA2lPsC6xsA1Vd0IpcnPOVb07FR2PccijD4xTTRrlyh1rXR9AjtaoP6CZ09l2/Wf0BV02+pWWnGFSzTlxb3E92xaE9hNfNAkQrDFUgCqZUXtH4UL+1OxUHU5f4KqZwCgECPoFu7t+bYYzGXzuaSgRXvWIxEAErFe/QI0CO2YFrAbPcptvBMHu3KgZt/dD9UJpGB0kf0MUxxCtgIdLteRoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(376002)(39860400002)(346002)(6916009)(38100700002)(316002)(66556008)(66946007)(36756003)(54906003)(4326008)(31686004)(66476007)(8676002)(4744005)(2906002)(41300700001)(26005)(6666004)(83380400001)(186003)(6512007)(478600001)(2616005)(5660300002)(6486002)(31696002)(8936002)(86362001)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YU5mQ0ZnZktGdkZvN2xmSy9LM2NjK3VpQ0NxWUVVZVJLT0pzeTMrVVl6ZEl4?= =?utf-8?B?MkpaYjM3YVExVDRLd0ZqSWZUT0h6N1E2cU9HUjBzQWxVNnpSUGg2UWcyOSt4?= =?utf-8?B?akpJcWlJYW92dmxXc0w3ZVQzQ2E0VU56MUxMeXBiNTFVUVZ2REpqT3NvR2dh?= =?utf-8?B?dHBNWWttWnRBblpQQ2dtQ1hvbmFaei9Xd1dCbEZ2cUhQanhjU2VUWEdlT3RI?= =?utf-8?B?YkpaSUN6WEIzWlh0V1o1blVrMDFHUUY0L0I3UUxOaFhOY0RFeFQyeEVVdU95?= =?utf-8?B?dVdKd3JhNkdTSnlXYVVSWWF6ZHUvOGtLV3hIYXZ4ZzRQTUNEaXp6bk1KNERT?= =?utf-8?B?Z0ZndlJjdDd3ay9TMXlmalA0ekdCY3BuTTFObDRRNVJRS2RscWNKdVdhaC9X?= =?utf-8?B?dEV1NHBUUGdmVnN1dWtkOEZ6bmRveUYreE9CNTJVaGdzZUJiVUFKOTY4Y2tk?= =?utf-8?B?YUk4V250MXNRM0VNbnZhcDRFcmxvZGlsRFo4NnA0Ym1yWkZFV2x6b21nN3FB?= =?utf-8?B?MmNjY0VUMlNZbm14MnF6cEkyVGo1cVgvSE9nVnBnME9hNjNTWndUVlFXRjFY?= =?utf-8?B?NVgwR2w0QlE1QkszM2FkYi9GbW5KeE80THN2eSs3ZTFpNi9EUFR1WVY3NWVt?= =?utf-8?B?aVAzejBJMXJRTUlXcjd4Z0wrMDZRd3k1d2JrR0tIU2NLZEVlZ0p2QkZ4Rmpo?= =?utf-8?B?QmJTYmcxRHRLdjhwdE5HN3cyWkZ1a0NnaU9XVCtVU2J5QnVRUUFPZXJxR25q?= =?utf-8?B?aldBQ3A3aTM4S2xDNEh3bHJlWmxlR2szSnNpZlpDeTBVSEhlWUlUQUF5c1N6?= =?utf-8?B?eEplV1RxTm5BTVRkYU1CWGQxTjFwSmZQOGhTelNwYlFoT0paaVhndDdVblkz?= =?utf-8?B?bDhpU2gyTlMzc3RocEFvaW0zKzFJQ0FSTjN3OVB5SmV2UlVtZ0QyYkZDU1hE?= =?utf-8?B?TGVSNmMraFRPNTV4WTc0WkRSMm5ScjRDK0x4SnJ5U0d6TmhvRnpPV1dWWGFj?= =?utf-8?B?NVRxSmxRNDI0UFdIckdBNTZ6V3NYTFNOYzZhaUNCeEpCamJTeWw4Y2JGY21H?= =?utf-8?B?N0Q5VGNXTnBsUFdDYjhuNldwVnhFUEtMSDN0YlE3a004TGlVSWVmbzdEcEdz?= =?utf-8?B?U0src0w2QnVjVlZBMTRFNllpbVlWUm5rQ05udHkxN0kxMGVXbUtaQ3J0bktO?= =?utf-8?B?TmE4ZHhIODJYZFR1WFB2a04rdkZYSTZERmQ2KzlNRlpiZ3MxSlZRQllXMCtB?= =?utf-8?B?RXRXSmxnMHd6d3JkSloxN2NGbzYrOXRVTjhIQ09lMDBQMGNGSWZjQ1dGQ1p4?= =?utf-8?B?L001bHdSTW9aTWs0Wm8xWUFXRGl3OUJCelZIdGxsMy95UGdlTmZ0Qzk1ZG12?= =?utf-8?B?RnBGN0pTWHVqN2tzSlNrTWh4Q0hhUWhnTllHYkpna2RzV2dmS2JWZEtIWnF2?= =?utf-8?B?aDNjN0FkaVpmSHNiaEViR0JKZ1pkcE1HenVQVFhDUEU2cW91VlVyaGJkUkJW?= =?utf-8?B?SXErVVJzeHhUck1hRm80TzZsais3VXVIUVE3M0pNQ3RTenBCeU9kYkd4c2VW?= =?utf-8?B?dWhyMHZTMWpER05NQjFLUW41UGxMLzhlUGJ3UGhsdUt2RFdaMUhtZisyRnRs?= =?utf-8?B?OU1kZGlqK3p6T0pPeGJkMWtVb3M0aENLRmtBdEJ6NExoMXFtVklSYXZEUWI2?= =?utf-8?B?NkFKU1g5T1QzT0VVbVBDU2NLd1Riakwrc0FzNm1OL1Q5dEpmZjJTd1N2bkVX?= =?utf-8?B?Smp1TkFvdDRTd2VwVFoxZGhtMHh0YzkzWGhySFRkdDdCNC9xanZmR291UXF3?= =?utf-8?B?TGgxYW11MHRjdE9uWDlHMzZaYWtEYVdBazZzdWlITjU4ajZWK3pmUnlVTG5z?= =?utf-8?B?YlFYQm9VVksvOWQ3RmJWVVpFQUp2S0N5S2tSUjRUOTVJY21PUEMvcVF0WGJE?= =?utf-8?B?anpBMVpjNjhLcnFzNDh0V2F1OVB2ZkQ1RGE1blpETWFNU2ROcFl1dUxDY2RQ?= =?utf-8?B?cXBRQm5VZ0tiWEtMTURkZElrVlgxSU5xWnVDWTk5aWkvbHJOLzEyWWtzMTVt?= =?utf-8?B?cWtKdEJGeGdDWGQvOE5qRW9zbENyS1JCeUhrNHU0MnZhNmpaaWFRSFQvSjUz?= =?utf-8?Q?IOm6MOywLXxGmdUfOUOP27u8t?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 43db62fa-1bac-4730-1109-08da694cffc7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:07:45.9763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: H+OzuZj6dB1XsF52wfgBo0Y727VlEamNSil9D+SscRkr6nQB88uSk+YAwTqP0mkjvcqwXLOaek/QqA64Ipw4RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5315 On 18.07.2022 23:15, Volodymyr Babchuk wrote: > Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to > iounmap(), but not added corresponding include. > > Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") I don't think there's any active issue with the "missing" include: That's only a problem once Arm has vPCI code enabled? In which case I don't think a Fixes: tag is warranted. > Signed-off-by: Volodymyr Babchuk With Roger away and on the basis that I'm sure we won't mind the change: Acked-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370337.602024 (Exim 4.92) (envelope-from ) id 1oDgUW-0006oE-0r; Tue, 19 Jul 2022 06:13:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370337.602024; Tue, 19 Jul 2022 06:13:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgUV-0006o7-Tv; Tue, 19 Jul 2022 06:13:55 +0000 Received: by outflank-mailman (input) for mailman id 370337; Tue, 19 Jul 2022 06:13:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgUU-0006nz-IP for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:13:54 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f6b894fd-0729-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:13:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7309.eurprd04.prod.outlook.com (2603:10a6:800:1a8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:13:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:13:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f6b894fd-0729-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1vVbkKutkTAT4BqSVnQOJf5HRyq9fOwF4bfcwHQrmVs35KSpFILkj7RU2Xy1d/NgOX37aGxHEFY1umZ4ImBlEDJ9mFzlVw6VJ8wEze3BAOFoMY5+Rl3g9vT9y79URk/lbRRpwlRMLuTcSHQrqQPuxjGz7oZqxsZ+tsQa8JT/WuqdLZ98oUDf+VdQXGOHkLre3+bhXogqu/7IjXfN7/0MKEdOZGMm9ClLypN3rpxCWct4m5HJgKeH/lVWBkC3FdvXPSMOyMoRXx98nVB6NB3R6yDxlaXSXJlFFjem2PqeX3xzIBDo7CQjopBNSlsb/FbK6Jq/I2OiH2YHbAia4+W5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WQx6jvbw0ce4D9tfYC8sMRrpdB607dpI7gyLn6aUrM8=; b=Z+KDKvc3q8LGdgNY1CgMKM/ovXIBw+czySTGZmGWgYXtafk2noBSsRYN/4YC1JAUsppM75Qk5Q8V/6GyJTs2cgXNY7Iow95EbvjLfOrPiY8E0YjaIdvWjwMxIseNChxl8KIUCBOhPDf7J5mw6XSQpHhT+2gXcU4tMhjXYCevXCot/gnPgH2RnPCRllZPXUmxvLi6YmlU15KJXSokRcRRCN5ubjNJZzDtcKWE+AZrXmUIU5bFqElomzqr2ZaOuDmyVtCX2y1Xbqv6MyxupmwWA4ZPph/cbm9Q0XMapxpm/DurSXAXquz+euNouZgBv7EdQlmyyuapdXxKHDyfQOvbeg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WQx6jvbw0ce4D9tfYC8sMRrpdB607dpI7gyLn6aUrM8=; b=bZNGZbiQbXjsi/Zo9rekEqYf+USiQ+gj09AKFKsH8dbE/ZHv3tOF5pZBab+NaqdG0+cBWobLWP3WHb0HV1UFyRXQ22VJ7bWAeqEeFvmEHgZcGUHkVmRKhoSzAso2NzTPfxr9wlMPvhdPnSJ4v+RjbTynGIUdo+ZrLH2/lic4w7oKjFxKey5p/ETmHZ7KLhSs1kNt7XL3wJvkqefgfDL/mYRZFyLRpLNOByU7ZL5AgRg/wF2fLnhucJ4QnFO2zr6QM2YTaRTz7LDcr77+3G0xdseXxvRSbcEUavd5GysjcjMKccOjUiv8E5umzje2Gp5LqY2NbbEZ/sSP3AQ6gOKwVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 08:13:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/3] x86/spec-ctrl: Consistently halt speculation using int3 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718205009.3557-1-andrew.cooper3@citrix.com> <20220718205009.3557-2-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718205009.3557-2-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24b3bce5-cae7-40a1-effc-08da694dd582 X-MS-TrafficTypeDiagnostic: VE1PR04MB7309:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6O5UAQiG1J37r348Er9zi6Ai2jv+TwSPPJoLStBi+cHCcNzItDOid3AfjtZZCeq+NICgP09lJmLfGPeTtAmzfjI44eeRcvDAQPR7QEwBwjJ0d3fzocg0KGATpi0XkF/63cAk2HuQGtMEChJV2LHF2W9V3RCpMUVXKHxiNLVpVLyxfhXbudEu4qJRUf3aRPRb/PUrqXEWyiNd9Z7ooVWjqhRSYzNcVGJ7m/3/QA8yU2uL2iMoUOxnE3mb2dHP/nkiN91ghMaXtfIbfnFwsjNr1p8jPBJDOtMOzZ8sHyjwFpsznQBx/9ARCefIeoAvnVBcpCtZN0z/ZzNp2HQfhLVbRFMbV2m6hx4wzqM3+l1jXRU2xRT1s4ibPt4XV65O2NNsU+g9Gq0uuup4Z3RirL4+hPC3OpdrhtminqqTIx/0ARBc6YK1I+VuHCFMYsql9Rf7iHFK8U6atcQ6g2aDltDb4v45mQpiKrHiMhHKyZ1W8h2XVhA9zry4x5Ay2YvtzCO8xcu+JL8kW1zxtfz/W9ock0aOEXKBzwMZawySVSaKPGswiPRTaaNbxWBQgFP/aCGHF+TkwC7WrrKMTT0G0DwZrogYtP1L1vwwBr/HoOkdiUY+WGXR3Vt8Oxr8ZY5RJFwwjV/dXT6Seo7VZKZ9HciES7X654DGpIE6OCwQR/J6cMgCr17P9E2dqD/48mVliOGtD3tPCLvdax3/bdrCaQ4J/7VCFBweWW86S5zf3CwtvPol1c7HrztP94Sa6/u+/3k/j1/rAqPllHKqXcIDpkgCWj/1arIskA9uDC9kKolRFt5LSZlrT3uZsKfWj3cVCXMHeh0vf97PTArcAsEoSF+hFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(366004)(396003)(346002)(36756003)(8936002)(66946007)(4744005)(5660300002)(66476007)(66556008)(8676002)(4326008)(54906003)(2906002)(31696002)(6916009)(26005)(86362001)(31686004)(6486002)(478600001)(6506007)(41300700001)(316002)(38100700002)(83380400001)(53546011)(2616005)(186003)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cU55bXZnclU4b1QrRE5ucGRzbzR2MjNCN2NEYWlBTEpCOHVQRytMWnFId1RU?= =?utf-8?B?T3hveDNibVBDR3lUdmtSMTMwbTkyaUFhNWZkUHo4bEdHbHo2cFIrRDQrc0dS?= =?utf-8?B?cjBoVGE3RUU3Z1NhUUE2S1JJMTl6eG1pZHBBdi92aHNKVHM3bk9VakxORkRy?= =?utf-8?B?NlNkVEFTVU1EcURNWGlxeldTdGhyUzBmTkoxWXhwTlVkdUUxRkxRczYyUk54?= =?utf-8?B?ZkVDTnJYVDkyMnBoK0NWekNCdEQvQzNVdDloRFFHdUxIYjFSbzc0WTlMUzNL?= =?utf-8?B?bk5TbUpvTG5UdGZ5NVFsOWlGVnFtMEt6UkpRRGt0NUM5dy9LT2lxV0NyT3dB?= =?utf-8?B?bVc5R3h1Mms0N0ZHNmwxbXk0eWJFR2RqUGp3azJrN0ZHU1dtbjJZRUpveC90?= =?utf-8?B?bDBUZlJpL001SXU5TlBXWVpCTTYrOHR0ZTdjSHdCbHVqTGN1U0ZrZmhOSjF4?= =?utf-8?B?WFZMek5DTjlZQ0VFQWF5RElUTVFTVTl6eUNFRkhhejUrZ21mUkNBdFVRNkhs?= =?utf-8?B?ais3RDJ4SC9wOHRwUVdCVHFna2NnbXNtRlFpZjlQcnZHYU9LYjdhdHB1S2pj?= =?utf-8?B?REtpV3VMMHZVV1JXMzZuUDFJNDg1ZjJMZ1hNVWZqUVYyQjNTRzRVUEQwSnRV?= =?utf-8?B?MjR6RXZtamdVSnJSUU9YcFMvMUZmWVk3eGFONEhDYXJXSHUxRE1rUVlUNjAx?= =?utf-8?B?ZEIyZXRSdUwrN3d5S0JKSDZ2dkFkOTBrbG54VStETHU3OCtzdDBkWVcyMDRm?= =?utf-8?B?cXVoSUY4M1JZVmNMWVptTzdNaVRQVktXd3JJME1RTnpXTzVXUkUvUm13MnBr?= =?utf-8?B?VkNmY3RtNzlkcDZNSzZPWG9HUDNUanM0OXNTcWIwbkUraGNxU1VkTWlvMmFv?= =?utf-8?B?cjcyRGxuS2ladGduM3NJM2VrLzZKZ3JYS0hGMldCSE9KU0JiMEp4WXN6dTFm?= =?utf-8?B?dzVKeGY4UHVzUFFMRW81S1Z4STRPQ2h0VHNtZHl2ZjllV1pQazVVdWZMOVBP?= =?utf-8?B?NzNhOWJLWExUMEN6ZDlONThHbHlMdXk3Y3FZaXE3cUswRSt4d1hUTDZ3UVps?= =?utf-8?B?b2puUk5yeHJmQklJMmlTSGdjSUtaYmM1djVUVnFWZUV1cVB1STJHei9sMjdp?= =?utf-8?B?L2p2UXpEK2g5TUNLU2llWHZ2eVBkbWNVeGtYczVpdHlxaUVsSzM1WlpObUV4?= =?utf-8?B?TklvY1RDbXZOM2c1aE5ZcWt5M0ppeVNnRnU5eTh0T1djOWFPYkNiQ0lEVklr?= =?utf-8?B?Y3dVVGtSNENiVlJnSnlMVW55VzhLNHNYSGZpRmlWcWMvdStORjFYWkY4VFhj?= =?utf-8?B?a1NTV25FSUFCOEdPUDVnaTZVa0VzVktZT2Jxa0JGTHRXV1hwU1JZR3BUNk11?= =?utf-8?B?OVJxeDdiRkF3Z3hFQVg2aVNSRkVjZzBPQ3dBcnhaNjdtMVZSVkhLVk9saFRS?= =?utf-8?B?NWlYNW5tZXFNNldIMFBuNlM1aVM1UmpNc3V2WmQvM2RicUxyOVBtOFZJMjcv?= =?utf-8?B?ZHFHc0p2cW5oMmM1TnFJY3M1VHRuU0hFMy9JaFEzSCtuUVRza2V6anIzZGRh?= =?utf-8?B?MENDN3Q1Vmc3dXlFODYyZ3pvdzRHQWxZUnkzMGRaTXB3ckRQQWt2enRpQnBo?= =?utf-8?B?dnYwbXRiVHowbzV4ellxa3FYSlZVcFI2WGpLME93dnd0aHl2Zm5nNk5wYTFF?= =?utf-8?B?eWVXYlRVYWVFQm53cm9Qaktxc09IRkhFUEU3OVlsa1lhU1NRM1BqeWpBK1lW?= =?utf-8?B?eEI2V0krdEgzVWM3M3JWNW01Y3h5YktVSGR4WER3K2lGTlhMblVJZ3VyYmVG?= =?utf-8?B?ZnVid2tPMlZJVGlJK0R1bXlRUDJhSG03K3ZMQXhSNHZwblY3dCtnZkc0VDZO?= =?utf-8?B?dlZ4VWcwSi9uYWtqZEdnemg0OTN0MUlwRm5yenBBTHFoSDlkZ3Z5QVVGVGpL?= =?utf-8?B?eTVJYlZjcEVDWCtidzNCVmZ1WGFQT2pqS0wyVUxPNVNYVDhhVXJFUHVOQkMz?= =?utf-8?B?MFdLb2lpM0UzeUZGVTJKT01xdXMyQU5Za3VDcTFYRXd0MGpuems3SFZXTUU2?= =?utf-8?B?T09FUDg1eHdaK2V4NjI1VjZpVWdUc3MxdFZ1eGNzMG1WRlIvdjdlNWEyZ3BG?= =?utf-8?Q?C/x9ZulyxWYzmQj5ELXyLWCoL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24b3bce5-cae7-40a1-effc-08da694dd582 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:13:44.3279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 97+8f5TinpM+z57u/mexmwm1wPMtE5YG8yA++vH9Munfv/+kXeCYN8qcp82V6I712kcGXEOhSw07TeoCBZ7QAg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7309 On 18.07.2022 22:50, Andrew Cooper wrote: > The RSB stuffing loop and retpoline thunks date from the very beginning, when > halting speculation was a brand new field. > > These days, we've largely settled on int3 for halting speculation in > non-architectural paths. It's a single byte, and is fully serialising - a > requirement for delivering #BP if it were to execute. > > Update the thunks. Mostly for consistency across the codebase, but it does > shrink every entrypath in Xen by 6 bytes which is a marginal win. > > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:16:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:16:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370343.602034 (Exim 4.92) (envelope-from ) id 1oDgX9-0007eg-Gg; Tue, 19 Jul 2022 06:16:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370343.602034; Tue, 19 Jul 2022 06:16:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgX9-0007eZ-Di; Tue, 19 Jul 2022 06:16:39 +0000 Received: by outflank-mailman (input) for mailman id 370343; Tue, 19 Jul 2022 06:16:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgX8-0007eT-6j for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:16:38 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2069.outbound.protection.outlook.com [40.107.20.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 583efe9b-072a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:16:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VE1PR04MB7309.eurprd04.prod.outlook.com (2603:10a6:800:1a8::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:16:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:16:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 583efe9b-072a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UAAY2C22UnBpn5RBHkNlUVtV0FNVzo8FYNnwEY356g9W+CmuIKS3mIQhBgP0BXSLbvm4PeP37asQs8KyzYbKMY2q9p9ESsZc0xqsv8+4xrfOs0ycV0gYhrOwxi65k/kLALhy+OI0f9/pAs99yGWZWUtaInZeuFzhH7N6QBn7KraLXVCUaDNugrR0cnpTTMk9lTvhdJE+w+EacZ5rBqnutoMvvamtLff5OW25L1lDBxWGs3SVFWjPpJ4yz/daNbn8zpTnAUtZzW3bHxbYsOclJ/zDkw25IO4z2dNzYb2ROXgwF2nJBFZWOzgAedDW4vtX9HopWYe7ISQpWTqI+GslAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yf2WrGHy1y670El0ayoy76jyaTuTUcESRHL6PrSYcdk=; b=aP85kyjIZPAkHSOqlyqh53IQjKX0H1Mqx2a7SbaqUatoiO5f6o5rjeQU2pTp6tZA4Zst1Yo2ssh53VLmAe7HIsMvMNJQZSyIHRE6gbAyH9ZUaEOieFBU1rz0XlPw1+m+O/AqbBWweBmvnBy4OElv4H4m/qYgWcrhWIPpKiA3OAjcpMYh8xZ2V238xQ8cKBBNxukX7RGj3X4WAnxS85v81/s+Ijt+HAayY8o/N6hlPj6WOGA2piDM2ywrA+CVWqDAYgtjsmMi3BV4RpmLqzvh6VuSgwyOO267ayGAVRKQbQSB+F6J+SSiYq3tWsNwdI5ZstA4ruolDp3CS6QFglVw6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yf2WrGHy1y670El0ayoy76jyaTuTUcESRHL6PrSYcdk=; b=ufN3MbHDo6W20TzbQGKBXcNHDD2pp3aMvVgwKzZBj9Oxu2Hi9udLRQTJgq3+WYIjrgvI4YvHd6+vps4Fu2a2o7BWRI39xZNYaHgWasPtrWR3p/yVi1DeeiDYxqo0yZ/tbp2txVvVT6UVxwmj0qS+9XOKeC+kySVkhdcaZik3iho++X/baw81Y2H/BDA9E4WHTaXiEyEU+HxLg6P/lMHgpSG02BMZh9lo6TBFwImJA980vaO1bVhbXzJRe+jj1KDImjAtzAoEW+p5njPxO5YM49dL1OmtJtigs0vfq68/FO1TpFeICqRlnQtkiE6rF9Pu1wzzVEdo8yNfoGXKt01NRw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8ebd876d-5cdf-8ac8-86ac-e5333cbfa365@suse.com> Date: Tue, 19 Jul 2022 08:16:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/3] x86/spec-ctrl: Make svm_vmexit_spec_ctrl conditional Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718205009.3557-1-andrew.cooper3@citrix.com> <20220718205009.3557-3-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718205009.3557-3-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0138.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: deed3961-689a-42aa-fadf-08da694e3b87 X-MS-TrafficTypeDiagnostic: VE1PR04MB7309:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1E2LUOFzrnU4L0Rb6Q1Pw2dsLgZp/0eby6QuberMKsH14eo4nGvxH0dikjSIGTME0ZA0Uuq+wcOGci5Ec5sQWFUabzpoUL3oJ5GZK+459FfSqzlYPGg3VVQw8Q2ewt2OW8qiCK0IKCeAtqETcJmPe8fUv72FWwMGNuyjluaeoa0yO8GH1ZQAiyQa/jCldJ8L8eAR35S+Ey0/eBPFtvS2+e0dZyvuyJ4TtxU4ucgOH2PthIr3U/+/MAXb0+84Lend5htMoU/iUfud77NlaPQzf8PIl8hkSvOBFh6aK53Upq4QpVyslVlF5l4IWfUHDShwMYCTDrhZUJ67R+C+nV4Ydc4bC9M1ROak2PgnnUbgzY9gsUYa+qdfSsumsctsR5WTSxxcCGlH1k5IK+upU0sJUGbm32BSQ6JjPjm8l14u8AQ+nzD68KmtwcRvJBIuYMYsQ9A4nTkwrMH+qrnD5RYe93o4c2h+9YB8udLlDwxxqzMysjoYlRbSMyUpflJGfGU3otgO4ggz/EAoAN5jiec7VVpkBb2b8JUovuXsGNI/7V08oq53fGynVz3bM9V1yEfJvNyB2aX8aI0CuHNnT3rkfh1WulYkQsrfZE5Cg9jMaTGt+Ckz0vWpkGBS2HLJnUS/socB2ciwWOg5hr0ijIa3cKpinUZMS6A/ZRrkA/tWkPL2t8+HyvX80YSTF6rgDtTd3uez5nqVUFAKx+MRTr8lLuxkJ3+xreHkF+0Ykj/4KPbDfSIrUMabI6zt2VDZ5ef7iiUXTWDnEHzpE1Y4nx9/Xh/mz5sCKz5clBruCiF4Ku6Yu74WREGrcBavy52RWfEgk5xv6MulzhNu3EHNNE3YSg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(346002)(396003)(366004)(136003)(39860400002)(478600001)(6486002)(41300700001)(316002)(6506007)(26005)(6916009)(31696002)(86362001)(31686004)(2616005)(186003)(6512007)(38100700002)(53546011)(8676002)(66556008)(5660300002)(36756003)(8936002)(4744005)(66946007)(66476007)(54906003)(2906002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TW15eGlSN2hkN0g4bmsyUXd1Qzc3N3AyNC85ZmtOcGF3TEJwNEZjeGFOMUtE?= =?utf-8?B?OWRlUkVnd25YbTE2eXFWL2pXN0lwUVRjVXZaNTN2NU5uQnJUQmtCY0pZSU9r?= =?utf-8?B?UTJpRG9VUDJobjc5My82RDlXN3VJOHQ4QkxyOEx5eExKTWF0MkZZQjlrVjJh?= =?utf-8?B?MUM4Q0w0cVpDYWJkVDBhYktWSXovRlNxWUNBSEJSWmVUK3U5bHN5UE9mbmoz?= =?utf-8?B?bENEY3hOdG1pUGJpdVBqMldGb1p6US96NUNNVmdsQ1lEbG14MDJ1aWwvL1dz?= =?utf-8?B?MXQ3ZUFjTnhhSEV6dGFINDcxTmFFR21LWFUyU3kvVE9oTmIxbWhaZ2o1eDdr?= =?utf-8?B?VTV2YnllbUkyVUpLQ2VzakdXZWcxMTh6cUNabjV3ZXJ6aHAxNEpkMnkyYlJj?= =?utf-8?B?WHJydWkvQXNxYkFTYVkxQW5SQnBLZzhPWVRPMzM4RDZZRVJtQ2xySko0L01h?= =?utf-8?B?TGlWT3JMaXFNczZsMXJXNUJnSkRadlluNFRIWnNHcFNBamV2QU01Zlp3SVhh?= =?utf-8?B?V05QRy9SRHZlUGhQR3VPVW43MElyM2U3ZmNLMk82VEFkUWZ6QTI3V1gxQWRi?= =?utf-8?B?Z0IvLzRIRjRiQmFIalN4ZW56SFBwYlFCUVhEOTY5dG1ObEJpNi95ZUdzdzU4?= =?utf-8?B?NGlicEJ2K1ZhUW5UY2szMUFvWmFXTzNtNTZoeEtKN2VJTU5ZMkhDYjRJVHpZ?= =?utf-8?B?bW8wZVZuNUcrcS90a2szcktvek9YSHpSUVdHcXhoNFpnTThRcGIra2t4QWxp?= =?utf-8?B?UmZJVVRRQ2o4a0IxNzBUbXRiWGI3NXpDdk1xUW5YdCtKQXpTTkhZUEg5Z3VY?= =?utf-8?B?SmNqbjkzemdzSmRmaXd6NXI2bWRvd1gxWjQ0WTk1bXRvQ1IwQXk4MjRJTkdp?= =?utf-8?B?dEE4ZnNmVmR0c0lGSnZuMmIxeUlMblNXTUNsZ3BJaGtpdk82SnJyVlY2RTdu?= =?utf-8?B?U0k0b2NEaW1ITC9LNFRnb1BKOTdvZVR0MUdWVVFFSU9oQk1hRFJvRVBZKzUx?= =?utf-8?B?SVdib1pNdnBZa20wN3gzQTRybGNjZnVjcjhETkcyczBCQUs2SEVYcHpLclBG?= =?utf-8?B?Nmk1UkxsZUFyMGpyYmRHUEU5MWdSb0RKQkZVeHNyQTBybkFCNDdzWmlTUHhS?= =?utf-8?B?VnlCODdjb0V4Umw0Qk9VdGYyVTVMVFJVRjdYMHlVeXRCb3hna0xlcWxQNld2?= =?utf-8?B?RDFSS3VkUm01Ty9QWGZBMUFGM3JDbS9XcHMrVkZ2TFdEZWJJOEt0WjNCL0tn?= =?utf-8?B?N01uTG83QXhVUE9GeXJCQ25PM3dpSjVma3Z6NDF1dWVuUDI2Zk5wVTZhZDkr?= =?utf-8?B?U1E1bTZsRk9hZjlOSUZuMytlWnBMYXYrbk1aaWVpcVRxbVAvMWtPRFptTlNT?= =?utf-8?B?VHJ3d3VrMkc1dWd4Q1c1cUV3WXlDWVBDbFFsVG4zcnc1QWE2bnNVWFNrNnQ1?= =?utf-8?B?UUtrUkxza3NVOGxoK2FTOVA5RHFuVW5NRFR4MlBXeEhPNmNEbTEyZ2Y2Q3V5?= =?utf-8?B?WE14a085VUs5aFlPaWxISFR5REZZNnFZdERzdHpqZU5PZUtuVzd5T2F4RzBk?= =?utf-8?B?RisyK0hTU3lSbUI4ZFNwWXY5Z1BFZlFRSmhqZHV6c2wzYXZ2b3ZkbW9kSExO?= =?utf-8?B?S0M3UGRERVhjWmlHMi9sM0FzT0xyRlJkQ3dNZVlnMWJvMHBxcXN2ZU5hVWhk?= =?utf-8?B?MjZsdk5DMktvdDlWQllPNFFtZXpXYllicnV5V3V0NU11bGVqUHhrRmI4cWgw?= =?utf-8?B?MjFKajZocTZsMTg3am1hT2pGZGsycUkzNmUzWjg0QTJNTzR0WmZhM3RUV05I?= =?utf-8?B?U3VaUVQ0dmZvQ0ZtRlM2b0JKV2VSZTdMMk9CSjI5UEVLSEMvTFQwNld3U1Ji?= =?utf-8?B?TG1vbG9aVy9LSG5jZ1p5K2hzd3JiNUs4QjhaTWQveldEVmdtdURlbmRndUFn?= =?utf-8?B?RFRUb2V2c3ltc2hKaHI4MmRkVHpwdmYvTUhCNXFtZlJ6YXN6ZUtuVndYdTBM?= =?utf-8?B?NWF2NytTZUJVa3U5T2h6MTRWTHlZY0dwK1NQenM2Qy9uWmRadGtjZlRjdkFO?= =?utf-8?B?MHJDSGNIR1NsYnlPd0hZS0xGejNUR2ErcGVlbEFDYXU1OGdQZlRLNXV0aURl?= =?utf-8?Q?uYZTkihBbqUHdr2T3pfaMLb1Y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: deed3961-689a-42aa-fadf-08da694e3b87 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:16:35.5198 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XNHKuZUw1aV/gpkOdYhNpn9CzErFjqZraXVQ9GPp3HFCK0SzmS6jm3e556Pqt/rcikgjMowk7SE7n/TpIZRo4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB7309 On 18.07.2022 22:50, Andrew Cooper wrote: > The logic was written this way out of an abundance of caution, but the reality > is that AMD parts don't currently have the RAS-flushing side effect, and nor > do they intend to gain it. Nit: Looks like there's a stray (leftover from a re-write) "and" here? > This removes one WRMSR from the VMExit path by default on Zen2 systems. > > Fixes: 614cec7d79d7 ("x86/svm: VMEntry/Exit logic for MSR_SPEC_CTRL") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:20:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:20:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370350.602046 (Exim 4.92) (envelope-from ) id 1oDgbG-0000eP-1y; Tue, 19 Jul 2022 06:20:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370350.602046; Tue, 19 Jul 2022 06:20:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgbF-0000eI-V5; Tue, 19 Jul 2022 06:20:53 +0000 Received: by outflank-mailman (input) for mailman id 370350; Tue, 19 Jul 2022 06:20:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgbF-0000eC-1h for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:20:53 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00059.outbound.protection.outlook.com [40.107.0.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ef4c3733-072a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:20:50 +0200 (CEST) Received: from DB6PR0201CA0003.eurprd02.prod.outlook.com (2603:10a6:4:3f::13) by DBBPR08MB4251.eurprd08.prod.outlook.com (2603:10a6:10:d1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Tue, 19 Jul 2022 06:20:45 +0000 Received: from DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:3f:cafe::2e) by DB6PR0201CA0003.outlook.office365.com (2603:10a6:4:3f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Tue, 19 Jul 2022 06:20:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT032.mail.protection.outlook.com (100.127.142.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 06:20:44 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 19 Jul 2022 06:20:44 +0000 Received: from fd439ccb24db.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2330313C-D0F4-46FC-B84F-1409CCEDD593.1; Tue, 19 Jul 2022 06:20:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id fd439ccb24db.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 06:20:37 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB7PR08MB3451.eurprd08.prod.outlook.com (2603:10a6:10:49::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Tue, 19 Jul 2022 06:20:36 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%5]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:20:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ef4c3733-072a-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=hyucavG9sL5B23ZBgVWFiWrc7IK1TYO+pEoM+HbBXNo4xLeq6cmXkOPLi3Go4PAlyRJIrMO/XK3uNsGhyijzHfl81TzBYh/KQ/QxxuPHEjasNKC9MzZ3Vw/fxCVTm0N9UD4X15K8XVPSM1mA/HUIlqxQ8t515L3Giu54P8f4XJS3qASPERcAwxboGFNTSU5wJiSakAF+ZvAqoOT+KmDOKK1DgL62lmPfPi+9HXDRZSxHiBdrbPYvThCSltiASecqSBqjLsF0m8tIF2RqBfA+G0OhINDXauWdeyf2/mBBO3bycu7KmsVbPQMVdKyrkYvXWLOvLjd2R6EEz4TzEqF10A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OtRjFiW1AfgmSvZaCYkGvgrGtvipb+RsPJ4GAoae4AU=; b=PawqjOfnMYVarVm47DTFpUn+W0jGmY31fLJpPJ4MBCCCPXuCTBMxGIzKTA/KyhsqnnMLyeRNNFQfg1R1ORmHBY2ZofxdCKSebGoUOU0TCbLEPoDtTyHuFnqBsZvueep9jATdrmuPhsmDyUA2nPSHz5rxD1agb8g1Biz7BbFzrCQRhG5uQBuVkFDqWGVd0AiYuXVyij9h5druZMF1z/BFakdVmRvz1ftH0/ltllMTrFR+hGsDQxUCdGH/L5Rm2i+4lw3Q9hdVUO5AMSObeUojLejoX0DxdCxWtznUW+DxYtmaO6Ld4vXbe5XziaJfovl1l5sQKNW8gUesUFEtj+9SIA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OtRjFiW1AfgmSvZaCYkGvgrGtvipb+RsPJ4GAoae4AU=; b=zPyOfAsl8JL2izPnCAkYJA3lNRj8vvuFF7ohaqMxQgpbF4w4/I1yl0kaMOTyyHl1xT7f0S6lxn1NtxMOopXfmDTH1oV9l9kQ3oJBjU3NGVTD6rAXDdq07SgTbBPTWDWF6MED/Y59FI7tBA6SUjOZV2FSu5fCKWz2sLcU1A8Y0/g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9f3b3b7a3a808798 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h67VteHR6Sp+f+BHoAXvruTJLMNYDlgN44IPF9jOw4+Zr7LI/k38stZvP7tLwKQN1MNXaW5aw+PPLTwkDS9OpcVmPeGhJT675jfiFdZlQ4fERH71QCCJ5VEB4Y+GrglZRTX6AKsh6EJwfwO2VQnZkI3qZlKWmCb40PQbFz4gfruULaYjLNkYV1sLq8ABt2fNBHdj8n6mw6rOHaKNFLfrhv1VnBA4lnVHEzcjeZEfh27cyI2hU6KekAsvFk7Ee1oYYDQPbtvQy6EVCwrCIw9IZZEKRum4yfFhsBjD6s6/rfQNi5SjnArzE37ZCx8ahMGiUxyH65YS9c+ASl7d9RFb3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OtRjFiW1AfgmSvZaCYkGvgrGtvipb+RsPJ4GAoae4AU=; b=RN3zFiPAXo6Ees+nVpklzg8R3BsdwckSgYKXe35Qc8jGGubL9Qp92Adpp1UyCMN8hxtlhn3GSdeIMCCQAGnsO2pMsnjDevSH7iqz/5HARMx4UuhrSzbji7cb1KNwYL2/6yyUljs/ZKx/hzBaROwbL8m8C6PvO26YMrIrlxFrSgtE3ywcK1lH6TdcswDPoeOxkg94Niegs2JoS26hMb+HX8ipVGDmXEkS0kXFSBeH2PiyxQ/wUqmQMg6NXs6Ih6YKqg2CfmgteatlgLrs0BwakgYQ0Yji8Emw3eyo7jgSLz8TiCXLR/+pUsdZKcaX2iCAbCkTfC/YETkJkcj5MxpCzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OtRjFiW1AfgmSvZaCYkGvgrGtvipb+RsPJ4GAoae4AU=; b=zPyOfAsl8JL2izPnCAkYJA3lNRj8vvuFF7ohaqMxQgpbF4w4/I1yl0kaMOTyyHl1xT7f0S6lxn1NtxMOopXfmDTH1oV9l9kQ3oJBjU3NGVTD6rAXDdq07SgTbBPTWDWF6MED/Y59FI7tBA6SUjOZV2FSu5fCKWz2sLcU1A8Y0/g= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: <0f8da611-0825-91ca-b1eb-dfbe0fb709f1@arm.com> Date: Tue, 19 Jul 2022 14:20:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Content-Language: en-US To: Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Cc: Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> <20220718211521.664729-2-volodymyr_babchuk@epam.com> From: Wei Chen In-Reply-To: <20220718211521.664729-2-volodymyr_babchuk@epam.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0172.apcprd01.prod.exchangelabs.com (2603:1096:4:28::28) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 21d531fc-ab2b-42c0-7d1a-08da694ed014 X-MS-TrafficTypeDiagnostic: DB7PR08MB3451:EE_|DBAEUR03FT032:EE_|DBBPR08MB4251:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mj8jvFR51X9HKNeJHJ91IOhiWsOfPmnjc8PJcYomhQfM2yHkcx+MGgD54nxiBbrdqx3Lpd0N8A+GL4ZiMB52Yyq4ytcrR2meVPnxVzE5QeFXNx02kFwB7ggDX2xjWpPIdwoZBYbAk5G+22ihqw3oVs5C66wHWFjr2vPTxWnku4nOhm0VTw9LND0Elhb41R8CJxzKS9MvpE4tb91Y0oC6fLcJf/r0aWR/SKXBS4Lb+ozLXcyuH9zakWIJww1ZB/KQEJggBjEsQztMNxOAK0e9DrKXiCdT19j/3yYNEjKVNl7rOE0t1XZE7peQ99aFNxhgauF46LlKKbkdmYSjiq0XGncUJKVONRvejR86PuPWD+HEz5R68eRJpQzxq06ImekunYeafm+dq+5TT/qha1XaWIYgyHWiFhplwlj2TF5zoTUke2QY0Hu0+9l+sG5MgQ3jHSfLNYXup9MTN8WXKAd1MW1HaKBDFytKiNU7J1cnvc39pA3osFYuJ9l7CFBPqYjIcO7NVwbRh2sltQXIYriZDJ8rrKV57Cpm9zFv+3OTWuvJ0EzRvq6k5HY1s+70SnDPyV1JYCaOtQX0XovAMzx8/6N6bjVzpBfBEkV+kRBvTQ23F1GevL4cjelENr+pXNELp2lHgIjcIPtLTfFxF4ZZHXzdUjSXV5LkcqwoJU8NAPy+bEqzhYjTuxN6Jb1s8ObnXG3aOACHRljDeISk7UedeGfm/Z+iV15XP/Rt2zvlh86zVDA9ueLgmQajY1LhdJDmTY3eEXLvP9rHq4jEqmibDz2zau7otdqm/nxenRktu6qjVIY4JsqL+IX0shn0+/oKzrW5ShZ7Wz1QaeC7TdOwDSBAZMOEUcZFYMBOuoy1i+8= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(2616005)(66476007)(66556008)(2906002)(41300700001)(4326008)(31696002)(478600001)(8676002)(5660300002)(6666004)(86362001)(66946007)(186003)(110136005)(6486002)(7416002)(8936002)(26005)(6512007)(53546011)(54906003)(6506007)(31686004)(316002)(36756003)(38100700002)(83380400001)(43740500002)(45980500001)(309714004);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3451 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f4fd6f35-b16f-496a-0126-08da694ecb1a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F0/azdG2x5aVzb4E5l3ONu8vrul1NtukelL128bknRhoGqJ4XAEZI78Q/SbkJEndTAskG9TS78hClxQTGXCKh3/vG7eF2ZtDCZEygeSN8qR6fMN8s9yfoNQGTtM37+JyfjetAnz5twsNSsgTmXshX8AebMghuI4W5EOavG+q5PEgZhyd2oNzcyDZtf3SMKVRW8nG29Tk9HzI+UhVDXdXt5v44/PKxundZza3YKdoSjQbmdsuWHAdCJUNqBYWFj1SpUXgwdYiQJgMW19JiLkEyOgojxnGtsVatO7AeIsFHfFxFLmk+Dm1FxxE1ESBAHLE2UPfA7XRRrwjTMWQbq7GsrllSBtgNBvz4fagpaZJQuA8kH9Ig/PFqriWaM59DhHUxwvGDya4/cLWilSezjDgxio5xE1+i2uMwtxAVzlOAfEPYN6Fz7JbS8NJfdZ17uSXEXTJpT/w+RatjeN+Jp00leOtoaPdoytaa73HNlkxUzPaRxG+FKzfyohRMDm4hEFHI24dOHNlxjR3M5vcyjy7CnzPs3MgP4vsnKdBznwK2ozR6/2I4TfdATXosQF5Bzk7kz4e0rRPUhl1XYbusyd5Y5bZnmbUhCM2LdwUIPOeurboic3zA+EJExKvx/yYRnFRRo1xCc8XxH9UP4NJ4vpMXbOMgNaOEYBkhiDgeE8js8q7L635K5yemCVuwhg11bGyP1RuYdYmAKUDEtz5yZFj4vg0DtNz4VHjprSVMw+bhtDjbZIqLocRryfSxkpICLrPzRJmbxXV8E3PRfZhbkC6hb2800eHjg6ml37B+zoM9G7oHkIUjxXluqn6kC8kpooWEL5v9ztNrnxsPsYpMqAGYjKYO69h2DxYM1I8KtvF8o4NxUxZYEPqH4kKXqSTf2TB X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(396003)(36840700001)(40470700004)(46966006)(83380400001)(2616005)(47076005)(336012)(186003)(36860700001)(5660300002)(81166007)(356005)(8936002)(82740400003)(31686004)(82310400005)(53546011)(6666004)(40480700001)(26005)(2906002)(6486002)(70586007)(478600001)(41300700001)(316002)(40460700003)(70206006)(4326008)(54906003)(8676002)(110136005)(86362001)(31696002)(6512007)(36756003)(6506007)(43740500002)(309714004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:20:44.5715 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21d531fc-ab2b-42c0-7d1a-08da694ed014 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4251 Hi Volodymyr, On 2022/7/19 5:15, Volodymyr Babchuk wrote: > From: Oleksandr Andrushchenko > > if ( !use_msi ) > return -EOPNOTSUPP; > diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c > index 938821e593..f93922acc8 100644 > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -50,21 +50,74 @@ struct pci_seg { > } bus2bridge[MAX_BUSES]; > }; > > -static spinlock_t _pcidevs_lock = SPIN_LOCK_UNLOCKED; > +static DEFINE_RWLOCK(_pcidevs_rwlock); > +static DEFINE_PER_CPU(unsigned int, pcidevs_read_cnt); > +static DEFINE_PER_CPU(unsigned int, pcidevs_write_cnt); > > void pcidevs_lock(void) > { > - spin_lock_recursive(&_pcidevs_lock); > + pcidevs_write_lock(); > } > > void pcidevs_unlock(void) > { > - spin_unlock_recursive(&_pcidevs_lock); > + pcidevs_write_unlock(); > } > > -bool_t pcidevs_locked(void) > +bool pcidevs_locked(void) > { > - return !!spin_is_locked(&_pcidevs_lock); > + return pcidevs_write_locked(); > +} > + > +void pcidevs_read_lock(void) > +{ > + if ( this_cpu(pcidevs_read_cnt)++ == 0 ) > + read_lock(&_pcidevs_rwlock); > +} > + For my understanding, if pcidevs_read_cnt > 0, pcidevs_read_lock will be unblocked.I am not sure if this behavior is consistent with the original lock? According to my understanding, the original spinlock should be blocked all the time, if the lock is not acquired. Maybe I have misunderstanding something, I am not very familiar with PCI subsystem. Cheers, Wei Chen > +int pcidevs_read_trylock(void) > +{ > + int ret = 1; > + > + if ( this_cpu(pcidevs_read_cnt) == 0 ) > + ret = read_trylock(&_pcidevs_rwlock); > + if ( ret ) > + this_cpu(pcidevs_read_cnt)++; > + > + return ret; > +} > + > +void pcidevs_read_unlock(void) > +{ > + ASSERT(this_cpu(pcidevs_read_cnt)); > + > + if ( --this_cpu(pcidevs_read_cnt) == 0 ) > + read_unlock(&_pcidevs_rwlock); > +} > + > +bool pcidevs_read_locked(void) > +{ > + /* Write lock implies read lock */ > + return this_cpu(pcidevs_read_cnt) || this_cpu(pcidevs_write_cnt); > +} > + > +void pcidevs_write_lock(void) > +{ > + if ( this_cpu(pcidevs_write_cnt)++ == 0 ) > + write_lock(&_pcidevs_rwlock); > +} > + > +void pcidevs_write_unlock(void) > +{ > + ASSERT(this_cpu(pcidevs_write_cnt)); > + > + if ( --this_cpu(pcidevs_write_cnt) == 0 ) > + write_unlock(&_pcidevs_rwlock); > +} > + > +bool pcidevs_write_locked(void) > +{ > + return rw_is_write_locked(&_pcidevs_rwlock); > } > > static struct radix_tree_root pci_segments; > @@ -581,7 +634,7 @@ struct pci_dev *pci_get_pdev(int seg, int bus, int devfn) > struct pci_seg *pseg = get_pseg(seg); > struct pci_dev *pdev = NULL; > > - ASSERT(pcidevs_locked()); > + ASSERT(pcidevs_read_locked()); > ASSERT(seg != -1 || bus == -1); > ASSERT(bus != -1 || devfn == -1); > > diff --git a/xen/include/xen/pci.h b/xen/include/xen/pci.h > index f34368643c..052b2ddf9f 100644 > --- a/xen/include/xen/pci.h > +++ b/xen/include/xen/pci.h > @@ -158,7 +158,15 @@ struct pci_dev { > > void pcidevs_lock(void); > void pcidevs_unlock(void); > -bool_t __must_check pcidevs_locked(void); > +bool __must_check pcidevs_locked(void); > + > +void pcidevs_read_lock(void); > +void pcidevs_read_unlock(void); > +bool __must_check pcidevs_read_locked(void); > + > +void pcidevs_write_lock(void); > +void pcidevs_write_unlock(void); > +bool __must_check pcidevs_write_locked(void); > > bool_t pci_known_segment(u16 seg); > bool_t pci_device_detect(u16 seg, u8 bus, u8 dev, u8 func); From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:24:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:24:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370356.602057 (Exim 4.92) (envelope-from ) id 1oDgey-0001HG-Ha; Tue, 19 Jul 2022 06:24:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370356.602057; Tue, 19 Jul 2022 06:24:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgey-0001H9-Ef; Tue, 19 Jul 2022 06:24:44 +0000 Received: by outflank-mailman (input) for mailman id 370356; Tue, 19 Jul 2022 06:24:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgex-0001H3-Lx for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:24:43 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130075.outbound.protection.outlook.com [40.107.13.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7997e6f5-072b-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:24:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM7PR04MB6854.eurprd04.prod.outlook.com (2603:10a6:20b:10c::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:24:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:24:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7997e6f5-072b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TWLomfDueT00QcMKrAO9mzmYjbsFWQfvC9a4FhXTyxjF9kmJRvlzO/w4Df/kAIZr92YQB+LkLFR85RxZKUO6uw2G3QJQ4EOGQt9+BZckB5Zn03/HsKXPYu3fHZ1cBOD9JlgM1ZyFNt28B2nHs2/RSHFWDKx4nI7m8YRqguH/7gvpDaYM+sCh9kKs53fbKee622KNOGYRTpX2BzFzf2q1JIUAXIg2t9on138qKoFO5Icuew8MQUnI2yueAOVuu2OaLgFaiZ2ougNbP8VNVy14ul8c+ssNmrReO5XO/F9qWI2cPa60U+fmiaatIsa+3ujEQC7QtBqfL/kwBLe+xNv0xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x72as8QuhGziGKORR5Eq/6hR1cWgcm/44/vg/7Fd6Qo=; b=RBg0oIZqrRJM+RyH1dg3x6HPc70LJCY2eA5gbdi6nVELQk0tKZRqCR1SaituG1zWAyWMUBSEZaXQcFpzyRAH6MJsnJleQSOpZ/mr8u6QMzG8+OCGntu+xvXVrXAJ6glZcqYPUTXCydOzpMHOt+OBpa94ocSxK1PGrzX3udI/VVs6olTbqDHDTiKgv7/k5zR4ngl7GxRCSn3rBAQdN/mkD0GwmpQWu3+KmmJsiTcL11qKEktWM4K2NlaNjfR6j+v9+cXz9yGUmvlPLPbJ6qMnNIxo1dRsR7b+F8PHHxffcL5FQb5NMLoifSwN1OcnDM76y3ReSyxrgvHhZbr8saS9Yg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x72as8QuhGziGKORR5Eq/6hR1cWgcm/44/vg/7Fd6Qo=; b=3ehKtVKiPjA5m9Vf4CNinqkVIU139FJDsBUhuRSJPPHZ47LuSZzTFaBz9fInk0QMRUmYPt8EAvnqfzcAGXecrGWLJAju3dfC8LmNlJ/xyLDUactVFWbIxFRhwsiLH3/if/ExtV3kXrqm44+6r9ETSU+1QO6uiZjiyT3R1rcAk2r4rB2erakBvtrKn0See8/Dz50t7TURBrS7mft3z4P3p9Ec7vzGt5G/wqDjPTi5d9F6xDKhx+7c3RppZozKuHKcEKzPmKkAZ8RRroUvW87XfUzUUjMJ4+uhXyXd33+wow6QFlD4BWEW1ieS7ccM/F/QhIfQEC3wMUHc5FrSeR5lYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <29855733-aac8-8c32-f4fa-e0b5922c5be1@suse.com> Date: Tue, 19 Jul 2022 08:24:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/3] x86/spec-ctrl: Shrink further entry paths due to %rdx being 0 Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220718205009.3557-1-andrew.cooper3@citrix.com> <20220718205009.3557-4-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220718205009.3557-4-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb64c329-5092-4c8e-023d-08da694f5cc1 X-MS-TrafficTypeDiagnostic: AM7PR04MB6854:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EbW8eeR6jHXi7oGBgB23aKa9v5KbFLdrTBwZBKDgOV8YE6R52/nU7qnX8L7Rt7TRt2LX4iwfJB61m3OdAxkDpSkzyuUjwkRTawy2myFOil2SFLGl9Asm60m4EeHkZcyMumty6Ww+Sk/duDCueVAOWslCFjLd4P4G0GAKo5TLlNVgvhZDMJWSBepE4QdNI+xTasz5cYncDl0lyVcW7KefZi7QDVsuBY4tL7RFBjNngVwqxaiO0T5Kyoigsz5VdSTxSs7MgxeCMtcIOEr5NGJ1aLflhPr1be4Ii5tA8GRXtmzO9GPrNLbO7tKILejG+tDrbQw3yPrAzdpyYzH0ODTNwPclfz9OL/ePBkWNvB387nlmLDzli8s3AMtYziGjupsepBWHvAm4R1aiqMK54fKhtiAP0LsJkzs0HAMgBpnbdI3BR04m8TW8x75Ud2V9JnT8Br/FtZdlfwr5aT8EQYG1PJ3gRt9ahEM6XpmcbCcdK29lWCI3yJeLRL+YpH6EY8YtLemuE1QCTBhGoTlCXl/LKfEq16+SKTjVBltWJY2flBqsckYJt5mkOSBWB7DbX98v0LQsOjhYAC8usSUUEariwKE/wSAG7bOeh5kr9aEZcxfR5PPmhp6NgD0069L4nEhjp9cVrwAWfmSp/fvie3ncAUODSXi0cvCLp2glSbrE/2rYIe6ECxRpNTrbyAO4bkU3ky2OWCjPNcSy99IGIThuOpuiKCFy3Ru6N9QtG0yRWTxaVt0XYgstW1Ko53m7BEqtWOzBPL8FInrbbBE2Q/H5DLsGrESS1ATRfm1ZQIxjcNYtxIUbWukjcDg1DpGuF6qPPom1rcmjHR/CZqzi9porOA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(136003)(396003)(366004)(6512007)(186003)(2616005)(478600001)(6486002)(41300700001)(53546011)(26005)(66476007)(38100700002)(6506007)(54906003)(4326008)(83380400001)(66946007)(31686004)(2906002)(8936002)(5660300002)(86362001)(6916009)(36756003)(31696002)(8676002)(316002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnduWFRSTDhYcEwzd3lmdktGVENkUjBtWWtNUXRrRVdiWWVndDdhNGJlaElp?= =?utf-8?B?NnVzTjFZcm1RTEd6WXdUTFBZSytqUTgyVURNdVdGL0JhT1BRaldyZjBVaU1h?= =?utf-8?B?N2lqOUVtNXBTZWs5VG9wcUhiTVB5UVpzbTd2VGhWOXlzd3I0SVhXeEFHTnFo?= =?utf-8?B?THJKMkpzWjRTcHY5emJaZ2RsekVPWkNTNVdVUmdsQjVLRmZEUmYrOUx6bEpH?= =?utf-8?B?TEhCMEpGRCs1ZEY3S3JLRVlYWnpDNk5La2RuVVdlajdXNEhpUTB1VStMa250?= =?utf-8?B?MzhPeGV4RUtZSE9OaC90aFlMbUlzWmRjaVZXTnN6cTVTVDJTK0xkWThFVldS?= =?utf-8?B?U1liU0loQ3c4ZjNLUGtITHI1KzFITUhmTHBHeVRibDcvbllwSFA0dUI3UzZZ?= =?utf-8?B?WE1CQSs1d2FNRVBXWTZjNTNPL0pRVmNPL0RuSWh6cUxRWHlvRWw3K3NkTzB0?= =?utf-8?B?bG14d2h5V0h0ZktOVjBqUGF3NlhKc01MTUNLeFFGV1F3eUt3Z0xZbEUyUnl2?= =?utf-8?B?dGYrOSswR1NpR3pKZElZVXV5UldLeVpXQzVaWk5CKzgzb2VoZlMrY2VubEF3?= =?utf-8?B?UGpmUkJ6WWFteDdhdG81emhSWDRMQ0N2c083eWppN3hyVmNRZjFHWnhDT29q?= =?utf-8?B?cmZrVkpENUlOTjZMWDc4Z21hQWlReGxNOEl3WGhVM016ZHEzYnMrajFIOUph?= =?utf-8?B?R2VNMEdzVEc3NUVsMk1FM09wdmMzYTUrRXp2UXJocFRKRWtiUkJ6QnFIU0Ru?= =?utf-8?B?TjZqYUVuUDc0U3k0d2Ixa2dLeUV4cERnV01qb3NPQzFET3NDNW52RWd2R1BK?= =?utf-8?B?S1JvWUt1RDZHdkt5VGhNZ2o2cTZNcFFTQ2lsYXBXL0k2WXMrV2FRR0dJckZH?= =?utf-8?B?bWFIMStqTjhBR1pXNEhFYmxEbzVRS3k4VjFRbEZzSTR2eXlGWEVDNG5IZHFm?= =?utf-8?B?MHMyU3lZVUV1enAzc2luUGMzZzZOdWdNUmJMQlYwUXhlOFdWbm83Y2h0enll?= =?utf-8?B?a3lpUEZlMEY3SjVIaCtWQVIwR09wOWdPV0VFR0lnR0xYYlFFREx6akZiY2ZL?= =?utf-8?B?UGY4bjdGOE9Wa0tnYm91cytXYStlQktJVURINVpBMEFKVTFnL0pkM0ZvTXhG?= =?utf-8?B?RlNaL0crNis2bmNhVE5nTEV0ODhrWXl4bDhqdFpJbStKR2RibGxtMmo2RVAw?= =?utf-8?B?YXd2ejN0bHRDRzNnRlFsRUFaUzRGaHlEeGFFOWYzeW5WMnYyU3hKbWR2NW5q?= =?utf-8?B?VW8wTkVTYmdaeUlRM0pVK3ZaRFVsWFRpYmZFODJXSWlZOE5FeVpxeDgvMnNk?= =?utf-8?B?THBraHFkSGpYeGJTOWVIUTU0ZEEvdU14ZkVVOFRuUmdpMHF3UGgrZTA1dzRs?= =?utf-8?B?dU4wWjV6QmQ3WEZNSFJRdW1MT2lScmJQeENTTE1FQmxzcVp5aEZOM016cGhy?= =?utf-8?B?OXpJSnNweXhTZEFEWm9iSDJDRUEwTGhFaHRvMmt2OXp1K0VCR2ZFZXc5eHNP?= =?utf-8?B?bDlKZHVhdGhCM3drWFBGZERDaHQzcFY0NDQ3Rm9oazlacHFsNjNKdFRtekQy?= =?utf-8?B?Z3BzQ1EvL1JsaG9wUjFoNkVPcld0TkNuMjdseGQxQU1tS2s0eWdXbFJ6Nit5?= =?utf-8?B?b21yazJSWEZUN2M2dVZ5V01zdEdibG1ZdXhkTjhRdC9nWE9BWTl6ZmVOQzc2?= =?utf-8?B?cHEyL0VpYThnNzJ5T2Q4aTlTRktOSTA5Mk9LN2hPUXlEdDdnSGpsWWdEOW10?= =?utf-8?B?YW8rZnJuc3JvQTJtWkhVWWt4KzlJNVUvR1NQNy96QmtTTnhmWTFuNEc0eWZo?= =?utf-8?B?TWVRMFlYaEt2cEhUcWhQbUJISDZvOFJpV3FpWE56Qmh5U0NKd1AvcVhFRVhD?= =?utf-8?B?OGVTb2JuMFdGNUkydktnWWlYS0JVTTRFYUVHblNuMnhGSEw4NXdzTGZWL0dL?= =?utf-8?B?VWhabk5HTm9QV1FrbmduSW0zbURlMWVPVW5ibHZvVmxZVjI0cGhlZTBNcy9t?= =?utf-8?B?TGVuRmJraVNhcjIrUVYvK052R0pQSUo0NVV6aTVtRmY2SGZiSDZzQjdFb0tF?= =?utf-8?B?WDQ5VkN3TG1jTHpYOXZ6TDF1NVpBQnRHdVlQT3JkQTU1TzlSWGlFN2pYRGVa?= =?utf-8?Q?Sc+16HYHIvS/YsoS4OQuJwfYl?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb64c329-5092-4c8e-023d-08da694f5cc1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:24:40.7082 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KfhBTtjIOWie+wmwcB4hCuA4QmwysyaQNaxam/nm9IOSzEJZsIWcIWrhE468Xxw4I+EhjBDSrIjeJjCHAT43+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6854 On 18.07.2022 22:50, Andrew Cooper wrote: > --- a/xen/arch/x86/hvm/vmx/entry.S > +++ b/xen/arch/x86/hvm/vmx/entry.S > @@ -33,13 +33,12 @@ ENTRY(vmx_asm_vmexit_handler) > movb $1,VCPU_vmx_launched(%rbx) > mov %rax,VCPU_hvm_guest_cr2(%rbx) > > - /* SPEC_CTRL_ENTRY_FROM_VMX Req: b=curr %rsp=regs/cpuinfo, Clob: acd */ > + /* SPEC_CTRL_ENTRY_FROM_VMX Req: %rsp=regs/cpuinfo, %rdx=0, Clob: acd */ > ALTERNATIVE "", DO_OVERWRITE_RSB, X86_FEATURE_SC_RSB_HVM Leaving %rdx documented as clobbered here is misleading - the scope of the comment is likely meant to extend to ... > .macro restore_spec_ctrl > mov $MSR_SPEC_CTRL, %ecx > movzbl CPUINFO_xen_spec_ctrl(%rsp), %eax > - xor %edx, %edx > wrmsr > .endm > ALTERNATIVE "", restore_spec_ctrl, X86_FEATURE_SC_MSR_HVM > @@ -49,7 +48,6 @@ ENTRY(vmx_asm_vmexit_handler) > .macro restore_lbr > mov $IA32_DEBUGCTLMSR_LBR, %eax > mov $MSR_IA32_DEBUGCTLMSR, %ecx > - xor %edx, %edx > wrmsr > .endm > ALTERNATIVE "", restore_lbr, X86_FEATURE_XEN_LBR ... here, but that's not necessarily what a reader might gain. Plus with the change the register isn't clobbered anymore. > --- a/xen/arch/x86/include/asm/spec_ctrl_asm.h > +++ b/xen/arch/x86/include/asm/spec_ctrl_asm.h > @@ -176,7 +176,7 @@ > .macro DO_SPEC_CTRL_ENTRY maybexen:req > /* > * Requires %rsp=regs (also cpuinfo if !maybexen) > - * Requires %r14=stack_end (if maybexen) > + * Requires %r14=stack_end (if maybexen), %rdx=0 > * Clobbers %rax, %rcx, %rdx > * > * PV guests can't update MSR_SPEC_CTRL behind Xen's back, so no need to read > @@ -184,7 +184,6 @@ > * while entries from Xen must leave shadowing in its current state. > */ > mov $MSR_SPEC_CTRL, %ecx > - xor %edx, %edx > > /* > * Clear SPEC_CTRL shadowing *before* loading Xen's value. If entering This is used in SPEC_CTRL_ENTRY_FROM_{INTR,PV} after DO_SPEC_CTRL_COND_IBPB, which documents %rdx as clobbered. Since it doesn't actually clobber the register, it's the documentation line which needs updating along with making this code change. With the respective adjustments Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:29:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:29:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370363.602068 (Exim 4.92) (envelope-from ) id 1oDgjf-000294-7m; Tue, 19 Jul 2022 06:29:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370363.602068; Tue, 19 Jul 2022 06:29:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgjf-00028x-4w; Tue, 19 Jul 2022 06:29:35 +0000 Received: by outflank-mailman (input) for mailman id 370363; Tue, 19 Jul 2022 06:29:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDgjd-00028r-7V for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:29:33 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80059.outbound.protection.outlook.com [40.107.8.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 25f3b478-072c-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:29:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2456.eurprd04.prod.outlook.com (2603:10a6:4:36::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:29:29 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:29:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 25f3b478-072c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLYE2nnClDEKKy+226xDbZoItBQoDZcs217M79bVpn10lPQ+CXSiXcwWa5J+0zS0MUus3qlEsm/55SjuM+Mhg/OWqsWB/hNQgh6TGDYz3W4sILCrm820U+N9+zUSEASUojow7GN9YX7/tYioCZtCvHEJzufMorXrBVkoslkA2z1J7imS0HF84gJYv9dKPIWntDBEHBlFKZmg9sM8W/aKad7zPwSWa00MvPu9vhq/J78AgUbl1HtwgHILXZWrb/UvM95jeIMEtKcGgyC1rJAdBiABhtFtTYKo4kodeO+xkBdtkosLsxeR2c3PbeGBLUcVgjCZ02xttMCIFKV+Dv5LJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jwj3HuGbaptPzMUmpnWm3KcocECrbuLMfqjFe01mlyg=; b=Nnq4bbkvrFq9N6Chfj7IcxGysdHTCkGklv9ovA0QPEzi8OM8/VcQywZIABChtopQKAnIZw+Kbwt71BlKnfSMd8VJ1r3eG2fcCJ3Sgg19GQCe0adD9HLJe/07GSqhdyb8J1KzGLpDXlM9CWpeUlTDRvnNK6TivlFHhfrbphU35vJExl+8YioDCfuy9uA9krpNwmpGLK8LUrsBVN4+zoQ9xrbDr5FRVtV5fdThjuRuYb47nt4kWu0XqgEjWk2+rFF0xiuDWZFxrD7whZZTqmPh3gu02GwHjFhw3Mgdp4H9UDABbRAYeguznan/nIqbI7QK8PJbCz7bE0cxqzbmfBCXEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jwj3HuGbaptPzMUmpnWm3KcocECrbuLMfqjFe01mlyg=; b=V+0wBYqS29JTPgcosiB6MjAckJbXkyyGVJY11HT523p7oEp9jIU5T0CatOisRv7ZRUdzh1n2W3xBc7MbVUlHLGKmz1Gg8lFoxcw3j4X5v0xOTQt2xZhM0ZlQ7JH976CZqHFV5JYeFXBrKFKGr/ZROMnLhH8PPL1wjMe7HJx0oDPgHams2FNDoD/XJZwY37xCKhIcGysoEiok5pv2ghc6Iabeacz5428++nPGy51F3H2B/P60/Yt6InsVTWsKpwv9D1YMCLTapYRNFOOnSIun82br4NQWZulo3UQu7j8fcy407cWkUEAw2fSMd0KK8HMBXnwzR3n6vGQtHpHvxG4cZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> Date: Tue, 19 Jul 2022 08:29:27 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly References: Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0067.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b132e104-f7c2-48bc-8578-08da6950087a X-MS-TrafficTypeDiagnostic: DB6PR0401MB2456:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: az9ASlZBw+BqQ+ODhtpxnvWPiomRUCtAxkzPBapZgsRzmRA7i9V/HeOwsGHjO5mxv7L+AKdbSA0zmcoiyRQdELPgEKkGyFxfv84lF9kH8WTyWn/L9uoWVeqaEECtAiPgSMt/KwicmgeqEvwVd16eoMCYf4TNJBYozKreEjIP7RFMq44jOjBdUl+wF/Ou3MODjqyoyFGsVV+7ztWrrfw3lYYSu6d4Sm02O6guDMQj7GxcWxebSM+DETgVmcEevkyHMyyHJ34rHpyJj5dEZ373bEzGnjp23D0ocdACFT/L88aUEo6p3fPkTId3+8Nki1ONFBmaWPPdT9ypKoQ+FvuS+a7H7WWqW/IEZUGvdvOr2g0Zz9FdKuARCCXMLyODLK6EteB8lJZEXDT+5R1THkGRrJZlMb8i9nEta1ek5jOkYXCijoQmTx8GQwpFlKbodofPE9HnCoMRLx5AY5EOqt7DGpS3/yRfGIPQG9j1y+VCil0e4YSM0+tUmKls5bzl975nSehmNqRS85O8s6ZK3cU+1N/+22lPIv2XoVroW5pa75WQsZUGg4CqzMC/ygOlLHzcvCn68WObV7G/HbU6NZ/h/DNK40bD7Yie6wsjH32ZolCZ228Ws2mZHP279GU6z6Zir2yPRTvzgFShX/wkuyO30AG4+aEh4ySH77b+lK1AuywGFSbLFwJ00sfgdREGj3yQ/oK5CMTcGR1FDdcWyxMw8UMiS+BinF3q2TwmGVwlphHNOsXycsN7YW0CIPfqi7f2PQ4m8k4n0A/UbI9IqrFSQgil4VSD9lHf27bV/V8LBVjAb250sFCMMU2frv3QQB/pQ3TNCWmPHyWNRvMDUD8IWLiCrvKcqvWpJ+XDlSA8kWo= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(346002)(39860400002)(396003)(83380400001)(316002)(478600001)(36756003)(966005)(53546011)(2616005)(41300700001)(6486002)(26005)(6512007)(186003)(38100700002)(31686004)(6916009)(66476007)(8676002)(8936002)(4326008)(66556008)(5660300002)(66946007)(2906002)(6506007)(86362001)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWVTQ21meXNvUjNGQkJJckl6Zm9uRlpMZmtzeEEveVdWb1ErT21kWXIwSEtN?= =?utf-8?B?N0xFL2U5K2NwcjhLVkN2ejBmOWpTWC9XbGlmYkF2TlNxZVEvREhrMGpZbitt?= =?utf-8?B?UlFwVGduRjBiK0EyYmw3REZkazduemJsQ0tyNmFWaGQxS2JZZTFNRG9JZHhs?= =?utf-8?B?dnNaNVptSUo0UnpWUkYxOUhRbTFFdlRJUUpTdnRFQmlNYVhqYktlUkdJN0ts?= =?utf-8?B?cHNwY2ZZa2c0bFRpeE51aWZ1ZzRDSHZHcUNxVlFFWDFJeE9rajdJY3p3RVZn?= =?utf-8?B?L1hiV2hFWG1LY2h2YzlZTW5GUEN4cVBsMmh2MGRrTzBUZUVBQS9XMFlnaXBt?= =?utf-8?B?bWQwdldzMkZWNEUrQ0JSTE1GQ1AzYVNFcmJXOFVWVjhoYkhsSDRXVmRVRkxQ?= =?utf-8?B?dXRTSXRKL2xKSjNBUjdsNUQwQlhSQmZ3d1BNZEhOdU9lL1c0RlowZW1BaCtE?= =?utf-8?B?YUFoZC9wRi92UlRMNDJ4VkU4ejVRWmNpZFE0Z1U1M29vRitqdTJudms5WkRy?= =?utf-8?B?b1FKR0Z0bmdkQTZTcStIU0ZkM0thamgwd3RqZk8rTzdDc3hSNVdKN25WNDNJ?= =?utf-8?B?Mm5ha242Ylh6bkJFZkNGa0hBK1FSRi9hZkpCT2t2Q2FpUGdGUU5DamlBK0FX?= =?utf-8?B?VDIreDdwaDNrTjhrRW9kUW8yS2p2d284YjBoeEZFaGRqWkF6bktyNW82cWlQ?= =?utf-8?B?ejk1Rjl2M2UzR016KzRqODdjL0ptMlg1MVZaTitTMUdrYVhna1NkbTFZWkd1?= =?utf-8?B?ZXo4WVhUeEdHcTFKdkZXeVpxNC9LdFhsRUt0QUR4dVYvMS9PZXlRK1JPS3hN?= =?utf-8?B?UDYyZUQybmtYb25VZmxRZ3VDc3IrUDQxRk5OeFc1b2I1V2tvdHdSMmNZNExh?= =?utf-8?B?RmNNNXBHeW9IMDV3aGRvNTg1UVltZHdIb2xUVVhTV0JGVzFHUDhHZGpId1l1?= =?utf-8?B?RjQySUJuNUgwUlhuakhPeXlTVm1vL2tRd1NNR2RGOHp0Q0dqbDdPNi9wMWJn?= =?utf-8?B?azh2TDJsbGtlQWczSVYwWHZLL21jNnFWSk1TQjM4SEpqQWhLV2wwWkI3dnkx?= =?utf-8?B?ZmxLUFMzRlUrdXJvRUE1NHR5NHpnTVZ1OVVYblpiT05TbXhJczlkQUdxZzVy?= =?utf-8?B?d2NLQlBYa3p4aE1lU3RCYUw5Q2xnTnNIUDR0ektvWVhvZ1RLa2gxUHZPcjEr?= =?utf-8?B?emVLVE1TUjVSTElwMU5aZG9raEN1VXd2dnorMDVOcGJhZ3VlZGhGQ3h1bStm?= =?utf-8?B?UnRIczhVSlRkYW5MZmRoMTVBQmlaZzZOQnd3VkpWcjBKanpqWVpsNWZNQmtp?= =?utf-8?B?MzlQcmtLL2U4OExmbmlsRC9CNmdkSlF0eFMzbzRGbHZyV2JnSGplb2h6WlNQ?= =?utf-8?B?YU15SndvdlJQUTdFSVd0a2p5OGJpaU5wNGdMdDdyTGFmUFFQSlpOQ3FsaE43?= =?utf-8?B?Vms2T1JFTlJHSTgzMmdnTEFaZnBBL3NwOHUvYnViTVcyY3BVRTJIbzNpanA4?= =?utf-8?B?R3ZGTzlWUDR0VnV5Sng2R1VaNU1jS052Sk8yUzVBYllnUVdEWXpUdHg1ejk3?= =?utf-8?B?TFpXbjFOd3hSeW53Skw2Q0JiWGs4MFRyeW1iaXRtbEt3NVpyYlBIcUtTcjZ0?= =?utf-8?B?TTZYbTIrYjdad3RUV292U0U5MkxTblk2Wkk5Z2FzUHQwWnNnbWJjOEhoS0xi?= =?utf-8?B?aEZFOFNCWkRjdWd6NVpVcVB6OVdEQkcwcGRqT3N0SG9MTy96aXVUTC9rZ2tE?= =?utf-8?B?WkFqR2dPZGdBR1J5MEtiM2dZZ0RBZ1pJZXVsZHY4Q2FQRElEWWEydm93blJM?= =?utf-8?B?b0QwQ09KaE9QakpEcnVXNmcyWGtQR3FqRHhIWVVYNHd2UnRJN3BTcmZKeEcy?= =?utf-8?B?NzJQejJhVS8raVdnbitHZmtRQWNtY2ZxNnlpdzl0djhKajlCZXZ1RGZqYm0x?= =?utf-8?B?ZGVwVURmb0hjMWFiVHNlSnJVWGIrSEpXbXlZQzluY3ROZjBhZ0xTTnk1TFVX?= =?utf-8?B?SlZrNFllemJndUh4WG1Ya2xPOEM0YnhUeGtGTkF2NDJxQzZrVjJyWURsMEsy?= =?utf-8?B?Y1RlbHdQeFR5TlMzMzh4TzJQT2JSL1NqVzN1SHhYY0R3RVhZaUhQMi9LeEdY?= =?utf-8?Q?3SzmHSGLMzg3QvLMKDJhy7/2s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b132e104-f7c2-48bc-8578-08da6950087a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:29:28.8456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BkSXLqWEnnLlu4oAdCP8D9R07IUyj+SC+A1P/gmiV7Dcd9GUHYadCzlI2M5rE7aflPQELHwRADOtx+bhTEnRpg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2456 On 19.07.2022 01:04, Dylanger Daly wrote: > I'm having issues getting QubesOS running on my Lenovo Yoga Slim 7 ProX (AMD Ryzen 6800HS) > > Firstly in order to boot the device at all, I'm required to add `dom0_max_vcpus=1 dom0_vcpus_pin` to dom0's CMDLINE, this is similar to what I had to do previously - https://xen.markmail.org/search/?q=Ryzen#query:Ryzen+page:1+mid:f3hel4yj25qilabv+state:results with the Ryzen 4000 series, however without these options added dom0 never fully boots into Fedora. > > The other interesting issue I'm having is upon booting any VM, just a normal simple VM without any PCI devices attached, it'll successfully start, about 1 second will pass then the entire device will hang and reset, it's virtually impossible to get any logs at all out of the device when it's in this state. > > FYI: QubesOS uses Xen 4.14 I guess you understand that with no logs or anything else technical there's very little chance anyone is going to be able to do anything about this, without having access to an affected system? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:47:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:47:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370372.602090 (Exim 4.92) (envelope-from ) id 1oDh1J-0004xJ-RS; Tue, 19 Jul 2022 06:47:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370372.602090; Tue, 19 Jul 2022 06:47:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh1J-0004xC-Oo; Tue, 19 Jul 2022 06:47:49 +0000 Received: by outflank-mailman (input) for mailman id 370372; Tue, 19 Jul 2022 06:47:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh1I-0004x6-4z for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:47:48 +0000 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b29ad0d5-072e-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:47:46 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b29ad0d5-072e-11ed-924f-1f966e50362f Date: Tue, 19 Jul 2022 06:47:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658213266; x=1658472466; bh=37G2tlaVzyhPuFL2u35GdUqZ0+Z/S5NnoDpS8FxgTTA=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=WVUsmYiBKOLX3Jqg6TKoI5sMPNv+2ERj8khHVZLfX4FhMwvIJcihu2+bg6NUrAaD3 4C2sbYSXG11i1Bx7YKTCDPOGIzSpsKPzVxI1pmOlbiEKNWRQTv8vz968AfU2I7pZuW nYLeNJhU08Jbs8zHU5vdcejD6YNitQU2RvKfo7RVLfZEAlpFDd2NuUqwNIbScyIvu6 gSFtoQb3M7a12mG+/h3ozkHqzlOspMrcYJQvPLDMNASDdNPhlDy+o9oGGcibHwBlNP Z1uMaglif7LrSwQJkR4iGx4jbdwQmExCkC6CXUFWlepFC16Gz3+rLxZTGpKfrdhh3E wrUHb6K7npyQQ== To: jbeulich@suse.com From: Dylanger Daly Cc: xen-devel@lists.xenproject.org Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> References: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_oKAIByR0E9jJOnj9JiOdROHoWzIjV572oGI9ouH4GbE" This is a multi-part message in MIME format. --b1_oKAIByR0E9jJOnj9JiOdROHoWzIjV572oGI9ouH4GbE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 WWVzIOKYue+4jywgZG8geW91IGtub3cgaWYgaXQncyBwb3NzaWJsZSB0byBvYnRhaW4gbG9ncyBz b21lIG90aGVyIHdheSBmb3IgYSBzeXN0ZW0gdGhhdCBkb2Vzbid0IGhhdmUgYSBDT00gcG9ydD8g Y29uc29sZT12Z2EgZXhpc3RzIGJ1dCBJIGNhbid0IHNlZW0gdG8gZmxpcCBvdmVyIHRvIHRoZSB2 Z2EgImNvbnNvbGUiIGFmdGVyIEkgdHJpZ2dlciB0aGUgc3RhcnQgb2YgYSBWTQoKLS0tLS0tLS0g T3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tLQpPbiBKdWwgMTksIDIwMjIsIDQ6MjkgUE0sIEphbiBC ZXVsaWNoIHdyb3RlOgoKPiBPbiAxOS4wNy4yMDIyIDAxOjA0LCBEeWxhbmdlciBEYWx5IHdyb3Rl OiA+IEknbSBoYXZpbmcgaXNzdWVzIGdldHRpbmcgUXViZXNPUyBydW5uaW5nIG9uIG15IExlbm92 byBZb2dhIFNsaW0gNyBQcm9YIChBTUQgUnl6ZW4gNjgwMEhTKSA+ID4gRmlyc3RseSBpbiBvcmRl ciB0byBib290IHRoZSBkZXZpY2UgYXQgYWxsLCBJJ20gcmVxdWlyZWQgdG8gYWRkIGBkb20wX21h eF92Y3B1cz0xIGRvbTBfdmNwdXNfcGluYCB0byBkb20wJ3MgQ01ETElORSwgdGhpcyBpcyBzaW1p bGFyIHRvIHdoYXQgSSBoYWQgdG8gZG8gcHJldmlvdXNseSAtIGh0dHBzOi8veGVuLm1hcmttYWls Lm9yZy9zZWFyY2gvP3E9Unl6ZW4jcXVlcnk6Unl6ZW4rcGFnZToxK21pZDpmM2hlbDR5ajI1cWls YWJ2K3N0YXRlOnJlc3VsdHMgd2l0aCB0aGUgUnl6ZW4gNDAwMCBzZXJpZXMsIGhvd2V2ZXIgd2l0 aG91dCB0aGVzZSBvcHRpb25zIGFkZGVkIGRvbTAgbmV2ZXIgZnVsbHkgYm9vdHMgaW50byBGZWRv cmEuID4gPiBUaGUgb3RoZXIgaW50ZXJlc3RpbmcgaXNzdWUgSSdtIGhhdmluZyBpcyB1cG9uIGJv b3RpbmcgYW55IFZNLCBqdXN0IGEgbm9ybWFsIHNpbXBsZSBWTSB3aXRob3V0IGFueSBQQ0kgZGV2 aWNlcyBhdHRhY2hlZCwgaXQnbGwgc3VjY2Vzc2Z1bGx5IHN0YXJ0LCBhYm91dCAxIHNlY29uZCB3 aWxsIHBhc3MgdGhlbiB0aGUgZW50aXJlIGRldmljZSB3aWxsIGhhbmcgYW5kIHJlc2V0LCBpdCdz IHZpcnR1YWxseSBpbXBvc3NpYmxlIHRvIGdldCBhbnkgbG9ncyBhdCBhbGwgb3V0IG9mIHRoZSBk ZXZpY2Ugd2hlbiBpdCdzIGluIHRoaXMgc3RhdGUuID4gPiBGWUk6IFF1YmVzT1MgdXNlcyBYZW4g NC4xNCBJIGd1ZXNzIHlvdSB1bmRlcnN0YW5kIHRoYXQgd2l0aCBubyBsb2dzIG9yIGFueXRoaW5n IGVsc2UgdGVjaG5pY2FsIHRoZXJlJ3MgdmVyeSBsaXR0bGUgY2hhbmNlIGFueW9uZSBpcyBnb2lu ZyB0byBiZSBhYmxlIHRvIGRvIGFueXRoaW5nIGFib3V0IHRoaXMsIHdpdGhvdXQgaGF2aW5nIGFj Y2VzcyB0byBhbiBhZmZlY3RlZCBzeXN0ZW0/IEphbg== --b1_oKAIByR0E9jJOnj9JiOdROHoWzIjV572oGI9ouH4GbE Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 WWVzIOKYue+4jywgZG8geW91IGtub3cgaWYgaXQncyBwb3NzaWJsZSB0byBvYnRhaW4gbG9ncyBz b21lIG90aGVyIHdheSBmb3IgYSBzeXN0ZW0gdGhhdCBkb2Vzbid0IGhhdmUgYSBDT00gcG9ydD8g Y29uc29sZT12Z2EgZXhpc3RzIGJ1dCBJIGNhbid0IHNlZW0gdG8gZmxpcCBvdmVyIHRvIHRoZSB2 Z2EgImNvbnNvbGUiIGFmdGVyIEkgdHJpZ2dlciB0aGUgc3RhcnQgb2YgYSBWTTxicj48YnI+PGJy Pjxicj4tLS0tLS0tLSBPcmlnaW5hbCBNZXNzYWdlIC0tLS0tLS0tPGJyPk9uIEp1bCAxOSwgMjAy MiwgNDoyOSBQTSwgSmFuIEJldWxpY2ggPCBqYmV1bGljaEBzdXNlLmNvbT4gd3JvdGU6PGJsb2Nr cXVvdGUgY2xhc3M9InByb3Rvbm1haWxfcXVvdGUiPjxicj5PbiAxOS4wNy4yMDIyIDAxOjA0LCBE eWxhbmdlciBEYWx5IHdyb3RlOg0KPiBJJ20gaGF2aW5nIGlzc3VlcyBnZXR0aW5nIFF1YmVzT1Mg cnVubmluZyBvbiBteSBMZW5vdm8gWW9nYSBTbGltIDcgUHJvWCAoQU1EIFJ5emVuIDY4MDBIUykN Cj4NCj4gRmlyc3RseSBpbiBvcmRlciB0byBib290IHRoZSBkZXZpY2UgYXQgYWxsLCBJJ20gcmVx dWlyZWQgdG8gYWRkIGBkb20wX21heF92Y3B1cz0xIGRvbTBfdmNwdXNfcGluYCB0byBkb20wJ3Mg Q01ETElORSwgdGhpcyBpcyBzaW1pbGFyIHRvIHdoYXQgSSBoYWQgdG8gZG8gcHJldmlvdXNseSAt IGh0dHBzOi8veGVuLm1hcmttYWlsLm9yZy9zZWFyY2gvP3E9Unl6ZW4jcXVlcnk6Unl6ZW4rcGFn ZToxK21pZDpmM2hlbDR5ajI1cWlsYWJ2K3N0YXRlOnJlc3VsdHMgd2l0aCB0aGUgUnl6ZW4gNDAw MCBzZXJpZXMsIGhvd2V2ZXIgd2l0aG91dCB0aGVzZSBvcHRpb25zIGFkZGVkIGRvbTAgbmV2ZXIg ZnVsbHkgYm9vdHMgaW50byBGZWRvcmEuDQo+DQo+IFRoZSBvdGhlciBpbnRlcmVzdGluZyBpc3N1 ZSBJJ20gaGF2aW5nIGlzIHVwb24gYm9vdGluZyBhbnkgVk0sIGp1c3QgYSBub3JtYWwgc2ltcGxl IFZNIHdpdGhvdXQgYW55IFBDSSBkZXZpY2VzIGF0dGFjaGVkLCBpdCdsbCBzdWNjZXNzZnVsbHkg c3RhcnQsIGFib3V0IDEgc2Vjb25kIHdpbGwgcGFzcyB0aGVuIHRoZSBlbnRpcmUgZGV2aWNlIHdp bGwgaGFuZyBhbmQgcmVzZXQsIGl0J3MgdmlydHVhbGx5IGltcG9zc2libGUgdG8gZ2V0IGFueSBs b2dzIGF0IGFsbCBvdXQgb2YgdGhlIGRldmljZSB3aGVuIGl0J3MgaW4gdGhpcyBzdGF0ZS4NCj4N Cj4gRllJOiBRdWJlc09TIHVzZXMgWGVuIDQuMTQNCg0KSSBndWVzcyB5b3UgdW5kZXJzdGFuZCB0 aGF0IHdpdGggbm8gbG9ncyBvciBhbnl0aGluZyBlbHNlIHRlY2huaWNhbA0KdGhlcmUncyB2ZXJ5 IGxpdHRsZSBjaGFuY2UgYW55b25lIGlzIGdvaW5nIHRvIGJlIGFibGUgdG8gZG8gYW55dGhpbmcN CmFib3V0IHRoaXMsIHdpdGhvdXQgaGF2aW5nIGFjY2VzcyB0byBhbiBhZmZlY3RlZCBzeXN0ZW0/ DQoNCkphbg0KPC9kaXY+ --b1_oKAIByR0E9jJOnj9JiOdROHoWzIjV572oGI9ouH4GbE-- From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:50:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:50:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370377.602101 (Exim 4.92) (envelope-from ) id 1oDh3t-0006Ie-8f; Tue, 19 Jul 2022 06:50:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370377.602101; Tue, 19 Jul 2022 06:50:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh3t-0006IX-64; Tue, 19 Jul 2022 06:50:29 +0000 Received: by outflank-mailman (input) for mailman id 370377; Tue, 19 Jul 2022 06:50:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh3s-0006IQ-06 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:50:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60077.outbound.protection.outlook.com [40.107.6.77]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11d88afa-072f-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:50:26 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4864.eurprd04.prod.outlook.com (2603:10a6:803:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:50:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:50:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11d88afa-072f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gI6EVl3ep63sP9gHJL4dbW9hP5MUX62VTwFg4hAJv1TZIwv5VqCmRRjWp8hEUsm24zEDv3DU3s39OXcGTmYzQsXg9GXEBdf1oWVr74W/Re8M9FDRnEPJiPubnB8V78QnpXfEceTVWq3VmgYc9oJdlfTLjezKZaH4WXlP65YGTpXW+fn2dstus4Y5Tc6y0yHEZmZ1bgyIewGfassRbQ9GnOeMLvGrUotCQBRUlJXwhaQTq42VqRCbzxmVWEQQ6D+6Tu0m6o+E3Cu84Q8KS9l4w3Nj5CjKmGT4+vTZ3B3HlzbUZcvGQtrpJc8aN/xyHmeUc16luFjCWxONSDjcKM4Z1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GUAzah9w/l5Z6D5t55tUznNm6b5NNsbbbrHqYCcZYGg=; b=BtGDMfm7SnWRqbvAFLr/Q8vJl0kebJDUVftcfk1TZyszf0d//86qZL4kZgyKn3CsrJDLejTTv3FHYHx5UYSjppTuHjc4ShUtyVplftGLkz2TgFBpOz14lVBH5m6Rxos9yUpKfY3pWAenDVMbjDSkn4jYC8rqroir5VZ9DFxw1h1dFJ+6OyKDnRJQSiPxOXxegeNrsVTHGmbLkwfzUkrgvJuYdmCTMZfc9MEVQzwPyoeweQwJ7yrTYV6pacvgJc38ynpSuHhdn7PQ8ZXrBxMdxOYqsCBDwbEvJm5iOuF/SEiagAeWKDBPxuzZ/HuSaB17uvDAbQUGXJ0VvqAbRtRw8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GUAzah9w/l5Z6D5t55tUznNm6b5NNsbbbrHqYCcZYGg=; b=gmoYhUoboOqA7iGQHMRSKhCwFmfXUiD6Q+HlfLoSxHl/rti0CRizdiS/zWoGs4LctoOyJXgIn0RZBR0WN4idjOx4koZuaVGoLQ0KeuekDWCaEpV/7uPUq8UWJmWxoHMypS5nLgIU3sAmRL8kXOS/NW62hIEJjdDHUfQTZsAoB+ErhdU64KBXOp97192zSlWtxylvT2n+7sApKucBAat0P5OVcSWtxBC+xjImqn23V4alaDEwXw3/dz1AwhQnMh3EtNw/KEsUmZMJNPYggEAPAzR/ky/k2+9WZjwyZtvwbWPgZiIiPZiAl4xuCGrymuMXdBK7R2ODF7lBOv6YG5x4dQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> Date: Tue, 19 Jul 2022 08:50:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: [PATCH v2 0/4] x86/P2M: allow 2M superpage use for shadowed guests To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Tim Deegan Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c428b28-9ff7-4a23-c92f-08da6952f536 X-MS-TrafficTypeDiagnostic: VI1PR04MB4864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: l5c6skmO32uHbNBPy45K7lKniIvHQOTXJt93lz9rfD4+vNozamr3eXJY18UZZxrRP4hd4BI2i7jUoeqUm653/tfWcg80SkULYYrpACcdcvi5pjF6KMFvIU0nE+pb18nSwUWm2KFqp6FACfQHVZCetVcXf2QIvTNApc9mh5OwfuS5Dqi+CIpLw1tl/ZKQtoDqwevcn4wsZOenjcL50sbms6jPfXPB7ArgQyN9eXJyFNaHmXISzU8C8HimRVSMj5zgIiuZTDSHUDiOPSZl/aKt8CIlhU1wEOKXhiZ7dFvwirt4EKeMTKoucIdZ309lkaG7j8m2eY8wWbT764FWUrpb4SNXzhVPbpcEzNunYKXRqEcmGu12rL2JcEIpyfcIFf1RsOiQJVhpInND2A4PQEYHfC0dkEcv1ChLo4Fv0uAB8G7UuSqaPlIE/vJYU91BRjZCOCjgE49wBd+pklaADe+PtpXQHqsRcPIFd0YQ9z5nkIGvbUHCAeH3CwIfTXWD9lausJ3+IVwon6201wKvsIdFlEJwc4uNam1Dn/wGTLjApspAoyTLJ7r3OEmMuHkt3gykgmUeleKTAW+j8q6LkC+0CiLtQK2OFohbfr8WWACqpDwE7KelFq+QvNQ1ajn1ldhmbL18+enpu3cFTanrfbEQ0FgQxQt3iSQ20CqF0NYmkiBsvrsrpPYBpdDj/BSuMvxDOIm41pheRLB4CPRZB3HRw2Tv4R038jtNISZah+1MtkcVtwWo4J6wcV1Kk+n+QsJemK21qPmWGIl3rA5/1iE3UBI24GnIcnBCpjvmi8x3OXYS0KReF6mK1eK5iKrLqNRZpThLok5TW6ySBAq9yYB8PA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(366004)(136003)(39860400002)(8936002)(4326008)(66556008)(4744005)(66946007)(5660300002)(66476007)(54906003)(38100700002)(26005)(86362001)(31696002)(2906002)(478600001)(83380400001)(316002)(6486002)(8676002)(186003)(6916009)(6512007)(2616005)(6506007)(36756003)(31686004)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHVxWXpyZVNjZTJBZnpDQXhNbmthN1RnalBUV29pTGNyRUlpVFVjVWhiNEYx?= =?utf-8?B?Y3A4cFc0U2RlLzJtdXNHdXY4d1BqVDZ3SW9GK1NPY2t4dXNCRm1lL2M0TWNI?= =?utf-8?B?R1JBZUNic3pMcjMraUlvcEdGQUJyeXVab0htbmpBUWlJZUN2WHdjQnUwQzdM?= =?utf-8?B?c3BLaU5GUWJ4aDZCZHc4TmVtTmNydUdmcGY4YUcxMys1eTFUVzYwUkVLOE80?= =?utf-8?B?akFSem9xSlB1YjlyUGt3SC81a3J2eVhjRm53d0J5Ym0xblNYOEdYN2VydjdT?= =?utf-8?B?SStKdUpVM0h4bGZJdnpObTlyR0l2SXBYb01LMm1zNG5OOWYxSHlwbGErZE5F?= =?utf-8?B?Q0NZWVhGc0dlQ2xQTDdUNGVSTDJ5NEZMbkFkV3cybHlDMFN3RXdWeVhzWnRS?= =?utf-8?B?OFM0UXZSVDhxcldMdFFvN2NqeEFhclcwOXpBcmZnVFArQWN3YVJCcitwaFFM?= =?utf-8?B?UlFQVUtRSGNxdjFKODBjQ1BidExqaFFjUFVWMlJRVEhneWZocG9GWitoeXgx?= =?utf-8?B?NEtHSmVzZUNZR2hESHZuTWN6dTdLWGdNVDEwMWdHYlRYMTIrWC9icjFnV1NJ?= =?utf-8?B?RWFEMkZ5VTFMV3J1eDI5R2daRGlqNGdqU2RyZkhRZkg4V3RSYlM4OEoyeDlN?= =?utf-8?B?UGljK1U5dG1uOGdPMXpQUGxqa05lOUZUYmpMWkhFT0djR3VWQWxFLzI5bGg3?= =?utf-8?B?YWZNdU5VWjE4N1FyQTV4cndDc1I5cGh3ZVpTd1BkczUvNDhvSW1MNXd4MVFX?= =?utf-8?B?YUt2ZnBLRXk3UG9od2xRZUNzWFNYbWpYRkZ6UlhGbFdQcnR6S2szNzJTLzE0?= =?utf-8?B?cXlVT05yYndxNVJwdzcvRm5zWFFuejkwS3ZkdFhhWTB1ak5aRkR0WmhiKzFj?= =?utf-8?B?Sy9sTi84ZXRjQkpzbUh1Wk9yS3dQeTNoeUF0ZG5WWlR1YzF5WFpSRW5JK200?= =?utf-8?B?WDB4RC85enVYTGlUNWs5VzlIOWQySGw1NTFQNmloZWhjNUg2Q1plZHpuTkZr?= =?utf-8?B?cTZ1RStUZmVXWkNNQzNESFBKSWcyNStqemdGd2JOelRmQ2tHNjZnRGNmc1Bn?= =?utf-8?B?NDhsS0hhcmt0TnlBTXBUQmttYitvVmkwWUpBR3l0RkdaRnp4bnBBVTBaQmNP?= =?utf-8?B?WXlvc01kTHhEbWh4djk2MmJZQjllV0ZtUGRZRmlSUU9lVFpYMkdOZDlqOWE2?= =?utf-8?B?bzV2VWx1S212YllVU0wyc1lEWnczSEY1NnFJSEhha3RhVXg1Z0NLbFRGejVK?= =?utf-8?B?YXJ6MmRLOEtpeUpqZnJ5b2IzMG1halhYRW9FcUlLSmZidmNEclpzK1I3eTJW?= =?utf-8?B?dDQrM1RleWM5VmFrcXdjSGRLL1NnaHlyL3ExaXRhMW92UWpOSE01TUZTY3ZR?= =?utf-8?B?ZmQrR0pkWVIwRkdaSlpEOGlRcTR3MnlqeEwwTjR5SHRLRDVsOUhEMnZ1QWNM?= =?utf-8?B?YzFYd0JRUGlhOXJyTDdnSG9JRjRLUlJyQk1UZGxVajBxcFFCVlF2bHhaK0hh?= =?utf-8?B?RWVhTTJaNWRJeUVWZGZSczhjSG8zdE9vOUp2TDYxT0EvSnJCUnBlekMwQkxi?= =?utf-8?B?YXh0RU9hSmpDTkZ6YWxReUlBYis3eDdRTGdMTzd2T05vbHJWRk5yalNSR0xN?= =?utf-8?B?VWZwMHptQ25iTWhoN1VNWC9xQ0JaeGE0SzNjTVNiQTZpZHo3aW94OWpDWkNu?= =?utf-8?B?QzJTK3lTQ1ZoVmRqWHhzbi9KZXc4WEc4a3hOOFlxdEFoemZIOVhBZnMyMHdS?= =?utf-8?B?cExPQ0JLS1M5aUxCc1Q1NnU0bTVZa09sOTRaSmU1YStPY0R0UWhuNHhuTzRz?= =?utf-8?B?SHFKSnZJUksxU3k2K0pyTzRYYlk4VHRHRVBmd043NUFodlBBSkxFbEZFSmdS?= =?utf-8?B?M2lrQzFOTGtYc1pGWnQrRnhlcDQ0aDJtVnI1YkgrdTdxNEZLUm9LcFUzUU1Y?= =?utf-8?B?MEZYRnNocUI4Y2VNU3hhWDFMVTZEZEt3TXEyNlpUSXlxL3BTTmJwdDE1N0hZ?= =?utf-8?B?YzhveXV0M3A0RXZROU1OZEZlV0dFZ1p1VVZnRG5PM2JtMHBBQWIzZG1CMVJT?= =?utf-8?B?eDA1TDFwSFZYZ0xPb0QwaWI4NFdqU3I0TXBEWXBldGpTWkRTdEJrQWZZVU1n?= =?utf-8?Q?sSVEPIzVpMCFJSniWK/7WKgNC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c428b28-9ff7-4a23-c92f-08da6952f536 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:50:25.0308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6hnKyjNcR1VLp0wQmGTgu8FGND0tnmuUSl7hODWw/e+X7oMRPut5vgAETiTXlzbvwD6mMgifkJc52b/08bVnUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4864 I did notice this anomaly in the context of IOMMU side work. 1: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part I) 2: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part II) 3: shadow: slightly consolidate sh_unshadow_for_p2m_change() (part III) 4: P2M: allow 2M superpage use for shadowed guests Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:50:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:50:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370381.602113 (Exim 4.92) (envelope-from ) id 1oDh4J-0006qm-IK; Tue, 19 Jul 2022 06:50:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370381.602113; Tue, 19 Jul 2022 06:50:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh4J-0006qf-EB; Tue, 19 Jul 2022 06:50:55 +0000 Received: by outflank-mailman (input) for mailman id 370381; Tue, 19 Jul 2022 06:50:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh4I-0006jP-Jq for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:50:54 +0000 Received: from mail-40134.protonmail.ch (mail-40134.protonmail.ch [185.70.40.134]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 22062b02-072f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:50:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 22062b02-072f-11ed-924f-1f966e50362f Date: Tue, 19 Jul 2022 06:50:49 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658213452; x=1658472652; bh=1mYqLP9gcfIBDY/3boXfROv+9pF8JFO0SeAOG3evp5c=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=JTd4nxKmZ3Qe7WDImDKjMa3NBn9eSAxuDi530YohJNSvyF72cYYYNuzNPrVi3x48/ OUfsC0U0sj5NhpCy6aUk3v4v41+amlEo0pJovFkxEzlgOJwOeZZlbFSOWX6U/NrsMn VA9KkfPH7+7KG1QFo1l+hRPgpcI7FVyadS2gxHjixsITMkW+EQw8K1ij4royZsC3Jj 6D03gYOxqt8OB0sT+IHccVQStto0SrQkOzMaT+T9HxfYcuHswP4oN6qD/t9JozeYK1 36GYhCGhcQiElk1qWAWDrYqifpGe9nzrk0e2rtK0RdapJBKzMZD3jgSKX85wrptK/Q +WUXwQ33RhalA== To: jbeulich@suse.com From: Dylanger Daly Cc: xen-devel@lists.xenproject.org Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> References: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_bUDd7NXX4Knct0MgU8RjjeKX8WhXFarvouZOJcFXUQ" This is a multi-part message in MIME format. --b1_bUDd7NXX4Knct0MgU8RjjeKX8WhXFarvouZOJcFXUQ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 RG9tMCAoYmVpbmcgYSBWTSBpdHNlbGYpIGJvb3RzIGp1c3QgcGVyZmVjdGx5LCBpdCdzIGFueSBv dGhlciBkb21VIHRoYXQgdHJpZ2dlcnMgdGhlIGlzc3VlLCBJJ20gaG9waW5nIEkgY2FuIHNvbWVo b3cgaG9vayB1cCBnZGIgb3Igc29tZXRoaW5nIHRvIFhlbiBzb21laG93CgotLS0tLS0tLSBPcmln aW5hbCBNZXNzYWdlIC0tLS0tLS0tCk9uIEp1bCAxOSwgMjAyMiwgNDoyOSBQTSwgSmFuIEJldWxp Y2ggd3JvdGU6Cgo+IE9uIDE5LjA3LjIwMjIgMDE6MDQsIER5bGFuZ2VyIERhbHkgd3JvdGU6ID4g SSdtIGhhdmluZyBpc3N1ZXMgZ2V0dGluZyBRdWJlc09TIHJ1bm5pbmcgb24gbXkgTGVub3ZvIFlv Z2EgU2xpbSA3IFByb1ggKEFNRCBSeXplbiA2ODAwSFMpID4gPiBGaXJzdGx5IGluIG9yZGVyIHRv IGJvb3QgdGhlIGRldmljZSBhdCBhbGwsIEknbSByZXF1aXJlZCB0byBhZGQgYGRvbTBfbWF4X3Zj cHVzPTEgZG9tMF92Y3B1c19waW5gIHRvIGRvbTAncyBDTURMSU5FLCB0aGlzIGlzIHNpbWlsYXIg dG8gd2hhdCBJIGhhZCB0byBkbyBwcmV2aW91c2x5IC0gaHR0cHM6Ly94ZW4ubWFya21haWwub3Jn L3NlYXJjaC8/cT1SeXplbiNxdWVyeTpSeXplbitwYWdlOjErbWlkOmYzaGVsNHlqMjVxaWxhYnYr c3RhdGU6cmVzdWx0cyB3aXRoIHRoZSBSeXplbiA0MDAwIHNlcmllcywgaG93ZXZlciB3aXRob3V0 IHRoZXNlIG9wdGlvbnMgYWRkZWQgZG9tMCBuZXZlciBmdWxseSBib290cyBpbnRvIEZlZG9yYS4g PiA+IFRoZSBvdGhlciBpbnRlcmVzdGluZyBpc3N1ZSBJJ20gaGF2aW5nIGlzIHVwb24gYm9vdGlu ZyBhbnkgVk0sIGp1c3QgYSBub3JtYWwgc2ltcGxlIFZNIHdpdGhvdXQgYW55IFBDSSBkZXZpY2Vz IGF0dGFjaGVkLCBpdCdsbCBzdWNjZXNzZnVsbHkgc3RhcnQsIGFib3V0IDEgc2Vjb25kIHdpbGwg cGFzcyB0aGVuIHRoZSBlbnRpcmUgZGV2aWNlIHdpbGwgaGFuZyBhbmQgcmVzZXQsIGl0J3Mgdmly dHVhbGx5IGltcG9zc2libGUgdG8gZ2V0IGFueSBsb2dzIGF0IGFsbCBvdXQgb2YgdGhlIGRldmlj ZSB3aGVuIGl0J3MgaW4gdGhpcyBzdGF0ZS4gPiA+IEZZSTogUXViZXNPUyB1c2VzIFhlbiA0LjE0 IEkgZ3Vlc3MgeW91IHVuZGVyc3RhbmQgdGhhdCB3aXRoIG5vIGxvZ3Mgb3IgYW55dGhpbmcgZWxz ZSB0ZWNobmljYWwgdGhlcmUncyB2ZXJ5IGxpdHRsZSBjaGFuY2UgYW55b25lIGlzIGdvaW5nIHRv IGJlIGFibGUgdG8gZG8gYW55dGhpbmcgYWJvdXQgdGhpcywgd2l0aG91dCBoYXZpbmcgYWNjZXNz IHRvIGFuIGFmZmVjdGVkIHN5c3RlbT8gSmFu --b1_bUDd7NXX4Knct0MgU8RjjeKX8WhXFarvouZOJcFXUQ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 RG9tMCAoYmVpbmcgYSBWTSBpdHNlbGYpIGJvb3RzIGp1c3QgcGVyZmVjdGx5LCBpdCYjMzk7cyBh bnkgb3RoZXIgZG9tVSB0aGF0IHRyaWdnZXJzIHRoZSBpc3N1ZSwgSSYjMzk7bSBob3BpbmcgSSBj YW4gc29tZWhvdyBob29rIHVwIGdkYiBvciBzb21ldGhpbmcgdG8gWGVuIHNvbWVob3c8YnI+PGJy Pjxicj48YnI+LS0tLS0tLS0gT3JpZ2luYWwgTWVzc2FnZSAtLS0tLS0tLTxicj5PbiBKdWwgMTks IDIwMjIsIDQ6MjkgUE0sIEphbiBCZXVsaWNoIDwgamJldWxpY2hAc3VzZS5jb20+IHdyb3RlOjxi bG9ja3F1b3RlIGNsYXNzPSJwcm90b25tYWlsX3F1b3RlIj48YnI+T24gMTkuMDcuMjAyMiAwMTow NCwgRHlsYW5nZXIgRGFseSB3cm90ZToNCj4gSSdtIGhhdmluZyBpc3N1ZXMgZ2V0dGluZyBRdWJl c09TIHJ1bm5pbmcgb24gbXkgTGVub3ZvIFlvZ2EgU2xpbSA3IFByb1ggKEFNRCBSeXplbiA2ODAw SFMpDQo+DQo+IEZpcnN0bHkgaW4gb3JkZXIgdG8gYm9vdCB0aGUgZGV2aWNlIGF0IGFsbCwgSSdt IHJlcXVpcmVkIHRvIGFkZCBgZG9tMF9tYXhfdmNwdXM9MSBkb20wX3ZjcHVzX3BpbmAgdG8gZG9t MCdzIENNRExJTkUsIHRoaXMgaXMgc2ltaWxhciB0byB3aGF0IEkgaGFkIHRvIGRvIHByZXZpb3Vz bHkgLSBodHRwczovL3hlbi5tYXJrbWFpbC5vcmcvc2VhcmNoLz9xPVJ5emVuI3F1ZXJ5OlJ5emVu K3BhZ2U6MSttaWQ6ZjNoZWw0eWoyNXFpbGFiditzdGF0ZTpyZXN1bHRzIHdpdGggdGhlIFJ5emVu IDQwMDAgc2VyaWVzLCBob3dldmVyIHdpdGhvdXQgdGhlc2Ugb3B0aW9ucyBhZGRlZCBkb20wIG5l dmVyIGZ1bGx5IGJvb3RzIGludG8gRmVkb3JhLg0KPg0KPiBUaGUgb3RoZXIgaW50ZXJlc3Rpbmcg aXNzdWUgSSdtIGhhdmluZyBpcyB1cG9uIGJvb3RpbmcgYW55IFZNLCBqdXN0IGEgbm9ybWFsIHNp bXBsZSBWTSB3aXRob3V0IGFueSBQQ0kgZGV2aWNlcyBhdHRhY2hlZCwgaXQnbGwgc3VjY2Vzc2Z1 bGx5IHN0YXJ0LCBhYm91dCAxIHNlY29uZCB3aWxsIHBhc3MgdGhlbiB0aGUgZW50aXJlIGRldmlj ZSB3aWxsIGhhbmcgYW5kIHJlc2V0LCBpdCdzIHZpcnR1YWxseSBpbXBvc3NpYmxlIHRvIGdldCBh bnkgbG9ncyBhdCBhbGwgb3V0IG9mIHRoZSBkZXZpY2Ugd2hlbiBpdCdzIGluIHRoaXMgc3RhdGUu DQo+DQo+IEZZSTogUXViZXNPUyB1c2VzIFhlbiA0LjE0DQoNCkkgZ3Vlc3MgeW91IHVuZGVyc3Rh bmQgdGhhdCB3aXRoIG5vIGxvZ3Mgb3IgYW55dGhpbmcgZWxzZSB0ZWNobmljYWwNCnRoZXJlJ3Mg dmVyeSBsaXR0bGUgY2hhbmNlIGFueW9uZSBpcyBnb2luZyB0byBiZSBhYmxlIHRvIGRvIGFueXRo aW5nDQphYm91dCB0aGlzLCB3aXRob3V0IGhhdmluZyBhY2Nlc3MgdG8gYW4gYWZmZWN0ZWQgc3lz dGVtPw0KDQpKYW4NCjwvZGl2Pg== --b1_bUDd7NXX4Knct0MgU8RjjeKX8WhXFarvouZOJcFXUQ-- From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:51:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:51:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370388.602124 (Exim 4.92) (envelope-from ) id 1oDh4s-0007Pu-To; Tue, 19 Jul 2022 06:51:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370388.602124; Tue, 19 Jul 2022 06:51:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh4s-0007Pn-R7; Tue, 19 Jul 2022 06:51:30 +0000 Received: by outflank-mailman (input) for mailman id 370388; Tue, 19 Jul 2022 06:51:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh4r-0007PT-6F for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:51:29 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60040.outbound.protection.outlook.com [40.107.6.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36764033-072f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:51:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4864.eurprd04.prod.outlook.com (2603:10a6:803:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:51:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:51:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36764033-072f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KbiE3zWVC5WVler8SD89pel9wCvicZ9R1afzRi8659kChHWxmLiiaYpi3rsRei5wW/QBNodj8k6PXqKHMdHYbSBDW7H+GLBpO2XcoGFb26Zv934WYXq8yOpdK8vMLi0qjfmxiJXYwVenQD8S2KFjv5HIDmfUEgb5UBOM6m2Z39m2ZySD152/aGRdnlHTQ/+Uqc4FWiP3bAyxuheuHt+cRdH/HJrEysdMdZCCBXwoGKyH5JyCglrFaKb/b6Yuy1DSBuVxUtA7v8VuE2Xd07Ado6B4gz+/oF/8P3ZDII5NmpHWoSIvq8H7CNumRGL5JK3yfgXVa5/SNia8K2YPGPx9Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=paHBxFxNPQQaCR96HVsNx65Tk5J0VvsjBSY4OoT4Sio=; b=Hoh3lq6XiDGPbxbdRPnX4ZUDdj9Bw3XDgWqBsQsBiLHGOXvMMRm+1hRGxU+fXVE11h9gMqFLTXEJdHcXvO+GJ8D/t1nL2Zf3swuS8/yl1NA43RxfDZBDYC6hb98rihtD1dGCLN38rB26jqwp1p6iT9IB2eqL/e/7T+L5ODoIf+YCTxVljja1hgTsSFMv4mr2VI8FA+on2Qs/EfLwq0HzYgdNOuH77j/I65SM3j9+xpgAW/mmPvcSyUmiifS3MaTIpRPO9T6WqRqzCI3v3Cz931Dox/KHvXiGE4+Vie/mDy1CLOj0BtgRFwlUvwpHlC+03/R9m/BpuEeYxyCr6WlUag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=paHBxFxNPQQaCR96HVsNx65Tk5J0VvsjBSY4OoT4Sio=; b=1XGyKKJEsBeixiiMEm00aG6kStOlKbmVNdIyRbbTiN6ZfWvygDIfv+nZWP/1TVyt+YnOBXyP1IKgSz2Hq4GKwdTK/ORRu/fwdLOvbDzO9VCDIAoah9bWDN/cB9fHaHOckko3v4CCzHQeIiBKLPLAkn/4szkQ+F+NGjYnXpxcL//fFZJuDwQbYSLAdocZ2pGXs5/Z9TbC7OC8pGE4+Ks5fM4QmsFVs+WTrzNyZDg8jTnon3AXeIedHrjCkKe4Ls/FvFKIB+HwhocMixwzlee8OgnIk9OLtVq9dY9sLdLGZzDDeGyLezpiZCfMBgaPzF6oiwnI2GV0FbAtZacJxltw3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 08:51:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v2 1/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part I) Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Tim Deegan References: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> In-Reply-To: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87e014f8-376a-4d6a-631d-08da695319de X-MS-TrafficTypeDiagnostic: VI1PR04MB4864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mVHgulCKwys5y/cLt2vGebB7vgdTFuGxVRrMhC0FIBsC0ndpq1z4GZ1hqw8RHTEbgxsbMToSK86AkRNiERLLGnCy/m8FfCTWx1aLgKjQ8nonJub/SNI/2/qQF9EcL9whovZuPypyR/JgHx9+3/KAppuHwTncD4JbwchRpNUYTy9GOJLMllrUyw4Dlw17B3lpegYdukwDUH4d8x9+P/cdrVLuOCGGSQZzx/FfXTAnMacATM8vYwwO3TEig9Y/bw+UdfIY1bVkycxjoAhKUzVXF786fnFATYqnq9VhZtfKAxJt3GRDUmBn6Xm0/dj/bhWEXqADVxLj1xsr4RDlevc38PVK/E0f0VTI2W18p+kp3Xra8ttmyt67zLV+3/JYle/AG9nqRAR0oOZ3AhHxhtgprQaz+glnxVJB//JreGOh5Vj3Pt4c7KiDzRZ77HJ/uj0fmpVuRQGFOOqjW8SX/LkzgKAZQVPhPRGpHi48X/1U0nuhrBJVxSR/pGZmzLQS2qwSgLby2mkpXlbRCkNwXrlgaKRU6CzHJ3cmXKS2TOjxQi2FcreiNv+sockyC55xzUCWljrvb9s6mu45t66VAz5InC5jTt5o99Tf+L8uGg2bsHgLp66sCuceDjtV2nvuPODi3ZdmMLrIeDrEmTHesxB3Y6S/r9iyw9qTFXBmTtYyumbWw/378ExHLBFHXMQwcbNwjvHTbqxBZivWIcYBRrOBQyXpdpZYANYKwWeQLMT3PLtYyInVunD5Wa6CDCVFfJjA9cR+EpVTJwYgznT7Q6dH6zPMrr0V0Og++W3gHBTidvpKAqANYb3rfupL2HenqG72YxogLzks4mxFTVpyuEPcem+oQ2LQXlqwAxriwaepu8k= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(136003)(396003)(376002)(346002)(316002)(6486002)(478600001)(36756003)(31686004)(41300700001)(6506007)(2616005)(8676002)(6916009)(6512007)(186003)(5660300002)(8936002)(4326008)(4744005)(66946007)(66556008)(66476007)(26005)(38100700002)(2906002)(86362001)(31696002)(54906003)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEYvSDA0S2REUEFuOXZaVEdLMSt3a3JDN05MQ2VBRVgrRkJpUzlHRGpUMUFs?= =?utf-8?B?QjFjQm0vWWh0UWRzOWJOK3hhdFZvQ1hSU2EwRzNzV3A1NTIzNlQ3eVJ1K0ZB?= =?utf-8?B?bWtJUk5uU2N2dXE5eXVCNnhoalZacVQzZ0tCVWFpTGp5RlljUk9UdFJUQUE0?= =?utf-8?B?akQ5dGFTYkVobm9td2FISUUvUGowd01tNGwvSDZIeGF2dy9jM2l1bmRxMDJH?= =?utf-8?B?TUR6VDdPTEI2SFY0aUpCZ2RDdWxTNTlXS2I4TWJ3LzZGZmFDeHdVNWJQUGNE?= =?utf-8?B?aXZxYVlFVWxJSmtUY1hkYlVYY3prOUdKM0ozeEY3OHJCYWRhK3J4MmF2cXg0?= =?utf-8?B?MGs2RktoWkpwUFQydjAwMXJBSVFsNy9QcWtmaVRVc2xJV0NySWFoSS9qZmE2?= =?utf-8?B?Q3UzQmx5NWpDVnFyMjNDcys5bkRMc1E2NElrLzQ4U2t0N01LdDFrcWVHZVJq?= =?utf-8?B?YVBaNjJwdUdXcW9nWUVpZ215MGUrWGFCd29HVHB6ZUhweUloZjFOOHlUSkcz?= =?utf-8?B?RlkwYjFJY1JTNTZ5SHl2YTd1b0NtbnRLdXV5alhjTGNHalJRWEExcktJSDFY?= =?utf-8?B?NUF2amFaZ1lhZ01maWpPazJKUElXdUFzMkRnOUcrNlVzZ3V0THpjOVVPdWFN?= =?utf-8?B?c1luMXpYdTJNL3ZjVlgxdW5kMEx0WDkzZ09SYVd6cU9QdXJYc3dJTVFJbGha?= =?utf-8?B?QVhqQ3BDMzFoOHNCTE9mYVAzajU1bWdDbnhrVWtpMFltNzlOYStZNEc0dVlh?= =?utf-8?B?Vk9ZZHcvRndJcVRkdUJtN2ZyUVQvTVY5WUcwWDBPaWo5Y01XNWVjUnkyMUxE?= =?utf-8?B?bnYwTWpnOTA2YWhZQmZyRE51NEpZbVJMbGxVQUR5cTB2dlorbmRZdHh5NjBG?= =?utf-8?B?OHhRLzNuYzJEcVM4WTdrNHgrTGRRelIwNmxMQndBNmE5QmZjNUVtZ2xGdHVN?= =?utf-8?B?MlRaWUhrK2s0bUtybVlVTThOZXNNdnhkNzFZT1NlUHREbWk3MUNrbUFncGV5?= =?utf-8?B?bXNCZEpzZmZKY2NxRjcySllTT203Ykw0MkdJVExUM2FQRWlBK2FQemp4NTdC?= =?utf-8?B?cjYxb2JLbW9kR3h4K1RtNU1aSStsQVVwTzBFQlpmWWp1MElGWEttSjVIbDY5?= =?utf-8?B?b1hWdGhOR0xUNU1VQ0FndU9PUjNyZVExYlJ2MUhwaU9MTUJUYXFnSU9MaVNU?= =?utf-8?B?T1dQUmg2QzRLb1FFUFdwOUZLYlRsTmk4d3BXaWZicDdtOUlCQkFBSGd5SUR2?= =?utf-8?B?OHpQMzcrT1l3L3hUT29LOXVjUTgvM1FDZDh1dDI2TzFxMjU0NVZkbWUrTlZI?= =?utf-8?B?VlZuT2lhOWpjai9JNnBWa3kwamZ1ZzlVa0xneHdyKzJyZ08rSzZobWN0KzZK?= =?utf-8?B?OHpFVnJoSFM1ZTFzczB1OVlJYm14aU15cmhrTVB3UjVsU2twdlhoYjZNdm1a?= =?utf-8?B?Z0czOW1PVXF3K2kwd2xST1IxaXNrN1VwZG1EZDJ5NTBQTmszbG9aVnN1SHVB?= =?utf-8?B?MnI0Qk1RMUtlWmE3dE05K292WERCcElLbXpDc0NXcDBmKzJiVERxbE83SWty?= =?utf-8?B?N2pvRGJ5dmpoNjBHYlM2QTZOM09WMzVjUEhnblhmU2NLTGhFK2Y1WHkrcVRD?= =?utf-8?B?NDFSa2FyQS84Tkc5dzdYaVlkbHJYZzlrM09sT2oycXZQWlJ5dDdBcStvWGNV?= =?utf-8?B?d3ptSkphSXVjRHNTekxnZmcreXBhZ0QzL0d0cVdHb2YzMXVJWExlSGNveitt?= =?utf-8?B?cFQzZnhxL3RUNStUb2NaeElWQ1ZrY0RibEZSaXBIK0YvbFdtWXgwU1duNUlJ?= =?utf-8?B?M1ByRmF1TkRNRVdxcW1BOS9JK2xzeFlVWCsvUVpSeUxaeFNFTUtwT3psU3hM?= =?utf-8?B?QTlKNzdLaHpLVGJ1bnd1bzdyUDZtUGdnZXhreFIyV1c3OHZrd1Vqd1haVk5X?= =?utf-8?B?M2g4QmVuNTlFblZOUGd2YklJS09pVzQ1ZVd2L2xNMU9UL2lBZlF1MG5iK296?= =?utf-8?B?NVJJUHZMWkFPTmM1ZHF4SHJrMHQySlpvN2U2T3VDVlcwSldZNS9VS3NaS1pp?= =?utf-8?B?VFdUR05vcGtXTjlKSzFPNDByNEZncGhVOVk1SjJOYnlqQkV6UVp4NHNLdmEy?= =?utf-8?Q?vbMuBQPf0/u4bLl/afNx6BUYy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87e014f8-376a-4d6a-631d-08da695319de X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:51:26.4803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7k6zspi0qjbCukCaEefeeFZ/JIVbXv7Teb2Mmah6Bbq2fg/eRNNOzyulegGstxpIaEFYQjHs+gV+VtvH/LXKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4864 Replace a p2m_is_ram() check in the 2M case by an explicit _PAGE_PRESENT one, to make more obvious that the subsequent l1e_get_mfn() actually retrieves something that really is an MFN. It doesn't really matter whether it's RAM, as the subsequent comparison with the original MFN is going to lead to zapping of everything except the "same MFN again" case. Signed-off-by: Jan Beulich --- v2: Split from previous bigger patch. --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -856,7 +856,7 @@ static void cf_check sh_unshadow_for_p2m for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ ) { if ( !npte || - !p2m_is_ram(p2m_flags_to_type(l1e_get_flags(npte[i]))) || + !(l1e_get_flags(npte[i]) & _PAGE_PRESENT) || !mfn_eq(l1e_get_mfn(npte[i]), omfn) ) { /* This GFN->MFN mapping has gone away */ From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:51:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:51:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370392.602135 (Exim 4.92) (envelope-from ) id 1oDh5E-0007va-53; Tue, 19 Jul 2022 06:51:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370392.602135; Tue, 19 Jul 2022 06:51:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh5E-0007vO-2M; Tue, 19 Jul 2022 06:51:52 +0000 Received: by outflank-mailman (input) for mailman id 370392; Tue, 19 Jul 2022 06:51:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh5C-0007PT-20 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:51:50 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60060.outbound.protection.outlook.com [40.107.6.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 430d8ea7-072f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:51:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4864.eurprd04.prod.outlook.com (2603:10a6:803:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:51:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:51:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 430d8ea7-072f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AKXvUG0OV/UPnNhsehUSZ+3S89HUpoWJSBHAe+DpWBSk7ddS/VemjKezEgIqkf1p4E2RRt8pKXCtMtY3+zlNmBNHcSyoL9Sghz2Sr1u9Ce1UExpuwPX8WDf13DyJMtdj/DOEDewcAAoyJrsQMXSWR9W5bth4aNhy67xjt/WeH9yVXmEhD6+vkqXoiHjxOtYREAOk4iWvj4B8IKdmqvRFbH4bkTQ4w0vaqdsgDiHsFbgAUeoNOW/vmpJ4Rmd5lGj9zYE4iTV9se+j6gxIcTI7HPEYiLYuAE6vl6GwKbXkUt6dCXwZNOmxJEmnJ6g9wzlI0Ht31Ojkk1kOdVx0jzK7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n/85LX8vVEsmVTn+P11FrOvSAKeuh/W8CeK3ApKBU1M=; b=fPr19Iy+ho4ZIo93SFtOEwThfKn/m15xv3LYegp1QIw0myQk/r6UYMAh2Azaq34gmgXnWOjRFLc7V9OBp+twtCp+SQPWYuIP0CBJqr6UgOSJBk7NjU8uZCd7fS86P8u/UGAwSixcnyBwElHfqr8pi4n6lWdNcYv4Dw6oSjHOVsFxXIZHntKQT28YVx1FXyNAIlf4XhqRudzQlPbup3kCywzqBqgB5T+CAW9MCWhh/nWD41q0SDNVEDu0nD33apVl7Aql9/DaRXLndnzdqDaq4+ZdA8RIiUklz6+es/y5tPJjf3FNb7KdnQYiHGLuTub+sp/TrMLzKTd37JXtd32AuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n/85LX8vVEsmVTn+P11FrOvSAKeuh/W8CeK3ApKBU1M=; b=T5R32DcfLrTWi3cXr6J+hYRN5WrWllGMW+QwPsSVxzfoLEjkYx1mHiD+M+VVcHSEiFBOOEEJV78+C6gucdmkJ6VLd/BNn5e+eZ+4J/dHVCRmj1XerZMavw7zq8MW7uWKQyi3DBfqEE9HSILc4JeaUoJf2HYDm4yPernPKlH48JIIMXKwdmo/DKBZgP9Ryl7652POMo/HVr9bAZlDk0gYUmTVZ99Bw/t4QyDXn+1FkybadrXOfMZZBo/m2zPrv6Ge5ctwHDfXtsprNvjEwknZtu4ocUg3hS8DDYXaoELVhpudtOey9D5yiXwKGuAHbtw2Aomd+VgJFSbZVoRJBc6YWg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 08:51:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v2 2/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part II) Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Tim Deegan References: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> In-Reply-To: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0166.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3ec5c356-88b5-4d61-efc3-08da69532645 X-MS-TrafficTypeDiagnostic: VI1PR04MB4864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FYzEQLiY7H9SfWs7udh7/lOXUB6dkmWnNuBjgG7cTACk2DdK/9UHfnF/CH1fvqWVdEpacclTmWJ53+gztzpjiUBWYcjHmA00aVWIn0VeFzS2t0/GrOVWW61Q0JT3Avc3AbOAsPV3rdX4HegOByON+PW/HYD3gvKcdOLKq88YFUBmyzsheyhzi0s4A1X1rFlCn7kcBE5gs960HBdxCDYXdd1FC3h6OiNjddlPgcAcBEzzrszAxJgrrovv9g5EmFkCqvOoJQdl7MNSAnpNBFsr2U+81jVUr2IrboWbS0BhxVpzbFQQ9HkYvclgBc0M68dOle3h63KI7/iDs8OKtTonDemoRdegnk6vY7tzlkg13P5a3WBWmecAGg5uYiGXc/HSLwA5Kqd152atiAqWKSoMeN01t45GgYUPedbpc5xw6BOzSxNhjwJSXPoyMzJ4OpVEi1kSCchd1Lj189pJur9P+T2jFEoa7uhrVyjyGTvspjHY6NagPfRmK/NfUFSj1PZBhEUIt4AMO/jzE+lyCFisHLz9zgSQT71ygN1bmXT/Of8HJZwBnOidVOXmLCYX4hwnii4J759IMeMRf4doL6LElS8fJoCQK7QeSxcAPbGjcvmc3ZUmgC+6nNiTzm8+appehlI3J9dOD25vPrqg4nELyKayn6nWB/ZWbjEQIKntgZ+078ygUAJOXBdLwTBnm4vj02gRLv/VdBWZsj4A2b74rZFbLYsusU5c72pox1OPKlg7w0N6uWH4AKlELEiNCucKoxsuB6nAkKPWxtyMEQX1w1/65a8WU8a6Ag3wyRUfAV0fLWbLV6JT7xSWiIJrZuukzZpE7NnMwNSXhCQun4vUYzoIwXeXzxCbjXGV6kDjeMg= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(136003)(396003)(376002)(346002)(83380400001)(316002)(6486002)(478600001)(36756003)(31686004)(41300700001)(6506007)(2616005)(8676002)(6916009)(6512007)(186003)(5660300002)(8936002)(4326008)(66946007)(66556008)(66476007)(26005)(38100700002)(2906002)(86362001)(31696002)(54906003)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTd1UndjWHhzL0U1TkN2djI5bmh1S3F3dHg0OHN0YW8wZlFNRTNmRmF0dE9L?= =?utf-8?B?c3c0cmxFSUdBaEJwNmJnY0dQSndyRmxnTGczWEs1OUhCY1dXdFRxRE1ZK2Nx?= =?utf-8?B?ZUEySVJCaXBnejB4Z2FJdS9kZTdZSGNMNU1pcVBtclc5M05WTzN3bGUwc3RW?= =?utf-8?B?bllYU1ErTlM1SDdaUnNaN2piYytXMDBWcVUvam5la2Q3cmtaaXhSOGFxTTFi?= =?utf-8?B?TjB2M251aUtoajFpMVBnWTZGeFpvOUxDV1RBUkUyQ0ZpRTVub0ZUK3lVWG5G?= =?utf-8?B?Mm1xQmJEeU11REVpUkFGajdoMzU5N3dTdUZTd1dYK1dEYnFNb1NEYyt1bDJw?= =?utf-8?B?TUxtb1RGSXRCSzJta2lJdzFMU3Rxa2FjMldNSXI5MGowUnZZWmtYSng2UG5y?= =?utf-8?B?OXBWZS91NGFQS1QrK3Z6cnVoODQ2SWhvRGs5ZXp6M2hnbGlQUmZsR1ZvRCtU?= =?utf-8?B?eDBNR0ZWTFo5dVA4QUdqcFkvb3pHRmZReTNjK3llaWhhdXlYV1lQUnQ1ZzVp?= =?utf-8?B?eTAwTWdZL3o1dHVQckFLNDFGRHVZQVhRa3BaK2g4KzU4R0hRRDErQzNEdXpt?= =?utf-8?B?YU1yUEtPQ04yRFBySStlUkhNckFRZ1VqVVFsUlRIUXRWTkhYUU9TcTFxbTJ4?= =?utf-8?B?TGFLdm11NUpsdkxXVFd1SHIrRERWcGVWdW9ubTkyNHpBa2RSY2IzcmFqUnRW?= =?utf-8?B?Q2lROWxJT0o0d0ZScThmeWIzQmVoaXJ0eUo2a2lHM051Z1RCa3pvcmlMN0ps?= =?utf-8?B?QXpRaUZOWTJIdkROQ05xTnN4QVBscEwyakx4bElnMExVV2RwOUI0VGJyTkF6?= =?utf-8?B?bG9nWEJWUWt6bDd3Qm03NVI1R1dOd3Y3ZTc1cnJNWnUxTURtaFJtMkhJbnVm?= =?utf-8?B?Z1lwUW9qYndRWnRRYTdwZEFZa2pMUkh3djI5SlMrTzFxZjZlNGJpSkhqS2RW?= =?utf-8?B?SVpHOGVKbEw4VDkvN0Z2K2ptVHlGYUNGZjY5cUpHMmxkM3R3MWx1QmRmU2V0?= =?utf-8?B?VDRiK2pMNldScDlsSWorWnlzUXY4dVpQK2Jpb3E2aCtoK21LNFdEbUJ2bzcr?= =?utf-8?B?ODh0S0JrM3p0aEFNYlRPTXMzZXZ4TjZVVlQxRzE4dWZMbGEyZHVRM0hCQTFN?= =?utf-8?B?YlhxYWc4NmEwb2VsdWNpcHNDMVczYmRDZk1tU3d6eFl4V0R3Qmw2OGZYZW9B?= =?utf-8?B?R0VaWG9Xc2UwdTBHb2ttVjFRc25oN1dtZ2ZrN1VKb1NWUGp1a0FtcWtnVGNT?= =?utf-8?B?K0hkNnYvQlg5YnVwTTFBYmdtamNxcHBSMlkvWDAydjRRRkQrRzZpQWxRN0Zh?= =?utf-8?B?ZndHQ0U0aEZtc2ErSU5reCs3cStpaVVjYWJkZ0lpcGtPdjFNOS9xZndqTXhL?= =?utf-8?B?bXF3K3cvc1hLdXVWZFZUMTJyZExNblgyeTZteTZBTTJmSVBiM2FUeFQ0RzVR?= =?utf-8?B?bWJMd0tseDZJWCtncHdWa0lLdU5CbHVqakZ3cDJJSXRvTHlTTjdqbGdma0cr?= =?utf-8?B?RFA5WHo1VmpDNW5qWG04L0ZEa1RsZUV1RmFZSHZPbGpJczhoSkZFd3dSU1kw?= =?utf-8?B?bzZTQXl5c3R0czlkN2oxenVYRXM0d21wR2hVYXdnUStmUXhkeGZDdjd1Qms4?= =?utf-8?B?QXJYM2U3NjUvMWMwaEdJZXVmZTU3ZTgzSDNMV01BbVAzejlMaU1kN0gvTHo3?= =?utf-8?B?dSs2a1drbVNuOG9MSlBZTEJTcjg1MXdHR0ZWZFVIS2x2VWhvMDVWREJDN1NU?= =?utf-8?B?U0tpby9SS1FXVzhUQ1FNVlc5VDBiOGlLSSsxTnhOZnh4S2xUVE5EaGl6b2ZE?= =?utf-8?B?N3EzSnRyRTlLcmdpU21MTEg3UGUrZkZiNTFZeEozWGs2VTR5TjZSVlRqNlZW?= =?utf-8?B?V2tGbVd4RVBaMVpvNHVyWDRUUmRvQ0FDeHVIdnVxSXBhTTEyY3JVSVB4YzRL?= =?utf-8?B?cHBveE95Z2lkTUdUZGUveFRnSkpFM2dZR2tlR1BVYWpxd2NWRUZVZFBxMHA1?= =?utf-8?B?c0RaMjNUdUw5ci8rNHQyYUpUdkJ3eTkvMk5Gd0NSRnZCT2JvZXZFdHdIMU5N?= =?utf-8?B?NktFMjVZN1pHMmhqMmVZSW9VRGpPWlFySXBBRFEySzBFcm1FakRTeTVnakRK?= =?utf-8?Q?D5nuBQ3eSJ4vQLlR7yT9x8NQ7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3ec5c356-88b5-4d61-efc3-08da69532645 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:51:47.2759 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ru1h3ajhoveGDcLbf2T0/egZRjZ3z6MI2NEz9nf5UV8q5u3JYz7898SFCrkQdJSZ5jv8Nx1MzOkwaBId0bJTng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4864 Pull common checks out of the switch(). This includes extending a _PAGE_PRESENT check to L1 as well, which presumably was deemed redundant with p2m_is_valid() || p2m_is_grant(), but I think we are better off being explicit in all cases. Note that for L2 (or higher) the grant check isn't strictly necessary, as grants are only ever single pages. Leave a respective assertion. For L1 replace the moved out condition with an MFN comparison: There's no need for any update or flushing when the two match. Signed-off-by: Jan Beulich --- v2: Split from previous bigger patch. Add grant related assertion for L2. --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -798,7 +798,7 @@ static void cf_check sh_unshadow_for_p2m struct domain *d, unsigned long gfn, l1_pgentry_t old, l1_pgentry_t new, unsigned int level) { - mfn_t omfn = l1e_get_mfn(old); + mfn_t omfn = l1e_get_mfn(old), nmfn; unsigned int oflags = l1e_get_flags(old); p2m_type_t p2mt = p2m_flags_to_type(oflags); bool flush = false; @@ -810,19 +810,30 @@ static void cf_check sh_unshadow_for_p2m if ( unlikely(!d->arch.paging.shadow.total_pages) ) return; + /* Only previously present / valid entries need processing. */ + if ( !(oflags & _PAGE_PRESENT) || + (!p2m_is_valid(p2mt) && !p2m_is_grant(p2mt)) || + !mfn_valid(omfn) ) + return; + + nmfn = l1e_get_flags(new) & _PAGE_PRESENT ? l1e_get_mfn(new) : INVALID_MFN; + switch ( level ) { default: /* * The following assertion is to make sure we don't step on 1GB host - * page support of HVM guest. + * page support of HVM guest. Plus we rely on ->set_entry() to never + * be called with orders above PAGE_ORDER_2M, not even to install + * non-present entries (which in principle ought to be fine even + * without respective large page support). */ - ASSERT(!((oflags & _PAGE_PRESENT) && (oflags & _PAGE_PSE))); + ASSERT(!(oflags & _PAGE_PSE)); break; /* If we're removing an MFN from the p2m, remove it from the shadows too */ case 1: - if ( (p2m_is_valid(p2mt) || p2m_is_grant(p2mt)) && mfn_valid(omfn) ) + if ( !mfn_eq(nmfn, omfn) ) { sh_remove_all_shadows_and_parents(d, omfn); if ( sh_remove_all_mappings(d, omfn, _gfn(gfn)) ) @@ -836,13 +847,13 @@ static void cf_check sh_unshadow_for_p2m * scheme, that's OK, but otherwise they must be unshadowed. */ case 2: - if ( !(oflags & _PAGE_PRESENT) || !(oflags & _PAGE_PSE) ) + if ( !(oflags & _PAGE_PSE) ) break; - if ( p2m_is_valid(p2mt) && mfn_valid(omfn) ) + ASSERT(!p2m_is_grant(p2mt)); + { unsigned int i; - mfn_t nmfn = l1e_get_mfn(new); l1_pgentry_t *npte = NULL; /* If we're replacing a superpage with a normal L1 page, map it */ From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:52:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:52:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370395.602146 (Exim 4.92) (envelope-from ) id 1oDh5Y-0008Qu-GA; Tue, 19 Jul 2022 06:52:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370395.602146; Tue, 19 Jul 2022 06:52:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh5Y-0008Qn-Bo; Tue, 19 Jul 2022 06:52:12 +0000 Received: by outflank-mailman (input) for mailman id 370395; Tue, 19 Jul 2022 06:52:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh5X-0008Ov-0X for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:52:11 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f7a49cd-072f-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:52:10 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4864.eurprd04.prod.outlook.com (2603:10a6:803:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:52:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:52:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f7a49cd-072f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LDe5K/R3ZfIqyr2oCPK9TWvBA+EP3cLt23cytxrAUlvSm5g5T6tZ72QzluKiBiKm1Xm/1A9CYjVN651Jq/QC1Sa5i6jnuVIzApEb5c0Y4APwVsGPFInLnxcNJ/KoCtyP+9JyYFeR71+LuF1Y6as/Wzdqwxf+4UpP/Oj+rT51OYvOJWsqJ6FmQ0Lqa7ql4KB9ww6Nu32UOImgL8QgINJGVFABxeJ6+j8LYyVtVSMQgcOT7M+H0BWWBms6yINB02q6eQddjZUEZwHGvcwjmX0W2uar2gbwW+lb68/myzNxUE9xlBPgX51miSTGQv9+pKCK4A3JubXNzRIJI5yXQdghnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MrLpz4xOfSP6s3F5vbYICU8lK4kwS1kPHKk6aMNfEXs=; b=l9pRrY8ivRG0VOWy2y5d8v7+nUGo/VYvm+GiCkAPrvf18vkD0LyR8d/Vr5MvXLjh0cz5oPlQIIaMDNKgYqWWZtUG/cPoqvtqlEQSv3JzCL6mw1PzKArlvaIf3olCMLrMvFiBTBldtbBWXQuInP10AuFFCy+om7OkNsZBGWab9wUOm0/ziOq1N2sXvs5cB5qe0hCRyQkot5ErJWt7UcPYmz7rZeAShw+WfaSfgHybNLcKO/PMSZB7OQTo7Rh2ibIOhQRmqESvVpZVPrCZ/qE5hy9BCN+5LeK3uVdoJls0hIQFSYXh9AXfBupm287UePAVgvMP9+6P1tO599LEDN/PGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MrLpz4xOfSP6s3F5vbYICU8lK4kwS1kPHKk6aMNfEXs=; b=hOTkYRA6eEm9RqezIcC/K0DmnRO/ljz9KtyC6DKHayzRAkzl8bLXe1Dq63kACn0mTHUGliYRfzcxenR1MFBOEOzA82pukrOkCHEImlW0gsgfeMVi/xR4i7i2eATADbySFEwQyxSLNawFWlqOANYPUFcpojeDA9shaoSRHuYOCNb6TCfT/BY1wpiSVeVeMA9XIYbmiu7nx/2SNWgbaShXt1kSEN58y+Ft5miprmq7/vFczYgwX/ZOIT2/lmb4qMD5Nw/Hd7AGMWZFKkmKIBo9BeIgeNfPP40V0swL+4KHoLqsgNtN8CFCd0JJxAa7Fq8PZEYQRaWGAiHfn38T3T0lbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4a13d256-b20c-78a7-54f9-ac094b7b50a5@suse.com> Date: Tue, 19 Jul 2022 08:52:06 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v2 3/4] x86/shadow: slightly consolidate sh_unshadow_for_p2m_change() (part III) Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Tim Deegan References: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> In-Reply-To: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0173.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91166a84-8c5f-4dd6-b586-08da695332c7 X-MS-TrafficTypeDiagnostic: VI1PR04MB4864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: bpmdc/ERwLcjploZq4GdqYrfSmTcEzwAbjyPtn6Md+Drw3oOC1aG5PSyMkY2pyYOlKpQdBDl8BHPovzg39br/rguvjJLL28+Is+LCnmCcJk3XfA33GakNDQetqkkIX4thDdh/LB4xrzDpFsBE7tAbqUaakveOzLLH7kTfQmBmTTH1T5rppxuvI6upNu/Sgp1Zjluzcsy88dwVdryz1+j9sgQMGdA4BMFm2SUApOKB4dRkYnXaAAF6iCYcLZhg95nnOEplC4ML29l54F3B/GPTp5Dr1+No83tZwprm7IkzVis6SMMB8xj5izsLElnUGVW47E78bOmNxv0D7pYqwIGsuFBdf1t7IBd7y7oC9CXZcczhLzLn0FxZrXD2vwUQuWPWj0STE4KLZhNQcQAT35AxB1vPer29LUwaI/H39Pn7G23Os1CesUr2e3jNICn27swTsE+EgKjm4TyzQaE4cbYR409JVzeJglfkqZP5n1BZSsNWruoz5OUbMf2rVolGLoeflDLgmCqNFDjeBdlKunygzL5O65lo8uvAH4fEkoMZufGQs3qeHf6O/+Abw0MSqdZ/HG5OdIuuOLt2MtSIzt2lrFMLlYkDVwAl5EhjOQuztMdIb6+Rtf0k6vd+AIygtgAxd0wEChCgVSRehU4mUz3I19KXslXghWRBvkx6R6anuaqupc/hpeYtBoNJBtWMM1apJopK/046coArpo2bnchVC8mpodNsaVYVHoUZpV/X4iIcJI7YwPqt12uuCw24kbrTUaHu7BFuvKClu69sEtlwsSViNXUe2mtFnNMqDsDpslzcQRS9Ff3+GA+/wgGHWD3gfWuMp43VOVc3dZ8cUuVLCMcchzFGFpu4KjOdlWZ1CY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(136003)(396003)(376002)(346002)(316002)(6486002)(478600001)(36756003)(31686004)(41300700001)(6506007)(2616005)(8676002)(6916009)(6512007)(186003)(5660300002)(8936002)(4326008)(66946007)(66556008)(66476007)(26005)(38100700002)(2906002)(86362001)(31696002)(54906003)(70780200001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3ozcW9uM3Y1V3FFM3ZscFRpNENIVmJpQVIrdEtTZUdwMzhtbGFYc0loWkFE?= =?utf-8?B?UWxNb3hMckNTVjN4KzdSK0N6WENyYWlZeXNBTDI1eFZyNS9jSHZTcXNnYWc0?= =?utf-8?B?K2pkaWt0STZBMTRxb0txaVFDV0RVR1JFYmZyZlo1UzRseW1HWXY2WFoydkE4?= =?utf-8?B?VmhxaDR2NC9NVzRUNnZBK01GMVV1WWZqY2hnamtRU1N3aHplZW1BUWZvTk1B?= =?utf-8?B?OUh5eTVFd2o3V0xuY1plZDJWY1JSNE9MZGR0YjFXeS9LUkRYN3h6dkJFTXJ5?= =?utf-8?B?bUxmQlVBZFZBbHJTbXJnSGlvNEh6QVN2Z2gwbTBOa0NiTDJKaEk5UEVreDc5?= =?utf-8?B?RkkxYXdKLzRTU2ZpY2lOcS85WVZkbnNQZ3BtNVRWcllTSVh3dXp5Y1lNS2ww?= =?utf-8?B?TXNBbk5adUd4MFFKZS9UclpSbWxwLzB4S2k1YXpaeVhCQktmYURaVnhrRFdI?= =?utf-8?B?NCtpaUFYUm1DSFhycnNJM1FIbmVuNVNoV0xIUmI3QnNLbktnbTBhMzFIVEc2?= =?utf-8?B?MHg4RmRGMThBaVhTaGd2WHlVb2JEMHBGcU1Vby94NmhhSlhUdFNNdGxEVVdE?= =?utf-8?B?VjlYR1NNdzFRd1RTa0s4OXlWSi9WemtnN1R3SDRzcGQxVTMwNW1RL045RWJq?= =?utf-8?B?K0FUWC9ocHNNdUxaenkzSGpDdTdGZUtITFhoTStJMTBvaENyeHpJUlN6b21Y?= =?utf-8?B?RXJkb0FUcS91dzV0bzNZYlZZbmozZkFReDVSSmRuZW02NWgwQnJ3Z2FSVVlr?= =?utf-8?B?cDVKQXJZd3luVm9ZcVR0SFY0QVpjZE9xQ3FpamdJWDlVNTB1NUN4NVVVR1k1?= =?utf-8?B?V0tDVTlweU9EcDB3RVZOM0RtY2dSWG04clRHM3VUak5XZnRJbHcyVS9Ya1dM?= =?utf-8?B?QWIrdEVCMmhzazlIY1JFYnR4MVp6clgxUEYzMUgvTkkyay9mNGdEeWYxOWlp?= =?utf-8?B?YzE1c1hBdE9adVVRTW84akpxZE9KYU1kclc4TUdTNGZDN0FmbXBVZy9tRmF0?= =?utf-8?B?eGNwMmk0czZTYi9lV0V2TGtBSlA1YS8xS3R2YWd3YmpLZUVCcWlPUWpOemxi?= =?utf-8?B?c3RmVkN4eUtWc2pOejdOdHh3dml4NEJ4MGorMG9MRFN0YUgrNjZJdktURHpY?= =?utf-8?B?bWdpUWpSZk9qWkd1MkVLcFlmdDFkYTZpd3ZpbjRocHU1bSt5ZWxFYzNSOXNy?= =?utf-8?B?S01MazdKMFNKcjFPVk90L2kvUURURnZ4YmxGbjdpRURDOGhobE1YeW5LeDFo?= =?utf-8?B?TzRKSnhLV2lkWG5kaUFzZXFFVWVVcWZsUkF0aVcybk9mM1hodXJPazk4Ym85?= =?utf-8?B?U1ExdWRkRkx1MUJnaXppSDRHejEwS2RBNlRGMHlVdlZJU3FyMFpFSTA4UVVW?= =?utf-8?B?c1M2Z3pGYkdURHFUcUcwc0NpTklRTkIvOVg5M2VLLzZINzY3TmkwS0lZTHgx?= =?utf-8?B?d0htQVkzU2VKaWJWbEFac0kvZCtHOStVaDRQbU1BaHRzWEVhYklCcnJtVkM2?= =?utf-8?B?V3VVY2lvRjlPTllDYzdLcDRqVjVQdmNDVmhZRHUrd2xpSlA5ZmNyQU5Oc3VP?= =?utf-8?B?T2lqNTRKcW5BblorNlYybi9iWlQ1SzluSjFOdXZHL0VpQ1NFVVRVRUo0bE55?= =?utf-8?B?NU42MTJMR1JPSW9ZMm9iQThqSWgyc3ZoUXlEZTI5VnRkOXROdkU0czMrMG0x?= =?utf-8?B?WDlIdDNBOWRiM0VFd0VGSDgrZ1FsL1p3Q0pINDE4SDZ6TkdWT3U2MlAxUFU4?= =?utf-8?B?cDh1TFhUcHIzN0V3c2JkUGxBd3EwME93QkE4NkQ1cEVVQmpOWTBjRUJwQU5t?= =?utf-8?B?d1p0Ty9OMVFvVG9aRmRBWGtLWXlOVFdldWZpK3NkaHAxMkJpeGU3bjhSZjlq?= =?utf-8?B?N1M0WHBGMFl2eVUzTm93Qy9rWGhqeFpaSzJXZEF3Wk44cUl5WW1HM3NTemFr?= =?utf-8?B?bU9TVDJEV2dwdEgwVFErTHpOS1YveDFFbi9Ha2duNVg5dDI5Qzk0WUhJMWpS?= =?utf-8?B?UDExV1U0SnlTc1MvWkxUbzhlYmlXTklXVDdwd0pQZzFZNnpTcEVsK2xtd1dP?= =?utf-8?B?V0hyMmFlQ2VpZ29rOVR3N0JBZk92NGxqUzJUNFlZL3psK3V5ZVFqVzFNc3Fn?= =?utf-8?Q?LQg7qhwP8ck11LEWcbVkV2Wrw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91166a84-8c5f-4dd6-b586-08da695332c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:52:08.2747 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: o4cI/4PVXw21SdIx0mi9sPBUHYLZX9lQSbdFPPqtg5EYdeFnRfGrg0Xj8oeJaLPlo5qxzZGblnentF1fccnQxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4864 In preparation for reactivating the presently dead 2M page path of the function, also deal with the case of replacing an L1 page table all in one go. Signed-off-by: Jan Beulich --- v2: Split from previous bigger patch. --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -847,14 +847,9 @@ static void cf_check sh_unshadow_for_p2m * scheme, that's OK, but otherwise they must be unshadowed. */ case 2: - if ( !(oflags & _PAGE_PSE) ) - break; - - ASSERT(!p2m_is_grant(p2mt)); - { unsigned int i; - l1_pgentry_t *npte = NULL; + l1_pgentry_t *npte = NULL, *opte = NULL; /* If we're replacing a superpage with a normal L1 page, map it */ if ( (l1e_get_flags(new) & _PAGE_PRESENT) && @@ -862,24 +857,39 @@ static void cf_check sh_unshadow_for_p2m mfn_valid(nmfn) ) npte = map_domain_page(nmfn); + /* If we're replacing a normal L1 page, map it as well. */ + if ( !(oflags & _PAGE_PSE) ) + opte = map_domain_page(omfn); + gfn &= ~(L1_PAGETABLE_ENTRIES - 1); for ( i = 0; i < L1_PAGETABLE_ENTRIES; i++ ) { - if ( !npte || - !(l1e_get_flags(npte[i]) & _PAGE_PRESENT) || - !mfn_eq(l1e_get_mfn(npte[i]), omfn) ) + if ( opte ) + { + if ( !(l1e_get_flags(opte[i]) & _PAGE_PRESENT) ) + continue; + omfn = l1e_get_mfn(opte[i]); + } + + if ( npte ) + nmfn = l1e_get_flags(npte[i]) & _PAGE_PRESENT + ? l1e_get_mfn(npte[i]) : INVALID_MFN; + + if ( !mfn_eq(nmfn, omfn) ) { /* This GFN->MFN mapping has gone away */ sh_remove_all_shadows_and_parents(d, omfn); if ( sh_remove_all_mappings(d, omfn, _gfn(gfn + i)) ) flush = true; } + omfn = mfn_add(omfn, 1); + nmfn = mfn_add(nmfn, 1); } - if ( npte ) - unmap_domain_page(npte); + unmap_domain_page(opte); + unmap_domain_page(npte); } break; From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:53:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:53:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370404.602157 (Exim 4.92) (envelope-from ) id 1oDh6Z-0000nn-UW; Tue, 19 Jul 2022 06:53:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370404.602157; Tue, 19 Jul 2022 06:53:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6Z-0000ng-RV; Tue, 19 Jul 2022 06:53:15 +0000 Received: by outflank-mailman (input) for mailman id 370404; Tue, 19 Jul 2022 06:53:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6Y-0000nN-CH for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:53:14 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60044.outbound.protection.outlook.com [40.107.6.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 753dad94-072f-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 08:53:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4864.eurprd04.prod.outlook.com (2603:10a6:803:5d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:53:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:53:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 753dad94-072f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cof2+GI8vdZpaohoO4bHksTgSIk7nXYUWbGkWeUQum4/Uo03rAa72EzUXT49YYxRkc4E5nk4OZNzzmjTFUqTdjbL7VTWogbxUc7zdWPkXAwZge3l5E+KK5YGCJr+0NtWfgbePfr/tYjav5+rqlygcnTiK9REgq3Td6ePrYZ4Tcpjq7Z5SORNVe9/r/j1e0T9qXran8mleAY/mjW3dg4LlUb+X4vSTFJHFTrxkb23gdDROh5GP8IGwi+Ew7F8JyDA4MYWKzeV9UheqsZ3M44jkzW/xEnd1iwy/jjrGbwPudV1Sw9VS6/++mLmoelsHAXh8SYHJ5r20bZlWGw6MZa/fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wMkmvOzz2gve8PQhJ5TEoDWHfH+EBc0eAdwOWdZ75oc=; b=H0QkQ15O6z2hB7d6y5bfj/gQYt2pcScS4iW/Y9ktj0omWg98JNuq7kccpKhzvYndwZYA0aTm9cJFFy0vWfnu6GDGcYpQl1Jiv4D6tqjGY4pqVroJZa3h4ym7hQWuY1RtBLZzVeZrrc4AIH6kHQJpjAMGlGIaOTuGHyQo9FrYV7o4B8c6IBkyloE+kKnOkQASJ5XjUKtS/2VZTcgMEh8y0x+tFHT2nQdeekE3GIt2/fxSkb7UqQmUJdT9PdGLaxbvXkk8sHZkTwpCio8FkKkR241Hztcu+U2d4DDBcdzX8TjPn/GGcZTcxiw5eZoe+FBSO8BnZJMhP8v7MVlTsx5YFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wMkmvOzz2gve8PQhJ5TEoDWHfH+EBc0eAdwOWdZ75oc=; b=3jPH/gn43Z8h/ZZODxn1/6nWKpuD4N2xETUzh2HVbuw88CB61+hUuMVUO+695BNWHgbMxZysvv5751f3gEwh2KsZhhCB0cxvtdGVIpHVrohoPixdVvDB1kwY2P0frVmls6sXyfZsAbfSZnDAeEbUm02iUT2b7cIJFQGXtM28zuXGxICd43qOXUG/G3712MItp1CE8udezrjGCKgaSD2bsCzoXmT+WAGuJeGiSpMyNU8Ew9XcV9YNWrGAeOrgghLH+AchrAc8vLECQSEVQYZJIGV3Hro08/RDJpBkKxFxR+AjkYxGd8S/lHCVY0noWIe7MDQ9ERlxX51GjEtaoGRX5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 08:53:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH v2 4/4] x86/P2M: allow 2M superpage use for shadowed guests Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Tim Deegan References: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> In-Reply-To: <1c14781b-e1a2-e049-c0ea-a12585f74e7e@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0079.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 920429f1-9e3c-44b0-d3b0-08da695358e0 X-MS-TrafficTypeDiagnostic: VI1PR04MB4864:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pllr3zMcNAjKGYKwrdZb9/B188Zpm/8+8Zdne288su+2nOgaevmjihyjkyd5e6xGh7aRG2xX80Pr7LTcDk7UEQydUpSLTbv4vRBDq4FKjEsioMiLg1oKrFVScba17JmwGzE+ALhC2oa2ZtUw+PW98cLGO6HvAlm7vJTVDLofD6cVKGjRSfq+f5y1t0i57SWfXADVF5TNKMoH3IhXnUzsGkhjaPbtsLUfeGGmY1I9E6D92CLy99NENMmP/YNrCKcJ29RXWEvUPgRuOIdgFbg9K4m8c+VWpcJsBrGWpZSG/D6bfiIvEzRgeFA66MAXE3xmISAnDkybJIht02hXQFM0i3qL7zsrrvwibZpoXwfhpHQ2njbepGaQ1dGYRtlXYHoKD481RLab8J4GviCVNksXp9+udVP5BqDfg459QJQwhG9t9OOvh4u2WLFelVU1WeaCW1i07xHh1yRki7Qy/mtQblkoY5EF/K2rQxV92poTvj4RSEDBdP2/1teyeIDx31ljMBh2hZshJPKcUKRGYiNsyfJq808FyxwweBjKea6cXHzpKM1CHVIu6Bj86iNJ1xYD+UVKT/EcOhx+TruhqOvss/BXaGMEV6u5NmG6nK9b0MuqunEvX9atJQFZGuyo1H8KVOppY+mtaeOsIhJAzfGGXKc49E1H+Zs0voZHO6nQc2E6/xZOjpYnajCaOSZrPKqj38Jfe0bsHz3u+ggipq9wuwqXLgnfp2AMMl35kw/hxE19ZYPRSD/w+WKqnm4ik7LStCO0CqINE7kIiAYst/5YLwOFiMyupAmL2czxExfa2CntW49Thj7wckwkjQpZedasL5zDa0M/hPR8gmQ/Pj+e3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(136003)(396003)(376002)(346002)(83380400001)(316002)(6486002)(478600001)(36756003)(31686004)(41300700001)(6506007)(2616005)(8676002)(6916009)(6512007)(186003)(5660300002)(8936002)(4326008)(66946007)(66556008)(66476007)(26005)(38100700002)(2906002)(86362001)(31696002)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aURLZTlQZUNLUHJMUlFXUERESlZTSjV5ZjFDL3dyWHFYUGxBUkVMTHNBeWlr?= =?utf-8?B?REJ3bTl6eG14cnFFVmJKNzl1ZlRweERoSUljN2F0SUVBUGtyU0RFVGZsUFdt?= =?utf-8?B?VjZ1S2hHSGVOU2x5Z1MzekQzOEM4bmdNanowSGxSQ0J3ejE2U0VxWU43eHUy?= =?utf-8?B?WGsvbXhlZzdoTU5mWm4wZElvSHlHZ3FCVWtMUmVrT0NQckUwcEN0Vnc3MGRk?= =?utf-8?B?amNzckN6cjZ5VkZlOVBvQkhJaE95S2ZDWDhtenVpZkFpbHFCRWU1bHhLRzFv?= =?utf-8?B?eitCUUxOMUR6SGVGK2lzWmtXTUtFRmx4Qk1oMjZDSm1tMy9rSHBTaE1Oay9s?= =?utf-8?B?YW1tamVUNWdsUlRxUlZDZlZ0NEtrRkdhTVFudStyaFFLT1FLY3FrcHpValJ3?= =?utf-8?B?RkJLc3gxU0wxVXpkNmE4SklGWlpSTncrK3AwVDJRYUxzcnJtdy84djYvZlVz?= =?utf-8?B?QkxXcktsWElzZ3VTQ1NraThka3A1d08vZEVrY2t4TkpuZFFNSW1IQVg0dHo2?= =?utf-8?B?d1RORzNwMmUvd09NNkdobmFOR3VwclR3OWtwUEsrNlV0aCtzT2E5U295bEVP?= =?utf-8?B?d3RBOEhFZ204SzF3WnM2MjJ3RHF3UGhuczhVL2FKdCtqYU03ZzNnMmFRMndN?= =?utf-8?B?SlQ1b0xSNTM0cTljL2s3dEhGSlhxZnNHQTdIb2hBYldHK0RjYVdxWklGN1hn?= =?utf-8?B?b3hsUFVjQUU5RDZpWEIzQzRYZVFsVWVoNmJ6SlRoQ1VVRkNUQ1UwU1NxUU53?= =?utf-8?B?Nlh6UDRWYjhsSHNLWmVnb3pMditPUmVERzl0WlowQVIvQ2dGNVBwNzdCaE5a?= =?utf-8?B?TEk5UE12R3M2akxoWjFlR3JLc0ticUU2M3ljUitwMHYvdUxmbk5EaUgrbTA0?= =?utf-8?B?WklMNlhtU1NSRTR4alZjSUd0NmZkZ09weWx5Q1FTQytmbjJNdzVPR0ZpMmYx?= =?utf-8?B?WHB3ZVpWcHErc01aR29Zem8venA5Zi9jL2toNzBMSmdBNjIyQTVsNmdNMWFV?= =?utf-8?B?MVpidkNMSXR0eDRyOVhnR0VWMzFwcitwRDZNRG95OXlQSm9VOGxtbU5qREg4?= =?utf-8?B?MEU0cXhrbUxxZ0ViQ3JvOEFyWEFQRkozdFcvZ2V4SUEzRkRMUE16dFNxTkcy?= =?utf-8?B?VHp4d2FuejNZenpBd2w1aEUyVVFmMGJpOEMrTnd0YXVudGJhUEVPQ0tLOE5i?= =?utf-8?B?dzRvY0QzZllSYytzak1IUkFqeWxJL0NHQzY3cmFqVTMzK0FjbDI4VS80QXB6?= =?utf-8?B?MlBCQ2kvR1JtckhSaVQ4OXZWZDJQV0tLM09weDhRekNwdnRhZmRRbFN3YStT?= =?utf-8?B?NjlKZ3VWM2RzU0xHczNhd1Nram9GNS9TY09Yd2RuR2NnTjgram1uWkk4MDc3?= =?utf-8?B?R2N1MXl0UFU5Y1g0YWN1VUFQUy9zWmI0SkIvZGw3UFl0ZCtiSENQUVhEcjYw?= =?utf-8?B?V0lxVmdRRXNhKzQ0NytydlI1amFhTzROcUxoZWtnQ1gyL0hjakRhRmdUTXhW?= =?utf-8?B?U3dNNTVRMksvRG43Wm1hMDlZZEk0VHRxSkFadjFqeEZWS08xTU45ZkFuSDZY?= =?utf-8?B?cWw2SFN1SFBQbHcvNVg3dTgybDZJZSs0RXc2UHRoRlpIMXZMQnhhRTNncjVY?= =?utf-8?B?QVNXakZmU3ErSDVlc2IxTjJ4bEhlTE9CU094YlBrdE9JdUk0NGlBUnpyK0lm?= =?utf-8?B?OVRYZ2ZTZVFwVzBMaGpNdTlTandnbmd4aDYreDZtUENXRXdzYUJkNE5JeFR2?= =?utf-8?B?UDBUeXdRbksvWXB4VjF2ZHR1allFcFRRb1V1ZGpRQngxWjVxeTR5alZmaDZy?= =?utf-8?B?SFZJNHVnaWI5MVdHL2tidzZBV2NKVTFpYTFXdlVtTHFCUXJUQ2tTV1AybXR0?= =?utf-8?B?dlV4ZWVNOG0wWDFJa25VRDJsTHNyeGxnSE94YlZENjlTS0g0TmtpdHNSeFZ5?= =?utf-8?B?bkIzV3hENHo4ZzY2bVpsQTNUWWdta0dIRWRjQ0dCM3JiNFRFS0lDZzJtSnJI?= =?utf-8?B?UXdqaWF2Sm9oVmNsSHF6ekJtT3hzZ0hobFgybGdQSHZCa3RONFlwK0lrYTRh?= =?utf-8?B?cWhXUXBLMXY1UUowRzVCZHd1WStIUHd5QlpWb3hQbHdXQkVVaXJuYS9IR1B6?= =?utf-8?Q?Zbu+l9ajSAmLCTbXpvKTF2pR6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 920429f1-9e3c-44b0-d3b0-08da695358e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:53:12.1927 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Re0LhPHvqIoW+IecU+zrBprR/+MoqMcl2GuPzkKbrBQRRxAGwFstbUEA7pZ1O/9eFZd5aDCbNKECEm9R5GgeVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4864 For guests in shadow mode the P2M table gets used only by software. The only place where it matters whether superpages in the P2M can be dealt with is sh_unshadow_for_p2m_change(): The table is never made accessible to hardware for address translation, and the only checks of _PAGE_PSE in P2M entries in shadow code are in this function (all others are against guest page table entries). That function has been capable of handling them even before commit 0ca1669871f8a ("P2M: check whether hap mode is enabled before using 2mb pages") disabled 2M use in this case for dubious reasons ("potential errors when hap is disabled"). While doing this, move "order" into more narrow scope and replace the local variable "d" by a new "hap" one. Signed-off-by: Jan Beulich --- v2: Extend description. --- Strictly speaking "fn_mask" could also be "unsigned int"; I wasn't sure whether changing that would cause objections. While at least sh_unshadow_for_p2m_change() presently relies on this behavior, it is somewhat odd (and inefficient) for p2m_set_entry() to split even non-present mappings. --- a/xen/arch/x86/mm/p2m.c +++ b/xen/arch/x86/mm/p2m.c @@ -403,28 +403,22 @@ struct page_info *p2m_get_page_from_gfn( int p2m_set_entry(struct p2m_domain *p2m, gfn_t gfn, mfn_t mfn, unsigned int page_order, p2m_type_t p2mt, p2m_access_t p2ma) { - struct domain *d = p2m->domain; + bool hap = hap_enabled(p2m->domain); unsigned long todo = 1ul << page_order; - unsigned int order; int set_rc, rc = 0; ASSERT(gfn_locked_by_me(p2m, gfn)); while ( todo ) { - if ( hap_enabled(d) ) - { - unsigned long fn_mask = !mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0; - - fn_mask |= gfn_x(gfn) | todo; - - order = (!(fn_mask & ((1ul << PAGE_ORDER_1G) - 1)) && - hap_has_1gb) ? PAGE_ORDER_1G : - (!(fn_mask & ((1ul << PAGE_ORDER_2M) - 1)) && - hap_has_2mb) ? PAGE_ORDER_2M : PAGE_ORDER_4K; - } - else - order = 0; + unsigned long fn_mask = (!mfn_eq(mfn, INVALID_MFN) ? mfn_x(mfn) : 0) | + gfn_x(gfn) | todo; + unsigned int order = (!(fn_mask & ((1ul << PAGE_ORDER_1G) - 1)) && + hap && hap_has_1gb) + ? PAGE_ORDER_1G + : (!(fn_mask & ((1ul << PAGE_ORDER_2M) - 1)) && + (!hap || hap_has_2mb)) + ? PAGE_ORDER_2M : PAGE_ORDER_4K; set_rc = p2m->set_entry(p2m, gfn, mfn, order, p2mt, p2ma, -1); if ( set_rc ) From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:53:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:53:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370409.602168 (Exim 4.92) (envelope-from ) id 1oDh6w-0001IO-6K; Tue, 19 Jul 2022 06:53:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370409.602168; Tue, 19 Jul 2022 06:53:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6w-0001IH-2r; Tue, 19 Jul 2022 06:53:38 +0000 Received: by outflank-mailman (input) for mailman id 370409; Tue, 19 Jul 2022 06:53:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6u-0001Hp-MZ; Tue, 19 Jul 2022 06:53:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6u-00014z-Jw; Tue, 19 Jul 2022 06:53:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDh6u-0005JN-5S; Tue, 19 Jul 2022 06:53:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDh6u-000503-4y; Tue, 19 Jul 2022 06:53:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VqDdLpSXSdfxWNS39y7L7gQpfDVzZtUHCYmavLFzu2U=; b=3guXC1aj/gbhA0nib0+CjZpB3t a8uBIhobe9xPUrkyM6vuuUpaC8Oioo2qBgI78g32kvF6weWR8lChxz9I8TBZq4MwMn5EBsKPf7EC1 Br8Qdg3Hc4AuIj4iWVi0oRuDIRbq3kZ/AFZ3guQ/1MRDjTPuXsOLymCSD/ls0p3dMyKo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171679: all pass - PUSHED X-Osstest-Versions-This: ovmf=f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 X-Osstest-Versions-That: ovmf=e21b2039112eeba9a93fdd7b70329a07a79c8f0e From: osstest service owner Date: Tue, 19 Jul 2022 06:53:36 +0000 flight 171679 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171679/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 baseline version: ovmf e21b2039112eeba9a93fdd7b70329a07a79c8f0e Last test of basis 171677 2022-07-19 01:11:58 Z 0 days Testing same since 171679 2022-07-19 03:13:39 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abner Abner Chang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e21b203911..f0064ac3af f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 06:58:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 06:58:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370422.602179 (Exim 4.92) (envelope-from ) id 1oDhBn-0002HF-Rk; Tue, 19 Jul 2022 06:58:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370422.602179; Tue, 19 Jul 2022 06:58:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhBn-0002H8-NA; Tue, 19 Jul 2022 06:58:39 +0000 Received: by outflank-mailman (input) for mailman id 370422; Tue, 19 Jul 2022 06:58:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhBm-0002H2-Bq for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 06:58:38 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80082.outbound.protection.outlook.com [40.107.8.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3606497f-0730-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 08:58:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2802.eurprd04.prod.outlook.com (2603:10a6:203:9e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 06:58:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 06:58:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3606497f-0730-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fR8Z7AJBZCwUzqnrX13SGEYdYwX+9BjPbskC9QUAe/AHDVqygSM44m+4g2HPTKWAUFatSmG+hQJdbCQgW5GbmdKH910DFmKod42QmX81lrapYt1qsVEj5uli4dYfrJu7q5MXeKj0tjrHWVYrwybZU6kX+QwiFLdA6Ct30j4FaHY9aCRcg+dG/jTkTN7rzat2TXQd8+R1HO1vf3Pgl/wSWqRbXWhUOzZJ+N6/6Y3RgLisPgOb4DsOYS51QbapScaW3Lam956ZpCCYmhDZNLTcU4kMtJLLejVXIC4YlER4kez0p1NtT6vY8JmyVhzuV7S59Eh4PT008MeRe9gSYJmobA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fWIicwDjON2Ptt7DxbfwOM+H9YNETXbZtEAAyHQcDNw=; b=XseIGCE9bvNL53p/XOi79EpnkWppZLsM9xEGKMw4wP3KYUwMPxkhXvIK/3CzYICyUxlhnLvZ0gC+ltFl3/2esyqCiISO035QECdtIBLDMbS9kLOBlWB5I2FH2TMA8Va0z9/nhzWovLOmSCoNmiMy9Od5OxZNDFCkrO9B8NWjSvStEwGoLOfEMH3gUDv1CnN1+8qrTpTTuuLjHNFGX1aajgIw8iqhVIonQDs876AKsBkKnKuAgwBNrvCGegMLe7NiR8zgGK4FDw7f2z/jrZWtw/19hNapP6EboG31gHrevXz83rMcMV9Qm6VETpRlu39oYJx6xnbjRp1BE80Cfl+IVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fWIicwDjON2Ptt7DxbfwOM+H9YNETXbZtEAAyHQcDNw=; b=0A7+Xr9MMc7/AaoQto71n+4JxYijACXNhKALfI2W8GDA4QOMVu+8RVayNYM4cMfGkyRZAWLGzheItlMWC2RVxE2W2bjV7h14/DWrse8dKdS/tZ14OdrfbeECwSlHrNoHHTO2ykcmnIJGqFw7f7T/KBdp8ty5rp3z4/KKvoim/SfdkePZD5jgXo76E/NdJHutdWLGLx8zpnj8NmN4C7Ma1OXFzoX1k0jPjmGgMlQ6JDIRzeLdUO2Vfxf77J9gQlDjdPhZCF+sAq1i7nymYVK6Nyx8xknFiGDeyJ79M5JnlfxHInNN/gqToL2q+vyz4HN9RWt6W3AZZWnpBPxx1ym9/w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b961b3b-ef91-1bf1-31c8-06f2ad812c29@suse.com> Date: Tue, 19 Jul 2022 08:58:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly Cc: xen-devel@lists.xenproject.org References: <7c369f0f-f602-8699-6ec6-9fb05b603825@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0119.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d29298bc-bce7-4f74-a3ae-08da695418e7 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2802:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: X1WR4WkIfPVNghudSgdcZicRP1Ss6bDL8WbinwU9nYlVUy/Hrk8BiGv2IzBtL9jdyZk9jcc5aknglvQzpAyXB9pS/AGZZoBX5+UNIjqvjnVzVJ1CVD2rYHyasWe9oYyUhcuR5rijNA7OpNRV9xG3HedkAvTx4I2Otef7YKBOU7OyJNyIFUZllQOgsx+q8DAVxrXATUkPS1oqTTntnsVHTfoBpR4+DHiUvpl8HUeoIWFrnW58ZEj1WXA9A1oBdOLNVM6lwO0W7LhAdZllYJnpkay8l8iiKoZ7RVNmAZ8jmY583jBNGELDvjrPuoAae2ESZ7016dJrdVj+30sSg2rnLgf0yLCs7yhc/roMil8gVlrkLqrhmSfWmfA8Twzpv2Lu/aKVa+8NCqhz6BjO3T5Xm5AzttCxJaukteKPtgXP7OYm+pHO0yQWcAsSCqQcub/Y634PXmAh/gTm9cQ7l+jQWpZ3cGjTZ6tQgmheV1013dvJQkXEdWZAw5JdBvflN3MUSEiRBdRKGX8R5EGWIBtIBHzE8b05WCfuqLAUQlsr4aGzk86/NQx8RteudlStVtXzE6+JDIdklURcvHfd0JRrEGhOFYZ+f8V7MwENON7VdM8Q/IOwIrrvPMPoukwuAjoVFl4W9y2XFPvtYyus3hZz1zMaoxFVLsAbKjxzA1iN1ksf5yH9OesRFfBUaGvwmTCetnsgcXUdLf0Q1qqDSXbxB8IVGo71kasU7R+dqywkDfUYpszB55YOjNuMhVHAXME1S66sRzAcJpVWSammdeFkypuvJKOXYLLv0UaLk+CF9BEDL62sGHG06uJWN8tNS3Nh7MdJZjTuU/7F70W5+5k2NQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(396003)(366004)(376002)(26005)(6916009)(6512007)(2616005)(31686004)(186003)(66574015)(6486002)(66476007)(41300700001)(36756003)(478600001)(2906002)(86362001)(38100700002)(8936002)(66946007)(316002)(6506007)(4326008)(66556008)(53546011)(4744005)(8676002)(5660300002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eCs3b2tvdHE0SERmcm02OEU3NWxqRUlrbXFWdjJIZzVGamVOdHZrNTVObnNo?= =?utf-8?B?ekIvbXZ2Y3F6bDBtaVpySzFPNFlTOTdSUHY2ZzBWOHN0bmxGTXpRREs2QjZq?= =?utf-8?B?MGROM0VEa1AycWY4ZkVGOHkxZlBDNWJsVGl3SnQvd0V6Z2IraU1NdHU4Lzcy?= =?utf-8?B?RDdIeHY4TWhSelU4WDhOVEIydkNVeUZyUjJwbjNML3JTOW1iTzNKV01FT05I?= =?utf-8?B?Tm5KNG50b0FTNWhWbEZMQTI4N3AvUWtnbE4rdkU4b25XaWxPZVdmNm8xZkpQ?= =?utf-8?B?S2EzV0RjdWx5RVpob3JsUnRjQ2NwbWkydlhKRFJxeWFLWDgzZVgyanBLbVBv?= =?utf-8?B?YjQ3bEFqZFFyWHl4Wi9aMmhkZzYzZmMrSFRvS2d4ZGNhRXFrOCtHdmRCeXVn?= =?utf-8?B?RjQ5Ky9MeW5vemFmWE15b2pjemg1TlRKMm9tTlJkVUxJdm9sK2xXdlcwYmha?= =?utf-8?B?LytIR096aTVmM0N1QkphSnlaK0xITVFXVXJ6cWU4QzloQk1NdzZuWVFIMnNm?= =?utf-8?B?bGNFbzdzR2dWKzJ0RG44OGtBdWZlUG4xZ2pjbCtheDlDZWNoeDU2eVlGdW1S?= =?utf-8?B?NGZTV0ZXaTR5TTR3bFJ2SkNHTGVFbm1pbk5sZE5xSzlVb3hoRjJOZ1oxanBG?= =?utf-8?B?WndlM1k0d2pEajgzaVVBR21PRXpmQkxFelZpYms2UmUrL3VGOVVLSDE0WWQ3?= =?utf-8?B?b1hCdHR3QW9leWtWdTRVckk1aTgyVk1TNjlZSVpXNWs2Mkw0VFBFejVPQzY4?= =?utf-8?B?eWQrdjhOcTJFUjhUclRaNlNVVEFpYllldHltZHBoREpqd21wekdPR3FVVzJM?= =?utf-8?B?NmhNR1J1WDlVb2ljQ3h0N0p2M0RTT3hkRlBVQkdNWDE5ekZRRFZVc2dSTmk5?= =?utf-8?B?Z3BJVDFZc1VKbGxoWTVsMmVGTXBDUzBiWUU5L2hxdkZDWG96WGJNeUtRRE1Q?= =?utf-8?B?Qm5yWGtSM2VXV3UzS3paM1RweVQvWlpFUjRxT1Z3T0l5OGZWcml5bWRWclFH?= =?utf-8?B?L1VYQ3dwZmY2aFBRRHJJQ0Q3TnNWY0tTNkZydWVGeEJld1JCRVJHRE02MXc2?= =?utf-8?B?ZnJEMHVVbU1aUGRMQzNxM2szZkpvOWpCcnkzNE9kanEzaWU4VlpzV0RYTUE2?= =?utf-8?B?aFZTVFM5b2hiK1BkaitHOWs3cHVhVVR2Rm9nMHNKa3JrMlg2WUh3UzdNeko3?= =?utf-8?B?ekNNMGFrZHBvQ28rZHY4VlVOMWRMY2tJWTRkeDFJT25qRkZZNTlLN0pVU1o3?= =?utf-8?B?cU9HbEFObmNKYlRibnJ0d2RoZU5ydDNlNXR0Qm1SM0FGSXNEM2w2K3E5ZzJL?= =?utf-8?B?enJRUWkyNW9xVlNDMUQxR3ppNFRJS2NKYnlxTTRNTTlZS2djczFSeXR2bEor?= =?utf-8?B?VU93amMxU09mTm15RFQxa0pRZS9SckxXeUxycUwraUNwTEZ3NXRqRlkzNWNW?= =?utf-8?B?dnZQYlIrZm5pUWpNdzVtYmdXRVcyeklTd2t2TWlXY21RbkxzU2xFd1E3VlA2?= =?utf-8?B?TDE2N1NIRGlQTzlTbHZhNXVMNXJva1lPY3d6bG9LSmJNNFVnSnArbDAxcE42?= =?utf-8?B?ZEw4em5MZUxIa3d1dXFXUHV1czk5bWlPUDRJWWgrWkRndFY4cENwWERMbXBE?= =?utf-8?B?MG51b081dVFTUHBsWXJTZGJRcC9heXJDNnJKUTUvVlRrbVU3WGVDc0c1OHU4?= =?utf-8?B?ek9hOHczamxlVFRZVnk5NGphN2ttdEVMc0dON2Iva0M2VmU3TVBlUk5IRGVY?= =?utf-8?B?ODI5UmlpSzk2Nzh4RVNqblhpVmZKc1haZitCL2p2VWhaNzZ0ekEzN2RIRXZG?= =?utf-8?B?WGNTYVpBOTIrRnlJWGQ5dW9zKzVSZFJtdERtZHU4SnM1aVBia2RCMU04SSs4?= =?utf-8?B?UVBBSHlZNEJBT1pwTGE0RDlrT2xwdG9pNGFBQlRVR3hIbU1TOEdMMUpGN01l?= =?utf-8?B?MFYwNHczRnphcUY2ZzBEcFE3NDZzWUQzYmFWMzBwbWZNb1FVdERDM2JnTTZ5?= =?utf-8?B?bmRNMUwzRFZXelA0ancwaVQwRXVIVC8yV01Xa2RiUi9wczI2RndMNTlBRWZy?= =?utf-8?B?MFBUUjF2cXp0Z0Z5WlBnVjE5aEJaMENkN3ZGa0llZ1N1WE9yU0Exd1o2ekgv?= =?utf-8?Q?vT05UE8wuXvI/eH84W94N6sRF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d29298bc-bce7-4f74-a3ae-08da695418e7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 06:58:34.3599 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u4+jGVF4LwUUi9ARVnjzGZ/Sj4jXrKfzVMirQmPfTvLg7ceq7nU7dRk4q2/9DgR/b9MifeK4SsBWNUkCvyLjig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2802 On 19.07.2022 08:47, Dylanger Daly wrote: > Yes ☹️, do you know if it's possible to obtain logs some other way for a system that doesn't have a COM port? console=vga exists but I can't seem to flip over to the vga "console" after I trigger the start of a VM I'd focus on the booting issues first. And I guess you can take a video of that (assuming that a single screenshot likely isn't going to be enough), possibly with "vga=keep" in place (albeit that introduces extra slowness)? There's also the option of using an EHCI debug port for the serial console, but this requires (a) a special cable and (b) the system designers not having inserted any hubs between the controller and the connector. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 07:03:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 07:03:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370428.602190 (Exim 4.92) (envelope-from ) id 1oDhGC-0003jr-CM; Tue, 19 Jul 2022 07:03:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370428.602190; Tue, 19 Jul 2022 07:03:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhGC-0003jk-9G; Tue, 19 Jul 2022 07:03:12 +0000 Received: by outflank-mailman (input) for mailman id 370428; Tue, 19 Jul 2022 07:03:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhGB-0003ja-EP; Tue, 19 Jul 2022 07:03:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhGB-0001HG-Bx; Tue, 19 Jul 2022 07:03:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhGA-0005gM-Gq; Tue, 19 Jul 2022 07:03:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDhGA-0002Sl-GM; Tue, 19 Jul 2022 07:03:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Lpufb6q68IQdj8kyyEyB3rZYN6qSBAF/BXQsfm/Yvjc=; b=KXtkYqKqX+Fcvc95pSkmnlYaMi EQ+pH3wJCLMLQywW1v0aqkMiFHSQ9GBo3TMpkEfCsIKPMh8PTE9GUR7eZ5lG1sVRTgqpX1u+DL3nG sbJ5JmXwf+zRfcaPvULjsrn/ys/SDnP24MyNd4r5kiHgQdmRVAAEaZGBx9uaeBo+qoKc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171676: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=782378973121addeb11b13fd12a6ac2e69faa33f X-Osstest-Versions-That: qemuu=0ebf76aae58324b8f7bf6af798696687f5f4c2a9 From: osstest service owner Date: Tue, 19 Jul 2022 07:03:10 +0000 flight 171676 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171676/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171648 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171648 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171648 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171648 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171648 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171648 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171648 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171648 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 782378973121addeb11b13fd12a6ac2e69faa33f baseline version: qemuu 0ebf76aae58324b8f7bf6af798696687f5f4c2a9 Last test of basis 171648 2022-07-16 03:15:54 Z 3 days Failing since 171670 2022-07-18 15:38:37 Z 0 days 2 attempts Testing same since 171676 2022-07-18 22:40:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrey Makarov Andrey Makarov Hao Wu Konstantin Kostiuk Michael Roth Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 0ebf76aae5..7823789731 782378973121addeb11b13fd12a6ac2e69faa33f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Jul 19 07:26:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 07:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370437.602201 (Exim 4.92) (envelope-from ) id 1oDhco-0006YI-A2; Tue, 19 Jul 2022 07:26:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370437.602201; Tue, 19 Jul 2022 07:26:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhco-0006YB-79; Tue, 19 Jul 2022 07:26:34 +0000 Received: by outflank-mailman (input) for mailman id 370437; Tue, 19 Jul 2022 07:26:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhcm-0006Xg-F2 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 07:26:33 +0000 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 194fc61e-0734-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 09:26:30 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:26:16 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 19 Jul 2022 00:26:12 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 00:26:12 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 19 Jul 2022 00:26:11 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 19 Jul 2022 00:26:11 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:26:11 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by CH0PR11MB5250.namprd11.prod.outlook.com (2603:10b6:610:e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 07:26:08 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c%2]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:26:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 194fc61e-0734-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658215590; x=1689751590; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=avsFE9lFn77Cqu+w62BqJM80TUs4u6jb51ngpyX/usQ=; b=WhUQ7uwhqZSha+hl9b+8qjDoAqSi01UZ1sV1DocJltQtZ5P0++YIZC9f FZnJRQath2iXFFPCnOYnd9yLGgjxsiGeAx0+RF6bb5qIPpASnLFyIWxoE R4rY0L3Ngd05p7Ejqqw/8IbwGvj0zN/frhpmuLlJjmJW/ilsRR+PNS2J6 vU1/Pszi/ehY0dF9anQoa30b0gLwjwOR3P8aCASGj+GcMj1ZjAjiNUqS5 p7UPAawPQ01A4KEojXcGZPLehY38NpIu/nC3MapWm7dQaHy3w5Jchn1BC 1cmBAmHeNH88x3a5y9q/dZg4x7twJJjwZL/EhJ4jeAGl/o2ft6xSDgT1s g==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="372723337" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="372723337" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="630226963" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XWdLm7ysOTWfb0BUPfG237GTjVguV+ScUhjuFwQZGO85fpF88BKo3rLAk5HIRYGd8W48StUyJshyShuYvpdUY0apzaXh03PLDjGKjipURUdUXSTRXcWAKMCchiDjCQpfD7GrxSFZH9OU93cng9c3aEXlDC/TBtlCirecU9n8fibQIf58OCtZEgmoCe+G0Ld+G5aZu1FGVBCATghaLdpHs5QZOhg1pxCDF+KFEREdzOifKmzfB1kNBxVOUO9iOoWswt8PwLSRPKf5p2XEpa7n02oka9cGnw9CzxeBfmTm2uMtSE9nTvBW5v6YOFF+kQsORZiVCpaQltSB40G0ENUmnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=avsFE9lFn77Cqu+w62BqJM80TUs4u6jb51ngpyX/usQ=; b=hlaO9yNdXn3bWZZRE8eZw5Hct4mjwpIJEII2OuWM8XCqXyDc/xfu8TtDZUCVZk99AyrDTJC57iSMqZuuCYVDhyeOZCmCtzC3J5HhU6sUQb3w+sxIeYyfugrLgfKgpCS8rfYFK/yhBsTf0CmdE4+jotyc1CUu8TFGiOrr+hbn8Eub8XVhIXIdyOyXvdDzpq8DwZuGu9V7csOe4VcvBG8qHnJwwoC/yvfSp69Z9JSg6EF4n085fXex9qfXH/q9KH6gsigSbrXdX/lERjtPnUL9Dp8BP54UeYW3nhsYad7Ruw6GO/21N6KBQON539KtwloFUcCdZ6lTlFbne3U5alNYPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Nakajima, Jun" , "Beulich, Jan" , "Cooper, Andrew" , Wei Liu Subject: RE: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Thread-Topic: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Thread-Index: AQHYjUzyisX0+ExRGkiFh4Bp+KXF1a2FZhTg Date: Tue, 19 Jul 2022 07:26:08 +0000 Message-ID: References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-2-roger.pau@citrix.com> In-Reply-To: <20220701131648.34292-2-roger.pau@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7c97caf-94e1-4521-14e9-08da6957f2e4 x-ms-traffictypediagnostic: CH0PR11MB5250:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zWXBtGcZP+tGZ1E4falRXloSJU0vOkC8t+UX3TocsCfJOxbGjBPi6TDNCLKU2MXdRJ0m3sFGrYI1IBDqzIicJ4abXL+kDfejNpZ6Ihm9MUzDTC7dplTXx9a9MID7YNQCAD4QYbbJu4nn8urrKn+6oNNF20wvTISrWONa+K1HeOoh50Lwc96bv6DOOEK+3aEGj4fmIv2MohRcZpsiphvhwEzpt9h6btA9U9S1Si8uUhTweX2p+oXEi/X8TjxTNZfGpX1HnkBYlZ2n7PYfjJKwnXkCK3+yjBqrJeInKTgE/nhmmP23+4vBo25T/R3GeD5eGLoBlimEvv0P17R3ONe6QGI3Z6BXDYSJtD/vP1yNWf2EqnTxHaBbjnkAxrMKeqhufmIv8tdJprK/gy2z1YjALCA9M3fnBbObxB0XAYrWRNxhNMTf6cP0Aq3cMct7NcxFG2ZDSEM+37JNP2ZBTTGwpvWuYeZF9fXsi4rxOpQu4iehIU47FhCU5+w3bRkkmGxWFdAZ6C6RzT1cuVaqRcNY1jVY8iHxZ8hWDHLMHZEW4l0peTyxC4PtV0oaMh4zOpixAYVhwgdxXsRTTySoxyBTeGj9bgHOQP5P83KmZosuwLjsk8jIkXYJPEALG9JBDj1fnWzc6x8u0b4pJMBN1ickTkxEurc5vGvhRmiID6Y6v9uZ/oUbh4FGsX8raYjulDuEujXJtE7OXSSUSuSQlf25jn79dN7l9vas+vKTPu7FIlnarmgCHEkB3g3Fjfx0K8UvJ3ZtzsFQfms7QRWb4MuNayLZfGNFZcKom2xY22SzAtWLKXsSvL9T7e4Z5pOi1PrA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(136003)(366004)(39860400002)(346002)(52536014)(8936002)(4326008)(5660300002)(55016003)(2906002)(33656002)(8676002)(64756008)(110136005)(54906003)(76116006)(316002)(122000001)(38070700005)(82960400001)(26005)(86362001)(41300700001)(186003)(9686003)(7696005)(478600001)(71200400001)(66446008)(66556008)(6506007)(83380400001)(66476007)(66946007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Y3I2eFJZeHFROXhZeWdtVVhXL2p0ak1vREJ2U1Y3S08yVmxHS1dBbUpRVHZR?= =?utf-8?B?K3daM1RkZDhrb3dLYzZUN29YT05TYUlxZUwyd2xCRGlEa0Y4RFVKY3krRXdp?= =?utf-8?B?dlVWWjB3S0YveG5YNUlqRGtjRmw1Z1kySDk4MFVIOGpFbHBibGg3OUs0eHl6?= =?utf-8?B?YXZDaXdNbGdrWXczN3ZzR1VwUm5kWk5HdjREaWs3Wko1M21kSUtWMnhQL1FE?= =?utf-8?B?Y0R3U3BDbUpFc2phQXpyOTJYc3pscUFlNXo0WS9zbUxtREx3U3pNYTg4Wmsy?= =?utf-8?B?S2pVZHlYZ0xhZzNUZEN1TmM5cDhyWS9lZEVEMk56OENKMmVhcWlZNU5wYkxl?= =?utf-8?B?djBtYWVNWUE0ZkRRVXdPTVNabUwrRy9OanJaejdDdWJ6OU13aFNUMEM2NFlF?= =?utf-8?B?QThMUEdCWEFCQXIyM1VCWFQ0a2E1bEFzcmlScFlPTE4wQWtWYU5OYWNDTjZW?= =?utf-8?B?VkpUVU9FU1BmU01hais5Mm5YdkV6OGNXMVJNb3dtWUlPdm00bDNHQUZXOHU1?= =?utf-8?B?eW03MCthNnUzaHBXRW8vclhaamt1VjlnUi9VNzlVQ0pyQ0ppNWsrZjk0NlF5?= =?utf-8?B?V3BROHBXTk5PSGhlTmk5cm42SHM4dkZna0RZV3ZYdHdkRTJtQU95V203WERu?= =?utf-8?B?cDdXNVlwVlJLSW9iOGlJSG1XaDNVTkVpTHJCTlpEQ3BsM1BsdUZJbEU0VXRF?= =?utf-8?B?MjgyT0pzRkkrTS92djdQbmFtdVpmOFFrVkJ3dGhSbVRsaUN4eWU3WTBUbmRK?= =?utf-8?B?SmV2dDBta3VGdzk5VFMxRGNNUE1iRkladEtqOWRuL2NSTWJsN1ZDcFRJVmxF?= =?utf-8?B?a2tLdXJ5VFp1N1lGRkNOYmhoQXRZWGxuRGM1bURNOWx6eWFJQTJvM3V4NGZm?= =?utf-8?B?VjU4Q01odFF2YmJMSjdKcGdkdWhjTndUd2ZZa2h3czgweERwYkdzVUVBUlBa?= =?utf-8?B?YWh4VFBCVXBGdFBMcmRLbEU4a0FmREl6Sno0bVppejQ3TmdWUmFQcUR5K3hp?= =?utf-8?B?by9aS1N0bEJCNE4zbk5PcllFYXJjcW90ZmdxYVRrYzQxRGJxaW96QlIxN0I5?= =?utf-8?B?TFBhZXBjd3JYNnZka1gxdU5zb2NkMTVxdVIwL045emZqYzcwN0ZLZlBDalph?= =?utf-8?B?dVh0VU5JcnI2dVdxb3Yray9jNVZDMjVmSzNMblIwdWtsUll2QnU2OWRPbGg1?= =?utf-8?B?ZWVnVVE3bGlicFFpNFo0Y0ZDWlVLLzBtdW9wVm1VY0RCcXBRQ0QzT2tYT1hh?= =?utf-8?B?OFVoalIxSk9abHdaaThIVGh5SG5NYmVZRXVjMkdnUEU4Z3k5M0RkTEY1NDQ0?= =?utf-8?B?SWFTaWcwcnVOL0YxclZYYXFETW4vaktvQkFZMGliSElPTXFQNXZZUEZtV3hj?= =?utf-8?B?TUdrTVdhc0pobEdLZHNQMEdrN0NOMFhtenU3Wko1dnVwSnFXeE1kdEhvWU5N?= =?utf-8?B?aE04NXd3WW5vSndMcnBMMGRFVVRUWkpYeFhKOW1qWE5FcXR5ckRDVmhqZW01?= =?utf-8?B?eENGMzJFVzREelhSRmRGS29ZRnZpSmtjZVViRHRKRzZEZENWWjZwWWZGUWI5?= =?utf-8?B?RDNyM2c4NFYrTTlRN1hRcjQ3eWphUFZnMExZMk9VS2Uzd004a1dvRXdkL29Z?= =?utf-8?B?M2c0U2FGeGZWZnpKS1daRzJIQzBZS051SjhOTnBJcWtXYTNjcTlvY1d5WWpW?= =?utf-8?B?T2pIa2dPcE1lUFlqQURrK3ZObTNLZkd4ZThlT2xWbU9XOWJsaFB4cDhmV2Fr?= =?utf-8?B?aGxXamxSWHg4TW9sYy9nNDNwSXJCOTJVV3V4ekM3YTA5SmFlb295MURGZnZk?= =?utf-8?B?UjcyZ2E4c3p1dGg2ZWp5cXpkZmxobERBMlBzY1NOeU5pMFNPU2xOR1JPZnZ5?= =?utf-8?B?TjZmTkZUNDNzd2x2MUgwcXZDYU8rc0EwM1BBMlBHWndSOGtUSmFBekg0cCs3?= =?utf-8?B?VEI0QkFFSm5qNWFZYTJhWnlhb3JrdUplMW5RSkZCQk82aFFLRW1yRnJlVGxM?= =?utf-8?B?NGJMdUI5a042MW9QSzhCWjlrUHI1MnI0b0U1cER3Y081bmZ1U3lFSXkxdVh0?= =?utf-8?B?cVNORkNhVFdZekFXdVVkNEpjK3g2L1dCZWZYUlFVUDU4VGpnNUovMkdiMFdY?= =?utf-8?Q?KO0zUIEKekHTsn3JyCWjvqfgY?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a7c97caf-94e1-4521-14e9-08da6957f2e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:26:08.4139 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ze96FF6RzUuWFMJbEj5YY8kzueM/kF1VLv4jKnxSXeG9pX9jrmgsCdiDOiIHrXgJB1s2ssIPKCrZ9WNck1QUjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5250 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTZW50OiBG cmlkYXksIEp1bHkgMSwgMjAyMiA5OjE3IFBNDQo+IA0KPiBAQCAtNDA2NSw2ICs0MDY1LDExIEBA IHZvaWQgdm14X3ZtZXhpdF9oYW5kbGVyKHN0cnVjdCBjcHVfdXNlcl9yZWdzDQo+ICpyZWdzKQ0K PiANCj4gICAgICBpZiAoIHVubGlrZWx5KGV4aXRfcmVhc29uICYgVk1YX0VYSVRfUkVBU09OU19G QUlMRURfVk1FTlRSWSkgKQ0KPiAgICAgICAgICByZXR1cm4gdm14X2ZhaWxlZF92bWVudHJ5KGV4 aXRfcmVhc29uLCByZWdzKTsNCg0KQWRkIGEgYmxhbmsgbGluZS4NCg0KPiArICAgIGlmICggdW5s aWtlbHkoZXhpdF9yZWFzb24gJiBWTVhfRVhJVF9SRUFTT05TX0JVU19MT0NLKSApDQo+ICsgICAg ew0KPiArICAgICAgICBwZXJmY19pbmNyKGJ1c2xvY2spOw0KPiArICAgICAgICBleGl0X3JlYXNv biAmPSB+Vk1YX0VYSVRfUkVBU09OU19CVVNfTE9DSzsNCj4gKyAgICB9DQo+IA0KPiAgICAgIGlm ICggdi0+YXJjaC5odm0udm14LnZteF9yZWFsbW9kZSApDQo+ICAgICAgew0KPiBAQCAtNDU2MSw2 ICs0NTY2LDE1IEBAIHZvaWQgdm14X3ZtZXhpdF9oYW5kbGVyKHN0cnVjdCBjcHVfdXNlcl9yZWdz DQo+ICpyZWdzKQ0KPiAgICAgICAgICB2bXhfaGFuZGxlX2Rlc2NyaXB0b3JfYWNjZXNzKGV4aXRf cmVhc29uKTsNCj4gICAgICAgICAgYnJlYWs7DQo+IA0KPiArICAgIGNhc2UgRVhJVF9SRUFTT05f QlVTX0xPQ0s6DQo+ICsgICAgICAgIC8qDQo+ICsgICAgICAgICAqIE5vdGhpbmcgdG8gZG86IGp1 c3QgdGFraW5nIGEgdm1leGl0IHNob3VsZCBiZSBlbm91Z2ggb2YgYSBwYXVzZSB0bw0KPiArICAg ICAgICAgKiBwcmV2ZW50IGEgVk0gZnJvbSBjcmlwcGxpbmcgdGhlIGhvc3Qgd2l0aCBidXMgbG9j a3MuICBOb3RlDQo+ICsgICAgICAgICAqIEVYSVRfUkVBU09OX0JVU19MT0NLIHdpbGwgYWx3YXlz IGhhdmUgYml0IDI2IHNldCBpbiBleGl0X3JlYXNvbiwNCj4gYW5kDQo+ICsgICAgICAgICAqIGhl bmNlIHRoZSBwZXJmIGNvdW50ZXIgaXMgYWxyZWFkeSBpbmNyZWFzZWQuDQo+ICsgICAgICAgICAq Lw0KPiArICAgICAgICBicmVhazsNCj4gKw0KDQpXb3VsZCBpdCBiZSBoZWxwZnVsIGZyb20gZGlh Z25vc3RpYyBhbmdsZSBieSB0aHJvd2luZyBvdXQgYSB3YXJuaW5nLA0Kb25jZSBwZXIgdGhlIGN1 bHByaXQgZG9tYWluPw0K From xen-devel-bounces@lists.xenproject.org Tue Jul 19 07:31:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 07:31:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370443.602211 (Exim 4.92) (envelope-from ) id 1oDhhh-0008BL-UT; Tue, 19 Jul 2022 07:31:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370443.602211; Tue, 19 Jul 2022 07:31:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhhh-0008BE-RT; Tue, 19 Jul 2022 07:31:37 +0000 Received: by outflank-mailman (input) for mailman id 370443; Tue, 19 Jul 2022 07:31:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhhf-0008B8-Vb for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 07:31:35 +0000 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cfa2c3e0-0734-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 09:31:34 +0200 (CEST) Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:31:31 -0700 Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 19 Jul 2022 00:31:30 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 00:31:30 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Tue, 19 Jul 2022 00:31:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 00:31:29 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.40) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:31:28 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by CH0PR11MB5250.namprd11.prod.outlook.com (2603:10b6:610:e1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 07:31:26 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c%2]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cfa2c3e0-0734-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658215894; x=1689751894; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=U9urn5LBzX7deftHHBmns6fZBycOG2pTxxCGfdTGXjc=; b=Fi0qRcXwQe7+v0laOuHsFCbj517yHYKXCUOGbo8wnUsrABg0uc1LHHEO jenbd5gCtjQ2TD81H8p57FzxXMrawN3nyqQjnAHOlnSsVTObvxCVMpOKv gknNHZopoXHBNoDqtpoBe3t1aKtVm4pPt5EvA9HWV32ZSEEmsBHUPHC8f ngJZnNPx+PW6aC8Gm5mjFrLNPBUQY3I+Q1P/Q7YdtfUtBhAs6GiW6MSI5 ZhgAol1lIbm35n4DNkDQYjYMYwbVs/hohDnigSnwITbv4+wb8Qivzimu2 4pBZQKFF+S6OGbz2jutbvODHcvyRiM4vekzh6X2BDJbErZCHDgaoCSEFY g==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="269443748" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="269443748" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="601495473" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GJchAt4JRf3fOXZIyjFRXOZajx3i8EkDbXW2u/pZCeBZGZDytk1g3o7jupTCwtG809jwXtnbTTp3IeJrkprCFAI9wb4ZNco/SzIgIX0OABwcSjpyFqI6FaSjPoGCo8rPDkSUBMPHyGNlQASVNunbnC8hvX9HRTw9hgNKElABME3rBfKXqis4N2PNCY1Fzubzai3qLvZbX5qv8SrJgyabZw4GNTRJV9/6Ws5bdmXeBDMYvCPH9McOzPz30G4Yl1FHF8kbOyvTbRuseOxHVVpJXNcuTu91Zxs6UYIPoiAIjcQx4XEHmQrW6ML51bKfnhpUxm+ccXKIg7sb+0UYES2UXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=U9urn5LBzX7deftHHBmns6fZBycOG2pTxxCGfdTGXjc=; b=XNim0R5b7yYJKyinfJ7Wirb8KmHU8hJNJv0Q+BK3K+zNz/Gsfb14AG/HbOyxubwWyalpPlWtRxCOqb0LUIcKU0PVULAfpSvBpKhhJTBR2ocbcRn9hRt2lo/xirnO+YpBninxtrTpdgaUqRIYskyQfDkufrwUfCyVxZMuLErg7Ba6XNOM+6XwOVofR/9W7lt7BfgAQsZQxl0i3Gv3hTFK1G/YLcj4lRbQX5VzlPJ6h9mqdodU9l/I8RbkJtA0bu8a2LR4lY0nl/Xn9Q4Sh9cbMQVuF3MWPgOY6EgPpq/TBNmUAR6bB31rbXCr1zb6ouYPxPjIRg6B9TIMewlqkjDh6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Beulich, Jan" CC: "Nakajima, Jun" , "Cooper, Andrew" , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Thread-Topic: [PATCH v3 1/3] x86/vmx: implement VMExit based guest Bus Lock detection Thread-Index: AQHYjUzyisX0+ExRGkiFh4Bp+KXF1a1t9f+AgAALFYCAF2Y1QA== Date: Tue, 19 Jul 2022 07:31:26 +0000 Message-ID: References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-2-roger.pau@citrix.com> <325bbf52-3b56-4062-88b5-a04dc21404bc@suse.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c909eb00-2f28-4cf4-ef81-08da6958b05a x-ms-traffictypediagnostic: CH0PR11MB5250:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: TmdZ36qX1ciFxrDJ5DeQA9zQc5WJ6PTRdpr+k2EoL7BXjRHFWDsha1J0xjtkGFH6wq9Tfu281lxKrruQ27xv/s3Rt0+Fb4441DLXozGrm4It8qTUiUJmLSiFRdUobF9YuZX37trzsHBpaV8XdoR/qLg/34kiJNO43m556id6y/5r+7NyRL8ulCXsyfyQ80hy4T39R6I51KJhTcOp3MoqGYwt0ArDMr7l0YDBOTm/Z3J16DI5VWfeQkmtUFmdxA5qyHZB1RjWr5uYUWir7FB63ptQPeyiNay+6FufRlRH03QH1s1vJTnwh561GwNMMi4phUhKmsNiKX60APFHX4N65+00BPFBZWOqJ9iHeoVlB4a1N8RRucMwAKTkcJWMjbKFbnk1kSj/Kl/Iz8OzHaUFEFVix6URqnKYYcXONGUymR85438nWrAEpnUa274o5AIRrh9PIrlzqj4gOlighc2RK68ZcGUe/HC0g40Suz7C9iGSA744LtV0u1RSgWzT7wHgAccLKNRuR1XXetfbuknY52fm0CqFVAryt0SZZuM7hq/MRrGD52+7Jmg8ZhTLt1QkgKC+3Z0yPmDrSBKRNHcXwuBWUWMsFwCPTr7Hkw7PA+OrLnfuQWa/lpUxgZcbKmf2JfJWSPPxF9oHWgxJPV7TKPtxEJGDTwqkSYn//lYc3objtY7zPWFKqs23Wra/0yz7gONJlBMPx/ClHSlhBsyWmwReigxZQta7FRIJGktkw2iTbU972LQ3ar6ov6shWb6MsWsTO+iWGvQTHn3CAyxbGbsrOHDdTjL4gRub5euwKu+balE/JCaKtUTzm1MxPgcF x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(136003)(366004)(39860400002)(346002)(52536014)(8936002)(4326008)(5660300002)(55016003)(2906002)(33656002)(8676002)(64756008)(110136005)(54906003)(76116006)(316002)(122000001)(38070700005)(53546011)(82960400001)(26005)(86362001)(41300700001)(186003)(9686003)(7696005)(478600001)(71200400001)(66446008)(66556008)(6506007)(83380400001)(66476007)(66946007)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NFVSSHdqM21pdG54QVZVM1dRbVF0SzNaazduWG5oR1Q4MDJ2RjRRN3VwKzk3?= =?utf-8?B?YmpOTTZDSGQwTzRYempOL09XeW80M1orQ0MxN2NBM05tVEVOcWpRTmRhY1hC?= =?utf-8?B?TjZBM05waEZsaGh0SnEvcWJXcm9sanFuaEpSSW5TZFgvM1RXaGJPcWJzeG9n?= =?utf-8?B?OVdpRUVmY2ozWk9FUGU3NEhvMjFISVc1aElVNDJYM29uN2x2anJKc05aUk5w?= =?utf-8?B?TDk0RXVBZ0ZVeFVmY0VVV3owSXpoZVNudTNUSVAyTzRLTXgvTGpYeVdEd1Fu?= =?utf-8?B?bmdKV0lqR2Y3WC9pUE1QUWtScG1KT1NYT3lSTTNHTUNqV3dtUlNIWVB5dXhz?= =?utf-8?B?VUtrZUt5eVdNbm91NG5tMG1LYlBqUXFFV24wNzhaN2xMdXpSVDl5RWZ1MzlR?= =?utf-8?B?Ymw2cHgrRmJZWHJBMmlRL3JNVGdjcmJWSFQzamx3ZFpEamJrN2NFL3J1VXNE?= =?utf-8?B?cDB1VCswTVdCc0xHL0FnVW9wZHMrUnZpZlY3dk1iMDhaQUc1Tkp2aEVORzZN?= =?utf-8?B?dmJpVy9Lams4d212ZDByR0tvT0dic0Naekdoa3JLOHBRVE9xOXAwWkp1b0dR?= =?utf-8?B?TFNlNURaelp0bW9XUXVwbFRPMklicnlvbitSNmZkZS95cnk3TzFkZkhPeUpD?= =?utf-8?B?ckpXaWE1T0Y5VGFTQnF6SDExbG0yazBxNzBhTVAyZFJOaVNVVG9QRWl0OTc5?= =?utf-8?B?SFVGcGt1VHh5OGNCbURweHRYZ2tPc2xia3JUWWUrM1NWTzhYakZpeXJRaURI?= =?utf-8?B?MVJ2azg3UlVWY0J0a3lCZFZqSW53THB6ZFc3M21MR3grdGE5NEFldjYzTzhQ?= =?utf-8?B?QzNFK0VwdEd6RDdQWGExRzMxb1VJWjdpdndseGtqck1FNzJNYnJGY21ZbUkz?= =?utf-8?B?cDlNNVhNWkNlTzlWWW9PNWh4OGxDQXZ0dWx6M2h1cXc2NWxWN0Jsbm9ibXRG?= =?utf-8?B?Wi94bm1GTXc5cGgxaUxqSEJmZlE0VEFWQUdvcDJUN2RSQ0NCOFNZc0hSSXg4?= =?utf-8?B?YU1lNnJKYS9FNmJ0VkxSdmxEUzl3SVJ6dlFHNld4bll3bWRhZDAvNVV1L1Zi?= =?utf-8?B?MXVDcFAvRkt0enhvZnFIcmpUdU8vK3FReElvN29Hc0pWa21jaGE5NXlEVzF1?= =?utf-8?B?WFlPeDlOQTF5Q0NDcWtlMEc3eWZ0ZmJzKzB4eFYwZklaZzAzY2ZoK3RieGgw?= =?utf-8?B?bVhJeTV1WERacHpDTXZuMXNkMm9Jd29oUUpjSG9sNytvOC9lR1VORkxlanpp?= =?utf-8?B?Y3lLUnZ6TXJIb0VTaVlzMUJadjM3dFpSNVM1YjYxZUpSVWlEYkFGNHVKS0o1?= =?utf-8?B?aUU5ZFVhVnlhekdIcEY0allvNzlaZzMyWDB1U3ZpVlA5eFNLUG11Y0pNL2Q4?= =?utf-8?B?cjIrOHlsYk1XdmRVOHpUMkJqRlZSVUd6dnFZdk02eU81aHpuVWhoOXF3Rmw0?= =?utf-8?B?NFYxQ1BpWEFwZjlhSVlkbTk5TnlIbURIWWVwbFNTNGR6TStqSW5CS1c2Q2NQ?= =?utf-8?B?Uld6OU9kdFRJcWx3WVU3a2tUVUNpZlljQWZWTXZ1SkdJbVNBa1RLNGNOc2pz?= =?utf-8?B?QmhkbUUyVlh6b1h1OXozL25QNkV3SGJJMXFzbzRrYmRZa0drVHRZcGNkYUxr?= =?utf-8?B?SXoyOVRrdG8zZlN5L3FMdTd3SXUxdmVpWkg3b1lnajVjdi8wOExMR2hETkZS?= =?utf-8?B?TUdJNUttYU95OXYxTUFyOHpoK0lkelEyOTRtcndFL1VKMkFpWEl6VUszK0hY?= =?utf-8?B?UmdjcmN3VHFaQVV1T3g3cU9pcm9ZREhoT0VYcU1UVUUyQzd0WVNlZHM4dE1O?= =?utf-8?B?ckFzakVNclVSV2F3cmwzZHFiY09qQThWcTRNNG5sVGZva1V4WVpjQW5GVFMv?= =?utf-8?B?My9uWGRMSVRQUndBS2djM05iNExDRDdaOFJzOGVQQ0dHbitRb3J3dlN2cVNq?= =?utf-8?B?d1hIVURVUlhlVUYrVXJnOCszYlNtYVNJc0hrckRFRmJxL1FXcmM1SFZLSWZU?= =?utf-8?B?aHBmZHM2VGprUWUvOWlqNHRLN3M4em9qbksvbUdIZzVHT3dYWSsydldIQ2JZ?= =?utf-8?B?V2x5d3BlWU9rc2ZKUWN4ME94OWJGWlpubVRTMVFGOUZ0M1VseEtWWkE4L0c5?= =?utf-8?Q?g0VKvT/Sj9hF4g+xmC9YQz/ca?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c909eb00-2f28-4cf4-ef81-08da6958b05a X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:31:26.2822 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: o9odf1OJiiYmV8SjYASo7VZwAqySYOI1AVLkPH2RrUNewXxjbyIM20mcH86QTQ4ZauOAAJEIlao+kaPsUCYhaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5250 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubsOpIDxyb2dlci5wYXVAY2l0cml4LmNvbT4NCj4gU2VudDog TW9uZGF5LCBKdWx5IDQsIDIwMjIgNjowNyBQTQ0KPiANCj4gT24gTW9uLCBKdWwgMDQsIDIwMjIg YXQgMTE6Mjc6MzdBTSArMDIwMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+ID4gT24gMDEuMDcuMjAy MiAxNToxNiwgUm9nZXIgUGF1IE1vbm5lIHdyb3RlOg0KPiA+ID4gLS0tIGEveGVuL2FyY2gveDg2 L2h2bS92bXgvdm14LmMNCj4gPiA+ICsrKyBiL3hlbi9hcmNoL3g4Ni9odm0vdm14L3ZteC5jDQo+ ID4gPiBAQCAtNDA2NSw2ICs0MDY1LDExIEBAIHZvaWQgdm14X3ZtZXhpdF9oYW5kbGVyKHN0cnVj dA0KPiBjcHVfdXNlcl9yZWdzICpyZWdzKQ0KPiA+ID4NCj4gPiA+ICAgICAgaWYgKCB1bmxpa2Vs eShleGl0X3JlYXNvbiAmIFZNWF9FWElUX1JFQVNPTlNfRkFJTEVEX1ZNRU5UUlkpICkNCj4gPiA+ ICAgICAgICAgIHJldHVybiB2bXhfZmFpbGVkX3ZtZW50cnkoZXhpdF9yZWFzb24sIHJlZ3MpOw0K PiA+ID4gKyAgICBpZiAoIHVubGlrZWx5KGV4aXRfcmVhc29uICYgVk1YX0VYSVRfUkVBU09OU19C VVNfTE9DSykgKQ0KPiA+ID4gKyAgICB7DQo+ID4gPiArICAgICAgICBwZXJmY19pbmNyKGJ1c2xv Y2spOw0KPiA+ID4gKyAgICAgICAgZXhpdF9yZWFzb24gJj0gflZNWF9FWElUX1JFQVNPTlNfQlVT X0xPQ0s7DQo+ID4gPiArICAgIH0NCj4gPg0KPiA+IFRvIGNvdmVyIGZvciB0aGUgZmxhZyBiaXQs IGRvbid0IHlvdSBhbHNvIG5lZWQgdG8gbWFzayBpdCBvZmYgaW4NCj4gPiBudm14X2lkdHZfaGFu ZGxpbmcoKT8gT3IgKGRpZG4ndCBnbyBpbnRvIGRldGFpbCB3aXRoIGNoZWNraW5nIHdoZXRoZXIN Cj4gPiB0aGVyZSBhcmVuJ3QgYW55IGNvdW50ZXIgaW5kaWNhdGlvbnMpIHBhc3MgdGhlIGV4aXQg cmVhc29uIHRoZXJlIGZyb20NCj4gPiB2bXhfdm1leGl0X2hhbmRsZXIoKSwgaW5zdGVhZCBvZiBy ZS1yZWFkaW5nIGl0IGZyb20gdGhlIFZNQ1M/DQo+IA0KPiBUaGlzIHNlZW0gdG8gYmUgYW4gZXhp c3RpbmcgaXNzdWUgd2l0aCBudm14X2lkdHZfaGFuZGxpbmcoKSwgYXMgaXQNCj4gc2hvdWxkIHVz ZSBqdXN0IHRoZSBsb3cgMTZiaXRzIHRvIGNoZWNrIGFnYWluc3QgdGhlIFZNIEV4aXQgcmVhc29u DQo+IGNvZGVzLg0KPiANCj4gSSBjYW4gc2VuZCBhIHByZS1wYXRjaCB0byBmaXggaXQsIGNvdWxk IHBhc3MgZXhpdCByZWFzb24gZnJvbQ0KPiB2bXhfdm1leGl0X2hhbmRsZXIoKSwgYnV0IEkgd291 bGQgc3RpbGwgbmVlZCB0byBjYXN0IHRvIHVpbnQxNl90IGZvcg0KPiBjb21wYXJpbmcgYWdhaW5z dCBleGl0IHJlYXNvbiBjb2RlcywgYXMgdGhlcmUncyBhIGp1bXAgaW50byB0aGUgJ291dCcNCj4g bGFiZWwgYmVmb3JlIFZNWF9FWElUX1JFQVNPTlNfQlVTX0xPQ0sgaXMgbWFza2VkIG91dC4NCg0K b3IganVzdCBtYXNraW5nIG91dCB0aGUgYml0IGluIGFuIGVhcmxpZXIgcGxhY2Ugd2hpY2ggdGhl biBhbHNvDQpjb3ZlcnMgbnZteF9uMl92bWV4aXRfaGFuZGxlcigpIGJlbG93PyBUaGVyZSBhcmUg YSBmZXcgb3RoZXINCmdvdG8ncyBhbmQgcmV0dXJuJ3MgYmVmb3JlIHRoZSBwb2ludCB3aGVyZSB0 aGF0IGJpdCBpcyBjdXJyZW50bHkNCm1hc2tlZCBvdXQuIEhhdmluZyBidXMgbG9jayBjb3VudGVk IGV2ZW4gaW4gdGhvc2UgZmFpbHVyZSBwYXRocw0KaXMgYWxzbyBub3QgYSBiYWQgdGhpbmcgaW1o by4uLg0KDQo+IA0KPiBJIHRoaW5rIHRoZXJlJ3MgYSBzaW1pbGFyIGlzc3VlIHdpdGggbnZteF9u Ml92bWV4aXRfaGFuZGxlcigpIHRoYXQNCj4gZG9lc24ndCBjYXN0IHRoZSB2YWx1ZSB0byB1aW50 MTZfdCBhbmQgaXMgY2FsbGVkIGJlZm9yZQ0KPiBWTVhfRVhJVF9SRUFTT05TX0JVU19MT0NLIGlz IHJlbW92ZWQgZnJvbSBleGl0IHJlYXNvbi4NCj4gDQoNCg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 19 07:34:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 07:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370448.602223 (Exim 4.92) (envelope-from ) id 1oDhk2-0000MY-CZ; Tue, 19 Jul 2022 07:34:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370448.602223; Tue, 19 Jul 2022 07:34:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhk2-0000MR-9T; Tue, 19 Jul 2022 07:34:02 +0000 Received: by outflank-mailman (input) for mailman id 370448; Tue, 19 Jul 2022 07:34:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDhk1-0000MG-2c for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 07:34:01 +0000 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2655b13d-0735-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 09:33:59 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 00:33:53 -0700 Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 19 Jul 2022 00:33:52 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 00:33:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 00:33:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 00:33:51 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by DS7PR11MB6016.namprd11.prod.outlook.com (2603:10b6:8:75::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 07:33:47 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c%2]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:33:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2655b13d-0735-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658216039; x=1689752039; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=jufNV3nxQkFwocZat4wcTsVyyuEHjh01WxwsvJNYDGI=; b=CTmgyy0hCAEns2GVD5rDwMSEzw0Vz//dMlwlqoN+K4/T2pTtj307bgcu wxUHAiRSfr7X2Iwl8UVc5yqAIIAp5zEK5wzexHgSVxxg+dJvJMVrombLZ 3n52QWB6z0a7Kl6B7l9WVx88ocD6X61Kc+IvSl/2YqXi75rHMbt9M0Q4K jfw49u8AowWW4YD0HOOhX3QoM69ssSuE5tcZIWJoBtJzM1ImBB5liIeTF 8jnyCo0Hph0Q8ipy2eDAd7uvFNBlMJAYLSgXoxYNoZk1d1S/61Kbr5JSX z+BkE9hj1olGHXjlp5mHK0cvELe6VLFv/jj3DFJaTBSHyrLBoMw3KKhpT w==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="266821746" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="266821746" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="665326433" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k5zi4Zws0niGOpUXIfoTy9MMa2g7IAD9r6tkrijjUHNIXDz6BlFQNr6C5JHeckCraXju9vF1PeEtvox7VQbULSl28+7192dld4AFsgADV6Ng1AQwJF4AvD9iABznduAcmUS+uMX/BA3UCnV2jYiB+F0XqZ0RPvRY0vomKe1TFhSLjX0vhUpLjiA+ARvj0t+Y3LxDewqFwwj6i2uaJkEY3MRjGkjrw2HbN+mVUGZ3JgPsgj7IYsUIGC0tG8eKZ9Zslz9UudjgwCODtsb/MDOCgaTb0/D0q6esdRHz15mw4c7uQCURmfA+PH5tHQJKDSTr9dz9dcS+eBoH0rzzf7HpYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jufNV3nxQkFwocZat4wcTsVyyuEHjh01WxwsvJNYDGI=; b=KPKGSsHt8GeV0l8QpZ0rVBI5yPKgcLSZlt4qli5uBcrVG3MQwwNRhwX1A/jt8te3tCvG2Wx6VwA45bJ+hhTvaw57fZTM5IyiYqJqMnJgESh5lWLHAHME7hiuUvVpLX3mI2dm3qfYa+Q5Nl4smmX6wMuiiFKfWqXZo5lB+eypMwZ+Kj1auC6wRmiWjP4ZuCGuYYcecMf+mWq57uXz95d+FwoLfPj3ahpz+FAbuNFM3daP3syIaU+psz5H0mYX3xri9TmIk7mT0pM+2pRJhf4Oi0IPHH0ZnENNeEUXFI+7rpLB2BJRaUo2St75dVQf3wBwIE5wXFZ9gKZ7NjJyusWfVA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Nakajima, Jun" , "Beulich, Jan" , "Cooper, Andrew" , Wei Liu Subject: RE: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI Thread-Topic: [PATCH v3 2/3] x86/vmx: introduce helper to set VMX_INTR_SHADOW_NMI Thread-Index: AQHYjUzyHVJg5Vl520WKm8Qoee4tTK2FaJfg Date: Tue, 19 Jul 2022 07:33:47 +0000 Message-ID: References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-3-roger.pau@citrix.com> In-Reply-To: <20220701131648.34292-3-roger.pau@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 6a4479a5-22c8-4d90-fbe2-08da6959049e x-ms-traffictypediagnostic: DS7PR11MB6016:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: JCWNuRAHUHEK6B+xbwNGv1oSzX/dhzF5qvc0CiQ99xKivclKe8HdZqH90YXXcs0afDKg/9pbAdAAbdho6DzvSHDUxxAJ08Q9Gx5cVKd0KuyXFBzKljy73AWmCKkSzPfawuQblnWFso+E4mu08W94L/7HQGE/pbzaL54kvOGT5nWKuLfKyBac61bpLnCXpWaTL1VDC2xS+x+HrIAWgEEqOKGHvvsWXddExUEjjFMAhJQHoYSzgMST48sJwA6zwn1WKH1tG52Oy6JGr1dByQzbZkIs+f+LpEZ1AkX3RFhi9rHmlM80LM11OwULDqlgxX0pp/Ze3U1ykIxyjtFsTZfRuTPXdssJ4PZyx5q9lDFnZwBmn0rE8mYqYGS+CJHymj70AX8QhgtyaoAIdjfOtAYQY/4e64d2Apd1v8Yd4uBG+V5tlcF1iQgtXDHgc30c5p47B6Dm85PKAVRoz6og834N3K4al67MjSyQVvwnnBE0IK5Rs6aSdgkhb9xpuLol/7ecpcugFl0fF02ax9nqhRIo070DlWRU9PHNuBPtEn07Yw3Gb2qIf66NSDy47zGeozNRlp+lCGktkfRqKzd6E2ZFqpm4Y1nJLtz+GKvfkk7bmyncffxbauuE1xqEJsWPexChcrgQNFCKwd/TfIO7RgP9N48HGO9i35HwE5jVfgYr5zt9sKR2F90GnRNrp2bRFp9LrOW5BJtpJlF1yt6SSXfXjVdX3l3OFUWVbas8Az0MDqqb+0rj8VAtYOO/27G1IhoFaO8gLWJFVtCUQVjzE2/cVMXil6ebJbfNy5in8AwA1LRGhWCIBX6mgoHAP0OEs3wI x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(396003)(136003)(39860400002)(376002)(52536014)(5660300002)(64756008)(8936002)(55016003)(66446008)(33656002)(2906002)(4744005)(8676002)(316002)(66556008)(110136005)(86362001)(76116006)(41300700001)(82960400001)(122000001)(66476007)(26005)(71200400001)(186003)(478600001)(9686003)(38070700005)(54906003)(4326008)(66946007)(83380400001)(7696005)(38100700002)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Snd6bW9IYy9FVlVuamJ1U3RqbERTOTJiY29JNmZvZDdmNU5GV2JuM3NFVE5v?= =?utf-8?B?dVZKRUtvR2VQS1FoTUVOT2J0dXdvL2FtZXZIUHNLQWJONGFUZERLUGxnV3Zk?= =?utf-8?B?RHFaV0pkMzRQYzhUeTZiQTk4Mnl6MVdCUnhSZGxJb08xdzRzNHA0KzRwRHZx?= =?utf-8?B?dTBZT2lxTnp6b2lMT3A3QkhoK1dzT3IxR0hiOHAxQ094NURnWDE4dndVOEdS?= =?utf-8?B?aU1GT3ZIdDF4MVRRTElkaXZ5UHk5UnFOc1ZPUkxsd1BaYlY1RGNOUEFheFNV?= =?utf-8?B?bGp6RVFMZGtGd0k5T1lqazNQQ3JSaFJWOEJLU2JnUy96QmUyS2RWSUlCb005?= =?utf-8?B?alM0Z09WTWhib0N4dUhTbDJjemhMRWNuZUlQS1hIZWJxZFF0QUJSTFpzVzV6?= =?utf-8?B?ODk5bEVzVGpmUlRraVFwZFNGL3RScVJ5eU5XdGppQVA0YjNOTE12c1JZUDgw?= =?utf-8?B?dEVZZjI5WTNkdkl2U0R5MURrdmkrMEhIblYwTDJpZmtDeXlZNFdhY3ZxWnZW?= =?utf-8?B?Q1JCOEhxeUdMU1lGT1ZBNlVNK2xPMmNQZTZ5Vjk4SXY2N3FFOU5Gci84bGxL?= =?utf-8?B?ek5VWE9TQlYvOEFYTk1ONHpwdFppYzNETXZYc0hZZHIrZTdWR0g2aTlQWWlv?= =?utf-8?B?T2tHZ1Z3Y1B1NGxZcEJ2QjVaZ3lWMEttNFhvOXdmeFk2dFFTRDBMV1JuVXJW?= =?utf-8?B?cUV1aUFUcnVjeFNqaitGWGU5VnBsZzNkSG84dDFxZTZub0EwY0p5ZU9sMmZ6?= =?utf-8?B?NjIrcUZLZEg5OU5oNEljMll0NDJDTk5FWkZqMThqYzcrb21EUlRXNG0rWWlU?= =?utf-8?B?bmVQOGxyU29jbnpRYldCdGd3cU5YM21vdjU5c2JyVDVXaHNJd1M4THJBOTVI?= =?utf-8?B?UnZMN0w3YStMeXFxcHlpVWFQaUlQWXFoYXFCa1lUcTYvNmt0aW0rS0RTUk9m?= =?utf-8?B?MWcwaUs4eVlSRGV6VDBRSm9zNzcyODFkRzBmTVd3WFpOdlJrRGhjWDJqUDg0?= =?utf-8?B?Y1ArRGNoZDd6Z29WMEFOdU1uS3VNVFRXVTFYT1VwNUVJbTFyQzBOWnhVNVlj?= =?utf-8?B?SjVIeEZQL1NKYVNjL2E0VGEyKzRyZURncksza29BR1pjaldYMTdyS0FXS3Zi?= =?utf-8?B?ejF6eUpnKzQ2RkdkRjJYQ25UV3RVQ2pPQ2o2SzJoZ1BabXVQdDRBd2h4ZXAr?= =?utf-8?B?THlqQTJPRkE5QndNV3N3VThzMTlaQTgrejFOcGdQanM3cmN4U3NpdnBoRkVG?= =?utf-8?B?UHhDN0x6RVRLV3NrU20rME1saU9KM0NTY2luOXBPMVZSc2hLK1hjK2VlTmFD?= =?utf-8?B?SWNGbk5DWU14bjVPUkw1a1NvZUJ4SXlJdDluUUplSCt1MDJnVW10ZnV0OUd2?= =?utf-8?B?ZVJGSENUYko0WHdjdnpaaUU5NlhxVDJLaGRlQlpodUFCZFJJaEVleEFsUEN0?= =?utf-8?B?TS9Xd3g4NTVJVnBCelQ5YUVwNlRDRGwwVG5Cb2VYWSszRElTS1JtQ3psbkRa?= =?utf-8?B?ajR0RjlMZHhTU1FlQXZ6Nks0UDhXK2xFU0FTK0FUVmJOWHl1bEtIUS9PZk9N?= =?utf-8?B?REVBOHFJZFY1d2twK2xNVjlzRm50TFNSWlNGVkFpZ2pKUGZ4UGt1MWhDbmp5?= =?utf-8?B?cENHZW0rYS8wVGFkcVZ6RWNNdzFUcXNiVjdtejc0SXIyNmppRUVGVHpYS3M4?= =?utf-8?B?NEt4OUJ1aDlvSS9DRGlaZHNObkFsNDA2OHByYkRXNkZzTFJVbzBVMlhKTEtJ?= =?utf-8?B?YUkzKzJSSVdoWlIxQi9NeWFGeTV4aWpmYjN1TDdZY1RBTlBkS2x1U1Avb0ZZ?= =?utf-8?B?R053c05iQitVNVhWc214eTVvR2NQeDZEQy81SWlQVVpjNURIYkVJT29aZ052?= =?utf-8?B?T0FxVXpTbENoWk1SQUcvU0g5cVgwUjEzbEo0VXVaQ25BakR2MnhDakpodUFr?= =?utf-8?B?MzJrWGxKOVBWQ1hQVDlIWHNZbmdMMGVtVmtta0JRMnJBUkxzbjRJZjBPdFR3?= =?utf-8?B?WnQ3c0pZVW5DeGtKU0syQlM1ai9zTEM4SzNjY2tRdWtYdVFWdXhiZHVHb1NW?= =?utf-8?B?amhEVTNMV3FiUVdpUy9nekl4cWVJOVp3NmJwY1V6TEx5YUVCYkh0K0tXY25t?= =?utf-8?Q?98VKzsb8NN4tAHzOLfDRtMpJq?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6a4479a5-22c8-4d90-fbe2-08da6959049e X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 07:33:47.6255 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FBvETTPFNnFie9cAcYQpGtUbaQyCJULoMA/KeV80VcMdrcHCFEzpRun/NwJCgBQhjSYT6MIVgQhSVW5YT7lxmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6016 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTZW50OiBG cmlkYXksIEp1bHkgMSwgMjAyMiA5OjE3IFBNDQo+IA0KPiBAQCAtMjI1LDYgKzIyNSw5IEBAIHN0 YXRpYyBpbmxpbmUgdm9pZCBwaV9jbGVhcl9zbihzdHJ1Y3QgcGlfZGVzYyAqcGlfZGVzYykNCj4g DQo+ICAvKg0KPiAgICogSW50ZXJydXB0aW9uLWluZm9ybWF0aW9uIGZvcm1hdA0KPiArICoNCj4g KyAqIE5vdGUgSU5UUl9JTkZPX05NSV9VTkJMT0NLRURfQllfSVJFVCBpcyBhbHNvIHVzZWQgd2l0 aCBFeGl0DQo+IFF1YWxpZmljYXRpb24NCj4gKyAqIGZpZWxkIHVuZGVyIHNvbWUgY2lyY3Vtc3Rh bmNlcy4NCj4gICAqLw0KPiAgI2RlZmluZSBJTlRSX0lORk9fVkVDVE9SX01BU0sgICAgICAgICAg IDB4ZmYgICAgICAgICAgICAvKiA3OjAgKi8NCj4gICNkZWZpbmUgSU5UUl9JTkZPX0lOVFJfVFlQ RV9NQVNLICAgICAgICAweDcwMCAgICAgICAgICAgLyogMTA6OCAqLw0KDQpPdmVyYWxsIHRoaXMg aXMgZ29vZC4gQnV0IEkgd29uZGVyIHdoZXRoZXIgdGhlIHJlYWRhYmlsaXR5IGlzIHNsaWdodGx5 IGJldHRlcg0KYnkgZGVmaW5pbmcgYSBkZWRpY2F0ZSBmbGFnIGJpdCBmb3IgZXhpdCBxdWFsaWZp Y2F0aW9uIHdpdGggYSBjbGVhciBjb21tZW50DQpvbiB3aGljaCBldmVudHMgaXQgbWFrZXMgc2Vu c2UgdG8uLi4NCg== From xen-devel-bounces@lists.xenproject.org Tue Jul 19 07:51:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 07:51:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370458.602234 (Exim 4.92) (envelope-from ) id 1oDi1E-00039E-1t; Tue, 19 Jul 2022 07:51:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370458.602234; Tue, 19 Jul 2022 07:51:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDi1D-000397-UC; Tue, 19 Jul 2022 07:51:47 +0000 Received: by outflank-mailman (input) for mailman id 370458; Tue, 19 Jul 2022 07:51:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDi1C-000390-Hf for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 07:51:46 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a27d1069-0737-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 09:51:45 +0200 (CEST) Received: from DB6PR07CA0063.eurprd07.prod.outlook.com (2603:10a6:6:2a::25) by VE1PR08MB5789.eurprd08.prod.outlook.com (2603:10a6:800:1b3::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Tue, 19 Jul 2022 07:51:40 +0000 Received: from DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:2a:cafe::26) by DB6PR07CA0063.outlook.office365.com (2603:10a6:6:2a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.16 via Frontend Transport; Tue, 19 Jul 2022 07:51:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT017.mail.protection.outlook.com (100.127.142.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 07:51:39 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Tue, 19 Jul 2022 07:51:39 +0000 Received: from 6f600144d5a8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E0E04BFC-438A-4151-ABDB-143DBDC5B0E3.1; Tue, 19 Jul 2022 07:51:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6f600144d5a8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 07:51:32 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB4712.eurprd08.prod.outlook.com (2603:10a6:10:f4::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Tue, 19 Jul 2022 07:51:30 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 07:51:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a27d1069-0737-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cbLQlfaY+exoQq7tWGwAshMsXlfWW0oF6dSOUGwFoqFfOMTR24BVnNC237+AssknWc9/WATKq27nstFAVpUXsXuu2/+lvrLVOmoZYzd5rRrwO4OrOxQrTLLI9I0kLe4hQh3GDxDylTlLrMBesjxrfzDn666AnWWnC4yMHBJHJ00aoVTkV0afcCvcuuUjWH0Wn0vZTzIMnjxZBO0m5UM7fjPgLMaWC5sfT7EMW1Bvx2eZAG0XKmngWWmMp0serN3tdmiVYb6Ky9BvuX2s/o3cC5uVv0UP2xZgdDd9T0UBEQqMGvuODb8/fxGcYeftVkm8R+VUVXamcfgTLdmhqOOGSw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yy5wchmBugCj+9D+Gp2kjqj+kp1a8D0a0MeOcskbhg0=; b=M1/Z6aZ8LHcGvtP/OE+T//P/EqHfq6v7LaxALtWU9+MgdnmoNQzyYEreeGjDQz0rx2klAh26Uu7/a6qBPGux3OJNrlW5vrcd4UmijgY0S8RYNPG5wTEsMSI13Y33oaI6bdSwfxh0EZcFUVVkFFRUny0CfTAtWl5S414gEUgv+kOI9ZUM273HZTAJDEWpgINlh1qR90+xm9GmoKYQKp+2hRHmQDwRTl7VNDCPxLRCoetqEojySBNFluTEn1mIwarvaS3Fuh8F8rTSAbmVKVexXjpQVD5+NGKJMkA4UHobyrQyJ9OGMnRkchE/aVrzW8V8J47Ylw7WSSPm/V3OA3E+Ig== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yy5wchmBugCj+9D+Gp2kjqj+kp1a8D0a0MeOcskbhg0=; b=RZQTnyngJC1qIF7KTYzsDdW3C/egPSpQqYa9ZX5bH6JHHGHd/YsJuSwn8x3jKcYrmhHshR9YJK8hZMtQIUifWnzB8tJj6hwtmC9222Q1tMHfH+NgXPm+tVikXuZyT13FHLzkydd9eUjQ2ftRHd825GmLyY9vYxhOsCLbOuSOrtM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: b81f1e0e5b493895 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UYYKpbEvt3DMkEmo5ECl0GzAtRnwQ97Gf3CGKqtYg3gxRXCwUeDt8Z5Zs2teL/jPR/EgBXxiQAw7bGZDQifu61JmI2NxaEnnElaunws9FjcVuY4vg7YkG1Lm7d8xlYUC2AkQphnDSJuWg9xNPhkYTui8ACSeUHCtlOZXoIVOrErisf9hWgOhoD1P85WBe0BzBXWyoaHTFW3v9LiCmWOp8KexoWi+J58gTpyuo4xSqpmcVzmc2f3weaua7VxR6xOJ/cvUhcflP5engeASPSqb3fS8A9tWOrZVwDR4+5fhq2JLN5HgcYMPZwYDfsyqiKtxGBA0my3QS2hNqewebMsYxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Yy5wchmBugCj+9D+Gp2kjqj+kp1a8D0a0MeOcskbhg0=; b=XD4okBeo4tKLIIK+vJUmSj1+6Ul8I3bWDePDmtCNHYVf31+dDL3BU+VM0lZEi/K8STa0NHyb7+73IL94mUsA1ynpsNNp4ZB4KsTE968hWzBkafruf1tqqz2srZXNSFIAbgLFl92etGBzdGy0qsCGFYkILVcyMywDjto5phfmagu2Hy9OGs9lvg/Wu+dFKz76I6zX9kvGF1llUC+A8VPcL8NrWFRurcLblVLQcGIPr6FEiIXCgYrj186gIB/34rqpVBseh33+LIaqBgKxpO41Wi0cFG1oHtnebIUlD2+xeOz8sLyUO5NYGbRJmlBD/QIBAUamcicZdiXapmhJww2Ggw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yy5wchmBugCj+9D+Gp2kjqj+kp1a8D0a0MeOcskbhg0=; b=RZQTnyngJC1qIF7KTYzsDdW3C/egPSpQqYa9ZX5bH6JHHGHd/YsJuSwn8x3jKcYrmhHshR9YJK8hZMtQIUifWnzB8tJj6hwtmC9222Q1tMHfH+NgXPm+tVikXuZyT13FHLzkydd9eUjQ2ftRHd825GmLyY9vYxhOsCLbOuSOrtM= From: Bertrand Marquis To: Christopher Clark CC: xen-devel , Doug Goldstein , Stefano Stabellini Subject: Re: [RFC PATCH 0/2] Yocto Gitlab CI support Thread-Topic: [RFC PATCH 0/2] Yocto Gitlab CI support Thread-Index: AQHYl2nwBpPj9ZB3akSbFdgxyjmZtK2FItmAgAA3CIA= Date: Tue, 19 Jul 2022 07:51:29 +0000 Message-ID: <489E5D0F-C554-4333-9191-AA759E31E69D@arm.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: cb3d8160-dd39-493d-7df7-08da695b8388 x-ms-traffictypediagnostic: DBBPR08MB4712:EE_|DBAEUR03FT017:EE_|VE1PR08MB5789:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: CGsw4KwTJZXxssFxUk/Ar4V0NB2zjiLyweQCjVP7Rvdkt8kns+Q4U28erdQaGzycF9NsQFSks8inL5TVkaCuYixnG21oUBDE/M/Qzp91ilV95cDyK2MwRJmDmPnKWn/vtO4TfzBP3l2wZMIzClh9AHlsRVXfgTIXQOjPZ1A4G4uXhvbgFuoRd1mjYWKnCgSTM8NnIdtFnv1mrdGvDs/3TJNoO6Ofjgp3vsFbC6cb7Kq2yRoqKt1AbtlMPWQ09DmrCJ+Kj4pa2LhLEvjzwDq7d5slZv/vq7VOaWtOKrusbOEjKz7i0BqeSLqTVfmecrUN6wQf+R6JjnRXnw2h7QfkTl2q5HicER5WfpeYUnttCB4cQUaSb4NugQhQbiwi2e+fYLW+Hh7PFN2opTWa9bpXvpRiTZbC23O727raVd6Q7SSnbYBp6AaGTB4vb7WA+hEwwZpwZDgP0YeCWHeCoQVYBc4EOLaGcoZjIo1U+wAcW3H9ehfvJjZaa1XDg2atitHaMKCG3IjdmqJq+9gb5IZOT0OOdD9rNdXsTwoM4hz7S5dpsHSNu3EArxkB36bY0ce3mHWy74fKNqjvibcl66f2ot4iXrM7rnVnIR3i+n+hnm7rAP/s0tkV1lWllhSAsM6noDDOkAn/PK6k34qR8mGq7SjLL16XXqhwCoXhNAHqM75ovzz+3r+PLx4MOCSCf6etKTJCaZopDkifwHmvYkVINMILwJ/rhlgnZdny55Tz4azZLHOnhKRaCKQv0KrvUfYgSCdKiSvAXDA+At9ay/6re0od85BSNVWJZIP3ws7YBV8e5dnI7+XzlExCjHAdTq1sHAJpoA8csJeHwC+T0YtqmA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(396003)(376002)(39860400002)(26005)(6916009)(6512007)(122000001)(186003)(41300700001)(64756008)(33656002)(2616005)(36756003)(66476007)(54906003)(478600001)(6486002)(2906002)(71200400001)(86362001)(76116006)(91956017)(316002)(53546011)(66446008)(38100700002)(83380400001)(8676002)(5660300002)(66946007)(4326008)(6506007)(38070700005)(66556008)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4712 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 181323bc-cbae-415e-80d2-08da695b7dcb X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: thVPodk9lzhwTHC08fSpwNmPWcftgfhB0DoyNXAqhjD/0llSbQAe3NHDT2UBZiXklliQoyisTm8oN1Ad4MWsI3GY0mYdXPBcNcx36pvq7Jwbi9ya1B00xmfM8fP06LOTqPYG9xCWwEsa4aGrrfJmu8SCQjpldvd+9wKHhDOJOCa9DGDn8LwpGZJwFLUW+5fpfKouPLhMi3YhJxcG9uv3Ht9gZCWzAi2S2qRGK6UGPI7ef0KuGOZA8LkNi/lgI0e+eVur7SQUkYVTHJ3nogDGTaRj+KwRO+/bJa7OULV7XTA9qlsGvglOKWjQdZgbwshXap9iE+hFFot7M8sdpBX4hNf4S5+Q9Kz91M1cIjMPSmlWMXX2zBtR5af+5m7DJWb91LdO+IgZE5td5JGN4kZTX0e9VQklytu65BSLlHnu0Eu8zBv28bBWQbAWCxlhTtiIqQgXWR3G7HZKGIuJfWS4GoCK3gHHBJTsLZdNiJeRCzp3tawrDbxWsjIrAjTlX6FevBlPSktLuXeSqgm0M/ptvmoy/KEV307faZeI1UjcWFTxDq57Dj6HqDpAWnR78uwpwtMN+idsI0jDyHn/PfuXdWfrHPDy5mFQwHSjGcURdpuI4vzsYJLGJ+D95ewbUCyhcB7+Es6U914X1H+5oK//W6mn+rKpmU4FIQVS6pWcNpV8/tuWZCgXQQyLpIyxoHzYeDbbWRiuHvQnMHWlRy4BPTcpKXrsaEuJSYKXAZ7dwg1arc66SS4rY2wqTCbgigRQZ2NzJOIYgyJTs3kLi2xlwKksKwMZRZsQmyFpUnmNcWHvxDjdbMLkSL0Jnv0gtxBc X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(46966006)(40470700004)(36840700001)(6506007)(53546011)(41300700001)(26005)(6486002)(336012)(47076005)(186003)(478600001)(40460700003)(82310400005)(2616005)(40480700001)(107886003)(83380400001)(2906002)(6512007)(8936002)(54906003)(70206006)(4326008)(8676002)(70586007)(33656002)(82740400003)(5660300002)(316002)(36756003)(81166007)(36860700001)(86362001)(356005)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 07:51:39.6047 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb3d8160-dd39-493d-7df7-08da695b8388 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT017.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5789 Hi Christopher, > On 19 Jul 2022, at 05:34, Christopher Clark wrote: >=20 > On Thu, Jul 14, 2022 at 3:10 AM Bertrand Marquis > wrote: >>=20 >> This patch series is a first attempt to check if we could use Yocto in >> gitlab ci to build and run xen on qemu for arm, arm64 and x86. >=20 > Hi Bertrand, thanks for posting this. >=20 > I'm still making my way through it, and should be able to speak more > to the OE/Yocto aspects than the Xen automation integration but at > first pass, I think that this is work in the right direction. > A few quick early points: > - The build-yocto.sh script is clear to understand, which is helpful. Thanks > - The layers that you have selected to include in the build are good. > Might be worth considering using openembedded-core, which is poky's > upstream, but I think either is a valid choice. That was how I did it first but packing them in one call is reducing the number of intermediate images during the creation. If having more is ok I can split this in v2 > - listing the layers one-per-line in the script might make it > easier to patch in additional layers downstream, if needed > - The target image of 'xen-image-minimal' is the right start; it would > be nice to be able to pass that as an input from the dockerfile to > allow for using this with other images. Using a different image might also trigger other changes (for example if you want to build xen-guest-image-minimal then you do not need the same features). Anyway I will add a parameter to build-yocto.sh to do it. > - Possibly worth mentioning somewhere in the series description that > this introduces coverage for x86-64 but not 32-bit x86 guests - it's > the right choice given that this is just booting to a dom0. I will add something saying that it does not cover booting guests (yet !!) but the 32bit guest issue is also true for arm64 so mentioning it for x86 would be weird. Cheers Bertrand >=20 > Christopher >=20 >> The first patch is creating a container with all elements required to >> build Yocto, a checkout of the yocto layers required and an helper >> script to build and run xen on qemu with yocto. >>=20 >> The second patch is creating containers with a first build of yocto done >> so that susbsequent build with those containers would only rebuild what >> was changed and take the rest from the cache. >>=20 >> This is is mainly for discussion and sharing as there are still some >> issues/problem to solve: >> - building the qemu* containers can take several hours depending on the >> network bandwith and computing power of the machine where those are >> created >> - produced containers containing the cache have a size between 8 and >> 12GB depending on the architecture. We might need to store the build >> cache somewhere else to reduce the size. If we choose to have one >> single image, the needed size is around 20GB and we need up to 40GB >> during the build, which is why I splitted them. >> - during the build and run, we use a bit more then 20GB of disk which is >> over the allowed size in gitlab >>=20 >> Once all problems passed, this can be used to build and run dom0 on qemu >> with a modified Xen on the 3 archs in less than 10 minutes. >>=20 >> Bertrand Marquis (2): >> automation: Add elements for Yocto test and run >> automation: Add yocto containers with cache >>=20 >> automation/build/Makefile | 2 + >> automation/build/yocto/build-yocto.sh | 322 ++++++++++++++++++ >> .../build/yocto/kirkstone-qemuarm.dockerfile | 28 ++ >> .../yocto/kirkstone-qemuarm64.dockerfile | 28 ++ >> .../yocto/kirkstone-qemux86-64.dockerfile | 28 ++ >> automation/build/yocto/kirkstone.dockerfile | 98 ++++++ >> 6 files changed, 506 insertions(+) >> create mode 100755 automation/build/yocto/build-yocto.sh >> create mode 100644 automation/build/yocto/kirkstone-qemuarm.dockerfile >> create mode 100644 automation/build/yocto/kirkstone-qemuarm64.dockerfile >> create mode 100644 automation/build/yocto/kirkstone-qemux86-64.dockerfil= e >> create mode 100644 automation/build/yocto/kirkstone.dockerfile >>=20 >> -- >> 2.25.1 >>=20 >>=20 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 08:00:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 08:00:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370464.602245 (Exim 4.92) (envelope-from ) id 1oDi94-00043K-Qw; Tue, 19 Jul 2022 07:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370464.602245; Tue, 19 Jul 2022 07:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDi94-00043D-O3; Tue, 19 Jul 2022 07:59:54 +0000 Received: by outflank-mailman (input) for mailman id 370464; Tue, 19 Jul 2022 07:59:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDi93-000436-HG for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 07:59:53 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDi92-0002Ho-5E; Tue, 19 Jul 2022 07:59:52 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oDi91-0004dB-Vz; Tue, 19 Jul 2022 07:59:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:Subject: From:References:Cc:To:MIME-Version:Date:Message-ID; bh=6cCDpR232OZ1sdfwh/36GhVcoa66livNdqVlARtsKYo=; b=hdAa5/7SNb9y8tBtkHEfbkMXBf lY+bNMw88Zn9nlZXSYnxZe5KZ/ziJw8krWgkchs0FfA9QBes7XNGZxy5h0x/6Z7UxLcylUIdWWlmf qZoj+Ryu1fLdYEFgebwm1nnfcPHfFubpK1jwaXboVWfmyEbxLxdEw+X6mdGVHW6bxKTk=; Message-ID: <432f285d-3d3e-5a08-e6bd-546eda523d32@xen.org> Date: Tue, 19 Jul 2022 08:59:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org, Henry Wang , Juergen Gross References: <20220527072427.20327-1-jgross@suse.com> <6e12a7ee-8526-2214-8beb-f0f3d8ad3e83@suse.com> <456d3702-c4b8-9a59-a8f3-307517be86a8@xen.org> From: Julien Grall Subject: Re: [PATCH v2 0/4] tools/xenstore: add some new features to the documentation In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 19/07/2022 06:58, Jan Beulich wrote: > On 18.07.2022 18:28, Julien Grall wrote: >> On 18/07/2022 17:12, Jan Beulich wrote: >>> On 27.05.2022 09:24, Juergen Gross wrote: >> As you committed, I would be OK if this is addressed in a follow-up >> series. But this *must* be addressed by the time 4.17 is released >> because otherwise we will commit ourself to a broken interface. @Henry, >> please add this in the blocker list. > > If you hadn't answered, I would have reverted these right away this > morning, in particular to remove the (now wrong) feature bit part > (patches 2 and 3 have dropped their feature bit additions in v2). > If you nevertheless think an incremental update is going to be okay, > I'll leave things alone. But personally I think this mistake of mine > would better be corrected immediately. I wasn't arguing against a revert and it looks like Juergen is away for the next 2 weeks. So if you prefer to correct the mistake now, then please revert it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 19 08:03:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 08:03:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370475.602256 (Exim 4.92) (envelope-from ) id 1oDiCw-000613-KG; Tue, 19 Jul 2022 08:03:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370475.602256; Tue, 19 Jul 2022 08:03:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDiCw-00060w-Gp; Tue, 19 Jul 2022 08:03:54 +0000 Received: by outflank-mailman (input) for mailman id 370475; Tue, 19 Jul 2022 08:03:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDiCv-00060p-1X for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 08:03:53 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 515ea7c0-0739-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 10:03:49 +0200 (CEST) Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 01:03:47 -0700 Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga006.jf.intel.com with ESMTP; 19 Jul 2022 01:03:47 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 19 Jul 2022 01:03:46 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Tue, 19 Jul 2022 01:03:46 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Tue, 19 Jul 2022 01:03:46 -0700 Received: from BN9PR11MB5276.namprd11.prod.outlook.com (2603:10b6:408:135::18) by BN6PR11MB1364.namprd11.prod.outlook.com (2603:10b6:404:48::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Tue, 19 Jul 2022 08:03:43 +0000 Received: from BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c]) by BN9PR11MB5276.namprd11.prod.outlook.com ([fe80::8435:5a99:1e28:b38c%2]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 08:03:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 515ea7c0-0739-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658217830; x=1689753830; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uaihzsmynefoCVA7HkcZN6dgUgOF1fJkgG2oIsBmMds=; b=byVtQFFS0ZB0WfN2EUzDZw5s9S/UykzvXQCYdgePxXCFzjGFY1X89WsT aaRxjfYWD1/CfD8PBPaODWA1cMt7XnkuBCknRFKL0DfC1YQlNtllvAEov fBgEh2f14jAFSVFHOtge342b4ZErURpDiYJda+Yg8YdIinXUSgYlZIm8H 2LyW4fy0CjSwnQ5Stn1oC+6Dyv1d7YT6uXLzon7e239aaqC2ydsbAOUMq ncj0iXopguGo63ehc7shRpeoH//bX7otgu4pXWwXVxqvEON8sFjbnnhIU AN/TZzf0lris+Q4V5GFm8dTDLgD4yqIzSmbBkDlRuB47YnD23FMygTrbN w==; X-IronPort-AV: E=McAfee;i="6400,9594,10412"; a="283989162" X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="283989162" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,283,1650956400"; d="scan'208";a="572749740" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SkVFwMjngpt1YGBirgk+1ntGL5QCk52tmUmbPLc2TetUd2qVW4J5EDgXz/mHH8u3cabgP0HeGTYAZ+USg9DEXkBE7mnD9GvDT5a6gse1h0QqWWG/Uulm+W3EDouVHcTBCb6ZHX9maO2YntLzOECHBe/gse2bXt6nGm6d3Qovw+FpZ8KRCd4OaXhy9T2bT/knxrtbUCUHGZrl2bDn1g5vA4IWQp2gNrEnuXQpuBr2j19FFgMVLoo8d3ih985elAfxKspGcHPyh7SfwkMzlACR+sQRImuuwtbOyvzwJFU+iEnDM2i8D6sU8FeLAqyXYX20yHRxRGLnwZtFwXsOcH6cmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uaihzsmynefoCVA7HkcZN6dgUgOF1fJkgG2oIsBmMds=; b=OPyKaExDCHqunmqVmFocT7kLaYOVfeDJ5FbEFonjisB9fUVgYJqDeESugi2bvOPB5oPq6iqpHMKZARTg7a0U3lmRY5/KKrbVhCz/ujmSPTwlNbNGD2SihOjssDSdqjb4S7Bal/ZIi0JtGL78zgHOGwAj4sp/W7qxg9d+AhAasfmIyUzIpsr70KSc633SIoCoOepL/7igXzXcUSdTbd02UAzk6L2RHso5eKK3jUWELtg45S/hTagj6r0J9ssVt5MtKXN1IBFcqQ5cXYh1QIZSaCfGOqfuUkSL3msMiv/JdN5nsYh1Lwo+3ZRsEfMF52LRObWKNZsinqpcscwOpBDROA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Tian, Kevin" To: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "xen-devel@lists.xenproject.org" CC: =?utf-8?B?UGF1IE1vbm7DqSwgUm9nZXI=?= , "Cooper, Andrew" , George Dunlap , "Beulich, Jan" , Julien Grall , Stefano Stabellini , Wei Liu , "Nakajima, Jun" Subject: RE: [PATCH v3 3/3] x86/vmx: implement Notify VM Exit Thread-Topic: [PATCH v3 3/3] x86/vmx: implement Notify VM Exit Thread-Index: AQHYjUz0v2qm7nHLtEKNiFhvlgtrma2FaavQ Date: Tue, 19 Jul 2022 08:03:43 +0000 Message-ID: References: <20220701131648.34292-1-roger.pau@citrix.com> <20220701131648.34292-4-roger.pau@citrix.com> In-Reply-To: <20220701131648.34292-4-roger.pau@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 792d2027-d897-4260-503a-08da695d3320 x-ms-traffictypediagnostic: BN6PR11MB1364:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FAxvvtq3/p39kuEb/0GpP/BHsPEOePC0u9KawYiiqFyaco689sRNOEzJCfitGoLc9CsNJmpcbJP/rkZy2XooaaphANH0rRlvgYPtFakUqLR81T4w+FC/IRfkXFiBzPY0p2DwuQhQuCNN3603R2ljQQW0Uj9C9+IS+AFyBtG5S72lYA/EgK46EvB8kMySvWfFMKOpzSFNRk1sEJQRODezGuWklW1tFUyLxDAb/JsD5qmbYcxp2WrIOaC7WdBzHsbOJ//V8ysaHRpJ85rUPxFa9QRhay00BaVqW70nK71VrRgFvmpom7VD296GUFEf1B3MI2q2ka9sJEXABO522fMb1LXEnxIxnhGHbKe26sVeyTcg6dryFDqdMKg21+5fGxBVc0t5drvVeWir1ztFeckIDo1rULBO8KBYqT86Q2jhR/bz70D0ac2TBQaOSko5VYaGc+WH/USRoNTw/9KdoyhAuxh8Z3DMor1ea0frXs+4ZUSUUNBq+HShghoT7ZefxHfXYP1LmgRHPRx4jo9Jmc61W8YDs9FL2IZitxKnz5xia3Np/Z/rLtLoF+htOo1t2sh2e/2NPbhyFooKZobuKLqfnrclk0I+EwOeFB2ArU5vY1QofTI0lN2L1RLe1po4JCG4HVBuhfFBaLwUMvDhcFxlNl7ghoam/itYQdY6BtupT3aq4+3Sor5UbCSNf8+QFiwLbpLNMkxR3lnWDQEkxxfKIA0EzB2AefDzsaJJyyxCIKRQVZ4DsKzCNaPMb/QBJo4JCXlSChMrzl2wAnRsTTDUzClteIpFA+vr9VgBMvLeRWevhvcl+97txQA5nBmkSar7 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR11MB5276.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(376002)(136003)(346002)(76116006)(66446008)(66556008)(66476007)(4326008)(52536014)(8676002)(64756008)(66946007)(8936002)(478600001)(110136005)(71200400001)(38070700005)(5660300002)(33656002)(38100700002)(316002)(82960400001)(122000001)(86362001)(186003)(41300700001)(26005)(7696005)(9686003)(107886003)(6506007)(54906003)(4744005)(2906002)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SlJwT1gvMWhiZHVuTGx0OGNSbnJ5clRVdk9HRFpkTmpiV1FSR05vTDN5VlI2?= =?utf-8?B?ZnhVUFk5Y3pQRFNOM3VWM1lPWmQ0dnRaanhhREdZNGdFYlpGdXB5L1Zxbys0?= =?utf-8?B?S2ZxTUJobUNOT0h5RW9HanNxcWRzWlcrYVM0Ym9IZ3k5ZWZkVUZDeTkyV0lC?= =?utf-8?B?M0VKUEFvRHg1dUZ0QVJtT2lIRG1YZTVsTmEyZjVlUkwzVkx2aEhMV0dqVkRK?= =?utf-8?B?bmhRK2M1TzNWTmQ1Yy85WWIyTzBzc2RORTJXQjJEMC8ybjhYeEE1Ym13QnV5?= =?utf-8?B?a3RCMTl4N0JBMlo0Ynl3dll2ZnF4M25RTG9pS25HZkJiUlpMQlVGSmRrRkZJ?= =?utf-8?B?MVZQY3UrTVdjRndIR0l1Uk5rM1BSM28rbVVlQUkzY0xMei9sQVNmbXlhd0N0?= =?utf-8?B?cy91L1VaenZ3U3RaMnl1Sit4Slc2QzlVa1JQTWJxTE8wc09kUlNmTGovd2dt?= =?utf-8?B?eS9sSThrbndHQVo0THRJdGJma1cxMzN5MWpNVmo0QmIrM1p6MnlpMmRWelFz?= =?utf-8?B?VlppZWwzUVNnc21sL1VLd25ZaEFjMC9BbGcveXlhSlMyaU5xN3E5bVFMcGZw?= =?utf-8?B?UFQ3Qlo2Vi9LSUZpd1ljalJ2NFpEMnNCcjMzZEc4VTZnSW9YaHp0VkFmRmR4?= =?utf-8?B?a3NoWnhUS1g2U3gxS29BMllUOU56K2FGeDJ3bW5Hd1RXaFMwSTNFWVJrVzQ3?= =?utf-8?B?Skk0UVg2cENaZmJCOUFPQkxaNng3UGphN3JVZm1RclNpc2twU29vOFdwUlE5?= =?utf-8?B?L3RRWVZuQWVIRjgwUWtOYVlQajh4WlpRRW9zTEFyRk90KzRrV3gzOUl4RU0r?= =?utf-8?B?eUJVdTRKYTBMKzh4Si9uN0dzN29qTkMwTDBFVXNaRUFDdHdRYThFUkNCMDBR?= =?utf-8?B?L0ZsTSt4VHg2eVkxOHNvcjl6K2VtekMvVmRrdUdtcit3alo5RU9ncnRWd2o2?= =?utf-8?B?U2hLbCsyZGN1TlVXd0tMRkduSytEVXRrY3l2TlJRdDNpY3NkUGpIU3hkQU9S?= =?utf-8?B?S0NEdkE0aHNCL1hrMGExd2xLOGc4cTFMUUE2RFBQTGZGanI2OG9WQkFDTlFV?= =?utf-8?B?UURsdkN3UTJKYmxJTlFFSHFGTGxCZ09HbUFIUzJXT2ZjU0puNy9pbnlGNDlR?= =?utf-8?B?VnRtL0tMV0E5NTBwRWgwb1oxR1padHNsRmcwMUMzRndBQkFFTC84T09aRTJn?= =?utf-8?B?dm16ODJoa0ZRL2VsNkg3QVZaVmpxVkRGenB1MytVTjBlVXhiVzhHK1BWNk9w?= =?utf-8?B?RkNFb2cxRzZQSTljeVh1d2RZSmpjNUVEVHd6d0orMFUvVHNBeDR6blQvVERn?= =?utf-8?B?WTdkUWNHVDNtazV0UU5MQk9wQVc3OWZCV0F3b0IrU1ZvUGVvcmtNazUrZnlV?= =?utf-8?B?U0pab2krc1hwOE1GVi9BSVJXVnMzZEFxL0lrelVaWjlXbXlqbmE5MHI2WkdF?= =?utf-8?B?VTBtd2I2dmhlT3NWZnkxanJ5b1dGYkRDaHJEK043ZDZxWTJPSExaUDBJbHVI?= =?utf-8?B?TCszNSs2b3V1WHhBVU1vWTlmRDlwMzVCbGlWTjgwazZHQW83SUlwWGN2UWlz?= =?utf-8?B?NHVNSmcwdjVlNFV2L2dMVkFaVUMwbzBBbThJODFzV0dFQW5Ob0NEUDd3UE9W?= =?utf-8?B?cnIzakc3TUIrZ0NFS0xWcFZURHU4aDJXemVDR01zMG1BS2FZWXJYaU9WMThp?= =?utf-8?B?VUpQU2swRDdJdjNSYVJ6bEtWaHQ5ZGpZUUY4am4vQTRkUEREaGV4dlRUOG5H?= =?utf-8?B?K045aFlscmg2cXc0dkVKTkhqTGFVSGNyazZPNUVYeFRvWUt1eEtQQmI3WFFk?= =?utf-8?B?SWo3dmpiLzc3RXUzOVJrczBpNGVPYVJ3RGNTay9pQXhhYVdFTXcrOHpwUlZw?= =?utf-8?B?S1ZCY1F1UENJQWVlTC9aMFVvZzd4NjR1VHJyMTE2S0IwdDhMUll3NEZLSVJh?= =?utf-8?B?ZEsrc0krdWJDRkpWVW04dzRQcjNFM1dSR2kwSlJEeUtUQmMvTVZiekhaNkpM?= =?utf-8?B?YS8rUVdDZkRuSGhSSmk2Q3d5SURadzRpNWRKamZjbCtFMjJYeGxXUWtxUU1B?= =?utf-8?B?MFNtdDNxUlZzK1ZKUE9QZnlaQVg3VUJRRUdzVC85SEpNZjJIU0lERDVOYklK?= =?utf-8?Q?7uc9vu7DtJDfz6u4ahyenFzv+?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 792d2027-d897-4260-503a-08da695d3320 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 08:03:43.6664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qnyJ4HTAveSomi8Ck/xWcp1+b4KWx83++FXO9ffQgQdpP/4nV6RuOZ7YOfEdzGCRPc243PPi/rqzBsaPIz7FbA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1364 X-OriginatorOrg: intel.com PiBGcm9tOiBSb2dlciBQYXUgTW9ubmUgPHJvZ2VyLnBhdUBjaXRyaXguY29tPg0KPiBTZW50OiBG cmlkYXksIEp1bHkgMSwgMjAyMiA5OjE3IFBNDQo+IEBAIC00NTg5LDYgKzQ2MDEsMjIgQEAgdm9p ZCB2bXhfdm1leGl0X2hhbmRsZXIoc3RydWN0IGNwdV91c2VyX3JlZ3MNCj4gKnJlZ3MpDQo+ICAg ICAgICAgICAqLw0KPiAgICAgICAgICBicmVhazsNCj4gDQo+ICsgICAgY2FzZSBFWElUX1JFQVNP Tl9OT1RJRlk6DQo+ICsgICAgICAgIF9fdm1yZWFkKEVYSVRfUVVBTElGSUNBVElPTiwgJmV4aXRf cXVhbGlmaWNhdGlvbik7DQo+ICsNCj4gKyAgICAgICAgaWYgKCBleGl0X3F1YWxpZmljYXRpb24g JiBOT1RJRllfVk1fQ09OVEVYVF9JTlZBTElEICkNCj4gKyAgICAgICAgew0KDQoJaWYgKCB1bmxp a2VseSgpICkNCg0KQXBhcnQgZnJvbSB0aGF0Og0KDQpSZXZpZXdlZC1ieTogS2V2aW4gVGlhbiA8 a2V2aW4udGlhbkBpbnRlbC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 19 09:33:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 09:33:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370499.602275 (Exim 4.92) (envelope-from ) id 1oDjb6-00083o-8V; Tue, 19 Jul 2022 09:32:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370499.602275; Tue, 19 Jul 2022 09:32:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjb6-00083h-5P; Tue, 19 Jul 2022 09:32:56 +0000 Received: by outflank-mailman (input) for mailman id 370499; Tue, 19 Jul 2022 09:32:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjb4-00083b-HJ for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 09:32:54 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80070.outbound.protection.outlook.com [40.107.8.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c2112158-0745-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 11:32:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5679.eurprd04.prod.outlook.com (2603:10a6:803:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 09:32:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:32:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c2112158-0745-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NgENY3uaDTfo3uyycJ14qF64Hrj3S5rw2ImyaUxCXSTytfcA3eLlH+mmGVDq9BwAplhpxNm6xXC5n+Z/u+mhQlB0dPRdhTIEzsmDjRRB//zhnLlM26z6Cri7eSZ/kPoYMelshDJBuiUqQ/n7Atp4SPcI9qzPsMN9NppwIdw35TAfrb7y06pv9K3aUOrFtY8IsIT3C7D1tZoGVQUEYKkhzQv498uOjg9BpBTNhDZGbtmo0OwALE5AWlYz4VER0P3xRe//G3icGrLTpFctpTy1EdjxhvKd0UYNKmCGDurreq8iHOIQmdVRlVn7XEcnVdPPJoOO7TnPWHR0JuqEQvKn7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Fz7c6wjkMrFruZ2/AtYHJb3j8hPxDPCAGR6792LWaK0=; b=kmc75bqE5GgaYqo6e6q6zcGKnHR8nRng2hmjMSNmXjmXdpQZT9TnNuo9ew2+/wr8AP0kKdANvCwySwQXxZB1i2HC6VdYT2WYS+1q4z+JH0ZmmSNDTf3GbWDmouTHfIOeYBH7xGmLOWfU5nb5E0heqPlXNsowJxfpoou9rwYHE/zDX6Q1SigMK2zUVFFvKP75i6hhZ0kChioeQzP5gt2QFpxApso+QWfbpUi7u2DdYVmHYCG4jnO8mR//pv1ASAxxB58qnF6FQehmno3J169LEpVdq46ipHJ8EB3Y0aSSuku5QHTPjtQPKkk5or1qTXgyogHrWKaoj60Vx4vh0OwE3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Fz7c6wjkMrFruZ2/AtYHJb3j8hPxDPCAGR6792LWaK0=; b=2qvO61+O8t5ytLu8gVxD8xMV/Y9VniPAux+u6xxnI5/uh/k3PgRtTRY3B13MqVaJltqkGV+yBBhnFp/aB0TsOf6V+U7A20bYMlpkKHQhvKeYGMVDS7NTYCZ3eMoF+frjk+DLZfCq2An2bSDk4u9YOqlHU3BAuLLEPkopGt1h0yr2s7jYOlbXdWlZeLH6jKegWjO4tMlw25iXZ2LGLPm05cHcUHVn8Jwzu8wJLoe3gXPdoWiutgId0Ia0VWcV/fCkm2y/oaz17keTIzlGooq9LGLHAqew6Mj+uCOaiNcb3KqkKKF4x1qi3QSGTdQOgNez+onqGtV8pklhUGajhaeywA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <59114d3a-b9fe-1fb0-fac3-fe14fe4c505f@suse.com> Date: Tue, 19 Jul 2022 11:32:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-2-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR07CA0046.eurprd07.prod.outlook.com (2603:10a6:20b:46b::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: feedd562-2b38-4e74-8134-08da6969a51a X-MS-TrafficTypeDiagnostic: VI1PR04MB5679:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W1d4Z/HdQkm/Ew44ofs+AkYVz482+himYmM/QnwQVQLp3e/o/NU3sjnGtLU02MBlA1daVfm25peEIPG6ndO8WobReHE77JCRs/zut6/lPfC3BqQyo0DUlgtZOC7pGm66tNW4zUgCNT6Om0mNmc1r1mTixecjaHinvSvE9QkUbDK3jULhDcd8l9PFb4fPTA9zRwdrgKpRte+WP+nQAcDZkYfxupQnmjD84lTRHqKHjPuKWD3K+8a+lYG8QLJ0EAD6ffECxC2DQuj9XHGYRigRozZiUQD886ii4sSwqH+3z80ZMmZzrqSITLz1bU0K5MlvOuZP871dzs+c3zbLfjji6/ow9H6b13OmX9Z7LWV7Ai2UAPE3TDRbm9fTzhrqUdL1+XDYA8eRsJuAsgE0SeRSYCVyyGKbZIJdVi7NvSIpLVf32kK5cMzPV5bX3eQLwWBDoI3ossbDNArFpiMrOQaqtQdypJyZJBupTzBzHipl5bHZ4r83KdWpbEq/j0dnn276ckJKK8gWzWH2n3NmfF7wujXVCdshfRRQ3pSFWCpXOGvpIThlbXsKXCe4QhvcVEfuiV7BqUq0XPhgewLbKrrEUqqT2NiHAFnqwy0EvF/E8rvUDQW3nDMMc+C5oMoD+BJ5JbhT1fRwSQN/1zh7xpDSLpxLGq4BFhtGxMamUwjafK1tbwbkpjlEfUxD0b5zaJTBp0PjB7YlQa9/CnBJZOLzGvFPgEfPvaIMg+RTf8cHYWIYY4oS+3RKlTYsiIIf+PCHwxp8/2cLBeRT9O5FMfhAcoC46ABBujDIobVJM4XrkJvKDAmUZeeREpEwU4pXAAne5AhdqlEVmc3/FIP731a5QQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(136003)(39860400002)(366004)(346002)(2616005)(5660300002)(6512007)(6486002)(86362001)(83380400001)(31696002)(8936002)(6506007)(2906002)(53546011)(7416002)(26005)(41300700001)(6666004)(478600001)(4326008)(186003)(31686004)(36756003)(66476007)(38100700002)(66946007)(6916009)(8676002)(54906003)(316002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1ZZVllWVHBxQ2txdFc4RnkvdlNnaUtMbW5zRFFNUldWaGtsKzBpUnlsRFpD?= =?utf-8?B?aS83VTRXUFREV21UMHI0TEFEMHYyZWZhWjVHd05FcDV6cWVuR1pPNjh4RmhL?= =?utf-8?B?V2VsZS92cUs1b3dPWWZtUE1uTTUxTWNzN3loMnFGeVRNMmwwa1MrSHBya2Ny?= =?utf-8?B?aC9tZ2gvSUhnalVqM3lYZEZGbmdTWnJHa0RJRlBEMjRsN3NxQzFpZFM5U3Iy?= =?utf-8?B?KzdkWnkxZlRLT01RVDRGTGEzam9aMnpQaDl2L3RXVzFxa2kxU0FYQ2c5blc0?= =?utf-8?B?Z2N3RXMwQ3QwRlRob3gvWUwzK1FpRnV6UXdKYW9RRkY0WGtGZno3bUVoTzVQ?= =?utf-8?B?bHQ5c0pkNVB6UXBIanZwemZ3VUtOY2JmSHpXRk05RUhiYjZDbS8zWWpISDAw?= =?utf-8?B?c3RTZHg1Wk9BZTQrYkhQeTBiVmZweVJTZWI0dXVWNGpUQ2lnRnlQVjdyZTVs?= =?utf-8?B?aVNicFBMTGQ0Z1l4clQ3MWEzeUQwMHArQ3JRWHQwWmkvZkNsL0FWbXZSdmhz?= =?utf-8?B?eUpReWRIQ0FVTHhiMDdJcUozSEVnYkErTk5wYnpzaHN0L3NCaVJyMjdha3N5?= =?utf-8?B?eE5kM2RLdHFmQ0VRU0hQam5NVG11WEQ0REVWMGhNeDlWU1IrZU5ObHZhbVE4?= =?utf-8?B?MkVQeWZ2LzlkbkU2NTJPSTM0QTVpV0ZhdWpCRTdTbjRoeHZOdjZEM09nZVBB?= =?utf-8?B?T3cvZ1Z1TTR2aFZVRWlIR280ZC9XUFkvVlBQMWhDMUc3K0dmVTRHNU9wV3dT?= =?utf-8?B?UHdVUWg4cm5ycFJWV2Z1clZQYTEvRVZZZzV2QTArNlFFUnRCcTFOWGNhMWZO?= =?utf-8?B?M1FCL1g0ZUpscmdnK3MvY2lqS1pQRjFVN1IzQURENlFFU3krZVVMZHkxUmhy?= =?utf-8?B?c2pUYi9lUEl2Y1UvdGJNSmdrVVdGeVBwbW44R2NFQ1dMUFEzbTBWTys1YzFh?= =?utf-8?B?VExnaSt0RWdFcWdxVitsWkdLT2VKdFBGN0FGK2QveW43cnozeTdjZzA4clRL?= =?utf-8?B?MmRmcmIwdng0T1NOaVpXZ2hvaUE0YUpqWUptb2lCR3p6aU84cnRZenB4bFlu?= =?utf-8?B?R29TK2xUaFUzRWhzendRSGNLS0pQSzJPQjRPVUwrSEJDT2hqNkY4RDBVRm1T?= =?utf-8?B?TzFCcm5TT01NVzRGdDBvcHd6VW50M2syS0w3NG9VMXRnc3RsZXZQL2pLVjBl?= =?utf-8?B?akJ2Wk9adDhWRkVTR2JLQ1pDNVlKbVNhSlZuaXZFc0hVcW9YSjJSbjVvYWQr?= =?utf-8?B?NGxKWDRublZXUFBNeXNod1FjaDhYaWgyNUdVditBQUtiaE5NVkdKTFNhblIw?= =?utf-8?B?Z3VWTUF5cEcwVjkxL1BZSlpXZEw3aFMwOThRaVdyMFY0eWFlVE11VlFvZnNj?= =?utf-8?B?VGtIQXdlRndGdnJVZG8rdVhYdE9TNFNlcUNnSE50VVFGbi80cCtoM2ozV0pZ?= =?utf-8?B?bnByTDExN3c1MTVraFZnQ3I2VHV3cHFmV0FPRFdxRlBCbnc1cTZmbUhIcm5F?= =?utf-8?B?U0tXdmFPQmFMNktKY05QZVN4NFpibXhXcnQ1Vnp0cGd5cEZISGFQMnMyVmU4?= =?utf-8?B?YVpOZndqUXdwaUlweUN6SlJCMFgrV0t3dUJ2RHNPbEVUeUphNXY0cGQzc3JV?= =?utf-8?B?TFVvV0ZYMDlodW9QQklHSXVRdE9CRStUWFZOZEx2bWNFM2pKblFSNGVYMEtj?= =?utf-8?B?RGtSK1VvQ2pvdTJzR1RPOG81L1FzNjIrL21Ya2lGTHhJbHhGTEdPR1diUElX?= =?utf-8?B?TGlXUWdOQ1ZHUk84TFNzU2VsMFkwaVdvaVVlL0lSeGNoSlhlZWx2bG9Ld0dy?= =?utf-8?B?UnlzK3UyTnh3dzhkV2FaVld4YnI5cDFBSHRjRmtOWlpnV1owZDJ4ZFEyYUhn?= =?utf-8?B?cTJ6d2laOTVHdmlQblZxVlE2eTN5N2tUUmw5cG50UXRBUFp0SCtOVGVWcmZQ?= =?utf-8?B?V2lWcTNSQU9PdjBOb2cyQnZITFF6ZXRnVXh4MVZYYUxVNzBiajdYOXBTNUxx?= =?utf-8?B?UE5JeGtZRE16c2tZeENOczVqdlBrVmxzdWhsYzRtM0JudldUZnpnMmRzeVlI?= =?utf-8?B?SmR2R3lYaVhjR29CODFzUnVORE83dnNjdkl4aTFQTmcvVWxhRi9wakpzQlZq?= =?utf-8?Q?XvXsYAjf29q65AaC+fYVxapiK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: feedd562-2b38-4e74-8134-08da6969a51a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 09:32:48.9900 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 86VIsZNidifMx5X4eTjeQ9uI+A6WL2IT63b5Q1bkiAkptk+dT8I/89l2wWi46/WGwD/aRjE4XhPih3bw+ek8sA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5679 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/arch/Kconfig > +++ b/xen/arch/Kconfig > @@ -17,3 +17,15 @@ config NR_CPUS > For CPU cores which support Simultaneous Multi-Threading or similar > technologies, this the number of logical threads which Xen will > support. > + > +config NR_BOOTMODS > + int "Maximum number of boot modules that a loader can pass" > + range 1 32768 > + default "8" if X86 > + default "32" if ARM Any reason for the larger default on Arm, irrespective of dom0less actually being in use? (I'm actually surprised I can't spot a Kconfig option controlling inclusion of dom0less. The default here imo isn't supposed to depend on the architecture, but on whether dom0less is supported. That way if another arch gained dom0less support, the higher default would apply to it without needing further adjustment.) > --- a/xen/arch/x86/efi/efi-boot.h > +++ b/xen/arch/x86/efi/efi-boot.h > @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { > * The array size needs to be one larger than the number of modules we > * support - see __start_xen(). > */ > -static module_t __initdata mb_modules[5]; > +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; If the build admin selected 1, I'm pretty sure about nothing would work. I think you want max(5, CONFIG_NR_BOOTMODS) or max(4, CONFIG_NR_BOOTMODS) + 1 here and ... > --- a/xen/arch/x86/guest/xen/pvh-boot.c > +++ b/xen/arch/x86/guest/xen/pvh-boot.c > @@ -32,7 +32,7 @@ bool __initdata pvh_boot; > uint32_t __initdata pvh_start_info_pa; > > static multiboot_info_t __initdata pvh_mbi; > -static module_t __initdata pvh_mbi_mods[8]; > +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; ... max(8, CONFIG_NR_BOOTMODS) here (albeit the 8 may have room for lowering - I don't recall why 8 was chosen rather than going with the minimum possible value covering all module kinds known at that time). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 09:34:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 09:34:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370501.602286 (Exim 4.92) (envelope-from ) id 1oDjcr-0000Bq-Ku; Tue, 19 Jul 2022 09:34:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370501.602286; Tue, 19 Jul 2022 09:34:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjcr-0000Bj-HD; Tue, 19 Jul 2022 09:34:45 +0000 Received: by outflank-mailman (input) for mailman id 370501; Tue, 19 Jul 2022 09:34:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjcp-0000Bd-Vk for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 09:34:44 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0364c719-0746-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 11:34:42 +0200 (CEST) Received: from mail-bn7nam10lp2101.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.101]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 05:34:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6166.namprd03.prod.outlook.com (2603:10b6:208:31e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 09:34:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:34:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0364c719-0746-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658223282; h=from:to:subject:date:message-id:references:in-reply-to: mime-version; bh=jGaxPw67yNaomW5LUh7x/857Ud68s40Hrtq/0GtuPKk=; b=OT+T3IdAolnJ5Whe+Z7FtARTnjxKX7RTIMDAeXVYvT0XY7WJ4uMorEvs Gvkn2uCgscehZE0Vaw3N5IVghzQLEQrhaRMWWMRmhzRyAxrv32eDumw2c VELqJ+xPIBs2KvHuVi8RripbrTKQYldYGs1gEV0lvxM6j0DP++DO+ShKZ o=; X-IronPort-RemoteIP: 104.47.70.101 X-IronPort-MID: 78681832 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:U9XF56Cxa/6VaBVW/zbiw5YqxClBgxIJ4kV8jS/XYbTApDoj1WEOz DYZWWrUaKuONDOhf9lxO4m+/UID75KHz4UwQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsvPb8XuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW1D++7IpAFEqAdIn6+hTJXlFz d0lMC9YO3hvh8ruqF66Ys9Fo517aePNY8YYsHwmyizFB/E7R5yFW7/N+dJTwDY3gIZJAOraY M0aLzFoaXwsYTUWYgtRVM14w7/u3yGmG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFZILPkGreqBpAgMeeoxP5eosgU4aA++Rmp02p+kBKMx8/AA7TTf6RzxTWt8hkA 0AF/iMooqUo+EWvX/HlRRqkp3iBtx8YHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbQGDq5WQQHOZs72S8jW7PHFNKXdYPHddCwwY/9PkvYc/yArVScpuG7K0iduzHizsx zeNr241gLB7YdM36phXNGvv21qEzqUlhCZpjukLdgpJNj9EWbM= IronPort-HdrOrdr: A9a23:ASnMCK+NBKFDXgWdRhJuk+Fndb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQkdcKO7SdK9qBLnhNVICOwqUYtKMzOW3FdAQLsC0WKm+UyYJ8SczJ8W6U 4DSdkYNDSYNzET4qjHCUuDYrAdKbK8gcOVbJLlvhJQpHZRGsNdBmlCajqzIwlTfk1rFJA5HJ 2T6o5svDy7Y0kaacy9Gz0sQ/XDj8ejruOrXTc2QzocrCWehzKh77D3VzKC2A0Fbj9JybA+tU DYjg3C4Lm5uf3T8G6S64aT1eUZpDLS8KoCOCW+sLlXFtwqsHfrWG1VYczCgNnympDr1L9lqq iJn/5qBbUI15qYRBDJnfKq4Xis7N9m0Q6c9bfT60GT3fDRVXY0DdFMipledQac4008vMtk2K YOxG6BsYFLZCmw6hgVyuK4Iy2CrHDE1kYKgKoWlThSQIEeYLheocgW+15UCo4JGGb/5Jo8GO djAcnA7LIOGGnqJ0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NY2SoVC5e 7DLqN0/Ys+B/M+fOZ4HqMMUMG3AmvCTVbFN3+TO03uEOUdN3fEu/fMkcAIDSGRCe41JbcJ6e X8uQljxBAPkmrVeL2z9YwO9AzRS2OgWjmowt1C5vFCy87BeIY= X-IronPort-AV: E=Sophos;i="5.92,283,1650945600"; d="scan'208,217";a="78681832" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e6S8c50RlW/kN/tvJAdH6uYQsHrjzvfzB4JKFcY69QWc2aIp0NVVTRGiZoDKW3msyjGo8WreY0G0jFV9OQp9AtEtp4Vi1WvNcFrvhyA4488JC575vIfRsVBOdGnC9DS9ZesAftkJzEK/jK3FAfuTL5VRT2WO1RN/uEbP9SK6qRyF2MGgutSmZqfn3TMGtAzC7QgFMcLGnaUY/r46B63ByKE1p79q8VIsNZRDrJanjGAKmyWbpkw2L3DgBGdAKAF6Un/fWHabJnVw5M5UqMJsuE85051S2aFYuH0x/GMunlVu4FtB17xQeS9XSiUKKyF/D55hwaiGOfgtxahq8zu65w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jGaxPw67yNaomW5LUh7x/857Ud68s40Hrtq/0GtuPKk=; b=mDUV5kUGrv2e+NHhZ3D+D+sgMOoHV9gGaiWlWJwp1C2FUtE22UIoKu8dd7P1r0EY8OgWVHGLsDjb3XhI9okOrQrkpYNUJ7eijp3M4fpElexXJyyWPC1PGWDofCeMImGILi6+PrHHk4wkhfQgNCfG+FkUlE8I0vZwz1UKbr7mmg+U/ZsjjNfONG4D69RtKFStq8I3F10C4DkAABNVmJ/4pqKZa2/+Dhpoo4AXNU5HkXHXIWmnzScXc3Tv37Z7SrJXn3Vd9LdW9WKLrYpdqZs+3BT2+AO+2G9jAEFvrMmXmqHSqNg6nqjGbnh4KTWhRlvsOuTjWXRY9ZGI7tSLa1Almw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jGaxPw67yNaomW5LUh7x/857Ud68s40Hrtq/0GtuPKk=; b=G1O09IQPvrAhzom3SCpG/7IX7/4QIMDaffXsDrAyfnVSUcB5/wLU+5iDhP2lvIU17Jrrwm95ILJG9Ze4/3xYFRRheqg0vM+dCLcD4oD/38PI1ClThf9kYBQq5a9uMDeLZm2dp1ZJoaCTLqNWEATQ1eySOn0b6pq9NvtuvZcBppQ= From: Andrew Cooper To: Dylanger Daly , "xen-devel@lists.xenproject.org" Subject: Re: Ryzen 6000 (Mobile) Thread-Topic: Ryzen 6000 (Mobile) Thread-Index: AQHYmvrX1sLvM09bk02pTR45nk82162Fb4oA Date: Tue, 19 Jul 2022 09:34:32 +0000 Message-ID: <4c3976aa-dad4-2707-2852-9b26593692d0@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66ca9dc5-b183-4d0e-2e65-08da6969e32f x-ms-traffictypediagnostic: BL1PR03MB6166:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3LbRalYS1x9ftqeoAKvrFYbhtjHKGkUZmpzaH3c91PRgyVPtdQuSK5+R0EOkIIh6PLAAlPK/K66dqX/hkDHQsDwGAIdvLnm0YmCK2wzgRpbtY3WYwGZljZQOgo0/BhCdokSgEcm6NSHahGvXEMISqWs7+74JOAoGamqxX5Vd6JFwwvWTcu59CCw04xpKYwbqyIbQCADDP3YOK96uBFIenr1N236wnOg+jOX3fxXWxvbL3P2iwzgh8Bon9j9iqaESCqpZ6QtiPmuYWvKIo8wUReR2W6GU9G1IlVDvdaS3mB53Vmj8UnnM9a3azRc69qoHt4Tk8zLXUjvQpyiMDOKpOFFQZPZ43g8AgqHQAv6/fZZQ4rWwAlpvqjZlfUpikROvZMvhkUTkAOqH+Aka6Z1tYnLCmkqhQvAjURuWQ9t6Dn9wmLb0Svv2gW+L4ITFkwVVbvP/TnszKQ4SlBXXs3ZKSsOg8UM+w/UbiyZnEGIgKoNWtoHR0JoVkXjedZL8wThQ2AE2oA5KVhdiNRssCfMTdZ4nM9DyIlKmv5oQTpbX0cqcYOtbbNYDlucFUtk6VhCdbmhFDi3PZ2m9k6fVLNvEbv+hCmeUtkA8Rs7AdK2v8fIP0sMW7c7XYfGNM/ld2I4/FxUCU+cm7LRAFKpHinG7nbeBH8N8dnjIYkC3C6FcsFKpTexVDfRVC/qxAhjBJe/ZbHjbPs5oeWbcu9WEZDugWG500C3e48EZp2EOqoeV9kBfUfyUDWWA1y22xrwxBv18J0ZoqDxUpy3BCNMZLRr+moZ7fRxraB6360p1UP4uDKAyAMZms4UPNIRwxeXjsLLLjRGQa1fDEFni9CbK87K6WQ5PVLyRuUkadaSLgqmSrXiihYXSazZQvg7PVgJ1751a x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(39860400002)(366004)(396003)(346002)(83380400001)(38100700002)(110136005)(5660300002)(966005)(186003)(2616005)(316002)(38070700005)(82960400001)(166002)(6512007)(31686004)(86362001)(66946007)(64756008)(31696002)(76116006)(66556008)(8676002)(66476007)(91956017)(122000001)(71200400001)(66446008)(26005)(6486002)(53546011)(6506007)(41300700001)(2906002)(8936002)(478600001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dWxjK1k2ekNzSzgrMFc5blVJYzVJcHZiTGM3SDhPSlo0cXdWV0p2TGNvbEJY?= =?utf-8?B?Zk41NUVjR2M2YkxDbVRKZ2J6aHBlcmFscXBpUm1GelpuYzdDc1dJREFURlpQ?= =?utf-8?B?NHpiWnBSWWdDaldxL3pYRXI3ZG1HLzNrYVdkZitBay9WTVh0V1pVcncvWFcx?= =?utf-8?B?eTBLWGJWS240NTNTTEhIYy9BOFVwZTBjSk9IT1JOTFhpOTBvRTBpT1ExOFhP?= =?utf-8?B?MHZ4akprRFF4Q05lNCtqUk51VnJNYXZ4VzEzMzlHaDlON3RVWDhxVGs2VWZ4?= =?utf-8?B?Q3ZCMVdmdk9JRmR0a29GS0tWRjBlMHlNbll2aytnR0tITGZCQUxKMUF6VzND?= =?utf-8?B?QXpleHg0aEExcElhaHlCUjg1ZUFxQ3ZCZElSTXJnOUVZZzcxZjNnSmVrYUFB?= =?utf-8?B?cDN6bVpTTXowandpMml5ZUQwUldmbGxtYkN5N3BPUTNNamJuRGw5bHFTMEJy?= =?utf-8?B?bzBkRTl5eEdxdG9DM3JBMkZxQUdCTzQ5cUxYbVd3RnFBZXc5QitrdmVTcWt5?= =?utf-8?B?ZnBXZTM3eXI0Tk94U0xTa05QQkV4VWFKWURweVdiN3hLQ0ZPdzRtbmhtNWdQ?= =?utf-8?B?VEFSS2xTY05xVko3QzlwUmRGZVN4Zjg1NEhTUGZUN3ovYlJsTlZLamhjUnlD?= =?utf-8?B?bDJUS1hOL0JoR3BRcHUrNE9FK0EvbUdWdU4vWEg3UU5ubUVlMm54NWpIczBP?= =?utf-8?B?T3J6Z1R4UHQxSTFvQVhvM1NFeit6ZmxOOFFhR2hwWFJTMVd4b0M3Qlh1bXpG?= =?utf-8?B?R3dXV3htMytiWTN0VTNzZHpJeG52cFlHWWVWQkR0VjBqcDN5VUtLSVJzTlZF?= =?utf-8?B?SGdUMnBrNFlUNXVUbXU1U2VGZ29TaEF5Nm5zSlFsb1FkcHBHRUFtMi9oa2xK?= =?utf-8?B?MDk3TFkxRmR2RkJtRnQvWEk5eG5GSklwWFhJNzJuWDlKK1lPZ2tJOERYcFNw?= =?utf-8?B?VzVxd2R3dHF1L0F3eWxEV2I3ZlhQWVlDbzVHZG91ZjhuZXlxcXZueElTOVpN?= =?utf-8?B?VUVwRk9pbXJreCtsWllsR0U3L2M4QUIxVHFyTC9sbW90a1hDZ2l6YlF4OUxx?= =?utf-8?B?eHo5dHN0Vjl1eFZYK2UveXpVL2JnU1hINS96bzI4Z3pKb1pPcU5jSTBjOWt2?= =?utf-8?B?TlI3SFBvRUxNdStwS2hOTXJUSFFrRWxldVY0S1FXd3FYSHVJWFI1VmQrN3Fh?= =?utf-8?B?Vk54RGRmTDU0bHhjcG4xRUIxNHVJSFNzOFJ0TUkwNzg3TktSV3ByWFdQR2c3?= =?utf-8?B?N1kyZ2taand0Y2lEVVJxNFBhbFJkOW9OMnZwcHBaVWd4SjVVS1VvY0MxUC9P?= =?utf-8?B?Z25SV2pieHpWbk9QTlp4RVVlSGhFVnpJTjJ6TGpOY3phMnA3aGVEeGxvRFkz?= =?utf-8?B?YkZCTkEwdmtDb0E3c0hTbHdCd1NjUjlnd3BIbTVOcXJjbGJxSitObmFxWmla?= =?utf-8?B?aXRyZzhMb3MxUTdDaVFwRFFZczZwWk1UR3pDWkRtdXNJUllwSlJ6QUoxclho?= =?utf-8?B?RzFlV0NnMjZsS0xpa1lJMEg1R3c0QnczWEJRdHZzNW5IZGI0eEFRaUFIR1pD?= =?utf-8?B?ZjZCdllYOHNUd1JCWi9nbDcrTlNSQks0U21DUnZiSk5jSlRVSHVlMW9sTTNH?= =?utf-8?B?amUwQ2xvckQyVzlYRWpwMzdTTzNrYjd5R3IwL3Q0SVV0dWM1dzA4eUZVaE5W?= =?utf-8?B?Sjl0RkFUayt0M2hXdzlZNWZ5SmIyMWNZOUpETWtqeEEzRytnL3YyRTFWN2Jn?= =?utf-8?B?VW5BMUFDQmE4em9ISS91RVZGSDAwRmFQLzNCZW1zMDRHQTVkYTdxMlRlMVUr?= =?utf-8?B?SDJ3bnRJZlZLTXRYRURJU3NnVnFlVXhaZEc4OW5tQnJlcmRteXRSVXN2WXVP?= =?utf-8?B?QXB6RVNPNlkxT09tbDc3dlpTM2gvWkdXMDN4cHNDUk90WURjRHZQZTV2VXpi?= =?utf-8?B?d1Nud1MvdVdRT2plMmlvekQzb2drVDhmcThMWWhYREY0UXByYjVqam1jVXBz?= =?utf-8?B?TGMwekZUZWdJQ1VPdU9RZW9yYUJDdkg0aC9FM2srTmZIV3FvVTFTU2N5VmlZ?= =?utf-8?B?WHFGYm9OUmFVVWU2SDViSU5UOXJ2MVhQTFRNNElkZm1TVUpWMFovV1lkdEFF?= =?utf-8?Q?guilVG+ld/94fV/6c19sX5LQa?= Content-Type: multipart/alternative; boundary="_000_4c3976aadad4270728529b26593692d0citrixcom_" MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66ca9dc5-b183-4d0e-2e65-08da6969e32f X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 09:34:33.0036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: A+BQ+5b6JP/i4DQJ/iIp84KGyZegiWuenNQuvnBFLyCWkpW5EmF8M3z7qBLB4xBIGQa17Uy/1mM3aS9YP10+zeahi/AomfXLIxSpd/FL6DI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6166 --_000_4c3976aadad4270728529b26593692d0citrixcom_ Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T24gMTkvMDcvMjAyMiAwMDowNCwgRHlsYW5nZXIgRGFseSB3cm90ZToNCkhpIEFsbCwNCg0KSSdt IGhhdmluZyBpc3N1ZXMgZ2V0dGluZyBRdWJlc09TIHJ1bm5pbmcgb24gbXkgTGVub3ZvIFlvZ2Eg U2xpbSA3IFByb1ggKEFNRCBSeXplbiA2ODAwSFMpDQoNCkZpcnN0bHkgaW4gb3JkZXIgdG8gYm9v dCB0aGUgZGV2aWNlIGF0IGFsbCwgSSdtIHJlcXVpcmVkIHRvIGFkZCBgZG9tMF9tYXhfdmNwdXM9 MSBkb20wX3ZjcHVzX3BpbmAgdG8gZG9tMCdzIENNRExJTkUsIHRoaXMgaXMgc2ltaWxhciB0byB3 aGF0IEkgaGFkIHRvIGRvIHByZXZpb3VzbHkgLSBodHRwczovL3hlbi5tYXJrbWFpbC5vcmcvc2Vh cmNoLz9xPVJ5emVuI3F1ZXJ5OlJ5emVuK3BhZ2U6MSttaWQ6ZjNoZWw0eWoyNXFpbGFiditzdGF0 ZTpyZXN1bHRzIHdpdGggdGhlIFJ5emVuIDQwMDAgc2VyaWVzLCBob3dldmVyIHdpdGhvdXQgdGhl c2Ugb3B0aW9ucyBhZGRlZCBkb20wIG5ldmVyIGZ1bGx5IGJvb3RzIGludG8gRmVkb3JhLg0KDQpU aGUgb3RoZXIgaW50ZXJlc3RpbmcgaXNzdWUgSSdtIGhhdmluZyBpcyB1cG9uIGJvb3RpbmcgYW55 IFZNLCBqdXN0IGEgbm9ybWFsIHNpbXBsZSBWTSB3aXRob3V0IGFueSBQQ0kgZGV2aWNlcyBhdHRh Y2hlZCwgaXQnbGwgc3VjY2Vzc2Z1bGx5IHN0YXJ0LCBhYm91dCAxIHNlY29uZCB3aWxsIHBhc3Mg dGhlbiB0aGUgZW50aXJlIGRldmljZSB3aWxsIGhhbmcgYW5kIHJlc2V0LCBpdCdzIHZpcnR1YWxs eSBpbXBvc3NpYmxlIHRvIGdldCBhbnkgbG9ncyBhdCBhbGwgb3V0IG9mIHRoZSBkZXZpY2Ugd2hl biBpdCdzIGluIHRoaXMgc3RhdGUuDQoNCkZZSTogUXViZXNPUyB1c2VzIFhlbiA0LjE0DQoNCk9r LCB0aGVzZSBzb3VuZCBsaWtlIHR3byBkaWZmZXJlbnQgdGhpbmdzLiAgT25lIGlzIGRvbTAgZmFp bGluZyB0byBib290LCBhbmQgb25lIGlzIHRoZSBoYW5nL3Jlc2V0IHdoZW4gc3RhcnRpbmcgdGhl IFZNcy4NCg0KTGV0cyBzdGFydCB3aXRoIHRoZSBkb20wIHByb2JsZW0gZmlyc3QuICBUaGUgbGlu ayB5b3UgcHJvdmlkZSBzdWdnZXN0cyBhIGNyZWRpdDIgYnVnLiAgRG9lcyBkb20wIGJvb3QgaWYg eW91IHBhc3MgYHNjaGVkPWNyZWRpdGAgb24gdGhlIGNvbW1hbmQgbGluZSwgaW4gcGxhY2Ugb2Yg YGRvbTBfbWF4X3ZjcHVzPTEgZG9tMF92Y3B1c19waW5gID8NCg0KfkFuZHJldw0K --_000_4c3976aadad4270728529b26593692d0citrixcom_ Content-Type: text/html; charset="utf-8" Content-ID: <9064591F4A3019449D7908F9F2AF507B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 PGh0bWw+DQo8aGVhZD4NCjxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0i dGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4NCjwvaGVhZD4NCjxib2R5Pg0KPGRpdiBjbGFzcz0i bW96LWNpdGUtcHJlZml4Ij5PbiAxOS8wNy8yMDIyIDAwOjA0LCBEeWxhbmdlciBEYWx5IHdyb3Rl Ojxicj4NCjwvZGl2Pg0KPGJsb2NrcXVvdGUgdHlwZT0iY2l0ZSIgY2l0ZT0ibWlkOndNVjRva29J bld4VHFBYUg2c3hVdWc2bXk5Qk9sa3VyT1d1Q1VJTEdGeG9ZZTk2VV8tWi1LUGpEZGFjUm11SWtz T01YLWNoYUFOMGxuR2o1WGV2Zk5KS3c2ZklWaHNTSXFCQ3hHSHdlSy1RPUBwcm90b25tYWlsLmNv bSI+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250LXNpemU6IDE0cHg7 Ij5IaSBBbGwsPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250 LXNpemU6IDE0cHg7Ij48YnI+DQo8L2Rpdj4NCjxkaXYgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2 ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPkknbSBoYXZpbmcgaXNzdWVzIGdldHRpbmcgUXViZXNP UyBydW5uaW5nIG9uIG15IExlbm92byBZb2dhIFNsaW0gNyBQcm9YIChBTUQgUnl6ZW4gNjgwMEhT KTwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAx NHB4OyI+PGJyPg0KPC9kaXY+DQo8ZGl2IHN0eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBm b250LXNpemU6IDE0cHg7Ij5GaXJzdGx5IGluIG9yZGVyIHRvIGJvb3QgdGhlIGRldmljZSBhdCBh bGwsIEknbSByZXF1aXJlZCB0byBhZGQgYDxzcGFuPmRvbTBfbWF4X3ZjcHVzPTEgZG9tMF92Y3B1 c19waW48L3NwYW4+YCB0byBkb20wJ3MgQ01ETElORSwgdGhpcyBpcyBzaW1pbGFyIHRvIHdoYXQg SSBoYWQgdG8gZG8gcHJldmlvdXNseSAtJm5ic3A7PHNwYW4+PGEgdGFyZ2V0PSJfYmxhbmsiIHJl bD0ibm9yZWZlcnJlciBub2ZvbGxvdyBub29wZW5lciIgaHJlZj0iaHR0cHM6Ly94ZW4ubWFya21h aWwub3JnL3NlYXJjaC8/cT1SeXplbiNxdWVyeTpSeXplbitwYWdlOjErbWlkOmYzaGVsNHlqMjVx aWxhYnYrc3RhdGU6cmVzdWx0cyIgbW96LWRvLW5vdC1zZW5kPSJ0cnVlIiBjbGFzcz0ibW96LXR4 dC1saW5rLWZyZWV0ZXh0Ij5odHRwczovL3hlbi5tYXJrbWFpbC5vcmcvc2VhcmNoLz9xPVJ5emVu I3F1ZXJ5OlJ5emVuK3BhZ2U6MSttaWQ6ZjNoZWw0eWoyNXFpbGFiditzdGF0ZTpyZXN1bHRzPC9h PiZuYnNwO3dpdGgNCiB0aGUgUnl6ZW4gNDAwMCBzZXJpZXMsIGhvd2V2ZXIgd2l0aG91dCB0aGVz ZSBvcHRpb25zIGFkZGVkIGRvbTAgbmV2ZXIgZnVsbHkgYm9vdHMgaW50byBGZWRvcmEuPC9zcGFu PjwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAx NHB4OyI+PHNwYW4+PGJyPg0KPC9zcGFuPjwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6 IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+PHNwYW4+VGhlIG90aGVyIGludGVyZXN0aW5n IGlzc3VlIEknbSBoYXZpbmcgaXMgdXBvbiBib290aW5nIGFueSBWTSwganVzdCBhIG5vcm1hbCBz aW1wbGUgVk0gd2l0aG91dCBhbnkgUENJIGRldmljZXMgYXR0YWNoZWQsIGl0J2xsIHN1Y2Nlc3Nm dWxseSBzdGFydCwgYWJvdXQgMSBzZWNvbmQgd2lsbCBwYXNzIHRoZW4gdGhlIGVudGlyZSBkZXZp Y2Ugd2lsbA0KIGhhbmcgYW5kIHJlc2V0LCBpdCdzIHZpcnR1YWxseSBpbXBvc3NpYmxlIHRvIGdl dCBhbnkgbG9ncyBhdCBhbGwgb3V0IG9mIHRoZSBkZXZpY2Ugd2hlbiBpdCdzIGluIHRoaXMgc3Rh dGUuPC9zcGFuPjwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9u dC1zaXplOiAxNHB4OyI+PHNwYW4+PGJyPg0KPC9zcGFuPjwvZGl2Pg0KPGRpdiBzdHlsZT0iZm9u dC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+RllJOiBRdWJlc09TIHVzZXMg WGVuIDQuMTQ8L2Rpdj4NCjwvYmxvY2txdW90ZT4NCjxicj4NCk9rLCB0aGVzZSBzb3VuZCBsaWtl IHR3byBkaWZmZXJlbnQgdGhpbmdzLiZuYnNwOyBPbmUgaXMgZG9tMCBmYWlsaW5nIHRvIGJvb3Qs IGFuZCBvbmUgaXMgdGhlIGhhbmcvcmVzZXQgd2hlbiBzdGFydGluZyB0aGUgVk1zLjxicj4NCjxi cj4NCkxldHMgc3RhcnQgd2l0aCB0aGUgZG9tMCBwcm9ibGVtIGZpcnN0LiZuYnNwOyBUaGUgbGlu ayB5b3UgcHJvdmlkZSBzdWdnZXN0cyBhIGNyZWRpdDIgYnVnLiZuYnNwOyBEb2VzIGRvbTAgYm9v dCBpZiB5b3UgcGFzcyBgc2NoZWQ9Y3JlZGl0YCBvbiB0aGUgY29tbWFuZCBsaW5lLCBpbiBwbGFj ZSBvZiBgPHNwYW4+ZG9tMF9tYXhfdmNwdXM9MSBkb20wX3ZjcHVzX3BpbmAgPzxicj4NCjxicj4N Cn5BbmRyZXc8YnI+DQo8L3NwYW4+DQo8L2JvZHk+DQo8L2h0bWw+DQo= --_000_4c3976aadad4270728529b26593692d0citrixcom_-- From xen-devel-bounces@lists.xenproject.org Tue Jul 19 09:37:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 09:37:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370504.602297 (Exim 4.92) (envelope-from ) id 1oDjf2-00011L-0T; Tue, 19 Jul 2022 09:37:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370504.602297; Tue, 19 Jul 2022 09:36:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjf1-00011E-U4; Tue, 19 Jul 2022 09:36:59 +0000 Received: by outflank-mailman (input) for mailman id 370504; Tue, 19 Jul 2022 09:36:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDjf0-00010z-0V for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 09:36:58 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80078.outbound.protection.outlook.com [40.107.8.78]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5494f572-0746-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 11:36:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5679.eurprd04.prod.outlook.com (2603:10a6:803:ea::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 09:36:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 09:36:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5494f572-0746-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mUckE3dvkHn4P/wKeqyN5BGwM+vW5uYJ2JGlsoqLQTDibrydhgH2lp+JB5sInkAA2JrwBo8KxGi1D4bcI3/YEXuffn72wOizsCOYrala5ZNu2FdJF3shci7NaW5lCBQKzqPB0JWmg4QxPS36iDwG1GE4PeEdIRblLO5vV1UWomsfU8MKnApu/rlwByl8EtMUfAYpEbF8a5QW28NVoVivRxwmIpnUgRGuUMrrr8+b0DZRe0mg91yUI0urPG4ordo0+xS0lWt/866qeBuFpqI6yaU/qPWcOd2F1TUl1hKYxJKfyQFOqLuYr6dmkEmcXqhanJHHBHCyl7iKd7FrOqXz/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LKUbbPv7+dRxb1QL6FA+0ZSJh/h0yAdGOQWjDusTHwg=; b=fhUx1txzi71GRogv39oJuwZkg2G0ycj9xMybVMdwKCBx+/SujhuUMfy9b5cTVfI8ho+cuiFNSJGL5LHX06sikNISUrGz0alK4YH9EICOOF9V2eJvjD9zcKV0wyTmYY+p7dD1ibO6RRqfYScl2gfZuBXGYR8g/iJM39+DNV+4kLu2Sgwr2LJ+rJZuFlv/tzW0fN+NWG9+YJrnO8BQ7DdKgqKW4hTf/3LYRMfatFhgU7L96DLvqZk2PCTMXS0o4bCltRwzmQn+0s9YRA2a8XcEIeTBgzgHJ4pOM6A1aPvBljbNbR5FbebfacDjQ7vij4SDRhUpm5OJxz1Jo/cIwxW0Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LKUbbPv7+dRxb1QL6FA+0ZSJh/h0yAdGOQWjDusTHwg=; b=zvbwyVHSY+VC9ydO2HgXXJH06PSb+PIfFyU625Htgs3Km1ha8aPVtSVU5FLSYRmlGxnmjIbUQv8NSE5aLmOyzaBTrw9+DJA92Sj8J6BUBgYecXWZCexnC6B7AW8MAlbYCisyMNMGn4QRQ3UxD7KaFw9NVUH5oOZSfc2mMp93n5CxossgZL6KgumFdYM5/lhFsJQ/pC1QxyXybxX2VMZDtD5padg1g5p6Er7IeR1+167FC1MVLhA8D0xsWpLZoUrOP2e6k6LPW4Uwms6+NkLwkNzJy7Oy6GRPvCWmpCoposYOGx8h22N6tLN+Ocz7haU7HwBPNg+SULlxNQMpFr/oxw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 11:36:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 06/18] fdt: make fdt handling reusable across arch Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org, Volodymyr Babchuk References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-7-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-7-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0024.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 237c7eb4-38e0-4038-aea8-08da696a37d7 X-MS-TrafficTypeDiagnostic: VI1PR04MB5679:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kbVa+3Xacfu9oVs42QmGzY6ogJ2ML9gkw+XHa147BKg+lckA+j6V1CH0gxoQ4uAyl+SnKh9u2EljxwHc3ng5jL5FFqwdgljGwOrOkIkOmu0NyDcSJ09W1EgmTylNeLl67r1RJJbdfo+onrz9nOrDOt8Bk3oZX9gfb7fFxtlhwhvoE6K4VgGShwWtGsmI8+2Hbjh4svij2lINziKjxeU9P1bdPiJqROV5zHdSda6s+7qMGdeIwR3MnlslmNMJ0p1h+dO9BYNXLj1QL+jbFQufRYqzy+OJdxzyNEKTe08IbchCx7/CJycbwtUndQgT0Ao8D2uPoGIHifh1grVFZKPz3L85/mS1tVzuiKETShT3DQR+pRjUswcJ5Lbz2adT4qLlonapDADhUwzqdu3wJ1lLZGI2HciEcnU3mJC9+X82TExRJZPdB4ad9gcp+JNrADiQdyoMuFStwCFM+X6w3X7r7WP8EQ+8CikJeqwrIRWDLqxvwOjkULjBkRHNDhxmxaO1m3yX9kekVUmGt2pKFdrRPppzi0LYkeBgs7r+Q5qtd/st7Ov7zect1gClA+FNI5UMYvoRKTcBTRLgAZNhxwzuswnJDUBEfguunhGsPzp6iPQi5LNYD6XIXZp9wa/IPXrPUmtU0RTFReiOveeiODVWSz+p/8E41kdVs9ytloX/t1No7XgAwPpbztoaTjOcPVXB8vgckc+D46q2X+2Q5PpEaTIpoVdSVecOBlXtSZwFZRfDxHx27sNlJncZRMf5XfHAor0gEDyZ/P9KELmTjMYr2+H5n+u+AUom57ov22hK1E1lWFi1vkAhE7yAwmtc9DzT6HRezTOmeNtMmWGG4V5s8w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(136003)(39860400002)(366004)(346002)(2616005)(5660300002)(6512007)(6486002)(86362001)(83380400001)(31696002)(8936002)(6506007)(2906002)(53546011)(7416002)(26005)(41300700001)(478600001)(4326008)(186003)(31686004)(36756003)(66476007)(38100700002)(66946007)(6916009)(8676002)(54906003)(316002)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHhGMUZHcWdqQlhrT2xNMzJHQ1FjYU1XRHBOUjZndkdVYVkyRTFPaDhRNndz?= =?utf-8?B?RHlYek0rbHRWQlhyN3FhTFpoYU9wVks0ZjlleGt4UzlqWlRMenR4bGVSZGln?= =?utf-8?B?UXFQRDVpWVJVMVJ2eVlYa09UZDhxb0MzRkx1WEVGRHJ5cUlOclp0LzdqSEtp?= =?utf-8?B?dTBod0JnYTB4UTRDWVVwMlk1TVhSQmN6M2FDcnp0eHlRSjk0V0lHQ1V0YjNv?= =?utf-8?B?SmsvUnJTUUdmTDByS0tJczJjeUpFRXcydzhkNzllcHdpcDlrVEdaZjJya01w?= =?utf-8?B?R3BXZDlFMTRhYU0weUg4YjBNaU1tWjN0MUJPVlY2a285Ulhyc0JyNk5JdDZh?= =?utf-8?B?RGh1ZE5LVGFrVVQ3SVVoVTNmR3FwUStMY1h3TS9ZT1ZJSitHUytLSTlsRVoz?= =?utf-8?B?c3FDZ3VXR2JLd3EzL21oN25sSGp2QWJvVSs5eCtJZGxYbXpVMTg0R0w3ZmVw?= =?utf-8?B?cElOeExKdERHUGlFMmsvbFliM2ZHZ2NlMC9SeE5HaUU1emZid05yWEE2dTZV?= =?utf-8?B?WkpMb01xSGJPRExQMlFlWTI5ZXpBQWFoR1VwcnZSeGkvR0tvcHZMa24wZjdU?= =?utf-8?B?WHdqT1ZLVVE0RVkrV1ZLMGxBcVpmTkJsK1hibHFaemhHVGxPMnRqbElaSFFI?= =?utf-8?B?TjQ3MnRYVlpSRUdLYjVjbDVFSXZGL1dnYkIyM01ncVdpWFZrQ2N6emsxWFIz?= =?utf-8?B?YkRoUjVacnhJbVBOWDRmSUVtWE92a1BXd1Baa2pIcWl5OWxPb0ExWFNiV0VB?= =?utf-8?B?UG9hZmpNZElqVHp5WkYySU9jRWtlcVdzMXRwRjE0TWljb1l0Qk43dlJncWYx?= =?utf-8?B?UndGMzgvaHUzbnpqZ2tIWU0zbS9xcmRvdStsS05RSVMzb2puZHptSXlvM2Ny?= =?utf-8?B?cnNyckZPeDVKUmk5dHdUaGJiVG8vWUFEOGFFclNMQkNQVmFXOGs3V1lyVnQ1?= =?utf-8?B?TjBFVTBxOG03Y0szaDcyZjVuNnJlM0xVKzY1a2RRNkd1NWU2czBPaEZ4eWdI?= =?utf-8?B?c2I0WHdXemtZakY1M2krZkJwSDBEUlVhZVFlMU04NDF4L0VPRGJTMFN0MWVh?= =?utf-8?B?RTRZRWtXM2RWNFIybENxVXFrVWIrejE0UVBmOWoxZE9EdUppL2JXaHFqQ05D?= =?utf-8?B?YnNZZC8ySlFrcGNETWxVWXBiK1Y5dWdQcGxuU3ZGZnRhZUVpL1A3MFY5VVNO?= =?utf-8?B?T205dGRPdjNKWkVIa1FYVjFJOFhiVDlZaVJaNTRLT1RMMkRnNXR6N0JqRERo?= =?utf-8?B?QXJ4Z0pDUUZuRDgvY0JjNEVkN25zb1JWMStIU3A4b1lHVVJzMjFxT1llSWZj?= =?utf-8?B?VXNIM2thczhYK2N6NUJQT3NGMERxV3o0NVRBZitTRS9kRFhIL3IyMDFmMlBD?= =?utf-8?B?Z3pwWVhNSjJNZWFtc2JOZzMydHRvRU9oQkdkK3Zmek5xVEpSeXk3czkraCt2?= =?utf-8?B?ZTczQXdYM1F4eXphZU0xaUltRWNzSUtzODBtR2kybVB4eTBPWXZWR0VZeXQ1?= =?utf-8?B?SzF4VEZubTJmVWNaYllINyszNUZ3QWFEY1F0UUsycjNoV3RKb2J2UWovTEhl?= =?utf-8?B?QTA3b21HaE5rL2h6dkdrUmFCNGQveWFlSjNjTkpnODhXdEFUS3ByQVBYQ2Zx?= =?utf-8?B?Y3lQTFlyNEt3MXJ2b1JvcnIxcWo2aDVoTDRpNGtYU2l4QU84Uk5SeFhqb08z?= =?utf-8?B?c2UyZzYzWmYyd0xWUGFIb3BjY3Ewak5GYVRzZDY1b3RQQ2x0amV6MEdJRjFH?= =?utf-8?B?eC9BUldwL28wc0pEUnZQQnlmY2JDckQ3Z1Y1eUY5aVEvcDJMclVqN2p0NEpZ?= =?utf-8?B?bm5GTkdmM3h1ZHdFUUlRRjZ0Y2RCMzRBNDhMWTVxdThYalIwT0QxOVp1dmNk?= =?utf-8?B?M0NUU1VQcmhyMVdEakNtYzI0alFveVFyM1RHbDFxbXRyVCtjNkJoc0s3SFJ4?= =?utf-8?B?LzBZS0tlN3F6c0pqcWkxd29lSWF6dk1JMVJ4UHlSMXRFQ0RjaUptSkRPaE1F?= =?utf-8?B?aExQSDNJSkxhOHB6UWFkRk9TZ2FSYVlMWnN3cVMyZjhGZDlDUzlTQzgzWUN6?= =?utf-8?B?WS9wNUp2OVJnMHdZK3AveHphbDlHMUhEa1Y0c29CNUhqMmk0anNrSzgwSFZZ?= =?utf-8?Q?KxlyGuCskRaXhcJDJtqdTnzko?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 237c7eb4-38e0-4038-aea8-08da696a37d7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 09:36:55.1771 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d8ryvRgzOxsYtjtrEAYuRQ+SkawC9UL9C+Nph/goC2608rRd4BW/7qWv+ckt1OMy7Vuk0cK8WekMTDlh7DpNLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5679 On 06.07.2022 23:04, Daniel P. Smith wrote: > This refactors reusable code from Arm's bootfdt.c and device-tree.h that is > general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is > introduced for when the ability of parsing DTB files is needed by a capability > such as hyperlaunch. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark > --- > xen/arch/arm/bootfdt.c | 115 +---------------------------- > xen/common/Kconfig | 4 ++ > xen/common/Makefile | 3 +- > xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++ > xen/include/xen/device_tree.h | 50 +------------ > xen/include/xen/fdt.h | 79 ++++++++++++++++++++ > 6 files changed, 218 insertions(+), 164 deletions(-) > create mode 100644 xen/common/fdt.c > create mode 100644 xen/include/xen/fdt.h I think this wants to be accompanied by an update to ./MAINTAINERS, so maintainership doesn't silently transition to THE REST. I further think that the moved code would want to have style adjusted to match present guidelines - I've noticed a number of u uses which should be uint_t. I didn't look closely to see whether other style violations are also retained in the moved code. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:13:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:13:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370520.602307 (Exim 4.92) (envelope-from ) id 1oDkEg-0005r9-0d; Tue, 19 Jul 2022 10:13:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370520.602307; Tue, 19 Jul 2022 10:13:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkEf-0005r2-UD; Tue, 19 Jul 2022 10:13:49 +0000 Received: by outflank-mailman (input) for mailman id 370520; Tue, 19 Jul 2022 10:13:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkEe-0005qs-N1; Tue, 19 Jul 2022 10:13:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkEe-0005Bs-L4; Tue, 19 Jul 2022 10:13:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkEe-0007zl-1k; Tue, 19 Jul 2022 10:13:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDkEe-0001mF-1J; Tue, 19 Jul 2022 10:13:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=goT0J46tTppy6SCZOHY3yPB2NsKZd/C0XvKJc0OG4MI=; b=hXPOBcRsENZm44nqkShD5JYVNm 59q8pGE7D8WAD/Utxjg+xO02vvzaAB8JOodyS77nGKtGmWGDMBAbq9uV0v4g4ZTyFkC2R3QmWevne L0A2yhTS29w85Jos0oOjVaD734Z+Pkc7nj4Ejh+x8dcvC6uBzYAnHYLCSHJV6HpAxVS8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171682: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9723507daf2120131410c91980d4e4d9b0d0aa90 X-Osstest-Versions-That: xen=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee From: osstest service owner Date: Tue, 19 Jul 2022 10:13:48 +0000 flight 171682 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171682/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9723507daf2120131410c91980d4e4d9b0d0aa90 baseline version: xen 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee Last test of basis 171673 2022-07-18 19:00:24 Z 0 days Testing same since 171682 2022-07-19 07:06:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0e60f1d9d1..9723507daf 9723507daf2120131410c91980d4e4d9b0d0aa90 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:32:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:32:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370531.602318 (Exim 4.92) (envelope-from ) id 1oDkWo-0000AB-J0; Tue, 19 Jul 2022 10:32:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370531.602318; Tue, 19 Jul 2022 10:32:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkWo-00009y-GM; Tue, 19 Jul 2022 10:32:34 +0000 Received: by outflank-mailman (input) for mailman id 370531; Tue, 19 Jul 2022 10:32:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkWn-00009R-A9 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 10:32:33 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 17bebed3-074e-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 12:32:31 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26J9c4iE016342; Tue, 19 Jul 2022 10:32:27 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2107.outbound.protection.outlook.com [104.47.18.107]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hdt2yg6ke-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Jul 2022 10:32:27 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by AM9PR03MB7948.eurprd03.prod.outlook.com (2603:10a6:20b:43b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 10:32:25 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Tue, 19 Jul 2022 10:32:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17bebed3-074e-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqjqhUN6NZIMWs7cesoqNtyc016duieGA+OpXt/1BzygLNcH7puLWf0PxWlK4vFNtHezWgBWEEIfSEBCegeWrzynpvo6sdeDyc2KvNwT2V0YCmYGGv67nuf73Z0mH+PvDXlyO9wwy+azc6m1DQ/F8ljtBXFgJlVfWaNA12v9n9jQTdx/bRxvYRfs+6CkTLUU2MoC3wpgZpKCjgyPKM/zMGY1rET0HIYl6snoQ9iLyYZSeb3wSOZiVItUXJ1EBh4W9K8WULbsmK6N7qBSCMrr8xG3dsoPhuNC9YSrCxG7v4p9qJyMfYLjAMDjddUOqqg2+meTuG/VVlDe54xIRQMfCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BY2AUKfBxi9X7pJmjnwBZcV/H/f0NIH5eYvKnlU1nYE=; b=OBZrMQ1yzUQgMBuWoAepy5scmJDN2kwmjobXLq70j5JWeeYuoNqhUKrqrHW6Wk5WBl6a4f6DyQ5qjGxZL8xR5eXR3TI89wyhCV9kwg4An3l3YgsaloR1RJC+WrcpYem0lC41v6H9BXS70cvst01Z7XRtzBtJVwbwXtrKqiJmktHhR1JgXWIQqBS3UH8V0anyzPWnLlQClGG+nr+PeglSnjabSMYHNI6Di/eYhXIpe2thYPvutHnm2RqNfgfKHTT+Nv/VH9OHXhse6RyqrN9mR6vPoZSNwZwiSOCAU/Vu8aoe5brTlYCZ7/BrA1UoBEQV9ouMiOuodxkcKt34RI48HA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BY2AUKfBxi9X7pJmjnwBZcV/H/f0NIH5eYvKnlU1nYE=; b=abqc0ZfgTG7VdsR+VaJO++6j5rZPJvbotC42cD91RDg66l5qjBDah5Zn2ys7k3lY4GB/N9SxJM2VJ05SuyUEmYQ4CISot3v8If6L7efxVXz8bUEbjBeoslpaBTBucFKPJwEADNVvp8XWOUN62PMbXFxlwn9YB64QW86yYipIqtS3Ro5kjpYnLke6J3jVIu3q5jGDyot/UrsvKzK6A3lPtl1fx/KAFt+k/5YCOupnoVftSIM+6TI6Ld/eBLLPGHBkp3F82tPhs63AcpksyWV4LYRDrFAwOvIM6+bQKULaJw6Puz9gUC3lggA9amXtPaWcHNkrWu3ky652h1z2UZf2XQ== From: Volodymyr Babchuk To: Jan Beulich CC: =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Thread-Topic: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Thread-Index: AQHYmuuJ09LC1x/2uEWs942YY/fNVK2FNeCAgABJdQA= Date: Tue, 19 Jul 2022 10:32:25 +0000 Message-ID: <87ilntgzpj.fsf@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> <20220718211521.664729-5-volodymyr_babchuk@epam.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.6.5; emacs 28.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 90166373-770f-46e2-69d6-08da6971f8bb x-ms-traffictypediagnostic: AM9PR03MB7948:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6v+4zrcmE/yL8IM6y9g2VUOT3EROJY/nTW1Lbj1UurvF4UGCl6LU9Jktem5N9zP1nwbT4YXm8xc7RKd0qslkMYqdFI0vJ75uHXxyzT9uZ78cYJQa0Sr3FJtivZj3zrx0VdVoZ2cvC6A1k0zemAmv5zN2qcoODwPEw4vrvVdEhtH/7us3E9sttrBAI8DMyhF+aRLOkYpY/SWmZgdIk33R8F3Sz3UgAKfTYgqoOLkTfBEqTbfmw3ZZFRvhkbX2v15e9Olqu+JxGyQ9P2G7SuPGDP/bRRG4DrOE/4pRSlsFkSgCWIyAYXkdOiB7KfJ9XK5wtj8LukQjZsLBR6iJKxAvT6+0bZgqp3BeVAxU5aNCmkdJGih+4B8k9bHmxRCPcIlAgpMzaW5RDum3tv6X3MhvJ+sRbCXxI+mp2g67FYA+vldK8gLkdirX5aMD/RMXtGpssPsvEpnxdzo20aqWZHefJKW/RqJSL8GWBzeS72FEX89R13jVLDTsAlWM8/stnFH2IqnGoOU9lknsAmLgXxYQAKa3symvcAZV6JhW93HUIgXE89Yf/+0rAcVS4ZQI6mwRKPtX8Ok8p1K64o2EhAMPR5YX+vYn+6/1qtO/4q+rgPRtfdCPoj4wi7Jhtss4qxSRCIyfiZ8tLWWQl5dBKWV5dZurlwJyI0bKSDzUTmAe7FqqFqnFaAcHb46w9v5/MMbJifkcBEb0qq2BddhlZo+1JhzOFKutkyGkDmaTG8pFrpAvqhTN3Og/URAnFOBjJi+Tkr8fwDRz4CQHNlggfBYeJh3VQ/1XS2moYYvrenQ/q5g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(66556008)(41300700001)(6486002)(122000001)(186003)(478600001)(71200400001)(53546011)(2616005)(55236004)(26005)(38100700002)(83380400001)(38070700005)(66946007)(66476007)(6512007)(6506007)(66446008)(2906002)(4744005)(5660300002)(8936002)(4326008)(91956017)(8676002)(76116006)(6916009)(36756003)(316002)(54906003)(64756008)(86362001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?pWWvQqK82oElIBOHaPEVRf1iCHEYuhaAXZifs5ok+jYaHSbk2pIMNA15qJ?= =?iso-8859-1?Q?pwJ5bG8SCA1rHUWls7aM7+HNL83LH1vqqlGGTeMdPfwYiuftiGVjzg5KFM?= =?iso-8859-1?Q?e3/bWdZbo670HVo/4GRhf+5YF2ip5ERXMBUz1T5FwZFHKxz80SFOg27wJm?= =?iso-8859-1?Q?GRKNdlJG1USPGvpvhiHe7h3nrwNi1/HjGTReBc6RgF3s1CvgnEytO3DD0w?= =?iso-8859-1?Q?F598J6AHRtHdBY9NEihBBffcatFaO9VbMXkg35vQ3epQ88ZqbhvMgs/HwB?= =?iso-8859-1?Q?QnpirvCV5J0Iad8yqyDJFxR6Ly8al/6Mixgl19Nuzva56zSpmQs0QrYSel?= =?iso-8859-1?Q?vSQAxtRegxFN+2wjs5fw52rlWfTsVw067DPouuVRNTxrT60JckPE3pCquV?= =?iso-8859-1?Q?duK5MToVTnzasDlRUwfoFbE3xKZQG+z1Am8VzQyqPdqcWGr/SDxpdbxOeb?= =?iso-8859-1?Q?ZJtDd7SH0zs1C+8TR9WE6k11sjLASyW+yfj4cEG2ti/vWBPKJ/bzM5xBtf?= =?iso-8859-1?Q?K4bFFTuNVdvNudX12UfmzSWHX1QzAB14H5IcGllUrh39BCfXBn74EjuJ8i?= =?iso-8859-1?Q?A6MEFbJD4PGYP2XGVCauFA7/2qDp6nWzoTYiga9QnTn5XSVyNmizcACyYJ?= =?iso-8859-1?Q?EqhiUYzyCwF10g09raovcZoki+Gvcn3N3KrLvsR5g5FLktIP+jS8fv5tOu?= =?iso-8859-1?Q?r102EyHBDZ5LjkGVKdomUaXtlmjkxx5dBRmV/RJC9z8hFBNtLftn40tlZ4?= =?iso-8859-1?Q?HiY9480193Ap0VUbkD3Uy+AEC54UpinkgiMLnNK1pv1os+hDoYyom1PSdT?= =?iso-8859-1?Q?6HrDwGhDsqobitPdPilQ01ak8H161h3SxHpz5qWSFllNrmtqXF7DrcGcwv?= =?iso-8859-1?Q?8tOytjQCDE6+bG4eCb09ieLSfymc9D5tk02FU0nfvN63oSPABGfcaTUnLT?= =?iso-8859-1?Q?aQY4pwiAHCz0gYW3yjQM9Y+X7mc/sRYlFXYx8UG2tZMRLn54zKiZxb5zDQ?= =?iso-8859-1?Q?ggFE8GmYoBsowRO15IZoVFCq4R5QkWLFSAR/8FOK0of6y2ngbBtEeZ6JW/?= =?iso-8859-1?Q?c4w5+QxCJiTI/PIfz565VTM99xMm62H4ufYJAsC392WhXK6gzYwQ/0mU84?= =?iso-8859-1?Q?fKq/lL07jM8c+5aDVc4kt8603QD6xNh6nxN54KpYoKGiu2piWL9Bu+xYdw?= =?iso-8859-1?Q?8s+/qhJY2Pdqix6Oj6rDAqDRDbo19WDvPq/3pfE8iCV3XmUIyTbWJ7c6IU?= =?iso-8859-1?Q?/KXE2m2qVHxsbho86v7KYzalP+8tzwI7pLOnlN63jCtcqBSnbjPoGSMxOS?= =?iso-8859-1?Q?pYG6gxSyYggIm/BT82peif1uYhlSY+GaBChI0ixEKpDjy+xg4mPFv+w2Ba?= =?iso-8859-1?Q?tKHiz+Y8mUUAfRJsyFJQ6V/8Fn7RL3QKaUvsk7Z7X0QRjSNBjmLbJ+6Q8U?= =?iso-8859-1?Q?VE/INzgtXqUaXWVg4rTEZ9q/8MJbsjfCW7DkEzlYLzkpAdgJlWHuzoo7OS?= =?iso-8859-1?Q?vZrmBMqYaqxCDtGqBYp/vylVREnzv/LAXMvIpGK1OH2mG8T4hIXNGCH5sh?= =?iso-8859-1?Q?bD1XNkQI957JIdC6+tLJAqPqkNG9ftVRkj2LT5h1ec4owTaLWjOKv5F7No?= =?iso-8859-1?Q?bw+bcB++IVZGpswpzkhd9yDDJ2R4K8cI9NxkkRlQ21b4jj/IcytKaAJA?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 90166373-770f-46e2-69d6-08da6971f8bb X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 10:32:25.1130 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B7syTT87qDDfTq9E1I0Fqe2HrREqTGRL7tqrbCbq+qdeJJ+Z+JalOyDCWgFqEq8s9cbsKPkUleGYfV2iB1iZ0KyrdjAibbQGXR1gkIGkiSA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB7948 X-Proofpoint-GUID: 24UIyhoREGNrPAodSvB8CtVuga0TKTXW X-Proofpoint-ORIG-GUID: 24UIyhoREGNrPAodSvB8CtVuga0TKTXW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-18_22,2022-07-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 mlxlogscore=663 suspectscore=0 impostorscore=0 priorityscore=1501 mlxscore=0 phishscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207190044 Hello Jan, Jan Beulich writes: > On 18.07.2022 23:15, Volodymyr Babchuk wrote: >> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >> iounmap(), but not added corresponding include. >>=20 >> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") > > I don't think there's any active issue with the "missing" include: > That's only a problem once Arm has vPCI code enabled? In which > case I don't think a Fixes: tag is warranted. > Fair enough. May I ask committer to drop this tag? >> Signed-off-by: Volodymyr Babchuk > > With Roger away and on the basis that I'm sure we won't mind the > change: > Acked-by: Jan Beulich Thank you, --=20 Volodymyr Babchuk at EPAM= From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:40:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:40:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370538.602330 (Exim 4.92) (envelope-from ) id 1oDkef-0001n5-F6; Tue, 19 Jul 2022 10:40:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370538.602330; Tue, 19 Jul 2022 10:40:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkef-0001my-BK; Tue, 19 Jul 2022 10:40:41 +0000 Received: by outflank-mailman (input) for mailman id 370538; Tue, 19 Jul 2022 10:40:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDked-0001ms-Vv for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 10:40:40 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10081.outbound.protection.outlook.com [40.107.1.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 39ecd785-074f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 12:40:37 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8855.eurprd04.prod.outlook.com (2603:10a6:10:2e2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 10:40:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 10:40:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 39ecd785-074f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WoBxl18nmlFDs7diHv14QIe94PiteUQXz4poWylD0n/rthcbbzfQbSPLoRhj4mqRlhkfCbPa3DNLoZTtMFCGbEgxKXQsz5h7KSIk/QIhDl8wPmRkoUq6SyK3DbUkzJvRpcSKH/yL4/AOttniG6L+5gDu2hkRaGTr67JkCg//0ZLRRYGThWSZ+UfbRtlR/cu08Z+TGLNhLN+ik21Q5l7xnd6aOaR0onzx9RAY3xVrT8ZojFTWNQLcWTE7tMQifooA09WdH52XPfq8dLvyDjz4f94oKvKOG/Oa7JOJmjRH8urq1fZ+SoOEt9zvvTA0VFxnavCmLqte0khT5LGBt3LUbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gRjwHYs/6+ulOWiNct/cBA7oHfv2XFfc84i8pr4DY4Y=; b=Q+MKDLAnMZ2lUZZuPSieiQG9laTec3Heg6L6FbrRPFxYEI3LSmWxpNauYe/16ckag0NR1zJPLOWKJWkC8Sel8xCYMhSSaLGRBrcwY7hsge52lDa3hOKvN3KzQ/IiKbNwL2cC2rXQUiUg5L527w7FxahG8Si9VuVpMmpJpWwpQHQe2S5nSevYl2GRwWfCknHCqZ201SWXPKeEcwrT98J+5MQAi3YemD/mbfynRf5Hygwo2V9D2oNC58td+CLieXFejr884Ze6JJg4ftZcJbfzNIHRlhwyVwRuZkV5AO96K1bl3TEhdxFszWSr28eUk7x28+8VORRrEwGHTo1SSINtBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gRjwHYs/6+ulOWiNct/cBA7oHfv2XFfc84i8pr4DY4Y=; b=iDmIxbj5tpaoKxwGzZ4ICBpdsMzXAYDXZUYTaE/Z6tf4HlKYpu4oY7sM1LsYLJnOH79Ra6MEMfnhK249yZxMWW77bdN4llkhb8WD/pEwtIXTo0Tpe7HXOxssBV0A7ogvraYymovCTDtHQ6XR57P42MSmII6ucEgC41+n5RCVMBrIlGrV8/sWhuIeAWNWwa0LrU5o2W4oyrJukZdbNvL3Z7vPUuW26TBCkaF/x9e63Nz3rtbi5xwS8VSlbvN73db6eHeqrj9DWi94XGNjod7GVlpA2xQJStw39/vOv7AnqA0QvxDGPfT0kNYTnbqiiag8GqoNwc6Jt0TdkzdNM0MgUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3aa941de-3dab-0265-02af-38ad1cc3a4f3@suse.com> Date: Tue, 19 Jul 2022 12:40:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/4] vpci: include xen/vmap.h to fix build on ARM Content-Language: en-US To: Volodymyr Babchuk Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , "xen-devel@lists.xenproject.org" References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> <20220718211521.664729-5-volodymyr_babchuk@epam.com> <87ilntgzpj.fsf@epam.com> From: Jan Beulich In-Reply-To: <87ilntgzpj.fsf@epam.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0034.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 266669a5-bb47-46ba-1aa8-08da69731ca2 X-MS-TrafficTypeDiagnostic: DU2PR04MB8855:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /yTpuizHkCo3rRk6PvANPx9poMGK8YrFIub4aDYKPSE8z4eI45MEALPK0KQ7sfIrP+Wkufuh9x1nhutdxIH3lisxBEuj3ceyeVfXYSE5OxpMxrTxPM6S8xtaNGOGM08mai+VCsE0AL9g4ALSAlNs7vCTQvHz6B5ZdN4Ph6ihtbaebxNKXgSuuXDj9dbHrCydeY3S1fiS0u6329xQV2zbA474PT32e9Hu5nChdVREjukqX2V5Y3N13ysGjZcndGMVCzUKvN6leYN+cJlrd8+uWx0ah0nTJqmHMlI6cnnEKuFro6maCDSF8r+pHH0PVR/PeJ1eNspL+zyI+J2SHlc284KSg64D9jcrl0Q5AnZv52SsEDu4uM2yUy4KwRV6R9rcTkLZfUN4JFfGbyuyVIW8KysoKj2hl85r+d1yX3zFm5v6llXcmkCAbsFIkeOjG9//FOvEwP5fsymeKPsKtSAX/MJS53VI3UTsGEjFKwO5sSll/kUkLfZLqE59kSxRJ1UIgFTtojowa8w4K7wNrqIlbSycIMFyM6Wb4iu3hYgjzLK3rzFzOIwaZHFZUvtp33Onu06gGQk7HLUPS/rZ9Z7W4dl2Ivm9DPFmJwVtnkKlNp9NbTbPJLcjkb59A6o9HBPXa/FsEphMOEBDrEyzVrAnk5TBI9j2iRhtsqc35eFUQsLx7vzzTsFzqTdO5qtWJ6SojqVaLTPCGRvd9S7B6Hf5Q4xYCIPcdUubc6u57LUES5X8NHNpu6w2zunFln483MYiQltjADdMFn6TdWnOc7SibqjbsZ6MszDgxdY3Q2FoEX6J/M9oBF8OKI7Dbbu4NnusNqZR8tdsGyYLqpPAF/Z5GQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(366004)(396003)(346002)(376002)(8936002)(66946007)(5660300002)(4744005)(8676002)(66476007)(66556008)(38100700002)(4326008)(186003)(36756003)(31686004)(86362001)(31696002)(316002)(6916009)(478600001)(6486002)(41300700001)(6506007)(2906002)(2616005)(53546011)(83380400001)(6512007)(26005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TjhndUNPVFJiKytXNUdwNnFTRG9ZRXl0Zkp3RmhIcG9EakZycml2ZVRPTVFZ?= =?utf-8?B?amhkUkZKZGZQTzlhVEJMWWFVSkZKOUVuTVQzMnR0aXp5OGlXTWFrUi9UKzdN?= =?utf-8?B?Z2FYc255UjRwcEV1MGNQUGllbFltbnVWdld2RXFKc1BIMEl2WkpCcEVMQ01v?= =?utf-8?B?c0Zpc0hNOGpsWWJXSC9tYlJxODlISFRxTmY2dUI4VTlXTGg0Y1J2NktWMmlT?= =?utf-8?B?b01ncEtjZUtRaUdDcXFSbE9iY0V4SG9kMWJmdFlpaTdPbFJXdFgrVnZYOTc3?= =?utf-8?B?TnJRTTRGRy9LcSt1L0hVL2tVUjhyN3hlSW5jVjNCVG9HM1piZmN0ZUZBWUxV?= =?utf-8?B?VHlHNUpGeHVMdWZxYlBSU0xNN1d4NVo0dDlFdDNpbE4zbVZwdVd0dVdUcXFB?= =?utf-8?B?Y2pvclQ5elJvenNrQUJyVHZ3ekhabmkwZjg3TG1lM1FFS1VCRU1pbVhnUkJS?= =?utf-8?B?OEVhU2lXZWJSRWt4VXFVUytvc3lhWlJVSTg1azg4b3hhRmR1L3l1ajk4dk4y?= =?utf-8?B?eE1sRHdyMWs4T25SWk1Ea00xdFUwNi8yQ1VlOUJxMHJ2djArUzE2S1Yxb1ln?= =?utf-8?B?VXlkTTB0TlQzZmhNS2dPZlBWV0czZEp0YTg1c2pqOTg4b0NMS3hrV2ZqY0NX?= =?utf-8?B?SkhWVktCNUlJV3ZmaDR1Uk9PdncxOE9DVjFYTG5tbzBLVHFiNjdPc2VYRXZo?= =?utf-8?B?R2hpNkRDNFQrVFpwOEtCZnU4N0ZJNFJxajlzVVN4b1REaDBMV0FVQ0thOEJt?= =?utf-8?B?dDFqcmhTT3prdE4yV051WVlCemdxSFdYQlA5UmZiMktuRWpSWUQ0cWh6cC9C?= =?utf-8?B?VUJieWRiL2JXWHJoN25mb0FwTlN6NWVMU0IwZWFudFpQdUN3cEdBS2phbUND?= =?utf-8?B?VndXSUJpUFFVV2VFSkthQ2R6ZzZtdWY4MlYrcEJLbldDb3lMczR0OE50dUxn?= =?utf-8?B?S3hGZ2RmUWFUZ2JaZFRuWVBhblMvanlCNy9NdEVRM3NSZGFabWtyM3RzOFFP?= =?utf-8?B?V1JOYng4WXp1VCtUS2ZnbjJRM3JVNFBza3VXMk9JWjdiekRqMU4zQW11ZDYy?= =?utf-8?B?WkRxdlFpdjVyVUZmbDVEb3gwdDArTXBuaWNlN253MXZ0cFdxT00xSlRGVzNa?= =?utf-8?B?OUM1TkMzVzc4NVFkdDB3di9wNjhsY2ZQWjNpU29QOVpUQzF4NHdodkJBQVk5?= =?utf-8?B?RXlKOTlXVDYwc3FySXF1SUY2Ky83aGZFUU9XdDZTN2VpQ0dtdTI5WmljZnJv?= =?utf-8?B?eWxtS2VUU0lkaktnNFpJWENnVGkycjNVOG8ycTJCU3QvNG1nOWJhQ2QrUEZ5?= =?utf-8?B?U096YXFZZkF6Qkt5WTFUM0czR1dzZFlpa0dxajJwU1ZxS3BPMVMrcG1pZjR5?= =?utf-8?B?UnRTODFhLzc3S2FYaDBqNXRsM0plcWdZTEFERzJuR09oN3VzUlJvV2R6MzlR?= =?utf-8?B?bmEzajJIVk43NG9RWG9zS0NGN1dXUXVnV3N6d01sNVRRYnpQcXd2bmI0WnBi?= =?utf-8?B?K1dYejNpYithdUdsTDdkUm5SdHNaUTVndm9jd241R05iODVlZHhhUDJ0L29S?= =?utf-8?B?K25iU1FLUnpSbzRmYmtTcldQT05RcnR4d3ZubGNiSW1qTG13SFl0dDdtZEVN?= =?utf-8?B?MGd3bkwzcWlZRWJFbVVQNkRLNUpzdDJXOTVCWkViWWZiTTJwSm11OTFwdVNQ?= =?utf-8?B?eFBuZVVOd01sNGtKMGlUdHAycC8wYlU3Rk5QYXc0a081cVpTNUlJMCszd2pJ?= =?utf-8?B?cmlRQ0FmS2VhYk10cENkTitHdDBIcEY1d3ZENHh0VlZRUVNjRXRrYXMwZmpi?= =?utf-8?B?M21JZDlzYUZuNTZycWJqM0xWUTJiNUJwdUM0dnhTbCs3d29rMnZxQXBqT00x?= =?utf-8?B?b1gvUkN6UjZFYmFwZ0crdlJRdFhVSmNXSk8wK25RNWV2N28raFluMDRCSVNM?= =?utf-8?B?QUFNRzNzbWkvdi9nSWs5Um4rWFloLzNKZE1ncUJFM0hMc25ZeGRUSXdpRkFh?= =?utf-8?B?QUZWaEgrUldrbC80WlJTNU44ZWpTNmdBbGJGcHllQy9ZT0liaFBYV0h0cWM4?= =?utf-8?B?SThOSVhFU0h0aGQzNlJ4RTRxVHE2eU1xYkQ1N0toejJFZUlQTVhoRUQzaVA4?= =?utf-8?Q?kW6NaHmK2U9iwFj6rqrdQv6zX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 266669a5-bb47-46ba-1aa8-08da69731ca2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 10:40:35.0918 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tia8XdfpHkoTjjkZLOcWh5yXXARmwHpibKcsMtiD+Zzf/wqhesZbzxPziKVh/W3QLkxsPRLK36wufHy8sYCBNA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8855 On 19.07.2022 12:32, Volodymyr Babchuk wrote: > Jan Beulich writes: > >> On 18.07.2022 23:15, Volodymyr Babchuk wrote: >>> Patch b4f211606011 ("vpci/msix: fix PBA accesses") introduced call to >>> iounmap(), but not added corresponding include. >>> >>> Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") >> >> I don't think there's any active issue with the "missing" include: >> That's only a problem once Arm has vPCI code enabled? In which >> case I don't think a Fixes: tag is warranted. > > Fair enough. May I ask committer to drop this tag? I had taken respective note already, in case I end up committing this. But this is the last patch of the series, so I can only guess whether it might be okay to go in ahead of the other three patches. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:48:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:48:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370543.602340 (Exim 4.92) (envelope-from ) id 1oDklk-0002Xl-6g; Tue, 19 Jul 2022 10:48:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370543.602340; Tue, 19 Jul 2022 10:48:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDklk-0002Xe-3o; Tue, 19 Jul 2022 10:48:00 +0000 Received: by outflank-mailman (input) for mailman id 370543; Tue, 19 Jul 2022 10:47:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkli-0002XU-3o for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 10:47:59 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f2fdfe7-0750-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 12:47:56 +0200 (CEST) Received: from zn.tnic (p200300ea97297609329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:7609:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 315601EC04D6; Tue, 19 Jul 2022 12:47:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f2fdfe7-0750-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658227671; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=itxQexl6sj7uyxfVl7DeFw4Cg1ss0IG70VFcnixr/7s=; b=b410x885IhieOidIYERnkO1GPUK8UXT1/Gg40HuooGSEIOMVEqdU50oUWHTW0ynG2CFaSG 0XoVc9VJ8bWoc0/oiJGGsJTwl9ggAbSOWZA2mrAcVVPKGagDAQ9Wu23YoQc3Uk2nEnP61G Yj0BYs0RVoahETfOz+/Ju8GVDm+Chwg= Date: Tue, 19 Jul 2022 12:47:38 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, brchuckz@netscape.net, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "Rafael J. Wysocki" , Pavel Machek Subject: Re: [PATCH 2/3] x86: add wrapper functions for mtrr functions handling also pat Message-ID: References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-3-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715142549.25223-3-jgross@suse.com> Drop stable. On Fri, Jul 15, 2022 at 04:25:48PM +0200, Juergen Gross wrote: > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h > index 5c934b922450..e2140204fb7e 100644 > --- a/arch/x86/include/asm/processor.h > +++ b/arch/x86/include/asm/processor.h > @@ -865,7 +865,14 @@ bool arch_is_platform_page(u64 paddr); > #define arch_is_platform_page arch_is_platform_page > #endif > > +extern bool cache_aps_delayed_init; > + > void cache_disable(void); > void cache_enable(void); > +void cache_bp_init(void); > +void cache_ap_init(void); > +void cache_set_aps_delayed_init(void); > +void cache_aps_init(void); > +void cache_bp_restore(void); > > #endif /* _ASM_X86_PROCESSOR_H */ Use arch/x86/include/asm/cacheinfo.h instead. > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index e43322f8a4ef..0a1bd14f7966 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -1929,7 +1929,7 @@ void identify_secondary_cpu(struct cpuinfo_x86 *c) > #ifdef CONFIG_X86_32 > enable_sep_cpu(); > #endif > - mtrr_ap_init(); > + cache_ap_init(); > validate_apic_and_package_id(c); > x86_spec_ctrl_setup_ap(); > update_srbds_msr(); > @@ -2403,3 +2403,45 @@ void cache_enable(void) __releases(cache_disable_lock) > > raw_spin_unlock(&cache_disable_lock); > } > + > +void __init cache_bp_init(void) > +{ > + if (IS_ENABLED(CONFIG_MTRR)) > + mtrr_bp_init(); > + else > + pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); > +} > + > +void cache_ap_init(void) > +{ > + if (cache_aps_delayed_init) > + return; > + > + mtrr_ap_init(); > +} > + > +bool cache_aps_delayed_init; > + > +void cache_set_aps_delayed_init(void) > +{ > + cache_aps_delayed_init = true; > +} What's the point of a variable and a setter function? You can either make this var __ro_after_init and then use it everywhere or make it static and use a setter and getter. > + > +void cache_aps_init(void) > +{ > + /* > + * Check if someone has requested the delay of AP cache initialization, > + * by doing cache_set_aps_delayed_init(), prior to this point. If not, > + * then we are done. > + */ > + if (!cache_aps_delayed_init) > + return; > + > + mtrr_aps_init(); > + cache_aps_delayed_init = false; > +} > + > +void cache_bp_restore(void) > +{ > + mtrr_bp_restore(); > +} > diff --git a/arch/x86/kernel/cpu/mtrr/mtrr.c b/arch/x86/kernel/cpu/mtrr/mtrr.c > index 2746cac9d8a9..c1593cfae641 100644 > --- a/arch/x86/kernel/cpu/mtrr/mtrr.c > +++ b/arch/x86/kernel/cpu/mtrr/mtrr.c > @@ -69,7 +69,6 @@ unsigned int mtrr_usage_table[MTRR_MAX_VAR_RANGES]; > static DEFINE_MUTEX(mtrr_mutex); > > u64 size_or_mask, size_and_mask; > -static bool mtrr_aps_delayed_init; > > static const struct mtrr_ops *mtrr_ops[X86_VENDOR_NUM] __ro_after_init; > > @@ -176,7 +175,8 @@ static int mtrr_rendezvous_handler(void *info) > if (data->smp_reg != ~0U) { > mtrr_if->set(data->smp_reg, data->smp_base, > data->smp_size, data->smp_type); > - } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) { > + } else if ((use_intel() && cache_aps_delayed_init) || What's the use_intel() for? > + !cpu_online(smp_processor_id())) { > mtrr_if->set_all(); > } > return 0; > @@ -789,7 +789,7 @@ void mtrr_ap_init(void) > if (!mtrr_enabled()) > return; > > - if (!use_intel() || mtrr_aps_delayed_init) > + if (!use_intel()) And here you remove the mtrr_aps_delayed_init check but you have the corresponding check of cache_aps_delayed_init in the caller. Hmm. So it looks like you're pushing some of the logic into the cache_* functions, one level up. But it is really hard to follow what you're doing here. And that mtrr_aps_delayed_init thing is not making it any easier. It gets set during init unconditionally and once APs have been setup, it gets cleared. And, AFAICT, it is used so that the MTRRs are not set when single APs get onlined but it is all done in one fell swoop in mtrr_aps_init() and then that delayed_init var gets cleared. But then I don't understand what the point is of that pushing of cache_aps_delayed_init up into the cache_* functions. /me greps a while longer... Ah, ok, I think I see where this is going. The delayed thing is relevant for PAT too because pat_init() happens also as part of the ->set_all() rendezvous dance. Right, so, this patch needs a *lot* more commit message text. You need to explain why you're doing what you're doing and explain it in detail. Perhaps even split the patch further into one adding the cache_* helpers and another converting to them. And, also, you probably should stick the small fix for the whole deal in front of the patchset so that we have a stable backport - I wouldn't want to backport all that more involved rework to stable. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:51:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370550.602352 (Exim 4.92) (envelope-from ) id 1oDkoh-00045Q-PN; Tue, 19 Jul 2022 10:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370550.602352; Tue, 19 Jul 2022 10:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkoh-00045J-Ld; Tue, 19 Jul 2022 10:51:03 +0000 Received: by outflank-mailman (input) for mailman id 370550; Tue, 19 Jul 2022 10:51:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkog-000459-Fw; Tue, 19 Jul 2022 10:51:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkog-0005qn-CP; Tue, 19 Jul 2022 10:51:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkog-0001IU-0c; Tue, 19 Jul 2022 10:51:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDkog-0002Rw-0A; Tue, 19 Jul 2022 10:51:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=d7IHT+5kct1j5/g74F13X13kwfTtWIQxIyWoHueC+cQ=; b=LADVMT7s6zZbj24nizmita07nB ClyoX6R8DzXIiwqcqhBldtgqXNuCWvgWa3bxJ9eesOBuEKYL1ZaBtGfkwgF+tA5GPuNo/0DSwZBMq SMy/b4OqJCtfy3qyKBTs35E1JLcMEzuiE7wNGfyvtpgue5Jpw+pWPFnN2/8MpwvoPSss=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171678: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-credit1:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee X-Osstest-Versions-That: xen=0af91dc0326cba12795e0b8fa8f665776e2a9e13 From: osstest service owner Date: Tue, 19 Jul 2022 10:51:02 +0000 flight 171678 xen-unstable real [real] flight 171684 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171678/ http://logs.test-lab.xenproject.org/osstest/logs/171684/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-credit1 22 guest-start/debian.repeat fail pass in 171684-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171672 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171672 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171672 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171672 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171672 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171672 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171672 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171672 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171672 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171672 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171672 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171672 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee baseline version: xen 0af91dc0326cba12795e0b8fa8f665776e2a9e13 Last test of basis 171672 2022-07-18 18:38:20 Z 0 days Testing same since 171678 2022-07-19 03:09:55 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Henry Wang Jan Beulich Juergen Gross Wei Chen # arm Xenia Ragiadakou jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 fail test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0af91dc032..0e60f1d9d1 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370557.602363 (Exim 4.92) (envelope-from ) id 1oDkpp-0004eP-3M; Tue, 19 Jul 2022 10:52:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370557.602363; Tue, 19 Jul 2022 10:52:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkpp-0004eI-0O; Tue, 19 Jul 2022 10:52:13 +0000 Received: by outflank-mailman (input) for mailman id 370557; Tue, 19 Jul 2022 10:52:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkpn-0004e6-Ig; Tue, 19 Jul 2022 10:52:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkpn-0005rc-G5; Tue, 19 Jul 2022 10:52:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkpn-0001NQ-6Q; Tue, 19 Jul 2022 10:52:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDkpn-0003OM-5x; Tue, 19 Jul 2022 10:52:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N7kzlCyXzjByYmYxyEaAje+KZ5LuOZ9feDj9DEwDHGI=; b=G2UcbzA9I6qXUKPip2j4ioiFTl ZBrZEjHiMh7J5jcvTQTJvxq6K16hHVb/vq7xEWuU35QuZGXxxFdjP2M44crJ6aWk0+dZsng8c+kdh GZTFVbiV4Wr4Fgd9WuFQCbBU/FY5zQ2TihsDgcrMxILcikpkrmo3BvPNfNpZoALR3OT4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171680: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=9e8601c46482664a543e35545a921c96ad9adbc6 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 19 Jul 2022 10:52:11 +0000 flight 171680 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171680/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 9e8601c46482664a543e35545a921c96ad9adbc6 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 739 days Failing since 151818 2020-07-11 04:18:52 Z 738 days 720 attempts Testing same since 171680 2022-07-19 04:20:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116239 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 19 10:59:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 10:59:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370580.602414 (Exim 4.92) (envelope-from ) id 1oDkxC-00065U-Gs; Tue, 19 Jul 2022 10:59:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370580.602414; Tue, 19 Jul 2022 10:59:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkxC-00065N-Dd; Tue, 19 Jul 2022 10:59:50 +0000 Received: by outflank-mailman (input) for mailman id 370580; Tue, 19 Jul 2022 10:59:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDkxB-00065G-8X for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 10:59:49 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2058.outbound.protection.outlook.com [40.107.21.58]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e772f049-0751-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 12:59:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6893.eurprd04.prod.outlook.com (2603:10a6:803:133::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 10:59:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 10:59:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e772f049-0751-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TKvWosZVXhDZPrnF0Obpd3r3hGz0dT98O5cJs9Qa4RB9gQePXWTcuzUlL8q9A0xY02TVgN4vUhNhfRB2WldCy3bBFdQha861yBYjayaFCSCExYtFaOZh+YoVQLVOVNNyfE0aEzJmQqoNu5a6weyxLUaJbzAAOARyc1HezmwPBHm2crlOfLNDQ3uTRnEdRUwXLqOkawkxg2xqEO7P6Ky/3LE5qqqfUI4EsyqTamw2fFbHcQTM22D82auOKNtEKiryijpn/GCe589TkF6Kj8/ylocaz7iqPMl8449WkA6QAjaRoy57B0yb7i9R9JShZKrYpU6GIy0UeEObFAJK07G4aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8DjIkfJbELGULg0dWJW8CLfI71F+vgNdui0vFWfUSN8=; b=gFjRx8ha52UMi6U8GWIVyvy7rhn63bwda0L/8Vnj65w7PHWkxJol9ecqbCkreSp/LdlydOBj/je609PXoRl2/o15C6K2Jzl17mOUAcgFttTnsgzojUo/5T4eUmVXQlD88QgKqaa5obYE0kYEyusRp8F8Rirep9c3hm9bLx4hjI4mrELl7FYtn8m6DxtNZs1jlxv3bTxuHnODZ72hE+paO2tVNwvQhN/4LnwEUVm2kfld8d7frvHBY10Z8auzj8rgLj+XnkWIVeKdSh/0RDw0vJsRRRUsXJXtOYTrpoRiIFJAqRzOMJF0222R/lpJanDNe2FoFnqlzmMoVnCd7DO2KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8DjIkfJbELGULg0dWJW8CLfI71F+vgNdui0vFWfUSN8=; b=4YSzfBR4m4MxiHyaBFly8Yiv8drf1+HLHE6ycnTg2UUyu4+s5NKJaZJPBu1MTUQO37ZJRk2ItsNaIH/ZzG7Qle+13uJ3fbwayuBQmSs4ZGX+ijiQt+OlQfnenoR38+O8Doa6q/HBsdgFKUQqY8+9Cs8avGGx4QtJ7r7v6GJ/P0N/SgrB3dcpAzQTFkUJdjDQIVDIHw8rgbHY+jYQ+cpP6kUeVWu8YcmAUt9h9fIzsRS6Yo+SBWXMmJcGy3dvNXCgnN0nImoFThweosifXWBlrrQU8AJXeV3KWxTcLWAYU2jCWkB8YkQYkuZvNlSrwEQmAaUksmUg+2xSvX9TmAp8OQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3a8d4fe8-de96-06cd-adc7-073bf746d5e2@suse.com> Date: Tue, 19 Jul 2022 12:59:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: =?UTF-8?Q?Fwd=3a_Ping=c2=b2=3a_=5bPATCH=5d_x86=3a_enable_interrupts?= =?UTF-8?Q?_around_dump=5fexecstate=28=29?= Content-Language: en-US References: <3a5a1efc-e610-e151-fa58-25cfd9177f26@suse.com> To: Henry Wang Cc: "xen-devel@lists.xenproject.org" From: Jan Beulich In-Reply-To: <3a5a1efc-e610-e151-fa58-25cfd9177f26@suse.com> X-Forwarded-Message-Id: <3a5a1efc-e610-e151-fa58-25cfd9177f26@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR07CA0045.eurprd07.prod.outlook.com (2603:10a6:20b:46b::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4e6d2c1-a51a-4a0b-b3b1-08da6975cab6 X-MS-TrafficTypeDiagnostic: VI1PR04MB6893:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /87Tu8PlIO2ae2UHO5StVuKTfNL3N3m6+96KVUjXfklYtgNyzv4LMmbK8/Wa46K2sM7SDiSbuybBbE4Ra3vakgOTwl4jOg+pB5hBPAexFnUeSGE2A8Fizs+DPVQJNCzXp1rIlfsWGgL1HspKT7W/eCUdoRysiyhWGWDKqJEkFKUfhz01ups1pG3qLgWDlLDCKWejLvOLL0+Gt1N2UBP6ToLuY1+LniLMWvGv5YSvptu13HF3dUT+tPh6PBvn+GWuYArRuwb0Lt8wxXfusYVmrLLeq2C/yEXbkkbrGqJYczF9Xq1gjcArizMIVUoj72hyCamlfKs4HcfZA+xjTw6H5fL1bf51TlFwZFWoF5rKgLU95wZGGMxumTP3dnke8oq6nYXgrDllZlgvomxO+LqmJSLxAWK6nX+PIRjdtX1ZEBb+aSHMNh7JnUcQiUBUj74bsPuwoZ0PrmLre9ats+B3zTY/3ie4xifX+uDCQVdhGjh6vmb3ga2y3eCXwhACjZp+NqWD6bVZWvFbBjuhSeNc/XYhF2+BAtdBvlXXP0ASFwxmTmAJat+xhAb3ThI8aKQ/iWSBML/Bvk+uGzta9g6yZhK6DYzkuaodISRQ62m/sjYz5Tr6z35PZgLMxvHCaeGwykdxZ3lMU++06AY+jpgTm1yLlsKD1iIKWKNNB451r4UPafevRMMYRNZ8MGnvkB8g/kOMITN0FR1v6PzrvkV/9dFmImxPR4V5GhJUz/hM62oGuOO8OIELdxveyDTQBkVqS1PHTK3+sj+uvfhh7GnBYCLgVX3y7VpLpcDEY52l3swjnp3VDBA210a6tP/z9+/ad0buKJPws3C9aXcmb/KSeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(366004)(346002)(396003)(376002)(8936002)(66946007)(5660300002)(66476007)(66556008)(26005)(38100700002)(4326008)(2906002)(186003)(36756003)(316002)(6916009)(6486002)(478600001)(41300700001)(6506007)(31686004)(86362001)(53546011)(2616005)(83380400001)(6512007)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjFCaUF5WnRMZHhhajNvakNYMUQ2R2NHSlZqWUoxZkhMdUpJbFhvT1UraHFS?= =?utf-8?B?Mkx0ejNtTm1yTzUrOUhCcDNTdWs3R1pWbDd0d3VPa2NMT0FxYXNoYldBQmxD?= =?utf-8?B?a3UyNEZHNW5CbnlUZndWMHFpNjJFbGlyZnJSY2VtT1FueHVxQUV2bWM0NXRR?= =?utf-8?B?SWNmczBzY24zQWV1dG55RE0wMlVkT00yMjFWYStDOXNmdWFaZ0tmRnVrWUNC?= =?utf-8?B?RnpwQmR5Si8xWUswMHFhRUJmSXBzeGFOeGxJd1phcEh0Ujl1QlFIcnV2eFVN?= =?utf-8?B?WWk5d1lEYUhrKzlZK3Z5K1NyaVVqR09QRk5PempFZmE5WXRFajVvRVE1dk56?= =?utf-8?B?cm1FWndKckhxNHVxY1JsQytxaGN0WGtIY29VamdqTnFId0tXSVZIalY5T2Ns?= =?utf-8?B?WjlQendoMEZ6ZDMyemZqakZjbisxWWJIOTZPQVRYUm1lZGpiZzVvK2FkZXQv?= =?utf-8?B?UEFsdVAvc1BKUS9maTk4Znhta0F5cUlxNWdCbVpCdGt3M0xuT05KMXZLUmxM?= =?utf-8?B?M0VQbHNzQTd1TnBmNWs1Q0gxNk53RDlRenNiMjBvUmMvNzN3ZEpIVHN2T051?= =?utf-8?B?UG9kYWdKdDZTYXF5Z2EwYTZrMDd2VlFSOEl5TzRhWHB3SmI4UE5tUThXM0xz?= =?utf-8?B?SmptazNYODVHa2ZBenJXa2gxZVl6bUNXYVpBUHZvdHBFbWswTkhOQWZrdFJk?= =?utf-8?B?MHg2ZFltUkswR3RwZG1yZU16SkFXdVk0N1hLVFNNT2svSDF1UjNQNWlZM2o5?= =?utf-8?B?cTVIUDd4VW5HZVZTYVRCV3JlUHdhSUtuUEltUkdQNmdIME5HZ0x1QmR6bEFi?= =?utf-8?B?ZW85cXVCUDUzV21oU1BWNXUzRUVOSDJNUk9QMVZZS3dCS0RIRGVnQlBuMXRl?= =?utf-8?B?YjR4UFFXUzVGQ2xZTVVJM0ZjSU5Oclg4bStqbitxMVd1V2JqVVRXb2RqSTVx?= =?utf-8?B?RVNtM2p6MnYrMFFySEkyUlVqWDJ2S3dFdVpvbHVLYU01WGkyd0k1eml1a2s4?= =?utf-8?B?b2FhVVE5a2tLeHZ4WkNRWjdqWmNzbmtxOVFNdzlHdmMzc0J1T1E0ZTdUNU1S?= =?utf-8?B?d0d3c1VMTG82OGR4YWFqZGQyT1VuTVZhcjMrcXptTHNlS1pUUnpjRkN1ZzFq?= =?utf-8?B?TjQ3WnBlN2tjYlRxNmw5MFAxRXlhb3RnTWI5M2JEbzhXY3U4ZmRuTjZYMFRp?= =?utf-8?B?R3NoeFQwR25CSW5uem13blZrb2xIUUxzZHVTUWJtL3kvWmJrbW9pYm1HdmdR?= =?utf-8?B?Zk51elVpbkFIdUZEVHQ3NUYvV2FWZ3RoeEwxci9LUHhpd2FCa0txU2svMFg0?= =?utf-8?B?eWZFWm95WWNIbDd4MmM5TFhpd1djZ2JreS9EajN4Uy9BZ2tlNHgzWHE1WDJh?= =?utf-8?B?dDh6bWpFWmQwVVQ0NGo4ZHNra2RJS3RpWDN3N2tROURlNkpXdG4rM3Evekd5?= =?utf-8?B?K2Z0dXcvRjhjMktZK3ROZnlyMHJJalk0QitWSjBGN0xHN1JPcXhldVlHbmxm?= =?utf-8?B?c0JuYlJocENidVVVSjQwYi80ZHdXRlB6UEozaUEvckhoYlpsd3JBVXh5Ky8v?= =?utf-8?B?Q29rQjRYNkFPeTEwNThDS3dvMmpLaXFiUmkvbno3SWVsa2VzSjNCMWxWaGdF?= =?utf-8?B?UFVaQmh2ckFVZWdUWFVOVzBRc3JHUkNGZEh3SG43KzlFMjNEY1IycVM4Yklz?= =?utf-8?B?bkxNWS9kWVgwY2FkalFRTWdmNG1CUWtlWktVS2VCTjJ1b0ZhVDRjcmVmMDV5?= =?utf-8?B?VzVUNUtCVmw5K0hQWE1tMGtWL3ppa1c1VGFSU1FmN2ZpQmdYYnRyK1N2Z25N?= =?utf-8?B?NlVQV2p3cW45Y0phNlVEdjlDSDFTbjFSVTZjeGtwLzhKR3QvanNmbVVVYWZK?= =?utf-8?B?c2kyS2JtYThmTzN3OTJlcU1aNUNJbFpjbUdzUWZmRHYxUzd5ZVZRZ1BpSXE5?= =?utf-8?B?MG1aNlBiWUNKRERkRjVHdkRadWFSZzRUM3NTREFtek5wSzgreWtXanhrN0d1?= =?utf-8?B?d0ZFVCttT3FkMkpvTlRBT015d0R1SXlvYUNkNVU2YVQ1b2VmbnpaNDNpWUZH?= =?utf-8?B?UlUyVmNieXpvcmx5Nk9yYkhBaUZLN0x1U2VvcFh3THZRVDFNS3lvdy9FZEtj?= =?utf-8?Q?eCoh1UQdZq5/NSMaAFwn0cSzk?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4e6d2c1-a51a-4a0b-b3b1-08da6975cab6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 10:59:46.1126 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0R3+h7b+uXBh5MOUCxpeP4E8OGRuc6/ii/VlxMEeQRAHWw6MAgfxsM+7GO2zPPT9CqlQ+fGA1jeo/Qusmx9o+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6893 Henry, -------- Forwarded Message -------- Subject: Ping²: [PATCH] x86: enable interrupts around dump_execstate() Date: Tue, 5 Jul 2022 18:19:38 +0200 From: Jan Beulich To: Andrew Cooper , Roger Pau Monné CC: Wei Liu , xen-devel@lists.xenproject.org >On 11.01.2022 11:08, Jan Beulich wrote: >> On 16.12.2021 14:33, Jan Beulich wrote: >>> On 16.12.2021 12:54, Andrew Cooper wrote: >>>> On 13/12/2021 15:12, Jan Beulich wrote: >>>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>>>> the consistency check in check_lock() for the p2m lock. To do so in >>>>> spurious_interrupt() requires adding reentrancy protection / handling >>>>> there. >>>>> >>>>> Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_state()") >>>>> Signed-off-by: Jan Beulich >> >> There's a bug here which we need to deal with one way or another. >> May I please ask for a response to the issues pointed out with >> what you said in your earlier reply? > >I sincerely hope we won't ship another major version with this >issue unfixed. The only option beyond applying this patch that I'm >aware of is to revert the commit pointed at by Fixes:, which imo >would be a shame (moving us further away from proper PVH support, >including Dom0). perhaps another item for the list of things needing resolution for the release. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 11:22:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 11:22:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370592.602425 (Exim 4.92) (envelope-from ) id 1oDlJA-0001Ic-9p; Tue, 19 Jul 2022 11:22:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370592.602425; Tue, 19 Jul 2022 11:22:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDlJA-0001IV-74; Tue, 19 Jul 2022 11:22:32 +0000 Received: by outflank-mailman (input) for mailman id 370592; Tue, 19 Jul 2022 11:22:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDlJ8-0001IP-Ue for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 11:22:31 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 12718a98-0755-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 13:22:29 +0200 (CEST) Received: from mail-dm6nam04lp2044.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.44]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 07:22:20 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB5955.namprd03.prod.outlook.com (2603:10b6:610:e2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Tue, 19 Jul 2022 11:22:18 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 11:22:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12718a98-0755-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658229749; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=jpE5EaLymmS3gJJbX75WqtTv82C9G5itlG5AWkllfU8=; b=XH5lJ8mpMVGeQgnmYH6KnmPLbwBs/AvYADLHDNIrxkiTfajII7oGBC9q MEWZItijdx+Tlub40tvcphzR61hM5tDIm2AsN7VNenK3exSv8ArvMMPCU 0XoY78hzgJMjT59GUnAEKxavDxyO58/sNo1sl1p/Uqgz7qqcqH+50hT2u I=; X-IronPort-RemoteIP: 104.47.73.44 X-IronPort-MID: 78688593 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:lDH27ql6kBjYob9RoDzH9GDo5gyvJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJMWDuCP62IZ2L3e4t1Po20oxwAvZSHyNFlTABuqiAyHyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3462j4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kNJdE2w+hlAVtL+ KYKBh5WZT7SusS5lefTpulE3qzPLeHNFaZH5jRM6G+cCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWID7g7JzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLaoiz81rKexksXXqobDYKl0OFKx2eh4WsdGhRGWGD45uWm3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JZFuZrtimW0KHapQCUGgAsUTppeNEg8sgsSlQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJTbp+PHmqYA3yx7KENBqFfbpisWvQW2sh TeXsCI5mrMfy9YR0Lm29kzGhDTqoYXVSgky5UPcWWfNAh5FWbNJrreAsTDzhcus5q7DJrVdl BDoQ/Sj0d0= IronPort-HdrOrdr: A9a23:s9LCHaNJ31eW6cBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.92,283,1650945600"; d="scan'208";a="78688593" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W9N3K9TaklxVcgXaab/UvgJIQybb/tiqs0wH5RU6MxbaDzQ7dKHYxJx+e6UAEIUAV9MjFzFYOJwdRUaDBUbuJNMCFIlYzd25Ek/H+TyhyQx/ZcK8at/Ga3TtVWSLmdn0K+TZB5BzKmSM0G+d4tXoz6jzDhrKqfGRjiZdd1HlhQGzqvAmS9fxhO19D636lLC695t0+kJbBIESYvdPeGREPpLoKC4wbxtxICGaKnWAeMm6weZcXthoYJiRLc1OvGTApddD/RyYPKuWhol3+LoY848gmyyZ7kc4Sn591FizLqic5kEANcpQMZy2hgHJInRR9oSb0/YDT8smLEtLH+obSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jpE5EaLymmS3gJJbX75WqtTv82C9G5itlG5AWkllfU8=; b=UmsFF2zeXlyXuUNnsO+hP0dJEjkn30bnph0U8om+pR6JwcMI1EZmGEXb8SaBar2N8l2hNOabK/R8PJnzTCnSunl2viJNIwQJrcr1aioXU8fUkpCqjzeLFiaDbjetA49YYswxZxp8FCDSKaLZscAKPJ3/xahjohJdqEQ87XJa0YT8CV/+UECqon8ptN+N1cYvIIzCKuKmmvwq5pPcc7tctUtPWuXF+vsBQ1Ps22Uaf/oiuUbw9K2+bgQi58evU40IabVuAWl8RTglA4jbjbV1eGdW8epIgIU0rkVc3NQfZbmGRVF3Kh32Fdm3IcwHsmY3KMDXfcL7Avkc0K9obI/NvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jpE5EaLymmS3gJJbX75WqtTv82C9G5itlG5AWkllfU8=; b=fGFPiGNvGlyPi8k5OxHJ+lWiI0l2cugJedljEhgHTfo3edS/iIAFNCcqGfZJLLAg1pCATDHI7OFAv+O92zL5cKWtngEbhLjC/5hh4qh6Vio/iaJP+WGE9EMNtuUDU0PBb3Gvx4t+opHFpdVR3JqSa/HeIKezY7cgYQr8gpn+70U= From: Andrew Cooper To: Jan Beulich , Andrew Cooper CC: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Thread-Topic: [PATCH] x86: enable interrupts around dump_execstate() Thread-Index: AQHX8DQPNo4qXehMEESfj1fdbKCDRqw1BvMAgAAbnwCBUcCggA== Date: Tue, 19 Jul 2022 11:22:18 +0000 Message-ID: <70cefb48-ab0f-7a84-ed31-fa44c3135fff@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a6904c9e-8494-4d44-f1dc-08da6978f0c1 x-ms-traffictypediagnostic: CH0PR03MB5955:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: siF6V88ELVoIWVwsIyIclSlAoV4ROB4Y4Vm/2OcYgNQ6aqNmwIMjIRqUdde7t+1+VxTzMCPS6CvJfnvnvYocJGgbaUE1sMJMw1oqa98L1ioyALRsq/93FEj/uZUW6PHPkRuzp/9cTIpdsFjhQZaxD3esOV1ru7Fn96oUP0hyoKZNpMK90tY8Pxn0eHCuvM9Ooj3Sa5Q26+JJnSsLVE4ie2nRgJw3fAiTIf86YNuxyjIIRZ9MRKiNXJlP/O7x5rsZeCrN2mU7sWpFvISnJcYEYeLDBoQaInS/NaBIVet1lbF6u5fDveISt7PmAyNMf9lUDKiAhIeE5+djiXr6ThrdpZ+udBHiYoQeS9F4q2EeD5mg/CbF+z6Lj54L6UQbqSxdJMYjrCVgQME2Yu5tkPM+HcbnYCQFQVExtbOEiZhmf9i4S9/GfNa1erJh7whTmUD1cY8L/nteFqSoKITUK3+EW0iKzIQGAWDRooQn7cX24bTZ30XxuYltqC8BF8hN4i6B8KDyutGgTTBa3MMQkDYiT3T0GDMPdJ3yB+aS/1SRJA76WuImISGo4wh/2B3wNOJ8aS+Wp3At92TBCy3IOCWDMlr5ogh3tayZGBqIz3xO4lkyZJwzOrDQ4Yf3anz155Z76q2yZgVMX4ss2hB8geoky+c979GfK6bcyzIJvYm/lX6vbT1HxzpgIlE0rrowXfiMmnpXn/rwSVCToKQ8+2fiwiAMsG6376XbO8TRiXZEEj1AR28LrnNsSxg94wjEo5788PscrmS9cHLpLEKGrRQqa5goi1w/CgJGky7hnxeXZv2wv9OhGGc3No7n73FWS+QRSZwStBV49qZZ0uuyCaLSBuSruLilIshYLNnSLGSbpBuq3vuLuayQV48PekBCzMXi x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(39860400002)(136003)(376002)(346002)(8936002)(5660300002)(76116006)(66556008)(66476007)(4326008)(8676002)(66946007)(38100700002)(36756003)(31696002)(122000001)(64756008)(2906002)(53546011)(66446008)(2616005)(41300700001)(86362001)(38070700005)(82960400001)(6486002)(71200400001)(478600001)(54906003)(110136005)(83380400001)(91956017)(316002)(31686004)(26005)(6512007)(6506007)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?UXY2ZSsxR3cyR0pLclBiemI4d1l5QnFlZEdQdEo4Ri85QmRldENqZW5uWXBD?= =?utf-8?B?VWQwRUpwV2tJdDhHN3EwbS9uL2lUVzFXM2xvQnFENWpDcGpRNkZ5WDdRQ0xl?= =?utf-8?B?ZHdlV2t4Tm11RzRNbjgzM3ptQ21kUmViSnZ2dXhuT21JTlZCSHNVRlMvZzVt?= =?utf-8?B?dlBkYmt6VkVkZnBVRXNlTllRNkpDUFI0Z0hBY056QTBEQWpjYXQwZVlOYmxp?= =?utf-8?B?U1RIK1p5Nms4ckdDeU8xUllhZ0NUbjEzSWxKbDRPbnBpRmlrOEM3dE50Nmdy?= =?utf-8?B?M0VBeWpXbzZGTmI5Z0J3RnFGM3VoeGZFOXVQTHJxdTVHcUhReXRiOXY3VEJp?= =?utf-8?B?RnhtNmV5QjcycjV0ek10K29NaWU2Q0srWkt4bEJxNEtydDM2Q0NwemE2Qzhk?= =?utf-8?B?NmNFczZ2bjR5cndYUWc1bURhbFNYcVlBVzl4TVZnVGh4YnRkdHMxbS9CMlZi?= =?utf-8?B?cXdPd2hUQU9UczlwQjRxR2U4VmZWNXJCUlJwRmx0WVMyTVpRR0NCLzloa1c5?= =?utf-8?B?dDNmOTFJNFZoN21ES2trV0hLMmk4czBXTnRqbExCV1hTdFhCaTZRR3p1REg5?= =?utf-8?B?aFZVZmZqWmdnVHlhOU4yZng2bXJ2bUpEM0xQb3FFNnNKTFdiT2ZRNDF2Vnpm?= =?utf-8?B?M3pvdkgyNDYxbkdVWE10WW1Ka1lrRWRDTzFlaVBabVBqSXdMVk9VcytqRVJZ?= =?utf-8?B?Qno1RTVySTk0dDRLTFJwekZ4VFJTQmwwVXhFUVYzMXdTZXc3YnF5TmxmQnVJ?= =?utf-8?B?N3c3YTVsQmpnZ3NQRDRqbnc4THBWSDZ6TUFOWGtsaU1zTUdnVmt0MFBNZkNp?= =?utf-8?B?Rlh4T1U3R1h4NTQ2UFk1N2hyc0MyTGlhNndsYUZDTHR3NVdqS0c2dDBQWlpF?= =?utf-8?B?MzZTcG1PWDFjVHFxVHpmbGFEc3dnSXNmMkU3M2RXL1pYS0JrSkZPMVJheGg1?= =?utf-8?B?L1ZScStUYld6WVU1T0FrcVo2TGNDR1JJTFV2NXR3dnlJaklZaHVqa3ArVTZL?= =?utf-8?B?UTRNN3BhR0RMT3lheWhlVHY2MHFhY2NnU292VHVxN3VFQ1JHbzIrb280eDZt?= =?utf-8?B?RmdsZ3Nzb3NVWFliVzRmYVFjcVN0R2ZHQzlNRGlBZ2lPWFEvQnFLMkQrUVZa?= =?utf-8?B?TEs2bEJuL0FMaHhISHh6VVcvVXlXVnhjbGxCUFZkOHAvcXhITm4zSmowMlRs?= =?utf-8?B?UzJHK1d3VkFwcTEralJ2UWd0ZWNTVnpRVTJOOHQ1NDQ4R2tCeEYwczdvbjRp?= =?utf-8?B?RXd4dVIyMGlFdyt0NVJMZDErT2hrUmdTeVFwWHJPd0NpWDZqRFFabHdTVExv?= =?utf-8?B?ZzNzNm10aXdYTkZjNG90UGsxSDB3ZnZVVkc4eDc2KzlkV1A5M2l4K1prdlJm?= =?utf-8?B?NFZmdUtuT2V6cFh2SFhWeE5kRk9vM2RCTWdKa29RVXZ0dTdXNjgyNGlkNG9z?= =?utf-8?B?TWlEVys5bmtHZHVlN1pHcytkQytmdTd3NnZMQnkzTE5xR0NOenBBSmdGcy9u?= =?utf-8?B?a3lZMEdXdElJY0dYbklOaTdkM3hCMVNBV2ZLZWpGOFFyY044SXNWR3JhT1oz?= =?utf-8?B?TWNuU2h6S3dlNmxtd2hKTjB0M045SDRTc0dpcmNaalFwNEhVQnEzQ3ppdFlh?= =?utf-8?B?NlNOTmR0RmMzNW9jU3QvNkYzaGtGUFR0WnhId1JvZ1NEbThVUDNISDFZVVlK?= =?utf-8?B?RXdBeXpKNFJOZFI2VzZUOHkwSTd5Vks3KzBpT2dKMkxrSXJSelF1UGllOG04?= =?utf-8?B?cWo2Ylhreno3cVoxVU5kYWVHdEswVlY2NXFISjNNU2hnaW1vdXMxalJNblJI?= =?utf-8?B?bnRvcDZGaGlVV3IzSFh6WE1RNkxPTXBZN1ljZVcxTmtOdEt4ZHR1QXZncERR?= =?utf-8?B?S3dKTllFWm9pVk5pS01HdmlCT1Z1Ny83ZHZ0UWlkZGxaK3JxWEhaVUhPSWhk?= =?utf-8?B?cGsxajhvWXQrTlRoWDZGd092U29mQ1UwdW5YakFyWk1LVGZHN3pzN2ZxbEpV?= =?utf-8?B?THpnLzNjUVhCL1hOa1hIYmhtbkpWRzFwTnFxSTA2MlFUUERNVVFqM0U1RlBx?= =?utf-8?B?Y2w4V21DcXVBbXpmNC9aYTQ2QkQ5SldPaG5aQzE3MEc1L3FrcWZHS2pJTmNX?= =?utf-8?B?L2JCUFpjNVU2Ym5Td3AwWlNHKzF4VU82aDFPaUhIL1lNdW0wYXpRVTJIWU9M?= =?utf-8?B?aXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <5BED913E203A4A488B072B2F19AD1289@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6904c9e-8494-4d44-f1dc-08da6978f0c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 11:22:18.2268 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QyXFdUHORR4VoBzcnicYawTNZGIII8He5FmuC4IBBey7scwvsgMuTLc6QrRGrrsV4Hl179Ziw0gKNPB/o5UYEMQAB/0P6jbRuYgiMVnSp7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB5955 T24gMTYvMTIvMjAyMSAxMzozMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDE2LjEyLjIwMjEg MTI6NTQsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxMy8xMi8yMDIxIDE1OjEyLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBzaG93X2h2bV9zdGFjaygpIHJlcXVpcmVzIGludGVycnVwdHMg dG8gYmUgZW5hYmxlZCB0byBhdm9pZHMgdHJpZ2dlcmluZw0KPj4+IHRoZSBjb25zaXN0ZW5jeSBj aGVjayBpbiBjaGVja19sb2NrKCkgZm9yIHRoZSBwMm0gbG9jay4gVG8gZG8gc28gaW4NCj4+PiBz cHVyaW91c19pbnRlcnJ1cHQoKSByZXF1aXJlcyBhZGRpbmcgcmVlbnRyYW5jeSBwcm90ZWN0aW9u IC8gaGFuZGxpbmcNCj4+PiB0aGVyZS4NCj4+Pg0KPj4+IEZpeGVzOiBhZGI3MTVkYjY5OGIgKCJ4 ODYvSFZNOiBhbHNvIGR1bXAgc3RhY2tzIGZyb20gc2hvd19leGVjdXRpb25fc3RhdGUoKSIpDQo+ Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPj4+IC0t LQ0KPj4+IFRoZSBvYnZpb3VzIChidXQgaW1vIHVuZGVzaXJhYmxlKSBhbHRlcm5hdGl2ZSBpcyB0 byBzdXBwcmVzcyB0aGUgY2FsbCB0bw0KPj4+IHNob3dfaHZtX3N0YWNrKCkgd2hlbiBpbnRlcnJ1 cHRzIGFyZSBkaXNhYmxlZC4NCj4+IHNob3dfZXhlY3V0aW9uX3N0YXRlKCkgbmVlZCB0byB3b3Jr IGluIGFueSBjb250ZXh0IGluY2x1ZGluZyB0aGUgI0RGDQo+PiBoYW5kbGVyLA0KPiBXaHk/IFRo ZXJlJ3Mgbm8gc2hvd19leGVjdXRpb25fc3RhdGUoKSBvbiB0aGF0IHBhdGguDQoNClllcyB0aGVy ZSBpcyAtIGl0J3MgcmVhY2hhYmxlIGZyb20gYW55IEJVRygpLg0KDQpJdCdzIGFsc28gcmVhY2hh YmxlIG9uIHRoZSBOTUkgcGF0aCB2aWEgZmF0YWxfdHJhcCgpLg0KDQpUYWxraW5nIG9mLCBkaWRu J3QgeW91IHNheSB5b3UnZCBmb3VuZCBhbiB1bmV4cGxhaW5lZCBkZWFkbG9jayB3aXRoIE5NSQ0K aGFuZGxpbmcuLi4gPw0KDQo+DQo+PiBhbmQNCj4+DQo+PiDCoMKgwqAgLyoNCj4+IMKgwqDCoMKg ICogU3RvcCBpbnRlcmxlYXZpbmcgcHJldmVudGlvbjogVGhlIG5lY2Vzc2FyeSBQMk0gbG9va3Vw cw0KPj4gwqDCoMKgwqAgKiBpbnZvbHZlIGxvY2tpbmcsIHdoaWNoIGhhcyB0byBvY2N1ciB3aXRo IElSUXMgZW5hYmxlZC4NCj4+IMKgwqDCoMKgICovDQo+PiDCoMKgwqAgY29uc29sZV91bmxvY2tf cmVjdXJzaXZlX2lycXJlc3RvcmUoZmxhZ3MpOw0KPj4gwqDCoCDCoA0KPj4gwqDCoMKgIHNob3df aHZtX3N0YWNrKGN1cnIsIHJlZ3MpOw0KPj4NCj4+IGlzIGxvb2tpbmcgZGlzdGluY3RseSBkb2Rn eS4uLg0KPiBXZWxsLCB5ZXMsIGl0IGRvZXMuDQoNCkJlY2F1c2UgaXQgaXMuDQoNCllvdSBjYW5u b3QgZW5hYmxlIGludGVycnVwdHMgaGVyZSwgYmVjYXVzZSB5b3UgaGF2ZSBubyBjbHVlIGlmIGl0 IHNhZmUNCnRvIGRvIHNvLg0KDQpXaGF0IHlvdSBhcmUgZG9pbmcgaXMgY3JlYXRpbmcgeWV0IGFu b3RoZXIgaW5zdGFuY2Ugb2YgdGhlIGJyb2tlbg0KcGF0dGVybiB3ZSBhbHJlYWR5IGhhdmUgd2l0 aCBzaHV0ZG93biB0cnlpbmcgdG8gbW92ZSBpdHNlbGYgdG8gQ1BVMCwNCnRoYXQgb2NjYXNpb25h bGx5IGV4cGxvZGVzIGluIHRoZSBtaWRkbGUgb2YgYSBjb250ZXh0IHN3aXRjaC4NCg0KRnVydGhl cm1vcmUgc2hvd19leGVjdXRpb25fc3RhdGUoKSBpdCBpcyBhbHJlYWR5IGJyb2tlbiBmb3IgYW55 IHBhdGgNCndoZXJlIGludGVycnVwdHMgYXJlIGFscmVhZHkgZGlzYWJsZWQsIGluY2x1ZGluZyBi dXQgbm90IGxpbWl0ZWQgdG8gdGhlDQpvbmUgeW91J3ZlIGZvdW5kIGhlcmUuDQoNCmFkYjcxNWRi Njk4YmM4ZWMzYjg4YzI0ZWI4OGIyMWU5ZGE1YjZjMDcgaXMgYnJva2VuIGFuZCBuZWVkcyByZXZl cnRpbmcuDQoNCk5vIGFtb3VudCBvZiBwbGF5aW5nIGdhbWVzIHdpdGggaXJxcyBoZXJlIGlzIGdv aW5nIHRvIGltcHJvdmUgdGhpbmdzLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 19 12:53:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 12:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370608.602435 (Exim 4.92) (envelope-from ) id 1oDmjF-0003So-7J; Tue, 19 Jul 2022 12:53:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370608.602435; Tue, 19 Jul 2022 12:53:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmjF-0003Sh-4R; Tue, 19 Jul 2022 12:53:33 +0000 Received: by outflank-mailman (input) for mailman id 370608; Tue, 19 Jul 2022 12:53:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmjD-0003Sb-Nm for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 12:53:31 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10057.outbound.protection.outlook.com [40.107.1.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca07b14a-0761-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 14:53:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2616.eurprd04.prod.outlook.com (2603:10a6:4:31::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 12:53:28 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 12:53:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca07b14a-0761-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P15dvh59jvluHQxRDI3rjkgvf0EiZ41nIVOPkOcHLkvKpaDhFT1Ue0bLdr9hU+VU5l1PJs39N4NnM9GFkABtmLVj6FKaCh6KchXZue7vWKCe+ZYbLgua4UY4YobXy4JoZQSC61BW5gxUFqd31YZHArbpgVjNz9d3sK4SBQ2RnfwH1i2gEceKSwVR6wPaJ7YiFDC2PlqusVF3416Q+pJkJa7wjdTRDqL2uLXlflg4osjy7K9WDcRUkUoaLBzpjRXJUEv0OsMRubAn1+KVTsvjOGvuNFOl4nykjMlPVnjk+RtilJmgOmWSCcrg7GmqUGyM/lCubJraZ9RWD09SDMDSww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3OuOtTzcMNnCpavIiNSvQ3Ib7RtgMz/yJh8JQCqFvuE=; b=og1P3PtPfs5eTKyKXPAer047NI1QHix/RiB6n5cnhmdEiEH4ejI+4Qv2wEdtIn9PmdL8CtxpmUNsabg4HTrgpyCsAGRNOHkSht9NIOCTyQOqZbSCip4+tb6z4PoPEj/nNgiMHxe5Civ+AnU6o80Be+5gIpnRtRaIJezWQw+EpXz4aeQnnOr4y/I4aA4JLzIWl0jK+XDzAgYFIsLlp8isCretj8tto4y4irTnDrgmjKWIVwhTdhiBRrE/yJpMHhKR6E2C43sVKWOEYo4ivQmRfDSq9fXSxrr26bhK/ofAmJ7lSPi9m3oLph4wBmI1xyTlk5Fr1uBlMW9g59ANiKlZhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3OuOtTzcMNnCpavIiNSvQ3Ib7RtgMz/yJh8JQCqFvuE=; b=a/QsM2zxGr5XG0kIcRJXu7ajXrDq9+Ho6nKbQy2RlMP2h4Aw3sIeBJgof1sxvWgp6TSRxo/odZRLBn0oV/ptpq7z+436I0DTy95R7712p7xQsYqapLz+f2mVg29I5nX2VNEGNMoRVGm/4x4AzJ4/c7cQzbdD116EbNE68t2rjn++CMgpeCjJf4FHM8KVOMCv7l8kRlKsH2/cLo83q17jMHODVTlTdPFQl+NxDfe9icLPyngIo8oiXCdRG4eJqU9rsqeQejrVUvTomju8VFVen4tWE1H2nipL+4lVCncHhWWzansD1hAEQ1eIkrHg5SLvxml3YqR1rzf9IwATFbz9XQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <106dbb1f-1e47-ed64-44ed-94f5fc03290c@suse.com> Date: Tue, 19 Jul 2022 14:53:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: enable interrupts around dump_execstate() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" , Andrew Cooper References: <70cefb48-ab0f-7a84-ed31-fa44c3135fff@citrix.com> From: Jan Beulich In-Reply-To: <70cefb48-ab0f-7a84-ed31-fa44c3135fff@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50c1e85e-7479-4a16-79e4-08da6985ad0e X-MS-TrafficTypeDiagnostic: DB6PR0401MB2616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Mcopo6zkwDZKlw3/IgPxfNht7cLqwUo7kuHE7EwfDCYCQpUrINxH6Ffh63eEjUG1ZkvWJdX/xOm0NN7boKFS2VyNY42itXIA7VA4Clryy3vQNm8IAeTPEQY4iXrjSk9JMk+AdHwDjrPfxFi9SAxf6T+Y6ED2gGsihFLqN4GjOt2krWytOo2IY9rn/lzUF/mg/0bLbxVpl1Dt4oXTy4gnLdDAh5+ccjx7+Wx62J4zE90pM5gym9BIES4dQwn0SiiOWCT1BYrR4Zos30tFNTncsqyrfhJ821NKNg0mdKf23B3Rp4d+YLG/VmoUSxBjG3m8+xuaFpjV3zEA5YHwByvYSfF7Isq0iTO294gxIJYa1H2XBMk6P1ugQmWRxopPp8jT7oawMJYtSN/J9/ExtdbmLJTN2pdHlsq1YW0iOly0EPDEXKKcsCqhmBVWxIcuLyHJeEQ2PNNXtyMx1cnqLC11LqYVkkDk0l+aGgq0jfoFYCOpvuf6ZGA8owPCAMtGU7dVZvLtJIWADfpPShITrq5A+2Z9djjkQeb4M0rOFUN6nOS2ber2W+Q1Qclx5RkoKkRrj+kjZTEGWZYIEtAY2Z4HLtlR3jHbnGncoa+0UALqw4fgc5lQ8afTvcMPtS4RbVAlS99BmIzO5wAMXM1bJS9Lmgq+ef1trRGLNGrJYxacF/+35V3gL7OUiMrcVajsgb/kVuUOsBLEjoSRRi6eCHkLobKRQp0tqlXGFz8Oz0q/mW8nHptFa+ox/jxnLQLAvde9l/82LTGrm8lLI5Nlse8vQwwSySM5tL7fu/Occavg0HVl5pAC8Cm7f79M9fEFAHaWfQSQYabjWEF3cvFFiq1Hvw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(346002)(396003)(376002)(136003)(39860400002)(36756003)(6916009)(316002)(38100700002)(66556008)(66946007)(54906003)(4326008)(31686004)(66476007)(8676002)(2906002)(26005)(186003)(6512007)(41300700001)(83380400001)(478600001)(2616005)(5660300002)(31696002)(8936002)(6486002)(6506007)(53546011)(86362001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0xFU2JHUFc1eHJXZTc4TVo4SUNpZUg5ZXc4RExHdGduSWgreWRHd0YvR2hH?= =?utf-8?B?UHVmWDdjdW1kdmlxZnBqcHlDT2V6amNZcExtQW9EdktxTEpaQXdINFVyU3VY?= =?utf-8?B?RnJyUWVBa0ZSejg3b1JwN2RyZUtnV2VyalBueUcrdStneFF4RlRsNXAxSjE1?= =?utf-8?B?L1dmWmMwWE93NUxIVDBOKzl3YUVtUjVQcmY3OUhleTNEVnI4WTJ4TzBsZFkv?= =?utf-8?B?amlnRGUrVUxwSGhqa1hOUHFUWjVibURpL2d2QkVOeVBwU3lZYk9pN2lXdHYv?= =?utf-8?B?d01sU29Oc0hVTENwQnpoQXRYVmpPQkk1K3Q5L1djbWt2dDQ3d0RSWDd0aGE5?= =?utf-8?B?aXk4bE9xcVRUUUIwV0lsdUxzNUVXWENJem5yWVN2OXlrRTFnbkpsazgvUldN?= =?utf-8?B?ZkxWemhaSm1hQVNYSCtMTzI0OEZac2FoTVdEVnM2bTA4OE42WlJYdzhDdmhZ?= =?utf-8?B?MGRxMTZNaDVlamZEVXR1QnBWcFZVYUtjNHZOS1IxYTlhQ2xBU2MwWlpyb0ts?= =?utf-8?B?dVZuTnFyY1VhQlJ0NkNxTThxcGlXQ2VkcDZqaXhjYWFwUGhUQ3QreEdXQjZL?= =?utf-8?B?S0ZEK1Y2OU15OWxLQ2FLc1NMVUQyMzVOQS9NWHRRRUJtWTVsajJHNldra2Nu?= =?utf-8?B?clI1L0hEOEpJYzRZOUNwUm5vQnYvdTAwaGR6VmlxMnlLWFluYnVLYUQvcnBI?= =?utf-8?B?YlFqRFVSRnhrejZKWnhwNEpKbWV4NnI3ZDRQNlJYZC9Eb09EVnEzZ0xBY3h5?= =?utf-8?B?dGd3RUFBVkx3QmorVTJWMVpSaGdIRko2RHZlSG9oNDZPZVpzaC9ucHNjOWFu?= =?utf-8?B?ZE8yM0pleWhaTzlkYVZQVUswZHZ2MGdUQXVvbkZkMVp4QmhpTit5b2tWR25J?= =?utf-8?B?KzJXOFdhU2trVkpUNzlja29uajNMZ3Y1a3pXVWlEWmN1MkhKZWZkTmpXN1Jp?= =?utf-8?B?R01ocGtPalo4UndpY2FPRTJjMjdNdVlKYnlCZWxhSmJhclIybE9iWEZ2aFE3?= =?utf-8?B?V2VwRjk4dkNZWUdSTXlHVXRlRlEvUnVzS0ZjMWt3R28wZ1RUbkVnYVR3a3lY?= =?utf-8?B?QnZIN2c2SWJuaXIzZWpIQisxbnExc3pvdnZMWkllWlpnVVltNCs4UTQ4RnNj?= =?utf-8?B?RDR2L1BlTzRVRGVmSmZrbGhhQU5tNFB4OGVBd3p4Qjg4Lzh3OHlKbnQ0a2xH?= =?utf-8?B?WEdDMk8vcFB2QmJwMjFqbU1RZGpvUm1VTElYelpJbWFSaVhOVFM4dVR6ZnRj?= =?utf-8?B?TittSTVEdS9aak5hb3hUSkMzVkthdG0xRnR5NiswcG1abGtGeGhxemhHMGlk?= =?utf-8?B?Rkdmd3YrVEI1d3AxOHB4aHNvWm8xM3hocjV6N25yRkY3Skc4K0x5NVVja0I5?= =?utf-8?B?TlRMdW9FZUQwMkNCUW4wZ1BIZ2xIZzZRcU9BdVNuc3ZZZWp0THhRQ1pxWDAw?= =?utf-8?B?Q0t3OWZuaisvSUdSYzZkQVdQZHh6WUE2UkkyRXNhZFgxdWlnREFBazRCdzQx?= =?utf-8?B?aHRpaU5sU3BaNTFzZ0U3cGlKRXl4QkY0RzNseVFaWWZLRktGcGlpUHN0cUwv?= =?utf-8?B?bnRMRmNoNkxUdWtHUkxHY05VUGxwZGlwQW1DY2FzSUhIektXMG9LTHJaSk1V?= =?utf-8?B?Vll2SHc3OURTcUxuOTEvak9hSjZtL3ZIelhvL201OGpZZFpzWmtCS04zdk1k?= =?utf-8?B?TEpHY3R1Q0Zaa3QzenVHTW1YbWd2RVZkZzBwQWs2YlR0dCs3eDhpdHp1Kyts?= =?utf-8?B?N0dwQXVoRmZXMWpqVDNZYVJDMUlPRVArOUovc2JHT3ozaHF3TEhLUzBtWmtM?= =?utf-8?B?ZEg4T1VuT0ZVQlFMSDV1cmZOaGxjNjJuV09GZ21jaUgzWEhPd2l0bGlHLzV2?= =?utf-8?B?MlRIV25pc2E4T3hPTmRCYnQ5a2dRWUlIdnBrMkw4OWNXM081MlllV2ZhcUJ4?= =?utf-8?B?eUI3NGFOb2QyLzhISlVEcFVtTTFlZ3BYNWNFazlSa0xTSW9mVHFESWV0UStr?= =?utf-8?B?eTdBbkdZakl3UlA4ajhPUno1U3A5ejc1dnFRMWlUVnpvZGFxcmprU3NvZmZL?= =?utf-8?B?T2xZUTloUlRsR21KTUJpWWRveVk5RmRlT0duNjNyaGROZ0tuVk40dE9lQkts?= =?utf-8?Q?x9R0sSJ5pq9VYpIdWaTbEeqmL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50c1e85e-7479-4a16-79e4-08da6985ad0e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 12:53:28.2414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lEJce9DUgFCrN5Qqau+1ED5isSfg/vWojLtNC/s+8rJ2s7aAjQ0T3xz4TXQu7uvfp0ESHJ6/ZpNAuutRBcNsxg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2616 On 19.07.2022 13:22, Andrew Cooper wrote: > On 16/12/2021 13:33, Jan Beulich wrote: >> On 16.12.2021 12:54, Andrew Cooper wrote: >>> On 13/12/2021 15:12, Jan Beulich wrote: >>>> show_hvm_stack() requires interrupts to be enabled to avoids triggering >>>> the consistency check in check_lock() for the p2m lock. To do so in >>>> spurious_interrupt() requires adding reentrancy protection / handling >>>> there. >>>> >>>> Fixes: adb715db698b ("x86/HVM: also dump stacks from show_execution_state()") >>>> Signed-off-by: Jan Beulich >>>> --- >>>> The obvious (but imo undesirable) alternative is to suppress the call to >>>> show_hvm_stack() when interrupts are disabled. >>> show_execution_state() need to work in any context including the #DF >>> handler, >> Why? There's no show_execution_state() on that path. > > Yes there is - it's reachable from any BUG(). "That path" was really referring to you mentioning #DF. > It's also reachable on the NMI path via fatal_trap(). > > Talking of, didn't you say you'd found an unexplained deadlock with NMI > handling... ? Entirely unrelated to this, but yes. >>> and >>> >>>     /* >>>      * Stop interleaving prevention: The necessary P2M lookups >>>      * involve locking, which has to occur with IRQs enabled. >>>      */ >>>     console_unlock_recursive_irqrestore(flags); >>>      >>>     show_hvm_stack(curr, regs); >>> >>> is looking distinctly dodgy... >> Well, yes, it does. > > Because it is. > > You cannot enable interrupts here, because you have no clue if it safe > to do so. We're not enabling interrupts here (if "here" is referring to the quoted piece of code), we're merely restoring them. When they were off before, they will continue to be off. (In that light calling show_hvm_stack() is then still wrong in that case.) If, otoh, you're talking about what the patch is doing, then we're in an IRQ handler, so context outside of the IRQ must have had IRQs enabled. > What you are doing is creating yet another instance of the broken > pattern we already have with shutdown trying to move itself to CPU0, > that occasionally explodes in the middle of a context switch. > > Furthermore show_execution_state() it is already broken for any path > where interrupts are already disabled, including but not limited to the > one you've found here. > > adb715db698bc8ec3b88c24eb88b21e9da5b6c07 is broken and needs reverting. Well, okay - but what's the plan then to achieve the intended functionality? The suggested alternative with the patch submission (to skip show_hvm_stack() when IRQs are off) is probably necessary anyway due to above observation (if we wouldn't outright revert), but won't get us very far. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 12:55:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 12:55:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370612.602446 (Exim 4.92) (envelope-from ) id 1oDmko-00040i-JY; Tue, 19 Jul 2022 12:55:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370612.602446; Tue, 19 Jul 2022 12:55:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmko-00040b-Gr; Tue, 19 Jul 2022 12:55:10 +0000 Received: by outflank-mailman (input) for mailman id 370612; Tue, 19 Jul 2022 12:55:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmkn-00040J-Ef for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 12:55:09 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10057.outbound.protection.outlook.com [40.107.1.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 030d614b-0762-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 14:55:06 +0200 (CEST) Received: from AS9PR06CA0122.eurprd06.prod.outlook.com (2603:10a6:20b:467::8) by AS8PR08MB7268.eurprd08.prod.outlook.com (2603:10a6:20b:423::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Tue, 19 Jul 2022 12:55:05 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:467:cafe::d5) by AS9PR06CA0122.outlook.office365.com (2603:10a6:20b:467::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19 via Frontend Transport; Tue, 19 Jul 2022 12:55:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 12:55:04 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 19 Jul 2022 12:55:04 +0000 Received: from 9760c0453b81.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C7B1EC30-0CDC-4327-90FE-6A664953021A.1; Tue, 19 Jul 2022 12:54:59 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9760c0453b81.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 12:54:59 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com (2603:10a6:20b:570::15) by DU0PR08MB8140.eurprd08.prod.outlook.com (2603:10a6:10:3ef::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 12:54:58 +0000 Received: from AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee]) by AS8PR08MB7991.eurprd08.prod.outlook.com ([fe80::502f:a77a:aba1:f3ee%6]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 12:54:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 030d614b-0762-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kViW945caLFSJ6wDzCNTNXEbgfKsfWB/tpS0QK6VyiG/a0/5GMuGLpbo9RnXTMq1jUOMmpo5/4wLvdnAHucgQ9j52bG9g1oAz2+oN4ycRWg+lhMKDAESbFSZO3aiPiElVmGHm5UlyXlh5G6mZ4NDtRiW4f4k/joW0AeTJzCphth5snouH4xTOeYzEimJ+bJ/Nryxj5KKoGapfXgK2P5ssTSo3LtUsUGeC9m64gnqUukhWP0OezaCyErOaRjNVloo364FyyExV/6Sv3SBEKb2Wwn0mXgzFENFPqND9L5UUXu0bTx1cHjtELVZf3jl1di7twf7mNAJTwYKVmqKaQufgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=UnEN5Be/fAcUhax14QiDBwC00qBVh2s5Y0PGSecrfoxlBItfAR8dH9HwzjSIWyH3Twch6zRdxmGot+3rzdxeJDzEV3qAvbdFRucl1KapS3gYEr7AgTCHwB2R5+wVW8FIJu1c/a6Rsdv9obX2stS1pEKtuIwBCbnot0Nb+NHOYyedmcsi5wkN2MMJxRpUEzsElCYLzqerNwBNPTBKp+zg9VCPhSfZDeef7y7wSrhawBqcN9/iVPmBNT11D+bbYIxDEyKsxrS6rEtM2C0S27RMpsTM6FisHXFoWhduEFEPQ867/FfZIpPYrY8SsYM+d0TUeOZvJOS7/bI9K3D4IJlmUQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=YneJDwCCtmY0vp0J/KmGMN/DcBFGgJDz6GdEcFzaFrFhFS2aA7XCJxKnDsQAVMvs1hIkc9cUwRNXn5L6Ips4AJCB5vbOcq8EisUR5MmytbYbev3bbNJcGy9yhFgtcnmHZh4+kDfKSSQrUKAWnD+iCArHSoWOwVrEI2gfIh35o9M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D4k0JrJEZ1ZC0j8QOWgs0ce7961o+PEAEjTyMZ3aaZTJDwjF5ZPGoDWhufz9U+xCj5ABspzjsMxef0HQ50VqFeffsFRzu15ahSzQZr1PijElzzxaAPuadhfZRkVUId0v8ftUi7Bc0lr3D18awC2wjFwc6if2K+RrOxkokIcA5EJUJ9HipE78u2LHzLXRi2JBS+Jj+jAJRL01u2GgVmjVpBxKexGvk2qhnL0PMAszdfUcaS/a1DoVqdjDR2CFARhmdY4hGNbg5YKBDCHChvU2+qBOL6eeVpMtWG9qH8QGt80KDUyTtVF3AXFmcIC6jCCg/VjVReCMhD+EsMc8rKDPgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=IOlKwd6onCXdgXrilTYzOqoMQNXG/Ei4eCA89tT440cWr/OpCOVrlUxZ8efObIlJHIYvx0W0JkUa09nAHQwpIymi9wxsO6nNf9Ux1KBzvPiQPoBtKJp07T8J+Sh9S8bKyt2MSccetpQhFaHJvP/yZrjnL/D0djjiyNv4UETndX3f4NqbDm4PR69WxBavB0TWDXuGH6xSlereE8+kbgAf1C0+ws1sPznNjF5NYePSE0mcwpnsrVWM6qHQo3un6Lku0AWc/XXPrvYftJtFf+qwkCGShLl3bccpPgoCRWgYj0M4gKKUTwlp0NmtrRS5iLXg9UIaNPSobl+SW8xTra5oSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=msxlRL/HC5HQgsMWonauO60dvwfBFNbLtgNfN2ek0xQ=; b=YneJDwCCtmY0vp0J/KmGMN/DcBFGgJDz6GdEcFzaFrFhFS2aA7XCJxKnDsQAVMvs1hIkc9cUwRNXn5L6Ips4AJCB5vbOcq8EisUR5MmytbYbev3bbNJcGy9yhFgtcnmHZh4+kDfKSSQrUKAWnD+iCArHSoWOwVrEI2gfIh35o9M= From: Henry Wang To: Jan Beulich CC: "xen-devel@lists.xenproject.org" Subject: =?utf-8?B?UkU6IFBpbmfCsjogW1BBVENIXSB4ODY6IGVuYWJsZSBpbnRlcnJ1cHRzIGFy?= =?utf-8?Q?ound_dump=5Fexecstate()?= Thread-Topic: =?utf-8?B?UGluZ8KyOiBbUEFUQ0hdIHg4NjogZW5hYmxlIGludGVycnVwdHMgYXJvdW5k?= =?utf-8?Q?_dump=5Fexecstate()?= Thread-Index: AQHYkIshAZJzP1BUJUaUK2Iq87bw6K2FnDcAgAAebSA= Date: Tue, 19 Jul 2022 12:54:58 +0000 Message-ID: References: <3a5a1efc-e610-e151-fa58-25cfd9177f26@suse.com> <3a8d4fe8-de96-06cd-adc7-073bf746d5e2@suse.com> In-Reply-To: <3a8d4fe8-de96-06cd-adc7-073bf746d5e2@suse.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 951AF078280EFE4D9C48C485C6C0713C.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fc69c9e7-38f5-4eb8-fd11-08da6985e6bc x-ms-traffictypediagnostic: DU0PR08MB8140:EE_|AM5EUR03FT005:EE_|AS8PR08MB7268:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: b4VKvaBZrv/oQ3C2gizPYBJUZBqJxaD5QhbWdB/ORnRaIvMfLqIYACSiNy8wHkgBcyfn1UAK60eSIVJ+ynVD/FsxwdAifFxcRfT40xNrpx7XKZFget1BoDpI9bQRgw9YYg/cKFCB7OUQwI1ZdlMkq7qROGSuZr+aiAQAeWepma9rT0fGW7eHjSEx/SnH8TRaov+l+rt5kdFbT/+ywLohcYCbmYMDAcrfKXS/2JY1sBcnDpCO3HnT/kIwIgg2x76Xk4AIz6wFIOiw6Orgs7hqh4FzNLrxhNwGXIpwLNYA8BMas6ARZqhsvfwgD337kgWA7v7DA8UnNWNnU0OdPnyutJZMlUVJXCwNJt8ZjbPhd7E3eN+ZOvWRZpDq/iDAelsvmrRfCb+oZNsumGWP8+tOXOEg2ygsiHQMOBIw05otvjtHm3M3D5zFVv0ilcSh1u3POrHjLPsw+SiZsR1psvcaQ7g8LOj2G5vPwMcgDsAvwFVCkGNAFRM938z/QrPidQthf+dW9TcL8ZWnvajvq/UFMARBbSuf3F1S3RN/jmAJZHmMGh6LGZGT+HMVhMd8bdqI1gIqY9pd29Qp7x/uRVT0palOz8CYLVgwXUwBlqJIneVgTuDYS4LkLM2FDZvIN4I+1EPHcfjqObXpp1N7syV8uKekx+LjZ6hRFSj/d9GpqfhvT4cDOeOggLgvqCF9p/KSu92455McFRIXnSOwDmQpaVP8A0HU+y2OvdyXQYse1AiMo1M3uqoXLkGwj0pLsHXV1PRlDIkzA/RDS9CdG4zk0BdGy0FrldtL6u6K5nOfpLw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7991.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(346002)(396003)(376002)(39860400002)(38070700005)(122000001)(6916009)(41300700001)(9686003)(26005)(33656002)(186003)(71200400001)(2906002)(478600001)(38100700002)(86362001)(316002)(8936002)(52536014)(6506007)(83380400001)(7696005)(66446008)(53546011)(4326008)(55016003)(66946007)(5660300002)(66556008)(66476007)(76116006)(64756008);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB8140 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 85ed1d7d-da7a-49a9-8584-08da6985e2b4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aX/n5StFYfdqJEmdolPMc84zHmXomV6im0+gHXBR+fbJRlzQrf1BCy0Uwnw2iZfP3o4SuzAaLD2c5Ts1yWrzcAxyeDyAccRxVrNXo2uGY32HweK8hxr5knh+gd7U37hP0wsUiGowUkKtyfKbcsLrDbD8o19t/f/qnPdYf2HmR/3bvRoJ3qaiGQUMTzUdPAaMD366OjDuaTJcU/LTDpqyu+jRjuJRD1W42zyDUYMswsvLLbu3iPpA35ceNgB/vsfkKwis+U8zTcHQaOgfFORDBOpLYeZ8qmC0G3VRBHP256BrZt8FmfPxvieyUHwdqbHv04AIimdEbg1e3CzDfWzw8j1oRkVQG51hPPKFVHaNCbHk2U1RJ0fySymcw+DJZ+XzS/i5Rp/2B/2pVT5r1fRICWKtJL4Ulw9qAA5xncFg1iyGQLE3jppiysT/EqvCU1bvzAxoaJAFV01P7hDk5LAHE+R13qqZTgA6+0CzO59JqfoWwfFu4J419mIvnKtHDacmXaSE6kicDAh5f2GAGkQ0Cs4ec8ryIaP773/UTYu4d6osZZKQNTJtmSULqe33Idro61fUc1RYcpeinbTPiYfBe1wJJiHdkSQ7B3p046QtnYM+6oambbkZOIgmipmkS6EJ1ymo6amVq4ufoH8lxquzqDvQz25S3KdxbT5A1+PKuYfJjuWSu3TxXWcUU4pm2Q41gDo4DJp2/H2dTLsc+gRsKrmgY++CsrJDlxhps0/h24pxB2nKKo9vPkzsG6L+HdYILGFxYC+Mhebd8hTq1ZgGych6hRdKvGnt+pJ6LvZEDj8enkMBt8vwOP54FykOIbIi X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(46966006)(40470700004)(36840700001)(83380400001)(82740400003)(81166007)(478600001)(356005)(47076005)(186003)(7696005)(41300700001)(53546011)(26005)(336012)(316002)(70206006)(40460700003)(52536014)(55016003)(70586007)(8936002)(5660300002)(6862004)(4326008)(82310400005)(40480700001)(6506007)(33656002)(86362001)(2906002)(36860700001)(9686003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 12:55:04.8509 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc69c9e7-38f5-4eb8-fd11-08da6985e6bc X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7268 SGkgSmFuLA0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4gSGVucnksDQo+IA0KPiAtLS0tLS0tLSBGb3J3YXJk ZWQgTWVzc2FnZSAtLS0tLS0tLQ0KPiBTdWJqZWN0OiBQaW5nwrI6IFtQQVRDSF0geDg2OiBlbmFi bGUgaW50ZXJydXB0cyBhcm91bmQgZHVtcF9leGVjc3RhdGUoKQ0KPiANCj4gPk9uIDExLjAxLjIw MjIgMTE6MDgsIEphbiBCZXVsaWNoIHdyb3RlOg0KPiA+PiBPbiAxNi4xMi4yMDIxIDE0OjMzLCBK YW4gQmV1bGljaCB3cm90ZToNCj4gPj4+IE9uIDE2LjEyLjIwMjEgMTI6NTQsIEFuZHJldyBDb29w ZXIgd3JvdGU6DQo+ID4+Pj4gT24gMTMvMTIvMjAyMSAxNToxMiwgSmFuIEJldWxpY2ggd3JvdGU6 DQo+ID4+Pj4+IHNob3dfaHZtX3N0YWNrKCkgcmVxdWlyZXMgaW50ZXJydXB0cyB0byBiZSBlbmFi bGVkIHRvIGF2b2lkcw0KPiB0cmlnZ2VyaW5nDQo+ID4+Pj4+IHRoZSBjb25zaXN0ZW5jeSBjaGVj ayBpbiBjaGVja19sb2NrKCkgZm9yIHRoZSBwMm0gbG9jay4gVG8gZG8gc28gaW4NCj4gPj4+Pj4g c3B1cmlvdXNfaW50ZXJydXB0KCkgcmVxdWlyZXMgYWRkaW5nIHJlZW50cmFuY3kgcHJvdGVjdGlv biAvIGhhbmRsaW5nDQo+ID4+Pj4+IHRoZXJlLg0KPiA+Pj4+Pg0KPiA+Pj4+PiBGaXhlczogYWRi NzE1ZGI2OThiICgieDg2L0hWTTogYWxzbyBkdW1wIHN0YWNrcyBmcm9tDQo+IHNob3dfZXhlY3V0 aW9uX3N0YXRlKCkiKQ0KPiA+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxp Y2hAc3VzZS5jb20+DQo+ID4+DQo+ID4+IFRoZXJlJ3MgYSBidWcgaGVyZSB3aGljaCB3ZSBuZWVk IHRvIGRlYWwgd2l0aCBvbmUgd2F5IG9yIGFub3RoZXIuDQo+ID4+IE1heSBJIHBsZWFzZSBhc2sg Zm9yIGEgcmVzcG9uc2UgdG8gdGhlIGlzc3VlcyBwb2ludGVkIG91dCB3aXRoDQo+ID4+IHdoYXQg eW91IHNhaWQgaW4geW91ciBlYXJsaWVyIHJlcGx5Pw0KPiA+DQo+ID5JIHNpbmNlcmVseSBob3Bl IHdlIHdvbid0IHNoaXAgYW5vdGhlciBtYWpvciB2ZXJzaW9uIHdpdGggdGhpcw0KPiA+aXNzdWUg dW5maXhlZC4gVGhlIG9ubHkgb3B0aW9uIGJleW9uZCBhcHBseWluZyB0aGlzIHBhdGNoIHRoYXQg SSdtDQo+ID5hd2FyZSBvZiBpcyB0byByZXZlcnQgdGhlIGNvbW1pdCBwb2ludGVkIGF0IGJ5IEZp eGVzOiwgd2hpY2ggaW1vDQo+ID53b3VsZCBiZSBhIHNoYW1lIChtb3ZpbmcgdXMgZnVydGhlciBh d2F5IGZyb20gcHJvcGVyIFBWSCBzdXBwb3J0LA0KPiA+aW5jbHVkaW5nIERvbTApLg0KPiANCj4g cGVyaGFwcyBhbm90aGVyIGl0ZW0gZm9yIHRoZSBsaXN0IG9mIHRoaW5ncyBuZWVkaW5nIHJlc29s dXRpb24gZm9yDQo+IHRoZSByZWxlYXNlLg0KDQpNYW55IHRoYW5rcyBmb3IgdGhpcyBpbmZvcm1h dGlvbiEgSSBjYW4gc2VlIHRoaXMgdGhyZWFkIGlzIHF1aXRlIG9sZCBhbmQNCnByb2JhYmx5IGV2 ZW4gYmVmb3JlIEkgYmVjYW1lIHRoZSByZWxlYXNlIG1hbmFnZXIgc28gdGhhbmtzIGZvciB5b3Vy DQplZmZvcnQgdG8gZmluZCB0aGlzIDopKQ0KDQpZZXMgb2YgY291cnNlLCBJJ3ZlIGFkZGVkIHRo aXMgc2VyaWVzIHRvIG15IGJsb2NrZXJzIGxpc3QgYW5kIEkgd2lsbCBzdGFydCB0bw0KdHJhY2sg aXQgc28gdGhhdCB3ZSBjYW4gaGF2ZSBwcm9wZXIgcmVzb2x1dGlvbiBmb3IgdGhlIDQuMTcgcmVs ZWFzZS4NCg0KS2luZCByZWdhcmRzLA0KSGVucnkNCg0KPiANCj4gSmFuDQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 19 12:55:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 12:55:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370613.602458 (Exim 4.92) (envelope-from ) id 1oDmkz-0004KL-Su; Tue, 19 Jul 2022 12:55:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370613.602458; Tue, 19 Jul 2022 12:55:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmkz-0004KE-Pg; Tue, 19 Jul 2022 12:55:21 +0000 Received: by outflank-mailman (input) for mailman id 370613; Tue, 19 Jul 2022 12:55:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmky-00040J-KE for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 12:55:20 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150050.outbound.protection.outlook.com [40.107.15.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0a8a159a-0762-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 14:55:18 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2616.eurprd04.prod.outlook.com (2603:10a6:4:31::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 12:55:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 12:55:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a8a159a-0762-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kee+KzCvOLUAQesxG6oVa3RdJueFyQ1xQFHawcY9gLhTC0A7l8bbVz6m8jfaZVr9fs7XNrh25goXGzCWST6bW8xNYZZc4tgd6PRqSPnJ7eOvB5hNVcBNjsJofZAds3M2zHHuCywI0ol1cvmLaYZJPbhXGhUaZoLP9CK78n3fIuxCg2CtGACteOuEGtyHvNb858jz8nybElS3zx6tGjccJdQ43d2p3usTU7AvJnO3jTOqNeY05H3j+ipSHzKCvRZQs3UuZ+pQgxL3FI01vWPPidsnufDbqsn+gyXQG4T0y6JAA2y5WbWiohBcfY5/izzKLWaUFLQb8yjx9o8qWwyWMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MIKUVCNislRgAc5Hk4ifVRBpK6kd9oa3qSRRPckftEg=; b=iMwd/9Trj5/OfhnW8hgIR9V9F+SpCjzmXHbPvZxzcvg35CuBm4ziELXeRArL1ctwJ6/nuMWKyM539eLmAr7Lo0Kk9i0CLA2p0w0uumb5DDTTkoSECub4OVFkz/QEUhK0WmPMS8AP8UQ0IFqPEdxW1kBftTGXhN8ceRdMZUXD8n0tRilQmO+1rcUyi8TkeNixVDFwZo3ZdgM7xei07BOLHpFGrs7PK6AxPLKJeIhKJjv8YJfrXi3+5pKkbzx1BrmQxUsQg876YcWQBslMBNFreHNvzTKYDcdQ8MbiVI5qIciWQxQZ2vucRZsbHYIBqwpNbP10mKEq+VUMKh492oomsQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MIKUVCNislRgAc5Hk4ifVRBpK6kd9oa3qSRRPckftEg=; b=Nl0ngKN2RzLzAKNN+Bea1wHHv3mqIdLJWShNxL6GUfGWucNrQQIaH65ZehkppUf19uS2ZoAwE+RqffpRe8DUBHixUB9WUfB0/500l2EFT2XEF0dt19LpToB2YrY6ctfIMqSPJDitB8Kmnc33T1lG2VRWbd9yzsHlYjXq59WUlJJl4jOdzShLlBZ3ITGneMjxaD55oEtz43FGg8Dk0DoHf29OcFi68lVcqIyX4QZULrvXHdPgpPqLZN6w3vgGcH9wH4AHJf/ibIiqeYB5qt/PeujqX95hRXx17zyBbNuHF8O10F1rAUN4kkal6G+BITtj1+YW98c1t62aJUw8gk3f2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 14:55:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH v2] x86/PV: issue branch prediction barrier when switching 64-bit guest to kernel mode Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52308178-3c9d-4b89-62cc-08da6985eeac X-MS-TrafficTypeDiagnostic: DB6PR0401MB2616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CLq2SmRCBjTkHbJ2E7wgE8dwPkHKL4by9CxTtVcOPseXxNNlnRtdBEQ6T2AvuUPo15uUdvUowA3C5rYMgFOGx7d+Zz6YHEiZY9w+1gLu4h+gFYO6vJVJm6uRQPR5sbdEJrWeYxhcHjLjg87TQewWvJAk2wekPnBZdC2ned+rlzVjiDL79aipkkD9tm9/epUHQyJfBSlL0cQpztbELV4kTFL3G3LtEpZuevZhtt0xLuVT3wiH1T/W7Ky2PCYEvxURjdspwCuINkE5KQs0mYJ1fFjNwbKCUILIPwA+ezYs1V6KZYf8eOImYnKUeGzrNdAYjQv2ETt+owPu6Dx7tQEHRSePTSp4mQpRvssH3qzBVWa87yifAyraTF40OFMrtOT16CNOS8jak+TPy08/nUYfCH/689bEWBmrBsNaK6Ez7rMLgnP9xnbIW/gBednG3HHsZFYqHDAIEAXcmPXNNTqD24GQN66BAg0YVYnC4mCXFcnjcYAOVtJK6+LnZ8c6Wf2mmmCKi+NfmFgs3/Umi3843GDu29yL9VLkVHsZrGmzwOurNgmlGZckobaa4onoZAm62gEtg9EkShtu2nWlDD5sAd2wVTPSCuCnVB7u4PWEpAdfXnYJuPrfpbGFBfOGO1GnS9Qi0WwRj9nLm0jg1JWqWlx2TtcspK8z0AmGn0Hw21Y3bnPLayXr5hgva5vUHav+qoCYcMbGskvDmEQIje/5I/2VM0fTREfFk27b04zHdzfF4tftiJti4HIGT2E6G0moxvlfyxFRxXIEIV/o30+WXCrGyXrx6qFY0rV2Vd8YARxV2W/AG2qgpdpA5T5xScjIniKU3DVZfFZyDUl/c2Dcnw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(376002)(396003)(366004)(478600001)(2906002)(6512007)(83380400001)(41300700001)(26005)(186003)(6506007)(86362001)(31696002)(2616005)(5660300002)(6486002)(8936002)(38100700002)(316002)(36756003)(6916009)(4326008)(54906003)(8676002)(31686004)(66476007)(66556008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RzlJWnBXcWdTZG5zMEFQMy83ZmNaYmJZbXRRMmJrNWRuTHphakZzdVNFOVZ3?= =?utf-8?B?eStDbDU0TVJ2U0h4d0xZRHhkR3U1QW56UlIyVFkySUg2Qm14MGRVNUVQM0FU?= =?utf-8?B?QVNHQnFQMlFURWlDWHhkUU9hQks3KzRsaFo1UUFDdEJ3emtMMlVIeFNselVz?= =?utf-8?B?MXAyN2p5ZG5YTVdiSllqN2kxT0dkUXNRZStlNVc3U1l0cUhnQ3JtRHhQOU1k?= =?utf-8?B?dGwzbXdWdVJaV0h3cjdBUTdQQ2RHNlo2NE5RU1pBNzJLaEErL3JxUFlwMXZC?= =?utf-8?B?clA5ZTZqTjQ5ZU1DeC9ERVkzSlNjeE9xOFJFR0xTcXBvZExmU05DemcwS3ls?= =?utf-8?B?Z2Q5bVk4OVdlS0M2VjJYQ1diVEVVV0l6Z3RDbWVFbm9lcGdDZHF5Wjl5RlJk?= =?utf-8?B?RU5mZWRDeWdHbUtueEdJa3R6d1Z4UGNwRkxpVEtWc0Fta1M4cWZ4Vm5sVzlL?= =?utf-8?B?ZmEyOFZxeGYxTGltWmdYaFZJTVhBazZHWmtkWElaKzlweSt0aE9QQzRTOEZT?= =?utf-8?B?MXprTUFrb050azQrV0wxZjVLaExoRG9mVDEwbytYQjMzdHUwL3M3NFpSOVI1?= =?utf-8?B?YXFjakY5RmRwZGZQM0JtUFhJWERleWJ0ekhobUJqSWEzbzFQNU1MVGRKSzJh?= =?utf-8?B?TFduSTVCUktRbjduZGN6TWVRdkZTYUwwS3d2RnpESHZyekJKSVEwc0lNdFRm?= =?utf-8?B?c1hxekcydGNsLytTT3FabWJ1dmd4ellnT2FNQW9TcmZHZE0wQmp5UkZ6Yy9r?= =?utf-8?B?L29FeWRJQXFKd3drVU9EdjByQmFBYmNFaXVvRThWZjBoM3dCUEVNQUpUcFlZ?= =?utf-8?B?UHZpU0hqTnlUNGdqaGVZWWgzUjBGbnRkYjlkQkR5ZEFEYUVjdjh6dSsyTUdN?= =?utf-8?B?T1kxVGxZYVhiZnJFMmxkQUhyRUlzTDFmWXg4dUN1ay9XekVWWlIvTXZ3WFpB?= =?utf-8?B?aGI3K0hHM3lha2paT0xIR21vbEZZbklqbzRuV3BDVG9DWVg1U3k0UVIxTjVQ?= =?utf-8?B?WDU2TVREaEM4aUVqbDA1cjNBdHk5bXRjcDZFKzlOUU90R09aUFpLV0xwRTU4?= =?utf-8?B?Wk5SbTVSaW11T0k4K2kvQ2I4NHZ3UlVKVWRTYkJXZmMvZE05eHpvZDc2R0RW?= =?utf-8?B?TU96NVRzUDU2N1U5bmRaUmFRZjlFS2lHbFVld09sbjAwNTF0ZkFZMEVXWU5q?= =?utf-8?B?S1ZtTDFKYUJZK29tS0NFdllnZmtWZzVkSm5yWEdvNTFoZmNyMlZqbWZSb0tC?= =?utf-8?B?T1lvSk5xdmNoZGpNdG1IY0FudTlpRVNmSm9zMEltSUhlWjRYVlV3WEtFcjE3?= =?utf-8?B?Z2RWWjBGYk9KQWpsZnlja0NHK1luSDdRV25RRFB5bHdKN1FXMysycmhqdjBU?= =?utf-8?B?b3pjOXcrU0dBMjVzUmpzd2NZdERDZjZ6bStKWTBOaEdJclZvSlNEMHZzS0M2?= =?utf-8?B?U3ZOZ3RFZVBhM0k5a2MwVGlTVnovejYvL0pEcVhKV1VQOWVSRjE1ZlRybzVV?= =?utf-8?B?T2NmQk01NnorYXR0UFoxQkVSYXJhZWhGWFNFWlBTelBMeTJLOWlwTjVqZElt?= =?utf-8?B?Y28yQ2hXaXVqQjUrSGhteTYyVmxwaWlXNkdLa2drbWxuK0dxaThCbG5MNDVD?= =?utf-8?B?enlZQmlsU0RUUkgwZy9tUytpR2VuN01FdHJDWlJoOFBQb1ZCaFRQWG84ZktT?= =?utf-8?B?SlBRaHlmVkFRODRBOXp3SUxZQlpZMkMyNStycFkrQ0h6cGdFa0F5L1dzTEZm?= =?utf-8?B?S3ovaytZcXFEZzF5dGRzNExvTDFueFBvRnYzei9xOHZVYktTLzQ3MTgrK21y?= =?utf-8?B?dzFubm85aGR2eW1oclR4UHJqUzFRM0dRd2krM3BvNUtVZTYvMDBXR0xaaHQ1?= =?utf-8?B?L2ZNbVBUcTBETktqenNjN3JXdW5pSElDMitHck9JR2xnRllCcUJqQ0g1WFRV?= =?utf-8?B?a0FISzVpYUc5b05VNHVTVmUwL0paZlhwUkZ2TDdqenFXaEoxZHgvVlN3Y2hO?= =?utf-8?B?MVFGMWh0TURlYTQyOHpjUzdyWW9uV3hEQi9VVWt5V0tzREtseGtZOVBUUkhM?= =?utf-8?B?RitLUDFOVGxrWXBpTExKWXdHaXZNbGdPRTR3dktRZFh4Wm1lWThTMGZLM1Uw?= =?utf-8?Q?Z7jVOeQuQGj3HnS55dH1VlSG0?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52308178-3c9d-4b89-62cc-08da6985eeac X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 12:55:18.2969 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3tX1PRRlTHTBhBVseBKdmF6P6kNSBCwbWKWWf7uNGYDkUNSHXokFnH2kT84Ef4vNTdDcaiVga83xNNBskcCLnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2616 Since both kernel and user mode run in ring 3, they run in the same "predictor mode". While the kernel could take care of this itself, doing so would be yet another item distinguishing PV from native. Additionally we're in a much better position to issue the barrier command, and we can save a #GP (for privileged instruction emulation) this way. To allow to recover performance, introduce a new VM assist allowing the guest kernel to suppress this barrier. Signed-off-by: Jan Beulich --- v2: Leverage entry-IBPB. Add VM assist. Re-base. --- I'm not entirely happy with re-using opt_ibpb_ctxt_switch here (it's a mode switch after all, but v1 used opt_ibpb here), but it also didn't seem very reasonable to introduce yet another command line option. The only feasible alternative I would see is to check the CPUID bits directly. --- a/xen/arch/x86/include/asm/domain.h +++ b/xen/arch/x86/include/asm/domain.h @@ -757,7 +757,8 @@ static inline void pv_inject_sw_interrup * but we can't make such requests fail all of the sudden. */ #define PV64_VM_ASSIST_MASK (PV32_VM_ASSIST_MASK | \ - (1UL << VMASST_TYPE_m2p_strict)) + (1UL << VMASST_TYPE_m2p_strict) | \ + (1UL << VMASST_TYPE_mode_switch_no_ibpb)) #define HVM_VM_ASSIST_MASK (1UL << VMASST_TYPE_runstate_update_flag) #define arch_vm_assist_valid_mask(d) \ --- a/xen/arch/x86/pv/domain.c +++ b/xen/arch/x86/pv/domain.c @@ -467,7 +467,15 @@ void toggle_guest_mode(struct vcpu *v) if ( v->arch.flags & TF_kernel_mode ) v->arch.pv.gs_base_kernel = gs_base; else + { v->arch.pv.gs_base_user = gs_base; + + if ( opt_ibpb_ctxt_switch && + !(d->arch.spec_ctrl_flags & SCF_entry_ibpb) && + !VM_ASSIST(d, mode_switch_no_ibpb) ) + wrmsrl(MSR_PRED_CMD, PRED_CMD_IBPB); + } + asm volatile ( "swapgs" ); _toggle_guest_pt(v); --- a/xen/include/public/xen.h +++ b/xen/include/public/xen.h @@ -571,6 +571,16 @@ DEFINE_XEN_GUEST_HANDLE(mmuext_op_t); */ #define VMASST_TYPE_m2p_strict 32 +/* + * x86-64 guests: Suppress IBPB on guest-user to guest-kernel mode switch. + * + * By default (on affected and capable hardware) as a safety measure Xen, + * to cover for the fact that guest-kernel and guest-user modes are both + * running in ring 3 (and hence share prediction context), would issue a + * barrier for user->kernel mode switches of PV guests. + */ +#define VMASST_TYPE_mode_switch_no_ibpb 33 + #if __XEN_INTERFACE_VERSION__ < 0x00040600 #define MAX_VMASST_TYPE 3 #endif From xen-devel-bounces@lists.xenproject.org Tue Jul 19 12:56:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 12:56:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370624.602469 (Exim 4.92) (envelope-from ) id 1oDmlx-0005DW-BS; Tue, 19 Jul 2022 12:56:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370624.602469; Tue, 19 Jul 2022 12:56:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmlx-0005DP-8r; Tue, 19 Jul 2022 12:56:21 +0000 Received: by outflank-mailman (input) for mailman id 370624; Tue, 19 Jul 2022 12:56:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDmlv-0005DD-NC for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 12:56:19 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150044.outbound.protection.outlook.com [40.107.15.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2da1c9ab-0762-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 14:56:17 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2616.eurprd04.prod.outlook.com (2603:10a6:4:31::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 12:56:17 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 12:56:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2da1c9ab-0762-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JS7qZtJ/O0dXXrB0O9TTVcdOQMZC19OZ/0a7R96Ccbo7dCrlFbC0PBi/JwJoxnHcxdwvKoKs9YpkGPzzIi0ZZlcetPTIe/ubBPKb0JXkVspjXyFvDA2TdQj/kdlRfS62MAtIjA341Rs/MFEkMcGzFdBCaPkjXnzsF+paXhpDi0HokFuKP2XmeGmODvC2S8eNio98dIz8NLeQZqPDvXAgjHXairfqJ0Yk7q8reAJ0rTVM9SdQTkdhuQPF60+nz7D9G7lTodYl+Nbk5n5dUhzWsbiSMCT4LSs1hqIO1cNuv5kkMfv+T+8PMZH6KwRXgtcltW46lTT6yOx0A7kiarwuTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uzhBdq+jhZM8miUoFcMY7wVOXlpa9XQiV1LdPy+xLQA=; b=gnhiBZiVwzhcm4Eb81tJ5v8kLM9MfS42gQ2HybwAd035N6qrp0qySIUgf0D2K8QQe8yz0U+yfMcx/49Fpb4+n2BsLFeXIz5yrOteiizthnNbAjkfNKYApG8P3RIk7r/qmSsLIdtgu4rShnG2FfzOtvNPNeroa6kkiZK59AotzYHd41C0FSGopXabOOGaTvRfcN1h+7ClkcpuUO2QpKM0eVl3YFnnFrpnaOMo52u7dzmTUNfLjB/x8S8yv3L7ukkPdbcnb0w+CZ6g7L15GxFMplIIbyaKHkhuZImDeBCWaJ1e5z1gzD4aVCRkp5aCG0UzVfJGkXdz5GNTf7TzLypj9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uzhBdq+jhZM8miUoFcMY7wVOXlpa9XQiV1LdPy+xLQA=; b=PuCjCt2iXXkjd7KXWax/u1Y7YW5JwN/OkIkHXTCOEc5gFaZv06h1Vig1vPg07OM1jkWvOCwyfzRxmhCjfNaORTaOVWUR2Itji21JWX29Z80MiwammiLAJxewPkoWD1rUY10wB+2Qg4J4ffZq+F3DVy5MQur5+P/Fk9a2gk7mn5kGxJbiKO7o7n2g6gNcJ9UzCX/Dx3XdgcUZoQE3Jbl638SeRIvrOJYKt03gCwpuOkUVLgfr/x8SCJ1yfer93eNDO3XQmreyRqk/nnY2HBjtXVog+PsDech8JM87PER03zKwSTi2Opxgj3g7Ipijga/ghopxoKwG9MrLkIEOtTdO6A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 14:56:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86emul: add memory operand low bits checks for ENQCMD{,S} Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0133.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 543665ca-c1c7-4582-1eba-08da698611b5 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2616:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xfHs8FIJeQm6RaAtrNxAnQLcXLDRSPTdEPdU8uNScbXgJjqx/eY5B/jNZrcWuuGrRV3dr1KH9pHEbjPIOTEoMzmzikpb3/3iaIagPcj/Vp+0j4yryjcWIJ6d7q3FrBQndIZf89kMrrkze7ww194e1ppdiXamFU30VdKBdc4icbgj1lxAm762nAs8ma6CjEF+P9755YqLWy61drPmEm1dvxvQiiQJMD2i3q5FJgmVG3uHbAc6cw5nQv1nAEe3dm004kA8WEuXFw3PovcAFXDH1vaK4iku/GZWKdY13P1xWsyrFOoj4sPTEurWh34i5FQlwJScSqMZpMEFux4EJDHOlN4ENemidrK7JVFYfFeoYlyp/cO1r5dR7TV8wgO/cN/txBDxhOYKIiij+TMu/XT0uqXhi8MnG0hh02RygTEN0sKunrO9JLSTu1lHd+1uzCEMazNIm9u9atXoLEfd874/S/Oqdl5FqSxgGtlJtIGVXRXFdLaJkEXtxFpj67ngoKYiEStE4w+Ku/8aC+DBfyTEjmxbidAFjMOU+Ot+kXkPgoCPRBike5g9RX8z+qDXpVx2/AH+iWWako5kBbIGptbCOk82rB+10eMwVNjiUlvHTwyC33np0VR7/Q7onpWJBVCzXNUZk1kw4XPkNlTAzAcR09A2i1FmrkaQh1X1jHDLtq6FFNTmNQrpMZt/gIeQe+WixfEH8Opsb+ZTMtJFY5QP76+POsVI1gHM//OtEbtwIHJRPC6+4JkPHNtolgU+1+bfD5U+NK4tdyMEYk6GjB9hs1fQnj3uJUg9fj0WTl03xO1ZMtvbimo05L0gUzROTGzBVLgWLGKPA/WV+pd0lz0l9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(136003)(376002)(396003)(366004)(478600001)(2906002)(6512007)(41300700001)(26005)(186003)(6506007)(86362001)(31696002)(2616005)(5660300002)(6486002)(8936002)(38100700002)(316002)(36756003)(6916009)(4326008)(54906003)(8676002)(31686004)(66476007)(66556008)(66946007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzlYTTlrYmxndHQxdEZRblVFd1ZFeUl5T25EOFFNN1ZzY0IyZ2NnaEwvd0pY?= =?utf-8?B?d3NUUXIrNXR5L3gvRTdjUnk4dHJ1MG1VSVkrSnNpbDVrRTRrZXArRE8xMG9I?= =?utf-8?B?RTZ6emNPWGpBNUtWdWpGYVBpKzJnWEs5Z1UvREwwcVd2NzY2SGpIUk5jSENE?= =?utf-8?B?dHNlK2NPSG1zZmhmTkY1WlZObnZTNkU4ZDZqRjJhdkNHbldEUTFRc0ViZ3N5?= =?utf-8?B?ZkhDOEFLL3BzOCtvbSttMVBlYW5UOXBGTUN0ZWo2czlyVlBDZHFOemg1U3Jn?= =?utf-8?B?bGVGVEkvUldhVTZxSXpEZklHQW1FS3hweURqTmQ4TzZzaVQvQnMzR3NsT25u?= =?utf-8?B?S2N0S3hsOSt5ejdRNWVkMjBWRk1VdjdFVzRsdmxhM0dyK2F1Q2w0aC9PUU5W?= =?utf-8?B?Qzl6bksxZU9kd2ZqZWtVQVh4WlJmVGc4MkQwL2hKb2RDd2wyeTBYckUyN1lS?= =?utf-8?B?TVlHbFVuWjNybWVtMHZOa2dPMnJWdU81Z1VtUG93QjN6eFZLNnRPdFMyeitm?= =?utf-8?B?S3d6WFh2eG51eVNlaXI1eVlqRlI1T0l5aG1TNkV0VE5ERlp0ZDBoNGJqWGhX?= =?utf-8?B?dDBqSVN1VUVYdGR4Nk5TNTBIMVMyWm9GTmNROS9pMEFPSHQ2OXVPRmxydmVZ?= =?utf-8?B?aUFGNzUwVkdJTHBkK3ozdHVSbEUveVJ1dDNQcU5jNFdNWUU5MWFyMnhQSTZV?= =?utf-8?B?OEVlNjI1S2tIa3J3T3QzZmhuamtvY09rWmErRVU1amNlN0krOWVMQTBJeGJH?= =?utf-8?B?ZXZmdU5FM3huOUxsZTB1b2xYRjlMMG1TSnRNN2RSM0JqZE5jcGN5RWJRdm0r?= =?utf-8?B?S2VFaFk3TURYaXBvdkhOZ05YUmZzOVhyRlhveFo3OVZEN0dmZ0NhOEdBYTA4?= =?utf-8?B?Y05TQnFGb0VLN3hOZ3AzUFdQY28zdEk2R2tYQ3EycXNkdXZzMnFQVmlxSzJT?= =?utf-8?B?L21MY0JDL2hSdXNxQ3NtazhTelAzWndudThnWlVxeFdqNlZsSDBQTHp2R1ZO?= =?utf-8?B?WHliSkU3OEtFOTBCb0RVeHlyVnlGbmppNGVKYmJvcUV1NXF1R2ZrdUdWWjV5?= =?utf-8?B?b2paakdFdkt0bjVNbkZxTVIzUHptdjZ4QysxTlRXQXBLTDV4ZC8yU0JaaEVU?= =?utf-8?B?eGI0Y21rZ3A5ekYzZWpBYmpTRUR2ekhsTG5wSEltSzFzYkRJMHBicEJzdm9W?= =?utf-8?B?aUhxb2R5ampTM0NkS0RvejFsOTJiazd2R1U1YjhHUWdxOG5nbkpvRm1nM2g3?= =?utf-8?B?bllRRzJScGV1OHVXcWROL05RaE9EUjFxUkhjTHpyMUprU3NnV2pOam5PT2Zu?= =?utf-8?B?MG1IbjJRb24wOXJDWlRzdENvRkRxR1M3ZzdDd1I0RG0vL0pBZG1tL3F6ejdJ?= =?utf-8?B?aVlGcnpaN0k1ZlZSWlkxTk9HRkY1RS9LaVh0L1Fhc3o1R3M4V2NBZHhPdTYr?= =?utf-8?B?YXdTN3NqZjZYUlo0QjFmeHVNZkhhUDNPUktpdnNQMzZ5cWx4clpUc0l5VXlU?= =?utf-8?B?aEpEOG5YMnlaVG5WbnNRS0s3Vm5rQUNVcU0rbE54NHcvVkdiRFQ5TzdUeU9R?= =?utf-8?B?T2lNMndxcmdneGE5YmNJVnJxeVhXRmk5SERqbm9LMjhmM3MwQnY2Q1RuS0x1?= =?utf-8?B?VEt6NGJIbkRpd2t0VnhXSE15TnJNUWxSNlAwZUlyUElGb2IxdzlDWmpDMm5Y?= =?utf-8?B?cDhaSkMyQTBaQWxPNG9Za1NIVWJwaHBFbGFWcTZ6SlRjMXNlK2I5MFA4ZWFw?= =?utf-8?B?eG5Zam5udlZEd0VmRTNKWlB5RkU1aXNDYitUZ2xEZ0x1ZllBOW9rR2JJd0xK?= =?utf-8?B?US9ENzFGeXUxaTAvUTNHOEg1UTNoQ0EyYkdYTjhkQmJCVm9oNjJJUWNvNGR4?= =?utf-8?B?ck83ZXhTdm12dzN4WS9xenA5cVYyLytReStPeld3SSs3SFN3V3VrTis1ME9Q?= =?utf-8?B?WitJS2JzSktBT3pVZ1ZTRVNYU0FZbi9zYjEvS0c5NlZBMHR6SVRJc0FibnJs?= =?utf-8?B?am52VmxMVE9BbS9aNDVCOUUxNlYwd2pZUFRBcDAzZTV2Q1RJYjAvQ2R5UDYv?= =?utf-8?B?aWtweVAvNUVSVEZkQTV0VFYxYjJKN1NZNWZTZUxDYkppOHdUYXo1OVg2WEV3?= =?utf-8?Q?eqR8FYBJ5YQKyPHM446xH8BN8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 543665ca-c1c7-4582-1eba-08da698611b5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 12:56:17.0744 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tNcCm810zofYA900WUupmJvHNXQFNuafU75PRus1WIyGEoW9F9JloeSTCdDsDJ08I0htWuIqrvYhmC08g+Lwcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2616 Already ISE rev 044 added text to this effect; rev 045 further dropped leftover earlier text indicating the contrary: - ENQCMD requires the low 32 bits of the memory operand to be clear, - ENDCMDS requires bits 20...30 of the memory operand to be clear. Signed-off-by: Jan Beulich --- I'm a little reluctant to add a Fixes: tag here, because at the time the code was written the behavior was matching what was documented. --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -10499,6 +10499,7 @@ x86_emulate( goto done; if ( vex.pfx == vex_f2 ) /* enqcmd */ { + generate_exception_if(mmvalp->data32[0], EXC_GP, 0); fail_if(!ops->read_msr); if ( (rc = ops->read_msr(MSR_PASID, &msr_val, ctxt)) != X86EMUL_OKAY ) @@ -10506,7 +10507,8 @@ x86_emulate( generate_exception_if(!(msr_val & PASID_VALID), EXC_GP, 0); mmvalp->data32[0] = MASK_EXTR(msr_val, PASID_PASID_MASK); } - mmvalp->data32[0] &= ~0x7ff00000; + else + generate_exception_if(mmvalp->data32[0] & 0x7ff00000, EXC_GP, 0); state->blk = blk_enqcmd; if ( (rc = ops->blk(x86_seg_es, src.val, mmvalp, 64, &_regs.eflags, state, ctxt)) != X86EMUL_OKAY ) From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:12:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:12:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370634.602480 (Exim 4.92) (envelope-from ) id 1oDn18-00081M-Mm; Tue, 19 Jul 2022 13:12:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370634.602480; Tue, 19 Jul 2022 13:12:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn18-00081F-Jn; Tue, 19 Jul 2022 13:12:02 +0000 Received: by outflank-mailman (input) for mailman id 370634; Tue, 19 Jul 2022 13:12:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn17-000819-Ht for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:12:01 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00089.outbound.protection.outlook.com [40.107.0.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5f611659-0764-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 15:11:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6755.eurprd04.prod.outlook.com (2603:10a6:208:16a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 13:11:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 13:11:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f611659-0764-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SzufNF2FX6yfgxE/lk4IZ9hc+Dt7PwZChVxoSuUnz1gmsILS2S2LTuFkRcZiCPqsXveaF1W1W80W0myyPduN2m1eXm5xXcgFeaCOOOPq6GWHeArAEtTByr4KxitMQGZ8+fFtcztVy3cyHnElTMuivW/LcGNlexyNSfWgkDH2OAmwUnb4EvPoE/XM6CjWO4/Xvt2GUVWFnLRXNJhE/GhArB0sQBh91NBe+cxZYeH7JZpTZ6BEYWfOcyvjihmaJE9U5vrQ53thk7E9FAs4fMhNRq32ZEbKoigM2cK32tQc2xvKDP/pBBsrDUKJV78COoifBoNiEplKuszQZicB+ngN3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GMIYP5hlYXCfohQKOngoeBwMxv8+5FmVs6MIHhxCB88=; b=SX65p7GBXs9hMxl0yw85QSzompWouZU3wfDJ4ir95HSlfIt2T+Kbh3Xq2Rhz/t8mKfEPiTDa5BPMmWaZH0Y1skEKi6jTXxRtT/PUynZ3fyrmQ9AxwfV6+wgnH44UrdCHZ6WeKh/nzWjZnyhVbhcNISJGPuHAzULjb40HpbDf9MccYO5vkDQGS3hV8DJXmapxUNjSkFZCCUWmQlzTBG+/GOS0VkNPamYPiIPLoa9KmhX+npdG+pkp3bUlpTygs+tsr7IIx1ugUmlBNEWHEk+1tiNYDtBWzijvwI9OahWWFZqSB2pv8mihDesIfHRUw9MI4KjJH6ovqcKALnpgvfCpvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GMIYP5hlYXCfohQKOngoeBwMxv8+5FmVs6MIHhxCB88=; b=MnQnfq7YJP++S8Ypqj4Q5dqY/geWZCPLllEgbtVz3yarBTl0sNffnX9nXwt9vrmS+Eygos0sN+TLyPEcxiPnlQZzE5R2cyw/u9PP0gFcnVgJgXh4P+v+XCu8SvplRTNSOR7qLLvow/xPYNcyhIACjO6wsrrzTa0la6zSqKCmzBE6QjEatVQEtdeCltPd6fautdxvbx59PVfUxf1in6cGZOssDmbkzISOuN7N515oMYHQDwNuUQ9XT6cwWo4Yn0bm+XauqVjJtlu7z4hKH1f4F3KREJmm1X9wPxAmzrP+5jUINygj+FRSxvN0/j5uPDU9j8N11JFpUTCA1gTeR1wKrw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> Date: Tue, 19 Jul 2022 15:11:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 02/18] introduction of generalized boot info Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-3-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0040.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:84::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d0d8fac-7269-4d8a-1866-08da6988427a X-MS-TrafficTypeDiagnostic: AM0PR04MB6755:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WRrFfG0FfcbEvKLbIYJ0b6eHwohPY1upp+zeni1d+F0uMKbz3WJQ3rSNAnAc8xhbfYhMfsuVR7sjIsHvTp8VoMwnIkz+xa5eRq7WCrDoMKjctn9qbXRCJn6HLVCTUQfDkNqsAnafhhkLZIHgGs2d3jZg71swLyp/qZiznQxKLN6Pi9m7kEtyZ8hpsL+LcRb/0U4n3gJXU27eF1hPS0OV0L7Yef6eMzyx55iNR661JtkBs3x3I6e/zA2NRIg0knlcnU+Wc5fQWC5NB1LP625T9xGJUjVqURFAhXQjBYU4nOe77jTSB1RASEKjQ2oHMq+DbP1usA3yl8JuzWh8q2/1I+dCc76En+mpZK4xP1K8N8m1YwqlE8GnlJA/HB494rNTa6X6EzSnXAyyJfIdBbnML5x/khzMwce9ja/JQrHA1+tlHpyDBUJEEEJbkglala7LCMYp/JwayF72CUE/amaQIzGVfn/yQO5gxisKLehizx2cVSgUvsQ4avHmDDPwcFzu2rN9+N73uEJ8TICDJY2PdWsa+Hb7Ht6eA8DeHg5mIXtHdKsvt7Y3u+keBtTF0vJXp4x+4E2UNeMB6j/L7unLZQfovsk7dM/YFR+EaRffFOMYlWEfcdV7qUQIpJbyefgemtOlS8IUBAqGhYO7LMF841pMQ8+Sq6MkHZK/25Gk+7fJ7LbEiQj66Qkg5Ld4fXAkTUf3I4lMPXPaJyCAO8x5F6m+Cw3+hB0wPEDLY8Kn3KXuxc+7Qs4UNmp+vCi6Du1f9HilSe+BteyS3w0laFC/pHThIMXm09lC7Tu6hqC/RkKwqG59ma9kLzX70sXqLZ/2MS4fmcY47Rz3YwPW7iXKWA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(346002)(396003)(376002)(366004)(5660300002)(8936002)(7416002)(66946007)(66556008)(66476007)(8676002)(4326008)(38100700002)(2906002)(36756003)(31686004)(6916009)(31696002)(316002)(86362001)(6506007)(478600001)(26005)(6486002)(41300700001)(6666004)(83380400001)(6512007)(2616005)(53546011)(186003)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2tSeVJ2RzNMSDBIc0V5OS9NeGdTaHE1WEpXdVdQS0Q3Nm1nZ0ZRRFVUNlda?= =?utf-8?B?WUptM1V3NVd5WUtQeGRwT2VZTmgvYnZFZGVmU2JiYmNRTWxMaTFabEUzajBI?= =?utf-8?B?WWRrcFhBNFJzNCtDejN3YmE1L3hJb28xTXBOamo3M05Zcjh1aDEwcTRWNzQr?= =?utf-8?B?Y2JZYU9mMXF3aXhWaURWZnl3ZjlUcGNhVWlrUGdta0dCbnh5WGpIWFczUjU2?= =?utf-8?B?aWh2OFRkaDIyWk9BYnNTSUc5ZDBLTlBQa3lyNHZYVFRQSGhGU1BFVjhyaGRD?= =?utf-8?B?dTE1dFVoRGpwaXdKeWtNUUJuK0E0cHBoNjVreEs0dUlRVGZwcVNKbFd2dWxv?= =?utf-8?B?OFFERHR1Y2xOaGdVWVVMNklxMXcrUTBIN2l0UmdmL1ZQTUlpeHpDYlR1Nito?= =?utf-8?B?aUF3YisyOGdvTWpuRmxjb1pWaUlyd2Jpc2c3MHFGbGROM1FuWjB3Z3U2dVBo?= =?utf-8?B?d0JaTEJ5YkhOM1R6WCs5eFJrVkcyd2lPMWorY1pVVkJhQTVrdWVxVkhGd2ln?= =?utf-8?B?cVAxSFFkV09HZmFocDNoc3hweU42MHVSVXNwMWxZd3BDYkdZWEdVQmhoa3Yr?= =?utf-8?B?M1JROXpxMGdacnVLbElGKzErZHhxNTNxWVhZTUlhd3M3RlViSTNvVGo0WTkx?= =?utf-8?B?dUxGbzRjd0RpcTNuejd0MXhtK0ljMjFQNW0vV0JLZXdxVXVCV1RuNHJIdE1t?= =?utf-8?B?YU5QM0wvTFVOWms4K2pSY0J5TWowbXRvaW1BZFFDeFRtb1ZWQnJZa0tzTG5x?= =?utf-8?B?Rm5VWHdnZURwODZsMllqcDhEQUFvemJiUlFSVG41S083K0Q0MnA3Wkl3Z2k3?= =?utf-8?B?MWdzbkd4YTRrYjRtNHg5aXRkZ1VIeit1anNyMkhPTlZtYlVPeENFVXVJdVJn?= =?utf-8?B?SlhnTFJiaTEvY2JkS0tObEtYRFJlVjNTa3hEakRLd3JDeW9IUE91MzdYVjZ2?= =?utf-8?B?MVBwcTJUMStGYWhyT2pQM2NEOUtaczA5Z1hHUy80VlJrYVlXdEFQMlBMc0t1?= =?utf-8?B?MVV5WU02bnhPakNodmMxRTF2Sml5cHVoZ1BnNkRzWEFuTktYQ2FVWSt2Qi9D?= =?utf-8?B?NGsvZDhCYVhCYUpnZjd5UVcxUUJ0dkxYVCs3OWNPME5QcEJ4cy9FUTVvTy9r?= =?utf-8?B?Q2VuSlR5WTQ2RWtKRlhaMUlvVWZac2p4Yk9iNEpadUJVS2FDbVZydjgwSTYz?= =?utf-8?B?OVhpNVpDczYya2x1ZTZXZ3JpaGswSUFBMmVnZ1V6ZlBSZ1VNZldyaWU0Rll0?= =?utf-8?B?MFdnbjBuNEprMlFBMWQ2bTFJelF0ckJUUS9xZUpSaFZCaHJHVERwOUNZRWs0?= =?utf-8?B?NzM3RjBTNngwR2NDWkREWlhDQVhFT2pZZ25sdnFOZ2dKWnBkNm5OTFJ2aVJX?= =?utf-8?B?NnM3U1dqMkN0bnlPTndCcFpSc0JHY3BycENwVzFsbGJONlQvdTlGOWtDdFVL?= =?utf-8?B?c1ZIY3FNaTJqRTVTZGY0bjkrdDlZUnNnS3ptNWtIZW1OaHMyQktIN2NJd1l2?= =?utf-8?B?TDA3azhJSnBYUTFOZmZIWFJFTVBXZy9SM2J0M2Ivblk3eDNLeTMvS2srMCs3?= =?utf-8?B?Q241Zmg1dnJCeWJwVmxGanY1Qll5bzhFTnZxbGFCZnZucThlS1hoMW5LR3Vr?= =?utf-8?B?T1FNbG9iVjl0ZVI2Y2FCdXNFVG1CZmVhUkcwSnB5eVRYUFV4TmZLOHlkRTdB?= =?utf-8?B?YTFoTmZZVjZ0VDZCV09KMFNpa3UwT2NmYXlFd3FVcm1VMklCU3cvUGsxVmlp?= =?utf-8?B?YXpadjZTeFZBcXhOWTg2Qllxc3RiZkZYOTZUZnJreDJuZWFCRzc5bVZPdXBG?= =?utf-8?B?cVRlYm4yVlV3YmpNbEtjYXZldHVRN1UzTkNiei9TRExGL0c1akdtUStoKzlI?= =?utf-8?B?ZzFGc3AvZ0VsMmFYWWMwVkJ6L1NpbHgyLzRXdjdJa2dIanp5TEVMa3BPdktj?= =?utf-8?B?aDlRdFJvNkgwNUhrQnNhdlV1SFpqTDkveHhhcUpiVGJDTFpvM0gwN0YzSEhu?= =?utf-8?B?c3Y1OHBOenp4MzlUdGJoa2l0Smh3aE5RbVUveVJvQnhlUUxZVy9rdkxrcTB1?= =?utf-8?B?Vlk5LzcxTDA3R0o1V2EwOWJVUWFKeFZqMUxVYnk2NENPWnBLbTRWZWtqRXlM?= =?utf-8?Q?eRzxWhKy/ChpFVrB/hKqv8YLp?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d0d8fac-7269-4d8a-1866-08da6988427a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 13:11:57.9206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ViowguatBJHb0f4OLoBKfrwtBOwqQIItakKuOSQTILixnx5axQEbrto0ey5xp+8H5CPJ4g8BqKVkjk9UtQ9Blg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6755 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/arch/x86/include/asm/bootinfo.h > @@ -0,0 +1,48 @@ > +#ifndef __ARCH_X86_BOOTINFO_H__ > +#define __ARCH_X86_BOOTINFO_H__ > + > +/* unused for x86 */ > +struct arch_bootstring { }; > + > +struct __packed arch_bootmodule { > +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 Such macro expansions need parenthesizing. > + uint32_t flags; > + uint32_t headroom; > +}; Since you're not following any external spec, on top of what Julien said about the __packed attribute I'd also like to point out that in many cases here there's no need to use fixed-width types. > +struct __packed arch_boot_info { > + uint32_t flags; > +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 > +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 > +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 > +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 > +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 > +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 > +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 > +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 > +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 > +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 > +#define BOOTINFO_FLAG_X86_APM 1U << 10 > + > + bool xen_guest; As the example of this, with just the header files being introduced here it is not really possible to figure what these fields are to be used for and hence whether they're legitimately represented here. > + char *boot_loader_name; > + char *kextra; const? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:16:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:16:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370641.602491 (Exim 4.92) (envelope-from ) id 1oDn5i-0000RB-9I; Tue, 19 Jul 2022 13:16:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370641.602491; Tue, 19 Jul 2022 13:16:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn5i-0000R4-6G; Tue, 19 Jul 2022 13:16:46 +0000 Received: by outflank-mailman (input) for mailman id 370641; Tue, 19 Jul 2022 13:16:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn5h-0000Qy-1Q for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:16:45 +0000 Received: from sonic307-54.consmr.mail.gq1.yahoo.com (sonic307-54.consmr.mail.gq1.yahoo.com [98.137.64.30]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 075bf7aa-0765-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 15:16:43 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 19 Jul 2022 13:16:40 +0000 Received: by hermes--production-ne1-7864dcfd54-zcbtw (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f8a194b32ac8dff4c07ef190f4a5c24b; Tue, 19 Jul 2022 13:16:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 075bf7aa-0765-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658236600; bh=i+MHmC3f3nRIa71TZ5V0lJfoBtcQ3Szmjn8VPRGZXig=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=PhWZ53ZTCllywnY+bGq0JlI3RLYHN0ZT1uacDe2L7F0rbnShp3mHCGZP9YkrXkDpmzCSlcvcCMXiPUJZOgeJuGNZ2hjQXMSaKht5YfahbgXhncWgDPxjEPdeBgETpSg2fzoKFTPEN4YIyu6Klt+nU4WIO1dpwtUSSrZ9qGQ+dAibun//+9W7rG1UM1yDc8HbJ+qen+Lw+4XJxxoV1gHD2eV1sZ+R4Y/N/6MwZ0DvtLbb6w5f4DZfcZzrFxIYIex0VYJJARh1HBTHIuxYC6IWzdZ1r1A78w/de+3p0tSSx4x6eyCbwy2md4yjxwpWUUeNTLISqCiqA/NJveZ8mJqQZA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658236600; bh=ZwKFe3NDbpGlvjCIECpC3Bpp0uLTj2n6XiB4+GzCk2F=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=AwG8XX1e6kdTM2RygujQzsKa2StldLZff6uUm4NC0VyNfPIw0XtzKBlZVpBg4vGAxXQsUCGLNuyTV+S69B0ZkWndf6+hghQIcdYP/jGqSs7WMUs8Se6NPnxMwR76UMaTQVWTJTpS0kIxfO8lnAbn/+pCTwIgnUVN+GkzG2r12CpqR3FmtRyrqBCzKA8g29mAvXPOJPEjHYsAYVXyo2JW+SikAFpBXIS0iXmTBQBICDvENxkCmBtcxCyfKDRvMsIYKJLqOGDuz8I82EJTw3K7whZ3xaML0u88FFYT7uWndfJwyS7LEolKe1TsMIEY+S8E+u4EqdDmJsDR1eVRZkPoow== X-YMail-OSG: idGw8U4VM1niBTlOcwHK07XhbPiQyi2sNeAnUxpcgKMxFFgZwZJYqEr3JochjSn hRikbd48hubP3r5AzQy7TYEX2ZrK79Jj83hzVIEkykqFFOokkAHuAhg_LTPE3FDoEz430_ePwVM0 OsgrNhZ1vFeyus4S3VPxrVsyvMWv2UhDQJQYSBG8uUJRiFQCaHbknpX0bLXhxjYEo1iVQFj3UgTF jyMQtETf45nryFUUkhMuKETJ6pPLqXo9TmRu6rSKghOL4Flg7MErYW6WevwtN_3izKNhv6FGEHPG U0iqC_fwVSUk8aaGghfVZR2lBTeoeHL_PKefNGLMivM99jweL1GiiRtAkTPae9tqlACNv4am8i82 iCvchdvB0quGk6ks9xS7C6Le7bRSD9MK.tHv69w6qsBNJCQuHzNKAVh.qodQYAZDH_Je.xG5sVmG DUoL.VOlBlQF2275FhitN9QnKIIQpvFLgK1Q.ZlgIGoj45Z1T_qI.vC94F6hFrWuPL6elz7JbBqK .BwbaMl8CeZkgtnX67T85_cB9aKoO9GdERn2WrrdAmf1e2dB178ZsTc3U0jQ3VMzADW.WQH0QWqd lLTkGDYpI5eJlZIQCg9W4mFJ5AZoZTrJOyPgJ3mLakhqsAKR64RSkJrqkhjFhfJttcuTDOucBoTz cV42iSMP4bSY.n5WaOCeO0layGsJmgA4_YKMeZUYCTfoV92pYARCcwm.32o0V_MxuFOBKzop6rRZ sOyy.578hrtxADgo_MGc5rhqt3vcQJOTzotB9V3e.ldXrx6dkI.ocRj8eNYZJEmxieE5p.0ijDlc bNCNSqqapVvWZjHpOmNUVQSiWA8JG7tEvKdMZ3yU4.DepJoxgoIoZJDlMvNvyo6Twzr.o.ZEkkzH zRZMiCNIFZXTptBzEOtQq4.Br_dRIWyijvLhhGf1_2D_tXWYDQbRYitaKO7C42VIy27Ga.v6hUht tWnZaJVxNyNONSAmNAt8t33z7Z.lkjj.eQsXAoWGiGzCg7O2lpRT1DqdskzfSeKH7oUEEr_NVOOA TMNIzoGETM3O0H0thXCU7aRFo5ssZ6jQpXhkf_Uo7j1bdx_CILNPneqkIFKcwUihbGrxvNDW2Otq zrVARYNrtGpMNjHlathA7RJOJSeZWAcO9c9i3n7vQd0mv1DOzpeHBhQ786sEtpc.tByw1U9Px1Gr 7DcbAPfXnVA5fOddpdV9JmctZnRIM_2_LBWUbLaz_j2ftEY44y3PjwQvsELIGa11i1U1O1k_loIc whn.1xPQSDNGNmgA.adcNGVt5CakQGFYcNr4ZVrgRBeP.Yv0deXBXDseUduByPu65JP9ES3TkpbD O2nEBDIEvKNNWkHs.d40g6hRIlPh3_FfiizQlpMl12W.BKAil2v3qJP65wDNZKPKZ2ZQ6omCALyt NtyFuC.SyuhCJY6cF_t_I79GtpUmSlM2GNLuoY0xo4R6caC4CYO5LimcwNESFGmmcvvzUyIqUmm5 CMIoxjWs7gs5rtX8J5Mz2MRlMWyIGDflFYBXGHJZv.ibn.8VGXIF1H_h1HnQNoQpK1PtI1SKJekI Trcwky8SIft7Lsj.GSexwiG.qJrChCnb.ItU1MdFio3VHRIv2UFDIurjctQz1r.EJ8tk3d_9Xy53 ERon6OqshmOiQjLBSy_BUherSuotY49.ep4ZoVSB_zB2kYpPkv936g3hs_8dMyxOYoLKD.UaotwU SwbIIGnGfnXaGnPI9gfKqzRNIo7KlZg.oaZpjwYTyuZAFIAWKJm6dhCBrYzWJ0SbNPNeQO28IbWU f.60f7uxIx23V6kkX7VDQVj9MtBeMkhHBD4Tnd_oPmX0WuuMCtq9D179prWGZfkHcQOkrBPd1ULF 9XvZxJjwZFTt7Pq_kWmroFMnV50vQ15Jx6yk1.Mukkg8kcEJdRq8JikSUTE2vXJ8wc.lhijLkb_L JA.RjuVr4pyrzm.B6.DKQgVJmUBrH9AT6tZX20nALWqXkAw2MVhfqzLaAWyhfjSYPwoWwlNpQIFH VUb42Ke5l5DrN91uYVrlLfD5a12FMbh1UP2h8DYlISzx0q8U7X5mRf4z8CQ2jf5acDHdTewQiw3l TFdyWCXIEWIGIXD7uPaNsxDxKCp74_Y.x09zd0dF7J0da_7Ky8CIuAdCMMas4BS0_dhe9FES0.Yu 2Pl28pA.HFv65DJ8xmTolmQkRLFvRNuCNXWxB8NXWzCQpA9Y0zHbF_1iRBtIMAxfkarKCWExrbDc LJg9ZJfbwojhVOeZC2xpJ7nFG7O4_P9.DpAUMmL5FGhy.HYx4zT05zrCEmm.Kzmamf0rvgRGm7ip V9m6ymQ-- X-Sonic-MF: Message-ID: Date: Tue, 19 Jul 2022 09:16:32 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 0/3] x86: make pat and mtrr independent from each other Content-Language: en-US From: Chuck Zmudzinski To: Thorsten Leemhuis , Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, Borislav Petkov Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "# 5 . 17" , "Rafael J. Wysocki" , Pavel Machek , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky References: <20220715142549.25223-1-jgross@suse.com> <4ef8c3ae-b365-03ba-0e8e-9f4a2bf53748@netscape.net> In-Reply-To: <4ef8c3ae-b365-03ba-0e8e-9f4a2bf53748@netscape.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 7126 On 7/18/2022 7:32 AM, Chuck Zmudzinski wrote: > On 7/17/2022 3:55 AM, Thorsten Leemhuis wrote: > > Hi Juergen! > > > > On 15.07.22 16:25, Juergen Gross wrote: > > > Today PAT can't be used without MTRR being available, unless MTRR is at > > > least configured via CONFIG_MTRR and the system is running as Xen PV > > > guest. In this case PAT is automatically available via the hypervisor, > > > but the PAT MSR can't be modified by the kernel and MTRR is disabled. > > > > > > As an additional complexity the availability of PAT can't be queried > > > via pat_enabled() in the Xen PV case, as the lack of MTRR will set PAT > > > to be disabled. This leads to some drivers believing that not all cache > > > modes are available, resulting in failures or degraded functionality. > > > > > > The same applies to a kernel built with no MTRR support: it won't > > > allow to use the PAT MSR, even if there is no technical reason for > > > that, other than setting up PAT on all cpus the same way (which is a > > > requirement of the processor's cache management) is relying on some > > > MTRR specific code. > > > > > > Fix all of that by: > > > > > > - moving the function needed by PAT from MTRR specific code one level > > > up > > > - adding a PAT indirection layer supporting the 3 cases "no or disabled > > > PAT", "PAT under kernel control", and "PAT under Xen control" > > > - removing the dependency of PAT on MTRR > > > > Thx for working on this. If you need to respin these patches for one > > reason or another, could you do me a favor and add proper 'Link:' tags > > pointing to all reports about this issue? e.g. like this: > > > > Link: https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > > > These tags are considered important by Linus[1] and others, as they > > allow anyone to look into the backstory weeks or years from now. That is > > why they should be placed in cases like this, as > > Documentation/process/submitting-patches.rst and > > Documentation/process/5.Posting.rst explain in more detail. I care > > personally, because these tags make my regression tracking efforts a > > whole lot easier, as they allow my tracking bot 'regzbot' to > > automatically connect reports with patches posted or committed to fix > > tracked regressions. > > > > [1] see for example: > > https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/ > > https://lore.kernel.org/all/CAHk-=wgs38ZrfPvy=nOwVkVzjpM3VFU1zobP37Fwd_h9iAD5JQ@mail.gmail.com/ > > https://lore.kernel.org/all/CAHk-=wjxzafG-=J8oT30s7upn4RhBs6TX-uVFZ5rME+L5_DoJA@mail.gmail.com/ > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > > > I echo Thorsten's thx for starting on this now instead of waiting until > September which I think is when Juergen said he could start working > on this last week. I agree with Thorsten that Link tags are needed. > Since multiple patches have been proposed to fix this regression, > perhaps a Link to each proposed patch, and a note that > the original report identified a specific commit which when reverted > also fixes it. IMO, this is all part of the backstory Thorsten refers to. > > It looks like with this approach, a fix will not be coming real soon, > and Borislav Petkov also discouraged me from testing this > patch set until I receive a ping telling me it is ready for testing, > which seems to confirm that this regression will not be fixed > very soon. Please correct me if I am wrong about how long > it will take to fix it with this approach. > > Also, is there any guarantee this approach is endorsed by > all the maintainers who will need to sign-off, especially > Linus? I say this because some of the discussion on the > earlier proposed patches makes me doubt this. I am especially > referring to this discussion: > > https://lore.kernel.org/lkml/4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info/ > > and also, here: > > https://lore.kernel.org/lkml/YsRjX%2FU1XN8rq+8u@zn.tnic/ > > where Borislav Petkov argues that Linux should not be > patched at all to fix this regression but instead the fix > should come by patching the Xen hypervisor. > > So I have several questions, presuming at least the fix is going > to be delayed for some time, and also presuming this approach > is not yet an approach that has the blessing of the maintainers > who will need to sign-off: > > 1. Can you estimate when the patch series will be ready for > testing and suitable for a prepatch or RC release? > > 2. Can you estimate when the patch series will be ready to be > merged into the mainline release? Is there any hope it will be > fixed before the next longterm release hosted on kernel.org? > > 3. Since a fix is likely not coming soon, can you explain > why the commit that was mentioned in the original > report cannot be reverted as a temporary solution while > we wait for the full fix to come later? I can say that > reverting that commit (It was a commit affecting > drm/i915) does fix the issue on my system with no > negative side effects at all. In such a case, it seems > contrary to Linus' regression rule to not revert the > offending commit, even if reverting the offending > commit is not going to be the final solution. IOW, > I am trying to argue that an important corollary to > the Linus regression rule is that we revert commits > that introduce regressions, especially when there > are no negative effects when reverting the offending > commit. Why are we not doing that in this case? > > 4. Can you explain why this patch series is superior > to the other proposed patches that are much more > simple and have been reported to fix the regression? > > 5. This approach seems way too aggressive for backporting > to the stable releases. Is that correct? Or, will the patches > be backported to the stable releases? I was told that > backports to the stable releases are needed to keep things > consistent across all the supported versions when I submitted > a patch to fix this regression that identified a specific five year > old commit that my proposed patch would fix. > > Remember, this is a regression that is really bothering > people now. For example, I am now in a position where > I cannot install the updates of the Linux kernel that Debian > pushes out to me without patching the kernel with my > own private build that has one of the known fixes that > have already been identified as ways to workaround this > regression while we wait for the full solution that will > hopefully come later. > > Chuck > > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > > reports and sometimes miss something important when writing mails like > > this. If that's the case here, don't hesitate to tell me in a public > > reply, it's in everyone's interest to set the public record straight. > > > > BTW, let me tell regzbot to monitor this thread: > > > > #regzbot ^backmonitor: > > https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > OK, the comments Boris made on the individual patches of this patch set answers most of my questions. Thx, Boris. Chuck From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:19:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:19:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370646.602502 (Exim 4.92) (envelope-from ) id 1oDn8I-00014s-PA; Tue, 19 Jul 2022 13:19:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370646.602502; Tue, 19 Jul 2022 13:19:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn8I-00014l-MV; Tue, 19 Jul 2022 13:19:26 +0000 Received: by outflank-mailman (input) for mailman id 370646; Tue, 19 Jul 2022 13:19:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDn8H-00014f-Fc for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:19:25 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50069.outbound.protection.outlook.com [40.107.5.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 681d7a71-0765-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 15:19:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3522.eurprd04.prod.outlook.com (2603:10a6:208:20::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 13:19:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 13:19:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 681d7a71-0765-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fTxuq/0TLlMgydkyuT+chdQf2ma4SuZAr6AEqSdEZt8LumzzjXrEsDfHfcycEftiPAtAt54l/V1AbcJfB9oTwcpavzyjjc12ttno07orPArgIsQKt4GsoY5B5WjGn9kDDzrIs49WphdnqBKBvg4uEHtrg0Kvk/h9c3Ii5LrShqINqX6Qdp+7MwkVvpN4MdCNo/08IPUfQEx2gJQoOg4xjztzRne/n9hWqbfI3iEkD9NgHUNbZyB3QMuDtrMcvcD1s+RKeNCvOliVs+IW2GHand5oHwXxmWf4iT2OIjap+RPzXZXdADBt+urnO2BPtXvhE4u/wVjc8/OWJ7/0gvNN6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kbaQLiU87Ncr/+dCFhJb1eHf05fRwFAZ1IPFbm+ULDk=; b=Khz/VnBSYTReMR/HqeWY900kWmDfV3typGeD1Vf6XyylaHjYY5kmF+6lnsNPaHaFX0YMgbRyd5FPPtpTceGjK8Qfr7nn1QBcnv7u5bHJb0ecaj5xhbmzzZ64HnlW4Kn1a++/fHpUe6Qsuipyeqy7G72fyIeKm/bu1w4/MmDfE9jCT7ikkP8ie/gJVafRwbVvxldPWXtIAKu/3EemZBxpF+VZZ32nXU4rswspZhDLm1cgHScwKarApxw/Z41ZfKoItJFvSTG2/RR+vRS7EL79T2DKQzr696AEvnOzkuxqWE/ehFLYQ8s8LCxAsszcRCH2ARbwBwc7PLXCFoWEIcPGtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kbaQLiU87Ncr/+dCFhJb1eHf05fRwFAZ1IPFbm+ULDk=; b=GU5WoMPrSLp0qlDQKiH81SuXj9fZ0co6NzqKfVLcBd7QwwOzfGWt5+sF3phT6qPHIPqJfmaPxn7bgl4Zr6LSl0esNcaouc5cK3rz1bCYXcDPgZMV9+dygRj4xePwMo1Z1ZdLPGfkhH+Uzdz8VNwI5mhF4f9q1y/NRD+Ld7f5rxYq7u2XdQyFs9eqytPgjlT3S7pkVymC1iq+8ONCgP4fUB8us6SuO6KPN/EmZNUIABVa/JTt3obFzjN5SgICJvNu2jOoy/HV8BHmyLgmItzh3TA4W61+Iw/Epk5TUS36EnkGowZgxnr+eLWJhmvJEye4KorsI524Mm+NzBgiAYHAPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 19 Jul 2022 15:19:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 03/18] x86: adopt new boot info structures Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Daniel De Graaf , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-4-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-4-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc456d51-89be-4db5-0886-08da69894b67 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3522:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vNq5RyRXB30RYE3e48YQJ4VsGkHLPHpMy+SEXcmuou7cueJIg3ochm1d/U+JpbGfcnAq7QoCDUsb/gJDn1hnVWo6OdVk3PwFimOpR633QKiJUcbI2jZFLSj1WWZ8n8lipbHXmkJiQ93C9mWOMIdGHp0C6Vl8TvrvqAiQVV2nRQK6YNmL0wFBDVAjBMxyJPW2or8R5psnLctcyhSxvBnHMJ1m84XPyV25bfKRuKqjbeKS6lcbToBdLMwoaRqiq2Ur4H3YTdejE+u5J/O6CwNS+cz4q6rXpFJrFQhw3sPBcl3joGRWP3g70BW7gsHAtU8TRUOQLBha5DlryuaxWrOq4g5gqUHedsCEFcqS/n9Ie1utYgW0otNb8+pAQ3ODstr0k6v95LzyTFJosJDoeqLSDGYogrho9SwgrVLMKExk8HcCXKJgIpsrfX1DRyOBpt76FJ+eyLnf+YiCQ4ha3vB9+aq3TCOB0imuZGHYOG5/g2kbP0PaTa1RXPk5wLFPybj1FihtpVmFaU1yIBxz0mRdm3I2Lg1vsLKCftzGmm8pbM/aQ2x8ScfA4EinY69rQGSsFuqfIi2J5JIxYFFnpqLiQJE58ki2nCkGk2Ninp2DYWcq3ZGOm4slBGk+cDQbZATmv7eMP3nGCAwAC/XLr6ofSt+TNwLfL5pP1alvkiORc1SrYDHj+RhOPOq7ChrJjrHPGcgtb95vEHf66kThmQrHULuZEvcLvIvANUg7PL3bJd23JZrXxItnr2zthL13AFJa+bJiTSbgetMpxEkNLAH+665XZjS98vtVyzdnhL8fVnXiEJ1OAImrzVKHQ1xwbOMc2G6A/DmQ6Db0k9k7rtYcAw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(346002)(136003)(376002)(2616005)(83380400001)(7416002)(41300700001)(186003)(31686004)(6512007)(26005)(5660300002)(2906002)(6486002)(478600001)(31696002)(38100700002)(86362001)(66946007)(66556008)(8676002)(8936002)(4326008)(316002)(54906003)(53546011)(6916009)(36756003)(6506007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWpMSXJsSDFMRlhOT2J5OEE5UU5hZFFhTU5JNXdTb0ZLdzRTNHh6TEhJSzlV?= =?utf-8?B?N1doTHNyTk1MWWx2SlVPQ1JLRmpFQmpTKzBNWVlSUUErMmJ0V0lBTVh1cEpZ?= =?utf-8?B?b0VTN3B0MXlOenptdUdHOTZzOFVBMnUySlZLYzRTSkF3VFRFSzM1aTl2Ynl4?= =?utf-8?B?Y0JOYXV2VkdxSDRPZ3hXSkJyUkZkdEhVNk9iVGRPTGxZbk42c2VHa3g4a2JJ?= =?utf-8?B?MDZIaFJLVVM3emV2R2JCbXFZUGsxTjAybDQwNnZWYlNHMkRSeE5oZ2duTGpM?= =?utf-8?B?RWJjVmZuYUFPNnA3RU9GSTljUlNJa1BqR1RkSlV6Z2htbWdHZUdWR3NFN2V5?= =?utf-8?B?S2RxQVJZclVXY1BIY1BWcUowTXNnL00wWWswMHh5bjBXUE8zQitQYUN6QmNx?= =?utf-8?B?RlFCNGhrMDJyKzMvbVRScGpNT1FRdUFCUlNoR3JTK0ZpNjV6WFZZRk4rWXBx?= =?utf-8?B?WEtQQk45ZFJCdlF4bkpSLzVkN0JaamMxendXSiswNVlvR1BzODd0MFRWMEkz?= =?utf-8?B?WTNlWWxXanJ0NFlIYjAvUlZVeFBKQ1dPUVVBZkUwWVZzOGF2c1R0MHlTVUlu?= =?utf-8?B?aHhSemQ3MU8vUUZiRTIrRWpiVGdzTDhUaFF5M0MwSE56NURYbGxodkZyby8r?= =?utf-8?B?OTBjUnM4angxS3VNL1dMLzRFT0VRMHM0VWFmWWpuL0tyT2Z0bzFYV1I4a1ZY?= =?utf-8?B?dkVoSlFaZ0E5S0EySSt3UVVpY2NLbGRNbnpqNVhqWGFiZGRPV2dMR2J0ZFM0?= =?utf-8?B?VXAzY3drbFQwWnhMejRlVzAyZS9RcVVRNnZnbXJjOERPc0xMcDh1TkwwQ1Fm?= =?utf-8?B?SFIzUUhKNkVWaUs2N0xSK2xRVmVSaWJGbGtjdGh1Y2pha1BDWGR0RlFMRlds?= =?utf-8?B?QmhCS29lTlltN2tBQ1JUT1Z2UUQ5eVZ6SXdQZFpyNVdPU2xGWjg0bFJnYWxi?= =?utf-8?B?VUlpSTNNV3ZWQnQzRmUrZjVJWHI1UklVcXhVbGU0NWVoVjQxcE9QMlNUd2dY?= =?utf-8?B?SkRyVitFQ1YzT0g0OUdUQ1NpNkNLNld4eUVaaXlWM2RON3E2UG5aczU1NUpI?= =?utf-8?B?a1F2RXhkN1h0cFhMZzdTK2Q5K2d4bDFVSit0NHhDYUMrY3pCWDdtbVN2RFZu?= =?utf-8?B?a1VYZlpTbDh3a3NoZzRFNGNVeEM0TjNMR3FkaEtkMVg3eEFBQzdZWWluOE9w?= =?utf-8?B?MmErSHd2aE1QMTdjVUtoaWFsTFlTZXIyT1cwc2pkNFZlbStFVWJxMkpITHI3?= =?utf-8?B?bHRDeldCNHdnUnAzUTFZbUtRT2VrdjJtVTNEUFhUd085QWtJbEtoMlViZWR1?= =?utf-8?B?cjN0c0RXak9qamNnQTJyY3ZadE9TSWRSaUVzSlNsNjJDT2hDMGYvcmtxZjFM?= =?utf-8?B?ZTBrdEp1KzdEVGVUam45QUdDM0hETzZra0tsWmVLbkxEN2ROL3ZiRHM2c0Ji?= =?utf-8?B?T0ZrMHZSRUphN0t2c1VPRmlsZUplMllMUlVpbXpFaUxnSTQ1NXdkemJwQUhU?= =?utf-8?B?S0xKUlJvci9rWDd0dUNEb0VuaUV0MDZ3MndWYXMrWG1HRDI3VXIxanYrR1ps?= =?utf-8?B?SVRub3ZwZzFSY1UwVHFEdnJoY253K3BpQjhnT3hOQW5na3pZakdVNzhUY3lO?= =?utf-8?B?eHd3NWZPR2dHdlZWak1tOGdSQXgvK0lONjFoWisrWE9haVJYNXJFSE1TVU9H?= =?utf-8?B?dWtpdGxuV1BHSG1oM3FuQUdaZjREWmxJMkk0OXEyS1RseGQwaVNzMWdLMGdi?= =?utf-8?B?Unl2TWl5RVBNdTdGYzNwdUpxN0l6aUpYdTlieHFrcjVBSWdOYkltZmhEakor?= =?utf-8?B?aDJVOVRZQjRlRlRDbEhvczFaZmYwSnM0N1NKdjQ4VkIwdnBsdGgyRHRGeGpw?= =?utf-8?B?UWdhcStoRGNzanFaT0RMdXpXN3VoUnVzNC9POS9MSXIyUFlLS1ZTbUtOZ3Aw?= =?utf-8?B?NlBpVEEyUjR0STJPUmhwZ2ozSGE3VTZvZUtyanlpWDEzUWhwdzg2TEhLRitr?= =?utf-8?B?Vkd2eDFqbFZIb2pQSWk3WnR6ejh1Mlo1ZHdHaXpTbGZtUmR1SlVEWWNkdmsy?= =?utf-8?B?MFJhVDJOSzlUYjlNS0JaUGYreHJtZHRRRUVUU0tsZXZucVQycFZqUVpvVC82?= =?utf-8?Q?0GM36ny6CAImVshfwf9UZBloI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc456d51-89be-4db5-0886-08da69894b67 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 13:19:22.3763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dksFKyUX5H4cFFURzAvgfV7Ht6Z3UqYD6yo4ytiQtoWA5Cq1AdhUw6HQOOzFUbIrK7QGKJXc2GRZebyJSmm7nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3522 On 06.07.2022 23:04, Daniel P. Smith wrote: > This commit replaces the use of the multiboot v1 structures starting > at __start_xen(). The majority of this commit is converting the fields > being accessed for the startup calculations. While adapting the ucode > boot module location logic, this code was refactored to reduce some > of the unnecessary complexity. Things like this or ... > --- a/xen/arch/x86/bzimage.c > +++ b/xen/arch/x86/bzimage.c > @@ -69,10 +69,8 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) > return 1; > } > > -static unsigned long __initdata orig_image_len; > - > -unsigned long __init bzimage_headroom(void *image_start, > - unsigned long image_length) > +unsigned long __init bzimage_headroom( > + void *image_start, unsigned long image_length) > { > struct setup_header *hdr = (struct setup_header *)image_start; > int err; > @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, > if ( elf_is_elfbinary(image_start, image_length) ) > return 0; > > - orig_image_len = image_length; > headroom = output_length(image_start, image_length); > if (gzip_check(image_start, image_length)) > { > @@ -104,12 +101,15 @@ unsigned long __init bzimage_headroom(void *image_start, > return headroom; > } > > -int __init bzimage_parse(void *image_base, void **image_start, > - unsigned long *image_len) > +int __init bzimage_parse( > + void *image_base, void **image_start, unsigned int headroom, > + unsigned long *image_len) > { > struct setup_header *hdr = (struct setup_header *)(*image_start); > int err = bzimage_check(hdr, *image_len); > - unsigned long output_len; > + unsigned long output_len, orig_image_len; > + > + orig_image_len = *image_len - headroom; > > if ( err < 0 ) > return err; > @@ -125,7 +125,7 @@ int __init bzimage_parse(void *image_base, void **image_start, > > BUG_ON(!(image_base < *image_start)); > > - output_len = output_length(*image_start, orig_image_len); > + output_len = output_length(*image_start, *image_len); > > if ( (err = perform_gunzip(image_base, *image_start, orig_image_len)) > 0 ) > err = decompress(*image_start, orig_image_len, image_base); ... whatever the deal is here want factoring out. Also you want to avoid making formatting changes (like in the function headers here) in an already large patch, when you don't otherwise touch the functions. I'm not even convinced the formatting changes are desirable here, so I'd like to ask that even on code you do touch for other reasons you do so only if the existing layout ends up really awkward. I have not looked in any further detail at this patch, sorry. Together with my comment on the earlier patch I conclude that it might be best if you moved things to the new representation field by field (or set of related fields), introducing the new fields in the abstraction struct as they are being made use of. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:26:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:26:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370653.602513 (Exim 4.92) (envelope-from ) id 1oDnEp-0002Wf-HT; Tue, 19 Jul 2022 13:26:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370653.602513; Tue, 19 Jul 2022 13:26:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDnEp-0002WY-Du; Tue, 19 Jul 2022 13:26:11 +0000 Received: by outflank-mailman (input) for mailman id 370653; Tue, 19 Jul 2022 13:26:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDnEn-0002WS-Al for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:26:09 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50085.outbound.protection.outlook.com [40.107.5.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 58984a6c-0766-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 15:26:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8703.eurprd04.prod.outlook.com (2603:10a6:102:21e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 13:26:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 13:26:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58984a6c-0766-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YxHLJI5p02RgEhRbeS8hKbu42u6njeyo/N8Muz02p6myhfzjMMFr2U7BYx0ZuGojGKM2IpnlpSVyN/Pn/oBcBpVCxWFDJLU3JgHfpxH7sFDUXu8W2q4sQxSnmt8/ouPt8hCV47zSZ3wpqzHGfL8rOZq79xQ4WQKAqDqJ4nnrwuuZJVKLxwuhvR0eSheFz5vV1sZ1OmqZ2lv2PAyp3B/AD4rXF2sX93kh5dg4YryDN6/QBSabGFP/P4DpU5NBrPKkK1go8GOIsQg/Ebus8lN8to0VOmzx0VGUFVRQpjKOY8rVAwJBb/LY+oQhxruHtB5rAOmmXHBTPLjS2RCIg4OzzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=++1L7owZW5MTQlMNcXjYhazYBSWrdakj9jpM3QNOotc=; b=Qvgjm51Fo2epIAtyhyfXUKAcbUNvFdJGvKObIsqu7FYc37jTMydjK5/Y5r8S//0dNwp64ZzSxqsPRqh4LcpiOcaHvFYvcgAFl4/GTckh51EXhUFccO27I+GWP8uWXWecrzdEcVVxB2Y6PIQ0tF50HdsemNhjrcFeXTsXHcPuWPFZAGOo6xTp5EwS1YhJ344JtmQQpqUEWWLvx/RYUtcQBAYnci21uOszIExq730DTkxDCVRavs5Kl/8Fiv2aZQBIvev+PAnOc+x9vuKiQt/DRZxlwS+rrlzrZ3qio4sp2/b510LLS4nrAQI/HXwb/IdEdyyAP2rychycrZRnt3yZHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=++1L7owZW5MTQlMNcXjYhazYBSWrdakj9jpM3QNOotc=; b=plpn30I33YjTwMK4i/a3JInCC2Tcmwvy+Vq4HwcSr1fkyBDwA6QbzP5fsle8pnXdNrmmi+TVd8ArEBtq1nE9J+TpdJeVWGlhgfhyIuwK9NI0IwetWMi0X7zqKNiLlpL5/IIVwUPmncTxSX0NCaRSkIgRT1xSueFs3RpNK796A+qbAAb0BUa1cYIJujlceZ8Amr/wXejLiyLsFqe7AOhMI3Mpozh2BIY8gLe6GMDjt4V5i56VklbB0s1Khxby19ZItUoQPExVhQ3WepECHjCZ8QXcfq0OHhiCvzcyX/0Jgm5pG9M2ZMoThcIU2IwogABucvfkNoO7+t/ffUef70oJSw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <681d9e71-f618-ff33-59c4-bc7f793d45c7@suse.com> Date: Tue, 19 Jul 2022 15:26:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 05/18] x86: refactor xen cmdline into general framework Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-6-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-6-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0122.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f3dc7bca-776b-41b6-eb52-08da698a3b90 X-MS-TrafficTypeDiagnostic: PAXPR04MB8703:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OCvw2MxdI/GyYUhkblePwLqa8xTRpPWOF0KZjvJvo1na2Su4esOyOY5fbifylJj9bJrvjICQfQ5XBE+Fh5ir3f/ha3hzAmaWypwkSPsnc0jvQKe5eCDJj1BYbQLnJg23H3Uav1fs3lZlBqMlRaamgRLaWiT0KdhBs8xdRb4vprCYjMesFotBl/hVJv1BFqfGjvYr/MIEf48SonbGyThM0o4/wLW/yrCUtbByQXkfyENQvZhPoWjL6Eg9/9laPKYbb245N7Nl3vjMWn1eKoOLlppyTPJjGyycXGIdDqqdD0RfyjcL0sbvihA4c1Fjws2L9dTkSB6OFGNCrxEriFIdHLQMmhaJvPDUKDuBd7F39kZs8dDsip3Ku0tI3EltcPwUL74qcXaSRYxCWvF4aOHmYnOi7Mc5UAMp0ccEaGAiKZ++u2mhUPrt3oN0JGNLC3cqnOFLnmDf78TC4kMNDJtZGbv5SorbNP/keNkI64aY0d8Qk9xO/MpsmD69pxx5hxtljn85lGSe75lrQquWtT1DyAw6lJTwZktFHn3LZENO2osE56NuJyLVCuPIfeoVc+mg0AhLGv6wdd+AYPgtE0kp9yZ26AokcN7bZ6F44rvHfT/aSxlzCl3jcRgGuZ03zOWNj0G3lmTJ8UjbnJiE/rPyrfSjHIcP4qDBVNqZkNcWtDJQoxOF4uh7R+u479xsvhCVKuCrnXxTTgGfN11Kf54YJzRfDD7w1Lxb0exRLD3kl4LXXtvrsVcaDNLN7P5aXVV1bM5YrZ+dyrlKN3JJLD/lXEaQUWXNAW1cryOR+2BxGy+t0Umeyyc+yMXqLCe43jvY21CGAVtmw0iWyyX5t001cw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(376002)(346002)(39860400002)(396003)(83380400001)(6512007)(478600001)(53546011)(6486002)(2616005)(31686004)(6506007)(6916009)(36756003)(316002)(38100700002)(186003)(66946007)(54906003)(66556008)(4326008)(86362001)(8936002)(4744005)(7416002)(5660300002)(66476007)(41300700001)(8676002)(2906002)(31696002)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHNDS2Z0bUFIUmQyMVNURHJTOGx0VllwMkFvVC85WVVnenRTaWVFOEMzNm1Z?= =?utf-8?B?QmJVcVJWRmdaQUZLbVpYSkMvVWExZ2w4M1hUY0xEMzJYYklpZTUyMVJSbU9G?= =?utf-8?B?STNnRGxrTkVvUGt4ckpCUU1kTFk4NnVlcnZFUEc5aWwxQVhKc0lHcGtJaXJ0?= =?utf-8?B?S1R2Kzg4TnFZa0RSd2R5MFU0UkRhL1FJeE9CWHprRzlaelpranNCczh4RDRF?= =?utf-8?B?ak5rbGhEdTVVekkwMkFzZWR2c1NDeHhTTFovbHpabUs2bGZLaHQxQW40MTZr?= =?utf-8?B?Ny9mdG4vSFY3b2lQRy9jM2xvN2xSK0laOGxDbHN6VVhaWnJaTzh1eUtFakZa?= =?utf-8?B?NmlGK1N1TGxzOGlsNVJXMS83S3E0ZlVmTmlyZk4wYXJhTFhNQmV1RHQ4T3Vm?= =?utf-8?B?SWEzejVQRmk0Q0ZMaG5aUWhJOXh4cXRwYjVDU0JKR09zOEEyaTdQTW1kMmVs?= =?utf-8?B?YXgxdFBtSUVvQnRuTzBFU21aM0FPblc1RG1NVFRxSWYxMFRlUVFCWU50cmI1?= =?utf-8?B?QkNmY2NpbnRBOXJld2Y0OThTdGNXc0dDeXRhYk9FMlUrb1FtSVpVUWVwV3lC?= =?utf-8?B?SU1xQ3hDcTJxSXV0VnBGeE5qVG82SlluN09RVGpwWnpRcWFZWWJ0MnVLZjdZ?= =?utf-8?B?WjlNYjVMdlcvekZlbTlJSjJzR0FxdThacWF3OFVISFNLYUFUZURRZVlNOFJv?= =?utf-8?B?SGUvKzVIMWRDMGxVejNnUzJscmJlWEFaUGZxaTM2WWlHT2pnWEN6bXN2OUkw?= =?utf-8?B?dzRTWTlZYUdOZEQreTNmVTRueThmM2dzZ2ZhYlpIR3RzanJ1a3ByemlvRFZ3?= =?utf-8?B?OHBLMjRkOWlLRlFucEV5ZnhxY200cmdUamdoamZUR2YxV2JOZzhqVDFtRnFQ?= =?utf-8?B?RVVPTnhLOHlJVXpiTERTUFhRQ1dHQWEvVFM2cm1SZjlzVXRVWFBhbWdTRGdG?= =?utf-8?B?dTVmRTBkWHpKY3FiV1p3MUwxOFNXMlFuRzNvcTZKcm9NekhTTCtGWm5Ldncz?= =?utf-8?B?dUtUaFRNWE9CRzVEY29KbkR5d09GaUhHcW9vTXRjRXhwS2xPb3pMcTNQTjBD?= =?utf-8?B?U1YySDlDeXQ5WEwxZDJrYmNuckdoenV0amNvdFJSWEpPclFMd1BQQWJFRlJN?= =?utf-8?B?WEVmQlQ0MTBYckpqZUFpWTkyT1Y3WnZkOXJMSmZhY0diclBySHVPYW5NRUFZ?= =?utf-8?B?MjlId2pyd2JPcTBLR0I0QjlIUVRObTJUT0g5VWJuaTBqcmphWG13aHRtTXI1?= =?utf-8?B?ZnM5bTRPZVRDQkpmc3hLaWx2SklyV1pWQVQraHhIOEJjWHN6Z1FKeGdxc3dx?= =?utf-8?B?SFNRQnVVT3pTVGJoWCtsd09KakkyeUJTSEZ4RDRUSTJwQUlEU1JGUnJnR1pT?= =?utf-8?B?Mi9jVytxb1RJamp0aE5LTzJRR25oVTZFTkYvdVpiU2NVN1pIdWdPdHpybjls?= =?utf-8?B?SG85Q0MyQmhxMXlDVWRGVVhxbFF6cjNvTHJxdjRpQkdYTldkOVVweWQ1NjFy?= =?utf-8?B?OGs5ak92WmdoMUo2eVR4UlJsdmVZODIyTGU4MVFxR1VjREFEWGxQUmlaNjB3?= =?utf-8?B?c1FvaittWEVpcTF5elBCUTZFQnZMY3JZZldPM29qaCtXcTlROHRYRDBUVEZP?= =?utf-8?B?UTgxV0prNFQ3WWI5VE9XazBXSkRuL2lCU1kxM3FQSXA2bnNsQlg2MHd0QW1l?= =?utf-8?B?TUVvTHFHUk50bEFaTWRCbjRTRTF4NlBjdEsrTDZVajdscG5TRzNpSkErTmxm?= =?utf-8?B?Zk02dHhtKzNZV2VCK0QyVnBWWFg1VVlnWkRGQ05IM2lMR0Z0WXkwUjhpY0pu?= =?utf-8?B?NDVhY2Yvb09HSHZ3a1kwaXd6MXhXQk1wN1ZCVWZuNVZyejBTWVI2U1ZhU0lX?= =?utf-8?B?QW12NGlCbUdWODN6S3hjU3hpb3YxTzgyZTc4MnhYWlJHK1p2Tnc0bHhqdERH?= =?utf-8?B?L1RlUnRnUXlNS2FoOC9hZW1iN0t3TWh0TFI4b0k0SjhtWFNVUjg1czJJbUI0?= =?utf-8?B?Um0vc3ZkN3RWMlRsaGFvNUEvdkY0UjBRaEpGa21PMmN3UEJHd243bTFtRmpJ?= =?utf-8?B?Z1Q3MVpjU3R1dHNTbURiQS9xeU44UnJKUkxaV1g5Z1MydVRyU1hVSkY1YmEv?= =?utf-8?Q?faDgQefSchYFluP0Rdgwuw9Ew?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3dc7bca-776b-41b6-eb52-08da698a3b90 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 13:26:05.3040 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MoUUI2nflpnI7CPyfXGmSnblI06/fMr5ePjzTGxcH1Bm84YmypNnT3aTfmiysrVyBhhs1lNSs0TwwtN9LpiSSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8703 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/include/xen/bootinfo.h > +++ b/xen/include/xen/bootinfo.h > @@ -53,6 +53,17 @@ struct __packed boot_info { > > extern struct boot_info *boot_info; > > +static inline char *bootinfo_prepare_cmdline(struct boot_info *bi) > +{ > + bi->cmdline = arch_bootinfo_prepare_cmdline(bi->cmdline, bi->arch); > + > + if ( *bi->cmdline == ' ' ) > + printk(XENLOG_WARNING "%s: leading whitespace left on cmdline\n", > + __func__); Just a remark and a question on this one: I don't view the use of __func__ here (and in fact in many other cases as well) as very useful. And why do we need such a warning all of the sudden in the first place? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:29:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:29:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370659.602523 (Exim 4.92) (envelope-from ) id 1oDnHx-0003KG-VJ; Tue, 19 Jul 2022 13:29:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370659.602523; Tue, 19 Jul 2022 13:29:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDnHx-0003K9-Sg; Tue, 19 Jul 2022 13:29:25 +0000 Received: by outflank-mailman (input) for mailman id 370659; Tue, 19 Jul 2022 13:29:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDnHw-0003Jz-TM for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:29:24 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50074.outbound.protection.outlook.com [40.107.5.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cda395bf-0766-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 15:29:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8703.eurprd04.prod.outlook.com (2603:10a6:102:21e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 13:29:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 13:29:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cda395bf-0766-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PH9FdB8I2D7Cp1zuz7nL1aGjgDpoU3Xo4h5QvD5cKudW5NGNOl0aF4IXbKTWOWSdpeQiCZ1t2cwGkonHc4uZAPKa0ajUipMXc7tyMnMhyuNNEBvQX1O49JGc641QQxbc7zv2pkO3wg1NxbhkRsfFiVCMmwfOO4sK18EOtQP8sBz0y8sxg1xj2r6SgMZmD+4CHmoLRvzW6k4qMSUqkWTTNVJ4fqStlrStRz5kBrObJEydp6jgEh4VgBpjCLl/D21R6qxvefP55qnZl+VuxER2cDK8Eh1yB74gGxtyxtsbpqtnBuZEX1j+lh9u6QyPX5B5S66CqSSFrjByX7wk0ScGrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kZUWv5XNoaEhV7qQbV6cd/MFWBtiZID9AfeU/P84akY=; b=OuhliyyqAq2ouohx7AsCGtb8/Q1EDo82jLF7hC+e+KG9NcrGQsfGKZSve1qGOnJ4KkxdVcB6OHjg5I8eexAb6LesBUeLgLplFCCnqVBwKXSGPJMQu79evp/3TxRMpq0IaZjo96HKGdeXJVJ+JeghA2bDdHn3U0i16VBfc2eO6OrSwLz4kRr9AJZlqxmLWW/NITHveWnMT7TjQnBgEubWKRHi/2P8PyAlJWajHTXpbsYteAS1ydNDt5tPjx3PShRLkJYqL0cYCcRdKfnpD3ND4h6gWiI0X9SkovoJCjRHGZifd9Mr5WUZOWo1rIiSe47TctSUThRPcFG8UwQCA1+ceQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kZUWv5XNoaEhV7qQbV6cd/MFWBtiZID9AfeU/P84akY=; b=zxVWVTijE9+dUwGkOyZlQ6tmS+Ju0kjnpIOkPnCWDJHuZNQPMEVJPKgsP0Rjla0SNo1WK+cj4Ix/5AtgYiUqWlWCEdERGP0d2cUY0xNCbZpdRYgYMmGyCZmnfYUreAI9DXyTuFeZjhj7kLKn3aExTS/xnOa0m8s1Ofg4+6gyP5Ue8RIjXF+pEkUiSN3FDSLQZabo60aBkmsjb1XdGLiuPD1wxJCNQikLUFeTa8MfXfrnct1fXWiL5ELytpxtMSwctcpDuNrsWAxA75WhM0zHbwwtyotRAHEfp3gKJzmYmDdDFpVUw1lneTIOdJLLe19djznITMW+GzgB0mjbjRzFqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <86f73a8a-5433-03c2-71fd-ee6a5abbe550@suse.com> Date: Tue, 19 Jul 2022 15:29:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 08/18] kconfig: introduce domain builder config option Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-9-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-9-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P195CA0032.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::45) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8215bcf6-5d86-4459-5e8d-08da698ab123 X-MS-TrafficTypeDiagnostic: PAXPR04MB8703:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RnMLvBkgwitSjhf65gx0mcV8JUTYB5iOmR1yFZd21ntoYO40zsN2bJVUD0an3/hcozxiyW/zRKw/iKr8EjOQpkImVq2luDu22E4Jo2DJuQljGwnWfUusBao9vQwSk88wjs6cDJjyKtrGr+6o1lxHEBQkq16Yf22nU7R/CML+m8NuSTpTrUvVLfP4DHGggj/YZx1I8Oh5mcmfnVHilmZYZ2742xujJnOI5oySK0tP59cFBBwxFfgMBNd/eAy7/lQrnCF0WcDh7VS1Q/hpd6RJ6mMGJn5o8TbjYxVWTX0+yd26ltdKOchc44i2WN7/uBc56KTUI0rJM7eucTwTJlCUg6HVpABzvfADA9rvotBDQSXub0eJAXzzmmPLMJeU/MEWzJAX36VRk32uMGBkk1ChODB2NWX2StHpfOGhZKMSpUfnEJqVeiZBowAO5cmeEPSflEEqdFMrvDkI/8cByM4kx6FQSAFgEHSovBmbC2WVb7/lkt0HowJdO+YrorKgrChK16C21ToipETMzeunFYGG24RdVQ0mik3Utu9sfFOfwDcdPcVPLjlTSBXJhbYbE/912nfTYtOaxKPn7jWeOJCwehBCBiNXPwRwhoqbzrmbKTDfLzaizUhMrZ179/pNUeCQSUWSJoP1+YiwGHET/zf5Sgv9/5p+9sP2CI6Ujxb8XQAg2g0sNbEF48vf0LjouUlDJHQWO63AOeK85JziEGL2vPBw8J7yFO98yUXE8aB3DoqNZF2SzZ1G2oq8Oou/0D4Se1A0/54SejP3/lQLzPhCcMTymyaoz0dd4AHtfrVnGWJrKQJZ7SZtRIzZAx8HVeDRD92XLIO0h4YHkdnbBTVRXA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(376002)(39860400002)(366004)(136003)(66556008)(4326008)(8936002)(86362001)(4744005)(66476007)(5660300002)(41300700001)(54906003)(66946007)(2906002)(8676002)(26005)(31696002)(53546011)(6486002)(6512007)(478600001)(36756003)(38100700002)(186003)(316002)(2616005)(6916009)(6506007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmxwY2tySXI5eklUcklKSHdZQzd5QUdmN0pIZ2hxbFVTeDl5T1ZkeUFLeHJM?= =?utf-8?B?ZldhblJlV2tTVjNub1VVVEFSZVAyK0xXUTJnVUZkMjF5MFRpL3JUdEorOFF1?= =?utf-8?B?UGNKVnZ3M3BFZlNzRE82T0h6RFViaXJwK3dKbVNyTllidmdJMENaMFBrbzYr?= =?utf-8?B?TkdEQ2p1K3NER2RUcktFZ1l3bVhnY3MwUXVGVC9aeEx1ZElycmxZZ2NUK0w0?= =?utf-8?B?NEczTU9Xbzh6K3piY0w5Q0huZkRyeUhFZUd1Y21Qd2NjY1NSR2dtckFuTUxX?= =?utf-8?B?aTdPSTRJTXlsYzFpZUpSUExoMmlmY2tOM1B1QzIzeE5ZRm1HSUhtQW9LbmlK?= =?utf-8?B?SHNJeGlxZzJjUk0vOTJrSzFoVVUxdzBaUDYza3ZVdTRKWk5JbGxNTktWcWdK?= =?utf-8?B?eWs0MjZBOWlZbmlVOWxISU95YzNKTExRMWwyZ25rQnpLRmI0TWd1eXZoWnB1?= =?utf-8?B?aUNLRmNRZWEza29aaHJldnFTTGJQUEFxU1N1b3l2WC9LZFdjaGlEdTZMb1FP?= =?utf-8?B?aGRXMlJHTWdNdWNlNUFMQWFtb2NOV1hIZWpkQVFsd2FQV29HUnVWU1lXTCtN?= =?utf-8?B?c2xocmo3UUg1MDFQRWVnenNvNFlwOVRXV1lNeHYwZlo2TkgzL3J3SmJvOEZ4?= =?utf-8?B?d29WVHdCYlRCQkllek53RE02L3ZhZTBOOWo3b3lRdFhpYmhhdm1JMFZwVjJs?= =?utf-8?B?bzVPaG5WNE9lR0JNNk5WZ3k3NWFSWTdGV1UzSldBV0U3SWRNMEUwVjNPaDFp?= =?utf-8?B?c2JBQTIzbC8xQkhiUjUzWWZabDFxcWMzQ0N3bm9ZOTB5ei80citMR21wUnZX?= =?utf-8?B?RmtRak1jejVDL1FhVDJ1bW9XNFI3cm5GdGFVRWl5a0pHQ05ja2ZzTE8ybWVh?= =?utf-8?B?U0Y4c1ZoSCt4amlaLzRGRlpIS2dMV3BSMGswb1Qrc20zMGtJZTR3MUtrSytP?= =?utf-8?B?NTlFajBXUVBZeTRXTytVZzVGNUpTR2JNOVhYSWErR0V2MTZJTk1yMHNBZENT?= =?utf-8?B?OUg2YUlpRnR6MkZ3SU1uUVhoeTNwb0Y5L2xJMlZmYXd2S0ZwcW1TTThSTGNz?= =?utf-8?B?UmJKaTFEOXlIN1RYR01sN1dlNWhKdldsT0RKOTBBazF4NEU5WnVGTXVualdO?= =?utf-8?B?S2drbWxxZVkrNVQyaS96QnoycE5hT1JYL0tMSnltWTE0eEZPbDR3SGNoYWVk?= =?utf-8?B?cTYrdEFHdG9KNDkvbWZJdUZpZ21OMmNYZlRBQWExdkZlejVHUzYzWGw4NzZi?= =?utf-8?B?eWxzaEh3Wm5maEdqdmdQaVpYRStHZ2JiUVZQR2VKRnZRZG5RdXhtdEp0TlVt?= =?utf-8?B?RklZLzU1REZRU0dMY0M4cHhkYzFCVXlUYkU0eUUvcTJjNEZqM3pacWhqM0Fr?= =?utf-8?B?OW15blBscTdYeGFjMkgrN1NkL2ExYmRnTHE0c1F6VnluTEh2MGNNSFVlZmxJ?= =?utf-8?B?V0RoMU94UTdtRHFlTHYrSzBNZDhleW9hK3BCSlJ1WnROYmZibmFKM2hZaEFB?= =?utf-8?B?cElPekV5SGk0bVYvdkdhQVlTZ05ONXdkSVBVRlRacFJZaWtQYWp2NmwyZm1w?= =?utf-8?B?TVdHTTQwTEJDakJGT2lQMXZrOEk0NmlENE1WS29SYUx1b2dvVVkwZXpqWFZa?= =?utf-8?B?WXdMd3Q0VjdCOFlyYVIwQmFSTjVxUFpGUDdlZHRYZUttQkNkcHcwYzhKWGdt?= =?utf-8?B?ckJMc1dmaHBwSEpZRVYybU5CNVhCbGxWSk9BZFNjRFVyOVRqSy8vQ0lvZUJN?= =?utf-8?B?Kzc5N2NYcnVITENVNjB6T0FvNFl0KzdlVWhFbER6blgwZ2JCT1VjcEd2eHNP?= =?utf-8?B?aGdmbXhWTFYvd01nM3VWSndzVXpBWjh5NXc2UzJTRVFDdFJKRDFNRkZqVFNY?= =?utf-8?B?Rjh5YWNlU2RBSUVMaXljZFpZWlN2eWJrVEFudUY2WTNNNnlFWkJaczA4ajlv?= =?utf-8?B?V3JHVmJxYURHdkJQL2Y1bnk3UGJVVG1ra2FVUlRYV1FtdmFhUGNkUDlXMmtU?= =?utf-8?B?eHNUd2grRHpZakZrQjBZK2d4R0Jjak9Qbmh1aXA4MXVETVVaR2F2TzlvU1JX?= =?utf-8?B?V2VKQklSMTFvMXZHRjk2VnpoWkliWFl6QkdUYlNBU2ptVUM2T1RMYTdDa1pG?= =?utf-8?Q?klNuo8IKaJ7wxa1stMzZdO6iP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8215bcf6-5d86-4459-5e8d-08da698ab123 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 13:29:22.5572 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SKs5V3sUAAkck9uSr2VvK34LIcFNFEx981o+dtjzHsd1CYckQ0Ck7dDJsrw6B9MpPy2ip5KbQCa8j6DNy5Ebvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8703 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/common/domain-builder/Kconfig > @@ -0,0 +1,15 @@ > + > +menu "Domain Builder Features" > + > +config BUILDER_FDT > + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED > + select CORE_DEVICE_TREE > + ---help--- Nit: No new ---help--- please anymore. > + Enables the ability to configure the domain builder using a > + flattened device tree. Is this about both Dom0 and DomU? Especially if not, this wants making explicit. But perhaps even if so it wants saying, for the avoidance of doubt. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 19 13:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 13:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370671.602542 (Exim 4.92) (envelope-from ) id 1oDneV-000729-1Q; Tue, 19 Jul 2022 13:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370671.602542; Tue, 19 Jul 2022 13:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDneU-000722-V6; Tue, 19 Jul 2022 13:52:42 +0000 Received: by outflank-mailman (input) for mailman id 370671; Tue, 19 Jul 2022 13:52:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDneU-00071w-1P for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 13:52:42 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0cf6cfab-076a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 15:52:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cf6cfab-076a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658238760; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=bOUbCRR6SPQ2sJ3KVcPFWoF4FEptXHJbHSvMvPXSqPQ=; b=Drl/+gpWQU1OLO9bqEQ4bzlgbMdJfjSTJzQH4RaKsNr4OfjkkaNvXU33 8bJK0NA2lzSwAlymMPYMthoHz58GnLw5W+DU9K/BGBuvdzecLDUPamB5f eyNG9skpia3XK3UqLFITrNKtUl4iCLiKRQhmLGLIfTAVhu5vC9ED50mPM 8=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76130499 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AdvG13K49xGeimmDQkCB8dQxR2vbMJTbqsCcv2?= =?us-ascii?q?wbIaF9S3hjvzP5pOkMGou+yHqcojJg0JnUAMVnC6nwTu7BG8UzxHHWiaGJDa?= =?us-ascii?q?Swnr9Uym3nBj85Uzni5rPURZfFrFRw2dixgtuKJuzph4reJp3z+twdcAJpWt?= =?us-ascii?q?ZyXURnV2TwocisxEQBeLuRHZvQsI4FMpYMflsKRNch24Xr66Swl9Y6xynERz?= =?us-ascii?q?vGHrV3teUnddcJDi0yllHrPsGU/KHzYyO9MOPs5ySz3NLYSfe4/LFkdy5Jq+?= =?us-ascii?q?19K+dD8xQP6oHvVFNo+TVgZxTpT8cmDWW38H1xKHU3FgrADqffTCLm5LmmJr?= =?us-ascii?q?ZviDGYbVr5P4lMRAFnBOu7Crpxmrms7wBGi8Ix8rda1twOQUsvWAWuXNK7pG?= =?us-ascii?q?ZxK4z4a22dvh8W/cuS13JhTpKKNVkDURfA1vEeJXxaYPwT+FArQ68LT4zys5?= =?us-ascii?q?G1N8mGHrI4/4BqYLg17Wgva1Z0YlWBJAAkDTAPzESbTn4ms9cgrUxaHF8LVs?= =?us-ascii?q?M+dgPyxDLAwFVGhHfE5GMQ1NVNTfw4NISHBh17yBIKxjaZGxpVbBe9NYAPa8?= =?us-ascii?q?CSKAT21PDv0LBatDmspNhrWJ/YgsHKhs9+JB4u8qrUHw6iI/xxjgf2nZuOTW?= =?us-ascii?q?NqRMNvw/VQ4JajLnPHxEK2YtJUOXsrZYPlTygn6MMZ0BoKf1aWHanqRxW0UI?= =?us-ascii?q?K/Li25gpaXVV5p5jErtwn4hysavjoOm3fbGG0xUAMGSANxDXVZaJEOl8gTcf?= =?us-ascii?q?CLMNys8FdJtX+xEQWLR0UpeIHhjZd55W2fnGcL3fMmIuV3fu6bbbRE/Ajwul?= =?us-ascii?q?aXIiJ9+xiaFtIVuJyqBrYXIMLtfuY83n1D08MsIj5hnv2S/0Wim7cKV1XQU1?= =?us-ascii?q?Ox6PcHGNJQ+cNwuNKkt3MnmVwbJEjjQlpeT6qZo4sVINjJZViqt4iIV9gBca?= =?us-ascii?q?b/2rvXsIYRf6pRa3UGBvEcK8IFsCiAjz2WEtdyuk/8SD+knzW2UlB4VZ0QYG?= =?us-ascii?q?TOI+mMYH+kmiTJ2oqCya6Y3FNGceJEAOBq4XkbJ44p4rBQ4xOWN8Nz+23lGH?= =?us-ascii?q?KTyIAWc4ZaLS07O7Wn4hFY4QgfJC4B+oVaF33bBUZ7dF0l25qhDmmv178+r7?= =?us-ascii?q?5iL8KaLWKmPora4rWtmHMICDqBHmgdDDBRm87JxcjimnAw2IKNSS2eGAsZLC?= =?us-ascii?q?MH140RjCrbFVq3sJXtcqy4ZO2I+6x4fgHpx0aq/OWzBoVJJkKZX22f1XRBDy?= =?us-ascii?q?p5rD4RDAB+pl0MIkVp4Pu5K9XTeX979XoIAucI4D7aaNbvAZwy8atYO83bx+?= =?us-ascii?q?EmK851NusVFKIVDL3TC06GFGpLpUvPgRro7hSVeVPXyWLjQkrZt6eZJoM4Xe?= =?us-ascii?q?AZaxRwWgcth+ukLu3CXAoC6llFntJ6QZIFYVLABMX57x8NJNPMESsIZtkcql?= =?us-ascii?q?BMvZ60BD94N4YSfY7q9KY0GDIsDauOIqc1EUEv0M1hul4RH9o7hORohtVoeL?= =?us-ascii?q?BG2UY8z95LNfIPt3Ougt21545qcs+3bKaesRZoEwPagTRqkpr6MXFiI0MJxh?= =?us-ascii?q?juzxM0P5slfQUMm77unZ6yOKa20tqc2oMWacdYXnZhl0cD2C/mDXpCh+KEs5?= =?us-ascii?q?X1QNWSCehaqvd1Qg0V6tJ9WQX26E3FuDkeLBDB8RCvwF8lux095lyLVgEYqj?= =?us-ascii?q?KvaQSIsHvG/MYfg0z8RjYtdVsdKetgcSv0236D45utDoePTrG8ULcQ8veDaH?= =?us-ascii?q?vMFT1Xi2yQWz3JuXACWL4jbVfpoIgQOjfvb302OyPU0gj3KZO/eCWeTdJ7rB?= =?us-ascii?q?Z4obRKYX5x9/1nD7cfHBx1IzhvDxG0p1vThaBEU41+dfJYiS85CPraCFzdN5?= =?us-ascii?q?yNJtY7hJtdYQ54JUyHxfsYCLrp0OrM3tVNirZkwLMM3Y/T9c3XJP2B6dtSd+?= =?us-ascii?q?/S36xocwqSBes4mtdf1UOC9AUMpDkgxB9ZzkLxtCukdRKCwkIeZ9pYgXmkze?= =?us-ascii?q?E3h8Ei8kUmrco0XMN15jy63er8eF8sTVL9lxlhml+DBjlU3fSkdcgKiRH13u?= =?us-ascii?q?eYwszytQT6iDlgdz2YomjC6oZJkbX1dr5Wzf7UtPsu0OIz34GFGT5f10phg4?= =?us-ascii?q?nXgU028LB6MxTi5geJmqco9uisnzRnMdadGam8yri3bQAXytMZvEdUySi/in?= =?us-ascii?q?ETQKnQCW0liU3Qqz6I3AwefCd9OMLQHZfagIqs0J8xiHRGMh6Pbf2AfaIkTQ?= =?us-ascii?q?qWPN8n861LWIN4tUWQshUO96tWe0rFOdOggMZRb5lmJAlvJuLw1kah5vfmWN?= =?us-ascii?q?5wlLnjWSmRkX9DbmtVO4Ovc8ziM6jng7cGKpf0N7csL0fIclzvlJWLksVN4k?= =?us-ascii?q?auLtJ8maRsWxBonTPqhnalrNtnipqH3IGtQENtS6epLTV8wuaa5e1ulO1VrC?= =?us-ascii?q?NNsdHh7bOiIdBcSexFOUq4sF12gBnLpivVeirLzdEz1tu8kqFM97UrOp5ceV?= =?us-ascii?q?PNX7vpH5tmG5LFSnHQlQZaNTY20sotr8j1IILp7mGh1WoQPChcBhlWc5PIaB?= =?us-ascii?q?trwYKEblQgyTy7dNrj4opzKyn1ptyVIZvV1f/RsWnBleXbaxIDAGxv6W9oVe?= =?us-ascii?q?4CAVBEJMvvn2wdx54ik8JS2aOfSmokiD07J0Os/HksgPjV3JLKC+2Sxk9/20?= =?us-ascii?q?CmAg08DozwqoxAgGlXz7XgPt3VTVtOyk2Uz4SdakuvOO83n/hSqjkQQUrc4P?= =?us-ascii?q?nQm0N8a91vvjfbaOB35h9fA9fBR9XcM4G+Kzhvkil47HXgruoEALpuV38AcL?= =?us-ascii?q?RHRChXhVquExG16MQV1342hyxlRpiSZcyfE9oengEE6G7XUihpnsDE3TURqK?= =?us-ascii?q?JRaDCtvMQ6yLHK0RG8iSBX4H91tIbf9TU/rhFLuWse4plfpGCzwAe7uKsGgl?= =?us-ascii?q?6dH4pJob3spT2eDufsB4yv2jz/H/n1dFGZeTD8lkS26YVBh/6dq0QpnXYogq?= =?us-ascii?q?992HzEKPoim3u16WRKm7DL77H8oXM+PWRkLKk69N/RmVp7K0KWlKmrwcq+Pa?= =?us-ascii?q?enUgPGp1FxFs2I1YJhRHOhRlFflBC0=3D?= X-IronPort-AV: E=Sophos;i="5.92,284,1650945600"; d="scan'208";a="76130499" From: Anthony PERARD To: CC: Anthony PERARD , , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Julien Grall Subject: [PATCH 1/1] OvmfPkg/XenPvBlkDxe: Fix memory barrier macro Date: Tue, 19 Jul 2022 14:52:30 +0100 Message-ID: <20220719135230.32838-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Type: text/plain RnJvbTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+CgpUaGUgbWFj cm8gInhlbl9tYigpIiBuZWVkcyB0byBiZSBhIGZ1bGwgbWVtb3J5IGJhcnJpZXIsIHRoYXQgaXMg aXQKbmVlZHMgdG8gYWxzbyBwcmV2ZW50IHN0b3JlcyBmcm9tIGJlZW4gcmVvcmRlciBhZnRlciBs b2FkcyB3aGljaCBhbgp4ODYgQ1BVIGNhbiBkbyAoYXMgSSB1bmRlcnN0YW5kIGZyb20gcmVhZGlu ZyBbMV0pLiBTbyB0aGlzIHBhdGNoIG1ha2VzCnVzZSBvZiAibWZlbmNlIiBpbnN0cnVjdGlvbi4K CkN1cnJlbnRseSwgdGhlcmUncyBhIGdvb2QgY2hhbmNlIHRoYXQgT3ZtZlhlbiBoYW5nIGluClhl blB2QmxvY2tTeW5jKCksIGluIGFuIGluZmluaXRlIGxvb3AsIHdhaXRpbmcgZm9yIHRoZSBsYXN0 IHJlcXVlc3QgdG8KYmUgY29uc3VtZWQgYnkgdGhlIGJhY2tlbmQuIE9uIHRoZSBvdGhlciBoYW5k LCB0aGUgYmFja2VuZCBkaWRuJ3Qga25vdwp0aGVyZSB3ZXJlIGEgbmV3IHJlcXVlc3QgYW5kIGRv bid0IGRvIGFueXRoaW5nLiBUaGlzIGlzIGJlY2F1c2UgdGhlcmUKaXMgdHdvIHdheXMgdGhlIGJh Y2tlbmQgbG9vayBmb3IgcmVxdWVzdCwgZWl0aGVyIGl0J3Mgd29ya2luZyBvbiBvbmUKYW5kIHVz ZSBSSU5HX0ZJTkFMX0NIRUNLX0ZPUl9SRVFVRVNUUygpLCBvciBpdCdzIHdhaXRpbmcgZm9yIGFu CmV2ZW50L25vdGlmaWNhdGlvbi4gU28gdGhlIGZyb250ZW5kIChPdm1mWGVuKSBkb2Vzbid0IG5l ZWQgdG8gc2VuZAphIG5vdGlmaWNhdGlvbiBpZiB0aGUgYmFja2VuZCBpcyBhbHJlYWR5IHdvcmtp bmcsIGNoZWNraW5nIGZvciBuZWVkZWQKbm90aWZpY2F0aW9uIGlzIGRvbmUgYnkgUklOR19QVVNI X1JFUVVFU1RTX0FORF9DSEVDS19OT1RJRlkoKS4KClRoYXQgbGFzdCBtYXJjbyBpcyB3aGVyZSBv cmRlciBvZiBzdG9yZSB2cyBsb2FkIGlzIGltcG9ydGFudCwgdGhlCm1hY3JvIGZpcnN0IHN0b3Jl IHRoZSBmYWN0IHRoYXQgdGhlcmUncyBhIG5ldyByZXF1ZXN0LCB0aGVuIGxvYWQgdGhlCnZhbHVl IG9mIHRoZSBsYXN0IGV2ZW50IHRoYXQgdGhlIGJhY2tlbmQgaGF2ZSBkb25lIHRvIGNoZWNrIGlm IGFuCmFzeW5jaHJvbm91cyBub3RpZmljYXRpb24gaXMgbmVlZGVkLiBJZiB0aG9zZSBzdG9yZSBh bmQgbG9hZCBhcmUKcmVvcmRlciwgT3ZtZlhlbiBjb3VsZCB0YWtlIHRoZSB3cm9uZyBkZWNpc2lv biBvZiBub3Qgc2VuZGluZyBhCm5vdGlmaWNhdGlvbiBhbmQgYm90aCBzaWRlcyBqdXN0IHdhaXQu CgpUbyBmaXggdGhpcywgd2UgbmVlZCB0byB0ZWxsIHRoZSBDUFUgdG8gbm90IHJlb3JkZXIgc3Rv cmVzIGFmdGVyIGxvYWRzLgoKQWFyY2g2NCBpbXBsZW1lbnRhdGlvbiBvZiBNZW1vcnlGZW5jZSgp IGlzIHVzaW5nICJkbWIgc3kiIHdoaWNoIHNlZW1zCnRvIHByZXZlbnQgYW55IHJlb3JkZXJpbmcu CgpbMV0gaHR0cHM6Ly9lbi53aWtpcGVkaWEub3JnL3dpa2kvTWVtb3J5X29yZGVyaW5nI1J1bnRp bWVfbWVtb3J5X29yZGVyaW5nCgpTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFSRCA8YW50aG9u eS5wZXJhcmRAY2l0cml4LmNvbT4KLS0tCgpJJ20gbm90IHN1cmUgd2hhdCB3b3VsZCBiZSB0aGUg Y29ycmVjdCBpbXBsZW1lbnRhdGlvbiBvbiBNU0ZULApfUmVhZFdyaXRlQmFycmllcigpIHNlZW1z IHRvIGJlIG9ubHkgYSBjb21waWxlciBiYXJyaWVyLCBhbmQgSSBkb24ndAprbm93IHdoZXRoZXIg X21tX21mZW5jZSgpIGlzIGp1c3QgIm1mZW5jZSIgb3IgaWYgaXQgYWN0IGFzIGEgY29tcGlsZXIK YmFycmllciBhcyB3ZWxsLgoKQ2M6IEFyZCBCaWVzaGV1dmVsIDxhcmRiK3RpYW5vY29yZUBrZXJu ZWwub3JnPgpDYzogSmlld2VuIFlhbyA8amlld2VuLnlhb0BpbnRlbC5jb20+CkNjOiBKb3JkYW4g SnVzdGVuIDxqb3JkYW4ubC5qdXN0ZW5AaW50ZWwuY29tPgpDYzogR2VyZCBIb2ZmbWFubiA8a3Jh eGVsQHJlZGhhdC5jb20+CkNjOiBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPgotLS0KIE92 bWZQa2cvWGVuUHZCbGtEeGUvWGVuUHZCbGtEeGUuaW5mICAgICAgICAgIHwgIDggKysrKysrCiBP dm1mUGtnL1hlblB2QmxrRHhlL0Z1bGxNZW1vcnlGZW5jZS5oICAgICAgICB8IDI3ICsrKysrKysr KysrKysrKysrKysrCiBPdm1mUGtnL1hlblB2QmxrRHhlL1hlblB2QmxrRHhlLmggICAgICAgICAg ICB8ICAzICsrLQogT3ZtZlBrZy9YZW5QdkJsa0R4ZS9YODZHY2NGdWxsTWVtb3J5RmVuY2UuYyAg fCAyMCArKysrKysrKysrKysrKysKIE92bWZQa2cvWGVuUHZCbGtEeGUvWDg2TXNmdEZ1bGxNZW1v cnlGZW5jZS5jIHwgMjIgKysrKysrKysrKysrKysrKwogNSBmaWxlcyBjaGFuZ2VkLCA3OSBpbnNl cnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCiBjcmVhdGUgbW9kZSAxMDA2NDQgT3ZtZlBrZy9YZW5Q dkJsa0R4ZS9GdWxsTWVtb3J5RmVuY2UuaAogY3JlYXRlIG1vZGUgMTAwNjQ0IE92bWZQa2cvWGVu UHZCbGtEeGUvWDg2R2NjRnVsbE1lbW9yeUZlbmNlLmMKIGNyZWF0ZSBtb2RlIDEwMDY0NCBPdm1m UGtnL1hlblB2QmxrRHhlL1g4Nk1zZnRGdWxsTWVtb3J5RmVuY2UuYwoKZGlmZiAtLWdpdCBhL092 bWZQa2cvWGVuUHZCbGtEeGUvWGVuUHZCbGtEeGUuaW5mIGIvT3ZtZlBrZy9YZW5QdkJsa0R4ZS9Y ZW5QdkJsa0R4ZS5pbmYKaW5kZXggNWRkOGU4YmUxMTgzLi5kYzkxODY1MjY1YzEgMTAwNjQ0Ci0t LSBhL092bWZQa2cvWGVuUHZCbGtEeGUvWGVuUHZCbGtEeGUuaW5mCisrKyBiL092bWZQa2cvWGVu UHZCbGtEeGUvWGVuUHZCbGtEeGUuaW5mCkBAIC0zMCw5ICszMCwxNyBAQCBbU291cmNlc10KICAg Q29tcG9uZW50TmFtZS5jDQogICBDb21wb25lbnROYW1lLmgNCiAgIERyaXZlckJpbmRpbmcuaA0K KyAgRnVsbE1lbW9yeUZlbmNlLmgNCiAgIFhlblB2QmxrRHhlLmMNCiAgIFhlblB2QmxrRHhlLmgN CiANCitbU291cmNlcy5JQTMyXQ0KKyAgWDg2R2NjRnVsbE1lbW9yeUZlbmNlLmMgfCBHQ0MNCisg IFg4Nk1zZnRGdWxsTWVtb3J5RmVuY2UuYyB8IE1TRlQNCisNCitbU291cmNlcy5YNjRdDQorICBY ODZHY2NGdWxsTWVtb3J5RmVuY2UuYyB8IEdDQw0KKyAgWDg2TXNmdEZ1bGxNZW1vcnlGZW5jZS5j IHwgTVNGVA0KIA0KIFtMaWJyYXJ5Q2xhc3Nlc10NCiAgIFVlZmlEcml2ZXJFbnRyeVBvaW50DQpk aWZmIC0tZ2l0IGEvT3ZtZlBrZy9YZW5QdkJsa0R4ZS9GdWxsTWVtb3J5RmVuY2UuaCBiL092bWZQ a2cvWGVuUHZCbGtEeGUvRnVsbE1lbW9yeUZlbmNlLmgKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwLi5lM2QxZGYzZDBlOWQKLS0tIC9kZXYvbnVsbAorKysgYi9Pdm1mUGtn L1hlblB2QmxrRHhlL0Z1bGxNZW1vcnlGZW5jZS5oCkBAIC0wLDAgKzEsMjcgQEAKKy8qKiBAZmls ZQ0KKyAgQ29weXJpZ2h0IChDKSAyMDIyLCBDaXRyaXggTHRkLg0KKw0KKyAgU1BEWC1MaWNlbnNl LUlkZW50aWZpZXI6IEJTRC0yLUNsYXVzZS1QYXRlbnQNCisqKi8NCisNCisjaWYgZGVmaW5lZCAo TURFX0NQVV9JQTMyKSB8fCBkZWZpbmVkIChNREVfQ1BVX1g2NCkNCisNCisvLw0KKy8vIExpa2Ug TWVtb3J5RmVuY2UoKSBidXQgcHJldmVudCBzdG9yZXMgZnJvbSBiZWVuIHJlb3JkZWQgd2l0aCBs b2FkcyBieQ0KKy8vIHRoZSBDUFUgb24gWDY0Lg0KKy8vDQorVk9JRA0KK0VGSUFQSQ0KK0Z1bGxN ZW1vcnlGZW5jZSAoDQorICBWT0lEDQorICApOw0KKw0KKyNlbHNlDQorDQorLy8NCisvLyBPbmx5 IGltcGxlbWVudCBGdWxsTWVtb3J5RmVuY2UoKSBvbiBYODYgYXMgTWVtb3J5RmVuY2UoKSBpcyBw cm9iYWJseQ0KKy8vIGZpbmUgb24gb3RoZXIgcGxhdGZvcm0uDQorLy8NCisjZGVmaW5lIEZ1bGxN ZW1vcnlGZW5jZSgpICBNZW1vcnlGZW5jZSgpDQorDQorI2VuZGlmDQpkaWZmIC0tZ2l0IGEvT3Zt ZlBrZy9YZW5QdkJsa0R4ZS9YZW5QdkJsa0R4ZS5oIGIvT3ZtZlBrZy9YZW5QdkJsa0R4ZS9YZW5Q dkJsa0R4ZS5oCmluZGV4IDM1MGI3YmQzMDljMC4uNjdlZTE4OTllOWE4IDEwMDY0NAotLS0gYS9P dm1mUGtnL1hlblB2QmxrRHhlL1hlblB2QmxrRHhlLmgKKysrIGIvT3ZtZlBrZy9YZW5QdkJsa0R4 ZS9YZW5QdkJsa0R4ZS5oCkBAIC0xMSw4ICsxMSw5IEBACiAjZGVmaW5lIF9fRUZJX1hFTl9QVl9C TEtfRFhFX0hfXw0KIA0KICNpbmNsdWRlIDxVZWZpLmg+DQorI2luY2x1ZGUgIkZ1bGxNZW1vcnlG ZW5jZS5oIg0KIA0KLSNkZWZpbmUgeGVuX21iKCkgICBNZW1vcnlGZW5jZSgpDQorI2RlZmluZSB4 ZW5fbWIoKSAgIEZ1bGxNZW1vcnlGZW5jZSgpDQogI2RlZmluZSB4ZW5fcm1iKCkgIE1lbW9yeUZl bmNlKCkNCiAjZGVmaW5lIHhlbl93bWIoKSAgTWVtb3J5RmVuY2UoKQ0KIA0KZGlmZiAtLWdpdCBh L092bWZQa2cvWGVuUHZCbGtEeGUvWDg2R2NjRnVsbE1lbW9yeUZlbmNlLmMgYi9Pdm1mUGtnL1hl blB2QmxrRHhlL1g4NkdjY0Z1bGxNZW1vcnlGZW5jZS5jCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMC4uOTJkMTA3ZGVmNDcwCi0tLSAvZGV2L251bGwKKysrIGIvT3ZtZlBr Zy9YZW5QdkJsa0R4ZS9YODZHY2NGdWxsTWVtb3J5RmVuY2UuYwpAQCAtMCwwICsxLDIwIEBACisv KiogQGZpbGUNCisgIENvcHlyaWdodCAoQykgMjAyMiwgQ2l0cml4IEx0ZC4NCisNCisgIFNQRFgt TGljZW5zZS1JZGVudGlmaWVyOiBCU0QtMi1DbGF1c2UtUGF0ZW50DQorKiovDQorDQorI2luY2x1 ZGUgIkZ1bGxNZW1vcnlGZW5jZS5oIg0KKw0KKy8vDQorLy8gTGlrZSBNZW1vcnlGZW5jZSgpIGJ1 dCBwcmV2ZW50IHN0b3JlcyBmcm9tIGJlZW4gcmVvcmRlZCB3aXRoIGxvYWRzIGJ5DQorLy8gdGhl IENQVSBvbiBYNjQuDQorLy8NCitWT0lEDQorRUZJQVBJDQorRnVsbE1lbW9yeUZlbmNlICgNCisg IFZPSUQNCisgICkNCit7DQorICBfX2FzbV9fIF9fdm9sYXRpbGVfXyAoIm1mZW5jZSI6OjoibWVt b3J5Iik7DQorfQ0KZGlmZiAtLWdpdCBhL092bWZQa2cvWGVuUHZCbGtEeGUvWDg2TXNmdEZ1bGxN ZW1vcnlGZW5jZS5jIGIvT3ZtZlBrZy9YZW5QdkJsa0R4ZS9YODZNc2Z0RnVsbE1lbW9yeUZlbmNl LmMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi5mY2IwOGY3NjAxY2QK LS0tIC9kZXYvbnVsbAorKysgYi9Pdm1mUGtnL1hlblB2QmxrRHhlL1g4Nk1zZnRGdWxsTWVtb3J5 RmVuY2UuYwpAQCAtMCwwICsxLDIyIEBACisvKiogQGZpbGUNCisgIENvcHlyaWdodCAoQykgMjAy MiwgQ2l0cml4IEx0ZC4NCisNCisgIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBCU0QtMi1DbGF1 c2UtUGF0ZW50DQorKiovDQorDQorI2luY2x1ZGUgIkZ1bGxNZW1vcnlGZW5jZS5oIg0KKyNpbmNs dWRlIDxpbnRyaW4uaD4NCisNCisvLw0KKy8vIExpa2UgTWVtb3J5RmVuY2UoKSBidXQgcHJldmVu dCBzdG9yZXMgZnJvbSBiZWVuIHJlb3JkZWQgd2l0aCBsb2FkcyBieQ0KKy8vIHRoZSBDUFUgb24g WDY0Lg0KKy8vDQorVk9JRA0KK0VGSUFQSQ0KK0Z1bGxNZW1vcnlGZW5jZSAoDQorICBWT0lEDQor ICApDQorew0KKyAgX1JlYWRXcml0ZUJhcnJpZXIgKCk7DQorICBfbW1fbWZlbmNlICgpOw0KK30N Ci0tIApBbnRob255IFBFUkFSRAoK From xen-devel-bounces@lists.xenproject.org Tue Jul 19 14:13:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 14:13:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370677.602554 (Exim 4.92) (envelope-from ) id 1oDny2-0001RK-Lp; Tue, 19 Jul 2022 14:12:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370677.602554; Tue, 19 Jul 2022 14:12:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDny2-0001RD-Iu; Tue, 19 Jul 2022 14:12:54 +0000 Received: by outflank-mailman (input) for mailman id 370677; Tue, 19 Jul 2022 14:12:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDny1-0001R7-75 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 14:12:53 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dde3f1a2-076c-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 16:12:50 +0200 (CEST) Received: from mail-dm6nam12lp2176.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 10:12:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB5962.namprd03.prod.outlook.com (2603:10b6:408:133::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Tue, 19 Jul 2022 14:12:40 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 14:12:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dde3f1a2-076c-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658239970; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=46eHTGcIXiTxNKzyN+/IF89NYdtrZ4+vu3IkW/DEro4=; b=KBQ7qIFOWuXtNeNXe9CUTOYl9hlIEb81/cmLAGDyoF4J6Rp9X//i6Zkc hMzPPoPD0WAjZnFUjH2CvjsBU6xw3+wmzMaybfd6hFiip7DHhYtNevGJz v2lEtTz9j5g0WZZ5HtBXOUEbkZd20/+z30C2ZVIQQyc1pH0kmNc+cUHyt 0=; X-IronPort-RemoteIP: 104.47.59.176 X-IronPort-MID: 75950192 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:TWQW36Jh7TkjX2C4FE+RVpQlxSXFcZb7ZxGr2PjKsXjdYENS1jcEm jYaCz+EM/mLNmr2eo92O4W3pEoOuMXcx4VnQFZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYjdJ5xYuajhOs/3a+Us11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE/ql3PGMvFoYi2sVHAmtXq /A1BxckcUXW7w626OrTpuhEoO0GdZOuEKZB/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H11z+mLGMwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPCmGfdqyP27gPJtQPSW7ITBODjz9druWSP3k4yJS8IX2Lu9JFVjWb7AbqzM Xc89icwoKwa+UCoFJ/yRRqluGXCvxl0c8pdFag25R+AzoLQ4h2FHS4UQzhZctskucQqAzsw2 TehlsnlD39zsbSTTnma7Lq8rj6oPyURa2gYakcsTwoI/NTl5pA6iTrOSMpuFOi+ididMTP32 TyDqm46wbcOltIG0Y26+0zKh3SnoZ2hZg0v7xXaWkq/4w95bZLjbIutgXDZ8PJBIYCxXlSH+ n8elKCjAPsmCJiMkGmBRbsLFbTwvfKdamSD3xhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLITLwJiti8ggJyX6VM IronPort-HdrOrdr: A9a23:RCXnIK0QC64I0XIewvHhzgqjBRFyeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5AEtQ4uxpOMG7MBDhHQYc2/hdAV7QZnidhILOFvAv0WKC+UyrJ8SazIJgPM hbAs9D4bHLbGSSyPyKmDVQcOxQj+VvkprY49s2pk0FJW4FV0gj1XYBNu/xKDwVeOAyP+tcKH Pq3Lsjm9PPQxQqR/X+IkNAc/nIptXNmp6jSwUBHQQb5A6Hii7twKLmEjCDty1uEg9n8PMHyy zoggb57qKsv7WQ0RnHzVLe6JxQhZ/I1sZDPsqRkcIYQw+cyjpAJb4RGIFqjgpF5d1H22xa1O UkZC1QePib3kmhPF1dZyGdnTUIngxeskMKgmXo/EcL6faJOA7STfAxy76xOyGplXbJ9rtHod 129nPcuJxNARzamiPho9DOShFxj0Kx5WEviOgJkhVkIMIjgZJq3PsiFXluYeE9NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonNrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUBzaPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTObNSRP5uw/zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fABK5r X-IronPort-AV: E=Sophos;i="5.92,284,1650945600"; d="scan'208";a="75950192" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTK0i/w5JXIz0NLO9Lq/IJNPgdDTx59MhYiPSXjOfGxGVHFXrHt8iitmHyVS8UVTvw7aX/beyOHn7W6c7Hsp5NSxXcLjGIXC1T20/jwrSYeLnZssnbCeQ2GMPQ9SbV+hTnIHdc8WdxgxAPH0a5INcJTT7eDMaNGdeFGXnUkmdwVUXln59blqW9Hc7SitQeD59bVyInr/xlGKXBW+Euv3oRiPeaDbOiNmDPNI1hgJDGSJgFxcDDDoTThMTu4wS281Z530J9EBM5LCSnSVvAKBsNWcSCT6fLdTJOqbD3zB31mSvd/REHpCKuaDJ3BbdcAARV0gF9vFFeHALmEyAGMk/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=46eHTGcIXiTxNKzyN+/IF89NYdtrZ4+vu3IkW/DEro4=; b=TQsUsvCn8USGf6KViJ1f19QwzOW8UUMnJLVxq0TwPo33Kh3WTIiFMxpLp+XA6b/+y21ElpU29AzbsX39qB72RpBR3a1pTRcYzKrWxpzmjm7sIHlc1N7+fz6Fq3FrYv+5w/yL3eKizsBczH7Lw7ZcnPYdBMSIGTrVxAypIYfPLNVELQMiSThGhFZrH7QetVvVq21CHMfaCWrhrFGFg0Ld9xL7XcyrRTWycurvEdEDu28pdg9ZOalk9m3wSAyDpC9Hj/A0LBBgq4BeBqBS3Co3J7U4j/kB3Hf+MDMZUszGAQ19PpLTpB8ZxX1mcXMW/5n4Uay1Sa0XXfojGHrB/rtWbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=46eHTGcIXiTxNKzyN+/IF89NYdtrZ4+vu3IkW/DEro4=; b=VlVwr+5Lpr4Whz8cfuSKXyH0ZghM/D1L3lKiMrPkAafi0zesVu7vj9d4btNw8tMrgAID2sQbeuHpxNofaE+xGFFPUmvsL3CJGg0P5E3BviXyWx/yCHB+Dv25ayckRU6vkcTtHVwXWGuaIllorpgVAVWb7q+yhEJlYAK4fi4pqo0= From: Andrew Cooper To: Anthony Perard , "devel@edk2.groups.io" CC: "xen-devel@lists.xenproject.org" , Ard Biesheuvel , Jiewen Yao , Jordan Justen , Gerd Hoffmann , Julien Grall Subject: Re: [PATCH 1/1] OvmfPkg/XenPvBlkDxe: Fix memory barrier macro Thread-Topic: [PATCH 1/1] OvmfPkg/XenPvBlkDxe: Fix memory barrier macro Thread-Index: AQHYm3bUnP9y0GYoU0uIINVtZTXPCK2FvEeA Date: Tue, 19 Jul 2022 14:12:40 +0000 Message-ID: <73483ebf-d641-e4f2-6e23-b0336e62f359@citrix.com> References: <20220719135230.32838-1-anthony.perard@citrix.com> In-Reply-To: <20220719135230.32838-1-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 459c6c68-c9f3-45f9-e2d8-08da6990bd98 x-ms-traffictypediagnostic: BN9PR03MB5962:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 181hoYzkU6eUIr4dOOIYmiL8nAcgAd6w2o4NjPyk96AEludIthqpaG91j4bGWHEzrIHNakHdEFS0Gkg3Egm55iO24No99woTkTj1A1gsTXJej05GDmxl/6Ufh9P9aUscpgneJHwXbx5toVq6hjHzQjVxSrfU6alY8n4+JwnVeQri4/pFU2zE41A05ZjEUfjLGtcwqjn7/SBZze25FHCFCTy6VMw4B4MoIup7+sxpxvz1ERtzhJWW2XlUhqOUKgOJOfuYp/RZI5Ut3VA8/589g2A6RjT/0CR/POtpUaYqnUSbGXBqS00jLI5fTxIEwbZVymlsmwNcbCmK3GNSuVRmY6YdPud3BqhH1GWsn/hZmVBm6vHa85k6auIUASQ7HzvyU8RPiT9quF6zxNhgctkfuEM6SqcRxElKk3OvcB4LvNPqH5sN8jxxNjmbbM2lNE5bTU6mjueisNgd7ttgAoWjTbM/Yeeb/enbfU1uo5W24RKsfnNhJF36lANFoKtj9cXPuVloCc5yj3jVopCl+qo4GUBwEj6n5/vhcH/zcIfhS+6GiUo7pvKbiZSoglHBGZWpnBRl+VM8RWG3ScKZNgenECNuZHH1doVTWlho5Zjk21VSN+651QahT47jF0Kj4gDhYCdInr67GpnRHQKIvs/ANtWTxnRxSY3qkGKXZUtT3YhE+6t8O+e/PDAB4cdKKq3Uy59bH3xTDQs3jJpCV/689YD8FhcyFfsj86+8k96xoMFB7bo9G5Cbx8giq2hnnsPLMlV7j5VI5EK7WLMP36bb26IzUbQG7Phe7TbP1ScwOQFUz7yOdYRRmERTqDAZtinFPfUBh6pBBmBuWYdXaUHbRtSvu29cMj986c+vPc4zw8g= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(6029001)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(36756003)(4326008)(76116006)(5660300002)(8936002)(66476007)(66556008)(64756008)(8676002)(66946007)(38100700002)(122000001)(31696002)(2616005)(2906002)(86362001)(478600001)(19627235002)(38070700005)(31686004)(6486002)(71200400001)(41300700001)(82960400001)(83380400001)(110136005)(6506007)(66446008)(316002)(6512007)(26005)(53546011)(186003)(91956017)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SnpYblhobzdNWmZTK2F5eHBOKzlFSnFmK1FUUzlwZlB3aE1CZjFBQWpPY2sr?= =?utf-8?B?NnNTZ0l0V2E0L1BuN0w0UTFmZUhrdTgrM3R6aTVWZVZncGpRZkdlSng0am5R?= =?utf-8?B?TXFNQjl4d09OTFBlNkJabGZIek1uc0lRaTV3Q25yMjhyYzFQRHh6M1JScTB4?= =?utf-8?B?VUxjaEtnK1gzRkFiMS9qTzZzcE9yY1EzWmJNcDZYOXdyWjU3MVhsMlJrZnQx?= =?utf-8?B?SThONU9MYkVZbTN4Q2lYekdJa0JoMXNZY05pT2MwSGFmaVZ6N3QwVWVUKzBo?= =?utf-8?B?TWVYY1hjdXNSbERIbUhSZWtxV1dlRjd0Wm1WRTJ6U2dtL1NmRkNoR1B2UGdF?= =?utf-8?B?aTdyd3Izc0s4S01vVDh5NTJ4MUQwWmRjcUl2c0FYQjRoWGtZeGpGR1JiZ2lh?= =?utf-8?B?TEpsSTd4bytFcWFEUDBJT1A3TmlXSEJKTzg4WjgzcENQaUtIWnBrTGhWSjhz?= =?utf-8?B?MTdaUWJXYmVaby9kSnpSZW5tVHBzeTVSTVRCZjl4azJJaG55RnliTWxsRS9H?= =?utf-8?B?V1doTkxsd2RPNUgwOUt4YlpFaGRRaTI0MHhlNDlGQ0FqMDdjZ3J3ZXFUU3Vx?= =?utf-8?B?RmJHVXdxUnJUWmxvTjMyNlc2NXo4QlhEemRFTnJrOGtZbjR5RG9xQjB6R0JG?= =?utf-8?B?UnY4QlEwMDZpSndnK3JBVmlVRkx2ZEkwaGpJbHc0ZzdvMjZPQVFYTTJMNmp6?= =?utf-8?B?RjRrTXRNcTZmb1g1UFNTa1haUjFrTHhlb0ZpbkNXSkoxWFUzVlE1SkRzVmNr?= =?utf-8?B?Wld6ZGNkQmZJWVRJSmllQWZrb0pMQWRSRklnaDlGOC9XMzJLQ0RCQ0tiSzh0?= =?utf-8?B?OW51R3hHZGNoNTQ5aGhRL0wvcXlYRzZEbXUxNkdZZUovdTRHT3hwV1Y2a0Jo?= =?utf-8?B?cmRCYXRINU1FUmlvWFBmS01ma3Q2K3FLT0RCaXRCM1NVWXlzTk9Rb3lON3No?= =?utf-8?B?V3BxcmVjeXkyQVZjako2Um5oTk9nUjhFUUZhQTBubWhUVnFkQVI4UGF1c09B?= =?utf-8?B?bXVRa1pVQm42SklVQzlIQUdGL1A0dWhsU1hKN0tTZ0J0YnJsUzB4TFBUajl4?= =?utf-8?B?elJvdnNaUEk1MzNldUJJMzBTbitMQVhPUHRiVzlBb3ZyRXRwU3RrSEVvQVpQ?= =?utf-8?B?Y2lxbFozLzdwV3BCVWxHcDdQeTdwZGRSWUR1QlZoY3U0Z3Z5ckRLZHN1NDdT?= =?utf-8?B?M3lNdFNHa0xJZ01ab0o3bTVPM1BoZW5hUVA0U0o1SldoT2UzUi9ZcU9vc2JS?= =?utf-8?B?N0s2U28zNFRGNW5nb0xjN3l3TFBBUkdOb2NQcEhDU01WUjhleTVNa0xERjJp?= =?utf-8?B?bGQ3TFh0QlNPUk1ZRDg1WGF3bzhmcGFhSy8rMDRCRUc1Y2h4YmtiVVFlT25p?= =?utf-8?B?OXRYcy9YNFRMWlF0MWFVdzFiaHRublpLQnh5NDFFb0RCeElxL01nMXhkVEp3?= =?utf-8?B?a3dydTg3VUs1SjRBZzhyNWcyc2NjVzlTaGg0T3RSNCsraG50RU5oaG55d2NP?= =?utf-8?B?WFY1ZERpYXdkdlRidm9sTjZyaURjTnJsTW9JRUhZYWc1RTRkSG0yMi9yWWh3?= =?utf-8?B?czBrMndTZVBvcTA5YmQrbmV1czlFVk1UMWVxeGc0d2twNDJwbXZnbGc5eDBl?= =?utf-8?B?bTJlM1hpNUZaeUtldkl1UUFueXR5STJ1bEcxM0pwTkRoNFdFTXdjc2tMRTFJ?= =?utf-8?B?Y0ZoR1BnUEpDZTNDaWxvMzhqVXhmaUlkRDFybUZ3dFp5YmtGQ0h5VmViWGoz?= =?utf-8?B?UXc4RjRoSWIrT2VHNEpZbEx1a2hRV2lnVTBwYTBleEV4TUNKdEJPdVpPamV2?= =?utf-8?B?K1dmSXNsNXU3L3E2djgxY21uTzhOQlFIK1NqZVlwTHczRkc3Tk1CczBXV2ov?= =?utf-8?B?QmhYUE1IaXpSWEhObG1seHNVcFFvR0tSbHRVbnhTNFZYeHVqOFVTM2hQQ2h2?= =?utf-8?B?UnJ0MVN4bUZIU3M3QU8wYlhvZXhkMUgvZDhIeU9GL0JvV2lHZzgzTmRYSGdq?= =?utf-8?B?Smd1ZHV1WVBqbzVvRHptOGNhR2VzU1RUM2FkOVZURDFGU0NlRGV3NXBZS0o2?= =?utf-8?B?TmJKRUQzZWdCRHc0L1NDSm5wbElEMXA2eXpBMFQ2dWxFVCtpN1JiUGhBSG9D?= =?utf-8?Q?EdyQS7Mc8E4FJH6gP5hcW7Y/E?= Content-Type: text/plain; charset="utf-8" Content-ID: <4322EA8C8F1BA34D9996EB110178DAC0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 459c6c68-c9f3-45f9-e2d8-08da6990bd98 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 14:12:40.3154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dGthQG0ll0ZY3kYrE2IbyHP1EbNYsD3yGnS0580krOxoTSelUVzZliY8odoZBQ1oUDtUTzNFHR8cTN97H5KuWIhQazraDYwuF03iMk0Bovk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB5962 T24gMTkvMDcvMjAyMiAxNDo1MiwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IGRpZmYgLS1naXQg YS9Pdm1mUGtnL1hlblB2QmxrRHhlL1hlblB2QmxrRHhlLmggYi9Pdm1mUGtnL1hlblB2QmxrRHhl L1hlblB2QmxrRHhlLmgNCj4gaW5kZXggMzUwYjdiZDMwOWMwLi42N2VlMTg5OWU5YTggMTAwNjQ0 DQo+IC0tLSBhL092bWZQa2cvWGVuUHZCbGtEeGUvWGVuUHZCbGtEeGUuaA0KPiArKysgYi9Pdm1m UGtnL1hlblB2QmxrRHhlL1hlblB2QmxrRHhlLmgNCj4gQEAgLTExLDggKzExLDkgQEANCj4gICNk ZWZpbmUgX19FRklfWEVOX1BWX0JMS19EWEVfSF9fDQo+ICANCj4gICNpbmNsdWRlIDxVZWZpLmg+ DQo+ICsjaW5jbHVkZSAiRnVsbE1lbW9yeUZlbmNlLmgiDQo+ICANCj4gLSNkZWZpbmUgeGVuX21i KCkgICBNZW1vcnlGZW5jZSgpDQo+ICsjZGVmaW5lIHhlbl9tYigpICAgRnVsbE1lbW9yeUZlbmNl KCkNCj4gICNkZWZpbmUgeGVuX3JtYigpICBNZW1vcnlGZW5jZSgpDQo+ICAjZGVmaW5lIHhlbl93 bWIoKSAgTWVtb3J5RmVuY2UoKQ0KDQpPaywgc28gdGhlIG9sZCBNZW1vcnlGZW5jZSgpIGlzIGRl ZmluaXRlbHkgYm9ndXMgaGVyZS4NCg0KSG93ZXZlciwgaXQgZG9lc24ndCBuZWVkIHRvIGJlIGFu IG1mZW5jZSBpbnN0cnVjdGlvbi7CoCBBbGwgdGhhdCBpcw0KbmVlZGVkIGlzIHNtcF9tYigpLCB3 aGljaCB0aGVzZSBkYXlzIGlzDQoNCmFzbSB2b2xhdGlsZSAoICJsb2NrIGFkZGwgJDAsIC00KCUl cnNwKSIgOjo6ICJtZW1vcnkiICkNCg0KYmVjYXVzZSB0aGF0IGhhcyB0aGUgcmVxdWlyZWQgcmVh ZC93cml0ZSBvcmRlcmluZyBwcm9wZXJ0aWVzIHdpdGhvdXQgdGhlDQpleHRyYSBzZXJpYWxpc2lu ZyBwcm9wZXJ0eSB0aGF0IG1mZW5jZSBoYXMuDQoNCkZ1cnRoZXJtb3JlLCAuLi4NCg0KPiAgDQo+ IGRpZmYgLS1naXQgYS9Pdm1mUGtnL1hlblB2QmxrRHhlL1g4NkdjY0Z1bGxNZW1vcnlGZW5jZS5j IGIvT3ZtZlBrZy9YZW5QdkJsa0R4ZS9YODZHY2NGdWxsTWVtb3J5RmVuY2UuYw0KPiBuZXcgZmls ZSBtb2RlIDEwMDY0NA0KPiBpbmRleCAwMDAwMDAwMDAwMDAuLjkyZDEwN2RlZjQ3MA0KPiAtLS0g L2Rldi9udWxsDQo+ICsrKyBiL092bWZQa2cvWGVuUHZCbGtEeGUvWDg2R2NjRnVsbE1lbW9yeUZl bmNlLmMNCj4gQEAgLTAsMCArMSwyMCBAQA0KPiArLyoqIEBmaWxlDQo+ICsgIENvcHlyaWdodCAo QykgMjAyMiwgQ2l0cml4IEx0ZC4NCj4gKw0KPiArICBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjog QlNELTItQ2xhdXNlLVBhdGVudA0KPiArKiovDQo+ICsNCj4gKyNpbmNsdWRlICJGdWxsTWVtb3J5 RmVuY2UuaCINCj4gKw0KPiArLy8NCj4gKy8vIExpa2UgTWVtb3J5RmVuY2UoKSBidXQgcHJldmVu dCBzdG9yZXMgZnJvbSBiZWVuIHJlb3JkZWQgd2l0aCBsb2FkcyBieQ0KPiArLy8gdGhlIENQVSBv biBYNjQuDQo+ICsvLw0KPiArVk9JRA0KPiArRUZJQVBJDQo+ICtGdWxsTWVtb3J5RmVuY2UgKA0K PiArICBWT0lEDQo+ICsgICkNCj4gK3sNCj4gKyAgX19hc21fXyBfX3ZvbGF0aWxlX18gKCJtZmVu Y2UiOjo6Im1lbW9yeSIpOw0KPiArfQ0KDQouLi4gc3R1ZmYgbGlrZSB0aGlzIG5lZWRzIHRvIGNv bWUgZnJvbSBhIHNpbmdsZSBjb3JlIGxvY2F0aW9uLCBhbmQgbm90DQpvcGVuY29kZWQgZm9yIGVh Y2ggZHJpdmVyLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 19 14:26:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 14:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370688.602565 (Exim 4.92) (envelope-from ) id 1oDoBW-0003He-0H; Tue, 19 Jul 2022 14:26:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370688.602565; Tue, 19 Jul 2022 14:26:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoBV-0003HX-TQ; Tue, 19 Jul 2022 14:26:49 +0000 Received: by outflank-mailman (input) for mailman id 370688; Tue, 19 Jul 2022 14:26:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoBU-0003HR-4V for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 14:26:48 +0000 Received: from sonic307-55.consmr.mail.gq1.yahoo.com (sonic307-55.consmr.mail.gq1.yahoo.com [98.137.64.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d042e8ad-076e-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 16:26:45 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic307.consmr.mail.gq1.yahoo.com with HTTP; Tue, 19 Jul 2022 14:26:43 +0000 Received: by hermes--production-ne1-7864dcfd54-xmlhn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID b8ca309c635e58bb59d98f5d4af24c5c; Tue, 19 Jul 2022 14:26:39 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d042e8ad-076e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658240803; bh=0MCR8ztNVvXBqIPyv/idSIbRg9uzDbj24OkajSfymqY=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=Z3k1/SJIzrZYrmbOX1dBbaf5GPEKHP9SIlbBvRQlqBjd8qMjN/2mF7XRPzfHAbxlmURUBwF5s5RI6+x316ZZpLkLk5e8Eu63arS8GgpUfxv3qs0+kJMCF+XL++omqVMKJXY05rIIue4WPv+uZJoi0BQjIoNZ8HVPWuF/zUjyI7Sg/4LD4pAW0Hud6OIkN5f5fBXX8Kv9+iodyZwQNK0ebnPwk1kchQpcrS0K5YPlRhbpz6Mv7x5htlA0KyUVm9cZsXJbVeoT9lijfAGPEiDRWImhzrz0LkvD844VI8FxMilexZ6roqaALnwSahB/eQ8f3muNnR6y/rO+H1Q92jwqvg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658240803; bh=prMMb/82heNYdPl8col/mQCTUTYLA2n+jBI4we748yI=; h=X-Sonic-MF:Date:Subject:From:To:From:Subject; b=PXDSqxBhUqlwJ479JUvc/OkXo87eA2EEDdZ0OgsoauJScchd8YyBSp/YMrYVHro8a8bBIhBTykGItbHbW7MMF5gZrSx3uBA7uTU5/taPrnANWu/LAfYW2Y31lcjoZACWbOIpeXyUhzgGaOxViSAvoNzb5K4/W1cXrUw/hktCFsyDW8lMC4TvP3pfzFfBqZlDHR6e00rAI0Buub08vGArUAkHytVsPVxwkgNOziLAs/Q/aYHHX/92rcB+2H/ezAlqcKx23fymfTPIJ1UGBbG2MW+yos2nEwNRhebgrKewXVKQA2Oowrh3azQWKSjAH8dH5PB2p23de2SREOEaSIehuw== X-YMail-OSG: GyAknA4VM1kx2hr044yAhCFakR.BiMo_KCi1aa1GGZVgj47vNFVX2KVm5iDUEFP QBdv0weC5482CAyl_reJrQeG7yhskjldBgFPnX6gi5Zt0H23wjVn08.AKrv9fxduJj1vTPqIGFJC P6VRJ5uFKnLmRC5FbZqJbxFoVNdNBCHC2gKWKxdq3RsM5n9cyFDnQnK.Kn0.Pk9Ug.j7iEOS2f9e 04jepfROKgV3LSQtuBFB9JiJ6_QbDXo7Z8OoGkMFEAqtNhXAxnQyyzcHD4q.Mc3ZWQZRlQx4BmwZ na7vGEY93Q72xg.gQGt3OjRbP9rHnHPVOunGQy82lLOPhe1.menmI.4iYiPd6sgQ62Ng95Sxdwep 7YplzMHSl5ZkYQkdrw99l1_CdeoINsCmUH_T2X1pwCGMcIEScz4BnDVseOWHTFlMELqS_OLywuRF yuhKryGQjDgpEsMIv2ASWN5QgKiISbQdtSmCKOUh_BnH3UBok6pBuIR8bj6m9QS2_zevXfGHiFPd P7b7Gy5DTz_bBh9ELpcGVGupqSZjF5BHx9r4F_YvEL3sPgrRuurMhgT.xks5mcb0XQD.ypbUbnCK pPZKp..QoZPYjWwq3Zy_unTauYc092g6h7AgtX022cBlfpwNyK55.KB0sXEdHAeihT5a_aKpnTAl 6CmaxqWzR_skPl19hHtrfVvC8xmJwPyQxr6DeZOAXDP7PST6inAkyROyytSyVQA47dvi.AzWo4F6 HuI2zMHolHgkocRl.3UQQ7Rk6ftZ1OTCsrlCrwzKN4ZpyPrOrutBDiYx0JpZYDipMfPXXL0Sp1iR dxecP0SOs.DRrNqkrYBTrd13.rRiA_Nfx6OPYkGIM4NCSMEMkm6vydRQDIEG5MM6Czdq53O937CV tWls6IqkwMHGvFManTX5wR24_Ow9y5UzCFa6zG2EOXdovq_1TF2JBoq8GOjeZgZHvKljWxV4wYmt AYBf9AirQQIRlzTovcuRuG0KDb9PNAntFpYnjpZlLfnQp4Q8KpX3tSPEbb9xR9V5wspdsUf_kVJS Rcmqm_T4hB7FGolwjYHOxUdftLx6.h8..h9HaP3GM0WRoO.WHOCFdIzuE3viSlnpZLW_QVModxIU kPp2dYNsqd5fhPNiWK01KOxKtV6jH.A_XCdXW7Yz.ZcoK1Y45cpxvj3bJSW0KXj8Vpf566nn1TaY sDQzkqgwhW5bNXFJJZkq97FcqZaXGfsCEQr57ckaxV7EV6W6PVK_Baow1FCAcTq3Ds9En3VM_nhL P5DhFhvSCAD.7DrCPEkDxraKn4XA_RY53p20snBga7NMYjqX9h2EZDXqUxyoxYyrwoswumb37_Wa TRZE.SjiIDiuY6yTL8CRpKrZLxFAkEwmnnwmdWGmqeQvYRdRn1KzTroB3nyfh_A3TbBFllUvJ3Bu cMiW.Gkp8172fijKqa7OVLjmltJKgTW4js3zHm8sU_xVMrwy_zfGoCNlw3El2vLw32GeTXoqzVnu VXdgXvDEw4SfkIk6rBnkL47Zi95Cy4QIetKfg3ywIkYGWVs9ZI0XxIaOFzYO_HrqlBZ8XYw.JXHa Wp0LK3oob4utMS3pr81QkDQ0QkcjB.yNOnA9ookCXhJyeDhjnjdPjxTu5kOWgoZafzQUc66nroal _NUpYCDB9xGEMDj0ESfRZHyslut8FOYa865RZZ1KZZ1st86xczDzl.24gS1opmAlPN5vCuaXjLGd 0ihIrsBWEADnSRmLuxNlsSmuIkOWzv_pDu1LtIMSaAxUy6d9TJ5gfdLHL7WXddNGBt.BbJbvTSj5 EFACuylD3.ASK.7J29Og4x_y4gFGrRaQFwWhaKDg6I.FzLCRsHCUNugN1176q7a94Tx4ts6j9.IG 1mPzfpNdx0AunF8y0vl9dhhdqzq564gZFshrBjSDbCfIlXEUHNDdOt2TnOuk_AN0q7nsRn5V5zcU aiGrNYcmt1yTRDF4fk8C7fKLFQaklfFkOIwrgwVUBPkDLws9en8hRpgdR7UI0JK6UkPAA0PWwktA 70r6OGbOBCJppoxtEXoUQBjbTVHLFmwJIs6f_3uQAF.7NWM0GGvEE9NuWo2r7gvQluSVvRjW6Ji_ .tUFXl8SnC34We6uYhEYB3nmDLX97eDjLsJPTuYKikdnmRX96HghKnqsXXlXxxZRgt3FuexlOAUK UVMvfK9fn8oQ84KcNbgYds0HCEZJIfmtPMwpEQJ1hTWVAsO5x3eilTOEfWF0.WjPuw_NLCWYZdkg W8ioE52OkZ.N18NN7rbedB6Q1rh3fSw-- X-Sonic-MF: Message-ID: <786efd9f-d8fc-7235-7c1c-e0e90d1640be@netscape.net> Date: Tue, 19 Jul 2022 10:26:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ping: [PATCH] x86/PAT: have pat_enabled() properly reflect state when running on e.g. Xen Content-Language: en-US From: Chuck Zmudzinski To: Thorsten Leemhuis , Jan Beulich Cc: lkml , "xen-devel@lists.xenproject.org" , Andrew Lutomirski , "dave.hansen@linux.intel.com" , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , Juergen Gross References: <9385fa60-fa5d-f559-a137-6608408f88b0@suse.com> <8756355c-b586-3d1b-531c-72a04a8c047a@leemhuis.info> <05b5e672-0a1b-2d00-a879-b5127a94973f@suse.com> <4c8c9d4c-1c6b-8e9f-fa47-918a64898a28@leemhuis.info> <1a486b6d-037e-ac54-4279-286b4ae9452e@netscape.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 8590 On 7/14/2022 6:45 PM, Chuck Zmudzinski wrote: > On 7/14/2022 6:33 PM, Chuck Zmudzinski wrote: > > On 7/14/2022 1:17 PM, Chuck Zmudzinski wrote: > > > On 7/5/22 6:57 AM, Thorsten Leemhuis wrote: > > > > [CCing tglx, mingo, Boris and Juergen] > > > > > > > > On 04.07.22 14:26, Jan Beulich wrote: > > > > > On 04.07.2022 13:58, Thorsten Leemhuis wrote: > > > > >> On 25.05.22 10:55, Jan Beulich wrote: > > > > >>> On 28.04.2022 16:50, Jan Beulich wrote: > > > > >>>> The latest with commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT > > > > >>>> with pat_enabled()") pat_enabled() returning false (because of PAT > > > > >>>> initialization being suppressed in the absence of MTRRs being announced > > > > >>>> to be available) has become a problem: The i915 driver now fails to > > > > >>>> initialize when running PV on Xen (i915_gem_object_pin_map() is where I > > > > >>>> located the induced failure), and its error handling is flaky enough to > > > > >>>> (at least sometimes) result in a hung system. > > > > >>>> > > > > >>>> Yet even beyond that problem the keying of the use of WC mappings to > > > > >>>> pat_enabled() (see arch_can_pci_mmap_wc()) means that in particular > > > > >>>> graphics frame buffer accesses would have been quite a bit less > > > > >>>> performant than possible. > > > > >>>> > > > > >>>> Arrange for the function to return true in such environments, without > > > > >>>> undermining the rest of PAT MSR management logic considering PAT to be > > > > >>>> disabled: Specifically, no writes to the PAT MSR should occur. > > > > >>>> > > > > >>>> For the new boolean to live in .init.data, init_cache_modes() also needs > > > > >>>> moving to .init.text (where it could/should have lived already before). > > > > >>>> > > > > >>>> Signed-off-by: Jan Beulich > > > > >>> > > > > >>> The Linux kernel regression tracker is pestering me because things are > > > > >>> taking so long (effectively quoting him), and alternative proposals > > > > >>> made so far look to have more severe downsides. > > > > >> > > > > >> Has any progress been made with this patch? It afaics is meant to fix > > > > >> this regression, which ideally should have been fixed weeks ago (btw: > > > > >> adding a "Link:" tag pointing to it would be good): > > > > >> https://lore.kernel.org/regressions/YnHK1Z3o99eMXsVK@mail-itl/ > > > > >> > > > > >> According to Juergen it's still needed: > > > > >> https://lore.kernel.org/lkml/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > > > >> > > > > >> Or was a different solution found to fix that regression? > > > > > > > > > > No progress and no alternatives I'm aware of. > > > > > > > > Getting closer to the point where I need to bring this to Linus > > > > attention. I hope this mail can help avoiding this. > > > > > > > > Jan, I didn't follow this closely, but do you have any idea why Dave, > > > > Luto, and Peter are ignoring this? Is reverting bdd8b6c98239 a option to > > > > get the regression fixed? Would a repost maybe help getting this rolling > > > > again? > > > > > > Hi, Thorsten, > > > > > > Here is a link to the hardware probe of my system which exhibits > > > a system hang before fully booting with bdd8b6c98239. Without > > > bdd8b6c98239, the problem is gone: > > > > > > https://linux-hardware.org/?probe=32e615b538 > > > > > > Keep in mind this problem is not seen with bdd8b6c98239 > > > on the bare metal, but only when running as a traditional Dom0 > > > PV type guest on Xen. I don't know see the problem on Xen HVM > > > DomU, and I have not tested it on Xen PVH DomU, Xen PV DomU, > > > or the experimental Xen PVH Dom0. > > > > Update: On affected hardware, you do not need to run in a > > Xen PV Dom0 to see the regression caused by bdd8b6c98239. > > > > All you need to do is run, on the bare metal, on the affected > > hardware, with the Linux kernel nopat boot option. > > > > Jan mentions in his commit message the function in the i915 > > driver that was touched by bdd8b6c98239 and that causes this > > regression. That is, any Intel IGD that needs to execute the > > function that Jan mentions in the commit message of his > > proposed patch when the i915 driver is setting up the graphics > > engine will most likely be hardware that is affected. My Intel > > IGD was marketed as HD Graphics 4600, I think. > > > > So find an a system with these hardware characteristics, and > > try running, with the nopat option, the Linux kernel, with > > and without bdd8b6c98239. You will see the regression I > > am experiencing, I predict. > > This raises a disturbing question: The commit message of > bdd8b6c98239 mentions the nopat option. It does not specify what > effect the commit was supposed to have on system > with the nopat option, but the actual effect on the system, > both with the seldom used nopat option and in Xen PV Dom0, > a nasty regression on some older Intel IGD devices. My question: > > Was this intentional? Or just grossly incompetent? Any other > possibilities? After reading more of the discussions on lkml, I suppose Intel decided a regression affecting older Intel IGDs running on Xen would not affect enough users to cause a serious problem. I just happen to be one of the few users affected by it. I understand I cannot expect Intel to support its older devices forever, even if Linus' regression rule would seem to suggest that on Linux older devices need to continue to be supported for as long as is reasonably possible. In any case, I can see that efforts are still underway to fix this regression, not from Intel, but from maintainers of x86 and Xen kernel code, and that is what is necessary if the Linus regression rule applies even when just a few users are affected by a regression. While waiting for a fix in the mainline kernel, affected users can revert bdd8b6c98239 on top of the released kernel versions as the most simple workaround for this regression. Chuck > > I think you should definitely notify Linus about this if you can > verify the story I am telling here. > > Chuck > > > > > Chuck > > > > > > > > You can probably verify yourself that reverting bdd8b6c98239 > > > fixes the regression if you try to reproduce the regression with > > > any Linux version that has bdd8b6c98239 or its equivalent on > > > the stable branches with a hardware profile similar to the link > > > to the profile of my machine which exhibits the problem. Mine > > > is a Haswell core-i5 4590S CPU and ASRock B85M-Pro4 > > > motherboard. > > > > > > Also, other notes: > > > > > > 1. Yes, AFAICT, Marek at Qubes OS is the first to report the problem. > > > 2. Juergen Gross' work to try to fix this has been helpful, but none > > > of his posted patches has fixed the regression on my system. > > > 3. Jan's patch fixes it also, and so do the two patches I posted to lkml > > > earlier this week to the appropriate maintainers. > > > 4. On the pkg-xen-devel mailing list, which is public, this issue was > > > briefly discussed where I first reported it. Someone there said they > > > did not see the issue with Broadwell Xeons. Mine is a Haswell core i5, > > > which is one generation older than Broadwell, so you are most likely > > > to be able to reproduce the problem with a Haswell core i5 desktop > > > system like my ASRock system, which was my own private build > > > which has been working fine for eight years until Linux 5.17.y. > > > > > > Hope this helps. > > > > > > Chuck > > > > > > > BTW, for anyone new to this, Jan's patch afaics is supposed to fix the > > > > regression reported here: > > > > https://lore.kernel.org/all/YnHK1Z3o99eMXsVK@mail-itl/ > > > > > > > > Side note: Juergen Gross recently posted related patches in this code > > > > area to fix some other problems (regressions?), but his efforts look > > > > stalled, too: > > > > https://lore.kernel.org/all/ddb0cc0d-cefc-4f33-23f8-3a94c7c51a49@suse.com/ > > > > > > > > And he recently stated this Jan's patch is still needed, even if his > > > > changes make it in. > > > > https://lore.kernel.org/all/c5515533-29a9-9e91-5a36-45f00f25b37b@suse.com/ > > > > > > > > This from my point all looks a bit... unsatisfying. :-/ > > > > > > > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > > > > > > > P.S.: As the Linux kernel's regression tracker I deal with a lot of > > > > reports and sometimes miss something important when writing mails like > > > > this. If that's the case here, don't hesitate to tell me in a public > > > > reply, it's in everyone's interest to set the public record straight. > > > > > > > > From xen-devel-bounces@lists.xenproject.org Tue Jul 19 14:49:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 14:49:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370730.602594 (Exim 4.92) (envelope-from ) id 1oDoWu-0007GL-7T; Tue, 19 Jul 2022 14:48:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370730.602594; Tue, 19 Jul 2022 14:48:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoWu-0007GE-4K; Tue, 19 Jul 2022 14:48:56 +0000 Received: by outflank-mailman (input) for mailman id 370730; Tue, 19 Jul 2022 14:48:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoWt-0007G4-2V; Tue, 19 Jul 2022 14:48:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoWt-0001fB-06; Tue, 19 Jul 2022 14:48:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDoWs-00089D-IN; Tue, 19 Jul 2022 14:48:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDoWs-0005LG-Ht; Tue, 19 Jul 2022 14:48:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Xq/Uv3/bXo4b3mWuNU0DVmcCXOhHsuF58kMGgqKe3yg=; b=Jtt7P9rrho9u/6KA6vXDisqhfu Yilj5zrfR+xFLVEkOz0c8WF+ub6kYcFz418ISVeYlxzBnQnT8CchcmGEvUVnOCBKsvGcPx4woUcB/ SLuFw2NpFDhBKM6fMvYVL2gclXvyVZjvCQCdqEShcoCeh3Uzq5hFCy0mzSuhZKMXfq1s=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171685: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=e500b6b8d07f87593a9d0e3a391456ef4ac5ee34 X-Osstest-Versions-That: xen=9723507daf2120131410c91980d4e4d9b0d0aa90 From: osstest service owner Date: Tue, 19 Jul 2022 14:48:54 +0000 flight 171685 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171685/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen e500b6b8d07f87593a9d0e3a391456ef4ac5ee34 baseline version: xen 9723507daf2120131410c91980d4e4d9b0d0aa90 Last test of basis 171682 2022-07-19 07:06:21 Z 0 days Testing same since 171685 2022-07-19 11:03:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Elliott Mitchell Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 9723507daf..e500b6b8d0 e500b6b8d07f87593a9d0e3a391456ef4ac5ee34 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 19 15:15:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 15:15:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370738.602606 (Exim 4.92) (envelope-from ) id 1oDowa-0002Th-EB; Tue, 19 Jul 2022 15:15:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370738.602606; Tue, 19 Jul 2022 15:15:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDowa-0002Ta-9A; Tue, 19 Jul 2022 15:15:28 +0000 Received: by outflank-mailman (input) for mailman id 370738; Tue, 19 Jul 2022 15:15:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDowV-0002TU-1x for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 15:15:26 +0000 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a866dfd-0775-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 17:15:20 +0200 (CEST) Received: from zn.tnic (p200300ea97297609329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:9729:7609:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id A7AEA1EC050F; Tue, 19 Jul 2022 17:15:15 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a866dfd-0775-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1658243715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=19tyF3hcmEXgvgnp46r5wyMNhL+B65efr3ypQp+I6Lc=; b=bgi94v/2BF7PUNqG8xmemrFZBnufFiYdPdUaAnPFw21wpY2AenhYjpMtVIXjal1w+mzOf/ /mJpaBLsrk1CG9OmmXyV1Mk42F2fLkopvrYioaM30O2wLjdfezvPIdmQCQWST61U2bwz0K 8qYCxwZHFYMHLQZMFQVOq4Y1vdDkO/E= Date: Tue, 19 Jul 2022 17:15:11 +0200 From: Borislav Petkov To: Juergen Gross Cc: xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, brchuckz@netscape.net, jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky , stable@vger.kernel.org Subject: Re: [PATCH 3/3] x86: decouple pat and mtrr handling Message-ID: References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-4-jgross@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220715142549.25223-4-jgross@suse.com> On Fri, Jul 15, 2022 at 04:25:49PM +0200, Juergen Gross wrote: > Today PAT is usable only with MTRR being active, with some nasty tweaks > to make PAT usable when running as Xen PV guest, which doesn't support > MTRR. > > The reason for this coupling is, that both, PAT MSR changes and MTRR > changes, require a similar sequence and so full PAT support was added > using the already available MTRR handling. > > Xen PV PAT handling can work without MTRR, as it just needs to consume > the PAT MSR setting done by the hypervisor without the ability and need > to change it. This in turn has resulted in a convoluted initialization > sequence and wrong decisions regarding cache mode availability due to > misguiding PAT availability flags. > > Fix all of that by allowing to use PAT without MTRR and by adding an > environment dependent PAT init function. Aha, there's the explanation I was looking for. > diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c > index 0a1bd14f7966..3edfb779dab5 100644 > --- a/arch/x86/kernel/cpu/common.c > +++ b/arch/x86/kernel/cpu/common.c > @@ -2408,8 +2408,8 @@ void __init cache_bp_init(void) > { > if (IS_ENABLED(CONFIG_MTRR)) > mtrr_bp_init(); > - else > - pat_disable("PAT support disabled because CONFIG_MTRR is disabled in the kernel."); > + > + pat_cpu_init(); > } > > void cache_ap_init(void) > @@ -2417,7 +2417,8 @@ void cache_ap_init(void) > if (cache_aps_delayed_init) > return; > > - mtrr_ap_init(); > + if (!mtrr_ap_init()) > + pat_ap_init_nomtrr(); > } So I'm reading this as: if it couldn't init AP's MTRRs, init its PAT. But currently, the code sets the MTRRs for the delayed case or when the CPU is not online by doing ->set_all and in there it sets first MTRRs and then PAT. I think the code above should simply try the two things, one after the other, independently from one another. And I see you've added another stomp machine call for PAT only. Now, what I think the design of all this should be, is: you have a bunch of things you need to do at each point: * cache_ap_init * cache_aps_init * ... Now, in each those, you look at whether PAT or MTRR is supported and you do only those which are supported. Also, the rendezvous handler should do: if MTRR: do MTRR specific stuff if PAT: do PAT specific stuff This way you have clean definitions of what needs to happen when and you also do *only* the things that the platform supports, by keeping the proper order of operations - I believe MTRRs first and then PAT. This way we'll get rid of that crazy maze of who calls what and when. But first we need to define those points where stuff needs to happen and then for each point define what stuff needs to happen. How does that sound? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette From xen-devel-bounces@lists.xenproject.org Tue Jul 19 16:37:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 16:37:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370753.602616 (Exim 4.92) (envelope-from ) id 1oDqDt-0004AZ-9V; Tue, 19 Jul 2022 16:37:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370753.602616; Tue, 19 Jul 2022 16:37:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqDt-0004AS-5U; Tue, 19 Jul 2022 16:37:25 +0000 Received: by outflank-mailman (input) for mailman id 370753; Tue, 19 Jul 2022 16:37:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqDr-0004AM-Dt for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 16:37:23 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0dbf8384-0781-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 18:37:20 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658248634568315.9538041364176; Tue, 19 Jul 2022 09:37:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0dbf8384-0781-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1658248636; cv=none; d=zohomail.com; s=zohoarc; b=M+KtG0SQGD5c4Yc5uAfdIV0yf1vj9Lk0YE09+/f112XEJjVFomiX7t7LtqmOhTb08v49uEz30B4TJHh40YT/KLBQ+ZOpuDErpClLKoLphhaQqsmWkmZ7QG+n4zD5cqP3cX4tEwc5/W65jZfFjGJtiTXr8eqi+Skj3b9uGYSk4iM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658248636; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=bjrTTcX2WxDg7VEE5uCHADJqFBNUYF9tPGumG+FeAWY=; b=M2GL0/17tGhuooUB/gUHr3Q3sBGioof4CDrdwy9CVj1SUN0/vzJGgfH1GpMdH2lBvwd0zk7sPA9rvEQjDBxY11TtT3HuTkNvFP7C4uv36WkD71ry6a9UtQhmR9cKPCBPiLQKCz3EUr9OkIYJnMsMqPW8FYz5SzSMI19uvZPWGY0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658248636; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=bjrTTcX2WxDg7VEE5uCHADJqFBNUYF9tPGumG+FeAWY=; b=Qj2i2P/dCLJFT5ePBTAJpxa/UUK4e/AF44pbydE0ejUxtk17HFhx/W97SOYZvfKH AwksQaRcCZeoiWjXK4FEdnfnPmPmNIef3ysjkC0uRv252mDvs5y/6wK/9zzVzhKJgLQ mEEB8iKseWQt8wv3VBaN6h3Ywe1bebrMYnHqCgOo= Message-ID: <78c3f88a-4f36-087d-31b1-d02bfbc8df30@apertussolutions.com> Date: Tue, 19 Jul 2022 12:36:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 7/15/22 15:16, Julien Grall wrote: > Hi Daniel, > > On 06/07/2022 22:04, Daniel P. Smith wrote: >> For x86 the number of allowable multiboot modules varies between the >> different >> entry points, non-efi boot, pvh boot, and efi boot. In the case of >> both Arm and >> x86 this value is fixed to values based on generalized assumptions. With >> hyperlaunch for x86 and dom0less on Arm, use of static sizes results >> in large >> allocations compiled into the hypervisor that will go unused by many >> use cases. >> >> This commit introduces a Kconfig variable that is set with sane >> defaults based >> on configuration selection. This variable is in turned used as the >> array size >> for the cases where a static allocated array of boot modules is declared. >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Christopher Clark > > I am not entirely sure where this reviewed-by is coming from. Is this > from internal review? Yes. > If yes, my recommendation would be to provide the reviewed-by on the > mailing list. Ideally, the review should also be done in the open, but I > understand some company wish to do a fully internal review first. Since this capability is being jointly developed by Christopher and I, with myself being the author of code, Christopher reviewed the code as the co-developer. He did so as a second pair of eyes for any obvious mistakes and to concur that the implementation was in line with the approach the two of us architected. Perhaps a SoB line might be more appropriate than an R-b line. > At least from a committer perspective, this helps me to know whether the > reviewed-by still apply. An example would be if you send a v2, I would > not be able to know whether Christoffer still agreed on the change. If an SoB line is more appropriate, then on the next version I can switch it >> --- >>   xen/arch/Kconfig                  | 12 ++++++++++++ >>   xen/arch/arm/include/asm/setup.h  |  5 +++-- >>   xen/arch/x86/efi/efi-boot.h       |  2 +- >>   xen/arch/x86/guest/xen/pvh-boot.c |  2 +- >>   xen/arch/x86/setup.c              |  4 ++-- >>   5 files changed, 19 insertions(+), 6 deletions(-) >> >> diff --git a/xen/arch/Kconfig b/xen/arch/Kconfig >> index f16eb0df43..24139057be 100644 >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -17,3 +17,15 @@ config NR_CPUS >>         For CPU cores which support Simultaneous Multi-Threading or >> similar >>         technologies, this the number of logical threads which Xen will >>         support. >> + >> +config NR_BOOTMODS >> +    int "Maximum number of boot modules that a loader can pass" >> +    range 1 32768 >> +    default "8" if X86 >> +    default "32" if ARM >> +    help >> +      Controls the build-time size of various arrays allocated for >> +      parsing the boot modules passed by a loader when starting Xen. >> + >> +      This is of particular interest when using Xen's hypervisor domain >> +      capabilities such as dom0less. >> diff --git a/xen/arch/arm/include/asm/setup.h >> b/xen/arch/arm/include/asm/setup.h >> index 2bb01ecfa8..312a3e4209 100644 >> --- a/xen/arch/arm/include/asm/setup.h >> +++ b/xen/arch/arm/include/asm/setup.h >> @@ -10,7 +10,8 @@ >>     #define NR_MEM_BANKS 256 >>   -#define MAX_MODULES 32 /* Current maximum useful modules */ >> +/* Current maximum useful modules */ >> +#define MAX_MODULES CONFIG_NR_BOOTMODS >>     typedef enum { >>       BOOTMOD_XEN, >> @@ -38,7 +39,7 @@ struct meminfo { >>    * The domU flag is set for kernels and ramdisks of "xen,domain" nodes. >>    * The purpose of the domU flag is to avoid getting confused in >>    * kernel_probe, where we try to guess which is the dom0 kernel and >> - * initrd to be compatible with all versions of the multiboot spec. >> + * initrd to be compatible with all versions of the multiboot spec. > > In general, I much prefer if coding style changes are done separately > because it helps the review (I don't have to stare at the line to figure > out what changed). Actually, on a past review of another series I got dinged on this, and I did try to get most of them out of this series. This is just a straggler that I missed. I will clean up on next revision. > I am not going to force this here. However, the strict minimum is to > mention the change in the commit message. > >>    */ >>   #define BOOTMOD_MAX_CMDLINE 1024 >>   struct bootmodule { >> diff --git a/xen/arch/x86/efi/efi-boot.h b/xen/arch/x86/efi/efi-boot.h >> index 6e65b569b0..4e1a799749 100644 >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { >>    * The array size needs to be one larger than the number of modules we >>    * support - see __start_xen(). >>    */ >> -static module_t __initdata mb_modules[5]; >> +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; > > Please explain in the commit message why the number of modules was > bumped from 5 to 9. The number of modules were inconsistent between the different entry points into __start_xen(). By switching to a Kconfig variable, whose default was set to the largest value used across the entry points, results in change for the locations using another value. See below for +1 explanation. >>     static void __init edd_put_string(u8 *dst, size_t n, const char *src) >>   { >> diff --git a/xen/arch/x86/guest/xen/pvh-boot.c >> b/xen/arch/x86/guest/xen/pvh-boot.c >> index 498625eae0..834b1ad16b 100644 >> --- a/xen/arch/x86/guest/xen/pvh-boot.c >> +++ b/xen/arch/x86/guest/xen/pvh-boot.c >> @@ -32,7 +32,7 @@ bool __initdata pvh_boot; >>   uint32_t __initdata pvh_start_info_pa; >>     static multiboot_info_t __initdata pvh_mbi; >> -static module_t __initdata pvh_mbi_mods[8]; >> +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; > > What's the +1 for? I should clarify in the commit message, but the value set in CONFIG_NR_BOOTMOD is the max modules that Xen would accept from a bootloader. Xen startup code expects to be able to append Xen itself as the array. The +1 allocates an additional entry to store Xen in the array should a bootloader actually pass CONFIG_NR_BOOTMOD modules to Xen. There is an existing comment floating in one of these locations that explained it. >>   static const char *__initdata pvh_loader = "PVH Directboot"; >>     static void __init convert_pvh_info(multiboot_info_t **mbi, >> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >> index f08b07b8de..2aa1e28c8f 100644 >> --- a/xen/arch/x86/setup.c >> +++ b/xen/arch/x86/setup.c >> @@ -1020,9 +1020,9 @@ void __init noreturn __start_xen(unsigned long >> mbi_p) >>           panic("dom0 kernel not specified. Check bootloader >> configuration\n"); >>         /* Check that we don't have a silly number of modules. */ >> -    if ( mbi->mods_count > sizeof(module_map) * 8 ) >> +    if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) >>       { >> -        mbi->mods_count = sizeof(module_map) * 8; >> +        mbi->mods_count = CONFIG_NR_BOOTMODS; >>           printk("Excessive multiboot modules - using the first %u >> only\n", >>                  mbi->mods_count); >>       } > > AFAIU, this check is to make sure that we will not overrun module_map in > the next line: > > bitmap_fill(module_map, mbi->mods_count); > > The current definition of module_map will allow 64 modules. But you are > allowing 32768. So I think you either want to keep the check or define > module_map as: > > DECLARE_BITMAP(module_map, CONFIG_NR_BOOTMODS); Yes, in the RFC I had it capped to 64 and lost track of this related changed when it was bumped to 32768 per the review discussion. Later in the series, module_map goes away. To ensure stability at this point I would be inclined to restore the 64 module clamp down check. Thoughts? v/r, dps From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:00:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:00:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370760.602627 (Exim 4.92) (envelope-from ) id 1oDqa1-0007jC-2y; Tue, 19 Jul 2022 17:00:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370760.602627; Tue, 19 Jul 2022 17:00:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqa0-0007j5-Vq; Tue, 19 Jul 2022 17:00:16 +0000 Received: by outflank-mailman (input) for mailman id 370760; Tue, 19 Jul 2022 17:00:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqZz-0007iv-Gh; Tue, 19 Jul 2022 17:00:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqZz-0004RB-CR; Tue, 19 Jul 2022 17:00:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqZz-0005xW-3J; Tue, 19 Jul 2022 17:00:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDqZz-0007oa-2o; Tue, 19 Jul 2022 17:00:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=P/3KIQdeEBwlSDFoZic66XyIh+gVmDe2kGl7G5IN3e8=; b=NdkE0Hggp10GWW2JwcyC7dAG9M e/+IdAoV2c/feNo/ip/StjaSNs3hP9B8cZBznPGn+U7UT7yQE10EMgLxHjQ0lpLKz0sg0RMu8RMrg Yt6lHrxKaBmi6snfjqWDDX716OpTzNXuBBDDqKu35vPa/PCm595ODs5a5ky+6RW+IRu8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171681: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=ca85855bdcae8f84f1512e88b4c75009ea17ea2f X-Osstest-Versions-That: linux=ff6992735ade75aae3e35d16b17da1008d753d28 From: osstest service owner Date: Tue, 19 Jul 2022 17:00:15 +0000 flight 171681 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171681/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171664 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171664 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171664 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171664 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171664 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171664 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171664 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171664 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171664 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux ca85855bdcae8f84f1512e88b4c75009ea17ea2f baseline version: linux ff6992735ade75aae3e35d16b17da1008d753d28 Last test of basis 171664 2022-07-17 21:11:10 Z 1 days Failing since 171674 2022-07-18 19:40:02 Z 0 days 2 attempts Testing same since 171681 2022-07-19 04:40:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andy Shevchenko Bartosz Golaszewski Dipen Patel Jason Gunthorpe Linus Torvalds Mustafa Ismail Shiraz Saleem Thierry Reding jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ff6992735ade..ca85855bdcae ca85855bdcae8f84f1512e88b4c75009ea17ea2f -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:02:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:02:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370768.602638 (Exim 4.92) (envelope-from ) id 1oDqcW-0008Oy-Jf; Tue, 19 Jul 2022 17:02:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370768.602638; Tue, 19 Jul 2022 17:02:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqcW-0008Or-H3; Tue, 19 Jul 2022 17:02:52 +0000 Received: by outflank-mailman (input) for mailman id 370768; Tue, 19 Jul 2022 17:02:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqcV-0008Oj-Hn for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:02:51 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9e0eb89f-0784-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:02:50 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658250165034752.3988518718096; Tue, 19 Jul 2022 10:02:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9e0eb89f-0784-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658250165; cv=none; d=zohomail.com; s=zohoarc; b=CFLDJd9Em1jJv336mdg6zkqAoal+0XG/iDEv6+FahkoCwdw8KCn/xt7fiftNYX2pRZMgppKVlpj4JKD1nuzcVrGZs2GVIKLN8o+hlXacIclChrnPxlHoHmjgAtxO7hNgsPyAGA+F3ktxREfQpQQgQHIiQsGFpgv2kIVmj6EHHbA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658250165; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fnOF9r7CK5QX0xoHgOGE+YFAoCHf4C2TBzNsgNwS9pE=; b=hR7DLx03UXUvk7IhnytKgaWXCJ/w3pEmes+cAivVjwdOIWeYZW6+2h7gquZIS+2yDeKhzl5vZQyDUknd2QSBJoFdi6k69zymNvKpXznecG2ivKoFcCHShrquj0kvfvIx22xf3aVUwo0ryyemDC7KscunBMkflZY5dcfujqhxqOQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658250165; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=fnOF9r7CK5QX0xoHgOGE+YFAoCHf4C2TBzNsgNwS9pE=; b=MZiNnkEXi/7r+pk6cbY+Zebyr+kzpErHg7GGcWxoPmmV9Lnn6KxKkQbfP8nzyIjn d5vjlBr4W4hEWF/D/Tkx/9JPVPBmTRC1pKJQ5MljMNkGPuOY2jl0bmLfZSmd3dltjB9 z8kYUmSK2jLO3IFgqY6Ys9o/i5o6eZx9tHhjG5cw= Message-ID: Date: Tue, 19 Jul 2022 13:02:24 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> <59114d3a-b9fe-1fb0-fac3-fe14fe4c505f@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules In-Reply-To: <59114d3a-b9fe-1fb0-fac3-fe14fe4c505f@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 05:32, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- a/xen/arch/Kconfig >> +++ b/xen/arch/Kconfig >> @@ -17,3 +17,15 @@ config NR_CPUS >> For CPU cores which support Simultaneous Multi-Threading or similar >> technologies, this the number of logical threads which Xen will >> support. >> + >> +config NR_BOOTMODS >> + int "Maximum number of boot modules that a loader can pass" >> + range 1 32768 >> + default "8" if X86 >> + default "32" if ARM > > Any reason for the larger default on Arm, irrespective of dom0less > actually being in use? (I'm actually surprised I can't spot a Kconfig > option controlling inclusion of dom0less. The default here imo isn't > supposed to depend on the architecture, but on whether dom0less is > supported. That way if another arch gained dom0less support, the > higher default would apply to it without needing further adjustment.) Yes, multidomain construction is always on for Arm and the only configurable is a commandline parameter to enforce that dom0 is not created. As for the default, it was selected based on the largest value used in the locations replaced by the Kconfig variable. Since there was a significant difference between Arm and x86, I did not feel it was appropriate to reduce/increase either, since it drives multiple static array allocations for x86. I have no attachments to any specific value, so I will freely adjust to whatever conscience the community might come to. >> --- a/xen/arch/x86/efi/efi-boot.h >> +++ b/xen/arch/x86/efi/efi-boot.h >> @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { >> * The array size needs to be one larger than the number of modules we >> * support - see __start_xen(). >> */ >> -static module_t __initdata mb_modules[5]; >> +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; > > If the build admin selected 1, I'm pretty sure about nothing would work. > I think you want max(5, CONFIG_NR_BOOTMODS) or > max(4, CONFIG_NR_BOOTMODS) + 1 here and ... Actually, I reasoned this out and 1 is in fact a valid value. It would mean Xen + Dom0 Linux kernel with embedded initramfs with no externally loaded XSM policy and no boot time microcode patching. This is a working configuration, but open to debate if it is a desirable configuration. The question is whether it is desired to block someone from building such a configuration, or any number between 1 and 4. If the answer is yes, then why not just set the lower bound of the range in the Kconfig file instead of having to maintain a hard-coded lower bound in a max marco across multiple locations? >> --- a/xen/arch/x86/guest/xen/pvh-boot.c >> +++ b/xen/arch/x86/guest/xen/pvh-boot.c >> @@ -32,7 +32,7 @@ bool __initdata pvh_boot; >> uint32_t __initdata pvh_start_info_pa; >> >> static multiboot_info_t __initdata pvh_mbi; >> -static module_t __initdata pvh_mbi_mods[8]; >> +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; > > ... max(8, CONFIG_NR_BOOTMODS) here (albeit the 8 may have room for > lowering - I don't recall why 8 was chosen rather than going with > the minimum possible value covering all module kinds known at that > time). This is what drove the default for x86 in Kconfig to be 8. I thought it was excessive but assumed there was some reason for the value. And see my comment above whether it should be max({n},CONFIG_NR_BOOTMOD) vs range {n}..32768. From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:06:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:06:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370775.602649 (Exim 4.92) (envelope-from ) id 1oDqg5-0000di-3i; Tue, 19 Jul 2022 17:06:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370775.602649; Tue, 19 Jul 2022 17:06:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqg5-0000d7-0Y; Tue, 19 Jul 2022 17:06:33 +0000 Received: by outflank-mailman (input) for mailman id 370775; Tue, 19 Jul 2022 17:06:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqg3-0000cM-8a for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:06:31 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0107.outbound.protection.office365.us [23.103.209.107]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2096b11f-0785-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 19:06:29 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1418.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:181::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Tue, 19 Jul 2022 17:06:26 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%3]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 17:06:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2096b11f-0785-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=Tuza4z5t8AM6Jr0P/j+p9kgWGG2YCZTbhO7N02iiu2YK+8LtAhe/TV/qi/lp/p+oj3TG8OGoOG8p73EFaKMXC7y3v1xPiSHygY65z5lhEttyg7vIYmNCaR+syW80ceLQIzMHgbecMny+a/5DSNHap9oLW8S+o2oYN0dANFXGv2By0xGxIeAqEYF8NLopy/7qKATwf3og9jYNdbnf7hWEq9JxEHRk6hjeIQjUm6Rcr6D8W5PtleryJhLopphLWBNuMsCzjlP7VYSp6uMEeOypoXh9q+C1xo7erhTwwQ8rCFeSXAoHmgQEU8ZWWT3R/r8nv2YrX5iTQ5ZrY4Ebkv0nBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=i6te3jQ3p/QWgcuoyD3zoTgKMYHVzI6raRHg9aEQR3A=; b=uMdMEaWw5OnlbxaDPm0YUA55Ld2IE9XncrQCmHZ7I8/yIQZT7Wqkie01u+KxRNUzSWyqd3uxpSp7KOvquenR/uYvc6e4aS7d7YLMCmVY17SooOiD0OeJNmcoaJMurwE+TWNotB+R1EJEyIa7vWjHREZOh3bnfQAasLk+OmwgqzAFPOV8I9z3PlLbvWxS9dU5XGfY9d84LqQlNg8thMlRbfvAF0K26N6qh9GbJ01M1a662cCxevSRnlXogZwFAATMXE3n46ffXdBSeUJunW6jQVeVj9jN0HqVqxvWIpVNCz3ocTiobMW2+pqmIoda3BpJ0GJdHWOgC97JVt+oWijGdg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i6te3jQ3p/QWgcuoyD3zoTgKMYHVzI6raRHg9aEQR3A=; b=EZo3bI5kI9j04nVMi3wA1DLrV2p2LVoeEiO4sBJZGCbVFbYQwWt6eOxb1GFpcuTus/Sj1IvZl4EE3NSuzRm+phL7ZZFw0NCok50oM7bmoCDwZOgNq4WY4c96BR/4FBjaY6TmwiiX+dkf2c34nSTAy9DLCvY2fYNDcpBljxs6uQOAU0J0lLTmFv0jh6Nr/4pa6e3ZLd9z7Mmo/qXebfmFzIXWEhG8FaMisvEHcrPIXzGCe5jtVTVcGL3J92iA0zN0X9Q0gcDZZ11O1L62HgxQ84tb6R4TAXZ/VzhPIHNcAlj8OpcmFbcd19ITBSEMSG/7ljPq9dsJWemZRIMOwdIfZQ== From: "Smith, Jackson" To: "Daniel P. Smith" , "xen-devel@lists.xenproject.org" CC: "scott.davis@starlab.io" , "christopher.clark@starlab.io" Subject: RE: [PATCH v1 00/18] Hyperlaunch Thread-Topic: [PATCH v1 00/18] Hyperlaunch Thread-Index: AQHDrne88XyYXkgxTAt6TFUls0rRYK2vvfVA Date: Tue, 19 Jul 2022 17:06:26 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> In-Reply-To: <20220706210454.30096-1-dpsmith@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8d93e4e1-fc7e-4bf3-6dd9-08da69a903df x-ms-traffictypediagnostic: BN0P110MB1418:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8pzMy4DoeACj9hNnC4atV3e6N9figjCLk7PM1Z9UkKR3qVDDZf+DaEftbMt7zV08e4E0n1d/2qotN+CIUjgdxcU3wK6vrUqT850TmHgpFpxaoDwPH8MngZUGUdjpCMexiTlz0mG08qyFuTz8LWo3pSiM0gh8KSuf8me4hV5n1E53s5cj7txGwSHzRSRvI4BoIiOFoA1R/5MIV7YnQNTdBVqSEQoDNwD1E+Oz/n6FwIM9A6ErbmrXbTWmm66iJlLcOb/XlIM1nJ9BKif0IrZtgzPagpqtg+txwwsK1JIYtFTLfRpv4KWdoyrbCii1+9tA2GBNFyV1tLpxbulQ/pJPjFOEvC4zHh42DEmU0ocvau/ezFdOWKvZ9GQiH+vf6bg2LoDRxRPZH+Y7h22pKdqxuWMVkffm1HK2MFgAffncGVnIxzzvOdzLeKf2kY4YjGaiupOu/lLf9etgHiEnccksNdWmDXwpOwot5C24TQYJe3KaKtZ+HQAnehJLHP3I4LBfsyilOrqbhZvyFBEUXVE4x/1OllcVCiQg4l0BeZZrQ+i0j24GSydIvMLunrDnT+GPDjSyESXJ2te76gEu3GgT1/UdUkev0miuZzyyAqRguELdy4ARgN1W1STTLDMcz0ZIMi+TVMsirvwuMRjnLkSTH9o04O0T/yN2FVm2jOFcESR3A3N+jHwMHTOg43ihX6ZmBuuZkjwOFpcCmFa05AGNfws6bcPKRhcPODRMqpZg4os1m6BEybUsPiwn7KIMdR++ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(55016003)(2906002)(54906003)(76116006)(33656002)(5660300002)(52536014)(8936002)(8676002)(66556008)(4326008)(66446008)(66946007)(64756008)(110136005)(66476007)(6506007)(83380400001)(71200400001)(122000001)(498600001)(82960400001)(86362001)(7696005)(38100700002)(186003)(9686003)(26005)(38070700005)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: uMuNJL4aJojtcz9JVyZJJklEM/L3Mf7Xm9PO0gOqkL1fa3bxshF92D6H+7JUNiHOVy6T1czrxVUzcAectYgrKFQfHl4HCNkEihzJIWQterD/lencuL8W4TUSvs1JyBtBJ+VBj8v9UzaseKa/rngq0XXAOwcy/wITZMN9kkqkGE0h5c7h6stdqX7ua4NP9shciPgpMhzr+7JobDnynJRJnWkRNll4ZFKegiQ+43XFKQofU9Gy676neH1OzIUL5+XCFsa3o06mbavTIQb7ntJoVIkDpN25qRM1xoUyrXpz5Z31zCbGjVauhW58/iZBPQnhDnt5ivIeo2EuMforM3VwG5T6bjsR2EYkOrEU7NkJuKWemcZQPmYag2ww6fPzFBuShvwbKLtMuZWq/5Nq/xCXnHNa7htLdpB2oQNDiL8yal4= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 8d93e4e1-fc7e-4bf3-6dd9-08da69a903df X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 17:06:26.1397 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1418 Hi Daniel, > -----Original Message----- > Subject: [PATCH v1 00/18] Hyperlaunch With the adjustments that I suggested in other messages, this patch builds = and boots for me on x86 (including a device tree with a domU). I will conti= nue to poke around and see if I discover any other rough edges. One strange behavior I see is that xen fails to start the Dom0 kernel on a = warm reboot. I'm using qemu_system_x86 with the KVM backend to test out the= patch. After starting qemu, xen will boot correctly only once. If I attemp= t to reboot the virtual system (through the 'reboot' command in dom0 or the= 'system_reset' qemu monitor command) without exiting/starting a new qemu p= rocess on the host machine, xen panics while booting after printing this: (XEN) *** Building Dom0 *** (XEN) Dom0 has maximum 856 PIRQs (XEN) *** Constructing a PV Dom0 *** (XEN) ELF: not an ELF binary (XEN) (XEN) **************************************** (XEN) Panic on CPU 0: (XEN) Could not construct domain 0 (XEN) **************************************** This happens with the BUILDER_FDT config option on and off, and regardless = of what dtb (if any) I pass to xen. I don't see this behavior if I switch b= ack to xen's master branch. Hopefully that explanation made sense. Let me know if I can provide any fur= ther information about my setup. Thanks, Jackson Also, I apologize that my last messages included a digital signature. Shoul= d be fixed now. From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370787.602660 (Exim 4.92) (envelope-from ) id 1oDqrx-0002W1-68; Tue, 19 Jul 2022 17:18:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370787.602660; Tue, 19 Jul 2022 17:18:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqrx-0002Vu-2g; Tue, 19 Jul 2022 17:18:49 +0000 Received: by outflank-mailman (input) for mailman id 370787; Tue, 19 Jul 2022 17:18:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDqrv-0002Vo-HA for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:18:47 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d75ccb72-0786-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:18:45 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 10:18:30 -0700 Received: from jlirvin-mobl5.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.39.211]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 10:18:29 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d75ccb72-0786-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658251125; x=1689787125; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=7OuMzZMeAVedQlxQcpp8HXe51NYN54wYxaB9nOgs/74=; b=nZcs3cFO6ezobCUnFm09uwHQQBbnbDH6wZ6R/LoicPXYKGGVVkP6f7mD 52w/z15u4mo+EcwI0Wv6eB/1zo3P+8SK6QC1WrGu3OiMON1qD497SW4oD KhwZdQymdT/ykmjObbtMbtDTM306Th49nllOSrxJFa+Gx2Pxxh4OAThhs LOURijGgqAq0BgvcXSF1EFkWDtiurU5yjR9DHqwHgmM0YJIKkCXWYJr8d Z7eVOPisBsYyUMi+GjS92cxyZbUJ+NJ78E0FTUC5ujlaS8qa7nQxDam6o eoob1QvRdqxqnHbTZ55sdC3fjD3ody+7apYtEGZICvQ7ne/kWqKB0nMXO A==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="284110682" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="284110682" X-IronPort-AV: E=Sophos;i="5.92,284,1650956400"; d="scan'208";a="924859998" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: [PATCH] xen/mem_sharing: support forks with active vPMU state Date: Tue, 19 Jul 2022 13:18:11 -0400 Message-Id: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the vPMU state from a parent isn't copied to VM forks. To enable the vPMU state to be copied to a fork VM we export certain vPMU functions. First, the vPMU context needs to be allocated for the fork if the parent has one. For this we introduce vpmu->allocate_context, which has previously only been called when the guest enables the PMU on itself. Furthermore, we export vpmu_save_force so that the PMU context can be saved on-demand even if no context switch took place on the parent's CPU yet. Additionally, we make sure all relevant configuration MSRs are saved in the vPMU context so the copy is complete and the fork starts with the same PMU config as the parent. Signed-off-by: Tamas K Lengyel --- xen/arch/x86/cpu/vpmu.c | 12 ++++++++- xen/arch/x86/cpu/vpmu_intel.c | 16 +++++++++++ xen/arch/x86/include/asm/vpmu.h | 5 ++++ xen/arch/x86/mm/mem_sharing.c | 48 +++++++++++++++++++++++++++++++++ 4 files changed, 80 insertions(+), 1 deletion(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index d2c03a1104..2b5d64a60d 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -336,7 +336,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs) #endif } -static void cf_check vpmu_save_force(void *arg) +void cf_check vpmu_save_force(void *arg) { struct vcpu *v = arg; struct vpmu_struct *vpmu = vcpu_vpmu(v); @@ -529,6 +529,16 @@ void vpmu_initialise(struct vcpu *v) put_vpmu(v); } +void vpmu_allocate_context(struct vcpu *v) +{ + struct vpmu_struct *vpmu = vcpu_vpmu(v); + + if ( vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) + return; + + alternative_call(vpmu_ops.allocate_context, v); +} + static void cf_check vpmu_clear_last(void *arg) { if ( this_cpu(last_vcpu) == arg ) diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index 8612f46973..31dc0ee14b 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -282,10 +282,17 @@ static inline void __core2_vpmu_save(struct vcpu *v) for ( i = 0; i < fixed_pmc_cnt; i++ ) rdmsrl(MSR_CORE_PERF_FIXED_CTR0 + i, fixed_counters[i]); for ( i = 0; i < arch_pmc_cnt; i++ ) + { rdmsrl(MSR_IA32_PERFCTR0 + i, xen_pmu_cntr_pair[i].counter); + rdmsrl(MSR_P6_EVNTSEL(i), xen_pmu_cntr_pair[i].control); + } if ( !is_hvm_vcpu(v) ) rdmsrl(MSR_CORE_PERF_GLOBAL_STATUS, core2_vpmu_cxt->global_status); + /* Save MSR to private context to make it fork-friendly */ + else if ( mem_sharing_enabled(v->domain) ) + vmx_read_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + &core2_vpmu_cxt->global_ctrl); } static int cf_check core2_vpmu_save(struct vcpu *v, bool to_guest) @@ -346,6 +353,10 @@ static inline void __core2_vpmu_load(struct vcpu *v) core2_vpmu_cxt->global_ovf_ctrl = 0; wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, core2_vpmu_cxt->global_ctrl); } + /* Restore MSR from context when used with a fork */ + else if ( mem_sharing_is_fork(v->domain) ) + vmx_write_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + core2_vpmu_cxt->global_ctrl); } static int core2_vpmu_verify(struct vcpu *v) @@ -474,7 +485,11 @@ static int core2_vpmu_alloc_resource(struct vcpu *v) sizeof(uint64_t) * fixed_pmc_cnt; vpmu->context = core2_vpmu_cxt; + vpmu->context_size = sizeof(struct xen_pmu_intel_ctxt) + + fixed_pmc_cnt * sizeof(uint64_t) + + arch_pmc_cnt * sizeof(struct xen_pmu_cntr_pair); vpmu->priv_context = p; + vpmu->priv_context_size = sizeof(uint64_t); if ( !has_vlapic(v->domain) ) { @@ -882,6 +897,7 @@ static int cf_check vmx_vpmu_initialise(struct vcpu *v) static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = { .initialise = vmx_vpmu_initialise, + .allocate_context = core2_vpmu_alloc_resource, .do_wrmsr = core2_vpmu_do_wrmsr, .do_rdmsr = core2_vpmu_do_rdmsr, .do_interrupt = core2_vpmu_do_interrupt, diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index e5709bd44a..14d0939247 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -40,6 +40,7 @@ /* Arch specific operations shared by all vpmus */ struct arch_vpmu_ops { int (*initialise)(struct vcpu *v); + int (*allocate_context)(struct vcpu *v); int (*do_wrmsr)(unsigned int msr, uint64_t msr_content); int (*do_rdmsr)(unsigned int msr, uint64_t *msr_content); int (*do_interrupt)(struct cpu_user_regs *regs); @@ -59,6 +60,8 @@ struct vpmu_struct { u32 hw_lapic_lvtpc; void *context; /* May be shared with PV guest */ void *priv_context; /* hypervisor-only */ + size_t context_size; + size_t priv_context_size; struct xen_pmu_data *xenpmu_data; spinlock_t vpmu_lock; }; @@ -106,8 +109,10 @@ void vpmu_lvtpc_update(uint32_t val); int vpmu_do_msr(unsigned int msr, uint64_t *msr_content, bool is_write); void vpmu_do_interrupt(struct cpu_user_regs *regs); void vpmu_initialise(struct vcpu *v); +void vpmu_allocate_context(struct vcpu *v); void vpmu_destroy(struct vcpu *v); void vpmu_save(struct vcpu *v); +void vpmu_save_force(void *arg); int vpmu_load(struct vcpu *v, bool_t from_guest); void vpmu_dump(struct vcpu *v); diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 8f9d9ed9a9..39cd03abf7 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1653,6 +1653,50 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) hvm_set_nonreg_state(cd_vcpu, &nrs); } +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) +{ + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); + + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) + return 0; + if ( !vpmu_is_set(cd_vpmu, VPMU_CONTEXT_ALLOCATED) ) + { + vpmu_allocate_context(cd_vcpu); + if ( !vpmu_is_set(cd_vpmu, VPMU_CONTEXT_ALLOCATED) ) + return -ENOMEM; + } + + /* + * The VPMU subsystem only saves the context when the CPU does a context + * switch. Otherwise, the relevant MSRs are not saved on vmexit. + * We force a save here in case the parent CPU context is still loaded. + */ + if ( vpmu_is_set(d_vpmu, VPMU_CONTEXT_LOADED) ) + { + int pcpu = smp_processor_id(); + + if ( d_vpmu->last_pcpu != pcpu ) + { + on_selected_cpus(cpumask_of(d_vpmu->last_pcpu), + vpmu_save_force, (void *)d_vcpu, 1); + vpmu_reset(d_vpmu, VPMU_CONTEXT_LOADED); + } else + vpmu_save(d_vcpu); + } + + if ( vpmu_is_set(d_vpmu, VPMU_RUNNING) ) + vpmu_set(cd_vpmu, VPMU_RUNNING); + + /* Make sure context gets (re-)loaded when scheduled next */ + vpmu_reset(cd_vpmu, VPMU_CONTEXT_LOADED); + + memcpy(cd_vpmu->context, d_vpmu->context, d_vpmu->context_size); + memcpy(cd_vpmu->priv_context, d_vpmu->priv_context, d_vpmu->priv_context_size); + + return 0; +} + static int copy_vcpu_settings(struct domain *cd, const struct domain *d) { unsigned int i; @@ -1702,6 +1746,10 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d) copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn); } + ret = copy_vpmu(d_vcpu, cd_vcpu); + if ( ret ) + return ret; + hvm_vmtrace_reset(cd_vcpu); copy_vcpu_nonreg_state(d_vcpu, cd_vcpu); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370804.602747 (Exim 4.92) (envelope-from ) id 1oDrFh-00080n-Ft; Tue, 19 Jul 2022 17:43:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370804.602747; Tue, 19 Jul 2022 17:43:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFh-000801-5Q; Tue, 19 Jul 2022 17:43:21 +0000 Received: by outflank-mailman (input) for mailman id 370804; Tue, 19 Jul 2022 17:43:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFf-00065R-4W for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:19 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4614dfb9-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:18 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id y8so20648513eda.3 for ; Tue, 19 Jul 2022 10:43:18 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:16 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4614dfb9-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NQVKGUXCWq6gwb2au9pJADkwFsbt3FsEYw9qYU1cR14=; b=D9S5tYQQeZHWtI9eesc3VZSqYMxyAotVHoWWiJ7yYXf2UlUbz9JY1/YTEO0g6yWeiY UCsW4olncR1OY0PPhWMKYCCGmJIGcnv1JXE7Ls4LWcidv9XU1RYDp0ThkNPxN8/GouGj all35/LcBjtqVPu2CWxYD1ydAvgOTHOjD9SQ5ekMPVm9o47Lqfp5kyt6YHAaH3u69y73 CFqNXyJpq+nWoR2SixcgsPVzGesYfFRXnDR9eoKSadi12IwNeJxpfiXd53HaLxUPfpK5 j/acfgMEh845vECyhcRq4LfK5ADBzdyGyzxBdVEDUlRYE9nKzPWo9lEfhy3HkENZgASF gIfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NQVKGUXCWq6gwb2au9pJADkwFsbt3FsEYw9qYU1cR14=; b=26VWz8Hg/8Iuy/yMBh8FnczxRtPIa7RyCGAE9kpMFc2sVBTaN1dPwJeFo2f1YsP31B 2gH/LGUt5OmTMcDC/KoF3LjoMMOqGMc2Q6ezUEbnpL94aiJA4Mkp/rXzwL1HKgg8LTeY hPlgOX8/prMuk6m97Wf8/oZlatZRFlaXE15lRGxNuxoPSyI8aUWBXfCLhV4Zcq+gZB4J XpRbnFWqSSjebpYyepXYXd0rQzvyGlV7vkcqFSCK/L79cn00c8HghX8ZQflMu5bUH/eu EWGUWzehNQv5zghIl1xh5Tp+ZG2Ob/EdLzMAZocDMiDkVwZaRUc25QGDac2GGeoeicxs r7fA== X-Gm-Message-State: AJIora8hBUr5mu7XH4+5ibYvVUpiIPQC7elJURy1EjmMhWmcB8bEGrTd zVpoYp9H6JRTERveotlgz3T3P9ViZR4+rg== X-Google-Smtp-Source: AGRyM1vJguGRMwMPFUWXrI9LSVBvRsLUYgXtF2tzmcgsvM+heKS5t0myo4bf5MxMeZPzYYVdvf+WsA== X-Received: by 2002:a05:6402:3881:b0:43a:691f:8e3b with SMTP id fd1-20020a056402388100b0043a691f8e3bmr45389885edb.217.1658252597458; Tue, 19 Jul 2022 10:43:17 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 07/11] vpci/header: emulate PCI_COMMAND register for guests Date: Tue, 19 Jul 2022 20:42:49 +0300 Message-Id: <20220719174253.541965-8-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Xen and/or Dom0 may have put values in PCI_COMMAND which they expect to remain unaltered. PCI_COMMAND_SERR bit is a good example: while the guest's view of this will want to be zero initially, the host having set it to 1 may not easily be overwritten with 0, or else we'd effectively imply giving the guest control of the bit. Thus, PCI_COMMAND register needs proper emulation in order to honor host's settings. There are examples of emulators [1], [2] which already deal with PCI_COMMAND register emulation and it seems that at most they care about is the only INTx bit (besides IO/memory enable and bus master which are write through). It could be because in order to properly emulate the PCI_COMMAND register we need to know about the whole PCI topology, e.g. if any setting in device's command register is aligned with the upstream port etc. This makes me think that because of this complexity others just ignore that. Neither I think this can easily be done in Xen case. According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0", section "6.2.2 Device Control" the reset state of the command register is typically 0, so when assigning a PCI device use 0 as the initial state for the guest's view of the command register. For now our emulation only makes sure INTx is set according to the host requirements, i.e. depending on MSI/MSI-X enabled state. This implementation and the decision to only emulate INTx bit for now is based on the previous discussion at [3]. [1] https://github.com/qemu/qemu/blob/master/hw/xen/xen_pt_config_init.c#L310 [2] https://github.com/projectacrn/acrn-hypervisor/blob/master/hypervisor/hw/pci.c#L336 [3] https://patchwork.kernel.org/project/xen-devel/patch/20210903100831.177748-9-andr2000@gmail.com/ Signed-off-by: Oleksandr Andrushchenko --- Since v6: - fold guest's logic into cmd_write - implement cmd_read, so we can report emulated INTx state to guests - introduce header->guest_cmd to hold the emulated state of the PCI_COMMAND register for guests - OT: rebased - OT: add cf_check specifier to cmd_read() Since v5: - add additional check for MSI-X enabled while altering INTX bit - make sure INTx disabled while guests enable MSI/MSI-X Since v3: - gate more code on CONFIG_HAS_MSI - removed logic for the case when MSI/MSI-X not enabled --- xen/drivers/vpci/header.c | 38 +++++++++++++++++++++++++++++++++++++- xen/drivers/vpci/msi.c | 4 ++++ xen/drivers/vpci/msix.c | 4 ++++ xen/include/xen/vpci.h | 3 +++ 4 files changed, 48 insertions(+), 1 deletion(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 4e6547a54d..2ce69a63a2 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -443,11 +443,27 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) return 0; } +/* TODO: Add proper emulation for all bits of the command register. */ static void cf_check cmd_write( const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data) { uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg); + if ( !is_hardware_domain(pdev->domain) ) + { + struct vpci_header *header = data; + + header->guest_cmd = cmd; +#ifdef CONFIG_HAS_PCI_MSI + if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled ) + /* + * Guest wants to enable INTx, but it can't be enabled + * if MSI/MSI-X enabled. + */ + cmd |= PCI_COMMAND_INTX_DISABLE; +#endif + } + /* * Let Dom0 play with all the bits directly except for the memory * decoding one. @@ -464,6 +480,19 @@ static void cf_check cmd_write( pci_conf_write16(pdev->sbdf, reg, cmd); } +static uint32_t cf_check cmd_read( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + if ( !is_hardware_domain(pdev->domain) ) + { + struct vpci_header *header = data; + + return header->guest_cmd; + } + + return pci_conf_read16(pdev->sbdf, reg); +} + static void cf_check bar_write( const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) { @@ -665,8 +694,15 @@ static int cf_check init_bars(struct pci_dev *pdev) return -EOPNOTSUPP; } + /* + * According to "PCI LOCAL BUS SPECIFICATION, REV. 3.0", section "6.2.2 + * Device Control" the reset state of the command register is + * typically all 0's, so this is used as initial value for the guests. + */ + ASSERT(header->guest_cmd == 0); + /* Setup a handler for the command register. */ - rc = vpci_add_register(pdev->vpci, vpci_hw_read16, cmd_write, PCI_COMMAND, + rc = vpci_add_register(pdev->vpci, cmd_read, cmd_write, PCI_COMMAND, 2, header); if ( rc ) return rc; diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c index d864f740cf..c8c495e2d7 100644 --- a/xen/drivers/vpci/msi.c +++ b/xen/drivers/vpci/msi.c @@ -70,6 +70,10 @@ static void cf_check control_write( if ( vpci_msi_arch_enable(msi, pdev, vectors) ) return; + + /* Make sure guest doesn't enable INTx while enabling MSI. */ + if ( !is_hardware_domain(pdev->domain) ) + pci_intx(pdev, false); } else vpci_msi_arch_disable(msi, pdev); diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 35cc9280f4..06f84b8b02 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -92,6 +92,10 @@ static void cf_check control_write( for ( i = 0; i < msix->max_entries; i++ ) if ( !msix->entries[i].masked && msix->entries[i].updated ) update_entry(&msix->entries[i], pdev, i); + + /* Make sure guest doesn't enable INTx while enabling MSI-X. */ + if ( !is_hardware_domain(pdev->domain) ) + pci_intx(pdev, false); } else if ( !new_enabled && msix->enabled ) { diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 6332659c4a..1010f68c28 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -87,6 +87,9 @@ struct vpci { } bars[PCI_HEADER_NORMAL_NR_BARS + 1]; /* At most 6 BARS + 1 expansion ROM BAR. */ + /* Guest view of the PCI_COMMAND register. */ + uint16_t guest_cmd; + /* * Store whether the ROM enable bit is set (doesn't imply ROM BAR * is mapped into guest p2m) if there's a ROM BAR on the device. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370801.602726 (Exim 4.92) (envelope-from ) id 1oDrFe-0007Qk-M1; Tue, 19 Jul 2022 17:43:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370801.602726; Tue, 19 Jul 2022 17:43:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFe-0007QV-HS; Tue, 19 Jul 2022 17:43:18 +0000 Received: by outflank-mailman (input) for mailman id 370801; Tue, 19 Jul 2022 17:43:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFd-00065R-3p for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:17 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 44a5100f-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:15 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id bp15so28611028ejb.6 for ; Tue, 19 Jul 2022 10:43:15 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 44a5100f-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OieAisZo52BPPW28GQWLm26fgvpHr9TxOwcPehMBtUc=; b=pbAkZHs2Ovwil0XJtD3oLEGPLgaJs45DiqIUbhMdbla4V4G66V2YM4ikeg2qrQ4pQw 8/LSdMqbJ6E+mFQAt8XRlTJUPgMZN151f6EYkKYb0fAiuBrs1j3fhvSErbv02PkeQa/I HPftSqB2NfU1oH77y6mUGxYi+wQvlS8BJZ4adtdukSgrgJcKJqMEJcT0KYcsKrZkvjLI TfZL3Pdtbk9ttEqdqFJ+oxV/AEfCxldvFqHsYSm+GIFLEA/anf5hzZ7z5F0keoBc5AWa fEl1M9z9MtUXK+uoGvHnRR5q5mbbiskniNEKeZAuXAv112O9QKZTdiOcYjRihdjLy5aB u7mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OieAisZo52BPPW28GQWLm26fgvpHr9TxOwcPehMBtUc=; b=B5EX3oKnMGXGzT9mtd+mXQDh/W/wVN6WSl9D1fHZj8TFbXlFgbqQ74dkIvRWyInHlW 0LEyGFvvFlq2xp6dTZfRJJFEBaQ/swBl1YOncWUPI2oNnV81UX8o4VbGHvp97bVIgvKS /TYt/CUf20Wl7T+aIqwVJ84sZYnnqwFm93sdq46iNwJywdrxcBeTAhyY0YuSIE20RBYK rVrX7GWKtfV0LUQJJ415s3OuDwNIyRo/3J8HrqyMfD5rxIavnWSQsrLyK9NoxQuOiVWi 5ZkUNXfTfiBkItFvBQP/MDQG93Lumd4VTzZhOWPyI1sHO+eZDkK3NkbK85fjoncEr2Mt M0pw== X-Gm-Message-State: AJIora8rznq5QX6q6DFSt8cDkrQb1SAAQZ5xhnP2Xt7d365kGpz1GUI/ ih2nEPPYc736r2GFLm3WKiiU6ibv6qQu6Q== X-Google-Smtp-Source: AGRyM1tbRAV2e9n0Nj7kC5Lvvd3jfZNCpCrgvfb24h7ry3pXKn7AQqZZMwhIeAfOW5ccrheE5vPlUQ== X-Received: by 2002:a17:907:28d4:b0:72b:49c0:d04a with SMTP id en20-20020a17090728d400b0072b49c0d04amr32968382ejc.141.1658252594893; Tue, 19 Jul 2022 10:43:14 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 05/11] vpci/header: handle p2m range sets per BAR Date: Tue, 19 Jul 2022 20:42:47 +0300 Message-Id: <20220719174253.541965-6-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Instead of handling a single range set, that contains all the memory regions of all the BARs and ROM, have them per BAR. As the range sets are now created when a PCI device is added and destroyed when it is removed so make them named and accounted. Note that rangesets were chosen here despite there being only up to 3 separate ranges in each set (typically just 1). But rangeset per BAR was chosen for the ease of implementation and existing code re-usability. This is in preparation of making non-identity mappings in p2m for the MMIOs. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - update according to the new locking scheme - remove odd fail label in modify_bars - OT: rebased Since v5: - fix comments - move rangeset allocation to init_bars and only allocate for MAPPABLE BARs - check for overlap with the already setup BAR ranges Since v4: - use named range sets for BARs (Jan) - changes required by the new locking scheme - updated commit message (Jan) Since v3: - re-work vpci_cancel_pending accordingly to the per-BAR handling - s/num_mem_ranges/map_pending and s/uint8_t/bool - ASSERT(bar->mem) in modify_bars - create and destroy the rangesets on add/remove --- xen/drivers/vpci/header.c | 241 +++++++++++++++++++++++++++----------- xen/drivers/vpci/vpci.c | 5 + xen/include/xen/vpci.h | 3 +- 3 files changed, 182 insertions(+), 67 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 9fbbdc3500..f14ff11882 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -131,64 +131,106 @@ static void modify_decoding(const struct pci_dev *pdev, uint16_t cmd, bool vpci_process_pending(struct vcpu *v) { - if ( v->vpci.mem ) + struct pci_dev *pdev = v->vpci.pdev; + + if ( !pdev ) + return false; + + pcidevs_read_lock(); + + if ( v->vpci.map_pending ) { struct map_data data = { .d = v->domain, .map = v->vpci.cmd & PCI_COMMAND_MEMORY, }; - int rc = rangeset_consume_ranges(v->vpci.mem, map_range, &data); - - if ( rc == -ERESTART ) - return true; - - pcidevs_read_lock(); - spin_lock(&v->vpci.pdev->vpci->lock); - /* Disable memory decoding unconditionally on failure. */ - modify_decoding(v->vpci.pdev, - rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : v->vpci.cmd, - !rc && v->vpci.rom_only); - spin_unlock(&v->vpci.pdev->vpci->lock); - pcidevs_read_unlock(); - - rangeset_destroy(v->vpci.mem); - v->vpci.mem = NULL; - if ( rc ) + struct vpci_header *header = &pdev->vpci->header; + unsigned int i; + + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) { - /* - * FIXME: in case of failure remove the device from the domain. - * Note that there might still be leftover mappings. While this is - * safe for Dom0, for DomUs the domain will likely need to be - * killed in order to avoid leaking stale p2m mappings on - * failure. - */ - pcidevs_write_lock(); - vpci_remove_device(v->vpci.pdev); - pcidevs_write_unlock(); + struct vpci_bar *bar = &header->bars[i]; + int rc; + + if ( rangeset_is_empty(bar->mem) ) + continue; + + rc = rangeset_consume_ranges(bar->mem, map_range, &data); + + if ( rc == -ERESTART ) + { + pcidevs_read_unlock(); + return true; + } + + spin_lock(&pdev->vpci->lock); + /* Disable memory decoding unconditionally on failure. */ + modify_decoding(pdev, rc ? v->vpci.cmd & ~PCI_COMMAND_MEMORY : + v->vpci.cmd, !rc && v->vpci.rom_only); + spin_unlock(&pdev->vpci->lock); + + if ( rc ) + { + /* + * FIXME: in case of failure remove the device from the domain. + * Note that there might still be leftover mappings. While this + * is safe for Dom0, for DomUs the domain needs to be killed in + * order to avoid leaking stale p2m mappings on failure. + */ + v->vpci.map_pending = false; + pcidevs_read_unlock(); + + if ( is_hardware_domain(v->domain) ) + { + pcidevs_write_lock(); + vpci_remove_device(v->vpci.pdev); + pcidevs_write_unlock(); + } + else + domain_crash(v->domain); + + return false; + } } + + v->vpci.map_pending = false; } + pcidevs_read_unlock(); + return false; } static int __init apply_map(struct domain *d, const struct pci_dev *pdev, - struct rangeset *mem, uint16_t cmd) + uint16_t cmd) { struct map_data data = { .d = d, .map = true }; - int rc; + struct vpci_header *header = &pdev->vpci->header; + int rc = 0; + unsigned int i; - while ( (rc = rangeset_consume_ranges(mem, map_range, &data)) == -ERESTART ) + ASSERT(pcidevs_write_locked()); + + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) { - /* - * It's safe to drop and re-acquire the lock in this context - * without risking pdev disappearing because devices cannot be - * removed until the initial domain has been started. - */ - pcidevs_write_unlock(); - process_pending_softirqs(); - pcidevs_write_lock(); + struct vpci_bar *bar = &header->bars[i]; + + if ( rangeset_is_empty(bar->mem) ) + continue; + + while ( (rc = rangeset_consume_ranges(bar->mem, map_range, + &data)) == -ERESTART ) + { + /* + * It's safe to drop and reacquire the lock in this context + * without risking pdev disappearing because devices cannot be + * removed until the initial domain has been started. + */ + pcidevs_write_unlock(); + process_pending_softirqs(); + pcidevs_write_lock(); + } } - rangeset_destroy(mem); if ( !rc ) modify_decoding(pdev, cmd, false); @@ -196,7 +238,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev, } static void defer_map(struct domain *d, struct pci_dev *pdev, - struct rangeset *mem, uint16_t cmd, bool rom_only) + uint16_t cmd, bool rom_only) { struct vcpu *curr = current; @@ -207,7 +249,7 @@ static void defer_map(struct domain *d, struct pci_dev *pdev, * started for the same device if the domain is not well-behaved. */ curr->vpci.pdev = pdev; - curr->vpci.mem = mem; + curr->vpci.map_pending = true; curr->vpci.cmd = cmd; curr->vpci.rom_only = rom_only; /* @@ -221,43 +263,61 @@ static void defer_map(struct domain *d, struct pci_dev *pdev, static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) { struct vpci_header *header = &pdev->vpci->header; - struct rangeset *mem = rangeset_new(NULL, NULL, 0); struct pci_dev *tmp, *dev = NULL; const struct vpci_msix *msix = pdev->vpci->msix; - unsigned int i; + unsigned int i, j; int rc; - - if ( !mem ) - return -ENOMEM; + bool map_pending; /* - * Create a rangeset that represents the current device BARs memory region - * and compare it against all the currently active BAR memory regions. If - * an overlap is found, subtract it from the region to be mapped/unmapped. + * Create a rangeset per BAR that represents the current device memory + * region and compare it against all the currently active BAR memory + * regions. If an overlap is found, subtract it from the region to be + * mapped/unmapped. * - * First fill the rangeset with all the BARs of this device or with the ROM + * First fill the rangesets with the BARs of this device or with the ROM * BAR only, depending on whether the guest is toggling the memory decode * bit of the command register, or the enable bit of the ROM BAR register. */ for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) { - const struct vpci_bar *bar = &header->bars[i]; + struct vpci_bar *bar = &header->bars[i]; unsigned long start = PFN_DOWN(bar->addr); unsigned long end = PFN_DOWN(bar->addr + bar->size - 1); + if ( !bar->mem ) + continue; + if ( !MAPPABLE_BAR(bar) || (rom_only ? bar->type != VPCI_BAR_ROM : (bar->type == VPCI_BAR_ROM && !header->rom_enabled)) ) continue; - rc = rangeset_add_range(mem, start, end); + rc = rangeset_add_range(bar->mem, start, end); if ( rc ) { printk(XENLOG_G_WARNING "Failed to add [%lx, %lx]: %d\n", start, end, rc); - rangeset_destroy(mem); return rc; } + + /* Check for overlap with the already setup BAR ranges. */ + for ( j = 0; j < i; j++ ) + { + struct vpci_bar *bar = &header->bars[j]; + + if ( rangeset_is_empty(bar->mem) ) + continue; + + rc = rangeset_remove_range(bar->mem, start, end); + if ( rc ) + { + printk(XENLOG_G_WARNING + "Failed to remove overlapping range [%lx, %lx]: %d\n", + start, end, rc); + return rc; + } + } } /* Remove any MSIX regions if present. */ @@ -267,14 +327,21 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) unsigned long end = PFN_DOWN(vmsix_table_addr(pdev->vpci, i) + vmsix_table_size(pdev->vpci, i) - 1); - rc = rangeset_remove_range(mem, start, end); - if ( rc ) + for ( j = 0; j < ARRAY_SIZE(header->bars); j++ ) { - printk(XENLOG_G_WARNING - "Failed to remove MSIX table [%lx, %lx]: %d\n", - start, end, rc); - rangeset_destroy(mem); - return rc; + const struct vpci_bar *bar = &header->bars[j]; + + if ( rangeset_is_empty(bar->mem) ) + continue; + + rc = rangeset_remove_range(bar->mem, start, end); + if ( rc ) + { + printk(XENLOG_G_WARNING + "Failed to remove MSIX table [%lx, %lx]: %d\n", + start, end, rc); + return rc; + } } } @@ -306,7 +373,8 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) unsigned long start = PFN_DOWN(bar->addr); unsigned long end = PFN_DOWN(bar->addr + bar->size - 1); - if ( !bar->enabled || !rangeset_overlaps_range(mem, start, end) || + if ( !bar->enabled || + !rangeset_overlaps_range(bar->mem, start, end) || /* * If only the ROM enable bit is toggled check against other * BARs in the same device for overlaps, but not against the @@ -315,12 +383,11 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) (rom_only && tmp == pdev && bar->type == VPCI_BAR_ROM) ) continue; - rc = rangeset_remove_range(mem, start, end); + rc = rangeset_remove_range(bar->mem, start, end); if ( rc ) { printk(XENLOG_G_WARNING "Failed to remove [%lx, %lx]: %d\n", start, end, rc); - rangeset_destroy(mem); return rc; } } @@ -339,10 +406,23 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) * will always be to establish mappings and process all the BARs. */ ASSERT((cmd & PCI_COMMAND_MEMORY) && !rom_only); - return apply_map(pdev->domain, pdev, mem, cmd); + return apply_map(pdev->domain, pdev, cmd); } - defer_map(dev->domain, dev, mem, cmd, rom_only); + /* Find out how many memory ranges has left after MSI and overlaps. */ + map_pending = false; + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ ) + if ( !rangeset_is_empty(header->bars[i].mem) ) + { + map_pending = true; + break; + } + + /* If there's no mapping work write the command register now. */ + if ( !map_pending ) + pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); + else + defer_map(dev->domain, dev, cmd, rom_only); return 0; } @@ -525,6 +605,19 @@ static void cf_check rom_write( rom->addr = val & PCI_ROM_ADDRESS_MASK; } +static int bar_add_rangeset(struct pci_dev *pdev, struct vpci_bar *bar, int i) +{ + char str[32]; + + snprintf(str, sizeof(str), "%pp:BAR%d", &pdev->sbdf, i); + + bar->mem = rangeset_new(pdev->domain, str, RANGESETF_no_print); + if ( !bar->mem ) + return -ENOMEM; + + return 0; +} + static int cf_check init_bars(struct pci_dev *pdev) { uint16_t cmd; @@ -611,6 +704,13 @@ static int cf_check init_bars(struct pci_dev *pdev) else bars[i].type = VPCI_BAR_MEM32; + rc = bar_add_rangeset(pdev, &bars[i], i); + if ( rc ) + { + bars[i].type = VPCI_BAR_EMPTY; + goto fail; + } + rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size, (i == num_bars - 1) ? PCI_BAR_LAST : 0); if ( rc < 0 ) @@ -661,6 +761,15 @@ static int cf_check init_bars(struct pci_dev *pdev) rom_reg, 4, rom); if ( rc ) rom->type = VPCI_BAR_EMPTY; + else + { + rc = bar_add_rangeset(pdev, rom, i); + if ( rc ) + { + rom->type = VPCI_BAR_EMPTY; + goto fail; + } + } } } else diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index d187901422..f683346285 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -38,6 +38,8 @@ extern vpci_register_init_t *const __end_vpci_array[]; void vpci_remove_device(struct pci_dev *pdev) { + unsigned int i; + ASSERT(pcidevs_write_locked()); if ( !has_vpci(pdev->domain) || !pdev->vpci ) @@ -54,6 +56,9 @@ void vpci_remove_device(struct pci_dev *pdev) xfree(r); } spin_unlock(&pdev->vpci->lock); + + for ( i = 0; i < ARRAY_SIZE(pdev->vpci->header.bars); i++ ) + rangeset_destroy(pdev->vpci->header.bars[i].mem); if ( pdev->vpci->msix && pdev->vpci->msix->pba ) iounmap(pdev->vpci->msix->pba); xfree(pdev->vpci->msix); diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 6e1d3b93cd..6332659c4a 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -72,6 +72,7 @@ struct vpci { /* Guest view of the BAR: address and lower bits. */ uint64_t guest_reg; uint64_t size; + struct rangeset *mem; enum { VPCI_BAR_EMPTY, VPCI_BAR_IO, @@ -146,9 +147,9 @@ struct vpci { struct vpci_vcpu { /* Per-vcpu structure to store state while {un}mapping of PCI BARs. */ - struct rangeset *mem; struct pci_dev *pdev; uint16_t cmd; + bool map_pending : 1; bool rom_only : 1; }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370798.602687 (Exim 4.92) (envelope-from ) id 1oDrFa-0006OW-K1; Tue, 19 Jul 2022 17:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370798.602687; Tue, 19 Jul 2022 17:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFa-0006Na-Ev; Tue, 19 Jul 2022 17:43:14 +0000 Received: by outflank-mailman (input) for mailman id 370798; Tue, 19 Jul 2022 17:43:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFZ-00065X-Dp for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:13 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 417dca07-078a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 19:43:10 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id oy13so28511195ejb.1 for ; Tue, 19 Jul 2022 10:43:10 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:09 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 417dca07-078a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tJNTg1Q/tJV0tMcGJ0EnKDCjisTQ8wg7Qbj1vC+6DIM=; b=JEBiRzNq8/rEVpY4Y1nCW+0agQpHA0wUkr+t5hIdFIBb9KlxybaeCAObAKObfaxV3K CQGvoMUAmYrEUj3Eo5BAlMm1g65MjO/b36aDofazXPb03Hc5ijiHyONtsOlEpRBj4/er xcYSLyjKsWm0shAZcoBRcEqb5sc+v0kcXmAbYRKjZp3+UHsV0gdOu3PdjgnxTitpfzNP DjrYSzpoJ9VALSlYMFm34nRMLO6WouZsnBSwdr7FySAwxXbgE7S3F8kdxceX3eXQqcFI nEjlv7B/84y37y1us2gVDx7znmZ12i3QplCweCTbqFsZ1oQVv6O2e+PEGBgWc3i01oIH jh/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tJNTg1Q/tJV0tMcGJ0EnKDCjisTQ8wg7Qbj1vC+6DIM=; b=hkSmE4kEyYL4XlwGrA97/Jv1+J66P9kGtdW2sVKjxH+xJ5A9eC46mAjlS/Pb6E2/0S 7roUbGRO4TraCLiPV/UHV2lD25tMq21UoVUHZaE+IzmPr54F9apOa5uE7DNZ60LabTr4 ds614Tc+SFUixeJ1RHVG7pUPvDTm7ZB21sauu8tDziB2TbY5IyHGxMb0JNWTkSa+lo6F LJpS0iN/fiPldQm0Cz4DNyJSeR8Jq6kG4N0un3Und6beurNjb0VURkKUJQTCZ5VPeb89 rnqLimbmkUqg9mpuEEIe+j7e5/QBlsgWW5zPPHGng1CQjM4P0xxGHT33ar59D23F5hJt 9f8g== X-Gm-Message-State: AJIora90aSc2p84Ckb4X6lT0YwbYHjKCXSyM6s+td/HpraVPN6rM49z/ tFAK47PMZTWuLI8WVxEGdZETEJ1W1/6IFw== X-Google-Smtp-Source: AGRyM1sWKSEJ1JhwSXANfNs9LH6TodgS9OnuY5ABFJc+y4wgMeLWpJHFKORNVHHvQJvIQj35lX12ow== X-Received: by 2002:a17:907:168d:b0:72b:5b67:83e6 with SMTP id hc13-20020a170907168d00b0072b5b6783e6mr32078995ejc.709.1658252589631; Tue, 19 Jul 2022 10:43:09 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH V7 01/11] xen/pci: arm: add stub for is_memory_hole Date: Tue, 19 Jul 2022 20:42:43 +0300 Message-Id: <20220719174253.541965-2-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add a stub for is_memory_hole which is required for PCI passthrough on Arm. Signed-off-by: Oleksandr Andrushchenko --- OT: It looks like the discussion got stuck. As I understand this patch is not immediately needed in the context of current series as PCI passthrough is not enabled on Arm at the moment. So the patch could be added later on, but it is needed to allow PCI passthrough to be built on Arm for those who want to test it. Copy here some context provided by Julien: Here a summary of the discussion (+ some my follow-up thoughts): is_memory_hole() was recently introduced on x86 (see commit 75cc460a1b8c "xen/pci: detect when BARs are not suitably positioned") to check whether the BAR are positioned outside of a valid memory range. This was introduced to work-around quirky firmware. In theory, this could also happen on Arm. In practice, this may not happen but it sounds better to sanity check that the BAR contains "valid" I/O range. On x86, this is implemented by checking the region is not described is in the e820. IIUC, on Arm, the BARs have to be positioned in pre-defined ranges. So I think it would be possible to implement is_memory_hole() by going through the list of hostbridges and check the ranges. But first, I'd like to confirm my understanding with Rahul, and others. If we were going to go this route, I would also rename the function to be better match what it is doing (i.e. it checks the BAR is correctly placed). As a potentially optimization/hardening for Arm, we could pass the hostbridge so we don't have to walk all of them. --- xen/arch/arm/mm.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 009b8cd9ef..bb34b97eb5 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1708,6 +1708,12 @@ unsigned long get_upper_mfn_bound(void) return max_page - 1; } +bool is_memory_hole(mfn_t start, mfn_t end) +{ + /* TODO: this needs to be properly implemented. */ + return true; +} + /* * Local variables: * mode: C -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370797.602682 (Exim 4.92) (envelope-from ) id 1oDrFa-0006LU-C5; Tue, 19 Jul 2022 17:43:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370797.602682; Tue, 19 Jul 2022 17:43:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFa-0006LN-85; Tue, 19 Jul 2022 17:43:14 +0000 Received: by outflank-mailman (input) for mailman id 370797; Tue, 19 Jul 2022 17:43:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFY-00065R-QO for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:12 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42540942-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:12 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id y8so20648121eda.3 for ; Tue, 19 Jul 2022 10:43:12 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42540942-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Clq/yFmOZ38glmpc8+TyB4sKPvTCJ7X1eyQxmF0coEI=; b=d5FPSK0K72d9Xe+i6ecKVccyRdhudBtSq7Gsg52mnFqT46RzZB1R2LF+jD9ndUfGaM /uPxrDP1hg7nUgQneTN2h0UYnFDfP3aswJ32KwNf8uQr4+EmToIUFBrmuRa4R7uPnVRL xzsUeROARqcaMcnfU6HQtED+vuNpnEynxFuwoh025WabBI6mYmFD8E19m+pEV0zKF7G6 +sAFvVejJ6236UnrN6QNFyeJanWDNpSBvBvyKtIHowxZf1TNfHjvtOVls/Ub8GA3mrb8 M0tOk64zMa6jovUmywas8nnjkkDWOxzAagsVH/NHiVNJEe6gPKXo/zlh7m3wUtWW9/z3 V8ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Clq/yFmOZ38glmpc8+TyB4sKPvTCJ7X1eyQxmF0coEI=; b=fkYnMy8Zpt8Lshhs9vHSk2I5U+5cA2cS3QGm5X9RkPVY+XbxCsBcp7XUYuzOIPC9+Z b5bjtEuZUZkmWhEnOttUc+ujJnHkmifOH9zG3F450WpSPMaa+6gaezIMQ5VFxhft1jFG IRa2uqHG1CnUgDspWa0qczXI49bKrZ6bS1l1rzz90vydpNs/k0cAP7ydmyxK9WRS/1Wa xmAHnVQYMTm8vadLeMzNKfNEdno7i/3TCmG6yore2M5A1cI/6dyIBMMrRhkq94D0IxDp R5HakVozA5B107ZAXfmMgEafCr367bO/1pizcBkrDBklgEegLNAphtKGRPaIlooBQ7WS WNPQ== X-Gm-Message-State: AJIora+0LelLZBAUPwoFN+RP/sS+zSi0NmA38JXsGS/aWTInZ4PxmjMB ySrh68n7aJifMCnDSnUqPXfhqZBcl4Fpxg== X-Google-Smtp-Source: AGRyM1sl4lvRtDpSZF0fInywXXwKy2gpEGVI470vMbcD0kTRR34dE4NikC9nXtxRM4smnaZPKlSnAQ== X-Received: by 2002:aa7:c250:0:b0:43b:25fb:4903 with SMTP id y16-20020aa7c250000000b0043b25fb4903mr36375785edo.253.1658252591074; Tue, 19 Jul 2022 10:43:11 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign Date: Tue, 19 Jul 2022 20:42:44 +0300 Message-Id: <20220719174253.541965-3-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko When a PCI device gets assigned/de-assigned some work on vPCI side needs to be done for that device. Introduce a pair of hooks so vPCI can handle that. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - do not pass struct domain to vpci_{assign|deassign}_device as pdev->domain can be used - do not leave the device assigned (pdev->domain == new domain) in case vpci_assign_device fails: try to de-assign and if this also fails, then crash the domain - re-work according to the new locking scheme (ASSERTs) - OT: rebased Since v5: - do not split code into run_vpci_init - do not check for is_system_domain in vpci_{de}assign_device - do not use vpci_remove_device_handlers_locked and re-allocate pdev->vpci completely - make vpci_deassign_device void Since v4: - de-assign vPCI from the previous domain on device assignment - do not remove handlers in vpci_assign_device as those must not exist at that point Since v3: - remove toolstack roll-back description from the commit message as error are to be handled with proper cleanup in Xen itself - remove __must_check - remove redundant rc check while assigning devices - fix redundant CONFIG_HAS_VPCI check for CONFIG_HAS_VPCI_GUEST_SUPPORT - use REGISTER_VPCI_INIT machinery to run required steps on device init/assign: add run_vpci_init helper Since v2: - define CONFIG_HAS_VPCI_GUEST_SUPPORT so dead code is not compiled for x86 Since v1: - constify struct pci_dev where possible - do not open code is_system_domain() - extended the commit message --- xen/drivers/Kconfig | 4 ++++ xen/drivers/passthrough/pci.c | 11 +++++++++++ xen/drivers/vpci/vpci.c | 31 +++++++++++++++++++++++++++++++ xen/include/xen/vpci.h | 15 +++++++++++++++ 4 files changed, 61 insertions(+) diff --git a/xen/drivers/Kconfig b/xen/drivers/Kconfig index db94393f47..780490cf8e 100644 --- a/xen/drivers/Kconfig +++ b/xen/drivers/Kconfig @@ -15,4 +15,8 @@ source "drivers/video/Kconfig" config HAS_VPCI bool +config HAS_VPCI_GUEST_SUPPORT + bool + depends on HAS_VPCI + endmenu diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c index f93922acc8..56af1dbd97 100644 --- a/xen/drivers/passthrough/pci.c +++ b/xen/drivers/passthrough/pci.c @@ -1019,6 +1019,8 @@ static int deassign_device(struct domain *d, uint16_t seg, uint8_t bus, if ( ret ) goto out; + vpci_deassign_device(pdev); + if ( pdev->domain == hardware_domain ) pdev->quarantine = false; @@ -1558,6 +1560,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) { const struct domain_iommu *hd = dom_iommu(d); struct pci_dev *pdev; + uint8_t old_devfn; int rc = 0; if ( !is_iommu_enabled(d) ) @@ -1577,6 +1580,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) if ( pdev->broken && d != hardware_domain && d != dom_io ) goto done; + vpci_deassign_device(pdev); + rc = pdev_msix_assign(d, pdev); if ( rc ) goto done; @@ -1594,6 +1599,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) pci_to_dev(pdev), flag)) ) goto done; + old_devfn = devfn; + for ( ; pdev->phantom_stride; rc = 0 ) { devfn += pdev->phantom_stride; @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) pci_to_dev(pdev), flag); } + rc = vpci_assign_device(pdev); + if ( rc && deassign_device(d, seg, bus, old_devfn) ) + domain_crash(d); + done: if ( rc ) printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index 674c9b347d..d187901422 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -92,6 +92,37 @@ int vpci_add_handlers(struct pci_dev *pdev) return rc; } + +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT +/* Notify vPCI that device is assigned to guest. */ +int vpci_assign_device(struct pci_dev *pdev) +{ + int rc; + + ASSERT(pcidevs_write_locked()); + + if ( !has_vpci(pdev->domain) ) + return 0; + + rc = vpci_add_handlers(pdev); + if ( rc ) + vpci_deassign_device(pdev); + + return rc; +} + +/* Notify vPCI that device is de-assigned from guest. */ +void vpci_deassign_device(struct pci_dev *pdev) +{ + ASSERT(pcidevs_write_locked()); + + if ( !has_vpci(pdev->domain) ) + return; + + vpci_remove_device(pdev); +} +#endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */ + #endif /* __XEN__ */ static int vpci_register_cmp(const struct vpci_register *r1, diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 7ab39839ff..e5501b9207 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -254,6 +254,21 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v) } #endif +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT +/* Notify vPCI that device is assigned/de-assigned to/from guest. */ +int vpci_assign_device(struct pci_dev *pdev); +void vpci_deassign_device(struct pci_dev *pdev); +#else +static inline int vpci_assign_device(struct pci_dev *pdev) +{ + return 0; +}; + +static inline void vpci_deassign_device(struct pci_dev *pdev) +{ +}; +#endif + #endif /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370799.602704 (Exim 4.92) (envelope-from ) id 1oDrFb-0006qj-RP; Tue, 19 Jul 2022 17:43:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370799.602704; Tue, 19 Jul 2022 17:43:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFb-0006qa-OG; Tue, 19 Jul 2022 17:43:15 +0000 Received: by outflank-mailman (input) for mailman id 370799; Tue, 19 Jul 2022 17:43:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFa-00065R-4T for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:14 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 42fd6b47-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:13 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id sz17so28557006ejc.9 for ; Tue, 19 Jul 2022 10:43:13 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 42fd6b47-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FgW5CBHXdcnwWKRIlMpQopBORvtG8zr4OSYqoD8fHyU=; b=CXgYMn7KHHmlUqP2ylgTZ4SLg8AaLwROxv/SKbNwpq/p3FgltdZdTs6yeq+BDsJ7aV YNoGKCkkYI4h1wKk0+RIKQUNDiyQxnSWgcqG8fkYU+2pp6vzaMinRYeP6DBDRHWDB7RO XlRGcN7iLtGIFfRGPoGPYYcIy0rQi1Ldw8NoKvdrN7kUDXjQK6VRBAWdZm3xUdy60EIQ IN2j7d+00XPogxocVYsNGBfyN88FEtKUFwbtcMWb3ey5vYb60PUAOA3GGHgbAJ+/2z6R E/Icog1jEAu9L4AtdD1rDxNsLkkGDYRhMOYo91mPWJhMbeKft6Iz5rhsCOIF+a62OEYT A3sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FgW5CBHXdcnwWKRIlMpQopBORvtG8zr4OSYqoD8fHyU=; b=tBP421QWy7xNtktv2Z03NW7PB1jVDDgOY2q0d/qtaq+KYQKyXfJxfn63K9NZiogNdP r0SnRkiUBiuW5hXv1rjQOFaPx1yDoIxFSJMT9YxIsEHj8mmVILMWBNvC3SudTIiHMZ9a yoFUJ4DDqsosA+I5+mhwqr7VToVWWx33GZNkh5K8KFa4oR7HJhEBV29gPsH13uoOjjGa NYqPD8ZcNAKNIMRDNg6O8d1PLfpIc5Bk01saZfccxvSo6yitNbn1zwgIAEwC2rkbD4XR 6p3MPoPxZoyeiv6fRFL9hwq43OLXwCpBROg4Ts60PT+VwB4nksQiQSmqjxKYDQZVlvuh REMw== X-Gm-Message-State: AJIora8r977G3T3TKQyAMWUIj8yYcsZU4Vh7ctNY49V9qz0Hn2y9k69r Vww8VOjI1IELjTNcLVK0vzMUeV4DwnnA6A== X-Google-Smtp-Source: AGRyM1ubvpmCjkSWVW5k2cVxXUpISmssUtDd1KiuVlTJ0QCQMdV9iUR30c8eFT1SCyrdIoIl4TkXrw== X-Received: by 2002:a17:907:948e:b0:72d:3fd2:5da0 with SMTP id dm14-20020a170907948e00b0072d3fd25da0mr30077049ejc.225.1658252592168; Tue, 19 Jul 2022 10:43:12 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers Date: Tue, 19 Jul 2022 20:42:45 +0300 Message-Id: <20220719174253.541965-4-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Add relevant vpci register handlers when assigning PCI device to a domain and remove those when de-assigning. This allows having different handlers for different domains, e.g. hwdom and other guests. Emulate guest BAR register values: this allows creating a guest view of the registers and emulates size and properties probe as it is done during PCI device enumeration by the guest. All empty, IO and ROM BARs for guests are emulated by returning 0 on reads and ignoring writes: this BARs are special with this respect as their lower bits have special meaning, so returning default ~0 on read may confuse guest OS. Memory decoding is initially disabled when used by guests in order to prevent the BAR being placed on top of a RAM region. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - unify the writing of the PCI_COMMAND register on the error path into a label - do not introduce bar_ignore_access helper and open code - s/guest_bar_ignore_read/empty_bar_read - update error message in guest_bar_write - only setup empty_bar_read for IO if !x86 - OT: rebased - OT: add cf_check specifier to guest_bar_(write)read() and empty_bar_read() Since v5: - make sure that the guest set address has the same page offset as the physical address on the host - remove guest_rom_{read|write} as those just implement the default behaviour of the registers not being handled - adjusted comment for struct vpci.addr field - add guest handlers for BARs which are not handled and will otherwise return ~0 on read and ignore writes. The BARs are special with this respect as their lower bits have special meaning, so returning ~0 doesn't seem to be right Since v4: - updated commit message - s/guest_addr/guest_reg Since v3: - squashed two patches: dynamic add/remove handlers and guest BAR handler implementation - fix guest BAR read of the high part of a 64bit BAR (Roger) - add error handling to vpci_assign_device - s/dom%pd/%pd - blank line before return Since v2: - remove unneeded ifdefs for CONFIG_HAS_VPCI_GUEST_SUPPORT as more code has been eliminated from being built on x86 Since v1: - constify struct pci_dev where possible - do not open code is_system_domain() - simplify some code3. simplify - use gdprintk + error code instead of gprintk - gate vpci_bar_{add|remove}_handlers with CONFIG_HAS_VPCI_GUEST_SUPPORT, so these do not get compiled for x86 - removed unneeded is_system_domain check - re-work guest read/write to be much simpler and do more work on write than read which is expected to be called more frequently - removed one too obvious comment --- xen/drivers/vpci/header.c | 151 +++++++++++++++++++++++++++++++------- xen/include/xen/vpci.h | 3 + 2 files changed, 126 insertions(+), 28 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index e0461b1139..9fbbdc3500 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -412,6 +412,71 @@ static void cf_check bar_write( pci_conf_write32(pdev->sbdf, reg, val); } +static void cf_check guest_bar_write( + const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) +{ + struct vpci_bar *bar = data; + bool hi = false; + uint64_t guest_reg = bar->guest_reg; + + if ( bar->type == VPCI_BAR_MEM64_HI ) + { + ASSERT(reg > PCI_BASE_ADDRESS_0); + bar--; + hi = true; + } + else + { + val &= PCI_BASE_ADDRESS_MEM_MASK; + val |= bar->type == VPCI_BAR_MEM32 ? PCI_BASE_ADDRESS_MEM_TYPE_32 + : PCI_BASE_ADDRESS_MEM_TYPE_64; + val |= bar->prefetchable ? PCI_BASE_ADDRESS_MEM_PREFETCH : 0; + } + + guest_reg &= ~(0xffffffffull << (hi ? 32 : 0)); + guest_reg |= (uint64_t)val << (hi ? 32 : 0); + + guest_reg &= ~(bar->size - 1) | ~PCI_BASE_ADDRESS_MEM_MASK; + + /* + * Make sure that the guest set address has the same page offset + * as the physical address on the host or otherwise things won't work as + * expected. + */ + if ( (guest_reg & (~PAGE_MASK & PCI_BASE_ADDRESS_MEM_MASK)) != + (bar->addr & ~PAGE_MASK) ) + { + gprintk(XENLOG_WARNING, + "%pp: ignored BAR %zu write attempting to change page offset\n", + &pdev->sbdf, bar - pdev->vpci->header.bars + hi); + return; + } + + bar->guest_reg = guest_reg; +} + +static uint32_t cf_check guest_bar_read( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + const struct vpci_bar *bar = data; + bool hi = false; + + if ( bar->type == VPCI_BAR_MEM64_HI ) + { + ASSERT(reg > PCI_BASE_ADDRESS_0); + bar--; + hi = true; + } + + return bar->guest_reg >> (hi ? 32 : 0); +} + +static uint32_t cf_check empty_bar_read( + const struct pci_dev *pdev, unsigned int reg, void *data) +{ + return 0; +} + static void cf_check rom_write( const struct pci_dev *pdev, unsigned int reg, uint32_t val, void *data) { @@ -468,6 +533,7 @@ static int cf_check init_bars(struct pci_dev *pdev) struct vpci_header *header; struct vpci_bar *bars; int rc; + bool is_hwdom = is_hardware_domain(pdev->domain); ASSERT(pcidevs_write_locked()); @@ -512,13 +578,12 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( i && bars[i - 1].type == VPCI_BAR_MEM64_LO ) { bars[i].type = VPCI_BAR_MEM64_HI; - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, - 4, &bars[i]); + rc = vpci_add_register(pdev->vpci, + is_hwdom ? vpci_hw_read32 : guest_bar_read, + is_hwdom ? bar_write : guest_bar_write, + reg, 4, &bars[i]); if ( rc ) - { - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); - return rc; - } + goto fail; continue; } @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) { bars[i].type = VPCI_BAR_IO; + +#ifndef CONFIG_X86 + if ( !is_hwdom ) + { + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, + reg, 4, &bars[i]); + if ( rc ) + goto fail; + } +#endif + continue; } if ( (val & PCI_BASE_ADDRESS_MEM_TYPE_MASK) == @@ -538,14 +614,20 @@ static int cf_check init_bars(struct pci_dev *pdev) rc = pci_size_mem_bar(pdev->sbdf, reg, &addr, &size, (i == num_bars - 1) ? PCI_BAR_LAST : 0); if ( rc < 0 ) - { - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); - return rc; - } + goto fail; if ( size == 0 ) { bars[i].type = VPCI_BAR_EMPTY; + + if ( !is_hwdom ) + { + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, + reg, 4, &bars[i]); + if ( rc ) + goto fail; + } + continue; } @@ -553,34 +635,47 @@ static int cf_check init_bars(struct pci_dev *pdev) bars[i].size = size; bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, - &bars[i]); + rc = vpci_add_register(pdev->vpci, + is_hwdom ? vpci_hw_read32 : guest_bar_read, + is_hwdom ? bar_write : guest_bar_write, + reg, 4, &bars[i]); if ( rc ) - { - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); - return rc; - } + goto fail; } - /* Check expansion ROM. */ - rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); - if ( rc > 0 && size ) + /* Check expansion ROM: we do not handle ROM for guests. */ + if ( is_hwdom ) { - struct vpci_bar *rom = &header->bars[num_bars]; + rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); + if ( rc > 0 && size ) + { + struct vpci_bar *rom = &header->bars[num_bars]; - rom->type = VPCI_BAR_ROM; - rom->size = size; - rom->addr = addr; - header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) & - PCI_ROM_ADDRESS_ENABLE; + rom->type = VPCI_BAR_ROM; + rom->size = size; + rom->addr = addr; + header->rom_enabled = pci_conf_read32(pdev->sbdf, rom_reg) & + PCI_ROM_ADDRESS_ENABLE; - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, rom_reg, - 4, rom); + rc = vpci_add_register(pdev->vpci, vpci_hw_read32, rom_write, + rom_reg, 4, rom); + if ( rc ) + rom->type = VPCI_BAR_EMPTY; + } + } + else + { + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, + rom_reg, 4, &header->bars[num_bars]); if ( rc ) - rom->type = VPCI_BAR_EMPTY; + goto fail; } return (cmd & PCI_COMMAND_MEMORY) ? modify_bars(pdev, cmd, false) : 0; + + fail: + pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); + return rc; } REGISTER_VPCI_INIT(init_bars, VPCI_PRIORITY_MIDDLE); diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index e5501b9207..6e1d3b93cd 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -67,7 +67,10 @@ struct vpci { struct vpci_header { /* Information about the PCI BARs of this device. */ struct vpci_bar { + /* Physical (host) address. */ uint64_t addr; + /* Guest view of the BAR: address and lower bits. */ + uint64_t guest_reg; uint64_t size; enum { VPCI_BAR_EMPTY, -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370803.602736 (Exim 4.92) (envelope-from ) id 1oDrFg-0007iH-0N; Tue, 19 Jul 2022 17:43:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370803.602736; Tue, 19 Jul 2022 17:43:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFf-0007he-Rz; Tue, 19 Jul 2022 17:43:19 +0000 Received: by outflank-mailman (input) for mailman id 370803; Tue, 19 Jul 2022 17:43:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFe-00065R-48 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:18 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4543bb89-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:16 +0200 (CEST) Received: by mail-ej1-x62c.google.com with SMTP id l23so28588728ejr.5 for ; Tue, 19 Jul 2022 10:43:16 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4543bb89-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=shxNV9joemK5imu4wT4+Id91nCPY01JMn0lJabYidsY=; b=eVHUjDx8fQyS+XcgwN0giiiOlBNaG1kuJPLiM5qEXzokJ/H8xzEiCobcMgiP1TD4tt g7YfLq9ADCL1ix35Dnb3kvv+QacuObxCwfEke6l9P5BfQ0mDfZEh4CvOy/CEQJI8qrGX M7bILaJys4OtfsRv0P/ZeJxyTKaYtkJlNlF7dcX767gA/TvEQQqNa9n5aEOd+lXRvum7 Yy7ktAlWEwWeaHCT02VSbtQEzIBZc58NMWMv388dOUBu5WHzs+REF6t65kW849DVZsWO xRudRUPW2uTys3nT4SHheP+DzE5NuwSQqSsogtNBT6t1THv0J9I5KVsZZLajiwprbck/ dEoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=shxNV9joemK5imu4wT4+Id91nCPY01JMn0lJabYidsY=; b=kIR2ldiTGTJesMPLh0onwX2pme+DEx/CVyY7m79r2ZTYPlXn4508GVE6KpDPhza4DD pPxwCTtXRcFN1UqCbJFIq8p3zxhWa3pLwDCDeN3X856zVtgzgHB9ns4aBKGkRC39FKvY MLL4+SxGutTJKORWvFoIKjSkUSruvDLjWyKQAkbp7jm5d4mi+dhewsDbKMo9heBFQ2Ob /FGby+yNE8+7XZtSP/TTrocgm5SoMNbSly21ccNiPfujko5jloxVS+m36p7/rBSUTxF3 IA5Daxxhc98CKbKAqmm6hLmL5EJf1NtZpcLwOBuKOGfkHWI1CxtbWFbW7jTntt/S6k43 03GQ== X-Gm-Message-State: AJIora87Yny0IrU7wMcQW5t6rmR8oGdMu+kNp1DffkVeFMTX9w+SDeLs V6tZKxUolAib6qB0cNmpY7O+IeAQ6p4Cbg== X-Google-Smtp-Source: AGRyM1tToApNxORVJ+5ePOsc4RwRSTArOU6bp+WD5v34DnOee+CQ52yyGCpFW054KCZ6s5dnBIPCjA== X-Received: by 2002:a17:907:3fa8:b0:72b:5895:f54f with SMTP id hr40-20020a1709073fa800b0072b5895f54fmr31647848ejc.464.1658252596053; Tue, 19 Jul 2022 10:43:16 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view Date: Tue, 19 Jul 2022 20:42:48 +0300 Message-Id: <20220719174253.541965-7-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value as set up by the PCI bus driver in the hardware domain. This way hardware domain sees physical BAR values and guest sees emulated ones. Signed-off-by: Oleksandr Andrushchenko --- Since v5: - remove debug print in map_range callback - remove "identity" from the debug print Since v4: - moved start_{gfn|mfn} calculation into map_range - pass vpci_bar in the map_data instead of start_{gfn|mfn} - s/guest_addr/guest_reg Since v3: - updated comment (Roger) - removed gfn_add(map->start_gfn, rc); which is wrong - use v->domain instead of v->vpci.pdev->domain - removed odd e.g. in comment - s/d%d/%pd in altered code - use gdprintk for map/unmap logs Since v2: - improve readability for data.start_gfn and restructure ?: construct Since v1: - s/MSI/MSI-X in comments --- xen/drivers/vpci/header.c | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index f14ff11882..4e6547a54d 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -30,6 +30,7 @@ struct map_data { struct domain *d; + const struct vpci_bar *bar; bool map; }; @@ -41,8 +42,21 @@ static int cf_check map_range( for ( ; ; ) { + /* Start address of the BAR as seen by the guest. */ + gfn_t start_gfn = _gfn(PFN_DOWN(is_hardware_domain(map->d) + ? map->bar->addr + : map->bar->guest_reg)); + /* Physical start address of the BAR. */ + mfn_t start_mfn = _mfn(PFN_DOWN(map->bar->addr)); unsigned long size = e - s + 1; + /* + * Ranges to be mapped don't always start at the BAR start address, as + * there can be holes or partially consumed ranges. Account for the + * offset of the current address from the BAR start. + */ + start_gfn = gfn_add(start_gfn, s - mfn_x(start_mfn)); + /* * ARM TODOs: * - On ARM whether the memory is prefetchable or not should be passed @@ -52,8 +66,8 @@ static int cf_check map_range( * - {un}map_mmio_regions doesn't support preemption. */ - rc = map->map ? map_mmio_regions(map->d, _gfn(s), size, _mfn(s)) - : unmap_mmio_regions(map->d, _gfn(s), size, _mfn(s)); + rc = map->map ? map_mmio_regions(map->d, start_gfn, size, _mfn(s)) + : unmap_mmio_regions(map->d, start_gfn, size, _mfn(s)); if ( rc == 0 ) { *c += size; @@ -62,8 +76,8 @@ static int cf_check map_range( if ( rc < 0 ) { printk(XENLOG_G_WARNING - "Failed to identity %smap [%lx, %lx] for d%d: %d\n", - map->map ? "" : "un", s, e, map->d->domain_id, rc); + "Failed to %smap [%lx, %lx] for %pd: %d\n", + map->map ? "" : "un", s, e, map->d, rc); break; } ASSERT(rc < size); @@ -155,6 +169,7 @@ bool vpci_process_pending(struct vcpu *v) if ( rangeset_is_empty(bar->mem) ) continue; + data.bar = bar; rc = rangeset_consume_ranges(bar->mem, map_range, &data); if ( rc == -ERESTART ) @@ -218,6 +233,7 @@ static int __init apply_map(struct domain *d, const struct pci_dev *pdev, if ( rangeset_is_empty(bar->mem) ) continue; + data.bar = bar; while ( (rc = rangeset_consume_ranges(bar->mem, map_range, &data)) == -ERESTART ) { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370800.602715 (Exim 4.92) (envelope-from ) id 1oDrFd-00077o-5d; Tue, 19 Jul 2022 17:43:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370800.602715; Tue, 19 Jul 2022 17:43:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFd-00077Z-19; Tue, 19 Jul 2022 17:43:17 +0000 Received: by outflank-mailman (input) for mailman id 370800; Tue, 19 Jul 2022 17:43:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFb-00065X-2k for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:15 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 43cfb566-078a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 19:43:14 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id m16so20604420edb.11 for ; Tue, 19 Jul 2022 10:43:14 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 43cfb566-078a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cpVLKnhd6vjujxD0bO2KThhMDJ+iVwVoqh13SC2q0cs=; b=CaEKmCTRcR8/SMRC0bQf+dOv9ySs6y3MjxkY0nxL38jn9DyDTVsUkvy9ZAHNwAQLUb 9PsHRS/MaA6iyDNGA87wfELTHOAsXgeUi44dzyPCvik1wvaojXPc4Cx5sdfckg0fWebP cc219FKu25+5dlHkgUDbhuknkXK8lem6VSZwLGW/7cdxLwwGTYenTN6e3PjlMmAbN2W4 CS9Sm/Psi7omj8llD7gcATQhopxoKJIfBZvlhyRJbQ3upJpAY5JvVVFv3ikETm0FZci/ g/ZeKkUGDsrsiaPWABpUrGO/2OwrY9PmD99wwQoNmAYMJsvw3q7zfdJMDKbtNZ4Bw5LB /jFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cpVLKnhd6vjujxD0bO2KThhMDJ+iVwVoqh13SC2q0cs=; b=kkPEF8SOekhfihud6SJ3BwzPidYZGYxYnKb2p2IX7k9W2ctGEpqYYAzk1KcwOljoNd Y19bH9CEqbxsTfcHcCepXv7vL4L6TZ0Q3cziHZW1nFAkkDN+WbUaXeHKTF4+GT8ZXG0j pyHsl6fiznMiQaZskDYx6qDL6g3kc7zlYtzsXNazAQII6j+GzgPZ0GZNgWYnkYUHOYao fHF08rE5DhCNhyX1cnWEG3cr4lVKuJx/XoYjwE3MRIvw4vU4kHABa0DUkhqJ4yINO7Ay 1rl6pA31NxJy6xn/xsIp2A1ErE2b2EbH7bDLoEQ/8ThsAHMRDPuvQI/RZkzzuLcCjEfB IjNw== X-Gm-Message-State: AJIora9RIbrwqi+ihS7TYXQXxLExEoIA70owytqJl6sCJ7HEawplO1L7 8ckZ33c7V8VKM8/FDOyInwRwGX0T73VtgQ== X-Google-Smtp-Source: AGRyM1tJIw9jRhYJ3lV/7WT5PUgwsKPZGJm0z6/cKEw7ZfGIW7GlhYz1AxpnWJFoCsR9lgCnsRsy1Q== X-Received: by 2002:a05:6402:5245:b0:43a:a024:82cc with SMTP id t5-20020a056402524500b0043aa02482ccmr45478822edd.56.1658252593657; Tue, 19 Jul 2022 10:43:13 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH V7 04/11] rangeset: add RANGESETF_no_print flag Date: Tue, 19 Jul 2022 20:42:46 +0300 Message-Id: <20220719174253.541965-5-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko There are range sets which should not be printed, so introduce a flag which allows marking those as such. Implement relevant logic to skip such entries while printing. While at it also simplify the definition of the flags by directly defining those without helpers. Suggested-by: Jan Beulich Signed-off-by: Oleksandr Andrushchenko Reviewed-by: Jan Beulich --- Since v5: - comment indentation (Jan) Since v1: - update BUG_ON with new flag - simplify the definition of the flags --- xen/common/rangeset.c | 5 ++++- xen/include/xen/rangeset.h | 5 +++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/xen/common/rangeset.c b/xen/common/rangeset.c index a6ef264046..f8b909d016 100644 --- a/xen/common/rangeset.c +++ b/xen/common/rangeset.c @@ -433,7 +433,7 @@ struct rangeset *rangeset_new( INIT_LIST_HEAD(&r->range_list); r->nr_ranges = -1; - BUG_ON(flags & ~RANGESETF_prettyprint_hex); + BUG_ON(flags & ~(RANGESETF_prettyprint_hex | RANGESETF_no_print)); r->flags = flags; safe_strcpy(r->name, name ?: "(no name)"); @@ -575,6 +575,9 @@ void rangeset_domain_printk( list_for_each_entry ( r, &d->rangesets, rangeset_list ) { + if ( r->flags & RANGESETF_no_print ) + continue; + printk(" "); rangeset_printk(r); printk("\n"); diff --git a/xen/include/xen/rangeset.h b/xen/include/xen/rangeset.h index 135f33f606..f7c69394d6 100644 --- a/xen/include/xen/rangeset.h +++ b/xen/include/xen/rangeset.h @@ -49,8 +49,9 @@ void rangeset_limit( /* Flags for passing to rangeset_new(). */ /* Pretty-print range limits in hexadecimal. */ -#define _RANGESETF_prettyprint_hex 0 -#define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex) +#define RANGESETF_prettyprint_hex (1U << 0) + /* Do not print entries marked with this flag. */ +#define RANGESETF_no_print (1U << 1) bool_t __must_check rangeset_is_empty( const struct rangeset *r); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370806.602752 (Exim 4.92) (envelope-from ) id 1oDrFi-0008At-6s; Tue, 19 Jul 2022 17:43:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370806.602752; Tue, 19 Jul 2022 17:43:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFi-00089A-28; Tue, 19 Jul 2022 17:43:22 +0000 Received: by outflank-mailman (input) for mailman id 370806; Tue, 19 Jul 2022 17:43:20 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFg-00065R-DZ for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:20 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 46a6d59e-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:19 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id j22so28609572ejs.2 for ; Tue, 19 Jul 2022 10:43:19 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46a6d59e-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QdkNpMhNG/rH2hDrjEqNlnDvarGoZ2Hnwipc//T8xoA=; b=kCtcd6y9IjewbRIotgLC7v/cJIoXJ/MN4xbaTvTJxILlca8FQtjx948FxXUmHlH9Nz u7PCFpRxM0iUCn/e7JteV+V+nQVNBckd9beuv9H/J1pMA1MyWT1jLP9rliJuApMopxEt E3Bc/5rvdaKAIsFW9B3ucUUa+3PPeuChPaBvKj3LzlB+cMDTrf9vfoFIJzE1bd4yAWt3 7BsZG9BYr5VjPQFcUblpnLgZE91KDhSkilg1V4smxIBkAgOp4gRWVzKJZM86l+J3vebi 8ve5+kyCH7QB0JDzVJyCdhqepz1TuVEuVkTJjOTw9zlA4zPbwG0Rzt7Rgxct++30Bmd5 3FKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QdkNpMhNG/rH2hDrjEqNlnDvarGoZ2Hnwipc//T8xoA=; b=vT3/jQIt44NR9n1nXzMupEyK0KVzhTuG5ytbiOxxyEfhjDI95GR4GRB+iYkp3ZkDXQ 6rKPTcLVCniIGbJx8PJCf+Quhpzvn1G7W4LkODX35KvTBmoTiIbjUXm9nTDmjmd38LMj jSkLup7ZbSyPpnM1QQUblifIct2Z3WLU2PzVkVEER8UTPnckaiMZPGyBqkSrwIGApv75 Rxcfg7/wUOnfaaRpmg4ldwRDqF5VdsFsH0DzXaCx81O8UnUqM5KVogd83grOPPyzobq/ MU/W6u1u/tw/GOWJISg8dgkbgwCe4yC+2otcLkx1FvCpUT3jYpJrKawoa6ZqHssV6+Kc p7Xg== X-Gm-Message-State: AJIora83D9rLmzAoRu33D4QxzEPjAJ3EKAAlOYu+JYZAclxRj/uhDLAc ODhI3mWbAPn+0OZX98yu5PQpiC6G+o0yCA== X-Google-Smtp-Source: AGRyM1vWyMAQazg5NUObXpt91XDu9miFPFNRbJJ25XFfOGHsIqfJSP8H9L3QnEklIiBZJi3ckOePmw== X-Received: by 2002:a17:907:94cb:b0:72f:1d8e:7305 with SMTP id dn11-20020a17090794cb00b0072f1d8e7305mr14904155ejc.625.1658252598420; Tue, 19 Jul 2022 10:43:18 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Date: Tue, 19 Jul 2022 20:42:50 +0300 Message-Id: <20220719174253.541965-9-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Reset the command register when assigning a PCI device to a guest: according to the PCI spec the PCI_COMMAND register is typically all 0's after reset, but this might not be true for the guest as it needs to respect host's settings. For that reason, do not write 0 to the PCI_COMMAND register directly, but go through the corresponding emulation layer (cmd_write), which will take care about the actual bits written. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - use cmd_write directly without introducing emulate_cmd_reg - update commit message with more description on all 0's in PCI_COMMAND Since v5: - updated commit message Since v1: - do not write 0 to the command register, but respect host settings. --- xen/drivers/vpci/header.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/xen/drivers/vpci/header.c b/xen/drivers/vpci/header.c index 2ce69a63a2..1be9775dda 100644 --- a/xen/drivers/vpci/header.c +++ b/xen/drivers/vpci/header.c @@ -701,6 +701,10 @@ static int cf_check init_bars(struct pci_dev *pdev) */ ASSERT(header->guest_cmd == 0); + /* Reset the command register for guests. */ + if ( !is_hwdom ) + cmd_write(pdev, PCI_COMMAND, 0, header); + /* Setup a handler for the command register. */ rc = vpci_add_register(pdev->vpci, cmd_read, cmd_write, PCI_COMMAND, 2, header); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370807.602761 (Exim 4.92) (envelope-from ) id 1oDrFj-0008Jh-57; Tue, 19 Jul 2022 17:43:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370807.602761; Tue, 19 Jul 2022 17:43:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFi-0008ID-Pb; Tue, 19 Jul 2022 17:43:22 +0000 Received: by outflank-mailman (input) for mailman id 370807; Tue, 19 Jul 2022 17:43:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFh-00065X-Em for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:21 +0000 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [2a00:1450:4864:20::52b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 478036d2-078a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 19:43:20 +0200 (CEST) Received: by mail-ed1-x52b.google.com with SMTP id m16so20604833edb.11 for ; Tue, 19 Jul 2022 10:43:20 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 478036d2-078a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rMoBmnl3ZpBTv1UmtiTdiuto4NAuEX1ahKih6uEYEJw=; b=j+R/OvzbEZtIhpUEhIGWc3q1bbZHYp0Ul+K4Dz37jhZz1+6vh8PCxAdE6dTmaGXtW6 AVnPLavEd7Syclorws2JcUeO0Ym2q9+9XlivFihN3LffQaeuDEQZcQuLS3PhI8c3e0M8 H5d8biejz0cHioAeGCZa0kcBFxN6ksKnK8+XWSKEeS/l4Cqv9N4V7/f6qbhg629nMOnw rEOKgkL+i552j3dW2PRr0/3H69bdD2k/vTwnLDG49dNpkqLKW+ac3A6SNOchhs6cCtVK MXNTUs9RN9Ubp8B9PbOMfDTxeUqgEOhqONELTgmT+axiBQMnvZvssNO2OpyaF6kTEi/y r7Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rMoBmnl3ZpBTv1UmtiTdiuto4NAuEX1ahKih6uEYEJw=; b=5dyBaKsu0MYfAYICVh/9ljA9TidTryulC0zAlKibiN4Jtv/iZd2vtecXdUO1bZFb4s cLSWIjqUEo1AJzzhzzZrzJV5uIOnqX4sIrwTWuhpuMau7rinA9gSe4f8heCMZECpUnSo oeff1Zl1X3c+n0LilhRkBNU1mTtxg9WkGd96bwDqS2c6ASgDhg2j++zXIHc6g28buszI 1gF2e0S2EX2y7Bxn/ygVFDuGG7MW3VGpKxcLrCVjXwv/W7wVk8MkF0YOXk3/H9Z5rram fllaNCc49P42kmpOIxDYcaE9F8dhjMbPl1nfg0dVLi4mMWnFASxobpWgtRsncWmZkZ4i 9gsg== X-Gm-Message-State: AJIora8gcIF0U8o3ZWD8XBZ7AIqgPoi+XEI9jDImLyIPHwzp+CS5fTD1 w5UUc7/KbrcdSSKm5a3CTfXFDeF9ylUWtw== X-Google-Smtp-Source: AGRyM1vwWKS94qRtIYCQT74pZ5Yf4pcr8nEvoMGSizTcpXdveRMSImguFS8MGQrIxdv0ZUQ8RxYMAg== X-Received: by 2002:a05:6402:26c3:b0:43a:a846:b2c1 with SMTP id x3-20020a05640226c300b0043aa846b2c1mr45920791edd.133.1658252599786; Tue, 19 Jul 2022 10:43:19 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology Date: Tue, 19 Jul 2022 20:42:51 +0300 Message-Id: <20220719174253.541965-10-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko Assign SBDF to the PCI devices being passed through with bus 0. The resulting topology is where PCIe devices reside on the bus 0 of the root complex itself (embedded endpoints). This implementation is limited to 32 devices which are allowed on a single PCI bus. Please note, that at the moment only function 0 of a multifunction device can be passed through. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - re-work wrt new locking scheme - OT: add ASSERT(pcidevs_write_locked()); to add_virtual_device() Since v5: - s/vpci_add_virtual_device/add_virtual_device and make it static - call add_virtual_device from vpci_assign_device and do not use REGISTER_VPCI_INIT machinery - add pcidevs_locked ASSERT - use DECLARE_BITMAP for vpci_dev_assigned_map Since v4: - moved and re-worked guest sbdf initializers - s/set_bit/__set_bit - s/clear_bit/__clear_bit - minor comment fix s/Virtual/Guest/ - added VPCI_MAX_VIRT_DEV constant (PCI_SLOT(~0) + 1) which will be used later for counting the number of MMIO handlers required for a guest (Julien) Since v3: - make use of VPCI_INIT - moved all new code to vpci.c which belongs to it - changed open-coded 31 to PCI_SLOT(~0) - added comments and code to reject multifunction devices with functions other than 0 - updated comment about vpci_dev_next and made it unsigned int - implement roll back in case of error while assigning/deassigning devices - s/dom%pd/%pd Since v2: - remove casts that are (a) malformed and (b) unnecessary - add new line for better readability - remove CONFIG_HAS_VPCI_GUEST_SUPPORT ifdef's as the relevant vPCI functions are now completely gated with this config - gate common code with CONFIG_HAS_VPCI_GUEST_SUPPORT New in v2 --- xen/drivers/vpci/vpci.c | 70 ++++++++++++++++++++++++++++++++++++++++- xen/include/xen/sched.h | 8 +++++ xen/include/xen/vpci.h | 11 +++++++ 3 files changed, 88 insertions(+), 1 deletion(-) diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index f683346285..d4601ecf9b 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -84,6 +84,9 @@ int vpci_add_handlers(struct pci_dev *pdev) INIT_LIST_HEAD(&pdev->vpci->handlers); spin_lock_init(&pdev->vpci->lock); +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT + pdev->vpci->guest_sbdf.sbdf = ~0; +#endif for ( i = 0; i < NUM_VPCI_INIT; i++ ) { @@ -99,6 +102,62 @@ int vpci_add_handlers(struct pci_dev *pdev) } #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT +static int add_virtual_device(struct pci_dev *pdev) +{ + struct domain *d = pdev->domain; + pci_sbdf_t sbdf = { 0 }; + unsigned long new_dev_number; + + if ( is_hardware_domain(d) ) + return 0; + + ASSERT(pcidevs_write_locked()); + + /* + * Each PCI bus supports 32 devices/slots at max or up to 256 when + * there are multi-function ones which are not yet supported. + */ + if ( pdev->info.is_extfn ) + { + gdprintk(XENLOG_ERR, "%pp: only function 0 passthrough supported\n", + &pdev->sbdf); + return -EOPNOTSUPP; + } + + new_dev_number = find_first_zero_bit(d->vpci_dev_assigned_map, + VPCI_MAX_VIRT_DEV); + if ( new_dev_number >= VPCI_MAX_VIRT_DEV ) + return -ENOSPC; + + __set_bit(new_dev_number, &d->vpci_dev_assigned_map); + + /* + * Both segment and bus number are 0: + * - we emulate a single host bridge for the guest, e.g. segment 0 + * - with bus 0 the virtual devices are seen as embedded + * endpoints behind the root complex + * + * TODO: add support for multi-function devices. + */ + sbdf.devfn = PCI_DEVFN(new_dev_number, 0); + pdev->vpci->guest_sbdf = sbdf; + + return 0; + +} + +static void vpci_remove_virtual_device(const struct pci_dev *pdev) +{ + ASSERT(pcidevs_write_locked()); + + if ( pdev->vpci ) + { + __clear_bit(pdev->vpci->guest_sbdf.dev, + &pdev->domain->vpci_dev_assigned_map); + pdev->vpci->guest_sbdf.sbdf = ~0; + } +} + /* Notify vPCI that device is assigned to guest. */ int vpci_assign_device(struct pci_dev *pdev) { @@ -111,8 +170,16 @@ int vpci_assign_device(struct pci_dev *pdev) rc = vpci_add_handlers(pdev); if ( rc ) - vpci_deassign_device(pdev); + goto fail; + + rc = add_virtual_device(pdev); + if ( rc ) + goto fail; + + return 0; + fail: + vpci_deassign_device(pdev); return rc; } @@ -124,6 +191,7 @@ void vpci_deassign_device(struct pci_dev *pdev) if ( !has_vpci(pdev->domain) ) return; + vpci_remove_virtual_device(pdev); vpci_remove_device(pdev); } #endif /* CONFIG_HAS_VPCI_GUEST_SUPPORT */ diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b9515eb497..a2848a5740 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -457,6 +457,14 @@ struct domain #ifdef CONFIG_HAS_PCI struct list_head pdev_list; +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT + /* + * The bitmap which shows which device numbers are already used by the + * virtual PCI bus topology and is used to assign a unique SBDF to the + * next passed through virtual PCI device. + */ + DECLARE_BITMAP(vpci_dev_assigned_map, VPCI_MAX_VIRT_DEV); +#endif #endif #ifdef CONFIG_HAS_PASSTHROUGH diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index 1010f68c28..cc14b0086d 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -21,6 +21,13 @@ typedef int vpci_register_init_t(struct pci_dev *dev); #define VPCI_ECAM_BDF(addr) (((addr) & 0x0ffff000) >> 12) +/* + * Maximum number of devices supported by the virtual bus topology: + * each PCI bus supports 32 devices/slots at max or up to 256 when + * there are multi-function ones which are not yet supported. + */ +#define VPCI_MAX_VIRT_DEV (PCI_SLOT(~0) + 1) + #define REGISTER_VPCI_INIT(x, p) \ static vpci_register_init_t *const x##_entry \ __used_section(".data.vpci." p) = x @@ -145,6 +152,10 @@ struct vpci { struct vpci_arch_msix_entry arch; } entries[]; } *msix; +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT + /* Guest SBDF of the device. */ + pci_sbdf_t guest_sbdf; +#endif #endif }; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370796.602671 (Exim 4.92) (envelope-from ) id 1oDrFZ-00065l-0b; Tue, 19 Jul 2022 17:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370796.602671; Tue, 19 Jul 2022 17:43:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFY-00065e-SC; Tue, 19 Jul 2022 17:43:12 +0000 Received: by outflank-mailman (input) for mailman id 370796; Tue, 19 Jul 2022 17:43:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFW-00065R-Ke for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:10 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 40ac0a14-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:09 +0200 (CEST) Received: by mail-ed1-x530.google.com with SMTP id w12so20591242edd.13 for ; Tue, 19 Jul 2022 10:43:09 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 40ac0a14-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iil/+hh1lHYGOFBEfrlSQzLIKhq77Pxuaiko3wYSpsA=; b=RPcILN7TxkPOWRwhXV/C22OKCKtG+y7218BmcyLiwGX2gm3tERkvTw3XHbJ5hIghgO GoUs3XEZIq880DUGx/5IGkkH9epNDZPpDsFo9Y5CCzdORnY5jBZr5laii2x+Gr0WBy9G SZ6hqfjUC1ea5xRL7W8aMqf4aGCZpfxblOwV5yZG9+Dk0jj/iXerrsM56uDq2T0LJPPM xr7r9/1ceS36v1zrs18BGSxHD0GbcYVG36KK90geOb5T/HzDyGaLTHEw8fZTWI/8KI3n FzZ/XiBWZkSGbzVdrxwPlZf7fRDQHUQSfiw8ZjGYcCPRpiBfE89KbvGZN4S+mZF3XD7O gCeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=iil/+hh1lHYGOFBEfrlSQzLIKhq77Pxuaiko3wYSpsA=; b=4ZiXkyU9NNFyDZSeeg0KrR4Bf+75hW5sU/cE4bfzWlkFLQPn4ww9maj4+Reurzznfp 41NKTQqiZQXt7SbyQjAud3QCQUac8AHVeGvK/2Ilpj1kqTEo/LygexSxwyqVDHVETzVN k4t0KMpyfOzzk6kZREWfH4L58LzI5qk36hQly9r+3tvlKt30sadcICNF0y6P+654qns+ SxGww61+U+G/BROZ6d/0fFHXGK5mGfDYaotHJX79KK7avlpJTKvmP8RS44xYfZwhVO/e FKLql2gBSCyCBeu3XVli7i6ZvWA33i2RXXPv4eTkpm/2g3vICi0XbKtYadjZqnp/hpB6 CyWg== X-Gm-Message-State: AJIora+pQ7Rq76SOyAOuyEgE3SzwH1oT7/QretXEtQtygxJemh8Fnwss y+lh0O2IDat6W92X9KegQq4wPQRngik53g== X-Google-Smtp-Source: AGRyM1v0XmDpSKmZVABaGFn5fKIsYr/CT0hOc8daUAkuz3OMKftl6Zk1BSBH77tlumb3enDFUXr1Eg== X-Received: by 2002:a05:6402:2554:b0:43a:902b:d31f with SMTP id l20-20020a056402255400b0043a902bd31fmr45208629edb.416.1658252588202; Tue, 19 Jul 2022 10:43:08 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Oleksandr Andrushchenko , Rahul Singh Subject: [PATCH V7 00/11] PCI devices passthrough on Arm, part 3 Date: Tue, 19 Jul 2022 20:42:42 +0300 Message-Id: <20220719174253.541965-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Hi, all! You can find previous discussion at [1]. 1. This patch series is focusing on vPCI and adds support for non-identity PCI BAR mappings which is required while passing through a PCI device to a guest. The highlights are: - Add relevant vpci register handlers when assigning PCI device to a domain and remove those when de-assigning. This allows having different handlers for different domains, e.g. hwdom and other guests. - Emulate guest BAR register values based on physical BAR values. This allows creating a guest view of the registers and emulates size and properties probe as it is done during PCI device enumeration by the guest. - Instead of handling a single range set, that contains all the memory regions of all the BARs and ROM, have them per BAR. - Take into account guest's BAR view and program its p2m accordingly: gfn is guest's view of the BAR and mfn is the physical BAR value as set up by the host bridge in the hardware domain. This way hardware domain sees physical BAR values and guest sees emulated ones. 2. The series also adds support for virtual PCI bus topology for guests: - We emulate a single host bridge for the guest, so segment is always 0. - The implementation is limited to 32 devices which are allowed on a single PCI bus. - The virtual bus number is set to 0, so virtual devices are seen as embedded endpoints behind the root complex. 3. The series has been updated due to the new PCI(vPCI) locking scheme implemented in the prereq series which is also on the review now [2]. 4. For unprivileged guests vpci_{read|write} has been re-worked to not passthrough accesses to the registers not explicitly handled by the corresponding vPCI handlers: without that passthrough to guests is completely unsafe as Xen allows them full access to the registers. During development this can be reverted for debugging purposes. !!! OT: please note, Oleksandr Andrushchenko who is the author of all this stuff has managed to address allmost all review comments given for v6 and pushed the updated version to the github (23.02.22). So after receiving his agreement I just picked it up and did the following before pushing V7: - rebased on the recent staging (resolving a few conflicts) - updated according to the recent changes (added cf_check specifiers where appropriate, etc) and performed minor adjustments - made sure that both current and prereq series [2] didn't really break x86 by testing PVH Dom0 (vPCI) and PV Dom0 + HVM DomU (PCI passthrough to DomU) using Qemu - my colleague Volodymyr Babchuk (who was involved in the prereq series) rechecked that both series worked on Arm using real HW You can also find the series at [3]. [1] https://lore.kernel.org/xen-devel/20220204063459.680961-1-andr2000@gmail.com/ [2] https://lore.kernel.org/xen-devel/20220718211521.664729-1-volodymyr_babchuk@epam.com/ [3] https://github.com/otyshchenko1/xen/commits/vpci7 Oleksandr Andrushchenko (11): xen/pci: arm: add stub for is_memory_hole vpci: add hooks for PCI device assign/de-assign vpci/header: implement guest BAR register handlers rangeset: add RANGESETF_no_print flag vpci/header: handle p2m range sets per BAR vpci/header: program p2m with guest BAR view vpci/header: emulate PCI_COMMAND register for guests vpci/header: reset the command register when adding devices vpci: add initial support for virtual PCI bus topology xen/arm: translate virtual PCI bus topology for guests xen/arm: account IO handlers for emulated PCI MSI-X xen/arch/arm/mm.c | 6 + xen/arch/arm/vpci.c | 31 ++- xen/common/rangeset.c | 5 +- xen/drivers/Kconfig | 4 + xen/drivers/passthrough/pci.c | 11 + xen/drivers/vpci/header.c | 458 ++++++++++++++++++++++++++-------- xen/drivers/vpci/msi.c | 4 + xen/drivers/vpci/msix.c | 4 + xen/drivers/vpci/vpci.c | 130 ++++++++++ xen/include/xen/rangeset.h | 5 +- xen/include/xen/sched.h | 8 + xen/include/xen/vpci.h | 42 +++- 12 files changed, 604 insertions(+), 104 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370809.602781 (Exim 4.92) (envelope-from ) id 1oDrFl-0000bb-V4; Tue, 19 Jul 2022 17:43:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370809.602781; Tue, 19 Jul 2022 17:43:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFl-0000a0-JR; Tue, 19 Jul 2022 17:43:25 +0000 Received: by outflank-mailman (input) for mailman id 370809; Tue, 19 Jul 2022 17:43:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFi-00065X-Q4 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:22 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4852fe6a-078a-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 19:43:22 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id fy29so27438152ejc.12 for ; Tue, 19 Jul 2022 10:43:22 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4852fe6a-078a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xeDSBefOUDefddwDFekw6Jxk+8IVVFXqS6nwlVZXVQU=; b=LFZN7CtylG3g24WT/N4AzwAJAclOs6Jx4biOe+TPkuFnIdk67Ggth4osh4UWA1JQqg 2gWZv+LO0nfgLBOAcPTUBBLpqIuToascsQZgquN3fv4dbRcVHpZC42GTPl/fvZBywLu0 y6PM9A0BjpL0q9G5eBCDlAYBBib8KInXOkC7/P7AXDSX68KgfxwcEjjgaaHJE+ZnevXy uWnEBnI+2f1rzfKJJZoO1tVwNRHLTCpeMi0g+0m2vcszSZjWYI/3aFQQWPZv6hrp6OxV JsvhmJGOcyVFchLGxCfKdJjbXXfHQtAy17DVsp4qdNoFdOyzzam7N2de7xowP84uRxJu 4GDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xeDSBefOUDefddwDFekw6Jxk+8IVVFXqS6nwlVZXVQU=; b=pPtsW0MyvprNACdJUvPTWvoa1ZzFzMR7UnjwJFkDUKPxahb96IqZNmq41wcz8l9/KN yt8ZEkuFwJJubNVmGcZ0pSro7oI960c6VvzWJ/ejRjx0ObTz++GY3/l4TS6JJDYfZEJ3 K3u6oRbbbX6DykbvzkT1CNm+RClhaVsWkBgBwOd2dnZhFDGtNBnq0PD3t9oXoho94bFP 1adQkTnbVimYXtf9ms1zN1PObUrN1eFJjD9usptpToEIbHNMSg49I0YNx9fhDlrM+QDU wNxMIZmaP/2XcSFXRwqbWbozJWWGvErFSRGCSFzg1So1CidxjA//Oar00ySTQvtydMmf qkYg== X-Gm-Message-State: AJIora+NJvarU5EznIjZaA2xL79YT/SwygenFaBd08B2l7pSk0YFfpEG BN3Vnyrtl4fvl8D4hq54N2SqzbjDQVFmmw== X-Google-Smtp-Source: AGRyM1ta7Q2IduHJgFwfDvZzHGMnbRGwVjNFMtsjyrVAgo3Vzo5xc2id5a7tTgOh4fNVI5H16aNGSQ== X-Received: by 2002:a17:907:7632:b0:72b:4d5d:ecce with SMTP id jy18-20020a170907763200b0072b4d5deccemr32856791ejc.11.1658252601136; Tue, 19 Jul 2022 10:43:21 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Date: Tue, 19 Jul 2022 20:42:52 +0300 Message-Id: <20220719174253.541965-11-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko There are three originators for the PCI configuration space access: 1. The domain that owns physical host bridge: MMIO handlers are there so we can update vPCI register handlers with the values written by the hardware domain, e.g. physical view of the registers vs guest's view on the configuration space. 2. Guest access to the passed through PCI devices: we need to properly map virtual bus topology to the physical one, e.g. pass the configuration space access to the corresponding physical devices. 3. Emulated host PCI bridge access. It doesn't exist in the physical topology, e.g. it can't be mapped to some physical host bridge. So, all access to the host bridge itself needs to be trapped and emulated. Signed-off-by: Oleksandr Andrushchenko --- Since v6: - add pcidevs locking to vpci_translate_virtual_device - update wrt to the new locking scheme Since v5: - add vpci_translate_virtual_device for #ifndef CONFIG_HAS_VPCI_GUEST_SUPPORT case to simplify ifdefery - add ASSERT(!is_hardware_domain(d)); to vpci_translate_virtual_device - reset output register on failed virtual SBDF translation Since v4: - indentation fixes - constify struct domain - updated commit message - updates to the new locking scheme (pdev->vpci_lock) Since v3: - revisit locking - move code to vpci.c Since v2: - pass struct domain instead of struct vcpu - constify arguments where possible - gate relevant code with CONFIG_HAS_VPCI_GUEST_SUPPORT New in v2 --- xen/arch/arm/vpci.c | 17 +++++++++++++++++ xen/drivers/vpci/vpci.c | 26 ++++++++++++++++++++++++++ xen/include/xen/vpci.h | 7 +++++++ 3 files changed, 50 insertions(+) diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c index a9fc5817f9..84b2b068a0 100644 --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info, /* data is needed to prevent a pointer cast on 32bit */ unsigned long data; + /* + * For the passed through devices we need to map their virtual SBDF + * to the physical PCI device being passed through. + */ + if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) + { + *r = ~0ul; + return 1; + } + if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa), 1U << info->dabt.size, &data) ) { @@ -59,6 +69,13 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info, struct pci_host_bridge *bridge = p; pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); + /* + * For the passed through devices we need to map their virtual SBDF + * to the physical PCI device being passed through. + */ + if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) + return 1; + return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa), 1U << info->dabt.size, r); } diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index d4601ecf9b..fc2c51dc3e 100644 --- a/xen/drivers/vpci/vpci.c +++ b/xen/drivers/vpci/vpci.c @@ -158,6 +158,32 @@ static void vpci_remove_virtual_device(const struct pci_dev *pdev) } } +/* + * Find the physical device which is mapped to the virtual device + * and translate virtual SBDF to the physical one. + */ +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf) +{ + struct pci_dev *pdev; + + ASSERT(!is_hardware_domain(d)); + + pcidevs_read_lock(); + for_each_pdev( d, pdev ) + { + if ( pdev->vpci && (pdev->vpci->guest_sbdf.sbdf == sbdf->sbdf) ) + { + /* Replace guest SBDF with the physical one. */ + *sbdf = pdev->sbdf; + pcidevs_read_unlock(); + return true; + } + } + + pcidevs_read_unlock(); + return false; +} + /* Notify vPCI that device is assigned to guest. */ int vpci_assign_device(struct pci_dev *pdev) { diff --git a/xen/include/xen/vpci.h b/xen/include/xen/vpci.h index cc14b0086d..5749d8da78 100644 --- a/xen/include/xen/vpci.h +++ b/xen/include/xen/vpci.h @@ -276,6 +276,7 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v) /* Notify vPCI that device is assigned/de-assigned to/from guest. */ int vpci_assign_device(struct pci_dev *pdev); void vpci_deassign_device(struct pci_dev *pdev); +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf); #else static inline int vpci_assign_device(struct pci_dev *pdev) { @@ -285,6 +286,12 @@ static inline int vpci_assign_device(struct pci_dev *pdev) static inline void vpci_deassign_device(struct pci_dev *pdev) { }; + +static inline bool vpci_translate_virtual_device(struct domain *d, + pci_sbdf_t *sbdf) +{ + return false; +} #endif #endif -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 17:43:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 17:43:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370810.602785 (Exim 4.92) (envelope-from ) id 1oDrFm-0000fN-Jg; Tue, 19 Jul 2022 17:43:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370810.602785; Tue, 19 Jul 2022 17:43:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFm-0000eF-3L; Tue, 19 Jul 2022 17:43:26 +0000 Received: by outflank-mailman (input) for mailman id 370810; Tue, 19 Jul 2022 17:43:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrFj-00065R-U2 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 17:43:24 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 490d4515-078a-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 19:43:23 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id mf4so28602384ejc.3 for ; Tue, 19 Jul 2022 10:43:23 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id wj18-20020a170907051200b0072af92fa086sm6903268ejb.32.2022.07.19.10.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 10:43:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 490d4515-078a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mjfe83MniR2Jpzqqr5fpFWKhsRCC+quCKfhPY3IFOKo=; b=OQ2AVbzzIBKQSpHMBmd5Jzm4KjCKHI2AAmLHJXEljMxRabf2UMa3xCil5cWsSzMrZs RwsTk3NLGqkmP3w3yS8GXO+hUMMADmmSeHB7jnhbmLwJNBhZUvWSmztZjBvxxSdZFBaL uV8IBGw0b60nevXgPI5yGzPaAA5lgK/7Pep3xuNqVhSy7sAWE1yG1LPFn4MaXmfrKx0h mwAAcP+CluaUkKNp7ZSNiw8seuvSI1GhqGZm3/kP2Y3/N+EH/aLXncaQ0b4x7CaY27LQ 3so8rkxBrQOJx3l2Jmtfzfb9Jua7272wcq92zN4mDgLqnYQhRmOicq39wagsTk+dDqvE 1DMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mjfe83MniR2Jpzqqr5fpFWKhsRCC+quCKfhPY3IFOKo=; b=wEFqAo1J8PP3GiSlADc3JploblLN137V0Oz75lzUmgBtBkMV4t0SheX1LYhJNMu/zW 5udMsGwNO2Sh4MsOuK9bwiw7OGXtlxaHwRu1/Eej6dyLRbkmxQ7io1BPYp7N67UTQ2G4 7jDf56Jws7ewZEHokg9GYhI9Hv+6pC3vNfWDvfp6pcLhoPvxbwbWX8ovgztXzY917bTb viXeC0N9d68iUv95CPUOPut4mfNZp3OCLYI6VIqZBC1Ss7yHB3MYF50ibL8+hHt25W/W W9HUo4fAGP/7YjvBDq6798P/KMKLh4rEpJNZ6QkwaMxMmNs9qIM7mUqTgGtWwHqCyhLE X5Zg== X-Gm-Message-State: AJIora+u8GK+0IJPwx5eJd6KLwowIqoexTgVkV4iY0+/ja/LV+zZFk/h SZ2QgcoqtYZ0EH/7Ppl5WjjMkBhsWp8yFg== X-Google-Smtp-Source: AGRyM1ulGFt/09wDa5Hg84aWzr2K3uZuAfWScHqhuYAENdA5DS01nR+/TJ+ZwDfTeJ2Lg/7e/X6S9Q== X-Received: by 2002:a17:907:75d9:b0:72b:1472:ba19 with SMTP id jl25-20020a17090775d900b0072b1472ba19mr30896306ejc.657.1658252602444; Tue, 19 Jul 2022 10:43:22 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org Cc: Oleksandr Andrushchenko , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Julien Grall , Stefano Stabellini Subject: [PATCH V7 11/11] xen/arm: account IO handlers for emulated PCI MSI-X Date: Tue, 19 Jul 2022 20:42:53 +0300 Message-Id: <20220719174253.541965-12-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> References: <20220719174253.541965-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Andrushchenko At the moment, we always allocate an extra 16 slots for IO handlers (see MAX_IO_HANDLER). So while adding IO trap handlers for the emulated MSI-X registers we need to explicitly tell that we have additional IO handlers, so those are accounted. Signed-off-by: Oleksandr Andrushchenko Acked-by: Julien Grall --- Cc: Julien Grall Cc: Stefano Stabellini --- This actually moved here from the part 2 of the prep work for PCI passthrough on Arm as it seems to be the proper place for it. Since v5: - optimize with IS_ENABLED(CONFIG_HAS_PCI_MSI) since VPCI_MAX_VIRT_DEV is defined unconditionally New in v5 --- xen/arch/arm/vpci.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c index 84b2b068a0..c5902cb9d3 100644 --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -131,6 +131,8 @@ static int vpci_get_num_handlers_cb(struct domain *d, unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d) { + unsigned int count; + if ( !has_vpci(d) ) return 0; @@ -151,7 +153,17 @@ unsigned int domain_vpci_get_num_mmio_handlers(struct domain *d) * For guests each host bridge requires one region to cover the * configuration space. At the moment, we only expose a single host bridge. */ - return 1; + count = 1; + + /* + * There's a single MSI-X MMIO handler that deals with both PBA + * and MSI-X tables per each PCI device being passed through. + * Maximum number of emulated virtual devices is VPCI_MAX_VIRT_DEV. + */ + if ( IS_ENABLED(CONFIG_HAS_PCI_MSI) ) + count += VPCI_MAX_VIRT_DEV; + + return count; } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:23:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:23:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370880.602802 (Exim 4.92) (envelope-from ) id 1oDrs6-0000yc-Qn; Tue, 19 Jul 2022 18:23:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370880.602802; Tue, 19 Jul 2022 18:23:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrs6-0000yV-Nu; Tue, 19 Jul 2022 18:23:02 +0000 Received: by outflank-mailman (input) for mailman id 370880; Tue, 19 Jul 2022 18:23:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrs5-0000yP-JX for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 18:23:01 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d0745919-078f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 20:22:59 +0200 (CEST) Received: from mail-dm3nam02lp2041.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 14:22:35 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BL1PR03MB6119.namprd03.prod.outlook.com (2603:10b6:208:318::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Tue, 19 Jul 2022 18:22:33 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 18:22:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d0745919-078f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658254979; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=J1N65RqM0M2f7IEwxCPXDaObWZSpFN/CyaTtqVHOB+E=; b=UCjvAKNk3qRL0wtIeZFulvM+gi3Lpt3DhkxoSrLF6yjRt9r2tb9mhx4W lhKGnNXlzeceGN22No3PfXya0tlXu2uwLy6o+ixk/8p+sM5mXdprnsSD9 lk6qz387mb2SwT5Esqw1j4uXLeuo9CIAB++OPSfPvGQpiPJmkY40pzDEv Q=; X-IronPort-RemoteIP: 104.47.56.41 X-IronPort-MID: 76161833 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ot7e8a0KLkfPFUmLTvbD5SFwkn2cJEfYwER7XKvMYLTBsI5bp2dRz WYaWjzQaPneYDH0Ld10O9nk9RgFscXRnN4yHlZvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8UI35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj69Z1M2cqF6siwNx2PFxv9 qUcOCtXZynW0opawJrjIgVtruIKCZGxea864TRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ye5L2QwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPBkGTcoin37gPJtRL/ZNo3EZSkytkppU/UyUwJLDIYS3Lu9JFVjWb7AbqzM Xc85iMrpLN08EGtQcjwWzW5pmKJulgXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBBzZirbmUQnK17aqPoHW5Pi19BXAGTT8JS00C+daLiIMuiFTJR9VqEq+wh/X0Hy39x 3aBqy1Wr7Yek88Nkbm69FbvgjSwq5yPRQkwji3LV2es9StlZ4qoYYO55Fyd5vFFRLt1VXGEt XkA3sSbt+YHCMnXkDTXGLlUWra0+/yCLTvQx0Z1GIUs/Cis/Hjlep1M5DZ5JwFiNcNslSLVX XI/cDh5vPd7VEZGp4cuC25tI6zGFZTdKOk= IronPort-HdrOrdr: A9a23:oSjJVqkMCknOIFcaMmiWvFfeLAfpDfN1iWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SEDUOy1HYVr2KirGSjAEIeheOu9K1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge6VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPcf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcdcsvy5zXIISdOUmRIXee r30lAd1gNImjXsl1SO0F7QMs/boW8TAjHZuAelaDDY0LHErXoBerZ8bMRiA1rkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4YkWWxxjImLH4sJlON1GkcKp gmMOjMoPJNNV+KZXHQuWdihNSqQ3QoBx+DBkwPoNac3TRalG1wixJw/r1Uol4QsJYmD5VU7e XNNapl0LlIU88NdKp4QOMMW9G+BGDBSQ/FdGiSPVPkHqcaPG+lke+93JwloOWxPJAYxpo7n5 rMFFteqG4pYkrrTdaD2ZVamyq9N1lVnQ6dvv22y6IJyoEUHoCbQBFrYGpe4PeIsrEYHtDRXe q1NdZfH+LjRFGebLp04w== X-IronPort-AV: E=Sophos;i="5.92,284,1650945600"; d="scan'208";a="76161833" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N/rVNxrvdrOuRADep/cZz70gYFo/Zecwkz4NfW6lYGWk82UCmkECQ6l1YP6fwxGT3ZmIAlNUcox1ZdN5E20wAsCmemmhPBqIMSgQq0Sp3DHkGKVOulcJpyuEI9iIRU9n7Gf+LLyvStuyyqyeLK1bVLsIXmRFfVnUH87kMm4cJ19/2S9kyW5hMtO0OyCO9zyoFqOT7q8uAZtxyB4+CMj11KDrIqZrTAR5qM5oagna4PlLUL77+ZPh9r/ZrczZYvepN0fIR+b5HbJT5t3gcxjxe6ackiCTo/Xw9PJChWB137E9e5J9OmiRK75Pcd8EBNd+2/WXn+bCipI9w/mLr/Zamw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J1N65RqM0M2f7IEwxCPXDaObWZSpFN/CyaTtqVHOB+E=; b=iR18J1MKivlrS+ft2J8P+15r7h3sdBFVJI0P+ZlOnF+8xpUWBC2cYwRKjMkPc0tpbDLX+2PDLiTomHYmdesy9+VYqbvdhOHY1/WIh640AH3sYMB1EdTfW5ctmvAbve2dGfoAmkJb+UVuYjdBJxEueJr+4RJITvNXa2Z+ZcCVEDWBv0lSqYyDfsw+weCozFbeHDPLMRQnk5SXdNdiDcLyvtAzBGxlygUihMONL5zibicyfB/lfg1/hXqqfVGbwBNMjmEHQVxsPIZ6VRlTp5Xrp0fRQFVx7U6vS0qm9kQBWkc1TZqu8gpeUf8iY3zyGC3tJrBzjht3ZgWGRASDpngVCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J1N65RqM0M2f7IEwxCPXDaObWZSpFN/CyaTtqVHOB+E=; b=LlIVUQaE9JyGhbFo8/39YCWVZWjjTw2Lm3eP2doemZJkrx1n4l07kyhNZARYRJafv/ZCVfQ5LzxN/HCwQ7Z516HID8adZMwZdDrF8JGjebpv6tnaAqq8/JYh9KxTWtgQtD5ExSmNXpWRhExMaYEinBI3K40S+gweq6G1ap/MQ0I= From: Andrew Cooper To: Tamas K Lengyel , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: Re: [PATCH] xen/mem_sharing: support forks with active vPMU state Thread-Topic: [PATCH] xen/mem_sharing: support forks with active vPMU state Thread-Index: AQHYm5OTwIuHiu1fjUi8OMah1wkU8K2GAd4A Date: Tue, 19 Jul 2022 18:22:33 +0000 Message-ID: References: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> In-Reply-To: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 421aef6b-473a-4a35-c877-08da69b3a61b x-ms-traffictypediagnostic: BL1PR03MB6119:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L+UjEw8+EGIn0eq3BykkxEbtbLHzyi0OETMRHAZHkErBypgDNCEOqV/JaOfXvccZXSOaQDp9VN5OZQ35dIPxCM9CIQvKuxGC5t4IpAShV6/pOPPODl9YotwfY2pAbmQiNSNubT/k5+d0f8YmlO8FdWxFDc0lf3/EmMXKckPIfnYpRNUbjorJVG3tTlFTv1haAPuFnKjwnvDP4/NPlpQvaCaf1Cs4o6nSgfBJeOCMclQIjaxiEQwbN+fR5P0dahz1rsvSUW/X9kboYh9KKsLLIgJofXnQUO6kT4eVA8WcRbKQJjpY8iyeevPRp8xLx7V3KiduoQG4sPptWXaGDJ3YHd9X/HvJh1w7FnqbQ5gO/yBHfiI06iKt57VOoN9coKVnO2ryE7h8KhOzTrsIxuLnVf/JcpbDp0xTrHcohoqzkSvC8PkBzeTn/r3ZcXUQFFKoP9Le71+5MNmrn+EySqjHwwiO3jM/x2xiXHox2H+kahEcc2iW5a8xj+fu8D7uc0yMriUWmN3IWOEjjukv4v/orr3QBn8KY/4FSDYT4QobzDBZH6ZHmZ3QppOknAAphiVkJ/CFvtrauEqNDV2yR+6Y/JFos56vDns7R4zyvtqdB8nbk5yjmk9Rn0+Z/CX3JiosY2cyfdLeYP3VKU4X997IcoU7GHuyrSteOpRONTA3PYz9LlOl6TptljNm9t5agceoliLiW+Zm9gX4asBkPerjXPLM8IIcj3DhiWt2064xgNVgmpSnHlvlVGYs5yWk3RdJdvfRa/DAXsRePqGGX+vJH4/oHMd73eyM/jRdDMpeyJnBPlsohuzYvzJpRkFYcAAPQcnmnuORnfoAl4FkponnYMsfl9GPHOagG4XhcbIa/ng= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(31696002)(38070700005)(122000001)(41300700001)(86362001)(478600001)(66946007)(4326008)(66446008)(53546011)(91956017)(64756008)(66556008)(2616005)(8676002)(66476007)(76116006)(6486002)(8936002)(316002)(110136005)(2906002)(6506007)(38100700002)(54906003)(186003)(71200400001)(31686004)(6512007)(82960400001)(26005)(107886003)(36756003)(83380400001)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aVhFRFNMNGdZTnl3KzF2Ukx0SWIzSkM3cE1TVzdISDlJTkp1dS9OVjJGakc2?= =?utf-8?B?eEtvUWw5bk9SaURDcmw1ZG55cjJnOVNLZ2lNSGgxcjRkVzlCa0pJWjAvaUIx?= =?utf-8?B?S3ZpamE0TTlnWm1WajJodE5iaHdkV2dXWVZobnQza1lJeEJnOXRzS1g0bkl0?= =?utf-8?B?d0ppenpFQ3d1WGdnOEZCbjJ2dk9HeDRZVFpuVTNnaDlOZnk5RE11ZVpZTURJ?= =?utf-8?B?YzNkblJjc3ovdTFoRWpFajdqRnZFdnRVeUlNUEZRZ3BuTUhsWU45d0U1V1Rk?= =?utf-8?B?M0lPTEcvMWtiWVFaNTBDNkJWWi9sd0cya2dveXlkZ25RTUJNanZVSTdRdElr?= =?utf-8?B?Rnk3aWlCUXpETDh5UU52cEgvVTFJWmJVQWFIeFdsV3FVU2paTmZwL2dheDBt?= =?utf-8?B?dWRodWk3Wi9rWEFLaFJhSnJSQlowT1dnM3dPUzFGNkVEb1hKK25reFJQM3J2?= =?utf-8?B?NVJDQW5IeWQ3eXAxMW9DYlRRNmZrbnRuMFhEeHRSd1ZMcGw4d1BBS2gxNXJl?= =?utf-8?B?WHM3M1E2RWxadk5JTU01UXlKVXZzVWxPS2tOQk9XVGU2aEk4QUhXZEhUdml6?= =?utf-8?B?Nk84MERka2h6dlNMTWh4NTVHSnh0S0VKWEJyRUo0aW1waElPYjFFOUIvVzUv?= =?utf-8?B?T2kwKzVtcWZLUnZycGE2SElySWVFR1VkejBDZXJNcWtZejVkcy9GMjkzZmtF?= =?utf-8?B?YjJpaFJRT0FWMUcwZ0MySFgzUUNkbk5zdWZBRUdJbS90aGpPV0hTaFluRkZq?= =?utf-8?B?endqV0h2RGI0dUc1RWRheEk5L1BWZzVZazIzY0FubHBKZFAxblRqMDdoejdX?= =?utf-8?B?M0RXRFdLTDV4TnlxL2d5N0NPWjV5TXlhOEgydkl0dllBN2h4ekI2dWhqSkxE?= =?utf-8?B?U0Q2NVQzUm0ySTZNWVcxK1VUL3pkOG01eXQ0cDB6bWU3YmFxZEgyWUZWUG1p?= =?utf-8?B?Y0d2eDRKNC95cmYvWXZ2eVErbytVemtQT0xZbU9DR2J3R1RKL2FudG9UdzNj?= =?utf-8?B?RUxLU2piTnp5a3RaRUlwbkY3L2VBQzV4Y09TUnNNZCtBQVZYVmtHS1RDNG54?= =?utf-8?B?RElTZWNNbVZIUzJrNlVUOHBxcGRvUGVMQ2x4OGcvSTVaMzRZL28wWFlxN05K?= =?utf-8?B?a2NrZldqcXp1cyt6ZXZGUjNMRGhHVlN6dEdhM1dET2l3U1M5WVNpa3BJOWpj?= =?utf-8?B?d3A3bUF3blFCU1lTZEpZRmJkUW14MEdJTmpEQmEzZDIxYTN2Uk9aNGlWckxi?= =?utf-8?B?eFlBSllKNnFYTVZqcExPUFdJTWVTWW00c2lVZzJsendpWUlqdVR6WmFwMmdP?= =?utf-8?B?TTR6NHN1VFA1UjJHWkFza0dkZWdGYk96eGJUcjE5dzVITVE0L0ZzRU4yaEl5?= =?utf-8?B?VElRU0FMdXB0MFZicmNrNFlheVI5c01yczZjdjV1WXIvenU3UUEzbU03YmJi?= =?utf-8?B?Y0lLblYxMG5HWEFDejBSdDZSUEJGbEVNaTF5QWtDT0h3byt0aFpERHBTVjhE?= =?utf-8?B?UFQ4Y3UvaHVYME9OVkJCbkJjd2dXeStQL0UxeFdoOC95N3IvY214Mm1MM2FV?= =?utf-8?B?Wks0MndiVHZmR1E3ek9vSmtURGhQRWVnajFBaGpIN0R6NlRKU1dESzJuNG5l?= =?utf-8?B?bEN1emZ2UVpYM1RadlFrSE80d25VTVJaUUlVeVdURmJuR0t1aWw5Z1NET28z?= =?utf-8?B?K1d4cFh5MkRjRWRpQjVjbHpKdkgrRTBsZUd3UjNCd2hXaHdkRm1RVjRxTjNQ?= =?utf-8?B?N3BleDliWjFORTJHUGIzRklaYmRwUUJndkhUcnVNZDhRLzAyVHk5UEZIWlpB?= =?utf-8?B?bVJsOFR6S0R2aXZUdTluZUhtdTNIWmNaZXNGR1RKVXE0MlIyYUU5NmZCenU1?= =?utf-8?B?eEVXN3lrN2thMXhyT1FjbHlSckx3MDk1dFhMcldSL25Mdzc0UkR0UUNhTFlY?= =?utf-8?B?WDhkbGdObjlUMGtIdzlKbnd4LzZ0c3NNUzgrRDVnU2ZKTCtKcTFlRGhxN1Ru?= =?utf-8?B?Tjhya05GSFpTNjc4SExSTm1KNU9kaHY2NDNjbEpOdmJtdGFIdW1MMTVneWVj?= =?utf-8?B?RzNGcUF3K2ExdDhTUHRYTWFxMEZ0V3c0aTNiSWNqN056ekREVCtYSDcwNlNY?= =?utf-8?Q?cEof3z4rR7F2XNVy+h6jeaSHG?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 421aef6b-473a-4a35-c877-08da69b3a61b X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 18:22:33.3091 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZsAFS/8gpnrpB0P4whdnx5w+gNt/mP4/A8lkMrdNw4auA4OUw08dlfrp4LsYHCHhczXqooWrCVnUd7F+QNrwcCGu9k+ajjRczGIwAweHj3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR03MB6119 T24gMTkvMDcvMjAyMiAxODoxOCwgVGFtYXMgSyBMZW5neWVsIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gveDg2L2NwdS92cG11LmMgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXUuYw0KPiBp bmRleCBkMmMwM2ExMTA0Li4yYjVkNjRhNjBkIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYv Y3B1L3ZwbXUuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXUuYw0KPiBAQCAtNTI5LDYg KzUyOSwxNiBAQCB2b2lkIHZwbXVfaW5pdGlhbGlzZShzdHJ1Y3QgdmNwdSAqdikNCj4gICAgICAg ICAgcHV0X3ZwbXUodik7DQo+ICB9DQo+ICANCj4gK3ZvaWQgdnBtdV9hbGxvY2F0ZV9jb250ZXh0 KHN0cnVjdCB2Y3B1ICp2KQ0KPiArew0KPiArICAgIHN0cnVjdCB2cG11X3N0cnVjdCAqdnBtdSA9 IHZjcHVfdnBtdSh2KTsNCj4gKw0KPiArICAgIGlmICggdnBtdV9pc19zZXQodnBtdSwgVlBNVV9D T05URVhUX0FMTE9DQVRFRCkgKQ0KPiArICAgICAgICByZXR1cm47DQo+ICsNCj4gKyAgICBhbHRl cm5hdGl2ZV9jYWxsKHZwbXVfb3BzLmFsbG9jYXRlX2NvbnRleHQsIHYpOw0KDQpZb3UgbmVlZCB0 byBmaWxsIGluIGFuIEFNRCBwb2ludGVyLCBvciBtYWtlIHRoaXMgY29uZGl0aW9uYWwuDQoNCkFs bCBhbHRlcm5hdGl2ZXMgaGF2ZSBOVUxMIHBvaW50ZXJzIHR1cm5lZCBpbnRvIFVEcy4NCg0KU2hv dWxkIGJlIGEgdHdvLWxpbmVyIG9uIHRoZSBBTUQgc2lkZS4NCg0KPiBkaWZmIC0tZ2l0IGEveGVu L2FyY2gveDg2L2NwdS92cG11X2ludGVsLmMgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50ZWwu Yw0KPiBpbmRleCA4NjEyZjQ2OTczLi4zMWRjMGVlMTRiIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJj aC94ODYvY3B1L3ZwbXVfaW50ZWwuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50 ZWwuYw0KPiAgc3RhdGljIGludCBjb3JlMl92cG11X3ZlcmlmeShzdHJ1Y3QgdmNwdSAqdikNCj4g QEAgLTQ3NCw3ICs0ODUsMTEgQEAgc3RhdGljIGludCBjb3JlMl92cG11X2FsbG9jX3Jlc291cmNl KHN0cnVjdCB2Y3B1ICp2KQ0KPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg c2l6ZW9mKHVpbnQ2NF90KSAqIGZpeGVkX3BtY19jbnQ7DQo+ICANCj4gICAgICB2cG11LT5jb250 ZXh0ID0gY29yZTJfdnBtdV9jeHQ7DQo+ICsgICAgdnBtdS0+Y29udGV4dF9zaXplID0gc2l6ZW9m KHN0cnVjdCB4ZW5fcG11X2ludGVsX2N0eHQpICsNCj4gKyAgICAgICAgICAgICAgICAgICAgICAg ICBmaXhlZF9wbWNfY250ICogc2l6ZW9mKHVpbnQ2NF90KSArDQo+ICsgICAgICAgICAgICAgICAg ICAgICAgICAgYXJjaF9wbWNfY250ICogc2l6ZW9mKHN0cnVjdCB4ZW5fcG11X2NudHJfcGFpcik7 DQoNClRoaXMgd2FudHMgZGVkdXBsaWNhdGluZyB3aXRoIHRoZSBlYXJsaWVyIGNhbGN1bGF0aW9u LCBzdXJlbHk/DQoNCj4gICAgICB2cG11LT5wcml2X2NvbnRleHQgPSBwOw0KPiArICAgIHZwbXUt PnByaXZfY29udGV4dF9zaXplID0gc2l6ZW9mKHVpbnQ2NF90KTsNCj4gIA0KPiAgICAgIGlmICgg IWhhc192bGFwaWModi0+ZG9tYWluKSApDQo+ICAgICAgew0KPiBAQCAtODgyLDYgKzg5Nyw3IEBA IHN0YXRpYyBpbnQgY2ZfY2hlY2sgdm14X3ZwbXVfaW5pdGlhbGlzZShzdHJ1Y3QgdmNwdSAqdikN Cj4gIA0KPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBhcmNoX3ZwbXVfb3BzIF9faW5pdGNvbnN0X2Nm X2Nsb2JiZXIgY29yZTJfdnBtdV9vcHMgPSB7DQo+ICAgICAgLmluaXRpYWxpc2UgPSB2bXhfdnBt dV9pbml0aWFsaXNlLA0KPiArICAgIC5hbGxvY2F0ZV9jb250ZXh0ID0gY29yZTJfdnBtdV9hbGxv Y19yZXNvdXJjZSwNCg0KY29yZTJfdnBtdV9hbGxvY19yZXNvdXJjZSgpIG5lZWRzIHRvIGdhaW4g YSBjZl9jaGVjayB0byBub3QgZXhwbG9kZSBvbg0KVEdML1NQUi4NCg0KPiAgICAgIC5kb193cm1z ciA9IGNvcmUyX3ZwbXVfZG9fd3Jtc3IsDQo+ICAgICAgLmRvX3JkbXNyID0gY29yZTJfdnBtdV9k b19yZG1zciwNCj4gICAgICAuZG9faW50ZXJydXB0ID0gY29yZTJfdnBtdV9kb19pbnRlcnJ1cHQs DQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vdnBtdS5oIGIveGVuL2Fy Y2gveDg2L2luY2x1ZGUvYXNtL3ZwbXUuaA0KPiBpbmRleCBlNTcwOWJkNDRhLi4xNGQwOTM5MjQ3 IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vdnBtdS5oDQo+ICsrKyBi L3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS92cG11LmgNCj4gQEAgLTEwNiw4ICsxMDksMTAgQEAg dm9pZCB2cG11X2x2dHBjX3VwZGF0ZSh1aW50MzJfdCB2YWwpOw0KPiAgaW50IHZwbXVfZG9fbXNy KHVuc2lnbmVkIGludCBtc3IsIHVpbnQ2NF90ICptc3JfY29udGVudCwgYm9vbCBpc193cml0ZSk7 DQo+ICB2b2lkIHZwbXVfZG9faW50ZXJydXB0KHN0cnVjdCBjcHVfdXNlcl9yZWdzICpyZWdzKTsN Cj4gIHZvaWQgdnBtdV9pbml0aWFsaXNlKHN0cnVjdCB2Y3B1ICp2KTsNCj4gK3ZvaWQgdnBtdV9h bGxvY2F0ZV9jb250ZXh0KHN0cnVjdCB2Y3B1ICp2KTsNCj4gIHZvaWQgdnBtdV9kZXN0cm95KHN0 cnVjdCB2Y3B1ICp2KTsNCj4gIHZvaWQgdnBtdV9zYXZlKHN0cnVjdCB2Y3B1ICp2KTsNCj4gK3Zv aWQgdnBtdV9zYXZlX2ZvcmNlKHZvaWQgKmFyZyk7DQoNCk5lZWRzIHRoZSBjZl9jaGVjayB0byBj b21waWxlLg0KDQo+ICBpbnQgdnBtdV9sb2FkKHN0cnVjdCB2Y3B1ICp2LCBib29sX3QgZnJvbV9n dWVzdCk7DQo+ICB2b2lkIHZwbXVfZHVtcChzdHJ1Y3QgdmNwdSAqdik7DQo+ICANCj4gZGlmZiAt LWdpdCBhL3hlbi9hcmNoL3g4Ni9tbS9tZW1fc2hhcmluZy5jIGIveGVuL2FyY2gveDg2L21tL21l bV9zaGFyaW5nLmMNCj4gaW5kZXggOGY5ZDllZDlhOS4uMzljZDAzYWJmNyAxMDA2NDQNCj4gLS0t IGEveGVuL2FyY2gveDg2L21tL21lbV9zaGFyaW5nLmMNCj4gKysrIGIveGVuL2FyY2gveDg2L21t L21lbV9zaGFyaW5nLmMNCj4gQEAgLTE2NTMsNiArMTY1Myw1MCBAQCBzdGF0aWMgdm9pZCBjb3B5 X3ZjcHVfbm9ucmVnX3N0YXRlKHN0cnVjdCB2Y3B1ICpkX3ZjcHUsIHN0cnVjdCB2Y3B1ICpjZF92 Y3B1KQ0KPiAgICAgIGh2bV9zZXRfbm9ucmVnX3N0YXRlKGNkX3ZjcHUsICZucnMpOw0KPiAgfQ0K PiAgDQo+ICtzdGF0aWMgaW50IGNvcHlfdnBtdShzdHJ1Y3QgdmNwdSAqZF92Y3B1LCBzdHJ1Y3Qg dmNwdSAqY2RfdmNwdSkNCj4gK3sNCj4gKyAgICBzdHJ1Y3QgdnBtdV9zdHJ1Y3QgKmRfdnBtdSA9 IHZjcHVfdnBtdShkX3ZjcHUpOw0KPiArICAgIHN0cnVjdCB2cG11X3N0cnVjdCAqY2RfdnBtdSA9 IHZjcHVfdnBtdShjZF92Y3B1KTsNCj4gKw0KPiArICAgIGlmICggIXZwbXVfYXJlX2FsbF9zZXQo ZF92cG11LCBWUE1VX0lOSVRJQUxJWkVEIHwgVlBNVV9DT05URVhUX0FMTE9DQVRFRCkgKQ0KPiAr ICAgICAgICByZXR1cm4gMDsNCj4gKyAgICBpZiAoICF2cG11X2lzX3NldChjZF92cG11LCBWUE1V X0NPTlRFWFRfQUxMT0NBVEVEKSApDQo+ICsgICAgew0KPiArICAgICAgICB2cG11X2FsbG9jYXRl X2NvbnRleHQoY2RfdmNwdSk7DQo+ICsgICAgICAgIGlmICggIXZwbXVfaXNfc2V0KGNkX3ZwbXUs IFZQTVVfQ09OVEVYVF9BTExPQ0FURUQpICkNCj4gKyAgICAgICAgICAgIHJldHVybiAtRU5PTUVN Ow0KDQp2cG11X2FsbG9jYXRlX2NvbnRleHQoKSBhbHJlYWR5IGNoZWNrcyBWUE1VX0NPTlRFWFRf QUxMT0NBVEVELsKgIEJ1dA0KaXNuJ3QgdGhlIGRvdWJsZSBjaGVjayBoZXJlIHJlZHVuZGFudD8N Cg0KVGhlIHN1YnNlcXVlbnQgY2hlY2sgbG9va3MgbGlrZSB5b3Ugd2FudCB0byBwYXNzIHRoZSBo b29rJ3MgcmV0dXJuIHZhbHVlDQp1cCB0aHJvdWdoIHZwbXVfYWxsb2NhdGVfY29udGV4dCgpLg0K DQooQW5kIGlmIHlvdSBmZWVsIGxpa2UgdHVybmluZyBpdCBmcm9tIGJvb2wtYXMtaW50IHRvIHNv bWV0aGluZyBtb3JlDQpzYW5lLCBzYXkgLWVycm5vLCB0aGF0IHdvdWxkIGFsc28gYmUgZ3JlYXQu KQ0KDQpPdGhlcndpc2UsIGxvb2tzIHBsYXVzaWJsZS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:24:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:24:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370886.602832 (Exim 4.92) (envelope-from ) id 1oDrtK-0001yn-Fo; Tue, 19 Jul 2022 18:24:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370886.602832; Tue, 19 Jul 2022 18:24:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrtK-0001yg-D5; Tue, 19 Jul 2022 18:24:18 +0000 Received: by outflank-mailman (input) for mailman id 370886; Tue, 19 Jul 2022 18:24:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrtI-0001xH-Pd; Tue, 19 Jul 2022 18:24:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrtI-0005yu-N3; Tue, 19 Jul 2022 18:24:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDrtI-0008Qj-7z; Tue, 19 Jul 2022 18:24:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDrtI-0003un-7W; Tue, 19 Jul 2022 18:24:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C8eZEYuDUuaJy6ZImD7hZZxPfEJFVOh+TdpLvQew8jM=; b=FKJ7O3/GBAC2+ZNsrltUoA8HGT GzLdwMAUJJ/ucwPvQHLr5ZMD7JJkuhrGkBsyTVZAxI+b7hRFIaYqVfo4QKOlXzKIVL0zv+w0iYAqM mD2zIC87zX4MD8kIgvTgH/+afZ3UkaqHoyOcK11wvOuJmfcz3cN8Qm6VDusA5pNXU0lg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171688: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf X-Osstest-Versions-That: xen=e500b6b8d07f87593a9d0e3a391456ef4ac5ee34 From: osstest service owner Date: Tue, 19 Jul 2022 18:24:16 +0000 flight 171688 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171688/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf baseline version: xen e500b6b8d07f87593a9d0e3a391456ef4ac5ee34 Last test of basis 171685 2022-07-19 11:03:41 Z 0 days Testing same since 171688 2022-07-19 15:01:54 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git e500b6b8d0..c16a9eda77 c16a9eda77b2089206d5bc39ab6488c3793e11bf -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:33:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:33:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370926.602843 (Exim 4.92) (envelope-from ) id 1oDs1h-0004IG-AA; Tue, 19 Jul 2022 18:32:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370926.602843; Tue, 19 Jul 2022 18:32:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDs1h-0004I7-7R; Tue, 19 Jul 2022 18:32:57 +0000 Received: by outflank-mailman (input) for mailman id 370926; Tue, 19 Jul 2022 18:32:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDs1f-0004Hx-Tl; Tue, 19 Jul 2022 18:32:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDs1f-00068d-R5; Tue, 19 Jul 2022 18:32:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDs1f-0000B0-Hi; Tue, 19 Jul 2022 18:32:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDs1f-0006WK-HF; Tue, 19 Jul 2022 18:32:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=unFPYXxadyNu2sWRCbhNUNBbnwzuW3/S34GAt+enBL0=; b=mRhlhToDzebtkOJUXGeCDpxWFH KcTeot3sfhB1ecPzUms7cEj/Z/XCwFB6OzqzdOUqwt/yvCznELlFB7EDBE3KIwQ6gajwfygSHKseF sjI9V6J9pdo6Xuqzf2UK9XZ2wSE8LWXzYi6lgDikCThRfWiddCh16qmK/hOLmV8NR5go=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [seabios test] 171687: tolerable FAIL - PUSHED X-Osstest-Failures: seabios:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug seabios:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking seabios:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking seabios:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking seabios:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: seabios=46de2eec93bffa0706e6229c0da2919763c8eb04 X-Osstest-Versions-That: seabios=dc88f9b72df52b22c35b127b80c487e0b6fca4af From: osstest service owner Date: Tue, 19 Jul 2022 18:32:55 +0000 flight 171687 seabios real [real] flight 171690 seabios real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171687/ http://logs.test-lab.xenproject.org/osstest/logs/171690/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171690-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 170031 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 170031 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 170031 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 170031 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 170031 test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass version targeted for testing: seabios 46de2eec93bffa0706e6229c0da2919763c8eb04 baseline version: seabios dc88f9b72df52b22c35b127b80c487e0b6fca4af Last test of basis 170031 2022-05-03 08:44:11 Z 77 days Testing same since 171687 2022-07-19 11:10:32 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gerd Hoffmann jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/seabios.git dc88f9b..46de2ee 46de2eec93bffa0706e6229c0da2919763c8eb04 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:43:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:43:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.370968.602872 (Exim 4.92) (envelope-from ) id 1oDsBd-00075o-Qv; Tue, 19 Jul 2022 18:43:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 370968.602872; Tue, 19 Jul 2022 18:43:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsBd-00075h-O4; Tue, 19 Jul 2022 18:43:13 +0000 Received: by outflank-mailman (input) for mailman id 370968; Tue, 19 Jul 2022 18:43:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsBc-00075b-VS for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 18:43:13 +0000 Received: from MTA-09-3.privateemail.com (mta-09-3.privateemail.com [68.65.122.19]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a273327d-0792-11ed-bd2d-47488cf2e6aa; Tue, 19 Jul 2022 20:43:10 +0200 (CEST) Received: from mta-09.privateemail.com (localhost [127.0.0.1]) by mta-09.privateemail.com (Postfix) with ESMTP id 5791B18000A4 for ; Tue, 19 Jul 2022 14:43:08 -0400 (EDT) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mta-09.privateemail.com (Postfix) with ESMTPA id 3283518000A6 for ; Tue, 19 Jul 2022 14:43:08 -0400 (EDT) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-31e560aa854so38642057b3.6 for ; Tue, 19 Jul 2022 11:43:08 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a273327d-0792-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1658256188; bh=zim6bjKcQIBAxytpk4m+vm66PngIMHcON1LKe382tuw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=yO3tdMpM6eQaAMVTs0bBMGiuWEaY3kBxs7lg/jtYIEjP8aEW/luW7gVC/YoQrEJ1A Uwv5ud8eOZZx5HN/gnazlzwWZUSjLG712vPfsB+SIFvEsirBpmBbTYQq32ZAChuRir RI6fNw9F1HIots62OUb4xGEqMwxZHW+iIJ/Pwmuh/vmyKHwrjaiXr1w4iJo9aEvRbq OoXYvwaOmN2ymSROjxihTPgIINVXgArjv7qHr+6J590QNAsuT5VI8oqK26S1L5MEcd Isi4nw4Pg5i5Xi/SwIKoHW0vhH3BQ/vTJC9L+y3zMXhdR8IJlqKQ5zJKXxtKX1cKVX 8dgSHtkKRVu2g== X-Gm-Message-State: AJIora9ArUDvU6AtuO8M6+3FhGjfL7Gt00N4oQGTZeiG8gOulN69dr3Z N+wWU83lTQYIVbMob5yRz3+lBVpqThNcjef3tuc= X-Google-Smtp-Source: AGRyM1swyhWp/jAbgPVFNX2VOWUKcc6aZHi3qgbh7bhkPnOgjYLrcTtxmQj9KJni7UoTHZNofx6r1SbKZjay1jQ61HM= X-Received: by 2002:a81:7b8b:0:b0:31d:17d1:4666 with SMTP id w133-20020a817b8b000000b0031d17d14666mr37482218ywc.269.1658256187344; Tue, 19 Jul 2022 11:43:07 -0700 (PDT) MIME-Version: 1.0 References: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> In-Reply-To: From: Tamas K Lengyel Date: Tue, 19 Jul 2022 14:42:30 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] xen/mem_sharing: support forks with active vPMU state To: Andrew Cooper Cc: Tamas K Lengyel , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , George Dunlap Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jul 19, 2022 at 2:23 PM Andrew Cooper wrote: > > On 19/07/2022 18:18, Tamas K Lengyel wrote: > > diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c > > index d2c03a1104..2b5d64a60d 100644 > > --- a/xen/arch/x86/cpu/vpmu.c > > +++ b/xen/arch/x86/cpu/vpmu.c > > @@ -529,6 +529,16 @@ void vpmu_initialise(struct vcpu *v) > > put_vpmu(v); > > } > > > > +void vpmu_allocate_context(struct vcpu *v) > > +{ > > + struct vpmu_struct *vpmu = vcpu_vpmu(v); > > + > > + if ( vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) > > + return; > > + > > + alternative_call(vpmu_ops.allocate_context, v); > > You need to fill in an AMD pointer, or make this conditional. > > All alternatives have NULL pointers turned into UDs. > > Should be a two-liner on the AMD side. There is no AMD caller to this so I'll just make it conditional to ensure it's non-NULL. > > > diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c > > index 8612f46973..31dc0ee14b 100644 > > --- a/xen/arch/x86/cpu/vpmu_intel.c > > +++ b/xen/arch/x86/cpu/vpmu_intel.c > > static int core2_vpmu_verify(struct vcpu *v) > > @@ -474,7 +485,11 @@ static int core2_vpmu_alloc_resource(struct vcpu *v) > > sizeof(uint64_t) * fixed_pmc_cnt; > > > > vpmu->context = core2_vpmu_cxt; > > + vpmu->context_size = sizeof(struct xen_pmu_intel_ctxt) + > > + fixed_pmc_cnt * sizeof(uint64_t) + > > + arch_pmc_cnt * sizeof(struct xen_pmu_cntr_pair); > > This wants deduplicating with the earlier calculation, surely? Sure. > > > vpmu->priv_context = p; > > + vpmu->priv_context_size = sizeof(uint64_t); > > > > if ( !has_vlapic(v->domain) ) > > { > > @@ -882,6 +897,7 @@ static int cf_check vmx_vpmu_initialise(struct vcpu *v) > > > > static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = { > > .initialise = vmx_vpmu_initialise, > > + .allocate_context = core2_vpmu_alloc_resource, > > core2_vpmu_alloc_resource() needs to gain a cf_check to not explode on > TGL/SPR. > > > .do_wrmsr = core2_vpmu_do_wrmsr, > > .do_rdmsr = core2_vpmu_do_rdmsr, > > .do_interrupt = core2_vpmu_do_interrupt, > > diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h > > index e5709bd44a..14d0939247 100644 > > --- a/xen/arch/x86/include/asm/vpmu.h > > +++ b/xen/arch/x86/include/asm/vpmu.h > > @@ -106,8 +109,10 @@ void vpmu_lvtpc_update(uint32_t val); > > int vpmu_do_msr(unsigned int msr, uint64_t *msr_content, bool is_write); > > void vpmu_do_interrupt(struct cpu_user_regs *regs); > > void vpmu_initialise(struct vcpu *v); > > +void vpmu_allocate_context(struct vcpu *v); > > void vpmu_destroy(struct vcpu *v); > > void vpmu_save(struct vcpu *v); > > +void vpmu_save_force(void *arg); > > Needs the cf_check to compile. > > > int vpmu_load(struct vcpu *v, bool_t from_guest); > > void vpmu_dump(struct vcpu *v); > > > > diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c > > index 8f9d9ed9a9..39cd03abf7 100644 > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1653,6 +1653,50 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > > hvm_set_nonreg_state(cd_vcpu, &nrs); > > } > > > > +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > > +{ > > + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); > > + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); > > + > > + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) > > + return 0; > > + if ( !vpmu_is_set(cd_vpmu, VPMU_CONTEXT_ALLOCATED) ) > > + { > > + vpmu_allocate_context(cd_vcpu); > > + if ( !vpmu_is_set(cd_vpmu, VPMU_CONTEXT_ALLOCATED) ) > > + return -ENOMEM; > > vpmu_allocate_context() already checks VPMU_CONTEXT_ALLOCATED. But > isn't the double check here redundant? True, I could drop the top level check here. > > The subsequent check looks like you want to pass the hook's return value > up through vpmu_allocate_context(). > > (And if you feel like turning it from bool-as-int to something more > sane, say -errno, that would also be great.) Yea, I wanted to avoid having to rework the currently backwards meaning of the returned int values of vpmu functions. So that's why I double check the allocation worked instead. If I do what you recommend it would be the only vpmu function that doesn't return void and the only callback that returns error codes instead of boolean success/failure. I rather keep the code self-consistent in vpmu and just live with this arguably kinda odd looking logic here. Tamas From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:48:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:48:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371009.602901 (Exim 4.92) (envelope-from ) id 1oDsGW-0000bD-Ql; Tue, 19 Jul 2022 18:48:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371009.602901; Tue, 19 Jul 2022 18:48:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsGW-0000b6-NV; Tue, 19 Jul 2022 18:48:16 +0000 Received: by outflank-mailman (input) for mailman id 371009; Tue, 19 Jul 2022 18:48:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsGV-0000aw-ID; Tue, 19 Jul 2022 18:48:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsGV-0006Ou-Gm; Tue, 19 Jul 2022 18:48:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsGV-0000YO-5W; Tue, 19 Jul 2022 18:48:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDsGV-0000NI-59; Tue, 19 Jul 2022 18:48:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ic8D5H2V3iFO3uNDbxF5x5mEPt1kGlEkTzRDO9+ohGE=; b=2APhhXVXzZAJcC/Wo7nCc1CuwY pEwt1NQ/dfi7TQxmkAJrKTik2Q4bBKOz3Vcm7dvYDv5fyUnn/nwQPqUDmION3q+GkMKrarMpbqnEH as8RcwYZ9PSilC1kL+cWPRhkv3NRi6R6RS2ideX9m7Ufs5yDVQ4yjR/uR+l0DQtdhzig=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171689: all pass - PUSHED X-Osstest-Versions-This: ovmf=19a87683654a4969a9f86a3d02199c253c789970 X-Osstest-Versions-That: ovmf=f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 From: osstest service owner Date: Tue, 19 Jul 2022 18:48:15 +0000 flight 171689 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171689/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 19a87683654a4969a9f86a3d02199c253c789970 baseline version: ovmf f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 Last test of basis 171679 2022-07-19 03:13:39 Z 0 days Testing same since 171689 2022-07-19 16:41:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jeff Brasen jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f0064ac3af..19a8768365 19a87683654a4969a9f86a3d02199c253c789970 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 18:57:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 18:57:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371020.602911 (Exim 4.92) (envelope-from ) id 1oDsPX-0002I5-OR; Tue, 19 Jul 2022 18:57:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371020.602911; Tue, 19 Jul 2022 18:57:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsPX-0002Hy-LN; Tue, 19 Jul 2022 18:57:35 +0000 Received: by outflank-mailman (input) for mailman id 371020; Tue, 19 Jul 2022 18:57:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDsPW-0002Hs-71 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 18:57:34 +0000 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a34a2434-0794-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 20:57:31 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jul 2022 11:57:28 -0700 Received: from lkp-server02.sh.intel.com (HELO ff137eb26ff1) ([10.239.97.151]) by orsmga002.jf.intel.com with ESMTP; 19 Jul 2022 11:57:25 -0700 Received: from kbuild by ff137eb26ff1 with local (Exim 4.95) (envelope-from ) id 1oDsPM-0005v3-Vy; Tue, 19 Jul 2022 18:57:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a34a2434-0794-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658257051; x=1689793051; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=BqgXG/4LbCtAN57U01YaIg9Myl3LD4Ewp7qmwOT00PM=; b=OSDsmD1VCwQWpoVm3gGICMlCSTbsugTifyYK14Y2jBIYkgKAnNRNRwQf 0W3D0XxOlbpNbetB6qKBSTFjnkTazUL7KiPVAXfDse/o39wymr5BvBkPn kvnEl+aybSWcyuw/MT99PLFkTWkfmK8oFhHAcPlk39pfs/Uh+dKh++A55 Z5ludP7jmBTg6NH3ESVDvGBLB53yHQPJDsQRV4J9tUMJFbYEQNeoxBTVh XFSTPuEBKHIww7pLjfL/97W0Iqi7vw4Om3gk2Xgb9eDy28aN1dmhJ/oGv ZwCvKtkg3FVB6x0QEkIjX4eBrIuNexzPOy3hlWS+VCtJadXNuwDKqjs/R g==; X-IronPort-AV: E=McAfee;i="6400,9594,10413"; a="348266989" X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208";a="348266989" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,285,1650956400"; d="scan'208";a="597776942" Date: Wed, 20 Jul 2022 02:57:24 +0800 From: kernel test robot To: Dan Carpenter , Juergen Gross Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Stefano Stabellini , Oleksandr Tyshchenko , Andres Lagar-Cavilla , Konrad Rzeszutek Wilk , David Vrabel , xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] xen/privcmd: prevent integer overflow on 32 bit systems Message-ID: <202207200236.GeswjpCk-lkp@intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Hi Dan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on xen-tip/linux-next] [also build test WARNING on linus/master v5.19-rc7 next-20220719] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dan-Carpenter/xen-privcmd-prevent-integer-overflow-on-32-bit-systems/20220715-162307 base: https://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git linux-next config: x86_64-randconfig-a005 (https://download.01.org/0day-ci/archive/20220720/202207200236.GeswjpCk-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project fa0c7639e91fa1cd0cf2ff0445a1634a90fe850a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/ea22ebd83753c7181043e69251b78f0be73675ad git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dan-Carpenter/xen-privcmd-prevent-integer-overflow-on-32-bit-systems/20220715-162307 git checkout ea22ebd83753c7181043e69251b78f0be73675ad # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/acpi/ drivers/ata/ drivers/rtc/ drivers/thermal/intel/ drivers/xen/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> drivers/xen/privcmd.c:459:13: warning: result of comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] if (m.num > SIZE_MAX / sizeof(*m.arr)) ~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/xen/privcmd.c:469:13: warning: result of comparison of constant 2305843009213693951 with expression of type 'unsigned int' is always false [-Wtautological-constant-out-of-range-compare] if (m.num > SIZE_MAX / sizeof(*m.arr)) ~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. vim +459 drivers/xen/privcmd.c 441 442 static long privcmd_ioctl_mmap_batch( 443 struct file *file, void __user *udata, int version) 444 { 445 struct privcmd_data *data = file->private_data; 446 int ret; 447 struct privcmd_mmapbatch_v2 m; 448 struct mm_struct *mm = current->mm; 449 struct vm_area_struct *vma; 450 unsigned long nr_pages; 451 LIST_HEAD(pagelist); 452 struct mmap_batch_state state; 453 454 switch (version) { 455 case 1: 456 if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch))) 457 return -EFAULT; 458 /* Returns per-frame error in m.arr. */ > 459 if (m.num > SIZE_MAX / sizeof(*m.arr)) 460 return -EINVAL; 461 m.err = NULL; 462 if (!access_ok(m.arr, m.num * sizeof(*m.arr))) 463 return -EFAULT; 464 break; 465 case 2: 466 if (copy_from_user(&m, udata, sizeof(struct privcmd_mmapbatch_v2))) 467 return -EFAULT; 468 /* Returns per-frame error code in m.err. */ 469 if (m.num > SIZE_MAX / sizeof(*m.arr)) 470 return -EINVAL; 471 if (!access_ok(m.err, m.num * (sizeof(*m.err)))) 472 return -EFAULT; 473 break; 474 default: 475 return -EINVAL; 476 } 477 478 /* If restriction is in place, check the domid matches */ 479 if (data->domid != DOMID_INVALID && data->domid != m.dom) 480 return -EPERM; 481 482 nr_pages = DIV_ROUND_UP(m.num, XEN_PFN_PER_PAGE); 483 if ((m.num <= 0) || (nr_pages > (LONG_MAX >> PAGE_SHIFT))) 484 return -EINVAL; 485 486 ret = gather_array(&pagelist, m.num, sizeof(xen_pfn_t), m.arr); 487 488 if (ret) 489 goto out; 490 if (list_empty(&pagelist)) { 491 ret = -EINVAL; 492 goto out; 493 } 494 495 if (version == 2) { 496 /* Zero error array now to only copy back actual errors. */ 497 if (clear_user(m.err, sizeof(int) * m.num)) { 498 ret = -EFAULT; 499 goto out; 500 } 501 } 502 503 mmap_write_lock(mm); 504 505 vma = find_vma(mm, m.addr); 506 if (!vma || 507 vma->vm_ops != &privcmd_vm_ops) { 508 ret = -EINVAL; 509 goto out_unlock; 510 } 511 512 /* 513 * Caller must either: 514 * 515 * Map the whole VMA range, which will also allocate all the 516 * pages required for the auto_translated_physmap case. 517 * 518 * Or 519 * 520 * Map unmapped holes left from a previous map attempt (e.g., 521 * because those foreign frames were previously paged out). 522 */ 523 if (vma->vm_private_data == NULL) { 524 if (m.addr != vma->vm_start || 525 m.addr + (nr_pages << PAGE_SHIFT) != vma->vm_end) { 526 ret = -EINVAL; 527 goto out_unlock; 528 } 529 if (xen_feature(XENFEAT_auto_translated_physmap)) { 530 ret = alloc_empty_pages(vma, nr_pages); 531 if (ret < 0) 532 goto out_unlock; 533 } else 534 vma->vm_private_data = PRIV_VMA_LOCKED; 535 } else { 536 if (m.addr < vma->vm_start || 537 m.addr + (nr_pages << PAGE_SHIFT) > vma->vm_end) { 538 ret = -EINVAL; 539 goto out_unlock; 540 } 541 if (privcmd_vma_range_is_mapped(vma, m.addr, nr_pages)) { 542 ret = -EINVAL; 543 goto out_unlock; 544 } 545 } 546 547 state.domain = m.dom; 548 state.vma = vma; 549 state.va = m.addr; 550 state.index = 0; 551 state.global_error = 0; 552 state.version = version; 553 554 BUILD_BUG_ON(((PAGE_SIZE / sizeof(xen_pfn_t)) % XEN_PFN_PER_PAGE) != 0); 555 /* mmap_batch_fn guarantees ret == 0 */ 556 BUG_ON(traverse_pages_block(m.num, sizeof(xen_pfn_t), 557 &pagelist, mmap_batch_fn, &state)); 558 559 mmap_write_unlock(mm); 560 561 if (state.global_error) { 562 /* Write back errors in second pass. */ 563 state.user_gfn = (xen_pfn_t *)m.arr; 564 state.user_err = m.err; 565 ret = traverse_pages_block(m.num, sizeof(xen_pfn_t), 566 &pagelist, mmap_return_errors, &state); 567 } else 568 ret = 0; 569 570 /* If we have not had any EFAULT-like global errors then set the global 571 * error to -ENOENT if necessary. */ 572 if ((ret == 0) && (state.global_error == -ENOENT)) 573 ret = -ENOENT; 574 575 out: 576 free_page_list(&pagelist); 577 return ret; 578 579 out_unlock: 580 mmap_write_unlock(mm); 581 goto out; 582 } 583 -- 0-DAY CI Kernel Test Service https://01.org/lkp From xen-devel-bounces@lists.xenproject.org Tue Jul 19 20:08:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 20:08:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371145.602977 (Exim 4.92) (envelope-from ) id 1oDtW5-0005gI-Pu; Tue, 19 Jul 2022 20:08:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371145.602977; Tue, 19 Jul 2022 20:08:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtW5-0005gB-Mv; Tue, 19 Jul 2022 20:08:25 +0000 Received: by outflank-mailman (input) for mailman id 371145; Tue, 19 Jul 2022 20:08:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtW4-0005g5-5M for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 20:08:24 +0000 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [2607:f8b0:4864:20::732]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8a42efc0-079e-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 22:08:23 +0200 (CEST) Received: by mail-qk1-x732.google.com with SMTP id m16so7909192qka.12 for ; Tue, 19 Jul 2022 13:08:23 -0700 (PDT) Received: from pm2-ws13.praxislan02.com ([2001:470:8:67e:b68c:61:1ba8:65b6]) by smtp.gmail.com with ESMTPSA id g3-20020a05620a40c300b006b5ee4de4fbsm5789509qko.37.2022.07.19.13.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 13:08:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8a42efc0-079e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vk644Lja/mvPWFdI7/cp75V/rxQwtcwBZ/WnM74etDI=; b=NslfdsnjmFJgi4tud+4/p+a+4qFgyVz5ao0zTmxhBEpQUI8JUesTnEn9KP/Eaiv52i anPLl99GDLAdyawp2Bz4ogBTmeazEuX45VAn7m28nWiwXPDQFMqgjjpZpO+xPfgvDCaV 58YmO7alnnJJlIeVE+0GQY9tXb41qC6XtxdfVd+X1A3GioFCT2N5V8DTmStGKKTFLeHt Y8+pNYT4ZnFaoiC3FhF9WH9jsuFl00CjMXuEZoGkHCRjbzaifjDiIbCZ0i8zdC3yRh2b Xg6S9Jmw/800mLiwnoOb9/OKC5X5ukrpp8sOgY5x3tGiMnvCRCUD1RNI1BEhEtKuJLTH Zm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vk644Lja/mvPWFdI7/cp75V/rxQwtcwBZ/WnM74etDI=; b=e/UKfKHyC22IyRU+rzv/TrmvYypTgEquqJWbPs9vZo8m+WArekHrAFtM0sYIg1Cep+ OSr8zvlfOSrQc2HtnTJZ1rGPr1jMjSp7xE3pX+OBQxHyuQDiuEMcxVbYnGudI+NpdG6n lU7aYXhc6FE7KfZvmJlh755R8VPuv16DyUX7s1M4PEJSvoSkuGCUMqhN/c0evMxwDKCk sAzhwikgFP0HvDfJXLWJRmUXZjBj37m6/EBbxLrTy4CdkE+YstHam9lWdlyMy5gZf/Et au8zB+eEqT9BG6gIrSGNgO2UnU4t9BQ13h+3imsbCaAHFdJyih/oWuN0HRl8kZLjqVm7 6ruQ== X-Gm-Message-State: AJIora/AqrZh1qHtxRetc++YZ6JA3kinVsi2QC6/fVN+sBjTkO8wJGEq 2grjzCP4sWVidiWYL0kpu5JfXmSpvcQ= X-Google-Smtp-Source: AGRyM1turHQnSVWDYwsKayK4cI+X2TFxzbe8/wcxb/GlnmcMMdDoofJ65IDk1BAqD2sDp8Vbod3wPg== X-Received: by 2002:a37:b241:0:b0:6b5:5eb6:3f9f with SMTP id b62-20020a37b241000000b006b55eb63f9fmr21436100qkf.299.1658261301520; Tue, 19 Jul 2022 13:08:21 -0700 (PDT) From: Jason Andryuk To: xen-devel@lists.xenproject.org Cc: Jason Andryuk , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86: Expose more MSR_ARCH_CAPS to hwdom Date: Tue, 19 Jul 2022 16:08:15 -0400 Message-Id: <20220719200815.69884-1-jandryuk@gmail.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit commit e46474278a0e ("x86/intel: Expose MSR_ARCH_CAPS to dom0") started exposing MSR_ARCH_CAPS to dom0. More bits in MSR_ARCH_CAPS have since been defined, but they haven't been exposed. Update the list to allow them through. As one example, this allows a linux Dom0 to know that it has the appropriate microcode via FB_CLEAR. Notably, and with the updated microcode, this changes dom0's /sys/devices/system/cpu/vulnerabilities/mmio_stale_data changes from: "Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state unknown" to: "Mitigation: Clear CPU buffers; SMT Host state unknown" This ecposes the MMIO Stale Data and Intel Branch History Injection (BHI) controls as well as the page size change MCE issue bit. Fixes: commit 2ebe8fe9b7e0 ("x86/spec-ctrl: Enumeration for MMIO Stale Data controls") Fixes: commit cea9ae062295 ("x86/spec-ctrl: Enumeration for new Intel BHI controls") Fixes: commit 59e89cdabc71 ("x86/vtx: Disable executable EPT superpages to work around CVE-2018-12207") Signed-off-by: Jason Andryuk --- This is the broader replacement for "x86: Add MMIO Stale Data arch_caps to hardware domain". It wasn't discussed previously, but ARCH_CAPS_IF_PSCHANGE_MC_NO is added as well. This patch can't be directly backported because cea9ae062295 was not backported. xen/arch/x86/msr.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/msr.c b/xen/arch/x86/msr.c index 6206529162..170f041793 100644 --- a/xen/arch/x86/msr.c +++ b/xen/arch/x86/msr.c @@ -72,7 +72,9 @@ static void __init calculate_host_policy(void) mp->arch_caps.raw &= (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | ARCH_CAPS_SKIP_L1DFL | ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | - ARCH_CAPS_IF_PSCHANGE_MC_NO | ARCH_CAPS_TSX_CTRL | ARCH_CAPS_TAA_NO); + ARCH_CAPS_IF_PSCHANGE_MC_NO | ARCH_CAPS_TSX_CTRL | ARCH_CAPS_TAA_NO | + ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | ARCH_CAPS_PSDP_NO | + ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | ARCH_CAPS_BHI_NO); } static void __init calculate_pv_max_policy(void) @@ -161,7 +163,10 @@ int init_domain_msr_policy(struct domain *d) mp->arch_caps.raw = val & (ARCH_CAPS_RDCL_NO | ARCH_CAPS_IBRS_ALL | ARCH_CAPS_RSBA | - ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_TAA_NO); + ARCH_CAPS_SSB_NO | ARCH_CAPS_MDS_NO | ARCH_CAPS_IF_PSCHANGE_MC_NO | + ARCH_CAPS_TAA_NO | ARCH_CAPS_SBDR_SSDP_NO | ARCH_CAPS_FBSDP_NO | + ARCH_CAPS_PSDP_NO | ARCH_CAPS_FB_CLEAR | ARCH_CAPS_RRSBA | + ARCH_CAPS_BHI_NO); } d->arch.msr = mp; -- 2.36.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 19 20:13:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 20:13:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371152.602988 (Exim 4.92) (envelope-from ) id 1oDtbC-0007Iz-Df; Tue, 19 Jul 2022 20:13:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371152.602988; Tue, 19 Jul 2022 20:13:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtbC-0007Is-9w; Tue, 19 Jul 2022 20:13:42 +0000 Received: by outflank-mailman (input) for mailman id 371152; Tue, 19 Jul 2022 20:13:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtbB-0007Im-EM for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 20:13:41 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46077709-079f-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 22:13:39 +0200 (CEST) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 16:13:29 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB5669.namprd03.prod.outlook.com (2603:10b6:510:33::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 20:13:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 20:13:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46077709-079f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658261619; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3RUlfYEfNwp809KR8X2QzXUGlVPuOa8+6cg0oGoco3U=; b=gv2bju3Tvda9fEBZ04PVuK6gepJzniDHCPF3dvEq3Y8NnL60Wu922zyG eYqLwuVrWLLhjrVxaVCCxK9JozzErLlGC7PMSxRBGQg8YLH10p2NXH8lS Y5n0Z8Yr8J4s/PeI7Ha5XyH/+Bcl4pFA16a7pHYGnpQGczygb+NzJauvS A=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 75465074 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ZQZFBKPe6Pa+H0TvrR27lsFynXyQoLVcMsEvi/4bfWQNrUomhWcOz DMcXGrVO/uOZGrxfdoib42+8R9SsJTczoc3TQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPvS8EgHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPw868tJgISAbQxpM13BH9O7 NA1azcSO0Xra+KemNpXS8FKr+F6dozOA9lavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rn2wCWhG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFaYDBlGLarhpAgMfNjyL8R7sKJoGkrN5zx3uLmFISAREvAA7TTf6RzxTWt8hkA 04e9zcqrKMy3Fe2VdS7VBq9yFaUsxhZV9dOHukS7ACW1rGS8wufHnIDTDNKdJohrsBebSMu/ k+EmZXuHzMHjVGOYXeU97PRqCzoPyEQdDUGfXVcEVVD5MT/qoYuiB6JVsxkDKO+ktzyH3f33 iyOqy89wb4UiKbnypmGwLwOuBr0zrChc+L/zly/sr6Nhu+hWLOYWg== IronPort-HdrOrdr: A9a23:r6/UGK8ikX2p5WNgJk1uk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.92,285,1650945600"; d="scan'208";a="75465074" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TGpqxLh2RGUrXDqv+KFeluhVxHnVm/wZ8j3tjf+nyBlBJtptunOujxmDvvPqPwye7ZV882GAhbxK4DB1eV+qMdHDMnobLFXcQdOFXInyd3nFF3FxyMCuuhB52QPt5iwm10Njy+hU9qOSlEuMkFvj7Qzu/dqJaFRosGw7Fr0aH6YPeRb8ChLkVGDAW8LKfQBP263keUDoaq1/l1/yYG+9vhOu5ZUX/mT2DP41AvImD3PTsckTk8xngp+Lhm7K28ir4oFx95cxk+wcTaYwig6SGO8JiPiYVwxIUnQJhz2DF6N/vtGciEUTnLKmVdEK0lRopNo0g53mJa/mmKE5QQQY9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3RUlfYEfNwp809KR8X2QzXUGlVPuOa8+6cg0oGoco3U=; b=K5K6HE8eyCx6+tY06+ff2pnqMnkhnKeH8TvI1mKN6jMc+aaMLdhMAs8qF8gqoaCqK99OVrhSHjA9JFlVGbUD0ZAFlSoANiUwbr1VFqTQ0qalB5Hx/FxgQRovM1pVuxRV09nkrv9/SErQc/vsvN2u9DfCkxJ7O9bCYA676TXvA9kQ68YfWwxPHFwVEJLFYpzGCcBNks/shYnUoSHZmcZuhkN5lI1aoQP2e4dlwZtakUuLnFXfD2O2q/iyxdijnKL1W0lTqlWo2AXK3DaJMrR+XEyjGmJDzvIwuJ8vdMv/JmdBzP1LTVIRKdEMlGjn7sdNFuyH8YsRlkgJ5t0FoEUD+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3RUlfYEfNwp809KR8X2QzXUGlVPuOa8+6cg0oGoco3U=; b=arH8uX0IPMmOxVtO1f/XAsOJjJL9xY3ui+Y4R8InmL/k3JRIiviXHa3agV78iG+f2q406f7cO8nb5I5nMLJgfzZx346omb9LnQqNIXAP3ueHEyJZYdjn6//SOYSbfPsMhrPRAfQvXpcSRB49J2Y3GeBCMDOuFB55DsVDc0ViM8A= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86emul: add memory operand low bits checks for ENQCMD{,S} Thread-Topic: [PATCH] x86emul: add memory operand low bits checks for ENQCMD{,S} Thread-Index: AQHYm27yQ3w+gdOvIE6doYW7iaLBhq2GISKA Date: Tue, 19 Jul 2022 20:13:25 +0000 Message-ID: <58c0aaa2-035b-46a9-8faf-a7221b0a6ddf@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 78b591dd-8faf-4198-b5e5-08da69c32367 x-ms-traffictypediagnostic: PH0PR03MB5669:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aoX1TGzJS2JU2KrHeDzutx85RSbQTUEf2qwqDjT0gkKhHOiHP0ijt8pA6qvLGtLbawoZ/xiXWfsdmm9MqWE9HjRtWkjqrcNszqg+QVoRgI0kxspCp7BvvABCFPBfMA9QWGe8P6bb0W+wC9XBghG2gkWWEmozcsCykPFpwya3J8YJrOidqijXz8Tlc9GJZfOa7VH6EwiDciVb5kZaHTwGRkGJZt8CnXy7gEmCaGUpmFOn9jIF5/ZuZEwF9kFZOiljIhYdVezwZfJHOgXlTx8yEv527V/Gf33jPD6QEIEXKEgn5WGc7dvfEmDN6Rvy84kcb1dLM8e8aKa2x+pqfkDAAk+0wGQtYvcyL9xO/U174M0SKdgKszGNk9rXFE3DPbVQfMzc8TAxuvmY7Te1eIcnGmW9vosRH1u9JqIc+gKehMLjvzZTMk3iM++DQ5FfOXMehCogeG7XpF8lhHXWwvJjlVtiKovLJ95ioOONGTeUahBqwKOOe8NliGXo89Trysq1Z7JbzA+YECg195OQjEhHKmU2/sorTR+zm5l80cMcdO+DyY0ECOVJVFqDyo+3JTFKPiS75HcKy3lnnl1E0qQmH17dXZuxdNh26qSmmv0swJSMJnzSitLSwvA3Bjl//utPXSESpa4p9shOO5mS2UajVbE0cCyXuP84UMu/chdhSs3GKXd6wSgKegj5FQ+YkjzzyzCD6QXjMfGZaICXW/tLe1W5ZZL1PeviM7yo7jb0wxS0D28NsnVf1bG8yvkhZMapNUD502ruRRsXNqubfregi0eCGisjP+p7Ptc0gmbZPyNWDWkC1O9FGZZ8y7au+hVMW4bNk+vQiCg1YuKBAh/y2fgAx2cf8u0HRi9G5H/2nIQgiOcuLltbopJZ0KICzbJZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(366004)(376002)(136003)(39860400002)(8676002)(186003)(38070700005)(82960400001)(6506007)(122000001)(6512007)(41300700001)(38100700002)(6486002)(36756003)(54906003)(86362001)(316002)(71200400001)(2616005)(53546011)(2906002)(26005)(4744005)(478600001)(107886003)(64756008)(66446008)(31696002)(66556008)(66946007)(8936002)(91956017)(76116006)(66476007)(4326008)(5660300002)(31686004)(110136005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?OXVYMlZNS1pQckd2UHNKa1c5by9vSndHd1g1RGpYTkUyYjlqWmVvUEJTRzFw?= =?utf-8?B?eEZZSm5rdUErS2QreUd4ME5CaTZLbzFjYXo1MzZQeVYrUG1EZFVDVVNyZkdx?= =?utf-8?B?QTJaV2hyaERzSTFicHpvWWpBdGswRGNCTitwZ2lBLyt3SUNxdG5jV1FrcTZ4?= =?utf-8?B?TkJVTVAyQXZ4QlBYUTFIc2ZFUGZ1WWEzdWhZSG05b0l0Wi9DUDc5KytZMXJU?= =?utf-8?B?R01CTlJ1SjhTM09oR2p6Vk8wMWhqV3poZmtXVkFSU1NPWU5hUXV1YmM4ZTVq?= =?utf-8?B?SkhoOHZKS0d0dzg3NlBDUFZVd2NNdGlIRit4dUFrdW5GR0ZZNmEzWjB1TkIw?= =?utf-8?B?dGtGSG5YaUFKdHlyWW1vOFlXaGxZdjJMNi9DSFBsL3Z6QVlZYmpXc2JsZkNS?= =?utf-8?B?WDBTQ3VQK1ZMTDRCRUpDOUVIRnRYTVpzVVIveFZSb0U5UWVDV2NMTEFaam9u?= =?utf-8?B?WmVaaldoUmFzNUZCcWVkaktyWnlhQmo1SE93OUZYUjNvazR6OFZQT290NGZU?= =?utf-8?B?UUFKOEhyZVR1TGpoS2lmSkNHaTM2bDhqRGl2SVZYMm9LdGlZMnlyNFV0ZkRU?= =?utf-8?B?WHJBb2FleURWZzdZZXNDeHdUdXRrMUpYUHl2REZjUmw2cXZqWGlXVmcrNjdz?= =?utf-8?B?dThPYzFnanBnVHVLRjdmejF3WUlhSUFTVXFSWGw3d1FuR2J6SW83bmN3SWI2?= =?utf-8?B?d0FUdE5mQjBTSDYrMngxYmU4d0gxQnlPYUw2UEttVDBHTHd4MjFteDlGTnVz?= =?utf-8?B?Zk1KUytlQVc2eXF3L3FBM2NvV3FEUVBlVk9PY1hxbFk5RE1ISDFiUFpybXVy?= =?utf-8?B?NUxqR1phK3BMWE1MYkJxamQzcHdIdzhpaWRucng2UHdRN1FmaDFMeU4yN3J3?= =?utf-8?B?cmZZbUM3bFVrOHFXUWszckZQOUR5V3N0MXJ0VXhKWlhNZW8wS2pWQmJ2UVVE?= =?utf-8?B?dCtMWDExZW5hVGZhUWRKVUlhWkJBQU1VWGM1cC96cUVCdjczTUYyM29RYTNq?= =?utf-8?B?Rk02QzJKK0RhQ1ZUbW55TjZ4aEdjOURFTG1YQjhMcUEwcHRzcmc2VU4zcXYz?= =?utf-8?B?S2FsSGZIVjlNNzdpQWxVRmxRVnpaQ2pCMWhqRm9lNGplcFA2RElXTlc5ZjRW?= =?utf-8?B?b2NQUWVtZENOZ0ZSNEt4T3UwZkp3VVZLcDJWL0ltd2J3ZVRuMW90dWllanBS?= =?utf-8?B?c3VpK3VzS1puK2tEM2N2Y1hUN2dZN2dZUUxHZENaT1Zjc2dVR25pLzhCcDV4?= =?utf-8?B?RnJkMHJaOFZsWGxsdzA2ZnNHWE5oWVc1alhCN2ZiWDJrWkJHeU1FQldraytn?= =?utf-8?B?ck5iWGY1TW5RUUlleHB6MXVyQUphc0hxSzloQ0lLZkN0MmJQalRzenhTZkhM?= =?utf-8?B?Z3R0QXN0c1pkQXJMZGlaVDJRNHRaNFBGbEJxQ3E3eGpCU011cUN6YnJtTkFk?= =?utf-8?B?c1NqN3pkZytmOTJSNDVIZnpNcXdDR2lFaG8wVmJTZGMwcm9NeEpNaGFmUWpl?= =?utf-8?B?ZEVLRHQzMENUQk1IaGtrQkJ5cXJKM2V0a0psVitNMzVPcURGSXZNcEJLMGFP?= =?utf-8?B?RUtEbE1TVGtVcldqNkNRelVZS1MzL21KUENucHpwNmxuWU53T3FuMWpRUUwy?= =?utf-8?B?Z1cxZlZyTzY3dnAwOHlrZG01dUJIYVdIWHBsYndMbGxYbkUyWVlGc3ZDVk1p?= =?utf-8?B?c2lzQWJWT3kzRHNDQ2Y2RnJCRitYZy9PeFRpdXZnU2RsbG11YUZ5YWQvMCtY?= =?utf-8?B?cnM3V2FFZno1ZXRJUlIzMkxZQUR4MmFjVUJQdmxxd2FZY1V1cnBodFJvZ2t4?= =?utf-8?B?bmlXQU0rVUdpVjBjVGFkSWo2L3FmRVc2V2NXdzJ2TDRhRFYxTmxBU2dYdExG?= =?utf-8?B?Q3NVV0dWMXdEdjBvZ1hqTGorVEt3VE5WeW40aVg3bVpHYTdiZ25nK2l5cjRW?= =?utf-8?B?UUJIRDFXdlFsRTVKbjJidDM4MFlDWStxTnE5bDB2M3FGYjlPUW8xZ2NDci9o?= =?utf-8?B?aTVwbUNLdS85SytJNWlxUGl1T2RsWS9jbHZNMzl4ZXB6UEZqREdkNGdwZDU4?= =?utf-8?B?VkpQbEVLamwzbHhBVGF5aGZsakVKbEtlU1pNejZCY1pXOUVXQzdndlgrTGlx?= =?utf-8?B?bml6K3YwTDZhRS8wZWcwdnVwY0FxNzFYbzJhb0pyYk94TjFHVno2V3o5Q1JS?= =?utf-8?B?eFE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78b591dd-8faf-4198-b5e5-08da69c32367 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 20:13:25.9416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f7CN0huk8DN8Fvpb71bsLijQ4If5Q54U7SifNWZ/wK486kUFvcCN47Xqd6nMjZMx3adWgbcwC9ItxmYx2fbMky/rM3UPOd20Gd/sVVNof2o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5669 T24gMTkvMDcvMjAyMiAxMzo1NiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFscmVhZHkgSVNFIHJl diAwNDQgYWRkZWQgdGV4dCB0byB0aGlzIGVmZmVjdDsgcmV2IDA0NSBmdXJ0aGVyIGRyb3BwZWQN Cj4gbGVmdG92ZXIgZWFybGllciB0ZXh0IGluZGljYXRpbmcgdGhlIGNvbnRyYXJ5Og0KPiAtIEVO UUNNRCByZXF1aXJlcyB0aGUgbG93IDMyIGJpdHMgb2YgdGhlIG1lbW9yeSBvcGVyYW5kIHRvIGJl IGNsZWFyLA0KPiAtIEVORENNRFMgcmVxdWlyZXMgYml0cyAyMC4uLjMwIG9mIHRoZSBtZW1vcnkg b3BlcmFuZCB0byBiZSBjbGVhci4NCj4NCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPg0KPiAtLS0NCj4gSSdtIGEgbGl0dGxlIHJlbHVjdGFudCB0byBhZGQg YSBGaXhlczogdGFnIGhlcmUsIGJlY2F1c2UgYXQgdGhlIHRpbWUNCj4gdGhlIGNvZGUgd2FzIHdy aXR0ZW4gdGhlIGJlaGF2aW9yIHdhcyBtYXRjaGluZyB3aGF0IHdhcyBkb2N1bWVudGVkLg0KDQpJ dCBuZWVkcyBhIHRhZywgYmVjYXVzZSB0aGlzIGlzIGZpeGluZyBhIHByb2JsZW0gaW4gYSBwcmV2 aW91cyBwYXRjaCwNCmFuZCBpbiBwcmluY2lwbGUgd2FudHMgYmFja3BvcnRpbmcgdG8gNC4xNC4N Cg0KSXQgZG9lc24ndCBtYXR0ZXIgdGhlIGNhdXNlIG9mIHRoZSBlcnJvciwgYW5kICJJbnRlbCBj aGFuZ2VkIHRoZWlyDQpkb2N1bWVudGF0aW9uIiBpcyBwcmV0dHkgZ29vZCBhcyBmYXIgYXMgZXhj dXNlcyBnby4NCg0KQXMgZmFyIGFzIHRoZSBjaGFuZ2UgZ29lcywgdGhhdCBkb2VzIHNlZW0gdG8g bWF0Y2ggdGhlIGxhdGVzdCBkb2NzLg0KDQpBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT4NCg== From xen-devel-bounces@lists.xenproject.org Tue Jul 19 20:29:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 20:29:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371160.602999 (Exim 4.92) (envelope-from ) id 1oDtqG-0000y5-SH; Tue, 19 Jul 2022 20:29:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371160.602999; Tue, 19 Jul 2022 20:29:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtqG-0000xy-OD; Tue, 19 Jul 2022 20:29:16 +0000 Received: by outflank-mailman (input) for mailman id 371160; Tue, 19 Jul 2022 20:29:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDtqF-0000xs-D5 for xen-devel@lists.xenproject.org; Tue, 19 Jul 2022 20:29:15 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73683edf-07a1-11ed-924f-1f966e50362f; Tue, 19 Jul 2022 22:29:14 +0200 (CEST) Received: from mail-bn8nam11lp2169.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.169]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 19 Jul 2022 16:29:04 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA2PR03MB5676.namprd03.prod.outlook.com (2603:10b6:806:116::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 20:29:02 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 20:29:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73683edf-07a1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658262553; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dfd9Qg21koYFJWiBMBhFrh7igxUgJod9k0RsrkbG4TE=; b=N0yhboaGd7BrzOH9kGjJXVI+9itqBuGaKI2XP8wgh+2FnRLh7+D7nSOM 2m2QYKxO35hgpevDwNqeRQu482+xJmSiNzb+fj+bm2Hz8PlWPQ7J5Vtmg 56zV9WHpZ9S7Px3nMNpdGLg8zJo76BRORkwPreoFbh5+PF79KsgmSH5Cd Q=; X-IronPort-RemoteIP: 104.47.58.169 X-IronPort-MID: 78740272 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5wc4h6/9+I8Qd4wqzk5YDrUDtX+TJUtcMsCJ2f8bNWPcYEJGY0x3m GIdDDzVP/6KZ2T1KNtwbYW2oRtU6JOBx9RqTVBsqSw8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gVaYDkpOs/jZ8Ew27ayp0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGVhgLOYoC3OFNIUJX0 /YFBiodfzuhvrfjqF67YrEEasULCuDOZdpakFcwiDbTALAhXIzJRLjM6ZlAxjAsi8tSHPHYI c0EdT5oaxeGaBpKUrsVIMtmwKH02T+iI3sB9gP9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WXVrS703LCV9c/9cJ0sJbKg+fxOuWGC4WwfOC0IX3GEhebs3yZSXPoac ST44BEGr6E0+Fa6U9rVUBixoXrCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht9HjCCFrsbaVYWmA7brSpjS3UQAKKUcSaClCShEKi+QPu6k2hxPLC9xlQKi8i4SsHSmqm m7b6i8jm78UkMgHkb2h+kzKiC6toZ6PSRMp4gLQXSSu6QYRiJOZWrFEIGPztZ5oRLt1hHHa1 JTYs6ByNNwzMKw= IronPort-HdrOrdr: A9a23:fp1UH6mcZ0O4Apl83G57Hs9xuKTpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.92,285,1650945600"; d="scan'208";a="78740272" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NKtnHlgKYWGyTCrBwIF8d+l92oRf5aNc4VFDBmvlGyqI/jQYINDWxSYik6dj/09gwlIatiJ84aDIoLiLkOMNbLujsbviaAqvDtlYohtlE7B51FvTa8dmIVGp3fbEpIGNPWw7OHLUGa58FRrC1PSSbjmSUhlXGki0hjnXytuwaeV0FSi+goLYv+5xptRrZdUr4BSoeARJrIHyAru2Q2kJDj5dhgzMgDTnzwrtKF0NChonHu1p0EnGxQl5dWYOFGcVjNgQMY+5cQS5tl8TUY+uLR90XWGBABDzSmm/76T8I39Nvzx82jOpwktLJ4etwtoHaFLEMmTusFxducOu0C21zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dfd9Qg21koYFJWiBMBhFrh7igxUgJod9k0RsrkbG4TE=; b=kCmHvHFJIE20xjLfjBHqFVUBy/awlBmoFNq05an4neULizG7T026PNBRVdRe6m64Fys+bs1PRNWAetn3afMTbwpJV0BmNtD3jDNFCJ0R+V5zvCg00xnmvxt/qZKZrTOoW5qUjRJ32OYIPCp2BZCZcoEd44PE0bu3X0Fi29diPZ0P+TZ1Ecq+OyqkZo0FbYAv6R/dSCjsG9QfR8ktQjXwI6b7TQRfRjVzJRBvARoZvIR/Tta5iUsB2MdP1V1CXkuysdMJ/OtQvKwoSPrq9A4hV6KGbAyYCRw+UjWh3+j2+SPgOUyeoLs22s/Hx9iZfGrJD7bI01qbipomwZQ/w8kYIQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dfd9Qg21koYFJWiBMBhFrh7igxUgJod9k0RsrkbG4TE=; b=wczjExH7fRgvS3qe2H2HOXYUYpwYAoc+MRSAXGEuHS/VDPTa4HgMEAWcRsPjSp67vEezVZpy/4Fku2yXAoOaTClw2kd3r8Z5eJPwbHSo3IU4kpSUhZEJJw977um3POt5Ji7LHUnHbEWuj3U36/PrljgB+pa/bggbFm0yF6KOPwA= From: Andrew Cooper To: Jason Andryuk , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH] x86: Expose more MSR_ARCH_CAPS to hwdom Thread-Topic: [PATCH] x86: Expose more MSR_ARCH_CAPS to hwdom Thread-Index: AQHYm6tQOqkwxP1MXkWBPUBpFSB52q2GJQcA Date: Tue, 19 Jul 2022 20:29:02 +0000 Message-ID: <5a1e78c8-1982-f787-46a4-7197b23d53e8@citrix.com> References: <20220719200815.69884-1-jandryuk@gmail.com> In-Reply-To: <20220719200815.69884-1-jandryuk@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b325d08c-a3b9-4c24-e7c6-08da69c551c6 x-ms-traffictypediagnostic: SA2PR03MB5676:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O1MlW1hOigqa9yj26JRqx8OmVC1oUW6IVV+iW3qMiLALUbbbgx7IJf2BHInlhUJ9T1xN+bzaSpvjX84Cr2mNTZiJG6b89GbB7FRR34cR8umKDlT/OXXRiEhgoC8y1MILw9GUzZyf93zagU/LMDcYIu7T5wkXqgF4f5G8NFKe7ZJrPsh4n4i9MtUS2JuqzB1oF5X/LrqddraAPz0nqxbtnG2XwFdP9+OuNpDJwZkZN7ZZfWExgDkVaqVx7KcUATmF72Yh7CExncUxdP6WzBAUson+JDz3hnoNqTAdkdnwrD8mbW9w0xkZBQ46iRH0uYNQOfHfc4x/aHY/HOApamd0j1fvlaDsaIyasRw9HDFIgqzsvvd44Km26paoNHlyPgR7V7mxjYO3TYKK7R99Jh7TTmSCgjYOwW50bi3mEqB0AxQu0IlSqhbxby24d0bmQO+DYIDiC7ZL2RamsfPmORVKhgvWSYaNmQ0+Mx4qPsJGNFQpXzafR7OXNOk0c0F6QYDR7hjbNEuNTzHV6V3cH7FvG41lJaQg1jpiHeDtEtQQMR8Ea0DwtsM2tInCO40wtusVu2PlOV70xFSiebrv3EFwwsa8OO9CmRHdFlfYjN9w2dbR6OYH3iFWLYB/WE+g/1SczGfY6Ew2rmhpq4s3Y+bdsu1N+SvhLINkfxrh081q0ROgqM7dvVheKVjqajA+Wf/uKGpg3RFWXM7lgufRs9wHKeUsksB7Vz/0eGL9sVYFp5yH17NRS+b7kW+XRZAqS+0vxyQOuGyZAySen7QhJOJaMxpkh9oCkYE2CRajChvPBB5oYHKko9I5YOrExoKB2zt7GHhjE2zeydGKZSgc4N+b7pQeMyDgc4MAsMSRNzoOL01hQiaymIsLu2qVHbIMdJHV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(39860400002)(346002)(366004)(41300700001)(5660300002)(66556008)(76116006)(66946007)(83380400001)(91956017)(54906003)(64756008)(38070700005)(8936002)(6512007)(8676002)(66446008)(26005)(53546011)(66476007)(31686004)(316002)(6506007)(36756003)(110136005)(31696002)(82960400001)(186003)(38100700002)(2616005)(478600001)(86362001)(71200400001)(4326008)(2906002)(6486002)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WDMyeVk0RmVrbHhWUDlRWDFpWktvMmlJdGJQVUdFY1VOd1ZjSDUzMGo3U01R?= =?utf-8?B?a0VWc2xtM2lsQUd4OTd1cXMxMWRwZm5UcnZVZVMyREl1Tnh0b1N3KzJWYXpW?= =?utf-8?B?RlJObHBtLzFEVS81Umt0NVo2SnlMQ0JuNGJoNTE2cEpxVlFzU25TZ0xEanFR?= =?utf-8?B?NlQ4aDRzYy9yMjJWTWlwSFBlKzRybERKcTNzWDlGNTE3MWZFMjZjZmFjUVA3?= =?utf-8?B?V2pjMjErUitzelV3bm51UExUTm1waEFWNjg2bWg5aEZZSHJwU3RjdWs4V2xi?= =?utf-8?B?WW9hN0w4TjFlMVNHcWljNFNpZ2hwV01BUmpEdU1Nd2w5ZlFBR2ZHcjlrWE82?= =?utf-8?B?VDlvM3VKQXJ0TkN5RitCem11VTM2WWlJOGNiN0hoc1I2WUxpZFJuS2UzTWJL?= =?utf-8?B?MWlqRzdsUmhFQkdlOHNISHRETkJ2WFBIcWlYRy9xVkxES2EvRDRrZFg5N3Ny?= =?utf-8?B?bnE0ak52UXdVNzlGblZsbk9GcFg3dkZMMWVTVFZKLzJybEdEdWVVQlFJTGs2?= =?utf-8?B?Z2NDRmQyVzJ2NVZ2SnFVL3N4Y0lxOHNQSWhxTnF6SG5LVGQxVTNWa3UxUERM?= =?utf-8?B?VWNIZVpnVEM4NnJFY1Z4SEdHamduWm9nMitlb0hhRFRCemltdjNkYkZJVzJH?= =?utf-8?B?RHJUT2lJbE1JOWFNZlBHdEE2a2lRTlNQdXBSdWJjVVRWeWt3bHhXclBqREhR?= =?utf-8?B?L0ZVZ0UxQVFNb0U1bzdyZWRIbU5aR3Y5ZkhJRENhUU9aZXAxaVJ0a3pXa2xn?= =?utf-8?B?azh2cGVjYkJsZmZ3UkxzUVk4V0g1VExVZWkyeEc4R2tkZUZLblc3OVVzVVkv?= =?utf-8?B?cmdobys4UU1HRmNPRm1ockRqb0U0SS9idnNaRXhaUkJSazRkaVNDRmpQbkNv?= =?utf-8?B?ZWlreDJkcGx4a2VjZnN1S1A0dzdaTE5YdTZvSHkzNDIyRzVKKzFzRXdXZFZL?= =?utf-8?B?V3VzMDhuNVB2MWNkck13QUFrd1JmeWg2VlFyV3JnZEhSM1ZVVWoxWk5pbnh4?= =?utf-8?B?SzVKS3RZV2c4c2lGUHdHdUs4S2tnYURsc1pIU3IxZ0hNeXN3MjFNbXJEMFph?= =?utf-8?B?ZDdORlc4T05ERG1zdmZ6eGpjd09vRUxpK3FWYnpSSTdCZzhDRC9OSEFXVENu?= =?utf-8?B?aXorMkNEUW85SXI3VlRWUjd4cEIvdzluS1RqbDZXc2VSSzZMSmFTcHdGMktE?= =?utf-8?B?QVV1NHNCSk5GWE91anozdEJYQk5QclZiT01PYStOMlViOWk3MHIvbHdtOTlY?= =?utf-8?B?cCtZeHhtaW5QbFFxQ3dDSVZzMDhMc1o0WjR2RmVDLzRWempPN3l6ek56djNX?= =?utf-8?B?RjZtVkpFdDRJS2VRMFBFRWh4SDRsRDRpTEpqYmJZVnQ2dExvSThTV0FZaWlD?= =?utf-8?B?d3hPUUsvR2VGUnp1K2RlMktsZFpKbURydGsvSVN2M05DelpGZ1JESzczdjdm?= =?utf-8?B?NENDWjcwL05vUk02MUZ0V1NkOFAzQzJybHpRQ0VrWEF3OEZiYmgwdXVBcHFm?= =?utf-8?B?RjNpSjZYSlhwOWZDM3hmTms0MGR0VmkwYXdQcmdNTDRiZ2hOcTlQY3NsZFli?= =?utf-8?B?T1FpK1oxRmxVUzRMUDNTOHhzYjQ3eU9oUW1na2xBSnJ2RWhTWStMTHNQUmh3?= =?utf-8?B?SW1FcytWNnJGaEo2Ni8wYnpBckc4UDZCNnhkaXp1REg0d05uVkZ3Q3JZOExj?= =?utf-8?B?bEVHWFZ4Z1dEcXByaUJKRzFsazlER3Y4azFWcFRUd2JOTkJ6djVUdzRJbDk3?= =?utf-8?B?ZjNhQXN5a2dURDJlRldWQmd6TTR3dzBxR2xTanJKdElOMlVxaENLdkhubnpp?= =?utf-8?B?UzFnWTJBMDJtWXozcHVqM1Qxb2dlQjEraWw4NndCMytqOTlCK2F4eldCelhw?= =?utf-8?B?Snd3bGk4ajA1bTdSNUpuNHNoZlhjK1VKR1Y1OXpvRnlSc25BOUFyWVBwNnU4?= =?utf-8?B?REpoQWlvWjkyRFhxTkZMMDc4U0tnWEowcUdVeGFFaXJOV2FkQVZuc3NPdWNv?= =?utf-8?B?RFl5K2Q3clUySTZueUpWeWdVWC91SWJyclB5Qm5kT3VEcHNjTklUWnZRQjZF?= =?utf-8?B?cnRwSlVQMEo0MFVud1hKcm9qTTNWdVNvSlBiTEttT0xOTXVwMjNpQlVRc2RN?= =?utf-8?B?eGVUQkFNWHR0RkNRU2w0UnlWWURnQ3BTYmNrekMxMkZHRnFYbG5yM3k2Y1ZL?= =?utf-8?B?dlE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b325d08c-a3b9-4c24-e7c6-08da69c551c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 20:29:02.7341 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3NDH39LDHsGT08cm0VayscgM9DqrXNtVn50oV6hrthDNCWHaI9/DLnwSUgE2AuV3dCNu6QP25uB/ldDaa72bS93qt1oO96odzN5Q3zlMy4g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5676 T24gMTkvMDcvMjAyMiAyMTowOCwgSmFzb24gQW5kcnl1ayB3cm90ZToNCj4gY29tbWl0IGU0NjQ3 NDI3OGEwZSAoIng4Ni9pbnRlbDogRXhwb3NlIE1TUl9BUkNIX0NBUFMgdG8gZG9tMCIpIHN0YXJ0 ZWQNCj4gZXhwb3NpbmcgTVNSX0FSQ0hfQ0FQUyB0byBkb20wLiAgTW9yZSBiaXRzIGluIE1TUl9B UkNIX0NBUFMgaGF2ZSBzaW5jZQ0KPiBiZWVuIGRlZmluZWQsIGJ1dCB0aGV5IGhhdmVuJ3QgYmVl biBleHBvc2VkLiAgVXBkYXRlIHRoZSBsaXN0IHRvIGFsbG93DQo+IHRoZW0gdGhyb3VnaC4NCj4N Cj4gQXMgb25lIGV4YW1wbGUsIHRoaXMgYWxsb3dzIGEgbGludXggRG9tMCB0byBrbm93IHRoYXQg aXQgaGFzIHRoZQ0KPiBhcHByb3ByaWF0ZSBtaWNyb2NvZGUgdmlhIEZCX0NMRUFSLiAgTm90YWJs eSwgYW5kIHdpdGggdGhlIHVwZGF0ZWQNCj4gbWljcm9jb2RlLCB0aGlzIGNoYW5nZXMgZG9tMCdz DQo+IC9zeXMvZGV2aWNlcy9zeXN0ZW0vY3B1L3Z1bG5lcmFiaWxpdGllcy9tbWlvX3N0YWxlX2Rh dGEgY2hhbmdlcyBmcm9tOg0KPiAiVnVsbmVyYWJsZTogQ2xlYXIgQ1BVIGJ1ZmZlcnMgYXR0ZW1w dGVkLCBubyBtaWNyb2NvZGU7IFNNVCBIb3N0IHN0YXRlDQo+IHVua25vd24iDQo+IHRvOg0KPiAi TWl0aWdhdGlvbjogQ2xlYXIgQ1BVIGJ1ZmZlcnM7IFNNVCBIb3N0IHN0YXRlIHVua25vd24iDQo+ DQo+IFRoaXMgZWNwb3NlcyB0aGUgTU1JTyBTdGFsZSBEYXRhIGFuZCBJbnRlbCBCcmFuY2ggSGlz dG9yeSBJbmplY3Rpb24NCj4gKEJISSkgY29udHJvbHMgYXMgd2VsbCBhcyB0aGUgcGFnZSBzaXpl IGNoYW5nZSBNQ0UgaXNzdWUgYml0Lg0KPg0KPiBGaXhlczogY29tbWl0IDJlYmU4ZmU5YjdlMCAo Ing4Ni9zcGVjLWN0cmw6IEVudW1lcmF0aW9uIGZvciBNTUlPIFN0YWxlIERhdGEgY29udHJvbHMi KQ0KPiBGaXhlczogY29tbWl0IGNlYTlhZTA2MjI5NSAoIng4Ni9zcGVjLWN0cmw6IEVudW1lcmF0 aW9uIGZvciBuZXcgSW50ZWwgQkhJIGNvbnRyb2xzIikNCj4gRml4ZXM6IGNvbW1pdCA1OWU4OWNk YWJjNzEgKCJ4ODYvdnR4OiBEaXNhYmxlIGV4ZWN1dGFibGUgRVBUIHN1cGVycGFnZXMgdG8gd29y ayBhcm91bmQgQ1ZFLTIwMTgtMTIyMDciKQ0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBBbmRy eXVrIDxqYW5kcnl1a0BnbWFpbC5jb20+DQo+IC0tLQ0KPiBUaGlzIGlzIHRoZSBicm9hZGVyIHJl cGxhY2VtZW50IGZvciAieDg2OiBBZGQgTU1JTyBTdGFsZSBEYXRhIGFyY2hfY2Fwcw0KPiB0byBo YXJkd2FyZSBkb21haW4iLg0KPg0KPiBJdCB3YXNuJ3QgZGlzY3Vzc2VkIHByZXZpb3VzbHksIGJ1 dCBBUkNIX0NBUFNfSUZfUFNDSEFOR0VfTUNfTk8gaXMgYWRkZWQNCj4gYXMgd2VsbC4NCg0KSSBk ZWxpYmVyYXRlbHkgZXhjbHVkZWQgSUZfUFNDSEFOR0VfTUNfTk8gYmVjYXVzZSBpdCB3YXNuJ3Qg cmVsZXZhbnQuwqANCkJ1dCBJIHN1cHBvc2UgTGludXggaXMgbG9va2luZyBmb3IgaXQgYW55d2F5 Pw0KDQpJRl9QU0NIQU5HRV9NQ19OTyBpcyB0aGUgbW91dGhmdWwgbWVhbmluZyAidGhlIGZyb250 ZW5kIGRvZXNuJ3QgaGF2ZSBhDQpzdHJvcCB3aGVuIGl0IHRha2VzIGFuIGFzc2lzdCBmaW5kcyB0 aGF0IHRoZSBpVExCIG1hcHBpbmcgaGFzIGNoYW5nZWQiLsKgDQpJdCdzIG9ubHkgaW50ZXJlc3Rp bmcgdG8gaHlwZXJ2aXNvcnMgbG9va2luZyBhZnRlciBhbiBFUFQgZ3Vlc3QsIHdoaWNoDQptZWFu cyB0aGF0IGl0J3Mgb25seSBpbnRlcmVzdGluZyB0byBleHBvc2UgdG8gSEFQIGd1ZXN0cyB3aXRo IG5lc3RlZA0KdmlydC7CoCBFeGNlcHQgd2UgZGlzYWJsZSBtaXRpZ2F0aW9ucyBmb3IgbmVzdGVk IHZpcnQgYmVjYXVzZSB0aGVyZSdzIGENCmJ1ZyBpbiB0aGUgbkhBUCBjb2RlIHdoaWNoIEkgZGlk bid0IGhhdmUgdGltZSB0byBmaWd1cmUgb3V0LCBhbmQgbm9uZSBvZg0KdGhpcyBpcyByZW1vdGVs eSBzZWN1cml0eSBzdXBwb3J0ZWQgdG8gc3RhcnQgd2l0aC4NCg0KSW4gcHJpbmNpcGxlLCBUQUFf Tk8ncyB2aXNpYmlsaXR5IHNob3VsZCBiZSBkZXBlbmRlbnQgb24gdGhlIHZpc2liaWxpdHkNCm9m IFJUTSwgYnV0IGdpdmVuIHRoaXMgaXMgYWxsIGEgcGlsZSBvZiBoYWNrcyBhbnl3YXksIEknbSBu b3Qgc3VyZSBob3cNCm11Y2ggSSBjYXJlIGF0IHRoaXMgcG9pbnQuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Tue Jul 19 20:49:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 20:49:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371167.603009 (Exim 4.92) (envelope-from ) id 1oDu9Z-0003qh-GV; Tue, 19 Jul 2022 20:49:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371167.603009; Tue, 19 Jul 2022 20:49:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDu9Z-0003qa-Dj; Tue, 19 Jul 2022 20:49:13 +0000 Received: by outflank-mailman (input) for mailman id 371167; Tue, 19 Jul 2022 20:49:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDu9Y-0003qQ-Ga; Tue, 19 Jul 2022 20:49:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDu9Y-00006D-96; Tue, 19 Jul 2022 20:49:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDu9X-0003iJ-Sy; Tue, 19 Jul 2022 20:49:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDu9X-0004ys-SU; Tue, 19 Jul 2022 20:49:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uDrdibcCexAZo/jYOkhWmGMRYqtlhm07ji7rVoIE1p8=; b=6ZwTWylobrbpYIkk5Ya4XTnxjQ mY5VAmXMzvWBBFtDxwQ720PzhAsG8p387/8ByZEnahqDJUk8MyJ1E8DovnakidTjI3NulbWuPbEJ0 IHS2zlnTe1lpyvAmEnaDbqX3NaXpGP3KvE1HUF530FPC9x5+kzmTSaBzsDxTwUNhTjf0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171683: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start:fail:allowable qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=b8bb9bbf4695b89bbdca702a054db0a7a2c8ff2b X-Osstest-Versions-That: qemuu=782378973121addeb11b13fd12a6ac2e69faa33f From: osstest service owner Date: Tue, 19 Jul 2022 20:49:11 +0000 flight 171683 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171683/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail REGR. vs. 171676 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171676 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171676 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171676 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171676 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171676 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171676 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171676 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171676 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu b8bb9bbf4695b89bbdca702a054db0a7a2c8ff2b baseline version: qemuu 782378973121addeb11b13fd12a6ac2e69faa33f Last test of basis 171676 2022-07-18 22:40:16 Z 0 days Testing same since 171683 2022-07-19 09:07:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cédric Le Goater Daniel Henrique Barboza Fabiano Rosas Jason A. Donenfeld Leandro Lupori Lucas Coutinho Mark Cave-Ayland Matheus Ferst Murilo Opsfelder Araujo Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7823789731..b8bb9bbf46 b8bb9bbf4695b89bbdca702a054db0a7a2c8ff2b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Jul 19 20:52:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 20:52:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371175.603021 (Exim 4.92) (envelope-from ) id 1oDuD4-0005Ib-6j; Tue, 19 Jul 2022 20:52:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371175.603021; Tue, 19 Jul 2022 20:52:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDuD4-0005IU-3Q; Tue, 19 Jul 2022 20:52:50 +0000 Received: by outflank-mailman (input) for mailman id 371175; Tue, 19 Jul 2022 20:52:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDuD2-0005IF-Vw; Tue, 19 Jul 2022 20:52:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDuD2-0000Aw-V0; Tue, 19 Jul 2022 20:52:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDuD2-0003n1-I4; Tue, 19 Jul 2022 20:52:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDuD2-0006BO-Ha; Tue, 19 Jul 2022 20:52:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=q8SIdDtSPYqz+GrNan5sb6dvYvakENIQQmSlEIHln/o=; b=3VadKrYxrAykd4PWzAHHY1de6E oh/SYusmsPWb7bCU9M2Ok4hKE1l0yXO1jM3sboiMJ1x+glajvzsnUENObrNnHRaElVGVS+Q7pHLSJ l/rx0nG2+GqpYSBG/tNiQ9RgVkN7yc34JQJ/VlbGWb0MNESfEQFW9szua5gOsLr+GGGg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171691: all pass - PUSHED X-Osstest-Versions-This: ovmf=671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d X-Osstest-Versions-That: ovmf=19a87683654a4969a9f86a3d02199c253c789970 From: osstest service owner Date: Tue, 19 Jul 2022 20:52:48 +0000 flight 171691 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171691/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d baseline version: ovmf 19a87683654a4969a9f86a3d02199c253c789970 Last test of basis 171689 2022-07-19 16:41:40 Z 0 days Testing same since 171691 2022-07-19 19:12:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Saloni Kasbekar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 19a8768365..671b0cea51 671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 19 22:23:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 19 Jul 2022 22:23:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371184.603031 (Exim 4.92) (envelope-from ) id 1oDvcT-0007nz-L4; Tue, 19 Jul 2022 22:23:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371184.603031; Tue, 19 Jul 2022 22:23:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDvcT-0007ns-IN; Tue, 19 Jul 2022 22:23:09 +0000 Received: by outflank-mailman (input) for mailman id 371184; Tue, 19 Jul 2022 22:23:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDvcR-0007ni-NG; Tue, 19 Jul 2022 22:23:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDvcR-0001hy-Ig; Tue, 19 Jul 2022 22:23:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDvcQ-0006In-Vg; Tue, 19 Jul 2022 22:23:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oDvcQ-0004Yl-V2; Tue, 19 Jul 2022 22:23:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FUp8jD0wyoOm6NCkXKhHTDNMbbXxQS+nhXPPa0wV9iY=; b=iSqH+iQdxx6xcjwfCz6l6m1irS euRjwLag0mXko8RikzDLy3CGMoUp7fCb0qnLmkUILA9li9aFomdbf/Y7Tkpq0Egvgb8sCub4Ot3d9 lAghNrWc69yevQkO7KfceNI95YTp11kzyVCzge2XNTS+i3gGuG7wyBweXmvDdaHgzsyU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171686: regressions - FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-debianhvm-i386-xsm:debian-hvm-install:fail:regression xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9723507daf2120131410c91980d4e4d9b0d0aa90 X-Osstest-Versions-That: xen=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee From: osstest service owner Date: Tue, 19 Jul 2022 22:23:06 +0000 flight 171686 xen-unstable real [real] flight 171692 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171686/ http://logs.test-lab.xenproject.org/osstest/logs/171692/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-i386-xsm 12 debian-hvm-install fail REGR. vs. 171678 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171678 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171678 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171678 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171678 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171678 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171678 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171678 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171678 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 9723507daf2120131410c91980d4e4d9b0d0aa90 baseline version: xen 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee Last test of basis 171678 2022-07-19 03:09:55 Z 0 days Testing same since 171686 2022-07-19 11:07:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm fail test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 9723507daf2120131410c91980d4e4d9b0d0aa90 Author: Jan Beulich Date: Tue Jul 19 08:37:29 2022 +0200 x86: deal with gcc12 release build issues While a number of issues we previously had with pre-release gcc12 were fixed in the final release, we continue to have one issue (with multiple instances) when doing release builds (i.e. at higher optimization levels): The compiler takes issue with subtracting (always 1 in our case) from artifical labels (expressed as array) marking the end of certain regions. This isn't an unreasonable position to take. Simply hide the "array-ness" by casting to an integer type. To keep things looking consistently, apply the same cast also on the respective expressions dealing with the starting addresses. (Note how efi_arch_memory_setup()'s l2_table_offset() invocations avoid a similar issue by already having the necessary casts.) In is_xen_fixed_mfn() further switch from __pa() to virt_to_maddr() to better match the left sides of the <= operators. Reported-by: Charles Arnold Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit fdbf8bdfebc2ed323c521848f642cc4f6b8cb662 Author: Jan Beulich Date: Tue Jul 19 08:36:53 2022 +0200 x86/spec-ctrl: correct per-guest-type reporting of MD_CLEAR There are command line controls for this and the default also isn't "always enable when hardware supports it", which logging should take into account. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper commit 59ec934d538c24265e29667aac5a6d69e31eef0a Author: Jan Beulich Date: Tue Jul 19 08:36:10 2022 +0200 x86: log non-responding CPUs in fatal_trap() This eases recognizing that something odd is going on. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Wed Jul 20 00:33:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 00:33:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371234.603070 (Exim 4.92) (envelope-from ) id 1oDxeK-0007zV-75; Wed, 20 Jul 2022 00:33:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371234.603070; Wed, 20 Jul 2022 00:33:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDxeK-0007zO-4L; Wed, 20 Jul 2022 00:33:12 +0000 Received: by outflank-mailman (input) for mailman id 371234; Wed, 20 Jul 2022 00:33:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDxeI-0007zC-8v for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 00:33:10 +0000 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86ffcb67-07c3-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 02:33:08 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86ffcb67-07c3-11ed-924f-1f966e50362f Date: Wed, 20 Jul 2022 00:33:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658277187; x=1658536387; bh=uwCIiuzMhvcjNM/4DDtAUEPWKgyBxdDAIwSD03eQxPs=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=eqBKKt8Cy6bCS/0SDk4vRcH/bQTfFSsCEq07qwV6n7eYmo5fhAaulGpcQeMQQkMf9 7U0eNBfCKDKts6oFIm6aoijP0rRngCE9PPWsDZXynPT8mkB1r4uK4BFc6vd+1YNtce e9nx/lxr4IJJzD8f1vqNZINWfJb/tJXaRh++MLbIHdMPESsvkOkU4yYC/ktSb6oRb4 HNKu8v2tz/6UgqrbRqeo3IzreWI4NL13hs/Gn3RnQjOGfawoJ3eehgDVg19RAS655n UOi9xoB9sza+jLljKh/cAkf4h0o+hXfBLVAUKSZ9RmDSfLZkt01ITs6SLgDXkcGkFK b5t1Al4BzVYdw== To: Andrew Cooper From: Dylanger Daly Cc: "xen-devel@lists.xenproject.org" Reply-To: Dylanger Daly Subject: Re: Ryzen 6000 (Mobile) Message-ID: In-Reply-To: <4c3976aa-dad4-2707-2852-9b26593692d0@citrix.com> References: <4c3976aa-dad4-2707-2852-9b26593692d0@citrix.com> Feedback-ID: 21854323:user:proton MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="b1_xTk3vw6VfGMgDSSPzYY6nwsZQ6W3Udu6r8mU5cLeI" This is a multi-part message in MIME format. --b1_xTk3vw6VfGMgDSSPzYY6nwsZQ6W3Udu6r8mU5cLeI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 PiBJJ2QgZm9jdXMgb24gdGhlIGJvb3RpbmcgaXNzdWVzIGZpcnN0LiBBbmQgSSBndWVzcyB5b3Ug Y2FuIHRha2UgYSB2aWRlbwo+IG9mIHRoYXQgKGFzc3VtaW5nIHRoYXQgYSBzaW5nbGUgc2NyZWVu c2hvdCBsaWtlbHkgaXNuJ3QgZ29pbmcgdG8gYmUKPiBlbm91Z2gpLCBwb3NzaWJseSB3aXRoICJ2 Z2E9a2VlcCIgaW4gcGxhY2UgKGFsYmVpdCB0aGF0IGludHJvZHVjZXMKPiBleHRyYSBzbG93bmVz cyk/Cj4KPiBUaGVyZSdzIGFsc28gdGhlIG9wdGlvbiBvZiB1c2luZyBhbiBFSENJIGRlYnVnIHBv cnQgZm9yIHRoZSBzZXJpYWwKPiBjb25zb2xlLCBidXQgdGhpcyByZXF1aXJlcyAoYSkgYSBzcGVj aWFsIGNhYmxlIGFuZCAoYikgdGhlIHN5c3RlbQo+IGRlc2lnbmVycyBub3QgaGF2aW5nIGluc2Vy dGVkIGFueSBodWJzIGJldHdlZW4gdGhlIGNvbnRyb2xsZXIgYW5kdGhlIGNvbm5lY3Rvci4KCkRv IHlvdSBrbm93IGlmIGl0J3MgcG9zc2libGUgdG8gaGF2ZSBgY29uc29sZT12Z2EgdmdhPWtlZXBg IGFuZCBzcGVjaWZ5IGEgc2Vjb25kYXJ5IG1vbml0b3I/IFRoaXMgd291bGQgYmUgdmVyeSB1c2Vm dWwgaWYgSSBjb3VsZCBoYXZlIFhlbiBsb2cgdmlhIGEgc2Vjb25kYXJ5IG1vbml0b3IsIGluIGFu eSBjYXNlIEknbGwgcmVjb3JkIGEgdmlkZW8gdG9kYXkuIEkgY2FuJ3Qgc2VlbSB0byBnZXQgYW55 dGhpbmcgdXNlZnVsIG91dCBvZiAvdmFyL2xvZy94ZW4vY29uc29sZS9oeXBlcnZpc29yLmxvZywg SSBhc3N1bWUgdGhpcyBsb2cgZmlsZSBpc24ndCB3cml0dGVuIHRvIG9uIGEgJ2xpdmUnIGJhc2lz LgoKSSB3b3VsZCBhc3N1bWUgQU1EIGhhcyBkaXNhYmxlZCBhbnkgc29ydCBvZiBkZWJ1Z2dpbmcv TklEblQvQ0NELCBzdXJwcmlzaW5nbHkgb3IgdW5zdXJwcmlzaW5nbHkgaXQncyBlYXNpZXIgdG8g ZGVidWcgQ2hyb21lYm9va3Mgd2l0aCB0aGVpciBDQ0QgVVNCLUMgY2FibGVzLgoKPiBPaywgdGhl c2Ugc291bmQgbGlrZSB0d28gZGlmZmVyZW50IHRoaW5ncy4gT25lIGlzIGRvbTAgZmFpbGluZyB0 byBib290LCBhbmQgb25lIGlzIHRoZSBoYW5nL3Jlc2V0IHdoZW4gc3RhcnRpbmcgdGhlIFZNcy4K PiBMZXRzIHN0YXJ0IHdpdGggdGhlIGRvbTAgcHJvYmxlbSBmaXJzdC4gVGhlIGxpbmsgeW91IHBy b3ZpZGUgc3VnZ2VzdHMgYSBjcmVkaXQyIGJ1Zy4gRG9lcyBkb20wIGJvb3QgaWYgeW91IHBhc3Mg YHNjaGVkPWNyZWRpdGAgb24gdGhlIGNvbW1hbmQgbGluZSwgaW4gcGxhY2Ugb2YgYGRvbTBfbWF4 X3ZjcHVzPTEgZG9tMF92Y3B1c19waW5gID8KClllcywgdGhpcyBpcyBjb3JyZWN0LCBJIHRoaW5r IHRoZSBmaXJzdCBwcm9ibGVtIGlzIGFuIEFNRCA2MDAwIFNlcmllcyBDUFUgaXNzdWUsIGFzIG90 aGVycyBoYXZlIHJlcG9ydGVkIHRoaXMgc2FtZSBmaXJzdCBpc3N1ZTogaHR0cHM6Ly9naXRodWIu Y29tL1F1YmVzT1MvcXViZXMtaXNzdWVzL2lzc3Vlcy83NTcwIChoYXZpbmcgdG8gYWRkIGBkb20w X21heF92Y3B1cz0xIGRvbTBfdmNwdXNfcGluYCkKCkkgYmVsaWV2ZSB0aGUgc2Vjb25kIGlzc3Vl IGNvdWxkIGJlIHBsYXRmb3JtIHNwZWNpZmljLCB0aGF0IGJlaW5nIGEgVUVGSSBPcHRpb24gcmVs YXRpbmcgdG8gdGhlIHNjaGVkdWxlciBvciBzb21ldGhpbmcgZWxzZSBjYXVzaW5nIHRoZSBkZXZp Y2UgdG8gaGFuZywgYW5lY2RvdGFsbHkgb3RoZXJzIHRoYXQgaGF2ZSB0aGUgc2FtZS1pc2ggQ1BV IGFyZW4ndCBoYXZpbmcgdGhpcyBpc3N1ZSwgc28gaXQgY291bGQgYmUgc3BlY2lmaWMgdG8gdGhl IExlbm92byBZb2dhIFNsaW0gNyBQcm8gWCAoR2VuIDcpLgoKSXNzdWUgIzEgc2VlbXMgdG8gYmUg Y29tbW9uIHdpdGggbmV3ZXIgQU1EIFJ5emVuIE1vYmlsZSBDUFVzCklzc3VlICMyIHNlZW1zIHRv IGJlIExlbm92byBzcGVjaWZpYywgSSd2ZSB0cmllZCBsaW1pdGluZyBvdGhlciBkb21VJ3MgdG8g MSB2Y3B1IHRvIG5vIGF2YWlsLCBJIGhhdmVuJ3QgdHJpZWQgcGlubmluZyBhIHZjcHUgdG8gYSBk b21VIHlldC4KClVuZm9ydHVuYXRlbHkgSSB0cmllZCBhZGRpbmcgYHNjaGVkPWNyZWRpdGAgaW4g cGxhY2Ugb2YgdGhlIHBpbm5pbmcgY29uZmlnIGFuZCBkb20wIGRpZG4ndCBjb21lIHVwIHRvIGFz ayBmb3IgYSBMVUtzIHBhc3N3b3JkLiBEb20wIGRvZXMgaW5kZWVkIGJvb3QsIGl0IGp1c3QgZG9l c24ndCBtYWtlIGl0IHBhc3QgdGhlIGVhcmx5IHN0YWdlIG9mIGtlcm5lbCBzZXR1cC4KCkNoZWVy cywgRHlsYW5nZXI= --b1_xTk3vw6VfGMgDSSPzYY6nwsZQ6W3Udu6r8mU5cLeI Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+PGJs b2NrcXVvdGUgc3R5bGU9ImJvcmRlci1sZWZ0OiAzcHggc29saWQgcmdiKDIwMCwgMjAwLCAyMDAp OyBib3JkZXItdG9wLWNvbG9yOiByZ2IoMjAwLCAyMDAsIDIwMCk7IGJvcmRlci1yaWdodC1jb2xv cjogcmdiKDIwMCwgMjAwLCAyMDApOyBib3JkZXItYm90dG9tLWNvbG9yOiByZ2IoMjAwLCAyMDAs IDIwMCk7IHBhZGRpbmctbGVmdDogMTBweDsgY29sb3I6IHJnYigxMDIsIDEwMiwgMTAyKTsiPjxz cGFuPkknZCBmb2N1cyBvbiB0aGUgYm9vdGluZyBpc3N1ZXMgZmlyc3QuIEFuZCBJIGd1ZXNzIHlv dSBjYW4gdGFrZSBhIHZpZGVvPC9zcGFuPjxkaXY+PHNwYW4+b2YgdGhhdCAoYXNzdW1pbmcgdGhh dCBhIHNpbmdsZSBzY3JlZW5zaG90IGxpa2VseSBpc24ndCBnb2luZyB0byBiZTwvc3Bhbj48L2Rp dj48ZGl2PjxzcGFuPmVub3VnaCksIHBvc3NpYmx5IHdpdGggInZnYT1rZWVwIiBpbiBwbGFjZSAo YWxiZWl0IHRoYXQgaW50cm9kdWNlczwvc3Bhbj48L2Rpdj48ZGl2PjxzcGFuPmV4dHJhIHNsb3du ZXNzKT88L3NwYW4+PC9kaXY+PGRpdj48YnI+PC9kaXY+PGRpdj48c3Bhbj5UaGVyZSdzIGFsc28g dGhlIG9wdGlvbiBvZiB1c2luZyBhbiBFSENJIGRlYnVnIHBvcnQgZm9yIHRoZSBzZXJpYWw8L3Nw YW4+PC9kaXY+PGRpdj48c3Bhbj5jb25zb2xlLCBidXQgdGhpcyByZXF1aXJlcyAoYSkgYSBzcGVj aWFsIGNhYmxlIGFuZCAoYikgdGhlIHN5c3RlbTwvc3Bhbj48L2Rpdj48ZGl2PjxzcGFuPmRlc2ln bmVycyBub3QgaGF2aW5nIGluc2VydGVkIGFueSBodWJzIGJldHdlZW4gdGhlIGNvbnRyb2xsZXIg YW5kPC9zcGFuPjwvZGl2PjxzcGFuPnRoZSBjb25uZWN0b3IuPC9zcGFuPjxicj48L2Jsb2NrcXVv dGU+PC9kaXY+PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAx NHB4OyI+PHNwYW4+PGJyPjwvc3Bhbj48L2Rpdj48ZGl2IHN0eWxlPSJmb250LWZhbWlseTogaGVs dmV0aWNhOyBmb250LXNpemU6IDE0cHg7Ij48c3Bhbj5EbyB5b3Uga25vdyBpZiBpdCdzIHBvc3Np YmxlIHRvIGhhdmUgYGNvbnNvbGU9dmdhIHZnYT1rZWVwYCBhbmQgc3BlY2lmeSBhIHNlY29uZGFy eSBtb25pdG9yPyBUaGlzIHdvdWxkIGJlIHZlcnkgdXNlZnVsIGlmIEkgY291bGQgaGF2ZSBYZW4g bG9nIHZpYSBhIHNlY29uZGFyeSBtb25pdG9yLCBpbiBhbnkgY2FzZSBJJ2xsIHJlY29yZCBhIHZp ZGVvIHRvZGF5LiBJIGNhbid0IHNlZW0gdG8gZ2V0IGFueXRoaW5nIHVzZWZ1bCBvdXQgb2YgL3Zh ci9sb2cveGVuL2NvbnNvbGUvaHlwZXJ2aXNvci5sb2csIEkgYXNzdW1lIHRoaXMgbG9nIGZpbGUg aXNuJ3Qgd3JpdHRlbiB0byBvbiBhICdsaXZlJyBiYXNpcy48L3NwYW4+PC9kaXY+PGRpdiBzdHls ZT0iZm9udC1mYW1pbHk6IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+PHNwYW4+PGJyPjwv c3Bhbj48L2Rpdj48ZGl2IHN0eWxlPSIiPjxmb250IGZhY2U9ImhlbHZldGljYSI+SSB3b3VsZCBh c3N1bWUgQU1EIGhhcyBkaXNhYmxlZCBhbnkgc29ydCBvZiBkZWJ1Z2dpbmcvTklEblQvQ0NELCBz dXJwcmlzaW5nbHkgb3IgdW48c3BhbiBzdHlsZT0iYmFja2dyb3VuZC1jb2xvcjpyZ2IoMjU1LCAy NTUsIDI1NSk7ZGlzcGxheTppbmxpbmUgIWltcG9ydGFudCI+c3VycHJpc2luZ2x5PC9zcGFuPiZu YnNwO2l0J3MgZWFzaWVyIHRvIGRlYnVnIENocm9tZWJvb2tzIHdpdGggdGhlaXIgQ0NEIFVTQi1D IGNhYmxlcy48L2ZvbnQ+PC9kaXY+PGRpdiBzdHlsZT0iIj48Zm9udCBmYWNlPSJoZWx2ZXRpY2Ei Pjxicj48L2ZvbnQ+PC9kaXY+PGRpdiBzdHlsZT0iIj48Zm9udCBmYWNlPSJoZWx2ZXRpY2EiPjxi cj48L2ZvbnQ+PC9kaXY+PGJsb2NrcXVvdGUgc3R5bGU9ImJvcmRlci1sZWZ0OiAzcHggc29saWQg cmdiKDIwMCwgMjAwLCAyMDApOyBib3JkZXItdG9wLWNvbG9yOiByZ2IoMjAwLCAyMDAsIDIwMCk7 IGJvcmRlci1yaWdodC1jb2xvcjogcmdiKDIwMCwgMjAwLCAyMDApOyBib3JkZXItYm90dG9tLWNv bG9yOiByZ2IoMjAwLCAyMDAsIDIwMCk7IHBhZGRpbmctbGVmdDogMTBweDsgY29sb3I6IHJnYigx MDIsIDEwMiwgMTAyKTsiPjxkaXYgc3R5bGU9IiI+PGZvbnQgZmFjZT0iaGVsdmV0aWNhIj48c3Bh bj5PaywgdGhlc2Ugc291bmQgbGlrZSB0d28gZGlmZmVyZW50IHRoaW5ncy4gJm5ic3A7T25lIGlz IGRvbTAgZmFpbGluZyB0byBib290LCBhbmQgb25lIGlzIHRoZSBoYW5nL3Jlc2V0IHdoZW4gc3Rh cnRpbmcgdGhlIFZNcy48L3NwYW4+PGRpdj48YnI+PC9kaXY+PHNwYW4+TGV0cyBzdGFydCB3aXRo IHRoZSBkb20wIHByb2JsZW0gZmlyc3QuICZuYnNwO1RoZSBsaW5rIHlvdSBwcm92aWRlIHN1Z2dl c3RzIGEgY3JlZGl0MiBidWcuICZuYnNwO0RvZXMgZG9tMCBib290IGlmIHlvdSBwYXNzIGBzY2hl ZD1jcmVkaXRgIG9uIHRoZSBjb21tYW5kIGxpbmUsIGluIHBsYWNlIG9mIGBkb20wX21heF92Y3B1 cz0xIGRvbTBfdmNwdXNfcGluYCA/PC9zcGFuPjwvZm9udD48L2Rpdj48L2Jsb2NrcXVvdGU+DQo8 ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jayIgc3R5bGU9IiI+DQogICAgPGRp diBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stdXNlciBwcm90b25tYWlsX3NpZ25h dHVyZV9ibG9jay1lbXB0eSIgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6 ZTogMTRweDsiPg0KDQogICAgICAgICAgICA8L2Rpdj4NCg0KICAgICAgICAgICAgPGRpdiBjbGFz cz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIiBzdHlsZT0iZm9udC1mYW1pbHk6 IGhlbHZldGljYTsgZm9udC1zaXplOiAxNHB4OyI+PGJyPjwvZGl2PjxkaXYgY2xhc3M9InByb3Rv bm1haWxfc2lnbmF0dXJlX2Jsb2NrLXByb3RvbiIgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRp Y2E7IGZvbnQtc2l6ZTogMTRweDsiPlllcywgdGhpcyBpcyBjb3JyZWN0LCBJIHRoaW5rIHRoZSBm aXJzdCBwcm9ibGVtIGlzIGFuIEFNRCA2MDAwIFNlcmllcyBDUFUgaXNzdWUsIGFzIG90aGVycyBo YXZlIHJlcG9ydGVkIHRoaXMgc2FtZSBmaXJzdCBpc3N1ZTombmJzcDs8c3Bhbj48YSB0YXJnZXQ9 Il9ibGFuayIgcmVsPSJub3JlZmVycmVyIG5vZm9sbG93IG5vb3BlbmVyIiBocmVmPSJodHRwczov L2dpdGh1Yi5jb20vUXViZXNPUy9xdWJlcy1pc3N1ZXMvaXNzdWVzLzc1NzAiPmh0dHBzOi8vZ2l0 aHViLmNvbS9RdWJlc09TL3F1YmVzLWlzc3Vlcy9pc3N1ZXMvNzU3MDwvYT4mbmJzcDsoaGF2aW5n IHRvIGFkZCZuYnNwOzxzcGFuPmBkb20wX21heF92Y3B1cz0xIGRvbTBfdmNwdXNfcGluYCk8L3Nw YW4+PC9zcGFuPjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLXBy b3RvbiIgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPjxz cGFuPjxzcGFuPjxicj48L3NwYW4+PC9zcGFuPjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxf c2lnbmF0dXJlX2Jsb2NrLXByb3RvbiIgc3R5bGU9IiI+PGZvbnQgZmFjZT0iaGVsdmV0aWNhIj5J IGJlbGlldmUgdGhlIHNlY29uZCBpc3N1ZSBjb3VsZCBiZSBwbGF0Zm9ybSBzcGVjaWZpYywgdGhh dCBiZWluZyBhIFVFRkkgT3B0aW9uIHJlbGF0aW5nIHRvIHRoZSBzY2hlZHVsZXImbmJzcDtvciBz b21ldGhpbmcgZWxzZSBjYXVzaW5nIHRoZSBkZXZpY2UgdG8gaGFuZywgYW5lY2RvdGFsbHkmbmJz cDtvdGhlcnMgdGhhdCBoYXZlIHRoZSBzYW1lLWlzaCBDUFUgYXJlbid0IGhhdmluZyB0aGlzIGlz c3VlLCBzbyBpdCBjb3VsZCBiZSBzcGVjaWZpYyB0byB0aGUgTGVub3ZvIFlvZ2EgU2xpbSA3IFBy byBYIChHZW4gNykuPC9mb250PjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJl X2Jsb2NrLXByb3RvbiIgc3R5bGU9IiI+PGZvbnQgZmFjZT0iaGVsdmV0aWNhIj48YnI+PC9mb250 PjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLXByb3RvbiIgc3R5 bGU9IiI+PGZvbnQgZmFjZT0iaGVsdmV0aWNhIj5Jc3N1ZSAjMSBzZWVtcyB0byBiZSBjb21tb24g d2l0aCBuZXdlciBBTUQgUnl6ZW4gTW9iaWxlIENQVXM8L2ZvbnQ+PC9kaXY+PGRpdiBjbGFzcz0i cHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIiBzdHlsZT0iIj48Zm9udCBmYWNlPSJo ZWx2ZXRpY2EiPklzc3VlICMyIHNlZW1zIHRvIGJlIExlbm92byBzcGVjaWZpYywgSSd2ZSB0cmll ZCBsaW1pdGluZyBvdGhlciBkb21VJ3MgdG8gMSB2Y3B1IHRvIG5vIGF2YWlsLCBJIGhhdmVuJ3Qg dHJpZWQgcGlubmluZyBhIHZjcHUgdG8gYSBkb21VIHlldC48L2ZvbnQ+PC9kaXY+PGRpdiBjbGFz cz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIiBzdHlsZT0iIj48Zm9udCBmYWNl PSJoZWx2ZXRpY2EiPjxicj48L2ZvbnQ+PC9kaXY+PGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWdu YXR1cmVfYmxvY2stcHJvdG9uIiBzdHlsZT0iIj48Zm9udCBmYWNlPSJoZWx2ZXRpY2EiPlVuZm9y dHVuYXRlbHkmbmJzcDtJIHRyaWVkIGFkZGluZyBgPHNwYW4+c2NoZWQ9Y3JlZGl0YCBpbiBwbGFj ZSBvZiB0aGUgcGlubmluZyBjb25maWcgYW5kIGRvbTAgZGlkbid0IGNvbWUgdXAgdG8gYXNrIGZv ciBhIExVS3MgcGFzc3dvcmQuIERvbTAgZG9lcyBpbmRlZWQgYm9vdCwgaXQganVzdCBkb2Vzbid0 Jm5ic3A7bWFrZSBpdCBwYXN0IHRoZSBlYXJseSBzdGFnZSBvZiBrZXJuZWwgc2V0dXAuPC9zcGFu PjwvZm9udD48L2Rpdj48ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1wcm90 b24iIHN0eWxlPSIiPjxmb250IGZhY2U9ImhlbHZldGljYSI+PHNwYW4+PGJyPjwvc3Bhbj48L2Zv bnQ+PC9kaXY+PGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2stcHJvdG9uIiBz dHlsZT0iIj48Zm9udCBmYWNlPSJoZWx2ZXRpY2EiPjxzcGFuPkNoZWVycywgRHlsYW5nZXI8L3Nw YW4+PC9mb250PjwvZGl2PjxkaXYgY2xhc3M9InByb3Rvbm1haWxfc2lnbmF0dXJlX2Jsb2NrLXBy b3RvbiIgc3R5bGU9ImZvbnQtZmFtaWx5OiBoZWx2ZXRpY2E7IGZvbnQtc2l6ZTogMTRweDsiPjxi cj48L2Rpdj48ZGl2IGNsYXNzPSJwcm90b25tYWlsX3NpZ25hdHVyZV9ibG9jay1wcm90b24iIHN0 eWxlPSJmb250LWZhbWlseTogaGVsdmV0aWNhOyBmb250LXNpemU6IDE0cHg7Ij48YnI+PC9kaXY+ PC9kaXY+ --b1_xTk3vw6VfGMgDSSPzYY6nwsZQ6W3Udu6r8mU5cLeI-- From xen-devel-bounces@lists.xenproject.org Wed Jul 20 01:12:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 01:12:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371277.603109 (Exim 4.92) (envelope-from ) id 1oDyG1-0004Jt-SV; Wed, 20 Jul 2022 01:12:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371277.603109; Wed, 20 Jul 2022 01:12:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyG1-0004Jm-PT; Wed, 20 Jul 2022 01:12:09 +0000 Received: by outflank-mailman (input) for mailman id 371277; Wed, 20 Jul 2022 01:12:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyG0-00044I-3u for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 01:12:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f86dbb4b-07c8-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 03:12:07 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9E8196174C; Wed, 20 Jul 2022 01:12:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B15B0C341D1; Wed, 20 Jul 2022 01:12:03 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f86dbb4b-07c8-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658279525; bh=c9nhF8SJnbgT1PcdEw9BhinCExmguSEsqIqZEydceYM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=D3cR5F6y+stgqYnzhXPjbUzIQhCS5sZXrXN4QVNkuR7VlyfyV/5YA9/Q7emGkuSJI eyJcQ8TuaKGeFLk8/qUpYzovHxJ/F4tBcF7sPHtRw+witDUi8Ve3QiVrf0llTLc7kv PlQ9prkBWq87sUzL5uWuS+gFMrP84HcSxYT2DD9i1HTSTcMIatlYXy9tk5ctziLAJs Mdm8kFKq4qfrpUq1Q0EIMxE1JvdpOaMcdpoAtpQUtINBsFGxENOwUC9dkdD2WrbNhK GWq7gvObl89raDRtsHCxkX2+HbYpf4cmerLw3LjF24BdNcyVR/kD09i9hg6aso02OG RulKTONQgHJug== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Zijlstra , Borislav Petkov , Josh Poimboeuf , Sasha Levin , jgross@suse.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.18 21/54] x86/xen: Rename SYS* entry points Date: Tue, 19 Jul 2022 21:09:58 -0400 Message-Id: <20220720011031.1023305-21-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220720011031.1023305-1-sashal@kernel.org> References: <20220720011031.1023305-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Peter Zijlstra [ Upstream commit b75b7f8ef1148be1b9321ffc2f6c19238904b438 ] Native SYS{CALL,ENTER} entry points are called entry_SYS{CALL,ENTER}_{64,compat}, make sure the Xen versions are named consistently. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Borislav Petkov Reviewed-by: Josh Poimboeuf Signed-off-by: Borislav Petkov Signed-off-by: Sasha Levin --- arch/x86/xen/setup.c | 6 +++--- arch/x86/xen/xen-asm.S | 20 ++++++++++---------- arch/x86/xen/xen-ops.h | 6 +++--- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 81aa46f770c5..cfa99e8f054b 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -918,7 +918,7 @@ void xen_enable_sysenter(void) if (!boot_cpu_has(sysenter_feature)) return; - ret = register_callback(CALLBACKTYPE_sysenter, xen_sysenter_target); + ret = register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat); if(ret != 0) setup_clear_cpu_cap(sysenter_feature); } @@ -927,7 +927,7 @@ void xen_enable_syscall(void) { int ret; - ret = register_callback(CALLBACKTYPE_syscall, xen_syscall_target); + ret = register_callback(CALLBACKTYPE_syscall, xen_entry_SYSCALL_64); if (ret != 0) { printk(KERN_ERR "Failed to set syscall callback: %d\n", ret); /* Pretty fatal; 64-bit userspace has no other @@ -936,7 +936,7 @@ void xen_enable_syscall(void) if (boot_cpu_has(X86_FEATURE_SYSCALL32)) { ret = register_callback(CALLBACKTYPE_syscall32, - xen_syscall32_target); + xen_entry_SYSCALL_compat); if (ret != 0) setup_clear_cpu_cap(X86_FEATURE_SYSCALL32); } diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S index caa9bc2fa100..6bf9d45b9178 100644 --- a/arch/x86/xen/xen-asm.S +++ b/arch/x86/xen/xen-asm.S @@ -234,7 +234,7 @@ SYM_CODE_END(xenpv_restore_regs_and_return_to_usermode) */ /* Normal 64-bit system call target */ -SYM_CODE_START(xen_syscall_target) +SYM_CODE_START(xen_entry_SYSCALL_64) UNWIND_HINT_EMPTY ENDBR popq %rcx @@ -249,12 +249,12 @@ SYM_CODE_START(xen_syscall_target) movq $__USER_CS, 1*8(%rsp) jmp entry_SYSCALL_64_after_hwframe -SYM_CODE_END(xen_syscall_target) +SYM_CODE_END(xen_entry_SYSCALL_64) #ifdef CONFIG_IA32_EMULATION /* 32-bit compat syscall target */ -SYM_CODE_START(xen_syscall32_target) +SYM_CODE_START(xen_entry_SYSCALL_compat) UNWIND_HINT_EMPTY ENDBR popq %rcx @@ -269,10 +269,10 @@ SYM_CODE_START(xen_syscall32_target) movq $__USER32_CS, 1*8(%rsp) jmp entry_SYSCALL_compat_after_hwframe -SYM_CODE_END(xen_syscall32_target) +SYM_CODE_END(xen_entry_SYSCALL_compat) /* 32-bit compat sysenter target */ -SYM_CODE_START(xen_sysenter_target) +SYM_CODE_START(xen_entry_SYSENTER_compat) UNWIND_HINT_EMPTY ENDBR /* @@ -291,19 +291,19 @@ SYM_CODE_START(xen_sysenter_target) movq $__USER32_CS, 1*8(%rsp) jmp entry_SYSENTER_compat_after_hwframe -SYM_CODE_END(xen_sysenter_target) +SYM_CODE_END(xen_entry_SYSENTER_compat) #else /* !CONFIG_IA32_EMULATION */ -SYM_CODE_START(xen_syscall32_target) -SYM_CODE_START(xen_sysenter_target) +SYM_CODE_START(xen_entry_SYSCALL_compat) +SYM_CODE_START(xen_entry_SYSENTER_compat) UNWIND_HINT_EMPTY ENDBR lea 16(%rsp), %rsp /* strip %rcx, %r11 */ mov $-ENOSYS, %rax pushq $0 jmp hypercall_iret -SYM_CODE_END(xen_sysenter_target) -SYM_CODE_END(xen_syscall32_target) +SYM_CODE_END(xen_entry_SYSENTER_compat) +SYM_CODE_END(xen_entry_SYSCALL_compat) #endif /* CONFIG_IA32_EMULATION */ diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h index fd0fec6e92f4..9a8bb972193d 100644 --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -10,10 +10,10 @@ /* These are code, but not functions. Defined in entry.S */ extern const char xen_failsafe_callback[]; -void xen_sysenter_target(void); +void xen_entry_SYSENTER_compat(void); #ifdef CONFIG_X86_64 -void xen_syscall_target(void); -void xen_syscall32_target(void); +void xen_entry_SYSCALL_64(void); +void xen_entry_SYSCALL_compat(void); #endif extern void *xen_initial_gdt; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 01:12:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 01:12:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371276.603099 (Exim 4.92) (envelope-from ) id 1oDyG0-00044a-Lh; Wed, 20 Jul 2022 01:12:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371276.603099; Wed, 20 Jul 2022 01:12:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyG0-00044T-J1; Wed, 20 Jul 2022 01:12:08 +0000 Received: by outflank-mailman (input) for mailman id 371276; Wed, 20 Jul 2022 01:12:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyFz-00044I-A5 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 01:12:07 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f7f77d53-07c8-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 03:12:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B1951B81DE4; Wed, 20 Jul 2022 01:12:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98CD9C341C6; Wed, 20 Jul 2022 01:12:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f7f77d53-07c8-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658279523; bh=VoMl3IiXADXOrzYUU30d8G4boCKSZdvtXjRJJHHaY44=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TDcie2KO3OBwvTT5O2M6l0j6f99DtbItqm2N3h8YB/Me2Xcsc4j83RP1GoDGwj2+6 996/g2aEZyU/RDVPXWHAqY/bE1z+B9P7/vTCiL+rBlMw75lgevexKtO9bav68aAxPs uZNh/k32ik3JWvRKKpinpUbo7MYP9Xgp7bvW3pOtqPxOOcFneLyo6ZKsGp7BxM4oGA M7g094X8ECOWxiyfjKXNBtoPwk7dY6j13mbIVBAjBMuGgiy8p37HE9AQnnX36IQhKD oiChHPykcF/xJToKcZxD6+lxZNtJ+h+FQaVg+AIAfAC7Y1cfXLN/RBT/WlYVYrm7WF 9dOlq8GtfsnEw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Zijlstra , Borislav Petkov , Josh Poimboeuf , Sasha Levin , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, luto@kernel.org, jgross@suse.com, pawan.kumar.gupta@linux.intel.com, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.18 20/54] objtool: Update Retpoline validation Date: Tue, 19 Jul 2022 21:09:57 -0400 Message-Id: <20220720011031.1023305-20-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220720011031.1023305-1-sashal@kernel.org> References: <20220720011031.1023305-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Peter Zijlstra [ Upstream commit 9bb2ec608a209018080ca262f771e6a9ff203b6f ] Update retpoline validation with the new CONFIG_RETPOLINE requirement of not having bare naked RET instructions. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Borislav Petkov Reviewed-by: Josh Poimboeuf Signed-off-by: Borislav Petkov Signed-off-by: Sasha Levin --- arch/x86/include/asm/nospec-branch.h | 6 ++++++ arch/x86/mm/mem_encrypt_boot.S | 2 ++ arch/x86/xen/xen-head.S | 1 + tools/objtool/check.c | 19 +++++++++++++------ 4 files changed, 22 insertions(+), 6 deletions(-) diff --git a/arch/x86/include/asm/nospec-branch.h b/arch/x86/include/asm/nospec-branch.h index 92290b4f1c96..a790109f9337 100644 --- a/arch/x86/include/asm/nospec-branch.h +++ b/arch/x86/include/asm/nospec-branch.h @@ -75,6 +75,12 @@ .popsection .endm +/* + * (ab)use RETPOLINE_SAFE on RET to annotate away 'bare' RET instructions + * vs RETBleed validation. + */ +#define ANNOTATE_UNRET_SAFE ANNOTATE_RETPOLINE_SAFE + /* * JMP_NOSPEC and CALL_NOSPEC macros can be used instead of a simple * indirect jmp/call which may be susceptible to the Spectre variant 2 diff --git a/arch/x86/mm/mem_encrypt_boot.S b/arch/x86/mm/mem_encrypt_boot.S index d94dea450fa6..9de3d900bc92 100644 --- a/arch/x86/mm/mem_encrypt_boot.S +++ b/arch/x86/mm/mem_encrypt_boot.S @@ -66,6 +66,7 @@ SYM_FUNC_START(sme_encrypt_execute) pop %rbp /* Offset to __x86_return_thunk would be wrong here */ + ANNOTATE_UNRET_SAFE ret int3 SYM_FUNC_END(sme_encrypt_execute) @@ -154,6 +155,7 @@ SYM_FUNC_START(__enc_copy) pop %r15 /* Offset to __x86_return_thunk would be wrong here */ + ANNOTATE_UNRET_SAFE ret int3 .L__enc_copy_end: diff --git a/arch/x86/xen/xen-head.S b/arch/x86/xen/xen-head.S index 3a2cd93bf059..fa884fc73e07 100644 --- a/arch/x86/xen/xen-head.S +++ b/arch/x86/xen/xen-head.S @@ -26,6 +26,7 @@ SYM_CODE_START(hypercall_page) .rept (PAGE_SIZE / 32) UNWIND_HINT_FUNC ANNOTATE_NOENDBR + ANNOTATE_UNRET_SAFE ret /* * Xen will write the hypercall page, and sort out ENDBR. diff --git a/tools/objtool/check.c b/tools/objtool/check.c index 204519704f3b..2daa0dce199b 100644 --- a/tools/objtool/check.c +++ b/tools/objtool/check.c @@ -2097,8 +2097,9 @@ static int read_retpoline_hints(struct objtool_file *file) } if (insn->type != INSN_JUMP_DYNAMIC && - insn->type != INSN_CALL_DYNAMIC) { - WARN_FUNC("retpoline_safe hint not an indirect jump/call", + insn->type != INSN_CALL_DYNAMIC && + insn->type != INSN_RETURN) { + WARN_FUNC("retpoline_safe hint not an indirect jump/call/ret", insn->sec, insn->offset); return -1; } @@ -3631,7 +3632,8 @@ static int validate_retpoline(struct objtool_file *file) for_each_insn(file, insn) { if (insn->type != INSN_JUMP_DYNAMIC && - insn->type != INSN_CALL_DYNAMIC) + insn->type != INSN_CALL_DYNAMIC && + insn->type != INSN_RETURN) continue; if (insn->retpoline_safe) @@ -3646,9 +3648,14 @@ static int validate_retpoline(struct objtool_file *file) if (!strcmp(insn->sec->name, ".init.text") && !module) continue; - WARN_FUNC("indirect %s found in RETPOLINE build", - insn->sec, insn->offset, - insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call"); + if (insn->type == INSN_RETURN) { + WARN_FUNC("'naked' return found in RETPOLINE build", + insn->sec, insn->offset); + } else { + WARN_FUNC("indirect %s found in RETPOLINE build", + insn->sec, insn->offset, + insn->type == INSN_JUMP_DYNAMIC ? "jump" : "call"); + } warnings++; } -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 01:13:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 01:13:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371286.603120 (Exim 4.92) (envelope-from ) id 1oDyGs-000575-54; Wed, 20 Jul 2022 01:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371286.603120; Wed, 20 Jul 2022 01:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyGs-00056y-28; Wed, 20 Jul 2022 01:13:02 +0000 Received: by outflank-mailman (input) for mailman id 371286; Wed, 20 Jul 2022 01:13:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyGp-00051e-Lz for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 01:13:00 +0000 Received: from sonic316-55.consmr.mail.gq1.yahoo.com (sonic316-55.consmr.mail.gq1.yahoo.com [98.137.69.31]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 163d2564-07c9-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 03:12:58 +0200 (CEST) Received: from sonic.gate.mail.ne1.yahoo.com by sonic316.consmr.mail.gq1.yahoo.com with HTTP; Wed, 20 Jul 2022 01:12:55 +0000 Received: by hermes--production-ne1-7864dcfd54-dxcrc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID da1c1059c6f58b1197fb62eedc118138; Wed, 20 Jul 2022 01:12:51 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 163d2564-07c9-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netscape.net; s=a2048; t=1658279575; bh=iWifEwj9jXr+OJlYWHhKvQEskuKfIAM/4zntUXILFnY=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From:Subject:Reply-To; b=exWkcLCPxO+hW4q4nym5lwdLYXXGPKihrdkNPqFWPQ0bJlQpL2z1Shc/S7+USYQz8x+IclfSyEU2gRSi2JDzq7hfz9ooYxGMX3+HjZsb7tmVp+hhQ7i3xv7JXQrPB1TqKKvvlsxzAZ3Lfsg35ntOJWeHgqGAoWDu5f1cCmu/5r1j58r+6alQ8qBh85Tc3wZZeFaKv1H5AEsqFBbQ8iwg3IV/W+c1sVYS2Dba7ZwAo9IhJ6jVmyJEXbj107v2q4L5BvdhIDjI72ZYUd35/nF0T+AUe+L3aOcx03AHzhBMlHlFink3K+ZFDq2me8t85yUYMKfq8a4dgbZ5LLnnjHT/YA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1658279575; bh=ltLZEA8eNzEprIbhzvJZSEYmOFXhbEoexjddTnHQJe0=; h=X-Sonic-MF:Date:From:Subject:To:From:Subject; b=o04QgON2jXIorVudFo+weZ1JqkUDUyf0LhDxLtasf+wfwbVi3bimjfGZdaQfRa/5CZ+edusKouC0GGdnMfP+2DCOdFuVH17BdN7rozKS7Xj0S23TuN8e+pLkNJFJjzIkCwkM784sh/nDzs0mm8zQOp94SZy4sGHkL/F7HvHA/KObD/I0YDn52L+cedlcoMH6UyIQGzKmtUwKDRmSlFS/pZh03jgWVlncN4KepPoupQD5WHGW1YZVhEpnYzwRmkOsC1CqbAwqMfdoGFOf6vZR09M3/aK4GX13robVyo8yJcXdaJjbtzIg2rTcnNC3GjUZ9S7EQbjMT4gInZGGFoltNg== X-YMail-OSG: _YxVZCIVM1mdVS.6PZEvKwtUn9DEZEiI_daZt3JoDahEStm86JT2j22U.LY4Mu4 4XXxbUOFQBSoI73wQ0WRjNTy3tN8GBI0NnEI80mK0SMpFLCN6JcTtuDCWQ.2IlrBfYiO0MeqRePh Eoz89uwJzVyVkhrTemBnLPx69lJu1sXoPebXkn4cNjk1935_ULAkty375.YUBtVP1bKclIu3.mXR BpVaOer9yweN.ayTZNccxid5wOs7EyqUsP4NA9DZu6kCFy9AvNNC6xNoFU8BfgnifrgS8IWrlXNZ HBz0VAVv.AtJHcmplK8QWjMj9VhB5ZmdxVGpI4AsfEAB8_fBmu07JCcqz.CyVPodNRJ8.LkrOSY7 MkCWhM1t9j1CljJRdx40ggqbZ54EAZ0XFpuEDTidw3hnyixrilMY_QM59FEC6gCVvSB2MjFwmqAv M_AtSaxNLyX3VqFy_GyUavaG9fAijYPzYEa44EjHNSKWu3Bg5DtrNLoVBJ6bxg5BMSYgJf4okDfd vBojJnA42UVVa56BYMH9GtVfQpKOpBf.JCCLR7apCCkkqq6HrH5oQUh20ges5cPC9baGC853yQ1g IfFgVSRSYEgllHqtC6yyC.2Xf2sdYvCfls3DcEtkcbySvhLIKBHAn6GkSJFtgYqu_famxfI7mSEL sL4fC5Q2Ao5d2JKaNJTdYszCyI540GTaujpA8qTYmRoCplfU5Ff5u_dVDHUoKROZ8MueFiKDcO0E qn7TEUVo9NaOp_HYaQ7BreHgYKQsb6OSpUbzU3lhKhZ6x69LRQll7xkZWUANck3cMW5B72lOuqrB JRJGmdBn8T.8VOzJM6xvQKqVUK2HdSbLcr8vdTYGyU7xzP1vHOlINaW6DI5fYfl_glupCKDBNeIj ZTEL8pSR_uuTzN_Z8M8DC5TBGF0lgNtDjYi4ZQxlJj.j3yW23RVdchi67N7LXez9Vbq16kKgiAy8 oOLcvtPiolij9UrvDVcdarHj93mrTCSAbzaV7PZbRm5hfa4yCkRzgHhCfrQRzKzwp.TTzb7CnTct yyHNrevjmlrImhXd47cHrv1LzaSu8GnqyIHOPBgdYg1lApUkUug7Ur7L.07BM9_hTwbu3UNWIAl5 b8CFvBAdIVFtIRTDTxHreK2ldCj.Vy9emehQI3mY2scsMCCjfOXa6SSctkGJQ3rTRYPXuY198sq3 eaoPmL7EcQzXnJHfO7nBkDMax4RyF8Ys_tv3mHz7ckZ4MXDOHwJYZAuAbrtRFMBFoNHLCS1FpI_c aHmkN8pjWLuy.gR.3rX_IBZZspifZayK9wla5l2NQozQQyo6HzkkysynXU5bdeA6atJrELPYnLvt LXV2W2fhnTj86b9zWVwrll..1UkKc6GGXYdAvLp9W20n9R_joWPK0P7.RWNaMZqS28yGX1nUJyKl NHKaGZKJi_8OnWmyVPTHlhAO67XJyJi4NLMvAYSUCNF4LMNSDtBUtoIGk7ncLYMPcJsJ_d6eDnKY We2TQja26tJLDoZJNVHhfr4oRS853WgkEFkeF7JMUvQSuem3xYrRUT4B_pKRPhXm1EhwIU0btxtj wA6FZMCo8_UHy5A9cfJbb9AdZNfweKL_liXHVmte_G0A1.llvkmSYi8X1U0uNFPscrNHLwSp3a3_ et7rnJjR17uhd7DveJ.PkQYJRNqFG86tD9VnKUEa6syH3FRAIDxHqQWKYwXraOY_BWGzPfsgJiiF CWgdIxUAjGTdSLxnZfxlyK7I62xMFJ8TJ6L5TBiQT3Vz939813izWLknZrWHfHxjrMZVqyCpP9NI OrKPqlTwlxTbeQ1patAdbgSgiuCPSy4w8oL9vyjtx_QB11w6b55EzUJ.iYFYBcRKUQ_HIcN5Pvca 29d1nhQ_1qdge_UMyTnbd4rPJzV7x6oRQmQfd2vF7Fg3cK3WK5bWOvzOvfBJi4R4nsDJI2vZ.hcT ETselLdMobEQZRd2GLJJYlq7aXgkkqqSsVffkv0vbymKzhFrFVFTsSD8I1mpoWKrUHYUOg9nQlMm 2klFKDl0YxZuaHaA7LTkMZLovoBEELcsSuNreV9lRUXSwK789N4XdHBwBqXZ58kAtbN6nkbx2Z8N 1XlFWaRFtI8zZvZn16mnDbRuQZjQNX4L5TIhdLkP_JSVHWeRZdsXphT2S0n8Zka8xB.YO39bAWUN Cm_1n1esOcoUCNwroUf3eGp91Nh3ayLsc3skJcxKsHppkhyNawAx3D7W7Yd3XNy8iKGB59RTldFr h0E4otvnGgXKBo_37ahHG5fA- X-Sonic-MF: Message-ID: <9487b1ef-bc7c-b9c5-929f-0953756e9bd5@netscape.net> Date: Tue, 19 Jul 2022 21:12:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Chuck Zmudzinski Subject: Re: [PATCH 3/3] x86: decouple pat and mtrr handling To: Juergen Gross , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Cc: jbeulich@suse.com, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Boris Ostrovsky , Borislav Petkov , Thorsten Leemhuis References: <20220715142549.25223-1-jgross@suse.com> <20220715142549.25223-4-jgross@suse.com> Content-Language: en-US In-Reply-To: <20220715142549.25223-4-jgross@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailer: WebService/1.1.20407 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.aol Content-Length: 2159 On 7/15/22 10:25 AM, Juergen Gross wrote: > Today PAT is usable only with MTRR being active, with some nasty tweaks > to make PAT usable when running as Xen PV guest, which doesn't support > MTRR. > > The reason for this coupling is, that both, PAT MSR changes and MTRR > changes, require a similar sequence and so full PAT support was added > using the already available MTRR handling. > > Xen PV PAT handling can work without MTRR, as it just needs to consume > the PAT MSR setting done by the hypervisor without the ability and need > to change it. This in turn has resulted in a convoluted initialization > sequence and wrong decisions regarding cache mode availability due to > misguiding PAT availability flags. > > Fix all of that by allowing to use PAT without MTRR and by adding an > environment dependent PAT init function. > > Cc: # 5.17 > Fixes: bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()") > Signed-off-by: Juergen Gross > --- ... > diff --git a/arch/x86/mm/pat/memtype.c b/arch/x86/mm/pat/memtype.c > index d5ef64ddd35e..3d4bc27ffebb 100644 > --- a/arch/x86/mm/pat/memtype.c > +++ b/arch/x86/mm/pat/memtype.c > ... > > +void pat_init_noset(void) > +{ > + pat_bp_enabled = true; > + init_cache_modes(); > +} This is what should fix the regression caused by commit bdd8b6c98239 ("drm/i915: replace X86_FEATURE_PAT with pat_enabled()"). Thanks for including this. This function might need a better name. Does noset refer to the fact that when we use this function, we do not set or write to the PAT MSR? Maybe it should be pat_init_noset_msr. Is Xen PV Dom0 the only case when this function will be called or is it also for unprivileged Xen PV domains? Then maybe it should be named pat_init_xen_pv_dom0 or maybe just pat_init_xen_pv if it is also used with unprivileged Xen PV domains. Or, if you want to keep the name as pat_init_noset, maybe it should be preceded by a comment clearly explaining this function is currently only for the Xen PV and/or the Xen PV Dom0 case when we don't write to the PAT MSR and we still want to report PAT as enabled in those cases. Chuck From xen-devel-bounces@lists.xenproject.org Wed Jul 20 01:15:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 01:15:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371290.603131 (Exim 4.92) (envelope-from ) id 1oDyIp-0005m1-JI; Wed, 20 Jul 2022 01:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371290.603131; Wed, 20 Jul 2022 01:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyIp-0005lu-Fq; Wed, 20 Jul 2022 01:15:03 +0000 Received: by outflank-mailman (input) for mailman id 371290; Wed, 20 Jul 2022 01:15:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oDyIn-0005lm-NA for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 01:15:01 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5fa7d9d8-07c9-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 03:15:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 09F4D61729; Wed, 20 Jul 2022 01:14:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AE03C341CB; Wed, 20 Jul 2022 01:14:57 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5fa7d9d8-07c9-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658279698; bh=7uBNXbLggcuOPXNHQ1tqRrJpC5voLMlSHr8dtTMW67E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JNJTyfkLKSiddmM9lP65EDCWXbtSDWBw0e8a7OfUq1FDWwXNEkcFLu65fMyJIyh+c FXa+HF3mICV5EhnNO19dB9Zh90ysjgUoftJ/fwAOUa4vX9fzRLC3Mdm+BmU7zsNqtt xbYZrDt4gre9rv57518iKEMP1z/fQSG52MyOMe2Btu0q3wjCRNh47MpypQIzzqbqka skIsVODkRbsEijQKVmo0yv27ArZBLxSpzwQHhJwe+biO2xJwplC9qmTMUFPBtn1Va4 tjyh5r1+wzZBCwI+QgWsZGTyqM4lMUac3aYJfvV5WP21taVy+k2eu367UNRFQHYkDU 96Sey0+POwdww== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Peter Zijlstra , Borislav Petkov , Josh Poimboeuf , Sasha Levin , jgross@suse.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, xen-devel@lists.xenproject.org Subject: [PATCH AUTOSEL 5.15 16/42] x86/xen: Rename SYS* entry points Date: Tue, 19 Jul 2022 21:13:24 -0400 Message-Id: <20220720011350.1024134-16-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220720011350.1024134-1-sashal@kernel.org> References: <20220720011350.1024134-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit From: Peter Zijlstra [ Upstream commit b75b7f8ef1148be1b9321ffc2f6c19238904b438 ] Native SYS{CALL,ENTER} entry points are called entry_SYS{CALL,ENTER}_{64,compat}, make sure the Xen versions are named consistently. Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Borislav Petkov Reviewed-by: Josh Poimboeuf Signed-off-by: Borislav Petkov Signed-off-by: Sasha Levin --- arch/x86/xen/setup.c | 6 +++--- arch/x86/xen/xen-asm.S | 20 ++++++++++---------- arch/x86/xen/xen-ops.h | 6 +++--- 3 files changed, 16 insertions(+), 16 deletions(-) diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c index 8bfc10330107..1f80dd3a2dd4 100644 --- a/arch/x86/xen/setup.c +++ b/arch/x86/xen/setup.c @@ -922,7 +922,7 @@ void xen_enable_sysenter(void) if (!boot_cpu_has(sysenter_feature)) return; - ret = register_callback(CALLBACKTYPE_sysenter, xen_sysenter_target); + ret = register_callback(CALLBACKTYPE_sysenter, xen_entry_SYSENTER_compat); if(ret != 0) setup_clear_cpu_cap(sysenter_feature); } @@ -931,7 +931,7 @@ void xen_enable_syscall(void) { int ret; - ret = register_callback(CALLBACKTYPE_syscall, xen_syscall_target); + ret = register_callback(CALLBACKTYPE_syscall, xen_entry_SYSCALL_64); if (ret != 0) { printk(KERN_ERR "Failed to set syscall callback: %d\n", ret); /* Pretty fatal; 64-bit userspace has no other @@ -940,7 +940,7 @@ void xen_enable_syscall(void) if (boot_cpu_has(X86_FEATURE_SYSCALL32)) { ret = register_callback(CALLBACKTYPE_syscall32, - xen_syscall32_target); + xen_entry_SYSCALL_compat); if (ret != 0) setup_clear_cpu_cap(X86_FEATURE_SYSCALL32); } diff --git a/arch/x86/xen/xen-asm.S b/arch/x86/xen/xen-asm.S index 962d30ea01a2..2cf22624012c 100644 --- a/arch/x86/xen/xen-asm.S +++ b/arch/x86/xen/xen-asm.S @@ -227,7 +227,7 @@ SYM_CODE_END(xenpv_restore_regs_and_return_to_usermode) */ /* Normal 64-bit system call target */ -SYM_CODE_START(xen_syscall_target) +SYM_CODE_START(xen_entry_SYSCALL_64) UNWIND_HINT_EMPTY popq %rcx popq %r11 @@ -241,12 +241,12 @@ SYM_CODE_START(xen_syscall_target) movq $__USER_CS, 1*8(%rsp) jmp entry_SYSCALL_64_after_hwframe -SYM_CODE_END(xen_syscall_target) +SYM_CODE_END(xen_entry_SYSCALL_64) #ifdef CONFIG_IA32_EMULATION /* 32-bit compat syscall target */ -SYM_CODE_START(xen_syscall32_target) +SYM_CODE_START(xen_entry_SYSCALL_compat) UNWIND_HINT_EMPTY popq %rcx popq %r11 @@ -260,10 +260,10 @@ SYM_CODE_START(xen_syscall32_target) movq $__USER32_CS, 1*8(%rsp) jmp entry_SYSCALL_compat_after_hwframe -SYM_CODE_END(xen_syscall32_target) +SYM_CODE_END(xen_entry_SYSCALL_compat) /* 32-bit compat sysenter target */ -SYM_CODE_START(xen_sysenter_target) +SYM_CODE_START(xen_entry_SYSENTER_compat) UNWIND_HINT_EMPTY /* * NB: Xen is polite and clears TF from EFLAGS for us. This means @@ -281,18 +281,18 @@ SYM_CODE_START(xen_sysenter_target) movq $__USER32_CS, 1*8(%rsp) jmp entry_SYSENTER_compat_after_hwframe -SYM_CODE_END(xen_sysenter_target) +SYM_CODE_END(xen_entry_SYSENTER_compat) #else /* !CONFIG_IA32_EMULATION */ -SYM_CODE_START(xen_syscall32_target) -SYM_CODE_START(xen_sysenter_target) +SYM_CODE_START(xen_entry_SYSCALL_compat) +SYM_CODE_START(xen_entry_SYSENTER_compat) UNWIND_HINT_EMPTY lea 16(%rsp), %rsp /* strip %rcx, %r11 */ mov $-ENOSYS, %rax pushq $0 jmp hypercall_iret -SYM_CODE_END(xen_sysenter_target) -SYM_CODE_END(xen_syscall32_target) +SYM_CODE_END(xen_entry_SYSENTER_compat) +SYM_CODE_END(xen_entry_SYSCALL_compat) #endif /* CONFIG_IA32_EMULATION */ diff --git a/arch/x86/xen/xen-ops.h b/arch/x86/xen/xen-ops.h index 8bc8b72a205d..16aed4b12129 100644 --- a/arch/x86/xen/xen-ops.h +++ b/arch/x86/xen/xen-ops.h @@ -10,10 +10,10 @@ /* These are code, but not functions. Defined in entry.S */ extern const char xen_failsafe_callback[]; -void xen_sysenter_target(void); +void xen_entry_SYSENTER_compat(void); #ifdef CONFIG_X86_64 -void xen_syscall_target(void); -void xen_syscall32_target(void); +void xen_entry_SYSCALL_64(void); +void xen_entry_SYSCALL_compat(void); #endif extern void *xen_initial_gdt; -- 2.35.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 03:29:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 03:29:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371306.603146 (Exim 4.92) (envelope-from ) id 1oE0Oy-0005E7-CH; Wed, 20 Jul 2022 03:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371306.603146; Wed, 20 Jul 2022 03:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE0Oy-0005E0-95; Wed, 20 Jul 2022 03:29:32 +0000 Received: by outflank-mailman (input) for mailman id 371306; Wed, 20 Jul 2022 03:29:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE0Ow-0005Du-37 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 03:29:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2042.outbound.protection.outlook.com [40.107.22.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2755272c-07dc-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 05:29:25 +0200 (CEST) Received: from DU2PR04CA0328.eurprd04.prod.outlook.com (2603:10a6:10:2b5::33) by AM6PR08MB4231.eurprd08.prod.outlook.com (2603:10a6:20b:73::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Wed, 20 Jul 2022 03:29:19 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::48) by DU2PR04CA0328.outlook.office365.com (2603:10a6:10:2b5::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.24 via Frontend Transport; Wed, 20 Jul 2022 03:29:19 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Wed, 20 Jul 2022 03:29:19 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Wed, 20 Jul 2022 03:29:19 +0000 Received: from ca43a0e1eb58.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0C7D5A2E-6E77-4E4F-AF9A-4353D5B322BB.1; Wed, 20 Jul 2022 03:29:09 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id ca43a0e1eb58.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Jul 2022 03:29:09 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com (2603:10a6:20b:523::11) by AM0PR08MB4466.eurprd08.prod.outlook.com (2603:10a6:208:141::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Wed, 20 Jul 2022 03:29:05 +0000 Received: from AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::1448:c938:fc33:56dc]) by AS8PR08MB7696.eurprd08.prod.outlook.com ([fe80::1448:c938:fc33:56dc%7]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 03:29:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2755272c-07dc-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dCaLaaWd6XVk2QQfH/S69nojAidGBOYycEWtn5TWsbqVSeq6dGJnCxKyiuck6OhlgiBm1SFEW6JOnSJ99Fv8NRJJ9MVQfPizOdxLAtiJzcrXq6GN72qbeNi9T/IUzUU7q+jfIpp3Ng/ExoVmO2QUVXIFE0TwzPRhCHVZIoEbKzSIgyK/HBgthJRW9Y+TUjbbZ1oJlx5FGCDp1SJLghce5KmyLdmMXwjQnedj8M8Z3/ozA1wvU9yfB+meBNu5qO18PfPxNGn9zUu93K22jOsm2FLQdNf0R/3sCBC+Ug+7vbsoRF97hsh+Pz7YqZpGJobSfXVFXu5Nl8t9InOw6KpM/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/2iTU67W94U5/9sDmpUejpz/8o3RMqhXvqjH8zS01o=; b=hbQLdwjDOViIP/zIjifQhLDYctbrXv6A2al7P+Z1DJZEgoSisBrZzH3hO1SxXUav7OGo7eWTfZ4ig7UHSDnXpyaZRw3vyg9UZurz7+DWiOfB8StbomFhXpGfLqAlUUr6i3sPGmobbpafLLFemwHsUCbNXYoiq5eUoh4hKlOQrkKot3GX3lxvPt1Cq5FtGssx2xkZdLr6HD+dPShPvTcIcvVKpxXByy9qRSnxhLszFZp0zwBgVT0KBUL3St+jxF740NGnQ1cKo7+1HOKT0/haVpFyF0f/J8d3U71dRZGck/qs+hCeT/2xWYE9oLtDfuZOm7li6sk3IKKwZPNQB/DTrg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/2iTU67W94U5/9sDmpUejpz/8o3RMqhXvqjH8zS01o=; b=0v2qFmZNGKk/tKAduYWaw+xNAuRlvhhm6myeeqsRL7yNnUJxAQ7ASux4gqBeyuGba6SGGi4oG0Qa+9uaJ/FeOSYJ0iohtL9GAetVFNMNhV2Ut51OUBGNjRvyRy6kusLTSSPQzlDZCoEemeTj4cuXucDlW0arh7A9K8pci2Qxc3U= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nuBIRjWMDlwn02qbA+uOYMoRJqAeM/ZnBbLGkygZIBePZgiZxOxfSPmqV+9UAlbJVO7ZJPvdPAcEyxUt/6rBvoCr610XwtesjUG+Zovvv+7Q+ALoLbBzXz3aeraCw5O7C5LcHy5ATYMZuVg7CBNQTXRnRE+cQaPqv1QMZtppWLpOYHHX8z4LBbV7zOFgYiY8FXksW2YFkfYJPDETcxp0HgrfAEjjyYu+/6R833OWUF0krz53/y6derSluWPI7RugvUNkxghksQHtv/EguF/lSmG6EhU2zHCYYKrca+8NeUIG/VGVGzhFgkWYaUL32We52HvtqfEXHt4jxXN7bhEFlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8/2iTU67W94U5/9sDmpUejpz/8o3RMqhXvqjH8zS01o=; b=jGRUJhABTCqi4WhqEyUSvrMcKK2XPqV+3KG7lyRVhfp7I4QSfkEjhcWPH0ehQL1NkxYqi2aw3mQj2sZcc0LXIE4FARUMK8AkgTdl1TnPa2ZgGFBvTaoZLtNxtrX7ceQ8BHeazN3ERurMjM9Q8npzcox+mBr/h5kd3ist1hTAqaFedY+KFqZxqwAbU1tsxmRG6tUgI2U7p6Of9W3Ozt8avTHc+xK8SNhTvAYEPpqpc8PEFYn6clSm00ubP1XxfemIffSKE7RX4gjJGb7sY1cupwDZCwiXBC3UUx4Fjkv+yEKm5FIQ094xA1GDikEBgO5pCQ00uVHn2thhzSmZUWvCXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8/2iTU67W94U5/9sDmpUejpz/8o3RMqhXvqjH8zS01o=; b=0v2qFmZNGKk/tKAduYWaw+xNAuRlvhhm6myeeqsRL7yNnUJxAQ7ASux4gqBeyuGba6SGGi4oG0Qa+9uaJ/FeOSYJ0iohtL9GAetVFNMNhV2Ut51OUBGNjRvyRy6kusLTSSPQzlDZCoEemeTj4cuXucDlW0arh7A9K8pci2Qxc3U= From: Jiamei Xie To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" CC: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , Bertrand Marquis Subject: RE: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYmTKNM91k5Yj/D023jkBScjNdsa2GlDng Date: Wed, 20 Jul 2022 03:29:05 +0000 Message-ID: References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> <20220716163745.28712-1-olekstysh@gmail.com> In-Reply-To: <20220716163745.28712-1-olekstysh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: F05C47EFD117A34884F93DA83D283236.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 09e0fd30-45f6-4a5d-a80b-08da6a0007ec x-ms-traffictypediagnostic: AM0PR08MB4466:EE_|DBAEUR03FT050:EE_|AM6PR08MB4231:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ycg8jFH7VA+zMi6lV4xhDmtsdU0upJkRtcTyjm6L3J2YwGoiMPEqSavmgeopYKdwZViVxLQZOsk1jj7CEGCOQ3z+WkraqE3/AF5fn5VYMkuntSb4/NW28JRYfewuaDUvhiXybUctHt8e7ysX3ErFHFoFeaEB6QTwNI96W7gEH+iQaB/edTjv4m4Ih3vFivANbsIfwur2qm6AeIONnNwXGTELS8lFMfEnY7xsflXnfdHbjWvz7f3FAEHhNBoPySGUEWwaYjepu9FDxqBfxBuirIHEoDxJ9XWWcy8d2QjfB8O5krBSS8w3l7w1Pud6Ykxi3iWMN8H3YjA/yADUnzkzV7k3L/w8e1CJiG7wwHGMKmKaEslgpv2964mPoo0SgrydCPsikSpCTQUD9Rv0JNBBhFO4rD3GqGsUTP+etAqhLGEvs34nUGQu+noAlLsZeYgfoX/7YUzhyky3Nx8zejMR9cIh9gvzeh4Q1NvAd2NCOiJj5nU44OSkCHMrUD/HEn6A9EaWzXra4pLwZR10zOT8U04J+QgqBZe2NZmBKi0u2ya3F1vZWUxHNvviG18uRfbKiHzb6z9BTgT/ArrLiFV8cu+tnCzHrTEmok9fTWpOEsOfDkkdyXE1BNf6dHyvrJN91UsTPWT8ocF7eIVPIeVm9ukE2sCSp9XzhLNkt3MKQSqgvEjDTzfs1WbmC05sMkDBD3dOVL+ThLqyZp9JsO9Np5h/fUQOh+x3+GsbWO6lsXgoGwyNjqUEgKLeWs3njseE37Vk3AH1EdhSbEBQduZx/Wf3z2+0zhLOVuNX3xo//Ggo9keKIUGEDved3sb9X+mq X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7696.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(366004)(396003)(346002)(8936002)(33656002)(52536014)(30864003)(5660300002)(55016003)(66476007)(54906003)(86362001)(2906002)(66556008)(7416002)(66446008)(4326008)(110136005)(316002)(76116006)(7696005)(41300700001)(83380400001)(71200400001)(8676002)(6506007)(478600001)(9686003)(122000001)(38100700002)(26005)(53546011)(66946007)(38070700005)(64756008)(186003)(579004)(559001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4466 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0bd74391-ff06-425b-da26-08da69ffff8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: y6hMEMQcGpOdgzQ68ZzreEjVDd5W768Up3QgoxJ4v5Xdc+4cVtU6BzhRk8wadIpNXS/CnWvqABP5gDsfzAvoFccI24DlCNXY6DJtRVnmPBKjqwEtZnh+paLBJ1noAyiJOTFIfQlzB6moyfTsawVVDaZ32nqXrgaQYHDTx6Etj+VW9tpLe9EtPF45Egw5CZhg2Bo/ISWsN1OGUTOw3+o3ttTvgVcz5SzQ3+5+AwpTsL83/GrrnmKxqzHAG0MVYC7MAbnYlpfGCxVa7ByDwJ8iRUZJIRQh2R6PJn97kizqvvLCUFnofb1PJ85xbwtJySCImZZIEQv/Je1GF2uu7J+xAkIxn9zBXDZtXbVRSO03OoaLGl4QK1+frb33W//GhD6IJvPLgTpH41I7x5r0kuTihEwpS/efBBzNVVqnU6VMMvasA4WPaErPxjSqZ6X9mlyXIUOcooXyRD+7ABQmve/KH0NWDX22JbXwAoxiBloKjcEqnnywWS5EStVR1Hypd/g8S9q1vR+PHpYvPfzYi751AhdsteCSg6d0ojzeUUbxDKCqmpBn52kIeMybCvezZBRfCwfABMO7f6wajY3w9CptxtijXq7MiAZTDRa36Vtpv8BNHvpnisL0/FuPqI2ImZyopDrn3W2JuHUzmrOLI58L7q1iZnDfPeWuXfQM1AiY6a+xC7uIy+sX5+odMfwdVbboZoNWSBY2J+K83tl8ADysNH0MTeifmbG1WSDxuB+xD+QMzjxXTdHbFcs6LJtXyRgTm063voFVyPIiySa18OhlRo4y4eVXypu5zuykFaceh55FnRzT8TxGwL6G1NQ2jwR6 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(346002)(39860400002)(40470700004)(46966006)(36840700001)(36860700001)(4326008)(40480700001)(8936002)(316002)(5660300002)(55016003)(52536014)(82310400005)(54906003)(40460700003)(2906002)(70586007)(83380400001)(8676002)(70206006)(356005)(86362001)(82740400003)(41300700001)(33656002)(6506007)(81166007)(110136005)(7696005)(336012)(9686003)(186003)(47076005)(478600001)(26005)(30864003)(53546011)(579004)(559001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 03:29:19.1684 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 09e0fd30-45f6-4a5d-a80b-08da6a0007ec X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4231 Hi Oleksandr, We have tested it on arm64 with " disk =3D [ 'phy:/usr/share/guests/disk.im= g0, xvda1, backendtype=3Dstandalone, specification=3Dvirtio']". It works ok= . Tested-by: Jiamei Xie Tested-by: Henry Wang Best wishes Jiamei Xie > -----Original Message----- > From: Xen-devel On Behalf Of > Oleksandr Tyshchenko > Sent: Sunday, July 17, 2022 12:38 AM > To: xen-devel@lists.xenproject.org > Cc: Oleksandr Tyshchenko ; Wei Liu > ; Anthony PERARD ; George > Dunlap ; Nick Rosbrook > ; Juergen Gross ; Stefano > Stabellini ; Julien Grall ; Volod= ymyr > Babchuk ; Bertrand Marquis > > Subject: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configurati= on >=20 > From: Oleksandr Tyshchenko >=20 > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-disk backend (emulator) which is intended to run out of > Qemu and could be run in any domain. > Although the Virtio block device is quite different from traditional > Xen PV block device (vbd) from the toolstack's point of view: > - as the frontend is virtio-blk which is not a Xenbus driver, nothing > written to Xenstore are fetched by the frontend currently ("vdev" > is not passed to the frontend). But this might need to be revised > in future, so frontend data might be written to Xenstore in order to > support hotplugging virtio devices or passing the backend domain id > on arch where the device-tree is not available. > - the ring-ref/event-channel are not used for the backend<->frontend > communication, the proposed IPC for Virtio is IOREQ/DM > it is still a "block device" and ought to be integrated in existing > "disk" handling. So, re-use (and adapt) "disk" parsing/configuration > logic to deal with Virtio devices as well. >=20 > For the immediate purpose and an ability to extend that support for > other use-cases in future (Qemu, virtio-pci, etc) perform the following > actions: > - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and > reflect > that in the configuration > - Introduce new disk "specification" and "transport" fields to struct > libxl_device_disk. Both are written to the Xenstore. The transport > field is only used for the specification "virtio" and it assumes > only "mmio" value for now. > - Introduce new "specification" option with "xen" communication > protocol being default value. > - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current > one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model >=20 > An example of domain configuration for Virtio disk: > disk =3D [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=3Dstandalone, > specification=3Dvirtio'] >=20 > Nothing has changed for default Xen disk configuration. >=20 > Please note, this patch is not enough for virtio-disk to work > on Xen (Arm), as for every Virtio device (including disk) we need > to allocate Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree. The subsequent > patch will add these missing bits. For the current patch, > the default "irq" and "base" are just written to the Xenstore. > This is not an ideal splitting, but this way we avoid breaking > the bisectability. >=20 > Signed-off-by: Oleksandr Tyshchenko > --- > Changes RFC -> V1: > - no changes >=20 > Changes V1 -> V2: > - rebase according to the new location of libxl_virtio_disk.c >=20 > Changes V2 -> V3: > - no changes >=20 > Changes V3 -> V4: > - rebase according to the new argument for DEFINE_DEVICE_TYPE_STRUCT >=20 > Changes V4 -> V5: > - split the changes, change the order of the patches > - update patch description > - don't introduce new "vdisk" configuration option with own parsing lo= gic, > re-use Xen PV block "disk" parsing/configuration logic for the virti= o-disk > - introduce "virtio" flag and document it's usage > - add LIBXL_HAVE_DEVICE_DISK_VIRTIO > - update libxlu_disk_l.[ch] > - drop num_disks variable/MAX_VIRTIO_DISKS > - drop Wei's T-b >=20 > Changes V5 -> V6: > - rebase on current staging > - use "%"PRIu64 instead of %lu for disk->base in device_disk_add() > - update *.gen.go files >=20 > Changes V6 -> V7: > - rebase on current staging > - update *.gen.go files and libxlu_disk_l.[ch] files > - update patch description > - rework significantly to support more flexible configuration > and have more generic basic implementation for being able to extend > that for other use-cases (virtio-pci, qemu, etc). >=20 > Changes V7 -> V8: > - update *.gen.go files and libxlu_disk_l.[ch] files > - update patch description and comments in the code > - use "specification" config option instead of "protocol" > - update libxl_types.idl and code according to new fields > in libxl_device_disk >=20 > Changes V8 -> V9: > - update (and harden) checks in libxl__device_disk_setdefault(), > return error in case of incorrect settings of specification > and transport > - remove both asserts in device_disk_add() > - update virtio related code in libxl__disk_from_xenstore(), > do not fail if specification node is absent, replace > open-coded checks of fetched specification and transport by > libxl_disk_specification_from_string() and > libxl_disk_transport_from_string() > respectively > - s/libxl_device_disk_get_path/libxl__device_disk_get_path > - add a comment for virtio-mmio parameters in struct libxl_device_disk >=20 > Changes V9 -> V10: > - s/ERROR_FAIL/ERROR_INVAL in both places in > libxl__device_disk_setdefault() > - rework libxl__device_disk_get_path() >=20 > Changes V10 -> V10.1: > - fix small coding style issue in libxl__device_disk_get_path() > - drop specification check in main_blockattach() and add > required check in libxl__device_disk_setdefault() > - update specification check in main_blockdetach() >=20 > Changes V10.1 -> V11: > - Anthony already gave his Reviewed-by, I dropped it due to the change= s > - George already gave his Acked-by, I dropped it due to the changes > - s/other/standalone for the backendtype >=20 > Changes V11 -> V11.1: > - rebase > --- > docs/man/xl-disk-configuration.5.pod.in | 38 +- > tools/golang/xenlight/helpers.gen.go | 8 + > tools/golang/xenlight/types.gen.go | 18 + > tools/include/libxl.h | 7 + > tools/libs/light/libxl_device.c | 62 +- > tools/libs/light/libxl_disk.c | 146 +++- > tools/libs/light/libxl_internal.h | 2 + > tools/libs/light/libxl_types.idl | 18 + > tools/libs/light/libxl_types_internal.idl | 1 + > tools/libs/light/libxl_utils.c | 2 + > tools/libs/util/libxlu_disk_l.c | 959 +++++++++++----------- > tools/libs/util/libxlu_disk_l.h | 2 +- > tools/libs/util/libxlu_disk_l.l | 9 + > tools/xl/xl_block.c | 6 + > 14 files changed, 798 insertions(+), 480 deletions(-) >=20 > diff --git a/docs/man/xl-disk-configuration.5.pod.in b/docs/man/xl-disk- > configuration.5.pod.in > index 95d039655a..bc945cc517 100644 > --- a/docs/man/xl-disk-configuration.5.pod.in > +++ b/docs/man/xl-disk-configuration.5.pod.in > @@ -232,7 +232,7 @@ Specifies the backend implementation to use >=20 > =3Ditem Supported values >=20 > -phy, qdisk > +phy, qdisk, standalone >=20 > =3Ditem Mandatory >=20 > @@ -244,11 +244,13 @@ Automatically determine which backend to use. >=20 > =3Dback >=20 > -This does not affect the guest's view of the device. It controls > -which software implementation of the Xen backend driver is used. > +It controls which software implementation of the backend driver is used. > +Depending on the "specification" option this may affect the guest's view > +of the device. >=20 > Not all backend drivers support all combinations of other options. > -For example, "phy" does not support formats other than "raw". > +For example, "phy" and "standalone" do not support formats other than > "raw" > +and "standalone" does not support specifications other than "virtio". > Normally this option should not be specified, in which case libxl will > automatically determine the most suitable backend. >=20 > @@ -373,8 +375,36 @@ processing or causing malfunction to the frontend > or the whole domain. >=20 > Note frontends can ignore such recommendation. >=20 > +=3Ditem B=3DI > + > +=3Dover 4 > + > +=3Ditem Description > + > +Specifies the communication protocol (specification) to use for the chos= en > +"backendtype" option > + > +=3Ditem Supported values > + > +xen, virtio > + > +=3Ditem Mandatory > + > +No > + > +=3Ditem Default value > + > +xen > + > =3Dback >=20 > +Besides forcing toolstack to use specific backend implementation, this a= lso > +affects the guest's view of the device. For example, "virtio" requires > +Virtio frontend driver (virtio-blk) to be used. Please note, the virtual > +device (vdev) is not passed to the guest in that case, but it still must= be > +specified for the internal purposes. > + > +=3Dback >=20 > =3Dhead1 COLO Parameters >=20 > diff --git a/tools/golang/xenlight/helpers.gen.go > b/tools/golang/xenlight/helpers.gen.go > index dece545ee0..ad8c11eae1 100644 > --- a/tools/golang/xenlight/helpers.gen.go > +++ b/tools/golang/xenlight/helpers.gen.go > @@ -1763,6 +1763,10 @@ x.DirectIoSafe =3D bool(xc.direct_io_safe) > if err :=3D x.DiscardEnable.fromC(&xc.discard_enable);err !=3D nil { > return fmt.Errorf("converting field DiscardEnable: %v", err) > } > +x.Specification =3D DiskSpecification(xc.specification) > +x.Transport =3D DiskTransport(xc.transport) > +x.Irq =3D uint32(xc.irq) > +x.Base =3D uint64(xc.base) > if err :=3D x.ColoEnable.fromC(&xc.colo_enable);err !=3D nil { > return fmt.Errorf("converting field ColoEnable: %v", err) > } > @@ -1800,6 +1804,10 @@ xc.direct_io_safe =3D C.bool(x.DirectIoSafe) > if err :=3D x.DiscardEnable.toC(&xc.discard_enable); err !=3D nil { > return fmt.Errorf("converting field DiscardEnable: %v", err) > } > +xc.specification =3D C.libxl_disk_specification(x.Specification) > +xc.transport =3D C.libxl_disk_transport(x.Transport) > +xc.irq =3D C.uint32_t(x.Irq) > +xc.base =3D C.uint64_t(x.Base) > if err :=3D x.ColoEnable.toC(&xc.colo_enable); err !=3D nil { > return fmt.Errorf("converting field ColoEnable: %v", err) > } > diff --git a/tools/golang/xenlight/types.gen.go > b/tools/golang/xenlight/types.gen.go > index 253c9ad93d..b9143390f8 100644 > --- a/tools/golang/xenlight/types.gen.go > +++ b/tools/golang/xenlight/types.gen.go > @@ -99,6 +99,20 @@ DiskBackendUnknown DiskBackend =3D 0 > DiskBackendPhy DiskBackend =3D 1 > DiskBackendTap DiskBackend =3D 2 > DiskBackendQdisk DiskBackend =3D 3 > +DiskBackendStandalone DiskBackend =3D 4 > +) > + > +type DiskSpecification int > +const( > +DiskSpecificationUnknown DiskSpecification =3D 0 > +DiskSpecificationXen DiskSpecification =3D 1 > +DiskSpecificationVirtio DiskSpecification =3D 2 > +) > + > +type DiskTransport int > +const( > +DiskTransportUnknown DiskTransport =3D 0 > +DiskTransportMmio DiskTransport =3D 1 > ) >=20 > type NicType int > @@ -645,6 +659,10 @@ Readwrite int > IsCdrom int > DirectIoSafe bool > DiscardEnable Defbool > +Specification DiskSpecification > +Transport DiskTransport > +Irq uint32 > +Base uint64 > ColoEnable Defbool > ColoRestoreEnable Defbool > ColoHost string > diff --git a/tools/include/libxl.h b/tools/include/libxl.h > index f351669039..2321a648a5 100644 > --- a/tools/include/libxl.h > +++ b/tools/include/libxl.h > @@ -549,6 +549,13 @@ > */ > #define LIBXL_HAVE_ASSISTED_APIC 1 >=20 > +/* > + * LIBXL_HAVE_DEVICE_DISK_SPECIFICATION indicates that 'specification' > and > + * 'transport' fields (of libxl_disk_specification and libxl_disk_transp= ort > + * types respectively) are present in libxl_device_disk. > + */ > +#define LIBXL_HAVE_DEVICE_DISK_SPECIFICATION 1 > + > /* > * libxl ABI compatibility > * > diff --git a/tools/libs/light/libxl_device.c b/tools/libs/light/libxl_dev= ice.c > index e6025d135e..a75c21d433 100644 > --- a/tools/libs/light/libxl_device.c > +++ b/tools/libs/light/libxl_device.c > @@ -289,9 +289,16 @@ static int disk_try_backend(disk_try_backend_args > *a, > libxl_disk_backend backend) > { > libxl__gc *gc =3D a->gc; > + libxl_disk_specification specification =3D a->disk->specification; > /* returns 0 (ie, DISK_BACKEND_UNKNOWN) on failure, or > * backend on success */ >=20 > + if ((specification =3D=3D LIBXL_DISK_SPECIFICATION_VIRTIO && > + backend !=3D LIBXL_DISK_BACKEND_STANDALONE) || > + (specification !=3D LIBXL_DISK_SPECIFICATION_VIRTIO && > + backend =3D=3D LIBXL_DISK_BACKEND_STANDALONE)) > + goto bad_specification; > + > switch (backend) { > case LIBXL_DISK_BACKEND_PHY: > if (a->disk->format !=3D LIBXL_DISK_FORMAT_RAW) { > @@ -329,6 +336,29 @@ static int disk_try_backend(disk_try_backend_args > *a, > if (a->disk->script) goto bad_script; > return backend; >=20 > + case LIBXL_DISK_BACKEND_STANDALONE: > + if (a->disk->format !=3D LIBXL_DISK_FORMAT_RAW) > + goto bad_format; > + > + if (a->disk->script) > + goto bad_script; > + > + if (libxl_defbool_val(a->disk->colo_enable)) > + goto bad_colo; > + > + if (a->disk->backend_domid !=3D LIBXL_TOOLSTACK_DOMID) { > + LOG(DEBUG, "Disk vdev=3D%s, is using a storage driver domain= , " > + "skipping physical device check", a->disk->vdev); > + return backend; > + } > + > + if (libxl__try_phy_backend(a->stab.st_mode)) > + return backend; > + > + LOG(DEBUG, "Disk vdev=3D%s, backend standalone unsuitable as phy= s > path not a " > + "block device", a->disk->vdev); > + return 0; > + > default: > LOG(DEBUG, "Disk vdev=3D%s, backend %d unknown", a->disk->vdev, > backend); > return 0; > @@ -352,6 +382,12 @@ static int disk_try_backend(disk_try_backend_args > *a, > LOG(DEBUG, "Disk vdev=3D%s, backend %s not compatible with colo", > a->disk->vdev, libxl_disk_backend_to_string(backend)); > return 0; > + > + bad_specification: > + LOG(DEBUG, "Disk vdev=3D%s, backend %s not compatible with > specification %s", > + a->disk->vdev, libxl_disk_backend_to_string(backend), > + libxl_disk_specification_to_string(specification)); > + return 0; > } >=20 > int libxl__backendpath_parse_domid(libxl__gc *gc, const char *be_path, > @@ -376,8 +412,9 @@ int libxl__device_disk_set_backend(libxl__gc *gc, > libxl_device_disk *disk) { > a.gc =3D gc; > a.disk =3D disk; >=20 > - LOG(DEBUG, "Disk vdev=3D%s spec.backend=3D%s", disk->vdev, > - libxl_disk_backend_to_string(disk->backend)); > + LOG(DEBUG, "Disk vdev=3D%s spec.backend=3D%s specification=3D%s", di= sk- > >vdev, > + libxl_disk_backend_to_string(disk->backend), > + libxl_disk_specification_to_string(disk->specification)); >=20 > if (disk->format =3D=3D LIBXL_DISK_FORMAT_EMPTY) { > if (!disk->is_cdrom) { > @@ -392,7 +429,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, > libxl_device_disk *disk) { > } > memset(&a.stab, 0, sizeof(a.stab)); > } else if ((disk->backend =3D=3D LIBXL_DISK_BACKEND_UNKNOWN || > - disk->backend =3D=3D LIBXL_DISK_BACKEND_PHY) && > + disk->backend =3D=3D LIBXL_DISK_BACKEND_PHY || > + disk->backend =3D=3D LIBXL_DISK_BACKEND_STANDALONE) && > disk->backend_domid =3D=3D LIBXL_TOOLSTACK_DOMID && > !disk->script) { > if (stat(disk->pdev_path, &a.stab)) { > @@ -408,7 +446,8 @@ int libxl__device_disk_set_backend(libxl__gc *gc, > libxl_device_disk *disk) { > ok=3D > disk_try_backend(&a, LIBXL_DISK_BACKEND_PHY) ?: > disk_try_backend(&a, LIBXL_DISK_BACKEND_QDISK) ?: > - disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP); > + disk_try_backend(&a, LIBXL_DISK_BACKEND_TAP) ?: > + disk_try_backend(&a, LIBXL_DISK_BACKEND_STANDALONE); > if (ok) > LOG(DEBUG, "Disk vdev=3D%s, using backend %s", > disk->vdev, > @@ -441,10 +480,25 @@ char > *libxl__device_disk_string_of_backend(libxl_disk_backend backend) > case LIBXL_DISK_BACKEND_QDISK: return "qdisk"; > case LIBXL_DISK_BACKEND_TAP: return "phy"; > case LIBXL_DISK_BACKEND_PHY: return "phy"; > + case LIBXL_DISK_BACKEND_STANDALONE: return "standalone"; > + default: return NULL; > + } > +} > + > +char *libxl__device_disk_string_of_specification(libxl_disk_specificatio= n > specification) > +{ > + switch (specification) { > + case LIBXL_DISK_SPECIFICATION_XEN: return "xen"; > + case LIBXL_DISK_SPECIFICATION_VIRTIO: return "virtio"; > default: return NULL; > } > } >=20 > +char *libxl__device_disk_string_of_transport(libxl_disk_transport transp= ort) > +{ > + return (transport =3D=3D LIBXL_DISK_TRANSPORT_MMIO ? "mmio" : NULL); > +} > + > const char *libxl__qemu_disk_format_string(libxl_disk_format format) > { > switch (format) { > diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.= c > index 9da2b2ed27..ea3623dd6f 100644 > --- a/tools/libs/light/libxl_disk.c > +++ b/tools/libs/light/libxl_disk.c > @@ -164,6 +164,30 @@ static int libxl__device_disk_setdefault(libxl__gc *= gc, > uint32_t domid, > rc =3D libxl__resolve_domid(gc, disk->backend_domname, &disk- > >backend_domid); > if (rc < 0) return rc; >=20 > + if (disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_UNKNOWN) > + disk->specification =3D LIBXL_DISK_SPECIFICATION_XEN; > + > + if (disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_XEN && > + disk->transport !=3D LIBXL_DISK_TRANSPORT_UNKNOWN) { > + LOGD(ERROR, domid, "Transport is only supported for specificatio= n > virtio"); > + return ERROR_INVAL; > + } > + > + /* Force transport mmio for specification virtio for now */ > + if (disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_VIRTIO) { > + if (!(disk->transport =3D=3D LIBXL_DISK_TRANSPORT_UNKNOWN || > + disk->transport =3D=3D LIBXL_DISK_TRANSPORT_MMIO)) { > + LOGD(ERROR, domid, "Unsupported transport for specification > virtio"); > + return ERROR_INVAL; > + } > + disk->transport =3D LIBXL_DISK_TRANSPORT_MMIO; > + } > + > + if (hotplug && disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_V= IRTIO) { > + LOGD(ERROR, domid, "Hotplug isn't supported for specification vi= rtio"); > + return ERROR_FAIL; > + } > + > /* Force Qdisk backend for CDROM devices of guests with a device mod= el. > */ > if (disk->is_cdrom !=3D 0 && > libxl__domain_type(gc, domid) =3D=3D LIBXL_DOMAIN_TYPE_HVM) { > @@ -205,6 +229,9 @@ static int libxl__device_from_disk(libxl__gc *gc, > uint32_t domid, > case LIBXL_DISK_BACKEND_QDISK: > device->backend_kind =3D LIBXL__DEVICE_KIND_QDISK; > break; > + case LIBXL_DISK_BACKEND_STANDALONE: > + device->backend_kind =3D LIBXL__DEVICE_KIND_VIRTIO_DISK; > + break; > default: > LOGD(ERROR, domid, "Unrecognized disk backend type: %d", > disk->backend); > @@ -213,7 +240,8 @@ static int libxl__device_from_disk(libxl__gc *gc, > uint32_t domid, >=20 > device->domid =3D domid; > device->devid =3D devid; > - device->kind =3D LIBXL__DEVICE_KIND_VBD; > + device->kind =3D disk->backend =3D=3D LIBXL_DISK_BACKEND_STANDALONE = ? > + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; >=20 > return 0; > } > @@ -331,7 +359,14 @@ static void device_disk_add(libxl__egc *egc, > uint32_t domid, >=20 > assert(device->backend_kind =3D=3D LIBXL__DEVICE_KIND_VB= D); > break; > + case LIBXL_DISK_BACKEND_STANDALONE: > + dev =3D disk->pdev_path; > + > + flexarray_append(back, "params"); > + flexarray_append(back, dev); >=20 > + assert(device->backend_kind =3D=3D > LIBXL__DEVICE_KIND_VIRTIO_DISK); > + break; > case LIBXL_DISK_BACKEND_TAP: > LOG(ERROR, "blktap is not supported"); > rc =3D ERROR_FAIL; > @@ -387,6 +422,14 @@ static void device_disk_add(libxl__egc *egc, > uint32_t domid, > flexarray_append_pair(back, "discard-enable", > libxl_defbool_val(disk->discard_enable) ? > "1" : "0"); > + flexarray_append(back, "specification"); > + flexarray_append(back, libxl__device_disk_string_of_specificatio= n(disk- > >specification)); > + if (disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_VIRTIO) = { > + flexarray_append(back, "transport"); > + flexarray_append(back, libxl__device_disk_string_of_transpor= t(disk- > >transport)); > + flexarray_append_pair(back, "base", GCSPRINTF("%"PRIu64, dis= k- > >base)); > + flexarray_append_pair(back, "irq", GCSPRINTF("%u", disk->irq= )); > + } >=20 > flexarray_append(front, "backend-id"); > flexarray_append(front, GCSPRINTF("%d", disk->backend_domid)); > @@ -535,6 +578,53 @@ static int libxl__disk_from_xenstore(libxl__gc *gc, > const char *libxl_path, > } > libxl_string_to_backend(ctx, tmp, &(disk->backend)); >=20 > + tmp =3D libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/specification", libxl_path)); > + if (!tmp) { > + LOG(DEBUG, "Missing xenstore node %s/specification, assuming > specification xen", libxl_path); > + disk->specification =3D LIBXL_DISK_SPECIFICATION_XEN; > + } else { > + rc =3D libxl_disk_specification_from_string(tmp, &disk->specific= ation); > + if (rc) { > + LOG(ERROR, "Unable to parse xenstore node %s/specification", > libxl_path); > + goto cleanup; > + } > + } > + > + if (disk->specification =3D=3D LIBXL_DISK_SPECIFICATION_VIRTIO) { > + tmp =3D libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/transport", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/transport", libxl_path)= ; > + goto cleanup; > + } > + rc =3D libxl_disk_transport_from_string(tmp, &disk->transport); > + if (rc) { > + LOG(ERROR, "Unable to parse xenstore node %s/transport", > libxl_path); > + goto cleanup; > + } > + if (disk->transport !=3D LIBXL_DISK_TRANSPORT_MMIO) { > + LOG(ERROR, "Only transport mmio is expected for specificatio= n > virtio"); > + goto cleanup; > + } > + > + tmp =3D libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/base", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/base", libxl_path); > + goto cleanup; > + } > + disk->base =3D strtoul(tmp, NULL, 10); > + > + tmp =3D libxl__xs_read(gc, XBT_NULL, > + GCSPRINTF("%s/irq", libxl_path)); > + if (!tmp) { > + LOG(ERROR, "Missing xenstore node %s/irq", libxl_path); > + goto cleanup; > + } > + disk->irq =3D strtoul(tmp, NULL, 10); > + } > + > disk->vdev =3D xs_read(ctx->xsh, XBT_NULL, > GCSPRINTF("%s/dev", libxl_path), &len); > if (!disk->vdev) { > @@ -578,6 +668,42 @@ cleanup: > return rc; > } >=20 > +static int libxl__device_disk_get_path(libxl__gc *gc, uint32_t domid, > + char **path) > +{ > + const char *xen_dir, *virtio_dir; > + char *xen_path, *virtio_path; > + int rc; > + > + /* default path */ > + xen_path =3D GCSPRINTF("%s/device/%s", > + libxl__xs_libxl_path(gc, domid), > + libxl__device_kind_to_string(LIBXL__DEVICE_KIND= _VBD)); > + > + rc =3D libxl__xs_read_checked(gc, XBT_NULL, xen_path, &xen_dir); > + if (rc) > + return rc; > + > + virtio_path =3D GCSPRINTF("%s/device/%s", > + libxl__xs_libxl_path(gc, domid), > + > libxl__device_kind_to_string(LIBXL__DEVICE_KIND_VIRTIO_DISK)); > + > + rc =3D libxl__xs_read_checked(gc, XBT_NULL, virtio_path, &virtio_dir= ); > + if (rc) > + return rc; > + > + if (xen_dir && virtio_dir) { > + LOGD(ERROR, domid, "Invalid configuration, both xen and virtio p= aths > are present"); > + return ERROR_INVAL; > + } else if (virtio_dir) { > + *path =3D virtio_path; > + } else { > + *path =3D xen_path; > + } > + > + return 0; > +} > + > int libxl_vdev_to_device_disk(libxl_ctx *ctx, uint32_t domid, > const char *vdev, libxl_device_disk *disk) > { > @@ -591,10 +717,12 @@ int libxl_vdev_to_device_disk(libxl_ctx *ctx, > uint32_t domid, >=20 > libxl_device_disk_init(disk); >=20 > - libxl_path =3D libxl__domain_device_libxl_path(gc, domid, devid, > - LIBXL__DEVICE_KIND_VBD)= ; > + rc =3D libxl__device_disk_get_path(gc, domid, &libxl_path); > + if (rc) > + return rc; >=20 > - rc =3D libxl__disk_from_xenstore(gc, libxl_path, devid, disk); > + rc =3D libxl__disk_from_xenstore(gc, GCSPRINTF("%s/%d", libxl_path, = devid), > + devid, disk); >=20 > GC_FREE; > return rc; > @@ -608,16 +736,19 @@ int libxl_device_disk_getinfo(libxl_ctx *ctx, > uint32_t domid, > char *fe_path, *libxl_path; > char *val; > int rc; > + libxl__device_kind kind; >=20 > diskinfo->backend =3D NULL; >=20 > diskinfo->devid =3D libxl__device_disk_dev_number(disk->vdev, NULL, = NULL); >=20 > - /* tap devices entries in xenstore are written as vbd devices. */ > + /* tap devices entries in xenstore are written as vbd/virtio_disk de= vices. > */ > + kind =3D disk->backend =3D=3D LIBXL_DISK_BACKEND_STANDALONE ? > + LIBXL__DEVICE_KIND_VIRTIO_DISK : LIBXL__DEVICE_KIND_VBD; > fe_path =3D libxl__domain_device_frontend_path(gc, domid, diskinfo- > >devid, > - LIBXL__DEVICE_KIND_VBD)= ; > + kind); > libxl_path =3D libxl__domain_device_libxl_path(gc, domid, diskinfo->= devid, > - LIBXL__DEVICE_KIND_VBD)= ; > + kind); > diskinfo->backend =3D xs_read(ctx->xsh, XBT_NULL, > GCSPRINTF("%s/backend", libxl_path), NUL= L); > if (!diskinfo->backend) { > @@ -1421,6 +1552,7 @@ LIBXL_DEFINE_DEVICE_LIST(disk) > #define libxl__device_disk_update_devid NULL >=20 > DEFINE_DEVICE_TYPE_STRUCT(disk, VBD, disks, > + .get_path =3D libxl__device_disk_get_path, > .merge =3D libxl_device_disk_merge, > .dm_needed =3D libxl_device_disk_dm_needed, > .from_xenstore =3D (device_from_xenstore_fn_t)libxl__disk_from_xenst= ore, > diff --git a/tools/libs/light/libxl_internal.h b/tools/libs/light/libxl_i= nternal.h > index bdef5a605e..cb9e8b3b8b 100644 > --- a/tools/libs/light/libxl_internal.h > +++ b/tools/libs/light/libxl_internal.h > @@ -1493,6 +1493,8 @@ _hidden char * > libxl__domain_pvcontrol_read(libxl__gc *gc, >=20 > /* from xl_device */ > _hidden char *libxl__device_disk_string_of_backend(libxl_disk_backend > backend); > +_hidden char > *libxl__device_disk_string_of_specification(libxl_disk_specification > specification); > +_hidden char *libxl__device_disk_string_of_transport(libxl_disk_transpor= t > transport); > _hidden char *libxl__device_disk_string_of_format(libxl_disk_format > format); > _hidden const char *libxl__qemu_disk_format_string(libxl_disk_format > format); > _hidden int libxl__device_disk_set_backend(libxl__gc*, libxl_device_disk= *); > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_ty= pes.idl > index f3ceb38c9e..d634f304cd 100644 > --- a/tools/libs/light/libxl_types.idl > +++ b/tools/libs/light/libxl_types.idl > @@ -130,6 +130,18 @@ libxl_disk_backend =3D Enumeration("disk_backend", > [ > (1, "PHY"), > (2, "TAP"), > (3, "QDISK"), > + (4, "STANDALONE"), # Only relying on the Xenstore data > + ]) > + > +libxl_disk_specification =3D Enumeration("disk_specification", [ > + (0, "UNKNOWN"), > + (1, "XEN"), > + (2, "VIRTIO"), > + ]) > + > +libxl_disk_transport =3D Enumeration("disk_transport", [ > + (0, "UNKNOWN"), > + (1, "MMIO"), > ]) >=20 > libxl_nic_type =3D Enumeration("nic_type", [ > @@ -706,6 +718,12 @@ libxl_device_disk =3D Struct("device_disk", [ > ("is_cdrom", integer), > ("direct_io_safe", bool), > ("discard_enable", libxl_defbool), > + ("specification", libxl_disk_specification), > + ("transport", libxl_disk_transport), > + # Note that virtio-mmio parameters (irq and base) are for internal u= se > + # by libxl and can't be modified. > + ("irq", uint32), > + ("base", uint64), > # Note that the COLO configuration settings should be considered uns= table. > # They may change incompatibly in future versions of Xen. > ("colo_enable", libxl_defbool), > diff --git a/tools/libs/light/libxl_types_internal.idl > b/tools/libs/light/libxl_types_internal.idl > index 3593e21dbb..8f71980aec 100644 > --- a/tools/libs/light/libxl_types_internal.idl > +++ b/tools/libs/light/libxl_types_internal.idl > @@ -32,6 +32,7 @@ libxl__device_kind =3D Enumeration("device_kind", [ > (14, "PVCALLS"), > (15, "VSND"), > (16, "VINPUT"), > + (17, "VIRTIO_DISK"), > ]) >=20 > libxl__console_backend =3D Enumeration("console_backend", [ > diff --git a/tools/libs/light/libxl_utils.c b/tools/libs/light/libxl_util= s.c > index e5e6b2da96..e403bd9bcf 100644 > --- a/tools/libs/light/libxl_utils.c > +++ b/tools/libs/light/libxl_utils.c > @@ -297,6 +297,8 @@ int libxl_string_to_backend(libxl_ctx *ctx, char *s, > libxl_disk_backend *backend > *backend =3D LIBXL_DISK_BACKEND_TAP; > } else if (!strcmp(s, "qdisk")) { > *backend =3D LIBXL_DISK_BACKEND_QDISK; > + } else if (!strcmp(s, "standalone")) { > + *backend =3D LIBXL_DISK_BACKEND_STANDALONE; > } else if (!strcmp(s, "tap")) { > p =3D strchr(s, ':'); > if (!p) { > diff --git a/tools/libs/util/libxlu_disk_l.c b/tools/libs/util/libxlu_dis= k_l.c > index 32d4b74b58..0b59723b71 100644 > --- a/tools/libs/util/libxlu_disk_l.c > +++ b/tools/libs/util/libxlu_disk_l.c > @@ -549,8 +549,8 @@ static void yynoreturn yy_fatal_error ( const char* > msg , yyscan_t yyscanner ); > yyg->yy_hold_char =3D *yy_cp; \ > *yy_cp =3D '\0'; \ > yyg->yy_c_buf_p =3D yy_cp; > -#define YY_NUM_RULES 36 > -#define YY_END_OF_BUFFER 37 > +#define YY_NUM_RULES 37 > +#define YY_END_OF_BUFFER 38 > /* This struct is not used in this scanner, > but its presence is necessary. */ > struct yy_trans_info > @@ -558,74 +558,77 @@ struct yy_trans_info > flex_int32_t yy_verify; > flex_int32_t yy_nxt; > }; > -static const flex_int16_t yy_acclist[575] =3D > +static const flex_int16_t yy_acclist[594] =3D > { 0, > - 35, 35, 37, 33, 34, 36, 8193, 33, 34, 36, > - 16385, 8193, 33, 36,16385, 33, 34, 36, 34, 36, > - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, > - 34, 36, 33, 34, 36, 33, 34, 36, 33, 34, > - 36, 33, 34, 36, 33, 34, 36, 33, 34, 36, > - 33, 34, 36, 33, 34, 36, 33, 34, 36, 33, > - 34, 36, 33, 34, 36, 33, 34, 36, 35, 36, > - 36, 33, 33, 8193, 33, 8193, 33,16385, 8193, 33, > - 8193, 33, 33, 8224, 33,16416, 33, 33, 33, 33, > - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, > - > - 33, 33, 33, 33, 33, 33, 33, 33, 33, 35, > - 8193, 33, 8193, 33, 8193, 8224, 33, 8224, 33, 8224, > - 23, 33, 33, 33, 33, 33, 33, 33, 33, 33, > - 33, 33, 33, 33, 33, 33, 33, 33, 33, 33, > - 33, 33, 33, 33, 33, 8224, 33, 8224, 33, 8224, > - 23, 33, 33, 28, 8224, 33,16416, 33, 33, 15, > - 33, 33, 33, 33, 33, 33, 33, 33, 33, 8217, > - 8224, 33,16409,16416, 33, 33, 31, 8224, 33,16416, > - 33, 8216, 8224, 33,16408,16416, 33, 33, 8219, 8224, > - 33,16411,16416, 33, 33, 33, 33, 33, 28, 8224, > - > - 33, 28, 8224, 33, 28, 33, 28, 8224, 33, 3, > - 33, 15, 33, 33, 33, 33, 33, 30, 8224, 33, > - 16416, 33, 33, 33, 8217, 8224, 33, 8217, 8224, 33, > - 8217, 33, 8217, 8224, 33, 33, 31, 8224, 33, 31, > - 8224, 33, 31, 33, 31, 8224, 8216, 8224, 33, 8216, > - 8224, 33, 8216, 33, 8216, 8224, 33, 8219, 8224, 33, > - 8219, 8224, 33, 8219, 33, 8219, 8224, 33, 33, 10, > - 33, 33, 28, 8224, 33, 28, 8224, 33, 28, 8224, > - 28, 33, 28, 33, 3, 33, 33, 33, 33, 33, > - 33, 33, 30, 8224, 33, 30, 8224, 33, 30, 33, > - > - 30, 8224, 33, 33, 29, 8224, 33,16416, 8217, 8224, > - 33, 8217, 8224, 33, 8217, 8224, 8217, 33, 8217, 33, > - 33, 31, 8224, 33, 31, 8224, 33, 31, 8224, 31, > - 33, 31, 8216, 8224, 33, 8216, 8224, 33, 8216, 8224, > - 8216, 33, 8216, 33, 8219, 8224, 33, 8219, 8224, 33, > - 8219, 8224, 8219, 33, 8219, 33, 33, 10, 23, 10, > - 7, 33, 33, 33, 33, 33, 33, 33, 13, 33, > - 30, 8224, 33, 30, 8224, 33, 30, 8224, 30, 33, > - 30, 2, 33, 29, 8224, 33, 29, 8224, 33, 29, > - 33, 29, 8224, 16, 33, 33, 11, 33, 22, 10, > - > - 10, 23, 7, 23, 7, 33, 8, 33, 33, 33, > - 33, 6, 33, 13, 33, 2, 23, 2, 33, 29, > - 8224, 33, 29, 8224, 33, 29, 8224, 29, 33, 29, > - 16, 33, 33, 11, 23, 11, 26, 8224, 33,16416, > - 22, 23, 22, 7, 7, 23, 33, 8, 23, 8, > - 33, 33, 33, 33, 6, 23, 6, 6, 23, 6, > - 23, 33, 2, 2, 23, 33, 33, 11, 11, 23, > - 26, 8224, 33, 26, 8224, 33, 26, 33, 26, 8224, > - 22, 23, 33, 8, 8, 23, 33, 33, 17, 18, > - 6, 6, 23, 6, 6, 33, 33, 14, 33, 26, > - > - 8224, 33, 26, 8224, 33, 26, 8224, 26, 33, 26, > - 33, 33, 33, 17, 23, 17, 18, 23, 18, 6, > - 6, 33, 33, 14, 33, 20, 9, 19, 17, 17, > - 23, 18, 18, 23, 6, 5, 6, 33, 21, 20, > - 23, 20, 9, 23, 9, 19, 23, 19, 4, 6, > - 5, 6, 33, 21, 23, 21, 20, 20, 23, 9, > - 9, 23, 19, 19, 23, 4, 6, 12, 33, 21, > - 21, 23, 12, 33 > + 36, 36, 38, 34, 35, 37, 8193, 34, 35, 37, > + 16385, 8193, 34, 37,16385, 34, 35, 37, 35, 37, > + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, > + 35, 37, 34, 35, 37, 34, 35, 37, 34, 35, > + 37, 34, 35, 37, 34, 35, 37, 34, 35, 37, > + 34, 35, 37, 34, 35, 37, 34, 35, 37, 34, > + 35, 37, 34, 35, 37, 34, 35, 37, 36, 37, > + 37, 34, 34, 8193, 34, 8193, 34,16385, 8193, 34, > + 8193, 34, 34, 8225, 34,16417, 34, 34, 34, 34, > + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, > + > + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, > + 36, 8193, 34, 8193, 34, 8193, 8225, 34, 8225, 34, > + 8225, 24, 34, 34, 34, 34, 34, 34, 34, 34, > + 34, 34, 34, 34, 34, 34, 34, 34, 34, 34, > + 34, 34, 34, 34, 34, 34, 34, 8225, 34, 8225, > + 34, 8225, 24, 34, 34, 29, 8225, 34,16417, 34, > + 34, 16, 34, 34, 34, 34, 34, 34, 34, 34, > + 34, 8218, 8225, 34,16410,16417, 34, 34, 32, 8225, > + 34,16417, 34, 8217, 8225, 34,16409,16417, 34, 34, > + 34, 8220, 8225, 34,16412,16417, 34, 34, 34, 34, > + > + 34, 29, 8225, 34, 29, 8225, 34, 29, 34, 29, > + 8225, 34, 3, 34, 16, 34, 34, 34, 34, 34, > + 31, 8225, 34,16417, 34, 34, 34, 8218, 8225, 34, > + 8218, 8225, 34, 8218, 34, 8218, 8225, 34, 34, 32, > + 8225, 34, 32, 8225, 34, 32, 34, 32, 8225, 8217, > + 8225, 34, 8217, 8225, 34, 8217, 34, 8217, 8225, 34, > + 34, 8220, 8225, 34, 8220, 8225, 34, 8220, 34, 8220, > + 8225, 34, 34, 11, 34, 34, 29, 8225, 34, 29, > + 8225, 34, 29, 8225, 29, 34, 29, 34, 3, 34, > + 34, 34, 34, 34, 34, 34, 31, 8225, 34, 31, > + > + 8225, 34, 31, 34, 31, 8225, 34, 34, 30, 8225, > + 34,16417, 8218, 8225, 34, 8218, 8225, 34, 8218, 8225, > + 8218, 34, 8218, 34, 34, 32, 8225, 34, 32, 8225, > + 34, 32, 8225, 32, 34, 32, 8217, 8225, 34, 8217, > + 8225, 34, 8217, 8225, 8217, 34, 8217, 34, 34, 8220, > + 8225, 34, 8220, 8225, 34, 8220, 8225, 8220, 34, 8220, > + 34, 34, 11, 24, 11, 7, 34, 34, 34, 34, > + 34, 34, 34, 14, 34, 31, 8225, 34, 31, 8225, > + 34, 31, 8225, 31, 34, 31, 2, 34, 30, 8225, > + 34, 30, 8225, 34, 30, 34, 30, 8225, 17, 34, > + > + 34, 12, 34, 34, 23, 11, 11, 24, 7, 24, > + 7, 34, 8, 34, 34, 34, 34, 6, 34, 14, > + 34, 2, 24, 2, 34, 30, 8225, 34, 30, 8225, > + 34, 30, 8225, 30, 34, 30, 17, 34, 34, 12, > + 24, 12, 34, 27, 8225, 34,16417, 23, 24, 23, > + 7, 7, 24, 34, 8, 24, 8, 34, 34, 34, > + 34, 6, 24, 6, 6, 24, 6, 24, 34, 2, > + 2, 24, 34, 34, 12, 12, 24, 34, 27, 8225, > + 34, 27, 8225, 34, 27, 34, 27, 8225, 23, 24, > + 34, 8, 8, 24, 34, 34, 18, 19, 6, 6, > + > + 24, 6, 6, 34, 34, 15, 34, 34, 27, 8225, > + 34, 27, 8225, 34, 27, 8225, 27, 34, 27, 34, > + 34, 34, 18, 24, 18, 19, 24, 19, 6, 6, > + 34, 34, 15, 34, 34, 21, 9, 20, 18, 18, > + 24, 19, 19, 24, 6, 5, 6, 34, 22, 34, > + 21, 24, 21, 9, 24, 9, 20, 24, 20, 4, > + 6, 5, 6, 34, 22, 24, 22, 34, 21, 21, > + 24, 9, 9, 24, 20, 20, 24, 4, 6, 13, > + 34, 22, 22, 24, 10, 13, 34, 10, 24, 10, > + 10, 10, 24 > + > } ; >=20 > -static const flex_int16_t yy_accept[356] =3D > +static const flex_int16_t yy_accept[373] =3D > { 0, > 1, 1, 1, 2, 3, 4, 7, 12, 16, 19, > 21, 24, 27, 30, 33, 36, 39, 42, 45, 48, > @@ -633,39 +636,41 @@ static const flex_int16_t yy_accept[356] =3D > 74, 76, 79, 81, 82, 83, 84, 87, 87, 88, > 89, 90, 91, 92, 93, 94, 95, 96, 97, 98, > 99, 100, 101, 102, 103, 104, 105, 106, 107, 108, > - 109, 110, 111, 113, 115, 116, 118, 120, 121, 122, > + 109, 110, 111, 112, 114, 116, 117, 119, 121, 122, > 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, > 133, 134, 135, 136, 137, 138, 139, 140, 141, 142, > - 143, 144, 145, 146, 148, 150, 151, 152, 153, 154, > - > - 158, 159, 160, 162, 163, 164, 165, 166, 167, 168, > - 169, 170, 175, 176, 177, 181, 182, 187, 188, 189, > - 194, 195, 196, 197, 198, 199, 202, 205, 207, 209, > - 210, 212, 214, 215, 216, 217, 218, 222, 223, 224, > - 225, 228, 231, 233, 235, 236, 237, 240, 243, 245, > - 247, 250, 253, 255, 257, 258, 261, 264, 266, 268, > - 269, 270, 271, 272, 273, 276, 279, 281, 283, 284, > - 285, 287, 288, 289, 290, 291, 292, 293, 296, 299, > - 301, 303, 304, 305, 309, 312, 315, 317, 319, 320, > - 321, 322, 325, 328, 330, 332, 333, 336, 339, 341, > - > - 343, 344, 345, 348, 351, 353, 355, 356, 357, 358, > - 360, 361, 362, 363, 364, 365, 366, 367, 368, 369, > - 371, 374, 377, 379, 381, 382, 383, 384, 387, 390, > - 392, 394, 396, 397, 398, 399, 400, 401, 403, 405, > - 406, 407, 408, 409, 410, 411, 412, 413, 414, 416, > - 418, 419, 420, 423, 426, 428, 430, 431, 433, 434, > - 436, 437, 441, 443, 444, 445, 447, 448, 450, 451, > - 452, 453, 454, 455, 457, 458, 460, 462, 463, 464, > - 466, 467, 468, 469, 471, 474, 477, 479, 481, 483, > - 484, 485, 487, 488, 489, 490, 491, 492, 494, 495, > - > - 496, 497, 498, 500, 503, 506, 508, 510, 511, 512, > - 513, 514, 516, 517, 519, 520, 521, 522, 523, 524, > - 526, 527, 528, 529, 530, 532, 533, 535, 536, 538, > - 539, 540, 542, 543, 545, 546, 548, 549, 551, 553, > - 554, 556, 557, 558, 560, 561, 563, 564, 566, 568, > - 570, 571, 573, 575, 575 > + 143, 144, 145, 146, 147, 148, 150, 152, 153, 154, > + > + 155, 156, 160, 161, 162, 164, 165, 166, 167, 168, > + 169, 170, 171, 172, 177, 178, 179, 183, 184, 189, > + 190, 191, 192, 197, 198, 199, 200, 201, 202, 205, > + 208, 210, 212, 213, 215, 217, 218, 219, 220, 221, > + 225, 226, 227, 228, 231, 234, 236, 238, 239, 240, > + 243, 246, 248, 250, 253, 256, 258, 260, 261, 262, > + 265, 268, 270, 272, 273, 274, 275, 276, 277, 280, > + 283, 285, 287, 288, 289, 291, 292, 293, 294, 295, > + 296, 297, 300, 303, 305, 307, 308, 309, 313, 316, > + 319, 321, 323, 324, 325, 326, 329, 332, 334, 336, > + > + 337, 340, 343, 345, 347, 348, 349, 350, 353, 356, > + 358, 360, 361, 362, 363, 365, 366, 367, 368, 369, > + 370, 371, 372, 373, 374, 376, 379, 382, 384, 386, > + 387, 388, 389, 392, 395, 397, 399, 401, 402, 403, > + 404, 405, 406, 407, 409, 411, 412, 413, 414, 415, > + 416, 417, 418, 419, 420, 422, 424, 425, 426, 429, > + 432, 434, 436, 437, 439, 440, 442, 443, 444, 448, > + 450, 451, 452, 454, 455, 457, 458, 459, 460, 461, > + 462, 464, 465, 467, 469, 470, 471, 473, 474, 475, > + 476, 478, 479, 482, 485, 487, 489, 491, 492, 493, > + > + 495, 496, 497, 498, 499, 500, 502, 503, 504, 505, > + 506, 508, 509, 512, 515, 517, 519, 520, 521, 522, > + 523, 525, 526, 528, 529, 530, 531, 532, 533, 535, > + 536, 537, 538, 539, 540, 542, 543, 545, 546, 548, > + 549, 550, 551, 553, 554, 556, 557, 559, 560, 562, > + 564, 565, 567, 568, 569, 570, 572, 573, 575, 576, > + 578, 580, 582, 583, 585, 586, 588, 590, 591, 592, > + 594, 594 > } ; >=20 > static const YY_CHAR yy_ec[256] =3D > @@ -708,216 +713,224 @@ static const YY_CHAR yy_meta[35] =3D > 1, 1, 1, 1 > } ; >=20 > -static const flex_int16_t yy_base[424] =3D > +static const flex_int16_t yy_base[443] =3D > { 0, > - 0, 0, 901, 900, 902, 897, 33, 36, 905, 905, > - 45, 63, 31, 42, 51, 52, 890, 33, 65, 67, > - 69, 70, 889, 71, 888, 75, 0, 905, 893, 905, > - 91, 94, 0, 0, 103, 886, 112, 0, 89, 98, > - 113, 92, 114, 99, 100, 48, 121, 116, 119, 74, > - 124, 129, 123, 135, 132, 133, 137, 134, 138, 139, > - 141, 0, 155, 0, 0, 164, 0, 0, 849, 142, > - 152, 164, 140, 161, 165, 166, 167, 168, 169, 173, > - 174, 178, 176, 180, 184, 208, 189, 183, 192, 195, > - 215, 191, 193, 223, 0, 0, 905, 208, 204, 236, > - > - 219, 209, 238, 196, 237, 831, 242, 815, 241, 224, > - 243, 261, 244, 259, 277, 266, 286, 250, 288, 298, > - 249, 283, 274, 282, 294, 308, 0, 310, 0, 295, > - 305, 905, 308, 306, 313, 314, 342, 319, 316, 320, > - 331, 0, 349, 0, 342, 344, 356, 0, 358, 0, > - 365, 0, 367, 0, 354, 375, 0, 377, 0, 363, > - 356, 809, 327, 322, 384, 0, 0, 0, 0, 379, > - 905, 382, 384, 386, 390, 372, 392, 403, 0, 410, > - 0, 407, 413, 423, 426, 0, 0, 0, 0, 409, > - 424, 435, 0, 0, 0, 0, 437, 0, 0, 0, > - > - 0, 433, 444, 0, 0, 0, 0, 391, 440, 781, > - 905, 769, 439, 445, 444, 447, 449, 454, 453, 399, > - 464, 0, 0, 0, 0, 757, 465, 476, 0, 478, > - 0, 479, 476, 753, 462, 490, 749, 905, 745, 905, > - 483, 737, 424, 485, 487, 490, 500, 493, 905, 729, > - 905, 502, 518, 0, 0, 0, 0, 905, 498, 721, > - 905, 527, 713, 0, 705, 905, 495, 697, 905, 365, > - 521, 528, 530, 685, 905, 534, 540, 540, 657, 905, > - 537, 542, 650, 905, 553, 0, 557, 0, 0, 551, > - 641, 905, 558, 557, 633, 614, 613, 905, 547, 555, > - > - 563, 565, 569, 584, 0, 0, 0, 0, 583, 570, > - 585, 612, 905, 601, 905, 522, 580, 589, 594, 905, > - 600, 585, 563, 520, 905, 514, 905, 586, 486, 597, > - 480, 441, 905, 416, 905, 345, 905, 334, 905, 601, > - 254, 905, 242, 905, 200, 905, 151, 905, 905, 607, > - 86, 905, 905, 905, 620, 624, 627, 631, 635, 639, > - 643, 647, 651, 655, 659, 663, 667, 671, 675, 679, > - 683, 687, 691, 695, 699, 703, 707, 711, 715, 719, > - 723, 727, 731, 735, 739, 743, 747, 751, 755, 759, > - 763, 767, 771, 775, 779, 783, 787, 791, 795, 799, > - > - 803, 807, 811, 815, 819, 823, 827, 831, 835, 839, > - 843, 847, 851, 855, 859, 863, 867, 871, 875, 879, > - 883, 887, 891 > + 0, 0, 936, 935, 937, 932, 33, 36, 940, 940, > + 45, 63, 31, 42, 51, 52, 925, 33, 65, 67, > + 69, 70, 924, 71, 923, 75, 0, 940, 928, 940, > + 91, 95, 0, 0, 104, 921, 113, 0, 91, 99, > + 114, 92, 115, 80, 100, 48, 119, 121, 122, 74, > + 123, 128, 131, 129, 125, 133, 135, 136, 137, 143, > + 138, 145, 0, 157, 0, 0, 168, 0, 0, 926, > + 140, 146, 165, 159, 152, 164, 155, 168, 171, 176, > + 177, 170, 180, 175, 184, 188, 212, 191, 185, 192, > + 193, 194, 219, 212, 199, 230, 0, 0, 940, 195, > + > + 200, 239, 235, 197, 246, 225, 226, 919, 244, 918, > + 243, 236, 245, 266, 248, 264, 282, 271, 291, 248, > + 270, 254, 300, 279, 296, 302, 288, 303, 311, 0, > + 315, 0, 311, 318, 940, 313, 319, 208, 313, 344, > + 321, 331, 325, 333, 0, 352, 0, 345, 347, 359, > + 0, 361, 0, 368, 0, 370, 0, 322, 366, 379, > + 0, 381, 0, 359, 357, 923, 382, 384, 392, 0, > + 0, 0, 0, 387, 940, 386, 390, 392, 329, 401, > + 397, 409, 0, 417, 0, 399, 412, 426, 429, 0, > + 0, 0, 0, 412, 427, 438, 0, 0, 0, 0, > + > + 440, 0, 0, 0, 0, 436, 405, 447, 0, 0, > + 0, 0, 438, 443, 922, 940, 921, 442, 450, 449, > + 452, 454, 459, 458, 453, 469, 0, 0, 0, 0, > + 920, 470, 481, 0, 483, 0, 484, 481, 919, 368, > + 467, 495, 918, 940, 917, 940, 488, 916, 479, 490, > + 492, 495, 505, 498, 940, 915, 940, 507, 523, 0, > + 0, 0, 0, 940, 503, 864, 940, 846, 532, 836, > + 0, 824, 940, 516, 796, 940, 513, 530, 536, 538, > + 784, 940, 542, 535, 547, 772, 940, 549, 551, 768, > + 940, 502, 562, 0, 564, 0, 0, 562, 764, 940, > + > + 544, 557, 760, 752, 744, 940, 552, 568, 571, 568, > + 581, 577, 588, 0, 0, 0, 0, 589, 580, 591, > + 736, 940, 728, 940, 601, 602, 597, 599, 940, 603, > + 720, 712, 700, 672, 940, 665, 940, 610, 656, 603, > + 648, 607, 629, 940, 627, 940, 625, 940, 624, 940, > + 607, 574, 940, 614, 572, 940, 491, 940, 433, 940, > + 940, 622, 389, 940, 303, 940, 261, 940, 204, 940, > + 940, 635, 639, 642, 646, 650, 654, 658, 662, 666, > + 670, 674, 678, 682, 686, 690, 694, 698, 702, 706, > + 710, 714, 718, 722, 726, 730, 734, 738, 742, 746, > + > + 750, 754, 758, 762, 766, 770, 774, 778, 782, 786, > + 790, 794, 798, 802, 806, 810, 814, 818, 822, 826, > + 830, 834, 838, 842, 846, 850, 854, 858, 862, 866, > + 870, 874, 878, 882, 886, 890, 894, 898, 902, 906, > + 910, 914 > } ; >=20 > -static const flex_int16_t yy_def[424] =3D > +static const flex_int16_t yy_def[443] =3D > { 0, > - 354, 1, 355, 355, 354, 356, 357, 357, 354, 354, > - 358, 358, 12, 12, 12, 12, 12, 12, 12, 12, > - 12, 12, 12, 12, 12, 12, 359, 354, 356, 354, > - 360, 357, 361, 361, 362, 12, 356, 363, 12, 12, > - 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, > + 371, 1, 372, 372, 371, 373, 374, 374, 371, 371, > + 375, 375, 12, 12, 12, 12, 12, 12, 12, 12, > + 12, 12, 12, 12, 12, 12, 376, 371, 373, 371, > + 377, 374, 378, 378, 379, 12, 373, 380, 12, 12, > 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, > - 12, 359, 360, 361, 361, 364, 365, 365, 354, 12, > 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, > - 12, 12, 12, 12, 12, 362, 12, 12, 12, 12, > - 12, 12, 12, 364, 365, 365, 354, 12, 12, 366, > - > + 12, 12, 376, 377, 378, 378, 381, 382, 382, 371, > 12, 12, 12, 12, 12, 12, 12, 12, 12, 12, > - 12, 367, 86, 86, 368, 12, 369, 12, 12, 370, > - 12, 12, 12, 12, 12, 371, 372, 366, 372, 12, > - 12, 354, 86, 12, 12, 12, 373, 12, 12, 12, > - 374, 375, 367, 375, 86, 86, 376, 377, 368, 377, > - 378, 379, 369, 379, 12, 380, 381, 370, 381, 12, > - 12, 382, 12, 12, 371, 372, 372, 383, 383, 12, > - 354, 86, 86, 86, 12, 12, 12, 384, 385, 373, > - 385, 12, 12, 386, 374, 375, 375, 387, 387, 86, > - 86, 376, 377, 377, 388, 388, 378, 379, 379, 389, > - > - 389, 12, 380, 381, 381, 390, 390, 12, 12, 391, > - 354, 392, 86, 12, 86, 86, 86, 12, 86, 12, > - 384, 385, 385, 393, 393, 394, 86, 395, 396, 386, > - 396, 86, 86, 397, 12, 398, 391, 354, 399, 354, > - 86, 400, 12, 86, 86, 86, 401, 86, 354, 402, > - 354, 86, 395, 396, 396, 403, 403, 354, 86, 404, > - 354, 405, 406, 406, 399, 354, 86, 407, 354, 12, > - 86, 86, 86, 408, 354, 408, 408, 86, 402, 354, > - 86, 86, 404, 354, 409, 410, 405, 410, 406, 86, > - 407, 354, 12, 86, 411, 412, 408, 354, 408, 408, > - > - 86, 86, 86, 409, 410, 410, 413, 413, 86, 12, > - 86, 414, 354, 415, 354, 408, 408, 86, 86, 354, > - 416, 417, 418, 414, 354, 415, 354, 408, 408, 86, > - 419, 420, 354, 421, 354, 422, 354, 408, 354, 86, > - 423, 354, 420, 354, 421, 354, 422, 354, 354, 86, > - 423, 354, 354, 0, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354 > + 12, 12, 12, 12, 12, 12, 379, 12, 12, 12, > + 12, 12, 12, 12, 12, 381, 382, 382, 371, 12, > + > + 12, 383, 12, 12, 12, 12, 12, 12, 12, 12, > + 12, 12, 12, 384, 87, 87, 385, 12, 386, 12, > + 12, 12, 387, 12, 12, 12, 12, 12, 388, 389, > + 383, 389, 12, 12, 371, 87, 12, 12, 12, 390, > + 12, 12, 12, 391, 392, 384, 392, 87, 87, 393, > + 394, 385, 394, 395, 396, 386, 396, 12, 12, 397, > + 398, 387, 398, 12, 12, 399, 12, 12, 388, 389, > + 389, 400, 400, 12, 371, 87, 87, 87, 12, 12, > + 12, 401, 402, 390, 402, 12, 12, 403, 391, 392, > + 392, 404, 404, 87, 87, 393, 394, 394, 405, 405, > + > + 395, 396, 396, 406, 406, 12, 12, 397, 398, 398, > + 407, 407, 12, 12, 408, 371, 409, 87, 12, 87, > + 87, 87, 12, 87, 12, 401, 402, 402, 410, 410, > + 411, 87, 412, 413, 403, 413, 87, 87, 414, 12, > + 12, 415, 408, 371, 416, 371, 87, 417, 12, 87, > + 87, 87, 418, 87, 371, 419, 371, 87, 412, 413, > + 413, 420, 420, 371, 87, 421, 371, 12, 422, 423, > + 423, 416, 371, 87, 424, 371, 12, 87, 87, 87, > + 425, 371, 425, 425, 87, 419, 371, 87, 87, 421, > + 371, 12, 426, 427, 422, 427, 423, 87, 424, 371, > + > + 12, 87, 428, 429, 425, 371, 425, 425, 87, 87, > + 87, 12, 426, 427, 427, 430, 430, 87, 12, 87, > + 431, 371, 432, 371, 425, 425, 87, 87, 371, 12, > + 433, 434, 435, 431, 371, 432, 371, 425, 425, 87, > + 436, 12, 437, 371, 438, 371, 439, 371, 425, 371, > + 87, 440, 371, 12, 437, 371, 438, 371, 439, 371, > + 371, 87, 440, 371, 441, 371, 442, 371, 442, 371, > + 0, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371 > } ; >=20 > -static const flex_int16_t yy_nxt[940] =3D > +static const flex_int16_t yy_nxt[975] =3D > { 0, > 6, 7, 8, 9, 6, 6, 6, 6, 10, 11, > 12, 13, 14, 15, 16, 17, 18, 19, 17, 17, > 17, 17, 20, 17, 21, 22, 23, 24, 25, 17, > 26, 17, 17, 17, 32, 32, 33, 32, 32, 33, > 36, 34, 36, 42, 34, 29, 29, 29, 30, 35, > - 50, 36, 37, 38, 43, 44, 39, 36, 79, 45, > + 50, 36, 37, 38, 43, 44, 39, 36, 80, 45, > 36, 36, 40, 29, 29, 29, 30, 35, 46, 48, > 37, 38, 41, 47, 36, 49, 36, 53, 36, 36, > - 36, 56, 58, 36, 36, 55, 82, 60, 51, 342, > - 54, 61, 52, 29, 64, 32, 32, 33, 36, 65, > - > - 70, 36, 34, 29, 29, 29, 30, 36, 36, 36, > - 29, 38, 66, 66, 66, 67, 66, 71, 74, 66, > - 68, 72, 36, 36, 73, 36, 77, 78, 36, 76, > - 36, 53, 36, 36, 75, 85, 80, 83, 36, 86, > - 84, 36, 36, 36, 36, 81, 36, 36, 36, 36, > - 36, 36, 93, 89, 337, 98, 88, 29, 64, 101, > - 90, 36, 91, 65, 92, 87, 29, 95, 89, 99, > - 36, 100, 96, 36, 36, 36, 36, 36, 36, 106, > - 105, 85, 36, 36, 102, 36, 107, 36, 103, 36, > - 109, 112, 36, 36, 104, 108, 115, 110, 36, 117, > - > - 36, 36, 36, 335, 36, 36, 122, 111, 29, 29, > - 29, 30, 118, 36, 116, 29, 38, 36, 36, 113, > - 114, 119, 120, 123, 36, 29, 95, 121, 36, 134, > - 131, 96, 130, 36, 125, 124, 126, 126, 66, 127, > - 126, 132, 133, 126, 129, 333, 36, 36, 135, 137, > - 36, 36, 36, 140, 139, 35, 35, 352, 36, 36, > - 85, 141, 141, 66, 142, 141, 160, 145, 141, 144, > - 35, 35, 89, 117, 155, 36, 146, 147, 147, 66, > - 148, 147, 162, 36, 147, 150, 151, 151, 66, 152, > - 151, 36, 36, 151, 154, 120, 161, 36, 156, 156, > - > - 66, 157, 156, 36, 36, 156, 159, 164, 171, 163, > - 29, 166, 29, 168, 36, 36, 167, 170, 169, 35, > - 35, 172, 36, 36, 173, 36, 213, 184, 36, 36, > - 175, 36, 174, 29, 186, 212, 36, 349, 183, 187, > - 177, 176, 178, 178, 66, 179, 178, 182, 348, 178, > - 181, 29, 188, 35, 35, 35, 35, 189, 29, 193, > - 29, 195, 190, 36, 194, 36, 196, 29, 198, 29, > - 200, 191, 36, 199, 36, 201, 219, 29, 204, 29, > - 206, 36, 202, 205, 209, 207, 29, 166, 36, 293, > - 208, 214, 167, 35, 35, 35, 35, 35, 35, 36, > - > - 36, 36, 249, 218, 220, 29, 222, 216, 36, 217, > - 235, 223, 29, 224, 215, 226, 36, 227, 225, 346, > - 35, 35, 36, 228, 228, 66, 229, 228, 29, 186, > - 228, 231, 232, 36, 187, 233, 35, 29, 193, 29, > - 198, 234, 36, 194, 344, 199, 29, 204, 236, 36, > - 35, 241, 205, 242, 36, 35, 35, 270, 35, 35, > - 35, 35, 247, 36, 35, 35, 29, 222, 244, 262, > - 248, 36, 223, 243, 245, 246, 35, 252, 29, 254, > - 29, 256, 258, 342, 255, 259, 257, 35, 35, 339, > - 35, 35, 69, 264, 35, 35, 35, 35, 35, 35, > - > - 267, 35, 35, 275, 35, 35, 35, 35, 271, 35, > - 35, 276, 277, 35, 35, 272, 278, 315, 273, 281, > - 29, 254, 290, 313, 282, 275, 255, 285, 285, 66, > - 286, 285, 35, 35, 285, 288, 295, 298, 296, 35, > - 35, 35, 35, 298, 301, 328, 299, 294, 35, 35, > - 275, 35, 35, 35, 303, 29, 305, 300, 275, 29, > - 307, 306, 35, 35, 302, 308, 337, 36, 35, 35, > - 309, 310, 320, 316, 35, 35, 35, 35, 322, 36, > - 35, 35, 317, 275, 319, 311, 29, 305, 335, 275, > - 318, 321, 306, 323, 35, 35, 35, 35, 330, 329, > - > - 35, 35, 331, 333, 327, 35, 35, 338, 35, 35, > - 353, 340, 35, 35, 350, 325, 275, 315, 35, 35, > - 27, 27, 27, 27, 29, 29, 29, 31, 31, 31, > - 31, 36, 36, 36, 36, 62, 313, 62, 62, 63, > - 63, 63, 63, 65, 269, 65, 65, 35, 35, 35, > - 35, 69, 69, 261, 69, 94, 94, 94, 94, 96, > - 251, 96, 96, 128, 128, 128, 128, 143, 143, 143, > - 143, 149, 149, 149, 149, 153, 153, 153, 153, 158, > - 158, 158, 158, 165, 165, 165, 165, 167, 298, 167, > - 167, 180, 180, 180, 180, 185, 185, 185, 185, 187, > - > - 292, 187, 187, 192, 192, 192, 192, 194, 240, 194, > - 194, 197, 197, 197, 197, 199, 289, 199, 199, 203, > - 203, 203, 203, 205, 284, 205, 205, 210, 210, 210, > - 210, 169, 280, 169, 169, 221, 221, 221, 221, 223, > - 269, 223, 223, 230, 230, 230, 230, 189, 266, 189, > - 189, 196, 211, 196, 196, 201, 261, 201, 201, 207, > - 251, 207, 207, 237, 237, 237, 237, 239, 239, 239, > - 239, 225, 240, 225, 225, 250, 250, 250, 250, 253, > - 253, 253, 253, 255, 238, 255, 255, 260, 260, 260, > - 260, 263, 263, 263, 263, 265, 265, 265, 265, 268, > - > - 268, 268, 268, 274, 274, 274, 274, 279, 279, 279, > - 279, 257, 211, 257, 257, 283, 283, 283, 283, 287, > - 287, 287, 287, 264, 138, 264, 264, 291, 291, 291, > - 291, 297, 297, 297, 297, 304, 304, 304, 304, 306, > - 136, 306, 306, 312, 312, 312, 312, 314, 314, 314, > - 314, 308, 97, 308, 308, 324, 324, 324, 324, 326, > - 326, 326, 326, 332, 332, 332, 332, 334, 334, 334, > - 334, 336, 336, 336, 336, 341, 341, 341, 341, 343, > - 343, 343, 343, 345, 345, 345, 345, 347, 347, 347, > - 347, 351, 351, 351, 351, 36, 30, 59, 57, 36, > - > - 30, 354, 28, 28, 5, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354 > + 36, 56, 58, 36, 36, 55, 83, 61, 51, 36, > + 54, 62, 52, 29, 65, 59, 32, 32, 33, 66, > + > + 36, 36, 71, 34, 29, 29, 29, 30, 36, 36, > + 77, 29, 38, 67, 67, 67, 68, 67, 75, 72, > + 67, 69, 73, 36, 36, 74, 78, 79, 36, 53, > + 36, 36, 36, 87, 36, 76, 84, 36, 36, 85, > + 36, 81, 36, 86, 36, 36, 36, 36, 82, 36, > + 92, 95, 36, 100, 36, 36, 89, 90, 88, 29, > + 65, 36, 91, 101, 36, 66, 90, 93, 36, 94, > + 29, 97, 102, 36, 36, 104, 98, 36, 103, 36, > + 36, 107, 108, 106, 36, 36, 36, 105, 86, 36, > + 109, 110, 111, 36, 36, 114, 112, 36, 117, 119, > + > + 36, 36, 36, 36, 36, 121, 36, 368, 36, 36, > + 120, 113, 29, 29, 29, 30, 118, 36, 134, 29, > + 38, 36, 127, 115, 116, 122, 123, 125, 36, 126, > + 128, 124, 29, 97, 36, 36, 180, 138, 98, 129, > + 129, 67, 130, 129, 36, 36, 129, 132, 133, 135, > + 136, 140, 36, 36, 36, 36, 142, 36, 137, 35, > + 35, 123, 86, 36, 370, 143, 144, 144, 67, 145, > + 144, 148, 158, 144, 147, 35, 35, 90, 119, 36, > + 36, 149, 150, 150, 67, 151, 150, 159, 36, 150, > + 153, 154, 154, 67, 155, 154, 164, 36, 154, 157, > + > + 160, 160, 67, 161, 160, 36, 368, 160, 163, 165, > + 166, 36, 36, 29, 170, 167, 168, 29, 172, 171, > + 36, 175, 36, 173, 35, 35, 176, 36, 36, 177, > + 36, 36, 188, 174, 36, 29, 190, 178, 36, 181, > + 36, 191, 223, 179, 182, 182, 67, 183, 182, 186, > + 206, 182, 185, 187, 29, 192, 35, 35, 35, 35, > + 193, 29, 197, 29, 199, 194, 36, 198, 36, 200, > + 29, 202, 29, 204, 195, 36, 203, 36, 205, 268, > + 207, 29, 209, 29, 211, 214, 213, 210, 218, 212, > + 217, 36, 353, 36, 29, 170, 36, 35, 35, 219, > + > + 171, 35, 35, 35, 35, 224, 36, 231, 36, 225, > + 36, 29, 227, 221, 36, 222, 232, 228, 220, 29, > + 229, 36, 240, 35, 35, 230, 233, 233, 67, 234, > + 233, 29, 190, 233, 236, 237, 348, 191, 238, 35, > + 29, 197, 29, 202, 239, 36, 198, 36, 203, 29, > + 209, 242, 36, 35, 247, 210, 255, 241, 248, 36, > + 35, 35, 36, 35, 35, 35, 35, 253, 36, 35, > + 35, 29, 227, 250, 269, 254, 36, 228, 249, 251, > + 252, 35, 258, 29, 260, 29, 262, 264, 36, 261, > + 265, 263, 35, 35, 346, 35, 35, 70, 271, 35, > + > + 35, 35, 35, 35, 35, 274, 35, 35, 282, 35, > + 35, 36, 277, 278, 35, 35, 283, 284, 35, 35, > + 279, 285, 36, 280, 288, 29, 260, 35, 35, 289, > + 312, 261, 293, 293, 67, 294, 293, 301, 306, 293, > + 296, 35, 35, 298, 303, 306, 304, 35, 35, 35, > + 35, 309, 308, 36, 307, 282, 302, 319, 35, 35, > + 35, 35, 35, 311, 29, 314, 29, 316, 35, 35, > + 315, 282, 317, 35, 35, 344, 310, 364, 325, 35, > + 35, 318, 35, 35, 329, 320, 36, 328, 332, 36, > + 29, 314, 35, 35, 330, 326, 315, 331, 327, 333, > + > + 35, 35, 35, 35, 282, 282, 340, 341, 35, 35, > + 35, 35, 36, 282, 35, 35, 36, 351, 35, 35, > + 362, 339, 365, 36, 338, 366, 342, 361, 360, 354, > + 358, 349, 356, 35, 35, 27, 27, 27, 27, 29, > + 29, 29, 31, 31, 31, 31, 36, 36, 36, 36, > + 63, 353, 63, 63, 64, 64, 64, 64, 66, 350, > + 66, 66, 35, 35, 35, 35, 70, 70, 324, 70, > + 96, 96, 96, 96, 98, 322, 98, 98, 131, 131, > + 131, 131, 146, 146, 146, 146, 152, 152, 152, 152, > + 156, 156, 156, 156, 162, 162, 162, 162, 169, 169, > + > + 169, 169, 171, 348, 171, 171, 184, 184, 184, 184, > + 189, 189, 189, 189, 191, 346, 191, 191, 196, 196, > + 196, 196, 198, 344, 198, 198, 201, 201, 201, 201, > + 203, 337, 203, 203, 208, 208, 208, 208, 210, 335, > + 210, 210, 215, 215, 215, 215, 173, 282, 173, 173, > + 226, 226, 226, 226, 228, 324, 228, 228, 235, 235, > + 235, 235, 193, 322, 193, 193, 200, 276, 200, 200, > + 205, 267, 205, 205, 212, 257, 212, 212, 243, 243, > + 243, 243, 245, 245, 245, 245, 230, 306, 230, 230, > + 256, 256, 256, 256, 259, 259, 259, 259, 261, 300, > + > + 261, 261, 266, 266, 266, 266, 270, 270, 270, 270, > + 272, 272, 272, 272, 275, 275, 275, 275, 281, 281, > + 281, 281, 286, 286, 286, 286, 263, 246, 263, 263, > + 290, 290, 290, 290, 295, 295, 295, 295, 271, 297, > + 271, 271, 299, 299, 299, 299, 305, 305, 305, 305, > + 313, 313, 313, 313, 315, 292, 315, 315, 321, 321, > + 321, 321, 323, 323, 323, 323, 317, 291, 317, 317, > + 334, 334, 334, 334, 336, 336, 336, 336, 343, 343, > + 343, 343, 345, 345, 345, 345, 347, 347, 347, 347, > + 352, 352, 352, 352, 355, 355, 355, 355, 357, 357, > + > + 357, 357, 359, 359, 359, 359, 363, 363, 363, 363, > + 367, 367, 367, 367, 369, 369, 369, 369, 287, 276, > + 273, 216, 267, 257, 246, 244, 216, 141, 139, 99, > + 36, 30, 60, 57, 36, 30, 371, 28, 28, 5, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371 > } ; >=20 > -static const flex_int16_t yy_chk[940] =3D > +static const flex_int16_t yy_chk[975] =3D > { 0, > 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, > @@ -927,101 +940,105 @@ static const flex_int16_t yy_chk[940] =3D > 18, 14, 11, 11, 13, 14, 11, 46, 46, 14, > 15, 16, 11, 12, 12, 12, 12, 12, 14, 16, > 12, 12, 12, 15, 19, 16, 20, 20, 21, 22, > - 24, 22, 24, 50, 26, 21, 50, 26, 19, 351, > - 20, 26, 19, 31, 31, 32, 32, 32, 39, 31, > - > - 39, 42, 32, 35, 35, 35, 35, 40, 44, 45, > - 35, 35, 37, 37, 37, 37, 37, 39, 42, 37, > - 37, 40, 41, 43, 41, 48, 45, 45, 49, 44, > - 47, 47, 53, 51, 43, 53, 48, 51, 52, 54, > - 52, 55, 56, 58, 54, 49, 57, 59, 60, 73, > - 61, 70, 60, 61, 347, 70, 56, 63, 63, 73, > - 58, 71, 59, 63, 59, 55, 66, 66, 57, 71, > - 74, 72, 66, 72, 75, 76, 77, 78, 79, 78, > - 77, 79, 80, 81, 74, 83, 80, 82, 75, 84, > - 82, 85, 88, 85, 76, 81, 87, 83, 87, 89, > - > - 92, 89, 93, 345, 90, 104, 92, 84, 86, 86, > - 86, 86, 90, 99, 88, 86, 86, 98, 102, 86, > - 86, 91, 91, 93, 91, 94, 94, 91, 101, 104, > - 102, 94, 101, 110, 99, 98, 100, 100, 100, 100, > - 100, 103, 103, 100, 100, 343, 105, 103, 105, 107, > - 109, 107, 111, 110, 109, 113, 113, 341, 121, 118, > - 111, 112, 112, 112, 112, 112, 121, 113, 112, 112, > - 114, 114, 116, 116, 118, 116, 114, 115, 115, 115, > - 115, 115, 123, 123, 115, 115, 117, 117, 117, 117, > - 117, 124, 122, 117, 117, 119, 122, 119, 120, 120, > - > - 120, 120, 120, 125, 130, 120, 120, 125, 131, 124, > - 126, 126, 128, 128, 131, 134, 126, 130, 128, 133, > - 133, 133, 135, 136, 133, 139, 164, 140, 138, 140, > - 134, 164, 133, 141, 141, 163, 163, 338, 139, 141, > - 136, 135, 137, 137, 137, 137, 137, 138, 336, 137, > - 137, 143, 143, 145, 145, 146, 146, 143, 147, 147, > - 149, 149, 145, 155, 147, 161, 149, 151, 151, 153, > - 153, 146, 160, 151, 270, 153, 176, 156, 156, 158, > - 158, 176, 155, 156, 161, 158, 165, 165, 170, 270, > - 160, 170, 165, 172, 172, 173, 173, 174, 174, 175, > - > - 208, 177, 220, 175, 177, 178, 178, 173, 220, 174, > - 208, 178, 180, 180, 172, 182, 182, 183, 180, 334, > - 190, 190, 183, 184, 184, 184, 184, 184, 185, 185, > - 184, 184, 190, 243, 185, 191, 191, 192, 192, 197, > - 197, 202, 202, 192, 332, 197, 203, 203, 209, 209, > - 213, 213, 203, 214, 214, 215, 215, 243, 216, 216, > - 217, 217, 218, 218, 219, 219, 221, 221, 215, 235, > - 219, 235, 221, 214, 216, 217, 227, 227, 228, 228, > - 230, 230, 232, 331, 228, 233, 230, 233, 233, 329, > - 232, 232, 236, 236, 241, 241, 244, 244, 245, 245, > - > - 241, 246, 246, 247, 248, 248, 267, 267, 244, 259, > - 259, 247, 247, 252, 252, 245, 248, 326, 246, 252, > - 253, 253, 267, 324, 259, 316, 253, 262, 262, 262, > - 262, 262, 271, 271, 262, 262, 272, 276, 273, 272, > - 272, 273, 273, 277, 278, 316, 276, 271, 281, 281, > - 299, 278, 278, 282, 282, 285, 285, 277, 300, 287, > - 287, 285, 290, 290, 281, 287, 323, 293, 294, 294, > - 290, 293, 303, 299, 301, 301, 302, 302, 310, 310, > - 303, 303, 300, 317, 302, 294, 304, 304, 322, 328, > - 301, 309, 304, 311, 309, 309, 311, 311, 318, 317, > - > - 318, 318, 319, 321, 314, 319, 319, 328, 330, 330, > - 350, 330, 340, 340, 340, 312, 297, 296, 350, 350, > - 355, 355, 355, 355, 356, 356, 356, 357, 357, 357, > - 357, 358, 358, 358, 358, 359, 295, 359, 359, 360, > - 360, 360, 360, 361, 291, 361, 361, 362, 362, 362, > - 362, 363, 363, 283, 363, 364, 364, 364, 364, 365, > - 279, 365, 365, 366, 366, 366, 366, 367, 367, 367, > - 367, 368, 368, 368, 368, 369, 369, 369, 369, 370, > - 370, 370, 370, 371, 371, 371, 371, 372, 274, 372, > - 372, 373, 373, 373, 373, 374, 374, 374, 374, 375, > - > - 268, 375, 375, 376, 376, 376, 376, 377, 265, 377, > - 377, 378, 378, 378, 378, 379, 263, 379, 379, 380, > - 380, 380, 380, 381, 260, 381, 381, 382, 382, 382, > - 382, 383, 250, 383, 383, 384, 384, 384, 384, 385, > - 242, 385, 385, 386, 386, 386, 386, 387, 239, 387, > - 387, 388, 237, 388, 388, 389, 234, 389, 389, 390, > - 226, 390, 390, 391, 391, 391, 391, 392, 392, 392, > - 392, 393, 212, 393, 393, 394, 394, 394, 394, 395, > - 395, 395, 395, 396, 210, 396, 396, 397, 397, 397, > - 397, 398, 398, 398, 398, 399, 399, 399, 399, 400, > - > - 400, 400, 400, 401, 401, 401, 401, 402, 402, 402, > - 402, 403, 162, 403, 403, 404, 404, 404, 404, 405, > - 405, 405, 405, 406, 108, 406, 406, 407, 407, 407, > - 407, 408, 408, 408, 408, 409, 409, 409, 409, 410, > - 106, 410, 410, 411, 411, 411, 411, 412, 412, 412, > - 412, 413, 69, 413, 413, 414, 414, 414, 414, 415, > - 415, 415, 415, 416, 416, 416, 416, 417, 417, 417, > - 417, 418, 418, 418, 418, 419, 419, 419, 419, 420, > - 420, 420, 420, 421, 421, 421, 421, 422, 422, 422, > - 422, 423, 423, 423, 423, 36, 29, 25, 23, 17, > - > - 6, 5, 4, 3, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354, 354, > - 354, 354, 354, 354, 354, 354, 354, 354, 354 > + 24, 22, 24, 50, 26, 21, 50, 26, 19, 44, > + 20, 26, 19, 31, 31, 24, 32, 32, 32, 31, > + > + 39, 42, 39, 32, 35, 35, 35, 35, 40, 45, > + 44, 35, 35, 37, 37, 37, 37, 37, 42, 39, > + 37, 37, 40, 41, 43, 41, 45, 45, 47, 47, > + 48, 49, 51, 54, 55, 43, 51, 52, 54, 52, > + 53, 48, 56, 53, 57, 58, 59, 61, 49, 71, > + 59, 61, 60, 71, 62, 72, 56, 62, 55, 64, > + 64, 75, 58, 72, 77, 64, 57, 60, 74, 60, > + 67, 67, 73, 76, 73, 75, 67, 78, 74, 82, > + 79, 78, 79, 77, 84, 80, 81, 76, 80, 83, > + 81, 82, 83, 85, 89, 86, 84, 86, 88, 90, > + > + 88, 90, 91, 92, 100, 92, 104, 369, 95, 101, > + 91, 85, 87, 87, 87, 87, 89, 138, 104, 87, > + 87, 94, 100, 87, 87, 93, 93, 94, 93, 95, > + 101, 93, 96, 96, 106, 107, 138, 107, 96, 102, > + 102, 102, 102, 102, 103, 112, 102, 102, 103, 105, > + 105, 109, 111, 109, 113, 105, 111, 120, 106, 115, > + 115, 122, 113, 122, 367, 112, 114, 114, 114, 114, > + 114, 115, 120, 114, 114, 116, 116, 118, 118, 121, > + 118, 116, 117, 117, 117, 117, 117, 121, 124, 117, > + 117, 119, 119, 119, 119, 119, 124, 127, 119, 119, > + > + 123, 123, 123, 123, 123, 125, 365, 123, 123, 125, > + 126, 126, 128, 129, 129, 127, 128, 131, 131, 129, > + 133, 134, 139, 131, 136, 136, 136, 134, 137, 136, > + 141, 158, 143, 133, 143, 144, 144, 136, 179, 139, > + 142, 144, 179, 137, 140, 140, 140, 140, 140, 141, > + 158, 140, 140, 142, 146, 146, 148, 148, 149, 149, > + 146, 150, 150, 152, 152, 148, 165, 150, 164, 152, > + 154, 154, 156, 156, 149, 159, 154, 240, 156, 240, > + 159, 160, 160, 162, 162, 165, 164, 160, 168, 162, > + 167, 167, 363, 168, 169, 169, 174, 176, 176, 174, > + > + 169, 177, 177, 178, 178, 180, 181, 186, 186, 181, > + 180, 182, 182, 177, 207, 178, 187, 182, 176, 184, > + 184, 187, 207, 194, 194, 184, 188, 188, 188, 188, > + 188, 189, 189, 188, 188, 194, 359, 189, 195, 195, > + 196, 196, 201, 201, 206, 206, 196, 213, 201, 208, > + 208, 214, 214, 218, 218, 208, 225, 213, 219, 219, > + 220, 220, 225, 221, 221, 222, 222, 223, 223, 224, > + 224, 226, 226, 220, 241, 224, 241, 226, 219, 221, > + 222, 232, 232, 233, 233, 235, 235, 237, 249, 233, > + 238, 235, 238, 238, 357, 237, 237, 242, 242, 247, > + > + 247, 250, 250, 251, 251, 247, 252, 252, 253, 254, > + 254, 292, 249, 250, 265, 265, 253, 253, 258, 258, > + 251, 254, 277, 252, 258, 259, 259, 274, 274, 265, > + 292, 259, 269, 269, 269, 269, 269, 277, 284, 269, > + 269, 278, 278, 274, 279, 283, 280, 279, 279, 280, > + 280, 285, 284, 301, 283, 307, 278, 301, 285, 285, > + 288, 288, 289, 289, 293, 293, 295, 295, 302, 302, > + 293, 308, 295, 298, 298, 355, 288, 352, 307, 310, > + 310, 298, 309, 309, 311, 302, 312, 310, 319, 319, > + 313, 313, 311, 311, 312, 308, 313, 318, 309, 320, > + > + 318, 318, 320, 320, 325, 326, 327, 328, 327, 327, > + 328, 328, 330, 338, 340, 340, 342, 340, 351, 351, > + 351, 326, 354, 354, 325, 362, 330, 349, 347, 342, > + 345, 338, 343, 362, 362, 372, 372, 372, 372, 373, > + 373, 373, 374, 374, 374, 374, 375, 375, 375, 375, > + 376, 341, 376, 376, 377, 377, 377, 377, 378, 339, > + 378, 378, 379, 379, 379, 379, 380, 380, 336, 380, > + 381, 381, 381, 381, 382, 334, 382, 382, 383, 383, > + 383, 383, 384, 384, 384, 384, 385, 385, 385, 385, > + 386, 386, 386, 386, 387, 387, 387, 387, 388, 388, > + > + 388, 388, 389, 333, 389, 389, 390, 390, 390, 390, > + 391, 391, 391, 391, 392, 332, 392, 392, 393, 393, > + 393, 393, 394, 331, 394, 394, 395, 395, 395, 395, > + 396, 323, 396, 396, 397, 397, 397, 397, 398, 321, > + 398, 398, 399, 399, 399, 399, 400, 305, 400, 400, > + 401, 401, 401, 401, 402, 304, 402, 402, 403, 403, > + 403, 403, 404, 303, 404, 404, 405, 299, 405, 405, > + 406, 290, 406, 406, 407, 286, 407, 407, 408, 408, > + 408, 408, 409, 409, 409, 409, 410, 281, 410, 410, > + 411, 411, 411, 411, 412, 412, 412, 412, 413, 275, > + > + 413, 413, 414, 414, 414, 414, 415, 415, 415, 415, > + 416, 416, 416, 416, 417, 417, 417, 417, 418, 418, > + 418, 418, 419, 419, 419, 419, 420, 272, 420, 420, > + 421, 421, 421, 421, 422, 422, 422, 422, 423, 270, > + 423, 423, 424, 424, 424, 424, 425, 425, 425, 425, > + 426, 426, 426, 426, 427, 268, 427, 427, 428, 428, > + 428, 428, 429, 429, 429, 429, 430, 266, 430, 430, > + 431, 431, 431, 431, 432, 432, 432, 432, 433, 433, > + 433, 433, 434, 434, 434, 434, 435, 435, 435, 435, > + 436, 436, 436, 436, 437, 437, 437, 437, 438, 438, > + > + 438, 438, 439, 439, 439, 439, 440, 440, 440, 440, > + 441, 441, 441, 441, 442, 442, 442, 442, 256, 248, > + 245, 243, 239, 231, 217, 215, 166, 110, 108, 70, > + 36, 29, 25, 23, 17, 6, 5, 4, 3, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371, 371, 371, 371, 371, 371, 371, > + 371, 371, 371, 371 > } ; >=20 > #define YY_TRAILING_MASK 0x2000 > @@ -1160,9 +1177,17 @@ static void setbackendtype(DiskParseContext > *dpc, const char *str) { > if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); > else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); > else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); > + else if (!strcmp(str,"standalone")) > DSET(dpc,backend,BACKEND,str,STANDALONE); > else xlu__disk_err(dpc,str,"unknown value for backendtype"); > } >=20 > +/* Sets ->specification from the string. IDL should provide something f= or > this. */ > +static void setspecification(DiskParseContext *dpc, const char *str) { > + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION= ,str,XEN); > + else if (!strcmp(str,"virtio")) > DSET(dpc,specification,SPECIFICATION,str,VIRTIO); > + else xlu__disk_err(dpc,str,"unknown value for specification"); > +} > + > /* Sets ->colo-port from the string. COLO need this. */ > static void setcoloport(DiskParseContext *dpc, const char *str) { > int port =3D atoi(str); > @@ -1199,9 +1224,9 @@ static int vdev_and_devtype(DiskParseContext > *dpc, char *str) { > #undef DPC /* needs to be defined differently the actual lexer */ > #define DPC ((DiskParseContext*)yyextra) >=20 > -#line 1202 "libxlu_disk_l.c" > +#line 1227 "libxlu_disk_l.c" >=20 > -#line 1204 "libxlu_disk_l.c" > +#line 1229 "libxlu_disk_l.c" >=20 > #define INITIAL 0 > #define LEXERR 1 > @@ -1477,13 +1502,13 @@ YY_DECL > } >=20 > { > -#line 177 "libxlu_disk_l.l" > +#line 185 "libxlu_disk_l.l" >=20 >=20 > -#line 180 "libxlu_disk_l.l" > +#line 188 "libxlu_disk_l.l" > /*----- the scanner rules which do the parsing -----*/ >=20 > -#line 1486 "libxlu_disk_l.c" > +#line 1511 "libxlu_disk_l.c" >=20 > while ( /*CONSTCOND*/1 ) /* loops until end-of-file is > reached */ > { > @@ -1515,14 +1540,14 @@ yy_match: > while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D > yy_current_state ) > { > yy_current_state =3D (int) > yy_def[yy_current_state]; > - if ( yy_current_state >=3D 355 ) > + if ( yy_current_state >=3D 372 ) > yy_c =3D yy_meta[yy_c]; > } > yy_current_state =3D yy_nxt[yy_base[yy_current_state] > + yy_c]; > *yyg->yy_state_ptr++ =3D yy_current_state; > ++yy_cp; > } > - while ( yy_current_state !=3D 354 ); > + while ( yy_current_state !=3D 371 ); >=20 > yy_find_action: > yy_current_state =3D *--yyg->yy_state_ptr; > @@ -1572,152 +1597,158 @@ do_action: /* This label is used only to > access EOF actions. */ > case 1: > /* rule 1 can match eol */ > YY_RULE_SETUP > -#line 182 "libxlu_disk_l.l" > +#line 190 "libxlu_disk_l.l" > { /* ignore whitespace before parameters */ } > YY_BREAK > /* ordinary parameters setting enums or strings */ > case 2: > /* rule 2 can match eol */ > YY_RULE_SETUP > -#line 186 "libxlu_disk_l.l" > +#line 194 "libxlu_disk_l.l" > { STRIP(','); setformat(DPC, FROMEQUALS); } > YY_BREAK > case 3: > YY_RULE_SETUP > -#line 188 "libxlu_disk_l.l" > +#line 196 "libxlu_disk_l.l" > { DPC->disk->is_cdrom =3D 1; } > YY_BREAK > case 4: > YY_RULE_SETUP > -#line 189 "libxlu_disk_l.l" > +#line 197 "libxlu_disk_l.l" > { DPC->disk->is_cdrom =3D 1; } > YY_BREAK > case 5: > YY_RULE_SETUP > -#line 190 "libxlu_disk_l.l" > +#line 198 "libxlu_disk_l.l" > { DPC->disk->is_cdrom =3D 0; } > YY_BREAK > case 6: > /* rule 6 can match eol */ > YY_RULE_SETUP > -#line 191 "libxlu_disk_l.l" > +#line 199 "libxlu_disk_l.l" > { xlu__disk_err(DPC,yytext,"unknown value for type"); } > YY_BREAK > case 7: > /* rule 7 can match eol */ > YY_RULE_SETUP > -#line 193 "libxlu_disk_l.l" > +#line 201 "libxlu_disk_l.l" > { STRIP(','); setaccess(DPC, FROMEQUALS); } > YY_BREAK > case 8: > /* rule 8 can match eol */ > YY_RULE_SETUP > -#line 194 "libxlu_disk_l.l" > +#line 202 "libxlu_disk_l.l" > { STRIP(','); SAVESTRING("backend", backend_domname, FROMEQUALS); } > YY_BREAK > case 9: > /* rule 9 can match eol */ > YY_RULE_SETUP > -#line 195 "libxlu_disk_l.l" > +#line 203 "libxlu_disk_l.l" > { STRIP(','); setbackendtype(DPC,FROMEQUALS); } > YY_BREAK > case 10: > /* rule 10 can match eol */ > YY_RULE_SETUP > -#line 197 "libxlu_disk_l.l" > -{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } > +#line 204 "libxlu_disk_l.l" > +{ STRIP(','); setspecification(DPC,FROMEQUALS); } > YY_BREAK > case 11: > /* rule 11 can match eol */ > YY_RULE_SETUP > -#line 198 "libxlu_disk_l.l" > -{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } > +#line 206 "libxlu_disk_l.l" > +{ STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } > YY_BREAK > case 12: > +/* rule 12 can match eol */ > YY_RULE_SETUP > -#line 199 "libxlu_disk_l.l" > -{ DPC->disk->direct_io_safe =3D 1; } > +#line 207 "libxlu_disk_l.l" > +{ STRIP(','); SAVESTRING("script", script, FROMEQUALS); } > YY_BREAK > case 13: > YY_RULE_SETUP > -#line 200 "libxlu_disk_l.l" > -{ libxl_defbool_set(&DPC->disk->discard_enable, true); } > +#line 208 "libxlu_disk_l.l" > +{ DPC->disk->direct_io_safe =3D 1; } > YY_BREAK > case 14: > YY_RULE_SETUP > -#line 201 "libxlu_disk_l.l" > -{ libxl_defbool_set(&DPC->disk->discard_enable, false); } > +#line 209 "libxlu_disk_l.l" > +{ libxl_defbool_set(&DPC->disk->discard_enable, true); } > YY_BREAK > -/* Note that the COLO configuration settings should be considered unstab= le. > - * They may change incompatibly in future versions of Xen. */ > case 15: > YY_RULE_SETUP > -#line 204 "libxlu_disk_l.l" > -{ libxl_defbool_set(&DPC->disk->colo_enable, true); } > +#line 210 "libxlu_disk_l.l" > +{ libxl_defbool_set(&DPC->disk->discard_enable, false); } > YY_BREAK > +/* Note that the COLO configuration settings should be considered unstab= le. > + * They may change incompatibly in future versions of Xen. */ > case 16: > YY_RULE_SETUP > -#line 205 "libxlu_disk_l.l" > -{ libxl_defbool_set(&DPC->disk->colo_enable, false); } > +#line 213 "libxlu_disk_l.l" > +{ libxl_defbool_set(&DPC->disk->colo_enable, true); } > YY_BREAK > case 17: > -/* rule 17 can match eol */ > YY_RULE_SETUP > -#line 206 "libxlu_disk_l.l" > -{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } > +#line 214 "libxlu_disk_l.l" > +{ libxl_defbool_set(&DPC->disk->colo_enable, false); } > YY_BREAK > case 18: > /* rule 18 can match eol */ > YY_RULE_SETUP > -#line 207 "libxlu_disk_l.l" > -{ STRIP(','); setcoloport(DPC, FROMEQUALS); } > +#line 215 "libxlu_disk_l.l" > +{ STRIP(','); SAVESTRING("colo-host", colo_host, FROMEQUALS); } > YY_BREAK > case 19: > /* rule 19 can match eol */ > YY_RULE_SETUP > -#line 208 "libxlu_disk_l.l" > -{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } > +#line 216 "libxlu_disk_l.l" > +{ STRIP(','); setcoloport(DPC, FROMEQUALS); } > YY_BREAK > case 20: > /* rule 20 can match eol */ > YY_RULE_SETUP > -#line 209 "libxlu_disk_l.l" > -{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } > +#line 217 "libxlu_disk_l.l" > +{ STRIP(','); SAVESTRING("colo-export", colo_export, FROMEQUALS); } > YY_BREAK > case 21: > /* rule 21 can match eol */ > YY_RULE_SETUP > -#line 210 "libxlu_disk_l.l" > +#line 218 "libxlu_disk_l.l" > +{ STRIP(','); SAVESTRING("active-disk", active_disk, FROMEQUALS); } > + YY_BREAK > +case 22: > +/* rule 22 can match eol */ > +YY_RULE_SETUP > +#line 219 "libxlu_disk_l.l" > { STRIP(','); SAVESTRING("hidden-disk", hidden_disk, FROMEQUALS); } > YY_BREAK > /* the target magic parameter, eats the rest of the string */ > -case 22: > +case 23: > YY_RULE_SETUP > -#line 214 "libxlu_disk_l.l" > +#line 223 "libxlu_disk_l.l" > { STRIP(','); SAVESTRING("target", pdev_path, FROMEQUALS); } > YY_BREAK > /* unknown parameters */ > -case 23: > -/* rule 23 can match eol */ > +case 24: > +/* rule 24 can match eol */ > YY_RULE_SETUP > -#line 218 "libxlu_disk_l.l" > +#line 227 "libxlu_disk_l.l" > { xlu__disk_err(DPC,yytext,"unknown parameter"); } > YY_BREAK > /* deprecated prefixes */ > /* the "/.*" in these patterns ensures that they count as if they > * matched the whole string, so these patterns take precedence */ > -case 24: > +case 25: > YY_RULE_SETUP > -#line 225 "libxlu_disk_l.l" > +#line 234 "libxlu_disk_l.l" > { > STRIP(':'); > DPC->had_depr_prefix=3D1; DEPRECATE("use `[format=3D= ]...,'"); > setformat(DPC, yytext); > } > YY_BREAK > -case 25: > +case 26: > YY_RULE_SETUP > -#line 231 "libxlu_disk_l.l" > +#line 240 "libxlu_disk_l.l" > { > char *newscript; > STRIP(':'); > @@ -1731,65 +1762,65 @@ YY_RULE_SETUP > free(newscript); > } > YY_BREAK > -case 26: > +case 27: > *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */ > yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 8; > YY_DO_BEFORE_ACTION; /* set up yytext again */ > YY_RULE_SETUP > -#line 244 "libxlu_disk_l.l" > +#line 253 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 27: > +case 28: > YY_RULE_SETUP > -#line 245 "libxlu_disk_l.l" > +#line 254 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 28: > +case 29: > *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */ > yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4; > YY_DO_BEFORE_ACTION; /* set up yytext again */ > YY_RULE_SETUP > -#line 246 "libxlu_disk_l.l" > +#line 255 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 29: > +case 30: > *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */ > yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 6; > YY_DO_BEFORE_ACTION; /* set up yytext again */ > YY_RULE_SETUP > -#line 247 "libxlu_disk_l.l" > +#line 256 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 30: > +case 31: > *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */ > yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 5; > YY_DO_BEFORE_ACTION; /* set up yytext again */ > YY_RULE_SETUP > -#line 248 "libxlu_disk_l.l" > +#line 257 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 31: > +case 32: > *yy_cp =3D yyg->yy_hold_char; /* undo effects of setting up yytext */ > yyg->yy_c_buf_p =3D yy_cp =3D yy_bp + 4; > YY_DO_BEFORE_ACTION; /* set up yytext again */ > YY_RULE_SETUP > -#line 249 "libxlu_disk_l.l" > +#line 258 "libxlu_disk_l.l" > { DPC->had_depr_prefix=3D1; DEPRECATE(0); } > YY_BREAK > -case 32: > -/* rule 32 can match eol */ > +case 33: > +/* rule 33 can match eol */ > YY_RULE_SETUP > -#line 251 "libxlu_disk_l.l" > +#line 260 "libxlu_disk_l.l" > { > xlu__disk_err(DPC,yytext,"unknown deprecated disk > prefix"); > return 0; > } > YY_BREAK > /* positional parameters */ > -case 33: > -/* rule 33 can match eol */ > +case 34: > +/* rule 34 can match eol */ > YY_RULE_SETUP > -#line 258 "libxlu_disk_l.l" > +#line 267 "libxlu_disk_l.l" > { > STRIP(','); >=20 > @@ -1816,27 +1847,27 @@ YY_RULE_SETUP > } > } > YY_BREAK > -case 34: > +case 35: > YY_RULE_SETUP > -#line 284 "libxlu_disk_l.l" > +#line 293 "libxlu_disk_l.l" > { > BEGIN(LEXERR); > yymore(); > } > YY_BREAK > -case 35: > +case 36: > YY_RULE_SETUP > -#line 288 "libxlu_disk_l.l" > +#line 297 "libxlu_disk_l.l" > { > xlu__disk_err(DPC,yytext,"bad disk syntax"); return 0; > } > YY_BREAK > -case 36: > +case 37: > YY_RULE_SETUP > -#line 291 "libxlu_disk_l.l" > +#line 300 "libxlu_disk_l.l" > YY_FATAL_ERROR( "flex scanner jammed" ); > YY_BREAK > -#line 1839 "libxlu_disk_l.c" > +#line 1870 "libxlu_disk_l.c" > case YY_STATE_EOF(INITIAL): > case YY_STATE_EOF(LEXERR): > yyterminate(); > @@ -2104,7 +2135,7 @@ static int yy_get_next_buffer (yyscan_t yyscanner) > while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D > yy_current_state ) > { > yy_current_state =3D (int) yy_def[yy_current_state]; > - if ( yy_current_state >=3D 355 ) > + if ( yy_current_state >=3D 372 ) > yy_c =3D yy_meta[yy_c]; > } > yy_current_state =3D yy_nxt[yy_base[yy_current_state] + yy_c]; > @@ -2128,11 +2159,11 @@ static int yy_get_next_buffer (yyscan_t > yyscanner) > while ( yy_chk[yy_base[yy_current_state] + yy_c] !=3D yy_current_state = ) > { > yy_current_state =3D (int) yy_def[yy_current_state]; > - if ( yy_current_state >=3D 355 ) > + if ( yy_current_state >=3D 372 ) > yy_c =3D yy_meta[yy_c]; > } > yy_current_state =3D yy_nxt[yy_base[yy_current_state] + yy_c]; > - yy_is_jam =3D (yy_current_state =3D=3D 354); > + yy_is_jam =3D (yy_current_state =3D=3D 371); > if ( ! yy_is_jam ) > *yyg->yy_state_ptr++ =3D yy_current_state; >=20 > @@ -2941,4 +2972,4 @@ void yyfree (void * ptr , yyscan_t yyscanner) >=20 > #define YYTABLES_NAME "yytables" >=20 > -#line 291 "libxlu_disk_l.l" > +#line 300 "libxlu_disk_l.l" > diff --git a/tools/libs/util/libxlu_disk_l.h b/tools/libs/util/libxlu_dis= k_l.h > index 6abeecf279..509aad67dc 100644 > --- a/tools/libs/util/libxlu_disk_l.h > +++ b/tools/libs/util/libxlu_disk_l.h > @@ -694,7 +694,7 @@ extern int yylex (yyscan_t yyscanner); > #undef yyTABLES_NAME > #endif >=20 > -#line 291 "libxlu_disk_l.l" > +#line 300 "libxlu_disk_l.l" >=20 > #line 699 "libxlu_disk_l.h" > #undef xlu__disk_yyIN_HEADER > diff --git a/tools/libs/util/libxlu_disk_l.l b/tools/libs/util/libxlu_dis= k_l.l > index e115460d99..6d53c093a3 100644 > --- a/tools/libs/util/libxlu_disk_l.l > +++ b/tools/libs/util/libxlu_disk_l.l > @@ -122,9 +122,17 @@ static void setbackendtype(DiskParseContext *dpc, > const char *str) { > if ( !strcmp(str,"phy")) DSET(dpc,backend,BACKEND,str,PHY); > else if (!strcmp(str,"tap")) DSET(dpc,backend,BACKEND,str,TAP); > else if (!strcmp(str,"qdisk")) DSET(dpc,backend,BACKEND,str,QDISK); > + else if (!strcmp(str,"standalone")) > DSET(dpc,backend,BACKEND,str,STANDALONE); > else xlu__disk_err(dpc,str,"unknown value for backendtype"); > } >=20 > +/* Sets ->specification from the string. IDL should provide something f= or > this. */ > +static void setspecification(DiskParseContext *dpc, const char *str) { > + if (!strcmp(str,"xen")) DSET(dpc,specification,SPECIFICATION= ,str,XEN); > + else if (!strcmp(str,"virtio")) > DSET(dpc,specification,SPECIFICATION,str,VIRTIO); > + else xlu__disk_err(dpc,str,"unknown value for specification"); > +} > + > /* Sets ->colo-port from the string. COLO need this. */ > static void setcoloport(DiskParseContext *dpc, const char *str) { > int port =3D atoi(str); > @@ -192,6 +200,7 @@ devtype=3D[^,]*,? > { xlu__disk_err(DPC,yytext,"unknown value for type"); } > access=3D[^,]*,? { STRIP(','); setaccess(DPC, FROMEQUALS); } > backend=3D[^,]*,? { STRIP(','); SAVESTRING("backend", backend_domname, > FROMEQUALS); } > backendtype=3D[^,]*,? { STRIP(','); setbackendtype(DPC,FROMEQUALS); } > +specification=3D[^,]*,? { STRIP(','); setspecification(DPC,FROMEQUALS); = } >=20 > vdev=3D[^,]*,? { STRIP(','); SAVESTRING("vdev", vdev, FROMEQUALS); } > script=3D[^,]*,? { STRIP(','); SAVESTRING("script", script, FROMEQUALS);= } > diff --git a/tools/xl/xl_block.c b/tools/xl/xl_block.c > index 70eed431e4..8836c07d6b 100644 > --- a/tools/xl/xl_block.c > +++ b/tools/xl/xl_block.c > @@ -119,6 +119,12 @@ int main_blockdetach(int argc, char **argv) > fprintf(stderr, "Error: Device %s not connected.\n", argv[optind= +1]); > return 1; > } > + > + if (disk.specification =3D=3D LIBXL_DISK_SPECIFICATION_VIRTIO) { > + fprintf(stderr, "Hotunplug isn't supported for specification vir= tio\n"); > + return 1; > + } > + > rc =3D !force ? libxl_device_disk_safe_remove(ctx, domid, &disk, 0) = : > libxl_device_disk_destroy(ctx, domid, &disk, 0); > if (rc) { > -- > 2.25.1 >=20 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 04:49:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 04:49:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371315.603157 (Exim 4.92) (envelope-from ) id 1oE1e6-0006n6-Bk; Wed, 20 Jul 2022 04:49:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371315.603157; Wed, 20 Jul 2022 04:49:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE1e6-0006mz-8f; Wed, 20 Jul 2022 04:49:14 +0000 Received: by outflank-mailman (input) for mailman id 371315; Wed, 20 Jul 2022 04:49:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE1e4-0006mt-PE for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 04:49:13 +0000 Received: from mail116c40.carrierzone.com (mail116c40.carrierzone.com [209.235.151.136]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 48aa646b-07e7-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 06:49:09 +0200 (CEST) Received: from [192.168.1.93] (172-125-173-116.lightspeed.rlghnc.sbcglobal.net [172.125.173.116]) (authenticated bits=0) by mail116c40.carrierzone.com (8.14.9/8.13.1) with ESMTP id 26K4muXc067471; Wed, 20 Jul 2022 04:48:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48aa646b-07e7-11ed-924f-1f966e50362f X-Authenticated-User: chris@dalessio.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=carrierzone.com; s=mailmia; t=1658292539; bh=R8TkUJtj2xWiQgvW+rwYSUNctkxQ3CNxC3ba4GXunDg=; h=Date:Subject:In-Reply-To:From:To:Cc:From; b=tqVmJc2LEusHeQtkZ27V3A9eC0tZOCUNHrN8SWyEyegA/7MciwVM+nTizvnogihgK T67Nhc0HUloKqYSCVLUkgrI0BRCKxNDN/MN+As91J0MXY56zUn7LaLlAVN9vwhcCEr Rz3LWyPh+ZEj35oxb2klILs3JT5H8j7nOjyzqFtk= Feedback-ID:chris@dalessio. Message-Id: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> SavedFromEmail: chris@dalessio.org Date: Wed, 20 Jul 2022 00:48:56 -0400 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] In-Reply-To: Importance: normal From: ChrisD To: Andrew Cooper , "xen-devel@lists.xenproject.org" Cc: Jan Beulich , Michael Young MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="--_com.samsung.android.email_3406098329667320" X-CTCH-RefID: str=0001.0A702F28.62D7893B.0087:SCFSTAT96973171,ss=1,re=-4.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Rules: X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-Origin-Country: US ----_com.samsung.android.email_3406098329667320 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 U28sIHlvdSB0aGluayBpdCdzIGEgcHJvYmxlbSB3aXRoIGZjMzY/Ci0tLS0tLS0tIE9yaWdpbmFs IG1lc3NhZ2UgLS0tLS0tLS1Gcm9tOiBBbmRyZXcgQ29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRy aXguY29tPiBEYXRlOiA3LzE4LzIyICA2OjI1IFBNICAoR01ULTA1OjAwKSBUbzogY2hyaXNAZGFs ZXNzaW8ub3JnLCB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmcgQ2M6IEphbiBCZXVsaWNo IDxqYmV1bGljaEBzdXNlLmNvbT4sIE1pY2hhZWwgWW91bmcgPG0uYS55b3VuZ0BkdXJoYW0uYWMu dWs+IFN1YmplY3Q6IFJlOiBQYW5pYyBvbiBDUFUgMDogRkFUQUwgVFJBUDogdmVjIDcsICNOTVsw MDAwXSBPbiAxOC8wNy8yMDIyIDIyOjMxLCBjaHJpc0BkYWxlc3Npby5vcmcgd3JvdGU6PiBJIGFt IHRyeWluZyB0byBydW4gWGVuLTQuMTYuMS00LmZjMzYgb24gRmVkb3JhIDM2IG9uIGEgYnJhbmQg bmV3IExlbm92bz4gVGhpbmtTdGF0aW9uIHA2MjAsIGJ1dCBJIGtlZXAgZ2V0dGluZyB0aGUgZm9s bG93aW5nIGVycm9yIGJvb3RpbmcgdGhlPiBYZW4ga2VybmVsLj4gPiBQYW5pYyBvbiBDUFUgMDo+ IEZBVEFMIFRSQVA6IHZlYyA3LCAjTk1bMDAwMF0+PiBWZXJzaW9uIGluZm86PiBOYW1lIMKgIMKg IMKgIMKgOiB4ZW4+IFZlcnNpb24gwqAgwqAgOiA0LjE2LjE+IFJlbGVhc2UgwqAgwqAgOiA0LmZj MzZTbyBodHRwczovL2tvamkuZmVkb3JhcHJvamVjdC5vcmcva29qaS9idWlsZGluZm8/YnVpbGRJ RD0xOTkxMTgyIHNob3VsZGJlIHRoZSBiaW5hcnkgYnVpbGQgaW4gdXNlLCBhbmQgbG9va2luZyBh dCB0aGUgZGVidWcgc3ltcywgaXQgcmVhbGx5ZG9lcyBoYXZlOmZmZmY4MmQwNDA0MzljODAgPGFt ZF9pb21tdV9pbml0PjouLi5mZmZmODJkMDQwNDNhMDBjOsKgwqDCoMKgwqDCoCAwZiA2ZSBjMsKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBtb3ZkwqDCoCAlZWR4LCVtbTBmZmZmODJkMDQw NDNhMDBmOsKgwqDCoMKgwqDCoCAwZiA2MiBjMMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCBwdW5wY2tsZHEgJW1tMCwlbW0wZmZmZjgyZDA0MDQzYTAxMjrCoMKgwqDCoMKgwqAgNDkgODkg ODcgYzAgMDAgMDAgMDDCoMKgwqAgbW92wqDCoMKgICVyYXgsMHhjMCglcjE1KWZmZmY4MmQwNDA0 M2EwMTk6wqDCoMKgwqDCoMKgIDQxIDBmIDdmIDg3IGQwIDAwIDAwwqDCoMKgIG1vdnHCoMKgICVt bTAsMHhkMCglcjE1KWZmZmY4MmQwNDA0M2EwMjA6wqDCoMKgwqDCoMKgIDAwU28gaGFyZHdhcmUg aXMgY29ycmVjdCAtIHRoaXMgYnVpbGQgb2YgWGVuIGlzIG5vbnNlbnNlLlRoZSBiaW5hcnkgaXMg YWxzbyBmdWxsIG9mIC5hbm5vYmluXyBzdHVmZiB3aGljaCBhcHBlYXJzIHRvIGJlIHNvbWUga2lu ZG9mIEdDQyBwbHVnaW4gZm9yIHdhdGVybWFya2luZy5NaWNoYWVsOiBBbnkgaWRlYSB3aGF0J3Mg Z29pbmcgb24gaGVyZT/CoCBTb21ldGhpbmcgaGFzIGNhdXNlZCBHQ0MgdG9lbWl0IHNvbWUgTU1Y IGxvZ2ljIHdoaWNoIGlzIHVsdGltYXRlbHkgd2h5IHRoaW5ncyBleHBsb2RlZCwgYnV0IHRoaXNw cm9iYWJseSBtZWFucyB0aGF0IHNvbWUgb2YgdGhlIGJ1aWxkIENGTEFHUyBnb3QgZHJvcHBlZC5U aGFua3MsfkFuZHJldw== ----_com.samsung.android.email_3406098329667320 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGh0bWw+PGhlYWQ+PG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250ZW50PSJ0ZXh0 L2h0bWw7IGNoYXJzZXQ9VVRGLTgiPjwvaGVhZD48Ym9keSBkaXI9ImF1dG8iPlNvLCB5b3UgdGhp bmsgaXQncyBhIHByb2JsZW0gd2l0aCBmYzM2PzxkaXY+PGJyPjwvZGl2PjxkaXYgYWxpZ249Imxl ZnQiIGRpcj0iYXV0byIgc3R5bGU9ImZvbnQtc2l6ZToxMDAlO2NvbG9yOiMwMDAwMDAiPjxkaXY+ LS0tLS0tLS0gT3JpZ2luYWwgbWVzc2FnZSAtLS0tLS0tLTwvZGl2PjxkaXY+RnJvbTogQW5kcmV3 IENvb3BlciAmbHQ7QW5kcmV3LkNvb3BlcjNAY2l0cml4LmNvbSZndDsgPC9kaXY+PGRpdj5EYXRl OiA3LzE4LzIyICA2OjI1IFBNICAoR01ULTA1OjAwKSA8L2Rpdj48ZGl2PlRvOiBjaHJpc0BkYWxl c3Npby5vcmcsIHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZyA8L2Rpdj48ZGl2PkNjOiBK YW4gQmV1bGljaCAmbHQ7amJldWxpY2hAc3VzZS5jb20mZ3Q7LCBNaWNoYWVsIFlvdW5nICZsdDtt LmEueW91bmdAZHVyaGFtLmFjLnVrJmd0OyA8L2Rpdj48ZGl2PlN1YmplY3Q6IFJlOiBQYW5pYyBv biBDUFUgMDogRkFUQUwgVFJBUDogdmVjIDcsICNOTVswMDAwXSA8L2Rpdj48ZGl2Pjxicj48L2Rp dj48L2Rpdj5PbiAxOC8wNy8yMDIyIDIyOjMxLCBjaHJpc0BkYWxlc3Npby5vcmcgd3JvdGU6PGJy PiZndDsgSSBhbSB0cnlpbmcgdG8gcnVuIFhlbi00LjE2LjEtNC5mYzM2IG9uIEZlZG9yYSAzNiBv biBhIGJyYW5kIG5ldyBMZW5vdm88YnI+Jmd0OyBUaGlua1N0YXRpb24gcDYyMCwgYnV0IEkga2Vl cCBnZXR0aW5nIHRoZSBmb2xsb3dpbmcgZXJyb3IgYm9vdGluZyB0aGU8YnI+Jmd0OyBYZW4ga2Vy bmVsLjxicj4mZ3Q7IDxicj4mZ3Q7IFBhbmljIG9uIENQVSAwOjxicj4mZ3Q7IEZBVEFMIFRSQVA6 IHZlYyA3LCAjTk1bMDAwMF08YnI+Jmd0Ozxicj4mZ3Q7IFZlcnNpb24gaW5mbzo8YnI+Jmd0OyBO YW1lICZuYnNwOyAmbmJzcDsgJm5ic3A7ICZuYnNwOzogeGVuPGJyPiZndDsgVmVyc2lvbiAmbmJz cDsgJm5ic3A7IDogNC4xNi4xPGJyPiZndDsgUmVsZWFzZSAmbmJzcDsgJm5ic3A7IDogNC5mYzM2 PGJyPjxicj5TbyBodHRwczovL2tvamkuZmVkb3JhcHJvamVjdC5vcmcva29qaS9idWlsZGluZm8/ YnVpbGRJRD0xOTkxMTgyIHNob3VsZDxicj5iZSB0aGUgYmluYXJ5IGJ1aWxkIGluIHVzZSwgYW5k IGxvb2tpbmcgYXQgdGhlIGRlYnVnIHN5bXMsIGl0IHJlYWxseTxicj5kb2VzIGhhdmU6PGJyPjxi cj5mZmZmODJkMDQwNDM5YzgwICZsdDthbWRfaW9tbXVfaW5pdCZndDs6PGJyPi4uLjxicj5mZmZm ODJkMDQwNDNhMDBjOiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyAwZiA2ZSBj MiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBtb3ZkJm5ic3A7Jm5ic3A7ICVlZHgs JW1tMDxicj5mZmZmODJkMDQwNDNhMDBmOiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyAwZiA2MiBjMCZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyBwdW5wY2tsZHEg JW1tMCwlbW0wPGJyPmZmZmY4MmQwNDA0M2EwMTI6Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7IDQ5IDg5IDg3IGMwIDAwIDAwIDAwJm5ic3A7Jm5ic3A7Jm5ic3A7IG1vdiZuYnNw OyZuYnNwOyZuYnNwOyAlcmF4LDB4YzAoJXIxNSk8YnI+ZmZmZjgyZDA0MDQzYTAxOTombmJzcDsm bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgNDEgMGYgN2YgODcgZDAgMDAgMDAmbmJzcDsm bmJzcDsmbmJzcDsgbW92cSZuYnNwOyZuYnNwOyAlbW0wLDB4ZDAoJXIxNSk8YnI+ZmZmZjgyZDA0 MDQzYTAyMDombmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsgMDA8YnI+PGJyPlNv IGhhcmR3YXJlIGlzIGNvcnJlY3QgLSB0aGlzIGJ1aWxkIG9mIFhlbiBpcyBub25zZW5zZS48YnI+ PGJyPlRoZSBiaW5hcnkgaXMgYWxzbyBmdWxsIG9mIC5hbm5vYmluXyBzdHVmZiB3aGljaCBhcHBl YXJzIHRvIGJlIHNvbWUga2luZDxicj5vZiBHQ0MgcGx1Z2luIGZvciB3YXRlcm1hcmtpbmcuPGJy Pjxicj5NaWNoYWVsOiBBbnkgaWRlYSB3aGF0J3MgZ29pbmcgb24gaGVyZT8mbmJzcDsgU29tZXRo aW5nIGhhcyBjYXVzZWQgR0NDIHRvPGJyPmVtaXQgc29tZSBNTVggbG9naWMgd2hpY2ggaXMgdWx0 aW1hdGVseSB3aHkgdGhpbmdzIGV4cGxvZGVkLCBidXQgdGhpczxicj5wcm9iYWJseSBtZWFucyB0 aGF0IHNvbWUgb2YgdGhlIGJ1aWxkIENGTEFHUyBnb3QgZHJvcHBlZC48YnI+PGJyPlRoYW5rcyw8 YnI+PGJyPn5BbmRyZXc8YnI+PGJyPjwvYm9keT48L2h0bWw+ ----_com.samsung.android.email_3406098329667320-- From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:22:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:22:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371322.603168 (Exim 4.92) (envelope-from ) id 1oE2Aa-0003aJ-Sl; Wed, 20 Jul 2022 05:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371322.603168; Wed, 20 Jul 2022 05:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Aa-0003aC-Q7; Wed, 20 Jul 2022 05:22:48 +0000 Received: by outflank-mailman (input) for mailman id 371322; Wed, 20 Jul 2022 05:22:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2AZ-0003a2-K6; Wed, 20 Jul 2022 05:22:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2AZ-0000HC-Gi; Wed, 20 Jul 2022 05:22:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2AZ-00030z-4V; Wed, 20 Jul 2022 05:22:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE2AZ-0008Gz-45; Wed, 20 Jul 2022 05:22:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CqrFuTEmD5GQCmcU/FVY6YZatNRqAblK1IHCwdUY144=; b=0x5xpQewjsPKNcvpcDvlPN3KH7 xKICls9SfJ0m5BhcgtbiHalikbHC28TcO/5SqvJrmCdhKHNfIbJmB9Fm1486n9Cm+P+b8P0gszo9z jHr6/SPzKg1hfGmpYkqQE06vaGIcxXoogIOjqAvDew/txNxJwNhpF32wriLLnR6m1Xhc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171693: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-xl-vhd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=d48125de38f48a61d6423ef6a01156d6dff9ee2c X-Osstest-Versions-That: qemuu=b8bb9bbf4695b89bbdca702a054db0a7a2c8ff2b From: osstest service owner Date: Wed, 20 Jul 2022 05:22:47 +0000 flight 171693 qemu-mainline real [real] flight 171698 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171693/ http://logs.test-lab.xenproject.org/osstest/logs/171698/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-vhd 7 xen-install fail pass in 171698-retest test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 171698-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 171698 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 171698 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171683 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171683 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171683 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171683 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171683 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171683 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171683 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171683 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu d48125de38f48a61d6423ef6a01156d6dff9ee2c baseline version: qemuu b8bb9bbf4695b89bbdca702a054db0a7a2c8ff2b Last test of basis 171683 2022-07-19 09:07:08 Z 0 days Testing same since 171693 2022-07-19 21:08:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cole Robinson Felix "xq" Queißner Felix xq Queißner Gerd Hoffmann Helge Deller John Snow Marc-André Lureau Mark Cave-Ayland Mauro Matteo Cascella Peter Maydell Philippe Mathieu-Daudé Richard Henderson Song Gao Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git b8bb9bbf46..d48125de38 d48125de38f48a61d6423ef6a01156d6dff9ee2c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371332.603190 (Exim 4.92) (envelope-from ) id 1oE2Xd-0006mL-7z; Wed, 20 Jul 2022 05:46:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371332.603190; Wed, 20 Jul 2022 05:46:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xd-0006mE-3P; Wed, 20 Jul 2022 05:46:37 +0000 Received: by outflank-mailman (input) for mailman id 371332; Wed, 20 Jul 2022 05:46:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xb-0006lV-VO for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:35 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 4f9991d8-07ef-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 07:46:33 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6181C15A1; Tue, 19 Jul 2022 22:46:33 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0447D3F70D; Tue, 19 Jul 2022 22:46:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f9991d8-07ef-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v9 1/8] xen/arm: rename PGC_reserved to PGC_static Date: Wed, 20 Jul 2022 13:46:04 +0800 Message-Id: <20220720054611.2695787-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit PGC_reserved could be ambiguous, and we have to tell what the pages are reserved for, so this commit intends to rename PGC_reserved to PGC_static, which clearly indicates the page is reserved for static memory. Signed-off-by: Penny Zheng Acked-by: Jan Beulich Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - rename PGC_staticmem to PGC_static --- v5 changes: - new commit --- xen/arch/arm/include/asm/mm.h | 6 +++--- xen/common/page_alloc.c | 22 +++++++++++----------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index c4bc3cd1e5..8b2481c1f3 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,9 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is reserved */ -#define _PGC_reserved PG_shift(3) -#define PGC_reserved PG_mask(1, 3) + /* Page is static memory */ +#define _PGC_static PG_shift(3) +#define PGC_static PG_mask(1, 3) /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index fe0e15429a..ed56379b96 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,8 +151,8 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_reserved -#define PGC_reserved 0 +#ifndef PGC_static +#define PGC_static 0 #endif /* @@ -2286,7 +2286,7 @@ int assign_pages( for ( i = 0; i < nr; i++ ) { - ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_reserved))); + ASSERT(!(pg[i].count_info & ~(PGC_extra | PGC_static))); if ( pg[i].count_info & PGC_extra ) extra_pages++; } @@ -2346,7 +2346,7 @@ int assign_pages( page_set_owner(&pg[i], d); smp_wmb(); /* Domain pointer must be visible before updating refcnt. */ pg[i].count_info = - (pg[i].count_info & (PGC_extra | PGC_reserved)) | PGC_allocated | 1; + (pg[i].count_info & (PGC_extra | PGC_static)) | PGC_allocated | 1; page_list_add_tail(&pg[i], page_to_list(d, &pg[i])); } @@ -2652,8 +2652,8 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_reserved. */ - pg[i].count_info |= PGC_reserved; + /* In case initializing page of static memory, mark it PGC_static. */ + pg[i].count_info |= PGC_static; } } @@ -2682,8 +2682,8 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, for ( i = 0; i < nr_mfns; i++ ) { - /* The page should be reserved and not yet allocated. */ - if ( pg[i].count_info != (PGC_state_free | PGC_reserved) ) + /* The page should be static and not yet allocated. */ + if ( pg[i].count_info != (PGC_state_free | PGC_static) ) { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", @@ -2697,10 +2697,10 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, &tlbflush_timestamp); /* - * Preserve flag PGC_reserved and change page state + * Preserve flag PGC_static and change page state * to PGC_state_inuse. */ - pg[i].count_info = PGC_reserved | PGC_state_inuse; + pg[i].count_info = PGC_static | PGC_state_inuse; /* Initialise fields which have other uses for free pages. */ pg[i].u.inuse.type_info = 0; page_set_owner(&pg[i], NULL); @@ -2722,7 +2722,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, out_err: while ( i-- ) - pg[i].count_info = PGC_reserved | PGC_state_free; + pg[i].count_info = PGC_static | PGC_state_free; spin_unlock(&heap_lock); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371330.603178 (Exim 4.92) (envelope-from ) id 1oE2XY-0006Vd-QX; Wed, 20 Jul 2022 05:46:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371330.603178; Wed, 20 Jul 2022 05:46:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2XY-0006VW-Nq; Wed, 20 Jul 2022 05:46:32 +0000 Received: by outflank-mailman (input) for mailman id 371330; Wed, 20 Jul 2022 05:46:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2XX-0006VQ-Ny for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:31 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 4cf6094d-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04A631042; Tue, 19 Jul 2022 22:46:29 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 231813F70D; Tue, 19 Jul 2022 22:46:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4cf6094d-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v9 0/8] populate/unpopulate memory when domain on static allocation Date: Wed, 20 Jul 2022 13:46:03 +0800 Message-Id: <20220720054611.2695787-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory over to the heap allocator. And it will be a problem if it is a static domain. Pages used as guest RAM for static domain shall always be reserved to this domain only, and not be used for any other purposes, so they shall never go back to heap allocator. This patch serie intends to fix this issue, by adding pages on the new list resv_page_list after having taken them off the "normal" list, when unpopulating memory, and retrieving pages from resv page list(resv_page_list) when populating memory. --- v9 changes: - move free_domheap_page into else-condition - considering scrubbing static pages, domain dying case and opt_scrub_domheap both do not apply to static pages. - as unowned static pages don't make themselves to free_domstatic_page at the moment, remove else-condition and add ASSERT(d) at the top of the function - remove macro helper put_static_page, and just expand its code inside free_domstatic_page - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page - Add free_staticmem_pages to undo prepare_staticmem_pages when assign_domstatic_pages fails - Remove redundant static in error message --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY, as it is used outside page_alloc.c - #ifdef-ary around is_domain_using_staticmem() is not needed anymore - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore - add page on the rsv_page_list *after* it has been freed - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - rename PGC_staticmem to PGC_static - remove #ifdef aroud function declaration - use domain instead of sub-systems - move non-zero is_domain_using_staticmem() from ARM header to common header - move PGC_static !CONFIG_STATIC_MEMORY definition to common header - drop the lock before returning --- v5 changes: - introduce three new commits - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes: - commit message refinement - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" - change name from "is_domain_static()" to "is_domain_using_staticmem" - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. - move #ifndef is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - change name from "is_domain_on_static_allocation" to "is_domain_static()" - put reserved pages on resv_page_list after having taken them off the "normal" list - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 - fix coding style Penny Zheng (8): xen/arm: rename PGC_reserved to PGC_static xen: do not free reserved memory into heap xen: do not merge reserved pages in free_heap_pages() xen: add field "flags" to cover all internal CDF_XXX xen/arm: introduce CDF_staticmem xen/arm: unpopulate memory when domain is static xen: introduce prepare_staticmem_pages xen: retrieve reserved pages on populate_physmap xen/arch/arm/domain.c | 2 - xen/arch/arm/domain_build.c | 5 +- xen/arch/arm/include/asm/domain.h | 3 +- xen/arch/arm/include/asm/mm.h | 8 +- xen/arch/arm/mm.c | 5 +- xen/common/domain.c | 7 ++ xen/common/memory.c | 23 ++++ xen/common/page_alloc.c | 178 ++++++++++++++++++++++-------- xen/include/xen/domain.h | 8 ++ xen/include/xen/mm.h | 8 +- xen/include/xen/sched.h | 6 + 11 files changed, 193 insertions(+), 60 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371333.603201 (Exim 4.92) (envelope-from ) id 1oE2Xg-00074z-FP; Wed, 20 Jul 2022 05:46:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371333.603201; Wed, 20 Jul 2022 05:46:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xg-00074o-C2; Wed, 20 Jul 2022 05:46:40 +0000 Received: by outflank-mailman (input) for mailman id 371333; Wed, 20 Jul 2022 05:46:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xe-0006VQ-Pv for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5215e53d-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:37 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 80F401042; Tue, 19 Jul 2022 22:46:37 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6268A3F70D; Tue, 19 Jul 2022 22:46:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5215e53d-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng Subject: [PATCH v9 2/8] xen: do not free reserved memory into heap Date: Wed, 20 Jul 2022 13:46:05 +0800 Message-Id: <20220720054611.2695787-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Pages used as guest RAM for static domain, shall be reserved to this domain only. So in case reserved pages being used for other purpose, users shall not free them back to heap, even when last ref gets dropped. This commit introduces a new helper free_domstatic_page to free static page in runtime, and free_staticmem_pages will be called by it in runtime, so let's drop the __init flag. Signed-off-by: Penny Zheng --- v9 changes: - move free_domheap_page into else-condition - considering scrubbing static pages, domain dying case and opt_scrub_domheap both donot apply to static pages. - as unowned static pages don't make themselves to free_domstatic_page at the moment, remove else-condition and add ASSERT(d) at the top of the function --- v8 changes: - introduce new helper free_domstatic_page - let put_page call free_domstatic_page for static page, when last ref drops - #define PGC_static zero when !CONFIG_STATIC_MEMORY, as it is used outside page_alloc.c --- v7 changes: - protect free_staticmem_pages with heap_lock to match its reverse function acquire_staticmem_pages --- v6 changes: - adapt to PGC_static - remove #ifdef aroud function declaration --- v5 changes: - In order to avoid stub functions, we #define PGC_staticmem to non-zero only when CONFIG_STATIC_MEMORY - use "unlikely()" around pg->count_info & PGC_staticmem - remove pointless "if", since mark_page_free() is going to set count_info to PGC_state_free and by consequence clear PGC_staticmem - move #define PGC_staticmem 0 to mm.h --- v4 changes: - no changes --- v3 changes: - fix possible racy issue in free_staticmem_pages() - introduce a stub free_staticmem_pages() for the !CONFIG_STATIC_MEMORY case - move the change to free_heap_pages() to cover other potential call sites - fix the indentation --- v2 changes: - new commit --- --- xen/arch/arm/include/asm/mm.h | 4 +++- xen/arch/arm/mm.c | 5 ++++- xen/common/page_alloc.c | 37 ++++++++++++++++++++++++++++------- xen/include/xen/mm.h | 7 +++++-- 4 files changed, 42 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index 8b2481c1f3..f1640bbda4 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -108,9 +108,11 @@ struct page_info /* Page is Xen heap? */ #define _PGC_xen_heap PG_shift(2) #define PGC_xen_heap PG_mask(1, 2) - /* Page is static memory */ +#ifdef CONFIG_STATIC_MEMORY +/* Page is static memory */ #define _PGC_static PG_shift(3) #define PGC_static PG_mask(1, 3) +#endif /* ... */ /* Page is broken? */ #define _PGC_broken PG_shift(7) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 009b8cd9ef..9132fb9472 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1622,7 +1622,10 @@ void put_page(struct page_info *page) if ( unlikely((nx & PGC_count_mask) == 0) ) { - free_domheap_page(page); + if ( unlikely(nx & PGC_static) ) + free_domstatic_page(page); + else + free_domheap_page(page); } } diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index ed56379b96..a12622e921 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -151,10 +151,6 @@ #define p2m_pod_offline_or_broken_replace(pg) BUG_ON(pg != NULL) #endif -#ifndef PGC_static -#define PGC_static 0 -#endif - /* * Comma-separated list of hexadecimal page numbers containing bad bytes. * e.g. 'badpage=0x3f45,0x8a321'. @@ -2636,12 +2632,14 @@ struct domain *get_pg_owner(domid_t domid) #ifdef CONFIG_STATIC_MEMORY /* Equivalent of free_heap_pages to free nr_mfns pages of static memory. */ -void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, - bool need_scrub) +void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + bool need_scrub) { mfn_t mfn = page_to_mfn(pg); unsigned long i; + spin_lock(&heap_lock); + for ( i = 0; i < nr_mfns; i++ ) { mark_page_free(&pg[i], mfn_add(mfn, i)); @@ -2652,9 +2650,34 @@ void __init free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, scrub_one_page(pg); } - /* In case initializing page of static memory, mark it PGC_static. */ pg[i].count_info |= PGC_static; } + + spin_unlock(&heap_lock); +} + +void free_domstatic_page(struct page_info *page) +{ + struct domain *d = page_get_owner(page); + bool drop_dom_ref; + + ASSERT(d); + + ASSERT_ALLOC_CONTEXT(); + + /* NB. May recursively lock from relinquish_memory(). */ + spin_lock_recursive(&d->page_alloc_lock); + + arch_free_heap_page(d, page); + + drop_dom_ref = !domain_adjust_tot_pages(d, -1); + + spin_unlock_recursive(&d->page_alloc_lock); + + free_staticmem_pages(page, 1, scrub_debug); + + if ( drop_dom_ref ) + put_domain(d); } /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index 3be754da92..f1a7d5c991 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -85,13 +85,12 @@ bool scrub_free_pages(void); } while ( false ) #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) -#ifdef CONFIG_STATIC_MEMORY /* These functions are for static memory */ void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, bool need_scrub); +void free_domstatic_page(struct page_info *page); int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, unsigned int memflags); -#endif /* Map machine page range in Xen virtual address space. */ int map_pages_to_xen( @@ -212,6 +211,10 @@ extern struct domain *dom_cow; #include +#ifndef PGC_static +#define PGC_static 0 +#endif + static inline bool is_special_page(const struct page_info *page) { return is_xen_heap_page(page) || (page->count_info & PGC_extra); -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371334.603212 (Exim 4.92) (envelope-from ) id 1oE2Xi-0007NU-Pt; Wed, 20 Jul 2022 05:46:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371334.603212; Wed, 20 Jul 2022 05:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xi-0007NN-Ks; Wed, 20 Jul 2022 05:46:42 +0000 Received: by outflank-mailman (input) for mailman id 371334; Wed, 20 Jul 2022 05:46:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xi-0006VQ-97 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5461ea39-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:41 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 615B91042; Tue, 19 Jul 2022 22:46:41 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 81E0E3F70D; Tue, 19 Jul 2022 22:46:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5461ea39-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , Penny Zheng Subject: [PATCH v9 3/8] xen: do not merge reserved pages in free_heap_pages() Date: Wed, 20 Jul 2022 13:46:06 +0800 Message-Id: <20220720054611.2695787-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The code in free_heap_pages() will try to merge pages with the successor/predecessor if pages are suitably aligned. So if the pages reserved are right next to the pages given to the heap allocator, free_heap_pages() will merge them, and give the reserved pages to heap allocator accidently as a result. So in order to avoid the above scenario, this commit updates free_heap_pages() to check whether the predecessor and/or successor has PGC_reserved set, when trying to merge the about-to-be-freed chunk with the predecessor and/or successor. Suggested-by: Julien Grall Signed-off-by: Penny Zheng Reviewed-by: Jan Beulich Reviewed-by: Julien Grall --- v9 changes: - no change --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - adapt to PGC_static --- v5 changes: - change PGC_reserved to adapt to PGC_staticmem --- v4 changes: - no changes --- v3 changes: - no changes --- v2 changes: - new commit --- xen/common/page_alloc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index a12622e921..45bd88a685 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1475,6 +1475,7 @@ static void free_heap_pages( /* Merge with predecessor block? */ if ( !mfn_valid(page_to_mfn(predecessor)) || !page_state_is(predecessor, free) || + (predecessor->count_info & PGC_static) || (PFN_ORDER(predecessor) != order) || (phys_to_nid(page_to_maddr(predecessor)) != node) ) break; @@ -1498,6 +1499,7 @@ static void free_heap_pages( /* Merge with successor block? */ if ( !mfn_valid(page_to_mfn(successor)) || !page_state_is(successor, free) || + (successor->count_info & PGC_static) || (PFN_ORDER(successor) != order) || (phys_to_nid(page_to_maddr(successor)) != node) ) break; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371337.603223 (Exim 4.92) (envelope-from ) id 1oE2Xo-0007pI-4O; Wed, 20 Jul 2022 05:46:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371337.603223; Wed, 20 Jul 2022 05:46:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xn-0007p5-Vw; Wed, 20 Jul 2022 05:46:47 +0000 Received: by outflank-mailman (input) for mailman id 371337; Wed, 20 Jul 2022 05:46:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xm-0006VQ-UN for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 57074302-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:46 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C0A5D1042; Tue, 19 Jul 2022 22:46:45 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 626333F70D; Tue, 19 Jul 2022 22:46:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57074302-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v9 4/8] xen: add field "flags" to cover all internal CDF_XXX Date: Wed, 20 Jul 2022 13:46:07 +0800 Message-Id: <20220720054611.2695787-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit With more and more CDF_xxx internal flags in and to save the space, this commit introduces a new field "flags" in struct domain to store CDF_* internal flags directly. Another new CDF_xxx will be introduced in the next patch. Signed-off-by: Penny Zheng Acked-by: Julien Grall --- v9 changes: - no change --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - no change --- v5 changes: - no change --- v4 changes: - no change --- v3 changes: - change fixed width type uint32_t to unsigned int - change "flags" to a more descriptive name "cdf" --- v2 changes: - let "flags" live in the struct domain. So other arch can take advantage of it in the future - fix coding style --- xen/arch/arm/domain.c | 2 -- xen/arch/arm/include/asm/domain.h | 3 +-- xen/common/domain.c | 3 +++ xen/include/xen/sched.h | 3 +++ 4 files changed, 7 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b5..4722988ee7 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -709,8 +709,6 @@ int arch_domain_create(struct domain *d, ioreq_domain_init(d); #endif - d->arch.directmap = flags & CDF_directmap; - /* p2m_init relies on some value initialized by the IOMMU subsystem */ if ( (rc = iommu_domain_init(d, config->iommu_opts)) != 0 ) goto fail; diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h index cd9ce19b4b..26a8348eed 100644 --- a/xen/arch/arm/include/asm/domain.h +++ b/xen/arch/arm/include/asm/domain.h @@ -29,7 +29,7 @@ enum domain_type { #define is_64bit_domain(d) (0) #endif -#define is_domain_direct_mapped(d) (d)->arch.directmap +#define is_domain_direct_mapped(d) ((d)->cdf & CDF_directmap) /* * Is the domain using the host memory layout? @@ -104,7 +104,6 @@ struct arch_domain void *tee; #endif - bool directmap; } __cacheline_aligned; struct arch_vcpu diff --git a/xen/common/domain.c b/xen/common/domain.c index 618410e3b2..7062393e37 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -567,6 +567,9 @@ struct domain *domain_create(domid_t domid, /* Sort out our idea of is_system_domain(). */ d->domain_id = domid; + /* Holding CDF_* internal flags. */ + d->cdf = flags; + /* Debug sanity. */ ASSERT(is_system_domain(d) ? config == NULL : config != NULL); diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index b9515eb497..98e8001c89 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -596,6 +596,9 @@ struct domain struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; } ioreq_server; #endif + + /* Holding CDF_* constant. Internal flags for domain creation. */ + unsigned int cdf; }; static inline struct page_list_head *page_to_list( -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371340.603234 (Exim 4.92) (envelope-from ) id 1oE2Xs-0008FY-EF; Wed, 20 Jul 2022 05:46:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371340.603234; Wed, 20 Jul 2022 05:46:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xs-0008FK-9D; Wed, 20 Jul 2022 05:46:52 +0000 Received: by outflank-mailman (input) for mailman id 371340; Wed, 20 Jul 2022 05:46:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xr-0006VQ-3N for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 599e7393-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2AADE1042; Tue, 19 Jul 2022 22:46:50 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C1A973F70D; Tue, 19 Jul 2022 22:46:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 599e7393-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v9 5/8] xen/arm: introduce CDF_staticmem Date: Wed, 20 Jul 2022 13:46:08 +0800 Message-Id: <20220720054611.2695787-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In order to have an easy and quick way to find out whether this domain memory is statically configured, this commit introduces a new flag CDF_staticmem and a new helper is_domain_using_staticmem() to tell. Signed-off-by: Penny Zheng Acked-by: Julien Grall Acked-by: Jan Beulich --- v9 changes: - no change --- v8 changes: - #ifdef-ary around is_domain_using_staticmem() is not needed anymore --- v7 changes: - IS_ENABLED(CONFIG_STATIC_MEMORY) would not be needed anymore --- v6 changes: - move non-zero is_domain_using_staticmem() from ARM header to common header --- v5 changes: - guard "is_domain_using_staticmem" under CONFIG_STATIC_MEMORY - #define is_domain_using_staticmem zero if undefined --- v4 changes: - no changes --- v3 changes: - change name from "is_domain_static()" to "is_domain_using_staticmem" --- v2 changes: - change name from "is_domain_on_static_allocation" to "is_domain_static()" --- xen/arch/arm/domain_build.c | 5 ++++- xen/include/xen/domain.h | 8 ++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..b76a84e8f5 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3287,9 +3287,12 @@ void __init create_domUs(void) if ( !dt_device_is_compatible(node, "xen,domain") ) continue; + if ( dt_find_property(node, "xen,static-mem", NULL) ) + flags |= CDF_staticmem; + if ( dt_property_read_bool(node, "direct-map") ) { - if ( !IS_ENABLED(CONFIG_STATIC_MEMORY) || !dt_find_property(node, "xen,static-mem", NULL) ) + if ( !(flags & CDF_staticmem) ) panic("direct-map is not valid for domain %s without static allocation.\n", dt_node_name(node)); diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h index 628b14b086..2c8116afba 100644 --- a/xen/include/xen/domain.h +++ b/xen/include/xen/domain.h @@ -35,6 +35,14 @@ void arch_get_domain_info(const struct domain *d, /* Should domain memory be directly mapped? */ #define CDF_directmap (1U << 1) #endif +/* Is domain memory on static allocation? */ +#ifdef CONFIG_STATIC_MEMORY +#define CDF_staticmem (1U << 2) +#else +#define CDF_staticmem 0 +#endif + +#define is_domain_using_staticmem(d) ((d)->cdf & CDF_staticmem) /* * Arch-specifics. -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:46:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:46:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371349.603245 (Exim 4.92) (envelope-from ) id 1oE2Xw-0000UT-Nu; Wed, 20 Jul 2022 05:46:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371349.603245; Wed, 20 Jul 2022 05:46:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xw-0000UE-KA; Wed, 20 Jul 2022 05:46:56 +0000 Received: by outflank-mailman (input) for mailman id 371349; Wed, 20 Jul 2022 05:46:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xu-0006VQ-T4 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:55 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5bc75a6d-07ef-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 07:46:53 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C01B41042; Tue, 19 Jul 2022 22:46:53 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 2B6553F70D; Tue, 19 Jul 2022 22:46:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bc75a6d-07ef-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static Date: Wed, 20 Jul 2022 13:46:09 +0800 Message-Id: <20220720054611.2695787-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Today when a domain unpopulates the memory on runtime, they will always hand the memory back to the heap allocator. And it will be a problem if domain is static. Pages as guest RAM for static domain shall be reserved to only this domain and not be used for any other purposes, so they shall never go back to heap allocator. This commit puts reserved pages on the new list resv_page_list only after having taken them off the "normal" list, when the last ref dropped. Signed-off-by: Penny Zheng --- v9 change: - remove macro helper put_static_page, and just expand its code inside free_domstatic_page --- v8 changes: - adapt this patch for newly introduced free_domstatic_page - order as a parameter is not needed here, as all staticmem operations are limited to order-0 regions - move d->page_alloc_lock after operation on d->resv_page_list --- v7 changes: - Add page on the rsv_page_list *after* it has been freed --- v6 changes: - refine in-code comment - move PGC_static !CONFIG_STATIC_MEMORY definition to common header --- v5 changes: - adapt this patch for PGC_staticmem --- v4 changes: - no changes --- v3 changes: - have page_list_del() just once out of the if() - remove resv_pages counter - make arch_free_heap_page be an expression, not a compound statement. --- v2 changes: - put reserved pages on resv_page_list after having taken them off the "normal" list --- xen/common/domain.c | 4 ++++ xen/common/page_alloc.c | 8 ++++++-- xen/include/xen/sched.h | 3 +++ 3 files changed, 13 insertions(+), 2 deletions(-) diff --git a/xen/common/domain.c b/xen/common/domain.c index 7062393e37..c23f449451 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -604,6 +604,10 @@ struct domain *domain_create(domid_t domid, INIT_PAGE_LIST_HEAD(&d->page_list); INIT_PAGE_LIST_HEAD(&d->extra_page_list); INIT_PAGE_LIST_HEAD(&d->xenpage_list); +#ifdef CONFIG_STATIC_MEMORY + INIT_PAGE_LIST_HEAD(&d->resv_page_list); +#endif + spin_lock_init(&d->node_affinity_lock); d->node_affinity = NODE_MASK_ALL; diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 45bd88a685..a568be55e3 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2674,10 +2674,14 @@ void free_domstatic_page(struct page_info *page) drop_dom_ref = !domain_adjust_tot_pages(d, -1); - spin_unlock_recursive(&d->page_alloc_lock); - free_staticmem_pages(page, 1, scrub_debug); + /* Add page on the resv_page_list *after* it has been freed. */ + if ( !drop_dom_ref ) + page_list_add_tail(page, &d->resv_page_list); + + spin_unlock_recursive(&d->page_alloc_lock); + if ( drop_dom_ref ) put_domain(d); } diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index 98e8001c89..d4fbd3dea7 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -381,6 +381,9 @@ struct domain struct page_list_head page_list; /* linked list */ struct page_list_head extra_page_list; /* linked list (size extra_pages) */ struct page_list_head xenpage_list; /* linked list (size xenheap_pages) */ +#ifdef CONFIG_STATIC_MEMORY + struct page_list_head resv_page_list; /* linked list */ +#endif /* * This field should only be directly accessed by domain_adjust_tot_pages() -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:47:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:47:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371354.603256 (Exim 4.92) (envelope-from ) id 1oE2Y0-0000xF-9A; Wed, 20 Jul 2022 05:47:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371354.603256; Wed, 20 Jul 2022 05:47:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Y0-0000x6-4H; Wed, 20 Jul 2022 05:47:00 +0000 Received: by outflank-mailman (input) for mailman id 371354; Wed, 20 Jul 2022 05:46:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Xy-0006lV-SD for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:46:58 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 5e165305-07ef-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 07:46:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A154D1042; Tue, 19 Jul 2022 22:46:57 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C18A13F70D; Tue, 19 Jul 2022 22:46:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5e165305-07ef-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng , Julien Grall Subject: [PATCH v9 7/8] xen: introduce prepare_staticmem_pages Date: Wed, 20 Jul 2022 13:46:10 +0800 Message-Id: <20220720054611.2695787-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we want to use acquire_domstatic_pages() for populating memory for static domain on runtime, however, there are a lot of pointless work (checking mfn_valid(), scrubbing the free part, cleaning the cache...) considering we know the page is valid and belong to the guest. This commit splits acquire_staticmem_pages() in two parts, and introduces prepare_staticmem_pages to bypass all "pointless work". Signed-off-by: Penny Zheng Acked-by: Jan Beulich Acked-by: Julien Grall --- v8 changes: - no change --- v7 changes: - no change --- v6 changes: - adapt to PGC_static --- v5 changes: - new commit --- xen/common/page_alloc.c | 61 ++++++++++++++++++++++++----------------- 1 file changed, 36 insertions(+), 25 deletions(-) diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index a568be55e3..9e150946f9 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2686,26 +2686,13 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -/* - * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of - * static memory. - * This function needs to be reworked if used outside of boot. - */ -static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, - unsigned long nr_mfns, - unsigned int memflags) +static bool __init prepare_staticmem_pages(struct page_info *pg, + unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; unsigned long i; - struct page_info *pg; - - ASSERT(nr_mfns); - for ( i = 0; i < nr_mfns; i++ ) - if ( !mfn_valid(mfn_add(smfn, i)) ) - return NULL; - - pg = mfn_to_page(smfn); spin_lock(&heap_lock); @@ -2716,7 +2703,7 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, { printk(XENLOG_ERR "pg[%lu] Static MFN %"PRI_mfn" c=%#lx t=%#x\n", - i, mfn_x(smfn) + i, + i, mfn_x(page_to_mfn(pg)) + i, pg[i].count_info, pg[i].tlbflush_timestamp); goto out_err; } @@ -2740,6 +2727,38 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, if ( need_tlbflush ) filtered_flush_tlb_mask(tlbflush_timestamp); + return true; + + out_err: + while ( i-- ) + pg[i].count_info = PGC_static | PGC_state_free; + + spin_unlock(&heap_lock); + + return false; +} + +/* + * Acquire nr_mfns contiguous reserved pages, starting at #smfn, of + * static memory. + * This function needs to be reworked if used outside of boot. + */ +static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, + unsigned long nr_mfns, + unsigned int memflags) +{ + unsigned long i; + struct page_info *pg; + + ASSERT(nr_mfns); + for ( i = 0; i < nr_mfns; i++ ) + if ( !mfn_valid(mfn_add(smfn, i)) ) + return NULL; + + pg = mfn_to_page(smfn); + if ( !prepare_staticmem_pages(pg, nr_mfns, memflags) ) + return NULL; + /* * Ensure cache and RAM are consistent for platforms where the guest * can control its own visibility of/through the cache. @@ -2748,14 +2767,6 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, flush_page_to_ram(mfn_x(smfn) + i, !(memflags & MEMF_no_icache_flush)); return pg; - - out_err: - while ( i-- ) - pg[i].count_info = PGC_static | PGC_state_free; - - spin_unlock(&heap_lock); - - return NULL; } /* -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 05:47:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 05:47:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371359.603267 (Exim 4.92) (envelope-from ) id 1oE2Y4-0001X6-JS; Wed, 20 Jul 2022 05:47:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371359.603267; Wed, 20 Jul 2022 05:47:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Y4-0001Wt-D8; Wed, 20 Jul 2022 05:47:04 +0000 Received: by outflank-mailman (input) for mailman id 371359; Wed, 20 Jul 2022 05:47:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2Y3-0006lV-1O for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 05:47:03 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 6031bed4-07ef-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 07:47:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 429901042; Tue, 19 Jul 2022 22:47:01 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A1FED3F7D7; Tue, 19 Jul 2022 22:46:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6031bed4-07ef-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: wei.chen@arm.com, Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap Date: Wed, 20 Jul 2022 13:46:11 +0800 Message-Id: <20220720054611.2695787-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220720054611.2695787-1-Penny.Zheng@arm.com> References: <20220720054611.2695787-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When a static domain populates memory through populate_physmap at runtime, it shall retrieve reserved pages from resv_page_list to make sure that guest RAM is still restricted in statically configured memory regions. This commit also introduces a new helper acquire_reserved_page to make it work. Signed-off-by: Penny Zheng --- v9 changes: - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page - Add free_staticmem_pages to undo prepare_staticmem_pages when assign_domstatic_pages fails - Remove redundant static in error message --- v8 changes: - As concurrent free/allocate could modify the resv_page_list, we still need the lock --- v7 changes: - remove the lock, since we add the page to rsv_page_list after it has been totally freed. --- v6 changes: - drop the lock before returning --- v5 changes: - extract common codes for assigning pages into a helper assign_domstatic_pages - refine commit message - remove stub function acquire_reserved_page - Alloc/free of memory can happen concurrently. So access to rsv_page_list needs to be protected with a spinlock --- v4 changes： - miss dropping __init in acquire_domstatic_pages - add the page back to the reserved list in case of error - remove redundant printk - refine log message and make it warn level --- v3 changes: - move is_domain_using_staticmem to the common header file - remove #ifdef CONFIG_STATIC_MEMORY-ary - remove meaningless page_to_mfn(page) in error log --- v2 changes: - introduce acquire_reserved_page to retrieve reserved pages from resv_page_list - forbid non-zero-order requests in populate_physmap - let is_domain_static return ((void)(d), false) on x86 --- xen/common/memory.c | 23 +++++++++++++ xen/common/page_alloc.c | 74 +++++++++++++++++++++++++++++++---------- xen/include/xen/mm.h | 1 + 3 files changed, 81 insertions(+), 17 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index f6f794914d..d486ebd8b9 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -245,6 +245,29 @@ static void populate_physmap(struct memop_args *a) mfn = _mfn(gpfn); } + else if ( is_domain_using_staticmem(d) ) + { + /* + * No easy way to guarantee the retrieved pages are contiguous, + * so forbid non-zero-order requests here. + */ + if ( a->extent_order != 0 ) + { + gdprintk(XENLOG_WARNING, + "Cannot allocate static order-%u pages for %pd\n", + a->extent_order, d); + goto out; + } + + mfn = acquire_reserved_page(d, a->memflags); + if ( mfn_eq(mfn, INVALID_MFN) ) + { + gdprintk(XENLOG_WARNING, + "%pd: failed to retrieve a reserved page\n", + d); + goto out; + } + } else { page = alloc_domheap_pages(d, a->extent_order, a->memflags); diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c index 9e150946f9..3414189432 100644 --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -2686,9 +2686,8 @@ void free_domstatic_page(struct page_info *page) put_domain(d); } -static bool __init prepare_staticmem_pages(struct page_info *pg, - unsigned long nr_mfns, - unsigned int memflags) +static bool prepare_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, + unsigned int memflags) { bool need_tlbflush = false; uint32_t tlbflush_timestamp = 0; @@ -2769,21 +2768,9 @@ static struct page_info * __init acquire_staticmem_pages(mfn_t smfn, return pg; } -/* - * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, - * then assign them to one specific domain #d. - */ -int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, - unsigned int nr_mfns, unsigned int memflags) +static int assign_domstatic_pages(struct domain *d, struct page_info *pg, + unsigned int nr_mfns, unsigned int memflags) { - struct page_info *pg; - - ASSERT_ALLOC_CONTEXT(); - - pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); - if ( !pg ) - return -ENOENT; - if ( !d || (memflags & (MEMF_no_owner | MEMF_no_refcount)) ) { /* @@ -2802,6 +2789,59 @@ int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, return 0; } + +/* + * Acquire nr_mfns contiguous pages, starting at #smfn, of static memory, + * then assign them to one specific domain #d. + */ +int __init acquire_domstatic_pages(struct domain *d, mfn_t smfn, + unsigned int nr_mfns, unsigned int memflags) +{ + struct page_info *pg; + + ASSERT_ALLOC_CONTEXT(); + + pg = acquire_staticmem_pages(smfn, nr_mfns, memflags); + if ( !pg ) + return -ENOENT; + + if ( assign_domstatic_pages(d, pg, nr_mfns, memflags) ) + return -EINVAL; + + return 0; +} + +/* + * Acquire a page from reserved page list(resv_page_list), when populating + * memory for static domain on runtime. + */ +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) +{ + struct page_info *page; + + ASSERT_ALLOC_CONTEXT(); + + /* Acquire a page from reserved page list(resv_page_list). */ + spin_lock(&d->page_alloc_lock); + page = page_list_remove_head(&d->resv_page_list); + spin_unlock(&d->page_alloc_lock); + if ( unlikely(!page) ) + return INVALID_MFN; + + if ( !prepare_staticmem_pages(page, 1, memflags) ) + goto fail; + + if ( assign_domstatic_pages(d, page, 1, memflags) ) + goto fail_assign; + + return page_to_mfn(page); + + fail_assign: + free_staticmem_pages(page, 1, memflags & MEMF_no_scrub); + fail: + page_list_add_tail(page, &d->resv_page_list); + return INVALID_MFN; +} #endif /* diff --git a/xen/include/xen/mm.h b/xen/include/xen/mm.h index f1a7d5c991..9ea87d2199 100644 --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -198,6 +198,7 @@ struct npfec { #else #define MAX_ORDER 20 /* 2^20 contiguous pages */ #endif +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags); /* Private domain structs for DOMID_XEN, DOMID_IO, etc. */ extern struct domain *dom_xen, *dom_io; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 06:07:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 06:07:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371394.603278 (Exim 4.92) (envelope-from ) id 1oE2ru-0005q5-Bb; Wed, 20 Jul 2022 06:07:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371394.603278; Wed, 20 Jul 2022 06:07:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2ru-0005py-8L; Wed, 20 Jul 2022 06:07:34 +0000 Received: by outflank-mailman (input) for mailman id 371394; Wed, 20 Jul 2022 06:07:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2rs-0005pn-5V; Wed, 20 Jul 2022 06:07:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2rs-00019E-1L; Wed, 20 Jul 2022 06:07:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE2rr-00042M-MM; Wed, 20 Jul 2022 06:07:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE2rr-0006bv-Lu; Wed, 20 Jul 2022 06:07:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VSwla7JCP7XQxrWgS2BWjbWoUIIILEGIwr1wCtrLB1k=; b=HWi+3Y/hCxCJF10hyjzya2zT40 fcd1D5jdRkFzniZDdUpGsFr5ELnBxs9fik0lRMaQKeYRvlXbHOmcPA333+glUuX9zK9RJJ6B6QeKL 1QLep/GB3PaT8uWF6HNhTfCEBJ6Eq1D9MsSwxqmnSBlH9Z+zf6x5szEWkbGfatBQ/raM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171695: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf X-Osstest-Versions-That: xen=0e60f1d9d1970cae49ee9d03f5759f44afc1fdee From: osstest service owner Date: Wed, 20 Jul 2022 06:07:31 +0000 flight 171695 xen-unstable real [real] flight 171701 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171695/ http://logs.test-lab.xenproject.org/osstest/logs/171701/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail pass in 171701-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171678 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171678 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171678 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171678 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171678 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171678 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171678 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171678 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171678 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf baseline version: xen 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee Last test of basis 171678 2022-07-19 03:09:55 Z 1 days Failing since 171686 2022-07-19 11:07:05 Z 0 days 2 attempts Testing same since 171695 2022-07-19 22:37:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Elliott Mitchell Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair fail test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0e60f1d9d1..c16a9eda77 c16a9eda77b2089206d5bc39ab6488c3793e11bf -> master From xen-devel-bounces@lists.xenproject.org Wed Jul 20 06:47:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 06:47:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371413.603320 (Exim 4.92) (envelope-from ) id 1oE3UT-0002vX-Vi; Wed, 20 Jul 2022 06:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371413.603320; Wed, 20 Jul 2022 06:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE3UT-0002vQ-RY; Wed, 20 Jul 2022 06:47:25 +0000 Received: by outflank-mailman (input) for mailman id 371413; Wed, 20 Jul 2022 06:47:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE3US-0002vG-5x; Wed, 20 Jul 2022 06:47:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE3UR-0001qj-S3; Wed, 20 Jul 2022 06:47:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE3UR-0004xQ-8e; Wed, 20 Jul 2022 06:47:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE3UR-0006NO-8B; Wed, 20 Jul 2022 06:47:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hxfEX8hXaWjiXSSqWDN/yTezBdrWJ6c0w8dSAC8qYbI=; b=ZntNKhFUPAQ+E38v2iz5EuiNZS ykMX6TkmtVTYx2wqeLwgJc8ScASuytldRiXqM0lEY7Q88AAVVsce3VyFzpqcZKvRGB3yUzH4RXiy3 ziW55tedYz2KvybFRhUxbwuMcBSwp9GZU7xvNHugIBPFg0TagTz5A+JI/qbXWGn3geHE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171700: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=f52dbac93f146e5a80d5d27b2db1d3549d6580ef X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 20 Jul 2022 06:47:23 +0000 flight 171700 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171700/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt f52dbac93f146e5a80d5d27b2db1d3549d6580ef baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 740 days Failing since 151818 2020-07-11 04:18:52 Z 739 days 721 attempts Testing same since 171700 2022-07-20 04:18:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116278 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 20 07:27:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 07:27:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371421.603330 (Exim 4.92) (envelope-from ) id 1oE46v-0007xX-UH; Wed, 20 Jul 2022 07:27:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371421.603330; Wed, 20 Jul 2022 07:27:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE46v-0007xQ-Rd; Wed, 20 Jul 2022 07:27:09 +0000 Received: by outflank-mailman (input) for mailman id 371421; Wed, 20 Jul 2022 07:27:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE46u-0007xK-IY for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 07:27:08 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10073.outbound.protection.outlook.com [40.107.1.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5bb74eba-07fd-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 09:27:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8451.eurprd04.prod.outlook.com (2603:10a6:20b:347::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 07:27:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 07:27:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5bb74eba-07fd-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pk8j8xdqh16rT+vy+lRDLwkkGUNRKtmhGhtOo37kSZtZME8eSDPV3dzKXVyIc0eAj7DT5xa7qEAhdGMUP6U+s2UtI5fYV58D+xC0KMizRoxtJ4cG+fHPGkb2CZ4bBr9qUN3wxSTO0cbxNBed0t9HsICmvqf2nzULOKvA6Pfd7zQyu62yL1dKzeWoV/ccz3sCQHGTx+FsQ7yKhWW6FafZkKJmfNLtCuOPKPe45EvRr5Ud0OYuB1So4Piych++9yRh2kMPQQtXg9bbii0rxvXerOcgUlaFwtxFqJKpjGmCPnoZGdMXXB4MaIMclXKYO1HSl9x8MNF3MJo3Sj1cnIdOyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+wej7D2PPP022yB4o0M5gh/c5kG3KcO0qdL9cLY/AVQ=; b=Po4L7lMt/enePW1gLUD/4A5CjhH2a4lYSa5OhozSKViFgb8eGk/yqLK5xY6myap3QmPX249Qe8upTvC4YxFwlxy7o+QwKBF8FVzRLC3hu+nczcQdN/3Z3pc+8HsG+IbssLnYRCIO4zIAdfOzJYrhJsKtCDGm9NQzt410yJWJ3VRzMENaNHwRVgz3C4epBSwhzYLX49bmt/i1pFjgQAf0DcT5dJ+gZ93i8GCdQ/yptirqBMln6v0VJ5qBDAJpV+pbmKNaoR3oWi6Ww/C/Pv5+EIMhHWyZgxoeHh9uNYiatugkIttC/qsRoYvB1IEgSNMDNh6DyYi/qTOCox5Buk63+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+wej7D2PPP022yB4o0M5gh/c5kG3KcO0qdL9cLY/AVQ=; b=P25nkh4xSg8bc2pjbC2OVk+uxAbwx6dFgsjN8djED7CIkVaGsypM8KwepSSegvKbQD5Vi5NVfwUDFx9aNqcl8nJ4LL5LxE4yM+YMN/ZAG6iL7PHWp789tKi6hA9YTbWTlc93Xjocyp2HwVq+xIgN+hTYCOavivgbeiA+8+BdEGStqN6gBFtDhBEN+nlwxTO4M2TkgReCqL1o2SsYNTCte8tO36buM8YZKPVIWL1npRXHdjwzGbeeGamcMDBEfn0jPLzkdrANedlhASg5btU4FTZ9Q3uMfBvohS5NEEp1q35lxHp98UScEbF1Uh6dqfBKqwVrRY4VPZZDAoSO/Jc9BA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6cc461b1-e308-0e2f-3f78-caf491095042@suse.com> Date: Wed, 20 Jul 2022 09:27:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> <59114d3a-b9fe-1fb0-fac3-fe14fe4c505f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR0301CA0014.eurprd03.prod.outlook.com (2603:10a6:206:14::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 68c8f107-7383-4c01-daef-08da6a213ec5 X-MS-TrafficTypeDiagnostic: AS8PR04MB8451:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: F64ABYfzKj7z/DAjj38jBzo98Z8doe1wGc4Uve68kglwjyi7dtYDqDacTOEtlqYp8kA4HPQmeAcqCquKp+CmbS5l050f+ZvM6LE3XtuuQXj3hDhC57OdHJ+UGb1LkdDmLHRdMda5mxTf9T+EO+q8Py83eyado8LMmhaJKWLxOTEgK/rnnYKnCEtM2xRODxI1/wZvmsdoKc1gVQThae0QmdIu593/EaIFQgSpHpqD0aiDch1MX1zY+3C4uU7mQZcqtAL512ALOkkq3Likdc/4bP7TKuHkxR0l69hece/Z43IXq79WMJs1rYwpPhZXbQvQKeiSant9BNzpgzIUOmlOKzXYYgC6vwxhaQC3exkCVA9zzrZ9R0zv+BH2gohvlZCoVHG+wtBhJZ12aJs8E+xnINiQLNnJy/vSJEp4eeqSGCLhv29JoiCcTorkvJHnMVfSsnEyCBjpe0lvbY0bYTem2p4uxGQDyKj8GYm0WSM/GntVJos1S0MwaNKjSta9ZfUuu27IYVZy5Z5WBuKZkiHV9OcKkvc+a7MYKjLXPstjomrU8eYplY2zRyNCwgJcIwG2fH8yMdAov5gLsdb0p8DlYdS9zlM7Y3tsqJETlvXlwxzhtM5ihhVN1G1oUmi5k5uXFK9YzVPfKaTRe7IS/FyUdm/j/BqO9YhJ43myvagCEIAFUkvVCWGTvS5VzxHhTe2x05A+qctNf03hPaE4Wt1spNJxa27UAy6TPEHjgyZv4vHxnXFMYD1I6PyQXSH3EjBk8UYT2EsIwVlX7QVHgZX37Z9EnpeJ4J5jr0TGMuseU1cX/UB3AKXGed1Ggz+Df0xOynMJ55ZEPJbPIUxJoqm0aA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(39860400002)(376002)(366004)(186003)(6512007)(2616005)(66946007)(83380400001)(316002)(6916009)(5660300002)(66556008)(66476007)(4326008)(8936002)(8676002)(36756003)(54906003)(7416002)(478600001)(6486002)(6506007)(53546011)(41300700001)(26005)(2906002)(31686004)(86362001)(31696002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjhQTTE1ejhuRFR4ajB6elVsZlFSSjdOa3NPRC9yVUxCUVhyQ0hRMUFGbzh1?= =?utf-8?B?cEIxdER4VC9rTU9WOGlYTWpyc2dQSWVrWmhmTldjNSt6amFDbFAyQ2tUZ2Nu?= =?utf-8?B?aVpWNmxxbGRPd1NIYUpRcVJkQ2lvUWhTU3NmNlhkZlpzRFBlTkk5RzJWYjBj?= =?utf-8?B?SGZ3cWxOdWVVREFJYUp4RFB1QnRUQ2FSa3pPVEpodkliWTFNZ0pFRCswdmQ0?= =?utf-8?B?V1RuaUNUSWM2MjYwTG53WHlFdEFnQzVpaSs2RTRrTEJkOXc1SVZvWG02OVlv?= =?utf-8?B?WER5aTkvYjJ3cXA4a2NNWE10YWFZQ0FCeFdPbzZsdnRVb3kzY1dCekthZTJY?= =?utf-8?B?UTNUN2pNZmwvWnBWSUE3ck5WczNYbjRYQWt1V3JlQWRUdGFXOG9aTzhXSEpO?= =?utf-8?B?VW51Z2tTUVA5RnBUd2s2bm9pZVNCdjZkK2dab1pET2RYb25IM2YxaU9qSEt5?= =?utf-8?B?c0VoQkhISVp2ZThjeWUyTnNtaVlobm1vS3VuMnAzRnBwZ05NNXU0YUtUcjFP?= =?utf-8?B?RFVwdXdPUG5udVhISk84Vm1HdjBod2JTOU5MakdNR1dMTkJ5TTJmZWN2blFK?= =?utf-8?B?cFV4MGRYSVVBNGtuUEN1TjAzR1BQNFZMWHFGVzd1anpLZlRVcjVuVzMrOFFi?= =?utf-8?B?aXhzcFFYNXBCU1BjL2R1UUpkRjJnQ084S3JsMC82eUhKM243NTVCSitOSEpt?= =?utf-8?B?Z1NoNGh6bzI4S0s2UnNSRStBRUpHUkl5Y2ZHMGtmTGF5ME1ldmxlVHYvVm9v?= =?utf-8?B?ejlLSXlMMmZVOTVKOE5TMzFRME5Xb1lSclIwWXplbkg2ZVhSaVl4SnhReHE2?= =?utf-8?B?dkZKQ2NzRDVsSU9wdW80Q1dNYmwycDc5QW1VOHF6WWRXL2srSGtGVVF5NEJy?= =?utf-8?B?UEorMlg4dG9pMiszcFlQSUtrMFQ3aWVYWW1Yb2d2L2xlcjFDN2ZISlQ5TU1M?= =?utf-8?B?RVBwWG5UQ1hkOXJFeFhhZDJheGN4aVViMFN4KzY1M3VteXRGVlJMUlJ5cmdT?= =?utf-8?B?NE9kWFRDMXBOQnF6VkRlNUYvMFo5TjJzb1RSK2xGSForbitFN1pnd2lhVVBW?= =?utf-8?B?VTNJVmZ0MTh1UHhXVGFzU3lIYzNjUU1lQnF5c3E1ZmRvaDhlWGorMVB1aWJ0?= =?utf-8?B?U1JqNTFjTXRUa0lTMy9TSkdrVEE4Qm1acFJCQTBTeG5waHJFVm1scXBCaFk2?= =?utf-8?B?YVNYRjIxLzBFOXBrTWpkLzhoS1lhYU5wRVY0NVljSmdWVWNhYjVVbjZMVlRJ?= =?utf-8?B?d2UxM3krRUFOakhUUGN5enFIL2NDbU5iWmQwUi93aXdOaDY5ZmplM0k0em5x?= =?utf-8?B?TkJqdzRsRTBwWk9jeFU1MjAvcWhzb1lMSUllcEs5bDdlVktRMkJndHJlMDUv?= =?utf-8?B?a0ZKbFBXbkFPOC83UkhsdlorNllPaGQ3elNYb1hYbkZtN1Z6T3JIMk5pekow?= =?utf-8?B?S0N5aG5LRkRETTB2YUlXb3piaHJ1OTAva0tIQVRKUzNoZWZ5c3AwT0doS2hF?= =?utf-8?B?RnpCeEN1Z2lUcStNbzhCZ0E1ZHB3QU1OSzR0S1pNRElrS3lkQy9YKys4Z3BG?= =?utf-8?B?UGhxNXlWZFVSdkNKZ25WRFZYMitBaTYzb1FBdm1zcTgvR0lQQk9YNlk1ZVBO?= =?utf-8?B?Y2o2bzhIbk1KUGZFU3pHOXUzZHRiWitlYXNWdjlJQVJaU3RnemZRVkFGZUMy?= =?utf-8?B?VExUQ0dBM21LWXhtNWRBUnpsdEFiRXNsa0daZVB1elBVRzBMR1YxcHdYVFFs?= =?utf-8?B?Y0twVHVrbVExQ2YyZVBQbnZPNEpvUk5PZ0F6S1RPT204NlhzMXJaM210VDlJ?= =?utf-8?B?a3VzMzgwNGxMM25uVGJMY3ZtdUtiOFUvTVg0aWhEazE5NWlzVDlDUms4dGhi?= =?utf-8?B?VEJoc21RTVBxNHhISmE5UUxNeDMyZ1IyNVljUk9PSm9WWUJieWIrWDFqZ3F2?= =?utf-8?B?UDJuU1FSLzlvK01EdWMrYXFsVTBGTllmVjBBM1JSVTU4N0ZVL1Y4c21weklx?= =?utf-8?B?czNPOXd3emkyZ1lieGxRMWtSM0htb3VRUVljVHhtTXpwbVJPNWgvcnJPRUVD?= =?utf-8?B?UFNMZUpuZ2UrK2tMc25MeG9aaTlJWXRFbFR2RzdwRWhKWjZ0S2JlZC9Ya0oz?= =?utf-8?Q?uDNtNk54ECdpHn6tWrt0wckwP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 68c8f107-7383-4c01-daef-08da6a213ec5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 07:27:04.7371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 32X3kBWICBkgkVoTT0ZGwrEWJkDlyewrQtRvLOU8WB2E8N26wsF5zLXAIQXwOM4aCbwy0pUbqC9yhQk8xgYjlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8451 On 19.07.2022 19:02, Daniel P. Smith wrote: > On 7/19/22 05:32, Jan Beulich wrote: >> On 06.07.2022 23:04, Daniel P. Smith wrote: >>> --- a/xen/arch/x86/efi/efi-boot.h >>> +++ b/xen/arch/x86/efi/efi-boot.h >>> @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { >>> * The array size needs to be one larger than the number of modules we >>> * support - see __start_xen(). >>> */ >>> -static module_t __initdata mb_modules[5]; >>> +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; >> >> If the build admin selected 1, I'm pretty sure about nothing would work. >> I think you want max(5, CONFIG_NR_BOOTMODS) or >> max(4, CONFIG_NR_BOOTMODS) + 1 here and ... > > Actually, I reasoned this out and 1 is in fact a valid value. It would > mean Xen + Dom0 Linux kernel with embedded initramfs with no externally > loaded XSM policy and no boot time microcode patching. This is a working > configuration, but open to debate if it is a desirable configuration. > The question is whether it is desired to block someone from building > such a configuration, or any number between 1 and 4. If the answer is > yes, then why not just set the lower bound of the range in the Kconfig > file instead of having to maintain a hard-coded lower bound in a max > marco across multiple locations? While I'd be fine with the lower bounds being raised, I wouldn't be very happy with seeing those lower bounds becoming arch-specific. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 07:31:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 07:31:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371427.603341 (Exim 4.92) (envelope-from ) id 1oE4BX-0000vz-Fe; Wed, 20 Jul 2022 07:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371427.603341; Wed, 20 Jul 2022 07:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4BX-0000vs-D8; Wed, 20 Jul 2022 07:31:55 +0000 Received: by outflank-mailman (input) for mailman id 371427; Wed, 20 Jul 2022 07:31:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4BV-0000vi-V7; Wed, 20 Jul 2022 07:31:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4BV-0002bd-Tu; Wed, 20 Jul 2022 07:31:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4BV-0000Gh-JZ; Wed, 20 Jul 2022 07:31:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE4BV-0004ic-J8; Wed, 20 Jul 2022 07:31:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5mpJzztRJl4Q53W07jqEHuUWMDj/2VfI1zRZAnqxy90=; b=DYfHoyNaZhph6JeZDmizL0yiji J2O4WYcqyz07B1Ea1Y0EA7QbRRuz+obB/4NP1835R2DFYVqkpldFK3GbvaalThtnAj/eCEkzDG1pb WisNx4ukpjlX57RdX29HZtC5ycxfjX465baInXw0ipt6L3eRgr6vY+LAJqO0f4n8Jlik=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171696: tolerable FAIL - PUSHED X-Osstest-Failures: ovmf:test-amd64-i386-xl-qemuu-ovmf-amd64:xen-install:fail:heisenbug X-Osstest-Versions-This: ovmf=24eac4caf31afae48349af44588a52783c1819b8 X-Osstest-Versions-That: ovmf=671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d From: osstest service owner Date: Wed, 20 Jul 2022 07:31:53 +0000 flight 171696 ovmf real [real] flight 171699 ovmf real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171696/ http://logs.test-lab.xenproject.org/osstest/logs/171699/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-ovmf-amd64 7 xen-install fail pass in 171699-retest version targeted for testing: ovmf 24eac4caf31afae48349af44588a52783c1819b8 baseline version: ovmf 671b0cea510ad6de02ee9d6dbdf8f9bbb881f35d Last test of basis 171691 2022-07-19 19:12:59 Z 0 days Testing same since 171696 2022-07-19 22:40:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 671b0cea51..24eac4caf3 24eac4caf31afae48349af44588a52783c1819b8 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 20 08:03:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 08:03:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371441.603353 (Exim 4.92) (envelope-from ) id 1oE4g0-0005T1-Lr; Wed, 20 Jul 2022 08:03:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371441.603353; Wed, 20 Jul 2022 08:03:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4g0-0005Su-IT; Wed, 20 Jul 2022 08:03:24 +0000 Received: by outflank-mailman (input) for mailman id 371441; Wed, 20 Jul 2022 08:03:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4fy-0005Sl-AT for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 08:03:23 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 69a56ec7-0802-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 10:03:18 +0200 (CEST) Received: from pps.filterd (m0174680.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26K7hJVt014766; Wed, 20 Jul 2022 08:03:03 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2113.outbound.protection.outlook.com [104.47.17.113]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hdx6aahec-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 08:03:02 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by PR2PR03MB5305.eurprd03.prod.outlook.com (2603:10a6:101:1a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 08:02:56 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 08:02:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 69a56ec7-0802-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eDP/eit1/CtlAw72a/Q3Rwhja1Cv9wRil6Ig8DYh2hatc9KJ7ixXTH+jc0PuDmqLIPz9jBWY90ySUJAU3rAu8kJ8plfJLqZ8+NnrPVFeY8/tpuCX2aZCizZdvF0XMOrZRIJiVTwQMU5mATFolFQHJotK7NAsctVbcYqAadrJifTk4EsWuQcsblT5vVcXmBQlmSIGCNVeapgKU1SCDSPmwavJvGwozKwbrxecYC596jA4/ktLoSBZ27a56NJKHmnMLDO1oviu3qi5WTJHdjkWzmaEOlU26FSONKqYHLjDtzjwcQZXdA1/pjnyz7lpHuw+OA9bVohZsRbwzJNYql57gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wbQBGpzsw+6R98RuEswdayMd6mvjT4EDlbRQcHvYdI4=; b=HfzRtisNaiId5tyQTKV9egHdkpdFHi01X6bnOc9sgMYsAkC/VVrYgIhZJJRlmWjQdm4641xUcRF4ZyMDjTqoTDCavDeneVrRBX8FiMOmno4EN4W0x1VWNHd4YFJGAyPIhrkbZko9UWgUcVJ1RFAxVW50BJRghk2EBnyBeqa48vhNe6N1ERFTc5qgOJDZMAIMbbRZ2SKUcnPPjBeOxo8qf1uPyvqajHWPV1Yecr6Fk5IwAi7o18jWKr0aCffaxtnJtX8y75TQ998To05Muq00dBqQFy0qovBkCCVlRsI+qwHodi9MUUEezd9P5C/bAJeEaH7MUAKZFMKuRWo+43lomQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbQBGpzsw+6R98RuEswdayMd6mvjT4EDlbRQcHvYdI4=; b=F4PsHttlD4SjOL5rzyXQmUvxj5c3kCMnSzXF7Iely203uEs1azY/gudWuOHchlNtpKYbHdF5cUC4F2mNjJd1h19wMbiQUNqMEKS//+rPWHREz+FIZlqZQjE2j+cw0O7jA/91BokT8up2JroMYt/OSH0YcrLYPRkz8n1eX2INXlGoExrTcelWSDvHw25vMbgUdkZ6mzQwGLkAvYxcPa0IhHAFsOvB+e17UeCNi/g6+1DQiV+SdNMwEZQRMZPeR3pgiWiTo3NIWT28WnPsOoePHxoLrDYtgc3Uc9rP01vxqUltAlf9myE7cdh2jZpypUnLeu059QvdNp2uADWTN/H6yg== From: Oleksandr Tyshchenko To: Jiamei Xie , "xen-devel@lists.xenproject.org" CC: Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Julien Grall , Oleksandr Tyshchenko , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Thread-Topic: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Thread-Index: AQHYmTJwCB+meLO+00OCULSeAQjbpq2Gn1WAgABMgQA= Date: Wed, 20 Jul 2022 08:02:55 +0000 Message-ID: <7c71f903-e1d2-d744-bc8d-29bef2d96650@epam.com> References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> <20220716163745.28712-1-olekstysh@gmail.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60a5a361-0989-4ad3-8884-08da6a264121 x-ms-traffictypediagnostic: PR2PR03MB5305:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hT7kXkK+sQ2QOTOiXZ4buuKqWORmbOPXt4WP0dh/uPtBa/o8a4vT+aEgeRjwZWpUkyEObfxweYIQTp9d+m08XEn8/OwSZDDdY93/xfb+sbRL36iuiDOkj4rOYRX+cUrCD3N0fDBvbVRdRfo1BIu4nkjCeASgNL+yQMoM1avlTtGoI/qoClzU316IEUJiGLvCtDpxdJknL1YY3DguKloMzLhHZgHu5Ef84pafGRRc2inOrYrfZQRvDIYVrMoRDqJxQ321vPcKgSD5OXHwjgSNa0mk7d9W6zopLjgI9hkPG82l/s8T9hHadfwVwCF8ZODMuxPCsHSYak3RAuI8GFD1Dss0JdTu/ptIKzBsyLG2vrLRbOW+rF9Syqpr1Xi8R29ksXk47JAzgWHqqW70UjC8qUTbPJZr85A1AKfDlvOOgiphz+GbPNDGOceuUY5YEOJ+NBBndPMdcx1y1aEr7qhosTo762fHsBhKqP3LkZM0ATWIy4Iquu3GB4xVbFE8q8wjZhTyTwHbq6tn6fGVFIU7avCuqc88m22AViaMxgT96dMRRB/Y7i0xLdFSZiZRLxZYFzwWw8TfDQN7TteFCC1qvO86BQBmkF0liElljFoILtVQMYNNDJNy5Cc5dSjP34fgPF/a60x5NTBjwVH5JvsCE8NELURgWeFf264j6o309Ti5wbQqLOSHgwi1jFDSOSfjJ7n6hzIFynQZvplkj+ifuuwIh3UUW4rpjRiafkndsyKxHhEZT/kh+2siLQlGXlydL9e/ueBAuqy6IZa/bX3yWxfd4p0pC6kpHt4Xsh71VzJXyfYrlT9no7LApgFe2fqkt98oyVm6mCfMEI4L1NoOyg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(136003)(346002)(376002)(39860400002)(7416002)(8936002)(6486002)(478600001)(5660300002)(186003)(26005)(6512007)(55236004)(53546011)(2616005)(86362001)(31696002)(41300700001)(83380400001)(2906002)(30864003)(6506007)(122000001)(31686004)(36756003)(38100700002)(91956017)(38070700005)(316002)(8676002)(110136005)(4326008)(54906003)(66446008)(64756008)(66556008)(66476007)(66946007)(71200400001)(76116006)(45980500001)(579004)(559001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bmxYcW9vTUg4cVFpbk5SQWUvMlZnV0FyY2M0cEsxQ21nN08wRzRzWEFsR1hQ?= =?utf-8?B?bThYUE1TbHROb1hPUkg5MUYzM2RuSmdlTXV3Q25lZURUQzBBaFhKY1Nobksy?= =?utf-8?B?b2tjMUJtVkJmYkF1OFFKcFRpZmpUUHhZdzU0R0hjRDhyS3ltdFpkb0Rub1E5?= =?utf-8?B?SkJRRm45bHZFK0oyKzhscFhPeTdkZW5oUm5VWWxtNkpkYjZiWEM0UE5abW9q?= =?utf-8?B?TUpzdTdtTmkvM3c4YmhkcmpadHo0Y3VxOEdnRDhjTVBHMFBObHlYWnQrbmFM?= =?utf-8?B?eW5zUDdNcDZ6OXU4c2pWT3VacUZpQ3NSV2xGVEluTXloNk82UUdCMzQ4d0k0?= =?utf-8?B?a1RTTzhENS9scE5MWjVXbTVGdDZLRldySlNNUkR5bTJCODRQVkFnaEM3SW5W?= =?utf-8?B?UGV1WjQ5dFl1WkNjTy9jV1FGVGZDQkNPVmJhamc1dlhyUmhHZnhKK282TDF6?= =?utf-8?B?WUtCMXFxcE15c2FUMSsxNlJHb1NiWmpkdmp6NyswYllqR3MzYUdJNzhkaFhB?= =?utf-8?B?TlRwalAwN2pKZXJVUCtHNEZmazVBMGZwUVN2VDVKdFgrK3RieTgya25aUEp1?= =?utf-8?B?amVkQ0ZWelVrSC9sSlF1Ump0ZkxsdmhmbzN4bGpJSVdOY1JsTmsyUTlCNG1y?= =?utf-8?B?K1dVM21LYklXcng4SmxBSlhPM2VzcGdEdUhzQTZhZkhUMGY5OHBmODljUHZO?= =?utf-8?B?Rit4bFByVXAveGdPZ3RGUGVaVGNITkR3bjNoMW1lRTdScDVPaWNrN2I3L2pi?= =?utf-8?B?Qmw2dVgrN2d5ZlVNVkk2dVRteC9PUzFDVk1HYTA2SVo1c1l1TVliaE9xWFk2?= =?utf-8?B?YS9ybGVSNWxrdW1rVE5pY2pVUTNUNUYvdU8rMitmZDczYmhHL29Oa2pONDB3?= =?utf-8?B?MkZQK2hwZzdHT3RaR21Oa05wNUpxb3cwL3BwMTBBcTZiR0VHbEJTOXEreXNR?= =?utf-8?B?Si9YV3ZtWjhtVEQ4QTdXUW1idGlMMHA0Vkk2VktFaDNjWkhJSTB5UzAwRnkz?= =?utf-8?B?MUlvejNnOFBxVXFLKzVhSlVYclA4OGhNOGtxaE8xSkhVa1FqQ0NaTm9mQW5W?= =?utf-8?B?TVNaWUdlTGw5TWdUWlowb3ZrVHVZRmpBbzk2ZWhjWDNVTHI5dHQwcFlqRlFr?= =?utf-8?B?SExtem53MkVlRldqRTltOHpROXR2bWxwc29wTERibFJpN2tFZmxsM3dGNWZV?= =?utf-8?B?ZkhadXhUNjZpcmh5dFdyN0hjSi8rU0MyVndpLzhkd0FKVW9Wb2FORnRSUCtq?= =?utf-8?B?UVRqL1k4Z0N1Wm0zR1NtKzcrM08vWGxlbTRwL1ZDNlJqU3hRTDdUM1VxRDhW?= =?utf-8?B?VU43ZDJpZzU2aW0yZlBUN2hJeTFiQkJqNkI4OTJYQURBbjBXUjRmYUd3VTh5?= =?utf-8?B?NSszeCtpWGJmWlhkTW1la2xqajV6WEQ2ck9xUDFYZHVUblJUMFJvZHk1YkJN?= =?utf-8?B?NTJjb0lQWTJuYVZQT0JPSlg5Yjh2dnhsUU9pV0loK2ZMU3NmU2U0SXd6SkRZ?= =?utf-8?B?Yk93UXlFSkw5VFV6N2FrT0ZxemY2N1A4WndINjc2OTlRMUQ1U0ZYZGVncmts?= =?utf-8?B?QjVXQ3JPeDh5NlhNS2FSSVFPMUNvOHJ2NGN0NnREVEI3OWFYY3JCVmRkbS8w?= =?utf-8?B?MmJMUHllakdQalFoZUQvSEY1dm42eGhnRGxvNGhJdjFEcHZ0c1ZtditkMDdF?= =?utf-8?B?aDgxdk8zdTRmbFFaSHZLcjNLMmhjUzV5NmhlT2xtSTUyZlVNOEFacVJ1Y2hK?= =?utf-8?B?VGkwZ1pSZTdzZHBSK2haYm0vdEh4WEtxa1NyeHpCZDVQVENDSHVLUVV4N3pU?= =?utf-8?B?Z1BIM1p2VnlaY2lpc1AvWUlJZ0xyR2U1RnRGYURPV3VONC8xMjk0MXR6cHpv?= =?utf-8?B?NXJGaG5CMkNadk5yNmxubFVWZWV1ZkR5ckEvbHRaT29EaGdXdmlaMHJqaHJD?= =?utf-8?B?VFA2bmxOcDV6VnpNRURnU0JwemFqbm5PTXRNVFkxTHAxNXpqamJhNEpCVmlY?= =?utf-8?B?VXk1M3RLZlVLL0ZmaXlISWp4ZDJzL0t3NHV5WFFXYUtYdHZhM0hUUC9SbzlF?= =?utf-8?B?UGNxNkFqVmFEd3dVdi85ZW0reDhxZkcvN25DRzh6QWVWWU02WGkwc2tXYmNO?= =?utf-8?B?UjBBVUZiUy9HZWJNbFBqMjZGMFFWRjZwUFc3Y2o5d3FWVWdVV1VtaUh5c1A4?= =?utf-8?Q?lW2ptVY1GT6fGPOlO5YgCf4=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60a5a361-0989-4ad3-8884-08da6a264121 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 08:02:55.9895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZSfRqYro/nxFulMyRo3T/TfSeq31+cxf1iVHlmU8zUDCt4j0otMbSjYwFroFuhj5NFemL8d7nljLi0B08nMNQRZhrvd+pjlFvs6JaW/ZVLY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5305 X-Proofpoint-ORIG-GUID: W_0QD5bY6dmEBcZm3oJT9N7tOU7t5_Ez X-Proofpoint-GUID: W_0QD5bY6dmEBcZm3oJT9N7tOU7t5_Ez X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-20_04,2022-07-19_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 impostorscore=0 malwarescore=0 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200033 DQpPbiAyMC4wNy4yMiAwNjoyOSwgSmlhbWVpIFhpZSB3cm90ZToNCj4gSGkgT2xla3NhbmRyLA0K DQpIZWxsbyBKaWFtZWkNCg0KDQo+DQo+IFdlIGhhdmUgdGVzdGVkIGl0IG9uIGFybTY0IHdpdGgg IiBkaXNrID0gWyAncGh5Oi91c3Ivc2hhcmUvZ3Vlc3RzL2Rpc2suaW1nMCwgeHZkYTEsIGJhY2tl bmR0eXBlPXN0YW5kYWxvbmUsIHNwZWNpZmljYXRpb249dmlydGlvJ10iLiBJdCB3b3JrcyBvay4N Cj4NCj4gVGVzdGVkLWJ5OiBKaWFtZWkgWGllIDxqaWFtZWkueGllQGFybS5jb20+DQo+IFRlc3Rl ZC1ieTogSGVucnkgV2FuZyA8SGVucnkuV2FuZ0Bhcm0uY29tPg0KDQoNClRoYW5rIHlvdSBmb3Ig dGhlIHRlc3RpbmchDQoNCg0KPg0KPiBCZXN0IHdpc2hlcw0KPiBKaWFtZWkgWGllDQo+DQo+DQo+ PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPj4gRnJvbTogWGVuLWRldmVsIDx4ZW4tZGV2 ZWwtYm91bmNlc0BsaXN0cy54ZW5wcm9qZWN0Lm9yZz4gT24gQmVoYWxmIE9mDQo+PiBPbGVrc2Fu ZHIgVHlzaGNoZW5rbw0KPj4gU2VudDogU3VuZGF5LCBKdWx5IDE3LCAyMDIyIDEyOjM4IEFNDQo+ PiBUbzogeGVuLWRldmVsQGxpc3RzLnhlbnByb2plY3Qub3JnDQo+PiBDYzogT2xla3NhbmRyIFR5 c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPjsgV2VpIExpdQ0KPj4gPHds QHhlbi5vcmc+OyBBbnRob255IFBFUkFSRCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT47IEdl b3JnZQ0KPj4gRHVubGFwIDxnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+OyBOaWNrIFJvc2Jyb29r DQo+PiA8cm9zYnJvb2tuQGdtYWlsLmNvbT47IEp1ZXJnZW4gR3Jvc3MgPGpncm9zc0BzdXNlLmNv bT47IFN0ZWZhbm8NCj4+IFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBKdWxp ZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgVm9sb2R5bXlyDQo+PiBCYWJjaHVrIDxWb2xvZHlt eXJfQmFiY2h1a0BlcGFtLmNvbT47IEJlcnRyYW5kIE1hcnF1aXMNCj4+IDxCZXJ0cmFuZC5NYXJx dWlzQGFybS5jb20+DQo+PiBTdWJqZWN0OiBbUEFUQ0ggVjExLjEgMS8zXSBsaWJ4bDogQWRkIHN1 cHBvcnQgZm9yIFZpcnRpbyBkaXNrIGNvbmZpZ3VyYXRpb24NCj4+DQo+PiBGcm9tOiBPbGVrc2Fu ZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+Pg0KPj4gVGhp cyBwYXRjaCBhZGRzIGJhc2ljIHN1cHBvcnQgZm9yIGNvbmZpZ3VyaW5nIGFuZCBhc3Npc3Rpbmcg dmlydGlvLW1taW8NCj4+IGJhc2VkIHZpcnRpby1kaXNrIGJhY2tlbmQgKGVtdWxhdG9yKSB3aGlj aCBpcyBpbnRlbmRlZCB0byBydW4gb3V0IG9mDQo+PiBRZW11IGFuZCBjb3VsZCBiZSBydW4gaW4g YW55IGRvbWFpbi4NCj4+IEFsdGhvdWdoIHRoZSBWaXJ0aW8gYmxvY2sgZGV2aWNlIGlzIHF1aXRl IGRpZmZlcmVudCBmcm9tIHRyYWRpdGlvbmFsDQo+PiBYZW4gUFYgYmxvY2sgZGV2aWNlICh2YmQp IGZyb20gdGhlIHRvb2xzdGFjaydzIHBvaW50IG9mIHZpZXc6DQo+PiAgIC0gYXMgdGhlIGZyb250 ZW5kIGlzIHZpcnRpby1ibGsgd2hpY2ggaXMgbm90IGEgWGVuYnVzIGRyaXZlciwgbm90aGluZw0K Pj4gICAgIHdyaXR0ZW4gdG8gWGVuc3RvcmUgYXJlIGZldGNoZWQgYnkgdGhlIGZyb250ZW5kIGN1 cnJlbnRseSAoInZkZXYiDQo+PiAgICAgaXMgbm90IHBhc3NlZCB0byB0aGUgZnJvbnRlbmQpLiBC dXQgdGhpcyBtaWdodCBuZWVkIHRvIGJlIHJldmlzZWQNCj4+ICAgICBpbiBmdXR1cmUsIHNvIGZy b250ZW5kIGRhdGEgbWlnaHQgYmUgd3JpdHRlbiB0byBYZW5zdG9yZSBpbiBvcmRlciB0bw0KPj4g ICAgIHN1cHBvcnQgaG90cGx1Z2dpbmcgdmlydGlvIGRldmljZXMgb3IgcGFzc2luZyB0aGUgYmFj a2VuZCBkb21haW4gaWQNCj4+ICAgICBvbiBhcmNoIHdoZXJlIHRoZSBkZXZpY2UtdHJlZSBpcyBu b3QgYXZhaWxhYmxlLg0KPj4gICAtIHRoZSByaW5nLXJlZi9ldmVudC1jaGFubmVsIGFyZSBub3Qg dXNlZCBmb3IgdGhlIGJhY2tlbmQ8LT5mcm9udGVuZA0KPj4gICAgIGNvbW11bmljYXRpb24sIHRo ZSBwcm9wb3NlZCBJUEMgZm9yIFZpcnRpbyBpcyBJT1JFUS9ETQ0KPj4gaXQgaXMgc3RpbGwgYSAi YmxvY2sgZGV2aWNlIiBhbmQgb3VnaHQgdG8gYmUgaW50ZWdyYXRlZCBpbiBleGlzdGluZw0KPj4g ImRpc2siIGhhbmRsaW5nLiBTbywgcmUtdXNlIChhbmQgYWRhcHQpICJkaXNrIiBwYXJzaW5nL2Nv bmZpZ3VyYXRpb24NCj4+IGxvZ2ljIHRvIGRlYWwgd2l0aCBWaXJ0aW8gZGV2aWNlcyBhcyB3ZWxs Lg0KPj4NCj4+IEZvciB0aGUgaW1tZWRpYXRlIHB1cnBvc2UgYW5kIGFuIGFiaWxpdHkgdG8gZXh0 ZW5kIHRoYXQgc3VwcG9ydCBmb3INCj4+IG90aGVyIHVzZS1jYXNlcyBpbiBmdXR1cmUgKFFlbXUs IHZpcnRpby1wY2ksIGV0YykgcGVyZm9ybSB0aGUgZm9sbG93aW5nDQo+PiBhY3Rpb25zOg0KPj4g LSBBZGQgbmV3IGRpc2sgYmFja2VuZCB0eXBlIChMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9O RSkgYW5kDQo+PiByZWZsZWN0DQo+PiAgICB0aGF0IGluIHRoZSBjb25maWd1cmF0aW9uDQo+PiAt IEludHJvZHVjZSBuZXcgZGlzayAic3BlY2lmaWNhdGlvbiIgYW5kICJ0cmFuc3BvcnQiIGZpZWxk cyB0byBzdHJ1Y3QNCj4+ICAgIGxpYnhsX2RldmljZV9kaXNrLiBCb3RoIGFyZSB3cml0dGVuIHRv IHRoZSBYZW5zdG9yZS4gVGhlIHRyYW5zcG9ydA0KPj4gICAgZmllbGQgaXMgb25seSB1c2VkIGZv ciB0aGUgc3BlY2lmaWNhdGlvbiAidmlydGlvIiBhbmQgaXQgYXNzdW1lcw0KPj4gICAgb25seSAi bW1pbyIgdmFsdWUgZm9yIG5vdy4NCj4+IC0gSW50cm9kdWNlIG5ldyAic3BlY2lmaWNhdGlvbiIg b3B0aW9uIHdpdGggInhlbiIgY29tbXVuaWNhdGlvbg0KPj4gICAgcHJvdG9jb2wgYmVpbmcgZGVm YXVsdCB2YWx1ZS4NCj4+IC0gQWRkIG5ldyBkZXZpY2Uga2luZCAoTElCWExfX0RFVklDRV9LSU5E X1ZJUlRJT19ESVNLKSBhcyBjdXJyZW50DQo+PiAgICBvbmUgKExJQlhMX19ERVZJQ0VfS0lORF9W QkQpIGRvZXNuJ3QgZml0IGludG8gVmlydGlvIGRpc2sgbW9kZWwNCj4+DQo+PiBBbiBleGFtcGxl IG9mIGRvbWFpbiBjb25maWd1cmF0aW9uIGZvciBWaXJ0aW8gZGlzazoNCj4+IGRpc2sgPSBbICdw aHk6L2Rldi9tbWNibGswcDMsIHh2ZGExLCBiYWNrZW5kdHlwZT1zdGFuZGFsb25lLA0KPj4gc3Bl Y2lmaWNhdGlvbj12aXJ0aW8nXQ0KPj4NCj4+IE5vdGhpbmcgaGFzIGNoYW5nZWQgZm9yIGRlZmF1 bHQgWGVuIGRpc2sgY29uZmlndXJhdGlvbi4NCj4+DQo+PiBQbGVhc2Ugbm90ZSwgdGhpcyBwYXRj aCBpcyBub3QgZW5vdWdoIGZvciB2aXJ0aW8tZGlzayB0byB3b3JrDQo+PiBvbiBYZW4gKEFybSks IGFzIGZvciBldmVyeSBWaXJ0aW8gZGV2aWNlIChpbmNsdWRpbmcgZGlzaykgd2UgbmVlZA0KPj4g dG8gYWxsb2NhdGUgVmlydGlvIE1NSU8gcGFyYW1zIChJUlEgYW5kIG1lbW9yeSByZWdpb24pIGFu ZCBwYXNzDQo+PiB0aGVtIHRvIHRoZSBiYWNrZW5kLCBhbHNvIHVwZGF0ZSBHdWVzdCBkZXZpY2Ut dHJlZS4gVGhlIHN1YnNlcXVlbnQNCj4+IHBhdGNoIHdpbGwgYWRkIHRoZXNlIG1pc3NpbmcgYml0 cy4gRm9yIHRoZSBjdXJyZW50IHBhdGNoLA0KPj4gdGhlIGRlZmF1bHQgImlycSIgYW5kICJiYXNl IiBhcmUganVzdCB3cml0dGVuIHRvIHRoZSBYZW5zdG9yZS4NCj4+IFRoaXMgaXMgbm90IGFuIGlk ZWFsIHNwbGl0dGluZywgYnV0IHRoaXMgd2F5IHdlIGF2b2lkIGJyZWFraW5nDQo+PiB0aGUgYmlz ZWN0YWJpbGl0eS4NCj4+DQo+PiBTaWduZWQtb2ZmLWJ5OiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8 b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5jb20+DQo+PiAtLS0NCj4+IENoYW5nZXMgUkZDIC0+ IFYxOg0KPj4gICAgIC0gbm8gY2hhbmdlcw0KPj4NCj4+IENoYW5nZXMgVjEgLT4gVjI6DQo+PiAg ICAgLSByZWJhc2UgYWNjb3JkaW5nIHRvIHRoZSBuZXcgbG9jYXRpb24gb2YgbGlieGxfdmlydGlv X2Rpc2suYw0KPj4NCj4+IENoYW5nZXMgVjIgLT4gVjM6DQo+PiAgICAgLSBubyBjaGFuZ2VzDQo+ Pg0KPj4gQ2hhbmdlcyBWMyAtPiBWNDoNCj4+ICAgICAtIHJlYmFzZSBhY2NvcmRpbmcgdG8gdGhl IG5ldyBhcmd1bWVudCBmb3IgREVGSU5FX0RFVklDRV9UWVBFX1NUUlVDVA0KPj4NCj4+IENoYW5n ZXMgVjQgLT4gVjU6DQo+PiAgICAgLSBzcGxpdCB0aGUgY2hhbmdlcywgY2hhbmdlIHRoZSBvcmRl ciBvZiB0aGUgcGF0Y2hlcw0KPj4gICAgIC0gdXBkYXRlIHBhdGNoIGRlc2NyaXB0aW9uDQo+PiAg ICAgLSBkb24ndCBpbnRyb2R1Y2UgbmV3ICJ2ZGlzayIgY29uZmlndXJhdGlvbiBvcHRpb24gd2l0 aCBvd24gcGFyc2luZyBsb2dpYywNCj4+ICAgICAgIHJlLXVzZSBYZW4gUFYgYmxvY2sgImRpc2si IHBhcnNpbmcvY29uZmlndXJhdGlvbiBsb2dpYyBmb3IgdGhlIHZpcnRpby1kaXNrDQo+PiAgICAg LSBpbnRyb2R1Y2UgInZpcnRpbyIgZmxhZyBhbmQgZG9jdW1lbnQgaXQncyB1c2FnZQ0KPj4gICAg IC0gYWRkIExJQlhMX0hBVkVfREVWSUNFX0RJU0tfVklSVElPDQo+PiAgICAgLSB1cGRhdGUgbGli eGx1X2Rpc2tfbC5bY2hdDQo+PiAgICAgLSBkcm9wIG51bV9kaXNrcyB2YXJpYWJsZS9NQVhfVklS VElPX0RJU0tTDQo+PiAgICAgLSBkcm9wIFdlaSdzIFQtYg0KPj4NCj4+IENoYW5nZXMgVjUgLT4g VjY6DQo+PiAgICAgLSByZWJhc2Ugb24gY3VycmVudCBzdGFnaW5nDQo+PiAgICAgLSB1c2UgIiUi UFJJdTY0IGluc3RlYWQgb2YgJWx1IGZvciBkaXNrLT5iYXNlIGluIGRldmljZV9kaXNrX2FkZCgp DQo+PiAgICAgLSB1cGRhdGUgKi5nZW4uZ28gZmlsZXMNCj4+DQo+PiBDaGFuZ2VzIFY2IC0+IFY3 Og0KPj4gICAgIC0gcmViYXNlIG9uIGN1cnJlbnQgc3RhZ2luZw0KPj4gICAgIC0gdXBkYXRlICou Z2VuLmdvIGZpbGVzIGFuZCBsaWJ4bHVfZGlza19sLltjaF0gZmlsZXMNCj4+ICAgICAtIHVwZGF0 ZSBwYXRjaCBkZXNjcmlwdGlvbg0KPj4gICAgIC0gcmV3b3JrIHNpZ25pZmljYW50bHkgdG8gc3Vw cG9ydCBtb3JlIGZsZXhpYmxlIGNvbmZpZ3VyYXRpb24NCj4+ICAgICAgIGFuZCBoYXZlIG1vcmUg Z2VuZXJpYyBiYXNpYyBpbXBsZW1lbnRhdGlvbiBmb3IgYmVpbmcgYWJsZSB0byBleHRlbmQNCj4+ ICAgICAgIHRoYXQgZm9yIG90aGVyIHVzZS1jYXNlcyAodmlydGlvLXBjaSwgcWVtdSwgZXRjKS4N Cj4+DQo+PiBDaGFuZ2VzIFY3IC0+IFY4Og0KPj4gICAgIC0gdXBkYXRlICouZ2VuLmdvIGZpbGVz IGFuZCBsaWJ4bHVfZGlza19sLltjaF0gZmlsZXMNCj4+ICAgICAtIHVwZGF0ZSBwYXRjaCBkZXNj cmlwdGlvbiBhbmQgY29tbWVudHMgaW4gdGhlIGNvZGUNCj4+ICAgICAtIHVzZSAic3BlY2lmaWNh dGlvbiIgY29uZmlnIG9wdGlvbiBpbnN0ZWFkIG9mICJwcm90b2NvbCINCj4+ICAgICAtIHVwZGF0 ZSBsaWJ4bF90eXBlcy5pZGwgYW5kIGNvZGUgYWNjb3JkaW5nIHRvIG5ldyBmaWVsZHMNCj4+ICAg ICAgIGluIGxpYnhsX2RldmljZV9kaXNrDQo+Pg0KPj4gQ2hhbmdlcyBWOCAtPiBWOToNCj4+ICAg ICAtIHVwZGF0ZSAoYW5kIGhhcmRlbikgY2hlY2tzIGluIGxpYnhsX19kZXZpY2VfZGlza19zZXRk ZWZhdWx0KCksDQo+PiAgICAgICByZXR1cm4gZXJyb3IgaW4gY2FzZSBvZiBpbmNvcnJlY3Qgc2V0 dGluZ3Mgb2Ygc3BlY2lmaWNhdGlvbg0KPj4gICAgICAgYW5kIHRyYW5zcG9ydA0KPj4gICAgIC0g cmVtb3ZlIGJvdGggYXNzZXJ0cyBpbiBkZXZpY2VfZGlza19hZGQoKQ0KPj4gICAgIC0gdXBkYXRl IHZpcnRpbyByZWxhdGVkIGNvZGUgaW4gbGlieGxfX2Rpc2tfZnJvbV94ZW5zdG9yZSgpLA0KPj4g ICAgICAgZG8gbm90IGZhaWwgaWYgc3BlY2lmaWNhdGlvbiBub2RlIGlzIGFic2VudCwgcmVwbGFj ZQ0KPj4gICAgICAgb3Blbi1jb2RlZCBjaGVja3Mgb2YgZmV0Y2hlZCBzcGVjaWZpY2F0aW9uIGFu ZCB0cmFuc3BvcnQgYnkNCj4+ICAgICAgIGxpYnhsX2Rpc2tfc3BlY2lmaWNhdGlvbl9mcm9tX3N0 cmluZygpIGFuZA0KPj4gbGlieGxfZGlza190cmFuc3BvcnRfZnJvbV9zdHJpbmcoKQ0KPj4gICAg ICAgcmVzcGVjdGl2ZWx5DQo+PiAgICAgLSBzL2xpYnhsX2RldmljZV9kaXNrX2dldF9wYXRoL2xp YnhsX19kZXZpY2VfZGlza19nZXRfcGF0aA0KPj4gICAgIC0gYWRkIGEgY29tbWVudCBmb3Igdmly dGlvLW1taW8gcGFyYW1ldGVycyBpbiBzdHJ1Y3QgbGlieGxfZGV2aWNlX2Rpc2sNCj4+DQo+PiBD aGFuZ2VzIFY5IC0+IFYxMDoNCj4+ICAgICAtIHMvRVJST1JfRkFJTC9FUlJPUl9JTlZBTCBpbiBi b3RoIHBsYWNlcyBpbg0KPj4gbGlieGxfX2RldmljZV9kaXNrX3NldGRlZmF1bHQoKQ0KPj4gICAg IC0gcmV3b3JrIGxpYnhsX19kZXZpY2VfZGlza19nZXRfcGF0aCgpDQo+Pg0KPj4gQ2hhbmdlcyBW MTAgLT4gVjEwLjE6DQo+PiAgICAgLSBmaXggc21hbGwgY29kaW5nIHN0eWxlIGlzc3VlIGluIGxp YnhsX19kZXZpY2VfZGlza19nZXRfcGF0aCgpDQo+PiAgICAgLSBkcm9wIHNwZWNpZmljYXRpb24g Y2hlY2sgaW4gbWFpbl9ibG9ja2F0dGFjaCgpIGFuZCBhZGQNCj4+ICAgICAgIHJlcXVpcmVkIGNo ZWNrIGluIGxpYnhsX19kZXZpY2VfZGlza19zZXRkZWZhdWx0KCkNCj4+ICAgICAtIHVwZGF0ZSBz cGVjaWZpY2F0aW9uIGNoZWNrIGluIG1haW5fYmxvY2tkZXRhY2goKQ0KPj4NCj4+IENoYW5nZXMg VjEwLjEgLT4gVjExOg0KPj4gICAgIC0gQW50aG9ueSBhbHJlYWR5IGdhdmUgaGlzIFJldmlld2Vk LWJ5LCBJIGRyb3BwZWQgaXQgZHVlIHRvIHRoZSBjaGFuZ2VzDQo+PiAgICAgLSBHZW9yZ2UgYWxy ZWFkeSBnYXZlIGhpcyBBY2tlZC1ieSwgSSBkcm9wcGVkIGl0IGR1ZSB0byB0aGUgY2hhbmdlcw0K Pj4gICAgIC0gcy9vdGhlci9zdGFuZGFsb25lIGZvciB0aGUgYmFja2VuZHR5cGUNCj4+DQo+PiBD aGFuZ2VzIFYxMSAtPiBWMTEuMToNCj4+ICAgICAtIHJlYmFzZQ0KPj4gLS0tDQo+PiAgIGRvY3Mv bWFuL3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBvZC5pbiAgIHwgIDM4ICstDQo+PiAgIHRvb2xz L2dvbGFuZy94ZW5saWdodC9oZWxwZXJzLmdlbi5nbyAgICAgIHwgICA4ICsNCj4+ICAgdG9vbHMv Z29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbyAgICAgICAgfCAgMTggKw0KPj4gICB0b29scy9p bmNsdWRlL2xpYnhsLmggICAgICAgICAgICAgICAgICAgICB8ICAgNyArDQo+PiAgIHRvb2xzL2xp YnMvbGlnaHQvbGlieGxfZGV2aWNlLmMgICAgICAgICAgIHwgIDYyICstDQo+PiAgIHRvb2xzL2xp YnMvbGlnaHQvbGlieGxfZGlzay5jICAgICAgICAgICAgIHwgMTQ2ICsrKy0NCj4+ICAgdG9vbHMv bGlicy9saWdodC9saWJ4bF9pbnRlcm5hbC5oICAgICAgICAgfCAgIDIgKw0KPj4gICB0b29scy9s aWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbCAgICAgICAgICB8ICAxOCArDQo+PiAgIHRvb2xzL2xp YnMvbGlnaHQvbGlieGxfdHlwZXNfaW50ZXJuYWwuaWRsIHwgICAxICsNCj4+ICAgdG9vbHMvbGli cy9saWdodC9saWJ4bF91dGlscy5jICAgICAgICAgICAgfCAgIDIgKw0KPj4gICB0b29scy9saWJz L3V0aWwvbGlieGx1X2Rpc2tfbC5jICAgICAgICAgICB8IDk1OSArKysrKysrKysrKy0tLS0tLS0t LS0tDQo+PiAgIHRvb2xzL2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmggICAgICAgICAgIHwgICAy ICstDQo+PiAgIHRvb2xzL2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmwgICAgICAgICAgIHwgICA5 ICsNCj4+ICAgdG9vbHMveGwveGxfYmxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDYg Kw0KPj4gICAxNCBmaWxlcyBjaGFuZ2VkLCA3OTggaW5zZXJ0aW9ucygrKSwgNDgwIGRlbGV0aW9u cygtKQ0KPj4NCj4+IGRpZmYgLS1naXQgYS9kb2NzL21hbi94bC1kaXNrLWNvbmZpZ3VyYXRpb24u NS5wb2QuaW4gYi9kb2NzL21hbi94bC1kaXNrLQ0KPj4gY29uZmlndXJhdGlvbi41LnBvZC5pbg0K Pj4gaW5kZXggOTVkMDM5NjU1YS4uYmM5NDVjYzUxNyAxMDA2NDQNCj4+IC0tLSBhL2RvY3MvbWFu L3hsLWRpc2stY29uZmlndXJhdGlvbi41LnBvZC5pbg0KPj4gKysrIGIvZG9jcy9tYW4veGwtZGlz ay1jb25maWd1cmF0aW9uLjUucG9kLmluDQo+PiBAQCAtMjMyLDcgKzIzMiw3IEBAIFNwZWNpZmll cyB0aGUgYmFja2VuZCBpbXBsZW1lbnRhdGlvbiB0byB1c2UNCj4+DQo+PiAgID1pdGVtIFN1cHBv cnRlZCB2YWx1ZXMNCj4+DQo+PiAtcGh5LCBxZGlzaw0KPj4gK3BoeSwgcWRpc2ssIHN0YW5kYWxv bmUNCj4+DQo+PiAgID1pdGVtIE1hbmRhdG9yeQ0KPj4NCj4+IEBAIC0yNDQsMTEgKzI0NCwxMyBA QCBBdXRvbWF0aWNhbGx5IGRldGVybWluZSB3aGljaCBiYWNrZW5kIHRvIHVzZS4NCj4+DQo+PiAg ID1iYWNrDQo+Pg0KPj4gLVRoaXMgZG9lcyBub3QgYWZmZWN0IHRoZSBndWVzdCdzIHZpZXcgb2Yg dGhlIGRldmljZS4gIEl0IGNvbnRyb2xzDQo+PiAtd2hpY2ggc29mdHdhcmUgaW1wbGVtZW50YXRp b24gb2YgdGhlIFhlbiBiYWNrZW5kIGRyaXZlciBpcyB1c2VkLg0KPj4gK0l0IGNvbnRyb2xzIHdo aWNoIHNvZnR3YXJlIGltcGxlbWVudGF0aW9uIG9mIHRoZSBiYWNrZW5kIGRyaXZlciBpcyB1c2Vk Lg0KPj4gK0RlcGVuZGluZyBvbiB0aGUgInNwZWNpZmljYXRpb24iIG9wdGlvbiB0aGlzIG1heSBh ZmZlY3QgdGhlIGd1ZXN0J3Mgdmlldw0KPj4gK29mIHRoZSBkZXZpY2UuDQo+Pg0KPj4gICBOb3Qg YWxsIGJhY2tlbmQgZHJpdmVycyBzdXBwb3J0IGFsbCBjb21iaW5hdGlvbnMgb2Ygb3RoZXIgb3B0 aW9ucy4NCj4+IC1Gb3IgZXhhbXBsZSwgInBoeSIgZG9lcyBub3Qgc3VwcG9ydCBmb3JtYXRzIG90 aGVyIHRoYW4gInJhdyIuDQo+PiArRm9yIGV4YW1wbGUsICJwaHkiIGFuZCAic3RhbmRhbG9uZSIg ZG8gbm90IHN1cHBvcnQgZm9ybWF0cyBvdGhlciB0aGFuDQo+PiAicmF3Ig0KPj4gK2FuZCAic3Rh bmRhbG9uZSIgZG9lcyBub3Qgc3VwcG9ydCBzcGVjaWZpY2F0aW9ucyBvdGhlciB0aGFuICJ2aXJ0 aW8iLg0KPj4gICBOb3JtYWxseSB0aGlzIG9wdGlvbiBzaG91bGQgbm90IGJlIHNwZWNpZmllZCwg aW4gd2hpY2ggY2FzZSBsaWJ4bCB3aWxsDQo+PiAgIGF1dG9tYXRpY2FsbHkgZGV0ZXJtaW5lIHRo ZSBtb3N0IHN1aXRhYmxlIGJhY2tlbmQuDQo+Pg0KPj4gQEAgLTM3Myw4ICszNzUsMzYgQEAgcHJv Y2Vzc2luZyBvciBjYXVzaW5nIG1hbGZ1bmN0aW9uIHRvIHRoZSBmcm9udGVuZA0KPj4gb3IgdGhl IHdob2xlIGRvbWFpbi4NCj4+DQo+PiAgIE5vdGUgZnJvbnRlbmRzIGNhbiBpZ25vcmUgc3VjaCBy ZWNvbW1lbmRhdGlvbi4NCj4+DQo+PiArPWl0ZW0gQjxzcGVjaWZpY2F0aW9uPj1JPFNQRUNJRklD QVRJT04+DQo+PiArDQo+PiArPW92ZXIgNA0KPj4gKw0KPj4gKz1pdGVtIERlc2NyaXB0aW9uDQo+ PiArDQo+PiArU3BlY2lmaWVzIHRoZSBjb21tdW5pY2F0aW9uIHByb3RvY29sIChzcGVjaWZpY2F0 aW9uKSB0byB1c2UgZm9yIHRoZSBjaG9zZW4NCj4+ICsiYmFja2VuZHR5cGUiIG9wdGlvbg0KPj4g Kw0KPj4gKz1pdGVtIFN1cHBvcnRlZCB2YWx1ZXMNCj4+ICsNCj4+ICt4ZW4sIHZpcnRpbw0KPj4g Kw0KPj4gKz1pdGVtIE1hbmRhdG9yeQ0KPj4gKw0KPj4gK05vDQo+PiArDQo+PiArPWl0ZW0gRGVm YXVsdCB2YWx1ZQ0KPj4gKw0KPj4gK3hlbg0KPj4gKw0KPj4gICA9YmFjaw0KPj4NCj4+ICtCZXNp ZGVzIGZvcmNpbmcgdG9vbHN0YWNrIHRvIHVzZSBzcGVjaWZpYyBiYWNrZW5kIGltcGxlbWVudGF0 aW9uLCB0aGlzIGFsc28NCj4+ICthZmZlY3RzIHRoZSBndWVzdCdzIHZpZXcgb2YgdGhlIGRldmlj ZS4gRm9yIGV4YW1wbGUsICJ2aXJ0aW8iIHJlcXVpcmVzDQo+PiArVmlydGlvIGZyb250ZW5kIGRy aXZlciAodmlydGlvLWJsaykgdG8gYmUgdXNlZC4gUGxlYXNlIG5vdGUsIHRoZSB2aXJ0dWFsDQo+ PiArZGV2aWNlICh2ZGV2KSBpcyBub3QgcGFzc2VkIHRvIHRoZSBndWVzdCBpbiB0aGF0IGNhc2Us IGJ1dCBpdCBzdGlsbCBtdXN0IGJlDQo+PiArc3BlY2lmaWVkIGZvciB0aGUgaW50ZXJuYWwgcHVy cG9zZXMuDQo+PiArDQo+PiArPWJhY2sNCj4+DQo+PiAgID1oZWFkMSBDT0xPIFBhcmFtZXRlcnMN Cj4+DQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMuZ2VuLmdv DQo+PiBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC9oZWxwZXJzLmdlbi5nbw0KPj4gaW5kZXggZGVj ZTU0NWVlMC4uYWQ4YzExZWFlMSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2dvbGFuZy94ZW5saWdo dC9oZWxwZXJzLmdlbi5nbw0KPj4gKysrIGIvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L2hlbHBlcnMu Z2VuLmdvDQo+PiBAQCAtMTc2Myw2ICsxNzYzLDEwIEBAIHguRGlyZWN0SW9TYWZlID0gYm9vbCh4 Yy5kaXJlY3RfaW9fc2FmZSkNCj4+ICAgaWYgZXJyIDo9IHguRGlzY2FyZEVuYWJsZS5mcm9tQygm eGMuZGlzY2FyZF9lbmFibGUpO2VyciAhPSBuaWwgew0KPj4gICByZXR1cm4gZm10LkVycm9yZigi Y29udmVydGluZyBmaWVsZCBEaXNjYXJkRW5hYmxlOiAldiIsIGVycikNCj4+ICAgfQ0KPj4gK3gu U3BlY2lmaWNhdGlvbiA9IERpc2tTcGVjaWZpY2F0aW9uKHhjLnNwZWNpZmljYXRpb24pDQo+PiAr eC5UcmFuc3BvcnQgPSBEaXNrVHJhbnNwb3J0KHhjLnRyYW5zcG9ydCkNCj4+ICt4LklycSA9IHVp bnQzMih4Yy5pcnEpDQo+PiAreC5CYXNlID0gdWludDY0KHhjLmJhc2UpDQo+PiAgIGlmIGVyciA6 PSB4LkNvbG9FbmFibGUuZnJvbUMoJnhjLmNvbG9fZW5hYmxlKTtlcnIgIT0gbmlsIHsNCj4+ICAg cmV0dXJuIGZtdC5FcnJvcmYoImNvbnZlcnRpbmcgZmllbGQgQ29sb0VuYWJsZTogJXYiLCBlcnIp DQo+PiAgIH0NCj4+IEBAIC0xODAwLDYgKzE4MDQsMTAgQEAgeGMuZGlyZWN0X2lvX3NhZmUgPSBD LmJvb2woeC5EaXJlY3RJb1NhZmUpDQo+PiAgIGlmIGVyciA6PSB4LkRpc2NhcmRFbmFibGUudG9D KCZ4Yy5kaXNjYXJkX2VuYWJsZSk7IGVyciAhPSBuaWwgew0KPj4gICByZXR1cm4gZm10LkVycm9y ZigiY29udmVydGluZyBmaWVsZCBEaXNjYXJkRW5hYmxlOiAldiIsIGVycikNCj4+ICAgfQ0KPj4g K3hjLnNwZWNpZmljYXRpb24gPSBDLmxpYnhsX2Rpc2tfc3BlY2lmaWNhdGlvbih4LlNwZWNpZmlj YXRpb24pDQo+PiAreGMudHJhbnNwb3J0ID0gQy5saWJ4bF9kaXNrX3RyYW5zcG9ydCh4LlRyYW5z cG9ydCkNCj4+ICt4Yy5pcnEgPSBDLnVpbnQzMl90KHguSXJxKQ0KPj4gK3hjLmJhc2UgPSBDLnVp bnQ2NF90KHguQmFzZSkNCj4+ICAgaWYgZXJyIDo9IHguQ29sb0VuYWJsZS50b0MoJnhjLmNvbG9f ZW5hYmxlKTsgZXJyICE9IG5pbCB7DQo+PiAgIHJldHVybiBmbXQuRXJyb3JmKCJjb252ZXJ0aW5n IGZpZWxkIENvbG9FbmFibGU6ICV2IiwgZXJyKQ0KPj4gICB9DQo+PiBkaWZmIC0tZ2l0IGEvdG9v bHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gYi90b29scy9nb2xhbmcveGVubGln aHQvdHlwZXMuZ2VuLmdvDQo+PiBpbmRleCAyNTNjOWFkOTNkLi5iOTE0MzM5MGY4IDEwMDY0NA0K Pj4gLS0tIGEvdG9vbHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gKysrIGIvdG9v bHMvZ29sYW5nL3hlbmxpZ2h0L3R5cGVzLmdlbi5nbw0KPj4gQEAgLTk5LDYgKzk5LDIwIEBAIERp c2tCYWNrZW5kVW5rbm93biBEaXNrQmFja2VuZCA9IDANCj4+ICAgRGlza0JhY2tlbmRQaHkgRGlz a0JhY2tlbmQgPSAxDQo+PiAgIERpc2tCYWNrZW5kVGFwIERpc2tCYWNrZW5kID0gMg0KPj4gICBE aXNrQmFja2VuZFFkaXNrIERpc2tCYWNrZW5kID0gMw0KPj4gK0Rpc2tCYWNrZW5kU3RhbmRhbG9u ZSBEaXNrQmFja2VuZCA9IDQNCj4+ICspDQo+PiArDQo+PiArdHlwZSBEaXNrU3BlY2lmaWNhdGlv biBpbnQNCj4+ICtjb25zdCgNCj4+ICtEaXNrU3BlY2lmaWNhdGlvblVua25vd24gRGlza1NwZWNp ZmljYXRpb24gPSAwDQo+PiArRGlza1NwZWNpZmljYXRpb25YZW4gRGlza1NwZWNpZmljYXRpb24g PSAxDQo+PiArRGlza1NwZWNpZmljYXRpb25WaXJ0aW8gRGlza1NwZWNpZmljYXRpb24gPSAyDQo+ PiArKQ0KPj4gKw0KPj4gK3R5cGUgRGlza1RyYW5zcG9ydCBpbnQNCj4+ICtjb25zdCgNCj4+ICtE aXNrVHJhbnNwb3J0VW5rbm93biBEaXNrVHJhbnNwb3J0ID0gMA0KPj4gK0Rpc2tUcmFuc3BvcnRN bWlvIERpc2tUcmFuc3BvcnQgPSAxDQo+PiAgICkNCj4+DQo+PiAgIHR5cGUgTmljVHlwZSBpbnQN Cj4+IEBAIC02NDUsNiArNjU5LDEwIEBAIFJlYWR3cml0ZSBpbnQNCj4+ICAgSXNDZHJvbSBpbnQN Cj4+ICAgRGlyZWN0SW9TYWZlIGJvb2wNCj4+ICAgRGlzY2FyZEVuYWJsZSBEZWZib29sDQo+PiAr U3BlY2lmaWNhdGlvbiBEaXNrU3BlY2lmaWNhdGlvbg0KPj4gK1RyYW5zcG9ydCBEaXNrVHJhbnNw b3J0DQo+PiArSXJxIHVpbnQzMg0KPj4gK0Jhc2UgdWludDY0DQo+PiAgIENvbG9FbmFibGUgRGVm Ym9vbA0KPj4gICBDb2xvUmVzdG9yZUVuYWJsZSBEZWZib29sDQo+PiAgIENvbG9Ib3N0IHN0cmlu Zw0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2luY2x1ZGUvbGlieGwuaCBiL3Rvb2xzL2luY2x1ZGUv bGlieGwuaA0KPj4gaW5kZXggZjM1MTY2OTAzOS4uMjMyMWE2NDhhNSAxMDA2NDQNCj4+IC0tLSBh L3Rvb2xzL2luY2x1ZGUvbGlieGwuaA0KPj4gKysrIGIvdG9vbHMvaW5jbHVkZS9saWJ4bC5oDQo+ PiBAQCAtNTQ5LDYgKzU0OSwxMyBAQA0KPj4gICAgKi8NCj4+ICAgI2RlZmluZSBMSUJYTF9IQVZF X0FTU0lTVEVEX0FQSUMgMQ0KPj4NCj4+ICsvKg0KPj4gKyAqIExJQlhMX0hBVkVfREVWSUNFX0RJ U0tfU1BFQ0lGSUNBVElPTiBpbmRpY2F0ZXMgdGhhdCAnc3BlY2lmaWNhdGlvbicNCj4+IGFuZA0K Pj4gKyAqICd0cmFuc3BvcnQnIGZpZWxkcyAob2YgbGlieGxfZGlza19zcGVjaWZpY2F0aW9uIGFu ZCBsaWJ4bF9kaXNrX3RyYW5zcG9ydA0KPj4gKyAqIHR5cGVzIHJlc3BlY3RpdmVseSkgYXJlIHBy ZXNlbnQgaW4gbGlieGxfZGV2aWNlX2Rpc2suDQo+PiArICovDQo+PiArI2RlZmluZSBMSUJYTF9I QVZFX0RFVklDRV9ESVNLX1NQRUNJRklDQVRJT04gMQ0KPj4gKw0KPj4gICAvKg0KPj4gICAgKiBs aWJ4bCBBQkkgY29tcGF0aWJpbGl0eQ0KPj4gICAgKg0KPj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2xp YnMvbGlnaHQvbGlieGxfZGV2aWNlLmMgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2RldmljZS5j DQo+PiBpbmRleCBlNjAyNWQxMzVlLi5hNzVjMjFkNDMzIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMv bGlicy9saWdodC9saWJ4bF9kZXZpY2UuYw0KPj4gKysrIGIvdG9vbHMvbGlicy9saWdodC9saWJ4 bF9kZXZpY2UuYw0KPj4gQEAgLTI4OSw5ICsyODksMTYgQEAgc3RhdGljIGludCBkaXNrX3RyeV9i YWNrZW5kKGRpc2tfdHJ5X2JhY2tlbmRfYXJncw0KPj4gKmEsDQo+PiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsaWJ4bF9kaXNrX2JhY2tlbmQgYmFja2VuZCkNCj4+ICAgIHsNCj4+ICAg ICAgIGxpYnhsX19nYyAqZ2MgPSBhLT5nYzsNCj4+ICsgICAgbGlieGxfZGlza19zcGVjaWZpY2F0 aW9uIHNwZWNpZmljYXRpb24gPSBhLT5kaXNrLT5zcGVjaWZpY2F0aW9uOw0KPj4gICAgICAgLyog cmV0dXJucyAwIChpZSwgRElTS19CQUNLRU5EX1VOS05PV04pIG9uIGZhaWx1cmUsIG9yDQo+PiAg ICAgICAgKiBiYWNrZW5kIG9uIHN1Y2Nlc3MgKi8NCj4+DQo+PiArICAgIGlmICgoc3BlY2lmaWNh dGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJRklDQVRJT05fVklSVElPICYmDQo+PiArICAgICAgICAg YmFja2VuZCAhPSBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9ORSkgfHwNCj4+ICsgICAgICAg IChzcGVjaWZpY2F0aW9uICE9IExJQlhMX0RJU0tfU1BFQ0lGSUNBVElPTl9WSVJUSU8gJiYNCj4+ ICsgICAgICAgICBiYWNrZW5kID09IExJQlhMX0RJU0tfQkFDS0VORF9TVEFOREFMT05FKSkNCj4+ ICsgICAgICAgIGdvdG8gYmFkX3NwZWNpZmljYXRpb247DQo+PiArDQo+PiAgICAgICBzd2l0Y2gg KGJhY2tlbmQpIHsNCj4+ICAgICAgIGNhc2UgTElCWExfRElTS19CQUNLRU5EX1BIWToNCj4+ICAg ICAgICAgICBpZiAoYS0+ZGlzay0+Zm9ybWF0ICE9IExJQlhMX0RJU0tfRk9STUFUX1JBVykgew0K Pj4gQEAgLTMyOSw2ICszMzYsMjkgQEAgc3RhdGljIGludCBkaXNrX3RyeV9iYWNrZW5kKGRpc2tf dHJ5X2JhY2tlbmRfYXJncw0KPj4gKmEsDQo+PiAgICAgICAgICAgaWYgKGEtPmRpc2stPnNjcmlw dCkgZ290byBiYWRfc2NyaXB0Ow0KPj4gICAgICAgICAgIHJldHVybiBiYWNrZW5kOw0KPj4NCj4+ ICsgICAgY2FzZSBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9ORToNCj4+ICsgICAgICAgIGlm IChhLT5kaXNrLT5mb3JtYXQgIT0gTElCWExfRElTS19GT1JNQVRfUkFXKQ0KPj4gKyAgICAgICAg ICAgIGdvdG8gYmFkX2Zvcm1hdDsNCj4+ICsNCj4+ICsgICAgICAgIGlmIChhLT5kaXNrLT5zY3Jp cHQpDQo+PiArICAgICAgICAgICAgZ290byBiYWRfc2NyaXB0Ow0KPj4gKw0KPj4gKyAgICAgICAg aWYgKGxpYnhsX2RlZmJvb2xfdmFsKGEtPmRpc2stPmNvbG9fZW5hYmxlKSkNCj4+ICsgICAgICAg ICAgICBnb3RvIGJhZF9jb2xvOw0KPj4gKw0KPj4gKyAgICAgICAgaWYgKGEtPmRpc2stPmJhY2tl bmRfZG9taWQgIT0gTElCWExfVE9PTFNUQUNLX0RPTUlEKSB7DQo+PiArICAgICAgICAgICAgTE9H KERFQlVHLCAiRGlzayB2ZGV2PSVzLCBpcyB1c2luZyBhIHN0b3JhZ2UgZHJpdmVyIGRvbWFpbiwg Ig0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgInNraXBwaW5nIHBoeXNpY2FsIGRldmljZSBj aGVjayIsIGEtPmRpc2stPnZkZXYpOw0KPj4gKyAgICAgICAgICAgIHJldHVybiBiYWNrZW5kOw0K Pj4gKyAgICAgICAgfQ0KPj4gKw0KPj4gKyAgICAgICAgaWYgKGxpYnhsX190cnlfcGh5X2JhY2tl bmQoYS0+c3RhYi5zdF9tb2RlKSkNCj4+ICsgICAgICAgICAgICByZXR1cm4gYmFja2VuZDsNCj4+ ICsNCj4+ICsgICAgICAgIExPRyhERUJVRywgIkRpc2sgdmRldj0lcywgYmFja2VuZCBzdGFuZGFs b25lIHVuc3VpdGFibGUgYXMgcGh5cw0KPj4gcGF0aCBub3QgYSAiDQo+PiArICAgICAgICAgICAg ICAgICAgICJibG9jayBkZXZpY2UiLCBhLT5kaXNrLT52ZGV2KTsNCj4+ICsgICAgICAgIHJldHVy biAwOw0KPj4gKw0KPj4gICAgICAgZGVmYXVsdDoNCj4+ICAgICAgICAgICBMT0coREVCVUcsICJE aXNrIHZkZXY9JXMsIGJhY2tlbmQgJWQgdW5rbm93biIsIGEtPmRpc2stPnZkZXYsDQo+PiBiYWNr ZW5kKTsNCj4+ICAgICAgICAgICByZXR1cm4gMDsNCj4+IEBAIC0zNTIsNiArMzgyLDEyIEBAIHN0 YXRpYyBpbnQgZGlza190cnlfYmFja2VuZChkaXNrX3RyeV9iYWNrZW5kX2FyZ3MNCj4+ICphLA0K Pj4gICAgICAgTE9HKERFQlVHLCAiRGlzayB2ZGV2PSVzLCBiYWNrZW5kICVzIG5vdCBjb21wYXRp YmxlIHdpdGggY29sbyIsDQo+PiAgICAgICAgICAgYS0+ZGlzay0+dmRldiwgbGlieGxfZGlza19i YWNrZW5kX3RvX3N0cmluZyhiYWNrZW5kKSk7DQo+PiAgICAgICByZXR1cm4gMDsNCj4+ICsNCj4+ ICsgYmFkX3NwZWNpZmljYXRpb246DQo+PiArICAgIExPRyhERUJVRywgIkRpc2sgdmRldj0lcywg YmFja2VuZCAlcyBub3QgY29tcGF0aWJsZSB3aXRoDQo+PiBzcGVjaWZpY2F0aW9uICVzIiwNCj4+ ICsgICAgICAgIGEtPmRpc2stPnZkZXYsIGxpYnhsX2Rpc2tfYmFja2VuZF90b19zdHJpbmcoYmFj a2VuZCksDQo+PiArICAgICAgICBsaWJ4bF9kaXNrX3NwZWNpZmljYXRpb25fdG9fc3RyaW5nKHNw ZWNpZmljYXRpb24pKTsNCj4+ICsgICAgcmV0dXJuIDA7DQo+PiAgIH0NCj4+DQo+PiAgIGludCBs aWJ4bF9fYmFja2VuZHBhdGhfcGFyc2VfZG9taWQobGlieGxfX2djICpnYywgY29uc3QgY2hhciAq YmVfcGF0aCwNCj4+IEBAIC0zNzYsOCArNDEyLDkgQEAgaW50IGxpYnhsX19kZXZpY2VfZGlza19z ZXRfYmFja2VuZChsaWJ4bF9fZ2MgKmdjLA0KPj4gbGlieGxfZGV2aWNlX2Rpc2sgKmRpc2spIHsN Cj4+ICAgICAgIGEuZ2MgPSBnYzsNCj4+ICAgICAgIGEuZGlzayA9IGRpc2s7DQo+Pg0KPj4gLSAg ICBMT0coREVCVUcsICJEaXNrIHZkZXY9JXMgc3BlYy5iYWNrZW5kPSVzIiwgZGlzay0+dmRldiwN Cj4+IC0gICAgICAgICAgICAgICBsaWJ4bF9kaXNrX2JhY2tlbmRfdG9fc3RyaW5nKGRpc2stPmJh Y2tlbmQpKTsNCj4+ICsgICAgTE9HKERFQlVHLCAiRGlzayB2ZGV2PSVzIHNwZWMuYmFja2VuZD0l cyBzcGVjaWZpY2F0aW9uPSVzIiwgZGlzay0NCj4+PiB2ZGV2LA0KPj4gKyAgICAgICAgICAgICAg IGxpYnhsX2Rpc2tfYmFja2VuZF90b19zdHJpbmcoZGlzay0+YmFja2VuZCksDQo+PiArICAgICAg ICAgICAgICAgbGlieGxfZGlza19zcGVjaWZpY2F0aW9uX3RvX3N0cmluZyhkaXNrLT5zcGVjaWZp Y2F0aW9uKSk7DQo+Pg0KPj4gICAgICAgaWYgKGRpc2stPmZvcm1hdCA9PSBMSUJYTF9ESVNLX0ZP Uk1BVF9FTVBUWSkgew0KPj4gICAgICAgICAgIGlmICghZGlzay0+aXNfY2Ryb20pIHsNCj4+IEBA IC0zOTIsNyArNDI5LDggQEAgaW50IGxpYnhsX19kZXZpY2VfZGlza19zZXRfYmFja2VuZChsaWJ4 bF9fZ2MgKmdjLA0KPj4gbGlieGxfZGV2aWNlX2Rpc2sgKmRpc2spIHsNCj4+ICAgICAgICAgICB9 DQo+PiAgICAgICAgICAgbWVtc2V0KCZhLnN0YWIsIDAsIHNpemVvZihhLnN0YWIpKTsNCj4+ICAg ICAgIH0gZWxzZSBpZiAoKGRpc2stPmJhY2tlbmQgPT0gTElCWExfRElTS19CQUNLRU5EX1VOS05P V04gfHwNCj4+IC0gICAgICAgICAgICAgICAgZGlzay0+YmFja2VuZCA9PSBMSUJYTF9ESVNLX0JB Q0tFTkRfUEhZKSAmJg0KPj4gKyAgICAgICAgICAgICAgICBkaXNrLT5iYWNrZW5kID09IExJQlhM X0RJU0tfQkFDS0VORF9QSFkgfHwNCj4+ICsgICAgICAgICAgICAgICAgZGlzay0+YmFja2VuZCA9 PSBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9ORSkgJiYNCj4+ICAgICAgICAgICAgICAgICAg ZGlzay0+YmFja2VuZF9kb21pZCA9PSBMSUJYTF9UT09MU1RBQ0tfRE9NSUQgJiYNCj4+ICAgICAg ICAgICAgICAgICAgIWRpc2stPnNjcmlwdCkgew0KPj4gICAgICAgICAgIGlmIChzdGF0KGRpc2st PnBkZXZfcGF0aCwgJmEuc3RhYikpIHsNCj4+IEBAIC00MDgsNyArNDQ2LDggQEAgaW50IGxpYnhs X19kZXZpY2VfZGlza19zZXRfYmFja2VuZChsaWJ4bF9fZ2MgKmdjLA0KPj4gbGlieGxfZGV2aWNl X2Rpc2sgKmRpc2spIHsNCj4+ICAgICAgICAgICBvaz0NCj4+ICAgICAgICAgICAgICAgZGlza190 cnlfYmFja2VuZCgmYSwgTElCWExfRElTS19CQUNLRU5EX1BIWSkgPzoNCj4+ICAgICAgICAgICAg ICAgZGlza190cnlfYmFja2VuZCgmYSwgTElCWExfRElTS19CQUNLRU5EX1FESVNLKSA/Og0KPj4g LSAgICAgICAgICAgIGRpc2tfdHJ5X2JhY2tlbmQoJmEsIExJQlhMX0RJU0tfQkFDS0VORF9UQVAp Ow0KPj4gKyAgICAgICAgICAgIGRpc2tfdHJ5X2JhY2tlbmQoJmEsIExJQlhMX0RJU0tfQkFDS0VO RF9UQVApID86DQo+PiArICAgICAgICAgICAgZGlza190cnlfYmFja2VuZCgmYSwgTElCWExfRElT S19CQUNLRU5EX1NUQU5EQUxPTkUpOw0KPj4gICAgICAgICAgIGlmIChvaykNCj4+ICAgICAgICAg ICAgICAgTE9HKERFQlVHLCAiRGlzayB2ZGV2PSVzLCB1c2luZyBiYWNrZW5kICVzIiwNCj4+ICAg ICAgICAgICAgICAgICAgICAgICAgICBkaXNrLT52ZGV2LA0KPj4gQEAgLTQ0MSwxMCArNDgwLDI1 IEBAIGNoYXINCj4+ICpsaWJ4bF9fZGV2aWNlX2Rpc2tfc3RyaW5nX29mX2JhY2tlbmQobGlieGxf ZGlza19iYWNrZW5kIGJhY2tlbmQpDQo+PiAgICAgICAgICAgY2FzZSBMSUJYTF9ESVNLX0JBQ0tF TkRfUURJU0s6IHJldHVybiAicWRpc2siOw0KPj4gICAgICAgICAgIGNhc2UgTElCWExfRElTS19C QUNLRU5EX1RBUDogcmV0dXJuICJwaHkiOw0KPj4gICAgICAgICAgIGNhc2UgTElCWExfRElTS19C QUNLRU5EX1BIWTogcmV0dXJuICJwaHkiOw0KPj4gKyAgICAgICAgY2FzZSBMSUJYTF9ESVNLX0JB Q0tFTkRfU1RBTkRBTE9ORTogcmV0dXJuICJzdGFuZGFsb25lIjsNCj4+ICsgICAgICAgIGRlZmF1 bHQ6IHJldHVybiBOVUxMOw0KPj4gKyAgICB9DQo+PiArfQ0KPj4gKw0KPj4gK2NoYXIgKmxpYnhs X19kZXZpY2VfZGlza19zdHJpbmdfb2Zfc3BlY2lmaWNhdGlvbihsaWJ4bF9kaXNrX3NwZWNpZmlj YXRpb24NCj4+IHNwZWNpZmljYXRpb24pDQo+PiArew0KPj4gKyAgICBzd2l0Y2ggKHNwZWNpZmlj YXRpb24pIHsNCj4+ICsgICAgICAgIGNhc2UgTElCWExfRElTS19TUEVDSUZJQ0FUSU9OX1hFTjog cmV0dXJuICJ4ZW4iOw0KPj4gKyAgICAgICAgY2FzZSBMSUJYTF9ESVNLX1NQRUNJRklDQVRJT05f VklSVElPOiByZXR1cm4gInZpcnRpbyI7DQo+PiAgICAgICAgICAgZGVmYXVsdDogcmV0dXJuIE5V TEw7DQo+PiAgICAgICB9DQo+PiAgIH0NCj4+DQo+PiArY2hhciAqbGlieGxfX2RldmljZV9kaXNr X3N0cmluZ19vZl90cmFuc3BvcnQobGlieGxfZGlza190cmFuc3BvcnQgdHJhbnNwb3J0KQ0KPj4g K3sNCj4+ICsgICAgcmV0dXJuICh0cmFuc3BvcnQgPT0gTElCWExfRElTS19UUkFOU1BPUlRfTU1J TyA/ICJtbWlvIiA6IE5VTEwpOw0KPj4gK30NCj4+ICsNCj4+ICAgY29uc3QgY2hhciAqbGlieGxf X3FlbXVfZGlza19mb3JtYXRfc3RyaW5nKGxpYnhsX2Rpc2tfZm9ybWF0IGZvcm1hdCkNCj4+ICAg ew0KPj4gICAgICAgc3dpdGNoIChmb3JtYXQpIHsNCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJz L2xpZ2h0L2xpYnhsX2Rpc2suYyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZGlzay5jDQo+PiBp bmRleCA5ZGEyYjJlZDI3Li5lYTM2MjNkZDZmIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9s aWdodC9saWJ4bF9kaXNrLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfZGlzay5j DQo+PiBAQCAtMTY0LDYgKzE2NCwzMCBAQCBzdGF0aWMgaW50IGxpYnhsX19kZXZpY2VfZGlza19z ZXRkZWZhdWx0KGxpYnhsX19nYyAqZ2MsDQo+PiB1aW50MzJfdCBkb21pZCwNCj4+ICAgICAgIHJj ID0gbGlieGxfX3Jlc29sdmVfZG9taWQoZ2MsIGRpc2stPmJhY2tlbmRfZG9tbmFtZSwgJmRpc2st DQo+Pj4gYmFja2VuZF9kb21pZCk7DQo+PiAgICAgICBpZiAocmMgPCAwKSByZXR1cm4gcmM7DQo+ Pg0KPj4gKyAgICBpZiAoZGlzay0+c3BlY2lmaWNhdGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJRklD QVRJT05fVU5LTk9XTikNCj4+ICsgICAgICAgIGRpc2stPnNwZWNpZmljYXRpb24gPSBMSUJYTF9E SVNLX1NQRUNJRklDQVRJT05fWEVOOw0KPj4gKw0KPj4gKyAgICBpZiAoZGlzay0+c3BlY2lmaWNh dGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJRklDQVRJT05fWEVOICYmDQo+PiArICAgICAgICBkaXNr LT50cmFuc3BvcnQgIT0gTElCWExfRElTS19UUkFOU1BPUlRfVU5LTk9XTikgew0KPj4gKyAgICAg ICAgTE9HRChFUlJPUiwgZG9taWQsICJUcmFuc3BvcnQgaXMgb25seSBzdXBwb3J0ZWQgZm9yIHNw ZWNpZmljYXRpb24NCj4+IHZpcnRpbyIpOw0KPj4gKyAgICAgICAgcmV0dXJuIEVSUk9SX0lOVkFM Ow0KPj4gKyAgICB9DQo+PiArDQo+PiArICAgIC8qIEZvcmNlIHRyYW5zcG9ydCBtbWlvIGZvciBz cGVjaWZpY2F0aW9uIHZpcnRpbyBmb3Igbm93ICovDQo+PiArICAgIGlmIChkaXNrLT5zcGVjaWZp Y2F0aW9uID09IExJQlhMX0RJU0tfU1BFQ0lGSUNBVElPTl9WSVJUSU8pIHsNCj4+ICsgICAgICAg IGlmICghKGRpc2stPnRyYW5zcG9ydCA9PSBMSUJYTF9ESVNLX1RSQU5TUE9SVF9VTktOT1dOIHx8 DQo+PiArICAgICAgICAgICAgICBkaXNrLT50cmFuc3BvcnQgPT0gTElCWExfRElTS19UUkFOU1BP UlRfTU1JTykpIHsNCj4+ICsgICAgICAgICAgICBMT0dEKEVSUk9SLCBkb21pZCwgIlVuc3VwcG9y dGVkIHRyYW5zcG9ydCBmb3Igc3BlY2lmaWNhdGlvbg0KPj4gdmlydGlvIik7DQo+PiArICAgICAg ICAgICAgcmV0dXJuIEVSUk9SX0lOVkFMOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgZGlz ay0+dHJhbnNwb3J0ID0gTElCWExfRElTS19UUkFOU1BPUlRfTU1JTzsNCj4+ICsgICAgfQ0KPj4g Kw0KPj4gKyAgICBpZiAoaG90cGx1ZyAmJiBkaXNrLT5zcGVjaWZpY2F0aW9uID09IExJQlhMX0RJ U0tfU1BFQ0lGSUNBVElPTl9WSVJUSU8pIHsNCj4+ICsgICAgICAgIExPR0QoRVJST1IsIGRvbWlk LCAiSG90cGx1ZyBpc24ndCBzdXBwb3J0ZWQgZm9yIHNwZWNpZmljYXRpb24gdmlydGlvIik7DQo+ PiArICAgICAgICByZXR1cm4gRVJST1JfRkFJTDsNCj4+ICsgICAgfQ0KPj4gKw0KPj4gICAgICAg LyogRm9yY2UgUWRpc2sgYmFja2VuZCBmb3IgQ0RST00gZGV2aWNlcyBvZiBndWVzdHMgd2l0aCBh IGRldmljZSBtb2RlbC4NCj4+ICovDQo+PiAgICAgICBpZiAoZGlzay0+aXNfY2Ryb20gIT0gMCAm Jg0KPj4gICAgICAgICAgIGxpYnhsX19kb21haW5fdHlwZShnYywgZG9taWQpID09IExJQlhMX0RP TUFJTl9UWVBFX0hWTSkgew0KPj4gQEAgLTIwNSw2ICsyMjksOSBAQCBzdGF0aWMgaW50IGxpYnhs X19kZXZpY2VfZnJvbV9kaXNrKGxpYnhsX19nYyAqZ2MsDQo+PiB1aW50MzJfdCBkb21pZCwNCj4+ ICAgICAgICAgICBjYXNlIExJQlhMX0RJU0tfQkFDS0VORF9RRElTSzoNCj4+ICAgICAgICAgICAg ICAgZGV2aWNlLT5iYWNrZW5kX2tpbmQgPSBMSUJYTF9fREVWSUNFX0tJTkRfUURJU0s7DQo+PiAg ICAgICAgICAgICAgIGJyZWFrOw0KPj4gKyAgICAgICAgY2FzZSBMSUJYTF9ESVNLX0JBQ0tFTkRf U1RBTkRBTE9ORToNCj4+ICsgICAgICAgICAgICBkZXZpY2UtPmJhY2tlbmRfa2luZCA9IExJQlhM X19ERVZJQ0VfS0lORF9WSVJUSU9fRElTSzsNCj4+ICsgICAgICAgICAgICBicmVhazsNCj4+ICAg ICAgICAgICBkZWZhdWx0Og0KPj4gICAgICAgICAgICAgICBMT0dEKEVSUk9SLCBkb21pZCwgIlVu cmVjb2duaXplZCBkaXNrIGJhY2tlbmQgdHlwZTogJWQiLA0KPj4gICAgICAgICAgICAgICAgICAg IGRpc2stPmJhY2tlbmQpOw0KPj4gQEAgLTIxMyw3ICsyNDAsOCBAQCBzdGF0aWMgaW50IGxpYnhs X19kZXZpY2VfZnJvbV9kaXNrKGxpYnhsX19nYyAqZ2MsDQo+PiB1aW50MzJfdCBkb21pZCwNCj4+ DQo+PiAgICAgICBkZXZpY2UtPmRvbWlkID0gZG9taWQ7DQo+PiAgICAgICBkZXZpY2UtPmRldmlk ID0gZGV2aWQ7DQo+PiAtICAgIGRldmljZS0+a2luZCAgPSBMSUJYTF9fREVWSUNFX0tJTkRfVkJE Ow0KPj4gKyAgICBkZXZpY2UtPmtpbmQgPSBkaXNrLT5iYWNrZW5kID09IExJQlhMX0RJU0tfQkFD S0VORF9TVEFOREFMT05FID8NCj4+ICsgICAgICAgIExJQlhMX19ERVZJQ0VfS0lORF9WSVJUSU9f RElTSyA6IExJQlhMX19ERVZJQ0VfS0lORF9WQkQ7DQo+Pg0KPj4gICAgICAgcmV0dXJuIDA7DQo+ PiAgIH0NCj4+IEBAIC0zMzEsNyArMzU5LDE0IEBAIHN0YXRpYyB2b2lkIGRldmljZV9kaXNrX2Fk ZChsaWJ4bF9fZWdjICplZ2MsDQo+PiB1aW50MzJfdCBkb21pZCwNCj4+DQo+PiAgICAgICAgICAg ICAgICAgICBhc3NlcnQoZGV2aWNlLT5iYWNrZW5kX2tpbmQgPT0gTElCWExfX0RFVklDRV9LSU5E X1ZCRCk7DQo+PiAgICAgICAgICAgICAgICAgICBicmVhazsNCj4+ICsgICAgICAgICAgICBjYXNl IExJQlhMX0RJU0tfQkFDS0VORF9TVEFOREFMT05FOg0KPj4gKyAgICAgICAgICAgICAgICBkZXYg PSBkaXNrLT5wZGV2X3BhdGg7DQo+PiArDQo+PiArICAgICAgICAgICAgICAgIGZsZXhhcnJheV9h cHBlbmQoYmFjaywgInBhcmFtcyIpOw0KPj4gKyAgICAgICAgICAgICAgICBmbGV4YXJyYXlfYXBw ZW5kKGJhY2ssIGRldik7DQo+Pg0KPj4gKyAgICAgICAgICAgICAgICBhc3NlcnQoZGV2aWNlLT5i YWNrZW5kX2tpbmQgPT0NCj4+IExJQlhMX19ERVZJQ0VfS0lORF9WSVJUSU9fRElTSyk7DQo+PiAr ICAgICAgICAgICAgICAgIGJyZWFrOw0KPj4gICAgICAgICAgICAgICBjYXNlIExJQlhMX0RJU0tf QkFDS0VORF9UQVA6DQo+PiAgICAgICAgICAgICAgICAgICBMT0coRVJST1IsICJibGt0YXAgaXMg bm90IHN1cHBvcnRlZCIpOw0KPj4gICAgICAgICAgICAgICAgICAgcmMgPSBFUlJPUl9GQUlMOw0K Pj4gQEAgLTM4Nyw2ICs0MjIsMTQgQEAgc3RhdGljIHZvaWQgZGV2aWNlX2Rpc2tfYWRkKGxpYnhs X19lZ2MgKmVnYywNCj4+IHVpbnQzMl90IGRvbWlkLA0KPj4gICAgICAgICAgIGZsZXhhcnJheV9h cHBlbmRfcGFpcihiYWNrLCAiZGlzY2FyZC1lbmFibGUiLA0KPj4gICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBsaWJ4bF9kZWZib29sX3ZhbChkaXNrLT5kaXNjYXJkX2VuYWJsZSkgPw0K Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiMSIgOiAiMCIpOw0KPj4gKyAgICAg ICAgZmxleGFycmF5X2FwcGVuZChiYWNrLCAic3BlY2lmaWNhdGlvbiIpOw0KPj4gKyAgICAgICAg ZmxleGFycmF5X2FwcGVuZChiYWNrLCBsaWJ4bF9fZGV2aWNlX2Rpc2tfc3RyaW5nX29mX3NwZWNp ZmljYXRpb24oZGlzay0NCj4+PiBzcGVjaWZpY2F0aW9uKSk7DQo+PiArICAgICAgICBpZiAoZGlz ay0+c3BlY2lmaWNhdGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJRklDQVRJT05fVklSVElPKSB7DQo+ PiArICAgICAgICAgICAgZmxleGFycmF5X2FwcGVuZChiYWNrLCAidHJhbnNwb3J0Iik7DQo+PiAr ICAgICAgICAgICAgZmxleGFycmF5X2FwcGVuZChiYWNrLCBsaWJ4bF9fZGV2aWNlX2Rpc2tfc3Ry aW5nX29mX3RyYW5zcG9ydChkaXNrLQ0KPj4+IHRyYW5zcG9ydCkpOw0KPj4gKyAgICAgICAgICAg IGZsZXhhcnJheV9hcHBlbmRfcGFpcihiYWNrLCAiYmFzZSIsIEdDU1BSSU5URigiJSJQUkl1NjQs IGRpc2stDQo+Pj4gYmFzZSkpOw0KPj4gKyAgICAgICAgICAgIGZsZXhhcnJheV9hcHBlbmRfcGFp cihiYWNrLCAiaXJxIiwgR0NTUFJJTlRGKCIldSIsIGRpc2stPmlycSkpOw0KPj4gKyAgICAgICAg fQ0KPj4NCj4+ICAgICAgICAgICBmbGV4YXJyYXlfYXBwZW5kKGZyb250LCAiYmFja2VuZC1pZCIp Ow0KPj4gICAgICAgICAgIGZsZXhhcnJheV9hcHBlbmQoZnJvbnQsIEdDU1BSSU5URigiJWQiLCBk aXNrLT5iYWNrZW5kX2RvbWlkKSk7DQo+PiBAQCAtNTM1LDYgKzU3OCw1MyBAQCBzdGF0aWMgaW50 IGxpYnhsX19kaXNrX2Zyb21feGVuc3RvcmUobGlieGxfX2djICpnYywNCj4+IGNvbnN0IGNoYXIg KmxpYnhsX3BhdGgsDQo+PiAgICAgICB9DQo+PiAgICAgICBsaWJ4bF9zdHJpbmdfdG9fYmFja2Vu ZChjdHgsIHRtcCwgJihkaXNrLT5iYWNrZW5kKSk7DQo+Pg0KPj4gKyAgICB0bXAgPSBsaWJ4bF9f eHNfcmVhZChnYywgWEJUX05VTEwsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgIEdDU1BS SU5URigiJXMvc3BlY2lmaWNhdGlvbiIsIGxpYnhsX3BhdGgpKTsNCj4+ICsgICAgaWYgKCF0bXAp IHsNCj4+ICsgICAgICAgIExPRyhERUJVRywgIk1pc3NpbmcgeGVuc3RvcmUgbm9kZSAlcy9zcGVj aWZpY2F0aW9uLCBhc3N1bWluZw0KPj4gc3BlY2lmaWNhdGlvbiB4ZW4iLCBsaWJ4bF9wYXRoKTsN Cj4+ICsgICAgICAgIGRpc2stPnNwZWNpZmljYXRpb24gPSBMSUJYTF9ESVNLX1NQRUNJRklDQVRJ T05fWEVOOw0KPj4gKyAgICB9IGVsc2Ugew0KPj4gKyAgICAgICAgcmMgPSBsaWJ4bF9kaXNrX3Nw ZWNpZmljYXRpb25fZnJvbV9zdHJpbmcodG1wLCAmZGlzay0+c3BlY2lmaWNhdGlvbik7DQo+PiAr ICAgICAgICBpZiAocmMpIHsNCj4+ICsgICAgICAgICAgICBMT0coRVJST1IsICJVbmFibGUgdG8g cGFyc2UgeGVuc3RvcmUgbm9kZSAlcy9zcGVjaWZpY2F0aW9uIiwNCj4+IGxpYnhsX3BhdGgpOw0K Pj4gKyAgICAgICAgICAgIGdvdG8gY2xlYW51cDsNCj4+ICsgICAgICAgIH0NCj4+ICsgICAgfQ0K Pj4gKw0KPj4gKyAgICBpZiAoZGlzay0+c3BlY2lmaWNhdGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJ RklDQVRJT05fVklSVElPKSB7DQo+PiArICAgICAgICB0bXAgPSBsaWJ4bF9feHNfcmVhZChnYywg WEJUX05VTEwsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHQ1NQUklOVEYoIiVz L3RyYW5zcG9ydCIsIGxpYnhsX3BhdGgpKTsNCj4+ICsgICAgICAgIGlmICghdG1wKSB7DQo+PiAr ICAgICAgICAgICAgTE9HKEVSUk9SLCAiTWlzc2luZyB4ZW5zdG9yZSBub2RlICVzL3RyYW5zcG9y dCIsIGxpYnhsX3BhdGgpOw0KPj4gKyAgICAgICAgICAgIGdvdG8gY2xlYW51cDsNCj4+ICsgICAg ICAgIH0NCj4+ICsgICAgICAgIHJjID0gbGlieGxfZGlza190cmFuc3BvcnRfZnJvbV9zdHJpbmco dG1wLCAmZGlzay0+dHJhbnNwb3J0KTsNCj4+ICsgICAgICAgIGlmIChyYykgew0KPj4gKyAgICAg ICAgICAgIExPRyhFUlJPUiwgIlVuYWJsZSB0byBwYXJzZSB4ZW5zdG9yZSBub2RlICVzL3RyYW5z cG9ydCIsDQo+PiBsaWJ4bF9wYXRoKTsNCj4+ICsgICAgICAgICAgICBnb3RvIGNsZWFudXA7DQo+ PiArICAgICAgICB9DQo+PiArICAgICAgICBpZiAoZGlzay0+dHJhbnNwb3J0ICE9IExJQlhMX0RJ U0tfVFJBTlNQT1JUX01NSU8pIHsNCj4+ICsgICAgICAgICAgICBMT0coRVJST1IsICJPbmx5IHRy YW5zcG9ydCBtbWlvIGlzIGV4cGVjdGVkIGZvciBzcGVjaWZpY2F0aW9uDQo+PiB2aXJ0aW8iKTsN Cj4+ICsgICAgICAgICAgICBnb3RvIGNsZWFudXA7DQo+PiArICAgICAgICB9DQo+PiArDQo+PiAr ICAgICAgICB0bXAgPSBsaWJ4bF9feHNfcmVhZChnYywgWEJUX05VTEwsDQo+PiArICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBHQ1NQUklOVEYoIiVzL2Jhc2UiLCBsaWJ4bF9wYXRoKSk7DQo+ PiArICAgICAgICBpZiAoIXRtcCkgew0KPj4gKyAgICAgICAgICAgIExPRyhFUlJPUiwgIk1pc3Np bmcgeGVuc3RvcmUgbm9kZSAlcy9iYXNlIiwgbGlieGxfcGF0aCk7DQo+PiArICAgICAgICAgICAg Z290byBjbGVhbnVwOw0KPj4gKyAgICAgICAgfQ0KPj4gKyAgICAgICAgZGlzay0+YmFzZSA9IHN0 cnRvdWwodG1wLCBOVUxMLCAxMCk7DQo+PiArDQo+PiArICAgICAgICB0bXAgPSBsaWJ4bF9feHNf cmVhZChnYywgWEJUX05VTEwsDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHQ1NQ UklOVEYoIiVzL2lycSIsIGxpYnhsX3BhdGgpKTsNCj4+ICsgICAgICAgIGlmICghdG1wKSB7DQo+ PiArICAgICAgICAgICAgTE9HKEVSUk9SLCAiTWlzc2luZyB4ZW5zdG9yZSBub2RlICVzL2lycSIs IGxpYnhsX3BhdGgpOw0KPj4gKyAgICAgICAgICAgIGdvdG8gY2xlYW51cDsNCj4+ICsgICAgICAg IH0NCj4+ICsgICAgICAgIGRpc2stPmlycSA9IHN0cnRvdWwodG1wLCBOVUxMLCAxMCk7DQo+PiAr ICAgIH0NCj4+ICsNCj4+ICAgICAgIGRpc2stPnZkZXYgPSB4c19yZWFkKGN0eC0+eHNoLCBYQlRf TlVMTCwNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDU1BSSU5URigiJXMvZGV2Iiwg bGlieGxfcGF0aCksICZsZW4pOw0KPj4gICAgICAgaWYgKCFkaXNrLT52ZGV2KSB7DQo+PiBAQCAt NTc4LDYgKzY2OCw0MiBAQCBjbGVhbnVwOg0KPj4gICAgICAgcmV0dXJuIHJjOw0KPj4gICB9DQo+ Pg0KPj4gK3N0YXRpYyBpbnQgbGlieGxfX2RldmljZV9kaXNrX2dldF9wYXRoKGxpYnhsX19nYyAq Z2MsIHVpbnQzMl90IGRvbWlkLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGNoYXIgKipwYXRoKQ0KPj4gK3sNCj4+ICsgICAgY29uc3QgY2hhciAqeGVuX2Rpciwg KnZpcnRpb19kaXI7DQo+PiArICAgIGNoYXIgKnhlbl9wYXRoLCAqdmlydGlvX3BhdGg7DQo+PiAr ICAgIGludCByYzsNCj4+ICsNCj4+ICsgICAgLyogZGVmYXVsdCBwYXRoICovDQo+PiArICAgIHhl bl9wYXRoID0gR0NTUFJJTlRGKCIlcy9kZXZpY2UvJXMiLA0KPj4gKyAgICAgICAgICAgICAgICAg ICAgICAgICBsaWJ4bF9feHNfbGlieGxfcGF0aChnYywgZG9taWQpLA0KPj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICBsaWJ4bF9fZGV2aWNlX2tpbmRfdG9fc3RyaW5nKExJQlhMX19ERVZJQ0Vf S0lORF9WQkQpKTsNCj4+ICsNCj4+ICsgICAgcmMgPSBsaWJ4bF9feHNfcmVhZF9jaGVja2VkKGdj LCBYQlRfTlVMTCwgeGVuX3BhdGgsICZ4ZW5fZGlyKTsNCj4+ICsgICAgaWYgKHJjKQ0KPj4gKyAg ICAgICAgcmV0dXJuIHJjOw0KPj4gKw0KPj4gKyAgICB2aXJ0aW9fcGF0aCA9IEdDU1BSSU5URigi JXMvZGV2aWNlLyVzIiwNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlieGxfX3hz X2xpYnhsX3BhdGgoZ2MsIGRvbWlkKSwNCj4+ICsNCj4+IGxpYnhsX19kZXZpY2Vfa2luZF90b19z dHJpbmcoTElCWExfX0RFVklDRV9LSU5EX1ZJUlRJT19ESVNLKSk7DQo+PiArDQo+PiArICAgIHJj ID0gbGlieGxfX3hzX3JlYWRfY2hlY2tlZChnYywgWEJUX05VTEwsIHZpcnRpb19wYXRoLCAmdmly dGlvX2Rpcik7DQo+PiArICAgIGlmIChyYykNCj4+ICsgICAgICAgIHJldHVybiByYzsNCj4+ICsN Cj4+ICsgICAgaWYgKHhlbl9kaXIgJiYgdmlydGlvX2Rpcikgew0KPj4gKyAgICAgICAgTE9HRChF UlJPUiwgZG9taWQsICJJbnZhbGlkIGNvbmZpZ3VyYXRpb24sIGJvdGggeGVuIGFuZCB2aXJ0aW8g cGF0aHMNCj4+IGFyZSBwcmVzZW50Iik7DQo+PiArICAgICAgICByZXR1cm4gRVJST1JfSU5WQUw7 DQo+PiArICAgIH0gZWxzZSBpZiAodmlydGlvX2Rpcikgew0KPj4gKyAgICAgICAgKnBhdGggPSB2 aXJ0aW9fcGF0aDsNCj4+ICsgICAgfSBlbHNlIHsNCj4+ICsgICAgICAgICpwYXRoID0geGVuX3Bh dGg7DQo+PiArICAgIH0NCj4+ICsNCj4+ICsgICAgcmV0dXJuIDA7DQo+PiArfQ0KPj4gKw0KPj4g ICBpbnQgbGlieGxfdmRldl90b19kZXZpY2VfZGlzayhsaWJ4bF9jdHggKmN0eCwgdWludDMyX3Qg ZG9taWQsDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IGNoYXIgKnZk ZXYsIGxpYnhsX2RldmljZV9kaXNrICpkaXNrKQ0KPj4gICB7DQo+PiBAQCAtNTkxLDEwICs3MTcs MTIgQEAgaW50IGxpYnhsX3ZkZXZfdG9fZGV2aWNlX2Rpc2sobGlieGxfY3R4ICpjdHgsDQo+PiB1 aW50MzJfdCBkb21pZCwNCj4+DQo+PiAgICAgICBsaWJ4bF9kZXZpY2VfZGlza19pbml0KGRpc2sp Ow0KPj4NCj4+IC0gICAgbGlieGxfcGF0aCA9IGxpYnhsX19kb21haW5fZGV2aWNlX2xpYnhsX3Bh dGgoZ2MsIGRvbWlkLCBkZXZpZCwNCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgTElCWExfX0RFVklDRV9LSU5EX1ZCRCk7DQo+PiArICAgIHJjID0g bGlieGxfX2RldmljZV9kaXNrX2dldF9wYXRoKGdjLCBkb21pZCwgJmxpYnhsX3BhdGgpOw0KPj4g KyAgICBpZiAocmMpDQo+PiArICAgICAgICByZXR1cm4gcmM7DQo+Pg0KPj4gLSAgICByYyA9IGxp YnhsX19kaXNrX2Zyb21feGVuc3RvcmUoZ2MsIGxpYnhsX3BhdGgsIGRldmlkLCBkaXNrKTsNCj4+ ICsgICAgcmMgPSBsaWJ4bF9fZGlza19mcm9tX3hlbnN0b3JlKGdjLCBHQ1NQUklOVEYoIiVzLyVk IiwgbGlieGxfcGF0aCwgZGV2aWQpLA0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgZGV2aWQsIGRpc2spOw0KPj4NCj4+ICAgICAgIEdDX0ZSRUU7DQo+PiAgICAgICByZXR1 cm4gcmM7DQo+PiBAQCAtNjA4LDE2ICs3MzYsMTkgQEAgaW50IGxpYnhsX2RldmljZV9kaXNrX2dl dGluZm8obGlieGxfY3R4ICpjdHgsDQo+PiB1aW50MzJfdCBkb21pZCwNCj4+ICAgICAgIGNoYXIg KmZlX3BhdGgsICpsaWJ4bF9wYXRoOw0KPj4gICAgICAgY2hhciAqdmFsOw0KPj4gICAgICAgaW50 IHJjOw0KPj4gKyAgICBsaWJ4bF9fZGV2aWNlX2tpbmQga2luZDsNCj4+DQo+PiAgICAgICBkaXNr aW5mby0+YmFja2VuZCA9IE5VTEw7DQo+Pg0KPj4gICAgICAgZGlza2luZm8tPmRldmlkID0gbGli eGxfX2RldmljZV9kaXNrX2Rldl9udW1iZXIoZGlzay0+dmRldiwgTlVMTCwgTlVMTCk7DQo+Pg0K Pj4gLSAgICAvKiB0YXAgZGV2aWNlcyBlbnRyaWVzIGluIHhlbnN0b3JlIGFyZSB3cml0dGVuIGFz IHZiZCBkZXZpY2VzLiAqLw0KPj4gKyAgICAvKiB0YXAgZGV2aWNlcyBlbnRyaWVzIGluIHhlbnN0 b3JlIGFyZSB3cml0dGVuIGFzIHZiZC92aXJ0aW9fZGlzayBkZXZpY2VzLg0KPj4gKi8NCj4+ICsg ICAga2luZCA9IGRpc2stPmJhY2tlbmQgPT0gTElCWExfRElTS19CQUNLRU5EX1NUQU5EQUxPTkUg Pw0KPj4gKyAgICAgICAgTElCWExfX0RFVklDRV9LSU5EX1ZJUlRJT19ESVNLIDogTElCWExfX0RF VklDRV9LSU5EX1ZCRDsNCj4+ICAgICAgIGZlX3BhdGggPSBsaWJ4bF9fZG9tYWluX2RldmljZV9m cm9udGVuZF9wYXRoKGdjLCBkb21pZCwgZGlza2luZm8tDQo+Pj4gZGV2aWQsDQo+PiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIExJQlhMX19ERVZJQ0Vf S0lORF9WQkQpOw0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBraW5kKTsNCj4+ICAgICAgIGxpYnhsX3BhdGggPSBsaWJ4bF9fZG9tYWluX2Rldmlj ZV9saWJ4bF9wYXRoKGdjLCBkb21pZCwgZGlza2luZm8tPmRldmlkLA0KPj4gLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBMSUJYTF9fREVWSUNFX0tJTkRf VkJEKTsNCj4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAga2luZCk7DQo+PiAgICAgICBkaXNraW5mby0+YmFja2VuZCA9IHhzX3JlYWQoY3R4LT54c2gs IFhCVF9OVUxMLA0KPj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIEdDU1BSSU5U RigiJXMvYmFja2VuZCIsIGxpYnhsX3BhdGgpLCBOVUxMKTsNCj4+ICAgICAgIGlmICghZGlza2lu Zm8tPmJhY2tlbmQpIHsNCj4+IEBAIC0xNDIxLDYgKzE1NTIsNyBAQCBMSUJYTF9ERUZJTkVfREVW SUNFX0xJU1QoZGlzaykNCj4+ICAgI2RlZmluZSBsaWJ4bF9fZGV2aWNlX2Rpc2tfdXBkYXRlX2Rl dmlkIE5VTEwNCj4+DQo+PiAgIERFRklORV9ERVZJQ0VfVFlQRV9TVFJVQ1QoZGlzaywgVkJELCBk aXNrcywNCj4+ICsgICAgLmdldF9wYXRoICAgID0gbGlieGxfX2RldmljZV9kaXNrX2dldF9wYXRo LA0KPj4gICAgICAgLm1lcmdlICAgICAgID0gbGlieGxfZGV2aWNlX2Rpc2tfbWVyZ2UsDQo+PiAg ICAgICAuZG1fbmVlZGVkICAgPSBsaWJ4bF9kZXZpY2VfZGlza19kbV9uZWVkZWQsDQo+PiAgICAg ICAuZnJvbV94ZW5zdG9yZSA9IChkZXZpY2VfZnJvbV94ZW5zdG9yZV9mbl90KWxpYnhsX19kaXNr X2Zyb21feGVuc3RvcmUsDQo+PiBkaWZmIC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF9p bnRlcm5hbC5oIGIvdG9vbHMvbGlicy9saWdodC9saWJ4bF9pbnRlcm5hbC5oDQo+PiBpbmRleCBi ZGVmNWE2MDVlLi5jYjllOGIzYjhiIDEwMDY0NA0KPj4gLS0tIGEvdG9vbHMvbGlicy9saWdodC9s aWJ4bF9pbnRlcm5hbC5oDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX2ludGVybmFs LmgNCj4+IEBAIC0xNDkzLDYgKzE0OTMsOCBAQCBfaGlkZGVuIGNoYXIgKg0KPj4gbGlieGxfX2Rv bWFpbl9wdmNvbnRyb2xfcmVhZChsaWJ4bF9fZ2MgKmdjLA0KPj4NCj4+ICAgLyogZnJvbSB4bF9k ZXZpY2UgKi8NCj4+ICAgX2hpZGRlbiBjaGFyICpsaWJ4bF9fZGV2aWNlX2Rpc2tfc3RyaW5nX29m X2JhY2tlbmQobGlieGxfZGlza19iYWNrZW5kDQo+PiBiYWNrZW5kKTsNCj4+ICtfaGlkZGVuIGNo YXINCj4+ICpsaWJ4bF9fZGV2aWNlX2Rpc2tfc3RyaW5nX29mX3NwZWNpZmljYXRpb24obGlieGxf ZGlza19zcGVjaWZpY2F0aW9uDQo+PiBzcGVjaWZpY2F0aW9uKTsNCj4+ICtfaGlkZGVuIGNoYXIg KmxpYnhsX19kZXZpY2VfZGlza19zdHJpbmdfb2ZfdHJhbnNwb3J0KGxpYnhsX2Rpc2tfdHJhbnNw b3J0DQo+PiB0cmFuc3BvcnQpOw0KPj4gICBfaGlkZGVuIGNoYXIgKmxpYnhsX19kZXZpY2VfZGlz a19zdHJpbmdfb2ZfZm9ybWF0KGxpYnhsX2Rpc2tfZm9ybWF0DQo+PiBmb3JtYXQpOw0KPj4gICBf aGlkZGVuIGNvbnN0IGNoYXIgKmxpYnhsX19xZW11X2Rpc2tfZm9ybWF0X3N0cmluZyhsaWJ4bF9k aXNrX2Zvcm1hdA0KPj4gZm9ybWF0KTsNCj4+ICAgX2hpZGRlbiBpbnQgbGlieGxfX2RldmljZV9k aXNrX3NldF9iYWNrZW5kKGxpYnhsX19nYyosIGxpYnhsX2RldmljZV9kaXNrKik7DQo+PiBkaWZm IC0tZ2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF90eXBlcy5pZGwgYi90b29scy9saWJzL2xp Z2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gaW5kZXggZjNjZWIzOGM5ZS4uZDYzNGYzMDRjZCAxMDA2 NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxfdHlwZXMuaWRsDQo+PiArKysgYi90 b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzLmlkbA0KPj4gQEAgLTEzMCw2ICsxMzAsMTggQEAg bGlieGxfZGlza19iYWNrZW5kID0gRW51bWVyYXRpb24oImRpc2tfYmFja2VuZCIsDQo+PiBbDQo+ PiAgICAgICAoMSwgIlBIWSIpLA0KPj4gICAgICAgKDIsICJUQVAiKSwNCj4+ICAgICAgICgzLCAi UURJU0siKSwNCj4+ICsgICAgKDQsICJTVEFOREFMT05FIiksICMgT25seSByZWx5aW5nIG9uIHRo ZSBYZW5zdG9yZSBkYXRhDQo+PiArICAgIF0pDQo+PiArDQo+PiArbGlieGxfZGlza19zcGVjaWZp Y2F0aW9uID0gRW51bWVyYXRpb24oImRpc2tfc3BlY2lmaWNhdGlvbiIsIFsNCj4+ICsgICAgKDAs ICJVTktOT1dOIiksDQo+PiArICAgICgxLCAiWEVOIiksDQo+PiArICAgICgyLCAiVklSVElPIiks DQo+PiArICAgIF0pDQo+PiArDQo+PiArbGlieGxfZGlza190cmFuc3BvcnQgPSBFbnVtZXJhdGlv bigiZGlza190cmFuc3BvcnQiLCBbDQo+PiArICAgICgwLCAiVU5LTk9XTiIpLA0KPj4gKyAgICAo MSwgIk1NSU8iKSwNCj4+ICAgICAgIF0pDQo+Pg0KPj4gICBsaWJ4bF9uaWNfdHlwZSA9IEVudW1l cmF0aW9uKCJuaWNfdHlwZSIsIFsNCj4+IEBAIC03MDYsNiArNzE4LDEyIEBAIGxpYnhsX2Rldmlj ZV9kaXNrID0gU3RydWN0KCJkZXZpY2VfZGlzayIsIFsNCj4+ICAgICAgICgiaXNfY2Ryb20iLCBp bnRlZ2VyKSwNCj4+ICAgICAgICgiZGlyZWN0X2lvX3NhZmUiLCBib29sKSwNCj4+ICAgICAgICgi ZGlzY2FyZF9lbmFibGUiLCBsaWJ4bF9kZWZib29sKSwNCj4+ICsgICAgKCJzcGVjaWZpY2F0aW9u IiwgbGlieGxfZGlza19zcGVjaWZpY2F0aW9uKSwNCj4+ICsgICAgKCJ0cmFuc3BvcnQiLCBsaWJ4 bF9kaXNrX3RyYW5zcG9ydCksDQo+PiArICAgICMgTm90ZSB0aGF0IHZpcnRpby1tbWlvIHBhcmFt ZXRlcnMgKGlycSBhbmQgYmFzZSkgYXJlIGZvciBpbnRlcm5hbCB1c2UNCj4+ICsgICAgIyBieSBs aWJ4bCBhbmQgY2FuJ3QgYmUgbW9kaWZpZWQuDQo+PiArICAgICgiaXJxIiwgdWludDMyKSwNCj4+ ICsgICAgKCJiYXNlIiwgdWludDY0KSwNCj4+ICAgICAgICMgTm90ZSB0aGF0IHRoZSBDT0xPIGNv bmZpZ3VyYXRpb24gc2V0dGluZ3Mgc2hvdWxkIGJlIGNvbnNpZGVyZWQgdW5zdGFibGUuDQo+PiAg ICAgICAjIFRoZXkgbWF5IGNoYW5nZSBpbmNvbXBhdGlibHkgaW4gZnV0dXJlIHZlcnNpb25zIG9m IFhlbi4NCj4+ICAgICAgICgiY29sb19lbmFibGUiLCBsaWJ4bF9kZWZib29sKSwNCj4+IGRpZmYg LS1naXQgYS90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzX2ludGVybmFsLmlkbA0KPj4gYi90 b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVzX2ludGVybmFsLmlkbA0KPj4gaW5kZXggMzU5M2Uy MWRiYi4uOGY3MTk4MGFlYyAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvbGlnaHQvbGlieGxf dHlwZXNfaW50ZXJuYWwuaWRsDQo+PiArKysgYi90b29scy9saWJzL2xpZ2h0L2xpYnhsX3R5cGVz X2ludGVybmFsLmlkbA0KPj4gQEAgLTMyLDYgKzMyLDcgQEAgbGlieGxfX2RldmljZV9raW5kID0g RW51bWVyYXRpb24oImRldmljZV9raW5kIiwgWw0KPj4gICAgICAgKDE0LCAiUFZDQUxMUyIpLA0K Pj4gICAgICAgKDE1LCAiVlNORCIpLA0KPj4gICAgICAgKDE2LCAiVklOUFVUIiksDQo+PiArICAg ICgxNywgIlZJUlRJT19ESVNLIiksDQo+PiAgICAgICBdKQ0KPj4NCj4+ICAgbGlieGxfX2NvbnNv bGVfYmFja2VuZCA9IEVudW1lcmF0aW9uKCJjb25zb2xlX2JhY2tlbmQiLCBbDQo+PiBkaWZmIC0t Z2l0IGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF91dGlscy5jIGIvdG9vbHMvbGlicy9saWdodC9s aWJ4bF91dGlscy5jDQo+PiBpbmRleCBlNWU2YjJkYTk2Li5lNDAzYmQ5YmNmIDEwMDY0NA0KPj4g LS0tIGEvdG9vbHMvbGlicy9saWdodC9saWJ4bF91dGlscy5jDQo+PiArKysgYi90b29scy9saWJz L2xpZ2h0L2xpYnhsX3V0aWxzLmMNCj4+IEBAIC0yOTcsNiArMjk3LDggQEAgaW50IGxpYnhsX3N0 cmluZ190b19iYWNrZW5kKGxpYnhsX2N0eCAqY3R4LCBjaGFyICpzLA0KPj4gbGlieGxfZGlza19i YWNrZW5kICpiYWNrZW5kDQo+PiAgICAgICAgICAgKmJhY2tlbmQgPSBMSUJYTF9ESVNLX0JBQ0tF TkRfVEFQOw0KPj4gICAgICAgfSBlbHNlIGlmICghc3RyY21wKHMsICJxZGlzayIpKSB7DQo+PiAg ICAgICAgICAgKmJhY2tlbmQgPSBMSUJYTF9ESVNLX0JBQ0tFTkRfUURJU0s7DQo+PiArICAgIH0g ZWxzZSBpZiAoIXN0cmNtcChzLCAic3RhbmRhbG9uZSIpKSB7DQo+PiArICAgICAgICAqYmFja2Vu ZCA9IExJQlhMX0RJU0tfQkFDS0VORF9TVEFOREFMT05FOw0KPj4gICAgICAgfSBlbHNlIGlmICgh c3RyY21wKHMsICJ0YXAiKSkgew0KPj4gICAgICAgICAgIHAgPSBzdHJjaHIocywgJzonKTsNCj4+ ICAgICAgICAgICBpZiAoIXApIHsNCj4+IGRpZmYgLS1naXQgYS90b29scy9saWJzL3V0aWwvbGli eGx1X2Rpc2tfbC5jIGIvdG9vbHMvbGlicy91dGlsL2xpYnhsdV9kaXNrX2wuYw0KPj4gaW5kZXgg MzJkNGI3NGI1OC4uMGI1OTcyM2I3MSAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL2xpYnMvdXRpbC9s aWJ4bHVfZGlza19sLmMNCj4+ICsrKyBiL3Rvb2xzL2xpYnMvdXRpbC9saWJ4bHVfZGlza19sLmMN Cj4+IEBAIC01NDksOCArNTQ5LDggQEAgc3RhdGljIHZvaWQgeXlub3JldHVybiB5eV9mYXRhbF9l cnJvciAoIGNvbnN0IGNoYXIqDQo+PiBtc2cgLCB5eXNjYW5fdCB5eXNjYW5uZXIgKTsNCj4+ICAg CXl5Zy0+eXlfaG9sZF9jaGFyID0gKnl5X2NwOyBcDQo+PiAgIAkqeXlfY3AgPSAnXDAnOyBcDQo+ PiAgIAl5eWctPnl5X2NfYnVmX3AgPSB5eV9jcDsNCj4+IC0jZGVmaW5lIFlZX05VTV9SVUxFUyAz Ng0KPj4gLSNkZWZpbmUgWVlfRU5EX09GX0JVRkZFUiAzNw0KPj4gKyNkZWZpbmUgWVlfTlVNX1JV TEVTIDM3DQo+PiArI2RlZmluZSBZWV9FTkRfT0ZfQlVGRkVSIDM4DQo+PiAgIC8qIFRoaXMgc3Ry dWN0IGlzIG5vdCB1c2VkIGluIHRoaXMgc2Nhbm5lciwNCj4+ICAgICAgYnV0IGl0cyBwcmVzZW5j ZSBpcyBuZWNlc3NhcnkuICovDQo+PiAgIHN0cnVjdCB5eV90cmFuc19pbmZvDQo+PiBAQCAtNTU4 LDc0ICs1NTgsNzcgQEAgc3RydWN0IHl5X3RyYW5zX2luZm8NCj4+ICAgCWZsZXhfaW50MzJfdCB5 eV92ZXJpZnk7DQo+PiAgIAlmbGV4X2ludDMyX3QgeXlfbnh0Ow0KPj4gICAJfTsNCj4+IC1zdGF0 aWMgY29uc3QgZmxleF9pbnQxNl90IHl5X2FjY2xpc3RbNTc1XSA9DQo+PiArc3RhdGljIGNvbnN0 IGZsZXhfaW50MTZfdCB5eV9hY2NsaXN0WzU5NF0gPQ0KPj4gICAgICAgeyAgIDAsDQo+PiAtICAg ICAgIDM1LCAgIDM1LCAgIDM3LCAgIDMzLCAgIDM0LCAgIDM2LCA4MTkzLCAgIDMzLCAgIDM0LCAg IDM2LA0KPj4gLSAgICAxNjM4NSwgODE5MywgICAzMywgICAzNiwxNjM4NSwgICAzMywgICAzNCwg ICAzNiwgICAzNCwgICAzNiwNCj4+IC0gICAgICAgMzMsICAgMzQsICAgMzYsICAgMzMsICAgMzQs ICAgMzYsICAgMzMsICAgMzQsICAgMzYsICAgMzMsDQo+PiAtICAgICAgIDM0LCAgIDM2LCAgIDMz LCAgIDM0LCAgIDM2LCAgIDMzLCAgIDM0LCAgIDM2LCAgIDMzLCAgIDM0LA0KPj4gLSAgICAgICAz NiwgICAzMywgICAzNCwgICAzNiwgICAzMywgICAzNCwgICAzNiwgICAzMywgICAzNCwgICAzNiwN Cj4+IC0gICAgICAgMzMsICAgMzQsICAgMzYsICAgMzMsICAgMzQsICAgMzYsICAgMzMsICAgMzQs ICAgMzYsICAgMzMsDQo+PiAtICAgICAgIDM0LCAgIDM2LCAgIDMzLCAgIDM0LCAgIDM2LCAgIDMz LCAgIDM0LCAgIDM2LCAgIDM1LCAgIDM2LA0KPj4gLSAgICAgICAzNiwgICAzMywgICAzMywgODE5 MywgICAzMywgODE5MywgICAzMywxNjM4NSwgODE5MywgICAzMywNCj4+IC0gICAgIDgxOTMsICAg MzMsICAgMzMsIDgyMjQsICAgMzMsMTY0MTYsICAgMzMsICAgMzMsICAgMzMsICAgMzMsDQo+PiAt ICAgICAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMz LCAgIDMzLA0KPj4gLQ0KPj4gLSAgICAgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAz MywgICAzMywgICAzMywgICAzMywgICAzNSwNCj4+IC0gICAgIDgxOTMsICAgMzMsIDgxOTMsICAg MzMsIDgxOTMsIDgyMjQsICAgMzMsIDgyMjQsICAgMzMsIDgyMjQsDQo+PiAtICAgICAgIDIzLCAg IDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLA0KPj4g LSAgICAgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAz MywgICAzMywNCj4+IC0gICAgICAgMzMsICAgMzMsICAgMzMsICAgMzMsICAgMzMsIDgyMjQsICAg MzMsIDgyMjQsICAgMzMsIDgyMjQsDQo+PiAtICAgICAgIDIzLCAgIDMzLCAgIDMzLCAgIDI4LCA4 MjI0LCAgIDMzLDE2NDE2LCAgIDMzLCAgIDMzLCAgIDE1LA0KPj4gLSAgICAgICAzMywgICAzMywg ICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywgODIxNywNCj4+IC0gICAg IDgyMjQsICAgMzMsMTY0MDksMTY0MTYsICAgMzMsICAgMzMsICAgMzEsIDgyMjQsICAgMzMsMTY0 MTYsDQo+PiAtICAgICAgIDMzLCA4MjE2LCA4MjI0LCAgIDMzLDE2NDA4LDE2NDE2LCAgIDMzLCAg IDMzLCA4MjE5LCA4MjI0LA0KPj4gLSAgICAgICAzMywxNjQxMSwxNjQxNiwgICAzMywgICAzMywg ICAzMywgICAzMywgICAzMywgICAyOCwgODIyNCwNCj4+IC0NCj4+IC0gICAgICAgMzMsICAgMjgs IDgyMjQsICAgMzMsICAgMjgsICAgMzMsICAgMjgsIDgyMjQsICAgMzMsICAgIDMsDQo+PiAtICAg ICAgIDMzLCAgIDE1LCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDMwLCA4MjI0LCAg IDMzLA0KPj4gLSAgICAxNjQxNiwgICAzMywgICAzMywgICAzMywgODIxNywgODIyNCwgICAzMywg ODIxNywgODIyNCwgICAzMywNCj4+IC0gICAgIDgyMTcsICAgMzMsIDgyMTcsIDgyMjQsICAgMzMs ICAgMzMsICAgMzEsIDgyMjQsICAgMzMsICAgMzEsDQo+PiAtICAgICA4MjI0LCAgIDMzLCAgIDMx LCAgIDMzLCAgIDMxLCA4MjI0LCA4MjE2LCA4MjI0LCAgIDMzLCA4MjE2LA0KPj4gLSAgICAgODIy NCwgICAzMywgODIxNiwgICAzMywgODIxNiwgODIyNCwgICAzMywgODIxOSwgODIyNCwgICAzMywN Cj4+IC0gICAgIDgyMTksIDgyMjQsICAgMzMsIDgyMTksICAgMzMsIDgyMTksIDgyMjQsICAgMzMs ICAgMzMsICAgMTAsDQo+PiAtICAgICAgIDMzLCAgIDMzLCAgIDI4LCA4MjI0LCAgIDMzLCAgIDI4 LCA4MjI0LCAgIDMzLCAgIDI4LCA4MjI0LA0KPj4gLSAgICAgICAyOCwgICAzMywgICAyOCwgICAz MywgICAgMywgICAzMywgICAzMywgICAzMywgICAzMywgICAzMywNCj4+IC0gICAgICAgMzMsICAg MzMsICAgMzAsIDgyMjQsICAgMzMsICAgMzAsIDgyMjQsICAgMzMsICAgMzAsICAgMzMsDQo+PiAt DQo+PiAtICAgICAgIDMwLCA4MjI0LCAgIDMzLCAgIDMzLCAgIDI5LCA4MjI0LCAgIDMzLDE2NDE2 LCA4MjE3LCA4MjI0LA0KPj4gLSAgICAgICAzMywgODIxNywgODIyNCwgICAzMywgODIxNywgODIy NCwgODIxNywgICAzMywgODIxNywgICAzMywNCj4+IC0gICAgICAgMzMsICAgMzEsIDgyMjQsICAg MzMsICAgMzEsIDgyMjQsICAgMzMsICAgMzEsIDgyMjQsICAgMzEsDQo+PiAtICAgICAgIDMzLCAg IDMxLCA4MjE2LCA4MjI0LCAgIDMzLCA4MjE2LCA4MjI0LCAgIDMzLCA4MjE2LCA4MjI0LA0KPj4g LSAgICAgODIxNiwgICAzMywgODIxNiwgICAzMywgODIxOSwgODIyNCwgICAzMywgODIxOSwgODIy NCwgICAzMywNCj4+IC0gICAgIDgyMTksIDgyMjQsIDgyMTksICAgMzMsIDgyMTksICAgMzMsICAg MzMsICAgMTAsICAgMjMsICAgMTAsDQo+PiAtICAgICAgICA3LCAgIDMzLCAgIDMzLCAgIDMzLCAg IDMzLCAgIDMzLCAgIDMzLCAgIDMzLCAgIDEzLCAgIDMzLA0KPj4gLSAgICAgICAzMCwgODIyNCwg ICAzMywgICAzMCwgODIyNCwgICAzMywgICAzMCwgODIyNCwgICAzMCwgICAzMywNCj4+IC0gICAg ICAgMzAsICAgIDIsICAgMzMsICAgMjksIDgyMjQsICAgMzMsICAgMjksIDgyMjQsICAgMzMsICAg MjksDQo+PiAtICAgICAgIDMzLCAgIDI5LCA4MjI0LCAgIDE2LCAgIDMzLCAgIDMzLCAgIDExLCAg IDMzLCAgIDIyLCAgIDEwLA0KPj4gLQ0KPj4gLSAgICAgICAxMCwgICAyMywgICAgNywgICAyMywg ICAgNywgICAzMywgICAgOCwgICAzMywgICAzMywgICAzMywNCj4+IC0gICAgICAgMzMsICAgIDYs ICAgMzMsICAgMTMsICAgMzMsICAgIDIsICAgMjMsICAgIDIsICAgMzMsICAgMjksDQo+PiAtICAg ICA4MjI0LCAgIDMzLCAgIDI5LCA4MjI0LCAgIDMzLCAgIDI5LCA4MjI0LCAgIDI5LCAgIDMzLCAg IDI5LA0KPj4gLSAgICAgICAxNiwgICAzMywgICAzMywgICAxMSwgICAyMywgICAxMSwgICAyNiwg ODIyNCwgICAzMywxNjQxNiwNCj4+IC0gICAgICAgMjIsICAgMjMsICAgMjIsICAgIDcsICAgIDcs ICAgMjMsICAgMzMsICAgIDgsICAgMjMsICAgIDgsDQo+PiAtICAgICAgIDMzLCAgIDMzLCAgIDMz LCAgIDMzLCAgICA2LCAgIDIzLCAgICA2LCAgICA2LCAgIDIzLCAgICA2LA0KPj4gLSAgICAgICAy MywgICAzMywgICAgMiwgICAgMiwgICAyMywgICAzMywgICAzMywgICAxMSwgICAxMSwgICAyMywN Cj4+IC0gICAgICAgMjYsIDgyMjQsICAgMzMsICAgMjYsIDgyMjQsICAgMzMsICAgMjYsICAgMzMs ICAgMjYsIDgyMjQsDQo+PiAtICAgICAgIDIyLCAgIDIzLCAgIDMzLCAgICA4LCAgICA4LCAgIDIz LCAgIDMzLCAgIDMzLCAgIDE3LCAgIDE4LA0KPj4gLSAgICAgICAgNiwgICAgNiwgICAyMywgICAg NiwgICAgNiwgICAzMywgICAzMywgICAxNCwgICAzMywgICAyNiwNCj4+IC0NCj4+IC0gICAgIDgy MjQsICAgMzMsICAgMjYsIDgyMjQsICAgMzMsICAgMjYsIDgyMjQsICAgMjYsICAgMzMsICAgMjYs DQo+PiAtICAgICAgIDMzLCAgIDMzLCAgIDMzLCAgIDE3LCAgIDIzLCAgIDE3LCAgIDE4LCAgIDIz LCAgIDE4LCAgICA2LA0KPj4gLSAgICAgICAgNiwgICAzMywgICAzMywgICAxNCwgICAzMywgICAy MCwgICAgOSwgICAxOSwgICAxNywgICAxNywNCj4+IC0gICAgICAgMjMsICAgMTgsICAgMTgsICAg MjMsICAgIDYsICAgIDUsICAgIDYsICAgMzMsICAgMjEsICAgMjAsDQo+PiAtICAgICAgIDIzLCAg IDIwLCAgICA5LCAgIDIzLCAgICA5LCAgIDE5LCAgIDIzLCAgIDE5LCAgICA0LCAgICA2LA0KPj4g LSAgICAgICAgNSwgICAgNiwgICAzMywgICAyMSwgICAyMywgICAyMSwgICAyMCwgICAyMCwgICAy MywgICAgOSwNCj4+IC0gICAgICAgIDksICAgMjMsICAgMTksICAgMTksICAgMjMsICAgIDQsICAg IDYsICAgMTIsICAgMzMsICAgMjEsDQo+PiAtICAgICAgIDIxLCAgIDIzLCAgIDEyLCAgIDMzDQo+ PiArICAgICAgIDM2LCAgIDM2LCAgIDM4LCAgIDM0LCAgIDM1LCAgIDM3LCA4MTkzLCAgIDM0LCAg IDM1LCAgIDM3LA0KPj4gKyAgICAxNjM4NSwgODE5MywgICAzNCwgICAzNywxNjM4NSwgICAzNCwg ICAzNSwgICAzNywgICAzNSwgICAzNywNCj4+ICsgICAgICAgMzQsICAgMzUsICAgMzcsICAgMzQs ICAgMzUsICAgMzcsICAgMzQsICAgMzUsICAgMzcsICAgMzQsDQo+PiArICAgICAgIDM1LCAgIDM3 LCAgIDM0LCAgIDM1LCAgIDM3LCAgIDM0LCAgIDM1LCAgIDM3LCAgIDM0LCAgIDM1LA0KPj4gKyAg ICAgICAzNywgICAzNCwgICAzNSwgICAzNywgICAzNCwgICAzNSwgICAzNywgICAzNCwgICAzNSwg ICAzNywNCj4+ICsgICAgICAgMzQsICAgMzUsICAgMzcsICAgMzQsICAgMzUsICAgMzcsICAgMzQs ICAgMzUsICAgMzcsICAgMzQsDQo+PiArICAgICAgIDM1LCAgIDM3LCAgIDM0LCAgIDM1LCAgIDM3 LCAgIDM0LCAgIDM1LCAgIDM3LCAgIDM2LCAgIDM3LA0KPj4gKyAgICAgICAzNywgICAzNCwgICAz NCwgODE5MywgICAzNCwgODE5MywgICAzNCwxNjM4NSwgODE5MywgICAzNCwNCj4+ICsgICAgIDgx OTMsICAgMzQsICAgMzQsIDgyMjUsICAgMzQsMTY0MTcsICAgMzQsICAgMzQsICAgMzQsICAgMzQs DQo+PiArICAgICAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0 LCAgIDM0LCAgIDM0LA0KPj4gKw0KPj4gKyAgICAgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAz NCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwNCj4+ICsgICAgICAgMzYsIDgxOTMsICAg MzQsIDgxOTMsICAgMzQsIDgxOTMsIDgyMjUsICAgMzQsIDgyMjUsICAgMzQsDQo+PiArICAgICA4 MjI1LCAgIDI0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0 LA0KPj4gKyAgICAgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAz NCwgICAzNCwgICAzNCwNCj4+ICsgICAgICAgMzQsICAgMzQsICAgMzQsICAgMzQsICAgMzQsICAg MzQsICAgMzQsIDgyMjUsICAgMzQsIDgyMjUsDQo+PiArICAgICAgIDM0LCA4MjI1LCAgIDI0LCAg IDM0LCAgIDM0LCAgIDI5LCA4MjI1LCAgIDM0LDE2NDE3LCAgIDM0LA0KPj4gKyAgICAgICAzNCwg ICAxNiwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwgICAzNCwNCj4+ ICsgICAgICAgMzQsIDgyMTgsIDgyMjUsICAgMzQsMTY0MTAsMTY0MTcsICAgMzQsICAgMzQsICAg MzIsIDgyMjUsDQo+PiArICAgICAgIDM0LDE2NDE3LCAgIDM0LCA4MjE3LCA4MjI1LCAgIDM0LDE2 NDA5LDE2NDE3LCAgIDM0LCAgIDM0LA0KPj4gKyAgICAgICAzNCwgODIyMCwgODIyNSwgICAzNCwx NjQxMiwxNjQxNywgICAzNCwgICAzNCwgICAzNCwgICAzNCwNCj4+ICsNCj4+ICsgICAgICAgMzQs ICAgMjksIDgyMjUsICAgMzQsICAgMjksIDgyMjUsICAgMzQsICAgMjksICAgMzQsICAgMjksDQo+ PiArICAgICA4MjI1LCAgIDM0LCAgICAzLCAgIDM0LCAgIDE2LCAgIDM0LCAgIDM0LCAgIDM0LCAg IDM0LCAgIDM0LA0KPj4gKyAgICAgICAzMSwgODIyNSwgICAzNCwxNjQxNywgICAzNCwgICAzNCwg ICAzNCwgODIxOCwgODIyNSwgICAzNCwNCj4+ICsgICAgIDgyMTgsIDgyMjUsICAgMzQsIDgyMTgs ICAgMzQsIDgyMTgsIDgyMjUsICAgMzQsICAgMzQsICAgMzIsDQo+PiArICAgICA4MjI1LCAgIDM0 LCAgIDMyLCA4MjI1LCAgIDM0LCAgIDMyLCAgIDM0LCAgIDMyLCA4MjI1LCA4MjE3LA0KPj4gKyAg ICAgODIyNSwgICAzNCwgODIxNywgODIyNSwgICAzNCwgODIxNywgICAzNCwgODIxNywgODIyNSwg ICAzNCwNCj4+ICsgICAgICAgMzQsIDgyMjAsIDgyMjUsICAgMzQsIDgyMjAsIDgyMjUsICAgMzQs IDgyMjAsICAgMzQsIDgyMjAsDQo+PiArICAgICA4MjI1LCAgIDM0LCAgIDM0LCAgIDExLCAgIDM0 LCAgIDM0LCAgIDI5LCA4MjI1LCAgIDM0LCAgIDI5LA0KPj4gKyAgICAgODIyNSwgICAzNCwgICAy OSwgODIyNSwgICAyOSwgICAzNCwgICAyOSwgICAzNCwgICAgMywgICAzNCwNCj4+ICsgICAgICAg MzQsICAgMzQsICAgMzQsICAgMzQsICAgMzQsICAgMzQsICAgMzEsIDgyMjUsICAgMzQsICAgMzEs DQo+PiArDQo+PiArICAgICA4MjI1LCAgIDM0LCAgIDMxLCAgIDM0LCAgIDMxLCA4MjI1LCAgIDM0 LCAgIDM0LCAgIDMwLCA4MjI1LA0KPj4gKyAgICAgICAzNCwxNjQxNywgODIxOCwgODIyNSwgICAz NCwgODIxOCwgODIyNSwgICAzNCwgODIxOCwgODIyNSwNCj4+ICsgICAgIDgyMTgsICAgMzQsIDgy MTgsICAgMzQsICAgMzQsICAgMzIsIDgyMjUsICAgMzQsICAgMzIsIDgyMjUsDQo+PiArICAgICAg IDM0LCAgIDMyLCA4MjI1LCAgIDMyLCAgIDM0LCAgIDMyLCA4MjE3LCA4MjI1LCAgIDM0LCA4MjE3 LA0KPj4gKyAgICAgODIyNSwgICAzNCwgODIxNywgODIyNSwgODIxNywgICAzNCwgODIxNywgICAz NCwgICAzNCwgODIyMCwNCj4+ICsgICAgIDgyMjUsICAgMzQsIDgyMjAsIDgyMjUsICAgMzQsIDgy MjAsIDgyMjUsIDgyMjAsICAgMzQsIDgyMjAsDQo+PiArICAgICAgIDM0LCAgIDM0LCAgIDExLCAg IDI0LCAgIDExLCAgICA3LCAgIDM0LCAgIDM0LCAgIDM0LCAgIDM0LA0KPj4gKyAgICAgICAzNCwg ICAzNCwgICAzNCwgICAxNCwgICAzNCwgICAzMSwgODIyNSwgICAzNCwgICAzMSwgODIyNSwNCj4+ ICsgICAgICAgMzQsICAgMzEsIDgyMjUsICAgMzEsICAgMzQsICAgMzEsICAgIDIsICAgMzQsICAg MzAsIDgyMjUsDQo+PiArICAgICAgIDM0LCAgIDMwLCA4MjI1LCAgIDM0LCAgIDMwLCAgIDM0LCAg IDMwLCA4MjI1LCAgIDE3LCAgIDM0LA0KPj4gKw0KPj4gKyAgICAgICAzNCwgICAxMiwgICAzNCwg ICAzNCwgICAyMywgICAxMSwgICAxMSwgICAyNCwgICAgNywgICAyNCwNCj4+ICsgICAgICAgIDcs ICAgMzQsICAgIDgsICAgMzQsICAgMzQsICAgMzQsICAgMzQsICAgIDYsICAgMzQsICAgMTQsDQo+ PiArICAgICAgIDM0LCAgICAyLCAgIDI0LCAgICAyLCAgIDM0LCAgIDMwLCA4MjI1LCAgIDM0LCAg IDMwLCA4MjI1LA0KPj4gKyAgICAgICAzNCwgICAzMCwgODIyNSwgICAzMCwgICAzNCwgICAzMCwg ICAxNywgICAzNCwgICAzNCwgICAxMiwNCj4+ICsgICAgICAgMjQsICAgMTIsICAgMzQsICAgMjcs IDgyMjUsICAgMzQsMTY0MTcsICAgMjMsICAgMjQsICAgMjMsDQo+PiArICAgICAgICA3LCAgICA3 LCAgIDI0LCAgIDM0LCAgICA4LCAgIDI0LCAgICA4LCAgIDM0LCAgIDM0LCAgIDM0LA0KPj4gKyAg ICAgICAzNCwgICAgNiwgICAyNCwgICAgNiwgICAgNiwgICAyNCwgICAgNiwgICAyNCwgICAzNCwg ICAgMiwNCj4+ICsgICAgICAgIDIsICAgMjQsICAgMzQsICAgMzQsICAgMTIsICAgMTIsICAgMjQs ICAgMzQsICAgMjcsIDgyMjUsDQo+PiArICAgICAgIDM0LCAgIDI3LCA4MjI1LCAgIDM0LCAgIDI3 LCAgIDM0LCAgIDI3LCA4MjI1LCAgIDIzLCAgIDI0LA0KPj4gKyAgICAgICAzNCwgICAgOCwgICAg OCwgICAyNCwgICAzNCwgICAzNCwgICAxOCwgICAxOSwgICAgNiwgICAgNiwNCj4+ICsNCj4+ICsg ICAgICAgMjQsICAgIDYsICAgIDYsICAgMzQsICAgMzQsICAgMTUsICAgMzQsICAgMzQsICAgMjcs IDgyMjUsDQo+PiArICAgICAgIDM0LCAgIDI3LCA4MjI1LCAgIDM0LCAgIDI3LCA4MjI1LCAgIDI3 LCAgIDM0LCAgIDI3LCAgIDM0LA0KPj4gKyAgICAgICAzNCwgICAzNCwgICAxOCwgICAyNCwgICAx OCwgICAxOSwgICAyNCwgICAxOSwgICAgNiwgICAgNiwNCj4+ICsgICAgICAgMzQsICAgMzQsICAg MTUsICAgMzQsICAgMzQsICAgMjEsICAgIDksICAgMjAsICAgMTgsICAgMTgsDQo+PiArICAgICAg IDI0LCAgIDE5LCAgIDE5LCAgIDI0LCAgICA2LCAgICA1LCAgICA2LCAgIDM0LCAgIDIyLCAgIDM0 LA0KPj4gKyAgICAgICAyMSwgICAyNCwgICAyMSwgICAgOSwgICAyNCwgICAgOSwgICAyMCwgICAy NCwgICAyMCwgICAgNCwNCj4+ICsgICAgICAgIDYsICAgIDUsICAgIDYsICAgMzQsICAgMjIsICAg MjQsICAgMjIsICAgMzQsICAgMjEsICAgMjEsDQo+PiArICAgICAgIDI0LCAgICA5LCAgICA5LCAg IDI0LCAgIDIwLCAgIDIwLCAgIDI0LCAgICA0LCAgICA2LCAgIDEzLA0KPj4gKyAgICAgICAzNCwg ICAyMiwgICAyMiwgICAyNCwgICAxMCwgICAxMywgICAzNCwgICAxMCwgICAyNCwgICAxMCwNCj4+ ICsgICAgICAgMTAsICAgMTAsICAgMjQNCj4+ICsNCj4+ICAgICAgIH0gOw0KPj4NCj4+IC1zdGF0 aWMgY29uc3QgZmxleF9pbnQxNl90IHl5X2FjY2VwdFszNTZdID0NCj4+ICtzdGF0aWMgY29uc3Qg ZmxleF9pbnQxNl90IHl5X2FjY2VwdFszNzNdID0NCj4+ICAgICAgIHsgICAwLA0KPj4gICAgICAg ICAgIDEsICAgIDEsICAgIDEsICAgIDIsICAgIDMsICAgIDQsICAgIDcsICAgMTIsICAgMTYsICAg MTksDQo+PiAgICAgICAgICAyMSwgICAyNCwgICAyNywgICAzMCwgICAzMywgICAzNiwgICAzOSwg ICA0MiwgICA0NSwgICA0OCwNCj4+IEBAIC02MzMsMzkgKzYzNiw0MSBAQCBzdGF0aWMgY29uc3Qg ZmxleF9pbnQxNl90IHl5X2FjY2VwdFszNTZdID0NCj4+ICAgICAgICAgIDc0LCAgIDc2LCAgIDc5 LCAgIDgxLCAgIDgyLCAgIDgzLCAgIDg0LCAgIDg3LCAgIDg3LCAgIDg4LA0KPj4gICAgICAgICAg ODksICAgOTAsICAgOTEsICAgOTIsICAgOTMsICAgOTQsICAgOTUsICAgOTYsICAgOTcsICAgOTgs DQo+PiAgICAgICAgICA5OSwgIDEwMCwgIDEwMSwgIDEwMiwgIDEwMywgIDEwNCwgIDEwNSwgIDEw NiwgIDEwNywgIDEwOCwNCj4+IC0gICAgICAxMDksICAxMTAsICAxMTEsICAxMTMsICAxMTUsICAx MTYsICAxMTgsICAxMjAsICAxMjEsICAxMjIsDQo+PiArICAgICAgMTA5LCAgMTEwLCAgMTExLCAg MTEyLCAgMTE0LCAgMTE2LCAgMTE3LCAgMTE5LCAgMTIxLCAgMTIyLA0KPj4gICAgICAgICAxMjMs ICAxMjQsICAxMjUsICAxMjYsICAxMjcsICAxMjgsICAxMjksICAxMzAsICAxMzEsICAxMzIsDQo+ PiAgICAgICAgIDEzMywgIDEzNCwgIDEzNSwgIDEzNiwgIDEzNywgIDEzOCwgIDEzOSwgIDE0MCwg IDE0MSwgIDE0MiwNCj4+IC0gICAgICAxNDMsICAxNDQsICAxNDUsICAxNDYsICAxNDgsICAxNTAs ICAxNTEsICAxNTIsICAxNTMsICAxNTQsDQo+PiAtDQo+PiAtICAgICAgMTU4LCAgMTU5LCAgMTYw LCAgMTYyLCAgMTYzLCAgMTY0LCAgMTY1LCAgMTY2LCAgMTY3LCAgMTY4LA0KPj4gLSAgICAgIDE2 OSwgIDE3MCwgIDE3NSwgIDE3NiwgIDE3NywgIDE4MSwgIDE4MiwgIDE4NywgIDE4OCwgIDE4OSwN Cj4+IC0gICAgICAxOTQsICAxOTUsICAxOTYsICAxOTcsICAxOTgsICAxOTksICAyMDIsICAyMDUs ICAyMDcsICAyMDksDQo+PiAtICAgICAgMjEwLCAgMjEyLCAgMjE0LCAgMjE1LCAgMjE2LCAgMjE3 LCAgMjE4LCAgMjIyLCAgMjIzLCAgMjI0LA0KPj4gLSAgICAgIDIyNSwgIDIyOCwgIDIzMSwgIDIz MywgIDIzNSwgIDIzNiwgIDIzNywgIDI0MCwgIDI0MywgIDI0NSwNCj4+IC0gICAgICAyNDcsICAy NTAsICAyNTMsICAyNTUsICAyNTcsICAyNTgsICAyNjEsICAyNjQsICAyNjYsICAyNjgsDQo+PiAt ICAgICAgMjY5LCAgMjcwLCAgMjcxLCAgMjcyLCAgMjczLCAgMjc2LCAgMjc5LCAgMjgxLCAgMjgz LCAgMjg0LA0KPj4gLSAgICAgIDI4NSwgIDI4NywgIDI4OCwgIDI4OSwgIDI5MCwgIDI5MSwgIDI5 MiwgIDI5MywgIDI5NiwgIDI5OSwNCj4+IC0gICAgICAzMDEsICAzMDMsICAzMDQsICAzMDUsICAz MDksICAzMTIsICAzMTUsICAzMTcsICAzMTksICAzMjAsDQo+PiAtICAgICAgMzIxLCAgMzIyLCAg MzI1LCAgMzI4LCAgMzMwLCAgMzMyLCAgMzMzLCAgMzM2LCAgMzM5LCAgMzQxLA0KPj4gLQ0KPj4g LSAgICAgIDM0MywgIDM0NCwgIDM0NSwgIDM0OCwgIDM1MSwgIDM1MywgIDM1NSwgIDM1NiwgIDM1 NywgIDM1OCwNCj4+IC0gICAgICAzNjAsICAzNjEsICAzNjIsICAzNjMsICAzNjQsICAzNjUsICAz NjYsICAzNjcsICAzNjgsICAzNjksDQo+PiAtICAgICAgMzcxLCAgMzc0LCAgMzc3LCAgMzc5LCAg MzgxLCAgMzgyLCAgMzgzLCAgMzg0LCAgMzg3LCAgMzkwLA0KPj4gLSAgICAgIDM5MiwgIDM5NCwg IDM5NiwgIDM5NywgIDM5OCwgIDM5OSwgIDQwMCwgIDQwMSwgIDQwMywgIDQwNSwNCj4+IC0gICAg ICA0MDYsICA0MDcsICA0MDgsICA0MDksICA0MTAsICA0MTEsICA0MTIsICA0MTMsICA0MTQsICA0 MTYsDQo+PiAtICAgICAgNDE4LCAgNDE5LCAgNDIwLCAgNDIzLCAgNDI2LCAgNDI4LCAgNDMwLCAg NDMxLCAgNDMzLCAgNDM0LA0KPj4gLSAgICAgIDQzNiwgIDQzNywgIDQ0MSwgIDQ0MywgIDQ0NCwg IDQ0NSwgIDQ0NywgIDQ0OCwgIDQ1MCwgIDQ1MSwNCj4+IC0gICAgICA0NTIsICA0NTMsICA0NTQs ICA0NTUsICA0NTcsICA0NTgsICA0NjAsICA0NjIsICA0NjMsICA0NjQsDQo+PiAtICAgICAgNDY2 LCAgNDY3LCAgNDY4LCAgNDY5LCAgNDcxLCAgNDc0LCAgNDc3LCAgNDc5LCAgNDgxLCAgNDgzLA0K Pj4gLSAgICAgIDQ4NCwgIDQ4NSwgIDQ4NywgIDQ4OCwgIDQ4OSwgIDQ5MCwgIDQ5MSwgIDQ5Miwg IDQ5NCwgIDQ5NSwNCj4+IC0NCj4+IC0gICAgICA0OTYsICA0OTcsICA0OTgsICA1MDAsICA1MDMs ICA1MDYsICA1MDgsICA1MTAsICA1MTEsICA1MTIsDQo+PiAtICAgICAgNTEzLCAgNTE0LCAgNTE2 LCAgNTE3LCAgNTE5LCAgNTIwLCAgNTIxLCAgNTIyLCAgNTIzLCAgNTI0LA0KPj4gLSAgICAgIDUy NiwgIDUyNywgIDUyOCwgIDUyOSwgIDUzMCwgIDUzMiwgIDUzMywgIDUzNSwgIDUzNiwgIDUzOCwN Cj4+IC0gICAgICA1MzksICA1NDAsICA1NDIsICA1NDMsICA1NDUsICA1NDYsICA1NDgsICA1NDks ICA1NTEsICA1NTMsDQo+PiAtICAgICAgNTU0LCAgNTU2LCAgNTU3LCAgNTU4LCAgNTYwLCAgNTYx LCAgNTYzLCAgNTY0LCAgNTY2LCAgNTY4LA0KPj4gLSAgICAgIDU3MCwgIDU3MSwgIDU3MywgIDU3 NSwgIDU3NQ0KPj4gKyAgICAgIDE0MywgIDE0NCwgIDE0NSwgIDE0NiwgIDE0NywgIDE0OCwgIDE1 MCwgIDE1MiwgIDE1MywgIDE1NCwNCj4+ICsNCj4+ICsgICAgICAxNTUsICAxNTYsICAxNjAsICAx NjEsICAxNjIsICAxNjQsICAxNjUsICAxNjYsICAxNjcsICAxNjgsDQo+PiArICAgICAgMTY5LCAg MTcwLCAgMTcxLCAgMTcyLCAgMTc3LCAgMTc4LCAgMTc5LCAgMTgzLCAgMTg0LCAgMTg5LA0KPj4g KyAgICAgIDE5MCwgIDE5MSwgIDE5MiwgIDE5NywgIDE5OCwgIDE5OSwgIDIwMCwgIDIwMSwgIDIw MiwgIDIwNSwNCj4+ICsgICAgICAyMDgsICAyMTAsICAyMTIsICAyMTMsICAyMTUsICAyMTcsICAy MTgsICAyMTksICAyMjAsICAyMjEsDQo+PiArICAgICAgMjI1LCAgMjI2LCAgMjI3LCAgMjI4LCAg MjMxLCAgMjM0LCAgMjM2LCAgMjM4LCAgMjM5LCAgMjQwLA0KPj4gKyAgICAgIDI0MywgIDI0Niwg IDI0OCwgIDI1MCwgIDI1MywgIDI1NiwgIDI1OCwgIDI2MCwgIDI2MSwgIDI2MiwNCj4+ICsgICAg ICAyNjUsICAyNjgsICAyNzAsICAyNzIsICAyNzMsICAyNzQsICAyNzUsICAyNzYsICAyNzcsICAy ODAsDQo+PiArICAgICAgMjgzLCAgMjg1LCAgMjg3LCAgMjg4LCAgMjg5LCAgMjkxLCAgMjkyLCAg MjkzLCAgMjk0LCAgMjk1LA0KPj4gKyAgICAgIDI5NiwgIDI5NywgIDMwMCwgIDMwMywgIDMwNSwg IDMwNywgIDMwOCwgIDMwOSwgIDMxMywgIDMxNiwNCj4+ICsgICAgICAzMTksICAzMjEsICAzMjMs ICAzMjQsICAzMjUsICAzMjYsICAzMjksICAzMzIsICAzMzQsICAzMzYsDQo+PiArDQo+PiArICAg ICAgMzM3LCAgMzQwLCAgMzQzLCAgMzQ1LCAgMzQ3LCAgMzQ4LCAgMzQ5LCAgMzUwLCAgMzUzLCAg MzU2LA0KPj4gKyAgICAgIDM1OCwgIDM2MCwgIDM2MSwgIDM2MiwgIDM2MywgIDM2NSwgIDM2Niwg IDM2NywgIDM2OCwgIDM2OSwNCj4+ICsgICAgICAzNzAsICAzNzEsICAzNzIsICAzNzMsICAzNzQs ICAzNzYsICAzNzksICAzODIsICAzODQsICAzODYsDQo+PiArICAgICAgMzg3LCAgMzg4LCAgMzg5 LCAgMzkyLCAgMzk1LCAgMzk3LCAgMzk5LCAgNDAxLCAgNDAyLCAgNDAzLA0KPj4gKyAgICAgIDQw NCwgIDQwNSwgIDQwNiwgIDQwNywgIDQwOSwgIDQxMSwgIDQxMiwgIDQxMywgIDQxNCwgIDQxNSwN Cj4+ICsgICAgICA0MTYsICA0MTcsICA0MTgsICA0MTksICA0MjAsICA0MjIsICA0MjQsICA0MjUs ICA0MjYsICA0MjksDQo+PiArICAgICAgNDMyLCAgNDM0LCAgNDM2LCAgNDM3LCAgNDM5LCAgNDQw LCAgNDQyLCAgNDQzLCAgNDQ0LCAgNDQ4LA0KPj4gKyAgICAgIDQ1MCwgIDQ1MSwgIDQ1MiwgIDQ1 NCwgIDQ1NSwgIDQ1NywgIDQ1OCwgIDQ1OSwgIDQ2MCwgIDQ2MSwNCj4+ICsgICAgICA0NjIsICA0 NjQsICA0NjUsICA0NjcsICA0NjksICA0NzAsICA0NzEsICA0NzMsICA0NzQsICA0NzUsDQo+PiAr ICAgICAgNDc2LCAgNDc4LCAgNDc5LCAgNDgyLCAgNDg1LCAgNDg3LCAgNDg5LCAgNDkxLCAgNDky LCAgNDkzLA0KPj4gKw0KPj4gKyAgICAgIDQ5NSwgIDQ5NiwgIDQ5NywgIDQ5OCwgIDQ5OSwgIDUw MCwgIDUwMiwgIDUwMywgIDUwNCwgIDUwNSwNCj4+ICsgICAgICA1MDYsICA1MDgsICA1MDksICA1 MTIsICA1MTUsICA1MTcsICA1MTksICA1MjAsICA1MjEsICA1MjIsDQo+PiArICAgICAgNTIzLCAg NTI1LCAgNTI2LCAgNTI4LCAgNTI5LCAgNTMwLCAgNTMxLCAgNTMyLCAgNTMzLCAgNTM1LA0KPj4g KyAgICAgIDUzNiwgIDUzNywgIDUzOCwgIDUzOSwgIDU0MCwgIDU0MiwgIDU0MywgIDU0NSwgIDU0 NiwgIDU0OCwNCj4+ICsgICAgICA1NDksICA1NTAsICA1NTEsICA1NTMsICA1NTQsICA1NTYsICA1 NTcsICA1NTksICA1NjAsICA1NjIsDQo+PiArICAgICAgNTY0LCAgNTY1LCAgNTY3LCAgNTY4LCAg NTY5LCAgNTcwLCAgNTcyLCAgNTczLCAgNTc1LCAgNTc2LA0KPj4gKyAgICAgIDU3OCwgIDU4MCwg IDU4MiwgIDU4MywgIDU4NSwgIDU4NiwgIDU4OCwgIDU5MCwgIDU5MSwgIDU5MiwNCj4+ICsgICAg ICA1OTQsICA1OTQNCj4+ICAgICAgIH0gOw0KPj4NCj4+ICAgc3RhdGljIGNvbnN0IFlZX0NIQVIg eXlfZWNbMjU2XSA9DQo+PiBAQCAtNzA4LDIxNiArNzEzLDIyNCBAQCBzdGF0aWMgY29uc3QgWVlf Q0hBUiB5eV9tZXRhWzM1XSA9DQo+PiAgICAgICAgICAgMSwgICAgMSwgICAgMSwgICAgMQ0KPj4g ICAgICAgfSA7DQo+Pg0KPj4gLXN0YXRpYyBjb25zdCBmbGV4X2ludDE2X3QgeXlfYmFzZVs0MjRd ID0NCj4+ICtzdGF0aWMgY29uc3QgZmxleF9pbnQxNl90IHl5X2Jhc2VbNDQzXSA9DQo+PiAgICAg ICB7ICAgMCwNCj4+IC0gICAgICAgIDAsICAgIDAsICA5MDEsICA5MDAsICA5MDIsICA4OTcsICAg MzMsICAgMzYsICA5MDUsICA5MDUsDQo+PiAtICAgICAgIDQ1LCAgIDYzLCAgIDMxLCAgIDQyLCAg IDUxLCAgIDUyLCAgODkwLCAgIDMzLCAgIDY1LCAgIDY3LA0KPj4gLSAgICAgICA2OSwgICA3MCwg IDg4OSwgICA3MSwgIDg4OCwgICA3NSwgICAgMCwgIDkwNSwgIDg5MywgIDkwNSwNCj4+IC0gICAg ICAgOTEsICAgOTQsICAgIDAsICAgIDAsICAxMDMsICA4ODYsICAxMTIsICAgIDAsICAgODksICAg OTgsDQo+PiAtICAgICAgMTEzLCAgIDkyLCAgMTE0LCAgIDk5LCAgMTAwLCAgIDQ4LCAgMTIxLCAg MTE2LCAgMTE5LCAgIDc0LA0KPj4gLSAgICAgIDEyNCwgIDEyOSwgIDEyMywgIDEzNSwgIDEzMiwg IDEzMywgIDEzNywgIDEzNCwgIDEzOCwgIDEzOSwNCj4+IC0gICAgICAxNDEsICAgIDAsICAxNTUs ICAgIDAsICAgIDAsICAxNjQsICAgIDAsICAgIDAsICA4NDksICAxNDIsDQo+PiAtICAgICAgMTUy LCAgMTY0LCAgMTQwLCAgMTYxLCAgMTY1LCAgMTY2LCAgMTY3LCAgMTY4LCAgMTY5LCAgMTczLA0K Pj4gLSAgICAgIDE3NCwgIDE3OCwgIDE3NiwgIDE4MCwgIDE4NCwgIDIwOCwgIDE4OSwgIDE4Mywg IDE5MiwgIDE5NSwNCj4+IC0gICAgICAyMTUsICAxOTEsICAxOTMsICAyMjMsICAgIDAsICAgIDAs ICA5MDUsICAyMDgsICAyMDQsICAyMzYsDQo+PiAtDQo+PiAtICAgICAgMjE5LCAgMjA5LCAgMjM4 LCAgMTk2LCAgMjM3LCAgODMxLCAgMjQyLCAgODE1LCAgMjQxLCAgMjI0LA0KPj4gLSAgICAgIDI0 MywgIDI2MSwgIDI0NCwgIDI1OSwgIDI3NywgIDI2NiwgIDI4NiwgIDI1MCwgIDI4OCwgIDI5OCwN Cj4+IC0gICAgICAyNDksICAyODMsICAyNzQsICAyODIsICAyOTQsICAzMDgsICAgIDAsICAzMTAs ICAgIDAsICAyOTUsDQo+PiAtICAgICAgMzA1LCAgOTA1LCAgMzA4LCAgMzA2LCAgMzEzLCAgMzE0 LCAgMzQyLCAgMzE5LCAgMzE2LCAgMzIwLA0KPj4gLSAgICAgIDMzMSwgICAgMCwgIDM0OSwgICAg MCwgIDM0MiwgIDM0NCwgIDM1NiwgICAgMCwgIDM1OCwgICAgMCwNCj4+IC0gICAgICAzNjUsICAg IDAsICAzNjcsICAgIDAsICAzNTQsICAzNzUsICAgIDAsICAzNzcsICAgIDAsICAzNjMsDQo+PiAt ICAgICAgMzU2LCAgODA5LCAgMzI3LCAgMzIyLCAgMzg0LCAgICAwLCAgICAwLCAgICAwLCAgICAw LCAgMzc5LA0KPj4gLSAgICAgIDkwNSwgIDM4MiwgIDM4NCwgIDM4NiwgIDM5MCwgIDM3MiwgIDM5 MiwgIDQwMywgICAgMCwgIDQxMCwNCj4+IC0gICAgICAgIDAsICA0MDcsICA0MTMsICA0MjMsICA0 MjYsICAgIDAsICAgIDAsICAgIDAsICAgIDAsICA0MDksDQo+PiAtICAgICAgNDI0LCAgNDM1LCAg ICAwLCAgICAwLCAgICAwLCAgICAwLCAgNDM3LCAgICAwLCAgICAwLCAgICAwLA0KPj4gLQ0KPj4g LSAgICAgICAgMCwgIDQzMywgIDQ0NCwgICAgMCwgICAgMCwgICAgMCwgICAgMCwgIDM5MSwgIDQ0 MCwgIDc4MSwNCj4+IC0gICAgICA5MDUsICA3NjksICA0MzksICA0NDUsICA0NDQsICA0NDcsICA0 NDksICA0NTQsICA0NTMsICAzOTksDQo+PiAtICAgICAgNDY0LCAgICAwLCAgICAwLCAgICAwLCAg ICAwLCAgNzU3LCAgNDY1LCAgNDc2LCAgICAwLCAgNDc4LA0KPj4gLSAgICAgICAgMCwgIDQ3OSwg IDQ3NiwgIDc1MywgIDQ2MiwgIDQ5MCwgIDc0OSwgIDkwNSwgIDc0NSwgIDkwNSwNCj4+IC0gICAg ICA0ODMsICA3MzcsICA0MjQsICA0ODUsICA0ODcsICA0OTAsICA1MDAsICA0OTMsICA5MDUsICA3 MjksDQo+PiAtICAgICAgOTA1LCAgNTAyLCAgNTE4LCAgICAwLCAgICAwLCAgICAwLCAgICAwLCAg OTA1LCAgNDk4LCAgNzIxLA0KPj4gLSAgICAgIDkwNSwgIDUyNywgIDcxMywgICAgMCwgIDcwNSwg IDkwNSwgIDQ5NSwgIDY5NywgIDkwNSwgIDM2NSwNCj4+IC0gICAgICA1MjEsICA1MjgsICA1MzAs ICA2ODUsICA5MDUsICA1MzQsICA1NDAsICA1NDAsICA2NTcsICA5MDUsDQo+PiAtICAgICAgNTM3 LCAgNTQyLCAgNjUwLCAgOTA1LCAgNTUzLCAgICAwLCAgNTU3LCAgICAwLCAgICAwLCAgNTUxLA0K Pj4gLSAgICAgIDY0MSwgIDkwNSwgIDU1OCwgIDU1NywgIDYzMywgIDYxNCwgIDYxMywgIDkwNSwg IDU0NywgIDU1NSwNCj4+IC0NCj4+IC0gICAgICA1NjMsICA1NjUsICA1NjksICA1ODQsICAgIDAs ICAgIDAsICAgIDAsICAgIDAsICA1ODMsICA1NzAsDQo+PiAtICAgICAgNTg1LCAgNjEyLCAgOTA1 LCAgNjAxLCAgOTA1LCAgNTIyLCAgNTgwLCAgNTg5LCAgNTk0LCAgOTA1LA0KPj4gLSAgICAgIDYw MCwgIDU4NSwgIDU2MywgIDUyMCwgIDkwNSwgIDUxNCwgIDkwNSwgIDU4NiwgIDQ4NiwgIDU5NywN Cj4+IC0gICAgICA0ODAsICA0NDEsICA5MDUsICA0MTYsICA5MDUsICAzNDUsICA5MDUsICAzMzQs ICA5MDUsICA2MDEsDQo+PiAtICAgICAgMjU0LCAgOTA1LCAgMjQyLCAgOTA1LCAgMjAwLCAgOTA1 LCAgMTUxLCAgOTA1LCAgOTA1LCAgNjA3LA0KPj4gLSAgICAgICA4NiwgIDkwNSwgIDkwNSwgIDkw NSwgIDYyMCwgIDYyNCwgIDYyNywgIDYzMSwgIDYzNSwgIDYzOSwNCj4+IC0gICAgICA2NDMsICA2 NDcsICA2NTEsICA2NTUsICA2NTksICA2NjMsICA2NjcsICA2NzEsICA2NzUsICA2NzksDQo+PiAt ICAgICAgNjgzLCAgNjg3LCAgNjkxLCAgNjk1LCAgNjk5LCAgNzAzLCAgNzA3LCAgNzExLCAgNzE1 LCAgNzE5LA0KPj4gLSAgICAgIDcyMywgIDcyNywgIDczMSwgIDczNSwgIDczOSwgIDc0MywgIDc0 NywgIDc1MSwgIDc1NSwgIDc1OSwNCj4+IC0gICAgICA3NjMsICA3NjcsICA3NzEsICA3NzUsICA3 NzksICA3ODMsICA3ODcsICA3OTEsICA3OTUsICA3OTksDQo+PiAtDQo+PiAtICAgICAgODAzLCAg ODA3LCAgODExLCAgODE1LCAgODE5LCAgODIzLCAgODI3LCAgODMxLCAgODM1LCAgODM5LA0KPj4g LSAgICAgIDg0MywgIDg0NywgIDg1MSwgIDg1NSwgIDg1OSwgIDg2MywgIDg2NywgIDg3MSwgIDg3 NSwgIDg3OSwNCj4+IC0gICAgICA4ODMsICA4ODcsICA4OTENCj4+ICsgICAgICAgIDAsICAgIDAs ICA5MzYsICA5MzUsICA5MzcsICA5MzIsICAgMzMsICAgMzYsICA5NDAsICA5NDAsDQo+PiArICAg ICAgIDQ1LCAgIDYzLCAgIDMxLCAgIDQyLCAgIDUxLCAgIDUyLCAgOTI1LCAgIDMzLCAgIDY1LCAg IDY3LA0KPj4gKyAgICAgICA2OSwgICA3MCwgIDkyNCwgICA3MSwgIDkyMywgICA3NSwgICAgMCwg IDk0MCwgIDkyOCwgIDk0MCwNCj4+ICsgICAgICAgOTEsICAgOTUsICAgIDAsICAgIDAsICAxMDQs ICA5MjEsICAxMTMsICAgIDAsICAgOTEsICAgOTksDQo+PiArICAgICAgMTE0LCAgIDkyLCAgMTE1 LCAgIDgwLCAgMTAwLCAgIDQ4LCAgMTE5LCAgMTIxLCAgMTIyLCAgIDc0LA0KPj4gKyAgICAgIDEy MywgIDEyOCwgIDEzMSwgIDEyOSwgIDEyNSwgIDEzMywgIDEzNSwgIDEzNiwgIDEzNywgIDE0MywN Cj4+ICsgICAgICAxMzgsICAxNDUsICAgIDAsICAxNTcsICAgIDAsICAgIDAsICAxNjgsICAgIDAs ICAgIDAsICA5MjYsDQo+PiArICAgICAgMTQwLCAgMTQ2LCAgMTY1LCAgMTU5LCAgMTUyLCAgMTY0 LCAgMTU1LCAgMTY4LCAgMTcxLCAgMTc2LA0KPj4gKyAgICAgIDE3NywgIDE3MCwgIDE4MCwgIDE3 NSwgIDE4NCwgIDE4OCwgIDIxMiwgIDE5MSwgIDE4NSwgIDE5MiwNCj4+ICsgICAgICAxOTMsICAx OTQsICAyMTksICAyMTIsICAxOTksICAyMzAsICAgIDAsICAgIDAsICA5NDAsICAxOTUsDQo+PiAr DQo+PiArICAgICAgMjAwLCAgMjM5LCAgMjM1LCAgMTk3LCAgMjQ2LCAgMjI1LCAgMjI2LCAgOTE5 LCAgMjQ0LCAgOTE4LA0KPj4gKyAgICAgIDI0MywgIDIzNiwgIDI0NSwgIDI2NiwgIDI0OCwgIDI2 NCwgIDI4MiwgIDI3MSwgIDI5MSwgIDI0OCwNCj4+ICsgICAgICAyNzAsICAyNTQsICAzMDAsICAy NzksICAyOTYsICAzMDIsICAyODgsICAzMDMsICAzMTEsICAgIDAsDQo+PiArICAgICAgMzE1LCAg ICAwLCAgMzExLCAgMzE4LCAgOTQwLCAgMzEzLCAgMzE5LCAgMjA4LCAgMzEzLCAgMzQ0LA0KPj4g KyAgICAgIDMyMSwgIDMzMSwgIDMyNSwgIDMzMywgICAgMCwgIDM1MiwgICAgMCwgIDM0NSwgIDM0 NywgIDM1OSwNCj4+ICsgICAgICAgIDAsICAzNjEsICAgIDAsICAzNjgsICAgIDAsICAzNzAsICAg IDAsICAzMjIsICAzNjYsICAzNzksDQo+PiArICAgICAgICAwLCAgMzgxLCAgICAwLCAgMzU5LCAg MzU3LCAgOTIzLCAgMzgyLCAgMzg0LCAgMzkyLCAgICAwLA0KPj4gKyAgICAgICAgMCwgICAgMCwg ICAgMCwgIDM4NywgIDk0MCwgIDM4NiwgIDM5MCwgIDM5MiwgIDMyOSwgIDQwMSwNCj4+ICsgICAg ICAzOTcsICA0MDksICAgIDAsICA0MTcsICAgIDAsICAzOTksICA0MTIsICA0MjYsICA0MjksICAg IDAsDQo+PiArICAgICAgICAwLCAgICAwLCAgICAwLCAgNDEyLCAgNDI3LCAgNDM4LCAgICAwLCAg ICAwLCAgICAwLCAgICAwLA0KPj4gKw0KPj4gKyAgICAgIDQ0MCwgICAgMCwgICAgMCwgICAgMCwg ICAgMCwgIDQzNiwgIDQwNSwgIDQ0NywgICAgMCwgICAgMCwNCj4+ICsgICAgICAgIDAsICAgIDAs ICA0MzgsICA0NDMsICA5MjIsICA5NDAsICA5MjEsICA0NDIsICA0NTAsICA0NDksDQo+PiArICAg ICAgNDUyLCAgNDU0LCAgNDU5LCAgNDU4LCAgNDUzLCAgNDY5LCAgICAwLCAgICAwLCAgICAwLCAg ICAwLA0KPj4gKyAgICAgIDkyMCwgIDQ3MCwgIDQ4MSwgICAgMCwgIDQ4MywgICAgMCwgIDQ4NCwg IDQ4MSwgIDkxOSwgIDM2OCwNCj4+ICsgICAgICA0NjcsICA0OTUsICA5MTgsICA5NDAsICA5MTcs ICA5NDAsICA0ODgsICA5MTYsICA0NzksICA0OTAsDQo+PiArICAgICAgNDkyLCAgNDk1LCAgNTA1 LCAgNDk4LCAgOTQwLCAgOTE1LCAgOTQwLCAgNTA3LCAgNTIzLCAgICAwLA0KPj4gKyAgICAgICAg MCwgICAgMCwgICAgMCwgIDk0MCwgIDUwMywgIDg2NCwgIDk0MCwgIDg0NiwgIDUzMiwgIDgzNiwN Cj4+ICsgICAgICAgIDAsICA4MjQsICA5NDAsICA1MTYsICA3OTYsICA5NDAsICA1MTMsICA1MzAs ICA1MzYsICA1MzgsDQo+PiArICAgICAgNzg0LCAgOTQwLCAgNTQyLCAgNTM1LCAgNTQ3LCAgNzcy LCAgOTQwLCAgNTQ5LCAgNTUxLCAgNzY4LA0KPj4gKyAgICAgIDk0MCwgIDUwMiwgIDU2MiwgICAg MCwgIDU2NCwgICAgMCwgICAgMCwgIDU2MiwgIDc2NCwgIDk0MCwNCj4+ICsNCj4+ICsgICAgICA1 NDQsICA1NTcsICA3NjAsICA3NTIsICA3NDQsICA5NDAsICA1NTIsICA1NjgsICA1NzEsICA1Njgs DQo+PiArICAgICAgNTgxLCAgNTc3LCAgNTg4LCAgICAwLCAgICAwLCAgICAwLCAgICAwLCAgNTg5 LCAgNTgwLCAgNTkxLA0KPj4gKyAgICAgIDczNiwgIDk0MCwgIDcyOCwgIDk0MCwgIDYwMSwgIDYw MiwgIDU5NywgIDU5OSwgIDk0MCwgIDYwMywNCj4+ICsgICAgICA3MjAsICA3MTIsICA3MDAsICA2 NzIsICA5NDAsICA2NjUsICA5NDAsICA2MTAsICA2NTYsICA2MDMsDQo+PiArICAgICAgNjQ4LCAg NjA3LCAgNjI5LCAgOTQwLCAgNjI3LCAgOTQwLCAgNjI1LCAgOTQwLCAgNjI0LCAgOTQwLA0KPj4g KyAgICAgIDYwNywgIDU3NCwgIDk0MCwgIDYxNCwgIDU3MiwgIDk0MCwgIDQ5MSwgIDk0MCwgIDQz MywgIDk0MCwNCj4+ICsgICAgICA5NDAsICA2MjIsICAzODksICA5NDAsICAzMDMsICA5NDAsICAy NjEsICA5NDAsICAyMDQsICA5NDAsDQo+PiArICAgICAgOTQwLCAgNjM1LCAgNjM5LCAgNjQyLCAg NjQ2LCAgNjUwLCAgNjU0LCAgNjU4LCAgNjYyLCAgNjY2LA0KPj4gKyAgICAgIDY3MCwgIDY3NCwg IDY3OCwgIDY4MiwgIDY4NiwgIDY5MCwgIDY5NCwgIDY5OCwgIDcwMiwgIDcwNiwNCj4+ICsgICAg ICA3MTAsICA3MTQsICA3MTgsICA3MjIsICA3MjYsICA3MzAsICA3MzQsICA3MzgsICA3NDIsICA3 NDYsDQo+PiArDQo+PiArICAgICAgNzUwLCAgNzU0LCAgNzU4LCAgNzYyLCAgNzY2LCAgNzcwLCAg Nzc0LCAgNzc4LCAgNzgyLCAgNzg2LA0KPj4gKyAgICAgIDc5MCwgIDc5NCwgIDc5OCwgIDgwMiwg IDgwNiwgIDgxMCwgIDgxNCwgIDgxOCwgIDgyMiwgIDgyNiwNCj4+ICsgICAgICA4MzAsICA4MzQs ICA4MzgsICA4NDIsICA4NDYsICA4NTAsICA4NTQsICA4NTgsICA4NjIsICA4NjYsDQo+PiArICAg ICAgODcwLCAgODc0LCAgODc4LCAgODgyLCAgODg2LCAgODkwLCAgODk0LCAgODk4LCAgOTAyLCAg OTA2LA0KPj4gKyAgICAgIDkxMCwgIDkxNA0KPj4gICAgICAgfSA7DQo+Pg0KPj4gLXN0YXRpYyBj b25zdCBmbGV4X2ludDE2X3QgeXlfZGVmWzQyNF0gPQ0KPj4gK3N0YXRpYyBjb25zdCBmbGV4X2lu dDE2X3QgeXlfZGVmWzQ0M10gPQ0KPj4gICAgICAgeyAgIDAsDQo+PiAtICAgICAgMzU0LCAgICAx LCAgMzU1LCAgMzU1LCAgMzU0LCAgMzU2LCAgMzU3LCAgMzU3LCAgMzU0LCAgMzU0LA0KPj4gLSAg ICAgIDM1OCwgIDM1OCwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwg ICAxMiwNCj4+IC0gICAgICAgMTIsICAgMTIsICAgMTIsICAgMTIsICAgMTIsICAgMTIsICAzNTks ICAzNTQsICAzNTYsICAzNTQsDQo+PiAtICAgICAgMzYwLCAgMzU3LCAgMzYxLCAgMzYxLCAgMzYy LCAgIDEyLCAgMzU2LCAgMzYzLCAgIDEyLCAgIDEyLA0KPj4gLSAgICAgICAxMiwgICAxMiwgICAx MiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwNCj4+ICsgICAgICAz NzEsICAgIDEsICAzNzIsICAzNzIsICAzNzEsICAzNzMsICAzNzQsICAzNzQsICAzNzEsICAzNzEs DQo+PiArICAgICAgMzc1LCAgMzc1LCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEy LCAgIDEyLCAgIDEyLA0KPj4gKyAgICAgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAx MiwgIDM3NiwgIDM3MSwgIDM3MywgIDM3MSwNCj4+ICsgICAgICAzNzcsICAzNzQsICAzNzgsICAz NzgsICAzNzksICAgMTIsICAzNzMsICAzODAsICAgMTIsICAgMTIsDQo+PiAgICAgICAgICAxMiwg ICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwNCj4+ IC0gICAgICAgMTIsICAzNTksICAzNjAsICAzNjEsICAzNjEsICAzNjQsICAzNjUsICAzNjUsICAz NTQsICAgMTIsDQo+PiAgICAgICAgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwg ICAxMiwgICAxMiwgICAxMiwgICAxMiwNCj4+IC0gICAgICAgMTIsICAgMTIsICAgMTIsICAgMTIs ICAgMTIsICAzNjIsICAgMTIsICAgMTIsICAgMTIsICAgMTIsDQo+PiAtICAgICAgIDEyLCAgIDEy LCAgIDEyLCAgMzY0LCAgMzY1LCAgMzY1LCAgMzU0LCAgIDEyLCAgIDEyLCAgMzY2LA0KPj4gLQ0K Pj4gKyAgICAgICAxMiwgICAxMiwgIDM3NiwgIDM3NywgIDM3OCwgIDM3OCwgIDM4MSwgIDM4Miwg IDM4MiwgIDM3MSwNCj4+ICAgICAgICAgIDEyLCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEy LCAgIDEyLCAgIDEyLCAgIDEyLCAgIDEyLA0KPj4gLSAgICAgICAxMiwgIDM2NywgICA4NiwgICA4 NiwgIDM2OCwgICAxMiwgIDM2OSwgICAxMiwgICAxMiwgIDM3MCwNCj4+IC0gICAgICAgMTIsICAg MTIsICAgMTIsICAgMTIsICAgMTIsICAzNzEsICAzNzIsICAzNjYsICAzNzIsICAgMTIsDQo+PiAt ICAgICAgIDEyLCAgMzU0LCAgIDg2LCAgIDEyLCAgIDEyLCAgIDEyLCAgMzczLCAgIDEyLCAgIDEy LCAgIDEyLA0KPj4gLSAgICAgIDM3NCwgIDM3NSwgIDM2NywgIDM3NSwgICA4NiwgICA4NiwgIDM3 NiwgIDM3NywgIDM2OCwgIDM3NywNCj4+IC0gICAgICAzNzgsICAzNzksICAzNjksICAzNzksICAg MTIsICAzODAsICAzODEsICAzNzAsICAzODEsICAgMTIsDQo+PiAtICAgICAgIDEyLCAgMzgyLCAg IDEyLCAgIDEyLCAgMzcxLCAgMzcyLCAgMzcyLCAgMzgzLCAgMzgzLCAgIDEyLA0KPj4gLSAgICAg IDM1NCwgICA4NiwgICA4NiwgICA4NiwgICAxMiwgICAxMiwgICAxMiwgIDM4NCwgIDM4NSwgIDM3 MywNCj4+IC0gICAgICAzODUsICAgMTIsICAgMTIsICAzODYsICAzNzQsICAzNzUsICAzNzUsICAz ODcsICAzODcsICAgODYsDQo+PiAtICAgICAgIDg2LCAgMzc2LCAgMzc3LCAgMzc3LCAgMzg4LCAg Mzg4LCAgMzc4LCAgMzc5LCAgMzc5LCAgMzg5LA0KPj4gLQ0KPj4gLSAgICAgIDM4OSwgICAxMiwg IDM4MCwgIDM4MSwgIDM4MSwgIDM5MCwgIDM5MCwgICAxMiwgICAxMiwgIDM5MSwNCj4+IC0gICAg ICAzNTQsICAzOTIsICAgODYsICAgMTIsICAgODYsICAgODYsICAgODYsICAgMTIsICAgODYsICAg MTIsDQo+PiAtICAgICAgMzg0LCAgMzg1LCAgMzg1LCAgMzkzLCAgMzkzLCAgMzk0LCAgIDg2LCAg Mzk1LCAgMzk2LCAgMzg2LA0KPj4gLSAgICAgIDM5NiwgICA4NiwgICA4NiwgIDM5NywgICAxMiwg IDM5OCwgIDM5MSwgIDM1NCwgIDM5OSwgIDM1NCwNCj4+IC0gICAgICAgODYsICA0MDAsICAgMTIs ICAgODYsICAgODYsICAgODYsICA0MDEsICAgODYsICAzNTQsICA0MDIsDQo+PiAtICAgICAgMzU0 LCAgIDg2LCAgMzk1LCAgMzk2LCAgMzk2LCAgNDAzLCAgNDAzLCAgMzU0LCAgIDg2LCAgNDA0LA0K Pj4gLSAgICAgIDM1NCwgIDQwNSwgIDQwNiwgIDQwNiwgIDM5OSwgIDM1NCwgICA4NiwgIDQwNywg IDM1NCwgICAxMiwNCj4+IC0gICAgICAgODYsICAgODYsICAgODYsICA0MDgsICAzNTQsICA0MDgs ICA0MDgsICAgODYsICA0MDIsICAzNTQsDQo+PiAtICAgICAgIDg2LCAgIDg2LCAgNDA0LCAgMzU0 LCAgNDA5LCAgNDEwLCAgNDA1LCAgNDEwLCAgNDA2LCAgIDg2LA0KPj4gLSAgICAgIDQwNywgIDM1 NCwgICAxMiwgICA4NiwgIDQxMSwgIDQxMiwgIDQwOCwgIDM1NCwgIDQwOCwgIDQwOCwNCj4+IC0N Cj4+IC0gICAgICAgODYsICAgODYsICAgODYsICA0MDksICA0MTAsICA0MTAsICA0MTMsICA0MTMs ICAgODYsICAgMTIsDQo+PiAtICAgICAgIDg2LCAgNDE0LCAgMzU0LCAgNDE1LCAgMzU0LCAgNDA4 LCAgNDA4LCAgIDg2LCAgIDg2LCAgMzU0LA0KPj4gLSAgICAgIDQxNiwgIDQxNywgIDQxOCwgIDQx NCwgIDM1NCwgIDQxNSwgIDM1NCwgIDQwOCwgIDQwOCwgICA4NiwNCj4+IC0gICAgICA0MTksICA0 MjAsICAzNTQsICA0MjEsICAzNTQsICA0MjIsICAzNTQsICA0MDgsICAzNTQsICAgODYsDQo+PiAt ICAgICAgNDIzLCAgMzU0LCAgNDIwLCAgMzU0LCAgNDIxLCAgMzU0LCAgNDIyLCAgMzU0LCAgMzU0 LCAgIDg2LA0KPj4gLSAgICAgIDQyMywgIDM1NCwgIDM1NCwgICAgMCwgIDM1NCwgIDM1NCwgIDM1 NCwgIDM1NCwgIDM1NCwgIDM1NCwNCj4+IC0gICAgICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAz NTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsDQo+PiAtICAgICAgMzU0LCAgMzU0LCAg MzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LA0KPj4gLSAgICAg IDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1 NCwNCj4+IC0gICAgICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAz NTQsICAzNTQsICAzNTQsDQo+PiAtDQo+PiAtICAgICAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAg MzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LA0KPj4gLSAgICAgIDM1NCwgIDM1NCwg IDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwNCj4+IC0gICAg ICAzNTQsICAzNTQsICAzNTQNCj4+ICsgICAgICAgMTIsICAgMTIsICAgMTIsICAgMTIsICAgMTIs ICAgMTIsICAzNzksICAgMTIsICAgMTIsICAgMTIsDQo+PiArICAgICAgIDEyLCAgIDEyLCAgIDEy LCAgIDEyLCAgIDEyLCAgMzgxLCAgMzgyLCAgMzgyLCAgMzcxLCAgIDEyLA0KPj4gKw0KPj4gKyAg ICAgICAxMiwgIDM4MywgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwgICAxMiwg ICAxMiwNCj4+ICsgICAgICAgMTIsICAgMTIsICAgMTIsICAzODQsICAgODcsICAgODcsICAzODUs ICAgMTIsICAzODYsICAgMTIsDQo+PiArICAgICAgIDEyLCAgIDEyLCAgMzg3LCAgIDEyLCAgIDEy LCAgIDEyLCAgIDEyLCAgIDEyLCAgMzg4LCAgMzg5LA0KPj4gKyAgICAgIDM4MywgIDM4OSwgICAx MiwgICAxMiwgIDM3MSwgICA4NywgICAxMiwgICAxMiwgICAxMiwgIDM5MCwNCj4+ICsgICAgICAg MTIsICAgMTIsICAgMTIsICAzOTEsICAzOTIsICAzODQsICAzOTIsICAgODcsICAgODcsICAzOTMs DQo+PiArICAgICAgMzk0LCAgMzg1LCAgMzk0LCAgMzk1LCAgMzk2LCAgMzg2LCAgMzk2LCAgIDEy LCAgIDEyLCAgMzk3LA0KPj4gKyAgICAgIDM5OCwgIDM4NywgIDM5OCwgICAxMiwgICAxMiwgIDM5 OSwgICAxMiwgICAxMiwgIDM4OCwgIDM4OSwNCj4+ICsgICAgICAzODksICA0MDAsICA0MDAsICAg MTIsICAzNzEsICAgODcsICAgODcsICAgODcsICAgMTIsICAgMTIsDQo+PiArICAgICAgIDEyLCAg NDAxLCAgNDAyLCAgMzkwLCAgNDAyLCAgIDEyLCAgIDEyLCAgNDAzLCAgMzkxLCAgMzkyLA0KPj4g KyAgICAgIDM5MiwgIDQwNCwgIDQwNCwgICA4NywgICA4NywgIDM5MywgIDM5NCwgIDM5NCwgIDQw NSwgIDQwNSwNCj4+ICsNCj4+ICsgICAgICAzOTUsICAzOTYsICAzOTYsICA0MDYsICA0MDYsICAg MTIsICAgMTIsICAzOTcsICAzOTgsICAzOTgsDQo+PiArICAgICAgNDA3LCAgNDA3LCAgIDEyLCAg IDEyLCAgNDA4LCAgMzcxLCAgNDA5LCAgIDg3LCAgIDEyLCAgIDg3LA0KPj4gKyAgICAgICA4Nywg ICA4NywgICAxMiwgICA4NywgICAxMiwgIDQwMSwgIDQwMiwgIDQwMiwgIDQxMCwgIDQxMCwNCj4+ ICsgICAgICA0MTEsICAgODcsICA0MTIsICA0MTMsICA0MDMsICA0MTMsICAgODcsICAgODcsICA0 MTQsICAgMTIsDQo+PiArICAgICAgIDEyLCAgNDE1LCAgNDA4LCAgMzcxLCAgNDE2LCAgMzcxLCAg IDg3LCAgNDE3LCAgIDEyLCAgIDg3LA0KPj4gKyAgICAgICA4NywgICA4NywgIDQxOCwgICA4Nywg IDM3MSwgIDQxOSwgIDM3MSwgICA4NywgIDQxMiwgIDQxMywNCj4+ICsgICAgICA0MTMsICA0MjAs ICA0MjAsICAzNzEsICAgODcsICA0MjEsICAzNzEsICAgMTIsICA0MjIsICA0MjMsDQo+PiArICAg ICAgNDIzLCAgNDE2LCAgMzcxLCAgIDg3LCAgNDI0LCAgMzcxLCAgIDEyLCAgIDg3LCAgIDg3LCAg IDg3LA0KPj4gKyAgICAgIDQyNSwgIDM3MSwgIDQyNSwgIDQyNSwgICA4NywgIDQxOSwgIDM3MSwg ICA4NywgICA4NywgIDQyMSwNCj4+ICsgICAgICAzNzEsICAgMTIsICA0MjYsICA0MjcsICA0MjIs ICA0MjcsICA0MjMsICAgODcsICA0MjQsICAzNzEsDQo+PiArDQo+PiArICAgICAgIDEyLCAgIDg3 LCAgNDI4LCAgNDI5LCAgNDI1LCAgMzcxLCAgNDI1LCAgNDI1LCAgIDg3LCAgIDg3LA0KPj4gKyAg ICAgICA4NywgICAxMiwgIDQyNiwgIDQyNywgIDQyNywgIDQzMCwgIDQzMCwgICA4NywgICAxMiwg ICA4NywNCj4+ICsgICAgICA0MzEsICAzNzEsICA0MzIsICAzNzEsICA0MjUsICA0MjUsICAgODcs ICAgODcsICAzNzEsICAgMTIsDQo+PiArICAgICAgNDMzLCAgNDM0LCAgNDM1LCAgNDMxLCAgMzcx LCAgNDMyLCAgMzcxLCAgNDI1LCAgNDI1LCAgIDg3LA0KPj4gKyAgICAgIDQzNiwgICAxMiwgIDQz NywgIDM3MSwgIDQzOCwgIDM3MSwgIDQzOSwgIDM3MSwgIDQyNSwgIDM3MSwNCj4+ICsgICAgICAg ODcsICA0NDAsICAzNzEsICAgMTIsICA0MzcsICAzNzEsICA0MzgsICAzNzEsICA0MzksICAzNzEs DQo+PiArICAgICAgMzcxLCAgIDg3LCAgNDQwLCAgMzcxLCAgNDQxLCAgMzcxLCAgNDQyLCAgMzcx LCAgNDQyLCAgMzcxLA0KPj4gKyAgICAgICAgMCwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3 MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwNCj4+ICsgICAgICAzNzEsICAzNzEsICAzNzEsICAz NzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsDQo+PiArICAgICAgMzcxLCAg MzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLA0KPj4g Kw0KPj4gKyAgICAgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3 MSwgIDM3MSwgIDM3MSwNCj4+ICsgICAgICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAz NzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsDQo+PiArICAgICAgMzcxLCAgMzcxLCAgMzcxLCAg MzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLA0KPj4gKyAgICAgIDM3MSwg IDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwNCj4+ ICsgICAgICAzNzEsICAzNzENCj4+ICAgICAgIH0gOw0KPj4NCj4+IC1zdGF0aWMgY29uc3QgZmxl eF9pbnQxNl90IHl5X254dFs5NDBdID0NCj4+ICtzdGF0aWMgY29uc3QgZmxleF9pbnQxNl90IHl5 X254dFs5NzVdID0NCj4+ICAgICAgIHsgICAwLA0KPj4gICAgICAgICAgIDYsICAgIDcsICAgIDgs ICAgIDksICAgIDYsICAgIDYsICAgIDYsICAgIDYsICAgMTAsICAgMTEsDQo+PiAgICAgICAgICAx MiwgICAxMywgICAxNCwgICAxNSwgICAxNiwgICAxNywgICAxOCwgICAxOSwgICAxNywgICAxNywN Cj4+ICAgICAgICAgIDE3LCAgIDE3LCAgIDIwLCAgIDE3LCAgIDIxLCAgIDIyLCAgIDIzLCAgIDI0 LCAgIDI1LCAgIDE3LA0KPj4gICAgICAgICAgMjYsICAgMTcsICAgMTcsICAgMTcsICAgMzIsICAg MzIsICAgMzMsICAgMzIsICAgMzIsICAgMzMsDQo+PiAgICAgICAgICAzNiwgICAzNCwgICAzNiwg ICA0MiwgICAzNCwgICAyOSwgICAyOSwgICAyOSwgICAzMCwgICAzNSwNCj4+IC0gICAgICAgNTAs ICAgMzYsICAgMzcsICAgMzgsICAgNDMsICAgNDQsICAgMzksICAgMzYsICAgNzksICAgNDUsDQo+ PiArICAgICAgIDUwLCAgIDM2LCAgIDM3LCAgIDM4LCAgIDQzLCAgIDQ0LCAgIDM5LCAgIDM2LCAg IDgwLCAgIDQ1LA0KPj4gICAgICAgICAgMzYsICAgMzYsICAgNDAsICAgMjksICAgMjksICAgMjks ICAgMzAsICAgMzUsICAgNDYsICAgNDgsDQo+PiAgICAgICAgICAzNywgICAzOCwgICA0MSwgICA0 NywgICAzNiwgICA0OSwgICAzNiwgICA1MywgICAzNiwgICAzNiwNCj4+IC0gICAgICAgMzYsICAg NTYsICAgNTgsICAgMzYsICAgMzYsICAgNTUsICAgODIsICAgNjAsICAgNTEsICAzNDIsDQo+PiAt ICAgICAgIDU0LCAgIDYxLCAgIDUyLCAgIDI5LCAgIDY0LCAgIDMyLCAgIDMyLCAgIDMzLCAgIDM2 LCAgIDY1LA0KPj4gLQ0KPj4gLSAgICAgICA3MCwgICAzNiwgICAzNCwgICAyOSwgICAyOSwgICAy OSwgICAzMCwgICAzNiwgICAzNiwgICAzNiwNCj4+IC0gICAgICAgMjksICAgMzgsICAgNjYsICAg NjYsICAgNjYsICAgNjcsICAgNjYsICAgNzEsICAgNzQsICAgNjYsDQo+PiAtICAgICAgIDY4LCAg IDcyLCAgIDM2LCAgIDM2LCAgIDczLCAgIDM2LCAgIDc3LCAgIDc4LCAgIDM2LCAgIDc2LA0KPj4g LSAgICAgICAzNiwgICA1MywgICAzNiwgICAzNiwgICA3NSwgICA4NSwgICA4MCwgICA4MywgICAz NiwgICA4NiwNCj4+IC0gICAgICAgODQsICAgMzYsICAgMzYsICAgMzYsICAgMzYsICAgODEsICAg MzYsICAgMzYsICAgMzYsICAgMzYsDQo+PiAtICAgICAgIDM2LCAgIDM2LCAgIDkzLCAgIDg5LCAg MzM3LCAgIDk4LCAgIDg4LCAgIDI5LCAgIDY0LCAgMTAxLA0KPj4gLSAgICAgICA5MCwgICAzNiwg ICA5MSwgICA2NSwgICA5MiwgICA4NywgICAyOSwgICA5NSwgICA4OSwgICA5OSwNCj4+IC0gICAg ICAgMzYsICAxMDAsICAgOTYsICAgMzYsICAgMzYsICAgMzYsICAgMzYsICAgMzYsICAgMzYsICAx MDYsDQo+PiAtICAgICAgMTA1LCAgIDg1LCAgIDM2LCAgIDM2LCAgMTAyLCAgIDM2LCAgMTA3LCAg IDM2LCAgMTAzLCAgIDM2LA0KPj4gLSAgICAgIDEwOSwgIDExMiwgICAzNiwgICAzNiwgIDEwNCwg IDEwOCwgIDExNSwgIDExMCwgICAzNiwgIDExNywNCj4+IC0NCj4+IC0gICAgICAgMzYsICAgMzYs ICAgMzYsICAzMzUsICAgMzYsICAgMzYsICAxMjIsICAxMTEsICAgMjksICAgMjksDQo+PiAtICAg ICAgIDI5LCAgIDMwLCAgMTE4LCAgIDM2LCAgMTE2LCAgIDI5LCAgIDM4LCAgIDM2LCAgIDM2LCAg MTEzLA0KPj4gLSAgICAgIDExNCwgIDExOSwgIDEyMCwgIDEyMywgICAzNiwgICAyOSwgICA5NSwg IDEyMSwgICAzNiwgIDEzNCwNCj4+IC0gICAgICAxMzEsICAgOTYsICAxMzAsICAgMzYsICAxMjUs ICAxMjQsICAxMjYsICAxMjYsICAgNjYsICAxMjcsDQo+PiAtICAgICAgMTI2LCAgMTMyLCAgMTMz LCAgMTI2LCAgMTI5LCAgMzMzLCAgIDM2LCAgIDM2LCAgMTM1LCAgMTM3LA0KPj4gLSAgICAgICAz NiwgICAzNiwgICAzNiwgIDE0MCwgIDEzOSwgICAzNSwgICAzNSwgIDM1MiwgICAzNiwgICAzNiwN Cj4+IC0gICAgICAgODUsICAxNDEsICAxNDEsICAgNjYsICAxNDIsICAxNDEsICAxNjAsICAxNDUs ICAxNDEsICAxNDQsDQo+PiAtICAgICAgIDM1LCAgIDM1LCAgIDg5LCAgMTE3LCAgMTU1LCAgIDM2 LCAgMTQ2LCAgMTQ3LCAgMTQ3LCAgIDY2LA0KPj4gLSAgICAgIDE0OCwgIDE0NywgIDE2MiwgICAz NiwgIDE0NywgIDE1MCwgIDE1MSwgIDE1MSwgICA2NiwgIDE1MiwNCj4+IC0gICAgICAxNTEsICAg MzYsICAgMzYsICAxNTEsICAxNTQsICAxMjAsICAxNjEsICAgMzYsICAxNTYsICAxNTYsDQo+PiAt DQo+PiAtICAgICAgIDY2LCAgMTU3LCAgMTU2LCAgIDM2LCAgIDM2LCAgMTU2LCAgMTU5LCAgMTY0 LCAgMTcxLCAgMTYzLA0KPj4gLSAgICAgICAyOSwgIDE2NiwgICAyOSwgIDE2OCwgICAzNiwgICAz NiwgIDE2NywgIDE3MCwgIDE2OSwgICAzNSwNCj4+IC0gICAgICAgMzUsICAxNzIsICAgMzYsICAg MzYsICAxNzMsICAgMzYsICAyMTMsICAxODQsICAgMzYsICAgMzYsDQo+PiAtICAgICAgMTc1LCAg IDM2LCAgMTc0LCAgIDI5LCAgMTg2LCAgMjEyLCAgIDM2LCAgMzQ5LCAgMTgzLCAgMTg3LA0KPj4g LSAgICAgIDE3NywgIDE3NiwgIDE3OCwgIDE3OCwgICA2NiwgIDE3OSwgIDE3OCwgIDE4MiwgIDM0 OCwgIDE3OCwNCj4+IC0gICAgICAxODEsICAgMjksICAxODgsICAgMzUsICAgMzUsICAgMzUsICAg MzUsICAxODksICAgMjksICAxOTMsDQo+PiAtICAgICAgIDI5LCAgMTk1LCAgMTkwLCAgIDM2LCAg MTk0LCAgIDM2LCAgMTk2LCAgIDI5LCAgMTk4LCAgIDI5LA0KPj4gLSAgICAgIDIwMCwgIDE5MSwg ICAzNiwgIDE5OSwgICAzNiwgIDIwMSwgIDIxOSwgICAyOSwgIDIwNCwgICAyOSwNCj4+IC0gICAg ICAyMDYsICAgMzYsICAyMDIsICAyMDUsICAyMDksICAyMDcsICAgMjksICAxNjYsICAgMzYsICAy OTMsDQo+PiAtICAgICAgMjA4LCAgMjE0LCAgMTY3LCAgIDM1LCAgIDM1LCAgIDM1LCAgIDM1LCAg IDM1LCAgIDM1LCAgIDM2LA0KPj4gLQ0KPj4gLSAgICAgICAzNiwgICAzNiwgIDI0OSwgIDIxOCwg IDIyMCwgICAyOSwgIDIyMiwgIDIxNiwgICAzNiwgIDIxNywNCj4+IC0gICAgICAyMzUsICAyMjMs ICAgMjksICAyMjQsICAyMTUsICAyMjYsICAgMzYsICAyMjcsICAyMjUsICAzNDYsDQo+PiAtICAg ICAgIDM1LCAgIDM1LCAgIDM2LCAgMjI4LCAgMjI4LCAgIDY2LCAgMjI5LCAgMjI4LCAgIDI5LCAg MTg2LA0KPj4gLSAgICAgIDIyOCwgIDIzMSwgIDIzMiwgICAzNiwgIDE4NywgIDIzMywgICAzNSwg ICAyOSwgIDE5MywgICAyOSwNCj4+IC0gICAgICAxOTgsICAyMzQsICAgMzYsICAxOTQsICAzNDQs ICAxOTksICAgMjksICAyMDQsICAyMzYsICAgMzYsDQo+PiAtICAgICAgIDM1LCAgMjQxLCAgMjA1 LCAgMjQyLCAgIDM2LCAgIDM1LCAgIDM1LCAgMjcwLCAgIDM1LCAgIDM1LA0KPj4gLSAgICAgICAz NSwgICAzNSwgIDI0NywgICAzNiwgICAzNSwgICAzNSwgICAyOSwgIDIyMiwgIDI0NCwgIDI2MiwN Cj4+IC0gICAgICAyNDgsICAgMzYsICAyMjMsICAyNDMsICAyNDUsICAyNDYsICAgMzUsICAyNTIs ICAgMjksICAyNTQsDQo+PiAtICAgICAgIDI5LCAgMjU2LCAgMjU4LCAgMzQyLCAgMjU1LCAgMjU5 LCAgMjU3LCAgIDM1LCAgIDM1LCAgMzM5LA0KPj4gLSAgICAgICAzNSwgICAzNSwgICA2OSwgIDI2 NCwgICAzNSwgICAzNSwgICAzNSwgICAzNSwgICAzNSwgICAzNSwNCj4+IC0NCj4+IC0gICAgICAy NjcsICAgMzUsICAgMzUsICAyNzUsICAgMzUsICAgMzUsICAgMzUsICAgMzUsICAyNzEsICAgMzUs DQo+PiAtICAgICAgIDM1LCAgMjc2LCAgMjc3LCAgIDM1LCAgIDM1LCAgMjcyLCAgMjc4LCAgMzE1 LCAgMjczLCAgMjgxLA0KPj4gLSAgICAgICAyOSwgIDI1NCwgIDI5MCwgIDMxMywgIDI4MiwgIDI3 NSwgIDI1NSwgIDI4NSwgIDI4NSwgICA2NiwNCj4+IC0gICAgICAyODYsICAyODUsICAgMzUsICAg MzUsICAyODUsICAyODgsICAyOTUsICAyOTgsICAyOTYsICAgMzUsDQo+PiAtICAgICAgIDM1LCAg IDM1LCAgIDM1LCAgMjk4LCAgMzAxLCAgMzI4LCAgMjk5LCAgMjk0LCAgIDM1LCAgIDM1LA0KPj4g LSAgICAgIDI3NSwgICAzNSwgICAzNSwgICAzNSwgIDMwMywgICAyOSwgIDMwNSwgIDMwMCwgIDI3 NSwgICAyOSwNCj4+IC0gICAgICAzMDcsICAzMDYsICAgMzUsICAgMzUsICAzMDIsICAzMDgsICAz MzcsICAgMzYsICAgMzUsICAgMzUsDQo+PiAtICAgICAgMzA5LCAgMzEwLCAgMzIwLCAgMzE2LCAg IDM1LCAgIDM1LCAgIDM1LCAgIDM1LCAgMzIyLCAgIDM2LA0KPj4gLSAgICAgICAzNSwgICAzNSwg IDMxNywgIDI3NSwgIDMxOSwgIDMxMSwgICAyOSwgIDMwNSwgIDMzNSwgIDI3NSwNCj4+IC0gICAg ICAzMTgsICAzMjEsICAzMDYsICAzMjMsICAgMzUsICAgMzUsICAgMzUsICAgMzUsICAzMzAsICAz MjksDQo+PiAtDQo+PiAtICAgICAgIDM1LCAgIDM1LCAgMzMxLCAgMzMzLCAgMzI3LCAgIDM1LCAg IDM1LCAgMzM4LCAgIDM1LCAgIDM1LA0KPj4gLSAgICAgIDM1MywgIDM0MCwgICAzNSwgICAzNSwg IDM1MCwgIDMyNSwgIDI3NSwgIDMxNSwgICAzNSwgICAzNSwNCj4+IC0gICAgICAgMjcsICAgMjcs ICAgMjcsICAgMjcsICAgMjksICAgMjksICAgMjksICAgMzEsICAgMzEsICAgMzEsDQo+PiAtICAg ICAgIDMxLCAgIDM2LCAgIDM2LCAgIDM2LCAgIDM2LCAgIDYyLCAgMzEzLCAgIDYyLCAgIDYyLCAg IDYzLA0KPj4gLSAgICAgICA2MywgICA2MywgICA2MywgICA2NSwgIDI2OSwgICA2NSwgICA2NSwg ICAzNSwgICAzNSwgICAzNSwNCj4+IC0gICAgICAgMzUsICAgNjksICAgNjksICAyNjEsICAgNjks ICAgOTQsICAgOTQsICAgOTQsICAgOTQsICAgOTYsDQo+PiAtICAgICAgMjUxLCAgIDk2LCAgIDk2 LCAgMTI4LCAgMTI4LCAgMTI4LCAgMTI4LCAgMTQzLCAgMTQzLCAgMTQzLA0KPj4gLSAgICAgIDE0 MywgIDE0OSwgIDE0OSwgIDE0OSwgIDE0OSwgIDE1MywgIDE1MywgIDE1MywgIDE1MywgIDE1OCwN Cj4+IC0gICAgICAxNTgsICAxNTgsICAxNTgsICAxNjUsICAxNjUsICAxNjUsICAxNjUsICAxNjcs ICAyOTgsICAxNjcsDQo+PiAtICAgICAgMTY3LCAgMTgwLCAgMTgwLCAgMTgwLCAgMTgwLCAgMTg1 LCAgMTg1LCAgMTg1LCAgMTg1LCAgMTg3LA0KPj4gLQ0KPj4gLSAgICAgIDI5MiwgIDE4NywgIDE4 NywgIDE5MiwgIDE5MiwgIDE5MiwgIDE5MiwgIDE5NCwgIDI0MCwgIDE5NCwNCj4+IC0gICAgICAx OTQsICAxOTcsICAxOTcsICAxOTcsICAxOTcsICAxOTksICAyODksICAxOTksICAxOTksICAyMDMs DQo+PiAtICAgICAgMjAzLCAgMjAzLCAgMjAzLCAgMjA1LCAgMjg0LCAgMjA1LCAgMjA1LCAgMjEw LCAgMjEwLCAgMjEwLA0KPj4gLSAgICAgIDIxMCwgIDE2OSwgIDI4MCwgIDE2OSwgIDE2OSwgIDIy MSwgIDIyMSwgIDIyMSwgIDIyMSwgIDIyMywNCj4+IC0gICAgICAyNjksICAyMjMsICAyMjMsICAy MzAsICAyMzAsICAyMzAsICAyMzAsICAxODksICAyNjYsICAxODksDQo+PiAtICAgICAgMTg5LCAg MTk2LCAgMjExLCAgMTk2LCAgMTk2LCAgMjAxLCAgMjYxLCAgMjAxLCAgMjAxLCAgMjA3LA0KPj4g LSAgICAgIDI1MSwgIDIwNywgIDIwNywgIDIzNywgIDIzNywgIDIzNywgIDIzNywgIDIzOSwgIDIz OSwgIDIzOSwNCj4+IC0gICAgICAyMzksICAyMjUsICAyNDAsICAyMjUsICAyMjUsICAyNTAsICAy NTAsICAyNTAsICAyNTAsICAyNTMsDQo+PiAtICAgICAgMjUzLCAgMjUzLCAgMjUzLCAgMjU1LCAg MjM4LCAgMjU1LCAgMjU1LCAgMjYwLCAgMjYwLCAgMjYwLA0KPj4gLSAgICAgIDI2MCwgIDI2Mywg IDI2MywgIDI2MywgIDI2MywgIDI2NSwgIDI2NSwgIDI2NSwgIDI2NSwgIDI2OCwNCj4+IC0NCj4+ IC0gICAgICAyNjgsICAyNjgsICAyNjgsICAyNzQsICAyNzQsICAyNzQsICAyNzQsICAyNzksICAy NzksICAyNzksDQo+PiAtICAgICAgMjc5LCAgMjU3LCAgMjExLCAgMjU3LCAgMjU3LCAgMjgzLCAg MjgzLCAgMjgzLCAgMjgzLCAgMjg3LA0KPj4gLSAgICAgIDI4NywgIDI4NywgIDI4NywgIDI2NCwg IDEzOCwgIDI2NCwgIDI2NCwgIDI5MSwgIDI5MSwgIDI5MSwNCj4+IC0gICAgICAyOTEsICAyOTcs ICAyOTcsICAyOTcsICAyOTcsICAzMDQsICAzMDQsICAzMDQsICAzMDQsICAzMDYsDQo+PiAtICAg ICAgMTM2LCAgMzA2LCAgMzA2LCAgMzEyLCAgMzEyLCAgMzEyLCAgMzEyLCAgMzE0LCAgMzE0LCAg MzE0LA0KPj4gLSAgICAgIDMxNCwgIDMwOCwgICA5NywgIDMwOCwgIDMwOCwgIDMyNCwgIDMyNCwg IDMyNCwgIDMyNCwgIDMyNiwNCj4+IC0gICAgICAzMjYsICAzMjYsICAzMjYsICAzMzIsICAzMzIs ICAzMzIsICAzMzIsICAzMzQsICAzMzQsICAzMzQsDQo+PiAtICAgICAgMzM0LCAgMzM2LCAgMzM2 LCAgMzM2LCAgMzM2LCAgMzQxLCAgMzQxLCAgMzQxLCAgMzQxLCAgMzQzLA0KPj4gLSAgICAgIDM0 MywgIDM0MywgIDM0MywgIDM0NSwgIDM0NSwgIDM0NSwgIDM0NSwgIDM0NywgIDM0NywgIDM0NywN Cj4+IC0gICAgICAzNDcsICAzNTEsICAzNTEsICAzNTEsICAzNTEsICAgMzYsICAgMzAsICAgNTks ICAgNTcsICAgMzYsDQo+PiAtDQo+PiAtICAgICAgIDMwLCAgMzU0LCAgIDI4LCAgIDI4LCAgICA1 LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LA0KPj4gLSAgICAgIDM1NCwgIDM1NCwgIDM1 NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwNCj4+IC0gICAgICAz NTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQs DQo+PiAtICAgICAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0 LCAgMzU0DQo+PiArICAgICAgIDM2LCAgIDU2LCAgIDU4LCAgIDM2LCAgIDM2LCAgIDU1LCAgIDgz LCAgIDYxLCAgIDUxLCAgIDM2LA0KPj4gKyAgICAgICA1NCwgICA2MiwgICA1MiwgICAyOSwgICA2 NSwgICA1OSwgICAzMiwgICAzMiwgICAzMywgICA2NiwNCj4+ICsNCj4+ICsgICAgICAgMzYsICAg MzYsICAgNzEsICAgMzQsICAgMjksICAgMjksICAgMjksICAgMzAsICAgMzYsICAgMzYsDQo+PiAr ICAgICAgIDc3LCAgIDI5LCAgIDM4LCAgIDY3LCAgIDY3LCAgIDY3LCAgIDY4LCAgIDY3LCAgIDc1 LCAgIDcyLA0KPj4gKyAgICAgICA2NywgICA2OSwgICA3MywgICAzNiwgICAzNiwgICA3NCwgICA3 OCwgICA3OSwgICAzNiwgICA1MywNCj4+ICsgICAgICAgMzYsICAgMzYsICAgMzYsICAgODcsICAg MzYsICAgNzYsICAgODQsICAgMzYsICAgMzYsICAgODUsDQo+PiArICAgICAgIDM2LCAgIDgxLCAg IDM2LCAgIDg2LCAgIDM2LCAgIDM2LCAgIDM2LCAgIDM2LCAgIDgyLCAgIDM2LA0KPj4gKyAgICAg ICA5MiwgICA5NSwgICAzNiwgIDEwMCwgICAzNiwgICAzNiwgICA4OSwgICA5MCwgICA4OCwgICAy OSwNCj4+ICsgICAgICAgNjUsICAgMzYsICAgOTEsICAxMDEsICAgMzYsICAgNjYsICAgOTAsICAg OTMsICAgMzYsICAgOTQsDQo+PiArICAgICAgIDI5LCAgIDk3LCAgMTAyLCAgIDM2LCAgIDM2LCAg MTA0LCAgIDk4LCAgIDM2LCAgMTAzLCAgIDM2LA0KPj4gKyAgICAgICAzNiwgIDEwNywgIDEwOCwg IDEwNiwgICAzNiwgICAzNiwgICAzNiwgIDEwNSwgICA4NiwgICAzNiwNCj4+ICsgICAgICAxMDks ICAxMTAsICAxMTEsICAgMzYsICAgMzYsICAxMTQsICAxMTIsICAgMzYsICAxMTcsICAxMTksDQo+ PiArDQo+PiArICAgICAgIDM2LCAgIDM2LCAgIDM2LCAgIDM2LCAgIDM2LCAgMTIxLCAgIDM2LCAg MzY4LCAgIDM2LCAgIDM2LA0KPj4gKyAgICAgIDEyMCwgIDExMywgICAyOSwgICAyOSwgICAyOSwg ICAzMCwgIDExOCwgICAzNiwgIDEzNCwgICAyOSwNCj4+ICsgICAgICAgMzgsICAgMzYsICAxMjcs ICAxMTUsICAxMTYsICAxMjIsICAxMjMsICAxMjUsICAgMzYsICAxMjYsDQo+PiArICAgICAgMTI4 LCAgMTI0LCAgIDI5LCAgIDk3LCAgIDM2LCAgIDM2LCAgMTgwLCAgMTM4LCAgIDk4LCAgMTI5LA0K Pj4gKyAgICAgIDEyOSwgICA2NywgIDEzMCwgIDEyOSwgICAzNiwgICAzNiwgIDEyOSwgIDEzMiwg IDEzMywgIDEzNSwNCj4+ICsgICAgICAxMzYsICAxNDAsICAgMzYsICAgMzYsICAgMzYsICAgMzYs ICAxNDIsICAgMzYsICAxMzcsICAgMzUsDQo+PiArICAgICAgIDM1LCAgMTIzLCAgIDg2LCAgIDM2 LCAgMzcwLCAgMTQzLCAgMTQ0LCAgMTQ0LCAgIDY3LCAgMTQ1LA0KPj4gKyAgICAgIDE0NCwgIDE0 OCwgIDE1OCwgIDE0NCwgIDE0NywgICAzNSwgICAzNSwgICA5MCwgIDExOSwgICAzNiwNCj4+ICsg ICAgICAgMzYsICAxNDksICAxNTAsICAxNTAsICAgNjcsICAxNTEsICAxNTAsICAxNTksICAgMzYs ICAxNTAsDQo+PiArICAgICAgMTUzLCAgMTU0LCAgMTU0LCAgIDY3LCAgMTU1LCAgMTU0LCAgMTY0 LCAgIDM2LCAgMTU0LCAgMTU3LA0KPj4gKw0KPj4gKyAgICAgIDE2MCwgIDE2MCwgICA2NywgIDE2 MSwgIDE2MCwgICAzNiwgIDM2OCwgIDE2MCwgIDE2MywgIDE2NSwNCj4+ICsgICAgICAxNjYsICAg MzYsICAgMzYsICAgMjksICAxNzAsICAxNjcsICAxNjgsICAgMjksICAxNzIsICAxNzEsDQo+PiAr ICAgICAgIDM2LCAgMTc1LCAgIDM2LCAgMTczLCAgIDM1LCAgIDM1LCAgMTc2LCAgIDM2LCAgIDM2 LCAgMTc3LA0KPj4gKyAgICAgICAzNiwgICAzNiwgIDE4OCwgIDE3NCwgICAzNiwgICAyOSwgIDE5 MCwgIDE3OCwgICAzNiwgIDE4MSwNCj4+ICsgICAgICAgMzYsICAxOTEsICAyMjMsICAxNzksICAx ODIsICAxODIsICAgNjcsICAxODMsICAxODIsICAxODYsDQo+PiArICAgICAgMjA2LCAgMTgyLCAg MTg1LCAgMTg3LCAgIDI5LCAgMTkyLCAgIDM1LCAgIDM1LCAgIDM1LCAgIDM1LA0KPj4gKyAgICAg IDE5MywgICAyOSwgIDE5NywgICAyOSwgIDE5OSwgIDE5NCwgICAzNiwgIDE5OCwgICAzNiwgIDIw MCwNCj4+ICsgICAgICAgMjksICAyMDIsICAgMjksICAyMDQsICAxOTUsICAgMzYsICAyMDMsICAg MzYsICAyMDUsICAyNjgsDQo+PiArICAgICAgMjA3LCAgIDI5LCAgMjA5LCAgIDI5LCAgMjExLCAg MjE0LCAgMjEzLCAgMjEwLCAgMjE4LCAgMjEyLA0KPj4gKyAgICAgIDIxNywgICAzNiwgIDM1Mywg ICAzNiwgICAyOSwgIDE3MCwgICAzNiwgICAzNSwgICAzNSwgIDIxOSwNCj4+ICsNCj4+ICsgICAg ICAxNzEsICAgMzUsICAgMzUsICAgMzUsICAgMzUsICAyMjQsICAgMzYsICAyMzEsICAgMzYsICAy MjUsDQo+PiArICAgICAgIDM2LCAgIDI5LCAgMjI3LCAgMjIxLCAgIDM2LCAgMjIyLCAgMjMyLCAg MjI4LCAgMjIwLCAgIDI5LA0KPj4gKyAgICAgIDIyOSwgICAzNiwgIDI0MCwgICAzNSwgICAzNSwg IDIzMCwgIDIzMywgIDIzMywgICA2NywgIDIzNCwNCj4+ICsgICAgICAyMzMsICAgMjksICAxOTAs ICAyMzMsICAyMzYsICAyMzcsICAzNDgsICAxOTEsICAyMzgsICAgMzUsDQo+PiArICAgICAgIDI5 LCAgMTk3LCAgIDI5LCAgMjAyLCAgMjM5LCAgIDM2LCAgMTk4LCAgIDM2LCAgMjAzLCAgIDI5LA0K Pj4gKyAgICAgIDIwOSwgIDI0MiwgICAzNiwgICAzNSwgIDI0NywgIDIxMCwgIDI1NSwgIDI0MSwg IDI0OCwgICAzNiwNCj4+ICsgICAgICAgMzUsICAgMzUsICAgMzYsICAgMzUsICAgMzUsICAgMzUs ICAgMzUsICAyNTMsICAgMzYsICAgMzUsDQo+PiArICAgICAgIDM1LCAgIDI5LCAgMjI3LCAgMjUw LCAgMjY5LCAgMjU0LCAgIDM2LCAgMjI4LCAgMjQ5LCAgMjUxLA0KPj4gKyAgICAgIDI1MiwgICAz NSwgIDI1OCwgICAyOSwgIDI2MCwgICAyOSwgIDI2MiwgIDI2NCwgICAzNiwgIDI2MSwNCj4+ICsg ICAgICAyNjUsICAyNjMsICAgMzUsICAgMzUsICAzNDYsICAgMzUsICAgMzUsICAgNzAsICAyNzEs ICAgMzUsDQo+PiArDQo+PiArICAgICAgIDM1LCAgIDM1LCAgIDM1LCAgIDM1LCAgIDM1LCAgMjc0 LCAgIDM1LCAgIDM1LCAgMjgyLCAgIDM1LA0KPj4gKyAgICAgICAzNSwgICAzNiwgIDI3NywgIDI3 OCwgICAzNSwgICAzNSwgIDI4MywgIDI4NCwgICAzNSwgICAzNSwNCj4+ICsgICAgICAyNzksICAy ODUsICAgMzYsICAyODAsICAyODgsICAgMjksICAyNjAsICAgMzUsICAgMzUsICAyODksDQo+PiAr ICAgICAgMzEyLCAgMjYxLCAgMjkzLCAgMjkzLCAgIDY3LCAgMjk0LCAgMjkzLCAgMzAxLCAgMzA2 LCAgMjkzLA0KPj4gKyAgICAgIDI5NiwgICAzNSwgICAzNSwgIDI5OCwgIDMwMywgIDMwNiwgIDMw NCwgICAzNSwgICAzNSwgICAzNSwNCj4+ICsgICAgICAgMzUsICAzMDksICAzMDgsICAgMzYsICAz MDcsICAyODIsICAzMDIsICAzMTksICAgMzUsICAgMzUsDQo+PiArICAgICAgIDM1LCAgIDM1LCAg IDM1LCAgMzExLCAgIDI5LCAgMzE0LCAgIDI5LCAgMzE2LCAgIDM1LCAgIDM1LA0KPj4gKyAgICAg IDMxNSwgIDI4MiwgIDMxNywgICAzNSwgICAzNSwgIDM0NCwgIDMxMCwgIDM2NCwgIDMyNSwgICAz NSwNCj4+ICsgICAgICAgMzUsICAzMTgsICAgMzUsICAgMzUsICAzMjksICAzMjAsICAgMzYsICAz MjgsICAzMzIsICAgMzYsDQo+PiArICAgICAgIDI5LCAgMzE0LCAgIDM1LCAgIDM1LCAgMzMwLCAg MzI2LCAgMzE1LCAgMzMxLCAgMzI3LCAgMzMzLA0KPj4gKw0KPj4gKyAgICAgICAzNSwgICAzNSwg ICAzNSwgICAzNSwgIDI4MiwgIDI4MiwgIDM0MCwgIDM0MSwgICAzNSwgICAzNSwNCj4+ICsgICAg ICAgMzUsICAgMzUsICAgMzYsICAyODIsICAgMzUsICAgMzUsICAgMzYsICAzNTEsICAgMzUsICAg MzUsDQo+PiArICAgICAgMzYyLCAgMzM5LCAgMzY1LCAgIDM2LCAgMzM4LCAgMzY2LCAgMzQyLCAg MzYxLCAgMzYwLCAgMzU0LA0KPj4gKyAgICAgIDM1OCwgIDM0OSwgIDM1NiwgICAzNSwgICAzNSwg ICAyNywgICAyNywgICAyNywgICAyNywgICAyOSwNCj4+ICsgICAgICAgMjksICAgMjksICAgMzEs ICAgMzEsICAgMzEsICAgMzEsICAgMzYsICAgMzYsICAgMzYsICAgMzYsDQo+PiArICAgICAgIDYz LCAgMzUzLCAgIDYzLCAgIDYzLCAgIDY0LCAgIDY0LCAgIDY0LCAgIDY0LCAgIDY2LCAgMzUwLA0K Pj4gKyAgICAgICA2NiwgICA2NiwgICAzNSwgICAzNSwgICAzNSwgICAzNSwgICA3MCwgICA3MCwg IDMyNCwgICA3MCwNCj4+ICsgICAgICAgOTYsICAgOTYsICAgOTYsICAgOTYsICAgOTgsICAzMjIs ICAgOTgsICAgOTgsICAxMzEsICAxMzEsDQo+PiArICAgICAgMTMxLCAgMTMxLCAgMTQ2LCAgMTQ2 LCAgMTQ2LCAgMTQ2LCAgMTUyLCAgMTUyLCAgMTUyLCAgMTUyLA0KPj4gKyAgICAgIDE1NiwgIDE1 NiwgIDE1NiwgIDE1NiwgIDE2MiwgIDE2MiwgIDE2MiwgIDE2MiwgIDE2OSwgIDE2OSwNCj4+ICsN Cj4+ICsgICAgICAxNjksICAxNjksICAxNzEsICAzNDgsICAxNzEsICAxNzEsICAxODQsICAxODQs ICAxODQsICAxODQsDQo+PiArICAgICAgMTg5LCAgMTg5LCAgMTg5LCAgMTg5LCAgMTkxLCAgMzQ2 LCAgMTkxLCAgMTkxLCAgMTk2LCAgMTk2LA0KPj4gKyAgICAgIDE5NiwgIDE5NiwgIDE5OCwgIDM0 NCwgIDE5OCwgIDE5OCwgIDIwMSwgIDIwMSwgIDIwMSwgIDIwMSwNCj4+ICsgICAgICAyMDMsICAz MzcsICAyMDMsICAyMDMsICAyMDgsICAyMDgsICAyMDgsICAyMDgsICAyMTAsICAzMzUsDQo+PiAr ICAgICAgMjEwLCAgMjEwLCAgMjE1LCAgMjE1LCAgMjE1LCAgMjE1LCAgMTczLCAgMjgyLCAgMTcz LCAgMTczLA0KPj4gKyAgICAgIDIyNiwgIDIyNiwgIDIyNiwgIDIyNiwgIDIyOCwgIDMyNCwgIDIy OCwgIDIyOCwgIDIzNSwgIDIzNSwNCj4+ICsgICAgICAyMzUsICAyMzUsICAxOTMsICAzMjIsICAx OTMsICAxOTMsICAyMDAsICAyNzYsICAyMDAsICAyMDAsDQo+PiArICAgICAgMjA1LCAgMjY3LCAg MjA1LCAgMjA1LCAgMjEyLCAgMjU3LCAgMjEyLCAgMjEyLCAgMjQzLCAgMjQzLA0KPj4gKyAgICAg IDI0MywgIDI0MywgIDI0NSwgIDI0NSwgIDI0NSwgIDI0NSwgIDIzMCwgIDMwNiwgIDIzMCwgIDIz MCwNCj4+ICsgICAgICAyNTYsICAyNTYsICAyNTYsICAyNTYsICAyNTksICAyNTksICAyNTksICAy NTksICAyNjEsICAzMDAsDQo+PiArDQo+PiArICAgICAgMjYxLCAgMjYxLCAgMjY2LCAgMjY2LCAg MjY2LCAgMjY2LCAgMjcwLCAgMjcwLCAgMjcwLCAgMjcwLA0KPj4gKyAgICAgIDI3MiwgIDI3Miwg IDI3MiwgIDI3MiwgIDI3NSwgIDI3NSwgIDI3NSwgIDI3NSwgIDI4MSwgIDI4MSwNCj4+ICsgICAg ICAyODEsICAyODEsICAyODYsICAyODYsICAyODYsICAyODYsICAyNjMsICAyNDYsICAyNjMsICAy NjMsDQo+PiArICAgICAgMjkwLCAgMjkwLCAgMjkwLCAgMjkwLCAgMjk1LCAgMjk1LCAgMjk1LCAg Mjk1LCAgMjcxLCAgMjk3LA0KPj4gKyAgICAgIDI3MSwgIDI3MSwgIDI5OSwgIDI5OSwgIDI5OSwg IDI5OSwgIDMwNSwgIDMwNSwgIDMwNSwgIDMwNSwNCj4+ICsgICAgICAzMTMsICAzMTMsICAzMTMs ICAzMTMsICAzMTUsICAyOTIsICAzMTUsICAzMTUsICAzMjEsICAzMjEsDQo+PiArICAgICAgMzIx LCAgMzIxLCAgMzIzLCAgMzIzLCAgMzIzLCAgMzIzLCAgMzE3LCAgMjkxLCAgMzE3LCAgMzE3LA0K Pj4gKyAgICAgIDMzNCwgIDMzNCwgIDMzNCwgIDMzNCwgIDMzNiwgIDMzNiwgIDMzNiwgIDMzNiwg IDM0MywgIDM0MywNCj4+ICsgICAgICAzNDMsICAzNDMsICAzNDUsICAzNDUsICAzNDUsICAzNDUs ICAzNDcsICAzNDcsICAzNDcsICAzNDcsDQo+PiArICAgICAgMzUyLCAgMzUyLCAgMzUyLCAgMzUy LCAgMzU1LCAgMzU1LCAgMzU1LCAgMzU1LCAgMzU3LCAgMzU3LA0KPj4gKw0KPj4gKyAgICAgIDM1 NywgIDM1NywgIDM1OSwgIDM1OSwgIDM1OSwgIDM1OSwgIDM2MywgIDM2MywgIDM2MywgIDM2MywN Cj4+ICsgICAgICAzNjcsICAzNjcsICAzNjcsICAzNjcsICAzNjksICAzNjksICAzNjksICAzNjks ICAyODcsICAyNzYsDQo+PiArICAgICAgMjczLCAgMjE2LCAgMjY3LCAgMjU3LCAgMjQ2LCAgMjQ0 LCAgMjE2LCAgMTQxLCAgMTM5LCAgIDk5LA0KPj4gKyAgICAgICAzNiwgICAzMCwgICA2MCwgICA1 NywgICAzNiwgICAzMCwgIDM3MSwgICAyOCwgICAyOCwgICAgNSwNCj4+ICsgICAgICAzNzEsICAz NzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsDQo+PiAr ICAgICAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcx LCAgMzcxLA0KPj4gKyAgICAgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3 MSwgIDM3MSwgIDM3MSwgIDM3MSwNCj4+ICsgICAgICAzNzEsICAzNzEsICAzNzEsICAzNzENCj4+ ICAgICAgIH0gOw0KPj4NCj4+IC1zdGF0aWMgY29uc3QgZmxleF9pbnQxNl90IHl5X2Noa1s5NDBd ID0NCj4+ICtzdGF0aWMgY29uc3QgZmxleF9pbnQxNl90IHl5X2Noa1s5NzVdID0NCj4+ICAgICAg IHsgICAwLA0KPj4gICAgICAgICAgIDEsICAgIDEsICAgIDEsICAgIDEsICAgIDEsICAgIDEsICAg IDEsICAgIDEsICAgIDEsICAgIDEsDQo+PiAgICAgICAgICAgMSwgICAgMSwgICAgMSwgICAgMSwg ICAgMSwgICAgMSwgICAgMSwgICAgMSwgICAgMSwgICAgMSwNCj4+IEBAIC05MjcsMTAxICs5NDAs MTA1IEBAIHN0YXRpYyBjb25zdCBmbGV4X2ludDE2X3QgeXlfY2hrWzk0MF0gPQ0KPj4gICAgICAg ICAgMTgsICAgMTQsICAgMTEsICAgMTEsICAgMTMsICAgMTQsICAgMTEsICAgNDYsICAgNDYsICAg MTQsDQo+PiAgICAgICAgICAxNSwgICAxNiwgICAxMSwgICAxMiwgICAxMiwgICAxMiwgICAxMiwg ICAxMiwgICAxNCwgICAxNiwNCj4+ICAgICAgICAgIDEyLCAgIDEyLCAgIDEyLCAgIDE1LCAgIDE5 LCAgIDE2LCAgIDIwLCAgIDIwLCAgIDIxLCAgIDIyLA0KPj4gLSAgICAgICAyNCwgICAyMiwgICAy NCwgICA1MCwgICAyNiwgICAyMSwgICA1MCwgICAyNiwgICAxOSwgIDM1MSwNCj4+IC0gICAgICAg MjAsICAgMjYsICAgMTksICAgMzEsICAgMzEsICAgMzIsICAgMzIsICAgMzIsICAgMzksICAgMzEs DQo+PiAtDQo+PiAtICAgICAgIDM5LCAgIDQyLCAgIDMyLCAgIDM1LCAgIDM1LCAgIDM1LCAgIDM1 LCAgIDQwLCAgIDQ0LCAgIDQ1LA0KPj4gLSAgICAgICAzNSwgICAzNSwgICAzNywgICAzNywgICAz NywgICAzNywgICAzNywgICAzOSwgICA0MiwgICAzNywNCj4+IC0gICAgICAgMzcsICAgNDAsICAg NDEsICAgNDMsICAgNDEsICAgNDgsICAgNDUsICAgNDUsICAgNDksICAgNDQsDQo+PiAtICAgICAg IDQ3LCAgIDQ3LCAgIDUzLCAgIDUxLCAgIDQzLCAgIDUzLCAgIDQ4LCAgIDUxLCAgIDUyLCAgIDU0 LA0KPj4gLSAgICAgICA1MiwgICA1NSwgICA1NiwgICA1OCwgICA1NCwgICA0OSwgICA1NywgICA1 OSwgICA2MCwgICA3MywNCj4+IC0gICAgICAgNjEsICAgNzAsICAgNjAsICAgNjEsICAzNDcsICAg NzAsICAgNTYsICAgNjMsICAgNjMsICAgNzMsDQo+PiAtICAgICAgIDU4LCAgIDcxLCAgIDU5LCAg IDYzLCAgIDU5LCAgIDU1LCAgIDY2LCAgIDY2LCAgIDU3LCAgIDcxLA0KPj4gLSAgICAgICA3NCwg ICA3MiwgICA2NiwgICA3MiwgICA3NSwgICA3NiwgICA3NywgICA3OCwgICA3OSwgICA3OCwNCj4+ IC0gICAgICAgNzcsICAgNzksICAgODAsICAgODEsICAgNzQsICAgODMsICAgODAsICAgODIsICAg NzUsICAgODQsDQo+PiAtICAgICAgIDgyLCAgIDg1LCAgIDg4LCAgIDg1LCAgIDc2LCAgIDgxLCAg IDg3LCAgIDgzLCAgIDg3LCAgIDg5LA0KPj4gLQ0KPj4gLSAgICAgICA5MiwgICA4OSwgICA5Mywg IDM0NSwgICA5MCwgIDEwNCwgICA5MiwgICA4NCwgICA4NiwgICA4NiwNCj4+IC0gICAgICAgODYs ICAgODYsICAgOTAsICAgOTksICAgODgsICAgODYsICAgODYsICAgOTgsICAxMDIsICAgODYsDQo+ PiAtICAgICAgIDg2LCAgIDkxLCAgIDkxLCAgIDkzLCAgIDkxLCAgIDk0LCAgIDk0LCAgIDkxLCAg MTAxLCAgMTA0LA0KPj4gLSAgICAgIDEwMiwgICA5NCwgIDEwMSwgIDExMCwgICA5OSwgICA5OCwg IDEwMCwgIDEwMCwgIDEwMCwgIDEwMCwNCj4+IC0gICAgICAxMDAsICAxMDMsICAxMDMsICAxMDAs ICAxMDAsICAzNDMsICAxMDUsICAxMDMsICAxMDUsICAxMDcsDQo+PiAtICAgICAgMTA5LCAgMTA3 LCAgMTExLCAgMTEwLCAgMTA5LCAgMTEzLCAgMTEzLCAgMzQxLCAgMTIxLCAgMTE4LA0KPj4gLSAg ICAgIDExMSwgIDExMiwgIDExMiwgIDExMiwgIDExMiwgIDExMiwgIDEyMSwgIDExMywgIDExMiwg IDExMiwNCj4+IC0gICAgICAxMTQsICAxMTQsICAxMTYsICAxMTYsICAxMTgsICAxMTYsICAxMTQs ICAxMTUsICAxMTUsICAxMTUsDQo+PiAtICAgICAgMTE1LCAgMTE1LCAgMTIzLCAgMTIzLCAgMTE1 LCAgMTE1LCAgMTE3LCAgMTE3LCAgMTE3LCAgMTE3LA0KPj4gLSAgICAgIDExNywgIDEyNCwgIDEy MiwgIDExNywgIDExNywgIDExOSwgIDEyMiwgIDExOSwgIDEyMCwgIDEyMCwNCj4+IC0NCj4+IC0g ICAgICAxMjAsICAxMjAsICAxMjAsICAxMjUsICAxMzAsICAxMjAsICAxMjAsICAxMjUsICAxMzEs ICAxMjQsDQo+PiAtICAgICAgMTI2LCAgMTI2LCAgMTI4LCAgMTI4LCAgMTMxLCAgMTM0LCAgMTI2 LCAgMTMwLCAgMTI4LCAgMTMzLA0KPj4gLSAgICAgIDEzMywgIDEzMywgIDEzNSwgIDEzNiwgIDEz MywgIDEzOSwgIDE2NCwgIDE0MCwgIDEzOCwgIDE0MCwNCj4+IC0gICAgICAxMzQsICAxNjQsICAx MzMsICAxNDEsICAxNDEsICAxNjMsICAxNjMsICAzMzgsICAxMzksICAxNDEsDQo+PiAtICAgICAg MTM2LCAgMTM1LCAgMTM3LCAgMTM3LCAgMTM3LCAgMTM3LCAgMTM3LCAgMTM4LCAgMzM2LCAgMTM3 LA0KPj4gLSAgICAgIDEzNywgIDE0MywgIDE0MywgIDE0NSwgIDE0NSwgIDE0NiwgIDE0NiwgIDE0 MywgIDE0NywgIDE0NywNCj4+IC0gICAgICAxNDksICAxNDksICAxNDUsICAxNTUsICAxNDcsICAx NjEsICAxNDksICAxNTEsICAxNTEsICAxNTMsDQo+PiAtICAgICAgMTUzLCAgMTQ2LCAgMTYwLCAg MTUxLCAgMjcwLCAgMTUzLCAgMTc2LCAgMTU2LCAgMTU2LCAgMTU4LA0KPj4gLSAgICAgIDE1OCwg IDE3NiwgIDE1NSwgIDE1NiwgIDE2MSwgIDE1OCwgIDE2NSwgIDE2NSwgIDE3MCwgIDI3MCwNCj4+ IC0gICAgICAxNjAsICAxNzAsICAxNjUsICAxNzIsICAxNzIsICAxNzMsICAxNzMsICAxNzQsICAx NzQsICAxNzUsDQo+PiAtDQo+PiAtICAgICAgMjA4LCAgMTc3LCAgMjIwLCAgMTc1LCAgMTc3LCAg MTc4LCAgMTc4LCAgMTczLCAgMjIwLCAgMTc0LA0KPj4gLSAgICAgIDIwOCwgIDE3OCwgIDE4MCwg IDE4MCwgIDE3MiwgIDE4MiwgIDE4MiwgIDE4MywgIDE4MCwgIDMzNCwNCj4+IC0gICAgICAxOTAs ICAxOTAsICAxODMsICAxODQsICAxODQsICAxODQsICAxODQsICAxODQsICAxODUsICAxODUsDQo+ PiAtICAgICAgMTg0LCAgMTg0LCAgMTkwLCAgMjQzLCAgMTg1LCAgMTkxLCAgMTkxLCAgMTkyLCAg MTkyLCAgMTk3LA0KPj4gLSAgICAgIDE5NywgIDIwMiwgIDIwMiwgIDE5MiwgIDMzMiwgIDE5Nywg IDIwMywgIDIwMywgIDIwOSwgIDIwOSwNCj4+IC0gICAgICAyMTMsICAyMTMsICAyMDMsICAyMTQs ICAyMTQsICAyMTUsICAyMTUsICAyNDMsICAyMTYsICAyMTYsDQo+PiAtICAgICAgMjE3LCAgMjE3 LCAgMjE4LCAgMjE4LCAgMjE5LCAgMjE5LCAgMjIxLCAgMjIxLCAgMjE1LCAgMjM1LA0KPj4gLSAg ICAgIDIxOSwgIDIzNSwgIDIyMSwgIDIxNCwgIDIxNiwgIDIxNywgIDIyNywgIDIyNywgIDIyOCwg IDIyOCwNCj4+IC0gICAgICAyMzAsICAyMzAsICAyMzIsICAzMzEsICAyMjgsICAyMzMsICAyMzAs ICAyMzMsICAyMzMsICAzMjksDQo+PiAtICAgICAgMjMyLCAgMjMyLCAgMjM2LCAgMjM2LCAgMjQx LCAgMjQxLCAgMjQ0LCAgMjQ0LCAgMjQ1LCAgMjQ1LA0KPj4gLQ0KPj4gLSAgICAgIDI0MSwgIDI0 NiwgIDI0NiwgIDI0NywgIDI0OCwgIDI0OCwgIDI2NywgIDI2NywgIDI0NCwgIDI1OSwNCj4+IC0g ICAgICAyNTksICAyNDcsICAyNDcsICAyNTIsICAyNTIsICAyNDUsICAyNDgsICAzMjYsICAyNDYs ICAyNTIsDQo+PiAtICAgICAgMjUzLCAgMjUzLCAgMjY3LCAgMzI0LCAgMjU5LCAgMzE2LCAgMjUz LCAgMjYyLCAgMjYyLCAgMjYyLA0KPj4gLSAgICAgIDI2MiwgIDI2MiwgIDI3MSwgIDI3MSwgIDI2 MiwgIDI2MiwgIDI3MiwgIDI3NiwgIDI3MywgIDI3MiwNCj4+IC0gICAgICAyNzIsICAyNzMsICAy NzMsICAyNzcsICAyNzgsICAzMTYsICAyNzYsICAyNzEsICAyODEsICAyODEsDQo+PiAtICAgICAg Mjk5LCAgMjc4LCAgMjc4LCAgMjgyLCAgMjgyLCAgMjg1LCAgMjg1LCAgMjc3LCAgMzAwLCAgMjg3 LA0KPj4gLSAgICAgIDI4NywgIDI4NSwgIDI5MCwgIDI5MCwgIDI4MSwgIDI4NywgIDMyMywgIDI5 MywgIDI5NCwgIDI5NCwNCj4+IC0gICAgICAyOTAsICAyOTMsICAzMDMsICAyOTksICAzMDEsICAz MDEsICAzMDIsICAzMDIsICAzMTAsICAzMTAsDQo+PiAtICAgICAgMzAzLCAgMzAzLCAgMzAwLCAg MzE3LCAgMzAyLCAgMjk0LCAgMzA0LCAgMzA0LCAgMzIyLCAgMzI4LA0KPj4gLSAgICAgIDMwMSwg IDMwOSwgIDMwNCwgIDMxMSwgIDMwOSwgIDMwOSwgIDMxMSwgIDMxMSwgIDMxOCwgIDMxNywNCj4+ IC0NCj4+IC0gICAgICAzMTgsICAzMTgsICAzMTksICAzMjEsICAzMTQsICAzMTksICAzMTksICAz MjgsICAzMzAsICAzMzAsDQo+PiAtICAgICAgMzUwLCAgMzMwLCAgMzQwLCAgMzQwLCAgMzQwLCAg MzEyLCAgMjk3LCAgMjk2LCAgMzUwLCAgMzUwLA0KPj4gLSAgICAgIDM1NSwgIDM1NSwgIDM1NSwg IDM1NSwgIDM1NiwgIDM1NiwgIDM1NiwgIDM1NywgIDM1NywgIDM1NywNCj4+IC0gICAgICAzNTcs ICAzNTgsICAzNTgsICAzNTgsICAzNTgsICAzNTksICAyOTUsICAzNTksICAzNTksICAzNjAsDQo+ PiAtICAgICAgMzYwLCAgMzYwLCAgMzYwLCAgMzYxLCAgMjkxLCAgMzYxLCAgMzYxLCAgMzYyLCAg MzYyLCAgMzYyLA0KPj4gLSAgICAgIDM2MiwgIDM2MywgIDM2MywgIDI4MywgIDM2MywgIDM2NCwg IDM2NCwgIDM2NCwgIDM2NCwgIDM2NSwNCj4+IC0gICAgICAyNzksICAzNjUsICAzNjUsICAzNjYs ICAzNjYsICAzNjYsICAzNjYsICAzNjcsICAzNjcsICAzNjcsDQo+PiAtICAgICAgMzY3LCAgMzY4 LCAgMzY4LCAgMzY4LCAgMzY4LCAgMzY5LCAgMzY5LCAgMzY5LCAgMzY5LCAgMzcwLA0KPj4gLSAg ICAgIDM3MCwgIDM3MCwgIDM3MCwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MiwgIDI3NCwg IDM3MiwNCj4+IC0gICAgICAzNzIsICAzNzMsICAzNzMsICAzNzMsICAzNzMsICAzNzQsICAzNzQs ICAzNzQsICAzNzQsICAzNzUsDQo+PiAtDQo+PiAtICAgICAgMjY4LCAgMzc1LCAgMzc1LCAgMzc2 LCAgMzc2LCAgMzc2LCAgMzc2LCAgMzc3LCAgMjY1LCAgMzc3LA0KPj4gLSAgICAgIDM3NywgIDM3 OCwgIDM3OCwgIDM3OCwgIDM3OCwgIDM3OSwgIDI2MywgIDM3OSwgIDM3OSwgIDM4MCwNCj4+IC0g ICAgICAzODAsICAzODAsICAzODAsICAzODEsICAyNjAsICAzODEsICAzODEsICAzODIsICAzODIs ICAzODIsDQo+PiAtICAgICAgMzgyLCAgMzgzLCAgMjUwLCAgMzgzLCAgMzgzLCAgMzg0LCAgMzg0 LCAgMzg0LCAgMzg0LCAgMzg1LA0KPj4gLSAgICAgIDI0MiwgIDM4NSwgIDM4NSwgIDM4NiwgIDM4 NiwgIDM4NiwgIDM4NiwgIDM4NywgIDIzOSwgIDM4NywNCj4+IC0gICAgICAzODcsICAzODgsICAy MzcsICAzODgsICAzODgsICAzODksICAyMzQsICAzODksICAzODksICAzOTAsDQo+PiAtICAgICAg MjI2LCAgMzkwLCAgMzkwLCAgMzkxLCAgMzkxLCAgMzkxLCAgMzkxLCAgMzkyLCAgMzkyLCAgMzky LA0KPj4gLSAgICAgIDM5MiwgIDM5MywgIDIxMiwgIDM5MywgIDM5MywgIDM5NCwgIDM5NCwgIDM5 NCwgIDM5NCwgIDM5NSwNCj4+IC0gICAgICAzOTUsICAzOTUsICAzOTUsICAzOTYsICAyMTAsICAz OTYsICAzOTYsICAzOTcsICAzOTcsICAzOTcsDQo+PiAtICAgICAgMzk3LCAgMzk4LCAgMzk4LCAg Mzk4LCAgMzk4LCAgMzk5LCAgMzk5LCAgMzk5LCAgMzk5LCAgNDAwLA0KPj4gLQ0KPj4gLSAgICAg IDQwMCwgIDQwMCwgIDQwMCwgIDQwMSwgIDQwMSwgIDQwMSwgIDQwMSwgIDQwMiwgIDQwMiwgIDQw MiwNCj4+IC0gICAgICA0MDIsICA0MDMsICAxNjIsICA0MDMsICA0MDMsICA0MDQsICA0MDQsICA0 MDQsICA0MDQsICA0MDUsDQo+PiAtICAgICAgNDA1LCAgNDA1LCAgNDA1LCAgNDA2LCAgMTA4LCAg NDA2LCAgNDA2LCAgNDA3LCAgNDA3LCAgNDA3LA0KPj4gLSAgICAgIDQwNywgIDQwOCwgIDQwOCwg IDQwOCwgIDQwOCwgIDQwOSwgIDQwOSwgIDQwOSwgIDQwOSwgIDQxMCwNCj4+IC0gICAgICAxMDYs ICA0MTAsICA0MTAsICA0MTEsICA0MTEsICA0MTEsICA0MTEsICA0MTIsICA0MTIsICA0MTIsDQo+ PiAtICAgICAgNDEyLCAgNDEzLCAgIDY5LCAgNDEzLCAgNDEzLCAgNDE0LCAgNDE0LCAgNDE0LCAg NDE0LCAgNDE1LA0KPj4gLSAgICAgIDQxNSwgIDQxNSwgIDQxNSwgIDQxNiwgIDQxNiwgIDQxNiwg IDQxNiwgIDQxNywgIDQxNywgIDQxNywNCj4+IC0gICAgICA0MTcsICA0MTgsICA0MTgsICA0MTgs ICA0MTgsICA0MTksICA0MTksICA0MTksICA0MTksICA0MjAsDQo+PiAtICAgICAgNDIwLCAgNDIw LCAgNDIwLCAgNDIxLCAgNDIxLCAgNDIxLCAgNDIxLCAgNDIyLCAgNDIyLCAgNDIyLA0KPj4gLSAg ICAgIDQyMiwgIDQyMywgIDQyMywgIDQyMywgIDQyMywgICAzNiwgICAyOSwgICAyNSwgICAyMywg ICAxNywNCj4+IC0NCj4+IC0gICAgICAgIDYsICAgIDUsICAgIDQsICAgIDMsICAzNTQsICAzNTQs ICAzNTQsICAzNTQsICAzNTQsICAzNTQsDQo+PiAtICAgICAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0 LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LCAgMzU0LA0KPj4gLSAgICAgIDM1NCwgIDM1 NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwgIDM1NCwNCj4+IC0g ICAgICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQsICAzNTQN Cj4+ICsgICAgICAgMjQsICAgMjIsICAgMjQsICAgNTAsICAgMjYsICAgMjEsICAgNTAsICAgMjYs ICAgMTksICAgNDQsDQo+PiArICAgICAgIDIwLCAgIDI2LCAgIDE5LCAgIDMxLCAgIDMxLCAgIDI0 LCAgIDMyLCAgIDMyLCAgIDMyLCAgIDMxLA0KPj4gKw0KPj4gKyAgICAgICAzOSwgICA0MiwgICAz OSwgICAzMiwgICAzNSwgICAzNSwgICAzNSwgICAzNSwgICA0MCwgICA0NSwNCj4+ICsgICAgICAg NDQsICAgMzUsICAgMzUsICAgMzcsICAgMzcsICAgMzcsICAgMzcsICAgMzcsICAgNDIsICAgMzks DQo+PiArICAgICAgIDM3LCAgIDM3LCAgIDQwLCAgIDQxLCAgIDQzLCAgIDQxLCAgIDQ1LCAgIDQ1 LCAgIDQ3LCAgIDQ3LA0KPj4gKyAgICAgICA0OCwgICA0OSwgICA1MSwgICA1NCwgICA1NSwgICA0 MywgICA1MSwgICA1MiwgICA1NCwgICA1MiwNCj4+ICsgICAgICAgNTMsICAgNDgsICAgNTYsICAg NTMsICAgNTcsICAgNTgsICAgNTksICAgNjEsICAgNDksICAgNzEsDQo+PiArICAgICAgIDU5LCAg IDYxLCAgIDYwLCAgIDcxLCAgIDYyLCAgIDcyLCAgIDU2LCAgIDYyLCAgIDU1LCAgIDY0LA0KPj4g KyAgICAgICA2NCwgICA3NSwgICA1OCwgICA3MiwgICA3NywgICA2NCwgICA1NywgICA2MCwgICA3 NCwgICA2MCwNCj4+ICsgICAgICAgNjcsICAgNjcsICAgNzMsICAgNzYsICAgNzMsICAgNzUsICAg NjcsICAgNzgsICAgNzQsICAgODIsDQo+PiArICAgICAgIDc5LCAgIDc4LCAgIDc5LCAgIDc3LCAg IDg0LCAgIDgwLCAgIDgxLCAgIDc2LCAgIDgwLCAgIDgzLA0KPj4gKyAgICAgICA4MSwgICA4Miwg ICA4MywgICA4NSwgICA4OSwgICA4NiwgICA4NCwgICA4NiwgICA4OCwgICA5MCwNCj4+ICsNCj4+ ICsgICAgICAgODgsICAgOTAsICAgOTEsICAgOTIsICAxMDAsICAgOTIsICAxMDQsICAzNjksICAg OTUsICAxMDEsDQo+PiArICAgICAgIDkxLCAgIDg1LCAgIDg3LCAgIDg3LCAgIDg3LCAgIDg3LCAg IDg5LCAgMTM4LCAgMTA0LCAgIDg3LA0KPj4gKyAgICAgICA4NywgICA5NCwgIDEwMCwgICA4Nywg ICA4NywgICA5MywgICA5MywgICA5NCwgICA5MywgICA5NSwNCj4+ICsgICAgICAxMDEsICAgOTMs ICAgOTYsICAgOTYsICAxMDYsICAxMDcsICAxMzgsICAxMDcsICAgOTYsICAxMDIsDQo+PiArICAg ICAgMTAyLCAgMTAyLCAgMTAyLCAgMTAyLCAgMTAzLCAgMTEyLCAgMTAyLCAgMTAyLCAgMTAzLCAg MTA1LA0KPj4gKyAgICAgIDEwNSwgIDEwOSwgIDExMSwgIDEwOSwgIDExMywgIDEwNSwgIDExMSwg IDEyMCwgIDEwNiwgIDExNSwNCj4+ICsgICAgICAxMTUsICAxMjIsICAxMTMsICAxMjIsICAzNjcs ICAxMTIsICAxMTQsICAxMTQsICAxMTQsICAxMTQsDQo+PiArICAgICAgMTE0LCAgMTE1LCAgMTIw LCAgMTE0LCAgMTE0LCAgMTE2LCAgMTE2LCAgMTE4LCAgMTE4LCAgMTIxLA0KPj4gKyAgICAgIDEx OCwgIDExNiwgIDExNywgIDExNywgIDExNywgIDExNywgIDExNywgIDEyMSwgIDEyNCwgIDExNywN Cj4+ICsgICAgICAxMTcsICAxMTksICAxMTksICAxMTksICAxMTksICAxMTksICAxMjQsICAxMjcs ICAxMTksICAxMTksDQo+PiArDQo+PiArICAgICAgMTIzLCAgMTIzLCAgMTIzLCAgMTIzLCAgMTIz LCAgMTI1LCAgMzY1LCAgMTIzLCAgMTIzLCAgMTI1LA0KPj4gKyAgICAgIDEyNiwgIDEyNiwgIDEy OCwgIDEyOSwgIDEyOSwgIDEyNywgIDEyOCwgIDEzMSwgIDEzMSwgIDEyOSwNCj4+ICsgICAgICAx MzMsICAxMzQsICAxMzksICAxMzEsICAxMzYsICAxMzYsICAxMzYsICAxMzQsICAxMzcsICAxMzYs DQo+PiArICAgICAgMTQxLCAgMTU4LCAgMTQzLCAgMTMzLCAgMTQzLCAgMTQ0LCAgMTQ0LCAgMTM2 LCAgMTc5LCAgMTM5LA0KPj4gKyAgICAgIDE0MiwgIDE0NCwgIDE3OSwgIDEzNywgIDE0MCwgIDE0 MCwgIDE0MCwgIDE0MCwgIDE0MCwgIDE0MSwNCj4+ICsgICAgICAxNTgsICAxNDAsICAxNDAsICAx NDIsICAxNDYsICAxNDYsICAxNDgsICAxNDgsICAxNDksICAxNDksDQo+PiArICAgICAgMTQ2LCAg MTUwLCAgMTUwLCAgMTUyLCAgMTUyLCAgMTQ4LCAgMTY1LCAgMTUwLCAgMTY0LCAgMTUyLA0KPj4g KyAgICAgIDE1NCwgIDE1NCwgIDE1NiwgIDE1NiwgIDE0OSwgIDE1OSwgIDE1NCwgIDI0MCwgIDE1 NiwgIDI0MCwNCj4+ICsgICAgICAxNTksICAxNjAsICAxNjAsICAxNjIsICAxNjIsICAxNjUsICAx NjQsICAxNjAsICAxNjgsICAxNjIsDQo+PiArICAgICAgMTY3LCAgMTY3LCAgMzYzLCAgMTY4LCAg MTY5LCAgMTY5LCAgMTc0LCAgMTc2LCAgMTc2LCAgMTc0LA0KPj4gKw0KPj4gKyAgICAgIDE2OSwg IDE3NywgIDE3NywgIDE3OCwgIDE3OCwgIDE4MCwgIDE4MSwgIDE4NiwgIDE4NiwgIDE4MSwNCj4+ ICsgICAgICAxODAsICAxODIsICAxODIsICAxNzcsICAyMDcsICAxNzgsICAxODcsICAxODIsICAx NzYsICAxODQsDQo+PiArICAgICAgMTg0LCAgMTg3LCAgMjA3LCAgMTk0LCAgMTk0LCAgMTg0LCAg MTg4LCAgMTg4LCAgMTg4LCAgMTg4LA0KPj4gKyAgICAgIDE4OCwgIDE4OSwgIDE4OSwgIDE4OCwg IDE4OCwgIDE5NCwgIDM1OSwgIDE4OSwgIDE5NSwgIDE5NSwNCj4+ICsgICAgICAxOTYsICAxOTYs ICAyMDEsICAyMDEsICAyMDYsICAyMDYsICAxOTYsICAyMTMsICAyMDEsICAyMDgsDQo+PiArICAg ICAgMjA4LCAgMjE0LCAgMjE0LCAgMjE4LCAgMjE4LCAgMjA4LCAgMjI1LCAgMjEzLCAgMjE5LCAg MjE5LA0KPj4gKyAgICAgIDIyMCwgIDIyMCwgIDIyNSwgIDIyMSwgIDIyMSwgIDIyMiwgIDIyMiwg IDIyMywgIDIyMywgIDIyNCwNCj4+ICsgICAgICAyMjQsICAyMjYsICAyMjYsICAyMjAsICAyNDEs ICAyMjQsICAyNDEsICAyMjYsICAyMTksICAyMjEsDQo+PiArICAgICAgMjIyLCAgMjMyLCAgMjMy LCAgMjMzLCAgMjMzLCAgMjM1LCAgMjM1LCAgMjM3LCAgMjQ5LCAgMjMzLA0KPj4gKyAgICAgIDIz OCwgIDIzNSwgIDIzOCwgIDIzOCwgIDM1NywgIDIzNywgIDIzNywgIDI0MiwgIDI0MiwgIDI0NywN Cj4+ICsNCj4+ICsgICAgICAyNDcsICAyNTAsICAyNTAsICAyNTEsICAyNTEsICAyNDcsICAyNTIs ICAyNTIsICAyNTMsICAyNTQsDQo+PiArICAgICAgMjU0LCAgMjkyLCAgMjQ5LCAgMjUwLCAgMjY1 LCAgMjY1LCAgMjUzLCAgMjUzLCAgMjU4LCAgMjU4LA0KPj4gKyAgICAgIDI1MSwgIDI1NCwgIDI3 NywgIDI1MiwgIDI1OCwgIDI1OSwgIDI1OSwgIDI3NCwgIDI3NCwgIDI2NSwNCj4+ICsgICAgICAy OTIsICAyNTksICAyNjksICAyNjksICAyNjksICAyNjksICAyNjksICAyNzcsICAyODQsICAyNjks DQo+PiArICAgICAgMjY5LCAgMjc4LCAgMjc4LCAgMjc0LCAgMjc5LCAgMjgzLCAgMjgwLCAgMjc5 LCAgMjc5LCAgMjgwLA0KPj4gKyAgICAgIDI4MCwgIDI4NSwgIDI4NCwgIDMwMSwgIDI4MywgIDMw NywgIDI3OCwgIDMwMSwgIDI4NSwgIDI4NSwNCj4+ICsgICAgICAyODgsICAyODgsICAyODksICAy ODksICAyOTMsICAyOTMsICAyOTUsICAyOTUsICAzMDIsICAzMDIsDQo+PiArICAgICAgMjkzLCAg MzA4LCAgMjk1LCAgMjk4LCAgMjk4LCAgMzU1LCAgMjg4LCAgMzUyLCAgMzA3LCAgMzEwLA0KPj4g KyAgICAgIDMxMCwgIDI5OCwgIDMwOSwgIDMwOSwgIDMxMSwgIDMwMiwgIDMxMiwgIDMxMCwgIDMx OSwgIDMxOSwNCj4+ICsgICAgICAzMTMsICAzMTMsICAzMTEsICAzMTEsICAzMTIsICAzMDgsICAz MTMsICAzMTgsICAzMDksICAzMjAsDQo+PiArDQo+PiArICAgICAgMzE4LCAgMzE4LCAgMzIwLCAg MzIwLCAgMzI1LCAgMzI2LCAgMzI3LCAgMzI4LCAgMzI3LCAgMzI3LA0KPj4gKyAgICAgIDMyOCwg IDMyOCwgIDMzMCwgIDMzOCwgIDM0MCwgIDM0MCwgIDM0MiwgIDM0MCwgIDM1MSwgIDM1MSwNCj4+ ICsgICAgICAzNTEsICAzMjYsICAzNTQsICAzNTQsICAzMjUsICAzNjIsICAzMzAsICAzNDksICAz NDcsICAzNDIsDQo+PiArICAgICAgMzQ1LCAgMzM4LCAgMzQzLCAgMzYyLCAgMzYyLCAgMzcyLCAg MzcyLCAgMzcyLCAgMzcyLCAgMzczLA0KPj4gKyAgICAgIDM3MywgIDM3MywgIDM3NCwgIDM3NCwg IDM3NCwgIDM3NCwgIDM3NSwgIDM3NSwgIDM3NSwgIDM3NSwNCj4+ICsgICAgICAzNzYsICAzNDEs ICAzNzYsICAzNzYsICAzNzcsICAzNzcsICAzNzcsICAzNzcsICAzNzgsICAzMzksDQo+PiArICAg ICAgMzc4LCAgMzc4LCAgMzc5LCAgMzc5LCAgMzc5LCAgMzc5LCAgMzgwLCAgMzgwLCAgMzM2LCAg MzgwLA0KPj4gKyAgICAgIDM4MSwgIDM4MSwgIDM4MSwgIDM4MSwgIDM4MiwgIDMzNCwgIDM4Miwg IDM4MiwgIDM4MywgIDM4MywNCj4+ICsgICAgICAzODMsICAzODMsICAzODQsICAzODQsICAzODQs ICAzODQsICAzODUsICAzODUsICAzODUsICAzODUsDQo+PiArICAgICAgMzg2LCAgMzg2LCAgMzg2 LCAgMzg2LCAgMzg3LCAgMzg3LCAgMzg3LCAgMzg3LCAgMzg4LCAgMzg4LA0KPj4gKw0KPj4gKyAg ICAgIDM4OCwgIDM4OCwgIDM4OSwgIDMzMywgIDM4OSwgIDM4OSwgIDM5MCwgIDM5MCwgIDM5MCwg IDM5MCwNCj4+ICsgICAgICAzOTEsICAzOTEsICAzOTEsICAzOTEsICAzOTIsICAzMzIsICAzOTIs ICAzOTIsICAzOTMsICAzOTMsDQo+PiArICAgICAgMzkzLCAgMzkzLCAgMzk0LCAgMzMxLCAgMzk0 LCAgMzk0LCAgMzk1LCAgMzk1LCAgMzk1LCAgMzk1LA0KPj4gKyAgICAgIDM5NiwgIDMyMywgIDM5 NiwgIDM5NiwgIDM5NywgIDM5NywgIDM5NywgIDM5NywgIDM5OCwgIDMyMSwNCj4+ICsgICAgICAz OTgsICAzOTgsICAzOTksICAzOTksICAzOTksICAzOTksICA0MDAsICAzMDUsICA0MDAsICA0MDAs DQo+PiArICAgICAgNDAxLCAgNDAxLCAgNDAxLCAgNDAxLCAgNDAyLCAgMzA0LCAgNDAyLCAgNDAy LCAgNDAzLCAgNDAzLA0KPj4gKyAgICAgIDQwMywgIDQwMywgIDQwNCwgIDMwMywgIDQwNCwgIDQw NCwgIDQwNSwgIDI5OSwgIDQwNSwgIDQwNSwNCj4+ICsgICAgICA0MDYsICAyOTAsICA0MDYsICA0 MDYsICA0MDcsICAyODYsICA0MDcsICA0MDcsICA0MDgsICA0MDgsDQo+PiArICAgICAgNDA4LCAg NDA4LCAgNDA5LCAgNDA5LCAgNDA5LCAgNDA5LCAgNDEwLCAgMjgxLCAgNDEwLCAgNDEwLA0KPj4g KyAgICAgIDQxMSwgIDQxMSwgIDQxMSwgIDQxMSwgIDQxMiwgIDQxMiwgIDQxMiwgIDQxMiwgIDQx MywgIDI3NSwNCj4+ICsNCj4+ICsgICAgICA0MTMsICA0MTMsICA0MTQsICA0MTQsICA0MTQsICA0 MTQsICA0MTUsICA0MTUsICA0MTUsICA0MTUsDQo+PiArICAgICAgNDE2LCAgNDE2LCAgNDE2LCAg NDE2LCAgNDE3LCAgNDE3LCAgNDE3LCAgNDE3LCAgNDE4LCAgNDE4LA0KPj4gKyAgICAgIDQxOCwg IDQxOCwgIDQxOSwgIDQxOSwgIDQxOSwgIDQxOSwgIDQyMCwgIDI3MiwgIDQyMCwgIDQyMCwNCj4+ ICsgICAgICA0MjEsICA0MjEsICA0MjEsICA0MjEsICA0MjIsICA0MjIsICA0MjIsICA0MjIsICA0 MjMsICAyNzAsDQo+PiArICAgICAgNDIzLCAgNDIzLCAgNDI0LCAgNDI0LCAgNDI0LCAgNDI0LCAg NDI1LCAgNDI1LCAgNDI1LCAgNDI1LA0KPj4gKyAgICAgIDQyNiwgIDQyNiwgIDQyNiwgIDQyNiwg IDQyNywgIDI2OCwgIDQyNywgIDQyNywgIDQyOCwgIDQyOCwNCj4+ICsgICAgICA0MjgsICA0Mjgs ICA0MjksICA0MjksICA0MjksICA0MjksICA0MzAsICAyNjYsICA0MzAsICA0MzAsDQo+PiArICAg ICAgNDMxLCAgNDMxLCAgNDMxLCAgNDMxLCAgNDMyLCAgNDMyLCAgNDMyLCAgNDMyLCAgNDMzLCAg NDMzLA0KPj4gKyAgICAgIDQzMywgIDQzMywgIDQzNCwgIDQzNCwgIDQzNCwgIDQzNCwgIDQzNSwg IDQzNSwgIDQzNSwgIDQzNSwNCj4+ICsgICAgICA0MzYsICA0MzYsICA0MzYsICA0MzYsICA0Mzcs ICA0MzcsICA0MzcsICA0MzcsICA0MzgsICA0MzgsDQo+PiArDQo+PiArICAgICAgNDM4LCAgNDM4 LCAgNDM5LCAgNDM5LCAgNDM5LCAgNDM5LCAgNDQwLCAgNDQwLCAgNDQwLCAgNDQwLA0KPj4gKyAg ICAgIDQ0MSwgIDQ0MSwgIDQ0MSwgIDQ0MSwgIDQ0MiwgIDQ0MiwgIDQ0MiwgIDQ0MiwgIDI1Niwg IDI0OCwNCj4+ICsgICAgICAyNDUsICAyNDMsICAyMzksICAyMzEsICAyMTcsICAyMTUsICAxNjYs ICAxMTAsICAxMDgsICAgNzAsDQo+PiArICAgICAgIDM2LCAgIDI5LCAgIDI1LCAgIDIzLCAgIDE3 LCAgICA2LCAgICA1LCAgICA0LCAgICAzLCAgMzcxLA0KPj4gKyAgICAgIDM3MSwgIDM3MSwgIDM3 MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MSwNCj4+ICsgICAgICAz NzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEsICAzNzEs DQo+PiArICAgICAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcxLCAgMzcx LCAgMzcxLCAgMzcxLA0KPj4gKyAgICAgIDM3MSwgIDM3MSwgIDM3MSwgIDM3MQ0KPj4gICAgICAg fSA7DQo+Pg0KPj4gICAjZGVmaW5lIFlZX1RSQUlMSU5HX01BU0sgMHgyMDAwDQo+PiBAQCAtMTE2 MCw5ICsxMTc3LDE3IEBAIHN0YXRpYyB2b2lkIHNldGJhY2tlbmR0eXBlKERpc2tQYXJzZUNvbnRl eHQNCj4+ICpkcGMsIGNvbnN0IGNoYXIgKnN0cikgew0KPj4gICAgICAgaWYgKCAgICAgIXN0cmNt cChzdHIsInBoeSIpKSAgIERTRVQoZHBjLGJhY2tlbmQsQkFDS0VORCxzdHIsUEhZKTsNCj4+ICAg ICAgIGVsc2UgaWYgKCFzdHJjbXAoc3RyLCJ0YXAiKSkgICBEU0VUKGRwYyxiYWNrZW5kLEJBQ0tF TkQsc3RyLFRBUCk7DQo+PiAgICAgICBlbHNlIGlmICghc3RyY21wKHN0ciwicWRpc2siKSkgRFNF VChkcGMsYmFja2VuZCxCQUNLRU5ELHN0cixRRElTSyk7DQo+PiArICAgIGVsc2UgaWYgKCFzdHJj bXAoc3RyLCJzdGFuZGFsb25lIikpDQo+PiBEU0VUKGRwYyxiYWNrZW5kLEJBQ0tFTkQsc3RyLFNU QU5EQUxPTkUpOw0KPj4gICAgICAgZWxzZSB4bHVfX2Rpc2tfZXJyKGRwYyxzdHIsInVua25vd24g dmFsdWUgZm9yIGJhY2tlbmR0eXBlIik7DQo+PiAgIH0NCj4+DQo+PiArLyogU2V0cyAtPnNwZWNp ZmljYXRpb24gZnJvbSB0aGUgc3RyaW5nLiAgSURMIHNob3VsZCBwcm92aWRlIHNvbWV0aGluZyBm b3INCj4+IHRoaXMuICovDQo+PiArc3RhdGljIHZvaWQgc2V0c3BlY2lmaWNhdGlvbihEaXNrUGFy c2VDb250ZXh0ICpkcGMsIGNvbnN0IGNoYXIgKnN0cikgew0KPj4gKyAgICBpZiAgICAgICghc3Ry Y21wKHN0ciwieGVuIikpICAgIERTRVQoZHBjLHNwZWNpZmljYXRpb24sU1BFQ0lGSUNBVElPTixz dHIsWEVOKTsNCj4+ICsgICAgZWxzZSBpZiAoIXN0cmNtcChzdHIsInZpcnRpbyIpKQ0KPj4gRFNF VChkcGMsc3BlY2lmaWNhdGlvbixTUEVDSUZJQ0FUSU9OLHN0cixWSVJUSU8pOw0KPj4gKyAgICBl bHNlIHhsdV9fZGlza19lcnIoZHBjLHN0ciwidW5rbm93biB2YWx1ZSBmb3Igc3BlY2lmaWNhdGlv biIpOw0KPj4gK30NCj4+ICsNCj4+ICAgLyogU2V0cyAtPmNvbG8tcG9ydCBmcm9tIHRoZSBzdHJp bmcuICBDT0xPIG5lZWQgdGhpcy4gKi8NCj4+ICAgc3RhdGljIHZvaWQgc2V0Y29sb3BvcnQoRGlz a1BhcnNlQ29udGV4dCAqZHBjLCBjb25zdCBjaGFyICpzdHIpIHsNCj4+ICAgICAgIGludCBwb3J0 ID0gYXRvaShzdHIpOw0KPj4gQEAgLTExOTksOSArMTIyNCw5IEBAIHN0YXRpYyBpbnQgdmRldl9h bmRfZGV2dHlwZShEaXNrUGFyc2VDb250ZXh0DQo+PiAqZHBjLCBjaGFyICpzdHIpIHsNCj4+ICAg I3VuZGVmIERQQyAvKiBuZWVkcyB0byBiZSBkZWZpbmVkIGRpZmZlcmVudGx5IHRoZSBhY3R1YWwg bGV4ZXIgKi8NCj4+ICAgI2RlZmluZSBEUEMgKChEaXNrUGFyc2VDb250ZXh0Kil5eWV4dHJhKQ0K Pj4NCj4+IC0jbGluZSAxMjAyICJsaWJ4bHVfZGlza19sLmMiDQo+PiArI2xpbmUgMTIyNyAibGli eGx1X2Rpc2tfbC5jIg0KPj4NCj4+IC0jbGluZSAxMjA0ICJsaWJ4bHVfZGlza19sLmMiDQo+PiAr I2xpbmUgMTIyOSAibGlieGx1X2Rpc2tfbC5jIg0KPj4NCj4+ICAgI2RlZmluZSBJTklUSUFMIDAN Cj4+ICAgI2RlZmluZSBMRVhFUlIgMQ0KPj4gQEAgLTE0NzcsMTMgKzE1MDIsMTMgQEAgWVlfREVD TA0KPj4gICAJCX0NCj4+DQo+PiAgIAl7DQo+PiAtI2xpbmUgMTc3ICJsaWJ4bHVfZGlza19sLmwi DQo+PiArI2xpbmUgMTg1ICJsaWJ4bHVfZGlza19sLmwiDQo+Pg0KPj4NCj4+IC0jbGluZSAxODAg ImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAxODggImxpYnhsdV9kaXNrX2wubCINCj4+ICAg IC8qLS0tLS0gdGhlIHNjYW5uZXIgcnVsZXMgd2hpY2ggZG8gdGhlIHBhcnNpbmcgLS0tLS0qLw0K Pj4NCj4+IC0jbGluZSAxNDg2ICJsaWJ4bHVfZGlza19sLmMiDQo+PiArI2xpbmUgMTUxMSAibGli eGx1X2Rpc2tfbC5jIg0KPj4NCj4+ICAgCXdoaWxlICggLypDT05TVENPTkQqLzEgKQkJLyogbG9v cHMgdW50aWwgZW5kLW9mLWZpbGUgaXMNCj4+IHJlYWNoZWQgKi8NCj4+ICAgCQl7DQo+PiBAQCAt MTUxNSwxNCArMTU0MCwxNCBAQCB5eV9tYXRjaDoNCj4+ICAgCQkJd2hpbGUgKCB5eV9jaGtbeXlf YmFzZVt5eV9jdXJyZW50X3N0YXRlXSArIHl5X2NdICE9DQo+PiB5eV9jdXJyZW50X3N0YXRlICkN Cj4+ICAgCQkJCXsNCj4+ICAgCQkJCXl5X2N1cnJlbnRfc3RhdGUgPSAoaW50KQ0KPj4geXlfZGVm W3l5X2N1cnJlbnRfc3RhdGVdOw0KPj4gLQkJCQlpZiAoIHl5X2N1cnJlbnRfc3RhdGUgPj0gMzU1 ICkNCj4+ICsJCQkJaWYgKCB5eV9jdXJyZW50X3N0YXRlID49IDM3MiApDQo+PiAgIAkJCQkJeXlf YyA9IHl5X21ldGFbeXlfY107DQo+PiAgIAkJCQl9DQo+PiAgIAkJCXl5X2N1cnJlbnRfc3RhdGUg PSB5eV9ueHRbeXlfYmFzZVt5eV9jdXJyZW50X3N0YXRlXQ0KPj4gKyB5eV9jXTsNCj4+ICAgCQkJ Knl5Zy0+eXlfc3RhdGVfcHRyKysgPSB5eV9jdXJyZW50X3N0YXRlOw0KPj4gICAJCQkrK3l5X2Nw Ow0KPj4gICAJCQl9DQo+PiAtCQl3aGlsZSAoIHl5X2N1cnJlbnRfc3RhdGUgIT0gMzU0ICk7DQo+ PiArCQl3aGlsZSAoIHl5X2N1cnJlbnRfc3RhdGUgIT0gMzcxICk7DQo+Pg0KPj4gICB5eV9maW5k X2FjdGlvbjoNCj4+ICAgCQl5eV9jdXJyZW50X3N0YXRlID0gKi0teXlnLT55eV9zdGF0ZV9wdHI7 DQo+PiBAQCAtMTU3MiwxNTIgKzE1OTcsMTU4IEBAIGRvX2FjdGlvbjoJLyogVGhpcyBsYWJlbCBp cyB1c2VkIG9ubHkgdG8NCj4+IGFjY2VzcyBFT0YgYWN0aW9ucy4gKi8NCj4+ICAgY2FzZSAxOg0K Pj4gICAvKiBydWxlIDEgY2FuIG1hdGNoIGVvbCAqLw0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAt I2xpbmUgMTgyICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMTkwICJsaWJ4bHVfZGlza19s LmwiDQo+PiAgIHsgLyogaWdub3JlIHdoaXRlc3BhY2UgYmVmb3JlIHBhcmFtZXRlcnMgKi8gfQ0K Pj4gICAJWVlfQlJFQUsNCj4+ICAgLyogb3JkaW5hcnkgcGFyYW1ldGVycyBzZXR0aW5nIGVudW1z IG9yIHN0cmluZ3MgKi8NCj4+ICAgY2FzZSAyOg0KPj4gICAvKiBydWxlIDIgY2FuIG1hdGNoIGVv bCAqLw0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMTg2ICJsaWJ4bHVfZGlza19sLmwi DQo+PiArI2xpbmUgMTk0ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAgIHsgU1RSSVAoJywnKTsgc2V0 Zm9ybWF0KERQQywgRlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIGNhc2UgMzoN Cj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDE4OCAibGlieGx1X2Rpc2tfbC5sIg0KPj4g KyNsaW5lIDE5NiAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+ZGlzay0+aXNfY2Ryb20g PSAxOyB9DQo+PiAgIAlZWV9CUkVBSw0KPj4gICBjYXNlIDQ6DQo+PiAgIFlZX1JVTEVfU0VUVVAN Cj4+IC0jbGluZSAxODkgImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAxOTcgImxpYnhsdV9k aXNrX2wubCINCj4+ICAgeyBEUEMtPmRpc2stPmlzX2Nkcm9tID0gMTsgfQ0KPj4gICAJWVlfQlJF QUsNCj4+ICAgY2FzZSA1Og0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMTkwICJsaWJ4 bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMTk4ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAgIHsgRFBD LT5kaXNrLT5pc19jZHJvbSA9IDA7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIGNhc2UgNjoNCj4+ ICAgLyogcnVsZSA2IGNhbiBtYXRjaCBlb2wgKi8NCj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNs aW5lIDE5MSAibGlieGx1X2Rpc2tfbC5sIg0KPj4gKyNsaW5lIDE5OSAibGlieGx1X2Rpc2tfbC5s Ig0KPj4gICB7IHhsdV9fZGlza19lcnIoRFBDLHl5dGV4dCwidW5rbm93biB2YWx1ZSBmb3IgdHlw ZSIpOyB9DQo+PiAgIAlZWV9CUkVBSw0KPj4gICBjYXNlIDc6DQo+PiAgIC8qIHJ1bGUgNyBjYW4g bWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGluZSAxOTMgImxpYnhsdV9k aXNrX2wubCINCj4+ICsjbGluZSAyMDEgImxpYnhsdV9kaXNrX2wubCINCj4+ICAgeyBTVFJJUCgn LCcpOyBzZXRhY2Nlc3MoRFBDLCBGUk9NRVFVQUxTKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAg Y2FzZSA4Og0KPj4gICAvKiBydWxlIDggY2FuIG1hdGNoIGVvbCAqLw0KPj4gICBZWV9SVUxFX1NF VFVQDQo+PiAtI2xpbmUgMTk0ICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMjAyICJsaWJ4 bHVfZGlza19sLmwiDQo+PiAgIHsgU1RSSVAoJywnKTsgU0FWRVNUUklORygiYmFja2VuZCIsIGJh Y2tlbmRfZG9tbmFtZSwgRlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIGNhc2Ug OToNCj4+ICAgLyogcnVsZSA5IGNhbiBtYXRjaCBlb2wgKi8NCj4+ICAgWVlfUlVMRV9TRVRVUA0K Pj4gLSNsaW5lIDE5NSAibGlieGx1X2Rpc2tfbC5sIg0KPj4gKyNsaW5lIDIwMyAibGlieGx1X2Rp c2tfbC5sIg0KPj4gICB7IFNUUklQKCcsJyk7IHNldGJhY2tlbmR0eXBlKERQQyxGUk9NRVFVQUxT KTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAgY2FzZSAxMDoNCj4+ICAgLyogcnVsZSAxMCBjYW4g bWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGluZSAxOTcgImxpYnhsdV9k aXNrX2wubCINCj4+IC17IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoInZkZXYiLCB2ZGV2LCBGUk9N RVFVQUxTKTsgfQ0KPj4gKyNsaW5lIDIwNCAibGlieGx1X2Rpc2tfbC5sIg0KPj4gK3sgU1RSSVAo JywnKTsgc2V0c3BlY2lmaWNhdGlvbihEUEMsRlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFL DQo+PiAgIGNhc2UgMTE6DQo+PiAgIC8qIHJ1bGUgMTEgY2FuIG1hdGNoIGVvbCAqLw0KPj4gICBZ WV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMTk4ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAteyBTVFJJ UCgnLCcpOyBTQVZFU1RSSU5HKCJzY3JpcHQiLCBzY3JpcHQsIEZST01FUVVBTFMpOyB9DQo+PiAr I2xpbmUgMjA2ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAreyBTVFJJUCgnLCcpOyBTQVZFU1RSSU5H KCJ2ZGV2IiwgdmRldiwgRlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIGNhc2Ug MTI6DQo+PiArLyogcnVsZSAxMiBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVAN Cj4+IC0jbGluZSAxOTkgImxpYnhsdV9kaXNrX2wubCINCj4+IC17IERQQy0+ZGlzay0+ZGlyZWN0 X2lvX3NhZmUgPSAxOyB9DQo+PiArI2xpbmUgMjA3ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAreyBT VFJJUCgnLCcpOyBTQVZFU1RSSU5HKCJzY3JpcHQiLCBzY3JpcHQsIEZST01FUVVBTFMpOyB9DQo+ PiAgIAlZWV9CUkVBSw0KPj4gICBjYXNlIDEzOg0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xp bmUgMjAwICJsaWJ4bHVfZGlza19sLmwiDQo+PiAteyBsaWJ4bF9kZWZib29sX3NldCgmRFBDLT5k aXNrLT5kaXNjYXJkX2VuYWJsZSwgdHJ1ZSk7IH0NCj4+ICsjbGluZSAyMDggImxpYnhsdV9kaXNr X2wubCINCj4+ICt7IERQQy0+ZGlzay0+ZGlyZWN0X2lvX3NhZmUgPSAxOyB9DQo+PiAgIAlZWV9C UkVBSw0KPj4gICBjYXNlIDE0Og0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMjAxICJs aWJ4bHVfZGlza19sLmwiDQo+PiAteyBsaWJ4bF9kZWZib29sX3NldCgmRFBDLT5kaXNrLT5kaXNj YXJkX2VuYWJsZSwgZmFsc2UpOyB9DQo+PiArI2xpbmUgMjA5ICJsaWJ4bHVfZGlza19sLmwiDQo+ PiAreyBsaWJ4bF9kZWZib29sX3NldCgmRFBDLT5kaXNrLT5kaXNjYXJkX2VuYWJsZSwgdHJ1ZSk7 IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAtLyogTm90ZSB0aGF0IHRoZSBDT0xPIGNvbmZpZ3VyYXRp b24gc2V0dGluZ3Mgc2hvdWxkIGJlIGNvbnNpZGVyZWQgdW5zdGFibGUuDQo+PiAtICAqIFRoZXkg bWF5IGNoYW5nZSBpbmNvbXBhdGlibHkgaW4gZnV0dXJlIHZlcnNpb25zIG9mIFhlbi4gKi8NCj4+ ICAgY2FzZSAxNToNCj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDIwNCAibGlieGx1X2Rp c2tfbC5sIg0KPj4gLXsgbGlieGxfZGVmYm9vbF9zZXQoJkRQQy0+ZGlzay0+Y29sb19lbmFibGUs IHRydWUpOyB9DQo+PiArI2xpbmUgMjEwICJsaWJ4bHVfZGlza19sLmwiDQo+PiAreyBsaWJ4bF9k ZWZib29sX3NldCgmRFBDLT5kaXNrLT5kaXNjYXJkX2VuYWJsZSwgZmFsc2UpOyB9DQo+PiAgIAlZ WV9CUkVBSw0KPj4gKy8qIE5vdGUgdGhhdCB0aGUgQ09MTyBjb25maWd1cmF0aW9uIHNldHRpbmdz IHNob3VsZCBiZSBjb25zaWRlcmVkIHVuc3RhYmxlLg0KPj4gKyAgKiBUaGV5IG1heSBjaGFuZ2Ug aW5jb21wYXRpYmx5IGluIGZ1dHVyZSB2ZXJzaW9ucyBvZiBYZW4uICovDQo+PiAgIGNhc2UgMTY6 DQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGluZSAyMDUgImxpYnhsdV9kaXNrX2wubCINCj4+ IC17IGxpYnhsX2RlZmJvb2xfc2V0KCZEUEMtPmRpc2stPmNvbG9fZW5hYmxlLCBmYWxzZSk7IH0N Cj4+ICsjbGluZSAyMTMgImxpYnhsdV9kaXNrX2wubCINCj4+ICt7IGxpYnhsX2RlZmJvb2xfc2V0 KCZEUEMtPmRpc2stPmNvbG9fZW5hYmxlLCB0cnVlKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAg Y2FzZSAxNzoNCj4+IC0vKiBydWxlIDE3IGNhbiBtYXRjaCBlb2wgKi8NCj4+ICAgWVlfUlVMRV9T RVRVUA0KPj4gLSNsaW5lIDIwNiAibGlieGx1X2Rpc2tfbC5sIg0KPj4gLXsgU1RSSVAoJywnKTsg U0FWRVNUUklORygiY29sby1ob3N0IiwgY29sb19ob3N0LCBGUk9NRVFVQUxTKTsgfQ0KPj4gKyNs aW5lIDIxNCAibGlieGx1X2Rpc2tfbC5sIg0KPj4gK3sgbGlieGxfZGVmYm9vbF9zZXQoJkRQQy0+ ZGlzay0+Y29sb19lbmFibGUsIGZhbHNlKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAgY2FzZSAx ODoNCj4+ICAgLyogcnVsZSAxOCBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVAN Cj4+IC0jbGluZSAyMDcgImxpYnhsdV9kaXNrX2wubCINCj4+IC17IFNUUklQKCcsJyk7IHNldGNv bG9wb3J0KERQQywgRlJPTUVRVUFMUyk7IH0NCj4+ICsjbGluZSAyMTUgImxpYnhsdV9kaXNrX2wu bCINCj4+ICt7IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImNvbG8taG9zdCIsIGNvbG9faG9zdCwg RlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIGNhc2UgMTk6DQo+PiAgIC8qIHJ1 bGUgMTkgY2FuIG1hdGNoIGVvbCAqLw0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMjA4 ICJsaWJ4bHVfZGlza19sLmwiDQo+PiAteyBTVFJJUCgnLCcpOyBTQVZFU1RSSU5HKCJjb2xvLWV4 cG9ydCIsIGNvbG9fZXhwb3J0LCBGUk9NRVFVQUxTKTsgfQ0KPj4gKyNsaW5lIDIxNiAibGlieGx1 X2Rpc2tfbC5sIg0KPj4gK3sgU1RSSVAoJywnKTsgc2V0Y29sb3BvcnQoRFBDLCBGUk9NRVFVQUxT KTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAgY2FzZSAyMDoNCj4+ICAgLyogcnVsZSAyMCBjYW4g bWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGluZSAyMDkgImxpYnhsdV9k aXNrX2wubCINCj4+IC17IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImFjdGl2ZS1kaXNrIiwgYWN0 aXZlX2Rpc2ssIEZST01FUVVBTFMpOyB9DQo+PiArI2xpbmUgMjE3ICJsaWJ4bHVfZGlza19sLmwi DQo+PiAreyBTVFJJUCgnLCcpOyBTQVZFU1RSSU5HKCJjb2xvLWV4cG9ydCIsIGNvbG9fZXhwb3J0 LCBGUk9NRVFVQUxTKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+ICAgY2FzZSAyMToNCj4+ICAgLyog cnVsZSAyMSBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGluZSAy MTAgImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyMTggImxpYnhsdV9kaXNrX2wubCINCj4+ ICt7IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImFjdGl2ZS1kaXNrIiwgYWN0aXZlX2Rpc2ssIEZS T01FUVVBTFMpOyB9DQo+PiArCVlZX0JSRUFLDQo+PiArY2FzZSAyMjoNCj4+ICsvKiBydWxlIDIy IGNhbiBtYXRjaCBlb2wgKi8NCj4+ICtZWV9SVUxFX1NFVFVQDQo+PiArI2xpbmUgMjE5ICJsaWJ4 bHVfZGlza19sLmwiDQo+PiAgIHsgU1RSSVAoJywnKTsgU0FWRVNUUklORygiaGlkZGVuLWRpc2si LCBoaWRkZW5fZGlzaywgRlJPTUVRVUFMUyk7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIC8qIHRo ZSB0YXJnZXQgbWFnaWMgcGFyYW1ldGVyLCBlYXRzIHRoZSByZXN0IG9mIHRoZSBzdHJpbmcgKi8N Cj4+IC1jYXNlIDIyOg0KPj4gK2Nhc2UgMjM6DQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGlu ZSAyMTQgImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyMjMgImxpYnhsdV9kaXNrX2wubCIN Cj4+ICAgeyBTVFJJUCgnLCcpOyBTQVZFU1RSSU5HKCJ0YXJnZXQiLCBwZGV2X3BhdGgsIEZST01F UVVBTFMpOyB9DQo+PiAgIAlZWV9CUkVBSw0KPj4gICAvKiB1bmtub3duIHBhcmFtZXRlcnMgKi8N Cj4+IC1jYXNlIDIzOg0KPj4gLS8qIHJ1bGUgMjMgY2FuIG1hdGNoIGVvbCAqLw0KPj4gK2Nhc2Ug MjQ6DQo+PiArLyogcnVsZSAyNCBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVAN Cj4+IC0jbGluZSAyMTggImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyMjcgImxpYnhsdV9k aXNrX2wubCINCj4+ICAgeyB4bHVfX2Rpc2tfZXJyKERQQyx5eXRleHQsInVua25vd24gcGFyYW1l dGVyIik7IH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAgIC8qIGRlcHJlY2F0ZWQgcHJlZml4ZXMgKi8N Cj4+ICAgLyogdGhlICIvLioiIGluIHRoZXNlIHBhdHRlcm5zIGVuc3VyZXMgdGhhdCB0aGV5IGNv dW50IGFzIGlmIHRoZXkNCj4+ICAgICAgKiBtYXRjaGVkIHRoZSB3aG9sZSBzdHJpbmcsIHNvIHRo ZXNlIHBhdHRlcm5zIHRha2UgcHJlY2VkZW5jZSAqLw0KPj4gLWNhc2UgMjQ6DQo+PiArY2FzZSAy NToNCj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDIyNSAibGlieGx1X2Rpc2tfbC5sIg0K Pj4gKyNsaW5lIDIzNCAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7DQo+PiAgICAgICAgICAgICAg ICAgICAgICAgU1RSSVAoJzonKTsNCj4+ICAgICAgICAgICAgICAgICAgICAgICBEUEMtPmhhZF9k ZXByX3ByZWZpeD0xOyBERVBSRUNBVEUoInVzZSBgW2Zvcm1hdD1dLi4uLCciKTsNCj4+ICAgICAg ICAgICAgICAgICAgICAgICBzZXRmb3JtYXQoRFBDLCB5eXRleHQpOw0KPj4gICAgICAgICAgICAg ICAgICAgIH0NCj4+ICAgCVlZX0JSRUFLDQo+PiAtY2FzZSAyNToNCj4+ICtjYXNlIDI2Og0KPj4g ICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUgMjMxICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xp bmUgMjQwICJsaWJ4bHVfZGlza19sLmwiDQo+PiAgIHsNCj4+ICAgICAgICAgICAgICAgICAgICAg ICBjaGFyICpuZXdzY3JpcHQ7DQo+PiAgICAgICAgICAgICAgICAgICAgICAgU1RSSVAoJzonKTsN Cj4+IEBAIC0xNzMxLDY1ICsxNzYyLDY1IEBAIFlZX1JVTEVfU0VUVVANCj4+ICAgICAgICAgICAg ICAgICAgICAgICBmcmVlKG5ld3NjcmlwdCk7DQo+PiAgICAgICAgICAgICAgICAgICB9DQo+PiAg IAlZWV9CUkVBSw0KPj4gLWNhc2UgMjY6DQo+PiArY2FzZSAyNzoNCj4+ICAgKnl5X2NwID0geXln LT55eV9ob2xkX2NoYXI7IC8qIHVuZG8gZWZmZWN0cyBvZiBzZXR0aW5nIHVwIHl5dGV4dCAqLw0K Pj4gICB5eWctPnl5X2NfYnVmX3AgPSB5eV9jcCA9IHl5X2JwICsgODsNCj4+ICAgWVlfRE9fQkVG T1JFX0FDVElPTjsgLyogc2V0IHVwIHl5dGV4dCBhZ2FpbiAqLw0KPj4gICBZWV9SVUxFX1NFVFVQ DQo+PiAtI2xpbmUgMjQ0ICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMjUzICJsaWJ4bHVf ZGlza19sLmwiDQo+PiAgIHsgRFBDLT5oYWRfZGVwcl9wcmVmaXg9MTsgREVQUkVDQVRFKDApOyB9 DQo+PiAgIAlZWV9CUkVBSw0KPj4gLWNhc2UgMjc6DQo+PiArY2FzZSAyODoNCj4+ICAgWVlfUlVM RV9TRVRVUA0KPj4gLSNsaW5lIDI0NSAibGlieGx1X2Rpc2tfbC5sIg0KPj4gKyNsaW5lIDI1NCAi bGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+aGFkX2RlcHJfcHJlZml4PTE7IERFUFJFQ0FU RSgwKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNlIDI4Og0KPj4gK2Nhc2UgMjk6DQo+PiAg ICp5eV9jcCA9IHl5Zy0+eXlfaG9sZF9jaGFyOyAvKiB1bmRvIGVmZmVjdHMgb2Ygc2V0dGluZyB1 cCB5eXRleHQgKi8NCj4+ICAgeXlnLT55eV9jX2J1Zl9wID0geXlfY3AgPSB5eV9icCArIDQ7DQo+ PiAgIFlZX0RPX0JFRk9SRV9BQ1RJT047IC8qIHNldCB1cCB5eXRleHQgYWdhaW4gKi8NCj4+ICAg WVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDI0NiAibGlieGx1X2Rpc2tfbC5sIg0KPj4gKyNsaW5l IDI1NSAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+aGFkX2RlcHJfcHJlZml4PTE7IERF UFJFQ0FURSgwKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNlIDI5Og0KPj4gK2Nhc2UgMzA6 DQo+PiAgICp5eV9jcCA9IHl5Zy0+eXlfaG9sZF9jaGFyOyAvKiB1bmRvIGVmZmVjdHMgb2Ygc2V0 dGluZyB1cCB5eXRleHQgKi8NCj4+ICAgeXlnLT55eV9jX2J1Zl9wID0geXlfY3AgPSB5eV9icCAr IDY7DQo+PiAgIFlZX0RPX0JFRk9SRV9BQ1RJT047IC8qIHNldCB1cCB5eXRleHQgYWdhaW4gKi8N Cj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDI0NyAibGlieGx1X2Rpc2tfbC5sIg0KPj4g KyNsaW5lIDI1NiAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+aGFkX2RlcHJfcHJlZml4 PTE7IERFUFJFQ0FURSgwKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNlIDMwOg0KPj4gK2Nh c2UgMzE6DQo+PiAgICp5eV9jcCA9IHl5Zy0+eXlfaG9sZF9jaGFyOyAvKiB1bmRvIGVmZmVjdHMg b2Ygc2V0dGluZyB1cCB5eXRleHQgKi8NCj4+ICAgeXlnLT55eV9jX2J1Zl9wID0geXlfY3AgPSB5 eV9icCArIDU7DQo+PiAgIFlZX0RPX0JFRk9SRV9BQ1RJT047IC8qIHNldCB1cCB5eXRleHQgYWdh aW4gKi8NCj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDI0OCAibGlieGx1X2Rpc2tfbC5s Ig0KPj4gKyNsaW5lIDI1NyAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+aGFkX2RlcHJf cHJlZml4PTE7IERFUFJFQ0FURSgwKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNlIDMxOg0K Pj4gK2Nhc2UgMzI6DQo+PiAgICp5eV9jcCA9IHl5Zy0+eXlfaG9sZF9jaGFyOyAvKiB1bmRvIGVm ZmVjdHMgb2Ygc2V0dGluZyB1cCB5eXRleHQgKi8NCj4+ICAgeXlnLT55eV9jX2J1Zl9wID0geXlf Y3AgPSB5eV9icCArIDQ7DQo+PiAgIFlZX0RPX0JFRk9SRV9BQ1RJT047IC8qIHNldCB1cCB5eXRl eHQgYWdhaW4gKi8NCj4+ICAgWVlfUlVMRV9TRVRVUA0KPj4gLSNsaW5lIDI0OSAibGlieGx1X2Rp c2tfbC5sIg0KPj4gKyNsaW5lIDI1OCAibGlieGx1X2Rpc2tfbC5sIg0KPj4gICB7IERQQy0+aGFk X2RlcHJfcHJlZml4PTE7IERFUFJFQ0FURSgwKTsgfQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNl IDMyOg0KPj4gLS8qIHJ1bGUgMzIgY2FuIG1hdGNoIGVvbCAqLw0KPj4gK2Nhc2UgMzM6DQo+PiAr LyogcnVsZSAzMyBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGlu ZSAyNTEgImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyNjAgImxpYnhsdV9kaXNrX2wubCIN Cj4+ICAgew0KPj4gICAJCSAgeGx1X19kaXNrX2VycihEUEMseXl0ZXh0LCJ1bmtub3duIGRlcHJl Y2F0ZWQgZGlzaw0KPj4gcHJlZml4Iik7DQo+PiAgIAkJICByZXR1cm4gMDsNCj4+ICAgCQl9DQo+ PiAgIAlZWV9CUkVBSw0KPj4gICAvKiBwb3NpdGlvbmFsIHBhcmFtZXRlcnMgKi8NCj4+IC1jYXNl IDMzOg0KPj4gLS8qIHJ1bGUgMzMgY2FuIG1hdGNoIGVvbCAqLw0KPj4gK2Nhc2UgMzQ6DQo+PiAr LyogcnVsZSAzNCBjYW4gbWF0Y2ggZW9sICovDQo+PiAgIFlZX1JVTEVfU0VUVVANCj4+IC0jbGlu ZSAyNTggImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyNjcgImxpYnhsdV9kaXNrX2wubCIN Cj4+ICAgew0KPj4gICAgICAgU1RSSVAoJywnKTsNCj4+DQo+PiBAQCAtMTgxNiwyNyArMTg0Nywy NyBAQCBZWV9SVUxFX1NFVFVQDQo+PiAgICAgICB9DQo+PiAgIH0NCj4+ICAgCVlZX0JSRUFLDQo+ PiAtY2FzZSAzNDoNCj4+ICtjYXNlIDM1Og0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xpbmUg Mjg0ICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMjkzICJsaWJ4bHVfZGlza19sLmwiDQo+ PiAgIHsNCj4+ICAgICAgIEJFR0lOKExFWEVSUik7DQo+PiAgICAgICB5eW1vcmUoKTsNCj4+ICAg fQ0KPj4gICAJWVlfQlJFQUsNCj4+IC1jYXNlIDM1Og0KPj4gK2Nhc2UgMzY6DQo+PiAgIFlZX1JV TEVfU0VUVVANCj4+IC0jbGluZSAyODggImxpYnhsdV9kaXNrX2wubCINCj4+ICsjbGluZSAyOTcg ImxpYnhsdV9kaXNrX2wubCINCj4+ICAgew0KPj4gICAgICAgeGx1X19kaXNrX2VycihEUEMseXl0 ZXh0LCJiYWQgZGlzayBzeW50YXgiKTsgcmV0dXJuIDA7DQo+PiAgIH0NCj4+ICAgCVlZX0JSRUFL DQo+PiAtY2FzZSAzNjoNCj4+ICtjYXNlIDM3Og0KPj4gICBZWV9SVUxFX1NFVFVQDQo+PiAtI2xp bmUgMjkxICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMzAwICJsaWJ4bHVfZGlza19sLmwi DQo+PiAgIFlZX0ZBVEFMX0VSUk9SKCAiZmxleCBzY2FubmVyIGphbW1lZCIgKTsNCj4+ICAgCVlZ X0JSRUFLDQo+PiAtI2xpbmUgMTgzOSAibGlieGx1X2Rpc2tfbC5jIg0KPj4gKyNsaW5lIDE4NzAg ImxpYnhsdV9kaXNrX2wuYyINCj4+ICAgCQkJY2FzZSBZWV9TVEFURV9FT0YoSU5JVElBTCk6DQo+ PiAgIAkJCWNhc2UgWVlfU1RBVEVfRU9GKExFWEVSUik6DQo+PiAgIAkJCQl5eXRlcm1pbmF0ZSgp Ow0KPj4gQEAgLTIxMDQsNyArMjEzNSw3IEBAIHN0YXRpYyBpbnQgeXlfZ2V0X25leHRfYnVmZmVy ICh5eXNjYW5fdCB5eXNjYW5uZXIpDQo+PiAgIAkJd2hpbGUgKCB5eV9jaGtbeXlfYmFzZVt5eV9j dXJyZW50X3N0YXRlXSArIHl5X2NdICE9DQo+PiB5eV9jdXJyZW50X3N0YXRlICkNCj4+ICAgCQkJ ew0KPj4gICAJCQl5eV9jdXJyZW50X3N0YXRlID0gKGludCkgeXlfZGVmW3l5X2N1cnJlbnRfc3Rh dGVdOw0KPj4gLQkJCWlmICggeXlfY3VycmVudF9zdGF0ZSA+PSAzNTUgKQ0KPj4gKwkJCWlmICgg eXlfY3VycmVudF9zdGF0ZSA+PSAzNzIgKQ0KPj4gICAJCQkJeXlfYyA9IHl5X21ldGFbeXlfY107 DQo+PiAgIAkJCX0NCj4+ICAgCQl5eV9jdXJyZW50X3N0YXRlID0geXlfbnh0W3l5X2Jhc2VbeXlf Y3VycmVudF9zdGF0ZV0gKyB5eV9jXTsNCj4+IEBAIC0yMTI4LDExICsyMTU5LDExIEBAIHN0YXRp YyBpbnQgeXlfZ2V0X25leHRfYnVmZmVyICh5eXNjYW5fdA0KPj4geXlzY2FubmVyKQ0KPj4gICAJ d2hpbGUgKCB5eV9jaGtbeXlfYmFzZVt5eV9jdXJyZW50X3N0YXRlXSArIHl5X2NdICE9IHl5X2N1 cnJlbnRfc3RhdGUgKQ0KPj4gICAJCXsNCj4+ICAgCQl5eV9jdXJyZW50X3N0YXRlID0gKGludCkg eXlfZGVmW3l5X2N1cnJlbnRfc3RhdGVdOw0KPj4gLQkJaWYgKCB5eV9jdXJyZW50X3N0YXRlID49 IDM1NSApDQo+PiArCQlpZiAoIHl5X2N1cnJlbnRfc3RhdGUgPj0gMzcyICkNCj4+ICAgCQkJeXlf YyA9IHl5X21ldGFbeXlfY107DQo+PiAgIAkJfQ0KPj4gICAJeXlfY3VycmVudF9zdGF0ZSA9IHl5 X254dFt5eV9iYXNlW3l5X2N1cnJlbnRfc3RhdGVdICsgeXlfY107DQo+PiAtCXl5X2lzX2phbSA9 ICh5eV9jdXJyZW50X3N0YXRlID09IDM1NCk7DQo+PiArCXl5X2lzX2phbSA9ICh5eV9jdXJyZW50 X3N0YXRlID09IDM3MSk7DQo+PiAgIAlpZiAoICEgeXlfaXNfamFtICkNCj4+ICAgCQkqeXlnLT55 eV9zdGF0ZV9wdHIrKyA9IHl5X2N1cnJlbnRfc3RhdGU7DQo+Pg0KPj4gQEAgLTI5NDEsNCArMjk3 Miw0IEBAIHZvaWQgeXlmcmVlICh2b2lkICogcHRyICwgeXlzY2FuX3QgeXlzY2FubmVyKQ0KPj4N Cj4+ICAgI2RlZmluZSBZWVRBQkxFU19OQU1FICJ5eXRhYmxlcyINCj4+DQo+PiAtI2xpbmUgMjkx ICJsaWJ4bHVfZGlza19sLmwiDQo+PiArI2xpbmUgMzAwICJsaWJ4bHVfZGlza19sLmwiDQo+PiBk aWZmIC0tZ2l0IGEvdG9vbHMvbGlicy91dGlsL2xpYnhsdV9kaXNrX2wuaCBiL3Rvb2xzL2xpYnMv dXRpbC9saWJ4bHVfZGlza19sLmgNCj4+IGluZGV4IDZhYmVlY2YyNzkuLjUwOWFhZDY3ZGMgMTAw NjQ0DQo+PiAtLS0gYS90b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5oDQo+PiArKysgYi90 b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5oDQo+PiBAQCAtNjk0LDcgKzY5NCw3IEBAIGV4 dGVybiBpbnQgeXlsZXggKHl5c2Nhbl90IHl5c2Nhbm5lcik7DQo+PiAgICN1bmRlZiB5eVRBQkxF U19OQU1FDQo+PiAgICNlbmRpZg0KPj4NCj4+IC0jbGluZSAyOTEgImxpYnhsdV9kaXNrX2wubCIN Cj4+ICsjbGluZSAzMDAgImxpYnhsdV9kaXNrX2wubCINCj4+DQo+PiAgICNsaW5lIDY5OSAibGli eGx1X2Rpc2tfbC5oIg0KPj4gICAjdW5kZWYgeGx1X19kaXNrX3l5SU5fSEVBREVSDQo+PiBkaWZm IC0tZ2l0IGEvdG9vbHMvbGlicy91dGlsL2xpYnhsdV9kaXNrX2wubCBiL3Rvb2xzL2xpYnMvdXRp bC9saWJ4bHVfZGlza19sLmwNCj4+IGluZGV4IGUxMTU0NjBkOTkuLjZkNTNjMDkzYTMgMTAwNjQ0 DQo+PiAtLS0gYS90b29scy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5sDQo+PiArKysgYi90b29s cy9saWJzL3V0aWwvbGlieGx1X2Rpc2tfbC5sDQo+PiBAQCAtMTIyLDkgKzEyMiwxNyBAQCBzdGF0 aWMgdm9pZCBzZXRiYWNrZW5kdHlwZShEaXNrUGFyc2VDb250ZXh0ICpkcGMsDQo+PiBjb25zdCBj aGFyICpzdHIpIHsNCj4+ICAgICAgIGlmICggICAgICFzdHJjbXAoc3RyLCJwaHkiKSkgICBEU0VU KGRwYyxiYWNrZW5kLEJBQ0tFTkQsc3RyLFBIWSk7DQo+PiAgICAgICBlbHNlIGlmICghc3RyY21w KHN0ciwidGFwIikpICAgRFNFVChkcGMsYmFja2VuZCxCQUNLRU5ELHN0cixUQVApOw0KPj4gICAg ICAgZWxzZSBpZiAoIXN0cmNtcChzdHIsInFkaXNrIikpIERTRVQoZHBjLGJhY2tlbmQsQkFDS0VO RCxzdHIsUURJU0spOw0KPj4gKyAgICBlbHNlIGlmICghc3RyY21wKHN0ciwic3RhbmRhbG9uZSIp KQ0KPj4gRFNFVChkcGMsYmFja2VuZCxCQUNLRU5ELHN0cixTVEFOREFMT05FKTsNCj4+ICAgICAg IGVsc2UgeGx1X19kaXNrX2VycihkcGMsc3RyLCJ1bmtub3duIHZhbHVlIGZvciBiYWNrZW5kdHlw ZSIpOw0KPj4gICB9DQo+Pg0KPj4gKy8qIFNldHMgLT5zcGVjaWZpY2F0aW9uIGZyb20gdGhlIHN0 cmluZy4gIElETCBzaG91bGQgcHJvdmlkZSBzb21ldGhpbmcgZm9yDQo+PiB0aGlzLiAqLw0KPj4g K3N0YXRpYyB2b2lkIHNldHNwZWNpZmljYXRpb24oRGlza1BhcnNlQ29udGV4dCAqZHBjLCBjb25z dCBjaGFyICpzdHIpIHsNCj4+ICsgICAgaWYgICAgICAoIXN0cmNtcChzdHIsInhlbiIpKSAgICBE U0VUKGRwYyxzcGVjaWZpY2F0aW9uLFNQRUNJRklDQVRJT04sc3RyLFhFTik7DQo+PiArICAgIGVs c2UgaWYgKCFzdHJjbXAoc3RyLCJ2aXJ0aW8iKSkNCj4+IERTRVQoZHBjLHNwZWNpZmljYXRpb24s U1BFQ0lGSUNBVElPTixzdHIsVklSVElPKTsNCj4+ICsgICAgZWxzZSB4bHVfX2Rpc2tfZXJyKGRw YyxzdHIsInVua25vd24gdmFsdWUgZm9yIHNwZWNpZmljYXRpb24iKTsNCj4+ICt9DQo+PiArDQo+ PiAgIC8qIFNldHMgLT5jb2xvLXBvcnQgZnJvbSB0aGUgc3RyaW5nLiAgQ09MTyBuZWVkIHRoaXMu ICovDQo+PiAgIHN0YXRpYyB2b2lkIHNldGNvbG9wb3J0KERpc2tQYXJzZUNvbnRleHQgKmRwYywg Y29uc3QgY2hhciAqc3RyKSB7DQo+PiAgICAgICBpbnQgcG9ydCA9IGF0b2koc3RyKTsNCj4+IEBA IC0xOTIsNiArMjAwLDcgQEAgZGV2dHlwZT1bXixdKiw/DQo+PiAJeyB4bHVfX2Rpc2tfZXJyKERQ Qyx5eXRleHQsInVua25vd24gdmFsdWUgZm9yIHR5cGUiKTsgfQ0KPj4gICBhY2Nlc3M9W14sXSos Pwl7IFNUUklQKCcsJyk7IHNldGFjY2VzcyhEUEMsIEZST01FUVVBTFMpOyB9DQo+PiAgIGJhY2tl bmQ9W14sXSosPyB7IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoImJhY2tlbmQiLCBiYWNrZW5kX2Rv bW5hbWUsDQo+PiBGUk9NRVFVQUxTKTsgfQ0KPj4gICBiYWNrZW5kdHlwZT1bXixdKiw/IHsgU1RS SVAoJywnKTsgc2V0YmFja2VuZHR5cGUoRFBDLEZST01FUVVBTFMpOyB9DQo+PiArc3BlY2lmaWNh dGlvbj1bXixdKiw/IHsgU1RSSVAoJywnKTsgc2V0c3BlY2lmaWNhdGlvbihEUEMsRlJPTUVRVUFM Uyk7IH0NCj4+DQo+PiAgIHZkZXY9W14sXSosPwl7IFNUUklQKCcsJyk7IFNBVkVTVFJJTkcoInZk ZXYiLCB2ZGV2LCBGUk9NRVFVQUxTKTsgfQ0KPj4gICBzY3JpcHQ9W14sXSosPwl7IFNUUklQKCcs Jyk7IFNBVkVTVFJJTkcoInNjcmlwdCIsIHNjcmlwdCwgRlJPTUVRVUFMUyk7IH0NCj4+IGRpZmYg LS1naXQgYS90b29scy94bC94bF9ibG9jay5jIGIvdG9vbHMveGwveGxfYmxvY2suYw0KPj4gaW5k ZXggNzBlZWQ0MzFlNC4uODgzNmMwN2Q2YiAxMDA2NDQNCj4+IC0tLSBhL3Rvb2xzL3hsL3hsX2Js b2NrLmMNCj4+ICsrKyBiL3Rvb2xzL3hsL3hsX2Jsb2NrLmMNCj4+IEBAIC0xMTksNiArMTE5LDEy IEBAIGludCBtYWluX2Jsb2NrZGV0YWNoKGludCBhcmdjLCBjaGFyICoqYXJndikNCj4+ICAgICAg ICAgICBmcHJpbnRmKHN0ZGVyciwgIkVycm9yOiBEZXZpY2UgJXMgbm90IGNvbm5lY3RlZC5cbiIs IGFyZ3Zbb3B0aW5kKzFdKTsNCj4+ICAgICAgICAgICByZXR1cm4gMTsNCj4+ICAgICAgIH0NCj4+ ICsNCj4+ICsgICAgaWYgKGRpc2suc3BlY2lmaWNhdGlvbiA9PSBMSUJYTF9ESVNLX1NQRUNJRklD QVRJT05fVklSVElPKSB7DQo+PiArICAgICAgICBmcHJpbnRmKHN0ZGVyciwgIkhvdHVucGx1ZyBp c24ndCBzdXBwb3J0ZWQgZm9yIHNwZWNpZmljYXRpb24gdmlydGlvXG4iKTsNCj4+ICsgICAgICAg IHJldHVybiAxOw0KPj4gKyAgICB9DQo+PiArDQo+PiAgICAgICByYyA9ICFmb3JjZSA/IGxpYnhs X2RldmljZV9kaXNrX3NhZmVfcmVtb3ZlKGN0eCwgZG9taWQsICZkaXNrLCAwKSA6DQo+PiAgICAg ICAgICAgbGlieGxfZGV2aWNlX2Rpc2tfZGVzdHJveShjdHgsIGRvbWlkLCAmZGlzaywgMCk7DQo+ PiAgICAgICBpZiAocmMpIHsNCj4+IC0tDQo+PiAyLjI1LjENCj4+DQotLSANClJlZ2FyZHMsDQoN Ck9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 20 08:11:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 08:11:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371449.603364 (Exim 4.92) (envelope-from ) id 1oE4oA-0007Bm-N9; Wed, 20 Jul 2022 08:11:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371449.603364; Wed, 20 Jul 2022 08:11:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4oA-0007Bf-KM; Wed, 20 Jul 2022 08:11:50 +0000 Received: by outflank-mailman (input) for mailman id 371449; Wed, 20 Jul 2022 08:11:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4o9-0007BZ-Rq for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 08:11:49 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 99fe5b6f-0803-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 10:11:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8771.eurprd04.prod.outlook.com (2603:10a6:20b:42c::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 08:11:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 08:11:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99fe5b6f-0803-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O4Xf4yLUyBKxfzmU8hVC2hl743D5xv9jaMYiyPl9hUHK0YxBz4dDjB8pGHPbqzxkyr4Ixu+1oV7LgIaLZevNGuIuUvsF3Z+VxoD42SxP4asVGwLaXHed3BJ28ZhOmPASyYt75XfARyTPGcaAYtycNDmc9c4penuApAGPMpKtgILyFzUFp906LOuE+TRlSTQYGDKVJ9FAgwOGByYSRCGHVmaJ0tmY8DC25glmo16M1qroKOkhF0fl4eow2anFd6VqUjv0yOuZ1u82DFJ02ZIkEi83/naOnEKMmydKFmJYWoBTnzjcv6LacoNq9IzgpmbCguRv/S3nuD0lC7MLNBr86A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q5QMMJmdv8UdFFp/tFz5gEMskgskspJo3Tgkarqn6m4=; b=kZxrGHRUDy7beys0sBNqnGpLjCVWeXspIrzRcxyG+36SVazZVN7OkOOpAqySy5do5663Spm8mOJZN3I235WQavgvmsUgqsLjOJYmgk0+/K5+QWP0eHRPyiEin/p+CGJ6QOpF0mNf0jFvh4nYdj6kB+Tu95s9s8Yixm+km3QScF5iK/fStZDHufN8EnjPY7FZGW4W2ivMZlBLVAkRKqFQ+wiou9uh1p9vWkRnQYP0qECWw251YhYHW5xSi49gvy6EKC9AZJM06Wb1rPlSj90wtTP6Pp1gIJ5euzoblhl/TFFc9Tyfx/LN09kTSqTpLYy4tOB0Q6bv6g3EZ9LFzak0vA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q5QMMJmdv8UdFFp/tFz5gEMskgskspJo3Tgkarqn6m4=; b=1XZ7T0VbO6pOjHeuUsHDbNkNNzXlow5h0TW3ov1m1jCq7GAunHWcQSkn380snS5rG7T78/Wiqwu1yUAjAMI4NQIBcQpK7oLalcXXOHGfpmBH+BIZ3wIlIKXTDN7/CbBa/ktrnGdQK/AQO+RdWEFfZ2ilqgfKvu404y+Np2LqPECG04UEduH7N0cGtmA64wYL6r6WeWyMiuqHoFozbJgEyHCgbw9d4MMsFlPJjFJC4uWvWvDQ4UcF5yflKrqdyBcFo5HAOAU7B7JRinUOpDddQ85RB5KMrHGuHzT+GI2Yse9VGAVjAHP4t64QPblvGFoQPU/WFOTycWqzu1dnjIFEhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 20 Jul 2022 10:11:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US To: Dylanger Daly Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <4c3976aa-dad4-2707-2852-9b26593692d0@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 87f0eee0-1c40-456c-5cc4-08da6a277d0b X-MS-TrafficTypeDiagnostic: AS8PR04MB8771:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wn4/9FPXD559DqlcycQn4GbRont3p83nVuhwDFEGuvklpuKqCoY9DYvxOhtK5d5ozoZFaWnWxhmt0+3F+F+u9+qGfbOPrIEyleAPRJyw3gj3pb9GzyVOtiLR44RlTYzDU2K8VhS0h5ta6VasUhzUgLRoNzVal8QvdmjOpNA4t0kZgCoADDruQGdMKQez+t74NqKBCG+ctQ6h2FPXkDV25Fn/iXCQuTNqcZqPFyAvtNhZDjzgw0ZMQ2AMeBRC/vHkLXqU0NuAm1j206Q93vIy2y3KQ13tWuWTU3BCDX0T5cl/XHpQH7gIhi7nmPRfpRmox7+9BU3qe6zMYgJOtALuhWSe45JJSE3ycSIZW2Zutvx4dIi6VoS+g+mtgDVnmH+WhTNSSfEDrht0jeg8py9TFD370uD2medTI2wHGbCpGYdKFKOl2d/mRWWmjpjCScvQmsKrT8/agaeDanprJVbuRlB5q4Ih03wpsLPw6cOGsbn4rlqMN/frqT8j/xFnjUCPCg6dLyUMzc3Rb5lU3inmVEKTf9NE+yz3TZAa9LsDSuVt38TE/l0Gtg3c3aY5q6c5G6is1+POQphfM3c2u5NGXzEK9fijoz6WFsdC26UZebpszKFnbpfUX7cK5YTIbjGBCiJ4CjZ609QvGB+Yla2ktSV5qAYURqzOt5bpm4WHxKygoN4pf4uWK+lR7N7A9H9j8cCvLgGAcjbogI+ojwdJH1TLbvwNcboLA97lwRlm76oEGhEuG/AkBnZmUHCG2pgwm63yXUKuepYGitRfVr3fznjOjyLkz1rtxfOk2hcO8OPgtq0n0XWYsbuUgapjZQkv87PtqrNZQyDeSRdWztNdiQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(366004)(136003)(376002)(346002)(2906002)(6486002)(66574015)(38100700002)(6506007)(66946007)(66556008)(66476007)(53546011)(8676002)(4326008)(6512007)(86362001)(26005)(31696002)(5660300002)(36756003)(31686004)(8936002)(2616005)(186003)(41300700001)(316002)(4744005)(54906003)(478600001)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUdHVVFhOEljS20rWGxUQ3JEUm5xRmJzYnVhMGJFUU1WdG14TmY0QUpNOUor?= =?utf-8?B?K1VpZ1c0VE9ZbXp4WkR1MnFJTXJuWHJYY2tNWFdHMjRKTHMxNXR5b2pSU3Ju?= =?utf-8?B?dlMxN3pnOWMyc0lVZnBSc3pDa1VlSjlsSUFZMyswTFdHOEw3bVQrSmMySE9R?= =?utf-8?B?MUwwVEZybGZWYkdGQWJlamVXaXRwRnJ6QmQ4ZmJXV0REZ21mSDQ4VHUvTUJi?= =?utf-8?B?V2VDV1ZpVlZiUW9CMmVFOVZXZE4vUi85U0VrSEtHZkdvYTIrVURSWmZEd2xL?= =?utf-8?B?ejVmTjNQRENvQUJQTGlSVFRZVFR4bmZoSjJIYW5oby9pL3NvOXFRWVB4R3ZX?= =?utf-8?B?d1VYbHJ1bnRPMDN1OGI5ekVMdmFmSXlEYm1IVGdWYXQrNHJmUGM5N2xLNWEw?= =?utf-8?B?dnpCRDhaMEpnWmdacVZodUFGaU9EK2ZlQ1ZQRU9qalNkeW5zVzZvVnRUbWJx?= =?utf-8?B?QkZvQWNIUjdCY3p2UmFzdThDVVdrMGNCQzNtM3JmalR1RUJRUHdweThGcFNy?= =?utf-8?B?azBaMXM3ZG5ndU5HdFhQTE5CSHFXNkxUNnRsYlJYQVlyOE1oK1U2ZEpiOG84?= =?utf-8?B?QnkzU1dwem8xN0NTdXNxNjFKUVF5WkQydFR3ZE5jMWxuVmk3TFBjN3gxdlNx?= =?utf-8?B?V21UTExoSGxRUWozNVlmd2JhWGJISC9XamtmdkwzQkNobHgxSllhYnZwNnMr?= =?utf-8?B?bUNwK2ZXWCtHVlJLUnZ3SHVQNmNyTVpFeVRYemZ6SExvejFFWlRKWkMxYzQ3?= =?utf-8?B?MHhIaXdGdE1wVjVhUUtnQ0toTWh4T09aNVRVRmlpNFBGSUpreElia01nRjlH?= =?utf-8?B?Z2M1UGs4d0VSWGNSdFJUQ3oyaTBBOUhCcHVaVFVXUG1OaTNNY0dwSjhJNUVv?= =?utf-8?B?cVk5YmtLNWJ3eWFBODJ4cUNoZEhha0ZvQTl4VlA2UjViUnJGRGJ2aGI3cTVq?= =?utf-8?B?K3U0ZUJaT2l6cWtTZG9WUDR6MWVaeUtBZmJML0s1ai9RTDBmTEtidzc0V1F2?= =?utf-8?B?KzlrK1JhREJrYnpwN2duUkdaZ2k0Wk9FcGdhekNwdmNCWTlJRGVOcUNpVzN2?= =?utf-8?B?MC9oMUhvaENxV05BUFVYKzh2dTgzVTVqdnMzcWlZMTc3Ykhaa1RxNUFwL3R2?= =?utf-8?B?YmpmLzZqWEpBVU9rUENCQWx0cEUrUEszWVIwaXdQa1U5UGp3VSs3RENwTlFs?= =?utf-8?B?eS9yckRUSFFnSyttcEZSQUd2TlRyVWx3NlVnUWcycU4rUWpwS1JiRzNCd053?= =?utf-8?B?SjQ5SERpRExXUjkwYTdrVEpHUU96TkNtK0lMWS9jNTdRZTcvTm9SQlZhMjlw?= =?utf-8?B?aVlWcm53NU5pdVBGNW5CV09XQWd4emY4QlRhV0JqcGVJbGJsQnNYcmJ3MzY5?= =?utf-8?B?L1NURHBHSStKU2NTSERDMHg0cm9lVmVWNjhYN2RmZWdpak1NVUVZVk5IVGlV?= =?utf-8?B?d3FaQjNndEl6SHczUldIQllKakNUNVVZQXd0ZENJN2w4aEE2Qzh4czViVWwz?= =?utf-8?B?L0treWdNN0VtQ0VURmVHalIwR2h0UXpyNFF2d2dlUHdYeXdSZjJQbkRDN1Nl?= =?utf-8?B?Y3FKOC9HeEU4Nysrd2N5TENQREZtczhSaXBkUlZrUGlFc000TFVsM3BIdzZ3?= =?utf-8?B?SzVZUUw0bTZYTHA4cGtBYkJ5cWFPSHAxTmFoT2hWdmN1aUVyRkh1VmNodE5n?= =?utf-8?B?V0k5Vkk2T3dBakZpZU4yaURBaFBpZ3VjQjNVTW1MQW5Pc0djeGVKMEgxaG5H?= =?utf-8?B?TjIxYVRrUnNXTExlaWlObUFBUVFVWnN0eTRsWjJhL1hrUS96bEltUlV1Mkpu?= =?utf-8?B?bUJ0bEx2SjdiU1FuSkwyUVVtTjU0ZEVES0hBOTVHTWhjVjc0L2FpN01MZTNz?= =?utf-8?B?TDFDSEk4cDZrT1lLaHpKZXgyckZ4RW5aM3BZaUFxS04wbkNQZnZROUJWWTdR?= =?utf-8?B?MDlyaWZNQjA0TTRpTEUzT01zUXJFVWliYTdTUlFacUkyUjRiejg0WC9NNGNl?= =?utf-8?B?Yi9Cb1ZnWHByL1Vjazc5WFQwKzNEMGhYS3JwRDhOUTI5VXZmVm1WR21jb3pz?= =?utf-8?B?Q0IwOWdwT2F5SzFMQ0EzRnorRjNxMjZnaFd6OXorZEt4czFmMUpjS21WQThr?= =?utf-8?Q?v+F39wSmhhcJy02bGTsay4EBR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 87f0eee0-1c40-456c-5cc4-08da6a277d0b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:11:46.1761 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v477SiasxL23d5+WkBLEjVI3IcPWQjKR/1RFQ4jPc67VlbOgBnMCShIgMNOVFpHoNHTZIBYTaS/cDF8OgKNjIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8771 On 20.07.2022 02:33, Dylanger Daly wrote: >> I'd focus on the booting issues first. And I guess you can take a video >> of that (assuming that a single screenshot likely isn't going to be >> enough), possibly with "vga=keep" in place (albeit that introduces >> extra slowness)? >> >> There's also the option of using an EHCI debug port for the serial >> console, but this requires (a) a special cable and (b) the system >> designers not having inserted any hubs between the controller andthe connector. > > Do you know if it's possible to have `console=vga vga=keep` and specify a secondary monitor? This would be very useful if I could have Xen log via a secondary monitor, No, if anything it could be the other way around. Xen wants to use the (sole) VGAish thing in the system; Dom0 kernel and Dom0 userspace (X) may be happy to use any secondary (non-VGA) graphics card. On EFI it might in principle be possible, but that would require (perhaps quite a bit of) work in Xen. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 08:13:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 08:13:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371454.603375 (Exim 4.92) (envelope-from ) id 1oE4pg-0007kt-27; Wed, 20 Jul 2022 08:13:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371454.603375; Wed, 20 Jul 2022 08:13:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4pf-0007km-VG; Wed, 20 Jul 2022 08:13:23 +0000 Received: by outflank-mailman (input) for mailman id 371454; Wed, 20 Jul 2022 08:13:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4pe-0007ka-Qb for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 08:13:22 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150057.outbound.protection.outlook.com [40.107.15.57]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1b5f7df-0803-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 10:13:21 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4604.eurprd04.prod.outlook.com (2603:10a6:5:35::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 08:13:19 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 08:13:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1b5f7df-0803-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IbOCLNZ1K5fYKiflplWu6O5jiTOg1iurQ7rXgdmRRo3/gUVfHTeMsKv6eDR2uxgT5LDBr/SZhtr46OHF07YYZChV62GTU0tNR60lRxpQVkH5g2QjNwX4H7y9lDB5rnHMkp9WsXfx091lYSF//VakGEbapACDG5o+pkFG4vpMiLnm5ekfzugkp2UNFL+WeL8xa/9KYo2uqksB9x+MB/uyZ/cjdfdsk3WvI22KiSpDST/J65KjYfB9M+ZhpfZMMs2kZi9Cz4yFJgJz7b0eHjlQ2MTWwt1GU6NqUisLecMQeefxG4T1dMa1iJzuWJoNwJHLVyxOO/XrMDPEqFEUr596wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cA4PTsQ2pD7JPY5I47hxY4AHLn1jSjqv2mSGN20nFq0=; b=iHfG48mHnYC8EbQL4lnk67Nv2VBvsJVBDrMN/z6UM54KbsoCJGYy+pKOtptdMDq961GYLDFAg2OdO4ZvCQsh1h5vMJRUVMxPpDGGrwDDYtS5WAwGJvADzwDtrrKZ+ku4gPvy1oESHlvg30i418NZ101FdNj6v/xq7NCGeYjRi4W1hyO3b/6D1ucr+YQwBT0i5XKXdNo/0In36uHjRrGhuO0tZsHIdQZjwYn08NheyooEeeYhXBH1jJhjBC9Uqc4UiPt2Ib/fg37HUQjcJRY39iciI6+hFio+I9mOuJM1yLJAZaPJg5/1glV28adUSji599FuWSdyXzeQLIiXC7Prgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cA4PTsQ2pD7JPY5I47hxY4AHLn1jSjqv2mSGN20nFq0=; b=VieNTRFh9zNelzwWraKMS+el2+ZC2Rqjk6zEpBwohvd/xqgsgf2rYIiMLb9tN8staY5ayMMLWr1nPOZeQGBT/T762i6cdeNDBSPlSDMynWMIQUNiKUBZNgmE/Y9Zjo78rMZVE9bu7ZN7gvfYVu7Z3KQZzZ6aUMTxwY7lrEXBM/PHg2dRp/SemI9g943RvLcNlioJqoj8KAKAoPBlXHy22ObhzDkf5IjFKpf6hog3hivN5WT4PJ1r1duS85g00UCxAphozAMQizL41rH6m5CUg7f9hLebw5zPy2B1DGEC4TmhhYZd7QqbAkcbCGyADf24au4zFKFnSh7awEyj9yfDXg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 20 Jul 2022 10:13:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Ryzen 6000 (Mobile) Content-Language: en-US From: Jan Beulich To: Dylanger Daly Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper References: <4c3976aa-dad4-2707-2852-9b26593692d0@citrix.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c50d7c5c-39d8-44f2-f744-08da6a27b4ce X-MS-TrafficTypeDiagnostic: DB7PR04MB4604:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RaDqZMBx0i6w7lh1Z6dgFVu7LyHFzUmL6Vn8fK+NwZkM/YrWH9bNTllO9jzAywlhRar1jLEBH3PXCuGq9WyZdNmbW4j+XYNoAWQ3mbwemc5K2O27C0LFXdZaQVrFMLRuKFxeWR6aYRP2pWl+bcBjMRWWbyyM5tUPYbXgQmyfQHHssZR6ii4zoES05JAVGTxYj0m5cvsRtpLBCt1u74fOeIQcohk6vUB/DbRv9Q/PxH0vWZ6vUtEbwVfgw35QVqpi/8sRlttyg04aLikRH+buz/8nVmwgIqKOwOoM/9ENYYQgeRYi2JIju4AoM7pJ4Rmj0uAL6Q02jBirjFAxy91jDwBUsf+9iXxlNXF0Yg02tto5v+6BJoigGr7Tu6FkOgJcF9C5N8TPY6ZVMRXRNmT61v9XpwkQNO2dGWXWQY6O1n0XRYYQm/uL/2vQPdnVBcd//owu5q0QH5HrgGUjZMUrHT0CuWzCaPUlepqXbEn2kFIX+55gGxrkfpPGZx6Ihl6zvIJEBDDXTAa2hv9+psZ/MhXdNwc1ZkObqN7prznQu8GJ9dNkIx8ZO8KyjKfJgKPEQwjIEI0wNABW6QubpGjbriFl/acYSNCSAGtp7LEgTW6Yj9s4miBlENzZKuwYd+9QzSPNPQBjGFBWwT3uhlNhjqDMn5ido401Xaz4wEL79U+V4Dbi/5fm4dDgksNmBkr9m67fuxj9zygTKpJcwqhHwevhvMy+kdIbaIgmuxXWw+GDE28U/flN9W/5ipQlPnaTlhu6DDxguTnUX8M5BsmG4rgK0q3PjyuB2g1FvwTIE/rmisPrxfMVOk6r+FOgpZ3sc991KQIJSVD7FYgg1kmrPg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(346002)(376002)(366004)(396003)(6512007)(6506007)(66574015)(2616005)(26005)(66946007)(86362001)(6486002)(36756003)(478600001)(53546011)(186003)(41300700001)(5660300002)(54906003)(6916009)(316002)(38100700002)(8676002)(66476007)(2906002)(31686004)(4326008)(66556008)(8936002)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UW1pZURVQk14K1FlVnR5bHRwbHV6OC9yc0E4bmM4clV3Zm10bzJIaVNjZ2FV?= =?utf-8?B?cm9yNmpCYmc0K0lOS3gxc0YwT3RSSmlFNnhLUWswcWpBbTFpWDg1cU50S0VW?= =?utf-8?B?UlBxYlpxUlVBaFExeHVOaUY1akNGUU8wWHM2L0RHczRHUlcwTlZ2N25UUjhE?= =?utf-8?B?QWYzN0F1VDkzTU1STzRxcTZxYWd2TUluK2wxdU5aTEVvOTNsQlo2M2FtTUdX?= =?utf-8?B?YWk0S2FnZ3NXNUQ3TUpvcVBMaUttaWtob1pGZzVSeTdzYlJaNjBxOExDZ04y?= =?utf-8?B?WFY2UGh3TDJRNzc0dGdIcGxVK1BRdkJWdjVwSVlUdnZncVpUU3FaYTkwdmM2?= =?utf-8?B?ODBaSWIxek84djJPckU4ZUxIYTJMdHJDMlI4cE8zem1xVDBXTTBiUithdmps?= =?utf-8?B?cXNaUXl2MzlBT09neUdWaTJEUzQyYUlCSzZvRmE3RWFoRDlzOWltV05kUUlE?= =?utf-8?B?V0lydDFJV1VINUtsYmNmRkNmc0p5eG5sVzZuU3RwSGF3cFd5QnRaVFNUUnlx?= =?utf-8?B?bDNVMkhhSmFpSnVjZEVWZ2VhOFhDMGN0dVByVkF3blU2V0QreDRLMXgwZ09v?= =?utf-8?B?SEF3WkFhcTVCcFl1bDF0dC9NTGEvZ1dNeHprNURqZHBBbHFmcFgvOWRrVTdI?= =?utf-8?B?emUxby82bXRVckJWaERQVmxCZHJJcnZzbDhoOTJBK2RGclQzb1BVK3FZQ080?= =?utf-8?B?ZElvbzF0NlN3d2pEVjQweHhQdUM3ei91cjlwYjNmQ2Q4dVRQakU2QXVDOEl3?= =?utf-8?B?ZFdzeUNuRlNRYlZ2QzlxZFBsNXlha3NNci9nSXlPQkN4K2IrR2M4OHdudlB3?= =?utf-8?B?S2EwSHRxaEd4akhGelIxOFRZUUp4b2lyK2IxRFJySVRPR1BiUGhBS3RqbzI0?= =?utf-8?B?YjJjdzdrZlpCT0FYVWdRYXEzYmVUMVF2YXZIUkpIdWFMVjUvNmRWcW9XWklX?= =?utf-8?B?bVRYNlRSNi9HdjBBOW5PSmNxRG40MmJoNXVlT3Vuc2M3K2lNOC9ZOHp5MXR3?= =?utf-8?B?R1dma055NWVWa2Vra05ubExJdkNNS0NxSmN5MVZjbzAxZkJaWS9sZWYrZXJB?= =?utf-8?B?RThneml2VnlRNHJEQnNhWnY5VmpDaDRuU0JMLzVLMnBxZFpHVnVzOHV1MGd6?= =?utf-8?B?aitBS0luSElYcEVsSWhZYjlDd2N5TE1CUG05OXdtaXplVnhpYXVGNDZSem5J?= =?utf-8?B?d0FhZ2Y3a3J5bVdqakNXZ2R1UnZKK2FKWi9OajA0bklhTEVXMlZCa0JJVFkx?= =?utf-8?B?bzkyVmE5Z3hpNWI2RnVLU2FDamhmeS9xU1NURHlKTWx1Tzhxck1acWN1MjA5?= =?utf-8?B?bjlIa2tISFRCbm92dlA5ZVhvakZlQkpUNDh1Rld2TGhnUnhBQVEybzB0VTlU?= =?utf-8?B?bUlhd2tCemhsenUzODM4d0hRWFhidHphOUZNWFFCN2o1VDNSV0paRlcrR0JP?= =?utf-8?B?OGp3VkQ4VWdLbVN2Y0oyemIzY3VxZ0ovOWFRTHVla1BVVjlwdSt6WHMzUTBC?= =?utf-8?B?TlZZTmxOWEl4MmY4TFFHMTI5S0VublJnMElOYy9LRXZ6b0U4cmt4eTRGNGZ5?= =?utf-8?B?Tmh4TFB5cnR0YjE3MjZlMWwxRnV2anZ1bm1ZWVowajEvUVRxK3dVMExXNDRE?= =?utf-8?B?TWNQclJHdnhveXNOd1dDVWdrQXhlSnVqektQODlNeXN6OFR2c2dKbCtabkly?= =?utf-8?B?eFRiRHF5dUVTSkswT2pLcDVEdElmWUJ5TWpTaE5vbWdxdmtBcGt3blRDbnFY?= =?utf-8?B?bnd1UHMzQnFTbEF0VWxoajlrRjJpb0NWT3V2QzdUb1lLMVNuM1dVSDVjYThz?= =?utf-8?B?VnE3QkxVUXhRZE1xeS92TEowS0Q1U0E5MDVNdktNSzNoKzBLeVV2UG9JTDdT?= =?utf-8?B?bjZFVE9TbFhOU0ZrWjVUZndWblY3TXNHL0JMS21xa2JjVnZDZmVyRkpGTVk2?= =?utf-8?B?Q3psL1hPZXo3b2l4OXp2eDJtRWhMWXViZ0dueFVMb3RmOTRKbC9lcE5pRE1F?= =?utf-8?B?OTd4eWphYXcwNG5ZcDZiSWU2MCtKV0Q0S3RXT2lLQ291WEVKR1A5L2RlOW5s?= =?utf-8?B?eG1UVitqVzdDdWtteGh1SG1VTy8xRnhRaWNyeXZQcHAzOUtZVytaelJoK2Ja?= =?utf-8?Q?rFqYvt+9cVXnhG6iY+yr0GMoC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c50d7c5c-39d8-44f2-f744-08da6a27b4ce X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:13:19.7171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k+xVtX0n4CLg7xVcWnUDwezjc0Tq3+LE8dFq/r2boLINwmUn0zGvCxQAgr58tt9EC3YSOxLHQW1FT0uxehiVNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4604 On 20.07.2022 10:11, Jan Beulich wrote: > On 20.07.2022 02:33, Dylanger Daly wrote: >>> I'd focus on the booting issues first. And I guess you can take a video >>> of that (assuming that a single screenshot likely isn't going to be >>> enough), possibly with "vga=keep" in place (albeit that introduces >>> extra slowness)? >>> >>> There's also the option of using an EHCI debug port for the serial >>> console, but this requires (a) a special cable and (b) the system >>> designers not having inserted any hubs between the controller andthe connector. >> >> Do you know if it's possible to have `console=vga vga=keep` and specify a secondary monitor? This would be very useful if I could have Xen log via a secondary monitor, > > No, if anything it could be the other way around. Xen wants to use the > (sole) VGAish thing in the system; Dom0 kernel and Dom0 userspace (X) > may be happy to use any secondary (non-VGA) graphics card. On EFI it > might in principle be possible, but that would require (perhaps quite > a bit of) work in Xen. Oh - and then likely still only when there are two gfx cards in the system. Otherwise we'd likely get into card-specific-driver territory. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 08:19:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 08:19:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371461.603386 (Exim 4.92) (envelope-from ) id 1oE4vm-0000Bu-Ng; Wed, 20 Jul 2022 08:19:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371461.603386; Wed, 20 Jul 2022 08:19:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4vm-0000Bn-Ko; Wed, 20 Jul 2022 08:19:42 +0000 Received: by outflank-mailman (input) for mailman id 371461; Wed, 20 Jul 2022 08:19:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE4vk-0000Bh-To for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 08:19:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b32a47f0-0804-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 10:19:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7923.eurprd04.prod.outlook.com (2603:10a6:20b:24b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 08:19:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 08:19:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b32a47f0-0804-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jyEXuDD6RnCpn7gz+8xQjhXMaru+6hfV1sBNj200eiw8H8hczmCjMMpq7R9/S7Gr42EzaKjbV45ZVBN2pu79DJFWKf6lM4gHZOO2PuAvyBIKZTRW/+dDgTkZUiSviYhfQe9oaZBtEmfUjBmdHDcYPSZ//mZ8qdRUiv6OCw9UxcVKBozQgOKXz3BNL6IHEffLYGCPbiuU5/UsJ9tl+mhFvlAnbttu5jECKA6K+4ENbz0szj6BIm5Yhxw72OCBJJjfSHizSzbPqclQwBoW0shGPGr1ZZASfmwfK9cvELSoZxjn6AzgX4D/bb8c8vDC4i4vUkMFpZqJ4uwSCxrLkczWVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T3qwqajteK8X3OW0YwCJ1++ZMwIZAiGjw8tuRQcVOKA=; b=oUc8oQIX96jcwQc3C8Tf13/wOOWN6wKTlNyl5YyWRr5JfGPDXm0QrHsZap5RBTYPL6p0+zdL3n04qkJZo3mRtmXbTZ+Mz1C9Hvpnb84bot47RtTl/K7N2KYnVgXgDpU7/p1Rlqjp/9saOyK660fO17HpvzpkaT2MQsXAKuggS2GR7HN8b2wtNt4HiU1Tt3wczsDzHr6ZJd9dykqma61mIPlZk60XZ2wGMlUs5vOpWNL040Os9Zrm0S1OkViFoEGgZaFwjFGcXlCZ6Rvaq2U0ZM71edoFgJxjwzYZIdEwn0lanHWXGJOXr/hFwf+WhdLur5ETMjlxkRs9CmH/d+qQDQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T3qwqajteK8X3OW0YwCJ1++ZMwIZAiGjw8tuRQcVOKA=; b=E2kVhg2PzM0tsgVeDfLlOfvxlt196dP/mljumJ0Cs3IusH5pux8WUvEB9D5NxuzRCC5fdedDN00Va8AWuCN24ayxTEtPBi/frooir0ZN6IEcNpQin507EQoLLK7urjEbA5FuwU80DsZRLeLj09U3KAN1ODxCULP5OvIqUIBd8v+WQo/0w60jy6bEZrfuCgcVPoWj43iqU+HeoUEo3ukvkjD11j5h1XIINeqX4KAjuSM6pyaXs3CI3ar5JDYN/VZ+nlMpHBbQK3PtXrMg4UI2nXBondpDuKKOyPanlP1wt3ySrSTwnjtNOs2yNjwmkFLobsBQt70su3iDnhTNy9l8nw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> Date: Wed, 20 Jul 2022 10:19:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US To: ChrisD Cc: Michael Young , Andrew Cooper , "xen-devel@lists.xenproject.org" References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> From: Jan Beulich In-Reply-To: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM5PR0201CA0007.eurprd02.prod.outlook.com (2603:10a6:203:3d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37de2691-2a16-4d9b-c942-08da6a2896a3 X-MS-TrafficTypeDiagnostic: AM8PR04MB7923:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yVLVQ5DCLEFDR7njv8eRvQwQchW/UIGufGhxsygo6tW4YyJsgxc597aelcWxCUjl+1UKutXMxsZGwA2C3CWmRQabX13oPYJKzU3LjCe/3uSUgErsso9zA4o9GSoRBTu4AXdvO4LJVbDXPsdSharA+vjMThHQ3rDwHThBuJ7H546f8jVA5w+nr8N4JHTOVY+wljzIzoQiS3dqPeOelZL5CTLxvtGOdGYljuoy1MFHwc15DLXGFzw4Ysf1yIVMZHE1wx5XW2UDTSuog2ttH3U3t+mR44EbXy7Nyrnn4liEGCnmCWm9iWdtLaN6dygCL29xsfGEjLNn47jD+MvPXu9m437yOqwsHKYron/IoekgROgmjdjhmtdgERN2DPiU1kimY3O94OxQjVH1CxJriqGgyWikVZfzRcYDkmWbt7WIJmsbR4W66iDN14YOirJi7raQCy7r3p6+KNmcIlAyHQran30OoP/d7CKey0MvZISw+3kgz5hQ7du/EHUvAtahz0vQ0KYz8X0Wo49y3palNFtEmD1yiPS35a7UpsByeip2ECnPgkev6dRq2NKtUkgkjh4QmA5dYrPbKSm0Sxyz/cmst+CNRWZAsSuDRxF5g/L8Yfn1jPxo2szTssXKRFBpH9JmRcWhcq/dr2XGL5WPHw0x+7SS9gJHPS6YqYqOmDGYCMLTJP8e2Iz+tAGs7ah3BGgN1eWCENoXDaLnBBGs5ww1D4mzEh+xTnGfTtkcVLAvHF9p6HENb+FlhlLmyWyCGIl3EAEMxgdCMR/qhjhtJSuAOSKU7YuJIUrLqyt+ojlXce8WBlO6YwzHyaugRUmJlbWcVoRLBDrly8cWxD1FKms/2aecuJ13vVLVQ1Zuj/ccaYI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(39860400002)(346002)(376002)(366004)(5660300002)(6486002)(6512007)(86362001)(8936002)(2616005)(6506007)(53546011)(2906002)(478600001)(6666004)(31696002)(4326008)(26005)(31686004)(41300700001)(966005)(83380400001)(38100700002)(36756003)(316002)(66476007)(66556008)(66946007)(8676002)(54906003)(186003)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Yk5yTzh3ZS9xVEgwZUVZMmhwMFhCTFp1VjlpcDNwemliSXJDS1JqaTczbTVS?= =?utf-8?B?ajJYeDRnVTR6UFkwb3AwN0lhNFJGTmMwRlFNdDAxanpvZVo3TC9tMHgrMk11?= =?utf-8?B?UzRZSi8rTll3RGxKeGtRMzd1NnAxQnVqRXJ5RlN3VnpIODJRWFZlL0tRc1p5?= =?utf-8?B?QXhGTlE2SzhOZ21PR3JxUzVjSldENzdSUVArSDBCNmx5d1A4dDJlb2lxTnc4?= =?utf-8?B?b282Rlk0WU1GUzZ4UUw3SnpMWEVLRHRDREsrU0FsN3psUG52dEpSYzZQMzZy?= =?utf-8?B?VjI0anhKMjVIWUpSSFI2T3FZNEJLVDFJR2VoNVkrdkExdUM4K01kUFRUUFRP?= =?utf-8?B?MlNQR0V2V1FOTFlYdzhQUy91NmpWNkM4VjRFVEZUNGRuQXdlSzhTK09HS2Va?= =?utf-8?B?WVFpQktENW9yd2ZZTXk1OVpXdHRRQStsbjB0OEF6K0NYb24wSEFmK1NaQ1Zh?= =?utf-8?B?ZTlYbW5qMGFvNEl2MlExUFE5SG1RVmU2Q1JxNzBPZ0FrajhFWDc2QmMrS05S?= =?utf-8?B?VmRmRUpGbVdINnQ0SGhuVHlTWVMrWWtma2FhUktWNllndnVncUdIZEdXSWR0?= =?utf-8?B?ZlVtMUZuMHhvME9OY2ViOWlZVEFXdkM4QW1ONUsxZFFucjVJWDhKOVJpQjVG?= =?utf-8?B?dzJxQk40c3ZVMnQ1azkxaUVUd1JlMTRoeHlkdWtvYjZpYjgvOVhhZHVsSVBn?= =?utf-8?B?MUZBS0t1SWlaYVZ1MXBSeTA2Qm1DbCs1dy9jTWQ4T2tibHlxYTl2ank2Sm8z?= =?utf-8?B?RlVKS2ZybVVTbkF2YTJuVitUU3d6QXk0YkRGRnYwL0hKWlJ0WWFvaWRwOVZj?= =?utf-8?B?Mk01V1NDR3hVTy9WZkc2eEp0SVFMS3JWUkFsczYzYXIva0FBUFVjSFR6T3hp?= =?utf-8?B?bnp6MFJTYWNTK2NTMGxBb1ZNSGZLdTI1V1NJZmVoWWdxR2Z3K3kzODNhMXhx?= =?utf-8?B?Q3ZDcytiY0h2Rlc1cFdiVjkzdjA5cGxic2VKVVNLeTMzS3oxVUlZeDByMkVP?= =?utf-8?B?d3hDWW9NSnZmVG9yU3I2VEtueitDNkpRdlNTR0I2Wnc2YmFNbXpQRFdlcEtQ?= =?utf-8?B?dE1hT1MzQ0lQbDBhOFBNQlBibzJROW1ldE9iYmIva1dGT2E3RnpyL0h1em5o?= =?utf-8?B?MUp0emlraTA0U3AyMmFMV2xKUU4wRXFQUkJHVzZqdUtTeHJYVk1GTGJndGQr?= =?utf-8?B?cG9DZnlRVVNianRhVlRQd1EvVmlIVlpMbEZOQjQ4aGp3Y3FrV29GdlhQS1Rn?= =?utf-8?B?ZHRMV3RQU29rZzJWZnNFK0tsdFJNZmdzaGViMDBxV0FTeHlaYmRJV2lSb2ZJ?= =?utf-8?B?cWRaMk5FRUQ0QlNqditpejlCOXZLV2JFbXlyamRMNmluYWZTb3NucVo1eE1j?= =?utf-8?B?WElFNTFUVCtVdWRKd0MwczROZWRhT1RTKzJnREtIanN1Q1RKZCtoSXRZdmsv?= =?utf-8?B?NVp2aWFoZCtUKzNEU0FXUFZlMGpmVlBHNngrZXI4MW8vZ25nUWhwUStnRnZV?= =?utf-8?B?VUg1MHU1RDNESFBxZ3N3L0pUV2wzRHJuc2drc0xBRk5zSjlpR0VCM2t3WmxW?= =?utf-8?B?Smg0T1RyTGZhaXJpWWFCek9yRERmYm1GZXpjMksvUVE0RFE2cVdONFM3NlBy?= =?utf-8?B?UUorT0V0U2FhN3BzSHFNbUxOZThZemI0QzdwUjM1MXhlQnpnZ1RHM2d1T3Rj?= =?utf-8?B?cU5TR09QbUJuU3IwSm1BRVFLTm9wS0RlY25nTElGUkRXWWxLcDBsbUVPN0M3?= =?utf-8?B?RUQzaUUyZ1NjeE1vKzA3OUdEOFR4bXB3aEwwdktiSTR0RWJhek4zc3BRYi9p?= =?utf-8?B?em5wQ1pRb3dwcFhNZjVEZmNvVC9hQnFvTTBaNXdVZXRaOEFFUUVDU3J0ZmZY?= =?utf-8?B?dHR6V251WXcyc21lMERCRUZTcjlDN25LcmFlaC9jeDY2Qmp4eW5mOG9GVEEr?= =?utf-8?B?TzhWWDRyQitFbkFmRWxCYUZKVERzc3BqenRRZk9RT3VVeHNwWnU5c0N6MjJY?= =?utf-8?B?ZUprUVlQNlVHY1hYZ3pWSllZK0xHQkN4d0N6MGszTmJwaDc2MTMzUHUvR1ov?= =?utf-8?B?a0FDcno0a0tGY2VXN1ZzUTVUY091TlBHcFVjYjNaaHpEZldoUDVFb0x0VjNQ?= =?utf-8?Q?eJ/E6WdE5YHtewxlTw9cEyuNP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37de2691-2a16-4d9b-c942-08da6a2896a3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:19:38.5836 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TRQ8n4oK0HUqzl2/ZvfPm3D3FOntxFrG70STGL26t1Iq8iIrpnLsopf8zeG9WH+4zOS+gV2OndUn2AxHm8Amfg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7923 On 20.07.2022 06:48, ChrisD wrote: > So, you think it's a problem with fc36? Well, if that's where the binary came from, then yes. And btw please don't top-post and please don't send html mail (see the almost unreadable stuff below that was how your mail came through when read as plain-text). Jan > -------- Original message --------From: Andrew Cooper Date: 7/18/22 6:25 PM (GMT-05:00) To: chris@dalessio.org, xen-de= vel@lists.xenproject.org Cc: Jan Beulich , Michael Young= Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #= NM[0000] On 18/07/2022 22:31, chris@dalessio.org wrote:> I am trying to run= Xen-4.16.1-4.fc36 on Fedora 36 on a brand new Lenovo> ThinkStation p620, b= ut I keep getting the following error booting the> Xen kernel.> > Panic on = CPU 0:> FATAL TRAP: vec 7, #NM[0000]>> Version info:> Name =C2=A0 =C2=A0 = =C2=A0 =C2=A0: xen> Version =C2=A0 =C2=A0 : 4.16.1> Release =C2=A0 =C2=A0 := 4.fc36So https://koji.fedoraproject.org/koji/buildinfo?buildID=3D1991182 s= houldbe the binary build in use, and looking at the debug syms, it reallydo= es have:ffff82d040439c80 :...ffff82d04043a00c:=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0 0f 6e c2=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 movd=C2=A0=C2=A0 %edx,%mm0= ffff82d04043a00f:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0f 62 c0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 punpckldq %mm0,%mm0ffff82d04043a012:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 49 89 87 c0 00 00 00=C2=A0=C2=A0=C2=A0 mov=C2=A0=C2=A0=C2=A0 %rax,0xc0(= %r15)ffff82d04043a019:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 41 0f 7f 87 d0 0= 0 00=C2=A0=C2=A0=C2=A0 movq=C2=A0=C2=A0 %mm0,0xd0(%r15)ffff82d04043a020:=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 00So hardware is correct - this build of = Xen is nonsense.The binary is also full of .annobin_ stuff which appears to= be some kindof GCC plugin for watermarking.Michael: Any idea what's going = on here?=C2=A0 Something has caused GCC toemit some MMX logic which is ulti= mately why things exploded, but thisprobably means that some of the build C= FLAGS got dropped.Thanks,~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 20 08:24:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 08:24:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371467.603396 (Exim 4.92) (envelope-from ) id 1oE50N-0001bm-EY; Wed, 20 Jul 2022 08:24:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371467.603396; Wed, 20 Jul 2022 08:24:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE50N-0001bf-Bo; Wed, 20 Jul 2022 08:24:27 +0000 Received: by outflank-mailman (input) for mailman id 371467; Wed, 20 Jul 2022 08:24:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE50L-0001bZ-Hm for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 08:24:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5cb57feb-0805-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 10:24:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2571.eurprd04.prod.outlook.com (2603:10a6:3:84::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 08:24:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 08:24:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5cb57feb-0805-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jl7SWrSZSLCOUoM1ApnEPVcrLS2B4Ezim5LhvDhRPtIKg2jU864P+SqL7J1EEBv2M/RwWq55SXh0XoO09YhzY1smzhf4YcpscSvgFglaP4iLsLe0PIMyP28DAw4Tnr6TuhPtffG6PLzQJkgkaW9yt+pI9qwOdCOu7fL/YTOxT2Y+OHqT+dag26XCPXVl6+W5PEblSRffCuUIbb4FlYm4MDxDDRHfxSeMojhmr/tmVbRQ0ghnSES72xfpj+VCYTBzE9upSoEpKwZldMblp5w1x/JnCa0Yia+8fhVq9hJRLFMKUWqZa4EDJNkQJb7ZsGMeuqClAm/vRL9KyrHwQtmpEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xzmXbFtmrfDRl7nxXTjKH0Kaa4+gTp7pyd6cPEpRONA=; b=a6VvRpmdkG6jgaKpp5WtoLVTjKMbNVbaO7q0TvmDmVlDB+nIteYnYUhRf+Z73JJJmAv7VLOI10OiF3WLk50wA0tyUGYYnFgVZ5bLh+DU0GDkJDIq+Z2NPGHJHxdmXKupRKdMl9SWQU2L4MzAvGqfafLownAQn+CcoSY1Q9arZydD35PGg4K+2vTk7kFbPh95T31uORPtK792YqdENkpTSS9I0FTuZaT3FqnxnZvyK37SCfCOZWB+Lb5nvbUFsxIkfkNCU0EBjrgFI0HVdIPDJCPzB4rm2/6FxInMErPYzJql7XxShWDeYqqHzVGEqB6ueiB2WrUILyG05e0yxMENNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xzmXbFtmrfDRl7nxXTjKH0Kaa4+gTp7pyd6cPEpRONA=; b=XQFkB89Z7rArujs5mhSFYzsQUc1u+TqYRQ4ql24Irdc1NeRnyIgiM8FSuW7p9T66T7m/2F37oVYY1mtTBMVY9VeqCOWQRUDYGAH27ITvU8ZmxFAIh4iJh3J8oKmonAhKW7mCkeR+xvprqeN6IFrfWpyavdHgpo3n5OUpJM76K59yHNri7P6uuZdbZV85bH6RPzUkuoObPhudwMCsUvX2A8jQwsRfr3KmqCjFv4Vtz34VKh6oFYCnS4pZ69xsnp3tYnX1pvhm/DuZFgW8Q8/+C/yS0nOehVYmL8TCMQhTxfkRnSqzZSt1C17r4bNEfss6vilehLx5HBlosSuhrrR37w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 20 Jul 2022 10:24:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/mem_sharing: support forks with active vPMU state Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap , xen-devel@lists.xenproject.org References: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> From: Jan Beulich In-Reply-To: <4f3ff38d8226d10dab3440f020c9ba7f07cab1fd.1658250756.git.tamas.lengyel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0083.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: efde0002-63d9-4cc0-d352-08da6a293fc1 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2571:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u5eXLbaUXLm1T4r0NZvytqJO03KJSmNYY0IHzrj4haDjqnObeghRummlOw8Sea3lf2B78SRdtRLxxV5InpFJn5KuH8C6PhBX0IZjNo37Vp9IQA5i6FQMQDKNdekMz8KmEZKnK/HBb5bFb8C1zJnzlA8IrP4YXqPB7C+Bjw2WMjVr+JZOGafhYJ2B4qkWLWg3FBk+H+gcz46btGafoq7N29UXP7O2QiM/TUATbBAmgqM+UKYc8vv9YN/kIMAD0u5/POMT76ACOlvOQAKIbXVrBUw4mMDL40H4KbwHSwXefLvNHrF7WcdBx8+AL/M2kr8z0oPM5F3CnmL1bs2olFMchNNQvOj2381K1opF7B+WT0EC3EFBuBc3YFApOHAcld4gVNtpxWUOEkooGufmyvGCDYTqUPWOgFpvTQTQHFhfj1egJlJO8cRaYUQxi3XOC6NMoGKznP7f51caIreST5h7DSeztTpFsx+JEJn9jYJ22KB8yu1dauNUg5HTxjaZZW+w+JfBM6w032N1r0x6hX65uLwOrV/i9YV7Hiy7O0CApAP4UDbKnV5NLt6+TQrIt2bIbDaW8Mxixk/1TGzBV1JsPVdN7BWReqyPNsnLSCW7/wWyhUmOpBlCwiVY6mmLz+G4bBPCyDg3Khb5wBvB9R0j3Ajc4fsK4jT2/tFlCmxtu+lnVH4b+2CH8wcSA2jPuXGzPDueV2DqVQleZvDr6pPcdeiNguC1ektsnltNjR2D39i30djMTndad1rLQ7FyK/mG4JCa9x7pEbS6a4Knymy9PycuP4S20TwVk51BHxTltewLOROSr0RF+l4XwaKAaxbRf8N93dTe8lT9xzcDdX1vcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(6506007)(4744005)(31686004)(53546011)(41300700001)(26005)(5660300002)(186003)(6512007)(2616005)(6486002)(478600001)(316002)(8936002)(8676002)(54906003)(4326008)(66556008)(6916009)(66946007)(66476007)(38100700002)(2906002)(31696002)(86362001)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0xZclJCLzFxN0JISWNBdjVDM3RBZHJrUVlHRlhTdEZZdjhJeVpjdVR0MlB2?= =?utf-8?B?MkNFRVVLaVBLc3JMbXo4VEQ0TDkvblZFSWV0MlBGemd4UWo0TE9wVFE4K1lN?= =?utf-8?B?dTZvcDJTTjVZMC8zS21BUFp1Zm5tejVZMS9odFA3TGkwdndJaFdkRU11a1dD?= =?utf-8?B?YzBUTjFXY3huSnVwQ0pJSEtsaytaRGV4RVlBNDVpOTJXbWlseGY3U2ZjcTVR?= =?utf-8?B?TVB0ZVlJVlNONERoRkFMcUsxVytVYUlNckhCeXRvSVorUnNKSzdGb0dtMWpC?= =?utf-8?B?Sk55dzdTbGZOQnZ6aXBWdnF6Q1hiZTFQcldEaWZpSE0raVZqcnN0OFgrbFdG?= =?utf-8?B?aGVYM3NIOGN6TmJiQzJrNVNFUDF3azdWa1ZUaytGdlRNVUUxTHdFa0E3WUZn?= =?utf-8?B?NXFHbkNHWDczSlQ3dkhkbVZ0empMYmRPelM5R3FuNWQwWGt2Y2ZoUHNsZ0tt?= =?utf-8?B?VTNqU0ZFR2dKL01jaWhoUDJUWm5BMnlCR2hRZE8wS2Y3MFV3QUNBYUswM1JV?= =?utf-8?B?cVBVVHVTWmd2NlhVNFFnSzh1WndlOGh1RjNwMk9vekVFY1I5OHk4ZEJLQXlX?= =?utf-8?B?K3lVYUMwbWxtb1YxbDB1L1o5V1p4WmY2NTNiRURyc1ZoUFRaNjB3WEozK3pl?= =?utf-8?B?YUJ4VE5WV0pEY1dsRHNZcU9kd0wvZ2JoL3JwM3dWSGNZOWJ4UHZ6bit3WE9n?= =?utf-8?B?VFVGc0l0ZXM1aXdLR1p5cUtkazBRaDE4MFc5VExtOEMvejVhUGhUT21XR3lM?= =?utf-8?B?ZTc0S1p5eldwVkloL1Z1d1YzYjk0TVRQSU5VUFM0YmRDV1p2eGUyMGhvR203?= =?utf-8?B?c0xUb3hKd2FqU25pOFdyZUY2QTd0MXhmSnZZWDdXQVRGVUhzaXcwTlJRY09w?= =?utf-8?B?UkZTMEZ1cW9pemdMeEc2all3bWZNNGpNVkgzNy9WSXNHcDVBY2ROZG1aR3F5?= =?utf-8?B?RXp2OTJXbkY5clFHYll1WkxBS3VMbFoxMHhvV2I1UXNNejdNS0lQbmZsUkw1?= =?utf-8?B?anNadE84THQ4S2QzUTZCL0JFTWJiNjUwS29zZzIxOEJkeGN5dEhqTFZlcS9o?= =?utf-8?B?UkRRNmZkSFo3TGR5U3psN0txM3BhUU1lS2NKUWpUVFZVSFVVdG01RTV4WFJH?= =?utf-8?B?dDRsWWpIWlhZeWFIYjc1dUZoWDgyS0krV002V0VMbEpPTVZXR2cxNDFDVEds?= =?utf-8?B?ZG1BL1M3bXR0dGM5TmYyV3ZyaEtFcDhqMXVUMFRHendxSnFldHBiQnNMcUNv?= =?utf-8?B?Vm1TSTh6MDBVdERvd2ZUVjBkYjIzVFAvYVNiZFhFYjhXYWQ2UThzaU1yZ0Mr?= =?utf-8?B?eHNmQktsVlNGb2FITytKRGdmeitqTFliaVFndWJzYUNZejdpN1c1bVZsK0k2?= =?utf-8?B?dE9HZXo5Z1c5RXJIQUh6TWJobVhwM1ViSURVUzRIUkd4TjFDeTJCSUsxNjNv?= =?utf-8?B?WGtKa3pzNnFaY2NqbCsvZTJLaFk1Y0IzWVBXYXArcFdFb0tmdFZhNC95akFH?= =?utf-8?B?VUF4ZFM4aGhoeXBSVWZseEM4TFhhc1NSM0xORVhZQ210KzVzOThrMTFTQWk2?= =?utf-8?B?SWxweXkxWU5ySzkwK2ZRUWd2aVI0RVM5dkd2NklUTjdXQTFtU2tpTDMxSjRu?= =?utf-8?B?RGxHdUxvSzY0UDcxWFBzSWRWR1pWUnloekVac1dGMWNTdmFPajMvZmxITk54?= =?utf-8?B?cHJXaTVvZnpsck50YnliQVVWY2kvMk5hV3Q3WW9DNUwwUUFKd0I4QmNHbFEr?= =?utf-8?B?QkY0WEgvUFdxeXJVQWVXMG9SeEs2K2NsODVmMXRYMjl6NHRPY2RtVnBPVGZO?= =?utf-8?B?ZWlpczJ6Ykh4YkoxMEJoaEZ3UnNPa1R2MXh3ck5YbGI3RmRPYmtvZ09udnNF?= =?utf-8?B?aTkwUTJ6RnVoUUtSYmd4Q3BINzJaRjh5OW1tdDlVbTRXeWlrSkZzTDdZTTVP?= =?utf-8?B?VFMvaW5NQU1iUDFSd0NRQmdsSEx5c093K3NmU01nZGVKem1pNEI5WUZ6OTRY?= =?utf-8?B?ZlBVcmo1SjRIQWJxaHVYL25SbnpmTnh2TWgyeTRVUDczTnFENitzanRvNXdz?= =?utf-8?B?NDJHVmdKSWw5dytCTUFTLzY3YlRHU2JLTTZRMnp4dVZ0ZzRVVVM4N0tvSkp2?= =?utf-8?Q?mVs4Rcvobcm6S3e+fLtR94kJz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: efde0002-63d9-4cc0-d352-08da6a293fc1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 08:24:22.2998 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dhu489rwRDk+a7YIdBanPy33OUpW46JHHhZemlELztQrIvghJuzp4MzkuEa3dT5vu0CYq24WGsQqfIWpxdH7og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2571 On 19.07.2022 19:18, Tamas K Lengyel wrote: > --- a/xen/arch/x86/include/asm/vpmu.h > +++ b/xen/arch/x86/include/asm/vpmu.h > @@ -40,6 +40,7 @@ > /* Arch specific operations shared by all vpmus */ > struct arch_vpmu_ops { > int (*initialise)(struct vcpu *v); > + int (*allocate_context)(struct vcpu *v); I think this hook would best be compiled out when !MEM_SHARING, even more so when it can be left with NULL in it. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 09:59:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 09:59:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371474.603408 (Exim 4.92) (envelope-from ) id 1oE6UV-0003yd-Ao; Wed, 20 Jul 2022 09:59:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371474.603408; Wed, 20 Jul 2022 09:59:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE6UV-0003yW-7C; Wed, 20 Jul 2022 09:59:39 +0000 Received: by outflank-mailman (input) for mailman id 371474; Wed, 20 Jul 2022 09:59:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE6UU-0003yQ-4A for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 09:59:38 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140043.outbound.protection.outlook.com [40.107.14.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a760480e-0812-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 11:59:35 +0200 (CEST) Received: from AS8PR04CA0016.eurprd04.prod.outlook.com (2603:10a6:20b:310::21) by AS8PR08MB7338.eurprd08.prod.outlook.com (2603:10a6:20b:445::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.13; Wed, 20 Jul 2022 09:59:30 +0000 Received: from AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:310:cafe::c8) by AS8PR04CA0016.outlook.office365.com (2603:10a6:20b:310::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.25 via Frontend Transport; Wed, 20 Jul 2022 09:59:30 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT041.mail.protection.outlook.com (10.152.17.186) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Wed, 20 Jul 2022 09:59:30 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 20 Jul 2022 09:59:29 +0000 Received: from 0ef1267f4c57.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BE1E66FA-7869-47D6-8E58-9118F2983DAA.1; Wed, 20 Jul 2022 09:59:19 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0ef1267f4c57.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 20 Jul 2022 09:59:19 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by HE1PR0801MB1659.eurprd08.prod.outlook.com (2603:10a6:3:86::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Wed, 20 Jul 2022 09:59:16 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 09:59:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a760480e-0812-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=oWm3KOALTp/mXxN68prjgnE6iWWLc6dfTQKZKKTYsDZJ5UuaObjabE1vjkS8/CCI9+X/Svoz2VE22KQO1xgELvt+Leyb8iNiJN/HbUf9d/wSBgm4h9+02g1I+SbMOcxg2/DZDNLdBUKMJPIZK7FjKvNkwf2H3Y68Pgh/aamX1NG9DtVY+nzz+560RdmQZr6qOkdZK/jKX/EFBkwuubiOX9jH2H0+C785+tH8jlYcOmluUdUlJkpZy9PAVCAyRZA/2Ag3huD7MWFbbBljbLp0xXIlU7/YvdK2zQKQ3lEWmthDw1ZmbVZgQDtwIEr2DoAUMfs7t9r+fOPeX2X+bRk1Hw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waZRSNbw2JIFtxSxpSxziJAbnbk5G9weqWK6chagXzg=; b=PLlclkh5uIR8eoaWOZhpoUGD3IMoFNbK02o81geLEOM44GkJW7HKzn56IUgkXDMmB2VqRXh+IcwR7JHGyeg4HS65/3CtEVz4rIwZnI2+ZnoNVokKgCDCgNtcSLdMOfzDmlpDzpl0dddAfyDbuzRLPq4AOwyiW7kkojJdtd+51A8jLCJtBWRt+XHkWqatatN1rzLriYBajw4H7Uz0YeDs1ZwPG6rJPxpiiArGDnqzX2v7+Q0u82Wgz2mJt1sY1z13dfjHwB90Q1RJcVh3H0wRk4IjIbmutm2RKpfbRG3KDUXuWgr8Gnl8mGeToi00bSsqOpCMo8r+ZFKHBzgZDY9l7g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waZRSNbw2JIFtxSxpSxziJAbnbk5G9weqWK6chagXzg=; b=7EkV658C2R2B+zXpWyILRITDWxohUvyp8JUNkYxjkKmsZnrMVjxKSnV80RbxT9PzZdimqlzuDkV8XaiwLLylJ5+YExRwlqFsw1N7uivcBbQgi073KH1hlCx3/uo3amyJ8eQoep/0GSECvRhmOgzYCO2OPx94xNuPk3bofLiF0gY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8ea63d52ae289603 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EsPdQiTNzXTTT+ABA8OiXot21wlLZ++k6Ofc8tx82FoV305T71zjUGAcx0YXLfvKB9ofzslLqOaBvMOhQEYQAf01P0hReARN6XpkUqXGAQneuklzGRFEPOmkh9gDNG3kjdxkAWKdlPG/XuZjVzCtFb2UEDubJSmOCnHb5OBV4/uSaJF5f1+UIzq35wrRRiaHxP05AjuLuOPXOd9P7xoTJ4Y7sAaG4b9ocEL1iB+IxQBLdPWYXs8LUWOx63HOYCsXUC0GqRJGGlecYDOcxiCsjaG3zKUp8ZhaLwSal/bAnUWSWfK58MXI4HVi9hi5yBJOyRSOsuIgPtjnnL2TT8a5QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=waZRSNbw2JIFtxSxpSxziJAbnbk5G9weqWK6chagXzg=; b=ADNXXo7YeceUFqRQ6E334Hb7jEru9grVN9cGsDyh2dAI2vEkmcyWMHx2BdFoxI16MeQ3+Snj7BpUBFBNZMQgFoX4iPHX3JFlEjSrzyjD8k25bCHa669HNzEMgQ8GH2G/+JPmsTWglUzdefRYGO+TiYSXe4E3t4veOurpeDK7LYH5SSsJCkeOStilIXfyLOsQx0Oi+wOiPDGxoSzpnHOwQnK+C4+Oxsv8G2vfkYCQvgDd66kJzT8tSkA7822YqUoxPTLI/wpiPTc3eXq/NX/YwHg5Y6HRY/snniwyAfVQJK3TlxxwIuNBl8lwtWC52c39NOhb4Q0JyCcPrAB7VKKnrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=waZRSNbw2JIFtxSxpSxziJAbnbk5G9weqWK6chagXzg=; b=7EkV658C2R2B+zXpWyILRITDWxohUvyp8JUNkYxjkKmsZnrMVjxKSnV80RbxT9PzZdimqlzuDkV8XaiwLLylJ5+YExRwlqFsw1N7uivcBbQgi073KH1hlCx3/uo3amyJ8eQoep/0GSECvRhmOgzYCO2OPx94xNuPk3bofLiF0gY= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AAgAAEsgCACtZcgA== Date: Wed, 20 Jul 2022 09:59:15 +0000 Message-ID: References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5e7ba93b-588d-421d-ad3b-08da6a3689fa x-ms-traffictypediagnostic: HE1PR0801MB1659:EE_|AM5EUR03FT041:EE_|AS8PR08MB7338:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Rf8rSjZILAI18uEuT3srC+1FpnlwcuQw/b/9tjqQ5x8uVkJRg81Da+jkbx7kOmrA6HX5WixFtwTqkzFaBgK0TpYd1I2Mj8ORf5KXK6RqEaw/sbv8DBRkqN8zo/pmGpHVCr5mfaOEpJXDVWLKfMvPn2jVr8fXLkv05RvhTUH/hbpjEZmQ7ct6nQgj1xTxOYOe+vwWxWr7m8EMNVjQShLZZGzp9liiB/zy2WYfR19LUn67NIlFV8spm1GJQB8K/1CpyJRlqm7/obciykFPlAZRi0nq1HjD3z7ZB212RsygTEZUOw1NyVf9Au5vX82BIMvAvgRdIWSfJEl/00FB/9F07cncdzQXDif0fEu8D8Jf+JOPHjVTRA5jB/3a8UMlI2rElAE7fdUgSe//TZvM1m1XfRvrccMbXU3tFUh9C0nsjeRu3MXFJxtHEekrSJJz46NaZlBeqBM3pF32UiaZi5YA8SN9FU+Wzs3yDiVAFaX7XwzuP9XEkm1kMjAIvc95Vg7srFMtQdiUeFuuSjW7axEICqsX1PPdZvnOnzSw6jDkOtkcbmm5CHiNYCTiTKw95X3KXDijHsjD0o6nA7GRfxFkVta1PO6oP+4WsFZuaGFdZxW5d6QWKtxvvkV3P7Jf9L9t3iIzuY4jdMyyFXUwi6G3jetgegPfcpGdc1u8NsEQsHXA2Iitv+ouA2LCGQ1SZKxZp9KibX+AUMeL96oNUUECPOPIZk8welY43QyROPxWDkOiKmoETvz+rr+VlbcJD1c73vKc1S9vMoy/rLuXTbrfxXY5cVchnwpQDilps/ty8QdHZTUKAy41P6DoaEW49m4G9ljxX66r6W6Cv0/q3LifPg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(366004)(346002)(136003)(376002)(66476007)(8936002)(64756008)(66946007)(5660300002)(4326008)(66556008)(33656002)(76116006)(2616005)(66446008)(36756003)(2906002)(8676002)(38100700002)(53546011)(41300700001)(86362001)(478600001)(71200400001)(38070700005)(122000001)(91956017)(6512007)(6916009)(6506007)(83380400001)(186003)(54906003)(316002)(26005)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1659 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 587dafac-2133-4c52-b3fd-08da6a36817d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K+49hf44WX1RIbAlEbK9XmJPZ1bY9WuDTbQBN83cwpNLiVRFKxB5zV//1vjda8EcTNzUnreU7Jtn1dKRJoIB/ZhZ1yOU52WrarK+2GABQDsytQjv3bgtxwg3+CUynm/3zFTExjt2ZuK+8kwWbLlH9caR32LiKZwXCw7/4a0EVFuuJgJ7SIsRGaU/4Qbx4QLfx5MfrpfFS3NSuGVGYAbgue0/BevgAN1Eyy5g/hvsyx0a5i+srPeasmjNLZY9ocQZw8nfI4r46tfRSh6Pefjd5IRyNMqRH2SfNRIOOvkOuBOCgMaT/2z5o5A96G2i6fC/x41PG+v2m8vHhu/iw53AQ8giJDdHBgrkLT9rmB0p7h3lm7LPKc4IZGSMnPVf0doH/eAEtdmsi2XtTKtg2iQVjm/Hy7C2ZvvFgfJ4v2JedtWllJKUHeVETcxbywjH/jyR+RVAKxJSeZRmcgitzwPSWi+BIfltSVGveQ68dt0pKhu1TGzj8dySV5q5JabdiPDHiu6nHsoOkPacEcHoJ3W9WpQsm0sUV0ODw21/X66HVFYEDWp0A4IUn3Nw9egRQgiWYPYHHzsiurV/YvCNl0++y56SEWzKhbs2L9nfJBidYJGmD/u2Zq56Ckst737YzyAR0A1ir3xJWFn7xymHZkYUHs2mgyNmkowkQYVTCf9kQFe0dP07bLZ7/ErFrm2OirEirXPr0AviOl3T88bUf3ykZNXH51snuuzD9TqAIV3dYLSAmMP3j5QloybSH5Y9QbW0L88m2ngbNFFyqZSSw16wTbL8HXikFojRpbQa5Qj6IB7ezfqMUO/WTeMfrKtA6e6b X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(40470700004)(36840700001)(46966006)(2906002)(83380400001)(2616005)(40480700001)(47076005)(356005)(336012)(4326008)(36756003)(8676002)(186003)(316002)(70586007)(70206006)(54906003)(33656002)(26005)(8936002)(478600001)(6862004)(53546011)(6506007)(41300700001)(40460700003)(6512007)(5660300002)(6486002)(86362001)(82740400003)(82310400005)(81166007)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 09:59:30.1377 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5e7ba93b-588d-421d-ad3b-08da6a3689fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB7338 Hi , > On 13 Jul 2022, at 1:29 pm, Julien Grall wrote: >=20 >=20 >=20 > On 13/07/2022 13:12, Bertrand Marquis wrote: >>> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>>> I can't >>>> see why it would be wrong to have a more tight limit on static ports >>>> than on traditional ("dynamic") ones. Even if only to make sure so >>>> many dynamic ones are left. >>>=20 >>> This is similar to Xen forbidding to close a static port: it is not the= hypervisor business to check that there are enough event channel ports fre= ed for dynamic allocation. >> On other side we need to be cautious not to add too much complexity in t= he code by trying to make things always magically work. >> If you want Xen to be accessible to non expert by magically working all = the time, there would be a lot of work to do. >=20 > It is not clear to me whether you are referring to a developper or admin = here. >=20 > On the admin side, we need to make sure they have an easy way to configur= e event channels. One knob is always going to easier than two knobs. >=20 > On the developper side, this could be resolved by better documentation in= the code/interface. >=20 > Cheers, To conclude the discussion, If everyone agree I will add the below patch or= similar in the next version to restrict the max number of evtchn supported as suggested. diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 532e50e321..a8c5825a4f 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -3422,7 +3422,7 @@ void __init create_domUs(void) struct xen_domctl_createdomain d_cfg =3D { .arch.gic_version =3D XEN_DOMCTL_CONFIG_GIC_NATIVE, .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port =3D -1, + .max_evtchn_port =3D MAX_EVTCHNS_PORT, .max_grant_frames =3D -1, .max_maptrack_frames =3D -1, .grant_opts =3D XEN_DOMCTL_GRANT_version(opt_gnttab_max_versio= n), @@ -3582,7 +3582,7 @@ void __init create_dom0(void) struct domain *dom0; struct xen_domctl_createdomain dom0_cfg =3D { .flags =3D XEN_DOMCTL_CDF_hvm | XEN_DOMCTL_CDF_hap, - .max_evtchn_port =3D -1, + .max_evtchn_port =3D MAX_EVTCHNS_PORT, .max_grant_frames =3D gnttab_dom0_frames(), .max_maptrack_frames =3D -1, .grant_opts =3D XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8de..b1f95fbe1a 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -763,7 +763,7 @@ static struct domain *__init create_dom0(const module_t= *image, { struct xen_domctl_createdomain dom0_cfg =3D { .flags =3D IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity = : 0, - .max_evtchn_port =3D -1, + .max_evtchn_port =3D MAX_EVTCHNS_PORT, .max_grant_frames =3D -1, .max_maptrack_frames =3D -1, .grant_opts =3D XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h index d6c029020f..783359f733 100644 --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -76,6 +76,8 @@ extern domid_t hardware_domid; /* Maximum number of event channels for any ABI. */ #define MAX_NR_EVTCHNS MAX(EVTCHN_2L_NR_CHANNELS, EVTCHN_FIFO_NR_CHANNELS) =20 +#define MAX_EVTCHNS_PORT 4096 + #define EVTCHNS_PER_BUCKET (PAGE_SIZE / next_power_of_2(sizeof(struct evtc= hn))) #define EVTCHNS_PER_GROUP (BUCKETS_PER_GROUP * EVTCHNS_PER_BUCKET) #define NR_EVTCHN_GROUPS DIV_ROUND_UP(MAX_NR_EVTCHNS, EVTCHNS_PER_GROUP Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Wed Jul 20 10:02:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 10:02:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371479.603419 (Exim 4.92) (envelope-from ) id 1oE6XF-0005QF-Oc; Wed, 20 Jul 2022 10:02:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371479.603419; Wed, 20 Jul 2022 10:02:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE6XF-0005Q8-Lo; Wed, 20 Jul 2022 10:02:29 +0000 Received: by outflank-mailman (input) for mailman id 371479; Wed, 20 Jul 2022 10:02:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE6XE-0005Q0-PZ for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 10:02:28 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0d26c9df-0813-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 12:02:25 +0200 (CEST) Received: from mail-dm3nam02lp2048.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.48]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Jul 2022 06:02:05 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH0PR03MB6148.namprd03.prod.outlook.com (2603:10b6:610:d3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Wed, 20 Jul 2022 10:02:03 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 10:02:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0d26c9df-0813-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658311345; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GDFSOmP9rfU+b5Tl1tffmpdaFmigGJpnyCzCR5itSQs=; b=br5nioQbGmSFxpsxULSqzTjR5xB7cewM+bwkoKUBeBtUjW7cfS7F4VG6 NtzCySqSCBNr4h8wpJz5aPAQ1OQes/OyyX9RW43gW+iGtgQlY9tmd+1/0 6rscwMmpE1Y4Esun8CvIPrhZF+e0oZdWAmG/aqy5KInNhrvFbj2uBxSwd s=; X-IronPort-RemoteIP: 104.47.56.48 X-IronPort-MID: 76641405 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:MN3npKMiDHyHmobvrR2clsFynXyQoLVcMsEvi/4bfWQNrUokgjBTx mceUW+OaPqIYTb1eIwna9nj9B8HusPdyNNhTQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPjb8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPt48VFM38bLbcY2fZsDW4S2 tw6LxQSO0Xra+KemNpXS8FKr+F7dozHGdhavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr2wCWvG9FbgAv9Sa4fym7f1gFulpPqN8LYYIeiTsRJhEeI4 GnB+gwVBzlFaoLDkGbdrxpAgMfjsXn6YLktBIGk/8dPoVK3lkdDDDsvAA7TTf6RzxTWt8hkA 04e9zcqrKMy3Fe2VdS7VBq9yFaPvgQdQPJcGuk38xqMzezT+QnxLm1CR3hQb8Egu+c6WCYq3 1rPltivGD8HmK2YTzeR+6mZqRu2ODMJNikSaCkcVwwH7tL/5oYpgXryos1LFae0ipj5HGr2y jXS9iwm3e1P3YgMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2tbpm4U2l/MBVfNgwIQ== IronPort-HdrOrdr: A9a23:VXgU667XDGBkMGGIkwPXwWuBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+853WBjB8bZYOCAghrlEGgC1/qp/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXOrIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonys2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlagkEyzzYJ7iJaYfy+Qzdk9vfrGrCV+ O85CvICv4DqU85uFvF5ycFlTOQiQrGoEWStGNwyUGT3fARAghKRfapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jViuKYlGchsRLYkjTVoOYZFGDi/5JEsEe FoAs2Z7PFKcUmCZ3ScumV02tSjUnk6Ax/DGyE5y4eo+ikTmGo8w1oTxcQZkHtF/JUhS4Nc7+ CBNqhzjrlBQsIfcKo4DuYcRsm8DHDLXHv3QSqvCEWiELtCN2PGqpbx7rlw7Oa2eIYQxJ93g5 jFWEMwjx9HR6svM7z64HRmyGG8fIzmZ0Wd9ih33ekLhpTsALz2LCaEVFci18O9vvR3OLyoZ8 qO X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="76641405" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BH2yF8qvNq0EJ3VZ4eJhIKmWPO/0nlR86g5GXXNqFqOaWsIXmqW/LQBB214MjFuXAGhUWExrAyzYlACSVNio5+Jv7JYPUtF0GCtiOlmFPfWmBoga6nXoo1bdbUqu5HXOx5boU9LLlpVgJUxYbXa8uGyrsQXRYblwHsKEUsJEaJ7nyqD/viBXw5CsJ+c0YzKak00s0Tyh8S47nLdRB/MQueWZueSJspYB+cNUAUJqX8SRHWNhvm0ZuRVhaILaB5ZpWoRd6QP5m1lWWUJ8CyPV8Pz6fyEyxUGOKcj17SQp7j7vB5vUIEVrRFCEL4iMaI+QNgVyp74YfoNsuvQ9bfTd/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GDFSOmP9rfU+b5Tl1tffmpdaFmigGJpnyCzCR5itSQs=; b=Ui0W0tu5jnB+KGsvqMmcTfzyemdm1v2zqbb//XlNlXAjJ+8qCDUuWw+bFOHKP2xWScd+EHW/CWPnjfWM/2phenaambkgaIsD0lVAU38ABrsO/4VNYQTVy0npmpkUKrWCTGAT2Y3LkDyFpTrc7sxgw6huA3gJG0B9g/QGuySjZnkXs5eSHMYQEGTCysDvpidm0gLQNRClhhYw+qOub87fBbPqFxKC7tGgMUxLE0Z6ds57mvtpN10P+07BTVoDv9VQoDlS08zidUjuR72ozL7aUt8EZF+PPYTD9b0lA/kzv+ipbfwUTiHR01yeun+nvRdsBnqtLVflZAkITmjrC9aQUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GDFSOmP9rfU+b5Tl1tffmpdaFmigGJpnyCzCR5itSQs=; b=gYEZfx2NOE1dc5NPNTCt1L7lHztdTHdy4PXy7BnVaErR7jvM987BReAEs+AJr9luYsF175mOBn57x/zRDNFsX2UjNkgcsonkmEXEzCsnTVBRl1/S8kgepRvqwSxvGvkBRrJoXCl7X3puMVzkWb8YZ6SJyTD6gqIkoCqEhKEfCZs= From: Andrew Cooper To: Jan Beulich , ChrisD CC: Michael Young , "xen-devel@lists.xenproject.org" Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Thread-Topic: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Thread-Index: AQHYmvJAgpD4dPs1E0ycG7IdcXuLNK2EtJsAgAH9iQCAADrbgIAAHJ+A Date: Wed, 20 Jul 2022 10:02:02 +0000 Message-ID: References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> In-Reply-To: <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: aaa20c97-ec03-4a1a-3eb7-08da6a36e4a1 x-ms-traffictypediagnostic: CH0PR03MB6148:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qhNjJORWbTUZVMcw98Ct8KNjOfj3+WE1Kf1pi0UgljI/DTYVH6g1brnkAXwZie/A1NtxOeTuKuKxIh2NkWaT7CFLqFp0fu7RaiElvV0hFiEK2p6FKFi4fbA0u+1stds/HdGKA99DphiIAY2LxOG3zkRMdqNuy7lOUAvrgTbQXovlhLrW4oZS6yltmi8hulllvzN3K7IcZwjEC+G1MmXdh8Zviuk5zO8+vtZzut85iryCThD6t2kniTOm/g39FpIXpQOCMZRiFaNg3qEJKxEQG9dRSUXPHs+gYaKZuzZuvKM/rkVDJHVtETvAo2YeriIeLl8jZbUR7GoPx/mpxtGAvEuHZ2CO8xv1lQR7HWlXwVNtpK05SxaxR7jK2tHozYY1RxDOFILaMATHV3im3orGFP3plrN388ZYS5w8TqI6n+fiKU5FLzkzLOx82yDiK3uyBrpKbu4x6IKi37NRrejZd0wQljk9jLtVyCmB1KL3Q2jeDnqgbcNzO7H0jUXjv4TtCaDAonFL2dYTkQxFGVgTxQu0B86r03cfCWSvSNOQJMD1Hcy+52ELPoy6t2pNF/s56uj7CQsZka/GLm8KDK1VmgNw88yoMruiV3qnYfpR7GCFVe0Xo7sNnopVH20BFDV7Yc3NZmMpbHQ6+qhBLvX4Pwt2Brj7h5ZXtnfYwZXLWPYrwWpG1xt731JsI/+Gnq8ezy5oETMXxaf7z2aAmZSkbkbSAwA9vLj8htbScwPNh1UkQDuMqmW93D1bPhwNeGcfH3yrNSQKhaHPh1M2ujUwGfZ8j26eQUJ1S4n3Xer+0uWzpb53dafZXBLLHyFYwiLelipBfVvNBCpwj/HPr7d9hDkLPBcKhv7ia7eDJYX8GI26DY/vsDqS3WSkEgfCe2hv5rEnOvJi1MMsEli4rkhtDQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(38100700002)(5660300002)(8936002)(4744005)(122000001)(110136005)(38070700005)(82960400001)(478600001)(71200400001)(2906002)(66476007)(4326008)(91956017)(316002)(76116006)(54906003)(8676002)(86362001)(186003)(2616005)(66946007)(66446008)(36756003)(6512007)(53546011)(966005)(6486002)(31686004)(41300700001)(26005)(6506007)(31696002)(64756008)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MWJvQjJHK2lpczBSaGJIbGtTNWtNSzB5dStxWG83QnR0N0tBU0FaWmZONExz?= =?utf-8?B?NjUxVklMS1RsNGdZUFFVOWtjdU5HWUpYVmcyOXZ1VU9SeS9TVTFzRERnWWNk?= =?utf-8?B?VHl6S2N5VXMyaDBSYlNDMlgxQWMzUFNMbWV5NGlpcmFieVpuaGFjK3RvdVZj?= =?utf-8?B?U29tMXlGQ0RQSTRxTEg0M3N3Yis3ZVZMa2E4TUZCY3BaZjhva1VOQ2FrS0Vj?= =?utf-8?B?cW9mRmd5Vk9wTTRXWWhYU2V1V0JGRk9HVzV5S1R2YUMxVDRBajFyMmh2VWtY?= =?utf-8?B?bjZlcmVmaVVlNUJwZWNYYXRoanZydnVNNzZzamVoaEpDVERCUGl4ZzRqZnJi?= =?utf-8?B?SVdiQ0dMQUYraWtLYmJRSXg4U2Fud1BNME9XeXJxODZndlNTN2xBdXBTWG9J?= =?utf-8?B?aUNpZEY5bzJWYlR6aVpuY01Nd3JRY0xvei95dEZCamQ1eHp6SFB1V3dDZ3Rl?= =?utf-8?B?a0V1VjBScTl5bDRhblJwYTluVFdQOE9RanJxcGNEcjk0MmFra2NLcWxTSTQv?= =?utf-8?B?bUlqYXFVbVB3VGlRcEpnS005bGhFSFJEUHhMeHZUSDRaTGJ0aEF1RjN2WnRQ?= =?utf-8?B?a0pyVGhFeUljZ0doMnpheXRYNlNrcy91aStoWEtCK2xIdERzWHpOMmNpbzZw?= =?utf-8?B?eVJseE9mQkQ5MVo0QmJZU2o1bHJ4b09rMDRLSVpnUmsxendFR09ST1FZcTdO?= =?utf-8?B?WFlZb2NSMU9XclZiSTJWMlRWQ0Noek9YVUpwWGh1TU5FbDlpeVpyUlhUMXlX?= =?utf-8?B?dnhkeHJRcDFMdVY4Z3dseDdoR0JNUUMrdU1ONDFlVmJiQ3duQWsxWkpMQURs?= =?utf-8?B?c3p1MzZITHQ2ckFnNk1ockRJK0RhMTRzV2h2SXhnYmkrUzV6TmlrMWhDRVBR?= =?utf-8?B?WlRwN2YxKzFrTXF3SzY3MFR3NDBDQ0xvSDd4OGNzb1NjMFFPK2JzdWJEV0Za?= =?utf-8?B?NUNmYVNDaCs5RjhGMHh3ckc3MUpSQ3YzTzVEOFAxOGJnYi95ekJXK1d3RGs5?= =?utf-8?B?TzlEMlN3YXBoWlVDQ2t0RjNvZDN6YjFINHNST1RTT05iMllFMitUMG1nQ1Er?= =?utf-8?B?VDF6OHVSRFhiN0syM3NPZzFXbGdHQ291TUxmRWNGa05aUEVTUHo3dDN1L01j?= =?utf-8?B?ajIwditLTlRtNlJtMnBDTlpKbk9kSzlqTUhlWmpYM3NzU250WXdCcWJWbHlz?= =?utf-8?B?SXJ0L0hkOXNFUHRSaGdHMnRNUllOS0dDMStVWi9tWTFDMHpSZ0dFeEh2c0Fu?= =?utf-8?B?cnlURDZrcTZYUDJvN25Ob0tZU1M0cVo0STZUMTNKanVuL0pOMmRjUDR5c2RO?= =?utf-8?B?YmJuNGxMcHZqQ015WHFNRmlIQ0JoWWp0Z3NVckFMWnNoMUVCb0hDandvYkp6?= =?utf-8?B?YW11K1JLSzlhT0ZpNE5Xc1pJMm9PVytVa3U0VWFjSkdob1VwTmFTc3JRT3lL?= =?utf-8?B?Snhtb055bkU0bXZ4OUM3aGtnSERYS3NINXZjZVJJVWlOdW1YenUxWkpLRktt?= =?utf-8?B?bjBoVW9Kemx5MThJTTR2ZXI4K0VsK1p1b2FPWURuY29ya0JSWk1uY3FmWjRn?= =?utf-8?B?S25EaHlYaDdsdXdrMHFWMWMvVVoyZ29MSjhSTG1TaW5FbnBCRDlzYU1qYzhE?= =?utf-8?B?SHV4anA3OEtqcGZPVmdlaGpUcjFLQjlXdmxUOXRRd0FlSUkydWU2cVJBS0ZM?= =?utf-8?B?SzE0bFpJN1M3SWJscjlkaVpqQmtzaS83UGovT295WGxPdjlOSmluM3YyR0Zs?= =?utf-8?B?d3NZbm9yZzBLcHM5dHJSejF5cVluNy9lL3BreU1aQjliOW05ekJab1QzOVlO?= =?utf-8?B?K0hEaUw4aldnemRXckNab0prSzFUbGhPcWN1czZDQW1QOElJN1lWd0pFenNr?= =?utf-8?B?STBmdXhFczdDTGZLREVsZEFRV0RJTW9HQkxBWjRHanRSejZEbG1iRnh0SkJD?= =?utf-8?B?bmlFUk91RkJOaHNNdWZjWWhtSlRONU8rUjd3TThjRnFvNFUwUitpZFd5QkNG?= =?utf-8?B?MjQxQnNzcXVJaXg5c0hrekxkRjF5RGN2Z3hIczRFSW9hOTMwNU9RNHRHelFU?= =?utf-8?B?eXZ1UGJrLzM4YjhxTk1hVVpwdnhuQXdacTYybWZyZENiQ3Zzc1JFdnFYcnVT?= =?utf-8?Q?XJJZ9Rx46bG2LCkRFE030Ta8v?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: aaa20c97-ec03-4a1a-3eb7-08da6a36e4a1 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 10:02:02.2428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YVdCh2PCiYd777eynVMSw/QcI/QODfDnJT25mIxBnSpRoKsSiD5ZySYTRX5/iYWP7vL9nzyThEUE2QojxM3wE5YX+isWLDQYQAhzG3ZyQ6Y= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR03MB6148 T24gMjAvMDcvMjAyMiAwOToxOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA3LjIwMjIg MDY6NDgsIENocmlzRCB3cm90ZToNCj4+IFNvLCB5b3UgdGhpbmsgaXQncyBhIHByb2JsZW0gd2l0 aCBmYzM2Pw0KPiBXZWxsLCBpZiB0aGF0J3Mgd2hlcmUgdGhlIGJpbmFyeSBjYW1lIGZyb20sIHRo ZW4geWVzLg0KDQpTbw0KaHR0cHM6Ly9rb2ppcGtncy5mZWRvcmFwcm9qZWN0Lm9yZy8vcGFja2Fn ZXMveGVuLzQuMTYuMS80LmZjMzYvZGF0YS9sb2dzL3g4Nl82NC9idWlsZC5sb2cNCmlzIHRoZSBi dWlsZCBsb2cuDQoNCkZvciBpb21tdV9pbml0LmMgSSBkb24ndCBzZWUgYW55dGhpbmcgb3Zlcmx5 IGNvbmNlcm5pbmcsIGFsdGhvdWdoIHRoZQ0KcXVhbnRpdHkgb2Ygbm9uc2Vuc2Ugb24gdGhlIGdj YyBjbWRsaW5lIGlzIHNwZWFrcyB2b2x1bWVzLg0KDQpPbmUgb2JzZXJ2YXRpb24gdGhvdWdoLsKg IFdlIGRvIHBhc3MgLW1uby1zc2UgYnV0IG5vdCAtbW5vLW1teC7CoCBJIHN0aWxsDQpjYW4ndCBm aWd1cmUgb3V0IHdoYXQgbWFrZXMgdGhlIGNvbXBpbGVyIHRoaW5rIHRoZXJlJ3MgYW55IFNJTUQg dG8gYmUNCmRvbmUgaW4gdGhpcyBmdW5jdGlvbi4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jul 20 10:56:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 10:56:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371487.603429 (Exim 4.92) (envelope-from ) id 1oE7Mw-0003BS-Qc; Wed, 20 Jul 2022 10:55:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371487.603429; Wed, 20 Jul 2022 10:55:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7Mw-0003BL-O3; Wed, 20 Jul 2022 10:55:54 +0000 Received: by outflank-mailman (input) for mailman id 371487; Wed, 20 Jul 2022 10:55:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7Mu-0003BB-Rk; Wed, 20 Jul 2022 10:55:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7Mt-0006f3-Vp; Wed, 20 Jul 2022 10:55:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7Mt-0003Nt-G7; Wed, 20 Jul 2022 10:55:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE7Mt-0007EQ-Fg; Wed, 20 Jul 2022 10:55:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RV9TIUosqom/DZJGMUjmaW6+n1wSY3WFZPa6wXBI0Rk=; b=ju7yXiwZnCJWEqPZ8Ld9AKLyQh vd6Kfhbg4E6dbeYAWYZCUPrEXXIT2/M3SoukFhMUJFiTBUii51AhnxLDb8E3kTAvSD4VEUOR34Wk0 /1X8DAOaBNSnx/HFVD+kErlWcssOmESlz9NjfhwViUaJeoEla4Mq/aemRU08Iqn/2U18=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171703: all pass - PUSHED X-Osstest-Versions-This: ovmf=48249243777882d7d89ca0b86c89e355b5f941f3 X-Osstest-Versions-That: ovmf=24eac4caf31afae48349af44588a52783c1819b8 From: osstest service owner Date: Wed, 20 Jul 2022 10:55:51 +0000 flight 171703 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171703/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 48249243777882d7d89ca0b86c89e355b5f941f3 baseline version: ovmf 24eac4caf31afae48349af44588a52783c1819b8 Last test of basis 171696 2022-07-19 22:40:31 Z 0 days Testing same since 171703 2022-07-20 07:35:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu Hongbin1 Zhang jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 24eac4caf3..4824924377 48249243777882d7d89ca0b86c89e355b5f941f3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 20 11:16:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 11:16:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371496.603441 (Exim 4.92) (envelope-from ) id 1oE7gY-0005yl-H4; Wed, 20 Jul 2022 11:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371496.603441; Wed, 20 Jul 2022 11:16:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7gY-0005ye-Cr; Wed, 20 Jul 2022 11:16:10 +0000 Received: by outflank-mailman (input) for mailman id 371496; Wed, 20 Jul 2022 11:16:09 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7gX-0005yY-Do for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 11:16:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7gU-00071w-42; Wed, 20 Jul 2022 11:16:06 +0000 Received: from [54.239.6.185] (helo=[192.168.0.130]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oE7gT-0000hO-T7; Wed, 20 Jul 2022 11:16:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=UGUhOqkA6huNyuSVwxF9aSA9OkbZWMExmaJSQcdwXJ8=; b=E8Fq+vn7DcB3C7x9NagltS72t5 ucrCbatZtUxFtdaswQ+eau8G7KBf0VGrJsJLpF3a8Ss6icKcaKVTYANydOnNZIYQLeRQiW+KJ7bgh fyeS+1LwOeFwHGLTMUtzZL8JeL/FGI//hHLdVvaZBKx+pP9cr92wmyFMbZwcCyRSYAHk=; Message-ID: Date: Wed, 20 Jul 2022 12:16:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Rahul Singh Cc: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Rahul, On 20/07/2022 10:59, Rahul Singh wrote: >> On 13 Jul 2022, at 1:29 pm, Julien Grall wrote: >> >> >> >> On 13/07/2022 13:12, Bertrand Marquis wrote: >>>> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>>>> I can't >>>>> see why it would be wrong to have a more tight limit on static ports >>>>> than on traditional ("dynamic") ones. Even if only to make sure so >>>>> many dynamic ones are left. >>>> >>>> This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. >>> On other side we need to be cautious not to add too much complexity in the code by trying to make things always magically work. >>> If you want Xen to be accessible to non expert by magically working all the time, there would be a lot of work to do. >> >> It is not clear to me whether you are referring to a developper or admin here. >> >> On the admin side, we need to make sure they have an easy way to configure event channels. One knob is always going to easier than two knobs. >> >> On the developper side, this could be resolved by better documentation in the code/interface. >> >> Cheers, > > To conclude the discussion, If everyone agree I will add the below patch or similar in the next version to restrict the > max number of evtchn supported as suggested. I am fine if the limit for domU is fixed by Xen for now. However, for dom0, 4096 is potentially too low if you have many PV drivers (each backend will need a few event channels). So I don't think this wants to be fixed by Xen. I am not entirely sure we want to limit the number of event channels for dom0. But if you want to, then this will have to be done via a command line option (or device-tree property). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 20 11:28:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 11:28:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371502.603452 (Exim 4.92) (envelope-from ) id 1oE7sc-0007qC-Kb; Wed, 20 Jul 2022 11:28:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371502.603452; Wed, 20 Jul 2022 11:28:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7sc-0007q5-H2; Wed, 20 Jul 2022 11:28:38 +0000 Received: by outflank-mailman (input) for mailman id 371502; Wed, 20 Jul 2022 11:28:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7sa-0007pz-RV for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 11:28:37 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 170eeef7-081f-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 13:28:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8088.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 11:28:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 11:28:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 170eeef7-081f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOoRa7c6juElYwa7XnI8EpShQIZ/zSagM2DlMLLEsMMqrlHfThnE3O9L5bidoZCjP1GaqyDWxQTlB3Mi68CX9DC/HcsHbOVfYuLMw/ICJ4yP3AEHogyt3kTdJBusur4Xhz0WV+KX7VyxXkgdD5oBSCmJI+BmzGT0riwEet/B2HLW7Y0ZOx392e8Wn9RNj2jjxbnib+RnRBgjBRY8kXvKds7YS8vmBnrwFkcwG4plZ+loUBs4aibtsLD4I6Yenq0VriSus2UYQqn3NbNwmnsUmW6FMyMbRLy1AeuZOfaCrxYL/PEWf3+SOe7t3WjgVL37y5fQH7TjJcZ+tlN8Mvc7vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFivJr+JaY49LLdT/LQ9u4+a0rTu+ultC+v1a5et1uI=; b=ij/JK012fE6VLCSlzYc1LOgY6Dj3eerL4V0x/dPSicPI+pdDZKLpNjrBGdQ9gMgCzMkDcGqxd6JmEffgndNgKXhYzS8ZIjlTS/iunoL+JOC7KkfvO0m92eXhCrllOYhsVQHfcBuhGXLW3RuuwqYlB6sSZ72CE6332hZ/0uhDJGEv6LEgqjLZzqptChxlxIO4+UnGH9V3HCR8BFHEGGmBE2V249TRI/GH9upyCyEz45OgRFzn6xLock5f7EmyGiRq9Tj4zWe9O2J7S9r001NOGna3KYrPZ9XHxAMfxjN55FXIdMtiW+8B8HHx9xEn5AzJqEkmojnV/6C9/DKIOYc2Lw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFivJr+JaY49LLdT/LQ9u4+a0rTu+ultC+v1a5et1uI=; b=Sv4W6osX4U3yDbEhJJ/f7Jn+bdkgt/4jXAl9XeZbGW/hPqtEXNJ/b9Myy7z0g+qjG3OurmFuIJWJt8fFLE0wAf5gdzteXCoc/agCc/mVZ/RYhL0W+ZIoS/FEfxP/4Zv/Z20bEWfKwJimn0YHJoIboHezQ/B+mbeAAQTeYOCbIWDm1ib6hPHTxvXhysn8CnxvvphbSYOje+IzDkkH4+Q1VMHt8q7NoNv8DUfoR9JRYUzYfuS48zUgP36sJOEzCIZEh1vOiGUn/KGOzO0HjVcGDHxnH20z6zkl4dvV8ZRR404qcxLQ0fKcZ0AnU9Yiy0fyETspzV/XnJb/O/tx2mBUGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5bc211ba-96b4-b705-d600-e01e41e936e5@suse.com> Date: Wed, 20 Jul 2022 13:28:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US To: Andrew Cooper , ChrisD Cc: Michael Young , "xen-devel@lists.xenproject.org" References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR05CA0018.eurprd05.prod.outlook.com (2603:10a6:20b:488::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8110923a-c50b-4887-1f04-08da6a42f9e0 X-MS-TrafficTypeDiagnostic: AS8PR04MB8088:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jljpLHu/frmWfpsZSJA/18Ptk8naioJPUAgGHW1bhnNUWz2YiXkQFAKGu9ZTKz/Siv2OGMJR8PvGLehc8X529ZEgu1rJjfX9IrZdhss4o0cdsH+VKKOZh5DBuUi+XXWVw/P2imn9/aEPhyQeF3Znej+KIpDGnMJl+eAYRybiPCh2tq9KHe/OaYCGuCzbC0dx/B0n0othbPEHLzcNIwYgDZLtQHTtZxKzvruFSx7z7MV+BowuRZJlcmfheBgjmfqPi78+GS5gbLPMLViy70GWbXOUFH6wq7B0lndcc3nWszwldMf9VovC6goXnGTms0WrAU3Fbki+kULwk9/3VHc+HyUSzV+C4xRmjGRxA7tA33r+hOMs9iKpwQVlYPP8U8eN/4ZdKsqI+imE8Q3gob3tpMaVJ8UX5J1ET7rpJGj7PSpul/PDa2OXZsPfrT0LKHIWUZqtMuDgS6CiX8kTwF8Z9pQaYU0PvPu3RsmDuhv9a0M3nu/719TTeSQrlq0X3RmsEM4u51Pgqx3ztIuGLhOXiftlkcxKMf9eZ4rEClm490eYINemKkIu80P8hcjIxhZdSFS8Excs+iEx4ViBKYgAC9XUVpbvoP7y2WszvABVkW1/V03RKWIIRKjpe9s9cBTWt5WPqIWmljtid8ao7AGnKz0YvRcl/gpkyLxTLFmPNoazW0QEabXzcLxrh4diYoMXOGVujPLTPZi+A2cnWXu3QvMj77cRa9C28Yjlk+KKg76nCSB4LrOJlue/5WCjZIg4d4hn5QobPdIYB6F/KC+yO9j2MItKRUN6GCkMCc+dRx/+xKmuopW1XGKkhkOfaG1MMiE0gW/HlsvEUwrJNUGSZ+ryhm0o5DajsKWq0Ag6wNk= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(366004)(396003)(346002)(2616005)(316002)(186003)(54906003)(31686004)(110136005)(66946007)(4326008)(8676002)(6506007)(66476007)(66556008)(6512007)(53546011)(26005)(86362001)(31696002)(36756003)(478600001)(2906002)(41300700001)(6486002)(4744005)(38100700002)(8936002)(966005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QnVQN0trL3hOd21maE1kZUVKOVNLNXN5TGhDTTVCZW1mdGFSNldSZUdvdTAw?= =?utf-8?B?Q043eStab0UzOG9IR2p4SWZtUWJLNWRFQnpnWm8zL1ZkNUJ3bWd5SUxreW1Z?= =?utf-8?B?RnFKWDlFaS9SY09OcmhiTURTbmxybFJRMUVRaUlHdUlTN0ZFVXFqUFF3bk9Q?= =?utf-8?B?Y0RDNnBLVVkwZVV4ZW1TRUtNeVhtRjJnem1KYlhobnJSZjFwN2FhTkZPSkJH?= =?utf-8?B?Ly9HaGFwRkFQKzVvS2dwb0VWbEs0eFpFWFZPQmlXaVZHTDR6RE5ROWJ6aC9h?= =?utf-8?B?dndCMVkzWFk0M0VlVmZBRDVhYUoxUHFTdTdPVkxCNlZ5TkJwQXdJQlVoSDV6?= =?utf-8?B?VEJSKytoUGpTTU0wQXBsVGN0ZkdFY1JiTHRueXRnbUo2Um13R28xTmc2NnVQ?= =?utf-8?B?MFlEVzZ1RUxaeWt3YTE0NmxVbTljOU9KUVZvbzZsR0pJRHphQ0hqRW9hSEIx?= =?utf-8?B?eTR4c3hYdGdZNUFFMjZjVlpiQmY0aXkwUHhobjBwcFZva2tGbGNacnF5S0Rv?= =?utf-8?B?MmF5RUFOQVoxQ2h3UXk4aUtETWpTQTJuQytLQS9TL1RHZjlOSFBuSDU5bjUx?= =?utf-8?B?S3B0MnUxZlRYTGZNRCs1STVvUFJvNWZPYW9BaTlTQTNZaTFQWWNNdDhjTnJM?= =?utf-8?B?QWl2L1FtYnRzcGk4UVNySmFXNmF4K205QlJHZ1QyQkl0QXBJRURqUVd4VEow?= =?utf-8?B?aUVBVjN1MWgxZlFYa2JtRGs0SUxxOVN6aVBwZjQ3bDMxYzVUNXI4WTRITXZX?= =?utf-8?B?TzlIQ2V4aEZROVVYdDJWSjFWUUFra21HbFVVSFpKeHFaak1SMFFxT0VoRkk5?= =?utf-8?B?bEZmZFF0U1F4R2N3TXhzZTVCK1lkcE0zaTdyVW1abDRuZktldE5WV2N2V3Y5?= =?utf-8?B?cUtxbG8vWHVrUkNBZUo4My9peHNBMDVOQU9HazZTTHg2U2tqT0VLeldpWldI?= =?utf-8?B?aEUvTmlSWFdUZTcyNnBJaXVpb2l4Z3pIZWx6dEhPSGMvRlRQbVRRNGgyNmE1?= =?utf-8?B?dkE1dHM5VUxvOTBUNFZGeHV5SXdFRk1YVnlaM0tDeXUyT00xQmlMQmIySFQz?= =?utf-8?B?VVlOUm1vaXRidlpLaTNVZTh6Z0ltWUlScFJWYmJuVVJtYVN6TEY2WGJ5YkMw?= =?utf-8?B?aDk4N281Y0JoSVM2cERUaWw3c3ZhRTZyNUpPODg3dm41U1BkNTd0TktaemZR?= =?utf-8?B?TXF4eDJjRFBqNG0wd3pxNEZGS21GQ1N3UFgyYWFsYkp0TjRKV3FEYlNQQlBx?= =?utf-8?B?TE5KanFweEhBbE9iU0ozU1hmQXlXTW9pMFNxaGdWZm9EWncrTDVtTGtwbXlz?= =?utf-8?B?Ly9RZW5zNkpQb2UzSjJMeFJaYjFHUW52ZGNJZFhITk1CSm5nZXFBeGJ1QVV2?= =?utf-8?B?dkRLWDBmRGdOcVdTV2I3WXo0c3VYVjJiQkhrdmV3QS9UaHU4dURtd1h4dmRO?= =?utf-8?B?UlREWEt1WTFkSm9xQ1p1U0FVb1F5US9hQzBTZTVIaS9qYk1uNEkrUEZ5NS9I?= =?utf-8?B?ZUV0RWIzYzlZWEVPdkdjejA4bXVlc0lnc1pJN2Q3YjdrU1NjcWdZRGRzQkRQ?= =?utf-8?B?MkZnT2Y5a2hjM0RqWmwvTG5Pd3pXWG9kRW1rNUhjWHE1aEl4N0JIWFNEUzVn?= =?utf-8?B?bUN4WUptVFB3ajBqQ0ZwR0x2amlpR0VSRGlPNllIK3VQVlF5aC9lb2s5dXlD?= =?utf-8?B?NnlWbENTYXdOMGhxelpPUE9RU2kybUMvYWE5SzF1UjNsVGxpOG5sMWtiU1A1?= =?utf-8?B?QzBxbE5La0dBL2ZvMlF6dGxYTU5oNjI4NDRBbDY2OGxSSlRQeXZienVjK3B1?= =?utf-8?B?RXpYdm5rRzMrK085UEVHOUNRUjFSdG16clkwWjhETXFVL29sVFdnWFloYW50?= =?utf-8?B?RkpEbW5wVElHL2YzckF3KytNVWNIUXF1Q0pKVWlPYldoZU5TUXZ3aE9Ccnhh?= =?utf-8?B?dmJGMUtiL0k4enlObWJGb2xTcklEU0VQV1BNR0tCR0t6N3JnR3JSTm9ReHRz?= =?utf-8?B?U0xOdnE3VUd0bHdCWG1lWHROdnpnOFN3QVRzU2gwbFNTWTVBcUk4UzhudGVl?= =?utf-8?B?cGlCMi9wV0lDdHZ4ZzlLcTB5TEtwcEJRMHJGRHVWSmI3TFpPb1RvUFVHY3Uv?= =?utf-8?Q?wZr57R3F9vfkQCb6gilsCkhOS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8110923a-c50b-4887-1f04-08da6a42f9e0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 11:28:32.0978 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bszMAswuHKH7FbAeTd7CYHwLlSft6mPM25N0UUrwHWu9J/FhFESc9q5W6OLt0MEdjtD7DNU1kKBfrLcq+drx+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8088 On 20.07.2022 12:02, Andrew Cooper wrote: > On 20/07/2022 09:19, Jan Beulich wrote: >> On 20.07.2022 06:48, ChrisD wrote: >>> So, you think it's a problem with fc36? >> Well, if that's where the binary came from, then yes. > > So > https://kojipkgs.fedoraproject.org//packages/xen/4.16.1/4.fc36/data/logs/x86_64/build.log > is the build log. > > For iommu_init.c I don't see anything overly concerning, although the > quantity of nonsense on the gcc cmdline is speaks volumes. > > One observation though.  We do pass -mno-sse but not -mno-mmx. Right, but that should be no problem - the compiler isn't supposed to enable MMX without -mmmx. Jan >  I still > can't figure out what makes the compiler think there's any SIMD to be > done in this function. > > ~Andrew From xen-devel-bounces@lists.xenproject.org Wed Jul 20 11:31:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 11:31:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371507.603462 (Exim 4.92) (envelope-from ) id 1oE7va-0000nh-39; Wed, 20 Jul 2022 11:31:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371507.603462; Wed, 20 Jul 2022 11:31:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7va-0000na-0U; Wed, 20 Jul 2022 11:31:42 +0000 Received: by outflank-mailman (input) for mailman id 371507; Wed, 20 Jul 2022 11:31:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE7vY-0000nU-MY for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 11:31:40 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150051.outbound.protection.outlook.com [40.107.15.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8572589a-081f-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 13:31:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8088.eurprd04.prod.outlook.com (2603:10a6:20b:3f7::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 11:31:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 11:31:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8572589a-081f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y70bw6x+bWC44I+VuhNZNvicchCmxHlxFmHJ0/q/XaIwhYZGsOFatHkpSL4Y2fOa07HWVBFyoI6iAkSIGfA+M6K9iIOtbx6dUIXXSD3P04nFTnCKWKHfsCsXsPuFrzj5IGrYTYJ4MxDGFK1Fnne12lrKT32YSkH7hziS6hy1jP3sbIB38SzcQpCRtg+TeI4RThG5oJ5Z/XHR21utIzO+czGyYNJqLG5ZyRZ9vRxG7xwyEJFpM3GM6PyJ/DiyBIRT7EQ5k7qU/KTxfVzAALKe2p8otKexhnQObiGwKh9SIYFvlu/rYAMhYR+9gKoxDUqogCu+mhK0Sq5H90Rm5ol7Ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SI8L4bIQyrB2moWBqY3UYxaMkj6LMuV+tsjZDuMJGu0=; b=LQZfh6bIfEvKLSH+QrcqxcZErSrGMs1vzDVBq0bXp9F8vAbc61LOyhin/W+/bZZgGvwKJ8S9ifxgpIumlXEsLl5kVPcgBQE3U/VliJJQgFhAv566ugZ48rRraIxdZk82QJr75nVB13Nf3Mnc+6mK9qhBPbx0DIv5srqD+jrwGgkvff82XpcCq4288e3znWuFIJr+dEnFZZZAkF72eHDRmWxh/VwB6vci/rhgJkZ2A6TUPrAnf6RwFOaPwFS5G8IjLBIF5MZsYo3pHyGmHrBVnbGePcAM+FvnY0nFiJaKN3+S2Fx+i+OWGLLL5uTc8UA3i0okW+NkJCPNoQ3NQZwG7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SI8L4bIQyrB2moWBqY3UYxaMkj6LMuV+tsjZDuMJGu0=; b=eNpWe2JCRWLHBuem3pSXqWICGgUa7qFbePlahxHKaHlDmuGQlyJcb1Wny7xHgpQpI8RxCdcmfWHZvcdgXvR8+4T4S+9EAQZf8yBPUSqLvHAVWUIWSmC7pWIoAWP+cG3Sn9FEUBoUlf+cIEvY71hR5z/CLPN3C9/qYmPx7Ck73edhjfo3E4n1GrVcTpvVCoVNtP+JO1F4gvDDe8cWHmoWya/ZWdJ5I9+Wrv1tlwmZQXzx1HWoBCaGgfjPZliGyyRlGuf9hQf304p4UnFbrEBrWqYRIKxVByhTYHmVMpkpDiKY9a5eUrXb6s7uXJ61Vc69QlObQm0gtVpBe6GkgLC6Sw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4a1bf74a-b291-076e-1eb5-102facef6fab@suse.com> Date: Wed, 20 Jul 2022 13:31:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US To: Andrew Cooper Cc: Michael Young , "xen-devel@lists.xenproject.org" , ChrisD References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0049.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 84f903cb-a2c3-4aaa-ee13-08da6a4367fc X-MS-TrafficTypeDiagnostic: AS8PR04MB8088:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YBRW7ZEAk1g4myfi702eEr9rcBhWXNHUxHaKL+7OovYimooNF9ECg3Vwny6EyhLf8yg8/TnmdqnR8sbvPpDCoHipV7UOKiw4R8YfOUBgvCdHN2PIIMVSbQRyYppyoZ85TjIFOJ1TSHmX+x7AKwBk7FGrb5seL1rJhpuIRrfgQgXc3Jknb40sd0UjJNuvycYpIFFGvpM62eexDwSDnZSE9wKaM2/kagW61yjqFvs94aDXhbnWyZs9hXu5kzLjmKddvRYsX1I3XTGwta+OSLhCJXeHl95+70YuUnyZh7sCHPa9XGmCozVYoJa/IgWKAT/jHybLeEfp29mSTaTQTcaoQhSfqadXTVRTo3C8uh5YwW7eouNY3QxueAXBLtvC/F5LYLmAIKHS+NQxPpkUTHStfdvxyl+wMPQMFOwxCAm3rxK7x05BZZ2L8pu6UnL7VP6aiE/HxsuY3xsB6lqcB+x+edc8chIP5EvcZymDJlXwvF6tpWGoS0kLG+0+175JQA0D4/L3apwa1FAavmBY5yKt5319u0LFceJEaaGyAh/fQe+GiMGkdwewl97SzD1pywquYjmWKcZETVwFM/k2BMLgI3UoXRGXHdvP+gQFizAC3iL6KeH4eXJPBGrjO4bj8/EwRyK/ivVJibVkXlGKz+i6rlI0Tls5XNSC7HepPqg/FVds4yYQB56UKFy+GJQdJ0PpbMlilmRIrizKf297dAKIoNNRbc86VGEb2EpFntKhFANtvs6c57bxXK7bSlX/5xwTrjqSBhmkI0xTmTgBWTxM6hcf/BiW8u1T6BhLPLP80WHu15Oam85SgUG8jeC2FvcwAekd42T8HqW1bgXbwOYcRbN3BRT1RBJcSfZEQcBz7bQ= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(366004)(396003)(346002)(2616005)(316002)(6916009)(186003)(54906003)(31686004)(83380400001)(66946007)(4326008)(8676002)(6506007)(66476007)(66556008)(6512007)(53546011)(26005)(86362001)(31696002)(36756003)(478600001)(2906002)(41300700001)(6486002)(4744005)(38100700002)(8936002)(966005)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bi9sZnorV2pKMVJUNTFZYzRsQ3JIWDA3T2VFa0w4NU91WWtOaHFMajBWcVBr?= =?utf-8?B?MzEwWXNPYTFieXJESVJvRzY2SFdPS2RXUHhGd21zMFVMbDZxOTNLN1RUNXVU?= =?utf-8?B?bXFmbk5vbVNXYVBadW51cDk0cXdoS0p2QkhrbmllUUx3S3JldXo2YUFPMG1a?= =?utf-8?B?bDBWZk9hM0d5b3BrZnVFbkZYcU5LT0Fkd3RHMFZKQjhVWnpHNWZISlpsK1lF?= =?utf-8?B?OUEvUnFmV0hHdkJsWjFNdlpQOGptMUtaNnRXeURKSW5WQTdRZ0xjaC9LMjhN?= =?utf-8?B?a3NkeWorNWg5ZmpBYWxJNTBobUpuUzhUVmczdW01UTlrcDU2U05uSk9wTWNM?= =?utf-8?B?NnBWQ1hKL0NjNjhlRVBwOW94MkFudUpLUlJpNmNGRS9namRGUzNjQWZqMkgy?= =?utf-8?B?ekRoOXM3VUNsODBUbk84MUVpNmxPYVRMTENGOS8yZWpnZG1xcDNnOXVmWXM1?= =?utf-8?B?a2hsQmRNRUoxd3N1Uk5LSFVtWFYzVlBnTmJ5VWFPMFAzVHp1Znp1eHZmWG1n?= =?utf-8?B?b2Uyb1Z6U21NVkpNa3E2QXB1NGdTMHMwQ2NNRVEvMXdXVTlFbHJaNjhXdktz?= =?utf-8?B?ckNRWk9NNjJMTFlpNGhWNUpJemZLYVJIMXRtem5nQ0tUZ0dDb2pUVXZDNE1U?= =?utf-8?B?Rnd4em9XWWhtUVkxZjFPa1Y3TlRkeE1MS0R4VE0zQ2Q0UTFOeVVPU3E0ekFJ?= =?utf-8?B?SWtXeGlaajVFK0kxQy9FVFd3dklQMnQ3OGwzVE1GcUlqbm9CaUxxYTBkUmtX?= =?utf-8?B?VWVOUEJISGh3bWJQNlFEUjNJN1dVZ2k1NFNxRjNFZC9Zd1BUcFdKYXRMdnJP?= =?utf-8?B?cjFYcDBBZFgzaUhkaGpYaEgwN0dZbmZ5KzlqN1lic3h0a0RKWFo0WmpRMnRv?= =?utf-8?B?bHYzc3hEV0d5YlFkMXIyeldjMnJvZCthM1E5N1dyV2RtbzlkQVY3bmQwUzBZ?= =?utf-8?B?UnZTMEtFc3B1QWZSTHd6NDdRZENmTjJGWHI5RFFHQW1ncTFLYk5uVm9YYXFY?= =?utf-8?B?NzJpSWsyQzFyWGRiUEFwZ2pUQ0VRMEJNRzBWNkRTS0J1QzEzN0t4Yml0b1hU?= =?utf-8?B?Ti85N1I4alRxendVR1Q3WGtxLzF1ajRtYlZaWHpkQlpjZlh5VDNxL01QNS9l?= =?utf-8?B?cVQvNkxRV0FmYWZCMnloMmhNeFZlclcrcHdmWEhEa2FDdnJGdVJJYktmYkVB?= =?utf-8?B?TzZzLzg2bEVpQ0lNRWcyNVVvbmVkbk1JQlE1YlNSTjIxOStpMkZNTUdnUExu?= =?utf-8?B?eHdQc3MwS3lrSlA0dUxPS3l6Wi9JTXBaQ3N6eVZjRURqbzRYcDk0b2FDTnlN?= =?utf-8?B?NGIvcnIwNlZvNEk0cFYybEpSQnFCWkFmMHBwNktDYUFWRURkVHNNS2szbFpl?= =?utf-8?B?Zll4ZzNScTFleU5GZTVQNFZvTlRWWDZlSEl2QzdIODRmdTFxdUpWdm56Wm9P?= =?utf-8?B?YmVVREJmQWxWY2lHaUlNYkRkbzJyQ24xUEhodHRFUnZNempVeTZnTEtHWFZD?= =?utf-8?B?VGtENlJDOVNjZVNzWDlWazZGdTlNM05ITTRBTlRGRTgvSzM1Yjg2ZCtod0tG?= =?utf-8?B?YWJpRlZTeVU5VVJXWnUzaHhWWlB0VGJIZDBVSWQ5Um05dWpoV2VCNStQZkFV?= =?utf-8?B?N0xpSG5RVmRsSGRJUGE1SkMwZGErM3ZVTjB6NWtHMDRFeURSb2RMeGltbFBq?= =?utf-8?B?SStRMVVhWnNvVlhWZmZPYXdnajc5S0x6Z2grQTg4T3RscVJMOUsrZXJUaHlG?= =?utf-8?B?RzdtMWM3dUFVTy9UZHVUYjArRjBKWlc1RlZTbkFLaHZBT0NZaThuZ1pXODNV?= =?utf-8?B?VjZLK2h1K29NQ2s5Y3N5S2hiQzFqSUoxN2UxMzJpVS9NTTJ5cWQ5QW91NkVq?= =?utf-8?B?Qld0RXk3OWgwaGtxUTVRdVo4TVM2Ukg1UWYxQ3J1UmFhLzRsNFhSRWg2cGtz?= =?utf-8?B?YzJCSmROQUN1NS9qZC9ERzVXbUZPT0xxVjdvZVhrbWVGV05QTXU5L3Rza0Ny?= =?utf-8?B?T3VTWm9NT3Zvb21ZREt5L1VWNUZSbEtxNkUrdllDNnBmNlNocUxxcWt5c284?= =?utf-8?B?VFdTdkx6UUloWk9mK2N2bHdMSmZjZFdLeERYbXBvRWlKV1QyTUlzd2R5cU9K?= =?utf-8?Q?r3gVlqC1I5SerXbMysAGV41es?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84f903cb-a2c3-4aaa-ee13-08da6a4367fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 11:31:36.7110 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZhxtgmuxA7AP8kRqqA4mkzCuQG3sCrdtXVs4NiBULwVxDBYDeRCKb95c+3L4tb213NkkBFzz+19/DeU6O+9qIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8088 On 20.07.2022 12:02, Andrew Cooper wrote: > On 20/07/2022 09:19, Jan Beulich wrote: >> On 20.07.2022 06:48, ChrisD wrote: >>> So, you think it's a problem with fc36? >> Well, if that's where the binary came from, then yes. > > So > https://kojipkgs.fedoraproject.org//packages/xen/4.16.1/4.fc36/data/logs/x86_64/build.log > is the build log. > > For iommu_init.c I don't see anything overly concerning, although the > quantity of nonsense on the gcc cmdline is speaks volumes. Hmm, I wouldn't call two uses of -specs= entirely unconcerning. About anything can be enabled/disabled there. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 12:32:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 12:32:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371565.603492 (Exim 4.92) (envelope-from ) id 1oE8s8-0000v9-M6; Wed, 20 Jul 2022 12:32:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371565.603492; Wed, 20 Jul 2022 12:32:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE8s8-0000v2-Iw; Wed, 20 Jul 2022 12:32:12 +0000 Received: by outflank-mailman (input) for mailman id 371565; Wed, 20 Jul 2022 12:32:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE8s7-0000uw-8T for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 12:32:11 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f96be420-0827-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 14:32:10 +0200 (CEST) Received: by mail-lj1-x22e.google.com with SMTP id r14so6193655ljp.2 for ; Wed, 20 Jul 2022 05:32:10 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f96be420-0827-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Xd4I28wqGMbQUFhDjkVwdMEQ9FWCaodOJF7yMGauOSQ=; b=TUbucA2PU0zhiLKi1YEi3IwlYFz34YzfZFNfvRHZFq4skdHcMve9++EKkSwKs7WZWU uyIL8rGjn9nE8XGofAspve+LE8BbV7mDHiYGwKhcYjhAHPBMuSAGuQSm+fP08ryny8WV NCs6Eop4Sg6JPbDrKdRQBRAnrZxGP9yaHPE4YMR4d8+bKMM4clBGSJtvw8oJfLBi+hpT 9inBI8K1xT8RjbOuk/eDnw6pMaELrE5HYWw7LRYdpLGFzga0QzimAWv3mGpxGK1cJ5Lr wBsE69AivyE7ADTJd99C45jAzShwHeP9a82SYWFWGHBiBctAqCfnhjNpdSap+86EuKCd 9Mfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Xd4I28wqGMbQUFhDjkVwdMEQ9FWCaodOJF7yMGauOSQ=; b=RI5i4fVFh1oEXMkm5sJBV/Te2BVLAjI5CTWd/lEYLaLH7XxXJts6NYHJTRgDR8n7/b M2DFD0hSRSIbQcYvwL24jCfnOHnbY3SVyP/geA8U8b7e5/A63Ox7futWf3mz2W8ek1bw mu0S7yk+Gvnj9z8U8tJw6FFnf8OoDYq1phb24LyfUInEWtnEzM7jmNlfo1bH5kAihHEm qMDY7S0R2fbMF0DWgT2i7gsdaTxA3aYi1Qoo5TitR1B3fkk1e1DiA4y1DARLIoUfaiEG Uru3TR95z9Z5iz3fwnTOJeAq0RgLHIEo/7bMco6eJ3p9ERHhvWVnTPZ5PhUBbV0YNRnz ZnAw== X-Gm-Message-State: AJIora/QBha72uMz2EiDL9aekPJqEdohxofZS5tzcAboefmlApcY+d4g DxY9mVbaw7yomH5HM4rMauPxtsbd7y9Fj5PETMPY4e9Ff7I= X-Google-Smtp-Source: AGRyM1ste7D4rP9NsUSGd/hKmn2ECeW/G3M8TacFmWjmw0wFeF4UjY0hzbimDjT+KUayXv1WMyhtQ12SgbZ2jew7/TY= X-Received: by 2002:a05:651c:38e:b0:25d:87b1:b50a with SMTP id e14-20020a05651c038e00b0025d87b1b50amr17890958ljp.168.1658320329508; Wed, 20 Jul 2022 05:32:09 -0700 (PDT) MIME-Version: 1.0 References: <20220719200815.69884-1-jandryuk@gmail.com> <5a1e78c8-1982-f787-46a4-7197b23d53e8@citrix.com> In-Reply-To: <5a1e78c8-1982-f787-46a4-7197b23d53e8@citrix.com> From: Jason Andryuk Date: Wed, 20 Jul 2022 08:31:58 -0400 Message-ID: Subject: Re: [PATCH] x86: Expose more MSR_ARCH_CAPS to hwdom To: Andrew Cooper Cc: "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu Content-Type: text/plain; charset="UTF-8" On Tue, Jul 19, 2022 at 4:29 PM Andrew Cooper wrote: > > On 19/07/2022 21:08, Jason Andryuk wrote: > > commit e46474278a0e ("x86/intel: Expose MSR_ARCH_CAPS to dom0") started > > exposing MSR_ARCH_CAPS to dom0. More bits in MSR_ARCH_CAPS have since > > been defined, but they haven't been exposed. Update the list to allow > > them through. > > > > As one example, this allows a linux Dom0 to know that it has the > > appropriate microcode via FB_CLEAR. Notably, and with the updated > > microcode, this changes dom0's > > /sys/devices/system/cpu/vulnerabilities/mmio_stale_data changes from: > > "Vulnerable: Clear CPU buffers attempted, no microcode; SMT Host state > > unknown" > > to: > > "Mitigation: Clear CPU buffers; SMT Host state unknown" > > > > This ecposes the MMIO Stale Data and Intel Branch History Injection > > (BHI) controls as well as the page size change MCE issue bit. > > > > Fixes: commit 2ebe8fe9b7e0 ("x86/spec-ctrl: Enumeration for MMIO Stale Data controls") > > Fixes: commit cea9ae062295 ("x86/spec-ctrl: Enumeration for new Intel BHI controls") > > Fixes: commit 59e89cdabc71 ("x86/vtx: Disable executable EPT superpages to work around CVE-2018-12207") > > > > Signed-off-by: Jason Andryuk > > --- > > This is the broader replacement for "x86: Add MMIO Stale Data arch_caps > > to hardware domain". > > > > It wasn't discussed previously, but ARCH_CAPS_IF_PSCHANGE_MC_NO is added > > as well. > > I deliberately excluded IF_PSCHANGE_MC_NO because it wasn't relevant. > But I suppose Linux is looking for it anyway? Yeah, it looks like Linux checks that bit to determine if it is affected by what it calls "itlb_multihit". That's just from reading the code - I don't seem to have hardware that actually sets that bit though. > IF_PSCHANGE_MC_NO is the mouthful meaning "the frontend doesn't have a > strop when it takes an assist finds that the iTLB mapping has changed". > It's only interesting to hypervisors looking after an EPT guest, which > means that it's only interesting to expose to HAP guests with nested > virt. Except we disable mitigations for nested virt because there's a > bug in the nHAP code which I didn't have time to figure out, and none of > this is remotely security supported to start with. I can change this however you like. Basically my reasoning to include it was that since the "_NO" bits say the hardware is not affected by something, it's okay to pass it through. > In principle, TAA_NO's visibility should be dependent on the visibility > of RTM, but given this is all a pile of hacks anyway, I'm not sure how > much I care at this point. :/ Regards, Jason From xen-devel-bounces@lists.xenproject.org Wed Jul 20 12:41:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 12:41:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371571.603504 (Exim 4.92) (envelope-from ) id 1oE90m-0002Tp-Hy; Wed, 20 Jul 2022 12:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371571.603504; Wed, 20 Jul 2022 12:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE90m-0002Ti-D1; Wed, 20 Jul 2022 12:41:08 +0000 Received: by outflank-mailman (input) for mailman id 371571; Wed, 20 Jul 2022 12:41:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE90l-0002TY-PS; Wed, 20 Jul 2022 12:41:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE90l-0008VJ-Ls; Wed, 20 Jul 2022 12:41:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE90l-0006Uh-63; Wed, 20 Jul 2022 12:41:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oE90l-0007p8-5a; Wed, 20 Jul 2022 12:41:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MskSyd/GjLPEd3vKFccLlZaCSEVrcS3T31EpPPtr84Q=; b=flCL5Auj9WUoghktVPPwFzaxYY gxR3eCAM58ZY5mNbztcki3kNWqp/ywGbz3RuT9YXlwcMwSH1rBSUrQuGn3AFCy7Dpsa8sBi2ETFmO XVvnNkG460fSEJN9c1XHSVTslMQjm/y95aWueus7tqVkzbhHEk5IkE4buow2JbSZt80A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171702: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-pair:xen-install/dst_host:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf X-Osstest-Versions-That: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf From: osstest service owner Date: Wed, 20 Jul 2022 12:41:07 +0000 flight 171702 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171702/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-pair 11 xen-install/dst_host fail in 171695 pass in 171702 test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 171695 test-amd64-i386-qemut-rhel6hvm-amd 7 xen-install fail pass in 171695 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171695 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171695 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171695 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171695 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171695 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171695 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171695 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171695 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171695 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171695 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171695 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171695 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171695 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf baseline version: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf Last test of basis 171702 2022-07-20 06:09:55 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd fail test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Wed Jul 20 12:59:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 12:59:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371682.603568 (Exim 4.92) (envelope-from ) id 1oE9Il-0007lj-MX; Wed, 20 Jul 2022 12:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371682.603568; Wed, 20 Jul 2022 12:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9Il-0007lc-Js; Wed, 20 Jul 2022 12:59:43 +0000 Received: by outflank-mailman (input) for mailman id 371682; Wed, 20 Jul 2022 12:59:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9Ij-0007lW-SW for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 12:59:42 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d10f81fa-082b-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 14:59:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3129.eurprd04.prod.outlook.com (2603:10a6:7:19::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 12:59:37 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 12:59:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d10f81fa-082b-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fpTehVZRMxJAeaY8d9/KUQ9WDYnflfD66BlzV+xlLrLrhjlC9FvLhRb5h2lX0gWoUIz+aa84V+C5iGST2lesRLtS6T1GEFLwbz/lceXKXdM75SGU92aBQgKwhD/Hq3BpKODpqPBNQ+qEWJUjA2O5ycaKS0MBe0YAB+S6MGDEKu47JCrU0ZBC1LrnjdovhIh8rdlmD41tYy8YEa2ly7BabbOR3awccFUcWTdrv231587I/YPS6OLzBYV3iKl3f1kGMca3S212G41QbwNRL01REasN4FKyqo/2Gdqr0fwPgmPRd1jf11h6T1Hn9O+i9n5lHqPYeda+y1x2lnFRQyPvjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/hnnNYAAcECQlEoVrAmax3zp/3OszhvmF6k3LHBTMg=; b=E+CycUuJXlWgOUPPPF5QyJvrTwQgA6L/ryucFG4/EAySUAoheb63TZZQrqlUP8juh4ISGvhbV91FdXEVeaZOo0dJ+BMgWQsepIIV7n7YEl6ROk5u86m91RTF2Bt6Faa/R+6weZpDUNKAddfDnLSREBCfiYYUg8+nzWnS6G9D+cArIPrRwg9zqr0T6mw5kHqiqBKhxes9/de9JgWQ2uZJjGA+WVDAennBNanl6PeJBm308onWVoNhNzoI4xH5BCvJ9beAnE0ELvlQZB8WCzsJJlqZoSo5/i1ZyWuC06tRWD73bSEk8XQiWxBbjAdmAiHPObC1tFfFjf67BSmTU+EazQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/hnnNYAAcECQlEoVrAmax3zp/3OszhvmF6k3LHBTMg=; b=Qrs/BNgZp3rOnCxSVfwLIFAYBh4TmJGb10POH7scuAkk/fgOvULX4S3eomSSKYUSKAy/Zj81NPYoYTV8DHqCvKANtF1X6wQC6hyYRXEOQNXRIeNCPNQvwelYhBXfRhx5wzeJXI4n3eyDgtOLrWhH9rMkn99Lt9DrszTTFzlwfsXVIIXrNgeDyN9c8jh4/1ikKcVKDrNU+iZzjP+s0QanicSV+AERw/PN9DVjU4lsb44Ni9PTuGO/OPQVIz+wesVTLiFvyj6T4NS7S4ZCK0Pc/ZRpAW7kLoGhosaGH8plAtMA5RdfyKXBdjJuzhYk6qT4RB0bwHpS/lkw5MA3XY4HUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <59fd14e8-3fe3-4e57-4c77-da380f06108c@suse.com> Date: Wed, 20 Jul 2022 14:59:35 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US To: Andrew Cooper Cc: Michael Young , "xen-devel@lists.xenproject.org" , ChrisD References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0103.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c37d5f10-a261-4e88-54ab-08da6a4fb3a1 X-MS-TrafficTypeDiagnostic: HE1PR04MB3129:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7BSxLSjt+BJsi66OwOlKOL03CQo+90m1fmBs1fWb+WaMhDhzQl2K7+rBe2OPll5okAGD3xNqGjVhls2CKcuf4B7YNOfEyEc5wzALNZrDXjTQFSaLR4zIJ4j85wQ2eyJd62esuy+iw6tYhRqBC7g7AVYP1RoUEKfOzJV/ELRg9oO3Rpiw8fI8Fetx/IeiXDNV9VcSj1PSlU0CtyTe551EaPApzGOC1BWiWEwrrNOv0QWfUS5ju55AMRhu3eb37FVHAAzyrrtGUUOdPgnZHSWkrSrSOSmrWNRFEp1mDpVMs+lSqzRDX0Ynb7G40rBbNyalw31+Ad4oBtzv8ndmtqodqMoMVS5rQQjCmczeWdGa3pN1jURQXI9gqcXSuLoUuD2kcp74ERWF+BSFAN8MtNlMD8ds5eYIOo5CCOpzgMLnKarX456ulD/+Rx7Kp4DdtC9n7/EweEkeaQpotCMX7gFZ7UjiuTDqlnx+KZ3AYx2Z9lbqZBVlbzIIm9s/S6WZsGGPsaM7YN8xnKTp0u7ejxsycsbyllKFMYKtoNRZjrisWrHU9HUoIfmiHZynW6TPfg7Xz9YzUQRC4/HnhqaGSsjsJvNOoJq58lW9uCEpcljGCz1jqbmtDNwS/uf7s5/QTgC3auBVtg30BfA64adwGEPYK+TAeP0xacPgecSlN5a2L9VQ/vAwleHtbdlLmI60Q/iDBROTLyuiYaMwUDXhyEV5/DCJZglQ0U7KmerOIwLKUcJ+kAvEHCOX646OqAOmefiN66Qi3Al80X/F6W3kUt7PpLR7LXNN3MddEjdPwuwjMifMNa4okfXwiqdnFixqgpZe/w8kqlGRl79QUBlO042uZw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(39860400002)(396003)(366004)(346002)(66476007)(86362001)(8676002)(31686004)(4326008)(478600001)(66946007)(54906003)(6916009)(36756003)(8936002)(316002)(6486002)(5660300002)(6506007)(66556008)(31696002)(2906002)(4744005)(53546011)(26005)(41300700001)(6512007)(186003)(2616005)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3laT1BNbk9Obk9qVHQ3NkFIUWxybVFNSTkwZEJNN3hCcWdoU2cvY2M0NmpO?= =?utf-8?B?cExERWR2TmdLWVZ5cDV0Q29ZMFhJb0R0T1FQclZEYkladnYrRXhkc21aOXEz?= =?utf-8?B?cW4zelovKzVDMWVnY2c5dTU5NjFKNnRuM05YYnZRckNqRGQ1dmhnR0RXMCtt?= =?utf-8?B?bTIyeUlPM3ZwazZqaDQwYUpUdFAzYVhVN2Q5eUtBYzFIaHJOV3FhUXFZYzZD?= =?utf-8?B?eFFYZTY5cTNhaFpqK3d5SytQWklsVUNiVXo3L0VIaVhmRTRzUkpTQzN2OXNL?= =?utf-8?B?WHVhSGMrRmg4QW5ZU1l6cFB5Q2ZxV1BIRFpxaVgwNTNYMnh2bnpqRWNUZU14?= =?utf-8?B?MFYvNzJUbDB4Rk95MHVvK01pWGNTcGgrNU9EM05xM0dNTHE5aExUZGNsQ0JQ?= =?utf-8?B?NS9ldjdPaXMyckNhYUhZZTZmekxIT05lWXFwU0lYMFI3TFVBWkpMazdzcENH?= =?utf-8?B?NmJpeEFOdEtXRFNaWXhsSWxWSzJOU1lkMWZHbjZDZis2NlNOTDMzU25oRkw3?= =?utf-8?B?L3l1ejJXMTUxbFlRQmZKMjVMY3RNaG5Hd3JvMGVPcm9IeGdSQkhnUGNDZk5G?= =?utf-8?B?aWpaem5LK2E5VldyK1JGeTFKeDBBbEZRMlJHZnhPN29nVG5NdEt1S3JObmZw?= =?utf-8?B?U3lNcWxLYXVxN0wrVGNNalNZOXdwVGZZekhkYnhlOTFaRjFvMGhNQk5rYlMy?= =?utf-8?B?TkY5Vkd6TkpNejVjS1MvbUNrb3Rva0d5NU1lSndPZ2JFZDIxK09IdmdTb0ti?= =?utf-8?B?eitKVTM1WExlRzJmZE01c0wzU2RDOWJMc3drb0lFSlJZNVZiZ2dzc0MzNEV6?= =?utf-8?B?bDBYcXRSeUYvc3pwOFZrTkpOdmRnRStDZmZ5Q052RzF1aTJzblEwdWxycVBG?= =?utf-8?B?cVAxK3NSWHJXV21kRjJQczkyRk01TTBYUzZ3a2l5UFgzbW5adzRKQUFoc20z?= =?utf-8?B?UXlGaWk5TURxL1JDTUNpRlNLNjhGaWlKa2MvZ2JVWUgzeEk3VTdneGFEWEVL?= =?utf-8?B?NzNMQklZeG1ERGlVOVdJa2x5TU1nc2RnUGhOSHh0eW0xZUR1UEtUZDY2dnNB?= =?utf-8?B?d3ZLU0dTdzl3Y2JDNVBSME50aTZ5Ri9GbE9rdXZFcUN4Y3lDc3pQMEFROS92?= =?utf-8?B?Q3VxbEUwRHFUcXNtT0xvTDFkK0EySGN0bWNLNXRMaVVJOW94YUZEa1BhZ3ZF?= =?utf-8?B?N3hTNVpPV0o3c0Z2amZXR3NsdlpxYWJKOUFYTHFEVXRRbkdCSG9nM0h2WWdN?= =?utf-8?B?MzNLNm5jSDFiaVVVSTQ0am9IRUpxZkJzeWFSekNxVU1OenVGNmI0QW8xQy9Y?= =?utf-8?B?cFhHRk0wRURnRmUrYndLa3dWc2hQN2FOdFp1bi9Zd2xzWFlsa0dydXBQdHlP?= =?utf-8?B?MjN1ajNaZU96KzB3R3oxTFdEeEdzajVpSlV4b0xlUTYzM01GL1J6WTZaUEQx?= =?utf-8?B?cGtwVmwrZDNXNm04TE1oOUgreEcrUmFxYng4YjR2RjNRMEQyeGsvalNGVHgx?= =?utf-8?B?cFJVaStXdG5LMG53T3FQQTdhanZDME5DbDV5Q0RoKzlKVzRFMWsvV1Z2TStP?= =?utf-8?B?WHRPQlUzZEgxQ1kxUDlBUGhxa1pmSElSQ0o2ejV3WkFEcDhZRllTRmZEUyts?= =?utf-8?B?djJMaDhST2FjMFlvMFBQWlZMZTI2OHpsaVpBTW9PZXgvNDRYTVFYL3pyQUUx?= =?utf-8?B?WUtWVkdtL2xUckpvU0VoMzRlMG9FRlpGMlJyek96Wnp4V0YvMXcxekhWMzN5?= =?utf-8?B?andFNmw0elg4UHNPQktBdzdHcXFtcEpGNWd6U2MyZk9KalNlU2Y4Y0kyMXoy?= =?utf-8?B?c20yaUJwVFBhRDNtUzU2WW9zOC85QjlBN3YxNnJYSUgvM3Jmam4xSkNKSUh0?= =?utf-8?B?WWplSTB4aGIzZG55QUFBYkVXbHF4QlMzczFETWZ2T2NTSG1MSldhbFVsUGVk?= =?utf-8?B?cXQwSXBOWnJqVEREdDF0MVRkR0RNOGRZWVpnRjBWMVk2MTRVbVU5WU1NeEty?= =?utf-8?B?MzRQMk90UnN5QnNXcHhwZEZKT1pLZ3NEbk5BZ2JzbmE2RjFsMnp6ZFU0Umoz?= =?utf-8?B?R1l0MmtZL29sVkxYakVNWFJiSU5LYzIzL0tTOGFPOUVYVkpFV1ltcXFHT09m?= =?utf-8?Q?F39zWCWoKuGvO516wXTH+JtZ/?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c37d5f10-a261-4e88-54ab-08da6a4fb3a1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 12:59:37.6251 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bruzbGNyj31Clwv+7WOTSdztu4iiuaV3FDgf5jswo2hA4n0T7Xbs3MmQe7egnj2EgwTFvKAe7fs8ufVOoNFcHQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3129 On 20.07.2022 12:02, Andrew Cooper wrote: > One observation though.  We do pass -mno-sse but not -mno-mmx.  I still > can't figure out what makes the compiler think there's any SIMD to be > done in this function. So this looks to be "optimization", done in a few more places. The pattern is always the same: A 32-bit GPR is known to be zero, and there's nearby code which wants to store two adjacent zeros. Hence they take those 32 bits of zero in the GPR, move to %mm0 (which already zeros the upper half), unpack it to have the 32 bits of zero duplicated into the upper half, and then use %mm0 to do the store of the pair of zeros. IOW they "auto- vectorize" these two stores into a single V2SI (using the common notation) one. Besides this being quite the opposite of optimization, of course we didn't tell the compiler anywhere that it might use any of the %mm registers. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:20:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:20:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371770.603615 (Exim 4.92) (envelope-from ) id 1oE9d2-0005WA-Ts; Wed, 20 Jul 2022 13:20:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371770.603615; Wed, 20 Jul 2022 13:20:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9d2-0005W3-Qy; Wed, 20 Jul 2022 13:20:40 +0000 Received: by outflank-mailman (input) for mailman id 371770; Wed, 20 Jul 2022 13:20:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9d2-0005Vx-7A for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:20:40 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10084.outbound.protection.outlook.com [40.107.1.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be85722a-082e-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 15:20:38 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8603.eurprd04.prod.outlook.com (2603:10a6:20b:43a::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 13:20:35 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:20:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be85722a-082e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGlJQLh6ZpdJFH3BXyRgynXQdZkef6psuKtZYE+BS5HpXqwcTt6eo9fqMZSENyU/xIa98wv2WiaGY0aemkCD54Tj+yykQRbKIRH10dkrVXG250Kr7byVPmASsxGxsnCSgJ4BLD2QNcu9JPyLO+O2kfx/1s/HUHlKxW0AqYIjApQDtcoNTSEqO9nnhj/Rbf3yn0OtCyUY+nNWHEMrVv6KpDizP7yE3F+qYZ2CFEfDgAvYPWZmgWRK47pu9AgEZL5RYvoxlvkw6FWAh+zrlELBNuH4HWWckVk5ZAEFkB1nk9PJ+DGgrLVn+58rxhaqUWIu3rzZ2tc1220iYrmbqfHfNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E662UjOG/dd4T1UFc9fVSeya/8Qb8FOhoi4evWEj+fc=; b=CcH4v9WIuT/UTknXdy5O5uP+uq/sa+siXjFzNVY06DY3jI9aUt6SpOU23XQLPfLwuI6/p4fvMbGNW+wVPWcExUimP7HdoXQN8faFUrOvkhGp4EhSqJSif23YlEzjoZ5BFkNEM8L0P8ZnX7LsYw7CRaoKgThpMPeaO8Nm5cfNW6Qxi55yNKAjtIRBFMTONJCW4MP7qHn62glZwwGRODRolQ/NMXLX7d0Bx35VwdMbXKa9CgmCs8zAF3vULLgBGIT9sTQWds2MjFOoGv2OTVfwIsmB+e9ILCop1dKblEqLrGiM4Iu9B43khtTcOJlGhSNDKm0DoeL5sykkcyBNXf4UQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E662UjOG/dd4T1UFc9fVSeya/8Qb8FOhoi4evWEj+fc=; b=EBlZEZyiEixSUo5L9Nrxu0zZWc37HML7cyO2GC+CD7C8Kql8sSFIwM0odrKqcKqTjHYleQLFU46Cok+0nuUkzdkqISjWH1gSkA0wwy1XxbLtt/5YJbO/bUNmqJxB16SP8qTLASQwKTuIoHXD5mWEts5L4EMNbTw3WabrzZySPxM6fzbYU/xA580cQSBbEoGP4z2bc4KvOwryT6MvCANMQnjYIkwUheuXJf7EvMxgKklHqWZTmt1k2ZXpd50G7reWoMzXKvs0SQrlU+gRXqpiohGKkusbq+Iq9Ydxb8qVHUVHwkpr1IelYQBGYLhDhesIHmhnkC6yFqFUtWzeKAjWVg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 20 Jul 2022 15:20:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US From: Jan Beulich To: Andrew Cooper Cc: Michael Young , "xen-devel@lists.xenproject.org" , ChrisD References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <49352a0e-89ef-4f73-1c4b-ecfe6e0e49f0@suse.com> <5bc211ba-96b4-b705-d600-e01e41e936e5@suse.com> In-Reply-To: <5bc211ba-96b4-b705-d600-e01e41e936e5@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0175.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 437b8726-1355-42a8-48a3-08da6a52a185 X-MS-TrafficTypeDiagnostic: AM9PR04MB8603:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UHhcNq3M2TFmfuOi6rqj6gLIqxwgAeVPU+Rqud1AnTy8cKlSMWy5cSI17rMAFFZdvxuDUh54gBifz3C0If5hRJEn+tReQRtfh89ONW02KPVmAShV1Q9lWGQCVL5xHjefE1G40R2Y50Bm2COYBknU/Ehgr+yB72ypK9N3N9ciOSI3AsnZgJmL+pH4RPEdHf4HNT8wULtCeYTllTH4u8L/uALuHXL4TcxsE1OtJ8nwABp5JdyOcmtC0XXp/16e926lrf5oVJHey7xsOMxQsrz7NNT/OkMUn7ehPH4b+Yj08Jh04n4iFb06jpZ8T48YJ+FC8S1W3DzJblXgnif5JlGXK9q7SAWnDydNmclxQ10Iyw6+al993xSHoRcxy0eQbaSc+OtYE6J+fH3PKVsPntU/n3cVgIXZhMj9aPjn4j2Wxyk7UVHi3wf9y89iJqd4eAXeTrah9VdhiIOBxMiBYuIj5eXuA6tHeEBUb+5VID2vilkCLdR4tc7MxipdvfQp5hWZJJY+hmMKnIXC6RaV+KlDJZaOqllyQoKleEYz9L4/dvhmraFvVM0fY8JL9JKDQbsEU0nkZuSMdK5/b1VvvikrzNdRsNQLaIVTGGcWXODiO+3rCZ+UrYaWZ6f8rOSCFrP06l1ZEJ+b3WO+DLyrV6CjKxkVf8a4tPPfmCCZNoCK4wgNuhAGVqLi9RmZguz4wYXcRs3OpNbQRJOsepaTWuVotbwwfzzooW09cTQOCkw2vjP1gMthunZPiVlfT5UrL2AdFuvUAk2Ho9y/46D916oZq0sPbA1lPN9e+wB6SCAZiQrmeM+vqoWg6w4qRiUZpxiMU4VUo3W5DigLNhUjgTpvqYp4O4oKGrCjQaHcB8YYH3A= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(136003)(376002)(346002)(41300700001)(2906002)(31696002)(86362001)(36756003)(478600001)(8936002)(966005)(5660300002)(6486002)(38100700002)(4744005)(31686004)(6916009)(2616005)(316002)(54906003)(186003)(26005)(8676002)(66556008)(66476007)(6506007)(66946007)(83380400001)(53546011)(4326008)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WVpSVDJqNFdiQTZjWFpwWXdBNExuY0Z2Sk9HODM2S0NKRnZQWVRidDcvdDZI?= =?utf-8?B?Nkl1RTdLL0tmL0FQVmZDS0FVdDFyZ1cxOXZRV3RqY2pqRW9nVTlrTXduUnVs?= =?utf-8?B?MzFsYmdPNWFVaFFJSmpxQlZqMjUyQ25XRkNUUUhldWEyZ2hjRXFEbDVBeWJl?= =?utf-8?B?NDRma0Z4TmU1MzQ2STV6YXVQeEU4UWpaWDRnVkRCd1lqZ1ZPY1AvS3ZZUTlY?= =?utf-8?B?NkVYWUh1Q3kvYloveVpyZWdNWDZxOGlXb2FDK3A3dzlUVnAzcU5qd0I2UlFY?= =?utf-8?B?eEhCZ0JuQnhGZXc3QTJtc3B3SzFBcmhVd3NTU2hSRE9MVUdPbU03c3VqMW5k?= =?utf-8?B?dE9LSzVsSk83QTl4ZTlGcHJuU0Rma1oxYlVJYkVpbmdpQjdzNFd5bGRwR1NC?= =?utf-8?B?UDhyTnlqcW5FVkFmUjhtdzN5aWs0V2JnV203dU5KVHBUc0xLTEFneFY5a2t6?= =?utf-8?B?SnZ3TzJvendVeFJ1aWVKRXhLTzlVdkVrY3VOVys0bjc0OVlWaGIwck1aUHpq?= =?utf-8?B?S21ra0x0cXJqczV3elF4QUhjMFJHS3RJaHR0djJEdmxvWUhsN1VUNXF2NFJO?= =?utf-8?B?aE1Rcll5V0FHVVorV1dNL21ISHV1U09sT2g3UjY3bDErcHVhbitIR21QM1Iv?= =?utf-8?B?NlRCdXlCVWx0U0FlNmFXQytLTHNuM3dZTldqdWN0YkE0bVhQYmIyVTMrLzE4?= =?utf-8?B?SmpTZ1RQRU9lWjVjYkpQRXVzVlJuZWk1K3hXajQ2eW1xRHVjM0hrR3pOaXF4?= =?utf-8?B?eEJ4c2xmd0hhNkwzYnp4K1I1YlJVNy9Sck9XSU83OG9GU2hYQmt0ZDA4S0U5?= =?utf-8?B?QUh2RnI4RGk5R2VsSjlIZGF2Zk1MSTRmWThnWXlPamcrTCs2Vkt0L2EvR1d5?= =?utf-8?B?M0JvMkkrWDJkdGlKQWRpb2tVOUJlYnB6dUdwTVdHQ1lsdGhBMVlLL1dmVWRC?= =?utf-8?B?eWlRemg5ZFRtT0kySEJyMFZZR21jenlVMDNVSzFWYzZ2MGFnT0VENHRRUE81?= =?utf-8?B?TFQzaFhnSVpFY2c0czFTRVZlaVRLb1BadDEwaUd1VlAzcldtSHUwTlJDMUtm?= =?utf-8?B?Rnh1TUJTWmwyRXMveFoySGR1Q2VFTjRpOGlDZWNsLzVlQ0JYYU05NUtPZ0VK?= =?utf-8?B?SWpmQ0VCRUNzWDVFNzltZTNsbFgxUzNldFdoTzQvb3VtTUovOVpUOS9HOG1T?= =?utf-8?B?SElrdzZWemJMMU1GNStJMzJaaFdkNEQyYlhBai8vNFNBNFdIei8wQngzN3F4?= =?utf-8?B?UnR1c1RmRUIwTGE0dVBJNGFDakw0UGhoRFcrODViWm5iaUtyMG9oczVtdWh2?= =?utf-8?B?ek5hWlQvd2YwSm8yVzd4ZWpKSkZHbjUvVGwycktLNEhBcDl1WUNQL3BxNDkw?= =?utf-8?B?ZUowTFhMaVFybzViVTRkeEJLa05jK2pEZjBpejBCblhJdWZidS85NFpJeHp6?= =?utf-8?B?TlM4YTlsRkxDWE1ZVmlsanc1dk9PdExlc0NTVjF3OXQ3OWlhR3JYV2NPL2U5?= =?utf-8?B?U3NJTmZiRmtQblJIYklqTlhsS1ZrSmNybGRJV29QeFRnR3VtcnRLOE5NRVJH?= =?utf-8?B?SG5LeFJGc3lRaXord3JNUHZNVHBlbUlzS01EaUExTEdpWFhGVXhEVFhUNncz?= =?utf-8?B?VnNEMFlTQnlVVGtoNnpHRVVDK1dsTkpOZHRaemZweUdYTkZBc2w0S25VVzBW?= =?utf-8?B?TjNHajRaQlY5Uk1uZXVERGhobW0xQmJMNlZkRjFzbHVid0MzN1luQi94TW1y?= =?utf-8?B?WlFNdTYxTEpyNVFsaExGbFRoOTZDSGpVVGNXZThoUlJ1V2gwM0x6NFRxWjNz?= =?utf-8?B?dHgwc3VhUk5EVXIrZnUxbCt6d3ExZ0VVQXF1blk2ZEdsTE5yWldYREt6QVE3?= =?utf-8?B?Rm9LS2paa1l6UU1JVlYvaGNHMWN2UzVGemZvSElaaGw1UFMwUGdlU3dSTTNM?= =?utf-8?B?YUV6VXFwYnZNdE1DU29yUHIvNnNscWNsU2E2bENCeWpPTnBlVnNhZDNhVk1j?= =?utf-8?B?MGNQUmp3aSttSlVDZmZjeVJNVFY4ZjIrbkZsQllTVWdmSGtqUFpSaVlVRTRW?= =?utf-8?B?V2VTR1dVNjBTWURRV1o1dGdvTmpIOXNQKytEa21GQUxzNXBQbnN2YWQ2dnIz?= =?utf-8?Q?pybaeIoZwyHHpmgh6D4/dKfi+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 437b8726-1355-42a8-48a3-08da6a52a185 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 13:20:35.7638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: SLiphtsXOAoEF5NP+lPO0ADeDJ3GHKh3/JnKUNEax8YvepVZrfObcnbx9RIUPPpB6LC7Xj9h9fBMX50a1ztgbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8603 On 20.07.2022 13:28, Jan Beulich wrote: > On 20.07.2022 12:02, Andrew Cooper wrote: >> On 20/07/2022 09:19, Jan Beulich wrote: >>> On 20.07.2022 06:48, ChrisD wrote: >>>> So, you think it's a problem with fc36? >>> Well, if that's where the binary came from, then yes. >> >> So >> https://kojipkgs.fedoraproject.org//packages/xen/4.16.1/4.fc36/data/logs/x86_64/build.log >> is the build log. >> >> For iommu_init.c I don't see anything overly concerning, although the >> quantity of nonsense on the gcc cmdline is speaks volumes. >> >> One observation though.  We do pass -mno-sse but not -mno-mmx. > > Right, but that should be no problem - the compiler isn't supposed > to enable MMX without -mmmx. Or so I - wrongly - thought. Will make a patch. Nevertheless I consider gcc behavior here close to insane. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:30:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371776.603626 (Exim 4.92) (envelope-from ) id 1oE9mU-0007Cq-Os; Wed, 20 Jul 2022 13:30:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371776.603626; Wed, 20 Jul 2022 13:30:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9mU-0007Cj-LW; Wed, 20 Jul 2022 13:30:26 +0000 Received: by outflank-mailman (input) for mailman id 371776; Wed, 20 Jul 2022 13:30:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9mT-0007Cd-Bv for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:30:25 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50056.outbound.protection.outlook.com [40.107.5.56]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1bea42f0-0830-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 15:30:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3272.eurprd04.prod.outlook.com (2603:10a6:6:10::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 13:30:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:30:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bea42f0-0830-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VX3D8StgsgPxvjFwq5G4a8CnBh5u2PdpoWi9MSn+8e+ru9rryyLPs3CsNnL2Wt61Htr6vIYC/li/472LbtFZIwtNrxqCZTPteG8KPAAGdhoSybtTRaiDVVRXAqQn+85Yqi/uun+AER8h70KXKgi5gZf2yda/2ID1iERb9CesG+9TphFExqrvTja2kuJEmoBQ0czvXs4QyzFNulCzyxLux2si5w7cqXTit+NnSfjJ1RZLselgg3PyqhJ15SMMhUwhkI5mk813HqCEw7eqskZZFKg8NfTh6iYR12tpRgVTG8C5q08hYNkSoL+6YQBoAR2qQJdTxiOI3SmC6m9YIIMCUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ai2kHb5xY3mXJsaE8dKL6c2HKnZO7qf+tGSpE0LkuW8=; b=Eb0jbRdApBcjSZtTAvfs3tSmVyYyhVt2PNk54VRRhghusmL7E9+kGOJtDSlXHsyn3tSABapEgLZkfuZZeCb38+7+nW3bTjz3/W/2ONg4vKViyCDuwo29948n8dbPoaF+NZnEEw8Itnmz2cQjj28Ejq+MJcu0RHlgU2p9Z5D5P7RXDnd6aRu26M6uR1L+MFOnGsZ9LkNy1g5EQ+IuXVgaTR55TIR/EiziEYlqkKuR8eYQLfdqd68nFk19n3tx9IJr+pvdKvK4CjxYh9Klpbr9xFXLc3XYyk868i63Er718d7PlescAm0T3sdX+Mx/KdzsKlBR1uLHZ+CuUeoekH20sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ai2kHb5xY3mXJsaE8dKL6c2HKnZO7qf+tGSpE0LkuW8=; b=VzBKL2ytXbRU58fFVzavqEi1VZoveVtSv6GtPvvEGyXI1Ej6VWqj6vR0yNzNk7JuXBBgkj5c5G78cxzOLu6P1pjUqixwGrh3a7squfJdS+3bDb+um8dBnCIfQIYwdC+QpTfMBfTdlk0yPn1EEyiaiG5cVe4YZwmnCMrxtcI3wPJSoVaHNiLmZeza/g8GP68xDuWBrh1lWPRonpASdR3nLD3Dlk2zD8kY4xm9FJPb8RSjdAP+DsnScBsIK2HvayWDXcKDB7UKMJiVkpCu+ys7tVssWGLpuiw80Yu0AFyR1fUOrDo00uV7Ko4YkoGsBpygghX4XoaP/8e4xCG3I20H0Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 20 Jul 2022 15:30:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , ChrisD From: Jan Beulich Subject: [PATCH] x86: also suppress use of MMX insns Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM7PR04CA0012.eurprd04.prod.outlook.com (2603:10a6:20b:110::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de63d4ab-20ae-4f42-3647-08da6a53ff4b X-MS-TrafficTypeDiagnostic: DB6PR04MB3272:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: HZF79HSnRfPjerikhECQVxMtRSF4rxeRsXhN+Z5QXznOoEg+KY3TnzjMNQuUlR4zPQRmeyPTbiSmVg2ifKP3cXQbijNqVEKmBzezg1FPVoFpkXbQEVUbfscIUK5Dql23diL9zf0EKi8yJC5Jrx2OoSSW1j44gdeINi0wij5rVCbr2ZaLAlFe0JBZbEwnD+IVLjvhyZgOxbdEofgi/h+0/Bnf0DMykiVnXfmPF8MSYwX+dh6105gkWv862gW5SQnEFh123gGHHjgcpfQP0lfqWlAnxYg2JQQhZHCYze9K+ft0Rkpk50yOvkAMvK0NpiEWW+ywnyYKCNqV7StmhL/Lc0wUE1d+t3s2ggRv8A1ie+klJF6fzoaOgGVJGQ2aL1mchncadwYcgDMnaGWu0HiV4T4+WhTMK2lhcNOJC1T02kc9IAQEObhEk/b60lRgNmFZHLKYiKJyd4NKCxZ9Df+LvqYnpiXCTWawT7d7NYZCgQJYQ3fM/aOCQrPxZt7CqQiL2YJILGq/ktDq3EbOe6Q2+gbAcOM0gOBG8HBOeH/b/5AbVdV+eSUwLnLW53qGiAdQPVXICpu8h6gKu1Q1TpVI9ZjvcMOjb6i4nglTB2dyN4EJA7eQ8NjSK14QE6DOY1w0FgvdZbY1UB5xaVVCf0CeaelO7XXci2A7nmpttTP8j7jrlSHXx89iA+yKtlSGMrNIGpbI1Y+ves7Q2RY8lON5jbTT7yDqZbVwBd0w58TO1el4DM6IpDTv8L6srq2Fthmwh08/e59KrXwEvKV2JokMiVVq4pAZoZOKXiDqMuyfQm58RNLlPwr3bDVy1ysYZLZuImA+or3Gt4aa0AIrnMUzqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(376002)(366004)(396003)(26005)(6486002)(31686004)(36756003)(8936002)(4744005)(2906002)(41300700001)(5660300002)(6506007)(31696002)(2616005)(186003)(86362001)(6916009)(54906003)(8676002)(66556008)(316002)(478600001)(66946007)(38100700002)(4326008)(66476007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MDhGZXV3eG9IM3oyNTMzVERRSzJ1YXF6SjAvMmdIQlBvQ3NZYXB5RWZFcldD?= =?utf-8?B?bi9IZ3IweVJhVXI1V3daU0o4OTR1SkdWaFJwL0xaRU1VT05qS24wK08xa2I2?= =?utf-8?B?VEJya1ZqWjNKQWpjMGpZcXM4Q09JV2VhK1B5OE0wTURDc0diZ1M2VUdRQkRB?= =?utf-8?B?MEpTclBNMlB3a0VxM1NZb21pb2x6c1dCVU9zUi9LVkRvU2IrYUtXS2F2TW1V?= =?utf-8?B?VkRONFE2L2FMcE9ENEdnQllpOVZKeHhXVTdrZFI1ZGVWZzNITXZxZ2wrWjVF?= =?utf-8?B?c29Ba2FsZGNrZTdxaUNJbVJNYUk3VUtSV2JQM1RTRHcvcjRMeXIrSk9EREQv?= =?utf-8?B?ZjUvYnAvTEx2bXd2UGV2OHZhK1duYWF2aEwwNnFiSVhxc0VPT1BmQWFhZXdy?= =?utf-8?B?bW80ODdPeWg4UWROK2VVNWtxaFhVYmJRc2lldER4aEptTkZIOUw0c2o4ZzBk?= =?utf-8?B?bjBCZFQxV1F2Qm9INjRKOXo1NmMxN3pCdGZvYWtEbDl5MGh1YjVYL2VkWGNY?= =?utf-8?B?a2hIMFZLeFoxZmlhaUtzMloyYmdJdVVJNnQ1aE9iWDlCS09MeVM5ZTF6cDQw?= =?utf-8?B?K0FabTNwZ1djSERRYm16M3RaUnZubHZpYy8wb1R6QTlrZ25SK3dSUFVFcGx0?= =?utf-8?B?K1dJb2h0QnFodm8vVGhFeXNOUjhnRTU1UDR1VXNnakFZWDU5NU51NGdyZXJG?= =?utf-8?B?cXNtcUlTOVIyUC94KytKU2xxc21SbytKc21sMU4vRFAyODJKSGpiaEJMblBG?= =?utf-8?B?ODllQ3krWlU3UkcvR2FwMXZJTVlmZHhLWlQxS3RZS0tCSXFpeVVSeVp0VWx5?= =?utf-8?B?MXdaeUFSV1VzaVdnVkpLWTlrbVdRZmQrVFdkRElOeDF3emNtRHUrdHZEZWhK?= =?utf-8?B?Tnp0WFI0RjZ0d05XakkrSlltM0RYRWtaYzNVd2h2TVlmMDE0WUlIUzVxejZD?= =?utf-8?B?UTFxam15QjRHY3lKdjZXdjZmNndSb3liN1kxQit2UThEMnI2RlNiU2czVW1p?= =?utf-8?B?Ykoxa1UzT3krUkJEWGkycmRZYWNpYzJITmVTaTNRNHJjQXppWXh0MG1kRE4r?= =?utf-8?B?VFpBbjdPdGh5V2UrRTJiRGVFM2gyOWhiWHBKV0kxR2xFNk84VjVIMzdETXVt?= =?utf-8?B?b1REYnZPNlBlc1RFSmNrL0xOUnlnTHI4OUNoVzZNOC9JSFZsdTlPdWt4Vi9l?= =?utf-8?B?RGFvV1ovL2k1Y1NKOTdmZFZUcVFlVkZvbTliTkF6UGZpSmhxRWxPZkw2Tk1W?= =?utf-8?B?R2pnRi80R2RYZ0dUS0VqTW5HUHlLaHdZTHpYNjNlVHdwbGRrVnA2Wm5pWTZC?= =?utf-8?B?Zjd1KzE1ZWtGQ2ZYdG1OcFk4dFlmR3U4N2lGdFhKQk1pSkRVL0JFT2NRZVRj?= =?utf-8?B?emJUbmhxVGpVN1FaSmlNSmtvWTNPaVpDYkZlMjVYOUxzY09xWmIxczdzamhJ?= =?utf-8?B?MTN3UFY5QUhMSkVwTmNwWlgzejN3bmdFeDJka09KTGREenNrdnFEUnhicXJ1?= =?utf-8?B?OVpZNS96cGRnTXlTNnAxczlvM04vZFM1UTBZY2V1ZnJsS2VNZndDOGRTTVZS?= =?utf-8?B?RUtQZ1hRcUpRY2tNTXdZWEZCd3BBeFVaMExGS25zc1pzUnhkOGlXSFhNVUNj?= =?utf-8?B?OUtVQUN6ZmpyRHRqeTFnZmo4cXQ0R3pUays5L3J0aGFlcENDZkZJWUNHT3lV?= =?utf-8?B?dnh0VEdXVVJ6R0FXS21XamlVc2wvcUIzM2xkZmZSSm9yUXd6Ny8ybkdjeWR4?= =?utf-8?B?MmhueXNoNWtLRlZ6YlJjM1lKSGtycEZadkZRd3FqYXpwMXpzRjFlNTg2b1Zu?= =?utf-8?B?WFpmSDdPdzdzN0xNQlFHcVlja1N2ZGdxYnpCL0hFTzhGUThEUjJaYXgwaHdi?= =?utf-8?B?NGxUcnNsWWhOVkYxZllwUFg2amdRRktyVjJlcXBJYnZoWlJmMnE5aDZJUnVt?= =?utf-8?B?VVRnTHNEbXlaajQ2WnFRNzM3bjl5MkZycFFVQVg0clVLWDloN2lWeXVpR3Rq?= =?utf-8?B?Y3VDZk5FeGhwT1MvVEMzNElYMi9TVWkyRzAwV1JlWVlCNFc2MU9GNWlrSHBh?= =?utf-8?B?UzNFdWdYZ2dRU0pUYjd2cHM4dVFrSEhwd1QwdEh5aUtyRjBHR0pPbjhKelVv?= =?utf-8?Q?OASKK4L2IzMyd3aLNcwp/kK9C?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: de63d4ab-20ae-4f42-3647-08da6a53ff4b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 13:30:22.5545 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tWTNI03xOAnMKviuftSQTth6+P4bIZv8v8BQVFJfxfFgkwC8HkECMI2Aw+nV0g49mDtdb9tvfF6gCMtekIfIGw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3272 Passing -mno-sse alone is not enough: The compiler may still find (questionable) reasons to use MMX insns. In particular with gcc12 use of MOVD+PUNPCKLDQ+MOVQ was observed in an apparent attempt to auto- vectorize the storing of two adjacent zeroes, 32 bits each. Reported-by: ChrisD Signed-off-by: Jan Beulich --- a/xen/arch/x86/arch.mk +++ b/xen/arch/x86/arch.mk @@ -36,9 +36,9 @@ $(call cc-option-add,CFLAGS,CC,-Wa$$(com CFLAGS += -mno-red-zone -fpic -# Xen doesn't use SSE interally. If the compiler supports it, also skip the -# SSE setup for variadic function calls. -CFLAGS += -mno-sse $(call cc-option,$(CC),-mskip-rax-setup) +# Xen doesn't use MMX or SSE interally. If the compiler supports it, also skip +# the SSE setup for variadic function calls. +CFLAGS += -mno-mmx -mno-sse $(call cc-option,$(CC),-mskip-rax-setup) ifeq ($(CONFIG_INDIRECT_THUNK),y) # Compile with gcc thunk-extern, indirect-branch-register if available. From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:33:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:33:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371781.603636 (Exim 4.92) (envelope-from ) id 1oE9pj-0007p5-6L; Wed, 20 Jul 2022 13:33:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371781.603636; Wed, 20 Jul 2022 13:33:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9pj-0007oy-3W; Wed, 20 Jul 2022 13:33:47 +0000 Received: by outflank-mailman (input) for mailman id 371781; Wed, 20 Jul 2022 13:33:45 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9ph-0007os-Pb for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:33:45 +0000 Received: from ppsw-33.srv.uis.cam.ac.uk (ppsw-33.srv.uis.cam.ac.uk [131.111.8.133]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9308976c-0830-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 15:33:44 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:60300) by ppsw-33.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.137]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1oE9pY-000iGp-Sg (Exim 4.96) (return-path ); Wed, 20 Jul 2022 14:33:36 +0100 Received: from [10.80.3.248] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id A54F31FA31; Wed, 20 Jul 2022 14:33:36 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9308976c-0830-11ed-924f-1f966e50362f X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: <8fa727c8-3ee8-44e5-74c3-2c9c585f12c0@srcf.net> Date: Wed, 20 Jul 2022 14:33:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: also suppress use of MMX insns Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , ChrisD References: From: Andrew Cooper In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 20/07/2022 14:30, Jan Beulich wrote: > Passing -mno-sse alone is not enough: The compiler may still find > (questionable) reasons to use MMX insns. In particular with gcc12 use > of MOVD+PUNPCKLDQ+MOVQ was observed in an apparent attempt to auto- > vectorize the storing of two adjacent zeroes, 32 bits each. > > Reported-by: ChrisD > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper But while we're at it, what else might we have to clobber to stop nonsense like this?  x87 and avx come to mind. From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:34:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:34:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371783.603647 (Exim 4.92) (envelope-from ) id 1oE9q3-0008CW-ET; Wed, 20 Jul 2022 13:34:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371783.603647; Wed, 20 Jul 2022 13:34:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9q3-0008CP-BC; Wed, 20 Jul 2022 13:34:07 +0000 Received: by outflank-mailman (input) for mailman id 371783; Wed, 20 Jul 2022 13:34:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9q1-0008AM-DD for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:34:05 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9f1171e4-0830-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 15:34:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9632.eurprd04.prod.outlook.com (2603:10a6:20b:477::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.24; Wed, 20 Jul 2022 13:34:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:34:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f1171e4-0830-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LqNYXbnbWwWaI6Qkngvd+NDonx6ne6OlbELaJ67cpXVbS6fHB8GGfjkLvx9Ov0XVXABGYK2OT5/RspZJ2jSEuI3PWS0uLnGfb9U8RN2jCAXcb/T9CjvrYPkduXx0qWXQ7P/8ccuqA3uv7fEpwYNbLo7pC3eYUFbsd22IgoeUdWO+9ZoL/Szbndqns4bWjOBuk9LhLvFe7QmW4XTJcuxc5jF5gRTGTDevkAG2ex4gXpYW2M3xWdYqq9QMAbjXBKD/S3I3wMLG+eziG0zrfk2uNT1+Beo+ufSONy86NmJfaZjA56Q5AGcQ/wiShvwWzxiLjxzR6Z4EOvmcgfJ2ckh8yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t5lc6f/KKPjMnE4ho6v1CXA8VObImOpiOEO4gX459nY=; b=Bb4c0YUbijF5ePm54/D+H7GEBEAmuoKq3kVi+TW98Sn8haYjwbluxtYr8nxqW1kwLzq4JeJo4AVpbpV6wy2KvlDddMFjs20ZbBXhQ4rfOT2UarURQGYga9Uwy+gBqmHzQv2e3x5vP3m1lvX4jeARyqI4zatb71nIDCItB+TqbcP7/3S4COZT93J1GPRcl+2ZNds1uQEE9AoLlMfuhsPkRks7wxzG2n5zQav+k9ukgzPq/HCHn7S+Jupnbcmr/EhfOJO84eKVuxINwmOA6EddpssmiaEednU/y1TQHCIX1ErBAtI1KPNKhvB9pKeNFXx0uR48hHlmOSqoWH7oXTTCmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t5lc6f/KKPjMnE4ho6v1CXA8VObImOpiOEO4gX459nY=; b=Shtcv0srKce+C00578r4tEfWAwjKUXecqI8605sgNlqAOGfAN086vSpbylE2rTT3YkcGDS6zxFD9XlAR3K2gpbig4MXpP977xjwqc9GU6sh85ZvPz7yJguq9T/BmXW0x9Cx4QuS0iqY0kO8iZejahC9kgfhchytYRjX0ar527vTJM6h8hOXa3f8vIzwGZZ+5cjYLFuXpuOZVfldr6ItIbJ3geTc+c4/5A5TtVkexM5RAtjXEut2Wx2tQlAIKCtKxuXVvwJc6DSf9JJG6EKBiR+WB+ze5dmDQX/UpX+EnGaB8/nZRhMibwxYgVFi9OJAM20v78ixMurQAipouwISbaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1a56faa9-0c62-70b8-20ab-af9347a25354@suse.com> Date: Wed, 20 Jul 2022 15:34:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Julien Grall , Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0044.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02e3a656-4654-4c5d-f28c-08da6a548254 X-MS-TrafficTypeDiagnostic: AS1PR04MB9632:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ibEGNl9xp3JvZd9NSLZ3TFkQqAIj6EQ+Y4IGpP946m+UVxwSFy/3RG1qSG6ESkaCayZBG3xOHWWuoVG9I6K3gHQLd8lsfu4nAbu5N2587fdX4u/DZUm9+Ora1p/KbRxVFj9FpQ4vosApmV8yrIse6EWqI/m0K2k7RkOJNjdHmBzJzAWvzO15DWDt+AeTj6S+fIPIURgrK5AQIab1U7m4axtLc3UKbqeKhV0i/X9LY0Zx1mx8dplZ+vHj1T+6zsGN4PC8LO1qpzZH1gNPLmtYpqSiD0TVOSRpHzCoaXHxSSytfqgzGfEjD6Q7UG2F1W7eQ+amjl+yITMVumyytqeycn/PB8x6obo1xil+KNQiZ7u4gbTSCK4baLBLl8nci/HXmyWLBtDyIjbtqo/q1uyzKphhuUtk/XanUnjOO5qtD+l9gyJQrIvTBM/COCOq8ItqIKJCHfPq3syQgAQ6t46dUL1xvhj/WeqCU0o+CxJlWTpmTuTc0sCkdL1U6p7AdzovhhP2b9B/TL5CSkJdS+i7OjbZIMsMCDyuxEjnWm9dS7j4jLc16d/5iVXyhwGg+1/7t0GWHlQOSP4dFpZrEPhS6mUAeHgCnIOEQsMPthk5xBzxZPUIhuUq59ToEdLDBu8adHRHCwMzaG9Eo7cUsznv5qKNwVYXli8lCPz9o+uRX+24d50/kV26OkMr17waoTVXK0L90CcAHKa55TKJN1+1g6f7RUvm6fPDBBDcw2jKjJJemtRsW8udIhSfSUEXr+FYr5RaqbuDUGyxgH3JeDwevtNnbM/ZDlkifn7fma7ngZd0Z6Y2Jn9iiMJE2+S/4bNbj0k9qrnNNtUpMLjC+XLBPw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(136003)(376002)(346002)(39860400002)(6486002)(478600001)(31696002)(38100700002)(53546011)(41300700001)(6512007)(86362001)(31686004)(26005)(54906003)(110136005)(4326008)(8676002)(2616005)(6506007)(186003)(83380400001)(316002)(66476007)(8936002)(5660300002)(66556008)(66946007)(36756003)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0NHVnJ1NmR3NG1lMURxVlBpUEhJRk12QzdGNEJ3TEE4aFdKRi8wTTcvZk05?= =?utf-8?B?RGRjenNNRUpQVHZQVjZDd3JxVTBZWSt5ckl5djRoUVZCZmhHMTc2cHZTbzRN?= =?utf-8?B?TlJFNTZ3cWxwWDVNY0JET05TNmVHZm54bzZVaHROb0xDaHN5RmpRYjBLU0dK?= =?utf-8?B?K1FwUDJKMU1vM2JabC91bW5HZ2YxYWFhR1hHUytzaVZwdVd6bGFZL3pOcmZW?= =?utf-8?B?WjJ0YTJFSGMxa1owc2wyRHlqdVNYZ2lDb0d2R3NHZzZlKzVzWWJDeEtOOUY0?= =?utf-8?B?Tk9VYXl1Y3lwZWxzU1FTNVIzUDFvTEhDRy9EWnhEL2ZZVXlUd0NZK0dDc2Q4?= =?utf-8?B?bURSdVBjdUtkTEFIZXB3RjFHaVdWTkQwQUNJU0JXcjR6Z01mNnl2cW5iS3Fl?= =?utf-8?B?dDhBZVQ4QmFKTVVLK0Rvc0RlWDl2NGdOR3hUNnpPWGZRSDhYRE5NcGxtUmxK?= =?utf-8?B?alBqYVEyVlBpNVJReVBVN1lqUVptTHZubWdaRk0yTituZG5ia0NjOGdpVXZI?= =?utf-8?B?RWY1L2JqU3VIS2xybU1oWDM5R1FnT0JjS09NSGdNajk1UlpES1NQc0F2KzRo?= =?utf-8?B?TDN1REZHWC9iR1dUd3ZlTStNNUxtUitZdVdrcHdPcEtQK1J5UmN2S0xZdXpT?= =?utf-8?B?ZktNYW5iVklBMndwbjg0N1ZIKzN2dUlOa0pQNDJDSm1uanBQVEkxMDFtYnBP?= =?utf-8?B?NGJ4ckpSZG00bUNwZTFibkZUSTMwcFg3VGg0d3hqUVU4REpTNDA0MXV2SzVU?= =?utf-8?B?eDY0UE1hbkpENW1PaGF5ZDZlU3FlaExiREd1dEh1NW5NLzlwMGkrNGhHRlZu?= =?utf-8?B?bnVKNjExQ1NVR0FwSEFodXd5Sm5vYjlkYm0wT0tDRWNnRTBmYXpyY3huejZa?= =?utf-8?B?eFlzUGRVTUQ0ZE0waUllT3E0SEtFc2FCVk5OUXNoc2FRSGZRNnMrSVBqWDVo?= =?utf-8?B?TVhlSkYrRkFWM05KMmJLejBHUEh5d01mdDd4U2hSU0pXcVpPYVF6NHBlRUY4?= =?utf-8?B?L3FrUkFnRnRsYUFFbnZzMVFpYm1wT2VoWituY1VMTGgwZmNjMWhqQjVYeVd5?= =?utf-8?B?ek41N3pLT2xVcG5peW53OHRvU1hpUzAwVDMrQ0VBNVFQT3VqUWErU3lOaU5z?= =?utf-8?B?TWg3Zlk2Nnd6WmdiRWhFV0RQRndmZGJHU3RVc3NadVNvTUV1cVA4N2FSajQ1?= =?utf-8?B?ZWNMaU9vSjZLOTAydHc5WkNnd1ByMHc3MDlyWXVqd2tEN2EyOHdoemtkUVVl?= =?utf-8?B?b2orUG9JOEVPTGtXaE1yYmRyREFyNDZpZHlyM2RrOGhhYWRGNE4rYnVYend2?= =?utf-8?B?OEhnb0J5UkZPNXRoSEduYXRpS2N4RUxYUnpEbnRZQWc5bzJGSUFYb3FITzdQ?= =?utf-8?B?dEhNV2crVnBKRWtFT1hJaXJ2azY1YzhIM0MyY3RHSTBIQitXOTgwM1VkVGtU?= =?utf-8?B?a3p0bEFiMVNPQUJaM1VNNUpnRWJFQ2NrUGdUWjhGWDYvWWxEdktIeTFpUWZp?= =?utf-8?B?eWd4MjBUQytvdjBDVEU1OU4xNEc5RjlpbDlMWWVlamdoaUVGamQzREZQTnVK?= =?utf-8?B?RENWVHVxZnhwc1RYcHlLVldPSDE2b1NQMHpJT2dEcUZvdU1lVXJWOSt6aE5G?= =?utf-8?B?M1BQMFlWOHc3cWZlMXQ5L3ZVNVgyQmdpbWZZN09aa3pNb0xDOEpoRzJqNjdt?= =?utf-8?B?Nk9VcXMyZ3gveEtEdGZUcEFDd25MOTkwc3JuU3F5dzI3S0pESGlvc2JDcVRh?= =?utf-8?B?TVJZQk1wdzVCVm9BcFl0WE9UWTgxdjcvdnRubjVpdDBSSTAwTFBHRUdZQm5k?= =?utf-8?B?aTd1a3h3SWJXcHpPcVVmbHhRTTRTSXFRSFk4R0s3VFZWV2s4L0pTRW8rbU1C?= =?utf-8?B?dWNvNHBSWkZEdXVUMndZZTdqWUFacTdudERwRlpSWnVmTHBFSTFmQWRtNnVx?= =?utf-8?B?dGFiRkIzdzFqa3dwblQ0dXpnL0VwM1FlQlpJWERjbWFnUUZJek5Ybjd4L3Bx?= =?utf-8?B?NWdYUVVKM3pJOFN1SlBIVlQ5dDJ1SmtnekQ4eXZUTldEbENkTXVqV3BYVTRK?= =?utf-8?B?c2wyeWxweU9wRnEvRWY5UFc1bUpFNHJiVklsWjFpeUZTNGlNa2lCVEhvRUY3?= =?utf-8?Q?P+6ZlgPQzW7NL+YcJijjkEmah?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02e3a656-4654-4c5d-f28c-08da6a548254 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 13:34:02.4154 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TVmxeQV27/KnRarEDTTitSQdoXZniB5Vvj3CSWi6+YRIH8L/aSzg5wT2kPA0yEtJdtgHL5vXFsCAN1hK4EiD7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9632 On 20.07.2022 13:16, Julien Grall wrote: > On 20/07/2022 10:59, Rahul Singh wrote: >>> On 13 Jul 2022, at 1:29 pm, Julien Grall wrote: >>> On 13/07/2022 13:12, Bertrand Marquis wrote: >>>>> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>>>>> I can't >>>>>> see why it would be wrong to have a more tight limit on static ports >>>>>> than on traditional ("dynamic") ones. Even if only to make sure so >>>>>> many dynamic ones are left. >>>>> >>>>> This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. >>>> On other side we need to be cautious not to add too much complexity in the code by trying to make things always magically work. >>>> If you want Xen to be accessible to non expert by magically working all the time, there would be a lot of work to do. >>> >>> It is not clear to me whether you are referring to a developper or admin here. >>> >>> On the admin side, we need to make sure they have an easy way to configure event channels. One knob is always going to easier than two knobs. >>> >>> On the developper side, this could be resolved by better documentation in the code/interface. >>> >>> Cheers, >> >> To conclude the discussion, If everyone agree I will add the below patch or similar in the next version to restrict the >> max number of evtchn supported as suggested. > > I am fine if the limit for domU is fixed by Xen for now. However, for > dom0, 4096 is potentially too low if you have many PV drivers (each > backend will need a few event channels). So I don't think this wants to > be fixed by Xen. > > I am not entirely sure we want to limit the number of event channels for > dom0. But if you want to, then this will have to be done via a command > line option (or device-tree property). Imo there would need to be a very good reason to limit Dom0's port range. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:37:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:37:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371795.603659 (Exim 4.92) (envelope-from ) id 1oE9sl-0000fV-Uj; Wed, 20 Jul 2022 13:36:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371795.603659; Wed, 20 Jul 2022 13:36:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9sl-0000fO-S9; Wed, 20 Jul 2022 13:36:55 +0000 Received: by outflank-mailman (input) for mailman id 371795; Wed, 20 Jul 2022 13:36:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9sl-0000fG-7x for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:36:55 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150059.outbound.protection.outlook.com [40.107.15.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 044e94ff-0831-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 15:36:54 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3272.eurprd04.prod.outlook.com (2603:10a6:6:10::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 13:36:52 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:36:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 044e94ff-0831-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OjX+Jh8umV3vkbksm+MnCV/ge8xQGEbMYjASCPoNX71fKDJYn28ws9513ONW9yz/+R1S3Zu9vwJSl7lV6xM/Eb1GZjysSe7guMdE2gyJwrTRttaaF7Pq9d8sReM1xQUeg2DbsYimld76VAeDnjqvAHOAozQBa7JASyZs2/uJZTUDyYuP9eLILZDZ7Twd9dTHRvq2D7fPAzhHN2GI2ZmfX723W4IdW5brldUZxXH2xepEwg1lhvl294j2lzZF01Zo+MnmZcfzfP7HOZC4B+8Uzm4tLZ5c7qPj83tcZREWGPaSP+/Sfa+oaq/XnY08EWVCF1+6db45Qh3AfPCP77LcsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=02Xp6Q0Kl5AIhlobm5XcZDgjJAMUIe8aGwPMEGe9YWc=; b=AyWDaqHRjvUDdOaL9Q83r12wsF5uwCwUHkG2erwRIMM8yBcBVT78apbNoP9m0cRr5mNnIxBsKacJr8r17LlMDyjBFHXa4Y/F4fZo480l97UIylfzhPeVn+94mpF3qztw0dEEdOJnmWWRemsd60Gw+jeLm6XYfe75RNvwX5M2h4x7qjqY3CjluvAiy+EcFX04+k3J1Wg9M3JeIjYTzi649MEp7HGWgnVxnSKxnRAXOvtr/2pql6AcSlI6M2pEoxLVzIQK70ErquNoXZULp7akiuoUzySUT0VnhQpMnMdwaN0LmMXbULnJzo//N7A/jcVm7nHOfjAziKOR3OxorqARyQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=02Xp6Q0Kl5AIhlobm5XcZDgjJAMUIe8aGwPMEGe9YWc=; b=lBXRmcwv8ziIBx1ZzbyuEYJuedQ15wQdgG9x7ns5tMROn9ayhqXd4QgCELDRITOMInzbzXkBvck1x8X2SQBOP+LM4sDOKcP8NB/XHKNjxt1Y9DNqihqqOUh0Lne0NLkB6+SxeIVYICFGjEefxagKj2baBAlnEFOMbeCICEuerLYPMFXq2DCnpaSc62Lx3T48BzBXfUoL4gnZ+iAb/5B0EBT2u2zGt5bl2BRmVYVQtZwoUpHUj27hBEiaZjz7rE92gN0dE8OZV38tGKA4O7v4Zc03lYuz7fXTVt3KctYmT/hQnTf2kGa2Ni5VDwfCmbvha9k2ftMPtEXgmWGzwwmUTQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3d1eb47d-607b-1519-7e38-d0b574dc5d6d@suse.com> Date: Wed, 20 Jul 2022 15:36:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: also suppress use of MMX insns Content-Language: en-US To: Andrew Cooper Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , ChrisD , "xen-devel@lists.xenproject.org" References: <8fa727c8-3ee8-44e5-74c3-2c9c585f12c0@srcf.net> From: Jan Beulich In-Reply-To: <8fa727c8-3ee8-44e5-74c3-2c9c585f12c0@srcf.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9PR06CA0364.eurprd06.prod.outlook.com (2603:10a6:20b:460::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 64527076-e61e-40be-a109-08da6a54e7c8 X-MS-TrafficTypeDiagnostic: DB6PR04MB3272:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p+4DYoahxWmIeMVNGlwoXifws2VEYpJvY9mhgOi2mXidRqrQY0R2COQIMN9PqhKwnQPL+FyO2BGG92M54SuuTXeAUWrcD6rIOFJDvJegvzNo1oY4zavMnv+OrqhL3pI3/iNvl9C4UHi5bcsPGFYbNYMpjHlAePdea6PdXYBJBMTXqnRc6/44W0em00eMaEQbu1b5+hrMyHlZyP8SyOSIIxJ0XTSczbtkhIuGHZXHXhK+W+3EaH8gsAYCSZruQYYza3UMlCCqStbYF5k6lfXagEDMVKiWxKtbE8KYQNAZrlZt5TX6KlnMoa3bWosoRbczqma1IG9l3gDVnrTnIoRtnznQQSUBaH3OGRCsz8VD+pLF2iJu2E7eVtygnWsm8V2m9AWLz2pnkH4X5NbhbbcaF+7z/VJcwce3ySNRGY7QMlP047zUKsI82a/19PIuu57llcxfBzxCfPIgEUymZAxqsyVFUJfGYV+Nl2mDJzP15yfOLmVGIOH8PmiZ2y1E9cJ9dxm2iKdF4dC4h2iYPAj7zgi8NbI5RkF0K7WMHrckz4GTv3MuZF/AOHiS2uhOHNZ5RYB8U74Pwa3NfdTwX809OsDt0nSeVH/Expb6MOtTbty3+6jf6O7ZOtEscpX5RVs4XE8ZQ6aaHAwwZnfkPKl0EWl3l4nTA/0yoBP0LoLdccagTDBhZPthzX+ms5Bss9FzXBt9po7v0z4LQixgJ+MWZUGG0f2x3Ua3bylbRoYOyONe+ZqSO6X4v9oVXew4LI7F3wYsLSubNBu3oMSIAd8Mk6iM89AUmWxa6BXmXpz9h7pUxgJZU7DB8vy6rK3GxCcKXgvNWpTO53o5/SPUCyStEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(376002)(366004)(396003)(26005)(53546011)(6486002)(31686004)(36756003)(8936002)(4744005)(2906002)(41300700001)(5660300002)(6506007)(31696002)(2616005)(186003)(86362001)(6916009)(54906003)(8676002)(66556008)(316002)(478600001)(66946007)(38100700002)(4326008)(66476007)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TEl6SEhKUXBZRkJOd3RGZHdHTzVQRmRMcHNjMkpOVFM4LzA5VG9RWi9Wakto?= =?utf-8?B?VGMrTkpVVTZTZEwvRjlHY2EwRHpmSVplbzgzdWN2U2xQbUlocUpaUXJzekEv?= =?utf-8?B?ZytXdFNXUnd4RVFHOWY3YWtSRVlEWXZVOFg4Mlpra25pQ2VsR2RueU05ZHhj?= =?utf-8?B?a0twVTlvU2hsM0pMa1lNVmswV0NmVU1kbWFRZFo5WjRPdVpVRFpuY3MrcUtD?= =?utf-8?B?TGQrNUxiY1JiNHBWUEVLQUpHRldOU0w5LzVRenZOczRkdkZjT3dZK0RPZ1Fz?= =?utf-8?B?NGNreUxrOWhRMWtrTXBxWHY1NVJGbXpBRzJMVWlwOGlSNzVJeG9qVG5xTFRx?= =?utf-8?B?N3J2aTlTV29jLzBxSEFtdDd3b0lJZ1JJcGRsdm1oMjUvQjZyN1FwdGc0cWx0?= =?utf-8?B?ZlFnWTlMKzZsSUFXNk5DODFxREwvWURQOWlKZk42ZW1aV244NGZic2JJOEFl?= =?utf-8?B?L0NqUlFmditLalhnSXdwQy9HVmRjaTFERTdlZUIwV0JVWXBGTGlzZEVNSlg0?= =?utf-8?B?L1hLZlh0WnBib01Oc3pkVktIWUpZWHdnaXVleFphZGJmZkZtNTFySnROeVpI?= =?utf-8?B?Q0dJK0U0bys3TEkrdG9VQi9UM2VsWXh1U2ppYW9aOXNORUEzdG9JNHczcFZj?= =?utf-8?B?OHZRR01lMXdOQ1BVQVQzdnkrSFdXdXRuMXZXbUg4M2xFU3NGRU5JYUd5NE9B?= =?utf-8?B?TlpORUlnc0tnRXZPUWRUWkRFZmlMWDRBNXZudFYycXhrZ1cvd2wrcVNhRWVG?= =?utf-8?B?cWdRU1lUSnpZbmJJUTVTYzNZNWtTOXd1QTl6Rko3NDFXUHBOdHRFN0dDekVy?= =?utf-8?B?L0NyLzhnTVI1VG9jZ08yWWhjTXlSSHNRKzU2d2NkM1RBZVdaV3R0VGhUemNY?= =?utf-8?B?MVBVSlp3aWhFZkIvYVF0SnY0QjJYaWxSWDJoRFErM1dSQnl6YXlPU2dFWStR?= =?utf-8?B?L3ZycGJiaE5hUXVNeS9rV1VxUEFMbHdxZXBZM0J2bG9EOEkxV3pBVEVyMi9j?= =?utf-8?B?dDFTM2swV1gvMFhxTkRYa01QeC80RElFbHlraXJLTXY2Rk1WZnpERE14MHli?= =?utf-8?B?bjI3aGJhU0Z6V3RhLzNxZVNFYVQ4eHFVN3NNSklHaXhuOEd0L2RXOVIwSHls?= =?utf-8?B?K1FpM1gxVlUySDNjWUtWNDBVVUdWSzZ5T28yNDJJT3BCU0JCZnhlTGhjNXdy?= =?utf-8?B?Y01va0paM2xJWnpLTFZmK2N4N25EYndpS3lvV1E2OUFRMnpiQjlXYlFJZG94?= =?utf-8?B?Z3BFUFBNVmtxb04wTG00VXlZQ2VuRGhZbS8rN3Z2NkR3c3FTR0k3YXR2cEE1?= =?utf-8?B?dG0rZ1EveFBrYkpqVGlrTGkxT0lJclFLSGRlZmdSOFpGbnd2ckZWUHlEMGZo?= =?utf-8?B?eVBCSTk3WEx6VXVCQllrazE3MEo4dTBmd0VEc1RPekcxYjQ4R011eWpKTktm?= =?utf-8?B?dyswam1RZWJVNVNYTlc3NWpiSkU5c085Q0V0SHRGcmlqRjhpUWZEazZUbE1W?= =?utf-8?B?Y2h6ekllb05wQVNTcnhYRVY2YTJVOG5qS1FJcDJNR3UwSStGUDl4bG5tL1BG?= =?utf-8?B?YmpZM29qaEJsY1FudFM1SnI2SzcrQmVxWkZ6OXdBRGd6QlBIY05OdzhRZnUv?= =?utf-8?B?U0pqeXA5ZmJpbFZwZmNRQUdaYjlvbjJMUHNjQ2xrekR0VlhUOFlRcThBYU0y?= =?utf-8?B?ZTlYRml6ekJBeXhTTHhYcFVwSWZQcXRQbzVPNHdtOXlKTlROcFZkdmp1U3Yy?= =?utf-8?B?cUcycWYzOTV1NG8yWDNMMWJWTlcyUXJENEErMDQ4ZGkzUGpiUXB6YWhyaW1r?= =?utf-8?B?YUx6UEUxN0YwMkpmYTRlWDVhSXVLNzNFKzhtekxZT004eW81K1ZsNDNaUTlO?= =?utf-8?B?TGhVR1doRWlNbzVBNXJkNnlLcldPa0p0TDJzbjEyZjVsejMzR3JkZXE5UlRO?= =?utf-8?B?SUhvVktJeWFIZ0t5RWVGSkFVakFaTTIwY0F1azFhWmhNSjAyRHMwT29UUGJF?= =?utf-8?B?WE8zQ3NuU2U2V1lYWWVsQ3RJZ0I2N1FEVlM2b0E5OEwrbjVDa1dZY0pTc1hU?= =?utf-8?B?MDNsZGw0NlhFV0xtdlVvdHRXbVErcm8yQm1tYURPeVFMVEZ4S1FBcHArL0Fw?= =?utf-8?Q?rrZjC3vW7UZG3U26IoejfKd7c?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64527076-e61e-40be-a109-08da6a54e7c8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 13:36:52.6078 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9q0MWVZC2BEbOudtl1iAGHnIcTK8/uupQipBOyyru942pM4lAH98pVxtF/eceHrfkxneZVaKmSGArse1/7cZUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3272 On 20.07.2022 15:33, Andrew Cooper wrote: > On 20/07/2022 14:30, Jan Beulich wrote: >> Passing -mno-sse alone is not enough: The compiler may still find >> (questionable) reasons to use MMX insns. In particular with gcc12 use >> of MOVD+PUNPCKLDQ+MOVQ was observed in an apparent attempt to auto- >> vectorize the storing of two adjacent zeroes, 32 bits each. >> >> Reported-by: ChrisD >> Signed-off-by: Jan Beulich > > Acked-by: Andrew Cooper Thanks. > But while we're at it, what else might we have to clobber to stop > nonsense like this?  x87 and avx come to mind. AVX is taking SSE as a prereq (with -mno-sse %xmm etc registers simply are unavailable). And with -msoft-float I would very much hope we have clearly indicated to the compiler that we want no x87 insns whatsoever. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:39:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:39:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371801.603670 (Exim 4.92) (envelope-from ) id 1oE9vD-0001UL-BS; Wed, 20 Jul 2022 13:39:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371801.603670; Wed, 20 Jul 2022 13:39:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9vD-0001UE-8T; Wed, 20 Jul 2022 13:39:27 +0000 Received: by outflank-mailman (input) for mailman id 371801; Wed, 20 Jul 2022 13:39:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oE9vC-0001U4-CA for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:39:26 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d0d1558-0831-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 15:39:24 +0200 (CEST) Received: from mail-dm6nam11lp2175.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.175]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 20 Jul 2022 09:39:21 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB6351.namprd03.prod.outlook.com (2603:10b6:510:ab::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 13:39:19 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:39:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d0d1558-0831-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658324364; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=K8pypOpu9hgaR5vnUwx2r0HrjGvMH+W17ooc+AAQInY=; b=cRCaIeR1nxZmgI3G7e0Bq425KJ0a8Lo03i7T7DIE1HC5uHt3xcaS7qdK m2FngKpHVYnW968azHBqGgIx6TyRuyo7uEWhGe54QDfwmvpwiD8VtUPJD UgWmHs05NGsIXJC0B0ICz8t3L/ZaiF4KHlFd7MBKeNbrx4k3f+ViTSwBu s=; X-IronPort-RemoteIP: 104.47.57.175 X-IronPort-MID: 76658566 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:gG6Ng63iQHWqScn6ZvbD5RZwkn2cJEfYwER7XKvMYLTBsI5bpzQCy mNKCmGHOPuCNzTxfth+bInipBsEusPSx4QxQVBvpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8ks35ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj69RCFmwoFo0ew+Z6PFNX+ 8YINwEsSB/W0opawJrjIgVtruIKCZCyea865DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ya5KmIFwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTAl2TYoi/y2IcjmwvCao4eBbu+88cwp3e64j0tLEQucGaS9KzRZkmWHog3x 1Yv0igkoLU29UerZsLgRBD+q3mB1jYVXtEBTcUh8gqDjKzZ/26xGWwsXjNHLts8u6ceTjww1 0Shk9rtCCd0sbrTTmiSnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPoC1ggbwW1JcPz//iog2BhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHblrDkldF1x28u4DQ== IronPort-HdrOrdr: A9a23:jwY9uq+OMTAeTklLZktuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="76658566" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EQx8f0MFGlg5fwJaN7p5tmlyc44qXANekAzNkBu1B5kkGoeUIYcz7tQsfLwbQ3Ug+KKAVf1ozNfSSVLYNCajmdU3SLFK1NA6CIPMtOkSlbzNtjbMLQV7cW8PmKil2cwEmKW/3lC5eWBCxEqLPhArgJIBrQn6TfkgzR5ukKl8Mv4feZT9KpDYOvuB4j641RQoF3exB1C8uKgKMZEcl3mL/qS+ElQNf+USgscANJ+mG1Ptu0MBq9vsvVBegBz9waOLmvwZhjWoIXUEi8qLXELk5hSf0aNbnAQrYp2khogekbJxhmco7mPFHeZj5jaqsfmWVWpGNB+Ci/BPIbYFInISVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K8pypOpu9hgaR5vnUwx2r0HrjGvMH+W17ooc+AAQInY=; b=gAAJSVjiCRym2eCrignkHUD/GOv/NE33LIjK7y+V+a9VtY1h+tOBnH2tWd8ne+4iGoGpEkvIh0GxorncADEKQXKiOfKrucf/f0TiWM4pvE6IFMSGJFDhtRzEfgG7F/ONIN3oL5fXTli5+UleyQreTW2e/OiO5JrtTzdyQEmR0Z3xYw6uzRMmmVXRmpFwpWZwnrvXYugVMlkOby95i4d4nRx2JYQ7WFUvkxScXYGwy6uePLEFSjNGspDoFsgzEN3A6BCxdMrLugPCHFw3Rs5OKnQya/sBqxZ5k4uhbHVLNVc1zWovxJ5eHpBr4gbgFCeExm5BUB8yRsJQUZTOuqBwCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K8pypOpu9hgaR5vnUwx2r0HrjGvMH+W17ooc+AAQInY=; b=rDvhQq7PNvOxNicTMDUwpOtmRDD2ssye9gBDlqz593FkymFXHSSyvfDgYLMfGyJUHzx6gGfZtIcDeOEuNLLCqVvvqMd2Q9O9NzXC0wgTgXermzl3HMPHmP/s+qBZnrUuloPeOhsP0pWZsf76cIHwHHLneNzwO+s1r7s4xt3A7yU= From: Andrew Cooper To: Jan Beulich , Andrew Cooper CC: Wei Liu , Roger Pau Monne , ChrisD , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86: also suppress use of MMX insns Thread-Topic: [PATCH] x86: also suppress use of MMX insns Thread-Index: AQHYnDziwacZadvwmE2/HDJeAtmcAK2HQiYAgAAA5wCAAACxAA== Date: Wed, 20 Jul 2022 13:39:19 +0000 Message-ID: References: <8fa727c8-3ee8-44e5-74c3-2c9c585f12c0@srcf.net> <3d1eb47d-607b-1519-7e38-d0b574dc5d6d@suse.com> In-Reply-To: <3d1eb47d-607b-1519-7e38-d0b574dc5d6d@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 95401a53-eb4f-420e-03c5-08da6a553f3b x-ms-traffictypediagnostic: PH0PR03MB6351:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: g8eY8F4mtxvptyuFfe+bYGXgQKaHPKnFlTAj6lAKsrXWI+MGCu4k4gVcyqnpLbvRglhGoSCO2JqywIbQO8MJAuEvFFUmsmUJr+paUdJUdMK5Frju2rX9D8vZ2ubalzEwZttOg+EiGgCnBTXkR/QxrAz1e6mtNhEV9viwH+ZRpFbJlXFqjpZ9mJWyZi8RLc3z5H4iOfj+pwzDiRjc/llr8JNKhNJ1iTwYRD5S9lfH8wssa/jOw/zJwHLZUQl7lbDXcq2YhZnXIya4JYFZCfsPtnbsBKj4vFkosm+jqzzK6iA0eK5OoSUURiAIvesIyjzU0pG8oirRg1/CGbwwxdt29J1kVFY6IBAZd9tDPcu8QqtGB4qy+pG39wiUs/cBzId+nU9/L3EV7ufAi4Rnt41QfnFcyc4DWyGleevNeX6ukU/oKddKJtmHXSQNgselpGqiFFHXt4m6AS7wq4lQzNuwRWsGUNcNWLaUxbh8mcSw5uq9BeYV/o69LVJ2N6l/ezNF7ezZyOZ3Rt8kS8XYw4b74cMbOWB50jTZweNWP41mXREchbPD07f7pFWYxYQKUUcdA8oP3JRa/FVUfRofmEAlt2Sy04y+x42drFRvdK93NtCBMOXATIr4QJ1q1nuH3CMydQWpWU1fhluRQdzbXDxHHKGpLqceah9ZNIAzwyTjC25sNTbCcf10hhxspkLSmJUK/PBI8NTtp2BWo6jNlotjaYrB+7FeH/T7QprGmRgF6GnYgQQKY88YeKLd802K3bddMquH4Z0nB72zfZ36aXFYAFOiARSQ6bUqXdpk3GGriZyHCnCmvbvtXD3qlF8IqFfEB6SwBaNSkPzPNdo59x9agEwLCPlbqfZFaoRhtIzCLsI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(6506007)(2906002)(26005)(2616005)(6512007)(53546011)(186003)(38100700002)(86362001)(31696002)(122000001)(82960400001)(38070700005)(41300700001)(36756003)(6486002)(66946007)(76116006)(91956017)(66556008)(71200400001)(66476007)(66446008)(8676002)(4326008)(64756008)(8936002)(5660300002)(31686004)(478600001)(316002)(4744005)(110136005)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QWN5TlRwMzVkSytVeUJOaXBkOHBXSC9oVkcxVVBDalVmcEtHTFpod05GbTdO?= =?utf-8?B?cjByRVZCTnR5aEF5NVRDdXNlUzZsdEN0ZEt3RmFYT3dpVzhiSElFSGFTVkc0?= =?utf-8?B?VHBLZlUvenRtVlIwSmpuT0ZqaWRUbWVWTkNWK0puOEtEcEdJblUwUTBJLzh3?= =?utf-8?B?ckF1V3YySHZEK3hKRHovRTBVckczRFU2SkJQaHlpWnhOcUxZeGJiV2ExRVBh?= =?utf-8?B?Yy9tbXVxbkFxKzdBV1cyOXYza3NwQlNlVDR5b0FtOVpKOFhGUWJ5YUdHQTVm?= =?utf-8?B?R2VnVmU5WTFUeU9xdWVPQldpRGRuWFdmZ3p0Qm9vWDI0VjgvaW1JdElka21U?= =?utf-8?B?WHlMbWFtdEU5ajJtd0h6V3g1UFdzSVR5U0hHdkdGRnJaeG91SnU5R3RqUi9q?= =?utf-8?B?N0xDcGlxWjQ0WE11Z1J2cy9tRjJRZ21Helh2M2p2MGx6SmFnVmkwdEFFS1Nq?= =?utf-8?B?VTJObTRHQWxMYVpzRUlDKzJNelJlU09OdUs3K3BCd1BoKzd1ZndBWUxvSnA2?= =?utf-8?B?TnQ5clV3SGlrSmk4bHJxM1prRS96QTNOYzBqdnRqSjBLQmJIOVFMcXBRellm?= =?utf-8?B?SmFHSWFxb1gxUGp6S25DYkJxYjRCazdPSHBuaFZ4Tm9UNXNldVNLQ3NnSUho?= =?utf-8?B?VDB0dHJGSTB0S2NKVXhpc21DTk1URDA1UlJrNm54V2NaQ0VoM1VZc21OalhK?= =?utf-8?B?VXBCQkdJd1JZaDJmaFRrd1prVTdIN040Q3B4SE9VbS9kSTJQUVF5a2VCYjk1?= =?utf-8?B?WEM0N25aTmlXRUk5QTMwdkZoWmtsZGdDY3M5akpmTlFjUnZzOVIyNXRmbkdM?= =?utf-8?B?bkRuU0FiOHJiN1ExajNrcXBUQndqQkhaMHRhTUcydGFqQThWcmI0eTF4N0ww?= =?utf-8?B?TU1kNEFUTk1tQWRQWUVoSk9qcXlNK0tPN2hTdFhCaUtlYVBFVFhmdGttUENy?= =?utf-8?B?SlQ4VkNFZnhkYnF4clJwTVRwdjlEZ1puYTkrRjVNUFgxRFpzWUdWTjhBN3lj?= =?utf-8?B?Qk8vQkx2OTZKV25teEhHL0lxdFhsY2M3U1BNRFlRd2N2TFk1S1VVSXZxLzJC?= =?utf-8?B?clFrNU9MZHpOMXU0dlBJcUJFOUhwT2tqcmRVUDRnbUR6K3VRVUdNMlZGeGlh?= =?utf-8?B?Qks3cGZVVTJVY2MyczNFUERrMEtkK2ZZU2c4WktJMXVQc1lxbWo1K1NYbkpt?= =?utf-8?B?UXAwU0lBdzdvU0ZHRlI2OXVzUGduKzk2VkZndXhkZlU5RVVHTUo1K1RDb29S?= =?utf-8?B?amtyMGVGMlNCN0xYQ09UQWJGVlRRVFB5eHh6WVBDRWZ3YllSd2p0Ry95YW1v?= =?utf-8?B?ZEVJTWROQjBQTVJTVENBVk9FVDA0VTJkN01jMkovRThGZU1YMjNhbkpDMytz?= =?utf-8?B?Y0t2Qy9mdUtCbTZudWRtbEZRQVdYeHBmd0FUWmlsUTQ0dG5hamZQMXY0dFZT?= =?utf-8?B?WStIVmtWb1IyYW5QSFF5ME95aVZYSUo5VTdFS2g3cTFhMWZMNmpVcGtaVjBS?= =?utf-8?B?dXFidGQ3MENLWHF3N3ptMHFTSGhpcXErdG1JNGdtZEhMcWpQbktwaVh4SDlU?= =?utf-8?B?TmhZbXJwaXRDVTZ6SFBEZm5kUkMrOXZyYlc1SGoxT2NIMjl1TWVCWDU0YVBL?= =?utf-8?B?aXR6NWtpNStWUGRvSmFOaFJGb3VoKzZ0a2dBZnFpUy9wVGxocmd0Y3ZuYUFH?= =?utf-8?B?QXAvZ2JRUlZkUkphMG1tbVhUWGpIcTY3ME5GejNYLzBySTBHVFF2TUZlQ3k2?= =?utf-8?B?SDZGcGRPY25rZnJtVlU5cVY1OE5EMGM5V1VVNkowS1p1NVkwVXRTazUxNldu?= =?utf-8?B?dmkvemtYQVV2WjRJelcyS3FqWmdLZ1E1ZVV1TVNLWnJBOHFPMTNlMWRkenNa?= =?utf-8?B?ZzgvemM2UThNd1VjZEs4MEwyRUszbDRhNkhIY2VEZ3dkZE9jU2x3S1R4MVE5?= =?utf-8?B?cUZlbm5qcGMvS2U1QUVFZkhZT2ZQUi9hUFZTR1B2L21pbmQ3VjE0Q05rQjVP?= =?utf-8?B?YkJSSDZWejJmUjRTOGRaR0JPYkpQK0RiaVZ5RW45UE9tTTAvNCtYSHIzNndY?= =?utf-8?B?eTk0UFcyeXdQUnFnd0ZuVEs1SGpEL0pYSFFmVENZVVJ5L3gxRld3bVZUZWtv?= =?utf-8?Q?qglh9zJUSJP6/8aGNezQ6PKDN?= Content-Type: text/plain; charset="utf-8" Content-ID: <47CE96A21B5F734F9C10B96B2F27E982@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95401a53-eb4f-420e-03c5-08da6a553f3b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 13:39:19.1318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Q1GHD7PP+C4wFhutEauE2WY7HkYhRdSJ2hsOVIow/gJu/HopiPUjHRxb5nEBpbDYTyVMNV2iZ5bXoOtXSCgv2x9G7Rqjwd9YrtksDTlfiCk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB6351 T24gMjAvMDcvMjAyMiAxNDozNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDIwLjA3LjIwMjIg MTU6MzMsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyMC8wNy8yMDIyIDE0OjMwLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBQYXNzaW5nIC1tbm8tc3NlIGFsb25lIGlzIG5vdCBlbm91Z2g6 IFRoZSBjb21waWxlciBtYXkgc3RpbGwgZmluZA0KPj4+IChxdWVzdGlvbmFibGUpIHJlYXNvbnMg dG8gdXNlIE1NWCBpbnNucy4gSW4gcGFydGljdWxhciB3aXRoIGdjYzEyIHVzZQ0KPj4+IG9mIE1P VkQrUFVOUENLTERRK01PVlEgd2FzIG9ic2VydmVkIGluIGFuIGFwcGFyZW50IGF0dGVtcHQgdG8g YXV0by0NCj4+PiB2ZWN0b3JpemUgdGhlIHN0b3Jpbmcgb2YgdHdvIGFkamFjZW50IHplcm9lcywg MzIgYml0cyBlYWNoLg0KPj4+DQo+Pj4gUmVwb3J0ZWQtYnk6IENocmlzRCA8Y2hyaXNAZGFsZXNz aW8ub3JnPg0KPj4+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNv bT4NCj4+IEFja2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29t Pg0KPiBUaGFua3MuDQo+DQo+PiBCdXQgd2hpbGUgd2UncmUgYXQgaXQsIHdoYXQgZWxzZSBtaWdo dCB3ZSBoYXZlIHRvIGNsb2JiZXIgdG8gc3RvcA0KPj4gbm9uc2Vuc2UgbGlrZSB0aGlzP8KgIHg4 NyBhbmQgYXZ4IGNvbWUgdG8gbWluZC4NCj4gQVZYIGlzIHRha2luZyBTU0UgYXMgYSBwcmVyZXEg KHdpdGggLW1uby1zc2UgJXhtbSBldGMgcmVnaXN0ZXJzIHNpbXBseQ0KPiBhcmUgdW5hdmFpbGFi bGUpLiBBbmQgd2l0aCAtbXNvZnQtZmxvYXQgSSB3b3VsZCB2ZXJ5IG11Y2ggaG9wZSB3ZSBoYXZl DQo+IGNsZWFybHkgaW5kaWNhdGVkIHRvIHRoZSBjb21waWxlciB0aGF0IHdlIHdhbnQgbm8geDg3 IGluc25zIHdoYXRzb2V2ZXIuDQoNCk9rLsKgIFNvdW5kcyBwbGF1c2libGUuDQoNCn5BbmRyZXcN Cg== From xen-devel-bounces@lists.xenproject.org Wed Jul 20 13:49:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 13:49:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371856.603717 (Exim 4.92) (envelope-from ) id 1oEA4h-00055k-2T; Wed, 20 Jul 2022 13:49:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371856.603717; Wed, 20 Jul 2022 13:49:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEA4g-00055d-Us; Wed, 20 Jul 2022 13:49:14 +0000 Received: by outflank-mailman (input) for mailman id 371856; Wed, 20 Jul 2022 13:49:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEA1P-0002uf-SO for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 13:45:51 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00089.outbound.protection.outlook.com [40.107.0.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4451eb4c-0832-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 15:45:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4431.eurprd04.prod.outlook.com (2603:10a6:803:6f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 13:45:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::60ad:4d78:a28a:7df4%4]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 13:45:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4451eb4c-0832-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N0JfG3Q75Q9RDZAidxW0xAAAIITouCF+AlX/kI6cY38kpuiXZXJi1jMw1A/1lmhTz3GVYY1wXtxVh25LGp94l5Gu0oS4nlWlyXewKVOtE5hHfs2TOjOVE0vN1fOLtmQs+m7ZgTsvdWLM9yTEQEZV+CkUHvNp7Klm0wdtbF1cYGxXPI/RVCU/xvMMPtIjf5DjeyEw8EZvcaGe9OePWsrvxdjhCOGfRxyDHr+lbWd231Nd4jkMChRXlKUbTBhsLIrlqNIcM2XsAJoMQDNSzdmmghi3OMJmZrWErVXKJHpkgswMehALLTlOsf4ZqQyURUY4lafPZ7lWC334C+WlAFC3dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jS/yKL4oIKTxMLrQEBaAASlunp0O/VzrpFcEz+o5dEA=; b=TwjmC9pryJZ3mpFKnzQpw2DYp5syvY/5psZkeJmp1qrnVWJKughySEeE6lGlhufqXkxmDTo5pDVWPbv+V8Od9UNexC1jnKURRBFJPlkqGC1FRe0EKa5/bLgf6mfWFQ4c/zdXodMJEoT87nt6mnVve+6obYoeSBSks6ZbBFs3dOFBw+aL2/s+9Qx9ap95mB8DBODV4KFl14x+JfqnU8XxKrJPrPDCJKTeeb1MryDe/Ym1ygaVBqPh1twCELo2I5mbF5FkFB0fH2HcggPRe+AgaGTCogG5sF5FHJOgA/VsFL/nXc1yjgGSPDcB80hBHlfidOUK4paupxkK0ZD/xyWGNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jS/yKL4oIKTxMLrQEBaAASlunp0O/VzrpFcEz+o5dEA=; b=20Q0HHJQlqWYof6fbs76SXlTyS61VB1Rj/s1a+8ttJxeHhpwJEA+5wcrV84IM8TsMmcXsh6VL5nQowoKE+FDVMYFJUJdfQ6T5ks89ZrMUjMn6Q1OfivFOlM9QuIFfEYntz4OSk5UfhT7iahoA7JZLbdLlz07dS9b1FGJ0VIOOL7aPg3pOgbkGIMAx1Xc39B9J8IByHDp/xmVoktCAnCUcePp9sqsA0QU5wcucjNiEP1ljDbUkXCK5MsoMFX9931O2NwMpe9LeNqRMkp8bBwO6L9Uljs7wKVRN88+T8ATemcOAHbWdFFiYV257uAHlYZ8No2gKsz1Qy+RfhimtBnvEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1b6bed07-a500-4683-3b0a-0c82dde1c1cd@suse.com> Date: Wed, 20 Jul 2022 15:45:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] Content-Language: en-US To: ChrisD Cc: Michael Young , Andrew Cooper , "xen-devel@lists.xenproject.org" References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> From: Jan Beulich In-Reply-To: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 00d911e9-4c09-40a7-94aa-08da6a56278f X-MS-TrafficTypeDiagnostic: VI1PR04MB4431:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rbcUtvPBo3lla9R2fl4CjxkOk+Y9dk8tUl2mFGDaljLDXYv8Wlxpi760p5j+uolTO+Em8cQWyX0rqmIkYQkG6bnAPn7LZufY/Z67tVd093BYWHe4JB3QF+b3F7iefHYY4rasysb501wczkZ5b/fNX1Vjs5gsV5+R+1sugrioyNuocyGeOM+MjZlcoGdwxTd0fmmgO4dnfPamHSLNzlRWxAY/nKsuaN9rcOPRCwObNWAYQODcnST+/fKB/VxhEKYNbUYwyAKIleifMEzQxWRODe3TYfxWrmSaQtEnmcxc/5Rnu+2u7IcfbJUTt7rdMJuJ+Xj2iI4A+24mP7UcyNfRbYOv9hgBAFH8KiLkJ4S/PMh0xgfXbpxQ3NY5YC0oeINlJCwPY0IQ1CpgewbNSeaSka8yRJRdFDHarp+XHOBju9ABrceTG4/LIHwjvGsIUDV9IXSU+GvCqBqYwlt6fhPxFLT1nH0xlfNWjw/t9GqpovohXL83t9HihyPtd6JYnJ+z74FKhBFAxaADlSJ6ihohCOnAmfZu9SOXhkwqXYbV/4BYb3mEDZok4SYtttXv3/16tmBULE3avdjJ+lE7xMyvl4ecwKZ61gZdwtUqTn5SuzpAE8jNQy4U+Wl4CN8pJKoeP85dpNEcKCosthZaDeWHyNsplSEswZGEUniUlalNWfGlktU5y56HjSP21IhS+TuNNY0MTNN7EInYW6FrTInnZM+uedxSbVBZdueFgb4i5A/yX+yrL7n44mjAOOmxjyr7ZUTZg6sd19tk4cSnotlqDExOB2Wl6io5/LJ5GFmj5OvezMVSIx8Z8Fjq0qTiDjumZMsqIVcIKn8sv+z+2yeyiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(136003)(366004)(39860400002)(376002)(4326008)(6512007)(478600001)(53546011)(6486002)(86362001)(2616005)(26005)(186003)(38100700002)(6506007)(41300700001)(66946007)(31696002)(6916009)(558084003)(8676002)(31686004)(36756003)(5660300002)(8936002)(2906002)(54906003)(66476007)(316002)(66556008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MjROd3lFc3p3bzY3ZXZZUWM3Q0dMd2hKaWYySzRoUGhqdFl0cE43VUhDVnlh?= =?utf-8?B?K2lEcXo0RlNxY2tMTzBnZW84MnNobDkrbjRSVmRzcDJqQWloNmt2Q0tsMDZD?= =?utf-8?B?eEh0WUxxdnFmMmlHcmEwS21MQmwrem15aVpEUVNJMmhHZXVBbDNsWCt4Q0Z1?= =?utf-8?B?dXVqSzJTK1NSa3A0TVFwTFpQc1cxT1QyOHd2OWE4cForbWU1anZvUjlCd0w3?= =?utf-8?B?TVVBQXVzdHJsMjI4azJ6VE11M1M3QWxKWGVkdWw2MktxaUVjQjZhb1dzNnU3?= =?utf-8?B?Nnk2TVAvQWxJODNTbmJJMEoyVTM2MS9aR3N6MDdKbmRwcktldnVFMWV5MEJR?= =?utf-8?B?cDJqeFE4blJNN1ZmUVN2MTROb3NIUGlZM29qc0lsSTRWbThYRUg1T0JIS2xD?= =?utf-8?B?dDdKVkU3Tjlmb2FHVXdBcGZnbWh0Z2N2NXlUVy9VVTd5NGNGdjZhS2s2SUN4?= =?utf-8?B?WVNucWJzZ0RtT1NyeUhkMGppU0c0ai9RL3lkWEk3VGRDejc1aitmajJOVXdH?= =?utf-8?B?eGFSYW5pcEh5YVlyUUxyaWsvSndzbDhyc1N0ZmRiaFpFS1Vtc3MzTkxndTRm?= =?utf-8?B?emVFL3IrbU02cVpPTkhKU1l3OWEvVExReDMxTFIxWExXUW1MeHZpRS9vQ2VD?= =?utf-8?B?U2tJakJIT0JEZW9vcVllQ3p5UlhtOHh6akJlUTc2em9JMjV2WU9LZVZYOTRk?= =?utf-8?B?YXhVdE9KdVN3VkpvVzlGWTdlVEczWFlqVTBIbFl4MzJqMlNidURJWGErQ3Bj?= =?utf-8?B?V0FyUnF4dXRJTDRlS0RxN1pFbUgyUGxzYmloQU5kbU43OERIZUxUSEhTSnM3?= =?utf-8?B?dFZlaUREcmN5MXZQL2oyVWJIak1mcDZXcmtaOHVkMm83S3lvREJrbjdSQUN0?= =?utf-8?B?SndoTmVSdkVDREdPaFBIaFFaUndWMmkvYUtYL3grY1VOaTF2eHV2cGxac0V5?= =?utf-8?B?anFQOTV4UVRqbm9tZUFoQkM1UXlIMVNBVVV5YmJackNWUURSaW1uUHk2aW56?= =?utf-8?B?andUbXZKL0tFZUhhdFd1dEp4MlZQUkNDVktaTWUzTmxxNmtuTEZvMlFXSnhV?= =?utf-8?B?amMyQnlyRk1qMFlsVXRhU3d3QjZRVDBkanFjbjQ1OHo3Q0hwNS83SmhpRFBh?= =?utf-8?B?MHVxT0ptTmpUWFpmL3pMN0szUDdCU2xPZndNM1ltSzUzTUpwWFNDeWYySjFy?= =?utf-8?B?MEVDL0hPUDZRUFlxSGQyY2NrYnU2MjlSSE94R1ZXbVVEd3RFRjNnRFl0WURz?= =?utf-8?B?c1VtUGV0Q1VSLytWWE9OMWdoUklsdEhGU2lJZVdRODg4VlVIR3JpR2V2eEpF?= =?utf-8?B?MnZFLzcvV3lXVURxbFVGbTh6Rkh2Z1R6TEVBc3d1WDFIYzBGeXZSd09XMTZv?= =?utf-8?B?N0duT3pwMEdsVkZjcVJKa0FERGZ0ODI5NEREejhqK0tmSyttdWROVGh1NGhF?= =?utf-8?B?cFJrZUtoNzZuYUcwc2FxRmJxdkxUckZKdUtQMGp4QmFNa0NkWjdUQnhsOTJ6?= =?utf-8?B?MXRVeWlkY1EyQ202V0V2VjFhTldMS1RGWFhPVjZKZUZjWmhXOG9QbjNGeGVp?= =?utf-8?B?am9KejlzTG1UcVdGUUs5QW5nNEFTSzZ3azNmNUF3MVZDTlllSHA4R29XdnZR?= =?utf-8?B?WlUrNjBENVNZbjRKNXBLSVFUWS8xVVJDd1Z2TFAyZW1qbEhIRDF4Q3pyUHhW?= =?utf-8?B?WTlpeWZHYVpKSzhNRTBUTW5Zc3JCQkErdG5jcGtmZjk4dUFWRmhwcHdyc1Zz?= =?utf-8?B?MDdpRTJaelcyeTdtQlF2ZFZ1Tm84YVpFRzVsZW9FRTl2MDR2cFgydHhIY05T?= =?utf-8?B?cU9sL0w5UnpQTFE1VkFGZUNDZnVSZmFlRnFzWFpkcUgvMDFLekVKOG1YUlds?= =?utf-8?B?STBYOVZYQ0JDQ0F4VTFRUkVMMTFnSmJJbkNkbUJNMHlIbzlpZ3JGdStJa2dj?= =?utf-8?B?bjFnNFJURHFZSUQyOUhCQ1ZuVFRvamhoMkVSQmc0TWhQN3E0blJVMFpNRTV6?= =?utf-8?B?MTVsRDBhWWYzMjBhNi93b2FSUHN1NDUvVlpXMDg5RzM0UU9yMHRZWnBVcVpQ?= =?utf-8?B?WGRrVjkrckY4emZjbEJPeDFjbytrQnBPYWhmdVdOaHJiOXJYbUNlSnJtQ0ps?= =?utf-8?Q?l9P1WwFuFYc6fVuXP3c/Pj64d?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00d911e9-4c09-40a7-94aa-08da6a56278f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 13:45:49.1361 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Hu0DiMOCad7TO7hRIRRvSJR9MwHgOXBsxtXyiZL5DAXiww6wHA3svx48oSNBYFxRvAQJgYGS5aTvRy3/TZoQoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4431 On 20.07.2022 06:48, ChrisD wrote: > So, you think it's a problem with fc36? Just to also state it here - it turns out we need to tell the compiler to avoid MMX insns. A patch for this was already sent and ack-ed. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 20 14:31:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 14:31:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371884.603735 (Exim 4.92) (envelope-from ) id 1oEAjZ-0002zw-FX; Wed, 20 Jul 2022 14:31:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371884.603735; Wed, 20 Jul 2022 14:31:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEAjZ-0002zp-Cr; Wed, 20 Jul 2022 14:31:29 +0000 Received: by outflank-mailman (input) for mailman id 371884; Wed, 20 Jul 2022 14:31:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEAjY-0002ze-2A for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 14:31:28 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a02e128c-0838-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 16:31:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a02e128c-0838-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658327486; h=date:from:to:cc:subject:message-id:mime-version: content-transfer-encoding:in-reply-to; bh=TJ6DZ2oWI3AF7li+JDEzJLBp+/fJiehqbIJe5gKaBXM=; b=PZ2p4vIVsbCrtea3Gh3ZrtaaOSVOBkyx71x7qdS2IZ5X5MWUw0w3ZNAN h/xFab8TPe1KrMXfa/YGFXMlRIL+TVafQ5qYj92px1Jo7lJDC++rcDWfi cLMwGFsSrwbZVnlZDH35ik7H2XpmgokFxv4WauvIEGFBXJccQgkSJRoIb Y=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75525756 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jKAC8aw+BWraU6KP9MR6t+cDxirEfRIJ4+MujC+fZmUNrF6WrkUGy WBLCm6Obq6CMWHzcoslPIzn/B9QuZXSx9BmSVQ+riAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7/s9JIGjhMsfjb90k35K2aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1vFUUnJJQnyt1YQmFz0 eIjJTIESiCM0rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzJZQFPPVEGToozhu6yilH0ciFCqULTrq0yi4TW5FMsjeKwb4eLEjCMbe5bjka35 U3hxEnoXxA7KIOR0DSY0Uv504cjmgukAdlPRdVU7MVCglKJwXcIIAYLTlb9qv684mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O+En7gWE0qX8/gOYDWhCQzJcAPQjvdM2RDE3k EOAhcngARR3qrqJTnSY/7aQ6zi1PEA9PWIEIDIfQBEey93iu50oyALCSM55F6y4hcGzHiv/q w1mtwBn2e9V15RSkfzmoxaX2FpAu6QlUCY0/wHGR3ua3jhWJ46YQ5KT5FrSycZPedPxoka6g JQUpySPxLlQUMHXzXbcHLxl8KKBvKjcbmCF6bJ7N9x4rmn2pSb+FWxFyGsmTHqFJProbtMAj KX7nQpKrKFeM3KxBUOcS9LgUp96pUQM+DmMaxw1UjatSsIoHON/1HsyDXN8Jki0+KTWrYkxO I2AbeGnBmsABKJswVKeHrlAgeV2m3BmmD6PFfgXKihLNpLHPhaopUotagPSPojVEovfyOkqz zqvH5TTkEgOOAEPSiLW7ZQSPTg3EJTPPriv8pQ/XrPSfWJb9JQJUaC5LUUJJ9M4xMy4V47go hmAZ6Ov4AGv2S2WcF7UMiELhXGGdc8XkE/X9BcEZT6As0XPq672t8/zq7NfkWEbydFe IronPort-HdrOrdr: A9a23:6J8I4aE7wtVd34pmpLqEEseALOsnbusQ8zAXPiBKJCC9vPb5qy nOpoV+6faQslwssR4b9uxoVJPvfZq+z+8R3WByB8bAYOCOggLBQL2KhbGI/9SKIVydygcy78 Zdm6gVMqyMMbB55/yKnDVRxbwbsaa6GKPDv5ah8590JzsaDJ2Jd21Ce32m+ksdfnghObMJUK Cyy+BgvDSadXEefq2AdwM4t7iqnayzqHr+CyR2fyIa1A== X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="75525756" Date: Wed, 20 Jul 2022 15:31:00 +0100 From: Anthony PERARD To: Mathieu Tarral CC: Xen-users , George Dunlap , George Dunlap , Juergen Gross , Subject: Re: xen master: xl create hangs Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: CCing Juergen and xen-devel. On Mon, Jul 18, 2022 at 06:25:54PM +0000, Mathieu Tarral wrote: > Using gdb to debug the xl process, I get the following stacktrace: > > (gdb) bt > #0 __futex_abstimed_wait_common64 (private=128, cancel=true, abstime=0x0, op=265, expected=8652, futex_word=0x7f6debd22a50) at ./nptl/futex-internal.c:57 > #1 __futex_abstimed_wait_common (cancel=true, private=128, abstime=0x0, clockid=0, expected=8652, futex_word=0x7f6debd22a50) at ./nptl/futex-internal.c:87 > #2 __GI___futex_abstimed_wait_cancelable64 (futex_word=futex_word@entry=0x7f6debd22a50, expected=8652, clockid=clockid@entry=0, abstime=abstime@entry=0x0, > private=private@entry=128) at ./nptl/futex-internal.c:139 > #3 0x00007f6deba736a4 in __pthread_clockjoin_ex (threadid=140110084581248, thread_return=thread_return@entry=0x0, clockid=clockid@entry=0, > abstime=abstime@entry=0x0, block=block@entry=true) at ./nptl/pthread_join_common.c:105 > #4 0x00007f6deba73543 in ___pthread_join (threadid=, thread_return=thread_return@entry=0x0) at ./nptl/pthread_join.c:24 > #5 0x00007f6deb9a144b in xs_daemon_close (h=0x561db3bc5bc0) at xs.c:366 > #6 0x00007f6deb9a145f in xs_close (xsh=) at xs.c:386 > #7 0x00007f6debc43a36 in libxl_ctx_free (ctx=0x561db3bc52e0) at libxl.c:173 > #8 0x0000561db33bf5a3 in xl_ctx_free () at xl.c:370 > #9 0x00007f6deba22495 in __run_exit_handlers (status=0, listp=0x7f6debbf6838 <__exit_funcs>, run_list_atexit=run_list_atexit@entry=true, > run_dtors=run_dtors@entry=true) at ./stdlib/exit.c:113 > #10 0x00007f6deba22610 in __GI_exit (status=) at ./stdlib/exit.c:143 > #11 0x00007f6deba06d97 in __libc_start_call_main (main=main@entry=0x561db33c0425
, argc=argc@entry=4, argv=argv@entry=0x7ffeb2f263d8) > at ../sysdeps/nptl/libc_start_call_main.h:74 > #12 0x00007f6deba06e40 in __libc_start_main_impl (main=0x561db33c0425
, argc=4, argv=0x7ffeb2f263d8, init=, fini=, > rtld_fini=, stack_end=0x7ffeb2f263c8) at ../csu/libc-start.c:392 > #13 0x0000561db33bf425 in _start () > > Colorized version in a Github Gist: > https://gist.github.com/Wenzel/4da1e0a025954fac13a0ee57147cc44f > > So looks like xs_daemon_close is waiting on a thread to join: > https://github.com/xen-project/xen/blob/a5fb66f4513c2c2d222dcc3753163b15690bd003/tools/libs/store/xs.c#L366 On Wed, Jul 20, 2022 at 12:53:29PM +0000, Mathieu Tarral wrote: > > Verify that things work properly at that commit, then use that as the “good” starting point. > > Turns out that this commit (74a11c43fd7e074b1f77631b446dd2115eacb9e8) was also bad. > So I used git bisect again, but this time to find the commit which introduced the bug fix > between 74a11c43fd7e074b1f77631b446dd2115eacb9e8 and RELEASE-4.16.1. > > After a few steps, git bisect identified this commit: > https://github.com/xen-project/xen/commit/59505f48fabed2e6fa5ad992edaabeb4a1441599 > "Turn off debug by default" > Surprisingly simple. > > And I confirm that it's one that fixes the issue of xl create hanging. > > I cherry-picked this commit on master: > https://user-images.githubusercontent.com/964610/179986382-a774c91a-7b68-416b-9dbe-226b8aca0673.png > > recompiled and tested again, my master branch now works as expected, tested with the small config file I already had and the XTF test-pv64-example. > > So it works, but I don't know why this commit fixed it. $(debug) controls the level of optimisation of the compilation to make it easier to debug. So, with debug=y, we have libxenstore having issue with killing the its reading thread? :-( Maybe that reading thread is doing something that can't be stopped, maybe it's waiting for a lock. Could you try to print a back trace of that thread (or even all thread in `xl`)? ("thread apply all bt full" in gdb) Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 20 15:05:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 15:05:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.371960.603801 (Exim 4.92) (envelope-from ) id 1oEBGV-0001JG-79; Wed, 20 Jul 2022 15:05:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 371960.603801; Wed, 20 Jul 2022 15:05:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEBGV-0001J9-3h; Wed, 20 Jul 2022 15:05:31 +0000 Received: by outflank-mailman (input) for mailman id 371960; Wed, 20 Jul 2022 15:05:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEBGT-0000sn-5Y for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 15:05:29 +0000 Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6332d667-083d-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 17:05:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6332d667-083d-11ed-924f-1f966e50362f Date: Wed, 20 Jul 2022 15:04:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658329482; x=1658588682; bh=8I6cUtZSxk5aI20oZA3YlA3RP4NUz/d6XthLogP9r+E=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=G491Dn2r0ZXu4IEQcp2uuwyYDSgPsyWy6x1cPic4+z/8KMtLS1+X2auvtagsZuhA4 6LCAsxaOecbbgxAY1EFMmz2sangpVgII8LiM9zprdmocrYSr7UOF+jgk0lY14DKz1n Rlermn1I2/2rayToe/P1Fy3V2EqI7tOXnwpMhsBIP0jg25b4iK8Q4YHX30wyuidQQS lguqcqAjVQyhwi4432JmBXb5X5RyhXjxg7ovkEF7uMNGTMwXXgmcAW4KVFUADrW6z4 Q3IRocngeD8A+G/3QPH4mbHoMlACpURyMSdW4/xQG96jWUf/DMXNljKpzIIzmpFWLG n8baQdSuUU8Vg== To: Anthony PERARD From: Mathieu Tarral Cc: Xen-users , George Dunlap , George Dunlap , Juergen Gross , xen-devel@lists.xenproject.org Reply-To: Mathieu Tarral Subject: Re: xen master: xl create hangs Message-ID: In-Reply-To: References: Feedback-ID: 279104:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi Anthony > $(debug) controls the level of optimisation of the compilation to make > it easier to debug. > > So, with debug=3Dy, we have libxenstore having issue with killing the > its reading thread? :-( > Maybe that reading thread is doing something that can't be stopped, > maybe it's waiting for a lock. Could you try to print a back trace of > that thread (or even all thread in `xl`)? ("thread apply all bt full" in = gdb) I recompiled the buggy master, and this is the full GDB stacktrace when xl = create hangs: https://gist.github.com/Wenzel/969d5c06982246cd6cb2eb8cdf252a18 I don't see the same stacktrace as before, maybe I was on a different commi= t ? I hope this helps. Mathieu From xen-devel-bounces@lists.xenproject.org Wed Jul 20 16:04:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 16:04:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372005.603811 (Exim 4.92) (envelope-from ) id 1oECAz-0001Nb-HA; Wed, 20 Jul 2022 16:03:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372005.603811; Wed, 20 Jul 2022 16:03:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECAz-0001NU-ER; Wed, 20 Jul 2022 16:03:53 +0000 Received: by outflank-mailman (input) for mailman id 372005; Wed, 20 Jul 2022 16:03:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECAy-0001N8-Hm for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 16:03:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8b0f6901-0845-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 18:03:51 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8b0f6901-0845-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658333031; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=iyL2gP3DD/Oi9RpeIZmLJLel87QLp/1xugjUaTuMWtI=; b=enJNAPoIaDhzQimOeUARhvcaW1x2x8HTPORyEQ9sz02yNZUJS258loPa 49w1pbmpb5tLpz7GBDB2XmqluMZc047bVa8QWPfvvBLegxR2440f/vQww cjI1HVilT3TNVj9xcC3knbCq61HSPY1hkBKV8J3kTDLdeExMq6N0FvPX9 8=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75536602 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:mtUm06B889WhGRVW/73jw5YqxClBgxIJ4kV8jS/XYbTApG4i1WQGz DAbWD3QbKyKYGD8KN9wPoWz/UkDvJODxoMxQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsfrb8XuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJWyvsnftgM1MQBKIz4PR9X01l9 MwjAglYO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDWOl1IviOKF3Nz9QOCheNoLzmCim mvi51/TEE44CISyxm/Qmp6rrrCWxn6qMG4IL5Wj7eJjilCXwm0VCTUVWEG9rP3/jVSxM/pdJ FYT4TEGtrUp+QqgSdyVdx+lpH+JuDYMVtwWFPc1gCmHx7DI+Q+fCi4BRyRYdd09nMYsQHoh0 Vrht+3uATtjobiEU0W3/72frS6xESUNJGpEbigBJSMV7t+mrIwtgxbnStd4DLXzntDzASv3w T2BsG45nbp7pckP2qag4UHcgxqjo5HISkg+4QC/dmWh4wBibYipfbu0+EPb5vZNKoWeZlSZt X1CkM+bhMgUCoqHjiuKQ+MlE7Sg5vLDOzrZ6XZwG7Ex+jLr/GSsFb28+xkneh0vaJxdP2a0P gmD4mu9+aO/IlP6bfF5bb2jLf0F5rLyH4rJffHkVfB3N80ZmBC8wM1+WaKB9zmzzRh2yPtuZ c7zndWEVihDV/k+pNaib6JEiOJwmHhjrY/GbcqjpylLx4Zyc5J8pV0tFFKVJt4046qfyOk+2 4YObpDao/mzvQCXX8U2zWLwBQpTRZTDLcqqw/G7j8baSuacJEkvCuXK3ZQqcJF/kqJem4/gp y/gChUFlQqn2CCbeW1mj0yPj5u2B/5CQY8TZ3RwbT5EJVB4CWpQ0EvvX8RuJuR2nACS5fV1U +MEa629Pxi7cRyeomx1RcSs8+RfmOGD313m09yNPGdiJPaNhmXhprfZQ+cY3HJQVHTv6ZRk/ eHIO8GyacNrejmOxf3+MJqHp25dd1BE8A6udyMk+uVuRXg= IronPort-HdrOrdr: A9a23:cF26XqnybPj3lkY5XDgeYPbnk+DpDfIs3DAbv31ZSRFFG/Fxl6 iV8sjz8SWE7Ar5OUtQ/OxoV5PsfZqxz/JICMwqTNCftWrdyQmVxeNZjbcKqgeIc0aVygce79 YCT0EXMqyXMbEQt6fHCWeDfOod/A== X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="75536602" Date: Wed, 20 Jul 2022 17:03:33 +0100 From: Anthony PERARD To: Oleksandr Tyshchenko CC: , Oleksandr Tyshchenko , Wei Liu , George Dunlap , Nick Rosbrook , "Juergen Gross" , Stefano Stabellini , "Julien Grall" , Volodymyr Babchuk , Bertrand Marquis Subject: Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Message-ID: References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> <20220716163745.28712-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220716163745.28712-1-olekstysh@gmail.com> On Sat, Jul 16, 2022 at 07:37:45PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > This patch adds basic support for configuring and assisting virtio-mmio > based virtio-disk backend (emulator) which is intended to run out of > Qemu and could be run in any domain. > Although the Virtio block device is quite different from traditional > Xen PV block device (vbd) from the toolstack's point of view: > - as the frontend is virtio-blk which is not a Xenbus driver, nothing > written to Xenstore are fetched by the frontend currently ("vdev" > is not passed to the frontend). But this might need to be revised > in future, so frontend data might be written to Xenstore in order to > support hotplugging virtio devices or passing the backend domain id > on arch where the device-tree is not available. > - the ring-ref/event-channel are not used for the backend<->frontend > communication, the proposed IPC for Virtio is IOREQ/DM > it is still a "block device" and ought to be integrated in existing > "disk" handling. So, re-use (and adapt) "disk" parsing/configuration > logic to deal with Virtio devices as well. > > For the immediate purpose and an ability to extend that support for > other use-cases in future (Qemu, virtio-pci, etc) perform the following > actions: > - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect > that in the configuration > - Introduce new disk "specification" and "transport" fields to struct > libxl_device_disk. Both are written to the Xenstore. The transport > field is only used for the specification "virtio" and it assumes > only "mmio" value for now. > - Introduce new "specification" option with "xen" communication > protocol being default value. > - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current > one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model > > An example of domain configuration for Virtio disk: > disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] > > Nothing has changed for default Xen disk configuration. > > Please note, this patch is not enough for virtio-disk to work > on Xen (Arm), as for every Virtio device (including disk) we need > to allocate Virtio MMIO params (IRQ and memory region) and pass > them to the backend, also update Guest device-tree. The subsequent > patch will add these missing bits. For the current patch, > the default "irq" and "base" are just written to the Xenstore. > This is not an ideal splitting, but this way we avoid breaking > the bisectability. > > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 20 16:06:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 16:06:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372010.603822 (Exim 4.92) (envelope-from ) id 1oECDf-00028k-Uf; Wed, 20 Jul 2022 16:06:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372010.603822; Wed, 20 Jul 2022 16:06:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECDf-00028d-S0; Wed, 20 Jul 2022 16:06:39 +0000 Received: by outflank-mailman (input) for mailman id 372010; Wed, 20 Jul 2022 16:06:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECDe-00025G-WA for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 16:06:38 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecdf0b1a-0845-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 18:06:35 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecdf0b1a-0845-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658333195; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=gbGvLp8fdso+bACMBSwD3Z+fkqyE4Fr15tmPJJuH8kI=; b=SagQvOlumhrfqajXY+HUrYGnsqMTGcIvNlcNzaLkQ9nT3bVhnqgr9PVG n0BijSnGwz71lTpWdQrn2JbuITLAqFrbmu7vqgumvc3wwbQoejJclPIcQ oAfpKekUnnWn1U2vJVMi2nIBaDD7M8zKdGgGeYNxm5rsfw4DxFcS6CSb+ w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 78813765 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:qzMa5qllIXi5Gj4Q9kIqbHzo5gymJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIbWj+DbPzZY2HwctByOYuxo0lQuJLczYJnQFNppSw9QSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8uWo4ow/jb8kk3466q4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kYYZA1+cB0Qlpnz tEhDR0dVQjZttyflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+Oe9YIOOJYLXLSlTtlSFj 0T/0TnVOAEDK+6z5CaP2E+Q2daayEsXX6pNTeblp5aGmma73GsIAgcRUli9ifa8g0+6HdlYL iQ85S4GvaU0skuxQbHVWBm1o2WNuBIGbMZBCO0x6AyLya387h6QAy4PSTspQNsiucwtWS0x1 neGmtroAXpkt7j9YWKQ8PKYoC2/PQARLHQefmkUQA0d+d7hrYovyBXVQb5e/LWd14OvX2uqm nbT8XZ41+57YdM3O7uT0wzarjGKpdvyZzUY3yD6Tlm9tDJHTdvwD2C30mQ3/cqsPa7AEATR5 iFeypTHhAwdJcrTzXLQGY3hCJnsvq/Ya2OE3DaDCrF7r1yQF2ifkZe8Cd2UDGNgKY46dDDge yc/UisBtcYIbBNGgUKaCr9d6vjGLoC6TLwJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yUCZAVPk3lGfrG7d1PVoXKscWnDm7eHwG507/jer2iIC9Et/pz2dinshmtfjZ8W05A v5UNteQygU3bdASlhL/qNdLRXhXfCdTOHwDg5YIHgJ1ClY5RTpJ5j646e9JRrGJaIwOyL2Wp i3iABEEoLc97FWeQTi3hrlYQOuHdf5CQbgTYUTA4X7AN6AfXLuS IronPort-HdrOrdr: A9a23:mHvrmKzjMRD1zm5cw+ZxKrPwLL1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPH7P+VMssR4b9OxoVJPtfZqYz+8T3WBzB8bBYOCFgguVxehZhOOIqQEIWReOldK1vZ 0QFZSWY+eQMbEVt6nH3DU= X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="78813765" Date: Wed, 20 Jul 2022 17:06:16 +0100 From: Anthony PERARD To: Oleksandr Tyshchenko CC: , Oleksandr Tyshchenko , George Dunlap , Nick Rosbrook , Wei Liu Subject: Re: [PATCH] golang/xenlight: Update generated code Message-ID: References: <20220718092125.307310-1-olekstysh@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20220718092125.307310-1-olekstysh@gmail.com> On Mon, Jul 18, 2022 at 12:21:25PM +0300, Oleksandr Tyshchenko wrote: > From: Oleksandr Tyshchenko > > Re-generate goland bindings to reflect changes to libxl_types.idl > from the following commit: > 54d8f27d0477 tools/libxl: report trusted backend status to frontends > > Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 20 16:24:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 16:24:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372018.603852 (Exim 4.92) (envelope-from ) id 1oECV3-0005Cs-OV; Wed, 20 Jul 2022 16:24:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372018.603852; Wed, 20 Jul 2022 16:24:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECV3-0005Cl-LZ; Wed, 20 Jul 2022 16:24:37 +0000 Received: by outflank-mailman (input) for mailman id 372018; Wed, 20 Jul 2022 16:24:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECV2-0004mQ-Al for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 16:24:36 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6fcae1d8-0848-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 18:24:34 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6fcae1d8-0848-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658334274; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FXRHk59uu6znUS4nvUL8AGhMHJGKbD2dFt27kaALOBI=; b=ekNmNAQcL4FeZSWuVhIC7qabotkEh0zJPCsmIcqXVhJjwPRrK1AJHx3m Y6BU4AQ4/Rian5dkvFHQsYtyXNR5tLTCAC+Ara8IvLxE6nmGw6vQuS93z TuF9qWk1tM3G2x0OJX1JSYAnSmTCFEbk3D4SHysN8+D8iS4QBGqd4VCI8 U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 78815745 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ESKZZauab49swzhfzuUmh4+VsefnVGNeMUV32f8akzHdYApBsoF/q tZmKWyDbPmMZTPwf9sjOo/koUNT75XUmtE2SQFsqHgxRiMb+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzh8B56r8ks15qyt4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FZMXorlFBF9Dz 9ARFzUKQgu9xMju+YvuH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3Fb4qFI4HVGZg9ckCwm Uz31UXEOkwhHYaClBqp8Ervu8SSknauMG4VPOLhraM76LGJ/UQRBwcRTkCTuuSihwi1XNc3A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mlxrfS5w+BCUAZSz9KaJoruNJebTkjy l+Iks6vGTV1qrSRYWqH8auTqza7OCxTJmgHDQcUQA1A/sLuupobihPUUs0lAKOzlsfyGzz73 3aNtidWulkIpZdVjePhpwmB2m/y4MiSJuIo2unJdnyqtlxLYbCoXaCh1l3cwe1+b6zBd2DU6 RDohPOiAPAy4YClzXLQEL9URuD1vp5pIxWH3wcxQsBJGyCFvif6INsOuGwWyFJBaJ5sRNP/X KPEVeq9Drd3NWDiU6J4apnZ5y8Cnfm5ToSNuhw5g7NzjnlNmOyvpngGiba4hTyFraTVufhX1 W2nWcitF20GLq9s0SC7QewQuZdymH1unz6OFcimkkj3uVZ7WJJyYe5fWGZik8hjtP/UyOkr2 4032zS2J+V3D7SlP3i/HX87JlEWN3krba3LRzhsXrfaemJORTB+Y8I9NJt7JOSJaYwJybqTl px8M2cEoGfCaYrvclvQNCg/N+mxAf6SbxsTZEQRALph4FB7Ca7H0UvVX8FfkWUPnAC78cNJc g== IronPort-HdrOrdr: A9a23:pVoWmq+boJPl0p+ppY5uk+DYI+orL9Y04lQ7vn2YSXRuHPBws/ re+MjztCWE7Qr5N0tMpTntAsW9qDbnhPlICOoqTNWftWvd2FdARbsKheCJ/9SjIVycygc079 YHT0EUMrzN5DZB4vrH3A== X-IronPort-AV: E=Sophos;i="5.92,286,1650945600"; d="scan'208";a="78815745" Date: Wed, 20 Jul 2022 17:24:22 +0100 From: Anthony PERARD To: Mathieu Tarral CC: Xen-users , George Dunlap , George Dunlap , Juergen Gross , Subject: Re: xen master: xl create hangs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: On Wed, Jul 20, 2022 at 03:04:22PM +0000, Mathieu Tarral wrote: > Hi Anthony > > > > $(debug) controls the level of optimisation of the compilation to make > > it easier to debug. > > > > So, with debug=y, we have libxenstore having issue with killing the > > its reading thread? :-( > > Maybe that reading thread is doing something that can't be stopped, > > maybe it's waiting for a lock. Could you try to print a back trace of > > that thread (or even all thread in `xl`)? ("thread apply all bt full" in gdb) > > I recompiled the buggy master, and this is the full GDB stacktrace when xl create hangs: > https://gist.github.com/Wenzel/969d5c06982246cd6cb2eb8cdf252a18 > > I don't see the same stacktrace as before, maybe I was on a different commit ? I think that this `xl` process just wait for the domain to shutdown or die. When we run `xl create`, before exiting there's a fork/exec of xl which handle a few domain events, so it looks like this stack trace is expected (and look like the one I have). So it don't looks like to be the xl process that hangs. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Wed Jul 20 16:26:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 16:26:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372045.603863 (Exim 4.92) (envelope-from ) id 1oECX3-0006Y4-51; Wed, 20 Jul 2022 16:26:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372045.603863; Wed, 20 Jul 2022 16:26:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECX3-0006Xx-1i; Wed, 20 Jul 2022 16:26:41 +0000 Received: by outflank-mailman (input) for mailman id 372045; Wed, 20 Jul 2022 16:26:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECX1-0006K1-3c; Wed, 20 Jul 2022 16:26:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECX1-0004cm-1H; Wed, 20 Jul 2022 16:26:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oECX0-0007jL-Oo; Wed, 20 Jul 2022 16:26:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oECX0-0003dh-OK; Wed, 20 Jul 2022 16:26:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w88lECjjgaRnQThNQQX6rRHlfdCz/oMqpaHHoBEADIM=; b=38HaUmi0i/FxFVa5VlW1qYIW1E Z0ujzYQ9b1yVrlnpOJhkl8MF9OL8t0GAQP9hLHjWBHp25+TX1vV/cyueT89zTYdcRSFeDZKwd7fft U2D/zl6yTkchirj2Sg6Dtb6EQ2oP2+NLC4QLz9fHdH0ZDgHgTrtyDXK6fOi1meL30lxM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171705: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6fe2e39a0243bddba60f83b77b972a5922d25eb8 X-Osstest-Versions-That: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf From: osstest service owner Date: Wed, 20 Jul 2022 16:26:38 +0000 flight 171705 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171705/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 6fe2e39a0243bddba60f83b77b972a5922d25eb8 baseline version: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf Last test of basis 171688 2022-07-19 15:01:54 Z 1 days Testing same since 171705 2022-07-20 14:01:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c16a9eda77..6fe2e39a02 6fe2e39a0243bddba60f83b77b972a5922d25eb8 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jul 20 17:31:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 17:31:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372067.603881 (Exim 4.92) (envelope-from ) id 1oEDX5-0006sl-6N; Wed, 20 Jul 2022 17:30:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372067.603881; Wed, 20 Jul 2022 17:30:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEDX4-0006rA-Vx; Wed, 20 Jul 2022 17:30:46 +0000 Received: by outflank-mailman (input) for mailman id 372067; Wed, 20 Jul 2022 17:30:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEDX3-0006m6-Sm for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 17:30:45 +0000 Received: from mail-4322.protonmail.ch (mail-4322.protonmail.ch [185.70.43.22]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ae1bf13c-0851-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 19:30:43 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ae1bf13c-0851-11ed-bd2d-47488cf2e6aa Date: Wed, 20 Jul 2022 17:30:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1658338241; x=1658597441; bh=szd33vzL3HSe+BF5QKyTv7z99EAnCnS+kHy0kotcKsE=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:Feedback-ID:From:To:Cc:Date:Subject:Reply-To: Feedback-ID:Message-ID; b=lLGTKMX2fPvjuI2VMcmlgBEieu6bSS8RgSvHIoPtdY1E1AvbvhYkM8h7pg5TDG2Ag /l23gye/jndPYHkh7zFXjFB546ZZGS8fkwntjNP974VdTPECH2XmVokWrYMIF683ba qhWFvS+AKYu+4hpPOpqT9zPps6A54T6rQQI83ehe22PCcYn253dSRGXbYsIKsHFved i3DnkYbpF5rNFn9nxyy497IayGwqqix5tgWM/QALv0ruVLvpDeSgD8AHgDlkc7taqY I9K/utfvBhbK8HsttfHGIhqQ3jBhY6GDaCKYzmdks8OScT3BftC92RfiKlBD+/wiAb eIcD+DTMOHbeA== To: Anthony PERARD From: Mathieu Tarral Cc: Xen-users , George Dunlap , George Dunlap , Juergen Gross , xen-devel@lists.xenproject.org Reply-To: Mathieu Tarral Subject: Re: xen master: xl create hangs Message-ID: In-Reply-To: References: Feedback-ID: 279104:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable > I think that this `xl` process just wait for the domain to shutdown > or die. When we run `xl create`, before exiting there's a fork/exec of > xl which handle a few domain events, so it looks like this stack trace > is expected (and look like the one I have). So it don't looks like to be > the xl process that hangs. I tested again but this time with XTF test-pv64-example: https://user-images.githubusercontent.com/964610/180044164-74d12f63-d901-4e= 33-93be-073c7ed8d7dc.png This is the new xl stacktrace: https://gist.github.com/Wenzel/969d5c06982246cd6cb2eb8cdf252a18#file-gdb2-x= s-daemon-close-c It now shows the first thread waiting on the reading thread to join, as we = expected: https://github.com/xen-project/xen/blob/0e60f1d9d1970cae49ee9d03f5759f44afc= 1fdee/tools/libs/store/xs.c#L366 And the second one waiting in read_message: https://github.com/xen-project/xen/blob/0e60f1d9d1970cae49ee9d03f5759f44afc= 1fdee/tools/libs/store/xs.c#L1265 Mathieu From xen-devel-bounces@lists.xenproject.org Wed Jul 20 17:42:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 17:42:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372107.603903 (Exim 4.92) (envelope-from ) id 1oEDiR-00018U-5v; Wed, 20 Jul 2022 17:42:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372107.603903; Wed, 20 Jul 2022 17:42:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEDiR-00018N-36; Wed, 20 Jul 2022 17:42:31 +0000 Received: by outflank-mailman (input) for mailman id 372107; Wed, 20 Jul 2022 17:42:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEDiQ-00017n-5u for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 17:42:30 +0000 Received: from mailhost.m5p.com (mailhost.m5p.com [2001:470:1f07:15ff::f7]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53463a68-0853-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 19:42:29 +0200 (CEST) Received: from m5p.com (mailhost.m5p.com [IPv6:2001:470:1f07:15ff:0:0:0:f7]) by mailhost.m5p.com (8.16.1/8.15.2) with ESMTPS id 26KHgBON036587 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 20 Jul 2022 13:42:17 -0400 (EDT) (envelope-from ehem@m5p.com) Received: (from ehem@localhost) by m5p.com (8.16.1/8.15.2/Submit) id 26KHgBKA036586; Wed, 20 Jul 2022 10:42:11 -0700 (PDT) (envelope-from ehem) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53463a68-0853-11ed-bd2d-47488cf2e6aa Date: Wed, 20 Jul 2022 10:42:11 -0700 From: Elliott Mitchell To: Anthony PERARD Cc: Mathieu Tarral , Xen-users , George Dunlap , George Dunlap , Juergen Gross , xen-devel@lists.xenproject.org Subject: Re: xen master: xl create hangs Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.0 required=10.0 tests=KHOP_HELO_FCRDNS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on mattapan.m5p.com On Wed, Jul 20, 2022 at 05:24:22PM +0100, Anthony PERARD wrote: > > I think that this `xl` process just wait for the domain to shutdown > or die. When we run `xl create`, before exiting there's a fork/exec of > xl which handle a few domain events, so it looks like this stack trace > is expected (and look like the one I have). So it don't looks like to be > the xl process that hangs. I've got a patch to make use of `setproctitle()` to modify what shows as the process name for this process. Unfortunately `setproctitle()` is *BSD-only, "libbsd" for Linux implements similar functionality and I've been meaning to figure out how it works. I definitely think this should be done, just haven't gotten around to finding a proper way to do it. -- (\___(\___(\______ --=> 8-) EHM <=-- ______/)___/)___/) \BS ( | ehem+sigmsg@m5p.com PGP 87145445 | ) / \_CS\ | _____ -O #include O- _____ | / _/ 8A19\___\_|_/58D2 7E3D DDF4 7BA6 <-PGP-> 41D1 B375 37D0 8714\_|_/___/5445 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:20:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:20:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372118.603921 (Exim 4.92) (envelope-from ) id 1oEEIm-0005xM-9Q; Wed, 20 Jul 2022 18:20:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372118.603921; Wed, 20 Jul 2022 18:20:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEIm-0005wg-5m; Wed, 20 Jul 2022 18:20:04 +0000 Received: by outflank-mailman (input) for mailman id 372118; Wed, 20 Jul 2022 18:20:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEIk-0005iQ-NB for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:20:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEIk-0006eP-A2; Wed, 20 Jul 2022 18:20:02 +0000 Received: from [54.239.6.185] (helo=[192.168.0.130]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEIk-0001aj-3m; Wed, 20 Jul 2022 18:20:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=wX6Nsyee0y16F8ALHiab3Hdw62yglC7YJ6wiz8g1Us4=; b=38PucLFDTi+dt9BByNb3btzJlF CPzmPz7SICTWbbOkg0HuCY1hz99R16wxJOvZh2Mf5uGkHtB6X2YirUmJ1t96Kx2iIYQ2a7DBtR3b8 2rR9RqSBVq3Dcyd/8D7SzvxwUVh1xjEIVVB3CYhN2wxUR8z66BnbXzQUlfJO56ybQkXg=; Message-ID: <43793378-6539-1795-8262-189f7ff61d66@xen.org> Date: Wed, 20 Jul 2022 19:20:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 1/2] xen/arm: Harden the P2M code in p2m_remove_mapping() To: Oleksandr Tyshchenko , "xen-devel@lists.xenproject.org" Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Oleksandr Tyshchenko References: <20220716145658.4175730-1-olekstysh@gmail.com> <7960855a-5135-00d9-fff8-b571d7be03d1@epam.com> From: Julien Grall In-Reply-To: <7960855a-5135-00d9-fff8-b571d7be03d1@epam.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleksandr, On 16/07/2022 16:29, Oleksandr Tyshchenko wrote: >> On 16/07/2022 15:56, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Tyshchenko >>> >>> Borrow the x86's check from p2m_remove_page() which was added >>> by the following commit: c65ea16dbcafbe4fe21693b18f8c2a3c5d14600e >>> "x86/p2m: don't assert that the passed in MFN matches for a remove" >>> and adjust it to the Arm code base. >>> >>> Basically, this check will be strictly needed for the xenheap pages >>> after applying a subsequent commit which will introduce xenheap based >>> M2P approach on Arm. But, it will be a good opportunity to harden >>> the P2M code for *every* RAM pages since it is possible to remove >>> any GFN - MFN mapping currently on Arm (even with the wrong helpers). >>> >>> Suggested-by: Julien Grall >>> Signed-off-by: Oleksandr Tyshchenko >>> --- >>> You can find the corresponding discussion at: >>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/82d8bfe0-cb46-d303-6a60-2324dd76a1f7@xen.org/__;!!GF_29dbcQIUBPA!3a2u-XL4NvAzSMfz72LARrdWVFvq2In5ZpUdxP2cSt7bM8PgV7P_ZclZG2R-rE9PcosUHyqsKRNfVG2TiM9Tlg$ >>> [lore[.]kernel[.]org] >>> https://urldefense.com/v3/__https://lore.kernel.org/xen-devel/1652294845-13980-2-git-send-email-olekstysh@gmail.com/__;!!GF_29dbcQIUBPA!3a2u-XL4NvAzSMfz72LARrdWVFvq2In5ZpUdxP2cSt7bM8PgV7P_ZclZG2R-rE9PcosUHyqsKRNfVG0kg7IZSA$ >>> [lore[.]kernel[.]org] >>> >>> Changes V6 -> V7: >>>     - make this commit to be the first >>>     - update commit description and add a comment in code >>> --- >>>   xen/arch/arm/p2m.c | 28 ++++++++++++++++++++++++++++ >>>   1 file changed, 28 insertions(+) >>> >>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c >>> index d00c2e462a..2a0d383df4 100644 >>> --- a/xen/arch/arm/p2m.c >>> +++ b/xen/arch/arm/p2m.c >>> @@ -1308,11 +1308,39 @@ static inline int p2m_remove_mapping(struct >>> domain *d, >>>                                        mfn_t mfn) >>>   { >>>       struct p2m_domain *p2m = p2m_get_hostp2m(d); >>> +    unsigned long i; >>>       int rc; >>>         p2m_write_lock(p2m); >>> +    /* >>> +     * Before removing the GFN - MFN mapping for any RAM pages make >>> sure >>> +     * that there is no difference between what is already mapped >>> and what >>> +     * is requested to be unmapped. >>> +     * If they don't match bail out early. For instance, this could >>> happen >>> +     * if two CPUs are requesting to unmap the same P2M concurrently. >> >> Missing word: P2M *entry* > > Yes. May I please ask, could this be done on the commit if this appears > to be the last version? I have committed the series with the same typo. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:27:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:27:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372126.603939 (Exim 4.92) (envelope-from ) id 1oEEPi-0007Fv-6R; Wed, 20 Jul 2022 18:27:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372126.603939; Wed, 20 Jul 2022 18:27:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEPi-0007Fo-3t; Wed, 20 Jul 2022 18:27:14 +0000 Received: by outflank-mailman (input) for mailman id 372126; Wed, 20 Jul 2022 18:27:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEPh-0007Fi-C7 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:27:13 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEPd-0006n5-Kh; Wed, 20 Jul 2022 18:27:09 +0000 Received: from [54.239.6.185] (helo=[192.168.0.130]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEPd-0001w4-Bu; Wed, 20 Jul 2022 18:27:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=lukKjgnuc7y0+9OBOaI2LWBRC0HjHZ+rW3x2gC55vKQ=; b=6UXGz+6lnU39C2ju7kQoAhnKrc 7G2+jvWrPY/po8Yu4++rAUPxwE6DMLt3pxpjtEChLZj5vd3+IY1u5TB+3TRqtKoBA2IhPnaqKGLHN RdFw03TdVK/+4dA2sVqtKr/6LlXTFSomnOjVDicv2aGetla3USNijkCB8WkYXxtCt5M4=; Message-ID: Date: Wed, 20 Jul 2022 19:27:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/3] xen/heap: pass order to free_heap_pages() in heap init To: Jan Beulich Cc: Hongyan Xia , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <20220715170312.13931-1-julien@xen.org> <20220715170312.13931-4-julien@xen.org> <0242a659-fcf9-74cc-102c-df775123b7ac@suse.com> <097e8634-0c5b-35ac-6ad6-5b83d9b29f64@suse.com> <4904ae1b-19ef-533c-fc2f-baec570bfcca@suse.com> From: Julien Grall In-Reply-To: <4904ae1b-19ef-533c-fc2f-baec570bfcca@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 19/07/2022 07:01, Jan Beulich wrote: > On 18.07.2022 19:39, Julien Grall wrote: >> On 18/07/2022 12:02, Jan Beulich wrote: >>> On 18.07.2022 12:24, Julien Grall wrote: >>> 3) >>> unsigned int inc_order = min(MAX_ORDER, flsl(e - s) - 1); >>> >>> if ( s ) >>> inc_order = min(inc_order, ffsl(s) - 1U); >> >> I like this idea! >> >>> >>> No compilation issues to expect here, afaict. >> >> Correct, GCC is happy with this approach. Assuming there are no other >> comments, are you happy if I make the change on commit? > > Sure - iirc I gave my R-b already. You did. Just wanted to make sure your reviewed-by was valid with your proposal. I have now committed the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:31:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:31:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372132.603951 (Exim 4.92) (envelope-from ) id 1oEETr-0000L4-N0; Wed, 20 Jul 2022 18:31:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372132.603951; Wed, 20 Jul 2022 18:31:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEETr-0000Kx-KO; Wed, 20 Jul 2022 18:31:31 +0000 Received: by outflank-mailman (input) for mailman id 372132; Wed, 20 Jul 2022 18:31:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEETq-0000Kr-9b for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:31:30 +0000 Received: from GBR01-LO2-obe.outbound.protection.outlook.com (mail-lo2gbr01on2104.outbound.protection.outlook.com [40.107.10.104]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2aae1e92-085a-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 20:31:28 +0200 (CEST) Received: from LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:1d1::5) by LO2P265MB4230.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:1d7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Wed, 20 Jul 2022 18:31:26 +0000 Received: from LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM ([fe80::790c:999c:1a40:26f7]) by LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM ([fe80::790c:999c:1a40:26f7%6]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 18:31:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2aae1e92-085a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BpAQMN6Tf2HZL2asT3r37z2FwobxMWrmsb+OZ8fVlLrhxuq5hMkZbFZHaMJjMvT+hNS/A5Be6qynYb/U3WVyll59M5vSwYuAXkjJYA6aQVwpI9i4VHUXTFifORGGn8F3tO6rDKzlnTCK8orDEHT5qcjqwTAEEEnf38xswZDow9zWSxqVULpcWdg2rWVDseKKMEwujgMTcN4C7O+QCszPOUP3yRKOye2jy+R5pPMf5N/N16UahjTEUmBTDfxs0gbWKW6mFyOiXPzeO4vSGXgs5rfqIrN7NS6SkVJPJOplrzWav6VBnALOZKTc6veJOrg79H0Xneu6o0UgpwsWx5mSXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CXziTKEQNyfuo+3a5A8UlFLtBUbdAxQXAyeo/n97MoE=; b=hiYc/GdaE9EL6VhzO3L1ItB/+S3q03yCwyIDL9YWrehQBeSpzv2XaDKpLRClTXcxFr/aBIywoNlXJff6C5Z6qqKlOCHvyIJ3Cjmzag7M31j5nhAGh6AWZJ7L3QU04hTqLT1h3MRRCSA5ovVbJ81F02rAiAod2SSGKzzFUflQZFe4pGOFKL6WFssNihqLHtXQpbDk+usIQHrnQInnRyg5JCTPpneC+t69Nvt0ByKe0xjDFG4Ce5mmglssmHpQHTmtXcT02E9kp4yENaoYEecywgYbkiBTepnv5gyDWLsCuY8EUzJaXn1OVAT7DdYXnSIY2ffx0u25XtIv1JvfPYeKGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=durhamuniversity.onmicrosoft.com; s=selector2-durhamuniversity-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CXziTKEQNyfuo+3a5A8UlFLtBUbdAxQXAyeo/n97MoE=; b=ctA5ByEFewkxV3bpGEcewMl7a2BZr5b99l9bkG8w9I74xJrlghacjowzAIACLG3EFP4z0QEbIXqzgzq2w20eH0Z6+aavGf74GPNJIhz3nfjkNr2vPqDVNMgjhGXRKScUiRQaLgF4g+P7+RoFOjEafRUzrIzNMdOvD7ow167YEzU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=durham.ac.uk; Date: Wed, 20 Jul 2022 19:31:25 +0100 (BST) From: Michael Young To: Jan Beulich cc: ChrisD , Andrew Cooper , "xen-devel@lists.xenproject.org" Subject: Re: Panic on CPU 0: FATAL TRAP: vec 7, #NM[0000] In-Reply-To: <1b6bed07-a500-4683-3b0a-0c82dde1c1cd@suse.com> Message-ID: <54bb75ff-9f28-8d4a-3faf-53978cf3f5c@austen5.home> References: <202207200448.26K4muXc067471@mail116c40.carrierzone.com> <1b6bed07-a500-4683-3b0a-0c82dde1c1cd@suse.com> Content-Type: text/plain; charset=US-ASCII; format=flowed X-ClientProxiedBy: LO2P265CA0206.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9e::26) To LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:1d1::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 56d1e207-9641-4dc8-06d0-08da6a7e0e2a X-MS-TrafficTypeDiagnostic: LO2P265MB4230:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AaPXZ1dyc4TgWalAaUIEx4mvA7xrGE/IelutoY+l48+vY39K6mVHlERiNGRb6GXensaKjGhXLbi8NITQ0B3gCn75DdA4ziWw/4tdeS6SKjGcwl+yw+RUFfh29p/6CdH6R4+RdKykdLJew34V81G3pBkNvk0Ngu4KYli2SkW29lIWEPV12wixkf7e1M4mubo8E32uUwpmS2Xxl8BIj9WjURRvJ/d/ksvDtkiERsbR+yVC3RW2cbUw6/yo5hcQL3XcFVPRyYcmwVwDa9ItsPLmjnS2yOlcIi7rdVOkP/vRzLjCDZy7ZoyGENT/dELJsDMt51RXysPuzza3IUbxpez+ZEYZvLeZ8v1YVrMKMg5yC+XDO34zfd2FdN5F5XTyYDkTe+6nJOsydhT8tN/92LFrfqDlKuSt92O5TTZ7w6v4rAbrUpXOPtIbv3P9WYupgemBS02g/mNqwod6k+kpP1aPohnXhdmU8QPzfEMxFWnP4GiEVqAH9XXFSh8lGUbjhvDWobAnwB2AcXO3Y6wkDNMqiZQgXAiGmDN9NbSV301fnRMo5AvxduK69tzhQjlOciFbGU1iVX5/zzzVnJSRo7FisrU68R1MnQsRJ+j7EcdDyaN1i/DelF8Am+wvklEZYCTCbMtkiRUQ4Hc6H8QQr/Gcy+Di5yVsIIkd6UNHF5gCo15EEHrjAT23Ug0iKZUXe63THo1/w6E9VPt48IMiSoIhXHBbm7Sih0Uf78H2HVmk55oMeMr+IXyN/sjBtH1Kkyf6i2SLlrMsmApfEaSjf5xMmMxElf0tWe7IgGdNjEadyIucWWYOvAM4KOY36oTlSd6aXWzl7jxqFihgDsFjwYoDqA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(366004)(346002)(39860400002)(5660300002)(2906002)(8676002)(4744005)(6512007)(966005)(4326008)(186003)(41300700001)(478600001)(8936002)(66946007)(6506007)(6486002)(66476007)(86362001)(53546011)(9686003)(66556008)(786003)(41320700001)(316002)(36756003)(6916009)(54906003)(38100700002)(58440200007);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gqPXV2JTu6vQDFZUUBhL7PXFg0n3a0/72wbNgWJIRB/2JYPGHMIpkAeZQtg6?= =?us-ascii?Q?rblSvZVNh5k3H3/ew4GgxgHyLh4sZW/rZr7iqE5Kw40PY+7YZ5XAKLmolS5W?= =?us-ascii?Q?Tiq8e/BCzachhUJuT7FZKjxYpMzS1f6/8Ms0yv135/PFEnTPvyOkQH+xncZM?= =?us-ascii?Q?O2l5xiM2NCXIksFaFT7y5U9KEgJ/UeouXQkLL1yTBfk9lK2Qap0k/yzdpPq7?= =?us-ascii?Q?4bfcaq1/ru6oH1kVAiGZpSIabyqWyAiBI/cnKLSLGxg2cuB/rsksjCWk0Dnc?= =?us-ascii?Q?ObA7SvC2gGqHA19MUUJg9OaAwQI/+iYSFandgQ5yurGIPC7NEMiCktmCdNd3?= =?us-ascii?Q?bMqHkwGBrxCGedYoGkWwKUEUeUROnOBWjkV5IzJ+3szU7zZtNQnVCl4BZCjN?= =?us-ascii?Q?t//y1dSZ4M/69IWTxCvnPce25azIXXkMmNPwVtF7/ezvnaQhLnj0tyVGSxFE?= =?us-ascii?Q?yKA5SctE67zR7xKepXTMimpbvKgoKX0BM9vAiS6m7bcQFOwMrkSjlzWubqL3?= =?us-ascii?Q?H610Bun5kagzDSxSLs0YV06V8QyDP6QRbsGU7x7vpZB5HSU6zrz+FMOtFfSK?= =?us-ascii?Q?rPf83X01tDARHRybQdJVtTINUlrhV22G+meeOtg6BDHo+QirWzkX7JRx0p7I?= =?us-ascii?Q?NWS5K6mM9h1CLyKPUnIRyMYSRpMpZPbQq2i1ZkGBci+TVEtTwO/kdDA3WmTa?= =?us-ascii?Q?G4wwO/eI8FzKLv4+SW8cQMkJA/S6+A8q+20OZefXL+KhJPVcNsMMuReu2SyK?= =?us-ascii?Q?Ju53mKrk4MfhTmT5MIAC2KQvQPm3+JA7oHJxcSYcRGqObdHvybpJhmR6lT7w?= =?us-ascii?Q?VOkahaaPPF1chOCK1UAeuj0w3yguYs7dd9iGTRgHncMaDy6d22ydJRxT1oL/?= =?us-ascii?Q?11xrW6++uX0uycsw1ZPCLgMBAyjwvwvEDiT8AMG+oGmNZyMiyysknpw1Tic6?= =?us-ascii?Q?DLjJpJ82KxdB677M7ulRDgnAxooGvJKtKjdk3UnuctBa5bVU0cvYt9jeFwdE?= =?us-ascii?Q?TpCtHNYyi/3xRcs6vffz23CI1flIjT/fy8shC3vwDfNg5HzqmBZdhiWtq3/H?= =?us-ascii?Q?FPW+Ztgv1RLE7qFvNamWb13a6uwyX3M+JrxZ8vXHoXJn6AVfDU2CNeK322MX?= =?us-ascii?Q?Jf4sR1d2LAz6Of9WJhH0UApUghya6zJxVX/XLi5ocTXg2mdTJWVc0wi5TL91?= =?us-ascii?Q?XaVFzxNg+ZIBLSNlgzTRUHe0BXC5jqH167L/5BFXIpdj0rogBARhk7wLuq3D?= =?us-ascii?Q?M+PnetZmyYb+cydqcm1EkS6EeJxIdttp69nzTRKNww4OVWmMGz+q4Zryri4C?= =?us-ascii?Q?a30i0sJRPnwModh2B5YRFnXQ84GfBSYefsk9avHMTM1YE6QMKntz22LF7Om7?= =?us-ascii?Q?cadmuoHJvCtoRHQOCN2YciKs5eu9vXQAZ9JW6GmIcPge+iQeeksCy5cEkO/Y?= =?us-ascii?Q?LjEOkfTIK/lY9ubOy4Va9BI3/7ie/ci1HnQ8hkoUnxZCsycF/1oXvH6usFaj?= =?us-ascii?Q?LNWAZsefaeu2mIPTBZ2MqNH/Vdqtsz5TDOXj5sH0rhSkuMCJ6IKgU6A8sb/X?= =?us-ascii?Q?3v5IcJ/BXXcCDZb/UHXJB/yDiZLbtljeKEauUM4of26nfqYD+Ax8qNq7gm7o?= =?us-ascii?Q?DJfBci8emfqg0L8cMJBVmnXFV4mGr9kwW8XNOEinqm71?= X-OriginatorOrg: durham.ac.uk X-MS-Exchange-CrossTenant-Network-Message-Id: 56d1e207-9641-4dc8-06d0-08da6a7e0e2a X-MS-Exchange-CrossTenant-AuthSource: LO4P265MB3790.GBRP265.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2022 18:31:26.3498 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 7250d88b-4b68-4529-be44-d59a2d8a6f94 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VA1DVvRw16NAvbvZRGXc9vr6079BOt/QAug19zdr7orxP4Wi3Nb3Lx9sMkWwQBzGvWwYUUP7yMXu+glDB91iGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO2P265MB4230 On Wed, 20 Jul 2022, Jan Beulich wrote: > On 20.07.2022 06:48, ChrisD wrote: >> So, you think it's a problem with fc36? > > Just to also state it here - it turns out we need to tell the compiler > to avoid MMX insns. A patch for this was already sent and ack-ed. I have done a temporary build of xen for F36 at http://koji.fedoraproject.org/koji/taskinfo?taskID=89746549 which has the proposed patch applied if anyone wants to test it. Michael Young From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:33:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:33:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372136.603962 (Exim 4.92) (envelope-from ) id 1oEEVG-0000ts-2E; Wed, 20 Jul 2022 18:32:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372136.603962; Wed, 20 Jul 2022 18:32:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEVF-0000th-Uw; Wed, 20 Jul 2022 18:32:57 +0000 Received: by outflank-mailman (input) for mailman id 372136; Wed, 20 Jul 2022 18:32:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEVE-0000tU-8g for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:32:56 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5d768b61-085a-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 20:32:54 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658341968525237.44157802434802; Wed, 20 Jul 2022 11:32:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5d768b61-085a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1658341970; cv=none; d=zohomail.com; s=zohoarc; b=i3MSXvWGVFTj4Eu+UH9XowosJq51w/O/mFuuh7DV1IPL6dXT0ZYvo5t3E0vJotjB/l2TeFvPM6wAaD/6xaaXJ2Fau/LfE59r3TexA8rCXjS9faYY+6ZJrtnH9Nkt7NG5lV6x0mPkRZaoIB5wsFikgGi5E5mBVeorKVCiT8VsC3c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658341970; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=/co16vRAwNgC5Z2jziSVb8l7V52dXhdT0PZ8F1tU+Fo=; b=iM0rTlbn8QCJ2IjaVtZpNqgud4grhmDMFfikaza2IVN+zbV6R1jnZrz4UXHEiOpmI5ckcrxWV2mMvq3tTEDs3niTL0UHxg8o+bUPJyll7cvDDPe7HDNHD7ByaQxU5zuVqIou5ORQIwaKvatyxvsyLTY2Bilty92VVPuc75SrZ80= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658341970; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=/co16vRAwNgC5Z2jziSVb8l7V52dXhdT0PZ8F1tU+Fo=; b=YloKpdYmNEW44Dg61L2dRfzQ7ROTCgsZXnkOv9rNzyN1JoYl7ep1wDkk0pgp0aOf gLd+/eSs6gTHzkBbsL74VtLKzr9GNi8WBjt0DdRfd2faqPaIP0XRBU8aHNZevyqNLYb yQ7W3tWFfSgPrT6oFPtVj2gci+Hi2vFkkfxo6MVE= Message-ID: Date: Wed, 20 Jul 2022 14:32:26 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org, Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Stefano Stabellini References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 02/18] introduction of generalized boot info In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External On 7/15/22 15:25, Julien Grall wrote: > Hi Daniel, > > On 06/07/2022 22:04, Daniel P. Smith wrote: >> The x86 and Arm architectures represent in memory the general boot >> information >> and boot modules differently despite having commonality. The x86 >> representations are bound to the multiboot v1 structures while the Arm >> representations are a slightly generalized meta-data container for the >> boot >> material. The multiboot structure does not lend itself well to being >> expanded >> to accommodate additional metadata, both general and boot module >> specific. The >> Arm structures are not bound to an external specification and thus are >> able to >> be expanded for solutions such as dom0less. >> >> This commit introduces a set of structures patterned off the Arm >> structures to >> represent the boot information in a manner that captures common data. The >> structures provide an arch field to allow arch specific expansions to the >> structures. The intended goal of these new common structures is to enable >> commonality between the different architectures.  Specifically to enable >> dom0less and hyperlaunch to have a common representation of boot-time >> constructed domains. >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Christopher Clark >> --- >>   xen/arch/x86/include/asm/bootinfo.h | 48 +++++++++++++++++++++++++ >>   xen/include/xen/bootinfo.h          | 54 +++++++++++++++++++++++++++++ >>   2 files changed, 102 insertions(+) >>   create mode 100644 xen/arch/x86/include/asm/bootinfo.h >>   create mode 100644 xen/include/xen/bootinfo.h >> >> diff --git a/xen/arch/x86/include/asm/bootinfo.h >> b/xen/arch/x86/include/asm/bootinfo.h >> new file mode 100644 >> index 0000000000..b0754a3ed0 >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/bootinfo.h >> @@ -0,0 +1,48 @@ >> +#ifndef __ARCH_X86_BOOTINFO_H__ >> +#define __ARCH_X86_BOOTINFO_H__ >> + >> +/* unused for x86 */ >> +struct arch_bootstring { }; >> + >> +struct __packed arch_bootmodule { >> +#define BOOTMOD_FLAG_X86_RELOCATED      1U << 0 >> +    uint32_t flags; >> +    uint32_t headroom; >> +}; >> + >> +struct __packed arch_boot_info { >> +    uint32_t flags; >> +#define BOOTINFO_FLAG_X86_MEMLIMITS      1U << 0 >> +#define BOOTINFO_FLAG_X86_BOOTDEV        1U << 1 >> +#define BOOTINFO_FLAG_X86_CMDLINE        1U << 2 >> +#define BOOTINFO_FLAG_X86_MODULES        1U << 3 >> +#define BOOTINFO_FLAG_X86_AOUT_SYMS      1U << 4 >> +#define BOOTINFO_FLAG_X86_ELF_SYMS       1U << 5 >> +#define BOOTINFO_FLAG_X86_MEMMAP         1U << 6 >> +#define BOOTINFO_FLAG_X86_DRIVES         1U << 7 >> +#define BOOTINFO_FLAG_X86_BIOSCONFIG     1U << 8 >> +#define BOOTINFO_FLAG_X86_LOADERNAME     1U << 9 >> +#define BOOTINFO_FLAG_X86_APM            1U << 10 >> + >> +    bool xen_guest; >> + >> +    char *boot_loader_name; >> +    char *kextra; >> + >> +    uint32_t mem_lower; >> +    uint32_t mem_upper; >> + >> +    uint32_t mmap_length; >> +    paddr_t mmap_addr; >> +}; >> + >> +struct __packed mb_memmap { >> +    uint32_t size; >> +    uint32_t base_addr_low; >> +    uint32_t base_addr_high; >> +    uint32_t length_low; >> +    uint32_t length_high; >> +    uint32_t type; >> +}; >> + >> +#endif > > NIT: Missing emacs magics. As a devoted vim user, begrudged ack. ( ^_^) >> diff --git a/xen/include/xen/bootinfo.h b/xen/include/xen/bootinfo.h >> new file mode 100644 >> index 0000000000..42b53a3ca6 >> --- /dev/null >> +++ b/xen/include/xen/bootinfo.h >> @@ -0,0 +1,54 @@ >> +#ifndef __XEN_BOOTINFO_H__ >> +#define __XEN_BOOTINFO_H__ >> + >> +#include >> +#include >> + >> +#include >> + >> +typedef enum { >> +    BOOTMOD_UNKNOWN, >> +    BOOTMOD_XEN, >> +    BOOTMOD_FDT, >> +    BOOTMOD_KERNEL, >> +    BOOTMOD_RAMDISK, >> +    BOOTMOD_XSM, >> +    BOOTMOD_UCODE, >> +    BOOTMOD_GUEST_DTB, >> +}  bootmodule_kind; >> + >> +typedef enum { >> +    BOOTSTR_EMPTY, >> +    BOOTSTR_STRING, >> +    BOOTSTR_CMDLINE, >> +} bootstring_kind; >> + >> +#define BOOTMOD_MAX_STRING 1024 >> +struct __packed boot_string { > > As you use __packed, the fields... > >> +    bootstring_kind kind; >> +    struct arch_bootstring *arch; > > ... may not be naturally aligned anymore. Here it will depend on the > size of bootstring_kind (this is an enum and it don't think C guarantees > the size). This... Ack. >> + >> +    char bytes[BOOTMOD_MAX_STRING]; >> +    size_t len; >> +}; >> + >> +struct __packed boot_module { >> +    bootmodule_kind kind; >> +    paddr_t start; >> +    mfn_t mfn; >> +    size_t size; >> + >> +    struct arch_bootmodule *arch; >> +    struct boot_string string; >> +}; >> + >> +struct __packed boot_info { >> +    char *cmdline; >> + >> +    uint32_t nr_mods; >> +    struct boot_module *mods; > > ... more obvious on this one because on 64-bit arch, there will be no > 32-bit padding. So 'mods' will be 32-bit aligned even if the value 64-bit. > > This is going to be a problem on any architecture that forbid unaligned > access (or let the software decide). > > In this case, I don't think any structures you defined warrant to be > __packed. Ack, I was too focused on 32bit alignment for x86 bootstrap entry point when I was laying out the structure, that was short-sighted on my part. I will go back and rework to be 64bit aligned. >> + >> +    struct arch_boot_info *arch; >> +}; >> + >> +#endif > > > NIT: Missing emacs magics. Ack. From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:44:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:44:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372147.603984 (Exim 4.92) (envelope-from ) id 1oEEfx-0002qw-Aq; Wed, 20 Jul 2022 18:44:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372147.603984; Wed, 20 Jul 2022 18:44:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEfx-0002qp-87; Wed, 20 Jul 2022 18:44:01 +0000 Received: by outflank-mailman (input) for mailman id 372147; Wed, 20 Jul 2022 18:44:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEfw-0002qj-31 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:44:00 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id e95a0f26-085b-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 20:43:58 +0200 (CEST) Received: from pps.filterd (m0174678.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26KGrH79003649; Wed, 20 Jul 2022 18:43:46 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2112.outbound.protection.outlook.com [104.47.18.112]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hekbv8ubd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 20 Jul 2022 18:43:46 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com (2603:10a6:803:31::18) by PR2PR03MB5147.eurprd03.prod.outlook.com (2603:10a6:101:23::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Wed, 20 Jul 2022 18:43:41 +0000 Received: from VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488]) by VI1PR03MB3710.eurprd03.prod.outlook.com ([fe80::3db3:dad:7bd7:4488%7]) with mapi id 15.20.5417.035; Wed, 20 Jul 2022 18:43:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e95a0f26-085b-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ErM32AbG+hCWIw+QnpU1c142uOuXjTkbIhaipYZWw9o7Cx0NHEC6FJlMK1A7c5959mayFHv07bPWG3/MdhgsJXF2xtTpwCyhWfZEPCHmV2TOD9yXgOALeRGUoGz0TIa34iLv6H1SWovmGtUpDm6b702RRakiNwCON0Vt3XYkjYevtPKwp9+ydjSsgKhalgbKRxM0DFgPTPDnvFSYVZBZqlWgHEm8R+Q4570StvUmToDLvWfM4GGkVQUkwzhptbN3FP9nk3YmGLIpkGa8A2tXvLUNLF53FAVraeyNtxMEvFaZQC0bORM7kU0PAKo00yTDjRtXajw0m1bciZrWUTlkBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eZdKd5ovZyiwO036SsIMsoGHufaPZnO4eryczz+BMfI=; b=deKkMGrYbxHumPIbciS9bQWuYHvI0N4eG5U9QJLKo9HlVUujgHKwmOPMV0BOWBTGTUn6zAduc8vs7IqIaTAma7+5H3ydtYneM4BKj2dOYJFKL3naY5W9r/v2VGKGsmH9JitfAmNKOmD49SIobjZLGHFw4NwIAA9mzAzHlSga7r1r6b3yfsfK3iwOfvc3vXVJUgRkeCf0N6nEp6uyj7UN6LfqjYe1XlMv9BYt+/Hqpzt/bJQKJsjQT8lZQ7ciRutLnFy+RW32MFj6sBpc8pS890RZmVciU8U23tjqOL1gnhTThggzhXJ2JJtVG5/JRrR5KkRii2RjUQatwFqfs1qvhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eZdKd5ovZyiwO036SsIMsoGHufaPZnO4eryczz+BMfI=; b=JsZL8ltX5uZ+91QE9GzXFFkqE2l4cFhfSeIzBVUO98gO2i1u9iGnkSXvKW5LPX84foHW0yht7Z+26DXVFeyQ9BwtIhVTfmQXv6yUj7zd8DUNjl8kiFRO6l59SWr0wuyCat5+T/8UDa7uCmEyFmgBD8n0Fe1X+6auGTCSl563Pc2FtEV9HmsUEiUsCvrasdBABcBGlOBBhKyYzi3TvQrlQsMktjkkMw6dGtZbOYiULnQMFPAGPs/crVbJM6gfWSC8qagHmuWdvWe2sEag6bZAegTFHXPBgkVi46b1nEp7HLnvixcMZSYyIYb2tJSYVZpiwTxaZIg5FCNFaiKO2tCk+g== From: Volodymyr Babchuk To: Wei Chen CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Wei Liu , George Dunlap , Julien Grall , Stefano Stabellini , Paul Durrant Subject: Re: [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Thread-Topic: [PATCH v2 1/4] pci: add rwlock to pcidevs_lock machinery Thread-Index: AQHYmuuJlTOCfCU2VEeylMdGd6xTk62FOW4AgAJgrAA= Date: Wed, 20 Jul 2022 18:43:41 +0000 Message-ID: <87bktjhbfo.fsf@epam.com> References: <20220718211521.664729-1-volodymyr_babchuk@epam.com> <20220718211521.664729-2-volodymyr_babchuk@epam.com> <0f8da611-0825-91ca-b1eb-dfbe0fb709f1@arm.com> In-Reply-To: <0f8da611-0825-91ca-b1eb-dfbe0fb709f1@arm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: mu4e 1.6.5; emacs 28.1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b427399-cd89-4523-ec2a-08da6a7fc437 x-ms-traffictypediagnostic: PR2PR03MB5147:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cDofurihTfjixs2mj3z/AA6zQFZfRbCl8j9M1N/GNb018Ni+IJ1ck468LwW0XSNxQW+UwtNqnVJILC6Y5/lVX20YcWpP6ZtWds75sPvu9RVXC4Tom6cHTA7SXJJ0EHGwuOO9ZjOjdCY13ckPmZmPdwNe5JEPDaoGkXesrO/4rcQQBtHxw+FUBslNr9QS89I17zCQKfmG6rUxnFO5mKZhiCD12OPnV9NZtD0bhoBJv4W56kFYbn0HwC3YLASipEW+E9NYapFbbKTjjEsuDnPzrKCSGT7VF7BSb+LpCd2LmNVWttxZVBAeJ3SS/CWkG/lAQCHa6Zoe91IOI59FyoElwdMtG6yKBT4SwfWfenuuc8dQ7aAZl48RWwsqn7/mZdNgbk+iyxlUddfHFxn8DNiFm+bkJ1FApcMk2G/CRL0EI+nRfln23MjN50J6xUbi0MmH9aGH7A7okFDHSc6R835/xV9z9XiiB2past3RHhg3jJfEqA8yPxTEFeFa8HUa252GRhUD4C6TVByKUb6yDNAJWzIxKEFS6pMOuFgteFwO8IVwQCRzATC0S13jMG96h7HX8cv/3f3t9itoZ4+eeAihrquZmjDbFfyFKydnCzvDBHaGx9DXePWc01GX4QF3GiyJFrXOyZ9gRmCcBlpVI6oAFyA9dZKUjqToJpgcnmQ2MK8qAib6PHxUjRMeTFXXMe+eyvSmGizLBvv/qAdqs9iZ/jq1XmTPjrGkzwCFyv1X/49af6WHZKtgHdspW/+wF7X+/p9gcPxQHA3DYZdcPWaJbnOZxYkuTvRKSNqGHGgtdRlQH8oB6SB5JHjYfnHGNXcmxrs+7kixXhoYxxGt+UpQyA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR03MB3710.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(396003)(39860400002)(346002)(376002)(36756003)(66556008)(122000001)(6916009)(86362001)(91956017)(66946007)(38100700002)(76116006)(66476007)(66446008)(64756008)(8676002)(54906003)(38070700005)(316002)(71200400001)(4326008)(8936002)(41300700001)(2906002)(2616005)(6512007)(55236004)(186003)(478600001)(26005)(7416002)(5660300002)(53546011)(6486002)(6506007)(83380400001)(309714004);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?KsqQrdxqQiheN+dQb8lzX2vkGWMymty3cPThP4oqU1tsew3rcntXug3dHl?= =?iso-8859-1?Q?vJAXGHB57D3Ydmm8RjPpoVwTh24XBefbQoxAc7CrnfkDCt5LT22/BZBSME?= =?iso-8859-1?Q?ObekOwWW3mWEKm8WtKI3dUAeO4u92wVP+cLYQlFxL1P1K02mFPeoBzalYf?= =?iso-8859-1?Q?lISLnnd9u5/nh6IPqih4/dedP4KoJN6aIIK2wXgJGaByCIK9B23V4L9GbF?= =?iso-8859-1?Q?YTVfdvhJD+kzt3OrMPrOjC1KOFgjYIPEduQ5zUvdWI9n+7m5XFUwaAXDl+?= =?iso-8859-1?Q?4tm5qymW7bEEIIX8Kh5rQDmseLNNKEUrcPkJAa2Nq46eEM2O6k0TAzws7D?= =?iso-8859-1?Q?LTtKepZD27M4BknbwnWnWyW6Nq0lx2xUErQ6t8WP8I5brLjqplGCX43lXD?= =?iso-8859-1?Q?8tHmGSuKTiX0UAKg2or/6+e57jES2EoQYCgw+PGOHiJ3rNWUz+E2Ltc3ND?= =?iso-8859-1?Q?hlDpiyuyCEA4sBKYIAjBDAK8HjBLdUzyEp67C5JsPHtAPL1AkcBnyY0icv?= =?iso-8859-1?Q?E21UV81ePF3ex4diLk6rjcVHJvO+Sfasoy+PpHNvriIZlov06UnX7l6WER?= =?iso-8859-1?Q?MgL6olqdGxkxNXCeVPRBKyvWtZ+x7uMONkuHQShzWswqIFR6m3Cyti4m74?= =?iso-8859-1?Q?LlN9doluXr0idPui1Yl1+dWTvZG6mECkGXq8xXGN89UBA7RRITlK4s5u5z?= =?iso-8859-1?Q?3KKqkh9un/EHqKdeABIsEumq1+G17spv/VntUc2xKqTBHJUJR3xQohkR6d?= =?iso-8859-1?Q?iqVj6AJvHO4KLfLW0f25cwOAGnPnsHNAc+jLHoIMDizQ0Zhvc4Js/Sv0jm?= =?iso-8859-1?Q?pQ5VSnk1emSotZzGzomyJh2ZrctUDmsxsAjbntaSxBSAyf/IIQZ24RUdNi?= =?iso-8859-1?Q?Ml/Lb4O8x5vcdQlIR2XXTDvDwN9G298ZusQLTtgVVwd26Y/xrJuWJ7d9eJ?= =?iso-8859-1?Q?manDxPTmKLtdBNmVL/JP1PY8T1aEIMT+LoYwS0qOow/eQ+i8XlgmzV0931?= =?iso-8859-1?Q?mMtwC7qqqqQUtZdMbv7q3l37X9vdS/JWVHaDYpS78TYKxHBwX9Aj1qE+e1?= =?iso-8859-1?Q?fBM0hICZkv5m9Hcbd3n2kcFMFEmlnwv24XtnCvQiPe7SbvuhJqXyz/7pkk?= =?iso-8859-1?Q?g+n+b6ppBgEWKcLaHKT2jQ6TVxpjatGYK4ZE/lEn7RF3k+zP9PWKmXXcOE?= =?iso-8859-1?Q?CTvjYORG/8IHQl4tSr3PNZSv1YsO+3mgVIJ3gEv//2i0lesIDEjt0AP2iw?= =?iso-8859-1?Q?eh7wa8kIWb/SEwrbWizbXk7cE6ZmPL5UVzYRXSDi3eyxyHwZ3caLERWt6P?= =?iso-8859-1?Q?XxEsGZZFESmS3/W2XrLz8A60Vl94IGVaL5kEdj5wHh21yQlIpH9MzmDMOO?= =?iso-8859-1?Q?ZM3MrwJy11EjHtLQSWJUtu7OeCA7XfMq2YAYNmQjmprBgCx6k9eBp9Dagq?= =?iso-8859-1?Q?4tXUiBdG24cXdQmsIZorZIj+oCH3QoarxsEw/OJ3En8FRuDAvhhUwMHcDU?= =?iso-8859-1?Q?R+zFszkxZtng+H3gbBBaNOPOkkL1k71poWxm6ShkDTq/dYi1gcSnBVs6tx?= =?iso-8859-1?Q?2YniS5HzhCYGk7lum99fCpqwuP9pojuguazLYTNbHkRhVY+huDc6G8Gg2f?= =?iso-8859-1?Q?xR07aavzUM6QElWEr0RbhV5i8urRRk7iX7DmZNn6eKaw9W7c2pXQoG0g?= =?iso-8859-1?Q?=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: VI1PR03MB3710.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b427399-cd89-4523-ec2a-08da6a7fc437 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 18:43:41.1580 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VFG9HwMf/oggzCQSml3cZccNNRG6JFah9GD6c3U/ZsdZ/we+AVigIAGHJvOJ2tz60NLMpBLyHJAOOg9K70XzmJrQr07rgbx+Vrh8Uode5f8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR03MB5147 X-Proofpoint-GUID: uJqhKfQZfu-vxRuUJU57fyJ6Q4yc5o_s X-Proofpoint-ORIG-GUID: uJqhKfQZfu-vxRuUJU57fyJ6Q4yc5o_s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-20_12,2022-07-20_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 clxscore=1011 priorityscore=1501 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207200076 Hello Wei, Wei Chen writes: > Hi Volodymyr, > > On 2022/7/19 5:15, Volodymyr Babchuk wrote: >> From: Oleksandr Andrushchenko > >> if ( !use_msi ) >> return -EOPNOTSUPP; >> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci= .c >> index 938821e593..f93922acc8 100644 >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -50,21 +50,74 @@ struct pci_seg { >> } bus2bridge[MAX_BUSES]; >> }; >> -static spinlock_t _pcidevs_lock =3D SPIN_LOCK_UNLOCKED; >> +static DEFINE_RWLOCK(_pcidevs_rwlock); >> +static DEFINE_PER_CPU(unsigned int, pcidevs_read_cnt); >> +static DEFINE_PER_CPU(unsigned int, pcidevs_write_cnt); >> void pcidevs_lock(void) >> { >> - spin_lock_recursive(&_pcidevs_lock); >> + pcidevs_write_lock(); >> } >> void pcidevs_unlock(void) >> { >> - spin_unlock_recursive(&_pcidevs_lock); >> + pcidevs_write_unlock(); >> } >> -bool_t pcidevs_locked(void) >> +bool pcidevs_locked(void) >> { >> - return !!spin_is_locked(&_pcidevs_lock); >> + return pcidevs_write_locked(); >> +} >> + >> +void pcidevs_read_lock(void) >> +{ >> + if ( this_cpu(pcidevs_read_cnt)++ =3D=3D 0 ) >> + read_lock(&_pcidevs_rwlock); >> +} >> + > > For my understanding, if pcidevs_read_cnt > 0, pcidevs_read_lock > will be unblocked.I am not sure if this behavior is consistent with > the original lock? According to my understanding, the original > spinlock should be blocked all the time, if the lock is not > acquired. Maybe Original spinlock was recursive one. As read-write locks are non-recursive in Xen, we need to implement some other mechanism to support recursion. This code ensures that pCPU will not dead-lock itself if it'll call pcidevs_read_lock() twice. Per-CPU counter ensures that read_unlock() will be called only when pcidevs_read_unlock() calls is balanced with pcidevs_read_lock()s. > I have misunderstanding something, I am not very familiar with PCI > subsystem. > > Cheers, > Wei Chen [...] --=20 Volodymyr Babchuk at EPAM= From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372153.603999 (Exim 4.92) (envelope-from ) id 1oEEgz-0003RS-M4; Wed, 20 Jul 2022 18:45:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372153.603999; Wed, 20 Jul 2022 18:45:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEgz-0003RL-Iz; Wed, 20 Jul 2022 18:45:05 +0000 Received: by outflank-mailman (input) for mailman id 372153; Wed, 20 Jul 2022 18:45:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEgy-0003RF-Vy for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEgy-00077F-DS; Wed, 20 Jul 2022 18:45:04 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEgy-000309-3m; Wed, 20 Jul 2022 18:45:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:Message-Id:Date: Subject:Cc:To:From; bh=Y6gaNSd3J8zMYtlrc2f3c5lRDg45a2ZJJJFHbvZPWxQ=; b=ckezgs iQiV7ws2QyQoxFV7k7W4kaTLtRA6Lw9FJOoghWvbE6VarVlieABw16KVGKFZEDQnjE20kuARxP35Y ZeaGYQnhAz2pC6bejRJUb6V6n0uXi1FR1VBq9CpTboEFdPxgC2oOuBegb62LHOfMe78grHjMZcowX EPGRJIKuYtY=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups Date: Wed, 20 Jul 2022 19:44:54 +0100 Message-Id: <20220720184459.51582-1-julien@xen.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall Hi all, This series is a collection of patches to clean-up the MM subsystem I have done in preparation for the next revision of "xen/arm: Don't switch TTBR while the MMU is on" [1]. Cheers, [1] https://lore.kernel.org/all/20220309112048.17377-1-julien@xen.org/ Julien Grall (5): xen/arm: Remove most of the *_VIRT_END defines xen/arm32: mm: Consolidate the domheap mappings initialization xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... xen/arm: mm: Move domain_{,un}map_* helpers in a separate file xen/arm: mm: Reduce the area that xen_second covers xen/arch/arm/Kconfig | 1 + xen/arch/arm/Makefile | 1 + xen/arch/arm/domain_page.c | 193 ++++++++++++++++++++++++ xen/arch/arm/include/asm/arm32/mm.h | 8 + xen/arch/arm/include/asm/config.h | 19 +-- xen/arch/arm/include/asm/lpae.h | 17 +++ xen/arch/arm/livepatch.c | 2 +- xen/arch/arm/mm.c | 221 ++++------------------------ xen/arch/arm/setup.c | 21 ++- xen/arch/x86/Kconfig | 1 + xen/arch/x86/include/asm/config.h | 1 - xen/common/Kconfig | 6 + xen/include/xen/domain_page.h | 6 +- 13 files changed, 283 insertions(+), 214 deletions(-) create mode 100644 xen/arch/arm/domain_page.c -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372154.604011 (Exim 4.92) (envelope-from ) id 1oEEh1-0003i4-V8; Wed, 20 Jul 2022 18:45:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372154.604011; Wed, 20 Jul 2022 18:45:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh1-0003hx-R1; Wed, 20 Jul 2022 18:45:07 +0000 Received: by outflank-mailman (input) for mailman id 372154; Wed, 20 Jul 2022 18:45:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh0-0003Zu-2Q for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEgz-00077P-Ia; Wed, 20 Jul 2022 18:45:05 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEgz-000309-AI; Wed, 20 Jul 2022 18:45:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=hYBserRHCKnxjEBZbsMua2qzdvwsIdV+2glCDCaTlZQ=; b=XdW7vqYlbVh26LBYfdiQxTq3rk 6GHrE0ZwYKd8nwVfpe/XwbcyPC5YwYI/TxYGxhRNEKCradEp3S6BPzZDjNkgnE6StTutfhnEipk3m HSrfNl0TIRhVu0RmI7mwdESxZ+gyfRjSjPJ7V0t1SHEV7s7qCD19rC5i11VGQk+V9n9g=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Date: Wed, 20 Jul 2022 19:44:55 +0100 Message-Id: <20220720184459.51582-2-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220720184459.51582-1-julien@xen.org> References: <20220720184459.51582-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, *_VIRT_END may either point to the address after the end or the last address of the region. The lack of consistency make quite difficult to reason with them. Furthermore, there is a risk of overflow in the case where the address points past to the end. I am not aware of any cases, so this is only a latent bug. Start to solve the problem by removing all the *_VIRT_END exclusively used by the Arm code and add *_VIRT_SIZE when it is not present. Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE for better consistency and use _AT(vaddr_t, ). Also take the opportunity to fix the coding style of the comment touched in mm.c. Signed-off-by: Julien Grall ---- I noticed that a few functions in Xen expect [start, end[. This is risky as we may end up with end < start if the region is defined right at the top of the address space. I haven't yet tackle this issue. But I would at least like to get rid of *_VIRT_END. This was originally sent separately (lets call it v0). Changes in v2: - Correct the check in domain_page_map_to_mfn() Changes in v1: - Mention the coding style change. --- xen/arch/arm/include/asm/config.h | 18 ++++++++---------- xen/arch/arm/livepatch.c | 2 +- xen/arch/arm/mm.c | 13 ++++++++----- 3 files changed, 17 insertions(+), 16 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 3e2a55a91058..66db618b34e7 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -111,12 +111,11 @@ #define FIXMAP_ADDR(n) (_AT(vaddr_t,0x00400000) + (n) * PAGE_SIZE) #define BOOT_FDT_VIRT_START _AT(vaddr_t,0x00600000) -#define BOOT_FDT_SLOT_SIZE MB(4) -#define BOOT_FDT_VIRT_END (BOOT_FDT_VIRT_START + BOOT_FDT_SLOT_SIZE) +#define BOOT_FDT_VIRT_SIZE _AT(vaddr_t, MB(4)) #ifdef CONFIG_LIVEPATCH #define LIVEPATCH_VMAP_START _AT(vaddr_t,0x00a00000) -#define LIVEPATCH_VMAP_END (LIVEPATCH_VMAP_START + MB(2)) +#define LIVEPATCH_VMAP_SIZE _AT(vaddr_t, MB(2)) #endif #define HYPERVISOR_VIRT_START XEN_VIRT_START @@ -132,18 +131,18 @@ #define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) #define VMAP_VIRT_START _AT(vaddr_t,0x10000000) +#define VMAP_VIRT_SIZE _AT(vaddr_t, GB(1) - MB(256)) #define XENHEAP_VIRT_START _AT(vaddr_t,0x40000000) -#define XENHEAP_VIRT_END _AT(vaddr_t,0x7fffffff) -#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) -#define DOMHEAP_VIRT_END _AT(vaddr_t,0xffffffff) +#define XENHEAP_VIRT_SIZE _AT(vaddr_t, GB(1)) -#define VMAP_VIRT_END XENHEAP_VIRT_START +#define DOMHEAP_VIRT_START _AT(vaddr_t,0x80000000) +#define DOMHEAP_VIRT_SIZE _AT(vaddr_t, GB(2)) #define DOMHEAP_ENTRIES 1024 /* 1024 2MB mapping slots */ /* Number of domheap pagetable pages required at the second level (2MB mappings) */ -#define DOMHEAP_SECOND_PAGES ((DOMHEAP_VIRT_END - DOMHEAP_VIRT_START + 1) >> FIRST_SHIFT) +#define DOMHEAP_SECOND_PAGES (DOMHEAP_VIRT_SIZE >> FIRST_SHIFT) #else /* ARM_64 */ @@ -152,12 +151,11 @@ #define SLOT0_ENTRY_SIZE SLOT0(1) #define VMAP_VIRT_START GB(1) -#define VMAP_VIRT_END (VMAP_VIRT_START + GB(1)) +#define VMAP_VIRT_SIZE GB(1) #define FRAMETABLE_VIRT_START GB(32) #define FRAMETABLE_SIZE GB(32) #define FRAMETABLE_NR (FRAMETABLE_SIZE / sizeof(*frame_table)) -#define FRAMETABLE_VIRT_END (FRAMETABLE_VIRT_START + FRAMETABLE_SIZE - 1) #define DIRECTMAP_VIRT_START SLOT0(256) #define DIRECTMAP_SIZE (SLOT0_ENTRY_SIZE * (265-256)) diff --git a/xen/arch/arm/livepatch.c b/xen/arch/arm/livepatch.c index 75e8adcfd6a1..57abc746e60b 100644 --- a/xen/arch/arm/livepatch.c +++ b/xen/arch/arm/livepatch.c @@ -175,7 +175,7 @@ void __init arch_livepatch_init(void) void *start, *end; start = (void *)LIVEPATCH_VMAP_START; - end = (void *)LIVEPATCH_VMAP_END; + end = start + LIVEPATCH_VMAP_SIZE; vm_init_type(VMAP_XEN, start, end); diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 56fd0845861f..0177bc6b34d2 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -128,9 +128,11 @@ static DEFINE_PAGE_TABLE(xen_first); /* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ static DEFINE_PER_CPU(lpae_t *, xen_pgtable); #define THIS_CPU_PGTABLE this_cpu(xen_pgtable) -/* xen_dommap == pages used by map_domain_page, these pages contain +/* + * xen_dommap == pages used by map_domain_page, these pages contain * the second level pagetables which map the domheap region - * DOMHEAP_VIRT_START...DOMHEAP_VIRT_END in 2MB chunks. */ + * starting at DOMHEAP_VIRT_START in 2MB chunks. + */ static DEFINE_PER_CPU(lpae_t *, xen_dommap); /* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ static DEFINE_PAGE_TABLE(cpu0_pgtable); @@ -476,7 +478,7 @@ mfn_t domain_page_map_to_mfn(const void *ptr) int slot = (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; unsigned long offset = (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; - if ( va >= VMAP_VIRT_START && va < VMAP_VIRT_END ) + if ( (va >= VMAP_VIRT_START) && ((va - VMAP_VIRT_START) < VMAP_VIRT_SIZE) ) return virt_to_mfn(va); ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); @@ -570,7 +572,8 @@ void __init remove_early_mappings(void) int rc; /* destroy the _PAGE_BLOCK mapping */ - rc = modify_xen_mappings(BOOT_FDT_VIRT_START, BOOT_FDT_VIRT_END, + rc = modify_xen_mappings(BOOT_FDT_VIRT_START, + BOOT_FDT_VIRT_START + BOOT_FDT_VIRT_SIZE, _PAGE_BLOCK); BUG_ON(rc); } @@ -850,7 +853,7 @@ void __init setup_frametable_mappings(paddr_t ps, paddr_t pe) void *__init arch_vmap_virt_end(void) { - return (void *)VMAP_VIRT_END; + return (void *)(VMAP_VIRT_START + VMAP_VIRT_SIZE); } /* -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372155.604016 (Exim 4.92) (envelope-from ) id 1oEEh2-0003mB-9F; Wed, 20 Jul 2022 18:45:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372155.604016; Wed, 20 Jul 2022 18:45:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh2-0003kR-4V; Wed, 20 Jul 2022 18:45:08 +0000 Received: by outflank-mailman (input) for mailman id 372155; Wed, 20 Jul 2022 18:45:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh0-0003h3-RY for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:06 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh0-00077Z-I2; Wed, 20 Jul 2022 18:45:06 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEh0-000309-AK; Wed, 20 Jul 2022 18:45:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=roTEvcWcu2N8zSJ81FcgCWgpjdQOhGblXfk3B0P0v/Y=; b=AkrdoLpzTFmBR59StjPpMkW9z4 neOooEFhItAr/Wxqv8DkNINV/ADMeS2PcmzUd07YQaifNSe7TLb5UPt6Nwsk8lcJ6RR+gnKU+wqVt mY1CHk6oolM/Gw6dkjcqIyO3w33X6xJhdVbMxElpJA3i/PZtF9qED4c3KdA0n7yWVkNs=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Date: Wed, 20 Jul 2022 19:44:56 +0100 Message-Id: <20220720184459.51582-3-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220720184459.51582-1-julien@xen.org> References: <20220720184459.51582-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, the domheap mappings initialization is done separately for the boot CPU and secondary CPUs. The main difference is for the former the pages are part of Xen binary whilst for the latter they are dynamically allocated. It would be good to have a single helper so it is easier to rework on the domheap is initialized. For CPU0, we still need to use pre-allocated pages because the allocators may use domain_map_page(), so we need to have the domheap area ready first. But we can still delay the initialization to setup_mm(). Introduce a new helper init_domheap_mappings() that will be called from setup_mm() for the boot CPU and from init_secondary_pagetables() for secondary CPUs. Signed-off-by: Julien Grall ---- Changes in v2: - Fix function name in the commit message - Remove duplicated 'been' in the comment --- xen/arch/arm/include/asm/arm32/mm.h | 2 + xen/arch/arm/mm.c | 92 +++++++++++++++++++---------- xen/arch/arm/setup.c | 8 +++ 3 files changed, 71 insertions(+), 31 deletions(-) diff --git a/xen/arch/arm/include/asm/arm32/mm.h b/xen/arch/arm/include/asm/arm32/mm.h index 6b039d9ceaa2..575373aeb985 100644 --- a/xen/arch/arm/include/asm/arm32/mm.h +++ b/xen/arch/arm/include/asm/arm32/mm.h @@ -10,6 +10,8 @@ static inline bool arch_mfns_in_directmap(unsigned long mfn, unsigned long nr) return false; } +bool init_domheap_mappings(unsigned int cpu); + #endif /* __ARM_ARM32_MM_H__ */ /* diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 0177bc6b34d2..9311f3530066 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -372,6 +372,58 @@ void clear_fixmap(unsigned int map) } #ifdef CONFIG_DOMAIN_PAGE +/* + * Prepare the area that will be used to map domheap pages. They are + * mapped in 2MB chunks, so we need to allocate the page-tables up to + * the 2nd level. + * + * The caller should make sure the root page-table for @cpu has been + * allocated. + */ +bool init_domheap_mappings(unsigned int cpu) +{ + unsigned int order = get_order_from_pages(DOMHEAP_SECOND_PAGES); + lpae_t *root = per_cpu(xen_pgtable, cpu); + unsigned int i, first_idx; + lpae_t *domheap; + mfn_t mfn; + + ASSERT(root); + ASSERT(!per_cpu(xen_dommap, cpu)); + + /* + * The domheap for cpu0 is before the heap is initialized. So we + * need to use pre-allocated pages. + */ + if ( !cpu ) + domheap = cpu0_dommap; + else + domheap = alloc_xenheap_pages(order, 0); + + if ( !domheap ) + return false; + + /* Ensure the domheap has no stray mappings */ + memset(domheap, 0, DOMHEAP_SECOND_PAGES * PAGE_SIZE); + + /* + * Update the first level mapping to reference the local CPUs + * domheap mapping pages. + */ + mfn = virt_to_mfn(domheap); + first_idx = first_table_offset(DOMHEAP_VIRT_START); + for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) + { + lpae_t pte = mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL); + pte.pt.table = 1; + write_pte(&root[first_idx + i], pte); + } + + per_cpu(xen_dommap, cpu) = domheap; + + return true; +} + void *map_domain_page_global(mfn_t mfn) { return vmap(&mfn, 1); @@ -633,16 +685,6 @@ void __init setup_pagetables(unsigned long boot_phys_offset) p[i].pt.xn = 0; } -#ifdef CONFIG_ARM_32 - for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) - { - p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)] - = pte_of_xenaddr((uintptr_t)(cpu0_dommap + - i * XEN_PT_LPAE_ENTRIES)); - p[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)].pt.table = 1; - } -#endif - /* Break up the Xen mapping into 4k pages and protect them separately. */ for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) { @@ -686,7 +728,6 @@ void __init setup_pagetables(unsigned long boot_phys_offset) #ifdef CONFIG_ARM_32 per_cpu(xen_pgtable, 0) = cpu0_pgtable; - per_cpu(xen_dommap, 0) = cpu0_dommap; #endif } @@ -719,39 +760,28 @@ int init_secondary_pagetables(int cpu) #else int init_secondary_pagetables(int cpu) { - lpae_t *first, *domheap, pte; - int i; + lpae_t *first; first = alloc_xenheap_page(); /* root == first level on 32-bit 3-level trie */ - domheap = alloc_xenheap_pages(get_order_from_pages(DOMHEAP_SECOND_PAGES), 0); - if ( domheap == NULL || first == NULL ) + if ( !first ) { - printk("Not enough free memory for secondary CPU%d pagetables\n", cpu); - free_xenheap_pages(domheap, get_order_from_pages(DOMHEAP_SECOND_PAGES)); - free_xenheap_page(first); + printk("CPU%u: Unable to allocate the first page-table\n", cpu); return -ENOMEM; } /* Initialise root pagetable from root of boot tables */ memcpy(first, cpu0_pgtable, PAGE_SIZE); + per_cpu(xen_pgtable, cpu) = first; - /* Ensure the domheap has no stray mappings */ - memset(domheap, 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE); - - /* Update the first level mapping to reference the local CPUs - * domheap mapping pages. */ - for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) + if ( !init_domheap_mappings(cpu) ) { - pte = mfn_to_xen_entry(virt_to_mfn(domheap + i * XEN_PT_LPAE_ENTRIES), - MT_NORMAL); - pte.pt.table = 1; - write_pte(&first[first_table_offset(DOMHEAP_VIRT_START+i*FIRST_SIZE)], pte); + printk("CPU%u: Unable to prepare the domheap page-tables\n", cpu); + per_cpu(xen_pgtable, cpu) = NULL; + free_xenheap_page(first); + return -ENOMEM; } - per_cpu(xen_pgtable, cpu) = first; - per_cpu(xen_dommap, cpu) = domheap; - clear_boot_pagetables(); /* Set init_ttbr for this CPU coming up */ diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 85ff956ec2e3..068e84b10335 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -783,6 +783,14 @@ static void __init setup_mm(void) setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); + /* + * The allocators may need to use map_domain_page() (such as for + * scrubbing pages). So we need to prepare the domheap area first. + */ + if ( !init_domheap_mappings(smp_processor_id()) ) + panic("CPU%u: Unable to prepare the domheap page-tables\n", + smp_processor_id()); + /* Add xenheap memory that was not already added to the boot allocator. */ init_xenheap_pages(mfn_to_maddr(xenheap_mfn_start), mfn_to_maddr(xenheap_mfn_end)); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372156.604033 (Exim 4.92) (envelope-from ) id 1oEEh3-0004E8-VR; Wed, 20 Jul 2022 18:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372156.604033; Wed, 20 Jul 2022 18:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh3-0004Dr-PZ; Wed, 20 Jul 2022 18:45:09 +0000 Received: by outflank-mailman (input) for mailman id 372156; Wed, 20 Jul 2022 18:45:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh2-0003ri-Ey for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh2-00077p-1r; Wed, 20 Jul 2022 18:45:08 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEh1-000309-QO; Wed, 20 Jul 2022 18:45:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=ZCcbJJZ0Rn+Gw3fU5XlJ9t1HEWrkwplqjvNtiYujb+U=; b=mgfkhn8HmiKixAUJGLH7LNTgmO mU+d2SWubeDXGLatCRQ1GhcpZh2cssgZarwNFrKkFR1D/XCixHhi2h5IClQUi/YidmJDEg8v5pRBK SfALmDJCWtenAHbvJjZZoq0C7cQFnJ6hZ8FPS2OFi4Xp4fYfoPNjyyxFGmi5OmF9qnlw=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... Date: Wed, 20 Jul 2022 19:44:57 +0100 Message-Id: <20220720184459.51582-4-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220720184459.51582-1-julien@xen.org> References: <20220720184459.51582-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall move it to Kconfig. The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide helpers to map/unmap a domain page. Rename it to the define to CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove support for domain page (this is not a concept that Xen can't get away with). Take the opportunity to move CONFIG_MAP_DOMAIN_PAGE to Kconfig as this will soon be necessary to use it in the Makefile. Signed-off-by: Julien Grall ---- Changes in v2: - New patch --- xen/arch/arm/Kconfig | 1 + xen/arch/arm/include/asm/config.h | 1 - xen/arch/arm/mm.c | 2 +- xen/arch/x86/Kconfig | 1 + xen/arch/x86/include/asm/config.h | 1 - xen/common/Kconfig | 3 +++ xen/include/xen/domain_page.h | 6 +++--- 7 files changed, 9 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index be9eff014120..33e004d702bf 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -1,6 +1,7 @@ config ARM_32 def_bool y depends on "$(ARCH)" = "arm32" + select ARCH_MAP_DOMAIN_PAGE config ARM_64 def_bool y diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/arm/include/asm/config.h index 66db618b34e7..2fafb9f2283c 100644 --- a/xen/arch/arm/include/asm/config.h +++ b/xen/arch/arm/include/asm/config.h @@ -122,7 +122,6 @@ #ifdef CONFIG_ARM_32 -#define CONFIG_DOMAIN_PAGE 1 #define CONFIG_SEPARATE_XENHEAP 1 #define FRAMETABLE_VIRT_START _AT(vaddr_t,0x02000000) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 9311f3530066..7a722d6c86c6 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -371,7 +371,7 @@ void clear_fixmap(unsigned int map) BUG_ON(res != 0); } -#ifdef CONFIG_DOMAIN_PAGE +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE /* * Prepare the area that will be used to map domheap pages. They are * mapped in 2MB chunks, so we need to allocate the page-tables up to diff --git a/xen/arch/x86/Kconfig b/xen/arch/x86/Kconfig index 6bed72b79141..6a7825f4ba3c 100644 --- a/xen/arch/x86/Kconfig +++ b/xen/arch/x86/Kconfig @@ -8,6 +8,7 @@ config X86 select ACPI_LEGACY_TABLES_LOOKUP select ACPI_NUMA select ALTERNATIVE_CALL + select ARCH_MAP_DOMAIN_PAGE select ARCH_SUPPORTS_INT128 select CORE_PARKING select HAS_ALTERNATIVE diff --git a/xen/arch/x86/include/asm/config.h b/xen/arch/x86/include/asm/config.h index 07bcd158314b..fbc4bb3416bd 100644 --- a/xen/arch/x86/include/asm/config.h +++ b/xen/arch/x86/include/asm/config.h @@ -22,7 +22,6 @@ #define CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS 1 #define CONFIG_DISCONTIGMEM 1 #define CONFIG_NUMA_EMU 1 -#define CONFIG_DOMAIN_PAGE 1 #define CONFIG_PAGEALLOC_MAX_ORDER (2 * PAGETABLE_ORDER) #define CONFIG_DOMU_MAX_ORDER PAGETABLE_ORDER diff --git a/xen/common/Kconfig b/xen/common/Kconfig index 41a67891bcc8..f1ea3199c8eb 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -25,6 +25,9 @@ config GRANT_TABLE config ALTERNATIVE_CALL bool +config ARCH_MAP_DOMAIN_PAGE + bool + config HAS_ALTERNATIVE bool diff --git a/xen/include/xen/domain_page.h b/xen/include/xen/domain_page.h index a182d33b6701..149b217b9619 100644 --- a/xen/include/xen/domain_page.h +++ b/xen/include/xen/domain_page.h @@ -17,7 +17,7 @@ void clear_domain_page(mfn_t mfn); void copy_domain_page(mfn_t dst, const mfn_t src); -#ifdef CONFIG_DOMAIN_PAGE +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE /* * Map a given page frame, returning the mapped virtual address. The page is @@ -51,7 +51,7 @@ static inline void *__map_domain_page_global(const struct page_info *pg) return map_domain_page_global(page_to_mfn(pg)); } -#else /* !CONFIG_DOMAIN_PAGE */ +#else /* !CONFIG_ARCH_MAP_DOMAIN_PAGE */ #define map_domain_page(mfn) __mfn_to_virt(mfn_x(mfn)) #define __map_domain_page(pg) page_to_virt(pg) @@ -70,7 +70,7 @@ static inline void *__map_domain_page_global(const struct page_info *pg) static inline void unmap_domain_page_global(const void *va) {}; -#endif /* !CONFIG_DOMAIN_PAGE */ +#endif /* !CONFIG_ARCH_MAP_DOMAIN_PAGE */ #define UNMAP_DOMAIN_PAGE(p) do { \ unmap_domain_page(p); \ -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372158.604044 (Exim 4.92) (envelope-from ) id 1oEEh5-0004Vf-9L; Wed, 20 Jul 2022 18:45:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372158.604044; Wed, 20 Jul 2022 18:45:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh5-0004Ua-2L; Wed, 20 Jul 2022 18:45:11 +0000 Received: by outflank-mailman (input) for mailman id 372158; Wed, 20 Jul 2022 18:45:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh3-0004FA-UJ for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:09 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh3-00078B-Hq; Wed, 20 Jul 2022 18:45:09 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEh3-000309-74; Wed, 20 Jul 2022 18:45:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=5eiQZQZs5fJEBjxXTKP6HOuojy96rusV1MzRtnzOfTg=; b=EtDWPMqUAWteB5yasJHq/KXHVB SXLNrFdO5At3cb8XkIxePvaC6EYvRA5p7+aRrP0zMyO0HaQ2CUkn7IkExZJRyunsolSeGzQLEmWYR SIMgb4bKXPJZuPVtsgbQpLFgx5lqi3HMYwMJRheXbdM5ROoY9bgGwhQ4MMWsv7JxQ3fk=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file Date: Wed, 20 Jul 2022 19:44:58 +0100 Message-Id: <20220720184459.51582-5-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220720184459.51582-1-julien@xen.org> References: <20220720184459.51582-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall The file xen/arch/mm.c has been growing quite a lot. It now contains various independent part of the MM subsytem. One of them is the helpers to map/unmap a page which is only used by arm32 and protected by CONFIG_ARCH_MAP_DOMAIN_PAGE. Move them in a new file xen/arch/arm/domain_page.c. Signed-off-by: Julien Grall ---- Changes in v2: - Move CONFIG_* to Kconfig is now in a separate patch --- xen/arch/arm/Makefile | 1 + xen/arch/arm/domain_page.c | 193 +++++++++++++++++++++++++++ xen/arch/arm/include/asm/arm32/mm.h | 6 + xen/arch/arm/include/asm/lpae.h | 17 +++ xen/arch/arm/mm.c | 198 +--------------------------- xen/common/Kconfig | 3 + 6 files changed, 222 insertions(+), 196 deletions(-) create mode 100644 xen/arch/arm/domain_page.c diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile index bb7a6151c13c..4d076b278b10 100644 --- a/xen/arch/arm/Makefile +++ b/xen/arch/arm/Makefile @@ -17,6 +17,7 @@ obj-y += device.o obj-$(CONFIG_IOREQ_SERVER) += dm.o obj-y += domain.o obj-y += domain_build.init.o +obj-$(CONFIG_ARCH_MAP_DOMAIN_PAGE) += domain_page.o obj-y += domctl.o obj-$(CONFIG_EARLY_PRINTK) += early_printk.o obj-y += efi/ diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c new file mode 100644 index 000000000000..63e97730cf57 --- /dev/null +++ b/xen/arch/arm/domain_page.c @@ -0,0 +1,193 @@ +#include +#include +#include + +/* Override macros from asm/page.h to make them work with mfn_t */ +#undef virt_to_mfn +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) + +/* cpu0's domheap page tables */ +static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES); + +/* + * xen_dommap == pages used by map_domain_page, these pages contain + * the second level pagetables which map the domheap region + * starting at DOMHEAP_VIRT_START in 2MB chunks. + */ +static DEFINE_PER_CPU(lpae_t *, xen_dommap); + +/* + * Prepare the area that will be used to map domheap pages. They are + * mapped in 2MB chunks, so we need to allocate the page-tables up to + * the 2nd level. + * + * The caller should make sure the root page-table for @cpu has been + * allocated. + */ +bool init_domheap_mappings(unsigned int cpu) +{ + unsigned int order = get_order_from_pages(DOMHEAP_SECOND_PAGES); + lpae_t *root = per_cpu(xen_pgtable, cpu); + unsigned int i, first_idx; + lpae_t *domheap; + mfn_t mfn; + + ASSERT(root); + ASSERT(!per_cpu(xen_dommap, cpu)); + + /* + * The domheap for cpu0 is before the heap is initialized. So we + * need to use pre-allocated pages. + */ + if ( !cpu ) + domheap = cpu0_dommap; + else + domheap = alloc_xenheap_pages(order, 0); + + if ( !domheap ) + return false; + + /* Ensure the domheap has no stray mappings */ + memset(domheap, 0, DOMHEAP_SECOND_PAGES * PAGE_SIZE); + + /* + * Update the first level mapping to reference the local CPUs + * domheap mapping pages. + */ + mfn = virt_to_mfn(domheap); + first_idx = first_table_offset(DOMHEAP_VIRT_START); + for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) + { + lpae_t pte = mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL); + pte.pt.table = 1; + write_pte(&root[first_idx + i], pte); + } + + per_cpu(xen_dommap, cpu) = domheap; + + return true; +} + +void *map_domain_page_global(mfn_t mfn) +{ + return vmap(&mfn, 1); +} + +void unmap_domain_page_global(const void *va) +{ + vunmap(va); +} + +/* Map a page of domheap memory */ +void *map_domain_page(mfn_t mfn) +{ + unsigned long flags; + lpae_t *map = this_cpu(xen_dommap); + unsigned long slot_mfn = mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK; + vaddr_t va; + lpae_t pte; + int i, slot; + + local_irq_save(flags); + + /* The map is laid out as an open-addressed hash table where each + * entry is a 2MB superpage pte. We use the available bits of each + * PTE as a reference count; when the refcount is zero the slot can + * be reused. */ + for ( slot = (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i = 0; + i < DOMHEAP_ENTRIES; + slot = (slot + 1) % DOMHEAP_ENTRIES, i++ ) + { + if ( map[slot].pt.avail < 0xf && + map[slot].pt.base == slot_mfn && + map[slot].pt.valid ) + { + /* This slot already points to the right place; reuse it */ + map[slot].pt.avail++; + break; + } + else if ( map[slot].pt.avail == 0 ) + { + /* Commandeer this 2MB slot */ + pte = mfn_to_xen_entry(_mfn(slot_mfn), MT_NORMAL); + pte.pt.avail = 1; + write_pte(map + slot, pte); + break; + } + + } + /* If the map fills up, the callers have misbehaved. */ + BUG_ON(i == DOMHEAP_ENTRIES); + +#ifndef NDEBUG + /* Searching the hash could get slow if the map starts filling up. + * Cross that bridge when we come to it */ + { + static int max_tries = 32; + if ( i >= max_tries ) + { + dprintk(XENLOG_WARNING, "Domheap map is filling: %i tries\n", i); + max_tries *= 2; + } + } +#endif + + local_irq_restore(flags); + + va = (DOMHEAP_VIRT_START + + (slot << SECOND_SHIFT) + + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT)); + + /* + * We may not have flushed this specific subpage at map time, + * since we only flush the 4k page not the superpage + */ + flush_xen_tlb_range_va_local(va, PAGE_SIZE); + + return (void *)va; +} + +/* Release a mapping taken with map_domain_page() */ +void unmap_domain_page(const void *va) +{ + unsigned long flags; + lpae_t *map = this_cpu(xen_dommap); + int slot = ((unsigned long) va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; + + if ( !va ) + return; + + local_irq_save(flags); + + ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); + ASSERT(map[slot].pt.avail != 0); + + map[slot].pt.avail--; + + local_irq_restore(flags); +} + +mfn_t domain_page_map_to_mfn(const void *ptr) +{ + unsigned long va = (unsigned long)ptr; + lpae_t *map = this_cpu(xen_dommap); + int slot = (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; + unsigned long offset = (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; + + if ( (va >= VMAP_VIRT_START) && ((va - VMAP_VIRT_START) < VMAP_VIRT_SIZE) ) + return virt_to_mfn(va); + + ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); + ASSERT(map[slot].pt.avail != 0); + + return mfn_add(lpae_get_mfn(map[slot]), offset); +} + +/* + * Local variables: + * mode: C + * c-file-style: "BSD" + * c-basic-offset: 4 + * indent-tabs-mode: nil + * End: + */ diff --git a/xen/arch/arm/include/asm/arm32/mm.h b/xen/arch/arm/include/asm/arm32/mm.h index 575373aeb985..8bfc906e7178 100644 --- a/xen/arch/arm/include/asm/arm32/mm.h +++ b/xen/arch/arm/include/asm/arm32/mm.h @@ -1,6 +1,12 @@ #ifndef __ARM_ARM32_MM_H__ #define __ARM_ARM32_MM_H__ +#include + +#include + +DECLARE_PER_CPU(lpae_t *, xen_pgtable); + /* * Only a limited amount of RAM, called xenheap, is always mapped on ARM32. * For convenience always return false. diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/lpae.h index fc19cbd84772..3fdd5d0de28e 100644 --- a/xen/arch/arm/include/asm/lpae.h +++ b/xen/arch/arm/include/asm/lpae.h @@ -261,6 +261,23 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr); #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) +/* + * Macros to define page-tables: + * - DEFINE_BOOT_PAGE_TABLE is used to define page-table that are used + * in assembly code before BSS is zeroed. + * - DEFINE_PAGE_TABLE{,S} are used to define one or multiple + * page-tables to be used after BSS is zeroed (typically they are only used + * in C). + */ +#define DEFINE_BOOT_PAGE_TABLE(name) \ +lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") \ + name[XEN_PT_LPAE_ENTRIES] + +#define DEFINE_PAGE_TABLES(name, nr) \ +lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)] + +#define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1) + #endif /* __ARM_LPAE_H__ */ /* diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 7a722d6c86c6..ad26ad740308 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -57,23 +57,6 @@ mm_printk(const char *fmt, ...) {} } while (0) #endif -/* - * Macros to define page-tables: - * - DEFINE_BOOT_PAGE_TABLE is used to define page-table that are used - * in assembly code before BSS is zeroed. - * - DEFINE_PAGE_TABLE{,S} are used to define one or multiple - * page-tables to be used after BSS is zeroed (typically they are only used - * in C). - */ -#define DEFINE_BOOT_PAGE_TABLE(name) \ -lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") \ - name[XEN_PT_LPAE_ENTRIES] - -#define DEFINE_PAGE_TABLES(name, nr) \ -lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)] - -#define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1) - /* Static start-of-day pagetables that we use before the allocators * are up. These are used by all CPUs during bringup before switching * to the CPUs own pagetables. @@ -110,7 +93,7 @@ DEFINE_BOOT_PAGE_TABLE(boot_third); /* Main runtime page tables */ /* - * For arm32 xen_pgtable and xen_dommap are per-PCPU and are allocated before + * For arm32 xen_pgtable are per-PCPU and are allocated before * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. * * xen_second, xen_fixmap and xen_xenmap are always shared between all @@ -126,18 +109,10 @@ static DEFINE_PAGE_TABLE(xen_first); #define HYP_PT_ROOT_LEVEL 1 /* Per-CPU pagetable pages */ /* xen_pgtable == root of the trie (zeroeth level on 64-bit, first on 32-bit) */ -static DEFINE_PER_CPU(lpae_t *, xen_pgtable); +DEFINE_PER_CPU(lpae_t *, xen_pgtable); #define THIS_CPU_PGTABLE this_cpu(xen_pgtable) -/* - * xen_dommap == pages used by map_domain_page, these pages contain - * the second level pagetables which map the domheap region - * starting at DOMHEAP_VIRT_START in 2MB chunks. - */ -static DEFINE_PER_CPU(lpae_t *, xen_dommap); /* Root of the trie for cpu0, other CPU's PTs are dynamically allocated */ static DEFINE_PAGE_TABLE(cpu0_pgtable); -/* cpu0's domheap page tables */ -static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES); #endif /* Common pagetable leaves */ @@ -371,175 +346,6 @@ void clear_fixmap(unsigned int map) BUG_ON(res != 0); } -#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE -/* - * Prepare the area that will be used to map domheap pages. They are - * mapped in 2MB chunks, so we need to allocate the page-tables up to - * the 2nd level. - * - * The caller should make sure the root page-table for @cpu has been - * allocated. - */ -bool init_domheap_mappings(unsigned int cpu) -{ - unsigned int order = get_order_from_pages(DOMHEAP_SECOND_PAGES); - lpae_t *root = per_cpu(xen_pgtable, cpu); - unsigned int i, first_idx; - lpae_t *domheap; - mfn_t mfn; - - ASSERT(root); - ASSERT(!per_cpu(xen_dommap, cpu)); - - /* - * The domheap for cpu0 is before the heap is initialized. So we - * need to use pre-allocated pages. - */ - if ( !cpu ) - domheap = cpu0_dommap; - else - domheap = alloc_xenheap_pages(order, 0); - - if ( !domheap ) - return false; - - /* Ensure the domheap has no stray mappings */ - memset(domheap, 0, DOMHEAP_SECOND_PAGES * PAGE_SIZE); - - /* - * Update the first level mapping to reference the local CPUs - * domheap mapping pages. - */ - mfn = virt_to_mfn(domheap); - first_idx = first_table_offset(DOMHEAP_VIRT_START); - for ( i = 0; i < DOMHEAP_SECOND_PAGES; i++ ) - { - lpae_t pte = mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL); - pte.pt.table = 1; - write_pte(&root[first_idx + i], pte); - } - - per_cpu(xen_dommap, cpu) = domheap; - - return true; -} - -void *map_domain_page_global(mfn_t mfn) -{ - return vmap(&mfn, 1); -} - -void unmap_domain_page_global(const void *va) -{ - vunmap(va); -} - -/* Map a page of domheap memory */ -void *map_domain_page(mfn_t mfn) -{ - unsigned long flags; - lpae_t *map = this_cpu(xen_dommap); - unsigned long slot_mfn = mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK; - vaddr_t va; - lpae_t pte; - int i, slot; - - local_irq_save(flags); - - /* The map is laid out as an open-addressed hash table where each - * entry is a 2MB superpage pte. We use the available bits of each - * PTE as a reference count; when the refcount is zero the slot can - * be reused. */ - for ( slot = (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i = 0; - i < DOMHEAP_ENTRIES; - slot = (slot + 1) % DOMHEAP_ENTRIES, i++ ) - { - if ( map[slot].pt.avail < 0xf && - map[slot].pt.base == slot_mfn && - map[slot].pt.valid ) - { - /* This slot already points to the right place; reuse it */ - map[slot].pt.avail++; - break; - } - else if ( map[slot].pt.avail == 0 ) - { - /* Commandeer this 2MB slot */ - pte = mfn_to_xen_entry(_mfn(slot_mfn), MT_NORMAL); - pte.pt.avail = 1; - write_pte(map + slot, pte); - break; - } - - } - /* If the map fills up, the callers have misbehaved. */ - BUG_ON(i == DOMHEAP_ENTRIES); - -#ifndef NDEBUG - /* Searching the hash could get slow if the map starts filling up. - * Cross that bridge when we come to it */ - { - static int max_tries = 32; - if ( i >= max_tries ) - { - dprintk(XENLOG_WARNING, "Domheap map is filling: %i tries\n", i); - max_tries *= 2; - } - } -#endif - - local_irq_restore(flags); - - va = (DOMHEAP_VIRT_START - + (slot << SECOND_SHIFT) - + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT)); - - /* - * We may not have flushed this specific subpage at map time, - * since we only flush the 4k page not the superpage - */ - flush_xen_tlb_range_va_local(va, PAGE_SIZE); - - return (void *)va; -} - -/* Release a mapping taken with map_domain_page() */ -void unmap_domain_page(const void *va) -{ - unsigned long flags; - lpae_t *map = this_cpu(xen_dommap); - int slot = ((unsigned long) va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; - - if ( !va ) - return; - - local_irq_save(flags); - - ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); - ASSERT(map[slot].pt.avail != 0); - - map[slot].pt.avail--; - - local_irq_restore(flags); -} - -mfn_t domain_page_map_to_mfn(const void *ptr) -{ - unsigned long va = (unsigned long)ptr; - lpae_t *map = this_cpu(xen_dommap); - int slot = (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; - unsigned long offset = (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; - - if ( (va >= VMAP_VIRT_START) && ((va - VMAP_VIRT_START) < VMAP_VIRT_SIZE) ) - return virt_to_mfn(va); - - ASSERT(slot >= 0 && slot < DOMHEAP_ENTRIES); - ASSERT(map[slot].pt.avail != 0); - - return mfn_add(lpae_get_mfn(map[slot]), offset); -} -#endif - void flush_page_to_ram(unsigned long mfn, bool sync_icache) { void *v = map_domain_page(_mfn(mfn)); diff --git a/xen/common/Kconfig b/xen/common/Kconfig index f1ea3199c8eb..f0aee2cfd9f8 100644 --- a/xen/common/Kconfig +++ b/xen/common/Kconfig @@ -11,6 +11,9 @@ config COMPAT config CORE_PARKING bool +config DOMAIN_PAGE + bool + config GRANT_TABLE bool "Grant table support" if EXPERT default y -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:45:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:45:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372160.604055 (Exim 4.92) (envelope-from ) id 1oEEh6-0004ow-LM; Wed, 20 Jul 2022 18:45:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372160.604055; Wed, 20 Jul 2022 18:45:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh6-0004ob-DC; Wed, 20 Jul 2022 18:45:12 +0000 Received: by outflank-mailman (input) for mailman id 372160; Wed, 20 Jul 2022 18:45:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh4-0004S6-Pi for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:45:10 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEh4-00078a-L2; Wed, 20 Jul 2022 18:45:10 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=dev-dsk-jgrall-1b-035652ec.eu-west-1.amazon.com) by xenbits.xenproject.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEEh4-000309-DV; Wed, 20 Jul 2022 18:45:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-Id:Date:Subject:Cc:To:From; bh=W88wa027woW8KL9i8JFI4zNWkFVBWQcBIx2bW2nUgSg=; b=a/P6a7Z+WG8XJpD3Cq+j93KA8M vIdqaLI32/+6exvX4FfXD8BM1D7Qi1ZwpdZc2ilIu+WHj0/RNPvNY8li+2zGmTI5es1O1fdoyxqel 9c+3gB4d/sgz0vnviU/8Kcn+IooE9skcuHelxaAHL3iFBA1k71EEPXNfuJqU+g+QMwI0=; From: Julien Grall To: xen-devel@lists.xenproject.org Cc: julien@xen.org, Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Michal Orzel Subject: [PATCH v2 5/5] xen/arm: mm: Reduce the area that xen_second covers Date: Wed, 20 Jul 2022 19:44:59 +0100 Message-Id: <20220720184459.51582-6-julien@xen.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220720184459.51582-1-julien@xen.org> References: <20220720184459.51582-1-julien@xen.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Julien Grall At the moment, xen_second is used to cover the first 2GB of the virtual address space. With the recent rework of the page-tables, only the first 1GB region (where Xen resides) is effectively used. In addition to that, I would like to reshuffle the memory layout. So Xen mappings may not be anymore in the first 2GB of the virtual address space. Therefore, rework xen_second so it only covers the 1GB region where Xen will reside. With this change, xen_second doesn't cover anymore the xenheap area on arm32. So, we first need to add memory to the boot allocator before setting up the xenheap mappings. Take the opportunity to update the comments on top of xen_fixmap and xen_xenmap. Signed-off-by: Julien Grall Reviewed-by: Michal Orzel ---- Changes in v2: - Add Michal's reviewed-by --- xen/arch/arm/mm.c | 32 +++++++++++--------------------- xen/arch/arm/setup.c | 13 +++++++++++-- 2 files changed, 22 insertions(+), 23 deletions(-) diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index ad26ad740308..3d2c046bbb5c 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -116,17 +116,14 @@ static DEFINE_PAGE_TABLE(cpu0_pgtable); #endif /* Common pagetable leaves */ -/* Second level page tables. - * - * The second-level table is 2 contiguous pages long, and covers all - * addresses from 0 to 0x7fffffff. Offsets into it are calculated - * with second_linear_offset(), not second_table_offset(). - */ -static DEFINE_PAGE_TABLES(xen_second, 2); -/* First level page table used for fixmap */ +/* Second level page table used to cover Xen virtual address space */ +static DEFINE_PAGE_TABLE(xen_second); +/* Third level page table used for fixmap */ DEFINE_BOOT_PAGE_TABLE(xen_fixmap); -/* First level page table used to map Xen itself with the XN bit set - * as appropriate. */ +/* + * Third level page table used to map Xen itself with the XN bit set + * as appropriate. + */ static DEFINE_PAGE_TABLE(xen_xenmap); /* Non-boot CPUs use this to find the correct pagetables. */ @@ -168,7 +165,6 @@ static void __init __maybe_unused build_assertions(void) BUILD_BUG_ON(zeroeth_table_offset(XEN_VIRT_START)); #endif BUILD_BUG_ON(first_table_offset(XEN_VIRT_START)); - BUILD_BUG_ON(second_linear_offset(XEN_VIRT_START) >= XEN_PT_LPAE_ENTRIES); #ifdef CONFIG_DOMAIN_PAGE BUILD_BUG_ON(DOMHEAP_VIRT_START & ~FIRST_MASK); #endif @@ -482,14 +478,10 @@ void __init setup_pagetables(unsigned long boot_phys_offset) p = (void *) cpu0_pgtable; #endif - /* Initialise first level entries, to point to second level entries */ - for ( i = 0; i < 2; i++) - { - p[i] = pte_of_xenaddr((uintptr_t)(xen_second + - i * XEN_PT_LPAE_ENTRIES)); - p[i].pt.table = 1; - p[i].pt.xn = 0; - } + /* Map xen second level page-table */ + p[0] = pte_of_xenaddr((uintptr_t)(xen_second)); + p[0].pt.table = 1; + p[0].pt.xn = 0; /* Break up the Xen mapping into 4k pages and protect them separately. */ for ( i = 0; i < XEN_PT_LPAE_ENTRIES; i++ ) @@ -618,8 +610,6 @@ void __init setup_xenheap_mappings(unsigned long base_mfn, /* Record where the xenheap is, for translation routines. */ xenheap_virt_end = XENHEAP_VIRT_START + nr_mfns * PAGE_SIZE; - xenheap_mfn_start = _mfn(base_mfn); - xenheap_mfn_end = _mfn(base_mfn + nr_mfns); } #else /* CONFIG_ARM_64 */ void __init setup_xenheap_mappings(unsigned long base_mfn, diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index 068e84b10335..500307edc08d 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -774,11 +774,20 @@ static void __init setup_mm(void) opt_xenheap_megabytes ? ", from command-line" : ""); printk("Dom heap: %lu pages\n", domheap_pages); - setup_xenheap_mappings((e >> PAGE_SHIFT) - xenheap_pages, xenheap_pages); + /* + * We need some memory to allocate the page-tables used for the + * xenheap mappings. So populate the boot allocator first. + * + * This requires us to set xenheap_mfn_{start, end} first so the Xenheap + * region can be avoided. + */ + xenheap_mfn_start = _mfn((e >> PAGE_SHIFT) - xenheap_pages); + xenheap_mfn_end = mfn_add(xenheap_mfn_start, xenheap_pages); - /* Add non-xenheap memory */ populate_boot_allocator(); + setup_xenheap_mappings(mfn_x(xenheap_mfn_start), xenheap_pages); + /* Frame table covers all of RAM region, including holes */ setup_frametable_mappings(ram_start, ram_end); max_page = PFN_DOWN(ram_end); -- 2.32.0 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 18:47:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 18:47:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372186.604066 (Exim 4.92) (envelope-from ) id 1oEEjb-0007KR-8o; Wed, 20 Jul 2022 18:47:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372186.604066; Wed, 20 Jul 2022 18:47:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEjb-0007KK-6E; Wed, 20 Jul 2022 18:47:47 +0000 Received: by outflank-mailman (input) for mailman id 372186; Wed, 20 Jul 2022 18:47:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEEjZ-0007HU-M1 for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 18:47:45 +0000 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6de7acfb-085c-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 20:47:41 +0200 (CEST) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 11:47:38 -0700 Received: from tjallen-mobl2.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.77.158]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 11:47:37 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6de7acfb-085c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658342861; x=1689878861; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HvuiVSC6L+zZtd0km8X9OA/UYHsNkzJuQJiqCKLQ7sg=; b=hBsRaO9c8zY1K9euqpU1hZfmn3qbmbLZAJzKR4yjRpiFYO/5Wpw7Jd5e 2BYNZEeTLN/8fRNkq65chl99H1M0o84Kqb4WsHwmwxrOqtiOZf0nhfiLb eLK3M7jz/DwmujLFAsA4wPDGFkyxWJVAw8o7f9DKoU1N4bKX0El/G/Jos LJQeL8XQWaWB9rJVpMWBHZukyS2VXbw2+dgR1gOhBUkQkdlJ3iB5l/c2o ife6c4/Lbu8c8Z8PFKT7BjO8JhLaCwYbNaucWiJBI+iCTQCww6GARzp4/ AxFFjdBF9f2/jjmMhBSSb+HjbqVX5bWh4GsfqLzjFjA/H0SJ3f2j9RnSn g==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="266635037" X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="266635037" X-IronPort-AV: E=Sophos;i="5.92,287,1650956400"; d="scan'208";a="656393886" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Date: Wed, 20 Jul 2022 14:47:29 -0400 Message-Id: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the vPMU state from a parent isn't copied to VM forks. To enable the vPMU state to be copied to a fork VM we export certain vPMU functions. First, the vPMU context needs to be allocated for the fork if the parent has one. For this we introduce vpmu->allocate_context, which has previously only been called when the guest enables the PMU on itself. Furthermore, we export vpmu_save_force so that the PMU context can be saved on-demand even if no context switch took place on the parent's CPU yet. Additionally, we make sure all relevant configuration MSRs are saved in the vPMU context so the copy is complete and the fork starts with the same PMU config as the parent. Signed-off-by: Tamas K Lengyel --- v2: make some things conditional on CONFIG_MEM_SHARING add stub function on AMD to vpmu_ops to simplify allocate context calls --- xen/arch/x86/cpu/vpmu.c | 14 ++++++++++- xen/arch/x86/cpu/vpmu_amd.c | 12 +++++++++ xen/arch/x86/cpu/vpmu_intel.c | 32 ++++++++++++++++++++---- xen/arch/x86/include/asm/vpmu.h | 17 +++++++++++++ xen/arch/x86/mm/mem_sharing.c | 44 +++++++++++++++++++++++++++++++++ 5 files changed, 113 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index d2c03a1104..cacc24a30f 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -336,7 +336,19 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs) #endif } -static void cf_check vpmu_save_force(void *arg) +#ifdef CONFIG_MEM_SHARING +int vpmu_allocate_context(struct vcpu *v) +{ + struct vpmu_struct *vpmu = vcpu_vpmu(v); + + if ( vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) + return 0; + + return alternative_call(vpmu_ops.allocate_context, v) ? 0 : -ENOMEM; +} +#endif + +void cf_check vpmu_save_force(void *arg) { struct vcpu *v = arg; struct vpmu_struct *vpmu = vcpu_vpmu(v); diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 9bacc02ec1..4c76e24551 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -518,6 +518,14 @@ static int cf_check svm_vpmu_initialise(struct vcpu *v) return 0; } +#ifdef CONFIG_MEM_SHARING +static int cf_check amd_allocate_context(struct vcpu *v) +{ + ASSERT_UNREACHABLE(); + return 0; +} +#endif + static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { .initialise = svm_vpmu_initialise, .do_wrmsr = amd_vpmu_do_wrmsr, @@ -527,6 +535,10 @@ static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { .arch_vpmu_save = amd_vpmu_save, .arch_vpmu_load = amd_vpmu_load, .arch_vpmu_dump = amd_vpmu_dump, + +#ifdef CONFIG_MEM_SHARING + .allocate_context = amd_allocate_context +#endif }; static const struct arch_vpmu_ops *__init common_init(void) diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index 8612f46973..01d4296485 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -282,10 +282,17 @@ static inline void __core2_vpmu_save(struct vcpu *v) for ( i = 0; i < fixed_pmc_cnt; i++ ) rdmsrl(MSR_CORE_PERF_FIXED_CTR0 + i, fixed_counters[i]); for ( i = 0; i < arch_pmc_cnt; i++ ) + { rdmsrl(MSR_IA32_PERFCTR0 + i, xen_pmu_cntr_pair[i].counter); + rdmsrl(MSR_P6_EVNTSEL(i), xen_pmu_cntr_pair[i].control); + } if ( !is_hvm_vcpu(v) ) rdmsrl(MSR_CORE_PERF_GLOBAL_STATUS, core2_vpmu_cxt->global_status); + /* Save MSR to private context to make it fork-friendly */ + else if ( mem_sharing_enabled(v->domain) ) + vmx_read_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + &core2_vpmu_cxt->global_ctrl); } static int cf_check core2_vpmu_save(struct vcpu *v, bool to_guest) @@ -346,6 +353,10 @@ static inline void __core2_vpmu_load(struct vcpu *v) core2_vpmu_cxt->global_ovf_ctrl = 0; wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, core2_vpmu_cxt->global_ctrl); } + /* Restore MSR from context when used with a fork */ + else if ( mem_sharing_is_fork(v->domain) ) + vmx_write_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + core2_vpmu_cxt->global_ctrl); } static int core2_vpmu_verify(struct vcpu *v) @@ -443,7 +454,7 @@ static int cf_check core2_vpmu_load(struct vcpu *v, bool from_guest) return 0; } -static int core2_vpmu_alloc_resource(struct vcpu *v) +static int cf_check core2_vpmu_alloc_resource(struct vcpu *v) { struct vpmu_struct *vpmu = vcpu_vpmu(v); struct xen_pmu_intel_ctxt *core2_vpmu_cxt = NULL; @@ -461,11 +472,18 @@ static int core2_vpmu_alloc_resource(struct vcpu *v) goto out_err; } - core2_vpmu_cxt = xzalloc_flex_struct(struct xen_pmu_intel_ctxt, regs, - fixed_pmc_cnt + arch_pmc_cnt * - (sizeof(struct xen_pmu_cntr_pair) / - sizeof(*core2_vpmu_cxt->regs))); + vpmu->priv_context_size = sizeof(uint64_t); + vpmu->context_size = sizeof(struct xen_pmu_intel_ctxt) + + fixed_pmc_cnt * sizeof(uint64_t) + + arch_pmc_cnt * sizeof(struct xen_pmu_cntr_pair); + /* Calculate and add the padding for alignment */ + vpmu->context_size += vpmu->context_size % + sizeof(struct xen_pmu_intel_ctxt); + + core2_vpmu_cxt = _xzalloc(vpmu->context_size, + sizeof(struct xen_pmu_intel_ctxt)); p = xzalloc(uint64_t); + if ( !core2_vpmu_cxt || !p ) goto out_err; @@ -889,6 +907,10 @@ static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = { .arch_vpmu_save = core2_vpmu_save, .arch_vpmu_load = core2_vpmu_load, .arch_vpmu_dump = core2_vpmu_dump, + +#ifdef CONFIG_MEM_SHARING + .allocate_context = core2_vpmu_alloc_resource +#endif }; const struct arch_vpmu_ops *__init core2_vpmu_init(void) diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index e5709bd44a..8a3ae11562 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -47,6 +47,10 @@ struct arch_vpmu_ops { int (*arch_vpmu_save)(struct vcpu *v, bool_t to_guest); int (*arch_vpmu_load)(struct vcpu *v, bool_t from_guest); void (*arch_vpmu_dump)(const struct vcpu *); + +#ifdef CONFIG_MEM_SHARING + int (*allocate_context)(struct vcpu *v); +#endif }; const struct arch_vpmu_ops *core2_vpmu_init(void); @@ -59,6 +63,8 @@ struct vpmu_struct { u32 hw_lapic_lvtpc; void *context; /* May be shared with PV guest */ void *priv_context; /* hypervisor-only */ + size_t context_size; + size_t priv_context_size; struct xen_pmu_data *xenpmu_data; spinlock_t vpmu_lock; }; @@ -108,6 +114,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs); void vpmu_initialise(struct vcpu *v); void vpmu_destroy(struct vcpu *v); void vpmu_save(struct vcpu *v); +void vpmu_save_force(void *arg); int vpmu_load(struct vcpu *v, bool_t from_guest); void vpmu_dump(struct vcpu *v); @@ -136,5 +143,15 @@ static inline void vpmu_switch_to(struct vcpu *next) vpmu_load(next, 0); } +#ifdef CONFIG_MEM_SHARING +int vpmu_allocate_context(struct vcpu *v); +#else +static inline int vpmu_allocate_context(struct vcpu *v) +{ + ASSERT_UNREACHABLE(); + return 0; +} +#endif + #endif /* __ASM_X86_HVM_VPMU_H_*/ diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 8f9d9ed9a9..f851b20938 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1653,6 +1653,46 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) hvm_set_nonreg_state(cd_vcpu, &nrs); } +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) +{ + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); + + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) + return 0; + if ( vpmu_allocate_context(cd_vcpu) ) + return -ENOMEM; + + /* + * The VPMU subsystem only saves the context when the CPU does a context + * switch. Otherwise, the relevant MSRs are not saved on vmexit. + * We force a save here in case the parent CPU context is still loaded. + */ + if ( vpmu_is_set(d_vpmu, VPMU_CONTEXT_LOADED) ) + { + int pcpu = smp_processor_id(); + + if ( d_vpmu->last_pcpu != pcpu ) + { + on_selected_cpus(cpumask_of(d_vpmu->last_pcpu), + vpmu_save_force, (void *)d_vcpu, 1); + vpmu_reset(d_vpmu, VPMU_CONTEXT_LOADED); + } else + vpmu_save(d_vcpu); + } + + if ( vpmu_is_set(d_vpmu, VPMU_RUNNING) ) + vpmu_set(cd_vpmu, VPMU_RUNNING); + + /* Make sure context gets (re-)loaded when scheduled next */ + vpmu_reset(cd_vpmu, VPMU_CONTEXT_LOADED); + + memcpy(cd_vpmu->context, d_vpmu->context, d_vpmu->context_size); + memcpy(cd_vpmu->priv_context, d_vpmu->priv_context, d_vpmu->priv_context_size); + + return 0; +} + static int copy_vcpu_settings(struct domain *cd, const struct domain *d) { unsigned int i; @@ -1702,6 +1742,10 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d) copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn); } + ret = copy_vpmu(d_vcpu, cd_vcpu); + if ( ret ) + return ret; + hvm_vmtrace_reset(cd_vcpu); copy_vcpu_nonreg_state(d_vcpu, cd_vcpu); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 20 19:27:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 19:27:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372237.604095 (Exim 4.92) (envelope-from ) id 1oEFLw-0005AP-3t; Wed, 20 Jul 2022 19:27:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372237.604095; Wed, 20 Jul 2022 19:27:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEFLw-0005AI-05; Wed, 20 Jul 2022 19:27:24 +0000 Received: by outflank-mailman (input) for mailman id 372237; Wed, 20 Jul 2022 19:27:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEFLu-0005A8-Jw; Wed, 20 Jul 2022 19:27:22 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEFLu-0007u7-GO; Wed, 20 Jul 2022 19:27:22 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEFLu-0006c4-4c; Wed, 20 Jul 2022 19:27:22 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEFLu-0008RO-3i; Wed, 20 Jul 2022 19:27:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=JcLieXIxEJ6yg+OKhDOMOBZGonYxEYv4NAMMhR83afU=; b=yvKBpwaJwOI1pBDReTdxFpqmaR G1m5l+GH+LeEToBZqyMgIK2Q5ZVYrC7qWsTGasV+nW2lXPNqhkMrDZRlzMrQl6X0HRknsfAqM0gcB 1hwwED08yILICUUOKi0IFUWJdrfttkVfIUOGOhGfop0K3oVtf1Nhkmycwccv04eBGe0I=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171704: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-libvirt-xsm:xen-install:fail:heisenbug qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=68e26e1e812c8b09313d7929271f6cbd47ef4c07 X-Osstest-Versions-That: qemuu=d48125de38f48a61d6423ef6a01156d6dff9ee2c From: osstest service owner Date: Wed, 20 Jul 2022 19:27:22 +0000 flight 171704 qemu-mainline real [real] flight 171707 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171704/ http://logs.test-lab.xenproject.org/osstest/logs/171707/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt-xsm 7 xen-install fail pass in 171707-retest Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-xsm 15 migrate-support-check fail in 171707 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171693 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171693 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171693 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171693 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171693 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171693 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171693 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171693 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 68e26e1e812c8b09313d7929271f6cbd47ef4c07 baseline version: qemuu d48125de38f48a61d6423ef6a01156d6dff9ee2c Last test of basis 171693 2022-07-19 21:08:50 Z 0 days Testing same since 171704 2022-07-20 11:08:20 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Peter Maydell Philippe Mathieu-Daudé Richard Henderson Song Gao Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm fail test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git d48125de38..68e26e1e81 68e26e1e812c8b09313d7929271f6cbd47ef4c07 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 20 20:12:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 20:12:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372291.604124 (Exim 4.92) (envelope-from ) id 1oEG3K-0004GC-8t; Wed, 20 Jul 2022 20:12:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372291.604124; Wed, 20 Jul 2022 20:12:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEG3K-0004G5-60; Wed, 20 Jul 2022 20:12:14 +0000 Received: by outflank-mailman (input) for mailman id 372291; Wed, 20 Jul 2022 20:12:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEG3J-0004Fw-2F for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 20:12:13 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3b74536f-0868-11ed-924f-1f966e50362f; Wed, 20 Jul 2022 22:12:11 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id AA9E43200495; Wed, 20 Jul 2022 16:12:06 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 20 Jul 2022 16:12:07 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Jul 2022 16:12:04 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3b74536f-0868-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658347926; x= 1658434326; bh=84itqUMajeqYwj5llAtvXiSFE04XLiuJMB4+T3BZ0gk=; b=K xAunL5+xyG5B/KdhqnknPhILJ2iLgrP94ghEeOt0UWl5W38x5II9c4hL9vwPye3r 2dNmirfnqC3llgf6Awti0tbkyk670ZS5CaHxoWD8Pbne6b4KiSq3IFPy+TkJW34b oZS51/ZZkWPat05oklQHS97RdPLif+z/uuxGuNmRiYmxF+ylU6zqcQJ2s1UDaW7b VM1+cLiG5egPTj7bUvD7gIbjOfJ6CplAXMfrRbGMy1998LLZ1hF3Wt008nIH/4z2 AZ/9zyPzCt/kxtazJ1v0VFy6s20lG869bLUnJsmCilEPXdDJnZKACnawdsuB7L6N AgWuWggHzfKfYSxPXBHyg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658347926; x=1658434326; bh=84itqUMajeqYwj5llAtvXiSFE04X LiuJMB4+T3BZ0gk=; b=ntbMfc8sUp/ABJlF+IqoGOz70IXTxTyOk8cWTKByPbyZ NgnDFJvcZV5izL6uBCe/YmWVYdnILhM/Woq2heEjewMLwvKy9Ebzv8Kty/fRQmkh KwD3E2QcxNliUDZ2Hu/zmiAeQY0tz/VdlFgz1QKdvi6/yDYOMmaSQE3DYBRchdag hSrQeLU5urjumJ6MK+hyx1U0OWFBPDkY2ST9jdpC09y9oPVp/CzrkQVubALB9tyC FzSxHTMhQJeyY8hGWxfjLw6q/7IRlP5GNBTiirxhtLajoNXEZcCqWbjNlAMR0F0+ hHTwmGKjcnkbwo+1epuG+ww22tswE1IK9rS5figAYQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelvddgudegkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtdorredttdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedt tedvhfekudetvdelffeguedtkeethfethfffhfefteeghfeigeelvddttdektdenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 20 Jul 2022 22:12:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Message-ID: References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="gmazUWtArVsxmRsl" Content-Disposition: inline In-Reply-To: --gmazUWtArVsxmRsl Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 20 Jul 2022 22:12:01 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , xen-devel@lists.xenproject.org, Connor Davis Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > +static int xue_init_dbc(struct xue *xue) > > +{ > > + uint64_t erdp =3D 0; > > + uint64_t out =3D 0; > > + uint64_t in =3D 0; > > + uint64_t mbs =3D 0; > > + struct xue_dbc_reg *reg =3D xue_find_dbc(xue); > > + > > + if ( !reg ) > > + return 0; > > + > > + xue->dbc_reg =3D reg; > > + xue_disable_dbc(xue); > > + > > + xue_trb_ring_init(xue, &xue->dbc_ering, 0, XUE_DB_INVAL); > > + xue_trb_ring_init(xue, &xue->dbc_oring, 1, XUE_DB_OUT); > > + xue_trb_ring_init(xue, &xue->dbc_iring, 1, XUE_DB_IN); > > + > > + erdp =3D virt_to_maddr(xue->dbc_ering.trb); > > + if ( !erdp ) > > + return 0; > > + > > + memset(xue->dbc_erst, 0, sizeof(*xue->dbc_erst)); > > + xue->dbc_erst->base =3D erdp; > > + xue->dbc_erst->size =3D XUE_TRB_RING_CAP; > > + > > + mbs =3D (reg->ctrl & 0xFF0000) >> 16; > > + out =3D virt_to_maddr(xue->dbc_oring.trb); > > + in =3D virt_to_maddr(xue->dbc_iring.trb); > > + > > + memset(xue->dbc_ctx, 0, sizeof(*xue->dbc_ctx)); > > + xue_init_strings(xue, xue->dbc_ctx->info); > > + xue_init_ep(xue->dbc_ctx->ep_out, mbs, xue_ep_bulk_out, out); > > + xue_init_ep(xue->dbc_ctx->ep_in, mbs, xue_ep_bulk_in, in); > > + > > + reg->erstsz =3D 1; > > + reg->erstba =3D virt_to_maddr(xue->dbc_erst); > > + reg->erdp =3D erdp; > > + reg->cp =3D virt_to_maddr(xue->dbc_ctx); >=20 > The only place this field is read looks to be xue_dump(). No, reg is MMIO, all those assignments are actually configuring the device. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --gmazUWtArVsxmRsl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLYYZIACgkQ24/THMrX 1ywEvgf+PCnLYL2uWM9r9NN4JiRqxuxl6rzWgvOJTiJg7KKOjDypZtAqElL3otjA 00bxs1eRdzPupmUJ0K26dZTNtlMOOMRU4SSuWWK/VOUnwMPFqIQl0G9ZprGI0pO7 wCz6sae1atCT9YP5ijlSUw9ss4+SURYwxu2NtoAwMHvWSLLVLi7zVCIfAI+x6HtO lFcIBtK0dZG2Nx7oEUubJNmn1C8nq4dtlQv++zYllhEqP7R6B7kATR7rDCSjQwGd ziPWSn8flfuxfGnx7etxE85EbNzwW9Qs1Szw7XE3U0rpJt5zYYxzrhwPDXi0FbNQ 0P96sEM/lrMo61E7jDPXpwiFm+8aRw== =2BSg -----END PGP SIGNATURE----- --gmazUWtArVsxmRsl-- From xen-devel-bounces@lists.xenproject.org Wed Jul 20 20:18:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 20:18:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372298.604135 (Exim 4.92) (envelope-from ) id 1oEG91-00052b-Tw; Wed, 20 Jul 2022 20:18:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372298.604135; Wed, 20 Jul 2022 20:18:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEG91-00052U-R2; Wed, 20 Jul 2022 20:18:07 +0000 Received: by outflank-mailman (input) for mailman id 372298; Wed, 20 Jul 2022 20:18:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEG90-00052O-AX for xen-devel@lists.xenproject.org; Wed, 20 Jul 2022 20:18:06 +0000 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0ea0037f-0869-11ed-bd2d-47488cf2e6aa; Wed, 20 Jul 2022 22:18:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 2D5F732005C1; Wed, 20 Jul 2022 16:18:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 20 Jul 2022 16:18:01 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 20 Jul 2022 16:17:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0ea0037f-0869-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658348280; x= 1658434680; bh=HVYsngPy5VNH6lbULNvEzsWa3kU3SKBpPH9qjsV1bAI=; b=x lZ/MtMo/5DywHqlZsbIPWtnvVukotEL0unwcvH0c+jle2bUHM38wRGQLe1/HYFjD 8GZwLsIDb8Kx/0Bd82gayb37GNedFmdoNer0xZilVhPnsbIEzJZJxr4rIHGc0Bbr zzeyEXl290FSGaXEwyo8ofSLto+b6fPL2ocxUE93AvJ1zhGveeCTA8NzF325+x6s a3Ge9zIuy/6DNWo2qj1L59SHV/9bHA5KeSgao2qBvnzqfO+Rv0viRJ1CxGCO5C+2 xBXlc6tSaIuNnMmUC2maWmLst5EEdgoPtvTBHpWevbsLpuUXZRyQcTsATlVY+EW7 zzHJAxC0DBVQ1Lm0gmRxQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658348280; x=1658434680; bh=HVYsngPy5VNH6lbULNvEzsWa3kU3 SKBpPH9qjsV1bAI=; b=x18k/06QPP3t/50/Nmzdg2WPjem/zCyhznGLS7ovr8VD bm0wUP8oz6CZ4FWtzFlvnkSohCbJAJkby679SQp2On1ZYm17YrUk6AeSZnOFr1ub a/cC/pHkdS4Uv5CkZOVQ5T50H/tmyfrkA3jjaLLyGTVzGu1AcOZRwCMtwEmJFFaN vMVEySfrJO2uvCu6Lyv8o6tLlO7/n1LM8DWtKQV/7CjnJN7WJZl85tUO/Ruiglpi KI4j5tGPeQ3R07fxocvEpIBhQMukEE9p8TMYrHzWv6QYkvCw5Bde1SweMT5cpxZ+ 3uyveiwas0l6ElAb6C2YmecwKwJVlHrNnlumfIZpvw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudelvddgudehtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg udelteefvefhfeehieetleeihfejhfeludevteetkeevtedtvdegueetfeejudenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Wed, 20 Jul 2022 22:17:56 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Message-ID: References: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="0bWZJS4AZ60thrwW" Content-Disposition: inline In-Reply-To: --0bWZJS4AZ60thrwW Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Wed, 20 Jul 2022 22:17:56 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device On Thu, Jul 14, 2022 at 01:51:06PM +0200, Jan Beulich wrote: > On 06.07.2022 17:32, Marek Marczykowski-G=C3=B3recki wrote: > > + /* > > + * Don't place anything else on this page - it will be > > + * DMA-reachable by the USB controller. > > + */ > > + char _pad[0] __aligned(XUE_PAGE_SIZE); >=20 > I don't think this is needed, due to sizeof() being required to be > a multiple of alignof(). I'd prefer to be explicit about this, because if some future change breaks this property (makes alignment smaller than a page size), the result will be pretty bad. > > +}; > > +static struct xue_dma_bufs xue_dma_bufs __aligned(XUE_PAGE_SIZE); >=20 > I don't think the alignment here is needed, as the struct will > already have suitable alignment (derived from the biggest field > alignment value). Instead please consider putting this in > .bss.page_aligned. Ok. > > @@ -990,16 +999,22 @@ void __init xue_uart_init(void) > > xue->sbdf =3D PCI_SBDF(0, bus, slot, func); > > } > > =20 > > - xue->dbc_ctx =3D &ctx; > > - xue->dbc_erst =3D &erst; > > - xue->dbc_ering.trb =3D evt_trb; > > - xue->dbc_oring.trb =3D out_trb; > > - xue->dbc_iring.trb =3D in_trb; > > - xue->dbc_owork.buf =3D wrk_buf; > > - xue->dbc_str =3D str_buf; > > + xue->dbc_ctx =3D &xue_dma_bufs.ctx; > > + xue->dbc_erst =3D &xue_dma_bufs.erst; > > + xue->dbc_ering.trb =3D xue_dma_bufs.evt_trb; > > + xue->dbc_oring.trb =3D xue_dma_bufs.out_trb; > > + xue->dbc_iring.trb =3D xue_dma_bufs.in_trb; > > + xue->dbc_owork.buf =3D xue_dma_bufs.wrk_buf; > > + xue->dbc_str =3D xue_dma_bufs.str_buf; > > =20 > > if ( xue_open(xue) ) > > + { > > + iommu_add_extra_reserved_device_memory( > > + PFN_DOWN(virt_to_maddr(&xue_dma_bufs)), >=20 > virt_to_pfn()? Doesn't exist. Did you mean virt_to_mfn()? --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --0bWZJS4AZ60thrwW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLYYvQACgkQ24/THMrX 1yzCrQf+KvN50WPUxk1WKxBLMBLU9Y/jLp1Cq8vyIgKQKqomIRBkSq4wqgtuXDUM NbOEvuDqrueDvs3l6bDaYLRhdFvZYyngKi+kn7AHUK0DlguP0Qq+ul5PRkPYzWN3 3FR05YYPeZR9muNh/mu6XZdVFwrhNOCTJ5WBLYyyFQux8btz/pnuXHLdqTeoqRnd b8TXwLAMMA5Y8rrxPy5h9b02AxFjTircaw9bDVk7hKWJrP2tzYCGSGeuZGgHiwN3 /p0vm3hpGj1i6xr1/3XSWY5pjhS/yAK3nyYbS5dKLaVGdtsxDb8k3/oSdEfCw4HM q/JupD1gQtWKCUopunCZffhLu4YC8w== =CCfM -----END PGP SIGNATURE----- --0bWZJS4AZ60thrwW-- From xen-devel-bounces@lists.xenproject.org Wed Jul 20 22:34:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 22:34:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372427.604199 (Exim 4.92) (envelope-from ) id 1oEIH1-0000eX-SY; Wed, 20 Jul 2022 22:34:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372427.604199; Wed, 20 Jul 2022 22:34:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIH1-0000eQ-Pt; Wed, 20 Jul 2022 22:34:31 +0000 Received: by outflank-mailman (input) for mailman id 372427; Wed, 20 Jul 2022 22:34:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIH0-0000eG-7c; Wed, 20 Jul 2022 22:34:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIH0-0002m5-5h; Wed, 20 Jul 2022 22:34:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIGz-00026l-LH; Wed, 20 Jul 2022 22:34:29 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEIGz-0001Nu-Kp; Wed, 20 Jul 2022 22:34:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4ydjkivqPjzaRqHFa42uMFs9h7WaPEtjTw6wQFX/Z4c=; b=Mufj1O3JLOn+rCNh4FOh6Re4+Z 37VUQH7cjbaLIfwvJOCLLgq1z8jjbx/p8MOsOb6LhrMDGBcHXi6Ci5EHBknoHmjJvotSLPE5xDCLs TI+W24oW/v0/3Sxv5JBAzL6ToooOMbtuEPwro++pDTcATd7ZbIlNVVE4kofFinQlLLhc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171708: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 X-Osstest-Versions-That: xen=6fe2e39a0243bddba60f83b77b972a5922d25eb8 From: osstest service owner Date: Wed, 20 Jul 2022 22:34:29 +0000 flight 171708 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171708/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 baseline version: xen 6fe2e39a0243bddba60f83b77b972a5922d25eb8 Last test of basis 171705 2022-07-20 14:01:52 Z 0 days Testing same since 171708 2022-07-20 19:01:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Hongyan Xia Jan Beulich Julien Grall Oleksandr Tyshchenko Stefano Stabellini jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6fe2e39a02..d2cc5633e2 d2cc5633e2800e698c6a64554de7fa19d9627a24 -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jul 20 22:36:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 22:36:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372434.604211 (Exim 4.92) (envelope-from ) id 1oEIIf-0001Dm-8L; Wed, 20 Jul 2022 22:36:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372434.604211; Wed, 20 Jul 2022 22:36:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIIf-0001Df-5j; Wed, 20 Jul 2022 22:36:13 +0000 Received: by outflank-mailman (input) for mailman id 372434; Wed, 20 Jul 2022 22:36:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIId-0001DT-HC; Wed, 20 Jul 2022 22:36:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIId-0002p2-Ea; Wed, 20 Jul 2022 22:36:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEIIc-0002Cq-V6; Wed, 20 Jul 2022 22:36:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEIIc-0004Lb-Ud; Wed, 20 Jul 2022 22:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jY9bft7TRhPT9c64YY55gWuP/7Drs3eiL5Gtnl6Adf8=; b=OYaFN2R2UoSSon7h1LW/50zAJG 7qk4bDNawwjQhbFKuEagnKHuhOYYmI51Axb5rcdx1JRGE3Si7ye1dhDp39hN/NwGKI9nt6ad66aMJ Q8DPmHO3QWeQYE/hq/I75wn/L1PqVaAoFtwbhBlLriWE9rzSXJ/H1SS4p/gHNW3uhva0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171710: all pass - PUSHED X-Osstest-Versions-This: ovmf=3b8cee1781c4149c7a762b8a1c8115b635cf4cad X-Osstest-Versions-That: ovmf=48249243777882d7d89ca0b86c89e355b5f941f3 From: osstest service owner Date: Wed, 20 Jul 2022 22:36:10 +0000 flight 171710 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171710/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3b8cee1781c4149c7a762b8a1c8115b635cf4cad baseline version: ovmf 48249243777882d7d89ca0b86c89e355b5f941f3 Last test of basis 171703 2022-07-20 07:35:12 Z 0 days Testing same since 171710 2022-07-20 19:10:52 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Gary Lin jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 4824924377..3b8cee1781 3b8cee1781c4149c7a762b8a1c8115b635cf4cad -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 20 23:21:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 20 Jul 2022 23:21:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372485.604240 (Exim 4.92) (envelope-from ) id 1oEJ0h-0000PR-7q; Wed, 20 Jul 2022 23:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372485.604240; Wed, 20 Jul 2022 23:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEJ0h-0000PK-3w; Wed, 20 Jul 2022 23:21:43 +0000 Received: by outflank-mailman (input) for mailman id 372485; Wed, 20 Jul 2022 23:21:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEJ0f-0000PA-Fi; Wed, 20 Jul 2022 23:21:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEJ0f-0003eB-Aw; Wed, 20 Jul 2022 23:21:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEJ0e-00050S-IT; Wed, 20 Jul 2022 23:21:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEJ0e-00013u-I2; Wed, 20 Jul 2022 23:21:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qORu6W9COVGBcd5Nk5ZKW7KQtSAiz44HFfSR3kswPhI=; b=Na7VrNTlYJwOeZ1b30rFI8uDn5 AruI5HxlGe48+a4II4zH4n9F7IUemlp0pycpK3n6CZyjQ7XCBq6wFL6nauv0rLBFWMmMWgMi7b9Cy jaPokd9CsIgEubG5zaTe/Vc9mPIs5T7cqJtFKYzE6fmPVMYwKmmQikqcF8ts1UdAtrAE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171706: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-rtds:guest-localmigrate/x10:fail:allowable xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=6fe2e39a0243bddba60f83b77b972a5922d25eb8 X-Osstest-Versions-That: xen=c16a9eda77b2089206d5bc39ab6488c3793e11bf From: osstest service owner Date: Wed, 20 Jul 2022 23:21:40 +0000 flight 171706 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171706/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-amd64-amd64-xl-rtds 20 guest-localmigrate/x10 fail REGR. vs. 171702 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171702 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171702 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171702 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171702 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171702 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171702 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171702 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171702 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171702 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171702 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171702 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171702 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171702 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen 6fe2e39a0243bddba60f83b77b972a5922d25eb8 baseline version: xen c16a9eda77b2089206d5bc39ab6488c3793e11bf Last test of basis 171702 2022-07-20 06:09:55 Z 0 days Testing same since 171706 2022-07-20 16:39:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds fail test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git c16a9eda77..6fe2e39a02 6fe2e39a0243bddba60f83b77b972a5922d25eb8 -> master From xen-devel-bounces@lists.xenproject.org Thu Jul 21 02:09:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 02:09:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372501.604259 (Exim 4.92) (envelope-from ) id 1oELdC-0002lF-Jw; Thu, 21 Jul 2022 02:09:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372501.604259; Thu, 21 Jul 2022 02:09:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oELdC-0002l7-EX; Thu, 21 Jul 2022 02:09:38 +0000 Received: by outflank-mailman (input) for mailman id 372501; Thu, 21 Jul 2022 02:09:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oELdB-0002kx-B1; Thu, 21 Jul 2022 02:09:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oELdB-0005yB-8E; Thu, 21 Jul 2022 02:09:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oELdA-0005jS-M3; Thu, 21 Jul 2022 02:09:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oELdA-0002ny-LK; Thu, 21 Jul 2022 02:09:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=M8V2H0YBhF77Vz/CKMLseD15e0hIBlmJpJYydinQ/qQ=; b=oVNHU8NOtY3T3WOiSZP/l8ma1i gRceSM0BYmORQvb/wmwSWb6JevaVY5oMpcMGlws1MVjtZovT6zAlJp6ZGbKr1emnwejcIzqZTFikb VO7aTt8sMjvR3UNpVaLC3J4w7FaTnGukIrJpXdUv10lJPDfzNwbBEyWQHtxTueq6Rk80=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171709: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=353f7988dd8413c47718f7ca79c030b6fb62cfe5 X-Osstest-Versions-That: linux=ca85855bdcae8f84f1512e88b4c75009ea17ea2f From: osstest service owner Date: Thu, 21 Jul 2022 02:09:36 +0000 flight 171709 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171709/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171681 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171681 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171681 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171681 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171681 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171681 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171681 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171681 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 353f7988dd8413c47718f7ca79c030b6fb62cfe5 baseline version: linux ca85855bdcae8f84f1512e88b4c75009ea17ea2f Last test of basis 171681 2022-07-19 04:40:23 Z 1 days Testing same since 171709 2022-07-20 19:10:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Eric Snowberg Linus Torvalds Mimi Zohar jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git ca85855bdcae..353f7988dd84 353f7988dd8413c47718f7ca79c030b6fb62cfe5 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Jul 21 04:55:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 04:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372511.604270 (Exim 4.92) (envelope-from ) id 1oEODX-0006UN-Ei; Thu, 21 Jul 2022 04:55:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372511.604270; Thu, 21 Jul 2022 04:55:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEODX-0006UG-C4; Thu, 21 Jul 2022 04:55:19 +0000 Received: by outflank-mailman (input) for mailman id 372511; Thu, 21 Jul 2022 04:55:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEODV-0006UA-Da for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 04:55:18 +0000 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4aef3166-08b1-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 06:55:12 +0200 (CEST) Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20220721045506epoutp0475efa8cf24bd9c6fdb6349eaeb01ff14~DvzFx4dnF1716917169epoutp04C for ; Thu, 21 Jul 2022 04:55:06 +0000 (GMT) Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20220721045506epcas2p19a5a6e43a60d70d776374408f3cd094f~DvzFebk7Q2343123431epcas2p1K; Thu, 21 Jul 2022 04:55:06 +0000 (GMT) Received: from epsmges2p1.samsung.com (unknown [182.195.36.99]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LpKxk1xnCz4x9Pt; Thu, 21 Jul 2022 04:55:06 +0000 (GMT) Received: from epcas2p4.samsung.com ( [182.195.41.56]) by epsmges2p1.samsung.com (Symantec Messaging Gateway) with SMTP id 2C.50.09666.A2CD8D26; Thu, 21 Jul 2022 13:55:06 +0900 (KST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 4aef3166-08b1-11ed-bd2d-47488cf2e6aa DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20220721045506epoutp0475efa8cf24bd9c6fdb6349eaeb01ff14~DvzFx4dnF1716917169epoutp04C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1658379306; bh=8avSVaAGQwd9NkBvEJQbIBUBOKIKAkZ/2iA/oLTj4OM=; h=Subject:Reply-To:From:To:CC:Date:References:From; b=g154ghupio7vDYcN8D2iL4yY0xv6BWk+BRdj53P8KCYsVVU+q7w+GpjmkRxsgseem hxJZCeSLAp/x+BtaKlzXAUrwVfzqFBmQokXzTyrpcRgoWb9Xy1sDBxFeo5Um/Fzm/8 NUSGzHcDbo7+zbCAwnN1WLQVAbKJcCRb2/cu28Co= X-AuditID: b6c32a45-471ff700000025c2-1f-62d8dc2ae8aa Mime-Version: 1.0 Subject: RE: Re: [Question] Alternative Method for git send-email Reply-To: boyoun.park@samsung.com Sender: Boyoun Park From: Boyoun Park To: "jbeulich@suse.com" CC: "xen-devel@lists.xenproject.org" X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: DesktopMessage X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20220721045505epcms2p80d1fd948061d5a6a74324caa78191e74@epcms2p8> Date: Thu, 21 Jul 2022 13:55:05 +0900 X-CMS-MailID: 20220721045505epcms2p80d1fd948061d5a6a74324caa78191e74 Content-Type: multipart/related; boundary="----=_Part_7316330_1348192298.1658379305930" X-Sendblock-Type: AUTO_CONFIDENTIAL X-CPGSPASS: Y X-CPGSPASS: Y CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEKsWRmVeSWpSXmKPExsWy7bCmha7WnRtJBqf2c1q8PKRp8XPPQzaL 71smMzkwexz+cIXFo2/LKkaP9VuusgQwR2XbZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjq GlpamCsp5CXmptoqufgE6Lpl5gAtUlIoS8wpBQoFJBYXK+nb2RTll5akKmTkF5fYKqUWpOQU mBfoFSfmFpfmpevlpZZYGRoYGJkCFSZkZ/xo+cNa8F+n4tXrvAbGR9pdjJwcEgImEl2H/rOC 2EICOxglel94djFycPAKCEr83SEMEhYWcJR4fH4nE0SJokTrmYXsEHFdiZ6uvWwgNpuAtsSL m7dYQGwRIHtz9zFGEJtZwFXiydPLTBCreCVmtD9lgbClJbYv38oIYWtI/FjWywxhi0rcXP2W HcKWl+iaMhuqRkSi9d5ZqBpBiQc/d0PFpSQaPx2Cqi+WmNO3HsjmArIbGCVuXrwItVhfYkrL HLAfeQV8JVY8vgFmswioSpzsPgE11EVi4dkvzCC/MwtESlxdxgRiSggoSxy5xQJzfsPG3+zo bGYBPomOw3/h4jvmPYHaqirxq+kFI8y7e862Q9keEj2/zzBPYFSchQjoWQh7Z4ENVZSY0v2Q HcLWkGidM5d9ASPLKkax1ILi3PTUYqMCQ3gsJ+fnbmIEJz4t1x2Mk99+0DvEyMTBeIhRgoNZ SYT3aeH1JCHelMTKqtSi/Pii0pzU4kOMpkDfT2SWEk3OB6bevJJ4QxNLAxMzM0NzI1MDcyVx Xq+UDYlCAumJJanZqakFqUUwfUwcnFINTAaLz/BZKGm49T2zifkle07g+n71aJ6fW6ISj8/4 dGOn6Zn/5VN6Dr2dVMullLl2/4WkfdxT7Bb8vSqh9n7RQ62r716b6WbIGndJt/x5anGpRUqE Ians6uF55asfZrfs9NGPXLj8WFvisRW7LA4wO8mqv2Bk9lb5l3HOPoF76wvPmSvOqfZmOzr3 1LxMN605mioofPhfzHdDrdi/vLcf8+6boW/4tzfrZrhLf43qji0OsrKH39+Ldf9gdd+jIbHj RF9O0H7LDRfafRrDdbWq5A6c+/Tls8rPb65WF4VabVYWmCtuN7xppvLW0exHTpnQ20vON7fd aLyreZJ9i+P3PV/eSM68cF37k/5dTZY7B5VYijMSDbWYi4oTARu2h7UFBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220721045505epcms2p80d1fd948061d5a6a74324caa78191e74 References: ------=_Part_7316330_1348192298.1658379305930 Content-Transfer-Encoding: base64 Content-Type: text/html; charset="utf-8" PG1ldGEgY2xhc3M9ImN1aS1jb250ZW50LWRlZmF1bHQiIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlw ZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PVVURi04Ij4NCjxzdHlsZSBjbGFzcz0iY3Vp LWNvbnRlbnQtZGVmYXVsdCIgZGF0YS1jYWZlLWRlZmF1bHQ9InRydWUiIHR5cGU9InRleHQvY3Nz Ij4vKiEgY2FmZSBub3RlIHYyLjIuMjQgfCBDb3B5cmlnaHQgMjAxNCwgUy1Db3JlLCBJbmMuIEFs bCBSaWdodCBSZXNlcnZlZC4gKi8NCkBjaGFyc2V0ICJVVEYtOCI7Ym9keXtkaXNwbGF5OmJsb2Nr O21hcmdpbjoxMHB4O31ib2R5IG9sLGJvZHkgdWx7bWFyZ2luOjA7cGFkZGluZy1sZWZ0OjQwcHg7 fWJvZHkgcCxib2R5IGxpe2xpbmUtaGVpZ2h0OjEuOTttYXJnaW46MCBhdXRvO310YWJsZS5jdWkt ZGl2e3dpZHRoOjEwMCU7ZGlzcGxheTpibG9jazt9dGFibGUuY3VpLWRpdiA+IHRib2R5e2Rpc3Bs YXk6YmxvY2s7fXRhYmxlLmN1aS1kaXYgPiB0Ym9keSA+IHRye2Rpc3BsYXk6YmxvY2s7fXRhYmxl LmN1aS1kaXYgPiB0Ym9keSA+IHRyID4gdGQsdGFibGUuY3VpLWRpdiA+IHRib2R5ID4gdHIgPiB0 aHtkaXNwbGF5OmJsb2NrO310YWJsZS5jdWktcGFzdGVkLXRhYmxlIHRoLHRhYmxlLmN1aS1wYXN0 ZWQtdGFibGUgdGQsdGFibGUuY3VpLXBhc3RlZC10YWJsZSBwLHRhYmxlLmN1aS1wYXN0ZWQtdGFi bGUgaDEsdGFibGUuY3VpLXBhc3RlZC10YWJsZSBoMix0YWJsZS5jdWktcGFzdGVkLXRhYmxlIGgz LHRhYmxlLmN1aS1wYXN0ZWQtdGFibGUgaDQsdGFibGUuY3VpLXBhc3RlZC10YWJsZSBoNSx0YWJs ZS5jdWktcGFzdGVkLXRhYmxlIGg2LHRhYmxlLmN1aS1wYXN0ZWQtdGFibGUgbGl7bGluZS1oZWln aHQ6bm9ybWFsO31pbWdbZGF0YS1jdWktYWx0LWltYWdlXSxkaXZbZGF0YS1jdWktYWx0LWltYWdl XXtiYWNrZ3JvdW5kOnVybCgiZGF0YTppbWFnZS9wbmc7YmFzZTY0LGlWQk9SdzBLR2dvQUFBQU5T VWhFVWdBQUFCWUFBQUFVQ0FZQUFBQ0pmTTB3QUFBQkgwbEVRVlE0amJYVTI2cUVJQlFHWUYrd3R4 TE1nZzRRZEdkQlJFVWhGRUZCQngvdG42c0dwY1BlelRUQ0FpLzBRMTFyU1FnaGhER0dKNFA4QW4z ajIwUUlnU3pMdm9va1NmYXdVZ3JydWtJcDlWVmN3a0lJY003aCt6NjZybnNHYnByR2VDdmY5NStC OHp3M1lNNzVNL0E0am5BY0IzcFM5WTN6UEtQdiswdllLRGY5amNkeFJKN25hSnJHMkRSTkU4SXdC R01NWlZrZXdtUWJPbndWeTdJZ2lxTDNUV3piUnR1MngrZ1ZuS1lwWE5kRjI3WlkxeFZ4SE8rYXdI VmRETU1BS2FXSm5zRlpsaGtuOHp6dnRNT0NJQUNsMU5vOFNxbTFTNTVTQ2tWUjNHcmRJM1FIMTNW OS83UFJ4bUc1U1NsaDIvYkhLR01NVlZYdFljNzViWlJTYXVuWDF3OTIrOXZVVDZtanUzV2ZKdXF2 di96ZjhGbVpYcTcvQmZvQ0ExVlJzdks0QWZnQUFBQUFTVVZPUks1Q1lJST0iKSBuby1yZXBlYXQg Y2VudGVyICNjMWMxYzE7fV86LW1zLWxhbmcoeCksdGFibGUgdHI6bm90KDpmaXJzdC1jaGlsZCkg dGRbY29sc3Bhbl17Ym9yZGVyLXRvcC1zdHlsZTpub25lXDkgIWltcG9ydGFudDt9XzotbXMtbGFu Zyh4KSx0YWJsZSB0cjpub3QoOmZpcnN0LWNoaWxkKSB0aFtjb2xzcGFuXXtib3JkZXItdG9wLXN0 eWxlOm5vbmVcOSAhaW1wb3J0YW50O31fOjpzZWxlY3Rpb24sYm9keSxib2R5ICp7d29yZC13cmFw OmJyZWFrLXdvcmRcMDt9DQo8L3N0eWxlPg0KPHN0eWxlIGNsYXNzPSJjdWktY29udGVudC1kZWZh dWx0IiBkYXRhLXVzZXItY29uZmlnPSJ0cnVlIiB0eXBlPSJ0ZXh0L2NzcyI+Ym9keSB7bWFyZ2lu OiAwOyBmb250LXNpemU6IDEwcHQ7IGZvbnQtZmFtaWx5Oifrp5HsnYAg6rOg65SVJzsgbGluZS1o ZWlnaHQ6MS45O30NCmJvZHksYm9keSBwLGJvZHkgbGksYm9keSBoMSxib2R5IGgyLCBib2R5IGgz LGJvZHkgaDQsYm9keSBoNSxib2R5IGg2IHtmb250LWZhbWlseTon66eR7J2AIOqzoOuUlSc7IGxp bmUtaGVpZ2h0OjEuOTt9DQo8L3N0eWxlPg0KPHA+SSByZWFsbHkgYXBwcmVjaWF0ZSB5b3VyIGtp bmQgcmVwbHkuPC9wPg0KDQo8cD5JJiMzOTttIHN0aWxsJm5ic3A7bG9va2luZyBmb3ImbmJzcDth IHBvc3NpYmxlIG1ldGhvZCB0byBzZW5kJm5ic3A7dmlhIGdpdCBzZW5kLWVtYWlsLjwvcD4NCg0K PHA+SWYgSSBjYW5ub3QgZmluZCBhbiBhcHByb3ByaWF0ZSBtZXRob2QsIEkgd2lsbCBzZW5kIGEg cGF0Y2gmbmJzcDthcyBhbiBhdHRhY2htZW50IGFuZCBjb250ZW50Jm5ic3A7aW4gdGhlIG1haWwu PC9wPg0KDQo8cD5UaGFuayB5b3Ugc28gbXVjaC48L3A+DQoNCjxwPiZuYnNwOzwvcD4NCg0KPHA+ QmVzdCBSZWdhcmRzLDwvcD4NCg0KPHA+Qm8geW91biBQYXJrLjwvcD4NCg0KPHA+Jm5ic3A7PC9w Pg0KDQo8cD4tLS0tLS0tLS0gPGI+T3JpZ2luYWwgTWVzc2FnZTwvYj4gLS0tLS0tLS0tPC9wPg0K PCEtLSDtmY3quLjrj5k8MTIyM0BzYW1zdW5nLmNvbT4g7ISg7J6EL+qwnOuwnOq3uOujuShTQ1/s nbjtirjrnbzrhLcpL+yCvOyEsVNEUyAtLT4NCg0KPHA+PGI+U2VuZGVyPC9iPiA6IEphbiBCZXVs aWNoPGpiZXVsaWNoQHN1c2UuY29tPiA8L2piZXVsaWNoQHN1c2UuY29tPjwvcD4NCjwhLS0gMjAx NS0xMC0xMiAyMTozNyAoR01UKzA5OjAwKSAtLT4NCg0KPHA+PGI+RGF0ZTwvYj4gOiAyMDIyLTA2 LTEwIDE4OjM5IChHTVQrMDk6MDApPC9wPg0KDQo8cD48Yj5UaXRsZTwvYj4gOiBSZTogW1F1ZXN0 aW9uXSBBbHRlcm5hdGl2ZSBNZXRob2QgZm9yIGdpdCBzZW5kLWVtYWlsPC9wPg0KDQo8cD4mbmJz cDs8L3A+DQo8bWV0YSBodHRwLWVxdWl2PSJYLVVBLUNvbXBhdGlibGUiIGNvbnRlbnQ9IklFPWVk Z2UiPjxtZXRhIGh0dHAtZXF1aXY9ImNvbnRlbnQtdHlwZSIgY29udGVudD0idGV4dC9odG1sOyBj aGFyc2V0PVVURi04Ij4NCg0KPHByZT4NCk9uIDEwLjA2LjIwMjIgMTE6MzEsIOuwleuztOycpCB3 cm90ZToNCiZndDsgSGksIEkgd2FudCB0byBjb250cmlidXRlIHRvIFhlbiBQcm9qZWN0Lg0KJmd0 OyANCiZndDsgU28gSSB0cmllZCB0byBmb2xsb3cgdGhlIGNvbnRyaWJ1dGlvbiBndWlkZWxpbmVz IGZyb20gWGVuIFdpa2kuDQomZ3Q7IA0KJmd0OyBodHRwczovL3Byb3RlY3QyLmZpcmVleWUuY29t L3YxL3VybD9rPWYxMzZmODExLTkwYmRlZDI3LWYxMzc3MzVlLTc0ZmU0ODVmZmZlMC00OGI3MjAz MzcyMTc3ZDE4JmFtcDtxPTEmYW1wO2U9MmUzMWZiODQtNTNkNC00ODI4LWE5MmEtY2UxOWRiZTM2 MjIxJmFtcDt1PWh0dHBzJTNBJTJGJTJGd2lraS54ZW5wcm9qZWN0Lm9yZyUyRndpa2klMkZTdWJt aXR0aW5nX1hlbl9Qcm9qZWN0X1BhdGNoZXMgDQomZ3Q7IDxodHRwczogdXJsPSIiPg0KJmd0OyAN CiZndDsgQnV0IEkgZm91bmQgdGhhdCBJIGNhbm5vdCB1c2Ugc210cCBzZXJ2ZXIgZGlyZWN0bHkg ZnJvbSBsaW51eCBkdWUgdG8gc2VjdXJpdHkgDQomZ3Q7IHBvbGljeSBmcm9tIHdvcmsuDQomZ3Q7 IA0KJmd0OyBUaGVyZWZvcmUsIEkgY2Fubm90IHNlbmQgcGF0Y2hlcyB0aHJvdWdoIGdpdCBzZW5k LWVtYWlsLg0KJmd0OyANCiZndDsgQ2FuIEkgYXNrIHdoZXRoZXIgdGhlcmUgaXMgYW55IGFsdGVy bmF0aXZlIG1ldGhvZCBmb3IgZ2l0IHNlbmQtZW1haWw/DQoNCldpdGggYSBwcm9wZXJseSBjb25m aWd1cmVkIGNsaWVudCAoYW5kIHRoZSBzZXJ2ZXIgc2lkZSBub3QgZmlkZGxpbmcgd2l0aA0KbWFp bCBjb250ZW50IGluIHVuZHVlIHdheXMpIHlvdSBjYW4gc2ltcGx5IHNlbmQgcGF0Y2hlcyBtYW51 YWxseS4gSSBkbw0Kc28gYWxsIHRoZSB0aW1lLiBJZiB5b3UgYWJzb2x1dGVseSBjYW4mIzM5O3Qg Y29uZmlndXJlIHRoaW5ncyBzdWNoIHRoYXQNCnBhdGNoZXMgd291bGRuJiMzOTt0IGJlIGNvcnJ1 cHRlZCwgeW91IG1pZ2h0IG5lZWQgdG8gcmVzb3J0IHRvIGF0dGFjaGluZw0KcGF0Y2hlcyB0byB5 b3VyIG1haWxzIChidXQgZm9yIHRoZSBzYWtlIG9mIHBlb3BsZSB3YW50aW5nIHRvIGNvbW1lbnQs DQpwbGVhc2UgbmV2ZXJ0aGVsZXNzIGFsc28gaW5saW5lIHRoZSBwYXRjaCBpbiBzdWNoIGEgY2Fz ZSwgcG9pbnRpbmcgb3V0DQpjbGVhcmx5IHRoYXQgYSB3ZWxsLWZvcm1lZCBwYXRjaCBpcyBhdHRh Y2hlZCkuDQoNCkphbg0KPC9odHRwczo+PC9wcmU+DQo8dGFibGUgc3R5bGU9J2Rpc3BsYXk6IG5v bmU7Jz48dGJvZHk+PHRyPjx0ZD48aW1nIHN0eWxlPSdkaXNwbGF5OiBub25lOycgYm9yZGVyPTAg c3JjPSdodHRwOi8vZXh0LnNhbXN1bmcubmV0L21haWwvZXh0L3YxL2V4dGVybmFsL3N0YXR1cy91 cGRhdGU/dXNlcmlkPWJveW91bi5wYXJrJmRvPWJXRnBiRWxFUFRJd01qSXdOekl4TURRMU5UQTFa WEJqYlhNeWNEZ3daREZtWkRrME9EQTJNV1ExWVRaaE56UXpNalJqWVdFM09ERTVNV1UzTkNaeVpX TnBjR2xsYm5SQlpHUnlaWE56UFhobGJpMWtaWFpsYkVCc2FYTjBjeTU0Wlc1d2NtOXFaV04wTG05 eVp3X18nIHdpZHRoPTAgaGVpZ2h0PTA+PC90ZD48L3RyPjwvdGJvZHk+PC90YWJsZT4= ------=_Part_7316330_1348192298.1658379305930-- From xen-devel-bounces@lists.xenproject.org Thu Jul 21 06:00:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 06:00:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372520.604280 (Exim 4.92) (envelope-from ) id 1oEPDt-0006Bp-89; Thu, 21 Jul 2022 05:59:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372520.604280; Thu, 21 Jul 2022 05:59:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEPDt-0006Bi-5a; Thu, 21 Jul 2022 05:59:45 +0000 Received: by outflank-mailman (input) for mailman id 372520; Thu, 21 Jul 2022 05:59:43 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEPDr-0006BY-MM; Thu, 21 Jul 2022 05:59:43 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEPDr-00022y-Ig; Thu, 21 Jul 2022 05:59:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEPDr-00016l-4y; Thu, 21 Jul 2022 05:59:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEPDr-0008Gg-4X; Thu, 21 Jul 2022 05:59:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xhGQUpl+XTz8g81BDPr3OnhfzK9X12fYAUU30/shZkM=; b=YrhJXwEJNs7GV0EHuO+w7tOuqg 7sP9AEAnjvIfxibOe0faIWUcna6uo3T1mvdPJYNM7JATTEVS2fHC93J4AuL11oiw+n2TA7K2ab99G QgzGw6jVCtCY6bGOVDJ1d0R7/vX6/mKiaaanbeurrq80QIO0lPjYgQu8+udUI7cYXMmc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171711: regressions - FAIL X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:regression qemu-mainline:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:xen-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow:guest-start/debianhvm.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f45fd24c90767240735c6161c39699ad86fc38fa X-Osstest-Versions-That: qemuu=68e26e1e812c8b09313d7929271f6cbd47ef4c07 From: osstest service owner Date: Thu, 21 Jul 2022 05:59:43 +0000 flight 171711 qemu-mainline real [real] flight 171714 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171711/ http://logs.test-lab.xenproject.org/osstest/logs/171714/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail REGR. vs. 171704 Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 7 xen-install fail pass in 171714-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow 20 guest-start/debianhvm.repeat fail pass in 171714-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171704 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171704 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171704 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171704 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171704 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171704 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171704 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171704 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu f45fd24c90767240735c6161c39699ad86fc38fa baseline version: qemuu 68e26e1e812c8b09313d7929271f6cbd47ef4c07 Last test of basis 171704 2022-07-20 11:08:20 Z 0 days Testing same since 171711 2022-07-20 19:41:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Brian Cain Ilya Leoshkevich Peter Maydell Taylor Simpson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit f45fd24c90767240735c6161c39699ad86fc38fa Merge: 1f64dd76a1 23f13e1986 Author: Peter Maydell Date: Wed Jul 20 14:13:32 2022 +0100 Merge tag 'pull-request-2022-07-20' of https://gitlab.com/thuth/qemu into staging * Fixes for s390x floating point vector instructions # gpg: Signature made Wed 20 Jul 2022 08:14:50 BST # gpg: using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5 # gpg: issuer "thuth@redhat.com" # gpg: Good signature from "Thomas Huth " [full] # gpg: aka "Thomas Huth " [full] # gpg: aka "Thomas Huth " [full] # gpg: aka "Thomas Huth " [unknown] # Primary key fingerprint: 27B8 8847 EEE0 2501 18F3 EAB9 2ED9 D774 FE70 2DB5 * tag 'pull-request-2022-07-20' of https://gitlab.com/thuth/qemu: tests/tcg/s390x: test signed vfmin/vfmax target/s390x: fix NaN propagation rules target/s390x: fix handling of zeroes in vfmin/vfmax Signed-off-by: Peter Maydell # Conflicts: # fpu/softfloat-specialize.c.inc commit 1f64dd76a1bdf50ec8ab66da0ee7dcfd48ea31e4 Merge: 68e26e1e81 15fc6badbd Author: Peter Maydell Date: Wed Jul 20 11:51:00 2022 +0100 Merge tag 'pull-hex-20220719-1' of https://github.com/quic/qemu into staging Recall that the semantics of a Hexagon mem_noshuf packet are that the store effectively happens before the load. There are two bug fixes in this series. # gpg: Signature made Tue 19 Jul 2022 22:25:19 BST # gpg: using RSA key 3635C788CE62B91FD4C59AB47B0244FB12DE4422 # gpg: Good signature from "Taylor Simpson (Rock on) " [undefined] # gpg: WARNING: This key is not certified with a trusted signature! # gpg: There is no indication that the signature belongs to the owner. # Primary key fingerprint: 3635 C788 CE62 B91F D4C5 9AB4 7B02 44FB 12DE 4422 * tag 'pull-hex-20220719-1' of https://github.com/quic/qemu: Hexagon (target/hexagon) fix bug in mem_noshuf load exception Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load Signed-off-by: Peter Maydell commit 15fc6badbd28a126346f84c1acae48e273b66b67 Author: Taylor Simpson Date: Thu Jul 7 14:05:46 2022 -0700 Hexagon (target/hexagon) fix bug in mem_noshuf load exception The semantics of a mem_noshuf packet are that the store effectively happens before the load. However, in cases where the load raises an exception, we cannot simply execute the store first. This change adds a probe to check that the load will not raise an exception before executing the store. If the load is predicated, this requires special handling. We check the condition before performing the probe. Since, we need the EA to perform the check, we move the GET_EA portion inside CHECK_NOSHUF_PRED. Test case added in tests/tcg/hexagon/mem_noshuf_exception.c Suggested-by: Alessandro Di Federico Suggested-by: Anton Johansson Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20220707210546.15985-3-tsimpson@quicinc.com> commit cab86dea1d205f5224770de294cc718be467ccf8 Author: Taylor Simpson Date: Thu Jul 7 14:05:45 2022 -0700 Hexagon (target/hexagon) fix store w/mem_noshuf & predicated load Call the CHECK_NOSHUF macro multiple times: once in the fGEN_TCG_PRED_LOAD() and again in fLOAD(). Before this commit, a packet with a store and a predicated load with mem_noshuf that gets encoded like this: { P0 = cmp.eq(R17,#0x0) memw(R18+#0x0) = R2 if (!P0.new) R3 = memw(R17+#0x4) } ... would end up generating a branch over both the load and the store like so: ... brcond_i32 loc17,$0x0,eq,$L1 mov_i32 loc18,store_addr_1 qemu_st_i32 store_val32_1,store_addr_1,leul,0 qemu_ld_i32 loc16,loc7,leul,0 set_label $L1 ... Test cases added to tests/tcg/hexagon/mem_noshuf.c Co-authored-by: Taylor Simpson Signed-off-by: Brian Cain Signed-off-by: Taylor Simpson Reviewed-by: Richard Henderson Message-Id: <20220707210546.15985-2-tsimpson@quicinc.com> commit 23f13e1986e2ed3a02b65c0bf376c8c61d04ae7a Author: Ilya Leoshkevich Date: Wed Jul 13 20:26:12 2022 +0200 tests/tcg/s390x: test signed vfmin/vfmax Add a test to prevent regressions. Try all floating point value sizes and all combinations of floating point value classes. Verify the results against PoP tables, which are represented as close to the original as possible - this produces a lot of checkpatch complaints, but it seems to be justified in this case. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Message-Id: <20220713182612.3780050-4-iii@linux.ibm.com> Signed-off-by: Thomas Huth commit 63dd7bcbea143814924e2c6f1c01a7d9ca8038f5 Author: Ilya Leoshkevich Date: Wed Jul 13 20:26:11 2022 +0200 target/s390x: fix NaN propagation rules s390x has the same NaN propagation rules as ARM, and not as x86. Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20220713182612.3780050-3-iii@linux.ibm.com> Signed-off-by: Thomas Huth commit 13c59eb09bd6d1fbc13f08b708226421f14a232b Author: Ilya Leoshkevich Date: Wed Jul 13 20:26:10 2022 +0200 target/s390x: fix handling of zeroes in vfmin/vfmax vfmin_res() / vfmax_res() are trying to check whether a and b are both zeroes, but in reality they check that they are the same kind of zero. This causes incorrect results when comparing positive and negative zeroes. Fixes: da4807527f3b ("s390x/tcg: Implement VECTOR FP (MAXIMUM|MINIMUM)") Co-developed-by: Ulrich Weigand Signed-off-by: Ilya Leoshkevich Reviewed-by: Richard Henderson Reviewed-by: David Hildenbrand Message-Id: <20220713182612.3780050-2-iii@linux.ibm.com> Signed-off-by: Thomas Huth From xen-devel-bounces@lists.xenproject.org Thu Jul 21 07:35:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 07:35:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372540.604323 (Exim 4.92) (envelope-from ) id 1oEQi9-0001vM-O8; Thu, 21 Jul 2022 07:35:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372540.604323; Thu, 21 Jul 2022 07:35:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEQi9-0001vF-LO; Thu, 21 Jul 2022 07:35:05 +0000 Received: by outflank-mailman (input) for mailman id 372540; Thu, 21 Jul 2022 07:35:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEQi8-0001v5-5T; Thu, 21 Jul 2022 07:35:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEQi8-0003qB-2v; Thu, 21 Jul 2022 07:35:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEQi7-00053B-OD; Thu, 21 Jul 2022 07:35:03 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEQi7-0007kE-Ne; Thu, 21 Jul 2022 07:35:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=uk2DU/pxU6PhxRXqKWQdgGTv9iBTumW7kAcz4no0rPo=; b=Hby/kpoNvJoiSAbzntyvGqqraY 3ClBm6/gRDrIH8sM4pheGKqXtWRmwbacD2BiRVyXSgcbJncFQEffKVAhXnJUIsg6dP4XAxx3+1Ln9 yS3WRZim/N79vWUX7Kr5ggSTFmgqjqK4zR7xkW6qv+nru0vOysF6lgOm+jeDtdDoAjZ8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171712: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 X-Osstest-Versions-That: xen=6fe2e39a0243bddba60f83b77b972a5922d25eb8 From: osstest service owner Date: Thu, 21 Jul 2022 07:35:03 +0000 flight 171712 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171712/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171706 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171706 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171706 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171706 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171706 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171706 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171706 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171706 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171706 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171706 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171706 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171706 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass version targeted for testing: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 baseline version: xen 6fe2e39a0243bddba60f83b77b972a5922d25eb8 Last test of basis 171706 2022-07-20 16:39:21 Z 0 days Testing same since 171712 2022-07-20 23:40:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Hongyan Xia Jan Beulich Julien Grall Oleksandr Tyshchenko Stefano Stabellini jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 6fe2e39a02..d2cc5633e2 d2cc5633e2800e698c6a64554de7fa19d9627a24 -> master From xen-devel-bounces@lists.xenproject.org Thu Jul 21 08:10:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 08:10:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372556.604340 (Exim 4.92) (envelope-from ) id 1oERFt-0006xl-TY; Thu, 21 Jul 2022 08:09:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372556.604340; Thu, 21 Jul 2022 08:09:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERFt-0006xe-QK; Thu, 21 Jul 2022 08:09:57 +0000 Received: by outflank-mailman (input) for mailman id 372556; Thu, 21 Jul 2022 08:09:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERFs-0006xY-84 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 08:09:56 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00073.outbound.protection.outlook.com [40.107.0.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 803e1f92-08cc-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 10:09:54 +0200 (CEST) Received: from AS9PR06CA0607.eurprd06.prod.outlook.com (2603:10a6:20b:46e::10) by AM8PR08MB6417.eurprd08.prod.outlook.com (2603:10a6:20b:362::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 21 Jul 2022 08:09:51 +0000 Received: from VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::5a) by AS9PR06CA0607.outlook.office365.com (2603:10a6:20b:46e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19 via Frontend Transport; Thu, 21 Jul 2022 08:09:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT043.mail.protection.outlook.com (10.152.19.122) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 21 Jul 2022 08:09:50 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 21 Jul 2022 08:09:50 +0000 Received: from bc4bc973d33a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3BEF2E38-5456-4B82-9A5D-8957DDB43315.1; Thu, 21 Jul 2022 08:09:44 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc4bc973d33a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 08:09:44 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB3773.eurprd08.prod.outlook.com (2603:10a6:803:bb::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 08:09:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 08:09:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 803e1f92-08cc-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=csjK9Alq9VCZD8o0I7erzaSRqTrYmCvGc4QmbdWxdfA1gbvwdTFlHP3sRefLeBWt6eWu/pwjjJ/dYcbb25j5O33gnTNxF2gaPeNuiH5t2sOPWzNsSfcygkgQqsvO4EGgRbS4le+cQ/9nUZljfXejqm+NgCvRuaZk/ey7NKk1MEZeZfakycj9SzPOvXWU/ruOdy28ymiUUQOXufXwsrOLKFTpoCcZKA1Qymr28EwvLALog+SQX/S4rhpJmrQSGW7ymEeD2d6UtXD7dC3dhC5J//NEgHRYfbvk9F1jQPKE0vd8eh/mMmdboEcvvo1lmRafXnk8HSl/Uw+CghcrE8EWJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=gV8Wdiej/1ymVj/eipM6cVnWA0ayTGtdwwUXndx5Eqsc/+CfKcZ44rqccHH2iMGOAblAYWu9Tqfh5Y0/jKZ3hl8HEsgpl/ZVz7SSgNMdBouJwuNQBo1sfnREuebiELW+ozlmqhhXdjV2nZaWYv3urfOwW+MGRJRW+RQBtXE0HTLxBBogdaVBNVPFhuWJCuQVu470mICwJikeVWlH3q3prz7NCQNC7udADn/KoAmcsuR4uOMdNMGjYyDTG0ozvqGUJ4cbrWC5XLOw8a7xpnPzp7YciD7IJSWLDltmJJQPTVW3dD61wPvJWZ2TehR9WPw93IMTkpOFR1Oy+jbFozodIQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=7glH3gxvxPQZTt43BhAdo2YdOAntzMPAGkWEqqObVzmTSu8oPBnKEO3zAPQZfcgzitCvwkq/suU/OmV4lQkv+IOX/tEy+DvAa22a6WkZtfmGQKyMZWtOJImXsWW8yZNdkfHmR2RQW12d8/EJFSk15o9Lgbc/jOpx9hq4UOkykTg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 1217dff16136bb4e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gQUo6NS29a5jDH+NZQ0D6MDo62YT+mkyqfLz5uhwjg/L1GYpL3tBk4IN00B/xlzuYf4AsdLbk59bcsyaEZQx7EKuCsIC6aFZZOKJ6GoCfMpr6W/yMrTQY7kpE0Xb+qIReKGWBfiOsEbDvf4rhdsztFzfhF3dnMF6lUckX3vP4BrLqvtQUacNmRJES1Yq43rhEMfdHQ9EM+CCgPh7zJaQFsYiJhxmdxzkJdZievVcey98yWDON9dtDYS6GJ0CtwlwN1KYVM5h21l7vCdzdpSZekLFUH15BxDjRKY0wrvjuiaLUfR7k+HkWpkrdtxKCTIATwSa2dA4EXC1dAcENNniew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=ccyWkWZ0b1d7vVI3KJjFOgwCy3+y3MCPAri86ng0O7MMJwvz8pp68ia+Gns6N2MXXAp/CFHO9drP62vC0Ga7jfEoZmdOQjOBm7pgXd0naYxE6FEAoa7+lccBe4EOkMYJ/HcEaEPB93zUlrBoU0W1rF9pi+ThvAV4d+42s3dAMvQboqD8DqEsH6bUCxTxywdISutj2d8VlBzLUaQ7fiwuj0XvTx+ocW3cP3Xkb695MyqrV2jfZP9S+aszXdpm5NbwXZlyNurXJedFMzwoct4SAxXNQXQxvYYPNiFIMKkCVH8JJoCbW/8mRpygRS6eONmJJEt2NudJdg+kvMXMgJ3S/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y4KRPOwIMQUqC1HWijP8a8T9I5aVXmuipJ+DoNxYCYM=; b=7glH3gxvxPQZTt43BhAdo2YdOAntzMPAGkWEqqObVzmTSu8oPBnKEO3zAPQZfcgzitCvwkq/suU/OmV4lQkv+IOX/tEy+DvAa22a6WkZtfmGQKyMZWtOJImXsWW8yZNdkfHmR2RQW12d8/EJFSk15o9Lgbc/jOpx9hq4UOkykTg= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYnGjbXBqTY5m6xUmloRrBtkUewK2IeZyA Date: Thu, 21 Jul 2022 08:09:35 +0000 Message-ID: <5893B665-12E7-4C77-931A-2CB88F1AE36C@arm.com> References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-2-julien@xen.org> In-Reply-To: <20220720184459.51582-2-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d9ed3271-b743-448f-f4aa-08da6af062c0 x-ms-traffictypediagnostic: VI1PR08MB3773:EE_|VE1EUR03FT043:EE_|AM8PR08MB6417:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: /mF1bd3J7Mnfcw4RLnhtn9zDqH0GKDLDOsiSkRQPdxOW2chLDQR9jzhPUJDVdAFObPYqjDDClLy+v+3TRx7UAVzohpjb0AFC8plX9B4Hb0TirjEwmlmbKv7fWP1EqAS3RTNtDUvEk4qfsgJaOg1bHmtiAuduqtL/NPv93/Ir16jlSgRw9uKhb1c9KtSE/MfmY7nkZ9QU7K4XoztcrBp+ts4t0T+G3/6CbMQEAgDhARjdXWJ1iDidUEHgqvtkyuuHlDJyaBttZrSBuIbRyMUqhLcOL1Wj3nOGhgt1ukrs4TwBi7rnwWWcxbZUV6w4jEdlXT4Qo5lqPy4/HbySkQ/572xVrUYIDJET2vLZ5PqmZEiaFo/wJsrH6YWFpJNsxvDJutytuKkkyftk7b1zIVYymbpAId9qcP0xxoXCqGIVg5/SD9k54g7rW0r1syLDGJUfSuqiXzKnG37jOvbiuZFEQrtmTvglJZiPfaMD8vaZDwbD0X1kudCWA7iL12ndNucH3q3TpDUb12H9Fl9WQSVC4iV6CcADuAxbt69OPWzuB6wpTn2dkkgRScBXHKg/W3XHjTvrlTlGJ5IdePM1B/mXKS3/9o3anD/RSL4FB/PWayyW+cct6Qp++WmaPL6XtfIEPwIye84QzLPJXmGSPg8R3lYtVK6OQS0ejAlYuFiTuM/4OG727eR1BgizCAUMrGD8ABbmjopV7jsy7Gst4kq/sQIRsNFViOZOVFs/lJ/yHO971NHMmQF7CnnrSPQWRMoWAIKnEHSzEhDU2wtcyLAyk3T50YLhaZUA18F1KYoJz2u975aHTUvdhd7aacy6BErfCYvIP8247Avlvo/4CQvyxg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(366004)(376002)(396003)(39860400002)(53546011)(6506007)(41300700001)(6512007)(6486002)(478600001)(2906002)(54906003)(26005)(36756003)(86362001)(6916009)(316002)(71200400001)(76116006)(8676002)(91956017)(66946007)(4326008)(38070700005)(38100700002)(122000001)(8936002)(33656002)(64756008)(66446008)(66556008)(5660300002)(4744005)(66476007)(83380400001)(2616005)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <1F664B7493D06F49B498DCE8A16B8ED6@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3773 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b7d01447-3a36-4c64-b931-08da6af059c2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iWk/Upj/+H1DG/P4R5IMYvs78rEaBLhfkXDBGw4VzY3+6wGEfSZNpfyg+xlxHR0hCG3Ueyw9qsTMkUVVBZt3BxoocCxFqMmhr9nBAx8ifR3JBtxU6wW7VjogfDLZixl0t45pOeeuI+xMrF8R0ld64MI01JmrKSIjGId5gSz3YXRqcIy+i+z+DB4JQy1eCvPGusBYH8mv+SR2oA07X7JcTVnrx7wr7pQJkEJqkAH58bXz4m5Ty8bOxkMWFcDpi196chpmJP4rf8I/yvMSkKXlRtVwZ1QS5XTiePX6sozMEO3N9cSjJCHKAhZMMRzz9oYhTbAlu3/H9bPlgYENqt3Cd8fr3tvs6N7iE2hGBSdDFuwc8L+BOAkIt4neISD4gaGRQ2N/T6MbnKdjSEEzlNz+lhCKvC2SWWDo7yO6m1VCrp2l5KqMhAy0oJ+siPTZkzBK2fUXfqbTIH0O4WlvDZlU06dhDOBQO+7IV0HYhiEmvTipz8IrL4O2NjF9Wl+GJWqs6KxYEglWcQXXv4Q0Rwxwnvr9ElYw2SQKsfgPvJQP9sfnz6mCjzQl2+tul+e2kOnSUUMZn14w+ktOb9FtPWLj/pmprYMhVWYpA9VgkNCHXfyrl2HV3Q9WLxZ8Q8TJ4YG4QPC/l99fHWsfffaxursUFM9smkZJzsQrCfb8lfBAKE5Ws1FgUsmyeOuflyFj/6qv+kvPwwKuHj2gdjj6lj0M2dJj6X8KdNRvoNSyENOQwD5rogS0zDDGGyfbqg/8O/TvcC4up7MnydhvqaPvo+yJpa07xt6hhdLvDyBl89WVXnEd3q843KPF+H8KXVWsxDDY X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(376002)(396003)(36840700001)(40470700004)(46966006)(83380400001)(186003)(336012)(2616005)(82310400005)(47076005)(4744005)(2906002)(107886003)(41300700001)(33656002)(36756003)(26005)(40480700001)(6486002)(478600001)(53546011)(6512007)(6506007)(8936002)(81166007)(82740400003)(86362001)(36860700001)(54906003)(6862004)(5660300002)(316002)(70206006)(40460700003)(4326008)(356005)(8676002)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:09:50.6760 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d9ed3271-b743-448f-f4aa-08da6af062c0 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT043.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6417 HI Julien, > On 20 Jul 2022, at 19:44, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, *_VIRT_END may either point to the address after the end > or the last address of the region. >=20 > The lack of consistency make quite difficult to reason with them. >=20 > Furthermore, there is a risk of overflow in the case where the address > points past to the end. I am not aware of any cases, so this is only a > latent bug. >=20 > Start to solve the problem by removing all the *_VIRT_END exclusively use= d > by the Arm code and add *_VIRT_SIZE when it is not present. >=20 > Take the opportunity to rename BOOT_FDT_SLOT_SIZE to BOOT_FDT_VIRT_SIZE > for better consistency and use _AT(vaddr_t, ). >=20 > Also take the opportunity to fix the coding style of the comment touched > in mm.c. >=20 > Signed-off-by: Julien Grall Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Thu Jul 21 08:36:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 08:36:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372564.604351 (Exim 4.92) (envelope-from ) id 1oERf2-0002N5-3M; Thu, 21 Jul 2022 08:35:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372564.604351; Thu, 21 Jul 2022 08:35:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERf2-0002My-0f; Thu, 21 Jul 2022 08:35:56 +0000 Received: by outflank-mailman (input) for mailman id 372564; Thu, 21 Jul 2022 08:35:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERf0-0002Mq-DT for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 08:35:54 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50056.outbound.protection.outlook.com [40.107.5.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20a00264-08d0-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 10:35:51 +0200 (CEST) Received: from AS9PR06CA0463.eurprd06.prod.outlook.com (2603:10a6:20b:49a::14) by AM4PR08MB2835.eurprd08.prod.outlook.com (2603:10a6:205:a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 21 Jul 2022 08:35:49 +0000 Received: from AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49a:cafe::af) by AS9PR06CA0463.outlook.office365.com (2603:10a6:20b:49a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 08:35:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT007.mail.protection.outlook.com (10.152.16.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 08:35:48 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 21 Jul 2022 08:35:48 +0000 Received: from 07e529ff3c36.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D8F02C5C-E7D6-416C-A40C-A7B346AEFF26.1; Thu, 21 Jul 2022 08:35:40 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 07e529ff3c36.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 08:35:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM0PR08MB4115.eurprd08.prod.outlook.com (2603:10a6:208:12e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Thu, 21 Jul 2022 08:35:39 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 08:35:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20a00264-08d0-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aPQBIw9UOdZ/era49AGXhTZnSBPDGa/VFGDXTNkPpQNWMsd9H1Fy76sHXxgzbeLKOPFMksWO5CHbkVydS7oQ5pwbl3OOS7ik7mvmLtLalIYeG0gEqzXzu8/j4zhgIsj/ku4Lakqx+Zvyotvjed8h5/ZWdOy47/JoLDsqc6tWoOMBrC+yIlpbqGciEO0M5MHAsRqy8+IIGfaYwYfd2N6QgYuOvq/9DzZCW4mk6hy8jVersQhxO/brYTtfSmiPTvT92F9F2QtnQmsqzumvi4ofgLtGu4ToA0K+qKaRTw1hLDG7lWjk8HZNeo7sl3OOYkoL8PAGdmc1WA3F3tsC+MnH6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=a7OvFJNOAY2xJ8hdpscsT7FoZgLI3FLu3DPx4c/eNSwugwcPcEbOO5uBgsLwysOu9VnM/LK0Df9RQK+SVP8PLQdJhDhoGG1cqWpwUvfxlYILiZUN+Aiqy6gOB+Lm07qJ8A68I5cVMK3IcTSxEsWJAZQkW2qbwGbxQrJHWDqoVQ9mx14dGvl99qKGknXAx6e5mptz0+ztBi4bO+tN1Nl3LA0CvokzL7bQ/tuj44+z/0xTs/mEmiiumhMKnVJCMc6cEB6drfugv/mICMBlxcWekuIZMYuox7pvvH8CZUSruFCGYXA3qR9eiHpcoT1aSvzBhsm5LUgktSfvuaZmjREnoA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=jYNthHdxRivQuFz71ZPjvQ1lwGbsK76ishU8iDX4EdEWFiY48D6VEgNtQ/lFoqhOkMWZq4X6Z9dmbvRHg6WIomZUVp5fydW42mibI6q/UnfH5a+TOIZ6j6ZOc/MKVldxxCe5ygNS43hP+xb8s4Q8zb9tqcJhFuVN2bYA1TXmBhc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 93cf0c1c4646c53b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKZX9F1XgJjaz9ztmrOLIAzdUBE907v5IHFD97jmkc/l6TUdnSWM+WgG/Ioy2aT6uCaJ2yt5lARlP0wJc8tHurugwACi4Kgw4TWVsTQrAW6rR2mFWDXYuvp9+fqd2PY6qeHlIUca0dUOlHTjONIxP73chrhuE3xMgGuMSJD7yyJi7CciGl1xpU65DtgAnbyYpM34v5d0rNRXZkKAirFw9UDQZXCtYTuc+pfnycLGmFYh/i37VjSoYzdYGV9kRcdEFXlogShq7LmynBNRQpUea0D1eqwKXDZ9y3GovOd2CEHC62lcPv0SUUEAoJ3Rpt4diIsUtRLBA7TcyD2oIu+ltg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=NtB3YaiFfFhzo23hpX8MsHBP9DLZCIonQQhn5pWNqpeNtDgfbiNIep++Bm6UwpMzT+sOCIsyzQYHE31Ws3s34C+Gciu1lw1jteZZpRZenLgc73p6WzY4jjR+0b1TTe6BBYXY4hlvqadyKS6/ugNPLfKyu+CVMYm8Vb4YaK4xexsttglLMQXVZnGw6Jc05O5OCuH9jKUKOWbThapZKvvUjwrVxaiRETP+xRVtA/aqIJe4MJafzIW1bumqQmBotjfp4SfWoDF8pgQvKAfP+RJdTVkctFq+FQyFuZzmCuNgzdJz61kM6kjE6BaFEKlO/n4VGUX7zQLWSbK1j/8NeEaQpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fofCyzrORUdLScIptGph7XeCgcAnTIPNo8J8DG8sbkI=; b=jYNthHdxRivQuFz71ZPjvQ1lwGbsK76ishU8iDX4EdEWFiY48D6VEgNtQ/lFoqhOkMWZq4X6Z9dmbvRHg6WIomZUVp5fydW42mibI6q/UnfH5a+TOIZ6j6ZOc/MKVldxxCe5ygNS43hP+xb8s4Q8zb9tqcJhFuVN2bYA1TXmBhc= From: Luca Fancellu To: Julien Grall CC: Xen development discussion , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall Subject: Re: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Thread-Topic: [PATCH v2 1/5] xen/arm: Remove most of the *_VIRT_END defines Thread-Index: AQHYnGjlp6U2YulxrUmlrCnvJIWo3q2IgOKA Date: Thu, 21 Jul 2022 08:35:39 +0000 Message-ID: <364D75BC-39A0-4BB8-BE5F-B01BE4EDA707@arm.com> References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-2-julien@xen.org> In-Reply-To: <20220720184459.51582-2-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 7c6048c9-6d55-4717-6a7e-08da6af40323 x-ms-traffictypediagnostic: AM0PR08MB4115:EE_|AM5EUR03FT007:EE_|AM4PR08MB2835:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: M+2t7rf7nlA8l2PpNUPeNC9COsDbEbhR+9ndz+HiILpHibHyNH45XYcshG7/9NBpFKOBGM78lRWQznl3LYQI/AwPmBh4yrTE5Zhnu/8zJSPL703N3/IIfnIlMFbWtuBmWX90Z7taty8vQpu1Hjb1PxqUoWoEK8/HmuYePFmrjMGtxbFm+FfiK+7CcPp/5UoKtcUyTd1He6DM3TeU5DCzKnzWkXpJqyIXxa/qxikrjfxvPabKo3aMArRgqdEDtqenP5rxoCR77bk726LkRTZfLDTeeCYAFQeNirOkQR5hit9jQA5i6A2AXgsLRp5chWeuvHyP0bjpmFPHNtoPp4HpfS0rrrAQ2/x4elAKxzdVxv2+Af4i+yWhSYIg6R0cHm5pJUX8jdLVJx4GOXeEd9TvThSlCrczBqO8XsJaqWVpy30yxxx0eywD7w+c3mH0xg0U1/tdxBnXsW3WsAP5VX0aSFsL4WEymzaCxukzVab2vCF34N0jlq9lm5KHcpdOhsefub2u81R6KidkuQkb4yDc6HzPMhq4PIzi0YD6KhzaZ9iOraJ98zICPtBg1WH9vKV0fdObMVV60HHEEpNHtRZYnW0gER2WCmoD38bmSCH7S/Znyn5lzbq9xvt0HM+sY47psn/rcc8S+7DlNCviGdH4A2tyMvCsQCdcg3nMC5Ofl0Tddu0dGYo7RpW2HQT3DW9AsEPNhosVmBAFRQvgsgdrMEVNG72enXmXw+KZQ4NI59QIx4/sQvsA4AYfjCz3hXAHUJNuXkKMYi5kLsD/lTplVUbigDBHaVy4rLwdzRt2xVKiJ2en5pEIBfb7KHiyg4vX4hBcjDJqyGhyEb/FGv+FEA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(366004)(396003)(136003)(346002)(6486002)(8936002)(316002)(478600001)(36756003)(6916009)(54906003)(4744005)(76116006)(66946007)(71200400001)(5660300002)(66446008)(8676002)(91956017)(4326008)(66476007)(66556008)(64756008)(33656002)(2906002)(26005)(41300700001)(53546011)(2616005)(186003)(38070700005)(83380400001)(122000001)(6512007)(6506007)(38100700002)(86362001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <0F539BB2178E2D449C3F9D779483AD3F@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4115 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f99ad09-c03c-4f0a-8ae4-08da6af3fdac X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2204SWXlM/EP6ZmOyYKSuIcmyV4p1UfKYLLSYIyuDBL96sToMK3BcybO8FlOea2InUIT22OqhZWcUCUGCftSmQkQNNRl/r04O+JV48P6Mt90rL7LZoa96gYrGayTCiP9aQSqiN0wPB37zsaiVh3ROn6IEtYoodthxVAWMpB9FzmT1cfQRpjhAV7+rZDbjdAgvlI8CHU3ryZSGjPKOKZs5RYv3XChXWcBPHUBhVnXlOe21UGTBPJ+ytJWDtN7gzGRGt8E5JzqYin0VRKbQmDiVY6VvonIfDjpbmqppPcG0TuWMxIjL3RiPXTu1Ri89HVwwacTYtX4CMtSxghPuLD7MZHQqQvfkuRrl8dWVIE5AM5BYD7EX+MspG6mSG1w8zIq6TXQe/T2sbK3h2TTfbcL1XrNFTl8Am/p4qlII6mGJwPNWjZ/lTmAV4S8w2ym81y3OGTeon5WzHK+23p/WwJfcXeeHVHsnr1C4UDQQJgveahLqUboFhLltrbCipuGV3ieKu0FLXzLNNKLqHvjZ7ZZdNGzhDO4rN90255JTGekN00k9IVYweq1lDDo/5qHKAbcqm7Hicfv+LP5iPcqbNQeEO6/tTPEMJQKuJDz1Ykt8rIlqaO6GbXYkS/u1Ru66taz/7yBMao//3KW++sDIkOLxh08MuZzi+IdqlqXmmwhtJKAWVpSedYOgjubhmJRGKJ8L+rdnUrYkA8940gIWKTq3xp3c4Izh+CrnYYO6YYQluVpqPGSydp2lQyz0BAfa5rOP7fPe4+HshtcQg/jbZ393JxuXoz9xFgbVb5ctf58xn9FpYHP7XxIkTsesPFn0e1E X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(346002)(396003)(40470700004)(36840700001)(46966006)(356005)(82740400003)(86362001)(83380400001)(6486002)(478600001)(26005)(336012)(47076005)(186003)(107886003)(41300700001)(53546011)(54906003)(81166007)(6512007)(316002)(5660300002)(4326008)(33656002)(40460700003)(6862004)(8676002)(70586007)(8936002)(6506007)(82310400005)(2906002)(36756003)(40480700001)(36860700001)(70206006)(2616005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:35:48.3094 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c6048c9-6d55-4717-6a7e-08da6af40323 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT007.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2835 DQoNCj4gT24gMjAgSnVsIDIwMjIsIGF0IDE5OjQ0LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ DQo+IA0KPiBBdCB0aGUgbW9tZW50LCAqX1ZJUlRfRU5EIG1heSBlaXRoZXIgcG9pbnQgdG8gdGhl IGFkZHJlc3MgYWZ0ZXIgdGhlIGVuZA0KPiBvciB0aGUgbGFzdCBhZGRyZXNzIG9mIHRoZSByZWdp b24uDQo+IA0KPiBUaGUgbGFjayBvZiBjb25zaXN0ZW5jeSBtYWtlIHF1aXRlIGRpZmZpY3VsdCB0 byByZWFzb24gd2l0aCB0aGVtLg0KPiANCj4gRnVydGhlcm1vcmUsIHRoZXJlIGlzIGEgcmlzayBv ZiBvdmVyZmxvdyBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgYWRkcmVzcw0KPiBwb2ludHMgcGFzdCB0 byB0aGUgZW5kLiBJIGFtIG5vdCBhd2FyZSBvZiBhbnkgY2FzZXMsIHNvIHRoaXMgaXMgb25seSBh DQo+IGxhdGVudCBidWcuDQo+IA0KPiBTdGFydCB0byBzb2x2ZSB0aGUgcHJvYmxlbSBieSByZW1v dmluZyBhbGwgdGhlICpfVklSVF9FTkQgZXhjbHVzaXZlbHkgdXNlZA0KPiBieSB0aGUgQXJtIGNv ZGUgYW5kIGFkZCAqX1ZJUlRfU0laRSB3aGVuIGl0IGlzIG5vdCBwcmVzZW50Lg0KPiANCj4gVGFr ZSB0aGUgb3Bwb3J0dW5pdHkgdG8gcmVuYW1lIEJPT1RfRkRUX1NMT1RfU0laRSB0byBCT09UX0ZE VF9WSVJUX1NJWkUNCj4gZm9yIGJldHRlciBjb25zaXN0ZW5jeSBhbmQgdXNlIF9BVCh2YWRkcl90 LCApLg0KPiANCj4gQWxzbyB0YWtlIHRoZSBvcHBvcnR1bml0eSB0byBmaXggdGhlIGNvZGluZyBz dHlsZSBvZiB0aGUgY29tbWVudCB0b3VjaGVkDQo+IGluIG1tLmMuDQo+IA0KPiBTaWduZWQtb2Zm LWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFsbEBhbWF6b24uY29tPg0KPiANCg0KSGkgSnVsaWVuLA0K DQpJdCBsb29rIGdvb2QgdG8gbWUsDQoNClJldmlld2VkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNh LmZhbmNlbGx1QGFybS5jb20+DQoNCknigJl2ZSBhbHNvIHRlc3RlZCBvbiBmdnAsIHN0YXJ0aW5n IERvbTAgYW5kIGZldyBndWVzdHMNCg0KVGVzdGVkLUJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZh bmNlbGx1QGFybS5jb20+DQoNCkNoZWVycywNCkx1Y2ENCg0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 21 08:36:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 08:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372567.604361 (Exim 4.92) (envelope-from ) id 1oERfb-0002no-CH; Thu, 21 Jul 2022 08:36:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372567.604361; Thu, 21 Jul 2022 08:36:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERfb-0002ng-9K; Thu, 21 Jul 2022 08:36:31 +0000 Received: by outflank-mailman (input) for mailman id 372567; Thu, 21 Jul 2022 08:36:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERfZ-0002nM-Ia for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 08:36:29 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10055.outbound.protection.outlook.com [40.107.1.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36efe8de-08d0-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 10:36:28 +0200 (CEST) Received: from DB6PR0301CA0045.eurprd03.prod.outlook.com (2603:10a6:4:54::13) by DB8PR08MB4060.eurprd08.prod.outlook.com (2603:10a6:10:a7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Thu, 21 Jul 2022 08:36:25 +0000 Received: from DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:54:cafe::8d) by DB6PR0301CA0045.outlook.office365.com (2603:10a6:4:54::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 08:36:25 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT014.mail.protection.outlook.com (100.127.143.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 08:36:25 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 21 Jul 2022 08:36:25 +0000 Received: from 4b17e88d047a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 21BDEF32-61E4-4760-A764-89CD66845E73.1; Thu, 21 Jul 2022 08:36:19 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4b17e88d047a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 08:36:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4673.eurprd08.prod.outlook.com (2603:10a6:20b:c4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Thu, 21 Jul 2022 08:36:10 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 08:36:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36efe8de-08d0-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Sn2jFNUogXpPLaeNHTr1z8mODOk7KeGz0y5x8t/bZ3gabGFvXjQYu8sSVVZHyRLKJcsEbFWsJP1hKVFpFzjmY/mM+2Rqyhgnw1kJtMeuOMbQJTJWiXEMmtCWN7bfPI3ncTXt0NiiljGyPZnZK8x+BproW6WJB7aLrOIILNT1TRhYDEuvh6K/XzTyfokbIGuyUjW9DsIq5G8jet8pGh6I/JziF3g2mdx6ae49YmEjFHVeb10Us/VHDQ7gR5bzyUCbZUJkBuYMX9q9Dgbn5HZC5tLo/oMBmiPCsGrqr14lnr/YOj+Ud8e7FcTcWtsJZKPszmH1RgIrypheD0HN5xxCxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuZ4M4gHTq91mRmAjaPbTMmhEJh5TIjlu09hJWHueSA=; b=WyKHJpELvJ1Z1q9bifoMu+X4F9yXFXInCU5hkDEx9zMBV8yQa6IKwxvtx8hQKK34ZpkYk5cArGjYrebL8F5e/952pWyoBIrzB+26ChfzTODS1WWYcVYbmUUdiSOGdpmMT+kRU4VT8IQ2lfAp2VsNRokpd6+MsdPxoseWOWEPpJuhNF45bxvRl64nbP5PEdaDoiAVCX5GLukkc/36zN5lAHt6gJjnQ8yWjLSiz+MSxeShXhsYyRLSFJ/HAk0+/Zfa3u3OqiKdp/WVOUV4zbaKajiK1gFfEk1AV5+iKKxzT12p22jF+qO1SROcqGNB9nNXskSz+BZrKsLIpWfPrFtkfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuZ4M4gHTq91mRmAjaPbTMmhEJh5TIjlu09hJWHueSA=; b=2ikyBGejsbudp9aDwt14WImZidf34snYu63aI5vRl83CdH2tteTCNi0jbwyXsgsU00wulq9JHbIKXzljEEsD1E/W3qGuJcN9Hl0zQ6Lo9djk5wgBtVsz0uP7aE4EyJMVQ0hdSB7vzyIqcN1wQPm7i1qeHJHSAEHVUxcctim3lDs= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 88c166eef50a2c5b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H0CPn37bhR6uVKromApbS4n90VEcc4r8ubdGsrU95SvLfLtC2D3PcjRTW5+u7VxYUTsnpYa/iTFK8x4AbiSeAY5Tzm0ZUn+PY+yqcNV5gwe1ojqASUKaZITSmwXTYN+3AZ4OdkLUrpJa9b7CS9s5kl5FfRhx2ZeoKoKcWdKk7ny4xg/WLrOmh7zRO2wpy3nSmRS+Zx/4BSLJMvCh5g1tEElZ6LNX40KUjmTqxCDJ2yKfBZfFCxnUlYBNVxsHCWUW8BOKq0EQuqCe8M+V/eCTeyyVOxolQXdZxWFzuSoa3S/L8pV8b8rTb++hfP419GVyXBhwGMi4T4GlhyNSnA9T/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DuZ4M4gHTq91mRmAjaPbTMmhEJh5TIjlu09hJWHueSA=; b=IdLujCt1qO87yvH125j1vNAbc9KyzSJqBvSdM+szGb55WJpYB4XdB44+90k9e3Uhv7BP9B73JU88tYhRf2D1dVcEVaGKPzQHT6YP6C6028u5nIzGDtY9VA2NY/dXIAKgWFdIiepZ8SgwRhU8aF946Enqkvi2HF4FOCyb2QzjO3QjwGHRXGEOwRoAyb3n7dNPif1dpYSbjYTWUgWV+PNvCQYBflDs05aO+IMBpBscE7zL/R2NPJPj1ML693ruBpBwfignCXmHfRWxMw4JbguVcKZvOICFvf83doX1oIs5Ejb+qt9WTqSfNPCycMWCty1TMgd4v7NHv4vQOiQtfNGPOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DuZ4M4gHTq91mRmAjaPbTMmhEJh5TIjlu09hJWHueSA=; b=2ikyBGejsbudp9aDwt14WImZidf34snYu63aI5vRl83CdH2tteTCNi0jbwyXsgsU00wulq9JHbIKXzljEEsD1E/W3qGuJcN9Hl0zQ6Lo9djk5wgBtVsz0uP7aE4EyJMVQ0hdSB7vzyIqcN1wQPm7i1qeHJHSAEHVUxcctim3lDs= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Thread-Topic: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Thread-Index: AQHYnGjbgtq6TqhSCkikJaFgpVJiDq2IgQiA Date: Thu, 21 Jul 2022 08:36:09 +0000 Message-ID: References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-3-julien@xen.org> In-Reply-To: <20220720184459.51582-3-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 413555a3-bdad-4c2a-9f54-08da6af41971 x-ms-traffictypediagnostic: AM6PR08MB4673:EE_|DBAEUR03FT014:EE_|DB8PR08MB4060:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LkJtZFOzV1EUE15TJ6Kq2+rqRa04jVCKnu+XbPzikThodJVasTEltmhRzlgDufSxesrxRDpwmS0vniSyVH0QbUqG5p7wMyG89nTQQpzSzXh6rNVla0aNdyz+BOxAuUEUZiWmEW8Q8tB+OP2EakI4WXnA1jrOyDJrhH+B8RVEpqaMvjK3Heu70S+XuJaZx1pEKTLdGTTZ8y7lZ6bpIX3cRfwKcNZi0TzKNkmwt0Cc1+jVTJgSI39UEKbd7vYZOXG7akercPAwb/bzyiv3dsHnqL3nM2rgyXiitE1r4qGhOMLp4NyoyZalGKhAgTB2fZ2L85AQKOA1yyUwmlq15rPR0nJloox2WEzgLh6qheQ8gyycKkEgNQaSpJTobdV1jYQKET6boOiWZWadDcs/CjoFxErNyC48iVqAip/jsAqzudDzf3rB4pmu/dXw0pV4FEOwSFfNWtE5d2qlQyxSnv7Q7OoPn475lBgA6USvXPRDeOH+wLCcG62/jnVqYpOlzR0PKxy8WZUzq9P+MP0esfU99+tbufqztERWFb+s4ainLvG5BuiAjnNc9SQ62/5NZwrwTButRMmUsGqns+S/IE0Q+pjg0IKbSqKJw6u+WHN4eVuFMjXL1QnsRlxRHS56Of4LGMm3j+OdCBevan0frfWoXjjuCY5shFarl35MGgZ53rYEQ42g+Sd40L2IKTkC5/EQE7Nt41sJG55Y2wK1XeqfTbq+Cu9JypDiMgNwNa6/MdvIN1Ns3YEo0+KPRJLqGlwdkIVEj1h0Ufs2B6gXG/xmbnnLghNSHm3KyqBJHVlQuq9t0+7ztU3jKf/JXH/L3ecv73wQpJo01qlp6foToH1KeA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(366004)(66556008)(186003)(66476007)(8676002)(83380400001)(4326008)(54906003)(71200400001)(6486002)(66946007)(66446008)(6916009)(76116006)(64756008)(91956017)(2616005)(6506007)(53546011)(2906002)(6512007)(26005)(33656002)(36756003)(86362001)(38070700005)(5660300002)(41300700001)(316002)(38100700002)(478600001)(122000001)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <638717F2C245764EA6F61EA55B98034D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4673 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 775b8254-0af0-4efe-d180-08da6af40fda X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4mbYCKHtECwotpExqdQnn0LdkLqTJTv8+7v3ylXsOrNnvqW9umL1GK0lfDcmd0Zr0gkbshqDImaRVFYRQXAycjDbVw8aUoJFW4k01fKS5+/vMj0SGMqEf/h1tZVcXJkoqzivk2UBYt3DdVl+00LfEpye4z+yMuIUjB3GuLPYYxjhUMd0b/aDTmtc+PoqC8KZEeJLmLwb9Kcgkrj6MRYWOX6PkRFflNH7ee3TxQSQM4JlH8xxQzIdXk0LZ3oWtYaVo9aGPWAznH97iX6JiMvYez0FowWRL7K1OE+UHojEtHYKXcA7YXb+tPGYb21UXfT79DDULjbUmM6NyacprE+w79Cb7RmPrOebJtk4nLc+LpGaQBpDKFXrwXzjDW4cFP8ljf9WoYSXvmkEYhgA9zBDZQwc+AKnf4+zvi7kMWHgdYg6C98XXvjNQW8QedKXrBcY79lCJe+iKyuaxgQdvbffyFJqA7hikZpYYl9YcH+1YZKv43APyQanZdctph6/++28kkR5sJO6KzMvLXcTlRnd6rCA363ANeNCxixrZUrqAbB1+LTfxd/0Wvgawih7NvfWBRUe9TAHoNBUkPBxtq/i6mZv/V1Qox6zvlnWqgvyr6NftqIelryhbk4iVwFbyPcrNhdpTsZonayAVylJRHMh9ecDkYMAGaf0BghiYduSFnSKenwCqnFp188X1MB8kxirJSBK4iVY/W8bfPW8WkHypp/4s1+EgIXC562XEg7e0T/YIf5+rLMIzy8uluEUPTIU3QUvWLhmLqhuIVTecanZAzUkkcMF6LZjATQebtMg/1Ar49TEbLm1WeHdk9HRGvPF X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(376002)(346002)(40470700004)(36840700001)(46966006)(6512007)(186003)(83380400001)(86362001)(53546011)(26005)(41300700001)(47076005)(316002)(6486002)(107886003)(478600001)(2616005)(6506007)(81166007)(356005)(36860700001)(336012)(8676002)(36756003)(2906002)(82310400005)(4326008)(40480700001)(6862004)(82740400003)(54906003)(40460700003)(70586007)(70206006)(33656002)(5660300002)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:36:25.7631 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 413555a3-bdad-4c2a-9f54-08da6af41971 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB4060 SGkgSnVsaWVuLA0KDQo+IE9uIDIwIEp1bCAyMDIyLCBhdCAxOTo0NCwgSnVsaWVuIEdyYWxsIDxq dWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBGcm9tOiBKdWxpZW4gR3JhbGwgPGpncmFsbEBh bWF6b24uY29tPg0KPiANCj4gQXQgdGhlIG1vbWVudCwgdGhlIGRvbWhlYXAgbWFwcGluZ3MgaW5p dGlhbGl6YXRpb24gaXMgZG9uZSBzZXBhcmF0ZWx5IGZvcg0KPiB0aGUgYm9vdCBDUFUgYW5kIHNl Y29uZGFyeSBDUFVzLiBUaGUgbWFpbiBkaWZmZXJlbmNlIGlzIGZvciB0aGUgZm9ybWVyDQo+IHRo ZSBwYWdlcyBhcmUgcGFydCBvZiBYZW4gYmluYXJ5IHdoaWxzdCBmb3IgdGhlIGxhdHRlciB0aGV5 IGFyZQ0KPiBkeW5hbWljYWxseSBhbGxvY2F0ZWQuDQo+IA0KPiBJdCB3b3VsZCBiZSBnb29kIHRv IGhhdmUgYSBzaW5nbGUgaGVscGVyIHNvIGl0IGlzIGVhc2llciB0byByZXdvcmsNCj4gb24gdGhl IGRvbWhlYXAgaXMgaW5pdGlhbGl6ZWQuDQo+IA0KPiBGb3IgQ1BVMCwgd2Ugc3RpbGwgbmVlZCB0 byB1c2UgcHJlLWFsbG9jYXRlZCBwYWdlcyBiZWNhdXNlIHRoZQ0KPiBhbGxvY2F0b3JzIG1heSB1 c2UgZG9tYWluX21hcF9wYWdlKCksIHNvIHdlIG5lZWQgdG8gaGF2ZSB0aGUgZG9taGVhcA0KPiBh cmVhIHJlYWR5IGZpcnN0LiBCdXQgd2UgY2FuIHN0aWxsIGRlbGF5IHRoZSBpbml0aWFsaXphdGlv biB0byBzZXR1cF9tbSgpLg0KPiANCj4gSW50cm9kdWNlIGEgbmV3IGhlbHBlciBpbml0X2RvbWhl YXBfbWFwcGluZ3MoKSB0aGF0IHdpbGwgYmUgY2FsbGVkDQo+IGZyb20gc2V0dXBfbW0oKSBmb3Ig dGhlIGJvb3QgQ1BVIGFuZCBmcm9tIGluaXRfc2Vjb25kYXJ5X3BhZ2V0YWJsZXMoKQ0KPiBmb3Ig c2Vjb25kYXJ5IENQVXMuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBKdWxpZW4gR3JhbGwgPGpncmFs bEBhbWF6b24uY29tPg0KDQpXaXRoIGEgc21hbGwgdHlwbyBtZW50aW9uZWQgYWZ0ZXIgd2hpY2gg Y2FuIGJlIGZpeGVkIG9uIGNvbW1pdDoNCg0KUmV2aWV3ZWQtYnk6IEJlcnRyYW5kIE1hcnF1aXMg PGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4NCg0KPiANCj4gLS0tLQ0KPiAgICBDaGFuZ2VzIGlu IHYyOg0KPiAgICAgICAgLSBGaXggZnVuY3Rpb24gbmFtZSBpbiB0aGUgY29tbWl0IG1lc3NhZ2UN Cj4gICAgICAgIC0gUmVtb3ZlIGR1cGxpY2F0ZWQgJ2JlZW4nIGluIHRoZSBjb21tZW50DQo+IC0t LQ0KPiB4ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vYXJtMzIvbW0uaCB8ICAyICsNCj4geGVuL2Fy Y2gvYXJtL21tLmMgICAgICAgICAgICAgICAgICAgfCA5MiArKysrKysrKysrKysrKysrKysrLS0t LS0tLS0tLQ0KPiB4ZW4vYXJjaC9hcm0vc2V0dXAuYyAgICAgICAgICAgICAgICB8ICA4ICsrKw0K PiAzIGZpbGVzIGNoYW5nZWQsIDcxIGluc2VydGlvbnMoKyksIDMxIGRlbGV0aW9ucygtKQ0KPiAN Cj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm0zMi9tbS5oIGIveGVu L2FyY2gvYXJtL2luY2x1ZGUvYXNtL2FybTMyL21tLmgNCj4gaW5kZXggNmIwMzlkOWNlYWEyLi41 NzUzNzNhZWI5ODUgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm0z Mi9tbS5oDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9hcm0zMi9tbS5oDQo+IEBA IC0xMCw2ICsxMCw4IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBhcmNoX21mbnNfaW5fZGlyZWN0bWFw KHVuc2lnbmVkIGxvbmcgbWZuLCB1bnNpZ25lZCBsb25nIG5yKQ0KPiAgICAgcmV0dXJuIGZhbHNl Ow0KPiB9DQo+IA0KPiArYm9vbCBpbml0X2RvbWhlYXBfbWFwcGluZ3ModW5zaWduZWQgaW50IGNw dSk7DQo+ICsNCj4gI2VuZGlmIC8qIF9fQVJNX0FSTTMyX01NX0hfXyAqLw0KPiANCj4gLyoNCj4g ZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9tbS5jIGIveGVuL2FyY2gvYXJtL21tLmMNCj4gaW5k ZXggMDE3N2JjNmIzNGQyLi45MzExZjM1MzAwNjYgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2Fy bS9tbS5jDQo+ICsrKyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+IEBAIC0zNzIsNiArMzcyLDU4IEBA IHZvaWQgY2xlYXJfZml4bWFwKHVuc2lnbmVkIGludCBtYXApDQo+IH0NCj4gDQo+ICNpZmRlZiBD T05GSUdfRE9NQUlOX1BBR0UNCj4gKy8qDQo+ICsgKiBQcmVwYXJlIHRoZSBhcmVhIHRoYXQgd2ls bCBiZSB1c2VkIHRvIG1hcCBkb21oZWFwIHBhZ2VzLiBUaGV5IGFyZQ0KPiArICogbWFwcGVkIGlu IDJNQiBjaHVua3MsIHNvIHdlIG5lZWQgdG8gYWxsb2NhdGUgdGhlIHBhZ2UtdGFibGVzIHVwIHRv DQo+ICsgKiB0aGUgMm5kIGxldmVsLg0KPiArICoNCj4gKyAqIFRoZSBjYWxsZXIgc2hvdWxkIG1h a2Ugc3VyZSB0aGUgcm9vdCBwYWdlLXRhYmxlIGZvciBAY3B1IGhhcyBiZWVuDQo+ICsgKiBhbGxv Y2F0ZWQuDQo+ICsgKi8NCj4gK2Jvb2wgaW5pdF9kb21oZWFwX21hcHBpbmdzKHVuc2lnbmVkIGlu dCBjcHUpDQo+ICt7DQo+ICsgICAgdW5zaWduZWQgaW50IG9yZGVyID0gZ2V0X29yZGVyX2Zyb21f cGFnZXMoRE9NSEVBUF9TRUNPTkRfUEFHRVMpOw0KPiArICAgIGxwYWVfdCAqcm9vdCA9IHBlcl9j cHUoeGVuX3BndGFibGUsIGNwdSk7DQo+ICsgICAgdW5zaWduZWQgaW50IGksIGZpcnN0X2lkeDsN Cj4gKyAgICBscGFlX3QgKmRvbWhlYXA7DQo+ICsgICAgbWZuX3QgbWZuOw0KPiArDQo+ICsgICAg QVNTRVJUKHJvb3QpOw0KPiArICAgIEFTU0VSVCghcGVyX2NwdSh4ZW5fZG9tbWFwLCBjcHUpKTsN Cj4gKw0KPiArICAgIC8qDQo+ICsgICAgICogVGhlIGRvbWhlYXAgZm9yIGNwdTAgaXMgYmVmb3Jl IHRoZSBoZWFwIGlzIGluaXRpYWxpemVkLiBTbyB3ZQ0KDQpUaGVyZSBpcyBhIOKAnGluaXRpYWxp emVk4oCdIG1pc3NpbmcuDQoNCkNoZWVycw0KQmVydHJhbmQNCg0KPiArICAgICAqIG5lZWQgdG8g dXNlIHByZS1hbGxvY2F0ZWQgcGFnZXMuDQo+ICsgICAgICovDQo+ICsgICAgaWYgKCAhY3B1ICkN Cj4gKyAgICAgICAgZG9taGVhcCA9IGNwdTBfZG9tbWFwOw0KPiArICAgIGVsc2UNCj4gKyAgICAg ICAgZG9taGVhcCA9IGFsbG9jX3hlbmhlYXBfcGFnZXMob3JkZXIsIDApOw0KPiArDQo+ICsgICAg aWYgKCAhZG9taGVhcCApDQo+ICsgICAgICAgIHJldHVybiBmYWxzZTsNCj4gKw0KPiArICAgIC8q IEVuc3VyZSB0aGUgZG9taGVhcCBoYXMgbm8gc3RyYXkgbWFwcGluZ3MgKi8NCj4gKyAgICBtZW1z ZXQoZG9taGVhcCwgMCwgRE9NSEVBUF9TRUNPTkRfUEFHRVMgKiBQQUdFX1NJWkUpOw0KPiArDQo+ ICsgICAgLyoNCj4gKyAgICAgKiBVcGRhdGUgdGhlIGZpcnN0IGxldmVsIG1hcHBpbmcgdG8gcmVm ZXJlbmNlIHRoZSBsb2NhbCBDUFVzDQo+ICsgICAgICogZG9taGVhcCBtYXBwaW5nIHBhZ2VzLg0K PiArICAgICAqLw0KPiArICAgIG1mbiA9IHZpcnRfdG9fbWZuKGRvbWhlYXApOw0KPiArICAgIGZp cnN0X2lkeCA9IGZpcnN0X3RhYmxlX29mZnNldChET01IRUFQX1ZJUlRfU1RBUlQpOw0KPiArICAg IGZvciAoIGkgPSAwOyBpIDwgRE9NSEVBUF9TRUNPTkRfUEFHRVM7IGkrKyApDQo+ICsgICAgew0K PiArICAgICAgICBscGFlX3QgcHRlID0gbWZuX3RvX3hlbl9lbnRyeShtZm5fYWRkKG1mbiwgaSks IE1UX05PUk1BTCk7DQo+ICsgICAgICAgIHB0ZS5wdC50YWJsZSA9IDE7DQo+ICsgICAgICAgIHdy aXRlX3B0ZSgmcm9vdFtmaXJzdF9pZHggKyBpXSwgcHRlKTsNCj4gKyAgICB9DQo+ICsNCj4gKyAg ICBwZXJfY3B1KHhlbl9kb21tYXAsIGNwdSkgPSBkb21oZWFwOw0KPiArDQo+ICsgICAgcmV0dXJu IHRydWU7DQo+ICt9DQo+ICsNCj4gdm9pZCAqbWFwX2RvbWFpbl9wYWdlX2dsb2JhbChtZm5fdCBt Zm4pDQo+IHsNCj4gICAgIHJldHVybiB2bWFwKCZtZm4sIDEpOw0KPiBAQCAtNjMzLDE2ICs2ODUs NiBAQCB2b2lkIF9faW5pdCBzZXR1cF9wYWdldGFibGVzKHVuc2lnbmVkIGxvbmcgYm9vdF9waHlz X29mZnNldCkNCj4gICAgICAgICBwW2ldLnB0LnhuID0gMDsNCj4gICAgIH0NCj4gDQo+IC0jaWZk ZWYgQ09ORklHX0FSTV8zMg0KPiAtICAgIGZvciAoIGkgPSAwOyBpIDwgRE9NSEVBUF9TRUNPTkRf UEFHRVM7IGkrKyApDQo+IC0gICAgew0KPiAtICAgICAgICBwW2ZpcnN0X3RhYmxlX29mZnNldChE T01IRUFQX1ZJUlRfU1RBUlQraSpGSVJTVF9TSVpFKV0NCj4gLSAgICAgICAgICAgID0gcHRlX29m X3hlbmFkZHIoKHVpbnRwdHJfdCkoY3B1MF9kb21tYXAgKw0KPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpICogWEVOX1BUX0xQQUVfRU5UUklFUykpOw0KPiAtICAg ICAgICBwW2ZpcnN0X3RhYmxlX29mZnNldChET01IRUFQX1ZJUlRfU1RBUlQraSpGSVJTVF9TSVpF KV0ucHQudGFibGUgPSAxOw0KPiAtICAgIH0NCj4gLSNlbmRpZg0KPiAtDQo+ICAgICAvKiBCcmVh ayB1cCB0aGUgWGVuIG1hcHBpbmcgaW50byA0ayBwYWdlcyBhbmQgcHJvdGVjdCB0aGVtIHNlcGFy YXRlbHkuICovDQo+ICAgICBmb3IgKCBpID0gMDsgaSA8IFhFTl9QVF9MUEFFX0VOVFJJRVM7IGkr KyApDQo+ICAgICB7DQo+IEBAIC02ODYsNyArNzI4LDYgQEAgdm9pZCBfX2luaXQgc2V0dXBfcGFn ZXRhYmxlcyh1bnNpZ25lZCBsb25nIGJvb3RfcGh5c19vZmZzZXQpDQo+IA0KPiAjaWZkZWYgQ09O RklHX0FSTV8zMg0KPiAgICAgcGVyX2NwdSh4ZW5fcGd0YWJsZSwgMCkgPSBjcHUwX3BndGFibGU7 DQo+IC0gICAgcGVyX2NwdSh4ZW5fZG9tbWFwLCAwKSA9IGNwdTBfZG9tbWFwOw0KPiAjZW5kaWYN Cj4gfQ0KPiANCj4gQEAgLTcxOSwzOSArNzYwLDI4IEBAIGludCBpbml0X3NlY29uZGFyeV9wYWdl dGFibGVzKGludCBjcHUpDQo+ICNlbHNlDQo+IGludCBpbml0X3NlY29uZGFyeV9wYWdldGFibGVz KGludCBjcHUpDQo+IHsNCj4gLSAgICBscGFlX3QgKmZpcnN0LCAqZG9taGVhcCwgcHRlOw0KPiAt ICAgIGludCBpOw0KPiArICAgIGxwYWVfdCAqZmlyc3Q7DQo+IA0KPiAgICAgZmlyc3QgPSBhbGxv Y194ZW5oZWFwX3BhZ2UoKTsgLyogcm9vdCA9PSBmaXJzdCBsZXZlbCBvbiAzMi1iaXQgMy1sZXZl bCB0cmllICovDQo+IC0gICAgZG9taGVhcCA9IGFsbG9jX3hlbmhlYXBfcGFnZXMoZ2V0X29yZGVy X2Zyb21fcGFnZXMoRE9NSEVBUF9TRUNPTkRfUEFHRVMpLCAwKTsNCj4gDQo+IC0gICAgaWYgKCBk b21oZWFwID09IE5VTEwgfHwgZmlyc3QgPT0gTlVMTCApDQo+ICsgICAgaWYgKCAhZmlyc3QgKQ0K PiAgICAgew0KPiAtICAgICAgICBwcmludGsoIk5vdCBlbm91Z2ggZnJlZSBtZW1vcnkgZm9yIHNl Y29uZGFyeSBDUFUlZCBwYWdldGFibGVzXG4iLCBjcHUpOw0KPiAtICAgICAgICBmcmVlX3hlbmhl YXBfcGFnZXMoZG9taGVhcCwgZ2V0X29yZGVyX2Zyb21fcGFnZXMoRE9NSEVBUF9TRUNPTkRfUEFH RVMpKTsNCj4gLSAgICAgICAgZnJlZV94ZW5oZWFwX3BhZ2UoZmlyc3QpOw0KPiArICAgICAgICBw cmludGsoIkNQVSV1OiBVbmFibGUgdG8gYWxsb2NhdGUgdGhlIGZpcnN0IHBhZ2UtdGFibGVcbiIs IGNwdSk7DQo+ICAgICAgICAgcmV0dXJuIC1FTk9NRU07DQo+ICAgICB9DQo+IA0KPiAgICAgLyog SW5pdGlhbGlzZSByb290IHBhZ2V0YWJsZSBmcm9tIHJvb3Qgb2YgYm9vdCB0YWJsZXMgKi8NCj4g ICAgIG1lbWNweShmaXJzdCwgY3B1MF9wZ3RhYmxlLCBQQUdFX1NJWkUpOw0KPiArICAgIHBlcl9j cHUoeGVuX3BndGFibGUsIGNwdSkgPSBmaXJzdDsNCj4gDQo+IC0gICAgLyogRW5zdXJlIHRoZSBk b21oZWFwIGhhcyBubyBzdHJheSBtYXBwaW5ncyAqLw0KPiAtICAgIG1lbXNldChkb21oZWFwLCAw LCBET01IRUFQX1NFQ09ORF9QQUdFUypQQUdFX1NJWkUpOw0KPiAtDQo+IC0gICAgLyogVXBkYXRl IHRoZSBmaXJzdCBsZXZlbCBtYXBwaW5nIHRvIHJlZmVyZW5jZSB0aGUgbG9jYWwgQ1BVcw0KPiAt ICAgICAqIGRvbWhlYXAgbWFwcGluZyBwYWdlcy4gKi8NCj4gLSAgICBmb3IgKCBpID0gMDsgaSA8 IERPTUhFQVBfU0VDT05EX1BBR0VTOyBpKysgKQ0KPiArICAgIGlmICggIWluaXRfZG9taGVhcF9t YXBwaW5ncyhjcHUpICkNCj4gICAgIHsNCj4gLSAgICAgICAgcHRlID0gbWZuX3RvX3hlbl9lbnRy eSh2aXJ0X3RvX21mbihkb21oZWFwICsgaSAqIFhFTl9QVF9MUEFFX0VOVFJJRVMpLA0KPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIE1UX05PUk1BTCk7DQo+IC0gICAgICAgIHB0ZS5w dC50YWJsZSA9IDE7DQo+IC0gICAgICAgIHdyaXRlX3B0ZSgmZmlyc3RbZmlyc3RfdGFibGVfb2Zm c2V0KERPTUhFQVBfVklSVF9TVEFSVCtpKkZJUlNUX1NJWkUpXSwgcHRlKTsNCj4gKyAgICAgICAg cHJpbnRrKCJDUFUldTogVW5hYmxlIHRvIHByZXBhcmUgdGhlIGRvbWhlYXAgcGFnZS10YWJsZXNc biIsIGNwdSk7DQo+ICsgICAgICAgIHBlcl9jcHUoeGVuX3BndGFibGUsIGNwdSkgPSBOVUxMOw0K PiArICAgICAgICBmcmVlX3hlbmhlYXBfcGFnZShmaXJzdCk7DQo+ICsgICAgICAgIHJldHVybiAt RU5PTUVNOw0KPiAgICAgfQ0KPiANCj4gLSAgICBwZXJfY3B1KHhlbl9wZ3RhYmxlLCBjcHUpID0g Zmlyc3Q7DQo+IC0gICAgcGVyX2NwdSh4ZW5fZG9tbWFwLCBjcHUpID0gZG9taGVhcDsNCj4gLQ0K PiAgICAgY2xlYXJfYm9vdF9wYWdldGFibGVzKCk7DQo+IA0KPiAgICAgLyogU2V0IGluaXRfdHRi ciBmb3IgdGhpcyBDUFUgY29taW5nIHVwICovDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0v c2V0dXAuYyBiL3hlbi9hcmNoL2FybS9zZXR1cC5jDQo+IGluZGV4IDg1ZmY5NTZlYzJlMy4uMDY4 ZTg0YjEwMzM1IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiArKysgYi94 ZW4vYXJjaC9hcm0vc2V0dXAuYw0KPiBAQCAtNzgzLDYgKzc4MywxNCBAQCBzdGF0aWMgdm9pZCBf X2luaXQgc2V0dXBfbW0odm9pZCkNCj4gICAgIHNldHVwX2ZyYW1ldGFibGVfbWFwcGluZ3MocmFt X3N0YXJ0LCByYW1fZW5kKTsNCj4gICAgIG1heF9wYWdlID0gUEZOX0RPV04ocmFtX2VuZCk7DQo+ IA0KPiArICAgIC8qDQo+ICsgICAgICogVGhlIGFsbG9jYXRvcnMgbWF5IG5lZWQgdG8gdXNlIG1h cF9kb21haW5fcGFnZSgpIChzdWNoIGFzIGZvcg0KPiArICAgICAqIHNjcnViYmluZyBwYWdlcyku IFNvIHdlIG5lZWQgdG8gcHJlcGFyZSB0aGUgZG9taGVhcCBhcmVhIGZpcnN0Lg0KPiArICAgICAq Lw0KPiArICAgIGlmICggIWluaXRfZG9taGVhcF9tYXBwaW5ncyhzbXBfcHJvY2Vzc29yX2lkKCkp ICkNCj4gKyAgICAgICAgcGFuaWMoIkNQVSV1OiBVbmFibGUgdG8gcHJlcGFyZSB0aGUgZG9taGVh cCBwYWdlLXRhYmxlc1xuIiwNCj4gKyAgICAgICAgICAgICAgc21wX3Byb2Nlc3Nvcl9pZCgpKTsN Cj4gKw0KPiAgICAgLyogQWRkIHhlbmhlYXAgbWVtb3J5IHRoYXQgd2FzIG5vdCBhbHJlYWR5IGFk ZGVkIHRvIHRoZSBib290IGFsbG9jYXRvci4gKi8NCj4gICAgIGluaXRfeGVuaGVhcF9wYWdlcyht Zm5fdG9fbWFkZHIoeGVuaGVhcF9tZm5fc3RhcnQpLA0KPiAgICAgICAgICAgICAgICAgICAgICAg IG1mbl90b19tYWRkcih4ZW5oZWFwX21mbl9lbmQpKTsNCj4gLS0gDQo+IDIuMzIuMA0KPiANCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 21 08:40:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 08:40:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372572.604373 (Exim 4.92) (envelope-from ) id 1oERjY-0004hU-1Z; Thu, 21 Jul 2022 08:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372572.604373; Thu, 21 Jul 2022 08:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERjX-0004hN-V2; Thu, 21 Jul 2022 08:40:35 +0000 Received: by outflank-mailman (input) for mailman id 372572; Thu, 21 Jul 2022 08:40:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oERjW-0004hG-9H for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 08:40:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2083.outbound.protection.outlook.com [40.107.21.83]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c8be861f-08d0-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 10:40:33 +0200 (CEST) Received: from AS9PR06CA0247.eurprd06.prod.outlook.com (2603:10a6:20b:45f::14) by VI1PR08MB4349.eurprd08.prod.outlook.com (2603:10a6:803:101::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 21 Jul 2022 08:40:29 +0000 Received: from VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45f:cafe::76) by AS9PR06CA0247.outlook.office365.com (2603:10a6:20b:45f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17 via Frontend Transport; Thu, 21 Jul 2022 08:40:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT042.mail.protection.outlook.com (10.152.19.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 21 Jul 2022 08:40:28 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 21 Jul 2022 08:40:28 +0000 Received: from 0dc55d3e3aae.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 04B66DE1-D025-41D4-B868-AD0D6D510FB7.1; Thu, 21 Jul 2022 08:40:21 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0dc55d3e3aae.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 08:40:21 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB6PR0802MB2565.eurprd08.prod.outlook.com (2603:10a6:4:a1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 08:40:20 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 08:40:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c8be861f-08d0-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Xfd+V7xTO+Rgyi0iU6IzK8NQSlCYIhoMBQaktgja++e02ajZq8nOTldZK7ZPpFjV8I8lNwd0fs9PA0aRR4FWkPb5BkFhbGSON+0ekF3OhVFFm/A+v02vmnfDaXI8EfSonnQJj97DISqA4WXL07c3D+CJPuTM3anyXf9vWx4F+9Sa+KSpKLu+4agKN5ur/5X//GSlSALQasW/CQoup9G0apKgEo3R0//kYMM+GsWxDkQwYNLtFonFA32TZNAkI/LPF1ANQdKX3JXKe12VpD37TbzmMVBicnNt1ZcHfXa2TTRalXmLWgMMg8NJwENHwnUNXGLdvoFz8zfEp8WISHwMxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cdlNcI4fVnMTHFKCh1VtIFDmB9cGDOb3vX7/ehxnR+E=; b=Lxz84nC62mZfEO3bs0ZNllIe+zsFPPeRLJBvVjd7FcGhuaZlABeUJKly4ocwUy7hNUGcErK7ZAW2aCdM1mZG4xjP9mo7A9BWR9yCxPV5K7x3Vzb35SyAktX4d1reKIOGCvl6gC233SLKYgWAXVoICxf24SRuWh4vhB4ohGx0+rifeQtr5Tgyzz1Wuc91IIBGxxfJO52EAe4l/0aLkNJu5VIXyfG0PJAU8SqursZh9b/MBXCiM4oUGC/+ujb6MCdtEkwsilFw7tytx9gJzOar2e1RwhKz2E02sfgGesSf48gjYY7gF9KW7oN/+Z0b+rR2rfSv+nSDpEZreOKppPQlzg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdlNcI4fVnMTHFKCh1VtIFDmB9cGDOb3vX7/ehxnR+E=; b=ynihlbv8l55oUQ+2Wun8HxxMTkWbz+LGE9Y4rXdHiBijTYPBygiZdNhS35Y6I3z8z2LpCnZ5KarkuqqfsOsZIQUVE783mYKYLEPn51F9vm3ayPdcyBagsBeUbdoCbI76QNFfM++cnHHR7Nx7b0j8Q5yhtSAFb4JMKgYOlfgl80k= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 97dd903050827620 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayBcJRV6YeENLunZ8F9wc5Qh47LExRo0o1DxulcBH8gMWJwBbLcxETRhQgQHiC5qNZNExBN2SQvCBAEUJPQ9exULbZRAmwZsc6FbpyHgI7OitHvsp4VimwrHOML9/4nGPHKi8GVR7Dl/SfLR25UOfErWVxBZkdM9D1AI6hZhCg26bXjB1AMTmy9+kn3W7KKWRhhUP1uJ4wnr0PEd843Oifo9vEt1SzFpP3tx/tkxIUZl080M2s1LqoNNx4jpEyD1XIDqBkCJfOJ/W0P3t3Kotibbgf3ttFwxXzx5Uhzzi//PXyJhPQPFCocFTT+IztykMcU87m7zpeMqMqdK3dUzDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cdlNcI4fVnMTHFKCh1VtIFDmB9cGDOb3vX7/ehxnR+E=; b=lEeeDQK8Sq/6hSwWclmgNOjq2WkhVg9cVPRKzNxSBFrWAbwCnb9sZJ81e37ilucXdaI5EY0AR2cR1ubygyHbbzh9jOA9Gi/dJ2CMTE93gW3DJrX6gh7x8askkO7Rnwb5o0MirXYRx8te2xqzoztCAu84IUd3QYqesQzTNQXDYhZ1nN3gZkY7b4Xadb1QdPdK/t648fA3EEVhNtDb08t5bB7CL3Oy++Zsb0Fez6X2CPpE8bfB4nfeJQBoM8AJ/n8JTdJmLc80YHLibviHOscNbuEj0xaihJDdKqU5c9Z0ERYQPOzV+ugnGCUwTu1G2fJT8RRz6eWe53AOPWs//Ong+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cdlNcI4fVnMTHFKCh1VtIFDmB9cGDOb3vX7/ehxnR+E=; b=ynihlbv8l55oUQ+2Wun8HxxMTkWbz+LGE9Y4rXdHiBijTYPBygiZdNhS35Y6I3z8z2LpCnZ5KarkuqqfsOsZIQUVE783mYKYLEPn51F9vm3ayPdcyBagsBeUbdoCbI76QNFfM++cnHHR7Nx7b0j8Q5yhtSAFb4JMKgYOlfgl80k= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= Subject: Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... Thread-Topic: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... Thread-Index: AQHYnGjcNxK9N3xUAEK+BzEmL8ISta2IgjKA Date: Thu, 21 Jul 2022 08:40:19 +0000 Message-ID: <36782478-2EF8-45C6-A1CC-1E299704F33B@arm.com> References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-4-julien@xen.org> In-Reply-To: <20220720184459.51582-4-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 219a6269-7cd6-498e-30a9-08da6af4aa74 x-ms-traffictypediagnostic: DB6PR0802MB2565:EE_|VE1EUR03FT042:EE_|VI1PR08MB4349:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WuVJyznm8xz+RUqy7i9/vIgQOi3Opm5bRkTqITgXRjufKNV+cPkIHKUBgdA5M1gb65lJ5bA6ajSbv0WSLtxVyYwoYIUO0OEsvWhAVF8oZb0J/hl1fkMOorO9ONTHP/XXZBLLFUQOIeQVuyNQuh0Ihs43Ltd3m16emaoJ89qkBtfq1Xjxb6WnF19PcQEkExy8Ul9R3+zwBHadWJsvs4j657yIeiot7PmamhjbbcSZDb4qeOFgiX/Qb5Tfhzh/JQfpL5SRSybopU8e3S5m4sBcGQu8KckUtmfcV4okVJNV7EY8JPMIfkq1aVKpdT+dL2dSZkHu8ccCtxz8+xxY7NgUCf+kABVY9c1JlD9WijhOgdOoOwpdXyGz1QbhoQeX3lsJKC5TMt6MqiHt56zkfAzutAUh9ftq9LWa6DLvquKeorf2bli3L2hubHkOl4eR3BlIJbj8YmkXZEXO/mTc7dM3r7fsrDPVJQ8NANNqm/8R+utDJqH8Z0RYyyFkhNf6NPf9vMYXLGjm0LAXYuCERGbZp/2udQNCacJfL9M9m2xROedsrS9QQV6E3yLzY/gcZfztNFjBjE2Nl0pPuX7yibR+p3ZWH4kJ7r5ZJwXMTnE5KRfvMdKDqIVQSLYGf5AgDrCIVtg48vpHCDkZgiFNHDbEqmRopL+jzTHhcq77Wx3du+Uz/HtjEzwxM+iIKokybmDml/i/bviugedZWuLcScMXmNgeJ9kPrQwkSPFkFDShe9A+pYARAn+yBfaMFCi+Qblq31bADYSEqyK7BE3S3TcbtSded69OT+kMK96pVKMY7krDwIuuQak+/KGGWKeVkHMbTjyuvoiUIKc/e92J32HW+w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(4326008)(5660300002)(8936002)(7416002)(76116006)(91956017)(66946007)(64756008)(66446008)(66476007)(66556008)(8676002)(54906003)(2906002)(83380400001)(38070700005)(33656002)(86362001)(122000001)(38100700002)(36756003)(71200400001)(6512007)(26005)(6486002)(316002)(6916009)(53546011)(2616005)(478600001)(41300700001)(6506007)(186003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8C476A83EB465141971C742117816A1A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2565 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b50f3197-f1e3-4823-c47a-08da6af4a49b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PodVsvsUq6rWty3ZZcas74LVVLlZ9F3CWUtP94uUQOrD/fwNNxkIIf5Sy0mk1Ur08bf2zo0cpikjySFeN2BsGyrCvic4z0x/SN0Bz/zbpWQUu0W8NoZLWUe01GYe6di150a6nuvYz5ZYWMeIYQkXjukglUPyPBv+FlZxQYTQ5n64b6fnTVsTIaAekSmcElgT+atCwiPR+Swwrbwjucxft4ZrruvFxN5cUwtQS02qfpU0b6hnmnNCEWF4xVkRg4uD+x/tkHxQTgPixY0sCI/umxOZlxR5y8cSOKNz32t9/SsRhq2xu6Yd5owJnEjWMZfvUagjvg6Lu0jv0TMsZuHosGPh2vKf67etyhbR87Pun9pDgDhD9nHxTldQA1NY8WZ4gnAUm012dgguorrPf9/BPKeKJXO/wUWSYT3jKL4nPVMhGWxeCRuNIC4TXkXeH34tvz7hTFbPGXV0k2BObJL/QAw6Ko6Xy0x8Q3c1785wwkePQ4ukfnLcCiXVrebAaGF3fN+odQtgZvWKRlZaBBDTO/KJc0wPLMtsaTTnmT68QpdKS95/BtIerDVQyLORNXkaYkr0/XzCreGBB5Ql64dlLEHh1ZBjQJDpwFwBcNmK1gp9efgpinQZDY3odsxb1PROf5rYm5EClUD9d5hJ/b+0ngg87yFqbU9uMLbVM0Le1yxivJeOmHYXY1ZHsg8qiPM81fx4iYDT5m+6kahYYkT75/Qor+28k7O9mYgGnxuhkG5nsgVOrMSsEooNiBVnmB1ZJM/dXEBfojSvajUUar45W5YulKrjahPCf527BjAxDk4xls1pDHbSAuBKY5IlAOTt X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(376002)(39860400002)(40470700004)(46966006)(36840700001)(6512007)(316002)(356005)(81166007)(82740400003)(54906003)(82310400005)(36860700001)(4326008)(40480700001)(8676002)(70586007)(41300700001)(2906002)(33656002)(40460700003)(478600001)(83380400001)(70206006)(86362001)(336012)(2616005)(8936002)(107886003)(186003)(6862004)(36756003)(26005)(6506007)(53546011)(5660300002)(47076005)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:40:28.9246 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 219a6269-7cd6-498e-30a9-08da6af4aa74 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB4349 SGkgSnVsaWVuLA0KDQoNCj4gT24gMjAgSnVsIDIwMjIsIGF0IDE5OjQ0LCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxs QGFtYXpvbi5jb20+DQo+IA0KPiBtb3ZlIGl0IHRvIEtjb25maWcuDQo+IA0KPiBUaGUgZGVmaW5l IENPTkZJR19ET01BSU5fUEFHRSBpbmRpY2F0ZXMgd2hldGhlciB0aGUgYXJjaGl0ZWN0dXJlIHBy b3ZpZGUNCj4gaGVscGVycyB0byBtYXAvdW5tYXAgYSBkb21haW4gcGFnZS4gUmVuYW1lIGl0IHRv IHRoZSBkZWZpbmUgdG8NCg0KTWF5YmUg4oCcdGhlIGRlZmluZSB0b+KAnSBjYW4gYmUgcmVtb3Zl ZCBpbiB0aGlzIHNlbnRlbmNlIG9yIGl0IG5lZWRzIHNvbWUgcmVwaHJhc2luZy4NCg0KPiBDT05G SUdfQVJDSF9NQVBfRE9NQUlOX1BBR0Ugc28gaXQgaXMgY2xlYXJlciB0aGF0IHRoaXMgd2lsbCBu b3QgcmVtb3ZlDQo+IHN1cHBvcnQgZm9yIGRvbWFpbiBwYWdlICh0aGlzIGlzIG5vdCBhIGNvbmNl cHQgdGhhdCBYZW4gY2FuJ3QgZ2V0DQo+IGF3YXkgd2l0aCkuDQo+IA0KPiBUYWtlIHRoZSBvcHBv cnR1bml0eSB0byBtb3ZlIENPTkZJR19NQVBfRE9NQUlOX1BBR0UgdG8gS2NvbmZpZyBhcyB0aGlz DQo+IHdpbGwgc29vbiBiZSBuZWNlc3NhcnkgdG8gdXNlIGl0IGluIHRoZSBNYWtlZmlsZS4NCj4g DQo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+DQoNCldp dGggdGhpcyBmaXhlZDoNClJldmlld2VkLWJ5OiBCZXJ0cmFuZCBNYXJxdWlzIDxiZXJ0cmFuZC5t YXJxdWlzQGFybS5jb20+ICNhcm0gcGFydA0KDQpDaGVlcnMNCkJlcnRyYW5kDQoNCj4gDQo+IC0t LS0NCj4gICAgQ2hhbmdlcyBpbiB2MjoNCj4gICAgICAgIC0gTmV3IHBhdGNoDQo+IC0tLQ0KPiB4 ZW4vYXJjaC9hcm0vS2NvbmZpZyAgICAgICAgICAgICAgfCAxICsNCj4geGVuL2FyY2gvYXJtL2lu Y2x1ZGUvYXNtL2NvbmZpZy5oIHwgMSAtDQo+IHhlbi9hcmNoL2FybS9tbS5jICAgICAgICAgICAg ICAgICB8IDIgKy0NCj4geGVuL2FyY2gveDg2L0tjb25maWcgICAgICAgICAgICAgIHwgMSArDQo+ IHhlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9jb25maWcuaCB8IDEgLQ0KPiB4ZW4vY29tbW9uL0tj b25maWcgICAgICAgICAgICAgICAgfCAzICsrKw0KPiB4ZW4vaW5jbHVkZS94ZW4vZG9tYWluX3Bh Z2UuaCAgICAgfCA2ICsrKy0tLQ0KPiA3IGZpbGVzIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwg NiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vS2NvbmZpZyBi L3hlbi9hcmNoL2FybS9LY29uZmlnDQo+IGluZGV4IGJlOWVmZjAxNDEyMC4uMzNlMDA0ZDcwMmJm IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9hcm0vS2NvbmZpZw0KPiArKysgYi94ZW4vYXJjaC9h cm0vS2NvbmZpZw0KPiBAQCAtMSw2ICsxLDcgQEANCj4gY29uZmlnIEFSTV8zMg0KPiAJZGVmX2Jv b2wgeQ0KPiAJZGVwZW5kcyBvbiAiJChBUkNIKSIgPSAiYXJtMzIiDQo+ICsJc2VsZWN0IEFSQ0hf TUFQX0RPTUFJTl9QQUdFDQo+IA0KPiBjb25maWcgQVJNXzY0DQo+IAlkZWZfYm9vbCB5DQo+IGRp ZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmggYi94ZW4vYXJjaC9h cm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gaW5kZXggNjZkYjYxOGIzNGU3Li4yZmFmYjlmMjI4 M2MgMTAwNjQ0DQo+IC0tLSBhL3hlbi9hcmNoL2FybS9pbmNsdWRlL2FzbS9jb25maWcuaA0KPiAr KysgYi94ZW4vYXJjaC9hcm0vaW5jbHVkZS9hc20vY29uZmlnLmgNCj4gQEAgLTEyMiw3ICsxMjIs NiBAQA0KPiANCj4gI2lmZGVmIENPTkZJR19BUk1fMzINCj4gDQo+IC0jZGVmaW5lIENPTkZJR19E T01BSU5fUEFHRSAxDQo+ICNkZWZpbmUgQ09ORklHX1NFUEFSQVRFX1hFTkhFQVAgMQ0KPiANCj4g I2RlZmluZSBGUkFNRVRBQkxFX1ZJUlRfU1RBUlQgIF9BVCh2YWRkcl90LDB4MDIwMDAwMDApDQo+ IGRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbW0uYyBiL3hlbi9hcmNoL2FybS9tbS5jDQo+IGlu ZGV4IDkzMTFmMzUzMDA2Ni4uN2E3MjJkNmM4NmM2IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC9h cm0vbW0uYw0KPiArKysgYi94ZW4vYXJjaC9hcm0vbW0uYw0KPiBAQCAtMzcxLDcgKzM3MSw3IEBA IHZvaWQgY2xlYXJfZml4bWFwKHVuc2lnbmVkIGludCBtYXApDQo+ICAgICBCVUdfT04ocmVzICE9 IDApOw0KPiB9DQo+IA0KPiAtI2lmZGVmIENPTkZJR19ET01BSU5fUEFHRQ0KPiArI2lmZGVmIENP TkZJR19BUkNIX01BUF9ET01BSU5fUEFHRQ0KPiAvKg0KPiAgKiBQcmVwYXJlIHRoZSBhcmVhIHRo YXQgd2lsbCBiZSB1c2VkIHRvIG1hcCBkb21oZWFwIHBhZ2VzLiBUaGV5IGFyZQ0KPiAgKiBtYXBw ZWQgaW4gMk1CIGNodW5rcywgc28gd2UgbmVlZCB0byBhbGxvY2F0ZSB0aGUgcGFnZS10YWJsZXMg dXAgdG8NCj4gZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9LY29uZmlnIGIveGVuL2FyY2gveDg2 L0tjb25maWcNCj4gaW5kZXggNmJlZDcyYjc5MTQxLi42YTc4MjVmNGJhM2MgMTAwNjQ0DQo+IC0t LSBhL3hlbi9hcmNoL3g4Ni9LY29uZmlnDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9LY29uZmlnDQo+ IEBAIC04LDYgKzgsNyBAQCBjb25maWcgWDg2DQo+IAlzZWxlY3QgQUNQSV9MRUdBQ1lfVEFCTEVT X0xPT0tVUA0KPiAJc2VsZWN0IEFDUElfTlVNQQ0KPiAJc2VsZWN0IEFMVEVSTkFUSVZFX0NBTEwN Cj4gKwlzZWxlY3QgQVJDSF9NQVBfRE9NQUlOX1BBR0UNCj4gCXNlbGVjdCBBUkNIX1NVUFBPUlRT X0lOVDEyOA0KPiAJc2VsZWN0IENPUkVfUEFSS0lORw0KPiAJc2VsZWN0IEhBU19BTFRFUk5BVElW RQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NvbmZpZy5oIGIveGVu L2FyY2gveDg2L2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+IGluZGV4IDA3YmNkMTU4MzE0Yi4uZmJj NGJiMzQxNmJkIDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYvaW5jbHVkZS9hc20vY29uZmln LmgNCj4gKysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL2NvbmZpZy5oDQo+IEBAIC0yMiw3 ICsyMiw2IEBADQo+ICNkZWZpbmUgQ09ORklHX0hBVkVfRUZGSUNJRU5UX1VOQUxJR05FRF9BQ0NF U1MgMQ0KPiAjZGVmaW5lIENPTkZJR19ESVNDT05USUdNRU0gMQ0KPiAjZGVmaW5lIENPTkZJR19O VU1BX0VNVSAxDQo+IC0jZGVmaW5lIENPTkZJR19ET01BSU5fUEFHRSAxDQo+IA0KPiAjZGVmaW5l IENPTkZJR19QQUdFQUxMT0NfTUFYX09SREVSICgyICogUEFHRVRBQkxFX09SREVSKQ0KPiAjZGVm aW5lIENPTkZJR19ET01VX01BWF9PUkRFUiAgICAgIFBBR0VUQUJMRV9PUkRFUg0KPiBkaWZmIC0t Z2l0IGEveGVuL2NvbW1vbi9LY29uZmlnIGIveGVuL2NvbW1vbi9LY29uZmlnDQo+IGluZGV4IDQx YTY3ODkxYmNjOC4uZjFlYTMxOTljOGViIDEwMDY0NA0KPiAtLS0gYS94ZW4vY29tbW9uL0tjb25m aWcNCj4gKysrIGIveGVuL2NvbW1vbi9LY29uZmlnDQo+IEBAIC0yNSw2ICsyNSw5IEBAIGNvbmZp ZyBHUkFOVF9UQUJMRQ0KPiBjb25maWcgQUxURVJOQVRJVkVfQ0FMTA0KPiAJYm9vbA0KPiANCj4g K2NvbmZpZyBBUkNIX01BUF9ET01BSU5fUEFHRQ0KPiArCWJvb2wNCj4gKw0KPiBjb25maWcgSEFT X0FMVEVSTkFUSVZFDQo+IAlib29sDQo+IA0KPiBkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVu L2RvbWFpbl9wYWdlLmggYi94ZW4vaW5jbHVkZS94ZW4vZG9tYWluX3BhZ2UuaA0KPiBpbmRleCBh MTgyZDMzYjY3MDEuLjE0OWIyMTdiOTYxOSAxMDA2NDQNCj4gLS0tIGEveGVuL2luY2x1ZGUveGVu L2RvbWFpbl9wYWdlLmgNCj4gKysrIGIveGVuL2luY2x1ZGUveGVuL2RvbWFpbl9wYWdlLmgNCj4g QEAgLTE3LDcgKzE3LDcgQEANCj4gdm9pZCBjbGVhcl9kb21haW5fcGFnZShtZm5fdCBtZm4pOw0K PiB2b2lkIGNvcHlfZG9tYWluX3BhZ2UobWZuX3QgZHN0LCBjb25zdCBtZm5fdCBzcmMpOw0KPiAN Cj4gLSNpZmRlZiBDT05GSUdfRE9NQUlOX1BBR0UNCj4gKyNpZmRlZiBDT05GSUdfQVJDSF9NQVBf RE9NQUlOX1BBR0UNCj4gDQo+IC8qDQo+ICAqIE1hcCBhIGdpdmVuIHBhZ2UgZnJhbWUsIHJldHVy bmluZyB0aGUgbWFwcGVkIHZpcnR1YWwgYWRkcmVzcy4gVGhlIHBhZ2UgaXMNCj4gQEAgLTUxLDcg KzUxLDcgQEAgc3RhdGljIGlubGluZSB2b2lkICpfX21hcF9kb21haW5fcGFnZV9nbG9iYWwoY29u c3Qgc3RydWN0IHBhZ2VfaW5mbyAqcGcpDQo+ICAgICByZXR1cm4gbWFwX2RvbWFpbl9wYWdlX2ds b2JhbChwYWdlX3RvX21mbihwZykpOw0KPiB9DQo+IA0KPiAtI2Vsc2UgLyogIUNPTkZJR19ET01B SU5fUEFHRSAqLw0KPiArI2Vsc2UgLyogIUNPTkZJR19BUkNIX01BUF9ET01BSU5fUEFHRSAqLw0K PiANCj4gI2RlZmluZSBtYXBfZG9tYWluX3BhZ2UobWZuKSAgICAgICAgICAgICAgICBfX21mbl90 b192aXJ0KG1mbl94KG1mbikpDQo+ICNkZWZpbmUgX19tYXBfZG9tYWluX3BhZ2UocGcpICAgICAg ICAgICAgICAgcGFnZV90b192aXJ0KHBnKQ0KPiBAQCAtNzAsNyArNzAsNyBAQCBzdGF0aWMgaW5s aW5lIHZvaWQgKl9fbWFwX2RvbWFpbl9wYWdlX2dsb2JhbChjb25zdCBzdHJ1Y3QgcGFnZV9pbmZv ICpwZykNCj4gDQo+IHN0YXRpYyBpbmxpbmUgdm9pZCB1bm1hcF9kb21haW5fcGFnZV9nbG9iYWwo Y29uc3Qgdm9pZCAqdmEpIHt9Ow0KPiANCj4gLSNlbmRpZiAvKiAhQ09ORklHX0RPTUFJTl9QQUdF ICovDQo+ICsjZW5kaWYgLyogIUNPTkZJR19BUkNIX01BUF9ET01BSU5fUEFHRSAqLw0KPiANCj4g I2RlZmluZSBVTk1BUF9ET01BSU5fUEFHRShwKSBkbyB7ICAgXA0KPiAgICAgdW5tYXBfZG9tYWlu X3BhZ2UocCk7ICAgICAgICAgICBcDQo+IC0tIA0KPiAyLjMyLjANCj4gDQoNCg== From xen-devel-bounces@lists.xenproject.org Thu Jul 21 09:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 09:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372583.604384 (Exim 4.92) (envelope-from ) id 1oES2U-0007g2-Ku; Thu, 21 Jul 2022 09:00:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372583.604384; Thu, 21 Jul 2022 09:00:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oES2U-0007fv-Hs; Thu, 21 Jul 2022 09:00:10 +0000 Received: by outflank-mailman (input) for mailman id 372583; Thu, 21 Jul 2022 09:00:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oES2T-0007fp-PV for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 09:00:09 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8563f5f5-08d3-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 11:00:09 +0200 (CEST) Received: from AS9PR06CA0326.eurprd06.prod.outlook.com (2603:10a6:20b:45b::34) by DB9PR08MB6684.eurprd08.prod.outlook.com (2603:10a6:10:26d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Thu, 21 Jul 2022 08:59:56 +0000 Received: from VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45b::4) by AS9PR06CA0326.outlook.office365.com (2603:10a6:20b:45b::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 08:59:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT052.mail.protection.outlook.com (10.152.19.173) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 08:59:55 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 21 Jul 2022 08:59:54 +0000 Received: from 5a4b13f1ad07.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DBC4EC64-6E41-4889-BAF8-6520839A74AD.1; Thu, 21 Jul 2022 08:59:48 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 5a4b13f1ad07.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 08:59:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB5501.eurprd08.prod.outlook.com (2603:10a6:803:138::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.17; Thu, 21 Jul 2022 08:59:46 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 08:59:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8563f5f5-08d3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NHRyf6Q6//TEc8zY961B+Ax5zGZy9HZpzxVDBKPsYA+T36UOCyaxSZ2dfJnPVSPJzkoEGyEij/gXzcXeyHAcFSyfMMlJ+66bnVC63AuZjYZIr+uZ64S3o1rTTIJTrxSYxaXMSKGFFdbjGAsqhdBfjwC6laxzd/RvwYsw9nz9SewTzCP1fkrOYjjEPO0axgZ0Ct43RlkZiPgZvr3Y+oHBivdhmAI3cwyu/to1/zB4ZqosEzEqnFJqEBS36ARHdwWLx65PapXnJZy+YeMC+VquabuhxiRDB7/oHgpgmlKM9EkI5O9NQ888FowyV0q/qZvtDpYSa4x2SiwQlNvmvB/ibQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/KIo+477VEu1Sbz/j3vSz8fFclFe5qVsQi0g8TxE9E=; b=NUuV0sH+6loZdJkIPZUK9gGf34aRJ8bLAaUfyYu7OGryEYSGuvh9gvW8QsAKSkqT0qgTCr7MBvUaShD/W600mKLOT5gfhAkT87Fou5uHmKHogc1Fac4ADllbss5fT6dMDl1CsqBJFpLMuU7tdJNIK4+b7QYgpr+4XG4+naRuqJa/uf3Rb+5/nwwCoPlL6ZRTKMbdzDtD1r3LcY0jpBkYv+0cM2uD8bH95SnzyCGhotp4Ro9S0u/8YSEq+7+tARBzTApKWlnz9XLTmeyJ9zEc6LfQrxXPuEtAF1dRvjgRdWWVeHGB0BjzBr89797xWfJy0KL/Vk+QzYw+DprjnC5Gpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/KIo+477VEu1Sbz/j3vSz8fFclFe5qVsQi0g8TxE9E=; b=GtQvNZyAZQdjd6JpsTFBB3u5z8QPY6yzonRNTqe9nrzKUQX4XwyoP3IiVPjUKxibgWtgc7yu/Eztn8mHEHHUcvAyn1FRZZlYESEcpyuUVbLz2yZBzhMXrVYKn7Zu4WQrzxIlEDYrAg1VwEbaxwl90JQQhbn7wfYMLtQn6UsFZbY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 8bed13d8b79e5796 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRaeeBdHsc8rWlCYgZfbEQCey5BWYIw0W2qnAXytAOXoPkhAbML1usSllegsLJcX0G//fCDfCaappB8NAcuWMElfZCxUwb6FPyvn/KPD1qijRmga/V8CLoJ63MgWxxDWUq3FFGbBDsUVe6X5r7F2Ze8pksEMbTtiJyxXed98Mdt5150aNdxlgrP5EGeEMEzQUfi/JedRWHXRywy+K2AyYf3LHuHWDlQnNCpUoos+7O1VvggR74FrYdcIGpcc+4xhIQRS8EExH+vsnOaZ06igYbOzN//w3Rxz2SyVzOjFglrbXt1pjK7MCqutCrDcRWnAiJkcnbN5+p8/fjVpkBmFTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/KIo+477VEu1Sbz/j3vSz8fFclFe5qVsQi0g8TxE9E=; b=f4tnaW56lB8nUsQLMeIPxu5nKr5nEBq8G45vDx9jXjhCc+BIFYIrTSY+kfESfXVgxwgWyQ27x5/Z83nRWyUXarFtiL0q8t8MzEYQr8qybJdlZFVE8H5DkXq6cyethOMjrESa3iAyuaBUaHk2rYN0mgdWmXyqY4aF4Tcw7y+RTO+eJRiXgqa3ogW1A0e18lOKtV9DZ9csMSefISxGIy031FlHIZRmVkTmnJX7l+wFyuv37n4MkUW1wroUCqkF7u7HBQxIPUutXr2BzIqeDUeIi7rW1CxsRoBq1PUk1FriltS+bi8SWg6zvP9f8YuS+TztMcr5mLICzZRul0+cY8A35g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/KIo+477VEu1Sbz/j3vSz8fFclFe5qVsQi0g8TxE9E=; b=GtQvNZyAZQdjd6JpsTFBB3u5z8QPY6yzonRNTqe9nrzKUQX4XwyoP3IiVPjUKxibgWtgc7yu/Eztn8mHEHHUcvAyn1FRZZlYESEcpyuUVbLz2yZBzhMXrVYKn7Zu4WQrzxIlEDYrAg1VwEbaxwl90JQQhbn7wfYMLtQn6UsFZbY= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups Thread-Topic: [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups Thread-Index: AQHYnGjd/WoMkI+VCEKYLle60EibRq2Ih6CA Date: Thu, 21 Jul 2022 08:59:45 +0000 Message-ID: <4E4C5ACE-D7BB-4AAF-BE51-471BB73A2F08@arm.com> References: <20220720184459.51582-1-julien@xen.org> In-Reply-To: <20220720184459.51582-1-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: b78b75da-24d6-45a0-b320-08da6af7619f x-ms-traffictypediagnostic: VI1PR08MB5501:EE_|VE1EUR03FT052:EE_|DB9PR08MB6684:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cqLxfcdl2vNJASD+D1BYM4FchDMHEnSRq2NKX5E+Wl47a1Xz8LQSxjbCI72dZmVNsheAjhf4KLodkY+PjwqPiygnb+owYkb76Zm3c0L3ySJQG1KgNhBT7aE/B8W3UoYcnu93/99oYTIkz7HSNsfS/40PMUdor12SqrywQsRs7AMZbsvU+jJXsWXughRgQUvFiTkGrSEbmWlW61VGBej3B6zLns3ecGdwioJrll6a3l90/xvJ6G3AOhyDg0qRU5udcHnvnwbi9/4p68pqEdpGJLMU4RUH+OKzBNXk5bJRrAcB2yPKbTD42bQIbSR31Z1Ig/ENZyNnJaTFTL+f7gvC0xh8XqfV3e0j0VRcfOybLsiTVq384L2z4WAgfiGWTsOGH4sGf3+DG3SG3/+CBaj3KFRy/Uv2A7hT/VSEvpzKKDPsPF8OUn26hOuA4bBn+2kdLB42zNWFzuxXt0CnARKMG7U6VDDy24W0N8g0F5scfVgulSw+/rXRctqHStLrVEN0X7Hb5KC7cHlwwjzqREDsgTO9i97R5AErxO3cfZMn56Km5xbYc5YYEkt9P6a59PbParflC7625IR7oNm0ypo3ibHDpO1jjpb391gZDU9VyhRrDCjC2EvpQ7TMuDn2vtdFo7HgVxLceFc/79evnsmHiwbrqFiPhch4q/8s/aPD7X8NiuzUZNuCPzqoBBDPTewC9D9X/QRErGNLGZju0bGAZncGLG48JdepfRibPpS2Lp9UYNe3IIEorJAq5R1jZ2XInJpnm3a/HBIAtdrgiAELf4+MsGLF7HUdAMqpu362eca/sJweBQ8lAe5v1RdTGzh2n+Mykg1W+Lf0Bgr5V6vDOAh9wnRK8zGnglih3AuWTvfBwfRtNslSsfojs56LUzbS X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(396003)(376002)(136003)(346002)(39860400002)(8676002)(76116006)(66476007)(64756008)(316002)(66446008)(38100700002)(4326008)(66946007)(54906003)(66556008)(38070700005)(91956017)(33656002)(6916009)(86362001)(71200400001)(36756003)(6512007)(6506007)(122000001)(8936002)(5660300002)(6486002)(478600001)(41300700001)(2616005)(966005)(53546011)(7416002)(83380400001)(26005)(186003)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5501 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 85522c94-eef2-4f3d-4968-08da6af75bb5 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2/f3x3VjqhixmHVIxUmPeVXfer+7PorSQ+69bF/gyMZ8oUq2Mnq336cjM9O6F4fciTmHOpzlAGczp9p1glnkXthc7+DVLyYkIOlEdGFsdu7/zmXtgiMGu3vhQ8kPtrgPb0avMYslRcYM6pv/28qwR/kFF2XpUh3t94y3bwFcBsFPP4u3gac97PGtAziKpdnKhr8v/rsznNwSBrUhINtE47PhG47150xA0CIVuKzkUWOWjPW0HveVl2KNz9ZBFEJNeH0WGVB3gqXv87Hr7wYkD9vTQj7I7+LjqMmuv8t+IVJm4BMVlXHU/vSoavrEi46GpsRW9ApyTcTBaofxiN9BYjGgzSPunjNy74XYRZGtKAeRTy8ZiQegRHU9dL28pocq388M+1CtoynCC9Lzed0rHfrFOuCSDs41zWlW37DAV3YxGLjFC9wet5dR+klSACcDbaaLUFAzOMkrzPdMny7Rzx2lJRGezDhK0v5CUApjaC0DEbhaovWhCf1TrHraZHkOccw31SqEnslWHdTT6VOmh6ZAZ3CVbYryHLm6J4y4SoSp2Vo0SoO3EKhSBkDs4aUBb3F+B8uLVhYrss5j35Aa2u7Bx67Mgqkd54lL7DtYGjy2ac7mmnC/YUbxqBHJFGKQfunMQHUNBAioCgWldNcEmdMffikuVJ6TFAQB2GpdvZTW5LIHN7D6H8TiCcfOWdAMXSoe/FNNqljXL+07Kj76FNkVbAuubvV+9OSaCNefeHEBM56yhvc4fgXPYvjAe5+l9BivvPCipa/tB6t/VZ9UDYi4A3qBQ010a/pUqXkmFAqVGP2kYnMlzzsWEjHHrmc0hxue9hwm5NjxOQuWes5aAg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(39860400002)(346002)(36840700001)(46966006)(40470700004)(2906002)(53546011)(6506007)(82310400005)(83380400001)(81166007)(41300700001)(107886003)(2616005)(26005)(6512007)(356005)(82740400003)(47076005)(186003)(33656002)(336012)(966005)(70586007)(70206006)(36756003)(4326008)(8676002)(54906003)(40480700001)(40460700003)(316002)(478600001)(8936002)(6862004)(5660300002)(6486002)(86362001)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 08:59:55.2575 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b78b75da-24d6-45a0-b320-08da6af7619f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6684 Hi Julien, > On 20 Jul 2022, at 19:44, Julien Grall wrote: >=20 > From: Julien Grall >=20 > Hi all, >=20 > This series is a collection of patches to clean-up the MM subsystem > I have done in preparation for the next revision of "xen/arm: Don't > switch TTBR while the MMU is on" [1]. >=20 > Cheers, >=20 > [1] https://lore.kernel.org/all/20220309112048.17377-1-julien@xen.org/ >=20 I tested the whole serie with (including starting a guest) on qemu x86, qem= u arm32, qemu arm64 and fvp base. So for the whole serie: Tested-by: Bertrand Marquis Cheers Bertrand > Julien Grall (5): > xen/arm: Remove most of the *_VIRT_END defines > xen/arm32: mm: Consolidate the domheap mappings initialization > xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... > xen/arm: mm: Move domain_{,un}map_* helpers in a separate file > xen/arm: mm: Reduce the area that xen_second covers >=20 > xen/arch/arm/Kconfig | 1 + > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain_page.c | 193 ++++++++++++++++++++++++ > xen/arch/arm/include/asm/arm32/mm.h | 8 + > xen/arch/arm/include/asm/config.h | 19 +-- > xen/arch/arm/include/asm/lpae.h | 17 +++ > xen/arch/arm/livepatch.c | 2 +- > xen/arch/arm/mm.c | 221 ++++------------------------ > xen/arch/arm/setup.c | 21 ++- > xen/arch/x86/Kconfig | 1 + > xen/arch/x86/include/asm/config.h | 1 - > xen/common/Kconfig | 6 + > xen/include/xen/domain_page.h | 6 +- > 13 files changed, 283 insertions(+), 214 deletions(-) > create mode 100644 xen/arch/arm/domain_page.c >=20 > --=20 > 2.32.0 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 09:30:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 09:30:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372591.604394 (Exim 4.92) (envelope-from ) id 1oESVZ-0003Od-6p; Thu, 21 Jul 2022 09:30:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372591.604394; Thu, 21 Jul 2022 09:30:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oESVZ-0003OW-3Q; Thu, 21 Jul 2022 09:30:13 +0000 Received: by outflank-mailman (input) for mailman id 372591; Thu, 21 Jul 2022 09:30:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oESVY-0003OM-6h; Thu, 21 Jul 2022 09:30:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oESVY-0006U3-39; Thu, 21 Jul 2022 09:30:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oESVX-0003hU-OR; Thu, 21 Jul 2022 09:30:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oESVX-0005AZ-Nu; Thu, 21 Jul 2022 09:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k7DsDf/F5hCdsQCeevNFxYC7zIuGNYE+kBR1Un1Kwd0=; b=hJ160ySqEAcM+yIGnTJvrVRf+b Cc3GlLPKzXjdE0/7lDYYpTr5uTanqeNwHw75G/qa4Gh2wCw9qebK10OY+UEi+FClAUMOSeWiyUZPl NeOQ0ya1eOLimmVPMoP3U39xd8li9ErcjpO7Bv3ahQbf00UAdKOrcKNn7VHPiJCEA43c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171713: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ccfdc6b02932efda5d76e2cd40857db651fca684 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 21 Jul 2022 09:30:11 +0000 flight 171713 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171713/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt ccfdc6b02932efda5d76e2cd40857db651fca684 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 741 days Failing since 151818 2020-07-11 04:18:52 Z 740 days 722 attempts Testing same since 171713 2022-07-21 04:21:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116432 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 21 09:42:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 09:42:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372599.604406 (Exim 4.92) (envelope-from ) id 1oEShS-0005B3-AW; Thu, 21 Jul 2022 09:42:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372599.604406; Thu, 21 Jul 2022 09:42:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEShS-0005Aw-7Z; Thu, 21 Jul 2022 09:42:30 +0000 Received: by outflank-mailman (input) for mailman id 372599; Thu, 21 Jul 2022 09:42:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEShQ-0005Aq-Lg for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 09:42:28 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2048.outbound.protection.outlook.com [40.107.104.48]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6d230af2-08d9-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 11:42:25 +0200 (CEST) Received: from FR0P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::21) by VE1PR08MB5839.eurprd08.prod.outlook.com (2603:10a6:800:1a0::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 09:42:13 +0000 Received: from VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:1e:cafe::56) by FR0P281CA0082.outlook.office365.com (2603:10a6:d10:1e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Thu, 21 Jul 2022 09:42:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT010.mail.protection.outlook.com (10.152.18.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 09:42:12 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Thu, 21 Jul 2022 09:42:12 +0000 Received: from cad6147f9f6e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 966A367A-AF92-4DEC-A679-700F80897E89.1; Thu, 21 Jul 2022 09:42:05 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cad6147f9f6e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 09:42:05 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM5PR0802MB2529.eurprd08.prod.outlook.com (2603:10a6:203:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 09:42:03 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 09:42:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d230af2-08d9-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Whk8vEsqthChGTwxVe/r8ZituPH/cjgqWWDkCiWzG31Oh89Yfv4tdTYRdQd61zE7lyR4xtyrUMKMyNGqbWXUmW9ShbDcWRnagEHYtMvf3apxBQI9YWT293ZUL+Ul+55gRxr/UpIqwEk4NMbvSXltff7QL9eP/7INiiAL2MKayAKn4PNtDttXIv2CBhZOnvnrBod2KHFZhsxUhmhRFtSf+MRYXP6ncf4ofFW37LLq7PUNbNvPfxTSPTcIBuI5NoxxzTouVaY51y9bxvb74x7D62LCxmneQuFu46e5hMcoRnFQJu9lwt3qP7nRW7jLT1T66ds8LvE/CKWRCjA100LJWw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=Vxj3MG/JlzqvuX3GdNWJjTABWvHME+SLJYsJnsWGXaui6CRwHuvCE1iYM4+vCxwkAv/WVAVagrKa6x7XelsoN2/F6mZGjn/DQOGAJhmYd0ub63ggV4WXm1fBRSL6nJmBxiXRQ1qvzF3mcKZM54RYh7dDkXey6bAbFQSaBFavZEZmPAdgyH9UHpWJozQM7+ZxPu0nar0v7Y97bAAoeHGJsw3sNgVB4sXq48srOR9J6qZYoXOnpv0z9/KoqvEujX+PPcf7zUMEdUuFym0uP4b5+GVPmOJSjkiq2cXBboeQX5RbukZ6wQSUJ63u4KcuNuM6I+63hIk2FZbJ3j7ZNGLI5A== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=XSJ+diFt0jQjNFa8ABjY/HwPqjrn7t6miPhOacNN3+4FdRsLiDGUwdjpum/ktK8JVgENEStXLhRptYH0FXNAgNguRfnA6EvkHddVqR049ztm+5ZfbyVvppg5C/SNYxU8dwh2w/f6sCcppxDJp9O9rlytMssjYYVf5y860TRQMEA= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9d048be2ea574fcb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fz0QuozorezgFuvH6OsZkPTKZM+hLYmEwdU+TbpHBY48fvVHIA+/dPRgyXNoyL29B0ve6gNaGnSMT4ipEvg51Ljqr2Lsh3p5etO2ueWVXE96lE9nKljZQquPcdTwSX5rHF5HBla6nIdS9D/gPRK8dgeFoWTi6BwvRDcMqhLBF8j1PRdsjdY3U0DxqsCSSxCRBaVhSXsr9V0TXEV4kzgyWQw5arkSvlUQP0Pmey+rDfKY0wEr2AarCAAyZ3vtljmQ7dPU8MTySff9BCNb1+Od03GqOkBX7vyQgg/tNmqyvc03+hD+FRaYWe2pRsadQsqKlbh/6ng4nkwCRD8+8NfrDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=EDE+VaEKJsYQmtqypXG+x/Hx9vHguwPIXSOancLD8a5VQqBk8Bw/Urb2LFRBdi15VADeyQ6kHiMHn5iHkpE16aWYvTJbrS8r6rgo2jkb4Is4wXzd2dLd5/PEMOzisjGD87f2W/xXA/lzNv9y7ituRKkvK9YjNycIeFW0TKJxWcmZ7lbx3jUWz2MGeRTgKuXEIp/4Ne+TcuXmOIq/rKmrwBNoFZ+eMRr9ebehSix5MGcCZtAtbsnsCwsbWg1OD+YlAzOuGpdjrRGTRsfGmM3bnhS1jbku62FNtD4NuIdTWAYcXO+5XyCufOKRnCmdtqg3HYcI+HMnimypZvbkMcQtYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=79p6noFtPNzf+9uwJyf6reWBzGOEK97mk6XUY2WmVTc=; b=XSJ+diFt0jQjNFa8ABjY/HwPqjrn7t6miPhOacNN3+4FdRsLiDGUwdjpum/ktK8JVgENEStXLhRptYH0FXNAgNguRfnA6EvkHddVqR049ztm+5ZfbyVvppg5C/SNYxU8dwh2w/f6sCcppxDJp9O9rlytMssjYYVf5y860TRQMEA= From: Luca Fancellu To: Julien Grall CC: Xen development discussion , Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Thread-Topic: [PATCH v2 2/5] xen/arm32: mm: Consolidate the domheap mappings initialization Thread-Index: AQHYnGjqn9ie7DwPZ0aph4nZF/OvCK2Ik3AA Date: Thu, 21 Jul 2022 09:42:03 +0000 Message-ID: <857767B6-6E8B-435D-9312-A53550F36A4E@arm.com> References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-3-julien@xen.org> In-Reply-To: <20220720184459.51582-3-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 988135f0-3e4f-42ca-00c3-08da6afd4a0e x-ms-traffictypediagnostic: AM5PR0802MB2529:EE_|VE1EUR03FT010:EE_|VE1PR08MB5839:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: zoirBjD1jQ5z/eHQUPtwFfOLykMB3g2RjAJldqgEgFCLQVbyRO09mW57RLti+c4FjGyjRch97yG2IC1glQ2UNsKCKSqcvX/R4TWqXPyT5Ocf949L1HMiQyzFgGbJVqdY9B7wmoblknrDmtnWIKjXlhcMQ3P85a1l2k2L9ow6MaDauRtXBITNO5cWsuywnswNXPXLB7+Zqp0uwhuw7DjVGu0NdMew7VtE2mR9EbgdSzXxqjrNH701vROJCsiesmDZd3em0WUdTrMS35C3m3H25Wat3/WsvEZdBtJtjN/oxwuuT9NBDQe8ago4PtR6rq/6Dv8fnKREDK0etyZGkEN13BjxFNR38eloIK6n8x3UW0a9M3c54V06tv3DjzOw6yuAXgDF0YFFHqR1D3+xqanSAHpq9pnjpFEDkiw0WoSrN5cJ9p3WLFwfe3pCHhqvR4jBuhVj3cCz4djsoMBnamnZlqNcfnYulDnRffiJUQV4peZWWkmPHP2HFZlunbeIRR3tuFytZNXzgLy7gzjaosZtNlZiUQ/MXmFk97HC/eX07ocl7qXUSQLLuY5H6lNVAm59rkGNFvqcwfEJ3hqJp53i9LbRY2+WQ/j7skZwpvx8CS3BAqddGtkY8i3koGCpVBmDhvwFkjGmSLkl/gRNFsUwXBnXXJwwReYANB5feV6o4u+5gw1LOOOic9wEMcCnMUmdwENlML+nt7DoG5VUgITaYNfusTCfrP/FFVAH01Lxg29PXHHrjmIeiOURJEigvQQtxnZxRqdBShNnlsr/9JdVClkzPLzXBu71x8No3TpWfOM0YHS6NvsK6xpGXjjARihGT0WZnxwGPmjHURa1S2hi5w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(346002)(136003)(39860400002)(86362001)(2906002)(26005)(6512007)(6506007)(53546011)(186003)(38100700002)(2616005)(122000001)(38070700005)(33656002)(6486002)(41300700001)(316002)(478600001)(8676002)(4326008)(66556008)(66476007)(66446008)(64756008)(6916009)(5660300002)(76116006)(71200400001)(91956017)(36756003)(66946007)(54906003)(8936002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <9044A337C0CE7C408A54A7A017B07BDD@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2529 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1e54d8e6-2508-4411-ce94-08da6afd448d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ofv5lNbKt2W8FIsT8nilUCF+E+fwf/e5HRy7WsqjH2UPJGSD3f1nWseflm8BgNC1EhBmEyqJtl1HHlBQdV2HN1tVlr1jkFjQex81lpaty+jMlDfbM8aA0FeMVpjAVmwmFvozzqEZ01K/INsUH6oYffozs1vfM+QjaM08bx8sGsb5xnZNLq1207cMkPVxobOlrxRvog9hR4ClFvlMqsi3GxNLMViAcEhPXG7//rlM0+JAhGOpaAz3mOQgazLzt32L/M/tcqPYihKzER1MG68Kdtq8ajZQ34RXOyp7bgZEqqkNg6T0rq1EA+KmPnHgkDdRtfnGXCRM+mS9jzxgrBTcTOy9NgRdfKAhaknJKKU47UVPBAQPQAfeMs0SVC7CcFSIDhyl3lGSNAJtdK9Q7KRu8dDHKfHNDyG8hKXzQqO46JjLbuySiCFulHdgSU7wXYJnYw5Kl7SfYisHKTYtrw2JJ/kVeefDusSOXWsGQesXyy3V9SqUk9vb7A4WY5UBjtTsruLPFNochuNNF41JgVLv0c7dBCdWbMZizgxGSBQj0Fo5WWnui8FrFjtMdQ1CJ9edLi/WACeSt0q+J6U868mzJ5xUwQ3ptoMr6PNnkBQSNrgmCtbsFBBZSjjBgTK5L0A22lE8pxtr9U9mnWB1Gqu/dek22gsX0GeowJZgBvAVLHMm34dCtVz6JIzYMfDUngBSyEVbm6Nk6Dmtfnm5J3ZVm0oXsSW9WdMD26jWksaiDcJZxynH/YVBfxnezZKKGVLW5c3n84ufjKoqak7UY7knEqHnjOI6VuacnJ1Ll6yPjY9wkuPuid7T/WnZK+sWURqW X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(136003)(396003)(46966006)(36840700001)(40470700004)(336012)(47076005)(82740400003)(356005)(186003)(107886003)(2616005)(81166007)(5660300002)(8936002)(6862004)(36860700001)(2906002)(40480700001)(82310400005)(478600001)(6486002)(53546011)(26005)(6512007)(41300700001)(8676002)(70586007)(316002)(4326008)(70206006)(33656002)(54906003)(40460700003)(36756003)(6506007)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 09:42:12.6954 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 988135f0-3e4f-42ca-00c3-08da6afd4a0e X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT010.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5839 DQoNCj4gT24gMjAgSnVsIDIwMjIsIGF0IDE5OjQ0LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEZyb206IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5jb20+ DQo+IA0KPiBBdCB0aGUgbW9tZW50LCB0aGUgZG9taGVhcCBtYXBwaW5ncyBpbml0aWFsaXphdGlv biBpcyBkb25lIHNlcGFyYXRlbHkgZm9yDQo+IHRoZSBib290IENQVSBhbmQgc2Vjb25kYXJ5IENQ VXMuIFRoZSBtYWluIGRpZmZlcmVuY2UgaXMgZm9yIHRoZSBmb3JtZXINCj4gdGhlIHBhZ2VzIGFy ZSBwYXJ0IG9mIFhlbiBiaW5hcnkgd2hpbHN0IGZvciB0aGUgbGF0dGVyIHRoZXkgYXJlDQo+IGR5 bmFtaWNhbGx5IGFsbG9jYXRlZC4NCj4gDQo+IEl0IHdvdWxkIGJlIGdvb2QgdG8gaGF2ZSBhIHNp bmdsZSBoZWxwZXIgc28gaXQgaXMgZWFzaWVyIHRvIHJld29yaw0KPiBvbiB0aGUgZG9taGVhcCBp cyBpbml0aWFsaXplZC4NCj4gDQo+IEZvciBDUFUwLCB3ZSBzdGlsbCBuZWVkIHRvIHVzZSBwcmUt YWxsb2NhdGVkIHBhZ2VzIGJlY2F1c2UgdGhlDQo+IGFsbG9jYXRvcnMgbWF5IHVzZSBkb21haW5f bWFwX3BhZ2UoKSwgc28gd2UgbmVlZCB0byBoYXZlIHRoZSBkb21oZWFwDQo+IGFyZWEgcmVhZHkg Zmlyc3QuIEJ1dCB3ZSBjYW4gc3RpbGwgZGVsYXkgdGhlIGluaXRpYWxpemF0aW9uIHRvIHNldHVw X21tKCkuDQo+IA0KPiBJbnRyb2R1Y2UgYSBuZXcgaGVscGVyIGluaXRfZG9taGVhcF9tYXBwaW5n cygpIHRoYXQgd2lsbCBiZSBjYWxsZWQNCj4gZnJvbSBzZXR1cF9tbSgpIGZvciB0aGUgYm9vdCBD UFUgYW5kIGZyb20gaW5pdF9zZWNvbmRhcnlfcGFnZXRhYmxlcygpDQo+IGZvciBzZWNvbmRhcnkg Q1BVcy4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEp1bGllbiBHcmFsbCA8amdyYWxsQGFtYXpvbi5j b20+DQo+IA0KDQpIaSBKdWxpZW4sDQoNCldpdGggQmVydHJhbmQncyBjb21tZW50IGFkZHJlc3Nl ZDoNCg0KUmV2aWV3ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4N Cg0KSeKAmXZlIGFsc28gdGVzdGVkIHdpdGggZnZwIHVzaW5nIGFhcmNoMzIgY29uZmlndXJhdGlv biBzdGFydGluZyBEb20wIGFuZCBmZXcgZ3Vlc3RzDQphbmQgZXZlcnl0aGluZyB3b3Jrcy4NCg0K VGVzdGVkLWJ5OiBMdWNhIEZhbmNlbGx1IDxsdWNhLmZhbmNlbGx1QGFybS5jb20+DQoNCkNoZWVy cywNCkx1Y2ENCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:08:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:08:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372608.604420 (Exim 4.92) (envelope-from ) id 1oET6A-00008s-Jd; Thu, 21 Jul 2022 10:08:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372608.604420; Thu, 21 Jul 2022 10:08:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oET6A-00008l-GC; Thu, 21 Jul 2022 10:08:02 +0000 Received: by outflank-mailman (input) for mailman id 372608; Thu, 21 Jul 2022 10:08:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oET68-00008f-NP for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:08:00 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00047.outbound.protection.outlook.com [40.107.0.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id feab7fa4-08dc-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 12:07:59 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM8PR04MB7442.eurprd04.prod.outlook.com (2603:10a6:20b:1d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:07:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 10:07:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: feab7fa4-08dc-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jERV0eYlGPdVcBDZSqJVlIJOO/qOWHtoAlA4Sr9Sq6lHJHQOxx7CroCzwK3sLFBimi9ds+rGcm6n8+gGcYB+UVk0kGwvEfeSwCKyzJeJjKD9CvLTpVAxFarHOxDCdlGE1+vNOFL4a6a5lFnSCaauvAbmKXkPpCK6bBQhZYmG8Jn4MXvqL3h17HrG485KKGMTdWzXjpiCeWLJP+T/qCOIq3Nsyewt8kjUFxLInJJ5kkB9KuCl4keURT+TxrL77YA+SzDYp/Vl9CkieA7V3HNmTKVNSXBsUJa2P4Lqky7yQXxVLTNine0jha49p3T8L/CwjVBqq/qq13CM49j802Wn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xSlHUusqJEH9kKYYEGO54ihvGr+D0UzvhTG+WSF0gh8=; b=f2kZ2PbLVWAy1bT3JoNOZ7KP1qkPjwomC09jIyuK8HV1+4ZYXCEo0la9OdQpr7LxlI+M3MlHCYSy6kuzEz9CT99mowuB08KQdEI19nWAQ0cN2qNBPbbSbu10Q5Jc+CfV/euJhjXn/2LQu3xl62M3wfKUziAxtIMQ03ey71Lbffgp8TK6t0sPKoIHwsBU7x1nhnrF+bR25J/ULpk86vgTyGU38L9FfSRo1AQvodnWOqO0pob8jAfa/GIguyYjH0BkBC5mopkMant0glHH1P3FC51FOwyBeq340lqzsE9La+UfNAErvWcFX1sSaaWDNvsQ7YChLRQCOVQg044uEuUiMA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xSlHUusqJEH9kKYYEGO54ihvGr+D0UzvhTG+WSF0gh8=; b=toL3jtjm/RlnrUmcgB7k2azJBQFqS9Ry3ifuBSKvjw7YDh96c7QC6mpArFM/f5zviNEdZqo7C2umHaW2RW1C3cCQ9VDw/DQSRGhITZARnCU9n47qWjbvG4gcJ+S0WP6s6JcQpJa25YcA4TmzhewN3MwnnN7f41WfgaVgXRnC6uV13AwAiSwTJMin0EUsDFMPxkyzXAFndiaAgTHZm6WOVbW0zngtwKMYsJBSZTMnufBawQZH62hhqts42MBLUxh+m1v7hb26xuca5sa/t8Ca6GGirR345dn2Qa41Mpanek0pLRHvp6WfORxYepmPaOhIK6RmCHD8HVmUJR4dZSq30A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0c9a6602-8b3b-7cc0-981f-3aa67794b68a@suse.com> Date: Thu, 21 Jul 2022 12:07:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file Content-Language: en-US To: Julien Grall Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-5-julien@xen.org> From: Jan Beulich In-Reply-To: <20220720184459.51582-5-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0007.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5fabffdf-18fd-4107-49ed-08da6b00e174 X-MS-TrafficTypeDiagnostic: AM8PR04MB7442:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yrOBUQwW3mQvKulfPNj6rAYQYBA7i2L3WRJIa6RLIK3CnwTjjOUzhZylDHrSl1UgWrCAGv7gVFP4faUHQly+igzKFDrTieYHpPsjL1zdXKS4xWnZq78C+HPZ/waxQn1uS2LFkVCCANjZFBJYexOOivWehxgYHbtvmvuwaP+HEWtGo3jrqwvzc4ArvJhNzNKebvMLqoNCzDusr9BptfiSC3AOnR586TydZ25JbHQd9/A0KL8xrQ3WlXGd8WKVZbohLMu985FTO50utt6Y5KkiTAzns8OUzxhCU0CdE/uEj8s4YuiJOOpWX57QCKaSYSD/mvJyw6AZzmcUJlr924TPzHrKjPonNdSzfVZQPul1e5z+mG7fXD2O9tOzW06IYmoezw4pZc8VaoXxi02s7fzQ4BrLDee0NIPvj/1ZvIh8Z9jVmVE/pPRwBTjYnESsTr7dYXZJg/DxAqJnwrKq7ftXicDxKlFa+tcGf+Oo7czb9PkCkwMJIs6V8ZLrIqAvqdNG0mvLS8kyScHKh3yW9cswW4qmFeAZy8kNsef/YTZpHNO+ifuhleqQhu2JcfEkljjg5mmmByDmhiEQoerbX0D5T+9Pa1zVj5fhDyTM5kKHQ+kWMDH6at0dyBgkKPJZqhczuzMLJFdd6z4uLzu6N0uYowSjvtBZJC7pqnbNFniGULk0XPXPORuWX/VItohjtHh7cRJnAF2sYFsdlCN86Aqs/fLSzHf6Nc4LvMk/H+nU2+eHl6p2930CM+U8zld3h+TGnlg5G4vPrAnf8N6evH5snYkncBuQxBUK54Sy1IizAJZBNJePV3XBAZF087g5ZaDpwByeSzzdFhMvDwGzmGFYbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(366004)(136003)(346002)(39860400002)(5660300002)(316002)(36756003)(6916009)(54906003)(478600001)(66556008)(6486002)(66946007)(66476007)(4326008)(4744005)(8676002)(8936002)(31686004)(2906002)(26005)(2616005)(41300700001)(6506007)(186003)(53546011)(38100700002)(6512007)(31696002)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R21aUlJ5cWlmeklMbkR6VEQ1NE1Ic0ZJc2tQWDBuUlR0NHhJTUpFejhJZjNB?= =?utf-8?B?cUs2azY0ckcxYnplS2FYcTAwVXVZa0NDQUkzUHBKNit6RWNta2xVZnlCYnFn?= =?utf-8?B?K0cwQWpKNzVOLzdzVGxvcTJLMGpVWGpSTklrU3hrb2NuZnVNRkVyVFFUL0d2?= =?utf-8?B?TUdqa1I2UUl1RkEwZTlYcFZmby8xL1hSbEVMUlQzcm1SeCsvWFBMeW54SVc1?= =?utf-8?B?aFRIZmhtaHZEUGQ1Q01KWFRILzVheXZzbjRRUHZSMldKUXVtekl0d24wVmZH?= =?utf-8?B?SFFad2dOYVErK3JkYzNJZDR5empJTG83ZXcxdWFJVVU5Qnk1ZXpNZlB3OGh1?= =?utf-8?B?T2ViTkxkV1ZYYnUyU0loT1J0K1FmOU9NU25tbXQzTEh6QWRqUEtJRXMyQkZv?= =?utf-8?B?ZGJhVmZIMStBZ1VNdFVoMUdIVGFtQVdpbTZ1Rk1TT2dDOGlsR01rSzVuTzR4?= =?utf-8?B?OFl0cUhpTkJVWUU0Sm9tYkx3d0p5cXIyeDZzMEFPdjg1R2RoRy9kTzNTbDVx?= =?utf-8?B?Q1ZFSEhjT1JrbXh4RWx3L2Nhakg4QnlVd1I2WDk1MkFLTjdhMlRzcG82ZElN?= =?utf-8?B?Wk5KdzQ5dzNRaWp1cDdRMGNTUXNOMGRuRG9qOTl3L2hOQ2p4cFc5bVY3emVU?= =?utf-8?B?YzNzU3pZZUlSUVc3Z1hvM2dyVVhiOHpwd1hsYTUzVXRYS3hiM25vVDVSNGF2?= =?utf-8?B?eW1MeDMwdFpzY2liK1o1NjlSZjNrVjljNHRoSDVabXZxajNDSWVaaU42R0Js?= =?utf-8?B?TDdtSmpwb0dRU25uRDBkUURJUUVsUWtvU2p3U0h4eUxZbmZPMnZLR01IM3ln?= =?utf-8?B?RHpDUVd5eU5uc2Nub25NNFdUMkxxcUQ2MVorVlNndkF5QUVNSHpIUW9TRGpw?= =?utf-8?B?U2s3NU1uSTQwNHUxV0NTQkxGN3RaSFh0d0xMSmJUSityOHErajNOc1hHMytW?= =?utf-8?B?SVBkd1hsR0NWejFDZUlNTGFYU0NEdW5CSlBHR0dUNVptTERjNnpiU1J2RzRp?= =?utf-8?B?eHEwMmhraFZZbzlUQzN3SndCcFRBZHVpWUdBTzNUVDB4OWM1M3Z0SW15SGVj?= =?utf-8?B?Zkl2NDlJVnpuZW9aaU8wdmhOZ1lHZ3BxYWVnbVJFV0ttTU9PbE8yQzl4eER1?= =?utf-8?B?SjN1WURCTG02cUpKaFhDQ1RkVmtOTjlrZ2IxNGFYT0hTYzdxa0ZnOWNTTVFj?= =?utf-8?B?anBIQmgrQXB2U2pXelRTL2czeFFXR1lJNElDR1QrSXJhSkIxMGxNc1Boa0JT?= =?utf-8?B?ZUs4QWM2emFkZndiVmR1TnpUV3lxWkpBMVRoVExIbm5yTTluMm5NbGRqY3g3?= =?utf-8?B?UDFudGcxYWVxZDVOYjdOWWZGU2t1aHZRUlVvM05PSitEeWFTeHlnZnZtSEFw?= =?utf-8?B?S3o0SWxsV0JZOGNudjhEbVBPKzJBOVNxNFBLZ0V5Mm85T0ZWWnlabjM3NnJr?= =?utf-8?B?Qnc3ZUJwYUcxL3Z6aFdQSFBha0tabVVscFlrcmJZUVZ6UWt5SHQ2QzJ5N3Z4?= =?utf-8?B?Tm1DbVpHOGhYNzBrZ1NlK0M3S3VxOHNWOUdGNWZBcG44aFMzdHBCcm10bEF3?= =?utf-8?B?YktyenBhVVk1QTJRSjVLcmpXSWVsRXlxL3UxSThoQkNUQjZpQUhXYlRacFVS?= =?utf-8?B?THREMFFJeXBTWnBTemtnQ1NvYmlsNWc4RHBhNjJmNDhEOW5DbmNLejVDazhE?= =?utf-8?B?RFFCTmhBS294RzV0MnU2YVpnYlBnaHlSYXc3WWpWUlNpS3RjUWtqVVZtSlRs?= =?utf-8?B?VzcvajZySmpScFRQb2xiMFZWYm9tTXFaL3Q2SGR6L0dhOGppbXVXdE84aGFy?= =?utf-8?B?dW9rWHV0bDV0K3pCNlRvQXFJQ1UyN0RpWWVCVGFRN0FUVnIxTXJ2R296V3pp?= =?utf-8?B?V1VxOXJpNVh1MExsVVZMNGlPMVdTNFBmaWJ4V2FYREdxVVp1ajRjSjFSS2xp?= =?utf-8?B?VFdUUExTNGZqSklYWENRUTRZTkdzemJsbFJJR3ZEQTdCQldLckozS3VoSmJh?= =?utf-8?B?MndhQVJiU1dvVU1hbGF1RGdZQ2hhSDNzU3VOUWtBWTJuZWkreEtwZG1wdUw5?= =?utf-8?B?YlRpVkVIVjdsSVRTVzJidHNaU295eFU2NW1aejNUTFZGWjViSTVNR1EwT1JZ?= =?utf-8?Q?GU4dmsZBFeS56gT6l4JeKB35G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5fabffdf-18fd-4107-49ed-08da6b00e174 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:07:55.4888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bi/2xJQKnvSzRLMKCwaN4iEEEwIDGyjkqiTxixBoiSjtsidPtibIa9hF2DwVg/QGIVKQRwoWlsJhT5XAlLkOqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7442 On 20.07.2022 20:44, Julien Grall wrote: > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -11,6 +11,9 @@ config COMPAT > config CORE_PARKING > bool > > +config DOMAIN_PAGE > + bool > + > config GRANT_TABLE > bool "Grant table support" if EXPERT > default y Is this an unintended leftover? I can't spot any use in this patch. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:10:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:10:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372613.604431 (Exim 4.92) (envelope-from ) id 1oET8C-0001Uz-VF; Thu, 21 Jul 2022 10:10:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372613.604431; Thu, 21 Jul 2022 10:10:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oET8C-0001Us-SU; Thu, 21 Jul 2022 10:10:08 +0000 Received: by outflank-mailman (input) for mailman id 372613; Thu, 21 Jul 2022 10:10:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oET8B-0001Uk-Ow for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:10:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oET86-0007KB-93; Thu, 21 Jul 2022 10:10:02 +0000 Received: from [54.239.6.185] (helo=[10.85.97.231]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oET86-0007ld-18; Thu, 21 Jul 2022 10:10:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=Pco/YHE1BsU0Rcgzd2h0YBe6QK4X1/OMDVePGOHHDYw=; b=tw6SXF0C4GnZ/RtDy4TiwvOczm vqLMruZ7vgGX0yDiSUcPADvQcw/+Q1H6jcTpynkDM/ioLnm64SaSNvqSQi+kW9cwE745CnsXSNkd2 /GvwRNYE9Iswo35axGhFchjfUYKRu0SjnqjWt+Y+RDMygLrptdxUIWQVmjzA88q7+XZ0=; Message-ID: <3e28e8c4-9c80-59e3-6c8f-e0f357d9ae88@xen.org> Date: Thu, 21 Jul 2022 11:09:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file To: Jan Beulich Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-5-julien@xen.org> <0c9a6602-8b3b-7cc0-981f-3aa67794b68a@suse.com> From: Julien Grall In-Reply-To: <0c9a6602-8b3b-7cc0-981f-3aa67794b68a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 21/07/2022 11:07, Jan Beulich wrote: > On 20.07.2022 20:44, Julien Grall wrote: >> --- a/xen/common/Kconfig >> +++ b/xen/common/Kconfig >> @@ -11,6 +11,9 @@ config COMPAT >> config CORE_PARKING >> bool >> >> +config DOMAIN_PAGE >> + bool >> + >> config GRANT_TABLE >> bool "Grant table support" if EXPERT >> default y > > Is this an unintended leftover? I can't spot any use in this patch. This was a mistake when splitting/renaming the config. I will drop it. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:19:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:19:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372620.604442 (Exim 4.92) (envelope-from ) id 1oETHF-0002UM-S3; Thu, 21 Jul 2022 10:19:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372620.604442; Thu, 21 Jul 2022 10:19:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETHF-0002UE-PA; Thu, 21 Jul 2022 10:19:29 +0000 Received: by outflank-mailman (input) for mailman id 372620; Thu, 21 Jul 2022 10:19:28 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETHE-0002U8-Ci for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:19:28 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140071.outbound.protection.outlook.com [40.107.14.71]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 998b67a6-08de-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 12:19:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB4077.eurprd04.prod.outlook.com (2603:10a6:803:4b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 10:19:24 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 10:19:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 998b67a6-08de-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ntljw+vnOapobpr/a6k3U0KLx2ud1n0qRjZv8Q28JFNg+HMUrHhowSLmohlIHlYTbQfWYtAdm/cu9TODAfmjhy4wb2ZFiy/nU+KpcPy4LO282r9+IBjjcmRu1047ZUheDD0HoExSFslIuEbRjoCX3rPkXo6QgqWhHHBySuiqn+PE7JGOrwIjgtwdD1l0qe/cMLISXgAchbsIuhJgbhvSsz1tPSF6e/KW0mGaXJ4/K/2kkR2D3NQO9IwZptXUfv/0wqkyv6Obmof18eljBmOnhd/N6gq47Pu7Ovw/XOZCJaAnfZlgBohQHuXxSpUz0BhXh6HlYoiZbAiV3TB2DnTMQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BYQPAfY154PcZSxi7JMTTG068QuW44x+WnKsxhbnoKg=; b=MaxoEOIc/KAnrGf0EzI+Yv6ip3YPLdpMYHQ+tcvc6B+meSkYRPDQ9KXlbdinNKH9NkcZjfk5V1FMaMIr7T+f5qoZJNzmpQaHuf5Hg3KZp0fG4axLO73h9/jZd5RnX1A/Cbk6qpInDWwttKyS49iNCKVQ4PRJxdlhCnUKP8TIvQsc1bzM+8CydYrrmL1raD4jnu07eS4Sj7wl+wRGEH8gHD/7VNFFdWBQUnSDWTDoFEMPESfeqP/NTLthbnBNcsgcl72Stzb6/cWi9guQYdIoV0YXbRguilm7kZO7dZkGJieWBUIqFo+az2SqGCRKIJq7jZivgqht87/q91MgPeJWXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BYQPAfY154PcZSxi7JMTTG068QuW44x+WnKsxhbnoKg=; b=uNcaBBU0/FlkL2PgXyzj0UFfn+MzXzp/EOV6cK/sCHgPoit8e1lA0gni5FOCDdEhS1jLCk06BZd+nMjmKPSH8cPxCooT2oVrTqUaP2TgS6KDBExNqrqsUnbjspN3oRXQediMYk6m6xC8bdhPoaePVUnwNtyuUPwwEmhh5+KuWVHFRGIO53axHKcfOnjoq5mrVaVcpX5SDAW3yDNCrTKpChwztQ8gI69yvMIl0pTZgQhwR47E9BJH9PHH7fmMivksr3KKUfENMfzdo0BoVNOXFwfKMQwpd5oQCHGfA4SASbQl5VeIK9DMRj31IKaF+uSAe8M+8QHW4II3f3CE16grqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3160640f-f74d-725e-f2fe-3d33c4999772@suse.com> Date: Thu, 21 Jul 2022 12:19:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Content-Language: en-US To: Tamas K Lengyel Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0121.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95bfe582-eb26-4c3f-ce4a-08da6b027c47 X-MS-TrafficTypeDiagnostic: VI1PR04MB4077:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lrBTER3e3IybvFTjqDovOhxj5hzLqqli1+1a44WI7vc5WlYGwgkWydHv1wgMnGhHaxkSBIA4I5glGzyQhd0Y9is4LsFJ9y1wJ6mAmDeWGnuHtwyUnZaj12IaeL3onYIKkaNA0Szw/WESiqo6cQtP+dDXmaVStnj5EpRgC6c9bIq3KxFLGQrvk0QulbYmwGaEEArLhADIfplPntkV0evoWaDk5pg4vH3UbgsHz6GY52IgthlJtyF+syYSuixEmzA8HIeFukONFq/Vfxi1zaMBhRQBZe3GMgHGCOkRb4JZ5MxFVG+VNo3VP5sYiRLenZ0gYfVB+FXMrZ4o4r/8owv6HkbVOrtR9cFKSjRh9VkqRl65c91/CDFAdoFmD5GnQh7k1qiRq198vju1L87yyyAm6AhDDzDXsnhbP1uGdfE1arYV80CLVjNnLNuCSGZbFs1Iea5Tyl+bmkrB/cYh0qVuPGChVvR6sRBp6HY3P1VzzDbpXl+hMbqm/kCRucyUIL5z8qX0NFrDznvJniHobiN2cA+9usRVv/UWEz2i7gnqNdXKYzoMItO0gj9qNo4Cl/pGMGvuZvaB9c6qwIUSfx7Ps4jUjQykDBmGhw81OoJTKa9DXTsWY1KCQ+BWxJojw3ZNGIH1kizfxkTt0F0gkO5rBt2OCfIgzw57Hm0HnEMjM1yn65dYDWbcAlS042Wu6kqbvH36RCCnWpkhF9UJCnyIsz4uq1uWnWXIj3nwV8wUTd/oeM31bOb7RqQOHuDNehzoQz/i0MLu1eURgRi1y9yZ70ly0w3sN5E6GSm/tCpyeS2N+A9RPeMrmPx7F/IhbyJ5XkE4LCZv/dyTRumZOyEisw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(376002)(39860400002)(366004)(136003)(31696002)(2616005)(316002)(6916009)(5660300002)(6486002)(54906003)(186003)(38100700002)(478600001)(8936002)(86362001)(66476007)(66556008)(66946007)(4326008)(41300700001)(6512007)(26005)(53546011)(2906002)(31686004)(36756003)(6506007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVdwbjJFdncxcEVybGlwNjVQamNEd3FRcEkwRVRjdjNwc2VnSkNPY1ZNLzB3?= =?utf-8?B?MjEycGlXSEMxOEN0KzFIamFNekxPczRtZUl3SXMxdWM4S1Y4M2NOeGFscUJs?= =?utf-8?B?bmdhQVFUY3p2WWdTd01PQmJoYngrdXJxcVE4UmM2V2tjTnVoNEdQMi9yd3NM?= =?utf-8?B?ZDMrUzhZTXhiREE4ZVBCbTJXb0t2cmFCUVB4VHpiaXpBZlNCVTREeWhjRlR5?= =?utf-8?B?S3BjSlA2bWFqeWYvVjNPWjg5SlVMc2kyeCtjRFB2VlRkUllFLzFvTGo4c0NQ?= =?utf-8?B?NHhzSDRCSGN1ZDY5T3dBaGF4bmFlNHhHcHBqYklPdmhMRGdvdUJ3ZFhKSDhN?= =?utf-8?B?bXNiOGhTUXJ0SjdTQVZsazg3QVdsL08xSTNMckRqeTVyVGZyTDYwcENHZzQx?= =?utf-8?B?dCtKT20wbXpQRlpld2dEVG9pZ2JDb1BIWlJENXZ5eGs2T0JDNzJQNWhmK1V6?= =?utf-8?B?dk5KR04zUlBORVFQbTZJenZ4NWV4TzBXN1NHSUwrcVd2Y1FHdUVoK2ZZTGxL?= =?utf-8?B?aTBmZUl0dk5QNU81NjlpdHpZQk9mZE1UUE9PbVpLNGg3RmNIOHM0YVpkVVF5?= =?utf-8?B?MGozRVY5QmNzUlR1MWJ0emJ3cE9kL2g4SGpWREZIMlFmQnBDTmFVMzBYa04y?= =?utf-8?B?NDhKR0FXMFQrM3dyZVdoay9PRUdwSTV5Rk5hUnRNV3RERFBIdFlsaWdVeXZG?= =?utf-8?B?RXBEU1dEbitEQlhUaXRmSldYYVdpS3k4KzZrODFTZ0FGcTJZSk1PdGl3QjVo?= =?utf-8?B?bHZMVHBOSHE1bjU5VlFsaVJ5ZDV2ZEtESG5rWERTZ3M3NGlyS3VEUUFudFZa?= =?utf-8?B?ZUZrTHJ6b2c3QXloclNPZ0ZVRlV5L1A5TUpnRUt3SDRqZzhQekwwVFhaWE01?= =?utf-8?B?dzVST0RPRnhhcXdXS2xZS1EyaDJjQ1ArUmhGWXBBMGs5NWRYcnhOdlkrNjR2?= =?utf-8?B?YTYwdE1sTzQ0bVlCcGc1SkdEK29mbG1mNGRPRExveUkwTFlWbmUyMEkwRmJF?= =?utf-8?B?bEFCMUM3VW04eFhkL2N1V0hmNDN5ZzFGL0hlSzEwVjNVajFjSlFXbTNCamtz?= =?utf-8?B?bVNYb0g5ZW8zSTBDbFpaTllMeWVUQmVDSHZ5QVIrVjRNNE5uYzZvS0VHemNz?= =?utf-8?B?dlhjRkNTNTllUjhmOENrZjU5VE9JQ1RHMEFEcTREbWhUS1NsZWg3aWQ0ZlQv?= =?utf-8?B?OVBEckR6a3JmeGFCZ3hXMjNaWlZ2azNCbkdPa1FQaCtFSk1BdlZiYWd0YmRJ?= =?utf-8?B?RExNdk9qS05UUmY2UGovZGV1aVBaYXlaSVlWYXhubWNXN1JrYjdaNnRFcmVw?= =?utf-8?B?R0J6ekpEaVVTdVhwZGpLc3BhTFhZUU5LMlpXNjBZMnlMWG5BUzRrSU5VdEZL?= =?utf-8?B?Sys5VDZjWjI0ZWVNVjJ3OEpKTFFXYzJLYW5QMGpBMFo3SHIwQkNKUUxzRTdI?= =?utf-8?B?UDJUT0I5SnJwc2Zyd1lJaStIUVc4bkF1VHY2VEtjS2grSkNzSTJhd2VkV0F4?= =?utf-8?B?UGZmaUl0RGIyd01iTlEybURjbEc2VEN0U2FuZ0V4VitCRXhUVW1OelRrUU5W?= =?utf-8?B?SXJsSFRrWVl5bDZiVU5UL0tyN3F6TXlwY1oxUWF3V21sTytuVU85UlNWVlNB?= =?utf-8?B?YjR0Z3hPZUQ1T1MwSTVTVEJ3RUZERlVxVlVEcHNhMnQzdWtnaVQ3clhUL1N3?= =?utf-8?B?S2hyMjd6QVROUEpBTzRyU3RQU1NMQUVtam1qL1A3cnRXdWUxbFlLYVVYYU8y?= =?utf-8?B?OGtoQWw4clZ1UmhOWmtaZzdxeDdkRVFoQ3RZQ2ZrMkNFakczNkN6NWtpdnNM?= =?utf-8?B?Slhmak9DWWxMZTZhYzJodUdLcUFyMkN2V3JqSlVnZWdrMHE0Mk1PcUZwOTNk?= =?utf-8?B?cVdJMGpoZWsvR1B2OVdzSVVvL0Y5ZFhhZVoxbWpyeGFzTDArZGpmYmJsMXAr?= =?utf-8?B?bzZPbXBrUnJ1ZEVUNjhoWHc5djljOHNGY3JBSWFvQm1WVjY1ZlZLRHFRL3hi?= =?utf-8?B?STBiQ1NpMmw1LzR2Y2NDcWpGQ3Z3YzZlUWxnVzhtS0tvMG1LbGVzV0lkNCs5?= =?utf-8?B?ODVjZi9JSWwvZkNsVjBLWjN3SElMS1RkWXZESTF2VTFZQnd1OXJ5dkp4bG1w?= =?utf-8?Q?BcFlgKVSkPh0+DjG0ayZ6S7GL?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95bfe582-eb26-4c3f-ce4a-08da6b027c47 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:19:24.6627 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IjeJsK0frO6p7pNA6j1tcBSvC+2g9mt8ysKV/4bjXNH8iEqhDVklvquq4Ve7uopMDvAaZxY/du6ipom5TXmIig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4077 On 20.07.2022 20:47, Tamas K Lengyel wrote: > --- a/xen/arch/x86/mm/mem_sharing.c > +++ b/xen/arch/x86/mm/mem_sharing.c > @@ -1653,6 +1653,46 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > hvm_set_nonreg_state(cd_vcpu, &nrs); > } > > +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > +{ > + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); > + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); I would hope two of the four pointers could actually be constified. > + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) > + return 0; > + if ( vpmu_allocate_context(cd_vcpu) ) > + return -ENOMEM; The function supplies an error code - please use it rather than assuming it's always going to be -ENOMEM. Alternatively make the function return bool. (Ideally the hook functions themselves would be well-formed in this regard, but I realize that the Intel one is pre-existing in its present undesirable shape.) > + /* > + * The VPMU subsystem only saves the context when the CPU does a context > + * switch. Otherwise, the relevant MSRs are not saved on vmexit. > + * We force a save here in case the parent CPU context is still loaded. > + */ > + if ( vpmu_is_set(d_vpmu, VPMU_CONTEXT_LOADED) ) > + { > + int pcpu = smp_processor_id(); unsigned int please. > + if ( d_vpmu->last_pcpu != pcpu ) > + { > + on_selected_cpus(cpumask_of(d_vpmu->last_pcpu), > + vpmu_save_force, (void *)d_vcpu, 1); No need for the cast afaict. > + vpmu_reset(d_vpmu, VPMU_CONTEXT_LOADED); > + } else Nit: Style. > + vpmu_save(d_vcpu); > + } > + > + if ( vpmu_is_set(d_vpmu, VPMU_RUNNING) ) > + vpmu_set(cd_vpmu, VPMU_RUNNING); > + > + /* Make sure context gets (re-)loaded when scheduled next */ > + vpmu_reset(cd_vpmu, VPMU_CONTEXT_LOADED); > + > + memcpy(cd_vpmu->context, d_vpmu->context, d_vpmu->context_size); > + memcpy(cd_vpmu->priv_context, d_vpmu->priv_context, d_vpmu->priv_context_size); Nit: Long line. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:25:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:25:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372627.604456 (Exim 4.92) (envelope-from ) id 1oETNO-0003vf-Jc; Thu, 21 Jul 2022 10:25:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372627.604456; Thu, 21 Jul 2022 10:25:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETNO-0003vY-FA; Thu, 21 Jul 2022 10:25:50 +0000 Received: by outflank-mailman (input) for mailman id 372627; Thu, 21 Jul 2022 10:25:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETNN-0003vS-Cx for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:25:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2051.outbound.protection.outlook.com [40.107.20.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7c81922a-08df-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 12:25:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:25:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 10:25:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7c81922a-08df-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RV0nHcu42Ovfq4JuHS+v6xpylUGRYvcOvyDtunqb/Jft4HjkflrK036X1V3zemzLKKYFfVZbF2jup4yto1KJrohFUYRv5i6uZAcFGJUMzsBzIgYgBXwxZKxiem7SbualbOc90xNaOnHA2Fx2LgzV49UxEy5fNTkk3pFjU//16J/rZY3rqLPR1BdO71hKxtUOs1tjSszLRbplDoasquBI6DZcZhCUexMgKWcnAhUEfrAd1zGqh3rL+SgTEZcbT2od2tcmPi3EnDpZoA0SYg6XjuGVuvm5u9ZdxTgAWZCKGLiQk0Aa8n/ANCi2gkAQY80yQueFFOZksrWA8H1HdaVqOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZ99+JJHEW7/SDCvKqCeZrkRtJt1Wc2lOVB9VpAxiHI=; b=V2zy61CburQRq3sDphcLe+StaYU7XZp4VFMYb7omoVcW1wip7WnCo3JpmMMuBAACaC1QBr6NgeVmFesXgFBWxalp0ZYaX9KJhqf35/wxNDKY/BX2i2iUaFpMMVw6xrzQ5rChY2NnuX9bMn0JOfOyaK0LNuE5o8nHBEhD93jF8gFm3tK1PdwsRPvRSnlrQm2wwjIZM0telxAjYuXizOHrjlbDLZWiEDHU0vHYG0ffIiMW8QomyPmgyu2DfWmmqAPIn3lK21NJGl6slnBDc/sgBkEPrgSQYD3aHa2071dvWdaburKOgnog2DCigVjMYhEWYLM6LWzOoMuXDJS0hbNr/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RZ99+JJHEW7/SDCvKqCeZrkRtJt1Wc2lOVB9VpAxiHI=; b=v7A7IXaO0xEDgFWvexzSJoK9zWgs47k053xPgJDMtQVgvrw322Bzkc420/jAAAE/lVWffyR24g6tpJgur/MSRHmzTTWu8BdO3FWoHeXtgE3cp7HsC0vF1TL0ynzxAt5fIw8fWE4lQt/5RojOYAfAhHMLcchwkHdmyZC8Y4U78ure0TzwsVr4QGweS/5nBOJmNb/LAMAaqwrwR964u0jNC8N1t+uaWaRBWyHsa6wOYsB/rn/NzlXIhgwgj2V2iXMJHFPM4CssaVv1coXm3gMH206G0ZGz/Rnfi50yzGF8MBYh3n3z7mw14g0FkU0wHLob1iy23eKu1iy2ah8SjmSltA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <923f6623-1ea4-9089-d693-7a21570327e4@suse.com> Date: Thu, 21 Jul 2022 12:25:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 1/9] drivers/char: Add support for Xue USB3 debugger Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Connor Davis References: <80051b9dc5c99532e18a10a941c3523945d77698.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0112.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3f0119df-84aa-423e-c2ef-08da6b035412 X-MS-TrafficTypeDiagnostic: DU2PR04MB8551:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LUST/UAwObrYx5UYf0Fm44bsHDwjX8MMXJNvL3RG6m0VJhAAJlZqIYm7bUVHWl1dn3MtBU0W/WtgQBRZCnznElWTBJABfuZV/sivaYb2ckGQhkEAS0lunnRmlkdLlwRk1UtY++sBc+5MjQWCDFsp/JvWCU1TEy4+ILB3h50mQAYhok/kldALMdmEQurQrhCxvfAlWE67zkBiFHZmlq7CTy5vX4yO6F1l91JXLN9TCkskA5IQIgmFtT89Y0ymOVpbpAzlL7tAZNaMz8saD631xvJGOTxcjxxY7B6ausGwxvAl+WDJigqC27QiEy/+LYCN9xf1SXtTuxxoB8IZicbPkTna0dJnP/S6jYmr9KUhlrlmplyWWmtEZGrqh3dxDYIh6pHnbBTKDjYQWkYOLn/4rrHxfTFx+ehGAb8MWjcPNZFOkryNGHFgGerVtmHWqZk16VhKXlThZb7HXPoiPKioYlfNo2UxOnJd4WMIoYTV/f4optRnSzbZ7Q1FH0F2OWHAB4hxfO92uX+a1b5xNDyAUvLPtDLHXYcJuoL+7717PJUsuxldKmv6c71P5WwxGL07kSTgqkFHFUMNgwV/wjKyBHRStOllCLjtb6feR7MZPvFbmENIYvuAEaZq0JS9eKcNVhrckuAKF4t0sZiJ/X/rZ12vbWHd++2UL1gNdombsLh9fwPNXn+qc4ezxwvodr+G9kAcVcsS85HwV2NuOp6aTDWap91JOTqGeH9tNrnHJhb4dqBL7SLqCbXNWrUN3fythP7leRB8Om9amHTMRdyAsRJKtZQIL6xinfPnvjne6TRfwFVRMYBsZ+s6QKRS8UWWBTxehGA0XOwkWbRK6cOtrg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(136003)(346002)(376002)(36756003)(8936002)(26005)(6506007)(6512007)(6486002)(53546011)(478600001)(5660300002)(2906002)(41300700001)(31696002)(86362001)(66476007)(186003)(38100700002)(8676002)(4326008)(6916009)(66946007)(54906003)(66556008)(316002)(31686004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V2h0TWM3WmNpYSs4Wnp2dDJUTzFKSzM1YTd3Q1dGZ0VaK09qWWMzOHJXekVP?= =?utf-8?B?Y0wrQUoyNGVhMnUrcWUwLzZTczBMSFJma2VSMGt0cGhNbnllMVdGcXVLVC9u?= =?utf-8?B?dzd6VWlJbjFna2N6b1BPQjFUMys3S05vL0ZQTk5hZGJaNTVMTkpjMzh5bzZi?= =?utf-8?B?YVJWWFNkU1crNnp1WTI2UnpZMVpWM3JkNUtzcUoxMlZDT1RKWU9tblR2RU5X?= =?utf-8?B?cmVKNktpQWtnUGZjbHdneWpVM1IvWU9mSkJTRU1SQ0JkTXFlUFJWNUI4VnZN?= =?utf-8?B?ZkFYOGpOZXNOS255czRyOFM1SkJlMEU2ak9jcEYwaDBHeEFMQzRhQmswV3VX?= =?utf-8?B?YUxHbEt0MFArNncvcmpLNjkzM3FBN2ZndTFjSWJLM0p6QTVBbE5PQUdtSlU2?= =?utf-8?B?NTFjY0k5T3p0VTRhcFp5dGhiMWhyZjc0eXpNaUxpWmZRMEc2YWVRbkhjcUVL?= =?utf-8?B?bUh4WnZnZG4rd0k4M3l5bWtjKzBSKy9Ick5jeWZqRU9KcjlTM1VqQWlpYTVH?= =?utf-8?B?RWNTTC8yWnRNLzNKL2xDZEk1L2ZlekdYT1ZrLzVObFNSZ2ExNm42SUtCSjY2?= =?utf-8?B?Q0tQeStUSkFqeVdmYWtMM09ManFhR3dqQmQ2S0oydUx2bWZmcGlQd0FUbGJm?= =?utf-8?B?T0s0WXdnZXpLOWxqQXR3b1Z3THBpMHk4Und4aThRTmNnMW52cXc4S0JONFdu?= =?utf-8?B?MENkdCswQzRMS1dJaHZBc0VmM2RUTlVtc3V6ZlF0djQybEtrLzcxbThTWW9L?= =?utf-8?B?b3lHRm1NNG05Qi9DRUNsTklWMEN6RnJBZEtGbE0rVG95YzhPNUozVGlmNEU1?= =?utf-8?B?ZTVPM2RmWnp0ZlM1UmlaSGFZN2p5T0ZRdENwQW0vYzcrc2Myc0ozb25CNi9j?= =?utf-8?B?MllsMTBETkJicy8ySi9IWGZLMzVOSzdrVm9jWTFXckYyUlFwakt4bzB0Sk9Q?= =?utf-8?B?NnpTSnZFRTlBVXdQd3lXWUR2cVFUbjJVVTJSYkFjUDhjRmZxTXpaQkNRUmJD?= =?utf-8?B?QTlSTzIzUFhPWVNUQ1U5dDE2ZGs1am1IWkNKbGFOazdOWHJmZU9IWHl1U3c3?= =?utf-8?B?M1RUVDRWbFNja3FMdWoycFRVZktaTjB4elhDOUNlTWM5WHJnUEd0VUdJcjIw?= =?utf-8?B?QnR4NXFheE4yVVhHRTN2SzRDMVlpbk1yY0xtZ21jOXh0N0dZVStld24rZnQv?= =?utf-8?B?TWJMTzg5K3JsUUxDc3E2TmY1N2pjWEVYelV0ekhMLzcyS0NOcEs2akpkVE1i?= =?utf-8?B?NHJaaU5WaWNtcFR4Z3o5M2J0U2drTGJnSlZUc1VPblQyK2RBci9ucHJ3STE5?= =?utf-8?B?M2xqNm9IOHBVemNiYVdoSmhCK1FDTm1HaHAyNXdKZmNhSGExWUZmeVFidG9S?= =?utf-8?B?ZFJ4bEIyWlJiRW4vUlg4TkZhWFhKU1FRMlU5QzIwK3g3WmxPbURjazM3bnNQ?= =?utf-8?B?ODNieWhqOVBSZWtVYkhGcGtPeVZGYzlKZHRRSGczaVJrRlU0a1JyZndJVlVu?= =?utf-8?B?UzRmUGFJTEl3a1lpSmNFTHliWmtXSndaU0Q2WXk3VWpQVGVTUlBSalR5Z2NU?= =?utf-8?B?Q1NQK05lSExiUjhjc3RsQUpERGhWclAzMXZYZTJvV3h3WEZhdWVRcmRvbGZ2?= =?utf-8?B?dFFZalBqaUVuNDhiaUN3TEwvK2htcXdLakdCdS9HL0s4eE1MTlpRMFNDVEpW?= =?utf-8?B?cm1VbFMwS0tJeWVUUEM4N3hnQlBXZ1U2RFVtZU9pNE5QNExqeVBOZ0gxQ0NT?= =?utf-8?B?bnliNVRKVlVKQlFjbVFUazVNWS8yMFJTWkR3NzA3MTFIeUZ4NG5HU1gwQkVF?= =?utf-8?B?ai9TcThqSG9FNjRPYXB3VXlSclIxbzVXNllhWXl0S1pXZFUwa1lDRG1YTGcv?= =?utf-8?B?U0pRYjFRcDNJaHAzbzRHK3ZOaGFkbmN3Zk1Sc0RiNFVTYnZacVphVHRhRjZQ?= =?utf-8?B?M1JULzFZNWdzSjhJdzRWd0JMUEZWdnhXK005UzZkMHlYYkhxSkxWSm9NUDhR?= =?utf-8?B?NEJJSnoxeHQyRW1Xc2x3ckp0OHVxeTV5ZWtrUTNGZTNVSTNjVHlnankrM1Yw?= =?utf-8?B?QkRVOUw1S1pKUXQ1c0J3VGlTNC9nNDZVdTVoOHZxaTR5KzdLeWtDTGhYY1hY?= =?utf-8?Q?uFj4Ae3MUASROgcMnzLPjH/FF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3f0119df-84aa-423e-c2ef-08da6b035412 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:25:26.7342 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: RVysfzuBqbkjONkOWMja5ruThx3CiYPF5IXWJZgT53e2RmUwbPdJocTgyxzHViC0X15hQOcR+J69lYM7O3xrRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 On 20.07.2022 22:12, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 01:58:25PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> +static int xue_init_dbc(struct xue *xue) >>> +{ >>> + uint64_t erdp = 0; >>> + uint64_t out = 0; >>> + uint64_t in = 0; >>> + uint64_t mbs = 0; >>> + struct xue_dbc_reg *reg = xue_find_dbc(xue); >>> + >>> + if ( !reg ) >>> + return 0; >>> + >>> + xue->dbc_reg = reg; >>> + xue_disable_dbc(xue); >>> + >>> + xue_trb_ring_init(xue, &xue->dbc_ering, 0, XUE_DB_INVAL); >>> + xue_trb_ring_init(xue, &xue->dbc_oring, 1, XUE_DB_OUT); >>> + xue_trb_ring_init(xue, &xue->dbc_iring, 1, XUE_DB_IN); >>> + >>> + erdp = virt_to_maddr(xue->dbc_ering.trb); >>> + if ( !erdp ) >>> + return 0; >>> + >>> + memset(xue->dbc_erst, 0, sizeof(*xue->dbc_erst)); >>> + xue->dbc_erst->base = erdp; >>> + xue->dbc_erst->size = XUE_TRB_RING_CAP; >>> + >>> + mbs = (reg->ctrl & 0xFF0000) >> 16; >>> + out = virt_to_maddr(xue->dbc_oring.trb); >>> + in = virt_to_maddr(xue->dbc_iring.trb); >>> + >>> + memset(xue->dbc_ctx, 0, sizeof(*xue->dbc_ctx)); >>> + xue_init_strings(xue, xue->dbc_ctx->info); >>> + xue_init_ep(xue->dbc_ctx->ep_out, mbs, xue_ep_bulk_out, out); >>> + xue_init_ep(xue->dbc_ctx->ep_in, mbs, xue_ep_bulk_in, in); >>> + >>> + reg->erstsz = 1; >>> + reg->erstba = virt_to_maddr(xue->dbc_erst); >>> + reg->erdp = erdp; >>> + reg->cp = virt_to_maddr(xue->dbc_ctx); >> >> The only place this field is read looks to be xue_dump(). > > No, reg is MMIO, all those assignments are actually configuring the > device. Well, then the pointer would preferably be marked __iomem and the writes should be carried out via writel() and friends. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:30:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:30:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372634.604467 (Exim 4.92) (envelope-from ) id 1oETRr-0005eH-8Q; Thu, 21 Jul 2022 10:30:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372634.604467; Thu, 21 Jul 2022 10:30:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETRr-0005eA-4f; Thu, 21 Jul 2022 10:30:27 +0000 Received: by outflank-mailman (input) for mailman id 372634; Thu, 21 Jul 2022 10:30:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETRp-0005e4-9K for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:30:25 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 211e2669-08e0-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 12:30:24 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8551.eurprd04.prod.outlook.com (2603:10a6:10:2d6::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:30:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 10:30:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 211e2669-08e0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gkQjVnPhZEQ1jSNE1/65Aoku5iSzXFqBa7F5kat8a2NZALNUQXEfFYPIig0FV/R3gy1cTMaSdjLQeH24czDUjTwUK7qQhzEMOjTb3SUOR99zoi/LmPzlhGjUt1ZaDILMmtEUY3DIol/oytli0yPR83hFfzYFZJU4acykWlQ1REWk+m3l11vhvB2IPzeMdHjabuaGkyXsD8o8gcKBaeyqqY3R2mapYOAe5h9gZUVK4hULRx09BYxVi8SnAtyOAp7XiAbZqHzfokcvXFz8/jtOU6B82WzYGmawNBM2iqpabEDFM/gEapVs/+RZDXE+c0ayhNVBoy6+w3ZkNXmGbE/6tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B/ab/DOg3tdwPdjncFnOMa7rsl9SBFoBkrkz1z2TLaI=; b=B94SEEy/CmsnRhRsaAIGPayUG5OADApPN4heXtsz6TTkGkjAmTeEPGP2MuSIkbsjhELRm97ZujZJyPiCPOlGjA2SI7u6IN+5bEnH3Otd/FO55tBHRzKwc3uCarqhLSwDpFp7q8aqYtlFZfcgukciArzci9aNvJF3WlrzLJxL7yH5GKfw1dRVICBwV2Ngum6Jh9O9g5yVYAuKwaOwlX8Pm7sTK9Ay4ihOVyyzGqGntdi2OiZng45WFNDXE7wRoxbQc3zIEE2/RgH9IjPi2f6ePR3q2WzKFQRM2VO0rNSyUs6M+15NTLblVSwI8yMYg54vGjRVobYPU1JJssV2FTgBwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B/ab/DOg3tdwPdjncFnOMa7rsl9SBFoBkrkz1z2TLaI=; b=hbvUrOxg6SONRnKaadhLVAzEf/Fg/ycEZSihJzqixFZy7mArXAGxA6ZaaS3H8DcXY47IKcRzCYXpx1K2OxJHZORWIRdOF3VGSIP7EsKcxwrRQJ6Ob4zDC1IwyqZh6SAzxzk8qJHF6LNyZHrlG4UxZPZZTc1qT981kEorry4g8kB2Qh0jK8iUnIPE6ltqV1oTQkZCeQLfLC9uidTmko0IWhDkTfGYp3sbuiJ/OCPXLygi0jvV7CtkamRc87JP6xyQLL71BZRNqzi+dndTUrj50HFCzQ7bf0Tm1xzyO7cHVfKYGi9I0QD9oAr8AE6CsGIqpcv+BQ7DVYAGsQHkanTsyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 21 Jul 2022 12:30:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 8/9] xue: mark DMA buffers as reserved for the device Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Kevin Tian , xen-devel@lists.xenproject.org References: <0a30e15d9195d0cd09a5ea94297dc8a74bc12c97.1657121519.git-series.marmarek@invisiblethingslab.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR04CA0035.eurprd04.prod.outlook.com (2603:10a6:206:1::48) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea831996-3d58-4fb0-29fc-08da6b04046d X-MS-TrafficTypeDiagnostic: DU2PR04MB8551:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CY/5w9qqgO2GhdLnPR+2dPgtcrWwUwq6jWet2yaPWoBRJYDu+CbjXx9gIcZvBUA/GHgxYkC6kJHGvAzDicG1THOGiBCrE5M/g2SK/WxA5bmJuMsdCWd/DaOZvXib+e98U1hzuognkJB9BKHQ6bN8JtPt+UWUgMfcqt1ddK36U/RrpvJoK8Df1yNwfRtgmG/x6rIDiDjoQCkdOK0VfJez7c3u8KiXVxUC4xXAmI8LEslbJiVfBqLKw6RNI3V/DpI/Vr8g56Ybol4+d89IJwlAbYrQTbpLktSOB8ZgxstR/HFgoql9QEHr+deTm099MshD1JrgOszu7tXPce+UvJWp+SNh1tB22ogPvtx/0sZFY2BbhVQYNYaLk6v8KtztnqQZrEL6FKmj+vMiPqq8joshVb9r8rWzzxPhFkbR6yX6ovol0UgrgR4ZK6WIt97pM/UikCiEFpTQtWTdhUzPkr4dpdhiK4C82bpSSp7WIpAjJGJ+vRyuKZ8RTucUtU0Ccu3/H8NlSNDrv8USI3+vFoninkvw+nw2x3pRMgzmIkbpSOTubAVomAsX2oTSb6gxQy3TC0yJ+Yu5u+edCqMByUUG0d+VFcE+pVN+wGcZV1rAdb8Dmnc89Lr7YwgYG97TYgIx+oap2te39HZcTgF5mK+gJlEc5RTALU2tk5ofqfs0qpzXfpXjJZ40qyEO8FFezdq6TQOyo8pJlqAH+2sYhNWn42I0y8d0uS1d59oM2nGWgfRdN/BysTtQJrFGIcS5onwpMkckg+++vtM3tyU/0xx7KdA4hm4RZ7PXPe5fAmL8hKlH5Lk+5UDEWihFI/edYZs5dXfNXNYmKvH7RBTI10AWlg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(136003)(346002)(376002)(36756003)(8936002)(26005)(6506007)(6512007)(6486002)(53546011)(478600001)(5660300002)(2906002)(41300700001)(6666004)(83380400001)(66574015)(31696002)(86362001)(66476007)(186003)(38100700002)(8676002)(4326008)(6916009)(66946007)(54906003)(66556008)(316002)(31686004)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUl0T3E4aldQY2NBWlo2SDVWRURSN09jMUg4VjQ1bUhJemk0K1NLQVlocW9y?= =?utf-8?B?TlV0K3RDckVuWkswNGRHb0RYU2RmVWpnKzlIZGZVazBvSGlzNHdEWFFkNFQw?= =?utf-8?B?TFA2azJwNUtsNC9xSmo4QkhKNkVZSWZIMjFRUU1QeUwvUHZhWCtxaW5GOTZZ?= =?utf-8?B?MEdRZk1MbWROdE5sY2ZKSlJrY2FvaFBybjZkNThoZml0MFNJeTV5eW9OU3ln?= =?utf-8?B?SEhPa3VOWGc1VTlDSzRHZWtUWW1kN0pqVUxVa1BLcU1NZmRacUtlK2gzai9F?= =?utf-8?B?MjVPa1V0RFpxc1ZLa1Y4Y2N0WGFIaE0yUitBeVU0RHkya1h3WktJQWxadnlk?= =?utf-8?B?blB3NHVsVmRWMzJuUmxNNUk2bGNSZnpiMFM5TE9Wc3J2TG9ORkNvZ0RlT3px?= =?utf-8?B?elJValRNaW83VnlXVnltKzA1ZFBaQ2xyQTNVUWxDdjNNbk16bkt5ZVFkOFJH?= =?utf-8?B?QXRvNnRydW5uNDQ1QSttaTVRYUlEN0h3N1BCaEU1RWM5YjRTcFNUYzM1SWJl?= =?utf-8?B?S1Ztb3ByTFVPTGk0UldhNWZPOVRlYm1abWZWMVluKzErSmpnUkRUM1ZNRmF2?= =?utf-8?B?ZEJ0YlhzaEd5ZVVDMTRxZFQxWDVCbXllcTgwWGVLOUxiaE85aGQ1TEd2eWdy?= =?utf-8?B?eGVGNllYOGdVRlpuYUMxRFdSVEZCbXJKc2xvaldCZnlzdTBLZEpDN2VuZFNJ?= =?utf-8?B?V3podHowVFhYWXRIdCtvR290Nmp6Q2gwVzB1dWUvYUw1WUU0YzRyblg2bWE4?= =?utf-8?B?UWpUb3FuSUF5TmNLREFSZDBjZkJ1aW5kOUdXMGk1Ry92anU3T08wazNrZ0x3?= =?utf-8?B?Q1hEKzFjTmlNZHlERlpFV3BCREV6aVdLUnpWdWtpOElEeGUxS244ZzRUT1Ri?= =?utf-8?B?QUtqTWlBVkdySW81WFB1NmRJVWhzY1JMMlJuUUtTU25EQUFFeWtMOW0raUNx?= =?utf-8?B?dDd0T0Uvc2pHVGk3czF0Z216ZmlvQzBWTlozWmFBQWdxREFHM1diakpEVWVU?= =?utf-8?B?OEUrTDk0TnNsUXZhQVBxdjA4bUZOeG9EelM2eFFTUzRiU3lKeHFBN1dPcVln?= =?utf-8?B?ckI0MzVCVXV2WVJOVzd3Y3BFcVJlVGZOR2dqZkxNRmVhc0Flbi92RkllZGd5?= =?utf-8?B?ZjFTVDg1WUMxbUQ4MW8vWU1adDdMVVcyME9PMTM0bkM3K3NDMU0xbzJwMG5Z?= =?utf-8?B?b3kxNXM3dFNVSmRlR3I3dnFTWHMwSTFZMVkvUlkzQ01EOGlOTUwyUWNmaTJv?= =?utf-8?B?dUF1NytDM3l1YkVUSVp5S3BWdHc0MGNZWE5Lc2FWNXB3aWhVdnp1dFphVjFF?= =?utf-8?B?bzNoZWNWcjJpTzlyTzZtWG5rcG1tNDZqQ3VpRnY0WFRVbjd0UDliN1h1Q1VH?= =?utf-8?B?VUlxWGFqY0RTOXpsS3dXRWZNWFhwVzJFOFdFaVVWUS8zSGlyc0FGRTUzZmlh?= =?utf-8?B?RW5ML1ArSkg4WnVEQ2ZMeHF1VEdDSkUxSWI4bGxjTWlWRWphQzRXelh5cXcw?= =?utf-8?B?V2NPT0FRU1dWZUFzN0JsMW5ycGt2c0pLRWJ5S21weUxjTWtOdnFvWDRoeEtw?= =?utf-8?B?UXkzQ0ErWDdxb2w3aG9aTUNONzllNWZTdFYwWnZlTzc1OHNGclB0N1dZZEhW?= =?utf-8?B?QTlzeGlneHh0QWhBVng0L2o1WGNVb3FLVEJCbUV1dEM3eEpWSmM5L2IyUmJU?= =?utf-8?B?NE0xNXg3R1hCZk51WnJ3cmNRdzg2VUZROVdBQzlpWXNIRUR0bGxRUVdzRE90?= =?utf-8?B?TThPWWlhUXJwOTBiMGQxTU9iUzlaWHhmMkIyTlRtVWJ4UHFWUkcrUGEvaDNT?= =?utf-8?B?SHlwU3E4bXpsZjgrbGR4cDE3clRUY0ZQZzA3c1NsbitSSHNDNURMd2t2WTJq?= =?utf-8?B?V2hrN0FKV2llbXd0Y213QmtETDh6eWtQRDFYL2JtQjFyN1FKUzRkOTNBUEhF?= =?utf-8?B?N0hXN09qeFY5NEp4V0VPejBOVmdxKzF5TFdiSndaU2tpY2JQTGcrczY3aUJG?= =?utf-8?B?dTN6UnBwZUsyL0tDR3l0dFNodlNOOHZRZ1Jxbzh3N2xsNkZBQnVURXcyWnJr?= =?utf-8?B?Nzh5VEoxejdReVQyVkhDZ01NYlU5NDhDZ3pXcUY4R3BQWVVTdWVjTlo0RCtF?= =?utf-8?Q?49DErijFxsSUg+/sV+LLyyFcq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea831996-3d58-4fb0-29fc-08da6b04046d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:30:22.6369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: adNHWxTxGzxYjK6MT3kWQ439eni8l6Wb0wrB9P8VAhZYHtGLBbJ2CAuTi9s96KvsMlXrs8XxwJ8LTwSQ2Ada+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8551 On 20.07.2022 22:17, Marek Marczykowski-Górecki wrote: > On Thu, Jul 14, 2022 at 01:51:06PM +0200, Jan Beulich wrote: >> On 06.07.2022 17:32, Marek Marczykowski-Górecki wrote: >>> + /* >>> + * Don't place anything else on this page - it will be >>> + * DMA-reachable by the USB controller. >>> + */ >>> + char _pad[0] __aligned(XUE_PAGE_SIZE); >> >> I don't think this is needed, due to sizeof() being required to be >> a multiple of alignof(). > > I'd prefer to be explicit about this, because if some future change > breaks this property (makes alignment smaller than a page size), the > result will be pretty bad. I don't mind you leaving the comment; anyone making adjustments there ought to be checking the effects of what they're doing. >>> @@ -990,16 +999,22 @@ void __init xue_uart_init(void) >>> xue->sbdf = PCI_SBDF(0, bus, slot, func); >>> } >>> >>> - xue->dbc_ctx = &ctx; >>> - xue->dbc_erst = &erst; >>> - xue->dbc_ering.trb = evt_trb; >>> - xue->dbc_oring.trb = out_trb; >>> - xue->dbc_iring.trb = in_trb; >>> - xue->dbc_owork.buf = wrk_buf; >>> - xue->dbc_str = str_buf; >>> + xue->dbc_ctx = &xue_dma_bufs.ctx; >>> + xue->dbc_erst = &xue_dma_bufs.erst; >>> + xue->dbc_ering.trb = xue_dma_bufs.evt_trb; >>> + xue->dbc_oring.trb = xue_dma_bufs.out_trb; >>> + xue->dbc_iring.trb = xue_dma_bufs.in_trb; >>> + xue->dbc_owork.buf = xue_dma_bufs.wrk_buf; >>> + xue->dbc_str = xue_dma_bufs.str_buf; >>> >>> if ( xue_open(xue) ) >>> + { >>> + iommu_add_extra_reserved_device_memory( >>> + PFN_DOWN(virt_to_maddr(&xue_dma_bufs)), >> >> virt_to_pfn()? > > Doesn't exist. Did you mean virt_to_mfn()? Oh, sorry, never mind then. virt_to_mfn() would be good to use if the function took mfn_t, but as long as it doesn't what you have is as good. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:41:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:41:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372640.604477 (Exim 4.92) (envelope-from ) id 1oETci-0007RZ-7l; Thu, 21 Jul 2022 10:41:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372640.604477; Thu, 21 Jul 2022 10:41:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETci-0007RS-50; Thu, 21 Jul 2022 10:41:40 +0000 Received: by outflank-mailman (input) for mailman id 372640; Thu, 21 Jul 2022 10:41:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETcg-0007RM-PC for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:41:38 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20066.outbound.protection.outlook.com [40.107.2.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b29f5d3c-08e1-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 12:41:38 +0200 (CEST) Received: from AS9PR06CA0368.eurprd06.prod.outlook.com (2603:10a6:20b:460::32) by AM6PR08MB5220.eurprd08.prod.outlook.com (2603:10a6:20b:c3::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Thu, 21 Jul 2022 10:41:32 +0000 Received: from VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:460:cafe::21) by AS9PR06CA0368.outlook.office365.com (2603:10a6:20b:460::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Thu, 21 Jul 2022 10:41:32 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT013.mail.protection.outlook.com (10.152.19.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 10:41:31 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 21 Jul 2022 10:41:31 +0000 Received: from 70dadfa6af9d.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 281CC5B1-6F6E-45BA-B922-1AABB462A9D9.1; Thu, 21 Jul 2022 10:41:25 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 70dadfa6af9d.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 10:41:24 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB7675.eurprd08.prod.outlook.com (2603:10a6:10:37e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:41:22 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 10:41:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b29f5d3c-08e1-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=DJSuaQqqje3e09fA5yJoKhOPfLcsSpJR1Bd9BmFh81X5Gb4bJIfh/E6UF/xpCdQMlSaZxm7/6Yk/5fS6GKBwRtaD2kiQjp7h0kp+yqj7MNh2pjgBWtKityft8coiCqSS0ZQWds7zqYqK7Px4XeNWmvQhocsoFniFfoZ2B2PtkRgNzLdGMdB1EMn3Uo1H43VUARBzU18VRE3e9CcQk3Kq8zH0B8YTx/QK/do6l7x4uVL0dMNVqZljSYG8U0mZ8Aka/D6CeP6YbMDgrpPd/z+IqYJ+YNmWdopNQuXP2ExJKwE3JbSZQ3IhNS4UF4qhmx8Hcum8elvqGNU6Of2pOciVbA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1TGAxKC86E82i+Y2tz5z0X+LL2+RboBagycbhTk1Eg=; b=S1dJU8+1/qw4pjqSkDvn8D9QZULWjmeM9WXq6YQOz41ljXCXmH/+8mB8h2KZNl32DJ+uumxyJBvW/TIiZA9tscw7Rq99sgjxpiO+tyidbmMWY4vberMZagcs4P5I1pRrDeqwGRmhmhf3z6rhDMeb8gIUcNzDskbnLHSmEvoRg29Q+hxRudgdv7QWEUb+xOdJtSSZt68creUigpPf0aiF0XGTtBredKKN/4SLWFWqtGeUXP3T1rZ0TYfrk0JrEw1+L+47qMcJL/HfgNhzcdTSBCGZ8G1gNljPgq/5mnTE15HCyoGj9LAyf/EysxJaxEuwdfvLocfMcbY9RAC1+GcWHA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1TGAxKC86E82i+Y2tz5z0X+LL2+RboBagycbhTk1Eg=; b=JUYiayTb9Hi0a5phYi/gHwdW85XPv8Jw6zFlVlwcYMz4qwnOz9KYX2ulxl6jO4OiOvSxMUcn1vRmQOLw4uejKLNwxPk8lQbuAPVBOMTHJenTEZtWfBaEvzfcXx+JB0536NSK35H8EwY7lVjdKjFdOzys35eFE4pGnDPFfQ7eLa4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f5f387c06155b1f5 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mm8XB/LkEra5dFNPqQPd689U29x2hBX2KhVk8vr6UmQ96lkkYGl8DYKO3qkTifCTsN+JbnmTkY5CTZXjOVg9YaaGd5t22iKAUnraTdE08eNHuQwQ/tCNHvgNBhZlwZZmOto7NILx4U1owifpm+yiM22rJTmksBWFgdE9WVtL/kDP55tswGqCs6zs61xJyZqnrbTJx/uDo88t0EkyhfYoa8sF4YSC+Vbhnyg684fcMR/A4XXwfFrjsJvHbA6Ddl5VyAVTxKucUmUYumwZi85Hj9ulydkKxBVshR+RNM4COKetpPZq5RjVrKvGroMSX6K2mpCGJb4mr6sZgiE53Vm+Wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L1TGAxKC86E82i+Y2tz5z0X+LL2+RboBagycbhTk1Eg=; b=c4Okt+0xQHfkDZx52OFuyMG52Qz06yhC4yNOgCf40cn1JbXi/iXHzISdZmxJl9fursyFQJSP6ncnGB3UqYD5V585xnSOOdzHI+IAUM2G/K8D9Y26TDRVar5AMsgxJWZW0QsRUnL6j+AICKvovOH2OTRc5Bku+mUXJnh+2195WXcew+i30PR6+pgWM03Ykb5kDPR0IhaNIPIckQevIlMLfjKzR8/QkJRshyB8wICeudy7j+I2I2tnjQz9U5cQmI+tvLBfen6fM20BXsznsPuvo/QrauNRtpIAY376qvbIA6lmzdFFLO404X9RzQiKBBFyejMRWC7GtubcxUVQTGyItg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L1TGAxKC86E82i+Y2tz5z0X+LL2+RboBagycbhTk1Eg=; b=JUYiayTb9Hi0a5phYi/gHwdW85XPv8Jw6zFlVlwcYMz4qwnOz9KYX2ulxl6jO4OiOvSxMUcn1vRmQOLw4uejKLNwxPk8lQbuAPVBOMTHJenTEZtWfBaEvzfcXx+JB0536NSK35H8EwY7lVjdKjFdOzys35eFE4pGnDPFfQ7eLa4= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: Re: [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file Thread-Topic: [PATCH v2 4/5] xen/arm: mm: Move domain_{,un}map_* helpers in a separate file Thread-Index: AQHYnGjgbGc3p9EL0UO5jUcNVt1sgq2IpAQA Date: Thu, 21 Jul 2022 10:41:22 +0000 Message-ID: References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-5-julien@xen.org> In-Reply-To: <20220720184459.51582-5-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d0a241d2-192c-41a2-1ec1-08da6b059361 x-ms-traffictypediagnostic: DB9PR08MB7675:EE_|VE1EUR03FT013:EE_|AM6PR08MB5220:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0wJgKS6k7gH6fYA4OrDSkb/qx3cv5m6oDYLoqvpAt94W6+w61+RL+d+QqLo43nS9vlak4c3w/bExjI2foljbL0UploXHL67PNyOr+7uyS1KIjD/JGdfC37jiY+ix0+YzPUJphuwtpag91VpblSYopil1NVHnyTXDAXNwPNB4exHQr2s8lQ1Z41rpJWkidUDVY2LRuXPxVdZZyAtDCYClXt2mvXw+Ow4S8FiHRvvqOWK1q5HEVsAHfLQJs2NlV5Ht8UCAc7ygBOi924/8e3T74bu4UB3ipQFP8jzu7fho1SsZCtI8+gUqYfh9EusT0/jK3rShsosjL047kG8dDun8n5ZJ9hChY+/Fxsz7rnGrBgYprdZIDp4SGshh7N3qk0K3pkTyDzfIdfQ7G0CS7n3OiV12YiDNbH05AhqPPH3bI4ULgXYeGwTiGhJ1fjq2nVF3dG63Jxs2rtVjoLmwkQOmFJWsMIqEoC+/CambD81GMZV9MbnOMCcd8L7ernL4gNKa2xgg48yAFxnDOekpoWpXKZCClqkvZ2+iAuBULM8h5EHCO00DCGkX0Zfkl0rEC2k6jYj7o7DyhiGIGpbKyU/xroNDtViqhR7vbPhnyVYgohJ3cc+uPAn8HzSjlY2fUYzMsJiApsxS8CRYADmjy4i77cpDlH6DaQxAkbbn6nE/3BPsbwuh/DCPNqykBBQIVV7g8v5DoVJmmzE29vOmlV6/t3sAcgqKZ/hWIB3ZJanKzu0b2ctUELbl2Guj1O80FQeGx5tmOdPh3RD07V74X64j7fJ0o2Bd0dWhSyFjA2V+e2Tdsyo9PDxDR5IVIgKZIVkSysvfspD464Ays4OHdYZ24w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(39860400002)(396003)(366004)(376002)(53546011)(26005)(41300700001)(186003)(6506007)(2906002)(2616005)(6512007)(122000001)(83380400001)(86362001)(33656002)(38070700005)(66446008)(38100700002)(5660300002)(478600001)(316002)(71200400001)(54906003)(36756003)(64756008)(8936002)(8676002)(66556008)(66476007)(66946007)(6486002)(6916009)(4326008)(30864003)(76116006)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7675 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 66903634-7d9f-4a9d-5b00-08da6b058dde X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iKQjMHH8M6nwafvcbUZxkhPGSCvymwlLuOcorUdD3j3lbBhAuH94Z0YWWDNqRE+ckn0Ztmhal4SOCSJvkOVmI5lmRTwv4LwmWh6VltJMz7XD2ZU1+eq3qoa7SpYPCOnAmAeBeO/bIZ56NyGnOrAcm+GacxxrKMrOzTNj54yKjfhXwbiKwE5SqygM8NfOCHLlvp08jLH0Ml+k13oiXQCr1/9TVqlc6Y+BRYo5wl8dFIFuW7C6GUQlCW45qf6oxh1J4Lw72n3M7A4eeDEAgS4G5aHtOAvr7hx/FGLOPx44PqFY0VKIZKaylnpoQzpUZDQ7y/okfkwmHVEy7hrszsbr9TicvkG/WSokW3SNMjv1wxnlZqmFXw4rBPKjDcpus0rpzyrvYGjnFZSqvGB/KfaVzHBgXCUUwzA85JZNQdzx+T3pxqNSOM4l3QlH0vmPGHiZ7eihDCHxZXUtrD671XL5vvoMoUICUZWitvI6ZOMmer7rttrSjRGz7nRrlLsi9Z+gC6MxrymVDyOoquOfM80/jF5E4ky13s5ZB8XzfYn0E7svPS7qPBVSgQjNWBFsWhyFK7pX9fSHZNKly1vg1fZKB2ygvQ9KGyU0VJotE4AZ47kGbUBKXIJxK+K+/plTJtObj2hk3/ha4egvLT+2yr8kvyyVmb3Mg4wIpd+ZMKnNn+OT6pHJv3/vsraHkYxxudMZGDKnO+3vkOIsOBK5B/z3uiD97+B1ZWe89FJXjCTWd+iva5Rb2jTnKx2d3pYY+9rPzMv0/5P40ad8BjGnCyX/UH48W4uiSXo7CHl+QyoKiM4= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(396003)(376002)(36840700001)(46966006)(40470700004)(26005)(41300700001)(6512007)(54906003)(36860700001)(336012)(6506007)(82310400005)(5660300002)(8936002)(186003)(30864003)(6862004)(40460700003)(2906002)(356005)(478600001)(40480700001)(83380400001)(53546011)(4326008)(316002)(47076005)(2616005)(36756003)(70586007)(81166007)(70206006)(8676002)(82740400003)(86362001)(6486002)(33656002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:41:31.6564 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d0a241d2-192c-41a2-1ec1-08da6b059361 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT013.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5220 Hi Julien, > On 20 Jul 2022, at 19:44, Julien Grall wrote: >=20 > From: Julien Grall >=20 > The file xen/arch/mm.c has been growing quite a lot. It now contains > various independent part of the MM subsytem. >=20 > One of them is the helpers to map/unmap a page which is only used > by arm32 and protected by CONFIG_ARCH_MAP_DOMAIN_PAGE. Move them in a > new file xen/arch/arm/domain_page.c. >=20 > Signed-off-by: Julien Grall With the kconfig part removed: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > ---- > Changes in v2: > - Move CONFIG_* to Kconfig is now in a separate patch > --- > xen/arch/arm/Makefile | 1 + > xen/arch/arm/domain_page.c | 193 +++++++++++++++++++++++++++ > xen/arch/arm/include/asm/arm32/mm.h | 6 + > xen/arch/arm/include/asm/lpae.h | 17 +++ > xen/arch/arm/mm.c | 198 +--------------------------- > xen/common/Kconfig | 3 + > 6 files changed, 222 insertions(+), 196 deletions(-) > create mode 100644 xen/arch/arm/domain_page.c >=20 > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > index bb7a6151c13c..4d076b278b10 100644 > --- a/xen/arch/arm/Makefile > +++ b/xen/arch/arm/Makefile > @@ -17,6 +17,7 @@ obj-y +=3D device.o > obj-$(CONFIG_IOREQ_SERVER) +=3D dm.o > obj-y +=3D domain.o > obj-y +=3D domain_build.init.o > +obj-$(CONFIG_ARCH_MAP_DOMAIN_PAGE) +=3D domain_page.o > obj-y +=3D domctl.o > obj-$(CONFIG_EARLY_PRINTK) +=3D early_printk.o > obj-y +=3D efi/ > diff --git a/xen/arch/arm/domain_page.c b/xen/arch/arm/domain_page.c > new file mode 100644 > index 000000000000..63e97730cf57 > --- /dev/null > +++ b/xen/arch/arm/domain_page.c > @@ -0,0 +1,193 @@ > +#include > +#include > +#include > + > +/* Override macros from asm/page.h to make them work with mfn_t */ > +#undef virt_to_mfn > +#define virt_to_mfn(va) _mfn(__virt_to_mfn(va)) > + > +/* cpu0's domheap page tables */ > +static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES); > + > +/* > + * xen_dommap =3D=3D pages used by map_domain_page, these pages contain > + * the second level pagetables which map the domheap region > + * starting at DOMHEAP_VIRT_START in 2MB chunks. > + */ > +static DEFINE_PER_CPU(lpae_t *, xen_dommap); > + > +/* > + * Prepare the area that will be used to map domheap pages. They are > + * mapped in 2MB chunks, so we need to allocate the page-tables up to > + * the 2nd level. > + * > + * The caller should make sure the root page-table for @cpu has been > + * allocated. > + */ > +bool init_domheap_mappings(unsigned int cpu) > +{ > + unsigned int order =3D get_order_from_pages(DOMHEAP_SECOND_PAGES); > + lpae_t *root =3D per_cpu(xen_pgtable, cpu); > + unsigned int i, first_idx; > + lpae_t *domheap; > + mfn_t mfn; > + > + ASSERT(root); > + ASSERT(!per_cpu(xen_dommap, cpu)); > + > + /* > + * The domheap for cpu0 is before the heap is initialized. So we > + * need to use pre-allocated pages. > + */ > + if ( !cpu ) > + domheap =3D cpu0_dommap; > + else > + domheap =3D alloc_xenheap_pages(order, 0); > + > + if ( !domheap ) > + return false; > + > + /* Ensure the domheap has no stray mappings */ > + memset(domheap, 0, DOMHEAP_SECOND_PAGES * PAGE_SIZE); > + > + /* > + * Update the first level mapping to reference the local CPUs > + * domheap mapping pages. > + */ > + mfn =3D virt_to_mfn(domheap); > + first_idx =3D first_table_offset(DOMHEAP_VIRT_START); > + for ( i =3D 0; i < DOMHEAP_SECOND_PAGES; i++ ) > + { > + lpae_t pte =3D mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL); > + pte.pt.table =3D 1; > + write_pte(&root[first_idx + i], pte); > + } > + > + per_cpu(xen_dommap, cpu) =3D domheap; > + > + return true; > +} > + > +void *map_domain_page_global(mfn_t mfn) > +{ > + return vmap(&mfn, 1); > +} > + > +void unmap_domain_page_global(const void *va) > +{ > + vunmap(va); > +} > + > +/* Map a page of domheap memory */ > +void *map_domain_page(mfn_t mfn) > +{ > + unsigned long flags; > + lpae_t *map =3D this_cpu(xen_dommap); > + unsigned long slot_mfn =3D mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK; > + vaddr_t va; > + lpae_t pte; > + int i, slot; > + > + local_irq_save(flags); > + > + /* The map is laid out as an open-addressed hash table where each > + * entry is a 2MB superpage pte. We use the available bits of each > + * PTE as a reference count; when the refcount is zero the slot can > + * be reused. */ > + for ( slot =3D (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i = =3D 0; > + i < DOMHEAP_ENTRIES; > + slot =3D (slot + 1) % DOMHEAP_ENTRIES, i++ ) > + { > + if ( map[slot].pt.avail < 0xf && > + map[slot].pt.base =3D=3D slot_mfn && > + map[slot].pt.valid ) > + { > + /* This slot already points to the right place; reuse it */ > + map[slot].pt.avail++; > + break; > + } > + else if ( map[slot].pt.avail =3D=3D 0 ) > + { > + /* Commandeer this 2MB slot */ > + pte =3D mfn_to_xen_entry(_mfn(slot_mfn), MT_NORMAL); > + pte.pt.avail =3D 1; > + write_pte(map + slot, pte); > + break; > + } > + > + } > + /* If the map fills up, the callers have misbehaved. */ > + BUG_ON(i =3D=3D DOMHEAP_ENTRIES); > + > +#ifndef NDEBUG > + /* Searching the hash could get slow if the map starts filling up. > + * Cross that bridge when we come to it */ > + { > + static int max_tries =3D 32; > + if ( i >=3D max_tries ) > + { > + dprintk(XENLOG_WARNING, "Domheap map is filling: %i tries\n"= , i); > + max_tries *=3D 2; > + } > + } > +#endif > + > + local_irq_restore(flags); > + > + va =3D (DOMHEAP_VIRT_START > + + (slot << SECOND_SHIFT) > + + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT)); > + > + /* > + * We may not have flushed this specific subpage at map time, > + * since we only flush the 4k page not the superpage > + */ > + flush_xen_tlb_range_va_local(va, PAGE_SIZE); > + > + return (void *)va; > +} > + > +/* Release a mapping taken with map_domain_page() */ > +void unmap_domain_page(const void *va) > +{ > + unsigned long flags; > + lpae_t *map =3D this_cpu(xen_dommap); > + int slot =3D ((unsigned long) va - DOMHEAP_VIRT_START) >> SECOND_SHI= FT; > + > + if ( !va ) > + return; > + > + local_irq_save(flags); > + > + ASSERT(slot >=3D 0 && slot < DOMHEAP_ENTRIES); > + ASSERT(map[slot].pt.avail !=3D 0); > + > + map[slot].pt.avail--; > + > + local_irq_restore(flags); > +} > + > +mfn_t domain_page_map_to_mfn(const void *ptr) > +{ > + unsigned long va =3D (unsigned long)ptr; > + lpae_t *map =3D this_cpu(xen_dommap); > + int slot =3D (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; > + unsigned long offset =3D (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; > + > + if ( (va >=3D VMAP_VIRT_START) && ((va - VMAP_VIRT_START) < VMAP_VIR= T_SIZE) ) > + return virt_to_mfn(va); > + > + ASSERT(slot >=3D 0 && slot < DOMHEAP_ENTRIES); > + ASSERT(map[slot].pt.avail !=3D 0); > + > + return mfn_add(lpae_get_mfn(map[slot]), offset); > +} > + > +/* > + * Local variables: > + * mode: C > + * c-file-style: "BSD" > + * c-basic-offset: 4 > + * indent-tabs-mode: nil > + * End: > + */ > diff --git a/xen/arch/arm/include/asm/arm32/mm.h b/xen/arch/arm/include/a= sm/arm32/mm.h > index 575373aeb985..8bfc906e7178 100644 > --- a/xen/arch/arm/include/asm/arm32/mm.h > +++ b/xen/arch/arm/include/asm/arm32/mm.h > @@ -1,6 +1,12 @@ > #ifndef __ARM_ARM32_MM_H__ > #define __ARM_ARM32_MM_H__ >=20 > +#include > + > +#include > + > +DECLARE_PER_CPU(lpae_t *, xen_pgtable); > + > /* > * Only a limited amount of RAM, called xenheap, is always mapped on ARM3= 2. > * For convenience always return false. > diff --git a/xen/arch/arm/include/asm/lpae.h b/xen/arch/arm/include/asm/l= pae.h > index fc19cbd84772..3fdd5d0de28e 100644 > --- a/xen/arch/arm/include/asm/lpae.h > +++ b/xen/arch/arm/include/asm/lpae.h > @@ -261,6 +261,23 @@ lpae_t mfn_to_xen_entry(mfn_t mfn, unsigned int attr= ); > #define third_table_offset(va) TABLE_OFFSET(third_linear_offset(va)) > #define zeroeth_table_offset(va) TABLE_OFFSET(zeroeth_linear_offset(va)) >=20 > +/* > + * Macros to define page-tables: > + * - DEFINE_BOOT_PAGE_TABLE is used to define page-table that are used > + * in assembly code before BSS is zeroed. > + * - DEFINE_PAGE_TABLE{,S} are used to define one or multiple > + * page-tables to be used after BSS is zeroed (typically they are only = used > + * in C). > + */ > +#define DEFINE_BOOT_PAGE_TABLE(name) = \ > +lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") = \ > + name[XEN_PT_LPAE_ENTRIES] > + > +#define DEFINE_PAGE_TABLES(name, nr) \ > +lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)] > + > +#define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1) > + > #endif /* __ARM_LPAE_H__ */ >=20 > /* > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 7a722d6c86c6..ad26ad740308 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -57,23 +57,6 @@ mm_printk(const char *fmt, ...) {} > } while (0) > #endif >=20 > -/* > - * Macros to define page-tables: > - * - DEFINE_BOOT_PAGE_TABLE is used to define page-table that are used > - * in assembly code before BSS is zeroed. > - * - DEFINE_PAGE_TABLE{,S} are used to define one or multiple > - * page-tables to be used after BSS is zeroed (typically they are only = used > - * in C). > - */ > -#define DEFINE_BOOT_PAGE_TABLE(name) = \ > -lpae_t __aligned(PAGE_SIZE) __section(".data.page_aligned") = \ > - name[XEN_PT_LPAE_ENTRIES] > - > -#define DEFINE_PAGE_TABLES(name, nr) \ > -lpae_t __aligned(PAGE_SIZE) name[XEN_PT_LPAE_ENTRIES * (nr)] > - > -#define DEFINE_PAGE_TABLE(name) DEFINE_PAGE_TABLES(name, 1) > - > /* Static start-of-day pagetables that we use before the allocators > * are up. These are used by all CPUs during bringup before switching > * to the CPUs own pagetables. > @@ -110,7 +93,7 @@ DEFINE_BOOT_PAGE_TABLE(boot_third); > /* Main runtime page tables */ >=20 > /* > - * For arm32 xen_pgtable and xen_dommap are per-PCPU and are allocated b= efore > + * For arm32 xen_pgtable are per-PCPU and are allocated before > * bringing up each CPU. For arm64 xen_pgtable is common to all PCPUs. > * > * xen_second, xen_fixmap and xen_xenmap are always shared between all > @@ -126,18 +109,10 @@ static DEFINE_PAGE_TABLE(xen_first); > #define HYP_PT_ROOT_LEVEL 1 > /* Per-CPU pagetable pages */ > /* xen_pgtable =3D=3D root of the trie (zeroeth level on 64-bit, first on= 32-bit) */ > -static DEFINE_PER_CPU(lpae_t *, xen_pgtable); > +DEFINE_PER_CPU(lpae_t *, xen_pgtable); > #define THIS_CPU_PGTABLE this_cpu(xen_pgtable) > -/* > - * xen_dommap =3D=3D pages used by map_domain_page, these pages contain > - * the second level pagetables which map the domheap region > - * starting at DOMHEAP_VIRT_START in 2MB chunks. > - */ > -static DEFINE_PER_CPU(lpae_t *, xen_dommap); > /* Root of the trie for cpu0, other CPU's PTs are dynamically allocated *= / > static DEFINE_PAGE_TABLE(cpu0_pgtable); > -/* cpu0's domheap page tables */ > -static DEFINE_PAGE_TABLES(cpu0_dommap, DOMHEAP_SECOND_PAGES); > #endif >=20 > /* Common pagetable leaves */ > @@ -371,175 +346,6 @@ void clear_fixmap(unsigned int map) > BUG_ON(res !=3D 0); > } >=20 > -#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE > -/* > - * Prepare the area that will be used to map domheap pages. They are > - * mapped in 2MB chunks, so we need to allocate the page-tables up to > - * the 2nd level. > - * > - * The caller should make sure the root page-table for @cpu has been > - * allocated. > - */ > -bool init_domheap_mappings(unsigned int cpu) > -{ > - unsigned int order =3D get_order_from_pages(DOMHEAP_SECOND_PAGES); > - lpae_t *root =3D per_cpu(xen_pgtable, cpu); > - unsigned int i, first_idx; > - lpae_t *domheap; > - mfn_t mfn; > - > - ASSERT(root); > - ASSERT(!per_cpu(xen_dommap, cpu)); > - > - /* > - * The domheap for cpu0 is before the heap is initialized. So we > - * need to use pre-allocated pages. > - */ > - if ( !cpu ) > - domheap =3D cpu0_dommap; > - else > - domheap =3D alloc_xenheap_pages(order, 0); > - > - if ( !domheap ) > - return false; > - > - /* Ensure the domheap has no stray mappings */ > - memset(domheap, 0, DOMHEAP_SECOND_PAGES * PAGE_SIZE); > - > - /* > - * Update the first level mapping to reference the local CPUs > - * domheap mapping pages. > - */ > - mfn =3D virt_to_mfn(domheap); > - first_idx =3D first_table_offset(DOMHEAP_VIRT_START); > - for ( i =3D 0; i < DOMHEAP_SECOND_PAGES; i++ ) > - { > - lpae_t pte =3D mfn_to_xen_entry(mfn_add(mfn, i), MT_NORMAL); > - pte.pt.table =3D 1; > - write_pte(&root[first_idx + i], pte); > - } > - > - per_cpu(xen_dommap, cpu) =3D domheap; > - > - return true; > -} > - > -void *map_domain_page_global(mfn_t mfn) > -{ > - return vmap(&mfn, 1); > -} > - > -void unmap_domain_page_global(const void *va) > -{ > - vunmap(va); > -} > - > -/* Map a page of domheap memory */ > -void *map_domain_page(mfn_t mfn) > -{ > - unsigned long flags; > - lpae_t *map =3D this_cpu(xen_dommap); > - unsigned long slot_mfn =3D mfn_x(mfn) & ~XEN_PT_LPAE_ENTRY_MASK; > - vaddr_t va; > - lpae_t pte; > - int i, slot; > - > - local_irq_save(flags); > - > - /* The map is laid out as an open-addressed hash table where each > - * entry is a 2MB superpage pte. We use the available bits of each > - * PTE as a reference count; when the refcount is zero the slot can > - * be reused. */ > - for ( slot =3D (slot_mfn >> XEN_PT_LPAE_SHIFT) % DOMHEAP_ENTRIES, i = =3D 0; > - i < DOMHEAP_ENTRIES; > - slot =3D (slot + 1) % DOMHEAP_ENTRIES, i++ ) > - { > - if ( map[slot].pt.avail < 0xf && > - map[slot].pt.base =3D=3D slot_mfn && > - map[slot].pt.valid ) > - { > - /* This slot already points to the right place; reuse it */ > - map[slot].pt.avail++; > - break; > - } > - else if ( map[slot].pt.avail =3D=3D 0 ) > - { > - /* Commandeer this 2MB slot */ > - pte =3D mfn_to_xen_entry(_mfn(slot_mfn), MT_NORMAL); > - pte.pt.avail =3D 1; > - write_pte(map + slot, pte); > - break; > - } > - > - } > - /* If the map fills up, the callers have misbehaved. */ > - BUG_ON(i =3D=3D DOMHEAP_ENTRIES); > - > -#ifndef NDEBUG > - /* Searching the hash could get slow if the map starts filling up. > - * Cross that bridge when we come to it */ > - { > - static int max_tries =3D 32; > - if ( i >=3D max_tries ) > - { > - dprintk(XENLOG_WARNING, "Domheap map is filling: %i tries\n"= , i); > - max_tries *=3D 2; > - } > - } > -#endif > - > - local_irq_restore(flags); > - > - va =3D (DOMHEAP_VIRT_START > - + (slot << SECOND_SHIFT) > - + ((mfn_x(mfn) & XEN_PT_LPAE_ENTRY_MASK) << THIRD_SHIFT)); > - > - /* > - * We may not have flushed this specific subpage at map time, > - * since we only flush the 4k page not the superpage > - */ > - flush_xen_tlb_range_va_local(va, PAGE_SIZE); > - > - return (void *)va; > -} > - > -/* Release a mapping taken with map_domain_page() */ > -void unmap_domain_page(const void *va) > -{ > - unsigned long flags; > - lpae_t *map =3D this_cpu(xen_dommap); > - int slot =3D ((unsigned long) va - DOMHEAP_VIRT_START) >> SECOND_SHI= FT; > - > - if ( !va ) > - return; > - > - local_irq_save(flags); > - > - ASSERT(slot >=3D 0 && slot < DOMHEAP_ENTRIES); > - ASSERT(map[slot].pt.avail !=3D 0); > - > - map[slot].pt.avail--; > - > - local_irq_restore(flags); > -} > - > -mfn_t domain_page_map_to_mfn(const void *ptr) > -{ > - unsigned long va =3D (unsigned long)ptr; > - lpae_t *map =3D this_cpu(xen_dommap); > - int slot =3D (va - DOMHEAP_VIRT_START) >> SECOND_SHIFT; > - unsigned long offset =3D (va>>THIRD_SHIFT) & XEN_PT_LPAE_ENTRY_MASK; > - > - if ( (va >=3D VMAP_VIRT_START) && ((va - VMAP_VIRT_START) < VMAP_VIR= T_SIZE) ) > - return virt_to_mfn(va); > - > - ASSERT(slot >=3D 0 && slot < DOMHEAP_ENTRIES); > - ASSERT(map[slot].pt.avail !=3D 0); > - > - return mfn_add(lpae_get_mfn(map[slot]), offset); > -} > -#endif > - > void flush_page_to_ram(unsigned long mfn, bool sync_icache) > { > void *v =3D map_domain_page(_mfn(mfn)); > diff --git a/xen/common/Kconfig b/xen/common/Kconfig > index f1ea3199c8eb..f0aee2cfd9f8 100644 > --- a/xen/common/Kconfig > +++ b/xen/common/Kconfig > @@ -11,6 +11,9 @@ config COMPAT > config CORE_PARKING > bool >=20 > +config DOMAIN_PAGE > + bool > + > config GRANT_TABLE > bool "Grant table support" if EXPERT > default y > --=20 > 2.32.0 >=20 >=20 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:42:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:42:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372644.604489 (Exim 4.92) (envelope-from ) id 1oETdb-00080n-NM; Thu, 21 Jul 2022 10:42:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372644.604489; Thu, 21 Jul 2022 10:42:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETdb-00080e-JM; Thu, 21 Jul 2022 10:42:35 +0000 Received: by outflank-mailman (input) for mailman id 372644; Thu, 21 Jul 2022 10:42:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETda-00080Q-EG; Thu, 21 Jul 2022 10:42:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETda-0007vu-CB; Thu, 21 Jul 2022 10:42:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETda-0007XJ-1j; Thu, 21 Jul 2022 10:42:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oETda-0000qK-0g; Thu, 21 Jul 2022 10:42:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=5lcaE83GUshn0Lkh+WmC7BzxDjWE2nrgsMsNCsISVGg=; b=jJH4yIFKfXRe6/XlLVDWC1V3Ml XQtrNCGyvZY6cuuAcvgQy6H0OIFxJrOGxY4lR5HrDhISioLcelEJicnIsChQYZC7EB/t3rELWyFHo 9N3JMnNnYKXtRQ3D2+H8sl0qPXDk0UVL1RqieHpcJqUwfDgHfdOc6VWZSGT5P/+4wsTY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171717: all pass - PUSHED X-Osstest-Versions-This: ovmf=7ef91af84c04b1e5a17631bd1811c9bc1945dfdc X-Osstest-Versions-That: ovmf=3b8cee1781c4149c7a762b8a1c8115b635cf4cad From: osstest service owner Date: Thu, 21 Jul 2022 10:42:34 +0000 flight 171717 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171717/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7ef91af84c04b1e5a17631bd1811c9bc1945dfdc baseline version: ovmf 3b8cee1781c4149c7a762b8a1c8115b635cf4cad Last test of basis 171710 2022-07-20 19:10:52 Z 0 days Testing same since 171717 2022-07-21 06:42:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Miki Shindo Shindo, Miki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3b8cee1781..7ef91af84c 7ef91af84c04b1e5a17631bd1811c9bc1945dfdc -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 21 10:47:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 10:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372657.604503 (Exim 4.92) (envelope-from ) id 1oETiY-0000b6-CT; Thu, 21 Jul 2022 10:47:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372657.604503; Thu, 21 Jul 2022 10:47:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETiY-0000az-9X; Thu, 21 Jul 2022 10:47:42 +0000 Received: by outflank-mailman (input) for mailman id 372657; Thu, 21 Jul 2022 10:47:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oETiW-0000at-N2 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 10:47:41 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140057.outbound.protection.outlook.com [40.107.14.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 89eb8c9a-08e2-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 12:47:39 +0200 (CEST) Received: from AM6P195CA0092.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:86::33) by VI1PR0802MB2141.eurprd08.prod.outlook.com (2603:10a6:800:99::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:47:35 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:86:cafe::21) by AM6P195CA0092.outlook.office365.com (2603:10a6:209:86::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Thu, 21 Jul 2022 10:47:35 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 21 Jul 2022 10:47:35 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Thu, 21 Jul 2022 10:47:35 +0000 Received: from 7f0ad47bd94d.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C1E2481A-B09A-4CD8-A179-AB6A415FA4F5.1; Thu, 21 Jul 2022 10:47:23 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7f0ad47bd94d.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 10:47:23 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by VI1PR08MB2800.eurprd08.prod.outlook.com (2603:10a6:802:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 10:47:12 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 10:47:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89eb8c9a-08e2-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BqNzWhPfrp4npaWEqC1iAmE7/TqonUrAeaRP7nIh12MkifGqJc+Kgdq85GdEnxTZn1xZBPMpCxgGtOW+aBpZhCv7AaJORZPBRcpUjl41YUFonXmAIGolbObSLUaU7z2QdWzlU+PLoq9bg7XR5ebfvTA/QRQCsON1BdoYmkywXUA7VOqdT5ab4nWFChjapTJCSquMkHAxTFi4vVihz3yeEUonrv3S4rpMulGzrJ7OyxlJXgC/j67Tq9Y2vZJA/4v6/MRqLPwBjPxf4A5y+M+RvKy2veuGOWxuiI4cRwWZoqg7fMJgeu6AibmVLVQMFDB6W66Vm0o5RVfffG+bXFr37w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NSH43A6qt4zFa+wW0FGzZ4cwVivxVXU9pacBfuLujtU=; b=MeI0paRXarau9rLFChco+HybwHp2DGAJWpB46w+br9WbooyN4iRoDPhc41ma1omwvVYz7xSOcPAaMB42z2UKkczrajhXupMN/XKnjbZaBquLzxYKUMKDlewecme90fH0oQz1SN4+J8nYXEYMIF+f59TncbLBaXqn4/PWA6p4bn5Sqmvkq1FLgTr9Q3yed4P53Q13PByxSyazvjf3yDHLEtv7bhgFb+I4KYpkQSqdkIS5u4+3hrvfEJs7C3GilZ7baLPcwa5UBwG9uRZfiyWsiZYBbs9i3lgM9x/N+Bip8GrwN/jgjftoGyyU0A/GJAzV5xKh7P3pGxjGkFP9z6VJCg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NSH43A6qt4zFa+wW0FGzZ4cwVivxVXU9pacBfuLujtU=; b=VCPmm04NoftJsvRvLRDLNruzlC6j5WbPjxGNOt9mbNpfgJ862XHhH5HTiVEYQYqi2lCwJqXy3d3slxLpFh6/OwkVfkqJt00IEUZMEY9XMmpfEg+2aWKPKFkFT/5Gu2vLhvru89jpy+AkwuX9AhmKg2VZRqNV6yf3D4/H4sSLILc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f4583c43156cefe7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkN2s00uTGuFPEgETAhu4TOJNZyLyT6+1pP74aSTfXmJR4AHDL+s3PtgaNPUPxe/jLTwazjRf86Ym1Gj6yiD2M0F79IrnFC+1CyJa+iNTYxC9eQl7+/lfetrhIihD7sF2VjtvV6Vq3XpuQzG1uS29J7H3k+JF+gRRfrJaJiDuYq+Y3JllxBAFqNj4asIc3Pe5Y29sE/bwLTeONFsj31JWibCb3CPK+/To/0Huipdlq91PYQqCoyAzJaG3Ds14TmBlJy1mXZYaBMOur4lxU9VK18LkzYhPf0j3wZDwtuMOaYu4bx2cPQPwWOuLJ9LtBHSMq/nKqiGUai8cP+W3oKP0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NSH43A6qt4zFa+wW0FGzZ4cwVivxVXU9pacBfuLujtU=; b=gMspU/jePg85tjeG/E48dvhJwjpCN8BRcJyUNTyFbXqYOzrf7KjXsPqlGV5HLOGWDtmSBmpgBgl+H68cGJZdsV2I9cFD1VUN3DKkqnBLs1WhQoZCVNI6ydSo9IiKzDgtFBkWD9YEXFabYx2/daU5ThGaKgNWXOZP57aaKdfq5pun/Nhw4JYjTkpclPoR4a5rpmmf7tkng+5Hc2NbjKRBbxEo+flad9P0lGjCkOjQYVJwPS2kJ6CqQW9zv9SJiAFGoCd5xqGyH+Liz942GFV5x9crkskdeRs1PVw2cfbUD/yyeXHkvbtnSsqaGNr/Abe1PhdnSoqosta8TiBKEWD3NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NSH43A6qt4zFa+wW0FGzZ4cwVivxVXU9pacBfuLujtU=; b=VCPmm04NoftJsvRvLRDLNruzlC6j5WbPjxGNOt9mbNpfgJ862XHhH5HTiVEYQYqi2lCwJqXy3d3slxLpFh6/OwkVfkqJt00IEUZMEY9XMmpfEg+2aWKPKFkFT/5Gu2vLhvru89jpy+AkwuX9AhmKg2VZRqNV6yf3D4/H4sSLILc= From: Bertrand Marquis To: Julien Grall CC: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Michal Orzel Subject: Re: [PATCH v2 5/5] xen/arm: mm: Reduce the area that xen_second covers Thread-Topic: [PATCH v2 5/5] xen/arm: mm: Reduce the area that xen_second covers Thread-Index: AQHYnGjeDDgZDtcVsUyunSX4tE/BZq2IpaUA Date: Thu, 21 Jul 2022 10:47:12 +0000 Message-ID: References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-6-julien@xen.org> In-Reply-To: <20220720184459.51582-6-julien@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 898a802a-246c-432e-d04d-08da6b066c17 x-ms-traffictypediagnostic: VI1PR08MB2800:EE_|AM5EUR03FT014:EE_|VI1PR0802MB2141:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: KIIMJhZrjtSrQ4Pwc9bJaBd0Asgo0uypC5jq+KAb/KoCl2k5P332hwf3eXzmH0QVuwCIAfkTyI/C+9TGbNUvRAmXdAwXTeH+YTNGkp1m/XN1VX0419gBZwmS9o+1OxETbrAu3GTwWm4uofTF/Lom/eYipTllXCfjwad1LvQGSA3hnIGYf4cGppkSzfaw0TumZpGXh5vNdHYCU6OZXLbz92L/iykwC0PP6PLE/ppM0fEQKEPVYV+Xmpj6RYm64UGKsadYNBd1U6RnYmpxNB79xDDAZcnE8BJhH1ax+wxrdQnWwGOP5CDNiACvxeUwtsxCEjVvtIQjvlRn6Y9x3DiGlZ/811a43aQDFGiUyUO6xy+VVUqAUROdErD3eqxV7Dtu3gGG2+EumB5eRZMxTc8j8N8kpMpL3wVQxM6s/USjZs9wXePkTQFD7a+q84k0sdev6LzDsLhTQmwQ+XaN6BJp1/s7fA+jZeD99P88d7h7prsO1h1rbxddL3KbuiQgYSDxAXUQcgbayKtFoiNBrtsbZApJk7HoKJn8hgkG/fKlVMlbkguU7eFtRSIVfuuXmCafx5Z6Wu89gHje1c4G0LknrcO7Bmn7SUx5WOVT74LMntveMdLbf0KOLXcw6Y4TLOW86byy+KaBcsWZzUNl5TZTBZKZzL5bKyt0lg2ZAGA/Zockrb1qxEe6YdClGPDuSGvNhwqPilQdbpAVOPHL1vstg8JVsk3CgzkZc3TJtLKmiBcFMD9TwAnYBLTY/hkatp/kQxBpb3HsUwy+MVtfjUW7PdbKykMqZ5xWODS16a5BRMs3c0FDXJQz3JEJ0325FufeHaw+s29NzqKmnBG4fU8ZYQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(136003)(39860400002)(376002)(396003)(64756008)(71200400001)(54906003)(6916009)(41300700001)(26005)(53546011)(478600001)(6506007)(6486002)(6512007)(8936002)(2906002)(4744005)(5660300002)(76116006)(66946007)(91956017)(316002)(4326008)(66446008)(66476007)(66556008)(8676002)(33656002)(122000001)(36756003)(86362001)(38070700005)(38100700002)(2616005)(186003)(83380400001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <60225FBE3A31DD4789BA7928579736D1@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2800 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6338256f-11a6-4d3c-f216-08da6b065e61 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Fl6uoo4AXTKcyvWLqZ0j1IgkHiQaRL2FbcEx/3d5zlTHAV9XZwyeb42yWm71nAGszkI2xGzFU3TLsAWEiaB/QeW7nvrhx+Kf1J29hvZpLfLbm99M0AY5lAT6nF67FJqJEcsGhGdkjN1JnlbqRLe4r4KbonEGJWe4KFrQjSS/w9NDnqnxaYcEG9BgwnmGKavXF7H9oa/DHQYEFZZn7JklrIHAUWxCBKGSD50rXdyuKDXKT6DEEiFCikCcfKpBVTGNeClJW5q8dvJ6O6sXv4QP34NVrsPpPLgAwK+ROkPFBfLf4z9W7hWFBW71kvFFIX/9EWOtEZOUSb4Tcc/Ss1AnhapJ/pZHCT5+bmzk7grHdkMQsV9VFRSD8+z79Bl9B/By0kAF1hKLm9DYk0qTSDQ9+D8YEpeOdFABLE7gH14n1cuALe+HzGTc/yXOwUzHVXsIEZE2ixR1qJulUQbhXyuLw4wdQU41x6oWjxUXlIbC71Sfabup9GQQzaJBl2gyJN1wCEjp2nU8mK+vN4DoQwnX0WDyYEpQ/Dbn358tGdiTS0Nkm98INNK48jEMthZ64tOxj6pU1zCn6q93nje8u2bBbxq8u1EYotcUKC4FWmHw9gbEGIZdLnDrQi+qf0onlJ3zAnPJrREHQPZlNcgWCwALPqrE0gUJqCAUj1vD9YTwUyuH51iJ5B3SFI0DnIGuP9eKJfalsIqSRkuiC4DEu9KQDLNKGao7zKCinmqTVeEI1HqiODyVMQ/TlaE9IpYUacsw3CPkPBx3mMXnkk8CJdY4gmeBg5pCbfCWYMbnmboXgCyP9Vmqj6Jvi1isHxz5YaN+ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(39860400002)(376002)(396003)(46966006)(36840700001)(40470700004)(82740400003)(81166007)(36860700001)(356005)(40480700001)(83380400001)(70586007)(47076005)(336012)(316002)(8676002)(4326008)(33656002)(36756003)(70206006)(186003)(6506007)(478600001)(54906003)(6486002)(82310400005)(40460700003)(41300700001)(26005)(86362001)(6512007)(53546011)(2906002)(2616005)(5660300002)(6862004)(8936002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 10:47:35.3197 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 898a802a-246c-432e-d04d-08da6b066c17 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2141 Hi Julien, > On 20 Jul 2022, at 19:44, Julien Grall wrote: >=20 > From: Julien Grall >=20 > At the moment, xen_second is used to cover the first 2GB of the > virtual address space. With the recent rework of the page-tables, > only the first 1GB region (where Xen resides) is effectively used. >=20 > In addition to that, I would like to reshuffle the memory layout. > So Xen mappings may not be anymore in the first 2GB of the virtual > address space. >=20 > Therefore, rework xen_second so it only covers the 1GB region where > Xen will reside. >=20 > With this change, xen_second doesn't cover anymore the xenheap area > on arm32. So, we first need to add memory to the boot allocator before > setting up the xenheap mappings. >=20 > Take the opportunity to update the comments on top of xen_fixmap and > xen_xenmap. >=20 > Signed-off-by: Julien Grall > Reviewed-by: Michal Orzel Reviewed-by: Bertrand Marquis Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:03:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:03:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372666.604517 (Exim 4.92) (envelope-from ) id 1oEUu0-0001uu-5o; Thu, 21 Jul 2022 12:03:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372666.604517; Thu, 21 Jul 2022 12:03:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEUu0-0001un-2t; Thu, 21 Jul 2022 12:03:36 +0000 Received: by outflank-mailman (input) for mailman id 372666; Thu, 21 Jul 2022 12:03:35 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEUtz-0001uh-1S for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:03:35 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 23083679-08ed-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 14:03:32 +0200 (CEST) Received: from mail-bn8nam12lp2170.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jul 2022 08:03:28 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB5936.namprd03.prod.outlook.com (2603:10b6:a03:2ad::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 12:03:26 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 12:03:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 23083679-08ed-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658405012; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9/cjYmO/D1diyqQ8GoCBUNEW51CV5dQxoRAoxdm4Nzw=; b=STGHFOS0WPD+808yRn9Wn3UkfyfHoK0WLL8c7YwwLeqHHWCL6oOkOQNT XIAZUjCSOusHWmQLdvyRXjFwsXlTjgZo2zyJnd6JE/6H1nmAt9wZAbA2D Lcbd5soKnaBq8UwEiWlSE+jWiL+F1aU4XulOyTTmKvqjkVQBjJLppBttu 0=; X-IronPort-RemoteIP: 104.47.55.170 X-IronPort-MID: 76314507 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AcTqf/aj0wY8wjccTmUTmSLhSX17brhtd9AX2u?= =?us-ascii?q?qucmGbUl+iq8fl2rXO55VgNIJqpwNvMcIhBfowPmyaELMbgpxAz4Z0DIjQGv?= =?us-ascii?q?GHJHw9w6sG5E6HsI59d/cAl1IlCGqY0IN+FiyMOPMzc9/c3kGwiUAlQ/2SET?= =?us-ascii?q?SlpCJbWUTfNIoM37fyZCv0qPlgWkyhpMZfwnKlbIX/hKW5nn5/SGswrcx0nV?= =?us-ascii?q?p5wg6HjCDgX6hE1asp+FZYH8ZAibf6uNsx6EgCKReZSC+iUgs822bDaATSXo?= =?us-ascii?q?WKcoOg5J7iEefC4seGDVSEzsilStLxGiVVRrCVM3tUkNTjvbLgvbLq8Rs0ye?= =?us-ascii?q?FJUhWf5extkdZVx2qFnX/6s2wUTTeAiaRZ8uDXPfkWKjakt8e9mUPL6v2lEL?= =?us-ascii?q?quV+wP93xtvhFnMkL2B6Hw70qxXo3mcTrE2aWObDBYh0PTY/ak3c769AzTb/?= =?us-ascii?q?MVJB3SxcCinhx0M2ScBhS2NSIfwGRr9upSMzFTq8NyJ+Eokx6zDRuVtzJB8x?= =?us-ascii?q?DhcpKePuY57ubdun8AIEdCEwpHKkcYFyHtrviRLLg46r3LNQo7LMulELKROO?= =?us-ascii?q?bAhXtz5rMb1mD1/A/w3J9Bb4cCFlptax0ZlROIS9la5LsTIBqDD3qD/YbAoZ?= =?us-ascii?q?my2+HK8iGv3FMzti+PC5rjfrCdwpNBIxdKJoZlqQenn0o7CiflEWesRxG3rb?= =?us-ascii?q?yrtF8XUU2dIwQ/6jArc59HF0EY2zb+mF6nXEIWcrqy9r6uMdUE41NWsXyZ1z?= =?us-ascii?q?eHNtKmzJg7NUwy+BBLqTIrM8F3D+rMx6DDzD+WR+iDxUH0PjCqrrjLpg0w5Z?= =?us-ascii?q?idqtidgNmW7KXBC/94/Gr1eGd3slZ9gzuhbHnwU1apUGA5Cx5aBcwhsnj5dL?= =?us-ascii?q?wLhkRX5oK2QEoZ+yWifP0m+i8biT0AJyGQKZL6n9xXUM/zm0hCtm00m8FDk3?= =?us-ascii?q?kUG1RfZPoHcEOr9oCJWoh8903rztvezdHRuLV1FTQGapw06JZRyWs3vYf+WW?= =?us-ascii?q?7Krrj1AUujmSwiuZASMEL8iEmUkw5fEVJimip0o/GFGW0Yh758yC/P/0rij9?= =?us-ascii?q?6IAyi3fNjF7ugQEiwoq3suCrk0CvGgFNFiXEE3k+XrRYLlnR8HsUJ+LawTFm?= =?us-ascii?q?Wjpn/JTqdpoGKw+uhFeJSB2M4cfGo/i53OATTRsWpcVpzu2Ampl9k+AhswN/?= =?us-ascii?q?B7nJeDeqeWXtovjUmyL6n2uiA9VD8rfbrPHZm8wB/8Ddi0EETpXIBqm3qbCn?= =?us-ascii?q?Pe1t2vOhSpT4vl0JljQykbF9JJ/yE4+sYIIb0baL+Exrm1GVRRqUPHNIWvhm?= =?us-ascii?q?Xu2R6YzGsas9Nb4i+A/Z6YBY9ASraH8YssKdNjHiC4YFw9hLuz0iMDgGmOZE?= =?us-ascii?q?d6lFAudDlmes6AArFnNs5hkTZwa3tlYnaLKcLke5IEwPuvTMfuccaat2xJmC?= =?us-ascii?q?1xGK9f5pnuQ6TWPnrNeFgFkcGI49CgqRof8UqLPrpifTyNiArdGtQ5zN6kyC?= =?us-ascii?q?uCY5FoBINgyrS3x/+eTn52n2tgbtbbSm+Ski1lwD0J4nuNfr68oZeIpQxIS8?= =?us-ascii?q?9qiWoJkYJt2Gy/uLf/vma6ahAp++n8Cph69gevGAmm/RT8xkDDDS2dVhQ6c5?= =?us-ascii?q?w5A/wurJmfsGmk7eqfvAD3XlqmhJEgI822YBhm9q6v+nXO/oaOnttplzvinW?= =?us-ascii?q?DZpzErctosacCe+g7/XY0qbEkx1EJAA15nST6lw2FVisIRIRLv7yzp+c9nvY?= =?us-ascii?q?iXhq7E9vURIaIjrlHZeM5MvEeXiO396qzoymH3dxgPUNumlSWmigysetzDLq?= =?us-ascii?q?8mCVzrJX4VE25I1IqfW0KMlDlfiWOJ6QbKlZd/R76ZQeFJ7tRzlcNVaG5D9M?= =?us-ascii?q?sKPBskETuWqBSvR+uMw4nQg/3Jz/qR+tTTKgF7zgz8SggcLS7hl7RdW67qHG?= =?us-ascii?q?gNLPFVFCS7thK9fFStAMGhmQs453aPgsU3w8SN7V1EaBvtlEYobPqkkBTEO9?= =?us-ascii?q?qW0uwQ89tnzvGfMmfBeOwJrGc6ZZvnVqlbRCH2V3S1Q+qYV/OtlDixLj0j5O?= =?us-ascii?q?WXFWz4U6IhWsXmDKGaA5QpmYxCF5TmX5/I2A8ni6TFLZ/FKBlfjWuR0lRLNO?= =?us-ascii?q?zDGdta/TP4NggyV0lNpmN525zRmZrDQ5Y7MeELZLgSCKdW+dZPDzVVKkCSTy?= =?us-ascii?q?2ELBRJoKej1yGBKuTgR9qsL7gw6o94+uys0wkX0GaEzHg30Aju9C1F+M4maf?= =?us-ascii?q?rrGHSKvC8NjbdZvuQSMv7xDyD3CG/vJvivg4D8MoJiQKDRi/xRmJL0zQU7ss?= =?us-ascii?q?SOUv+oz/2Qkthu3nTsonJgxRS6sGUHxlZ079u9oo0qTyafjHikbHA/AZDK1z?= =?us-ascii?q?zC0Yes0nSNxacghkQLlYeHmJMEVApFgueCQRtBqmUtzSG8BpKy18On35WAEY?= =?us-ascii?q?xg1NjZmIIWpL93Xp/aHAYEjbrknRPM5ICChhPWOJ4JVVMBG3qw7ym+YwBt3X?= =?us-ascii?q?33vwax/VvtFz5rQm50VReI1u7HwVo6oOOOPCqcgz97VqwT13dr0OCs4oOZXj?= =?us-ascii?q?lp8yyK595ktS+Z23IRHztjAl83J5Z5mw6yzRxz4OuQZ94uTvkuz8S4VH4WSr?= =?us-ascii?q?VPPme7ZqDI1kim1JlX7CjEYTgf8U5W/vzIO4E7H2+zc6NY+yYWHpJmRqsSmV?= =?us-ascii?q?Y9Kta+frX9fbIkB0SX3KqFiTA=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76314507" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IUFInXPNVKnFZs82GbF3/6xKsQTDZmB+BBSZEPrmvR0+DKWwuh32CpSCmTlzWm923ArvD0x0MXEnjfarG1fec2nFhHKnMpLYXmSlSWG8TlLGXp1EzspAeGYCb5CoLgvD3vFhFmgka2FWlEi5AqobVkq8dGb97DYOr43ijmM7oG66b16r7xYrKi1PR8plik3gsSTOPVIL7abycMM2mo9ZIOfyZmwwWe1ksrehu9tR06dThtEEVYsDBTqjDeCye4ViPcZMDZ8ltIjRwC4tKhZ9pFCFY5iRU6QK5onViDVZe6vCC1oLdxo62JusAJzbClublPcDagEJnbfVJ/FjXUuCVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/cjYmO/D1diyqQ8GoCBUNEW51CV5dQxoRAoxdm4Nzw=; b=bQ45y7TZqDo9vT1FDehaqekIXqZlG/jfJB4j+pPTuE4scbzaR8OByyI9DgVy5LHVqb3GqocMhTe/mzQMWJ9NhI0RqYiY1HemdhAx6nRj7kB6ZLCDF4+nnld3+kxvTKBbRyM6SFYT4FUj+EsHI6opS6WvBakOMsGdgBNyYP+/jF1bxMNibr6cPw1iNKbncfiQ6TlMjD7lYki2pu4FIhq9INJrWdO0537S+aNOaZepWW4SoB/gJhhUtfqXGfzReZpyn0v1QWimJZzmh6EeB4Pot1hpKIYkE8/l0osmnKE6v9ZD2+VOOir3UeYspVIWjo7FplG+BXoDJF8z9oVSvlTLmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/cjYmO/D1diyqQ8GoCBUNEW51CV5dQxoRAoxdm4Nzw=; b=VuQh3ciR5czuHxt9Rnn9xxI0ZQUxGMTCB5Po2HJ40gOVGuo2YG5PEYPfmHYRXFd/WkHYW6NY5SgP579URRdyTzdgcF3eDgJePUtFki/K5LOUmgeFM0bYv81vmk5XbUE7/yGq2W8FB2W9DCxq5TkdGAz9LPaTj3FVz8QOVjGFEwo= From: Andrew Cooper To: Tamas K Lengyel , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: Re: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Thread-Topic: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Thread-Index: AQHYnGkyeHzLfYftlkqMXoeeKAYG062IuvCA Date: Thu, 21 Jul 2022 12:03:26 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06b2422b-b64f-4526-d897-08da6b1104a2 x-ms-traffictypediagnostic: SJ0PR03MB5936:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eTaToG8o1B57L0ubQ+u8vu1weQOjdOo3kSSamDMp3g1GopDxrtA3YPnhz5c64TMEy9vest1QKVS3yJ6ZhQmJSpM1SgGa/UypaxF+n7uWnmSZHjvOMMdb9M3sOKEMX0ItAWs6At0U/f/Tk9zBU87vdf76I1aChfHQtNHxJJt0Gg0p6N6s2NG9aIBVSiPnwizPo5X1BSiyCDdUUZWWvIT/Vd5y+4UeLpoaVOw8kogrLy+38OLJ4J0aFuHhor7DQKjpgRrWKSd7yldFiR82ap54eLbwNSN5X+hH4P7rg756NZlYPTIwhKHoTlKqy18SKFSkWinQ3H4AWY7oCYz+cD9W2G2jevNADidvfqJsJqR403CDKk5/1qiLIjob3KmU0WKM+aSX1FO95GjSfikB2FUt3qgdp4GiAlXiIojjQ5+rGQZgVPN8yh4U820RW4rui4qPEwFZti0xQH0l1s50eOW7B+r5YR1vimNYIWmsq9iapYrb1P29ixerrd1LSIfLr2CUzFnz7JTrWaARjreZusNWwUb9kL+W7XL9xbfFB/CPQyHUdk56yCc3txKbwIh9MQR0vaiAdeJ/1zyOfDxcftT9U+j/n7AYjXs13TBPTN9sTf55hC+3Fza0GJ93gz6DRwxDek1SRk1tut+R3M6diXB+6QjhAtn42cda2U8q3hsgT59u1hjBPkvZW/qu+MDmqyDugeoBnHGm3eZu2rkkUmzgyu6HDQD8RAcphKVZU/Yp17PvhP6AHoe5hfpunPsx8uAsiV3wI56DM0NU6JojYvbYv9A3c/ekMpLKHjgzgYcRm0zmVVFOVRWVnsMtTJo0kWUsTyDgb1XlbpSP6Nti0DdgmTsWENHGvYrV/UCF5FV+jO6Veupt75Seapk6Z92TSSa/ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(31686004)(2616005)(110136005)(186003)(107886003)(86362001)(26005)(38070700005)(38100700002)(6506007)(54906003)(31696002)(6512007)(53546011)(41300700001)(66476007)(2906002)(66446008)(91956017)(76116006)(66946007)(4326008)(36756003)(478600001)(71200400001)(5660300002)(82960400001)(316002)(122000001)(8676002)(66556008)(6486002)(8936002)(64756008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?SENSRlBXS3pMaDNPeDVOcFVRaW90bTZtVHJFUVlGM1Nvd2VzZVdTVEUxN09N?= =?utf-8?B?b2ZSdGZzL1JFV2sxWEhabTlxWVdOZWRxbVBNSTVOZmdoQzZBZGN0SGxmR3BZ?= =?utf-8?B?SDlIWXJrcVFlUVBybmpJVjlDYlJFTER4a20yUnZVYTVlc1pvTFhwMGZ5cnFS?= =?utf-8?B?ZmFWZUsrYkp4ZDNBdGNmcXBBZmtoaVI0WDB3S3NPV24yRGxIWUt4WWVxZFJu?= =?utf-8?B?enpYM0Q1dEtRckNyVldrbGVkYTlrVTBWaDl5bnk0VkhyTDhCY1Z2V2FoazZw?= =?utf-8?B?MGovZ0I2QnBMWWFJb0Y5ZXNnZjhoWGw5ZnZ6dHRDQ1hwRFhMNlBJZFpoUkU4?= =?utf-8?B?S1V0dzI0eXExdTZnbXBpNC93a2ZBVkUveWdJYkNZRS9tM2J6VXdYUUtYU1Bk?= =?utf-8?B?NjdaRWJCZWRqTmloVVNVMXJzdWlPY0NmQVlVbkI1RVQ2VFZGRWJkTjBHdk44?= =?utf-8?B?QldjdkFKdFhmMmREY2JWclYxTitoZEsxVzRaanpxNkxkUDkxQWk0YXk5ZVFT?= =?utf-8?B?aFQ4cGVtWWtWNjBsTjFJOWpxZ3Y1bWFGQ3NoTU1Lb0RtSmk5cXNaZmN3WVAy?= =?utf-8?B?ckFsY2hiZVlrWWo1V0x2MWowaGlNSTZ0cVlSM0h1VmxSSW5IakMvUTBSaUZU?= =?utf-8?B?ek9iNVNCbm9jdFdqZzlaSm1CbDlsZDhkeHJYL3kyMGo2MVpUN0h6dk93MWhH?= =?utf-8?B?VVVkdWRwWHpjTy9GTEpFNHpDdXZ2UlQ3UEdZK2poUXQzYmdjSm5TRVBTVFJJ?= =?utf-8?B?Y3ZZbnV1V2tpSU94ZDlMZE4yWGltaU1PSzlWeW1OOVRJcndySGh5TE5KYm1E?= =?utf-8?B?SGdnOXZMNlRKYkI5OVIrcXNaVnBNMDZud1BGSGhheWFzV0RxT2RYVlhZeEkw?= =?utf-8?B?S2NLemkwemhROFpoajBORS9tTmNWM0xoYUdFUG5TR2tqUWZQK3dWSnJUcVNi?= =?utf-8?B?bEozeHpMTWtINXVvdkl0UHJUNnN0RUlCRTFsNyt6Y0NBRk1hREgvOThNTXl4?= =?utf-8?B?OFZ3MmZCOUxWTDlEVFNvcTZObVFUTnJhZ0lxTWZqajZXdnRPK0R3WDhkVnlN?= =?utf-8?B?M1RueExLbDJJMzFUeDN5N0JvRmxTaTNYSUh2aW10WUVreUNxMFl2c0xOS0Zu?= =?utf-8?B?T050cktjZVRjVnpXaW5sc05zWDgvM08rb08wRDRNc3JzN005K2t6MkNodUlX?= =?utf-8?B?NVF3WG5iWWZOekxBZGZTeEk3UHpIeUkvcmhUbFNraEY5aWtlSFBOZU5BQmEr?= =?utf-8?B?clR5aEZXWHYyL0RhTEJrWFo2eUVHaWNGVnRleTZOdGg0Vnd1TFdMSG45RzJp?= =?utf-8?B?eWxNYndUcmtjMWtwQm9qMVFETDZsSFBlcEg2bDdVQit1V00wVHBKbWRNeGNr?= =?utf-8?B?RFdMcG85d0w2VEVLWElBNk03bEtzNUwxYldFQWlHLzBwWUdNeXd6Qlgvc2Vm?= =?utf-8?B?cjNTbWtjbEJ2SlkvbTFZNkdkUmZIc0lueW11Y1hvR0hPQTFJRmJWb3ZOc0My?= =?utf-8?B?NE5aaEVNNlBzbE5xUlVaMzhHUy9QVWhkbzlWNHlpRGcyeXNDcW1mSVdTZUxN?= =?utf-8?B?VWQ1YkRVSXY4T2U0Rml6czkvTzNLUWtWOTlIY3N4UVROZk1DT1NqTFdTNHA3?= =?utf-8?B?SEowMmwvMmhUS25RSmNRVHFTeTBpaFd0Q1lzSXlobC95TDNXL05kdmxkMXpR?= =?utf-8?B?YlREV2R6TFlDNWFmVWJWNVdZcUtsWU04TXpyTmF1N09DaTk3L1FIYzkrRHJK?= =?utf-8?B?eDBSc1d4TzY3RmVYT2FLOVpVbFBHNmtkZEZDNVlBd0R1OFlTK2NFSVZRZEpQ?= =?utf-8?B?aXdrS3JUZzQ5T2ovZmQzQ3B2c0lJTVhtVmpFTUl6emlWZmZVTWRmTUV3M2dT?= =?utf-8?B?S0RjNGtqRUYzVXFJeFR6WFMzbWMzaVVlN04rU2xxNFljT2V1TDZNVE9iNmJZ?= =?utf-8?B?NVY1U1pOd1dOSmFTMU9QMkZBazdRNjhrRFFGZjVXRFBpcmxOcnMxNnd0Q3NV?= =?utf-8?B?VlZvWVpZdnZNTXJhZjZTTmVpT2lJOFNGbFJtVGxqK2xlSlh4bXovd3VyVVJM?= =?utf-8?B?TmlZaDZvaHBPbWUvSENhRksyVlZCWjllOEFCc2pxN1hqV2pWSnVDUjd0MGtU?= =?utf-8?Q?XgSGUmN+1RPoPQ+8+5AgmsAp3?= Content-Type: text/plain; charset="utf-8" Content-ID: <9AAE41FB181C7146A82A408A655B87B1@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06b2422b-b64f-4526-d897-08da6b1104a2 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 12:03:26.2587 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xuLO7xG55ixqHgPnS4mZe5vFtM7SonHrF8sPy4S6s3URyrvo0OIB6blY7GOl7RDoobNX38hkhIFF8G25OM6CiiswmACnWHrJsTTkm0rbbzU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB5936 T24gMjAvMDcvMjAyMiAxOTo0NywgVGFtYXMgSyBMZW5neWVsIHdyb3RlOg0KPiBkaWZmIC0tZ2l0 IGEveGVuL2FyY2gveDg2L2NwdS92cG11X2FtZC5jIGIveGVuL2FyY2gveDg2L2NwdS92cG11X2Ft ZC5jDQo+IGluZGV4IDliYWNjMDJlYzEuLjRjNzZlMjQ1NTEgMTAwNjQ0DQo+IC0tLSBhL3hlbi9h cmNoL3g4Ni9jcHUvdnBtdV9hbWQuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfYW1k LmMNCj4gQEAgLTUxOCw2ICs1MTgsMTQgQEAgc3RhdGljIGludCBjZl9jaGVjayBzdm1fdnBtdV9p bml0aWFsaXNlKHN0cnVjdCB2Y3B1ICp2KQ0KPiAgICAgIHJldHVybiAwOw0KPiAgfQ0KPiAgDQo+ ICsjaWZkZWYgQ09ORklHX01FTV9TSEFSSU5HDQo+ICtzdGF0aWMgaW50IGNmX2NoZWNrIGFtZF9h bGxvY2F0ZV9jb250ZXh0KHN0cnVjdCB2Y3B1ICp2KQ0KPiArew0KPiArICAgIEFTU0VSVF9VTlJF QUNIQUJMRSgpOw0KDQpXaGF0IG1ha2VzIHRoaXMgdW5yZWFjaGFibGU/DQoNCkkga25vdyBub25l IG9mIHRoaXMgaXMgdGVzdGVkIG9uIEFNRCwgYnV0IGl0IGlzIGluIHByaW5jaXBsZSByZWFjaGFi bGUgSQ0KdGhpbmsuDQoNCkknZCBqdXN0IGxlYXZlIHRoaXMgYXMgcmV0dXJuIDAuwqAgSXQgd2ls bCBiZSBzbGlnaHRseSBsZXNzIHJ1ZGUgdG8NCndob21ldmVyIGFkZHMgZm9ya2luZyBzdXBwb3J0 IG9uIEFNRC4NCg0KPiArICAgIHJldHVybiAwOw0KPiArfQ0KPiArI2VuZGlmDQo+ICsNCj4gIHN0 YXRpYyBjb25zdCBzdHJ1Y3QgYXJjaF92cG11X29wcyBfX2luaXRjb25zdF9jZl9jbG9iYmVyIGFt ZF92cG11X29wcyA9IHsNCj4gICAgICAuaW5pdGlhbGlzZSA9IHN2bV92cG11X2luaXRpYWxpc2Us DQo+ICAgICAgLmRvX3dybXNyID0gYW1kX3ZwbXVfZG9fd3Jtc3IsDQo+IEBAIC01MjcsNiArNTM1 LDEwIEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXJjaF92cG11X29wcyBfX2luaXRjb25zdF9jZl9j bG9iYmVyIGFtZF92cG11X29wcyA9IHsNCj4gICAgICAuYXJjaF92cG11X3NhdmUgPSBhbWRfdnBt dV9zYXZlLA0KPiAgICAgIC5hcmNoX3ZwbXVfbG9hZCA9IGFtZF92cG11X2xvYWQsDQo+ICAgICAg LmFyY2hfdnBtdV9kdW1wID0gYW1kX3ZwbXVfZHVtcCwNCj4gKw0KPiArI2lmZGVmIENPTkZJR19N RU1fU0hBUklORw0KPiArICAgIC5hbGxvY2F0ZV9jb250ZXh0ID0gYW1kX2FsbG9jYXRlX2NvbnRl eHQNCg0KVHJhaWxpbmcgY29tbWEgcGxlYXNlLCBhbmQgaW4gdGhlIEludGVsIHN0cnVjdHVyZS4N Cg0KPiArI2VuZGlmDQo+ICB9Ow0KPiAgDQo+ICBzdGF0aWMgY29uc3Qgc3RydWN0IGFyY2hfdnBt dV9vcHMgKl9faW5pdCBjb21tb25faW5pdCh2b2lkKQ0KPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gv eDg2L2NwdS92cG11X2ludGVsLmMgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50ZWwuYw0KPiBp bmRleCA4NjEyZjQ2OTczLi4wMWQ0Mjk2NDg1IDEwMDY0NA0KPiAtLS0gYS94ZW4vYXJjaC94ODYv Y3B1L3ZwbXVfaW50ZWwuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50ZWwuYw0K PiBAQCAtMjgyLDEwICsyODIsMTcgQEAgc3RhdGljIGlubGluZSB2b2lkIF9fY29yZTJfdnBtdV9z YXZlKHN0cnVjdCB2Y3B1ICp2KQ0KPiAgICAgIGZvciAoIGkgPSAwOyBpIDwgZml4ZWRfcG1jX2Nu dDsgaSsrICkNCj4gICAgICAgICAgcmRtc3JsKE1TUl9DT1JFX1BFUkZfRklYRURfQ1RSMCArIGks IGZpeGVkX2NvdW50ZXJzW2ldKTsNCj4gICAgICBmb3IgKCBpID0gMDsgaSA8IGFyY2hfcG1jX2Nu dDsgaSsrICkNCj4gKyAgICB7DQo+ICAgICAgICAgIHJkbXNybChNU1JfSUEzMl9QRVJGQ1RSMCAr IGksIHhlbl9wbXVfY250cl9wYWlyW2ldLmNvdW50ZXIpOw0KPiArICAgICAgICByZG1zcmwoTVNS X1A2X0VWTlRTRUwoaSksIHhlbl9wbXVfY250cl9wYWlyW2ldLmNvbnRyb2wpOw0KPiArICAgIH0N Cj4gIA0KPiAgICAgIGlmICggIWlzX2h2bV92Y3B1KHYpICkNCj4gICAgICAgICAgcmRtc3JsKE1T Ul9DT1JFX1BFUkZfR0xPQkFMX1NUQVRVUywgY29yZTJfdnBtdV9jeHQtPmdsb2JhbF9zdGF0dXMp Ow0KPiArICAgIC8qIFNhdmUgTVNSIHRvIHByaXZhdGUgY29udGV4dCB0byBtYWtlIGl0IGZvcmst ZnJpZW5kbHkgKi8NCj4gKyAgICBlbHNlIGlmICggbWVtX3NoYXJpbmdfZW5hYmxlZCh2LT5kb21h aW4pICkNCj4gKyAgICAgICAgdm14X3JlYWRfZ3Vlc3RfbXNyKHYsIE1TUl9DT1JFX1BFUkZfR0xP QkFMX0NUUkwsDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAmY29yZTJfdnBtdV9jeHQt Pmdsb2JhbF9jdHJsKTsNCg0KL3NpZ2guwqAgU28gd2UncmUgYWxzbyBub3QgdXNpbmcgdGhlIFZN Q1MgcGVyZiBjb250cm9scyBlaXRoZXIuDQoNClRoYXQgd2FudHMgZml4aW5nIHRvbywgYnV0IGlz bid0IGEgdGFzayBmb3Igbm93Lg0KDQpFdmVyeXRoaW5nIGVsc2UgTEdUTS4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:31:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:31:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372678.604545 (Exim 4.92) (envelope-from ) id 1oEVLE-000645-NT; Thu, 21 Jul 2022 12:31:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372678.604545; Thu, 21 Jul 2022 12:31:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVLE-00063y-Kd; Thu, 21 Jul 2022 12:31:44 +0000 Received: by outflank-mailman (input) for mailman id 372678; Thu, 21 Jul 2022 12:31:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVLC-00063s-WB for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:31:43 +0000 Received: from MTA-05-3.privateemail.com (mta-05-3.privateemail.com [68.65.122.15]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 11e897ed-08f1-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 14:31:41 +0200 (CEST) Received: from mta-05.privateemail.com (localhost [127.0.0.1]) by mta-05.privateemail.com (Postfix) with ESMTP id 6465E18000AE for ; Thu, 21 Jul 2022 08:31:39 -0400 (EDT) Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by mta-05.privateemail.com (Postfix) with ESMTPA id 4019718000B5 for ; Thu, 21 Jul 2022 08:31:39 -0400 (EDT) Received: by mail-yb1-f175.google.com with SMTP id b143so1286571yba.11 for ; Thu, 21 Jul 2022 05:31:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 11e897ed-08f1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1658406699; bh=ouzZKxhU4ni00EoPmITNmMZrvXc+0VDuuzT2eDNtyio=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=lf4nUNGNCIhoy89VUCoIKRLR/+NDxvei33qes4UKV4H0gVSxuW2cOM5Q2W5/m1RH3 c7sTVjbrEv3eh3xAQ/hOUAAlGdb8k6C4QZVu5A0VtoUAcxYyhItIGpt/bcwdt/RTa5 35R1EEqSwOfauimszTBywxr+3Y5omXiT8e49bujQwUFkVQdVE32GjUC5ja1xImOrFj IXyxuXzd4W3OOVC0lPbrmn2Zz9tD6IlIqTnqMoJIRrQt9WbaaUZJtjwOlRNMlzq8k5 F848qI+vEV5n2Iiuf4lvNQ3d+lgnSpROk2SlGd8afvPl1GqQxhEDzcEYmlSGlCgPvj dQ3fsmJBz5b5g== X-Gm-Message-State: AJIora99oU2AX5dzMmM0lM9zCZmouKvRjjAN7cid8R7rOTcu5JmxcJ4A cM23C5/LhBeO2roJg70R2xJ2MONgMznRs956rgw= X-Google-Smtp-Source: AGRyM1u1m8FbtuDJQAFIubrmlgoohpd7wGsqHai3ANJGBSkUC4gR0n4A99diGsxfJcp8lFazfNannpjvOmwkaKWwUmI= X-Received: by 2002:a25:9d01:0:b0:66e:9087:4fb9 with SMTP id i1-20020a259d01000000b0066e90874fb9mr42996041ybp.159.1658406698340; Thu, 21 Jul 2022 05:31:38 -0700 (PDT) MIME-Version: 1.0 References: <3160640f-f74d-725e-f2fe-3d33c4999772@suse.com> In-Reply-To: <3160640f-f74d-725e-f2fe-3d33c4999772@suse.com> From: Tamas K Lengyel Date: Thu, 21 Jul 2022 08:31:01 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] x86/mem_sharing: support forks with active vPMU state To: Jan Beulich Cc: Tamas K Lengyel , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , George Dunlap , xen-devel@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jul 21, 2022 at 6:19 AM Jan Beulich wrote: > > On 20.07.2022 20:47, Tamas K Lengyel wrote: > > --- a/xen/arch/x86/mm/mem_sharing.c > > +++ b/xen/arch/x86/mm/mem_sharing.c > > @@ -1653,6 +1653,46 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > > hvm_set_nonreg_state(cd_vcpu, &nrs); > > } > > > > +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) > > +{ > > + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); > > + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); > > I would hope two of the four pointers could actually be constified. I don't think so, we do modify both the vpmu and vcpu state as-needed on both the parent and the child. > > + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) > > + return 0; > > + if ( vpmu_allocate_context(cd_vcpu) ) > > + return -ENOMEM; > > The function supplies an error code - please use it rather than > assuming it's always going to be -ENOMEM. Alternatively make the > function return bool. (Ideally the hook functions themselves would > be well-formed in this regard, but I realize that the Intel one is > pre-existing in its present undesirable shape.) Sure. > > + /* > > + * The VPMU subsystem only saves the context when the CPU does a context > > + * switch. Otherwise, the relevant MSRs are not saved on vmexit. > > + * We force a save here in case the parent CPU context is still loaded. > > + */ > > + if ( vpmu_is_set(d_vpmu, VPMU_CONTEXT_LOADED) ) > > + { > > + int pcpu = smp_processor_id(); > > unsigned int please. > > > + if ( d_vpmu->last_pcpu != pcpu ) > > + { > > + on_selected_cpus(cpumask_of(d_vpmu->last_pcpu), > > + vpmu_save_force, (void *)d_vcpu, 1); > > No need for the cast afaict. > > > + vpmu_reset(d_vpmu, VPMU_CONTEXT_LOADED); > > + } else > > Nit: Style. Sure, these were all pretty much copy-pasted but will fix them. > > + vpmu_save(d_vcpu); > > + } > > + > > + if ( vpmu_is_set(d_vpmu, VPMU_RUNNING) ) > > + vpmu_set(cd_vpmu, VPMU_RUNNING); > > + > > + /* Make sure context gets (re-)loaded when scheduled next */ > > + vpmu_reset(cd_vpmu, VPMU_CONTEXT_LOADED); > > + > > + memcpy(cd_vpmu->context, d_vpmu->context, d_vpmu->context_size); > > + memcpy(cd_vpmu->priv_context, d_vpmu->priv_context, d_vpmu->priv_context_size); > > Nit: Long line. Ack. Thanks, Tamas From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:36:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:36:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372684.604557 (Exim 4.92) (envelope-from ) id 1oEVPm-0006hj-8z; Thu, 21 Jul 2022 12:36:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372684.604557; Thu, 21 Jul 2022 12:36:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVPm-0006hc-6F; Thu, 21 Jul 2022 12:36:26 +0000 Received: by outflank-mailman (input) for mailman id 372684; Thu, 21 Jul 2022 12:36:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVPl-0006hW-5D for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:36:25 +0000 Received: from MTA-12-4.privateemail.com (mta-12-4.privateemail.com [198.54.127.107]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ba34de1e-08f1-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 14:36:23 +0200 (CEST) Received: from mta-12.privateemail.com (localhost [127.0.0.1]) by mta-12.privateemail.com (Postfix) with ESMTP id DF38918000B1 for ; Thu, 21 Jul 2022 08:36:21 -0400 (EDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by mta-12.privateemail.com (Postfix) with ESMTPA id B88D018000A6 for ; Thu, 21 Jul 2022 08:36:21 -0400 (EDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-31e623a4ff4so15560907b3.4 for ; Thu, 21 Jul 2022 05:36:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ba34de1e-08f1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=tklengyel.com; s=default; t=1658406981; bh=WeAe2LC7xCKJ81qdi9Kp9Kj6Yu7gsNTKz8RVccqjdSw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=LcQzNPbXnECcG9DVG6468KWzox/qFFVdlyJH+4sVN9r7OwPlqTHKNB/6thT+BtiST wj6OIIjzPyQgR0VjLQZTmY/YPYeU1aG2eyZ/YF6iLVgA85wDcmfdlfTea5O9QcC0it wP2rjxTG72EaisChK/GYQgEQBfbPnXeUhGwxfrkJ8zKmqJn6vHCfTOjsUATR0n7Uc2 B18diI509JoKwZx4nC1VhbuzxjR4eGB+6gpRaqYYgvkJrdjIRil5BjkOgnIqXwP8q8 pqAeHipm+eP8YLkFwIO/7pFh+9vw9MCcUvQOH+SuP33rGiqqW7GEcvQnGRTWMe1nwW nT8TWh0vlvEOQ== X-Gm-Message-State: AJIora+SnNeogO7h4/Y8B1Aq1B7JJwZ84rBho+EHoarpELswz4/0rLHp xRnkAG7RgYq0yBXqkieRwVcXucgtr+hc6NkN04g= X-Google-Smtp-Source: AGRyM1uiwC3kDgZwxczFKEVW5SAG5hFs0gH/AYnU4j/7P+vWA/O0hU7IA0XKb4ofhfG3y9HX3srny2kiYH/zZIYNMaY= X-Received: by 2002:a0d:f746:0:b0:31e:80dc:725f with SMTP id h67-20020a0df746000000b0031e80dc725fmr2091114ywf.460.1658406980878; Thu, 21 Jul 2022 05:36:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Tamas K Lengyel Date: Thu, 21 Jul 2022 08:35:44 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2] x86/mem_sharing: support forks with active vPMU state To: Andrew Cooper Cc: Tamas K Lengyel , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , George Dunlap Content-Type: text/plain; charset="UTF-8" X-Virus-Scanned: ClamAV using ClamSMTP On Thu, Jul 21, 2022 at 8:03 AM Andrew Cooper wrote: > > On 20/07/2022 19:47, Tamas K Lengyel wrote: > > diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c > > index 9bacc02ec1..4c76e24551 100644 > > --- a/xen/arch/x86/cpu/vpmu_amd.c > > +++ b/xen/arch/x86/cpu/vpmu_amd.c > > @@ -518,6 +518,14 @@ static int cf_check svm_vpmu_initialise(struct vcpu *v) > > return 0; > > } > > > > +#ifdef CONFIG_MEM_SHARING > > +static int cf_check amd_allocate_context(struct vcpu *v) > > +{ > > + ASSERT_UNREACHABLE(); > > What makes this unreachable? > > I know none of this is tested on AMD, but it is in principle reachable I > think. > > I'd just leave this as return 0. It will be slightly less rude to > whomever adds forking support on AMD. The only caller is the vm fork route and vm forks are explicitly only available on Intel (see mem_sharing_control). So this is unreachable and IMHO should be noted as such. > > > + return 0; > > +} > > +#endif > > + > > static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { > > .initialise = svm_vpmu_initialise, > > .do_wrmsr = amd_vpmu_do_wrmsr, > > @@ -527,6 +535,10 @@ static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { > > .arch_vpmu_save = amd_vpmu_save, > > .arch_vpmu_load = amd_vpmu_load, > > .arch_vpmu_dump = amd_vpmu_dump, > > + > > +#ifdef CONFIG_MEM_SHARING > > + .allocate_context = amd_allocate_context > > Trailing comma please, and in the Intel structure. Ack > > +#endif > > }; > > > > static const struct arch_vpmu_ops *__init common_init(void) > > diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c > > index 8612f46973..01d4296485 100644 > > --- a/xen/arch/x86/cpu/vpmu_intel.c > > +++ b/xen/arch/x86/cpu/vpmu_intel.c > > @@ -282,10 +282,17 @@ static inline void __core2_vpmu_save(struct vcpu *v) > > for ( i = 0; i < fixed_pmc_cnt; i++ ) > > rdmsrl(MSR_CORE_PERF_FIXED_CTR0 + i, fixed_counters[i]); > > for ( i = 0; i < arch_pmc_cnt; i++ ) > > + { > > rdmsrl(MSR_IA32_PERFCTR0 + i, xen_pmu_cntr_pair[i].counter); > > + rdmsrl(MSR_P6_EVNTSEL(i), xen_pmu_cntr_pair[i].control); > > + } > > > > if ( !is_hvm_vcpu(v) ) > > rdmsrl(MSR_CORE_PERF_GLOBAL_STATUS, core2_vpmu_cxt->global_status); > > + /* Save MSR to private context to make it fork-friendly */ > > + else if ( mem_sharing_enabled(v->domain) ) > > + vmx_read_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, > > + &core2_vpmu_cxt->global_ctrl); > > /sigh. So we're also not using the VMCS perf controls either. > > That wants fixing too, but isn't a task for now. It does get saved and swapped on vmexit but we don't want to do this vmx_read/vmx_write in the mem_sharing codebase. It's much cleaner if this is saved into the vpmu context structure and reloaded from there, so we can just do a memcpy in mem_sharing without having to know the details. > Everything else LGTM. Cheers! Tamas From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:46:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372691.604579 (Exim 4.92) (envelope-from ) id 1oEVZF-0000KT-Hk; Thu, 21 Jul 2022 12:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372691.604579; Thu, 21 Jul 2022 12:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZF-0000KK-ER; Thu, 21 Jul 2022 12:46:13 +0000 Received: by outflank-mailman (input) for mailman id 372691; Thu, 21 Jul 2022 12:46:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZE-0008VW-3V for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:46:12 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18377743-08f3-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 14:46:10 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18377743-08f3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658407570; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l+GzIgxPBvHngtRJvU9WIFoqyToE0lwj31ZPFwvXIEE=; b=XVS7xdmWGzAlZN3Oy0dom6pog1qapUn7lc9ckE0uGzwTysgLCQS/5n0+ Ulz6CPsG6X5B5Z3rWqYBvNVEMgbEPIBwR+cWgg54SQI5qEinzsAB4W7yO xZbbOgLCSBR6CEwSzhIijwoUp7kC3Fbg2ncyLyxxl+N/YemCS0GUN77kn g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76751237 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:sXqIL6MuUIcZUBvvrR2jl8FynXyQoLVcMsEvi/4bfWQNrUom0jMDm GUWDGqOP/aLNzH2cot1Otyx9EwOuZLVyYJgTgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyFULOZ82QsaDhMtPja8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPHndFpAxkSMLEo0cpUAHlo3 vM9dSwkO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJmagjAZBtefE8aEpskkM+jh2Xlci0eo1WQzUYyyzeNk1EoiuOyWDbTUuCxbMBywlSDm nqF9GTlXzNCHsOf5DXQpxpAgceQxHimCer+DoaQ7eV2iVeewmgSDhw+Vlahp/S9zEmkVLp3I EUO9i0jhaM77kCsQ5/2WBjQiG6JuFsQVsRdF8U+6RqR0ezE7gCBHG8GQzVdLts8u6ceWjgCx lKP2dTzClRSXKa9ECzHsO3O9HXrZHZTfTRqiTI4oRUtyIfHp45rqh/zfv1PM6+tqPb6PGzs6 mXfxMQhvIn/nfLnxo3iow2X2Wv298SQJuImzl6JBzz4t2uVcKbgPtX1sgaDsJ6sOa7DFjG8U G44d99yBQzkJbWEj2SzTeoEB9lFDN7VYWSH0TaD83TMnglBGkJPnqgKuVmS3G8zbq45lcbBO Sc/Qz956p5JJ2eNZqRqeY+3AMlC5fG+SIS+CqqNMIEfOMAZmOq7EMZGPBX44owQuBJ0zfFX1 WmzKq5A8kr2+Yw4lWHrFo/xIJcgxzwkxHO7eK0XOy+PiOPGDFbIGOhtDbd7RrpmhE9yiFmKr o032grj40k3bdASlQGMqtZJcg9bfCFT6FKfg5U/S9Nv6zFOQAkJY8I9C5t4E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:fcezi68C49tlW15HM7Nuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re+sjztCWE8Ar5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtFD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76751237" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2 1/4] automation: fix typo in .gcc-tmpl Date: Thu, 21 Jul 2022 13:45:59 +0100 Message-ID: <20220721124602.9910-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220721124602.9910-1-anthony.perard@citrix.com> References: <20220721124602.9910-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain The name of the field doesn't matter because it's use as a YAML achor, but it's nicer to have the proper spelling. Signed-off-by: Anthony PERARD --- automation/gitlab-ci/build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 72f2a317ac..5eb7312754 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -17,7 +17,7 @@ - /^stable-.*/ .gcc-tmpl: - variabes: &gcc + variables: &gcc CC: gcc CXX: g++ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:46:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372690.604568 (Exim 4.92) (envelope-from ) id 1oEVZE-0008Vi-9l; Thu, 21 Jul 2022 12:46:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372690.604568; Thu, 21 Jul 2022 12:46:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZE-0008Vb-6d; Thu, 21 Jul 2022 12:46:12 +0000 Received: by outflank-mailman (input) for mailman id 372690; Thu, 21 Jul 2022 12:46:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZC-0008VQ-NX for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:46:10 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 16f469e2-08f3-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 14:46:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f469e2-08f3-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658407568; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Uns11hYDdMSNgRjXpwobtj/xGQb5UASoHRMAOns4Ee4=; b=TcGm7mDb6hCdt4c5CNjkz7A4JPM96m+ZOaYR07SQ9bHp71etQrS2AwzU CmBTZn3pi9nUuIpitSSxGT+mWZX+uaasYj2ZfKx5VR+cwyy+dJtlzGufa /dmwr4su+4yIi+ZQtIjB13RkUMAKgMSZaM20pGYJBqsS1eZzBqkQmTFHD Y=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76321701 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:e8YWzaCoc+DaIRVW/y/jw5YqxClBgxIJ4kV8jS/XYbTApD501WQEy jEYXWGCOfaIN2Gmftt+Oo22oUoOv5TUz4c3QQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pe31GONgWYuaDpLsfvb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJW3fg0epwK14vBpYjy/8wUFNVr 98FFhlYO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTNpcBTHZQwJIloNAYgytOypmmP+Y3tTr1f9Sa8fvDaIllUuiOGF3Nz9c4yjZfp43Vai/ knL723ZEioQd+zExm/Qmp6rrrCWxn6qMG4IL5Wj7eJjilCXwm0VCTUVWEG9rP3/jVSxM/pUI lYY/ScGpqEo+EumCNL6WnWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcpQRQ62 1nPmMnmbQGDq5XMFyjbrO3N62rvZ25FdgfueBPoUyMJ78v8vqYslynUded6V/+HlYfWBA/Zl mXiQDcFu1kDsSIa//zloACd2mj9+sGhoh0dvVuOAD/8hu9tTMv8PtHztwCGhRpVBNzBJmRtq kTojCR3AAomKZiW3BKAT+wWdF1Cz6bUaWaM6bKD8nRIythMx5JAVdoJiN2GDB01WvvogBewC KMphStf5YVIIFyhZrJtboS6BqwClPa9RY+5DKmKNYsUOvCdkTNrGwk3PiatM53FyhBwwcnTx 7/AGSpTMZrqIfs+l2fnLwvs+bQq2jo/1QvueHwP9Dz+iOL2TCPEFt843K6mNL9RAFWs/FqIq L6y9qKil31ibQEJSnKMqdRMcgFbdBDWx/ne8qRqSwJKGSI+cElJNhMb6elJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23://7N2K4B/hKSP9ktpAPXwMLXdLJyesId70hD6qhwISY7TiX+rb HKoB17726StN9/YhAdcLy7VZVoIkmsl6Kdg7NwAV7KZmCP0wGVxelZnO/fKlbbdREWmNQw6U 4ZSdkcNOHN X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76321701" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Date: Thu, 21 Jul 2022 13:45:58 +0100 Message-ID: <20220721124602.9910-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Patch series available in this git branch: https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2 v2: - rebased Allow build and test jobs to run concurently. Avoid running "test artifact" jobs on branch "master" and other, when test jobs aren't runned. Anthony PERARD (4): automation: fix typo in .gcc-tmpl automation: add a templates for test jobs automation: only run test artifact jobs when needed automation: use "needs" instead of "dependencies" for test jobs automation/gitlab-ci/build.yaml | 20 ++++--- automation/gitlab-ci/test.yaml | 99 +++++++++------------------------ 2 files changed, 40 insertions(+), 79 deletions(-) -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:46:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:46:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372692.604589 (Exim 4.92) (envelope-from ) id 1oEVZI-0000cU-Pe; Thu, 21 Jul 2022 12:46:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372692.604589; Thu, 21 Jul 2022 12:46:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZI-0000cN-Mx; Thu, 21 Jul 2022 12:46:16 +0000 Received: by outflank-mailman (input) for mailman id 372692; Thu, 21 Jul 2022 12:46:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZG-0008VQ-Ts for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:46:15 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19ab8c06-08f3-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 14:46:13 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19ab8c06-08f3-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658407573; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HAlpDIChBskJIISW7qvJGVshVai7WZqyDUdysqvHuck=; b=MpjzucklPChO7QxXd/zk7reCDchzzC448k2o2Hs+AApsDzX71dMxokAt Jo52iwa+NQLi0Kr2uhgO9qh6155q/9bzMljITbnnTHBE7VrQg/S1CosIW PRHXBwBABuSV/brA3boRJQ+hMNC95Q2qBBmzloIrMT24gW8nz1sktrTEG s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76317781 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AfAblU64YbhhkzbLN3BdB1wxR2vbMJYAXvycv2?= =?us-ascii?q?9bIaENr3hjvzP4J6zDmcekdWPrztNzMcNnPa4wPmlJv28rgB4V/YzDj45YBn?= =?us-ascii?q?oOIehmiOdS4m1JWvl0QTppBfgQHDvWpMe/+9kbRsIQ8+YpucBSt17uEG9ZvD?= =?us-ascii?q?fCwbx9gmzDTinl1BbEx9wiViOdJZqX+8z5UTDW2jj3khVj/5fuhK441iX77D?= =?us-ascii?q?itHHmNyQBbiMwJAS3wcQ98JIokfWyDR9F10mcJ+Y7NCDXDhjUJnNrTGknQ9q?= =?us-ascii?q?MWajTdf2ui02dBsxgL8DZcXf7iAxSmdqbrYe4GiQPhqEMiOd5k/4OMHiean+?= =?us-ascii?q?wTGHA9vNDfss+kcJqxEncjCqkT7zl2cDR2I+RxpKb2HbFjzm6ssSlvNWyyt/?= =?us-ascii?q?cBpH71KBvRMIzUMFIPp1g1+WDJVujT6VhO9OSJ+Wz9hQLX5Dtj0uzzniOGBV?= =?us-ascii?q?+ONYvz/V676WN21YMFUTbaeHwVwhGpdA6+KauZF2xtdB/YZiO9f2PB7P9jh2?= =?us-ascii?q?JWoiKYh+G13BtizrMQAdqaNL+yj6LJlb8qhdjxbQT9LrNsSTxLGQ6miivWDI?= =?us-ascii?q?/LxJtdo7LQgrA1iKfYEdXfuq3vFM/jT4wrIfJ+U16RKbkvfFF3SPoMGe4jqO?= =?us-ascii?q?563V2px2L1AzPWhlutgkrBC4Z7inJiIMjzbyANmY5wD3K+27VmsuOJ245VT8?= =?us-ascii?q?vbWxa5aInRrNpC/wWBQbUn+AiZI8556VV06oOabezFT8uxS9WbUVgfEgJw1m?= =?us-ascii?q?ahcLxaAzgTMRDayv0hz8XtW3uHfiy6O3GiUyc0ykUUlwjVcpg45zCorpBvEo?= =?us-ascii?q?MiIg4znvKWpclYbALW8MTVNUEHh9mQvKnRxlaZnjj0yMySbfKTE0spewzneW?= =?us-ascii?q?kieusoKD44eseNRStUo+lPcbgtoF1L+MVccZGIIkoljiVzbi1aAcFXMp343L?= =?us-ascii?q?vkxGSEwmJ+03+eirGNnjYYHfsaSzo0UojK6dOpmJEv7QP5r5g6JoySFQdB/S?= =?us-ascii?q?wCgBDufGrKtcrO4rmzvfG6teB+0swZmR7GDE8WfUrk1amIXu6aw36cCuJ8zE?= =?us-ascii?q?1GzEkbhS2gBVoPQ2SNYonk3LE4+2IYHMFJgN4Ii6T/jmbukAnQp94XvOIYGQ?= =?us-ascii?q?rf344R2lXHvnBH2zwWvK1tDOvLJuTrRO6VI8IjYstoZszv4TY2luziRAmddY?= =?us-ascii?q?XzWtB3/LfxItsHFGP1hE+ZWc0pDEslW08PRbwIN8tTog6O10zGGQ+mRu2JIo?= =?us-ascii?q?ptmIkmxS+YJhkpC8KAbP4Vo0Z0ZWRhjWBeJuL5o8INBeMVTyvOkfqivAlC8f?= =?us-ascii?q?FqqqgWod2O+71KLSLQPAXzcmUv1GJzKTnrgsyF4NfBJo3HXvUhtA76Krm5PY?= =?us-ascii?q?hJjMQVe1stqBtMcDv+OZyNxW7yzrk7paeWjhBsG2E2xZ1BeRJ8zzG3Cxg5nn?= =?us-ascii?q?BLncmWy3xL3HgbsfK+tScRPfBac0Pbg92DqeQHmcCdYvQtfpvPBl5CZYcwcH?= =?us-ascii?q?3b3ACzgb1bm2nhxhVAC+eZdhflSqSVbbsViqG3ExZdoZqXXo55nfGBEl9azB?= =?us-ascii?q?8L4ZB/4iRiKqfCLnifMStHnePW559ShnR+9FGXIFv5RvvbbnRY8oHaA2+hxh?= =?us-ascii?q?E/wNV6OcRl9IJSIGx8rcWFETbCotgEzz09RrzRPMeFk+29va6Cct9iNPWnHC?= =?us-ascii?q?uj16m4SY/MhrJYFw0pvglEdKluiEWOXnJ9uwiLem3M7V924Dk/l9/pkY/16M?= =?us-ascii?q?J4+FS2aOnDMu6cYckbTT/Rvs9DGT24epLhWrsR23TXRtqiLkLURsWbOQeNLU?= =?us-ascii?q?i2/QQISxf2YwbXYrFcqSEiBTpls4IpzudjFQTdbSW1cmwGTtQOhZmbWjQE0x?= =?us-ascii?q?qrt0o/+1zOHkWrZOj7cU1di3WYULSmnZGSaMi1lPlCroaNfutr3L3F2ai7G4?= =?us-ascii?q?qj6TqFqByfAX8w63+i3Yfo8LygVHlh7Xlx56qfXYEDJbq0w0azFAvxzd6G58?= =?us-ascii?q?UsTJh4Q0pJMpdlgGaKcduqvQe85Qi/OhTq4TWFaJR3EpxJOu8iZL1qozqhvY?= =?us-ascii?q?au2xeEisYsy+84j1ugSr2X2HYLKuQbboQT5AGyD0KZBIknximlxC/GZrIj7+?= =?us-ascii?q?QHUfJDRkddUoyCd73v5+aXlaFfw4ytdhNI/QabIaGenW1pACZRJm8yAO7Yue?= =?us-ascii?q?IHdMuZ8nqqw8AgSSiDmDMo6LZSUXiVvZwKArVyzOsmvPtIxEt9WWAg76b5x/?= =?us-ascii?q?ZJBdOqjtWBCcUxuHVb2J3YCOuIdzEyQIOrCQHm/Qdnhda3Lzik+pHG0w1rEW?= =?us-ascii?q?SNIDOZatqypi+crX0wV38tySXtL9sU9p6HOdzT5Cx+wU7ZaWRtGXO+Jtu8yE?= =?us-ascii?q?ee+OOsZKuIdQla2QPpC8D4yee53GwpuZnUuO3XljuCQE76Gmk93Koq4WdnXh?= =?us-ascii?q?E02TvRz/MFvT+5DWlHGA04teEj52fq3mPu4V9JQZBOpJnVb0AXK+qID392fz?= =?us-ascii?q?kCNR3mWnajiEsnD+//82/fmxHP9W0kKF4dnZyjM6L8emVX1EcdnJ7OxuGB26?= =?us-ascii?q?0dID5v5QdaHBUIo6RO4xC7Tk+XSSdqMV9utDptCL5xMEQUgABHHtei4Miwdp?= =?us-ascii?q?9thTvxaxEXNDcXJITDwYGVyrxOj/hifehm2cYPA37h8yE23LcNMX5HuBbZGd?= =?us-ascii?q?+cxDTHbvUMQjeDw6wXCqTZ/NPcyU7VSVxldUvDKcenLPEsdQ3vfBNdoqEAXQ?= =?us-ascii?q?tX5mzBjWX/8mWUlQe0syOM9p/My8U+WxX6Ox/NzOVmgu547EiOfwNI3ue8Is?= =?us-ascii?q?sx28tyPp0p4NXpxm2bGUDpk1HlRpw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76317781" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2 2/4] automation: add a templates for test jobs Date: Thu, 21 Jul 2022 13:46:00 +0100 Message-ID: <20220721124602.9910-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220721124602.9910-1-anthony.perard@citrix.com> References: <20220721124602.9910-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Allow to set common configuration from a single place for all tests jobs. Signed-off-by: Anthony PERARD --- Notes: v2: - rebased, to include "qemu-smoke-arm32-gcc". automation/gitlab-ci/test.yaml | 81 ++++++++-------------------------- 1 file changed, 18 insertions(+), 63 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 42cd725a12..53b43801f4 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -1,7 +1,15 @@ -# Test jobs -build-each-commit-gcc: +.test-jobs-common: stage: test image: registry.gitlab.com/xen-project/xen/${CONTAINER} + except: + - master + - smoke + - /^coverity-tested\/.*/ + - /^stable-.*/ + +# Test jobs +build-each-commit-gcc: + extends: .test-jobs-common variables: CONTAINER: debian:stretch XEN_TARGET_ARCH: x86_64 @@ -16,15 +24,9 @@ build-each-commit-gcc: dependencies: [] tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-alpine-arm64-gcc: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: @@ -41,15 +43,9 @@ qemu-alpine-arm64-gcc: when: always tags: - arm64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-alpine-x86_64-gcc: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:stretch script: @@ -65,15 +61,9 @@ qemu-alpine-x86_64-gcc: when: always tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-arm64-gcc: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: @@ -89,15 +79,9 @@ qemu-smoke-arm64-gcc: when: always tags: - arm64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-arm32-gcc: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:unstable-arm64v8 script: @@ -112,15 +96,9 @@ qemu-smoke-arm32-gcc: when: always tags: - arm64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-x86-64-gcc: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:stretch script: @@ -134,15 +112,9 @@ qemu-smoke-x86-64-gcc: - debian-stretch-gcc-debug tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-x86-64-clang: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:stretch script: @@ -156,15 +128,9 @@ qemu-smoke-x86-64-clang: - debian-unstable-clang-debug tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-x86-64-gcc-pvh: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:stretch script: @@ -178,15 +144,9 @@ qemu-smoke-x86-64-gcc-pvh: - debian-stretch-gcc-debug tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ qemu-smoke-x86-64-clang-pvh: - stage: test - image: registry.gitlab.com/xen-project/xen/${CONTAINER} + extends: .test-jobs-common variables: CONTAINER: debian:stretch script: @@ -200,8 +160,3 @@ qemu-smoke-x86-64-clang-pvh: - debian-unstable-clang-debug tags: - x86_64 - except: - - master - - smoke - - /^coverity-tested\/.*/ - - /^stable-.*/ -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:46:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:46:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372695.604601 (Exim 4.92) (envelope-from ) id 1oEVZN-0000wm-2D; Thu, 21 Jul 2022 12:46:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372695.604601; Thu, 21 Jul 2022 12:46:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZM-0000wc-UI; Thu, 21 Jul 2022 12:46:20 +0000 Received: by outflank-mailman (input) for mailman id 372695; Thu, 21 Jul 2022 12:46:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZL-0008VW-0h for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:46:19 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1c77fd5f-08f3-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 14:46:18 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1c77fd5f-08f3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658407577; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4IwZ7MQ+unUkmwqNzuLpSWlb6ulXC3M5GmYE0wL7TYY=; b=biaWCaxyTr6eIUvQBoT2lAVxOp0MmMNUs68AbsD01G5kMt/DhOJN0o/O mHiv/Gm2ltMauWdGVd4knI5LGnqFwvSLt4porYSxcGFxcYnYkSCP8or4G yM1M5yT5shYVryHcepU6tdINpAkPWI1nsMkNAdToD8UpojUDvQJhTvkx3 8=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76321715 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:recdo6oT8GD6U1pZsj3Dueasxp5eBmIeZRIvgKrLsJaIsI4StFCzt garIBmCO/3YNzCgfdp/a42/pEMFvpLTm9BlTQNs+C5mQiJG+ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNOg06/gEk35q6q52lB5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUdq9h2G15V5 cYADzMcdSK6nfDx8LOSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIWLIYbTGpwI9qqej m3K01nFORNACPug8SK5q3StmuXemAquDer+E5Xnr6U30TV/3Fc7EwYKXFG2pf24jE+WWN9FL UEQvC00osAa/0WxQt7wdxaxunKDs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznS4ddEbSKlc3PARbz0 iu4lTIswIUSpJtev0mkxmwrkw5At7CQEFNlvFyNDz78hu9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 RDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0e5eIFcFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQP8gqKFXeono/Pxb4M4XRfK8EyPpXB HtmWZz0USZy5VpPl1JauNvxIZd0n3tjlAs/tLjwzgi90Kr2WUN5vYwtaQLWBshkvfzsnekg2 4wAXyd840kADbaWj+i+2dJ7EG3m2lBgXsis9JMGJ7frz8gPMDhJNsI9CIgJI+RN95m5XM+Rl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:PlS6eqmaNFOadbrrrl679gs9hu/pDfIU3DAbv31ZSRFFG/Fxl6 iV8sjzsiWE7gr5OUtQ4exoV5PhfZqxz/JICMwqTNKftWrdyQyVxeNZnOjfKlTbckWUnINgPO VbAsxD4bXLfCFHZK3BgTVQfexO/DD+ytHLudvj X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76321715" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2 4/4] automation: use "needs" instead of "dependencies" for test jobs Date: Thu, 21 Jul 2022 13:46:02 +0100 Message-ID: <20220721124602.9910-5-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220721124602.9910-1-anthony.perard@citrix.com> References: <20220721124602.9910-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Like with "dependencies", the jobs will get artifacts from the jobs listed in "needs". But the test jobs can run as soon as the build jobs listed have finished. Signed-off-by: Anthony PERARD --- Notes: v2: - rebased, to include "qemu-smoke-arm32-gcc". automation/gitlab-ci/test.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 53b43801f4..26bdbcc3ea 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -21,7 +21,7 @@ build-each-commit-gcc: paths: - '*.log' when: always - dependencies: [] + needs: [] tags: - x86_64 @@ -31,7 +31,7 @@ qemu-alpine-arm64-gcc: CONTAINER: debian:unstable-arm64v8 script: - ./automation/scripts/qemu-alpine-arm64.sh 2>&1 | tee qemu-smoke-arm64.log - dependencies: + needs: - alpine-3.12-gcc-arm64 - alpine-3.12-arm64-rootfs-export - kernel-5.9.9-arm64-export @@ -50,7 +50,7 @@ qemu-alpine-x86_64-gcc: CONTAINER: debian:stretch script: - ./automation/scripts/qemu-alpine-x86_64.sh 2>&1 | tee qemu-smoke-x86_64.log - dependencies: + needs: - alpine-3.12-gcc - alpine-3.12-rootfs-export - kernel-5.10.74-export @@ -68,7 +68,7 @@ qemu-smoke-arm64-gcc: CONTAINER: debian:unstable-arm64v8 script: - ./automation/scripts/qemu-smoke-arm64.sh 2>&1 | tee qemu-smoke-arm64.log - dependencies: + needs: - debian-unstable-gcc-arm64 - kernel-5.9.9-arm64-export - qemu-system-aarch64-6.0.0-arm64-export @@ -86,7 +86,7 @@ qemu-smoke-arm32-gcc: CONTAINER: debian:unstable-arm64v8 script: - ./automation/scripts/qemu-smoke-arm32.sh 2>&1 | tee qemu-smoke-arm32.log - dependencies: + needs: - debian-unstable-gcc-arm32 - qemu-system-aarch64-6.0.0-arm32-export artifacts: @@ -108,7 +108,7 @@ qemu-smoke-x86-64-gcc: - smoke.serial - '*.log' when: always - dependencies: + needs: - debian-stretch-gcc-debug tags: - x86_64 @@ -124,7 +124,7 @@ qemu-smoke-x86-64-clang: - smoke.serial - '*.log' when: always - dependencies: + needs: - debian-unstable-clang-debug tags: - x86_64 @@ -140,7 +140,7 @@ qemu-smoke-x86-64-gcc-pvh: - smoke.serial - '*.log' when: always - dependencies: + needs: - debian-stretch-gcc-debug tags: - x86_64 @@ -156,7 +156,7 @@ qemu-smoke-x86-64-clang-pvh: - smoke.serial - '*.log' when: always - dependencies: + needs: - debian-unstable-clang-debug tags: - x86_64 -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:46:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:46:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372696.604612 (Exim 4.92) (envelope-from ) id 1oEVZQ-0001HI-BU; Thu, 21 Jul 2022 12:46:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372696.604612; Thu, 21 Jul 2022 12:46:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZQ-0001H9-7j; Thu, 21 Jul 2022 12:46:24 +0000 Received: by outflank-mailman (input) for mailman id 372696; Thu, 21 Jul 2022 12:46:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVZP-0008VW-7Q for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:46:23 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1e9c5236-08f3-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 14:46:22 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e9c5236-08f3-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658407582; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PACc2mwSrwpX0iuSlqxknvAQt2F9ujkfuZBNPaxIerE=; b=huVn7XgRwTafIEv93M6de2MGVoH7uadTfVT7QeseqQpItZXKhUCqgwol Lx6aUzZWl88jIvyeBZoXAki0k2GJsfGyAXuDTHn6lvzot0/KKinRnkjMd TAaKSXPygg+20hZvP0qaGa5bv5mcQQrkRYcsUHGLObPKiMDH6DIbQChIv U=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 78888230 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:Jas/oKjzg6noFSZte7rfmUnVX161ZhAKZh0ujC45NGQN5FlHY01je htvDTyAaayNYjGkfNkjbt/jpExXsMXUzd9kTlY4qy5hFykb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kuo4WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4ePMoE/Op8L2J08 6IpCWE9V1Ocq6Xp6efuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI ZpCAdZsRE2ojxlnM1ELCJU4jaGwi2P2aTFwo1OJv6snpWPUyWSd1ZCyYIqFKobRHa25mG6qp TrKr3nrDSoiaveHxSWc1UucgsT2yHaTtIU6S+Tjq68CbEeo7ncIFBQcWF+/oP+4ok2zQdRSL woT4CVGhaM77kCsQ/H2Vge0p3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht8ztLSxitvuSU331y1uPhWrsY25PdzZEPHJaC1teizX+nG0tphOIUtBvG4C2tNurKBCh8 wnJswR52JxG2KbnyJ6HEUD7byOE/8aUHlRsvFSLBwpJ/SsiOtf7OtXABUzzqK8Zcd3HFgTpU G0swZD20QwYMX2aeMVhqs0pFarh2fuKOSa0bbVHT8h4rGTFF5JOkOltDNBCyKRBaJ9slcfBO hO7hO+ozMY70IGWRaF2eZmtLM8h0LLtE9/oPtiNMIceOcQrLVHcrXs2DaJ144wKuBF3+ZzTx L/BKZr8ZZrkIf8PIMWKqxc1juZwm3FWKZL7TpHn1RW3uYejiIquYe5caDOmM7FmhJ5oVS2Pr L6zwePWlEgEOAA/CwGLmbMuwacidiNjX8+p+p0OHgNBSyI/cFwc5zbq6etJU+RYc259zY8kI lnVtpdk9WfC IronPort-HdrOrdr: A9a23:Fd66paFz6OfHLd9QpLqE0MeALOsnbusQ8zAXP0AYc3Jom6uj5q aTdZUgpGfJYVkqOE3I9ertBEDEewK4yXcX2/h3AV7BZniEhILAFugLhuGO/9SjIVybygc079 YYT0EUMrzN5DZB4voSmDPIceod/A== X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="78888230" From: Anthony PERARD To: CC: , , , Anthony PERARD , Doug Goldstein Subject: [XEN PATCH v2 3/4] automation: only run test artifact jobs when needed Date: Thu, 21 Jul 2022 13:46:01 +0100 Message-ID: <20220721124602.9910-4-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220721124602.9910-1-anthony.perard@citrix.com> References: <20220721124602.9910-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Share the same "except" as the one used for tests. Signed-off-by: Anthony PERARD --- Notes: v2: - rebased, to include "qemu-system-aarch64-6.0.0-arm32-export". automation/gitlab-ci/build.yaml | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/automation/gitlab-ci/build.yaml b/automation/gitlab-ci/build.yaml index 5eb7312754..23b306e7d0 100644 --- a/automation/gitlab-ci/build.yaml +++ b/automation/gitlab-ci/build.yaml @@ -567,10 +567,16 @@ alpine-3.12-gcc-debug-arm64: CONTAINER: alpine:3.12-arm64v8 +## Test artifacts common + +.test-jobs-artifact-common: + stage: build + except: !reference [.test-jobs-common, except] + # Arm test artifacts alpine-3.12-arm64-rootfs-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12-arm64v8 script: - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz @@ -581,7 +587,7 @@ alpine-3.12-arm64-rootfs-export: - arm64 kernel-5.9.9-arm64-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.9.9-arm64v8 script: - mkdir binaries && cp /Image binaries/Image @@ -592,7 +598,7 @@ kernel-5.9.9-arm64-export: - arm64 qemu-system-aarch64-6.0.0-arm64-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:6.0.0-arm64v8 script: - mkdir binaries && cp /qemu-system-aarch64 binaries/qemu-system-aarch64 @@ -603,7 +609,7 @@ qemu-system-aarch64-6.0.0-arm64-export: - arm64 qemu-system-aarch64-6.0.0-arm32-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/qemu-system-aarch64:6.0.0-arm64v8 script: - mkdir binaries && cp /qemu-system-arm binaries/qemu-system-arm @@ -616,7 +622,7 @@ qemu-system-aarch64-6.0.0-arm32-export: # x86_64 test artifacts alpine-3.12-rootfs-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/alpine:3.12 script: - mkdir binaries && cp /initrd.tar.gz binaries/initrd.tar.gz @@ -627,7 +633,7 @@ alpine-3.12-rootfs-export: - x86_64 kernel-5.10.74-export: - stage: build + extends: .test-jobs-artifact-common image: registry.gitlab.com/xen-project/xen/tests-artifacts/kernel:5.10.74 script: - mkdir binaries && cp /bzImage binaries/bzImage -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 12:51:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 12:51:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372723.604629 (Exim 4.92) (envelope-from ) id 1oEVdv-0004A7-8i; Thu, 21 Jul 2022 12:51:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372723.604629; Thu, 21 Jul 2022 12:51:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVdv-0004A0-5d; Thu, 21 Jul 2022 12:51:03 +0000 Received: by outflank-mailman (input) for mailman id 372723; Thu, 21 Jul 2022 12:51:01 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVdt-00049u-59 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 12:51:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2088.outbound.protection.outlook.com [40.107.20.88]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c5465f13-08f3-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 14:51:00 +0200 (CEST) Received: from AM5PR0402CA0003.eurprd04.prod.outlook.com (2603:10a6:203:90::13) by DB8PR08MB3996.eurprd08.prod.outlook.com (2603:10a6:10:a5::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Thu, 21 Jul 2022 12:50:28 +0000 Received: from AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::5c) by AM5PR0402CA0003.outlook.office365.com (2603:10a6:203:90::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 12:50:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT023.mail.protection.outlook.com (10.152.16.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 21 Jul 2022 12:50:28 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 21 Jul 2022 12:50:28 +0000 Received: from e3b76a4cfdcc.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E866791A-B2CD-41AF-8BD1-5E4E8D930282.1; Thu, 21 Jul 2022 12:50:16 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e3b76a4cfdcc.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 12:50:16 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM9PR08MB7260.eurprd08.prod.outlook.com (2603:10a6:20b:433::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Thu, 21 Jul 2022 12:50:15 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 12:50:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c5465f13-08f3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=JZ4tybgaDFWjR2h7FS5aXI/5DQw2ID44lNqmiq/1vki4+8hBxI3hGXBE+Y35chFyssNbMHke1GV4Y9fonqJDcNwzLTV6JQV1ioEDSRxs3eL7KxYKaKaJNwIChPh/O8ZUXNH8mXZrKOJAX8FSKKjp0lW0Yax20B7mW+fuL09alJaIiHNhfLDwZj0m7109aZtcLztz1zVvx5gCP+Ce7KAi/usxS+pkyIl5s71V8qe4v85Q2pVJ73gC8OFqYf1qc1vU91kYtbAs83qCI/iOOnqtvY+9VuRt8RpVOsD5H40MT1f/DzTZezMGZXZCyKg0RA4uBcpq7NT6U/kNot3GE9o26w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeQr1vXptp6pTT09bPtp+3miZOJ5V5Uar/Aa96P3ZWw=; b=JppjC92jRvMVHJ/AZl/uy0w/+xMd42ZKEk0ner7XSvsjev2BJESCZ4a4H4EqDpsVa4MeaA7rSNgBwmgau1TbIOwKJaE59rqVYgg9/fWeK1DdRdhqYTkgwFJCBta7pjbwHtMYoDXE2QYCIpxXKL2VytxNmwUCjgo5ED96V+aYJ97H3t7p7Yo3PE8N74HhC29cen+M/Lh5hn2a8aafGslVMFW7fxxR7F26cWBgKM0z0G0mjf3DdsCgviY+dKhPhJaKweCrK57CKysGVFiHp141BV3+KiDDynFG42wUeRXO8/LA/9ulG8lLiGOaoPDPMrbSF0LsqVCuWvbCeXUNa5YsmA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DeQr1vXptp6pTT09bPtp+3miZOJ5V5Uar/Aa96P3ZWw=; b=gd6TxM0OsdLMnYxev+IF2KpEqxCXkcxug5ioLxU3cr3XLj/5ePtid9+2ToyrLl5ID96RkaJjl8FYwWyVLpsUibENQ5LS9EcBKkpjMW7VZsjXQVzh8+n1/wd0qddGt2+2PsWY7NZdcXK0qGFH1z7ogl8HiRIDeMEWkXnvNvNYozE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 9050cf5f9b421452 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C+5WhtA736SOS4vifFKTKOaiw0Edt9YOz86yXKSjBoRJEnVlAxLCjqiZUEdYgrsvznnch3nxRkYszyDIrJQkfnEi7yMfwi70Ul3Xr7xXws53/rqlHtGp5vBI5htVaWi1LIQ1ra4o9TyrxE5leA37e+efWHt27iQmc7B+M7CrNbxOsRv6ayaKmSxgr6HXEw+jeKLK4CDRYcTYriZ9gxW0Hv5j2j6i6mmTO3I6+G7o3oRtPAR/i2UyzXlKos+rkCYtdRfaX0zOT5S3E/KKeFPFuqLhBrGHrvTz/m66dyOirTox9Ttngc1XkeBfPE/cLmU5TVufTjbijiSpeUhgCtBoiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeQr1vXptp6pTT09bPtp+3miZOJ5V5Uar/Aa96P3ZWw=; b=YiWMO7U+CLAx0/NIsvg7j8/Vvzo1qzd5g+XQAKbVfipPQuA9glqZ2hBGNoxLV8usqDBZ1OmQ3Vy5Q6OBl1/YoAAriJqaCTbKev+vc+NvP9pPwCN4nUEJmjlMbssN2l13vXR3evnTnoBk+a3brPPbRTJkBDqY+Vrk9nrLYnHQAG1PLwJSX7H/n5jm2Ip1ID6iI9AaC+BUii2Oy9/l751LWg/B/tyc4VOw5wM7liX5DXa645FoBaJY/g1Bg+kHAqpCVn07gfmrea39Mjw5Et6NN0IoND8mK2iaYeLUF3NvyUA8GM7S4cijglolRv8nnsHXhqPWJzc47sxnotrtmCO8gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DeQr1vXptp6pTT09bPtp+3miZOJ5V5Uar/Aa96P3ZWw=; b=gd6TxM0OsdLMnYxev+IF2KpEqxCXkcxug5ioLxU3cr3XLj/5ePtid9+2ToyrLl5ID96RkaJjl8FYwWyVLpsUibENQ5LS9EcBKkpjMW7VZsjXQVzh8+n1/wd0qddGt2+2PsWY7NZdcXK0qGFH1z7ogl8HiRIDeMEWkXnvNvNYozE= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AAgAAEsgCACtZcgIAAFXWAgAGspoA= Date: Thu, 21 Jul 2022 12:50:15 +0000 Message-ID: <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: e2c31173-831e-424a-3f8b-08da6b1796e3 x-ms-traffictypediagnostic: AM9PR08MB7260:EE_|AM5EUR03FT023:EE_|DB8PR08MB3996:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tqWocHbXjJFBY0iYXz28Z4XlmqXDziNnFF/1602ZD6I9mjYPW2ZCT53YYtdsNAkA70NSzdARelnkH/p0UFcBOH3Gto8lWg78BS3HJ0hM0D6CTeligOyNUvWrT4zj0djQSEApIXoFY/oM+w+2o5bAiJmsbP5w03fFpRHtCJUQQorDphsqKR5M846FC/waqshjvsbqMqICCVwrOQfRU3qDBuDiFcajldg2bJK6E3wk67DeAYNqqYR5r1GF1qnUESdDS54XA0aN6S5hctUZlXi4wNHnilq+twGWPtCOexzBFzRGmw4PeW0pqBOsVCgyVn74uJoNARHpL2O44vI+9rvIb/u0Yx0IqCihuTOwx1QWaHhrZ3hs1xG2uuM+jtqlLBjBWRKb95rbFc+89L8CEVys0M19T3UH0XGg4Ne76u/xhghTXa2zr0iwBRKjGwmxqvI+L88cPvpH6rAxcGKxCnfeadhUyaK+5XKoAA64T9YN9VHFpJS9a5rRkRLtW2Hi04bOGBS7Oh+Ig1UNFbx1/xObb1gV1909wQwvmB31sQofuKLbgVFqsSzxfzknStvqL9wNqQ9OEOAJ4kZrq6Dem2WJVyDkrPV9taIU4WNrqXVTTmpXQs8+jnVjTOmf2xVhV+mYMWcq94XeCON03mUQwNVWIBJ/sgUozG8XjUB1iGjgh/RmqHEqsbMmP1R5mOLK/BuT2yTNa7V1ATD0l2cOoLojGcH0ppySWQSGn24uzbTBHtkNojYH6yvmPGkmUDj4HN3iUGCm50eHFoJhaR4ZGEk3n4DdXaPIW1+hMZqb1BEiuQrmoXj5L7poHl0eJTxxZ+X68cVXm66J/yg4WPbRThjIXA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(376002)(346002)(396003)(39860400002)(316002)(83380400001)(38070700005)(91956017)(38100700002)(71200400001)(186003)(53546011)(478600001)(2616005)(6506007)(6486002)(6512007)(8676002)(41300700001)(66446008)(66946007)(4326008)(122000001)(64756008)(6916009)(54906003)(66476007)(33656002)(8936002)(76116006)(66556008)(5660300002)(2906002)(86362001)(26005)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <061AC06C13E0B244807FBE5EC0F32DF0@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB7260 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 79a4bdab-9e41-4c1f-c33a-08da6b178f0b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FIb4ZXAm1mjh61Gd/ZxGpqaD2MBgCAF/1OxLJkA1fxtPH/Csuz3vh1qzpW6mpPeKsbkeH6SjT/MJ04qN4HpPNIJ9PmZ47+E83r4jWQCi3f+K6aBwkQsAPyA1bWFI8F8jemFkVmet0jjFuuwZPHt/sOea6QQeSREnDhlIYGXqveGPkDYaTta5LpeeaZkUCxeGqsrVueAKJxIEfdwAGlmGN0OSw2Nn4C83b21QlaG4WueWRMoRT33Lk9Ilk4zk6t9eOeAf3bzDmPVB5rVHi4GCvY0KKn2E8FcbmwYqZ7Z3ErTkvEDyRqrRXrted4bSVGmHYyWNW7nfttbBL4IuzsL8cdFfmtXV6s95sP81t43RD61P1PUXxQFykyLF/C3HPF9+Uhv+23F59QJ7OR5MFnDkVJNSBwO6lpW0Ni5hMJBTJOY5qg9vkrxevVvxCy3XFMaR9EAgU9a+rrLDHGxLm3PECqSz1P+RpN2emxa76mELKxOOLKNy1SC9VT3zLLFFbLsGNGpURuxWx6HxFt5BdG7BJAxFeF63uhkBh2rs2xoDEVn628shkVg4RzzGwYmAvIidZfT02IADtrDRGDpXZo/WnGXqyX9Fl36ai5lP04vesMM36M5RLvHQb0WPTqeauoen21vDaD4nA4yaChOAPZqaigDAsfG0a9wX0CXZ7TkzeudlpMrN0VOoYPUl4J4PgSyLNlHNioWgWRWrT05v8cw9r8BvHyg5gxV8n9cfyxRZx/xHUGjOOuWrJ54vEt9jutPOYKMWxDUiuAJDqbr05RqO3l1GNHEcXF70NEq/gvN7B/DrfvS9GxWAkuzNYYmRf+oX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(376002)(46966006)(36840700001)(40470700004)(2616005)(186003)(6512007)(26005)(47076005)(6486002)(41300700001)(5660300002)(478600001)(86362001)(36860700001)(40480700001)(81166007)(336012)(83380400001)(54906003)(36756003)(8676002)(6506007)(8936002)(33656002)(82310400005)(4326008)(316002)(6862004)(2906002)(82740400003)(356005)(70586007)(40460700003)(53546011)(70206006);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 12:50:28.5616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e2c31173-831e-424a-3f8b-08da6b1796e3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR08MB3996 SGkgSnVsaWVuLA0KDQo+IE9uIDIwIEp1bCAyMDIyLCBhdCAxMjoxNiBwbSwgSnVsaWVuIEdyYWxs IDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IE9uIDIwLzA3 LzIwMjIgMTA6NTksIFJhaHVsIFNpbmdoIHdyb3RlOg0KPj4+IE9uIDEzIEp1bCAyMDIyLCBhdCAx OjI5IHBtLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4+PiANCj4+PiAN Cj4+PiANCj4+PiBPbiAxMy8wNy8yMDIyIDEzOjEyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0K Pj4+Pj4gT24gMTMgSnVsIDIwMjIsIGF0IDEyOjMxLCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4+Pj4+PiBJIGNhbid0DQo+Pj4+Pj4gc2VlIHdoeSBpdCB3b3VsZCBiZSB3 cm9uZyB0byBoYXZlIGEgbW9yZSB0aWdodCBsaW1pdCBvbiBzdGF0aWMgcG9ydHMNCj4+Pj4+PiB0 aGFuIG9uIHRyYWRpdGlvbmFsICgiZHluYW1pYyIpIG9uZXMuIEV2ZW4gaWYgb25seSB0byBtYWtl IHN1cmUgc28NCj4+Pj4+PiBtYW55IGR5bmFtaWMgb25lcyBhcmUgbGVmdC4NCj4+Pj4+IA0KPj4+ Pj4gVGhpcyBpcyBzaW1pbGFyIHRvIFhlbiBmb3JiaWRkaW5nIHRvIGNsb3NlIGEgc3RhdGljIHBv cnQ6IGl0IGlzIG5vdCB0aGUgaHlwZXJ2aXNvciBidXNpbmVzcyB0byBjaGVjayB0aGF0IHRoZXJl IGFyZSBlbm91Z2ggZXZlbnQgY2hhbm5lbCBwb3J0cyBmcmVlZCBmb3IgZHluYW1pYyBhbGxvY2F0 aW9uLg0KPj4+PiBPbiBvdGhlciBzaWRlIHdlIG5lZWQgdG8gYmUgY2F1dGlvdXMgbm90IHRvIGFk ZCB0b28gbXVjaCBjb21wbGV4aXR5IGluIHRoZSBjb2RlIGJ5IHRyeWluZyB0byBtYWtlIHRoaW5n cyBhbHdheXMgbWFnaWNhbGx5IHdvcmsuDQo+Pj4+IElmIHlvdSB3YW50IFhlbiB0byBiZSBhY2Nl c3NpYmxlIHRvIG5vbiBleHBlcnQgYnkgbWFnaWNhbGx5IHdvcmtpbmcgYWxsIHRoZSB0aW1lLCB0 aGVyZSB3b3VsZCBiZSBhIGxvdCBvZiB3b3JrIHRvIGRvLg0KPj4+IA0KPj4+IEl0IGlzIG5vdCBj bGVhciB0byBtZSB3aGV0aGVyIHlvdSBhcmUgcmVmZXJyaW5nIHRvIGEgZGV2ZWxvcHBlciBvciBh ZG1pbiBoZXJlLg0KPj4+IA0KPj4+IE9uIHRoZSBhZG1pbiBzaWRlLCB3ZSBuZWVkIHRvIG1ha2Ug c3VyZSB0aGV5IGhhdmUgYW4gZWFzeSB3YXkgdG8gY29uZmlndXJlIGV2ZW50IGNoYW5uZWxzLiBP bmUga25vYiBpcyBhbHdheXMgZ29pbmcgdG8gZWFzaWVyIHRoYW4gdHdvIGtub2JzLg0KPj4+IA0K Pj4+IE9uIHRoZSBkZXZlbG9wcGVyIHNpZGUsIHRoaXMgY291bGQgYmUgcmVzb2x2ZWQgYnkgYmV0 dGVyIGRvY3VtZW50YXRpb24gaW4gdGhlIGNvZGUvaW50ZXJmYWNlLg0KPj4+IA0KPj4+IENoZWVy cywNCj4+IFRvIGNvbmNsdWRlIHRoZSBkaXNjdXNzaW9uLCBJZiBldmVyeW9uZSBhZ3JlZSBJIHdp bGwgYWRkIHRoZSBiZWxvdyBwYXRjaCBvciBzaW1pbGFyIGluIHRoZSBuZXh0IHZlcnNpb24gdG8g cmVzdHJpY3QgdGhlDQo+PiBtYXggbnVtYmVyIG9mIGV2dGNobiBzdXBwb3J0ZWQgYXMgc3VnZ2Vz dGVkLg0KPiANCj4gSSBhbSBmaW5lIGlmIHRoZSBsaW1pdCBmb3IgZG9tVSBpcyBmaXhlZCBieSBY ZW4gZm9yIG5vdy4gSG93ZXZlciwgZm9yIGRvbTAsIDQwOTYgaXMgcG90ZW50aWFsbHkgdG9vIGxv dyBpZiB5b3UgaGF2ZSBtYW55IFBWIGRyaXZlcnMgKGVhY2ggYmFja2VuZCB3aWxsIG5lZWQgYSBm ZXcgZXZlbnQgY2hhbm5lbHMpLiBTbyBJIGRvbid0IHRoaW5rIHRoaXMgd2FudHMgdG8gYmUgZml4 ZWQgYnkgWGVuLg0KQWdyZWUuDQo+IA0KPiBJIGFtIG5vdCBlbnRpcmVseSBzdXJlIHdlIHdhbnQg dG8gbGltaXQgdGhlIG51bWJlciBvZiBldmVudCBjaGFubmVscyBmb3IgZG9tMC4gQnV0IGlmIHlv dSB3YW50IHRvLCB0aGVuIHRoaXMgd2lsbCBoYXZlIHRvIGJlIGRvbmUgdmlhIGEgY29tbWFuZCBs aW5lIG9wdGlvbiAob3IgZGV2aWNlLXRyZWUgcHJvcGVydHkpLg0KDQpXZSBuZWVkIHRvIHN1cHBv cnQgdGhlIHN0YXRpYyBldmVudCBjaGFubmVsIGZvciBkb20wIGFsc28sIGluIHRoYXQgY2FzZSwg d2UgbmVlZCB0byByZXN0cmljdCB0aGUgbWF4IG51bWJlciBvZiBldnRjaG4gZm9yIGRvbTAgdG8g bWl0aWdhdGUgdGhlIHNlY3VyaXR5IGlzc3VlLg0KSSBhbSBva2F5IHdpdGggaW50cm9kdWNpbmcg dGhlIG5ldyBjb21tYW5kIGxpbmUgb3B0aW9uICJtYXhfZXZlbnRfY2hhbm5lbHPigJ0gZm9yIGRv bTAgYW5kIHNldHRpbmcgdGhlIGRlZmF1bHQgdmFsdWUgdG8gNDA5Ni4NCg0KSWYgdGhlIGFkbWlu IHNldCB0aGUgdmFsdWUgZ3JlYXRlciB0aGFuIDQwOTYgKG9yIHdoYXQgd2UgYWdyZWVkIG9uKSBh bmQgc3RhdGljIGV2ZW50IGNoYW5uZWwgc3VwcG9ydCBpcyBlbmFibGVkIHdlIHdpbGwgcHJpbnQg dGhlIHdhcm5pbmcgdG8gdGhlIHVzZXIgcmVsYXRlZCB0byBmaWxsDQp0aGUgaG9sZSBpc3N1ZSBm b3IgRklGTyBBQkkuDQoNClJlZ2FyZHMsDQpSYWh1bA0KDQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:04:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:04:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372729.604640 (Exim 4.92) (envelope-from ) id 1oEVqO-0005zf-Bh; Thu, 21 Jul 2022 13:03:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372729.604640; Thu, 21 Jul 2022 13:03:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVqO-0005zY-8I; Thu, 21 Jul 2022 13:03:56 +0000 Received: by outflank-mailman (input) for mailman id 372729; Thu, 21 Jul 2022 13:03:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVqM-0005zR-0U for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:03:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8fd52f9c-08f5-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:03:50 +0200 (CEST) Received: from mail-dm6nam11lp2172.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jul 2022 09:03:43 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6433.namprd03.prod.outlook.com (2603:10b6:806:1ce::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 13:03:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 13:03:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8fd52f9c-08f5-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658408630; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LmwHlkhS/Q2Wrazq/C1lp3LBA9t5NC5TsjEQb79l8Bk=; b=HzrBk8lq7p0dwAbcYJmfTSo032s9FBVINFIrn0ptdF0ca8l88q5F1mpP vVhX75/IcIyCss51r1zkd9g4gECp27U8nVWhTgH9CN6uQy6c0Pox434PK SiOXgh5S5UasbLGLxRWuSV7gw4JVwuUocdALuODUatXxdEhZ1+pNPM+D4 U=; X-IronPort-RemoteIP: 104.47.57.172 X-IronPort-MID: 75612341 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:te0s1aiS9Ejt9fBXowIZdIO7X161UREKZh0ujC45NGQN5FlHY01je htvWz+DM/qCMDGjeIpzO4q/8hwD65fSxtFiHFQ5+C48Eykb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaAr414rZ8Ek15Kuo4WtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eI84J5L1qLjtyq 6IYcTAoYzvZ2OO3+efuIgVsrpxLwMjDGqo64ygl4RSHSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsF9xTM+vBfD2v7lWSd1JDENtbPd8PMbsJShkuC/ UrN/njjAwFcP9uaodaA2i3x2LaVxn+iMG4UPL6Kxq9Yu3CS/DwSARlNZX6Kk+mgsUHrDrqzL GRRoELCt5Ma5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LRQxz UOAld7tAT1psZWWRGib+7PSqim9UQAeJHUOYiIsRgIf797u5oo0i3ryos1LFae0ipj5HG/2y jXT9Swm3exM14gMyrmx+k3Bj3S0vJ/VQwUp5wLRGGW48gd+Y43jbIutgbTG0ct9wE+iZgHpl BA5dwK2sIji0bnlePSxfdgw IronPort-HdrOrdr: A9a23:vu/fKaF0SsChrDgGpLqFS5HXdLJyesId70hD6qkvc3Fom52j/f xGws5x6fatskdrZJkh8erwW5Vp2RvnhNNICPoqTM2ftW7dySeVxeBZnMHfKljbdxEWmdQtsp uIH5IeNDS0NykDsS+Y2nj2Lz9D+qjgzEnAv463oBlQpENRGthdBmxCe2Sm+zhNNW177O0CZf +hD6R8xwaISDAyVICWF3MFV+/Mq5ngj5T9eyMLABYh9U2nkS6owKSSKWnY4j4uFxd0hZsy+2 nMlAL0oo+5teug9xPa32jPq7xLhdrazMdZDsDksLlUFtyssHfqWG1SYczGgNkHmpDq1L/sqq iKn/4UBbUw15oWRBDynfKi4Xi47N9k0Q6e9bbRuwqenSW+fkN1NyMJv/MmTvOSgXBQw+1Uwe ZF2XmUuIFQCg6FlCPh58LQXxUvjUasp2E++NRjxkC3fLFuH4O5l7Zvin99AdMFBmb3+YonGO 5hAIXV4+tXa0qTazTcsnN0yNKhU3wvFlPeK3Jy8fC9wnxThjR03kEYzMsQkjMJ8488UYBN46 DBPr5znL9DQ8cKZeZ2BfsHQ8GwFmvRKCi8eF66MBDiDuUKKnjNo5n47PE84/yrYoUByN8olJ HIQDpjxBoPkoLVeLizNbFwg2DwqT+GLEXQI+lllutEk6y5Qqb3OiueT11rm9e8opwkc7/mZ8 o= X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="75612341" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EY2nri+7shTNKtllwTpB3WNKePPxmZYrhavp4h1bhZ/I4u+plxhvwMW8BcOaAh/t6/FnhOR3arDnCqGA1z5eWHuH+kUFDkYrwccy7AtHrvHUF9+FjHgnsxLDYujGxyrnlJjpRIMHOEKT0vIYe85i9j59sP9YvHJ+zVd3hIspKoqLpW353ZOzM8KFMcx4ih5Gg8+1Wpjb6sNepnMdlqqhREP3SaEatKSNKOBLy/lvemszAWmmhTf9m3av0FLiRbzhSJpHTknrMAu1NWEVOd2wDFNMK48IZVj+yfMwp4Uo/M/wIGgZDI9RJUNWL0ufv80+QbSWAfL4jLAiJBxRahuqPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LmwHlkhS/Q2Wrazq/C1lp3LBA9t5NC5TsjEQb79l8Bk=; b=b6N4iz3uIqr3ZOg9hf1psaQMW2+DLK7JGMGoVyMjRCnoH2rE5ihly2KZdpLkya9D4dgVBS2Yfw9PXEob4+ebw8x3mcQdz9cMTIr+9UBLvFcvL1HGwTBcJJkv7fH5qEyHk88gf5tKGmZpcF3C2XuhrmgGajf4qtoKfwmJEsuUaKPd7CFDh9zd4+bSArxewR69oM2l/j22vZhs6+8/q2aPCgQZ99Spc8sls9NB4MXFastQnKxLZTWlmBtwV5XWKcIApqGN3Dw0PN07z56vke7/9XmrBxbdxE6xPBC0EsEfjkClNsH2LNUKLm9xMO5DByz1UvWv6By5cfW0HHDIlXFNzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LmwHlkhS/Q2Wrazq/C1lp3LBA9t5NC5TsjEQb79l8Bk=; b=lBNoglBshbMq0VbSyp4GYklWS/4VNQGo9IG3/KuJ6/xs2CUqnYrrZt3cJjZ83yocZeh14nK5+V52hcVRVBJfLcJlDe+AdOdqwOq9SYrFxxCF5ViWLU6KO73lHV3uFrcviAkhRtgjpDdx+1d3bbSi2/C+n+ZmpkMZFawglYMhPDs= From: Andrew Cooper To: Anthony Perard , "xen-devel@lists.xenproject.org" CC: "wl@xen.org" , "sstabellini@kernel.org" , Doug Goldstein Subject: Re: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Thread-Topic: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Thread-Index: AQHYnP/ekdkOx/Oyl0y0AyUNUkwaXa2IypmA Date: Thu, 21 Jul 2022 13:03:41 +0000 Message-ID: References: <20220721124602.9910-1-anthony.perard@citrix.com> In-Reply-To: <20220721124602.9910-1-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 60ad677f-8c3b-4633-985b-08da6b196fd0 x-ms-traffictypediagnostic: SA1PR03MB6433:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BDdzvllgwh0M/zOl+X8uEjT9t97QzYc8Ttf5s2Pjv7eBg0z7vVbm7BEM7Sz+aa+Dm2/zcQg6QaZf1OAWkJ4d2wzL5C1xAqQeiUvDFO4JH42LGUwKoIPdpB/bGslMX0UYrJtP7tFbYgoQV34BpsqniwiDACZtIrgrnFkqNJ/r8RZZS140JI58YXCFPSeJZFAm4pzwLVqSM8hsmbsjqfl4TErI7ixaVp7iiKvTLjMk6lSdipzuEGAsbORV7VJGZp2to+FduIl4uSI2m35AJedk+1SbIvKCr6mXE5svr7xvmI7Wp3ZnyMwbN1Ksj6fXhRkRyAszMqfFVSgQn3b7WssvvisA1bZdWQ2qT7zDgKQPon0euErOqXvE8VcRNbDHqTe7/I8ApExxY+Tk2wfxbcqS01XC+gSMtVW3hYfX1Avcc3KDX4O4R71Urm4n79xPe+dXcsTmh5Xk3FI/HdwBbvD1VDPxCg3Op2Rup+ZJGpgYz1ZHELUSMrlcirtz37FW/6Y7mCPYv4Hl6v6Gc4P+D+YzOU6hV+uB+htGA76kPjp5f+1yp67o5dY0DF8jNl0qBvTvvDRDxqeSKIFoVpOFyGJpNgjGTSxKFomRZotgkGy5AqsnZDCx5FFs0BMKNzWpH3bR+vpHDPB/3FTyEIQ7G1c9gePv+AulXtt+oj0QPIkBNBXuau+cbf0+ZM2dASEc6LtPjd4h21WxBrIs9taNmfd/tv8mDsWSZ+3RINN7Syg11Iym/05HbJPdTGWL+kQhcdla6TkdLtuUXfjt6k27wwNbFT1NdQoGWbHRnufEHluJ813THr6LUzbOR0D+YJnYPnsFNdJy2nyWriU00DEX5gn3o+nOv5tI4s2KGUM6OwLl+w/85asqs3n5xdtDS5CVzozk9JWUCWUod/Jj9rB4LXD6Xg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(38070700005)(31696002)(86362001)(38100700002)(82960400001)(91956017)(66476007)(64756008)(8676002)(122000001)(66556008)(66946007)(316002)(4326008)(66446008)(54906003)(36756003)(76116006)(8936002)(6512007)(4744005)(6506007)(26005)(53546011)(5660300002)(2906002)(110136005)(186003)(2616005)(41300700001)(31686004)(478600001)(6486002)(966005)(71200400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZHhZbXF0RlMzN2pIMXY4VHZ0Qm1qODdmZzd0UUxLSStqQ3lXcTAvWlVPQ25K?= =?utf-8?B?QVVRRVQxUGFWaWJTZU9CelZPVEVxNkJ1QjFoZ2huUGlMd2tFNWo1TENTWTdu?= =?utf-8?B?b3M3ZTFpNVI2ZUxxNi9PMGdpaGRpWm1yWmVFSzB6dUxybnRVK3dsMzJuckVY?= =?utf-8?B?bE1ueU05bDdoclF0WkdrRkRoejhOakVHdTE0QUhmNFpvMDgwWUZobUhiWGwz?= =?utf-8?B?Z0VnLzcxUzVjUnlkNlJPQW9oVnMzMU42NlpKWW5TK0hxSDhoVklQOFRqM2Jq?= =?utf-8?B?Z3Z5dEQzbk95V2tyZzBYTmZsV05FN1ZEREN6aS80RlNtY09BUEtnUjBETk5R?= =?utf-8?B?dGtYS1V1WHpLbGlLRjVLM3V2d05XVEUwZlA0NGZUNkU4SWlHMlgybmNPdHFw?= =?utf-8?B?YngyQ2lXdDRyMVlKa09KMHdZekVrcENsZmtDRWdkbi9mUXlBWDlrMVpZVUtV?= =?utf-8?B?ckJYRUxRcXlpQ2Q3azExUXYvTTY4ckRxK0dKaUZqa2FnSVRtSmZmVHBmM3Y5?= =?utf-8?B?cFg3Y2czdENXOXZvbGtGam9hdVAzdnJYTFl1MnNoZkVicTNvcjZxQklEUjVv?= =?utf-8?B?UUtzVE1LYTNDQ2dUaHBmYko0c2VIMHQ2U2pld25aR1VSVlh2M1grbldHeVVp?= =?utf-8?B?M1ppNVlFQVAyL3V3NFVUQTlPb1I0T2hyU3F5ZWVuaDhPR1NCNDdKNVd1M2Y4?= =?utf-8?B?dEtHQWMvR1dUVThBSXRnY1VKcDBJUWlUbTVJRlcrM2xDV2JhMzJqbWZhZ0M0?= =?utf-8?B?T2NtYVFXNjBVK1NnOWtLZkFYaTNKQm5EYXd6UUNiMzY0aVZyZ0tuVDVwaXAx?= =?utf-8?B?dWJBY3RoYnhOb0xHRTlRcHE5d1YzSkdQSWZZY1hjTE5kemp6NUErUTc0ZWRL?= =?utf-8?B?QS9SMUU3QUQzbzJ3NlZIMWUvc00vaFBpVUM1WXZzbzJiTjhodG45dnJHcDdT?= =?utf-8?B?eGZmY0JVaHUvZ20vbnJsazRpVFpmcmE2RlhGc0pad1VFcmdsU2M4QTlnUXRu?= =?utf-8?B?emtXRzk3QlkxcEhzaTRjeWpvVm1NN21ZOFpmSUU2UDE5RFR6ZnlCdFNCcEs5?= =?utf-8?B?N1loamRaVlBKVkZpSFZyandmUmFySHd3M25uSGpncGJkS2VnWG5MaEFKdkJN?= =?utf-8?B?aGNhMEthcWk1R0k1bUxSQng2SVdNU0x6Z2d1T1ZGcWplZlZNd21EeDRFZXRa?= =?utf-8?B?bU93Sk91TjFndG5saVF3TGdKZTNMbWN0QW9POGhvL0txUHIrL3hzczJ1Rk51?= =?utf-8?B?cmthTG9CMm54bDcwYkhuVk9qNVNkdGtTSG5SQ3AvbVBoaGdUUnZ0TGg5bFJi?= =?utf-8?B?WUNIMW5ySDBpcTl2ZmFoWWFEYjFRb3VtdlA5YXZtUGFEZVZlM2h1czZVNXNk?= =?utf-8?B?VGkyUTBNd045SlBRdG11Q1ZjTitaWlVaYW1JS2MxVHYvbnpVNjhvNmlEaG1q?= =?utf-8?B?NFozRzhDRVZ2dEdRUWFVaHY1SU5IS3N1TG5LWFducTVzanpBUmViekI4alI1?= =?utf-8?B?Q0pCYnl3dzlaY1VRRGdVNzc2NFhjb1RQTit6cC9lL0hSY3FhRXc2eUhwQjdt?= =?utf-8?B?SWRIVkdVUUVIZ3R4bGF4akNQWFFFeVA1MDlsc0pIWWNicUpUQisyU3E2MWww?= =?utf-8?B?eXE4bUZiTlBSU2NqVzFBM3lzeGRINnBPOGVDL3pCUXhEeERFMXhBQ01Va1Mv?= =?utf-8?B?eWJzTzRVeTJLb3Q5QXZCQlkzaFQxcDB2VTFJL0ttQkN0QXJldmtpWXlmTWZN?= =?utf-8?B?RnNvZXI5Mk5oMkg4RGw2TVVtSGFTZTBDbnZ2QVRjZUJtRWFJelZQaE9uVlVN?= =?utf-8?B?bHFOaXE1R1ZiWmdtL3g1bDlHck81ajBob1I0TmJuZlZjckFJZ2xrYTdGUlhB?= =?utf-8?B?bEZrZkNXQ3RyNjFSTlFkNmxHVGREeE5paUdSbmpaelNuNjh1SXc1RnBuOXZN?= =?utf-8?B?ZkY3ZmgyajV2STh5eDdmaU9oZ3d3aWovMmZxaTNGNlNmaDdBL0lhaVlUMmda?= =?utf-8?B?cktNemRsTnJ1ckg1UkJhK0cvbkgrYk92UlZoaHpWUW90UFR6N1lacHVUc05j?= =?utf-8?B?M2lPNUE2T3R2Ykt0UEc2RlBzUjJzZzBDMktIODZYRkM5SVcwSXZNT1hVMVJj?= =?utf-8?Q?oorbSR06DwwAlBCxpoNt5JpUL?= Content-Type: text/plain; charset="utf-8" Content-ID: <232A1CBA32CB9E4E8EE865056FA61B9B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60ad677f-8c3b-4633-985b-08da6b196fd0 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:03:42.0017 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0yRb8/nBG8T5ZqHvb+BXlNHqwrngpapxDdNdDZ8VJ/Rh9RqZSPHqkj2EMaAfOnX5CZ0AptuMDRXTABLGNar3/b2Im7xy6iNZ/K1PUMqpY6s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6433 T24gMjEvMDcvMjAyMiAxMzo0NSwgQW50aG9ueSBQZXJhcmQgd3JvdGU6DQo+IFBhdGNoIHNlcmll cyBhdmFpbGFibGUgaW4gdGhpcyBnaXQgYnJhbmNoOg0KPiBodHRwczovL3hlbmJpdHMueGVuLm9y Zy9naXQtaHR0cC9wZW9wbGUvYXBlcmFyZC94ZW4tdW5zdGFibGUuZ2l0IGJyLmdpdGxhYi1jaS1p bXByb3ZlbWVudC12Mg0KPg0KPiB2MjoNCj4gLSByZWJhc2VkDQo+DQo+IEFsbG93IGJ1aWxkIGFu ZCB0ZXN0IGpvYnMgdG8gcnVuIGNvbmN1cmVudGx5Lg0KPg0KPiBBdm9pZCBydW5uaW5nICJ0ZXN0 IGFydGlmYWN0IiBqb2JzIG9uIGJyYW5jaCAibWFzdGVyIiBhbmQgb3RoZXIsIHdoZW4gdGVzdCBq b2JzDQo+IGFyZW4ndCBydW5uZWQuDQo+DQo+IEFudGhvbnkgUEVSQVJEICg0KToNCj4gICBhdXRv bWF0aW9uOiBmaXggdHlwbyBpbiAuZ2NjLXRtcGwNCj4gICBhdXRvbWF0aW9uOiBhZGQgYSB0ZW1w bGF0ZXMgZm9yIHRlc3Qgam9icw0KPiAgIGF1dG9tYXRpb246IG9ubHkgcnVuIHRlc3QgYXJ0aWZh Y3Qgam9icyB3aGVuIG5lZWRlZA0KPiAgIGF1dG9tYXRpb246IHVzZSAibmVlZHMiIGluc3RlYWQg b2YgImRlcGVuZGVuY2llcyIgZm9yIHRlc3Qgam9icw0KDQpMR1RNLsKgIEdvdCBhIENJIHJ1biBv ZiB0aGVzZT8NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:09:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:09:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372738.604653 (Exim 4.92) (envelope-from ) id 1oEVvl-00070r-3D; Thu, 21 Jul 2022 13:09:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372738.604653; Thu, 21 Jul 2022 13:09:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVvl-00070k-0a; Thu, 21 Jul 2022 13:09:29 +0000 Received: by outflank-mailman (input) for mailman id 372738; Thu, 21 Jul 2022 13:09:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEVvj-00070e-SC for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:09:27 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57f8658d-08f6-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:09:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57f8658d-08f6-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658408966; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=oXq6zd/w4sGh12m3GGzjD+D2JLu8gxVMm/AoFlWNGf4=; b=PkltjImXZL+642yt4q8gK3OU79CWHDQkGAsqk7h/f41zs0evVz7N+0fz nVDovqfGVog3x5o9mEsAGDgndjgwj5D2jdBT8iiwEBjyMrSPO9OuFt+eZ kfag7ZbbPhJiehf6IkyrQk4DlpcW2VH/TVLTehynJh+HBkjskvcHtpZiT Y=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76320119 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AVV2qsaC15xs2QxVWkefolJIiHB/EJm4KOzbN4?= =?us-ascii?q?r1jHsv3zxNZIRWMlPgJTUqlPK6odUonXKPw3BDec0aghIdagL1VTmEpcvcGM?= =?us-ascii?q?j6/TpzQ4+x2/W5DM9dqxtC276BFUzAnYK3M/naWupi34Ayk4AGhNaaY8O8O6?= =?us-ascii?q?s3b0vJO4Jw+oQgR91xanjE3FQnpKVGxwszmzgXFyt2sR0oTgdqs0GRKNYaAl?= =?us-ascii?q?1jTY1Bo5ooOzBZaIIX/iakPw3C1FeluhquW3wlHOvJK3kwO7cBmSPXimZhsV?= =?us-ascii?q?yFka4+yEVn1+HvGI/6Obr0e+6fn+0/seAfFQC5fHIbICtdWETkNnlqkzvZFz?= =?us-ascii?q?fQbwWVg+/hkLAB29KMN4tBnMKrY3ZkQLnyCVe5fYeD5pO5HVIzMvcjMxVans?= =?us-ascii?q?LAOt7UxDk4rxdNCGFw6qVKHGK9m2ThNk/uuYiDD03/QAsUeUQxwdMpRJNmDv?= =?us-ascii?q?oYYHLKJnu5eLbSebvkp7Noz1WI73Ridmh8gL91TRWfohFBwOis67KXm7Iesp?= =?us-ascii?q?hBbOLx+zQc/UCJnzd/2jFx5OcO5WJjdW4QDxPsrrIfcFENI4rDCwcP9ZAKKw?= =?us-ascii?q?uYLmBnFodFY3QueP1vuM671KQhW/1z8XIcUAYH+1Q5nFYs692pRuvuhPCpDL?= =?us-ascii?q?o4KARdP9V/CE0diWbhuq6wWH6nR2ZL+ideYWRTpRtnCLZn+lukdOp+fFhoWq?= =?us-ascii?q?ontUGwlT6I0gNip4blDd4FJCUNyx6w/G65zgGre8DqT1bSffNsfFof0WQWgy?= =?us-ascii?q?eL59WruuxQc+fVAqtClhWHCyav1QByv2xoZGnN3u4bLXrZn0vQP/CQDx+9YD?= =?us-ascii?q?QVbv6emXDkX/Vgn8EVEH9aJJ5dIBOWN4Td2MXShMsnSVGByuzwuaZu9f850p?= =?us-ascii?q?FlMnM9zKh+Fdanm74lCcVO1s6P9tdT2Kw63bTRcgMxCEk4ILhDB9gNOZi0K0?= =?us-ascii?q?V9nG232+4THSqv8ekR1PjqNscJghdnLf6GWE4gPOCemH9HyFdY4/gwU4R+56?= =?us-ascii?q?8GC2AKYF6vwhhs856K9QuCByuxx6ZKNAIlNBQd9+7qvE6ZYoUCT0SzwyzNBB?= =?us-ascii?q?nKCNEmIUXDYAoH3bzlwf70hTfc2LdkGELEAehPHhzYPJKLfZBv20ZuQv1ZjS?= =?us-ascii?q?HDM8Ve1vY7it287RBE+S9LWZrUzxxuGbFkSag51IIVbOAhCkj8mGdcRp69F4?= =?us-ascii?q?o3zWHsXIKgW7joIUEz2lwm2pkBRYRDK4bkKe1gYkklfF+ITtin0JdUUrOoDO?= =?us-ascii?q?k1NUoul9J4804UbKJw6vpu4TUSyl3yBfj2Oe5AmwqpDgTb2A0eeeWGLmY+1U?= =?us-ascii?q?dGSp2SbRzocAVf49AQO2TvEVlFJW64nqBdkh8Otnikr3pbmeQBu+Njg8izXG?= =?us-ascii?q?VJlhjk1mk+xiN61CydyW6qbnY7wji2xwhvw8Ms0W+TuMqrBuCkCL/MkR7aEe?= =?us-ascii?q?ixCmtQDZtyGKnL3G3AH8C3S1FDonCADR6xoLlTIy4ADkPs8XikWvikf2Gz8n?= =?us-ascii?q?9Hsq58G8T9qb4hqMFVMPPPMLG9rWPAspw42KiJTQIgVFS48zNRGtGTUx9FHf?= =?us-ascii?q?4QGO3/wyFoWs3UVtXJunK+L01aIbg5uSevPRA29GwNFIVVhf2T2M4LIOH8Hw?= =?us-ascii?q?BBr8AvJeQWW/4RGF0Lw/yNipZahfO4f5as7nzu8O86kU9fMZxrU1HhUCk1YV?= =?us-ascii?q?mJeKHcqHSohPokjwz2UHCf+jsJ5vUMjOWxKOpqp9bI61qIjSMXK/RXzkcNrE?= =?us-ascii?q?zoQC8DrdY0VuP7YgAXOg7Yp62o0nNHQTB5LvPs46wNd3N6pRy0ZM1CHpVJPy?= =?us-ascii?q?h+fBwrMPP4gxV9tw5XVk3i46n1yGHvvGBmYBUf1aQX+OMKvOA35hSwtlLICR?= =?us-ascii?q?nM+Yk340SSiDdt8ix7sh2SRkRphmrEXU7JNAd8fURIUX0iD1Mler2OZnz2c4?= =?us-ascii?q?nSCqeZRxx8t+DZsONW9kTJ2RgA7mFjvqdPoBJOrgsltwOdQ4H6VlYT2CGOKx?= =?us-ascii?q?cLdDiT6KOnfBFhgLyEVF11zbHnp5ug5RVJIpFjt/WwO6uYW4ftfJIRSp/fVL?= =?us-ascii?q?Z7ysDmN5QMG5VooSlTiepTAS0KFY0s6cjDpVR2Z8xFJ1JLIlsLSys4M0Pmhm?= =?us-ascii?q?JOVdjHmygxdAMe1nJNRu6blB8emzZ9vKcxZkkIYGg1WxD1ZtqgowoPimsU0c?= =?us-ascii?q?YGKIUjc4Jzv2yWigTe9l0dB0fnGF3Inj7z6uGtncL4rzO1jf/X82rVLjupvi?= =?us-ascii?q?lbObIo9B7daAbKzp5lSiz6IIiJJrgbxtpfWHk/Rm5pxGDmcfbm5ZW+EJB09V?= =?us-ascii?q?i2O9msP7RoH+XQeY4fAsVBYrwqZkl/01DjSeTtsLPeJNxlUiwzbATyW+3k3c?= =?us-ascii?q?8jvsR8Iub2tN0M9O5uUxktkh1ye0c0tQczd9t9yjLDupI3nbj1SN0e9q1ZDC?= =?us-ascii?q?G5WjMB7bTq55cKWEVeZirFTm5hpkkbtoEdgm5kiqxfc/UtWQNKGNWoFBbn6A?= =?us-ascii?q?qfTdhly4LkpOrU65eaog9fNJe+DXr5KJkhg2rdrhB1SRTziMwmNEvtz1jkgN?= =?us-ascii?q?o5r5/bPThgYSOnwj+QIrSIOOqfCq81F8kJFUB+RHI3g0P9JlrTE18iqj+To+?= =?us-ascii?q?ko8hnrafXw0K25CUUB2INWNJsmTM3FBFdtXziEKqBfEZokO5ahLCYhXV239R?= =?us-ascii?q?XpSY4MC0PdkXSEmWw4ydKCZR4C/0l2ZDmDkKOGvHdBGhlFRlPKOds+3eis8A?= =?us-ascii?q?aNlUsIW9csj1sR6UF8gEbgFJZ4gSVEqV3eOO7gAk0AwGiWnPeGml13R1DcFI?= =?us-ascii?q?jGfUBtldN60NQdrjhUN5x+X3sSghh29d64k00XpMK1XNb8D+Kl+KPJXXgDKm?= =?us-ascii?q?7i+I1LnV/p8W5Fzzg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76320119" Date: Thu, 21 Jul 2022 14:09:20 +0100 From: Anthony PERARD To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , "wl@xen.org" , "sstabellini@kernel.org" , Doug Goldstein Subject: Re: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Message-ID: References: <20220721124602.9910-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Jul 21, 2022 at 01:03:41PM +0000, Andrew Cooper wrote: > On 21/07/2022 13:45, Anthony Perard wrote: > > Patch series available in this git branch: > > https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2 > > > > v2: > > - rebased > > > > Allow build and test jobs to run concurently. > > > > Avoid running "test artifact" jobs on branch "master" and other, when test jobs > > aren't runned. > > > > Anthony PERARD (4): > > automation: fix typo in .gcc-tmpl > > automation: add a templates for test jobs > > automation: only run test artifact jobs when needed > > automation: use "needs" instead of "dependencies" for test jobs > > LGTM. Got a CI run of these? Yes, patchew's commit is in progress: https://gitlab.com/xen-project/patchew/xen/-/pipelines/593479157 A run in my private repo: https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/593340820 (no failure due to this change) Running on one of my branch called "stable-wip" doesn't create any pipeline, as expected. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:14:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:14:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372745.604668 (Exim 4.92) (envelope-from ) id 1oEW0x-0008R2-PH; Thu, 21 Jul 2022 13:14:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372745.604668; Thu, 21 Jul 2022 13:14:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW0x-0008Qv-M1; Thu, 21 Jul 2022 13:14:51 +0000 Received: by outflank-mailman (input) for mailman id 372745; Thu, 21 Jul 2022 13:14:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW0w-0008Qp-J8 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:14:50 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 17e2aab4-08f7-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:14:48 +0200 (CEST) Received: from mail-dm3nam02lp2043.outbound.protection.outlook.com (HELO NAM02-DM3-obe.outbound.protection.outlook.com) ([104.47.56.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jul 2022 09:14:43 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5643.namprd03.prod.outlook.com (2603:10b6:806:bf::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 13:14:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 13:14:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 17e2aab4-08f7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658409288; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=uaLlxGElwCUILzeJNH5B/gg0vok9yn+3/ew19wtHBQg=; b=Vj8vllWC4D+XB+ZY28CgT6rcGnrJcP56ae0kpR44+YtMrygqzLmRkUer AMDsDy6z0Qi9dJCZTqtNVs48j48nDz4JeGGlKqQadH/x5TtmS6PDJrTYF e1JIW5LBg8Z3/rg/1AmBsEzn2x03ubA19ojYqexPsJhmIB3HHYf4Nukf1 I=; X-IronPort-RemoteIP: 104.47.56.43 X-IronPort-MID: 76128603 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:LLrWyq0gCoyJl3LwSPbD5eVwkn2cJEfYwER7XKvMYLTBsI5bpzcPy 2NKXGyOO/vbYTfweNtyaIjk/BsHuZbcytNlSgBlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQXNNwJcaDpOsfrc8ko35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj6+xkVlwYBoMCwb1+J3BE/ 8M8EQoKdx/W0opawJrjIgVtruIKCZGxea864TRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ye5L2YwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPBkGDVrCr37gPJtXPxR91POYHkzNdJoVmcwzURBTE8FlTu9JFVjWb7AbqzM Xc86ico6KQ/6kGvZt38RAGj5m6JuAYGXNhdGPF87xuCooLL5y6JC25CSSROAPQ9r9M/TzEu0 l6PnvvqCCZpvbnTTmiSnp+fpCm+PiU9JmYYaSgJCwAC5rHeTJobixvOSpNvFfWzh9itQzXom WjW9245mqkZitMN2+Oj51fbjjmwp5/PCAko+gHQWWHj5QR8DGK4W7GVBZHgxa4oBO6kopOp5 hDoR+D2ADgyMKyw IronPort-HdrOrdr: A9a23:63KNWKAtoH791l/lHegPsceALOsnbusQ8zAXPh9KJCC9I/bzqy nxpp8mPEfP+U0ssHFJo6HiBEEZKUmsuKKdkrNhR4tKOzOW9FdATbsSp7cKpgeNJ8SQzJ876U 4NSclD4ZjLfCBHZKXBkUaF+rQbsb+6GcmT7I+woUuFDzsaEp2IhD0JaDpzZ3cGIDWucqBJca Z0iPAmmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlml9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4gow3TX+0WVjbZaKvi/VQMO0aWSAZER4Z 7xSiIbToZOArXqDyeISFXWqlDdOX0VmgLfIBej8AfeSIrCNXwH4oN69PxkmlGy0TtegPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59bs5Vza/poVFZql/1owGpFVJMbWC7q4oEuF+ djSMna+fZNaFufK3TUpHNmztCgVmk6Wk7ueDlIhuWFlzxN2HxpxUoRw8IS2n8G6ZImUpFBo+ DJKL5hmr1CRtIfKah9GOACS82qDXGle2OFDEuCZVD8UK0XMXPErJD6pL0z+eGxYZQNiIA/nZ zQOWkowVLau3iefPFm8Kc7giwlGl/NLAgF4vsulKRRq/n7WKfhNzGFRRQnj9agys9vcPHmZw == X-IronPort-AV: E=Sophos;i="5.92,289,1650945600"; d="scan'208";a="76128603" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0bEvnLhBge4w6MmDcQck2QJ1KxBU7SSpFH1HavFwgYXBt0UUL8tnqJHXmcrOcBOyKG6x4G6/k+dKAH+JFUv2h2MR5xSm7c1RmtdRJ+x+bcQoQwYqc9o9fgydpoBuwdmDIbFRBlqVMalLPI3X6aO5CEpV416L5+v16ktmyqXuRynFGK0vGD4pMJfTIcKGEgE1j1waRwRXgZ7jnnsDL8+d52zT3g1FQWCI16/mHvC5mf0esvNXLlc1gfLZiXM973ntfJTef0Cxptr6Y7hVYKtajsMm7HlQDl0OHdBt4C5kF8Ia1q4KvUnjbvT77QlW8HRIjg90KJpgIWnc6S9xiQN1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uaLlxGElwCUILzeJNH5B/gg0vok9yn+3/ew19wtHBQg=; b=IB1/3Ii8iwwxWLYzVuELcojNNGDQrRstqb7hpPj9BG/Bd3LRuKkaGStf0V4G5xb1JNFxHArJlb0wnejfTKuF2Swh/beP+RHwT80OOCOJTDLUKSMWsndG1upvV/97jV1iOrX21kNn46bwXd89ld6ZDDyPZmDftZvBLq5aQkOC/QbFRjvqwLaHRpf3DgI4zMwTpwKacb9He+P4fqf92JL/MTY25NHwCwDgP03ZfNvk5+dNw90wzRvhYSQQKtgYPnHSCB0tGGdYnEtv8OLzIevVbIE4yvyAUxQm2lCL3fo1U7QXdJa7WrjOE53cPr+c1ZF0JE5pUso3q1YH3TBeoq8HVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uaLlxGElwCUILzeJNH5B/gg0vok9yn+3/ew19wtHBQg=; b=XX0RntGxYcZYMdfP0Sp8+CZvyewyXymTzqv0fcdtx/xowszmsR2VF2eGmm2B57qFtLprO4o95iSOn1RDzjEZFhtZLcpRSJjLDvcJqq5qLrJg9jgM3TpS3tFSNu54JnVCa1T8PaDg1c/cozgbndUYyP8vJ+X6kOtiCTI8zZTTG0c= From: Andrew Cooper To: Anthony Perard CC: "xen-devel@lists.xenproject.org" , "wl@xen.org" , "sstabellini@kernel.org" , Doug Goldstein Subject: Re: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Thread-Topic: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Thread-Index: AQHYnP/ekdkOx/Oyl0y0AyUNUkwaXa2IypmAgAABlACAAAF/gA== Date: Thu, 21 Jul 2022 13:14:41 +0000 Message-ID: <2bba32aa-6ff5-f1f2-87c6-682c65dcf84e@citrix.com> References: <20220721124602.9910-1-anthony.perard@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37497402-7d29-46d0-972c-08da6b1af8f6 x-ms-traffictypediagnostic: SA0PR03MB5643:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qd+GocMMLVmLytCHwIzNXVvOdSmWK8W2UInUnyLdHDI4ZRVuoMOAIqH5b4xJRUfYDO7CzFHHaSJT0r4FBi4JMazV69X3zETQMgFUNIfNnRID+S1/BIxuOsNkofmwfBZCoFduAHS+MQB64p+J74+scnWx8XaE60GUKfMrkUbSpNptyeO3Z5MN9WhU754kVRpR71teggfYNHIsrmsFuZU+QMLDJpiwIZQqfgPqWWKt8/ye5FHCpHaLyqygFyOKd6gkJpy7QMBZTOJLSVazc99WpI6FfetuA++ZMtVWy1kF8aDcxMWJbCRw2z6nnK3s8H9d77ptpcnavIvX2KrTkmaPvuWXdL61u8OhHN5PIq/lcFyLtWYW+QDFwKZuKWTGS7YvpH/EU4dHmZ6lfvlGlBSDD1xdwGL4XoMS0RM6st1BYd4WYREOgdm+igCcW3UJCtefinqQkkKuTSsov5SNYNdIWqJfo2Y0edHfv68J6x1pxilEidRLTS6pBUlX486myq4RSSCDxBO30dDlqI8gp3HDw0pQPrWZLR+NXIDAL4WK/exENhr7Bj4H23CuAjT4dsntxt+8+GXrKOJs9kFWo0jDrgDSncxduCDT02Nvij9evwMLqEzoKQxE2UpBZCYkdaLl3JX5mZfI10NE5M8hxDiq3P30ziLf/jgyB5l48J+a38QRcReK0+JhvYQ451hmIY18xH0UoJzIyHb3FtiIJfOM0MEFIRaLZ2JgSDQaVxJkeiHXdqS72SgD3kFbimCLZph/EV6tVR4+EGHturY6j1beGxQiH7uLyGMYgNHnEeeBw8B+oiBZktVVnvi+mSGBsptpbURUvRhoeIfuiUiffl04FErU3eOcoPzqRcJo/cZyZbI8oePcGsIMmux7Gj1B1nqbEqNy4r3S8w4g/lVocx9EX0AB/hAbYr0Xe0EiTADX9hDtWeCAKI7RSTLmPzDLTekP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(396003)(346002)(39860400002)(366004)(66946007)(54906003)(966005)(478600001)(76116006)(37006003)(6636002)(8676002)(6486002)(41300700001)(122000001)(316002)(8936002)(71200400001)(66556008)(36756003)(66446008)(66476007)(5660300002)(91956017)(31686004)(6862004)(6506007)(4326008)(2616005)(6512007)(186003)(31696002)(26005)(2906002)(53546011)(64756008)(38070700005)(82960400001)(83380400001)(86362001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?T1ptWDR3Z3NIa2tZVlBkMVhwM0hkM1VsR2ovNVk5bGxyRGlwbmg0aHBORG90?= =?utf-8?B?bGdYNDhKc0JlTW94ZzdCMXp3RHlGNTdaQUdJVGJrb1ZtNzc0ZWphQlY1N25Z?= =?utf-8?B?MlVUSFR5K0ZySnB6UFB1Qkk2ei90VDMrVGdwWlJTOFk4bUlnaTVmQ283VFMw?= =?utf-8?B?MnAwRzhwTTlqSXBrMkVwem1ocmN5aU9mSW41Q0w1Yk5sTXZFNElTSHJDYjU5?= =?utf-8?B?Z1V3RFY2VWptcGMwUkZDd1ZhdzBBU1h1cXlta0VGdVl0cW5DaG9GNlgxd1A5?= =?utf-8?B?SVljOGhaamZPNXA5cTBUcXFUa1l0UTZlMFNFeDhsQWEwaDRkR0Q0UGFHRW94?= =?utf-8?B?QkNFN3JVSlVZYzBZR0FLWS9qS3J2U3BwZlZPNnlrcjl1U0FxVXl6dk11eGRH?= =?utf-8?B?RkE2T0g4by8vcEVzNGpaTjJvblBNTHpFNmFVNVllMVVpajV6L1dTQWFIWmts?= =?utf-8?B?ZVdoeG8rS1B0QjYwYmZSMk9GMlFRbHhMbjNjNXpOeHZHcmowYTRWMmF1aUNR?= =?utf-8?B?d3YyS0xtaXdQZjJBd0E0clN6ZWF6Mk9hODBnWGR3TDVaUk1zMjllc0dJalhu?= =?utf-8?B?NUFyQnlmRnoxMkJFKytGbEZYejRwUnVUSmVTY0RaV3Bxb3AvZExVd3ZTMFlY?= =?utf-8?B?ODZ1bVVjQjY1WUtKakFPMGNIMVVKQmU4MUxGVUt0UWhwbms5ZkpxU3RXMU5B?= =?utf-8?B?NHlnR0NuOUpZUFVSTWtVQ0kxaDZVQUVTZnNDY01CSzFLVG96dHZ5cUM0ZUJy?= =?utf-8?B?ZkE3UkY0dnhWL2F4UVg3bU9EczVRNzJLN1JNcnh6V0ZKQlNyeExFN3ZkSGRM?= =?utf-8?B?MVJsT1RRemY2SEdXbWI4Rmd6UnFOTkE4MGU2UUhmbkNoVFd6OWgwNEUyTzA4?= =?utf-8?B?VG85YXdXUVBWZE1DYVc4MTJFT2RsOEwrK3EwRHNwQkF0VmFndmxPc0xXdDlx?= =?utf-8?B?SW5HNklscjd0N1pxVHRReVhnZlFWUmRXSGRoOCs2Qk5SV3lkOVlncnREMlhs?= =?utf-8?B?T2JOM3FjY1lKb3pFVW1SM3pYQm9mKy9sSk12YzVFeGlXbk11eW5IVEhyajkx?= =?utf-8?B?cy9BNytHOUx1SC9JZFB3V0hkUEJySkErTFNJYXg4MGFxWk96TFl6Mlk2R3I4?= =?utf-8?B?Mlkya0d4UGpPeml1UEJSKzhaSEtaWFdHOU5lMXhyU256aTFQTUY1ZUlubHg2?= =?utf-8?B?ekhZZnpNYnpTMmVGbFpEdStNT1Q1N2Y3K1A3VGJxS0tiZm5MZmV1UjBYQzhn?= =?utf-8?B?RG44Z0dPTWYrVE1weHNrUGdJZ0VVc3lSK2piMDg5V1JkdDIvSGEva3NzcTlk?= =?utf-8?B?QkRMYjRnRUJIOWpqUGY3ZGFNU1MwK0lTNlZDQjlsVUU5K0J0MnpTeWtjd2hV?= =?utf-8?B?VmZScGtKOWtDT05Takdsb0hML0xldDl4Q0pldENoK004OGpLY2ExRDMrYVd4?= =?utf-8?B?NEhGTnliWUUrS09lQ2JnK1R5T0E4bGwyUEcyL05yMnAzWDhPanZ3b1E0NTEw?= =?utf-8?B?Slh4dllNZGRWTENQRnNnWUlYSDdpK2dhbXlZbGpMUTNHSWQ0RldnMnU5Qnd4?= =?utf-8?B?c0QxVVRLWmJSaWdGc3g0Ky9mS2pHRHVPY0dvZFZCekQ3Y1BsSXlVYWNuZ0tP?= =?utf-8?B?UlZzR1pSeHhQaXkvaDdXL21Iak5hZVBUd1ZHMWprdTQxSGFFaHRXWHhCbG9V?= =?utf-8?B?UXhpV0pPUk4xeFRLc0tUNndvWnJEM1JRR0s2eXQxdkF5ZllUanpnNXd1SzZQ?= =?utf-8?B?L2dEYko0SDc5OWRqQmhlc1FuelFHUGZlaWFMUmFhdTR4amxaMTdldy96UWxR?= =?utf-8?B?Mm84VWVaSEJLVUdTcTZoK0ZqN0lUWmdEQ25uSTZnL3pRMmY0Qzc3ZkpUSHkz?= =?utf-8?B?TllDcWJTT3NJbzg3SmtQMjBNdHU5bHA4NXpZTDlXWDZJdlNZc1hqYUY5L3Y2?= =?utf-8?B?NmFOb0x3TW11VE9rU1NVL0pvL0x3TnRKNnJpcTBsSld6SDRRVU5HR1pYem4r?= =?utf-8?B?SU13czE5NFIzUExXWWJzOEEzYTV1YWt3SGNramJGZCtlQzBRZUJzcmp1aG5p?= =?utf-8?B?ZkpOYTEwV1p1YXF0cnpTVGViWE9FK1NHQkloanQwZ1ZSS1RyY3lXSWlRSjFU?= =?utf-8?Q?9FneXXFPPUSZRwk640iPhl+of?= Content-Type: text/plain; charset="utf-8" Content-ID: <9368F94B8322984EBD1A047E8828AE81@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37497402-7d29-46d0-972c-08da6b1af8f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 13:14:41.5953 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UDDfVg/Fu7OvSFPJbOTerCRcltZp/yNX1PNeVICaz88kVgT2euwrjgVBOSPB8U+FxFnyCwXj9rO7da9M6Lvt7vuepjrOucDg02t2oSaRyVg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5643 T24gMjEvMDcvMjAyMiAxNDowOSwgQW50aG9ueSBQRVJBUkQgd3JvdGU6DQo+IE9uIFRodSwgSnVs IDIxLCAyMDIyIGF0IDAxOjAzOjQxUE0gKzAwMDAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBP biAyMS8wNy8yMDIyIDEzOjQ1LCBBbnRob255IFBlcmFyZCB3cm90ZToNCj4+PiBQYXRjaCBzZXJp ZXMgYXZhaWxhYmxlIGluIHRoaXMgZ2l0IGJyYW5jaDoNCj4+PiBodHRwczovL3hlbmJpdHMueGVu Lm9yZy9naXQtaHR0cC9wZW9wbGUvYXBlcmFyZC94ZW4tdW5zdGFibGUuZ2l0IGJyLmdpdGxhYi1j aS1pbXByb3ZlbWVudC12Mg0KPj4+DQo+Pj4gdjI6DQo+Pj4gLSByZWJhc2VkDQo+Pj4NCj4+PiBB bGxvdyBidWlsZCBhbmQgdGVzdCBqb2JzIHRvIHJ1biBjb25jdXJlbnRseS4NCj4+Pg0KPj4+IEF2 b2lkIHJ1bm5pbmcgInRlc3QgYXJ0aWZhY3QiIGpvYnMgb24gYnJhbmNoICJtYXN0ZXIiIGFuZCBv dGhlciwgd2hlbiB0ZXN0IGpvYnMNCj4+PiBhcmVuJ3QgcnVubmVkLg0KPj4+DQo+Pj4gQW50aG9u eSBQRVJBUkQgKDQpOg0KPj4+ICAgYXV0b21hdGlvbjogZml4IHR5cG8gaW4gLmdjYy10bXBsDQo+ Pj4gICBhdXRvbWF0aW9uOiBhZGQgYSB0ZW1wbGF0ZXMgZm9yIHRlc3Qgam9icw0KPj4+ICAgYXV0 b21hdGlvbjogb25seSBydW4gdGVzdCBhcnRpZmFjdCBqb2JzIHdoZW4gbmVlZGVkDQo+Pj4gICBh dXRvbWF0aW9uOiB1c2UgIm5lZWRzIiBpbnN0ZWFkIG9mICJkZXBlbmRlbmNpZXMiIGZvciB0ZXN0 IGpvYnMNCj4+IExHVE0uwqAgR290IGEgQ0kgcnVuIG9mIHRoZXNlPw0KPiBZZXMsDQo+DQo+IHBh dGNoZXcncyBjb21taXQgaXMgaW4gcHJvZ3Jlc3M6DQo+IGh0dHBzOi8vZ2l0bGFiLmNvbS94ZW4t cHJvamVjdC9wYXRjaGV3L3hlbi8tL3BpcGVsaW5lcy81OTM0NzkxNTcNCj4NCj4gQSBydW4gaW4g bXkgcHJpdmF0ZSByZXBvOg0KPiBodHRwczovL2dpdGxhYi5jb20veGVuLXByb2plY3QvcGVvcGxl L2FudGhvbnlwZXIveGVuLy0vcGlwZWxpbmVzLzU5MzM0MDgyMA0KPiAobm8gZmFpbHVyZSBkdWUg dG8gdGhpcyBjaGFuZ2UpDQo+DQo+IFJ1bm5pbmcgb24gb25lIG9mIG15IGJyYW5jaCBjYWxsZWQg InN0YWJsZS13aXAiIGRvZXNuJ3QgY3JlYXRlIGFueQ0KPiBwaXBlbGluZSwgYXMgZXhwZWN0ZWQu DQo+DQoNCg0KQ29vbC7CoCBJJ2xsIGdldCB0aGVzZSA0IGNvbW1pdHRlZCBpbiBkdWUgY291cnNl Lg0KDQpPbmUgdGhpbmcsIGxvb2tpbmcgYXQgdGhpcyByaWdodCBub3cuwqAgSXMgdGhlcmUgYW55 dGhpbmcgd2UgY2FuIHdlDQpwcmlvcml0aXplIHRoZSBidWlsZHMgdXNlZCB0byBydW4gdGhlIHFl bXUgc21va2UgdGVzdHM/wqAgV2UndmUgY3VycmVudGx5DQpnb3QgeDg2IHNtb2tlIHRlc3RzIHdh aXRpbmcgd2hpbGUgdGhlIHdvcmtlcnMgYXJlIGJ1aWxkaW5nIGh5cGVydmlzb3JzDQp1bnJlbGF0 ZWQgdG8gdGhlIHRlc3RzLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372752.604689 (Exim 4.92) (envelope-from ) id 1oEW7Y-0001zk-Mx; Thu, 21 Jul 2022 13:21:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372752.604689; Thu, 21 Jul 2022 13:21:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7Y-0001zb-Jq; Thu, 21 Jul 2022 13:21:40 +0000 Received: by outflank-mailman (input) for mailman id 372752; Thu, 21 Jul 2022 13:21:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7W-0001je-BN for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:38 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 0c2d2859-08f8-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:21:37 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D567713D5; Thu, 21 Jul 2022 06:21:36 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 223733F73D; Thu, 21 Jul 2022 06:21:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c2d2859-08f8-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 1/9] xen/arm: introduce static shared memory Date: Thu, 21 Jul 2022 21:21:07 +0800 Message-Id: <20220721132115.3015761-2-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This patch series introduces a new feature: setting up static shared memory on a dom0less system, through device tree configuration. This commit parses shared memory node at boot-time, and reserve it in bootinfo.reserved_mem to avoid other use. This commits proposes a new Kconfig CONFIG_STATIC_SHM to wrap static-shm-related codes, and this option depends on static memory( CONFIG_STATIC_MEMORY). That's because that later we want to reuse a few helpers, guarded with CONFIG_STATIC_MEMORY, like acquire_staticmem_pages, etc, on static shared memory. Signed-off-by: Penny Zheng --- v6 change: - when host physical address is ommited, output the error message since xen doesn't support it at the moment - add the following check: 1) The shm ID matches and the region exactly match 2) The shm ID doesn't match and the region doesn't overlap - change it to "unsigned int" to be aligned with nr_banks - check the len of the property to confirm is it big enough to contain "paddr", "size", and "gaddr" - shm_id defined before nr_shm_domain, so we could re-use the existing hole and avoid increasing the size of the structure. - change "nr_shm_domain" to "nr_shm_borrowers", to not increment if the role is owner in parsing code - make "xen,shm_id" property as arbitrary string, with a strict limit on the number of characters, MAX_SHM_ID_LENGTH --- v5 change: - no change --- v4 change: - nit fix on doc --- v3 change: - make nr_shm_domain unsigned int --- v2 change: - document refinement - remove bitmap and use the iteration to check - add a new field nr_shm_domain to keep the number of shared domain --- docs/misc/arm/device-tree/booting.txt | 124 ++++++++++++++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 157 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/setup.h | 9 ++ 4 files changed, 296 insertions(+) diff --git a/docs/misc/arm/device-tree/booting.txt b/docs/misc/arm/device-tree/booting.txt index 98253414b8..8013fb98fe 100644 --- a/docs/misc/arm/device-tree/booting.txt +++ b/docs/misc/arm/device-tree/booting.txt @@ -378,3 +378,127 @@ device-tree: This will reserve a 512MB region starting at the host physical address 0x30000000 to be exclusively used by DomU1. + +Static Shared Memory +==================== + +The static shared memory device tree nodes allow users to statically set up +shared memory on dom0less system, enabling domains to do shm-based +communication. + +- compatible + + "xen,domain-shared-memory-v1" + +- xen,shm-id + + An arbitrary string that represents the unique identifier of the shared + memory region, with a strict limit on the number of characters(\0 included), + `MAX_SHM_ID_LENGTH(16)`. e.g. "xen,shm-id = "my-shared-mem-1"". + +- xen,shared-mem + + An array takes a physical address, which is the base address of the + shared memory region in host physical address space, a size, and a guest + physical address, as the target address of the mapping. + e.g. xen,shared-mem = < [host physical address] [size] [guest address] > + + The number of cells for the host address (and size) is the same as the + guest pseudo-physical address and they are inherited from the parent node. + + +- role (Optional) + + A string property specifying the ownership of a shared memory region, + the value must be one of the following: "owner", or "borrower" + A shared memory region could be explicitly backed by one domain, which is + called "owner domain", and all the other domains who are also sharing + this region are called "borrower domain". + If not specified, the default value is "borrower" and owner is + DOMID_IO, a system domain. + +As an example: + +chosen { + #address-cells = <0x1>; + #size-cells = <0x1>; + xen,xen-bootargs = "console=dtuart dtuart=serial0 bootscrub=0"; + + ...... + + /* this is for Dom0 */ + dom0-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "owner"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x10000000 0x10000000>; + } + + domU1 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 131072>; + cpus = <2>; + vpl011; + + /* + * shared memory region identified as 0x0(xen,shm-id = <0x0>) + * is shared between Dom0 and DomU1. + */ + domU1-shared-mem@10000000 { + compatible = "xen,domain-shared-memory-v1"; + role = "borrower"; + xen,shm-id = "my-shared-mem-0"; + xen,shared-mem = <0x10000000 0x10000000 0x50000000>; + } + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between DomU1 and DomU2. + */ + domU1-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x20000000 0x60000000>; + } + + ...... + + }; + + domU2 { + compatible = "xen,domain"; + #address-cells = <0x1>; + #size-cells = <0x1>; + memory = <0 65536>; + cpus = <1>; + + /* + * shared memory region identified as 0x1(xen,shm-id = <0x1>) + * is shared between domU1 and domU2. + */ + domU2-shared-mem@50000000 { + compatible = "xen,domain-shared-memory-v1"; + xen,shm-id = "my-shared-mem-1"; + xen,shared-mem = <0x50000000 0x20000000 0x70000000>; + } + + ...... + }; +}; + +This is an example with two static shared memory regions. + +For the static shared memory region identified as "my-shared-mem-0", host +physical address starting at 0x10000000 of 256MB will be reserved to be +shared between Dom0 and DomU1. It will get mapped at 0x10000000 in Dom0 guest +physical address space, and at 0x50000000 in DomU1 guest physical address space. +Dom0 is explicitly defined as the owner domain, and DomU1 is the borrower domain. + +For the static shared memory region identified as "my-shared-mem-1", host +physical address starting at 0x50000000 of 512MB will be reserved to be +shared between DomU1 and DomU2. It will get mapped at 0x60000000 in DomU1 guest +physical address space, and at 0x70000000 in DomU2 guest physical address space. +DomU1 and DomU2 are both the borrower domain, the owner domain is the default +owner domain DOMID_IO. diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig index be9eff0141..7321f47c0f 100644 --- a/xen/arch/arm/Kconfig +++ b/xen/arch/arm/Kconfig @@ -139,6 +139,12 @@ config TEE source "arch/arm/tee/Kconfig" +config STATIC_SHM + bool "Statically shared memory on a dom0less system" if UNSUPPORTED + depends on STATIC_MEMORY + help + This option enables statically shared memory on a dom0less system. + endmenu menu "ARM errata workaround via the alternative framework" diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c index ec81a45de9..c62d8867ec 100644 --- a/xen/arch/arm/bootfdt.c +++ b/xen/arch/arm/bootfdt.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include #include @@ -361,6 +362,158 @@ static int __init process_domain_node(const void *fdt, int node, size_cells, &bootinfo.reserved_mem, true); } +#ifdef CONFIG_STATIC_SHM +static int __init process_shm_node(const void *fdt, int node, + u32 address_cells, u32 size_cells) +{ + const struct fdt_property *prop, *prop_id, *prop_role; + const __be32 *cell; + paddr_t paddr, size; + struct meminfo *mem = &bootinfo.reserved_mem; + unsigned int i; + int len; + bool owner = false; + const char *shm_id; + + if ( address_cells < 1 || size_cells < 1 ) + { + printk("fdt: invalid #address-cells or #size-cells for static shared memory node.\n"); + return -EINVAL; + } + + /* + * "xen,shm-id" property holds an arbitrary string with a strict limit + * on the number of characters, MAX_SHM_ID_LENGTH + */ + prop_id = fdt_get_property(fdt, node, "xen,shm-id", NULL); + if ( !prop_id ) + return -ENOENT; + shm_id = (const char *)prop_id->data; + if ( strnlen(shm_id, MAX_SHM_ID_LENGTH) == MAX_SHM_ID_LENGTH ) + { + printk("fdt: invalid xen,shm-id %s, it must be limited to %d characters\n", + shm_id, MAX_SHM_ID_LENGTH); + return -EINVAL; + } + + /* + * "role" property is optional and if it is defined explicitly, + * it must be either `owner` or `borrower`. + */ + prop_role = fdt_get_property(fdt, node, "role", NULL); + if ( prop_role ) + { + if ( !strcmp(prop_role->data, "owner") ) + owner = true; + else if ( strcmp(prop_role->data, "borrower") ) + { + printk("fdt: invalid `role` property for static shared memory node.\n"); + return -EINVAL; + } + } + + /* + * xen,shared-mem = ; + * Memory region starting from physical address #paddr of #size shall + * be mapped to guest physical address #gaddr as static shared memory + * region. + */ + prop = fdt_get_property(fdt, node, "xen,shared-mem", &len); + if ( !prop ) + return -ENOENT; + + if ( len != dt_cells_to_size(address_cells + size_cells + address_cells) ) + { + /* TODO: physical address is optional. */ + if ( len == dt_cells_to_size(size_cells + address_cells) ) + printk("fdt: host physical address must be chosen by users at the moment.\n"); + + printk("fdt: invalid `xen,shared-mem` property.\n"); + return -EINVAL; + } + + cell = (const __be32 *)prop->data; + device_tree_get_reg(&cell, address_cells, size_cells, &paddr, &size); + + if ( !size ) + { + printk("fdt: the size for static shared memory region can not be zero\n"); + return -EINVAL; + } + + for ( i = 0; i < mem->nr_banks; i++ ) + { + /* + * Meet the following check: + * 1) The shm ID matches and the region exactly match + * 2) The shm ID doesn't match and the region doesn't overlap + * with an existing one + */ + if ( paddr == mem->bank[i].start && size == mem->bank[i].size ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, MAX_SHM_ID_LENGTH) == 0 ) + break; + else + { + printk("fdt: xen,shm-id %s does not match for all the nodes using the same region.\n", + shm_id); + return -EINVAL; + } + } + else + { + paddr_t end = paddr + size; + paddr_t bank_end = mem->bank[i].start + mem->bank[i].size; + + if ( (end <= mem->bank[i].start) || (paddr >= bank_end) ) + { + if ( strncmp(shm_id, mem->bank[i].shm_id, + MAX_SHM_ID_LENGTH) != 0 ) + continue; + else + { + printk("fdt: different shared memory region could not share the same shm ID %s\n", + shm_id); + return -EINVAL; + } + } + else + { + printk("fdt: shared memory region overlap with an existing entry %#"PRIpaddr" - %#"PRIpaddr"\n", + mem->bank[i].start, bank_end); + return -EINVAL; + } + } + } + + if ( i == mem->nr_banks ) + { + if ( i < NR_MEM_BANKS ) + { + /* Static shared memory shall be reserved from any other use. */ + safe_strcpy(mem->bank[mem->nr_banks].shm_id, shm_id); + mem->bank[mem->nr_banks].start = paddr; + mem->bank[mem->nr_banks].size = size; + mem->bank[mem->nr_banks].xen_domain = true; + mem->nr_banks++; + } + else + { + printk("Warning: Max number of supported memory regions reached.\n"); + return -ENOSPC; + } + } + /* + * keep a count of the number of borrowers, which later may be used + * to calculate the reference count. + */ + if ( !owner ) + mem->bank[i].nr_shm_borrowers++; + + return 0; +} +#endif + static int __init early_scan_node(const void *fdt, int node, const char *name, int depth, u32 address_cells, u32 size_cells, @@ -386,6 +539,10 @@ static int __init early_scan_node(const void *fdt, process_chosen_node(fdt, node, name, address_cells, size_cells); else if ( depth == 2 && device_tree_node_compatible(fdt, node, "xen,domain") ) rc = process_domain_node(fdt, node, name, address_cells, size_cells); +#ifdef CONFIG_STATIC_SHM + else if ( depth <= 3 && device_tree_node_compatible(fdt, node, "xen,domain-shared-memory-v1") ) + rc = process_shm_node(fdt, node, address_cells, size_cells); +#endif if ( rc < 0 ) printk("fdt: node `%s': parsing failed\n", name); diff --git a/xen/arch/arm/include/asm/setup.h b/xen/arch/arm/include/asm/setup.h index 2bb01ecfa8..39d4e93b8b 100644 --- a/xen/arch/arm/include/asm/setup.h +++ b/xen/arch/arm/include/asm/setup.h @@ -23,10 +23,19 @@ typedef enum { } bootmodule_kind; +#ifdef CONFIG_STATIC_SHM +/* Indicates the maximum number of characters(\0 included) for shm_id */ +#define MAX_SHM_ID_LENGTH 16 +#endif + struct membank { paddr_t start; paddr_t size; bool xen_domain; /* whether the memory bank is bound to a Xen domain. */ +#ifdef CONFIG_STATIC_SHM + char shm_id[MAX_SHM_ID_LENGTH]; + unsigned int nr_shm_borrowers; +#endif }; struct meminfo { -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372751.604678 (Exim 4.92) (envelope-from ) id 1oEW7W-0001jr-FF; Thu, 21 Jul 2022 13:21:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372751.604678; Thu, 21 Jul 2022 13:21:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7W-0001jk-Cd; Thu, 21 Jul 2022 13:21:38 +0000 Received: by outflank-mailman (input) for mailman id 372751; Thu, 21 Jul 2022 13:21:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7U-0001je-KU for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:36 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 0a87f646-08f8-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:21:34 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 22F2123A; Thu, 21 Jul 2022 06:21:34 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5EF9F3F73D; Thu, 21 Jul 2022 06:21:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a87f646-08f8-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v6 0/9] static shared memory on dom0less system Date: Thu, 21 Jul 2022 21:21:06 +0800 Message-Id: <20220721132115.3015761-1-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In safety-critical environment, it is not considered safe to dynamically change important configurations at runtime. Everything should be statically defined and statically verified. In this case, if the system configuration knows a priori that there are only 2 VMs and they need to communicate over shared memory, it is safer to pre-configure the shared memory at build time rather than let the VMs attempt to share memory at runtime. And it is faster too. Furthermore, on dom0less system, the legacy way to build up communication channels between domains, like grant table, are normally absent there. So this patch serie introduces a set of static shared memory device tree nodes to allow users to statically set up shared memory on dom0less system, enabling domains to do shm-based communication. The only way to trigger this static shared memory configuration should be via device tree, which is at the same level as the XSM rules. It was inspired by the patch serie of ["xl/libxl-based shared mem]( https://marc.info/?l=xen-devel&m=154404821731186ory"). Looking into related [design link]( https://lore.kernel.org/all/a50d9fde-1d06-7cda-2779-9eea9e1c0134@xen.org/T/) for more details. Penny Zheng (9): xen/arm: introduce static shared memory xen/arm: allocate static shared memory to the default owner dom_io xen/arm: allocate static shared memory to a specific owner domain xen/arm: introduce put_page_nr and get_page_nr xen/arm: Add additional reference to owner domain when the owner is allocated xen/arm: set up shared memory foreign mapping for borrower domain xen/arm: create shared memory nodes in guest device tree xen/arm: enable statically shared memory on Dom0 xen: Add static memory sharing in SUPPORT.md SUPPORT.md | 6 + docs/misc/arm/device-tree/booting.txt | 124 ++++++++ xen/arch/arm/Kconfig | 6 + xen/arch/arm/bootfdt.c | 157 ++++++++++ xen/arch/arm/domain_build.c | 402 ++++++++++++++++++++++++++ xen/arch/arm/include/asm/kernel.h | 1 + xen/arch/arm/include/asm/mm.h | 4 + xen/arch/arm/include/asm/setup.h | 9 + xen/arch/arm/mm.c | 42 ++- xen/common/domain.c | 3 + 10 files changed, 745 insertions(+), 9 deletions(-) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372753.604701 (Exim 4.92) (envelope-from ) id 1oEW7b-0002Hs-5v; Thu, 21 Jul 2022 13:21:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372753.604701; Thu, 21 Jul 2022 13:21:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7b-0002Hj-1z; Thu, 21 Jul 2022 13:21:43 +0000 Received: by outflank-mailman (input) for mailman id 372753; Thu, 21 Jul 2022 13:21:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7a-0002GA-AN for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:42 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 0e6ac250-08f8-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:21:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AA81523A; Thu, 21 Jul 2022 06:21:40 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id D95CC3F73D; Thu, 21 Jul 2022 06:21:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e6ac250-08f8-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu Subject: [PATCH v6 2/9] xen/arm: allocate static shared memory to the default owner dom_io Date: Thu, 21 Jul 2022 21:21:08 +0800 Message-Id: <20220721132115.3015761-3-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng This commit introduces process_shm to cope with static shared memory in domain construction. DOMID_IO will be the default owner of memory pre-shared among multiple domains at boot time, when no explicit owner is specified. This commit only considers allocating static shared memory to dom_io when owner domain is not explicitly defined in device tree, all the left, including the "borrower" code path, the "explicit owner" code path, shall be introduced later in the following patches. Signed-off-by: Penny Zheng --- v6 change: - use if-array to check psize, pbase and gbase are suitably aligned and valid - use mfn_valid to check (pbase, pbase + psize) - check d->max_pages will not overflow - refine acquire_shared_memory_bank to not reuse acquire_static_memory_bank, then input pbase and psize do not need to be used as a pointer. - use if-array to check if page owner is dom_io - in-code comment refinement --- v5 change: - refine in-code comment --- v4 change: - no changes --- v3 change: - refine in-code comment --- v2 change: - instead of introducing a new system domain, reuse the existing dom_io - make dom_io a non-auto-translated domain, then no need to create P2M for it - change dom_io definition and make it wider to support static shm here too - introduce is_shm_allocated_to_domio to check whether static shm is allocated yet, instead of using shm_mask bitmap - add in-code comment --- xen/arch/arm/domain_build.c | 155 ++++++++++++++++++++++++++++++++++++ xen/common/domain.c | 3 + 2 files changed, 158 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 3fd1186b53..ff2aebaf28 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -759,6 +759,155 @@ static void __init assign_static_memory_11(struct domain *d, panic("Failed to assign requested static memory for direct-map domain %pd.", d); } + +#ifdef CONFIG_STATIC_SHM +/* + * This function checks whether the static shared memory region is + * already allocated to dom_io. + */ +static bool __init is_shm_allocated_to_domio(paddr_t pbase) +{ + struct page_info *page; + + page = maddr_to_page(pbase); + if ( page_get_owner(page) == NULL ) + return false; + + if ( page_get_owner(page) != dom_io ) + { + printk(XENLOG_ERR + "shm memory node has already been allocated to a specific owner %pd, Please check your configuration\n", + page_get_owner(page)); + return false; + } + + return true; +} + +static mfn_t __init acquire_shared_memory_bank(struct domain *d, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + unsigned long nr_pfns; + int res; + + /* + * Pages of statically shared memory shall be included + * into domain_tot_pages(). + */ + nr_pfns = PFN_DOWN(psize); + if ( (UINT_MAX - d->max_pages) < nr_pfns ) + { + printk(XENLOG_ERR "%pd: Over-allocation for d->max_pages: %lu.\n", + d, nr_pfns); + return INVALID_MFN; + } + d->max_pages += nr_pfns; + + smfn = maddr_to_mfn(pbase); + res = acquire_domstatic_pages(d, smfn, nr_pfns, 0); + if ( res ) + { + printk(XENLOG_ERR + "%pd: failed to acquire static memory: %d.\n", d, res); + return INVALID_MFN; + } + + return smfn; +} + +static int __init allocate_shared_memory(struct domain *d, + u32 addr_cells, u32 size_cells, + paddr_t pbase, paddr_t psize) +{ + mfn_t smfn; + + dprintk(XENLOG_INFO, + "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", + d, pbase, pbase + psize); + + smfn = acquire_shared_memory_bank(d, pbase, psize); + if ( mfn_eq(smfn, INVALID_MFN) ) + return -EINVAL; + + /* + * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. + * It sees RAM 1:1 and we do not need to create P2M mapping for it + */ + ASSERT(d == dom_io); + return 0; +} + +static int __init process_shm(struct domain *d, + const struct dt_device_node *node) +{ + struct dt_device_node *shm_node; + + dt_for_each_child_node(node, shm_node) + { + const struct dt_property *prop; + const __be32 *cells; + uint32_t addr_cells, size_cells; + paddr_t gbase, pbase, psize; + int ret = 0; + unsigned int i; + + if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) + continue; + + /* + * xen,shared-mem = ; + * TODO: pbase is optional. + */ + addr_cells = dt_n_addr_cells(shm_node); + size_cells = dt_n_size_cells(shm_node); + prop = dt_find_property(shm_node, "xen,shared-mem", NULL); + ASSERT(prop); + cells = (const __be32 *)prop->value; + device_tree_get_reg(&cells, addr_cells, size_cells, &pbase, &psize); + gbase = dt_read_number(cells, addr_cells); + if ( !IS_ALIGNED(pbase, PAGE_SIZE) || !IS_ALIGNED(gbase, PAGE_SIZE) ) + { + printk("%pd: physical address 0x%"PRIpaddr", or guest address 0x%"PRIpaddr" is not suitably aligned.\n", + d, pbase, gbase); + return -EINVAL; + } + if ( !IS_ALIGNED(psize, PAGE_SIZE) ) + { + printk("%pd: size 0x%"PRIpaddr" is not suitably aligned\n", + d, psize); + return -EINVAL; + } + + for ( i = 0; i < PFN_DOWN(psize); i++ ) + if ( !mfn_valid(mfn_add(maddr_to_mfn(pbase), i)) ) + { + printk("%pd: invalid physical address 0x%"PRI_mfn"\n", + d, mfn_x(mfn_add(maddr_to_mfn(pbase), i))); + return -EINVAL; + } + + /* TODO: Consider owner domain is not the default dom_io. */ + /* + * Per static shared memory region could be shared between multiple + * domains. + * In case re-allocating the same shared memory region, we check + * if it is already allocated to the default owner dom_io before + * the actual allocation. + */ + if ( !is_shm_allocated_to_domio(pbase) ) + { + /* Allocate statically shared pages to the default owner dom_io. */ + ret = allocate_shared_memory(dom_io, addr_cells, size_cells, + pbase, psize); + if ( ret ) + return ret; + } + } + + return 0; +} +#endif /* CONFIG_STATIC_SHM */ #else static void __init allocate_static_memory(struct domain *d, struct kernel_info *kinfo, @@ -3236,6 +3385,12 @@ static int __init construct_domU(struct domain *d, else assign_static_memory_11(d, &kinfo, node); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, node); + if ( rc < 0 ) + return rc; +#endif + /* * Base address and irq number are needed when creating vpl011 device * tree node in prepare_dtb_domU, so initialization on related variables diff --git a/xen/common/domain.c b/xen/common/domain.c index 618410e3b2..c8564113e9 100644 --- a/xen/common/domain.c +++ b/xen/common/domain.c @@ -780,6 +780,9 @@ void __init setup_system_domains(void) * This domain owns I/O pages that are within the range of the page_info * array. Mappings occur at the priv of the caller. * Quarantined PCI devices will be associated with this domain. + * + * DOMID_IO is also the default owner of memory pre-shared among multiple + * domains at boot time. */ dom_io = domain_create(DOMID_IO, NULL, 0); if ( IS_ERR(dom_io) ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372755.604712 (Exim 4.92) (envelope-from ) id 1oEW7e-0002as-D5; Thu, 21 Jul 2022 13:21:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372755.604712; Thu, 21 Jul 2022 13:21:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7e-0002aj-A8; Thu, 21 Jul 2022 13:21:46 +0000 Received: by outflank-mailman (input) for mailman id 372755; Thu, 21 Jul 2022 13:21:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7c-0001je-K1 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:44 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 102246cb-08f8-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:21:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 883EB23A; Thu, 21 Jul 2022 06:21:43 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A4B6E3F73D; Thu, 21 Jul 2022 06:21:40 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 102246cb-08f8-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v6 3/9] xen/arm: allocate static shared memory to a specific owner domain Date: Thu, 21 Jul 2022 21:21:09 +0800 Message-Id: <20220721132115.3015761-4-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If owner property is defined, then owner domain of a static shared memory region is not the default dom_io anymore, but a specific domain. This commit implements allocating static shared memory to a specific domain when owner property is defined. Coding flow for dealing borrower domain will be introduced later in the following commits. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v6 change: - fix coding-style - role_str and owner_dom_io shall be defined within the loop --- v5 change: - no change --- v4 change: - no changes --- v3 change: - simplify the code since o_gbase is not used if the domain is dom_io --- v2 change: - P2M mapping is restricted to normal domain - in-code comment fix --- xen/arch/arm/domain_build.c | 44 +++++++++++++++++++++++++++---------- 1 file changed, 33 insertions(+), 11 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index ff2aebaf28..a7e95c34a7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -818,9 +818,11 @@ static mfn_t __init acquire_shared_memory_bank(struct domain *d, static int __init allocate_shared_memory(struct domain *d, u32 addr_cells, u32 size_cells, - paddr_t pbase, paddr_t psize) + paddr_t pbase, paddr_t psize, + paddr_t gbase) { mfn_t smfn; + int ret = 0; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -834,8 +836,18 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ - ASSERT(d == dom_io); - return 0; + if ( d != dom_io ) + { + ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, + PFN_DOWN(psize)); + if ( ret ) + { + printk(XENLOG_ERR "Failed to map shared memory to %pd.\n", d); + return ret; + } + } + + return ret; } static int __init process_shm(struct domain *d, @@ -851,6 +863,8 @@ static int __init process_shm(struct domain *d, paddr_t gbase, pbase, psize; int ret = 0; unsigned int i; + const char *role_str; + bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) continue; @@ -887,19 +901,27 @@ static int __init process_shm(struct domain *d, return -EINVAL; } - /* TODO: Consider owner domain is not the default dom_io. */ + /* + * "role" property is optional and if it is defined explicitly, + * then the owner domain is not the default "dom_io" domain. + */ + if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) + owner_dom_io = false; + /* * Per static shared memory region could be shared between multiple * domains. - * In case re-allocating the same shared memory region, we check - * if it is already allocated to the default owner dom_io before - * the actual allocation. + * So when owner domain is the default dom_io, in case re-allocating + * the same shared memory region, we check if it is already allocated + * to the default owner dom_io before the actual allocation. */ - if ( !is_shm_allocated_to_domio(pbase) ) + if ( (owner_dom_io && !is_shm_allocated_to_domio(pbase)) || + (!owner_dom_io && strcmp(role_str, "owner") == 0) ) { - /* Allocate statically shared pages to the default owner dom_io. */ - ret = allocate_shared_memory(dom_io, addr_cells, size_cells, - pbase, psize); + /* Allocate statically shared pages to the owner domain. */ + ret = allocate_shared_memory(owner_dom_io ? dom_io : d, + addr_cells, size_cells, + pbase, psize, gbase); if ( ret ) return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372757.604723 (Exim 4.92) (envelope-from ) id 1oEW7h-0002vT-MZ; Thu, 21 Jul 2022 13:21:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372757.604723; Thu, 21 Jul 2022 13:21:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7h-0002vK-Il; Thu, 21 Jul 2022 13:21:49 +0000 Received: by outflank-mailman (input) for mailman id 372757; Thu, 21 Jul 2022 13:21:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7f-0001je-Ro for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:47 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 120ceba8-08f8-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:21:46 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B30E723A; Thu, 21 Jul 2022 06:21:46 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 93A0A3F73D; Thu, 21 Jul 2022 06:21:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 120ceba8-08f8-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng , Julien Grall Subject: [PATCH v6 4/9] xen/arm: introduce put_page_nr and get_page_nr Date: Thu, 21 Jul 2022 21:21:10 +0800 Message-Id: <20220721132115.3015761-5-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Later, we need to add the right amount of references, which should be the number of borrower domains, to the owner domain. Since we only have get_page() to increment the page reference by 1, a loop is needed per page, which is inefficient and time-consuming. To save the loop time, this commit introduces a set of new helpers put_page_nr() and get_page_nr() to increment/drop the page reference by nr. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini Reviewed-by: Julien Grall --- v6 change: - no change --- v5 change: - no change --- v4 changes: - fix the assert about checking overflow to make sure that the right equation return is at least equal to nr - simplify the assert about checking the underflow --- v3 changes: - check overflow with "n" - remove spurious change - bring back the check that we enter the loop only when count_info is greater than 0 --- v2 change: - new commit --- xen/arch/arm/include/asm/mm.h | 4 ++++ xen/arch/arm/mm.c | 42 +++++++++++++++++++++++++++-------- 2 files changed, 37 insertions(+), 9 deletions(-) diff --git a/xen/arch/arm/include/asm/mm.h b/xen/arch/arm/include/asm/mm.h index c4bc3cd1e5..f1ab0fd030 100644 --- a/xen/arch/arm/include/asm/mm.h +++ b/xen/arch/arm/include/asm/mm.h @@ -343,6 +343,10 @@ void free_init_memory(void); int guest_physmap_mark_populate_on_demand(struct domain *d, unsigned long gfn, unsigned int order); +extern bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr); +extern void put_page_nr(struct page_info *page, unsigned long nr); + extern void put_page_type(struct page_info *page); static inline void put_page_and_type(struct page_info *page) { diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index 009b8cd9ef..d654980706 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -1587,21 +1587,29 @@ long arch_memory_op(int op, XEN_GUEST_HANDLE_PARAM(void) arg) return 0; } -struct domain *page_get_owner_and_reference(struct page_info *page) +static struct domain *page_get_owner_and_nr_reference(struct page_info *page, + unsigned long nr) { unsigned long x, y = page->count_info; struct domain *owner; + /* Restrict nr to avoid "double" overflow */ + if ( nr >= PGC_count_mask ) + { + ASSERT_UNREACHABLE(); + return NULL; + } + do { x = y; /* * Count == 0: Page is not allocated, so we cannot take a reference. * Count == -1: Reference count would wrap, which is invalid. */ - if ( unlikely(((x + 1) & PGC_count_mask) <= 1) ) + if ( unlikely(((x + nr) & PGC_count_mask) <= nr) ) return NULL; } - while ( (y = cmpxchg(&page->count_info, x, x + 1)) != x ); + while ( (y = cmpxchg(&page->count_info, x, x + nr)) != x ); owner = page_get_owner(page); ASSERT(owner); @@ -1609,14 +1617,19 @@ struct domain *page_get_owner_and_reference(struct page_info *page) return owner; } -void put_page(struct page_info *page) +struct domain *page_get_owner_and_reference(struct page_info *page) +{ + return page_get_owner_and_nr_reference(page, 1); +} + +void put_page_nr(struct page_info *page, unsigned long nr) { unsigned long nx, x, y = page->count_info; do { - ASSERT((y & PGC_count_mask) != 0); + ASSERT((y & PGC_count_mask) >= nr); x = y; - nx = x - 1; + nx = x - nr; } while ( unlikely((y = cmpxchg(&page->count_info, x, nx)) != x) ); @@ -1626,19 +1639,30 @@ void put_page(struct page_info *page) } } -bool get_page(struct page_info *page, const struct domain *domain) +void put_page(struct page_info *page) +{ + put_page_nr(page, 1); +} + +bool get_page_nr(struct page_info *page, const struct domain *domain, + unsigned long nr) { - const struct domain *owner = page_get_owner_and_reference(page); + const struct domain *owner = page_get_owner_and_nr_reference(page, nr); if ( likely(owner == domain) ) return true; if ( owner != NULL ) - put_page(page); + put_page_nr(page, nr); return false; } +bool get_page(struct page_info *page, const struct domain *domain) +{ + return get_page_nr(page, domain, 1); +} + /* Common code requires get_page_type and put_page_type. * We don't care about typecounts so we just do the minimum to make it * happy. */ -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372759.604734 (Exim 4.92) (envelope-from ) id 1oEW7j-0003GG-VF; Thu, 21 Jul 2022 13:21:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372759.604734; Thu, 21 Jul 2022 13:21:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7j-0003G5-Rh; Thu, 21 Jul 2022 13:21:51 +0000 Received: by outflank-mailman (input) for mailman id 372759; Thu, 21 Jul 2022 13:21:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7i-0002GA-T0 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:51 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 13c9acc9-08f8-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:21:49 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 97C9923A; Thu, 21 Jul 2022 06:21:49 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B0A363F73D; Thu, 21 Jul 2022 06:21:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13c9acc9-08f8-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v6 5/9] xen/arm: Add additional reference to owner domain when the owner is allocated Date: Thu, 21 Jul 2022 21:21:11 +0800 Message-Id: <20220721132115.3015761-6-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Borrower domain will fail to get a page ref using the owner domain during allocation, when the owner is created after borrower. So here, we decide to get and add the right amount of reference, which is the number of borrowers, when the owner is allocated. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v6 change: - adapt to the change of "nr_shm_borrowers" - add in-code comment to explain if the borrower is created first, we intend to add pages in the P2M without reference. --- v5 change: - no change --- v4 changes: - no change --- v3 change: - printk rather than dprintk since it is a serious error --- v2 change: - new commit --- xen/arch/arm/domain_build.c | 60 +++++++++++++++++++++++++++++++++++++ 1 file changed, 60 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index a7e95c34a7..e891e800a7 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -761,6 +761,30 @@ static void __init assign_static_memory_11(struct domain *d, } #ifdef CONFIG_STATIC_SHM +static int __init acquire_nr_borrower_domain(struct domain *d, + paddr_t pbase, paddr_t psize, + unsigned long *nr_borrowers) +{ + unsigned long bank; + + /* Iterate reserved memory to find requested shm bank. */ + for ( bank = 0 ; bank < bootinfo.reserved_mem.nr_banks; bank++ ) + { + paddr_t bank_start = bootinfo.reserved_mem.bank[bank].start; + paddr_t bank_size = bootinfo.reserved_mem.bank[bank].size; + + if ( (pbase == bank_start) && (psize == bank_size) ) + break; + } + + if ( bank == bootinfo.reserved_mem.nr_banks ) + return -ENOENT; + + *nr_borrowers = bootinfo.reserved_mem.bank[bank].nr_shm_borrowers; + + return 0; +} + /* * This function checks whether the static shared memory region is * already allocated to dom_io. @@ -823,6 +847,8 @@ static int __init allocate_shared_memory(struct domain *d, { mfn_t smfn; int ret = 0; + unsigned long nr_pages, nr_borrowers, i; + struct page_info *page; dprintk(XENLOG_INFO, "%pd: allocate static shared memory BANK %#"PRIpaddr"-%#"PRIpaddr".\n", @@ -836,6 +862,7 @@ static int __init allocate_shared_memory(struct domain *d, * DOMID_IO is the domain, like DOMID_XEN, that is not auto-translated. * It sees RAM 1:1 and we do not need to create P2M mapping for it */ + nr_pages = PFN_DOWN(psize); if ( d != dom_io ) { ret = guest_physmap_add_pages(d, gaddr_to_gfn(gbase), smfn, @@ -847,6 +874,39 @@ static int __init allocate_shared_memory(struct domain *d, } } + /* + * Get the right amount of references per page, which is the number of + * borrower domains. + */ + ret = acquire_nr_borrower_domain(d, pbase, psize, &nr_borrowers); + if ( ret ) + return ret; + + /* + * Instead of letting borrower domain get a page ref, we add as many + * additional reference as the number of borrowers when the owner + * is allocated, since there is a chance that owner is created + * after borrower. + * So if the borrower is created first, it will cause adding pages + * in the P2M without reference. + */ + page = mfn_to_page(smfn); + for ( i = 0; i < nr_pages; i++ ) + { + if ( !get_page_nr(page + i, d, nr_borrowers) ) + { + printk(XENLOG_ERR + "Failed to add %lu references to page %"PRI_mfn".\n", + nr_borrowers, mfn_x(smfn) + i); + goto fail; + } + } + + return 0; + + fail: + while ( --i >= 0 ) + put_page_nr(page + i, nr_borrowers); return ret; } -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372763.604745 (Exim 4.92) (envelope-from ) id 1oEW7m-0003bY-6j; Thu, 21 Jul 2022 13:21:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372763.604745; Thu, 21 Jul 2022 13:21:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7m-0003bD-3J; Thu, 21 Jul 2022 13:21:54 +0000 Received: by outflank-mailman (input) for mailman id 372763; Thu, 21 Jul 2022 13:21:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7l-0001je-Gv for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:53 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 15668b03-08f8-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 15:21:52 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B85123A; Thu, 21 Jul 2022 06:21:52 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8C23F3F73D; Thu, 21 Jul 2022 06:21:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 15668b03-08f8-11ed-924f-1f966e50362f From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v6 6/9] xen/arm: set up shared memory foreign mapping for borrower domain Date: Thu, 21 Jul 2022 21:21:12 +0800 Message-Id: <20220721132115.3015761-7-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This commit sets up shared memory foreign mapping for borrower domain. If owner domain is the default dom_io, all shared domain are treated as borrower domain. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v6 change: - no change --- v5 change: - no change --- v4 changes: - no change --- v3 change: - use map_regions_p2mt instead --- v2 change: - remove guest_physmap_add_shm, since for borrower domain, we only do P2M foreign memory mapping now. --- xen/arch/arm/domain_build.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index e891e800a7..f76fbbc644 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -985,6 +985,15 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + if ( owner_dom_io || (strcmp(role_str, "borrower") == 0) ) + { + /* Set up P2M foreign mapping for borrower domain. */ + ret = map_regions_p2mt(d, _gfn(PFN_UP(gbase)), PFN_DOWN(psize), + _mfn(PFN_UP(pbase)), p2m_map_foreign_rw); + if ( ret ) + return ret; + } } return 0; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:21:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:21:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372766.604756 (Exim 4.92) (envelope-from ) id 1oEW7q-00046V-OW; Thu, 21 Jul 2022 13:21:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372766.604756; Thu, 21 Jul 2022 13:21:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7q-00046G-Kz; Thu, 21 Jul 2022 13:21:58 +0000 Received: by outflank-mailman (input) for mailman id 372766; Thu, 21 Jul 2022 13:21:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7o-0002GA-Jw for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:56 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1731edf1-08f8-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:21:55 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 497A723A; Thu, 21 Jul 2022 06:21:55 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 66B953F73D; Thu, 21 Jul 2022 06:21:52 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1731edf1-08f8-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Penny Zheng Subject: [PATCH v6 7/9] xen/arm: create shared memory nodes in guest device tree Date: Thu, 21 Jul 2022 21:21:13 +0800 Message-Id: <20220721132115.3015761-8-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit We expose the shared memory to the domU using the "xen,shared-memory-v1" reserved-memory binding. See Documentation/devicetree/bindings/reserved-memory/xen,shared-memory.txt in Linux for the corresponding device tree binding. To save the cost of re-parsing shared memory device tree configuration when creating shared memory nodes in guest device tree, this commit adds new field "shm_mem" to store shm-info per domain. For each shared memory region, a range is exposed under the /reserved-memory node as a child node. Each range sub-node is named xen-shmem@
and has the following properties: - compatible: compatible = "xen,shared-memory-v1" - reg: the base guest physical address and size of the shared memory region - xen,id: a string that identifies the shared memory region. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v6 change: - change "struct meminfo *mem" to "const struct meminfo *mem" - change "unsigned long i" to "unsigned int i" to match the type of nr_banks. - accroding to the Linux binding, "xen,id" is meant to be a string, not an integer --- v5 change: - no change --- v4 change: - no change --- v3 change: - move field "shm_mem" to kernel_info --- v2 change: - using xzalloc - shm_id should be uint8_t - make reg a local variable - add #address-cells and #size-cells properties - fix alignment --- xen/arch/arm/domain_build.c | 146 +++++++++++++++++++++++++++++- xen/arch/arm/include/asm/kernel.h | 1 + 2 files changed, 145 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index f76fbbc644..8d2c465c99 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -910,7 +910,22 @@ static int __init allocate_shared_memory(struct domain *d, return ret; } -static int __init process_shm(struct domain *d, +static int __init append_shm_bank_to_domain(struct kernel_info *kinfo, + paddr_t start, paddr_t size, + const char *shm_id) +{ + if ( (kinfo->shm_mem.nr_banks + 1) > NR_MEM_BANKS ) + return -ENOMEM; + + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].start = start; + kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].size = size; + safe_strcpy(kinfo->shm_mem.bank[kinfo->shm_mem.nr_banks].shm_id, shm_id); + kinfo->shm_mem.nr_banks++; + + return 0; +} + +static int __init process_shm(struct domain *d, struct kernel_info *kinfo, const struct dt_device_node *node) { struct dt_device_node *shm_node; @@ -924,6 +939,7 @@ static int __init process_shm(struct domain *d, int ret = 0; unsigned int i; const char *role_str; + const char *shm_id; bool owner_dom_io = true; if ( !dt_device_is_compatible(shm_node, "xen,domain-shared-memory-v1") ) @@ -968,6 +984,9 @@ static int __init process_shm(struct domain *d, if ( dt_property_read_string(shm_node, "role", &role_str) == 0 ) owner_dom_io = false; + dt_property_read_string(shm_node, "xen,shm-id", &shm_id); + ASSERT((strlen(shm_id) > 0) && (strlen(shm_id) < MAX_SHM_ID_LENGTH)); + /* * Per static shared memory region could be shared between multiple * domains. @@ -994,6 +1013,14 @@ static int __init process_shm(struct domain *d, if ( ret ) return ret; } + + /* + * Record static shared memory region info for later setting + * up shm-node in guest device tree. + */ + ret = append_shm_bank_to_domain(kinfo, gbase, psize, shm_id); + if ( ret ) + return ret; } return 0; @@ -1324,6 +1351,116 @@ static int __init make_memory_node(const struct domain *d, return res; } +#ifdef CONFIG_STATIC_SHM +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + const struct meminfo *mem) +{ + unsigned int i = 0; + int res = 0; + + if ( mem->nr_banks == 0 ) + return -ENOENT; + + /* + * For each shared memory region, a range is exposed under + * the /reserved-memory node as a child node. Each range sub-node is + * named xen-shmem@
. + */ + dt_dprintk("Create xen-shmem node\n"); + + for ( ; i < mem->nr_banks; i++ ) + { + uint64_t start = mem->bank[i].start; + uint64_t size = mem->bank[i].size; + /* Placeholder for xen-shmem@ + a 64-bit number + \0 */ + char buf[27]; + const char compat[] = "xen,shared-memory-v1"; + __be32 reg[addrcells + sizecells]; + __be32 *cells; + unsigned int len = (addrcells + sizecells) * sizeof(__be32); + + snprintf(buf, sizeof(buf), "xen-shmem@%"PRIx64, mem->bank[i].start); + res = fdt_begin_node(fdt, buf); + if ( res ) + return res; + + res = fdt_property(fdt, "compatible", compat, sizeof(compat)); + if ( res ) + return res; + + cells = reg; + dt_child_set_range(&cells, addrcells, sizecells, start, size); + + res = fdt_property(fdt, "reg", reg, len); + if ( res ) + return res; + + dt_dprintk("Shared memory bank %u: %#"PRIx64"->%#"PRIx64"\n", + i, start, start + size); + + res = fdt_property_string(fdt, "xen,id", mem->bank[i].shm_id); + if ( res ) + return res; + + res = fdt_end_node(fdt); + if ( res ) + return res; + } + + return res; +} +#else +static int __init make_shm_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + ASSERT_UNREACHABLE(); +} +#endif + +static int __init make_resv_memory_node(const struct domain *d, + void *fdt, + int addrcells, int sizecells, + struct meminfo *mem) +{ + int res = 0; + /* Placeholder for reserved-memory\0 */ + char resvbuf[16] = "reserved-memory"; + + if ( mem->nr_banks == 0 ) + /* No shared memory provided. */ + return 0; + + dt_dprintk("Create reserved-memory node\n"); + + res = fdt_begin_node(fdt, resvbuf); + if ( res ) + return res; + + res = fdt_property(fdt, "ranges", NULL, 0); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#address-cells", addrcells); + if ( res ) + return res; + + res = fdt_property_cell(fdt, "#size-cells", sizecells); + if ( res ) + return res; + + res = make_shm_memory_node(d, fdt, addrcells, sizecells, mem); + if ( res ) + return res; + + res = fdt_end_node(fdt); + + return res; +} + static int __init add_ext_regions(unsigned long s, unsigned long e, void *data) { struct meminfo *ext_regions = data; @@ -3101,6 +3238,11 @@ static int __init prepare_dtb_domU(struct domain *d, struct kernel_info *kinfo) if ( ret ) goto err; + ret = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( ret ) + goto err; + /* * domain_handle_dtb_bootmodule has to be called before the rest of * the device tree is generated because it depends on the value of @@ -3477,7 +3619,7 @@ static int __init construct_domU(struct domain *d, assign_static_memory_11(d, &kinfo, node); #ifdef CONFIG_STATIC_SHM - rc = process_shm(d, node); + rc = process_shm(d, &kinfo, node); if ( rc < 0 ) return rc; #endif diff --git a/xen/arch/arm/include/asm/kernel.h b/xen/arch/arm/include/asm/kernel.h index c4dc039b54..2cc506b100 100644 --- a/xen/arch/arm/include/asm/kernel.h +++ b/xen/arch/arm/include/asm/kernel.h @@ -19,6 +19,7 @@ struct kernel_info { void *fdt; /* flat device tree */ paddr_t unassigned_mem; /* RAM not (yet) assigned to a bank */ struct meminfo mem; + struct meminfo shm_mem; /* kernel entry point */ paddr_t entry; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:22:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:22:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372769.604767 (Exim 4.92) (envelope-from ) id 1oEW7t-0004aj-3s; Thu, 21 Jul 2022 13:22:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372769.604767; Thu, 21 Jul 2022 13:22:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7s-0004aX-Vu; Thu, 21 Jul 2022 13:22:00 +0000 Received: by outflank-mailman (input) for mailman id 372769; Thu, 21 Jul 2022 13:21:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7r-0002GA-2h for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:21:59 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 18a15023-08f8-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:21:57 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D98A723A; Thu, 21 Jul 2022 06:21:57 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 42AF63F73D; Thu, 21 Jul 2022 06:21:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18a15023-08f8-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v6 8/9] xen/arm: enable statically shared memory on Dom0 Date: Thu, 21 Jul 2022 21:21:14 +0800 Message-Id: <20220721132115.3015761-9-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Penny Zheng To add statically shared memory nodes in Dom0, user shall put according static shared memory configuration under /chosen node. This commit adds shm-processing function process_shm in construct_dom0 to enable statically shared memory on Dom0. Signed-off-by: Penny Zheng Reviewed-by: Stefano Stabellini --- v6 change: - no change --- v5 change: - no change --- v4 change: - no change --- v3 change: - no change --- v2 change: - no change --- xen/arch/arm/domain_build.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c index 8d2c465c99..7c592d63ab 100644 --- a/xen/arch/arm/domain_build.c +++ b/xen/arch/arm/domain_build.c @@ -2684,6 +2684,11 @@ static int __init handle_node(struct domain *d, struct kernel_info *kinfo, if ( res ) return res; } + + res = make_resv_memory_node(d, kinfo->fdt, addrcells, sizecells, + &kinfo->shm_mem); + if ( res ) + return res; } res = fdt_end_node(kinfo->fdt); @@ -3756,6 +3761,9 @@ static int __init construct_dom0(struct domain *d) { struct kernel_info kinfo = {}; int rc; +#ifdef CONFIG_STATIC_SHM + const struct dt_device_node *chosen = dt_find_node_by_path("/chosen"); +#endif /* Sanity! */ BUG_ON(d->domain_id != 0); @@ -3790,6 +3798,12 @@ static int __init construct_dom0(struct domain *d) allocate_memory_11(d, &kinfo); find_gnttab_region(d, &kinfo); +#ifdef CONFIG_STATIC_SHM + rc = process_shm(d, &kinfo, chosen); + if ( rc < 0 ) + return rc; +#endif + /* Map extra GIC MMIO, irqs and other hw stuffs to dom0. */ rc = gic_map_hwdom_extra_mappings(d); if ( rc < 0 ) -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:22:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:22:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372773.604778 (Exim 4.92) (envelope-from ) id 1oEW7v-00053k-Ik; Thu, 21 Jul 2022 13:22:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372773.604778; Thu, 21 Jul 2022 13:22:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7v-000522-En; Thu, 21 Jul 2022 13:22:03 +0000 Received: by outflank-mailman (input) for mailman id 372773; Thu, 21 Jul 2022 13:22:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEW7u-0002GA-EW for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:22:02 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 1ac2f87d-08f8-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:22:01 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61CB823A; Thu, 21 Jul 2022 06:22:01 -0700 (PDT) Received: from a011292.shanghai.arm.com (a011292.shanghai.arm.com [10.169.190.94]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E11B63F73D; Thu, 21 Jul 2022 06:21:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ac2f87d-08f8-11ed-bd2d-47488cf2e6aa From: Penny Zheng To: xen-devel@lists.xenproject.org Cc: Penny Zheng , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Penny Zheng Subject: [PATCH v6 9/9] xen: Add static memory sharing in SUPPORT.md Date: Thu, 21 Jul 2022 21:21:15 +0800 Message-Id: <20220721132115.3015761-10-Penny.Zheng@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220721132115.3015761-1-Penny.Zheng@arm.com> References: <20220721132115.3015761-1-Penny.Zheng@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit on ARM, static memory sharing is tech preview, which shall be documented in SUPPORT.md Signed-off-by: Penny Zheng --- v6 change: - new commit --- SUPPORT.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/SUPPORT.md b/SUPPORT.md index 8e040d1c1e..3dfe6d2fbe 100644 --- a/SUPPORT.md +++ b/SUPPORT.md @@ -299,6 +299,12 @@ Allow sharing of identical pages between guests Status, x86 HVM: Experimental +### Static Memory Sharing + +Allow memory pre-shared among multiple domains at boot time through device tree configuration + + Status, ARM: Tech Preview + ### Memory Paging Allow pages belonging to guests to be paged to disk -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:29:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:29:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372822.604789 (Exim 4.92) (envelope-from ) id 1oEWFP-00081Y-Hr; Thu, 21 Jul 2022 13:29:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372822.604789; Thu, 21 Jul 2022 13:29:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEWFP-00081R-Ey; Thu, 21 Jul 2022 13:29:47 +0000 Received: by outflank-mailman (input) for mailman id 372822; Thu, 21 Jul 2022 13:29:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEWFO-00081G-1w for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:29:46 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEWFL-0002bc-NZ; Thu, 21 Jul 2022 13:29:43 +0000 Received: from [54.239.6.185] (helo=[10.85.97.231]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oEWFL-0000ZP-HM; Thu, 21 Jul 2022 13:29:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=S5V2/jT+g1a/Bd/Qarc/ElFtL0qfdmdFdntYhR9xVI4=; b=0lnUtdvjSymiY70umvXpHakoad ipQq1yfUpMrg0T/+sZbffGbGQEldJ+7l/9s7leha3SUmbfyS8Rg6Y7YJntsNY+zihTCVslKoloJfy heQG3gx6uPJJI5aXlMxqUTStmANtU8beaGKTGLgL4lo6n9KGCdAQ2hkzlX+kR94F+SoI=; Message-ID: Date: Thu, 21 Jul 2022 14:29:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Rahul Singh Cc: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> From: Julien Grall In-Reply-To: <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 21/07/2022 13:50, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 20 Jul 2022, at 12:16 pm, Julien Grall wrote: >> >> Hi Rahul, >> >> On 20/07/2022 10:59, Rahul Singh wrote: >>>> On 13 Jul 2022, at 1:29 pm, Julien Grall wrote: >>>> >>>> >>>> >>>> On 13/07/2022 13:12, Bertrand Marquis wrote: >>>>>> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>>>>>> I can't >>>>>>> see why it would be wrong to have a more tight limit on static ports >>>>>>> than on traditional ("dynamic") ones. Even if only to make sure so >>>>>>> many dynamic ones are left. >>>>>> >>>>>> This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. >>>>> On other side we need to be cautious not to add too much complexity in the code by trying to make things always magically work. >>>>> If you want Xen to be accessible to non expert by magically working all the time, there would be a lot of work to do. >>>> >>>> It is not clear to me whether you are referring to a developper or admin here. >>>> >>>> On the admin side, we need to make sure they have an easy way to configure event channels. One knob is always going to easier than two knobs. >>>> >>>> On the developper side, this could be resolved by better documentation in the code/interface. >>>> >>>> Cheers, >>> To conclude the discussion, If everyone agree I will add the below patch or similar in the next version to restrict the >>> max number of evtchn supported as suggested. >> >> I am fine if the limit for domU is fixed by Xen for now. However, for dom0, 4096 is potentially too low if you have many PV drivers (each backend will need a few event channels). So I don't think this wants to be fixed by Xen. > Agree. >> >> I am not entirely sure we want to limit the number of event channels for dom0. But if you want to, then this will have to be done via a command line option (or device-tree property). > > We need to support the static event channel for dom0 also, in that case, we need to restrict the max number of evtchn for dom0 to mitigate the security issue. It sounds like there are some misundertanding or I am missing some context. The static event channels will be allocated at boot, so the worse that can happen is it will be slower to boot. My point regarding fifo was more in the generic case of allowing the caller to select the port. This would be a concern in the context of non-cooperative live-migration. An easy way is to restrict the number of ports. For you, this is just an increase in boot time. Furthermore, there is an issue for dom0less domUs because we don't limit the number of port by default. This means that a domU can allocate a large amount of memory in Xen (we need some per-event channel state). Hence why I suggested to update max_evtchn_channel. > If the admin set the value greater than 4096 (or what we agreed on) and static event channel support is enabled we will print the warning to the user related to fill > the hole issue for FIFO ABI. See above. I don't see the need for a warning. The admin will notice that it is slower to boot. See above. Cheers, > > Regards, > Rahul > -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 21 13:44:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 13:44:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372830.604806 (Exim 4.92) (envelope-from ) id 1oEWT7-0002Ck-Ta; Thu, 21 Jul 2022 13:43:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372830.604806; Thu, 21 Jul 2022 13:43:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEWT7-0002Cd-QT; Thu, 21 Jul 2022 13:43:57 +0000 Received: by outflank-mailman (input) for mailman id 372830; Thu, 21 Jul 2022 13:43:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEWT7-0002CX-H5 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 13:43:57 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 29a51dfc-08fb-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 15:43:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 29a51dfc-08fb-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658411035; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=AS5ZTLxZhyXYtjfXkjHVwAkEdEESCEmnz1nW+OJSAkc=; b=SUNMhjtuxgtVGC5b9HW56CKI1ZJk7VpCcNk9BXy4RphlIe9gCGukPplZ NuiW/WzZO0HIe0WhRYRDv/JKEZoK0pLOsZja62kX3CINkIZ17pVlG7iZb 46mYrt2a48sD0tSFlUXnQ78bSN0fcNwbgh+Qv6HI9nir/q8L6u5tbRghX w=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76327238 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:p/RdG6o6mUWR4dcyocCqJtZMR4NeBmIeZRIvgKrLsJaIsI4StFCzt garIBmOOfeDNjH1L9t2boXl9E1VuZDcnd9lG1Bo+S48EX9H9ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lB5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU14LcvPUdQp MVEAykCdTmOwKGG+ZiSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIWLIYbVH54F9qqej iGewE7fECg0DdyCyhzY3GqT3vDWrBquDer+E5Xnr6U30TV/3Fc7EwYKXFG2pf24jE+WWN9FL UEQvC00osAa/0WxQt7wdxaxunKDs1gXXN84O/037kSBx7TZ5y6dB3MYVXhRZdo+rsg0SDc2k FiTkLvBGjhHoLCTD3WH+d+pQSiaYHZPazVYPGldEFVDs4KLTJwPYgznY8wySJKTkIzMRRrpz CujoW99t4w5pJtev0mkxmwrkw5At7CQEFNlvFyNDz78hu9qTNX7PtL1sDA3+d4Fdd/EFQfZ4 RDojuDEtIgz4YexeDthqQnnNJWg/L67PTLVmjaD9LFxpm32qxZPkW29iQySxXuF0e5eIFcFm GeJ5WtsCGZ7ZRNGl5NfbYOrENgNxqP9D9njXf28RoMQP8gqKFXeono/Pxb4M4XRfK8EyPpXB HtmWZz0USZy5VpPl1JauNvxIZd0n3tjlAs/tLjwzgi90Kr2WUN5vYwtaQLWBshkvfzsnekg2 4wAXyd840kADbaWj+i+2dJ7EG3m2lBgXsis9JMGJ7frz8gPMDhJNsI9CIgJI+RN95m5XM+Sl p1hcie0EGbCuEA= IronPort-HdrOrdr: A9a23:tQWXjqMAjQ6DLsBcTvmjsMiBIKoaSvp037Eqv3oRdfVwSL3+qy nIpoV86faUskd0ZJhOo7y90cW7Lk80sKQFmLX5Xo3SOTUO2lHYT72KhLGKq1aLdhEWtNQtt5 uIG5IOcOEYZmIbsS+V2meFL+o= X-IronPort-AV: E=Sophos;i="5.93,289,1654574400"; d="scan'208";a="76327238" Date: Thu, 21 Jul 2022 14:43:50 +0100 From: Anthony PERARD To: Andrew Cooper CC: "xen-devel@lists.xenproject.org" , "wl@xen.org" , "sstabellini@kernel.org" , Doug Goldstein Subject: Re: [XEN PATCH v2 0/4] Some improvement for gitlab CI jobs Message-ID: References: <20220721124602.9910-1-anthony.perard@citrix.com> <2bba32aa-6ff5-f1f2-87c6-682c65dcf84e@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2bba32aa-6ff5-f1f2-87c6-682c65dcf84e@citrix.com> On Thu, Jul 21, 2022 at 01:14:41PM +0000, Andrew Cooper wrote: > On 21/07/2022 14:09, Anthony PERARD wrote: > > On Thu, Jul 21, 2022 at 01:03:41PM +0000, Andrew Cooper wrote: > >> On 21/07/2022 13:45, Anthony Perard wrote: > >>> Patch series available in this git branch: > >>> https://xenbits.xen.org/git-http/people/aperard/xen-unstable.git br.gitlab-ci-improvement-v2 > >>> > >>> v2: > >>> - rebased > >>> > >>> Allow build and test jobs to run concurently. > >>> > >>> Avoid running "test artifact" jobs on branch "master" and other, when test jobs > >>> aren't runned. > >>> > >>> Anthony PERARD (4): > >>> automation: fix typo in .gcc-tmpl > >>> automation: add a templates for test jobs > >>> automation: only run test artifact jobs when needed > >>> automation: use "needs" instead of "dependencies" for test jobs > >> LGTM. Got a CI run of these? > > Yes, > > > > patchew's commit is in progress: > > https://gitlab.com/xen-project/patchew/xen/-/pipelines/593479157 > > > > A run in my private repo: > > https://gitlab.com/xen-project/people/anthonyper/xen/-/pipelines/593340820 > > (no failure due to this change) > > > > Running on one of my branch called "stable-wip" doesn't create any > > pipeline, as expected. > > > > > Cool. I'll get these 4 committed in due course. Thanks. > One thing, looking at this right now. Is there anything we can we > prioritize the builds used to run the qemu smoke tests? We've currently > got x86 smoke tests waiting while the workers are building hypervisors > unrelated to the tests. I think the only way would be to create a new stage before the "build" stage which would have all the build jobs needed by the tests jobs. But that kind of became more complicated. -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Thu Jul 21 14:29:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 14:29:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372841.604829 (Exim 4.92) (envelope-from ) id 1oEXAf-00084b-MR; Thu, 21 Jul 2022 14:28:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372841.604829; Thu, 21 Jul 2022 14:28:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXAf-00084U-Jj; Thu, 21 Jul 2022 14:28:57 +0000 Received: by outflank-mailman (input) for mailman id 372841; Thu, 21 Jul 2022 14:28:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXAd-00084O-Eh for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 14:28:55 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6ae8e2fd-0901-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 16:28:43 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658413711948827.866975293264; Thu, 21 Jul 2022 07:28:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6ae8e2fd-0901-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658413714; cv=none; d=zohomail.com; s=zohoarc; b=QCNe8q+B5niVa7U9mY5uxNP6SmzxE+Afqhy1PEsR47KCM3yZ6fsQSqROjqlrgicdvUGfWa8jddYvV2HTSN4aqtXaFAuyzG/9wC1uImPCl2eqzKh6W/v75RLpYwkySAqi1SMN+xtzw84D4fEle4jEbHk2Hn4tnTZYP7H18Ef0ep8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658413714; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=0u9pK8qX7F3CAFSQGQt3egUVWbEcJ+dkb3mKmVnAkIg=; b=Hylucoc9/WEcV3wguOPROjyJOp2wIFl/iJFrPeqGEj9omzA1B6xmCVR+n7/H9e8a13HtingJNflGCRRwXJP3HA96Jdsj/7PL9Z0n61Q5Oq8uuJvyOBsRsG8bny+auljK3q1/ILpBiVJAm+ZdT7wGVxV/iQIU7mWPXKcAJATGlqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658413714; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=0u9pK8qX7F3CAFSQGQt3egUVWbEcJ+dkb3mKmVnAkIg=; b=nfkUZP/bEbu4xl74tQ28Ov9NUpTDPnCVJyjDO2VFFNzx+XZ0v4wP/01KxBcKy0hj qpEcsSi5UXt7trOVpWnkmuEY3Jolu00JFaTtUihQBuDVhRo2505gq8xVkkgisffSEsH DbClqsBoefVYmp9q/rLcrFqtayy6k7J4elL4uFcc= Message-ID: <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> Date: Thu, 21 Jul 2022 10:28:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 02/18] introduction of generalized boot info In-Reply-To: <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 09:11, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/arch/x86/include/asm/bootinfo.h >> @@ -0,0 +1,48 @@ >> +#ifndef __ARCH_X86_BOOTINFO_H__ >> +#define __ARCH_X86_BOOTINFO_H__ >> + >> +/* unused for x86 */ >> +struct arch_bootstring { }; >> + >> +struct __packed arch_bootmodule { >> +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 > > Such macro expansions need parenthesizing. Ack. >> + uint32_t flags; >> + uint32_t headroom; >> +}; > > Since you're not following any external spec, on top of what Julien > said about the __packed attribute I'd also like to point out that > in many cases here there's no need to use fixed-width types. Oh, I forgot to mention that in the reply to Julien. Yes, the __packed is needed to correctly cross the 32bit to 64bit bridge from the x86 bootstrap in patch 4. >> +struct __packed arch_boot_info { >> + uint32_t flags; >> +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 >> +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 >> +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 >> +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 >> +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 >> +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 >> +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 >> +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 >> +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 >> +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 >> +#define BOOTINFO_FLAG_X86_APM 1U << 10 >> + >> + bool xen_guest; > > As the example of this, with just the header files being introduced > here it is not really possible to figure what these fields are to > be used for and hence whether they're legitimately represented here. I can add a comment to clarify these are a mirror of the multiboot flags. These were mirrored to allow the multiboot flags to be direct copied and eased the replacement locations where an mb flag is checked. >> + char *boot_loader_name; >> + char *kextra; > > const? I want to say const will not work based on usage, but I will double-check. From xen-devel-bounces@lists.xenproject.org Thu Jul 21 14:42:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 14:42:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372849.604845 (Exim 4.92) (envelope-from ) id 1oEXNf-0002Ee-1W; Thu, 21 Jul 2022 14:42:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372849.604845; Thu, 21 Jul 2022 14:42:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXNe-0002EX-UU; Thu, 21 Jul 2022 14:42:22 +0000 Received: by outflank-mailman (input) for mailman id 372849; Thu, 21 Jul 2022 14:42:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXNe-0002ER-5w for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 14:42:22 +0000 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50d40f42-0903-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 16:42:18 +0200 (CEST) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 07:42:16 -0700 Received: from amcguire-mobl1.amr.corp.intel.com (HELO ubuntu.localdomain) ([10.212.41.210]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2022 07:42:14 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50d40f42-0903-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658414538; x=1689950538; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=upWoArWDMjRP7S0misRd4b8EMXo9ZmgrhAHS7PyA39Q=; b=mBAMuXiV5Li8v/plusqd3f8N8Ccibljx0ga0469Ar8og2wT3bxYpLEgQ hRn6B16+FptvULCCEGqrd2+1C2W3tzuCM3ZY7mj+wPmvYCebqpZNNPKJJ rx8eYXxV+hcky2QcSsmSI6Ikpsdalh0KXI4+Jy/Ea3B7Kpg2dgS2huix3 P8onmJHFq/4UvZ8or9lI93O/5oU5UoiI4U8Av+crpFw00f30pIXU/x7dG AhqGe4cKi0sMqVTVNVzx1BC3U30FFg2kkaKXxNlcTSnPyPjo7fY1pyiUd WPfOzar3C9/JLVSgV9Rwx8/JJlKoy1t80ttS2ZiIf2EEPjPaQw/5nauaS Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="351055309" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="351055309" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="656773623" From: Tamas K Lengyel To: xen-devel@lists.xenproject.org Cc: Tamas K Lengyel , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: [PATCH v3] xen/mem_sharing: support forks with active vPMU state Date: Thu, 21 Jul 2022 10:42:05 -0400 Message-Id: <249a26c7c469ee913af5c3b367917b2e4bd4d86e.1658409173.git.tamas.lengyel@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently the vPMU state from a parent isn't copied to VM forks. To enable the vPMU state to be copied to a fork VM we export certain vPMU functions. First, the vPMU context needs to be allocated for the fork if the parent has one. For this we introduce vpmu->allocate_context, which has previously only been called when the guest enables the PMU on itself. Furthermore, we export vpmu_save_force so that the PMU context can be saved on-demand even if no context switch took place on the parent's CPU yet. Additionally, we make sure all relevant configuration MSRs are saved in the vPMU context so the copy is complete and the fork starts with the same PMU config as the parent. Signed-off-by: Tamas K Lengyel --- v3: address review comments v2: make some things conditional on CONFIG_MEM_SHARING add stub function on AMD to vpmu_ops to simplify allocate context calls --- xen/arch/x86/cpu/vpmu.c | 14 +++++++++- xen/arch/x86/cpu/vpmu_amd.c | 12 +++++++++ xen/arch/x86/cpu/vpmu_intel.c | 32 ++++++++++++++++++---- xen/arch/x86/include/asm/vpmu.h | 17 ++++++++++++ xen/arch/x86/mm/mem_sharing.c | 47 +++++++++++++++++++++++++++++++++ 5 files changed, 116 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/cpu/vpmu.c b/xen/arch/x86/cpu/vpmu.c index d2c03a1104..cacc24a30f 100644 --- a/xen/arch/x86/cpu/vpmu.c +++ b/xen/arch/x86/cpu/vpmu.c @@ -336,7 +336,19 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs) #endif } -static void cf_check vpmu_save_force(void *arg) +#ifdef CONFIG_MEM_SHARING +int vpmu_allocate_context(struct vcpu *v) +{ + struct vpmu_struct *vpmu = vcpu_vpmu(v); + + if ( vpmu_is_set(vpmu, VPMU_CONTEXT_ALLOCATED) ) + return 0; + + return alternative_call(vpmu_ops.allocate_context, v) ? 0 : -ENOMEM; +} +#endif + +void cf_check vpmu_save_force(void *arg) { struct vcpu *v = arg; struct vpmu_struct *vpmu = vcpu_vpmu(v); diff --git a/xen/arch/x86/cpu/vpmu_amd.c b/xen/arch/x86/cpu/vpmu_amd.c index 9bacc02ec1..58794a16f0 100644 --- a/xen/arch/x86/cpu/vpmu_amd.c +++ b/xen/arch/x86/cpu/vpmu_amd.c @@ -518,6 +518,14 @@ static int cf_check svm_vpmu_initialise(struct vcpu *v) return 0; } +#ifdef CONFIG_MEM_SHARING +static int cf_check amd_allocate_context(struct vcpu *v) +{ + ASSERT_UNREACHABLE(); + return 0; +} +#endif + static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { .initialise = svm_vpmu_initialise, .do_wrmsr = amd_vpmu_do_wrmsr, @@ -527,6 +535,10 @@ static const struct arch_vpmu_ops __initconst_cf_clobber amd_vpmu_ops = { .arch_vpmu_save = amd_vpmu_save, .arch_vpmu_load = amd_vpmu_load, .arch_vpmu_dump = amd_vpmu_dump, + +#ifdef CONFIG_MEM_SHARING + .allocate_context = amd_allocate_context, +#endif }; static const struct arch_vpmu_ops *__init common_init(void) diff --git a/xen/arch/x86/cpu/vpmu_intel.c b/xen/arch/x86/cpu/vpmu_intel.c index 8612f46973..b91d818be0 100644 --- a/xen/arch/x86/cpu/vpmu_intel.c +++ b/xen/arch/x86/cpu/vpmu_intel.c @@ -282,10 +282,17 @@ static inline void __core2_vpmu_save(struct vcpu *v) for ( i = 0; i < fixed_pmc_cnt; i++ ) rdmsrl(MSR_CORE_PERF_FIXED_CTR0 + i, fixed_counters[i]); for ( i = 0; i < arch_pmc_cnt; i++ ) + { rdmsrl(MSR_IA32_PERFCTR0 + i, xen_pmu_cntr_pair[i].counter); + rdmsrl(MSR_P6_EVNTSEL(i), xen_pmu_cntr_pair[i].control); + } if ( !is_hvm_vcpu(v) ) rdmsrl(MSR_CORE_PERF_GLOBAL_STATUS, core2_vpmu_cxt->global_status); + /* Save MSR to private context to make it fork-friendly */ + else if ( mem_sharing_enabled(v->domain) ) + vmx_read_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + &core2_vpmu_cxt->global_ctrl); } static int cf_check core2_vpmu_save(struct vcpu *v, bool to_guest) @@ -346,6 +353,10 @@ static inline void __core2_vpmu_load(struct vcpu *v) core2_vpmu_cxt->global_ovf_ctrl = 0; wrmsrl(MSR_CORE_PERF_GLOBAL_CTRL, core2_vpmu_cxt->global_ctrl); } + /* Restore MSR from context when used with a fork */ + else if ( mem_sharing_is_fork(v->domain) ) + vmx_write_guest_msr(v, MSR_CORE_PERF_GLOBAL_CTRL, + core2_vpmu_cxt->global_ctrl); } static int core2_vpmu_verify(struct vcpu *v) @@ -443,7 +454,7 @@ static int cf_check core2_vpmu_load(struct vcpu *v, bool from_guest) return 0; } -static int core2_vpmu_alloc_resource(struct vcpu *v) +static int cf_check core2_vpmu_alloc_resource(struct vcpu *v) { struct vpmu_struct *vpmu = vcpu_vpmu(v); struct xen_pmu_intel_ctxt *core2_vpmu_cxt = NULL; @@ -461,11 +472,18 @@ static int core2_vpmu_alloc_resource(struct vcpu *v) goto out_err; } - core2_vpmu_cxt = xzalloc_flex_struct(struct xen_pmu_intel_ctxt, regs, - fixed_pmc_cnt + arch_pmc_cnt * - (sizeof(struct xen_pmu_cntr_pair) / - sizeof(*core2_vpmu_cxt->regs))); + vpmu->priv_context_size = sizeof(uint64_t); + vpmu->context_size = sizeof(struct xen_pmu_intel_ctxt) + + fixed_pmc_cnt * sizeof(uint64_t) + + arch_pmc_cnt * sizeof(struct xen_pmu_cntr_pair); + /* Calculate and add the padding for alignment */ + vpmu->context_size += vpmu->context_size % + sizeof(struct xen_pmu_intel_ctxt); + + core2_vpmu_cxt = _xzalloc(vpmu->context_size, + sizeof(struct xen_pmu_intel_ctxt)); p = xzalloc(uint64_t); + if ( !core2_vpmu_cxt || !p ) goto out_err; @@ -889,6 +907,10 @@ static const struct arch_vpmu_ops __initconst_cf_clobber core2_vpmu_ops = { .arch_vpmu_save = core2_vpmu_save, .arch_vpmu_load = core2_vpmu_load, .arch_vpmu_dump = core2_vpmu_dump, + +#ifdef CONFIG_MEM_SHARING + .allocate_context = core2_vpmu_alloc_resource, +#endif }; const struct arch_vpmu_ops *__init core2_vpmu_init(void) diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index e5709bd44a..8a3ae11562 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -47,6 +47,10 @@ struct arch_vpmu_ops { int (*arch_vpmu_save)(struct vcpu *v, bool_t to_guest); int (*arch_vpmu_load)(struct vcpu *v, bool_t from_guest); void (*arch_vpmu_dump)(const struct vcpu *); + +#ifdef CONFIG_MEM_SHARING + int (*allocate_context)(struct vcpu *v); +#endif }; const struct arch_vpmu_ops *core2_vpmu_init(void); @@ -59,6 +63,8 @@ struct vpmu_struct { u32 hw_lapic_lvtpc; void *context; /* May be shared with PV guest */ void *priv_context; /* hypervisor-only */ + size_t context_size; + size_t priv_context_size; struct xen_pmu_data *xenpmu_data; spinlock_t vpmu_lock; }; @@ -108,6 +114,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs); void vpmu_initialise(struct vcpu *v); void vpmu_destroy(struct vcpu *v); void vpmu_save(struct vcpu *v); +void vpmu_save_force(void *arg); int vpmu_load(struct vcpu *v, bool_t from_guest); void vpmu_dump(struct vcpu *v); @@ -136,5 +143,15 @@ static inline void vpmu_switch_to(struct vcpu *next) vpmu_load(next, 0); } +#ifdef CONFIG_MEM_SHARING +int vpmu_allocate_context(struct vcpu *v); +#else +static inline int vpmu_allocate_context(struct vcpu *v) +{ + ASSERT_UNREACHABLE(); + return 0; +} +#endif + #endif /* __ASM_X86_HVM_VPMU_H_*/ diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c index 8f9d9ed9a9..649d93dc54 100644 --- a/xen/arch/x86/mm/mem_sharing.c +++ b/xen/arch/x86/mm/mem_sharing.c @@ -1653,6 +1653,49 @@ static void copy_vcpu_nonreg_state(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) hvm_set_nonreg_state(cd_vcpu, &nrs); } +static int copy_vpmu(struct vcpu *d_vcpu, struct vcpu *cd_vcpu) +{ + struct vpmu_struct *d_vpmu = vcpu_vpmu(d_vcpu); + struct vpmu_struct *cd_vpmu = vcpu_vpmu(cd_vcpu); + int ret; + + if ( !vpmu_are_all_set(d_vpmu, VPMU_INITIALIZED | VPMU_CONTEXT_ALLOCATED) ) + return 0; + if ( (ret = vpmu_allocate_context(cd_vcpu)) ) + return ret; + + /* + * The VPMU subsystem only saves the context when the CPU does a context + * switch. Otherwise, the relevant MSRs are not saved on vmexit. + * We force a save here in case the parent CPU context is still loaded. + */ + if ( vpmu_is_set(d_vpmu, VPMU_CONTEXT_LOADED) ) + { + unsigned int pcpu = smp_processor_id(); + + if ( d_vpmu->last_pcpu != pcpu ) + { + on_selected_cpus(cpumask_of(d_vpmu->last_pcpu), + vpmu_save_force, d_vcpu, 1); + vpmu_reset(d_vpmu, VPMU_CONTEXT_LOADED); + } + else + vpmu_save(d_vcpu); + } + + if ( vpmu_is_set(d_vpmu, VPMU_RUNNING) ) + vpmu_set(cd_vpmu, VPMU_RUNNING); + + /* Make sure context gets (re-)loaded when scheduled next */ + vpmu_reset(cd_vpmu, VPMU_CONTEXT_LOADED); + + memcpy(cd_vpmu->context, d_vpmu->context, d_vpmu->context_size); + memcpy(cd_vpmu->priv_context, d_vpmu->priv_context, + d_vpmu->priv_context_size); + + return 0; +} + static int copy_vcpu_settings(struct domain *cd, const struct domain *d) { unsigned int i; @@ -1702,6 +1745,10 @@ static int copy_vcpu_settings(struct domain *cd, const struct domain *d) copy_domain_page(new_vcpu_info_mfn, vcpu_info_mfn); } + ret = copy_vpmu(d_vcpu, cd_vcpu); + if ( ret ) + return ret; + hvm_vmtrace_reset(cd_vcpu); copy_vcpu_nonreg_state(d_vcpu, cd_vcpu); -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 21 15:16:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 15:16:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372859.604868 (Exim 4.92) (envelope-from ) id 1oEXuM-0006Uj-Tb; Thu, 21 Jul 2022 15:16:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372859.604868; Thu, 21 Jul 2022 15:16:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXuM-0006Uc-Qf; Thu, 21 Jul 2022 15:16:10 +0000 Received: by outflank-mailman (input) for mailman id 372859; Thu, 21 Jul 2022 15:16:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEXuL-0006UV-S5 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 15:16:09 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 08a1a8a8-0908-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 17:16:04 +0200 (CEST) Received: from mail-bn1nam07lp2041.outbound.protection.outlook.com (HELO NAM02-BN1-obe.outbound.protection.outlook.com) ([104.47.51.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 21 Jul 2022 11:15:57 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5113.namprd03.prod.outlook.com (2603:10b6:5:1f0::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 21 Jul 2022 15:15:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 15:15:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 08a1a8a8-0908-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658416564; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=ytzgrtUFFx3LKktpPwq4XSpiq6w8QlT5XznI9x0gHYM=; b=BQcMnHnTpBzVvBvd2ZpmIUswxaB04zZ3WGPtTtM3/WM9wiuD9CFxjQ0g B8Z5LrRDEhcpkWnJnYQV+q/T457yxxdXMPrMx2jcao4ICArcP7Qg2GAjm OulRv5CiBgB2CuKjx6bUjYsA5i8naFV7M13q6cdTOhSdqdYaEua3xZjhc 8=; X-IronPort-RemoteIP: 104.47.51.41 X-IronPort-MID: 75627852 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:iIwHv6mmA4Nh/Y3PwQz05hLo5gxzJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIWCGiGOv6LN2SkKNAlYI3j/BwH65HVy9RhQFE/pCoyQyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466r4GhwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2kPY5QB8OErWVpX3 t8qGG1RUxOllrq5lefTpulE3qzPLeHNFaZH4DRK62icCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAB7g7MzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLaryz22b+Sx0sXXqo5ToG5z/1b3Wa633cCFEQQTgPigsWm3xvWt9V3b hZ8FjAVhbQ78UWwCN3wWRKprXqsvxgAVt4WGOo/gCmdx6yR7wuHC2wsSj9adMdgpMIwXSYt1 FKCg5XuHzMHmL+fRG+Z97yUhSivIiVTJmgHDQcbSSMV7t+lp5s85jrNU9AlFqe2h9/0HDjYw jaWoSx4jLIW5eYI2ru6+xbbgjuqjpnPUgMxoA7QWwqN8gp8bZWNe4+s5F7U/PtEao2eSzG8U GMsnsGf6KUEC8iLnSnVH+EVRun1vrCCLSHWhkNpE9857TOx9nW/fIdWpjZjOENuNcVCcjjsC KPOhT5sCFZoFCPCRcdKj0iZUqzGEYCI+QzZa83p IronPort-HdrOrdr: A9a23:Xc+6nK6i4rMv77nyXwPXwA7XdLJyesId70hD6qkQc3Fom62j5q STdZEgvyMc5wx/ZJhNo7690cq7MBbhHPxOkOos1N6ZNWGLhILPFuBfBOPZqAEIcBeOlNK1u5 0BT0B/YueAcGRSvILBzySTV/wb57C8gceVbeW19QYQcem9AZsQkDuQCWygYzNLrBEtP+teKH IFjPA33QZJfx4sH72G7ilsZZm6mzXT/qiWGiI7Ow== X-IronPort-AV: E=Sophos;i="5.93,290,1654574400"; d="scan'208";a="75627852" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+OuQQH48OQA5KoX1S3L1+2p/E8GCAk6QTQ3SIzPSXTzESeoUkKwG086SFaKVzcAJS8rE2igxACv4qK8oQjGtphJWJ/3r6c/VyVQn9vA3zHpI4r97bfjeTsPJyp155VNumyWXJVJX4k/8KULy6i1K5iFHZv+ZonkmrmrellsR4pnGQb4SBMoAZ8/2/QTXBOsktiBX3j7cydhY0kAOx+afHg7emcUEgKhmPuSsxR+stXV3uuYOdvi3r0+u7CrLHgfwTeJTQuaLUGPOb3eHaJebY8+e+iL0EMioGaIaJmjhQJzxbDZCXeQHpnn9rzHmUgZ2jQTHxyIUY3aH739P1iTDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytzgrtUFFx3LKktpPwq4XSpiq6w8QlT5XznI9x0gHYM=; b=NJxo1LvxxM0RXvY3JCv+ZBEUZKfFJdypCqOrWioqNufLgTFg/udR94+UcWHHh1PmJCJoWu2ord8Q8RO3koszBAJInYqNzlv7Su87KPxxMzjD4d2wvYxwRFVxHFaZsqN4QpRdv8uNsHgcArzUaPMfBl1PHuwIbtJOkYP6T5Uie8NPF+VzRtCglHd8fElcWGoOs5w4J1JQcQz5Yz3du5Og/bK+ioBvzjvbGqz3fMZv7mnXqDh7BVkwuFSNNYlTs/w6GK92wx9ZfHqysI6L22EskwUXeRuak/jO2xdjh0ZD6rLnL8RTiwj50GsD1NCCPBMIpapVPBOrCl+eRDwMQHfQFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ytzgrtUFFx3LKktpPwq4XSpiq6w8QlT5XznI9x0gHYM=; b=FE3vnDL0pUxYx41OJhQRGuPA8dY7KChjPq7biRfFcp6Hi/vB5Vk0qt4cypj7Gb61iMXcdxagZ+JdcpdMlkNi6cDobGGVGm3SnSHlhWvNu7cDTMSWonOyceppfVF4n2ub/3eXbiP/b2mbxB/v8bkNd1D1W50gd8XXreDxQ+OdUKw= From: Andrew Cooper To: Tamas K Lengyel , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , Tamas K Lengyel , George Dunlap Subject: Re: [PATCH v3] xen/mem_sharing: support forks with active vPMU state Thread-Topic: [PATCH v3] xen/mem_sharing: support forks with active vPMU state Thread-Index: AQHYnRAaaj668bQ3XUia6H9jz2csv62I72oA Date: Thu, 21 Jul 2022 15:15:54 +0000 Message-ID: <622e0fec-c041-50ef-661d-1d541db9ef78@citrix.com> References: <249a26c7c469ee913af5c3b367917b2e4bd4d86e.1658409173.git.tamas.lengyel@intel.com> In-Reply-To: <249a26c7c469ee913af5c3b367917b2e4bd4d86e.1658409173.git.tamas.lengyel@intel.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2f349524-82f9-48c6-22b0-08da6b2be825 x-ms-traffictypediagnostic: DM6PR03MB5113:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tCX2KvmFu1n1uKL/nPV1kp7gxkrVX1ZHzEAKyZdyvheEsuySY8Lw7dW1sDhV6O6KK4Mvrm6hstJ8vo5dpxkNt4EdGxTvTY9sQk2R2jk5YVVfnoYUiDWFEBDBvxms1rTaI2CilfCPSR01wsgCEAmlsnsTQYZmEY+rfCZNA+zdDkY1814OI8HGeboY3td4fvZrhlnWngaiUqr8Jsv30diifP3foXPPnGMJ/04ps3cO/Kc2CT5wq4BHqGzdbKwa3TcY3v8s8wd8RkrRsqozIkjVGthNuW1OkBgsgbkRIFp6ixZ3okCaewpKG1+HiPHQ8/usYpNRFmD5VC4D++02m++Z6RhPCaYlf9KRh6N5eV0xJiCcS+sb9APLGv6xzBqE0/UHhbX55VkY79cEC059BpRkRsB5uvDIoLkkqt6r35fOD5TSsSM/SK2pL5g7XruPNWXf2s5GkNJKZujcXIGcLxvit+jMegZTzLFjaTGuO+cacnV3urGaJ0zw+HjiHQJNpVoPc5+v+yap3XqAGb+FXxxCKTUpqzcyfvOofFNXw52OMvg/q0Sy4tP6ndgYtnCIov74PBgxfnHsltp9fBp3AkxBLKU3LtVAJ6s+1bitAH2l5/NhNUgZMGDePTPfAH2PDvi++lyoYFIel3ug7t/C+x8a7HHVF+0gTYzcJozjo19Zq2EtJofEa+MSsWCh24ur2/bFFPp4ZGUIkk9AJDH+60/O5wOhneBzivSx1+yRfHBfKw6xGLUI1odRZJlRNSWB2xTuh55b7mhWitRizq5I/RL26t99CjkTB3WbqQsx25p9272rgd8H7qAmdkBl7J2HO63bOM11iRcE3tmfGeJYkuhLOer0sa1j6lMmgWqKBJ/WbtvRieK8I/BCtDxjIpBK9FmC x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(346002)(39860400002)(376002)(366004)(31686004)(2616005)(110136005)(186003)(107886003)(26005)(86362001)(38070700005)(38100700002)(6506007)(54906003)(31696002)(53546011)(6512007)(41300700001)(66476007)(2906002)(91956017)(76116006)(66446008)(66946007)(4326008)(36756003)(478600001)(71200400001)(5660300002)(82960400001)(8936002)(122000001)(316002)(8676002)(64756008)(4744005)(66556008)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V05zTDRBUzRsL2pDVVhwWFRyWkF5T0QzWGFFOFBDM21jSCtiR0lvSzdPNzQr?= =?utf-8?B?enNLN3BJWW12RFdyeUp5WFdZbjcyYXRWS2VrV2VjVE9kd1U5OGNmVTB6c0Nh?= =?utf-8?B?NFBlY0YxakpzV21EVEZVb1BKeW5hQ1plVVlnREgrUDZQY0xKQVh4cmF4cVp1?= =?utf-8?B?eFl2bkxCRkRCbHNxVUh6a3NOV2lRdzNrL1pKVjd5Q2tGZ25sMzJkL0VXaVJM?= =?utf-8?B?MFBDcU9TYzYrUTJSZEt6aHRwKzlEa2Q0WHBoVVFvU1Z3WTAwOUpIeTQ3aFNu?= =?utf-8?B?S3MvNWNIeFZlQzd6eU53MUpER0NUTzBIenRaa3V5bEtQeStSRVVHTmloQzRt?= =?utf-8?B?ZDZWSXJudk5ZaG5GUitMcGhNRzk5Tk1QN0ZTeklDLytMZWRDZm1xbU5Ibk9X?= =?utf-8?B?SnBxY1pQN09ub05tckU0REJLNUtBTnhGUzB5OFpDZGU4Zm00cjd3ZDQvM1Zp?= =?utf-8?B?a2phRmVwRTQ0Z2Irbks4VHRTU2FLcmNUMlZkYnBKZVNBQ2gwY1hzd1BXblR2?= =?utf-8?B?V3VnR1BDWkhMek1VNjlGREVaU21aaEx5aXdyeSt6ZzN6REEvOEdreG5oNXpj?= =?utf-8?B?cVc2U3pQQ2wrS3hNc0k2UGZKbXMxNnZ4MGd4amYwb1AzVUVwUVVMNXNzeHdY?= =?utf-8?B?MndQeDFFOHlhTGdSd0lNNVVoMnE4ZlhLaGU5VzdoL3Uxc3R5N0VhTDF2c2hC?= =?utf-8?B?YVFwQkFCUVZPcVkvS1pacS9ZU2tpUmh4T0dQOUE3OXV3OHpLR3VRSkJBUTk3?= =?utf-8?B?V2NPN2pxSG9WbGpUcFlwcWxtQXlPNUpVWkRxcktQajBNNGs5TWJrWmxWUVU3?= =?utf-8?B?OXNNNTFodWFMc3B4QUdjZWF4SHFYa0pCS3dUS1pvM0t1M211NnJBd2c5enhp?= =?utf-8?B?bjNPOVArOGoySlM2aHFMNEhlbWpXWU9rODdhblpXY1NnTVFCM1NkMzVVWnBj?= =?utf-8?B?K21xQXU5VFF2Q3doSE15cWEzckRhVm9sWEpwNExxMUVxdDhBWXRSMm1iVGYv?= =?utf-8?B?bFBHckJSRU4wSWxxUzBnYVdzeExncnpKakw1cnBXbkE3bHpJaStwYk9XZnR0?= =?utf-8?B?ZFE1OFNXbTNxNExXUVBvckZPYXA4MDQxUCs0dFF6TzMvNUtGQzBRa3VlaWds?= =?utf-8?B?VkV4VktRb2cvUzVBa3BmRkpDNWcrSUl3RkNiYmFuRUFMMk1pN3ZFNnZ4YzUy?= =?utf-8?B?ejhOYVU5ZjM1QS9YaGpXcUE0SCtKTTY2aXN6QldNRWtMZ0N2RHVxVnI4di9G?= =?utf-8?B?SXFRdlAxYjh6NWxKcXBwM1RJMXNTTVhnVysxZ3FmN0hNenE1TDlvazhZeFVV?= =?utf-8?B?U2JHZGdoNmpFT3FBZGFlTnE2TlNYVmZOaC92aUdqRktuTHV6dC9IbzRIN0d3?= =?utf-8?B?bTVadHFGdkpvTGxFSjhZZDNwZERwbVp2SC9Kd0ZSc0RtVnJxVm9nTlEzYy8z?= =?utf-8?B?YjN2MDUyb1pCZktBakhvdXJZbHFoSVlWbFVwZU0zYTlESGJtNHIzSXVjUFIz?= =?utf-8?B?cW9xRVRpTFJqMVZhZk1Dc3NFL3RZL01hanVadjgyKzF6enUxRTVKeVRGUTBu?= =?utf-8?B?dHlhRFJZdHBja0laQnhlblFHVWJoSUFtNHNodHdhVGZmTXdOZHRGYS9YKzBC?= =?utf-8?B?VHhOVG51dktpNDdKMTZxN2Z5dTUrc0ozUHZPN2tlVWZuUXptSFp5V0JOcFNJ?= =?utf-8?B?MTQ3TGVPbytzNHdoMVc5and6WUY0Yy90UTM2amhUK3VKWTBpY2Z3dkc1TEIr?= =?utf-8?B?Zm43ZnRGNE1CS1BVM0FTUE1Jb3EwOXh1dWRsQkh3bTM0Uy8rYms3amN6bjE1?= =?utf-8?B?QkFMVllsWms0a3JNdERSZ2QzcUZqV3pvc094R2M0Rk8vZFBJajBKZGdGdHNn?= =?utf-8?B?R1ZnSTN6cEV3SG5sa0hwMi93TUs0TUxLcVJKYVVwNFUwa3Q3UW4vQmY3SnhW?= =?utf-8?B?R1FtMGJEbzVYcWp5eVZ4WDBtcncyVnJENVN6d21rbEl2K1psRTdRSldXRXM2?= =?utf-8?B?Ni9mRy9RUW00RG5WV0hES3A3djVxRUFmTXBCcXZnSm4vM0ZZVTlvbVRHd0xN?= =?utf-8?B?WUU2a0dHb1RoSzlWVld1U1N0OTVIaFZCc0tISFlHMHZEQ3hEd2Y5TkU5NFJ3?= =?utf-8?Q?owYZlswqc3mFYVAgYqV0bYpOP?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2f349524-82f9-48c6-22b0-08da6b2be825 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2022 15:15:54.8547 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IZz4wyrqRIp14AU9k88QkAXZS22rpGj67Sahb8JmKYG7QwgDJw58arSKqkLWCPGGMEKUbc/vAel5XH0nbeq3xHxMNblOPL3neE6tmRcpWGE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5113 T24gMjEvMDcvMjAyMiAxNTo0MiwgVGFtYXMgSyBMZW5neWVsIHdyb3RlOg0KPiBDdXJyZW50bHkg dGhlIHZQTVUgc3RhdGUgZnJvbSBhIHBhcmVudCBpc24ndCBjb3BpZWQgdG8gVk0gZm9ya3MuIFRv IGVuYWJsZSB0aGUNCj4gdlBNVSBzdGF0ZSB0byBiZSBjb3BpZWQgdG8gYSBmb3JrIFZNIHdlIGV4 cG9ydCBjZXJ0YWluIHZQTVUgZnVuY3Rpb25zLiBGaXJzdCwNCj4gdGhlIHZQTVUgY29udGV4dCBu ZWVkcyB0byBiZSBhbGxvY2F0ZWQgZm9yIHRoZSBmb3JrIGlmIHRoZSBwYXJlbnQgaGFzIG9uZS4g Rm9yDQo+IHRoaXMgd2UgaW50cm9kdWNlIHZwbXUtPmFsbG9jYXRlX2NvbnRleHQsIHdoaWNoIGhh cyBwcmV2aW91c2x5IG9ubHkgYmVlbiBjYWxsZWQNCj4gd2hlbiB0aGUgZ3Vlc3QgZW5hYmxlcyB0 aGUgUE1VIG9uIGl0c2VsZi4gRnVydGhlcm1vcmUsIHdlIGV4cG9ydA0KPiB2cG11X3NhdmVfZm9y Y2Ugc28gdGhhdCB0aGUgUE1VIGNvbnRleHQgY2FuIGJlIHNhdmVkIG9uLWRlbWFuZCBldmVuIGlm IG5vDQo+IGNvbnRleHQgc3dpdGNoIHRvb2sgcGxhY2Ugb24gdGhlIHBhcmVudCdzIENQVSB5ZXQu IEFkZGl0aW9uYWxseSwgd2UgbWFrZSBzdXJlDQo+IGFsbCByZWxldmFudCBjb25maWd1cmF0aW9u IE1TUnMgYXJlIHNhdmVkIGluIHRoZSB2UE1VIGNvbnRleHQgc28gdGhlIGNvcHkgaXMNCj4gY29t cGxldGUgYW5kIHRoZSBmb3JrIHN0YXJ0cyB3aXRoIHRoZSBzYW1lIFBNVSBjb25maWcgYXMgdGhl IHBhcmVudC4NCj4NCj4gU2lnbmVkLW9mZi1ieTogVGFtYXMgSyBMZW5neWVsIDx0YW1hcy5sZW5n eWVsQGludGVsLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 21 15:38:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 15:38:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372867.604880 (Exim 4.92) (envelope-from ) id 1oEYFT-0001Ng-Pv; Thu, 21 Jul 2022 15:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372867.604880; Thu, 21 Jul 2022 15:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYFT-0001NZ-Ly; Thu, 21 Jul 2022 15:37:59 +0000 Received: by outflank-mailman (input) for mailman id 372867; Thu, 21 Jul 2022 15:37:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYFR-0001NP-8k for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 15:37:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60082.outbound.protection.outlook.com [40.107.6.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 161b709c-090b-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 17:37:54 +0200 (CEST) Received: from AS9PR06CA0508.eurprd06.prod.outlook.com (2603:10a6:20b:49b::32) by DB6PR08MB2885.eurprd08.prod.outlook.com (2603:10a6:6:1b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Thu, 21 Jul 2022 15:37:50 +0000 Received: from AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:49b:cafe::43) by AS9PR06CA0508.outlook.office365.com (2603:10a6:20b:49b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Thu, 21 Jul 2022 15:37:49 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT042.mail.protection.outlook.com (10.152.17.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Thu, 21 Jul 2022 15:37:49 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 21 Jul 2022 15:37:49 +0000 Received: from c493aea34d7e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B5B7212F-22AB-4E86-87C4-CC63339E1728.1; Thu, 21 Jul 2022 15:37:42 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c493aea34d7e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 15:37:42 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by VI1PR0802MB2559.eurprd08.prod.outlook.com (2603:10a6:800:b4::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.19; Thu, 21 Jul 2022 15:37:39 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 15:37:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 161b709c-090b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ZdUQE9JF2kWzGremfRZWJq6XQ9sOQ+rQSt7hgL9tzYdhNhHORmmTWMgTqcWpceJRKRFsVhMl6/AzHAfIP5KuKls3m7w1iumEcL9oI9T9r1NEiVWWmcEJylS22Et/y5kYbOLEsGJj+xznEx1g5UCeNe4TdhgsqU7of13Tri4assQqrw/oc9fP6g8Y+5lWm9XnhSrE/sVSDwifBWJWrtOfvGgmFRNafrpjOOgUFg9Ua9aam3+t//AkzsR0MRtXSel94hVBE7oRqkYzLpBvXbuN0PNV9P+BAgGq7wOK5jaTqQ59x2IfjVrH+e4nxg65KbTG4a5uDzAf5EpsGTxtPM6IsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghJcKzz8onE9Vr5Ev7HNN7ipqiTT42ctbkRbF9KRJPI=; b=RTWuUf/hsSeUXCKlVyyVOqo36Z8ekR4scfPlJToAC20JHUqUytw3aDFptNMiEc6j/Fkndi4xQuL9gD92ef4gc+K2KIgZ0okcLf/FU7g7cnB34VcKC4voG/p6W6pE61W0QncWJ72by2c+CoIuF+dCNNEJyrG2PPwUJcijRosGuNdzHO45yd4P7cmKeUZIPuqv3st5mZzAQg4JT79XoYhuZjOpOcVUd1vnrwqsy6YmxzHoXJH9GcbcfCUbPrFQ+OeM67ddJgh4M22m1EiToczPkMLiZiQcRSw6b5YQfr0tIygaEQXu3Qg/xaihhVw/ycZDqjGdKy7JD2Ep9fhR+umoEA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghJcKzz8onE9Vr5Ev7HNN7ipqiTT42ctbkRbF9KRJPI=; b=oH4NEkQLKWLQtRq8sQmLeyI5faMd1orvbp6rQmc61gKaRihex7YlbpiqYhfVYHxCqzkTLexEiY1af7vdE/qbVHnaKgT2MuIaq6MJnOOOIcHxnm4xM4II2TL7rM9OQ7IhxBjuExi7JGmqoce7p7tRuzLrohPjHmytKnEpSUZdZCI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d706cce1b2170696 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eUDPRLDPtC4RCUj1MOWiGBQXLCmGyrVN9QFXQYAcqtNmfc4oUez0U3Xeox/8Beq5xu7Tdxw7fmfx7Mt2gpxpNA8BI7R0AGFKXJhixDk+aSBTKmocoCzqrOIk3DAmjWKfGRb4iiHk3FL2lJjTm7LE9AoSLeIHzyJprs2X8lw9kA8surXgt4Kv0MUbuh4ZA98BHeMA5uv5poJvBIZOWfu7/cw82KkQcSdrL5E3pZKAPEmi7PzxAwiFd1Fnyw9F4byuNQsaZYOoulLymZOc4VtWVNM4SiFf1KfKDYxsKk6enUQrjWbZTQZIPSC8GguSGdUV9rtvanXWDa9IhkxF5hVokA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghJcKzz8onE9Vr5Ev7HNN7ipqiTT42ctbkRbF9KRJPI=; b=NG05nCQc4aqTuLPfG52GDDh753pRFBDgBtxbPoIhPf1UI1jFbULWtnDU8/IRyV8EdJy6VQSeHxSC01L/fKBpoTYBsmJy40RAc0p1f+1ivySwj/8YCUCQ1unUnMmg/oCSnFX4w2mfLvkdztrvv4xStNf6aaqb3etvlfJXS6jtOJzfPe0oL1NvfYxXDw2CuBW42v/RcTP7KNkWU/cdoPaX232Jw0FU9IGmyBj675wQU80ltNix59rJA1NKVgwpxuzPLoa9gJ4jTGbdPa8Hmd2YSS97GprbQv+GovEguvxW6kLpnixj6ix1jUipIKTBNMlQjeb/TiJ2aK+desNisqczgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghJcKzz8onE9Vr5Ev7HNN7ipqiTT42ctbkRbF9KRJPI=; b=oH4NEkQLKWLQtRq8sQmLeyI5faMd1orvbp6rQmc61gKaRihex7YlbpiqYhfVYHxCqzkTLexEiY1af7vdE/qbVHnaKgT2MuIaq6MJnOOOIcHxnm4xM4II2TL7rM9OQ7IhxBjuExi7JGmqoce7p7tRuzLrohPjHmytKnEpSUZdZCI= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AAgAAEsgCACtZcgIAAFXWAgAGspoCAAAsFgIAAI8AA Date: Thu, 21 Jul 2022 15:37:39 +0000 Message-ID: References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d3c6801e-0091-4dfa-bc48-08da6b2ef7ab x-ms-traffictypediagnostic: VI1PR0802MB2559:EE_|AM5EUR03FT042:EE_|DB6PR08MB2885:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: usW4p0QtsxruVzT5z4KuEjS9Ne2UH9JUO35BezAcKDVjCi5lgULT/8gro+vNwxUNUqMwnxQdtXjXf7wI/w15Ct0OJSnSWCAd3GKcuCZ32Exd2khtgKjP/puS0v/NuChA/RKnyRJ1NnL6Pa9KYqylCwwOEuUsi5ySsrX2hoBTbwkj4Aw7eVvQrZNJ/a7dnJrgcqX2N7+QD7fs/9sKb027rV0RCtgVPIji7ip/Qk2kHjbWQi5fmNr5vf5sfJ/LKIQt3vVTXckCmIg5m6d/JbT+toUTzL7aqhAsvxbEQllyPoPBUrTbmkaqNdVkX+DZGzMOJPLTG7nhFf3zE9oL6296Jo5lusmBqe7fVosqlZ65aTQknVVDIaoO7liIZ2sgziXvPK5UKqOvxtCuEYdRF7TjrxTPROJgZLQ/Fh36r8hbz/CghQ22Y3DNHGXD1qG9UhQE+F6+wU/TZ4gihUGhpZzDiZOtkc8rP2EMpSCBr+Meej0iKnjNN5mgsagRrMdLVykCdlfquU4PshGeEFZfsVoLG+mCDkQlDQfNDzZVylSkHXpUlURT/tr2NThLfbOSRW3ytSeTQavf/izvG9n+j2Ef2gxzaIOFl8DVOE5ZvvdqlFl5nioFxhaQoTTdRplFIcbnM39i3RW1iBZFPATAOoJ5oHXH+Z51RnosCLJ8M/QR0Yt0bAD6+6l0++vxfcbAPFaPQG9GumjVNKUBz0bcEx4Tmyco3FKuQFw61GyESxS7OzhL/vFdtBX75Gg2vdM+cnBQhH3V075n5J2p+MLIH9UJteblSnInVQS4wQjqyD7hsloBtJorWXLKXgIn9Yc6zI5GGU64bmWp9iA3l1rk0xpx0w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(366004)(136003)(39860400002)(33656002)(6512007)(6506007)(53546011)(54906003)(6916009)(2616005)(26005)(36756003)(41300700001)(71200400001)(316002)(186003)(6486002)(478600001)(83380400001)(8676002)(66446008)(66946007)(4326008)(66476007)(64756008)(66556008)(2906002)(86362001)(76116006)(38070700005)(122000001)(8936002)(5660300002)(38100700002)(91956017)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <957630487271DA47B1C2D7D07F406037@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2559 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ccef06d9-3eec-4f4b-5c01-08da6b2ef1af X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jmt+pQ8+7tnBDW+REQyfeslslo0BiX3NqfoET/TZ9crDBOzxdHXnNJXOvzVLNiJsfaNhLrDf66Vcd/Q5O1Kx/NWZFNTprrQaP5xk47RUudQiBQEz+CGWr+mogsQmGXThH+jrqpTzCB5hVyFMTuJVGqnIkFymVoEAB9LpIXDvUaCaODuNpcmC56+dFB3nXFXUWYgRtbOUMW1MFHVdkHnqX5nA2HsnPImKx8QlkJMLTD1OH9sp9kwDHv21DJVQjr5lCLBDcxwR1wY4J3omndTPEHwnSIvwGgYpEWpiANlFwgPh/vxWwE07W0iVpAYgTXS7ZFTxkLsw/XtEbLX1DfgUwKAyQloonzbTcLlkJ1MwUO3K5gY3SCzQSVo7Mm9kM5e5IOON1m6NDnRCVT8h6akH8OIEdUYgrPBpuDD9aR8OpiAtkRdVwx2CSaLB50rErx/oz+XAsM12i0AWPRtrnNnlrm3ydNQyFajIUKpJhn3oDsu7/uC74oUqLzAf0Gnx7EI+u0vNlX+oyuSwyQJ2ksS5ZYGLm2FQuAtdj06CXkJ4MfRYxXGpPitTrGPLCvnvh0Rx9dnjSQflGpy8wEhOTDK5LnVFql4fLIm4PNkZQC8Q+NaDO3i5Ki4197ZShv7ULNkQd3sQ+DPxZaSr1DFGuUz/a0aQVeZpEv5vRcZ4JkWlW24N/liVUVx0b5IpepwVHz6vgTvwAodaYXvwx2xdT3mN3muiIVAx9bWuyc+VCu3YM11qOACeTGt+CVpylb6T8MvqEZUuBO1kOOiHt2jtsaWAevX3Mnna+ACJqM1TUdloQoebFEauAhpbUH/1tJGcXgA8 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(40470700004)(36840700001)(46966006)(186003)(82310400005)(82740400003)(356005)(81166007)(2906002)(53546011)(36860700001)(6512007)(26005)(86362001)(83380400001)(47076005)(336012)(70586007)(316002)(4326008)(54906003)(70206006)(2616005)(40460700003)(6486002)(36756003)(8936002)(40480700001)(5660300002)(6862004)(478600001)(33656002)(8676002)(41300700001)(6506007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:37:49.3616 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d3c6801e-0091-4dfa-bc48-08da6b2ef7ab X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2885 SGkgSnVsaWVuLA0KDQo+IE9uIDIxIEp1bCAyMDIyLCBhdCAyOjI5IHBtLCBKdWxpZW4gR3JhbGwg PGp1bGllbkB4ZW4ub3JnPiB3cm90ZToNCj4gDQo+IE9uIDIxLzA3LzIwMjIgMTM6NTAsIFJhaHVs IFNpbmdoIHdyb3RlOg0KPj4gSGkgSnVsaWVuLA0KPiANCj4gSGkgUmFodWwsDQo+IA0KPj4+IE9u IDIwIEp1bCAyMDIyLCBhdCAxMjoxNiBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4g d3JvdGU6DQo+Pj4gDQo+Pj4gSGkgUmFodWwsDQo+Pj4gDQo+Pj4gT24gMjAvMDcvMjAyMiAxMDo1 OSwgUmFodWwgU2luZ2ggd3JvdGU6DQo+Pj4+PiBPbiAxMyBKdWwgMjAyMiwgYXQgMToyOSBwbSwg SnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+PiANCj4+Pj4+IA0KPj4+ Pj4gDQo+Pj4+PiBPbiAxMy8wNy8yMDIyIDEzOjEyLCBCZXJ0cmFuZCBNYXJxdWlzIHdyb3RlOg0K Pj4+Pj4+PiBPbiAxMyBKdWwgMjAyMiwgYXQgMTI6MzEsIEp1bGllbiBHcmFsbCA8anVsaWVuQHhl bi5vcmc+IHdyb3RlOg0KPj4+Pj4+Pj4gSSBjYW4ndA0KPj4+Pj4+Pj4gc2VlIHdoeSBpdCB3b3Vs ZCBiZSB3cm9uZyB0byBoYXZlIGEgbW9yZSB0aWdodCBsaW1pdCBvbiBzdGF0aWMgcG9ydHMNCj4+ Pj4+Pj4+IHRoYW4gb24gdHJhZGl0aW9uYWwgKCJkeW5hbWljIikgb25lcy4gRXZlbiBpZiBvbmx5 IHRvIG1ha2Ugc3VyZSBzbw0KPj4+Pj4+Pj4gbWFueSBkeW5hbWljIG9uZXMgYXJlIGxlZnQuDQo+ Pj4+Pj4+IA0KPj4+Pj4+PiBUaGlzIGlzIHNpbWlsYXIgdG8gWGVuIGZvcmJpZGRpbmcgdG8gY2xv c2UgYSBzdGF0aWMgcG9ydDogaXQgaXMgbm90IHRoZSBoeXBlcnZpc29yIGJ1c2luZXNzIHRvIGNo ZWNrIHRoYXQgdGhlcmUgYXJlIGVub3VnaCBldmVudCBjaGFubmVsIHBvcnRzIGZyZWVkIGZvciBk eW5hbWljIGFsbG9jYXRpb24uDQo+Pj4+Pj4gT24gb3RoZXIgc2lkZSB3ZSBuZWVkIHRvIGJlIGNh dXRpb3VzIG5vdCB0byBhZGQgdG9vIG11Y2ggY29tcGxleGl0eSBpbiB0aGUgY29kZSBieSB0cnlp bmcgdG8gbWFrZSB0aGluZ3MgYWx3YXlzIG1hZ2ljYWxseSB3b3JrLg0KPj4+Pj4+IElmIHlvdSB3 YW50IFhlbiB0byBiZSBhY2Nlc3NpYmxlIHRvIG5vbiBleHBlcnQgYnkgbWFnaWNhbGx5IHdvcmtp bmcgYWxsIHRoZSB0aW1lLCB0aGVyZSB3b3VsZCBiZSBhIGxvdCBvZiB3b3JrIHRvIGRvLg0KPj4+ Pj4gDQo+Pj4+PiBJdCBpcyBub3QgY2xlYXIgdG8gbWUgd2hldGhlciB5b3UgYXJlIHJlZmVycmlu ZyB0byBhIGRldmVsb3BwZXIgb3IgYWRtaW4gaGVyZS4NCj4+Pj4+IA0KPj4+Pj4gT24gdGhlIGFk bWluIHNpZGUsIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRoZXkgaGF2ZSBhbiBlYXN5IHdheSB0byBj b25maWd1cmUgZXZlbnQgY2hhbm5lbHMuIE9uZSBrbm9iIGlzIGFsd2F5cyBnb2luZyB0byBlYXNp ZXIgdGhhbiB0d28ga25vYnMuDQo+Pj4+PiANCj4+Pj4+IE9uIHRoZSBkZXZlbG9wcGVyIHNpZGUs IHRoaXMgY291bGQgYmUgcmVzb2x2ZWQgYnkgYmV0dGVyIGRvY3VtZW50YXRpb24gaW4gdGhlIGNv ZGUvaW50ZXJmYWNlLg0KPj4+Pj4gDQo+Pj4+PiBDaGVlcnMsDQo+Pj4+IFRvIGNvbmNsdWRlIHRo ZSBkaXNjdXNzaW9uLCBJZiBldmVyeW9uZSBhZ3JlZSBJIHdpbGwgYWRkIHRoZSBiZWxvdyBwYXRj aCBvciBzaW1pbGFyIGluIHRoZSBuZXh0IHZlcnNpb24gdG8gcmVzdHJpY3QgdGhlDQo+Pj4+IG1h eCBudW1iZXIgb2YgZXZ0Y2huIHN1cHBvcnRlZCBhcyBzdWdnZXN0ZWQuDQo+Pj4gDQo+Pj4gSSBh bSBmaW5lIGlmIHRoZSBsaW1pdCBmb3IgZG9tVSBpcyBmaXhlZCBieSBYZW4gZm9yIG5vdy4gSG93 ZXZlciwgZm9yIGRvbTAsIDQwOTYgaXMgcG90ZW50aWFsbHkgdG9vIGxvdyBpZiB5b3UgaGF2ZSBt YW55IFBWIGRyaXZlcnMgKGVhY2ggYmFja2VuZCB3aWxsIG5lZWQgYSBmZXcgZXZlbnQgY2hhbm5l bHMpLiBTbyBJIGRvbid0IHRoaW5rIHRoaXMgd2FudHMgdG8gYmUgZml4ZWQgYnkgWGVuLg0KPj4g QWdyZWUuDQo+Pj4gDQo+Pj4gSSBhbSBub3QgZW50aXJlbHkgc3VyZSB3ZSB3YW50IHRvIGxpbWl0 IHRoZSBudW1iZXIgb2YgZXZlbnQgY2hhbm5lbHMgZm9yIGRvbTAuIEJ1dCBpZiB5b3Ugd2FudCB0 bywgdGhlbiB0aGlzIHdpbGwgaGF2ZSB0byBiZSBkb25lIHZpYSBhIGNvbW1hbmQgbGluZSBvcHRp b24gKG9yIGRldmljZS10cmVlIHByb3BlcnR5KS4NCj4+IFdlIG5lZWQgdG8gc3VwcG9ydCB0aGUg c3RhdGljIGV2ZW50IGNoYW5uZWwgZm9yIGRvbTAgYWxzbywgaW4gdGhhdCBjYXNlLCB3ZSBuZWVk IHRvIHJlc3RyaWN0IHRoZSBtYXggbnVtYmVyIG9mIGV2dGNobiBmb3IgZG9tMCB0byBtaXRpZ2F0 ZSB0aGUgc2VjdXJpdHkgaXNzdWUuDQo+IA0KPiBJdCBzb3VuZHMgbGlrZSB0aGVyZSBhcmUgc29t ZSBtaXN1bmRlcnRhbmRpbmcgb3IgSSBhbSBtaXNzaW5nIHNvbWUgY29udGV4dC4gVGhlIHN0YXRp YyBldmVudCBjaGFubmVscyB3aWxsIGJlIGFsbG9jYXRlZCBhdCBib290LCBzbyB0aGUgd29yc2Ug dGhhdCBjYW4gaGFwcGVuIGlzIGl0IHdpbGwgYmUgc2xvd2VyIHRvIGJvb3QuDQo+IA0KPiBNeSBw b2ludCByZWdhcmRpbmcgZmlmbyB3YXMgbW9yZSBpbiB0aGUgZ2VuZXJpYyBjYXNlIG9mIGFsbG93 aW5nIHRoZSBjYWxsZXIgdG8gc2VsZWN0IHRoZSBwb3J0LiBUaGlzIHdvdWxkIGJlIGEgY29uY2Vy biBpbiB0aGUgY29udGV4dCBvZiBub24tY29vcGVyYXRpdmUgbGl2ZS1taWdyYXRpb24uIEFuIGVh c3kgd2F5IGlzIHRvIHJlc3RyaWN0IHRoZSBudW1iZXIgb2YgcG9ydHMuIEZvciB5b3UsIHRoaXMg aXMganVzdCBhbiBpbmNyZWFzZSBpbiBib290IHRpbWUuDQo+IA0KPiBGdXJ0aGVybW9yZSwgdGhl cmUgaXMgYW4gaXNzdWUgZm9yIGRvbTBsZXNzIGRvbVVzIGJlY2F1c2Ugd2UgZG9uJ3QgbGltaXQg dGhlIG51bWJlciBvZiBwb3J0IGJ5IGRlZmF1bHQuIFRoaXMgbWVhbnMgdGhhdCBhIGRvbVUgY2Fu IGFsbG9jYXRlIGEgbGFyZ2UgYW1vdW50IG9mIG1lbW9yeSBpbiBYZW4gKHdlIG5lZWQgc29tZSBw ZXItZXZlbnQgY2hhbm5lbCBzdGF0ZSkuIEhlbmNlIHdoeSBJIHN1Z2dlc3RlZCB0byB1cGRhdGUg bWF4X2V2dGNobl9jaGFubmVsLg0KDQpUaGFua3MgZm9yIHRoZSBjbGFyaWZpY2F0aW9uLiANCj4g DQo+PiBJZiB0aGUgYWRtaW4gc2V0IHRoZSB2YWx1ZSBncmVhdGVyIHRoYW4gNDA5NiAob3Igd2hh dCB3ZSBhZ3JlZWQgb24pIGFuZCBzdGF0aWMgZXZlbnQgY2hhbm5lbCBzdXBwb3J0IGlzIGVuYWJs ZWQgd2Ugd2lsbCBwcmludCB0aGUgd2FybmluZyB0byB0aGUgdXNlciByZWxhdGVkIHRvIGZpbGwN Cj4+IHRoZSBob2xlIGlzc3VlIGZvciBGSUZPIEFCSS4NCj4gDQo+IFNlZSBhYm92ZS4gSSBkb24n dCBzZWUgdGhlIG5lZWQgZm9yIGEgd2FybmluZy4gVGhlIGFkbWluIHdpbGwgbm90aWNlIHRoYXQg aXQgaXMgc2xvd2VyIHRvIGJvb3QuDQoNCk9rLiBJIHdpbGwgbm90IGFkZCB0aGUgd2FybmluZy4g SnVzdCB0byBjb25maXJtIGFnYWluIGlzIHRoYXQgb2theSBJZiBJIGFkZCBuZXcgY29tbWFuZCBs aW5lIG9wdGlvbiAibWF4X2V2ZW50X2NoYW5uZWxz4oCdICBpbg0KbmV4dCB2ZXJzaW9uIGZvciBk b20wIHRvIHJlc3RyaWN0IHRoZSBtYXggbnVtYmVyIG9mIGV2dGNobi4NCg0KUmVnYXJkcywNClJh aHVs From xen-devel-bounces@lists.xenproject.org Thu Jul 21 15:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 15:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372872.604891 (Exim 4.92) (envelope-from ) id 1oEYHN-0001wn-5h; Thu, 21 Jul 2022 15:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372872.604891; Thu, 21 Jul 2022 15:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYHN-0001wg-23; Thu, 21 Jul 2022 15:39:57 +0000 Received: by outflank-mailman (input) for mailman id 372872; Thu, 21 Jul 2022 15:39:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYHM-0001wU-CD; Thu, 21 Jul 2022 15:39:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYHM-000595-8f; Thu, 21 Jul 2022 15:39:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYHL-0002Bu-UA; Thu, 21 Jul 2022 15:39:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEYHL-0000fK-Tb; Thu, 21 Jul 2022 15:39:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=iHNYDj2NVIQIBYNGHP5585qVv+xfQx/9lufbRdOf9N8=; b=K5ixxEJUH/yUPa0jWvHVrco4Ju m9BAH/Wr4s7ebdAIo9XbaFn3o6ldSWsZFz5ZVRWSN4zh+NeUqkREep3GxHrBHd3SksOeLTNyTtzGX gIeCvoniwfq9eim4C9yJzW7+fuZwBz6P5x6XyBXK77XI9DgJupGA1MdcoE94EaWScQp4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171715: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=8ec4bc3c8c09366a9e4859de7c0a1860911e8424 X-Osstest-Versions-That: qemuu=68e26e1e812c8b09313d7929271f6cbd47ef4c07 From: osstest service owner Date: Thu, 21 Jul 2022 15:39:55 +0000 flight 171715 qemu-mainline real [real] flight 171731 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171715/ http://logs.test-lab.xenproject.org/osstest/logs/171731/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 171731-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171704 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171704 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171704 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171704 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171704 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171704 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171704 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171704 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu 8ec4bc3c8c09366a9e4859de7c0a1860911e8424 baseline version: qemuu 68e26e1e812c8b09313d7929271f6cbd47ef4c07 Last test of basis 171704 2022-07-20 11:08:20 Z 1 days Failing since 171711 2022-07-20 19:41:41 Z 0 days 2 attempts Testing same since 171715 2022-07-21 06:01:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Brian Cain Dr. David Alan Gilbert Eugenio Pérez Ilya Leoshkevich Jason Wang Like Xu Markus Armbruster Peter Maydell Tao Xu Taylor Simpson Thomas Huth Zhang Chen jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 68e26e1e81..8ec4bc3c8c 8ec4bc3c8c09366a9e4859de7c0a1860911e8424 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 21 15:54:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 15:54:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372882.604902 (Exim 4.92) (envelope-from ) id 1oEYUs-0004c8-FQ; Thu, 21 Jul 2022 15:53:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372882.604902; Thu, 21 Jul 2022 15:53:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYUs-0004c1-Cf; Thu, 21 Jul 2022 15:53:54 +0000 Received: by outflank-mailman (input) for mailman id 372882; Thu, 21 Jul 2022 15:53:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYUr-0004bu-35 for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 15:53:53 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20087.outbound.protection.outlook.com [40.107.2.87]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5057294e-090d-11ed-924f-1f966e50362f; Thu, 21 Jul 2022 17:53:51 +0200 (CEST) Received: from DBBPR09CA0036.eurprd09.prod.outlook.com (2603:10a6:10:d4::24) by AM0PR08MB4578.eurprd08.prod.outlook.com (2603:10a6:208:100::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Thu, 21 Jul 2022 15:53:39 +0000 Received: from DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:d4:cafe::7e) by DBBPR09CA0036.outlook.office365.com (2603:10a6:10:d4::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Thu, 21 Jul 2022 15:53:39 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT049.mail.protection.outlook.com (100.127.142.192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 21 Jul 2022 15:53:39 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Thu, 21 Jul 2022 15:53:38 +0000 Received: from 6abfc0c0a138.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBDDBBEC-7551-4A57-96B5-B8146F21121E.1; Thu, 21 Jul 2022 15:53:32 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 6abfc0c0a138.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 21 Jul 2022 15:53:32 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7363.eurprd08.prod.outlook.com (2603:10a6:150:22::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Thu, 21 Jul 2022 15:53:30 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5438.023; Thu, 21 Jul 2022 15:53:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5057294e-090d-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=O2tWMdBFZJwfmo3KKwTxFOwbbTqiiiKTIr1QMBIqV3F4uUSlJ7TTAM2tuFC3nKoRrHPdycqUkIDuZIHS3pH0Tud3ed2Mo/c9nJSEP5ZikQ8DEE8PhwlrMj5fJj3gXNVdXZrGn5NLE5QvCZAjyNXGI3tHsT9uqNk1LzemdYbwrN4mvVRXahCRIfWNUBYA4u8Bs5osikxjeAgjvSQ/cTh8dz8j2OuZVGL5DTEimuw6mz0WrU9rCGF6CZ4K8EZXi2sTvHYeX01uACPINTDROWmttZPBvOpPtiNS7MhJcMUtNCrcfDFn5TJjx5xma1F9dca99+6fYwvqaena9KnNMC1pdQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7qqhMz9u9+zPwSI1CNZsMaoieAopSHk2OeZj4UUXT0=; b=g0b23Swn0i8dMqmkP1OARmr6RhPIzthNZle+cb1Mkhs3xKNM8SUa/spE8nypLvuXj2jUQ2y23lw2h0Jw6gN0oF9Z7DJ7CLWuenObo/iJfGmeUMKO9A5NYZs9im+bLe5HXf3DolEYe4q0fc4gTLnCCAifLM05dKS91Xw+Q7SCvVQpB6arLm27ZvBnkK8JKCqSmdfEAR3Y/3phewTTpoUaF5DtbQly6c3FXa6eO4ajn810dD/LlLFBd14nxxfm4udnqeULMpkclyb5Wh1zN0o9IPF+kwBPKBM4S5C/kk4HuowkcpoJnizq4kDhiqvF/3zGd/CHMmjY7OTIUNpM1ExmsA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7qqhMz9u9+zPwSI1CNZsMaoieAopSHk2OeZj4UUXT0=; b=M+jZa8V6r6jzMbUh42tzgofwz/TmIDXXV5sDdAFnbVe2lY+gY4AajzI5qn4sk4bQ/UEMOL2vxDvCKIEhz5Fi8AHS7+UZ4mXWj7xKKz3zacQRNYS+LtL07a2SY+xkdx60hMWa1b+jNqz8JhGW4B7hoPSNb4Z587UVRtveXYtv4v0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d4ff78273d246a4f X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0sE+/yKwmObztipMkEMN4N08DGevzrzoJo2WxEb9JYkVD3jSGy3AFohPWuiP/xe4wSvyghFXAsUpI5YB8VFOz5DQgVGBxscySOXoNM26CB4bg96JDA2bpX2B6FjOFNb0inMw1Hmrt/fwcI99bc9xT9V8VEgJ0eJPKudxpXd1xEkOZ4KbVv/5lUaEQfpbvlzXBDqoD50EYXdFdxPA8l8WKWKYO9iDjEpKqk++AFTz2FR6xiK5IigInx7umsIUX7W9pD6hGkLSFyolFvVzfry/LDwpK+Ow6UAVukfDqvWoYkOYUXywrZ/P/9EzJg7BcxFk8dfd3l5uGoLM8aYJoLrbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T7qqhMz9u9+zPwSI1CNZsMaoieAopSHk2OeZj4UUXT0=; b=ibLErslqnjdeXrHvi9S1p3HhQHwEYfFvHjeavsOJWaSH9XT9eHLd09GfXaF9tklhOyxzSRThqEHE95vNNLdCGRmRWrD4c9Fx2fygo6/MjqCaOS0vJfRPKlkZZ52N0xthG9YbGKkJGKT4klOsoGIiAkAzTDzMr1J3BaO07cghakFI26SWthMAoCNaE9bo+IXUAeI/MVIU9+N9IhHZCooB3xoyhUtAa8h24ZiGgCBxivsFGHDb5iIIrhnTMRUolA/4/juz8qmcLjl/3S7+py3w8IMSK0WqX/j4l9pSHzxYxeiupdoZLzhluQLLWLvLhrXtLxvCSTyfNYJE1mX4nOFpiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T7qqhMz9u9+zPwSI1CNZsMaoieAopSHk2OeZj4UUXT0=; b=M+jZa8V6r6jzMbUh42tzgofwz/TmIDXXV5sDdAFnbVe2lY+gY4AajzI5qn4sk4bQ/UEMOL2vxDvCKIEhz5Fi8AHS7+UZ4mXWj7xKKz3zacQRNYS+LtL07a2SY+xkdx60hMWa1b+jNqz8JhGW4B7hoPSNb4Z587UVRtveXYtv4v0= From: Rahul Singh To: Mykyta Poturai CC: Bertrand Marquis , "Volodymyr_Babchuk@epam.com" , "julien@xen.org" , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device Thread-Topic: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device Thread-Index: AQHYWlIekEFYa4Z+ZkOKg6prrRxnv60EB7eAgALvxoCABl1EgIBEoW2AgAA0fACAAZfdAIAEm8YAgAGSSQCAAEbogIALO3kAgCQMb4A= Date: Thu, 21 Jul 2022 15:53:30 +0000 Message-ID: <69C0FF69-98E3-440B-9CE7-3025EE5E0E4C@arm.com> References: <0A58139F-CA6F-4E18-B44A-2066AEF0C8F6@arm.com> <20220628172338.1637121-1-mykyta_poturai@epam.com> In-Reply-To: <20220628172338.1637121-1-mykyta_poturai@epam.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2b8ff324-aba7-4a33-366c-08da6b312daf x-ms-traffictypediagnostic: GV1PR08MB7363:EE_|DBAEUR03FT049:EE_|AM0PR08MB4578:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: mloRJZj7yvRcQqL4DvgirCQm51Pwna+A7EfWflJvbieHG8lcF77/IEo9d+Ng2gQ36si3sSeryW73NGVyFM/ZZDcdA/LxIpFyd1Kjx4aJxhwKqV+yH70mUnZLzt5i5JMFweIp9cg+pTxyJekhIKVg0cKLpsb98A3WkTwlPfHpy1P5waYrWP57gyiGvyAJOwTe4DuYVGR7kG5VljyPD7Lfol6aKoluqSURKmSng+IdP+ky6VZ1mj0kuNaRv3M0C3f+arA+qBinPWoSP3dmrFfBOclqIA6XVRhv4uOl3BlZmSqjN6jnAnaPEpubfdle+94YVulZZ6ebc886XeIALFkEviwDIksuB7PGvuTZy7aAL0j8gLVGvvPeOWlkV63Max4eh7YkKOJB0Szcf52G+RV1Y99gnfM2RSxQ196Z4mhZPRWghds3nECmU9orz1Xia0dTHIp1L+vj5+wG7aCCWD0HFJJdfdFyKZnvMxj8Yzu2wFaoA/PRxiR1eCm7RkEf8w42xl0kH9rHhwmciRBfkIYKS6L7SCu7RrdNyKu82UmjcqjADMYaUil9AbiBcHqxOLoMlZSzf1UQfTdg+LHNxtza5f6O35B19LwD24nqBGpEMRfQB54s9nAG2mzAq5Ef2zIu8U+rKhWg2g0EOqViOEBvyxPBPMG0c5T972oxAruPNK3AX3DTaMcL+Eb1RpHvnoSp+4e0BBIblFUW9W75bT/Y0UjMGgXJGhXxc9rjxxS2xcuotLG9pTEyCMHveJAwWWpsxbfCRgqGY0qeh2JMtwMvJsvtnQKfECA9Keghuv3kk3p9pNFxNzT25/rdU6sfah+792HtZ4DZcPKIAO6EqES4WQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(366004)(39860400002)(376002)(136003)(4326008)(64756008)(33656002)(8936002)(83380400001)(2906002)(66556008)(5660300002)(38070700005)(66446008)(54906003)(86362001)(6916009)(91956017)(53546011)(76116006)(8676002)(316002)(36756003)(71200400001)(122000001)(2616005)(186003)(41300700001)(6512007)(6486002)(26005)(38100700002)(66476007)(66946007)(6506007)(478600001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <433AF83FA0B6B743AA014315B5BA8014@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7363 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9a436506-99be-4206-affb-08da6b31286a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Aei/x54lwEYBL9Up4BNtRBNQoPHsNJA4iFRoX/b98z2r5wvH4tWWvFxd3jxMi/6fdy1E0mx0lCjx5pbBCOsFURaG2efU4xla45XTTlhRDcDkvdISuc3WAzI7w2xUZzctY+rit2kepx6hdfNFbZgYtWWyxVulbKAlnnYbV0PBb1WbC8+DZ1IJno/9SS6EnP8h9UUsm3s7U6jMU0vOSPqbKwrfW/eh1Ln9FsEtcwKCqsr8/cGfZV6RzTCnuNYuOMcJcrC82GkTXz+qssgdTzbzYFhL+kprQbFYatcAxaB6eh1Qo73lmgH7TR58ifGNul1eaGyuJCOtHXQHd4F/I4OVugEOE1nWJoQ4bYpENXHD/1RKhM80mZuuHJrf78WAgtyyy5Df8rTzeF7OaQDFl8LDRgfdfrviypcJGr/lCq9Ed8LPc05U6aQ3uBtsn+pIWQR6ECz1+RywubzlY6pZ8iXLCKC4xvyAYyzx2U/801dAzgsQhBWyJo2iSaJkLMzUiyLuvmFREM7dkyZbt28P2nREUr6lRcBRY9PSTty97BdY1sYv6Egny4gIEpxaeVx7Nac7qQD6JXIMSG7DMDo/y9tIwCbb0R4dgjvSTQV4o11Wlxs6gtcSkrE1ZiTa9n8vtVNWwD0ZrkJPVmHO982p305/CJ7bDTXaffYRaehrMpdE72vfLRHzI2+/FBSPREqqdcuVvQBTLDEBaziJiMkSIE7bi/ARhy4LwDNVJvY8IblRjFAKhcfIYEQSx/kXmRRJt2cL8lV4iuKX50kekdXJ3WjgD854NT55rt5YQ7VkqtUhL/vVDeVSvL02jmI4MYIk/uEq X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(376002)(346002)(46966006)(40470700004)(36840700001)(40480700001)(6506007)(41300700001)(5660300002)(6486002)(40460700003)(26005)(6862004)(478600001)(356005)(336012)(53546011)(186003)(6512007)(47076005)(82310400005)(83380400001)(2616005)(36756003)(8676002)(33656002)(316002)(8936002)(54906003)(4326008)(70206006)(70586007)(81166007)(36860700001)(86362001)(2906002)(82740400003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 15:53:39.0373 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2b8ff324-aba7-4a33-366c-08da6b312daf X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT049.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4578 SGkgLA0KDQo+IE9uIDI4IEp1biAyMDIyLCBhdCA2OjIzIHBtLCBNeWt5dGEgUG90dXJhaSA8bXlr eXRhLnBvdHVyYWlAZ21haWwuY29tPiB3cm90ZToNCj4gDQo+PiBIaSBNeWt5dGEsDQo+PiANCj4+ PiBPbiAyMSBKdW4gMjAyMiwgYXQgMTA6MzggYW0sIE15a3l0YSBQb3R1cmFpIDxteWt5dGEucG90 dXJhaUBnbWFpbC5jb20+IHdyb3RlOg0KPj4+IA0KPj4+PiBUaGFua3MgZm9yIHRlc3RpbmcgdGhl IHBhdGNoLg0KPj4+Pj4gQnV0IG5vdCBmaXhlZCB0aGUgIlVuZXhwZWN0ZWQgR2xvYmFsIGZhdWx0 IiB0aGF0IG9jY2FzaW9uYWxseSBoYXBwZW5zIHdoZW4gZGVzdHJveWluZw0KPj4+Pj4gdGhlIGRv bWFpbiB3aXRoIGFuIGFjdGl2ZWx5IHdvcmtpbmcgR1BVLiBBbHRob3VnaCwgSSBhbSBub3Qgc3Vy ZSBpZiB0aGlzIGlzc3VlDQo+Pj4+PiBpcyByZWxldmFudCBoZXJlLg0KPj4+PiANCj4+Pj4gQ2Fu IHlvdSBwbGVhc2UgaWYgcG9zc2libGUgc2hhcmUgdGhlIG1vcmUgZGV0YWlscyBhbmQgbG9ncyBz byB0aGF0IEkgY2FuIGxvb2sgaWYgdGhpcyBpc3N1ZSBpcyByZWxldmFudCBoZXJlID8NCj4+PiAN Cj4+PiBTbyBpbiBteSBzZXR1cCBJIGhhdmUgYSBib2FyZCB3aXRoIElNWDggY2hpcCBhbmQgMiBj b3JlIFZpdmFudGUgR1BVLiBHUFUgaXMgc3BsaXQgYmV0d2VlbiBkb21haW5zLg0KPj4+IE9uZSBj b3JlIGdvZXMgdG8gRG9tMCBhbmQgb25lIHRvIERvbVUuDQo+Pj4gDQo+Pj4gU3RlcHMgdG8gdHJp Z2dlciB0aGlzIGlzc3VlOg0KPj4+IDEuIFN0YXJ0IERvbVUNCj4+PiAyLiBTdGFydCB3YXlsYW5k IGFuZCBnbG1hcmsyLWVzMi13YXlsYW5kIGluc2lkZSBEb21VDQo+Pj4gMy4gRGVzdHJveSBEb21V DQo+Pj4gDQo+Pj4gU29tZXRpbWVzIGl0IGRlc3Ryb3lzIGZpbmUgYnV0IHJvdWdobHkgMSBvZiA4 IHRpbWVzIEkgZ2V0IGxvZ3MgbGlrZSB0aGlzOg0KPj4+IA0KPj4+IHJvb3RAZG9tMDp+IyB4bCBk ZXN0IERvbVUNCj4+PiBbMTI3MjUuNDEyOTQwXSB4ZW5icjA6IHBvcnQgMSh2aWY4LjApIGVudGVy ZWQgZGlzYWJsZWQgc3RhdGUNCj4+PiBbMTI3MjUuNjcxMDMzXSB4ZW5icjA6IHBvcnQgMSh2aWY4 LjApIGVudGVyZWQgZGlzYWJsZWQgc3RhdGUNCj4+PiBbMTI3MjUuNjg5OTIzXSBkZXZpY2Ugdmlm OC4wIGxlZnQgcHJvbWlzY3VvdXMgbW9kZQ0KPj4+IFsxMjcyNS42OTY3MzZdIHhlbmJyMDogcG9y dCAxKHZpZjguMCkgZW50ZXJlZCBkaXNhYmxlZCBzdGF0ZQ0KPj4+IFsxMjcyNS42OTY5ODldIGF1 ZGl0OiB0eXBlPTE3MDAgYXVkaXQoMTYxNjU5NDI0MC4wNjg6MzkpOiBkZXY9dmlmOC4wIHByb209 MCBvbGRfcHJvbT0yNTYgYXVpZD00Mjk0OTY3Mjk1IHVpZD0wIGdpZD0wIHNlcz00Mjk0OTY3Mjk1 DQo+Pj4gKFhFTikgc21tdTogL2lvbW11QDUxNDAwMDAwOiBVbmV4cGVjdGVkIGdsb2JhbCBmYXVs dCwgdGhpcyBjb3VsZCBiZSBzZXJpb3VzDQo+Pj4gKFhFTikgc21tdTogL2lvbW11QDUxNDAwMDAw OiAgICBHRlNSIDB4MDAwMDAwMDEsIEdGU1lOUjAgMHgwMDAwMDAwNCwgR0ZTWU5SMSAweDAwMDAx MDU1LCBHRlNZTlIyIDB4MDAwMDAwMDANCj4+PiANCj4+PiBNeSBndWVzcyBpcyB0aGF0IHRoaXMg aGFwcGVucyBiZWNhdXNlIEdQVSBjb250aW51ZXMgdG8gYWNjZXNzIG1lbW9yeSB3aGVuIHRoZSBj b250ZXh0IGlzIGFscmVhZHkgaW52YWxpZGF0ZWQsDQo+Pj4gYW5kIHRoZXJlZm9yZSB0cmlnZ2Vy cyB0aGUgIkludmFsaWQgY29udGV4dCBmYXVsdCIuDQo+PiANCj4+IFllcyB5b3UgYXJlIHJpZ2h0 IGluIHRoaXMgY2FzZSBHUFUgdHJ5aW5nIHRvIGRvIERNQSBvcGVyYXRpb24gYWZ0ZXIgWGVuIGRl c3Ryb3llZCB0aGUgZ3Vlc3QgYW5kIGNvbmZpZ3VyZXMNCj4+IHRoZSBTMkNSIHR5cGUgdmFsdWUg dG8gZmF1bHQuIFNvbHV0aW9uIHRvIHRoaXMgaXNzdWUgaXMgdGhlIHBhdGNoIHRoYXQgSSBzaGFy ZWQgZWFybGllci4NCj4+IA0KPj4gWW91IGNhbiB0cnkgdGhpcyBwYXRjaCBhbmQgY29uZmlybS5U aGlzIHBhdGNoIHdpbGwgc29sdmUgYm90aCB0aGUgaXNzdWVzLg0KPj4gDQo+PiBkaWZmIC0tZ2l0 IGEveGVuL2RyaXZlcnMvcGFzc3Rocm91Z2gvYXJtL3NtbXUuYyBiL3hlbi9kcml2ZXJzL3Bhc3N0 aHJvdWdoL2FybS9zbW11LmMNCj4+IGluZGV4IDVjYWNiMmRkOTkuLmZmMWI3M2QzZDggMTAwNjQ0 DQo+PiAtLS0gYS94ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jDQo+PiArKysgYi94 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jDQo+PiBAQCAtMTY4MCw2ICsxNjgwLDEw IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfYXR0YWNoX2RldihzdHJ1Y3QgaW9tbXVfZG9tYWluICpk b21haW4sIHN0cnVjdCBkZXZpY2UgKmRldikNCj4+IGlmICghY2ZnKQ0KPj4gcmV0dXJuIC1FTk9E RVY7DQo+PiANCj4+ICsgcmV0ID0gYXJtX3NtbXVfbWFzdGVyX2FsbG9jX3NtZXMoZGV2KTsNCj4+ ICsgaWYgKHJldCkNCj4+ICsgcmV0dXJuIHJldDsNCj4+ICsNCj4+IHJldHVybiBhcm1fc21tdV9k b21haW5fYWRkX21hc3RlcihzbW11X2RvbWFpbiwgY2ZnKTsNCj4+IH0NCj4+IA0KPj4gQEAgLTIw NzUsNyArMjA3OSw3IEBAIHN0YXRpYyBpbnQgYXJtX3NtbXVfYWRkX2RldmljZShzdHJ1Y3QgZGV2 aWNlICpkZXYpDQo+PiBpb21tdV9ncm91cF9hZGRfZGV2aWNlKGdyb3VwLCBkZXYpOw0KPj4gaW9t bXVfZ3JvdXBfcHV0KGdyb3VwKTsNCj4+IA0KPj4gLSByZXR1cm4gYXJtX3NtbXVfbWFzdGVyX2Fs bG9jX3NtZXMoZGV2KTsNCj4+ICsgcmV0dXJuIDA7DQo+PiB9DQo+PiANCj4+IA0KPj4gUmVnYXJk cywNCj4+IFJhaHVsDQo+IA0KPiBIaSBSYWh1bCwNCj4gDQo+IFdpdGggdGhpcyBwYXRjaCBJIGdl dCB0aGUgc2FtZSByZXN1bHRzLCBoZXJlIGlzIHRoZSBlcnJvciBtZXNzYWdlOg0KPiANCj4gKFhF Tikgc21tdTogL2lvbW11QDUxNDAwMDAwOiBVbmV4cGVjdGVkIGdsb2JhbCBmYXVsdCwgdGhpcyBj b3VsZCBiZSBzZXJpb3VzDQo+IChYRU4pIHNtbXU6IC9pb21tdUA1MTQwMDAwMDogICAgR0ZTUiAw eDAwMDAwMDAxLCBHRlNZTlIwIDB4MDAwMDAwMDQsIEdGU1lOUjEgMHgwMDAwMTA1NSwgR0ZTWU5S MiAweDAwMDAwMDAwDQo+IA0KDQpBcyB5b3UgbWVudGlvbmVkIGVhcmxpZXIsIHRoaXMgZmF1bHQg aXMgb2JzZXJ2ZWQgYmVjYXVzZSBHUFUgY29udGludWVzIHRvIGFjY2VzcyBtZW1vcnkgd2hlbiB0 aGUgY29udGV4dCBpcw0KYWxyZWFkeSBpbnZhbGlkYXRlZCwgYW5kIHRoZXJlZm9yZSB0cmlnZ2Vy cyB0aGUgIkludmFsaWQgY29udGV4dCBmYXVsdCIuICBUaGlzIGlzIGEgZGlmZmVyZW50IGlzc3Vl IGFuZCBpcyBub3QgcmVsYXRlZCB0byB0aGlzIHBhdGNoLg0KDQpASnVsaWVuIGFyZSB5b3Ugb2th eSBpZiBJIHdpbGwgc2VuZCB0aGUgYmVsb3cgcGF0Y2ggZm9yIG9mZmljaWFsIHJldmlldyBhcyB0 aGlzIGlzc3VlIHBlbmRpbmcgZm9yIGEgbG9uZyB0aW1lPw0KDQpJbiB0aGlzIHBhdGNoIHdlIGRv buKAmXQgbmVlZCB0byBjYWxsIGFybV9zbW11X21hc3Rlcl9mcmVlX3NtZXMoKSBpbiBhcm1fc21t dV9kZXRhY2hfZGV2KCkgYnV0IHdlIHdpbGwgaW1wbGVtZW50IG5ldw0KZnVuY3Rpb24gYXJtX3Nt bXVfZG9tYWluX3JlbW92ZV9tYXN0ZXIoKSB0aGF0IHdpbGwgY29uZmlndXJlIHRoZSBzMmNyIHZh bHVlIHRvIHR5cGUgZmF1bHQgaW4gZGV0YWNoIGZ1bmN0aW9uLg0KYXJtX3NtbXVfZG9tYWluX3Jl bW92ZV9tYXN0ZXIoKSB3aWxsIHJldmVydCB0aGUgY2hhbmdlcyBkb25lIGJ5IGFybV9zbW11X2Rv bWFpbl9hZGRfbWFzdGVyKCkgaW4gYXR0YWNoIGZ1bmN0aW9uLg0KDQoNCmRpZmYgLS1naXQgYS94 ZW4vZHJpdmVycy9wYXNzdGhyb3VnaC9hcm0vc21tdS5jIGIveGVuL2RyaXZlcnMvcGFzc3Rocm91 Z2gvYXJtL3NtbXUuYw0KaW5kZXggNjk1MTE2ODNiNC4uZGEzYWRmOGU3ZiAxMDA2NDQNCi0tLSBh L3hlbi9kcml2ZXJzL3Bhc3N0aHJvdWdoL2FybS9zbW11LmMNCisrKyBiL3hlbi9kcml2ZXJzL3Bh c3N0aHJvdWdoL2FybS9zbW11LmMNCkBAIC0xNTk4LDIxICsxNTk4LDYgQEAgb3V0X2VycjoNCnJl dHVybiByZXQ7DQp9DQoNCi1zdGF0aWMgdm9pZCBhcm1fc21tdV9tYXN0ZXJfZnJlZV9zbWVzKHN0 cnVjdCBhcm1fc21tdV9tYXN0ZXJfY2ZnICpjZmcpDQotew0KLSBzdHJ1Y3QgYXJtX3NtbXVfZGV2 aWNlICpzbW11ID0gY2ZnLT5zbW11Ow0KLSBpbnQgaSwgaWR4Ow0KLSBzdHJ1Y3QgaW9tbXVfZndz cGVjICpmd3NwZWMgPSBhcm1fc21tdV9nZXRfZndzcGVjKGNmZyk7DQotDQotIHNwaW5fbG9jaygm c21tdS0+c3RyZWFtX21hcF9sb2NrKTsNCi0gZm9yX2VhY2hfY2ZnX3NtZShjZmcsIGksIGlkeCwg ZndzcGVjLT5udW1faWRzKSB7DQotIGlmIChhcm1fc21tdV9mcmVlX3NtZShzbW11LCBpZHgpKQ0K LSBhcm1fc21tdV93cml0ZV9zbWUoc21tdSwgaWR4KTsNCi0gY2ZnLT5zbWVuZHhbaV0gPSBJTlZB TElEX1NNRU5EWDsNCi0gfQ0KLSBzcGluX3VubG9jaygmc21tdS0+c3RyZWFtX21hcF9sb2NrKTsN Ci19DQotDQpzdGF0aWMgaW50IGFybV9zbW11X2RvbWFpbl9hZGRfbWFzdGVyKHN0cnVjdCBhcm1f c21tdV9kb21haW4gKnNtbXVfZG9tYWluLA0Kc3RydWN0IGFybV9zbW11X21hc3Rlcl9jZmcgKmNm ZykNCnsNCkBAIC0xNjM1LDYgKzE2MjAsMjAgQEAgc3RhdGljIGludCBhcm1fc21tdV9kb21haW5f YWRkX21hc3RlcihzdHJ1Y3QgYXJtX3NtbXVfZG9tYWluICpzbW11X2RvbWFpbiwNCnJldHVybiAw Ow0KfQ0KDQorc3RhdGljIHZvaWQgYXJtX3NtbXVfZG9tYWluX3JlbW92ZV9tYXN0ZXIoc3RydWN0 IGFybV9zbW11X2RvbWFpbiAqc21tdV9kb21haW4sDQorIHN0cnVjdCBhcm1fc21tdV9tYXN0ZXJf Y2ZnICpjZmcpDQorew0KKyBzdHJ1Y3QgYXJtX3NtbXVfZGV2aWNlICpzbW11ID0gc21tdV9kb21h aW4tPnNtbXU7DQorIHN0cnVjdCBhcm1fc21tdV9zMmNyICpzMmNyID0gc21tdS0+czJjcnM7DQor IHN0cnVjdCBpb21tdV9md3NwZWMgKmZ3c3BlYyA9IGFybV9zbW11X2dldF9md3NwZWMoY2ZnKTsN CisgaW50IGksIGlkeDsNCisNCisgZm9yX2VhY2hfY2ZnX3NtZShjZmcsIGksIGlkeCwgZndzcGVj LT5udW1faWRzKSB7DQorIHMyY3JbaWR4XSA9IHMyY3JfaW5pdF92YWw7DQorIGFybV9zbW11X3dy aXRlX3MyY3Ioc21tdSwgaWR4KTsNCisgfQ0KK30NCisNCnN0YXRpYyBpbnQgYXJtX3NtbXVfYXR0 YWNoX2RldihzdHJ1Y3QgaW9tbXVfZG9tYWluICpkb21haW4sIHN0cnVjdCBkZXZpY2UgKmRldikN CnsNCmludCByZXQ7DQpAQCAtMTY4NCwxMCArMTY4MywxMSBAQCBzdGF0aWMgaW50IGFybV9zbW11 X2F0dGFjaF9kZXYoc3RydWN0IGlvbW11X2RvbWFpbiAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpk ZXYpDQoNCnN0YXRpYyB2b2lkIGFybV9zbW11X2RldGFjaF9kZXYoc3RydWN0IGlvbW11X2RvbWFp biAqZG9tYWluLCBzdHJ1Y3QgZGV2aWNlICpkZXYpDQp7DQorIHN0cnVjdCBhcm1fc21tdV9kb21h aW4gKnNtbXVfZG9tYWluID0gZG9tYWluLT5wcml2Ow0Kc3RydWN0IGFybV9zbW11X21hc3Rlcl9j ZmcgKmNmZyA9IGZpbmRfc21tdV9tYXN0ZXJfY2ZnKGRldik7DQoNCmlmIChjZmcpDQotIGFybV9z bW11X21hc3Rlcl9mcmVlX3NtZXMoY2ZnKTsNCisgcmV0dXJuIGFybV9zbW11X2RvbWFpbl9yZW1v dmVfbWFzdGVyKHNtbXVfZG9tYWluLCBjZmcpOw0KDQp9DQoNCg0KUmVnYXJkcywNClJhaHVs From xen-devel-bounces@lists.xenproject.org Thu Jul 21 16:00:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 16:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372888.604913 (Exim 4.92) (envelope-from ) id 1oEYav-0006kw-61; Thu, 21 Jul 2022 16:00:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372888.604913; Thu, 21 Jul 2022 16:00:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYav-0006kp-2J; Thu, 21 Jul 2022 16:00:09 +0000 Received: by outflank-mailman (input) for mailman id 372888; Thu, 21 Jul 2022 16:00:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYat-0006g0-Gw for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 16:00:07 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150087.outbound.protection.outlook.com [40.107.15.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2fe24e8d-090e-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 18:00:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3240.eurprd04.prod.outlook.com (2603:10a6:6:11::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 21 Jul 2022 16:00:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 16:00:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2fe24e8d-090e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHFVlhi3Rjh1UahnHcT53JzO+aeZIQvlCYL7JUaeaaOfYd7O8idP/zwv4g3Hlw25krOEPjkh9Bz94PQeQaYSfc+TlhDmrgtvHiQvVhLI8Etb2vQOi0Fo2p0mZvP5TDn4Us/S0hV2iPW43Yci50vjHBbvOz5CADvXl0g2Z7vn1cEYhSeuRHJUemBsD3QP+CMPdb2JH1vGAzs/C+zWQU5tCtU5dxXHpojxxByq/O03fSMsMLSv+dQdQufjNJF6W2Lk+nX/p+Io7hNnq4KaybPy9GsrgqxWj07rKjjPISYSQs+v9lDm04D/ztZ9V2xmt4EMwNCIwTpTHcV49qBPSz5Tbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8W33qQcDznwUN2tLVyPbU4Juq2m810L8rzEfP7XtZQ=; b=ZLEQlqgwalVnb+dQ6p74pCjL0St4ZwD+U/H+o8bHk1i3vT9HLeeYQPJnYsauXnmrS44kgYDoIIkPpm8F5Q/L2xs/gekBrXJEI7lU9Rw1/76ks/cbRmrhdmayQo9N5Cyr7lox7mxOG31sI5cy8XDGQXlvsfZ8v6NV6D15ObfK5YZIL9zuIYUdeLK0rqfi8tiBaNroL+2U2Rc+0wDArte/YqfewNOmpSLP7J2TFczPCunVdtUlnLZqja5OWdp74uthW/CpxJSjUzzyhHrjif6eg2ZY8QogmYxdTLB2n2Uxs+JuLiq1T0ZKIf3GX9oVhWwezvXZ00kD7XeosgUoRHWxpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8W33qQcDznwUN2tLVyPbU4Juq2m810L8rzEfP7XtZQ=; b=kx8snZcIXi3K1P+Bqba9rfsf1L1mbJAY3Mg5Xirf10JtfTqpYVCWZAL6lTr+A31IPD1w+JnGdzf8XEogPOmPhhkO4dbtwY6cG5SafpmcZBWK9D4z8F9BPEg+H0tUoUUhTkPCRNwbDc7LsB0S1lduPilIPa4ZLyUSHGkh/CGg2bHHX8n+YEJB05zqX+ZxaHCgRJHEGnlB+Y6YND89AKl47WByzRfggLFRrPXK049P6Cp4CUxdYVrExjXe1MSO2njQ0MxfpJ903SLvcjoftbo1hWf7XP5k4U3KXFIb+Pp/LNwpyVvu8t8Dm+FBdRF1pBJrTxa06jPwaim+MwOP0+G2FA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 21 Jul 2022 18:00:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 02/18] introduction of generalized boot info Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> From: Jan Beulich In-Reply-To: <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5d017f9-359f-44ad-5b6e-08da6b3212cc X-MS-TrafficTypeDiagnostic: DB6PR04MB3240:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: D3Di22wQhMlnDiirkvZPGLgYMzPxr21tFEtuKstGfgwZ778RBJizJX3S5q3Ttp0H9t00YPMY0FqKDg4OCGv1Uz3vdNjdP24UIvZBZOGocvr3I13ms+sD4aNI6f49itNfhrNgyR00MUgqlkc0ojLx3T/BoA7aqbbA/GkPv5WsEQ9IX2zRTt/QmabDVY7jjo/YdVsaMaYDUzXzF5Zu8lGZnjsZHpKv8hTV3NocAXnREsl115usyiVN2sU/Dz5sBtCe8PZgirNkNSoeYZ7+0xokc8Y176WGZjToC6hZAGEMz2KceFwmxZ/G79iNMsaSM91wHofbYCsjzyThquUDh9quERVGIwg0lyCdmGz5/DZm81dfRq8atwXF0HKj5wVQ1b/LrXrqjzgtS8z2SSJIDikTwW0FuLYelnZLrwCQ8WsqhJDzFfINFxDduK0fcqL0bszBrCC8TWyCclb2KWy1tD/IcRPnPUjzxEuIKK3EbVoj1gyykw8bTjpMH9HZ2YB4T0ZbduDFvn4UzS4LcHW5oAIZjWx2M1H3EZFuLMDidRc3ppCVhmp4WleKmsFXW2hNpm55Ja6D5Jph3SCC0UKyVLzjJP58DiSbew//KDn9i3tcscXg2cBUep8jEm28+I29RlFAJg5hYZY5UzZYa3r7NRU9PNclVY2y0nr06BdxOnNVASysb0NoOW72mMBLqVy2TUcOyVbZ3rvFhrl8+7vx7sNYX7mpOPNiVc+/X04V7k6QBoLJRySP50A4nVy+7e/HnFOsfxr1SdIpX2lU35qB92qy2YoEGo1XNIDgfBnIO11SkbH8Yna6gzzzIVX0pt0qJZ1Z/T436WWFBOVnRNxLLrWkhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(346002)(39860400002)(136003)(376002)(316002)(6512007)(2906002)(5660300002)(8936002)(54906003)(186003)(7416002)(6916009)(8676002)(4326008)(66556008)(38100700002)(53546011)(31696002)(6486002)(66476007)(86362001)(6506007)(2616005)(83380400001)(41300700001)(31686004)(36756003)(66946007)(478600001)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QVZQUjRYc2l2MUt1QnVrS1hqVGVqRStpbTIxVUE0dXB2MXdzZStUdnMxRy9n?= =?utf-8?B?VzJHaU1tcGxWYkM2ajdPZTdRdld0UjNQZ29jVVBkS2REbE04aUpwbUZGMG43?= =?utf-8?B?eU5XajZ2TXVDc0QvNjk2dG5SdHpRUXhJVlRyV2diZVRhMGV2b090WWt6ZFVL?= =?utf-8?B?aUdTSHBzYnNsNDBWUW5xNzd4eG03SzJKVE1Lazg0ZWNYTGp6NVlubUhBUEQw?= =?utf-8?B?QkRTMUFnenI1Ym9lWHFPWis0aHd0NkwrWkp1bzhCdDN4aXNEMmVISjR3MGMx?= =?utf-8?B?QW83MWR6bVd4ZkdpMEtxL0EwOSt5ejlob0I5ejY5RE9lTUVZdEtIY1VqVzVO?= =?utf-8?B?bkFwa3IySVdRS1Z1Z2t1QjRPVU1CVStJTTRZK2lSMEtVM1cxdkJXZGNlN0J0?= =?utf-8?B?T0Y0Q21sQjZlVFBjOEFVNjJkL2xOeWRET3VuNG9TdVJ4OU13NnUzdW5uTFV6?= =?utf-8?B?ZjQ1WVhQUDF1cnVodndJcXhvR3dWa0paWTRmS1p1Y0dWeTcyUHFSQTNnUk1T?= =?utf-8?B?Y055alhIMlEvWTRTQjdpM256SDdjbWFMeEpqYlR0MjQ0ZWR4SUNIb2dBNGJm?= =?utf-8?B?SGpLSW9iUVFmZ04yanNSY1krM1JIQnBwMVRDTTFBUUxpdXQrSGZxQmwwQUlW?= =?utf-8?B?eHZpaEZrcDc3RzFWbnpESmxwSFhKcVd1OVhqRnpKKy9vNHhPT1VHMlN1U2ph?= =?utf-8?B?LzJ6L3dvbEM3ME9wT0dQS2pEZlFNQllRRm8yNVlnWWcveGd3V3lHdWR1dVVx?= =?utf-8?B?TG1UY1c0a0I0V2o1VEVEQkh5angzRk5XL0pjbzVpejIxT29sQXJlbDM4d0FC?= =?utf-8?B?NkplNTIvcmdvUHhTYzNidXNwUSttTXp3aG84dEljM01XMHZuZEdYbVBLS0lS?= =?utf-8?B?TWttRlF6ejNteDJvTlRjdUhaQm1VN29uSzFNem80TkJsYk9ZbjdyZ1p1MGlC?= =?utf-8?B?dWRJZzBvVXJYTFZzcHNPYVMxdGM5NmhsM1gzTUhVdjlYSUtSN0t5Z3MvTnhU?= =?utf-8?B?VzB1djN0UkVzaTBCcWVXMTJiOVpvQU13V25jSFhLWWM4YkEwZUVVMUxFblRm?= =?utf-8?B?NlZqQ2VUdklDR1ErQTNHYkNYM2pibmlzcXVsazhVN3ZZMkxDNzVPbjF0dXJG?= =?utf-8?B?R3ZnNkFBQlFwSEN4SlFpMmNDOUZTdVJjeEY3bUdpYlQzN1lYVEtHcUZ0WXVk?= =?utf-8?B?WDQ4aTBKNVpaTDZvcytGUWdWbW4yaWpXMlNBcW5pNmJsRXd3eHRjLzB0MzJj?= =?utf-8?B?VlAzeHhiTGVkT1B5d1lteE9XL0ttVmdZRlNnQk5RTTZETWpMZ2hpS0xhOFZr?= =?utf-8?B?S0xvc1VUYWxwNEdmemxlWFhVZDduUlhWbHd0Nm1WR0RZaVc3Um5rUCtWZ1pa?= =?utf-8?B?Sk0xVlg3NEhKYlZoSGJ0eTZnZlo4RUJxbkx2alBjZ2NYVHdQZklpdEdaaFIy?= =?utf-8?B?RkhGTXN3NkNoOG11ck5Xa3FmRjkrR24wdFJneitwcWJ1T1hxY3ZtcFF3NVcw?= =?utf-8?B?aXRXYVplUnBUUVo3dTNPMEs2YUJNMmxQK21KaFphdlZUSEg0NXgvcmxSY2hu?= =?utf-8?B?Qk5kVlQ2aWVLTVFXN25HZU5uaU4yMDEySUt6RDVTV2pVODF3SmFwZGJjY0Nn?= =?utf-8?B?S0RpakhPQkgyQVY2dnRkbm5ROXF3Q2MxRUZxdGZnU2ZTVHA2WlJ1Zm9nTXlW?= =?utf-8?B?NG4yTmw4ajduTHpmdW5zR2hSQ3NNZ1djWkhDWTJhdkxCK3pmbFg4YUFqV0R6?= =?utf-8?B?Z0tnaEp6V1RKSVdlYllwQm90TmhVQ1BJYVZFejhQbEJlTkYwOThzdUlaa3dp?= =?utf-8?B?eUZFdGJGaU5lN0VBS0ZaV3prSUwrNDY5Qi8zUTU1ZEFmT3FhOTFFN3o5NEJw?= =?utf-8?B?amF2cVQ1UGpNWk5naTBzb0hvWG9rQ295cjVYbHFxYWx5WUFGdkVrNXJQYXo3?= =?utf-8?B?eENlL05sRXlEaTNxdHh4em9ZL3QveUdVV2Q4c1krRXgyb09ES0JLSWRsWXBS?= =?utf-8?B?WlV2ZVVWQ25FTnFIN3V0R1V5MGtYdEIwdUFPN01Pa1hyZ3luZ3dPRDlNYWRU?= =?utf-8?B?V1dZRUtmdDBLbHB0YjJZRVVFdXZXNkxxOWUrWGN4YmRKRks4TC9PdTVpM3RO?= =?utf-8?Q?GQh/O6iDJ4EcTQXwTy0ENqfYR?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5d017f9-359f-44ad-5b6e-08da6b3212cc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 16:00:03.6453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: heMDtYanorfkCHRum8Q4+iajItP70xmoiY/+Mn15aSXmdAcz51qnUlUkwO1Dy1Nlks83Hmfqahz9XpRmFcN8ng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3240 On 21.07.2022 16:28, Daniel P. Smith wrote: > On 7/19/22 09:11, Jan Beulich wrote: >> On 06.07.2022 23:04, Daniel P. Smith wrote: >>> --- /dev/null >>> +++ b/xen/arch/x86/include/asm/bootinfo.h >>> @@ -0,0 +1,48 @@ >>> +#ifndef __ARCH_X86_BOOTINFO_H__ >>> +#define __ARCH_X86_BOOTINFO_H__ >>> + >>> +/* unused for x86 */ >>> +struct arch_bootstring { }; >>> + >>> +struct __packed arch_bootmodule { >>> +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 >> >> Such macro expansions need parenthesizing. > > Ack. > >>> + uint32_t flags; >>> + uint32_t headroom; >>> +}; >> >> Since you're not following any external spec, on top of what Julien >> said about the __packed attribute I'd also like to point out that >> in many cases here there's no need to use fixed-width types. > > Oh, I forgot to mention that in the reply to Julien. Yes, the __packed > is needed to correctly cross the 32bit to 64bit bridge from the x86 > bootstrap in patch 4. I'm afraid I don't follow you here. I did briefly look at patch 4 (but that really also falls in the "wants to be split" category), but I can't see why a purely internally used struct may need packing. I'd appreciate if you could expand on that. >>> +struct __packed arch_boot_info { >>> + uint32_t flags; >>> +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 >>> +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 >>> +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 >>> +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 >>> +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 >>> +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 >>> +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 >>> +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 >>> +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 >>> +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 >>> +#define BOOTINFO_FLAG_X86_APM 1U << 10 >>> + >>> + bool xen_guest; >> >> As the example of this, with just the header files being introduced >> here it is not really possible to figure what these fields are to >> be used for and hence whether they're legitimately represented here. > > I can add a comment to clarify these are a mirror of the multiboot > flags. These were mirrored to allow the multiboot flags to be direct > copied and eased the replacement locations where an mb flag is checked. Multiboot flags? The context here is the "xen_guest" field. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 16:00:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 16:00:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372889.604919 (Exim 4.92) (envelope-from ) id 1oEYav-0006ob-HF; Thu, 21 Jul 2022 16:00:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372889.604919; Thu, 21 Jul 2022 16:00:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYav-0006oB-BS; Thu, 21 Jul 2022 16:00:09 +0000 Received: by outflank-mailman (input) for mailman id 372889; Thu, 21 Jul 2022 16:00:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEYau-0006g0-8z for xen-devel@lists.xenproject.org; Thu, 21 Jul 2022 16:00:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2048.outbound.protection.outlook.com [40.107.21.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30c9b5a9-090e-11ed-bd2d-47488cf2e6aa; Thu, 21 Jul 2022 18:00:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4314.eurprd04.prod.outlook.com (2603:10a6:5:23::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Thu, 21 Jul 2022 16:00:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Thu, 21 Jul 2022 16:00:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30c9b5a9-090e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDP0GyLPZ0nrrXjQaad51yo+OdoVLKAuMZVzXaDDJGhZ8fKmEPp/c14UTndJNUsdR8aMM+f2qLyxuKFjSUOF9rfDrjQXqA4cT3B7MmPA3q/v0GhI5xeQjuPP5W4SoqRBbB8anIagsROSVvYY29YTp3iKHgqGGznSiBkat3TgKNWXaMs3vSIazu/xkPfjhdSW0Zz+6e1kZc06VaC9nPQ8PWZTsAmjmevk2K6L3alDcJoMTkgYkqB7QK3Pl/1waMaCNkJ8LEFpA2dVIuDJ3APkZfSCJ1NK5eCBsFhnx9+p/pyA1fjUmGsH9+6bzO+RzPa9Ggluf3JraCs/HpDTv35K6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/8W33qQcDznwUN2tLVyPbU4Juq2m810L8rzEfP7XtZQ=; b=YccpxWOmcEcz//9pKdZhSC9S2xPWVlsnHGtKC7uVNqdlgGG2UwO5EVuzwEsFBCOgdJUV8izT/4OF5gJ1mIJ2+t9/HvKqVeL7AzWHiGepw5eXr0KqlyPOozDn5czFU5Ji0j3kcBJXY9DSzWZMchxEPEgJeb5MeIasgK7bvPlhFyuvvawQTIkTXyFfeOK8HPbaTHIismcs304QttOWuGJ6fCI5Bp39ihrJxNWHLYUHvWn6Rp8nHHwarf5p9GXglCwGSqdFD98QuRzZv+Fyaqx9bc7GtC0jp4FqemtSBzoriUtgsY298DIYoMy/v9VP6SeL69meUNH405izY/xFIlgDPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/8W33qQcDznwUN2tLVyPbU4Juq2m810L8rzEfP7XtZQ=; b=Az3Md8zBt7SGdwmcY1+f7he6/Kn3rYYwl4obyCFN3XIzV49OA3l7ZGJBzPcsvXoFNIzp0Bt2ZPBLqxBOVJk0ExuEvkzzo5X4ubHgSrXcbrT8uAnrsfcKKplNGJXdyRVM6rtY2RdXKt2sos+A2lC8cH0voSD93S9O5moZm4bc0pIpIc/mZ3aOLa37LQLyK7X1ifiX/aWhbai10vPzqkO9qGltWv1n5l4ERYk/DR0znUpZt919rUzmdaDjX5wgItQy9Eo/7B3CTnTL3hnkwUORdVJG7nlWzyETW2kHJJzPYozeAOspHk8T/rfhIRWrFUNFX53r27+Emo7Tuc0d08vG3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1ea21e87-cfea-5378-091b-1d7358c9431f@suse.com> Date: Thu, 21 Jul 2022 18:00:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 02/18] introduction of generalized boot info Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> From: Jan Beulich In-Reply-To: <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0accfb89-cd1c-42c9-09a8-08da6b3212fc X-MS-TrafficTypeDiagnostic: DB7PR04MB4314:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +fd4g+SZP+GeB1bOhNcsQk4xN86njL2lGK50Qxwf2eVnQY1YrAWzrtS6s2vDguN7wF+ANjwyixAePmfENumNjNSWMx3VwQZZ0gOAW3toAeT/7r09uBUPIRc+DfKNZfiNy8TWt6lcSXGRQuMHsRq+Uo/Z9dImhH/8F5Hce1MR1kpxZIfMnzSuozz6FU1zKDUI43x9iHBRQF3vfM5C+2W8+gTK8I2kWo8bmaEAsos6sJn38WGW7BFcepDG1lk8J4XTAGSzX64NKOL/090YK5eLhHJiNtmGeUiz/8MpyH1DISMgE0Mjt5e4VYppvDrSlZrQorc9ThIOfketuy3JtAqpmTMHjjmnfAo33qoL04Z4UKQSBFGJ2UOj3aB1ohFgPpAMBCxNdVreo4/dB5+Qu/TWiYEc9xu/rh0a+V4Ia737uB3nqgg3jOWY5TL2p1NqEloKmeO1HM4JuTPfJ6DfmS5D00b2GDxSoJQjMLtVr9YfgsCdbLE9wn8M4+MyztRzryKOdQLF4E+KuTVSRBJMDh3HLa4UIam+jCnw4OO1imFcXqnrZDQvDSHYKfbCId8nPXcLpqlynmBgSPPRaRPNldi+AAAAu4vQllWUEB8cUr5ES29i+u83lCgAmLkIiwwQYOt8qyLB174u2JLtq8NeQaiaOSBJLkLlLzU5wrLJDve/eIJZR09tiYuz64lnl5CJLSxIf4211qpUftuGvAZLITouIvPtBVq0151ERQhjwps0Leod87Wh3Tkvqpn4ihlWsx0dC4CYDur0S5m5LZNom7Um5iOwbBmm6DUaEgV7WnhDafqXFKwGuZOxsvnid0uq/LlzH1mYX+VZaLu6+tnauzqegA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(136003)(346002)(396003)(366004)(83380400001)(6486002)(478600001)(7416002)(2616005)(5660300002)(8936002)(6512007)(186003)(2906002)(36756003)(31686004)(26005)(6506007)(53546011)(41300700001)(6666004)(316002)(31696002)(86362001)(6916009)(66946007)(38100700002)(4326008)(66476007)(66556008)(54906003)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjFFdU5PZWRlS3l6dG1Vdm9IZlVUaXByMXhVZ1NNQ3pHeDlHTFRwOFVnUlBz?= =?utf-8?B?VjVPbTV0ZGNTMmpCOHZGY2RjNDJiUWZaTkV3NXhoTDlxZy9FOEoyL1hOQXpk?= =?utf-8?B?Z095TithNFNrSWRINEdWMTY4TXZjZmN0NEZGY2ZoTCtDdVlPUWNqdm92QTJz?= =?utf-8?B?OWdyMW5qcXpWM0tFVVdOYzkzWWVTbnBzY1h0MEUvNUZSNjYyKzlzOGlVV0hP?= =?utf-8?B?bHVJTFVISE9uZ285bTBjcWM4ZFJzckxxRDcybnRrdWpzRmhZQ0U3OFlxNnlB?= =?utf-8?B?ZFFHdzVocndFUmNhYm8vWUxqS1dFWm4vTTNlYzBodXI4S3AzK0JGeGMzZHlB?= =?utf-8?B?VXgxY0YxNjNieVhTeGhIOHNBNEpncUdCYXlVb1U2cndyYU5aY2NYWXV6MkZE?= =?utf-8?B?QS9wWVFiVTZlMWFrTVFCTmcvOHpXTExta2hrVlJwYjdXTE9rcVBQa0d2d01m?= =?utf-8?B?ZDVqUDNBYXdzek1RNEdMREJuUDA5UTZkRTkrSndOSmgvcmdyeEhwclNjUW55?= =?utf-8?B?Q0hsQngyUUM3eFpRTlF5RmNJM0U1Sm4vOE53MkFYQnpLUHVDN3M1c05PVzBU?= =?utf-8?B?M1NrY284VTBHUVlEeTdub1ZEMzBva1BteEVxRWJ2SWgwYUpBQnRrQ1pZL0gv?= =?utf-8?B?T3VBSWQyNitBUUZwWWZOb2kxQ3JNYXkvTEh5R204ZFVHRCtqT1dKSXRZQk5P?= =?utf-8?B?SllXZTRLbnQzcHpDcHhDNXlhUHJxd2JjR1dJMi9hRiswRUkyUU1IMG45bUFz?= =?utf-8?B?WGlwdXFMTUd6dngwR2pYeTF0N2lJTXZYeDZCemhuRzRmMW9TZFFzTklQNmlq?= =?utf-8?B?Zzd6V1g3VFIzbU5DTldsVGlxbjlXOVo4UmNFUnBJRlFHZXYwaE1RaVM3K2dV?= =?utf-8?B?N1RVTWVWSmd1SWdZdjJWVUhTWjhiSjR1dHNPd0NKQ1JmSUlxc2VFVXJrYlpL?= =?utf-8?B?RnBDUkUweWZ5akVXMWNWalZxV1BJZnpiUmtxbFhkN0NhM2F5UWlvUytiZzlY?= =?utf-8?B?dkR1V3I2Rk0rbGZsRDBtdmpOS05RK0t1cGJUS0pQTmJQM2hacm4zQVVCaGxS?= =?utf-8?B?OWxXTTZIYlNuMGdIUWk5SnRGc2xMZTZlSUlRaElvSTkvaE1hb25SY0UrcTRp?= =?utf-8?B?aHlRUk92SUJjTnE1VXdFVHgzaVppL2FpTWVnWXJIVlZOb3l0bjMvYWxHZHZB?= =?utf-8?B?ZkNiMzdLbmh2VmdXZ29YSVJKWGdSWlpMN0RRNXpkS0NUUThKeEdTRXhaU1Jr?= =?utf-8?B?WFlkMVhJNjhtS0RwUTZ6VitIeDJGNlVMNnNmZ2ZZeGlTV0NITkRhWmZ2Nnpn?= =?utf-8?B?RlgwRk5xWm9tNmpIVUFjQUFhVFpPZk5VYnJxMmlUeTV0R0x3YzhhNms4TFl2?= =?utf-8?B?TlgwbVJyME9GWCtGblB0U1Y4K2tydFl1aFBnZlI4VVZsZ2lEVm1IRUJxa2Fo?= =?utf-8?B?UVNJbkFHSDBDdERRWFJZeHZzNUZZZ3NvNGV3TVpKWDdCTEtzZEl0ZTZ1NUNB?= =?utf-8?B?MEFrR0ZjSVg2RndVMCtPZVlML2tGU3dNb00xblZFMkJWR25XcDlVanV5K21S?= =?utf-8?B?WjBORGV1cXNJTzgwREpCT1dobUdqRnRKczl3ZDJTK0F0U1BRNXBlVnZqVGRm?= =?utf-8?B?dkh5Y3FpRjlVUmxRaGtNWEJnMDZ6TkN2YmpYZGkxcnJ5VHpNckdsY3E1cVp4?= =?utf-8?B?TGZWWjEzdDVncUk5ams5Um8vT3ZhYU52OVF3T0VZNzk0U3MvQlJJMVVrbCtu?= =?utf-8?B?dkJIZnlDblE0TXdGRDFIVHNwa3NhRCtlaDNKK0o3L1Y1dzVXTGZwZ0tkUm9S?= =?utf-8?B?OFNFVUhzTW95MnFqOTZ4bnpaR0srMkZ1TzBBOHRVemoxNGRLZnM2bnJ3MlRP?= =?utf-8?B?cFBndG5FUVd6UVdBbFZqUjN0eWI0dmk5YmZQYVJvSzBnRGIvRHAxTmk0bDcx?= =?utf-8?B?OUVDNkQxR3h6eGtYNEVkbDdlUjJqenJaYVpUZmV4NFNEbmFGOU9BT2kyQ3hU?= =?utf-8?B?cWgwZVoxbzhQOXFwWmFCU0pJZFMzeU1PZkptb05URzRKSitNN1RYQzFyb05X?= =?utf-8?B?L29aRnZCb2pxUEdPUkNRY2VBVktoUFBSZmsxQU1GazdSNVJiaSs2Y2dqNVAz?= =?utf-8?Q?6iwnT/zvD2KlfP62tTq/y3yZ3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0accfb89-cd1c-42c9-09a8-08da6b3212fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jul 2022 16:00:03.8796 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EOSz1CXVcyjEj1gXnUyvHv2b2Mpf9YkZpndtDFvc3g7moG62/1/az+ZZO+OIJNY9ZYrAzeNSXCqpsayUMR5SSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4314 On 21.07.2022 16:28, Daniel P. Smith wrote: > On 7/19/22 09:11, Jan Beulich wrote: >> On 06.07.2022 23:04, Daniel P. Smith wrote: >>> --- /dev/null >>> +++ b/xen/arch/x86/include/asm/bootinfo.h >>> @@ -0,0 +1,48 @@ >>> +#ifndef __ARCH_X86_BOOTINFO_H__ >>> +#define __ARCH_X86_BOOTINFO_H__ >>> + >>> +/* unused for x86 */ >>> +struct arch_bootstring { }; >>> + >>> +struct __packed arch_bootmodule { >>> +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 >> >> Such macro expansions need parenthesizing. > > Ack. > >>> + uint32_t flags; >>> + uint32_t headroom; >>> +}; >> >> Since you're not following any external spec, on top of what Julien >> said about the __packed attribute I'd also like to point out that >> in many cases here there's no need to use fixed-width types. > > Oh, I forgot to mention that in the reply to Julien. Yes, the __packed > is needed to correctly cross the 32bit to 64bit bridge from the x86 > bootstrap in patch 4. I'm afraid I don't follow you here. I did briefly look at patch 4 (but that really also falls in the "wants to be split" category), but I can't see why a purely internally used struct may need packing. I'd appreciate if you could expand on that. >>> +struct __packed arch_boot_info { >>> + uint32_t flags; >>> +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 >>> +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 >>> +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 >>> +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 >>> +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 >>> +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 >>> +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 >>> +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 >>> +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 >>> +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 >>> +#define BOOTINFO_FLAG_X86_APM 1U << 10 >>> + >>> + bool xen_guest; >> >> As the example of this, with just the header files being introduced >> here it is not really possible to figure what these fields are to >> be used for and hence whether they're legitimately represented here. > > I can add a comment to clarify these are a mirror of the multiboot > flags. These were mirrored to allow the multiboot flags to be direct > copied and eased the replacement locations where an mb flag is checked. Multiboot flags? The context here is the "xen_guest" field. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 21 17:06:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 17:06:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372905.604947 (Exim 4.92) (envelope-from ) id 1oEZcP-0006zM-It; Thu, 21 Jul 2022 17:05:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372905.604947; Thu, 21 Jul 2022 17:05:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEZcP-0006zF-GG; Thu, 21 Jul 2022 17:05:45 +0000 Received: by outflank-mailman (input) for mailman id 372905; Thu, 21 Jul 2022 17:05:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEZcO-0006z5-EK; Thu, 21 Jul 2022 17:05:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEZcO-0007FD-A3; Thu, 21 Jul 2022 17:05:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEZcN-0004wi-Ta; Thu, 21 Jul 2022 17:05:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEZcN-0000I1-T7; Thu, 21 Jul 2022 17:05:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ceYYBPcs5CFlbd/uAulUEEc1fBn5yZFq9B/JO8Ad92k=; b=VDHXoCLe0V1oy6dTOLGNqZksab lcJzqcYmmMGWN6HtgAuB6adGgfOOKQWzUN/1XqTWERUpyIE1Bz39+TVX+0Xj9ukrbAKtVfA6jIv2y SughSS67sTv/luKdBr7piijFw2ZszbPCBjAChZn36G/pDHG9etsBcnnU2s3dEAChJySI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171718: tolerable FAIL X-Osstest-Failures: xen-unstable:test-armhf-armhf-libvirt:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 X-Osstest-Versions-That: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 From: osstest service owner Date: Thu, 21 Jul 2022 17:05:43 +0000 flight 171718 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171718/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 8 xen-boot fail pass in 171712 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 171712 blocked in 171718 test-armhf-armhf-libvirt 15 migrate-support-check fail in 171712 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171712 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171712 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171712 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171712 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171712 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171712 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171712 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171712 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171712 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171712 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171712 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 baseline version: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 Last test of basis 171718 2022-07-21 07:37:39 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Jul 21 21:00:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 21:00:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372937.605028 (Exim 4.92) (envelope-from ) id 1oEdH3-0002Gc-JX; Thu, 21 Jul 2022 20:59:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372937.605028; Thu, 21 Jul 2022 20:59:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEdH3-0002GV-Fm; Thu, 21 Jul 2022 20:59:57 +0000 Received: by outflank-mailman (input) for mailman id 372937; Thu, 21 Jul 2022 20:59:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEdH1-0002GL-Oy; Thu, 21 Jul 2022 20:59:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEdH1-000391-Kh; Thu, 21 Jul 2022 20:59:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEdH1-000823-8h; Thu, 21 Jul 2022 20:59:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEdH1-0005YQ-8F; Thu, 21 Jul 2022 20:59:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PRXKZbYhrWo59j51+3eGuL4xHTYenrOluNAkvS4tjro=; b=Vz0ywfczMGiSRPsLB1JjOIBdMe bL2tk/V43P+IWJ9EP9LZhga5+wGhgTVOZzcFJptPegN8IJCS905tR94vSowFF9MqvGokcYUtHnznc KIjQiUVNGQwu7MDOiccDGFbQwWbmmxkTAHw0Ne0uqA/t5UK/1+LnHoszlqnbOFplXS20=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171734: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=fe16c833fdb74642c296fa96a472e39229cd4351 X-Osstest-Versions-That: qemuu=8ec4bc3c8c09366a9e4859de7c0a1860911e8424 From: osstest service owner Date: Thu, 21 Jul 2022 20:59:55 +0000 flight 171734 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171734/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171715 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171715 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171715 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171715 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail like 171715 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171715 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171715 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171715 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171715 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: qemuu fe16c833fdb74642c296fa96a472e39229cd4351 baseline version: qemuu 8ec4bc3c8c09366a9e4859de7c0a1860911e8424 Last test of basis 171715 2022-07-21 06:01:50 Z 0 days Testing same since 171734 2022-07-21 16:09:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel P. Berrangé Dr. David Alan Gilbert Hyman Huang(黄勇) Ilya Leoshkevich Juan Quintela Leonardo Bras Markus Armbruster Peter Maydell Peter Xu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 8ec4bc3c8c..fe16c833fd fe16c833fdb74642c296fa96a472e39229cd4351 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 21 22:26:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 22:26:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372950.605045 (Exim 4.92) (envelope-from ) id 1oEecG-0004sL-3w; Thu, 21 Jul 2022 22:25:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372950.605045; Thu, 21 Jul 2022 22:25:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEecG-0004sE-0W; Thu, 21 Jul 2022 22:25:56 +0000 Received: by outflank-mailman (input) for mailman id 372950; Thu, 21 Jul 2022 22:25:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEecE-0004s2-CZ; Thu, 21 Jul 2022 22:25:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEecE-0004jx-7l; Thu, 21 Jul 2022 22:25:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEecD-0005eN-Ts; Thu, 21 Jul 2022 22:25:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEecD-0001NE-TO; Thu, 21 Jul 2022 22:25:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=mhAL+VOCgqnKNkroIaN4W/tqGWglPBdASyu4mPaOUZ4=; b=q+FyTwXTdtvfxEGT0Aj4YioW0N HHSdrlSPLA9BKT/qt0lVCM+zvUk6sp3LTk2TZLcgRdCxO8suUaO5FSRc6vDXFVIb2JV6kW9LPm7VN O0MNW/Hwt+xY6KLHL7r/ezPkV+4apFiPqRWeP93ihnpGuYh8vNT3/iZu+JbW+X8AOVvw=; To: xen-devel@lists.xenproject.org Subject: [libvirt bisection] complete build-amd64-libvirt Message-Id: From: osstest service owner Date: Thu, 21 Jul 2022 22:25:53 +0000 branch xen-unstable xenbranch xen-unstable job build-amd64-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced: ccfdc6b02932efda5d76e2cd40857db651fca684 Bug not present: 2c846fa6bcc11929c9fb857a22430fb9945654ad Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171750/ (Revision log too long, omitted.) For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/libvirt/build-amd64-libvirt.libvirt-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/libvirt/build-amd64-libvirt.libvirt-build --summary-out=tmp/171750.bisection-summary --basis-template=151777 --blessings=real,real-bisect,real-retry libvirt build-amd64-libvirt libvirt-build Searching for failure / basis pass: 171713 fail [host=himrod0] / 151777 [host=albana0] 151754 [host=albana0] 151729 [host=albana0] 151698 [host=godello1] 151665 [host=godello1] 151638 [host=fiano0] 151608 [host=godello0] 151564 [host=godello0] 151527 [host=godello0] 151496 [host=godello1] 151469 [host=godello1] 151417 [host=godello1] 151396 [host=godello0] 151370 [host=godello0] 151352 [host=godello0] 151330 [host=godello1] 151308 [host=godello1] 151251 [host=godello1] 151229 [host=godello1] 151197 [host=godello1] 151165 [host=go\ dello1] 151091 [host=albana1] 151062 [host=chardonnay1] 151040 [host=fiano1] 150997 [host=godello1] 150932 [host=godello0] 146182 [host=rimava1] 146156 [host=huxelrebe1] 146103 [host=fiano0] 146061 [host=chardonnay1] 145969 [host=godello1] 145906 [host=godello1] 145842 [host=godello1] 145779 [host=godello0] 145511 [host=huxelrebe1] 145212 [host=godello0] 145173 [host=godello0] 145133 [host=godello1] 145054 [host=godello0] 144995 [host=godello1] 144958 [host=albana0] 144920 [host=godello0] 144885\ [host=albana1] 144853 [host=godello1] 144828 [host=godello1] 144802 [host=godello0] 144517 [host=godello0] 144501 [host=godello1] 144408 [host=godello0] 144368 [host=godello1] 144345 [host=godello0] 144318 [host=godello1] 144304 [host=godello1] 144290 [host=godello1] 144279 [host=godello0] 144260 [host=godello1] 144244 [host=godello0] 144233 [host=chardonnay0] 144215 [host=chardonnay0] 144204 [host=godello0] 144192 [host=godello1] 144181 [host=godello1] 144165 [host=godello1] 144144 [host=godel\ lo0] 144097 [host=godello1] 143904 [host=albana0] 143789 [host=godello1] 143589 [host=chardonnay1] 143484 [host=godello1] 143391 [host=huxelrebe1] 143316 [host=chardonnay1] 143263 [host=godello1] 143218 [host=huxelrebe1] 143189 [host=italia0] 143140 [host=italia1] 143051 [host=huxelrebe1] 143023 [host=debina0] 142949 [host=huxelrebe1] 142904 [host=italia0] 142862 [host=huxelrebe1] 142840 [host=godello0] 142798 [host=albana0] 142761 [host=italia0] 142644 [host=baroque0] 142584 [host=huxelrebe1] 1\ 42535 [host=huxelrebe1] 142476 [host=godello0] 142427 [host=godello0] 142384 [host=albana0] 142345 [host=huxelrebe1] 142252 [host=huxelrebe0] 142080 [host=chardonnay0] 141931 [host=godello1] 141893 [host=godello0] 141859 [host=huxelrebe1] 141806 [host=godello0] 141747 [host=huxelrebe1] 141683 [host=huxelrebe0] 141622 [host=godello1] 141569 [host=godello0] 141493 [host=huxelrebe0] 141456 [host=huxelrebe0] 141415 [host=godello1] 141384 [host=godello1] 141356 [host=godello0] 141296 [host=godello0] \ 141264 [host=huxelrebe0] 141241 [host=godello1] 141226 [host=albana1] 141205 [host=albana1] 141081 [host=albana0] 141033 [host=godello0] 140964 [host=godello1] 140904 [host=huxelrebe0] 140860 [host=godello1] 140822 [host=elbling1] 140784 [host=baroque0] 140738 [host=godello1] 140692 [host=godello0] 140598 [host=godello1] 140557 [host=godello0] 140510 [host=godello0] 140454 [host=godello0] 140398 [host=godello1] 140340 [host=godello0] 140277 [host=godello0] 140226 [host=godello1] 139853 [host=deb\ ina0] 139829 [host=godello1] 139790 [host=huxelrebe1] 139756 [host=italia0] 139688 [host=albana1] 139663 [host=italia0] 139627 [host=godello1] 139585 [host=godello1] 139551 [host=godello0] 139516 [host=debina0] 139476 [host=godello0] 139423 [host=godello0] 139393 [host=godello0] 139358 [host=godello0] 139328 [host=albana1] 139303 [host=albana0] 139193 [host=albana1] 139147 [host=godello1] 139076 [host=godello1] 139037 [host=albana0] 138970 [host=albana1] 138940 [host=godello1] 138912 [host=itali\ a0] 138895 [host=godello0] 138876 [host=godello0] 138850 [host=godello1] 138815 [host=albana0] 138804 [host=godello0] 138765 [host=godello0] 138718 [host=godello0] 138695 [host=italia0] 138618 [host=albana0] 138596 [host=albana0] 138569 [host=godello1] 138461 [host=godello0] 138327 [host=godello1] 138190 [host=albana0] 138048 [host=godello0] 137929 [host=godello1] 137736 [host=godello1] 137696 [host=albana1] 137604 [host=godello1] 137460 [host=elbling1] 137375 [host=albana1] 137271 [host=albana1\ ] 137120 [host=rimava1] 137099 [host=godello0] 137063 [host=elbling1] 137022 [host=elbling1] 136910 [host=chardonnay1] 136828 [host=pinot1] 136609 [host=godello1] 136480 [host=albana0] 136321 [host=godello1] 136197 [host=albana0] 136021 [host=baroque1] 135927 [host=rimava1] 135818 [host=albana0] 135687 [host=godello0] 135486 [host=godello1] 135437 [host=rimava1] 135413 [host=rimava1] 135160 [host=pinot1] 135017 [host=pinot1] 134942 [host=albana1] 134793 [host=rimava1] 134685 [host=godello1] 1340\ 04 [host=albana1] 133987 [host=godello0] 133967 [host=albana0] 133930 [host=albana1] 133876 [host=albana0] 133846 [host=godello0] 133798 [host=albana0] 133757 [host=albana0] 133728 [host=albana0] 133672 [host=albana0] 133646 [host=godello0] 133612 [host=godello0] 133582 [host=albana0] 133512 [host=albana0] 133488 [host=albana0] 133460 [host=baroque0] 133368 [host=godello1] 133320 [host=albana0] 133272 [host=godello1] 132941 [host=godello0] 132846 [host=albana0] 132776 [host=godello0] 132745 [hos\ t=godello0] 132664 [host=godello0] 132605 [host=godello1] 132541 [host=godello1] 132511 [host=godello1] 132490 [host=godello1] 132469 [host=godello1] 132453 [host=albana0] 132411 [host=italia0] 132318 [host=godello0] 132083 [host=rimava1] 132027 [host=godello1] 131978 [host=rimava1] 131964 [host=godello0] 131857 [host=godello0] 131792 [host=godello1] 131766 [host=godello1] 131747 [host=godello1] 131730 [host=baroque0] 131710 [host=godello0] 131679 [host=godello1] 131516 [host=godello1] 131484 [h\ ost=godello0] 131453 [host=godello1] 131433 [host=godello1] 131392 [host=debina0] 131364 [host=godello1] 131338 [host=godello1] 131311 [host=debina0] 131287 [host=albana0] 131219 [host=godello0] 131183 [host=fiano0] 131147 [host=godello0] 131116 [host=albana0] 131070 [host=godello0] 130995 [host=albana0] 130894 [host=fiano0] 130856 [host=rimava1] 130824 [host=albana0] 130113 [host=baroque0] 129914 [host=baroque1] 129752 [host=godello0] 129594 [host=chardonnay0] 129491 [host=godello0] 129434 [hos\ t=debina0] 129353 [host=albana0] 129292 [host=baroque1] 129249 [host=baroque1] 129168 [host=baroque1] 128963 [host=albana0] 128942 [host=albana1] 128918 [host=baroque1] 128880 [host=godello0] 128859 [host=albana0] 128833 [host=godello1] 128724 [host=godello0] 128665 [host=albana0] 128603 [host=fiano1] 128521 [host=albana0] 128441 [host=godello0] 128402 [host=godello1] 128367 [host=huxelrebe1] 128331 [host=godello1] 128304 [host=huxelrebe1] 128249 [host=godello0] 123814 [host=godello1] 123575 [ho\ st=huxelrebe0] 123456 [host=godello1] 123391 [host=godello0] 123334 [host=baroque0] 123285 [host=godello1] 123212 [host=huxelrebe0] 123189 [host=chardonnay1] 123120 [host=godello1] 123010 [host=chardonnay1] 122962 [host=godello1] 122887 [host=baroque0] 122801 [host=chardonnay0] 122669 [host=godello0] 122561 [host=elbling1] 122554 [host=godello0] 122527 [host=godello1] 122494 [host=godello1] 122455 [host=godello0] 122404 [host=godello0] 122344 [host=godello0] 122300 [host=godello1] 122224 [host=i\ talia0] 122182 [host=chardonnay0] 122167 [host=huxelrebe0] 122154 [host=godello0] 122005 [host=huxelrebe0] 121946 [host=godello0] 121771 [host=godello0] 121735 [host=godello0] 121707 [host=godello1] 121380 [host=huxelrebe0] 121339 [host=huxelrebe1] 121310 [host=huxelrebe1] 121283 [host=baroque1] 121101 [host=godello1] 121051 [host=godello0] 120982 [host=godello0] 120921 [host=chardonnay1] 120863 [host=fiano0] 120785 [host=godello0] 120666 [host=italia0] 120496 [host=huxelrebe1] 120378 [host=baro\ que1] 120326 [host=godello0] 120277 [host=godello0] 120188 [host=godello1] 120122 [host=godello1] 120084 [host=huxelrebe0] 120053 [host=baroque0] 120004 [host=italia0] 119991 [host=godello1] 119943 [host=italia0] 119874 [host=italia0] 119792 [host=fiano0] 119702 [host=huxelrebe0] 119539 [host=fiano0] 119464 [host=chardonnay1] 119370 [host=pinot0] 119237 [host=godello0] 119049 [host=godello0] 118829 [host=godello0] 118735 [host=godello0] 118667 [host=godello0] 118632 [host=fiano0] 118605 [host=it\ alia0] 118557 [host=chardonnay1] 118545 [host=godello0] 118505 [host=godello1] 118468 [host=godello1] 118447 [host=godello1] 118394 [host=baroque0] 118357 [host=godello0] 118319 [host=elbling1] 118278 [host=fiano0] 118237 [host=godello0] 118200 [host=huxelrebe0] 118137 [host=godello0] 118088 [host=godello1] 117772 [host=godello0] 117737 [host=godello0] 117662 [host=huxelrebe0] 117589 [host=pinot1] 117382 [host=godello0] 117316 [host=godello1] 117233 [host=baroque0] 117182 [host=godello1] 117133 \ [host=godello0] 116965 [host=baroque1] 116935 [host=godello0] 116902 [host=baroque0] 116849 [host=godello1] 116770 [host=godello1] 116732 [host=godello0] 116698 [host=godello1] 116651 [host=godello1] 116607 [host=chardonnay0] 116520 [host=baroque0] 116492 [host=nobling0] 116465 [host=huxelrebe1] 116430 [host=chardonnay0] 116362 [host=godello0] 116328 [host=italia0] 116304 [host=baroque0] 116248 [host=merlot1] 116216 [host=huxelrebe1] 116185 [host=godello0] 116153 [host=godello0] 116130 [host=god\ ello0] 115717 [host=godello1] 115660 [host=rimava1] 115636 [host=nobling0] 115605 [host=godello1] 115583 [host=fiano0] 115549 [host=rimava0] 115509 [host=nobling1] 115476 [host=merlot0] 115415 [host=merlot0] 115312 [host=godello1] 115282 [host=godello0] 115247 [host=godello0] 115202 [host=godello0] 114825 [host=nobling0] 114793 [host=godello1] 114713 [host=godello0] 114669 [host=huxelrebe0] 114531 [host=nobling0] 114503 [host=nobling0] 114452 [host=rimava1] 114395 [host=baroque1] 114088 [host=go\ dello1] 114057 [host=huxelrebe1] 114030 [host=baroque1] 113990 [host=huxelrebe1] 113960 [host=nobling1] 113898 [host=godello1] 113873 [host=fiano0] 113851 [host=godello1] 113821 [host=godello0] 113763 [host=huxelrebe1] 113708 [host=godello0] 113652 [host=nobling1] 113616 [host=godello0] 113592 [host=nobling1] 113495 [host=godello1] 113465 [host=godello1] 113434 [host=huxelrebe1] 113394 [host=chardonnay0] 113350 [host=nobling1] 113159 [host=huxelrebe1] 113141 [host=huxelrebe0] 112276 [host=huxelr\ ebe1] 112201 [host=huxelrebe0] 112119 [host=huxelrebe1] 112081 [host=godello1] 112036 [host=rimava0] 112002 [host=huxelrebe1] 111966 [host=huxelrebe0] 111915 [host=huxelrebe0] 111869 [host=huxelrebe1] 111792 [host=godello0] 111755 [host=godello1] 111718 [host=rimava0] 111662 [host=godello0] 111604 [host=italia1] 111552 [host=rimava0] 111458 [host=huxelrebe1] 111385 [host=rimava1] 111317 [host=rimava0] 111258 [host=godello1] 111209 [host=godello0] 111171 [host=godello1] 111133 [host=godello0] 111\ 061 [host=nocera1] 110999 [host=rimava0] 110962 [host=godello1] 110918 [host=godello0] 110512 [host=baroque0] 110480 [host=huxelrebe1] 110460 [host=godello0] 110425 [host=godello1] 110397 [host=elbling0] 110231 [host=godello1] 110162 [host=baroque0] 110107 [host=godello1] 110065 [host=elbling0] 110026 [host=godello1] 109962 [host=godello0] 109939 [host=chardonnay1] 109882 [host=huxelrebe0] 109846 [host=huxelrebe0] 109793 [host=huxelrebe1] 109759 [host=chardonnay0] 109736 [host=chardonnay1] 10970\ 9 [host=huxelrebe1] 109692 [host=godello0] 109637 [host=elbling1] 109603 [host=chardonnay0] 109561 [host=huxelrebe1] 109516 [host=elbling1] 109466 [host=godello0] 109375 [host=godello0] 109340 [host=godello1] 109301 [host=chardonnay1] 109246 [host=chardonnay1] 109203 [host=godello1] 109062 [host=godello1] 108177 [host=godello0] 107640 [host=godello1] 107613 [host=godello1] 107594 [host=elbling1] 107577 [host=huxelrebe1] 107556 [host=godello1] 107536 [host=godello1] 107442 [host=godello0] 107417 \ [host=godello0] 107384 [host=godello1] 107362 [host=godello0] 107353 [host=huxelrebe1] 107325 [host=godello0] 107298 [host=huxelrebe1] 107262 [host=fiano1] 107207 [host=baroque0] 107172 [host=baroque0] 107143 [host=huxelrebe1] 107101 [host=italia0] 107056 [host=baroque0] 107016 [host=huxelrebe1] 106989 [host=huxelrebe1] 106952 [host=baroque0] 106931 [host=godello0] 106924 [host=baroque0] 106906 [host=godello1] 106883 [host=godello0] 106855 [host=chardonnay1] 106829 [host=godello0] 106800 [host=r\ imava0] 106755 [host=huxelrebe0] 106707 [host=chardonnay1] 106678 [host=godello1] 106650 [host=godello0] 106628 [host=godello0] 106608 [host=godello1] 106594 [host=huxelrebe0] 106583 [host=baroque0] 106562 [host=godello1] 106543 [host=chardonnay1] 106510 [host=godello0] 106483 [host=huxelrebe0] 106473 [host=godello1] 106434 [host=godello0] 106394 [host=baroque0] 106352 [host=huxelrebe0] 106226 [host=huxelrebe0] 106101 [host=godello0] 105973 [host=godello1] 105938 [host=godello0] 105921 [host=hux\ elrebe0] 105902 [host=nocera0] 105895 [host=godello0] 105870 [host=godello1] 105805 [host=italia1] 105785 [host=godello0] 105759 [host=huxelrebe0] 105720 [host=italia1] 105684 [host=godello0] 105657 [host=huxelrebe0] 105624 [host=huxelrebe0] 105434 [host=godello0] 105325 [host=huxelrebe0] 105262 [host=italia1] 105188 [host=huxelrebe0] 105075 [host=nobling0] 104989 [host=godello1] 104886 [host=godello1] 104742 [host=godello1] 104685 [host=italia1] 104636 [host=nobling0] 104617 [host=nobling1] 104\ 579 [host=godello0] 104401 [host=merlot0] 104327 [host=nobling1] 104283 [host=godello0] 104238 [host=nobling1] 104199 [host=huxelrebe1] 104179 [host=nobling1] 104158 [host=huxelrebe1] 104134 [host=nobling0] 104110 [host=nobling0] 104093 [host=elbling1] 104076 [host=elbling1] 104072 [host=nobling1] 104053 [host=nobling1] 104036 [host=nobling1] 104021 [host=huxelrebe1] 104005 [host=huxelrebe1] 103915 [host=nobling1] 103827 [host=nobling0] 103798 [host=nobling1] 103479 [host=godello0] 103403 [host=\ godello0] 103329 [host=baroque0] 103263 [host=godello0] 103190 [host=godello1] 103065 [host=huxelrebe0] 102983 [host=godello1] 102921 [host=chardonnay0] 102830 [host=godello1] 102776 [host=godello1] 102750 [host=nobling0] 102726 [host=baroque0] 102706 [host=godello0] 102660 [host=godello0] 102640 [host=chardonnay1] 102603 [host=nobling0] 102550 [host=godello1] 102503 [host=nobling0] 102469 [host=godello1] 102443 [host=baroque0] 102375 [host=baroque0] 102332 [host=chardonnay1] 102283 [host=godell\ o0] 102251 [host=godello0] 102178 [host=fiano1] 102144 [host=baroque0] 102108 [host=godello0] 102082 [host=nobling0] 102058 [host=godello1] 102026 [host=chardonnay1] 101948 [host=godello0] 101915 [host=godello1] 101854 [host=baroque0] 101839 [host=baroque0] 101773 [host=chardonnay1] 101738 [host=godello0] 101711 [host=godello0] 101677 [host=godello1] 101656 [host=godello1] 101640 [host=nobling0] 101629 [host=elbling1] 101602 [host=elbling1] 101573 [host=godello0] 101557 [host=chardonnay1] 101538\ [host=godello0] 101502 [host=godello1] 101477 [host=godello0] 101461 [host=italia0] 101436 [host=italia0] 101412 [host=godello0] 101386 [host=godello1] 101368 [host=chardonnay0] 101349 [host=chardonnay0] 101333 [host=godello1] 101321 [host=godello0] 101301 [host=godello0] 101270 [host=huxelrebe1] 101232 [host=huxelrebe1] 101218 [host=huxelrebe1] 101200 [host=godello1] 101176 [host=huxelrebe1] 101161 [host=godello1] 101142 [host=baroque1] 101120 [host=huxelrebe1] 101094 [host=pinot0] 101072 [hos\ t=huxelrebe1] 101029 [host=godello1] 100999 [host=godello1] 100995 [host=godello1] 100962 [host=godello1] 100945 [host=huxelrebe1] 100912 [host=baroque1] 100866 [host=godello0] 100837 [host=baroque1] 100802 [host=huxelrebe1] 100782 [host=godello0] 100744 [host=godello1] 100715 [host=baroque1] 100671 [host=godello0] 100658 [host=huxelrebe1] 100643 [host=huxelrebe1] 100628 [host=godello0] 100615 [host=baroque1] 100603 [host=italia0] 100593 [host=italia0] 100575 [host=godello0] 100571 [host=baroque\ 1] 100553 [host=baroque1] 100538 [host=huxelrebe1] 100525 [host=huxelrebe1] 100509 [host=italia0] 100482 [host=fiano0] 100472 [host=godello0] 100426 [host=fiano0] 100404 [host=fiano0] 100381 [host=godello0] 99955 [host=chardonnay1] 99936 [host=baroque1] 99913 [host=italia0] 99895 [host=godello0] 99788 [host=godello0] 99738 [host=chardonnay1] 99696 [host=godello0] 97742 [host=godello0] 97688 [host=godello0] 97638 [host=godello0] 97416 [host=huxelrebe0] 97340 [host=godello1] 97286 [host=godello0] \ 97003 [host=godello0] 96904 [host=godello1] 96831 [host=baroque1] 96778 [host=godello0] 96664 [host=godello1] 96518 [host=baroque1] 96491 [host=baroque0] 96450 [host=huxelrebe0] 96364 [host=huxelrebe0] 96333 [host=pinot1] 96299 [host=fiano1] 96270 [host=baroque1] 96237 [host=godello0] 96204 [host=godello1] 96157 [host=godello0] 96095 [host=godello0] 96038 [host=godello1] 95913 [host=baroque0] 95873 [host=godello1] 95846 [host=pinot1] 95814 [host=baroque1] 95460 [host=godello0] 95419 [host=baroqu\ e1] 95358 [host=baroque1] 95282 [host=baroque1] 95255 [host=baroque0] 95220 [host=baroque0] 95095 [host=huxelrebe0] 94970 [host=fiano1] 94874 [host=rimava0] 94785 [host=huxelrebe0] 94751 [host=huxelrebe0] 94734 [host=baroque0] 94591 [host=pinot1] 94572 [host=fiano1] 94539 [host=pinot1] 94502 [host=chardonnay1] 94465 [host=pinot1] 94338 [host=rimava0] 94142 [host=rimava0] 94073 [host=baroque0] 94052 [host=rimava0] 94018 [host=italia0] 93954 [host=rimava1] 93880 [host=pinot1] 93821 [host=italia0] \ 93731 [host=rimava1] 93589 [host=baroque0] 93516 [host=rimava0] 93388 [host=elbling1] 93343 [host=baroque1] 93284 [host=baroque0] 93223 [host=baroque1] 93129 [host=italia0] 92799 [host=baroque1] 92667 [host=godello0] 92533 [host=godello0] 92421 [host=godello1] 92320 [host=godello1] 91479 [host=godello0] 91380 [host=elbling1] 91230 [host=elbling1] 91073 [host=elbling1] 90907 [host=italia1] 88483 [host=godello0] 88359 [host=godello1] 88247 [host=elbling1] 88091 [host=elbling1] 87976 [host=godello1\ ] 87831 [host=godello1] 87702 [host=godello0] 87404 [host=godello0] 87264 [host=godello1] 87134 [host=godello0] 86994 [host=godello0] 86883 [host=italia1] 86783 [host=baroque0] 86710 [host=elbling0] 86625 [host=italia1] 86536 [host=elbling0] 86448 [host=italia1] 86369 [host=godello0] 86026 [host=baroque1] 85976 [host=godello0] 85871 [host=godello1] 85689 [host=baroque1] 85412 [host=godello1] 85296 [host=godello0] 85151 [host=godello0] 85019 [host=godello0] 84468 [host=godello1] 84215 [host=fiano\ 1] 84072 [host=italia1] 83847 [host=godello0] 83714 [host=italia1] 83396 [host=pinot0] 83119 [host=huxelrebe0] 82949 [host=godello1] 82783 [host=godello1] 82637 [host=italia1] 82511 [host=godello1] 81975 [host=godello1] 81645 [host=godello1] 81366 [host=italia1] 81092 [host=godello1] 80855 [host=italia1] 80615 [host=godello1] 80382 [host=godello1] 80121 [host=pinot1] 79451 [host=pinot1] 79390 [host=godello1] 79209 [host=italia1] 79146 [host=godello0] 79069 [host=godello0] 78978 [host=italia1] 78\ 787 [host=godello0] 78659 [host=chardonnay0] 78582 [host=godello0] 78488 [host=italia0] 78311 [host=pinot0] 78228 [host=godello1] 78148 [host=godello1] 78066 [host=chardonnay1] 77993 [host=chardonnay1] 77934 [host=italia0] 77871 [host=baroque0] 77788 [host=godello0] 77684 [host=godello1] 77517 [host=godello1] 77324 [host=pinot0] 77211 [host=godello1] 77096 [host=godello1] 66919 [host=italia0] 66579 [host=huxelrebe1] 66498 [host=godello0] 66450 [host=godello1] 66413 [host=godello1] 65654 [host=ri\ mava1] 65460 [host=godello0] 65419 [host=baroque0] 65394 [host=godello0] 65353 [host=godello0] 65324 [host=baroque0] 65296 [host=godello0] 65281 [host=nocera0] 65260 [host=nocera0] 65243 [host=italia0] 65177 [host=godello1] 65151 [host=baroque1] 65124 [host=godello0] 65096 [host=godello0] 65068 [host=godello1] 65035 [host=godello0] 65004 [host=pinot1] 64980 [host=godello1] 64932 [host=godello0] 64762 [host=pinot0] 64520 [host=godello0] 64408 [host=godello1] 64291 [host=godello1] 64179 [host=gode\ llo1] 64130 [host=nocera0] 64021 [host=nocera1] 63903 [host=godello1] 63733 [host=godello0] 63702 [host=nocera1] 63578 [host=italia0] 63528 [host=godello1] 63469 [host=godello0] 63397 [host=godello0] 63373 [host=nocera0] 63352 [host=nocera1] 63340 [host=nocera0] 63231 [host=nocera1] 63207 [host=baroque0] 63022 [host=nocera0] 62995 [host=nocera0] 62973 [host=nocera0] 62955 [host=nocera0] 62942 [host=nocera0] 62807 [host=nocera1] 62727 [host=nocera1] 62701 [host=nocera0] 62666 [host=nocera0] 62618\ [host=nocera1] 62551 [host=nocera1] 62435 [host=nocera1] 62281 [host=nocera0] 62175 [host=nocera0] 62098 [host=nocera1] 62029 [host=nocera0] 61890 [host=nocera0] 61770 [host=nocera0] 61675 [host=nocera0] 61593 [host=nocera1] 61304 [host=nocera0] 61259 [host=nocera1] 61008 [host=nocera0] 60961 [host=nocera1] 60880 [host=nocera1] 60848 [host=nocera0] 60814 [host=nocera0] 60779 [host=nocera1] 60715 [host=nocera0] 60681 [host=nocera1] 60663 [host=nocera0] 60650 [host=nocera0] 60629 [host=nocera1] 6\ 0612 [host=nocera1] 60568 [host=nocera1] 60183 [host=nocera1] 60102 [host=nocera1] 60058 [host=nocera0] 60006 [host=nocera0] 59948 [host=nocera0] 59907 [host=pinot1] 59834 [host=nocera1] 59787 [host=nocera0] 59768 [host=godello0] 59730 [host=godello0] 59650 [host=godello1] 59560 [host=godello0] 59533 [host=godello1] 59488 [host=nocera1] 59464 [host=nocera0] 59428 [host=nocera0] 59350 [host=nocera1] 59256 [host=nocera0] 59185 [host=nocera0] 59132 [host=nocera0] 59088 [host=nocera0] 59038 [host=no\ cera0] 59020 [host=nocera1] 59004 [host=nocera0] 58984 [host=nocera0] 58967 [host=godello1] 58945 [host=nocera0] 58932 [host=nocera1] 58899 [host=nocera1] 58870 [host=nocera0] 58842 [host=nocera1] 58823 [host=godello1] 58767 [host=nocera0] 58738 [host=nocera0] 58713 [host=pinot0] 58643 [host=pinot0] 58510 [host=italia0] 58426 [host=nocera1] 58401 [host=nocera0] 58334 [host=godello1] 58230 [host=godello1] 58161 [host=nocera0] 58119 [host=nocera0] 58015 [host=nocera1] 57914 [host=nocera1] 57859 [h\ ost=nocera0] 57792 [host=nocera1] 57652 [host=nocera1] 57517 [host=nocera1] 57444 [host=nocera1] 57291 [host=italia0] 57206 [host=godello1] 57124 [host=godello1] 57032 [host=nocera0] 56966 [host=nocera1] 56876 [host=nocera0] 56793 [host=nocera0] 56719 [host=nocera0] 56661 [host=nocera0] 56590 [host=nocera0] 56509 [host=nocera0] 56415 [host=godello0] 55443 [host=nocera0] 55349 [host=nocera1] 55257 [host=godello1] 53854 [host=italia0] 53749 [host=baroque1] 53657 [host=baroque1] 53293 [host=pinot1]\ 53021 [host=godello1] 52703 [host=pinot1] 50417 [host=godello0] 50401 [host=baroque1] 50385 [host=pinot1] 50368 [host=nocera0] 50325 [host=baroque0] 50308 [host=nocera0] 50277 [host=baroque0] 36774 [host=gall-mite] 36729 [host=rice-weevil] 36702 [host=bush-cricket] 36630 [host=bush-cricket] 36571 [host=moss-bug] 36520 [host=rice-weevil] 36071 [host=grain-weevil] 35968 [host=rice-weevil] 35907 [host=lace-bug] 35863 [host=grain-weevil] 35800 [host=bush-cricket] 35683 [host=itch-mite] 35524 [host=\ grain-weevil] 35360 [host=rice-weevil] 35260 [host=itch-mite] 34801 [host=grain-weevil] 34668 [host=bush-cricket] 34580 [host=scape-moth] 34542 [host=grain-weevil] 34500 [host=scape-moth] 34464 [host=grain-weevil] 34420 [host=bush-cricket] 34292 [host=field-cricket] 34214 [host=grain-weevil] 34168 [host=scape-moth] 34128 [host=lace-bug] 33874 [host=bush-cricket] 33834 [host=grain-weevil] 33811 [host=scape-moth] 33772 [host=bush-cricket] 33698 [host=grain-weevil] 33657 [host=scape-moth] 33422 [ho\ st=grain-weevil] 33404 [host=grain-weevil] 33382 [host=grain-weevil] 33354 [host=grain-weevil] 33316 [host=rice-weevil] 32648 [host=field-cricket] 32617 [host=field-cricket] 32596 [host=scape-moth] 32576 [host=bush-cricket] 32555 [host=field-cricket] 32534 [host=scape-moth] 32508 [host=scape-moth] 32471 [host=scape-moth] 32433 [host=scape-moth] 32414 [host=bush-cricket] 32351 [host=field-cricket] 32330 [host=field-cricket] 32308 [host=moss-bug] 32272 [host=grain-weevil] 32217 [host=worm-moth] 32\ 137 [host=field-cricket] 32005 [host=bush-cricket] 31928 [host=bush-cricket] 31860 [host=scape-moth] 31852 [host=field-cricket] 31839 [host=rice-weevil] 31827 [host=grain-weevil] 31787 [host=scape-moth] 31761 [host=field-cricket] 31680 [host=bush-cricket] 31660 [host=scape-moth] 31595 [host=rice-weevil] 31566 [host=field-cricket] 31532 [host=field-cricket] 31508 [host=field-cricket] 31485 [host=lace-bug] 31465 [host=bush-cricket] 31392 [host=rice-weevil] 31372 [host=bush-cricket] 31327 [host=wor\ m-moth] 31284 [host=scape-moth] 31267 [host=scape-moth] 31242 [host=rice-weevil] 30985 [host=rice-weevil] 30919 [host=bush-cricket] 30869 [host=bush-cricket] 30857 [host=itch-mite] 30845 [host=bush-cricket] 30794 [host=rice-weevil] 30765 [host=scape-moth] 30748 [host=rice-weevil] 30731 [host=rice-weevil] 30718 [host=scape-moth] 30695 [host=rice-weevil] 30682 [host=field-cricket] 30668 [host=bush-cricket] 30658 [host=bush-cricket] 30599 [host=bush-cricket] 30589 [host=scape-moth] 30565 [host=scap\ e-moth] 30544 [host=worm-moth] 30529 [host=worm-moth] 30517 [host=rice-weevil] 30408 [host=scape-moth] 30376 [host=scape-moth] 30357 [host=rice-weevil] 30337 [host=bush-cricket] 30324 [host=grain-weevil] 30313 [host=grain-weevil] 30297 [host=worm-moth] 30286 [host=worm-moth] 30275 [host=worm-moth] 30269 [host=rice-weevil] 30260 [host=bush-cricket] 30238 [host=scape-moth] 30226 [host=scape-moth] 30200 [host=scape-moth] 30179 [host=worm-moth] 30154 [host=grain-weevil] 30147 [host=rice-weevil] 3013\ 3 [host=scape-moth] 30105 [host=worm-moth] 30099 [host=grain-weevil] 30085 [host=bush-cricket] 30051 [host=worm-moth] 30033 [host=bush-cricket] 30020 [host=bush-cricket] 29997 [host=bush-cricket] 29972 [host=bush-cricket] 29956 [host=grain-weevil] 29943 [host=scape-moth] 29909 [host=bush-cricket] 29875 [host=scape-moth] 29845 [host=itch-mite] 29817 [host=itch-mite] 29789 [host=grain-weevil] 29757 [host=bush-cricket] 29729 [host=itch-mite] 29712 [host=gall-mite] 29693 [host=rice-weevil] 29681 [ho\ st=gall-mite] 29676 [host=bush-cricket] 29670 [host=rice-weevil] 29664 [host=itch-mite] 29653 [host=rice-weevil] 29641 [host=rice-weevil] 29625 [host=bush-cricket] 29610 [host=rice-weevil] 29597 [host=bush-cricket] 29585 [host=grain-weevil] 29575 [host=bush-cricket] 29539 [host=bush-cricket] 29520 [host=grain-weevil] 29483 [host=bush-cricket] 29469 [host=moss-bug] 29457 [host=moss-bug] 29444 [host=moss-bug] 29434 [host=itch-mite] 29400 [host=bush-cricket] 29386 [host=itch-mite] 29377 [host=bush-\ cricket] 29360 [host=grain-weevil] 29331 [host=bush-cricket] 29303 [host=field-cricket] 29190 [host=gall-mite] 29087 [host=itch-mite] 28938 [host=gall-mite] 28916 [host=itch-mite] 28875 [host=woodlouse] 27864 [host=grain-weevil] 27845 [host=field-cricket] 27782 [host=gall-mite] 27525 [host=bush-cricket] 27479 [host=bush-cricket] 27452 [host=itch-mite] 27428 [host=bush-cricket] 27413 [host=bush-cricket] 27393 [host=gall-mite] 27248 [host=lace-bug] 27159 [host=bush-cricket] 27069 [host=bush-cricke\ t] 27058 [host=itch-mite] 27035 [host=itch-mite] 27021 [host=rice-weevil] 27005 [host=rice-weevil] 26994 [host=rice-weevil] 26970 [host=gall-mite] 26932 [host=rice-weevil] 26885 [host=moss-bug] 26664 [host=grain-weevil] 26551 [host=gall-mite] 26506 [host=gall-mite] 26483 [host=potato-beetle] 26372 [host=gall-mite] 26358 [host=itch-mite] 26314 [host=rice-weevil] 26292 [host=rice-weevil] 26262 [host=field-cricket] 26232 [host=rice-weevil] 26227 [host=gall-mite] 26205 [host=gall-mite] 26197 [host=i\ tch-mite] 26175 [host=gall-mite] 26159 [host=moss-bug] 26144 [host=moss-bug] 26128 [host=moss-bug] 25911 [host=gall-mite] 25910 [host=gall-mite] 25903 [host=gall-mite] 25902 [host=leaf-beetle] template as basis? using template as basis. Failure / basis pass flights: 171713 / 151777 (tree with no url: minios) Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 3b8cee1781c4149c7a762b8a1c8115b635cf4cad 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 Generating revisions with ./adhoc-revtuple-generator git://libvirt.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-ccfdc6b02932efda5d76e2cd40857db651fca684 https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-57ba70da5312170883a3d622cd2aa3fd0e2ec7ae git://xenbits.xen.org/osstest/ovmf.git#bdafda8c457eb90c65f37026589b54258300f05c-3b8cee1781c4149c7a762b8a1c8115b635cf4cad git://xenbits.xen.org/qemu-xen-traditional.git#3c659044118e34603161457db9934a34f816d\ 78b-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#ea6d3cd1ed79d824e605a70c3626bc437c386260-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/osstest/seabios.git#88ab0c15525ced2eefe39220742efe4769089ad8-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#3fdc211b01b29f252166937238efe02d15cb5780-6fe2e39a0243bddba60f83b77b972a5922d25eb8 adhoc-revtuple-generator: tree discontiguous: libvirt adhoc-revtuple-generator: tree discontiguous: qemu-xen Loaded 12668 nodes in revision graph Searching for test results: 151729 [host=albana0] 151754 [host=albana0] 151777 [host=albana0] 151822 [host=albana1] 151818 [host=albana1] 151842 [host=albana1] 151858 [host=albana1] 151883 [host=albana0] 151910 [host=albana0] 151935 [host=albana0] 151956 [host=albana0] 151984 [host=albana1] 152006 [host=albana1] 152034 [host=albana0] 152064 [host=albana0] 152094 [host=albana1] 152135 [host=albana0] 152167 [host=albana0] 152226 [host=albana1] 152209 [host=albana1] 152278 [host=albana1] 152193 [host=albana0] 152247 [host=albana1] 152317 [host=albana1] 152296 [host=albana1] 152339 [host=albana0] 152377 [host=albana0] 152408 [host=albana1] 152454 [host=albana0] 152482 [host=albana0] 152502 [host=albana0] 152512 [host=albana0] 152569 [host=albana0] 152558 [host=albana1] 152535 [host=albana0] 152595 [host=albana1] 152539 [host=albana0] 152549 [host=albana0] 152585 [host=albana1] 152628 [host=albana1] 152651 [host=albana1] 152666 [host=albana0] 152686 [host=albana0] 152720 [host=albana1] 162794 [host=himrod1] 152784 [host=albana1] 152845 [host=albana0] 167361 [host=himrod2] 152881 [host=albana0] 162829 [host=himrod1] 152955 [] 165325 [host=himrod2] 153032 [] 162852 [host=himrod2] 162870 [host=himrod1] 162888 [host=himrod2] 153144 [] 165373 [host=himrod2] 165395 [host=himrod2] 153338 [] 153440 [] 166965 [host=himrod2] 153608 [] 165412 [host=himrod2] 165424 [host=himrod2] 165441 [host=himrod2] 162985 [host=himrod1] 153534 [] 153678 [] 163011 [host=himrod2] 163026 [host=himrod2] 153853 [] 153783 [] 165451 [host=himrod1] 165461 [host=himrod1] 153999 [] 166997 [host=himrod1] 165473 [host=himrod2] 167224 [host=himrod2] 167226 [host=himrod1] 153928 [] 163139 [host=himrod2] 154043 [host=albana1] 167238 [host=himrod1] 163111 [host=himrod1] 154097 [host=albana0] 165489 [host=himrod1] 154154 [host=himrod1] 163164 [host=himrod1] 165504 [host=himrod1] 163178 [host=himrod1] 154238 [host=himrod1] 154313 [host=himrod1] 154415 [host=himrod1] 163191 [host=himrod1] 163208 [host=himrod1] 154353 [host=himrod1] 154454 [host=himrod1] 163223 [host=himrod2] 154374 [host=himrod1] 154561 [host=himrod2] 163236 [host=himrod1] 154605 [host=himrod2] 154489 [host=himrod1] 154632 [host=himrod2] 163295 [host=himrod2] 165516 [host=himrod2] 154675 [host=himrod2] 165533 [host=himrod1] 163308 [host=himrod1] 163322 [host=himrod1] 154520 [host=himrod1] 155067 [host=himrod1] 165595 [host=himrod1] 155123 [host=himrod1] 167499 [host=himrod2] 163382 [host=himrod1] 155193 [host=himrod1] 155429 [host=himrod2] 163431 [host=himrod1] 155301 [host=himrod1] 155475 [host=himrod1] 155500 [host=himrod1] 155397 [host=himrod1] 155511 [host=himrod1] 155543 [host=himrod1] 165633 [host=himrod2] 155588 [host=himrod1] 155721 [host=himrod1] 165658 [host=himrod1] 163466 [host=himrod2] 155762 [host=himrod1] 155793 [host=himrod1] 155634 [host=himrod2] 163510 [host=himrod2] 155831 [host=himrod2] 155678 [host=himrod2] 155948 [host=himrod1] 163555 [host=himrod1] 155974 [host=himrod2] 156012 [host=himrod2] 155885 [host=himrod1] 165683 [host=himrod1] 155920 [host=himrod2] 165702 [host=himrod1] 156163 [host=himrod1] 156059 [host=himrod2] 156201 [host=himrod2] 156082 [host=himrod1] 156233 [host=himrod2] 163588 [host=himrod2] 156114 [host=himrod2] 156253 [host=himrod2] 156290 [host=himrod2] 163630 [host=himrod2] 156314 [host=himrod2] 156273 [host=himrod2] 156376 [host=himrod1] 156328 [host=himrod2] 165735 [host=himrod1] 156391 [host=himrod1] 156340 [host=himrod2] 163669 [host=himrod1] 156357 [host=himrod1] 156509 [host=himrod2] 156537 [host=himrod1] 163704 [host=himrod2] 156405 [] 156549 [host=himrod1] 156579 [host=himrod2] 156611 [host=himrod2] 156639 [host=himrod2] 167066 [host=himrod2] 156800 [host=himrod2] 163728 [host=himrod1] 156808 [host=himrod2] 156817 [host=himrod2] 156671 [host=himrod2] 163760 [host=himrod2] 156828 [host=himrod2] 163773 [host=himrod1] 156702 [host=himrod2] 156870 [host=himrod1] 156847 [host=himrod1] 163796 [host=himrod2] 156731 [host=himrod1] 156977 [host=himrod2] 163829 [host=himrod2] 156892 [host=himrod1] 157000 [host=himrod2] 157022 [host=himrod1] 156915 [host=himrod1] 157045 [host=himrod1] 157067 [host=himrod1] 165803 [host=himrod1] 157084 [host=himrod2] 157106 [host=himrod2] 156938 [host=himrod1] 157125 [host=himrod2] 163862 [host=himrod1] 156958 [host=himrod2] 157150 [host=himrod1] 157171 [host=himrod2] 157251 [host=himrod2] 165829 [host=himrod1] 163893 [host=himrod2] 157274 [host=himrod1] 157195 [host=himrod1] 167382 [host=himrod2] 157339 [host=himrod1] 157216 [host=himrod1] 167390 [host=himrod2] 167405 [host=himrod1] 165852 [host=himrod1] 157369 [host=himrod1] 163933 [host=himrod2] 157235 [host=himrod1] 157404 [] 157453 [host=himrod2] 157481 [] 157543 [] 163973 [host=himrod1] 165871 [host=himrod1] 163982 [host=himrod2] 163994 [host=himrod1] 157516 [host=himrod2] 164004 [host=himrod2] 157593 [host=himrod2] 165890 [host=himrod1] 164017 [host=himrod2] 157715 [host=himrod2] 157624 [host=himrod2] 164032 [host=himrod1] 157735 [host=himrod1] 157661 [host=himrod2] 157750 [host=himrod1] 164050 [host=himrod2] 157867 [host=himrod1] 165922 [host=himrod1] 157844 [host=himrod2] 164063 [host=himrod2] 165931 [host=himrod1] 164070 [host=himrod2] 164080 [host=himrod1] 165944 [host=himrod1] 157885 [host=himrod1] 164088 [host=himrod1] 157781 [host=himrod1] 157904 [host=himrod1] 157933 [host=himrod1] 165955 [host=himrod2] 157953 [host=himrod1] 157970 [host=himrod2] 158065 [host=himrod2] 164099 [host=himrod1] 165968 [host=himrod2] 158083 [host=himrod1] 164108 [host=himrod2] 158099 [host=himrod2] 165985 [host=himrod2] 164118 [host=himrod1] 158118 [host=himrod2] 164130 [host=himrod2] 164124 [host=himrod1] 164140 [host=himrod2] 164147 [host=himrod2] 158023 [host=himrod2] 158147 [host=himrod2] 164156 [host=himrod1] 164165 [host=himrod1] 158274 [host=himrod2] 158188 [host=himrod2] 164175 [host=himrod1] 164184 [host=himrod1] 166764 [host=himrod2] 158294 [host=himrod1] 164190 [host=himrod1] 158238 [host=himrod2] 164201 [host=himrod1] 158310 [host=himrod1] 158344 [host=himrod1] 158350 [host=himrod1] 158431 [host=himrod1] 158374 [host=himrod1] 164223 [host=himrod2] 164236 [host=himrod2] 158460 [host=himrod1] 166024 [host=himrod2] 158469 [host=himrod1] 164249 [host=himrod2] 158397 [host=himrod2] 158485 [host=himrod1] 158415 [host=himrod2] 158569 [host=himrod2] 158587 [host=himrod2] 158509 [host=himrod2] 158597 [host=himrod1] 158610 [host=himrod1] 158535 [host=himrod2] 164268 [host=himrod2] 158623 [host=himrod2] 166040 [host=himrod1] 158551 [host=himrod1] 166050 [host=himrod1] 166067 [host=himrod2] 158700 [host=himrod1] 158717 [host=himrod1] 164311 [host=himrod2] 158805 [host=himrod2] 158761 [host=himrod1] 158842 [host=himrod2] 158935 [host=himrod1] 158878 [host=himrod1] 159031 [host=himrod1] 166076 [host=himrod2] 164374 [host=himrod1] 166082 [host=himrod2] 166091 [host=himrod2] 158973 [host=himrod1] 167130 [host=himrod2] 166103 [host=himrod1] 166112 [host=himrod1] 166121 [host=himrod2] 159152 [host=himrod1] 166137 [host=himrod1] 164423 [host=himrod2] 159239 [host=himrod1] 159284 [host=himrod1] 166143 [host=himrod1] 159318 [host=himrod2] 166148 [host=himrod2] 159338 [host=himrod1] 159401 [host=himrod1] 159366 [host=himrod1] 166153 [host=himrod2] 159437 [host=himrod2] 159537 [host=himrod2] 159454 [host=himrod1] 166161 [host=himrod1] 166182 [host=himrod2] 159471 [host=himrod2] 166191 [host=himrod1] 159486 [host=himrod1] 159570 [host=himrod1] 164498 [host=himrod1] 164470 [host=himrod1] 159613 [host=himrod1] 159507 [host=himrod2] 164514 [host=himrod2] 159656 [host=himrod2] 167423 [host=himrod1] 159782 [host=himrod2] 167473 [host=himrod1] 164539 [host=himrod1] 159693 [host=himrod1] 159790 [host=himrod1] 167481 [host=himrod1] 159799 [host=himrod1] 167488 [host=himrod1] 159812 [host=himrod2] 159723 [host=himrod1] 159885 [host=himrod2] 159903 [host=himrod2] 159824 [host=himrod1] 159928 [host=himrod1] 159832 [host=himrod1] 164603 [host=himrod1] 166203 [host=himrod1] 167178 [host=himrod1] 159845 [host=himrod2] 159969 [host=himrod2] 159854 [host=himrod2] 160053 [host=himrod2] 159865 [host=himrod2] 160071 [host=himrod2] 160122 [host=himrod2] 166236 [host=himrod1] 160085 [host=himrod2] 160135 [host=himrod2] 166264 [host=himrod2] 160093 [host=himrod1] 160151 [host=himrod1] 160107 [host=himrod2] 160164 [host=himrod1] 164641 [host=himrod2] 160406 [host=himrod1] 160262 [host=himrod1] 164677 [host=himrod2] 166305 [host=himrod2] 160350 [host=himrod2] 164688 [host=himrod1] 160434 [host=himrod1] 160379 [host=himrod2] 160546 [host=himrod1] 160464 [host=himrod1] 160576 [host=himrod1] 160490 [host=himrod1] 160634 [host=himrod2] 160519 [host=himrod2] 160740 [host=himrod2] 164745 [host=himrod2] 166340 [host=himrod2] 160661 [host=himrod2] 160761 [host=himrod2] 160783 [host=himrod1] 160690 [host=himrod1] 167325 [host=himrod1] 160890 [host=himrod2] 164852 [host=himrod1] 164789 [host=himrod2] 164803 [host=himrod1] 164870 [host=himrod2] 160937 [host=himrod1] 160813 [host=himrod1] 161037 [host=himrod1] 164822 [host=himrod2] 166374 [host=himrod1] 160845 [host=himrod2] 161078 [host=himrod2] 161157 [host=himrod2] 164880 [host=himrod1] 161192 [host=himrod1] 161119 [host=himrod1] 161223 [host=himrod1] 164895 [host=himrod1] 161311 [host=himrod2] 161345 [host=himrod1] 161251 [host=himrod2] 161369 [host=himrod2] 164935 [host=himrod2] 164947 [host=himrod1] 164964 [host=himrod2] 164953 [host=himrod2] 161398 [host=himrod1] 161282 [host=himrod2] 164978 [host=himrod2] 164990 [host=himrod2] 161459 [host=himrod2] 161423 [host=himrod2] 161475 [host=himrod1] 161443 [host=himrod2] 161516 [host=himrod1] 161496 [host=himrod2] 165005 [host=himrod2] 161596 [host=himrod1] 161542 [host=himrod2] 161615 [host=himrod1] 165028 [host=himrod1] 161570 [host=himrod1] 161698 [host=himrod1] 161827 [host=himrod2] 161783 [host=himrod2] 161804 [host=himrod1] 161848 [host=himrod1] 161871 [host=himrod1] 161889 [host=himrod1] 161956 [host=himrod1] 161913 [host=himrod2] 161927 [host=himrod1] 161944 [host=himrod1] 161966 [host=himrod1] 165104 [host=himrod2] 161975 [host=himrod2] 162076 [host=himrod2] 161988 [host=himrod1] 162100 [host=himrod1] 165126 [host=himrod1] 162110 [host=himrod2] 165137 [host=himrod2] 162120 [host=himrod2] 165148 [host=himrod1] 162128 [host=himrod2] 162191 [host=himrod1] 162138 [host=himrod2] 162243 [host=himrod1] 167444 [host=himrod2] 162254 [host=himrod1] 162263 [host=himrod2] 162147 [host=himrod1] 167457 [host=himrod1] 162272 [host=himrod1] 162295 [host=himrod1] 162159 [host=himrod1] 162390 [host=himrod1] 162332 [host=himrod1] 165162 [host=himrod1] 162427 [host=himrod1] 166956 [host=himrod1] 162345 [host=himrod2] 165201 [host=himrod2] 162360 [host=himrod2] 165177 [host=himrod2] 165189 [host=himrod1] 162481 [host=himrod1] 165228 [host=himrod1] 165214 [host=himrod2] 162563 [host=himrod2] 162535 [host=himrod2] 162598 [host=himrod1] 162760 [host=himrod1] 162632 [host=himrod2] 167511 [host=himrod2] 162681 [host=himrod1] 167525 [host=himrod1] 167582 [host=himrod1] 167533 [host=himrod1] 167607 [host=himrod1] 167538 [host=himrod1] 167589 [host=himrod2] 167542 [host=himrod1] 167594 [host=himrod1] 167546 [host=himrod2] 167600 [host=himrod2] 167551 [host=himrod2] 167617 [host=himrod1] 167556 [host=himrod1] 167568 [host=himrod2] 167625 [host=himrod1] 167574 [host=himrod1] 167657 [host=himrod1] 167637 [host=himrod1] 167669 [host=himrod2] 167682 [host=himrod2] 167645 [host=himrod2] 167694 [host=himrod1] 167703 [host=himrod1] 167710 [host=himrod2] 167650 [host=himrod1] 167721 [host=himrod1] 167804 [host=himrod1] 167809 [host=himrod1] 167732 [host=himrod1] 167846 [host=himrod1] 167744 [host=himrod2] 167911 [host=himrod2] 167930 [host=himrod1] 167756 [host=himrod1] 167942 [host=himrod1] 167952 [host=himrod1] 167779 [host=himrod2] 167962 [host=himrod2] 167971 [host=himrod2] 167982 [host=himrod1] 167791 [host=himrod2] 167992 [host=himrod2] 168006 [host=himrod2] 167797 [host=himrod1] 168117 [host=himrod1] 168125 [host=himrod1] 168021 [host=himrod2] 168146 [host=himrod1] 168159 [host=himrod2] 168031 [host=himrod1] 168171 [host=himrod1] 168040 [host=himrod1] 168176 fail irrelevant 168184 [host=himrod2] 168053 [host=himrod1] 168191 [host=himrod1] 168202 [host=himrod1] 168212 [host=himrod2] 168067 [host=himrod2] 168225 [host=himrod1] 168237 [host=himrod2] 168076 [host=himrod1] 168242 [host=himrod2] 168082 [host=himrod2] 168251 [host=himrod1] 168264 [host=himrod1] 168321 [host=himrod2] 168354 [host=himrod1] 168473 [host=himrod2] 168492 [host=himrod1] 168393 [host=himrod1] 168500 [host=himrod2] 168413 [host=himrod1] 168511 [host=himrod2] 168432 [host=himrod1] 168522 [host=himrod2] 168549 [host=himrod1] 168452 [host=himrod1] 168577 [host=himrod1] 168699 [host=himrod2] 168608 [host=himrod1] 168719 [host=himrod1] 168740 [host=himrod2] 168630 [host=himrod2] 168769 [host=himrod1] 168796 [host=himrod2] 168649 [host=himrod1] 168818 [host=himrod1] 168836 [host=himrod2] 168671 [host=himrod1] 168969 fail irrelevant 169009 [host=himrod1] 169126 [host=himrod2] 169139 [host=himrod2] 169058 [host=himrod1] 169154 [host=himrod2] 169171 [host=himrod1] 169098 [host=himrod1] 169270 [host=himrod1] 169296 [host=himrod2] 169192 [host=himrod2] 169322 fail irrelevant 169351 [host=himrod1] 169207 [host=himrod2] 169386 fail irrelevant 169224 [host=himrod1] 169415 [host=himrod1] 169447 [host=himrod1] 169254 [host=himrod1] 169477 [host=himrod1] 169502 [host=himrod1] 169555 [host=himrod2] 169531 [host=himrod1] 169581 [host=himrod1] 169640 [host=himrod1] 169611 [host=himrod1] 169669 [host=himrod2] 169768 [host=himrod1] 169805 [host=himrod1] 169850 [host=himrod2] 169699 [host=himrod2] 169897 fail irrelevant 169727 [host=himrod1] 170020 [host=himrod1] 169932 [host=himrod1] 170078 [host=himrod1] 169980 [host=himrod1] 170138 [host=himrod2] 170231 fail irrelevant 170168 fail irrelevant 170261 [host=himrod1] 170201 [host=himrod1] 170379 [host=himrod1] 170408 [host=himrod2] 170437 [host=himrod2] 170287 [host=himrod1] 170470 [host=himrod2] 170317 [host=himrod2] 170500 fail irrelevant 170346 [host=himrod1] 170589 [host=himrod1] 170624 [host=himrod1] 170660 fail irrelevant 170527 [host=himrod2] 170690 fail irrelevant 170715 [host=himrod2] 170560 [host=himrod1] 170722 [host=himrod2] 170803 [host=himrod2] 170744 [host=himrod2] 170814 [host=himrod1] 170825 [host=himrod2] 170835 [host=himrod2] 170752 [host=himrod1] 170842 [host=himrod1] 170857 fail irrelevant 170760 fail irrelevant 170881 [host=himrod1] 170768 [host=himrod2] 170892 [host=himrod1] 170911 [host=himrod2] 170774 [host=himrod1] 170990 [host=himrod1] 171143 [host=himrod1] 170784 [host=himrod1] 171153 [host=himrod2] 170793 [host=himrod1] 171159 [host=himrod1] 171175 [host=himrod2] 171189 [] 171297 [host=himrod1] 171230 [host=himrod1] 171306 [host=himrod1] 171266 [host=himrod2] 171323 [host=himrod1] 171338 [host=himrod2] 171279 [host=himrod2] 171351 [host=himrod1] 171358 [host=himrod1] 171285 [host=himrod1] 171436 [host=himrod2] 171451 fail irrelevant 171366 [host=himrod1] 171467 [host=himrod2] 171379 [host=himrod2] 171479 [host=himrod1] 171497 [host=himrod1] 171520 [host=himrod2] 171396 [host=himrod2] 171541 [host=himrod1] 171419 [host=himrod1] 171555 [host=himrod1] 171589 [host=himrod1] 171565 [host=himrod2] 171611 [host=himrod2] 171573 [host=himrod2] 171579 [host=himrod1] 171625 fail irrelevant 171658 [host=himrod1] 171638 [host=himrod2] 171667 fail irrelevant 171680 [host=himrod1] 171649 [host=himrod2] 171700 [host=himrod1] 171713 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 3b8cee1781c4149c7a762b8a1c8115b635cf4cad 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171720 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 171730 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae fec018624c7e3059cd3e23d5f1bc6006d99fb673 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 171721 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 3b8cee1781c4149c7a762b8a1c8115b635cf4cad 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171732 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae a21a3438f795deecb24e1843c1636f95c485017c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 dc88f9b72df52b22c35b127b80c487e0b6fca4af b22db3fcba1a5b4f9e563b58d402f1d5c434209f 171722 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c 3c659044118e34603161457db9934a34f816d78b ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 171723 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 3b8cee1781c4149c7a762b8a1c8115b635cf4cad 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171733 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae f304308e1cb21846a79fc8e4aa9ffa2cb1db3e4c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 dc88f9b72df52b22c35b127b80c487e0b6fca4af 65f684b728f779e170335e9e0cbbf82f7e1c7e5b 171724 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae dab96cf02e3be378310dd1bce119b0fac6fac958 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 0faf37e7434ea08ed99d804aad98fcddf74852e7 171725 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad da30b01ffaf702db082cd01ba594dd4fb4143e58 5801910013757bd626f67ed77eea6c16a176eebf 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9 d05c67efd94f301b48bc486246161b05acaa8df2 171726 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad d21009b1c9f94b740ea66be8e48a1d8ad8124023 46b4606ba23498d3d0e66b53e498eb3d5d592586 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 64f37cc530f144e53c190c9e8209a51b58fd5c43 1c3ed9c908732d19660fbe83580674d585464d4c 171727 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 6119e6e19a050df847418de7babe5166779955e4 3f90ac3ec03512e2374cd2968c047a7e856a8965 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 119c98972c4e737508df827bbbc8453cc93292c7 171728 blocked 2c846fa6bcc11929c9fb857a22430fb9945654ad 320f92c36a80bfafc5d57834592a7be5fd79f104 ddb3fdbef30de5a2946f9bd51060e8d5b1987aef 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 7292e4a0a8f58333ccbd2d0d47242f9865083c9c d21121685fac829c988e432407fb0e4ef9b19331 171729 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad da30b01ffaf702db082cd01ba594dd4fb4143e58 ee1f8262b83dd88b30091e6e81221ff299796099 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 bba24ef84b8d38bdc30a8d088874f933091605e1 8e3edefb880caeeaaf80123d5599139e8c2c9ecf 171735 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 12dd064a1804536518eb12229836fa572c232502 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 980bfb1ac9247e95790e283dbc03e231e02cced9 171736 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 ab2977b027acbbd33a7eecda854d1911a7702f8b 171737 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 586b4a104bfeae277ce16687f852c4f26c4a3b73 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee 171738 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf 171739 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 140446cd595cad870a0e8cef7a367bae8f09effa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf 171740 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 d620c66bdbe5510c3bae89be8cc7ca9a2a6cbaba 171741 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171744 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171745 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171746 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171748 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 171750 fail ccfdc6b02932efda5d76e2cd40857db651fca684 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 Searching for interesting versions Result found: flight 171720 (pass), for basis pass For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8, results HASH(0x5620f8a19de8) HASH(0x5620f8a23330) HASH(0x5620f8a29c70) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5\ 312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 d620c66bdbe5510c3bae89be8cc7ca9a2a6cbaba, results HASH(0x5620f8a15db0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 140446cd595cad870a0e8cef7a367bae8f09effa 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458\ 386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf, results HASH(0x5620f8a11da0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae f0064ac3afa28e1aa3b6b9c22c6cf422a4bb8771 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf, results HASH(0x5620f8a0eb70) For basis\ failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 586b4a104bfeae277ce16687f852c4f26c4a3b73 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 0e60f1d9d1970cae49ee9d03f5759f44afc1fdee, results HASH(0x5620f8a07f30) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 039bdb4d3e96f9c9264a\ bf135b8a0eef2e2b4860 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 ab2977b027acbbd33a7eecda854d1911a7702f8b, results HASH(0x5620f89fc4d8) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 12dd064a1804536518eb12229836fa572c232502 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c\ 8eb04 980bfb1ac9247e95790e283dbc03e231e02cced9, results HASH(0x5620f89fa1d0) For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae f304308e1cb21846a79fc8e4aa9ffa2cb1db3e4c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 dc88f9b72df52b22c35b127b80c487e0b6fca4af 65f684b728f779e170335e9e0cbbf82f7e1c7e5b, results HASH(0x5620f89ec260) For basis failure, parent search stopping at 2c846fa6bcc11929\ c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae a21a3438f795deecb24e1843c1636f95c485017c 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 ea6d3cd1ed79d824e605a70c3626bc437c386260 dc88f9b72df52b22c35b127b80c487e0b6fca4af b22db3fcba1a5b4f9e563b58d402f1d5c434209f, results HASH(0x5620f8a001e8) Result found: flight 171721 (fail), for basis failure (at ancestor ~571) Repro found: flight 171722 (pass), for basis pass Repro found: flight 171723 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 6fe2e39a0243bddba60f83b77b972a5922d25eb8 No revisions left to test, checking graph state. Result found: flight 171741 (pass), for last pass Result found: flight 171744 (fail), for first failure Repro found: flight 171745 (pass), for last pass Repro found: flight 171746 (fail), for first failure Repro found: flight 171748 (pass), for last pass Repro found: flight 171750 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced: ccfdc6b02932efda5d76e2cd40857db651fca684 Bug not present: 2c846fa6bcc11929c9fb857a22430fb9945654ad Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171750/ (Revision log too long, omitted.) neato: graph is too large for cairo-renderer bitmaps. Scaling by 0.106783 to fit pnmtopng: 10 colors found Revision graph left in /home/logs/results/bisect/libvirt/build-amd64-libvirt.libvirt-build.{dot,ps,png,html,svg}. ---------------------------------------- 171750: tolerable ALL FAIL flight 171750 libvirt real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/171750/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail baseline untested jobs: build-amd64-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Thu Jul 21 23:41:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 21 Jul 2022 23:41:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.372998.605076 (Exim 4.92) (envelope-from ) id 1oEfmu-0007oN-89; Thu, 21 Jul 2022 23:41:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 372998.605076; Thu, 21 Jul 2022 23:41:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEfmu-0007oG-5P; Thu, 21 Jul 2022 23:41:00 +0000 Received: by outflank-mailman (input) for mailman id 372998; Thu, 21 Jul 2022 23:40:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEfms-0007o5-Uq; Thu, 21 Jul 2022 23:40:58 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEfms-00065T-SA; Thu, 21 Jul 2022 23:40:58 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEfms-0001uC-Dg; Thu, 21 Jul 2022 23:40:58 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEfms-00044l-DF; Thu, 21 Jul 2022 23:40:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NQX1L5w/Vo/mkZhjV75OcXLPKLlBjF8Ij2nPV2JUtCM=; b=rvst8ougVdYF5PBxnknJPYGFQs I/cirsqazkA9kPqyhBg5rvWoR6ZT8MrVL/++dHrtcrLlQkEWYNi3K6u+mwXGp0dhj+APi380tgZRn DWS2enbQbPFRN27xoRPMCIM8y2lpZDmarnJDcErtwnEErSp712eIPpYVTwjtQsvaNROE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171747: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 From: osstest service owner Date: Thu, 21 Jul 2022 23:40:58 +0000 flight 171747 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171747/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 Last test of basis 171708 2022-07-20 19:01:51 Z 1 days Testing same since 171747 2022-07-21 20:05:50 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d2cc5633e2..fcd27b3c75 fcd27b3c759995775afb66be6bb7ba1e85da0506 -> smoke From xen-devel-bounces@lists.xenproject.org Fri Jul 22 04:02:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 04:02:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373023.605112 (Exim 4.92) (envelope-from ) id 1oEjrk-0005Ew-AC; Fri, 22 Jul 2022 04:02:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373023.605112; Fri, 22 Jul 2022 04:02:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEjrk-0005Eo-5O; Fri, 22 Jul 2022 04:02:16 +0000 Received: by outflank-mailman (input) for mailman id 373023; Fri, 22 Jul 2022 04:02:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEjri-0005Ee-C9; Fri, 22 Jul 2022 04:02:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEjri-0001iz-8k; Fri, 22 Jul 2022 04:02:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEjrh-0001NV-TJ; Fri, 22 Jul 2022 04:02:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEjrh-00010I-Sn; Fri, 22 Jul 2022 04:02:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/bkq8sLOb/iuhuibCM4TdqEkiEG7JaVoRI8Hh7DEXa8=; b=iJzIrF1eUHD8Q5rRBqJBn5fmcL YAmvMO7ZOAu2RXXtgtazWNwLqPxf90EE3Q4N3qb9e4vq3wbZ6IA5hobD1NQdB7IN6+9QLXzgkpb4u 2MxfG2M0eM1uSFtD1mkLDDTrt4HDnpthgQMDYhxb9+tAeuj8BIHDw3UcFVpx3aFw34gQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171742: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:xen-boot:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=68e77ffbfd06ae3ef8f2abf1c3b971383c866983 X-Osstest-Versions-That: linux=353f7988dd8413c47718f7ca79c030b6fb62cfe5 From: osstest service owner Date: Fri, 22 Jul 2022 04:02:13 +0000 flight 171742 linux-linus real [real] flight 171756 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171742/ http://logs.test-lab.xenproject.org/osstest/logs/171756/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 8 xen-boot fail pass in 171756-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171756 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171756 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171709 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171709 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171709 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171709 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171709 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171709 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171709 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171709 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 68e77ffbfd06ae3ef8f2abf1c3b971383c866983 baseline version: linux 353f7988dd8413c47718f7ca79c030b6fb62cfe5 Last test of basis 171709 2022-07-20 19:10:07 Z 1 days Testing same since 171742 2022-07-21 19:10:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Biao Huang Chia-Lin Kao (AceLan) David S. Miller Dawid Lukwinski Guo Ren Han Xu Hangyu Hua Hayes Wang Horatiu Vultur Hristo Venev Ido Schimmel Jakub Kicinski Jan Sokolowski Jedrzej Jagielski Jesse Brandeburg Jun Zhang Junxiao Chang Justin Stitt Khalid Masum Konrad Jankowski Kuniyuki Iwashima Lennert Buytenhek Lennert Buytenhek Liang He Linus Torvalds Lorenzo Bianconi Luis Chamberlain Maksym Glubokiy Marc Kleine-Budde Marek Szlosek Naama Meir Oleksij Rempel Oz Shlomo Paolo Abeni Peter Zijlstra (Intel) Peter Zijlstra Piotr Skajewski Przemyslaw Patynowski Richard Weinberger Sascha Hauer Sasha Neftin Steffen Klassert Taehee Yoo Tariq Toukan Tom Rix Tomasz Moń Tony Nguyen Vladimir Oltean Will Deacon Wong Vee Khee Xin Long Yuchung Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 353f7988dd84..68e77ffbfd06 68e77ffbfd06ae3ef8f2abf1c3b971383c866983 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Jul 22 07:18:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 07:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373046.605141 (Exim 4.92) (envelope-from ) id 1oEmva-00044X-K3; Fri, 22 Jul 2022 07:18:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373046.605141; Fri, 22 Jul 2022 07:18:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEmva-00044Q-Fv; Fri, 22 Jul 2022 07:18:26 +0000 Received: by outflank-mailman (input) for mailman id 373046; Fri, 22 Jul 2022 07:18:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEmvZ-00044G-Ma; Fri, 22 Jul 2022 07:18:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEmvZ-0005gk-Kd; Fri, 22 Jul 2022 07:18:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEmvZ-0001xy-9D; Fri, 22 Jul 2022 07:18:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEmvZ-0008Jh-8k; Fri, 22 Jul 2022 07:18:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2ap9u3PPiwKdzpGGwAw2bv68YFADNyTp5C/RIPG+KXk=; b=z59XpxIbusvZXLw4eQrH8sM0OA PSotMqjtKNDEM57LqO3q1JqdYwXcJXTdJHsttlNGPgtl62TEv6lGXrDz0QPvgMTwPVXHmztNKzRPL +whals9PmUzlYG9LQRx4DPHfzDNtbNd9INJuA9wC8fxZEC8nyi9A9hCcnxKHJJFHLf08=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171760: all pass - PUSHED X-Osstest-Versions-This: ovmf=494f333aba024cf8e695fda78594e5cac210c7a3 X-Osstest-Versions-That: ovmf=7ef91af84c04b1e5a17631bd1811c9bc1945dfdc From: osstest service owner Date: Fri, 22 Jul 2022 07:18:25 +0000 flight 171760 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171760/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 494f333aba024cf8e695fda78594e5cac210c7a3 baseline version: ovmf 7ef91af84c04b1e5a17631bd1811c9bc1945dfdc Last test of basis 171717 2022-07-21 06:42:21 Z 1 days Testing same since 171760 2022-07-22 05:41:58 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Stacy Howell jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7ef91af84c..494f333aba 494f333aba024cf8e695fda78594e5cac210c7a3 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 22 07:33:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 07:33:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373060.605152 (Exim 4.92) (envelope-from ) id 1oEnAK-0006pI-Th; Fri, 22 Jul 2022 07:33:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373060.605152; Fri, 22 Jul 2022 07:33:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEnAK-0006pB-Pt; Fri, 22 Jul 2022 07:33:40 +0000 Received: by outflank-mailman (input) for mailman id 373060; Fri, 22 Jul 2022 07:33:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEnAJ-0006p1-Ga; Fri, 22 Jul 2022 07:33:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEnAJ-0005vc-Dr; Fri, 22 Jul 2022 07:33:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEnAJ-0002Pr-3s; Fri, 22 Jul 2022 07:33:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEnAJ-0005Bn-3O; Fri, 22 Jul 2022 07:33:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xAYER/DZ4nylesCGtf0/ydyh3kgnE8oSF5jv8sPb4K0=; b=gfnhdvZjvVIdWxUjVU0zaNWqiO QJEBAhehUbJJAkw9tcpqNzqfNnlhjYl0NUBFAAS/hVNb4egB3uRtxspUDEcFglTLhmSvBix99frt5 W+HSryBQtV0Fh774pBT8qmpk8hnDRD8OJ0iyU2g9VLRVAfkH+o8PHymyCRexsYQfZFn0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171743: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:regression linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Fri, 22 Jul 2022 07:33:39 +0000 flight 171743 linux-5.4 real [real] flight 171759 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171743/ http://logs.test-lab.xenproject.org/osstest/logs/171759/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 171642 test-armhf-armhf-xl-vhd 13 guest-start fail REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 171759-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail in 171759 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 6 days Testing same since 171743 2022-07-21 19:11:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm fail test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 22 08:42:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 08:42:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373082.605166 (Exim 4.92) (envelope-from ) id 1oEoEK-0007tW-Gf; Fri, 22 Jul 2022 08:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373082.605166; Fri, 22 Jul 2022 08:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEoEK-0007tP-C2; Fri, 22 Jul 2022 08:41:52 +0000 Received: by outflank-mailman (input) for mailman id 373082; Fri, 22 Jul 2022 08:41:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEoEJ-0007tD-6r; Fri, 22 Jul 2022 08:41:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEoEJ-0007iv-3Y; Fri, 22 Jul 2022 08:41:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEoEI-0005Vf-Dk; Fri, 22 Jul 2022 08:41:50 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEoEI-0008JG-Co; Fri, 22 Jul 2022 08:41:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=KBjTGBlrL3G8cW3Tm8hFB3n20zcioSnjd6KA6ulM7QA=; b=2yYVSwLedZ/N2VexyoYM1gg0TA LWwOLWrZZKHWG6sIS6T+WMZsCo3bayUJsYy2zRGOEsM6VrpnohIRSMzAfRzvjxQt6WodDdZpdZEcU 6Rr+XySd+SFp4LrL1xKEGw6BQyZrP6wcaftFlaqRL/s+YLngQ0GyUYSuVZflVWrBbPkI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171749: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=5288bee45fbd33203b61f8c76e41b15bb5913e6e X-Osstest-Versions-That: qemuu=fe16c833fdb74642c296fa96a472e39229cd4351 From: osstest service owner Date: Fri, 22 Jul 2022 08:41:50 +0000 flight 171749 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171749/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171734 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171734 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171734 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171734 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171734 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171734 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171734 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171734 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 5288bee45fbd33203b61f8c76e41b15bb5913e6e baseline version: qemuu fe16c833fdb74642c296fa96a472e39229cd4351 Last test of basis 171734 2022-07-21 16:09:16 Z 0 days Testing same since 171749 2022-07-21 21:10:51 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Paolo Bonzini Peter Maydell Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git fe16c833fd..5288bee45f 5288bee45fbd33203b61f8c76e41b15bb5913e6e -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jul 22 10:54:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 10:54:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373120.605195 (Exim 4.92) (envelope-from ) id 1oEqIX-00079z-BP; Fri, 22 Jul 2022 10:54:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373120.605195; Fri, 22 Jul 2022 10:54:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqIX-00079q-87; Fri, 22 Jul 2022 10:54:21 +0000 Received: by outflank-mailman (input) for mailman id 373120; Fri, 22 Jul 2022 10:54:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqIV-00079U-5y for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 10:54:19 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9f564993-09ac-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 12:54:17 +0200 (CEST) Received: from mail-dm6nam11lp2177.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Jul 2022 06:54:07 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5087.namprd03.prod.outlook.com (2603:10b6:208:1ad::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 10:54:05 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.023; Fri, 22 Jul 2022 10:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9f564993-09ac-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658487257; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=u+w0/tVtW6tFrWYY1ZR9/pMCOsgMzQV5sFVeVE8gFyw=; b=J7n65L3OVUAuaiCmME6EIYCxHUsqdVZsOfR1zeGEOkHGWLI7S8N0CA6A QB2AePmAbRTuXgXfAckcmCI92Sh3bKTmIlmytbrRSGxd3hfFxHxkz4IkE 66mdWld2llI2cuhKGEolBs/+Po3EDo5psdmN4ULaamsmzuNE8cT4vjsxl 0=; X-IronPort-RemoteIP: 104.47.57.177 X-IronPort-MID: 78971298 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:FaZuYaMfDwEoOcHvrR1YlsFynXyQoLVcMsEvi/4bfWQNrUohhjMDx zEaCmuEP/2ON2Sjc4hzaty3/EsP75/TytBkGgto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMtPjZ8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPw2NR2A2YZDLc/xeR0G0pj+ MMkEys0O0Xra+KemNpXS8FKr+F6dYzHGd1avXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rr3wCCgLFW0q3rMzUYzy0HVwBZ8z/7GN93Nd8bRbc5UglyZt iTN+GGR7hQya4zOlmPfoyLEaunnlwj7dr8bH5+CyNFoo1nP6V4PBDYTbA7uyRW+ogvkMz5FE GQI8y8ntoAu90imSNbsUhn+q3mB1jYAUt9ZCKs+5QeC26fQywefGmUACDVGbbQOpMIwADAny FKNt9foHiB09q2YT2qH8bWZpi/0PjIaRUcAbyIZSQoO4/H4vZo+yBnIS75LD6qdntDzXzbqz FiirjU4wbMajscJ1qCy1VHBnz+o4JPOS2Yd5QjJX2Tj8gJwYqakYZCl7R7Q6vMoEWqCZlyIv XxBl83A6ukLVMiJjHbUH7pLG6y17fGYNjGamURoA5Qq6zWq/TikYJxU5zZ9YkxuN67oZAPUX aMagisJjLc7AZdgRfYfj16ZYyjy8ZXdKA== IronPort-HdrOrdr: A9a23:lKbVwKO4dxLqBcBcT5j255DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKRyXcH2/hqAV7EZniohILIFvAu0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrjVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUySw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yfT9aw+cyDpAVr4RH4FqjwpF591HL2xa1u Ukli1QevibLUmhJ11d7yGdgzUImwxelkMKgWXo/UcL5/aJBQ7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KYuZtNkIPkjgZJq3PoiFXluYd49NTO/7JpiHP hlDcna6voTeVSGb2rBtm0qxNC3RHw8EhqPX0BH46WuonJrtWE8y1FdyN0Un38G+p54Q55Y5/ 7cOqAtkL1VVMcZYa90Ge9ES8qqDW7GRw7KLQupUB/aPbBCP2iIp4/84b0z6u3vcJsUzIEqkJ CES19cvX5aQTOYNSRP5uw+zvngehTMYd228LAu23FQgMyOeJP7dSueVVspj8ys5/0CH8yzYY fHBK5r X-IronPort-AV: E=Sophos;i="5.93,185,1654574400"; d="scan'208";a="78971298" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Lr/Rfk3uVMzC/VUIHF2pWsMS8BK0FnzBXiH2zSftLw0QGEoLkt/znIi8cyzNunP5bRfMNmc1cUyOYp0mhICStA5xENfxAsVMnEaGeLbCMVgF5rFlvS3JK+sxLMhej/nRP4xnBeFTVcZbxdMtVpW0tBZHmhylthNBTp/4To256l+qMSX8MRgyJfEhAq2amthb78gUFpAJlj9XVTZ9WpFnMv+V78rK/88a7Gu6/RqTe89FU/SWdX2pIjSPfJNFG7lcwVSYfv75usbkJU0wpU76veM9WID3qmGNeTiGEFBrHU704AfnT6CSbU3cswkcePRf+1ycUtF3M+EQoPcUWpbSug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u+w0/tVtW6tFrWYY1ZR9/pMCOsgMzQV5sFVeVE8gFyw=; b=n4L/7oQGjqgG4v8O7vK/KwImjoUK7Yhgv5AtO4v8pDE7ztTsY8Io2F+beYV+KGobiSmJmKXMVUgHXNahOKPgbsNoi65Yk2Xnx+OBhkHvF3xGBsVSvh5j1rkMbuEHkxJ5co5MniqPS1zUc7MfOeLfnG/W/478QLV4wo3J1Dj5nErxKzjyzr0zhmb60qm1+DfClMtq7aZHtexmrp8xyWMs8niZrCdqUwH2hgxmL3BHDGuITOJI1TTStAjojLgwoO/fqxRelS0urqlexYeMSIFGPx1IoCgiSECPfmTsXSJYhI2cVQtrHGDf8Guzn0Aj0NcftIi9G+0tYyBe4pqngpjCng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u+w0/tVtW6tFrWYY1ZR9/pMCOsgMzQV5sFVeVE8gFyw=; b=q0FmXhgQWRnqogfN621MrTCd78DuVAoD94xBJ2cBVMT4st/hkUoFK1s200saauKFoV7KhIx5OXbRTA2Mvv8QEqV/QmQg/hvLrmA2CpO71Uyd1QYxwpdBbtaM6EZ26/kNVXwo1Zhgtfcjx//YCyEfhshWtGf7g1tju7w4OQuIXAY= From: Andrew Cooper To: Tamas K Lengyel CC: Tamas K Lengyel , "xen-devel@lists.xenproject.org" , Jan Beulich , Roger Pau Monne , Wei Liu , Jun Nakajima , Kevin Tian , George Dunlap Subject: VMCS perf, Was: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Thread-Topic: VMCS perf, Was: [PATCH v2] x86/mem_sharing: support forks with active vPMU state Thread-Index: AQHYnGkyeHzLfYftlkqMXoeeKAYG062IuvCAgAAJBwCAAXXsgA== Date: Fri, 22 Jul 2022 10:54:04 +0000 Message-ID: <27a2e492-3374-0f66-d571-d067f5c8f22f@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eeaa2ee2-f350-4c9b-f277-08da6bd07e3d x-ms-traffictypediagnostic: MN2PR03MB5087:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Xbyl6e3OI78lUSOmVHjtJtgOH8aP5BF6cKr4FXRzcFTXbKM2nsiuvv92hjInDo3aq7QYE2FzHyCbV8OpqnvMd/UqhLo/gQ094SwbNEBKvSUqihIC+HQpJe7MwLFrQw/K0NYXbId6LvujhX9mu2UgelmbznPFw5m6wQsy3xKtzust0lyjhA25Pcst4zVRfGNhxe0w6/q+mxFq6OUaTUqpaDJqb99ebZ5ri2ludSxk7cKRyvOcDGt7hojZnlEBrqkKEPS1jHu4Y8bOFP9AUslSdI2d3nwb2p1GnZI5fYyJozuokUDMqsdoQcNqvdzS1AcS+dPnRvQeCbgzYeIu/+pli3ErnQIcUq/0wF0R57B/ejLMX+kPYJr9S8uVNZ3T21cSmCMW375RKhyqMt7dM/EG+nkrg/WluWWXOf2pSWBuCg6ZtnTh3sAyc4bJ5y/mG4ahbLVWmJ2EIW0F2PyG3dukLfCUh4Yx/7UTX1pA+89lZ8NOM7W3ajv2dp3dJjI78yQluyReaX5KKGy6QBYOxt/X+NKQV0+ea6MtIoqk9f4xTUyHJUJeslOVhASBcNLltLcfM+Ix340Of9upGHbTUPbc+81E/Pmp339I8f6NaKv3PX1R8CtvgCQOh5YLdLjy+X4tTuX1xAw3+E70n4sMkZbXark6ryS3JSQL/NPHcXjcKhfyUsZvs3kAe8WdY2l3QTqdmUnKFYZBuWvQNbv1/+9GL4qg9w8NoF/prSeawVJ9JYR9DmsVc/qj9gJYhqLH2uf211A93f75tZ2H5MRsqolrHvvHbpS5mKbxyCnSxcfYmIAXpqV8XCBIalOECWKapd4BXvqqz/fQMj5aUDi7rslh7xrCb4hnl4duqNoloRO2154= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(396003)(366004)(39860400002)(4326008)(8676002)(64756008)(66446008)(66556008)(66476007)(71200400001)(66946007)(76116006)(91956017)(2906002)(6512007)(82960400001)(41300700001)(478600001)(8936002)(26005)(5660300002)(38070700005)(86362001)(6506007)(31696002)(38100700002)(53546011)(6486002)(122000001)(54906003)(186003)(36756003)(6916009)(316002)(31686004)(107886003)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?QmpVMTRoU0oxUG85NkFBVUJZRGd3YmIraHRONGhma1pLWkxtWnArMS90UnQ0?= =?utf-8?B?ZzArV3JOK3h2N1RLclRPUHdsczAxS3dzamZZUWZjcHp6dVRjUW1TaXIySExC?= =?utf-8?B?dnZXVEl5UEhVa2dtSk5ra0w1S3pNR3FQRkY3WCtQZ0dlQUd0eVJ1dGtiT2Vr?= =?utf-8?B?MlJsWTU4ZE1DUTEzM1N0QS9rcXVySlVDNjI4VXIvcjJhNTlma0tFZTArK1Ax?= =?utf-8?B?L1JaT0l0V3M3NVJaQ2ozK1hiK010NnhxRm9udkpEUFV0NXhMY3B0R1FYc3lY?= =?utf-8?B?TXFVNWhya1NJdHFhTk5pRGpRa1JRM2wydjU3VHM2WFdiSmVjbDVXcjVkWTVy?= =?utf-8?B?dGFQQTNRTHhxckQvMTlHbytuT2hyalZ0SWZ0U3p1Q0lFWElCYlVzUlpSMy9H?= =?utf-8?B?cENQTE5tUFQ0bVVGYTRsSWcrY3VDTHEweWJscXNKOVZRR2VBaFIzRXh3Mm9k?= =?utf-8?B?LzBZV2hpRTQ3UzFxamdPK1p6SHZQdGF0OTFIVEFTZzlsakE5SytvSUJ1d1o0?= =?utf-8?B?ZTF2WXVQRjBJN3BVQ0VQa0xHMkg2WUJzUCtCUmVnQ1pvT0Q4Q3RoSUxIeEpy?= =?utf-8?B?UjZzQnRWMGtWN3RUUXgyckRSdm9HTzRHTnUvMEhKWmtRRGg0VkNKWFd0OWFh?= =?utf-8?B?ajlkYStsTWJmeUJyRXBpR1Q4UmtKRzAwaURVMWYwOWVrQSthZENPTUp6Y2pv?= =?utf-8?B?c1BhOTlLUzIxUUNpYWVJN1NQY2RieSt4ZGRxMzNRL3BHSE0vbkFTeVRNUWYx?= =?utf-8?B?anVwMVVwcEU1RnNrdXdEa0Q3c0IxRk82Nmp2VCsxakhiNEhYblBmK0MxU3cr?= =?utf-8?B?MmVKWWxpWXYrREY2Q0ZtbHlJRjQ2eUVXU2U3cGhPZytkYUhlVEV6ZnhzYlhK?= =?utf-8?B?SzhKTGR3bFpUUkprSlVJZlZ2d3o3U3VobXRCdVBLWENqY05EYjFDYTB6VlhB?= =?utf-8?B?OU1pdUw1N2I5MUsvMlUwSUw4aDFtVE1CMnRSSVNjM0svNHpaOSt0UVdISVlW?= =?utf-8?B?NmVhUEc0aVRyekdHLzhneE9YZnF4dEY4aFY2NnY5MHJmU1pDWFlNS1dMWkU1?= =?utf-8?B?ZFVYTDZTMzFtclQrTzVhU0Z0NC9Zd25kYlROaUd0cnNycmE0d01nbUZ6Z1Ji?= =?utf-8?B?MEcwU3B1NXJnajNQdUh4d0k1Rm53MWs1VitHempWRGQzS3Vkd2ZhU2wzRlBx?= =?utf-8?B?WGZrY3BXbS83bEZhNHlISldlZyszb0REVUFvTjM0dloxRC81d0dpQ09FS09N?= =?utf-8?B?ZXVCTFhvUWJIbFZoVEZ3czllSzRpUHo4bXh3ZVF6c3E0TVdPS3pZekxOR3lq?= =?utf-8?B?L1JoUzRUNHNqc3hrbkhtdzRYZzFNWkR0aW1Ib0dpOElaMkh3MDlkZXVYRzJy?= =?utf-8?B?Q2JlVVZ4SGg5eC9lUDZod2FzTkVzSkZoSmJ1Zm1UNm5MUG5PUFFFdjVBcVRo?= =?utf-8?B?bURKNENrWU8rZi9rS280dkRYU3ZTd2VxTnFtUkpzMkMzeWxySGRNUUM5UmZG?= =?utf-8?B?QTJWWDl5RVRKTjBvK0kyN2dOZFBtcml2R3ZNMkVEVjRETzNmUE5KVUdDV1Fr?= =?utf-8?B?MWlabSs5TGg2MXp1dDRUQW9pQlB5UUJVRExTWDJXa2tXLzZORUxxbkVwMjVm?= =?utf-8?B?dUJxYUJSOW9CK2lwSXdsMjdPVHVKZkUrVVZoYTN3NjZWdUtNZEJVRmpUMUQ4?= =?utf-8?B?RHFpZUFkWjlyZkdUMlMrUmN4TkFlVnFMQ0sxeVo4ZFM2ZVM2eWUrNFI2SU1C?= =?utf-8?B?OHkzWjZPdE04OHduTElDYy96TExGeHp2YmMrZTV5Y09DTW5mZll4TGNqbU9X?= =?utf-8?B?TDJZSEhYVnNHaFFPb1NsS3g0ejMwYk1GZEVkNlFpTmF4VnJWL2Y0dFd5V0JS?= =?utf-8?B?cGxWa2VhWXIwSlJNWW8zaXVadkxlREMycWVNVCs3aVd1RFFoMzRRVWZoMDFP?= =?utf-8?B?bGFML2tDOVBONW5rbHpHSG8rMnZXMXM2Ums1QVZqUEROc1pUTWVRZEswVmJH?= =?utf-8?B?anB6Wmp4cnZqK1EyZXhHREQwcmpEWVhCaXRiekVZbVlvZmYrSEY0Szkwa1ZR?= =?utf-8?B?WkZoNEYxcVdMalNGSTdML01vN2F1eW1MUnAvTGZ3Y01XdXlHOWhTdTdRMXND?= =?utf-8?Q?lp6TB2eP8P0q8j3WwHLiU3J9t?= Content-Type: text/plain; charset="utf-8" Content-ID: <7C62546923F49A49B291653060BFB95D@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eeaa2ee2-f350-4c9b-f277-08da6bd07e3d X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 10:54:04.1392 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e5Jl8p2aGlGil89ifUBGFuCqx1owEWdmdhYVxsgJU4p2u0tWAmTn6DdLxzjuwnL8qC23lO0GfFK+ABPZmcA4GYgoypx5Nx4seS8mRYoe+sc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5087 T24gMjEvMDcvMjAyMiAxMzozNSwgVGFtYXMgSyBMZW5neWVsIHdyb3RlOg0KPiBPbiBUaHUsIEp1 bCAyMSwgMjAyMiBhdCA4OjAzIEFNIEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJp eC5jb20+IHdyb3RlOg0KPj4gT24gMjAvMDcvMjAyMiAxOTo0NywgVGFtYXMgSyBMZW5neWVsIHdy b3RlOg0KPj4+ICsjZW5kaWYNCj4+PiAgfTsNCj4+Pg0KPj4+ICBzdGF0aWMgY29uc3Qgc3RydWN0 IGFyY2hfdnBtdV9vcHMgKl9faW5pdCBjb21tb25faW5pdCh2b2lkKQ0KPj4+IGRpZmYgLS1naXQg YS94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50ZWwuYyBiL3hlbi9hcmNoL3g4Ni9jcHUvdnBtdV9p bnRlbC5jDQo+Pj4gaW5kZXggODYxMmY0Njk3My4uMDFkNDI5NjQ4NSAxMDA2NDQNCj4+PiAtLS0g YS94ZW4vYXJjaC94ODYvY3B1L3ZwbXVfaW50ZWwuYw0KPj4+ICsrKyBiL3hlbi9hcmNoL3g4Ni9j cHUvdnBtdV9pbnRlbC5jDQo+Pj4gQEAgLTI4MiwxMCArMjgyLDE3IEBAIHN0YXRpYyBpbmxpbmUg dm9pZCBfX2NvcmUyX3ZwbXVfc2F2ZShzdHJ1Y3QgdmNwdSAqdikNCj4+PiAgICAgIGZvciAoIGkg PSAwOyBpIDwgZml4ZWRfcG1jX2NudDsgaSsrICkNCj4+PiAgICAgICAgICByZG1zcmwoTVNSX0NP UkVfUEVSRl9GSVhFRF9DVFIwICsgaSwgZml4ZWRfY291bnRlcnNbaV0pOw0KPj4+ICAgICAgZm9y ICggaSA9IDA7IGkgPCBhcmNoX3BtY19jbnQ7IGkrKyApDQo+Pj4gKyAgICB7DQo+Pj4gICAgICAg ICAgcmRtc3JsKE1TUl9JQTMyX1BFUkZDVFIwICsgaSwgeGVuX3BtdV9jbnRyX3BhaXJbaV0uY291 bnRlcik7DQo+Pj4gKyAgICAgICAgcmRtc3JsKE1TUl9QNl9FVk5UU0VMKGkpLCB4ZW5fcG11X2Nu dHJfcGFpcltpXS5jb250cm9sKTsNCj4+PiArICAgIH0NCj4+Pg0KPj4+ICAgICAgaWYgKCAhaXNf aHZtX3ZjcHUodikgKQ0KPj4+ICAgICAgICAgIHJkbXNybChNU1JfQ09SRV9QRVJGX0dMT0JBTF9T VEFUVVMsIGNvcmUyX3ZwbXVfY3h0LT5nbG9iYWxfc3RhdHVzKTsNCj4+PiArICAgIC8qIFNhdmUg TVNSIHRvIHByaXZhdGUgY29udGV4dCB0byBtYWtlIGl0IGZvcmstZnJpZW5kbHkgKi8NCj4+PiAr ICAgIGVsc2UgaWYgKCBtZW1fc2hhcmluZ19lbmFibGVkKHYtPmRvbWFpbikgKQ0KPj4+ICsgICAg ICAgIHZteF9yZWFkX2d1ZXN0X21zcih2LCBNU1JfQ09SRV9QRVJGX0dMT0JBTF9DVFJMLA0KPj4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAmY29yZTJfdnBtdV9jeHQtPmdsb2JhbF9jdHJs KTsNCj4+IC9zaWdoLiAgU28gd2UncmUgYWxzbyBub3QgdXNpbmcgdGhlIFZNQ1MgcGVyZiBjb250 cm9scyBlaXRoZXIuDQo+Pg0KPj4gVGhhdCB3YW50cyBmaXhpbmcgdG9vLCBidXQgaXNuJ3QgYSB0 YXNrIGZvciBub3cuDQo+IEl0IGRvZXMgZ2V0IHNhdmVkIGFuZCBzd2FwcGVkIG9uIHZtZXhpdCBi dXQgd2UgZG9uJ3Qgd2FudCB0byBkbyB0aGlzDQo+IHZteF9yZWFkL3ZteF93cml0ZSBpbiB0aGUg bWVtX3NoYXJpbmcgY29kZWJhc2UuIEl0J3MgbXVjaCBjbGVhbmVyIGlmDQo+IHRoaXMgaXMgc2F2 ZWQgaW50byB0aGUgdnBtdSBjb250ZXh0IHN0cnVjdHVyZSBhbmQgcmVsb2FkZWQgZnJvbSB0aGVy ZSwNCj4gc28gd2UgY2FuIGp1c3QgZG8gYSBtZW1jcHkgaW4gbWVtX3NoYXJpbmcgd2l0aG91dCBo YXZpbmcgdG8ga25vdyB0aGUNCj4gZGV0YWlscy4NCg0KVGhpcyBpcyBzcGVjaWZpY2FsbHkgd2h5 IEkgaW50cm9kdWNlZCB0aGUge3B2LGh2bX1fe2dldCxzZXR9X3JlZygpDQppbnRlcmZhY2VzLg0K DQpMb3RzIG9mIGNhbGxlcnMgd2FudCB0byBvcGVyYXRlIG9uIGEgc3BlY2lmaWMgcmVnaXN0ZXIs IHdpdGhvdXQgd2FudGluZw0KdG8ga25vdyBpZiBpdCdzIGxpdmUgaW4gYW4gTVNSLCBvciBpbiB0 aGUgVk1DQiwgVk1DUywgTVNSIGxvYWQvc2F2ZQ0KbGlzdCwgb3IgaW4gYSByYW5kb20gc3RydWN0 dXJlIGluIG1lbW9yeS4NCg0KVGhpcyBpcyBhIHBlcmZlY3QgZXhhbXBsZSB0aGF0IHdhbnRzIGNv bnZlcnRpbmcuwqAgT25lIHBhdGNoIHRvIG1vdmUNCk1TUl9DT1JFX1BFUkZfR0xPQkFMX0NUUkwg aW50byB0aGUgZ2V0L3NldCByZWcgaW5mcmFzdHJ1Y3R1cmUgKG5vDQpwcmFjdGljYWwgY2hhbmdl KSwgYW5kIHRoZW4gYSBzZWNvbmQgcGF0Y2ggdG8gbWFrZSB0aGUgVlQteA0KaW1wbGVtZW50YXRp b24gY29uZGl0aW9uYWwgYmV0d2VlbiB0aGUgTVNSIGxvYWQvc2F2ZSBsaXN0cyBhbmQgdGhlIFZN Q1MNCmhvc3QvZ3Vlc3QgY29udHJvbHMgZGVwZW5kaW5nIG9uIGhhcmR3YXJlIHN1cHBvcnQuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 22 11:00:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 11:00:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373131.605206 (Exim 4.92) (envelope-from ) id 1oEqOl-0000Xn-5n; Fri, 22 Jul 2022 11:00:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373131.605206; Fri, 22 Jul 2022 11:00:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqOl-0000Xg-2p; Fri, 22 Jul 2022 11:00:47 +0000 Received: by outflank-mailman (input) for mailman id 373131; Fri, 22 Jul 2022 11:00:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqOj-0000XW-CS; Fri, 22 Jul 2022 11:00:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqOj-0001tb-8k; Fri, 22 Jul 2022 11:00:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqOj-0005Ev-0e; Fri, 22 Jul 2022 11:00:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEqOj-0004qM-0C; Fri, 22 Jul 2022 11:00:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2T/Sd6opqZHoocQdiHfaEEf6Ni0QKR4s9M5erhi1fGg=; b=aAKES7MD2FS7oDLRzcrnKflEFx 9T7DK0C8Aai+Gw+EgyugyHGppI0SqXT6gX6tjbxboZ6EL5DxxXQW6UntGuGhs6KlpoNZq4EQgCtjE N6qDVOM2IBVq6+I9cJRuI9rFKDfTyvYC94m3k0vf3QP2XuayfW5rpwZCvkYGZ/2dGQZk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171766: all pass - PUSHED X-Osstest-Versions-This: ovmf=343f37b5c07fd261b0fe8f3236459c9071be38b7 X-Osstest-Versions-That: ovmf=494f333aba024cf8e695fda78594e5cac210c7a3 From: osstest service owner Date: Fri, 22 Jul 2022 11:00:45 +0000 flight 171766 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171766/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 343f37b5c07fd261b0fe8f3236459c9071be38b7 baseline version: ovmf 494f333aba024cf8e695fda78594e5cac210c7a3 Last test of basis 171760 2022-07-22 05:41:58 Z 0 days Testing same since 171766 2022-07-22 07:45:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Walon Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 494f333aba..343f37b5c0 343f37b5c07fd261b0fe8f3236459c9071be38b7 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 22 11:02:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 11:02:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373139.605217 (Exim 4.92) (envelope-from ) id 1oEqQc-00017p-Id; Fri, 22 Jul 2022 11:02:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373139.605217; Fri, 22 Jul 2022 11:02:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqQc-00017i-Fb; Fri, 22 Jul 2022 11:02:42 +0000 Received: by outflank-mailman (input) for mailman id 373139; Fri, 22 Jul 2022 11:02:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEqQb-00017Y-4X for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 11:02:41 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80047.outbound.protection.outlook.com [40.107.8.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cd0ca2e2-09ad-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 13:02:39 +0200 (CEST) Received: from AM5PR04CA0024.eurprd04.prod.outlook.com (2603:10a6:206:1::37) by DU0PR08MB7691.eurprd08.prod.outlook.com (2603:10a6:10:3a5::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 11:02:37 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:206:1:cafe::d6) by AM5PR04CA0024.outlook.office365.com (2603:10a6:206:1::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 11:02:36 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 11:02:36 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 22 Jul 2022 11:02:35 +0000 Received: from 1d8fd92e7151.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 6050D417-A8A9-4D2A-A51D-BD2F04DDD32A.1; Fri, 22 Jul 2022 11:02:29 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1d8fd92e7151.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 11:02:29 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB7PR08MB3260.eurprd08.prod.outlook.com (2603:10a6:5:21::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 11:02:22 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 11:02:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd0ca2e2-09ad-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ND9BgXrNXqHDK95rnMISPLnNh79GtRJOTme44xhrb0ah1wrC/aAkCB9cbo96Y+mKdzBfBU0krDiKtuGBkl7OW9fNPLwoNewVQ0inZb9BPV7zx5Wm9KTJMXAUhYjF9MyjYenQ4QgbKiIhuuQv1ivLoLH1MSvgCtavDXbENCl3hoUla5vFTD6x8fwVvG0j3BeEljVkQ95V5taCYk/jeGLtYUb3yb5kuhTKVH9JoIbVPSAmlEh/+upA/BTNqQkNLy4iifAP7UOYoYwEK2L3Bggq97yVpYlXFMxnvDQEZ30wQobCbB0OYi1i1diUAcAyDw0zzVq9UrZHn+QZde+w2MpqJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=Y4BwKSaFcipvjPyWTzaYHy6H3WI36oerrBmiSq2BUzgBoJ9WpL6qbiXhRSxubkOcFiy7CLzO3CT7GeBfd/tdsCFEj/W1gB9+BrWDiiNLdFgWP7ydty57p18tQ+bpi+JsSRudcioZZ2eshhS7h6M7+t/zjKwwvR0DReqNqi+hh0qHKXvy+eDJXovfdLDHUV/2tfOSCHK/kcNdcP/ejvQiKn6UrWNcfDeaMMwtklUeiA9sJ0qp2hcRh5nsLcpgQDsrZy7it46oxeVaDJMoqO8XlDXkcvInFrFXHsEfVt2auFEtPuO4EcIqkSW2uKg16AChJjaF8KH/BPEhWHbEU8dSjA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=2UhNpcmt/rNeBk7z2laeXeNqgtdy1E96ydapHM22LAZLAaLQBdpiMbTBM+J2Mv3vFptVfK+1UyaMXc4gcw4CLz9hLLwTtrY9zLA2/+T2hpM92rMiQxkOUsGFG35lh6XJICswZJRKRvBdBlU5ZDJRY7xCB9es6OeOOpM0y1HVw1o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: ee6d01aca74e9f3e X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=efWUiu1GjxquQwmtIw3W7J6UUHeo8iITZxYaU0OmPNPDv6+jZBdhAgIKf37Us3uh4w7RU7zsH1uJlmTuq6xYR9Wz5z53ApJnoRPaEznoi+Is1NJXmUNLUbxBCWFjPktX7RRUVxhGVGOU/M23WtnRfn1nc67uj5TPBQyvyhbOBBoIE4g7U7Wo0g5pbmu1Xu47ZZoR+NQ9QjO9l7c+T2k7lUU8eKvQWa3isHN37F2m7NobZmFlFT9oIoD18nBeBpqe4zGuFbCF1C5ZrSNmuapQgwz+xKbtC7RhL+e1WG9vby8EuW7vjO/HOPdRDI4xK8CtfkscMz1ZU7Tig98TWZ9wEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=WUei4b1o4TvkAue0eSTc06mDToX6LidkvLrfnEgXCu7zyC5zB5aN3hoSPy5BXOLiaoxhyQVB6LDyCqaEh+Dpm1M9m9relNqwIsoMbIDBp2fhRu9+sIiTc0X/4LUOD0E0Sppg1dx2hH/Q6ILnie7ONVZe1RBkEB6PtFefEPAVI72eSR4+EfaGw/LEjQSXjRBEfwoMOmHMyxro2sf9icehjnYx/kL2DnBDMGwFX8Osi1IwbQ6mS02ebUlsCv+uRVV4tomwfaerX1AJG5gK37nUQvk64moCLKutB1QvhnZQQb3X+bh0RQQtaGCR+8UkDhcnygrnYa8PJf9vbXOj+I93KQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=a4LYNAiJxauD9PPon6uI0OXhD+Qp4Tq+euSXLKEgZi0=; b=2UhNpcmt/rNeBk7z2laeXeNqgtdy1E96ydapHM22LAZLAaLQBdpiMbTBM+J2Mv3vFptVfK+1UyaMXc4gcw4CLz9hLLwTtrY9zLA2/+T2hpM92rMiQxkOUsGFG35lh6XJICswZJRKRvBdBlU5ZDJRY7xCB9es6OeOOpM0y1HVw1o= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 07/25] tools/hotplug: cleanup Makefiles Thread-Topic: [XEN PATCH v3 07/25] tools/hotplug: cleanup Makefiles Thread-Index: AQHYh+Q6qu+KWis5mUCexJRiIhEBa62KZT+A Date: Fri, 22 Jul 2022 11:02:22 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-8-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-8-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 1f6ccaab-1147-4eea-1709-08da6bd1af71 x-ms-traffictypediagnostic: DB7PR08MB3260:EE_|VE1EUR03FT037:EE_|DU0PR08MB7691:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7MyA+qrxkG3FGH0uft95o3bVujzyDGoIxDprb/eK537KOHgRAMXfLqhB8ncgPRLjhAJJFaz8pdGJFb/3JSNTReSHs/aCTFl0JTT5Yb4zNyTPA0lehB8R/1d5Qtss0y/krDN5JxqLR4oIEyHf/ENZlgrBe2hgbqJk5xgvfd0y8/yao6nUfRRmmFDDyQrkuve5LNXsV4uHFfHbFDA+Ku1wRoOmRK9V/iwC8jkMZTM4EAzgZ49UqUmfW50SAsXgDdw7UxX0Zwufsnm7nk8p0MxWRAkW4AATJt9+wKohzaBOvyavrIxuipee2IofoCBQ79N9BzHLahcjBBoVn0J5VpvoW930QOyxdP6axonsT9kJkU9KSKRj5TzgAHqxFxFKg4PQHKWhjs1zdgCpJOVjTuJaiBhw5zZNd+ah1h83LQIHJd/UTt8J37R14B++dWxLeZUJG0gDbp2rve5CGJuB5zMWs66VXzFhrW2VRtho044r3CsZIeQV/lnI5Z1Ug8l6Ugac802Aiq5T9FosVz0Ag+C52kCBHvA3croKsQ3xqzf8ny/Cz++yAj/ems44a/JGo06zjhsNgo+O+15o5/jjVdGKg9wigalYTDl0tqSXOOgf5LNhjBgM/E1c+C0G/0Tu8wqGQZOxy7xtxduRbJxFtw8LcMYx+FTPpBsCCTLBzAaKuQVCDszNSadj2rvuDehy7x1KmemxSk8BYQAA+rQLrx6G+LNrr3NCLiGjb/gsulv/a5dd1jmWBzF5PyF7PikwN8uKSkzhYLvy+7F4dLCcD12ca0vzRskb1UMOKo0ievZnZY9Otmekz5SrZ7BoaW21WDABWBZ7dXCGe5VPMze8y0DVZA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(376002)(136003)(366004)(33656002)(122000001)(36756003)(5660300002)(8936002)(38100700002)(2616005)(83380400001)(38070700005)(186003)(86362001)(6506007)(478600001)(71200400001)(6486002)(91956017)(41300700001)(6512007)(316002)(54906003)(26005)(6916009)(8676002)(66556008)(66946007)(76116006)(66476007)(64756008)(66446008)(53546011)(2906002)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR08MB3260 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 4b661a14-d679-464c-3fbe-08da6bd1a733 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7uVTZAz0zwlxNilMN1wOuqi56GdFywSSah2p5ADiJ7nbsez7MSSYbJ8uAZp8nHeyjQK6On+2cMp44TrG2RF8+Zcjlb/wiov8GVmEUikhW2OEmxdYGGf84IFC3s86s3TTeWi7KNIdmK++9t5TycnDb0FO3sw0UMi5rB1gjYWk89j4IkBSBHVDqHowx0qspkPp4t9wA7qGtt+aPUWJ8TEca81luWMjTWutQda0Ek/WakMIT8TP27U3R3ZrJSWlfbcrjl/Z9Xs6Dl21cgwrFC1k9SIWMCo/lNKoPLXPe5Hu8cF8awgUfr3oj1QdcJUP0bbM+fMZ037GnEfm33PujWeGO+8+RYdCKVpOeudd9yHpJGCILdFHBdudsCRvczu33t2Lrv/+rfHivhOHBaqq3QKTjK9xKkgMK7JBZvUXuzrxV92JA+YKKSj/mBth6+zAfLQYISOu2InLZEi5Pl/Z6a55Dlv5qFXo26UlzSSQUIVdQCBPqgAZa8iqLMCwknq90um0VjajN55OBc3F9kIs0F2/oX8W2Hs2KsdxD5GX2c31zbHUR4hB+vofzF6CRnKRN7fDaNf+w76nfRDhgoi2ufRKSxOcW6MjnTKYGXS9B9cXFYaBVBS7ah/mtcm3QD4jVT/88YaueJzwNQm9tCT3xnmBrfIwRy7JBToeG16a5J4PmF1BO5MEzSr1V3vOshK/8HXuVyiULCfrrTwVqRXSfYa9AY1LJlU78P7gMLiKtayH3x321XcPyKbb0cpx0+u7L0Gnr6j6FZN4nik2y/W5guZ1qQ0bFzv60iPnYvPkDEIgYR2K8GupYc78J+doILgD60smbbDmWAOxaCT4N8dj2nu2Of4DlXIG1tSzQxAkZE2SYG0= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(346002)(136003)(46966006)(36840700001)(40470700004)(6862004)(478600001)(316002)(6486002)(86362001)(36860700001)(5660300002)(36756003)(8936002)(70206006)(70586007)(8676002)(41300700001)(47076005)(26005)(53546011)(33656002)(2616005)(40480700001)(81166007)(336012)(6506007)(4326008)(83380400001)(356005)(82740400003)(40460700003)(54906003)(6512007)(2906002)(82310400005)(186003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 11:02:36.0857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f6ccaab-1147-4eea-1709-08da6bd1af71 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7691 > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Remove "build" targets. >=20 > Use simply expanded variables when recursively expanded variable > aren't needed. (Use ":=3D" instead of "=3D".) >=20 > Don't check if a directory already exist when installing, just create > it. >=20 > Fix $(HOTPLUGPATH), it shouldn't have any double-quote. >=20 > Some reindentation. >=20 > FreeBSD, "hotplugpath.sh" is already installed by common/. >=20 > Signed-off-by: Anthony PERARD Hi Antony, > --- > tools/hotplug/FreeBSD/Makefile | 11 +++-------- > tools/hotplug/Linux/Makefile | 16 ++++++---------- > tools/hotplug/Linux/systemd/Makefile | 16 +++++++--------- > tools/hotplug/NetBSD/Makefile | 9 +++------ > tools/hotplug/common/Makefile | 16 ++++++---------- > 5 files changed, 25 insertions(+), 43 deletions(-) >=20 > diff --git a/tools/hotplug/FreeBSD/Makefile b/tools/hotplug/FreeBSD/Makef= ile > index de9928cd86..a6552c9884 100644 > --- a/tools/hotplug/FreeBSD/Makefile > +++ b/tools/hotplug/FreeBSD/Makefile > @@ -2,18 +2,15 @@ XEN_ROOT =3D $(CURDIR)/../../.. > include $(XEN_ROOT)/tools/Rules.mk >=20 > # Xen script dir and scripts to go there. > -XEN_SCRIPTS =3D vif-bridge block > +XEN_SCRIPTS :=3D vif-bridge block >=20 > -XEN_SCRIPT_DATA =3D > +XEN_SCRIPT_DATA :=3D Here (and also in NetBSD) the variable is empty, why are we keeping them and the related code? Is it to keep a certain structure? However the changes works and looks good to me, so your choice if it needs to be addressed or not Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 22 11:33:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 11:33:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373154.605227 (Exim 4.92) (envelope-from ) id 1oEquK-0005FE-Vc; Fri, 22 Jul 2022 11:33:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373154.605227; Fri, 22 Jul 2022 11:33:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEquK-0005F7-Sr; Fri, 22 Jul 2022 11:33:24 +0000 Received: by outflank-mailman (input) for mailman id 373154; Fri, 22 Jul 2022 11:33:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEquJ-0005F1-Q1 for xen-devel@lists.xen.org; Fri, 22 Jul 2022 11:33:24 +0000 Received: from server.eikelenboom.it (server.eikelenboom.it [91.121.65.215]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 173d41a6-09b2-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 13:33:22 +0200 (CEST) Received: from 76-24-144-85.ftth.glasoperator.nl ([85.144.24.76]:35446 helo=[172.16.1.50]) by server.eikelenboom.it with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1oEqfb-0007YO-Qg; Fri, 22 Jul 2022 13:18:11 +0200 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 173d41a6-09b2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=eikelenboom.it; s=20180706; h=Content-Transfer-Encoding:Content-Type: Subject:From:Cc:To:MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=RGLlDkwv2j1oXjKi7EcbwVfItOOYy9Qr6zsEcosPC40=; b=WMdqvmuVte5raHIMbAZqipZemh gmQ8cYby6HdvxDyhrZtMj4wG3RElCM8f1d/vvgaj32ZyKcDkTC0gOajcW5uHDMrHxALqWAO/XVwa2 wupcI+reWhGm0MimYVtUHumyWPefJMRtS3sXVeYkT34xs9ShYRhMOsTDo3W7I/k6QnJU=; Message-ID: <7a474e07-4b5f-b985-1b1f-e2e1ae54a110@eikelenboom.it> Date: Fri, 22 Jul 2022 13:16:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Content-Language: nl-NL To: Juergen Gross Cc: Xen-devel From: Sander Eikelenboom Subject: Linux 5.19-rc7: WARNING: CPU: 5 PID: 50 at drivers/block/xen-blkback/xenbus.c:322 xen_blkif_disconnect+0x24f/0x260 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Juergen, While trying out linux-5.19-rc7 (both for dom0 and domU's) running under Xen, I encounter these warnings below for every domU in my kernel log on dom0. The domU's don't boot any further because of lacking a block device. Normally I use the same kernel for both dom0 and domU while booting with direct kernel boot, I also tried the combination of a 5.19-rc7 dom0 kernel and 5.18 domU kernel and then no warnings and all domU's boot fine. Any ideas ? -- Sander [ 144.137781] ------------[ cut here ]------------ [ 144.137782] WARNING: CPU: 5 PID: 50 at drivers/block/xen-blkback/xenbus.c:322 xen_blkif_disconnect+0x24f/0x260 [ 144.137786] Modules linked in: [ 144.137787] CPU: 5 PID: 50 Comm: xenwatch Tainted: G W 5.19.0-rc7-20220722-doflr-mac80211debug+ #1 [ 144.137789] Hardware name: MSI MS-7640/890FXA-GD70 (MS-7640) , BIOS V1.8B1 09/13/2010 [ 144.137791] RIP: e030:xen_blkif_disconnect+0x24f/0x260 [ 144.137794] Code: 20 48 8d 56 20 48 8d 48 e0 48 3b 54 24 08 0f 84 a7 fe ff ff 4c 8b 74 24 10 48 89 4c 24 10 eb 82 0f 0b 0f 0b 0f 0b 0f 0b 0f 0b <0f> 0b e9 ef fe ff ff b8 f0 ff ff ff e9 34 ff ff ff 41 54 55 48 89 [ 144.137795] RSP: e02b:ffffc90000847dd8 EFLAGS: 00010202 [ 144.137797] RAX: 0000000000000040 RBX: 0000000000000001 RCX: ffff88800fef8350 [ 144.137799] RDX: 0000000000000000 RSI: 0000000000000200 RDI: 00000000ffffffff [ 144.137800] RBP: ffff88800fef82f0 R08: ffff88807d36fd00 R09: 0000000000028220 [ 144.137802] R10: 000000000002fd60 R11: 0000000000000006 R12: 0000000000000002 [ 144.137803] R13: ffff88801d1cd000 R14: ffff88800fef8330 R15: ffff888006c70cc0 [ 144.137807] FS: 0000000000000000(0000) GS:ffff88807d340000(0000) knlGS:0000000000000000 [ 144.137809] CS: e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 144.137810] CR2: 00007f536f443450 CR3: 0000000023000000 CR4: 0000000000000660 [ 144.137813] Call Trace: [ 144.137814] [ 144.137816] frontend_changed+0x388/0x450 [ 144.137819] xenwatch_thread+0x9c/0x170 [ 144.137822] ? cpu_core_flags+0x10/0x10 [ 144.137824] ? find_watch+0x50/0x50 [ 144.137827] kthread+0xe3/0x110 [ 144.137830] ? kthread_complete_and_exit+0x20/0x20 [ 144.137832] ret_from_fork+0x22/0x30 [ 144.137835] [ 144.137836] ---[ end trace 0000000000000000 ]--- From xen-devel-bounces@lists.xenproject.org Fri Jul 22 12:08:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 12:08:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373175.605239 (Exim 4.92) (envelope-from ) id 1oErRf-0001LE-Vo; Fri, 22 Jul 2022 12:07:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373175.605239; Fri, 22 Jul 2022 12:07:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErRf-0001L7-Sj; Fri, 22 Jul 2022 12:07:51 +0000 Received: by outflank-mailman (input) for mailman id 373175; Fri, 22 Jul 2022 12:07:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErRe-0001Ky-AZ for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 12:07:50 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130087.outbound.protection.outlook.com [40.107.13.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e5d3e3b5-09b6-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 14:07:48 +0200 (CEST) Received: from AS9PR07CA0001.eurprd07.prod.outlook.com (2603:10a6:20b:46c::11) by VI1PR0802MB2509.eurprd08.prod.outlook.com (2603:10a6:800:b7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 12:07:44 +0000 Received: from VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46c:cafe::de) by AS9PR07CA0001.outlook.office365.com (2603:10a6:20b:46c::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Fri, 22 Jul 2022 12:07:43 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT026.mail.protection.outlook.com (10.152.18.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 12:07:43 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 22 Jul 2022 12:07:42 +0000 Received: from 824464693877.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5AA2331E-A7B4-4DC5-95CA-1413BC2A0A49.1; Fri, 22 Jul 2022 12:07:36 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 824464693877.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 12:07:35 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB4952.eurprd08.prod.outlook.com (2603:10a6:20b:e1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 12:07:34 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 12:07:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e5d3e3b5-09b6-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=jhT0+WS0X0V9Gph6T5FiyFc/A9PZ1782w8q+y7UnSzsX6OuSseAlUOXO0p7gkHxp2+h6ejQr0pir4usSj8RMoRwtvrdMz3aRykvOL7YaOGVjL5QpCDxO3T7kiyxJcu7vE0TFIckOJNYXmPQPgq+zA/B+XyWgUz3KSbNeAycu+z01IdLX0ns4Ftxx+nXCcALQnh6DhVO+m7smY68Gh9QN/GzDzeicskgN9+xzhvXqjDbg4tjHF7saPyxgSowSohWQ+1Mf2KxsvbwFdLrOuiSUbfuItT9dfvSzW93OCjlAz/Xir+Y+Y7SqKNYu436rCOnK+lnbH6ECBdBcEsJDQOiMcg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=fjOrxQzd3q3K2xGonXNhlkDqJ0tMUWtNBAksS2YG4f3xSlSV2O2wHh4bhQ5sw9mSLCl0zRQW5J8KiNUV7EXd0628XHIL3dXP7wFWCP9Al9V1OOxCUZDjsA5+4Pq7G8D981v1eWCJDP/HDyLviKml/1XrSZzZlSZcVsl4/Ja/7wet7Se1zJ/ss313/H0444FEeOqyxbpyBPkOoouTjxNu6axuImOjNA38VTCqzZM8D5QGFWvZOH2QAUMB7kBI6HefVw4SOrdmBWCPwC1yq3d+iS05iMrpBtFYry4BGcVV0FNz+r/rzwrZlCqBZ1yRd06/EdDGiTGN1xYSn7kcr0z8hg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=Kved1wokS5q8ab2Ukpu9PZfSLgI/S7Twk/HQ0r/8hjamSynidvGKKDjG2ZDMn304HDpawwoyTc5qRItroWipl68JFuSD59GIPKvhtau4Vm9FrzxRNVXfsSBzCSrduqqi6aCGode6NaFdQtpdV7dnev1QFijb3z9En+t1NL5S+48= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3eb4b800288c9db8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fFOUCIvd80ry/k7tAUgMNf/v+h4pwT8l7L4990qNoUppBhQruqkRpiZZGqGG6l2rStrbhs4CqQp1KpAwL857G4CNEXUIz2lGG7SUyltUrr4GpN1j2ljz8hBkT3BxVAXpBaSMjRSWuTZ578GseYR7cLCKGYTOXQI8r0mLySJ2xJjHqsGa1lVHAN+9tVbTsZSDjjJxBEaoJH0dDmbIOnx7PFZecHh0MWNBNp8dkZ2hcUqic3iBRuiiXrrGh1M7W7bhCjdsTYuDzEb6U1fKv2PGnZSWWbZ5dHytOTWWmEUZhcdKlgYAT9POpGd7vV3vkOQx2yIyr1nug7ZGdf3l6O4xTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=UXww7AhuvepluhFCpAKLvYwdbk1GYE4WZ0ycW7O3LQ1UebHTxVosqayjJ+CohXalO/JCrwWRCXNcPgu6dhBix2TniKoswraVsJ2GTTMbl5cmZRwWr7lWNa9hAG9bwNDmWARWQBturUNg+1Om2eZ+9OTFi4OyeQdZg0LP0u9TJTjX8sl+HOYeMoUUr8ohF+MWQ4xcXAFfRMydHfp4J/sGYtnn07vGsflLzWtLT05LuWJWz5rCEvTq52GzdxQhXCBM5bTNt47Z20HvZ+EVqHuT4fBvviMuk2iI5gUaG3vaSJzxxO7IlBjsyxJgurYo9koZfi/rl5FzU8mQOEXHHCdQ6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mG94UoF7MulTzX8cPfIShSOi+i1WGT5N+9up7TGyqt8=; b=Kved1wokS5q8ab2Ukpu9PZfSLgI/S7Twk/HQ0r/8hjamSynidvGKKDjG2ZDMn304HDpawwoyTc5qRItroWipl68JFuSD59GIPKvhtau4Vm9FrzxRNVXfsSBzCSrduqqi6aCGode6NaFdQtpdV7dnev1QFijb3z9En+t1NL5S+48= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 08/25] tools/libfsimage: Cleanup makefiles Thread-Topic: [XEN PATCH v3 08/25] tools/libfsimage: Cleanup makefiles Thread-Index: AQHYh+Qs/zKTqDbfTEaHrzjY08GxPa2Kd3UA Date: Fri, 22 Jul 2022 12:07:33 +0000 Message-ID: <50A81854-3FF3-407A-A6DE-E9A7E67D5123@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-9-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-9-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d2651d83-4f86-40e7-2a57-08da6bdac83a x-ms-traffictypediagnostic: AM6PR08MB4952:EE_|VE1EUR03FT026:EE_|VI1PR0802MB2509:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hc8cNTJZxDZWaL7zuVeAk3BoQsZhEHq64o3vAlRu4ElkZHMxsvm2uPAlNc/aMxvHVZBExjb4v2/vKqvCHeItHEZpnuMyvC2sKg6dr3fq7x/jUl/N4mb//emwB4wfZSrX7pBiiPUagGsa4rOQVqBFgcYev+hh6yY/vnN3IooNwjvprHSke2IIRGfXwT8lWcmwQ2SL1MGHm/DnaCn2ZTcONktultBux9+o7U1Xcdqr3QYB2t2mPkzspGPBDfHDJArebwJaJHaUXwsCqo8ZMtFHQpm7z++M4fx3A1SJ0XrAaqEGlyUZJRrwwHqtzC5QikmI8fq92fRE2SN20ugza8yy0PRg00KK1yN18T2ddyqwHJkIk5GNJWU0ZtcMP+6VQIgOrwDmYeqPDB+/VyzN4TaCs41NLIz4J+pDhiKDkXVf2LqTG2ijUgXojndZ+3jYR+OEz+r+26+d7YNszsBr+ciSYGjf+Jqo9aEunp/GYwo9yIn7wl8HMExlWIxTGrKgPH2PnJsia2LocZb+Banm1x4dw7+PyI5sMaE+rlsENaIU83Z2qXqlN/WWCkR36PmOCVjETaSQhY31sXfIKNFvJbwiEEPAbw/Hxrl+A4/K5yAQ8ZoP0iOSCvZVVx9Gt435iC8DwyC4jR+UZnpsMxo3657/w+oU25lMO5ZxDguxnukX1ttFoEmHBHZSCcXVrXjjy4+YBlVrAl0/SIzSC+Zp6u4DD/yYHXBj/J/11sQHmxAp3b5Ea+RAuGz1TenkBEF2zr3Qbqm7S2C+XEHqsqrLUT2HqW/ywqSmSfOIkT+mpnsTfcYt0xxwAg+XfemwWvCD81TnsOaYOn6Z8b+XtTXWSwSxSQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(366004)(136003)(36756003)(122000001)(86362001)(41300700001)(2906002)(6506007)(53546011)(38070700005)(66946007)(66476007)(64756008)(6916009)(66556008)(4326008)(316002)(66446008)(76116006)(54906003)(8676002)(91956017)(8936002)(71200400001)(5660300002)(4744005)(26005)(6512007)(2616005)(38100700002)(186003)(478600001)(33656002)(6486002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4952 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 49872fef-4743-4c54-d710-08da6bdac22b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O+L0ECNgBCsVQrQWwLVExGytbaqIM1nYNsb4diYJ8D2W8pkbQmgEh7jK13TNpPaJzLSDbKJR4cbRvKbtPHr98pP9J9BxHwcqpDja/t0VkCYmkqSr1Yvyq66DCnWHSTVXI7OB0xnX9TU2MZYzivocSO0uq6YV3ToEXUfH886y+w8buNHQl2ud5H59ZkuPESF4fr7CCDaG/UTHn8eeiXzR74g21jZbdWH/Ltbqja2oVhEtqvejwOtvhsmBtKUxCOQQdGcgRRGUr85d5LUf2IpESatV968xkUJ/l0/YlzHNvqni7ADopD3fqwkLeHoYng2FD4k0Ofz78db6m0sfusbcjwmlyDAOEvhjjfzNJI0h0hbgTzjIt/+4N0xcdApWNs7HgowC5PqggGjh1iNatN4mgBlEAJS/m54oVcb/csfkZ0WjA5hfUWp8JfK0p7Hust51qZf4U6GcrTeNPodF2YhWEkRVkA27qzTuVy3pBmNBnX84qmJ11IKoEdRieuenUX5tiShKg/rqQjkMp+VHGuAILLZ/2JU4yj4pZ45A6ut9GV1/9EyXiz3mX/GgMWS2QswXa6CjhrKlHh+xJPvMFc90tigxOP4rjEQnuXYZez9EsiffLfZcauBcr7x2Fx3cV8ahQmrHtwOVOVVEkFFtv2jcptDT1JCvSgksu2iJs4z4y5fHjz/iSFQe8EFFvJ4Cd2IdQOVEGbn5wx6FaC+syN0ew/JYL/fKCyFBxpnTB3Amyim79hbZIy6bPwJM9csZt8cxZKuEjDvdEpv5GEyOPkOiT/kUBpAA0YsjzR7Sjt7mnCxc/5b5SqqNdoBP1RQN3KRr X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(39860400002)(136003)(36840700001)(40470700004)(46966006)(81166007)(6862004)(356005)(8936002)(47076005)(4744005)(2906002)(82740400003)(33656002)(336012)(186003)(70586007)(8676002)(4326008)(82310400005)(36756003)(5660300002)(86362001)(40480700001)(36860700001)(316002)(54906003)(6486002)(70206006)(40460700003)(6512007)(478600001)(41300700001)(53546011)(2616005)(6506007)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 12:07:43.1421 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2651d83-4f86-40e7-2a57-08da6bdac83a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2509 > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > Remove the need for "fs-*" targets by creating a "common.mk" which > have flags that are common to libfsimage/common/ and the other > libfsimages/*/ directories. >=20 > In common.mk, make $(PIC_OBJS) a recursively expanded variable so it > doesn't matter where $(LIB_SRCS-y) is defined, and remove the extra > $(PIC_OBJS) from libfsimage/common/Makefile. >=20 > Use a $(TARGETS) variable to list things to be built. And $(TARGETS) > can be use in the clean target in common.mk. >=20 > iso9660/: > Remove the explicit dependency between fsys_iso9660.c and > iso9660.h, this is handled automaticaly by the .*.d dependency files, > and iso9660.h already exist. >=20 > Signed-off-by: Anthony PERARD Hi Antony, Looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 22 12:18:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 12:18:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373185.605249 (Exim 4.92) (envelope-from ) id 1oErbk-0003Di-UH; Fri, 22 Jul 2022 12:18:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373185.605249; Fri, 22 Jul 2022 12:18:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErbk-0003Db-RY; Fri, 22 Jul 2022 12:18:16 +0000 Received: by outflank-mailman (input) for mailman id 373185; Fri, 22 Jul 2022 12:18:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErbi-0003DV-Mv for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 12:18:14 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00066.outbound.protection.outlook.com [40.107.0.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5b2f2354-09b8-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 14:18:12 +0200 (CEST) Received: from AS8PR07CA0004.eurprd07.prod.outlook.com (2603:10a6:20b:451::19) by AS4PR08MB7997.eurprd08.prod.outlook.com (2603:10a6:20b:580::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 12:18:04 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:451:cafe::cc) by AS8PR07CA0004.outlook.office365.com (2603:10a6:20b:451::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Fri, 22 Jul 2022 12:18:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Fri, 22 Jul 2022 12:18:03 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Fri, 22 Jul 2022 12:18:03 +0000 Received: from a1eb64f8938f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 463AB30E-5BE7-4BEC-84D7-FAA241D0DF02.1; Fri, 22 Jul 2022 12:17:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a1eb64f8938f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 12:17:56 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB3208.eurprd08.prod.outlook.com (2603:10a6:209:4b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Fri, 22 Jul 2022 12:17:48 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 12:17:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5b2f2354-09b8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=BTE0FobMfSp8mCCcCByXSW12fH6VdbXT8VXPF+0n7UpeDl4ZLG39a6ablIYBhB9sxy5eR6tiEtY3xZk/mlhVtuCxkWUW8CV4FZ+sIrwpgcLBAeIdtt1tnTCWGE1aCabwF8gL5BZr+Ia6Ln2iSb/qYXpkzF6V4j/Nbz/jT5OoZA5rvH+vTvAEKcDIO8wgcX2iAq6DWDViP9yxt75h6E+m8/+hv74M/UGKRIDoU8E3LPfdfUMioqAN+4xWJzGpVEzBVBWEghXgZi8y9oYk7fr1OgqLs8nfxWCM/wgVyWAf1nAHGem3DybsU5y/Hp4J6EaPXN3r4hZgAWewDXLjdd/h8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R8aK92PG1tNoEuDVIfwLTyc3ovnYpYkx/Zp/4kxg+VU=; b=eLsLyJmwTlj6I355t5s1iwQsElbpo7XwW8P5FON4F4MIQZaoZsUzZGkMYTFk2XxjJ3iNEZNtsUwzvZYL6r2RkcBjXVOTbmuCkiVLyxuCnOYHJFvr0alA39C9VkYoHB1YsNUzOYx/boStJ4wGIubS/BB/f96qhS/XqouG7tgS3WGU153emkahRiTB+t1MuddhGbxjy3aqnVspnyhktpJhrvtBooWYV0Clm7fhN4LH5IS2obdLl4edEOpjCT3c4wnlDGE3xHyLc4jD+X7ZARJ6QEnKwX1H9KU0b8VCo3VhJM/L+rd1bnB0uGaeZxXumQXGS5txHWDrdyL2g8iFWtuZ3Q== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R8aK92PG1tNoEuDVIfwLTyc3ovnYpYkx/Zp/4kxg+VU=; b=ALCN6lVwU2PkGT1hOeSueRTwfgnBpLdjXp4PLP6BHIHkv7JuE9P8acrtkINKP2EDVA3PVbeUNHKbwoTx2Xdb860JTKbWjTSmKPTq1IDfqqza4j9vl5gfpKYhaU00g0RL0bkU9IpK3rEN0Dk6mD1vp0oI/Kzv2jn5vF+1JADL2kc= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 6009f6e664adb3e9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=neVfneE8M+EauViZr6GxyKDdsm1Xx5GQQUYqdNkgTIGUnSGx5ZrkVtgyxFfI8+KJo4WTXtPeLtwKg3sxaziRR7lbsuxO4WBxnVstdfWQq6AGylYZ2jDMqROjyCGFOAkgzRAO0IrJ6ZmQkef3VT3ZD94azwjxV7lfbp5oYpj93PCbJCRPSsIdzK5Nr8y97oAx0NP8xEJLxrT6hmVmkx58xyHIk+IPq469zBHtQPaxvniKb5lnqa6Ich9o77GmmW7VOypXQGtjzI4zfZG15PIRzo25fGRUaTECbm+CLedL+fb9n8kOewI1HsS5oFWFKKk4pD76FzSR20g3NeW0ea1laA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R8aK92PG1tNoEuDVIfwLTyc3ovnYpYkx/Zp/4kxg+VU=; b=SxZbMaxSYfKeaMuCDOII0M4VDeFXuEKpojUX7e4haYAkEBI4AQuvSkTYHwU/uCeXY2uV2CB0KjeXqTUrnO9ovqgshTbhK7LToaFTQrABGUq0eBKcraeZ6YE4Wb8dvxk2O9V35duF/SGmxxt7+LZzOFOk6NSrnxy6w7DOdbd/YWxfFJz9LGkJqDNElgxyphPzfgxwga6/nLtuO5wMgo8wJQgWYDZz/voCesm1JxAU2I8g8Un81qJ70r6EYPE9kU1tlezoILCAlX32HQ8luX61cKEsCcCLDpzvzNqoG23FgVro8Wll/hiv+axm2fCccVgiA4X8aZJl7wG3AXGR0dAUKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R8aK92PG1tNoEuDVIfwLTyc3ovnYpYkx/Zp/4kxg+VU=; b=ALCN6lVwU2PkGT1hOeSueRTwfgnBpLdjXp4PLP6BHIHkv7JuE9P8acrtkINKP2EDVA3PVbeUNHKbwoTx2Xdb860JTKbWjTSmKPTq1IDfqqza4j9vl5gfpKYhaU00g0RL0bkU9IpK3rEN0Dk6mD1vp0oI/Kzv2jn5vF+1JADL2kc= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 09/25] tools/xenpaging: Rework makefile Thread-Topic: [XEN PATCH v3 09/25] tools/xenpaging: Rework makefile Thread-Index: AQHYh+QwbqdlAL00aEOFYBjfWyoAZa2KelQA Date: Fri, 22 Jul 2022 12:17:48 +0000 Message-ID: <3D24E70F-CD97-4F88-AC65-48F91F79F5E8@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-10-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-10-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: f0f31008-f0c0-44d1-356f-08da6bdc39f8 x-ms-traffictypediagnostic: AM6PR08MB3208:EE_|AM5EUR03FT030:EE_|AS4PR08MB7997:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MdWFnE/vWL+xGtuJt8k+4om4PLrOjfPxdl0x9sPyX+BnlcSnPuM+u+fTvioDL5k5N+cIDiQr2nfak//arqKHazkaRxShEsbZTPerNz/v+jw0KlZBFhnXrmHKLMprHf4r47lKCyElw4yuCmUGNP5kcALzSxL55S6hl3Z3/VjU1g36jtHaYewaIrX/U4i/KWvTqmZAOU9RYrEJXe8/g1qwJXD9a9xYIM/z2Ty4qRok7ctMSQyvtgtlX55uzeVRPwH3lygxR7OslTT72coczDgkeZhzVA49fDIZuuwjOOlXXzYEkZHt3ZSQI0hB1cBC+3Ugj+9OmiQ2pQbqkvg4K5RHjXoC+Dvoy53Te3UgbLZ2cIFrLtOipxpNxwMIhvPDLfKbFLYVgAFXUEng6ZN+jaXJUazvaxlZMKIEuH6/tiAswSV05RBrVrqRUAk5UdL+FUYDCnrx53LDrY8gUeVHofSn6o3S3s6Z8nOr+X7CLJx1Zo4DNc+OWJLpaKcPp3uuhRx5lHdUEcKVETzfQeue4PzG51/OOqTbMtyhypc8jZv7NmvC6iidvuE54r9zmRRWuMj3iIABTnBTBANAtj7H53zU4Tyhvxgykuempr+lSUKTF/8DHJVHy1O1z6b1FOi4rjARPasZ24WznSosNTie0/otPH70oe6BvoOyd44G3SdHjw53aQ6Mlq7ACy6txWmfKxdKv0cbpIH/ultBGQZC6wZ5jgdM06ArO2Vw9pyHl7tgm4iXswp86Fq+bd+SZiumPBYOxfsrLk1T0WrbxbnA8Cls5gNyJOqVudu1KcTLoSXnA3LfrgeK4KdyuCbx3YU03OPZ/9IUg91xrJC4SfK6psqdnQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(5660300002)(6486002)(41300700001)(478600001)(6512007)(6506007)(91956017)(26005)(8936002)(4744005)(86362001)(33656002)(71200400001)(36756003)(53546011)(316002)(54906003)(6916009)(2616005)(38070700005)(122000001)(186003)(4326008)(2906002)(66946007)(76116006)(8676002)(66556008)(66476007)(66446008)(64756008)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3208 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e3c4a360-7e4d-4682-0b28-08da6bdc3110 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: awXqbKObnCExK3guKg2Fn3Oc5St6T35R/JSHRfFl4vn7nId3rOIrtADw/bQUst13nzwfbA/9E2YVWe57ULJ07yT+lPKUcoojuAuZtGctX8OpVQygFhRDuLwRtwUXzc3EA98Jy9YF/0fkFuN4voIKlMyOtg5BoywJaFkoXUL0lHkFGtKHpRGybwfg3rP9MeMtBkEgFbtG++zcgDK0fn/Dd/1WFifM5MfR/HKHpxOmhpq/p2JWpEXoSQ+IuRa2hJaQCbW5N04gQ+BODcwilejJ0JlvHHyGgV8vA6olJl0i2vqFUsDNRUAjEeAl1ZDV8WzZFn0wF+D7+kjXLQJVDT0H8vI0Gf482kwqyhB9t3anNnxjat9u8y1vrxHVVD6Bt2GaV+tExi1x5Gg6FE2n6+yYDIktJ68c8OTQFEzxI2VeMKfSOmowoDEBWJ6sCRi7yTjK/ieZXU2j+g81gDbGKTJqligDwI9NbZFOAUeg+oiPOIjR5hQDPjF52Ak5HACmusu1XxZfdBrM42YiDrGHNUXjNNdQwIxEOLietgm6DLxMrA43K4xsppd4sZtE4qpBonzrBUblVoIkGLzFRnlTZegUxe6eWjj0hwylFIiKyFu4lztB+F9kjYKy62PfEKqUgayS3zX2EfsHpjNelGa/mjgzvpViYjz2JcJVYyjXibueklKmy5jfupZc9XscGgiJNHtFd7c9gMpE1gAdA2boYcN1XWP/D5CITVYFBxmBO/Pq/AylK72Qneak/j7We0bfsuiJ6gWXs3xLrSglIZYhVr1HM1KrYgnSFebCRRBBOWAPeMBDcACCu/yoXOfPd8Nfo/PQ X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(136003)(36840700001)(40470700004)(46966006)(36860700001)(4744005)(336012)(41300700001)(47076005)(6506007)(33656002)(2906002)(5660300002)(6512007)(40460700003)(6486002)(86362001)(2616005)(6862004)(53546011)(8936002)(478600001)(186003)(26005)(54906003)(316002)(82310400005)(82740400003)(81166007)(356005)(36756003)(40480700001)(70206006)(8676002)(4326008)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 12:18:03.5266 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f0f31008-f0c0-44d1-356f-08da6bdc39f8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7997 > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > - Rename $(SRCS) to $(OBJS-y), we don't need to collect sources. > - Rename $(IBINS) to $(TARGETS) > - Stop cleaning "xen" and non-set variable $(LIB). >=20 > Signed-off-by: Anthony PERARD Hi Antony, Is it worth to mention also that POLICY now is now not recursively expanded= ? In any case the patch works as before: Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 22 12:34:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 12:34:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373192.605261 (Exim 4.92) (envelope-from ) id 1oErrg-0005n8-9F; Fri, 22 Jul 2022 12:34:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373192.605261; Fri, 22 Jul 2022 12:34:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErrg-0005n1-6K; Fri, 22 Jul 2022 12:34:44 +0000 Received: by outflank-mailman (input) for mailman id 373192; Fri, 22 Jul 2022 12:34:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oErrf-0005mv-62 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 12:34:43 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a6fd23ac-09ba-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 14:34:41 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658493272370405.0185814564628; Fri, 22 Jul 2022 05:34:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a6fd23ac-09ba-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658493273; cv=none; d=zohomail.com; s=zohoarc; b=Eyfs70f3jJJkvzVl2KpgfTQCWrgFkmLGuAqHX3b/2tT/Hb2hWHiW+wrSr78xQtrPIRap1YuuXxwBkrVzHEHfy6zblA4JXpqkjPuo4+p4XvhH0bFzmcuKvn5Xl7HlC2Mw6YjWXRNs9bAt9GR5eZvQbH047d12s2ZkZrrbGpzAnqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658493273; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=9FY1k4OtkebniC+PPty7n2xQX9sMYMkEdbwDoDPv2cY=; b=IJ8rdap82/PalownHnQbUoejBCRStCx2cIXZbS/F7P3e5s/VUbBtlkFfj/GXiGdfI9OFoNe6aIycqm8nxfvberkO3SP+JyO+QbExbU1ob6qGGTOiS7rwuAwjCkMokyH62ETJIy9RTCB2SFeK2VzWkIvp7MjCMQt7nB/KkD1/Lg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658493273; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=9FY1k4OtkebniC+PPty7n2xQX9sMYMkEdbwDoDPv2cY=; b=VrDcvNmHpx5E5B8Q8b4dJZ61AGF0w64bIIQPqK78UUT1CWYoQOKAOHrEGuO/ScEj GmO9dK+ftY1IHACikuWvM0ZcLgP/vRatI5PG1VdxoFjZNtd8LPZ06UnaPyjhq7Z3qQl 34ifaoOEjkhD4trNXmMqM6SEGKdnYwJXcbWdGIgY= Message-ID: <57b4d7cc-561c-efbe-43cd-522d0a9d61fa@apertussolutions.com> Date: Fri, 22 Jul 2022 08:34:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Daniel De Graaf , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-4-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 03/18] x86: adopt new boot info structures In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 09:19, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> This commit replaces the use of the multiboot v1 structures starting >> at __start_xen(). The majority of this commit is converting the fields >> being accessed for the startup calculations. While adapting the ucode >> boot module location logic, this code was refactored to reduce some >> of the unnecessary complexity. > > Things like this or ... > >> --- a/xen/arch/x86/bzimage.c >> +++ b/xen/arch/x86/bzimage.c >> @@ -69,10 +69,8 @@ static __init int bzimage_check(struct setup_header *hdr, unsigned long len) >> return 1; >> } >> >> -static unsigned long __initdata orig_image_len; >> - >> -unsigned long __init bzimage_headroom(void *image_start, >> - unsigned long image_length) >> +unsigned long __init bzimage_headroom( >> + void *image_start, unsigned long image_length) >> { >> struct setup_header *hdr = (struct setup_header *)image_start; >> int err; >> @@ -91,7 +89,6 @@ unsigned long __init bzimage_headroom(void *image_start, >> if ( elf_is_elfbinary(image_start, image_length) ) >> return 0; >> >> - orig_image_len = image_length; >> headroom = output_length(image_start, image_length); >> if (gzip_check(image_start, image_length)) >> { >> @@ -104,12 +101,15 @@ unsigned long __init bzimage_headroom(void *image_start, >> return headroom; >> } >> >> -int __init bzimage_parse(void *image_base, void **image_start, >> - unsigned long *image_len) >> +int __init bzimage_parse( >> + void *image_base, void **image_start, unsigned int headroom, >> + unsigned long *image_len) >> { >> struct setup_header *hdr = (struct setup_header *)(*image_start); >> int err = bzimage_check(hdr, *image_len); >> - unsigned long output_len; >> + unsigned long output_len, orig_image_len; >> + >> + orig_image_len = *image_len - headroom; >> >> if ( err < 0 ) >> return err; >> @@ -125,7 +125,7 @@ int __init bzimage_parse(void *image_base, void **image_start, >> >> BUG_ON(!(image_base < *image_start)); >> >> - output_len = output_length(*image_start, orig_image_len); >> + output_len = output_length(*image_start, *image_len); >> >> if ( (err = perform_gunzip(image_base, *image_start, orig_image_len)) > 0 ) >> err = decompress(*image_start, orig_image_len, image_base); > > ... whatever the deal is here want factoring out. Also you want to avoid > making formatting changes (like in the function headers here) in an > already large patch, when you don't otherwise touch the functions. I'm > not even convinced the formatting changes are desirable here, so I'd > like to ask that even on code you do touch for other reasons you do so > only if the existing layout ends up really awkward. Ack. As I mentioned, I tried dropping these based on past reviews. I will do another pass to try to catch just formatting and drop them. > I have not looked in any further detail at this patch, sorry. Together > with my comment on the earlier patch I conclude that it might be best > if you moved things to the new representation field by field (or set of > related fields), introducing the new fields in the abstraction struct > as they are being made use of. I am not sure whether it is possible to do this field by field. This is why I was asking on IRC on about dealing with this kind of situation. As soon as multiboot_info_t/module_t are replaced with struct boot_info{}/struct boot_module{} a wholesale replacement must be done. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:00:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:00:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373202.605272 (Exim 4.92) (envelope-from ) id 1oEsG1-0000eg-Cx; Fri, 22 Jul 2022 12:59:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373202.605272; Fri, 22 Jul 2022 12:59:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsG1-0000eZ-9T; Fri, 22 Jul 2022 12:59:53 +0000 Received: by outflank-mailman (input) for mailman id 373202; Fri, 22 Jul 2022 12:59:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsG0-0000eT-ED for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 12:59:52 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2b210c28-09be-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 14:59:50 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658494785143133.8843124497207; Fri, 22 Jul 2022 05:59:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b210c28-09be-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658494787; cv=none; d=zohomail.com; s=zohoarc; b=dITkspF3ZmMHulPYGfluW5josaMC3Q64nNHlGJhyDNoJe8ZNDaSOlDYvH9sMDRy+eDddODd4UNSYlUpx1IE8Q0FSWdUxRhTVkNQgsGTtutxQeDEJCNKL3EdqPnMgzVhyDYiBl+LcnzI/tAIBsEvD/e/3e/BWOK3klu/FGWuB/MM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658494787; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=1YdYhWeWfG2WYOsNNcuaoMlXqJKYGHTjMVoDhHw9IdA=; b=hJTJZl8d8uU22PDEJcp7ey6d/tb2c4Kmv/0fih8qtiGlTR8ER/UtRB6nrTi1azzrCFSTcuLbDfSjnLw6xXZqFBrInfQgFPXnklOyrcfweXSQupK9FuyG7WeE/78u0A9s+AIDV+rLBHiKCzRJ2a+YLyMvTZS1Lk8C++ZzUvTnjtM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658494787; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=1YdYhWeWfG2WYOsNNcuaoMlXqJKYGHTjMVoDhHw9IdA=; b=BfyhetGADspSD1tdZyLKV8UMBK3bBNul46NHvSpoXyU00bRhUJxDFG5k0XYGKRqF Z2TdEwvNpiYH1R54FoUb1L9NWbSb2CMSWaJT19Azm2hjA6clK47eqSC/L4H8MQMC6GA IUXFjq/ZIhWZVG6jXUjjVb1swYNHCTLyvCNsJ4C0= Message-ID: <3fc13a16-1af3-05f0-98dd-38ec0faf111d@apertussolutions.com> Date: Fri, 22 Jul 2022 08:59:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "Smith, Jackson" , "xen-devel@lists.xenproject.org" Cc: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-5-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 04/18] x86: refactor entrypoints to new boot info In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/18/22 09:58, Smith, Jackson wrote: > Hi Daniel, > > I hope outlook gets this reply right. Looks good to me, thank you for taking the time to review. >> -----Original Message----- >> Subject: [PATCH v1 04/18] x86: refactor entrypoints to new boot info > >> diff --git a/xen/arch/x86/guest/xen/pvh-boot.c >> b/xen/arch/x86/guest/xen/pvh-boot.c >> index 834b1ad16b..28cf5df0a3 100644 >> --- a/xen/arch/x86/guest/xen/pvh-boot.c >> +++ b/xen/arch/x86/guest/xen/pvh-boot.c > >> @@ -99,13 +118,16 @@ static void __init get_memory_map(void) >> sanitize_e820_map(e820_raw.map, &e820_raw.nr_map); >> } >> >> -void __init pvh_init(multiboot_info_t **mbi, module_t **mod) >> +void __init pvh_init(struct boot_info **bi) >> { >> - convert_pvh_info(mbi, mod); >> + *bi = init_pvh_info(); >> + convert_pvh_info(*bi); >> >> hypervisor_probe(); >> ASSERT(xen_guest); >> >> + (*bi)->arch->xen_guest = xen_guest; > > I think you may have a typo/missed refactoring here? > I changed this line to "(*bi)->arch->xenguest = xen_guest;" to get the > patchset to build. Hmm, I guess I missed one. I originally was going to mimic the name xen_guest in the structure definition but when xen guest support is disable the xen_guest global turns into a #define which replaces the reference resulting in a compilation error. > The arch_boot_info struct in boot_info32.h has a field 'xen_guest' but the > same field in asm/bootinfo.h was re-named from 'xen_guest' to 'xenguest' in > the 'x86: adopt new boot info structures' commit. > > What was your intent? As I mentioned above, the renaming was intentional, and it looks like I do a poor job catching everywhere where the renaming need to be done. >> + >> get_memory_map(); >> } >> > > Thanks, > Jackson Smith v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:13:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:13:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373210.605289 (Exim 4.92) (envelope-from ) id 1oEsTC-0003HP-Nm; Fri, 22 Jul 2022 13:13:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373210.605289; Fri, 22 Jul 2022 13:13:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsTC-0003HI-Jw; Fri, 22 Jul 2022 13:13:30 +0000 Received: by outflank-mailman (input) for mailman id 373210; Fri, 22 Jul 2022 13:13:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsTB-0003HC-65 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:13:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1208bc51-09c0-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 15:13:27 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658495597171408.76117411861526; Fri, 22 Jul 2022 06:13:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1208bc51-09c0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658495598; cv=none; d=zohomail.com; s=zohoarc; b=Ib8/LEFNKfyQROkZynvtQ3R4fUHA8k/vdsvgwSMj3qUMcSm4xkVj7AZWmn09Z/BZhhEaw6GUQeXriyG0lkv78BoGLodeeoyxEnDVxDh6Q2JNXA/gCTcq1qfZ9v155p3aheRVXXNE2VOSu0Ggsyh2Jc4l4N0qQ/5I9ZGdThd+9Vo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658495598; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DMELeVJ2IWtNbtfjbHFv36eX8cn2RFCk39q6I9hwIo4=; b=QK+hkFrJE3sBtlLR2r7KcQujgWYd4CQpNK+I+3E7TmmF2ZB+JMBP9Pno0HlcpO8DXbpp3ytfWK0CkpKZYd9lVoeVeFD/QQ6Hs8NING/wyCi5a798xf/UntUCe9auuV/sCWUHtQkJ4lKZrDvZ92BaSgsEX3/idjUtd5Asan7/+Q8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658495598; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=DMELeVJ2IWtNbtfjbHFv36eX8cn2RFCk39q6I9hwIo4=; b=oy0d7HU3eSVgDJFKxwfUyqK4FfVjC/+XMTH93NZJBkPVjyVx2WhBS2QYSlc7OYxS XtCMaUMPJqIlOXpGLZGW2pDuQLHcd6S8GYU241GagWmAh7BTSp01SYNQWS84rJYAN9l nzVEook4DZO9+CFocsUsNMK4pR1IdKcrfTl5QzBo= Message-ID: Date: Fri, 22 Jul 2022 09:12:53 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-6-dpsmith@apertussolutions.com> <681d9e71-f618-ff33-59c4-bc7f793d45c7@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 05/18] x86: refactor xen cmdline into general framework In-Reply-To: <681d9e71-f618-ff33-59c4-bc7f793d45c7@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 09:26, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- a/xen/include/xen/bootinfo.h >> +++ b/xen/include/xen/bootinfo.h >> @@ -53,6 +53,17 @@ struct __packed boot_info { >> >> extern struct boot_info *boot_info; >> >> +static inline char *bootinfo_prepare_cmdline(struct boot_info *bi) >> +{ >> + bi->cmdline = arch_bootinfo_prepare_cmdline(bi->cmdline, bi->arch); >> + >> + if ( *bi->cmdline == ' ' ) >> + printk(XENLOG_WARNING "%s: leading whitespace left on cmdline\n", >> + __func__); > > Just a remark and a question on this one: I don't view the use of > __func__ here (and in fact in many other cases as well) as very > useful. And why do we need such a warning all of the sudden in the > first place? This started as just a debug print, thus why __func__ is in place, but later decided to leave it. This is because after this point, the code assumes that all leading space was stripped, but there was never a check that logic did the job correct. I don't believe a failure to do so warranted a halt to the boot process, but at least provide a warning into the log should the trimming fail. Doing so would allow an admin to have a clue should an unexpected behavior occur as a result of leading space making it through and breaking the fully trimmed assumption made elsewhere. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:14:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:14:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373213.605300 (Exim 4.92) (envelope-from ) id 1oEsTg-0003iN-04; Fri, 22 Jul 2022 13:14:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373213.605300; Fri, 22 Jul 2022 13:13:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsTf-0003iG-Sf; Fri, 22 Jul 2022 13:13:59 +0000 Received: by outflank-mailman (input) for mailman id 373213; Fri, 22 Jul 2022 13:13:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsTe-0003hw-G3 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:13:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140082.outbound.protection.outlook.com [40.107.14.82]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 242e1747-09c0-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 15:13:56 +0200 (CEST) Received: from AM5PR0402CA0003.eurprd04.prod.outlook.com (2603:10a6:203:90::13) by DB6PR0801MB1878.eurprd08.prod.outlook.com (2603:10a6:4:76::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Fri, 22 Jul 2022 13:13:51 +0000 Received: from VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:90:cafe::97) by AM5PR0402CA0003.outlook.office365.com (2603:10a6:203:90::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 13:13:51 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT037.mail.protection.outlook.com (10.152.19.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 13:13:50 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 22 Jul 2022 13:13:50 +0000 Received: from a592652af29a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3BCA623B-2E25-4D1C-B09B-88CC5C2B2EAB.1; Fri, 22 Jul 2022 13:13:43 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a592652af29a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 13:13:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DB9PR08MB6906.eurprd08.prod.outlook.com (2603:10a6:10:2ac::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 13:13:41 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 13:13:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 242e1747-09c0-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=T0NNu8dxGAvRuaxwxdHl3T89YwPq/w0ChX5xVZwfLX8wm9tfSThqN9dcg6DCcd52MlBMuZ86YlPFHtjx3rgtqCNfqZBbr5N/4RZRFU1YA36vF7oXjl4Yu6vkfhf6wQ51CH/ojp5tP8j34HJX3d1uUvX/P80DxaEViPrcxxK2ESdzoRqmTwc/VeZAVHgJ2wq5x9zlG71YwKj/tBsueebBHvRoswnb1tKUMGbvizVeWUiWuD3LQPB4qKdaQ1RJgXPapiKp1cq1ru8mTfG/g5Yiw2rIejuKuIL+DdUE4JWqcwKy1Kf1OWSR2YPowV+5oblg3ft5AJ99/hexo6O3cuAiiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=H6ctCwGiqNZDfqhv5hkYArTe3mdTNCKx5/KP2Gons42r8dRMaJmduz96SJ9deP88gDNIrKCZhFUqfPIdDxkzSVbAszFK/fANBSNxLoBjb385+IjOejanvMRvxEHkQIvl5Y7yAzBAPRE91wUkCExcwE79tUu2Nn3T3p9zpikVuxlx+hzpcSZAMJ3UHeqBCuQjhvM3DaGtFdWbsyO18lTrwxl9Xad3PAvJOSNM5QeFn6bFcqBMUJsUQcn/1gSQhG4aSuNjmG+teWIVhNz9Orcru8CnVv48zcADxtmaNvun3z35/5KaZ928o6DKJfZLvVJlkLdXOfYqmRK+hweKb26aTw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=w61n3c2x1RotT5D2rVcH5suyxYF3UCLEwTIMiFnZbSSBZxxOs61H3qwJQZD49y5lO1yyi6iuO9Ez2j7HVYaOcw19N8hUFIeMbbjUhVdVmDrTHQibu9y0/z5+41BtOEDk+AJmfXQScxrin+hlfE4fWcmvG4kv3thhSYKKsh/h2Yk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 43249df0cc27a5ef X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nreUMO6KLmWrKGIJRtg73ypmgS8919OQm7uAdt+7aMWhjEFppNdm3KId5h3io/hJbKQQzBI2CRJhQpUdTm15hp+dogyUSzxi0eqL6umR79os8jVBF3n905vbSrZrNt9ekoyH3Vlc9WejzFhrjONR3/EOtVfFQQyIFJ79c91TdBLF1eU8CPKjr20Cxim0zrayQ2IfjAmXC7nBsnXH0G9+vlvV7yHh5sMnXgqRiWdO3PccSr+oRZQHSYr22cm1aWzJRZAVXiF7V7B8ASBJyguZPWdqgFdIYbjlsRNNrRy/mN+H31beTjJoFW7bGV34ip4kdrec7HIitTZMuQw7BOsb/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=TZHHaGBx0giL5z9RZSpDkFhuuZpfD2UrLiRXSlS4egFtFenEfN9kTLOom5AqCrSk8LZMcNuaygYhTaySGfnryn/7Cy6GCOcL00NmxJQJ2B0KSCROl4+0WLN6PynBpRGmVGXWXG7b8mn/l4pPEkES4OE0SngJZZq8Gll6XKsVNYiAodgW9oPmMUBrhSLLciioMCEyT5KUwga2BhcRXgVGq1/t0IHPRO0fCsyqLpJXS/2qxO7joBrudc5ADK5M5y5eWCRwcWassq6JKD8DqpLTejgQXMSz+KYN4PpGZGILHK7hRa0NWGd1z1xj4XbxPyIMt/Gfx6F5EBmD3OHObfp1KA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wErP77+PBFHHrVpdVOfdqP3+il67j2XJK8wRT0Uiu14=; b=w61n3c2x1RotT5D2rVcH5suyxYF3UCLEwTIMiFnZbSSBZxxOs61H3qwJQZD49y5lO1yyi6iuO9Ez2j7HVYaOcw19N8hUFIeMbbjUhVdVmDrTHQibu9y0/z5+41BtOEDk+AJmfXQScxrin+hlfE4fWcmvG4kv3thhSYKKsh/h2Yk= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 10/25] tools/xentop: rework makefile Thread-Topic: [XEN PATCH v3 10/25] tools/xentop: rework makefile Thread-Index: AQHYh+Q1KLXT6Xly3keDEoxcgJ3CFK2Kie8A Date: Fri, 22 Jul 2022 13:13:41 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-11-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-11-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: af1b2753-9651-4d51-4339-08da6be40530 x-ms-traffictypediagnostic: DB9PR08MB6906:EE_|VE1EUR03FT037:EE_|DB6PR0801MB1878:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: RkUVUIBn0M+q/CZAq1184bWfZSwdnnGx+IT9q8HSpswtyaLGem9ZIGFH37VvCJfvam1JuSd1lkrG08zhYFwDuSv7ck2YAa4j+7WSQFB5tE3gl0un5+N5zGJp94omnr+ZaHWBRa7jFsr+iLcx66t0q5RoYBYm7F4X9ovx7FyWI6r1KMENWD2u7mt0Ww3WB65/R4ARP/KoTEWnkEhtXZatcN8znH6FAgBRi0dN+S8bG5N9kvLvd8m8baGMRGtvPTufbMJaML5/WhMXg1GIfp1vYzWf+KNpFemr+1XZK1ydUfabhiOgLCxv4/Z9MNOK/aabNKW+4Fvr8/LnN104fXRBDFB3lXiwqbT3H780do+t1U6R2nvKYGmyvCgr+hBsuCd03rXGG6BypMTUBL/op2yfYzOzbe+UKh3qZmCnUaNj1qcrujHKWaC8cEPp/5nRPteEhKi38bTFz5skd49f1KiBW59W9TLJ9ZvQ2Ufpz53cX3c9ejLCZH1vaw3GE5Jitsvn80sgT6WQ7KZ77R2HaLuB8U4BhU4wjzuWdVU1m0setTisu1cNv1TAEjm8gQWYdakeqP18ySNK8YIiHvICUFMXHhS6fir190QcJCunLtSBB0D4cnUQgGT2GYDn2IYrqnNpNF6UFiatKInmatZO02/wT6GawudODJxxUkLKDcU8nFfLOv1mmRE/NXj5qQO2YafozYE2za85dydNjwPOkrgK0G66yFJLkfhtA5FMQTzyq6mJXFWyBCTlL7OQSfB1W5UkVDEFHyhQ4zH4FEesvqmsfJ+dQ6hQhnfmmI7diajfihT5i0UdNVpXq8KUYFuVmiOHgskf4w7QSrmElmetI4u+vw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(366004)(346002)(39860400002)(136003)(91956017)(8936002)(5660300002)(4326008)(76116006)(66476007)(66946007)(4744005)(64756008)(66446008)(66556008)(8676002)(2906002)(54906003)(38070700005)(33656002)(38100700002)(36756003)(71200400001)(86362001)(6486002)(122000001)(186003)(6506007)(6512007)(26005)(53546011)(6916009)(478600001)(41300700001)(2616005)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6906 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ed0ec2c8-492e-407e-8938-08da6be3ff4f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OhJNt6FGQsgqvlfdjAawl/yvwyJEI6AIrCcEJG1PddMYWFX4YAU8LqvUki2DhqRaA/3IJ7ocKjVDRI8o5+poEaLXycE69kANLSmeVpIF3QtlQRMiR8mxIoDkAmIdsSnnjfOjYOEJjMcW3Szvg6g/VuCS6yV6aeC1YAl+/Pn+inUZlwW77+EEU7gNibIGPsk8KDaTwvS1aIp2tkgmeYZs0EoIp+jpdr1ZjqHpqd7nnW5ZMFefdfuqhhB+2KzyAoBLwxSz7x9pNrnQDzt5rWIoY/jZ8eCRpD58/c3ZeMNR8SGSwqMtcPAwGPkLldPu/nQ89ZbmaARMBCYBLKdAdJCz1bD9W+Q0qTwObl/Vx0MIqox67ie6mldBKer/wgXcPw0lw82ga0osoRpBt/3oJcGAPPT/HIXBT4iii34qva75MceFtKKSn3OxslMDPNhAdWRRE7BBXAoduwomqrh9t2DphQ0lE6U0G8iGuvvq3PM7oSBx70ev9w3ibVoh4524ufEfHVdafxw8H1jixbMU2nQMNSFVoFoLGR+pBEvyWTK+md+r4FYNagJr+W5KZFt9L9imk0dfuMAfxj1AcahFlM/klCNhSPxKOcFTKCSO9tmY778cuLy0jM1Es4Z/Y1ZOwd6aN4EBx0/StA7AYEUBZM0R83rwMIcwnZzfjXggfoMnwwjd6zWi2GIjxFKcR1WhN7pMpt6Sp+O/ypM8azF0gD5Spo06U21UFb1focXlYIx85PIyXdXehYK2jTCO3G3QwH//grVBC4xSiXGxNZVo8QTsTszFSpWyfDR8jfNBYXAtg2hvzGYx5gPeljAcjHb/qUgp X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(39860400002)(36840700001)(46966006)(40470700004)(316002)(186003)(81166007)(33656002)(41300700001)(8676002)(54906003)(82740400003)(70206006)(4326008)(336012)(2906002)(86362001)(40460700003)(2616005)(47076005)(356005)(5660300002)(70586007)(53546011)(6506007)(6512007)(26005)(478600001)(4744005)(82310400005)(6486002)(8936002)(36860700001)(40480700001)(6862004)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 13:13:50.9017 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: af1b2753-9651-4d51-4339-08da6be40530 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1878 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBBZGQgInhlbnRvcCIgdG8gIlRBUkdFVFMi IGJlY2F1c2UgdGhpcyB2YXJpYWJsZSB3aWxsIGJlIHVzZWZ1bCBsYXRlci4NCj4gDQo+IEFsd2F5 cyBkZWZpbmUgYWxsIHRoZSB0YXJnZXRzLCBldmVuIHdoZW4gY29uZmlndXJlZCB3aXRoDQo+IC0t ZGlzYWJsZS1tb25pdG9yLCBpbnN0ZWFkIGRvbid0IHZpc2l0IHRoZSBzdWJkaXJlY3RvcnkuDQo+ IFRoaXMgbWVhbiB4ZW50b3AvIGlzbid0IHZpc2l0ZWQgYW55bW9yZSBkdXJpbmcgIm1ha2UgY2xl YW4iIHRoYXQncyBob3cNCj4gbW9zdCBvdGhlciBzdWJkaXJzIGluIHRoZSB0b29scy8gd29ya3Mu DQo+IA0KPiBBbHNvIGFkZCBtaXNzaW5nICJ4ZW50b3AiIHJ1bGVzLiBJdCBvbmx5IHdvcmtzIHdp dGhvdXQgaXQgYmVjYXVzZSB3ZQ0KPiBzdGlsbCBoYXZlIG1ha2UncyBidWlsdC1pbnMgcnVsZXMg YW5kIHZhcmlhYmxlcywgYnV0IGZpeCB0aGlzIHRvIG5vdA0KPiBoYXZlIHRvIHJlbHkgb24gdGhl bS4NCj4gDQo+IFVzZSAkKFRBUkdFVFMpIHdpdGggJChJTlNUQUxMX1BST0cpLCBhbmQgdGh1cyBp bnN0YWxsIGludG8gdGhlDQo+IGRpcmVjdG9yeSByYXRoZXIgdGhhbiBzcGVsbGluZyB0aGUgcHJv Z3JhbSBuYW1lLg0KPiANCj4gSW4gdGhlICJjbGVhbiIgcnVsZSwgdXNlICQoUk0pIGFuZCByZW1v dmUgYWxsICIqLm8iIGluc3RlYWQgb2YganVzdA0KPiBvbmUgb2JqZWN0Lg0KPiANCj4gU2lnbmVk LW9mZi1ieTogQW50aG9ueSBQRVJBUkQgPGFudGhvbnkucGVyYXJkQGNpdHJpeC5jb20+DQo+IOKA lA0KDQpIaSBBbnRvbnksDQoNCk5pY2UsIHRoaXMgZG9lcyBpdCB3aXRoIGp1c3Qgb25lIGdjYyBp bnZvY2F0aW9uLg0KDQpSZXZpZXdlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBh cm0uY29tPg0KDQoNCg0K From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:18:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:18:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373224.605311 (Exim 4.92) (envelope-from ) id 1oEsY9-0004lV-IJ; Fri, 22 Jul 2022 13:18:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373224.605311; Fri, 22 Jul 2022 13:18:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsY9-0004lO-Ep; Fri, 22 Jul 2022 13:18:37 +0000 Received: by outflank-mailman (input) for mailman id 373224; Fri, 22 Jul 2022 13:18:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsY8-0004lI-D9 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:18:36 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c9673e80-09c0-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 15:18:35 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658495909825547.7375402127639; Fri, 22 Jul 2022 06:18:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9673e80-09c0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658495911; cv=none; d=zohomail.com; s=zohoarc; b=L6W8owW4oMEfYqZq3zJCxIdmscPmof7zK3n/FXGXM3WxSkTszR9VUl5KDGCjSgWP9uDnCkWMse5vGmLG+AQgkzWvDkXCMmbuHjCkbroj6q5vl1GxVolQMgKzYew4cfCUFmpKG6rnlpf6mp9e9/N7cQdAjiSQMlrvKDfenFSKeJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658495911; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=2mi9QCDrdMzvMaCAfbcQVzTwqX6ZUDeJ0EiZEI1lqXg=; b=D6IFtofJBR/KB8dK8IpShKlDP5+2RM9lSIs7El+jHvO+YJuZzzcbLQaP1BRZ80gmBgk+u0TimzZAjzqnppXiI+VyRzEXdMBm/7FVz34YGmO5JdCsSA4IV23UDPpdCkYJGkVE86l0c49EXc43apl9pQpQ6mDGHwvfAgyMRgaf7Og= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658495911; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=2mi9QCDrdMzvMaCAfbcQVzTwqX6ZUDeJ0EiZEI1lqXg=; b=a+/SY8DG7AS9wUgru3xdULUfquQIpXOtStqfFZ8ICVt8BBBkRUn6E4FhXG52cB2M ZfdE+YsH9xH/2Bxs8hLfhVSy0kfsg8eW0vmo+tOiHTkIma+DvvWJv9GMMgSxkXn3Xyd gHpeCqLTns/AxSdXQRISCRKccrHve1gqfXCXcuME= Message-ID: Date: Fri, 22 Jul 2022 09:18:05 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 06/18] fdt: make fdt handling reusable across arch Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Stefano Stabellini , Julien Grall , Bertrand Marquis , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org, Volodymyr Babchuk References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-7-dpsmith@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 05:36, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> This refactors reusable code from Arm's bootfdt.c and device-tree.h that is >> general fdt handling code. The Kconfig parameter CORE_DEVICE_TREE is >> introduced for when the ability of parsing DTB files is needed by a capability >> such as hyperlaunch. >> >> Signed-off-by: Daniel P. Smith >> Reviewed-by: Christopher Clark >> --- >> xen/arch/arm/bootfdt.c | 115 +---------------------------- >> xen/common/Kconfig | 4 ++ >> xen/common/Makefile | 3 +- >> xen/common/fdt.c | 131 ++++++++++++++++++++++++++++++++++ >> xen/include/xen/device_tree.h | 50 +------------ >> xen/include/xen/fdt.h | 79 ++++++++++++++++++++ >> 6 files changed, 218 insertions(+), 164 deletions(-) >> create mode 100644 xen/common/fdt.c >> create mode 100644 xen/include/xen/fdt.h > > I think this wants to be accompanied by an update to ./MAINTAINERS, > so maintainership doesn't silently transition to THE REST. ack > I further think that the moved code would want to have style adjusted > to match present guidelines - I've noticed a number of u uses which > should be uint_t. I didn't look closely to see whether other style > violations are also retained in the moved code. ack v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:31:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:31:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373231.605322 (Exim 4.92) (envelope-from ) id 1oEskL-0007Ms-Og; Fri, 22 Jul 2022 13:31:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373231.605322; Fri, 22 Jul 2022 13:31:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEskL-0007Ml-Kv; Fri, 22 Jul 2022 13:31:13 +0000 Received: by outflank-mailman (input) for mailman id 373231; Fri, 22 Jul 2022 13:31:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEskK-0007Mf-AL for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:31:12 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10073.outbound.protection.outlook.com [40.107.1.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8aef5bb6-09c2-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 15:31:07 +0200 (CEST) Received: from AM6P194CA0035.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::48) by GV1PR08MB7731.eurprd08.prod.outlook.com (2603:10a6:150:52::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 13:31:04 +0000 Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::3b) by AM6P194CA0035.outlook.office365.com (2603:10a6:209:90::48) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 13:31:04 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 13:31:02 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Fri, 22 Jul 2022 13:31:02 +0000 Received: from a721f8d7b757.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 705B7C12-6C03-4B11-8A7C-B490090466CE.1; Fri, 22 Jul 2022 13:30:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a721f8d7b757.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 13:30:55 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DBBPR08MB6123.eurprd08.prod.outlook.com (2603:10a6:10:20a::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 13:30:53 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 13:30:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8aef5bb6-09c2-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LQbYPfHP+Oi13Ae7rxfq4kAW3WsBVD3y++abE46dONG9s6KZrn0dkt/Ma+O/YTj/KHr5xfTCMRGAd81H/pW3EAKPlmNcdm0i9pHpr+fuOX7qETvQIDS/0HODNj47TR0u9TYleeTTDTSLIBdDPqWojf4p6OJxrVWy/AHrasRBEyVNjlu+zBSLNa+1Ig2Jo/6s5eMGO9cmsR5uRGbPhsmMJOiMUCsZocU+XptG4dSdaUmZ4olY34itXbf19YWSHgvip283JWsuEYsEnVGUUBKs+0zT0GDO6gQdHbkprV3VNngQJ7qfEwjxE0V/Pv77oeZSV6js4i6xK4thhhP295jg2g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=F52/GIn+QS7P387/xFjDHIM5RHQj0z/9NHjA36XWwZ25ypiQly5Z4qyQoA+slAYGQzokDe3EOIk8YxMA8ZvIajXJEM67qf05jzqWY6Cpb97XZ0N8V/X02bBJsmZ7Hcq1MP8UUJik9t/SFO0e0RzZbNNMDpNK0+e8QbtD8DgVNBx2E7+qHZS0abVdsO/QETjgMNgfvud2XZnVlI3EhSswzbf4mr9Vq9vRWbgHBIFvRIxhCgXParCXFcfPUvhq2oiKJuvJKi6CNhNKedtz/F5uqxxVcz8fKGCNiFd2ht5/Jfq8z69pa8z5uy0tohUf75fo4Q1ymT4RJQWhstk8jJLxZA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=fVpqWnZ/1jU3/tLVcvY0o1ym6qY0PLtbs7GSOdY5Ta6xd9fA2N8uj0aGsBsO5uIZN9Xkzq6hEjkUERh2OWxXxWA7zzPMUi+4vmzla2FO2vbO/HvPwHTIY+mnNgEZht4USe3tLhrxWa/KXw8u7l/QbRfkHsbtMACVsi4QGft5jLY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bd617bef8ef3b90d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W0+amNtTOQZu2Pvth5j07a9xSMkfvwe+jZOSknJu4y+T5SJ8xzFDepn12C/BdmTAVyQw91cGIqI8UEbeky84LSAKuRN4ui/E5+2FgsYYUljgCb76aB/7eERDPJxwyjmSIDM6JqDp2dN8GzzaBJ5XkVDSgQskkLgP62O/kVUdV8KOon5uJ6EWuvXZjZWY7RgcJnKd4cftLKrSvzJHmEdMsaaXBprZIOTI88ybKDrvDTzyHnlvAncIbaowamusMA+mlZGIXkCZvRVvEY/TazUE/UvQ+lpTwaJLi+lMnW5X51CenS7Y8vuvJi3x9F8n7uwjZdeaaXQJ4KE72sMFfqDYOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=YHNj0NQyD3qqXNQamGOIUM0k33lF4WiWVKlLGz+OT73sw1pNr5dmjuiWYaJ2ttYqaarollKmRpDtttBPuSvD4Jij/Wctv7R76Mxy+tZisRuqAtjx1OACjFMN3T2zfiilcJlthNeeMR3jx4a3md4tQ8ZRzveX/QqOJPDQb6egBzFT6C++M7KEyed6pYAcGjgTFI+eFi4hC2YeI2t/6ucDAA28Z7ExBVtXo0dKwxe7BiYDj0kL7CmQnQtgfeFX3Wv06jWNuBSfhH3gYRIHrZa0bJ49jtHGOQaCKT9NiYc+p7wVJ0niocFuTrdwJFKSjmNEqa9Yx4w3pT2ZRMXymckVvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7m+r0zQRXv2eZ9CJuxVVAYbBlzcpeQOKcOjAw8RSvnQ=; b=fVpqWnZ/1jU3/tLVcvY0o1ym6qY0PLtbs7GSOdY5Ta6xd9fA2N8uj0aGsBsO5uIZN9Xkzq6hEjkUERh2OWxXxWA7zzPMUi+4vmzla2FO2vbO/HvPwHTIY+mnNgEZht4USe3tLhrxWa/KXw8u7l/QbRfkHsbtMACVsi4QGft5jLY= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , George Dunlap , Wei Liu Subject: Re: [XEN PATCH v3 11/25] tools/xentrace: rework Makefile Thread-Topic: [XEN PATCH v3 11/25] tools/xentrace: rework Makefile Thread-Index: AQHYh+S+xJXhWYMyUkSO+GQKLe3BdK2Kjr0A Date: Fri, 22 Jul 2022 13:30:53 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-12-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-12-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0076a77e-10dc-489f-0d6d-08da6be66bfe x-ms-traffictypediagnostic: DBBPR08MB6123:EE_|AM5EUR03FT046:EE_|GV1PR08MB7731:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +MEO/LF44Ue+phnvDUOVkeY3GSZj2PebQWJYBICBGz3TBSTyHgBfjwmy2aOD+igasSCrz/GRUyA9kpZEvxD5fw3rPqIasdsSdpdJ4LK2TnUuXlUoqrvUNj/ah1rsXPZdq77mEW2c5clH/xvqOuOpPc/y0lBgZ1fmRreD9wluKP+UQVS4Ky5u+2VeF/fg/sXuXUylC/hvsjO7Ta0qvBCSsUg/fGHL1k5Ax6/cy80+7kZ5uZ2w0wQKtIiYNIRr4HeyS2Gp6DqYeYMNwBCUoLWp5OaNbcdL0OCiG4SM50UP4CjKqSVaCeyTD7T2tAqWJpf9jVzVAEKDpC+NnPBZujE41Dmdo8sPNduRagpWuGcS4hVHBOxX9t+bot/NqyjzXhW4iI5UxASl3GRGRlcXWsk6nKxkBR1FR0U7ICx0uFKC1efM1kpwwG2B4d1fX2Six+wddOwwY61MKDWb+Q4ZCtfH3s+Kfd60NeKckusofXwGNV42BmTzxvcABGMriyZ2hW56WtC+mjeWzv8gaRBiPPVhZhl/FZJedGIiHKe7UDyRS+Se9d17Iy3wa0hAssMJXPV/K8wl+GbbgYCGd5fS5+v2u6wNJw+TlMd4mDmrAGvY0QjSTOBYSeVgArZEDEJ5p1wD9PKaOKJqL4C+aGFuyDhKAWUkDpuCjgst0H0MiogutOCFUzrOUc40zUCoIdoGtMFGv5M+NMTX/C1XVM3nHLhneJV0woy8fuim020O90azT3hDVADKWkMiCNIm3L0FGLHsZ8sxwmLPQLPUi2VibmwNPBkIUma1PAQ40cCpMuh8bNGxIC1OJ27VLCbtg2vKwfPtUS8EwMnnOj2JdpuLTLW3AQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(366004)(66946007)(66446008)(64756008)(186003)(66476007)(76116006)(83380400001)(66556008)(6506007)(86362001)(8676002)(478600001)(4326008)(36756003)(33656002)(91956017)(2906002)(122000001)(38100700002)(8936002)(5660300002)(38070700005)(6512007)(71200400001)(26005)(41300700001)(6486002)(316002)(54906003)(6916009)(53546011)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6123 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 66f89899-b2c8-402c-23d4-08da6be666d0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n5Rv5whVX++fLLwBDJ/tol0QjrSrt2RqnIxDre2a51XkHFRYzuk+FWA5JcQjlX56CWY8d1op1SWMhD8Uf6fne2EBTup3uCqODZp7L5+tpASXgT36zau0YefcxHCT2+v3aVNvVBNzNqJGmXeS7qncCWNV5m3PI/aRvHvIHmBaGG8Cmoo7+ekZbcSHL4qTclvXG7jeV6ZvrEDEKMqKRVEaL1tQ/o7V4pi//cghQzYxL4MWg3sg2FRN6JqZ/m4ytPLXgAMOFRVM0t8XqHVDqAEZ1izDBfiy0PfxWmwopMItjyQYjZXO9I2wYt5ZoKUwh3Ej1vBWsz2UAcyWQLmDLRkYdaYVkYJLn/9UqO/5ygAqEKickOHDG433EISHFxzoOWgBUabvXwDoSnsztF8B5omqTgw4UXJT9ctY+La+TOJhbYbr4COlo0CeaOJjJ4OIti1sadvQmE2z9yqcrenjDjiMQuvmvzANrv8oqUTflDb3CnSdhOg1jeVGlWDm8Y4XgBOr15sKCXXWKFCCDtrmknklGLAtImdc4K3JgAsxSUhrMLrqR07EikBLGhFHOH4uCQv9u20bRdnR+ttCnhhKbzbIccC9xx6XtGFpQjWF1H9BJ/TKwisqKNN8EJO8KMD+wa+SBSdw201ireUpb5Os4+6jvdd9R+ncaR523P08muQG64vG5iq4USoRNR/Dgdq9hY0U3xvlc2u7jOrENru2hRSb8PiDw6hHDFU/DzKndwKfjjhbPVyoaXeuIqi3xxbqdnXvW2LJORzad8tXN2vKvSpExfHnUu4xTAcWyTvuzWIEiNag2lXNdDvGb3rLzWMJ46w4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(36840700001)(40470700004)(6486002)(41300700001)(478600001)(356005)(33656002)(82740400003)(81166007)(336012)(26005)(53546011)(6506007)(2616005)(83380400001)(316002)(54906003)(86362001)(186003)(47076005)(6512007)(82310400005)(40460700003)(8936002)(6862004)(40480700001)(5660300002)(8676002)(70586007)(70206006)(4326008)(36756003)(36860700001)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 13:31:02.4209 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0076a77e-10dc-489f-0d6d-08da6be66bfe X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7731 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBSZW1vdmUgImJ1aWxkIiB0YXJnZXRzLg0K PiANCj4gVXNlICIkKFRBUkdFVFMpIiB0byBsaXN0IGJpbmFyeSB0byBiZSBidWlsdC4NCj4gDQo+ IENsZWFudXAgImNsZWFuIiBydWxlLg0KPiANCj4gQWxzbyBkcm9wIGNvbmRpdGlvbmFsIGluc3Rh bGwgb2YgJChCSU4pIGFuZCAkKExJQkJJTikgYXMgdGhvc2UgdHdvDQo+IHZhcmlhYmxlcyBhcmUg bm93IGFsd2F5cyBwb3B1bGF0ZWQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBBbnRob255IFBFUkFS RCA8YW50aG9ueS5wZXJhcmRAY2l0cml4LmNvbT4NCg0KSGkgQW50b255LA0KDQpXb3VsZCBpdCBt YWtlIHNlbnNlIHRvIHVzZSA6PSBpbnN0ZWFkIG9mID0sIGZvciBCSU4sIFNCSU4sIExJQkJJTiwg U0NSSVBUUz8NCg0KPiAtLS0NCj4gDQo+IE5vdGVzOg0KPiAgICB2MjoNCj4gICAgLSBmaXggdHlw byBpbiB0aXRsZQ0KPiAgICAtIGRyb3AgY29uZGl0aW9uYWwgaW5zdGFsbCBvZiAkKEJJTikgYW5k ICQoTElCQklOKQ0KPiANCj4gdG9vbHMveGVudHJhY2UvTWFrZWZpbGUgfCAxOSArKysrKysrLS0t LS0tLS0tLS0tDQo+IDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDEyIGRlbGV0aW9u cygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL3Rvb2xzL3hlbnRyYWNlL01ha2VmaWxlIGIvdG9vbHMv eGVudHJhY2UvTWFrZWZpbGUNCj4gaW5kZXggOWZiN2ZjOTZlNy4uMDk5NWZhOTIwMyAxMDA2NDQN Cj4gLS0tIGEvdG9vbHMveGVudHJhY2UvTWFrZWZpbGUNCj4gKysrIGIvdG9vbHMveGVudHJhY2Uv TWFrZWZpbGUNCj4gQEAgLTE0LDM2ICsxNCwzMSBAQCBTQklOICAgICA9IHhlbnRyYWNlIHhlbnRy YWNlX3NldHNpemUNCj4gTElCQklOICAgPSB4ZW5jdHgNCj4gU0NSSVBUUyAgPSB4ZW50cmFjZV9m b3JtYXQNCj4gDQo+IC0uUEhPTlk6IGFsbA0KPiAtYWxsOiBidWlsZA0KPiArVEFSR0VUUyA6PSAk KEJJTikgJChTQklOKSAkKExJQkJJTikNCj4gDQo+IC0uUEhPTlk6IGJ1aWxkDQo+IC1idWlsZDog JChCSU4pICQoU0JJTikgJChMSUJCSU4pDQo+ICsuUEhPTlk6IGFsbA0KPiArYWxsOiAkKFRBUkdF VFMpDQo+IA0KPiAuUEhPTlk6IGluc3RhbGwNCj4gLWluc3RhbGw6IGJ1aWxkDQo+ICtpbnN0YWxs OiBhbGwNCj4gCSQoSU5TVEFMTF9ESVIpICQoREVTVERJUikkKGJpbmRpcikNCj4gCSQoSU5TVEFM TF9ESVIpICQoREVTVERJUikkKHNiaW5kaXIpDQo+IC0JWyAteiAiJChMSUJCSU4pIiBdIHx8ICQo SU5TVEFMTF9ESVIpICQoREVTVERJUikkKExJQkVYRUNfQklOKQ0KPiAtaWZuZXEgKCQoQklOKSwp DQo+ICsJJChJTlNUQUxMX0RJUikgJChERVNURElSKSQoTElCRVhFQ19CSU4pDQo+IAkkKElOU1RB TExfUFJPRykgJChCSU4pICQoREVTVERJUikkKGJpbmRpcikNCj4gLWVuZGlmDQo+IAkkKElOU1RB TExfUFJPRykgJChTQklOKSAkKERFU1RESVIpJChzYmluZGlyKQ0KPiAJJChJTlNUQUxMX1BZVEhP Tl9QUk9HKSAkKFNDUklQVFMpICQoREVTVERJUikkKGJpbmRpcikNCj4gLQlbIC16ICIkKExJQkJJ TikiIF0gfHwgJChJTlNUQUxMX1BST0cpICQoTElCQklOKSAkKERFU1RESVIpJChMSUJFWEVDX0JJ TikNCj4gKwkkKElOU1RBTExfUFJPRykgJChMSUJCSU4pICQoREVTVERJUikkKExJQkVYRUNfQklO KQ0KPiANCj4gLlBIT05ZOiB1bmluc3RhbGwNCj4gdW5pbnN0YWxsOg0KPiAJcm0gLWYgJChhZGRw cmVmaXggJChERVNURElSKSQoTElCRVhFQ19CSU4pLywgJChMSUJCSU4pKQ0KPiAJcm0gLWYgJChh ZGRwcmVmaXggJChERVNURElSKSQoYmluZGlyKS8sICQoU0NSSVBUUykpDQo+IAlybSAtZiAkKGFk ZHByZWZpeCAkKERFU1RESVIpJChzYmluZGlyKS8sICQoU0JJTikpDQo+IC1pZm5lcSAoJChCSU4p LCkNCj4gCXJtIC1mICQoYWRkcHJlZml4ICQoREVTVERJUikkKGJpbmRpcikvLCAkKEJJTikpDQo+ IC1lbmRpZg0KDQpXaHkgaGVyZSBkb27igJl0IHdlIHVzZSAkKFJNKSA/DQoNCg0KDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:34:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:34:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373235.605332 (Exim 4.92) (envelope-from ) id 1oEsne-0007xb-7D; Fri, 22 Jul 2022 13:34:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373235.605332; Fri, 22 Jul 2022 13:34:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsne-0007xU-4M; Fri, 22 Jul 2022 13:34:38 +0000 Received: by outflank-mailman (input) for mailman id 373235; Fri, 22 Jul 2022 13:34:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEsnc-0007xO-Np for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:34:36 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 05b4143d-09c3-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 15:34:35 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658496870909100.07187457516591; Fri, 22 Jul 2022 06:34:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 05b4143d-09c3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658496872; cv=none; d=zohomail.com; s=zohoarc; b=K3KXLnLBM/sDDCTJ/1cAFcvt+/nyCR0WJaJC+3c0WMDNVV15bIe7Pn7zFbdb+OYNlijn4beWdXmfLLnYgd7/sqo8uWvGLleWEk7tkq71OOKgnX3ez+bWB2LTtMnDtirVjmns0mPSD8KQswtC84rEeVu+JRGuZt1zjtL4ZrphXFQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658496872; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=eWYmUzB8UzAGnireUWQ3+Nj0NSCC3ugxXIDD+vcIowU=; b=LMw5Bc3Ed+ngEEx+VRNK9IfGMSb9TQPg//2ttoO5kj12dzj4A0DsE5aOs/qEe0RvTrZ44yqsaxDi+vBD6L2V7FJS0qGhX3mz7qrDJuDID0FGCirXK5w+OHJOETd/UUguwLOmqrLANKvYRdjTig9f8sKfqoDMU15KbvtnCmBhsTw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658496872; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=eWYmUzB8UzAGnireUWQ3+Nj0NSCC3ugxXIDD+vcIowU=; b=RVK+gKwIgZdkKCjzL2QFEp9g8XaxDoIajqEx5YAbnGrwwl6zuH/QxDg23IyUVBNG 55noLw5GWH6lrmImK6rllnmvz0/OuzJH6xfMnQWE8tKCakKDi8v5fX/ndfZai1vNG9z 5aLLWczMfes4oY07kSDBIg2rAjnFpcs6m1iV1cWE= Message-ID: Date: Fri, 22 Jul 2022 09:34:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "Smith, Jackson" , "xen-devel@lists.xenproject.org" Cc: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-8-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 07/18] docs: update hyperlaunch device tree documentation In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/18/22 09:57, Smith, Jackson wrote: > Hi Daniel, > >> -----Original Message----- >> Subject: [PATCH v1 07/18] docs: update hyperlaunch device tree >> documentation > > >> diff --git a/docs/designs/launch/hyperlaunch-devicetree.rst >> b/docs/designs/launch/hyperlaunch-devicetree.rst >> index b49c98cfbd..ae1a786d0b 100644 >> --- a/docs/designs/launch/hyperlaunch-devicetree.rst >> +++ b/docs/designs/launch/hyperlaunch-devicetree.rst >> @@ -13,12 +13,268 @@ difference is the introduction of the ``hypervisor`` > >> + >> +The Hypervisor node >> +------------------- >> + >> +The ``hypervisor`` node is a top level container for the domains that >> +will be >> built >> +by hypervisor on start up. The node will be named ``hypervisor`` with >> +a >> ``compatible`` >> +property to identify which hypervisors the configuration is intended. > ^^^ Should there be a note here that hypervisor node also needs a compatible > "xen,"? Ack. >> +The >> hypervisor >> +node will consist of one or more config nodes and one or more domain >> nodes. >> + >> +Properties >> +"""""""""" >> + >> +compatible >> + Identifies which hypervisors the configuration is compatible. Required. >> + >> + Format: "hypervisor,", e.g "hypervisor,xen" > ^^^ Same here: compatible ","? Ack. >> Example Configuration >> --------------------- >> + >> +Multiboot x86 Configuration Dom0-only: >> +"""""""""""""""""""""""""""""""""""""" >> +The following dts file can be provided to the Device Tree compiler, >> +``dtc``, >> to >> +produce a dtb file. >> +:: >> + >> + /dts-v1/; >> + >> + / { >> + chosen { >> + hypervisor { >> + compatible = "hypervisor,xen"; > ^^^^^^^^ compatible = "hypervisor,xen", "xen,x86"; Ack. >> + >> + dom0 { >> + compatible = "xen,domain"; >> + >> + domid = <0>; >> + >> + permissions = <3>; >> + functions = <0xC000000F>; >> + mode = <5>; >> + >> + domain-uuid = [B3 FB 98 FB 8F 9F 67 A3 8A 6E 62 5A 09 >> + 13 F0 >> 8C]; >> + >> + cpus = <1>; >> + memory = <0x0 0x20000000>; > ^^^^^^^^^^ memory = "2048M"; > Needs to be updated to new format for mem. Ack. >> + >> + kernel { >> + compatible = "module,kernel", "module,index"; >> + module-index = <1>; >> + }; >> + }; >> + >> + }; >> + }; >> + }; >> + > > Similar adjustments are needed for the rest of the examples I believe. > > Also, two typos: > Line 287 is missing a line ending semi-colon. > Line 82 has a double space between 'node' and 'may'. Ack. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:48:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:48:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373246.605344 (Exim 4.92) (envelope-from ) id 1oEt14-0001c2-AG; Fri, 22 Jul 2022 13:48:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373246.605344; Fri, 22 Jul 2022 13:48:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt14-0001bv-7Z; Fri, 22 Jul 2022 13:48:30 +0000 Received: by outflank-mailman (input) for mailman id 373246; Fri, 22 Jul 2022 13:48:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt13-0001bp-28 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 13:48:29 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f591754b-09c4-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 15:48:27 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658497699048555.4846389057155; Fri, 22 Jul 2022 06:48:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f591754b-09c4-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1658497700; cv=none; d=zohomail.com; s=zohoarc; b=JuTol4TEcWlmzqCO5eWNW1Sp+CdG16SwD+Ii4eg+NtX3dB7KAtb+raGPqrxtoB/b7uXDZ/AdEwG7ONRJl0z+BoHG8h9wac2L7Ad1tLGa+WF3zZMk21HSbmkbJZVERUay7LBN+egL2w1uzCP2UbeiWGyQLqsKpGLQyRBVVmjWaZs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658497700; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=xnD+qKqY92asmX/XIXB+qAKIUsXF3sKlaZLCB+kmrys=; b=caVOL/kYZRMOQinQt7jAIiydN20WAXBBM5qRCZbVyw3YRHE//UqzWl4ZyVF2jIV0laCAXRe9hgNj01spwgIObN01sl0IYPc8L+WhM5n8wTcVj1KAnKko5MTFoPDn7HVVZMSvlyFn8kpT53WmX+x8at+cOw2kIHYtzBDspVNS+Ao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658497700; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=xnD+qKqY92asmX/XIXB+qAKIUsXF3sKlaZLCB+kmrys=; b=ua4xj4lRIS7kHdJXaDSBF/ZVhnNHqugnqlbzBoD8AHvq8l7tEZQriF3+64ZZI+lz LAx/edubVwnBDEwfmPE5lX8dkxpdTTaQw1Uat8u5r6GXxut5pdcD7pA0Yp2L44E+gXK GrWNCrRSmYe3Rd60Bwo1Td9yHBFrcHuTGdHc7+N4= Message-ID: Date: Fri, 22 Jul 2022 09:47:54 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-9-dpsmith@apertussolutions.com> <86f73a8a-5433-03c2-71fd-ee6a5abbe550@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 08/18] kconfig: introduce domain builder config option In-Reply-To: <86f73a8a-5433-03c2-71fd-ee6a5abbe550@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 09:29, Jan Beulich wrote: > On 06.07.2022 23:04, Daniel P. Smith wrote: >> --- /dev/null >> +++ b/xen/common/domain-builder/Kconfig >> @@ -0,0 +1,15 @@ >> + >> +menu "Domain Builder Features" >> + >> +config BUILDER_FDT >> + bool "Domain builder device tree (UNSUPPORTED)" if UNSUPPORTED >> + select CORE_DEVICE_TREE >> + ---help--- > > Nit: No new ---help--- please anymore. Ack. >> + Enables the ability to configure the domain builder using a >> + flattened device tree. > > Is this about both Dom0 and DomU? Especially if not, this wants making > explicit. But perhaps even if so it wants saying, for the avoidance of > doubt. The following patches will end with full conversion of both Dom0 and DomU construction to be handled by a core domain construction framework. If a device tree configuration is not present or this Kconfig option is not set, then the domain builder will construct a Dom0 as it does today. Turning this option on enables controlling the domain builder using a device tree configuration, which (eventually) will be able to construct any combination of Dom0, HWDom, CtlDom, DomU, etc. So I can add a qualifier of, 'configure what domains will be constructed at boot by the domain builder using a flattened device tree'. I can even add an explanation that on x86 the FDT must be provided as the first multiboot module. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 13:57:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 13:57:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373252.605355 (Exim 4.92) (envelope-from ) id 1oEt9Y-0003LK-70; Fri, 22 Jul 2022 13:57:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373252.605355; Fri, 22 Jul 2022 13:57:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt9Y-0003LD-27; Fri, 22 Jul 2022 13:57:16 +0000 Received: by outflank-mailman (input) for mailman id 373252; Fri, 22 Jul 2022 13:57:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt9X-0003L3-BR; Fri, 22 Jul 2022 13:57:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt9X-0005KP-7u; Fri, 22 Jul 2022 13:57:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEt9W-0001pP-Rs; Fri, 22 Jul 2022 13:57:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEt9W-00083j-RT; Fri, 22 Jul 2022 13:57:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=C4LsWLBdiv666bwneQeqDuO8YVRCncfkpQE37jz77A8=; b=IFJx5nRMqBiTndL6Nni9RAblue cLz+VTJx8HjVC2f0vdOdkA3CEZ50fF9ltW87vfjlR9nzDljjO7jb9QWnFIMfUk8cS3G04RsJiTsqi BCjFJW+z+OCP4o5GS/ydfJgUyiEr7GrT8Z8RAEH7WWO5lGuiUNnC5tuo/wa6YDPrZ/wM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171758: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=25883cd5f0b188f2417f294b7d219a77b219f7c2 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 22 Jul 2022 13:57:14 +0000 flight 171758 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171758/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 25883cd5f0b188f2417f294b7d219a77b219f7c2 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 742 days Failing since 151818 2020-07-11 04:18:52 Z 741 days 723 attempts Testing same since 171758 2022-07-22 04:20:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116638 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:06:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:06:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373264.605366 (Exim 4.92) (envelope-from ) id 1oEtIo-0005CL-5V; Fri, 22 Jul 2022 14:06:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373264.605366; Fri, 22 Jul 2022 14:06:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtIo-0005By-2j; Fri, 22 Jul 2022 14:06:50 +0000 Received: by outflank-mailman (input) for mailman id 373264; Fri, 22 Jul 2022 14:06:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtIn-0005BW-76 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:06:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2062.outbound.protection.outlook.com [40.107.22.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 86666490-09c7-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 16:06:47 +0200 (CEST) Received: from AM6PR02CA0025.eurprd02.prod.outlook.com (2603:10a6:20b:6e::38) by AM5PR0802MB2530.eurprd08.prod.outlook.com (2603:10a6:203:98::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 14:06:45 +0000 Received: from VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:6e:cafe::75) by AM6PR02CA0025.outlook.office365.com (2603:10a6:20b:6e::38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 14:06:45 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT064.mail.protection.outlook.com (10.152.19.210) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 14:06:44 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 22 Jul 2022 14:06:44 +0000 Received: from d2cc2ffe1092.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 66C82476-9E14-4398-BDEC-8C98F71E1AB2.1; Fri, 22 Jul 2022 14:06:38 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d2cc2ffe1092.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 14:06:38 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM4PR08MB2913.eurprd08.prod.outlook.com (2603:10a6:205:a::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.22; Fri, 22 Jul 2022 14:06:36 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 14:06:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 86666490-09c7-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PMooFyZHk/kUT6oz5QMOFIHsfZCONyMIsmFUw8LAls1JM+VzWP52fNP+gvyzHlYn5XJ/XPx6RGp5tkRm+uGEbdlvwdZj+WQmFp/jIYppb6+27g9vuvUlPiD2IwSy8sSXg3JcXQr7U5KPqu4Ejxpy76yFTKYhVSJTSadU0FqFRS3RwKCA/j7WfTMkxw/Jup7b2/FMHB9n0/OZorrfwbsej7uMq2pl/+ZbSI56a42BWJc7HbFMYpFw1gk7t/jNcdy5w9+Q4E13B9I07aYcDpYlojNcuFtF1tRMQvx8xvxnnqtm5LLJwHdi4NXJZaFAdroWt5d2MfYg61QgU2F9TxpSIw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=JNQ3iq8/9V0ngCu/l3ahI7creRe1yNVJjPbJoZp0ros60vjHLuBZEOkRv9DzzHOhnWFyWyrM4k8Mak/pIlvyl+E2jp5nd6MoqyrUKwGxQp1a4dHCWKhrxAT1eLj3FlGo/pdYgAUE6X3JT9pRYrKG9OVxzpwYonVHuLvknuQCvAC7XVUl9+eVKGLPzxf2UT/aMvFmvzlO5n7nlnvqlQCPghujQWN2V8PVxMsi85Y/8C2sjmsDVkCgYlA/xGNeeknhe59rddfRi7y5JAUHR65KfRFJV7m2xxTVL4cdUm5axlt9ekXAR6RUNwl0Xapd7CmoczGLBiQ9WFMVjsgd4iIlQw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=tZr74qf5Fj9XHc8BGzzkCajYbGuHW4znyRVxxwEIx/UBA7tWkvAG/CK184JWEc4Bkqu7SGVT0alREF46nJthhZdGDHYXsRpordsS4XotUnXw76FRsoqK/BKRWXdmOERW1zm4tc3tSDkLN5WJiyEmqBnW9wDHNzPtrDH/CFWip/g= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: d303d9d6274a1ae8 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cfeA2vGikfOi0Nzil+7L4nQ9JSiZ+AyKY4iTGHyh54UC0qzAUp51HWNP9BM+1k2sr50pR7yX34YYUUDoeYAyIRmhrJ61aolOaoRZOSVrjRGbzNwsAMGtP0RBSgf4EgjnQdir3kW2RZU3q5JxBxcUq0gBw5EVBxI5mlZz4J/hn8qBJdAHkGl8jnkEFR+mYWOU+uf3Tn+GZzxNbr9nijg/zwKWZuAW6LIqlRhPmm/gPcRBjOoArcz4brzmvGf/lTQ2L4OWa07xOXH7clwkHsPINjAK7QiIdQsd/fZ+GbTcC/0dQcRLt0PtYwiGHanPxUGZ7fl3sIowHfMrrnIbeJb3Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=MUJdcJ9cI9TGglQEWbzb4FQbfm9oaRMA6YWpsp1NTphytMa2p7o/TMe/fjDhmRzZThpvpO1lmdFeAU1U04MfyUeQBrRoFX/4f+cutDzgxvWYbd7WyiDFpWXjBmhFPd8V2YgrbdT/HxI2LQ8ID/Mlp1+gb9l3xgA+6EsFHql1VnTwGTxul8pxtb/xAdEw/gImt1fGV8iG2JeNiKSl80KxlicEotUhfHOFm3v0/Y8dxj6OH1MgHZBppDXrpV+1Hhqp8x+rT2CeOQX5+zjfOCy3k8JQiTpt7NLzQ9FL69MsAOpJEAJJVQxoaxBnB9v6oMOPv0Dbnx3KUwa7kM16zDzUsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0sockyqUQ192qkRWDk7L0M9+vX96BUdJhjWpGJq0C0o=; b=tZr74qf5Fj9XHc8BGzzkCajYbGuHW4znyRVxxwEIx/UBA7tWkvAG/CK184JWEc4Bkqu7SGVT0alREF46nJthhZdGDHYXsRpordsS4XotUnXw76FRsoqK/BKRWXdmOERW1zm4tc3tSDkLN5WJiyEmqBnW9wDHNzPtrDH/CFWip/g= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 21/25] tools/helper: Cleanup Makefile Thread-Topic: [XEN PATCH v3 21/25] tools/helper: Cleanup Makefile Thread-Index: AQHYh+SpG67mKDjnhUizMZbh76UNia2KmLeA Date: Fri, 22 Jul 2022 14:06:36 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-22-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-22-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 88c8d963-49bc-4521-a118-08da6beb68cb x-ms-traffictypediagnostic: AM4PR08MB2913:EE_|VE1EUR03FT064:EE_|AM5PR0802MB2530:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: nQl/a6/VNwn5SXTACLFzksCT3oVqLGLKwaX7IO4U9YZnRAcLjIfKi3MHgysVfJ3hSiEF5MJjKUArKegk2e3EEzXvoVLO0sk9q7zrsFa/giihXf2O+DNsiamfltq14KLLDSmVO+Xe7ppwP8ulWnZRWPmVoNXCC3d2/ojgmmQR3TW1lZybIAoOuWxXdZOCiN0VsXAxEAoDpiqW8XXXB13pi2S/mZ21FSEIscRudSVOGUzWuLSeevXMxdh++9z0NAdCu1G6MQcEVqssSduFlcN1z1ToraxehujYEB+xQT7j6UNKdzFaEOqM9xhiYHdQC8SSp8DGvkR8woRbDZJEJxQVTYCK6bMVTU7liP1mh5dEY1XqDErvzYseKhPcqw8nRiwAHJQ0jFQbbbLQGx4tQ/Q9m5adCI0xzVyOPVbmGymfa9VYqZ2PvGeby7JDlwVOlTDr2YBgge5e6Q6RlHGFze6miYDcU0phWsUScuj82PrO1cCC8OYbZ3dNcyVSkpmxjIOfx3Z5gLIR1YXbeJ8gmszppCHgwBnqwwYbZTYfmYiGNa4irZChwXB+/b5WCrR76vtqK0NI8cG7Qz87EHvMJptn4UvcOeSzosP7KF1x3h54kUYB6YOY0eWTouk7zqVWQ9i170UllfQrfB8cd1M72rCaLFAWMCoj3Z8YRmm3b4oglM285pPtd37raydG0NCardRF9G/AK3UgEXevYPUIMEhT8w0JufSXP4KuaDhdEnwMf9aE6Wiw3Hb9hrDa68qm9n2XwdE8zNh0AkV5xQ5t02Ol8/b2+PAZh40BPuS76IocvopULWVeU0rq909j0E2zXkTUrhvo/2b5f4s5Ix3NNpikJQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(366004)(39860400002)(376002)(346002)(86362001)(66446008)(8936002)(6512007)(5660300002)(38070700005)(26005)(2906002)(186003)(38100700002)(122000001)(53546011)(6506007)(36756003)(6486002)(66476007)(41300700001)(6916009)(71200400001)(2616005)(478600001)(54906003)(76116006)(91956017)(83380400001)(33656002)(4326008)(66556008)(66946007)(8676002)(64756008)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <33D2932FACCBE84B8EF81573146330E8@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM4PR08MB2913 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ffc68cd7-7dcf-457c-7f37-08da6beb63de X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OexHW6ZjKGxJTyHylfR/LbLBA2nrfL7/t4/PGGhA9EHZSUrx/b+4tZr+VSnQ/m/HNi7Qj3ns8zmHuQ4wQ+FCxcf+janssNPE4Ntch85ZP1yW2gqkf+K2zTLNeQP5ueFdoGvrsOCVBc7oe9oGMVxys9QMeTAOzSF5gBF2QNijV+45flbywwDAtLOmOYay3jmyYqfVXFSHAew7lob680iqwV7IQScpSat70joXXP6HCuGFyPCEyC6k+M6iMo92hshlAPtEuPmH7HFFIaFjfSPbcqJHYDYbBtSc+zLleUp4fXzdWs0xKDUuN2r6NrO4p+4qBO5tpTXoulq6ymVymSvTAFvZtqvvgKFvG1ITTezMFmQ3B/6XMuPAnZnIcPW2jdVfKWijd1Uw+ammwEyOue7hdxUL7WoKEAnUhWcbybHBddgzjhc635m1FiHHQU55R6yZVOOaTBQAywxuEJC1ENZkXjETb04Yu8u9pohuncE/qWW9FB0BQFkO9ltTQDutn+cpwSILFGB7AAeVEmU3MaIaQGaaN11mTJ4N7mYNh0i+jRqrkQilF6SQrmjtUAAxCZvcqHb3w0B7zn+VR6A5SSttN8OZzOvTrwsgEoVqGQ8Fxsocm7UHgXIV6scs3onCAcS+FtgdpkUAPqweRCxI1bPbubPHwh0bR1rqpKIMmfFy5UiJx3N9bx8vjTaQq4BtGhac/jlxSJklAnpCac4PT3MaiajrQ88bJ+3ZW5UY3RKmNV4VJg82ma40c+v1XlTMYER1jn+U8W7LPksgwrpjUOwhrVIjDc19zqe7QRWuBq0hd8UcAEgg/hOBy6CziR7XasVa X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(346002)(376002)(36840700001)(46966006)(40470700004)(8676002)(6862004)(8936002)(5660300002)(70206006)(70586007)(40480700001)(40460700003)(2906002)(82310400005)(54906003)(4326008)(36860700001)(83380400001)(86362001)(36756003)(6512007)(356005)(33656002)(81166007)(82740400003)(26005)(6486002)(478600001)(316002)(47076005)(2616005)(186003)(336012)(6506007)(53546011)(41300700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:06:44.4980 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 88c8d963-49bc-4521-a118-08da6beb68cb X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2530 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KPiBVc2UgJChUQVJHRVRTKSB0byBjb2xsZWN0 IHRhcmdldHMuDQo+IENvbGxlY3QgbGlicmFyeSB0byBsaW5rIGFnYWluc3QgaW4gJChMRExJQlMp Lg0KPiBSZW1vdmUgZXh0cmEgIi1mIiBmbGFncyB0aGF0IGlzIGFscmVhZHkgcGFydCBvZiAkKFJN KS4NCj4gDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVSQVJEIDxhbnRob255LnBlcmFyZEBj aXRyaXguY29tPg0KPiAtLS0NCj4gDQo+IE5vdGVzOg0KPiAgICB2MzoNCj4gICAgLSBhcHBseSBj aGFuZ2VzIHRvIHRoZSBuZXcgImluaXQtZG9tMGxlc3MiIGhlbHBlci4NCj4gICAgLSBtYWtlIHVz ZSBvZiB0aGUgbmV3IG1hY3JvICQoeGVubGlicy1sZGxpYnMsKQ0KPiANCj4gdG9vbHMvaGVscGVy cy9NYWtlZmlsZSB8IDIzICsrKysrKysrKysrKystLS0tLS0tLS0tDQo+IDEgZmlsZSBjaGFuZ2Vk LCAxMyBpbnNlcnRpb25zKCspLCAxMCBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90 b29scy9oZWxwZXJzL01ha2VmaWxlIGIvdG9vbHMvaGVscGVycy9NYWtlZmlsZQ0KPiBpbmRleCA4 ZDc4YWIxZTkwLi43YzlkNjcxYjMyIDEwMDY0NA0KPiAtLS0gYS90b29scy9oZWxwZXJzL01ha2Vm aWxlDQo+ICsrKyBiL3Rvb2xzL2hlbHBlcnMvTWFrZWZpbGUNCj4gQEAgLTUsMTMgKzUsMTMgQEAN Cj4gWEVOX1JPT1QgPSAkKENVUkRJUikvLi4vLi4NCj4gaW5jbHVkZSAkKFhFTl9ST09UKS90b29s cy9SdWxlcy5taw0KPiANCj4gLVBST0dTICs9IHhlbi1pbml0LWRvbTANCj4gK1RBUkdFVFMgKz0g eGVuLWluaXQtZG9tMA0KDQpDYW4gdGhpcyBiZSBUQVJHRVRTIDo9DQoNClRoZSByZXN0IGxvb2tz IGdvb2QsIHNvIHdpdGggdGhpcyBhZGRyZXNzZWQNCg0KUmV2aWV3ZWQtYnk6IEx1Y2EgRmFuY2Vs bHUgPGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCg0KSeKAmXZlIGFsc28gYnVpbHQgYW5kIHJ1biB0 aGUgdG9vbCBzdGFjayB3aXRoICh1cCB0bykgdGhpcyBwYXRjaCBvbiBib3RoIGZ2cC1iYXNlIGZv ciBhcm0gYW5kDQpxZW11IGZvciB4ODZfNjQgYW5kIHRoZSBiaW5hcmllcyBhcmUgb2suDQoNClRl c3RlZC1ieTogTHVjYSBGYW5jZWxsdSA8bHVjYS5mYW5jZWxsdUBhcm0uY29tPg0KDQoNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:16:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:16:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373272.605377 (Exim 4.92) (envelope-from ) id 1oEtRf-0006gM-14; Fri, 22 Jul 2022 14:15:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373272.605377; Fri, 22 Jul 2022 14:15:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtRe-0006gF-UA; Fri, 22 Jul 2022 14:15:58 +0000 Received: by outflank-mailman (input) for mailman id 373272; Fri, 22 Jul 2022 14:15:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtRd-0006g9-3M for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:15:57 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00065.outbound.protection.outlook.com [40.107.0.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd167310-09c8-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 16:15:56 +0200 (CEST) Received: from FR3P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::13) by AM0PR08MB4209.eurprd08.prod.outlook.com (2603:10a6:208:10c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Fri, 22 Jul 2022 14:15:53 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::7) by FR3P281CA0063.outlook.office365.com (2603:10a6:d10:4b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.14 via Frontend Transport; Fri, 22 Jul 2022 14:15:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 14:15:52 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 22 Jul 2022 14:15:51 +0000 Received: from a41c43fa236f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D428F4FE-2C6A-47CB-A864-DA1CDE98A1FB.1; Fri, 22 Jul 2022 14:15:45 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a41c43fa236f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 14:15:45 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by VI1PR08MB5437.eurprd08.prod.outlook.com (2603:10a6:803:13d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 14:15:42 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 14:15:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd167310-09c8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=h6Bydq6sIk/2FZUSh/SYmrHQL1UAQRGGRVHVfPO6xf7gbatzu9j3/dgETounVhGOPdfMLBaTJ6n+sI0WEwLUlbljhNkUNPZ8H2foai+pXmzshOl5jP0rDa6ShzpecEMkCg1JNg2a7NaVcryDs90vfeyAmu6DnKwzsCXUGjYF7K6cUSDMMSCJiwSQB39DVGnu0n9xqQ2ta/Sx1Lt2SAwbqriqtz6sEDg8O6HTeko8+5wm5jy2WP7yK14c0vwj4tX3wYQTHF2C5j7bTR1iCIkR3Q7nHluQPA4unxMCC+D5zdZhliV+ISBiKk8BCbAC7y2Yy/n/94dwdT9WpK/G5Uj8BQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tHtpbGJkU4h9FCTOiG+Z7bDDA/CF1i+cP4q3c8efRU=; b=m+xMNvrhgJqtIy3ciukPU1uC5+6PJkzx64VAdxzu+EHU9r9EA5JMSpjUi/JiJQSqQyh7OzAI6hTrCE6i+KQkapiQw5W5baZt+diYyeeLIrRCucLeb4XT9Tv4ypffPX2p35Ry4DeXkTQtRM5OgUVvIACgUkzIgo1IByhzud8tFb6P3stY7jFaAJ/FOkje3/0pfX6zx4RbRhwWYctAMG4cDWFKzdfZuYDHjeIENrFcaQBdNyF4LkYwe9AqC0ofgOBxldAyuUU2gTZ9qjK3NLIQ5s63CBgO1hLgsBuHDEKpa3IBm+mmeavLqtHIq3kBdqQOOdvFS0CqWfI8toF4EQBSyQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tHtpbGJkU4h9FCTOiG+Z7bDDA/CF1i+cP4q3c8efRU=; b=sIPgXV4OnVuKQtZnIKyRYSs+EQluSo7MI8ptNeQo00WW2JX6FcmrS8HZv755+FL5Z5lA2NDfDQwF8IiYjtofayQ8q2P7+BJSF5ym/O8T/1D2YQIAXGtGUfrsYMNuWnYjG0m/5MEb/ITAliW+mKO8Mxye3GOswlsfDGJ3gj6/mjg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 620a799ab8d25c4d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F3qI+mATLSsPtGDvAFpndTTco4avfJ0xXQ+UdjDK914IkQgqS9zJEQRe2NkhMiRxT8Ho5gXw6DGp7ZxXLwUcd1CLoUyB/zuF6qUwlWOdPx9PyLxNfJghpL0Yglz23yWdeADXe80Gt6ZGDqlUJPl3LVAFunyBfbSar/kuVP2Fv3hqFjFN4TRw6sN2K2xtM5TXT+mCNA0ifit46GuIJFG683Yl7VPimu1barg7vsyBnqsCabjOtrnbMw+BjAGpXKXNFgJavmqsewTxGViUj9NXhVgg88hn++8omvaOnUTr1vBXawSOhKCqGArllwohAi4/OKuqFS3jeK5U7/M985+FIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1tHtpbGJkU4h9FCTOiG+Z7bDDA/CF1i+cP4q3c8efRU=; b=U8cLSnUbf+Iu/MxRuQ7HIHoPccB3yy5QQ5Gxoyy2iQ6dKkrD6TDY7uioV6QfeHQJIo9vqGV0tblYywcQlkuOnyU0kTgx5lQMo1L4uUD1YvvSbToEulyWoVn9pUsR42YqxYPNiLmpQu8T7E7byrnhmCW5f/tW/BQwk2BwSOU/oDjmXRqHTpiT4dG/5/TeC4xqkWsMS8VkceIa/Ahc+KWE/fL/V6wHvp/mAqcCBNBYwoWyaCDFTuE/s7pFknn0CQqH6TFc6D2ZavVUBepdQmvGmpaeSKXrmZLIQDkCSFn0CE16FYtjSb8qp4fRcAN9+7f/Ig/z3jhXFBUPD2L8qYISHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1tHtpbGJkU4h9FCTOiG+Z7bDDA/CF1i+cP4q3c8efRU=; b=sIPgXV4OnVuKQtZnIKyRYSs+EQluSo7MI8ptNeQo00WW2JX6FcmrS8HZv755+FL5Z5lA2NDfDQwF8IiYjtofayQ8q2P7+BJSF5ym/O8T/1D2YQIAXGtGUfrsYMNuWnYjG0m/5MEb/ITAliW+mKO8Mxye3GOswlsfDGJ3gj6/mjg= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 22/25] tools/console: Use $(xenlibs-ldlibs,) Thread-Topic: [XEN PATCH v3 22/25] tools/console: Use $(xenlibs-ldlibs,) Thread-Index: AQHYh+SsviFG70C+5ESE8GdSE6k7yq2Km0KA Date: Fri, 22 Jul 2022 14:15:42 +0000 Message-ID: <2C041D8E-96F2-472D-9EFD-78CB0ED3CFE5@arm.com> References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-23-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-23-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d2891a99-bd72-4cb6-c4d4-08da6becaf3b x-ms-traffictypediagnostic: VI1PR08MB5437:EE_|VE1EUR03FT041:EE_|AM0PR08MB4209:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n8MVjy0RZhmgBKkTr4ydzgCUDr48N4/60WI6ZAywKPlANimYxR2uyEMCYoeVBcVkm/Lvpp5Lh0uMZL7/gS3sGlI0op9xxHKxyaTY5NgFUbvu+vEmmCdH+4WrKTsTbYDk928lkUtszl+Od/4G73xKvd0bLv7Nm+h1R0KJgPec/3dLm6DQlFW4EhCckhitsNBwjnm3/w0rN5gYd57i7CETDy2/HiwAaf2cEuDUqocUa/js+GYieFXlKoQAQL08hAwOEVvSwi3kUWiOTMVROJfLvbpPrCrKpfNqN7i/+QMQQRymxtfzt/rzAZIaBZKFfiVbGdMW9Crv1gf3heu1bUjcQABhGhnY7cdMas6F031WjJw7NEBEn6yIox2GSNZHNAjTxdSQzPa2VlO+CdIineDwCp37MuR4OaqhdnoGZBTibXEdnPNjcOjnXnPC0sd4zoqXUojIglrRi7DgnJKeHz393SHDMPbdkXvannj9o4iTUKnYszIGVAYuEsGi2l4rlfWe4fvXhDb8nNwRvnCuEHVR6aQ3FzEVgK/vL2Qrf2sgePz8MGsI+cFlSb+KyPhuxYqlwqUbNn07veUVfwIrAETABFBNkVXIHPj06Tou8Ok+t/YaeVwJ303Qn+3TOBK2bsDseOcQoDZPkiowD6NAWYFlGQ1Gv5NbOQlHOxor1ttyEi578Lf2sLjMPzqo4FEh/NMXht3qoBMwnLuDk4oQAhKa2q+rmpGAhQZ59Dfarp/H8VVuU3OnwYvXCrLeN+ytc7Ao+2Lly8Z3/Pqt2suvyIsD5TSTMVD2JznA+cSfPjSIKQTP/Vbty3hHoM3C90TdG6ubyuzFVBy50RnHA+NJV14YSA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(316002)(71200400001)(33656002)(6916009)(558084003)(54906003)(6506007)(6486002)(478600001)(2616005)(53546011)(26005)(41300700001)(8936002)(86362001)(2906002)(5660300002)(91956017)(8676002)(66946007)(4326008)(66556008)(76116006)(186003)(122000001)(38100700002)(83380400001)(36756003)(64756008)(38070700005)(66476007)(6512007)(66446008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5437 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 48d071e3-97dd-42c1-cb9e-08da6beca964 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PQL2oqk4OHI6kZgHRpPrlq2k+FIWMDwLPFSEj2Jn7gPfhGUBEthBjXbaZjUjPRWrOo/tXaUIfBDrXiNTjTc8Nd4639juvpuSpQOeeWj5zPtRjrPZYTsVklTwf5keRqYI8sbAB0z79bclJGndFLZuvhP/DoQS5KLcGrf+eTFjtySB9iBuWj25Y4Fq1+7YkqWpWl8NHsv4m/8O4SDy1HRx/CjIOy4L+mX6ifvRCfAgjLlE8ut1aGoNZKbsraybqTgwjUVDnuHff1eKfxpYKrVjgznhtwT9Jy42sE6WSEdnFgMrRrNWhMmI/NNUiSIrL8o1kvyZzZD0U9aHKkcbybr93tRWXE4tgav0QSg0PFWnjEfgXQPr1U23ugAdYQHKinwpuuSM1ERlsLu7Feh38zo4Yv6h1JlTd/FgOKky9oIHATv3miTLP1U/ucayxGhXmEdazNx51HVpqXjIJEif8Tw/sJGF97ZAR1vvkg0V7SRFnoXFKdsMD5Uy96va+HfGGJPnU6SwNVugVeXQUR1fwCToT8MKV9N0mP6GeDQvzMtgrq/R69BRwHBDtwTN+cKJeho0++6QDxijPiwDBjYPdZyHViWBEb2BBkD+sLG/gbClbmU9Qa/F/7jCrsYYaPIkh2TAoAL08W+xj6Xj0QvYhGaXSYgJ8inm6r2vkyOYx5qa02sRJmYbEPIsHang4rDn3rl9NGNxAV3JG00nEddWcTRgZ1C+5vSyN+/CGhQoAABbJ92XmcgCYSs1CmcGjmp/rELy+Tb6jj62XiECco4SfXSy8OfnCEQt9GAvrMCMTgIkBedMNiPxUTVDv/+YkfS9GB0r X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(136003)(346002)(36840700001)(40470700004)(46966006)(26005)(2906002)(4326008)(6512007)(2616005)(41300700001)(558084003)(6506007)(478600001)(70586007)(5660300002)(6486002)(86362001)(82740400003)(356005)(8936002)(82310400005)(6862004)(53546011)(186003)(336012)(83380400001)(40480700001)(36860700001)(40460700003)(33656002)(316002)(47076005)(54906003)(8676002)(36756003)(70206006)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:15:52.1636 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d2891a99-bd72-4cb6-c4d4-08da6becaf3b X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4209 DQoNCj4gT24gMjQgSnVuIDIwMjIsIGF0IDE3OjA0LCBBbnRob255IFBFUkFSRCA8YW50aG9ueS5w ZXJhcmRAY2l0cml4LmNvbT4gd3JvdGU6DQo+IA0KDQpJdCB3b3VsZG7igJl0IGh1cnQgc29tZXRo aW5nIGFzIGNvbW1pdCBtZXNzYWdlIDopIA0KDQo+IFNpZ25lZC1vZmYtYnk6IEFudGhvbnkgUEVS QVJEIDxhbnRob255LnBlcmFyZEBjaXRyaXguY29tPg0KDQpJbiBhbnkgY2FzZSB0aGUgcGF0Y2gg bG9va3MgZ29vZDoNCg0KUmV2aWV3ZWQtYnk6IEx1Y2EgRmFuY2VsbHUgPGx1Y2EuZmFuY2VsbHVA YXJtLmNvbT4NCg0K From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:21:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:21:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373280.605387 (Exim 4.92) (envelope-from ) id 1oEtXH-0008Mn-Lh; Fri, 22 Jul 2022 14:21:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373280.605387; Fri, 22 Jul 2022 14:21:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtXH-0008Mg-Ia; Fri, 22 Jul 2022 14:21:47 +0000 Received: by outflank-mailman (input) for mailman id 373280; Fri, 22 Jul 2022 14:21:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtXG-0008MW-M3; Fri, 22 Jul 2022 14:21:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtXG-0005u3-GE; Fri, 22 Jul 2022 14:21:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtXF-0002Rq-Ur; Fri, 22 Jul 2022 14:21:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEtXF-0003b6-UQ; Fri, 22 Jul 2022 14:21:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jEg0Ta+FGBDDXLtYF4lOx8NlZzoCADwbe3Fo6v9Falw=; b=0Z/znMvrxtHSaWwpKhYyS+5gnF wndkrtPiirW/sbjRTr3JYxtjy3z9r9krh6zrGPPP8+rfMBQ3fBYxwWROCJpDhzN6fSdd0fLBtfZWj U8Ep/pD4tI/GmKaNYfCRkBiCDPkjRo2RQhYdgwO3M8o21IOZvBgN1i0lTBzBFp+mL1eQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171753: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-unstable:test-arm64-arm64-xl:xen-boot:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=d2cc5633e2800e698c6a64554de7fa19d9627a24 From: osstest service owner Date: Fri, 22 Jul 2022 14:21:45 +0000 flight 171753 xen-unstable real [real] flight 171771 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171753/ http://logs.test-lab.xenproject.org/osstest/logs/171771/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail pass in 171771-retest test-arm64-arm64-xl 8 xen-boot fail pass in 171771-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171718 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl 15 migrate-support-check fail in 171771 never pass test-arm64-arm64-xl 16 saverestore-support-check fail in 171771 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171712 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171718 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171718 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171718 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171718 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171718 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171718 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171718 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171718 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171718 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171718 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171718 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen d2cc5633e2800e698c6a64554de7fa19d9627a24 Last test of basis 171718 2022-07-21 07:37:39 Z 1 days Testing same since 171753 2022-07-22 00:07:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Anthony PERARD jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl fail test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git d2cc5633e2..fcd27b3c75 fcd27b3c759995775afb66be6bb7ba1e85da0506 -> master From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:31:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:31:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373295.605415 (Exim 4.92) (envelope-from ) id 1oEtgo-0001vi-SZ; Fri, 22 Jul 2022 14:31:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373295.605415; Fri, 22 Jul 2022 14:31:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtgo-0001vb-Pd; Fri, 22 Jul 2022 14:31:38 +0000 Received: by outflank-mailman (input) for mailman id 373295; Fri, 22 Jul 2022 14:31:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtgm-0001vT-Ku for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:31:36 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fb8cee34-09ca-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 16:31:34 +0200 (CEST) Received: from mail-dm6nam11lp2170.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Jul 2022 10:31:30 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5826.namprd03.prod.outlook.com (2603:10b6:303:9f::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 22 Jul 2022 14:31:29 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5438.028; Fri, 22 Jul 2022 14:31:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fb8cee34-09ca-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658500294; h=from:to:cc:subject:date:message-id:content-id: content-transfer-encoding:mime-version; bh=0yx9l+JCziqpt4/8vgwPPTFtZRpxE7WZ6ZYYHa1Jmxg=; b=hMGoutCj2hSsB3r9BO8xAOQrRhKQnX7xWH4dMf+7gebQKRij4sq4wOrK uoHs3DIDB8Yymy50X1F+gZ5MaN+G50W6c2ZfJXb72uz8WT3kGjyilbpQw jCxyOsMzIXttudxj2WgcnIZmichX2G8KdZCJe5gCYqzwnIDqcfjgsAAP0 k=; X-IronPort-RemoteIP: 104.47.57.170 X-IronPort-MID: 76421545 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:j4tbI69GXT+qjrOEpg2bDrUDIX+TJUtcMsCJ2f8bNWPcYEJGY0x3z jFOCGCGO/mLMzChfItzYd60pBkG6MODm9FiHQA4qCo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9z8kvU2xbuKUIPbePSxsThNTRi4kiBZy88Y0mYctitWia++3k YqaT/b3ZRn0gFaYDkpOs/jZ8Ew15qyo0N8llgdWic5j7Qe2e0Y9VPrzFYnpR1PkT49dGPKNR uqr5NlVKUuAon/Bovv8+lrKWhViroz6ZGBiuVIPM0SWuTBQpzRa70oOHKF0hXG7Kdm+t4sZJ N1l7fRcQOqyV0HGsLx1vxJwS0mSMUDakVNuzLfWXcG7liX7n3XQL/pGEkAEE505p9ROJj929 /YlDiJONU2NvrfjqF67YrEEasULCuDOZdpallQ+iDbTALAhXIzJRLjM6ZlAxjAsi8tSHPHYI c0EdT5oaxeGaBpKUrsVIMtmwKH02T+iLHsB9wr9SakfugA/yCRY1rT3PcWTUduNXchPxW6Tp 37c/nS/CRYfXDCa4WXbrij127OS9c/9cKEcEZOSyKFlu1GSxXIoDgdGBEOLuNDs3yZSXPoac ST44BEGvaU0sUCmUNT5dxm5u2Kf+A4RXcJKFO834x3LzbDbiy6bDGUZSj9KaPQ9qdQ7Azct0 zehnc7tBDFpmK2YTzSa7Lj8hSipJSEfIGsGZCkFZQgI+d/upMc0lB2nZslnOL64iJvyAz6Y6 zKFti8lnJ0IkNUGka68+DjvqT+2uoLASAJzwwzNR3+k9StwfovjbIutgXD74PBaPcCmR1+Ol HEeno6V6+VmJZSEjimEWugONLCv+feeMTfYjEJvHp8u7DCk8TioeoU43d1lDEJgM8JBdTq3Z kbW4FpV/MUKYyPsarJraYWsDchs1bLnCdnuSvHTaJxJf4R1cwiEuippYCZ8wlzQraTlqolnU b/zTCpmJS9y5XhPpNZue9og7A== IronPort-HdrOrdr: A9a23:6tZIea8Vh2em/1ULxoJuk+Fvdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQgdcdDpAtjifZtFnaQFqrX5To3SJDUO31HYZr2KjLGSiwEIfheTygcz79 YGT0ETMrzN5DtB/IvHCWuDYrAdKbC8mcjG69s2pE0dLz2CHpsQizuRfTzrd3GeKjMnObMJUL 6nouZXrTupfnoaKu6hAGMeYuTFr9rX0Lr7fB8vHXccmUazpALtzIS/PwmT3x8YXT8K66wl63 L5nwvw4bjmm+2nyyXby3TY4/1t6ZXcI5p4dY2xY/ouW3bRYzWTFcZcsnq5zXUISdSUmRYXeR /30lMd1opImjTslyqO0GDQMkHboUwTAjnZuBOlaDLY0LDErHhRMbs9uatJNhTe8EYup9d6ze ZC2H+YrYNeCVfakD36/MWgbWAcqqOYmwtWrQcotQ0qbaIOLLtK6YAP9kJcF5kNWCr89YA8Ce FrSMXR/uxff1+WZ23Q+jAH+q3kYl0jWhOdBkQSsM2c1DZb2Hh/0ksD3cQa2nMN7og0RZVI7/ nNdq5oiLZNRMkLar8VPpZ2feKnTmjWBR7cOmObJlrqUKkBJnLWspbypK444em7EaZ4vqfaWK 6xI2+wmVRCBX4GU/f+o6Gj2iq9MVmVTHDq1txU4YR/t/n1WKfrWBfzOGwTrw== X-IronPort-AV: E=Sophos;i="5.93,186,1654574400"; d="scan'208";a="76421545" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mgJfpdWkLXesJwvEy87BSbzvusZ5/A9rKRqPNeiwgJ03dv1zT0cpSubdKfH5bCoFYnRaYFIdhiUppkgDkE/+kEXjEDNtjze9bR+GldqxnlmU+/lz34RfFEjAn6un/jUlOEXXRR7oi1mTAOyijmSz9aoEUrN2ct8q1ebFxDIGabwdeEahqjoHxprSZ3TBwZxEK66hvAFOIiLDdRMo97d0ixicqrJ7TjpK2FY6XOhX9ay1AfAXpEHgC/+Jm5Bi7jiPwh7yFYgdjfySLQrtU/4lywym02E6KBTbhX3CyGYzg0mPqFuLTOn7bCGZGm3bcdQa5gR68nYb65ase4VG3elUkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0yx9l+JCziqpt4/8vgwPPTFtZRpxE7WZ6ZYYHa1Jmxg=; b=ELahwZitsamR3Lt8F70lDi/to8/l/TIfFC3lOj/3SeeJGdu1Pz39lS8aW1URAdJPIpBrh4hs8YD4LJzS8jQCmURiUoCU/gppahGc0LOyCfQwXn0rsGtczMqZ2phvpUbVhfLyG0nQ9UsGulmBciDehK/16LWDYP40AUimprkIOfgL8yD+jpV670WZPYY1mP9f1nLMOS7Lh32k5cDgShLeEqU2IN/cbxvel5x4ok0LN3zBumqedSTrSKc4+JaorsKfgkjLKM2H8GnhNb6HUMdxzvDgFka5IM5Gmx3rQE1ckYz48qoIsSJaRpkA9ip/45A/OF1KWlrcWiuzLyDnwOUysg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yx9l+JCziqpt4/8vgwPPTFtZRpxE7WZ6ZYYHa1Jmxg=; b=i3u3BeOPKJoefcwhQnmUEIWEIQNd1x+7naxo/s/bmCWcIeuhvyL9NYl7MQLY0ALBq+0Y52zKzqOxtO66LmBFYOxNz00LZBQkEuS8lW1SfOYZs8a2XfE5scovDVfFm3Ct2vo+fZBxrYpNNvDgb0GNiCKySCkg28zRV4GOk7VFhfg= From: Andrew Cooper To: xen-devel CC: George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross , Roger Pau Monne , Bertrand Marquis , Henry Wang , =?utf-8?B?TWFyZWsgTWFyY3p5a293c2tpLUfDs3JlY2tp?= Subject: Licensing issues Thread-Topic: Licensing issues Thread-Index: AQHYnde78ZWweQEF5EuUvPBrJgjmBQ== Date: Fri, 22 Jul 2022 14:31:28 +0000 Message-ID: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 27ff810f-18b1-4504-4f4d-08da6beedd9a x-ms-traffictypediagnostic: CO1PR03MB5826:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: W5INVu7LFLzbcAc3xQwzrYhmrgM24qyQttw/++fl1ugf0eNDvXiTuyngC+D7XiXWdpztstqzBbrWjZGt2qHFjWaXHAZuyOPv07ptU0a7Y9WdrymKEBYnt8e2TVKJUEzh0COJrpGTh58SAHJzotjcw7LMbxeZ3kTOYjYoM9LGJnXiOWHJVamwBd/5l6q3ksOCqzEZkgUKNlB/c1BmWOA1eHvn1Rnta6GlfbqChmUjCjYBRsapRY+SacQPjMKk7jiHP47PrzxtAcI8qeKOgH/6rQMYbcuKyIS8R6jUXm6qpebBpHoofo9nNfIDtMt4E41UOAmEqYJW1ESp/k6v8swWbcZsdlekpu6BaQSQU+wCucZxW/a55X9jI05MFLH0Boye4SEulWWtkIGXSUJ5Tpzo6WXxrfyC8Ned8yrTnzstFWs0VxkCO0CSUbdfIqW9RJyY8X1CkCAWtff581dxTDrHkpgnVcUQc0LsAkwJfcq5Sre/fGpba0wdLP0UVgGVS4ZBLHZk28GvptlfiiJ9wZZdP89UQRWazsQJiAuXIWQ03572w/6eNM5qJS1EXxsmrTNgFjUkVdXjF+l9gBYTmQKsCFUksrAYGfzasvDLlz7P3qlJVkuddSVLOX1f5T+L6s3xruWQqInH1Qa3445UbyWxB4Q2MvsjxCXBRSGAnOdGG2iRy7I7jHskO191x1mwn+UhrE4CKrf+I2NC/+kgZ6v29Eq9BiRFfFaC2RyZcHVNKjyIRP42ducGHx4eam5IqUl7vXm1ncTr8lMaQOH/Eidk4WsruhqPdboRlObQZ817KikPZ5CiD/DzCew6NQzWWWSzpiLGIgyUnQ1lxOidPWJEWWUcQ/gsSgZXOwaE29BtzDTqBQ9LK4/uTVmpsJr3hOJ1 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(91956017)(122000001)(76116006)(6506007)(186003)(36756003)(4326008)(54906003)(6916009)(8676002)(82960400001)(66446008)(66476007)(66556008)(64756008)(66946007)(316002)(31686004)(38100700002)(7116003)(38070700005)(86362001)(2616005)(8936002)(6486002)(31696002)(478600001)(5660300002)(3480700007)(71200400001)(6512007)(26005)(83380400001)(2906002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bnBpR0VtMXhoMTZabEF5WHVDcEpmYjQ0eHlnQXYzYkRFVE1nYUVaZ1hPM2Y0?= =?utf-8?B?cWdtamE2M2lCM2NNS1M1c3F5dEE2L2ZtUnBMemxYZ1d6NG1wZmJvMTVTUFpO?= =?utf-8?B?UklaR204MDNiTTM1SVNKNDNXUmNiOWVVRUttcHliR2ZYN0g1VDVmWmNVYUEz?= =?utf-8?B?WFdtd2Q5cFhKSzQ5WnE1MjdTcXJDY3dCSExsMmtDWXF1OStnVHoxNnVYOW5E?= =?utf-8?B?NUFYVnBZTWxXSndEUlZmQjYrRXJSRzJQQUtuclJwYytmS0p6RndXMDVGdWtC?= =?utf-8?B?SnlrdFBGRmxPaWVwMkM5bEY3ZVdZSHU4MnVPS2NNK0ZkRjdtdGt4WnMzNlJr?= =?utf-8?B?dXNmZlJKR3QydjhxRFBuSDBvN2ZJOHk2WUc2L3h0VFp5WmRSYWhmTExoTDI5?= =?utf-8?B?Vjh2a1BuRjBTdzRZYzN1U01NQk92Uk1TZmlhdFBtc04yNEZQKzJyMkUzb2Y3?= =?utf-8?B?OEQvT2x5LzFzU2dpelJRcFZLUExYbWRIQkZrTjlrYW1xSUJ3Y3RvQlVBbTBM?= =?utf-8?B?b2xURXlJV3hneDFMWWExdFNMM2taNzhiQnp1bHlnQXkvU09Pc3hMM1VieUZD?= =?utf-8?B?MkNlOFF4UWVUSkc4Qmg2b1dlM210WHU2WDJpaFdDSTRIa2h1OG5Kdi9ZVERJ?= =?utf-8?B?ekhqOEl3ZzR2UUJOR2xzbkw0bHhFOWlFTks5U3pYQ1RUdnN3TzB4K3MzMFRE?= =?utf-8?B?bjdjZ3pIdWxOQThTRHhZTm0zb2J3ZmlFRnZlUE1nMW9QZEppSXJ2N1lxWVBi?= =?utf-8?B?cEt1WUg4cVRUOG5hSXBNOEo0c2NGeFY5VDFxRCtFeU9qeTRabWxjV1lmUkZY?= =?utf-8?B?QklHS0V3QldlZy9tMnkvajJ5eldpa3p2dTJic01ET09vS0JoYitHemVISjZQ?= =?utf-8?B?Tmc0cDVla2docnZhay9kMktETm9lYmZRL3U4bis5Q0xQODNzWjBzcU9QZUtP?= =?utf-8?B?RzJtQTJsVUlDcWpDY3BxalZBQVZTZ1VLM3c2bm45RlpaZkQyQ1dDanFOR3Jm?= =?utf-8?B?QWxXUDgydktQVlNmRXEzdE56RUtOdloxU0FDaW1qMHl1eGdYMEZEcXk5Q0Fh?= =?utf-8?B?U1BUT3hQaXFuUVJZYmFiUHIwWWtPWlBJVFBiaU5RcFV3NXVRQURQNk1Nc3Iv?= =?utf-8?B?YlpNcFlkdkJBdHRxeU5taGhmQW5WTmRzd01ZUkRyUm5POWlYekp3MmNTRHFW?= =?utf-8?B?MUFmOGM4akNqMFlzL29NcVZzTzdYN0grTVRPeWkzNHdOQzg2SGhIQmQ4Vm5V?= =?utf-8?B?SGF5Uk9kZkdVTVJweHBhSGZ1ellOTnpqQUwzemN1SkRXOEdvQlE4YkFGQmRN?= =?utf-8?B?UGFSMlhWTEMvZmdJVDVXM0pGcUNzeXJpVkEwWU53ZmNTV2RRWlJKeFUxbHo5?= =?utf-8?B?dXI2cnBGOUxyNmI5UmJaSVBxRGxxS0V1Nm16dXA4V2RaTmtKTWkyUDI0ZE5R?= =?utf-8?B?Q05XYlFXWExldlZnRzJBM3ZMUHBUTmY2aGhEbXJ6bVkyeHg1M3pZUFpNWWpY?= =?utf-8?B?YkNaK0xNZ1l0eEdJNjlMeGJCS2lLRmpOZWh5a3lhZ3dJbU9SS3ZOSzVvV1Z5?= =?utf-8?B?VjNxdEN6L0FlbGF5NkRMeUdZTDVpUlNHQ0hIK3d2d0NTT1ovWklESVpWVVN1?= =?utf-8?B?UWVwS1c5Z2JOV0w5SktydmxHSk1LNHB0Q0dybFVjTU5pcWdPeGhzWEgvWTl1?= =?utf-8?B?M1R5ZmxqMlZCUmxlSGNJcW5jQlI5NXlFd2VBbFlqN3ljNFdMaWJSQ1ZkRDZY?= =?utf-8?B?R3FJTTNBUjV5Z2dZZy9OWWd1VEtoZTU3ZzFiUTBXeWErdU1sQS9wbDJ4UDZn?= =?utf-8?B?RzJSeTVRQ3pyYW9BQjByT2RabkpwM3hnN21sNWhzdVBvakpHR1pxMDJ4UWMw?= =?utf-8?B?UjJwZ1EwQW0vMVVQSXUzQlhlK0E2Qk1jb2FoQU1LRnhDUTkvbWI5ZWhiY2JF?= =?utf-8?B?RzhiUng2cGY3VWliaVFiejhBOGF3cG94KzZCK2JPR1A0Z09JNXRlZ2pBOEpC?= =?utf-8?B?MWVrTkVKaTVLQ1lZL0ZTQktaKzBQbmk2NDhGaTZubnRNbEpqRzBTMmVPbWtH?= =?utf-8?B?UHFJUmREeWxuK3RDZEJKY1puOFpOSlFzYmxCZm5QSGhtTThhRmtGQjZwTytn?= =?utf-8?Q?oQ7+GGchxYHlCkNdk4h8WvwKF?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 27ff810f-18b1-4504-4f4d-08da6beedd9a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 14:31:29.0143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: M7AV1njCxpPR1452iHCRzPlg2mJBms7l8QaZoswrLPeE9VLHUy1asoaBg3nRY610Va14O+tZVcfQ+xXKG+tDY1GzAJgcBbVC/rmwHSYbHH0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5826 SSd2ZSBiZWVuIGNyb3NzLWNoZWNraW5nIGxpY2Vuc2luZyBkZXRhaWxzLCBhbmQgd2UgaGF2ZSBz b21lIHByb2JsZW1zLg0KDQoxKSBXZSBpbnN0YWxsIHhlbi9pbmNsdWRlL3B1YmxpYy9DT1BZSU5H IGludG8gL3Vzci9pbmNsdWRlL3hlbi9DT1BZSU5HLA0Kd2hpY2ggaXMgbm90IGNvbW1vbiBwcmFj dGljZS7CoCBUaGUgaW5zdGFsbGVkIGZpbGUgaXMgbW9zdGx5IHVzZWxlc3MNCmJlY2F1c2UgaXQg ZGlzY3Vzc2VzIGZpbGVzIGJhc2VkIG9uIHRoZWlyIHhlbi5naXQgcGF0aHMuDQoNCjIpIFdlIGFj dHVhbGx5IHVzZSB0aGUgTUlUIGhlYWRlciBmb3IgdGhlIHB1YmxpYyBpbnRlcmZhY2UsIGJ1dCB3 ZSBkb24ndA0KYWN0dWFsbHkgY2FsbCBpdCBieSBpdCdzIGNvbW1vbiBuYW1lIGFueXdoZXJlLg0K DQozKSBUaGUgZm9sbG93aW5nIGZpbGVzIGFyZSBtaXNzaW5nIHRoZSBNSVQgaGVhZGVyOg0KDQov dXNyL2luY2x1ZGUveGVuL2ZvcmVpZ24veDg2XzMyLmgNCi91c3IvaW5jbHVkZS94ZW4vZm9yZWln bi94ODZfNjQuaA0KL3Vzci9pbmNsdWRlL3hlbi9mb3JlaWduL2FybTMyLmgNCi91c3IvaW5jbHVk ZS94ZW4vZm9yZWlnbi9hcm02NC5oDQovdXNyL2luY2x1ZGUveGVuL3N5cy9nbnRhbGxvYy5oDQov dXNyL2luY2x1ZGUveGVuL2RldmljZV90cmVlX2RlZnMuaA0KL3Vzci9pbmNsdWRlL3hlbi9lcnJu by5oDQoNCkZvcmVpZ24gYXJlIGF1dG9nZW5lcmF0ZWQgZnJvbSBoZWFkZXJzIHdpdGggTUlUIGxp Y2VuY2VzLCBzbyB0aGF0J3MgYW4NCmVhc3kgZml4Lg0KDQplcnJuby5oIHdhcyBhbiBvdmVyc2ln aHQgd2hlbiB3ZSBhZGRlZCBpdC7CoCBUaGVyZSdzIG5vIHByb2JsZW0gZml4aW5nDQppdCwgYXMg aXQgaXMgY292ZXJlZCBieSBtdWx0aXBsZSBzdGF0ZW1lbnRzIGVsc2V3aGVyZSBpbiB0aGUgdHJl ZS4NCg0KZGV2aWNlX3RyZWVfZGVmcy5oIGlzIHByb2JsZW1hdGljLsKgIEl0IGNhbWUgaW50byBl eGlzdGVuY2UgaW4gYy9zDQoxYzg5OGE5ZmVjN2U0IHdoZW4gc29tZSBMR1BMIGNvZGUgd2FzIG1v dmVkIG91dCBvZiBsaWJ4bCwgYW5kIHNvbWUgR1BMDQpjb2RlIHdhcyBjb3BpZWQgb3V0IG9mIFhl bi7CoCBTbyB0aGVyZSdzIGN1cnJlbnRseSBhbiBHUEwrTEdQTCB2cyBNSVQNCmxpY2Vuc2luZyB2 aW9sYXRpb24uDQoNCkkgaGF2ZSBub3QgbG9va2VkIHRocm91Z2ggaGlzdG9yeSwgYnV0IGl0J3Mg bGlrZWx5IHRoYXQgdGhlIGNvcHlyaWdodCBpcw0KY292ZXJlZCBieSBpbmRpdmlkdWFscy9jb21w YW5pZXMgd2hvIGFyZSBzdGlsbCBhY3RpdmUgbWVtYmVycyBvZiBYZW4sDQphbmQgSSBkb24ndCBh bnRpY2lwYXRlIGFueSBwcm9ibGVtIGdldHRpbmcgaXQgZm9ybWFsbHkgcmVsaWNlbnNlZCAoaXQn cw0KanVzdCBhIGZldyBjb25zdGFudHMpLCBidXQgdGhpcyBkb2VzIG5lZWQgZml4aW5nLg0KDQpz eXMvZ250YWxsb2MuaCBpcyBtb3JlIGNvbXBsaWNhdGVkLsKgIEl0J3Mgc3RhdGVkIGFzIHB1Ymxp YyBkb21haW4gd2hpY2gNCmlzIGZpbmUgZm9yIG91ciBwdXJwb3NlcywgYnV0IGluY29uc2lzdGVu dCB3aXRoIGV2ZXJ5dGhpbmcgZWxzZSwgYW5kIHdlDQpuZWVkIHRvIGFkanVzdCB0aGUgdmFyaW91 cyBmaWxlcyB3ZSd2ZSBnb3Qgd2hpY2ggc3RhdGUgdGhhdCB0aGUgZnVsbA0KcHVibGljIEFQSSBp cyBNSVQuDQoNCkJ1dCBpdCBkb2VzIHJhaXNlIGEgZGlmZmVyZW50IGJ1Zy7CoCBXaHkgZG8gd2Ug aGF2ZSByYW5kb20gbGludXggaGVhZGVycw0KY29tbWl0dGVkIGluIHRoZSB0cmVlLCB1c2VkIGJ5 IHNvbWUgdXNlcnNwYWNlIGxpYnJhcmllcz8NCg0KQW5vdGhlciBlcnJvciBJIGZvdW5kIHdoaWxl IHBva2luZyBhcm91bmQgaXMgaW8vbGlieGVudmNoYW4uaC7CoCBUaGlzIGlzDQp0aGUgaW50ZXJm YWNlIGZvciB0aGUgZG9tLT5kb20gdmNoYW4gc2hhcmVkIGhlYWRlciBzbyBvdWdodCB0byBsaXZl IGluDQp0aGUgWGVuIHB1YmxpYyBoZWFkZXJzLCBidXQgaXQgaW5jbHVkZXMgPHN5cy90eXBlcy5o PiBmb3Igbm8gbmVlZCwNCmV4Y2x1ZGluZyBpdHMgdXNlIGluIG5vbi1wb3NpeCB1c2VjYXNlcy7C oCBBbHNvIGFsc28gb3VnaHQgdG8gYmUgZml4ZWQNCmZyb20gaGF2aW5nIGEgemVybyBsZW5ndGgg YXJyYXkgdG8gYSBmbGV4aWJsZSBtZW1iZXIuDQoNCg0KNCkgSSdtIGdvaW5nIHRvIHN0YXJ0IHB1 dHRpbmcgdG9nZXRoZXIgc29tZSBmaXhlcyBzb21lIG9mIHRoaXMuwqAgSGVucnk6DQpSZWxpY2Vu c2luZyBkZXZpY2VfdHJlZV9kZWZzLmggaXMgYSByZWxlYXNlIGJsb2NrZXIuDQoNCkknbSBhbHNv IGludGVuZGluZyB0byBzdGFydCB1c2luZyBTRFBYIGlkZW50aWZpZXJzIHRvIHNhdmUgb24gYWxs IHRoZQ0KYm9pbGVycGxhdGUuwqAgVGhleSdyZSBhbHJlYWR5IHVzZWQgZWxzZXdoZXJlLg0KDQpJ J20gdGVtcHRlZCB0byBwdXQgdG9nZXRoZXIgYSBjaGVjayB3aGljaCBjYW4gcnVuIGluIENJIHRv IHRyeSBhbmQNCnByZXZlbnQgbWlzdGFrZXMgbGlrZSB0aGlzIHNsaXBwaW5nIGluIGFnYWluLCBi dXQgaXQncyBnb2luZyB0byBiZSBvZg0KbGl0dGxlIHVzZSB1bnRpbCBpdCBpcyB1c2VkIGluIHBy ZS1wdXNoIHRlc3RpbmcuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:32:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:32:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373299.605426 (Exim 4.92) (envelope-from ) id 1oEthB-0002ML-4F; Fri, 22 Jul 2022 14:32:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373299.605426; Fri, 22 Jul 2022 14:32:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEthB-0002MC-1U; Fri, 22 Jul 2022 14:32:01 +0000 Received: by outflank-mailman (input) for mailman id 373299; Fri, 22 Jul 2022 14:32:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEth9-0002JJ-W4 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:32:00 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70080.outbound.protection.outlook.com [40.107.7.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0a9d5eaa-09cb-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 16:31:58 +0200 (CEST) Received: from DB7PR03CA0098.eurprd03.prod.outlook.com (2603:10a6:10:72::39) by PAXPR08MB6909.eurprd08.prod.outlook.com (2603:10a6:102:139::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Fri, 22 Jul 2022 14:31:55 +0000 Received: from DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::3f) by DB7PR03CA0098.outlook.office365.com (2603:10a6:10:72::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 22 Jul 2022 14:31:55 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT064.mail.protection.outlook.com (100.127.143.3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Fri, 22 Jul 2022 14:31:55 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Fri, 22 Jul 2022 14:31:54 +0000 Received: from b05fc40e0ce7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CBF649D1-9D16-4579-A133-2148D54FE865.1; Fri, 22 Jul 2022 14:31:46 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b05fc40e0ce7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 22 Jul 2022 14:31:46 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB3239.eurprd08.prod.outlook.com (2603:10a6:209:47::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Fri, 22 Jul 2022 14:31:45 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.019; Fri, 22 Jul 2022 14:31:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0a9d5eaa-09cb-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=kqnKNq1A2NzwnSCUI3DpS4mo7qKz3TUClSA3+XtpnFMiI1DnbPNTgOUBWAhkXQsYfQbCzFfZzocRn9/OMWs1iJYPdE1leVXdwZFqt06I0OrNqugOchK6JZrF5OkpVpoiXUle78/X5DMIcf5CdUclbAALplD3YCoMOtvhQXCbdeKtBO1Y7Jiwe3rtf9Gm0TWj2EYwyJifrU7Qy5OPnrhKr1OsLmoj4V5rSp8lVu59sYTuss0efYg/efNb2jSMKY5vIJv5pxfLOZ+OEgcDyTVXpSlVJSBe3bszKHEsWog8Y0LvNg1JQyT6PTLzAwE0YjI29td9A01txzhbFUskf0KxcA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=naDHrJpGCE9wgT5Y6+JlfCKxrH2lMRdgjZLYHRmDdg4=; b=DOC9vfqG6SUAKL9ImWgMJMPPi10E4o7IT+5PmMxs7wwkW23QTKXvuAs9Dz1CIb7FVIaUr7eKV8H3mQMFc3lC77oIrrIAtf8Qp1a3GOmps8GdxcaW3e2/umy2sR4npWPJXUe93fBViGSZqLkgSGCnkTe17k5esW5brjC0d1xKc83qqZcM5VjqenX8iHcuUVhXUAZRpIPSS00jXgbUUjpW6R1/0dHFoMRYOYcZ3Zlkx2YbCZ34F3Uokgz1jPh54nSTIoOS7B78SMlvvgxceVRH5wCf7JfTw1inrh4kKVEuVSYGSN6iK/dsAXnZC3VHIG9A2qLIjX59yk86Gc87OGsMNQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=naDHrJpGCE9wgT5Y6+JlfCKxrH2lMRdgjZLYHRmDdg4=; b=XtBUQlcioV3SOCJ21XiaL/TXkYzZ6g+DOOOit/bd6qhKsa3PZyFgGTerPPFkSz0XF7aY9jjcLz0LlcslknQWqrie7Al4vZFuEDcS8ZRQlv3EYpFOSR8vkPzuM8Ka9LKs9f6TWDloAdow0RazHESaPU1EQr/GwgCz2pIBnaArPPE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: f0c288de30d6da2c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LIhlCyWhw8qkklmaXvffjGzdeXfufiB6+mncz4+PL4Urhy4/ULWwpoxqWcUTWYnu7dSkepaLG96/EdkuLgt27hvkPPqPHXxUf1dFBzZ1AXWHb7tjDBRzJD5+IjWB9t9xKNVXmIRmzEfiuGsoyw2rD0lGUHhJCbnGPe/Ky7K0P6yfNvgExhuJZi+zGjfbafQdO0Gs0MiM0JxqhFDVsiafjURfs3aJPvDx+O+BnOQUPoHO0ONdPrgFQXv9jtohS1vALkr91W6H49GoYh7hZ/QNctXUiyTn5jlTIeD3VOY9koXcP4oXAs/M8TFkJHzEPCbnPKk1+OixnxmGxZB2ffCzNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=naDHrJpGCE9wgT5Y6+JlfCKxrH2lMRdgjZLYHRmDdg4=; b=g0b047k0KmYPWqFJqw+kWCNF4vitu2765RQItIGiVDgi0oQsXKGOIqNwNDEMZ1UcqKw9nWuGMWhu62UN4dqmTW3S0yvpohQWlGaeRsW2f82++dkhHaXrOXXWiRixUoxT2kcNbNiJ1h0MkoNbg3EgYRI2K3PgxSOAJfcFHAC1XPoZzozOcia5p1zEr2MmSdODqgm8xzdb7RHar+bTdzfeIEsnQ9IT9BaCBIAuYz9EpbY6x+iD5c2Zgh/DtTa7YRTJVbmIjjchgIl7b1z5nO6e5RDWFa2VOhXDNaokbsSEA5gA+7tbn+k3yrJOQ1V494PTWhk0BnAQa7tkkhC1OveNrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=naDHrJpGCE9wgT5Y6+JlfCKxrH2lMRdgjZLYHRmDdg4=; b=XtBUQlcioV3SOCJ21XiaL/TXkYzZ6g+DOOOit/bd6qhKsa3PZyFgGTerPPFkSz0XF7aY9jjcLz0LlcslknQWqrie7Al4vZFuEDcS8ZRQlv3EYpFOSR8vkPzuM8Ka9LKs9f6TWDloAdow0RazHESaPU1EQr/GwgCz2pIBnaArPPE= From: Luca Fancellu To: Anthony PERARD CC: "xen-devel@lists.xenproject.org" , Wei Liu Subject: Re: [XEN PATCH v3 24/25] tools: Add -Werror by default to all tools/ Thread-Topic: [XEN PATCH v3 24/25] tools: Add -Werror by default to all tools/ Thread-Index: AQHYh+S2cSvMt2yjdUK6F8k4/yD9Ya2Kn74A Date: Fri, 22 Jul 2022 14:31:45 +0000 Message-ID: References: <20220624160422.53457-1-anthony.perard@citrix.com> <20220624160422.53457-25-anthony.perard@citrix.com> In-Reply-To: <20220624160422.53457-25-anthony.perard@citrix.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 39608cff-d96d-4fe3-0c11-08da6beeed11 x-ms-traffictypediagnostic: AM6PR08MB3239:EE_|DBAEUR03FT064:EE_|PAXPR08MB6909:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: DfhhH2XGYHKKZXaWxPkmJB2Bit6v1qlK32Gz+UR2WChOYqSuF7FTWDsudQ3E3yY6Zt1LuAb3tIeUVL1NJi7RgZ0qwoUu4FQtGE0wJPg3dfTR++sFGn0qR2HGs1PHcicZOl3MRYVHEb1lfyNOWr9ONPqZJfGiIpd24euztjRsQDwI8yBWsOm6fihJdNbiJfgigOfjCFG4i3vCQ4S2Ftd5UNcQE0p2zCjuXK6iJCO53SD4RgbVvfiawidnUhuOUkBz1d/xNKgkMzG0CIZFuohjuLsh2tMSUCL1y8LJb809cbJwkhTSXbUpS4yHKJ3DG8f41djZMHodI9hCXQrSyyLvd6aEhr+JnxuRLHWv2CVYByfEgPwa+vIpEM62R4wwiTU2jdicGSM6zkSGcxY/HzIAb+mO9/CAgsyaXWUeGK9OpIKMxngf3qCGWgLBdnp6vzRq7642NEGW2poq9RNmwV37PXix9GovxHOhmhPyENo830vGpSvGGVNoiOfO3F7eMUal/MnHC/YQ9FlVuPb0JbVdwN+hNsRu0j2ijykDCwoG7rS1y71xFfPTKAuq+gvRh1cEphYq/vN+TksPk0CYsfY7GlNOvRRWS6sZU8CAQB7aYz9o18zTi2pavNrPZKuOYmrvpGKbC07C4kZRNir9uUDqL37TQ8CIxe9zaJ8Ox4mlZ5FxXu5nCdD5yuSrzMidvbnE4Q5Xaz1lSAiB2xLBVu50n8QZ18Av/oC/mlBoq6vM/JlVAPAiQyNpwNlxWhxThiLi0tRx55BVOYYrdEC0UxS5/TukToWAwrJ7dp0oXtbSqZn0NC5Lv2CT95O/luZ4AHRuU3S+mJIqdLXu44fbu9/4Dw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(366004)(396003)(346002)(39860400002)(4744005)(33656002)(6916009)(5660300002)(71200400001)(41300700001)(122000001)(2616005)(478600001)(54906003)(86362001)(38070700005)(316002)(2906002)(66476007)(8676002)(4326008)(26005)(91956017)(64756008)(76116006)(38100700002)(8936002)(66946007)(186003)(53546011)(6512007)(6486002)(6506007)(66446008)(66556008)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <3FC41CDFCF0AA8449FD2329C5A7F7C6C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3239 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1364ee79-89a3-402b-e0fc-08da6beee74b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TbPkZBav0Zb+aiqZjpmZxJk4/fkTnEiu7Vu+GETeZD/qWDx0bHVCSciRFz0EcVD6MVtLM7M8SIcevvf1dEkIKJple2WEy1Kdx1Fa1eQPaNx5tlQjdmjenazrjkg5kYybCqfMlwUhRPSwh7+dDk+VnBBf6/4rb3HhrBtwAVjaDXdDX0XCLNmJzmiTmFX8bAu4UYgGB7rqZNc17Lj5PFW8rdvrdYk5NdPQh3nzcASDZzPntnMDum/f7hMLMINGa6Au/YRRscjXjGIgPcMYSDhFHnmy48gG4nE9LFmL2XMTpuFWIlMJiDHYGzYcJAb3qynisETR0NZ8H2jjtSFuOGLn01Awbl6iEj5yE0Vn212aGEZLagSS52o82MPtOU0IJ+SiM+CWYN1k0mF1X3roLFe3qx3zS40z1miLHJg+S4+7wYvHmzybdH1oo/jAh2zr1EdTW6QesWzbmYliwX6O6Xu71Y25GtVkPV/BC1XHYbUhvAXZidgVJQn9BHlrhESsJScFVCmjjKdc7JYF6lgtuOKRp8sWaty61TwS6g4Gs/i/8tp8hwSbekZRkr3mZbDyOgC8y5I/p5oGf1fmolAL2EdQo7UzbUM2SAO6pCCH/F8CX1hURp7OsK8KVdJdxMT/0XUuuV9TEQHudjjVfLFjR6c3lhZJ/RGyFp2pk8lqUEFdLvoyOt7xYpSevkalM5JvJOlePNeHfKlYEwUisFieuRlQSatQ9QDDdGY8PHM28PwNfycmMbRAL5MkxhnWybsAhlQxcXJ/rMSBoEIJ68iUlRPwt8IqquS8DfAYv6d/hb+qlPAL/5KXgEz0JUcgNBXzs0XK X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(346002)(376002)(39860400002)(40470700004)(46966006)(36840700001)(33656002)(47076005)(26005)(53546011)(336012)(41300700001)(2906002)(186003)(2616005)(6506007)(6512007)(81166007)(40460700003)(86362001)(356005)(82740400003)(40480700001)(36860700001)(82310400005)(36756003)(478600001)(316002)(4744005)(6486002)(4326008)(70586007)(70206006)(8676002)(6862004)(54906003)(8936002)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2022 14:31:55.0052 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 39608cff-d96d-4fe3-0c11-08da6beeed11 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT064.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6909 > On 24 Jun 2022, at 17:04, Anthony PERARD wrot= e: >=20 > And provide an option to ./configure to disable it. >=20 > A follow-up patch will remove -Werror from every other Makefile in > tools/. ("tools: Remove -Werror everywhere else") >=20 > Signed-off-by: Anthony PERARD Hi Antony, Looks good to me Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373307.605436 (Exim 4.92) (envelope-from ) id 1oEtm3-0003Ry-Mg; Fri, 22 Jul 2022 14:37:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373307.605436; Fri, 22 Jul 2022 14:37:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtm3-0003Rr-Jo; Fri, 22 Jul 2022 14:37:03 +0000 Received: by outflank-mailman (input) for mailman id 373307; Fri, 22 Jul 2022 14:37:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEtm2-0003Rl-P9 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:37:02 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id be5b179b-09cb-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 16:37:01 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658500613510367.3388619115185; Fri, 22 Jul 2022 07:36:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be5b179b-09cb-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1658500615; cv=none; d=zohomail.com; s=zohoarc; b=UkLSqu+I+jERP8niOM9qnZwTq4ONc7DgQMfomir4FoMIuRD5leLLpjCIRNXSmQpvbXohzWLz4jmfIIh++iZ2xAjZ58DRBd5ILP+aQ02duRe6Pj7DQSGXrsBD6NKFOF8cHlAOkb7DPn5182OcNdXmL2xIqDhDs8XyT2SCyBvhvSk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658500615; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=cyMNX9hjD/zX8ywkDXCFUsBvTbaj01gv0K3cyjQb/w8=; b=d0yoeUYJPoVHeR79sO7aUDwN3tNLCIViP4yIbReAtrXN8LZc1MKwMtIb/8Yv9eKjmMeCOM/Srt31HLi5ASlM68Uh49Gv0LWSzYZvjQVZPovsWvyleAxXzEL4fRzaWmgC6Gb26FoIgekKTQPoc+6Nzwca37unK1hy/Y2OhV+P+Y0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658500615; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=cyMNX9hjD/zX8ywkDXCFUsBvTbaj01gv0K3cyjQb/w8=; b=W/r7hO09+rkXpRNPW4cqh/nmKDRcUn0WQ3Mahmu3uPeKT4nJl0dA0gCQ/4LTf9Ri CNU7gvOtrd4o89tB1bCiAPla5X7gAD9Kfy3VvyOfXGNkX+zGBYdM1cdgU3YLVf2xPG/ GJ0MlBHRdxP2Fhs6bvKcFTU29Revs1Afq0PfY03o= Message-ID: <96cc29cf-5b31-eabd-3cca-eeaa7d7c58db@apertussolutions.com> Date: Fri, 22 Jul 2022 10:36:29 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "Smith, Jackson" , "xen-devel@lists.xenproject.org" Cc: "scott.davis@starlab.io" , "christopher.clark@starlab.io" , Jan Beulich , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-11-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 10/18] x86: introduce the domain builder In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/18/22 09:59, Smith, Jackson wrote: > Hi Daniel, > >> -----Original Message----- >> Subject: [PATCH v1 10/18] x86: introduce the domain builder >> >> This commit introduces the domain builder configuration FDT parser along >> with the domain builder core for domain creation. To enable domain builder >> to be a cross architecture internal API, a new arch domain creation call > is >> introduced for use by the domain builder. > >> diff --git a/xen/common/domain-builder/core.c > >> +void __init builder_init(struct boot_info *info) { >> + struct boot_domain *d = NULL; >> + >> + info->builder = &builder; >> + >> + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) >> + { > >> + } >> + >> + /* >> + * No FDT config support or an FDT wasn't present, do an initial >> + * domain construction >> + */ >> + printk("Domain Builder: falling back to initial domain build\n"); >> + info->builder->nr_doms = 1; >> + d = &info->builder->domains[0]; >> + >> + d->mode = opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; >> + >> + d->kernel = &info->mods[0]; >> + d->kernel->kind = BOOTMOD_KERNEL; >> + >> + d->permissions = BUILD_PERMISSION_CONTROL | >> BUILD_PERMISSION_HARDWARE; >> + d->functions = BUILD_FUNCTION_CONSOLE | >> BUILD_FUNCTION_XENSTORE | >> + BUILD_FUNCTION_INITIAL_DOM; >> + >> + d->kernel->arch->headroom = bzimage_headroom(bootstrap_map(d- >>> kernel), >> + d->kernel->size); >> + bootstrap_map(NULL); >> + >> + if ( d->kernel->string.len ) >> + d->kernel->string.kind = BOOTSTR_CMDLINE; } > > Forgive me if I'm incorrect, but I believe there is an issue with this > fallback logic for the case where no FDT was provided. IIUC, the issue at hand has to deal with patch #15. > If dom0_mem is not supplied to the xen cmd line, then d->meminfo is never > initialized. (See dom0_compute_nr_pages/dom0_build.c:335) > This was giving me trouble because bd->meminfo.mem_max.nr_pages was left at > 0, effectivity clamping dom0 to 0 pages of ram. > > I'm not sure what the best solution is but one (easy) possibility is just > initializing meminfo to the dom0 defaults near the end of this function: > d->meminfo.mem_size = dom0_size; > d->meminfo.mem_min = dom0_min_size; > d->meminfo.mem_max = dom0_max_size; I believe the correct fix is to this hunk, @@ -416,7 +379,12 @@ unsigned long __init dom0_compute_nr_pages( } } - d->max_pages = min_t(unsigned long, max_pages, UINT_MAX); + /* Clamp according to min/max limits and available memory (final). */ + nr_pages = max(nr_pages, min_pages); + nr_pages = min(nr_pages, max_pages); + nr_pages = min(nr_pages, avail); + + bd->domain->max_pages = min_t(unsigned long, max_pages, UINT_MAX); Before that last line, there should be a clamp up of max_pages, e.g. nr_pages = max(nr_pages, min_pages); nr_pages = min(nr_pages, max_pages); nr_pages = min(nr_pages, avail); max_pages = max(nr_pages, max_pages); bd->domain->max_pages = min_t(unsigned long, max_pages, UINT_MAX); v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 14:51:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 14:51:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373315.605447 (Exim 4.92) (envelope-from ) id 1oEu0A-00064Q-3Q; Fri, 22 Jul 2022 14:51:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373315.605447; Fri, 22 Jul 2022 14:51:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEu0A-00064J-0f; Fri, 22 Jul 2022 14:51:38 +0000 Received: by outflank-mailman (input) for mailman id 373315; Fri, 22 Jul 2022 14:51:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEu08-00064D-G4 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 14:51:36 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c704cd0f-09cd-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 16:51:34 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658501490142284.71513356999617; Fri, 22 Jul 2022 07:51:30 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c704cd0f-09cd-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658501492; cv=none; d=zohomail.com; s=zohoarc; b=Mew7OXShvMRwoGDwHlgEjwszSNSttYY7rDNWH1oX4vMshagZkO5NGXIFsbm2xyw/jCuUjWaC2OrsvlxcJHXGMSxaU4yjenc3T/0hVmWvGcpYTTyKIpCWCk6f/i+vDhS5eoTXgD604CBHKIV8hHn3ANZTskiH3LrT4RxRd/nEk08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658501492; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=LY6ekQGrWlYm10xecyKNOkpPaSOz1o6GFlDi/DCO8J0=; b=ibjduP59Nmuo/Vf0v6DWuJJaTsKTNOg2cDAAkGU2WVQn8Me83eoFKko2estkXKrXE/dufON6dTadnlOeQVQHA3Iq2ewLTKT+0ZwLmKBDlDRyMP/FpncCsrNx9qx7aKZ30rJExVo1Ez5IaUxO0kjbEFSD3svjLWpY4tITa6Mu1Ro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658501492; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=LY6ekQGrWlYm10xecyKNOkpPaSOz1o6GFlDi/DCO8J0=; b=iJ7NPvkmsq3PyypagRSl2qhV4Nk+SlP84ad/02cbSVRnyBn12iITKofpDiMivFbc FeV1kjcn4GqMkoZqk3vD7aYvlXhAwB7R67H3+7OEDUrxdCvi56qoD7xN88t134CEiCN 36/0Sh0UPBlXaBB3f4aGDXzteqY49hUDr3kQfUXE= Message-ID: <961186e0-7da5-da27-a355-4c2554f800c3@apertussolutions.com> Date: Fri, 22 Jul 2022 10:51:06 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "Smith, Jackson" , "xen-devel@lists.xenproject.org" Cc: "scott.davis@starlab.io" , "christopher.clark@starlab.io" References: <20220706210454.30096-1-dpsmith@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 00/18] Hyperlaunch In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/19/22 13:06, Smith, Jackson wrote: > Hi Daniel, > >> -----Original Message----- >> Subject: [PATCH v1 00/18] Hyperlaunch > > With the adjustments that I suggested in other messages, this patch builds and boots for me on x86 (including a device tree with a domU). I will continue to poke around and see if I discover any other rough edges. Thank you so much for reviewing and testing! > One strange behavior I see is that xen fails to start the Dom0 kernel on a warm reboot. I'm using qemu_system_x86 with the KVM backend to test out the patch. After starting qemu, xen will boot correctly only once. If I attempt to reboot the virtual system (through the 'reboot' command in dom0 or the 'system_reset' qemu monitor command) without exiting/starting a new qemu process on the host machine, xen panics while booting after printing this: > > (XEN) *** Building Dom0 *** > (XEN) Dom0 has maximum 856 PIRQs > (XEN) *** Constructing a PV Dom0 *** > (XEN) ELF: not an ELF binary > (XEN) > (XEN) **************************************** > (XEN) Panic on CPU 0: > (XEN) Could not construct domain 0 > (XEN) **************************************** > > This happens with the BUILDER_FDT config option on and off, and regardless of what dtb (if any) I pass to xen. I don't see this behavior if I switch back to xen's master branch. > > Hopefully that explanation made sense. Let me know if I can provide any further information about my setup. That is certainly a very strange behavior. I never tested reboot as I assumed it should just go through the same process as could boot. I will add this to my tests to run and see if I can track down why it is happening. V/r, Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Fri Jul 22 15:00:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 15:00:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373321.605459 (Exim 4.92) (envelope-from ) id 1oEu8s-0007nV-W8; Fri, 22 Jul 2022 15:00:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373321.605459; Fri, 22 Jul 2022 15:00:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEu8s-0007nO-SU; Fri, 22 Jul 2022 15:00:38 +0000 Received: by outflank-mailman (input) for mailman id 373321; Fri, 22 Jul 2022 15:00:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEu8r-0007nI-Jd for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 15:00:37 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 09d76c4c-09cf-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 17:00:36 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658502027966808.5026853773671; Fri, 22 Jul 2022 08:00:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 09d76c4c-09cf-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658502029; cv=none; d=zohomail.com; s=zohoarc; b=D68mHYTQzgzyB54MnPBo1g7/y4ujM2DiCsF59J8/EC+JHAofZJhaSWd5Q0kaPJW4ao/oV31F6MlodiIXRR0kz7d+mZj6qiOt9VMd4x3XAnDHA/ARKDt7twNAoOiW6VBPeavpqhhE821KhutRg2lPanWkbR+4s6aKJ0Srqyb2Q64= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658502029; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=TVu2m/FUCQZmTM7meZirvQChW7DS1/cB07OQf3IJzRs=; b=nqKpBPqZlqxJd2wmx9Fcw6/ocjnKEUjgPwQqjmPYaiWdwskthfGEiiLCHbotAdc+kgDRSwSVgsuLU9WCvMeMX2IPYuigEmVRO5769uqWzuL6gcCbVNC6qGS/BI/tnNybkHH7QqSa34zoEyxPOaV1dzXFiS4KA3TgzT7Sx9l/sFo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658502029; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=TVu2m/FUCQZmTM7meZirvQChW7DS1/cB07OQf3IJzRs=; b=gPOJExkKiB4QxWq70/5NJYTa7F4PTpIOhcg8ZLnAJiPiJZvcZ7AbNNnVVerKwaYG sD1eBfZi30XDFRTIDYpdbap2QP29mutrHTlTE+Vj705DkyKg/msMMrsfpiWoite7Rkm mgAgAMJyQ89EGqe+bzxQPH1hEmk2yW8U1o9b1fsg= Message-ID: <5cc059f8-1d13-eccc-ded6-c91feaf6c02b@apertussolutions.com> Date: Fri, 22 Jul 2022 11:00:03 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> <59114d3a-b9fe-1fb0-fac3-fe14fe4c505f@suse.com> <6cc461b1-e308-0e2f-3f78-caf491095042@suse.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules In-Reply-To: <6cc461b1-e308-0e2f-3f78-caf491095042@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/20/22 03:27, Jan Beulich wrote: > On 19.07.2022 19:02, Daniel P. Smith wrote: >> On 7/19/22 05:32, Jan Beulich wrote: >>> On 06.07.2022 23:04, Daniel P. Smith wrote: >>>> --- a/xen/arch/x86/efi/efi-boot.h >>>> +++ b/xen/arch/x86/efi/efi-boot.h >>>> @@ -18,7 +18,7 @@ static multiboot_info_t __initdata mbi = { >>>> * The array size needs to be one larger than the number of modules we >>>> * support - see __start_xen(). >>>> */ >>>> -static module_t __initdata mb_modules[5]; >>>> +static module_t __initdata mb_modules[CONFIG_NR_BOOTMODS + 1]; >>> >>> If the build admin selected 1, I'm pretty sure about nothing would work. >>> I think you want max(5, CONFIG_NR_BOOTMODS) or >>> max(4, CONFIG_NR_BOOTMODS) + 1 here and ... >> >> Actually, I reasoned this out and 1 is in fact a valid value. It would >> mean Xen + Dom0 Linux kernel with embedded initramfs with no externally >> loaded XSM policy and no boot time microcode patching. This is a working >> configuration, but open to debate if it is a desirable configuration. >> The question is whether it is desired to block someone from building >> such a configuration, or any number between 1 and 4. If the answer is >> yes, then why not just set the lower bound of the range in the Kconfig >> file instead of having to maintain a hard-coded lower bound in a max >> marco across multiple locations? > > While I'd be fine with the lower bounds being raised, I wouldn't be very > happy with seeing those lower bounds becoming arch-specific. Okay, and I am not sure how changing the range in Kconfig would make it arch-specific. I was not proposing making the existing range conditioned and having arch specific instances. There is one range, it will have a lower bound of 4 and the upper bound of 31768. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:02:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373332.605476 (Exim 4.92) (envelope-from ) id 1oEv60-0007XL-Fr; Fri, 22 Jul 2022 16:01:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373332.605476; Fri, 22 Jul 2022 16:01:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEv60-0007XE-Cp; Fri, 22 Jul 2022 16:01:44 +0000 Received: by outflank-mailman (input) for mailman id 373332; Fri, 22 Jul 2022 16:01:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEv5z-0007X8-Si for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:01:44 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9178496d-09d7-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:01:41 +0200 (CEST) Received: from [10.10.1.138] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1658505688401753.8926392556864; Fri, 22 Jul 2022 09:01:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9178496d-09d7-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1658505690; cv=none; d=zohomail.com; s=zohoarc; b=Cm1knlTpxvwD9nyLIZ6OmDmvdSbz7fJZgectueq1HNvAXuWd5LFCOpGuMVjS3ghJGRhHchKR+86Sfw5qf5YPCQ66uSXcmPDAVe7KZfXfEX6c56htoILRoaWbgSs+eb4QXcSDF/8N9zHqW8yuvfMppx0NSrQLgZgncpIV8X8d5+U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658505690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=OAXmiiKbq7UJHEAdgQrye9BMYL7fkx6s7TFjFyt1RCc=; b=YlvjywEQZmJIoS0cGHiWcXFgyxAR7ntqi0hiKqg/PkvY/KDG/df8vGmkZHPjx+zMHR4uhSadiX8baJU4iHWF3EmvixsZVQ1hBECpT2p+G6LJ5+ygXo0uAqfV6Cp9gt4zI9mDvDLeCqyIPt9aZty+YzFLw6EAhVAMsbpl/3ldDFg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658505690; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:To:To:Cc:Cc:References:From:From:Subject:Subject:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=OAXmiiKbq7UJHEAdgQrye9BMYL7fkx6s7TFjFyt1RCc=; b=j54O6yJppFJw5tlGD5z9zFL+NTWlFgZrijhg7Gmh+qT1gej42HVhp44geCx/yo9l WTLNJzXWPYPz4m7UYJqVUV3pe4OUTuy8geUrfMXZk2XpdFRoQzMiNnTnrWBgvdD3tz1 AVqiPbVh+2eqUssdhnnpBlLOsZclOpioH269RgYQ= Message-ID: Date: Fri, 22 Jul 2022 12:01:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Jan Beulich Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> From: "Daniel P. Smith" Subject: Re: [PATCH v1 02/18] introduction of generalized boot info In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/21/22 12:00, Jan Beulich wrote: > On 21.07.2022 16:28, Daniel P. Smith wrote: >> On 7/19/22 09:11, Jan Beulich wrote: >>> On 06.07.2022 23:04, Daniel P. Smith wrote: >>>> --- /dev/null >>>> +++ b/xen/arch/x86/include/asm/bootinfo.h >>>> @@ -0,0 +1,48 @@ >>>> +#ifndef __ARCH_X86_BOOTINFO_H__ >>>> +#define __ARCH_X86_BOOTINFO_H__ >>>> + >>>> +/* unused for x86 */ >>>> +struct arch_bootstring { }; >>>> + >>>> +struct __packed arch_bootmodule { >>>> +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 >>> >>> Such macro expansions need parenthesizing. >> >> Ack. >> >>>> + uint32_t flags; >>>> + uint32_t headroom; >>>> +}; >>> >>> Since you're not following any external spec, on top of what Julien >>> said about the __packed attribute I'd also like to point out that >>> in many cases here there's no need to use fixed-width types. >> >> Oh, I forgot to mention that in the reply to Julien. Yes, the __packed >> is needed to correctly cross the 32bit to 64bit bridge from the x86 >> bootstrap in patch 4. > > I'm afraid I don't follow you here. I did briefly look at patch 4 (but > that really also falls in the "wants to be split" category), but I > can't see why a purely internally used struct may need packing. I'd > appreciate if you could expand on that. Originally, patch 3 and patch 4 were a single patch, and obviously was way too large. To split them, I realized I could introduce a temporary conversion function that would allow the patch to be split into a post start_xen() patch (patch 3) and a pre start_xen() patch, (patch 4). For x86, pre start_xen() consists of 3 different entry points. These being the classic/traditional/old multiboot1/2 entry, EFI entry, and PVH entry (aka Xen Guest). The latter two are all internal, 64bit, but the former is located in arch/x86/boot and is compiled as 32bit. I tried different approaches to support using a single header between these two environments. Ultimately, IMHO, the cleanest approach is what is introduced in patch 4 as it enabled the use of Xen types in the structures and maintain a single structure that need to be passed around. To do this, a 32bit specific version of the structures were defined in arch/x86/boot/boot_info32.h that is populated under 32bit mode, then they can be fixed up after getting into start_xen() and in 64bit code. To ensure no unexpected insertion of padding, I focused on ensuring everything was 32bit aligned and packed. As Julien pointed out, I messed up with the use of enum as its size is not guaranteed as the enum list grows and I forgot to consider keeping pointers 64bit aligned. Does that help? >>>> +struct __packed arch_boot_info { >>>> + uint32_t flags; >>>> +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 >>>> +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 >>>> +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 >>>> +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 >>>> +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 >>>> +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 >>>> +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 >>>> +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 >>>> +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 >>>> +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 >>>> +#define BOOTINFO_FLAG_X86_APM 1U << 10 >>>> + >>>> + bool xen_guest; >>> >>> As the example of this, with just the header files being introduced >>> here it is not really possible to figure what these fields are to >>> be used for and hence whether they're legitimately represented here. >> >> I can add a comment to clarify these are a mirror of the multiboot >> flags. These were mirrored to allow the multiboot flags to be direct >> copied and eased the replacement locations where an mb flag is checked. > > Multiboot flags? The context here is the "xen_guest" field. Apologies, I thought you were referring to all the fields and I forgot to explain xen_guest. So to clarify, flags is to carry the MB flags passed up from the MB entry point and xen_guest is meant to carry the xen_guest bool passed up from the PVH/Xen Guest entry point. v/r, dps From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:32:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:32:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373344.605493 (Exim 4.92) (envelope-from ) id 1oEvZD-0003H3-QU; Fri, 22 Jul 2022 16:31:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373344.605493; Fri, 22 Jul 2022 16:31:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvZD-0003Gw-NJ; Fri, 22 Jul 2022 16:31:55 +0000 Received: by outflank-mailman (input) for mailman id 373344; Fri, 22 Jul 2022 16:31:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvZC-0003Gq-Gv for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:31:54 +0000 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [2a00:1450:4864:20::42b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cb0c3ed2-09db-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 18:31:52 +0200 (CEST) Received: by mail-wr1-x42b.google.com with SMTP id h9so7260427wrm.0 for ; Fri, 22 Jul 2022 09:31:53 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id y7-20020adfe6c7000000b0021e4f595590sm5103809wrm.28.2022.07.22.09.31.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:31:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cb0c3ed2-09db-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+Hju2upPsuaUMXu0Y7f4daw3tGQKzInvRhbWU/D3Jt0=; b=XmOsBGowtYcYScTl5DG3Q1Pz/OuOw+nlEbfk6WFvQEa7wZIHHeEghH/K6AVd6QIRbt wkSIhXTLDOYEbzhOW1qzIoLq/8KWEtDZDqtkQyyuu4zfmco71nPpDAmnuxa0K7mu5Bum wyRfpKCzwrsmSPzUtr1pFTgq4q+ERdmkcFq3NizhV5IlCniv1bbuH7MaelogQ+s3VPb4 U4qg5svBHucz9DlsySoqM1hvwcaX6epM+0/mCHHP64y5my1kqFo2SVJLbjYDTXToFzAF u8r6Hb0dCfhDWGpGa+hOTpGzG49aBHJAvXlSTmQUo2KHA5Rnp3DnIwZN5l4d6yNISLMQ rQxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+Hju2upPsuaUMXu0Y7f4daw3tGQKzInvRhbWU/D3Jt0=; b=eC8vizE33105Og2HYhkqPpxSZycPAvhfQXobZNTSvmcIPzcp6Fe5ZbhzGuWjLaDGBi 8gein5W9eHr339/cwC7AzWJaupbNQPvcaJ0hQsE2srWgj+7dHDWkxxQIve3KAoKnYopw F1z/ht6nYA2MZR6rrdYwpBc3NVxGed2dy8knXFLZD8N4uyHAHQ12ONPq4sAxwpxeR118 RG9fInbeuLkDsDecLtPnMj59M/SVHx/DsMMLjTQr9D0q3lVVx/HX8h5zKia3RyUYHO4J nbr1rvu83ViImv1s3lruQwiW5+H236ABooO5n3encUfPvIvFlB2vhY+7uEKGBWnExOH+ hPIQ== X-Gm-Message-State: AJIora9kof9xUm4yDI78hE+/5VoDG315wsfZn7JXSB5cZIAf0/bNX+kq PJk8JCnPvW2/PJVe4zo+vto= X-Google-Smtp-Source: AGRyM1t4KYFr8FDqqVdNfkH0UqepHKS9F2xz7PIVNIKMvrUHfW7v8dcyDxJ+6Z/kdY5qqqYYmkmK9A== X-Received: by 2002:adf:fecd:0:b0:21e:61cd:713d with SMTP id q13-20020adffecd000000b0021e61cd713dmr472228wrs.668.1658507512675; Fri, 22 Jul 2022 09:31:52 -0700 (PDT) Message-ID: <934251cb-70e7-264b-d79e-618f55f2760e@gmail.com> Date: Fri, 22 Jul 2022 17:31:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 01/14] iommu: add preemption support to iommu_{un,}map() Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <3b3e1a15-f358-3095-87fc-c47843eff94a@suse.com> From: "Durrant, Paul" In-Reply-To: <3b3e1a15-f358-3095-87fc-c47843eff94a@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:43, Jan Beulich wrote: > From: Roger Pau Monné > > The loop in iommu_{,un}map() can be arbitrary large, and as such it > needs to handle preemption. Introduce a new flag that signals whether > the function should do preemption checks, returning the number of pages > that have been processed in case a need for preemption was actually > found. > > Note that the cleanup done in iommu_map() can now be incomplete if > preemption has happened, and hence callers would need to take care of > unmapping the whole range (ie: ranges already mapped by previously > preempted calls). So far none of the callers care about having those > ranges unmapped, so error handling in arch_iommu_hwdom_init() can be > kept as-is. > > Note that iommu_legacy_{un,}map() are left without preemption handling: > callers of those interfaces aren't going to modified to pass bigger > chunks, and hence the functions won't be modified as they are legacy and > uses should be replaced with iommu_{un,}map() instead if preemption is > required. > > Signed-off-by: Roger Pau Monné > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:36:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:36:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373351.605504 (Exim 4.92) (envelope-from ) id 1oEvdq-0004BM-E8; Fri, 22 Jul 2022 16:36:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373351.605504; Fri, 22 Jul 2022 16:36:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvdq-0004BF-AG; Fri, 22 Jul 2022 16:36:42 +0000 Received: by outflank-mailman (input) for mailman id 373351; Fri, 22 Jul 2022 16:36:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvdo-0004B9-Tj for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:36:40 +0000 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [2a00:1450:4864:20::431]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75bd2908-09dc-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 18:36:39 +0200 (CEST) Received: by mail-wr1-x431.google.com with SMTP id bu1so7217549wrb.9 for ; Fri, 22 Jul 2022 09:36:39 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id l4-20020a05600012c400b0021e4829d359sm4999224wrx.39.2022.07.22.09.36.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:36:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75bd2908-09dc-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1/GIfOsmvCDNYzoGrWM27SqOzkUgoHSo67253yQixbM=; b=U0G+1rJ18wtbbUtZ8gkcUS+t7Cdjj4AMGJbDbABVknPvwpRK1F8YBuASd/n7c/2ljw S8OO0B/UmHodet1uod+/gTvBnsO+kcrF7BPIbmspXVY/j3/jCv4+/vCp8OziqlrJF9qT tRVs0T0qqny6NUhEf1SFkKypvH3EnZXFyXZvppYNuEmiEs7gOyEtuZyN+gyTARYcHerm uX+wAjY2zB1tTjC7gBbuZFa73Ehu1/TMGVGfGq0q2Nx5fqbYSQlwKDx8N7OJhXwCvHP4 RC5gOXBkERPZL5SGUjPYSOIpJqCuURqsLSXaYSp9HqerQh0ND6hMYL3qQl02XNWbYjGz P3xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1/GIfOsmvCDNYzoGrWM27SqOzkUgoHSo67253yQixbM=; b=sYcz4MmqtGFjTx4YysS3EXMQZ0w4ixrGqFn+VgcD6vFUSvZSaNSKrPPqHoE3oQSsO3 bhACc/d9gLXRVVHI+8EqOhdM5gONpVx65TtYJydT4In8ZO3rY+4P62iUMMMcxCdJBXS9 t++El9hS0AHrIvjvky8t7Z12C2UxTIGhHeL2UzDUQOJ+ohuScHuC3YuvamKXchT5RaE5 RDwpMJG1h6MwoS7/znFdG8xS7j6Wbgbp9j39UE8J3uosBCJzcpJDgAM3KWGy8WQGJON7 8h8IE28W5Go7EsWyVIGzcOY4JyxbnmVkVQfeRB63p6PMVC1BCt58pD0UnX7oWtkVcVkP DZOQ== X-Gm-Message-State: AJIora8OQErTICneXzJzWMCxz2YtcxYRXXoD4efnoQ3MukExRJxk2Qmr 8g2jG39yHBZ7AKcOUBkgjzw= X-Google-Smtp-Source: AGRyM1tGyI8GcBZgrLrUq7b+FTc1OoBrmfq5SaIUp6dPXYg8afuo56R7z9blGkuczpCFGD+BiXyyDg== X-Received: by 2002:a05:6000:1888:b0:21d:beeb:7873 with SMTP id a8-20020a056000188800b0021dbeeb7873mr492082wri.393.1658507799249; Fri, 22 Jul 2022 09:36:39 -0700 (PDT) Message-ID: <23730379-9a06-00a5-1ea1-6ffe880814a7@gmail.com> Date: Fri, 22 Jul 2022 17:36:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 02/14] IOMMU/x86: perform PV Dom0 mappings in batches Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <1adca369-c911-e126-6b94-b26859a01e5f@suse.com> From: "Durrant, Paul" In-Reply-To: <1adca369-c911-e126-6b94-b26859a01e5f@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/07/2022 13:44, Jan Beulich wrote: > For large page mappings to be easily usable (i.e. in particular without > un-shattering of smaller page mappings) and for mapping operations to > then also be more efficient, pass batches of Dom0 memory to iommu_map(). > In dom0_construct_pv() and its helpers (covering strict mode) this > additionally requires establishing the type of those pages (albeit with > zero type references). > > The earlier establishing of PGT_writable_page | PGT_validated requires > the existing places where this gets done (through get_page_and_type()) > to be updated: For pages which actually have a mapping, the type > refcount needs to be 1. > > There is actually a related bug that gets fixed here as a side effect: > Typically the last L1 table would get marked as such only after > get_page_and_type(..., PGT_writable_page). While this is fine as far as > refcounting goes, the page did remain mapped in the IOMMU in this case > (when "iommu=dom0-strict"). > > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:44:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:44:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373357.605514 (Exim 4.92) (envelope-from ) id 1oEvl1-0005fs-8J; Fri, 22 Jul 2022 16:44:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373357.605514; Fri, 22 Jul 2022 16:44:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvl1-0005fl-5R; Fri, 22 Jul 2022 16:44:07 +0000 Received: by outflank-mailman (input) for mailman id 373357; Fri, 22 Jul 2022 16:44:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvl0-0005ff-8q for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:44:06 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7f95f2cb-09dd-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:44:05 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id a11so3112726wmq.3 for ; Fri, 22 Jul 2022 09:44:05 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id a8-20020adffb88000000b0021d73772c87sm4952685wrr.91.2022.07.22.09.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:44:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7f95f2cb-09dd-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bacCLMc4VWJre6VMJNeYyywDzMMICUIKY0BopfXJL/g=; b=n8GBgITjggnfs63julnZosM8FE71aIW5n4QMu4XGioXAj2hYhaQ6lYb9gZQHpxtqZD +Das/ixn3op8aWW6tUhLK19oelRrCr8ehBpy/Bmr0JdXc/6BMQs/JfVI7ZTgkYpQHoMN M3yl9056xjIABHPVcz6B91YUY77KubHfSwrTN7xPgBRCTJoiP7TZtP/V3gJi9eJydqcB WSdL/oHu2dZMflEYej4qYrvKAhDL4iUKrtioC8yWao4GszaSAyuYtPYmP87X6aihao8i w3iZiq2petX29koWUk1fz7o3nDW2V6DmWRCNpugndzS/gZb88PsH3fEUT++ItfcGFX2E CarA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bacCLMc4VWJre6VMJNeYyywDzMMICUIKY0BopfXJL/g=; b=kM2/twAijjsy91CqLv0JluRvESfuwZoCb5U75QRDB9g9KwGN7lddihFtWrv+XTNjTc hCKRry/IlSCRxg+dJrRg03DtIRlt7YVQtVtvUi3jddJQtApCQvN64bBUHntabR+T6oni p0+5e1qF2xUgzVPtJU2tEB2NgROp2CHLDSvL49D5MTEh/yvGNCiqBLLmITmrKH71Paxh SORCUxGJsIi4uLKi7VV6RR5pL7lpYA3ynQYtIp4guEnttgrOaew1n0+4aoF/KT+cqNS3 DqPZmpSlSoRziJj2gy+G9y09I3IptUn7r/ZiCiXg+YPlIP0TMDSwUL8s2cx47WErgZQu zt4g== X-Gm-Message-State: AJIora+Wx7c4GcMHspOMBHcZ2Lp2q93w0Dyq4zyoqhrgMUs3weVNw4A2 R39n0Pk7BWYfaOyQknkQHa8= X-Google-Smtp-Source: AGRyM1s28IVfG4MxuBpbB43kD9I83fuihu5ZcbAPx3avdQGga6xcw1KwH7p0PqPKC7tQ9coUv7FSeA== X-Received: by 2002:a05:600c:1f13:b0:3a3:3f0d:d9d4 with SMTP id bd19-20020a05600c1f1300b003a33f0dd9d4mr3394103wmb.4.1658508244855; Fri, 22 Jul 2022 09:44:04 -0700 (PDT) Message-ID: <748d17d4-fa19-fc16-c503-7d0ae1f37e7f@gmail.com> Date: Fri, 22 Jul 2022 17:44:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 03/14] IOMMU/x86: support freeing of pagetables Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:44, Jan Beulich wrote: > For vendor specific code to support superpages we need to be able to > deal with a superpage mapping replacing an intermediate page table (or > hierarchy thereof). Consequently an iommu_alloc_pgtable() counterpart is > needed to free individual page tables while a domain is still alive. > Since the freeing needs to be deferred until after a suitable IOTLB > flush was performed, released page tables get queued for processing by a > tasklet. > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:46:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:46:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373362.605526 (Exim 4.92) (envelope-from ) id 1oEvmv-0006H5-LD; Fri, 22 Jul 2022 16:46:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373362.605526; Fri, 22 Jul 2022 16:46:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvmv-0006Gy-Hq; Fri, 22 Jul 2022 16:46:05 +0000 Received: by outflank-mailman (input) for mailman id 373362; Fri, 22 Jul 2022 16:46:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvmu-0006Gs-Pt for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:46:04 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c64a0319-09dd-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:46:04 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id h206-20020a1c21d7000000b003a2fa488efdso2956984wmh.4 for ; Fri, 22 Jul 2022 09:46:03 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id k22-20020a5d5256000000b0021e2fccea97sm5190509wrc.64.2022.07.22.09.46.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:46:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c64a0319-09dd-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4QDc6LB7WD6UjcOQO3uE4zZfyNkWEGaSGSScriALPlk=; b=bljsnDCAgXPpnNugMC/7l9VySSwvdcAfTzOK58EZTvWjmLvB0VSzFMa39U1zm3UmPz i1guJjOKQZXPl5uMN5Rf9ZUUCvywJJ2Zbes0Y4DQokQcq38hw0upAkFyWe6OYXRIQe00 73mYIX4bUTQCwVM7VKq0aRZND3gRi3u0a07VW+KfKP1bCH6ahRGc8Nx+vNrwaBhNzmxs jL26xJOnJCA0zNNRU68uOjnJj0p7LfjTzVq2F47S6UNwXsTIXE4FDhvCmAPxpNj0Yl6x TiX8lGWO4jlBd/fN6aWPbbIE1akhtA14YmqEGALlO1GSnebdvFFedgr9JL6ihLyyq4xh iUXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=4QDc6LB7WD6UjcOQO3uE4zZfyNkWEGaSGSScriALPlk=; b=7X8GdyUjZmdty0z4fwe7AgDWF4gdkM+1uNrxDlD+xPF9r2BiuHt9XmTgpVOAPYk+pJ j3WH60ARyT9GzUTgiAJRKIg7MdU1RP/sfda3tFYBNXCj80x6IlhGQ4FOQf6BsuSK3BKL 7cL72tfiiCkBu4jEHWB598n895Bt7lRZ0G7ObiGLAh6cuypJmbXcjioNmwwilM07YZIA c5JC3rbUbmoKRXkZXipD0W/G9W+r4LbtHl2j0DYLfkIQ5hGczzva+C6uXB2ArTvIAYl1 i8z+jgbrgtmzTjKz8gotGTEruEn3lu133CUPbMUtUoEj00VICgL3SeYk8cRYKegTpUcR RjPg== X-Gm-Message-State: AJIora8yS/7jyFYwkGQ+H4MXR2SreQAv9iHh33FDhukwO+/R5JHUtn05 iGYhVDSOQ95pQOCZeYQTJE4= X-Google-Smtp-Source: AGRyM1uoLq4T/BOu9lZ6KnZRpHeL8WT3PoelJf0Xwac46MWXuMvdIqEHS+4DuGkfA74JpOqlHbghXg== X-Received: by 2002:a05:600c:591:b0:3a3:205f:e2ca with SMTP id o17-20020a05600c059100b003a3205fe2camr409346wmd.147.1658508363466; Fri, 22 Jul 2022 09:46:03 -0700 (PDT) Message-ID: <077f367b-b9fb-0711-fdea-00250cd96a19@gmail.com> Date: Fri, 22 Jul 2022 17:46:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 04/14] IOMMU/x86: new command line option to suppress use of superpage mappings Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <7e587d78-43bf-70e5-b629-b7fbed0ae0fc@suse.com> From: "Durrant, Paul" In-Reply-To: <7e587d78-43bf-70e5-b629-b7fbed0ae0fc@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:45, Jan Beulich wrote: > Before actually enabling their use, provide a means to suppress it in > case of problems. Note that using the option can also affect the sharing > of page tables in the VT-d / EPT combination: If EPT would use large > page mappings but the option is in effect, page table sharing would be > suppressed (to properly fulfill the admin request). > > Requested-by: Roger Pau Monné > Signed-off-by: Jan Beulich Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:48:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:48:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373368.605536 (Exim 4.92) (envelope-from ) id 1oEvpL-000795-2S; Fri, 22 Jul 2022 16:48:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373368.605536; Fri, 22 Jul 2022 16:48:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvpK-00078y-WA; Fri, 22 Jul 2022 16:48:34 +0000 Received: by outflank-mailman (input) for mailman id 373368; Fri, 22 Jul 2022 16:48:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvpJ-00078s-Do for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:48:33 +0000 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [2a00:1450:4864:20::32a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1ed443f1-09de-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:48:32 +0200 (CEST) Received: by mail-wm1-x32a.google.com with SMTP id r1-20020a05600c35c100b003a326685e7cso4840910wmq.1 for ; Fri, 22 Jul 2022 09:48:32 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id m39-20020a05600c3b2700b003a2e1883a27sm12428818wms.18.2022.07.22.09.48.30 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:48:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1ed443f1-09de-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7QhYqcqhb3JRPzK1WchfWG6GW+FTDQHvg0lGPxPhVMU=; b=PeYJe5CldcZaQw5zqx95/CLyqb1bQyZaG40o40NxI89FDfO9qG1zhX8ujr0OIJyZHQ QzsOXnIcq+vNBc6FFA7mfC93nAgcmMLY5q3NKXmSOzvFN2i/wN+uVhQC2aB7qCuxgwrC Uj4RlFIHzAAHpiZk7nXwC7/AymS8JGjKAJEQpwabDFGasGOYGPQznxteCOOXffN7bmem LVmKdqb0CWiGbQFvQ4vbB4iqkLm1BfTI1rbkp31ULo6W6x4NCmDuHgnHuPoIrnZj3xg5 Juv8L20sm0rh9vz/j2WUQxSYDDYHfk/GxKzZ4rwkdGiCgOMy4wdiUxwTqQStnCVgmoOx hu0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=7QhYqcqhb3JRPzK1WchfWG6GW+FTDQHvg0lGPxPhVMU=; b=z/dn5Nu+4wn4R01+Uv2FHRB3ph/Eqm8yHVDNxPJBuI6/KECwmEkzCJID+eIRmPVjRD 8uYrVVMLSKUBgdpNR5XPDDO5/GvejomfPfgabZut5u/m7+Uj4coBc0LwlVj5iLOoF23r YLmo2I5y8cRTJHljfhjvwNoBu0ib5fZnTEHl4q7jsH5qnxhxcXV2XxKuI4GLoIilxtm7 KLHO6wcknA5a25HUaWShR6Q5gpBwH4vDylSyNA+fyDPhk5rWwSWwUvbWyVdsT2o3S8qX rLxtWhX4KH7jvm7dSwlfdxrteFj17zcdKYbTtFvzj+/BpVSd0pi55ul9QHMsFZa4NkXn dYsg== X-Gm-Message-State: AJIora9h8lF6c3BYTmSRv0q1LCxfjmx0EZarDMCDpiE4RdaDhCHUOZ2l 8tYSENiJjWGihKSzNP54J1vTuGOfdcmiuQ== X-Google-Smtp-Source: AGRyM1v9ySo7/thzvGGCvf6v4P5b7LMpRF2wIyI7Hae3pIdxkfACaV4DPTJRvsifxMd2/ToM18FpuA== X-Received: by 2002:a05:600c:1e8a:b0:3a3:20fc:a651 with SMTP id be10-20020a05600c1e8a00b003a320fca651mr439767wmb.39.1658508511952; Fri, 22 Jul 2022 09:48:31 -0700 (PDT) Message-ID: <4538079b-8aa0-df72-0b1a-9382887aa9c9@gmail.com> Date: Fri, 22 Jul 2022 17:48:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 05/14] AMD/IOMMU: allow use of superpage mappings Content-Language: en-US To: xen-devel@lists.xenproject.org References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:45, Jan Beulich wrote: > No separate feature flags exist which would control availability of > these; the only restriction is HATS (establishing the maximum number of > page table levels in general), and even that has a lower bound of 4. > Thus we can unconditionally announce 2M and 1G mappings. (Via non- > default page sizes the implementation in principle permits arbitrary > size mappings, but these require multiple identical leaf PTEs to be > written, which isn't all that different from having to write multiple > consecutive PTEs with increasing frame numbers. IMO that's therefore > beneficial only on hardware where suitable TLBs exist; I'm unaware of > such hardware.) > > Note that in principle 512G and 256T mappings could also be supported > right away, but the freeing of page tables (to be introduced in > subsequent patches) when replacing a sufficiently populated tree with a > single huge page would need suitable preemption, which will require > extra work. > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:51:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:51:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373375.605548 (Exim 4.92) (envelope-from ) id 1oEvsN-00006M-Gv; Fri, 22 Jul 2022 16:51:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373375.605548; Fri, 22 Jul 2022 16:51:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvsN-00006F-E4; Fri, 22 Jul 2022 16:51:43 +0000 Received: by outflank-mailman (input) for mailman id 373375; Fri, 22 Jul 2022 16:51:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvsM-000069-23 for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:51:42 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f4871fc-09de-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:51:41 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id c22so3133379wmr.2 for ; Fri, 22 Jul 2022 09:51:41 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id u18-20020a5d4352000000b0021e297d6850sm4797562wrr.110.2022.07.22.09.51.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:51:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f4871fc-09de-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LoqjoC9DXCi8ELLSQyxZ3VbyPqP+95OVLKZHKaBD+DM=; b=bDFcTRbS24frylBzidaFLX8xxbzBzeRRs4q8cq2FAMETbqh//lM0zJ7GJsf70m4Zna 2SPZkFyNzwYSafJC7aE8px5pKS+nszEwPpYhs8vP8EPS+y7pP/YxuYl2qZBpDbzRTxTB VezvYnxCoZqd+ZWHOP4duQgAD3WnQrxTwE4RQFKw1gLzkkop2zYcjBpKJVGNHMjNDDml sPX1yzx80dd944YqHHOPmCtReg7ECsLpqtNGBDP68+tzUtexsOf1KDnv6oCXqu+r34Jt Hu9+sHgJ1Wy3ou+0MqX7fAtxDV4OHTATsnIKewIpPZ0r4etxqvF90/lABbXPqOqw9LER +aow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=LoqjoC9DXCi8ELLSQyxZ3VbyPqP+95OVLKZHKaBD+DM=; b=vs62eGc2PjLVvOv5FDteJY2EVorc35nEJqJt+SRliOAvoqtpDaqXJrA/by1Noeawsm JbUDaj8qklB9BorNXUSL+X74X2x/kGY56XynuGBeJHu/TuksJDkHIZvvXkKUpqDxI0uk dQPhOevZMjQPH21niQe3W9Alxg/SatmlNzuH/SQZV1zM59ZcaxeX88qhQ8zO/+cSWBB2 UPhsbCJVCUpgJkeMQES90W4aykJd7NC7J3ZAgFnSEMdJ7qt9q3cKxjTlIxxD48wFxbI2 SI71gDiORRCjO2vxQ3dOq2BKCD4JVYr3OPwIlJp/6gYeRqE0lw/VsiK2HWZXolPckV0s qCCw== X-Gm-Message-State: AJIora/rAmmyfWXP/tSS5Lmoc5meQuoKQYSxjHqAUyWFfPBB+0MXe+bC 7btR1ciS/7kQoiYHpYXE+v4Vqan2ycjjfg== X-Google-Smtp-Source: AGRyM1uF705CZIM9R/I7eKfx64bvf8vApg3yt7R0XUVI1vrCJMJSbxqcck8hPrXAtQd7IzNgVwEL6w== X-Received: by 2002:a1c:5452:0:b0:3a3:2b9:6cfe with SMTP id p18-20020a1c5452000000b003a302b96cfemr470175wmi.112.1658508700555; Fri, 22 Jul 2022 09:51:40 -0700 (PDT) Message-ID: <473cb9d3-dfd0-96fd-47c6-3dcd3e7b6f74@gmail.com> Date: Fri, 22 Jul 2022 17:51:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 06/14] VT-d: allow use of superpage mappings Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <629e7e8a-b846-14cd-08eb-75433c8c3369@suse.com> From: "Durrant, Paul" In-Reply-To: <629e7e8a-b846-14cd-08eb-75433c8c3369@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:46, Jan Beulich wrote: > ... depending on feature availability (and absence of quirks). > > Also make the page table dumping function aware of superpages. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:54:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:54:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373380.605559 (Exim 4.92) (envelope-from ) id 1oEvvG-0000iY-UJ; Fri, 22 Jul 2022 16:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373380.605559; Fri, 22 Jul 2022 16:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvvG-0000iR-R7; Fri, 22 Jul 2022 16:54:42 +0000 Received: by outflank-mailman (input) for mailman id 373380; Fri, 22 Jul 2022 16:54:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvvF-0000iE-AU for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:54:41 +0000 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [2a00:1450:4864:20::436]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f9e509db-09de-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 18:54:40 +0200 (CEST) Received: by mail-wr1-x436.google.com with SMTP id d16so7283300wrv.10 for ; Fri, 22 Jul 2022 09:54:40 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id f18-20020a7bc8d2000000b003a327b98c0asm5372518wml.22.2022.07.22.09.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:54:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9e509db-09de-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7oJJgHVcmYFn8MF2+FvbVxvhYZdqbXU2SoUn7GdHc8U=; b=fMco9Vj4Cu/pFo1pFkHcTb91YtrqkRPQfICExE1Ukwbzsk3oL8hgoiWvoBd1nJaIcw lQ/Cfva64vOE4CPR3fdNLYeITrcQibvHLNnnViyeb4769XQHU3/YnGW9JutDGvKkGWZl tctE8lZG7/hApv8ecQ9g5f4EAPK8FroRadV+JFkB+d1vcDi/7nIU8HoIZ8oKo9yFVjoC sl+LuKCvniW1zMrMxxvyt9DzHjU0zEWdtzi0XHjifwkEOdLABFwXV2TMm3b3k3xD5u0m 6p8Vnw7x6GHscOEHaU3ceehDbfMNGMBdTdaZDuvVRr3CmUrHziJtvLzUJdD/vMndD3K+ EnNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7oJJgHVcmYFn8MF2+FvbVxvhYZdqbXU2SoUn7GdHc8U=; b=hY4zUyi7r0jMT8c2Atom7L67L80kiLzfXG016USQb8dgsPJeKfViJ23ybdnZNsUbAA jaDqjr0KwkmOYUoiLS2ESbrLihnbf5E1bnQcY6/EcQQFsFZht91nGRyEjdWyvKtdIuzo adNjxIEJeuKSQDQFOtJkQK9KL2kxdhGEF7W8Mf2sqMEtklNkdx3QA+uaTV5PG2NsJCv7 pk/xAs46nkVWXLl7H7b84GywvpvV8K68cbcPcHHdHKuTIt8m5LMIInwbjs+PKUe3C05T 8ZSWf8+4xgqCTvTddC/yRGCC1WYvFiDCCszrmFIVNaDWczwnlwYXbbxrVamDf+uFXn1D Wr2Q== X-Gm-Message-State: AJIora/NMIgAhGNGLC2V2TCVQ6+KOfd651X1Y1Onn2O1BI2/ROKtl9ME Zixf2qJK7EELE8SxwvildHA= X-Google-Smtp-Source: AGRyM1sWVPPqX0lhQet60L0j9W22O4EQrD0Q7+fx9xhtSnU9lPEstJfuYtYtd49TacM4pXzRt2NA9g== X-Received: by 2002:adf:dc01:0:b0:21e:28ea:5d41 with SMTP id t1-20020adfdc01000000b0021e28ea5d41mr562938wri.440.1658508879764; Fri, 22 Jul 2022 09:54:39 -0700 (PDT) Message-ID: <349cf7c2-6426-9a42-02c8-185aa02e272b@gmail.com> Date: Fri, 22 Jul 2022 17:54:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 07/14] x86: introduce helper for recording degree of contiguity in page tables Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <1ff53db0-088e-ec08-b757-b03639c09432@suse.com> From: "Durrant, Paul" In-Reply-To: <1ff53db0-088e-ec08-b757-b03639c09432@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:47, Jan Beulich wrote: > This is a re-usable helper (kind of a template) which gets introduced > without users so that the individual subsequent patches introducing such > users can get committed independently of one another. > > See the comment at the top of the new file. To demonstrate the effect, > if a page table had just 16 entries, this would be the set of markers > for a page table with fully contiguous mappings: > > index 0 1 2 3 4 5 6 7 8 9 A B C D E F > marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 > > "Contiguous" here means not only present entries with successively > increasing MFNs, each one suitably aligned for its slot, but also a > respective number of all non-present entries. > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:56:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:56:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373386.605570 (Exim 4.92) (envelope-from ) id 1oEvwh-0001K0-7x; Fri, 22 Jul 2022 16:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373386.605570; Fri, 22 Jul 2022 16:56:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvwh-0001Jt-4b; Fri, 22 Jul 2022 16:56:11 +0000 Received: by outflank-mailman (input) for mailman id 373386; Fri, 22 Jul 2022 16:56:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvwf-0001Jh-5S for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:56:09 +0000 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [2a00:1450:4864:20::32c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2e7ead1f-09df-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 18:56:08 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id r1-20020a05600c35c100b003a326685e7cso4849882wmq.1 for ; Fri, 22 Jul 2022 09:56:08 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id i13-20020adff30d000000b0021e4982270asm5185332wro.13.2022.07.22.09.56.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:56:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2e7ead1f-09df-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BdOvOOxFrgEHoNBKjWoXTbrloJ36jxHuqfmbhuME3AI=; b=XELhvY596K6qD2u0lLw5dJNtROs0P1h59YJzQ5TPT6XhtOUdRdW9DLT1C18KMlGFxE IB0ttJdTvkjUSSGIevsN/DGglNckXLMxCRlKwJBcQI+AQq4ke6u3xsgZNdro1LFR4APA n5Nz4jJn+20VaXBsBquxEbJQWJdf2IyT6tlIBwbnfbSudIzi+zIlJMk2ek+tKYEwUhfP mBx3J7cIGuEe3x3TNQvodZwJcbbDUC5vWnmcvdFrSHUNnRRMUSzYYHtuBttOwyi8Rz5e 2njX0Y15O8TmlLo0J7HY01X11WWanBo06iKektVSz46+EICi8ipKtFdC0tSI2mvqlAcq izHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BdOvOOxFrgEHoNBKjWoXTbrloJ36jxHuqfmbhuME3AI=; b=Ow5Jy7MNnppM8Q+ovSABVX1Mivg89Vp+KgvK3nHpM6LvgRtjTzkhKuaC5oLYO6nayW a4/Smo10QTAXqXwO9O9MkdhaXSyMpgwSj9epLynwTD0CgFuiczliBPrI4Cc3Zd984z51 dw6bOldGDEPQr7MDUSTyJJmHUWnCrhSQqCZAOrkubIXfgPxdHftSRnkNe7boteDN+ziy L3goNFMj3i9OS8mtiIZt9gqXKI5QWKMjdMfxqQMe3phBo5OiSGw3aFNUyJIQhl71viaV mSJ5XaZ3AmblBMaVULnPwYCsq1U5eHrnkEBNYcrwG4A8Ns2S9SBvUvGHKGFd2WnXd9hg gCYA== X-Gm-Message-State: AJIora9y6DlERll/EmotxBnMdUTXwelS2UdHKxrk3KXjSRCH5SX/Uj2k rxQO+9yFCkpwQCaz7YTF8vI= X-Google-Smtp-Source: AGRyM1umb/9TLFU9W5ohexbMT2vfhk1EbrTzo9dlgILKcY2CpfBnazv8UgFCCoKIKoFQAyXZh8t2aw== X-Received: by 2002:a05:600c:1c83:b0:3a3:1f70:25a5 with SMTP id k3-20020a05600c1c8300b003a31f7025a5mr13118962wms.54.1658508967550; Fri, 22 Jul 2022 09:56:07 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 17:56:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 08/14] IOMMU/x86: prefill newly allocate page tables Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> From: "Durrant, Paul" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:47, Jan Beulich wrote: > Page tables are used for two purposes after allocation: They either > start out all empty, or they are filled to replace a superpage. > Subsequently, to replace all empty or fully contiguous page tables, > contiguous sub-regions will be recorded within individual page tables. > Install the initial set of markers immediately after allocation. Make > sure to retain these markers when further populating a page table in > preparation for it to replace a superpage. > > The markers are simply 4-bit fields holding the order value of > contiguous entries. To demonstrate this, if a page table had just 16 > entries, this would be the initial (fully contiguous) set of markers: > > index 0 1 2 3 4 5 6 7 8 9 A B C D E F > marker 4 0 1 0 2 0 1 0 3 0 1 0 2 0 1 0 > > "Contiguous" here means not only present entries with successively > increasing MFNs, each one suitably aligned for its slot, and identical > attributes, but also a respective number of all non-present (zero except > for the markers) entries. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 16:58:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 16:58:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373393.605581 (Exim 4.92) (envelope-from ) id 1oEvyX-0002Fg-Oj; Fri, 22 Jul 2022 16:58:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373393.605581; Fri, 22 Jul 2022 16:58:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvyX-0002FZ-Lb; Fri, 22 Jul 2022 16:58:05 +0000 Received: by outflank-mailman (input) for mailman id 373393; Fri, 22 Jul 2022 16:58:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEvyW-0002FT-Et for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 16:58:04 +0000 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [2a00:1450:4864:20::42a]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 72e243f7-09df-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 18:58:03 +0200 (CEST) Received: by mail-wr1-x42a.google.com with SMTP id bu1so7292449wrb.9 for ; Fri, 22 Jul 2022 09:58:03 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id j38-20020a05600c48a600b003a2f6367049sm5098110wmp.48.2022.07.22.09.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 09:58:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 72e243f7-09df-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vACh0L6pvmXIZw/x+RdnP68YD9pUSN3ZhhaRo9VbPZs=; b=mEKwJmL7mY+I23Hym0BPvLNPulC2HRHwSHocY7odvIDnGwp5lswEvsr4aq5OVk9s7n Jvda2DG9LXQqbAjfJXhQcWIvya4Jz+C3ZybKhczOn6XLQbG7jR2+SjZNQWMsi/xCJA79 8s/ZABzGFVyl5lzuT2BGurV1lRkum+k2YpqTzPp5Iiw/SemAWftxvCRkgFZ6gaF/YqqJ ObxOCLHuA+Q9byKYyll+o0byRQaTa3NXuSb9p6kRmubI1Jde5PrLsbxHM6XCnbwPHcAI qz+i4jnGPvbTsFmYto4SxTf9PKr93KRPMmPJNTk16JRgllVsD9VusChJXN/kvlj8uOaK nJug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vACh0L6pvmXIZw/x+RdnP68YD9pUSN3ZhhaRo9VbPZs=; b=eixP1n0Y73sQOLljRM/zCgtHEFLuNuM9mHUjIAivfGUcf2ZuOkR4PZYgWsesO+0Zpg gEHTslz8RjW70pIj2jGszebGTKyz9eIR4+CnFPJiexUUjB36PFIsC/cpYq0qTrBFlJ02 Z/fxQIb4cXFU242kgWoWJaarXMT+MeLMZchgXdaLvHnBHLiEpl2hAkrKxBeOP1PHyAU4 R5vosA5kOEk2Scg/lIqoOOdMoxkSNQHTdCcp2eRevIzxpmuUeHF4coy6m3RvesEfbM/F FrqTRjL5CTIQVTxiO+guQyEerRLaLaYIOE3VwAGknP2eBBGc4J0TWI5oBw2j2UFLf5P2 MReA== X-Gm-Message-State: AJIora9eRHF5XFnkrfwf152Sd+o/cyL6A7rGBb/mVAOTsDVjDCYlaP9e 7hYuPfbVBRGaPomigTdybP4= X-Google-Smtp-Source: AGRyM1tO4mq5fA2zvdxk7UkCnawvsPMRD9yS4jlEdxM4xk4Wg2JOCQryzwQ0sNj45/5RKLEP2isD+w== X-Received: by 2002:a5d:4304:0:b0:21e:3161:4aa2 with SMTP id h4-20020a5d4304000000b0021e31614aa2mr531730wrq.581.1658509082727; Fri, 22 Jul 2022 09:58:02 -0700 (PDT) Message-ID: <3ae54e6c-7e16-36fc-6b2b-afd2cad7e8f8@gmail.com> Date: Fri, 22 Jul 2022 17:58:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 09/14] AMD/IOMMU: free all-empty page tables Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <8b375834-5f36-c1d5-f13d-dc9bb7b53134@suse.com> From: "Durrant, Paul" In-Reply-To: <8b375834-5f36-c1d5-f13d-dc9bb7b53134@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:47, Jan Beulich wrote: > When a page table ends up with no present entries left, it can be > replaced by a non-present entry at the next higher level. The page table > itself can then be scheduled for freeing. > > Note that while its output isn't used there yet, > pt_update_contig_markers() right away needs to be called in all places > where entries get updated, not just the one where entries get cleared. > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:00:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:00:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373399.605592 (Exim 4.92) (envelope-from ) id 1oEw1H-0003h5-8P; Fri, 22 Jul 2022 17:00:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373399.605592; Fri, 22 Jul 2022 17:00:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw1H-0003gy-4M; Fri, 22 Jul 2022 17:00:55 +0000 Received: by outflank-mailman (input) for mailman id 373399; Fri, 22 Jul 2022 17:00:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw1F-0003go-Fa for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 17:00:53 +0000 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [2a00:1450:4864:20::336]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d7b66267-09df-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 19:00:52 +0200 (CEST) Received: by mail-wm1-x336.google.com with SMTP id h206-20020a1c21d7000000b003a2fa488efdso2979615wmh.4 for ; Fri, 22 Jul 2022 10:00:52 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id h13-20020a5d548d000000b0021d8b1656dfsm5000160wrv.93.2022.07.22.10.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:00:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d7b66267-09df-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ybomNOJkP9mYTlFH/CeNcETmX8OuO8axxo3LlgQXCSs=; b=LnHSpk0wlCrHGbs/3CB706PvBjgqWdASaC96xsMyjrnq0QwZL5pEiy/iy+cX5I78rm KE0fTOT11fUxGLZZK5GC/vUGJ+WUKo/tYkc5Mv5O8hKLysDZ0XohhQAg1UTVg4fcgGLy 7WSv/SZoutpmg8Q1waV6V5i7kvilOGwFU8AWoKJs6D4wAUFym2IfS3WMe/d+OEcwcI86 FR2RBw4MFp96+l5dMsWvQ9TyJXP33eQND5O9llu7tQslWF0w5kxApPc6Dn32fFKU3q2p tclzy0IzFWQnSRc5rlo4Ga1FgsupbVC70DhB4xaFvq8zHISweh9qox23Ipggha+mvQfc 3TEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ybomNOJkP9mYTlFH/CeNcETmX8OuO8axxo3LlgQXCSs=; b=pEM1Alk2PNBapdlBLP3DVhjzbcCTQKWrFhdnj4ehNnXhmOz1HXlL84qJWnYC7s5+i2 PgK1AFB59z4Y007d2rJNGeYiCHiYn7wwJtLFEDR9dDvSmjmu7imn1KnisxLCq4Ue1FrH LycikAtlaFyOAA93CU9sT8J3fgDAUNMBc1dDjHIhDlfuSJaiibwaptYZNiec1/Ap9aMu SX99nZh5oTM2Dej2peqCT7zcJ0pctzGXZQzHtq6yP805vQ9sRbT4TiAdLKfjC5D57/e4 9GgAzUOthbyKNCw+NYyewQhQxnp18CXdZcRU2RtYibaHLeHxi0SeYUr4sT0C09wKVpKF q/cg== X-Gm-Message-State: AJIora9gD/ePRx3KHFdzSX5ysa2o/oUQ7IPOVZ3Pw7fnwgzmE5E8PdZw /nocasDSNzPBnBheKzPCXdM= X-Google-Smtp-Source: AGRyM1trvXqK+BtxPRYA2QKuonRK8srXHf0OUgsGDlb0GQ2cVcQoQ9Kv9b1zfpyu7DWnvh1UtKISSA== X-Received: by 2002:a05:600c:35c7:b0:3a3:2612:f823 with SMTP id r7-20020a05600c35c700b003a32612f823mr466880wmq.33.1658509251793; Fri, 22 Jul 2022 10:00:51 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 18:00:50 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 10/14] VT-d: free all-empty page tables Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <28b6c824-683c-6a15-d891-651f79d99300@suse.com> From: "Durrant, Paul" In-Reply-To: <28b6c824-683c-6a15-d891-651f79d99300@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:48, Jan Beulich wrote: > When a page table ends up with no present entries left, it can be > replaced by a non-present entry at the next higher level. The page table > itself can then be scheduled for freeing. > > Note that while its output isn't used there yet, > pt_update_contig_markers() right away needs to be called in all places > where entries get updated, not just the one where entries get cleared. > > Note further that while pt_update_contig_markers() updates perhaps > several PTEs within the table, since these are changes to "avail" bits > only I do not think that cache flushing would be needed afterwards. Such > cache flushing (of entire pages, unless adding yet more logic to me more > selective) would be quite noticable performance-wise (very prominent > during Dom0 boot). > > Also note that cache sync-ing is likely more strict than necessary. This > is both to be on the safe side as well as to maintain the pattern of all > updates of (potentially) live tables being accompanied by a flush (if so > needed). > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:02:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:02:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373403.605603 (Exim 4.92) (envelope-from ) id 1oEw35-0004Gn-JK; Fri, 22 Jul 2022 17:02:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373403.605603; Fri, 22 Jul 2022 17:02:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw35-0004Gg-GJ; Fri, 22 Jul 2022 17:02:47 +0000 Received: by outflank-mailman (input) for mailman id 373403; Fri, 22 Jul 2022 17:02:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw34-0004GY-Ax for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 17:02:46 +0000 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [2a00:1450:4864:20::433]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1aafa069-09e0-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 19:02:44 +0200 (CEST) Received: by mail-wr1-x433.google.com with SMTP id m17so7040882wrw.7 for ; Fri, 22 Jul 2022 10:02:44 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id x3-20020adff0c3000000b0021deba99142sm4790720wro.40.2022.07.22.10.02.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:02:43 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1aafa069-09e0-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s+KqLdn0dK89A+5Nw7DWkEcVYPRUvYjP2NFooCkwCWY=; b=A6pk2/c3YvMcQrCnD6qzBM3PL/Q+2HGq9XKixlNG8lgtnyFm4Q2uqbLN+blKawVFMZ sAzXVM68Z1NREhajX3d0jwExy4nHtTg5j2/QZozdDbbl3bAnZHJU8OLNQVgQAt/MhgI1 5CUMsDLKdcQrH4XBntwd6k3NchdySrPNijG7IGnO5LWAGbyIozMbMAMcv2DzkfX7ICi/ OVyTUtj93lzR0cqc/ZddJ1QczHVIY2hco2byLoslginpiK4EPaJ7mPOf8e/2Fcb7673M GpOv/viO3sHtmbE5JRcmxVBwLx8DG4Gf5VTqaOvcOyH8zklkpgtg9OI8lG7If1B9D7U1 bTeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s+KqLdn0dK89A+5Nw7DWkEcVYPRUvYjP2NFooCkwCWY=; b=y2Q0P4/ADJOsIBXyGpaikELu7nKisEbic4cYOtGjZGBTqCG6mbFE6lDogmlE886E/4 gltwq/t8Lm31fSJu8h5MLhlZEv1d+eW8Ya30ofxaN4xBXrWFhzyMctSX9h/TDayM0FxG nif32B7xirDf1QrELfcB2lOcCRdLPDv2VzLYHQPdTI/SinDxL9K1WgG3CSxse9ofGbLH c1flsjLjcbvplRZYe2Amx8QIBMnprllgeTK62ZH2YaJCo8PHl5j60EscDJyniuM074rU RFF7rTheDEX7o/DztzWZ0FqCTO7n649wg3+hQ/7OVNITbWuWhfBnsVCeSrYyxq/crtCP 1uCA== X-Gm-Message-State: AJIora+CrECbfhef8NuNec8AFotixLMjCVizSECXCjliBzIRTRqFb5iK 761rdU74JD4I9a0qxjnW/r8= X-Google-Smtp-Source: AGRyM1so3uj6f907n8hM6XImJDl2zrekwBTh9rS+coQ/uU7/jA8rlE5VqZged9ExBQvGdRQap49ywA== X-Received: by 2002:a5d:470b:0:b0:21e:47f4:9a8b with SMTP id y11-20020a5d470b000000b0021e47f49a8bmr569535wrq.173.1658509364487; Fri, 22 Jul 2022 10:02:44 -0700 (PDT) Message-ID: <67765d28-a4e7-2461-8c4b-87e039e113ff@gmail.com> Date: Fri, 22 Jul 2022 18:02:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 11/14] AMD/IOMMU: replace all-contiguous page tables by superpage mappings Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <718906a5-8c18-530a-89f5-02e2a2efb211@suse.com> From: "Durrant, Paul" In-Reply-To: <718906a5-8c18-530a-89f5-02e2a2efb211@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:48, Jan Beulich wrote: > When a page table ends up with all contiguous entries (including all > identical attributes), it can be replaced by a superpage entry at the > next higher level. The page table itself can then be scheduled for > freeing. > > Signed-off-by: Jan Beulich > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:09:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:09:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373412.605614 (Exim 4.92) (envelope-from ) id 1oEw9C-0005DW-9T; Fri, 22 Jul 2022 17:09:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373412.605614; Fri, 22 Jul 2022 17:09:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw9C-0005DP-62; Fri, 22 Jul 2022 17:09:06 +0000 Received: by outflank-mailman (input) for mailman id 373412; Fri, 22 Jul 2022 17:09:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw9A-0005DH-Up for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 17:09:05 +0000 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [2a00:1450:4864:20::333]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fc84104c-09e0-11ed-bd2d-47488cf2e6aa; Fri, 22 Jul 2022 19:09:03 +0200 (CEST) Received: by mail-wm1-x333.google.com with SMTP id u14-20020a05600c00ce00b003a323062569so2836084wmm.4 for ; Fri, 22 Jul 2022 10:09:03 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id d1-20020adfe2c1000000b0021e491fd250sm5140518wrj.89.2022.07.22.10.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:09:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc84104c-09e0-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Qe3ukPZg5wzIjZ2k3fZ/Lhr1bZPPOrRSOqV2qo6wUKA=; b=FldCeIrjDK+4cq0YnhVAsd2McaFQN/z//93aCJRYrIxU5VWULpxb4YWhxWQBpFYq1I kOhZpBQzBNFZi+wAheSAcTFEG27lZckemCYSsJ4TcjVZaqjlsQd4Bd0/Lzc9GqOr+itw ywGj1F0jWAE6mMgQ+HIIll/VHf8D4pJmb8kc5kdFZ8SSkyYDXu7z2vYKoQIHJh49s8G9 dwAvSAw6Gf4jNIhrnpFjz4+ob1MJ6lO3lEpKPuyI9ypuNzRDQJD5nFKW1K3C81Qf+MhH 0i8urKMSAyEjIppbjM2rbUtq9exUYxyMoEHXBAkPxul01kQ0uC3xCJbl0SbZTAS6ZdZI gWjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Qe3ukPZg5wzIjZ2k3fZ/Lhr1bZPPOrRSOqV2qo6wUKA=; b=3xZQQCjJxjcGl1nTrNJxsnzrJKDTK86B5c9ObLCYwaSKM891ZHQKZuJCse5BZyrour +3TY/kfxII1X2zunu38d8E/7qJ0GIkxBvjApiu+p4tjdCnz29n6egZA7qzfJs+T6qfPG gQ4kuYvAPXm5Dz03uHc1mW3DYzZSjmYS3DsXwz/7fwEey8vC3lIHVJiryx3zyUrhHHaQ y5AkJ3M8COK0ntKETnrQD5RbXU4TngBJgE/m8WHFAvUCsNNzokR3Y2OqCyCVJzE5SfAM 8w0CKE8EjyzSLrfn6Rp5xj+Sf93RyXe92MYpyGQksbzlYBJgmQP4j131S/K7yHA3AlCm Nx8A== X-Gm-Message-State: AJIora+sA/1r755yzIYB5omzZHIIW1PyEKqY5Wx/TWSqqLPZacgSl+5B Qt9xvd27jdWhj2O4xGhROdU= X-Google-Smtp-Source: AGRyM1uVUuQtVdnL4hhl9TC6r53jpVlcirM6kiUkzDWiuSrmvmdQ9EVyqhMpyh4rSYNtU8suRda+oA== X-Received: by 2002:a05:600c:218a:b0:3a3:276b:7a17 with SMTP id e10-20020a05600c218a00b003a3276b7a17mr13072765wme.15.1658509743062; Fri, 22 Jul 2022 10:09:03 -0700 (PDT) Message-ID: <23e2221d-0d17-ed9c-d1bb-9a23289d9cee@gmail.com> Date: Fri, 22 Jul 2022 18:09:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 12/14] VT-d: replace all-contiguous page tables by superpage mappings Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <9ccc854e-9a8b-ffed-cd68-d26e5b3347ec@suse.com> From: "Durrant, Paul" In-Reply-To: <9ccc854e-9a8b-ffed-cd68-d26e5b3347ec@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:48, Jan Beulich wrote: > When a page table ends up with all contiguous entries (including all > identical attributes), it can be replaced by a superpage entry at the > next higher level. The page table itself can then be scheduled for > freeing. > > The adjustment to LEVEL_MASK is merely to avoid leaving a latent trap > for whenever we (and obviously hardware) start supporting 512G mappings. > > Note that cache sync-ing is likely more strict than necessary. This is > both to be on the safe side as well as to maintain the pattern of all > updates of (potentially) live tables being accompanied by a flush (if so > needed). > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:09:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:09:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373417.605625 (Exim 4.92) (envelope-from ) id 1oEwA0-0005k4-JC; Fri, 22 Jul 2022 17:09:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373417.605625; Fri, 22 Jul 2022 17:09:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEwA0-0005jx-Fr; Fri, 22 Jul 2022 17:09:56 +0000 Received: by outflank-mailman (input) for mailman id 373417; Fri, 22 Jul 2022 17:09:55 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEw9z-0005gM-Sc for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 17:09:55 +0000 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [2a00:1450:4864:20::434]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1b6cb211-09e1-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 19:09:55 +0200 (CEST) Received: by mail-wr1-x434.google.com with SMTP id u5so7368258wrm.4 for ; Fri, 22 Jul 2022 10:09:55 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id h17-20020adfe991000000b0021dd3e2fb60sm6220440wrm.0.2022.07.22.10.09.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:09:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1b6cb211-09e1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9455aJTLpHUAD4z+LwIX3srv5fwyHOkSK65qhSwRZaw=; b=E2iRV1OQDgi7+AfSPCYhsBnBmXTMcHGNnJ/7LEUWU2AL8xlpws1DJSjTsXRkLsoVaP K1dwNO+9Wp/eNhprT+g5mDSkEIr1koFNKo4KVsJFRh87la3/opY8aRqofy/H2aM/qg+i 3i7ItxrA5ypD/nALxQfSXD74hYy9xUY/qOBlTML9UPKfYLpRK29A58mN2P8CNvZDh8iR HTZfvUoltZ7fQf9hGeRzox/JMbXGOp84me0W6ITV9c1GZA1pD0xqbR7vmx0qV6NUhfEk 3FnrmeEgMo7XzQlcZCEIuMOwXGayyKaa6eiRsWoLsLroPfCxrMM6IZwp4ZG07oKGEtKR G8kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=9455aJTLpHUAD4z+LwIX3srv5fwyHOkSK65qhSwRZaw=; b=JoPkYKAVGgaDX05tJz26mkOlLWFo7APUn0MOH+OnUhMVs+mluKlGSavBb2bGu8X2mY lFKD2+aYj3tKNSMaWs6KTQyMwcFIIyB8eVH/9l3czXMLtUs0RKB9B8d5QZj0JT6NDK+f pASlIrjBShn0CMmaYfOBol+8CMDAFhhO+M3sj/4JItCHS6q1GgMMNEJJwcsN701tVVrl f4BV9svO4zn9NqRn5rIedAqqHWr/Wlhmf/J6QKFdr1CVA2VbzOdKO1SaGiBtV9mUFtlJ qvD5O4n164cHYUzIHS+GX0c7X8Mvgz/b7Ca6E/cEEmEBIUCx0vnpru5q1ZuKfcxLQ9mU lR0w== X-Gm-Message-State: AJIora8dxoaW/cl/UWCm1zSUGdFWuaZniF4+2NiLtruOV8xFueUebNft cVqCgsMp6++yk6PT29etp3hXHDSoPOy/Sg== X-Google-Smtp-Source: AGRyM1ufHlbFIAUZzARe47CG4qulQ8NjSPoe+GhPy5AWVpQ/Qx4kdg2wEcT0WwGYkx5AJg+K309hhA== X-Received: by 2002:a05:6000:1f08:b0:21e:54e1:6f21 with SMTP id bv8-20020a0560001f0800b0021e54e16f21mr584736wrb.255.1658509794778; Fri, 22 Jul 2022 10:09:54 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 18:09:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 13/14] IOMMU/x86: add perf counters for page table splitting / coalescing Content-Language: en-US To: xen-devel@lists.xenproject.org References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <1dab40d4-75f1-566c-f982-610013db72f5@suse.com> From: "Durrant, Paul" In-Reply-To: <1dab40d4-75f1-566c-f982-610013db72f5@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:49, Jan Beulich wrote: > Signed-off-by: Jan Beulich > Reviewed-by: Kevin tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:11:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:11:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373422.605636 (Exim 4.92) (envelope-from ) id 1oEwBH-00078G-Tk; Fri, 22 Jul 2022 17:11:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373422.605636; Fri, 22 Jul 2022 17:11:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEwBH-000789-QN; Fri, 22 Jul 2022 17:11:15 +0000 Received: by outflank-mailman (input) for mailman id 373422; Fri, 22 Jul 2022 17:11:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEwBG-000783-Cn for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 17:11:14 +0000 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [2a00:1450:4864:20::332]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a10e7f0-09e1-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 19:11:13 +0200 (CEST) Received: by mail-wm1-x332.google.com with SMTP id v67-20020a1cac46000000b003a1888b9d36so5592743wme.0 for ; Fri, 22 Jul 2022 10:11:13 -0700 (PDT) Received: from ?IPV6:2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9? ([2a00:23c5:5785:9a01:c8eb:68b3:50cf:a1a9]) by smtp.gmail.com with ESMTPSA id i5-20020a1c3b05000000b003a31d200a7dsm5807044wma.9.2022.07.22.10.11.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 10:11:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a10e7f0-09e1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:reply-to:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+uHNPRHasGp/zLvSnnqRXk//D9PCQ6LVhMfCDxKqXNM=; b=GG4IV6TRIXP4SDhyFqMZOKL4iaxU9XVC1wqaEnf831GteSYKvbLVEcBOFk6KD+vBlM SYPhb6thDE4hWi8M9976v+RvW6rTXYWYEwHXPMNhQ+9G2Dwv0YQ7QM3UBkahwPNDjKuN Qcu1Vrf/moofyEMm+NbivEh4x8KNZbTrp/+Igi50mjksUPrPnJiJrEt4acDP66h6NnoQ 3g9ctN5Yj4Y1QmfDUaG5Lqu68YSGHn1gnj+L3JoxC3kN52eMmt6rRG3nfaiffP2BX2iD ivs/JfWR21jtXp1N3tVQB1A46vm46YPhwQ87a6bEFVOQfYU/auI2d4PURmigLQdIzE4W RR2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:reply-to :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+uHNPRHasGp/zLvSnnqRXk//D9PCQ6LVhMfCDxKqXNM=; b=3PRaYrFNa4Xh6Ifd5hO7S7p9IOGb24sfaOQjfyBAnfXgWW+p+jh73Cl5XaMQPUMIlv s/+8CUqkImtwbT68EI63+YON27vv8WcDabTtyJZ7Wlkxoac9WsPRl/odPf/MCDKML4I5 Z84c/xPNM1wU4VOCvVjakbQTks+c5DGDT4Lw3FigoqObtsOjR9Q3YdgcwIByvzANZa4g wrJZzVPwrZi2nsB3jChtHNyX64/YyA7VFU3n2KsRiNDHU/9lmtdLZZYQQYjrXgdbQrpC Ds0PROwsvbxpQN+tK1nwvosWa8tvnt7gVZ7SL/JmAMBmxAB0GA+A5a6Qb4rx2XhYE0Ee NcTw== X-Gm-Message-State: AJIora/kjsbADOBe66a7VGUqvDo7Uzt4gJTsuqg17v/JTYE716Z44kKG QZwGqcWm2K6FYDmDN4BSUkRZKDTX9brC8g== X-Google-Smtp-Source: AGRyM1vBTXIH7YaNO6XQMXH9ayrQs8i5n1T42h3KaSOQqeWS+bCPJ9T24kX9SKH9RHqVBrJvbevzcg== X-Received: by 2002:a05:600c:4e01:b0:3a3:342:5f55 with SMTP id b1-20020a05600c4e0100b003a303425f55mr521459wmq.150.1658509872825; Fri, 22 Jul 2022 10:11:12 -0700 (PDT) Message-ID: Date: Fri, 22 Jul 2022 18:11:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Reply-To: paul@xen.org Subject: Re: [PATCH v7 14/14] VT-d: fold dma_pte_clear_one() into its only caller Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <4c9d4b32-d4db-3a4f-fe92-6022e63c3f82@suse.com> <20b9d343-fe6e-b5f1-1ad4-6795aaae0fcd@suse.com> From: "Durrant, Paul" In-Reply-To: <20b9d343-fe6e-b5f1-1ad4-6795aaae0fcd@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05/07/2022 13:49, Jan Beulich wrote: > This way intel_iommu_unmap_page() ends up quite a bit more similar to > intel_iommu_map_page(). > > No functional change intended. > > Signed-off-by: Jan Beulich > Reviewed-by: Kevin Tian > Reviewed-by: Roger Pau Monné Reviewed-by: Paul Durrant From xen-devel-bounces@lists.xenproject.org Fri Jul 22 17:55:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 17:55:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373439.605653 (Exim 4.92) (envelope-from ) id 1oEws6-00048J-C1; Fri, 22 Jul 2022 17:55:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373439.605653; Fri, 22 Jul 2022 17:55:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEws6-00048B-8T; Fri, 22 Jul 2022 17:55:30 +0000 Received: by outflank-mailman (input) for mailman id 373439; Fri, 22 Jul 2022 17:55:28 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEws4-000480-PW; Fri, 22 Jul 2022 17:55:28 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEws4-000284-Lj; Fri, 22 Jul 2022 17:55:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEws4-0004Rr-BN; Fri, 22 Jul 2022 17:55:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEws4-0003Xn-Aw; Fri, 22 Jul 2022 17:55:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rAYxRVfuX45BbD629dkGTYqQG+SIzY8QXi6xzASyPjY=; b=wjKTBAH9x7aHn/HwLLkSYrw/xE 6JoIylHDQUID35nKiEWncxGBdqpp4TvJHtWoJGykUEYj/iEpehJlcci+xjNRnojHEGZazJ/mq0ZAv GjQEWrjmtAJ8tx/rOeLgyEU4z3ijkTAszH5phWnd76w0du5bDtNBYhDah8HePn+muzvo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171764: regressions - trouble: broken/fail/pass X-Osstest-Failures: linux-5.4:test-amd64-amd64-pair::broken:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:regression linux-5.4:test-amd64-amd64-pair:host-install/src_host(6):broken:heisenbug linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Fri, 22 Jul 2022 17:55:28 +0000 flight 171764 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171764/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-pair broken test-armhf-armhf-xl-multivcpu 14 guest-start fail REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-amd64-amd64-pair 6 host-install/src_host(6) broken pass in 171743 test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 12 debian-hvm-install fail in 171743 pass in 171764 test-armhf-armhf-xl-vhd 13 guest-start fail in 171743 pass in 171764 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 171743 test-armhf-armhf-libvirt-qcow2 17 guest-start/debian.repeat fail pass in 171743 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 171743 like 171642 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171743 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171743 never pass test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 7 days Testing same since 171743 2022-07-21 19:11:46 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair broken test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-pair broken broken-step test-amd64-amd64-pair host-install/src_host(6) Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 22 19:38:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 19:38:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373465.605676 (Exim 4.92) (envelope-from ) id 1oEyTc-00009j-3t; Fri, 22 Jul 2022 19:38:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373465.605676; Fri, 22 Jul 2022 19:38:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEyTc-00009b-07; Fri, 22 Jul 2022 19:38:20 +0000 Received: by outflank-mailman (input) for mailman id 373465; Fri, 22 Jul 2022 19:38:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEyTa-00009Q-V5; Fri, 22 Jul 2022 19:38:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEyTa-00047A-T6; Fri, 22 Jul 2022 19:38:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEyTa-0000ys-Ic; Fri, 22 Jul 2022 19:38:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oEyTa-0006wn-Hv; Fri, 22 Jul 2022 19:38:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6T0r2Pxi2bKgmEHHOzzMNnN3uW5lKJvWCxjNfuQIBmY=; b=50vqjUSWO4NWjGK1wDmWw5bl4G vJQUVZblK8H6fhP41Enhli4SKjPzDUmPfayFr2bz4iur0kjn+H19k+IiqBnGRSCm0utGlOT4/kaxV U9wSWAbPBK3aXytPFDN8rtL8QC1WKa6TK7+mDDx5+0d5rSEVPOgjCq6vGnSkaEb/5Kfc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171776: all pass - PUSHED X-Osstest-Versions-This: ovmf=c8af26627a4e9a3659255dc147d75596da08248e X-Osstest-Versions-That: ovmf=343f37b5c07fd261b0fe8f3236459c9071be38b7 From: osstest service owner Date: Fri, 22 Jul 2022 19:38:18 +0000 flight 171776 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171776/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c8af26627a4e9a3659255dc147d75596da08248e baseline version: ovmf 343f37b5c07fd261b0fe8f3236459c9071be38b7 Last test of basis 171766 2022-07-22 07:45:21 Z 0 days Testing same since 171776 2022-07-22 17:41:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Sami Mujawar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 343f37b5c0..c8af26627a c8af26627a4e9a3659255dc147d75596da08248e -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 22 20:33:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 20:33:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373475.605693 (Exim 4.92) (envelope-from ) id 1oEzL7-0007aP-Ae; Fri, 22 Jul 2022 20:33:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373475.605693; Fri, 22 Jul 2022 20:33:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEzL7-0007aI-7J; Fri, 22 Jul 2022 20:33:37 +0000 Received: by outflank-mailman (input) for mailman id 373475; Fri, 22 Jul 2022 20:33:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oEzL5-0007aC-Pr for xen-devel@lists.xenproject.org; Fri, 22 Jul 2022 20:33:36 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0094.outbound.protection.office365.us [23.103.209.94]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8bb51a08-09fd-11ed-924f-1f966e50362f; Fri, 22 Jul 2022 22:33:31 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1433.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:180::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Fri, 22 Jul 2022 20:33:14 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%3]) with mapi id 15.20.5438.025; Fri, 22 Jul 2022 20:33:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8bb51a08-09fd-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=ye4QgLX8yYEVNgqQyIq1QtQJKO8+bfR8nsU/SjP1rxaCCiJ+URyc/Iwk4dqiNPiNnkeB5V7q64CD6p/4IBEVX3/2iHgybzLYD67W+xTDna/bm+IkYHYLwJDLJO5VzsCSd1KmNGufFc9AdpQGAskTfncnDmANvFnot4stn84HWdwRS0ymRBsP2KrAtK4m8Zsd/zz7ijBzkrc0Auwospi2pb6bOruN7MJeduwYOjyX6U0OUbhrxgJSsZFktAtA11/ICMKlHf3yso0A/uisdKMQln88Wz3lbnA8PDuo6kwazyDnpHEHY3fvv5QiTwl+hGoILU+tQnx2F2RwU7vmVoWutQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w+312G5s2Hko5HdbemCSLwRYiOVwjVoYNR2dui20+Do=; b=ahXgVqjA8P/mwdpCDcyC5k+swnVU08aggwjG9k8dKBA0mm//tDSvOA6ur6MiZ3dGWDhqr8dGiAPM1lgD0D/fG5QnBLZQsxbKWqKfghiefEV8jtojvKGdVfGVALq/Bl3Jj0Dg7Fxyn5KK5cUQ9xvPPNLqii58zotGVMECZkp7af1kUORjU5FWtOD3PHXbCF1WGL7L2Lf0kchso+H3k/4uW/zTovhv0SRpEoX6TJAqfoIFpmh9Jvu5/arv04Qb2TOQmTbRXh7ulEmhLXUTzjeNevGAYFLQD1aWAcr1UDiclOxtZKLquxm9kmvV9RNo4X+PgsiDQw9WQ4N79pOXKfjyKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w+312G5s2Hko5HdbemCSLwRYiOVwjVoYNR2dui20+Do=; b=qpVA+ttJFiy2N3qUUK/TAhSKvwwLLRrvlh+X+wCMyGw2xwwyL6cHnVMw5MSfwlpink7pSVhTYFLyV0tYhTvZjPSygxJl7XN2NToeMAyClauGq+9GUm3n05rT7ACx35O2ORnjK3i0G/C/VmV6Fq3gIJLzQ8Fh612NiqRC2LcopmtAJkqIxGJ97VXiKyRMOPMU/uZHhMDLVAb6Wz8uvF/gy2YTFs67RXZ87QWgmXPaISmuI0/wz9DBeYMN2oW1Tod8335uYReMM2LGTFPv1rr8iDkbwknZfeOucZqzpd5xalyIymPXdEY5MVr2yoBmK2AALR15Ky3NIyc5s1m3rQNcTw== From: "Smith, Jackson" To: "Daniel P. Smith" , Xen-devel Subject: RE: [PATCH v1 10/18] x86: introduce the domain builder Thread-Topic: [PATCH v1 10/18] x86: introduce the domain builder Thread-Index: AQHDrne88XyYXkgxTAt6TFUls0rRYAIuncUgrZgzpLCACqtagIAAUITg Date: Fri, 22 Jul 2022 20:33:14 +0000 Message-ID: References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-11-dpsmith@apertussolutions.com> <96cc29cf-5b31-eabd-3cca-eeaa7d7c58db@apertussolutions.com> In-Reply-To: <96cc29cf-5b31-eabd-3cca-eeaa7d7c58db@apertussolutions.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c7e2b41-8b24-4b1d-82da-08da6c216704 x-ms-traffictypediagnostic: BN0P110MB1433:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2vSnCfchwuxWIvpaThTWa8WP4K2oZ/vifRj+Os5iO4m+qRH/9HLIh6xxGzAJAv2Oa0V+BaNi3Re0J1ijDCg8QGjZtLT4GHzd9LRQoMYbWuYt1ZRYMm5O3UqYbWOcwjsSQ5Rt0EIAGBeS+6sxvBhEsMeiCaytNYmT0a+yYR1DFPaC9663JBXJu+qiGe06yrq/k/yz030gfUvde7eI8208w9hHILx3d4WkzcU7xYrNGMBiaC5yn33vzvXP0u526KkQUomNgD2DL1N+egt68icTrR2kXOBCjmQy/lM8vcrjMi6jJjehwFEMG4+F45oBXrQc4C4g99zMEJi0j73fDdlMC15AYZLU3QmVnkFfw0BzAxKCYW+mHluj2F+OjSh+IcReTWQO1MPa98e4eR3s37VG3Vph8ikxmb1WV7VpNl8qROE21ZkW/IKTxaAhNBARGOtCsI8KItG3+r2pkgb8tuXIzUEAJdJ8lrF5IZBgP4FrnHNkrvR94tQhE4sg7YaIJQDoScoIHzRbeNDsOkpVtoZRaNZRHlxe7LBzLLctWgybu9Ejp4EYqLrhv19H11KHQDgaM4O5T0PnpbEDK0FBR8lWu9FRPLitvFPVzU65XqwNUheyV488oWDqs8G01mTVOY4Lmh25dAM8SKawmz2SgTVJDdKbLdhZ2ZcTSBu6veFiaSBzJm6mdy2GzP+IB/AP7Rf4AXJuCu3cuTU6PLmqdnKcMkUHBCQ0ABJpix6RLOmdB77NrJUGNGcd0fHYxymMCYXA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(55016003)(83380400001)(110136005)(9686003)(38100700002)(33656002)(186003)(2906002)(8676002)(64756008)(66446008)(66476007)(66556008)(6506007)(7696005)(71200400001)(5660300002)(53546011)(66946007)(498600001)(122000001)(86362001)(38070700005)(76116006)(8936002)(52536014)(82960400001)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: a3L6ZUxAunzSgdS8vLvwlhLSzhdknBmldDeOiWFw4DXqTeazlGU+0T8D7d8RADuWAO6xKlEETrupDodopyFSv1GBmVu0WEh8jKafnwR5fWMMWCy0s0eEUSkZo0UNGkpigK42DJ1IuhyLuB/snGTfNp0AMS6c+hNIxEdGNboAqI6/WHZEsvE/TODRgEARB8tekCIR7zWWKC0ziASxzmc/PCRg/Oe/hNisioXRTN4aGR+3ZdAww29k7WYU4KNEoKCfBvTKBaPOdH0ipacJbSa9ECrzJHbOzKxvtAEmKNAEIywCwk3fI0FV4H13EDD/tqt+E9B0OJ5xTPkYbLjQzUSzK912MjTYk+kCThCUH9pd5zb+ayF2q3jg67wrRJSnCkHqTmluYqbsvhwNyDYNwF0iJd/NlYx3xpqVcgb0lqN41WjOtvlIQx9pYX4LBwbxPq49YKcww4KsGhdvokB/P3SSVe1apNPu+JMnwu5A1CM9tow= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 2c7e2b41-8b24-4b1d-82da-08da6c216704 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2022 20:33:14.4103 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1433 > -----Original Message----- > From: Daniel P. Smith > > On 7/18/22 09:59, Smith, Jackson wrote: > > Hi Daniel, > > > >> -----Original Message----- > >> Subject: [PATCH v1 10/18] x86: introduce the domain builder > >> > >> This commit introduces the domain builder configuration FDT parser > >> along with the domain builder core for domain creation. To enable > >> domain builder to be a cross architecture internal API, a new arch > >> domain creation call > > is > >> introduced for use by the domain builder. > > > >> diff --git a/xen/common/domain-builder/core.c > > > >> +void __init builder_init(struct boot_info *info) { > >> + struct boot_domain *d =3D NULL; > >> + > >> + info->builder =3D &builder; > >> + > >> + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) > >> + { > > > >> + } > >> + > >> + /* > >> + * No FDT config support or an FDT wasn't present, do an initial > >> + * domain construction > >> + */ > >> + printk("Domain Builder: falling back to initial domain build\n"); > >> + info->builder->nr_doms =3D 1; > >> + d =3D &info->builder->domains[0]; > >> + > >> + d->mode =3D opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; > >> + > >> + d->kernel =3D &info->mods[0]; > >> + d->kernel->kind =3D BOOTMOD_KERNEL; > >> + > >> + d->permissions =3D BUILD_PERMISSION_CONTROL | > >> BUILD_PERMISSION_HARDWARE; > >> + d->functions =3D BUILD_FUNCTION_CONSOLE | > >> BUILD_FUNCTION_XENSTORE | > >> + BUILD_FUNCTION_INITIAL_DOM; > >> + > >> + d->kernel->arch->headroom =3D bzimage_headroom(bootstrap_map(d- > >>> kernel), > >> + d->kernel->size); > >> + bootstrap_map(NULL); > >> + > >> + if ( d->kernel->string.len ) > >> + d->kernel->string.kind =3D BOOTSTR_CMDLINE; } > > > > Forgive me if I'm incorrect, but I believe there is an issue with this > > fallback logic for the case where no FDT was provided. > > IIUC, the issue at hand has to deal with patch #15. > > > If dom0_mem is not supplied to the xen cmd line, then d->meminfo is > > never initialized. (See dom0_compute_nr_pages/dom0_build.c:335) > > This was giving me trouble because bd->meminfo.mem_max.nr_pages was > > left at 0, effectivity clamping dom0 to 0 pages of ram. > > I realize I never shared the exact panic message I was experiencing. Sorry = about that. It's "Domain 0 allocation is too small for kernel image" on xen/arch/x86/pv= /domain_builder.c:534 I think you should be able to consistently reproduce what I'm seeing as lon= g as these two conditions are met: - the dom0_mem cmdline option is _not_ set - no domain builder device tree is passed to xen (the fallback case I ident= ified above) > > I'm not sure what the best solution is but one (easy) possibility is > > just initializing meminfo to the dom0 defaults near the end of this fun= ction: > > d->meminfo.mem_size =3D dom0_size; > > d->meminfo.mem_min =3D dom0_min_size; > > d->meminfo.mem_max =3D dom0_max_size; > > I believe the correct fix is to this hunk, > > @@ -416,7 +379,12 @@ unsigned long __init dom0_compute_nr_pages( > } > } > > - d->max_pages =3D min_t(unsigned long, max_pages, UINT_MAX); > + /* Clamp according to min/max limits and available memory (final). *= / > + nr_pages =3D max(nr_pages, min_pages); > + nr_pages =3D min(nr_pages, max_pages); > + nr_pages =3D min(nr_pages, avail); > + > + bd->domain->max_pages =3D min_t(unsigned long, max_pages, UINT_MAX); > > Before that last line, there should be a clamp up of max_pages, e.g. > > nr_pages =3D max(nr_pages, min_pages); > nr_pages =3D min(nr_pages, max_pages); > nr_pages =3D min(nr_pages, avail); > > max_pages =3D max(nr_pages, max_pages); > > bd->domain->max_pages =3D min_t(unsigned long, max_pages, UINT_MAX); > > v/r, > dps I don't believe this resolves my issue. If max_pages is 0 before these 5 lines, then the second line will still cla= mp nr_pages to 0 and the panic on line 534 will be hit. Before patch 15, this max limit came directly from dom0_max_size, which has= a default value of { .nr_pages =3D LONG_MAX }, so no clamping will occur u= nless overridden by the cmd line. After patch 15, bd->meminfo.mem_max is used as the max limit. (unless overr= idden by the cmdline) I'm assuming it will eventually be specified in the device tree, but for no= w, the max limit just set to equal to the size (xen/common/domain-builder/f= dt.c:155) so no down-clamping will occur. The only exception is the initial domain construction fallback. In this cas= e, there is no device tree and bd->meminfo is never initialized. If bd->meminfo.mem_size is zero, the code will try to compute a reasonable = default for nr_pages, but there is no such logic max_pages. It remains 0, a= nd clamps nr_pages to zero. Does this help clarify? The core issue is that without a device tree or command line option to spec= ify the max limit, the max limit is left uninitialized, which clamps dom0's= memory to 0. I think it should be initialized to LONG_MAX in that case, li= ke it was before this patch set. Thanks, Jackson From xen-devel-bounces@lists.xenproject.org Fri Jul 22 22:25:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 22 Jul 2022 22:25:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373497.605715 (Exim 4.92) (envelope-from ) id 1oF14f-0004Wv-E3; Fri, 22 Jul 2022 22:24:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373497.605715; Fri, 22 Jul 2022 22:24:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF14f-0004Wo-BQ; Fri, 22 Jul 2022 22:24:45 +0000 Received: by outflank-mailman (input) for mailman id 373497; Fri, 22 Jul 2022 22:24:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF14e-0004We-3L; Fri, 22 Jul 2022 22:24:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF14e-0007XG-2P; Fri, 22 Jul 2022 22:24:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF14d-0004kb-Nr; Fri, 22 Jul 2022 22:24:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oF14d-0000di-NL; Fri, 22 Jul 2022 22:24:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PZuPN/xj6e81JhaZbl/vDhkVQQNyb3xp1hTQsJuoR5c=; b=0rmXOKF9gNHkgioNUCbvyAJYtY qxv34Mxl6t2xiKXYca5DT/LY7wpYddRMSNbSkCBQMT8zHaKF+FSj6Fj86eCu+a15+ckI3VP9mMbON PUmu7gh86IVreRtolN4WSchr1qeJAYDVt2qnGWByqxil48ZSoxwMpIztXRAKmLNLebRI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171781: all pass - PUSHED X-Osstest-Versions-This: ovmf=5a3641bfcdcf99fd76817833488f2af8abb69383 X-Osstest-Versions-That: ovmf=c8af26627a4e9a3659255dc147d75596da08248e From: osstest service owner Date: Fri, 22 Jul 2022 22:24:43 +0000 flight 171781 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171781/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 5a3641bfcdcf99fd76817833488f2af8abb69383 baseline version: ovmf c8af26627a4e9a3659255dc147d75596da08248e Last test of basis 171776 2022-07-22 17:41:16 Z 0 days Testing same since 171781 2022-07-22 19:41:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c8af26627a..5a3641bfcd 5a3641bfcdcf99fd76817833488f2af8abb69383 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 23 00:57:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 00:57:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373521.605739 (Exim 4.92) (envelope-from ) id 1oF3S8-0006Ue-6I; Sat, 23 Jul 2022 00:57:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373521.605739; Sat, 23 Jul 2022 00:57:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF3S8-0006UX-2N; Sat, 23 Jul 2022 00:57:08 +0000 Received: by outflank-mailman (input) for mailman id 373521; Sat, 23 Jul 2022 00:57:06 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF3S6-0006UN-7L; Sat, 23 Jul 2022 00:57:06 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF3S6-0002id-1s; Sat, 23 Jul 2022 00:57:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF3S5-0003Ap-My; Sat, 23 Jul 2022 00:57:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oF3S5-0003SI-1z; Sat, 23 Jul 2022 00:57:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ehyhf+pm87vR8yvtc+L72oofH3lNbcBdr89i5f14Hpo=; b=jPMmu51JIrXfNyyrVRSspxenun wHPrS52C4vb+JTqk9s604ezn0TSEY5VTw8mG87+MzKwb6YcwMkSNd2kO3W+7Odw3EHs+0AD4Oz06e yEa/C5MKE/Tt+/iSndxj7yBOmjBgj2q90RS6Bll/lrMqBgZj9jOeMkjTzOaLAdXM3qVg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171772: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Sat, 23 Jul 2022 00:57:05 +0000 flight 171772 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171772/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171753 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171753 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171753 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171753 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171753 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171753 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171753 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171753 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171753 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171753 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171753 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171753 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171772 2022-07-22 14:23:54 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373543.605801 (Exim 4.92) (envelope-from ) id 1oF64B-0000R1-EL; Sat, 23 Jul 2022 03:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373543.605801; Sat, 23 Jul 2022 03:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64B-0000QI-8q; Sat, 23 Jul 2022 03:44:35 +0000 Received: by outflank-mailman (input) for mailman id 373543; Sat, 23 Jul 2022 03:44:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF649-00086N-A3 for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:33 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c1cc8aff-0a39-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 05:44:30 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BBBD15C0110; Fri, 22 Jul 2022 23:44:29 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Jul 2022 23:44:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c1cc8aff-0a39-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658547869; x=1658634269; bh=zetN2Gdm7SQF49L9d/RaHd27ZFZZJEqIZva 4v9uU+Uo=; b=WdkjChwxrvlfemtCy+k8/LlCUSTcWbbPu7lJgsih+BAixvKhuH7 4JHWJsFBa9X929jnbwN84wsTwWd/7kkK1yFmp9GInuuk8K4Ot0xSOw8lmkhByc3s 6f32V5an7x2f7AEXfgvlsV43LLYH5Wsi6shrT71O05uzyyg3mTQgF70hRWdxF/up nMKSR8xCGb+We4tWs0E4zl7a/2lHGE/SXeME+IZmY39ORV8oBzZuaLXs0hO6h2Du QJwdczqlmS01z9+9BllO0buWCrZhbWlax7e6TV3hTlMzoOH0+E7mawIqEbsQ/Piv WyIjHwcnXgOVHEf8JKBonVyUoCHG9IZ9/Gw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658547869; x=1658634269; bh=zetN2Gdm7SQF4 9L9d/RaHd27ZFZZJEqIZva4v9uU+Uo=; b=MXr/yLrlk0Yd3w8l6zkGqUFCBb99n QKdhJAjm5DP27t8994iPVdFhjYnAuctrPQ0Hoe4CC7xX7CoAzRNNVa3VRk+WtOtX jb0e7IAdbCLcDckMqUGNB3sOUKAFzdjqdQ8wWZo/ft1QPluAFioaGBM6qXyvc0vF Te3b6avTwX5qNmb3YkRvddUpRZwBjQNCDcHdk7QgQNNx+nGSYlMYkJRvjEhkOSAt E35uE4yL4duH69ooN0RPaqL9dg6f92ARYcqAWlWNrfgCG8ZdrXCbK5FjeBRKHBA5 X1sU/+KcVs3VjIWzh7BhaEdPUKYpK8wrEVRoI+GfW/EXtstzrTgHTF0eA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 4.19] Ignore failure to unmap -1 Date: Fri, 22 Jul 2022 23:44:13 -0400 Message-Id: <20220723034415.1560-4-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 73e9e72247b9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 492084814f55d8ed46d2d656db75b28a91dd7f06..27d955c5d9f9076266f77b9fedfa1a6a2ba08f56 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -416,7 +416,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373541.605779 (Exim 4.92) (envelope-from ) id 1oF649-0008NG-T0; Sat, 23 Jul 2022 03:44:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373541.605779; Sat, 23 Jul 2022 03:44:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF649-0008N9-Ow; Sat, 23 Jul 2022 03:44:33 +0000 Received: by outflank-mailman (input) for mailman id 373541; Sat, 23 Jul 2022 03:44:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF648-00086N-2w for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:32 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bef30e6b-0a39-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 05:44:28 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 9CA275C0090; Fri, 22 Jul 2022 23:44:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Jul 2022 23:44:24 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:23 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bef30e6b-0a39-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1658547864; x= 1658634264; bh=Q+2bcuYbqNaeJUyXlpoGM3BHR0EjVdzO4fH/v0jEPL4=; b=7 t1JRyzTo/cUpqOGjclWdhpSnggdWsoxx/jZXJ8VkWT8hDZgObyUSmHMsJ2rQceMA IbsozmiGBQ3OowrBrhrm/UH+cqJQhlYZ5C+FkbxjvZPEf20El5Ez4DkJ7ASqqrdF Qm5TWOplLbMpM47m7uuTiQpgMa03O4S1wcjQztwPfT/d8pHPWqb0hXKpMkIa4EHa idR00dVzu09I6/vjFlHxpQyCbqbqVSwZn3mmNOZjlYY5MZQHi4wAz11G/2viordE Q4PlxgOK8cnhwgLTgp5Uk7V2r7JyRFp8+IbrU8lTHTEBeT8galyYO+n6QgDuAsPv 7srhaCpCFGUTsg3RwIfFA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1658547864; x=1658634264; bh=Q+2bcuYbqNaeJUyXlpoGM3BHR0EjVdzO4fH /v0jEPL4=; b=C/uvxx0mgnbPf8amBWXIyKazG/mgZB/TuRDW8v+FCezAN0hkTf8 iTSiozTjbTDY0H23jRMmUi8ztfOEMhcs4QKabgc67MM4cFFlS9yhJZwxQ7WsWz9W XqsrHOSl3eQM0RVG11QRuEKW/XROGXbYbxmm81uJU/R8rPn4MDh2Nj2BBY16sGUz DRg3KyI6+HJ4R1EebfS2jPTUJbTEtkqZWoma1I/AHdGEqO2uEQo0aF7rzQJsqPFu oCDgsH80JdQ01oipnF80Uqx826dMRaIbuPHMLDIUQt6GU52kycspkpQBMOMWZzEj WP/Y4cUcwldoY05nrgdzgiRfikAv3KMGimA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgggfestdekredtredttdenucfhrhhomhepffgvmhhiucfo rghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomheqnecuggftrfgrthhtvghrnhepvdefgeekvdekgfffgeekhfeijedtffek hefhleehfeejueetgfelgefgtdevieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhslhgr sgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Backport of 166d38632316 ("xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE") Date: Fri, 22 Jul 2022 23:44:10 -0400 Message-Id: <20220723034415.1560-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This series backports upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f to all supported stable kernel trees. -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373540.605768 (Exim 4.92) (envelope-from ) id 1oF648-000870-MA; Sat, 23 Jul 2022 03:44:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373540.605768; Sat, 23 Jul 2022 03:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF648-00086o-GG; Sat, 23 Jul 2022 03:44:32 +0000 Received: by outflank-mailman (input) for mailman id 373540; Sat, 23 Jul 2022 03:44:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF647-00086N-8s for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:31 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c01b9550-0a39-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 05:44:28 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id DE2435C00A8; Fri, 22 Jul 2022 23:44:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 22 Jul 2022 23:44:26 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:26 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c01b9550-0a39-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658547866; x=1658634266; bh=9EVYFQs3TfjexPazUkgkLFWSM4eN+61vSya zDvU3JXY=; b=RcBEtNP8oYQgdE7PhROvqMVJnmJebGH9Dxpv/SnrKBJk1fDlr1v fZgw30SFvmeZbNGJCV3k5YwBly3Ik0M5cDx8Si33qIyKNg3uaG3xPQ27/+JLvfwS VvDy4Lenhc8igbigKtRiQmg+ojnjnyDBG70Ueo8OZZhsXioKaMQgnZYR3erfwXKZ rqUOS2AAMVbPvQ2pxBxKdtercd7sXCV2I/gxt+dlI92XaawMv+aIsENFQX8/sRNT 3f9mHVsKt/XthsHhiCjnjdaQBK0uOHYF/v1pC48hzRv+YRYgCI149TP8GmugOypp r/DzRapvNBkF7KsXTlR6Ni+4re4tD7/ytQQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658547866; x=1658634266; bh=9EVYFQs3Tfjex PazUkgkLFWSM4eN+61vSyazDvU3JXY=; b=Y/A0P4Tc/sW0dbP6uJYXE3eVZJQ1E rtbAL/RtaQhhliRjoxxYyHKVGpxcAmDpAf8n4bT73/d3kbJuRaBKPrxMh9K38E35 1OB+14RaUsVux01fx9FB7JNlmUh2JAsxuTuDRxrG03ALZr5TDJJpcu7lxoZAhDKU dDX90LldNTeBcW3qttqZTPZ+FKDP4dtQiLqPw5p8pqshnMw9f4Yy6XZ18B+iwLYT 2Z+LjCQabPi4MftzQmGj4x5lOGsGpnCJR/KbCVp06fgumYWD9CLvqakJN1VRt1+N kw7HhV5ZSM1h/nLn3PCbXt6hz4gGaPD9swFyB155/cA8q1QfBpGBjwo9w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 4.9] Ignore failure to unmap -1 Date: Fri, 22 Jul 2022 23:44:11 -0400 Message-Id: <20220723034415.1560-2-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 36cd49b071fc ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 2c3248e71e9c1a3e032b847d177b02855cdda1a1..a6585854a85fc6fffc16c3498ba73fbee84ad6ca 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -390,7 +390,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373544.605806 (Exim 4.92) (envelope-from ) id 1oF64B-0000To-Pe; Sat, 23 Jul 2022 03:44:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373544.605806; Sat, 23 Jul 2022 03:44:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64B-0000SQ-ID; Sat, 23 Jul 2022 03:44:35 +0000 Received: by outflank-mailman (input) for mailman id 373544; Sat, 23 Jul 2022 03:44:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64A-00086N-AC for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:34 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c358c0dc-0a39-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 05:44:33 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 5978D5C0108; Fri, 22 Jul 2022 23:44:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Jul 2022 23:44:32 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c358c0dc-0a39-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658547872; x=1658634272; bh=flbY27l8SG12tvSsNQqmUwpFJSmusaEnV0T 4ZJqcCMU=; b=xF4f0386+BRstwpc3+9vBKw9cvhM1tkQkF858TzC7uIOjLlSh34 ORyX/bAT+dAnZ0/VdteC2jCowbUkQI5PgKFTYE9bLM+yHsF9Btjp/3iKqU9B8ui9 SdVaFifm473sHXZJK9knjbYjCi2/z0DoCMEga4ty932Xavn/qS4i0ZZqt5INi8al 31cl09EsRpqJiMQ9b1wVDBufJvSxOwKwB9ygLy/BfeEm6Iczsmztv2GuscMLuJba Ud7vftBpuB7edh5lUpVhU3gDnyixx9wUEDKvEpPrx//atq1e/ZHOjLzukR7CXznl j/09Iipj7aIrGvr2Wg4rQetAvqbib3IAnKA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658547872; x=1658634272; bh=flbY27l8SG12t vSsNQqmUwpFJSmusaEnV0T4ZJqcCMU=; b=qgzR+RglHcHc38yEZClE9b1aX24dd Ri+tHGKDYV0ifeqntUra/V2HFEKxn8C7ECnCZ7qhb/EGnKdqMngBdJq2iETQcfC2 itYc/6Sj2tiCQUJ28ARkOk9nCPUYA+DV2UIhlz8SVM5ByBEj6dbmBDKq38201drQ b9NAYSS5jtt+ING60a7ts/jKv/64EevwNsKkU69tg/YBlUdh9jntqQp9AKu4f7xm jgEoxmyPLHgUB7C1KQkHXsFN4O64l6H2J8wHVCNx/PtYbhu1EVm7gxrBT6X+Lagr 0ZXkYDO70+1d5YjACDcfkdbMtJ4+xKSRZLt89jAFi9MVdkMhuOjcxUzIg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 5.10] Ignore failure to unmap -1 Date: Fri, 22 Jul 2022 23:44:15 -0400 Message-Id: <20220723034415.1560-6-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 79963021fd71 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f415c056ff8ab8d808ee2bacfaa3cad57af28204..54fee4087bf1078803c230ad2081aafa8415cf53 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -401,7 +401,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373542.605785 (Exim 4.92) (envelope-from ) id 1oF64A-0008Qm-64; Sat, 23 Jul 2022 03:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373542.605785; Sat, 23 Jul 2022 03:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64A-0008QL-13; Sat, 23 Jul 2022 03:44:34 +0000 Received: by outflank-mailman (input) for mailman id 373542; Sat, 23 Jul 2022 03:44:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF648-00086N-HI for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:32 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c102e2e0-0a39-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 05:44:29 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 6D1545C00AB; Fri, 22 Jul 2022 23:44:28 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 22 Jul 2022 23:44:28 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:27 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c102e2e0-0a39-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658547868; x=1658634268; bh=Du7er5SQVhxuW3kUx1splIMx/vSJydk7q3s MOCxCorg=; b=BCfGo0YGXpJJWQLnZlFcCYNqz0PW4gLDxZ0brfHPJ1WKGupvT9O Lgyzb0mQhjsxfvSUk4M2XagIVT60vPH+OA0sxRBdk5aRk4e4KVuMBW7POIcQEX5N YRawmPVgPl0vFLttyk1tTpr6LvkXsvVajtMSqwGAKguuavNcRVNX7nrO7Tzk1hdd 24sve1DGEYVmm4UgVG2agglRFSIU8dMSYhFKDsGU7gU8yg0jwDVVdwJTGJO7oWKj GUj6k8xDrNFPZCdkUK+AcPMvBmT9PPKncpGt5rOShan3hRqIrMaTSfV30+WjZnpb NcSIy3tD8SmSV8al98x24Ya5NxIyfC4PapQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658547868; x=1658634268; bh=Du7er5SQVhxuW 3kUx1splIMx/vSJydk7q3sMOCxCorg=; b=JQZZ/tAL35rpY/iPYzDQl8unwVHG+ bEdFAwYP50vYxfBAmfg7+BrlEMt11rNQ0aYIEcdkr9jUtfoXjfTTjE97GRRfws+N wysZ55j2rPOxYwLFpRNpRUn965fq8R5gIsF9dEr1UZWnIHup5w8Z5npB90I0ypxq slkSjPiXWwYXRu+AE7XKHLG/4bmXPgpP0Yk1OhGn8xDr3x69Qhdg6VrCVml8Pn9Z D+xFc23ouETZHFdqbebiKcjpuOUunS/N6LoSCFNf5uXqlIq21tV4eJgq5dr1EN2a SVVeJ7F8H0oIDxhOyueLqRPdS1XYKMAW3e/BGZLjt3wzWvw5LdJFRWJIA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 4.14] Ignore failure to unmap -1 Date: Fri, 22 Jul 2022 23:44:12 -0400 Message-Id: <20220723034415.1560-3-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: 2fe26a9a7048 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index 2827015604fbaa45f0ca60c342bbf71ce4132dec..799173755b785e2f3e2483855f75af1eba8e9373 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -393,7 +393,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 03:44:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 03:44:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373545.605823 (Exim 4.92) (envelope-from ) id 1oF64E-00012V-CC; Sat, 23 Jul 2022 03:44:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373545.605823; Sat, 23 Jul 2022 03:44:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64E-00011z-86; Sat, 23 Jul 2022 03:44:38 +0000 Received: by outflank-mailman (input) for mailman id 373545; Sat, 23 Jul 2022 03:44:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF64B-0000F2-Ul for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 03:44:36 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c298500b-0a39-11ed-924f-1f966e50362f; Sat, 23 Jul 2022 05:44:32 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1EA145C00A8; Fri, 22 Jul 2022 23:44:31 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 22 Jul 2022 23:44:31 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 22 Jul 2022 23:44:30 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c298500b-0a39-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658547871; x=1658634271; bh=kIshqhgj647286FiEwZIn8F2MuAyAKY1Gro 0c4s+gcU=; b=JSx2PtzEibgqrkEZvGoBG8CqK+2r9TveSD7YgfXhFqGIPOCRIDx CNqujNo0dpXwsCZYMb77VVlctLv+wq85vt4nTZVQB3aDmLTJu4X9bMrCpOI60n6H Ut6f4JX2r1Wo2xdRTgp+ScdCBzvEMaDz4ECoUXV2kseUr+m8TejW+P5VQGAKS62y MUfynq/6Zzi9cB5MWxMkDT5jw1jyqfmdHJAOnfGvKZ7bRAqBHnGIatZ7OLruAnCw 09IMEHA5ogA0Ni7xY5Q24+3xaJCMBz5oze2bxC3lTxRMNRwP+Xcu+G2xmJrI1ut+ K2SE9ej2nkUynmRVsaCgYhJCJbnnaZQFUTQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658547871; x=1658634271; bh=kIshqhgj64728 6FiEwZIn8F2MuAyAKY1Gro0c4s+gcU=; b=QLHmLeMDfqL+icAIL083qO6iMLevo 3NggKb84AMD2NMJwLlCzStS5W4tJNeNqznnJ8R6zNyxVuK88pE7RICfFZ2cX6Jh1 BzoTbL6VST26O/6XLo0SkU1SaJ3pDx5crVPNVhC5Fi8mS/ZBhQRYKH+TVSyJ3UOZ 4KbTWwM6s3yiQeruZ5dwanozvwnDCmqGAemsEu5wVba1KnTzgurum6krrLSf5w2n qvEBEzEqamTrSh092ifXcbA736Ou12PA8pasS5pG5irRRP+MRoGJokDYnJjURmWu UnBmPgbJULdtFxXMThGb/xL/gi1DyDA8tsNTccGkk9v5An1VghyN8GXvg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtfedgjeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhgggfestdekredtredttdenucfhrhhomhepffgvmhhi ucforghrihgvucfqsggvnhhouhhruceouggvmhhisehinhhvihhsihgslhgvthhhihhngh hslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepjeffjefggfeugeduvedvjeekgfeh gffhhfffjeetkeelueefffetfffhtdduheetnecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepuggvmhhisehinhhvihhsihgslhgvthhhihhnghhs lhgrsgdrtghomh X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Greg Kroah-Hartman Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, stable@vger.kernel.org Subject: [PATCH 5.4] Ignore failure to unmap -1 Date: Fri, 22 Jul 2022 23:44:14 -0400 Message-Id: <20220723034415.1560-5-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit [ Upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f ] The error paths of gntdev_mmap() can call unmap_grant_pages() even though not all of the pages have been successfully mapped. This will trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of warnings can be very large; I have observed thousands of lines of warnings in the systemd journal. Avoid this problem by only warning on unmapping failure if the handle being unmapped is not -1. The handle field of any page that was not successfully mapped will be -1, so this catches all cases where unmapping can legitimately fail. Suggested-by: Juergen Gross Cc: stable@vger.kernel.org Signed-off-by: Demi Marie Obenour Fixes: ee25841221c1 ("xen/gntdev: Avoid blocking in unmap_grant_pages()") --- drivers/xen/gntdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c index f464793477650e631c8928e85c1990c5964c2e94..bba849e5d8a7b4d54925b842fbe3c6792e0f0214 100644 --- a/drivers/xen/gntdev.c +++ b/drivers/xen/gntdev.c @@ -413,7 +413,8 @@ static void __unmap_grant_pages_done(int result, unsigned int offset = data->unmap_ops - map->unmap_ops; for (i = 0; i < data->count; i++) { - WARN_ON(map->unmap_ops[offset+i].status); + WARN_ON(map->unmap_ops[offset+i].status && + map->unmap_ops[offset+i].handle != -1); pr_debug("unmap handle=%d st=%d\n", map->unmap_ops[offset+i].handle, map->unmap_ops[offset+i].status); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 05:08:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 05:08:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373589.605846 (Exim 4.92) (envelope-from ) id 1oF7N7-0004r1-JW; Sat, 23 Jul 2022 05:08:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373589.605846; Sat, 23 Jul 2022 05:08:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF7N7-0004qu-Ga; Sat, 23 Jul 2022 05:08:13 +0000 Received: by outflank-mailman (input) for mailman id 373589; Sat, 23 Jul 2022 05:08:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF7N6-0004qk-Rc; Sat, 23 Jul 2022 05:08:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF7N6-0006yt-O1; Sat, 23 Jul 2022 05:08:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF7N6-0005fp-6N; Sat, 23 Jul 2022 05:08:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oF7N6-0004rj-3L; Sat, 23 Jul 2022 05:08:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Vvw/AluCcsOLa0dwiGA8fe97kQUV8MXv+t0rKuJH/Y4=; b=nGP9gms7WSH4fIkVWHMFQtDgeC j2VQ8Dfp+lbTNj8LHsUi7WujF9+t0L2A2OH89XLvhdvwXcNC5ZAF/vUq/lCQsncjE9TbpIy+lGY9n 5q2TN6d4mPx11tmL72MMwVSyulq66HL5dXxJOwZEpq8WKykUXq+27MDKauJoEtzRogkA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171777: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sat, 23 Jul 2022 05:08:12 +0000 flight 171777 linux-5.4 real [real] flight 171792 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171777/ http://logs.test-lab.xenproject.org/osstest/logs/171792/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 171792 REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 171792-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 171642 test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 171792 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 171792 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 7 days Testing same since 171743 2022-07-21 19:11:46 Z 1 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 23 05:54:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 05:54:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373600.605863 (Exim 4.92) (envelope-from ) id 1oF866-0002Td-8W; Sat, 23 Jul 2022 05:54:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373600.605863; Sat, 23 Jul 2022 05:54:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF866-0002TW-4c; Sat, 23 Jul 2022 05:54:42 +0000 Received: by outflank-mailman (input) for mailman id 373600; Sat, 23 Jul 2022 05:54:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF864-0002TM-UQ; Sat, 23 Jul 2022 05:54:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF864-0007uz-Gg; Sat, 23 Jul 2022 05:54:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF864-0008Ai-3X; Sat, 23 Jul 2022 05:54:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oF864-0007dc-35; Sat, 23 Jul 2022 05:54:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2Mam6ZGz/5h8MfMn/Z1uQRIAtsBDqOe4uF7JriKTw5c=; b=K34KuiVc5gFDtUBGTtNQgZ4U46 qxHa9v66Wfw36NNKoAZE/HYPuCaLxY9t+p1L8wx5eNCVTyNfq4eFsJ288DNqV6gRUITpmoQxD5gxC 6rddSmt53B+XERKAgA85LUVqmL+K/ldqdWJ/I0WZ7hgZi8ZfM3hfQ17UNJt01dg3hqvw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171780: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=4ba1329cbb9456c937bff1ed8ad4ca91ab75eab6 X-Osstest-Versions-That: linux=68e77ffbfd06ae3ef8f2abf1c3b971383c866983 From: osstest service owner Date: Sat, 23 Jul 2022 05:54:40 +0000 flight 171780 linux-linus real [real] flight 171796 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171780/ http://logs.test-lab.xenproject.org/osstest/logs/171796/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-xsm 8 xen-boot fail pass in 171796-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 171796 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 171796 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171742 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171742 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171742 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171742 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171742 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171742 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171742 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171742 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 4ba1329cbb9456c937bff1ed8ad4ca91ab75eab6 baseline version: linux 68e77ffbfd06ae3ef8f2abf1c3b971383c866983 Last test of basis 171742 2022-07-21 19:10:41 Z 1 days Testing same since 171780 2022-07-22 19:10:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Linus Torvalds Marc Zyngier Neeraj Upadhyay Paul E. McKenney Zhangfei Gao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 68e77ffbfd06..4ba1329cbb94 4ba1329cbb9456c937bff1ed8ad4ca91ab75eab6 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Jul 23 06:04:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 06:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373609.605874 (Exim 4.92) (envelope-from ) id 1oF8Fi-0004HA-4Y; Sat, 23 Jul 2022 06:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373609.605874; Sat, 23 Jul 2022 06:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF8Fi-0004H3-1k; Sat, 23 Jul 2022 06:04:38 +0000 Received: by outflank-mailman (input) for mailman id 373609; Sat, 23 Jul 2022 06:04:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF8Fg-0004Gt-N3; Sat, 23 Jul 2022 06:04:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF8Fg-0008Be-KW; Sat, 23 Jul 2022 06:04:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oF8Fg-0000JX-9k; Sat, 23 Jul 2022 06:04:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oF8Fg-0006TF-9C; Sat, 23 Jul 2022 06:04:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/lAVp0DxzPsVE6+JLgR7qp/jAeoNZohZBX93dPSrGuc=; b=2ZcEwWCaJ/TRgnAW9lXMBpgeUt 6xSBUZut2GXNf7/Q7DIOW+wjq1eFUECvKG+oMPZgqJQJGNn7YJzDY8+4Z0M7nOuJRV67pv1+adFsr FuXj7JeY9e5XjI6JOt1CC0k7cABIx7F/w0+4f9gUpyt8YEEdEsfffRE11toUp8tjJcsk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171790: all pass - PUSHED X-Osstest-Versions-This: ovmf=bf1ff540d9271c64f0c5323c79b20b21990626fe X-Osstest-Versions-That: ovmf=5a3641bfcdcf99fd76817833488f2af8abb69383 From: osstest service owner Date: Sat, 23 Jul 2022 06:04:36 +0000 flight 171790 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171790/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf bf1ff540d9271c64f0c5323c79b20b21990626fe baseline version: ovmf 5a3641bfcdcf99fd76817833488f2af8abb69383 Last test of basis 171781 2022-07-22 19:41:47 Z 0 days Testing same since 171790 2022-07-23 02:40:26 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Mateusz Albecki jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 5a3641bfcd..bf1ff540d9 bf1ff540d9271c64f0c5323c79b20b21990626fe -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 23 08:58:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 08:58:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373655.605903 (Exim 4.92) (envelope-from ) id 1oFAy1-0008Lp-42; Sat, 23 Jul 2022 08:58:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373655.605903; Sat, 23 Jul 2022 08:58:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFAy1-0008Li-1I; Sat, 23 Jul 2022 08:58:33 +0000 Received: by outflank-mailman (input) for mailman id 373655; Sat, 23 Jul 2022 08:58:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFAy0-0008LY-GR; Sat, 23 Jul 2022 08:58:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFAy0-0003m7-Ct; Sat, 23 Jul 2022 08:58:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFAy0-0003pV-1D; Sat, 23 Jul 2022 08:58:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFAy0-0005Ng-0k; Sat, 23 Jul 2022 08:58:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ymGkr9PQm4KeU5ZRoRVwwl+iLvUI/x91hrqiSaRGCxg=; b=MmwJ+xquXY+2rFSn/N/BDWflvx +uQ0z2hh69+aO5L2fGfxE4q+buB+YWPUk79nJsgzESHRjl8uc/Fz4AOaUJo9lIA/hZDi8wIiSk5lA ExHDrB1qXvrY7+K1WtI71NAOkdTA9e/IRhKI+QIPo2RJylCyVOIXMB1q0+6hqUKQkSZQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171795: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=510540961417288a24d0870f0226f8255420c463 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 23 Jul 2022 08:58:32 +0000 flight 171795 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171795/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 510540961417288a24d0870f0226f8255420c463 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 743 days Failing since 151818 2020-07-11 04:18:52 Z 742 days 724 attempts Testing same since 171795 2022-07-23 04:21:17 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116919 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 23 09:26:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 09:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373665.605913 (Exim 4.92) (envelope-from ) id 1oFBP0-0003iV-HG; Sat, 23 Jul 2022 09:26:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373665.605913; Sat, 23 Jul 2022 09:26:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFBP0-0003iO-EV; Sat, 23 Jul 2022 09:26:26 +0000 Received: by outflank-mailman (input) for mailman id 373665; Sat, 23 Jul 2022 09:26:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFBOz-0003iE-GM; Sat, 23 Jul 2022 09:26:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFBOz-0004N3-8m; Sat, 23 Jul 2022 09:26:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFBOy-0005uO-TA; Sat, 23 Jul 2022 09:26:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFBOy-0000vN-Sa; Sat, 23 Jul 2022 09:26:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/T0iYoyDbDKpUWuwomvNqb7tD2FtMFrp+QsVuQ4lOu8=; b=ehp2gm6R5Hvhy2zNRbpOeTpa2i xMYg2vdwjoMe65HmqsDOeSsRC6dznZongVTFkNi2jX+1rtKC+uVXMWm2kk/Qym3BZtZ4hGyo6ConM iMzR7Dnj0hbyt8+ngT6DGmWvDF4QR7xP+NCosx58k8YEGBciFsglsXRvkMkQPAQrkuEM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171789: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Sat, 23 Jul 2022 09:26:24 +0000 flight 171789 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171789/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171772 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171772 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171772 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171772 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171772 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171772 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171772 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171772 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171772 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171772 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171772 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171772 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171789 2022-07-23 01:57:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jul 23 10:47:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 10:47:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373681.605931 (Exim 4.92) (envelope-from ) id 1oFCev-0005MI-K9; Sat, 23 Jul 2022 10:46:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373681.605931; Sat, 23 Jul 2022 10:46:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFCev-0005MB-Gh; Sat, 23 Jul 2022 10:46:57 +0000 Received: by outflank-mailman (input) for mailman id 373681; Sat, 23 Jul 2022 10:46:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFCet-0005M5-Gr for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 10:46:55 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c21ce76e-0a74-11ed-bd2d-47488cf2e6aa; Sat, 23 Jul 2022 12:46:52 +0200 (CEST) Received: from [10.10.1.164] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165857320800738.906841468846665; Sat, 23 Jul 2022 03:46:48 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c21ce76e-0a74-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1658573209; cv=none; d=zohomail.com; s=zohoarc; b=LaSJkBUNQnBBBQEiDzs74O6YSCx2nKaNHd63Nv+hLFB8BEPIlNj58vooOp1BUDGjoTvgjIXiDSIgB1clTCSfwJnlU1wi8BQdPSJmDs8RFl1eVCO6mtD394XaaUK11YIHFo2u+l2l4wy5yh+5+TvijSwhUeTldu36OaxXD0jzCmI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1658573209; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=DfnQwF38VcjhRW+hMYNYYelq1crc075oByVEd8ukSPc=; b=QTJieFrk0RbKhRGO3FBFkWO3rwFdZieh+rKg7FMQsQB8znKes5UXBIqeLkhqemITS1pCQjGMy3dqMIU468EV0fV0xxAKaXq2qha2CDorN4fAwjAer0FxqSUXCCw3bMjx1MWo3G7OEuniENsPZXwpO2k4LxEkWAaobc4P/lUUXbE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1658573209; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=DfnQwF38VcjhRW+hMYNYYelq1crc075oByVEd8ukSPc=; b=GwViLYnVsBROgzqOhgTTTq7uBH9CJocBSzVeCvwib9IECUq4qBkf+ltPAnCADZK0 GrKcD68RBdzahx7Q3MLtBduRNIUazz0FJgP/P0JkCl34mY6+afywzgWkAPcyXbA/JY/ o8QPEZK2EbESy2yZIZXRIrgmxhVsuVwW5mCFQeeg= Message-ID: <83f6facb-8cfe-67f6-32d4-e32e3976fd1f@apertussolutions.com> Date: Sat, 23 Jul 2022 06:45:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v1 10/18] x86: introduce the domain builder Content-Language: en-US To: "Smith, Jackson" , Xen-devel References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-11-dpsmith@apertussolutions.com> <96cc29cf-5b31-eabd-3cca-eeaa7d7c58db@apertussolutions.com> From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/22/22 16:33, Smith, Jackson wrote: >> -----Original Message----- >> From: Daniel P. Smith >> >> On 7/18/22 09:59, Smith, Jackson wrote: >>> Hi Daniel, >>> >>>> -----Original Message----- >>>> Subject: [PATCH v1 10/18] x86: introduce the domain builder >>>> >>>> This commit introduces the domain builder configuration FDT parser >>>> along with the domain builder core for domain creation. To enable >>>> domain builder to be a cross architecture internal API, a new arch >>>> domain creation call >>> is >>>> introduced for use by the domain builder. >>> >>>> diff --git a/xen/common/domain-builder/core.c >>> >>>> +void __init builder_init(struct boot_info *info) { >>>> + struct boot_domain *d = NULL; >>>> + >>>> + info->builder = &builder; >>>> + >>>> + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) >>>> + { >>> >>>> + } >>>> + >>>> + /* >>>> + * No FDT config support or an FDT wasn't present, do an initial >>>> + * domain construction >>>> + */ >>>> + printk("Domain Builder: falling back to initial domain build\n"); >>>> + info->builder->nr_doms = 1; >>>> + d = &info->builder->domains[0]; >>>> + >>>> + d->mode = opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; >>>> + >>>> + d->kernel = &info->mods[0]; >>>> + d->kernel->kind = BOOTMOD_KERNEL; >>>> + >>>> + d->permissions = BUILD_PERMISSION_CONTROL | >>>> BUILD_PERMISSION_HARDWARE; >>>> + d->functions = BUILD_FUNCTION_CONSOLE | >>>> BUILD_FUNCTION_XENSTORE | >>>> + BUILD_FUNCTION_INITIAL_DOM; >>>> + >>>> + d->kernel->arch->headroom = bzimage_headroom(bootstrap_map(d- >>>>> kernel), >>>> + d->kernel->size); >>>> + bootstrap_map(NULL); >>>> + >>>> + if ( d->kernel->string.len ) >>>> + d->kernel->string.kind = BOOTSTR_CMDLINE; } >>> >>> Forgive me if I'm incorrect, but I believe there is an issue with this >>> fallback logic for the case where no FDT was provided. >> >> IIUC, the issue at hand has to deal with patch #15. >> >>> If dom0_mem is not supplied to the xen cmd line, then d->meminfo is >>> never initialized. (See dom0_compute_nr_pages/dom0_build.c:335) >>> This was giving me trouble because bd->meminfo.mem_max.nr_pages was >>> left at 0, effectivity clamping dom0 to 0 pages of ram. >>> > > I realize I never shared the exact panic message I was experiencing. Sorry about that. > It's "Domain 0 allocation is too small for kernel image" on xen/arch/x86/pv/domain_builder.c:534 Yep, I ran into this one before and thought I had it addressed. > I think you should be able to consistently reproduce what I'm seeing as long as these two conditions are met: > - the dom0_mem cmdline option is _not_ set > - no domain builder device tree is passed to xen (the fallback case I identified above) Ack >>> I'm not sure what the best solution is but one (easy) possibility is >>> just initializing meminfo to the dom0 defaults near the end of this function: >>> d->meminfo.mem_size = dom0_size; >>> d->meminfo.mem_min = dom0_min_size; >>> d->meminfo.mem_max = dom0_max_size; >> >> I believe the correct fix is to this hunk, >> >> @@ -416,7 +379,12 @@ unsigned long __init dom0_compute_nr_pages( >> } >> } >> >> - d->max_pages = min_t(unsigned long, max_pages, UINT_MAX); >> + /* Clamp according to min/max limits and available memory (final). */ >> + nr_pages = max(nr_pages, min_pages); >> + nr_pages = min(nr_pages, max_pages); >> + nr_pages = min(nr_pages, avail); >> + >> + bd->domain->max_pages = min_t(unsigned long, max_pages, UINT_MAX); >> >> Before that last line, there should be a clamp up of max_pages, e.g. >> >> nr_pages = max(nr_pages, min_pages); >> nr_pages = min(nr_pages, max_pages); >> nr_pages = min(nr_pages, avail); >> >> max_pages = max(nr_pages, max_pages); >> >> bd->domain->max_pages = min_t(unsigned long, max_pages, UINT_MAX); >> >> v/r, >> dps > > I don't believe this resolves my issue. > > If max_pages is 0 before these 5 lines, then the second line will still clamp nr_pages to 0 and the panic on line 534 will be hit. > > Before patch 15, this max limit came directly from dom0_max_size, which has a default value of { .nr_pages = LONG_MAX }, so no clamping will occur unless overridden by the cmd line. > > After patch 15, bd->meminfo.mem_max is used as the max limit. (unless overridden by the cmdline) > I'm assuming it will eventually be specified in the device tree, but for now, the max limit just set to equal to the size (xen/common/domain-builder/fdt.c:155) so no down-clamping will occur. > > The only exception is the initial domain construction fallback. In this case, there is no device tree and bd->meminfo is never initialized. > If bd->meminfo.mem_size is zero, the code will try to compute a reasonable default for nr_pages, but there is no such logic max_pages. It remains 0, and clamps nr_pages to zero. > > Does this help clarify? > The core issue is that without a device tree or command line option to specify the max limit, the max limit is left uninitialized, which clamps dom0's memory to 0. I think it should be initialized to LONG_MAX in that case, like it was before this patch set. You are correct, my apologies. Thank you! > Thanks, > Jackson From xen-devel-bounces@lists.xenproject.org Sat Jul 23 11:58:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 11:58:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373693.605942 (Exim 4.92) (envelope-from ) id 1oFDlV-0005Zv-Us; Sat, 23 Jul 2022 11:57:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373693.605942; Sat, 23 Jul 2022 11:57:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFDlV-0005Zo-Rw; Sat, 23 Jul 2022 11:57:49 +0000 Received: by outflank-mailman (input) for mailman id 373693; Sat, 23 Jul 2022 11:57:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFDlU-0005Ze-OQ; Sat, 23 Jul 2022 11:57:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFDlU-0007RF-MN; Sat, 23 Jul 2022 11:57:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFDlU-00045M-Bi; Sat, 23 Jul 2022 11:57:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFDlU-00016V-BF; Sat, 23 Jul 2022 11:57:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NFxWr/RQ3iBnTvp0xMETpBdaanSOptYaZ7OC5DDKFkI=; b=m1OZqTvL5HVS0xLzt4IBM1K0X/ o79rxL/542wPX3ywYowT/HxIZYPeJcNanOK71xZuMkG57IatMiAd8d/8bhekm7do7EF0LB2C/Klke B5CJOsUoI96yp1StfXagdbnhYbSExOQ5NccP9bZluJUVTT/ooLQX6GF3vJbgMYSoc9QQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171800: all pass - PUSHED X-Osstest-Versions-This: ovmf=6964b5c48c69e4961bad2dd9d6c02918f23c3be0 X-Osstest-Versions-That: ovmf=bf1ff540d9271c64f0c5323c79b20b21990626fe From: osstest service owner Date: Sat, 23 Jul 2022 11:57:48 +0000 flight 171800 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171800/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6964b5c48c69e4961bad2dd9d6c02918f23c3be0 baseline version: ovmf bf1ff540d9271c64f0c5323c79b20b21990626fe Last test of basis 171790 2022-07-23 02:40:26 Z 0 days Testing same since 171800 2022-07-23 06:11:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Cosmo Lai jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git bf1ff540d9..6964b5c48c 6964b5c48c69e4961bad2dd9d6c02918f23c3be0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sat Jul 23 14:53:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 14:53:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373736.605959 (Exim 4.92) (envelope-from ) id 1oFGUj-00010Z-Le; Sat, 23 Jul 2022 14:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373736.605959; Sat, 23 Jul 2022 14:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGUj-00010S-Hs; Sat, 23 Jul 2022 14:52:41 +0000 Received: by outflank-mailman (input) for mailman id 373736; Sat, 23 Jul 2022 14:52:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGUj-00010K-0w for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 14:52:41 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 16f9aedf-0a97-11ed-924f-1f966e50362f; Sat, 23 Jul 2022 16:52:38 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2A68A60B71; Sat, 23 Jul 2022 14:52:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFC40C341C0; Sat, 23 Jul 2022 14:52:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 16f9aedf-0a97-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1658587954; bh=eHGhJ9gT5hbsaF5ne4IhQFx6DfM/kznHBz4j3QNAFyU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wxodx3+zAsm0XiEbE3jw6YNNywhqynaK28nIT8AcIzHvhFoVT1zmIXMDlmXG45CFd NfY8R+wL8UyExZ6+RhMoqBPSvo6tKE/P+/IVdduH//9Cae0uMHuoBOvs/aGgJhTfL9 R1/IQm4BXaOV9l1b+826TQBDHUItZ5Ks7ijSw5e4= Date: Sat, 23 Jul 2022 16:52:31 +0200 From: Greg Kroah-Hartman To: Demi Marie Obenour Cc: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: Backport of 166d38632316 ("xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE") Message-ID: References: <20220723034415.1560-1-demi@invisiblethingslab.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220723034415.1560-1-demi@invisiblethingslab.com> On Fri, Jul 22, 2022 at 11:44:10PM -0400, Demi Marie Obenour wrote: > This series backports upstream commit 166d3863231667c4f64dee72b77d1102cdfad11f > to all supported stable kernel trees. All now queued up, thanks. greg k-h From xen-devel-bounces@lists.xenproject.org Sat Jul 23 15:04:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 15:04:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373743.605969 (Exim 4.92) (envelope-from ) id 1oFGgH-0002kR-Ni; Sat, 23 Jul 2022 15:04:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373743.605969; Sat, 23 Jul 2022 15:04:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGgH-0002kK-Kx; Sat, 23 Jul 2022 15:04:37 +0000 Received: by outflank-mailman (input) for mailman id 373743; Sat, 23 Jul 2022 15:04:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGgG-0002kA-ED; Sat, 23 Jul 2022 15:04:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGgG-0002x8-BV; Sat, 23 Jul 2022 15:04:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFGgF-00012f-Tl; Sat, 23 Jul 2022 15:04:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFGgF-0005Pn-TG; Sat, 23 Jul 2022 15:04:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8rcYwo/E4DpZyjFWJgMIvABLoWGoL8tSy8jF7vcSBjY=; b=eTuYevVZAZLV+rN649277HAR3e PogVmStL/1wKlFve5gtkr40EOxamrXG1VIl2URPM2tW1k3Jomg+A9ImcqyTHiHdQDgbEczNeheqpe 1xmkoapZvdXAbVptVqL981/VSt4HxTOwWhgGFjm0vtRFdm2pd/+31Y/pWIcNeX9vaerE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171797: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sat, 23 Jul 2022 15:04:35 +0000 flight 171797 linux-5.4 real [real] flight 171806 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171797/ http://logs.test-lab.xenproject.org/osstest/logs/171806/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 171777 pass in 171797 test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 171777 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 171642 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 8 days Testing same since 171743 2022-07-21 19:11:46 Z 1 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 23 16:54:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 16:54:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373759.605999 (Exim 4.92) (envelope-from ) id 1oFIOP-0007iI-TD; Sat, 23 Jul 2022 16:54:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373759.605999; Sat, 23 Jul 2022 16:54:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFIOP-0007iB-QK; Sat, 23 Jul 2022 16:54:17 +0000 Received: by outflank-mailman (input) for mailman id 373759; Sat, 23 Jul 2022 16:54:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFION-0007i1-P6; Sat, 23 Jul 2022 16:54:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFION-0005ov-JQ; Sat, 23 Jul 2022 16:54:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFION-0005F4-46; Sat, 23 Jul 2022 16:54:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFION-0007BW-3a; Sat, 23 Jul 2022 16:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EQviaGnYJ82FchnpPWzuaFOWgpArG/4vE3LsWWvgvv8=; b=O9SPE8Ek0nejTXMpR1FLEpfl2p sXsdA3PCtbhPfEQ4igvK/m7cmYiMr6I3Oqj/F5BZWKsDWi3TQ1rwr/9bkbfIt95pCDXaZwg5nzInu Wv7/OtS6O5rygtKsC2uTTNX+VwTr19z6rPWc4dwyprkR08r2GLTu8Rvd7FP1ekTB2ze8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171799: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=70664fc10c0d722ec79d746d8ac1db8546c94114 X-Osstest-Versions-That: linux=4ba1329cbb9456c937bff1ed8ad4ca91ab75eab6 From: osstest service owner Date: Sat, 23 Jul 2022 16:54:15 +0000 flight 171799 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171799/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171780 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171780 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171780 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171780 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171780 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171780 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171780 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171780 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 70664fc10c0d722ec79d746d8ac1db8546c94114 baseline version: linux 4ba1329cbb9456c937bff1ed8ad4ca91ab75eab6 Last test of basis 171780 2022-07-22 19:10:04 Z 0 days Testing same since 171799 2022-07-23 05:56:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adrian Hunter Alex Deucher Alexandru Elisei Andrey Grodzovsky Aravind Iddamsetty Bartosz Golaszewski Ben Dooks Christian König Colin Foster Dan Carpenter Daniele Ceraolo Spurio Dave Airlie Dmitry Osipenko Douglas Anderson Dylan Yudaken Flavio Suligoi Haibo Chen Hans de Goede Harry Wentland Horatiu Vultur Jacky Bai Jens Axboe Kent Gibson Krzysztof Kozlowski Laurentiu Palcu Li Zhengyu Liang He Linus Torvalds Linus Walleij Luben Tuikov Mario Limonciello Mark Brown Matthew Brost Maxime Ripard Michal Simek Nícolas F. R. A. Prado Oleksij Rempel Palmer Dabbelt Rafael J. Wysocki Randy Dunlap Robert Hancock Rodrigo Vivi Solomon Chiu Song Liu Srinivas Neeli Stefan Agner Stylon Wang Takashi Iwai Tony Lindgren Ulf Hansson Vadim Pasternak Vladimir Oltean William Dean Wolfram Sang xinhui pan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 4ba1329cbb94..70664fc10c0d 70664fc10c0d722ec79d746d8ac1db8546c94114 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Jul 23 20:28:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 20:28:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373829.606034 (Exim 4.92) (envelope-from ) id 1oFLjM-0006gK-Lo; Sat, 23 Jul 2022 20:28:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373829.606034; Sat, 23 Jul 2022 20:28:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFLjM-0006gD-Iq; Sat, 23 Jul 2022 20:28:08 +0000 Received: by outflank-mailman (input) for mailman id 373829; Sat, 23 Jul 2022 20:28:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFLjL-0006g7-OP for xen-devel@lists.xenproject.org; Sat, 23 Jul 2022 20:28:08 +0000 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f206b1a8-0ac5-11ed-924f-1f966e50362f; Sat, 23 Jul 2022 22:28:03 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id B7266320024A; Sat, 23 Jul 2022 16:27:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sat, 23 Jul 2022 16:27:59 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 23 Jul 2022 16:27:57 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f206b1a8-0ac5-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding:date :date:from:from:in-reply-to:message-id:mime-version:reply-to :sender:subject:subject:to:to; s=fm3; t=1658608078; x= 1658694478; bh=JobHjI4vPeM2BF7bd/XNMmcC9Kn1HoQurkd99RcLsRk=; b=M WTbsxQI9l4G7tqQAiHf/K7oMTU8ufWVr4ldV3R0crGVCTUJE7fJXbX/llcvh7KRu lMPM4KBNzZXu+MCHVaVLJQ0vLXz6MvmZsaqgDYfLZ4LJ14ywaAxJBJmLhz8um+EW k7IzfudSehvF4XvP4qQma6b8jgN2bz148Fdt6Yt+6d8M5tufHxPp55tYcCM2qKUa AYxF2DvjnVWkrL/qH2HxZEmzjG/JCRLw22jYZo/5WVhG4frOZki37ELYn0CVoGO4 7ORJfy/Cr/ZwsgiqTSIevzoBtjgL4Kf/ojeISpBEqc1eKHbu+qZhcF2WSCHN5rc5 UqLNwgbiVCjkEGxQwZn/A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1658608078; x=1658694478; bh=JobHjI4vPeM2BF7bd/XNMmcC9Kn1HoQurkd 99RcLsRk=; b=BQzLN7kwQvOQTpo8U3OTqq0SwNGL/plAlnFsyOgbYUHXhPgDTuE Ow0WJS1uDHRgtvX6+v3V2jy+yZohTe8uG+k8qH/8cwoHhxr9rZZzpAnEE39A7F7U vmR/K50G5UxQFjvDe06/kn6PxIbeVr9nrDsPaaWJ85y6C7zKo7aJsfV2r05HpZwC FcNsswMDcMZsLMNOUVJF03H5qTfEl89C4kA999nfCRI30K+0Wa/kznBB5Z54GKnL /l9SClT6onhEurr+kr0nJEU5bp9RBu8qn8PoHk/0DRiMVahfQVcMcTtG6JhmzQ94 N7EPeagF7IvLMo3QXMSu4z0uaeTP2PzmO2A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtgedgudehfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkffoggfgsedtkeertdertddtnecuhfhrohhmpeffvghmihcu ofgrrhhivgcuqfgsvghnohhurhcuoeguvghmihesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpedvfeegkedvkefgffegkefhieejtdff keehhfelheefjeeutefgleeggfdtveeileenucevlhhushhtvghrufhiiigvpedtnecurf grrhgrmhepmhgrihhlfhhrohhmpeguvghmihesihhnvhhishhisghlvghthhhinhhgshhl rggsrdgtohhm X-ME-Proxy: Feedback-ID: iac594737:Fastmail From: Demi Marie Obenour To: =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Jens Axboe Cc: Demi Marie Obenour , xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH] Implement diskseq checks in blkback Date: Sat, 23 Jul 2022 16:27:15 -0400 Message-Id: <20220723202715.1347-1-demi@invisiblethingslab.com> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This allows specifying a disk sequence number in XenStore. If it does not match the disk sequence number of the underlying device, the device will not be exported and a warning will be logged. Userspace can use this to eliminate race conditions due to major/minor number reuse. Older kernels will ignore this, so it is safe for userspace to set it unconditionally. Signed-off-by: Demi Marie Obenour --- I'm marking this patch as RFC because I have not tested it beyond compiliation, and because I want to get feedback on the API before I put more effort into it. drivers/block/xen-blkback/xenbus.c | 35 ++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c index 97de13b14175eb8ced14d1649a3be461a464ee8a..cb531236b19709c791a82c868bfb4ed9aa284485 100644 --- a/drivers/block/xen-blkback/xenbus.c +++ b/drivers/block/xen-blkback/xenbus.c @@ -480,7 +480,7 @@ MODULE_PARM_DESC(feature_persistent, static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, unsigned major, unsigned minor, int readonly, - int cdrom) + bool cdrom, u64 diskseq) { struct xen_vbd *vbd; struct block_device *bdev; @@ -508,6 +508,25 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle, xen_vbd_free(vbd); return -ENOENT; } + + if (diskseq != (u64)-1) { + struct gendisk *disk = bdev->bd_disk; + if (unlikely(disk == NULL)) { + pr_err("xen_vbd_create: device %08x has no gendisk\n", + vbd->pdevice); + xen_vbd_free(vbd); + return -EFAULT; + } + + if (unlikely(disk->diskseq != diskseq)) { + pr_warn("xen_vbd_create: device %08x has incorrect sequence " + "number 0x%llx (expected 0x%llx)\n", + vbd->pdevice, disk->diskseq, diskseq); + xen_vbd_free(vbd); + return -ENODEV; + } + } + vbd->size = vbd_sz(vbd); if (cdrom || disk_to_cdi(vbd->bdev->bd_disk)) @@ -712,6 +731,7 @@ static void backend_changed(struct xenbus_watch *watch, int cdrom = 0; unsigned long handle; char *device_type; + unsigned long long diskseq; pr_debug("%s %p %d\n", __func__, dev, dev->otherend_id); @@ -730,6 +750,17 @@ static void backend_changed(struct xenbus_watch *watch, return; } + err = xenbus_scanf(XBT_NIL, dev->nodename, "diskseq", "%llx", &diskseq); + if (err == -ENOENT) { + diskseq = (uint64_t)-1; + } else if (err != 1) { + xenbus_dev_fatal(dev, err, "reading diskseq"); + return; + } else if (diskseq == (uint64_t)-1) { + xenbus_dev_fatal(dev, err, "UINT64_MAX is not a valid diskseq"); + return; + } + if (be->major | be->minor) { if (be->major != major || be->minor != minor) pr_warn("changing physical device (from %x:%x to %x:%x) not supported.\n", @@ -763,7 +794,7 @@ static void backend_changed(struct xenbus_watch *watch, be->minor = minor; err = xen_vbd_create(be->blkif, handle, major, minor, - !strchr(be->mode, 'w'), cdrom); + !strchr(be->mode, 'w'), cdrom, diskseq); if (err) xenbus_dev_fatal(dev, err, "creating vbd structure"); -- Sincerely, Demi Marie Obenour (she/her/hers) Invisible Things Lab From xen-devel-bounces@lists.xenproject.org Sat Jul 23 21:15:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 23 Jul 2022 21:15:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373839.606045 (Exim 4.92) (envelope-from ) id 1oFMTM-00042v-81; Sat, 23 Jul 2022 21:15:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373839.606045; Sat, 23 Jul 2022 21:15:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFMTM-00042o-3g; Sat, 23 Jul 2022 21:15:40 +0000 Received: by outflank-mailman (input) for mailman id 373839; Sat, 23 Jul 2022 21:15:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFMTL-00042e-C9; Sat, 23 Jul 2022 21:15:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFMTL-0003Gq-8c; Sat, 23 Jul 2022 21:15:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFMTK-0002oX-Pk; Sat, 23 Jul 2022 21:15:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFMTK-00062H-PE; Sat, 23 Jul 2022 21:15:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pJFHWmg/S/fEqW21ZHGAgXVQzaXDXAY07n7hc20db2s=; b=t5Bbdo1wQrISQQ5h+4WITkgBK1 DKaf3zM4fD/i8cSxaL1EEhf32htbGo89+u3O42KxyLRSPGxOOuvSg+fM3EiYHHAxAQ9yCLU2t28oh FRXYS9kWr+uu0QedsMPFI0ueeyez+yOo91qQ9BNLVWSstKZupma1DyhwvqVSciZSqZ9M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171807: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sat, 23 Jul 2022 21:15:38 +0000 flight 171807 linux-5.4 real [real] flight 171817 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171807/ http://logs.test-lab.xenproject.org/osstest/logs/171817/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 171797 REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail in 171797 pass in 171807 test-armhf-armhf-xl-multivcpu 14 guest-start fail pass in 171797 test-armhf-armhf-libvirt-raw 13 guest-start fail pass in 171797 test-armhf-armhf-libvirt-qcow2 13 guest-start fail pass in 171797 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 171797 blocked in 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 171797 like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 171797 like 171642 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 171797 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 171797 never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail in 171797 never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail in 171797 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 171797 never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 171797 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 8 days Testing same since 171743 2022-07-21 19:11:46 Z 2 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 24 03:02:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 03:02:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373873.606086 (Exim 4.92) (envelope-from ) id 1oFRsJ-00083i-8K; Sun, 24 Jul 2022 03:01:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373873.606086; Sun, 24 Jul 2022 03:01:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFRsJ-00083a-3L; Sun, 24 Jul 2022 03:01:47 +0000 Received: by outflank-mailman (input) for mailman id 373873; Sun, 24 Jul 2022 03:01:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFRsI-000837-BT; Sun, 24 Jul 2022 03:01:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFRsI-0001kS-8E; Sun, 24 Jul 2022 03:01:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFRsH-0001bO-Qe; Sun, 24 Jul 2022 03:01:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFRsH-0005Mp-QD; Sun, 24 Jul 2022 03:01:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ME33UYvz9pHfElIZlhQ5SuNQOacfJJJQMu33jhAvkcM=; b=NH8V6CIdIhniLOtavmX3PREWF6 ht+Xg7KzKP0rmzFjbVvIo3DXlhImoJE9Ykn7pkssNvbCWe+fij3icK2NA4dARj/lV/602jHRyWR59 WkDR+jm9qsA58fC8oWj66PDHniWVhg6RjDsn7g7T+P5ufbjrhX+wB0/WDzbprFMG9CfQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171813: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:host-ping-check-xen:fail:heisenbug linux-linus:test-amd64-amd64-pygrub:guest-saverestore.2:fail:heisenbug linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=515f71412bb73ebd7f41f90e1684fc80b8730789 X-Osstest-Versions-That: linux=70664fc10c0d722ec79d746d8ac1db8546c94114 From: osstest service owner Date: Sun, 24 Jul 2022 03:01:45 +0000 flight 171813 linux-linus real [real] flight 171824 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171813/ http://logs.test-lab.xenproject.org/osstest/logs/171824/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt 10 host-ping-check-xen fail pass in 171824-retest test-amd64-amd64-pygrub 18 guest-saverestore.2 fail pass in 171824-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail in 171824 like 171799 test-armhf-armhf-libvirt 15 migrate-support-check fail in 171824 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171799 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171799 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171799 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171799 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171799 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171799 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171799 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 515f71412bb73ebd7f41f90e1684fc80b8730789 baseline version: linux 70664fc10c0d722ec79d746d8ac1db8546c94114 Last test of basis 171799 2022-07-23 05:56:25 Z 0 days Testing same since 171813 2022-07-23 18:10:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Aaron Lewis Amit Kumar Mahapatra Biju Das Gavin Shan Linus Torvalds Marc Kleine-Budde Mark Brown Oliver Upton Paolo Bonzini Sai Krishna Potthuri jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub fail test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 70664fc10c0d..515f71412bb7 515f71412bb73ebd7f41f90e1684fc80b8730789 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Jul 24 06:06:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 06:06:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373901.606115 (Exim 4.92) (envelope-from ) id 1oFUl9-0003WJ-Ig; Sun, 24 Jul 2022 06:06:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373901.606115; Sun, 24 Jul 2022 06:06:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFUl9-0003WC-EH; Sun, 24 Jul 2022 06:06:35 +0000 Received: by outflank-mailman (input) for mailman id 373901; Sun, 24 Jul 2022 06:06:33 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFUl7-0003Rm-L8; Sun, 24 Jul 2022 06:06:33 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFUl7-0006PO-H5; Sun, 24 Jul 2022 06:06:33 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFUl7-00040H-6P; Sun, 24 Jul 2022 06:06:33 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFUl7-0006tl-5o; Sun, 24 Jul 2022 06:06:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Rj44yrvmgUDpqhaGERQBSTAdAq7t+PAHqg/9nuSmOJU=; b=eH+/mpnYfpxUDMaBGYb9CYSBib gfG3pqXKSO934c2cLD8hYW95W8s/jAT6s3gSTFhZTg5z/aO8LPiL26kHmrUHdTCAALzjIXV89/2F8 YqX9ncf/vZcEGX4hVsMiERl1n1KJeG0U93kohQllZweBipApkbQpcANhUsLwWTY9/TeY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171819: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start.2:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sun, 24 Jul 2022 06:06:33 +0000 flight 171819 linux-5.4 real [real] flight 171830 linux-5.4 real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171819/ http://logs.test-lab.xenproject.org/osstest/logs/171830/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 19 guest-start.2 fail in 171830 REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 171807 pass in 171819 test-armhf-armhf-libvirt-raw 13 guest-start fail in 171807 pass in 171819 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 171807 pass in 171819 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 171807 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171807 test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail pass in 171830-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail blocked in 171642 test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 171807 like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171807 like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail in 171807 like 171642 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171807 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171807 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171807 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171807 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 8 days Testing same since 171743 2022-07-21 19:11:46 Z 2 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 24 06:56:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 06:56:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373912.606129 (Exim 4.92) (envelope-from ) id 1oFVWu-000169-EK; Sun, 24 Jul 2022 06:55:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373912.606129; Sun, 24 Jul 2022 06:55:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFVWu-000162-BO; Sun, 24 Jul 2022 06:55:56 +0000 Received: by outflank-mailman (input) for mailman id 373912; Sun, 24 Jul 2022 06:55:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFVWs-00015s-Nz; Sun, 24 Jul 2022 06:55:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFVWs-0007ax-J8; Sun, 24 Jul 2022 06:55:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFVWs-0006Dy-9F; Sun, 24 Jul 2022 06:55:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFVWs-0003da-8m; Sun, 24 Jul 2022 06:55:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w9UqUaBE2oMmAM8fL5FvqHTrf6BaW7xxw8jaZ7VOpHg=; b=0pIvA/5Hqge0cgqWn44b1Q4EzL 5gJ5n7KLtpSKptt45gJy8RQX9tIkvt7//VM7vbP+oLxwyH60m5PzqtVd/siRo3VQsK+SeI6k/5y+q eH/8LQhh02fuP4BnARtRFHfNQJOZ0o+wUcsiA1DeUZnibyBv5eNPpYXLDUxh29Xj+UlM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171828: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=510540961417288a24d0870f0226f8255420c463 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 24 Jul 2022 06:55:54 +0000 flight 171828 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171828/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 510540961417288a24d0870f0226f8255420c463 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 744 days Failing since 151818 2020-07-11 04:18:52 Z 743 days 725 attempts Testing same since 171795 2022-07-23 04:21:17 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116919 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 24 08:47:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 08:47:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373936.606151 (Exim 4.92) (envelope-from ) id 1oFXGu-0005lV-0m; Sun, 24 Jul 2022 08:47:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373936.606151; Sun, 24 Jul 2022 08:47:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFXGt-0005lO-UL; Sun, 24 Jul 2022 08:47:31 +0000 Received: by outflank-mailman (input) for mailman id 373936; Sun, 24 Jul 2022 08:47:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFXGs-0005lE-O5; Sun, 24 Jul 2022 08:47:30 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFXGs-0002Cq-Ix; Sun, 24 Jul 2022 08:47:30 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFXGs-0003Sl-6B; Sun, 24 Jul 2022 08:47:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFXGs-0007VA-5i; Sun, 24 Jul 2022 08:47:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=k6B9WrRQzSm3spEvoPLL28uD8yBlQXo764GIFzGmz+o=; b=Bcf6Ev1ba4mFE9aFixwLiNet9q NNnLCAOSF6GKhTwc2EVATef4WkOwYbfD9kw0YV6UcEZPN4dc8oPFtDDf+JbUYWeJ1JdmkzF1ozhDh J9GAmntXnZwN9Vjit3XgJNLoEMvkmz93m6h0nSOJXYRz9wdHpUko+nZkkninz6iBViLI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171823: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Sun, 24 Jul 2022 08:47:30 +0000 flight 171823 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171823/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171789 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171789 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171789 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171789 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171789 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171789 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171789 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171789 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171789 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171789 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171789 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171789 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171823 2022-07-24 01:51:49 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 24 09:36:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 09:36:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373951.606181 (Exim 4.92) (envelope-from ) id 1oFY2X-0003NV-2D; Sun, 24 Jul 2022 09:36:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373951.606181; Sun, 24 Jul 2022 09:36:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFY2W-0003NO-VP; Sun, 24 Jul 2022 09:36:44 +0000 Received: by outflank-mailman (input) for mailman id 373951; Sun, 24 Jul 2022 09:36:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFY2U-0003NE-Qr; Sun, 24 Jul 2022 09:36:42 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFY2U-0003B1-ML; Sun, 24 Jul 2022 09:36:42 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFY2U-0005rU-BY; Sun, 24 Jul 2022 09:36:42 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFY2U-0007xG-Ax; Sun, 24 Jul 2022 09:36:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=1ZVUrSuD5QdGX2n8kUbX7TWU0tkt2fT3iIi8tEkhIkg=; b=BoL+pRvxgEFzlObVQJvqOw4Eyz jaAMXXqGwXiyqgZ4SkIIYZPW37Lrx8x8mwMe5+jmIor8DyehwN7PnqFA8+hUJe/LfaPbDxFitJE7Q IRQg7j8rcWWAUDJXzO469KIWBuvXokZqQYEUFBD0TBXRJEUa/8X1xxelYQ0JLUmsqQXA=; To: xen-devel@lists.xenproject.org Subject: [libvirt bisection] complete build-arm64-libvirt Message-Id: From: osstest service owner Date: Sun, 24 Jul 2022 09:36:42 +0000 branch xen-unstable xenbranch xen-unstable job build-arm64-libvirt testid libvirt-build Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced: 510540961417288a24d0870f0226f8255420c463 Bug not present: a4d97f0c199e980bb55d3b659214308c1b371b73 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171838/ (Revision log too long, omitted.) For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/libvirt/build-arm64-libvirt.libvirt-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/libvirt/build-arm64-libvirt.libvirt-build --summary-out=tmp/171838.bisection-summary --basis-template=151777 --blessings=real,real-bisect,real-retry libvirt build-arm64-libvirt libvirt-build Searching for failure / basis pass: 171828 fail [host=rochester0] / 151777 [host=laxton0] 151754 ok. Failure / basis pass flights: 171828 / 151754 Tree: libvirt git://libvirt.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: ovmf git://xenbits.xen.org/osstest/ovmf.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: seabios git://xenbits.xen.org/osstest/seabios.git Tree: xen git://xenbits.xen.org/xen.git Latest 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 6964b5c48c69e4961bad2dd9d6c02918f23c3be0 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 Basis pass a4d97f0c199e980bb55d3b659214308c1b371b73 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 Generating revisions with ./adhoc-revtuple-generator git://libvirt.org/libvirt.git#a4d97f0c199e980bb55d3b659214308c1b371b73-510540961417288a24d0870f0226f8255420c463 https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-57ba70da5312170883a3d622cd2aa3fd0e2ec7ae git://xenbits.xen.org/osstest/ovmf.git#bdafda8c457eb90c65f37026589b54258300f05c-6964b5c48c69e4961bad2dd9d6c02918f23c3be0 git://xenbits.xen.org/qemu-xen.git#ea6d3cd1ed79d824e605a70c3626bc437c386260-b746458e\ 1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/osstest/seabios.git#88ab0c15525ced2eefe39220742efe4769089ad8-46de2eec93bffa0706e6229c0da2919763c8eb04 git://xenbits.xen.org/xen.git#3fdc211b01b29f252166937238efe02d15cb5780-fcd27b3c759995775afb66be6bb7ba1e85da0506 adhoc-revtuple-generator: tree discontiguous: libvirt adhoc-revtuple-generator: tree discontiguous: qemu-xen Loaded 12667 nodes in revision graph Searching for test results: 151729 [host=laxton1] 151754 pass a4d97f0c199e980bb55d3b659214308c1b371b73 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 151777 [host=laxton0] 151818 [host=laxton1] 151827 [host=laxton1] 151842 [host=laxton0] 151858 [host=laxton1] 151883 [host=laxton1] 151910 [host=laxton0] 151935 [host=laxton0] 151956 [host=laxton0] 151984 [host=laxton1] 152006 [host=laxton0] 152034 [host=laxton0] 152064 [host=laxton1] 152094 [host=laxton1] 152135 [host=laxton1] 152167 [host=laxton0] 152226 [host=laxton1] 152209 [host=laxton0] 152278 [host=laxton1] 152193 [host=laxton0] 152247 [host=laxton1] 152317 [host=laxton0] 152296 [host=laxton1] 152339 [host=laxton0] 152377 [host=laxton0] 152408 [host=laxton1] 152454 [host=laxton0] 152482 [host=laxton0] 152502 [host=laxton1] 152512 [host=laxton0] 152569 [host=laxton1] 152558 [host=laxton0] 152535 [host=laxton1] 152595 [host=laxton1] 152539 [host=laxton0] 152549 [host=laxton0] 152585 [host=laxton1] 152628 [host=laxton1] 152651 [host=laxton1] 152666 [host=laxton0] 152686 [host=laxton0] 152720 [host=laxton1] 162794 [host=laxton0] 152784 [host=laxton1] 152845 [host=laxton1] 167361 [host=laxton0] 152881 [host=laxton0] 162829 [host=laxton0] 152955 [host=laxton0] 165325 [host=laxton1] 153032 [host=laxton1] 162852 [host=laxton0] 162870 [host=laxton0] 162888 [host=laxton1] 153144 [host=laxton1] 165373 [host=laxton1] 165395 [host=laxton1] 153338 [host=laxton0] 153440 [host=laxton1] 166965 [host=laxton0] 153534 [host=laxton1] 153608 [host=laxton0] 165412 [host=laxton1] 165424 [host=laxton0] 165441 [host=laxton0] 162985 [host=laxton1] 153678 [host=laxton0] 163011 [host=laxton1] 163026 [host=laxton1] 153853 [host=laxton0] 165451 [host=laxton0] 165461 [host=laxton1] 165473 [host=laxton1] 153928 [host=laxton0] 153783 [host=laxton0] 153999 [host=laxton1] 163139 [host=laxton0] 166997 [host=laxton1] 167224 [host=laxton1] 163111 [host=laxton1] 167226 [host=laxton1] 165489 [host=laxton0] 154043 [host=laxton1] 154154 [host=laxton1] 167238 [host=laxton1] 165504 [host=laxton0] 154238 [host=laxton1] 154097 [host=laxton1] 154353 [host=laxton0] 163164 [host=laxton0] 154374 [host=laxton1] 163178 [host=laxton0] 154415 [host=laxton0] 154313 [host=laxton1] 163191 [host=laxton1] 163208 [host=laxton0] 154489 [host=laxton0] 154454 [host=laxton0] 163223 [host=laxton1] 165516 [host=laxton0] 154561 [host=laxton0] 165533 [host=laxton0] 163236 [host=laxton1] 154520 [host=laxton1] 154605 [host=laxton0] 163295 [host=laxton0] 154632 [host=laxton1] 154675 [host=laxton0] 163308 [host=laxton0] 155123 [host=laxton0] 163322 [host=laxton0] 163382 [host=laxton0] 155067 [host=laxton0] 167499 [host=laxton0] 165595 [host=laxton0] 155193 [host=laxton0] 155429 [host=laxton0] 155301 [host=laxton1] 163431 [host=laxton1] 155397 [host=laxton0] 155475 [host=laxton1] 165633 [host=laxton1] 155500 [host=laxton1] 155511 [host=laxton0] 163466 [host=laxton0] 155543 [host=laxton0] 155634 [host=laxton1] 155588 [host=laxton1] 155678 [host=laxton1] 155793 [host=laxton0] 155721 [host=laxton1] 163510 [host=laxton0] 165658 [host=laxton1] 155831 [host=laxton0] 155762 [host=laxton0] 155948 [host=laxton0] 163555 [host=laxton0] 155885 [host=laxton0] 155974 [host=laxton1] 155920 [host=laxton1] 156059 [host=laxton1] 156012 [host=laxton0] 156082 [host=laxton0] 165683 [host=laxton1] 163588 [host=laxton0] 165702 [host=laxton1] 156114 [host=laxton1] 156233 [host=laxton0] 156163 [host=laxton1] 156253 [host=laxton0] 156201 [host=laxton0] 156290 [host=laxton1] 163630 [host=laxton0] 156314 [host=laxton0] 156273 [host=laxton0] 156376 [host=laxton0] 156328 [host=laxton1] 156391 [host=laxton0] 165735 [host=laxton0] 163669 [host=laxton1] 156340 [host=laxton1] 156405 [host=laxton0] 156357 [host=laxton0] 156611 [host=laxton1] 156509 [host=laxton0] 156537 [host=laxton1] 163728 [host=laxton1] 163704 [host=laxton1] 156549 [host=laxton0] 156671 [host=laxton0] 156702 [host=laxton1] 156579 [host=laxton0] 156731 [host=laxton0] 156817 [host=laxton1] 167066 [host=laxton1] 163760 [host=laxton0] 156800 [host=laxton1] 156828 [host=laxton0] 163773 [host=laxton1] 156808 [host=laxton1] 156870 [host=laxton1] 156847 [host=laxton1] 156892 [host=laxton1] 163796 [host=laxton0] 156915 [host=laxton1] 156977 [host=laxton0] 165803 [host=laxton0] 163829 [host=laxton0] 156938 [host=laxton0] 157000 [host=laxton0] 157022 [host=laxton1] 156958 [host=laxton0] 157106 [host=laxton0] 157045 [host=laxton1] 157125 [host=laxton1] 163862 [host=laxton0] 157067 [host=laxton1] 157150 [host=laxton1] 157084 [host=laxton0] 157171 [host=laxton0] 157251 [host=laxton0] 165829 [host=laxton1] 163893 [host=laxton1] 157195 [host=laxton0] 157274 [host=laxton0] 157216 [host=laxton1] 167382 [host=laxton1] 165852 [host=laxton0] 157339 [host=laxton1] 167390 [host=laxton0] 157235 [host=laxton1] 167405 [host=laxton1] 157369 [host=laxton0] 163933 [host=laxton0] 157481 [host=laxton1] 157404 [host=laxton1] 165871 [host=laxton0] 157516 [host=laxton0] 157453 [host=laxton1] 165890 [host=laxton0] 157624 [host=laxton0] 157543 [host=laxton0] 157661 [host=laxton0] 163973 [host=laxton0] 164017 [host=laxton1] 163982 [host=laxton0] 157715 [host=laxton0] 163994 [host=laxton1] 164004 [host=laxton0] 157593 [host=laxton0] 164032 [host=laxton0] 165922 [host=laxton1] 157735 [host=laxton0] 157750 [host=laxton1] 165931 [host=laxton1] 164050 [host=laxton1] 165944 [host=laxton0] 157867 [host=laxton0] 157844 [host=laxton0] 157781 [host=laxton0] 164063 [host=laxton0] 164070 [host=laxton0] 165955 [host=laxton0] 164080 [host=laxton1] 157885 [host=laxton1] 164088 [host=laxton1] 157904 [host=laxton1] 164099 [host=laxton1] 157933 [host=laxton0] 164108 [host=laxton1] 164118 [host=laxton1] 157953 [host=laxton0] 164124 [host=laxton0] 157970 [host=laxton0] 158023 [host=laxton0] 164130 [host=laxton1] 158065 [host=laxton1] 164140 [host=laxton0] 165968 [host=laxton0] 164147 [host=laxton1] 158083 [host=laxton0] 158147 [host=laxton0] 158099 [host=laxton1] 164156 [host=laxton0] 165985 [host=laxton0] 164165 [host=laxton1] 158188 [host=laxton0] 158118 [host=laxton1] 166764 [host=laxton1] 158274 [host=laxton1] 158238 [host=laxton1] 158374 [host=laxton1] 164175 [host=laxton0] 164184 [host=laxton0] 166024 [host=laxton1] 158294 [host=laxton1] 158397 [host=laxton0] 164190 [host=laxton1] 158415 [host=laxton0] 164201 [host=laxton1] 158431 [host=laxton0] 158310 [host=laxton1] 164223 [host=laxton0] 158344 [host=laxton1] 164236 [host=laxton1] 158460 [host=laxton0] 158469 [host=laxton1] 158509 [host=laxton1] 164249 [host=laxton1] 158535 [host=laxton0] 158485 [host=laxton1] 158569 [host=laxton0] 158551 [host=laxton0] 158587 [host=laxton0] 166040 [host=laxton0] 158597 [host=laxton0] 166050 [host=laxton0] 158610 [host=laxton1] 164268 [host=laxton1] 166067 [host=laxton0] 158623 [host=laxton1] 164311 [host=laxton1] 158700 [host=laxton1] 158717 [host=laxton0] 158761 [host=laxton0] 158805 [host=laxton0] 158842 [host=laxton0] 158935 [host=laxton0] 158878 [host=laxton0] 166076 [host=laxton0] 166082 [host=laxton1] 166091 [host=laxton1] 159031 [host=laxton0] 158973 [host=laxton1] 166103 [host=laxton1] 164374 [host=laxton0] 159152 [host=laxton1] 164423 [host=laxton1] 166112 [host=laxton1] 166121 [host=laxton1] 167130 [host=laxton0] 166137 [host=laxton0] 159239 [host=laxton0] 159284 [host=laxton1] 166143 [host=laxton0] 159318 [host=laxton0] 166148 [host=laxton0] 159338 [host=laxton0] 159401 [host=laxton0] 159366 [host=laxton0] 166153 [host=laxton0] 159537 [host=laxton1] 159437 [host=laxton1] 166161 [host=laxton0] 159454 [host=laxton0] 166182 [host=laxton1] 166191 [host=laxton0] 159471 [host=laxton0] 159570 [host=laxton0] 159486 [host=laxton0] 164498 [host=laxton1] 164470 [host=laxton0] 159613 [host=laxton1] 159507 [host=laxton0] 164514 [host=laxton1] 159656 [host=laxton0] 167423 [host=laxton1] 159782 [host=laxton1] 167473 [host=laxton1] 164539 [host=laxton1] 159693 [host=laxton0] 159790 [host=laxton0] 167481 [host=laxton1] 159799 [host=laxton0] 167488 [host=laxton1] 159812 [host=laxton1] 159723 [host=laxton1] 159885 [host=laxton1] 159903 [host=laxton0] 159824 [host=laxton1] 159928 [host=laxton1] 159832 [host=laxton1] 164603 [host=laxton0] 166203 [host=laxton0] 167178 [host=laxton0] 159845 [host=laxton0] 159969 [host=laxton0] 159854 [host=laxton0] 160053 [host=laxton0] 159865 [host=laxton0] 160071 [host=laxton0] 160075 [host=laxton0] 160085 [host=laxton1] 160122 [host=laxton1] 160093 [host=laxton1] 166236 [host=laxton0] 160107 [host=laxton0] 160135 [host=laxton1] 164641 [host=laxton0] 166264 [host=laxton1] 160151 [host=laxton0] 160262 [host=laxton1] 160164 [host=laxton0] 160406 [host=laxton1] 164677 [host=laxton0] 166305 [host=laxton1] 160350 [host=laxton1] 160434 [host=laxton0] 164688 [host=laxton0] 160379 [host=laxton1] 160464 [host=laxton0] 160546 [host=laxton1] 160490 [host=laxton0] 160576 [host=laxton0] 160519 [host=laxton0] 160634 [host=laxton1] 160740 [host=laxton0] 164745 [host=laxton1] 160661 [host=laxton0] 166340 [host=laxton0] 160690 [host=laxton1] 160761 [host=laxton1] 160783 [host=laxton1] 164789 [host=laxton0] 167325 [host=laxton0] 164803 [host=laxton1] 160890 [host=laxton0] 160813 [host=laxton1] 164852 [host=laxton0] 164822 [host=laxton1] 164870 [host=laxton0] 160845 [host=laxton1] 160937 [host=laxton0] 164880 [host=laxton1] 161037 [host=laxton0] 161119 [host=laxton1] 166374 [host=laxton0] 164895 [host=laxton1] 161157 [host=laxton0] 161078 [host=laxton0] 161192 [host=laxton0] 161251 [host=laxton1] 161223 [host=laxton1] 164935 [host=laxton1] 161311 [host=laxton0] 164947 [host=laxton1] 161345 [host=laxton0] 164953 [host=laxton1] 161369 [host=laxton1] 161282 [host=laxton1] 164964 [host=laxton1] 161459 [host=laxton1] 161398 [host=laxton1] 161475 [host=laxton1] 164978 [host=laxton1] 164990 [host=laxton0] 161496 [host=laxton1] 161423 [host=laxton0] 161516 [host=laxton1] 161443 [host=laxton0] 165005 [host=laxton0] 161596 [host=laxton1] 161542 [host=laxton1] 161615 [host=laxton1] 165028 [host=laxton0] 161698 [host=laxton0] 161570 [host=laxton0] 161783 [host=laxton0] 161804 [host=laxton0] 161827 [host=laxton0] 161889 [host=laxton0] 161848 [host=laxton1] 161871 [host=laxton1] 161913 [host=laxton1] 161956 [host=laxton0] 161927 [host=laxton1] 161944 [host=laxton0] 161966 [host=laxton1] 165104 [host=laxton0] 161975 [host=laxton0] 161988 [host=laxton1] 162110 [host=laxton0] 162076 [host=laxton1] 162120 [host=laxton1] 162128 [host=laxton1] 162138 [host=laxton0] 162100 [host=laxton0] 167444 [host=laxton0] 165126 [host=laxton1] 162147 [host=laxton1] 165137 [host=laxton1] 167457 [host=laxton1] 165148 [host=laxton1] 162159 [host=laxton1] 162191 [host=laxton1] 162254 [host=laxton1] 162263 [host=laxton0] 162243 [host=laxton1] 162272 [host=laxton1] 162332 [host=laxton0] 165162 [host=laxton0] 162295 [host=laxton1] 162345 [host=laxton1] 162360 [host=laxton0] 162390 [host=laxton1] 165177 [host=laxton0] 162427 [host=laxton1] 165189 [host=laxton0] 165201 [host=laxton0] 166956 [host=laxton1] 162481 [host=laxton1] 165228 [host=laxton1] 165214 [host=laxton0] 162535 [host=laxton1] 162563 [host=laxton1] 162632 [host=laxton1] 162598 [host=laxton1] 162681 [host=laxton0] 167511 [host=laxton0] 162760 [host=laxton0] 167525 [host=laxton1] 167533 [host=laxton1] 167582 [host=laxton0] 167538 [host=laxton1] 167542 [host=laxton0] 167607 [host=laxton0] 167546 [host=laxton1] 167589 [host=laxton0] 167551 [host=laxton0] 167594 [host=laxton1] 167556 [host=laxton0] 167600 [host=laxton1] 167568 [host=laxton0] 167617 [host=laxton0] 167574 [host=laxton0] 167657 [host=laxton0] 167625 [host=laxton0] 167669 [host=laxton0] 167637 [host=laxton1] 167682 [host=laxton1] 167645 [host=laxton1] 167694 [host=laxton0] 167650 [host=laxton1] 167703 [host=laxton1] 167710 [host=laxton1] 167732 [host=laxton0] 167721 [host=laxton1] 167744 [host=laxton0] 167804 [host=laxton1] 167756 [host=laxton0] 167809 [host=laxton1] 167846 [host=laxton1] 167779 [host=laxton0] 167791 [host=laxton0] 167911 [host=laxton1] 167930 [host=laxton0] 167797 [host=laxton0] 167952 [host=laxton1] 167962 [host=laxton1] 167942 [host=laxton1] 167971 [host=laxton0] 168021 [host=laxton1] 167982 [host=laxton0] 168031 [host=laxton1] 167992 [host=laxton0] 168040 [host=laxton0] 168053 [host=laxton0] 168006 [host=laxton0] 168067 [host=laxton1] 168076 [host=laxton0] 168082 [host=laxton1] 168171 [host=laxton1] 168176 [host=laxton1] 168117 [host=laxton1] 168184 [host=laxton1] 168125 [host=laxton1] 168191 [host=laxton1] 168202 [host=laxton1] 168146 [host=laxton1] 168212 [host=laxton1] 168225 [host=laxton1] 168159 [host=laxton1] 168237 [host=laxton1] 168321 [host=laxton1] 168242 [host=laxton1] 168354 [host=laxton1] 168251 [host=laxton1] 168393 [host=laxton1] 168264 [host=laxton1] 168413 [host=laxton1] 168432 [host=laxton1] 168473 [host=laxton1] 168452 [host=laxton1] 168549 [host=laxton1] 168492 [host=laxton1] 168577 [host=laxton1] 168500 [host=laxton1] 168608 [host=laxton1] 168511 [host=laxton1] 168630 [host=laxton1] 168522 [host=laxton1] 168649 [host=laxton1] 168671 [host=laxton1] 168699 [host=laxton1] 168769 [host=laxton1] 168719 [host=laxton1] 168796 [host=laxton1] 168740 [host=laxton1] 168818 [host=laxton1] 168969 [host=laxton1] 168836 [host=laxton1] 169009 [host=laxton1] 169126 [host=laxton1] 169058 [host=laxton1] 169139 [host=laxton1] 169154 [host=laxton1] 169098 [host=laxton1] 169171 [host=laxton1] 169270 [host=laxton1] 169192 [host=laxton1] 169296 [host=laxton1] 169207 [host=laxton1] 169322 [host=laxton1] 169224 [host=laxton1] 169351 [host=laxton1] 169254 [host=laxton1] 169386 [host=laxton1] 169502 [host=laxton1] 169415 [host=laxton1] 169531 [host=laxton1] 169447 [host=laxton1] 169555 [host=laxton1] 169477 [host=laxton1] 169581 [host=laxton1] 169611 [host=laxton1] 169640 [host=laxton1] 169669 [host=laxton1] 169768 [host=laxton1] 169699 [host=laxton1] 169805 [host=laxton1] 169727 [host=laxton1] 169932 [host=laxton1] 169850 [host=laxton1] 169980 [host=laxton1] 169897 [host=laxton1] 170078 [host=laxton1] 170138 [host=laxton1] 170020 [host=laxton1] 170231 [host=laxton1] 170168 [host=laxton1] 170261 [host=laxton1] 170287 [host=laxton1] 170201 [host=laxton1] 170317 [host=laxton1] 170346 [host=laxton1] 170379 [host=laxton1] 170437 [host=laxton1] 170408 [host=laxton1] 170470 [host=laxton1] 170500 [host=laxton1] 170527 [host=laxton1] 170589 [host=laxton1] 170560 [host=laxton1] 170624 [host=laxton1] 170744 [host=laxton1] 170660 [host=laxton1] 170752 [host=laxton1] 170690 [host=laxton1] 170760 [host=laxton1] 170715 [host=laxton1] 170768 [host=laxton1] 170722 [host=laxton1] 170774 [host=laxton1] 170784 [host=laxton1] 170803 [host=laxton1] 170793 [host=laxton1] 170881 [host=rochester1] 170814 [] 170892 [host=laxton1] 170825 [host=laxton1] 170911 fail irrelevant 170835 [host=laxton1] 170990 fail irrelevant 170842 [host=laxton1] 171143 fail irrelevant 170857 [host=laxton1] 171230 fail irrelevant 171153 fail irrelevant 171266 [host=rochester1] 171159 [host=rochester1] 171279 fail irrelevant 171285 [host=laxton1] 171175 [host=rochester1] 171297 [host=laxton1] 171189 [host=rochester1] 171306 [host=rochester1] 171323 [host=laxton1] 171338 [host=rochester1] 171351 [host=laxton1] 171366 [host=laxton1] 171358 [host=laxton1] 171379 [host=rochester1] 171436 fail irrelevant 171396 [host=rochester1] 171451 [host=laxton1] 171419 [host=laxton1] 171467 [host=laxton1] 171479 [host=laxton1] 171497 fail irrelevant 171520 fail irrelevant 171589 [host=rochester1] 171541 fail irrelevant 171555 fail irrelevant 171565 [host=rochester1] 171611 [host=rochester1] 171573 fail irrelevant 171625 [host=rochester1] 171579 [host=laxton1] 171638 fail irrelevant 171649 [host=laxton1] 171658 [host=laxton1] 171751 [host=rochester1] 171667 [host=laxton1] 171680 [host=rochester1] 171700 fail irrelevant 171752 [host=rochester1] 171754 [host=rochester1] 171713 [host=rochester1] 171755 [host=rochester1] 171775 [host=rochester1] 171757 [host=rochester1] 171761 [host=rochester1] 171762 [host=rochester1] 171804 pass a4d97f0c199e980bb55d3b659214308c1b371b73 27acf0ef828bf719b2053ba398b195829413dbdd bdafda8c457eb90c65f37026589b54258300f05c ea6d3cd1ed79d824e605a70c3626bc437c386260 88ab0c15525ced2eefe39220742efe4769089ad8 3fdc211b01b29f252166937238efe02d15cb5780 171763 [host=rochester1] 171805 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 5a3641bfcdcf99fd76817833488f2af8abb69383 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171767 [host=rochester1] 171768 [host=rochester1] 171808 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae dab96cf02e3be378310dd1bce119b0fac6fac958 ea6d3cd1ed79d824e605a70c3626bc437c386260 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 0faf37e7434ea08ed99d804aad98fcddf74852e7 171769 [host=rochester1] 171758 [host=rochester1] 171770 [host=rochester1] 171810 pass a4d97f0c199e980bb55d3b659214308c1b371b73 da30b01ffaf702db082cd01ba594dd4fb4143e58 5801910013757bd626f67ed77eea6c16a176eebf ea6d3cd1ed79d824e605a70c3626bc437c386260 6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9 d05c67efd94f301b48bc486246161b05acaa8df2 171811 pass a4d97f0c199e980bb55d3b659214308c1b371b73 d21009b1c9f94b740ea66be8e48a1d8ad8124023 46b4606ba23498d3d0e66b53e498eb3d5d592586 ea6d3cd1ed79d824e605a70c3626bc437c386260 64f37cc530f144e53c190c9e8209a51b58fd5c43 1c3ed9c908732d19660fbe83580674d585464d4c 171773 [host=rochester1] 171812 pass a4d97f0c199e980bb55d3b659214308c1b371b73 6119e6e19a050df847418de7babe5166779955e4 3f90ac3ec03512e2374cd2968c047a7e856a8965 ea6d3cd1ed79d824e605a70c3626bc437c386260 ef88eeaf052c8a7d28c5f85e790c5e45bcffa45e 119c98972c4e737508df827bbbc8453cc93292c7 171779 [host=rochester1] 171814 pass a4d97f0c199e980bb55d3b659214308c1b371b73 320f92c36a80bfafc5d57834592a7be5fd79f104 558d83ab1a5179e146a56dd5f3cb16e1ca44ff46 ea6d3cd1ed79d824e605a70c3626bc437c386260 7292e4a0a8f58333ccbd2d0d47242f9865083c9c cbfa62bb140c8f10a0ae96db3ce06e22b3b9d302 171782 [host=rochester1] 171784 [host=rochester1] 171815 pass a4d97f0c199e980bb55d3b659214308c1b371b73 da30b01ffaf702db082cd01ba594dd4fb4143e58 9ec2cc1f3138ef9314314df29fc6ce0aa5e120b9 ea6d3cd1ed79d824e605a70c3626bc437c386260 6a62e0cb0dfe9cd28b70547dbea5caf76847c3a9 f1e268b9fd13647e1f69c8ce0ae7be401d319fc8 171816 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 88f3d734f5a066491d6da3cddcacc6cd7f07d184 ea6d3cd1ed79d824e605a70c3626bc437c386260 01774004c7f7fdc9c1e8f1715f70d3b913f8d491 e270af94280e6a9610705ebc1fdd1d7a9b1f8a98 171785 [host=rochester1] 171818 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae df1c7e91b46db364ba1ce5e21660987c29c35334 ea6d3cd1ed79d824e605a70c3626bc437c386260 dc88f9b72df52b22c35b127b80c487e0b6fca4af 49dd52fb1311dadab29f6634d0bc1f4c022c357a 171787 [host=rochester1] 171791 [host=rochester1] 171820 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae b600f253b3077943908431cd780dbc1a9ed1bc81 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 dc88f9b72df52b22c35b127b80c487e0b6fca4af 0544c4ee4b48f7e2715e69ff3e73c3d5545b0526 171793 [host=rochester1] 171821 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 12dd064a1804536518eb12229836fa572c232502 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 ee3810899181170d21ab2c4e1aeba8dcdcd6f2b6 171801 [host=rochester1] 171822 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae fc4a132c0e9d108d30115cb8729f8fcd5564b855 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 4f67f1cbb66e96769557863e1734fa465b73b6db 171802 [host=rochester1] 171795 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 5a3641bfcdcf99fd76817833488f2af8abb69383 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171825 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 24eac4caf31afae48349af44588a52783c1819b8 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf 171826 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 d2cc5633e2800e698c6a64554de7fa19d9627a24 171803 [host=rochester1] 171827 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 7ef91af84c04b1e5a17631bd1811c9bc1945dfdc b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 aa45ffc115e6e2b31baff81a5294c5ac7b8c6b9d 171829 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171828 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 6964b5c48c69e4961bad2dd9d6c02918f23c3be0 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171833 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171835 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171836 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171837 pass a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 171838 fail 510540961417288a24d0870f0226f8255420c463 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 Searching for interesting versions Result found: flight 151754 (pass), for basis pass For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506, results HASH(0x55a037880cd8) HASH(0x55a03784a9e8) HASH(0x55a03788c850) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 7ef91af84\ c04b1e5a17631bd1811c9bc1945dfdc b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 aa45ffc115e6e2b31baff81a5294c5ac7b8c6b9d, results HASH(0x55a03787ccc8) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 48249243777882d7d89ca0b86c89e355b5f941f3 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 d2cc5633e2800e698c6a64554de7fa19d9627a24, results HASH(0x55a03787\ 8690) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 24eac4caf31afae48349af44588a52783c1819b8 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 c16a9eda77b2089206d5bc39ab6488c3793e11bf, results HASH(0x55a037875460) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae fc4a132c0e9d108d30115cb8729f8fcd5564b855 b7464\ 58e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 4f67f1cbb66e96769557863e1734fa465b73b6db, results HASH(0x55a03786d418) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 12dd064a1804536518eb12229836fa572c232502 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 ee3810899181170d21ab2c4e1aeba8dcdcd6f2b6, results HASH(0x55a037866ad8) For basis failure, parent searc\ h stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae b600f253b3077943908431cd780dbc1a9ed1bc81 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 dc88f9b72df52b22c35b127b80c487e0b6fca4af 0544c4ee4b48f7e2715e69ff3e73c3d5545b0526, results HASH(0x55a037840c98) For basis failure, parent search stopping at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae df1c7e91b46db364ba1ce5e21660987c29c35334 ea6d3cd1ed79d824e605a70c3626bc437c386260 d\ c88f9b72df52b22c35b127b80c487e0b6fca4af 49dd52fb1311dadab29f6634d0bc1f4c022c357a, results HASH(0x55a037831710) Result found: flight 171795 (fail), for basis failure (at ancestor ~589) Repro found: flight 171804 (pass), for basis pass Repro found: flight 171828 (fail), for basis failure 0 revisions at a4d97f0c199e980bb55d3b659214308c1b371b73 57ba70da5312170883a3d622cd2aa3fd0e2ec7ae 343f37b5c07fd261b0fe8f3236459c9071be38b7 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 46de2eec93bffa0706e6229c0da2919763c8eb04 fcd27b3c759995775afb66be6bb7ba1e85da0506 No revisions left to test, checking graph state. Result found: flight 171829 (pass), for last pass Result found: flight 171833 (fail), for first failure Repro found: flight 171835 (pass), for last pass Repro found: flight 171836 (fail), for first failure Repro found: flight 171837 (pass), for last pass Repro found: flight 171838 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: libvirt git://libvirt.org/libvirt.git Bug introduced: 510540961417288a24d0870f0226f8255420c463 Bug not present: a4d97f0c199e980bb55d3b659214308c1b371b73 Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171838/ (Revision log too long, omitted.) neato: graph is too large for cairo-renderer bitmaps. Scaling by 0.106438 to fit pnmtopng: 10 colors found Revision graph left in /home/logs/results/bisect/libvirt/build-arm64-libvirt.libvirt-build.{dot,ps,png,html,svg}. ---------------------------------------- 171838: tolerable ALL FAIL flight 171838 libvirt real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/171838/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail baseline untested jobs: build-arm64-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Sun Jul 24 11:35:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 11:35:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373967.606197 (Exim 4.92) (envelope-from ) id 1oFZsw-0008F0-P9; Sun, 24 Jul 2022 11:34:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373967.606197; Sun, 24 Jul 2022 11:34:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFZsw-0008Et-Mb; Sun, 24 Jul 2022 11:34:58 +0000 Received: by outflank-mailman (input) for mailman id 373967; Sun, 24 Jul 2022 11:34:57 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFZsv-0008Ej-OA; Sun, 24 Jul 2022 11:34:57 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFZsv-0005lo-9A; Sun, 24 Jul 2022 11:34:57 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFZsv-0002rs-2B; Sun, 24 Jul 2022 11:34:57 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFZsv-0005Lu-1i; Sun, 24 Jul 2022 11:34:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VuEOasJBu98+uYJ5gFiBYE3dv3NMy8SIAOtTJc/ajxo=; b=nqapMs3CcsN+S0Do05Xs+22m4I i6fQfwczZc5O7qFkz9hKcdP8/ood8YLwmqjlPYgxL7+9W6WY5/gp4i/2lbuv6Th0saetAhIhF8HZZ 3DBC/ie+vay8yn6Rx+fi8ttAC7iXXp0TdykLsxUwvesMmB9cQ2bZZVc8dmMfRDvDRrVw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171834: all pass - PUSHED X-Osstest-Versions-This: ovmf=d32a84b5ad8eb5293710ca83dad2b4686479b653 X-Osstest-Versions-That: ovmf=6964b5c48c69e4961bad2dd9d6c02918f23c3be0 From: osstest service owner Date: Sun, 24 Jul 2022 11:34:57 +0000 flight 171834 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171834/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf d32a84b5ad8eb5293710ca83dad2b4686479b653 baseline version: ovmf 6964b5c48c69e4961bad2dd9d6c02918f23c3be0 Last test of basis 171800 2022-07-23 06:11:59 Z 1 days Testing same since 171834 2022-07-24 07:10:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Li, Yi1 Yi Li jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 6964b5c48c..d32a84b5ad d32a84b5ad8eb5293710ca83dad2b4686479b653 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 24 12:59:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 12:59:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.373999.606209 (Exim 4.92) (envelope-from ) id 1oFbCP-0000zx-Sk; Sun, 24 Jul 2022 12:59:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 373999.606209; Sun, 24 Jul 2022 12:59:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFbCP-0000zq-Pz; Sun, 24 Jul 2022 12:59:09 +0000 Received: by outflank-mailman (input) for mailman id 373999; Sun, 24 Jul 2022 12:59:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFbCO-0000zg-5Q; Sun, 24 Jul 2022 12:59:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFbCO-0007dY-1v; Sun, 24 Jul 2022 12:59:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFbCN-0004yt-JU; Sun, 24 Jul 2022 12:59:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFbCN-0001w2-J1; Sun, 24 Jul 2022 12:59:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Y5zTIKLzW1A/txeY6oTDwHVN3TJP72h6Zr0gnNKdPwg=; b=UcLbC/Rj1mCF3b0GiXKh+9oYzD 44X11CF1DZOeRCXVZsEG2abAhwVEtAW9Twuq7ba7hiLrjLpyOqIP/gt/LzDbJkpQW+vB5iHcwd+hB f6cBdBiE3U8M6fSmDgKOV5Hy2E7OzR0ijeIKyUmgnIItUPBkIqpTTq+8LlCMq3hLTBJo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171831: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-raw:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-libvirt-qcow2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sun, 24 Jul 2022 12:59:07 +0000 flight 171831 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171831/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 14 guest-start fail in 171807 pass in 171831 test-armhf-armhf-libvirt-raw 13 guest-start fail in 171807 pass in 171831 test-armhf-armhf-libvirt-qcow2 13 guest-start fail in 171807 pass in 171831 test-armhf-armhf-xl-credit2 14 guest-start fail in 171819 pass in 171831 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171807 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 171819 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171807 like 171642 test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171807 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171807 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 171807 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 171807 never pass test-armhf-armhf-xl-credit1 18 guest-start/debian.repeat fail in 171819 blocked in 171642 test-armhf-armhf-xl-credit1 15 migrate-support-check fail in 171819 never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail in 171819 never pass test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 8 days Testing same since 171743 2022-07-21 19:11:46 Z 2 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 24 13:54:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 13:54:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374027.606220 (Exim 4.92) (envelope-from ) id 1oFc4E-0007wq-3H; Sun, 24 Jul 2022 13:54:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374027.606220; Sun, 24 Jul 2022 13:54:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFc4D-0007wj-VQ; Sun, 24 Jul 2022 13:54:45 +0000 Received: by outflank-mailman (input) for mailman id 374027; Sun, 24 Jul 2022 13:54:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFc4D-0007wZ-4J; Sun, 24 Jul 2022 13:54:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFc4D-0000Qz-2Q; Sun, 24 Jul 2022 13:54:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFc4C-0006aX-Jq; Sun, 24 Jul 2022 13:54:44 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFc4C-00045Z-JN; Sun, 24 Jul 2022 13:54:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WauBCrU0voTnsIr6bTYv4qWHamwLIvFiJOg2a1PqUig=; b=usr3HecSdRjBEzpJ4qEJ5mcyc4 nS73S2F4YGQi5wWtcRsPqyGvpnGatFQyZ8yFnfyzZhsDuobYJPrN3gWa2Hm+gupcEXCu7ZGqYp5rs LINhSa7JncIf0IG+VwzZKvwYIvwDC3CM1flU81ladkQCtTBJmMwg2SFbw/qSG+41BEvQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171841: all pass - PUSHED X-Osstest-Versions-This: ovmf=8ee26529d1b554a31c1041f0b9ed4e2dd250bd7a X-Osstest-Versions-That: ovmf=d32a84b5ad8eb5293710ca83dad2b4686479b653 From: osstest service owner Date: Sun, 24 Jul 2022 13:54:44 +0000 flight 171841 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171841/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8ee26529d1b554a31c1041f0b9ed4e2dd250bd7a baseline version: ovmf d32a84b5ad8eb5293710ca83dad2b4686479b653 Last test of basis 171834 2022-07-24 07:10:34 Z 0 days Testing same since 171841 2022-07-24 11:40:22 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Aladyshev jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git d32a84b5ad..8ee26529d1 8ee26529d1b554a31c1041f0b9ed4e2dd250bd7a -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 24 16:51:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 16:51:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374180.606285 (Exim 4.92) (envelope-from ) id 1oFeoc-00062F-1n; Sun, 24 Jul 2022 16:50:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374180.606285; Sun, 24 Jul 2022 16:50:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFeob-000628-VJ; Sun, 24 Jul 2022 16:50:49 +0000 Received: by outflank-mailman (input) for mailman id 374180; Sun, 24 Jul 2022 16:50:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFeoa-00061y-Fv; Sun, 24 Jul 2022 16:50:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFeoa-0004uz-D8; Sun, 24 Jul 2022 16:50:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFeoa-0008Rj-5J; Sun, 24 Jul 2022 16:50:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFeoa-0004jf-4p; Sun, 24 Jul 2022 16:50:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=6PsmIGIlwPq2KRDIXFGlvH2VaGK17daDfEAH5kp6fUQ=; b=kQSd77CGWHeKjnDRuOLXJfG8qM 9P8e9iMzeEFCcctmHtxVrk6ai2+qZ+xeqOoCvayUZ1sjvU5iP/jNMstovsVFeNgQORReChEh/PzFc 7TioE629gVPZ8gyAHywGHwfa3epCk9snZH12mXlpeKc+65F0Kw04C8hmuIv8Aou3v5m4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171843: all pass - PUSHED X-Osstest-Versions-This: ovmf=c0b7679aac90ab6c757bbc61ac4ccfa293ab14df X-Osstest-Versions-That: ovmf=8ee26529d1b554a31c1041f0b9ed4e2dd250bd7a From: osstest service owner Date: Sun, 24 Jul 2022 16:50:48 +0000 flight 171843 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171843/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf c0b7679aac90ab6c757bbc61ac4ccfa293ab14df baseline version: ovmf 8ee26529d1b554a31c1041f0b9ed4e2dd250bd7a Last test of basis 171841 2022-07-24 11:40:22 Z 0 days Testing same since 171843 2022-07-24 14:13:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Aladyshev jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8ee26529d1..c0b7679aac c0b7679aac90ab6c757bbc61ac4ccfa293ab14df -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 24 17:20:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 17:20:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374195.606300 (Exim 4.92) (envelope-from ) id 1oFfH6-0001Vm-D8; Sun, 24 Jul 2022 17:20:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374195.606300; Sun, 24 Jul 2022 17:20:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFfH6-0001Vf-Aa; Sun, 24 Jul 2022 17:20:16 +0000 Received: by outflank-mailman (input) for mailman id 374195; Sun, 24 Jul 2022 17:20:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFfH4-0001VZ-Vy for xen-devel@lists.xenproject.org; Sun, 24 Jul 2022 17:20:15 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e0f6a3a6-0b74-11ed-bd2d-47488cf2e6aa; Sun, 24 Jul 2022 19:20:13 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id sz17so16639985ejc.9 for ; Sun, 24 Jul 2022 10:20:13 -0700 (PDT) Received: from [192.168.8.105] (adsl-30.37.6.163.tellas.gr. [37.6.163.30]) by smtp.gmail.com with ESMTPSA id u18-20020a056402111200b0043bb892a86csm5822853edv.69.2022.07.24.10.20.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jul 2022 10:20:12 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e0f6a3a6-0b74-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1jFB94iK6Ya6i/rotTW4zhaqD4q99vuq9m6m8IMQHjg=; b=eb/Fg6ID2KMg2vXbTay+5005a6SUfJLoNmW9RbkRJ5b4CQ3jbsgJgLm6QezrMTft+A BJUfOdWBT1WTPmxgVQSYCQ+eeNZGJpmJa1L4ZxUPTPe+ey3NmBNHY7hapV6/NSsGaiKP GBnjZ8qRxp+hLHqDgi8b7cCG7R/2FSjlDH7AqkW/UAbJ/Kk4/zwo5u8UhN76CovMbVsV KKzm1WuJ9R4zCX5LLGxzssPZucr+aaEAKnWOeSwwtw8tRFMMKn03ptsUk4H2+0m4SX91 0nOy+8X4cwcgEFTWTT3KwhIYruWyzPD4l43dG7UyMqwBYgVrDp7yaq3tQJV58Fwpn+tT WOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1jFB94iK6Ya6i/rotTW4zhaqD4q99vuq9m6m8IMQHjg=; b=sEIMnhjprQfjQzbEl1ZqCVS3ADUIvG5tpPrwJchz514tzwGem/s14P8Nw/cOkCKP2S yA4KA1wfT135YqobJt0hQm8w0Ct4VAGwipVY80nvIvKtIV4QnRvXj9o9rbdQNBHgraLn SXe8JjEkDdC3cE0EyJpGh5PskNYB6aI7WzcnyWaYBTxqhyITl3GChyrzUgNKC0QVxG9/ 4IT4uaw7qgOIbaGYbVIcTAXio7iFHXWYIDqM5G4+AjOixvOW4CmQFRhGe4Shp595+qoX s315fef+kD68Uk3+vIDM4T4TcfEsR0LURjx6+ABybx8UKyzvCEV9cDtvqlBUt/II3mJb BiWg== X-Gm-Message-State: AJIora+aA6XnN0WYi8UGKbfn1+qWusnCf+QuQ2bGVZL/fTg/2uFyhCFj cNvjCxW/dH8/VvsqZzfZuuINv/38HwQ= X-Google-Smtp-Source: AGRyM1vAJiAarmqInubULpKbVkHgo1ZczYrpfXC+F7vma9xFqmiauskhZ55RSRqsiFxggOuAdPoo3g== X-Received: by 2002:a17:907:a061:b0:72f:1dde:fac0 with SMTP id ia1-20020a170907a06100b0072f1ddefac0mr6923284ejc.310.1658683213238; Sun, 24 Jul 2022 10:20:13 -0700 (PDT) Message-ID: Date: Sun, 24 Jul 2022 20:20:10 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/7/22 10:55, Jan Beulich wrote: > On 07.07.2022 09:27, Xenia Ragiadakou wrote: >> On 7/6/22 11:51, Jan Beulich wrote: >>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>> The function idle_loop() is referenced only in domain.c. >>>>>> Change its linkage from external to internal by adding the storage-class >>>>>> specifier static to its definitions. >>>>>> >>>>>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>>>>> attribute to suppress unused-function compiler warning. >>>>> >>>>> While I see that Julien has already acked the patch, I'd like to point >>>>> out that using __used here is somewhat bogus. Imo the better approach >>>>> is to properly make visible to the compiler that the symbol is used by >>>>> the asm(), by adding a fake(?) input. >>>> >>>> I 'm afraid I do not understand what do you mean by "adding a fake(?) >>>> input". Can you please elaborate a little on your suggestion? >>> >>> Once the asm() in question takes the function as an input, the compiler >>> will know that the function has a user (unless, of course, it finds a >>> way to elide the asm() itself). The "fake(?)" was because I'm not deeply >>> enough into Arm inline assembly to know whether the input could then >>> also be used as an instruction operand (which imo would be preferable) - >>> if it can't (e.g. because there's no suitable constraint or operand >>> modifier), it still can be an input just to inform the compiler. >> >> According to the following statement, your approach is the recommended one: >> "To prevent the compiler from removing global data or functions which >> are referenced from inline assembly statements, you can: >> -use __attribute__((used)) with the global data or functions. >> -pass the reference to global data or functions as operands to inline >> assembly statements. >> Arm recommends passing the reference to global data or functions as >> operands to inline assembly statements so that if the final image does >> not require the inline assembly statements and the referenced global >> data or function, then they can be removed." >> >> IIUC, you are suggesting to change >> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) >> into >> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); > > Yes, except that I can't judge about the "S" constraint. > This constraint does not work for arm32. Any other thoughts? Another way, as Jan suggested, is to pass the function as a 'fake' (unused) input. I 'm suspecting something like the following could work asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory") What do you think? >> This gives, respectively: >> reset_stack_and_jump(idle_loop); >> >> 460: 9100001f mov sp, x0 >> >> 464: 14000007 b 480 >> >> >> reset_stack_and_jump(idle_loop); >> >> 460: 9100001f mov sp, x0 >> >> 464: 14000000 b 600 >> >> >> With this change, the functions return_to_new_vcpu32 and >> return_to_new_vcpu64, implemented in assembly and called in the same way >> as idle_loop(), need to be declared. > > Which imo is a good thing - these probably shouldn't have lived entirely > behind the back of the compiler. > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Sun Jul 24 17:32:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 17:32:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374201.606311 (Exim 4.92) (envelope-from ) id 1oFfSj-00039j-FG; Sun, 24 Jul 2022 17:32:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374201.606311; Sun, 24 Jul 2022 17:32:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFfSj-00039c-CW; Sun, 24 Jul 2022 17:32:17 +0000 Received: by outflank-mailman (input) for mailman id 374201; Sun, 24 Jul 2022 17:32:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFfSi-00039W-Ev for xen-devel@lists.xenproject.org; Sun, 24 Jul 2022 17:32:16 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8ef30640-0b76-11ed-924f-1f966e50362f; Sun, 24 Jul 2022 19:32:15 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id mf4so16706276ejc.3 for ; Sun, 24 Jul 2022 10:32:15 -0700 (PDT) Received: from uni.. (adsl-30.37.6.163.tellas.gr. [37.6.163.30]) by smtp.googlemail.com with ESMTPSA id y19-20020aa7d513000000b0043a7293a03dsm5964351edq.7.2022.07.24.10.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 Jul 2022 10:32:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ef30640-0b76-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wGdFeGO04cPBh2TJfksxWvjBkowEnAQJN4GYEqmgdUE=; b=j5Eh7XR9052VdETaWLq4ngqaJ/QDyMBi1T+t3pPh3KKEZl7FGP+mXajO5jR2KuRTAi ZhY2bsJCTz2hCV7h6GoWTi6mww0Ma52B0g7wzHCYP3NiKIvaQfCYs9TOupY1jjQoauSk v34sPVk0508R8Nkc/2hSH8q7mVu+4kmferR5jRm2mYqPvDqxzGEtNVD7egaqJH+ncBEu tp+n3PbvX22C9Nw2/HGgRYHvbMQZlgqFVhWifaQwRcHSuKi4qzxtodjtCn1Btd43mUUr T/QUC/WV5/wCKvW31E9FJfptgG43nHe5LrrDIdUm5WAYWBNUVCNu7H15MPAlbM8DfEUc gPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wGdFeGO04cPBh2TJfksxWvjBkowEnAQJN4GYEqmgdUE=; b=wcjuGtdcblB47AJVv8lp+yR+CHGZNY0D1s2THqleNPVYw5t8TKOShW8zBzUvU0NdHv GEJSPu9VjG6EHnKgJ1DhcnOmLmJHLfPOo6Bj/vO4nB9KlIkDUo4k2UIvGR3mW6GP7Hm7 f+Q5tdiOUpkzslMb7a5+ZK/gg/xXbZxlgrztwX8fAx6fVhqoH3EA5mp9IkwbcOHmsrvb TzhP/7M8Gqh6PyW2j0Ac9XiL9eRuAa3xFTtka+ibM8GrFw+Z98vVLFUx5Un35YSTWJ0u rT7zmEQpAy4JQdQmTSYKe2VXEeREgf4Ati6R4yLqpbhkct+SKEmWs9SNM1Wiw1+t16V2 BIXA== X-Gm-Message-State: AJIora8ZfZwTmlZCCbi8GhwOQBA3762HVjPDMU63l3zqowKE3OG4/qZT NaGKXlf0jBAKNAdM4O1zugOBWP4vOnw= X-Google-Smtp-Source: AGRyM1uoYKr7LBwVgS+mFk+HjV3K0z2Cti4RUJqHqbiqU+1AeV+ViAxtsbHlDVzhDlVmoA4i4ghBWw== X-Received: by 2002:a17:906:49d4:b0:6d6:e5ec:9a23 with SMTP id w20-20020a17090649d400b006d6e5ec9a23mr7262208ejv.79.1658683934394; Sun, 24 Jul 2022 10:32:14 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Juergen Gross Subject: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently Date: Sun, 24 Jul 2022 20:31:59 +0300 Message-Id: <20220724173159.410535-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function snprintf() returns the number of characters that would have been written in the buffer if the buffer size had been sufficiently large, not counting the terminating null character. Hence, the value returned is not guaranteed to be smaller than the buffer size. Check the return value of snprintf to prevent leaking stack contents to the guest by accident. Signed-off-by: Xenia Ragiadakou --- I 've noticed that in general in xen the return value of snprintf is not checked. Is there a particular reason for this? I mean if there is no space to fit the entire string, is it preferable to write only a part of it instead of failing? If that's the case, then scnprintf could be used instead below. xen/common/hypfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/common/hypfs.c b/xen/common/hypfs.c index acd258edf2..66026ad3e0 100644 --- a/xen/common/hypfs.c +++ b/xen/common/hypfs.c @@ -377,6 +377,8 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template, unsigned int e_namelen, e_len; e_namelen = snprintf(name, sizeof(name), template->e.name, id); + if ( e_namelen >= sizeof(name) ) + return -ENOBUFS; e_len = DIRENTRY_SIZE(e_namelen); direntry.e.pad = 0; direntry.e.type = template->e.type; -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Sun Jul 24 18:29:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 18:29:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374215.606322 (Exim 4.92) (envelope-from ) id 1oFgME-0000nX-Ny; Sun, 24 Jul 2022 18:29:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374215.606322; Sun, 24 Jul 2022 18:29:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFgME-0000nQ-LM; Sun, 24 Jul 2022 18:29:38 +0000 Received: by outflank-mailman (input) for mailman id 374215; Sun, 24 Jul 2022 18:29:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFgMD-0000nG-Hu; Sun, 24 Jul 2022 18:29:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFgMD-00078w-Dy; Sun, 24 Jul 2022 18:29:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFgMC-0002zU-GP; Sun, 24 Jul 2022 18:29:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFgMC-0006CC-Fw; Sun, 24 Jul 2022 18:29:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=a8njRZuANKi1cn/ZgzKfmtA9rKYQgdy2QWNI22vU4OQ=; b=2V2Dh77jzHzPHmv/6ebMGFb2xo NixsCo+vGFrVDXcOIF+z+gAfTruFEZMcn0vH2665wQ91uSKzFkT0W4zk3xA5Gg3NIR7gQuNc99eZ7 F3sh3siQHpgBYHMg3QQ/2hoeQ1IgCVmK6nHqsLbgC38q0RxUuzM/3VFhrxG0Wspd/tTs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171842: regressions - FAIL X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:regression linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Sun, 24 Jul 2022 18:29:36 +0000 flight 171842 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171842/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail REGR. vs. 171642 Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-rtds 14 guest-start fail in 171831 pass in 171842 test-armhf-armhf-xl-vhd 13 guest-start fail in 171831 pass in 171842 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171831 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail like 171642 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 9 days Testing same since 171743 2022-07-21 19:11:46 Z 2 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu fail test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 1917 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 24 19:15:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 19:15:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374235.606334 (Exim 4.92) (envelope-from ) id 1oFh4T-0006Ra-8x; Sun, 24 Jul 2022 19:15:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374235.606334; Sun, 24 Jul 2022 19:15:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFh4T-0006RT-5l; Sun, 24 Jul 2022 19:15:21 +0000 Received: by outflank-mailman (input) for mailman id 374235; Sun, 24 Jul 2022 19:15:19 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFh4R-0006RH-HU; Sun, 24 Jul 2022 19:15:19 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFh4R-0008Eh-AO; Sun, 24 Jul 2022 19:15:19 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFh4Q-0005XL-V0; Sun, 24 Jul 2022 19:15:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFh4Q-0000dG-UZ; Sun, 24 Jul 2022 19:15:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=MpT5bnG9SUkMsoDCsTCPWHh3O53jzeFnF0pf8+tp0/g=; b=cSS0rD84E0agIGGprZH9qUzXLJ ZbRxjW3OYhB9YgQEvpAjfrRx8nuCAL9fcWI9FfeGhInglUKzg8Yf2WM8xLx302xd3X4B4i/NxAJXo 2W7ykuJ/laZcJIUBZ1KUd0HQGr0M8+a1VUMYuDy2fcjVZXYY/g0MJHXbY0iCIDSQdaiY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171845: all pass - PUSHED X-Osstest-Versions-This: ovmf=fca5de51e1fd2f3c5ddbf5974d785f0f6b2f6c38 X-Osstest-Versions-That: ovmf=c0b7679aac90ab6c757bbc61ac4ccfa293ab14df From: osstest service owner Date: Sun, 24 Jul 2022 19:15:18 +0000 flight 171845 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171845/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf fca5de51e1fd2f3c5ddbf5974d785f0f6b2f6c38 baseline version: ovmf c0b7679aac90ab6c757bbc61ac4ccfa293ab14df Last test of basis 171843 2022-07-24 14:13:09 Z 0 days Testing same since 171845 2022-07-24 17:11:43 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Aladyshev jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git c0b7679aac..fca5de51e1 fca5de51e1fd2f3c5ddbf5974d785f0f6b2f6c38 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 24 23:29:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 24 Jul 2022 23:29:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374332.606362 (Exim 4.92) (envelope-from ) id 1oFl2X-00008U-Dd; Sun, 24 Jul 2022 23:29:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374332.606362; Sun, 24 Jul 2022 23:29:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFl2X-00008N-Af; Sun, 24 Jul 2022 23:29:37 +0000 Received: by outflank-mailman (input) for mailman id 374332; Sun, 24 Jul 2022 23:29:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFl2V-00008C-V5; Sun, 24 Jul 2022 23:29:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFl2V-0005OI-Se; Sun, 24 Jul 2022 23:29:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFl2U-0003SC-OB; Sun, 24 Jul 2022 23:29:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFl2U-0004Y4-NA; Sun, 24 Jul 2022 23:29:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ChnmvXEkBD46enBosSE5sq4u0SGrmV6twzg4kYjzv6c=; b=QppOCJXlPVSBa5yiz6nRVlTXrz 3RfKNowwZdfYN+4C2dDvWYvQHpbYgI0PfiXoJHoOpYNJGFtpcAEfy3JiE0SADSIwPinaDyfjyKaLe jn3K9c18G5k1Q0Tyt+aC+mDtBQIqFFGb9yhTYFt/D0aNPcV+NPs47soNEk6XWA1aly/E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171844: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=af2c9ac24019ece9281e606662e5c78fa67f5930 X-Osstest-Versions-That: linux=515f71412bb73ebd7f41f90e1684fc80b8730789 From: osstest service owner Date: Sun, 24 Jul 2022 23:29:34 +0000 flight 171844 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171844/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail blocked in 171813 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171813 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171813 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171813 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171813 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171813 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171813 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171813 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux af2c9ac24019ece9281e606662e5c78fa67f5930 baseline version: linux 515f71412bb73ebd7f41f90e1684fc80b8730789 Last test of basis 171813 2022-07-23 18:10:08 Z 1 days Testing same since 171844 2022-07-24 17:11:08 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ben Hutchings Borislav Petkov Herve Codina Josh Poimboeuf Juri Lelli Kan Liang Kees Cook Linus Torvalds Michael Walle Pawan Gupta Peter Zijlstra (Intel) Peter Zijlstra Stephen Boyd Tom Lendacky jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 515f71412bb7..af2c9ac24019 af2c9ac24019ece9281e606662e5c78fa67f5930 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Jul 25 01:33:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 01:33:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374340.606374 (Exim 4.92) (envelope-from ) id 1oFmyB-0003z4-2E; Mon, 25 Jul 2022 01:33:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374340.606374; Mon, 25 Jul 2022 01:33:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFmyA-0003yw-SB; Mon, 25 Jul 2022 01:33:14 +0000 Received: by outflank-mailman (input) for mailman id 374340; Mon, 25 Jul 2022 01:33:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFmy9-0003ym-BA; Mon, 25 Jul 2022 01:33:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFmy9-00073j-7j; Mon, 25 Jul 2022 01:33:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFmy8-00019i-CW; Mon, 25 Jul 2022 01:33:12 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFmy8-0002ig-C5; Mon, 25 Jul 2022 01:33:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=8znbSP7GlUivkASeEG0ArNID+fe0M8htxQNeXKbuoZ4=; b=nqHr3Nb2f/E8aE0d2C8eYQUFeI FkNOoxLoOkwlWwUD4wHGyKjOjITB/1es2oVktAK2c6R8wODWoOQ+Q98FZkV4sB5PPbOEaQA5NkeO2 /TsrF8PjlZVnNZKyEJzmxwedqhsCIHz2NVOmM4sP0Rky4rldmJ4i/T/5AqU4r8vjg3jA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171846: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-multivcpu:guest-start/debian.repeat:fail:heisenbug linux-5.4:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug linux-5.4:test-amd64-i386-libvirt-raw:xen-install:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:heisenbug linux-5.4:test-armhf-armhf-xl-credit2:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 X-Osstest-Versions-That: linux=6584107915561f860b7b05dcca5c903dd62a308d From: osstest service owner Date: Mon, 25 Jul 2022 01:33:12 +0000 flight 171846 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171846/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-multivcpu 18 guest-start/debian.repeat fail in 171842 pass in 171846 test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail in 171842 pass in 171846 test-amd64-i386-libvirt-raw 7 xen-install fail pass in 171842 test-armhf-armhf-xl-credit2 14 guest-start fail pass in 171842 test-armhf-armhf-xl-rtds 14 guest-start fail pass in 171842 test-armhf-armhf-xl-vhd 13 guest-start fail pass in 171842 Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 18 guest-start/debian.repeat fail in 171842 like 171642 test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail in 171842 like 171642 test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 171842 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 171842 never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail in 171842 never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail in 171842 never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail in 171842 never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail in 171842 never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail in 171842 never pass test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171642 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-xl-credit1 14 guest-start fail like 171642 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171642 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171642 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171642 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171642 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 baseline version: linux 6584107915561f860b7b05dcca5c903dd62a308d Last test of basis 171642 2022-07-15 13:02:24 Z 9 days Testing same since 171743 2022-07-21 19:11:46 Z 3 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Alexandre Torgue Alyssa Rosenzweig Andrea Mayer Andrew Morton Ard Biesheuvel Arnd Bergmann Baokun Li Borislav Petkov Chanho Park Charles Keepax Chris Wilson Christoph Hellwig Claudiu Beznea Daniel Bristot de Oliveira David S. Miller Dmitry Osipenko Edward Cree Felix Fietkau Florian Fainelli Florian Westphal Francesco Dolcini Gabriel Fernandez Greg Kroah-Hartman Guenter Roeck Hangyu Hua Hans de Goede Huaxin Lu Hulk Robot Ilpo Järvinen Jakub Kicinski Jernej Skrabec Jianglei Nie Johan Hovold Johannes Berg Jon Hunter José Roberto de Souza Juergen Gross Kai-Heng Feng Kris Bahnsen Kuniyuki Iwashima Liang He Linus Torvalds Linus Walleij Linux Kernel Functional Testing Linyu Yuan Lucien Buchmann Luis Chamberlain Marc Kleine-Budde Marc Zyngier Mark Brown Mark-PK Tsai Martin Habets Mauro Carvalho Chehab Mel Gorman Meng Tang Michael S. Tsirkin Michael Walle Michal Hocko Michal Suchanek Mimi Zohar Muchun Song Nicolas Dichtel Nuno Gonçalves Pablo Neira Ayuso Paolo Abeni Paul Moore Peter Zijlstra (Intel) Rodrigo Vivi Ruozhu Li Russell King (Oracle) Ryan Wanner Ryusuke Konishi Sasha Levin Shawn Guo Stafford Horne Stephan Gerhold Steven Price Steven Rostedt (Google) Sudip Mukherjee Sudip Mukherjee Tadeusz Struk Takashi Iwai Tejun Heo Theodore Ts'o Thinh Nguyen Thomas Hellström Viresh Kumar Wei Wang Xiu Jianfeng Yi Yang Zhen Lei Zheng Yejian Íñigo Huguet jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw fail test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 658410791556..002c3bbb4713 002c3bbb4713859e8f3d1e756637572a09dcca49 -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 02:29:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 02:29:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374350.606385 (Exim 4.92) (envelope-from ) id 1oFnqN-0001lY-Be; Mon, 25 Jul 2022 02:29:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374350.606385; Mon, 25 Jul 2022 02:29:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFnqN-0001lR-7u; Mon, 25 Jul 2022 02:29:15 +0000 Received: by outflank-mailman (input) for mailman id 374350; Mon, 25 Jul 2022 02:29:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFnqL-0001lL-T1 for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 02:29:14 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10076.outbound.protection.outlook.com [40.107.1.76]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90e04bf8-0bc1-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 04:29:10 +0200 (CEST) Received: from DB8PR06CA0003.eurprd06.prod.outlook.com (2603:10a6:10:100::16) by AM0PR08MB3587.eurprd08.prod.outlook.com (2603:10a6:208:dd::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Mon, 25 Jul 2022 02:29:08 +0000 Received: from DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:100:cafe::d1) by DB8PR06CA0003.outlook.office365.com (2603:10a6:10:100::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Mon, 25 Jul 2022 02:29:08 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT004.mail.protection.outlook.com (100.127.142.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Mon, 25 Jul 2022 02:29:08 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Mon, 25 Jul 2022 02:29:08 +0000 Received: from aac1fafe8fa5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 3F2ECD2C-CE9F-4069-B76F-2B7053D50ED5.1; Mon, 25 Jul 2022 02:29:01 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aac1fafe8fa5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Jul 2022 02:29:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by AS8PR08MB6839.eurprd08.prod.outlook.com (2603:10a6:20b:352::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 02:29:00 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::980a:f741:c4e1:82f7%7]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 02:29:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90e04bf8-0bc1-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LRDpEtbquqbKlZP6CJIrdW2BhesLKbM1i86l/Hzm5jej2LVUQ9v5FoSHn6KTlMb5X6x7ehF1IbtCH5xfJUPpONdlWgGi23l9iQ4zlKvjhgIBJOZ9XYO088/VkJwrqNXQI85KMVcfvdOHftmZtPeN/DmIuQWbHlkYzrFlnHbaOUs9tT9gQrIGjtGqcemUbAsuWUkr4vPJrrDqQWJ+gD+ugk+tajibajqY8cFqYIKK1Yhu76qnr06viDM36WD/ZEPboSGq+4X5pFGNVniMLV0RB2FDmYintSkD0VzaOIUVBDzWbi6oMwcjjNbKctwBcTkA3pSpaQn91Md9xT5zxR+0dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLuCzy+cN/I3v4U/f4R0TTbIF/bAwTpA+wkmXDvyB98=; b=bIdSH680XTuglP2vxSVM4eOn7/NWln1xYzaEb7qnJgHgs1sl3xtsRuG3ApuQVxFYyCAruRda83NStorRBUBWZv+flbaYfr1gmnVa9HFJq88sOftR5PWs7GLpxZxOVk7Heggeb/6zrhT/yh4vcJsUZvknPRVaNjQ3JtKhRGk7keyCFNrn/QsEcinlbvL3dnS87qf6L7j2M5caIgbRfyG4foJ70goTF1KBBBczQayVxACbH1fDRVDh8gGcZBKSzTZjDV6ofIyHAkLAaSN0Y7R0uCqgbxxnJQdIixqKWLXKQYoZnYvbypVSG88zrb2euCRKGMbiWbIsr6ayxtMxNNTRlg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLuCzy+cN/I3v4U/f4R0TTbIF/bAwTpA+wkmXDvyB98=; b=R2+/q+k2GuLPpNZCqXDmxX1G6lDovcMZZnAEsj9GysutEN1X/4pQzqLlwP4AQsVYdryiOwuePAqPS5creEHKCgZYOKwQNDHTWvsCnlNEmdJG9ZJ6CVMsat1bCd7Kg2uCjz2hAlMLbczPxNBNeSV5L3OQqXQiAvq99Sknbb/D0G0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: e8fe19ef822afd2d X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m91sS+XV/fgIZp2OCDH2FPK81Rb6MEcwqaC0hmBIVjuzFOrDQlzG4nOIIqmRTx9MjLV03dwcHli9SvMfNTCT3Ilfx2LOIZKXcK8fPSt8XwQDdCfp+WeWOPZ/xaLXss8054dd0sICn0zMI0BGxFAP/pWzxt0tkQyci6htdKyoYZKwsxf8A8UuEKUE9uHLEuFm47Jk0CtTn1z+YHh1p59A6UDWlUi4BI5Gs66KEINysquXkTsCmGrEpCdoNgKDBkZA5d8iFiXM/4AHKV1VUSUopLcukjU5/qNJHPruLaxz+8shm90p1Y7rV10w6ILyXcWsDd4VzZS7Ixd8Vl9sxqKG2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YLuCzy+cN/I3v4U/f4R0TTbIF/bAwTpA+wkmXDvyB98=; b=HTZ7go/UBUReQ/U3nv5fvBdZUSHngfCdBvoSz7S/eGWVSwhNCZLzoyjg/rBhLFpewS3QjwnuffhetJ2ojR7v1SPWxuP5nyMuCdlrueDPP7COfh+Nwcj/MIPY4PTFn9oHD55hPtk1rN3iz6dEJ7Av111dZXU9cBEbHxY94sXGSj2RLwIf5GfFSf5nDmht7dkJ725a7qp+kv/3wXJeM1508ZIaXXpGW+hVhb/wzMpqKhf01ZMAyzuW7SZKPBAPIqyfN0wy5VTevxGOQMbN6ou4O1NwFylOvSFU5nZV1FuhPE1yyw+D5Kj8J9Ime3yoDrKrwn1hp54xjQecQCyXPEcltw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLuCzy+cN/I3v4U/f4R0TTbIF/bAwTpA+wkmXDvyB98=; b=R2+/q+k2GuLPpNZCqXDmxX1G6lDovcMZZnAEsj9GysutEN1X/4pQzqLlwP4AQsVYdryiOwuePAqPS5creEHKCgZYOKwQNDHTWvsCnlNEmdJG9ZJ6CVMsat1bCd7Kg2uCjz2hAlMLbczPxNBNeSV5L3OQqXQiAvq99Sknbb/D0G0= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Message-ID: Date: Mon, 25 Jul 2022 10:28:52 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/9] xen/x86: Use enumerations to indicate NUMA status Content-Language: en-US To: Jan Beulich Cc: nd , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220708145424.1848572-1-wei.chen@arm.com> <20220708145424.1848572-3-wei.chen@arm.com> <66b4ce65-037c-a8cc-ce17-adfce7828a2f@suse.com> <41876fdf-862d-bb6a-7a34-0d1db9183716@suse.com> From: Wei Chen In-Reply-To: <41876fdf-862d-bb6a-7a34-0d1db9183716@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2P153CA0046.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c6::15) To PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1108af7c-de7e-4b24-6a54-08da6de57399 X-MS-TrafficTypeDiagnostic: AS8PR08MB6839:EE_|DBAEUR03FT004:EE_|AM0PR08MB3587:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: n4D1nNRSkTMfUB1iiP4bSAvJozGiDRaZPiZPXuf0YNKKz9KNMcTZVIODllXlg9Ez/2pxRV8duqn0lr0X/sIH7NKoT25CDGKrHJiNPi1BS7CmPnhZpYGvWEMcLnlk/AUWcxlygJIoJf1jHQtopw2fHJzW7bZJqTHWPrnX43GV2RfTHD/2vvJ6ri+DSooQ7Yvx+d2Yu4yKOHOAnyg2YMAa9y4hG+xN+Vme5rFx8zwbvREmqQLms378cZv6PFioj9rhvK5dBHGQ73m5+tKvBR4CTvvhQ422Ds1HgrJVEILE3QJrRsupWhduhWozmuG60HTkApWqvVWCrpvfD83Z0XvjlLbHelq6dc7EWoZ79ai6PT7MqoEFJ6qHzkdkM8GnWZnKPt8ZYy9mJQLdX9vE+E0123hhRU3BMjYpe6UWX5PUXMtTJiJ2Oe5y4WmBahM4uzBGdQEJvTU9+MAxh1dOkswmj/xPO+ZlT09o3qciqy0JEehRpcyejvf1Rp6K9QVOZiFf5bYsSou/03mw1F1QvhTi84VKxKDO3Tb9nP6n5BYDwEtVaOlo6AkRD1a50dMZcKnecDFBz5Y+EfAtX8eHtm3BDzoo/08ZW7aMQDizGKyCpIcO45g9D1bAq9r5LDIyEPo42gniotXFX8aU0nXTWYEKiUldfZyOF2YlhF/mHqs1dZgvlFj0eDEFEW0pVbhnUZzrTx1qMlL/LahDfsroAsO8K9vgg2w8NJ+uTuoiIG0xlyURtFS5/bUXR7ULPIJfhQyTGMmuUfXVpow8o8UW7HyBZkYo8C4icQhxwUswKY3csXerZZzAJ2IExWfnBE7Y/yRKMSny/IGgd5/JTO9NLrY8cw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(136003)(366004)(396003)(39860400002)(86362001)(31696002)(38100700002)(478600001)(6486002)(8936002)(5660300002)(316002)(6916009)(54906003)(8676002)(66946007)(4326008)(186003)(2616005)(83380400001)(6506007)(6666004)(53546011)(41300700001)(2906002)(26005)(6512007)(36756003)(66556008)(66476007)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6839 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81821316-2ed6-4737-7cef-08da6de56e87 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: chl/YPWhG1N+dtJ5Xl5VtPCtY7YKXEH502y/q48PldxMnxTY4V8Jy/hvokY2px+N3WRvMPqBHqc1FtYQkJ5WbxF0yfFtzpCdXRzpQ88ytsrfeAjIdj9eV+Z4ICc5Rpi75ZN+EOzbUuDaVjgN//RB9tvc4/Fudqjnbdy7RhZ/2ujkYtWxdqGt6METwb0uLE5IINtNefCr1NbiSXNCrA985Kr8MLH3dmF9uHru5iksHPCHSQNhuWa6VxhQzaB5iKO6mn956avc6znwo+nCSiD0zUY/hzCvbdsWz0glciQgQY0t9NMudZ2DDP5UI8zWLFB+HlJvHcchMS13jeOOPkKuFTS3GdSlSbenKhtqFDpMzdMI7+SECOGw80CFqdGR+1HpPyVdk3hibGwTEkQ/4SRf3qqJ0zwDlCNEvyDWW9+Bzvql5W8CKR8jq30h2cbIL9AlfoUoCUr4fqhjDtJttR14WxiMu2jiH4NkTu+8NrQY6BAAlkcaUVYw4cfLIas5HQy3iZw0UyDvNfRQgI0CE2amff27NMehuDdsQRNT+hqLmOPBL81En1H30j40CTdkMPKDD7q9/S7ZxTPvPsVNJzHAwzAVAEOQ+8+ogVth03Xi80EgQuwxpoPz4UrKjWqyetfd/jCt3rRDAU7NkVR8RDzwD6YtMRM3preLB/PdNWCQ0+WhzKojk9nbiL7TRDPHMe4whnvnkBMrlXQfJD62W/IykmAUlvdsxXHUmd1S9MPbd6ZZs99R2Ae1+pD4w/Z6/A9e8d/VQqgYcZhtcOZOSPk6gwsqgcV1NpPApGW8NRsMNwfGp9bS4AhuwleektgeV3Ma X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(46966006)(36840700001)(4326008)(8936002)(70206006)(6862004)(82310400005)(8676002)(40480700001)(2616005)(6666004)(5660300002)(36860700001)(36756003)(6512007)(2906002)(31696002)(86362001)(83380400001)(356005)(6486002)(26005)(336012)(82740400003)(478600001)(81166007)(54906003)(70586007)(316002)(41300700001)(47076005)(186003)(31686004)(53546011)(6506007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 02:29:08.0718 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1108af7c-de7e-4b24-6a54-08da6de57399 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT004.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3587 Hi Jan, On 2022/7/14 18:51, Jan Beulich wrote: >>> >>> No matter how many separate "numa=" parameters have been parsed from >>> Command line, the values of these original variables are determined >>> after parsing the command line. So the determined status can be mapped >>> to the new one variable from above table. >> >> Hmm, I was partly wrong - the initial values of both variables are >> indeed set from just the single "numa=" parsing. But later on they >> "evolve" independently, and multiple "numa=" on the command line >> can also have "interesting" effects. I'm afraid I still can't >> convince myself that the new mapping fully represents all originally >> possible combinations (nor can I convince myself that in the existing >> code everything is working as intended). > > Maybe the solution is to make numa_off common but keep acpi_numa > arch-specific? Then e.g. the replacement of srat_disabled() could > be > > int numa_disabled(void) > { > return numa_off || arch_numa_disabled(); > } > > with arch_numa_disabled() evaluating acpi_numa on x86. > While I am working on the new version, I think this may be not enough, we may need another helper like arch_handle_numa_param to prevent direct accessing of acpi_numa in numa_setup. Cheers, Wei Chen > Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 03:23:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 03:23:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374356.606396 (Exim 4.92) (envelope-from ) id 1oFogA-0000CH-6g; Mon, 25 Jul 2022 03:22:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374356.606396; Mon, 25 Jul 2022 03:22:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFogA-0000CA-3J; Mon, 25 Jul 2022 03:22:46 +0000 Received: by outflank-mailman (input) for mailman id 374356; Mon, 25 Jul 2022 03:22:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFog8-0000C2-Qv for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 03:22:44 +0000 Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0960d7e6-0bc9-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 05:22:41 +0200 (CEST) Received: from localhost.localdomain (c-174-62-72-237.hsd1.ca.comcast.net [174.62.72.237]) (authenticated bits=0) by d.mail.sonic.net (8.16.1/8.16.1) with ESMTPSA id 26P3LrEj027125 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Sun, 24 Jul 2022 20:22:37 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0960d7e6-0bc9-11ed-bd2d-47488cf2e6aa From: Sarah Newman To: xen-devel@lists.xenproject.org Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com, Sarah Newman Subject: [PATCH v2] livepatch: create-diff-object: Check that the section has a secsym Date: Sun, 24 Jul 2022 20:20:53 -0700 Message-Id: <20220725032053.12933-1-sarah.newman@computer.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Sonic-CAuth: UmFuZG9tSVZoC1vw7S/DCY/pzLZLUesW5RkI/M5t3vi1cuMydmAvHEj1dz9TptErxRVfVfXjX1+yIR5WZeeqT3dh8Q67NO41 X-Sonic-ID: C;iB7f7cgL7RGZuLBQfcNRkQ== M;YmcaCMkL7RGZuLBQfcNRkQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it. Origin: https://github.com/dynup/kpatch.git ba3defa06073 Signed-off-by: Sarah Newman --- Changes in v2: - commit message changed to use Origin --- create-diff-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-diff-object.c b/create-diff-object.c index a516670..780e6c8 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf) list_for_each_entry(sec, &kelf->sections, list) { if (is_debug_section(sec)) { sec->include = 1; - if (!is_rela_section(sec)) + if (!is_rela_section(sec) && sec->secsym) sec->secsym->include = 1; } } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 05:01:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 05:01:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374383.606407 (Exim 4.92) (envelope-from ) id 1oFqDi-0002xW-57; Mon, 25 Jul 2022 05:01:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374383.606407; Mon, 25 Jul 2022 05:01:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqDi-0002xP-1Z; Mon, 25 Jul 2022 05:01:30 +0000 Received: by outflank-mailman (input) for mailman id 374383; Mon, 25 Jul 2022 05:01:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqDh-0002xF-05; Mon, 25 Jul 2022 05:01:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqDg-0004dz-TG; Mon, 25 Jul 2022 05:01:28 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqDg-0001KY-GZ; Mon, 25 Jul 2022 05:01:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFqDg-0004ZN-Fo; Mon, 25 Jul 2022 05:01:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Ap3IKGAoR5qRNsCAgXwTh9asl/UQV8USsJ/93Ey2Q5U=; b=FnwCqL3b9XMrGHlVqRs5YDv/nA hf90qNKZU5hTt4kTSmSrRDncjoR/N0sGYj38aHDCRi+Gb1BuW00waTFz+rQ4UkujZFYU9bUkY/kI1 tt1c8o+Jk+6CV5T87ESTW6+PqCtB2ZrMU6r7A6ezAAxkRkVTL9boD88+3Q9hon3uGKtI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171849: all pass - PUSHED X-Osstest-Versions-This: ovmf=8a5782d704cfeb78aafdec1c03685107586f4ee6 X-Osstest-Versions-That: ovmf=fca5de51e1fd2f3c5ddbf5974d785f0f6b2f6c38 From: osstest service owner Date: Mon, 25 Jul 2022 05:01:28 +0000 flight 171849 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171849/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 8a5782d704cfeb78aafdec1c03685107586f4ee6 baseline version: ovmf fca5de51e1fd2f3c5ddbf5974d785f0f6b2f6c38 Last test of basis 171845 2022-07-24 17:11:43 Z 0 days Testing same since 171849 2022-07-25 02:42:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Zhiguang Liu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git fca5de51e1..8a5782d704 8a5782d704cfeb78aafdec1c03685107586f4ee6 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 25 05:09:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 05:09:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374391.606417 (Exim 4.92) (envelope-from ) id 1oFqLE-0003jH-Uo; Mon, 25 Jul 2022 05:09:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374391.606417; Mon, 25 Jul 2022 05:09:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqLE-0003jA-S9; Mon, 25 Jul 2022 05:09:16 +0000 Received: by outflank-mailman (input) for mailman id 374391; Mon, 25 Jul 2022 05:09:15 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqLD-0003j0-S3; Mon, 25 Jul 2022 05:09:15 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqLD-0004lL-KJ; Mon, 25 Jul 2022 05:09:15 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFqLD-0001ec-8W; Mon, 25 Jul 2022 05:09:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFqLD-0007GX-7x; Mon, 25 Jul 2022 05:09:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=tKCNVMTmg+YhjqrovvaJGspP4eMo6zNyYBjMb6xihII=; b=SOO+rilKIVWITGb6hbOPdYhX/W O+221JRPa4QoKlQVBQDJkQdreB44lyRrE1UxaYHxq5t+Hz0m408ld/9X8BJKTgKbbDNhuDXCk1RLE ZMPism8M2gD7sNv8Q3K8C3+Mlf5Y4ahTIR32DfhhtEooou5dISerdewzMX1yXZb9qFnY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171847: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e0dccc3b76fb35bb257b4118367a883073d7390e X-Osstest-Versions-That: linux=af2c9ac24019ece9281e606662e5c78fa67f5930 From: osstest service owner Date: Mon, 25 Jul 2022 05:09:15 +0000 flight 171847 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171847/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171844 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171844 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171844 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171844 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171844 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171844 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171844 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171844 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e0dccc3b76fb35bb257b4118367a883073d7390e baseline version: linux af2c9ac24019ece9281e606662e5c78fa67f5930 Last test of basis 171844 2022-07-24 17:11:08 Z 0 days Testing same since 171847 2022-07-24 23:42:33 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adam Borowski Linus Torvalds jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git af2c9ac24019..e0dccc3b76fb e0dccc3b76fb35bb257b4118367a883073d7390e -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Mon Jul 25 06:33:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 06:33:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374401.606429 (Exim 4.92) (envelope-from ) id 1oFre2-0004qG-2r; Mon, 25 Jul 2022 06:32:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374401.606429; Mon, 25 Jul 2022 06:32:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFre2-0004q9-09; Mon, 25 Jul 2022 06:32:46 +0000 Received: by outflank-mailman (input) for mailman id 374401; Mon, 25 Jul 2022 06:32:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFre0-0004q3-09 for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 06:32:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60066.outbound.protection.outlook.com [40.107.6.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 95c9d749-0be3-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 08:32:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6995.eurprd04.prod.outlook.com (2603:10a6:208:18e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 25 Jul 2022 06:32:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 06:32:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95c9d749-0be3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tz+yJLbimhojX5eswuLVT6xT97tGSaYiiEKBMzEPw7/WsLJxwuF/LDWk5BD0g4GeE3/IcrFkHoepqKpg8TfP7Ar55MLnmXtnTueyQb6WjusM/FvDjHf+0qNbR38Dj00t+upO9Ib3j7ljhiIsZzA/o1DYotFDALSIVBzcPRtCyr1huneGw6LWKrg//KBS8UP5/OGp/ApYtSOKOBLBO260BFXadrq2PTKfFeQm0vODq/7LK7IPp3zgpk95fOc06A+LJksu7Xa9Jxic7yrPdEqXT/RMZHSDW8Hyr02/OjrQZeb9qWPGZ2mVDTUxqepKIqFhwwpzDyZTU4lx3uGQWQ73vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LEMI1NFGV6V7jkH+IAFDlcLl0okeZTCi4Cw6X6lc1MY=; b=UlCFlntDWFZ1+chK77SBfTd2BIxJqgUk9JvEQgaORGqnSubZGS7P5i0BhFITLJvqVACKS5wWswf7QjEhb4dDy8nida4b5jBjvVcvY8ktlEgI/KVdGLBRfijUTWmdqKWhrZmBX57UsPpdsCDW6FhIh1PIR4Vz2dmPWI9uxP+huoaGX2/ar6INOT4sRBmIFrBFNkcpzLSJlmCdwZ6Dq69FO+sczlI4jcclmXGPhmzLWAxl8IA4f+JwzsPle2asOyexlqlEmpy4D1UmHfH2R14kgk46/vnGjhlvvL8UFjR/YLljrI2W/5XuDrgqt/3m+BncP+QyR20h5vp2k1eKqFzK6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LEMI1NFGV6V7jkH+IAFDlcLl0okeZTCi4Cw6X6lc1MY=; b=dmyYWowDpqG8REWhAG60TmZNq8aAOMHIhj5e0WriZYpnxpUfyN4xcVFLOAxQeMtS6Ii77qriOA1+n3x8D7+UCjUbqdlnR9s+ti80jJgou2FC3rJDMgfcTgNKrtPQG1NoPXHlVmpuuPFcdyHd+FPu1LiMXu+RI5QxupiYV8kszjCxR3IbAMxMg3XMRlEvKeRBfpGmY7xssgbkGt/uXp7BrpUUuL7QHFRaFv+RB1kLYu6NO+d32eBsG6Lj4MqEvPwGBW8vW4xTBuXy0iQ3vw6bR5vB/lFx5ARzVv+aMYAhUes3468cMSyJfrwliA5S6PL+FQDn0LFgliuJFfC2h9+KgA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> Date: Mon, 25 Jul 2022 08:32:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0128.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f3474a0-f370-43ce-4213-08da6e077929 X-MS-TrafficTypeDiagnostic: AM0PR04MB6995:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WIw3IwlqLfM+wib8/xppD171/x47GtkUmHZmm1LcV7u/Kjy35hgLnMXjAAogl9sZEsE9aPez7BxFuPk68OvQ073Z6cY9dvRKEk4etX21aZv7b6mCblJzp+K6tVMM6O2a82TsgnSPsZ8fimBX5CZI3tebTkuWUKJpk2DNPhWR8oIu+7s803qGNnHWBmHVRF/H8YF0Xf9cSBUDBRawS5InsUKQEpCEYSl3THuUzFuc9eDsKqF55Hl54pta2tSglyjukzbNtztsQDINT0DFVjtUtH1dRf+j7jQz0M6yGT3xeHQnK2Ra79n1/Qy9WYB8rrkSDZbE0zq0Ha7RaE5Oq1T69vnqx5SHEwYDealH9mCEo3TXjqBc4U5dZFjvbevLIcvjWWni/EWjVGNJREYN3Jf8Jc+dOyi3/R6jgn0QtYy7kJnjiDvw8Vd1lGDJH28eK6gpiTChpcmp3RJNbiQeJv1PpiCIktEKGzaBQ8R5mlFLVjmc19ajc2kNplPnVyAWSt/f9DiYIyTE7GqMtJ11TiR7H7/rHJqrQYV7oxcZOA3Bm68TOtaYzMfQGncpg7Hq1vvt0GRLvld8y/1XATfqD3JpSDZBI1bAmGlXiPrMQWwEUdugJTBtGtk1fio/uBJ2yry4Moj2JP6aONjaIsfoVxXr8vzgFsbOlLp5VdIJ7gzwN6e9vznETCDhQpVDt/+aSctiSFnhJs3Lr7dPNsuEsawY4PLK/1c6rbjFSoOueV4H8D5RMKCd8/kGM8HakWseAHoXOELqhZkbxtpFUnsTHqtQvL7O5XX7ZMCP5bvh1UWGjb7hrgCy9b16tqJ83lJIKOQf0it/j37WQPlrelId4OapHw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39850400004)(366004)(136003)(376002)(346002)(396003)(6916009)(8676002)(38100700002)(66946007)(4326008)(36756003)(66476007)(86362001)(31696002)(54906003)(66556008)(316002)(5660300002)(8936002)(41300700001)(6512007)(478600001)(31686004)(83380400001)(26005)(2906002)(2616005)(186003)(6486002)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTkyNkszeDZDeVU3ZVgzM3hpdTRwOERlWWlxekRlaHc3T1pwMjZMeGczZmFY?= =?utf-8?B?SjJpbXNwWUozcDJuMUhpczhsbUxnaW5SNUdONHliZnpNdFh0RkdpM1hSbVBq?= =?utf-8?B?V010anhtS250ODV1bDZqUzB0cUoxcTdVRE5SeDlhRXQybmVqbXlzKzBMNElT?= =?utf-8?B?YkJEbzhFZDdIaUFwbGFTWGFwT3dQNHVsZVhrWEZQaTNuYzg4dFdsZWRkZUVi?= =?utf-8?B?TFJGYnVKbDB1VXNHYUkyTERlUjM4cGdzL28xNlpHbUplYlRwYit6VytaYTZN?= =?utf-8?B?K2hKOWwrcWg1WlB1RFhJK3hYSVZleUltUFpTRTd3ZTNEVWQ2ZG9nYVI1bGpv?= =?utf-8?B?SFNZZm5DaktMUG0rdzJ6YnNONEw3aXZmRUFBN1lZbU1Ia2lwdi9jbDdETkJh?= =?utf-8?B?MjRHa3p4aHhUcFRtSUJUdnZJUEk2N3ZQakxROTRPL0pHa2tOaVczZkg2TXNQ?= =?utf-8?B?RlBSaVhzb3lORE0xQXIyWmxKRVFlc3JPZGZ1N1FON2FFTktlOE1tdjRjMTN4?= =?utf-8?B?YURueHpxUDNPcDl4ZzJXZmVhM0F2WEF1VXNzUmdQS3hJMFhuOXpMNVY0Nm9L?= =?utf-8?B?Q1RWMzhnR29HRE1hTG9GTTg1MzVTczJ5UWNydWo2dHIzTS9nM3R2ZlJVdFAr?= =?utf-8?B?S3l5R3ZaaXlUR211YlEwNHNvcUlaSkVRMkhWSTEvM3hiZWJYd1o0NU1QSEdz?= =?utf-8?B?V3NxRFVJakEyUTVUc245MWFsQ2hLSmh6aVFSRldwQ25Sb3BGdExidFJqNUNB?= =?utf-8?B?VU5ETTRMVHRWTTRLTEpmUnVGeE90VmpzYklRdE43RnRxWDFvbUIyN0V3SVY0?= =?utf-8?B?NEtWa2FDbU5wK2hJcXdEYTE1MDNoTUZHTEZUdVAwOXhqQVl0TmQ5Nm5zcnBp?= =?utf-8?B?UlA5NlZ6RVFISWVZN2pmVFYwVnBUcXUwa250SzdQK21neVMwSUpSTG80cmpj?= =?utf-8?B?RFd5cG53MWVwWlR6VTJ2RnJGdnU3TlZ3VGRVMXhRL1FmQUdFdmpzYU5rR3Zr?= =?utf-8?B?cG1XdUttVW0xZ2tQQzRDaFhUSmo1RGFINVc0c2xSSjAxR3d2TFRYZFBudGRO?= =?utf-8?B?d2FqVFp4Skdob2N6QnVaSFN2Ujh0MlJjVnM0T0lxMUJBL2psWU5YY0xWOVdG?= =?utf-8?B?SFBhdytxV1I5ZFhUSnRid1hISDdFWHZvdWFRYXlHS2g4bzkyc0NjdkxJcVdo?= =?utf-8?B?Z0JOL3JoZVZKL0pEbXNSYU1hRVJEOFFKL0hLY1hzQ2dkb1JJOXhTdkJCNW1n?= =?utf-8?B?MXIrcTJuUkxrQWNmK1N4ZEdwem5qZlE5OHFPZllwaWZScTA1d2pxM0t5SlBp?= =?utf-8?B?bmQ4SmJSMW01blF2VnVmY29zUXpHdUNXS3dMVWRLNjVjZDJhZjI3OUZrbzhu?= =?utf-8?B?b0d3RnFoTHltZVFqV3FWWCtUcEt3VjRoQXlGVkVtMElrdmc4K09jb0F2K2Ft?= =?utf-8?B?R3NTWnY5djFRbDRCMU1QSDBrWmlUdldsRko4Qkp1ZzZsTnJPL3VqT3YzU3dm?= =?utf-8?B?SUp3UlpFVXJJajNkNXNqRzh1QldnaTRiMXp4Ym9JNU9yU2JaTFdwVXJ6V21Y?= =?utf-8?B?ejZXNlFrT0FNbVdpd0QrRjRJVzBXdDVZUUJudmV0YzN4TTZ6OEVFWmhKUTZ4?= =?utf-8?B?WWtweFlKaTdEVmRhdUNDSFhnY2E5SXdPbVkreE01UmFmekR2TjZ1eFBrZldm?= =?utf-8?B?ZzRiQ2RwNkNCc280R2cwc20wa2xEdks4a3k3Tnc3ZGlsbHl5aytJMFAzMWw4?= =?utf-8?B?YVRHMi8zNHVmNDZkYWZoN053OXA3SjRiVkNRaWdNRzY1MXlCTDR3U3Yvcng5?= =?utf-8?B?blhWa2hxU0pRUktCTk9uQmN6cXFvdzJvTWF4eE5KSFU0WlJ2Q0NybFg2Z2p2?= =?utf-8?B?UXFYVzIwL1JSdi85bzF2NCtURVVSd3Q2QWFvMk1rOEpqbmJWUTlXYnErYjdx?= =?utf-8?B?RHJlV3d2NWN2RktoQlppRDF1cDVVTzFRdXV4V2pBY01jNlp6YjdHQWd4V1Np?= =?utf-8?B?M2I2TEU4Y0REMkREeSttQVNiSWdudDY1TXJBcEFKalJ6Y3NHM05SSjhYZm45?= =?utf-8?B?SFFrSHZrMENrTE9PQXY4L3lFdTYycTZiUVJ1QjZaeG80TlZwaWMweHdwVTRy?= =?utf-8?Q?NSKF98u2o2+ycSZ0p3Hlh/9Vs?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f3474a0-f370-43ce-4213-08da6e077929 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 06:32:40.3857 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mWwNZamJ5hXAybJDn3qLPT5YLgHqU5+6d0ATgo/JRlJTJ1+/cT5T60dz7EuyiMePxFtJhwragoLiot1hbfrRTQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6995 On 24.07.2022 19:20, Xenia Ragiadakou wrote: > On 7/7/22 10:55, Jan Beulich wrote: >> On 07.07.2022 09:27, Xenia Ragiadakou wrote: >>> On 7/6/22 11:51, Jan Beulich wrote: >>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>>> The function idle_loop() is referenced only in domain.c. >>>>>>> Change its linkage from external to internal by adding the storage-class >>>>>>> specifier static to its definitions. >>>>>>> >>>>>>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>>>>>> attribute to suppress unused-function compiler warning. >>>>>> >>>>>> While I see that Julien has already acked the patch, I'd like to point >>>>>> out that using __used here is somewhat bogus. Imo the better approach >>>>>> is to properly make visible to the compiler that the symbol is used by >>>>>> the asm(), by adding a fake(?) input. >>>>> >>>>> I 'm afraid I do not understand what do you mean by "adding a fake(?) >>>>> input". Can you please elaborate a little on your suggestion? >>>> >>>> Once the asm() in question takes the function as an input, the compiler >>>> will know that the function has a user (unless, of course, it finds a >>>> way to elide the asm() itself). The "fake(?)" was because I'm not deeply >>>> enough into Arm inline assembly to know whether the input could then >>>> also be used as an instruction operand (which imo would be preferable) - >>>> if it can't (e.g. because there's no suitable constraint or operand >>>> modifier), it still can be an input just to inform the compiler. >>> >>> According to the following statement, your approach is the recommended one: >>> "To prevent the compiler from removing global data or functions which >>> are referenced from inline assembly statements, you can: >>> -use __attribute__((used)) with the global data or functions. >>> -pass the reference to global data or functions as operands to inline >>> assembly statements. >>> Arm recommends passing the reference to global data or functions as >>> operands to inline assembly statements so that if the final image does >>> not require the inline assembly statements and the referenced global >>> data or function, then they can be removed." >>> >>> IIUC, you are suggesting to change >>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) >>> into >>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); >> >> Yes, except that I can't judge about the "S" constraint. >> > > This constraint does not work for arm32. Any other thoughts? > > Another way, as Jan suggested, is to pass the function as a 'fake' > (unused) input. > I 'm suspecting something like the following could work > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory") > What do you think? Well, yes, X should always be a fallback option. But I said already when you suggested S that I can't judge about its use, so I guess I'm the wrong one to ask. Even more so that you only say "does not work", without any details ... Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 06:50:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 06:50:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374407.606439 (Exim 4.92) (envelope-from ) id 1oFruj-0006ex-IP; Mon, 25 Jul 2022 06:50:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374407.606439; Mon, 25 Jul 2022 06:50:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFruj-0006eP-EP; Mon, 25 Jul 2022 06:50:01 +0000 Received: by outflank-mailman (input) for mailman id 374407; Mon, 25 Jul 2022 06:50:00 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFrui-0006bg-5z; Mon, 25 Jul 2022 06:50:00 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFrui-00071Y-1i; Mon, 25 Jul 2022 06:50:00 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFruh-0000B8-HO; Mon, 25 Jul 2022 06:49:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFruh-0000UF-Gw; Mon, 25 Jul 2022 06:49:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=w4ztPlqH+n5L7ZXZQVsTVwO9paTm3qzosjggE7yxugg=; b=01c0BFCEL8Hnl2XvT3ozHzcffK bX0HRpSa0ERIl+AU0wc4Jr+/1r/SqCoJ3UqcnhOw9YxF5TxMoF1CRIu6SbNONNYCYt3RKwpRlWtj/ Gu8lO+ZO6WfJN7PwHYfqYg/Fm4aVyDjOoCr4HafGIL2sCSel+Et/Ycbbi3XGgP6PGUuk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171850: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=510540961417288a24d0870f0226f8255420c463 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Mon, 25 Jul 2022 06:49:59 +0000 flight 171850 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171850/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 510540961417288a24d0870f0226f8255420c463 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 745 days Failing since 151818 2020-07-11 04:18:52 Z 744 days 726 attempts Testing same since 171795 2022-07-23 04:21:17 Z 2 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 116919 lines long.) From xen-devel-bounces@lists.xenproject.org Mon Jul 25 07:05:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 07:05:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374416.606451 (Exim 4.92) (envelope-from ) id 1oFs9I-0000hC-3b; Mon, 25 Jul 2022 07:05:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374416.606451; Mon, 25 Jul 2022 07:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFs9H-0000h5-Vg; Mon, 25 Jul 2022 07:05:03 +0000 Received: by outflank-mailman (input) for mailman id 374416; Mon, 25 Jul 2022 07:05:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFs9H-0000gz-2w for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 07:05:03 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2074.outbound.protection.outlook.com [40.107.20.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 19d30e19-0be8-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 09:05:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB7099.eurprd04.prod.outlook.com (2603:10a6:10:12b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 07:04:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 07:04:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19d30e19-0be8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JXUjZYiilPFNqOEUTlg815bz7Dk1M2b/wrHWvlvzizr0kr3VTDnxXnkHb5dzfrro6ZdCawUu9Rn+5mcYEuOIAjAorLMZk13hU+01NOJ583ALsBEJWog7XmjQyw1hEGDUReZLvfIn7RGd1vR7rD4nxJIakNRcw164R6YepQcrymNspKMHDxZDLkDy1/lu/96jzj56u+91osHeC+7wZs2WON/sVOXBVMioaJxVYkeA13YQkry6FWTWp3XvNQcnejCT0KQbpF3MRo5rHPGWxmd/EhMuliqrvSuRUauMoks4Hcjnmd3VWgebP7+PLa2PB6GzVyiWaUKDEuDA9rvneHbG/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=f1Yw5Bs9b4nFFMGItWddg+suyr26NNRUnjH9jAUQeP8=; b=f3LGZtm+aCaXy3Cn8tmVVyzFlxFG6PCg2di4VSUKDzjAXBtLEJ8n4+RF6utZ1/r55Z/V194QIg/S5ipyFwmYBQyl53rNKBNiRIBNkUB1YBxLBTiuvd2WyZJzfBsKSyymihOGwAvid9GA3ZXGWq1q59HaG4HIqslFde5zWqtQsnEwQQdAXORxCww9RDKfO8I31o946g3AGGB0z1GRuC7ZO2sk0ZbxXqq6TaMwaYax8dNJEb028dDE+u8qCc33x47xrznITp1oS1hh0AxEyE3b0noImDmGc5GctBcaZ1mXHd2Di50TmPmjbgnrnvjeO6h4XpFqiZ2Z8ATGm8R6WzPlOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f1Yw5Bs9b4nFFMGItWddg+suyr26NNRUnjH9jAUQeP8=; b=x+KK6lce2suXfn72RuFLvgs/J5LjAoZ6TFkXMwZrfiGxOCtHmmXyMjuRYhA85TDMdxwwy+tbSe/cVjqKD6YNC4vV8bgJ5BAwq7xcsT5/2FImMTzHf4sW9KEdcSYlXw4gEs2+NZO6gp+zrvdNLkS5/95Utkp0BJJIRrd/1S4VUT6PfCoLAiAYCqhak7OqYT/PZCUOnoiweBWSqYD8vh2Y6qvFyrKKOgHZyIV5FcUyIXINLK/cnlvhQIFi9XAOdYhlEzR4bavML+Bs3peCVyUIle9rtWjj0ro5f0wqyQee09W9PAf5Y7IEbS+VApCrXFMrzDF9YI9dn9pvYj51KmPfiQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 25 Jul 2022 09:05:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 02/18] introduction of generalized boot info Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-3-dpsmith@apertussolutions.com> <39c02342-649b-1f9f-f685-27efb7293c69@suse.com> <73cd6f59-a9d4-8767-6732-0eaae851d8fe@apertussolutions.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0163.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 38fa7b8f-f3fa-4a88-ce64-08da6e0bfd0d X-MS-TrafficTypeDiagnostic: DB8PR04MB7099:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FdYzjnjIdWPSMjjDmpox61mqVXQWAkBUpgMEnWe258S06qndfEDiVdXwMOfSLdagMn/yqG1bfiz1+Op/qMfJS/tjilh8QGipfFp6h1BnBcZ8WaLdIKCznEHmCIEtG4YqIjf2xD8rw5GflErZ8bhaC+VRNwnyei3NaKgNPiPb5mCVoFatJQehDn7t+PcvfWkYd6eqqg3eOWoG+xJec9LAP+Z9mWeQ3llAYNdtXcbHX/tQYgrQcIEqIwwLXPJwUmUINpGTBkTHZ60ZO5uR+p7sD0WIV+9/qlgelAnQes2VEN46n10j7GqG8Bpk6D171+pz5Eg3su2EyhFYSMOg+G7Sjwr57hznfbdJPOEXbZWcak57jZDp2sgKCpxDM74NMpqnyuzIIClvnXNpLB7qN6MXFhOG/4jVNruu3kCoNx7bcUBqC3xqVPr8797vwbqy9BLER0KNrgA7F5wHSjTiDNlihjQCtm/MQ63zn1HhzKcNXDO1uO7rCTKW4SL7YS4dX5R+79juaQ75Taf5gwWHSTRKyDe5a9PRxTBNq/QbTdbSeoZ0pLYwbtM1Mrj3awBdt0tIOkx4uXvHzJz1TcWh/bv8tghIcv1owlqHND9aJfxP/rRuVxjT2Zv+4xummymWaIS2ZCZ+Gttx79IogRNWTGhXCpLubgUs1xfXSr1ibsvujJLEHOrpm4rP6r6/X0typgKkwyjtShN0ZmM4xyEt07x3idZaAe5IeZwHmu5sEETO+soqH3gVCWPVMs2TVowjoylEK6S2RKR3bYNGtv5nx/hnlfpX83lCu8Yvw0Z2CvWUW0u/nmxeOdLQJW/V+mckfse6vypxirXyajN2Yv8q51OIbg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39850400004)(136003)(346002)(366004)(396003)(5660300002)(41300700001)(7416002)(8676002)(478600001)(2616005)(83380400001)(53546011)(316002)(6666004)(31686004)(4326008)(66476007)(2906002)(6506007)(38100700002)(66946007)(8936002)(86362001)(26005)(36756003)(66556008)(54906003)(6486002)(6512007)(186003)(31696002)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bk1xM3ByNGVwdTlvNmxXMnZEQXNWT2h4TUQxRSswZUxlM0hWcU1JQ1VITDJ3?= =?utf-8?B?cHFIbjl2Qm94L1dOdHVSOVVCMnh0b3JqSVVoUm01M05yck1JOUVXbmVGbDZX?= =?utf-8?B?SU1LWkhuQ0Z4c3F1Z3BQM0luR1FvM09PZjZtWFI2bTFIcUk1RXBoRHJaSkpS?= =?utf-8?B?V095N2JEdGxKNk9XeHpXcGpBZVZUZHFUK2sxdnlubFhjK3psclNldjVoMURR?= =?utf-8?B?TUg4bGxrYnpteUE1R2VmeWljRUxaOUhRbzJHcEJMYTFhWUVSZnNkVlcxVlVD?= =?utf-8?B?YUZCWjNWNERuMkxTM29lTExRTW02V3A3Y2g4YTlzSHpaemZuM2F2ekFyZWVH?= =?utf-8?B?QkVkWk5XOSs1VzJHVHlLM1ZVZkdEQVJvYmcvdEpVdHUvdlh0QmJ4d2xkTXRm?= =?utf-8?B?NFhuR0JOTGxSQnQ1eDRKellLVkZycUpDRUNyZ2ZaUXZEL0hGSjhBSzVxbDho?= =?utf-8?B?TTFSZGRyTU1BYTl1UGpYckZiWCtCaTZIalFmRkFJZzFUbGJOQ1hlZ1llSkV6?= =?utf-8?B?TVlKQkgxNldhMnRsWWVRTG1uMVFjanFaWm1kSTJDdlN5K3NiOHkvV3ZPOXFy?= =?utf-8?B?d09HSVhKWUZXMWdtTnpzNmRrQ1NaRjdpMEF1cElkM0czWnFtVy9xS0ZyVTRt?= =?utf-8?B?Q3FPZEZLQlN2OXN5Vk94MTMrck9KclNubm1OL2g1ZHVFUlJ4cTBlUGpsd2lt?= =?utf-8?B?M2xFUDExWkVTc3BBLzhTRDZYSGl4aVM0VDJLay9VSmhlME80dnAwMTBUem43?= =?utf-8?B?MVRWeGZQNjA5eHNHWUJhOWpHT29oLzJ5aWZuKzRJbHB1VVBzZGQweTg4U3h0?= =?utf-8?B?QnRXeVdiemlmMUNhR2Y3dllSUGtqRmZ1cDB0MmhUckpmYTZXdFhCWmdSSU9K?= =?utf-8?B?cmJCd1pvSFU3Wmswck1wZ09jUEJxWmw2U1R3QlRrQmhkYzNOTkthaUNwY29u?= =?utf-8?B?dFZmNzhUa1hnT3pBYXhrSmgzVEhxY3c4L3BzV0tVV1FhYklENUpBeTliWW95?= =?utf-8?B?aVJvM1k2cFpoUXdQZ3NRaExxMzV6cFYwblF4dzByQ1FjY29sSVpHa2gwZGVn?= =?utf-8?B?U21haC9vZ2FESGdYV1lmL2JMbnRyU0tNSUFOd2hrL216eU5mY0RYdU9BWUhk?= =?utf-8?B?Z2lNQlg3bTE0dUlUTjNhU2hLUlhTZ3g0ajhML2FYS1ZyK1BpSGsvdHFOT2lt?= =?utf-8?B?UE1nVTNSb1FvMzJPQUFwMzZnRGFuVGhLK01RM09aY2h6M2RpU1lIQnhOV1ZQ?= =?utf-8?B?QTh4OENPTnZWLzlxQnlPbXZKRU1FelVtaXRrckJCY1gvRzdmS0JISGZwTFl6?= =?utf-8?B?ZXp6K2RRdUU2QVpmTjBRYVFDM3ZrZEc1UmVDRU9CVnQ3VnYzNjlPTWlHb2tr?= =?utf-8?B?RWZYeG5kYk1uR1U3MXNocDU5TnJiVGtLWHVtenE5ZUJYMTJXbzhkYXpyZjJv?= =?utf-8?B?RElPNUM4Vzc3d1dvU0pWZGg1YTAxT1hjSDB6emhIU1JtRkU3QnR1bjVnd3ov?= =?utf-8?B?amZCRFAvWWw0dDdRL3k0djBLL3RnWWtYbjVBUlpveHR4SWp4bHpsZHVNckcv?= =?utf-8?B?dVNGUk9rOVhkUFBsM1A3MEl4Qkw5MzhKZjdibDZ5Y054a0JZcGowMEpVakNo?= =?utf-8?B?elhta0d1blNNUG0wZFBMUnk1Zm92Q3p4OW51TmU4QWtaMU1WOVpSVnphcFBO?= =?utf-8?B?WUVjakFKTVQwWlJHN1lKM2hxaUM1S2ZRTk5Lb3E1TVhINWZGTnA4Y3ZpeTJI?= =?utf-8?B?RDBGZ1lpM2JLVThqRnR4dGFFNFQ0enU3RHFnZkZOc1JzZTRLMk1SYm9KUXc1?= =?utf-8?B?T0lHQllScGE0QWx0SjNETXdrMVk2WEV4MXhRYzY2VVRUeUt6dkhYYmd2czg4?= =?utf-8?B?b2xtU1VKWDhxd0RFOUljNzNONFhoaFF4NkdIbm9FeENFS0ZDbTB6V0pBMWZ2?= =?utf-8?B?S3FUK3BnUURUVDQzSkh1dWdhZm9ZL2V1L1kraHFNOUExZ3YvWXVJV2FIbmw4?= =?utf-8?B?T1hPTkNRRytIN0Z3aGR4emVGSHRLbjNQNWYxcWo0cUszbVZXYk9mUGFNSjlz?= =?utf-8?B?SStxNUMvdlBFMWZuTFJueHRsS1AwbzFzSmVCUGswMmJYeHJPa1dVc1RsblNX?= =?utf-8?Q?Ou0POMeyqvY9RJHuEFaBPgOCJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38fa7b8f-f3fa-4a88-ce64-08da6e0bfd0d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 07:04:59.6676 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: b7UQxAAq05BdXHtGOBJyPGZOwRjDNuRolEyGst5rEsoawJi1FAAilWyAmmJZOhfAed9/4QYvGsV1+9sJpQWDIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB7099 On 22.07.2022 18:01, Daniel P. Smith wrote: > On 7/21/22 12:00, Jan Beulich wrote: >> On 21.07.2022 16:28, Daniel P. Smith wrote: >>> On 7/19/22 09:11, Jan Beulich wrote: >>>> On 06.07.2022 23:04, Daniel P. Smith wrote: >>>>> --- /dev/null >>>>> +++ b/xen/arch/x86/include/asm/bootinfo.h >>>>> @@ -0,0 +1,48 @@ >>>>> +#ifndef __ARCH_X86_BOOTINFO_H__ >>>>> +#define __ARCH_X86_BOOTINFO_H__ >>>>> + >>>>> +/* unused for x86 */ >>>>> +struct arch_bootstring { }; >>>>> + >>>>> +struct __packed arch_bootmodule { >>>>> +#define BOOTMOD_FLAG_X86_RELOCATED 1U << 0 >>>> >>>> Such macro expansions need parenthesizing. >>> >>> Ack. >>> >>>>> + uint32_t flags; >>>>> + uint32_t headroom; >>>>> +}; >>>> >>>> Since you're not following any external spec, on top of what Julien >>>> said about the __packed attribute I'd also like to point out that >>>> in many cases here there's no need to use fixed-width types. >>> >>> Oh, I forgot to mention that in the reply to Julien. Yes, the __packed >>> is needed to correctly cross the 32bit to 64bit bridge from the x86 >>> bootstrap in patch 4. >> >> I'm afraid I don't follow you here. I did briefly look at patch 4 (but >> that really also falls in the "wants to be split" category), but I >> can't see why a purely internally used struct may need packing. I'd >> appreciate if you could expand on that. > > Originally, patch 3 and patch 4 were a single patch, and obviously was > way too large. To split them, I realized I could introduce a temporary > conversion function that would allow the patch to be split into a post > start_xen() patch (patch 3) and a pre start_xen() patch, (patch 4). For > x86, pre start_xen() consists of 3 different entry points. These being > the classic/traditional/old multiboot1/2 entry, EFI entry, and PVH entry > (aka Xen Guest). The latter two are all internal, 64bit, but the former > is located in arch/x86/boot and is compiled as 32bit. I tried different > approaches to support using a single header between these two > environments. Ultimately, IMHO, the cleanest approach is what is > introduced in patch 4 as it enabled the use of Xen types in the > structures and maintain a single structure that need to be passed > around. To do this, a 32bit specific version of the structures were > defined in arch/x86/boot/boot_info32.h that is populated under 32bit > mode, then they can be fixed up after getting into start_xen() and in > 64bit code. To ensure no unexpected insertion of padding, I focused on > ensuring everything was 32bit aligned and packed. As Julien pointed out, > I messed up with the use of enum as its size is not guaranteed as the > enum list grows and I forgot to consider keeping pointers 64bit aligned. > > Does that help? It helps as background info, yes, but I continue to be unhappy with the new uses of the __packed attribute. >>>>> +struct __packed arch_boot_info { >>>>> + uint32_t flags; >>>>> +#define BOOTINFO_FLAG_X86_MEMLIMITS 1U << 0 >>>>> +#define BOOTINFO_FLAG_X86_BOOTDEV 1U << 1 >>>>> +#define BOOTINFO_FLAG_X86_CMDLINE 1U << 2 >>>>> +#define BOOTINFO_FLAG_X86_MODULES 1U << 3 >>>>> +#define BOOTINFO_FLAG_X86_AOUT_SYMS 1U << 4 >>>>> +#define BOOTINFO_FLAG_X86_ELF_SYMS 1U << 5 >>>>> +#define BOOTINFO_FLAG_X86_MEMMAP 1U << 6 >>>>> +#define BOOTINFO_FLAG_X86_DRIVES 1U << 7 >>>>> +#define BOOTINFO_FLAG_X86_BIOSCONFIG 1U << 8 >>>>> +#define BOOTINFO_FLAG_X86_LOADERNAME 1U << 9 >>>>> +#define BOOTINFO_FLAG_X86_APM 1U << 10 >>>>> + >>>>> + bool xen_guest; >>>> >>>> As the example of this, with just the header files being introduced >>>> here it is not really possible to figure what these fields are to >>>> be used for and hence whether they're legitimately represented here. >>> >>> I can add a comment to clarify these are a mirror of the multiboot >>> flags. These were mirrored to allow the multiboot flags to be direct >>> copied and eased the replacement locations where an mb flag is checked. >> >> Multiboot flags? The context here is the "xen_guest" field. > > Apologies, I thought you were referring to all the fields and I forgot > to explain xen_guest. So to clarify, flags is to carry the MB flags > passed up from the MB entry point and xen_guest is meant to carry the > xen_guest bool passed up from the PVH/Xen Guest entry point. That was my guess, but then my request stands: The fields should be added to the struct at the time they're being made use of. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 07:09:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 07:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374422.606461 (Exim 4.92) (envelope-from ) id 1oFsDO-0001RJ-Kh; Mon, 25 Jul 2022 07:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374422.606461; Mon, 25 Jul 2022 07:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFsDO-0001RC-Hq; Mon, 25 Jul 2022 07:09:18 +0000 Received: by outflank-mailman (input) for mailman id 374422; Mon, 25 Jul 2022 07:09:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFsDN-0001R6-8D for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 07:09:17 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30059.outbound.protection.outlook.com [40.107.3.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b1c82b4b-0be8-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 09:09:16 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR0402MB3781.eurprd04.prod.outlook.com (2603:10a6:209:1f::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 07:09:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 07:09:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b1c82b4b-0be8-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P+/7acfxsIQK2M/5jZC0tweC4YBF+WRhAqGntcgb0c233cYicCHQHDfvFlaYNtQHHH7/x74VBHq18GFKjGF5C/uL+LNaJPM97vF6IFx/y5/p3/qlciTzk2Ts7rC0Wao6GvcjZtmMohsdQYZY2QpLKAGpVJ6REKohqWP47nTpXwSqtQfvMy5fTcRUhJvrtT+KyRQN3eiCdJwT/HldnF/Rms8cCa05F0Rt6hqQlOfJXVwELKTVZ/LHS0So8aQBo1BPD0sKStozMPCrmpMpf5PEyyLtAWUKfvfEoxRMAh84SWcKs8YGLXRb4O91XZaVDDwbFizidIeX4ouIjNMNq/Z0wg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+PIj7R1l1yRdtgBX2XEGtcGEBOffcS42TzhMTVJ3Ok4=; b=lAWcJ2XYBBHWLoMOcFjzxCTAIoWsaACbN72EeKp2TetA9KBY8ZdsGL/folVSAA23ya8RU72+7q41YPDIhQCOhXcv8lk6jayy/o3vDISkRteLhM9l9QugAf16nbztS7WfehShLJ6+4mR3XnPqu3AKt+LnoeFdvHWvjMbX5f6PIYTKDv5QLzMlToQsJj+kckdyatmZIRoyhos2B5vJn9YGUGY66xGkwvLDaR4aGul4rBua7QtvSf2fynelMvdTpKL/i/QOV+s44ZSOO7cSLvWDU7hV7HFpWfKth9+apN9Fmz1w/T5RzAkVLeLugwyGnaUpZ+SkyiNs82IVt3tG7r6g8w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+PIj7R1l1yRdtgBX2XEGtcGEBOffcS42TzhMTVJ3Ok4=; b=QAToo+6cO+mhM+M3Y2ePQchBJgnTfWNqeDjbICL9p4fSEyojbFqr3NN2OSggMh2Xss4QRfYJvwUA+wFAg1hR/yhcN0gKRz6LtSTHEKZ13TaG9nnIyvefJuP3dWnkxTSfum44f6GuWjGuLnfknkomIc87aQpfvMP5zq7qOJiQpCYDPfMyX7A1NWhakePGGPjUgWVnpEZo5crmdwFdTeZBHs/oazG8/AFDE0yqRWZlJLwI/uI9QzPy+7NX4QGqPybOIvsyszfR9xSjqaEIMDxkte7Q3/2QFY4DaMFQLtUXXoY7+859e/tI+lBlG8KU3I3YXfcAuuT83QtqYAp0V+mXxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <009d5350-70db-f614-a8a0-77a6337ac8c3@suse.com> Date: Mon, 25 Jul 2022 09:09:15 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 05/18] x86: refactor xen cmdline into general framework Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-6-dpsmith@apertussolutions.com> <681d9e71-f618-ff33-59c4-bc7f793d45c7@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 710f198f-1186-4771-32b2-08da6e0c94ea X-MS-TrafficTypeDiagnostic: AM6PR0402MB3781:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mTERptAooCFM7gPgaztOX60Ov/ZV/cbdCRde10abHte8u5fLrzxD+L/g2LiY6BqvVXZgsAmtldBQXgv4/IYRj8HqmtDoZxxjNFqp4hfmtSM1crKHPAnrutvXmMmGKmVHqlWYI4QrR8iVHgggSWbvaHX/eaUCH5SWduSR755PB5ZISUpHeNt8VlFQCTqu9zQDC8WCisS8eJL48B774s8WVKcudvfnehqWnnrQzabWept7LzRAW9YIZT9m70B6l94XBIAXPgJpcWmKdkTK7ES9cw0tigN4chnFikFqkJNfhDkVbiDUGLvaREYau25WKYt6soeKI2q45W5cr2rtjdVWg5W4P6XxiyEcBg9qUxxq/SYIAlN6F+3VjuC/Mrqo8pNE9I5xdydc13drIOz5DXWdDPGGFrEtUab9MUWlNvMbzwgITtGzVsJrjqqwCSr8IT3wY891i9j0x1wnPFDaIIhAUZf8SkveYSZAh6xhKwfKd2195SngilmIDMmOWoUVAnBX+Ys6IBFSPIOksSok1XKnxWG9Id+VThqwqBVjFpKTB5ZMPRduTksHG9dEqegDgx5PBPW3eDqRvcj6iCDM/kNwEMnE/OstQdwv77SQF9eabk8W+yZ0HbKRXaYh6dj38s3MAFduRhNeG3J+EwHbj6r44eOFMjLt+43QRHN/DF1pV70rbK/aXqjxAV3gkDrJVMqUbus0JDsaaZD0E+Rx8Q6xAZ8epuGyhLa3a51tgCUq0W6UJ+fUHevv2/jUO5RJguhYwHQVW1JCiZquW77v2Cpd7/s5rXiPv/jB0V3nQJsV+diLcX6luKJmslkKIGAB/rjflKxBBQVvGvvEgkAk3CXvwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(39850400004)(346002)(396003)(54906003)(316002)(6486002)(41300700001)(6512007)(2906002)(7416002)(66476007)(6506007)(4326008)(66946007)(26005)(8676002)(66556008)(478600001)(5660300002)(8936002)(31696002)(53546011)(36756003)(38100700002)(186003)(83380400001)(6916009)(2616005)(86362001)(31686004)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXhPcnNBVGJuVzB1eFF4bTRsYU1kNGl0RGd1YjZrQndjVC9wWG5MK1ZXQjlq?= =?utf-8?B?cllFUzdqa0dpZG5xQlREVzV0Q3QrUG1pb0RITEI5eTJIVFZWQWR6WE1nUkpT?= =?utf-8?B?UWNyT0cxaVZRYzhYVldJMkY0TDYyN01WWXc3YmVYMnhaVkdNTFRZNnhqeXhR?= =?utf-8?B?eVcrWjA1anE3Q3UxenRJOXpLL0hLcFB6Y1BHbFBRRzZxUTdBMkd3aDROMGFU?= =?utf-8?B?cUMxL0NzWlJvT2tOWlRWRkpHb1ZQZnNhemhpUkV2S05WZ0tsZE5QUmdUekRs?= =?utf-8?B?ZFZtQ2JPNVpHQTlRN0JVbGNLZG5VaWdSLzNwcXlvUlFqUkpBbHBTODBxSm43?= =?utf-8?B?WWFOQ0hiNkVaSENkbWJISmNrbXR5RmR5U3ZZeHU2bk9jVStpWXRMM1hhOGxK?= =?utf-8?B?T05uR0VZek1rMG9vbkUzUnpzTE5NQVpvdnV4dk1OenRobEgreDJVUEtVMGVG?= =?utf-8?B?NEo2alBReHA1TS9JbFk4Zkp3ZjFmdXM4dUNIY0gzYmFSWkdKby9NNXA1YS83?= =?utf-8?B?RzRRdmFOQUlGdVFDYWRUMTNCdGNiYWtXQXBMVWtFT1orM3RUUXY5TE9SdXlH?= =?utf-8?B?d3B5RlBVVW4rbUdXZEhzbmhXcFFOM2ZXN2VablMxSW9kSFZsTlFuMnNVOGRp?= =?utf-8?B?VnlHMmloMUFLa0dETGY1aGZpZFR5YkphMVRqMUwrRURPdzdMWjRWcHY5WTlS?= =?utf-8?B?eC9lTHJZYVl3eDR3Z3l1dGRzNExMU1lSYWpiSTRJSEoxRDl6eWpVVU01dTcy?= =?utf-8?B?UjgxK3BBRWMxbkwvNDF5dE13Z2pSRDVNbk9pTXZJdE51dSt2MnU4LzJyaFY1?= =?utf-8?B?dUhzV3lZV1IrU0NHZVA1L0lDQXFoZU83Q0tiOXhCNGlJVDhzd1p0QXZYSEpp?= =?utf-8?B?TjhUeW1mbWxVVjY2UkptbWhGR0JFcFVJejFJRlpyODBKRWcwR0FOTFVXRys1?= =?utf-8?B?MnpJdTVQK004ajB1ZVZtcUNFNzlyZVNyM05zNXBrS1VZT0w3ZEcyMjQ2aFp5?= =?utf-8?B?aWJobDIzY2xxVGhQU0F2SzNJUWdSOHhzVkJ1K3BiN3ZYdG5oUGVPcThOV1dp?= =?utf-8?B?NzdUWHJySFp4ZnBsNHlyV1RvamJTWHI1ZkZNT2xUOU9IenNSYkVLaVAyV09p?= =?utf-8?B?RG1vN3BIdWFwMTZ4eEZEWDF2MXBpVkJiUU11ZFlwVEc0UnNRNWJRc3FXSWJu?= =?utf-8?B?WDhMNzdqTFJmMUlvSUxKN3pjVGs4cjBJeFhOblZzNU9QRjdWUkttUW51TTEy?= =?utf-8?B?YUZpNXVsM0xCNDNZa0xRUldaL0dzNWkyZThkK01ZV2d4N0RvWE53Vy9zSk5Z?= =?utf-8?B?YUhaNlpVUFM5dFkvMlp6bUx2OTM0N2QrRlBrMmVYYy9PbEdXTXAvWFJQOWc2?= =?utf-8?B?RkR1cnNLME9MOHhVNkdhMWZmQTMrRGNlNzRnVlVneU43OUhtQU9vQmJQa2RR?= =?utf-8?B?M1ZteGV0OEtJcWx6SElEb05uNWpaU2t4Ym40aldjenkxYzZ4UXRjWlNpSHBZ?= =?utf-8?B?U3J3dlBIM2plRzZDMmlGTEhvYmpqckg0d3dzVkNGN3hoNmoxQ1lUcndzR0J2?= =?utf-8?B?TGlVeEppTlZRNHQ2ZytaQzJxSGJGeFpyNElML1p1VWViQkFBSS9zTTQ1cENW?= =?utf-8?B?YTNoQ2g0ZWtVb3h1bDFPN2liZHU2Z05HbzVHb1dpUytqVzBwWEZ6Z0hBblcx?= =?utf-8?B?R2gxMW1KV25GclhYK1c4d3ppR1RxNzdIN0RkU3g2WjJ1UjdVSFFTTkZKR01h?= =?utf-8?B?aHV3bktsbGNYQ1JJUW0rd0Y4TmxrNTY2anhQamVQVGlSRFZIUjlaMGc1aGdC?= =?utf-8?B?bDBHZ24rV3RlWGJGQ0hzTjdLUVNpeWorY3JkcG5JdC8yYmJIR1hNYkQ0UTE2?= =?utf-8?B?bVdONkJzeVRPcjhRM2htbnJSTW55MFVINU55LzdXUEFONXlzUVFpYjJsejFV?= =?utf-8?B?UnBUNFNmWkdvb1dHMitRSFZMRVY1dkNlc3hvSTNucVd5eXNtL3dXR0tUeUJj?= =?utf-8?B?c2cyeGtzeEg4VVRUeXJ3WWR4UWdnK2tmVkJ2M2RsZG5qMmFLZjlmWFpSL0Jh?= =?utf-8?B?aXZPRW84NkpWeTlGUmYrQ2pGS1ZFZGQ1MGtyNHNDM2tSQVdLdUFuanczQjhp?= =?utf-8?Q?5AF7wSw1ZZ9r7t/03OUDhnKpy?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 710f198f-1186-4771-32b2-08da6e0c94ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 07:09:14.4323 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2UXHGdUEggFSP+sNGNg4DJxv7JObCRlP2w4dW3f3ApKGzQDJmvMeaMIJqssK8u4Sd84Gjj3bP/owtJhWoZKnLg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0402MB3781 On 22.07.2022 15:12, Daniel P. Smith wrote: > On 7/19/22 09:26, Jan Beulich wrote: >> On 06.07.2022 23:04, Daniel P. Smith wrote: >>> --- a/xen/include/xen/bootinfo.h >>> +++ b/xen/include/xen/bootinfo.h >>> @@ -53,6 +53,17 @@ struct __packed boot_info { >>> >>> extern struct boot_info *boot_info; >>> >>> +static inline char *bootinfo_prepare_cmdline(struct boot_info *bi) >>> +{ >>> + bi->cmdline = arch_bootinfo_prepare_cmdline(bi->cmdline, bi->arch); >>> + >>> + if ( *bi->cmdline == ' ' ) >>> + printk(XENLOG_WARNING "%s: leading whitespace left on cmdline\n", >>> + __func__); >> >> Just a remark and a question on this one: I don't view the use of >> __func__ here (and in fact in many other cases as well) as very >> useful. And why do we need such a warning all of the sudden in the >> first place? > > This started as just a debug print, thus why __func__ is in place, but > later decided to leave it. This is because after this point, the code > assumes that all leading space was stripped, but there was never a check > that logic did the job correct. I don't believe a failure to do so > warranted a halt to the boot process, but at least provide a warning > into the log should the trimming fail. Doing so would allow an admin to > have a clue should an unexpected behavior occur as a result of leading > space making it through and breaking the fully trimmed assumption made > elsewhere. All fine, but then such a change wants doing on its own, not in the middle of pretty involved refactoring work. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 07:47:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 07:47:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374429.606473 (Exim 4.92) (envelope-from ) id 1oFsoH-0005yl-EC; Mon, 25 Jul 2022 07:47:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374429.606473; Mon, 25 Jul 2022 07:47:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFsoH-0005ye-BT; Mon, 25 Jul 2022 07:47:25 +0000 Received: by outflank-mailman (input) for mailman id 374429; Mon, 25 Jul 2022 07:47:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFsoF-0005yY-K3 for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 07:47:23 +0000 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [2a00:1450:4864:20::42f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 04092fe9-0bee-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 09:47:21 +0200 (CEST) Received: by mail-wr1-x42f.google.com with SMTP id g2so6678581wru.3 for ; Mon, 25 Jul 2022 00:47:21 -0700 (PDT) Received: from [192.168.43.143] ([62.74.23.66]) by smtp.gmail.com with ESMTPSA id p2-20020a05600c430200b003a2e89d1fb5sm16464108wme.42.2022.07.25.00.47.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jul 2022 00:47:20 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04092fe9-0bee-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dtzdpk25rNaEKVZul+zahBkB4hSradURMLN7UgwUAWc=; b=IeEgJ0aSXsfO11vOdryARyp3kb5ZKmJSUclzCtCRU+OO6sgqNk78RiPtERuwW/DiAI pxWvH+9UUjMXvCh8lU+DKCS63j/iYCLK+LnJg57zXcbaGang/0OEifmixSxcV3ZmkXUz iA5zZtPE/XDwhBe+lXzCqL/Iyo2tkF5wx5x7Y0hVvDLIgZJn7wPoQxXddK7OVG2zXgDX yeiVl0jeutWrdZi7B4sEas1G5b68xXQtZ3OqUEvt+WHHd0qX9HBwztFUN0jehajKPBi+ C7LTGoGoDnByrkzwZDPzpEW3hgwrGg3TE8TYDHenEG4gGjDb4EmOnS2zXs9ioiyiZsEu dLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dtzdpk25rNaEKVZul+zahBkB4hSradURMLN7UgwUAWc=; b=NqHZHckS/i0rnN9SbpSZzao2QknHJTzVPTP7kY65+U5h3QAmob+enQZKTwvYul6Bmd 2fFCfCT9U0MtH9O9z8IQDJ+qkmoCovBAF9039FP/vA81sa54AZ2IZxLIUW4jxwZs5xTJ CI9pbpG9+N7hjxnuRXHhV8o/cPk68rP6bgQuqIjevx1X62tFnCHdUvK4ivzfpT6lufMP z8uMgfoKFcZPOnRwAO/xt4POK1ADhq7QH+gyynXwUaopboaoPkk6/++07inho0TsX3V7 KeBMWai3kEM6vOJPfUq8jO8gZO0qDb9/FmUvwzoUE9hxc6HxnkLzQi84uteOxtuOvJOt ieQQ== X-Gm-Message-State: AJIora+UX6zUuxlN+f0j0sKl8UTVuO3qoNDKI060Am/x69PuIEigL4d5 mC0qEQZAHuglc1wnxEvDFLE= X-Google-Smtp-Source: AGRyM1tr19kvj1fkKv84s8bZVxyI0/vxWzO6e1GtWCCUkLSVS2hEtDvZR4QuPh+H+0VvqF/u9t9hLQ== X-Received: by 2002:a05:6000:508:b0:21d:4105:caf9 with SMTP id a8-20020a056000050800b0021d4105caf9mr7076202wrf.699.1658735241230; Mon, 25 Jul 2022 00:47:21 -0700 (PDT) Message-ID: <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> Date: Mon, 25 Jul 2022 10:47:18 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Cc: xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> From: Xenia Ragiadakou In-Reply-To: <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/25/22 09:32, Jan Beulich wrote: > On 24.07.2022 19:20, Xenia Ragiadakou wrote: >> On 7/7/22 10:55, Jan Beulich wrote: >>> On 07.07.2022 09:27, Xenia Ragiadakou wrote: >>>> On 7/6/22 11:51, Jan Beulich wrote: >>>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>>>> The function idle_loop() is referenced only in domain.c. >>>>>>>> Change its linkage from external to internal by adding the storage-class >>>>>>>> specifier static to its definitions. >>>>>>>> >>>>>>>> Since idle_loop() is referenced only in inline assembly, add the 'used' >>>>>>>> attribute to suppress unused-function compiler warning. >>>>>>> >>>>>>> While I see that Julien has already acked the patch, I'd like to point >>>>>>> out that using __used here is somewhat bogus. Imo the better approach >>>>>>> is to properly make visible to the compiler that the symbol is used by >>>>>>> the asm(), by adding a fake(?) input. >>>>>> >>>>>> I 'm afraid I do not understand what do you mean by "adding a fake(?) >>>>>> input". Can you please elaborate a little on your suggestion? >>>>> >>>>> Once the asm() in question takes the function as an input, the compiler >>>>> will know that the function has a user (unless, of course, it finds a >>>>> way to elide the asm() itself). The "fake(?)" was because I'm not deeply >>>>> enough into Arm inline assembly to know whether the input could then >>>>> also be used as an instruction operand (which imo would be preferable) - >>>>> if it can't (e.g. because there's no suitable constraint or operand >>>>> modifier), it still can be an input just to inform the compiler. >>>> >>>> According to the following statement, your approach is the recommended one: >>>> "To prevent the compiler from removing global data or functions which >>>> are referenced from inline assembly statements, you can: >>>> -use __attribute__((used)) with the global data or functions. >>>> -pass the reference to global data or functions as operands to inline >>>> assembly statements. >>>> Arm recommends passing the reference to global data or functions as >>>> operands to inline assembly statements so that if the final image does >>>> not require the inline assembly statements and the referenced global >>>> data or function, then they can be removed." >>>> >>>> IIUC, you are suggesting to change >>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) >>>> into >>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); >>> >>> Yes, except that I can't judge about the "S" constraint. >>> >> >> This constraint does not work for arm32. Any other thoughts? >> >> Another way, as Jan suggested, is to pass the function as a 'fake' >> (unused) input. >> I 'm suspecting something like the following could work >> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory") >> What do you think? > > Well, yes, X should always be a fallback option. But I said already when > you suggested S that I can't judge about its use, so I guess I'm the > wrong one to ask. Even more so that you only say "does not work", without > any details ... > The question is addressed to anyone familiar with arm inline assembly. I added the arm maintainers as primary recipients to this email to make this perfectly clear. When cross-compiling Xen on x86 for arm32 with asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); compilation fails with the error: impossible constraint in ‘asm' -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Jul 25 08:00:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 08:00:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374439.606484 (Exim 4.92) (envelope-from ) id 1oFt0f-0000Og-Vp; Mon, 25 Jul 2022 08:00:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374439.606484; Mon, 25 Jul 2022 08:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFt0f-0000OZ-Rq; Mon, 25 Jul 2022 08:00:13 +0000 Received: by outflank-mailman (input) for mailman id 374439; Mon, 25 Jul 2022 08:00:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFt0e-0000OT-KT for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 08:00:12 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2053.outbound.protection.outlook.com [40.107.20.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id cea7473b-0bef-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 10:00:11 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4228.eurprd04.prod.outlook.com (2603:10a6:208:66::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 25 Jul 2022 08:00:08 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 08:00:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cea7473b-0bef-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GqJEo38bHLRwBOLcLbZeF52jujgGXcoHJxynZtbEYMnEW22l4mlGrl0czxaYfHpgxuuu6frlHXK426QCFTxnGjTogaDAYhNSHiwXMxI6II856n7Oln+fYMLNpKPi7+nfonY35zY7nfpBo1zWU+dd0kMkO1Czi74RuYL3+WSgyvn9duT9y+6Nh7bnmeaL4c4o2jedHLnJY0TEShUadM/VtEScvYp2GKzKyQruADl/IM8oxZ/q1NgslZegbopl4KVYRUDYmFGPPnUvh3O1d5Z32NKm2VGKpqstDDSHqdiPgrZ2SU2kymHD2ONNs/+WF6jUe4LCDyRTmnrJ6tG85dsoBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GuA/4AlDLjM1fwxUGbpAWYbhTC5JycA54f/haeULPP0=; b=j0URB+1GW51TM+gchapXdgSDNwYE6kvkAGX66xQDxc12AoBmsOZw97R9fJV8UQ/pShPF5aS0UVBJ/1HzyFcwtR0dM23R0+2m7iR72FIBArRuE240c43v3XOgsRteJl3Dp9pvZe96umx02CQa5yWOqejHc5fkWHe67i9GvPrdRhUycz+h9FM9h8z5LXyunE0K9i7Mdbr+qFbIwI8JzJQPxR1CJZl/Yt3CEjK1pnoWyihzWbOcbWmRnej1mjEEbltYJJtM7UByHISnk9xEQgtE5f3WpSgL5KzKQk2xsoU1DH/JXzCI6xu2iRJ/Qw3sfvgxwcNqCxK2YKyTs7fNwFcVWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GuA/4AlDLjM1fwxUGbpAWYbhTC5JycA54f/haeULPP0=; b=eQG0d6CiiwC+nc2OLruv0EDqObxoDxrBzipqsDAdoTsq/63bxlfgQ/u9sla1IqiGvxrRJMs9vnyTpd70NjB7EUB6meDxZbudn//SWskGEA/kQaR6qa4qAz7O9SyG1Ve5YxcRqyvcm2ePG5/Q/0eDvFwMvwhWHTHdsbt2ggNjb3oNDaoo3CZoVDG33wpkuresU9v0Zgdm/bu+bC5t68cK4d1Z1KvvIxx66OaQWmqrsg+FpGS0rwraQOgW/B8wXojUP5VRr5/G/c7z5ziBRXZPBrNld2JhbAmvFPzswlT0PsZ0RgWWYjXs1d6HXT+vYYwBTIxBOPMSmQS08S8S7JEeww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <69b5906f-163b-b7cd-81ed-98be8e45bdf2@suse.com> Date: Mon, 25 Jul 2022 10:00:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently Content-Language: en-US To: Xenia Ragiadakou Cc: Juergen Gross , xen-devel@lists.xenproject.org References: <20220724173159.410535-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220724173159.410535-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 25746d18-457f-48ff-3434-08da6e13b0f2 X-MS-TrafficTypeDiagnostic: AM0PR04MB4228:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h6J31ISsOERd9k50I9NXFYhPYuMwdLiLPUHnWBzrXMIrZ5lYxSLrYPKKw9+sGcJFod4Dci+FIMbVGTukSE84LF+lm1045ya9MDsOU4HAJzVAK2oZ0FMlnohcPH9eHl12ylmEdbGnen4Efii76dAp8eeGw9kJkLix9oZoCnxTCZAiob4LQUMicFr7+lpupUBQbS0DuoppzHjtYojlpEZ7NvZ4lPZAr3HyrvsbXRl0+Do6sKo45kcTemIcpMi+b8nElAyTMtIveTzRHsDRtrCki7FrWhA9j44arSz126attOAv6cBb+ubhs/veXgZHEopsQxEE35mE549hcBYpEXC14CwrbzlA6ec6pixMNouZ317dxSa3J7gpwpf4sZkEM6C52fJHH3G5+a1zD/JZ8TtMRqX5DhHEInUXfoFDDyeq2GPZDVgc2gtDbyvZd/Ey8aBcZ5MUj1BMP/hIltd856plipEx4pWNFUO0KOAazNvah3MaBJY5EabIR0HHnq1yatrHt5AILewihcxeknwwbY6skHOMeLZ752CrEZuNKdUQRsGIJXhm5hRILNA4d9z5Fa2Yk15K/vieA9x2o5eUAO5hokIC5Nzs7XKfP+IwrTWpJKsGfI652yKB5e1nQhhsPa568VAKUMuEmJC73ogzl5v8zpcS3bogldy9+N7d/Cz4ZmCN9EOHjhTxT50vxKC0qfrp7vM1YIUaZGuh9RUY62QMo5PFWXSwwSqm0/ycrkkewAaBQk+Wmalt3cdbb/l6w083IRN6N2B7RocBHG7Uq6Z7JFRXC0VkexYPSKTyBasHjYxWsHvr5ZV8T3YLvnDZwyuoVkCZwDjSh9VBsXDVTyhyOg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(136003)(346002)(39860400002)(6916009)(41300700001)(316002)(38100700002)(36756003)(66946007)(31686004)(8676002)(4326008)(53546011)(478600001)(6512007)(6506007)(26005)(8936002)(5660300002)(86362001)(2906002)(186003)(83380400001)(66476007)(66556008)(2616005)(31696002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkhpajZlQ0lBdmlBVGIyR2pjVm5hajN5QVVObnpIY1NQOEphdjJJVUdFS0to?= =?utf-8?B?bEh1dkczcmFQMkRRQlBMOVhCN3I2a0pmV3NqeTJseTBmSUFIbFBnSllwcThK?= =?utf-8?B?aE85RjJyMzZlUUg3T1hkWktKOWhuYTVhMEFFS0NPT0dUZThKZGN0YURydm5X?= =?utf-8?B?QkI2QTlxaTlSYlJ4OCtMOExRK0FoOEJvd0lnVHRzblBjZmVzUzgzaFdaUXdB?= =?utf-8?B?Y0hnQmhCMUFTbENqU1RVSVY5b0UxdXBoSTBWV0RZTXFnOXhWbGFZUU5PcXAz?= =?utf-8?B?cktsQW5VYUZDekpQay8vbG1pUE1kcGpPR3czbGRoa09YbEpMR3dwQW1PSzA4?= =?utf-8?B?d2R0N0I3TW54OEovbkJFSzJoYlY5UVVMRG1qWU1udHI2WXR0c2Yvb0xGTVFq?= =?utf-8?B?a09pWDFaY3BUVjVzVFZQL2RXZFpuTm5jZXdSZmxUVVpYQndzOVZOTE5UYXl4?= =?utf-8?B?RXg0UVhZSmtoN01FL0hqdlBjQm11ejRWbE9kUEhKQ2cyR2h2OXhBUktyck5E?= =?utf-8?B?ZUJzK21wS3lOc0lNU1IxSDl3K2lqYVpKVTJuWWFtY1MzQUxwR3BjbVluZm5X?= =?utf-8?B?QkNQcVpvQXhJVTlLTTdVcGRScXgwOFJWUG5BRVNCR3RKdW1mcC85cDlUb0RW?= =?utf-8?B?QmdCRmNScUl5UXQxWXRXM2RnZ2JPaHJYUGdKWlIvdE9XQVkxVGlvQXh6R1Jl?= =?utf-8?B?U2pNbnFFcU15bDRCWFM4VEJKcEQxZ21UM01vNUxCTnNQZUF2RFQ0NGY4NlJU?= =?utf-8?B?bHRNbDJYeGY1L3hodjJzRE5oUlNwMU1mTzhNMnE0dlJTT0ZsampTVzhFZXk4?= =?utf-8?B?L21qOTlBTDYzT0lVV1RaYWZiblZaSEx0RzBmV241NjlKSnRuZ1dockZSSE1C?= =?utf-8?B?MndwTFpsandWTmxzaGFXV1lPNng2OGlOVTF5NkZIUUErMU5jSEY3eHp6YjJ1?= =?utf-8?B?cURxUTFQNlM1TzVpNWJORFR3cUpHV1dmZ0R5TmVBcVZWNW5OelZmcS9KMHR3?= =?utf-8?B?Q2EwMW8wM0grWmYrcDluRXEydXBlTDdHcXdob2RRMklIRVlPMUdzK3hERXUv?= =?utf-8?B?Yk5QVk1TemdOWitScGhBN1FNa002Nml6Q2tCSWNYQXZDUEtyUFVoK2VQZ09K?= =?utf-8?B?MFAvVENrVDJ0OWNoSEYrekhudGJaOUNsWDNZN2lHNUVHZkRPNWZTVXlXVVkw?= =?utf-8?B?c3QreERLTmhNTWdGdVFLT3lPVVVET252WGc5MDlQbUt5YVYyWnUvQ0NxOFdN?= =?utf-8?B?eDJ6a01rUnlGblRIUzMzMjArODlnYjRrTkZmRmRtNTBESklGREc3OW5IZ21Q?= =?utf-8?B?UjdIcS80N3ljbVJac3VCMmNBYlhSQmR2OWpuMVRPekxMRFkyemNZaFhVQkxn?= =?utf-8?B?cjB2ckE3M2U3VVFTUitYQkY3cGMrQk5BWFRJbHhtNFlxRFpsVFB1ZFhWTEMx?= =?utf-8?B?SjRqR1ZZSFZINHJvS2lvMnhCNU9MR25PRGQvYjV5KzVOMWtYRVFkVncvNHpW?= =?utf-8?B?am9kSkxzRGdPWEF0RmpCbkFic2NwSXEzME8veUF2MTlCUDRRclAxYUZOK3RP?= =?utf-8?B?dUtsWENDZUN5eVd5Y3dhNzdhOHlNcXc2blpGWWNLaDE4SWxEUU41a080Yk5m?= =?utf-8?B?RHRrRHNjRm8wWnRkVXpPNFVPMXJFaUsvS1YycE03OXBpSUttYnlVekRGVVB6?= =?utf-8?B?SWtiQnppRm92cmdpTlVzU212cE9rV2pQaXQyUTFwaFFvQy9xVWZkK0lRY2xa?= =?utf-8?B?WDZIeVdnTWg3YWU2LzZBNnpFbnZxL0Q1SytlREtyRTdYeGlwUjVvMkVOdnF3?= =?utf-8?B?elBrY0Z5blJmNlNlanIvR204NVloQmUzLzNIWDBYdXE5MktVV3VOWU9DT3NF?= =?utf-8?B?NHVRNkVzbHErdGhValppeUtVdXJNVjF4YkhuNTdaM2liRzZkTko1V2NVbnF2?= =?utf-8?B?MGpKcGVpeU1wSzdVME9heHRLT3BCVk1FV0g1U2h3Nk1sOWJxaUt1VkRlNndP?= =?utf-8?B?TS9CTXpRdDhvMjhLajdYTGNPVDQrdVRnV3ZyU1F4cmJOeFJ5WDVFNlNWNWpH?= =?utf-8?B?dTBteWkvdTUrVE81SUZxTGM4MzdyS1ZHMHN2SVNWNCs2dWdxbnNHK2lWOWJ3?= =?utf-8?Q?MKlozup90Lyg6/NxQw/uQyCVd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25746d18-457f-48ff-3434-08da6e13b0f2 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 08:00:07.9693 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UZw2smRKJBAVO95MZvL9kO8O/T1IaiMSHOsF5beqGipaSAgNYkiqoo+aMF/P0Uqm3+rd9nwvgvECgjLWfCCdXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4228 On 24.07.2022 19:31, Xenia Ragiadakou wrote: > The function snprintf() returns the number of characters that would have been > written in the buffer if the buffer size had been sufficiently large, > not counting the terminating null character. > Hence, the value returned is not guaranteed to be smaller than the buffer size. > Check the return value of snprintf to prevent leaking stack contents to the > guest by accident. > > Signed-off-by: Xenia Ragiadakou > --- > I 've noticed that in general in xen the return value of snprintf is not > checked. Is there a particular reason for this? I mean if there is no space to > fit the entire string, is it preferable to write only a part of it instead of > failing? If that's the case, then scnprintf could be used instead below. You will find lack of checking particularly in cases where the buffer size has been chosen to always fit the (expected) to-be-formatted value(s). While in a number of (most?) cases this ends up being fragile when considering general portability (like assuming that "unsigned int" can always be expressed in 10 decimal digits), I guess making such assumptions has been deemed "good enough" up until now. I think this also applies here, so ... > --- a/xen/common/hypfs.c > +++ b/xen/common/hypfs.c > @@ -377,6 +377,8 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template, > unsigned int e_namelen, e_len; > > e_namelen = snprintf(name, sizeof(name), template->e.name, id); > + if ( e_namelen >= sizeof(name) ) > + return -ENOBUFS; ... I wonder whether you don't want to additionally put ASSERT_UNREACHABLE() here (but leave -ENOBUFS to keep release builds safe). (I also take it that you haven't found an actual case of the buffer being too small here?) But of course the main purpose of using snprintf() is to avoid buffer overrun, so truncation is indeed deemed only secondary in many cases. Which doesn't mean adding such checks would be unwelcome - it's just that in some of the cases your options are limited - see e.g. the other similar use of snprintf() in hypfs_gen_dyndir_id_entry(), where the function doesn't presently have any error cases. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 08:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 08:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374445.606495 (Exim 4.92) (envelope-from ) id 1oFt4i-00019h-GB; Mon, 25 Jul 2022 08:04:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374445.606495; Mon, 25 Jul 2022 08:04:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFt4i-00019a-DR; Mon, 25 Jul 2022 08:04:24 +0000 Received: by outflank-mailman (input) for mailman id 374445; Mon, 25 Jul 2022 08:04:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFt4h-00019U-DJ for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 08:04:23 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 645b675d-0bf0-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 10:04:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB7119.eurprd04.prod.outlook.com (2603:10a6:800:12e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 08:04:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 08:04:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 645b675d-0bf0-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FkRZ+hgeQzKN03JFqFe9tCz0vPMKl3HRXbc4B9klujxTtlMNJkytW1kh7BfGuHgkrGQOriyHYrw/4cnjaAFsGv2DaiuVVsfi+quK8cOzk9Wvh4l94FSoJdW/24pTIXLpfmmyKJThML8VhCsj4xYvk9MpIUc1LGtUg0b8w5eUqfJAg3HCJiPtrViYItngTOqeeBLTitdxnz0Kj9yqRZXO1QCnVo7GeRc8wY+gbEPNfL3G53Kira215Dy1xO7QOCJl1ZZrHcryxvBa6R7PKWUm9/5cW3CN/Bd9/ZVmX/DDz3DJdlHf1Cq4jk+BwYo6C9XhxH35I0Y9Y9a4VdogbQHwNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KhP/YKy/mAv37Wzk0qENE4pdZtbRspMJLZCokmVPwTU=; b=Nw8C+wkfRcb8V5Rvqt3YPDCeihQyc9iaQGeLasq/l0idEDk//h+HXDGGyD8PPlZ3T6/GcWEM8bwxKH+zNd/hdC+ys5MKecwP2+IBo2Uc6azl+VI8ZSEMS5Gn7r44+DRcycvSbpRdkI29iAMYXKzNlKVwXTHRHlql6hsMgkM258/nb19lcUqcLqSap46GZqikcpeANf9cDTIt8bzEiZJd2kSB8Gjx78Db+f64aV+e8BpKLmaEkpEgCwyfwp/JXIOVTY6IW+ibrbZ4/aogN9c2IHy/dBiNTSeqpI+YGl2YGBhbW9sGvUWDtYQPHqDj49LFizbCDYcEufsxhgJkFdNcqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KhP/YKy/mAv37Wzk0qENE4pdZtbRspMJLZCokmVPwTU=; b=YopYgIKUwY6kEC8hUcbxNUr6MEwd/qWUr+EwDK4NI7eareRWzXSl97YRniujA/FofW6rg7fucUMcAbMTpmGlOWIxcdpTmWDb3AIALttEeoVGcYabwsqCIKzij2Honr3kAAEqa5R8tfl2md/lUqY3x/p50Q6hJxeeeJ2VRTHNO3sjQEQ/5axf8StTAc5jC7buQ951gE91Fi0m750960Rdj5/LWjckpiwB3jIt2TR2CeFLs5EOL6Z3Px3I6Zu6mA75VAY68gnhDCkLPDpdjt38QKIjy9ZoBdKlaWVlJs9AlIVa4kqxu5R/GeknrILnU7zlED6ZpAbExHkHdHM7SzO0Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 25 Jul 2022 10:04:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] livepatch: create-diff-object: Check that the section has a secsym Content-Language: en-US To: Sarah Newman Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com, xen-devel@lists.xenproject.org References: <20220725032053.12933-1-sarah.newman@computer.org> From: Jan Beulich In-Reply-To: <20220725032053.12933-1-sarah.newman@computer.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0172.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 50e99a5d-3e9c-4228-756f-08da6e1447bc X-MS-TrafficTypeDiagnostic: VI1PR04MB7119:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZbtZXBJfk9ZHDuaqNPQ3FQaOZctHm2NfoRB0bSKqaK4VuXD3U5epBEXAVXbtY7G39cDHRb8NsJP35G8eJRFlOg5YO+aCZil5WFGrp3MQK/mdIVx/twPmXlSw5PUUp+h0le+pDVTg2l0uCZiup0THrM8+oQ9IZ4tnkMmohfSNf2i80a6jJ71O5zwuu7Vl/XiUR3J+Am8Uz5MXWUU3F8M5DeumQK3Pu2GizU1N/lli2v5qAVNz8jx1bTdYrFiJCu3ii0yM06PlcJw5Xqi8+0fZk65QDEhHj9C7S1DlBg64TLzytF00jFOgo9wPUOIxXP3HGncOfh3gnkq9ConPp+liQ4F9aJPv1Fc3d1mo3vyxGmjW1xi+yymA5w5n8V7ZEFh6bPfIVfc9dwiC4gyuEJARZFMHnjuWN1vDQmgtPONyqEAovH1wAwxYU6ldpCkM4IIoJsumuOEApwYFcYA83Ek83QiuFwZ0h96ek/49F1YVKjIm6vhXATFcleR+IzeK+U5rB8VFBZABpR8ICCc39I4eSjowjPYh5DY+xVdjqnVFZV4/rVvBDVf3lAPS89fEgZtNimIfKtrCLVNZVhv9zZYMioEnzqbo4V784Pgtgk2l8Ek4riiwlQARfafN8wur7aDAa1FC0zHJEnLqnIsVwsN+uxgsyBEVsMZq8Z2PsJGrzIqktXAc1a/VZl760BDrpo0kt3R0wJaZGh+y6c36aqWn+vhdXjTbSGC7emtjP99Fl0YZg8vVGQtDwC4OfIeJ3l+UncRGDrfSz5hQB7nmDMCeAT1Oru6zhUsA8xd2G1wOASj/c8ovi2UhZ92iHJ4vtPsZOsxS0sQzyfj5EAAs/klxOoX7D8aAcVMWyVhIFb5tkLbUOnYgSX9sMinzh9T9mYcX X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(346002)(396003)(39850400004)(66556008)(66476007)(4326008)(66946007)(4744005)(53546011)(5660300002)(36756003)(8676002)(2906002)(8936002)(83380400001)(6916009)(478600001)(38100700002)(2616005)(31696002)(316002)(6512007)(26005)(966005)(41300700001)(31686004)(186003)(86362001)(6486002)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUF3TFdhQXBxVHpwVW85WWNPUzQrNEYyT0VrL3UxdnR2UmE5SEd5Wm1GREtN?= =?utf-8?B?ZnJ2cWhNRzlnQkJDZ2U3dndLaW1CVDNSL1NueHBhbGRhcm5lWlp3aGpmZk1B?= =?utf-8?B?U09OWnRqNW52cWM0bkl3ZHlWZGxLdTBPTnU4M3kzVHVQYythMmYyeVJFTFZT?= =?utf-8?B?aGZYcE0vT1M0ZHhCVnRKdVJHdmt1VDd1dTVQeGhrN0VDNmpuQzk1SGNoQ0Y3?= =?utf-8?B?K1hITCtJdk9PWEc0bS9RS3ZITTlXZTZ6RjJIdDhHS0piM3FxaXZlUStxd1ZS?= =?utf-8?B?djYrK0pnREgzekZ2TThvYzh2dTNyYlF5bkdLTmdBdWhRR3Q1RjhoWXdjeDJo?= =?utf-8?B?Tmw4WUlHdkZxQkFWWm9ucjFod1RpSjhLbWdxN0IyUVB5K25ETWtYYU4wczVt?= =?utf-8?B?MUM2R01RVngrOTU4czJiNWlEZVRFWU5tQVdoYXNybjd0QjlqL3RIZDFKeVhn?= =?utf-8?B?NzAvekJsaEkxcGttVUduSXFEb25rYXkreDhqcE5TRjlLaElsNVI4RU9lblNx?= =?utf-8?B?R2NtUUZGQ3NOWWVIck5mWFZobkovR2wwR3h3WFRTUDNrVDEzL2kwMlFKbTE0?= =?utf-8?B?OE1XOW1tdjE4aVVvWGZJZTlFTUxrODdkUEt1UDExRDkycFYrVjQxSzMxdXVR?= =?utf-8?B?WTJiZ2Y0UXZOdk8xSm1TYTRhWi95WXFYbEM5Q2tBZVZxYVlpVjhpUzRWNFp6?= =?utf-8?B?ZE1Uc2JjYlFOWE9GeVVKaVdMRG9hd2Y2MlE0R3Q5MUtiWDdrTDJaMTNTMHpo?= =?utf-8?B?OU1xRmUrckllSS90dVBzM0JaUkhpWWRqM3ZxQkxwTU1DY1pNZEg4VFdhOUJM?= =?utf-8?B?THplb3BEbHk0bUFNTTE2UEg4MG9GU1Jadnd5VUtjZDJSNWNnMjFRa095ajdU?= =?utf-8?B?YmQwT0NEWGxHWGJyamZBVW9QcVczTW03UW9HdFdJNkhoM3pQUGRVcGlGNjFU?= =?utf-8?B?L0QwL0xYKy96ak1vSCtVbWVxdlRuOWRJQXd0K2lxUDFMSTdFdFZSZDZ3bUVO?= =?utf-8?B?NkFmTzdudk1haVNscnRucVVCa0ZXVm1sSjhMVXRMai9OdVlYQkhoWWFEem80?= =?utf-8?B?eFluV2pFRW1pSXRkU3ROTmwwR2Qrd3lxeU9QREJUZlRaTWlrVGYwN3ZHQlpY?= =?utf-8?B?TGhNTkF0TEozeDdHNTJ2UjZOS3NlQkFmN1Fpa25qNW15cFJYWjVxZGIyREk4?= =?utf-8?B?UmVSRUNhSXB4WmdsUlM3NzBZbXl0ZWdmT1lqZEtYVitielVyNHpIaGtHSENJ?= =?utf-8?B?V0NiYjhkUWZYVmYzdmRUSllmWDd6NitTVlNqSDBtM1VFcDA1bEYyK0w1a2N5?= =?utf-8?B?VU1ZNitKd3F1T0FsT0QyR2g4SHY3NEF3SVd0WWlkMW8yR2R0c29JcWlVbEVH?= =?utf-8?B?WTk0RXUxY3d1TnMyb0NPSDQ4VnhJVDU1TWdBV0E1MlE2Lzlub2R3ODJ3QlNG?= =?utf-8?B?YkxCR1lleHQ3citPNnRUZkdUQTVoVW41UHU0YThMTVJnRTQ4Z3I5YmN5UXN3?= =?utf-8?B?akR6TmxBcUhlbWxTbWxTRWE0SzRUMGJvbEcvWXVvSVpFSVpPR0VnQ2NBdk12?= =?utf-8?B?cDd5Sm90WHdSWmovWGk5bGYrNGxQQ0tZdHRmNWFyNjJ0REVRc1A5cGQrQ0F3?= =?utf-8?B?cVlJNFRQNko2K2ZnVytiRVZ1SjlFMjczMjRuYlpyZzlHTHVaa1IvU2pVbE5M?= =?utf-8?B?Nmk3K1ZoMGFxMGdXa05icE9LdmF1RmVxb1UwS2pieXJaL1FZbHRNN01BN2g0?= =?utf-8?B?UjJLeW9VKzRCVTNrZThXdmxBWjFDdTBCakhSSS91SEt2RjdtcFlnZmJYRHpJ?= =?utf-8?B?ZnlWVHBNMm5ndE1wQUxQMW5LY3BkaVhnQjZxNDVVbWErTnhvcHJEQURPdjNY?= =?utf-8?B?bFVNSlJGajZzUzR3NnNiVGU1R1JKVVhkSGhBUTRzMktRbE0xODJ3MHIvNGNQ?= =?utf-8?B?SXFiRmxIODFlVGdqZDI4L3JwbWVDUHBzUXVLQmpjdlFqbUJlZGVMMWd4OUx6?= =?utf-8?B?NUhyUUFXaE1MN1J6eGUrMXl0UHVyeTNVZVVJNHBYTGNUUmJXZm9HZHNZaTBI?= =?utf-8?B?NGhNVWVSVmRERVEyVUVGT3RraHd1Q01OT0RtTHpWY0pDQ3JIZjNRUndEbXNI?= =?utf-8?Q?N+U1td49oiv7o2Vn2mp1t9JfN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 50e99a5d-3e9c-4228-756f-08da6e1447bc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 08:04:20.9999 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LK5xy2BNkbnmQwjb2i63nX0xMmLWGFzFWtfOX8TxNYLVf4CaXF20zLL2S1jPM5fyPn683aK2y+bF3f3byfXoqA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB7119 On 25.07.2022 05:20, Sarah Newman wrote: > A STT_SECTION symbol is not needed if if it is not used as a relocation > target. Therefore, a section, in this case a debug section, may not have > a secsym associated with it. > > Origin: https://github.com/dynup/kpatch.git ba3defa06073 > Signed-off-by: Sarah Newman > --- > Changes in v2: > - commit message changed to use Origin With this I don't see why you didn't keep Ross'es R-b. Please help committers by keeping tags up-to-date. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 08:23:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 08:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374452.606506 (Exim 4.92) (envelope-from ) id 1oFtMg-0003iG-1a; Mon, 25 Jul 2022 08:22:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374452.606506; Mon, 25 Jul 2022 08:22:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtMf-0003i9-Uu; Mon, 25 Jul 2022 08:22:57 +0000 Received: by outflank-mailman (input) for mailman id 374452; Mon, 25 Jul 2022 08:22:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtMe-0003hz-VE for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 08:22:57 +0000 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [2a00:1450:4864:20::331]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fc0f1410-0bf2-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 10:22:56 +0200 (CEST) Received: by mail-wm1-x331.google.com with SMTP id a18-20020a05600c349200b003a30de68697so7328035wmq.0 for ; Mon, 25 Jul 2022 01:22:55 -0700 (PDT) Received: from [192.168.43.143] ([62.74.23.66]) by smtp.gmail.com with ESMTPSA id l7-20020a05600c4f0700b003a310fe1d75sm18959251wmq.38.2022.07.25.01.22.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Jul 2022 01:22:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fc0f1410-0bf2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=15aj+0E/UcFe5hRzcTzX2m7ze62KPV2MGGip38EmLKU=; b=QNEqUSqby8SN60gPFrHSLP8iubXPMcJEPrT0eSYx9PVHS1u28V735xzZI++/rKHsYU tnJ9d0KqnogQUS7e0LEDz/mHdxIyo6+epciX/dt4ip68/SJ019OHFW98fa8G66yKbofk 3xK2xuS44EgZCCePMjI+E2GrqxXzYsCJwNdTRyy5rhz8fAkCK9uq+Yo3pfDhoFSOq4fB xaqWqsyDV6R5hp826d02lmaWPxNg3ksQomYOVKfVgfWkJWsPhyPz2xkwJudp4AR+TgdX WzNUGo9ik7JX+Yc1TOf/t+irVu7H3aUP/qlimIxMbG6MeZbVBURYIVLDzGnqCKEgAcvZ SocQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=15aj+0E/UcFe5hRzcTzX2m7ze62KPV2MGGip38EmLKU=; b=oMdBsq7DDskwbdh4h4n56IpaHWSOdIsgLSBLBfE5SDYSUifRKLph7nd77UsAURNJ4z M8seITGbNYq+iMhPUYipS+y/kdBkaAfbOOErKTR8OlDyKACBiPlLZ8549k9Nw7MxmEmM AD2I+7v8THNvzwKQASoQtCh74YNl+QzUdgt9b0qmVACbRGFOKboOl7dH+xbG+mydGvR+ cG8pnPSxMWB0Kigo04sQBwL9fe6NF+9Xp/GqsVw1AEF3B3vVOidQTlvaGB07qrV0AE3A seL3BMak9Xr5tYmxgsdK+RwDvl+cnkrwRToUryTBfNoDnTB8cySFsPPQmGmE0qaRoEvu GVOw== X-Gm-Message-State: AJIora/cPKRmIrNaktJpWf5F2F6tAsgPI+zCyjgb9QrzMQZ+g1UI23Ck 1NxgZmdErkezZGWdaGASvZAsfUPkP+4= X-Google-Smtp-Source: AGRyM1tsHG2gnVWK6/oSuF1dxKOiQ7tMYSBKmx7WEdXBE6xLj3X2Q8sy38lYXE89srUnCMAvVzVLhA== X-Received: by 2002:a1c:27c4:0:b0:3a3:365d:10a2 with SMTP id n187-20020a1c27c4000000b003a3365d10a2mr13146366wmn.61.1658737375234; Mon, 25 Jul 2022 01:22:55 -0700 (PDT) Message-ID: <1d64331b-5258-6c91-82a7-54fc7f2600ab@gmail.com> Date: Mon, 25 Jul 2022 11:22:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently Content-Language: en-US To: Jan Beulich Cc: Juergen Gross , xen-devel@lists.xenproject.org References: <20220724173159.410535-1-burzalodowa@gmail.com> <69b5906f-163b-b7cd-81ed-98be8e45bdf2@suse.com> From: Xenia Ragiadakou In-Reply-To: <69b5906f-163b-b7cd-81ed-98be8e45bdf2@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/25/22 11:00, Jan Beulich wrote: > On 24.07.2022 19:31, Xenia Ragiadakou wrote: >> The function snprintf() returns the number of characters that would have been >> written in the buffer if the buffer size had been sufficiently large, >> not counting the terminating null character. >> Hence, the value returned is not guaranteed to be smaller than the buffer size. >> Check the return value of snprintf to prevent leaking stack contents to the >> guest by accident. >> >> Signed-off-by: Xenia Ragiadakou >> --- >> I 've noticed that in general in xen the return value of snprintf is not >> checked. Is there a particular reason for this? I mean if there is no space to >> fit the entire string, is it preferable to write only a part of it instead of >> failing? If that's the case, then scnprintf could be used instead below. > > You will find lack of checking particularly in cases where the buffer size > has been chosen to always fit the (expected) to-be-formatted value(s). > While in a number of (most?) cases this ends up being fragile when > considering general portability (like assuming that "unsigned int" can > always be expressed in 10 decimal digits), I guess making such assumptions > has been deemed "good enough" up until now. I think this also applies here, > so ... > >> --- a/xen/common/hypfs.c >> +++ b/xen/common/hypfs.c >> @@ -377,6 +377,8 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template, >> unsigned int e_namelen, e_len; >> >> e_namelen = snprintf(name, sizeof(name), template->e.name, id); >> + if ( e_namelen >= sizeof(name) ) >> + return -ENOBUFS; > > ... I wonder whether you don't want to additionally put ASSERT_UNREACHABLE() > here (but leave -ENOBUFS to keep release builds safe). (I also take it that > you haven't found an actual case of the buffer being too small here?) hypfs_read_dyndir_id_entry() currently is used only by the cpupool pooldir and the name needs to hold an unsigned int. So, currently there is not a case of the buffer being too small. > > But of course the main purpose of using snprintf() is to avoid buffer > overrun, so truncation is indeed deemed only secondary in many cases. > Which doesn't mean adding such checks would be unwelcome - it's just that > in some of the cases your options are limited - see e.g. the other similar > use of snprintf() in hypfs_gen_dyndir_id_entry(), where the function doesn't > presently have any error cases. What I considered an issue here is that when copying the buffer to the guest we use the value returned by snprintf(). copy_to_guest_offset(*uaddr, DIRENTRY_NAME_OFF, name, e_namelen + 1) Also, if truncation is not considered an issue, I can remove the check and replace snprintf with scnprintf. -- Xenia From xen-devel-bounces@lists.xenproject.org Mon Jul 25 08:31:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 08:31:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374458.606517 (Exim 4.92) (envelope-from ) id 1oFtUu-0005G5-TD; Mon, 25 Jul 2022 08:31:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374458.606517; Mon, 25 Jul 2022 08:31:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtUu-0005Fy-Q1; Mon, 25 Jul 2022 08:31:28 +0000 Received: by outflank-mailman (input) for mailman id 374458; Mon, 25 Jul 2022 08:31:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtUs-0005Fs-RW for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 08:31:26 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80085.outbound.protection.outlook.com [40.107.8.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2bb328e3-0bf4-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 10:31:25 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8967.eurprd04.prod.outlook.com (2603:10a6:10:2e2::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 08:31:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 08:31:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2bb328e3-0bf4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fYT2IEoQd8425oRLuFV3OYDUXG5Bs0zG68a8MGIPLTV+yXh+WcVlZrx915v8WxPONuzLF3uXDPVRMrWv3O0kx7VqTPqZyGQm1GRyHTn+sqH5VGPCjFUhHZAqDAWzdJWf5cZpK7fmlQGKztctw375Tgk9IM5M2LJnbhQ9wPrlVup1vCMLhHMfHECSKTdBibf5cs34vdvO4MXssu3ErtvZmEOAeJM99uHaQLh8W4X+kKESD4bLCIBT6bJUPoQiwqfXLnVwqOl8d1yeivZEFk9pChZ+BjkfV0vOkhZH22A+YKKvn/tNdItLVNnnzt9lyUwY1bsLafl2E+eOsb8kBurXyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fIKnc8hrWldqcpl27vlFISaBuD349hjOuyHFj0Bg/RQ=; b=OXjL9w2kTj643+E1qr2pzzoNXE+0hdd0EHZZAQSD36knPfu22GPrFWU+6KFlPuKtXZpViVCj9OnncZrp6YRagg5Li7lTT21PpSqnV9wPDnv9DEbeMWP2tQMIXd+Jor5QQyYbOgx6DRFm3RmJiNTNZcwHBOzUyzFW/yJTdEBe3J3jkHd8IUD/G9PwjG7fVSnaZsAUhU9u3cRbMZFcyeEbDCyZ8UJgNHoAf15NGmGrbfvAt0G+kvRGXjgCtFko+itwtObUqiDPCSHEeo/OrpNAA6KPVuwjcP+mLurYepw1mC6oUsNWQhR448XWU+sUG2uZMLf5gzkHfMPdWBwQVt/ZQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fIKnc8hrWldqcpl27vlFISaBuD349hjOuyHFj0Bg/RQ=; b=P1tiz+7VfcgWGzjp8ObXJeM5/fngOCVC5DBXycyZMMu0KVGjtYqEJijBFYb8MumZHzuqmlP+VTRF+QX8YbtRTViMpNWtgUDKp9T+b65ry6Xtkkhff9S4Ce7hrg/63l+xZLTsLe8BWQWXDf0eBiQ9gOS5LpSCZH+qJPnSPVyxvHVAtMgp0hWUeckORl4pbsEjYuRxAuKcbCA/gGfivw8pghy8qM1ubkx7xWUOyNjEEDSL3PHWzfqtkzrZy1v5H5YNYNNifwoSGB9hbr+/+zR/prb1aVKQDPb4yOZ2JuE86/VK4G8YwVazb7it+9HRu6MpeMEgdNEoj4bZ5F7LiIZMSg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <4f18499e-57f7-ed8d-f3fb-9a0ea9d8ac05@suse.com> Date: Mon, 25 Jul 2022 10:31:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/hypfs: check the return value of snprintf to avoid leaking stack accidently Content-Language: en-US To: Xenia Ragiadakou Cc: Juergen Gross , xen-devel@lists.xenproject.org References: <20220724173159.410535-1-burzalodowa@gmail.com> <69b5906f-163b-b7cd-81ed-98be8e45bdf2@suse.com> <1d64331b-5258-6c91-82a7-54fc7f2600ab@gmail.com> From: Jan Beulich In-Reply-To: <1d64331b-5258-6c91-82a7-54fc7f2600ab@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0145.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1280982f-f217-4290-7b11-08da6e180de9 X-MS-TrafficTypeDiagnostic: DU2PR04MB8967:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zUt1VKLR5zvXrBAzY4Nu0GB3P+/GIKvKgLSZ6H92jOPhHQQzQYKSOpMxu32pstWA5GrY3Mu/pVWd7oDaTQr3roPXH5XM1CLIUvoasBjPFfrVYnAmKObVz+c8/PBlr5+jRdsEtqU2tJgYWFrnlN28KIHDf4MtjPGqL9jeG8iRhpT8eUm16Ty6scX5J8LzkS5r0sqRDSDq+BstTBYu1IEJYdi3D6OFEIYelbQrmost0b+/NUSLI8GousSZ4MTvNaHFHZjOq85O0Pkblsw1Vv3SILExiSjXxF0HzSJcZpfNPI2ZwpeS8C9j1Oezno/OFpRGow3gV+6k0EY+b6+Cl9pZkF/WwDZwY38MD+g2mAQeFml17ESgr//kLeAc8mC4MJg05XeGzs8GhRRtLWhDnpVUFX4QSKyDvmlc7oEa8b4KQhGyFl9VlDTPhuLf5iSVCdpwvIBhQxyBR6EqY5loJuMlO+E42ueDXDv/7iRMT55CDNI1tEkCwujAeJFNSZD0IaLf0OHMthwA49eh7+4r8ba9OrDy6OzOhr4IxkvTE5K9WQf/fWwuNHxCdxQ6r48dXVdwTtqRHlbSlwXwfzB+4YQD46EiNEH/9sCRBhdHzrW3k9eqZN9tnqec0yPc2ZqBmFgqkDCB5stu0XD4+33Ufd7Nzno81f/89iPSRdpUEX+HSwB7v+Ef3HRfUHJEQmaU1/5aa6vzYnvjE8u5Q3jERkSRDewbAV5/DvyLJXJsvLt2nhmQl42qycQ3L3A5aYqAsZPoLMYOEL6FlJ3DtMU2die7lmmjvRyWKr/2w0TqRuEXoK7lOL/FIl57DFaUDFbOTZdXA2QAohyQxlyQjFvbTUCm6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(376002)(346002)(396003)(38100700002)(316002)(6916009)(36756003)(31686004)(186003)(2616005)(478600001)(8936002)(5660300002)(6486002)(26005)(83380400001)(66556008)(41300700001)(4326008)(2906002)(66946007)(66476007)(53546011)(8676002)(6506007)(31696002)(86362001)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0ViTVlpYmNEU3hVeXIxODFCMjNIVnFHVWhaNzB4ZGtzRGhmb3VVaEJNYno3?= =?utf-8?B?Z09nR2gxTGE4WHltSmQrNXdxOGFzL1B6bEtaYVdLTVBoOStIYmt0dnVYTDcz?= =?utf-8?B?ZmFHcXJrMXV2b056OW9nVEtiVHZNUUdjN1dPMi9CaSt3eTFSQmZ4aDRTci9i?= =?utf-8?B?Q21TeUcwVmE4Vy9ETlNRMnAzNjNYRnYxZEt0SFJhejVGMzFxV2pqdzd6VktJ?= =?utf-8?B?aml0dURPa25waUdPZ1pSM2xjdm9nZXQ4NDMvVTkvZi93RGxpbXhmZGhrdGoz?= =?utf-8?B?VUhXK2xIWXl0L090RVAxUmozaFRhdk9tS0ZpN1BkZm9NMGlzb1V0UkkzWTN6?= =?utf-8?B?SWNtNkNreHBKLzRXbEpGRHQ0MzEyWnJMR1ZwVUpEUlNsU21GWXBpNTVYZzdO?= =?utf-8?B?SEFPK0hRMU1CbkFCbHhhak5TY1I5LzJoU3lkNHRTWktwemJDRkZaVzVINy94?= =?utf-8?B?MEhtYXcySGp6UmpqYVBjcTErL09GZW5TMlU2Ri9Lc3BKTGFlbDh5Wk1TYmJi?= =?utf-8?B?cUEvbXNtTUxNOFJNYlVZTHNESWVTOUJVNFFCTkhzcUdobXF0VlNUb0J4dE8y?= =?utf-8?B?bVRIZXp6czAybTFuWW1mMzB2cVpwbDVBK2NqU3ZwK3cvT0MrVitDb0t2SCtx?= =?utf-8?B?K09EZ20xcjB5NlhGRGdHalpIc25wTVc5QSt5RklqcTVoOFJ1R3lNcytCQWVJ?= =?utf-8?B?MlhkdUtyZjRSdXhwcGNlTEVqMkN1S0FkS1BmbUI3UXJRaXFMOStmZ1lhN1F1?= =?utf-8?B?N2NvRmovdXQ1djlqZ2lDaDM2aEx0bjM5cG1OSjI0UnVJZnVPR2tEbTAxK3VE?= =?utf-8?B?S0xVY0NEb0ExTG5hZWE4bGZ5TVJPSi9MUFNXMFZudkQvRWZONVUvWk1vYTFR?= =?utf-8?B?VUxTWHJtQjVlZ09JdHpIMHVWai85ZlVkTnI0VnFTZGhwQkxzRU5rOVloelI5?= =?utf-8?B?bDMxV213K25TK3dOcE55MmovZHJLS1ZKdTZjRGt4Y3Y3WmNmY0ltdnFPbFVk?= =?utf-8?B?eC9mWUQ4Qzh6OWE2aEZNdFY1M1cxSitNRlNnTC8ySkZYSU1XdGZ3ZzZVYjEy?= =?utf-8?B?cElYUjcxaFd2RkVtTnJ0RmJVeHdIVGxqem9GcDBrL3VNZVp0VXRHMHhHbDhE?= =?utf-8?B?YnhGVzdHUUZRc3UvNjRXeTh3Ujh5WU1yYXVxU1hCcCtqWDJmVjdMYTNQeXgz?= =?utf-8?B?Qy85OHZKMlBPcTZ3U0Mrd1AvZCt3blVVazdHTDhuYWhYU3VqbjlGY3BHejJS?= =?utf-8?B?RFFoR0FyZVFMUTlXcTdONTBpaGVja2hjVVRtQ3lweVVjUTdvWHh1MmRkV29L?= =?utf-8?B?NUhXUXJKQW9pdVFxQ0ZISklqQWNwdmJLOFRJeTRMSGdraXBpRkJYNVp4RFNW?= =?utf-8?B?V0tDaVFFWGxBekRtU04vMXgyYjNGbEJBMkVFd0NNdUM3ZnNiVkdhemRJa1p3?= =?utf-8?B?SmpWTjdteUs2SU80UzRlTkxUWVlRY1ZXalFOaldDNkdIQTZLdmZPVURZY0M3?= =?utf-8?B?dGNzVmJjRHpZdjU4MVlEeVlyMHB3U212dWtFT3pIdjk5ZG5xQlptdHBuaUJB?= =?utf-8?B?WHcyU25SV3dkRHYwM28rV0diY1dyVTJDRm5hM1EwV1lWU2V2VDZsWG5FQlVK?= =?utf-8?B?RklKY21hSG0xTjlkTW50NWkraVQ1UW9MS2Z2MlZaV3BMRHFNYzRtR3lFZzRj?= =?utf-8?B?aXFPcWRZUUxrWll1T01iZVlxdmk3bTIzdW1jZGRMTlUrOWxWeERKdThBb1NI?= =?utf-8?B?WUFaM3BGcUgyNmd0RFYwTTRiaWNYelhGUTdiZFZQWFRvYzlBbzNwc2k4cVpV?= =?utf-8?B?MzVkYmoyLzZlSlRxK2crZHp6anhKRFNCK1dEY1JUSHJnN0Q1eTMvWXUrb1NV?= =?utf-8?B?Z2lOK01BemNZY010SWZielV4V0s2WEhGbGh0M3BwZEs5RkFjWS8ydFBEZVha?= =?utf-8?B?YVVYMWk1MmtUSGdGOXRGeUJUUTdERmF2aGw3ejQ1akRuVUZOYmdsLzYvOXVM?= =?utf-8?B?bkxOUm1hdzBWUVdtRFNiUDJSYjJGNzRJVlBZK3YwUXk3ZXMweklSRDFmN2kr?= =?utf-8?B?L2U1VnZ2N3ZsTTNoaGZZVlI1bWJDaXRLUmpRelBTMGZPZnBKMFk2d25RcWN3?= =?utf-8?Q?qMgg+B8sFW+079P7bHSNZhCes?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1280982f-f217-4290-7b11-08da6e180de9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 08:31:21.8803 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GiP+HNVbGyAOBGquxTrZe/kpaIbt3HDlEI0QJsEUVomyu1v4zk5I294u4sq4uj44yQ/6T/3g+cCdGePuA3gsCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8967 On 25.07.2022 10:22, Xenia Ragiadakou wrote: > > On 7/25/22 11:00, Jan Beulich wrote: >> On 24.07.2022 19:31, Xenia Ragiadakou wrote: >>> The function snprintf() returns the number of characters that would have been >>> written in the buffer if the buffer size had been sufficiently large, >>> not counting the terminating null character. >>> Hence, the value returned is not guaranteed to be smaller than the buffer size. >>> Check the return value of snprintf to prevent leaking stack contents to the >>> guest by accident. >>> >>> Signed-off-by: Xenia Ragiadakou >>> --- >>> I 've noticed that in general in xen the return value of snprintf is not >>> checked. Is there a particular reason for this? I mean if there is no space to >>> fit the entire string, is it preferable to write only a part of it instead of >>> failing? If that's the case, then scnprintf could be used instead below. >> >> You will find lack of checking particularly in cases where the buffer size >> has been chosen to always fit the (expected) to-be-formatted value(s). >> While in a number of (most?) cases this ends up being fragile when >> considering general portability (like assuming that "unsigned int" can >> always be expressed in 10 decimal digits), I guess making such assumptions >> has been deemed "good enough" up until now. I think this also applies here, >> so ... >> >>> --- a/xen/common/hypfs.c >>> +++ b/xen/common/hypfs.c >>> @@ -377,6 +377,8 @@ int hypfs_read_dyndir_id_entry(const struct hypfs_entry_dir *template, >>> unsigned int e_namelen, e_len; >>> >>> e_namelen = snprintf(name, sizeof(name), template->e.name, id); >>> + if ( e_namelen >= sizeof(name) ) >>> + return -ENOBUFS; >> >> ... I wonder whether you don't want to additionally put ASSERT_UNREACHABLE() >> here (but leave -ENOBUFS to keep release builds safe). (I also take it that >> you haven't found an actual case of the buffer being too small here?) > > hypfs_read_dyndir_id_entry() currently is used only by the cpupool > pooldir and the name needs to hold an unsigned int. So, currently there > is not a case of the buffer being too small. > >> >> But of course the main purpose of using snprintf() is to avoid buffer >> overrun, so truncation is indeed deemed only secondary in many cases. >> Which doesn't mean adding such checks would be unwelcome - it's just that >> in some of the cases your options are limited - see e.g. the other similar >> use of snprintf() in hypfs_gen_dyndir_id_entry(), where the function doesn't >> presently have any error cases. > > What I considered an issue here is that when copying the buffer to the > guest we use the value returned by snprintf(). > > copy_to_guest_offset(*uaddr, DIRENTRY_NAME_OFF, name, e_namelen + 1) > > Also, if truncation is not considered an issue, I can remove the check > and replace snprintf with scnprintf. Well, it is my view that truncation (if any could happen here) is an issue which does not want papering over. So I agree with you sticking to snprintf(). Still I think there's an internal assumption that truncation should not happen here, hence I've suggested the addition of an assertion to this effect. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 08:43:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 08:43:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374467.606528 (Exim 4.92) (envelope-from ) id 1oFtgC-0006w6-1s; Mon, 25 Jul 2022 08:43:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374467.606528; Mon, 25 Jul 2022 08:43:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtgB-0006vz-V7; Mon, 25 Jul 2022 08:43:07 +0000 Received: by outflank-mailman (input) for mailman id 374467; Mon, 25 Jul 2022 08:43:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtgB-0006vp-GD; Mon, 25 Jul 2022 08:43:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtgB-0001a2-7u; Mon, 25 Jul 2022 08:43:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFtgA-0003O7-Ua; Mon, 25 Jul 2022 08:43:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oFtgA-00058F-UD; Mon, 25 Jul 2022 08:43:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=kfCE1ikJqk5COpXbkC6tA+ro5gX97DDRz+UcQlqQQeA=; b=co0JJIo4KcOe6aiqq+wqJKG8GE a+IG1qZTnHXbMoPxeEv4ufvJO8sWvLeQwkaC2x5VTJfelx7No8A0m5krX2JStJrA0wFW88M6LgUOJ 2pyQgwFDVw4v+s+TwHOjwXuS1M2j1a0e+swh6YJGJnDQx+UEw+A9nYFIyw4c3jMwOcO8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171848: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Mon, 25 Jul 2022 08:43:06 +0000 flight 171848 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171848/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail pass in 171823 test-amd64-i386-libvirt 7 xen-install fail pass in 171823 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt 15 migrate-support-check fail in 171823 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171823 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171823 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171823 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171823 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171823 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171823 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171823 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171823 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171823 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171823 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171823 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171823 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171848 2022-07-25 01:53:37 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Mon Jul 25 10:04:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 10:04:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374479.606539 (Exim 4.92) (envelope-from ) id 1oFuwG-0007FG-Tg; Mon, 25 Jul 2022 10:03:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374479.606539; Mon, 25 Jul 2022 10:03:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFuwG-0007F9-Qh; Mon, 25 Jul 2022 10:03:48 +0000 Received: by outflank-mailman (input) for mailman id 374479; Mon, 25 Jul 2022 10:03:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFuwF-0007F3-5w for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 10:03:47 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 106f1472-0c01-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 12:03:44 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2022 06:03:41 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by CH2PR03MB5287.namprd03.prod.outlook.com (2603:10b6:610:9e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 10:03:39 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f%7]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 10:03:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 106f1472-0c01-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658743424; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6Lt2GgxNPsKiOQY6yDwIBYB4wb+bQmMpmZwN5uWlm2Q=; b=OfHH9l9MtUzxs42VN/WlY30nJ6hbyznzMbxSDMD925PlwgDYrj9cSYbK eh8KLuSapBkB8ZNl1hKdWu6BnrUBG57llRNjTmWxMWgw2jQ8x44GNr3Cx ZXEBRpmXGD5u+CdasK8CIJhp9ltfeMj+ieOMIejGkKDyWhXn264ObcifJ o=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 76543497 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:T64oFK3G0IIG9H55q/bD5f9xkn2cJEfYwER7XKvMYLTBsI5bpzIBn GMZW22POavfYzakfo1za9njp04H78PdytA2TlY5pC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrc8k435ZwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj665PA29rGqoow+tmHHkN7 b8fAiAJbR/W0opawJrjIgVtruIKCZCyea865DRnxzyfCus6S5feRamM/cVfwDo7msFJG7DZe tYdbj1sKh/HZnWjOH9OUM54wLju2ya5KmIEwL6WjfNfD2z77gV33f7IOd7cftWMSO1en1qCp 3KA9GP8av0fHIPBlGberiPz7gPJtRLyRpMtPoK+zKEpoXup/z0YDCMEUHLu9JFVjWb7AbqzM Xc88C00rLN081e3VN7jRB6piHmetxUYVpxbFOhSwAWMzLfEpgWUHG4JShZfZ9E88sw7Xzon0 hmOhdyBLSxitviZRGyQ8p+QrCiuIm4FIGkafygGQAAZpd75r+kbjB3VSc14OLWoldCzEjb1q xiWoywur7ESi9MXzaK9/ECBjz/Ejp3ISAEyzh/aUmKs8kVyY4vNT4awwVHf7PtGfMCVQzGps HEalo6e5eYVAJelkC2LXfVLHbe16vLDOzrZ6XZ/T8cJ9Dm3/XOnO4dK71lWJF9gGtQVZTjzJ kTUvGt5/4RPNXGnaat2ZYOZCMkwy6XkU9P/WZj8ad5DYYN4cgOdyz1/fk6b323rk08EnLk2P NGQdsPEJXMaBLVhwRK/Qu4P1rltyi1W7WHZSI3/zh+n+aGDf3PTQrAAWHOFaeQ46uWHoQPa2 9dZK8aOjR5YVYXDjjL/9IcSKRUGKCY9DJWv8shPLLfcfkxhBX0rDOLXzfU5YYt5kq9Jl+DOu HagRktfz1m5jnrCQemXVk1ehHrUdc4XhRoG0eYEYT5EB1BLjV6T0Zoi IronPort-HdrOrdr: A9a23:oSxD2q8QvlFcFfJjAapuk+F0db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFq7X5To3SJjUO31HYYb2KjLGSiAEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpodKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1kjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3TRY0eTFcRcso+5zXIISdKUmRMXeR 730lMd1vFImjDsl6eO0FzQMkfboXATAjTZuCKlaDPY0LDErXQBeoV8bMtiA2Tkwltls9dm3K 1R2WWF85JREBPbhSz4o8PFThdwiyOP0AwfeMMo/ghiuLElGchshJ1a+FkQHIYLHSr85oxiGO 5yDNvE7PITdV+BdXjWsmRm3dTpBx0Ib1+7a1lHvtbQ3yldnXh/wUddzMsDnm0Y/JZ4T5Vf/e zLPqlhibkLRM4LaqB2AvsHXKKMeyXwaAOJNHjXLUXsFakBNX6Io5nr4K8t7OXvY5AMxItaou W1bLqZjx9BR6vDM7z+4HQQyGGyfIyUZ0Wc9uhOo55kp7b7WL3ndSWeVVFGqbrSn8ki X-IronPort-AV: E=Sophos;i="5.93,192,1654574400"; d="scan'208";a="76543497" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZEXdpcaoJisglOJeG5MBQHtJq3pnd8UBLNMNXZmIdBp4qsvJnUh2FtlDhWKEnh1kAlfdNWyve8bYsclb1DzXR7NCqXWXpgThbFnLZ1gZmZmAOcDZ/8c9A0IVCVtcOtN7s2scjiW7l0pj2D8Ldys1gzD1PEXxohlhEZQSrjZgk7BJGTWPSOkHEt79g9w34Rbhg9AIg7bs7X0ReOJ/46EIBEErAyRCHpeIkWgpql7wsrH715wzGwg9S+7h4gprrwGn/hDlhHytq5dAokA4eRjxmxf0FRqA4pI6bV1hWK/IyOLfUcqYJ18+wiJ4gselplxYEQptxYBvCJs0XuW6KJLSDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Lt2GgxNPsKiOQY6yDwIBYB4wb+bQmMpmZwN5uWlm2Q=; b=bCDQjsunsU8HtuxF+AAYxy+Wj5LfTEgx0DDQpB+rlooNqMqlcbSIaaaKQuEQjjrMAXktU3Y+i5YoUBWvIYD8rpXipPx3aXgBP8ouRCl03fHn4W0IpQJ7thtwYTOOAAogm6CZkQngAnb27wyZ8YB77j8WlmibuvSZEBpS2RjsvnHSY1AzwwdOflK464TkO7PblZwtJL/NoVI1HuqRNHAmI0d+3hAXhx5yds+TzeS7GYN7cLMxkXJVuJw6EtujVy3CBe5oUSoYltuZ6YnFLAkwdCh+H8nTZ6GEUvpSOoxYdf1wvYJNxKjCkHKfnDsILaNExnbFj9Mdkjf/yxpJb24+ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Lt2GgxNPsKiOQY6yDwIBYB4wb+bQmMpmZwN5uWlm2Q=; b=ucxVVOh3LWMATdffNwmfzuy+agNbzQT8VlV8G5VNq0lA8IvgHG5IpN94MI2NbHsySts+h8NIu8LEqRYIJ4VFE8PpWPVL/IZJNWM/EhzAHPapK6E44/7Lqv+nnqjSHfRNTRgcOMuOTTQ2xDPILx+fng4KgxPUv38bn/GvaN8DUtI= From: Jane Malalane To: Boris Ostrovsky , Andrew Cooper , LKML , Xen-devel CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlTod5hgtPAUSGEuMopkQlGVYGq189b0AgAImowCAABm4gIAAOBkAgARvxACAAFS4gIAKvnyA Date: Mon, 25 Jul 2022 10:03:39 +0000 Message-ID: References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> In-Reply-To: <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 03871609-416f-4617-7d4c-08da6e24f283 x-ms-traffictypediagnostic: CH2PR03MB5287:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I6+usgarUexbQ7EZmVmMgMSPmHpT9x81vTXhxhgooYKNy/L/Nb0rehqHGuFNYAYTl76Z0Vog7H7S0T4i1Hf88boaigGa2smbXY0giy4YaDGNhejXxuEUtrqmWcHRnAj92+9IoH3ODIflS4ZekpQcVIXyb39ZkHO/5NiCvGcNZhgYsYQbgyYmspqpvqN8wTNRwEOmzsRSPiVYoVv4GhNGBpV08W1ADrvqsrmVP1QAz0amWhhUqk10Ooed8dxj9Kug2x82eaH4MSspcDZv5PejC+TBbAXcQGZPDwxwDPj7XC2pmODYqeIxJeUH2Yqum91z/0wtrmGrN/nLonzFXYQL5M7uwnoTuIAMfCohwGRxkljHycN75Viz77teS3yIGmHoyltStg1n0G+v6RU6zjp3yzSIsbQqcobIUixfEyfKBhJLcd3qdsgJHjlf7AS7PD48ixuNXnAp6Th5yohtv/Jdh0WjtyPQn5+LQJlgEhk2R3bAv+oq4DfaOf1DEkCePdng2SmO1WV0ff9X74lDPFuIDfoLj3qwHSdayp91LRgGjrwEVdFJWuoWZtvN7L5j5pr7NaqU+CxkrLnuSal9Ah9kdVTU8mh9+kpOTYpTMqaLLmPzlNZv1osQWULCequ/0Id5Gwk2IgA2okOTdtRgR/LgP8Fsgt1i8k5EdqQIcvSv1QiOBDOCTlNKJ+Nbt595d7bgShj8CkFbQD/8CVGU09hnlHFe+nglwQchvMUtDPduJQHrqwqBwLoB47w708uJGTVas2lCVlIdkZZuVF7dwdJJeNx7A23fpb2BYFPfToSbAjW6yKocEwV4bPRyyZYm0y9yxhWQeb2rxhwYl8RSsfxWAA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(346002)(376002)(39860400002)(136003)(36756003)(53546011)(83380400001)(186003)(66476007)(66556008)(54906003)(66946007)(71200400001)(76116006)(110136005)(91956017)(8676002)(64756008)(4326008)(31686004)(66446008)(2906002)(6512007)(26005)(2616005)(38070700005)(38100700002)(86362001)(6486002)(6506007)(122000001)(5660300002)(7416002)(316002)(41300700001)(478600001)(82960400001)(8936002)(31696002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Z0pwbkViMFB6ZlRYMmNtRFRQYnp4eWQxM3hTa1pSZjFHYXNVWWwxaXJpZDFS?= =?utf-8?B?eDRhdmFMc0pUakFWZmh1bkY0VjhBSjkxSDIxa3V4TkZnc3FJMzhmR2NaeTgw?= =?utf-8?B?OFRvREdVcGUrRnpEZTh2TnNhWXFOOElpZmRDOW9Md2hDS0FSN0dYQm12Qk4x?= =?utf-8?B?YUFwQkFzK2RwcWYxeFZZemt5YjIrRFpWOHZGcHg1cGpackRidUZHeUJJY1JU?= =?utf-8?B?NEgxdjEySjhKdDZlUm5YVDExSEdVU1h0bzhlbndQS2hBZ3QwWHhOTXRxR3FF?= =?utf-8?B?OHY0Ly9FUkppQUdZL0dWbVB1bTZRaVYvK2N1K3YxOE5RWkRVb3d3Z05ZclB4?= =?utf-8?B?cmk0Tlo2aHR4WVEwTDlEdU9odGdxT0dIWklUWEo0U3huYTRvb1JSQnBHUlJP?= =?utf-8?B?cHoxQjVGbmloQk56cWdoOU1oRXZGNkJDZmdIL0MydVNWckpzUU9VaWJ4eWhF?= =?utf-8?B?UUhUVDVkU2NtQ3lKQ05EMDc2SFlFK0ZuSWQ0WkN2ZEZ6eDdvMkhtcnhkQUZG?= =?utf-8?B?cmMxbzFuTmtxeTVYd2w0Q0Jla2pFV3pxdUo1WGFDaFlxMkVGT1hKOVVVQUc3?= =?utf-8?B?WWdHVFZtMXBtTWRGOUtSdDhzLzh1SUFQamgyNjdMdTVvZXZqc0d4MDA2LzJH?= =?utf-8?B?aUJ4aXZSOWJDMmJLek1JbG1iVjVzcHRCc0FQY3ZFRkFYSlRkcjhSSkRENm5Q?= =?utf-8?B?SUhVcXVCSElRUm1yZ04raXVOb3lmOHJGZlJnbTRPemFVR3VNekw2MmtJU0Fw?= =?utf-8?B?VWcrbDBTY053QnZHMnF2dll5dHVoV1lCUmFWSmxrN0JuRk14WE5ITkxkSHNm?= =?utf-8?B?em5PaW1zOTlBUUF3ZS8zNkhrbXpoSmZGMXYrT21kSUptcmo2aTdWWkN5UW11?= =?utf-8?B?VWRJY2RJUUkzK05jQUczNmFWcmtNNk96MFExb2o2bnRwNVRubjdrYnBvSk4x?= =?utf-8?B?UWpLemRjbEp1a2RYd015UE1NTUVQQjgzQzJVVmo3MmYySTJ3K1A3L3VuYW8v?= =?utf-8?B?b1c1NDlYWW1lMGVtS0pZZVFSZjlHMjIwRUYrRDdGOFRrUVplWkp6QzFoczZG?= =?utf-8?B?YzBJUUJFcnh1RlZ1UHVrT2FHQlhmdkhxVnhJZlp0TGxrUU5KZWdISVpwN3pu?= =?utf-8?B?NFpMNUZkQ1ppYXU5eWc5YlZZL21VUHlncEtKUThFejhSNVJkWC9yaGpMK21l?= =?utf-8?B?T1JIbFdldHFGYTZwSFRaZ1B5azlacTFYcm1KRFcvdHJONWhRczdzZkJSTFB3?= =?utf-8?B?WUxpNUlDNTZiMzc4MjF3ZmNnYzJzNXNXNTVicUJST0N5K2cvRkUwVjlyN0tW?= =?utf-8?B?REhvRmFBYkRsTW1kR0FVcE1MaGNqZUVlTU1oQlJpblcxemlUR2MxMzhmMlFw?= =?utf-8?B?MzlRSXBMZ09wanRKTmcvR2VKWjI2a25CN1BvVU1qR0UwWnVrNFlJUlBWbis1?= =?utf-8?B?bDJKVmk5bHkrcG5GMEg4UTlUWGd3Q0wyVUhZeGxYcm1MbEs4a2t3d1NQM3px?= =?utf-8?B?b1pCUU1Ea1d1S0NRQUtzWHBycG1PS0hYSXhqUW50dXpaelhWdFNJZCtHQVZS?= =?utf-8?B?T0c0bEtKR2c3QVFiNU02QktaNm54YWtVU05Md0g4MVhtNHZOWXpLaFAwb0VY?= =?utf-8?B?QktuOWVEcUI5SktxMi9vVk1RZXY2RU1HV3IwWXI4MHJaVFRJdVM2UWRESktW?= =?utf-8?B?NkxMVFVpdnJMWi9CamhENEI3WDV4OEhsMVl0L3cyYXFuOXJQQ000aW5qNEdp?= =?utf-8?B?UCtHb3dvYm05Z043Q2RxVlpwT0VlU0FlMEZWeGJ1dlIwWG1TWVlhcHpqV3hx?= =?utf-8?B?d1Vrb3lpTlRYclh2VlVnbStmV21obHZEYUZTKzNIWFZGbmpma3RoWnZ3UmZV?= =?utf-8?B?TXROUDV3alpTUzNaanhBUFRIRHBnZVBYMFN4RFN5cGxSV3R2VTJwTTJ3S2Vi?= =?utf-8?B?dEdwS1IrUzUzWTR3czJiMDdGamo2elVzQmttVFMyVWJ3T0ZneVRHM1ZKK1Bs?= =?utf-8?B?TlRFZjRQb2pVdk9JcDkzeHNHL3N3NGVkK3lUVEVzN3ZsT1RhSER1cFJvUkxH?= =?utf-8?B?Zm5QOVFwWDdHNmVPK3hNSU5GRWJXaHhQSGZxeGI2blNaVS80N3hwbCtIMW5a?= =?utf-8?B?cnRId3dUUnZsZTFlRFRlTEdyNnVJYUtRWU1tVksvWENRSGhHV0w1TVVLRmI4?= =?utf-8?B?bmc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <9A1A336A688148479378394BF185E815@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03871609-416f-4617-7d4c-08da6e24f283 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 10:03:39.2459 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 14RqiQ7b9zvbeGRoR6HSe0tptABx8THT0B62uNFKb/FRHI7fN6DmdxgV7J/QspSe2Zd6cDTr2UiTvDQGR+AOswlAUblBOaVMuFg6YS7jW7k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5287 T24gMTgvMDcvMjAyMiAxNDo1OSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPiANCj4gT24gNy8x OC8yMiA0OjU2IEFNLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0KPj4gT24gMTUvMDcvMjAyMiAxNDox MCwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPj4+IE9uIDcvMTUvMjIgNTo1MCBBTSwgQW5kcmV3 IENvb3BlciB3cm90ZToNCj4+Pj4gT24gMTUvMDcvMjAyMiAwOToxOCwgSmFuZSBNYWxhbGFuZSB3 cm90ZToNCj4+Pj4+IE9uIDE0LzA3LzIwMjIgMDA6MjcsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToN Cj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqAgeGVuX2h2bV9zbXBfaW5pdCgpOw0KPj4+Pj4+PiDCoMKg wqDCoMKgwqDCoCBXQVJOX09OKHhlbl9jcHVocF9zZXR1cCh4ZW5fY3B1X3VwX3ByZXBhcmVfaHZt LA0KPj4+Pj4+PiB4ZW5fY3B1X2RlYWRfaHZtKSk7DQo+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNo L3g4Ni94ZW4vc3VzcGVuZF9odm0uYyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+Pj4+ Pj4+IGluZGV4IDlkNTQ4YjBjNzcyZi4uYmU2NmUwMjdlZjI4IDEwMDY0NA0KPj4+Pj4+PiAtLS0g YS9hcmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYw0KPj4+Pj4+PiArKysgYi9hcmNoL3g4Ni94ZW4v c3VzcGVuZF9odm0uYw0KPj4+Pj4+PiBAQCAtNSw2ICs1LDcgQEANCj4+Pj4+Pj4gwqDCoMKgICNp bmNsdWRlIDx4ZW4vaHZtLmg+DQo+Pj4+Pj4+IMKgwqDCoCAjaW5jbHVkZSA8eGVuL2ZlYXR1cmVz Lmg+DQo+Pj4+Pj4+IMKgwqDCoCAjaW5jbHVkZSA8eGVuL2ludGVyZmFjZS9mZWF0dXJlcy5oPg0K Pj4+Pj4+PiArI2luY2x1ZGUgPHhlbi9ldmVudHMuaD4NCj4+Pj4+Pj4gwqDCoMKgICNpbmNsdWRl ICJ4ZW4tb3BzLmgiDQo+Pj4+Pj4+IEBAIC0xNCw2ICsxNSwyMyBAQCB2b2lkIHhlbl9odm1fcG9z dF9zdXNwZW5kKGludCBzdXNwZW5kX2NhbmNlbGxlZCkNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCB4ZW5faHZtX2luaXRfc2hhcmVkX2luZm8oKTsNCj4+Pj4+Pj4gwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCB4ZW5fdmNwdV9yZXN0b3JlKCk7DQo+Pj4+Pj4+IMKgwqDCoMKgwqDCoMKgIH0N Cj4+Pj4+Pj4gLcKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+Pj4+Pj4+ICvC oMKgwqAgaWYgKHhlbl9hY2tfdXBjYWxsKSB7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCB1bnNp Z25lZCBpbnQgY3B1Ow0KPj4+Pj4+PiArDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoCBmb3JfZWFj aF9vbmxpbmVfY3B1KGNwdSkgew0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5f aHZtX2V2dGNobl91cGNhbGxfdmVjdG9yX3Qgb3AgPSB7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudmVjdG9yID0gSFlQRVJWSVNPUl9DQUxMQkFDS19W RUNUT1IsDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAu dmNwdSA9IHBlcl9jcHUoeGVuX3ZjcHVfaWQsIGNwdSksDQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIH07DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gKyAgICAgICAgICAgIA0KPj4+Pj4+PiBC VUdfT04oSFlQRVJWSVNPUl9odm1fb3AoSFZNT1Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yLA0K Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICZvcCkpOw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAvKiBUcmljayB0b29sc3Rh Y2sgdG8gdGhpbmsgd2UgYXJlIGVubGlnaHRlbmVkLiAqLw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBpZiAoIWNwdSkNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBCVUdfT04oeGVuX3NldF9jYWxsYmFja192aWEoMSkpOw0KPj4+Pj4+IFdoYXQgYXJlIHlv dSB0cnlpbmcgdG8gbWFrZSB0aGUgdG9vbHN0YWNrIGF3YXJlIG9mPyBUaGF0IHdlIGhhdmUgKmEq DQo+Pj4+Pj4gY2FsbGJhY2sgKGVpdGhlciBnbG9iYWwgb3IgcGVyY3B1KT8NCj4+Pj4+IFllcywg c3BlY2lmaWNhbGx5IGZvciB0aGUgY2hlY2sgaW4gbGlieGxfX2RvbWFpbl9wdmNvbnRyb2xfYXZh aWxhYmxlLg0KPj4+PiBBbmQgb3RoZXJzLg0KPj4+Pg0KPj4+PiBUaGlzIGlzIGFsbCBhIGdpYW50 IGJvZGdlLCBidXQgYmFzaWNhbGx5IGEgbG90IG9mIHRvb2xpbmcgdXNlcyB0aGUNCj4+Pj4gbm9u LXplcm8tbmVzcyBvZiB0aGUgQ0FMTEJBQ0tfVklBIHBhcmFtIHRvIGRldGVybWluZSB3aGV0aGVy IHRoZSBWTSBoYXMNCj4+Pj4gWGVuLWF3YXJlIGRyaXZlcnMgbG9hZGVkIG9yIG5vdC4NCj4+Pj4N Cj4+Pj4gVGhlIHZhbHVlIDEgaXMgYSBDQUxMQkFDS19WSUEgdmFsdWUgd2hpY2ggZW5jb2RlcyBH U0kgMSwgYW5kIHRoZSBvbmx5DQo+Pj4+IHJlYXNvbiB0aGlzIGRvZXNuJ3QgZXhwbG9kZSBldmVy eXdoZXJlIGlzIGJlY2F1c2UgdGhlDQo+Pj4+IGV2dGNobl91cGNhbGxfdmVjdG9yIHJlZ2lzdHJh dGlvbiB0YWtlcyBwcmlvcml0eSBvdmVyIEdTSSBkZWxpdmVyeS4NCj4+Pj4NCj4+Pj4gVGhpcyBp cyBkZWNhZGVzIG9mIHRlY2ggZGVidCBwaWxlZCBvbiB0b3Agb2YgdGVjaCBkZWJ0Lg0KPj4+DQo+ Pj4gRmVlbHMgbGlrZSBpdCAoc2V0dGluZyB0aGUgY2FsbGJhY2sgcGFyYW1ldGVyKSBpcyBzb21l dGhpbmcgdGhhdCB0aGUNCj4+PiBoeXBlcnZpc29yIHNob3VsZCBkbyAtLS0gbm8gbmVlZCB0byBl eHBvc2UgZ3Vlc3RzIHRvIHRoaXMuDQo+PiBTZW5zaWJsZSBvciBub3QsIGl0IGlzIHRoZSBBQkku DQo+Pg0KPj4gTGludXggc3RpbGwgbmVlZHMgdG8gd29yayAobmljZWx5KSB3aXRoIG9sZGVyIFhl bidzIGluIHRoZSB3b3JsZCwgYW5kIHdlDQo+PiBjYW4ndCBqdXN0IHJldHJvZml0IGEgY2hhbmdl IGluIHRoZSBoeXBlcnZpc29yIHdoaWNoIHNheXMgImJ0dywgdGhpcyBBQkkNCj4+IHdlJ3ZlIGp1 c3QgY2hhbmdlZCBub3cgaGFzIGEgc2lkZSBlZmZlY3Qgb2YgbW9kaWZ5aW5nIGEgZmllbGQgdGhh dCB5b3UNCj4+IGFsc28gbG9naWNhbGx5IG93biIuDQo+IA0KPiANCj4gVGhlIGh5cGVyY2FsbCBo YXMgYmVlbiBhcm91bmQgZm9yIGEgd2hpbGUgc28gSSB1bmRlcnN0YW5kIEFCSSBjb25jZXJucyAN Cj4gdGhlcmUgYnV0IFhFTl9IVk1fQ1BVSURfVVBDQUxMX1ZFQ1RPUiB3YXMgaW50cm9kdWNlZCBv bmx5IGEgbW9udGggYWdvLiANCj4gV2h5IG5vdCB0aWUgcHJlc2VuY2Ugb2YgdGhpcyBiaXQgdG8g bm8gbG9uZ2VyIGhhdmluZyB0byBleHBsaWNpdGx5IHNldCANCj4gdGhlIGNhbGxiYWNrIGZpZWxk Pw0KPiANCkFueSBvdGhlciBvcGluaW9ucyBvbiB0aGlzPw0KDQooaS5lLiwgY2FsbGluZyB4ZW5f c2V0X2NhbGxiYWNrX3ZpYSgxKSBhZnRlciANCkhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3Rv ciBPUiBub3QgZXhwb3NpbmcgdGhpcyB0byBndWVzdHMgYW5kIA0KaW5zdGVhZCBoYXZpbmcgWGVu IGNhbGwgdGhpcyBmdW5jdGlvbiAoaW4gaHZtb3Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yIA0K bWF5YmUpIGFuZCB0aWVpbmcgaXRzIHByZXNlbnNlIHRvIFhFTl9IVk1fQ1BVSURfVVBDQUxMX1ZF Q1RPUiB3aGljaCB3YXMgDQpyZWNlbnRseSBhZGRlZCkNCg0KVGhhbmsgeW91LA0KDQpKYW5lLg== From xen-devel-bounces@lists.xenproject.org Mon Jul 25 10:08:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 10:08:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374486.606550 (Exim 4.92) (envelope-from ) id 1oFv1C-000839-Jl; Mon, 25 Jul 2022 10:08:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374486.606550; Mon, 25 Jul 2022 10:08:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv1C-000832-Gn; Mon, 25 Jul 2022 10:08:54 +0000 Received: by outflank-mailman (input) for mailman id 374486; Mon, 25 Jul 2022 10:08:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv1B-00082v-Eb for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 10:08:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c789b41e-0c01-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 12:08:51 +0200 (CEST) Received: from mail-co1nam11lp2172.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.172]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2022 06:08:48 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by PH0PR03MB7017.namprd03.prod.outlook.com (2603:10b6:510:170::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Mon, 25 Jul 2022 10:08:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 10:08:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c789b41e-0c01-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658743731; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=kqItF+M2OU5sj85TVLt33ajlOHQoYByO3WX7XoCmzRM=; b=PFLFsUJRruR+izM+vuD2WAR9go5qfiKZWJ56TeFnQqC620b4vG00zfLY 6VsyYu54KxPGC+qtnzzzQAz+Ae6CL14GfjGxybb9C4QoB3oXrKON7U5Bd /nIrFHJg65KSIJk+UJ5hMefgos3qS5/+B3ahK5rDtpFbdJZ95jhzMN+qL 4=; X-IronPort-RemoteIP: 104.47.56.172 X-IronPort-MID: 76538133 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A/8UdA623NOLNzwVcK/bDix16xcyv+3FdZeh4A?= =?us-ascii?q?8V8DSJ0REvO9WDO3PKurZDyZGxZPOn4GStR26+fTktD0PdbNrls31Zn9NXzy?= =?us-ascii?q?/QiOsJtSRd74WGFBWcTQ9A+bv0Cw37+Nnr9lfD/IFbu2NC/edcIEQpxJrffT?= =?us-ascii?q?oxuii9dqj0tfQ3QX1JvQptL27O95WOUI6kmzki68iPiwla1DT52pSSzN1PL6?= =?us-ascii?q?FFhohbynfVNOdSMN3Rn+vSxX9SMqMf36cBsfa7lM242Ftacw4mOxNPGSGODY?= =?us-ascii?q?97vpCB03QiHsAdt4Z+JEtwTsHtXPLnk2XLS7h6VCT6UggYk+kNwSuyZ/AmU3?= =?us-ascii?q?s9wE8MwZMI1ET8XimFuMle/Qdw66lEz4I6e/Y7K7NULn7MRvZ2x4641TGfRM?= =?us-ascii?q?Qoy5jPiQO/TcDv57AGbRO53/0ImuzALNqhu0TkuQ8K/Gkiy9FuETsTR7/y85?= =?us-ascii?q?IVJn9F4J8zXNwESG9OeOCY8cpPGGhb8EuqkBJUHRixJJerFsUN8gwK2k9sID?= =?us-ascii?q?T9lbT/Py0gOOy/k9X6gLvBFUGprGsN785gYeugtLgZ6snL5wvfbheVFdyos0?= =?us-ascii?q?02uNsrI78j3qDl3gmNMCY57wcCQ1fUKr0vLh+USch1AuqWrx9Ln5DZyvJHBn?= =?us-ascii?q?/fwt5e9udwnbfw2ysNVFM64TfZKgJE7lHV3uHAQP+mr5iqU0r96k+PRcqv7a?= =?us-ascii?q?5f82fyVfOmfOYbKpoFiMfmRiotld8tqqFjQcjxHVHj0CsXq78NUNPmEfPeL0?= =?us-ascii?q?XsQowjTeYoeBvB98U+LXePWZ7E/7mKen551ecNuF7QNu59Pmd9q68/FHlWfa?= =?us-ascii?q?GHIj9RW/Or0xjVdpJzrre+sHnxUKqCL/NoYFCmyv1dKchnwWyyojmxHMoExT?= =?us-ascii?q?UegH9jMZZaNJBGwwP3o0Bq61BIrUNffkltQgcNaxRIgFqbSX0C+q8gg7Bz8n?= =?us-ascii?q?DX/cDmqoq95hE+tFnOxkhVJsCJPSoqL7dovLFfmu5i4J9zEd6bBjhCcu4s3I?= =?us-ascii?q?1BihENUWjEsrLBaYnP+lXSrRTD0IiNOdL8S38PL2Z0VJGDWlSw13xa2Qjm5c?= =?us-ascii?q?TSF/QtHGZXQEFUe3mvdOz706kWCj1Z0vHPG6ZvJ/TCkuVU2qzk1WTHazhvci?= =?us-ascii?q?FChnvNGMZXbWvb2sAcT4YL7Y1dctKE6oLwS69TK2Ep26TZ+UekjuTS8c1JJQ?= =?us-ascii?q?jw0+ExRY5bsr19bi4PL20CAP1giSOMzVyEvlgSh6d7UWMBGu+L0snZ7StgdU?= =?us-ascii?q?a663DNYOrCeanVwAYYWsLESZj8N9aXull7QhRSWfDY5Yibq3dRg65+yZ1LrG?= =?us-ascii?q?vxi391c3W2S7PWkeoVAWE+/L6QTvkF+sI4cmwzZGofC3Y1qMLRwzo5RqXK1L?= =?us-ascii?q?kU0glp4aHz68+sTt4ZxFfv6zQ2CmvnR6xdBeqGRTYMEm8qYR0JRC2lXH/q6Y?= =?us-ascii?q?CoCYmMbi6umrKThxKguh491FJo7e8m5zlV3AG7TaZ8ia5TfVd7QPitYcExSU?= =?us-ascii?q?mbMIPDXmz4F813U0omdi+D+5x2zgfOvJ2cJ4C0/3MOfSO2dHc8qHkeEjwNky?= =?us-ascii?q?/HPlyrY8N4m5gknA+x9N7pZT1CWBsJAj5d9PIrWmUaCCfYea7RzX9OQPsuDj?= =?us-ascii?q?vEv0AxOKujgOpHApub6HiFXqoQWLcg4yVrjd/dLRRwPySulEZe4HZ8O4QUKf?= =?us-ascii?q?O30GcxqnzYvkyz9DtRptv4+N2rkrD1YQnqiBqTFRrHRjgLWBHnOkv6hYCshf?= =?us-ascii?q?meplOL880osC3xaa4WYQrTmY2NgMa2lz8tyXp4T55tdoME63LKp3tE8/MoaP?= =?us-ascii?q?w+vyzkHNhnxCorlTSFwcqqiUe4652qi2rjsmLsSSUDeDakzE8sVhLtB+jgfO?= =?us-ascii?q?8+fea1+Iki7O9QEf2IokPD8hjYfJTXPCFqYDobtMx2fzPgUyZhkgSdH89Qnv?= =?us-ascii?q?VZmbdjpos1OPQovPVEcmK9beeiVXzlIKd54r2LKXkkBzaTIeCeBlq6/CfHl6?= =?us-ascii?q?wWpTvfIM+AVRBcu6a9wZss20OR5yDPXFEWMk0bkkRzyLvuQQXBHJfrOUWBMV?= =?us-ascii?q?hzoK0UshzJIq5kvT2/Z1dQQqRVu532ehtzRxqwKVON4RuuAjUUoL/R9DNvwg?= =?us-ascii?q?CDnMmRJ0i38G8JW7AZm7sUGc/qqI5vuGEW81kxn53iF6/8yv+e4vvNl35SBu?= =?us-ascii?q?j+gdGsKLL+i9SRtp2NBqhNok04HAUHuFEJ22nIsJbfhrIjKUrjux2qPNVzvr?= =?us-ascii?q?C0PaB0cwhur6waS895NfroFRA7yjuYQxGrvMJ0pZYHQ3AR2/YxziN07VNJvs?= =?us-ascii?q?Q/RZm8RJxzwJ6iFpuasQdf+nQDJ3JRpTGfxy+/vxjMPQ1WStmL3VzAvlzCV2?= =?us-ascii?q?9wFRWo8CqrRykkvTtwHK21K4I8otgibeD6erFBr4ElfyIgok72LM7bZnFM1x?= =?us-ascii?q?0G3abKIyVMpNa7Gr+kpZXSQBTPsuyHF+3GHImhLm+anr7jy4xvz+6ZefW29U?= =?us-ascii?q?FpIiGyvwdtract3jJUU3n1ojm/usT+dj8M6J/CRhLY4Fh4mfTTkFLihbyCzE?= =?us-ascii?q?G1DVgh5boRvswcda0BN2FOTtGOmkhZ0NWTHETu+ogOMxZ7mjq6tDyigejn3Q?= =?us-ascii?q?y2OhkfMevdP5RDNHkEy7hMQivgCeTH2T7A+RqRPB3CCGcx8C5yFeDVuDUelK?= =?us-ascii?q?ZaKKwpyjGRHC92UMafohsqaJNeaT4d7zB66vtPazHgkn9S+I0sMb6GD3cck7?= =?us-ascii?q?9kTQ+JeU2uYbCYpPs6u/X/XCsQDo2NFetJ1dPKzvwMSUeYct/gInkbia2foC?= =?us-ascii?q?Dy8eI8NmpO9ejYXTkgDdIrBralqWF9QTvm1UbE1b1Qlhttf7s3B9DO29bhF2?= =?us-ascii?q?5s+HwbeyhE5N27FmAb8JM6+/7UWL7zMOToY93zt1q2i9RqjGdpsSc7o+A4eQ?= =?us-ascii?q?Or7zS4PHMDosEEL2+KKfdIPfdm9PPJewUGTVS9d7Z0iIizjNw625nAy5pZnp?= =?us-ascii?q?3MQtdnx5R2HWzcckdfKwf+qAe1/gsNPcPPUqPM1mf2QbLFBeTdrrslxIv3um?= =?us-ascii?q?mLzj7asNQDgz342llK+iyLTdLsLrZAXE0SkwhmhBGM/h2hlPWpcVyzP+qquL?= =?us-ascii?q?QV9VIGSGx2VqyW5dOKzub8fscDsOakPpVDc4fGYxZlL50nxX+LutNdNnVfSF?= =?us-ascii?q?+2JMzLlTEetfnfp3Mv0IwyATg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,192,1654574400"; d="scan'208";a="76538133" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsLLPZJ38NBz+/6y+kU3QOR7VzsLR2172wwiGFGmnFRFcUVBKp/NVto0zH+JwNg8G651VKR/KIuQPVYbHHolTqNWoCbUhEvMfpVTlNUWMU4dbjsZE5gzGQAWgfEh1V6Hix45H5nPjNRDrTDmfNcyy3LHF8LF36EGc7iYTO/l9BVx6HyhTkDD4HqeZdWR5+OOQovFZgSugp2MDiz6QLLt5FBZb+fRd0byRaLhMt3v5dBmwQJnh1RimTYAT7GMcv4wQ2rKUGGaddnPihqroyRowycjSlR5sEP6Mk4YlskcOeehDMNLX8fOmNcp/1A3OefJMgHor7HYBDC6JIENIyyMMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kqItF+M2OU5sj85TVLt33ajlOHQoYByO3WX7XoCmzRM=; b=L3HxC5I4H0XpqXYpt4MfPH5d2TkHDxbwzxWja9B1Kn5TrosGzV2xQHm0qn1vEiLXh6pV65BdoBl9pP9kPpg/N31Wc8ygWiJgsI5Qi2QhRk/5nFBtWDMb8yw2DFJ5WOFtEwYnoAct6p47VQJ5JX8rUK78ZzqhNNslg/2bPlGW6uGnLqHI+/3YGEx2qKGtmO1r0IMQwhaEGq48VspD30qrHdrmCE79wTGmYon8b+LxUzbvFRJI6Plh0N+Zhxem5M1OKDSB2jD8KEHEDoacmRE/jKVFKN+Q5cI3hiOYQWBgJSXpjiHcBIEXXqCAX2uA+9vDyFqOQUQXuz9hxkWMywfjRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kqItF+M2OU5sj85TVLt33ajlOHQoYByO3WX7XoCmzRM=; b=oh5MUoUgPM4tYzwbDJ2s3MkeIyglR3X/r9uW8y8XFKiSo+8YxiZAkfSkj6WNlQaYC0didcOzJMkKXl0rC7kzgLDIkTY6Dac6NLm2/+Y3RfJ5v/jWSo68jX1gfHTFqy+82/AHC7dRT3XTF/O3zGqV1KmG9VweUshNixqeRFzQQ10= From: Andrew Cooper To: Boris Ostrovsky , Jane Malalane , LKML CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlToncjhzapb0rEGq8Bkg0N3t9a189b0AgAImuYCAABmhgIAAOBoAgARvxACAAFS4gIAKv+oA Date: Mon, 25 Jul 2022 10:08:44 +0000 Message-ID: <4cf1f190-60d8-6bfc-f339-334bbefff299@citrix.com> References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> In-Reply-To: <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1d4c301c-b7ee-47f0-bbb2-08da6e25a882 x-ms-traffictypediagnostic: PH0PR03MB7017:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9m9Cne3O3UCjxSqQEURoJ/tiKQ9N+HpGgwzpSTcAlk8E3gydPAZCM8ivT+S/e6KYJnyWi8rxrUOwTa2MkPaHz7ueevaUeq7dMYGjNfKXS9/EDQ/zX7ZI9TPIomZeaECxoLb0ztfdXUPlrDCnHAabYrxvsw6B4Xlke4ZcgnRmkyfan48Laoq3u/rlQf/fDRYoqYkT6gY+MFmCTVWxL3NtdLEulIMwW8ltexufV0/SVxTPZCstLgrcBfnFUrRLCrn8EW/nGo65oyDI7eRh6txrO7OldyPTi/QykQYoBUkRI7iCRO2AG8heyYqYEDJqryPMVrFAjTHrUxrizMZ/xbeOLv1UnGTefwNvHe9N7US5SPb0FPpWNN+B+X2K+SKM3Lrb16S01CAZtozel53fmUzCxSqDLp1FGEXOKInWQbgB+Yv4T5TY2mpCVQ/vZ5WRtdw74kHiDWnb2Sam0tz5kn86Sg34h1qFU1y1aNSvL3PuaQyIeGy0Y4vaGt8ccaX+UmweVSZbNFkF6dyfmp0axFL3uRavWfPBidA3mZpUAxYdN3t325bC6CNYh7cnJFPO+n56uxl4OfmWL5c32SuUxn6frYix7bNvnN+qB1SuRHoY1GK20XdME8tFhpgKA6VLAzsoOoEvzpXu1WpfOeGuyZ+J4J8gyF6lEToSSAR3LfyeyDgAAgEnSSsknHV6PfJC8ZuyHU5wgAkebsTsmPdPSn67wSGFfWzJdbcNfTmYC+IAPjuZ18GFbVooLJ+TfIyJav+w7qw3elsPrl6rsASt3ZtYDVwoHWd8AKZ6S8UGKuuL0eqvNhmoNM/u1EDxPPv5jqZmCh1pR7+v/PAZ3I97MmCiGXYd61VoVuE9r2iUMR8qJ+PGn9T6PiS/LsZRS5jz9+Px x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(366004)(122000001)(6486002)(38070700005)(38100700002)(86362001)(82960400001)(478600001)(31696002)(7416002)(5660300002)(8936002)(316002)(41300700001)(54906003)(66476007)(66556008)(91956017)(66946007)(8676002)(76116006)(71200400001)(110136005)(83380400001)(53546011)(36756003)(186003)(2906002)(2616005)(6512007)(26005)(31686004)(64756008)(66446008)(6506007)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?MFMzUnFERm1qbFJQY0RKMWhIZFVLN0xJZmlDS2F1d0FKMXYwdS9mbjY4ZzZT?= =?utf-8?B?NGNPMjg0SEpVTVVvK1RscEttNW03dVcrZmtqMEt1Z1JQZlZaTGo3RlBRajNS?= =?utf-8?B?T3dCUkZwU1EwelU1dEV6VnVzaURVUHdxRFpXdkpVekcyS1hUUTJLalJRU3pj?= =?utf-8?B?aUpmcURVTUN2STBlNENPQkI2aG5SZzVQZW9BKzN1M3QvVjN2eVNZZlYrSXFE?= =?utf-8?B?aEJjRmhMMjd4NCs1ekhjY3k5YW5JY2M5amsxNytaZ2pNQVNIdjNmT0xwUXh6?= =?utf-8?B?MmxDZ3ptTG1YOVk3V0h2Tk1BQUVkNUtvZTFsd1VWQXFMYmlUL2YyOEZzaFZ1?= =?utf-8?B?TElRckVaTFltaUJLajdBb0dKUEFkWlhnSjZkd0lMS2lzb0RaWVdyYTFpeEdw?= =?utf-8?B?RkVPOUhGZ3M1TXJxSERucW1IVTlzbzdhcUM0eXNpZHB3YjV3aTM2bTFCRytZ?= =?utf-8?B?bk1NRk15NHFpbS9sOEIwQXdUSTQ4SWp3eGlIU2VWSVR6VjdZUHI5MXRLYlhy?= =?utf-8?B?U1VWMlYwbWpYQ2RHelA1UHBVcjV4bDJLdVlPbXpJRkpTMnE0NzIxSnFIOHVG?= =?utf-8?B?UTl0SUE0UVJZRUlCU1VtZTVhR25DVW5sV1JKV0NPRzRUelZFNGJ1cnUxN3VY?= =?utf-8?B?VEdQY3V4R3ZCWmVITkIvTzExTkZyNlRwaWtTc2lQRWVmVnI0MmtTU05DS0ZD?= =?utf-8?B?WjYrenZPamRVeXRJTXBVdGQxL1UxUlBGSmMxd2lCU3hWWURjQUpzcHA2dXph?= =?utf-8?B?bXlLRzZYNFllTVlaSmsrNWtvRitORFA1a2Q1VU40N0NKcVBZNGlLeUVRMEpR?= =?utf-8?B?cERpYkVTOHFmaWRtT3dkU2Vyd203bThtaSt3UnFLMkZLVWRreGYwM1VkZFdE?= =?utf-8?B?NWQ4aTZXTzk1cDRqNnpwaHRwTGhlRkZ5eUJpTWJpVEpTMWI5a3JzOVpsZGJu?= =?utf-8?B?Q1FNOEpYUk1wMkpVZGJHNVhENWF0VzFCRFR5RUY2cWRIK0MvR3M2ZEo1MGEx?= =?utf-8?B?SGc5RWpETisrWC94THkzMFFpUFhuTGc0VUtNVFQ5cHBCUDhGZkN1RmcvVjE4?= =?utf-8?B?TmZ3N1JnZTl2THFWbjBrTE5FRjZBUForZVZxdkZDZDBLM0ExY0V5ZGtQL0JB?= =?utf-8?B?N1pJZEk0ano5Z0tHRnRIa3FuUUJ6WkVWWWdqM1FmNUpXVno0d2JOUC82Q1Y4?= =?utf-8?B?aHovdXhZZm9nd0FMckZhOTAvajE0bktjRG5NcGNqQnU2eG10L2pUcEFMa3Br?= =?utf-8?B?cm9teGNLQ2t3c1U5VDVySjFKNWxXbjFUN28rZE9lZFdKZlpBeDZ4dnpBay85?= =?utf-8?B?ekdHQWxXV0FLY0p5L0dBcEh2VWZEVWFsQVd0KzJWS0MxSGlPRDBrN3dIL2pw?= =?utf-8?B?OTUzSlNnSlBpVXBqeFROZGJaWkVzeDg3d1l4WWhoL0Zycld0eDF6SnJsdzR6?= =?utf-8?B?WFJ0akdPSElDa25ETG50UmZ5VXNGTEM5VFV6b0lmTFB2SjlzMmx4WVUvSWJt?= =?utf-8?B?Tk1qM2c1VmFnOWVjL2xpTUsxblE3WDBKL2VobC9CVEpSMXdiOFAwQ2MxMVE4?= =?utf-8?B?NEZIQ2NsRlFoYVcxQTBsbEJwaWNQY3dOeGJlNmFsL25LamxWVTU5TG16Uzd5?= =?utf-8?B?b1ZLTHhNOVNXaEJ6b0svVFdLRkFPckNBeWV1M05NcTlXL2NwV3pRanBoTkRE?= =?utf-8?B?cU53QlNpTG9KY3d1NEFZZCtiTTJrMHcrSDIxWmpPSW5sc21WbUNOT2hibXhR?= =?utf-8?B?NWZWemd0OU4xTGpxQ1NnZXJKR29QZlRYcjdZQ3Bpd0RQT0JLVzB2R3ZBQjdR?= =?utf-8?B?cUtQK1ZSYW1uQm4wOFhkS05XVnBFd0VZOSszcU85di9QQ0tNSzh4NDVMR1pn?= =?utf-8?B?SW5rc0pZNTcydzlwMDhRSk1pdm43QXRtMEdpeW40WW9YRUNxVVh3S0RZZmg5?= =?utf-8?B?cE5wSTQ2TGNGMzR2cWkrVFltdmQ0WWlZSHVEd1R1VDlGM3VJNDkvWnNJNGNI?= =?utf-8?B?MXdtcjFXNXUvS3FNc29MOGtEVTZEbzZYRzRneDVvMkdscmpLR0VpL21KREpS?= =?utf-8?B?bUZjYWJKZ2FZSkUrWmJ6QlB4L2FtZG9wSU5FandEdk5RbHp3aGo3YklQRVRx?= =?utf-8?Q?cU6AvlovHs2rIirPQQV2UKTjf?= Content-Type: text/plain; charset="utf-8" Content-ID: <32FBC27E3FBA21478D20D2E74D8264FC@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d4c301c-b7ee-47f0-bbb2-08da6e25a882 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 10:08:44.6019 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N3I3RxBGiclKxZqXCZhSV8xfpEqfG2dDybawzBqgus8c+R+P1GmZn5PLa9jY9DrQAa8duRWIRTjbfefm03i4Z5Jz/JZwR78yH8SeeSoe0OE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB7017 T24gMTgvMDcvMjAyMiAxNDo1OSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPg0KPiBPbiA3LzE4 LzIyIDQ6NTYgQU0sIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAxNS8wNy8yMDIyIDE0OjEw LCBCb3JpcyBPc3Ryb3Zza3kgd3JvdGU6DQo+Pj4gT24gNy8xNS8yMiA1OjUwIEFNLCBBbmRyZXcg Q29vcGVyIHdyb3RlOg0KPj4+PiBPbiAxNS8wNy8yMDIyIDA5OjE4LCBKYW5lIE1hbGFsYW5lIHdy b3RlOg0KPj4+Pj4gT24gMTQvMDcvMjAyMiAwMDoyNywgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0K Pj4+Pj4+PiDCoMKgwqDCoMKgwqDCoCB4ZW5faHZtX3NtcF9pbml0KCk7DQo+Pj4+Pj4+IMKgwqDC oMKgwqDCoMKgIFdBUk5fT04oeGVuX2NwdWhwX3NldHVwKHhlbl9jcHVfdXBfcHJlcGFyZV9odm0s DQo+Pj4+Pj4+IHhlbl9jcHVfZGVhZF9odm0pKTsNCj4+Pj4+Pj4gZGlmZiAtLWdpdCBhL2FyY2gv eDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+Pj4+Pj4+IGIvYXJjaC94ODYveGVuL3N1c3BlbmRfaHZt LmMNCj4+Pj4+Pj4gaW5kZXggOWQ1NDhiMGM3NzJmLi5iZTY2ZTAyN2VmMjggMTAwNjQ0DQo+Pj4+ Pj4+IC0tLSBhL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+Pj4+Pj4+ICsrKyBiL2FyY2gv eDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+Pj4+Pj4+IEBAIC01LDYgKzUsNyBAQA0KPj4+Pj4+PiDC oMKgwqAgI2luY2x1ZGUgPHhlbi9odm0uaD4NCj4+Pj4+Pj4gwqDCoMKgICNpbmNsdWRlIDx4ZW4v ZmVhdHVyZXMuaD4NCj4+Pj4+Pj4gwqDCoMKgICNpbmNsdWRlIDx4ZW4vaW50ZXJmYWNlL2ZlYXR1 cmVzLmg+DQo+Pj4+Pj4+ICsjaW5jbHVkZSA8eGVuL2V2ZW50cy5oPg0KPj4+Pj4+PiDCoMKgwqAg I2luY2x1ZGUgInhlbi1vcHMuaCINCj4+Pj4+Pj4gQEAgLTE0LDYgKzE1LDIzIEBAIHZvaWQgeGVu X2h2bV9wb3N0X3N1c3BlbmQoaW50IHN1c3BlbmRfY2FuY2VsbGVkKQ0KPj4+Pj4+PiDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHhlbl9odm1faW5pdF9zaGFyZWRfaW5mbygpOw0KPj4+Pj4+PiDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgIHhlbl92Y3B1X3Jlc3RvcmUoKTsNCj4+Pj4+Pj4gwqDCoMKgwqDC oMKgwqAgfQ0KPj4+Pj4+PiAtwqDCoMKgIHhlbl9zZXR1cF9jYWxsYmFja192ZWN0b3IoKTsNCj4+ Pj4+Pj4gK8KgwqDCoCBpZiAoeGVuX2Fja191cGNhbGwpIHsNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDC oMKgIHVuc2lnbmVkIGludCBjcHU7DQo+Pj4+Pj4+ICsNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKg IGZvcl9lYWNoX29ubGluZV9jcHUoY3B1KSB7DQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgIHhlbl9odm1fZXZ0Y2huX3VwY2FsbF92ZWN0b3JfdCBvcCA9IHsNCj4+Pj4+Pj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIC52ZWN0b3IgPSBIWVBFUlZJU09SX0NB TExCQUNLX1ZFQ1RPUiwNCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIC52Y3B1ID0gcGVyX2NwdSh4ZW5fdmNwdV9pZCwgY3B1KSwNCj4+Pj4+Pj4gK8KgwqDC oMKgwqDCoMKgwqDCoMKgwqAgfTsNCj4+Pj4+Pj4gKw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDC oMKgwqDCoA0KPj4+Pj4+PiBCVUdfT04oSFlQRVJWSVNPUl9odm1fb3AoSFZNT1Bfc2V0X2V2dGNo bl91cGNhbGxfdmVjdG9yLA0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgICZvcCkpOw0KPj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAvKiBUcmljayB0b29sc3RhY2sgdG8gdGhpbmsgd2UgYXJlIGVubGlnaHRlbmVkLiAqLw0KPj4+ Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIWNwdSkNCj4+Pj4+Pj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdfT04oeGVuX3NldF9jYWxsYmFja192aWEoMSkpOw0K Pj4+Pj4+IFdoYXQgYXJlIHlvdSB0cnlpbmcgdG8gbWFrZSB0aGUgdG9vbHN0YWNrIGF3YXJlIG9m PyBUaGF0IHdlIGhhdmUgKmEqDQo+Pj4+Pj4gY2FsbGJhY2sgKGVpdGhlciBnbG9iYWwgb3IgcGVy Y3B1KT8NCj4+Pj4+IFllcywgc3BlY2lmaWNhbGx5IGZvciB0aGUgY2hlY2sgaW4gbGlieGxfX2Rv bWFpbl9wdmNvbnRyb2xfYXZhaWxhYmxlLg0KPj4+PiBBbmQgb3RoZXJzLg0KPj4+Pg0KPj4+PiBU aGlzIGlzIGFsbCBhIGdpYW50IGJvZGdlLCBidXQgYmFzaWNhbGx5IGEgbG90IG9mIHRvb2xpbmcg dXNlcyB0aGUNCj4+Pj4gbm9uLXplcm8tbmVzcyBvZiB0aGUgQ0FMTEJBQ0tfVklBIHBhcmFtIHRv IGRldGVybWluZSB3aGV0aGVyIHRoZSBWTQ0KPj4+PiBoYXMNCj4+Pj4gWGVuLWF3YXJlIGRyaXZl cnMgbG9hZGVkIG9yIG5vdC4NCj4+Pj4NCj4+Pj4gVGhlIHZhbHVlIDEgaXMgYSBDQUxMQkFDS19W SUEgdmFsdWUgd2hpY2ggZW5jb2RlcyBHU0kgMSwgYW5kIHRoZSBvbmx5DQo+Pj4+IHJlYXNvbiB0 aGlzIGRvZXNuJ3QgZXhwbG9kZSBldmVyeXdoZXJlIGlzIGJlY2F1c2UgdGhlDQo+Pj4+IGV2dGNo bl91cGNhbGxfdmVjdG9yIHJlZ2lzdHJhdGlvbiB0YWtlcyBwcmlvcml0eSBvdmVyIEdTSSBkZWxp dmVyeS4NCj4+Pj4NCj4+Pj4gVGhpcyBpcyBkZWNhZGVzIG9mIHRlY2ggZGVidCBwaWxlZCBvbiB0 b3Agb2YgdGVjaCBkZWJ0Lg0KPj4+DQo+Pj4gRmVlbHMgbGlrZSBpdCAoc2V0dGluZyB0aGUgY2Fs bGJhY2sgcGFyYW1ldGVyKSBpcyBzb21ldGhpbmcgdGhhdCB0aGUNCj4+PiBoeXBlcnZpc29yIHNo b3VsZCBkbyAtLS0gbm8gbmVlZCB0byBleHBvc2UgZ3Vlc3RzIHRvIHRoaXMuDQo+PiBTZW5zaWJs ZSBvciBub3QsIGl0IGlzIHRoZSBBQkkuDQo+Pg0KPj4gTGludXggc3RpbGwgbmVlZHMgdG8gd29y ayAobmljZWx5KSB3aXRoIG9sZGVyIFhlbidzIGluIHRoZSB3b3JsZCwgYW5kIHdlDQo+PiBjYW4n dCBqdXN0IHJldHJvZml0IGEgY2hhbmdlIGluIHRoZSBoeXBlcnZpc29yIHdoaWNoIHNheXMgImJ0 dywgdGhpcyBBQkkNCj4+IHdlJ3ZlIGp1c3QgY2hhbmdlZCBub3cgaGFzIGEgc2lkZSBlZmZlY3Qg b2YgbW9kaWZ5aW5nIGEgZmllbGQgdGhhdCB5b3UNCj4+IGFsc28gbG9naWNhbGx5IG93biIuDQo+ DQo+DQo+IFRoZSBoeXBlcmNhbGwgaGFzIGJlZW4gYXJvdW5kIGZvciBhIHdoaWxlIHNvIEkgdW5k ZXJzdGFuZCBBQkkgY29uY2VybnMNCj4gdGhlcmUgYnV0IFhFTl9IVk1fQ1BVSURfVVBDQUxMX1ZF Q1RPUiB3YXMgaW50cm9kdWNlZCBvbmx5IGEgbW9udGggYWdvLg0KPiBXaHkgbm90IHRpZSBwcmVz ZW5jZSBvZiB0aGlzIGJpdCB0byBubyBsb25nZXIgaGF2aW5nIHRvIGV4cGxpY2l0bHkgc2V0DQo+ IHRoZSBjYWxsYmFjayBmaWVsZD8NCg0KQmVjYXVzZSB0aGF0J3MgYSBicmVha2luZyBjaGFuZ2Ug Zm9yIH41IHllYXJzIG9mIHdpbmRvd3MgZHJpdmVycy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Mon Jul 25 10:12:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 10:12:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374492.606560 (Exim 4.92) (envelope-from ) id 1oFv4j-00010q-2t; Mon, 25 Jul 2022 10:12:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374492.606560; Mon, 25 Jul 2022 10:12:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv4j-00010j-05; Mon, 25 Jul 2022 10:12:33 +0000 Received: by outflank-mailman (input) for mailman id 374492; Mon, 25 Jul 2022 10:12:31 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv4g-00010c-Vi for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 10:12:31 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2043.outbound.protection.outlook.com [40.107.20.43]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4a58d402-0c02-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 12:12:30 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2931.eurprd04.prod.outlook.com (2603:10a6:203:95::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 10:12:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 10:12:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a58d402-0c02-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPqlv+TxzD4emqQUgJGFjAvVv9MNVU0T7ovGYNNMRo0v7qsS3+zFB7SDxtKD+zJO9lRIMs8L8lhke5LJ8mdqLnQ7JTjlh4JcOJ0m5ik/LRfQulyXsaOzx7QwFirmdqU20aUmkshkYHL2vlpVQM1MQeh90nXnYFRqXGyy1bpiRzOjcu2DFURXiQ0nbA+BIIRr/820If5wVio51XveRaBwXIpE2sk/M15c37BMO3XQee9AvOoXSgijf26RaRWhLrt3xdJPeMKCeeXKaBy8hMHRRltk4/86GRAsJvx0nnPa2mOn+yo6fXJfeYIRMFlvAeWSuQcpS6vnfPjq/1YRcAeJiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3KdE9xaqCyFWvZiVbiYAF/eDuRclX4SXpIVmBkhtA4M=; b=IGfGs7+F29ViYlezeco/3ZgSm8Dm7LrqA+L9AeAfcoEgDKxBckMthZ438RHmo/13MdU76WB0MpMpexCl9m3xdiRcAlTIuxx9rRL/QajJ2SRSZhczPihLmxo4iT7IsQ1Xb0/jvcqrEtF3bNgE0127nPV9m4/E2AaqEwP9TWIbk3mgAdZDJtopmRWnChGI/MEhU5jMTGJsPxIWfSlXznd3WszfWwlt817O2Gt/rUN06XXO5pz7EmbdJTTXdnUoAmj2cOjGEZNWrxWzK00D/MlX3xhJyvylEqXRyt8fgon0+oJsYFuxeLYZwaDRw0pOJ6cnLWrwEw+5JoLvV+v1QiSaSg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3KdE9xaqCyFWvZiVbiYAF/eDuRclX4SXpIVmBkhtA4M=; b=FKbA7bSeaqOkWjDIUEYygtgr7SmrVsmrHV4Ad11rp3bnmQnRUMaWnp9M1t/vg8yUk8NkUJqjscvTWTLABDNg6WnQaKbV6q0x6mxBmEt3+JrhCLHadzkrjObpyxAEkQ/kYZdsx1wWYH+vD+rgvlfEKMJtHRjluKnd9ZXRJpiXYtCSg7ZU92t/RTAJhYjCuNZQWp1pv/OB4Yrcv/k/8VlQ4vqRqf1qAdOXd6cGde4DiBifW+AseiNHI0NTFaONlMEQPMLJr7x5eTpTR/35Wrku8IqpbTlhErMVO8Z+13YDMIXfBkI1TRu/B1uV1XOlDJDVcg5CtLGnWuCkCHKrqspJYg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f1949e5-665b-a153-342e-8b3482c8b9c8@suse.com> Date: Mon, 25 Jul 2022 12:12:24 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis From: Jan Beulich Subject: [PATCH] Arm32: restore proper name of .dtb section start symbol Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR10CA0068.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:80::45) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 401d43e5-debf-4037-bf52-08da6e262c6c X-MS-TrafficTypeDiagnostic: AM5PR0402MB2931:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Cn7tH9pOPJ110qRK5xva5lWcZjVwHLwzhotBoZENOTOR//mAntGSHdAFMKL/WY6OzAlUd5RJ6PZ8dhW8JA1a4LQ7FJ+izEzX1AjyWCCCWvX6KtngG/TsSBhF09ceZTQXnFOIBCTV9iA5X6Eandw4sX4xz6pGKuJNknqRXnJnQcIl3tqabATCjkmWtKI/HHldoqJtiTeHCS8sAwa7HuDHbmV4f2k66i7wjzPOuUUKvI6Voj5ycRYwWBdmbbwGeE8f6SdAUUAdV9Oc0WK7/9qoivFyldVJa2JK1GskSff14/nwEQxYwcnLTzNxYVJjnrgJmUigUnJ0JdKbWbqTnJiYJuo4INoKeCBflXlVShjas2ssviI+cEPKExqIvu9VsdG7bU3NRZyz7CtpRjTOhluHEoIMjfBgA6/UrijRXI0X+32BhGLaKXYxLkTQbHoN5+gBTyX/nXuSxmvOsuuJfGdOm51kUYkr0VqDAb54N5QJZYpYZRoqoSZ5sqf33vWQBobOzxoBvyJJhw93BTysN8XLXI5a+SmWcHiL7RooCXbCmVqG2PWKW6snaXXIwxuwwfxg106wfP4rrtezcgbG2KPYo6UBqjAbm+6CJRaC2Z9SKCvZvZJUzsaxecoocnc4S6i4WNFPF7E3XsqyoQj6/kmYshhTNJGXWy9YfID+YYRU5c0hogSWjCD752eLYZ+JrsCfvvntqSE/nymbVZxsqMtjgpuPNDXr6ekohH5DmiOFsg0FWI7Zg3v/y4fPpzcc4gohiKmaCi/53XhHFnoZMEKa9ROSsVsHIfOJQ3l+x6eo5vXc2piJehAAsonF9weNQtf5bqV1h9bLyxOseNebXrEpC+nOuRGkoMkE9jcY2JeGyK8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(346002)(396003)(39860400002)(136003)(41300700001)(26005)(6512007)(186003)(6506007)(2616005)(83380400001)(8936002)(2906002)(4744005)(31686004)(5660300002)(38100700002)(4326008)(54906003)(6486002)(66476007)(6916009)(66556008)(8676002)(316002)(66946007)(478600001)(86362001)(36756003)(31696002)(142923001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MTRmZklsbVcrQ3ZjblJCeFBsSG5ISENyY2h6cDR5TVpabkJhNzdsdmV5QzRz?= =?utf-8?B?dFE3VWlOM1pFQ2VyVkZmek5ySEJGSGxBTUJ0WmpMOW42L2VHbFBYRE9RSUhU?= =?utf-8?B?cWRScm5VcGkwZW9YaXBkUDFoRWMxTUN4eldrbEt0b1lVYlBWSUFjUnRtTWIz?= =?utf-8?B?NXNodllVa09VcURRSHVVR2t5T0E2YzRWaEtNbzNoNTRwSDlhQjdvZmExUWhE?= =?utf-8?B?UExYcFBBanJTZENYWWtvYVFjcWpQUFhaM2RaZEE2UDlCVDh3WTB0dW9aVnpH?= =?utf-8?B?WER6RE14UGtGUXJFMFpvYlN3Y0JYWDJoNThFZEFwcjVlb0tZV0ZKaDVuRlBE?= =?utf-8?B?cWhzN2hMUHNOWUZRc0tFVGRGT1FrZy8wdzc2SUw5cHZ4cml3OG1oK21RMDZF?= =?utf-8?B?cDI3U2ZxSVlxdFRVWVFaWkZ3SFArNzA1OW1lS3dzSHUvT3FFKzg1WVMrVXla?= =?utf-8?B?SlFiNGdRdmxuR3EzQ2pNbkh5V3RvdVhCdXJna1ZlenRZcFhXd05yZ1p1M2pN?= =?utf-8?B?SFZRMUt6RFZ3RHVsNGFmZ1V5MnpQa2VKcjVxb3lYUjN0d3pSWmJvemRWWXJQ?= =?utf-8?B?cFpKMVlZekJBaXg2bTVlUnBCVEZGWUlQUjZoSXZ4N2E4WDlUUGk1akI2WnFi?= =?utf-8?B?TVM4U1RnL3VnYXNMU3ZmTWQ3UWVHdGRna3pNR3pRTUxIYnF2YXN6Y2dNQmMz?= =?utf-8?B?bHpmcE1MSUFpNHpSTCsxeDlQcWZmd2hnT091YzI2eWF1bkY5TWVyYkVrQzRj?= =?utf-8?B?WXo5eDRlOFN4TGRjUmRob0l2NUVKN1JEOTYyM2JoZWMzUjRyTi8xRC92TmxC?= =?utf-8?B?ekdtZ1M4a21IYnhES0h3UzlkdVNwV29wb2pvcVhFa2ZLYnNXcUpIM090THBm?= =?utf-8?B?OFRlR1pobzJVdjJWc01QcVdjemltN3lrbWYydERURFZ0UkxaY0E2eVMwM3hW?= =?utf-8?B?ZWt2eFBJNm9ZWDdlWnh1UmRYZFY1K1NkaGpQZVpsZ29HckRtdXBpTVN0T1J1?= =?utf-8?B?RGQrdngrNmx4WENFQzNYR29pWE93TEVwL3dHckVuRUtXNjVUejVEZFBqVlVt?= =?utf-8?B?MXd0bVd4RWhyRWdwOVVCZDg5aC9FR1FVYm01S005bDFwdW16a1JTK2l1djl0?= =?utf-8?B?UExJOHJVSkwwOGhCLy92ZGNjOGgrU25aVkJ1VUZjYWZoL0lxYUFxblFSMm9J?= =?utf-8?B?RUdJYkhONlM5eERnbUlqcDVGRTNtSitjU0UwTWwxR0ZYR0ltWlFKMHdRNHpN?= =?utf-8?B?OUVNbTE2ZThwYmZVaWsvblVkaDlucDdtQ2l2Ly9ZSkVOTHVGQlJsc0lSOUdD?= =?utf-8?B?NkhuZmNxY2Q5OS9nZlhNNmZaeFNBWUVPckJKdTFqbUpnUjZ5TkkxS2gzQXcx?= =?utf-8?B?SXA3cTJhRXZFbEE5RkZHUkh2WnJFalN3S0pmT3Y5bUVHb2ZBSUZmTW01amV6?= =?utf-8?B?SGRRdzY1SXNnY3VwdkhtMGxHcUM3OXhwd1duY3VSYlFsUUF2OEpWZGpmQTFH?= =?utf-8?B?U3I3RjQxYnlQbm1ERXlzWGRzMUpvS0lwS0lTb0dzZ0cvL2k0WmpvYVZDOVBX?= =?utf-8?B?bitRb0lOaVBucEVMZzNkaWx1SFloWXVkVDZtK3ByQnIyUnFIeFRtc01hTWwr?= =?utf-8?B?eFp3S2pHUXd6dVVCazZYdTlGL2d6SHpEdGRwaWFKd3p3dlV4WjN2UER1a2kv?= =?utf-8?B?dmpQY2lrZGIxWVFMa0d0S0Y0VDErQ1hQdWlsc0liRHg5VWxBQUdrZXJRbkNK?= =?utf-8?B?a2dmdHR1dW5Ld3RYMU5uQVRwVlpaSEwwUzVCd0ZCNmZEOFlSSWFnUHB2cU9p?= =?utf-8?B?c0RWUGhKNHZaZVNDa010VWpkVTgvaEVDUERWeXpzWlRlWU5jaC9tTVNMUmQ4?= =?utf-8?B?ckRJSlpCb2N6bkRMclJ6QnIwZjM5aW11M0N3aXA2RElvTjdJbnVwbE5BS2pn?= =?utf-8?B?RUpBOS9XN0pSTG52STZrQ0ExbGlXZEQ3T0ZZdUlYVlIzNTZWOFNCc0VFSXR2?= =?utf-8?B?akUwOHo0T1c4Z0F1SnZyZXBLcmJNQ3RlUis5ZFloeXl6UE5yVzlVOVNmOEIv?= =?utf-8?B?a0p3VnZwYzUzaU1qQ1h5dU5BWUhGMy9hTmg0Q2xUVkdyaFFwRUhwZWI5QVF0?= =?utf-8?Q?gCMqne9XwW8eWwpN0y85C9hIQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 401d43e5-debf-4037-bf52-08da6e262c6c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 10:12:26.1983 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9jS2nCm4GDN1Pt0nVpaEpGm23oOylISl9EPmhJJZlbgh9EF6uTkTfLOsBrHgudRYUvQlKZ+IWfdj8EJoPIbGjg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2931 This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- empty string. Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the physical address of a symbol") Signed-off-by: Jan Beulich --- Of course this really would be a prime candidate for avoiding the use of linker-script-defined symbols in the first place, by using .startof.(.dtb). If only Clang also supported that ... --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -162,7 +162,7 @@ past_zImage: /* Using the DTB in the .dtb section? */ .ifnes CONFIG_DTB_FILE,"" - load_paddr r8, _stdb + load_paddr r8, _sdtb .endif /* Initialize the UART if earlyprintk has been enabled. */ From xen-devel-bounces@lists.xenproject.org Mon Jul 25 10:16:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 10:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374499.606572 (Exim 4.92) (envelope-from ) id 1oFv8N-0001gB-NN; Mon, 25 Jul 2022 10:16:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374499.606572; Mon, 25 Jul 2022 10:16:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv8N-0001g4-Kb; Mon, 25 Jul 2022 10:16:19 +0000 Received: by outflank-mailman (input) for mailman id 374499; Mon, 25 Jul 2022 10:16:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFv8M-0001fy-Es for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 10:16:18 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60080.outbound.protection.outlook.com [40.107.6.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d1957163-0c02-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 12:16:16 +0200 (CEST) Received: from AS9PR04CA0144.eurprd04.prod.outlook.com (2603:10a6:20b:48a::25) by DB9PR08MB6553.eurprd08.prod.outlook.com (2603:10a6:10:25b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 10:16:13 +0000 Received: from AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:48a:cafe::2) by AS9PR04CA0144.outlook.office365.com (2603:10a6:20b:48a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24 via Frontend Transport; Mon, 25 Jul 2022 10:16:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT030.mail.protection.outlook.com (10.152.16.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Mon, 25 Jul 2022 10:16:13 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Mon, 25 Jul 2022 10:16:13 +0000 Received: from 9348a12d7fb2.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id DF8D64BD-F78B-4CDB-9282-DE4D455C7414.1; Mon, 25 Jul 2022 10:16:05 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9348a12d7fb2.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Jul 2022 10:16:05 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB4506.eurprd08.prod.outlook.com (2603:10a6:10:d0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 10:16:04 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.026; Mon, 25 Jul 2022 10:16:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d1957163-0c02-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RaS++jbYPKV2Ur80Fzb0Msb7ULa9wexhqBAZKRXYBW2KcR3NQUC8bg9gdhPr2enCRZPlLAAgrkqBKy1xc4EP9PgefTNa0oc2VgjkN6IBZBVCSDDleeEEG+fQDLERijIzK2aXUaaK2VbuPBFyU8+b9j7/o4zw3w+823I/g5T7OIAVUvzfg/ksmak8uVIYssin6W5KQVZMA4ACaDucLb4MEBSd7a34jSCgdDXXfOSRRbeKTL1zZGsVRpDCgX8TbhsYlISxVvs8FfoJUiWuPJNTHpZ/zjthoXyIQhB1hLV5w/ThwV0IYddlPZ9IlIl2ABG6KALYaYUzKngH05tbjMSK5g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=DQDtdyv8SPhxpALRFh4M25H7lZCTmZUmJd+sbq7mDYOy38zQiZU3O78eU0Mr/V+FdkuCSw7/fV5fnupAdkc82/Jvg/z45AqAb7r6tG/x5vK4aJi3Yn1t/DcWMY+X5iBcrlilbKwC+kvPtk1przZ9bYob+UO/PZEvsl7I+rorjlDAkkrPloVdIB52JTJ0qeIfB2xrFF84Fv4vghwKUnkqK7WhFRWCqY8qvsSmDsp9Pz/pPuDCW1JAr/qOxDEMYYnNBc3cQ2cIeGEQNoL/+6TJUDMrKyL+0sgxQRJoOIkyxSVLZRReoN4GM6eZs5n8PGzvZFkjnscMc6FZhaRvATABog== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=P5b5vKUJm56J7ncXb35lYsznZuLvgHw81RiE/xImyALkmCtG3ebXPEQBlGFFqocfdRDCkYySnWQGaTRoixBwJSqDnwwJnXugbE1NK6gJSJG1B8759V3tT19M7DZbrxnv1ci799puDzt6NTQGqJef1Ffy/fM9oUNZDUJpl+cT8cY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 28ea5f9c2e39e528 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kHatFPrOxmQ1qzIXhFfNMsKU+e6GIE+hij5gvX1fNfYs2xI82HQ124oaMLVgm1dacdE1kfBpKzyZgvtddWCKCcfNSviojBjviHx9zY+QvctsX9eTPPJ4RyVsZrr1Y7QmuhREoCaZ+ZfeXZj2ZQXBx+aWPS2uCUNW7kVa1ukUTWufC9suDqfbTVX/Q1SiP1iRYoBI6d3S8vDRKLRxBFo0PMBvHdaAaNFCXG+X531zJ/AFEhsz+QWXFEW+oIdTameW1Sdbk5z8hLvY7uk5oAsUk3eRq6Hc+qz80Pd/Q0SQ8h6Wcz3x6426aOZt1VNRlIqmJc5B9oL9+vWlWCi88tIXOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=BXE9hCw7tQY0lmZo7Nu64mpfBy0VrfKwGSrlVE0s1w4eCfDC7Yw7uwZL71E2372UD9qSzaNVMBBSCzx7tDLiG1UpUIRDawn5r2TqW4dtGLnS4XXi2ISGpBALnMQqwTXbKtLXVDv89qbZ+Fh4lVSEkepuaE7JjAHsDxk5KN9Gyu1zMgMeJN9iwdsHM/aVGOXRs35LNB7V8Gohu7hhz85mfzMtNQkwGzYfZq48lwy88NP9BJ1Q0CRC8DAiR4sJrVUvcvWaZPN7kghQCAwZ2zoB3VEfKAj9qIDcE01Pa6EnT2FAtO2O2bx7obCJtVRckBudFtm81S4e/PYnx56JSbRrwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wS9vItpIuIK9OlfLSP7o6peJlfETlLDCYbgMyPx/Gjw=; b=P5b5vKUJm56J7ncXb35lYsznZuLvgHw81RiE/xImyALkmCtG3ebXPEQBlGFFqocfdRDCkYySnWQGaTRoixBwJSqDnwwJnXugbE1NK6gJSJG1B8759V3tT19M7DZbrxnv1ci799puDzt6NTQGqJef1Ffy/fM9oUNZDUJpl+cT8cY= From: Bertrand Marquis To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , Julien Grall , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] Arm32: restore proper name of .dtb section start symbol Thread-Topic: [PATCH] Arm32: restore proper name of .dtb section start symbol Thread-Index: AQHYoA8PRqZOjU+nJkmLp8Hrm92H6a2O3vcA Date: Mon, 25 Jul 2022 10:16:03 +0000 Message-ID: <1130CFDC-9464-4559-9E8D-DBDFF069B895@arm.com> References: <9f1949e5-665b-a153-342e-8b3482c8b9c8@suse.com> In-Reply-To: <9f1949e5-665b-a153-342e-8b3482c8b9c8@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2757d274-28ab-483a-8182-08da6e26b3fa x-ms-traffictypediagnostic: DBBPR08MB4506:EE_|AM5EUR03FT030:EE_|DB9PR08MB6553:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 0XuFcGxZV7YN3OuTbaACJ/xryFloYncZER+htYMxUhkiD4msYxaomOyWq53Z+rVhvpjIQbcZGe2ClrklRhGc7EUvIY/Le0B5Oy5n8xt5Bs0ew5hlP5dKSp0Ig2l2iNFaScUgpWzz1QyuAQd09sb9zx7pbpJS0/6ucYgTD1rP3RhIdpsQ08i96oO0KCse1cuUciJG8NotT+0zV8IcDAS2wJP65DkoVikHRv5wzMr2Gyy7DGR83T1YVrdGBz89H6P1WoDbb8EOlU/HnwkUro9h9e/hc0I9dOjGIG/WD7xqHPfyAgEt0BC+j9wLGTcNHKm/EA/cg3aHJvWysKVI+MaIoQtTquYJF1BQwJ6L6W8tYrjQgDZGN6sPgUx8Xf6rIl4B320ve7pUfaVp6YNsNetsbgQ9aMKGYmJWmNgidkoCTm7PeIKt68+pPLS+/HLio+VnggeR3QU3/8cn6hIYvaZU6JtYY4zDaGrUgFd8odfrK5stb9pCBvbl+xc2yJn7+/5h2AgvKyd6DTxDsnfxa9Pt79UVwsCJ15IGevKGYAt1SIKCICMarjNM2hggIhaeBhw69VcbIYXXeosHAGpaUNleOEvg3VZ3J4ySWWoYh1dk8fzW75pTXicuY4A7mfh8Lb9kwohOwT2aFEgCXuC/Kglp9Wb2IohwtNXxSmROodxKziILLGm59OkDbpSC649Sr58uEmZCvAhxGkygyZCm5+/Bb84lGnHO0iPTSE50dRmCx5+uHLNT1tOHhj/zEZ7vFoMZb5NPFfDkVQdcSaVQG0f5+qz2k/VDBHZ3aGEK6OmI6USvdd2Iwwaq7Wg3H/aHWEQ1ykOw4oF5rEJ5Afha8Xamc+bR9QES8459/vK4c/FHBSI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(366004)(186003)(64756008)(66556008)(66446008)(66476007)(8676002)(91956017)(4326008)(76116006)(2906002)(41300700001)(66946007)(71200400001)(26005)(33656002)(86362001)(6506007)(6486002)(8936002)(2616005)(53546011)(54906003)(36756003)(316002)(4744005)(6916009)(83380400001)(6512007)(38100700002)(5660300002)(38070700005)(478600001)(122000001)(142923001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <291124C6D1BB4547BB0E0B6EA6705177@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4506 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ce2dd595-f5f2-4425-5608-08da6e26ae3c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qc9sHu4MPpXlZSWu58OjvOTBeNJkfK1osdyebtMgE0WRYN+z2pn4XBKW6kXpjouLPrgvEdowatbLLJGMsqXy+lbTOmCpJ+o2nYjn5sOHVrCyW/K2b/7/6eL3z5RPMDXrIbf+QdapCGl8IKaXJyvTj0gfj/CUKDzmTh+4axod2UrGk28sONRtpG63FO56OCqfLfBzwzGaEUl0gs60AE9SiH1hfoHbarmrZiWTNdwZWBlCR7I1/Ur1sf7wuSroxVDujbYbDZ0DgAl7fBO3+smqX7lShqHBsunX3NfyBNxxlxX3CFcf5n4UVAS7cUOiwEjFF8M/tYtiA4V1SGXx08zwSRclfdXGVr+x24484yyqQXUjQKYKdKnSbmvenMacjBNqHL+07YhQCsAxjUkEb+j07ixwUAIZojrHEyM0NKGgd2ukOKKcFmJeIt5bavZIxoY7ScBI5pviQTzsBrFaqv4OtlpwFDf3om0/fqE7XNxBUzpjB7C0d6eVz4xcyh6pbGpsyJ+TTjEN7eXj4Rr8pxobCSAYsDFbUJcPj2wFC2BGa8ABHna23VeBlEmIc6ZuL+yXGqvnZJAE9TZMcYyJYbfX3vCto0BWs0FtMlT/yNugMF6strErOb2xf8u7kjfcILl8JdSOM44D6czv5IoJxdnPcJbTjh5/CdtIDLsP4XRX0v1lb8mp23rPX5lU+ZsK3/yB4QbIEqMwFkWah/CY8latZOVBHsgiZbyNOAzhmuapv4uF438oYm3tNZ9pG8Ec0PNKuNK1ltNlofnzVsNMYIMUDfdQZ9w7NzauUanTo3jGTQnjoGDCZOuBg96gqzyNfQuYdsBCNYd1w91ArZXsVWY/EQ== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(346002)(39860400002)(396003)(40470700004)(36840700001)(46966006)(86362001)(41300700001)(2906002)(26005)(6512007)(40460700003)(53546011)(6506007)(6486002)(33656002)(6862004)(82310400005)(4744005)(478600001)(83380400001)(8936002)(5660300002)(107886003)(2616005)(47076005)(336012)(40480700001)(186003)(36860700001)(82740400003)(356005)(81166007)(8676002)(4326008)(54906003)(36756003)(316002)(70586007)(70206006)(142923001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 10:16:13.3084 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2757d274-28ab-483a-8182-08da6e26b3fa X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT030.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6553 Hi Jan, > On 25 Jul 2022, at 11:12, Jan Beulich wrote: >=20 > This addresses a build failure when CONFIG_DTB_FILE evaluates to a non- > empty string. >=20 > Fixes: d07358f2dccd ("xen/arm32: head.S: Introduce a macro to load the ph= ysical address of a symbol") > Signed-off-by: Jan Beulich Reviewed-by: Bertrand Marquis Cheers Bertrand > --- > Of course this really would be a prime candidate for avoiding the > use of linker-script-defined symbols in the first place, by using > .startof.(.dtb). If only Clang also supported that ... >=20 > --- a/xen/arch/arm/arm32/head.S > +++ b/xen/arch/arm/arm32/head.S > @@ -162,7 +162,7 @@ past_zImage: >=20 > /* Using the DTB in the .dtb section? */ > .ifnes CONFIG_DTB_FILE,"" > - load_paddr r8, _stdb > + load_paddr r8, _sdtb > .endif >=20 > /* Initialize the UART if earlyprintk has been enabled. */ From xen-devel-bounces@lists.xenproject.org Mon Jul 25 11:45:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 11:45:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374514.606583 (Exim 4.92) (envelope-from ) id 1oFwWP-0002pB-Aj; Mon, 25 Jul 2022 11:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374514.606583; Mon, 25 Jul 2022 11:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwWP-0002p4-7n; Mon, 25 Jul 2022 11:45:13 +0000 Received: by outflank-mailman (input) for mailman id 374514; Mon, 25 Jul 2022 11:08:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFvwX-0007QK-VK for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 11:08:10 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2055.outbound.protection.outlook.com [40.107.244.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e1d20e1-0c0a-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 13:08:05 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MN0PR12MB5738.namprd12.prod.outlook.com (2603:10b6:208:371::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 11:08:02 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814%8]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 11:08:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e1d20e1-0c0a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GPVgGqYILFVynq+nivA00pGVEZv8ay+LpfHy06dTzQnb7aru/brTjITnuCBGsuObU9FdTv4u76z4f1vJ6lHBo98O0DLzsXlpCOJsJ4wPRd+Hz9+iWuwLLqUTceAUD85ZWi0C1D5SJOzL/VbFZffqWDAR+smZKo2FBNVTkey+7WHpYEswCZIh5sL+M4ZDVhoN82ku26S1D9rIwyI9wRiSLmrpKsNM4X8Ey0LIAujKgCSz/fIuci+rtHvSzMcr6lrDyitjOUliFPicmr8qrw1rqzq60XS66/y5qUr1NjhG0mrY5oEO8n82eONSCnoOZazK+CeOD69lWuh7D0Pb6435Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1pE36YuDFr8dBcDQe1VFdtWB/yKy+888/RgE0jLo6Ec=; b=g2LnAtgaKfOQWN30toqn88/JaXI+9VYJ4HWotfZLWzpq9KviPID9l1599WYCA3N8e/qlSasuwBq+93LvVb5Ykx++hGbSkIWe6C1JmXufkgys322GN8A82ads7FS9snxAFIctuF1I1/nrahU8iGI/h8u7tvLActZaWvFjSWWoCNlcV7nySelqKO+YDHgea9Aidv9SEGeaYvYxjML3sAiJFGUDc/UwjplHLbXRbkyGcRNcHzlFp+viee1yfVgwLE4K6kvFpbCDzZ2MGTPNIedi7ezD6ZB3ol43IzaL8N0DV9b9cC5xOQGaCXAZ7Kdc4BUNxDcPRPAmebcMZz/dyWnLQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1pE36YuDFr8dBcDQe1VFdtWB/yKy+888/RgE0jLo6Ec=; b=5Z8p+fBHsXpVzqp0NBwpyVeLYmiglUQMi8KFLzvP5WxWTuJsuiemaU1uAw9fTgeo6kmC8VbOgEsyufaNFKyxx0gr0cBftaXZ32/YjIN8r0nxWTTz5YNuakQDh5isRbdOQkwe4nYXVBf+tZavabWHx/og9l0d23zZORQQlOINiNk= From: "SHARMA, JYOTIRMOY" To: "xen-devel@lists.xenproject.org" Subject: Enable audio virtualization in Xen Thread-Topic: Enable audio virtualization in Xen Thread-Index: AdigFizJpGeQu9pXSearK44pKRlEjg== Date: Mon, 25 Jul 2022 11:08:02 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-25T11:08:00Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=7d5c4f99-97b2-458f-bee6-d48e42e127b1; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a0944b6a-4e07-45d0-798f-08da6e2df0e9 x-ms-traffictypediagnostic: MN0PR12MB5738:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8kQVsv45sr0ssnsJ+z/RKwXpQt4MX8GsqFoAxhaC1rwHt0zkKTUltF2XpbBoOofh5AlmdR+TkzzpjulnqH5U5vK45N+iXgGCXV9wfhiyZRXJefnpx9MvDNJ6OFfOMHZ98L90H26SVGAadU/r7tsrL6P7O0sO/7+4+h2Z4g+ki4sr063GVQTXGPrQ7965ofiY9SI+XZ4lcZpfTiKdYlj7L786wQHDlo049B3247MKdnDnTM3+H9pGfScVtIhxXfxvdVGaWBClllXZC/yIKfSOK401BRa7DR4wi+IVa25laNEJjJCZ7BCBUNNjJaJPkLZB3AQDq2hWmTjSL64xf8Vgo8FeD8hleiJ4j6U33gr3AiLKtPUmnbDBXYDHbIC6cnPKAAdGIZGQodzgRr087Ek7PPqzc7saxmKts6XCyjCUCNHtXB9HOur1AjIQGglX/ex+5W9+TYm9d+1CPrBcm8TdoJmGyhGIVua9zO5b8hv4RC1mHAmLeiHELD+YSRUfW1RldY5bZ4fTJJ9GI4X7DUh5eYq0bH1K8iAf4rUloTzll7nWLwTVk01arDXw0WzwKlXwG8QzNqKtEFxWCZhuodV/e0Lns3zbXADQ+eY0nPq9Up+umditvpUxQr54LTuDYIonowK2wFa+a07W1Alt8s7XW2q74uCrp4wqv/d4pEXp+LathQzGx7RiPFGu8LqsHbSQ5wsHa1hLS4Hqro+RKTKG0OWba1BLj+uXTGqCB2aIWL7htgQZHYRm1ph5DcB+Ncazxz/XKhNcXdwYT6wTe2sHErpJAr50aSN+4w2JBb2fTRFxxaZOVW2hjkpsqqXYHW1X x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(38100700002)(8676002)(5660300002)(86362001)(55016003)(478600001)(71200400001)(122000001)(4744005)(76116006)(66476007)(64756008)(66446008)(52536014)(8936002)(66556008)(66946007)(33656002)(186003)(6506007)(26005)(41300700001)(9686003)(7696005)(316002)(6916009)(2906002)(38070700005);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yd0dbIYciRFAYaZVjogPw+njC0cl+WEQsxIwPoKyoszS6wMBHt0jnUWnJ+o6?= =?us-ascii?Q?uIPyPHrn1yt6DxWESTfAUr53xaqVCfnjnTQAEEapRxETjthIGwphMqW+RRli?= =?us-ascii?Q?lb8J5dMqP4lN9jomBSZcVbisAOxwhHsBugU+o4rlM2Er0GjdwLReLfo/S4Vx?= =?us-ascii?Q?ZuzHCC+07MCjJq8uT1jgGJQ+xWw9OleYykzSGeWBmyEas2zf5ygBLosHa1t2?= =?us-ascii?Q?hPljeEOG7cHL7pQ991hdmXlZaVQJQPUlypQ2cMjcg3BfGMc7A+8naUV+rHoy?= =?us-ascii?Q?V2eAAos0a7HeX1UHRIDpGo72JnLjpO4ZpxhyBbC2JYR+P/3qjAYiTKduHT6B?= =?us-ascii?Q?YjeoE0t58BOuVuVpnPjbTiff4CMHLV3BUbb7hs1uIsevfYohGt3cm7EqHLc/?= =?us-ascii?Q?cGe4BxjSw1RRl/84Ayr6uGR1GvIV7KfY+MRrJOq59rlJn9xFMvsWKY012TYD?= =?us-ascii?Q?5u9Rk9c/IW9lGsbJBeGoVHtkbpo8zsPTRUqiauCfQIxZB9nvgXcsI5LMCpN/?= =?us-ascii?Q?pTPz/LtNHw7gFOhL6O7AD8Qov3WZ2c9P9oZM28R6dySGHvpN7iJhRjCrdjnH?= =?us-ascii?Q?pEMtoGNNecRDlKn/AquEEegkMyg5dBaka8c9dSHRWK7k4AuBq0vXafDIzkeE?= =?us-ascii?Q?aEKy1lD5/KSGCkSWgvYFJ/PqEOdhan10aHlBQyIFxm5je/iA+4M0J/5Mcnnc?= =?us-ascii?Q?RICfzMcABLjJxVAT/eXZlUfoyEZrQP6tDqXGNMAKBlzEHiO/+pAzeatvji7M?= =?us-ascii?Q?HSPkHOBHZoUPSAzGPc02g6Ehm860gwyl9EwiR/P9likRWiKBkdDht16/l7h0?= =?us-ascii?Q?nc1gXwUDyZxtcg2c9mjPDq//pDzn0Hf/TIJc2o1t5ILl6NYaVYUeq+jNEtdu?= =?us-ascii?Q?iFzLt3Z078uPM+aAaAtpW3e+e5flKgdQuHKuJe33PqmX+ZWktsydIbBn/6bz?= =?us-ascii?Q?iH3n1uoU6W7Mrq3YOwAkC1lKKtEnoDVY+a9/HHB+4w1wvyl/miLcCb4Oqkrr?= =?us-ascii?Q?iQFW8QEhx1MkKmwl31d41L2IY8fu8RntWwia1FEPhJm0/RCt/7NasU20JE+G?= =?us-ascii?Q?yfPLwdrhG9RUoM8jZ1bYIHK80JeX0BTfnl1/CXy1O8ey0yRNzyr6FeyCZU2R?= =?us-ascii?Q?VKfnnRC8LVsvx0f8aqWogQEICA6wmztAhHiE6IBx6zAxLgU+MdR1R1R0LNMr?= =?us-ascii?Q?Ll9PvE+ONhQnufxVvYtLoLQW0tfo1jB9EWCaXTjDPvIH+kQrua0L4FEACFYV?= =?us-ascii?Q?tmuUqJIGJ7Q8VENE506pa9y73pz2d/vaw12poxEPr69uQL6XAelu9P4NijjW?= =?us-ascii?Q?JxwQXHy+90t6IiCZD7LinbptpoF5ZMBQ8FtBq7r426WtiRp4MBPRZHBN3Xly?= =?us-ascii?Q?Sj78DQJ2k8n/413k/OOOTdue9B/n6jEhEUTL9hhXPbJs7YHgap39D48+Ny0A?= =?us-ascii?Q?jnhWx4xhajsB7PH9x4Lfo0o8cgM2u2FmDfssGVAoYTTiKVNJF+f1iCyQ3IWG?= =?us-ascii?Q?HtovTP46NMzjmFbIot8pRaiqt7KxawMfM2hWpwUr1wdAzjaufTn9pgLHjoVq?= =?us-ascii?Q?FytSWmj4ZHdgEbHCH93Egnz+sMGteXz3lfi6Bj3/?= Content-Type: multipart/alternative; boundary="_000_DM6PR12MB4297AA9CE29208A979437D889F959DM6PR12MB4297namp_" MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a0944b6a-4e07-45d0-798f-08da6e2df0e9 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 11:08:02.0606 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1yZgSywADXfhpThqgkYjLoRWGZvjYJWwcpyfYfXCNqNLUn4zw7eUNnjPwBdR/LmHcoS+cDPUYq1Qzeaxg5jjsw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5738 --_000_DM6PR12MB4297AA9CE29208A979437D889F959DM6PR12MB4297namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] Hi all, I am using ubuntu as dom 0 and also dom U (HVM). I want to play audio from = "dom U" Ubuntu. I am new to Xen/virtualization in general. >From various reading I understood that I need to take following approach: 1. Use Xen front end ALSA driver in dom U 2. Use Qemu to connect to the backend ALSA driver in Dom 0 Can you please let me know if this approach is fine? If yes, I have followi= ng questions: 1. Do I need to recompile Ubuntu to support Xen front end ALSA driver? O= r will Ubuntu iso file already have it enabled? 2. Ho do I configure Qemu to enable backend driver? Regards, Jyotirmoy --_000_DM6PR12MB4297AA9CE29208A979437D889F959DM6PR12MB4297namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

[AMD Official Use O= nly - General]


Hi all,

 

I am using ubuntu as dom 0 and also dom U (HVM). I w= ant to play audio from “dom U” Ubuntu. I am new to Xen/virtuali= zation in general.

From various reading I understood that I need to tak= e following approach:

 

  1. Use Xen front end ALSA driver in dom U
  2. Use Qemu = to connect to the backend ALSA driver in Dom 0

 

Can you please let me know if this approach is fine?= If yes, I have following questions:

 

  1. Do I need to recompile Ubuntu to support Xen front end ALSA driver? O= r will Ubuntu iso file already have it enabled?
  2. Ho do = I configure Qemu to enable backend driver?

 

Regards,

Jyotirmoy

 

--_000_DM6PR12MB4297AA9CE29208A979437D889F959DM6PR12MB4297namp_-- From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:08:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:08:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374539.606594 (Exim 4.92) (envelope-from ) id 1oFwsc-0005ox-Ht; Mon, 25 Jul 2022 12:08:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374539.606594; Mon, 25 Jul 2022 12:08:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwsc-0005oq-EZ; Mon, 25 Jul 2022 12:08:10 +0000 Received: by outflank-mailman (input) for mailman id 374539; Mon, 25 Jul 2022 12:08:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwsb-0005ok-CS for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:08:09 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70071.outbound.protection.outlook.com [40.107.7.71]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71e5b0b9-0c12-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 14:08:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0401MB2434.eurprd04.prod.outlook.com (2603:10a6:203:35::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 12:08:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 12:08:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71e5b0b9-0c12-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HrYUGg7q9TqvhSLjZ5DhylvShSZj3FHnCyFwpeGu8i+fPVJLE2h1lk6vmcHZ+1Il5uTrrMxyQ/I1UsJlrlOhnlFqodzHpCB2b4DKATk8uQdTl6pMcW0aiJAngRYqgBupI+tg50H5g4OKQBtTmnZcYOQ82rScQiLcNB7QjR9aqgeuw3AKvvywtuSnkK2NEozkDJv/qNSHzwPAxlyWxZ6T95bNHzlvFKVnBjJcsLrloxApd8+dZrill4ts/5TpKcz+3tL2GUrsWwLc2XqgDggrhGmtgXEDgU+XXGy0Wlcim69aWZMsyXeRhf5VR7Re2nAiVeHVkyuXlh5EeiDex8m+Og== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ix3T/GyDlyNaCXGu9Au09uHqaznqPh8szhyrUBKwsA4=; b=OKaM7xXvlagmLVtTBTRmLgPY2ygglmpKTg6lWCt3PFG0E44RnMYCOMdghYfE28cUyQXnZ6t6sIVvyqKGM/s25JUfoKZc3KX5Gbtb6jLgFUUaHLFt4hxuKVmlXCf4AiMOe+NCk0etQ7iguuKfaKVqmDgN2S8igPk0BnEXhAhcZLPpf3kg+vU4pzvLS/RBQf99MPEUUTRb0PeZwSc/AIa1zg6prXM1Pn/eoQbhMNpwUkEFeZcLDt/x3fHxxOSLfrZwNsEQ6AN9mWDK6UO31TkI6SM2bFtnN6L1K8ZumJwn4OBvfuSKKQwquNnHr99UAg6S9mveQzyoF6VqjOH/hsqUhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ix3T/GyDlyNaCXGu9Au09uHqaznqPh8szhyrUBKwsA4=; b=hiJfykQ53zpqsjD5cUf1ubWTEYt3yocURM9yy9pXAgMyEI7M28s26YQ/UEpL6nzWOFYtuXLHQjv8gb873xVCM+tOdYAAlmX6dRvWJcX6ZjzXQYonmLoAgDT+qptZ2eanil58EazRYDoG/amNE/Fy0JmXLdpKFbsaesHEHQOdpCm7H8tZ1smszfc8m8FqschOB40Pa99mGA0gb1BOrSRLjxzlY5oDLKvVdWp7eU6xPEGYG9AhpSR6PknvSSO+1uXsFH1abeDCQWgGxTSMHNMKXixll/bpxhl3hnFMV03FuFk0ji7UVCjwJ3yLnLNcGt9wqp6tcx4EKHx2/H9HBq0IJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <15c8b790-f6a6-42e6-d244-8f7d83c880b2@suse.com> Date: Mon, 25 Jul 2022 14:08:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Anthony Perard From: Jan Beulich Subject: [PATCH] include: correct re-building conditions around hypercall-defs.h Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 63baa11a-18c8-4cc7-dbc4-08da6e3654ea X-MS-TrafficTypeDiagnostic: AM5PR0401MB2434:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NogFDpj0+S0BOuhLKaBeJ2jqf/+ZchVrjNQmftcBCJMVsBQD9Q+9wz6Ni1YD/5vu/6uzYkX8Nqqm4eUavCHbOn5hJS9tpJdJuQwUsKWKIDHUl607IcbSfWKMpfuJXpDyL4qX5PcC4+qoO/ErjBc79JNiAyITtHtsJTbbkYALuQafjjYX/BWt/pQIEoLe7W9epxbmTS5T3A6QJqWImtFnAwRzRKCcHdulc6a8nSlaSqdMVt0D1DAz9NC9y5aZzKp/KNVVTtNkgW3OLYgJ68FqanZGBYfhvTaTJkfTDeAC4uiPwK6fpiQ2pzVjaUC3BRlxocI9b4m0418d2cd0ZJayt/2o0BDBHLvnUkc657XW8VNJbB2o2ifbbi82oq9T7hE0Z0pasSowCQNIA7z1lfxIT2Tk15lrcG+J6rvI5MFqYEwBmkBmldPyzDe60W3OBSnKpHzs4pa6AOuSb5P3sJwXfr+Dr0gSZbASgZLe8nRwaInjxjwOfywPsmrEQx+/Q1J1ORbxpEmU6goHYQ+4IwNteU4+brers2Mm+SzQzLGpzeVLkDB3FQjt3yt2aGkB9eJ8tyrJwiA2OpC5yErfPOC+kOf6vV9vApA0k6ZgQ/iE/de79tJESEvL/hBkWQht7iGeOTqzbTj94Vb5RWsE0bKYlI2yoPAzVVdIQ3pXOaY8QNRMcu74ABVHcC6DbrmLSKWv6zN+fVBNL3D8h5QEsaMJjxUqQLiRrPc06PaoZSGpSI+iO5atWZ1WCtge/aS08fAxgxB9Z1ZbLS412d17NbwTzra8+DeUFw6SFb+NHJu+K2lf9VatW+JRtHtgkTzmOYNYLFlsKTmQO+TApMJ8k+m8uA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(186003)(36756003)(2616005)(66946007)(54906003)(6916009)(66556008)(4326008)(6506007)(8676002)(31686004)(66476007)(6512007)(41300700001)(26005)(2906002)(38100700002)(31696002)(86362001)(5660300002)(4744005)(8936002)(316002)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXB6clNGK1ZGbzJ1U0JMQThoM05ueS9NQ2lWbjlWYklWdkNBYUxEZ3R2eFp3?= =?utf-8?B?TzkwamxBNUgyTWZoMXY1Z2c0TnUrSHFTZUNhWmEyZUNxOUpiajVNZEJDNnZF?= =?utf-8?B?OG94YW0ydEhQbDFldjNhaE5idG4wUWlyRm94WlFIWHVYTm95ekZWQ2VVV1Zu?= =?utf-8?B?NUR4WDBlMlN5dER4QnlNTVlzZWxEUWk4VUx6eHJ6NWdraXRScmJ0L0lRVWpm?= =?utf-8?B?MXFEaFJnV2pzZ00vZkdlK08vNlNrRmJRQm9sZ2NScktpTDVkcktoMHI4MGNE?= =?utf-8?B?aTRxQzRqVWJJMG1JaFU1UFhKQTc1dm5xUWx3Q0ZvVXJiaVR2WWdoaHphN05R?= =?utf-8?B?Q2xNVGdpVGxQUG5kTEZUV0EzNTJPY0Q1MXZYb3VpY0FidjVmWmpJYzRwV1hr?= =?utf-8?B?aUdyNjdZV0VxTW80eFl2bm9Ma0MxSjJyNzE0Vm1RMnZlZVNEVEVoREtxdkh1?= =?utf-8?B?MHRVREFTSXBPTHRvK0k1V3RhelZXU3AzaGtBTTF6Zm1ETTNsdnd2SFpPYXJK?= =?utf-8?B?ZEFhaVIvMEZQaE9JUEdUeDUvY2d6VVFPVHlEUHJCNTFEMVlOdHhTZDdRLzB1?= =?utf-8?B?NkhHdjQrVWJlZnVQWjlwQjhrMGczOUpVUEFId0thT0JIYy84M2NMOEJGYm9I?= =?utf-8?B?RnlTV1RnR3JISnZJUWxRS2RONkN3NTZEUlFRS1NqdHB0TktpNHY3eUVadXF4?= =?utf-8?B?RG1GNjE0azh5cmxFYVNjb1QyQ2pEanJTRC8vdldBcjIrWVBJbXdlMGw4a2s5?= =?utf-8?B?NHpOM2pmZExxNjBlU25LbU51WWRkK00vMUNqOXd1Q1lYa2hDa3g2WVc3bmU1?= =?utf-8?B?MkRCTUIwMm1yRGpDTUZhSFU1WE9BZ3ZraXdkaUdxeis5VG1xM1l1MGEyUCtO?= =?utf-8?B?M2VnREl3VjdGWEZpTXpnWCtva2M1eEVqaHkrbyszRUtXL1Njby9NNk1uaWgr?= =?utf-8?B?QkxmaU5adCsrZ09IUDhtM1g0MkpINmQ0N2I1WVJsL3NLKysrbjF5UDRVYURa?= =?utf-8?B?UG9Bb3hXRGVRTkZPY1JLUmk0R1NlY1M3bjNOalNzOVBXOENBa3dOdi9rdlFC?= =?utf-8?B?VzIvWVR0TFp5ME50WWM2a01GOXF5ZDltenN1cTQ1eXJmcUdMY0RZQW15cjdC?= =?utf-8?B?QnMyWktEU2wrNE53ZmpsbWJ3azNocnZLdlVjYkJuaEdyQ3B1V1JLVjllWHN3?= =?utf-8?B?anAzTjM3SGgwT000YWJyY1M4NlNrMXFyVkZtZGZveDdxYnVTcVpKVll0SUc2?= =?utf-8?B?VGo4K2pMU2prNG5HTEhRaS9hVDdKK1ZsUnlTK1BENmVCL0dKS0U1VHY0RStO?= =?utf-8?B?OVluK3krUTljbzBBcnFrL1BDSVVQY0ZOV05HRXo3ZjBtQ0duQnVhemsveXJQ?= =?utf-8?B?enE3QVFrMCtmRlZwaEdwbDc2NCs4aEN6YTc1b29QcDIzVWtySG1uWGhDc1lE?= =?utf-8?B?NVdPSnYxT3o2ejA1TUNXd2RhWjgrMUVXSzBlSTZWVVlBY2ErUW9OMWpMUXk3?= =?utf-8?B?eWQzY2pFcHhlOW5vaTljT0xkdkRydWVpZWVGWGtxbjVDa1ZaeElUbER3aEc1?= =?utf-8?B?c3dpKzcxUHJqWmtUUE1HbE5OcTRCNmE1NUVqYkxibERNRUtpM0RCZjQxSHRT?= =?utf-8?B?cFVqeTRjNFd6b3FZMmRuK1BYYVhMUVFhVi9mdW1ScWRQODhIYnFJVEJUdUFo?= =?utf-8?B?Si9KY2dibXlIOFdmcEFwNmhFYmdNMFROVzd3N2lKOTZHT3ZjYjMrSWxZUkZm?= =?utf-8?B?d2FhS3Zuc2hFUGNoWWR3eDhubEdwZGlPTElZMFcyQ00yeStJOThWM01XWnFY?= =?utf-8?B?bFBYZFM2aFZOdHdFV0M2VmJZaTFKQjhFQWNsVDZFeWthSE5LdU5YNTM1NUsx?= =?utf-8?B?alVQT3UwSmNRdE5CUjFDSVp0Uk9MME1WTmROc3Y0VktSbE5tT0dnU3I3WS9R?= =?utf-8?B?V1N6bUJTc0RCUzFBTlhGcjkrTThjcjhCdTcwbC9iYXpTZ0grRnZpc2I2cVRX?= =?utf-8?B?eWphbk51Nk81VEc0b1NDQ2ZPRmhTd1dxbkhsVnl6MjBkckFOcjBPdnlqZU1o?= =?utf-8?B?KzRJVlYrcFN6NE1IYTZka2tFTytBRE1VaE5qdmhhRVhsNFA0ZXMxS0NsNkJE?= =?utf-8?Q?/K5kQYeP6Kxy+aQZawR7EdMjQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63baa11a-18c8-4cc7-dbc4-08da6e3654ea X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 12:08:05.9407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u4OzKQzkzRkD2F/xP/fHOJVS8br+XSn8yM1VX1m3tCg2NcSGXnX2ajYL6mhLhzAML6Ci21WPeBOBhgMtuRCC8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2434 For a .cmd file to be picked up, the respective target needs to be listed in $(targets). This wasn't the case for hypercall-defs.i, leading to permanent re-building even on an entirely unchanged tree (because of the command apparently having changed). Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") Signed-off-by: Jan Beulich --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -114,7 +114,7 @@ all: $(obj)/xen/hypercall-defs.h $(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(srctree)/scripts/gen_hypercall.awk FORCE $(call if_changed,genhyp) -targets += xen/hypercall-defs.h +targets += hypercall-defs.i xen/hypercall-defs.h ifeq ($(XEN_TARGET_ARCH),$(XEN_COMPILE_ARCH)) From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:09:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:09:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374544.606605 (Exim 4.92) (envelope-from ) id 1oFwti-0006ME-Rd; Mon, 25 Jul 2022 12:09:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374544.606605; Mon, 25 Jul 2022 12:09:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwti-0006M5-Om; Mon, 25 Jul 2022 12:09:18 +0000 Received: by outflank-mailman (input) for mailman id 374544; Mon, 25 Jul 2022 12:09:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwth-0006Lv-Jy for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:09:17 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70050.outbound.protection.outlook.com [40.107.7.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a36fdcc-0c12-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 14:09:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0401MB2434.eurprd04.prod.outlook.com (2603:10a6:203:35::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 12:09:14 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 12:09:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a36fdcc-0c12-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ohx1BLH9T55WAC6EnItWbmBSSSvAKIY7vRT3PYfFShYfvGXingPhyAfVFfYwNesEyQ+iplQs5C1ysAzIQkVA9VNM4EA2NprJE3ZylnxC3VBdyhBlC4LKbeQ2KA6K496V4a6flMF6Yus2J0GTqh2HeQhW44PYxddsrhlLXVj19kfU6/qtWB7biSgp3LNjQv3CfeNcW4O1RTjukWRdoNXDyxlwID73Snp/Hymgi6pxCjvHo1EMuPq33lKNEhhm8oldLSQ/KskykXfnIjle7kgJdF73kv7dtLp+OUUAMjSbCpmC7K8uohpOTQ/kWSl0FsksaZoknu6YCc8ESBVFF9kzIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1yXpgIEPCLYefS8RgPyuvc9ydQjRfy2PsDfZ9Qamkm0=; b=hEpVXk3P+TAndDrk1rIUcwEW1+ChCtznmLS9bTFzbU5yWo3JZln2lFPCjwmlkhZ/4kwgsZ9/+ExQaVGeIWGDfINSoF+AZZ8eVv6gSkfQezyDhqY+EDssuRY5L0Tl4ydBaIkMEjmAN8nJOpuzAqnn8Nt+Sf9riHmXeD/1C15u+zHfczA3YrHXvJZx0eGXmEUVrmQUxxz8sWQ+qfRa2Eb4antNAlo0sW82PPQz4czpWo9IPNwCBE3J9TdF6z8RVG/IPWdDd2QdB0VJU+LN+znupgNzQGv4NQZePxPZM2B+ciWAUmpt5X8J25Uv2v24AnOqZafKmVBGGO4gv1PzEU5EKQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1yXpgIEPCLYefS8RgPyuvc9ydQjRfy2PsDfZ9Qamkm0=; b=X7o9ssrAsyK1uqv00ytPYMRv+yXVyOAb0zLodItaf0aNNXqyUyh/EP7MGm65u3YUGjokB4p4CONLoMlBj2dz7pp87OdAVh1X5L6FahylNdIIBni1DslVixev8d9ih1f53tfoGQqH/lsms0a+KTn8uTVru0YkQnh6CKWzuQpl1NWQbcH6HNjivr5QBmmW3lhBf/1CWbVlgUqpw0hz1QqHOss+YTeWzZHmJSOEeYNeY/8mFZqBaCrzPYr7Sek8QBvQRw+1w3LSVECwZKUjpUSs/HEUDtswGwsRnjrBLGxTeZXOWjQFr101jAziZyC1Lacp0yrCKJG3QhaQP599alQUYQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3327586c-1489-4af9-0fa2-29f48d957954@suse.com> Date: Mon, 25 Jul 2022 14:09:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= From: Jan Beulich Subject: [PATCH] x86: limit issuing of IBPB during context switch Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0062.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3dafc363-c6eb-4e01-b5e7-08da6e367d7b X-MS-TrafficTypeDiagnostic: AM5PR0401MB2434:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9IHe25fSq52+X3qntK22Oz+oinjTB/vvKMN4Y1fd84JwL3TXh2cdfv5aMQDENl6iugWIUyx6yBunzO+iV1KyX2tivWdm+k/FdCgWtmo+PyzSGMVFW9Qodg8jq6YcMqpLsgySo9ksqS1JuaPFfG6PLCVoJ/ir2gnhaf3ziG/DmIte2IY8MfaubSoT03RqvBq0lOQMM3ay+AVbyDLc6UcejC+SybCRzYKRC00TfHhN98a/pAJd8T8ue97weVZka4CgYt0fhjoBZDL6F+Cu5tQkco8nz+N4qkVH0nFAC6M5ryDPwzw1xvG8ADEfykGML50dOyvCworBD/2OWPpqfBiQowh0jdHgs14k1G2tspjJDPcp08UNNye20qipJhUlyIuSuFlhdjqHiCYZSkwR3Nf17vi316H9SAM/5CKIiZZIzDLQ7DVjriPIICMYvwf/fZ5EbF7fSSaT0H2kFOVA0/Pt8vf2N3JJX8UWo/EvBDE1lCau+KuzbWwQf5P11uBz0Y6oP9jCYocBN3Z5zOayWLoMfj1+W2VAya5xjmkiUhCfEyJIEnxo+UOpGoHQFcM6icms5gwUqE7dVYxmvflQqSgpzJP7DYgv3LwwCLFW/3bW4BCBBGq6xC+3+BiQ/AgeghpGwq4FgHtNpREj+wttf4+IU5Gm2ZM/T7x6VZTeI2u4VGptGbsCFUdDwcyuTaNIldqfQf0BaiIM45WJVJfc/JQEDnZJt9IjLNEifx2FG7gEXxZjB1IxyyKUTvXRn4DP1VLttZR8Zoe9Nk9edanTxp8Y63HIEKopl7irHoLvHCVU/JjPQtMMRY1ah+qbtaRQWfnuRfp+eA3A1pMXX4LQdPS+HQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(39860400002)(346002)(376002)(136003)(186003)(36756003)(2616005)(66946007)(54906003)(6916009)(66556008)(4326008)(6506007)(8676002)(31686004)(66476007)(6512007)(41300700001)(26005)(2906002)(38100700002)(31696002)(86362001)(5660300002)(4744005)(8936002)(316002)(6486002)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmlmaVRBOC9sd0hISW56Tm5GTVZhdG9FSEhxK3lGT1R5NVA3dHhaNzJkRHQ0?= =?utf-8?B?Z0ZwTXoyVDBpLzN4Q2FCMzAvZEJwQjBoVytYTFpCL2NKaTNnMVphZTBKRXFy?= =?utf-8?B?NENIanQ0WDBvWUtBYTNKajNxRG5zcHNRTS9hdGo4MUdGTUc0VDZUYzVnYm9y?= =?utf-8?B?YXZCUlA3SVlrNnFnaDZCV01OR0NiTnFOeitZVmV1amlnTjl2VTJ3d2pBN3Jp?= =?utf-8?B?Ryt4Tk1zNkNaNE8wM1RxUWNjNCs2V2ZrMnVJcmd5enpMT1luVjk4YU1Najd4?= =?utf-8?B?UzZwcEhFNnltOWNuNldWSzA2bkowZ2s0TUo4SjhLcUtDUkRLdFNUSDh4cFVC?= =?utf-8?B?ZXVxYmc5bGN3Rnc5QlhPbGFWVjY5ZFZnWVZuTzJWU0gxZklUR0F6bXkweCtZ?= =?utf-8?B?Y3dIQlVtajVOMlR1MTU3YTNjam1ocXdNL1FBd3RPRjVkSk5SQUJpaVorVW5K?= =?utf-8?B?dnpTODBsZ24xMnRqK0lMUmdwQWV6dFlHbUo1dDZScXV5YkE4WFArOUk4Yy9i?= =?utf-8?B?MDF2L2RtVEFTblBseWJPd01CenI2bUFrazJkM0J3cHRDYUQwZ2RIMVBRajFY?= =?utf-8?B?MFhQRGc2L01JKzd5Vi9mQkVzaS93WDZ5QXVWVi9hZVA4NzBnbUFvT2p5L0pl?= =?utf-8?B?QUpwMUJ0clBsUFpNVGZ3c011WElBdW1LN0JRcTl2Y1luVUJoYURtckROU3JF?= =?utf-8?B?UmE0cTdDMnI3QmhpTnp5MWhGYnRaVWUrdWZwRXBpUDJ5ZUF4dUxYaFRYK1g3?= =?utf-8?B?NWNPSGNqeG81TGplc21jTzdpRHE4TlNVNDFGamQrMUNEVU1OS3FBeHJTQ0JZ?= =?utf-8?B?ZkVPQU5rUVhQOUgrc3MwLzFzOVFvbkV5bjBCOTgyNzgzQllnekw4V3FVV3N4?= =?utf-8?B?eTA2Ym1ZRVl2Tzl4ZUNLYXBwSGVtT2ZkeC9Rbjc0R09LYU44SzFSUUlsSXdx?= =?utf-8?B?YTE1ay9NdnNXTHhwSG5DV3NZQVR0N00wTEpvcEwvZThicHVsa0NFaW9STFFp?= =?utf-8?B?M2lQMEs2TWVLdDBaZlpWMzJLdG11YlZ3eWVyQmNLcDVuTWJ2Y3VYcElDUTlS?= =?utf-8?B?b0dnWnhDa2hWV2x0eFg5YkFwendPQ1cwS0VBajFDMUhzYjBxbzh5NGZVcHhv?= =?utf-8?B?ZWpOdGxHQjQ5UUUxVmFOeU95Sm1kYTJQMXAxUzhSMU1HaGlzMWZ5ejNXZTNs?= =?utf-8?B?OHZYWGNQWk13YmpVempqZis2YUswWDhleHdpRi9kMDVrTUw2ZTVlbjJWTDZy?= =?utf-8?B?WXVSZTVKM29XMWhyeldOT1YvbkcyWjdCYjdpUklmbmUvWXFCWFhBcko3cG50?= =?utf-8?B?VElYbHBBOCszTFJCZVA1RkFNYmRzN1Q5cVdhTk44THNmY2tKY1FpRHh3ZjJQ?= =?utf-8?B?Mzcyd3JKQW1Yd2EyaHBGekNuVE1wblluNXhzZExBeFZDSk9pL3lFZFlzUEIw?= =?utf-8?B?dGlIdEZSQ3hJTitTSEhHUTJsL0FVWkx5VmNNcEVleG5iNkw3YVdYaCt2Q0NZ?= =?utf-8?B?bWpoUnFFbGJrTjhlangxcGNIK3NSYnJ2MWJYOWh1MkYyc0NTZURzQVBrUi80?= =?utf-8?B?akpSV3BnMVAraUJPdXpOdkMwS1I3eE11WmcwTUpxTnJkemRCZ1piam1pQ1Ru?= =?utf-8?B?djN3YmlmdkJ4WENCSXExOFh5S0Q4TUdwVGRFY2NBdlVjZ3VsQUtIeE1RRWRv?= =?utf-8?B?Vk05dTlRNlNxNlgrNFBWaXB4N09aRFRuckxFeDJOb1NaaFNBTVIraVpxeW9O?= =?utf-8?B?a1hmb3B2YTJTUDVrNGpTbUE3NXRmamprbUdFQndXT05ndjR1WXF0UEJOU2RE?= =?utf-8?B?NFQzaTZvdUdzZVA5ckNMK1dDdVVoWURncVZJQVQwMmxuUEoydjk1dGVib1Rp?= =?utf-8?B?RTlXSjlGWkhMYnBVSU05RGl6Q3o5OE5aMVZKVE1aZ2NKa3pxWkhYcmRwdXIx?= =?utf-8?B?S2ZKL3lwNWE0ZWhZUDEwU3BEMTZjZjVJQ2xMNm5Od0FiYzI3Nm5ROGlCcEhQ?= =?utf-8?B?UXJMNXg2R2liZ0dHSWNjQVYyZlVkRkp0RWdQQVRnYUwxTHlGTDNnaFRYcTBn?= =?utf-8?B?Nlo4eWM2b2txYnFSUFB6RDlCKzdubzNXVDEycEJsU005NEFMa3hDWU8rLzgy?= =?utf-8?Q?rj6IJb5YTU/rsrxbGEgijf/JO?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3dafc363-c6eb-4e01-b5e7-08da6e367d7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 12:09:14.0613 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YdykzJ86Bdydfa4rwsWsnrNZi5rgvp9flFtFAV5dvrEvAn8ZWIcfQekG7vYIo72CNki6sVOJxAW9fDSFMSfsrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2434 When the outgoing vCPU had IBPB issued upon entering Xen there's no need for a 2nd barrier during context switch. Signed-off-by: Jan Beulich --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -2098,7 +2098,8 @@ void context_switch(struct vcpu *prev, s ctxt_switch_levelling(next); - if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) ) + if ( opt_ibpb_ctxt_switch && !is_idle_domain(nextd) && + !(prevd->arch.spec_ctrl_flags & SCF_entry_ibpb) ) { static DEFINE_PER_CPU(unsigned int, last); unsigned int *last_id = &this_cpu(last); From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:15:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:15:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374551.606616 (Exim 4.92) (envelope-from ) id 1oFwzm-0007oG-HB; Mon, 25 Jul 2022 12:15:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374551.606616; Mon, 25 Jul 2022 12:15:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwzm-0007o9-E1; Mon, 25 Jul 2022 12:15:34 +0000 Received: by outflank-mailman (input) for mailman id 374551; Mon, 25 Jul 2022 12:15:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFwzl-0007o3-53 for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:15:33 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 78fcb76e-0c13-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 14:15:30 +0200 (CEST) Received: from mail-co1nam11lp2170.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.170]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2022 08:15:28 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5828.namprd03.prod.outlook.com (2603:10b6:303:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 12:15:24 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 12:15:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 78fcb76e-0c13-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658751331; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=mj5BS7CNdwXmyx7Ynyd6mTcKHsXDU2C+LCrXRK/9TzQ=; b=NckIcOyFjaPWIK1KgXglihiQE5o9UDJ+oktYcg2z6wku21PNtwlDNXKb zR2ux1nTG1fNi8cUZ7AIWEzfAj+BAO3fJgnJjv40zReSTY1SWB2A0riDR Ng1CVaVZWhTEvOG1oOU9dkTX9I0ogguWQb4Skz8bXQorAyonH6SvTsdSu U=; X-IronPort-RemoteIP: 104.47.56.170 X-IronPort-MID: 76551859 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:tfRBa66QQNsFmd8zxyj5igxRtCHGchMFZxGqfqrLsTDasY5as4F+v jBLDG3UMveCYTahKNgkb43noB8O7ZWDndJiHQBp/3s9Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5qmq4Vv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJEgUbbNf2eYuOj9Lz tBHGhEqXBqJo+3jldpXSsE07igiBO/CGdpG/1pHlHTeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LmMe8Q3NzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLarC/x37+SzEsXXqoeOrbmpvFDvWS4hUk1BCMbZAadotC23xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JAHut/5AyTx6785weCGnNCXjNHcMYhtsI9WXotz FDht8ztLSxitvuSU331y1uPhTa7OCxQJmhbYyYBFFIB+4O6/9l1iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxlkRiFKND2Bw1WXm0A== IronPort-HdrOrdr: A9a23:ZjhSGK+FakovlSCWpthuk+F7db1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYW4qKQodcdDpAtjifZtFnaQFrLX5To3SJjUO31HYYL2KjLGSiQEIfheTygcz79 YGT0ETMrzN5B1B/L7HCWqDYpkdKbu8gcaVbI7lph8DIz2CKZsQljuRYTzrcHGeMTM2YabRY6 Dsg/avyQDBRV0nKuCAQlUVVenKoNPG0Lj8ZwQdOhIh4A6SyRu19b/TCXGjr1YjegIK5Y1n3X nOkgT/6Knmmeq80AXg22ja6IkTsMf9y+FEGNeHhqEuW3XRY0eTFcdcso+5zXUISdKUmRIXeR 730lAd1vFImjHsl6eO0F3QMkfboW8TAjTZuCKlaDPY0LDErXQBeoR8bMtiA2XkAwBLhqAC7I tbm22erJZZFhXGgWD04MXJTQhjkg6urWMlivN7tQ0XbWIyUs4nkWUkxjIiLL4QWCbhrIw3Gu hnC8/RoP5QbFOBdnjc+m1i2salUHg/FgqPBhFqgL3f7xFG2HRii0cIzs0WmXkNsJo7Vplf/u zBdqBljqtHQMMaZb90QO0BXcy0AGrQRg+kChPbHX33UKUcf37doZ/+57s4oOmsZZwT1ZM33I /MVVtJ3FRCD34Gyff+qaGj3iq9MFlVBw6du/22z6IJyYHUVf7sLTCJTkwono+pv+gfa/erKc qOBA== X-IronPort-AV: E=Sophos;i="5.93,192,1654574400"; d="scan'208";a="76551859" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TBprPQ8UUS56any+8vmm/7FefxwAU22AqmwMe5gYmVC4kJ4IJL32B++nXKTm46kFADy/97+VZ9Gm/LCGilWhHNI/tVkiIeBEK/xA8A3K0UwoGKCUfgh2Q0gV1iqAbhaNBUaAi23lhUh6G4e+e5+OYfiEQ5eQOqiMPFfhiNz3QDtZCgOYD+4mZJhWFKjo7ZBDFEX0gLrkn2StV5GCwjuJ6wla5LEPio5E0lyDl/wmmRkDc2c14o23ArqzTQDEz5kS8bVdGUcq75nmSU0nkvpETH1GAhCjtolKBEWX+/mrGDwNo5EGw8j7g3mFW+lcHumhH2l834W20scb3X+TaUluJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mj5BS7CNdwXmyx7Ynyd6mTcKHsXDU2C+LCrXRK/9TzQ=; b=cHxpfBb+rDSC0muyoLVDmem0pMdWufujl36apYroLNJUP2K3Kjx+7KW1pGH4x43iwEOjEnbDIW7Eu8+p3XB9cEv/6W+Q0y2e5GoMt9T1n/qNMetCMoWiMcHa0ofTBhKQSa3+W0dPNlsI2ryElxCtOv391kCptHG/dikgvfswHErGTi7ArznRenPm2bhi3UnJX15S3o9zZUqxJJjYoaZS53QS0xmBnLpQmWJ6UsITfa+qa96BVXoVTS3A68W4ds6Dn2xtjXYCljZcHtX81YhpTl2jEg6hAW9Qt6RLiPCZ4PdsbvibDClk0AB5m9bmiz8Ap3Ugq9m4lK9yvURptku4oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mj5BS7CNdwXmyx7Ynyd6mTcKHsXDU2C+LCrXRK/9TzQ=; b=Fu0r3GHx3gAW/IxwPN9pX0ZVsUadoRo5pWSFvZHNS8qwG8pw/e2AleJwE8nnpu3mUXoI4p7Ma9UYxoFBlLPZlbeu7NsP1hhhn2qiu5cYlOFmZaLfhir3i4XGdQ7SK9Mn4YoVAEBsIvzNnq/V4P29Afy7DGl+1gi28l8WPSbdD3Y= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne Subject: Re: [PATCH] x86: limit issuing of IBPB during context switch Thread-Topic: [PATCH] x86: limit issuing of IBPB during context switch Thread-Index: AQHYoB9g490kRgaofE+hh4IHFh3+f62PADAA Date: Mon, 25 Jul 2022 12:15:24 +0000 Message-ID: <8b347c26-d1c3-b3c7-8e78-2e43b274255a@citrix.com> References: <3327586c-1489-4af9-0fa2-29f48d957954@suse.com> In-Reply-To: <3327586c-1489-4af9-0fa2-29f48d957954@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0409b292-bb89-4193-5d86-08da6e375a7b x-ms-traffictypediagnostic: CO1PR03MB5828:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8BVM5in71gIVGpALa1SJ8YnE4grnzoXABXNP4F0PIOYnupiH+557yjWq8g63kcMF3bUiWPUid1IIJH1vxHRsbnHoPUFc2q+V7Y2T0+fAoV3vnhVZRtk0qynvb0onbeuqyw6D5UJ/SmmHgyBFwRf7gXMtFlk57iYL8p1edsPLAZVgJR9ZT5LBgZwkLfTvcgJVG9OUE7mY7/ZG96g5mZnh1WQIDGcX6WOur7rjQDQBOQd4vCB74hbNVv8We3aLiunjpj606lJ9xp1Gz8Y/WH9TVDWKgdhQhacPNVxgOyy2TfBbXUffTwCvjSgTnsXdX2srftn9sJFU0MdRxV24ZkYNFPEY4NdysaCT9XAoqMd4bly8AS4TqBdkGqiW3Mz73l/T10sYBPZGhP3qvaJ2CAKm8jJk1hlvFgzKr/FxgCJq/VPRSW7t8niYFZ1+45qpTqjGLpbKuFQqllgEIZwtYuc8GApQXhfibuWKDx9W5FvPLgs3Qwhv/knQId3V9ADh7NN+gTEYccslQHstKtyyZsJuYq2qtU4kf487r3IEvj7GedCKp+3uBveeUmAB8Q9HRKmwu0QLHPIPczbBFggUaZpjllOr2Licmzxovt6Q8d9d+8RmVyzG84sozbLQPzSH2oQQ5Kea9CDAxQgDCC5Uxprs/NY5l8fNBhTO0HWga6nGkydQhS/dDo8NfVtMX6Ma7AAvcR09Whsl8ASITSlzc8i40B37j37uam0Z94QVvJRwkWdNJhlLIjq6tGSMGI7qHJeM77+etftqmhNFl8pc+7tV+yRnD8u0QZpGaM7B7jqR4dSpriB3WBjP/XqWVr2GmqTa9bO6UwFmG2mySIc67yfX+R3Vw1PCmGz1+i5eJ5yKD6qlfB0Bg+xYxaF4RtvXrO0U x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(366004)(346002)(136003)(91956017)(122000001)(36756003)(186003)(66476007)(82960400001)(4326008)(38070700005)(8676002)(66946007)(110136005)(64756008)(316002)(31686004)(76116006)(66556008)(38100700002)(31696002)(71200400001)(8936002)(86362001)(2616005)(478600001)(5660300002)(6506007)(53546011)(558084003)(6486002)(83380400001)(41300700001)(6512007)(66446008)(26005)(54906003)(107886003)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Q1dBNXE1OHdqTjJsb0RzTm5Eb1RrSzhhRytnOE9zZlc2RC9udjJ5WUZzUS9H?= =?utf-8?B?WEtTaDZ0RHRWd1lNaGdWbEdqUUdmTy9Ja2FKSldSaENRSm5PRmV2MnVtdzNN?= =?utf-8?B?d0lwTU1ZY0dGeVpRd3FwaWg1aXJQR3lXQzFoYkpDeHZYMHdUYllPUTR5RlVU?= =?utf-8?B?RWRzeFczc1hxOEtjYVBKUFNzSzFXTm43d1hWMXRMd3kyK2huTlR1UTR1VFdF?= =?utf-8?B?anZjdGxUNStEaDdKRjAyVFNEM01UR1U1NE1ITG5Oc091WTd2RnYxWXBXQTB6?= =?utf-8?B?ZTJnMUl3ckFCRFdSNmFUZXlwdkpTTjRsWTVXajExUXQ3RXA2K1B2NVZmY3ow?= =?utf-8?B?dG9lR09peW9xMkt2aEVsZEVrbUxiUHNxc0huWHdQM0pqMHlkaTBzQnQ4T080?= =?utf-8?B?alZiSUFERVdVZXdKVGMvUHBYSTdlaS9BYTl3bUtXZEVLeE5rd0ZsZFdNQW9J?= =?utf-8?B?dWs2bmp5cGJkYUVzZTdEeFJ3RE5iNENyMCt1aHV1WUtXRElMUnZXbVFRT2pD?= =?utf-8?B?M0VxdDlEYlR0U1NnRlVjTXFSN2dTekpoNnJJVkJ4THIxendWc0dSY25KOWtX?= =?utf-8?B?UCtLaE5PR3Jrcm94NDBHRzQ1SE9PSzMxN012cFVBTnQxVGJLR3E0NDZIRXVq?= =?utf-8?B?MDU3djR6NDd1ak5EUDltUnFrSVZaUmRMWUhYd3dtMy9VSTM2RFo4RUJ2aUlN?= =?utf-8?B?U1pkSmFVNS9xdUhFdlZrSHA2dGxneE4rNjBCZmdWbkR6RXJXRXk2L1ZvTkdQ?= =?utf-8?B?bnRlM0FUN0Y4OG13REtHT0lCa3lIUlRoVjhMV3dUNWwxdk1RMTNDbmNITlNG?= =?utf-8?B?MVNvV0xSYVgxMVNWMG9DUHVYZmplRE1GRXFGd0R2c0Y4eWdnVUswUGx2UUFl?= =?utf-8?B?Tm5Vc0lwZndla255UG1USk8zQVhGZUFudHpmdGt6OWFtYXJyVllhbFZrT25O?= =?utf-8?B?bXhRQkkxdnRidXh2eHpraHRPMUE2cVoxcHdRa2VYa0M3L0hrczJNZTl1eXNw?= =?utf-8?B?QlNnQUxRZUp6R3dGamZaZSsvTFIrU0tzV1pZNXRCMkllRW9TaFlaOWVUWFhZ?= =?utf-8?B?SXp3ellwb0FXcklZZmVLejlTMGFsSWwvaTIxd0FzWWEwN0VETGpRcEdZVXVY?= =?utf-8?B?dlJVVVIxM1daRmpLU2RMeGRua2M1bUJSUElua1FoZXd2dGI2ako1S0kwSk9K?= =?utf-8?B?TmlGeGVaNS84dGxqNk8xYVQ0TGZNUkp5QVlPTE12bTg5NHFNUTBNTjdieVhB?= =?utf-8?B?RUN0TFprZXd3Wjd5Z1piVDZZSmlUek1FZ0pySzZMdUZwQU43OW5mTFI2b1pQ?= =?utf-8?B?UVhxV2VidXdEZnBuLzNmOTVTVzFhTUtFSzRsQWpFVjhGY1BuT1pBbk9xT1FM?= =?utf-8?B?T3dPU2wzQ2phSmVQSjgveVJrTlA1VzFSN2NiUmxDL2pLdkNJMzJ2dFdBU1hw?= =?utf-8?B?b0hjVjlnTkU0eEJaVnlJRkw4MWxvQVArTm4wcW1DOU9WcGN2ODZkOEpJQUZ6?= =?utf-8?B?VUl5QmNyUG5xNHVqWVNORlJDUkZpY1NCVHB2a21jN0xBcDZvVjRqS2hpb0Iy?= =?utf-8?B?WDQrN05OaTVCMFIvTTdSUlVPdk9id3NUN3FlU3BWaW5uMmJFSlpvbWp6Qngz?= =?utf-8?B?bVhEeFc1bVZpYlRMUTdnWGZuOHBQdERPaVRHck8yTWhMSXpnRVB3bFROSm1u?= =?utf-8?B?eTAya3dwMUdNbGVIYmptSkVHQ0tNWGhJY01vdkVzMjRuZDQwT0kwNjdCNmli?= =?utf-8?B?UWRNZWFNVS9JZEd6OGxnWEFtcUFuRkRQclI1NHZWbkd5UitzR3loV2tGYSty?= =?utf-8?B?TEluTVJDaHJ5U3AwbzBXR2JqdGVqd25zVFZEMVBwSGI0UkdlUTRyVUFzNEFh?= =?utf-8?B?NnFPWk5Qc2pZQlZkUWh0ZGR1MHp3RUFPYzJ2dDhiWFVyMVZDaVI1bVE2YjlW?= =?utf-8?B?NjdnWUMrSmtOTWpqT3VTUnEvM2VHRmJHMnlsc3pKQmdncHRjUUNRZUNlS3ZO?= =?utf-8?B?TFVxbnRJQXBkVnpSVnlDcUVvMUdTWVN5RjIwMThDVjhHNnFISnJESmVpeFp0?= =?utf-8?B?d3A4eHVXNDhwU2Y2d3hlM2xoTnVxdUp6UFJ5R25TZ2xzWDFiK294YVp0YUxx?= =?utf-8?Q?z8bZLWrt6OIJZq1ebIABacqAW?= Content-Type: text/plain; charset="utf-8" Content-ID: <6AD94FF9B35C0D41924D0876C419AC3B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0409b292-bb89-4193-5d86-08da6e375a7b X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 12:15:24.6481 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: X/pf+trZkEvv7XldcQZ/moHsR8uOjiQJ2GYdEUaOdQhc4OdhKK9/ZX3M6m/0WucSBNLAKiXVwOo/5n9K9aZpDXYbIScgzjiuKxII4aq/3j0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5828 T24gMjUvMDcvMjAyMiAxMzowOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdoZW4gdGhlIG91dGdv aW5nIHZDUFUgaGFkIElCUEIgaXNzdWVkIHVwb24gZW50ZXJpbmcgWGVuIHRoZXJlJ3Mgbm8NCj4g bmVlZCBmb3IgYSAybmQgYmFycmllciBkdXJpbmcgY29udGV4dCBzd2l0Y2guDQo+DQo+IFNpZ25l ZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KVGhhdCdzIGFscmVh ZHkgYWNjb3VudGVkIGZvciBieSBvcHRfaWJwYl9jdHh0X3N3aXRjaCBjb25kaXRpb25hbGx5IGJl aW5nDQpub3Qgc2V0Lg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:25:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:25:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374558.606626 (Exim 4.92) (envelope-from ) id 1oFx8o-00010N-Ft; Mon, 25 Jul 2022 12:24:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374558.606626; Mon, 25 Jul 2022 12:24:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFx8o-00010G-DE; Mon, 25 Jul 2022 12:24:54 +0000 Received: by outflank-mailman (input) for mailman id 374558; Mon, 25 Jul 2022 12:24:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFx8m-00010A-AJ for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:24:52 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c6a5746b-0c14-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 14:24:50 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6a5746b-0c14-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658751890; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=l0PxjRjAX1Ym8OkRbFYxrFXgDofANdGx3w+3OD5XQKE=; b=d+esDhhKIGC3AX8sljjJ+UZPbux6vr6REYwS/h5osnnDvrHDn9uvtC3I rMUSualVGkngkJqDdwyLWBUjuJ5IBt8EMXaC7hwtm87SH6Ks7rZVdq85L U8trX+O9LNbj9qjdnx4zAWhdSfmD4tBxE9O8Eu9pLbcKaoW4h9hwLY4/y 0=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75835577 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:TQMUy6n1kd+IjO/SiFr4BGvo5gyQJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJOX26FPf3fY2byKttwb4+0pkoCvMWEyYBgHgZp+Ck9EyMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466v4GpwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k9Iqkhq91+OVtW5 P5IAzkydC6Kl9+plefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVGPEsXD5Qv2v+lnHDlfxVTqU6PpLpx6G/WpOB0+OewYIGIJ4PVLSlTtmaFm iXWoWf0OQE5FdWy72eH0XO0mMaayEsXX6pNTeblp5aGmma73XcPARcbUV+6p/iRiUOkXd9bb UsO9UIGsqwa5EGtCN7nUHWQomOAvxMac8pdFas98g7l4qje7hudB2MEZiVcc9Fgv8gzLRQ62 1nMk973CDhHtLyOVWnb5rqStSm1OyUeMSkFfyBscOcey4C9+sdp1EuJF4s9Vv7u5jHoJd3u6 zuViBFvvLwrt9Ya1fWQ9G/dvTu8m4ecG2bZ+T7rsnKZAhJRPdD4N9D1tQaAt56sP67CEADf4 SFsd9y2qblXUMrTzHHlrPAlRunB2hqTDNHLbbeD9bEF/i/lxXOsdJs4DNpWdBYwaZZsldMEj SbuVeJtCHx7ZiLCgVdfOd7ZNijT5fGI+S7Zfv7VdMFSRZN6aRWK+ipjDWbJgT29zhhzzvtvY cfCGSpJMZr9If08pAdaus9HieN7rszA7Ti7qW/HI+SPjuPFOS/9pUYtO1qSdOEphJ65TPHu2 48Gb6OilkQAONASlwGNrub/23hWciVgbX03wuQLHtO+zv1OQzt6Vq6Lme16I+SIXc19z4/1w 510YWcAoHKXuJENAVzihqxLAF83YatCkA== IronPort-HdrOrdr: A9a23:lsKUqKvvsfV+/9UvoYfRWAEo7skDdNV00zEX/kB9WHVpmszxra GTddAgpHjJYVcqKRUdcL+7VJVoLUmyyXcx2/h2AV7AZniChILLFvAA0WKK+VSJcEeSygce79 YDT0EXMqyIMbEQt6bHCWeDfeod/A== X-IronPort-AV: E=Sophos;i="5.93,192,1654574400"; d="scan'208";a="75835577" Date: Mon, 25 Jul 2022 13:24:35 +0100 From: Anthony PERARD To: Jan Beulich CC: "xen-devel@lists.xenproject.org" , "Andrew Cooper" , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH] include: correct re-building conditions around hypercall-defs.h Message-ID: References: <15c8b790-f6a6-42e6-d244-8f7d83c880b2@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <15c8b790-f6a6-42e6-d244-8f7d83c880b2@suse.com> On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote: > For a .cmd file to be picked up, the respective target needs to be > listed in $(targets). This wasn't the case for hypercall-defs.i, leading > to permanent re-building even on an entirely unchanged tree (because of > the command apparently having changed). > > Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") > Signed-off-by: Jan Beulich > > --- a/xen/include/Makefile > +++ b/xen/include/Makefile > @@ -114,7 +114,7 @@ all: $(obj)/xen/hypercall-defs.h > $(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(srctree)/scripts/gen_hypercall.awk FORCE > $(call if_changed,genhyp) > > -targets += xen/hypercall-defs.h > +targets += hypercall-defs.i xen/hypercall-defs.h Do you want to remove "hypercall-defs.i" from $(clean-files) at the same time? In any case, Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:27:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:27:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374563.606638 (Exim 4.92) (envelope-from ) id 1oFxBW-0001iW-Su; Mon, 25 Jul 2022 12:27:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374563.606638; Mon, 25 Jul 2022 12:27:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxBW-0001iP-Pt; Mon, 25 Jul 2022 12:27:42 +0000 Received: by outflank-mailman (input) for mailman id 374563; Mon, 25 Jul 2022 12:27:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxBV-0001iJ-SO for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:27:41 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2067.outbound.protection.outlook.com [40.107.20.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2cac8cec-0c15-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 14:27:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3440.eurprd04.prod.outlook.com (2603:10a6:803:6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Mon, 25 Jul 2022 12:27:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 12:27:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2cac8cec-0c15-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NJ9PwsNLb9gvhZHujDMvCsjIPZhHW6Yg+EexJlS4GOBvJgpzo/PkADswNlYKnzN+viB5EPXFmPoqVj67HXhe5HEzBsavbIH5wIOlwJDq2nbVetmpcaErvpft+BNWXgli/2VPM3K1Hm14kqkUsCi7t8c8+aP2CgOTp+BDMVm2Su61czat3CJqbQZV4Nuhgsj8vzXsdxrbeJVdOc4EmDD2iqJxmKUN+EWmwdJ81MOsBT/G1YLyOGNfnpHPTsVqxeqBQEk2ajRql+ulFqjM1ujGbtUWE4KuhB+mvLNP0fMTf3UnquPMLbJdIaRm3HCcEKnlVu6w0DKNTxiSnUuPMzdjtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RbUmj3ceKPymepo19iMVy/3v7AEDccGvYecKu3QwyVM=; b=oDjMnDaf1Y8FM72t6eUM44n1gdQqeXxz7HIHCE3JrJgVUorEfXDhuoWY4nPwIlMD0cWHY9uWJfbZPUxrUzIxVq8RxJH7cOnemAdofZmPf2/tvcbVJrFwOXRn6GpfIvavBMMNSvBWgg07c8SN9E5ZSTyQrDZ8nW6KVUMZSJILlmJfOkNEtZWx0W5R/H2JdXtEMX+ocp0kgYCo6qPVbVXpClWoz9H6+lrAdKB04xKKsw5DicCglgV0DpiO/Jix8sxSA6vZuokfyzFTlJ7juU5VXSA5/+MoioyZn5iIrASFQYwu04aOVmCnaJMrK02GRQ1St4xK+rgMJN16ktPCx167WQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RbUmj3ceKPymepo19iMVy/3v7AEDccGvYecKu3QwyVM=; b=iGK43dIsBpoCOmxItcQPewLni1hfnrad8yme9j10j9AnZsY2mnxxc3k7cijKz9sAdyruYPlj+4PzDHq3bhg1f3qTc+duPbuirVA+zoz1VrmOgdlPuPDkG2JlfQMWelQKwwsK3kh90mwWrbQtzy5+WPQyTY2xrW2K2+CXMe5M72kIRWcpUErGEz9oszRW0R7nBnFSh1hxwawnLhgZ8LhmcoQMBXrNN74ju/5USKwLLYpmjVHq68HuGZNf17AI1qVL8Ho3Svfgf1nWIEBWXcYCsIQgK/cIvMXNWWynDkcKVxw588jWGhd3SGyQSUfoLWZnrLazqUmHqJvh0E+1HwJakQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <242213b8-694f-524d-7c1e-a333c352c985@suse.com> Date: Mon, 25 Jul 2022 14:27:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: limit issuing of IBPB during context switch Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , "xen-devel@lists.xenproject.org" References: <3327586c-1489-4af9-0fa2-29f48d957954@suse.com> <8b347c26-d1c3-b3c7-8e78-2e43b274255a@citrix.com> From: Jan Beulich In-Reply-To: <8b347c26-d1c3-b3c7-8e78-2e43b274255a@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0098.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f1509538-f1ee-4f1c-aeff-08da6e390f6b X-MS-TrafficTypeDiagnostic: VI1PR0402MB3440:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: otag0myZ6MbblVhx4CW5LfsR01voc6s3+K3Zl26hzrz3LCCU61eT/RMwOrnybeUDNVh2DLA3Og+rbq2eIOunlJxU08LZfDTpOFTVrRGFV7fE571AZw40bbNrPk0eBnYaYvMtHuQffnxk3VY7Qqt2x6DHyMH8otlNLT5SDWQWDavHEc1llb2dALZHYkv6R/55tKfq1T4tciBr6jwcP8SsTIIF2+2KLtGVzSYBF78FwV3md1vcyPnSHEP/XZSpzv5Yw+kaI9QGqub/K6+KeY2TMCjIhMRwuHX4lDc+Hwbl1WReKaJqVYcI+2YQgtcQx7kF6EiprSNry+E3nWZvRcH/c15aMuCe651qKu5IPJJkFkWTvnd9Y5wo4nfYoilM8lcVFHIF7NDwtpiM3zI4O4bRhWBQqBMsBuZOlUkvR8rCGdk00Y2TBKxIOsxbiP+fLLUT8ZzwDIRKi0tjDb/EYLZktzsn65oe8jb0kO1DVKVNjQGb0nqPhkVRXX58I85cHogO5/zTSxWY9TyxqDMgDLg7jF/rMt6y5qT1q5gfjHoAJ0LjVvYeZfDsyNtAmyXLzmhy8aZGQ2g5/NgkDJyzeilYOdjOyOOe3sE1+eul6qR7iKqkr3IqR2QH+NAYe2SbjAhlf6N2OlbrpeKjri3iDtn2OQerFZdwJRHAtKSgDDskNqM79OQF0u0aQVaEAVLN3Um2s00Kl38FiAQ7Y6CX0y2F2lGdkTl3xYaitKLWW3Wz5kEYeBYIoUMHgTYZg+85dxIUc4FAfsJY78TwYR54gJqXyQuqPwLwWobcHgZKhNfbCmJlrIRFixUGJf0PqzywbbQXeFumNLjcNNK5RTUcPX/ehw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(39860400002)(136003)(346002)(31696002)(6486002)(8936002)(36756003)(53546011)(6506007)(2906002)(478600001)(6512007)(26005)(86362001)(4744005)(41300700001)(5660300002)(186003)(83380400001)(2616005)(66556008)(8676002)(4326008)(6916009)(66476007)(66946007)(54906003)(31686004)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c0ljd29TZ2kzS0tHVnJpYXZyem56am5BVUZZZFJsNTlaYStmY2g2cVUyaUR2?= =?utf-8?B?bDlPNHZTdDN5SlpQWnVEOVUyMEpETXc4UTZyY2FkZVVOT21PendSVnhOdVd1?= =?utf-8?B?Z1FFZFBxeGlEcGRXRzZUVENGbjlvUFRldTlKcEpyaXVxdFlZVnhFQVNtMU1B?= =?utf-8?B?THZsMStmS3dSNjJoRTN4YnZtMnM4ejl4cFo5NHRIbUlxVGxJaXJGL3d4clBv?= =?utf-8?B?YytsVVBtbzUwbkpBM1hMZWRBSFhLeHdCYUMzalJ5aWJlSXdjMG4xc04wUVd4?= =?utf-8?B?MlBYUEE4OFAxS3p1d3cvVGVIYk9TQ092cVhoZzlGaUJQUVF6TDVkZmMwVWtN?= =?utf-8?B?UlVLTTVnTHNRdURoY0hNQXFnL1NrVlFhTWNmYUpyWmt2MWgzRWt1RGhwUUJR?= =?utf-8?B?ZnFIajhCLzNIUEZqbW4xeVY0NkxzeUJXampHNnZkTG43ZlFoQWpMZjJNNkRy?= =?utf-8?B?aDVYejBaMEZMUWdjbUhSYXVkemxxUUtxZ3pvaEdRZXRpbmpuQy9qV05sVzRV?= =?utf-8?B?Ym5wUGd1UHkvZkR4dGo3T093OGFkVTYzcFF2eEFwRVBRUXF4WisvK05Qd0RF?= =?utf-8?B?K3h2cFBwa2R4WXBYbFNLLzU5c2hSR2U0UVFlZG4rdi9BUVoxajdmWjJhZVhG?= =?utf-8?B?c0hhNzUvN25UNUYvWmFzQUliWlEwdHoxWWRxeGRxcXE1cmJHOEJQR01SRCtm?= =?utf-8?B?bDdNVm90VzhUek9HUGYxL3NCWjJpdEJjVkxVaXA0SmtWNWhLWHVpSjNlSGVt?= =?utf-8?B?MHFLd3c2b1VKWHNGMjdhb0RoWlVod2pCc2Fxc01OZHNDdUpkRGVJUmZnVEUx?= =?utf-8?B?cTBjeG1XZ3Z0TE1DRGFIdUw2emk0NXIrL0h0dmgzY3BXNkEwWjJhOHVjUWxv?= =?utf-8?B?ZzhOTnEyS1BxNE5GZWZoTHRLY0NIakxVZFpReVlDTkxvZzlPeUtSbjEyWnNt?= =?utf-8?B?eWNjT1VUalkwVWkwR0l6WDBORDB3V3hSZG5QMEs2VHlWLzU5WElDSzllMzBZ?= =?utf-8?B?ZzJVNlVQTy9VVHZFSGVhdFlNMno1SkdZb0dzNUFyN0N5QzJjdGQ3ZnRaM1Fi?= =?utf-8?B?eGpWdk1RR0RQWE80OHByMU5DQWYxbHRCT0pqWUwzZHlHaGlvNnlWQk1IWXJn?= =?utf-8?B?eFFhV3VVdXlmaTNoOGlleVRJa3AwWDJPbk54K0lZL1FkakdQL1RGVDFHMlFa?= =?utf-8?B?c0tnRHJRME1sRkhBS1YyYkJ0Q3lzcjc2aFFZYVVwNWYrUkN4QUkzMkRGaU5N?= =?utf-8?B?Qm5RdDdMckk3c2xSVElMMGhxQllkRDA1Y3VXcGVkMU02RnA0eUMyUHl0bHQ2?= =?utf-8?B?SWZMeFZ0OFRDNDA2ampGRy8rdDNOaE1FL3ljb04wcm5EUVRvK3JxdFN4emNL?= =?utf-8?B?elJiOXloakFVdkNSUFJlQklCZkFBOHNWdWx1c1FCWXpCNEU2VnllM3VtVEw3?= =?utf-8?B?SkNHdEZtV3VzOEJ5QmtkOU1SY1VCUWxsNzZobFZaWlBtQ3lwWXZMVGIvek1W?= =?utf-8?B?OHJHWWJTTWZXNk42bzVnSEllQytpMXpUeU5JeUxLVVhKQjlxTnVOaklZT1hw?= =?utf-8?B?SnZyYkpJbGtqdEx3cVdKTmVuVTcvZVJLeDY4R2Rhd0dvSEplUmNVMUJzQ3Nz?= =?utf-8?B?a1M3TXpQSDRsS1ArTnZldnRqTUtWMjRVOTFvT01najk0Q2FoNm95UGxSUURu?= =?utf-8?B?U0tHREF4emV0NFhnY28wVWh1Uzhtdmd4OXNiYWdIUUFKcUdqcnYzUlBqNVM5?= =?utf-8?B?dXo0cHJ1Z0dGc2NRS29Oa2pKa25TT2FGbXZjd05CdmExYWNLNE5BM210dHF5?= =?utf-8?B?eXNiS2NmVklIb1NzYVUyK1pwNjExUnRPUXNSZkRHdnBGZ2dtaVh5Y1dmNlZX?= =?utf-8?B?c2lLQzlRRDlwbXVpLzdRV2JXbVM0WG9INGpyZ3lacUYrV2ZXMVlzNDRtYlRp?= =?utf-8?B?Sm1JVzJNZExyVCthdWZuL2t2Q095T2V0eDM3M1pnY0VKWU8xWXVPa1N1R29p?= =?utf-8?B?aUYycHFmR1puQzBKZlhQZDJDeTBDM1NiUCtMOWVLZDFTWDIvT2kzcW03bWd3?= =?utf-8?B?S1RhTXRCSjAzL3NNKzIzTmkrOUd2SjV4dVZ6QU9oWU9aYU9NRUZZTU9NOW1C?= =?utf-8?Q?ErNeJaEdYKV1FjDXbszW+XtXI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f1509538-f1ee-4f1c-aeff-08da6e390f6b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 12:27:37.8971 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sjx5UOxhfYvZYMeecqqN6wkZVB+0tW4hGMHxLmLHu0DYndcp3TIcEpi8MfG43uLfVflS4bH1F0yRvtALQG8UPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3440 On 25.07.2022 14:15, Andrew Cooper wrote: > On 25/07/2022 13:09, Jan Beulich wrote: >> When the outgoing vCPU had IBPB issued upon entering Xen there's no >> need for a 2nd barrier during context switch. >> >> Signed-off-by: Jan Beulich > > That's already accounted for by opt_ibpb_ctxt_switch conditionally being > not set. That option defaults to false only if both PV and HVM have the entry barrier turned on. In fact, if it wasn't for Dom0 I was first thinking the global could go away and only the per-domain setting could be inspected here. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 12:29:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 12:29:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374569.606649 (Exim 4.92) (envelope-from ) id 1oFxDV-0002Ix-9P; Mon, 25 Jul 2022 12:29:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374569.606649; Mon, 25 Jul 2022 12:29:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxDV-0002Iq-5n; Mon, 25 Jul 2022 12:29:45 +0000 Received: by outflank-mailman (input) for mailman id 374569; Mon, 25 Jul 2022 12:29:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxDU-0002Ik-3F for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 12:29:44 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70040.outbound.protection.outlook.com [40.107.7.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 75d3dea7-0c15-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 14:29:43 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB3440.eurprd04.prod.outlook.com (2603:10a6:803:6::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Mon, 25 Jul 2022 12:29:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 12:29:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75d3dea7-0c15-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBY9k0eLvaX030arjIqz5QhpeXF5+q1k48hwR8zpADFTybxpEjaIedlL98ZE/6LsnufrZzY1+mZIVpa+MpT5b10WYCB7Tfo91jhmR2rQXGsI8HJjbKn3FFy31gBW5oEJmNmkK3FSjwDaERMR9xfo9l3a4/FIMRFVLvNGXAd8479AFR/PG1XSJgNf8Go88VMfCXmbwOtNYOiK36e4jf7Azlje/l3YITW/H+CMVJGUhiMPpvpJkuhgBAykSHG2QTpw6UyrECa1ch7MaFXoXVWLZBvhBTWhsOzqKD/5QXMFiUCe7MhSQE2EZMUlNVbit9IOjytTojXl08soJanpWTmMTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fRqYbcHK+4yb1FARcdcQ9AdkIFK+6TUR+T8EfUhaX64=; b=WLPKKvCR9WMO2SDOj/HFf6v5CK2qfo9pFMcjWtQB1RJgpfAok7B7Yi5agTOiymx+IGrsW9qNgcBPmIUFlbcualbV0Q5NxzMWBN4XXM3MrQHa996bjds3bSQTYSBCQUrA63jtoIB6UzmQdUgR12Pm496o3stfNH6dVaPDa1C1x9Ap9CqnhmgoZmSl1rxpoQTtb4ajWfhz6dTi4w3VncVEKXnaL/Fo6hVxeyx1ROQ0TwtV1NHBBncPyTBQQsXbrrxnrlnx6TQqQp4by2Mk5nyZuZc3TN6O3BZr85AVA/xGIghtSJLJUz0vdUUqemmGbHsrdPO8GPqlkPZDvJXeieSUew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fRqYbcHK+4yb1FARcdcQ9AdkIFK+6TUR+T8EfUhaX64=; b=Xqve01ai28xTdk6Gi4rO0vRYqpZk/0uP3JMt80Up6L54+eYM0LPo0DrW9Q5h/qGwjc6esFjB9O32Eufz1hDGmGb7Luaot1XZmnePJ0mg+5eSn/e2DYKU7ibEzKZYfUvM1qzJ+9C3vycF7fWqM6loBZDi4Uog/+mnXAMCRzlw5f6BIIykXujCGa/WsqXQcKhK3dEYkWxPEALAmS21hoUcFM3Q+VI6L31xvdw1THNXa5jBlrWTuSPg23vxs535O+B2ds5YwCb+Yt2Y24KAtt1LV4sSwy2q+19+oKG/oPEKthfEAYcyabBtctLaDwuJoECCxBEaHlphylWnT3uen2wXOw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <36ee5129-18e4-1fd3-c3bc-55894696de96@suse.com> Date: Mon, 25 Jul 2022 14:29:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] include: correct re-building conditions around hypercall-defs.h Content-Language: en-US To: Anthony PERARD Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <15c8b790-f6a6-42e6-d244-8f7d83c880b2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0006.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5165a66-27b8-442e-b026-08da6e395923 X-MS-TrafficTypeDiagnostic: VI1PR0402MB3440:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Wcb4axAAIgM82EujqIPJ0ZoosCANGzn1cVXiJIyuuf+yYwCx8Ko2zgFUzSaBYF1L4759SXvLsqNYTQkwVPSmYpvY64/CqriXncYGPrq7xtFZ+udzFhLkt5utOBU87YOoLtibaG/bDLOdUdUeuJKR3iEMrmVhwKNiLuB9mY+B74+349Csmk+qJM3DPTYllyzeeW9UCB91c7cb+/ntwCpmiqw3rRbKc64Ta5PLoJ+kauCamnKvQIrFjSg6h0siWRpri26uVt2x40dVBccY8lJRPiakRKDiXLDhJCXTVHyFQCEmV6SIg+J6scBoGNAXjezkbfACpnMiYnYGE9MGiVxUFkB/mo4u4Uibzz0+hIhq0vq2LmG4JzHKkT/dfLoJ99Hy1K7JdIriH3zZ7eqxKeXe2lAYp7z0xebNfiuLcBoIhyaq1WNlM/WMc4Wo6DVhm/rwwYYYrxzh66rVVz+HIeNnSL+H+I/oHJTo3GN0TXQ1F/eF886/Zm6EDxlIYRscJ2mK4cbflZoYn6rcBKyIWOk9EvDYeyBYKWwWhbXx3xrggVKC5DROW0mVZCiylHK5RNv4cPfKffyQbkF9MIn49r5YjMN0RVGHoxE/FrocZiVbfk64JFccIwrT5Qa/KZJluw3As2Q1z0aSR+FhNAUNmeTOxU9PcDi+XZZ1b9h9wOChPXEbd88dxTWMX1v/lhmCFH+r2bpPo4rtGAi3bYXHtfmdRo57v6MUL1wCWbyU6JN4iP0MtGXn79L/L0lzerbJlSifXR9MH808wbTb/SpiAzSx/3rOpa8eXWU6OeIjg1iPQk7OJ56k8BKGl7tWruu2dadYVjoYfWcCYGtNff4tufzBeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(39860400002)(136003)(346002)(31696002)(6486002)(8936002)(36756003)(53546011)(6506007)(2906002)(478600001)(6512007)(26005)(86362001)(41300700001)(5660300002)(186003)(2616005)(66556008)(8676002)(4326008)(6916009)(66476007)(66946007)(54906003)(31686004)(316002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXBwUll3SVZuMUFWK1dFVTF2VkVJaWx5MmVOYmdSaXg5Q2xqUFREV3NoY3pl?= =?utf-8?B?ZTU5MHJMRkVvamp3RkZuSGZpQUpnQmkxMlhCYzk2YzduUUhEbmpuUmlLZ25u?= =?utf-8?B?TUk2QTRla04rOFNJRElpemdXMXkyRUVhYXFVYjR1V1FIVjdCQ0JscURNUkZx?= =?utf-8?B?OXdkSE9tOFJ0SXZqK2Q4Y0JJamYxdGxobXlVTmh6RDBxYkhIbm0waVNCa3o5?= =?utf-8?B?TUMzZFUxbU1pZWhzZjBRTllNalhpb3dmYStJcFh6NTFLdGthc3FqOWJaZktv?= =?utf-8?B?Y3haR1FOa1BOTkE3UmJNdHJRN1pYNUZUTjg2d0ozaFZBbmxHdGVweS9nbk9D?= =?utf-8?B?bGg2YWVab0NtK3VDOW13UEk1YmhpdUMvanFDcUNIb1VIeVYxYzU5TUttRjJQ?= =?utf-8?B?cVlyTTJZenZBN3U4Q0pEZmZnZ2wvc2NjTzBORjhIaXI2RkZyUnFoQzBNSmw4?= =?utf-8?B?Y2JyeGlUSnB5b0kvSkxnbEd0VVpCSWIwOFBiLy9PMzcrM243dC82WTRNZTdR?= =?utf-8?B?ejM1Yk0zejNBL0lWMi9ZREgwS0wyTmhXR1lTYjBtenJoRE1wUHJpYU9DRVpN?= =?utf-8?B?c2liYmJKd0ZnVlhsU0JqdE9oSHdQN21rbGFiNFJZYUdNdjNxZUNuUjVQclA3?= =?utf-8?B?K3pDcFdyOS8vOUtQSDdYZ2FseHErOTZSTHBYaU1naWJJdzRQZWNDOXlrZVZK?= =?utf-8?B?YjJvUzFHNU5kMTd5dzY5MTFyekVocW1TVUdRUjJKckVlMVJvVW9kUWtWVlpr?= =?utf-8?B?Njl3dmJHYVpVYkNubXMzS0RHSkJCVGdXV3lqTjNENkpJSm5CUGVPajF5bUtJ?= =?utf-8?B?Z0UrVlp4WFFpeTVaWUVaN3FDMzFSdzZKajl0b1hZbk8xVy9SRVUzR2liUXBQ?= =?utf-8?B?MnU3NzhNVVhHMFZ2OXFtQ1RiRXV0amxMTWhVQjFQRSsycVZOR2JJME9UZTZh?= =?utf-8?B?aC95NUVGb25JN0g2ZTlqUm1rbUZ2N0F1SmlHdlRCNmRuY01sYjhLdWN0SE1Q?= =?utf-8?B?ZTBqNWhLcG51eEp2c1RwQm82SktTOTFTM0VCalYwcUxxOUw5a2NUQTBOOGRG?= =?utf-8?B?cUdsYi8rY3QwbDdVSlBrREVLR0hNdm1HL3UvLzh2eC83RVhyNSt4ejRVanIx?= =?utf-8?B?dUk3bzNiSXlsdnY4MUl4dGxHd3hQN21HdlZkVEViSjBKOFhDM1RQUlZXMjlm?= =?utf-8?B?SzRRRm1Md0xrbXBOTE0zZU16RE9naG1wbmhMK1cyNGRzOXRWNDNsQnNuQWE1?= =?utf-8?B?cDBYUzIrRUZDNmZrQW1GL1NxeDVKbkpNd0RYQklLNzQzQ2VsTk1ONDVDNjQ4?= =?utf-8?B?WnhpYTIvZFV3NWk0UUtZZTM4RThDN3BVYWhibEpiL1ZXTEc3NjM4Ukk2bFhR?= =?utf-8?B?SFBza0hxdU4yTktHOENvcW12djNpWmdQeG9Ec2VtS1l6b0lwZ1QvRTVVOVVV?= =?utf-8?B?bU5QVTNSdUxtckhxYnVQQllBdElHVWlOMlpndkpIc2hNVmlTWXlmd3doSGJN?= =?utf-8?B?RXlTelZ1WXplc21BSVJBU1VlT1J3UFovWmRMWTdqUDdKT1FGcGFPTHdSemVw?= =?utf-8?B?V3Bqc0lHY0dPc1diWVRBUmpXZlhtVTJIQ1VPQ0J3Rll0WWJMUnBGUmZja0JT?= =?utf-8?B?emw0T2JBc0lRSUVrREtZYVNHRVlJeit5SWJhaFMyT1BSdXZ5SXBCaTNZamp1?= =?utf-8?B?aDl3RXAzbWZLUVl4MmQvT2dSYjFxcHYrWm1KYldyb3FZclVZSW1DWHRKdGkw?= =?utf-8?B?NFlrQkx4c0l1MCs4eW5VbUN3cUxVd2w2NThTY09PbjZZT0JnVXd6NEtoYTVa?= =?utf-8?B?SjBhWGtnUndid1J2MGp6M2lNK2pxN2ZrY2Z3WkQyVkhtbm9GSTZWM0FFNkpV?= =?utf-8?B?Y2NmUmFMWVJvZENKNUVBRitMa1RIK25iUEJaWUFibTFYSWNpUVZIVEhxYnQv?= =?utf-8?B?Y280UXJQVHl5VWdnUUJTelVpd0tqU28rNkNTOFhNeDc5WlBYNmdDYmlzRGYz?= =?utf-8?B?clZZeE9pemJxWFRBcWJHZlhObnIvYjY3am5GS0ozV0RmWjlkbEU3ajcyRW4w?= =?utf-8?B?RGdWWlVMT1hmeVp1bC8yNDJub1BmSlFSMmhIeWdZSmRQRWp5dEZkVy90TEN1?= =?utf-8?Q?PsXjIDDajR9VZaDqlz7N1YL4y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5165a66-27b8-442e-b026-08da6e395923 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 12:29:41.5298 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ycVbTqODNTQrIXZqkeXnhkTO1W+axGKs4LZ2hIN4eAErDgoxiTxOZhPwx0w7szC7vxKJcWVHerEox14D0U6t0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3440 On 25.07.2022 14:24, Anthony PERARD wrote: > On Mon, Jul 25, 2022 at 02:08:04PM +0200, Jan Beulich wrote: >> For a .cmd file to be picked up, the respective target needs to be >> listed in $(targets). This wasn't the case for hypercall-defs.i, leading >> to permanent re-building even on an entirely unchanged tree (because of >> the command apparently having changed). >> >> Fixes: eca1f00d0227 ("xen: generate hypercall interface related code") >> Signed-off-by: Jan Beulich >> >> --- a/xen/include/Makefile >> +++ b/xen/include/Makefile >> @@ -114,7 +114,7 @@ all: $(obj)/xen/hypercall-defs.h >> $(obj)/xen/hypercall-defs.h: $(obj)/hypercall-defs.i $(srctree)/scripts/gen_hypercall.awk FORCE >> $(call if_changed,genhyp) >> >> -targets += xen/hypercall-defs.h >> +targets += hypercall-defs.i xen/hypercall-defs.h > > Do you want to remove "hypercall-defs.i" from $(clean-files) at the same > time? Oh, right - I certainly should. > In any case, > Reviewed-by: Anthony PERARD Thanks. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 13:11:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 13:11:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374593.606660 (Exim 4.92) (envelope-from ) id 1oFxrF-0007iR-E8; Mon, 25 Jul 2022 13:10:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374593.606660; Mon, 25 Jul 2022 13:10:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxrF-0007iK-B4; Mon, 25 Jul 2022 13:10:49 +0000 Received: by outflank-mailman (input) for mailman id 374593; Mon, 25 Jul 2022 13:10:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFxrD-0007iD-QS for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 13:10:47 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31f30ef8-0c1b-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 15:10:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB3115.eurprd04.prod.outlook.com (2603:10a6:7:1a::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 13:10:44 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 13:10:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31f30ef8-0c1b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g7hV+7GWpfMnXoUgxk1J3AG6bf0RGtNWCsOe4mDbP1AFiXPPAIfUsatCM3Ju9PCJ6kCxwI1j0ZPjD9qmItBbtfoHh3DNWmISNW2bn+CVh/3ikUaNP96QpJS1LK/hhz4zcgkWpZPkXVaXxC5S6i9ZeMTinA8DHJFadvZCYmirhrWhcaPkXu//xtF/f0z7pX2rN7cb/2HTN9Xyyr4lS0hXz/66q0Yu6Rsr53OXrfT7R2bDka6c4M8BaYEMp4hFHy4tl7JEslemlbXkmK2cLjONLmYV2Kp0cu5tc9w1Lg60Y6j6EQCDSw/pTrd33vs7WG0vIYqeYnSNiPAOYPK/HiCbfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2Y9bbWTZkIjkIehIg0UtM+rMqcF9EceSJLRI57FqFxE=; b=TATjkFkkXOJB2TgbHallS+C6lTCuqdTRum9jU0QhQklZIHZ3v2w5nfO3V+vV/HjDRpEbg7gb5tYHssqupeIkX29R5Ju8lUZntIslw5yNfWVenudXFMP/5iLpDphoeZFxV7xKmmT9oesfGWOll/bht+Oi2bHRoJbzuCORjv6mMdFYZznbUTISn5EYWJ1ZoIFiRbKmChwFWSVRlkJ5hNS6qgScGQc+FWCFEmLfDYMGDjIqsqJG0LL4+ffDTL3wHMaYTKUu86TvYCJnZQNF5jbOC8l1bdFjrBgND0EkVtaiYLeNBoa93lYvg2ikIlnclij47WODzvA3t221kIUh8hJOVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2Y9bbWTZkIjkIehIg0UtM+rMqcF9EceSJLRI57FqFxE=; b=rKGazL1OEET0smcw4rmwi/bogfT6QQiS2R784G0UXD99/U7/02Ym/kGsM9xjmGxIMdpEHU1U+c5tiOFIf973MUA4lpJDIYsSkubhIZ267vzwn8QBxiTz/hV9Dn4UWQL4VZQcnSub4MIE927p+gIgqLhA8PRwgFj9uJ9YHGoNJIRv1ET/fnulwVeZMQjZ3B7kapx/Q5tCH6QNMaw1VAy0dU09hC6KwdOXKHaTZn3PgS/CKsDyg+2INtvALwnkOn0QMYoas8zdaKldxa8E9zeyMIkrxNc7jTyHsFNCWUllJ5AOOtBktU6lPrN59SQkZmE023jf2U+f6ElSxj2IqH9Ccw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> Date: Mon, 25 Jul 2022 15:10:42 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "Xia, Hongyan" From: Jan Beulich Subject: [PATCH] page-alloc: fix initialization of cross-node regions Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6PR01CA0069.eurprd01.prod.exchangelabs.com (2603:10a6:20b:e0::46) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dbcaea2a-65cb-4853-ee23-08da6e3f1541 X-MS-TrafficTypeDiagnostic: HE1PR04MB3115:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M2gCZ2IR9ZSLWvPVOs9PHXl+Si4IwfVPaIU+2AaPLMotonQrW37VVyr2+zQF8lxtYsOtezlwDAxOAikmtryPUNyvpV29Kd0iCbAPU/nVHDqm/mu1tNXX8RPNQlVjihSHjR4mmV/1QToiOYrVvFGQiAUcxAidouMFvETGgGWfjPfTzXjSjV3OXvzfuARgh98FKw9ii0lxvfVnBKy2F0jjwrTnBAxxEyA2E/cAlTlVMouy8A6FW3lzU5/+Q5+tt8wnLsdcB/sCTB+dGoGMH3qwMW5ylfXz7PesVV7sBvwOM+JBiIajgw+dGUnzql6GmOmaPusEjOPOz6s9NWt4yvHsGppyLXwTlEJbDeTwwtXjYm16V+nHjR3TG+kdBjKNwBoJoWQ0z/Z7IFz6Srdhspy5VA4AAGY+iBTKZpJ7AUFSzcWzRlXRZ4ArnB5UGd596FcXr/qYgmGMBxA1dJipNCcPWqtluYvkBR+fqxiifqx8ZWpAXUIhjfoDCjWzqLBV9o+6NQwoMjcfQosqbKPk8yiX4nmKtj1KuPrwcW+m1QXn5wlBbzUZBRaQnNCGQulknl+TJ2TwA6s8vUNNgnMCPfSD+TWZ9r6PIBoSc+zR0bW+IKuMlWNEjF6yAL09/CselCcscu+z91UKzAJRqzBwOh6w8l/H9+Pe4wpbRM8lUH1QfofyWm7PW1T/6oXAaY3qvYVAmlaDUwzMMQujxxSS1ZdHLp+9FeYINtwlOER5ZpfjsEoSLTVewg1Yz31mB2NjAVOJG5AHfs33ShR1WIMMyMmOI+2gD9zJTeB3EY7cqt+dXoJiLZNwj9s8MKZzHtPfvQ+5wzLdQnrt6Pi6TyeywclGYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(396003)(376002)(39860400002)(136003)(31696002)(86362001)(41300700001)(2906002)(26005)(6512007)(6506007)(6486002)(4744005)(5660300002)(478600001)(8936002)(83380400001)(2616005)(186003)(38100700002)(6916009)(8676002)(4326008)(66476007)(54906003)(316002)(31686004)(36756003)(66556008)(66946007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVN2RHdGaWxZVTZ1bDBIVjUrMUloWjU0Vk5RcUxsUE1rUTM1WHZmd2pseEhi?= =?utf-8?B?ZDd6TldSTkkzM0E3ZXE1QUh0Qmh1V052S3Y2ZGE2a0p4d0I2TnpwQlUvbkRl?= =?utf-8?B?WWtDdXU3TmlnMXUySHduR0VZa1lBbnhZM3lyY2lERWdIZFdTUkNibGdqTWZK?= =?utf-8?B?eDl3eW5jeUs0eEJSaTJPdnlmMitvdGRDeTUzc2hsOXM4MmY4azVjaWdZSVdi?= =?utf-8?B?THk1WDg4WHVzdm5UTlAyR2k4ekVwaWpFWktjL25mV3F2YzdIZUphNFh3STJQ?= =?utf-8?B?WW9rc09mZDNJZmdFK0pkcTVkZktqK2Fpb0VVQkMvU1F1cUgzcGlScDM2bkE3?= =?utf-8?B?Sm9Dc3BQVVNCTnJuT0syY05uL0VDdWZIVGxvL3JtckNmZU91Z3FmSStiL25s?= =?utf-8?B?ajZEZk9ONldodGM2RktBT1dKMERwVTdqQzRYdytWVERmM1F5M3YybGZ3M1NM?= =?utf-8?B?M1dzMFd4enAxYnRDY2FPbXlIMjk4cVEzOTF1NG9UZS9DclIvTFZPZUZ0SzRN?= =?utf-8?B?WlNoWFBBbERYazA4SERrczlneWo2VUN4aTBkUUNpV0RVdEZvK1lkV1lKSmJm?= =?utf-8?B?OGN0MEVORXc5dDNZRXErYWZaakgxRUw5cEVsVTFDV1NibitWRTN4MkFuVVg2?= =?utf-8?B?QUgxWnBmT2RMYU8xZHlsc1VmRTJxN2IyWDVKTkFCOHkyUUgvTDNDVGlXaUtG?= =?utf-8?B?b1duRXZGZ3lOTHVrWjhRL01kaDNyWmRJQ1NBeUUyQ096YnFDSzlDZk51UDhl?= =?utf-8?B?ZWcvYkxnTjY3TDc2ZUtVbnJxT1NtdHZ0WExzVFdhcjBIL2ZqdmN4L0FqQVlW?= =?utf-8?B?WE5COGVtV1QwME1qQTJsSFBkMzVhZHpoNlhWWndGTjl1dDdkM0VBY1dwZndU?= =?utf-8?B?Q00yaldRNEZoUVI4UURMcVN0NUQvRXpjQkVnV2FLc3lVbWd5OUtTeWlZTXlz?= =?utf-8?B?MHBSaTBYb29lNmgwanBYWk1pN2gzS05LZkdGT09jSE1CODVsdEp5M0d2bW80?= =?utf-8?B?aUV2NGcrWnBVeWdQQnlYYW5tem56TEFxNCthMTN5UXN0Y29oQWMvb1RScUtX?= =?utf-8?B?K3h2L2xXbXpWeXZZSU9UL1BSZEZaMHh0TzJ5SjVoYWp6c3I1TEMxNjhIY29T?= =?utf-8?B?dEEram92dy92Qmw1S0ZkT3hKWWtWTjJvRmgvWDNrcmhuTTYxZit6S0NqSXhq?= =?utf-8?B?Z1VMRUE2UzNuNWMzcm1kaEd6UUJKQTh4L0UxckkwazFKRkM0TUxKZU9FWUEr?= =?utf-8?B?cGQzY2hTK2xaYWtTY2phUEl6eEhxWW9oNnFzQndDQmtoNzZNa2xkaWpub0No?= =?utf-8?B?U3YvZlcxSU9uZWhGYzlDSlk4bmJZRGk2NXA2WGt3TUdjbm5UbUhOZEs0TnNE?= =?utf-8?B?cXVRckd0YnRIT25UbXRRT1JRRENDSWVYS1dwMEljaFpjMTNld1hvMGRhV2F6?= =?utf-8?B?MmFnNEhvU3MzRExVS2dRWjhhbWtxR2lhNUJCUUE2dHFKYkJENDMwV1l3V3Ry?= =?utf-8?B?cCt2TlZ2anJZVXN5NHQ3cmRXYWdNQmwxb0JvdUlEaUUxWldIa2JPN1o1dW1s?= =?utf-8?B?QXRNZUZFZW12cGFweWpUZDZPOHFsd0JiUWZxSWt0M0FlejFtUnY1Zm1DVEtu?= =?utf-8?B?amo2cWJ3WHhoTnB6d29lOGJFV1NXRllBaWY4cFhFRDRTVkJFWWludjBvWDJ0?= =?utf-8?B?RisyZ2M5WnRaa1gwT0hKQURXYWtRejlpMXBMekhCbzM5V1N0dVF3OGk0TU1p?= =?utf-8?B?YWlBSVBxNy9SWmQrZ1ZOdGE0d01yd1JWWFVVV1JNRFJHZTZ5ZFkzWXdJMnJG?= =?utf-8?B?N1ZybU9sL0NmTzkxa3AzVDB2YWVpK3A4Q0hFWHJNOTR0QjFLa1NSdWRnK282?= =?utf-8?B?a2RrK1VLQUYrS3FDRGtVSXA1SzdYU1h0aEVNU0NHanp2RVkyOElRZnBnbXdG?= =?utf-8?B?RElLb0FoczllZlA4WlF6UktHZHlHYTQ5RG9tdzREWmRSSjcyVEFocGpOZnVX?= =?utf-8?B?azk3cGxoSWJjQnhWVHRPUllYdnlqWG51ZHd3Vk9TbHhTNnc2LzhYNHVuLzhp?= =?utf-8?B?RzYwT2RaeVZhYmNLN0R3WGttMWhBK1E2TW5BTEJjdkJ6S3EvaU5mWWM0dzZv?= =?utf-8?Q?BSfV/NJURx3E0XSEwrW89Bqmi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dbcaea2a-65cb-4853-ee23-08da6e3f1541 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 13:10:44.6233 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nA+yFO/2Y0m8IJppJlSYR9brnyzTq+vzIKLTTCp+JE8XDnpREY1PplwwSnk6bKIvB1p5aLDTFxG0+Z0D8OvNlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB3115 Quite obviously to determine the split condition successive pages' attributes need to be evaluated, not always those of the initial page. Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap init") Signed-off-by: Jan Beulich --- Part of the problem was already introduced in 24a53060bd37 ("xen/heap: Split init_heap_pages() in two"), but there it was still benign. --- a/xen/common/page_alloc.c +++ b/xen/common/page_alloc.c @@ -1885,11 +1885,11 @@ static void init_heap_pages( * range to cross zones. */ #ifdef CONFIG_SEPARATE_XENHEAP - if ( zone != page_to_zone(pg) ) + if ( zone != page_to_zone(pg + contig_pages) ) break; #endif - if ( nid != (phys_to_nid(page_to_maddr(pg))) ) + if ( nid != (phys_to_nid(page_to_maddr(pg + contig_pages))) ) break; } From xen-devel-bounces@lists.xenproject.org Mon Jul 25 14:45:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 14:45:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374634.606743 (Exim 4.92) (envelope-from ) id 1oFzKX-0001LU-8x; Mon, 25 Jul 2022 14:45:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374634.606743; Mon, 25 Jul 2022 14:45:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzKX-0001LN-4g; Mon, 25 Jul 2022 14:45:09 +0000 Received: by outflank-mailman (input) for mailman id 374634; Mon, 25 Jul 2022 14:45:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzKW-0001LH-5l for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 14:45:08 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-flk1.inumbo.com (Halon) with ESMTP id 5f2daa38-0c28-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 16:45:06 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 74B8E2B; Mon, 25 Jul 2022 07:45:05 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A89783F73D; Mon, 25 Jul 2022 07:45:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5f2daa38-0c28-11ed-924f-1f966e50362f From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH] common/memory: Fix ifdefs for ptdom_max_order Date: Mon, 25 Jul 2022 15:44:55 +0100 Message-Id: <20220725144455.7666-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 In common/memory.c the ifdef code surrounding ptdom_max_order is using HAS_PASSTHROUGH instead of CONFIG_HAS_PASSTHROUGH, fix the problem using the correct macro. Fixes: e0d44c1f9461 ("build: convert HAS_PASSTHROUGH use to Kconfig") Signed-off-by: Luca Fancellu --- xen/common/memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/common/memory.c b/xen/common/memory.c index f6f794914dfd..bc89442ba53f 100644 --- a/xen/common/memory.c +++ b/xen/common/memory.c @@ -58,7 +58,7 @@ struct memop_args { static unsigned int __read_mostly domu_max_order = CONFIG_DOMU_MAX_ORDER; static unsigned int __read_mostly ctldom_max_order = CONFIG_CTLDOM_MAX_ORDER; static unsigned int __read_mostly hwdom_max_order = CONFIG_HWDOM_MAX_ORDER; -#ifdef HAS_PASSTHROUGH +#ifdef CONFIG_HAS_PASSTHROUGH static unsigned int __read_mostly ptdom_max_order = CONFIG_PTDOM_MAX_ORDER; #endif @@ -70,7 +70,7 @@ static int __init cf_check parse_max_order(const char *s) ctldom_max_order = simple_strtoul(s, &s, 0); if ( *s == ',' && *++s != ',' ) hwdom_max_order = simple_strtoul(s, &s, 0); -#ifdef HAS_PASSTHROUGH +#ifdef CONFIG_HAS_PASSTHROUGH if ( *s == ',' && *++s != ',' ) ptdom_max_order = simple_strtoul(s, &s, 0); #endif @@ -83,7 +83,7 @@ static unsigned int max_order(const struct domain *d) { unsigned int order = domu_max_order; -#ifdef HAS_PASSTHROUGH +#ifdef CONFIG_HAS_PASSTHROUGH if ( cache_flush_permitted(d) && order < ptdom_max_order ) order = ptdom_max_order; #endif -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 14:46:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 14:46:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374639.606754 (Exim 4.92) (envelope-from ) id 1oFzM7-00020l-Ie; Mon, 25 Jul 2022 14:46:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374639.606754; Mon, 25 Jul 2022 14:46:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzM7-00020e-G4; Mon, 25 Jul 2022 14:46:47 +0000 Received: by outflank-mailman (input) for mailman id 374639; Mon, 25 Jul 2022 14:46:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzM5-00020K-Vv for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 14:46:45 +0000 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by se1-gles-sth1.inumbo.com (Halon) with ESMTP id 9996d8ad-0c28-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 16:46:43 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8482C2B; Mon, 25 Jul 2022 07:46:43 -0700 (PDT) Received: from e125770.cambridge.arm.com (e125770.cambridge.arm.com [10.1.195.16]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 13B053F73D; Mon, 25 Jul 2022 07:46:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9996d8ad-0c28-11ed-bd2d-47488cf2e6aa From: Luca Fancellu To: xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Julien Grall , Volodymyr Babchuk Subject: [PATCH] arm/domain: fix comment for arch_set_info_guest Date: Mon, 25 Jul 2022 15:46:34 +0100 Message-Id: <20220725144634.8086-1-luca.fancellu@arm.com> X-Mailer: git-send-email 2.17.1 The function arch_set_info_guest is not reached anymore through VCPUOP_initialise on arm, update the comment. Signed-off-by: Luca Fancellu --- xen/arch/arm/domain.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b56b..6451cd013c1a 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -882,9 +882,9 @@ static int is_guest_pv64_psr(uint64_t psr) #endif /* - * Initialise VCPU state. The context can be supplied by either the - * toolstack (XEN_DOMCTL_setvcpucontext) or the guest - * (VCPUOP_initialise) and therefore must be properly validated. + * Initialise VCPU state. The context can be supplied by the toolstack + * (XEN_DOMCTL_setvcpucontext) and therefore must be properly validated, + * or by PSCI call (PSCI_cpu_on) handled by vpsci module. */ int arch_set_info_guest( struct vcpu *v, vcpu_guest_context_u c) -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:19:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374650.606765 (Exim 4.92) (envelope-from ) id 1oFzrS-0005dH-2n; Mon, 25 Jul 2022 15:19:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374650.606765; Mon, 25 Jul 2022 15:19:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzrR-0005dA-VO; Mon, 25 Jul 2022 15:19:09 +0000 Received: by outflank-mailman (input) for mailman id 374650; Mon, 25 Jul 2022 15:19:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oFzrQ-0005d4-OD for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:19:08 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 201ab18c-0c2d-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 17:19:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS1PR04MB9630.eurprd04.prod.outlook.com (2603:10a6:20b:475::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 15:19:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 15:19:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 201ab18c-0c2d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BR6JaZIO8e65Nha7/5a4ntCW74FP1EPICFix6sIVmGzUGk7XM44xfDB68dwg7kXXdmG6u3lbITmBTdtlVP5kNfKUjHo+wVqr5BsOIYSqtM3sZrscqyzw27QbP4dAzU/zClcC/ST1HjRzEfsJPuONM5h0eOiCW3tiqSVsuF6M+X8J/UEphvYh2dMTk58Dh0q0GZQHA7tn6IZ2POBJOtNUs068ARM7FpynF+YLTDvzh6EQWVzCnRqPJXuTZSdu0H/nMho4BlSf4fP8Ygh9/oMlnox1ikMgmXw6kBxjooh4fbiApiN7kF/1lTNam40B1iF5A4DjswZ2Dvdgq3exEMHTeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1IbqQ68jT7ZGxS6o6tDsOo1+4EOVu2o8VCYhp3hPcIQ=; b=dDQieC7i19vKHu2i6S8IBQMgs0l/H3Th+S/RJATDS/SeOSyp69XIOwQ6mzsI4xSvarfu56Kp0PrdLveTZgjbqSx+gsUKAW1KibktTmOo2Hesf46s7r4bHSUuMkdDyvi66lPkldj1lEyt/gjHlm8J67SGnRJ+fxvw4bvR3oSRzycVxCNF7IOGzgKsZkoLxIzaoKDtOV95bFa8e8HC60AmDPjfAUkRZ65tcv6y+Fj/8fy0BcdusNvy8ACNDw+VTBJNhiQA6msguBSYMo170k1DUidewvyvwUz9Qljt9q25MRz9KLiA75ONtDsKrxvIVxk+grlfY9F/D5RTy2EprW8jiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1IbqQ68jT7ZGxS6o6tDsOo1+4EOVu2o8VCYhp3hPcIQ=; b=5W90DkCE7Iz79ny7TsPlYRfHDYjC9ZN4X69jmLevLAupQrVjtkOAn3nXfPQJGNDUtXBOlqHI3Y+aMGXLRj6eDltUNw42fkXDiOrvMWOpFWbB3A906gUfx82YPXYDyWMTLDzCm04AUCEiu0qD/WLXxLDctxlkrGZ24lo4zEqPGq4GCrCofqnv6t4a8RAfJhf3wVz8al/8cqUg+CmiyXxx+X9J2McPlBzP9xMiY9MFuIYVdMy5Sr74s5a6Jm2K1+x8KYzkg5MZAw3yO8l1w2AGPzOEwjmy1NtXQEfAr8RtCliraE4TRQ5iUaHQ6F+tT+V87gahblZBHm3YdIlHWZJo+A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 25 Jul 2022 17:19:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] common/memory: Fix ifdefs for ptdom_max_order Content-Language: en-US To: Luca Fancellu Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220725144455.7666-1-luca.fancellu@arm.com> From: Jan Beulich In-Reply-To: <20220725144455.7666-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0142.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b090e224-fc58-4a28-6690-08da6e5101f0 X-MS-TrafficTypeDiagnostic: AS1PR04MB9630:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fHLzrJwjodgEegqeGz3s93mNE2v1S54riaS8gqCWB41O5k8JOvUbdrFHvtpusF4YzqP2iz/l6i0kkPVg/Bp22EdoqxltghXX/67HJd59DbvsaGX/o5xZsPReVbKcB0FifJd+zTz9USIKTde/MQWu1ppeje0V9xcuaTN7IP6VKdQPKKKHT/9yNNIs4Nnz85rAwlYrrS/txoloY6xw8MzB0QgSv2qNrbSYJYkI92hQ94l/05Qns10d+ys/h1BEPBhAlAka5PjknngcSWoPav9INdYwgRQ+JyxKfyBSSC4DZrEETti/T6wmcNHWQS6IFEa/CVzSn3fgCxwm9UuEOru180eS96PxH73TqmFQfGUYqO4KXnE4XPNyPwqfeZGj6vIVObpGJYhkpWGabHHZQ03RDhJXHkdQq7EJ/q5+86pjQXwwiBrD4u1IesX9JkeUmseFB/OLcHEjiXOVhi61kegjG3tfX0bbs4cFjEv/u4dI3hExHUjFp4nYOCqWidNzKLDqRNDRuj6rckTdJYlPakL/FY6/a+RAzqcyF0d/2NvuQRvPAsD2VMjjiUW67SWw/Ml9Vum53bm+1SDAysmDn2nAg4L6RLNowR920q+lVjNgpwoiw7hfQ39K9kkL5Kv57uTOKgDE1nfpP2B7Xh4waIwbwVkWRtqtpV50tnYZKcD7kYSpiLhF50gWKUt+72kruFj6REmcr3TGkcHFM94SnLMxXJUho3ceuWrAnuhxQXEzJikPTsz50nZ6c8c7mTnUK0G8wSw2XqWdquUHJN43/VugkfLpr7cWuU/aOeNQPIEDkqvyfgQ++N2sYR8jyKtPYQHxq3ZuZZS1Cz7J6W+31zqkbQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(396003)(346002)(366004)(39860400002)(38100700002)(8676002)(4326008)(6916009)(66946007)(66556008)(54906003)(66476007)(6486002)(6512007)(478600001)(53546011)(26005)(31696002)(316002)(41300700001)(2906002)(6666004)(6506007)(83380400001)(8936002)(36756003)(2616005)(86362001)(31686004)(186003)(5660300002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTJmVEtVMUlGempRVnE0S1JtbDZZd25pcWNvL0x6K2lBc0J3VFVRNm1YVExW?= =?utf-8?B?NVFXNG90TUJBN2ZNMlVzblBQeEtxT0xnNFBoSDZKOXRXbGhlMnBMQUtuS1Q0?= =?utf-8?B?M2tnTnlDSmthLzVqZ3MyME9TNEJsUXZHeWFxc2dkeDVJT1lURzJEZ2NHV25K?= =?utf-8?B?TWdBOVZkaG1kdUtHTnFkYlBJOUQxM1U0S3hOb1VsK2lDWm80cThuOCthODds?= =?utf-8?B?UmcycEJvUE5FZVMyZzIyODNBSXVzV3VuTVJUM0hwWmJOZHVhYW5VN2hJeG96?= =?utf-8?B?UmgxVnhJMTB5cDVHWDVoMkxBYmMwSzBZemlheFJyRzZ3MnVySVpwYkVpeGMx?= =?utf-8?B?ZVoyemxBYVlsY1Vwb0JPMERSQ09Sd3RXVXg0TmdEQ3dRU3dHNlBlZjlTS2I2?= =?utf-8?B?OHBmSE93WHVjbXNLaFBqRllsNEVYRWYzL3lPc3VVcmh1TmM1dW5YM3RkUmZI?= =?utf-8?B?KzhxVHBPVi9mS3hrU1AvejY5MEN4Y1V2Vk5IWHkvdlp6aXU0WHJnaTJHenFq?= =?utf-8?B?L1dReVFXZDFvU0J2em5TSU9GcEZWcGpqTTV6SEpWdXViY3l4YnZVVzkxZXlm?= =?utf-8?B?N2pKRU9vS2xQWHhSQnFVUFo0VDNxNFZNL3pITWwvcVhBQkRiYXVZaE5Ua1Fh?= =?utf-8?B?T2ZUcytqeDFpYTNrU01CcHVJMHJzUllkeFRJN3ZMVU9yRjZVSXNJRlNjZDU0?= =?utf-8?B?bDZaNWJZVlloRUlvc2RjM0R2NmpQcWpIZUg2MFEwa2grVXRMZ3BmMGVQeXJo?= =?utf-8?B?Z1Q4U1BYdkl3bUtmQUwzbmdVR1ZENGhKbVIrbng2TExJNkRuVmZTd1Bja1pz?= =?utf-8?B?a2VVb1gvZ2FXamgvK3NESm51ZkZ6enRZbmNGNVBKZnh5NHNDMGlIRVFLSW5U?= =?utf-8?B?SnM2NEpKUEo5S0xwRjh2ZjVwKzFseERTZDdCbzV6QkxteGJ2M1JtNEc2M1lE?= =?utf-8?B?NURxZjhzSGVSdk1mUGgrRDV0REwwbGlyaDdnSDYwSUN5RnRKTTlXVEZTcTJz?= =?utf-8?B?SEpKTi9ZRnhURjA2R0dEd1VQSVd6OXo3V28rK3RWS005N3FXR3RQbzd2RjNU?= =?utf-8?B?VHRLR29FcHVxeWcyUXhGaytVOTR0RytWTENRN2xQQTJld3NCOTNsRDZiZHRy?= =?utf-8?B?Njc2VVJQMzFHWnU5QlJyZkJKYWMrYnlUNWxGY1JKN1YvVHByNXVoUVltSHpu?= =?utf-8?B?KzByT0dHeU5LOVlFUU5BTVl1RmpjQzZKYXdhcGhPS3JTSDlrcGhXb05xeW5I?= =?utf-8?B?SzNVcnpPK3lybDQ0VUZoN2ZQakt2Vk5SbVFrbUhYSC90aWZXeXVzaGpHVkVJ?= =?utf-8?B?S2tIR3VrdzIyN05NNEVKcUxudVVtMCsyRC85SUFaWHpKSGtoSzY3WmxtczBJ?= =?utf-8?B?SmJVdi8yaGhhU2FvNzZLZ3c1ZjBPVFBScFhycmVhcS96SldTNkY0dHZEeUI2?= =?utf-8?B?bmFzUnpTckNEcFdqbFJzbGtSZy8xb0lqUnMxcHJCYkJ3NU1DUzJWZFVPZExJ?= =?utf-8?B?LzJ4Z3BOVUFjK1g3SVhmNCszZ1pHbVM1VU9leWcrQkFlczNRcDBiTHNIQjMx?= =?utf-8?B?R3E1bEZ5VnBjalRsMEFqcUFTSmNzUjBOeXJpOFhid1hvbXF3NU5KbWxRMnBk?= =?utf-8?B?WVdKZjNuSWl2ZFpjV21PTUUycDBBT1d1QW5wV1l0VSsvc1F6dG5hcDZ2bzRE?= =?utf-8?B?L2FQRjMvbEJVSCt3empzUTNMRVIrc3ZYMnVvL3YzSFpTcmx0cU9CZjNvdDM5?= =?utf-8?B?QUNqbXh2YmlXVFg5L3pWV0Q5cmhkNGxZc1ZwL1RDanh1SFo4S1RjcWRNWjE4?= =?utf-8?B?eUx2VVhoZHhmNTZBTDY4di9BQ1BWZnE3RzgwdktRRUtrZCtheDlYdlc5NVh3?= =?utf-8?B?b0NWbHB5RVRaYWt3bGd2Q3hycnVLY3NRQUh1TzNmdXRqUUVGS1g1LzBPaHk0?= =?utf-8?B?SGloMkRiOTNrN0VrOE5zZFRvMUxjVTE2TC9vN3FibGg3QktaNnF4Qk5KMGZi?= =?utf-8?B?U0xwQllPWVltYTFnZFBSL2lKL0ExeEVDUndJNjIrVWtCRmJmSVNINTJOSXBk?= =?utf-8?B?WDhzbHNIWlVDcDlNNXZsMHc2dFRtSVo1RllWcjJWZW8wNjVONzFocGZDSGYr?= =?utf-8?Q?ph/kUSdg+A2+e6ZEgF03uzluv?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b090e224-fc58-4a28-6690-08da6e5101f0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:19:04.8565 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: chDPn6WdKn2X8eDEHu0lHLuAGSKNpTaMBogB7i8+Q8piS2Ney3lyldxpQiivl72J0JWb3wFeX0aWLl+XIi7QEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9630 On 25.07.2022 16:44, Luca Fancellu wrote: > In common/memory.c the ifdef code surrounding ptdom_max_order is > using HAS_PASSTHROUGH instead of CONFIG_HAS_PASSTHROUGH, fix the > problem using the correct macro. > > Fixes: e0d44c1f9461 ("build: convert HAS_PASSTHROUGH use to Kconfig") > Signed-off-by: Luca Fancellu Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:29:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:29:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374656.606776 (Exim 4.92) (envelope-from ) id 1oG01b-0007Bt-3F; Mon, 25 Jul 2022 15:29:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374656.606776; Mon, 25 Jul 2022 15:29:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG01a-0007Bm-W4; Mon, 25 Jul 2022 15:29:38 +0000 Received: by outflank-mailman (input) for mailman id 374656; Mon, 25 Jul 2022 15:29:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG01Z-0007Bg-FU for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:29:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 96b17522-0c2e-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 17:29:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB3964.eurprd04.prod.outlook.com (2603:10a6:5:17::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 25 Jul 2022 15:29:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 15:29:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96b17522-0c2e-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CG2+9DyC9pz8pZvHT/JBkTmZJZ++cJu715FDPjXHwQx4u23JuoKTe6GDtte57nFMc0j4CvUkDo6v5VbwQryVxLvhvEyd18K6v+1cIgoJeicATtF75Oy1hshMRHzy1HnyLKgzBrhLi9qSvyYDiZZ8oYZQTGevg29nLGAbZJmWlIqOMuonyYOB8HjvGVFHi6gJWjq8hWX9vkIi9FUgxZ42Y5rHjmffwq/RUr5XTg6G5PYyxG2qm6oVbAAzetFN43t0Y6iEACCtiqybDTGHxUcxQ47b7XVE6p28+xqyOlb/A+2PxcVcj9I4vsoWZSj1iHXjTG7W5IabiK1yF7hO0rnhWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q8sRcLpwRjFEyUxKeqRGhLngYzc44AUkBJ73exqTkPg=; b=dD6huxbmlqJhciEiuWa6+i6xALuq5ODsPI9bCt3aiUq0jJ2fyko2icRSk7M96Uv7nKxidOl3gypSKv7uMGucsADFIGhEYiULuPmELXI+hYu2CFkWDj0E8uf7ZDId81HH3jjTmnTQM8S/K5/qEo7E0rKpjK3zYJtI0K7vj2LImRtyTUUcKxa8TeHTj/EsewrWKcoi9SSQefxr/rVscg5mUk2QE1AGvIxwS9qIszx2MJofIfM07IBGjaZevHb4Oe2QdvhI9CLcqb5JsgYsz4257HdeVHaCff85DEFu81EdgdB9Fw+7KBUM3Kip5s90MtgJY28MZyQsvk6oCVyYTIDnOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q8sRcLpwRjFEyUxKeqRGhLngYzc44AUkBJ73exqTkPg=; b=mlu6XRndbd+Udkl6nrEGMstoAFQeYhoPP5KhCWmTdmCEGVtmnzT89hHwC5drzLymJXAxnHa1VtiUuse8dZcvYZqqBgXFATUlhhhvbSnLv3mqcbuu9aZ91rVE9Tq4IzuQmsO/YAAEGi8zhGR0DoBPc8PPlJ3Sv7LXq/lVkPpsHIKTxaR41RiTzMsQwvArjsZgILWI1ty7HiQqEatK1KqZBd2qTBzuLi0477ekeShRuGiQJQyido8mbNQki12F/u7pJodfBGe2rcgrpdmH3VdBrBEy4IhYlF7N8s0H9IgQ4SYXoxlTK6U+5e/lX93Ey67i1sgRCC5ZolXcQ1eKcQpeOQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 25 Jul 2022 17:29:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 2/8] xen: do not free reserved memory into heap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , xen-devel@lists.xenproject.org References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-3-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220720054611.2695787-3-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::10) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 743ec0a5-5374-4bba-4219-08da6e5279a8 X-MS-TrafficTypeDiagnostic: DB7PR04MB3964:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: OSQNqY2lGRaDfB2IYLXObsgNXzZJZfgLJMNgHxRpI8UHuV2vzBEeKGQzvVeR+iHooKV/5H+Um4mXHgPlrFNXFQUFcRjAfouxYoWNgJ7LV6iq8KIGirOrBADamv2Bjx3A61WGIAvrjyux3EVIptHQT3Lo0rxPkJs5JfaiH4PnuNtdC3HLHNdyRq8ECbxHhUKGU76Bvghftkd4NVyp7Puh8Lt9EF6Ti9JRy5u4pYn8vwZmandNicBf/zdLAIWXTVt1VsSrKFsmbjqL1YGrPoT1wMAGY4SRNu6MMRSl7KB0z8rj/VOLY5d6gHvDmpBsvm72JTM0tqsN9tjStpWlKlExam+t83NsYIjpghH6RDSR0lCEf9qm8NlEjnWAEhI2wWf4j4La01pksG+1lQAuQbXFU/SVc6iq8nq3BaBXAHCIsWXp8M78thHy7bUN9cnsxcLxQpchLpyA6aY7Ti7FJUarzB5myBUHBm9a4oePlfdbOSV29gWusRaxu4R8WZwOSUoY5L813TRMWssG8PXiHdcwmYnlMYfRtgLsJXK/1sP6ihviErzZGib22ls1Zy5o9EIJGS4ordcULcy9imKb/4qfpAj2cY2Ds7Su07pKHNHw6bqVYqBKzwv/sWNluA4kVWGTvy2n9eW8n/HyBHEfdgbMYdkoPxg1JDddEdc0idh/qwiXhWnEVV+OGui5XtpnESsPeqnNswKY1tFa26nPaTpMlrCB91FI1zhysrEW1EYJinfrZbF8lydJz8Ju5aFQYLl+Zq6iiMdV6wTDVyleanncJMPHhBgrhibVIVQAhxXG1au+tOVBcPtO/u5PVTz2YXhJ8mEQvQYasuHfEqPVkzzsCQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(39860400002)(366004)(396003)(136003)(4326008)(66556008)(2906002)(8936002)(316002)(5660300002)(6916009)(7416002)(8676002)(31686004)(66476007)(54906003)(66946007)(36756003)(86362001)(38100700002)(478600001)(186003)(6506007)(6486002)(26005)(2616005)(6512007)(31696002)(41300700001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU83ZWlURFVNbnZqTmlqNjVCYmFnTllJWmYrT0FxVVpWVlFhSGVoSGJBV1NJ?= =?utf-8?B?TzltR0xKRm5EbjdnSWlhTmVIM2x4UGczUkdSMFNEWDlLOXNNUEhGa0FraHp0?= =?utf-8?B?VVlBKytrUHBZemhGN1RmOCtjenIzakRUY3Q0SHVGTTFvQnc1L3NhUzJvVEI5?= =?utf-8?B?MTkvcDcvKzl6czRBc3dReUx5U1lkZlZJdUhnT0V6OUQyek44Y2MwMHNBek1J?= =?utf-8?B?ZzRLdTczbWJFa1VURzdLT2VPajN6N2NtSGRqTS9QMzhVUTBockJiN0laUm5p?= =?utf-8?B?c1RWNndFcDZQVTFDWFhhZ05Cd253Znc2bXphZU1hdTJtWGdBNDVralVDMTgw?= =?utf-8?B?M29ZNFliRHNneHg5dldVTHBzYU1lWVZVUTIwK2RLa04xQU1ZaFBad0xQbDla?= =?utf-8?B?WjFxejBJdnBqUXpNSFBTSHVlNjZwOVV3TjN3SHJKY2crTldFQVQrcFEreDhP?= =?utf-8?B?SmlUNVJvemQrODFHa2dxY2d2R1cxc3hEa1R0bjRtejFVZVVZU2g4TFNNc3RG?= =?utf-8?B?cDhrRm00R3poaWd1aDlHZDk1SEpadEZlSXFEZTBJZVdlSWxYelhFaTNMRHZK?= =?utf-8?B?dGI0WHd1eXN3T1N0aU9XYzN0MXI0Q0cvUE1zT1o4YjEzeUlMbys4a205a2p6?= =?utf-8?B?QUkxWEEyOWRPTHR1OFR5dUNBaktsbjl4RVhoVmxscHN0VjFsN1ZqbHdXZDIy?= =?utf-8?B?aTUwNXJ5KzNwQ2kxbS9nekZkL2J4elpkUHlKbytkN2R2OFdxaTN6V2QwOG5U?= =?utf-8?B?L3hldHdmalRkZGZtemp6R1pYNURONWg4VXlMSG11a2I1V2FEYU5LdWRmN1Q3?= =?utf-8?B?Q2diNFB6dE9IcUozSURYbnlzbEdQaDBPZ0hlVUk3R1hvMzVQc3habU1SR3RW?= =?utf-8?B?VExyRlk0TGFWUHFlWjBLclF6eFJJVllGMDljbmVpOEhIaTRNcHlydW1Lc3JY?= =?utf-8?B?bjRWUTRYYm5pRHBVZHVGWXlIN0xlaDZuaVRrVFJaR05VaElQdkJubTRpcUho?= =?utf-8?B?Z25FakV3d1daVWFzQ0w1bzJ1VjZ1NjE2akJvc1A3M2FpSS9WMnZ6emNXRWlZ?= =?utf-8?B?UWNrWFIrL2pUQWpXdWpVeUZWbEdoREVaaTc0WGZDeERwRGw4ckRrb1E1ZTFr?= =?utf-8?B?OWJqMERpb0Jrb3RROGdnOG8zeHh3aERDbyt3NFZVSklKcVQyamRzVGl2WHVt?= =?utf-8?B?S3JhditROU92OU5CUUhTc0RWSGdvbnVDSVQranAvQWxWVDFFenRpRWpqcEpa?= =?utf-8?B?aVdvZ1g4cEVaWVdYZTZ1emRrNmtBT3dwMUpDdUxkN2FGakg2UFEvcWRPWkds?= =?utf-8?B?b011TGFGZWU1eUIra1pzeWw1SmJKeGlLUFhyRlhHbmlibzhyYnZOR1orWk5R?= =?utf-8?B?UXZjaDNPczFDcjVuYWFkZVNxNDNVSmpMNnIyR29aWnQ0ZWZKd1I5UnRjek1q?= =?utf-8?B?VkNncXY2TGxHT2VtU0pYQXFHK01BeUNEQWJjQ0FSZXpvTEM3K1cvWm5icWVB?= =?utf-8?B?UldISi9IZjgwbmZNOGtjaWZGSXFnQzBhc1RRZHlGRG5OR2kyNkdIbFdaV0M0?= =?utf-8?B?WW5XNDJROVBOVE1HbDllaVhKa2hOUmprb0dnTUxYVzJWcTRGR1BRdmtPVXdm?= =?utf-8?B?dDRSeFhGMDFIalJWZ0l6L0g3YlZhV29xa2tOTlBZUmU4L05YOG1meCs5azR4?= =?utf-8?B?Sk5KekJMd2lUdzdiQ1BNT0JNTVpWbkFBNklOM08yTkRSUHdoMXBzNTJ4MXNB?= =?utf-8?B?SGdIU0l6VnpxZ3VLSjhFT281R3VTczBMZXR5Q3hsczlSVDBMZWU3NWNNMmtJ?= =?utf-8?B?MG52WGIybTVxUTY5TzdOcWltOWFESTRyZ3JkdGxoUHdod0loZHpVS0Z2Rytw?= =?utf-8?B?TkRDd1MyNGFSaVJLSUd0UDBLRmpYbzY2L3ZGZitBWWViRjQxSlhtaTk1SFRG?= =?utf-8?B?L05DaDNCbHZZRmdYWldXV0VEUzVlV2pHQXBwVTZZbDYwM1J4cnpGc1dnZ2hH?= =?utf-8?B?OXhENmRNa3N4VDVrdzByM2dNV3FKNlFJbFhjQkFZdm5oeWhCN2hUdm1PWG84?= =?utf-8?B?VGIveWJsOHVhMU9BcHdtYW90V05hai8rVWg0cFk3SVdhWDFWVFdPY20xb3ds?= =?utf-8?Q?gXv01BOvrJE+z5FQDW2v/5wL2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 743ec0a5-5374-4bba-4219-08da6e5279a8 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:29:33.5821 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k3k3fe3WEfDiz1c0+o0us0yLjAU4SWOvSjdaupGI9sbSEI+VrIVb15Cnp4A4NQr/1z0DqKDRacuhqNHpY6zSig== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB3964 On 20.07.2022 07:46, Penny Zheng wrote: > Pages used as guest RAM for static domain, shall be reserved to this > domain only. > So in case reserved pages being used for other purpose, users > shall not free them back to heap, even when last ref gets dropped. > > This commit introduces a new helper free_domstatic_page to free > static page in runtime, and free_staticmem_pages will be called by it > in runtime, so let's drop the __init flag. > > Signed-off-by: Penny Zheng Technically Reviewed-by: Jan Beulich Nevertheless two remarks: > +void free_domstatic_page(struct page_info *page) > +{ > + struct domain *d = page_get_owner(page); > + bool drop_dom_ref; > + > + ASSERT(d); I wonder whether if ( unlikely(!d) ) { ASSERT_UNREACHABLE(); return; } wouldn't be more robust looking forward. > --- a/xen/include/xen/mm.h > +++ b/xen/include/xen/mm.h > @@ -85,13 +85,12 @@ bool scrub_free_pages(void); > } while ( false ) > #define FREE_XENHEAP_PAGE(p) FREE_XENHEAP_PAGES(p, 0) > > -#ifdef CONFIG_STATIC_MEMORY > /* These functions are for static memory */ > void free_staticmem_pages(struct page_info *pg, unsigned long nr_mfns, > bool need_scrub); > +void free_domstatic_page(struct page_info *page); > int acquire_domstatic_pages(struct domain *d, mfn_t smfn, unsigned int nr_mfns, > unsigned int memflags); > -#endif > > /* Map machine page range in Xen virtual address space. */ > int map_pages_to_xen( > @@ -212,6 +211,10 @@ extern struct domain *dom_cow; > > #include > > +#ifndef PGC_static > +#define PGC_static 0 > +#endif This disconnect from all other PGC_* values isn't very nice. I wonder as how bad it would be seen if Arm kept its #define to 0 private, with the generic fallback remaining in page_alloc.c. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:35:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:35:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374662.606786 (Exim 4.92) (envelope-from ) id 1oG07M-00009V-Nn; Mon, 25 Jul 2022 15:35:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374662.606786; Mon, 25 Jul 2022 15:35:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG07M-00009O-LA; Mon, 25 Jul 2022 15:35:36 +0000 Received: by outflank-mailman (input) for mailman id 374662; Mon, 25 Jul 2022 15:35:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG07L-00009I-JY for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:35:35 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140051.outbound.protection.outlook.com [40.107.14.51]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6c88c3e0-0c2f-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 17:35:34 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8746.eurprd04.prod.outlook.com (2603:10a6:20b:43f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 15:35:32 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 15:35:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6c88c3e0-0c2f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JAvqz3SSisAzinBkF3QTTF0u62qdfoDL2yXvg8g7Vg6FnUdR2aaD3diRTLJGz69i3i3FziddjUxqMXSgqLUKD82xDvJKUvAiYeXiCSk7aljWQNi2RT/SPjRy47lyfhQZ/Ul57EUOmsd+IPHT/dnLZOwJ/d03l9ZlgWhqq6dbJPVLRpUmlRa/S4m+u7ztsTMlbBP0ZWx2WdV3oQH7z5bUDGEd1gQDQoH2s2PxUqE6Q20ZAnKzSC8fpimBq9H+3Ap/XfvExam1GtAQ7Ah7QZTh7IqwzR9X3VYUXEXbuVdRJGqywGh9X29Ps+iNSbn22fX0OuKY+eKe8QPByx2vFtgsvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IQRQ4PQdqjivhqvwrVdrxAnblF6BKWoJt05WMl82ao0=; b=Ki+Q6ShyKMkjinObUHUF57xhCZ7YCk++Q/3jjQYULlh+78AXCjd0HiYtr0gA/7rpH2aXjSH8Av1Y8S90gZPIExflK2AiGbBI56fvJKWIhbW85mLkpRAylOszw0lUY9X3JtOh9LixZaoJqhcXkBzZCB5OChE1uZ3648RZxwbMUq2H8cvwhjz3Xfu28K/+hJLnyj6dUHO0Q9zORVbd7UMUVydR7ebUg5a+JkHtGCv5LIjMokuHdO8dcT+fIiXyejwEfFODRi+Z8LdPaHuzXzWgACq2Ptc56tU5IzzQTzOrOg1um7JmLioFu9510XV/8NxrtkApazwcJiO4ggdKkA5bTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IQRQ4PQdqjivhqvwrVdrxAnblF6BKWoJt05WMl82ao0=; b=QIj6gCjD+1s7ffIoE0cXY49JX+dcAJ6hftWDuBUmbbjMGcCjoVD9poW2nlyTijru7yeHi8bLAbW9ZSS1q8Keyi3g8909ARdXOnF1MPmXc+Pw65xTPRyMUYFcYUiTmr/mIPz01a+f5qbnLwwyGAR9VDWLeVR1t6DuCDXnIY4VfrS/jt09ieALVE9HZpUjhEQng2KJhGdeQN1NqczJLQ3HAkLvZfoCccOU+XfmL550O14sB/lZ+QT2My2VbdQ0A2nNWojupdkjzBTf91BbI3e3bDDbrtiQv66ABVRIjpRYY+lh4YClrLCbwgy9F4RG9ickE8KuSDLFzHTJtHD56PVADA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <903b6203-a475-5a83-0b2a-f3a8fa345b73@suse.com> Date: Mon, 25 Jul 2022 17:35:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-7-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220720054611.2695787-7-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0016.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 654bae5c-a686-49a5-5c63-08da6e534fa9 X-MS-TrafficTypeDiagnostic: AM9PR04MB8746:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dv3nNNGGEN8kSgjG+oBJgvEk96j6Dea91gLjoDffxbzAGOoKieiRV1ww9T/dAbTEwjfaC6IReN0LqKpA5wNICwMhXpmqkgNZHqOKvSomCvAkQRcDsW6IZjlW9Xt/V1t8r+vjvZVMqAkol/ELHsVzExXCjZQ2dx6yvN4UhcuyS1scaAPmOM33zkcSRKLx5r7Uao4zDMOJVftwOUKSj974dI+0Q3swdIy/c3aiGzIXuy0PQhxB5t6GSII6T/gNRPVFbWHUG5dh0ivBSLZ/e832ToXqz19vwpUqZlsvPSxH53jpzGILOsd0Jy5wa1ZmISad8hjCkot6n+5Dw5X+EXR2v5gKlP3WN+ieL7xFtG1iJcLSlfMgHLWf3cmo1H6TEzqnxnECG0eiJxRRwoHQi0IA6XiDaMhCwmKaBEIujSAHImUKSJHHPTSrUFNlEE6GY0LlEZaxXBBO9TvlxSOhCUvD2j9TqJTwGS1o5kajxIWxoMynLcMyqJsjNguBREYQwaig/Qy3BgoeHNhw+0b4uMQ8Ny7rjFjx65YzD0XqCWKdRVls61g92yjg7sg8DDOWnc1LcxxihPCqFUy4GfTaCHBunThUWyCeH8b2Q2OKNuFA3It20kh6CSJ5njg0WG7y2iVzM4yk4pe8t3scBeAEMqimLF9QiQ9GGRiL+9AAOR4NGIS1FvGXDZw4PiAF+dmt+CpqOsuGr3TgdM6+iOngwVALCfkSaDG8fbR0ogTNsjBVEg9W6eBVgNuvaPNJZgsDW9lz+fkUyCb2sfJm3yDbHujIzu3ilbj2BHwdJbEN6GvFSP3LElfeJvN3FCZJSsvY+mRiqmn5Susaf+lgqypnOkFDnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(136003)(366004)(376002)(39860400002)(396003)(86362001)(31696002)(83380400001)(6512007)(186003)(26005)(53546011)(6506007)(36756003)(2616005)(31686004)(41300700001)(54906003)(6916009)(6486002)(316002)(8936002)(38100700002)(8676002)(66556008)(5660300002)(66476007)(4326008)(66946007)(2906002)(478600001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WDFUZ2d4eFVXaXA3SWNyaFNvSk4xTEx2MWtkWXdnMEU3TjlNMjdFdlBESWFP?= =?utf-8?B?TXRzMWhUSnRHNHZRbVRILzFmTG8yTUtPVzVScElZS21vVkhNaTN1OGZLU3pa?= =?utf-8?B?c0lLQWdBUVJhTENiL2pNVm1LYjI5YjZZNGhJQXVBMTNtYUdMMWc2alUyQ0kw?= =?utf-8?B?QzBGMzRIMzJOcEQ3ZnFRMDF2Z056UVFOSy8xeUd6QkQ5YmU1VU94WU5WVHVr?= =?utf-8?B?WCsyWTRZOVZHR0Z6MFlIS0ZzbVlhb2dKc0F4Vm5tS00rc250Vi9VeC9kYnRS?= =?utf-8?B?a1lhak5vTG1oTGR0bCtNem50Ly84NTE3bzYxb2FReU9EMGQxdGEvNjJtb3dt?= =?utf-8?B?bnFBZUlCcjRBZkdpR3Avcnp3WFY1SXFuMHJNVkxsMUtNVHN5eFBscmZsdFhm?= =?utf-8?B?aVJWWExhbWZhVFBnRWtNNlJjWmtxbHoxYkJXeTZoTXRjMEMrdVVyUnN4ZnNT?= =?utf-8?B?UHJUK0RlSHJteXc4UndMY2tLTU5rZkN3Q2Jva1VpVnVxL2hoZ0RCSnZmYTd0?= =?utf-8?B?VDUyRTA1d1lJOUpOVUdBQnViRjRqNVo0SGJZN3NnM05CQUNRWEQzaTQwOTlY?= =?utf-8?B?cVE3dmszRmtLMTAzZEprbi94cHNlSFo5OTQ4NTBKdzFqQ0NEK25uRnUzRk8r?= =?utf-8?B?S1lqcnFrWWJ3TitLRmFsOFpDTDBlYlpkRkp6a1BBcEVwUDhESDlNZ0UzWFFX?= =?utf-8?B?NnNIYWJ1K0svanptZGJkR3VRVTJUckxITjdzUmpnaytJRXZydlRkdnl0MnNT?= =?utf-8?B?UXdhanh0Y3gyUGpuNXFjMmJiZGRaYXZ1VnNLdEF0RXlsQXp4TFROMytPL2Nj?= =?utf-8?B?K0dUWmlhVy9vRFlVaEpKbVFFb2pBblVOU0N4NkV1dW5weTJJeUZ1TXZpY01x?= =?utf-8?B?M21ycCtwc0hvYjVUK2NSQ2NtbGoxUDVhUm1MZkJtb3Ywcko1NVUzRmhveDBU?= =?utf-8?B?dDYzcFR1eVphemIzSnBmN21BUEJ1ZWpFY1BlTXJrQkU1ODR0UFJEakc1SVNm?= =?utf-8?B?ajVRdnAvMGFRS3BFQ0FwYVBNZitId2xEZ21PVFAwNlpLMkp0SlNXQzQ3cldS?= =?utf-8?B?ZHNHU2dlM3RPSmh2V3RMM1BaWEdSKytxOVpwSFZyekw1TjlXVmhhMDd6Nkln?= =?utf-8?B?WmJJbmxlb0VQTTVxNEdFRHRBWEYyN2dmek1QUGxaYThaem9USnNObkRzdy9u?= =?utf-8?B?QWoxZGlVSDRISnJQS2tSZ2tkZHljMXNrTzNSOGhZVjc0SmI3N1ZENlNtemRi?= =?utf-8?B?WDUrZEFMNVZJNlRZVUM2TjVoRjd5blBsbllDUEFhb3pzOTl6SldmUnFjNDFH?= =?utf-8?B?WUtiYVVCMVVTVHI0RVdPbHhFR3Zrc0JSajBPalBCRitZRWRqMGl3YXlSMmNz?= =?utf-8?B?dm0yV1BGVk0vVzVlMmZ1ODgwWVA2VUlKOG93WUhGV3c1Y0hZWkpla3k0YUJT?= =?utf-8?B?bFlIeVRvUG9NWTlDRWJ2OFJsWllSaGQ0aG14alErME9XaUVpcFJSUmVZK3h4?= =?utf-8?B?K0ZWaEdQcFpsZ3NyRGQwODYybFFuUm5yOVBEQisxY2xnVERORGZMWEtsUCt3?= =?utf-8?B?cEJTZURJWVJZMXArSTlhUjk0Y1QwN1V3SnFtZHFGWlRFSC9tdVRsQWtnVGZJ?= =?utf-8?B?Wi9KQ2UrV3dnU2pUb211NDIyaFhlSWw3YzJQMzhUYVpKalVUc2JXVDhEWlh4?= =?utf-8?B?OVdUby9nell4N1VSTzNiTXNrM3hBalA2TlRSUit4aENxa05IOU81UkFuT2lr?= =?utf-8?B?dHl5eHFJWU9Wbk1MU3pCbGJhVmIxOFREKzJXZnJIRy9uNDMwK3pGQ1dFQ09v?= =?utf-8?B?YnYrYjMrZ1RFN3dEZ2c4Q2tuSU1XMlRBbVRYVHdWcWRGV21sZ0pqMFdtRm1x?= =?utf-8?B?T1Q1ZmRJMXpvSjBOb0hnMDNHQWNWQWd4TmphMjhDOE9TRW1MSlQ0VG1RYUpH?= =?utf-8?B?WWNKNFhKNGtPaVdqV1Y0em1JU0ZDUHBydFpSZlZlRDAxMWtyYnF1MnZFSTA3?= =?utf-8?B?azFxbS90ckwwTWhteGFSdHk2L2tMUEFFSThqcFBPdlo5ZFZxcGk4aUIvN05H?= =?utf-8?B?Q3BZQnppRmt3L3ppSDh0OWpDVWJ4MjhiUW96RFNYNnBXTXRubE1PMTZDR3pn?= =?utf-8?Q?s24EleTbdJI77ejiP9IU85iIw?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 654bae5c-a686-49a5-5c63-08da6e534fa9 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:35:32.5592 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mJD9nGoPPLCC+Sohc9BGuki3HEFN9uWwURTjqhtFbrmsdehZsoOzA54B3M8BzYjHIyPs0Xv0vsX6p9i69pTL/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8746 On 20.07.2022 07:46, Penny Zheng wrote: > Today when a domain unpopulates the memory on runtime, they will always > hand the memory back to the heap allocator. And it will be a problem if domain > is static. > > Pages as guest RAM for static domain shall be reserved to only this domain > and not be used for any other purposes, so they shall never go back to heap > allocator. > > This commit puts reserved pages on the new list resv_page_list only after > having taken them off the "normal" list, when the last ref dropped. I guess this wording somehow relates to ... > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -2674,10 +2674,14 @@ void free_domstatic_page(struct page_info *page) > > drop_dom_ref = !domain_adjust_tot_pages(d, -1); > > - spin_unlock_recursive(&d->page_alloc_lock); > - > free_staticmem_pages(page, 1, scrub_debug); > > + /* Add page on the resv_page_list *after* it has been freed. */ > + if ( !drop_dom_ref ) > + page_list_add_tail(page, &d->resv_page_list); ... the conditional used here. I cannot, however, figure why there is this conditional (and said part of the description also doesn't help me figure it out). As an aside: A title prefix of xen/arm: suggests you're mostly touching Arm code. But you're touching exclusively common code here. I for one would almost have skipped this patch (more than once) when deciding which ones (may) want me looking at them. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:44:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:44:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374668.606797 (Exim 4.92) (envelope-from ) id 1oG0Fx-0001ma-Mr; Mon, 25 Jul 2022 15:44:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374668.606797; Mon, 25 Jul 2022 15:44:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0Fx-0001mT-K1; Mon, 25 Jul 2022 15:44:29 +0000 Received: by outflank-mailman (input) for mailman id 374668; Mon, 25 Jul 2022 15:44:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0Fw-0001mN-2H for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:44:28 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2047.outbound.protection.outlook.com [40.107.22.47]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a9f96ce6-0c30-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 17:44:27 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3363.eurprd04.prod.outlook.com (2603:10a6:208:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Mon, 25 Jul 2022 15:44:25 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 15:44:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a9f96ce6-0c30-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ksdsU8/GehGDV5K7ScbwQ5vePzF8GrJoGPL3wJvJJ+xEKtmrgP+zwFkk588mAazzJizVhM4Rou7vFJ6oplJjDTIkukLVxkQBHRLBmqXSbjOQ0Jyj8IXfDFbV4paioCTKuePULWkFYmOjKf2L95x813Nt52UmF/DwlL8kGN+zNhwHfDP8Fwvg/onsL5R4YDX3UydW7m+jOAhetorykHOrTo1eoAeo00coZW4PHtrJuQZ7CbQMPmcIGkPb6LSY2ZMUu0sKroekElZk2krW3MXuUNXZQvjUnKFuc6OGTjGLy56L7bD8FlbLe+GTzGsMxy8wL7coqG32C0FhnNkEvo96Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7s0/1qJhReTgi4aCjoGoWe2iBVyXGcIRpJJdx8BiEvk=; b=MpfvyJAribaGS2jUGPwSujjZDvHKeBZVj/LV+5GWX69edlDvvrtw/hlgFX0/HpGl7XPNJPZ43gIsOEB2/4wVNCRLEWMBUqFF3BMpkJiXEmb2g028kN3toNmzu2FQBFYaWRr8FSjG6VnwnxPkmfqUZYHLafhkWj7lZI64Vv0EmvFQwuwlxYcgQaGFavZQW914naLToK0klakk36tR8vs5P2MexTvHo8GDT4+YR2avAcTzO5UuyxnGv6teYcFtkf0yOX+iogDZ09Odg6KZlmJHqJoGOEncMosXh4AaWlspWUhgqQo092qHc9QJ5YElTqcVtUdmCEGbAxpnNElUQCp3CA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7s0/1qJhReTgi4aCjoGoWe2iBVyXGcIRpJJdx8BiEvk=; b=yaPfXODtSAlibzxX3Obvs4TXMv3dg0+oE7tJseT9PV+QGuueLHZ8BSzBA3ujTBl1HGfhs9dbSKZJGlt445eQXafOi5ex8l4lywtxc3fRps+ZEOKu5vHGhvrGbmkhZmw93F67wMlV8sOdBQZ4w+kVbMZFW9OIVZ19vadkc+LqOJH4KyaDudqmheGM3fhm7jFcWNckJGkM/ZYO2XSq+/5V6GOdzmVxvmqUsPzssvbrjBfbTp9kt8TiL8iDlpqeiz+cx9Y+8YGn9k/g0CsQkW+LE1BMCeFytSy5+khc8vBCvEdnkLzhdop9L8GUCztXtkHFzuJaN3e3z73oynvSHyKbnw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Mon, 25 Jul 2022 17:44:23 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 8/8] xen: retrieve reserved pages on populate_physmap Content-Language: en-US To: Penny Zheng Cc: wei.chen@arm.com, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-9-Penny.Zheng@arm.com> From: Jan Beulich In-Reply-To: <20220720054611.2695787-9-Penny.Zheng@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cfbdd267-5ae6-4e8e-20f9-08da6e548d15 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3363:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8SXxOj0STEM+s7gnP2Rr53aPmpPwqkZ4iCKTSUs55sSWVRGSkLgsfIzMp2tooOXOcrXTwCiiWsmB201OjWNJuHk5LU6XQ2UQwCTutPGzwc+bF05+pXjjpSjg6StPFtkjf5rnO+5DhgP7gs2aWGZT/OERFjUhRO8f6Yfyeei/WVFE0yjSeVSN7MkOJKw8aYJGkFVydCnDbzIPhjB5ojXKKmOIXdNFm2y40Ecm83zMZSLougrncqf6IZk/GeHB4xHQM0/W7tiVjiD7oMFqF1MuG2J3g9aRsjYmpRe/eLmxxZso7D0gaVvbD4KElja6HEAl2WxkH+uNT6rayT4nwIjJaj+KXgwjnlYPqO3GA6yVr2WXKFnfGVe1iy4VejI4FR+HM19lCXwfvpXV25QIO3qnBk2BzaVTeRc3tJ2nK74iMlreiDWGoyqBkj39DjQ58/silOKP3UEykyXP5mvg6cvhC5o73OW54GZkdoa1Q/pIOLGwnJpMO1LA+uLAPv/KwNO48cnkqCJOR/CIZnMNpL+ntpPELzHRFClgXbkuOatTOcvI0BWnaXeZcta3KAdi1nfh0NRYk4KdkGG7tFOIZeI+KvQBsqSSFjoV6Bl/tY4uD/7TncybQ7QSDwfi5jirKi7NblsbJPIJpNA4dveE89VY4zdUgtnu2Hcj6wL5GwpjhG5L3epY64+V4xUHNTyEX67jZiV1szsrRP2dGpRpMXY2PS5zPO0bNF/kYxgYhRDIMh/w6lgXTCwFjyOZ0Uck5ucXbW4EhENa2PVjibopu8Ov3DK0fTWEl0isuzFPhUKOllcZo14lT1xXtDu/PtJiPSCBDcVM3JTcu6FNzTaG8E3N6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(366004)(346002)(376002)(2616005)(38100700002)(41300700001)(66946007)(4326008)(186003)(26005)(31686004)(6512007)(478600001)(2906002)(36756003)(83380400001)(6486002)(54906003)(8676002)(6506007)(66556008)(86362001)(316002)(5660300002)(8936002)(6916009)(31696002)(66476007)(53546011)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U3NsMDJCdGRIblB0bHNxTHM2SEZ6QTNzaTlZbHR6QjFMbFV1bUVaVEJZRDBK?= =?utf-8?B?RWhyT2tEZDV6bkl0ZVNVNE8wbWl5cW1YZlhRTnEvVU83TzNLTzc0aTMxZ0Nv?= =?utf-8?B?aFZrV1dBTERFM0ttaWVYSjh6V2RwL2dDVFp1V3dsWHU3TXJvSTM2U0laOSty?= =?utf-8?B?YlJLWStyYnJEQm5wQXZVRGg4WlB2dUVGZGFZM3l2Q1lxbS9IQ0hZQ3VWTm9K?= =?utf-8?B?UGY3NjFuUHg2Yi9ibWhodHlwaU9BQXN5ZnhqdDRtdkF6NTNWVjRScEJNSXJs?= =?utf-8?B?TVEzSHZEcGdidXNycGNoUnhCNXBXTzl4QXdZK0s1K2dNd2lNVlRVV2Y1eXpT?= =?utf-8?B?YXNhZ2g0eURlNzhkcEdRcFc4SXNBclBnM01TMHRGSThzK0NWZEFNOFYwVW1h?= =?utf-8?B?S000L3lHTy94Z1VHR0VZbUhzWFBVamVURHBQNnI2U2pUUFQvbUlsK0RmNFpn?= =?utf-8?B?S2M1NHBHU3JNTmZ6SkswZUxobG9OejhKa3BTREpuREptYUZvbFdNRDFYUm1U?= =?utf-8?B?OTlQQVg4Q1R6b096OFFVNEs1d2I4TnFEbFFiV0dWdTM3QkRVWURmYWZGQnF4?= =?utf-8?B?dXJCbFVlcHc2dExlejNRczEzMlVhaGt4aGdVZDc3MDhDWllUbEk5TkxFNjQ4?= =?utf-8?B?VjV5MWQyOEFXdzlOd1VKaWdqZ1RwM0J5QjQyRDZLc29vL0ZON0hHVU1pNnBF?= =?utf-8?B?enNSWkJSQWZhaitVbWxxS3ppOTM0anYyTVJBa1JoTUh4QVB5V2lncU1BUVZH?= =?utf-8?B?dHkrWUd3cWcydC81STh3REozOWpSS2srcGpzeGV4eXhhTkg5SXNralpleGFr?= =?utf-8?B?WXVrNEhROXZTWmhjSlVXVXd0U2RoRVdqbGVQNWN0VDJnTmMrUDF0QWZENGVs?= =?utf-8?B?WnBJb0VDWitSS2E2a29vdmJpNm1vQytkSjNMOS9HSUx1M0ZtWWNXMm8rUVMz?= =?utf-8?B?VTc2MEowdlRNU2RVUWtGbVhMQ3lvTWhtWUFhNnlCK3dOWWRWQm43dS9LajRQ?= =?utf-8?B?ZG92RDlDVnBJWXEwNWJDTzE0SGRUNzNFUjFndnNoakM1cmk4TURDSHBGQnRh?= =?utf-8?B?VG9xdVdJdmZmVFEwYURZZGRid3pZb2pSdDBNRyt1V0ZnMkwwelpXbjR2Y0Fj?= =?utf-8?B?M3BqR3BNY0pDWndMaVducjQzUHMxTWIxYjJtTUdwOEZUS2NqR3kzbFJ0VnFp?= =?utf-8?B?UzdVSTN5S1lVQlpDbEh2Rno5b1l5WThNTmhlOHN1K3F6MGw4czNxUzRFWXAz?= =?utf-8?B?VWxiZjRKZHY3MjhpUW9adTFrcC8veEFjMDE1azlHQ05ud3Bnd2ZPUWVOM2VU?= =?utf-8?B?SUFqcEhCakhxbXlhV2ZqZUU2RklESWFsVnRjdDk1dWY4QzlqYlhYUWxBUkNm?= =?utf-8?B?YXpKS2xLVFlhcUxTQm5JRTI2YjlEVUxVWlVSU0l1dDhWdTBWblYzWEVsL2x5?= =?utf-8?B?SG5zcCtkOFQzZlg3ellTN2xVT0pmdTA1dm1mMlFtOWpPbCtneGl5cUIxMHVW?= =?utf-8?B?ZDNYMWNmU0YzT254VVBXZ1RlR1c1QUNBT1gxaHhxQTBMQ1BGSXRwOFBDMFBV?= =?utf-8?B?Q21SZkpGMExmZHdCTEQ1YkpmTnFpSVRBSVlVVkNpL1F3RnprYlBEdnNhd2JM?= =?utf-8?B?cWNyNGF3alRSOHBiQzArSlV6MHhxdWg2dmsxNTZCUFpPUUYxZlZDbVZ3V25t?= =?utf-8?B?ZWZRdXNlcVRGTTQwc0Nqc1c3dmtWQnpHdm52bkFrd2RoVkRHSWR0OXUwSnp5?= =?utf-8?B?Z3drTDF2U3pkMGo0cDdDR0ZlSVBPMGxtaGVUU29ITW42Yk1uSDBIVSs0bzRY?= =?utf-8?B?MFJpbWpZL1BBU3AzMWhWWmlEb3pXWGxaYWxRL3EvMVRoVGIxc254Q2s0Q0V4?= =?utf-8?B?dVE0c21jcmtiODljMXViRmVZbXpLL0xWN3BGaGhVeTBPQWFlQVBscVc0Qk9V?= =?utf-8?B?RU1oNXBOOG9XWDZSam1DcXg5L2h6cFE0UGJqQ0l0WXpTb2RrczhPZnlSWTJV?= =?utf-8?B?OE5IbXRrODB0WnFINkIrSTVhU012T3RTUm05K25uMWx6dnBqeVFsR1I3cnF6?= =?utf-8?B?MUQxVXVLVmFsSU14NXBmMWdLZFEwbVJFU3F0MzRIWUc4M2RQdEZ3dzE4Qkpw?= =?utf-8?Q?85lVPQwqepJVX2BBxb9Fv/z9q?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfbdd267-5ae6-4e8e-20f9-08da6e548d15 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:44:25.0876 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oB5B3T6SAX5KeIeDiWe1TwNVhYXwDOXUHPZrxYLMLigIslZ1lMLF/Us3+6juRHneYgPclZouPI7ST2SVVmFSUw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3363 On 20.07.2022 07:46, Penny Zheng wrote: > When a static domain populates memory through populate_physmap at runtime, > it shall retrieve reserved pages from resv_page_list to make sure that > guest RAM is still restricted in statically configured memory regions. > This commit also introduces a new helper acquire_reserved_page to make it work. > > Signed-off-by: Penny Zheng > --- > v9 changes: > - Use ASSERT_ALLOC_CONTEXT() in acquire_reserved_page > - Add free_staticmem_pages to undo prepare_staticmem_pages when > assign_domstatic_pages fails May I suggest to re-consider naming of the various functions? Undoing what "prepare" did by "free" is, well, counterintuitive. > +/* > + * Acquire a page from reserved page list(resv_page_list), when populating > + * memory for static domain on runtime. > + */ > +mfn_t acquire_reserved_page(struct domain *d, unsigned int memflags) > +{ > + struct page_info *page; > + > + ASSERT_ALLOC_CONTEXT(); > + > + /* Acquire a page from reserved page list(resv_page_list). */ > + spin_lock(&d->page_alloc_lock); > + page = page_list_remove_head(&d->resv_page_list); > + spin_unlock(&d->page_alloc_lock); > + if ( unlikely(!page) ) > + return INVALID_MFN; > + > + if ( !prepare_staticmem_pages(page, 1, memflags) ) > + goto fail; > + > + if ( assign_domstatic_pages(d, page, 1, memflags) ) > + goto fail_assign; > + > + return page_to_mfn(page); > + > + fail_assign: > + free_staticmem_pages(page, 1, memflags & MEMF_no_scrub); > + fail: > + page_list_add_tail(page, &d->resv_page_list); > + return INVALID_MFN; > +} What about locking on this error path? Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:51:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:51:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374677.606808 (Exim 4.92) (envelope-from ) id 1oG0MU-0003Jp-Db; Mon, 25 Jul 2022 15:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374677.606808; Mon, 25 Jul 2022 15:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0MU-0003Ji-B2; Mon, 25 Jul 2022 15:51:14 +0000 Received: by outflank-mailman (input) for mailman id 374677; Mon, 25 Jul 2022 15:51:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0MT-0003Jc-Nr for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:51:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80041.outbound.protection.outlook.com [40.107.8.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9ba90d2f-0c31-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 17:51:12 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM9PR04MB8440.eurprd04.prod.outlook.com (2603:10a6:20b:413::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 15:51:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 15:51:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9ba90d2f-0c31-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q1kIGimLJ0RVj08ry9lciV+2tMKih4we+f4I9w5hMmjUJpFLrh+aVq9wzxHGBAUJEKIZmI0sHhgkvIaJxvCzjX8qb+fPTpSVapgw6lanMsWObK3sceLB4sM94Il6GKLLipDy1ikmU8nVXTPj9sruE2syS/5o5fL/Wqt9Cx2Aeze247wwJSa9dgW/fMez72U2OxZ6PbzE/Dt69sSSjwvhdkDqeBU4pM2b3X0nhTAcWX8t8sA2av8vTujhDKWTwrBoB7KrP7K1tRLHQQ5L5+w2Tl00+dGs9crHctIAyTT6cQXYiEXjJFS+uSDBLb3Pf+7Oh0dlnIdqKJ90/522zlTjxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RY3QNhx7VpzFe+yo2jhRa4wL68B+R3JENc19j9hx+1M=; b=Xl65RQ/n9Wo70Ed13Cz02AJw1qZtbAIx6VAmnl5LSED0CqUAPZbQVTOUc3tZ3xasn+VwdNTi+d9mi5t76bHIEA5/MqZkMlVUEEpBHmObbA+GBfV/TfdfXD7uP1lPOLJLGnHsK1OyuSSL9Lpm1/RwCqwXBxM/VM+9lyJVLfTQsC1vpuuVgLV3dAvKEDSP6oG5PKvRIUxjlSBEbH5gIbjI/qL90lxOQLVjnmM6wOR+HVcAjdhEnpu6q11QPK0jHqU3X7JheGvchmvvkoGL7Q0DPB9QQ+P1mSj93SrSwh11BVDantFnmydOj/QuFPP0ptjg860pCanA/hCzeIg4o2IHUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RY3QNhx7VpzFe+yo2jhRa4wL68B+R3JENc19j9hx+1M=; b=lWwRa+m17q+tgSYUT1abUdIs4A8mJBBZDH7e0F0piNHiKgTDZMVOIYUy9oZ71JHFvZB013aSZBlRIu35pyXeSXHFLYoF1XGYxcnEseoFH2SHrfby8DB4bwSIvk3iEoskUovpaj2DgzvkSMttfVhCygS9Yt/82pY80WuDzeONaXxXPPSJI33BJPcIOlgr4MvW8XQ+Mf1EAmfZ+p3ynqbKiUz6PzcP11iB79KRY2tpiaz4hHkk+2qhS4yp/MVAFAA9tKjXY0ubn8MzUKo1uIqh2Mr39K2XXfwIFSFsunWkLK+Iz9DxgSuxRUvFShAzq+F6caNl3X/sfwyQn5wRbSwwug== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <414dcf57-b18f-8a88-b143-e275b5311079@suse.com> Date: Mon, 25 Jul 2022 17:51:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... Content-Language: en-US To: Julien Grall Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-4-julien@xen.org> From: Jan Beulich In-Reply-To: <20220720184459.51582-4-julien@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0051.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d887ccd3-e3dd-46aa-4b18-08da6e557e77 X-MS-TrafficTypeDiagnostic: AM9PR04MB8440:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xm4O2oXN9bTj0wZhHy1X8CZvst0hPWzl+KWNgr/75p+4BOiCckwBtGLRnBgFpjjJ0wMi+SjsXHIN9q8dkoV2M2FjPsUvHkea9Og8d7gO2X4uh5zdIGWrqIWgTQrvsPdbFnbny30ZxPiG71+TVsoj6heM+lrDjh/ze0fOmker38vHJQhpsJyhLaLHwjOxpXJNUYJeAklGH077ImUqh6+nIbiDvzWefrQYUvIK6wosiO6+w7VGniRaq6INlgnLKgYdZiBGXgIde3Zo1ZVXYn+xvcBecKqjT3MH6XyMegFQnREvnMlzbp7BmGoqxReq1WqnpoR2FzwSIGUumDwTkOEmETGnSMn4A6C02+OgteCYJe5rOkIACLx+8Hq24ySRoiFRobD6T8C4cubozBS6hrmOhMDz21MJr/71mi5qThtjrmMmIMyrefviXNLANnJW4klYBXR7YUvQ29KNIAd79XRKKG5LmVLiS1LInQMGf5SQix8PNeGVUu9diknnoU4AKTO39ZuBIylFXtDZWdlF9bN3C4/ZQj7Jq8h3nPl45R7NX/TunNxKqOQUhhh49Y+VNClbB34qpohqZJFBca7K26yRauICraREQXky1dciTzWqSijgz9e/n6zhyAnQXMYrzp/aC8ibImgZ/20KIlNqFmk1JslzqTovpF98lOj/1sMMczw0T0FVnEiIOsTIs+qqWUeyJGGOyYTi4ZuXRft0QvtJ2MRr7sGAlODH+zskPDnBJ2VLrGOtLDWrED64MRWDqoSIy6Zu/BZj9+zxov7OP0KkkAFgWqjyeCWBRLyTTIsILqLzpqVFVFGa2eo1KO0mBIOWsQ3ab48P2ZIc/oqcCCvvVA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(376002)(346002)(39860400002)(396003)(366004)(186003)(2906002)(6506007)(53546011)(8936002)(41300700001)(4744005)(7416002)(5660300002)(2616005)(86362001)(31696002)(26005)(6512007)(478600001)(6486002)(54906003)(6916009)(316002)(36756003)(38100700002)(66556008)(66476007)(31686004)(66946007)(8676002)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUR4ajhjVGhkQks0SS9CSVRMYkRQK0dxUU1CalJFN1ZhTXJ1Q01USmdSTkJa?= =?utf-8?B?K2QzQU1RNFhYTEVzSGxGeGlscTAzekRuVk10Z3JlNTZGNFBXQlA2YXdYa1F6?= =?utf-8?B?L0xYZkdaRXpBNnlUU3d2UVhQVEVtVS8vb0FMZ0cyaGpYRFQvSXFGSDl5dzdS?= =?utf-8?B?MDRLa295Yk9jQkEveFJNUjRwYUtMS1BrVFdnRmZROGsyTlpZVlRQbzh3b3cr?= =?utf-8?B?OW9RcUY0eUtETEIzcTNqNVJmamljZElQQ2lnU0RvbmxkTVIwQWI5YWtxd0Rp?= =?utf-8?B?cHAzL3BDazNJSDN0SERqY0pGYVlQTWIzVnMxcDJQdHNCZjVYNXc5anA5Nmo0?= =?utf-8?B?ZkJDdGh3RFBjUmxuZ0RFeXd1V0JmN2gvS3FtcGo1UElrcEV2Vk9VdVJ5MnVS?= =?utf-8?B?aVN1WHd3cTVsK0dDTEdLbk1oZ1RMK2FzSm1MRnVPOHhDMjBWMSs2eDlHbXYy?= =?utf-8?B?TXA2d0Q3TnZFUmFkdGo0bEJiZTRsVWpJTWg3UE9ic05Ndjg1cUkwbTJHN0Fy?= =?utf-8?B?U1NnV2hkWnpvR3ZaYnNEWjk0Z0NnQkpSOU9SOEtpTXJ2WEw1ZDFUdDZqZHhu?= =?utf-8?B?bUU3eTEvTnUxRXBBOWRUblpEVHZER2t2UHVkRzUyRzJXU1Nya1gxUTlZb1J3?= =?utf-8?B?L1JFSVh6b002dk1lRCtmajhGdFZkMGV5aGcvRmdPQ2p6TzA1dzhaZGtqWEFS?= =?utf-8?B?RlRmZzJveHNXUzB6a3pmNHpjQmJzcXgwYVAvcWdLOTBKdlV0eHJXcFk4N3lh?= =?utf-8?B?c2NTd0tTMUM2ajBaTGluTTk2Yll5Yyt1WFFqd2t4aTBIUTM0blluZkNxdnVz?= =?utf-8?B?Q25SbzRVbndobVcyb0JuOWJhWmtlcEd4SmJKV1lxYjFXOWZjVmZtb25KMXlT?= =?utf-8?B?M1B0d1hRa2hzcVBYa3JUd1hER2dmajVHaWk5alFNMzlXWWx1OGtOUVFxR013?= =?utf-8?B?ZlNMQmVUb3JYVFJ6dUViSkF2Ly80SWpxWnlhWXQvY0VpczBsRmZ4c3g4MUhN?= =?utf-8?B?N1VCQ3p6eU1vakZaRDB6WmhZMU9QMSs4QnJFVXpHOXVjcDYySi96SUEwZ0Fj?= =?utf-8?B?YkJPdmZxVzFCQ013NVVsR2hIVVlJZlljYVBoZG9xL2tHNFBZVk1CUkh4empp?= =?utf-8?B?SXRrMXlFY0JZdE9DYi9kMUZGNXdVemwycVR2czBXVStOTkNaTzZ5RTA0MVRs?= =?utf-8?B?bEdPazdlN0w1MVJsYnJDdWt4U3ptREdDMGpsQzdndXdzNDNvNm5kUkpsMmpD?= =?utf-8?B?RDVrbEcwMm16NTgyaEg3S09zQXVvWk1zU3JLN3htWnZxcUlMOGt3S0NLN3NG?= =?utf-8?B?a2VDa21aNzdVOVU2M0VWdHEwM2ZjS1N1SjF6blp4Ry9XSzFZemFRT3VlaURM?= =?utf-8?B?d2dIaWpLVkYwVlRDOTY4WVFzME9xY25CSGpSQ2JHbzlpZjNpTUs3aXlFUjI1?= =?utf-8?B?SXFDVlVwZXJEaGhtc3ZUS0FJWFlIcksvaVdURVRURDNKbmh0VnVKbG1aSWJL?= =?utf-8?B?cnBpWXBlOFBQMW9vbjg4OFVWdVU3R2VlZktCSm5LYjd3UWYrUjhGeG1iWXBn?= =?utf-8?B?NTJjdHAvYVUyMFRyY2hoQW1DeDI4ZkVJZjRiVTFoY3NKTGZHNWwxc1FKb3ps?= =?utf-8?B?OVdaSlNHcUQvaGFKSzdSTnVaakFWTkt5eGcxOU1wVHRpUlpiSVFQdTZsQW1O?= =?utf-8?B?NmM4TE8vMjNDSHFvNlB3cGtNejlQUjhwbTQ2dFMvMlJwWEYva214bVFmMHRK?= =?utf-8?B?V2h3aDBxUUlZZFg5L29SUVY5dFZDelN0aUtaZ3QzQms0ckN3OEdrVEgzRnhK?= =?utf-8?B?SGxieENMczN4T0pZckVKR3ZjZy81b05RRFhFaUVROTZiK250U2g1YWZrZi9p?= =?utf-8?B?VHRVZDBTb3BZNkVYM1NUY0RaRGpoTlRYNml4YU1BWnlXVjFwc3NzVlM4K0o4?= =?utf-8?B?NDhzWmNUUE1rODV5MnUxdjE5c3BEMDlITzFLRlIyQUU3VytDelZ5SXZDQ0M1?= =?utf-8?B?aUE4SmwvdUg5QzhEdFRNUDNoajdnc2VabzVITTR3ZzFpQVoydDlGOVZqVE5X?= =?utf-8?B?LzJIZUU4Qm02eHM5eW96L2FIN3hhenFzeGtqK3NSUHo5NXdqOGQvZzZmOGNx?= =?utf-8?Q?W25QzQQ6m/qfFXS47A+WLX2V1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d887ccd3-e3dd-46aa-4b18-08da6e557e77 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:51:10.0619 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3r0Dcu5LBSJ39c6/hTZ4N/WDJbljlocWLGNWXaNlMeOtxV6a5w6Fi33vGu0YkXSA/I17Cm2QeJGcFAQISQvigg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8440 On 20.07.2022 20:44, Julien Grall wrote: > From: Julien Grall > > move it to Kconfig. > > The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide > helpers to map/unmap a domain page. Rename it to the define to > CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove > support for domain page (this is not a concept that Xen can't get > away with). Especially the part in parentheses reads odd, if not backwards. > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -371,7 +371,7 @@ void clear_fixmap(unsigned int map) > BUG_ON(res != 0); > } > > -#ifdef CONFIG_DOMAIN_PAGE > +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE > /* > * Prepare the area that will be used to map domheap pages. They are > * mapped in 2MB chunks, so we need to allocate the page-tables up to What about the other #ifdef in build_assertions()? With that also converted (and preferably with the description adjusted) Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 15:52:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 15:52:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374683.606820 (Exim 4.92) (envelope-from ) id 1oG0NF-0003pO-Ou; Mon, 25 Jul 2022 15:52:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374683.606820; Mon, 25 Jul 2022 15:52:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0NF-0003pH-Lm; Mon, 25 Jul 2022 15:52:01 +0000 Received: by outflank-mailman (input) for mailman id 374683; Mon, 25 Jul 2022 15:52:00 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0NE-0003jA-43 for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 15:52:00 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140085.outbound.protection.outlook.com [40.107.14.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b7084c4f-0c31-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 17:51:58 +0200 (CEST) Received: from AM6P195CA0016.EURP195.PROD.OUTLOOK.COM (2603:10a6:209:81::29) by AS4PR08MB7758.eurprd08.prod.outlook.com (2603:10a6:20b:515::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Mon, 25 Jul 2022 15:51:56 +0000 Received: from AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:81:cafe::a7) by AM6P195CA0016.outlook.office365.com (2603:10a6:209:81::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18 via Frontend Transport; Mon, 25 Jul 2022 15:51:56 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT026.mail.protection.outlook.com (10.152.16.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Mon, 25 Jul 2022 15:51:56 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Mon, 25 Jul 2022 15:51:56 +0000 Received: from e4ba0395712b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A4722A5-B0C9-4352-8514-E676B0CBBCE1.1; Mon, 25 Jul 2022 15:51:48 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e4ba0395712b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 25 Jul 2022 15:51:48 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by HE1PR0802MB2281.eurprd08.prod.outlook.com (2603:10a6:3:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 15:51:46 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5438.026; Mon, 25 Jul 2022 15:51:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b7084c4f-0c31-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ih5y2lz/J7QifjnWNGRMDmQSOwo6A5YXabHTc2O7P9pufJNuS9e8d3dEi2/nNcNm4s2vpQKpDpjqHw5tLFM/CUbn6lYr5IpS3vrwUa9EvIMWvJSUwUVQJx8A19evTy69mTbRo5mMYTz8uq+uIK9wb/vc/3B/mnvJIcDsmECT1LXsQnRsfP1E678zrgm9ZvnpNrZLAPzM69F0VBE8FYmguiJ7yD6y0fNGnty2aavh3BhC0eK1euVNza8WZt+Bo18UIKyyH5ksp6k0etQYKDnAfIIPLgazc8xgBOxT21L2/QRV46rRYNXsn7BdlBKhPw7ki7nEViqLMKArvzkeKQkEFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vPlSXKsfflmUNxZ8WYhL1yB5p1uk9h6zIXGh2wIUor0=; b=of+e83822KmW6SxSCECuMoy/NqAGv+MXRXkMQAhdjz+gxApniYFTC/E7msL1+wFjBTHROx+yIrMITE9tSGuzjPIytha2shfk+F0xQdU5d8t+xQ2lLyrmB00AhfwDd3cWsnoovJqHbx+hwO23D4Pg5GWI9jntOYjFg3dGVA/gNNzAva9aBvOguDg1J2TftnceO4BhqbORXxUi8VVMHkZsqppvsSWlAhtPpgOLDznrFSSLDbkiBbASO3f7Wk0cc+9iFe0+QASeKMFwp91VHfUJGgzCdIoqf5NMmkBjsMDRxtAdHLbG8uIeeMxenzf2g2+DDYANa4TG+RxagneGXJZa9g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPlSXKsfflmUNxZ8WYhL1yB5p1uk9h6zIXGh2wIUor0=; b=2h/cjaFZXi/a+PVtNw7BvVDBDyfGgBgtXPMSXzIyqrq59eYfQr6RwYxkLT18Mr+K7X8EaakyK0FGrpgB+Jlk63LF7fna+YGMmuEDaJ1OeORAGrZmX9aA2KBhePw4fO4vKgRWSDnXNMtQbiNMxp299BomnILbcFemd4lZQcdnAms= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bf49dd52388c20b9 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WZ5j6cn+fdrqDtoh/8bSM86igy080RH38Fi+iLe1OYxFPvOm1nc0omPg1T7pSk1FfpwgMaHb1eUju3aR1usT6JTh7ZJQ0u8p4ZJeEznsxrng6BWzKVhqezXtl4hC/fl9SlgSZDhl18nRE0BUIf0vMRaqSM3LL1DRXpUe6VjU3QEnJQ6qvERbXIMa0Q2GleQcLfRfkH7GVHihUDiWUjj95vGv3J5mwTrzRaKkI7JkSpbtBkzx32ZIpnF0fIPorabfMdkjH1Kg130gxo1w9Z9uuUPEVKbZ9adf0Cn1WcGe+/PgIeGtcaI1HQIE9Bbikl9ydV+h+kI3LG2WziHXXNwmmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vPlSXKsfflmUNxZ8WYhL1yB5p1uk9h6zIXGh2wIUor0=; b=Ye9QdmspcQclVUMFjNh1qYCIFiOlGjzAT+THV7GzJKhO1HG1KEyNsHys42U8OhPFjk39/f4hO6HhkKkIrrLYH50prS9f0zZiXzInidu9hxIoI7PHu2mLKt2EDaQq5IwWevxHkzi+WMZ4oV5srVWFhTUCtiwKitRmVLtu30Rvn53CWLIihaO8FkC46jfnjp2mmmlfg7hiDTpUTZ1MOavRq9iK0vMLv5WMECYZRuL9DK2fLQv0cC++V3JLmg3zgISnlLsxa9duy5jKEbXpGBxOQEGxEkpUgZPmxB6uEJyiq4V2hQnWJUY2z8l+MlmT6hPAdmhe1+oBMHySrI01oZxKuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vPlSXKsfflmUNxZ8WYhL1yB5p1uk9h6zIXGh2wIUor0=; b=2h/cjaFZXi/a+PVtNw7BvVDBDyfGgBgtXPMSXzIyqrq59eYfQr6RwYxkLT18Mr+K7X8EaakyK0FGrpgB+Jlk63LF7fna+YGMmuEDaJ1OeORAGrZmX9aA2KBhePw4fO4vKgRWSDnXNMtQbiNMxp299BomnILbcFemd4lZQcdnAms= From: Bertrand Marquis To: xen-devel CC: Jan Beulich , Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Random crash during guest start on x86 Thread-Topic: Random crash during guest start on x86 Thread-Index: AQHYoD5xlH8T1cfPDEKhJmKe7Gw5BA== Date: Mon, 25 Jul 2022 15:51:45 +0000 Message-ID: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 194214bd-78a2-47c3-e31b-08da6e559a05 x-ms-traffictypediagnostic: HE1PR0802MB2281:EE_|AM5EUR03FT026:EE_|AS4PR08MB7758:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +OGb+UPpMtXuqQ+E8KdY1Smx9mY6S/IE8OCCn3Z1+Bx76RaiuuvmSNxBVuzvPSVnxsc0pqlcX9W91DT1M/+Z0QvN7bfiQ0BzGRw9+08SVRo5sXuY6XcKFk9AOLIt/uxeG+zGKA5/G24ETrhpqIS1y42du3e+jnBGojlttZVHsRmY79mQDacSOq/n8EkK126unSAUAzg1oQBbvNwD1EODX5denSK3ArvrPCcsuezobko/WolapMTUVVI69eopAOPGmR0fNCsR/3MUOySecgPJyU4HLHllpJF29QKx4U5ZoYoYorsMnjhZhxPI2ChI42fPJkaUu2IUg97+MGQ6b+h3tttGPpAHAeERbVZaL58eT2yfZF8FtQlHMpig8RuZHqY3r3py9Y+9fEHmsf2OC/RQi/WecIahNpmMpg6JIgeZ5d3pSOPcJvzJ8kXj49unbCU/5E0DRK3v2JDlrs1+5r52fYVhTTzlsSlSwmcijccmZBUGROwqOpe/JZlM0Kio+dGYlmdt9PalbhZkStWVOOj3Kpj5i3IKYkfaTEhfx7AM3ZCvojmewhVCOQjn8x2x21oCkTv5jN+fq/knfG2F7Jp7PaFeUzZE6rkuayXhbEyuoifOVy4zZbXBLWhaaRVi+sbcL8p1zZSCkhEJg92i2rVnB622tGriV8T88jhUF/mLSzXUcVfqL+PMiXHv2Ies/w28LW5zLlHDcDsO2E8Eq9Qi4cn7NixxFQc7I53kE9ah8HyqYeG4ZZdtaSW+OLNAsrLSYJ08Qm2iVWmyDG3Iu8zgABOc/fL/8Gh7Zl34m8ERyZ9mknCIBzQJcY7HLgRt7qjzi1MSmmSasCCg7dfVRq5Y/g== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(366004)(346002)(396003)(66556008)(83380400001)(38070700005)(66946007)(91956017)(38100700002)(122000001)(66476007)(76116006)(66446008)(5660300002)(54906003)(8676002)(4326008)(6916009)(30864003)(186003)(6512007)(2906002)(316002)(2616005)(26005)(478600001)(6486002)(8936002)(45080400002)(86362001)(41300700001)(6506007)(64756008)(71200400001)(33656002)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <5717D13B01FF8E4CA0E065CB35038E29@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0802MB2281 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6e4b6203-7054-475f-18b5-08da6e5593e8 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8PjvkyWqaB72w0VeKFGYyrCXkzwomV+vsvjRn3u2kQvQiHYYNqUUEy9aIcV1ROvC/HkL7oacfUVwjGRiyCF2cmwcDHsIsfD26kWtcYoTADZO6X2YOrUn3FSuZkKpbkr8CVbsoqrURubF7czDAA/0hEV/T1A/B6Do0TEfXmc/H+3OUEgB8YJq9pWGpkIxfvCfA26lpjF3TT+EeXeaRI+8dHypjVUEGVCuht2Q66PHCKeiG3PLF55PRf/m2NYulHON2yB76FEiu6kQhk0EOQAACq7XNQD5ZPVTBUnZ2pna+Re9wDEQikyHUWGRVQYCghLq7dFx3v+yT0B4MQB14zebxqlQLDFvTlZagFpWFpaOzhzFWoqYfO1g125YbQpKYzpGUD84ne108tENH3PerZAX9CPYfj29ERdwceH8mwVCeh/Jdd3N598gk0eO5NxxaDCkn9RtMCcOTUoNRSOqgCtxMpHBcWtCKucCdFgwirJ42F0lrUy63PZI4gT5xf1tO4dWXAFqKJCAz2f/KEfQeZ6EKZYBEigyIsFEfP2GPNI7N3ADUk2/Wrl886/cpzn8ofvDOuEvwU8NslFEqbI4C701ETR2Ti6+Ot4UyXdxeuvdBtIiP9a0WvTNF3Jn6UMieVHw89jkmU02dkP5rZjWrnOcdUQO3bI4oV8PAZHsXWYk/8V/F7xrofWW5AZ1zG9qMY1wh+9mYmXFBcsuv89WNEdNHhdZ0SebQMKgzPVsedPPgVJHD4nRi6g//0IqFZok8tgyR7oNwreVjORKeLgXwuHJQgiJxmos8RBjw4s8hnhKZ8Mk8hf93+DAV9VOjgqnCjah X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(136003)(346002)(39860400002)(396003)(46966006)(36840700001)(40470700004)(82310400005)(36860700001)(33656002)(40460700003)(86362001)(81166007)(356005)(478600001)(6486002)(8936002)(82740400003)(5660300002)(316002)(40480700001)(6916009)(70586007)(4326008)(70206006)(47076005)(336012)(36756003)(54906003)(2616005)(107886003)(186003)(83380400001)(8676002)(6506007)(6512007)(41300700001)(45080400002)(30864003)(2906002)(26005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 15:51:56.0917 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 194214bd-78a2-47c3-e31b-08da6e559a05 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7758 Hi, On our CI we have randomly a crash during guest boot on x86. We are running on qemu x86_64 using Xen staging. The crash is happening randomly (something like 1 out of 20 times). This is always happening on the first guest we start, we never got it after= first guest was successfully started. Please tell me if you need any other info. Here is the guest kernel log: [ 0.000000] Linux version 5.17.6 (@ip-100-64-206-234.eu-west-1.compute.i= nternal) (gcc (Ubuntu 11.2.0-19ubuntu1) 11.2.0, GNU ld (GNU Binutils for Ub= untu) 2.38) #1 SMP PREEMPT Mon Jul 25 14:54:50 UTC 2022 [ 0.000000] Command line: console=3Dhvc0 rdinit=3D/sbin/init [ 0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point= registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [ 0.000000] x86/fpu: Enabled xstate features 0x3, context size is 576 by= tes, using 'standard' format. [ 0.000000] signal: max sigframe size: 1520 [ 0.000000] ACPI in unprivileged domain disabled [ 0.000000] Released 0 page(s) [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] Xen: [mem 0x0000000000000000-0x000000000009ffff] usable [ 0.000000] Xen: [mem 0x00000000000a0000-0x00000000000fffff] reserved [ 0.000000] Xen: [mem 0x0000000000100000-0x000000001fffffff] usable [ 0.000000] NX (Execute Disable) protection: active [ 0.000000] DMI not present or invalid. [ 0.000000] Hypervisor detected: Xen PV [ 4.842670] tsc: Fast TSC calibration failed [ 4.842916] tsc: Detected 2799.922 MHz processor [ 4.845741] last_pfn =3D 0x20000 max_arch_pfn =3D 0x400000000 [ 4.845871] Disabled [ 4.845953] x86/PAT: MTRRs disabled, skipping PAT initialization too. [ 4.846227] x86/PAT: Configuration [0-7]: WB WT UC- UC WC WP UC UC= =20 [ 4.848955] Kernel/User page tables isolation: disabled on XEN PV. [ 5.214349] RAMDISK: [mem 0x03400000-0x04158fff] [ 5.221796] NUMA turned off [ 5.221926] Faking a node at [mem 0x0000000000000000-0x000000001fffffff] [ 5.222712] NODE_DATA(0) allocated [mem 0x1ff17000-0x1ff1afff] [ 5.374020] Zone ranges: [ 5.374146] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 5.374349] DMA32 [mem 0x0000000001000000-0x000000001fffffff] [ 5.374450] Normal empty [ 5.374562] Movable zone start for each node [ 5.374647] Early memory node ranges [ 5.374730] node 0: [mem 0x0000000000001000-0x000000000009ffff] [ 5.376184] node 0: [mem 0x0000000000100000-0x000000001fffffff] [ 5.376586] Initmem setup node 0 [mem 0x0000000000001000-0x000000001ffff= fff] [ 5.377581] On node 0, zone DMA: 1 pages in unavailable ranges [ 5.378034] On node 0, zone DMA: 96 pages in unavailable ranges [ 5.385508] p2m virtual area at (____ptrval____), size is 40000000 [ 6.156878] Remapped 0 page(s) [ 6.160205] smpboot: Allowing 1 CPUs, 0 hotplug CPUs [ 6.161126] PM: hibernation: Registered nosave memory: [mem 0x00000000-0= x00000fff] [ 6.161230] PM: hibernation: Registered nosave memory: [mem 0x000a0000-0= x000fffff] [ 6.161425] [mem 0x20000000-0xffffffff] available for PCI devices [ 6.161565] Booting kernel on Xen [ 6.161636] Xen version: 4.17-unstable (preserve-AD) [ 6.162085] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0= xffffffff, max_idle_ns: 1910969940391419 ns [ 6.179113] setup_percpu: NR_CPUS:64 nr_cpumask_bits:64 nr_cpu_ids:1 nr_= node_ids:1 [ 6.200627] percpu: Embedded 53 pages/cpu s179864 r8192 d29032 u2097152 [ 6.204411] Fallback order for Node 0: 0=20 [ 6.204883] Built 1 zonelists, mobility grouping on. Total pages: 12876= 8 [ 6.204954] Policy zone: DMA32 [ 6.205071] Kernel command line: console=3Dhvc0 rdinit=3D/sbin/init [ 6.211967] Dentry cache hash table entries: 65536 (order: 7, 524288 byt= es, linear) [ 6.214335] Inode-cache hash table entries: 32768 (order: 6, 262144 byte= s, linear) [ 6.220677] mem auto-init: stack:off, heap alloc:off, heap free:off [ 6.242643] Memory: 463112K/523900K available (16396K kernel code, 2697K= rwdata, 5140K rodata, 1380K init, 1032K bss, 60536K reserved, 0K cma-reser= ved) [ 6.250830] SLUB: HWalign=3D64, Order=3D0-3, MinObjects=3D0, CPUs=3D1, N= odes=3D1 [ 6.292059] Dynamic Preempt: voluntary [ 6.296486] rcu: Preemptible hierarchical RCU implementation. [ 6.296556] rcu: RCU event tracing is enabled. [ 6.296636] rcu: RCU restricting CPUs from NR_CPUS=3D64 to nr_cpu_ids= =3D1. [ 6.296805] Trampoline variant of Tasks RCU enabled. [ 6.296954] rcu: RCU calculated value of scheduler-enlistment delay is 1= 00 jiffies. [ 6.297045] rcu: Adjusting geometry for rcu_fanout_leaf=3D16, nr_cpu_ids= =3D1 [ 6.538636] Using NULL legacy PIC [ 6.538760] NR_IRQS: 4352, nr_irqs: 32, preallocated irqs: 0 [ 6.542021] xen:events: Using FIFO-based ABI [ 6.560876] random: get_random_bytes called from start_kernel+0x4a3/0x68= 0 with crng_init=3D0 [ 6.573619] Console: colour dummy device 80x25 [ 6.575908] printk: console [tty0] enabled [ 6.590639] printk: console [hvc0] enabled [ 6.592790] clocksource: xen: mask: 0xffffffffffffffff max_cycles: 0x1cd= 42e4dffb, max_idle_ns: 881590591483 ns [ 6.593865] installing Xen timer for CPU 0 [ 6.599636] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles:= 0x285bf6ea05e, max_idle_ns: 440795246805 ns [ 6.604322] Calibrating delay loop (skipped), value calculated using tim= er frequency.. 5599.84 BogoMIPS (lpj=3D2799922) [ 6.605421] pid_max: default: 32768 minimum: 301 [ 6.607341] LSM: Security Framework initializing [ 6.608878] SELinux: Initializing. [ 6.612563] Mount-cache hash table entries: 1024 (order: 1, 8192 bytes, = linear) [ 6.613569] Mountpoint-cache hash table entries: 1024 (order: 1, 8192 by= tes, linear) [ 6.646968] Last level iTLB entries: 4KB 0, 2MB 0, 4MB 0 [ 6.647269] Last level dTLB entries: 4KB 0, 2MB 0, 4MB 0, 1GB 0 [ 6.647785] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user= pointer sanitization [ 6.648329] Spectre V2 : Mitigation: Retpolines [ 6.648540] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB= on context switch [ 6.648854] Speculative Store Bypass: Vulnerable [ 6.649437] MDS: Vulnerable: Clear CPU buffers attempted, no microcode [ 6.679020] general protection fault, maybe for address 0x8800: 0000 [#1= ] PREEMPT SMP NOPTI [ 6.679020] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.6 #1 [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 = 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f= > 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e= 00fa7 [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000= 000eb [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000000= 00000 [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000000= 00000 [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000000= 00000 [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:= 0000000000000000 [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 00000000000= 50660 [ 6.679020] Call Trace: [ 6.679020] [ 6.679020] RIP: e030:native_irq_return_iret+0x0/0x2 [ 6.679020] Code: 41 5d 41 5c 5d 5b 41 5b 41 5a 41 59 41 58 58 59 5a 5e = 5f 48 83 c4 08 eb 0a 0f 1f 00 90 66 0f 1f 44 00 00 f6 44 24 20 04 75 02 <48= > cf 57 0f 01 f8 eb 12 0f 20 df 90 90 90 90 90 48 81 e7 ff e7 ff [ 6.679020] RSP: e02b:ffffffff82803b48 EFLAGS: 00000046 ORIG_RAX: 000000= 000000e030 [ 6.679020] RAX: 0000000000008800 RBX: ffffffff82803be0 RCX: ffffffff81e= 00f95 [ 6.679020] RDX: ffffffff81e00f94 RSI: ffffffff81e00f95 RDI: 00000000000= 000eb [ 6.679020] RBP: 00000000000000eb R08: 0000000090001f0f R09: 00000000000= 00007 [ 6.679020] R10: ffffffff81e00f94 R11: ffffffff8285a6c0 R12: 00000000000= 00000 [ 6.679020] R13: ffffffff81e00f94 R14: 0000000000000006 R15: 00000000000= 00006 [ 6.679020] ? asm_exc_general_protection+0x8/0x30 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 [ 6.679020] RIP: e030:insn_get_opcode.part.0+0xab/0x180 [ 6.679020] Code: 00 00 8b 43 4c a9 c0 07 08 00 0f 84 bf 00 00 00 c6 43 = 1c 01 31 c0 5b 5d c3 83 e2 03 be 01 00 00 00 eb b7 89 ef e8 65 e4 ff ff <89= > 43 4c a8 30 75 21 e9 8e 00 00 00 0f b6 7b 03 40 84 ff 75 73 8b [ 6.679020] RSP: e02b:ffffffff82803b70 EFLAGS: 00000246 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] insn_get_modrm+0x6c/0x120 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] insn_get_sib+0x40/0x80 [ 6.679020] insn_get_displacement+0x82/0x100 [ 6.679020] insn_decode+0xf8/0x100 [ 6.679020] optimize_nops+0x60/0x1e0 [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] ? native_iret+0x3/0x7 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 [ 6.679020] apply_alternatives+0x165/0x2e0 [ 6.679020] ? insn_get_opcode.part.0+0xab/0x180 [ 6.679020] ? insn_get_modrm+0x6c/0x120 [ 6.679020] ? rcu_nmi_enter+0x2b/0xf0 [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 [ 6.679020] ? irqentry_exit+0x29/0x30 [ 6.679020] ? exc_xen_hypervisor_callback+0x8/0x10 [ 6.679020] ? relocate_restore_code+0x22a/0x240 [ 6.679020] alternative_instructions+0x8b/0x13a [ 6.679020] check_bugs+0xa87/0xadf [ 6.679020] ? __get_locked_pte+0xa8/0xf0 [ 6.679020] start_kernel+0x64c/0x680 [ 6.679020] xen_start_kernel+0x592/0x59f [ 6.679020] startup_xen+0x3e/0x3e [ 6.679020] [ 6.679020] Modules linked in: [ 6.679020] ---[ end trace 0000000000000000 ]--- [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 = 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f= > 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e= 00fa7 [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000= 000eb [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000000= 00000 [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000000= 00000 [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000000= 00000 [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:= 0000000000000000 [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 00000000000= 50660 [ 6.679020] Kernel panic - not syncing: Attempted to kill the idle task! Cheers Bertrand From xen-devel-bounces@lists.xenproject.org Mon Jul 25 16:03:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 16:03:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374692.606831 (Exim 4.92) (envelope-from ) id 1oG0YP-00065B-VP; Mon, 25 Jul 2022 16:03:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374692.606831; Mon, 25 Jul 2022 16:03:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0YP-000654-SU; Mon, 25 Jul 2022 16:03:33 +0000 Received: by outflank-mailman (input) for mailman id 374692; Mon, 25 Jul 2022 16:03:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0YO-00064y-5M for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 16:03:32 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 52336e2f-0c33-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 18:03:29 +0200 (CEST) Received: from mail-co1nam11lp2176.outbound.protection.outlook.com (HELO NAM11-CO1-obe.outbound.protection.outlook.com) ([104.47.56.176]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2022 12:03:18 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5262.namprd03.prod.outlook.com (2603:10b6:208:1e9::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Mon, 25 Jul 2022 16:03:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 16:03:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52336e2f-0c33-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658765010; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=pNMvH64AehGK7iKjyFr51c29wHGMsDTBdiji2K2xWlA=; b=DBUnn+TMf6tU1zcyfic2OinVN7+da0EVRkJSgdtdBbjNIRvMgXE8pMmM 4TYB1MpkK8wGGEi8V6VEXEDpUB+ABaxHdcEhMj/IWdvTob2UzXfSI6R+1 e3JwSNh2puUOPVU9tj3nT0D3gbNLzx/aX96xozwAi6/BZSqyGax6rfSyQ s=; X-IronPort-RemoteIP: 104.47.56.176 X-IronPort-MID: 76370269 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9ZKI9Kl6QEIoWj97yQyaRejo5gy/J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIcXjvVPqrcNzbxctogPoXj80sP757QyNdnGQs5qXsxHiMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466v4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k5Iqo44btJBlhB0 qMmARw1ZAmnuuy5lefTpulE3qzPLeHNFaZG4zRL6micCvwrB5feX6/N+NlUmi8qgdxDFurfY MxfbidzaBPHYFtEPVJ/5JAWxb/0wCWgNWAG7gvK+8Lb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSz32beVw3KTtIQ6DK+y3/Nt3n2ox2FUUAAHVV22q+b+lRvrMz5YA wlOksY0loAY+Va3VND7U1udqWSdox8Hc9NKFqsx7wTl4rrZ5UOVC3YJShZFacc6r4kmSDoyz FiLktj1Qzt1v9W9S3iQ67OVpjOaIjUOICkJYipsZQkK+d74u6kokwnCCN1kFcaIYsbdHDjxx 3WBq3E4jrBK1MoTjfzkoxbAni6moYXPQkgt/ALLU2m57wR/Iom4e4iv7lud5vFFRGqEcmS8U LE/s5D2xIgz4VulzURhnM1l8GmV2su4 IronPort-HdrOrdr: A9a23:3bPdAqMh5podeMBcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76370269" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZuyiPnc1IVttW+HyxaL7KXpyAd5ePU2PUk6Jacj8p+CpKdd9OBRfIaNmYkGiPGzuR78bz47lzsLAPkLmf9cT7KCygwKz0cRw0l7i+0W4Lzv1QOw58dveI1Rfh8I5wbtPC5s0G5++ES2rcATkm+DFj6Zx5Kg4CDYw7lE5oAciv5DAfcfJdpUInV/h11WZjFIFLol5QsA/AcalbDMXma1gjMNWbf79veJG3iIozyK/+JGOxOAiNwtlr7hw+5akTDTOqyMajpeTJ4ORMbRl5TorcbNeWrIcOmcMrJRj2xyFisDKNwTGmO3UyzzYlseJXoFCve7wRwLpAZCgNYMVTHLSAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pNMvH64AehGK7iKjyFr51c29wHGMsDTBdiji2K2xWlA=; b=Fg8Ova7gCayvIDklFf3M0Q6NG8qXl3pWayP9cmoNBJzdcRisfSSbh6zIbOBk1MxEwTcRZ7OSxI9F7EvbiNKYe9umpqJFRTthEfqTWKgGC5V8ZTGN0Y72UJrqHApRXYFLO6WxZW2e6nQV/J3fst5hnP//E5R1J8fMkZ7Xoy27rX+8UyOUqHWghybBfDIgkAMsM9jwp3LN/Im2kkmaUSvFuxbrN0Gl6YUu/Fdg7R6RxC39ITTE4vjkW2MoUHn/UBw+IoRUh13u1qhvRkYvy5YF3CQhVduw85yl7dhG09LTSdJ4xtJnlGA6dQpjtt3PZgMm1ZGlAAavuOO88NDUi5ieZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pNMvH64AehGK7iKjyFr51c29wHGMsDTBdiji2K2xWlA=; b=gqZ9KE4LMtB1donLKIDGmZQub9Q4iDfzeMOmEDHo/H1uJVRz/IZpgy4CTmAadi6ECIuO303Qk0P2LdbUM7U7R9xeng9MWAnUqz7CA8DldrFBZxWExkOMy0uv4qYwQAdSjr7EJNmXqnpQwf6bdkyWQvHuKQ0gaVIaQGSwme1XA80= From: Andrew Cooper To: Bertrand Marquis , xen-devel CC: Jan Beulich , Roger Pau Monne , Juergen Gross Subject: Re: Random crash during guest start on x86 Thread-Topic: Random crash during guest start on x86 Thread-Index: AQHYoD5xlH8T1cfPDEKhJmKe7Gw5BK2PP42A Date: Mon, 25 Jul 2022 16:03:04 +0000 Message-ID: <7ba0f8dc-b495-d83c-4b2b-0b53d8b98ad4@citrix.com> References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> In-Reply-To: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ad202c3-5deb-4d20-ebb3-08da6e57284d x-ms-traffictypediagnostic: MN2PR03MB5262:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9ZfJRiZ1Zw002ExKIdaKNP4VAXnWINAxwmQduLZCMihylBcBsrR9qfUy+1ODEZHeqDPvaZxRG8j3VUzcjPbaZztifzX2urh8UcNLsQp2Ac7zIbtBrbwmdaZnbB8L9sjCGMaX4bCN4YnRDsPRNgcjft/891zGI06bX7LqyuAqXJZmWhjbF1fibVns8hyUSCjEb6BNAhshW26lphaMQiTrrgYAc6JTrv+uZhxA2rUoJqqQ48xcN2Ny5SCiMx1fRnfst/pKz55N3ljsLhGU/QR44xfARaZGENzpNLGQMVWwm+YMcvJT4TXFoeYwOkLDE7eO81vmX8uh+Kb+S8D0mtF241w+3Td3LWQWtTmdpyDnwAxtFqLPjWfy0tSV9ACs3HFc6KzVgsCUKS8Bes5J/wgvRK4BjvuglSqH6WPF3emH1AGDN2ucUtpAHVt/vvCR58vysMXGRr67fOWe4JOyGR6EtutV0IpSb8Jo7MJBJvL04ZH8PXHy4f6GbgQMtpiTfrDUevzieBNIY19FuSTbPfDe70Mltd3YiSnTscJc87mYSRhSEBBcgFlxBTDNu0i4lCxxRIUpwDQdVCy8pbbrUPUOwFsAEp5P2sLiYSX9wZGzD9yjeFeMeSXCrqNdLizorPXYGSYroiciBouPT/9Agr/ql1eHD8e0REcW7ImV/2JahbAYQ6fENhrtztUGD9jhZ/y9V/hldtyx+4Ose3+SnbIFkviz2Y3v9OP6QNv/OsjKFi/133UwY/xqDj7kKxF+6krUwYBfGzDgjByJp0hf+P6dSle6tVT5k6RCnvrrKZdS2g3GezBWEVpAlGPD12iEKUct7aec3/WK1xeaOezfd7VY/G5PkkenRsWEKC7u+gVYn39DT7Wew7Ko0BoSMlNytw81 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(82960400001)(122000001)(36756003)(54906003)(26005)(31686004)(110136005)(66556008)(8676002)(66946007)(66476007)(66446008)(316002)(91956017)(4326008)(38070700005)(76116006)(38100700002)(53546011)(86362001)(6506007)(31696002)(2616005)(8936002)(71200400001)(478600001)(6486002)(41300700001)(5660300002)(64756008)(186003)(83380400001)(6512007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TWFzNWtTc3VROHA0Zm45YmZCQktwTGtWOHYzTkNhWDBpZjJzZXRTSXpvQTdu?= =?utf-8?B?MEUzSEhVa2JqdUsvOTZvYXo3T2NyUjRqY05ZeWNSdWsrNjhQMjZDOVFpbmdH?= =?utf-8?B?Nkh0bXFYcWU2elBTN0x6SHZhNVV5ZlBDOHBIcHhxWnBsN2ZXZjQweVJIOUJs?= =?utf-8?B?TlpZRkQxSDBHK05wcFplVG11YzVoYVRCaWxpSlZOK3RPNFJPMC9XdDlMUnRF?= =?utf-8?B?NXFhTFZpeEwvZU53R1YxUjBJbmxJdWQzT05LanlOaGY1bVBGeWlNaTZoMXZH?= =?utf-8?B?cGpqVGxHb3VTOWxsb21EbjN1cFVHSXpheHdaeTl0QWRTYjZ2ZGwwRmxoSHhN?= =?utf-8?B?NTNESEJQV1VtazBMZUhGbFU2cnNqVXZnQUM2dGJnQ0tFWWlteG9qWGdBTVM0?= =?utf-8?B?VytKWDBnZlpXdnNySS9YWjVSTFNWZzIrei9IdEUvMFVBQUNoWlgzdm5oeUh3?= =?utf-8?B?aXpvaE14UTN0c2ZLcGJ6RWU4U0hUTWY3aWZyVldleGtjclFJUEl5SDRyWkh4?= =?utf-8?B?S2VPWlVaTTJ3Qmsyd2ZaSHQ0UXVUY1FrQk1hWjBKU1JEMXJEOERKN1lPY0Yr?= =?utf-8?B?OE4vb2Z1THhqSGhocXVRUlZOSk1Nait3MWppNzl2bENMQXZabHJvZWI0aVhJ?= =?utf-8?B?UnBldlIyNWowSndBYSs3RFpTYzNhR3krYmUyekZLV0hHamc1RnVRTnVVNmFh?= =?utf-8?B?M291aThJTnl3RlRDdkpPTFp0MndSUXBjcEMvQVl0VWMrOXBONnZPZTJzMmlh?= =?utf-8?B?Rm1waUhsOEJuY2NhdHlqb3hTY0tHYzAxa0IrUjhvZEpuR1ljSUdCalBVM0JZ?= =?utf-8?B?cVAwaitJM2dvSWdBU2YrQnhjbzk0c1Q0M0JMZFp6TW9Yd1FQVEIySUxpK3Iy?= =?utf-8?B?cEtoSzkrMlVyaHN2RnZLdEtFVEpUdjFZOGpua1MxaFlDYWU1TXZ2Zy9RZXp2?= =?utf-8?B?bHdXaEsxZ3c1VG91MFVBK21pbDNYb2FjYlp2bXVnWDEzcmE3bDdKazZwTGdS?= =?utf-8?B?VnJ4MGpzMHVKN2hpWWZXY3ZLWnhBWmc2OXJTdGJIeS9LT1gxbm41cktvYjRh?= =?utf-8?B?Mm1QUTA4a0ZBNDBmQWJzbDlHQ05JcWRHYlBEamRiSW5OYUJ3eTFJTHFrazB6?= =?utf-8?B?ZTdaMlBpVkdmdWZKSTZXNStEcmtYWGFDYlRPc2t3R2hMNUh1ckZPb1hmVWJV?= =?utf-8?B?RFJuZjNLYXdaeXhzd2JOR1c2TmNHRDZ5akJwa2VRSm1VOFBpa0pjYm5CWm9F?= =?utf-8?B?UXRnU1I5L2FpVWpSMXZ6R2diOExObStYRmhGUDl4K0JDclBGdzBWTy80TVZ0?= =?utf-8?B?TytGTHBLYVBhUXNUZEo3QlY0SWVWbllEMmtIdHlEMGZtUjdwUUMvS2gxZ0Zs?= =?utf-8?B?UFptL0VsUnVpbUFBQ2FMUC90OVBRMDNKUnpuVlJOQjh2RUN4bnVlS09pS09v?= =?utf-8?B?SUpvT3J2cU5tbzNLTmZPK0JNRVFIYlBaQTRFWUNvY1pIZmpra0xBOHkwa0hQ?= =?utf-8?B?bEZCV3ZwNnJMVnZ2YWR4ZXRKNThuaTNQcHpNZnRONUZ5NVJaMTA1c3BZdGtv?= =?utf-8?B?UFhlZGZZajZrRGp6NGNESmM0VHJ4dnBQcFV6enBKdHpUS0pJQWc2SGNLWnJG?= =?utf-8?B?ck9nNUlSanMrSW9wRTJ5eEpzbnRxZDV2YWZadVVZYVpic2tPczRrK0QzM1Nn?= =?utf-8?B?VERpTmZ2SVp5UVBJc211djFxbEE2WUpNd1AvUXUxK2F6QW1qVFBIcEpEeEFY?= =?utf-8?B?dHVueXZQVkJhazdOK1FienRySHNNZGh4TjNnakl3bkE3VENYc05zS05NdmZy?= =?utf-8?B?Y3BYanR5WVBuU2JETTd0eHJURmdpeEhsbEZmWUdnWWlVNzJJZ3NSUWxNRnUw?= =?utf-8?B?VTZGRnlrYkRoaVkwV0E3WVdEY2ljQjh3SEk1eVhOalRhcGhFVE1hSS84N0JJ?= =?utf-8?B?ZlNBWk9RUGYvNEZKUC9jSUhDNVUwZks1WkEvb0xBbWV6OWdFVHE3SUl6dVFC?= =?utf-8?B?dEd2MlNHRlVFT1Nva3R5cmZua3NtNXM2d2lmN3NGckZ5MlE5cU9nQW92a2Fv?= =?utf-8?B?UXBxUXBwZ29JaWozdVBGMzc3SmFuNHYvSlFKeklmcHdIT29DSkpzVWpyMmdL?= =?utf-8?Q?z2ZmAgg6NUHRyGEq6O79IZf2C?= Content-Type: text/plain; charset="utf-8" Content-ID: <302D9C7C6C63824DBFF0A605F9FF2632@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad202c3-5deb-4d20-ebb3-08da6e57284d X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 16:03:04.3595 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +QNGkhZSSA1de6JCrLnir9f2oHxEE27a47RCTSLeTubTsXiXscstKmYjJiEwMyIHd76P0NY1QQipsES/GaOg1ycTuiRzGr8fV9tTQIPD6iM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5262 T24gMjUvMDcvMjAyMiAxNjo1MSwgQmVydHJhbmQgTWFycXVpcyB3cm90ZToNCj4gSGksDQo+DQo+ IE9uIG91ciBDSSB3ZSBoYXZlIHJhbmRvbWx5IGEgY3Jhc2ggZHVyaW5nIGd1ZXN0IGJvb3Qgb24g eDg2Lg0KPg0KPiBXZSBhcmUgcnVubmluZyBvbiBxZW11IHg4Nl82NCB1c2luZyBYZW4gc3RhZ2lu Zy4NCj4gVGhlIGNyYXNoIGlzIGhhcHBlbmluZyByYW5kb21seSAoc29tZXRoaW5nIGxpa2UgMSBv dXQgb2YgMjAgdGltZXMpLg0KPg0KPiBUaGlzIGlzIGFsd2F5cyBoYXBwZW5pbmcgb24gdGhlIGZp cnN0IGd1ZXN0IHdlIHN0YXJ0LCB3ZSBuZXZlciBnb3QgaXQgYWZ0ZXIgZmlyc3QgZ3Vlc3Qgd2Fz IHN1Y2Nlc3NmdWxseSBzdGFydGVkLg0KPg0KPiBQbGVhc2UgdGVsbCBtZSBpZiB5b3UgbmVlZCBh bnkgb3RoZXIgaW5mby4NCj4NCj4gSGVyZSBpcyB0aGUgZ3Vlc3Qga2VybmVsIGxvZzoNCj4gPHNu aXA+DQo+IFsgICAgMC4wMDAwMDBdIEh5cGVydmlzb3IgZGV0ZWN0ZWQ6IFhlbiBQVg0KPiA8c25p cD4NCj4gWyAgICA2LjY3OTAyMF0gZ2VuZXJhbCBwcm90ZWN0aW9uIGZhdWx0LCBtYXliZSBmb3Ig YWRkcmVzcyAweDg4MDA6IDAwMDAgWyMxXSBQUkVFTVBUIFNNUCBOT1BUSQ0KPiBbICAgIDYuNjc5 MDIwXSBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIvMCBOb3QgdGFpbnRlZCA1LjE3LjYgIzEN Cj4gWyAgICA2LjY3OTAyMF0gUklQOiBlMDMwOmVycm9yX2VudHJ5KzB4YWYvMHhlMA0KPiBbICAg IDYuNjc5MDIwXSBDb2RlOiAyOSA4OSBjOCA0OCAzOSA4NCAyNCA4OCAwMCAwMCAwMCA3NCAxNSA0 OCA4MSBiYyAyNCA4OCAwMCAwMCAwMCA2MyAxMCBlMCA4MSA3NSAwMyAwZiAwMSBmOCA5MCA5MCA5 MCBjMyA0OCA4OSA4YyAyNCA4OCAwMCAwMCAwMCA8MGY+IDAxIGY4IDkwIDkwIDkwIGViIDExIDBm IDIwIGQ4IDkwIDkwIDkwIDkwIDkwIDQ4IDI1IGZmIGU3IGZmIGZmDQo+IFsgICAgNi42NzkwMjBd IFJTUDogZTAyYjpmZmZmZmZmZjgyODAzYTkwIEVGTEFHUzogMDAwMDAwNDYNCj4gWyAgICA2LjY3 OTAyMF0gUkFYOiAwMDAwMDAwMDAwMDA4ODAwIFJCWDogMDAwMDAwMDAwMDAwMDAwMCBSQ1g6IGZm ZmZmZmZmODFlMDBmYTcNCj4gWyAgICA2LjY3OTAyMF0gUkRYOiAwMDAwMDAwMDAwMDAwMDAwIFJT STogZmZmZmZmZmY4MWUwMDlmOCBSREk6IDAwMDAwMDAwMDAwMDAwZWINCj4gWyAgICA2LjY3OTAy MF0gUkJQOiAwMDAwMDAwMDAwMDAwMDAwIFIwODogMDAwMDAwMDAwMDAwMDAwMCBSMDk6IDAwMDAw MDAwMDAwMDAwMDANCj4gWyAgICA2LjY3OTAyMF0gUjEwOiAwMDAwMDAwMDAwMDAwMDAwIFIxMTog MDAwMDAwMDAwMDAwMDAwMCBSMTI6IDAwMDAwMDAwMDAwMDAwMDANCj4gWyAgICA2LjY3OTAyMF0g UjEzOiAwMDAwMDAwMDAwMDAwMDAwIFIxNDogMDAwMDAwMDAwMDAwMDAwMCBSMTU6IDAwMDAwMDAw MDAwMDAwMDANCj4gWyAgICA2LjY3OTAyMF0gRlM6ICAwMDAwMDAwMDAwMDAwMDAwKDAwMDApIEdT OmZmZmY4ODgwMWYyMDAwMDAoMDAwMCkga25sR1M6MDAwMDAwMDAwMDAwMDAwMA0KPiBbICAgIDYu Njc5MDIwXSBDUzogIDEwMDAwZTAzMCBEUzogMDAwMCBFUzogMDAwMCBDUjA6IDAwMDAwMDAwODAw NTAwMzMNCj4gWyAgICA2LjY3OTAyMF0gQ1IyOiAwMDAwMDAwMDAwMDAwMDAwIENSMzogMDAwMDAw MDAwMjgwYzAwMCBDUjQ6IDAwMDAwMDAwMDAwNTA2NjANCj4gWyAgICA2LjY3OTAyMF0gQ2FsbCBU cmFjZToNCj4gWyAgICA2LjY3OTAyMF0gIDxUQVNLPg0KPg0KDQowZiAwMSBmOCBpcyBTV0FQR1MN Cg0KVGhpcyBpcyBhIHByaXZpbGVnZWQgaW5zdHJ1Y3Rpb24sIGFuZCBoYXMgbmV2ZXIgYmVlbiBw ZXJtaXR0ZWQgdW5kZXIgWGVuDQpQVi7CoCBUaGlzIHNob3VsZCBoYXZlIGJlZW4gZXhjbHVkZWQg YnkgcHZvcHMuDQoNClRoaXMgaXMgYSBMaW51eCBidWcsIG5vdCBhIFhlbiBidWcuDQoNCkkgY2Fu J3QgZXhwbGFpbiB3aHkgeW91J3JlIG9ubHkgc2VlaW5nIGl0IGludGVybWl0dGVudGx5LsKgIFBl cmhhcHMNCmVycm9yX2VudHJ5IGlzIGJyb2tlbiBieSBkZWZhdWx0LCBhbmQgcHZvcHMgZml4ZXMg dGhpbmdzIHVwLCBidXQgYW4NCmVycm9yIGVhcmx5IGVub3VnaCB0YWtlcyBhIG5vbi1maXhlZC11 cCBwYXRoIDotLw0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Mon Jul 25 16:05:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 16:05:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374697.606841 (Exim 4.92) (envelope-from ) id 1oG0ag-0006g2-C4; Mon, 25 Jul 2022 16:05:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374697.606841; Mon, 25 Jul 2022 16:05:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0ag-0006fv-9Q; Mon, 25 Jul 2022 16:05:54 +0000 Received: by outflank-mailman (input) for mailman id 374697; Mon, 25 Jul 2022 16:05:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0ae-0006fn-OI for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 16:05:52 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a7d788a6-0c33-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 18:05:51 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id b16so6292283lfb.7 for ; Mon, 25 Jul 2022 09:05:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7d788a6-0c33-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VkJA++WE/02NU2MuNrToVC9RuJySznakYDIVUGMzJ8c=; b=GqAiOLzPey8s2s02fNpSCV4tPxWaYnJeMaWUyT9lnMC+W2hL5ZNvTxXPevJQr0WN8K zoAUyJeZ+oF+ZZl22SI3qKmfAro3LhWqDhh7b0f/Qfeikd/0FNvI6/a/67SQVeFI8EIo qYkP0x/G9wAhyvpq2Cp0ZTKYaIesuob7GSp+Fynkih1/xHk3GNEvcLajQ8bQuWE+4cZu t9fsjlecpm2TJypgg9YXfwSqB8i75hwS76XOqkHfnmEgCF3O4uvFhD2ZsUqNr6p3+iQH FhTjf+PtR/wAE+HQvb6v8IpFrGnGnPih9mN4hxDBejmR9zqPlN0m+ij63oZygPmIACE0 b+bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VkJA++WE/02NU2MuNrToVC9RuJySznakYDIVUGMzJ8c=; b=N0q02z7PiWiFp4XBGgy3tQoekC6sbkwu9oVy8o2KoLetq2Bnzso31TGhCS5SWlzagJ uFuAikz2olBVpGihFvO7iMBOGahE02FhpjVTDrsQ9JVOzq+zbOG5cxE9j6nvmAbZAiWp Wr6LTVtt7l3zWLOtJODk1cHk/umJoxRgdM282uAtEpyAVoT0IKTC1uN9o4Z/iTPP6g9o W6nUqijd/kZbzvimIFdLlI0vy4ls13bnU0vv7VKdH6EwklIXv7zcqRK0IobsVph8Ilim XmiawfChlW6vpy+cMC9aRKZc6FpjSSXNOGVsDnYQ75/CMrt+j6du2ps0nF6ROEBMqF+O ZC/A== X-Gm-Message-State: AJIora9+BisZX5mvadFmILFqRrQFVoXA78/Tlbb8QA7b1MKz+9ohQXSI 3/23DFHHdcpJHD9ddydEJc2vrCvdJ0VXm3tXBZM= X-Google-Smtp-Source: AGRyM1srxNwmrAx6+NLMXFU5XzOsb1J0xzhxbTIyo4jOXP3eyDXX+54k5L0aPYjKb3pspkaanXYlzZwL7JSqGIlzVSI= X-Received: by 2002:a05:6512:1085:b0:48a:710:6a7b with SMTP id j5-20020a056512108500b0048a07106a7bmr4626920lfg.417.1658765151224; Mon, 25 Jul 2022 09:05:51 -0700 (PDT) MIME-Version: 1.0 References: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> In-Reply-To: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> From: Julien Grall Date: Mon, 25 Jul 2022 17:05:37 +0100 Message-ID: Subject: Re: [PATCH] page-alloc: fix initialization of cross-node regions To: Jan Beulich Cc: xen-devel , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "Xia, Hongyan" Content-Type: multipart/alternative; boundary="0000000000009ac62d05e4a35b15" --0000000000009ac62d05e4a35b15 Content-Type: text/plain; charset="UTF-8" Hi Jan, (Sorry for the formatting) On Mon, 25 Jul 2022, 14:10 Jan Beulich, wrote: > Quite obviously to determine the split condition successive pages' > attributes need to be evaluated, not always those of the initial page. > > Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap > init") > Signed-off-by: Jan Beulich > --- > Part of the problem was already introduced in 24a53060bd37 ("xen/heap: > Split init_heap_pages() in two"), but there it was still benign. > Is this because range will never cross numa node? How about the fake NUMA node? > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -1885,11 +1885,11 @@ static void init_heap_pages( > * range to cross zones. > */ > #ifdef CONFIG_SEPARATE_XENHEAP > - if ( zone != page_to_zone(pg) ) > + if ( zone != page_to_zone(pg + contig_pages) ) > break; > #endif > > - if ( nid != (phys_to_nid(page_to_maddr(pg))) ) > + if ( nid != (phys_to_nid(page_to_maddr(pg + contig_pages))) ) > break; > } > Hmmm I am not sure why I didn't spot this issue during my testing. It looks like this was introduced in v2, sorry for that. Reviewed-by: Julien Grall Cheets, > --0000000000009ac62d05e4a35b15 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Jan,

(Sorry for the formatting)


On Mon, 25 Jul 2022, 14:10 Jan Beulich, <= jbeulich@suse.com> wrote:
Quite obviously to determine the split c= ondition successive pages'
attributes need to be evaluated, not always those of the initial page.

Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in hea= p init")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Part of the problem was already introduced in 24a53060bd37 ("xen/heap:=
Split init_heap_pages() in two"), but there it was still benign.

Is thi= s because range will never cross numa node? How about the fake NUMA node?


--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1885,11 +1885,11 @@ static void init_heap_pages(
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * range to cross zones. =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 */
=C2=A0#ifdef CONFIG_SEPARATE_XENHEAP
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( zone !=3D page_to_zone(pg) = )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( zone !=3D page_to_zone(pg += contig_pages) )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;
=C2=A0#endif

-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( nid !=3D (phys_to_nid(page_= to_maddr(pg))) )
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ( nid !=3D (phys_to_nid(page_= to_maddr(pg + contig_pages))) )
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0break;
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0}

Hmmm I am not sure why I didn't spot= this issue during my testing. It looks like this was introduced in v2, sor= ry for that.

Reviewed-by= : Julien Grall <jgrall@amazon.com>


--0000000000009ac62d05e4a35b15-- From xen-devel-bounces@lists.xenproject.org Mon Jul 25 16:16:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 16:16:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374706.606853 (Exim 4.92) (envelope-from ) id 1oG0kZ-0008Fn-BX; Mon, 25 Jul 2022 16:16:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374706.606853; Mon, 25 Jul 2022 16:16:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0kZ-0008Fg-88; Mon, 25 Jul 2022 16:16:07 +0000 Received: by outflank-mailman (input) for mailman id 374706; Mon, 25 Jul 2022 16:16:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0kY-0008Fa-3P for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 16:16:06 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70073.outbound.protection.outlook.com [40.107.7.73]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 14f11018-0c35-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 18:16:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2724.eurprd04.prod.outlook.com (2603:10a6:203:97::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 16:16:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 16:16:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14f11018-0c35-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GYV9Jcvl4ByIgm1wGejF8a9+71qljUKI01wDc88Lg1+nyade4t7lyn3cyPEMjIY09h9O0qIqHrSmMT7Q7HfqZwNmNWUu2Oy5ZJaJFW5nOG+RezUMJ+zT6cluJoIlMK/QUoYnzu8xMCAGecvE6eS6XBOSwbPZMPnUSUtGKlNqeMa4+CR5sop50b1/JeLPOSeCpwwB/ZST6xE8ZKJMbtrNCIlDZgYQNDfk+R+s5M42QeavNVharOvYRv8kuIUCawsYDZPrBsKlP7coiqHn5QK0pl7eKSFRnTqfo/Qih3Kdt2/i6ZgVWY2/1ALrmR/5awtPTZ/oFvoAviZ6nmLMyK0Q3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G3nTpai3WeGvgri+l+g5JnF3+TSlBuZUsjH2tkTfrDY=; b=jp16fZxwWcy7nJQa4UFo3EPYLrc4VNQdxuhFayUOWqcY6z107tV3zgOn7WFgYCSqXveNNAqfOWMYdKO0+OP31ZQwlH6baURDbDnoDOQrfhpW/IMtL+5q/YMQsv5n4sYn8jyFkd9Am9TKTu6Q2hpljZZlwnjushDh3++Qxap0WqOnW5pD2IdKrfE5agwFanDoEyrl/HLB1zeWk1UXeySvtUBd6rNfXyinwzWud9VwpnDSJu17g9CFNawHVDRjPJFVwXuhcJGLKCgW6tjQcTJiJ1cBTUzN/INYlDghHu5HniRi9t8gEA3sTOZGjUx8fBNTmEQciNVlIl4IHHTkn9wQvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G3nTpai3WeGvgri+l+g5JnF3+TSlBuZUsjH2tkTfrDY=; b=X1P1etFe300fCEqGThW284nmsfb5mMjhxKq6J7FeOQDddqyv7httpV4thTNWyLNHV2/RM9Gvjc1xDeer15BsLRWhRa/LcIsJecV6ZlUU/E9Kln3e03U01ZZDz12IJwKag55oZRsUOxo03w2A9ookKRYcl2lscWZrwdoXqXuuq5iOK8O7xMaGKdJh37duwYiKQkzaJqcfnlGhE1KqvZCWG7JcyhLqx93udSV0wPRfr3K6GAJHxtgTSh8TUznyGcmSiNiq2BMSaOFae5B8IunD/pmO0ZQL0Kz4PS6haoo3vhaY2iErws4ys73J+MWgpD7XEWiGJJ4CvMVcaUvApQ36eA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> Date: Mon, 25 Jul 2022 18:16:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Random crash during guest start on x86 Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> From: Jan Beulich In-Reply-To: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0029.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7d170810-8f02-4258-324c-08da6e58f7f6 X-MS-TrafficTypeDiagnostic: AM5PR0402MB2724:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: u6CeFJVuRwGVr77k8g1nqFIawNtKrG2Cp5XTfRWm2oxA8xl1/IFchApAwphnxy48DBMrbu5ozPJ939+lSuRD4XWjTC7YKqEXrDV5ICxLx0sTcNFR5yj/oTUAMoRqAuMMjrzULUoNyQ/ET3K5ApUHTeGErUF64VHWIE6ufbZ+KqVElgE8cZpIy+hjephmd7SwVaY47wEwe2rcL6hjyI8wrLC6Oyiox5OmgUyS7Y/nGiv85nYasW2tKz0spNm8mUL9w6x5WvLQj3fwk8yZcbNEFnaXV7esC2LxZu2tNr+6eqxMw+CrioJm7M2XncDne/6tIVtJgEjMkIHSAx99mbiRp/YDYO79a3x8Ddirkwc1vG3NGeIs9w7OJHpy0DLRZ62FI3OQmPoN6oHzrDUln/U+qT/sFWD+T696cs7ti+jNPs756BQU1EdTm9RlwGv3pirzgYzZmcXrFVZ/PbWBFoKulEILjjNGwxdIkDK0cXO51zD2hXDMiW3YYB76HHoq4Tf+jGouuO2eL7wEjapL8axSVxfqByIfkLIxyVrwlq9USifgccWKbH9Jh19PqAqol94Wr41BKnQtrHriBy5oFcFdxCV0T0+cRAasISl4ZFwO/j4oy2/3IJCa6yLvevgJp4Wst5ud+iQQ2R6MAOkqE2xKP7OGwP+ZwcWZbSTUlO65VaXAskLIeO8Sx2cIt6NdLwpuEmNmstqSJugckT/PIRDAxL2/jpC5GulGvPFdLL4tuJFwh3NBbZTq6mJ3NnjRo/0AWrska+O7czbwe8ySbyA5Xbl6w8AlCWOdYeCTXeoRHCSOMsZIqC8poJWjPGHyev0nZVAo1y8mbu9iYbxTmS8yWQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(366004)(376002)(136003)(396003)(39860400002)(4326008)(5660300002)(478600001)(6486002)(41300700001)(6506007)(83380400001)(86362001)(2616005)(53546011)(31686004)(31696002)(6512007)(26005)(2906002)(45080400002)(54906003)(6916009)(186003)(8936002)(36756003)(66476007)(38100700002)(316002)(8676002)(66946007)(66556008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L256c2VpdUhrUlFSTlQ0eTlFeEdXZVhVRnFPbnRvZUpyK0ZuaHFjT0NIS3Fj?= =?utf-8?B?MHgrYXEzZ3J0enNDaFJmMnJXUEJxcjNpWWl1R2h5amIvT1pUaldCbUhsaTlo?= =?utf-8?B?anZHT2RMRkM0eXJDeDNrN3FxU0g4Y3YwT3gxTDhJZzZCcUZkOVhrQWd0TkR3?= =?utf-8?B?TUJzMXlrVEJLWERsR1FLMXRUSjE2T2FIcTRyN09sbHQ0ZnhzTlRRUU1ZczZy?= =?utf-8?B?c21MblVoUjlHN3pLUitMa2RwT1lod1p4NlVZVElFdVpYM25Mdkpac056aUNy?= =?utf-8?B?Sm0vTndiejMrVi9oeHllVXdZOXo4VUcvcUZyR2EvMWJRYWQxb0NyaVZ5MTFy?= =?utf-8?B?dlZEVFFTcUxwY0hJd0xlR2dnT0h4TnhqdEc1aDN6M3NhVi91MVpha1h1bURV?= =?utf-8?B?Z1JLcXQybmNQb3BaZm4xMm5DT0Zkdlk4T0xnRGxRWU9ydEhJZXFoa3piN0Ru?= =?utf-8?B?Um5TZ1RIdWhqKzM5bmtOSTh6TUJhVGtYSzNkMCthcGJNajgyZW9lQm94M0ta?= =?utf-8?B?ZWRmM2hwSTFYOTdVVVQ1M3o3ZHY0RVBCb2Z6UFdJaVRadTdZV3I4RjZIZlVP?= =?utf-8?B?a29Da3JHVGtGNHFKRmNuRFRtK3loem5yTjJCSnRzRFBLQVhJVDFwc29WcHNE?= =?utf-8?B?YWZRU1JYaFVVc0RwZ3ZjNCtCVitJRWZRV0dINWJ0QVkzRlVDVmZ5YzRqWjdW?= =?utf-8?B?TTQyTlh3cG0rU0JZMVBOQlZ4c2FhQXZjdHcyZE5OR1hSM1hkaWNmcHd4SWVO?= =?utf-8?B?R1I3NlVtamFyNGlkNjl2RVIwMDhZbDV4RHQyUk9JYVlNbmVEWjdnKzBQOFJY?= =?utf-8?B?NzNpd2tZRjdCYm1JelVCT2ROWG1IbUpIRy9OUlYyM1h6eW5qTlRxdXJIeDVH?= =?utf-8?B?RCt5NTgvOEpubWo0WTd5OURtZEZPdUd3YUtiSEFpajdidGgweVg4YkQvQmU4?= =?utf-8?B?UGExUWRFRXJ5WCtkQXpNOWJCb0pXQ09wY0xMazBDdkxQd3lDZFJreU45YlpJ?= =?utf-8?B?c1RkZWNxcnc5aDVrQ1V4cHo4Q1RGdlNjeHlHYTVkclkzWkdtMUZ1VTFWSlFs?= =?utf-8?B?bzkzclRQRUJqNTdRcGMya0txcHJleUJVYW9oYXl2MkQ4cW9FMU5XZXA0Vmtz?= =?utf-8?B?ZVI0R0NXQ1VIWFpac0FobStZWEpyY1Uvc0htMDlIMnd5VlZNaFNsMUFqWHRu?= =?utf-8?B?QWlzVnJubSszdzJaQ0d6M3NEWjdpbE1URnoyajdWSGdOQk02cnVIS2E3V3B4?= =?utf-8?B?b1JtZ2w2Y0tuMWVkSnBuNnduYnRoamJkdmRLRVNwenV0emdHbnRyeU0vbXU2?= =?utf-8?B?YjFTNzJMN0gxSmRreG00MVJUS0h5Zk03TmR2ZUE1K0dTd3g4S2lpSnNPaVkw?= =?utf-8?B?YUJHWVg3eTU3eklsVUNRa2FRTEZrOVd3OU5GbFFyZnpuRFNyd3ExQWxpZEY3?= =?utf-8?B?RFZ5MUgraWpaV29yN2VGUFFERTkrVnhKRWFwcFZwOENqWTFYWHRGWXo0VzJ6?= =?utf-8?B?YXVwWUZsS25KcDhLTTZpS3k2ZFVSUVVnREtMNlNvOUFyMEtueGFzQlJGV2Vi?= =?utf-8?B?cnczdzBvc2JWNmhVVjNEWmIvZlpVd0s5dHVxNU1GSDFQL0djRGNmTUZwUE5V?= =?utf-8?B?WnJjL2JuanQ2RmNmOXB4YTQ0VEhnNXF4d256Z25Fa3h5TTI2OXJvYjFkTGti?= =?utf-8?B?ZmJ3TXNDeStXbSs2VHp4K2pOSmNCZGlCbkRBNTcwTE9pODhOZzU2YVM4N0Ri?= =?utf-8?B?cm1QN0RvM3YxTGZoMmJPbnFrQzNvcW1DdXI3a1BMV2IxVU1CNE1jazZldkVC?= =?utf-8?B?WmlEbTJJclRscmJvT3pZTGdTeGhRRGlqRUlVQWEzT1g2UXFycUJXUFJnSnh1?= =?utf-8?B?UWpqK2dVaWRkUjB6d3hHazNNNmFEOEg1YVVEek5rRzJoUFp5YzlOSlBTN05M?= =?utf-8?B?cExhc1ExcFVFSUZlK0RDTENzb3AxZ1hTbmNDU05GQjI5dCtwN1NvSzJxZGVC?= =?utf-8?B?djZySEZ3N1B5N1EyeGlhWmlVbjRsbVBodENjc2N4Ymc4Y0F2L3I2bXVWdktS?= =?utf-8?B?VllFaTJ3dUY0eTJtbkQ0Rlp6L0swQzQrUGE0UGlzQ0NLSnNUbzVnNUJndVZZ?= =?utf-8?Q?5QVlKdm3fFq+lL9y9x0Le2uDd?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d170810-8f02-4258-324c-08da6e58f7f6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 16:16:02.3724 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AQ6nIcDxrNRLK4jgQaBmVl1GJoXsqXTQDNdaltZT1LA6bOjdBhqh0f3fQnl6jnU3xQHSw8dhfvkvKQX6kbJ6FQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2724 On 25.07.2022 17:51, Bertrand Marquis wrote: > On our CI we have randomly a crash during guest boot on x86. Afaict of a PV guest. > We are running on qemu x86_64 using Xen staging. Which may introduce unusual timing. An issue never hit on actual hardware _may_ (but doesn't have to be) one in qemu itself. > The crash is happening randomly (something like 1 out of 20 times). > > This is always happening on the first guest we start, we never got it after first guest was successfully started. > > Please tell me if you need any other info. > > Here is the guest kernel log: >[...] > [ 6.679020] general protection fault, maybe for address 0x8800: 0000 [#1] PREEMPT SMP NOPTI > [ 6.679020] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.6 #1 > [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 > [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f> 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff This is SWAPGS, which supposedly a PV guest should never hit. Data further down suggests the kernel is still in the process of patching alternatives, which may be the reason for the insn to still be there (being at a point where exceptions are still unexpected). > [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 > [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e00fa7 > [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000000eb > [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 > [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 > [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 0000000000050660 > [ 6.679020] Call Trace: > [ 6.679020] > [ 6.679020] RIP: e030:native_irq_return_iret+0x0/0x2 > [ 6.679020] Code: 41 5d 41 5c 5d 5b 41 5b 41 5a 41 59 41 58 58 59 5a 5e 5f 48 83 c4 08 eb 0a 0f 1f 00 90 66 0f 1f 44 00 00 f6 44 24 20 04 75 02 <48> cf 57 0f 01 f8 eb 12 0f 20 df 90 90 90 90 90 48 81 e7 ff e7 ff > [ 6.679020] RSP: e02b:ffffffff82803b48 EFLAGS: 00000046 ORIG_RAX: 000000000000e030 > [ 6.679020] RAX: 0000000000008800 RBX: ffffffff82803be0 RCX: ffffffff81e00f95 > [ 6.679020] RDX: ffffffff81e00f94 RSI: ffffffff81e00f95 RDI: 00000000000000eb > [ 6.679020] RBP: 00000000000000eb R08: 0000000090001f0f R09: 0000000000000007 > [ 6.679020] R10: ffffffff81e00f94 R11: ffffffff8285a6c0 R12: 0000000000000000 > [ 6.679020] R13: ffffffff81e00f94 R14: 0000000000000006 R15: 0000000000000006 > [ 6.679020] ? asm_exc_general_protection+0x8/0x30 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 > [ 6.679020] RIP: e030:insn_get_opcode.part.0+0xab/0x180 > [ 6.679020] Code: 00 00 8b 43 4c a9 c0 07 08 00 0f 84 bf 00 00 00 c6 43 1c 01 31 c0 5b 5d c3 83 e2 03 be 01 00 00 00 eb b7 89 ef e8 65 e4 ff ff <89> 43 4c a8 30 75 21 e9 8e 00 00 00 0f b6 7b 03 40 84 ff 75 73 8b > [ 6.679020] RSP: e02b:ffffffff82803b70 EFLAGS: 00000246 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] insn_get_modrm+0x6c/0x120 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] insn_get_sib+0x40/0x80 > [ 6.679020] insn_get_displacement+0x82/0x100 > [ 6.679020] insn_decode+0xf8/0x100 > [ 6.679020] optimize_nops+0x60/0x1e0 > [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] ? native_iret+0x3/0x7 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 > [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 > [ 6.679020] apply_alternatives+0x165/0x2e0 I have to admit that I'm a little lost with these "modern" stack traces, where contexts apparently switch without being clearly annotated. It is looking a little as if a #GP fault was happening somewhere here (hence the asm_exc_general_protection further up), but I cannot work out where (what insn) that would have come from. You may want to add some debugging code to the hypervisor to tell you where exactly that #GP (if there is one in the first place) originates from. With that it may then become a little more clear what's actually going on (and why the behavior is random). As a final remark - you've Cc-ed the x86 hypervisor maintainers, but at least from the data which is available so far this is more likely a kernel issue. So kernel folks might be of more help ... Jan > [ 6.679020] ? insn_get_opcode.part.0+0xab/0x180 > [ 6.679020] ? insn_get_modrm+0x6c/0x120 > [ 6.679020] ? rcu_nmi_enter+0x2b/0xf0 > [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 > [ 6.679020] ? irqentry_exit+0x29/0x30 > [ 6.679020] ? exc_xen_hypervisor_callback+0x8/0x10 > [ 6.679020] ? relocate_restore_code+0x22a/0x240 > [ 6.679020] alternative_instructions+0x8b/0x13a > [ 6.679020] check_bugs+0xa87/0xadf > [ 6.679020] ? __get_locked_pte+0xa8/0xf0 > [ 6.679020] start_kernel+0x64c/0x680 > [ 6.679020] xen_start_kernel+0x592/0x59f > [ 6.679020] startup_xen+0x3e/0x3e > [ 6.679020] > [ 6.679020] Modules linked in: > [ 6.679020] ---[ end trace 0000000000000000 ]--- > [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 > [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f> 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff > [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 > [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e00fa7 > [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000000eb > [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 > [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 > [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 > [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 > [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 0000000000050660 > [ 6.679020] Kernel panic - not syncing: Attempted to kill the idle task! > > Cheers > Bertrand > From xen-devel-bounces@lists.xenproject.org Mon Jul 25 16:18:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 16:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374711.606864 (Exim 4.92) (envelope-from ) id 1oG0mX-0000Yf-Sb; Mon, 25 Jul 2022 16:18:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374711.606864; Mon, 25 Jul 2022 16:18:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0mX-0000YY-PS; Mon, 25 Jul 2022 16:18:09 +0000 Received: by outflank-mailman (input) for mailman id 374711; Mon, 25 Jul 2022 16:18:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG0mW-0000YI-ET for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 16:18:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5df3d065-0c35-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 18:18:07 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM5PR0402MB2724.eurprd04.prod.outlook.com (2603:10a6:203:97::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Mon, 25 Jul 2022 16:18:05 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Mon, 25 Jul 2022 16:18:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5df3d065-0c35-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IE0ZNx8fPFMG48avmplfv7RVmu18sLwQESSsTPVhKOKICICWkHQbpL4oyA1I0EQ2CYi6Xn7SPyzmihaIIkBqxAOzLOoR87nPAQQnZq+flvO5oV9n5OSu/Yeh8djh7kcZYo3VIewJskKOuU4/nXc/V6SP3GwcoFkeHqxIru8hBXG/F53lpob82dhjmpVBgZ/wthmpmAosQABxGdMgHl0vEPrUPZSTFRRwwuffYZNxQHijd9CmQDx4oLsOeIzxZPCqtSpP2QRv3zarp+4/veXlD/zhJzaWRqcamLMISLiiOTP4iT5vlnOzx5WR6WIL5yxbboqEjw2ptkVfik+J8BkDOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mz1YE18l9VGVY57WwyAGO7FD1IPzpn0GTqYKKlSJ2cU=; b=iH/7WazNf1U/tCdLxE/P408sBkL3oG8fVEC8268is9HUe1L4cBED/3Mr8DSLhf3fP9MBTE6JQZTGw+63pPRA6Y4i5FjPe0qEwRXYkzvXK14YTtBRDFBkl3NS24DwDRnEhz03cE8kGvJ0qPYYkiNHBVPNGNgTXtapR3nwQYqjDwlmz8f5YgvLe6CrL9wAdUihhszLpm5TbJPU15lwhsIEfQ1RFaZrnm1rjT7kWE0ajgx9cZ1mjNkJO72SerudwOTTpOgO3nJgwbgGHaU9MJKBVBDJQ48Owl2pfzjcnC5CQfIP9dz6ChPM39r0m4sUaiHKSLssKaD210ulphrF6ouQQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mz1YE18l9VGVY57WwyAGO7FD1IPzpn0GTqYKKlSJ2cU=; b=4b24ozksqsE/8nrQGlFPtsKkXkl0NhIw4f6LHK/kfvRMrVaO8BNwiUe63UQyANhByRJgeNUYyLr23X69bwOz+/PTFCOvulXEwM7PVV5ZUCJDopH5DRYxhY4dM6gymkRTCbSHDf2wmV9Wc3stZqJPL4fyRCph9ZDLzAYZJJSZDAuQg1KBuBdVfDgK7f1mOKdrXKAzQ7+CFQAaQkcXnakPoGt+KXnuzornQRSwoSwEk6ftcFV8Fr1MR7yvFd2vyM1OYAtGjgfASAxb6ueETShciXq/QXI73FVZWo3FvY3pA9+RuwAHdswlglwkGt9vBEk4Xuy3LbMK3uDnPAzVrdkFAg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ea40e1c-6be4-ea82-accb-8bfc21cdf987@suse.com> Date: Mon, 25 Jul 2022 18:18:03 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] page-alloc: fix initialization of cross-node regions Content-Language: en-US To: Julien Grall Cc: xen-devel , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "Xia, Hongyan" References: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ecfb92e6-a939-4d32-2653-08da6e59415d X-MS-TrafficTypeDiagnostic: AM5PR0402MB2724:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Uqh/Cu2SfVLnUumY8u2Hz6KlRTsAcEglF899GtlOLNmKX/T1TcObBqh5W3KHEl/J+nhhGhW7r0iPn3+pncn64Z5S7ltgkqbuRFtvxhpwu4sY5Ih43xgzptFSlInfiIWOCqc4FtH0wsKacwz7a8jOsDt8UY/j5fXuv0bC8yputxu0Pt51QXU/Qa4ymbNdEiWy0p2j5vP6hRJQu3ZdDffDL452JAqexYAYrDLgp2JrKSckY43g0PmzGNqnaXrKpTA7IAtdVHo1HffQn7VzopK55RuNZpsaANHXso8/1p13MRvjltLJe/koa8zwTH/I9Td/e2XRBj1JGDpqYyne4Gp7BTDP1c+ZmXfAdOK5L4REeNHvD2pzq5KLzPi6W/vjTS7WBvOZoruUwNFz86Zxl1y6Wo9DKHbiYab7NWWDM2bfhsKKV9epsO5ifYWZTeqoPMQaot4RxCuIizkqP9Mx0VaMrbbTQFFkYM3JFPPPDglBlipqzzBgGTaf5lEZEd43F/b1DpTOJHoSKez9vqS73V+Edc0lidfnXBfY1JgLxOi28sQhWrF8aTyiKrnBuvJhGW5V5sthub3VFwSxTUUedEGC1zkpc0CuwqgmQmmePizVwyOS1CIkrAEH/kHmUX8ISx9juWG9GjwV/livf2iKpXN/mPpUIE4y9Hm6xl8pl32ZlEKMg1E5Ox7ZJGl6pqsaUG5ifT4eSmrALM83pMWjsx3/O5aYlapDbyReLJue8ULF3zq9SK7jMfxkKEw9cRd1Qm+dGiQE+qCY1O0gHv32iQWijJP2y3V/hTX9B6CI5urod+3FRdJDpShAP4M6/yeOkqIdNRPIfssauV/7Hegvk/PULg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(376002)(366004)(346002)(36756003)(54906003)(186003)(8936002)(6916009)(66556008)(66946007)(8676002)(316002)(66476007)(38100700002)(86362001)(31686004)(53546011)(2616005)(478600001)(5660300002)(4326008)(31696002)(83380400001)(6486002)(6506007)(41300700001)(26005)(6512007)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NllXdCs1aDI1Q29MTUVGMWRScGxqNEkxN2tmeXBqYmhITUlkTFZrUXNYVEpi?= =?utf-8?B?OGVNTXY2dG5neUEwamk4dGFKL3NTazJzRnl5c1dYc0dESzR3d2wzQUIrU2p6?= =?utf-8?B?dm5SVFdQRVdkN25JT0F6MXZDeVgwdVpIbW1Mb3UvMkpubW1rQU91bEUreGl6?= =?utf-8?B?N2dGRzZnZmJFVitzdWRXOFptM1JQUk4rb3hOMEtReDI0N040bHdmZVQrSUx6?= =?utf-8?B?dFkxamJqR0hUWlowdCtyRWwyVHhRcytLM0hvWHI5ZHNleXBVTFd0N1N6YlEy?= =?utf-8?B?MEpyODB4ZDJSNTBFK29haEhvc2VoNlYzblhOcUZOdzdTMGUvc2NIUWJXVHJK?= =?utf-8?B?ZkpsYnZyYlJ5SmpiczUwQnFEV2EyVVIzaXh2c1VRamdaTTF5NmcvaXlkQWpo?= =?utf-8?B?aVNEVEM0YnpLMXc2MTUyd0pTWDd3RHN2dXJWR1FHV3VNUDQvYnkzTWxGY1Rl?= =?utf-8?B?Mm4rdm1ndnN3Y0MxK3REVGFWL2s0Q0d2b2lqYndKdC9iVEczeHdRclN4eWc2?= =?utf-8?B?THVjSjhCUXdBdmY1bThXdFVtU01ya2tjVkY1ZFVCTk5UQ3dTTGptR1JJckNR?= =?utf-8?B?ZG5NeW5OblN6c0RmNWVPK0FaSFl1M0xhTFVTcFZwL0g3R2l0bzhlZHlwdElF?= =?utf-8?B?MmVOQzl6SlF1STJTQjh5d1c1MzZteDZub2pSODBEVm5jNTJzYTN1ZkxHSXRt?= =?utf-8?B?RzVWM1lLVlU2cnVuMnFCandRM1VMVDFMVVd1U0ZGTjBrMXFwNHE0em5ZY29x?= =?utf-8?B?L3E0Rm14ZFhMelVzcHJpcWQ0ZmV1OW5nNitkMnNZd1g3S3c0RENDTGhENzJV?= =?utf-8?B?NCs1NFlRUWNjbnpXQnY4QTJ1dlJYVS9zdm5OV3hCYXo0M25WRGRxVFBMUlgv?= =?utf-8?B?dWFMVDY1Y0o1Z1pocVZtWHV0bUhVN3ljQkM3dTdQN1pSMGpxNXZYOTB0SHF6?= =?utf-8?B?VHhCdkpDaXNmNmY3R0wxMlgxQncyZDJnVlZRek9rMlhPaGQwejBmUUFhR0la?= =?utf-8?B?aEorSTNXYitBeUdCMEluYVRpaEhlZEJxWjR3LzkxYWZyNWhva0ZSUVB1MVBV?= =?utf-8?B?aFBRa0JNVmhaV2JpSUNUMVJPc1l2dk50N3ZQNU1vL0l2MmcyRXg2eklPUngx?= =?utf-8?B?WW1lYXdZMFgwNzNRRnZYRlJFRm1ITkN2U051SjMvUkI0VnRMTXJUNGprNmd3?= =?utf-8?B?M0wxSGZzUVhKc2h3N1oxMkFqd0pCUktpbis5SzRkL2MzbEM5UFg5RFlPQ3lM?= =?utf-8?B?elNUTEVjTGRXTEZwajJsMlB4MnEvbndVK1A1WCtkRCtEVjhYbld6cUxBZWZ4?= =?utf-8?B?VnNld0hlMEEzdUFndEZXeWdpV0YwNGNaWjYxK0hhakV3Q1FTaXVuNlEyZVIv?= =?utf-8?B?U25HdHFPZTdRVmtVckx4Wjd6QVNXR0plSk1KTmRmdGszczhDQUhqNjQvZ1JY?= =?utf-8?B?aDNkaklQZ2d4aW9LWTZLdlgybXlKVlhZRFA2UkVXNXFCUUloL0Vya1pEV1NS?= =?utf-8?B?N3pQaWc1UXVVZkZWMVVidnU2ckx2djBWNEZaZHRxaHdxZGhIaVNCcFB4a2h1?= =?utf-8?B?dUdhOUQ1bFNGa1Y0Qk9mTTd1dFNsbE1lQWdkb1NRc1djais5eWw4R2xkOFJh?= =?utf-8?B?TGt5aTBvbktIR0hyMGwyYmxuNUFWZWJySG5UQmpZcm00WGlmOFNWWjdBUHB2?= =?utf-8?B?K054VkllZzlXUVkvbzVhUyt2QUtVS0YzL2NVZm1ub0FUTUVvYnNORTlrR1Qv?= =?utf-8?B?MFZteFNBdFZ6TjYyMklWakdjUW5lZlpqeEVlLzJYZDVFcDNRV2oyZXZoTVN2?= =?utf-8?B?Uk85YVRxZTN0Y012YVJ6NjNJcGQ4QVRQQlNvZnAzOS85Q0p1RUFEK3NIZTFZ?= =?utf-8?B?RDFHVitsNThXQ2hKOW96RkRZVnNVcTM3SmJVMHRuUXUwWEZ0R2FuUnVTQmlD?= =?utf-8?B?N0pXVHRIb1A5WmlHbnBSYzhrdFhER1dhenZwWlV0ajJjd1JyL01jMkRFRUhm?= =?utf-8?B?TFZ5VDlUNENLdDZhcGZNdCsrT0dFbitGRGVyZ25xT29ENlFGSFkxRlF2ZUo0?= =?utf-8?B?L3VKTzZxL2laOE1YazZDRFZ3clBEU2plR1VDUnZqODVvb0xFQ1JpZUZEN1FL?= =?utf-8?Q?Vok/eCQfzLHERXKOt17kb+H3J?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ecfb92e6-a939-4d32-2653-08da6e59415d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 16:18:05.5677 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: m8GEWLmMuJgXltKyH++eh0XNMFUTjhemexeqsRqpUt+J8S/j06sPtSfLmxPLtFvrzrnqHWrDvWxE3ztboR7k5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2724 On 25.07.2022 18:05, Julien Grall wrote: > (Sorry for the formatting) No issues seen. > On Mon, 25 Jul 2022, 14:10 Jan Beulich, wrote: > >> Quite obviously to determine the split condition successive pages' >> attributes need to be evaluated, not always those of the initial page. >> >> Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap >> init") >> Signed-off-by: Jan Beulich >> --- >> Part of the problem was already introduced in 24a53060bd37 ("xen/heap: >> Split init_heap_pages() in two"), but there it was still benign. >> > > Is this because range will never cross numa node? How about the fake NUMA > node? No (afaict), because pages were still freed one by one (and hence node boundaries still wouldn't end up in the middle of a buddy). >> --- a/xen/common/page_alloc.c >> +++ b/xen/common/page_alloc.c >> @@ -1885,11 +1885,11 @@ static void init_heap_pages( >> * range to cross zones. >> */ >> #ifdef CONFIG_SEPARATE_XENHEAP >> - if ( zone != page_to_zone(pg) ) >> + if ( zone != page_to_zone(pg + contig_pages) ) >> break; >> #endif >> >> - if ( nid != (phys_to_nid(page_to_maddr(pg))) ) >> + if ( nid != (phys_to_nid(page_to_maddr(pg + contig_pages))) ) >> break; >> } >> > > Hmmm I am not sure why I didn't spot this issue during my testing. It looks > like this was introduced in v2, sorry for that. > > Reviewed-by: Julien Grall Thanks. Jan From xen-devel-bounces@lists.xenproject.org Mon Jul 25 16:37:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 16:37:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374719.606875 (Exim 4.92) (envelope-from ) id 1oG14i-00037f-H9; Mon, 25 Jul 2022 16:36:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374719.606875; Mon, 25 Jul 2022 16:36:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG14i-00037Y-Ci; Mon, 25 Jul 2022 16:36:56 +0000 Received: by outflank-mailman (input) for mailman id 374719; Mon, 25 Jul 2022 16:36:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG14g-00037O-Sj; Mon, 25 Jul 2022 16:36:54 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG14g-00045k-QN; Mon, 25 Jul 2022 16:36:54 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG14g-0003MU-AK; Mon, 25 Jul 2022 16:36:54 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oG14g-0002SA-9v; Mon, 25 Jul 2022 16:36:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vYE52YPr88WyEMusMKjj0gUhmIvVWNz61edoYR8QgMw=; b=uIAPKmY+jl6cSnbQeZ7I6zcQmQ eApG/rnCwYv0zm4ha81qmlLoF11+VKQ5XOngA6RxnjBJZqXSG1Y8BKZS/8HP0wFUx7rBpB0eFBHrU 8FudAVz1+0QG0NNKzvc7YE7t0+rqhjDnY7Y+Zl27PRdAzMvuPu9hVaDB0GEJA++1NlnA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171854: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Mon, 25 Jul 2022 16:36:54 +0000 flight 171854 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171854/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171747 2022-07-21 20:05:50 Z 3 days Testing same since 171854 2022-07-25 14:03:15 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Oleksandr Tyshchenko Roger Pau Monné Tamas K Lengyel jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fcd27b3c75..f1c719d5cd f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 -> smoke From xen-devel-bounces@lists.xenproject.org Mon Jul 25 17:15:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 17:15:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374728.606886 (Exim 4.92) (envelope-from ) id 1oG1fb-0007Xg-Ey; Mon, 25 Jul 2022 17:15:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374728.606886; Mon, 25 Jul 2022 17:15:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG1fb-0007XZ-Bx; Mon, 25 Jul 2022 17:15:03 +0000 Received: by outflank-mailman (input) for mailman id 374728; Mon, 25 Jul 2022 17:15:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG1fa-0007XT-SC for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 17:15:02 +0000 Received: from c.mail.sonic.net (c.mail.sonic.net [64.142.111.80]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f893653-0c3d-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 19:15:00 +0200 (CEST) Received: from localhost.localdomain (c-174-62-72-237.hsd1.ca.comcast.net [174.62.72.237]) (authenticated bits=0) by c.mail.sonic.net (8.16.1/8.16.1) with ESMTPSA id 26PHD3R7021698 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 25 Jul 2022 10:14:55 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f893653-0c3d-11ed-bd2d-47488cf2e6aa From: Sarah Newman To: xen-devel@lists.xenproject.org Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com, Sarah Newman Subject: [PATCH v3] livepatch: create-diff-object: Check that the section has a secsym Date: Mon, 25 Jul 2022 10:13:02 -0700 Message-Id: <20220725171302.25910-1-sarah.newman@computer.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Sonic-CAuth: UmFuZG9tSVYw7an9Y36xyKou/Ityk+kRmydRdr2FhcFU/JCK9M/WxdIVNlvsx6221yndaODaqA+nI/CrvDASekfPuR8/E4h4 X-Sonic-ID: C;pNjCCj0M7RGWb/U2He8XJw== M;eGqDTT0M7RGWb/U2He8XJw== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd A STT_SECTION symbol is not needed if if it is not used as a relocation target. Therefore, a section, in this case a debug section, may not have a secsym associated with it. Signed-off-by: Bill Wendling Origin: https://github.com/dynup/kpatch.git ba3defa06073 Signed-off-by: Sarah Newman Reviewed-by: Ross Lagerwall --- Changes in v3: - add reviewed-by given to v1 of this patch - restored tag from original commit per sending-patches.pandoc Changes in v2: - commit message changed to use Origin --- create-diff-object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/create-diff-object.c b/create-diff-object.c index a516670..780e6c8 100644 --- a/create-diff-object.c +++ b/create-diff-object.c @@ -1484,7 +1484,7 @@ static void kpatch_include_debug_sections(struct kpatch_elf *kelf) list_for_each_entry(sec, &kelf->sections, list) { if (is_debug_section(sec)) { sec->include = 1; - if (!is_rela_section(sec)) + if (!is_rela_section(sec) && sec->secsym) sec->secsym->include = 1; } } -- 2.17.1 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 17:44:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 17:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374736.606897 (Exim 4.92) (envelope-from ) id 1oG27l-0002dS-Nk; Mon, 25 Jul 2022 17:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374736.606897; Mon, 25 Jul 2022 17:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG27l-0002dL-Jp; Mon, 25 Jul 2022 17:44:09 +0000 Received: by outflank-mailman (input) for mailman id 374736; Mon, 25 Jul 2022 17:44:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG27k-0002dF-7Z for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 17:44:08 +0000 Received: from USG02-CY1-obe.outbound.protection.office365.us (mail-cy1usg02on0098.outbound.protection.office365.us [23.103.209.98]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6003cfa0-0c41-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 19:44:06 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1484.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:186::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Mon, 25 Jul 2022 17:44:01 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%4]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 17:44:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6003cfa0-0c41-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=UZXjv/69WcoUo1UfBHz0/bVuLuy7VLzpjf3ZiuywJD2rlLGJVVppPp5Ne3mE4KiV9IpyAZ4jzQHRB8+Fw8RcYNr+znnxDdMPy6/Wnusu7KzCm5+Q3CyI8LPqIyjtrT1VwHpa9IYQb/10I7zulEdIC9nE4eTLHC4nv/MF6pNzYlOKvFJRqq1c9cIcJu9qL8sLeS9dU0M9hCsxUGiV4QXrJXBnyNEjZTNCCYC7dk1v6M/aDbIw01aKT2MxyINRzcPIlJPVd9ZbgmmUDveBF1eRwEc+zzTka3gmcYUQvUyEnMRphfeN+m253ywHHgZa2Hg71mo2H1ZAA5dZmnmtOyaVuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5aLSY46HCACeRx9OPpUpXthhlP/QIwvUeLDK/Y4t5AU=; b=hggJKQDcsKrGLyYog9uT1NhAisUS86bi0lHzvoprjekY9bIvS9/vivcx99hk5/wbuIJi0J8p2eRvfossLtvE7oJ4uJVOwUsH5A0suM+RiGJOW2c8LrpbJrPhqhhZkpTzM4vX8DvCeZK6WueGX37kd+qblhdLtgajKburlnFOyRXmWy2DxcRaLdsDP4RjkMO4Gfy3qa4XegMP64QMSKPFg/vb5b6tkYIYZoPzahg9lIbgGirlJLfqihsOXhK64djiKYiYtbd+xNWcfiXaKgNiShGv+WUkh2mXt0TXBYp9rUi/ePKgygZa9zAPni7Q5eB3ZGiAiRAicF/CT5o+vm7qcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5aLSY46HCACeRx9OPpUpXthhlP/QIwvUeLDK/Y4t5AU=; b=Yipb7/K4Q/yPQaoBkTHljD4tL3vEm4tjKx8Bn5CY+WIPTD8auGtWXY9SCjT9j+YRPTRtTCgj1VyAAmdAh1ooaFVO6H8oBwoMNxBD3qOqtTl+jzcgiP7I/NMWYQ04PAgNyD78rdk9kgB5MD5SAHFGVzVHARAuGiZn8kMrT3uC+RBHs98s16pST24BThlVsxmGOpGY3TqjmevxeOM8BzntWws2eqBZwv5vWsH4heTDoI2ZcINxzrejlWx6IWEaaUGHkbRWfu7LtHb7Gal/dqRw9ngTzqLRlyB4o5m/LIXXk2cx3ElBmdvle27OyO51g7RUT0wL8Ba0qyV2PkacXMN7cg== From: "Smith, Jackson" To: Xen-devel CC: Stefano Stabellini Subject: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Topic: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Index: AdigP3XkakTWEwukTeurpU94cGpQzA== Date: Mon, 25 Jul 2022 17:44:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4577e3b-0cad-4023-a7e0-08da6e6542af x-ms-traffictypediagnostic: BN0P110MB1484:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: d/2LMZGExwp1euZU53xFDnbc1KBfsd4/KvkNle1Jrx1TxETGsfcAS549t6eJAZN8X9u5JZK+v1KbpcA9yfYjKGKoocF6sWzJc4bp/huFIAz0vzsDfHp94OoYZI5x2aTDz5v04r+tkb3+sFgyb2uKHmEdkSkD3vUGEHqzuz0BdUzOhfQ+HKZdLBMMgx5dAbnelfrvDRealO5EngniuHu9v/sCz9FEOHcz/h6kyL/xBWyu0dKj2XK/CM7Sp7d/6CmQJb/2wf2vB9yJivsiCy3iioDVI4RYwI3iFiW34k5U8wBJo+TzyfPj9iNYd6WiwmC5BztbYbYCoIs/GNWTYXxvWwPFt9s3PqWBIGlz+z38P1sBJyarW3jDXDGtMxs09LTLE24mGmgpB1eNfym3Qtu4yZr0Y4/FUlPZaYaqeQ0DDFEv8P+WTVxf1VCBz3ozF9prQkxLVZxAq0qL1YMXUYUIwDpztIyaNjQRJDNtSdwq1y4kMmUXbHMoJ7Te4zMy5Ia+VUKil7bWxzznWFX/rhSJ74ihNjQ/lrxGIhJp7SKfKPrjFwzTsPwIoIrneZLij7YfoGiLFFjWvsc5mUP7chFPlLcp/xHXCvByVFzD0RmGvJ1C88z2BdQ5d8lXc1CkxVIRkYxH7gGBBUpA9ZUY7b47XtGMwBDNbwRMeYjTgIBXgIMh4B2OVnONilJAWbqtv+i95q+lxLHo59wDPJ/+GrjOIM8LtKNqb//+p937DOMHq4NVXeCjPp2ZTIETVal9o3H+ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(6506007)(66446008)(4326008)(76116006)(66556008)(4744005)(64756008)(66946007)(82960400001)(498600001)(66476007)(5660300002)(122000001)(9686003)(38070700005)(8676002)(8936002)(7696005)(6916009)(38100700002)(52536014)(55016003)(33656002)(86362001)(71200400001)(2906002)(186003)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: sfayqqNm035M7iSuSJ7rTE0H0qdVAdEiVEGnmgYmzcrUTV7oG7wJ1AkeLuNZF6mcR5lCUzJ/TTwZaT098Cu0ha1TJqo46s3K/wZrXJeYTl74RkHGXCIEjA5LAUnxXQyONfp15DNelUC/oG6d0b34K29h+UQc2GPJKIJ+TugzI2BPyZvW3WHB9aUM0nN9c/XsW8LzdY0S2Tlfb1Mj4rwdaNfgZRc+g2Z5g+gkBrmldUMcqDggprIvxyeF1vmFIUfkEGUo5fjjSZpQH6E9U1G8rO+8N0IGn4XusPvzjp/F9mfKIilGamakY0vpG9RDoCxXw2lRjlVwhrrP5t8WqnOHcXhYRnppKNzDQm6QkiBNEVVue1f7nEwoP1NHLm1SnSl3JGe71k6bJ/il0wQdyly00mWZYZdNTwOpQw6Q11Uq0ZT//RpfMOu0URO6Tjax3eTRXS0bSYX3l5sBVx9x9ZmpojIs2+aEvklVIfIHHS1majM= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: d4577e3b-0cad-4023-a7e0-08da6e6542af X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 17:44:01.5750 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1484 Hi Stefano, My colleague Jason Lei and I would like to submit a patch to imagebuilder. It seems that generating a .fit with a true dom0less configuration fails be= cause an extraneous comma is included in the its file. We believe this change resolves the issue. Thanks, Jackson -- >8 -- Remove extraneous comma in generated its file when no DOM0_KERNEL is specif= ied. diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 8f08cd6..6f94fce 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -676,7 +676,12 @@ create_its_file_xen() i=3D$(( $i + 1 )) continue fi - load_files+=3D", \"domU${i}_kernel\"" + if test -z "$load_files" + then + load_files+=3D"\"domU${i}_kernel\"" + else + load_files+=3D", \"domU${i}_kernel\"" + fi cat >> "$its_file" <<- EOF domU${i}_kernel { description =3D "domU${i} kernel binary"; From xen-devel-bounces@lists.xenproject.org Mon Jul 25 17:50:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 17:50:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374742.606908 (Exim 4.92) (envelope-from ) id 1oG2EB-0004Ct-CO; Mon, 25 Jul 2022 17:50:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374742.606908; Mon, 25 Jul 2022 17:50:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2EB-0004Cm-9b; Mon, 25 Jul 2022 17:50:47 +0000 Received: by outflank-mailman (input) for mailman id 374742; Mon, 25 Jul 2022 17:50:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2EA-0004Ce-0S for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 17:50:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4d5bdcf7-0c42-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 19:50:44 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4d5bdcf7-0c42-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658771444; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WISRva/7OJYvlUnuWZvJyWPyAeP97N5JN+mLOlGSdzM=; b=hrQrPQzs9GJVfCk4fe9L7GdRfP/A0aFJb2QNzqGU5bKvGkBKbJp0YBEg Fbhiyd+knrstn8g/gNqO3+Ku3vvv7U3XupMCn6VSSkX3cnPG3VUlYZ11s BZJej9Lv9y2bNuZyKstJP3Knn88wJNitANLknem5DKTrgU6lEp8jGMgP7 c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76380120 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:QxvQv646aA6FMbXoHhzTVAxRtEPHchMFZxGqfqrLsTDasY5as4F+v mofCGGHbqnZNmHzL9p/Ydu/9BgDu8XVz9MwQFE6pHswHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5qmq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJBsTMNUipcgoPXpL8 u4RBw1QSRrYwO3jldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESzRJNk0aF9QVm+Cwi2OkWzZZtEiUtew85G27IAlZj+a2YIKMIITiqcN9o37Fv U/o337AHksWE9Ch7yS53CiUr7qa9c/8cN1LT+DpnhJwu3Wx7GEODBwdVXOgvOK0zEW5Xrp3K UMO/TE1hbMv70HtRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnNAybSwn0 BmOhdyBONB0mOTLEzTHrO7S9G7sf3hORYMfWcMaZVEg7oHZ/69ssgnKScRqP5PoqdeuXj6ll lhmsxMCa6UvYd8jjvvmrQya32z3/PAlXSZuuFyJAzvNAhdRIdf8Otf2sQWzAeNodt7xc7WXg JQTdyFyBsgqBIrFqiGCSf5l8FqBt6fca220bbKC8vAcG9WRF52LJ9k4DMlWfhsBDyr9UWaBj LXvkQ1Q/oRPG3ChcLV6ZYm8Y+xzk/WwS4S6CaqENooXCnSUSONg1Hg1DXN8Iki3yBR8+U3BE czznTmQ4YYyVv08kWveqxY12r433CEurV7uqWTA503+idK2OS/KIYrpxXPUMYjVGovY/1iOm zueXuPWoyhivBrWOHCPqdBJcwFVfBDWx/ne8qRqSwJKGSI+cElJNhMb6ep4E2C5t8y5Ttv1w 0w= IronPort-HdrOrdr: A9a23:5DGMXqMSl6LXzMBcTs+jsMiBIKoaSvp037Eqv3oRdfUzSL3/qy nOpoV96faaskdzZJhNo7+90cq7MBfhHPxOkOss1N6ZNWGM0gbFEGgL1/qa/9SKIU3DH4Bmu5 uIC5IObeHNMQ== X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76380120" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Juergen Gross Subject: [PATCH] x86/pv: Inject #GP for implicit grant unmaps Date: Mon, 25 Jul 2022 18:50:13 +0100 Message-ID: <20220725175013.893-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit This is a debug behaviour to identify buggy kernels. Crashing the domain is the most unhelpful thing to do, because it discards the relevant context. Instead, inject #GP[0] like other permission errors in x86. In particular, this lets the kernel provide a backtrace that's actually helpful to a developer trying to figure out what's going wrong. As a bugfix, this always injects #GP[0] to current, not l1e_owner. It is not l1e_owner's fault if dom0 using superpowers triggers an implicit unmap. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Juergen Gross This is a prerequisite to investigating https://github.com/QubesOS/qubes-issues/issues/7631 which is looking like an error in Linux's gntdev driver. --- xen/arch/x86/mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c index 5b81d5fbdbb2..b3393385ffb6 100644 --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -1232,7 +1232,7 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner) gdprintk(XENLOG_WARNING, "Attempt to implicitly unmap a granted PTE %" PRIpte "\n", l1e_get_intpte(l1e)); - domain_crash(l1e_owner); + pv_inject_hw_exception(TRAP_gp_fault, 0); } #endif -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Mon Jul 25 18:16:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 18:16:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374749.606919 (Exim 4.92) (envelope-from ) id 1oG2cn-00070E-Ed; Mon, 25 Jul 2022 18:16:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374749.606919; Mon, 25 Jul 2022 18:16:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2cn-000707-Bp; Mon, 25 Jul 2022 18:16:13 +0000 Received: by outflank-mailman (input) for mailman id 374749; Mon, 25 Jul 2022 18:16:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2cl-0006ze-Na; Mon, 25 Jul 2022 18:16:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2cl-0006V6-Kd; Mon, 25 Jul 2022 18:16:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG2cl-0005eS-D1; Mon, 25 Jul 2022 18:16:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oG2cl-0002Hd-CZ; Mon, 25 Jul 2022 18:16:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=hd3M1uPBmQjlSV1UB3senElrOAVbZHFT6pZ8cR86+L8=; b=xWw6AUYPsHYJAuTY8Bw7LdgxtF Wyji+FEBg7TIn9QrnU+mPCrn2TLPHDRiw6nRyx366d702MqB91Aiuj3QYe8hR2+lu+VKmgRnYOxq2 Ii7Fh/6bV85shL9iziFgzbQarxKDAm2N1swDrVi9r7bX39ZcR4OZY5tuYgSo5iNFSSnA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171855: all pass - PUSHED X-Osstest-Versions-This: ovmf=a47241f1337c2ce78179b7db939faebd7828d8d0 X-Osstest-Versions-That: ovmf=8a5782d704cfeb78aafdec1c03685107586f4ee6 From: osstest service owner Date: Mon, 25 Jul 2022 18:16:11 +0000 flight 171855 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171855/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf a47241f1337c2ce78179b7db939faebd7828d8d0 baseline version: ovmf 8a5782d704cfeb78aafdec1c03685107586f4ee6 Last test of basis 171849 2022-07-25 02:42:04 Z 0 days Testing same since 171855 2022-07-25 16:40:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: PaytonX Hsieh jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 8a5782d704..a47241f133 a47241f1337c2ce78179b7db939faebd7828d8d0 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Mon Jul 25 18:54:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 18:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374758.606930 (Exim 4.92) (envelope-from ) id 1oG3E9-00034I-At; Mon, 25 Jul 2022 18:54:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374758.606930; Mon, 25 Jul 2022 18:54:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG3E9-00034B-7D; Mon, 25 Jul 2022 18:54:49 +0000 Received: by outflank-mailman (input) for mailman id 374758; Mon, 25 Jul 2022 18:54:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG3E6-00033z-Nz for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 18:54:47 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3dfbb307-0c4b-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 20:54:44 +0200 (CEST) Received: from mail-sn1anam02lp2042.outbound.protection.outlook.com (HELO NAM02-SN1-obe.outbound.protection.outlook.com) ([104.47.57.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 25 Jul 2022 14:54:40 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CO1PR03MB5764.namprd03.prod.outlook.com (2603:10b6:303:6c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 18:54:38 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 18:54:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3dfbb307-0c4b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658775284; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=KT3b4QFAbJb7FmbVNKQ73N98HuLURsXs+2Cu0eGeDJQ=; b=ChkT2YzFsh2/wwCpIvO53iXpJ/S8hFnHmeTPYc0/Ek8jgkzEq/+fYxGZ CSr0GPCHyh8RMYbJWiOPHFITckh0ypaDw3rFgX1d/qLsTBNM6nfL3F8t0 TllINUVcXOJU6iXMppaLZivoYWqJvWebH5AMa9czXzNBp6CsXT14hgbUl s=; X-IronPort-RemoteIP: 104.47.57.42 X-IronPort-MID: 77019704 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:UhCDeKJLwCxiQ+NyFE+RDZQlxSXFcZb7ZxGr2PjKsXjdYENS1mAFz mtMC2nVP/2Majf3KYtzbN+/8hkPsMTQm4RmGlZlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/3Z9Us11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE+tg1F1EIYrEiyP9aXj8U7 uZHGBlVcUXW7w626OrTpuhEoO0GdJOuB6VG/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H12T+jKVW0q3rMzUYzy0HVwBZ8z/7GN93Nd8bRbc5UglyZt iTN+GGR7hQya4PHkGvaqi7EaunnpTreQKAYN5yCrL1pnVDO5mA3GQ9GfA7uyRW+ogvkMz5FE GQW8Cczqak59GSwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQoy 1uIktXBFTFp9rqPRhq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kbkRbnXttlVqmvgbXdGTb2z CGarSEWjrAan8kNka68+Dj6bymEo5HISksu4FzeWGugtll9fNT9O9bu7kXH5/FdKorfVkOGo HUPh8mZ6qYJEI2JkyuOBu4KGdlF+sq4DdEVunY3d7FJythn0yXLkVx4iN2mGHpUDw== IronPort-HdrOrdr: A9a23:2rev/65J4NJAf+19sAPXwUKBI+orL9Y04lQ7vn2ZFiY5A6qlfp GV9oV96farsl1hPE3IwerwTZVohEmsvKKc4eEqTMqftXrdyR+VxeBZnOnfKljbdxEWmdQtpJ uIH5IOc+EYSGIK//oSgzPIUurIouP3gJxA7N22pxgCPGIaDtAYnn9E5x6gcnGeBjM2dqbRfK Dso/avzADQBUj/G/7LeEXtKNKz2OEj+qiWGyIuNloM7gSDsC2vrJr3CQKR0Bs/flp0sPQf2F mAuQr16pi8tcihzBXRzXXe4v1t6ZncI+94dYixY4UuW2/RYsnBXvUuZ5Sy+BQO5M2/4lcjl9 fB5z8mIsRI8nvUOlq4pBP8sjOQnQrHvxXZqGOwsD/Gm4jUVTg6A81OicZyaR3C8Xctu9l6ze Ziw3+Zn4A/N2KSoA3No/zzEz16nEu9pnQv1cQJiWZEbIcYYLhN6aQC4UJuFosaFi6S0vF2LA BXNrCP2B9qSyLFU5mZhBgx/DWUZAVuIv5SeDlShiSXuwIm1kyRgXFohL1Lop/HnKhNDKWsrN 60RZiAr4s+BvP/t8pGdb48qPuMeyrwqFr3QRSvyHTcZfk60iH22sXKCENc3pDkRHT+pKFC1K gpFmko6FLaU3ieQvGz4A== X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="77019704" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CvSNpDXjK2iSH8bc/y4LHiHMzu5/XIYpU2UMpgGrt0hP1RJt3jp/E3QuHhN988jGCWyjiDrkboyv4YcxB9K1dRp4CHwjRp6qT9vfMqL/LirmJMDoTy3aiF7p6vst//zkjxWiwYvYATmN4bxmIqkNKxXAsXqpUzzQ+syR8uXdTvmhFN8kG+skQoBkpfIIKzGNGJgViR9tkJ1lQiXYOZoU3nAdjPC0/Ty+nIA7AsOqFv1tzxmBeD3tKGc/uDLE6V3566uSWRMpHbtDdOmrTQ4cfQyDGHDRDwe27fATZE+sMLyXxcCnTA1hauvsgub6QVCQBCwIvqQY7gzkeLYjgIYayA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KT3b4QFAbJb7FmbVNKQ73N98HuLURsXs+2Cu0eGeDJQ=; b=mp8dscp/VkO6LM2Qpei9WM1cbUK3Ftqxf3bL9jgt0+K9Xd50UIZULzdcCYfgjd7lOgBrHayF8NGu48Vljae2T9PpQ/a0xz26M5YD+hxFfL8xRIvzEAQlvO6ANlskILOTNmnBule51Y5teybqNZTvbRB2ILkafGFE4yxDPqDFVEY1CZG019Y65FmGDfizfuiPNHpuBdqDqW67m5oIyAn5yf23m4vcRZEqbp/yP+q72VUZ9aVjYZlObyOntjvCuFQSKgdmQQOcPW0/vqgRKVakH0fO/EBJdQ/FqiinSDKa6tFbW/DOI48M7n7FRI2fVVKfiF9IiyEf7EhZrBDjedCsqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KT3b4QFAbJb7FmbVNKQ73N98HuLURsXs+2Cu0eGeDJQ=; b=c2AX+Q36xL11W7/zQLY9qr6pYU94e97sYOg5FnIcjF5n6hcs39iSKQH+7IFtXmSKCnC/un+WoR613Q+TZrCKRjqN4gPyvT1tsrjmS2vv7qJ4dS7PqzLBR0ILxBc04CyxvNHMgyFPRalwXupIfJsADQDpp7efAsbIN1vesqhzK0o= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "Xia, Hongyan" Subject: Re: [PATCH] page-alloc: fix initialization of cross-node regions Thread-Topic: [PATCH] page-alloc: fix initialization of cross-node regions Thread-Index: AQHYoCf56rW3CCsK5U6FSVvXkA9srq2Pb6mA Date: Mon, 25 Jul 2022 18:54:37 +0000 Message-ID: <1f43b3a1-a580-d1a7-c52e-06ba591ae3a0@citrix.com> References: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> In-Reply-To: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bc9ab57-ff0d-41d1-2e4d-08da6e6f1fc5 x-ms-traffictypediagnostic: CO1PR03MB5764:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SANUet+oLoixi7OUKjwVKAoH0cIEW+PA/dCsKGeBJF1kUP5DOlFqF+WQ6hqVFgHZxMeoYYCgaYA+6og927Szvg1E8MvHdWG1Ffucl8UGCGNwOarEwVK9uUm/lNwFjBAkBvXbEgVSvqNpEPXdH4xQ/zj0rnYZh/Nzfrs28oygt5of3dtcrRnazOhZ4gAV4tf0emR8Y1gaoSCq9oY2Mosc4t2Gghu8jdI6J+V/nplxJ5+7dcR7BF5MOBBsOI0QBdZAyFhpJN7/SWBmXOBSStECzCBmWNA3YK9N/Br9wjOEsDe6b3n9qilXMvl5HiVft6ahxFFm6gLcSdCDO+ZQ+4tLBdLwWre8NMeA/Tyow3ZRVnAdCRIUc8XKtlrzTGXDxMRu7kh8KWuOhaJfjNn511eqBHtsvEuyNEldWfkreawZ/Gfgb5SvI1CcKDlcQS2X4bcIRFedQpLuyqNj04ZpjP4Y2/bH036e52zUfRG9ilqRwHbuJozkzdSQFW34IHOmpP1pwzng4+AH24W9p79CcVM4hX2us86X11xQ0bmiaTIJHbykmEv9tDsuPEvTRTSLx7uYriORSdHNbZwt6mPRYAPE/CwTSUHtytv0GzgWG/isMHjFBA7DqfK4DLAy8h2mvJHrqlA3zzRISjSm9NfUgydIYvtpMauavOd9tE6SX9wTTcwpWb429dkHcLmNCTCgZTa7ScURH7Q8rzdmeIvBTJHUCYMjMy4VzQ7WiP5V3hVylpR7WlM5RTqM9etkHgBamCZpNpxAfuoKCmqFrB6SOeCtpamY5O2/D8gtqQ9/Hk7kFd+ISTDUXy5n3tx+weDH9i3u4S9fumc7zI19H1T3c70s9/Uf4L+hkGCSinuOVz874z7CV6hiVY74imeL7z8iDXRA x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(376002)(396003)(346002)(366004)(110136005)(54906003)(316002)(71200400001)(478600001)(6486002)(41300700001)(2906002)(53546011)(76116006)(91956017)(4326008)(66556008)(64756008)(66446008)(66476007)(66946007)(8676002)(5660300002)(82960400001)(31696002)(86362001)(8936002)(31686004)(186003)(38100700002)(2616005)(38070700005)(26005)(36756003)(6506007)(83380400001)(6512007)(122000001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RldkQVNzYTRaRTRORHZuMHFBYkt6cEZNR3FoU3NZeVJnbzJJTEVGMTdzWEc3?= =?utf-8?B?TjVZR2QwRmJBS2xWVUQ5MWZOSXQwazQ0aTVCSDVSYkFKWnFoMzFkUWsyWnJE?= =?utf-8?B?SmE5TSttcUhXNjJCZC9PUVFJNndveHhMemtpRVdaaDZ3cmhRc1k2MVZER3oz?= =?utf-8?B?QmtLRy9rbHJwV2pLSFlaSzhZYUpsQ2JlSzZQTC9TR1ROZnQvRkdVMXNqK3VX?= =?utf-8?B?cWxjMSt1NDdBMmZuVFJaMUsxNU9HRERiUWxVSTQxTmJ1cUhTSmE3cmxWMVNl?= =?utf-8?B?TkE2eElQbGZoVXpHTlZnK0pwT1dtTGkrOThjNTVTOXMzTWxWR2RaSUtraEJM?= =?utf-8?B?bHkyZGVkWkFNQnhQQ05ZU25XeCsyblk4YmxyR1RuU2d5U0xScWRkU1o4WVJy?= =?utf-8?B?NjVaSDlSQ2R4QmdvaDE0Y2xNb3NPSG1QdjAvQ3UzT2QyVUN6L1hCaElCNUZZ?= =?utf-8?B?YWM2R2hkN1lkOWttSThtb3NEc21yL25KcU03V3Y3S2VuUzBGVkpRSFJnUzkx?= =?utf-8?B?b1k4dnBpSGtmZzlUMEdaODBpajBiTUJsMEF1cWlvajRpNzJjZlBFcEQ3UHg0?= =?utf-8?B?cnlsL0JnRUsvUGxvdEJwdnZlWWpRU0dORlRkZk1OWmZ0VGp3YUFCcnc3RVBU?= =?utf-8?B?WTFycjZlemN0aU9hdzFsTUtHN2NTRWU0TjFHMExXTjh0L3puSnBZWnJuNDFu?= =?utf-8?B?WHdrYjU3YkpsL3E3TGY5K2pqYlhnQWxSd3FwNzdDNHFyd08yb2M5VTlkRkEx?= =?utf-8?B?dy9WQ1Y1MGZBa0dZaWRIL0tZZndaUGljR2gxYjU1NTY3SzMyb2NVYVpiQmdq?= =?utf-8?B?RWpQR1I3RDlNdjZrTlJaR1FMZUdyL25jVGc2NjFIL2RNMnh3MUpiQlNIVmZB?= =?utf-8?B?czZkR2UvMkZTTTdvdmZTSGpRSU5QNzRJODJQMElmRURGOFllaVU0cmtYV3JT?= =?utf-8?B?UTNhaFBnUURJRUZGeDU2eVhuUWxuNlg2dE5tc2tPK09oVE55ZnlzNnQvQ1BU?= =?utf-8?B?eE04OGVya1VNMHh5UTBHWGdxQlZDYmttK21TRkszenQzTXZlVXlMSWgzTDdX?= =?utf-8?B?L1BESmlrNHhlRGtNaXAxUWNndEVQWkxnbEE5ZmdsaDBKSHdNYXloWDg5TERP?= =?utf-8?B?NWhGMjRIb2d5WXlDUk9obVFiM01ac003VU5CYlNTeGxTVkNUcVcyVHdETC9m?= =?utf-8?B?aG5aSnoway8vQU9KMVRrZ0tHWmZMMy8zTkZNTFhwNnByRjExajZ0Z09neW50?= =?utf-8?B?aVVOVHlvTDhiWUY3M2JhOVNic2YvdkJ5ejgzaHI4MGtVeEtDSjVSQjVSU0or?= =?utf-8?B?Zk5yVlk2Y2ZlME5FNGg2bWpzZTJOcVVFSE5LL2pCK2xRNWgxeE9Nd0hKM3BP?= =?utf-8?B?bXE1UXdCb0VIMDF0UGRiODBTOUNqMkVWdEhQaGkrRUhya2hWRGNNZUFFUHFu?= =?utf-8?B?RWpWWDVQYmFqUlNHQlNtbEpPWDgvZkcrbHEwUVp4VXlhRHpERVZiQkdCdlM2?= =?utf-8?B?Y2cxSk1Ua0YvVWdVbVN0YkV0eFhlSGNhc0NnS2IxRTVrZkpNaWxseG9Ka0Rv?= =?utf-8?B?K1Bob2tYaWkvSUJPNGNWKzBGdmw3M0x4d1VoL1R4UU9nTnlYSStLK25CSG9r?= =?utf-8?B?TGx3Z3ROejk1SjNOeEdkZHB5S2lCV3E1bWVnSXo4YnFtekpoRklZUlY0K3Ny?= =?utf-8?B?b2tqRmRyaTYvd1EvUndTaFFFQzBJNm5aQXVta0hSdkFyYWN2TzhIcEhZWCtq?= =?utf-8?B?R3gydjhRWG5uL1hqaHFPekVmOXVrU2c3UThDdDIzZjNvVFNzMUwwYkFRdThh?= =?utf-8?B?QnlaSjlDV0gwMHVvdi9oTE5iWkZmWWJlQ3JoTGxOL1FDbzlGWEMxL3BxY0F2?= =?utf-8?B?YUZmeWNTV1pUZWo1NjU2akIvWjVlNFBjQ09lOW9hY05PQWpQZFVnMjNFczFE?= =?utf-8?B?RXRvblMxeUJyQnlnMHQwenJHekhMMCt1aXprMFRmUm9ZaFhKNnY3bTZxUzhl?= =?utf-8?B?bTZ3K2d0UEZkT2lpUzJ1Sk5tVXh4Qy9CbGRNdUtxdXp2cVZhWkx2MDdockxq?= =?utf-8?B?ZnBvbUJ6NlBJZzRKKzBLZVJ5SzRoVXlOaHZQUVloN2s5Y2w1UzAxV2tPMkpT?= =?utf-8?Q?3uSkATCtZn7abNLtWp9Fos41k?= Content-Type: text/plain; charset="utf-8" Content-ID: <9BBFC74553B0E548AA5810253414F394@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bc9ab57-ff0d-41d1-2e4d-08da6e6f1fc5 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Jul 2022 18:54:37.9319 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XQLsWQgExOnQFf3yf9hFG0qwNLBLPKYk81PCH+XN0jnRIu28oIO6QTZvjyDt8tdBjz5HPX8m6XCbx1YyAhGjlDFLy5VxObNlZFRjwGK/OYg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR03MB5764 T24gMjUvMDcvMjAyMiAxNDoxMCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFF1aXRlIG9idmlvdXNs eSB0byBkZXRlcm1pbmUgdGhlIHNwbGl0IGNvbmRpdGlvbiBzdWNjZXNzaXZlIHBhZ2VzJw0KPiBh dHRyaWJ1dGVzIG5lZWQgdG8gYmUgZXZhbHVhdGVkLCBub3QgYWx3YXlzIHRob3NlIG9mIHRoZSBp bml0aWFsIHBhZ2UuDQo+DQo+IEZpeGVzOiA3MmIwMmJjNzViNDcgKCJ4ZW4vaGVhcDogcGFzcyBv cmRlciB0byBmcmVlX2hlYXBfcGFnZXMoKSBpbiBoZWFwIGluaXQiKQ0KPiBTaWduZWQtb2ZmLWJ5 OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQo+IC0tLQ0KPiBQYXJ0IG9mIHRoZSBw cm9ibGVtIHdhcyBhbHJlYWR5IGludHJvZHVjZWQgaW4gMjRhNTMwNjBiZDM3ICgieGVuL2hlYXA6 DQo+IFNwbGl0IGluaXRfaGVhcF9wYWdlcygpIGluIHR3byIpLCBidXQgdGhlcmUgaXQgd2FzIHN0 aWxsIGJlbmlnbi4NCg0KVGhpcyBhbHNvIGZpeGVzIHRoZSBjcmFzaCB0aGF0IFhlblJUIGZvdW5k IG9uIGxvYWRzIG9mIGhhcmR3YXJlLCB3aGljaA0KbG9va3Mgc29tZXRoaW5nIGxpa2U6DQoNCihY RU4pIE5VTUE6IEFsbG9jYXRlZCBtZW1ub2RlbWFwIGZyb20gMTA1YmM4MTAwMCAtIDEwNWJjOTIw MDANCihYRU4pIE5VTUE6IFVzaW5nIDggZm9yIHRoZSBoYXNoIHNoaWZ0Lg0KKFhFTikgRWFybHkg ZmF0YWwgcGFnZSBmYXVsdCBhdCBlMDA4OmZmZmY4MmQwNDAyMmFlMWUNCihjcjI9MDAwMDAwMDAw MDAwMDBiOCwgZWM9MDAwMikNCihYRU4pIC0tLS1bIFhlbi00LjE3LjDCoCB4ODZfNjTCoCBkZWJ1 Zz15wqAgTm90IHRhaW50ZWQgXS0tLS0NCihYRU4pIENQVTrCoMKgwqAgMA0KKFhFTikgUklQOsKg wqDCoCBlMDA4Ols8ZmZmZjgyZDA0MDIyYWUxZT5dDQpjb21tb24vcGFnZV9hbGxvYy5jI2ZyZWVf aGVhcF9wYWdlcysweDJkZC8weDg1MA0KLi4uDQooWEVOKSBYZW4gY2FsbCB0cmFjZToNCihYRU4p wqDCoMKgIFs8ZmZmZjgyZDA0MDIyYWUxZT5dIFINCmNvbW1vbi9wYWdlX2FsbG9jLmMjZnJlZV9o ZWFwX3BhZ2VzKzB4MmRkLzB4ODUwDQooWEVOKcKgwqDCoCBbPGZmZmY4MmQwNDAyMmRkNjQ+XSBG DQpjb21tb24vcGFnZV9hbGxvYy5jI2luaXRfaGVhcF9wYWdlcysweDU1Zi8weDcyMA0KKFhFTinC oMKgwqAgWzxmZmZmODJkMDQwNDE1MjM0Pl0gRiBlbmRfYm9vdF9hbGxvY2F0b3IrMHgxODcvMHgx ZTcNCihYRU4pwqDCoMKgIFs8ZmZmZjgyZDA0MDQ1MjMzNz5dIEYgX19zdGFydF94ZW4rMHgxYTA2 LzB4Mjc3OQ0KKFhFTinCoMKgwqAgWzxmZmZmODJkMDQwMjA0MzQ0Pl0gRiBfX2hpZ2hfc3RhcnQr MHg5NC8weGEwDQoNCkRlYnVnZ2luZyBzaG93cyB0aGF0IGl0J3MgYWx3YXlzIGEgYmxvY2sgd2hp Y2ggY3Jvc3NlcyBub2RlIDAgYW5kIDEsDQp3aGVyZSBhdmFpbFsxXSBoYXMgeWV0IHRvIGJlIGlu aXRpYWxpc2VkLg0KDQpXaGF0IEknbSBjb25mdXNlZCBieSBpcyBob3cgdGhpcyBtYW5hZ2VzIHRv IG1hbmlmZXN0IGJyb2tlbiBzd2lvdGxiDQppc3N1ZXMgd2l0aG91dCBYZW4gY3Jhc2hpbmcuDQoN Cn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Mon Jul 25 20:49:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 20:49:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374769.606940 (Exim 4.92) (envelope-from ) id 1oG50P-0006Qj-LO; Mon, 25 Jul 2022 20:48:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374769.606940; Mon, 25 Jul 2022 20:48:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG50P-0006Qc-Im; Mon, 25 Jul 2022 20:48:45 +0000 Received: by outflank-mailman (input) for mailman id 374769; Mon, 25 Jul 2022 20:48:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG50O-0006QV-1E for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 20:48:44 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 28f41bfd-0c5b-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 22:48:39 +0200 (CEST) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26PKhoGR008803; Mon, 25 Jul 2022 20:47:03 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg9a4mpke-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Jul 2022 20:47:02 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26PKM0tQ017379; Mon, 25 Jul 2022 20:47:01 GMT Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04lp2040.outbound.protection.outlook.com [104.47.73.40]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hh64ys353-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Jul 2022 20:47:01 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BLAPR10MB5283.namprd10.prod.outlook.com (2603:10b6:208:325::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Mon, 25 Jul 2022 20:46:59 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5458.024; Mon, 25 Jul 2022 20:46:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 28f41bfd-0c5b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=QUsg1I9/CaAjDKyQ8r5mqHTb3KdEpWdYfi5h2h3wmg4=; b=uVJyYcyQAK1XBDo9BCZhrgGMcGoHIYgpF1Wl4csJvWwyVDW+svGvSGc6rd/7b27b8+ti yGmy8bsu1aIYIjX076mcmeYUU4GTNvysikodb3nOb46dOKgybkMhVhUjKf/bm5tUaI3S NRzbDTQroQp8Wv9D+cOi1zVgnJ8uAx9RPjJnOFHFAE7rUdhFdV0vcfASU3e9Y1k0vuhN RLhcAvLJMGq7Sjw9MJ94gKqGZnLbT3kDcqMAMVP0JrZI80FqhKWDryDPQanYBqRn/OjH vNBISez3OJF9kzI/kLl/3oqmgPzqjzl8Elttj3ZYOcqMMv0vuPdbtcKYjFmZKB9YDmRs rg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JnGmskViF5qdb+ZT99gHTjyVXBKVPkZ/vgV67X/MpZX32hogysuNEKlJxvseygt4tYY/5JUyG5JrsvZslDwq6TyJ/1C4XT6vkLKcXr4mChMdb2kdvjNYnvQdRNdSqZT0SmHUBSg5Jw1+6mXigMD5/EDM+3NnGQIdCbzTRPOMjzlBNE4iRUYl1I1tgcmnJFZmG3eaJAGAxQdbZBwyQ7jEVQjdwzamFMRuSpmoiJiVaMxgdfFngrUy7CHLxDhvFKwnYH8pLW4gBSI3tbr2OuCpNHiWWOe8VxCWI6TBLsHTAnASsPQJUJSVQ2vmTD08LTl+aKSUEIlU+9giAN0vPJTHIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QUsg1I9/CaAjDKyQ8r5mqHTb3KdEpWdYfi5h2h3wmg4=; b=EbqgqIn3F0eik4MjJ92lPjQyybVZ3NkRhiOQQlUNPjFiD66mhQjSdS8jsNcGTE53RviwnJ/tvMln7l41lN66au4zIc79XMPKUJcWSpvKpqsYf0eais8kDfMlgQelLcZ2L1ERQPwWcGNU6ty8+m3S+14mRbtfHKr67HKSr+5BVO4xuj8jtaklRbIBxLa3xF2csLhBs/0/qqgeWgr96CXwUDPDtltkrVZe8WLtRJsWeBU2fsdlgsfD45VuzDhOg286u4nleFmhO7o1YQmucHBQ1CiAbvbPQU/4VUPtbOEO8ySDScEzlVIQA7BVG5wHKs5AcIGlK4SrmUIAjwP59f0WiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QUsg1I9/CaAjDKyQ8r5mqHTb3KdEpWdYfi5h2h3wmg4=; b=LAsSm/fR2KnzL3/lkkPHhJ4t94iOnAvC87faD8G0nfHEAo7Ft6oD01rW5zwz9C1pAbSQkJ8k10lvuiktCRvXsUb/zw2TPdyE9jkok9Vrv/rXx3+NMKlr3x3a4Lm63wlBcz2z3mxCDyrqeHmo3TMvuE0YyU4N8eeoPWQH9xaR/wQ= Message-ID: Date: Mon, 25 Jul 2022 16:46:53 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane , Andrew Cooper , LKML , Xen-devel Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> From: Boris Ostrovsky In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN6PR2101CA0030.namprd21.prod.outlook.com (2603:10b6:805:106::40) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 708a937b-6ec0-402c-a09d-08da6e7ed1ac X-MS-TrafficTypeDiagnostic: BLAPR10MB5283:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pu2/ubNIdW2gMQwF/6o+1P2VAyXwXPIbTYgg3RCiPHtlatmB7lzDy8l6TfwiUkSy9UPmXAhkRANQN3tTieDkgSVFwGgP/KHXnHy37+vRbI0yuV8isG1yJeBsrXQH8sfqY0mmv3kocDUMrCaw+sP/2q8s5bLVoLLPAAO7ch5Uw7EpmYx4HcjUuZv/eoJfyqucJ3nkCSs9IQfK1l9wBhwUe9IG8RDbExyRNvczWCHBui6KCgMtg96SN9kt5/ez5NrMdfM4ppf4aImD9kC45LI7ysLHtEIwQ90fuP3oVF3jwFPzbNaBuZE80sbV8D1MdF6ZTfuJrHIc0CZ6rbdN/5x6pII13B5/oY6DizqMl5z5Vu6ge+V4rUMR6yNJ2qUQ2gDORGp1R7h8oQ76w4bFm//D5cvRSwT/bW79IrWIWiIvdxZMdK5lQILxbhYQY56aBudROZiTyMF8+1U5UG+noesYLKhFGXzD/oM3zL09FRkvevQO2QvdM0eimJzm3pRZbKYGiqn5bJA4c6lWFzzrandS91End3Bu7XETq7f6q2gv2eJi6nxZUODOmXLoTp0IpbWawT1vBhnn5ys3/1w5h9yQsJQe/moayBuG/9W6nDRssC13dmZpAEi4/3DvoA2D0opDoy2JvpS+rPDAxKMaU+qk2DL2s6P0WnrSmdV4c6iswYLIt4m+idcVtNulj12B6ZFlZhKz710F/4Uqp3ZwRL1yorKuB5Zdz9Bde1FrNL2bP9SI3DynozgEeA/VbBrHBEiiqZ3xilTL54QI089gvdovyazQB8+DDvyqraBnemXbwYHWTdTCpENH0lD5q6hQWHBhtAGNHtq7TM0y+Cdgac6Vsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(39860400002)(376002)(396003)(86362001)(31696002)(6506007)(26005)(83380400001)(53546011)(36756003)(2616005)(186003)(31686004)(6666004)(41300700001)(38100700002)(110136005)(54906003)(6486002)(316002)(5660300002)(8936002)(44832011)(66946007)(8676002)(4326008)(66476007)(7416002)(66556008)(2906002)(6512007)(478600001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L2hURnNCZkRzK2RpR081SHpMTlcwTjFQWGNlK1RDUi9YYXNEVG01cFBlaStM?= =?utf-8?B?U2RIcVlJS2ZIQnJnNkdxdFdHNllic083Ui8rZHlhd0dLZ0dJcU54YzdzQm5p?= =?utf-8?B?K0NDWWd4Rm1mam5MV1A1b0gxajVpTmVXQVJvVkxvazFiZU5mdGVYVFE4Tklt?= =?utf-8?B?U1Q2RlFIYm9za3pqRHd2bytRdWE4a1JvL1E4YTE5aGpDVlplamlhRm5uUDJ0?= =?utf-8?B?NHJndFhvdUlFS2pTNkxTV2k0RktrQ2t5U0FYdDZtS2k3R205TEpFMnM5YVZT?= =?utf-8?B?MUdpOXQwbWtnMkZCdGJZR2U3NnpJM0U5Z3dabzdnc2gvSldQWE5kWkdyUzA3?= =?utf-8?B?SmZNNS8yalprcnR1ZUMweWRuekhPV3RSRGRMdlFYaXZTOHVVWk1ZeWRaK1E1?= =?utf-8?B?ajJQQUkxZzdGUFRPZGRROFB4blBxUm5rd1k3aUlxUHQveTYxOEo1YlJFRlBO?= =?utf-8?B?a0dnU21FRmFoSVpYMk1LcVovR2VUR2RvT05xS1RWd04wbE1YSDhsckNuZ29D?= =?utf-8?B?ZlJUcEc1Vm1pWThBcnRWVjY5Y3VvVmNUUHhJRS9VNWZyV0ZwSFZKTEIrOFlK?= =?utf-8?B?T1ROeEpqYyszckEzdyt3T2VIdnlkSGR5UU1LeUk5Ny9EN0lXYWF5ZmMxQXVn?= =?utf-8?B?RlJUSlIwamNCMi9tNndBbEI5MFY1N0dOMHpabENpZ3k5RnUveXNUTVZGVk5p?= =?utf-8?B?VXR0aSt0VTV4dGNQb1Q4ektsVTZqaW5LYUxDUE83Z1NYdWgrdGRjTUwvR1p5?= =?utf-8?B?Zms4MWEycmNueDgvQ28rMjJTVHpxNjBGZEpPVm1sNmJPajFwdTZubjVRUnVq?= =?utf-8?B?T25RcmxqWmFmdVB3d1k5V0c0SVpQS0NleThWL0RZeXhxMU81U282cDRVU1Av?= =?utf-8?B?L3RScWwzcW5JcWF3d0c3Yzd4QlE3MEtIbUVXWlpXcU1ScnphRnNyc3h5SEtv?= =?utf-8?B?bjVvekU1VnQ2SlpSczFTWlFTc1BVTTY2RlZFQUZNeTlJbVRpU25WM0tuY0Ja?= =?utf-8?B?TjQ1N2ZCSmNCNE9UV1FTQzQ0SXJDb28xV0ExTU1hWXpSbXRYdmVpSmFxbFRI?= =?utf-8?B?VVdxblB6Vm9kYkg1M3VkSTVUWXJIRnJCbnFvTE40MzhFSTl3a3JhREt3TXA2?= =?utf-8?B?TENaUkhRanM5bFNmOFY0MXlqZncweEpQbzlKL1RHVCt5VFE3c2xSbkNOTDM3?= =?utf-8?B?SGlpbHRGa0RYVUV5Qkw0ak1HSEhWMU5nd20wLy9uaFZ4K2ZHdzdubUM1QjNx?= =?utf-8?B?eGRGQ0FnRkxqTUNqWG8zV2xiUnVKbjc5YXdKNmQxZDFmYlJvL1lBNkh5YzlH?= =?utf-8?B?Wk1lek93YUdXaVo0MzgzMVVqaXhCMXFxMlk3MTJDTVRBa0M5MC8ydXZESi8w?= =?utf-8?B?c0htUjFYeHhUNHNpNnpvaTg1L1FsenhOdEFRWE8yR2g5cVYwTVcvQ3FSVVYy?= =?utf-8?B?NUdNSlVHY25RZG1vSVkvU2xETnpEY011MnJpNkgxUE1leFJ4NFM0M0NvQ1pw?= =?utf-8?B?aWlIdTNucXN2WTVHcWxXdXA3L1JBVnRtVE5Sd0FHb0hBSjNHZU1LdFNjODc2?= =?utf-8?B?THh5M1o4RUZSS09EdWNHRnAxRHdwT2J0OU9xNUdBUmZ4aUhyK2FSY3U0dDd4?= =?utf-8?B?eTVBY1ZKdk5ETUQ5bGlXMW82dmVSTytTTFRvU0RxTzlKYlBzNmNmVHpQamVn?= =?utf-8?B?Q2hZdlEvTlBDZmovREFGOHlYbUs2K2haMXF1cko2VTFpQ0hOaEh2TTlwb3JJ?= =?utf-8?B?WUsxdmNzRkdROTM3aHFkLys3anBpWTVpWk90d0VBb2VxVnZHbjZuWGlTMEZ1?= =?utf-8?B?cE1MRFdPb1N6RnpBYldYcy9raEJ6VjErWFhuOVJOTzg4bndBcGJzVnlTblg0?= =?utf-8?B?NExPS21FQllqTG9KRDBtT3QvMURZeEYxQjJiWk5XR3NUUHlxWmt6b0xCVisz?= =?utf-8?B?dmpqNDJQcDl0b3gxbVI4N3FTbDNYdG04MmdENHgwNlBYK2NtUGFUdm83Z2pB?= =?utf-8?B?MzZnTXlHcGRMSWVXbmZtc3VtUk9KSXJRbnZ2M00waHluZnJuTWNscHVvR24y?= =?utf-8?B?QUZnWkpoZCtXL29QSXEvM3NJSm5JQW92TStIaGVZTzc5WXlVQURHMU1OVjd2?= =?utf-8?B?UEJ5RkxkK3RvMjVWb2g5V2poTmRSK1Zkc2xaRGNWOHN6Yllsb3V4T0gvNjBY?= =?utf-8?B?RlE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 708a937b-6ec0-402c-a09d-08da6e7ed1ac X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jul 2022 20:46:59.1063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FvzXvS+O9MT8EPHDpMSl5FioSDsqkawD07DWiCu+AF2IUOv/6Al3H/B7rriA6qfV8897jMxOrK0FUCHQGcu2WywMOx4cvqaaEtuvt7z+6RE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5283 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-25_13,2022-07-25_03,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207250084 X-Proofpoint-ORIG-GUID: hKu8nYe2Keo72yhHldu1TYhEa_9LyMuG X-Proofpoint-GUID: hKu8nYe2Keo72yhHldu1TYhEa_9LyMuG On 7/25/22 6:03 AM, Jane Malalane wrote: > On 18/07/2022 14:59, Boris Ostrovsky wrote: >> On 7/18/22 4:56 AM, Andrew Cooper wrote: >>> On 15/07/2022 14:10, Boris Ostrovsky wrote: >>>> On 7/15/22 5:50 AM, Andrew Cooper wrote: >>>>> On 15/07/2022 09:18, Jane Malalane wrote: >>>>>> On 14/07/2022 00:27, Boris Ostrovsky wrote: >>>>>>>>         xen_hvm_smp_init(); >>>>>>>>         WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, >>>>>>>> xen_cpu_dead_hvm)); >>>>>>>> diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c >>>>>>>> index 9d548b0c772f..be66e027ef28 100644 >>>>>>>> --- a/arch/x86/xen/suspend_hvm.c >>>>>>>> +++ b/arch/x86/xen/suspend_hvm.c >>>>>>>> @@ -5,6 +5,7 @@ >>>>>>>>     #include >>>>>>>>     #include >>>>>>>>     #include >>>>>>>> +#include >>>>>>>>     #include "xen-ops.h" >>>>>>>> @@ -14,6 +15,23 @@ void xen_hvm_post_suspend(int suspend_cancelled) >>>>>>>>             xen_hvm_init_shared_info(); >>>>>>>>             xen_vcpu_restore(); >>>>>>>>         } >>>>>>>> -    xen_setup_callback_vector(); >>>>>>>> +    if (xen_ack_upcall) { >>>>>>>> +        unsigned int cpu; >>>>>>>> + >>>>>>>> +        for_each_online_cpu(cpu) { >>>>>>>> +            xen_hvm_evtchn_upcall_vector_t op = { >>>>>>>> +                    .vector = HYPERVISOR_CALLBACK_VECTOR, >>>>>>>> +                    .vcpu = per_cpu(xen_vcpu_id, cpu), >>>>>>>> +            }; >>>>>>>> + >>>>>>>> + >>>>>>>> BUG_ON(HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, >>>>>>>> +                         &op)); >>>>>>>> +            /* Trick toolstack to think we are enlightened. */ >>>>>>>> +            if (!cpu) >>>>>>>> +                BUG_ON(xen_set_callback_via(1)); >>>>>>> What are you trying to make the toolstack aware of? That we have *a* >>>>>>> callback (either global or percpu)? >>>>>> Yes, specifically for the check in libxl__domain_pvcontrol_available. >>>>> And others. >>>>> >>>>> This is all a giant bodge, but basically a lot of tooling uses the >>>>> non-zero-ness of the CALLBACK_VIA param to determine whether the VM has >>>>> Xen-aware drivers loaded or not. >>>>> >>>>> The value 1 is a CALLBACK_VIA value which encodes GSI 1, and the only >>>>> reason this doesn't explode everywhere is because the >>>>> evtchn_upcall_vector registration takes priority over GSI delivery. >>>>> >>>>> This is decades of tech debt piled on top of tech debt. >>>> Feels like it (setting the callback parameter) is something that the >>>> hypervisor should do --- no need to expose guests to this. >>> Sensible or not, it is the ABI. >>> >>> Linux still needs to work (nicely) with older Xen's in the world, and we >>> can't just retrofit a change in the hypervisor which says "btw, this ABI >>> we've just changed now has a side effect of modifying a field that you >>> also logically own". >> >> The hypercall has been around for a while so I understand ABI concerns >> there but XEN_HVM_CPUID_UPCALL_VECTOR was introduced only a month ago. >> Why not tie presence of this bit to no longer having to explicitly set >> the callback field? >> > Any other opinions on this? > > (i.e., calling xen_set_callback_via(1) after > HVMOP_set_evtchn_upcall_vector OR not exposing this to guests and > instead having Xen call this function (in hvmop_set_evtchn_upcall_vector > maybe) and tieing its presense to XEN_HVM_CPUID_UPCALL_VECTOR which was > recently added) CPUID won't help here, I wasn't thinking clearly. Can we wrap the HVMOP_set_evtchn_upcall_vector hypercall in a function that will decide whether or not to also do xen_set_callback_via(1)? -boris From xen-devel-bounces@lists.xenproject.org Mon Jul 25 21:14:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Mon, 25 Jul 2022 21:14:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374778.606952 (Exim 4.92) (envelope-from ) id 1oG5PE-0001Tr-PK; Mon, 25 Jul 2022 21:14:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374778.606952; Mon, 25 Jul 2022 21:14:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG5PE-0001Tk-LX; Mon, 25 Jul 2022 21:14:24 +0000 Received: by outflank-mailman (input) for mailman id 374778; Mon, 25 Jul 2022 21:14:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG5PD-0001TZ-Jm for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 21:14:23 +0000 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [2607:f8b0:4864:20::92c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c001397f-0c5e-11ed-bd2d-47488cf2e6aa; Mon, 25 Jul 2022 23:14:21 +0200 (CEST) Received: by mail-ua1-x92c.google.com with SMTP id u11so4941741ual.6; Mon, 25 Jul 2022 14:14:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c001397f-0c5e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Set6ijWuGy4kk4KHbyLi++Jqn9CFwke25VQzsJfBHGY=; b=aUBnqkfjwMvxaWE4FNacP1IABzdQfFgWi9V0j1XB/z1htkE1lUlfAsSUV9pFjIdK/U kRYnMmwJ0EaRZw0Y6vTtGQlndro2vCZbzsh9/mVu6YcRtYFwe5WupUf+uwujNXE0IHxb F+6zDdT2760Kf3qKDuduzpCP3lsMTzgCUeMB/lIU7Yh4ti3BV4xV7qPVRNu3OX58L10a /IRh9QWAsAU+S+/GR1z5FKRuK1t0GIuRDV4xi227vSX18tv8g6f+ciIm7+CkXVjnEDxV wJ02XmRdWmCc/fdE8l29LPEPlq58vVci6qaIg2mykbpo60LM2kcSPanUUFLaS8VWSQFO KLDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Set6ijWuGy4kk4KHbyLi++Jqn9CFwke25VQzsJfBHGY=; b=FmxSjOGJ+T/6zGu48dkk3FLbbkM1ZWOx8iiBNFwjziaaAxRmXTEZoenVl8CDKdwJzM b2kGj9V/2Cc4Xl5Uo6d8fKXFgjDTJ9GOdWuWg3ZTzjPTnMVSftz8pBemNNsWHAztzoT5 AYYWNaAYRbcnXvhKownpwiLwMlEFGzrbmSrJjXHkYqO8H/jCkHaZ6FDPKW9QE4M42CEX WsccbjYBKRXReV3cB7p4ZJP3uN1AHsM1zBtP3xl0Dd7RI//IXVNhpxKvinUoZgPIbOYG v3ZtC1UsP2Kqiec5tb3fQseUoTAwIXqQusrw3M7z+jLB4pAAuxzQXvylg2FwXCvlTFav jPOw== X-Gm-Message-State: AJIora+tCPMa1mgeeqmT9npVp0Lv7aViyVfcr70JrKSZQxxsJWTPPaIo /suHLAZjEfx3xuMWfJClqOOngvtS52iTOeJOeWs= X-Google-Smtp-Source: AGRyM1ufAzmhlSrUAJlVc/2Qjeo927hVxJS+pcpWx+xPdoH3occbMYIcqWvmjZDPS2nGj9C9oafjut6n724RJrAfaQ4= X-Received: by 2002:a05:6130:a1c:b0:384:679f:4ef with SMTP id bx28-20020a0561300a1c00b00384679f04efmr4097314uab.55.1658783660163; Mon, 25 Jul 2022 14:14:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christopher Clark Date: Mon, 25 Jul 2022 14:14:09 -0700 Message-ID: Subject: Re: Enable audio virtualization in Xen To: "SHARMA, JYOTIRMOY" Cc: "xen-devel@lists.xenproject.org" , xen-users@lists.xenproject.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 25, 2022 at 4:45 AM SHARMA, JYOTIRMOY wrote: > > [AMD Official Use Only - General] > > > Hi all, Hi Jyotirmoy, I have add the xen-users list to CC since this thread may be useful to that forum. > I am using ubuntu as dom 0 and also dom U (HVM). I want to play audio fro= m =E2=80=9Cdom U=E2=80=9D Ubuntu. I think that it should be possible to enable what you are attempting to do. ie. audio output from a HVM Ubuntu guest VM. Some questions to support assisting you: * Does audio playback work OK from your Ubuntu dom0? * Do you know which version of Ubuntu you are using? ('cat /etc/lsb-release= ') * Do you know which version of Xen you are using? ('xl info' in dom0 should help) * Do you know which version of Qemu you have installed in dom0? * Did you build and install Xen from source code, or are you using binary packages of Xen and its tools? * Are you using the xl tools, or libvirt tools for configuring and running your guest? -- ie. how do you start your domU VM? * When your domU is running, please could you run 'ps auxwww' in dom0 and obtain the process information about the qemu instance that is running, so that we can see what command line arguments have been supplied to it > I am new to Xen/virtualization in general. Welcome! :-) > From various reading I understood that I need to take following approach: > > 1. Use Xen front end ALSA driver in dom U I'm not certain that this is necessary for your HVM guest. Instead of using the Xen paravirtualized audio protocol, Qemu should be able to present an emulated audio device to the HVM guest domU, and a standard audio driver (hda or ac97) in domU should suffice. > 2. Use Qemu to connect to the backend ALSA driver in Dom 0 I think if Qemu is started with the correct command line arguments, it should be able to play sound on behalf of the guest, if sound is correctly configured and working in dom0. > Can you please let me know if this approach is fine? If yes, I have follo= wing questions: > > 1. Do I need to recompile Ubuntu to support Xen front end ALSA driver? Or= will Ubuntu iso file already have it enabled? I think the latter, that the Ubuntu installation ISO should already contain a suitable audio device driver that is compatible with the virtual audio device that is emulated by Qemu. > 2. Ho do I configure Qemu to enable backend driver? A little more information about what you're running will help with providing guidance here. The xl man page indicates that there is a "soundhw" option in the VM configuration file for passing sound hardware configution through to qemu, so if you are using the xl toolstack, you could try adding this to the config file: soundhw=3D"hda" Christopher From xen-devel-bounces@lists.xenproject.org Tue Jul 26 00:00:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 00:00:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374869.606998 (Exim 4.92) (envelope-from ) id 1oG7zO-0003cl-Ad; Mon, 25 Jul 2022 23:59:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374869.606998; Mon, 25 Jul 2022 23:59:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG7zO-0003ce-7x; Mon, 25 Jul 2022 23:59:54 +0000 Received: by outflank-mailman (input) for mailman id 374869; Mon, 25 Jul 2022 23:59:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG7zM-0003cU-OQ; Mon, 25 Jul 2022 23:59:52 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG7zM-0005aJ-L1; Mon, 25 Jul 2022 23:59:52 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG7zM-0004Gk-3w; Mon, 25 Jul 2022 23:59:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oG7zM-0005k6-3W; Mon, 25 Jul 2022 23:59:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/PpZqgy80AxY25yUAywbLcPZzBDZoNo2wVnkKNOR+VU=; b=P4Plh3v/EwG0H9Kz81A6hoEQTR Rarh/bhXPiCBdHg/ptcfoaT1KLZsVWjBnmnf87EJjGgFZy1VfMjivGD1HgitoSSePlSq4GbH81C+J xWs4xBhDcJm8WWI9HBdZMMglh1reFARMQBA2AEjlsjtFxq0QSLfVkHaLfbxvnPnrM7Ys=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171856: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:xen-install:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 X-Osstest-Versions-That: xen=fcd27b3c759995775afb66be6bb7ba1e85da0506 From: osstest service owner Date: Mon, 25 Jul 2022 23:59:52 +0000 flight 171856 xen-unstable real [real] flight 171857 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171856/ http://logs.test-lab.xenproject.org/osstest/logs/171857/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171857-retest test-arm64-arm64-libvirt-raw 13 guest-start fail pass in 171857-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 171857 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 171857 never pass test-amd64-i386-libvirt 7 xen-install fail like 171848 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail like 171848 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171848 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171848 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171848 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171848 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171848 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171848 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171848 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171848 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171848 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171848 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171848 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171848 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 baseline version: xen fcd27b3c759995775afb66be6bb7ba1e85da0506 Last test of basis 171848 2022-07-25 01:53:37 Z 0 days Testing same since 171856 2022-07-25 17:08:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Oleksandr Tyshchenko Roger Pau Monné Tamas K Lengyel jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt fail test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow fail test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git fcd27b3c75..f1c719d5cd f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 26 00:33:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 00:33:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374895.607082 (Exim 4.92) (envelope-from ) id 1oG8W8-00012P-8v; Tue, 26 Jul 2022 00:33:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374895.607082; Tue, 26 Jul 2022 00:33:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG8W8-00012I-5l; Tue, 26 Jul 2022 00:33:44 +0000 Received: by outflank-mailman (input) for mailman id 374895; Tue, 26 Jul 2022 00:33:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG8W7-00012C-5r for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 00:33:43 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 98971548-0c7a-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 02:33:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D58D61466; Tue, 26 Jul 2022 00:33:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9845DC341C6; Tue, 26 Jul 2022 00:33:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 98971548-0c7a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658795619; bh=tYxghph7QJqyKPD2IEK+sAJ6pT0jxePQEvrZQwQg404=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=YqoXBWBrtLydlBC4mTD/3xS/9PTDbB3RCjaIyGd4M06zFIGLZuvxw0R4jUHFK1y5Q ZLPGSVaiRr1hIEzSnYTiuzpas3iMoOxiAmDbFPE5Zk+T0or477cfFBD2fCccjXcwSg FGVG7p0a6SNK860Xtbf3fkOZUBzwMapz0yli+1AL3wyRFg3B3LlR9PhAi4jiQPzUxD kZWx+iXADvmchDFDNWxfGdojHo52LYJdvuYgG1OqbfAbXMwC7/QfRURPt1aSteTDsH oqFK2syUfbZw+3UH8iOetc0QSQMmr8d/HMENHDLWI/97/Ek5hkMBpvMMWWxzPf7MvK WAWalsjViSAuw== Date: Mon, 25 Jul 2022 17:33:37 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: Jan Beulich , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation In-Reply-To: <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> Message-ID: References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1515025650-1658795618=:4648" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1515025650-1658795618=:4648 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > On 7/25/22 09:32, Jan Beulich wrote: > > On 24.07.2022 19:20, Xenia Ragiadakou wrote: > > > On 7/7/22 10:55, Jan Beulich wrote: > > > > On 07.07.2022 09:27, Xenia Ragiadakou wrote: > > > > > On 7/6/22 11:51, Jan Beulich wrote: > > > > > > On 06.07.2022 10:43, Xenia Ragiadakou wrote: > > > > > > > On 7/6/22 10:10, Jan Beulich wrote: > > > > > > > > On 05.07.2022 23:02, Xenia Ragiadakou wrote: > > > > > > > > > The function idle_loop() is referenced only in domain.c. > > > > > > > > > Change its linkage from external to internal by adding the > > > > > > > > > storage-class > > > > > > > > > specifier static to its definitions. > > > > > > > > > > > > > > > > > > Since idle_loop() is referenced only in inline assembly, add > > > > > > > > > the 'used' > > > > > > > > > attribute to suppress unused-function compiler warning. > > > > > > > > > > > > > > > > While I see that Julien has already acked the patch, I'd like to > > > > > > > > point > > > > > > > > out that using __used here is somewhat bogus. Imo the better > > > > > > > > approach > > > > > > > > is to properly make visible to the compiler that the symbol is > > > > > > > > used by > > > > > > > > the asm(), by adding a fake(?) input. > > > > > > > > > > > > > > I 'm afraid I do not understand what do you mean by "adding a > > > > > > > fake(?) > > > > > > > input". Can you please elaborate a little on your suggestion? > > > > > > > > > > > > Once the asm() in question takes the function as an input, the > > > > > > compiler > > > > > > will know that the function has a user (unless, of course, it finds > > > > > > a > > > > > > way to elide the asm() itself). The "fake(?)" was because I'm not > > > > > > deeply > > > > > > enough into Arm inline assembly to know whether the input could then > > > > > > also be used as an instruction operand (which imo would be > > > > > > preferable) - > > > > > > if it can't (e.g. because there's no suitable constraint or operand > > > > > > modifier), it still can be an input just to inform the compiler. > > > > > > > > > > According to the following statement, your approach is the recommended > > > > > one: > > > > > "To prevent the compiler from removing global data or functions which > > > > > are referenced from inline assembly statements, you can: > > > > > -use __attribute__((used)) with the global data or functions. > > > > > -pass the reference to global data or functions as operands to inline > > > > > assembly statements. > > > > > Arm recommends passing the reference to global data or functions as > > > > > operands to inline assembly statements so that if the final image does > > > > > not require the inline assembly statements and the referenced global > > > > > data or function, then they can be removed." > > > > > > > > > > IIUC, you are suggesting to change > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) > > > > > into > > > > > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" > > > > > ); > > > > > > > > Yes, except that I can't judge about the "S" constraint. > > > > > > > > > > This constraint does not work for arm32. Any other thoughts? > > > > > > Another way, as Jan suggested, is to pass the function as a 'fake' > > > (unused) input. > > > I 'm suspecting something like the following could work > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : > > > "memory") > > > What do you think? > > > > Well, yes, X should always be a fallback option. But I said already when > > you suggested S that I can't judge about its use, so I guess I'm the > > wrong one to ask. Even more so that you only say "does not work", without > > any details ... > > > > The question is addressed to anyone familiar with arm inline assembly. > I added the arm maintainers as primary recipients to this email to make this > perfectly clear. > > When cross-compiling Xen on x86 for arm32 with > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); > compilation fails with the error: impossible constraint in ‘asm' Unfortunately looking at the GCC manual pages [1], it doesn't seem to be possible. The problem is that the definition of "S" changes between aarch64 and arm (the 32-bit version). For aarch64: S An absolute symbolic address or a label reference This is what we want. For arm instead: S A symbol in the text segment of the current file This is not useful for what we need to do here. As far as I can tell, there is no other way in GCC assembly inline for arm to do this. So we have 2 choices: we use the __used keyword as Xenia did in this patch. Or we move the implementation of switch_stack_and_jump in assembly. I attempted a prototype of the latter to see how it would come out, see below. I don't like it very much. I prefer the version with __used that Xenia had in this patch. But I am OK either way. diff --git a/xen/arch/arm/arm32/entry.S b/xen/arch/arm/arm32/entry.S index 38826142ad..4d28f7e9f7 100644 --- a/xen/arch/arm/arm32/entry.S +++ b/xen/arch/arm/arm32/entry.S @@ -442,6 +442,10 @@ ENTRY(__context_switch) add r4, r1, #VCPU_arch_saved_context ldmia r4, {r4 - sl, fp, sp, pc} /* Load registers and return */ +ENTRY(__switch_stack_and_jump) + mov sp, r0 + bx r1 + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/arm64/entry.S b/xen/arch/arm/arm64/entry.S index 95f1a92684..5d5d713f80 100644 --- a/xen/arch/arm/arm64/entry.S +++ b/xen/arch/arm/arm64/entry.S @@ -618,6 +618,10 @@ ENTRY(__context_switch) mov sp, x9 ret +ENTRY(__switch_stack_and_jump) + mov sp, x0 + br x1 + /* * Local variables: * mode: ASM diff --git a/xen/arch/arm/include/asm/current.h b/xen/arch/arm/include/asm/current.h index 73e81458e5..7696440a57 100644 --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -44,8 +44,12 @@ static inline struct cpu_info *get_cpu_info(void) #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) +void return_to_new_vcpu32(void); +void return_to_new_vcpu64(void); +void __switch_stack_and_jump(void *p, void *f); + #define switch_stack_and_jump(stack, fn) do { \ - asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ); \ + __switch_stack_and_jump(stack, fn); \ unreachable(); \ } while ( false ) [1] https://gcc.gnu.org/onlinedocs/gcc/Machine-Constraints.html --8323329-1515025650-1658795618=:4648-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 00:56:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 00:56:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374902.607093 (Exim 4.92) (envelope-from ) id 1oG8sG-0003jh-4y; Tue, 26 Jul 2022 00:56:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374902.607093; Tue, 26 Jul 2022 00:56:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG8sG-0003ja-2H; Tue, 26 Jul 2022 00:56:36 +0000 Received: by outflank-mailman (input) for mailman id 374902; Tue, 26 Jul 2022 00:56:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG8sD-0003jT-V5 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 00:56:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ca1f65cc-0c7d-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 02:56:32 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6A44B60FDB; Tue, 26 Jul 2022 00:56:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 39A90C341C6; Tue, 26 Jul 2022 00:56:30 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ca1f65cc-0c7d-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658796990; bh=LeEZV5faHLvTsF6TwF/tRHiJ0/fhg4SX7hZy7ZfmmS4=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sJRqRmXdQKrMnd/MjJDF823s18IVkX/2z3wOfy6OMECvyuHaaF6Oj5CnAxeha3W4n BKP2joM1HnswQ95yNilPitIbw3P6cys9bKDZpMy5cDC6ZIOzpnHgKZnVE1LZ5hAZlx htYS2bdGGlYLc183/hMA3yy5u1wu1cNBdahOSaBCnO3rQ0jYvMmIXj8q+9AKKvfcDl sZHLNG+ZQkGzJze1WBL/V0BF8wNJxoV/Zmnj/bYEZHPBmcRwFzPHJ6sT1zlM5il5/7 LfYDUz9r5RtqosnnhEDsVa0L8dm6TIqXnKBf8uozrYLoUeDNPVch6eDGZPb/qs4Hjd XCOIqFnxAZgyg== Date: Mon, 25 Jul 2022 17:56:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Andrew Cooper cc: xen-devel , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Juergen Gross , Roger Pau Monne , Bertrand Marquis , Henry Wang , =?UTF-8?Q?Marek_Marczykowski-G=C3=B3recki?= Subject: Re: Licensing issues In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1675117545-1658796990=:4648" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1675117545-1658796990=:4648 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 22 Jul 2022, Andrew Cooper wrote: > I'm also intending to start using SDPX identifiers to save on all the > boilerplate.  They're already used elsewhere. I just wanted to add that adding/using SPDX is important and came up quite a few times in Linux Foundation discussions recently [1]. Linux and Zephyr already support it. As a community, I think we should move toward it reasonably quickly. [1] https://elisa.tech/blog/2022/06/29/elisas-new-systems-working-group/?utm_campaign=ELISA%20Project%20Blog&utm_content=213223762&utm_medium=social&utm_source=linkedin&hss_channel=lcp-35579852 --8323329-1675117545-1658796990=:4648-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 01:27:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 01:27:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374908.607104 (Exim 4.92) (envelope-from ) id 1oG9M5-0005ax-HV; Tue, 26 Jul 2022 01:27:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374908.607104; Tue, 26 Jul 2022 01:27:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG9M5-0005aq-Es; Tue, 26 Jul 2022 01:27:25 +0000 Received: by outflank-mailman (input) for mailman id 374908; Tue, 26 Jul 2022 01:27:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG9M4-0005ag-BV; Tue, 26 Jul 2022 01:27:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG9M4-0006Ve-9d; Tue, 26 Jul 2022 01:27:24 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG9M3-0006JQ-Q1; Tue, 26 Jul 2022 01:27:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oG9M3-0000qR-PZ; Tue, 26 Jul 2022 01:27:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y5CH2wKBf9bItHneELWC3wZbeyTKoMs2mC5d/YfqU/8=; b=dHZKR6CB5uDyELxAEW7UmHX+7O HXoF6uO+qzZ+KhoDFBLc3fwUVFDtJsPjReoNGQGdLxco7vqtn342LBghnecJOA0/ANb1WS3cnM4uf ClKIOdw2jQzMBsq5rR14grETDJurTOY9J4lExwPJaEnPkCowY9PbUrS6+PFOU5wKSROk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171858: all pass - PUSHED X-Osstest-Versions-This: ovmf=7f1c89f16790fc2fa8bc88330dc896941b9b40bb X-Osstest-Versions-That: ovmf=a47241f1337c2ce78179b7db939faebd7828d8d0 From: osstest service owner Date: Tue, 26 Jul 2022 01:27:23 +0000 flight 171858 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171858/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 7f1c89f16790fc2fa8bc88330dc896941b9b40bb baseline version: ovmf a47241f1337c2ce78179b7db939faebd7828d8d0 Last test of basis 171855 2022-07-25 16:40:24 Z 0 days Testing same since 171858 2022-07-25 23:40:21 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Gary Lin Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git a47241f133..7f1c89f167 7f1c89f16790fc2fa8bc88330dc896941b9b40bb -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Tue Jul 26 02:58:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 02:58:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374916.607115 (Exim 4.92) (envelope-from ) id 1oGAlq-00078j-1A; Tue, 26 Jul 2022 02:58:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374916.607115; Tue, 26 Jul 2022 02:58:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGAlp-00078c-UI; Tue, 26 Jul 2022 02:58:05 +0000 Received: by outflank-mailman (input) for mailman id 374916; Tue, 26 Jul 2022 02:58:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGAlo-00078W-7U for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 02:58:04 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70079.outbound.protection.outlook.com [40.107.7.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c281a1c2-0c8e-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 04:58:01 +0200 (CEST) Received: from DB7PR02CA0018.eurprd02.prod.outlook.com (2603:10a6:10:52::31) by AS8PR08MB6993.eurprd08.prod.outlook.com (2603:10a6:20b:34a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 02:57:58 +0000 Received: from DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::d5) by DB7PR02CA0018.outlook.office365.com (2603:10a6:10:52::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25 via Frontend Transport; Tue, 26 Jul 2022 02:57:58 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT018.mail.protection.outlook.com (100.127.142.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 02:57:57 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Tue, 26 Jul 2022 02:57:57 +0000 Received: from e57ac9db520e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E88F58AF-4E4E-4B51-86A2-ABEF76E21249.1; Tue, 26 Jul 2022 02:57:47 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e57ac9db520e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 02:57:47 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR08MB3917.eurprd08.prod.outlook.com (2603:10a6:803:c1::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 02:57:42 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 02:57:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c281a1c2-0c8e-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=SOQUyUpLGZflfDdJoX3E50wDi/BacDiGMW78p9zU8NSkjFWC80G1OsyQhROJvdeFHW1XpIO2S2j3N8GdPTa9B9ZpsRO9IrwTKVaPq1k7XqZgvnLmK6Fapq5Tk+nR4gyeQp7TWqyv03e+OlXNYPKndio2PvvsW89wN3HiZ2DUptdd5vbnm+g6LsTfw1Y7UVtG93awmiQQFkJI3YOScjRpZheSWOHjEKoptx6eN7X5AYEH3MO5LtVlYtN0Kon8ZJ+Au1S2VrNsTnBsczgxilaqO7+RQczYS3l0Sa0QbEBI9BL8NWYNSa6zb0yBBuC575vk7RtQHHhtHKfa12zMeNdu0A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EsSUfY5+XGWTbio/dwOVcg6/hGZYnAsP/J3Vbi1MDLI=; b=oCgRXqU1rusUCXZZwQXwFhj/FgJwaSrxL5suW7M0BQHPuh7Kjh82J8zNAz4Km/9Sm2Sf2SWDDDCjneYMDyF9Cfz6rli3tWYvSInassBuOwKOQJQYOiojnW763RcjwZr/DRUjunZJ7fWER5URbPwORIOVNKNtG5PW2Eo0PVHjekvIEjbNhR3lyrhqx7TzhK+RvBN5pWiAvSt6VMHt75CX0DzkpfpWwyH3uu4sDWe0a+XPxNvuYmG9CE08gK7NqGJIMF8IKhIvpA4sYUAX3+AJvyeqjq8rMuEgUVCjm6JlEqxsoKPQhRav4u25y/8HWGeJzTBtdahhFt6UU6AF7IyTTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EsSUfY5+XGWTbio/dwOVcg6/hGZYnAsP/J3Vbi1MDLI=; b=zx/RxTyQT/HvK9BTPtMhi2rvFAaOLJ3xL+t2hxWQ8ZH4a2h1DiQoBQ3RmdwuajDQGng++27vcxF8LEHiG3Gkl2Pu5LkjD/ToQvvcEkg8yPE5e2GBhirgci3J0Ao4F3WJHT2PZN2fYxMRwNsCBfMZ1EQlhPhx1HC/jeYjbsPHZHg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jnVL9raBaRyBhy7YJ+ITeSYVqUDstN3bm0r35aK3f/dgCKkyfvpDaSsWQkM+LondPEPH9Ul6LVHvEkeSz7RLuLUP3IkRuYsU4x7eh0XiNvgmUX954AiSAmwZcargSL0VWaZ5eb75rH/S3ZbsI3M/OR2+5+3Y0hOCyKASM/B65HvXqT0R0zv23uLV2b0Si1A6IiNiEX9tFIl2HXnCOjrqozCOAFlxzBSqBnkj+B1Am0ymJEaZ6kEP/234y9LC2/N8GtUeLZ9IXTQlFdkHElp3ISKbq0mYs8R2Au9hjbEJv14kjRphUlyGdVKIa6RBP1t3QOgFAbRKqpPLcH9YJU4X1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EsSUfY5+XGWTbio/dwOVcg6/hGZYnAsP/J3Vbi1MDLI=; b=YhMozm/0HWzeeGhM8lKCksutQsJmtYIKIEpZWWlUc+YIHovvJUfujAKBvLpmNx0LIAIo9oNmITQBpJ4hAWHZsRh0or2xn2lTTqnnMi/5Sby8OO4yRk48+3V4wAP1yqHrdttRrZWLWcLGc9saOl6kwq4+8pLhARwl0/0jrbBAyko1UI7VoqNvIouiYqRUVryFUU0TjqaukMViMAcQ63owK4XDB3EqkybytzstvDeB8K7BJ5imMFwq4+HWfmAlAkLcec1vWJfLloB2pHoTFktf6yc32+9ewxzzPUnP5oRLfvaGBeBSqJ6HHcW3nWd6/o5liTrsTYLfxdThvb5omy5DiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EsSUfY5+XGWTbio/dwOVcg6/hGZYnAsP/J3Vbi1MDLI=; b=zx/RxTyQT/HvK9BTPtMhi2rvFAaOLJ3xL+t2hxWQ8ZH4a2h1DiQoBQ3RmdwuajDQGng++27vcxF8LEHiG3Gkl2Pu5LkjD/ToQvvcEkg8yPE5e2GBhirgci3J0Ao4F3WJHT2PZN2fYxMRwNsCBfMZ1EQlhPhx1HC/jeYjbsPHZHg= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static Thread-Topic: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static Thread-Index: AQHYm/wj+C+KkWoRC0CF4EH9AdaBLK2PQF8AgAC9HgA= Date: Tue, 26 Jul 2022 02:57:42 +0000 Message-ID: References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-7-Penny.Zheng@arm.com> <903b6203-a475-5a83-0b2a-f3a8fa345b73@suse.com> In-Reply-To: <903b6203-a475-5a83-0b2a-f3a8fa345b73@suse.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: 18E04B3EA22F6444907F0A0647CE9536.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 9dfcdfaa-b694-41c1-ce56-08da6eb2a500 x-ms-traffictypediagnostic: VI1PR08MB3917:EE_|DBAEUR03FT018:EE_|AS8PR08MB6993:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +4ZHvwmets/61dToATWOaq7/UGA762zSs9H3GI4Z5sDGLDl7Xj3a0/qmZQFvHQUXWAMuNqd2Lgk93ph/h/XJ3C5iPCm/tNlJfdKaqem8fBaawK3+AFSp67HpJFgrTnYOIDTbMFSRpuNft5BPnHUYcE4kSmSx6RCeSIO5OWqhJwhOv1wKWezbjxT7b5RUYlFltVxcqGNwzTppjQHJVi97biXZlHUHFaEeMyWYqhFGAmEZYmDFzxYcTOlChsduMTFS4drZqz9LimpVDT2Hq/j9yskITg1MisTgdOlJI6qse5mIRUNwfXj3VsgXRIGY5LvN3rUhzeDOKvSNoxZW7qY2pCtn2h3dzNaLjVS9dVvSPDpU3dd4YMsabfbLDLQn8/7xyQb7/Ej2+bPfDo2F9kBG/JwZNF2kfexaN2yjFzTtE5lYfIfk9eoP6dbFi79DMYhCWaT7x8+Wzrz8SlI+UBtiVyItc4YeOhSKC7gD8HvmDr75RSaGiTXcy/Ekyotme3i3ctpMQzkvTnuixMSODhA9C3LB0DXViKKjWA8LcgjWmn08GZ+kXOED4w/QMVG+HcmTvKb9ddQ8RFP5MlyKPoWItffrxBw9Ty4c8u9YmEvYKwBcpnOsHZzj3cEfP+rRl2QNBApXEJTgC3tSZ9Lwhq/C8rDkStY31PUDI7eVrjwUhY+hEuvY4Zy0+em2DnJuf7OjPEnr4yh3VJkIEOQ4KReJifnHaWo02xFlfdxtgg4Z3fX9K9YBepUZ4LWOEzoWJBH5qpyZofhaWSqwKlbicWBLI/gGJTtgwYNondX0f65E0v1vqIFnDf57H4w7KOpKSvbX X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(346002)(376002)(39860400002)(396003)(5660300002)(52536014)(54906003)(86362001)(2906002)(55016003)(6506007)(8936002)(478600001)(7696005)(186003)(66476007)(76116006)(41300700001)(66556008)(66946007)(26005)(122000001)(38070700005)(4326008)(33656002)(71200400001)(66446008)(83380400001)(64756008)(53546011)(38100700002)(8676002)(9686003)(6916009)(316002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3917 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 83ca2e8f-e59d-44a2-b9e1-08da6eb29bf4 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGcVS2XSbNYwrlHTrE2MG+MbTivg70uS0d9lmE2xb83m/HnGS/NOGIOokmARkd13kjXmEIsjb8Jpju5LkxRD2m0Qzff1KewvSNhOBBogl71PuD7PBO5IAQ+JznLG2vHWZyTE4wcIleF0t0nRyHLwok8qL75uHkdYTn8PBErmqRfU7saBGi/HLf4jGcp6ECmZFXAQLlQDwlHX+chdzOqlT+EqPc2DXmOrE+RuNKIlgfe63yuzIMEAMLMTSXXeRq60vouWmLQ+80/PjYpo5wqNN/xLdLnhf5tiv9/G2bOuG+InQDScuRbpEmFZCSkmZYxZdYa3hQSxSd2bSygA/ji6OxVCP/T7GYQXvEFT+Bui6a0yRn4Bcm1adtj+CGnYEYptLGElc1+Q+K8csMp++E/9cqcL05Zu+Xc33W+zx6yTP0pfSEtTzwzQUYR2I6eEcAiUWKP/txPT8xW6KBiGvD6UvbYNCHGxs7KNEgzfHAO0aDeqzYe4P++tgN8JhnyiwW9C5/71rlIiFVkMYfiBArouJHYbkNeIKivLEIkodoqkIG8wI4pAmnOCuDUKCxmGCNSIXKRtxlqKgLUbUX0QrAZLT96UsB5b0F8cX59f/ZhvjJuQUs9sD/TaYojg+tXAqDIRh7+O8Z7so9Oo//jJxyTJiV901peescTclwraodk0YbKy+tj4mHk71ZAUC/28eMaHFp919fwSOjkZ997Tx9OLad4GBnRgdtpCn4+/LpABvtNYX2Tn/UHzXOTVPSknXW0GcFT0LMgFf1Y5W0fNR22jbazdcYrM760OF14JBI8G5n68yWvb6sPVkSEdSVbuA3OD X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(40470700004)(46966006)(36840700001)(40460700003)(41300700001)(9686003)(33656002)(26005)(53546011)(81166007)(6506007)(7696005)(478600001)(54906003)(86362001)(316002)(40480700001)(55016003)(82310400005)(186003)(2906002)(47076005)(336012)(70586007)(52536014)(83380400001)(5660300002)(70206006)(6862004)(8936002)(82740400003)(356005)(36860700001)(8676002)(4326008);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 02:57:57.7874 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9dfcdfaa-b694-41c1-ce56-08da6eb2a500 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT018.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6993 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBNb25kYXksIEp1bHkgMjUsIDIwMjIgMTE6 MzYgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBBbmRyZXcgQ29vcGVyDQo+IDxhbmRyZXcuY29vcGVy M0BjaXRyaXguY29tPjsgR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRyaXguY29tPjsN Cj4gSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz47IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0 YWJlbGxpbmlAa2VybmVsLm9yZz47DQo+IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2OSA2LzhdIHhlbi9h cm06IHVucG9wdWxhdGUgbWVtb3J5IHdoZW4gZG9tYWluIGlzDQo+IHN0YXRpYw0KPiANCj4gT24g MjAuMDcuMjAyMiAwNzo0NiwgUGVubnkgWmhlbmcgd3JvdGU6DQo+ID4gVG9kYXkgd2hlbiBhIGRv bWFpbiB1bnBvcHVsYXRlcyB0aGUgbWVtb3J5IG9uIHJ1bnRpbWUsIHRoZXkgd2lsbA0KPiA+IGFs d2F5cyBoYW5kIHRoZSBtZW1vcnkgYmFjayB0byB0aGUgaGVhcCBhbGxvY2F0b3IuIEFuZCBpdCB3 aWxsIGJlIGENCj4gPiBwcm9ibGVtIGlmIGRvbWFpbiBpcyBzdGF0aWMuDQo+ID4NCj4gPiBQYWdl cyBhcyBndWVzdCBSQU0gZm9yIHN0YXRpYyBkb21haW4gc2hhbGwgYmUgcmVzZXJ2ZWQgdG8gb25s eSB0aGlzDQo+ID4gZG9tYWluIGFuZCBub3QgYmUgdXNlZCBmb3IgYW55IG90aGVyIHB1cnBvc2Vz LCBzbyB0aGV5IHNoYWxsIG5ldmVyIGdvDQo+ID4gYmFjayB0byBoZWFwIGFsbG9jYXRvci4NCj4g Pg0KPiA+IFRoaXMgY29tbWl0IHB1dHMgcmVzZXJ2ZWQgcGFnZXMgb24gdGhlIG5ldyBsaXN0IHJl c3ZfcGFnZV9saXN0IG9ubHkNCj4gPiBhZnRlciBoYXZpbmcgdGFrZW4gdGhlbSBvZmYgdGhlICJu b3JtYWwiIGxpc3QsIHdoZW4gdGhlIGxhc3QgcmVmIGRyb3BwZWQuDQo+IA0KPiBJIGd1ZXNzIHRo aXMgd29yZGluZyBzb21laG93IHJlbGF0ZXMgdG8gLi4uDQo+IA0KPiA+IC0tLSBhL3hlbi9jb21t b24vcGFnZV9hbGxvYy5jDQo+ID4gKysrIGIveGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMNCj4gPiBA QCAtMjY3NCwxMCArMjY3NCwxNCBAQCB2b2lkIGZyZWVfZG9tc3RhdGljX3BhZ2Uoc3RydWN0IHBh Z2VfaW5mbw0KPiA+ICpwYWdlKQ0KPiA+DQo+ID4gICAgICBkcm9wX2RvbV9yZWYgPSAhZG9tYWlu X2FkanVzdF90b3RfcGFnZXMoZCwgLTEpOw0KPiA+DQo+ID4gLSAgICBzcGluX3VubG9ja19yZWN1 cnNpdmUoJmQtPnBhZ2VfYWxsb2NfbG9jayk7DQo+ID4gLQ0KPiA+ICAgICAgZnJlZV9zdGF0aWNt ZW1fcGFnZXMocGFnZSwgMSwgc2NydWJfZGVidWcpOw0KPiA+DQo+ID4gKyAgICAvKiBBZGQgcGFn ZSBvbiB0aGUgcmVzdl9wYWdlX2xpc3QgKmFmdGVyKiBpdCBoYXMgYmVlbiBmcmVlZC4gKi8NCj4g PiArICAgIGlmICggIWRyb3BfZG9tX3JlZiApDQo+ID4gKyAgICAgICAgcGFnZV9saXN0X2FkZF90 YWlsKHBhZ2UsICZkLT5yZXN2X3BhZ2VfbGlzdCk7DQo+IA0KPiAuLi4gdGhlIGNvbmRpdGlvbmFs IHVzZWQgaGVyZS4gSSBjYW5ub3QsIGhvd2V2ZXIsIGZpZ3VyZSB3aHkgdGhlcmUgaXMgdGhpcw0K PiBjb25kaXRpb25hbCAoYW5kIHNhaWQgcGFydCBvZiB0aGUgZGVzY3JpcHRpb24gYWxzbyBkb2Vz bid0IGhlbHAgbWUgZmlndXJlIGl0DQo+IG91dCkuDQo+IA0KDQpJIHdhcyB0aGlua2luZyB0aGF0 IGlmIGRyb3BfZG9tX3JlZiB0cnVlLCB0aGVuIGxhdGVyIHRoZSB3aG9sZSBkb21haW4gc3RydWN0 DQp3aWxsIGJlIHJlbGVhc2VkLCB0aGVuIHRoZXJlIGlzIG5vIG5lZWQgdG8gYWRkIHRoZSBwYWdl IHRvIGQtPnJlc3ZfcGFnZV9saXN0DQoNCj4gQXMgYW4gYXNpZGU6IEEgdGl0bGUgcHJlZml4IG9m IHhlbi9hcm06IHN1Z2dlc3RzIHlvdSdyZSBtb3N0bHkgdG91Y2hpbmcgQXJtDQo+IGNvZGUuIEJ1 dCB5b3UncmUgdG91Y2hpbmcgZXhjbHVzaXZlbHkgY29tbW9uIGNvZGUgaGVyZS4NCj4gSSBmb3Ig b25lIHdvdWxkIGFsbW9zdCBoYXZlIHNraXBwZWQgdGhpcyBwYXRjaCAobW9yZSB0aGFuIG9uY2Up IHdoZW4NCj4gZGVjaWRpbmcgd2hpY2ggb25lcyAobWF5KSB3YW50IG1lIGxvb2tpbmcgYXQgdGhl bS4NCj4gDQoNClNvcnJ5IGZvciB0aGF0LCBJ4oCZbGwgZml4IGl0DQo+IEphbg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:16:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:16:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374922.607126 (Exim 4.92) (envelope-from ) id 1oGB3P-0001BD-Gx; Tue, 26 Jul 2022 03:16:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374922.607126; Tue, 26 Jul 2022 03:16:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB3P-0001B6-EA; Tue, 26 Jul 2022 03:16:15 +0000 Received: by outflank-mailman (input) for mailman id 374922; Tue, 26 Jul 2022 03:16:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB3N-0001B0-W4 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:16:14 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2054.outbound.protection.outlook.com [40.107.20.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b9eb523-0c91-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:16:12 +0200 (CEST) Received: from FR3P281CA0124.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::15) by GV1PR08MB8106.eurprd08.prod.outlook.com (2603:10a6:150:95::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 03:16:05 +0000 Received: from VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:94:cafe::e7) by FR3P281CA0124.outlook.office365.com (2603:10a6:d10:94::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Tue, 26 Jul 2022 03:16:05 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT044.mail.protection.outlook.com (10.152.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 03:16:04 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Tue, 26 Jul 2022 03:16:04 +0000 Received: from 9203a51a8afd.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F5C24FA6-272A-4B88-8E8B-E7E5B75C5488.1; Tue, 26 Jul 2022 03:15:53 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9203a51a8afd.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 03:15:53 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com (2603:10a6:10:2e4::7) by VI1PR08MB3726.eurprd08.prod.outlook.com (2603:10a6:803:ba::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.15; Tue, 26 Jul 2022 03:15:51 +0000 Received: from DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0]) by DU2PR08MB7325.eurprd08.prod.outlook.com ([fe80::f90a:69e3:64e7:fdc0%8]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 03:15:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b9eb523-0c91-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=PtivYfqHfRTq4dMhixuUNngkkRA1cFt6c/0Mn0w8Gt227f/YPq922YtfUbgIY1Dad9+T7C5nga94mbRPrqjHpMJCUW1xcgjk1Weskpa75MTfyuk01z0yqw0c4Oi6mBobmhJrWbPnxCMCj8Gs6D8oKsznlexDC2vsvvSZyPDs8bbDHjzhsSytNItdJVZ1eFAFK5gFnSk51ldA1Mf/xNRQacdgWCdPlxVDztPrRkgLrMCmWKRGrJcXbiyP13E61FiTtkwo4DX/Nmc2Bvey9+W6s6oWoS5A3xBjVTBo4UTaB1cSroevp5a4Oky1aVMjr8sxAX8y+AUZNgnY8f35KjyaiQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+EUfJweFe5RBt67MncQk4V6z7mqKjpeCFTB5GPYH/YE=; b=TC+DD3KJYaO6lCL6FQLWycm2bGHpQmn4+7q43lsfhtomGKeGyCUFLu1GpuZPQk2xIqNK/kKM4bDZ+0L6ClhSXIcvoAbUYi7JdppsJL34RjWzWwSpq+7B40nmHcrip7tiBU2RKRSwDzj/YOg3eZvn6tKlwqKnx7ItYuOLRJNC7vfx8LEMBtHZSrZJqnwairtqq+tB98sOhEPNP38tZPFGxSPtvU4rV/zy2Rk6Um/sEQAZ1FYaysAIVoCazTa2bINuQksKoeoCmUwODzy6NKunrXafTZReqtWigXi/xQsCjyR3BIPdqPFLizkKwCiV7rjVSd1d9kiNIoof5ATcrCnCwQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EUfJweFe5RBt67MncQk4V6z7mqKjpeCFTB5GPYH/YE=; b=3naZgR2BfJCxO2qIn7ZGeH9zGI6qqqpq3MdHmmSchbXlLKWThc2LbmNzYmplu2QMJO8P+ut252iI8ZVSnMgvxVRtGcNXOgySj7yB3MyUevisFnioUu7sSEpinintEi8mvIVKuch3hsuZzlRAkrw2yYpN9f8AwjA8acXXbx+otoM= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NW5ufMjq0ejkwB/Tec+6wC+D3K5atEwfqksRbgKQdV+IB9lZ1G0pxa4FJssTBjn0xWhXL9+H6wGN6W/8tTq6kMGPxhh37qZ8rl59NK0TyS/ibLCas5tCDTWk45rZHlyKaH+oX5PNj3lK1Rtsyf9zSVWx2Z4fUI2ax7ZErheaRa4TDjmfPyJsNaIrVpbHwyYJRUmkTl8aXMP9GIdA7zJ837EMIHFy9iNOqCIKoo9cTCmkwRtvVr7awRh+gqXkktPlA1w3SPHNCAAC5B3KohPDvQ5Cb4l6YjHL1t1EeXvnIfZzW/mYEHBFb+UIpb4huC1bHj+7LbshOT4bwP2R5lxNbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+EUfJweFe5RBt67MncQk4V6z7mqKjpeCFTB5GPYH/YE=; b=E3iNlYtB4YYtdpKP96TcCC413IqtsPjvGIbr8Jn/NnPqrdLB/ikKQuNfgBQG3q2jl3oMMcJRCcBJb1fSgkmAthpEMQhO+VEy4aN1M74bgbJXBDjJSJeI4pGV3w7/5f2UySml9jvJ31IHBpEH4bkvQEoRErfNVKDJG6DabLIPhpnFiG+Kzoq0ZtZYqgx4MJuL0xZpSHpFWfjMKft57HkAJwb7c/FUM6WgrZUEajMn+dCy3uqNXyNhJOFjH2/M0DyNPgXHRGeLcsi2qYOCUUS+qzXHZ7zOkBYLFM/H2noXsJ/RDbetnsaXVf0IDVwHK88rtbDXej65n1E9cUpL8TG3pQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+EUfJweFe5RBt67MncQk4V6z7mqKjpeCFTB5GPYH/YE=; b=3naZgR2BfJCxO2qIn7ZGeH9zGI6qqqpq3MdHmmSchbXlLKWThc2LbmNzYmplu2QMJO8P+ut252iI8ZVSnMgvxVRtGcNXOgySj7yB3MyUevisFnioUu7sSEpinintEi8mvIVKuch3hsuZzlRAkrw2yYpN9f8AwjA8acXXbx+otoM= From: Penny Zheng To: Jan Beulich CC: Wei Chen , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , "xen-devel@lists.xenproject.org" Subject: RE: [PATCH v9 2/8] xen: do not free reserved memory into heap Thread-Topic: [PATCH v9 2/8] xen: do not free reserved memory into heap Thread-Index: AQHYm/wkzpoqdfP5/kKS0Y1Fu7qjpq2PPrOAgADESLA= Date: Tue, 26 Jul 2022 03:15:50 +0000 Message-ID: References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-3-Penny.Zheng@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: B63E34946A664C4B8CDA3C512FCE3E4A.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 125a9e94-67d5-4e84-4102-08da6eb52d0a x-ms-traffictypediagnostic: VI1PR08MB3726:EE_|VE1EUR03FT044:EE_|GV1PR08MB8106:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7Bjxfz+hRRSnTYlBysTystzBvriKVOFIdBU3RO0lUVz/DH0zkLoOA+WVn+vjUH5aidHg5v5dVwJ2M26j4piJH2sKi04TZIYZgkAXbPQOVHSzongSy6mYn/2NjquTuv401+YMnATGBvJS4rhKWCia+Y1EH3Zen6G781sTHxcjP0jqggsRlSXEkYBW4LOk32jn4yM/YgN2lH6SDk0uyIHSM1c4yTMlpuFbG0PTr2r1e264mQfvg/wY6DWXWX6Ku2gR6/JyTzKWb2tx57YmkmQMdDqMWSab/QKNHl1HkbGO4y9/VvJkaTg8aY5gAX7YxUCSENsTZe+MhYuD72VshwYrgqKc2PR4jVYsESVVYLtRDL37rbG/MeWmhfBn/SovMo84bLIoklht8Uyy2I4J2hwXlcz+GZwDgamG6ylIAuUVvOxs2cGlFlfsjtQI6nsG6PRXaESTRNdSUqoD1cHtG/PKzvO8tk9NXvgJ6xrB5SJmvBTGzkSYU9GmVAjbu4wLduGatECypAKi+PCoGmbDmKz65B+CQlqgLsrKcXKmLnVUJZ7QGxp/5HR/IPxDN+gaLrcxnTAnixRoWYoke3LMoAylzHoc8rz+jXzq/bt4pgvOBV9O2+ArKA5ZJHvp8BqrdmX8lUoB/mpYqcSiDRyb3mSxR/u4fZrerg+23RnRxiD8jbxTZKRXj3JesrR9FSImLrIf97RO+FgddoKYxjZpSk8BkNZQJeS4dJZ5pFn2nYNH/4w8f/3+7+O9B8dR6sdwvr1HCmgBvY3u+cNFz2sc28KN9zsXupd0yc/e2LYtY9e2HSQm8KaZi7FoWZz9b/wQ9GO7tdm6bFb2FDAgHkE+i+TV53TeBvAAWiAxCaDxoDZ2kaI= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR08MB7325.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(396003)(366004)(136003)(346002)(66446008)(8676002)(83380400001)(38100700002)(66476007)(122000001)(54906003)(66556008)(66946007)(76116006)(8936002)(52536014)(33656002)(5660300002)(2906002)(6506007)(186003)(26005)(64756008)(9686003)(41300700001)(4326008)(71200400001)(316002)(55016003)(53546011)(38070700005)(478600001)(86362001)(6916009)(7696005);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3726 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3f6ded5a-40b1-42c6-6c4d-08da6eb5249d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PkLnpm36NKSzd86EMNrfqkAM7OC9tOJok94BSsdGUyeIvSGb8dFttF0MBkV0wC/y3NjCFoQ1oZj2v/xdwcf5fraCNJrDG1TGHeGiQy4R+9m4dmlH6avllRCYuLTgVtFANNriCSeQK3nMP++ZqZjeAjArM2ujMWggE9TqHGdtY7yvulY0M8GroQRwCgSETI6T8uPcatnXGxc/FGXnVXP+YAdiBFitwXNMgDOBbDuSFqIfXYGRxtAKKonsLgobXd9uMHD2LHmDcgRytRyoxSnj1qQ8oXdxVZQY5cMhnloNF1rZRdcslOc8Y390ZmyKeA0ffXEXWbubAtcosZY3EqbQgibzQdu2lfr6P0HgG54oQ+aw6MHi6nTG8EYlSPAZRPHUb2PtNeAZ5tp7UpR3JbzxLlgNUmWEdIJYRSLxQ7fBw1v4oIc6I+dgqlAj2xhNkjtbJAzRjPaHw9z9fhhIpwJlSEw77j5nC25HOEowg35iXHXiBPfPEj7ZmKIvBqtKlCiyMwy6uWWBEhTD0EnJiG9iSF7in26B37IrqJ2H4NE46eVlzUMaRx3cGlioRzWC3tRlu7aKM1YirtU9Jg76wQL7wLeQA0yN3BK4LDJMbacJZwbgweM+5fIE4NZtrzioVQulHU1KjprXR2xP0tGToyctPFI8O+ql4RW5tZRQiL1kaKgKmLhIyPGy05KlsH4yoX3mbEYAi1EEM20TR3HEd/HiMf2YLKy9LB973wncaQ+wI7G2JxCraNbCn2yefLzPlh7isjmmFwhqRz/oTL0wAsk+z8/byRB2NWP5J/ATEr0RL+qeERJvcIioZBxcV33qYsu5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(136003)(376002)(46966006)(40470700004)(36840700001)(26005)(82740400003)(53546011)(9686003)(81166007)(356005)(70586007)(70206006)(8676002)(4326008)(82310400005)(41300700001)(33656002)(6506007)(7696005)(2906002)(40460700003)(5660300002)(186003)(83380400001)(478600001)(6862004)(47076005)(86362001)(52536014)(8936002)(336012)(40480700001)(316002)(36860700001)(54906003)(55016003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 03:16:04.9191 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 125a9e94-67d5-4e84-4102-08da6eb52d0a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT044.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB8106 SGkgSmFuDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPg0KPiBTZW50OiBNb25kYXksIEp1bHkgMjUsIDIwMjIgMTE6 MzAgUE0NCj4gVG86IFBlbm55IFpoZW5nIDxQZW5ueS5aaGVuZ0Bhcm0uY29tPg0KPiBDYzogV2Vp IENoZW4gPFdlaS5DaGVuQGFybS5jb20+OyBTdGVmYW5vIFN0YWJlbGxpbmkNCj4gPHNzdGFiZWxs aW5pQGtlcm5lbC5vcmc+OyBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4ub3JnPjsgQmVydHJhbmQg TWFycXVpcw0KPiA8QmVydHJhbmQuTWFycXVpc0Bhcm0uY29tPjsgVm9sb2R5bXlyIEJhYmNodWsN Cj4gPFZvbG9keW15cl9CYWJjaHVrQGVwYW0uY29tPjsgQW5kcmV3IENvb3Blcg0KPiA8YW5kcmV3 LmNvb3BlcjNAY2l0cml4LmNvbT47IEdlb3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAY2l0cml4 LmNvbT47DQo+IFdlaSBMaXUgPHdsQHhlbi5vcmc+OyB4ZW4tZGV2ZWxAbGlzdHMueGVucHJvamVj dC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2OSAyLzhdIHhlbjogZG8gbm90IGZyZWUgcmVz ZXJ2ZWQgbWVtb3J5IGludG8gaGVhcA0KPiANCj4gT24gMjAuMDcuMjAyMiAwNzo0NiwgUGVubnkg Wmhlbmcgd3JvdGU6DQo+ID4gUGFnZXMgdXNlZCBhcyBndWVzdCBSQU0gZm9yIHN0YXRpYyBkb21h aW4sIHNoYWxsIGJlIHJlc2VydmVkIHRvIHRoaXMNCj4gPiBkb21haW4gb25seS4NCj4gPiBTbyBp biBjYXNlIHJlc2VydmVkIHBhZ2VzIGJlaW5nIHVzZWQgZm9yIG90aGVyIHB1cnBvc2UsIHVzZXJz IHNoYWxsDQo+ID4gbm90IGZyZWUgdGhlbSBiYWNrIHRvIGhlYXAsIGV2ZW4gd2hlbiBsYXN0IHJl ZiBnZXRzIGRyb3BwZWQuDQo+ID4NCj4gPiBUaGlzIGNvbW1pdCBpbnRyb2R1Y2VzIGEgbmV3IGhl bHBlciBmcmVlX2RvbXN0YXRpY19wYWdlIHRvIGZyZWUgc3RhdGljDQo+ID4gcGFnZSBpbiBydW50 aW1lLCBhbmQgZnJlZV9zdGF0aWNtZW1fcGFnZXMgd2lsbCBiZSBjYWxsZWQgYnkgaXQgaW4NCj4g PiBydW50aW1lLCBzbyBsZXQncyBkcm9wIHRoZSBfX2luaXQgZmxhZy4NCj4gPg0KPiA+IFNpZ25l ZC1vZmYtYnk6IFBlbm55IFpoZW5nIDxwZW5ueS56aGVuZ0Bhcm0uY29tPg0KPiANCj4gVGVjaG5p Y2FsbHkNCj4gUmV2aWV3ZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4g DQo+IE5ldmVydGhlbGVzcyB0d28gcmVtYXJrczoNCj4gDQo+ID4gK3ZvaWQgZnJlZV9kb21zdGF0 aWNfcGFnZShzdHJ1Y3QgcGFnZV9pbmZvICpwYWdlKSB7DQo+ID4gKyAgICBzdHJ1Y3QgZG9tYWlu ICpkID0gcGFnZV9nZXRfb3duZXIocGFnZSk7DQo+ID4gKyAgICBib29sIGRyb3BfZG9tX3JlZjsN Cj4gPiArDQo+ID4gKyAgICBBU1NFUlQoZCk7DQo+IA0KPiBJIHdvbmRlciB3aGV0aGVyDQo+IA0K PiAgICAgaWYgKCB1bmxpa2VseSghZCkgKQ0KPiAgICAgew0KPiAgICAgICAgIEFTU0VSVF9VTlJF QUNIQUJMRSgpOw0KPiAgICAgICAgIHJldHVybjsNCj4gICAgIH0NCj4gDQo+IHdvdWxkbid0IGJl IG1vcmUgcm9idXN0IGxvb2tpbmcgZm9yd2FyZC4NCj4gDQo+ID4gLS0tIGEveGVuL2luY2x1ZGUv eGVuL21tLmgNCj4gPiArKysgYi94ZW4vaW5jbHVkZS94ZW4vbW0uaA0KPiA+IEBAIC04NSwxMyAr ODUsMTIgQEAgYm9vbCBzY3J1Yl9mcmVlX3BhZ2VzKHZvaWQpOyAgfSB3aGlsZSAoIGZhbHNlICkN Cj4gPiAjZGVmaW5lIEZSRUVfWEVOSEVBUF9QQUdFKHApIEZSRUVfWEVOSEVBUF9QQUdFUyhwLCAw KQ0KPiA+DQo+ID4gLSNpZmRlZiBDT05GSUdfU1RBVElDX01FTU9SWQ0KPiA+ICAvKiBUaGVzZSBm dW5jdGlvbnMgYXJlIGZvciBzdGF0aWMgbWVtb3J5ICovICB2b2lkDQo+ID4gZnJlZV9zdGF0aWNt ZW1fcGFnZXMoc3RydWN0IHBhZ2VfaW5mbyAqcGcsIHVuc2lnbmVkIGxvbmcgbnJfbWZucywNCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgICBib29sIG5lZWRfc2NydWIpOw0KPiA+ICt2b2lk IGZyZWVfZG9tc3RhdGljX3BhZ2Uoc3RydWN0IHBhZ2VfaW5mbyAqcGFnZSk7DQo+ID4gIGludCBh Y3F1aXJlX2RvbXN0YXRpY19wYWdlcyhzdHJ1Y3QgZG9tYWluICpkLCBtZm5fdCBzbWZuLCB1bnNp Z25lZCBpbnQNCj4gbnJfbWZucywNCj4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu c2lnbmVkIGludCBtZW1mbGFncyk7IC0jZW5kaWYNCj4gPg0KPiA+ICAvKiBNYXAgbWFjaGluZSBw YWdlIHJhbmdlIGluIFhlbiB2aXJ0dWFsIGFkZHJlc3Mgc3BhY2UuICovICBpbnQNCj4gPiBtYXBf cGFnZXNfdG9feGVuKCBAQCAtMjEyLDYgKzIxMSwxMCBAQCBleHRlcm4gc3RydWN0IGRvbWFpbg0K PiAqZG9tX2NvdzsNCj4gPg0KPiA+ICAjaW5jbHVkZSA8YXNtL21tLmg+DQo+ID4NCj4gPiArI2lm bmRlZiBQR0Nfc3RhdGljDQo+ID4gKyNkZWZpbmUgUEdDX3N0YXRpYyAwDQo+ID4gKyNlbmRpZg0K PiANCj4gVGhpcyBkaXNjb25uZWN0IGZyb20gYWxsIG90aGVyIFBHQ18qIHZhbHVlcyBpc24ndCB2 ZXJ5IG5pY2UuIEkgd29uZGVyIGFzIGhvdw0KPiBiYWQgaXQgd291bGQgYmUgc2VlbiBpZiBBcm0g a2VwdCBpdHMgI2RlZmluZSB0byAwIHByaXZhdGUsIHdpdGggdGhlIGdlbmVyaWMNCj4gZmFsbGJh Y2sgcmVtYWluaW5nIGluIHBhZ2VfYWxsb2MuYy4NCj4gDQoNCkl0LCByaWdodCBub3csIGlzIG9u bHkgdXNlZCBpbiB4ZW4vYXJjaC9hcm0vbW0uYyBhbmQgeGVuL2NvbW1vbi9wYWdlX2FsbG9jLmMu DQpJdCBpcyBvayB0byBsZXQgQXJtIGtlZXAgaXRzICNkZWZpbmUgdG8gMCBwcml2YXRlLCB3aXRo IHRoZSBnZW5lcmljDQpmYWxsYmFjayByZW1haW5pbmcgaW4gcGFnZV9hbGxvYy5jLg0KDQo+IEph bg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:20:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:20:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374928.607137 (Exim 4.92) (envelope-from ) id 1oGB7J-0002iQ-7e; Tue, 26 Jul 2022 03:20:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374928.607137; Tue, 26 Jul 2022 03:20:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB7J-0002iJ-4a; Tue, 26 Jul 2022 03:20:17 +0000 Received: by outflank-mailman (input) for mailman id 374928; Tue, 26 Jul 2022 03:20:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGB7H-0002i7-2v for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:20:15 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id da854759-0c91-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:20:11 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 1A62D5C00D8; Mon, 25 Jul 2022 23:20:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:20:09 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:20:07 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da854759-0c91-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805609; x=1658892009; bh=rHEDfxRD/a 8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=wAW4LsScsEW9GwH8cMjG+uZruz swQVvOLcmRP432nunHw3PdVzK/JeUdFn/IemDIhi9hK2hAnCXOqXBao7CC7s0sKS HVs5OvEKa60wTESaX2isJ6Wpg1jsf71ZFBt5og0hVPtSp7jF9bOE4W86DlaEEvMH mifLdxyE5Rfai7w21f3QU7JEfm+zpf4wBsj2Yk9RjPeyfrZo75/QaB4u11JWUP2I ymRb2pJVJhFqGDalglsiIEHzUqp2rQz95EjWssVy2SbHOzZtOMvI+rJDICWceXss pGeBgAdl4W2zEY7lXMR7EV3+MAg1vMcNKzf8+uO6Lfv6z2qmnImaPOz88BBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805609; x= 1658892009; bh=rHEDfxRD/a8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=X 2ZR3MWRXVWuT1Gyp77fS/gPkYCZZY3kHkIKuoiOBCgtZk6RaSRxIX4ehC/L3NMHm ptnmoEeG/WQrCxiGOXdAHqe7sStwQmjGZBAwVwW2qyOYPo1HKlClF9jEkz5w7tuD R/M5QNd0CURCOWkPiCVCMhasTv1EPj46C1nO3W7rmxITq7WKe4U4sl5zqe8Br/mU trHUU2rB+lDdKGN3FdhaZkEQKRvzEGq5Tjc8MJd5HoIPli8FRwDmnXIOv0tJdTtW V7b//5x47+YLLEkZQIlIEAQ8IqHenB7B/OxV8+8uvT8PLFmPF5z5Wt6Rgp0NvWZD +Awu3VllUrdMfbvkjQdkg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeek udejueeuudetudffffdtheetteeileekkeefjeeljefhkeelffevueffkeelfeenucffoh hmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Connor Davis , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger Date: Tue, 26 Jul 2022 05:19:56 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct uart_driver that uses xue as a backend. Note that only target -> host communication is supported for now. To use Xue as a console, add 'console=dbgp dbgp=xhci' to the command line. [Marek] The Xue driver is taken from https://github.com/connojd/xue and heavily refactored to fit into Xen code base. Major changes include: - rename to xhci_dbc - drop support for non-Xen systems - drop xue_ops abstraction - use Xen's native helper functions for PCI access - move all the code to xue.c, drop "inline" - build for x86 only - annotate functions with cf_check - adjust for Xen's code style At this stage, only the first xHCI is considered. Later patch adds support for choosing specific one. The driver is initiallized before memory allocator works, so all the transfer buffers (about 230KiB of them) are allocated statically and will use memory even if XUE console is not selected. The driver can be disabled build time to reclaim this memory. Signed-off-by: Connor Davis Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - rename to xhci-dbc - add empty stub for xhci_dbc_uart_init(), to avoid #ifdef in setup.c - use PCI_BASE_ADDRESS_MEM_MASK - make strings init more readable - avoid infinite extended caps lookup - size the whole 64bit BAR - rename CONFIG_HAS_XHCI to CONFIG_XHCI - use cpu_relax(), drop xue_sys_pause() - disable memory decoding for the BAR sizing time, and enable it explicitly - drop mmio_size field - it's used only in init_xhc() function internally - use readl()/writel() for accessing MMIO - add pci_ro_device(), to protect device before later patch(es) add other protections - fix setting dequeue pointer based on events: TRB ring was page aligned, not 16-page aligned, so just taking DBC_TRB_RING_MASK bits doesn't work; instead, calculate distance from the ring beginning; while at it, fix off by one error there; dequeue pointer isn't used much yet, but it will be useful for RX handling - split dbc_ensure_running() out of dbc_flush() - it make dbc_flush() more logical, and will make even more sense with RX support added - make enum names upper case Changes in v2: - drop #pragma pack - fix indentation in Kconfig - minor style fixes - use cache_flush() - mark init functions as __init, and return bool - fix PCI_SBDF usage, use constants from pci_regs.h - add command line docs - allow disabling the driver in menuconfig, to reclaim 2MB allocated memory - guard unused debug functions with #ifdef XUE_DEBUG --- docs/misc/xen-command-line.pandoc | 5 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 1 +- xen/drivers/char/Kconfig | 9 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/xhci-dbc.c | 1024 ++++++++++++++++++++++++++++++- xen/include/xen/serial.h | 5 +- 7 files changed, 1049 insertions(+) create mode 100644 xen/drivers/char/xhci-dbc.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index da18172e50c5..f936283cd187 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` +> `= xhci` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output +only). XHCI driver will wait indefinitely for the debug host to connect - make +sure the cable is connected. + ### debug_stack_lines > `= ` diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/fixmap.h index 20746afd0a2a..bc39ffe896b1 100644 --- a/xen/arch/x86/include/asm/fixmap.h +++ b/xen/arch/x86/include/asm/fixmap.h @@ -25,6 +25,8 @@ #include #include +#define MAX_XHCI_PAGES 16 + /* * Here we define all the compile-time 'special' virtual * addresses. The point is to have a constant address at @@ -43,6 +45,8 @@ enum fixed_addresses { FIX_COM_BEGIN, FIX_COM_END, FIX_EHCI_DBGP, + FIX_XHCI_BEGIN, + FIX_XHCI_END = FIX_XHCI_BEGIN + MAX_XHCI_PAGES - 1, #ifdef CONFIG_XEN_GUEST FIX_PV_CONSOLE, FIX_XEN_SHARED_INFO, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8dea6..e05189f64997 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -950,6 +950,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) ns16550.irq = 3; ns16550_init(1, &ns16550); ehci_dbgp_init(); + xhci_dbc_uart_init(); console_init_preirq(); if ( pvh_boot ) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index dec58bc99360..06350c387371 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -84,3 +84,12 @@ config SERIAL_TX_BUFSIZE the nearest power of 2. Default value is 16384 (16kiB). + +config XHCI + bool "XHCI DbC UART driver" + depends on X86 + help + This selects the USB based XHCI debug capability to be usable as a UART. + Enabling this option makes Xen use extra ~230KiB memory, even if XHCI UART + is not selected. + If you have an x86 based system with USB3, say Y. diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile index 14e67cf072d7..e7e374775d32 100644 --- a/xen/drivers/char/Makefile +++ b/xen/drivers/char/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o obj-$(CONFIG_HAS_OMAP) += omap-uart.o obj-$(CONFIG_HAS_SCIF) += scif-uart.o obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o +obj-$(CONFIG_XHCI) += xhci-dbc.o obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o obj-$(CONFIG_ARM) += arm-uart.o obj-y += serial.o diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c new file mode 100644 index 000000000000..f0e60d1b86aa --- /dev/null +++ b/xen/drivers/char/xhci-dbc.c @@ -0,0 +1,1024 @@ +/* + * drivers/char/xhci-dbc.c + * + * Xen port for the xue debugger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; If not, see . + * + * Copyright (c) 2019 Assured Information Security. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* uncomment to have dbc_uart_dump() debug function */ +/* #define DBC_DEBUG 1 */ + +#define DBC_POLL_INTERVAL 100 /* us */ + +#define DBC_PAGE_SIZE 4096U + +/* Supported xHC PCI configurations */ +#define DBC_XHC_CLASSC 0xC0330U + +/* DbC idVendor and idProduct */ +#define DBC_DBC_VENDOR 0x1D6B +#define DBC_DBC_PRODUCT 0x0010 +#define DBC_DBC_PROTOCOL 0x0000 + +/* DCCTRL fields */ +#define DBC_CTRL_DCR 0 +#define DBC_CTRL_HOT 2 +#define DBC_CTRL_HIT 3 +#define DBC_CTRL_DRC 4 +#define DBC_CTRL_DCE 31 + +/* DCPORTSC fields */ +#define DBC_PSC_PED 1 +#define DBC_PSC_CSC 17 +#define DBC_PSC_PRC 21 +#define DBC_PSC_PLC 22 +#define DBC_PSC_CEC 23 + +#define DBC_PSC_ACK_MASK \ + ((1UL << DBC_PSC_CSC) | (1UL << DBC_PSC_PRC) | (1UL << DBC_PSC_PLC) | \ + (1UL << DBC_PSC_CEC)) + +#define dbc_debug(...) printk("dbc debug: " __VA_ARGS__) +#define dbc_alert(...) printk("dbc alert: " __VA_ARGS__) +#define dbc_error(...) printk("dbc error: " __VA_ARGS__) + +/****************************************************************************** + * TRB ring (summarized from the manual): + * + * TRB rings are circular queues of TRBs shared between the xHC and the driver. + * Each ring has one producer and one consumer. The DbC has one event + * ring and two transfer rings; one IN and one OUT. + * + * The DbC hardware is the producer on the event ring, and + * dbc driver is the consumer. This means that event TRBs are read-only from + * the dbc driver. + * + * OTOH, dbc drive is the producer of transfer TRBs on the two transfer + * rings, so dbc driver enqueues transfers, and the hardware dequeues + * them. The dequeue pointer of a transfer ring is read by + * dbc driver by examining the latest transfer event TRB on the event ring. The + * transfer event TRB contains the address of the transfer TRB that generated + * the event. + * + * To make each transfer ring circular, the last TRB must be a link TRB, which + * points to the beginning of the next queue. Note that this implementation + * does not support multiple segments, so each link TRB points back to the + * beginning of its own segment. + ******************************************************************************/ + +/* TRB types */ +enum { + XHCI_TRB_NORM = 1, + XHCI_TRB_LINK = 6, + XHCI_TRB_TFRE = 32, + XHCI_TRB_PSCE = 34 +}; + +/* TRB completion codes */ +enum { + XHCI_TRB_CC_SUCCESS = 1, + XHCI_TRB_CC_TRB_ERR = 5, +}; + +/* DbC endpoint types */ +enum { + XHCI_EP_BULK_OUT = 2, + XHCI_EP_BULK_IN = 6, +}; + +/* DMA/MMIO structures */ +struct xhci_trb { + uint64_t params; + uint32_t status; + uint32_t ctrl; +}; + +/* log2(sizeof(struct xhci_trb)) */ +#define XHCI_TRB_SHIFT 4 + +struct xhci_erst_segment { + uint64_t base; + uint16_t size; + uint8_t rsvdz[6]; +}; + +/* Arbitrary length, must fit every DBC_STRING_* */ +#define MAX_STRING_LENGTH 16 + +#define DBC_STRINGS_COUNT 4 +#define DBC_STRING_LANGID "\x09\x04" +#define DBC_STRING_MANUFACTURER "Xen" +#define DBC_STRING_PRODUCT "Debug console" +#define DBC_STRING_SERIAL "0" + +#define XHCI_DT_STRING 3 + +struct xhci_string_descriptor { + uint8_t size; + uint8_t type; + uint16_t string[MAX_STRING_LENGTH]; +}; + +#define DBC_CTX_SIZE 16 +#define DBC_CTX_BYTES (DBC_CTX_SIZE * 4) + +struct xhci_dbc_ctx { + union { + uint32_t info[DBC_CTX_SIZE]; + struct { + uint64_t string0_ptr; + uint64_t manufacturer_ptr; + uint64_t product_ptr; + uint64_t serial_ptr; + uint8_t string0_size; + uint8_t manufacturer_size; + uint8_t product_size; + uint8_t serial_size; + }; + }; + uint32_t ep_out[DBC_CTX_SIZE]; + uint32_t ep_in[DBC_CTX_SIZE]; +}; + +struct dbc_reg { + uint32_t id; + uint32_t db; + uint32_t erstsz; + uint32_t rsvdz; + uint64_t erstba; + uint64_t erdp; + uint32_t ctrl; + uint32_t st; + uint32_t portsc; + uint32_t rsvdp; + uint64_t cp; + uint32_t ddi1; + uint32_t ddi2; +}; + +#define DBC_TRB_MAX_TFR (DBC_PAGE_SIZE << 4) +#define DBC_TRB_PER_PAGE (DBC_PAGE_SIZE / sizeof(struct xhci_trb)) + +/* Defines the size in bytes of TRB rings as 2^DBC_TRB_RING_ORDER * 4096 */ +#ifndef DBC_TRB_RING_ORDER +#define DBC_TRB_RING_ORDER 4 +#endif +#define DBC_TRB_RING_CAP (DBC_TRB_PER_PAGE * (1 << DBC_TRB_RING_ORDER)) +#define DBC_TRB_RING_BYTES (DBC_TRB_RING_CAP * sizeof(struct xhci_trb)) +#define DBC_TRB_RING_MASK (DBC_TRB_RING_BYTES - 1U) + +struct xhci_trb_ring { + struct xhci_trb *trb; /* Array of TRBs */ + uint32_t enq; /* The offset of the enqueue ptr */ + uint32_t deq; /* The offset of the dequeue ptr */ + uint8_t cyc; /* Cycle state toggled on each wrap-around */ + uint8_t db; /* Doorbell target */ + uint64_t dma; /* Physical address (for the device) */ +}; + +#define DBC_DB_OUT 0x0 +#define DBC_DB_IN 0x1 +#define DBC_DB_INVAL 0xFF + +/* Defines the size in bytes of work rings as 2^DBC_WORK_RING_ORDER * 4096 */ +#ifndef DBC_WORK_RING_ORDER +#define DBC_WORK_RING_ORDER 3 +#endif +#define DBC_WORK_RING_CAP (DBC_PAGE_SIZE * (1 << DBC_WORK_RING_ORDER)) +#define DBC_WORK_RING_BYTES DBC_WORK_RING_CAP + +#if DBC_WORK_RING_CAP > DBC_TRB_MAX_TFR +#error "DBC_WORK_RING_ORDER must be at most 4" +#endif + +struct dbc_work_ring { + uint8_t *buf; + uint32_t enq; + uint32_t deq; + uint64_t dma; +}; + +struct dbc { + struct dbc_reg __iomem *dbc_reg; + struct xhci_dbc_ctx *dbc_ctx; + struct xhci_erst_segment *dbc_erst; + struct xhci_trb_ring dbc_ering; + struct xhci_trb_ring dbc_oring; + struct xhci_trb_ring dbc_iring; + struct dbc_work_ring dbc_owork; + struct xhci_string_descriptor *dbc_str; + + pci_sbdf_t sbdf; + uint64_t xhc_mmio_phys; + uint64_t xhc_dbc_offset; + void __iomem *xhc_mmio; + + bool open; +}; + +static void *dbc_sys_map_xhc(uint64_t phys, size_t size) +{ + size_t i; + + if ( size != MAX_XHCI_PAGES * DBC_PAGE_SIZE ) + return NULL; + + for ( i = FIX_XHCI_END; i >= FIX_XHCI_BEGIN; i-- ) + { + set_fixmap_nocache(i, phys); + phys += DBC_PAGE_SIZE; + } + + /* + * The fixmap grows downward, so the lowest virt is + * at the highest index + */ + return fix_to_virt(FIX_XHCI_END); +} + +static bool __init dbc_init_xhc(struct dbc *dbc) +{ + uint32_t bar0; + uint64_t bar1; + uint64_t bar_size; + uint64_t devfn; + uint16_t cmd; + size_t xhc_mmio_size; + + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so far + * are part of the chipset and are on bus 0. + */ + for ( devfn = 0; devfn < 256; devfn++ ) + { + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); + uint8_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr == 0 || hdr == 0x80 ) + { + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == DBC_XHC_CLASSC ) + { + dbc->sbdf = sbdf; + break; + } + } + } + + if ( !dbc->sbdf.sbdf ) + { + dbc_error("Compatible xHC not found on bus 0\n"); + return false; + } + + /* ...we found it, so parse the BAR and map the registers */ + bar0 = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar1 = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1); + + /* IO BARs not allowed; BAR must be 64-bit */ + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY || + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) != PCI_BASE_ADDRESS_MEM_TYPE_64 ) + return false; + + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY); + + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, 0xFFFFFFFF); + bar_size = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar_size |= (uint64_t)pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1) << 32; + xhc_mmio_size = ~(bar_size & PCI_BASE_ADDRESS_MEM_MASK) + 1; + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, bar0); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, bar1); + + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + + dbc->xhc_mmio_phys = (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 32); + dbc->xhc_mmio = dbc_sys_map_xhc(dbc->xhc_mmio_phys, xhc_mmio_size); + + if ( dbc->xhc_mmio == NULL ) + return false; + + if ( (cmd & PCI_COMMAND_MEMORY) == 0 ) + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MEMORY); + + return true; +} + +/** + * The first register of the debug capability is found by traversing the + * host controller's capability list (xcap) until a capability + * with ID = 0xA is found. The xHCI capability list begins at address + * mmio + (HCCPARAMS1[31:16] << 2). + */ +static struct dbc_reg __iomem *xhci_find_dbc(struct dbc *dbc) +{ + uint32_t *xcap; + uint32_t xcap_val; + uint32_t next; + uint32_t id = 0; + uint8_t *mmio = (uint8_t *)dbc->xhc_mmio; + uint32_t *hccp1 = (uint32_t *)(mmio + 0x10); + const uint32_t DBC_ID = 0xA; + int ttl = 48; + + xcap = (uint32_t *)dbc->xhc_mmio; + /* + * This is initially an offset to the first capability. All the offsets + * (both in HCCP1 and then next capability pointer are dword-based. + */ + next = (readl(hccp1) & 0xFFFF0000) >> 16; + + while ( id != DBC_ID && next && ttl-- ) + { + xcap += next; + xcap_val = readl(xcap); + id = xcap_val & 0xFF; + next = (xcap_val & 0xFF00) >> 8; + } + + if ( id != DBC_ID ) + return NULL; + + dbc->xhc_dbc_offset = (uint64_t)xcap - (uint64_t)mmio; + return (struct dbc_reg __iomem *)xcap; +} + +/** + * Fields with the same interpretation for every TRB type (section 4.11.1). + * These are the fields defined in the TRB template, minus the ENT bit. That + * bit is the toggle cycle bit in link TRBs, so it shouldn't be in the + * template. + */ +static uint32_t xhci_trb_cyc(const struct xhci_trb *trb) +{ + return trb->ctrl & 0x1; +} + +static uint32_t xhci_trb_type(const struct xhci_trb *trb) +{ + return (trb->ctrl & 0xFC00) >> 10; +} + +static void xhci_trb_set_cyc(struct xhci_trb *trb, uint32_t c) +{ + trb->ctrl &= ~0x1U; + trb->ctrl |= c; +} + +static void xhci_trb_set_type(struct xhci_trb *trb, uint32_t t) +{ + trb->ctrl &= ~0xFC00U; + trb->ctrl |= (t << 10); +} + +/* Fields for normal TRBs */ +static void xhci_trb_norm_set_buf(struct xhci_trb *trb, uint64_t addr) +{ + trb->params = addr; +} + +static void xhci_trb_norm_set_len(struct xhci_trb *trb, uint32_t len) +{ + trb->status &= ~0x1FFFFU; + trb->status |= len; +} + +static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) +{ + trb->ctrl |= 0x20; +} + +/** + * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event + * TRBs are read-only from software + */ +static uint64_t xhci_trb_tfre_ptr(const struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) +{ + return trb->status >> 24; +} + +/* Fields for link TRBs (section 6.4.4.1) */ +static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) +{ + trb->params = rsp; +} + +static void xhci_trb_link_set_tc(struct xhci_trb *trb) +{ + trb->ctrl |= 0x2; +} + +static void xhci_trb_ring_init(const struct dbc *dbc, + struct xhci_trb_ring *ring, int producer, + int doorbell) +{ + memset(ring->trb, 0, DBC_TRB_RING_CAP * sizeof(ring->trb[0])); + + ring->enq = 0; + ring->deq = 0; + ring->cyc = 1; + ring->db = (uint8_t)doorbell; + ring->dma = virt_to_maddr(ring->trb); + + /* + * Producer implies transfer ring, so we have to place a + * link TRB at the end that points back to trb[0] + */ + if ( producer ) + { + struct xhci_trb *trb = &ring->trb[DBC_TRB_RING_CAP - 1]; + xhci_trb_set_type(trb, XHCI_TRB_LINK); + xhci_trb_link_set_tc(trb); + xhci_trb_link_set_rsp(trb, virt_to_maddr(ring->trb)); + } +} + +static int xhci_trb_ring_full(const struct xhci_trb_ring *ring) +{ + return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) == ring->deq; +} + +static int dbc_work_ring_full(const struct dbc_work_ring *ring) +{ + return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) == ring->deq; +} + +static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return DBC_WORK_RING_CAP - ring->deq + ring->enq; +} + +static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, + uint64_t dma, uint64_t len) +{ + struct xhci_trb trb; + + if ( ring->enq == DBC_TRB_RING_CAP - 1 ) + { + /* + * We have to make sure the xHC processes the link TRB in order + * for wrap-around to work properly. We do this by marking the + * xHC as owner of the link TRB by setting the TRB's cycle bit + * (just like with normal TRBs). + */ + struct xhci_trb *link = &ring->trb[ring->enq]; + xhci_trb_set_cyc(link, ring->cyc); + + ring->enq = 0; + ring->cyc ^= 1; + } + + trb.params = 0; + trb.status = 0; + trb.ctrl = 0; + + xhci_trb_set_type(&trb, XHCI_TRB_NORM); + xhci_trb_set_cyc(&trb, ring->cyc); + + xhci_trb_norm_set_buf(&trb, dma); + xhci_trb_norm_set_len(&trb, (uint32_t)len); + xhci_trb_norm_set_ioc(&trb); + + ring->trb[ring->enq++] = trb; + cache_flush(&ring->trb[ring->enq - 1], sizeof(trb)); +} + +static int64_t dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, + const char *buf, unsigned int len) +{ + unsigned int i = 0; + unsigned int end, start = ring->enq; + + while ( !dbc_work_ring_full(ring) && i < len ) + { + ring->buf[ring->enq] = buf[i++]; + ring->enq = (ring->enq + 1) & (DBC_WORK_RING_CAP - 1); + } + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); + else if ( i > 0 ) + { + cache_flush(&ring->buf[start], DBC_WORK_RING_CAP - start); + cache_flush(&ring->buf[0], end); + } + + return i; +} + +/* + * Note that if IN transfer support is added, then this + * will need to be changed; it assumes an OUT transfer ring only + */ +static void dbc_pop_events(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + struct xhci_trb_ring *er = &dbc->dbc_ering; + struct xhci_trb_ring *tr = &dbc->dbc_oring; + struct xhci_trb *event = &er->trb[er->deq]; + uint64_t erdp = readq(®->erdp); + uint32_t portsc; + uint64_t event_ptr; + unsigned int trb_idx; + + BUILD_BUG_ON((1 << XHCI_TRB_SHIFT) != sizeof(struct xhci_trb)); + + rmb(); + + while ( xhci_trb_cyc(event) == er->cyc ) + { + switch (xhci_trb_type(event)) + { + case XHCI_TRB_TFRE: + event_ptr = xhci_trb_tfre_ptr(event); + /* + * trb_idx is just completed TRB, so set the dequeue ptr one + * position further. + */ + if ( event_ptr - tr->dma < DBC_TRB_RING_BYTES ) + { + trb_idx = (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; + tr->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } + else + dbc_alert("event: TRB 0x%lx not found in any ring\n", + event_ptr); + break; + case XHCI_TRB_PSCE: + portsc = readl(®->portsc); + portsc |= DBC_PSC_ACK_MASK & portsc; + writel(portsc, ®->portsc); + break; + default: + break; + } + + er->cyc = (er->deq == DBC_TRB_RING_CAP - 1) ? er->cyc ^ 1 : er->cyc; + er->deq = (er->deq + 1) & (DBC_TRB_RING_CAP - 1); + event = &er->trb[er->deq]; + } + + erdp = er->dma + (er->deq << XHCI_TRB_SHIFT); + wmb(); + writeq(erdp, ®->erdp); +} + +/** + * dbc_init_ep + * + * Initializes the endpoint as specified in sections 7.6.3.2 and 7.6.9.2. + * Each endpoint is Bulk, so the MaxPStreams, LSA, HID, CErr, FE, + * Interval, Mult, and Max ESIT Payload fields are all 0. + * + * Max packet size: 1024 + * Max burst size: debug mbs (from dbc_reg->ctrl register) + * EP type: 2 for OUT bulk, 6 for IN bulk + * TR dequeue ptr: physical base address of transfer ring + * Avg TRB length: software defined (see 4.14.1.1 for suggested defaults) + */ +static void dbc_init_ep(uint32_t *ep, uint64_t mbs, uint32_t type, + uint64_t ring_dma) +{ + memset(ep, 0, DBC_CTX_BYTES); + + ep[1] = (1024 << 16) | ((uint32_t)mbs << 8) | (type << 3); + ep[2] = (ring_dma & 0xFFFFFFFF) | 1; + ep[3] = ring_dma >> 32; + ep[4] = 3 * 1024; +} + +static void dbc_init_string_single(struct xhci_string_descriptor *string, + char *ascii_str, + uint64_t *str_ptr, + uint8_t *str_size_ptr) +{ + size_t i, len = strlen(ascii_str); + + string->size = offsetof(typeof(*string), string) + len * 2; + string->type = XHCI_DT_STRING; + /* ASCII to UTF16 conversion */ + for (i = 0; i < len; i++) + string->string[i] = ascii_str[i]; + *str_ptr = virt_to_maddr(string); + *str_size_ptr = string->size; +} + +/* Initialize the DbC info with USB string descriptor addresses */ +static void dbc_init_strings(struct dbc *dbc, uint32_t *info) +{ + BUILD_BUG_ON(sizeof(DBC_STRING_LANGID) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_MANUFACTURER) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_PRODUCT) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_SERIAL) > MAX_STRING_LENGTH); + + dbc_init_string_single(&dbc->dbc_str[0], DBC_STRING_LANGID, + &dbc->dbc_ctx->string0_ptr, + &dbc->dbc_ctx->string0_size); + dbc_init_string_single(&dbc->dbc_str[1], DBC_STRING_MANUFACTURER, + &dbc->dbc_ctx->manufacturer_ptr, + &dbc->dbc_ctx->manufacturer_size); + dbc_init_string_single(&dbc->dbc_str[2], DBC_STRING_PRODUCT, + &dbc->dbc_ctx->product_ptr, + &dbc->dbc_ctx->product_size); + dbc_init_string_single(&dbc->dbc_str[3], DBC_STRING_SERIAL, + &dbc->dbc_ctx->serial_ptr, + &dbc->dbc_ctx->serial_size); +} + +static void dbc_enable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + + wmb(); + writel(readl(®->ctrl) | (1U << DBC_CTRL_DCE), ®->ctrl); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) == 0 ) + cpu_relax(); + + wmb(); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCR)) == 0 ) + cpu_relax(); +} + +static void dbc_disable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + + writel(readl(®->portsc) & ~(1U << DBC_PSC_PED), ®->portsc); + wmb(); + writel(readl(®->ctrl) & ~(1U << DBC_CTRL_DCE), ®->ctrl); + + while ( readl(®->ctrl) & (1U << DBC_CTRL_DCE) ) + cpu_relax(); +} + +static int dbc_init_dbc(struct dbc *dbc) +{ + uint64_t erdp = 0; + uint64_t mbs = 0; + uint16_t cmd; + struct dbc_reg *reg = xhci_find_dbc(dbc); + + if ( !reg ) + return 0; + + dbc->dbc_reg = reg; + dbc_disable_dbc(dbc); + + xhci_trb_ring_init(dbc, &dbc->dbc_ering, 0, DBC_DB_INVAL); + xhci_trb_ring_init(dbc, &dbc->dbc_oring, 1, DBC_DB_OUT); + xhci_trb_ring_init(dbc, &dbc->dbc_iring, 1, DBC_DB_IN); + + erdp = virt_to_maddr(dbc->dbc_ering.trb); + if ( !erdp ) + return 0; + + memset(dbc->dbc_erst, 0, sizeof(*dbc->dbc_erst)); + dbc->dbc_erst->base = erdp; + dbc->dbc_erst->size = DBC_TRB_RING_CAP; + + mbs = (readl(®->ctrl) & 0xFF0000) >> 16; + + memset(dbc->dbc_ctx, 0, sizeof(*dbc->dbc_ctx)); + dbc_init_strings(dbc, dbc->dbc_ctx->info); + dbc_init_ep(dbc->dbc_ctx->ep_out, mbs, XHCI_EP_BULK_OUT, + dbc->dbc_oring.dma); + dbc_init_ep(dbc->dbc_ctx->ep_in, mbs, XHCI_EP_BULK_IN, + dbc->dbc_iring.dma); + + writel(1, ®->erstsz); + writeq(virt_to_maddr(dbc->dbc_erst), ®->erstba); + writeq(erdp, ®->erdp); + writeq(virt_to_maddr(dbc->dbc_ctx), ®->cp); + writel((DBC_DBC_VENDOR << 16) | DBC_DBC_PROTOCOL, ®->ddi1); + writel(DBC_DBC_PRODUCT, ®->ddi2); + + cache_flush(dbc->dbc_ctx, sizeof(*dbc->dbc_ctx)); + cache_flush(dbc->dbc_erst, sizeof(*dbc->dbc_erst)); + cache_flush(dbc->dbc_ering.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_oring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_iring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_owork.buf, DBC_WORK_RING_BYTES); + + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MASTER); + + return 1; +} + +static void dbc_init_work_ring(struct dbc *dbc, + struct dbc_work_ring *wrk) +{ + wrk->enq = 0; + wrk->deq = 0; + wrk->dma = virt_to_maddr(wrk->buf); +} + +/** + * Initialize the DbC and enable it for transfers. First map in the DbC + * registers from the host controller's MMIO region. Then allocate and map + * DMA for the event and transfer rings. Finally, enable the DbC for + * the host to enumerate. On success, the DbC is ready to send packets. + * + * @param dbc the dbc to open (!= NULL) + * @return true iff dbc_open succeeded + */ +static bool __init dbc_open(struct dbc *dbc) +{ + if ( !dbc ) + return false; + + if ( !dbc_init_xhc(dbc) ) + return false; + + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + dbc->open = true; + + return true; +} + +/* + * Ensure DbC is still running, handle events, and possibly re-enable if cable + * was re-plugged. Returns true if DbC is operational. + */ +static bool dbc_ensure_running(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t ctrl; + uint32_t cmd; + + dbc_pop_events(dbc); + + ctrl = readl(®->ctrl); + if ( !(ctrl & (1U << DBC_CTRL_DCR)) ) + { + return false; + } + + if ( ctrl & (1U << DBC_CTRL_DRC) ) + { + writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + } + + return true; +} + +/** + * Commit the pending transfer TRBs to the DbC. This notifies + * the DbC of any previously-queued data on the work ring and + * rings the doorbell. + * + * @param dbc the dbc to flush + * @param trb the ring containing the TRBs to transfer + * @param wrk the work ring containing data to be flushed + */ +static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t db = (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + if ( xhci_trb_ring_full(trb) ) + return; + + if ( wrk->enq == wrk->deq ) + return; + else if ( wrk->enq > wrk->deq ) + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, wrk->enq - wrk->deq); + wrk->deq = wrk->enq; + } + else + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, + DBC_WORK_RING_CAP - wrk->deq); + wrk->deq = 0; + if ( wrk->enq > 0 && !xhci_trb_ring_full(trb) ) + { + dbc_push_trb(dbc, trb, wrk->dma, wrk->enq); + wrk->deq = wrk->enq; + } + } + + wmb(); + writel(db, ®->db); +} + +/** + * Queue a single character to the DbC. A transfer TRB will be created + * if the character is a newline and the DbC will be notified that data is + * available for writing to the debug host. + * + * @param dbc the dbc to write to + * @param c the character to write + * @return the number of bytes written + */ +static int64_t dbc_putc(struct dbc *dbc, char c) +{ + if ( !dbc_push_work(dbc, &dbc->dbc_owork, &c, 1) ) + return 0; + + if ( !dbc_ensure_running(dbc) ) + return 1; + + if ( c == '\n' ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + return 1; +} + +struct dbc_uart { + struct dbc dbc; + struct timer timer; + spinlock_t *lock; +}; + +static struct dbc_uart dbc_uart; + +static void cf_check dbc_uart_poll(void *data) +{ + struct serial_port *port = data; + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + unsigned long flags = 0; + + if ( spin_trylock_irqsave(&port->tx_lock, flags) ) + { + if ( dbc_ensure_running(dbc) ) + { + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + dbc_enqueue_in(dbc, &dbc->dbc_iring, &dbc->dbc_iwork); + } + spin_unlock_irqrestore(&port->tx_lock, flags); + } + + serial_tx_interrupt(port, guest_cpu_user_regs()); + set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); +} + +static void __init cf_check dbc_uart_init_preirq(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + uart->lock = &port->tx_lock; +} + +static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + + serial_async_transmit(port); + init_timer(&uart->timer, dbc_uart_poll, port, 0); + set_timer(&uart->timer, NOW() + MILLISECS(1)); + + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); +} + +static int cf_check dbc_uart_tx_ready(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + return DBC_WORK_RING_CAP - dbc_work_ring_size(&dbc->dbc_owork); +} + +static void cf_check dbc_uart_putc(struct serial_port *port, char c) +{ + struct dbc_uart *uart = port->uart; + dbc_putc(&uart->dbc, c); +} + +static void cf_check dbc_uart_flush(struct serial_port *port) +{ + s_time_t goal; + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + if ( dbc_ensure_running(dbc) ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + goal = NOW() + MICROSECS(DBC_POLL_INTERVAL); + if ( uart->timer.expires > goal ) + set_timer(&uart->timer, goal); +} + +static struct uart_driver dbc_uart_driver = { + .init_preirq = dbc_uart_init_preirq, + .init_postirq = dbc_uart_init_postirq, + .tx_ready = dbc_uart_tx_ready, + .putc = dbc_uart_putc, + .flush = dbc_uart_flush, +}; + +static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; +static struct xhci_erst_segment erst __aligned(64); +static struct xhci_dbc_ctx ctx __aligned(64); +static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); +static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +static char __initdata opt_dbgp[30]; + +string_param("dbgp", opt_dbgp); + +void __init xhci_dbc_uart_init(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + if ( strncmp(opt_dbgp, "xhci", 4) ) + return; + + memset(dbc, 0, sizeof(*dbc)); + + dbc->dbc_ctx = &ctx; + dbc->dbc_erst = &erst; + dbc->dbc_ering.trb = evt_trb; + dbc->dbc_oring.trb = out_trb; + dbc->dbc_iring.trb = in_trb; + dbc->dbc_owork.buf = out_wrk_buf; + dbc->dbc_str = str_buf; + + if ( dbc_open(dbc) ) + serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); +} + +#ifdef DBC_DEBUG +static void dbc_dump(struct dbc *dbc) +{ + struct dbc_reg *r = dbc->dbc_reg; + + dbc_debug("XHCI DBC DUMP:\n"); + dbc_debug(" ctrl: 0x%x stat: 0x%x psc: 0x%x\n", + readl(&r->ctrl), readl(&r->st), readl(&r->portsc)); + dbc_debug(" id: 0x%x, db: 0x%x\n", + readl(&r->id), readl(&r->db)); + dbc_debug(" erstsz: %u, erstba: 0x%lx\n", + readl(&r->erstsz), readq(&r->erstba)); + dbc_debug(" erdp: 0x%lx, cp: 0x%lx\n", + readq(&r->erdp), readq(&r->cp)); + dbc_debug(" ddi1: 0x%x, ddi2: 0x%x\n", + readl(&r->ddi1), readl(&r->ddi2)); + dbc_debug(" erstba == virt_to_dma(erst): %d\n", + readq(&r->erstba) == virt_to_maddr(dbc->dbc_erst)); + dbc_debug(" erdp == virt_to_dma(erst[0].base): %d\n", + readq(&r->erdp) == dbc->dbc_erst[0].base); + dbc_debug(" cp == virt_to_dma(ctx): %d\n", + readq(&r->cp) == virt_to_maddr(dbc->dbc_ctx)); +} + +static void dbc_uart_dump(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + dbc_dump(dbc); +} +#endif diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 6548f0b0a9cf..181e026967bc 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -171,6 +171,11 @@ struct ns16550_defaults { }; void ns16550_init(int index, struct ns16550_defaults *defaults); void ehci_dbgp_init(void); +#ifdef CONFIG_XHCI +void xhci_dbc_uart_init(void); +#else +static void inline xhci_dbc_uart_init(void) {}; +#endif void arm_uart_init(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374936.607170 (Exim 4.92) (envelope-from ) id 1oGBAV-0003wK-FO; Tue, 26 Jul 2022 03:23:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374936.607170; Tue, 26 Jul 2022 03:23:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAV-0003w9-BY; Tue, 26 Jul 2022 03:23:35 +0000 Received: by outflank-mailman (input) for mailman id 374936; Tue, 26 Jul 2022 03:23:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAT-0003P0-SL for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:33 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 52d2e04c-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:31 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 1E3605C00E4; Mon, 25 Jul 2022 23:23:31 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:31 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:29 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 52d2e04c-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805811; x=1658892211; bh=mn0z1OH9eg gVIVHY4O0/oZ9aMMverVaOFzZCSUteg7c=; b=glyArnG9S9fGItYdmV6xuIABX5 FhM7J6AkqfUzfPh2O7CVhcjHsDrn7PO5FMQqiIr+fZUPQ5TPMxNUjFxrTBdZgqVh OkTmGiHQl3joPxAxosiLnyuirErBkMVPuc8GZP5Cq1gxPcKcj99Ml5Kt9ao/dnzG 8x2Vd3NH1Gh+WBtkhq8enqPrvgFfEGPNcG7+ebW3MxbPpy3xRjXaEzw5UGKokKwB 6nbnETABu/fgP9cWXq7u0x0KvFzW9MRdMlEnhRokQwSznX1oojyY/DXZr6rQGUKu WWBIhHVMB28SnHTrvjmpUOKNDHbH0YCJyiVaHfrSmLY8MiAR1n8u/VHIzz2A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805811; x= 1658892211; bh=mn0z1OH9eggVIVHY4O0/oZ9aMMverVaOFzZCSUteg7c=; b=Q lyKL0uHEipv1rrru2WwJyMUJQaNjeg4nDF+9uELy6xyvm/OEixaJkKYQ0ApF8oXZ qWPtLiBjr/DfeMh8QW+unVX8uBBvHXilEPtIRQ8i/lWP5Psa3E23tgWM9X+oKg3t g/CHzhwkKKudqZmSCzlpNLd38Gt3MIZs6QagGcb6C2plPKjQHGTI+5Jx4AKj0J6M ZGuszkvtgmsq5cFPe1zZAlJyk+Mlnf4K7la8EHTqFiZrq4S7uL8IZuwiGA2cvHUB 5RZvFXmTWj9+rcPDEshWS7gqfr9co+LvQjwhj/a5ldQVOwKkEEV1YsyE+za7GuVs HvaU9M2d4LyR22NKVCZiA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 02/10] drivers/char: reset XHCI ports when initializing dbc Date: Tue, 26 Jul 2022 05:23:07 +0200 Message-Id: <0f26cc3299e340f7cea58aa59fcd462abd3215da.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Reset ports, to force host system to re-enumerate devices. Otheriwse it will require the cable to be re-plugged, or will wait in the "configuring" state indefinitely. Trick and code copied from Linux: drivers/usb/early/xhci-dbc.c:xdbc_start()->xdbc_reset_debug_port() Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - adjust for renamed driver - use readl() etc for MMIO - simplify xcap lookup - drop acked-by Changes in v2: - use uint32_t instead of u32 - code style --- xen/drivers/char/xhci-dbc.c | 75 ++++++++++++++++++++++++++++++++++++++- 1 file changed, 75 insertions(+) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index f0e60d1b86aa..53c39eedd4a6 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -63,6 +63,10 @@ ((1UL << DBC_PSC_CSC) | (1UL << DBC_PSC_PRC) | (1UL << DBC_PSC_PLC) | \ (1UL << DBC_PSC_CEC)) +#define XHC_EXT_PORT_MAJOR(x) (((x) >> 24) & 0xff) +#define PORT_RESET (1 << 4) +#define PORT_CONNECT (1 << 0) + #define dbc_debug(...) printk("dbc debug: " __VA_ARGS__) #define dbc_alert(...) printk("dbc alert: " __VA_ARGS__) #define dbc_error(...) printk("dbc error: " __VA_ARGS__) @@ -660,6 +664,73 @@ static void dbc_init_strings(struct dbc *dbc, uint32_t *info) &dbc->dbc_ctx->serial_size); } +static void dbc_do_reset_debug_port(struct dbc *dbc, + unsigned int id, unsigned int count) +{ + uint32_t __iomem *ops_reg; + uint32_t __iomem *portsc; + uint32_t val, cap_length; + unsigned int i; + + cap_length = readl(dbc->xhc_mmio) & 0xff; + ops_reg = dbc->xhc_mmio + cap_length; + + id--; + for ( i = id; i < (id + count); i++ ) + { + portsc = ops_reg + 0x100 + i * 0x4; + val = readl(portsc); + if ( !(val & PORT_CONNECT) ) + writel(val | PORT_RESET, portsc); + } +} + +static void dbc_reset_debug_port(struct dbc *dbc) +{ + uint32_t val, port_offset, port_count; + uint32_t __iomem *xcap; + uint32_t xcap_val; + uint32_t next; + uint32_t id; + uint8_t __iomem *mmio = (uint8_t *)dbc->xhc_mmio; + uint32_t __iomem *hccp1 = (uint32_t *)(mmio + 0x10); + const uint32_t PROTOCOL_ID = 0x2; + int ttl = 48; + + xcap = (uint32_t *)dbc->xhc_mmio; + /* + * This is initially an offset to the first capability. All the offsets + * (both in HCCP1 and then next capability pointer are dword-based. + */ + next = (readl(hccp1) & 0xFFFF0000) >> 16; + + /* + * Look for "supported protocol" capability, major revision 3. + * There may be multiple of them. + */ + while ( next && ttl-- ) + { + xcap += next; + xcap_val = readl(xcap); + id = xcap_val & 0xFF; + next = (xcap_val & 0xFF00) >> 8; + + if ( id != PROTOCOL_ID ) + continue; + + if ( XHC_EXT_PORT_MAJOR(xcap_val) != 0x3 ) + continue; + + /* extract ports offset and count from the capability structure */ + val = readl(xcap + 2); + port_offset = val & 0xff; + port_count = (val >> 8) & 0xff; + + /* and reset them all */ + dbc_do_reset_debug_port(dbc, port_offset, port_count); + } +} + static void dbc_enable_dbc(struct dbc *dbc) { struct dbc_reg *reg = dbc->dbc_reg; @@ -671,6 +742,10 @@ static void dbc_enable_dbc(struct dbc *dbc) while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) == 0 ) cpu_relax(); + /* reset ports on initial open, to force re-enumerating by the host */ + if ( !dbc->open ) + dbc_reset_debug_port(dbc); + wmb(); writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); wmb(); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374935.607159 (Exim 4.92) (envelope-from ) id 1oGBAU-0003fd-2l; Tue, 26 Jul 2022 03:23:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374935.607159; Tue, 26 Jul 2022 03:23:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAT-0003fS-Vm; Tue, 26 Jul 2022 03:23:33 +0000 Received: by outflank-mailman (input) for mailman id 374935; Tue, 26 Jul 2022 03:23:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAS-0003P0-S9 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:33 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 51d4aa20-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:30 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 6AD375C00CC; Mon, 25 Jul 2022 23:23:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:29 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:27 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 51d4aa20-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805809; x=1658892209; bh=rHEDfxRD/a 8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=Y0DYPy9T5QVOmEf2l+98Yrls5V KNdTS/LdDkCdknHDQMtuYEtpZWixQJaJCpfiq+i0/TfuHwI26DfPvKgVnbXNX98T d12yObPjv9B5zyAn4yJB88XHrYmBAE2YZVVQNcI2B6G0KU8PlqUuiV48WR3lhDlX 8Sd82x3k5MfmsmCzN+XfDOIdzrg6TzL1b9lDAKd4J7QFfam4cIuQnjS7U5sLm3Xc gs/LKbVxfOL29Pv80mjQ6AoI5ZGQVHZ8aelQbooJodzZlyuOlf/9E/LDPGs/iwQD eB9TvMeBLnQFOkK0zG1D0gqs1xvpxQJfHu6ha7ZNctf5IwT3HJOcuy9s6gHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805809; x= 1658892209; bh=rHEDfxRD/a8Xy6nGoB/Ufb5Aee8IzVX8gl6KkLM1ayE=; b=s ebgA0ntWuUxP3N7ANMPDVmzP/yDermek6uOXojGosGGC0i6SOsmz4CfaOlzq6vm0 cyt4ZXsxxhgyhA18lxqzF0cbedzyLbx3O0MkjyVkgoZliDWpm1dFBLTMp06kTrnX Div4e7Cy/29HJcidETX4VOWqolWcey5BHRDAZ9Tqd8lmlf4iZ+1WlBg+NA3PfRKn yHbmpkmiMcUY3N+aohSsciC+IqH1uIPBX07lXID2RP1P2p09WnAz37c9Zhd1VTM9 bgD89zhAPp0Z1ow0F5detTm8IEnqPQx7fMN5NsJ2+GcCRN1kXAvFuvxjjimxT7Uy 1Y7ITjAtr3fDG/giYqWSg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeek udejueeuudetudffffdtheetteeileekkeefjeeljefhkeelffevueffkeelfeenucffoh hmrghinhepghhithhhuhgsrdgtohhmpdhgnhhurdhorhhgnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsih gslhgvthhhihhnghhslhgrsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 01/10] drivers/char: Add support for USB3 DbC debugger Date: Tue, 26 Jul 2022 05:23:06 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Connor Davis [Connor] Xue is a cross-platform USB 3 debugger that drives the Debug Capability (DbC) of xHCI-compliant host controllers. This patch implements the operations needed for xue to initialize the host controller's DbC and communicate with it. It also implements a struct uart_driver that uses xue as a backend. Note that only target -> host communication is supported for now. To use Xue as a console, add 'console=dbgp dbgp=xhci' to the command line. [Marek] The Xue driver is taken from https://github.com/connojd/xue and heavily refactored to fit into Xen code base. Major changes include: - rename to xhci_dbc - drop support for non-Xen systems - drop xue_ops abstraction - use Xen's native helper functions for PCI access - move all the code to xue.c, drop "inline" - build for x86 only - annotate functions with cf_check - adjust for Xen's code style At this stage, only the first xHCI is considered. Later patch adds support for choosing specific one. The driver is initiallized before memory allocator works, so all the transfer buffers (about 230KiB of them) are allocated statically and will use memory even if XUE console is not selected. The driver can be disabled build time to reclaim this memory. Signed-off-by: Connor Davis Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - rename to xhci-dbc - add empty stub for xhci_dbc_uart_init(), to avoid #ifdef in setup.c - use PCI_BASE_ADDRESS_MEM_MASK - make strings init more readable - avoid infinite extended caps lookup - size the whole 64bit BAR - rename CONFIG_HAS_XHCI to CONFIG_XHCI - use cpu_relax(), drop xue_sys_pause() - disable memory decoding for the BAR sizing time, and enable it explicitly - drop mmio_size field - it's used only in init_xhc() function internally - use readl()/writel() for accessing MMIO - add pci_ro_device(), to protect device before later patch(es) add other protections - fix setting dequeue pointer based on events: TRB ring was page aligned, not 16-page aligned, so just taking DBC_TRB_RING_MASK bits doesn't work; instead, calculate distance from the ring beginning; while at it, fix off by one error there; dequeue pointer isn't used much yet, but it will be useful for RX handling - split dbc_ensure_running() out of dbc_flush() - it make dbc_flush() more logical, and will make even more sense with RX support added - make enum names upper case Changes in v2: - drop #pragma pack - fix indentation in Kconfig - minor style fixes - use cache_flush() - mark init functions as __init, and return bool - fix PCI_SBDF usage, use constants from pci_regs.h - add command line docs - allow disabling the driver in menuconfig, to reclaim 2MB allocated memory - guard unused debug functions with #ifdef XUE_DEBUG --- docs/misc/xen-command-line.pandoc | 5 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 1 +- xen/drivers/char/Kconfig | 9 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/xhci-dbc.c | 1024 ++++++++++++++++++++++++++++++- xen/include/xen/serial.h | 5 +- 7 files changed, 1049 insertions(+) create mode 100644 xen/drivers/char/xhci-dbc.c diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index da18172e50c5..f936283cd187 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,10 +721,15 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` +> `= xhci` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output +only). XHCI driver will wait indefinitely for the debug host to connect - make +sure the cable is connected. + ### debug_stack_lines > `= ` diff --git a/xen/arch/x86/include/asm/fixmap.h b/xen/arch/x86/include/asm/fixmap.h index 20746afd0a2a..bc39ffe896b1 100644 --- a/xen/arch/x86/include/asm/fixmap.h +++ b/xen/arch/x86/include/asm/fixmap.h @@ -25,6 +25,8 @@ #include #include +#define MAX_XHCI_PAGES 16 + /* * Here we define all the compile-time 'special' virtual * addresses. The point is to have a constant address at @@ -43,6 +45,8 @@ enum fixed_addresses { FIX_COM_BEGIN, FIX_COM_END, FIX_EHCI_DBGP, + FIX_XHCI_BEGIN, + FIX_XHCI_END = FIX_XHCI_BEGIN + MAX_XHCI_PAGES - 1, #ifdef CONFIG_XEN_GUEST FIX_PV_CONSOLE, FIX_XEN_SHARED_INFO, diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c index f08b07b8dea6..e05189f64997 100644 --- a/xen/arch/x86/setup.c +++ b/xen/arch/x86/setup.c @@ -950,6 +950,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) ns16550.irq = 3; ns16550_init(1, &ns16550); ehci_dbgp_init(); + xhci_dbc_uart_init(); console_init_preirq(); if ( pvh_boot ) diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index dec58bc99360..06350c387371 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -84,3 +84,12 @@ config SERIAL_TX_BUFSIZE the nearest power of 2. Default value is 16384 (16kiB). + +config XHCI + bool "XHCI DbC UART driver" + depends on X86 + help + This selects the USB based XHCI debug capability to be usable as a UART. + Enabling this option makes Xen use extra ~230KiB memory, even if XHCI UART + is not selected. + If you have an x86 based system with USB3, say Y. diff --git a/xen/drivers/char/Makefile b/xen/drivers/char/Makefile index 14e67cf072d7..e7e374775d32 100644 --- a/xen/drivers/char/Makefile +++ b/xen/drivers/char/Makefile @@ -8,6 +8,7 @@ obj-$(CONFIG_HAS_MVEBU) += mvebu-uart.o obj-$(CONFIG_HAS_OMAP) += omap-uart.o obj-$(CONFIG_HAS_SCIF) += scif-uart.o obj-$(CONFIG_HAS_EHCI) += ehci-dbgp.o +obj-$(CONFIG_XHCI) += xhci-dbc.o obj-$(CONFIG_HAS_IMX_LPUART) += imx-lpuart.o obj-$(CONFIG_ARM) += arm-uart.o obj-y += serial.o diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c new file mode 100644 index 000000000000..f0e60d1b86aa --- /dev/null +++ b/xen/drivers/char/xhci-dbc.c @@ -0,0 +1,1024 @@ +/* + * drivers/char/xhci-dbc.c + * + * Xen port for the xue debugger + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; If not, see . + * + * Copyright (c) 2019 Assured Information Security. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* uncomment to have dbc_uart_dump() debug function */ +/* #define DBC_DEBUG 1 */ + +#define DBC_POLL_INTERVAL 100 /* us */ + +#define DBC_PAGE_SIZE 4096U + +/* Supported xHC PCI configurations */ +#define DBC_XHC_CLASSC 0xC0330U + +/* DbC idVendor and idProduct */ +#define DBC_DBC_VENDOR 0x1D6B +#define DBC_DBC_PRODUCT 0x0010 +#define DBC_DBC_PROTOCOL 0x0000 + +/* DCCTRL fields */ +#define DBC_CTRL_DCR 0 +#define DBC_CTRL_HOT 2 +#define DBC_CTRL_HIT 3 +#define DBC_CTRL_DRC 4 +#define DBC_CTRL_DCE 31 + +/* DCPORTSC fields */ +#define DBC_PSC_PED 1 +#define DBC_PSC_CSC 17 +#define DBC_PSC_PRC 21 +#define DBC_PSC_PLC 22 +#define DBC_PSC_CEC 23 + +#define DBC_PSC_ACK_MASK \ + ((1UL << DBC_PSC_CSC) | (1UL << DBC_PSC_PRC) | (1UL << DBC_PSC_PLC) | \ + (1UL << DBC_PSC_CEC)) + +#define dbc_debug(...) printk("dbc debug: " __VA_ARGS__) +#define dbc_alert(...) printk("dbc alert: " __VA_ARGS__) +#define dbc_error(...) printk("dbc error: " __VA_ARGS__) + +/****************************************************************************** + * TRB ring (summarized from the manual): + * + * TRB rings are circular queues of TRBs shared between the xHC and the driver. + * Each ring has one producer and one consumer. The DbC has one event + * ring and two transfer rings; one IN and one OUT. + * + * The DbC hardware is the producer on the event ring, and + * dbc driver is the consumer. This means that event TRBs are read-only from + * the dbc driver. + * + * OTOH, dbc drive is the producer of transfer TRBs on the two transfer + * rings, so dbc driver enqueues transfers, and the hardware dequeues + * them. The dequeue pointer of a transfer ring is read by + * dbc driver by examining the latest transfer event TRB on the event ring. The + * transfer event TRB contains the address of the transfer TRB that generated + * the event. + * + * To make each transfer ring circular, the last TRB must be a link TRB, which + * points to the beginning of the next queue. Note that this implementation + * does not support multiple segments, so each link TRB points back to the + * beginning of its own segment. + ******************************************************************************/ + +/* TRB types */ +enum { + XHCI_TRB_NORM = 1, + XHCI_TRB_LINK = 6, + XHCI_TRB_TFRE = 32, + XHCI_TRB_PSCE = 34 +}; + +/* TRB completion codes */ +enum { + XHCI_TRB_CC_SUCCESS = 1, + XHCI_TRB_CC_TRB_ERR = 5, +}; + +/* DbC endpoint types */ +enum { + XHCI_EP_BULK_OUT = 2, + XHCI_EP_BULK_IN = 6, +}; + +/* DMA/MMIO structures */ +struct xhci_trb { + uint64_t params; + uint32_t status; + uint32_t ctrl; +}; + +/* log2(sizeof(struct xhci_trb)) */ +#define XHCI_TRB_SHIFT 4 + +struct xhci_erst_segment { + uint64_t base; + uint16_t size; + uint8_t rsvdz[6]; +}; + +/* Arbitrary length, must fit every DBC_STRING_* */ +#define MAX_STRING_LENGTH 16 + +#define DBC_STRINGS_COUNT 4 +#define DBC_STRING_LANGID "\x09\x04" +#define DBC_STRING_MANUFACTURER "Xen" +#define DBC_STRING_PRODUCT "Debug console" +#define DBC_STRING_SERIAL "0" + +#define XHCI_DT_STRING 3 + +struct xhci_string_descriptor { + uint8_t size; + uint8_t type; + uint16_t string[MAX_STRING_LENGTH]; +}; + +#define DBC_CTX_SIZE 16 +#define DBC_CTX_BYTES (DBC_CTX_SIZE * 4) + +struct xhci_dbc_ctx { + union { + uint32_t info[DBC_CTX_SIZE]; + struct { + uint64_t string0_ptr; + uint64_t manufacturer_ptr; + uint64_t product_ptr; + uint64_t serial_ptr; + uint8_t string0_size; + uint8_t manufacturer_size; + uint8_t product_size; + uint8_t serial_size; + }; + }; + uint32_t ep_out[DBC_CTX_SIZE]; + uint32_t ep_in[DBC_CTX_SIZE]; +}; + +struct dbc_reg { + uint32_t id; + uint32_t db; + uint32_t erstsz; + uint32_t rsvdz; + uint64_t erstba; + uint64_t erdp; + uint32_t ctrl; + uint32_t st; + uint32_t portsc; + uint32_t rsvdp; + uint64_t cp; + uint32_t ddi1; + uint32_t ddi2; +}; + +#define DBC_TRB_MAX_TFR (DBC_PAGE_SIZE << 4) +#define DBC_TRB_PER_PAGE (DBC_PAGE_SIZE / sizeof(struct xhci_trb)) + +/* Defines the size in bytes of TRB rings as 2^DBC_TRB_RING_ORDER * 4096 */ +#ifndef DBC_TRB_RING_ORDER +#define DBC_TRB_RING_ORDER 4 +#endif +#define DBC_TRB_RING_CAP (DBC_TRB_PER_PAGE * (1 << DBC_TRB_RING_ORDER)) +#define DBC_TRB_RING_BYTES (DBC_TRB_RING_CAP * sizeof(struct xhci_trb)) +#define DBC_TRB_RING_MASK (DBC_TRB_RING_BYTES - 1U) + +struct xhci_trb_ring { + struct xhci_trb *trb; /* Array of TRBs */ + uint32_t enq; /* The offset of the enqueue ptr */ + uint32_t deq; /* The offset of the dequeue ptr */ + uint8_t cyc; /* Cycle state toggled on each wrap-around */ + uint8_t db; /* Doorbell target */ + uint64_t dma; /* Physical address (for the device) */ +}; + +#define DBC_DB_OUT 0x0 +#define DBC_DB_IN 0x1 +#define DBC_DB_INVAL 0xFF + +/* Defines the size in bytes of work rings as 2^DBC_WORK_RING_ORDER * 4096 */ +#ifndef DBC_WORK_RING_ORDER +#define DBC_WORK_RING_ORDER 3 +#endif +#define DBC_WORK_RING_CAP (DBC_PAGE_SIZE * (1 << DBC_WORK_RING_ORDER)) +#define DBC_WORK_RING_BYTES DBC_WORK_RING_CAP + +#if DBC_WORK_RING_CAP > DBC_TRB_MAX_TFR +#error "DBC_WORK_RING_ORDER must be at most 4" +#endif + +struct dbc_work_ring { + uint8_t *buf; + uint32_t enq; + uint32_t deq; + uint64_t dma; +}; + +struct dbc { + struct dbc_reg __iomem *dbc_reg; + struct xhci_dbc_ctx *dbc_ctx; + struct xhci_erst_segment *dbc_erst; + struct xhci_trb_ring dbc_ering; + struct xhci_trb_ring dbc_oring; + struct xhci_trb_ring dbc_iring; + struct dbc_work_ring dbc_owork; + struct xhci_string_descriptor *dbc_str; + + pci_sbdf_t sbdf; + uint64_t xhc_mmio_phys; + uint64_t xhc_dbc_offset; + void __iomem *xhc_mmio; + + bool open; +}; + +static void *dbc_sys_map_xhc(uint64_t phys, size_t size) +{ + size_t i; + + if ( size != MAX_XHCI_PAGES * DBC_PAGE_SIZE ) + return NULL; + + for ( i = FIX_XHCI_END; i >= FIX_XHCI_BEGIN; i-- ) + { + set_fixmap_nocache(i, phys); + phys += DBC_PAGE_SIZE; + } + + /* + * The fixmap grows downward, so the lowest virt is + * at the highest index + */ + return fix_to_virt(FIX_XHCI_END); +} + +static bool __init dbc_init_xhc(struct dbc *dbc) +{ + uint32_t bar0; + uint64_t bar1; + uint64_t bar_size; + uint64_t devfn; + uint16_t cmd; + size_t xhc_mmio_size; + + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so far + * are part of the chipset and are on bus 0. + */ + for ( devfn = 0; devfn < 256; devfn++ ) + { + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); + uint8_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr == 0 || hdr == 0x80 ) + { + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == DBC_XHC_CLASSC ) + { + dbc->sbdf = sbdf; + break; + } + } + } + + if ( !dbc->sbdf.sbdf ) + { + dbc_error("Compatible xHC not found on bus 0\n"); + return false; + } + + /* ...we found it, so parse the BAR and map the registers */ + bar0 = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar1 = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1); + + /* IO BARs not allowed; BAR must be 64-bit */ + if ( (bar0 & PCI_BASE_ADDRESS_SPACE) != PCI_BASE_ADDRESS_SPACE_MEMORY || + (bar0 & PCI_BASE_ADDRESS_MEM_TYPE_MASK) != PCI_BASE_ADDRESS_MEM_TYPE_64 ) + return false; + + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd & ~PCI_COMMAND_MEMORY); + + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, 0xFFFFFFFF); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, 0xFFFFFFFF); + bar_size = pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_0); + bar_size |= (uint64_t)pci_conf_read32(dbc->sbdf, PCI_BASE_ADDRESS_1) << 32; + xhc_mmio_size = ~(bar_size & PCI_BASE_ADDRESS_MEM_MASK) + 1; + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_0, bar0); + pci_conf_write32(dbc->sbdf, PCI_BASE_ADDRESS_1, bar1); + + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + + dbc->xhc_mmio_phys = (bar0 & PCI_BASE_ADDRESS_MEM_MASK) | (bar1 << 32); + dbc->xhc_mmio = dbc_sys_map_xhc(dbc->xhc_mmio_phys, xhc_mmio_size); + + if ( dbc->xhc_mmio == NULL ) + return false; + + if ( (cmd & PCI_COMMAND_MEMORY) == 0 ) + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MEMORY); + + return true; +} + +/** + * The first register of the debug capability is found by traversing the + * host controller's capability list (xcap) until a capability + * with ID = 0xA is found. The xHCI capability list begins at address + * mmio + (HCCPARAMS1[31:16] << 2). + */ +static struct dbc_reg __iomem *xhci_find_dbc(struct dbc *dbc) +{ + uint32_t *xcap; + uint32_t xcap_val; + uint32_t next; + uint32_t id = 0; + uint8_t *mmio = (uint8_t *)dbc->xhc_mmio; + uint32_t *hccp1 = (uint32_t *)(mmio + 0x10); + const uint32_t DBC_ID = 0xA; + int ttl = 48; + + xcap = (uint32_t *)dbc->xhc_mmio; + /* + * This is initially an offset to the first capability. All the offsets + * (both in HCCP1 and then next capability pointer are dword-based. + */ + next = (readl(hccp1) & 0xFFFF0000) >> 16; + + while ( id != DBC_ID && next && ttl-- ) + { + xcap += next; + xcap_val = readl(xcap); + id = xcap_val & 0xFF; + next = (xcap_val & 0xFF00) >> 8; + } + + if ( id != DBC_ID ) + return NULL; + + dbc->xhc_dbc_offset = (uint64_t)xcap - (uint64_t)mmio; + return (struct dbc_reg __iomem *)xcap; +} + +/** + * Fields with the same interpretation for every TRB type (section 4.11.1). + * These are the fields defined in the TRB template, minus the ENT bit. That + * bit is the toggle cycle bit in link TRBs, so it shouldn't be in the + * template. + */ +static uint32_t xhci_trb_cyc(const struct xhci_trb *trb) +{ + return trb->ctrl & 0x1; +} + +static uint32_t xhci_trb_type(const struct xhci_trb *trb) +{ + return (trb->ctrl & 0xFC00) >> 10; +} + +static void xhci_trb_set_cyc(struct xhci_trb *trb, uint32_t c) +{ + trb->ctrl &= ~0x1U; + trb->ctrl |= c; +} + +static void xhci_trb_set_type(struct xhci_trb *trb, uint32_t t) +{ + trb->ctrl &= ~0xFC00U; + trb->ctrl |= (t << 10); +} + +/* Fields for normal TRBs */ +static void xhci_trb_norm_set_buf(struct xhci_trb *trb, uint64_t addr) +{ + trb->params = addr; +} + +static void xhci_trb_norm_set_len(struct xhci_trb *trb, uint32_t len) +{ + trb->status &= ~0x1FFFFU; + trb->status |= len; +} + +static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) +{ + trb->ctrl |= 0x20; +} + +/** + * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event + * TRBs are read-only from software + */ +static uint64_t xhci_trb_tfre_ptr(const struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) +{ + return trb->status >> 24; +} + +/* Fields for link TRBs (section 6.4.4.1) */ +static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) +{ + trb->params = rsp; +} + +static void xhci_trb_link_set_tc(struct xhci_trb *trb) +{ + trb->ctrl |= 0x2; +} + +static void xhci_trb_ring_init(const struct dbc *dbc, + struct xhci_trb_ring *ring, int producer, + int doorbell) +{ + memset(ring->trb, 0, DBC_TRB_RING_CAP * sizeof(ring->trb[0])); + + ring->enq = 0; + ring->deq = 0; + ring->cyc = 1; + ring->db = (uint8_t)doorbell; + ring->dma = virt_to_maddr(ring->trb); + + /* + * Producer implies transfer ring, so we have to place a + * link TRB at the end that points back to trb[0] + */ + if ( producer ) + { + struct xhci_trb *trb = &ring->trb[DBC_TRB_RING_CAP - 1]; + xhci_trb_set_type(trb, XHCI_TRB_LINK); + xhci_trb_link_set_tc(trb); + xhci_trb_link_set_rsp(trb, virt_to_maddr(ring->trb)); + } +} + +static int xhci_trb_ring_full(const struct xhci_trb_ring *ring) +{ + return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) == ring->deq; +} + +static int dbc_work_ring_full(const struct dbc_work_ring *ring) +{ + return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) == ring->deq; +} + +static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return DBC_WORK_RING_CAP - ring->deq + ring->enq; +} + +static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, + uint64_t dma, uint64_t len) +{ + struct xhci_trb trb; + + if ( ring->enq == DBC_TRB_RING_CAP - 1 ) + { + /* + * We have to make sure the xHC processes the link TRB in order + * for wrap-around to work properly. We do this by marking the + * xHC as owner of the link TRB by setting the TRB's cycle bit + * (just like with normal TRBs). + */ + struct xhci_trb *link = &ring->trb[ring->enq]; + xhci_trb_set_cyc(link, ring->cyc); + + ring->enq = 0; + ring->cyc ^= 1; + } + + trb.params = 0; + trb.status = 0; + trb.ctrl = 0; + + xhci_trb_set_type(&trb, XHCI_TRB_NORM); + xhci_trb_set_cyc(&trb, ring->cyc); + + xhci_trb_norm_set_buf(&trb, dma); + xhci_trb_norm_set_len(&trb, (uint32_t)len); + xhci_trb_norm_set_ioc(&trb); + + ring->trb[ring->enq++] = trb; + cache_flush(&ring->trb[ring->enq - 1], sizeof(trb)); +} + +static int64_t dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, + const char *buf, unsigned int len) +{ + unsigned int i = 0; + unsigned int end, start = ring->enq; + + while ( !dbc_work_ring_full(ring) && i < len ) + { + ring->buf[ring->enq] = buf[i++]; + ring->enq = (ring->enq + 1) & (DBC_WORK_RING_CAP - 1); + } + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); + else if ( i > 0 ) + { + cache_flush(&ring->buf[start], DBC_WORK_RING_CAP - start); + cache_flush(&ring->buf[0], end); + } + + return i; +} + +/* + * Note that if IN transfer support is added, then this + * will need to be changed; it assumes an OUT transfer ring only + */ +static void dbc_pop_events(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + struct xhci_trb_ring *er = &dbc->dbc_ering; + struct xhci_trb_ring *tr = &dbc->dbc_oring; + struct xhci_trb *event = &er->trb[er->deq]; + uint64_t erdp = readq(®->erdp); + uint32_t portsc; + uint64_t event_ptr; + unsigned int trb_idx; + + BUILD_BUG_ON((1 << XHCI_TRB_SHIFT) != sizeof(struct xhci_trb)); + + rmb(); + + while ( xhci_trb_cyc(event) == er->cyc ) + { + switch (xhci_trb_type(event)) + { + case XHCI_TRB_TFRE: + event_ptr = xhci_trb_tfre_ptr(event); + /* + * trb_idx is just completed TRB, so set the dequeue ptr one + * position further. + */ + if ( event_ptr - tr->dma < DBC_TRB_RING_BYTES ) + { + trb_idx = (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; + tr->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } + else + dbc_alert("event: TRB 0x%lx not found in any ring\n", + event_ptr); + break; + case XHCI_TRB_PSCE: + portsc = readl(®->portsc); + portsc |= DBC_PSC_ACK_MASK & portsc; + writel(portsc, ®->portsc); + break; + default: + break; + } + + er->cyc = (er->deq == DBC_TRB_RING_CAP - 1) ? er->cyc ^ 1 : er->cyc; + er->deq = (er->deq + 1) & (DBC_TRB_RING_CAP - 1); + event = &er->trb[er->deq]; + } + + erdp = er->dma + (er->deq << XHCI_TRB_SHIFT); + wmb(); + writeq(erdp, ®->erdp); +} + +/** + * dbc_init_ep + * + * Initializes the endpoint as specified in sections 7.6.3.2 and 7.6.9.2. + * Each endpoint is Bulk, so the MaxPStreams, LSA, HID, CErr, FE, + * Interval, Mult, and Max ESIT Payload fields are all 0. + * + * Max packet size: 1024 + * Max burst size: debug mbs (from dbc_reg->ctrl register) + * EP type: 2 for OUT bulk, 6 for IN bulk + * TR dequeue ptr: physical base address of transfer ring + * Avg TRB length: software defined (see 4.14.1.1 for suggested defaults) + */ +static void dbc_init_ep(uint32_t *ep, uint64_t mbs, uint32_t type, + uint64_t ring_dma) +{ + memset(ep, 0, DBC_CTX_BYTES); + + ep[1] = (1024 << 16) | ((uint32_t)mbs << 8) | (type << 3); + ep[2] = (ring_dma & 0xFFFFFFFF) | 1; + ep[3] = ring_dma >> 32; + ep[4] = 3 * 1024; +} + +static void dbc_init_string_single(struct xhci_string_descriptor *string, + char *ascii_str, + uint64_t *str_ptr, + uint8_t *str_size_ptr) +{ + size_t i, len = strlen(ascii_str); + + string->size = offsetof(typeof(*string), string) + len * 2; + string->type = XHCI_DT_STRING; + /* ASCII to UTF16 conversion */ + for (i = 0; i < len; i++) + string->string[i] = ascii_str[i]; + *str_ptr = virt_to_maddr(string); + *str_size_ptr = string->size; +} + +/* Initialize the DbC info with USB string descriptor addresses */ +static void dbc_init_strings(struct dbc *dbc, uint32_t *info) +{ + BUILD_BUG_ON(sizeof(DBC_STRING_LANGID) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_MANUFACTURER) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_PRODUCT) > MAX_STRING_LENGTH); + BUILD_BUG_ON(sizeof(DBC_STRING_SERIAL) > MAX_STRING_LENGTH); + + dbc_init_string_single(&dbc->dbc_str[0], DBC_STRING_LANGID, + &dbc->dbc_ctx->string0_ptr, + &dbc->dbc_ctx->string0_size); + dbc_init_string_single(&dbc->dbc_str[1], DBC_STRING_MANUFACTURER, + &dbc->dbc_ctx->manufacturer_ptr, + &dbc->dbc_ctx->manufacturer_size); + dbc_init_string_single(&dbc->dbc_str[2], DBC_STRING_PRODUCT, + &dbc->dbc_ctx->product_ptr, + &dbc->dbc_ctx->product_size); + dbc_init_string_single(&dbc->dbc_str[3], DBC_STRING_SERIAL, + &dbc->dbc_ctx->serial_ptr, + &dbc->dbc_ctx->serial_size); +} + +static void dbc_enable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + + wmb(); + writel(readl(®->ctrl) | (1U << DBC_CTRL_DCE), ®->ctrl); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCE)) == 0 ) + cpu_relax(); + + wmb(); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + + while ( (readl(®->ctrl) & (1U << DBC_CTRL_DCR)) == 0 ) + cpu_relax(); +} + +static void dbc_disable_dbc(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + + writel(readl(®->portsc) & ~(1U << DBC_PSC_PED), ®->portsc); + wmb(); + writel(readl(®->ctrl) & ~(1U << DBC_CTRL_DCE), ®->ctrl); + + while ( readl(®->ctrl) & (1U << DBC_CTRL_DCE) ) + cpu_relax(); +} + +static int dbc_init_dbc(struct dbc *dbc) +{ + uint64_t erdp = 0; + uint64_t mbs = 0; + uint16_t cmd; + struct dbc_reg *reg = xhci_find_dbc(dbc); + + if ( !reg ) + return 0; + + dbc->dbc_reg = reg; + dbc_disable_dbc(dbc); + + xhci_trb_ring_init(dbc, &dbc->dbc_ering, 0, DBC_DB_INVAL); + xhci_trb_ring_init(dbc, &dbc->dbc_oring, 1, DBC_DB_OUT); + xhci_trb_ring_init(dbc, &dbc->dbc_iring, 1, DBC_DB_IN); + + erdp = virt_to_maddr(dbc->dbc_ering.trb); + if ( !erdp ) + return 0; + + memset(dbc->dbc_erst, 0, sizeof(*dbc->dbc_erst)); + dbc->dbc_erst->base = erdp; + dbc->dbc_erst->size = DBC_TRB_RING_CAP; + + mbs = (readl(®->ctrl) & 0xFF0000) >> 16; + + memset(dbc->dbc_ctx, 0, sizeof(*dbc->dbc_ctx)); + dbc_init_strings(dbc, dbc->dbc_ctx->info); + dbc_init_ep(dbc->dbc_ctx->ep_out, mbs, XHCI_EP_BULK_OUT, + dbc->dbc_oring.dma); + dbc_init_ep(dbc->dbc_ctx->ep_in, mbs, XHCI_EP_BULK_IN, + dbc->dbc_iring.dma); + + writel(1, ®->erstsz); + writeq(virt_to_maddr(dbc->dbc_erst), ®->erstba); + writeq(erdp, ®->erdp); + writeq(virt_to_maddr(dbc->dbc_ctx), ®->cp); + writel((DBC_DBC_VENDOR << 16) | DBC_DBC_PROTOCOL, ®->ddi1); + writel(DBC_DBC_PRODUCT, ®->ddi2); + + cache_flush(dbc->dbc_ctx, sizeof(*dbc->dbc_ctx)); + cache_flush(dbc->dbc_erst, sizeof(*dbc->dbc_erst)); + cache_flush(dbc->dbc_ering.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_oring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_iring.trb, DBC_TRB_RING_BYTES); + cache_flush(dbc->dbc_owork.buf, DBC_WORK_RING_BYTES); + + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd | PCI_COMMAND_MASTER); + + return 1; +} + +static void dbc_init_work_ring(struct dbc *dbc, + struct dbc_work_ring *wrk) +{ + wrk->enq = 0; + wrk->deq = 0; + wrk->dma = virt_to_maddr(wrk->buf); +} + +/** + * Initialize the DbC and enable it for transfers. First map in the DbC + * registers from the host controller's MMIO region. Then allocate and map + * DMA for the event and transfer rings. Finally, enable the DbC for + * the host to enumerate. On success, the DbC is ready to send packets. + * + * @param dbc the dbc to open (!= NULL) + * @return true iff dbc_open succeeded + */ +static bool __init dbc_open(struct dbc *dbc) +{ + if ( !dbc ) + return false; + + if ( !dbc_init_xhc(dbc) ) + return false; + + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + dbc->open = true; + + return true; +} + +/* + * Ensure DbC is still running, handle events, and possibly re-enable if cable + * was re-plugged. Returns true if DbC is operational. + */ +static bool dbc_ensure_running(struct dbc *dbc) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t ctrl; + uint32_t cmd; + + dbc_pop_events(dbc); + + ctrl = readl(®->ctrl); + if ( !(ctrl & (1U << DBC_CTRL_DCR)) ) + { + return false; + } + + if ( ctrl & (1U << DBC_CTRL_DRC) ) + { + writel(ctrl | (1U << DBC_CTRL_DRC), ®->ctrl); + writel(readl(®->portsc) | (1U << DBC_PSC_PED), ®->portsc); + wmb(); + } + + return true; +} + +/** + * Commit the pending transfer TRBs to the DbC. This notifies + * the DbC of any previously-queued data on the work ring and + * rings the doorbell. + * + * @param dbc the dbc to flush + * @param trb the ring containing the TRBs to transfer + * @param wrk the work ring containing data to be flushed + */ +static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t db = (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + if ( xhci_trb_ring_full(trb) ) + return; + + if ( wrk->enq == wrk->deq ) + return; + else if ( wrk->enq > wrk->deq ) + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, wrk->enq - wrk->deq); + wrk->deq = wrk->enq; + } + else + { + dbc_push_trb(dbc, trb, wrk->dma + wrk->deq, + DBC_WORK_RING_CAP - wrk->deq); + wrk->deq = 0; + if ( wrk->enq > 0 && !xhci_trb_ring_full(trb) ) + { + dbc_push_trb(dbc, trb, wrk->dma, wrk->enq); + wrk->deq = wrk->enq; + } + } + + wmb(); + writel(db, ®->db); +} + +/** + * Queue a single character to the DbC. A transfer TRB will be created + * if the character is a newline and the DbC will be notified that data is + * available for writing to the debug host. + * + * @param dbc the dbc to write to + * @param c the character to write + * @return the number of bytes written + */ +static int64_t dbc_putc(struct dbc *dbc, char c) +{ + if ( !dbc_push_work(dbc, &dbc->dbc_owork, &c, 1) ) + return 0; + + if ( !dbc_ensure_running(dbc) ) + return 1; + + if ( c == '\n' ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + return 1; +} + +struct dbc_uart { + struct dbc dbc; + struct timer timer; + spinlock_t *lock; +}; + +static struct dbc_uart dbc_uart; + +static void cf_check dbc_uart_poll(void *data) +{ + struct serial_port *port = data; + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + unsigned long flags = 0; + + if ( spin_trylock_irqsave(&port->tx_lock, flags) ) + { + if ( dbc_ensure_running(dbc) ) + { + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + dbc_enqueue_in(dbc, &dbc->dbc_iring, &dbc->dbc_iwork); + } + spin_unlock_irqrestore(&port->tx_lock, flags); + } + + serial_tx_interrupt(port, guest_cpu_user_regs()); + set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); +} + +static void __init cf_check dbc_uart_init_preirq(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + uart->lock = &port->tx_lock; +} + +static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + + serial_async_transmit(port); + init_timer(&uart->timer, dbc_uart_poll, port, 0); + set_timer(&uart->timer, NOW() + MILLISECS(1)); + + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); +} + +static int cf_check dbc_uart_tx_ready(struct serial_port *port) +{ + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + return DBC_WORK_RING_CAP - dbc_work_ring_size(&dbc->dbc_owork); +} + +static void cf_check dbc_uart_putc(struct serial_port *port, char c) +{ + struct dbc_uart *uart = port->uart; + dbc_putc(&uart->dbc, c); +} + +static void cf_check dbc_uart_flush(struct serial_port *port) +{ + s_time_t goal; + struct dbc_uart *uart = port->uart; + struct dbc *dbc = &uart->dbc; + + if ( dbc_ensure_running(dbc) ) + dbc_flush(dbc, &dbc->dbc_oring, &dbc->dbc_owork); + + goal = NOW() + MICROSECS(DBC_POLL_INTERVAL); + if ( uart->timer.expires > goal ) + set_timer(&uart->timer, goal); +} + +static struct uart_driver dbc_uart_driver = { + .init_preirq = dbc_uart_init_preirq, + .init_postirq = dbc_uart_init_postirq, + .tx_ready = dbc_uart_tx_ready, + .putc = dbc_uart_putc, + .flush = dbc_uart_flush, +}; + +static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; +static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; +static struct xhci_erst_segment erst __aligned(64); +static struct xhci_dbc_ctx ctx __aligned(64); +static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); +static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +static char __initdata opt_dbgp[30]; + +string_param("dbgp", opt_dbgp); + +void __init xhci_dbc_uart_init(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + if ( strncmp(opt_dbgp, "xhci", 4) ) + return; + + memset(dbc, 0, sizeof(*dbc)); + + dbc->dbc_ctx = &ctx; + dbc->dbc_erst = &erst; + dbc->dbc_ering.trb = evt_trb; + dbc->dbc_oring.trb = out_trb; + dbc->dbc_iring.trb = in_trb; + dbc->dbc_owork.buf = out_wrk_buf; + dbc->dbc_str = str_buf; + + if ( dbc_open(dbc) ) + serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); +} + +#ifdef DBC_DEBUG +static void dbc_dump(struct dbc *dbc) +{ + struct dbc_reg *r = dbc->dbc_reg; + + dbc_debug("XHCI DBC DUMP:\n"); + dbc_debug(" ctrl: 0x%x stat: 0x%x psc: 0x%x\n", + readl(&r->ctrl), readl(&r->st), readl(&r->portsc)); + dbc_debug(" id: 0x%x, db: 0x%x\n", + readl(&r->id), readl(&r->db)); + dbc_debug(" erstsz: %u, erstba: 0x%lx\n", + readl(&r->erstsz), readq(&r->erstba)); + dbc_debug(" erdp: 0x%lx, cp: 0x%lx\n", + readq(&r->erdp), readq(&r->cp)); + dbc_debug(" ddi1: 0x%x, ddi2: 0x%x\n", + readl(&r->ddi1), readl(&r->ddi2)); + dbc_debug(" erstba == virt_to_dma(erst): %d\n", + readq(&r->erstba) == virt_to_maddr(dbc->dbc_erst)); + dbc_debug(" erdp == virt_to_dma(erst[0].base): %d\n", + readq(&r->erdp) == dbc->dbc_erst[0].base); + dbc_debug(" cp == virt_to_dma(ctx): %d\n", + readq(&r->cp) == virt_to_maddr(dbc->dbc_ctx)); +} + +static void dbc_uart_dump(void) +{ + struct dbc_uart *uart = &dbc_uart; + struct dbc *dbc = &uart->dbc; + + dbc_dump(dbc); +} +#endif diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 6548f0b0a9cf..181e026967bc 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -171,6 +171,11 @@ struct ns16550_defaults { }; void ns16550_init(int index, struct ns16550_defaults *defaults); void ehci_dbgp_init(void); +#ifdef CONFIG_XHCI +void xhci_dbc_uart_init(void); +#else +static void inline xhci_dbc_uart_init(void) {}; +#endif void arm_uart_init(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374934.607148 (Exim 4.92) (envelope-from ) id 1oGBAQ-0003PD-QS; Tue, 26 Jul 2022 03:23:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374934.607148; Tue, 26 Jul 2022 03:23:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAQ-0003P6-NU; Tue, 26 Jul 2022 03:23:30 +0000 Received: by outflank-mailman (input) for mailman id 374934; Tue, 26 Jul 2022 03:23:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAP-0003P0-Hv for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:29 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 50bfcbde-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:28 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9C45D5C00C4; Mon, 25 Jul 2022 23:23:27 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 25 Jul 2022 23:23:27 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:25 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 50bfcbde-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t= 1658805807; x=1658892207; bh=k9jiFqn51KOOI3U/+3qfkMWa6aFW6+VVMrP BEdhS56M=; b=vZ/QRA655qUHdCeHVhbIWlYnF8sVQCFTkJ+hbLLCueP1Baa+eT4 mhxPEX/IxsbTvyBzChMj9Zte3wswbYu2zn/cNuWhFIgPkNvzUWn3uZ+qHFWg8ZC+ HxWYU/S3n0U3gpwvhD+5tXdPar4bmnb+rastZ1RJacfQV9QhO7qpoQp3s1DcpAS6 LgG5P3E2pUJfIWaIUig8A0a2V0RmaHs3EKGJV8hD0gI9XzPLAawbXd1/MA/XS4Dg eaYeZ96UiI3ASUaA2xRq0A0ai5Bkx0WxUQmktBlJ4uN0h5JrV9KO3IzduB4UUA9O 5/3ExKBtc7I00L9FkxWjcKdqVPgwAFQ1yTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1658805807; x=1658892207; bh=k9jiFqn51KOOI 3U/+3qfkMWa6aFW6+VVMrPBEdhS56M=; b=J5x6/abGkbWhobYAAN2psLNxLWKEP oavtbI80Qta4m4ukptTuUuVTX/6BYklorcfYFkV86/+HzgnUYe4XrwfjhrbmpChs TPLsDKtXjFKfdfT9bG5OHS512bAIPTFLJtHi9kZX45GUbTyezB2qKT1mhpu5b9sU By9hDrgwk92/RI6AGFCsBOHAAhEIW2iZXtqvat4T8dEGC3BzOsmnF3v4Hyj9THlu +agFvjMj1xQo//7C0HeJ40YC9xa6DtWMLdxZpCYRF89Qp2seLA1wv0d5UVbYl0zU J7jNqMhJG8N4cOvS3rJei+EYrrtOUOjErKEEVDDTK2i8wEnorygIun5Iw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeforghrvghk ucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesihhnvh hishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpeefgffg geevhffggfetfefhffeuvefhvdevkeehkedttddtgeefkeduheevffduleenucffohhmrg hinhepghhithhhuhgsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghm pehmrghilhhfrhhomhepmhgrrhhmrghrvghksehinhhvihhsihgslhgvthhhihhnghhslh grsgdrtghomh X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Paul Durrant , Kevin Tian , Connor Davis Subject: [PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability Date: Tue, 26 Jul 2022 05:23:05 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is integration of https://github.com/connojd/xue into mainline Xen. This patch series includes several patches that I made in the process, some are very loosely related. The driver developed by Connor supports console via USB3 debug capability. The capability is designed to operate mostly independently of normal XHCI driver, so this patch series allows dom0 to drive standard USB3 controller part, while Xen uses DbC for console output. Changes since RFC: - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction - adjust for Xen code style - build for x86 only - drop patch hidding the device from dom0 Changes since v1: - drop ehci patch - already applied - adjust for review comments from Jan (see changelogs in individual patches) Changes since v2: - add runtime option to share (or not) the controller with dom0 or other domains - add RX support - several smaller changes according to review comments Cc: Andrew Cooper Cc: George Dunlap Cc: Jan Beulich Cc: Julien Grall Cc: Stefano Stabellini Cc: Wei Liu Cc: "Roger Pau Monné" Cc: Paul Durrant Cc: Kevin Tian Cc: Connor Davis Connor Davis (1): drivers/char: Add support for USB3 DbC debugger Marek Marczykowski-Górecki (9): drivers/char: reset XHCI ports when initializing dbc drivers/char: add support for selecting specific xhci console: support multiple serial console simultaneously IOMMU: add common API for device reserved memory IOMMU/VT-d: wire common device reserved memory API IOMMU/AMD: wire common device reserved memory API drivers/char: mark DMA buffers as reserved for the XHCI drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC driver/char: add RX support to the XHCI driver docs/misc/xen-command-line.pandoc | 19 +- xen/arch/x86/include/asm/fixmap.h | 4 +- xen/arch/x86/setup.c | 1 +- xen/drivers/char/Kconfig | 20 +- xen/drivers/char/Makefile | 1 +- xen/drivers/char/console.c | 97 +- xen/drivers/char/xhci-dbc.c | 1367 +++++++++++++++++++++++- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +- xen/drivers/passthrough/iommu.c | 45 +- xen/drivers/passthrough/vtd/dmar.c | 201 +-- xen/include/xen/iommu.h | 13 +- xen/include/xen/serial.h | 6 +- 12 files changed, 1690 insertions(+), 105 deletions(-) create mode 100644 xen/drivers/char/xhci-dbc.c base-commit: 4df2e99d731402da48afb19dc970ccab5a0814d6 -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374937.607181 (Exim 4.92) (envelope-from ) id 1oGBAW-0004Dn-P5; Tue, 26 Jul 2022 03:23:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374937.607181; Tue, 26 Jul 2022 03:23:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-0004D1-JO; Tue, 26 Jul 2022 03:23:36 +0000 Received: by outflank-mailman (input) for mailman id 374937; Tue, 26 Jul 2022 03:23:35 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAU-0003P0-SU for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:34 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 53c69a50-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:33 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B00DB5C00D2; Mon, 25 Jul 2022 23:23:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 25 Jul 2022 23:23:32 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:31 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53c69a50-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805812; x=1658892212; bh=3+Myjyd1Ql jUjc3rIyJbwALSLpFyz/2kcKDHAc8UTjU=; b=jUaEBIvUae6flJleBjXEEGUdFe JAgTIwisnWqcQvdsZCoYNpqROwJ6mMBWsWMe07I2VpM3XHBPiUxUIJya53PcsT3s dEFEjZccdU5uplmijE33r65KMhJmh85GbQ7PsF6DW+oTu9BKCka0i2BmSb3z/WRC TztkyKNO15+yxHt+btr7BlQMjhaaltCO6VuxDo/Tf3Dro6cJsBVib7Gpx+ZS/0ev 6HMYyBjtnhhvFCUAUFBzbw5oTYn9uX+iKsasLWIvLMcKGCfecE8iTSi/PEdapsT1 2j+acUrTBpVRrNBdn7KuXUniK0XxIZcMyx17L3ST1PGQH0ZmZqjh8D2M+bAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805812; x= 1658892212; bh=3+Myjyd1QljUjc3rIyJbwALSLpFyz/2kcKDHAc8UTjU=; b=z 2RPsAdyciG6IBHebVkU63AHlkXtawGFyZoTcWMYv8EJGOuL3THT343Ytxu1zA17s geCjuVORzo0Fg65LckTxdbsyMkax3NEwyNPxwZOn1ff9E7lnSN/8X6xhJPTE2qZD AN9UIIuamYi++MKNOgNrJ0rgTlJ5fMFCW++ViHRPlWWFhHq5ptBymwDJmhBcC0Wt MY8e7TeqieqQArEVxbp56FeRcbe81DGyn+Ht9/pYAv2e0yHc5FmTDBSDKPmkHbd9 YTh7TZ1PLBH9orceO6vcyzWW/fEToARRhaJjZLmFHm8kX+qBUz6LZqw/9wa4PLlp XsJ1G4FgXrsfMI2mWI/8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 03/10] drivers/char: add support for selecting specific xhci Date: Tue, 26 Jul 2022 05:23:08 +0200 Message-Id: <97e54ccf5f9a21cf1226a1e9de6aae8dc09d2406.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Handle parameters similar to dbgp=ehci. Implement this by not resettting dbc->sbdf again in dbc_init_xhc(), but using a value found there if non-zero. Additionally, add xue->xhc_num to select n-th controller. Signed-off-by: Marek Marczykowski-Górecki Reviewed-by: Jan Beulich --- Changes in v3: - adjust for xhci-dbc rename - drop redundant check in parsing dbgp= option Changes in v2: - unsigned int xhc_num - code style --- docs/misc/xen-command-line.pandoc | 2 +- xen/drivers/char/xhci-dbc.c | 54 ++++++++++++++++++++++++-------- 2 files changed, 43 insertions(+), 13 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index f936283cd187..d594bd5c7436 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -721,7 +721,7 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` -> `= xhci` +> `= xhci[ | @pci:. ]` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 53c39eedd4a6..11026d3b71f0 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -243,6 +243,7 @@ struct dbc { void __iomem *xhc_mmio; bool open; + unsigned int xhc_num; /* look for n-th xhc */ }; static void *dbc_sys_map_xhc(uint64_t phys, size_t size) @@ -274,24 +275,37 @@ static bool __init dbc_init_xhc(struct dbc *dbc) uint16_t cmd; size_t xhc_mmio_size; - /* - * Search PCI bus 0 for the xHC. All the host controllers supported so far - * are part of the chipset and are on bus 0. - */ - for ( devfn = 0; devfn < 256; devfn++ ) + if ( dbc->sbdf.sbdf == 0 ) { - pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); - uint8_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); - - if ( hdr == 0 || hdr == 0x80 ) + /* + * Search PCI bus 0 for the xHC. All the host controllers supported so + * far are part of the chipset and are on bus 0. + */ + for ( devfn = 0; devfn < 256; devfn++ ) { - if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == DBC_XHC_CLASSC ) + pci_sbdf_t sbdf = PCI_SBDF(0, 0, devfn); + uint8_t hdr = pci_conf_read8(sbdf, PCI_HEADER_TYPE); + + if ( hdr == 0 || hdr == 0x80 ) { - dbc->sbdf = sbdf; - break; + if ( (pci_conf_read32(sbdf, PCI_CLASS_REVISION) >> 8) == + DBC_XHC_CLASSC ) + { + if ( dbc->xhc_num-- ) + continue; + dbc->sbdf = sbdf; + break; + } } } } + else + { + /* Verify if selected device is really xHC */ + if ( (pci_conf_read32(dbc->sbdf, PCI_CLASS_REVISION) >> 8) != + DBC_XHC_CLASSC ) + dbc->sbdf.sbdf = 0; + } if ( !dbc->sbdf.sbdf ) { @@ -1047,12 +1061,28 @@ void __init xhci_dbc_uart_init(void) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; + const char *e; if ( strncmp(opt_dbgp, "xhci", 4) ) return; memset(dbc, 0, sizeof(*dbc)); + if ( isdigit(opt_dbgp[4]) ) + { + dbc->xhc_num = simple_strtoul(opt_dbgp + 4, &e, 10); + } + else if ( strncmp(opt_dbgp + 4, "@pci", 4) == 0 ) + { + unsigned int bus, slot, func; + + e = parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); + if ( !e || *e ) + return; + + dbc->sbdf = PCI_SBDF(0, bus, slot, func); + } + dbc->dbc_ctx = &ctx; dbc->dbc_erst = &erst; dbc->dbc_ering.trb = evt_trb; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374938.607187 (Exim 4.92) (envelope-from ) id 1oGBAX-0004Hp-5P; Tue, 26 Jul 2022 03:23:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374938.607187; Tue, 26 Jul 2022 03:23:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-0004Fq-TN; Tue, 26 Jul 2022 03:23:36 +0000 Received: by outflank-mailman (input) for mailman id 374938; Tue, 26 Jul 2022 03:23:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAW-000459-BF for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:36 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 54a90892-0c92-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 05:23:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 38A6F5C00C4; Mon, 25 Jul 2022 23:23:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 25 Jul 2022 23:23:34 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:32 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 54a90892-0c92-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805814; x=1658892214; bh=hSsEZHy6kJ LcmqWZuPa/umq2lr+G/hdZU1gW2QDjIRI=; b=hIFn0DIgOSL3dauKE5PXTJegSt GlpZO47OaT7GxSTdX0cGtkv2FrVfxKey4WVaAAOY4bGZ39yt4fH1TLVjRkKXNnCx XoMAhkufI4fVrw6vdwug8YOoWm/cuVdKLHtN1iHHqW9MHr6t8CeRYH9nVoMfd6s8 V7TiIS8GepYCkUUQLA+voybRNnIBcAQuy46XpPh9UA4HsJjmeJpiT8eu10PO+FeP 6n9OtNVi2N3FcgY42baDW0rWAXngKInIF2Z/eJDpnRQS9azDFC7z2L5DaQNFyIa/ sRqHJWx7RiqKZt8tJdUY7lSm8ujXgzZJMf2mocgzZLZAImRoKDUkFN5+r9+g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805814; x= 1658892214; bh=hSsEZHy6kJLcmqWZuPa/umq2lr+G/hdZU1gW2QDjIRI=; b=O rxHoquYpjEzNSsjsYn2n1ZBx9j6TSD60CNrjkV9STnEzNXC98XoDNZHvyNmO2TB2 +dQWEg57TvAtL4ughDcqq3R/EOnK8ZNSPZcV9l42T5bbl9kpx9PjuiS9CDn8fbzE u+NDcA2nZgoWJOAhf6+oZL2T0n4FeGx9rfK1ULygvPrOUPOF9P39D2/zYNuaA0W1 FfdtVDSYDZ/+rf2OzEkLaXRp3k/aXN5xyGuLY/2UcqBgxjZs1neE0lTlWBMP1VBm FoP1zBXGihE5b0mKtbAii0zaNXzcUXw4Ob01p0q3xzvhyVtN/pxGIhn4tDZhjFD6 MRDRbGGY5Pmgpf3C3o2Nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 04/10] console: support multiple serial console simultaneously Date: Tue, 26 Jul 2022 05:23:09 +0200 Message-Id: <14411aa674b61d22d9626a3455206454793b6a37.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Previously only one serial console was supported at the same time. Using console=com1,dbgp,vga silently ignored all but last serial console (in this case: only dbgp and vga were active). Fix this by storing not a single sercon_handle, but an array of them, up to MAX_SERCONS entries. The value of MAX_SERCONS can be chosen in kconfig, the default (4) is arbitrary, inspired by the number of SERHND_IDX values. Make console_steal() aware of multiple consoles too. It can now either steal output from specific console (for gdbstub), or from all of them at once (for console suspend). Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - adjust console_steal() for multiple consoles too - add MAX_SERCONS to kconfig - add warning about sync_console impact - add warning if too many consoles are configured - log issue with PCI spec parsing --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/Kconfig | 11 ++++- xen/drivers/char/console.c | 97 ++++++++++++++++++++++++-------- xen/drivers/char/xhci-dbc.c | 6 +- xen/include/xen/serial.h | 1 +- 5 files changed, 95 insertions(+), 24 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index d594bd5c7436..e53efdb324b3 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -433,6 +433,9 @@ only available when used together with `pv-in-pvh`. `none` indicates that Xen should not use a console. This option only makes sense on its own. +Specifying more than one serial console will increase console latency, +especially when `sync_console` option is used. + ### console_timestamps > `= none | date | datems | boot | raw` @@ -2372,6 +2375,7 @@ vulnerabilities. Flag to force synchronous console output. Useful for debugging, but not suitable for production environments due to incurred overhead. +If multiple consoles are configured, the incurred overhead is even bigger. ### tboot (x86) > `= 0x` diff --git a/xen/drivers/char/Kconfig b/xen/drivers/char/Kconfig index 06350c387371..1010436d245c 100644 --- a/xen/drivers/char/Kconfig +++ b/xen/drivers/char/Kconfig @@ -85,6 +85,17 @@ config SERIAL_TX_BUFSIZE Default value is 16384 (16kiB). +config MAX_SERCONS + int "Maximum number of serial consoles active at once" + default 4 + help + Controls how many serial consoles can be active at once. Configuring more + using `console=` parameter will be ignored. + When multiple consoles are configured, overhead of `sync_console` option + is even bigger. + + Default value is 4. + config XHCI bool "XHCI DbC UART driver" depends on X86 diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c index f9937c5134c0..2ffc919445c6 100644 --- a/xen/drivers/char/console.c +++ b/xen/drivers/char/console.c @@ -113,7 +113,9 @@ static char *__read_mostly conring = _conring; static uint32_t __read_mostly conring_size = _CONRING_SIZE; static uint32_t conringc, conringp; -static int __read_mostly sercon_handle = -1; +#define MAX_SERCONS CONFIG_MAX_SERCONS +static int __read_mostly sercon_handle[MAX_SERCONS]; +static int __read_mostly nr_sercon_handle = 0; #ifdef CONFIG_X86 /* Tristate: 0 disabled, 1 user enabled, -1 default enabled */ @@ -393,32 +395,59 @@ long read_console_ring(struct xen_sysctl_readconsole *op) static char serial_rx_ring[SERIAL_RX_SIZE]; static unsigned int serial_rx_cons, serial_rx_prod; -static void (*serial_steal_fn)(const char *, size_t nr) = early_puts; +/* The last entry means "steal from all consoles" */ +static void (*serial_steal_fn[MAX_SERCONS+1])(const char *, size_t nr) = { + [MAX_SERCONS] = early_puts, +}; +/* + * Redirect console *handle* output to *fn*. Use SERHND_STEAL_ALL as *handle* to + * redirect all the consoles. + */ int console_steal(int handle, void (*fn)(const char *, size_t nr)) { - if ( (handle == -1) || (handle != sercon_handle) ) - return 0; + int i; + + if ( handle == -1 ) + return -ENOENT; + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + return -EBUSY; + if ( handle == SERHND_STEAL_ALL ) + { + serial_steal_fn[MAX_SERCONS] = fn; + return MAX_SERCONS; + } + for ( i = 0; i < nr_sercon_handle; i++ ) + if ( handle == sercon_handle[i] ) + break; + if ( i == nr_sercon_handle ) + return -ENOENT; - if ( serial_steal_fn != NULL ) + if ( serial_steal_fn[i] != NULL ) return -EBUSY; - serial_steal_fn = fn; - return 1; + serial_steal_fn[i] = fn; + return i; } void console_giveback(int id) { - if ( id == 1 ) - serial_steal_fn = NULL; + if ( id >= 0 && id <= MAX_SERCONS ) + serial_steal_fn[id] = NULL; } void console_serial_puts(const char *s, size_t nr) { - if ( serial_steal_fn != NULL ) - serial_steal_fn(s, nr); + int i; + + if ( serial_steal_fn[MAX_SERCONS] != NULL ) + serial_steal_fn[MAX_SERCONS](s, nr); else - serial_puts(sercon_handle, s, nr); + for ( i = 0; i < nr_sercon_handle; i++ ) + if ( serial_steal_fn[i] != NULL ) + serial_steal_fn[i](s, nr); + else + serial_puts(sercon_handle[i], s, nr); /* Copy all serial output into PV console */ pv_console_puts(s, nr); @@ -956,7 +985,7 @@ void guest_printk(const struct domain *d, const char *fmt, ...) void __init console_init_preirq(void) { char *p; - int sh; + int sh, i; serial_init_preirq(); @@ -977,8 +1006,12 @@ void __init console_init_preirq(void) continue; else if ( (sh = serial_parse_handle(p)) >= 0 ) { - sercon_handle = sh; - serial_steal_fn = NULL; + if ( nr_sercon_handle < MAX_SERCONS ) + sercon_handle[nr_sercon_handle++] = sh; + else + printk("Too many consoles (max %d), ignoring '%s'\n", + MAX_SERCONS, p); + serial_steal_fn[MAX_SERCONS] = NULL; } else { @@ -996,7 +1029,8 @@ void __init console_init_preirq(void) opt_console_xen = 0; #endif - serial_set_rx_handler(sercon_handle, serial_rx); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_set_rx_handler(sercon_handle[i], serial_rx); pv_console_set_rx_handler(serial_rx); /* HELLO WORLD --- start-of-day banner text. */ @@ -1014,7 +1048,8 @@ void __init console_init_preirq(void) if ( opt_sync_console ) { - serial_start_sync(sercon_handle); + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_sync(sercon_handle[i]); add_taint(TAINT_SYNC_CONSOLE); printk("Console output is synchronous.\n"); warning_add(warning_sync_console); @@ -1121,13 +1156,19 @@ int __init console_has(const char *device) void console_start_log_everything(void) { - serial_start_log_everything(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_start_log_everything(sercon_handle[i]); atomic_inc(&print_everything); } void console_end_log_everything(void) { - serial_end_log_everything(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_log_everything(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1149,23 +1190,32 @@ void console_unlock_recursive_irqrestore(unsigned long flags) void console_force_unlock(void) { + int i; + watchdog_disable(); spin_debug_disable(); spin_lock_init(&console_lock); - serial_force_unlock(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_force_unlock(sercon_handle[i]); console_locks_busted = 1; console_start_sync(); } void console_start_sync(void) { + int i; + atomic_inc(&print_everything); - serial_start_sync(sercon_handle); + for ( i = 0 ; i < nr_sercon_handle ; i++ ) + serial_start_sync(sercon_handle[i]); } void console_end_sync(void) { - serial_end_sync(sercon_handle); + int i; + + for ( i = 0; i < nr_sercon_handle; i++ ) + serial_end_sync(sercon_handle[i]); atomic_dec(&print_everything); } @@ -1291,7 +1341,8 @@ static int suspend_steal_id; int console_suspend(void) { - suspend_steal_id = console_steal(sercon_handle, suspend_steal_fn); + if ( nr_sercon_handle ) + suspend_steal_id = console_steal(SERHND_STEAL_ALL, suspend_steal_fn); serial_suspend(); return 0; } diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 11026d3b71f0..14a2d3eb0ee2 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -1078,8 +1078,12 @@ void __init xhci_dbc_uart_init(void) e = parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); if ( !e || *e ) + { + printk(XENLOG_ERR + "Invalid dbgp= PCI device spec: '%s'\n", + opt_dbgp); return; - + } dbc->sbdf = PCI_SBDF(0, bus, slot, func); } diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h index 181e026967bc..c3bca000e238 100644 --- a/xen/include/xen/serial.h +++ b/xen/include/xen/serial.h @@ -99,6 +99,7 @@ struct uart_driver { #define SERHND_HI (1<<2) /* Mux/demux each transferred char by MSB. */ #define SERHND_LO (1<<3) /* Ditto, except that the MSB is cleared. */ #define SERHND_COOKED (1<<4) /* Newline/carriage-return translation? */ +#define SERHND_STEAL_ALL 0xff /* Synthetic handle used in console_steal() */ /* Three-stage initialisation (before/during/after IRQ-subsystem setup). */ void serial_init_preirq(void); -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374939.607202 (Exim 4.92) (envelope-from ) id 1oGBAY-0004iO-Kr; Tue, 26 Jul 2022 03:23:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374939.607202; Tue, 26 Jul 2022 03:23:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAY-0004hn-Ct; Tue, 26 Jul 2022 03:23:38 +0000 Received: by outflank-mailman (input) for mailman id 374939; Tue, 26 Jul 2022 03:23:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAX-0003P0-3o for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:37 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 556b9709-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:36 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 757E45C00CC; Mon, 25 Jul 2022 23:23:35 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 25 Jul 2022 23:23:35 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:34 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 556b9709-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805815; x=1658892215; bh=r/M8YO8NxS 0KXBQpVOXd9NU+IPTWyvROd1xBgr9fbs4=; b=vXZrlGKoAaUGT1udv1cL6dhpyg wCRG4ZpDq9IXG21Z6avFkoAdI66wWzgq3BO6INFDP882IlG/BHY3XM+qiTAqNaLN bJOODnXTsmVrtoJgBNsgywuJDSX+QZcCYcYygy7mUP0zzIyxVIL7P6l+7+epJfM7 eh+EjlsfGDUOTgGGSG+FFPkCv33FzmLXrvcElFXPzlAkF4/1PAU4+WgP30D20uOj fR9+yZRDzaW3JVAiW5IxrVlKT0R7+vtCSwYQzYtDOXiP766jNgzVffmwRQNJZSZy 3E3Vynw88a+IjzIbo1A3/dO5yZKjoLu8DatbYTKjU4/KFAR++S9BgSrRYkHg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805815; x= 1658892215; bh=r/M8YO8NxS0KXBQpVOXd9NU+IPTWyvROd1xBgr9fbs4=; b=S n5ZcBWVs6JXO2qrBfnsQe5Fx4mMs60ftfsPf8MiNJp74+jEiyT824eDwhb2U8U2o fPSO1VKu0QGCIzIYSubMa5831nCxv7X7jGQz6lk9seQl6XR/yGCUqZvLAAeNxR5j GXq2V26Sls4wMtPHkZgusNwMHvyH1DRFy/zF8aTLfTxJUNigdqR3DKoFytvAH6O6 UxwdvDD0LtBlW9RAyzaGb7kSAezM1jxZwQRFdkNnFwaD1h2NOY+eC0Mya+drY3tf hH8SbOFTQ2U6QDi1gzL4+/Yq+gOGt84xZ4IYYrFbPNXw0EM9FkPKzFzTD0m7ymoF Kzgy59Y7vJ0OaOVICXtnA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Paul Durrant , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [PATCH v3 05/10] IOMMU: add common API for device reserved memory Date: Tue, 26 Jul 2022 05:23:10 +0200 Message-Id: <6a99f9b99b419a20e895d54db2e345c80270248c.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add API similar to rmrr= and ivmd= arguments, but in a common code. This will allow drivers to register reserved memory regardless of the IOMMU vendor. The direct reason for this API is xhci-dbc console driver (aka xue), that needs to use DMA. But future change may unify command line arguments for user-supplied reserved memory, and it may be useful for other drivers in the future too. This commit just introduces an API, subsequent patches will plug it in appropriate places. The reserved memory ranges needs to be saved locally, because at the point when they are collected, Xen doesn't know yet which IOMMU driver will be used. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - adjust code style --- xen/drivers/passthrough/iommu.c | 45 ++++++++++++++++++++++++++++++++++- xen/include/xen/iommu.h | 13 ++++++++++- 2 files changed, 58 insertions(+) diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c index 77f64e61748d..74efd865ab69 100644 --- a/xen/drivers/passthrough/iommu.c +++ b/xen/drivers/passthrough/iommu.c @@ -651,6 +651,51 @@ bool_t iommu_has_feature(struct domain *d, enum iommu_feature feature) return is_iommu_enabled(d) && test_bit(feature, dom_iommu(d)->features); } +#define MAX_EXTRA_RESERVED_RANGES 20 +struct extra_reserved_range { + unsigned long start; + unsigned long nr; + uint32_t sbdf; +}; +static unsigned int __initdata nr_extra_reserved_ranges; +static struct extra_reserved_range __initdata + extra_reserved_ranges[MAX_EXTRA_RESERVED_RANGES]; + +int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + uint32_t sbdf) +{ + unsigned int idx; + + if ( nr_extra_reserved_ranges >= MAX_EXTRA_RESERVED_RANGES ) + return -ENOMEM; + + idx = nr_extra_reserved_ranges++; + extra_reserved_ranges[idx].start = start; + extra_reserved_ranges[idx].nr = nr; + extra_reserved_ranges[idx].sbdf = sbdf; + + return 0; +} + +int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void *ctxt) +{ + unsigned int idx; + int ret; + + for ( idx = 0; idx < nr_extra_reserved_ranges; idx++ ) + { + ret = func(extra_reserved_ranges[idx].start, + extra_reserved_ranges[idx].nr, + extra_reserved_ranges[idx].sbdf, + ctxt); + if ( ret < 0 ) + return ret; + } + + return 0; +} + /* * Local variables: * mode: C diff --git a/xen/include/xen/iommu.h b/xen/include/xen/iommu.h index 79529adf1fa5..aa87c3fd9ebc 100644 --- a/xen/include/xen/iommu.h +++ b/xen/include/xen/iommu.h @@ -297,6 +297,19 @@ struct iommu_ops { #endif }; +/* + * To be called by Xen internally, to register extra RMRR/IVMD ranges. + * Needs to be called before IOMMU initialization. + */ +extern int iommu_add_extra_reserved_device_memory(unsigned long start, + unsigned long nr, + uint32_t sbdf); +/* + * To be called by specific IOMMU driver during initialization, + * to fetch ranges registered with iommu_add_extra_reserved_device_memory(). + */ +extern int iommu_get_extra_reserved_device_memory(iommu_grdm_t *func, void *ctxt); + #include #ifndef iommu_call -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374940.607213 (Exim 4.92) (envelope-from ) id 1oGBAZ-000538-UU; Tue, 26 Jul 2022 03:23:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374940.607213; Tue, 26 Jul 2022 03:23:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAZ-00052T-OM; Tue, 26 Jul 2022 03:23:39 +0000 Received: by outflank-mailman (input) for mailman id 374940; Tue, 26 Jul 2022 03:23:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAY-000459-78 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:38 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 56027e2f-0c92-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 05:23:37 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 794525C00D1; Mon, 25 Jul 2022 23:23:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:36 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:35 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56027e2f-0c92-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805816; x=1658892216; bh=CFew235jgq 1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=WRQxw3OBitWNGCYieQr8QttJD9 sPQ2lLMqsM/Nh/JLOEvFCaxTO2BhR3ADv/pSQCO8UgBZT0Z/Suo8H7yqROmh/fgW mE1b0VRHSTBjkUtsfl9OWIZCc5ZrBHkEqwpRsB19c5v9z+kGiMKwayF0Uiclb0Jp ukVWO9+avzXAWHKbl4ANpJgxWAfbFu0Wo+Y2o0+0rWUErfYw0MRIgWoduEJV0tl2 zCjc+6Ovb0zgJHQB6VBZ0XcDd9XaEY2ZFW1eUjPfGA+Ieay0wlukrMirnVN/84ED P7fXE5uswll5D+wMXxKEy+x+e162wk2wy8HzIQI8bFi0rFzH5ydnr3GYH+Ew== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805816; x= 1658892216; bh=CFew235jgq1Bpcgaw8qOFpTlwBPLlNuYoSmc12fF7k4=; b=1 S4K2OoRNLnrAkd15WJgBuqPqoAzm/RQTVblxpSrLXXZGPdGo7tYulxJOdDVLZewB +htgDQXvNgtsmA8dEMj+gvh1EP9Arnpc5kgATXB+0cYYRkvqTCgWv7X7ZNvr2UoH If+PTitycJ9FMqKVSUddbjCOA5XzBO1cUGnVLKLAtnvOP3iU3opzW3ttZKEmhjhW 7kMP6ZzP3ie2PuyWRmXHPUwXiPX/jp8hvoQgsUhLuGSTYemqT+iz7jsxDmsycwh0 Ii48Kt/wqUIoNZtfrMY1ytN6Qo2OMOieP7tiAZ+8u+AJkjTrfPdfyrJbSpLQ6K5P jebwbx02OXfM35jIQbNdA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Kevin Tian Subject: [PATCH v3 06/10] IOMMU/VT-d: wire common device reserved memory API Date: Tue, 26 Jul 2022 05:23:11 +0200 Message-Id: <0670dc3600aac44532d73fced60b457848ec2ceb.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Re-use rmrr= parameter handling code to handle common device reserved memory. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - make MAX_USER_RMRR_PAGES applicable only to user-configured RMRR --- xen/drivers/passthrough/vtd/dmar.c | 201 +++++++++++++++++------------- 1 file changed, 119 insertions(+), 82 deletions(-) diff --git a/xen/drivers/passthrough/vtd/dmar.c b/xen/drivers/passthrough/vtd/dmar.c index 367304c8739c..3df5f6b69719 100644 --- a/xen/drivers/passthrough/vtd/dmar.c +++ b/xen/drivers/passthrough/vtd/dmar.c @@ -861,111 +861,139 @@ static struct user_rmrr __initdata user_rmrrs[MAX_USER_RMRR]; /* Macro for RMRR inclusive range formatting. */ #define ERMRRU_FMT "[%lx-%lx]" -#define ERMRRU_ARG(eru) eru.base_pfn, eru.end_pfn +#define ERMRRU_ARG base_pfn, end_pfn + +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf); static int __init add_user_rmrr(void) { + unsigned int i; + int ret; + + for ( i = 0; i < nr_rmrr; i++ ) + { + ret = add_one_user_rmrr(user_rmrrs[i].base_pfn, + user_rmrrs[i].end_pfn, + user_rmrrs[i].dev_count, + user_rmrrs[i].sbdf); + if ( ret < 0 ) + return ret; + } + return 0; +} + +/* Returns 1 on success, 0 when ignoring and < 0 on error. */ +static int __init add_one_user_rmrr(unsigned long base_pfn, + unsigned long end_pfn, + unsigned int dev_count, + uint32_t *sbdf) +{ struct acpi_rmrr_unit *rmrr, *rmrru; - unsigned int idx, seg, i; - unsigned long base, end; + unsigned int idx, seg; + unsigned long base_iter; bool overlap; - for ( i = 0; i < nr_rmrr; i++ ) + if ( iommu_verbose ) + printk(XENLOG_DEBUG VTDPREFIX + "Adding RMRR for %d device ([0]: %#x) range "ERMRRU_FMT"\n", + dev_count, sbdf[0], ERMRRU_ARG); + + if ( base_pfn > end_pfn ) { - base = user_rmrrs[i].base_pfn; - end = user_rmrrs[i].end_pfn; + printk(XENLOG_ERR VTDPREFIX + "Invalid RMRR Range "ERMRRU_FMT"\n", + ERMRRU_ARG); + return 0; + } - if ( base > end ) + overlap = false; + list_for_each_entry(rmrru, &acpi_rmrr_units, list) + { + if ( pfn_to_paddr(base_pfn) <= rmrru->end_address && + rmrru->base_address <= pfn_to_paddr(end_pfn) ) { printk(XENLOG_ERR VTDPREFIX - "Invalid RMRR Range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", + ERMRRU_ARG, + paddr_to_pfn(rmrru->base_address), + paddr_to_pfn(rmrru->end_address)); + overlap = true; + break; } + } + /* Don't add overlapping RMRR. */ + if ( overlap ) + return 0; - if ( (end - base) >= MAX_USER_RMRR_PAGES ) + base_iter = base_pfn; + do + { + if ( !mfn_valid(_mfn(base_iter)) ) { printk(XENLOG_ERR VTDPREFIX - "RMRR range "ERMRRU_FMT" exceeds "\ - __stringify(MAX_USER_RMRR_PAGES)" pages\n", - ERMRRU_ARG(user_rmrrs[i])); - continue; + "Invalid pfn in RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + break; } + } while ( base_iter++ < end_pfn ); - overlap = false; - list_for_each_entry(rmrru, &acpi_rmrr_units, list) - { - if ( pfn_to_paddr(base) <= rmrru->end_address && - rmrru->base_address <= pfn_to_paddr(end) ) - { - printk(XENLOG_ERR VTDPREFIX - "Overlapping RMRRs: "ERMRRU_FMT" and [%lx-%lx]\n", - ERMRRU_ARG(user_rmrrs[i]), - paddr_to_pfn(rmrru->base_address), - paddr_to_pfn(rmrru->end_address)); - overlap = true; - break; - } - } - /* Don't add overlapping RMRR. */ - if ( overlap ) - continue; + /* Invalid pfn in range as the loop ended before end_pfn was reached. */ + if ( base_iter <= end_pfn ) + return 0; - do - { - if ( !mfn_valid(_mfn(base)) ) - { - printk(XENLOG_ERR VTDPREFIX - "Invalid pfn in RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - break; - } - } while ( base++ < end ); + rmrr = xzalloc(struct acpi_rmrr_unit); + if ( !rmrr ) + return -ENOMEM; - /* Invalid pfn in range as the loop ended before end_pfn was reached. */ - if ( base <= end ) - continue; + rmrr->scope.devices = xmalloc_array(u16, dev_count); + if ( !rmrr->scope.devices ) + { + xfree(rmrr); + return -ENOMEM; + } - rmrr = xzalloc(struct acpi_rmrr_unit); - if ( !rmrr ) - return -ENOMEM; + seg = 0; + for ( idx = 0; idx < dev_count; idx++ ) + { + rmrr->scope.devices[idx] = sbdf[idx]; + seg |= PCI_SEG(sbdf[idx]); + } + if ( seg != PCI_SEG(sbdf[0]) ) + { + printk(XENLOG_ERR VTDPREFIX + "Segments are not equal for RMRR range "ERMRRU_FMT"\n", + ERMRRU_ARG); + scope_devices_free(&rmrr->scope); + xfree(rmrr); + return 0; + } - rmrr->scope.devices = xmalloc_array(u16, user_rmrrs[i].dev_count); - if ( !rmrr->scope.devices ) - { - xfree(rmrr); - return -ENOMEM; - } + rmrr->segment = seg; + rmrr->base_address = pfn_to_paddr(base_pfn); + /* Align the end_address to the end of the page */ + rmrr->end_address = pfn_to_paddr(end_pfn) | ~PAGE_MASK; + rmrr->scope.devices_cnt = dev_count; - seg = 0; - for ( idx = 0; idx < user_rmrrs[i].dev_count; idx++ ) - { - rmrr->scope.devices[idx] = user_rmrrs[i].sbdf[idx]; - seg |= PCI_SEG(user_rmrrs[i].sbdf[idx]); - } - if ( seg != PCI_SEG(user_rmrrs[i].sbdf[0]) ) - { - printk(XENLOG_ERR VTDPREFIX - "Segments are not equal for RMRR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - scope_devices_free(&rmrr->scope); - xfree(rmrr); - continue; - } + if ( register_one_rmrr(rmrr) ) + printk(XENLOG_ERR VTDPREFIX + "Could not register RMMR range "ERMRRU_FMT"\n", + ERMRRU_ARG); - rmrr->segment = seg; - rmrr->base_address = pfn_to_paddr(user_rmrrs[i].base_pfn); - /* Align the end_address to the end of the page */ - rmrr->end_address = pfn_to_paddr(user_rmrrs[i].end_pfn) | ~PAGE_MASK; - rmrr->scope.devices_cnt = user_rmrrs[i].dev_count; + return 1; +} - if ( register_one_rmrr(rmrr) ) - printk(XENLOG_ERR VTDPREFIX - "Could not register RMMR range "ERMRRU_FMT"\n", - ERMRRU_ARG(user_rmrrs[i])); - } +static int __init cf_check add_one_extra_rmrr(xen_pfn_t start, xen_ulong_t nr, u32 id, void *ctxt) +{ + u32 sbdf_array[] = { id }; + return add_one_user_rmrr(start, start+nr, 1, sbdf_array); +} - return 0; +static int __init add_extra_rmrr(void) +{ + return iommu_get_extra_reserved_device_memory(add_one_extra_rmrr, NULL); } #include @@ -1010,7 +1038,7 @@ int __init acpi_dmar_init(void) { iommu_init_ops = &intel_iommu_init_ops; - return add_user_rmrr(); + return add_user_rmrr() || add_extra_rmrr(); } return ret; @@ -1108,6 +1136,15 @@ static int __init cf_check parse_rmrr_param(const char *str) else end = start; + if ( (end - start) >= MAX_USER_RMRR_PAGES ) + { + printk(XENLOG_ERR VTDPREFIX + "RMRR range "ERMRRU_FMT" exceeds "\ + __stringify(MAX_USER_RMRR_PAGES)" pages\n", + start, end); + return -E2BIG; + } + user_rmrrs[nr_rmrr].base_pfn = start; user_rmrrs[nr_rmrr].end_pfn = end; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374941.607224 (Exim 4.92) (envelope-from ) id 1oGBAb-0005Mf-DO; Tue, 26 Jul 2022 03:23:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374941.607224; Tue, 26 Jul 2022 03:23:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAb-0005MB-5J; Tue, 26 Jul 2022 03:23:41 +0000 Received: by outflank-mailman (input) for mailman id 374941; Tue, 26 Jul 2022 03:23:39 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAZ-0003P0-6Q for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:39 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 56b4385f-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:38 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 9AB7A5C00C4; Mon, 25 Jul 2022 23:23:37 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:37 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:36 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 56b4385f-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805817; x=1658892217; bh=I6siKunDYx GQP0S8ZLOM5K5jIoXt/ZQrNSId/g+ijJY=; b=pElV3R8p4/TAoXjNMneelUeSOc WzEfG7cV2LTGPTH5QUdU3X2zdZnYZ7lpbS2L1kKeQDktgzMeMC0bFZ16UUniqLyt OcwIWGF+C6WlrsxSM558fb3eMAo04E6i/k9oX0Vg8CSLyUljlCJ/5kDMOIm844NP OFzJmg06dEgY3qUfYSjZzL6RLJkpQ/DtAgsJCKUBnzBHtHNhXkLayicD5fXNhhXE JVPMBCppJsRSJyaPrD9yk1+ykL9CuKh3WRkCo/zM0dyA73jOxZnrxU7XBVO29imL PDW8qfhRZQaHeceit3TqT+nqM8786vqrK20InMlzuVEj0xb3uqom3kNn9ATw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805817; x= 1658892217; bh=I6siKunDYxGQP0S8ZLOM5K5jIoXt/ZQrNSId/g+ijJY=; b=c nKHTVFf4cw8/jsjUXCGdJyxr3HQe1zCGUfYCoUnvjjdYpPLXwtxK+pU6M0s8rKoE do8tg3kb8w/nAz+XYNIChEwqwOPk6CTQ9I5UJt+5ztjFS9ESOVwq1d5bZexMqLdP gqSf9wSlFQFBvuxvG0Ye9O1l6BefvnrLnigrRY22IomrRpZkNlRss3IwLS26XHrm YEgkhLIdpoeFTG6b+A3YWaP1uabR8dW/EHn1+W3zNY8tJePb2rhJulea3dtAXgXa wquOpYjsM18IvQyFz0GuwIN668vaA+pS0AZIhMt3J9nfQFiTX+9apQ7VgXiHTFgy Es7zc8z/biUfSFY/Pd6+Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Jan Beulich , Andrew Cooper Subject: [PATCH v3 07/10] IOMMU/AMD: wire common device reserved memory API Date: Tue, 26 Jul 2022 05:23:12 +0200 Message-Id: <68b7a172fcdad2495fb928e47f33ebe5bafcf953.1658804819.git-series.marmarek@invisiblethingslab.com> X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Register common device reserved memory similar to how ivmd= parameter is handled. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - use variable initializer - use pfn_to_paddr() --- xen/drivers/passthrough/amd/iommu_acpi.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/xen/drivers/passthrough/amd/iommu_acpi.c b/xen/drivers/passthrough/amd/iommu_acpi.c index ac6835225bae..3b577c9b390c 100644 --- a/xen/drivers/passthrough/amd/iommu_acpi.c +++ b/xen/drivers/passthrough/amd/iommu_acpi.c @@ -1078,6 +1078,25 @@ static inline bool_t is_ivmd_block(u8 type) type == ACPI_IVRS_TYPE_MEMORY_IOMMU); } +static int __init cf_check add_one_extra_ivmd(unsigned long start, + unsigned long nr, + uint32_t id, void *ctxt) +{ + struct acpi_ivrs_memory ivmd = { + .header = { + .length = sizeof(ivmd), + .flags = ACPI_IVMD_UNITY | ACPI_IVMD_READ | ACPI_IVMD_WRITE, + .device_id = id, + .type = ACPI_IVRS_TYPE_MEMORY_ONE, + }, + }; + + ivmd.start_address = pfn_to_paddr(start); + ivmd.memory_length = pfn_to_paddr(nr); + + return parse_ivmd_block(&ivmd); +} + static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) { const struct acpi_ivrs_header *ivrs_block; @@ -1121,6 +1140,8 @@ static int __init cf_check parse_ivrs_table(struct acpi_table_header *table) AMD_IOMMU_DEBUG("IVMD: %u command line provided entries\n", nr_ivmd); for ( i = 0; !error && i < nr_ivmd; ++i ) error = parse_ivmd_block(user_ivmds + i); + if ( !error ) + error = iommu_get_extra_reserved_device_memory(add_one_extra_ivmd, NULL); /* Each IO-APIC must have been mentioned in the table. */ for ( apic = 0; !error && iommu_intremap && apic < nr_ioapics; ++apic ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374942.607235 (Exim 4.92) (envelope-from ) id 1oGBAc-0005hT-T4; Tue, 26 Jul 2022 03:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374942.607235; Tue, 26 Jul 2022 03:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAc-0005gr-N1; Tue, 26 Jul 2022 03:23:42 +0000 Received: by outflank-mailman (input) for mailman id 374942; Tue, 26 Jul 2022 03:23:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAa-0003P0-SQ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:40 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 57a688ba-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:40 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 365C65C00C4; Mon, 25 Jul 2022 23:23:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 25 Jul 2022 23:23:39 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:37 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 57a688ba-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805819; x=1658892219; bh=3kwK8JcWbh LtjVsgq8YPYw4utn8O/FJoTtsnfytYm9A=; b=jY+5mrm5AnkRJ55gXNeVKy+7ya hVLHsSlfuBpNYRTCXGgH6Z+gnuxjKtFCZktjgc+b3bMDYVPWWiMRjQTALmhJkZGv wtEGGsoj/7j9Twk9ODa2AOx/alSMP2fMBgIr7GVmKszSTm9i2xy2AE/1Wsr1Et5e KZGlqy1zX69hipxq1Kle1k888w8ehv88MOkPzbRCsnqyO/JHy2uB8Ar9rEjo+hmI uu+Njn1uj1Ld8vRKQDGAMjexbJyeeyX1xGknPIlZ2Z0+nPTKWsRIb2HLqsjnvjAO H1PxcPxGl/kAALW5cpAOMTiNhcYsNP/ou/ROyzMEcYmNyZUE+VZ8FI5WZY3g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805819; x= 1658892219; bh=3kwK8JcWbhLtjVsgq8YPYw4utn8O/FJoTtsnfytYm9A=; b=R XD6WVK0xA+m0sWGLNWwKOcwsKeTCIEkq2bHNbRPbs+cZkS/ppAjgsy3/LBR1qRU7 UuVpjmr7e8BXKmOFS7wj3ENtLKqjeCzn+JOCWhaCB7BgqBa7Ce5m8SDM7I61t9Yi 2/a4KBtEWlSlD2HZLh04CbzLhZyGTNs0o/g/mP/ePVEFRb8cyd38ucyWZzZQs2Bh tO0d415yWzzEtu9vMmFB7reLFai9R1xWxDZeH8Vc1Ta6k7W40rbH8xfqi8t7TgzH e+V7bUDNMlqeLlSkYlHY4qoBR4zdc3LbgAUWWy+P+8zA0WDC4OMxTcgRsxXNgXU/ ZCywdOcrl2hxbFAMlysCw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 08/10] drivers/char: mark DMA buffers as reserved for the XHCI Date: Tue, 26 Jul 2022 05:23:13 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The important part is to include those buffers in IOMMU page table relevant for the USB controller. Otherwise, DbC will stop working as soon as IOMMU is enabled, regardless of to which domain device assigned (be it xen or dom0). If the device is passed through to dom0 or other domain (see later patches), that domain will effectively have access to those buffers too. It does give such domain yet another way to DoS the system (as is the case when having PCI device assigned already), but also possibly steal the console ring content. Thus, such domain should be a trusted one. In any case, prevent anything else being placed on those pages by adding artificial padding. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - adjust for xhci-dbc rename - do not raise MAX_USER_RMRR_PAGES - adjust alignment of DMA buffers --- xen/drivers/char/xhci-dbc.c | 42 +++++++++++++++++++++++++------------- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 14a2d3eb0ee2..546231a75894 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -20,6 +20,7 @@ */ #include +#include #include #include #include @@ -1046,13 +1047,20 @@ static struct uart_driver dbc_uart_driver = { .flush = dbc_uart_flush, }; -static struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb out_trb[DBC_TRB_RING_CAP]; -static struct xhci_trb in_trb[DBC_TRB_RING_CAP]; -static struct xhci_erst_segment erst __aligned(64); -static struct xhci_dbc_ctx ctx __aligned(64); -static uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); -static struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; +struct dbc_dma_bufs { + struct xhci_trb evt_trb[DBC_TRB_RING_CAP]; + struct xhci_trb out_trb[DBC_TRB_RING_CAP]; + struct xhci_trb in_trb[DBC_TRB_RING_CAP]; + uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); + struct xhci_erst_segment erst __aligned(16); + struct xhci_dbc_ctx ctx __aligned(16); + struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; + /* + * Don't place anything else on this page - it will be + * DMA-reachable by the USB controller. + */ +}; +static struct dbc_dma_bufs dbc_dma_bufs __section(".bss.page_aligned"); static char __initdata opt_dbgp[30]; string_param("dbgp", opt_dbgp); @@ -1087,16 +1095,22 @@ void __init xhci_dbc_uart_init(void) dbc->sbdf = PCI_SBDF(0, bus, slot, func); } - dbc->dbc_ctx = &ctx; - dbc->dbc_erst = &erst; - dbc->dbc_ering.trb = evt_trb; - dbc->dbc_oring.trb = out_trb; - dbc->dbc_iring.trb = in_trb; - dbc->dbc_owork.buf = out_wrk_buf; - dbc->dbc_str = str_buf; + dbc->dbc_ctx = &dbc_dma_bufs.ctx; + dbc->dbc_erst = &dbc_dma_bufs.erst; + dbc->dbc_ering.trb = dbc_dma_bufs.evt_trb; + dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; + dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; + dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) + { + iommu_add_extra_reserved_device_memory( + PFN_DOWN(virt_to_maddr(&dbc_dma_bufs)), + PFN_UP(sizeof(dbc_dma_bufs)), + uart->dbc.sbdf.sbdf); serial_register_uart(SERHND_DBGP, &dbc_uart_driver, &dbc_uart); + } } #ifdef DBC_DEBUG -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:23:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:23:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374943.607245 (Exim 4.92) (envelope-from ) id 1oGBAe-00061z-RM; Tue, 26 Jul 2022 03:23:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374943.607245; Tue, 26 Jul 2022 03:23:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAe-00061K-Dc; Tue, 26 Jul 2022 03:23:44 +0000 Received: by outflank-mailman (input) for mailman id 374943; Tue, 26 Jul 2022 03:23:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAc-0003P0-O2 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:42 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 589110a6-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:41 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B49FD5C0196; Mon, 25 Jul 2022 23:23:40 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:23:40 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:39 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 589110a6-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805820; x=1658892220; bh=JtMaNlSkIU jNbemR38QZSlvj6PVIS1fPR5IHNRRgKE0=; b=e8/MkaZB3yB2Z08i7UAYEqex/T /Fhelk6WSsBSpD8S09l5kVyNZwv2yQF/AqSi3dX4RMOia41Fo5xzlw3oeJ4MHIR5 +KW8fiPjdlM5nS/yyw4JmuJWGmowNBQPrigsDpjqwF5WyeJ87X33bahdRpfpzSdz zPxY0h/lqUqGwsB8MnWP0/yfkRwiy4YQX1coJe8wMNT1IvKo1SLliyxn0ZrB+vWt mMoQgvWFRYvmvfwUp7RyMhQpPXf1p+ykPoO8nIzxz/MdAMDKb0gixlBC6Fxg3PVG AV8abe7lALeRyJHPDUCUi9NThFaBpgz8LmLs/rh00asgiHJ7I4+W+hs6jWOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805820; x= 1658892220; bh=JtMaNlSkIUjNbemR38QZSlvj6PVIS1fPR5IHNRRgKE0=; b=n Zko7ir08z3laZ3+yVu1VvBprnlVVNFJf+G9hCQmML83ZZaqItoBOXQdgKra2AwJV nNbcrg3DFJsV6uj/GG5KvLt4zVuWwvP3I/nUwQZrl3HpkqvgwcysL7uMwdlN0Lh9 4SFN8zJKw5mE9SshSxkomZlTiDfQ34cAMSUMRr/h3vZwemZWTosFtI06GwAIiolM qIipkW0hpcpPqr9/nwf/2INSuXWaEN6zAFHAjOo44BEKJki5pOPwYb2jZqDEISu5 zyRrRITzrp8UmRChk/NzXEQjPN+UTnkB8/AdhgmjR9gbrJs503YhMREMwidBWOz1 qXA4V7A7OUII+ppfyL5kA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 09/10] drivers/char: allow driving the rest of XHCI by a domain while Xen uses DbC Date: Tue, 26 Jul 2022 05:23:14 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit That's possible, because the capability was designed specifically to allow separate driver handle it, in parallel to unmodified xhci driver (separate set of registers, pretending the port is "disconnected" for the main xhci driver etc). It works with Linux dom0, although requires an awful hack - re-enabling bus mastering behind dom0's backs. Linux driver does similar thing - see drivers/usb/early/xhci-dbc.c:xdbc_handle_events(). Add an option to allow/deny other domains to use the USB controller. By default, if XHCI console is enabled, Xen will take the whole controller for itself, using `dbgp=xhci,share=hwdom` or `=any` allows other ports to be used by either only dom0 or any dom0 that get this PCI device assigned. In any case, to avoid Linux messing with the DbC, mark this MMIO area as read-only. Signed-off-by: Marek Marczykowski-Górecki --- Changes in v3: - adjust for xhci-dbc rename - adjust for dbc_ensure_running() split - wrap long lines - add runtime option for sharing USB controller --- docs/misc/xen-command-line.pandoc | 12 ++- xen/drivers/char/xhci-dbc.c | 115 ++++++++++++++++++++++++++++--- 2 files changed, 118 insertions(+), 9 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index e53efdb324b3..cc1e1989b17e 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -724,7 +724,7 @@ Available alternatives, with their meaning, are: ### dbgp > `= ehci[ | @pci:. ]` -> `= xhci[ | @pci:. ]` +> `= xhci[ | @pci:. ][,share=none|hwdom|any]` Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). @@ -732,6 +732,16 @@ over the PCI busses sequentially) or by PCI device (must be on segment 0). Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output only). XHCI driver will wait indefinitely for the debug host to connect - make sure the cable is connected. +The `share` option for xhci controls who else can use the controller: +* `none`: use the controller exclusively for console, even hardware domain + (dom0) cannot use it; this is the default +* `hwdom`: hardware domain may use the controller too, ports not used for debug + console will be available for normal devices +* `any`: the controller can be assigned to any domain; it is not safe to assign + the controller to untrusted domain + +Choosing `share=hwdom` or `share=any` allows a domain to reset the controller, +which may cause small portion of the console output to be lost. ### debug_stack_lines > `= ` diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 546231a75894..805b447f2300 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -23,6 +23,7 @@ #include #include #include +#include #include #include #include @@ -228,6 +229,12 @@ struct dbc_work_ring { uint64_t dma; }; +enum xhci_share { + XHCI_SHARE_NONE = 0, + XHCI_SHARE_HWDOM, + XHCI_SHARE_ANY +}; + struct dbc { struct dbc_reg __iomem *dbc_reg; struct xhci_dbc_ctx *dbc_ctx; @@ -244,6 +251,7 @@ struct dbc { void __iomem *xhc_mmio; bool open; + enum xhci_share share; unsigned int xhc_num; /* look for n-th xhc */ }; @@ -871,8 +879,9 @@ static bool __init dbc_open(struct dbc *dbc) } /* - * Ensure DbC is still running, handle events, and possibly re-enable if cable - * was re-plugged. Returns true if DbC is operational. + * Ensure DbC is still running, handle events, and possibly + * re-enable/re-configure if cable was re-plugged or controller was reset. + * Returns true if DbC is operational. */ static bool dbc_ensure_running(struct dbc *dbc) { @@ -880,6 +889,42 @@ static bool dbc_ensure_running(struct dbc *dbc) uint32_t ctrl; uint32_t cmd; + if ( dbc->share != XHCI_SHARE_NONE ) + { + /* + * Re-enable memory decoding and later bus mastering, if dom0 (or + * other) disabled it in the meantime. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MEMORY) ) + { + cmd |= PCI_COMMAND_MEMORY; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + + if ( dbc->open && !(readl(®->ctrl) & (1U << DBC_CTRL_DCE)) ) + { + if ( !dbc_init_dbc(dbc) ) + return false; + + dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_enable_dbc(dbc); + } + else + { + /* + * dbc_init_dbc() takes care about it, so check only if it wasn't + * called. + */ + cmd = pci_conf_read16(dbc->sbdf, PCI_COMMAND); + if ( !(cmd & PCI_COMMAND_MASTER) ) + { + cmd |= PCI_COMMAND_MASTER; + pci_conf_write16(dbc->sbdf, PCI_COMMAND, cmd); + } + } + } + dbc_pop_events(dbc); ctrl = readl(®->ctrl); @@ -1005,10 +1050,32 @@ static void __init cf_check dbc_uart_init_postirq(struct serial_port *port) init_timer(&uart->timer, dbc_uart_poll, port, 0); set_timer(&uart->timer, NOW() + MILLISECS(1)); - if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) - printk(XENLOG_WARNING - "Failed to mark read-only %pp used for XHCI console\n", - &uart->dbc.sbdf); + switch ( uart->dbc.share ) + { + case XHCI_SHARE_NONE: + if ( pci_ro_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to mark read-only %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_HWDOM: + if ( pci_hide_device(0, uart->dbc.sbdf.bus, uart->dbc.sbdf.devfn) ) + printk(XENLOG_WARNING + "Failed to hide %pp used for XHCI console\n", + &uart->dbc.sbdf); + break; + case XHCI_SHARE_ANY: + /* Do not hide. */ + break; + } +#ifdef CONFIG_X86 + if ( rangeset_add_range(mmio_ro_ranges, + PFN_DOWN(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset), + PFN_UP(uart->dbc.xhc_mmio_phys + uart->dbc.xhc_dbc_offset + + sizeof(*uart->dbc.dbc_reg)) - 1) ) + printk(XENLOG_INFO + "Error while adding MMIO range of device to mmio_ro_ranges\n"); +#endif } static int cf_check dbc_uart_tx_ready(struct serial_port *port) @@ -1069,13 +1136,14 @@ void __init xhci_dbc_uart_init(void) { struct dbc_uart *uart = &dbc_uart; struct dbc *dbc = &uart->dbc; - const char *e; + const char *e, *opt; if ( strncmp(opt_dbgp, "xhci", 4) ) return; memset(dbc, 0, sizeof(*dbc)); + e = &opt_dbgp[4]; if ( isdigit(opt_dbgp[4]) ) { dbc->xhc_num = simple_strtoul(opt_dbgp + 4, &e, 10); @@ -1085,7 +1153,7 @@ void __init xhci_dbc_uart_init(void) unsigned int bus, slot, func; e = parse_pci(opt_dbgp + 8, NULL, &bus, &slot, &func); - if ( !e || *e ) + if ( !e || (*e && *e != ',') ) { printk(XENLOG_ERR "Invalid dbgp= PCI device spec: '%s'\n", @@ -1094,6 +1162,37 @@ void __init xhci_dbc_uart_init(void) } dbc->sbdf = PCI_SBDF(0, bus, slot, func); } + opt = e; + + /* other options */ + while ( opt && *opt == ',' ) + { + opt++; + e = strchr(opt, ','); + if ( !e ) + e = strchr(opt, '\0'); + + if ( !strncmp(opt, "share=", 6) ) + { + if ( !cmdline_strcmp(opt + 6, "none") ) + dbc->share = XHCI_SHARE_NONE; + else if ( !cmdline_strcmp(opt + 6, "hwdom") ) + dbc->share = XHCI_SHARE_HWDOM; + else if ( !cmdline_strcmp(opt + 6, "any") ) + dbc->share = XHCI_SHARE_ANY; + else + break; + } + else + break; + + opt = e; + } + if ( !opt || *opt ) + { + printk(XENLOG_ERR "Invalid dbgp= parameters: '%s'\n", opt_dbgp); + return; + } dbc->dbc_ctx = &dbc_dma_bufs.ctx; dbc->dbc_erst = &dbc_dma_bufs.erst; -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 03:26:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 03:26:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375006.607258 (Exim 4.92) (envelope-from ) id 1oGBDc-00016U-EX; Tue, 26 Jul 2022 03:26:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375006.607258; Tue, 26 Jul 2022 03:26:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBDc-00016N-C0; Tue, 26 Jul 2022 03:26:48 +0000 Received: by outflank-mailman (input) for mailman id 375006; Tue, 26 Jul 2022 03:26:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGBAf-0003P0-9s for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 03:23:45 +0000 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 597f4bba-0c92-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 05:23:43 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4E87C5C00C4; Mon, 25 Jul 2022 23:23:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Mon, 25 Jul 2022 23:23:42 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 25 Jul 2022 23:23:40 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 597f4bba-0c92-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm3; t=1658805822; x=1658892222; bh=3vE9DGYbhI DJep8SC3VFi3wWujuEwVBs1IYyq266dMs=; b=DNewsGpK5rLAbc6QqSmb64oajs YI/gPl81TyM+Psc/HlywUIII+Gj81IIHTqM9T3ejn2RGPHbb2VN8sx95AplC7ddL cjftQ2BuINq2hLvRJCOj/3lUArkN2yq3Zfdmh4klEAeLqqt1AdOB1ROJK+ok8p1I Omtp5P7XLFeqEM42a0hOkr6VGb1JeUthYjhirhfFecfcF6WTfi38jej7+lAU6XUF RU8liaDYrS5JlHmLXGqvt+8rNCOM4bB9qSNMxVKMsyW7obD4wNrwSAkX8ZyB4EYk hANv91UMpBMtK+Lp1PfSoOYK+DJ8M1XU5FB+IUn0f9r5kaGB/ooS7phv/1mQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1658805822; x= 1658892222; bh=3vE9DGYbhIDJep8SC3VFi3wWujuEwVBs1IYyq266dMs=; b=r uADkbeaSQDVLdT/4gy1rcV4vqbqcISvVmaOnhBuyt4cnJW6WPViTYxeEf+WsOOg/ ZzeK/5NUiXT0Yh6mxoUS+t35Kyqc8KdL8dWMTM70BoSICdhmqj4yXbWIs6dajAwT 8hzDcSt5WmG6Tcz+iiDDxnYB3HJMIVVsIWYjQJmBkz9LNIxisWs2Zc/1vlyKUMjm SV9Ow6nNbvk4FJ2hUi652OIeBVMzcT/fsf9bYMbXDskbMs9XZwpxcc8xgzSjOSsi I9EXlmtPV3cqNUoPDLqPqLNeQ+7Chf0SU3pqGNjLmmWxmEVBk7+slzjq/y+hrVOB D2aAah+1+10JcjtS0WgpA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddtledgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhmpeforghr vghkucforghrtgiihihkohifshhkihdqifpkrhgvtghkihcuoehmrghrmhgrrhgvkhesih hnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhmqeenucggtffrrghtthgvrhhnpefg ueduhefgvdefheehudejheefudevueeghfekhfehleegveduteeuiedugffgffenucevlh hushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrghrmhgrrhgv khesihhnvhhishhisghlvghthhhinhhgshhlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail From: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= To: xen-devel@lists.xenproject.org Cc: =?UTF-8?q?Marek=20Marczykowski-G=C3=B3recki?= , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: [PATCH v3 10/10] driver/char: add RX support to the XHCI driver Date: Tue, 26 Jul 2022 05:23:15 +0200 Message-Id: X-Mailer: git-send-email 2.35.3 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add another work ring buffer for received data, and point IN TRB at it. Ensure there is always at least one pending IN TRB, so the controller has a way to send incoming data to the driver. Note that both "success" and "short packet" completion codes are okay - in fact it will be "short packet" most of the time, as the TRB length is about maximum size, not required size. Signed-off-by: Marek Marczykowski-Górecki --- New patch in v3 --- docs/misc/xen-command-line.pandoc | 4 +- xen/drivers/char/xhci-dbc.c | 121 +++++++++++++++++++++++++++++++- 2 files changed, 123 insertions(+), 2 deletions(-) diff --git a/docs/misc/xen-command-line.pandoc b/docs/misc/xen-command-line.pandoc index cc1e1989b17e..07174badac8f 100644 --- a/docs/misc/xen-command-line.pandoc +++ b/docs/misc/xen-command-line.pandoc @@ -729,8 +729,8 @@ Available alternatives, with their meaning, are: Specify the USB controller to use, either by instance number (when going over the PCI busses sequentially) or by PCI device (must be on segment 0). -Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability (output -only). XHCI driver will wait indefinitely for the debug host to connect - make +Use `ehci` for EHCI debug port, use `xhci` for XHCI debug capability. +XHCI driver will wait indefinitely for the debug host to connect - make sure the cable is connected. The `share` option for xhci controls who else can use the controller: * `none`: use the controller exclusively for console, even hardware domain diff --git a/xen/drivers/char/xhci-dbc.c b/xen/drivers/char/xhci-dbc.c index 805b447f2300..ccf4f9bbe2b7 100644 --- a/xen/drivers/char/xhci-dbc.c +++ b/xen/drivers/char/xhci-dbc.c @@ -109,6 +109,7 @@ enum { enum { XHCI_TRB_CC_SUCCESS = 1, XHCI_TRB_CC_TRB_ERR = 5, + XHCI_TRB_CC_SHORT_PACKET = 13, }; /* DbC endpoint types */ @@ -243,6 +244,7 @@ struct dbc { struct xhci_trb_ring dbc_oring; struct xhci_trb_ring dbc_iring; struct dbc_work_ring dbc_owork; + struct dbc_work_ring dbc_iwork; struct xhci_string_descriptor *dbc_str; pci_sbdf_t sbdf; @@ -440,6 +442,16 @@ static void xhci_trb_norm_set_ioc(struct xhci_trb *trb) trb->ctrl |= 0x20; } +static uint64_t xhci_trb_norm_buf(struct xhci_trb *trb) +{ + return trb->params; +} + +static uint32_t xhci_trb_norm_len(struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /** * Fields for Transfer Event TRBs (see section 6.4.2.1). Note that event * TRBs are read-only from software @@ -454,6 +466,12 @@ static uint32_t xhci_trb_tfre_cc(const struct xhci_trb *trb) return trb->status >> 24; } +/* Amount of data _not_ transferred */ +static uint32_t xhci_trb_tfre_len(const struct xhci_trb *trb) +{ + return trb->status & 0x1FFFF; +} + /* Fields for link TRBs (section 6.4.4.1) */ static void xhci_trb_link_set_rsp(struct xhci_trb *trb, uint64_t rsp) { @@ -495,6 +513,14 @@ static int xhci_trb_ring_full(const struct xhci_trb_ring *ring) return ((ring->enq + 1) & (DBC_TRB_RING_CAP - 1)) == ring->deq; } +static int xhci_trb_ring_size(const struct xhci_trb_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return ring->enq - ring->deq; + + return DBC_TRB_RING_CAP - ring->deq + ring->enq; +} + static int dbc_work_ring_full(const struct dbc_work_ring *ring) { return ((ring->enq + 1) & (DBC_WORK_RING_CAP - 1)) == ring->deq; @@ -508,6 +534,14 @@ static uint64_t dbc_work_ring_size(const struct dbc_work_ring *ring) return DBC_WORK_RING_CAP - ring->deq + ring->enq; } +static uint64_t dbc_work_ring_space_to_end(const struct dbc_work_ring *ring) +{ + if ( ring->enq >= ring->deq ) + return DBC_WORK_RING_CAP - ring->enq; + + return ring->deq - ring->enq; +} + static void dbc_push_trb(struct dbc *dbc, struct xhci_trb_ring *ring, uint64_t dma, uint64_t len) { @@ -568,6 +602,31 @@ static int64_t dbc_push_work(struct dbc *dbc, struct dbc_work_ring *ring, return i; } +static void dbc_rx_trb(struct dbc *dbc, struct xhci_trb *trb, + uint64_t not_transferred) +{ + struct dbc_work_ring *ring = &dbc->dbc_iwork; + unsigned int rx_len; + unsigned int end, start = ring->enq; + + if ( xhci_trb_type(trb) != XHCI_TRB_NORM ) + /* Can be Link TRB for example. */ + return; + + ASSERT(xhci_trb_norm_buf(trb) == ring->dma + ring->enq); + ASSERT(xhci_trb_norm_len(trb) >= not_transferred); + rx_len = xhci_trb_norm_len(trb) - not_transferred; + + /* It can hit the ring end, but should not wrap around. */ + ASSERT(ring->enq + rx_len <= DBC_WORK_RING_CAP); + ring->enq = (ring->enq + rx_len) & (DBC_WORK_RING_CAP - 1); + + end = ring->enq; + + if ( end > start ) + cache_flush(&ring->buf[start], end - start); +} + /* * Note that if IN transfer support is added, then this * will need to be changed; it assumes an OUT transfer ring only @@ -577,6 +636,7 @@ static void dbc_pop_events(struct dbc *dbc) struct dbc_reg *reg = dbc->dbc_reg; struct xhci_trb_ring *er = &dbc->dbc_ering; struct xhci_trb_ring *tr = &dbc->dbc_oring; + struct xhci_trb_ring *ir = &dbc->dbc_iring; struct xhci_trb *event = &er->trb[er->deq]; uint64_t erdp = readq(®->erdp); uint32_t portsc; @@ -602,6 +662,14 @@ static void dbc_pop_events(struct dbc *dbc) trb_idx = (event_ptr - tr->dma) >> XHCI_TRB_SHIFT; tr->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); } + else if ( event_ptr - ir->dma < DBC_TRB_RING_BYTES ) + { + trb_idx = (event_ptr - ir->dma) >> XHCI_TRB_SHIFT; + if ( xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SUCCESS || + xhci_trb_tfre_cc(event) == XHCI_TRB_CC_SHORT_PACKET ) + dbc_rx_trb(dbc, &ir->trb[trb_idx], xhci_trb_tfre_len(event)); + ir->deq = (trb_idx + 1) & (DBC_TRB_RING_CAP - 1); + } else dbc_alert("event: TRB 0x%lx not found in any ring\n", event_ptr); @@ -872,6 +940,7 @@ static bool __init dbc_open(struct dbc *dbc) return false; dbc_init_work_ring(dbc, &dbc->dbc_owork); + dbc_init_work_ring(dbc, &dbc->dbc_iwork); dbc_enable_dbc(dbc); dbc->open = true; @@ -985,6 +1054,33 @@ static void dbc_flush(struct dbc *dbc, struct xhci_trb_ring *trb, } /** + * Ensure DbC has a pending transfer TRB to receive data into. + * + * @param dbc the dbc to flush + * @param trb the ring for the TRBs to transfer + * @param wrk the work ring to receive data into + */ +static void dbc_enqueue_in(struct dbc *dbc, struct xhci_trb_ring *trb, + struct dbc_work_ring *wrk) +{ + struct dbc_reg *reg = dbc->dbc_reg; + uint32_t db = (readl(®->db) & 0xFFFF00FF) | (trb->db << 8); + + /* Check if there is already queued TRB */ + if ( xhci_trb_ring_size(trb) >= 1 ) + return; + + if ( dbc_work_ring_full(wrk) ) + return; + + dbc_push_trb(dbc, trb, wrk->dma + wrk->enq, + dbc_work_ring_space_to_end(wrk)); + + wmb(); + writel(db, ®->db); +} + +/** * Queue a single character to the DbC. A transfer TRB will be created * if the character is a newline and the DbC will be notified that data is * available for writing to the debug host. @@ -1007,6 +1103,19 @@ static int64_t dbc_putc(struct dbc *dbc, char c) return 1; } +static int dbc_getc(struct dbc *dbc, char *c) +{ + struct dbc_work_ring *wrk = &dbc->dbc_iwork; + + if ( dbc_work_ring_size(wrk) == 0 ) + return 0; + + *c = wrk->buf[wrk->deq]; + wrk->deq = (wrk->deq + 1) & (DBC_WORK_RING_CAP - 1); + + return 1; +} + struct dbc_uart { struct dbc dbc; struct timer timer; @@ -1032,6 +1141,9 @@ static void cf_check dbc_uart_poll(void *data) spin_unlock_irqrestore(&port->tx_lock, flags); } + while ( dbc_work_ring_size(&dbc->dbc_iwork) ) + serial_rx_interrupt(port, guest_cpu_user_regs()); + serial_tx_interrupt(port, guest_cpu_user_regs()); set_timer(&uart->timer, NOW() + MICROSECS(DBC_POLL_INTERVAL)); } @@ -1092,6 +1204,12 @@ static void cf_check dbc_uart_putc(struct serial_port *port, char c) dbc_putc(&uart->dbc, c); } +static int cf_check dbc_uart_getc(struct serial_port *port, char *c) +{ + struct dbc_uart *uart = port->uart; + return dbc_getc(&uart->dbc, c); +} + static void cf_check dbc_uart_flush(struct serial_port *port) { s_time_t goal; @@ -1111,6 +1229,7 @@ static struct uart_driver dbc_uart_driver = { .init_postirq = dbc_uart_init_postirq, .tx_ready = dbc_uart_tx_ready, .putc = dbc_uart_putc, + .getc = dbc_uart_getc, .flush = dbc_uart_flush, }; @@ -1119,6 +1238,7 @@ struct dbc_dma_bufs { struct xhci_trb out_trb[DBC_TRB_RING_CAP]; struct xhci_trb in_trb[DBC_TRB_RING_CAP]; uint8_t out_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); + uint8_t in_wrk_buf[DBC_WORK_RING_CAP] __aligned(DBC_PAGE_SIZE); struct xhci_erst_segment erst __aligned(16); struct xhci_dbc_ctx ctx __aligned(16); struct xhci_string_descriptor str_buf[DBC_STRINGS_COUNT]; @@ -1200,6 +1320,7 @@ void __init xhci_dbc_uart_init(void) dbc->dbc_oring.trb = dbc_dma_bufs.out_trb; dbc->dbc_iring.trb = dbc_dma_bufs.in_trb; dbc->dbc_owork.buf = dbc_dma_bufs.out_wrk_buf; + dbc->dbc_iwork.buf = dbc_dma_bufs.in_wrk_buf; dbc->dbc_str = dbc_dma_bufs.str_buf; if ( dbc_open(dbc) ) -- git-series 0.9.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:15:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:15:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375018.607269 (Exim 4.92) (envelope-from ) id 1oGDq7-0002LK-9z; Tue, 26 Jul 2022 06:14:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375018.607269; Tue, 26 Jul 2022 06:14:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDq7-0002LD-7B; Tue, 26 Jul 2022 06:14:43 +0000 Received: by outflank-mailman (input) for mailman id 375018; Tue, 26 Jul 2022 06:14:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDq5-0002L7-EC for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:14:41 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50054.outbound.protection.outlook.com [40.107.5.54]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3ab0e178-0caa-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 08:14:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8474.eurprd04.prod.outlook.com (2603:10a6:102:1dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 06:14:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:14:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3ab0e178-0caa-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OJeEYQvJoPBU8Lroxmms8XZdFyzJxGdCqVaFY+I01VqQSB4C3KKz5Rd1Hc0DhCR3IS3Fo5SlmIsvbFot4zuxD0EKdqBBIqaVoKlzgS/Mx1baLm39tH/ozK+G58MmwsRbN6hXVI1EPPYKx2LV88/zF9pMi7cwciz7sR3id3Ku/IUfF3a9Xw8F6aw5b64jiSdPG95Pvg43bmHjtyXOKUsFK7XwAcUqrOKYoViZ5p/5j1bfmN88zvvFbrKLLdniFPbVg6YznKAKzVTpuaNe5OXqJ+nFuGDOCRKqk069fRVBoa07ORsBYXaC8VhQg4/Kml98klkAM6RarQJZIX0TdEHPug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dD0tPYF9vg1Ta58uv42EHd8UFXVBnbGT6bTL29YE+iM=; b=Mp4H8m3niXOBvPfNDxpVbdkbHU8nT8Amam7l1kf+35mt0GBugd7WaZgx2QWMlnt0p2i0dTE/ksbYuKo9apDGTaC9RukQ7Wp5qh5L0QtkWsbciIL9tYFYy+MhXvQRhVwtYehQfEpTnkdYSOTaYLSmRQReAp8B//Qm6DEflZ400zWpkG3TlZBRYzZY5015KMSan9bJ1TVKaddRTf8H+wAvUaBCAfNhBK/IDabrZeR9RkmQF4ESCQuauFuPgUgaJhREU6zvQnhS8y5VKuPTeH+Fn0arEqRDWFbvRfJ/QSPtKq5pJQtsBvnWzIHNct9m6cJR/g1j6FpAFnSVRgMQCmy7Jg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dD0tPYF9vg1Ta58uv42EHd8UFXVBnbGT6bTL29YE+iM=; b=h8lvDqIu0MCieObFd/LCqkM9xmRKzbsl23j+YnR75qVHbSAg4x0Gu63MfjHoDSrZLCmilayIw4OAarecCY4iyboTRr57fcFUYr7nd8y4TW6NFE4tgR0Z1LhAAVcIhX5pd43wwCo3LMOGnydZaT6pfH/SgXk4W2MYTR5IB14s4Ia3iAqPD/TCha7q8oRM7DfXjgmiXhp4WTz5P4HDqriZgygQy/s6z/045VVJsTiC2X/1T9RcGTuSnpEEe61qajBkk+NT6cmXpd9g5APoCI5iHuEkDsDsKM7Y1ASyjEGAdOnpnQps073y5gUAVK8oJZkZxi/hVb5EMKiZWkuJVnieUg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7c50304a-0a9e-8488-ec97-555403f8f301@suse.com> Date: Tue, 26 Jul 2022 08:14:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] page-alloc: fix initialization of cross-node regions Content-Language: en-US To: Andrew Cooper Cc: George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "Xia, Hongyan" , "xen-devel@lists.xenproject.org" References: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> <1f43b3a1-a580-d1a7-c52e-06ba591ae3a0@citrix.com> From: Jan Beulich In-Reply-To: <1f43b3a1-a580-d1a7-c52e-06ba591ae3a0@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdc1302b-94c8-4bbd-83f3-08da6ece1d62 X-MS-TrafficTypeDiagnostic: PAXPR04MB8474:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CR16Y9YnaOLqXPZr5hqxrhH1ePFhcuZnS1mquUMCyP488MS4T6MbwNYl0yXNe5JFGO5Q2EnE5qoWKKbar6yjQbxNB50YssP2RXaVkzdWUuHLJzvrTHjrKMDYqMbqlxJaYMWItI3pp1TyJGgRSO+CKBTCQM24JGwkGIb3B/slxPAqh/jqvRWtvhXUOQoPN9wPR7kS0ve3FT2HWemQfA15h8ISRPmPzjEZf9evbgebdLFBO65/vzFTTSSVbybZeunA3/PKxYyrSWHKwt2lGofahjjBJyGZVhEE+PgfSiTy7UbF5IS8z0k/hVC1Vock25/H35mFSEOkE9M6eAh3+Jnymgy2AOiyn2qWlJblPvomdlHox5JHa+AtJzgO2Y5Htb+pWWKxqKavv1YJ44epYallanq2+VMigySB09JFAeNvn+con/ffjDbOotYx5SR7DalilrbAuMUP4qqbNBfc0phmo94W4CtTlkr4iWMLtS2FfjlKEd1T/bJkrgtke0rVJzzT9X2x3jzzpGemCR3YtlfSZu1grsdIgWVfLQr7Xxd14CvQIJhVOcRkA9Gakp4sCKV2nPnq6yyDCqh8F6y/rnl8VnQcKI/6WuySmVZX/DJiH7fkKkW3kcWNhMaRQlM/GjXYVvAIhZ28VhkGvtaoTXDvIh2lDvkytltVDiEuaXQ9ND+/mpv7jKKd2hpU6s/3Ex59Mx2pegH6K/QfI6r1CS41TWlu5Cs+3+S7BGGrU9z4HAZO/FnyFZw7u4LUoc0FJX6V3j0kU8dVWtY6LdXzy6/03e2osSspqPVHfBKJVluhSR+hWb6Z1l8G65sFY+mMHTrCvSntlk8F0Pw/ieoaqUwy9A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(376002)(396003)(366004)(8936002)(83380400001)(26005)(5660300002)(38100700002)(2906002)(54906003)(6916009)(478600001)(6486002)(316002)(2616005)(8676002)(66946007)(186003)(66476007)(41300700001)(31696002)(6512007)(53546011)(86362001)(66556008)(4326008)(36756003)(6506007)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEpnSnF2aG9XaTdQWDQwQVVpai9xREFUS0pTakZJckF5bWJQME8zNU11L0Q1?= =?utf-8?B?WjJTQjhlQmc0bklpb2g4eXQ2SEVlYm9NaFRwNkc3S3dRZHBSUEdLcHFoZUJH?= =?utf-8?B?MTBXWHVjV3o2WGkvTjBpVEJ4MnJRbi82VW1wdWw4Vk5RZ09uUjdvMnA0Z2R1?= =?utf-8?B?VUJndktBd0wvbEdGeCtDQmphSGI0SW1JYndnUnhYYVRXbW9vdWVZbzdKMk9N?= =?utf-8?B?RzBoNi9oRDM2M1RaWnNnU3hxR29Tcm9XL2l0ZEZtRmNBZXFkZ3RjZ2ZDYnhZ?= =?utf-8?B?UGJtekZienVkOXhjeFY5eWUzMXh5M1NCL0RwVyt4aFBmZElWMloraU9EWElz?= =?utf-8?B?VWZPK1RqVHlQMlBBMyt3SmVOeDJrL0FLd2MwdHI3NWVmVzhsNHErSkR2dm1F?= =?utf-8?B?aSsvZThFMFNyWkZoelRFYjdWNVQ0QU9JNTdWQWZ6bzlNbExXanZtTVdXRE9s?= =?utf-8?B?RFhFdUdYY2U0eEdGOFRMeGZWemxHaTBYeituRnNHUjhTSnhmVGJndkJNdUJH?= =?utf-8?B?eThnSk5SWjBNOFh6dTVlYW1SSGU4UTJUYVkwOEliU0p3WXFKVlJKdk9UYnVX?= =?utf-8?B?RHprQVpLSkpZQldaSHJxVmIvY1g2RUE1NTFHSmFkREdwZ3JhQldKdG9zSWhG?= =?utf-8?B?NHRVSmtFeFVZcFJjV3k5bU42MDVTUGdQaFdidkVqTmtsRjMxY3JEOG5CNVFo?= =?utf-8?B?dHFkZktsZkxwWEJNNXRQaXZHbGlLMmlhZEIwV040Ti9jWU5LUElHaExxa2dC?= =?utf-8?B?MEllRWNMVVZNWXJJUGJOeE4yQTltMUpGN0tJbFhVUVB4ZllCLzJWVkU3WDFv?= =?utf-8?B?U1FnN1h2RmRuVWsya0tpbW9RdU9oczVzakpOeXRpemhYdmVYQUdxVUQ4UWYy?= =?utf-8?B?dkFKQWMrTUFCMXNEeldkWUxNMXpjRVRQY1RkMHlDaWdvU21LYmJ1dkNRNU02?= =?utf-8?B?VXpDejFOdEF5Ulp6VmI4b0l6QU1aTzVvZmNqeEZkeWd1cHo2VmVRQng5U2ZO?= =?utf-8?B?SGpQR25nZWU4dDd2andXVWpsV0x6czEyRlB5bGNnZlIzM1JaN1BEUXdMNFI0?= =?utf-8?B?VDN1VGh6TElyYW5SaUNNNTRJcUZUVk1mSG1CbHRtYVFwOG5aNHRmY1pNMFNK?= =?utf-8?B?Z1AwdVZHUEg5VmhoSVJvdStiKy9RbWJmRU5TVzRqVFpGbks0Rm1rQXZJd3Zy?= =?utf-8?B?eTlmK2xtcnUvZ2EyU1BmTzAwTFN3SzhqdVlKRUF3alA3S1JPZHdla0VjUUs5?= =?utf-8?B?ODdGNVJPcktyNE40Ny90MS9vUVBXQk5DUjJjbFBNVnZsdTA3M1Nrc0RwU2c0?= =?utf-8?B?S0VDUVAzcVg2UXZvVWk5b0pzRmIrb2x4QXRORTA5azFGRFFsSXpXZWhzbGpt?= =?utf-8?B?bmcrNXBXMkJaWmZXV0drUmpsV085dnBhak1PNHV6Mmh5Q0Nzb3IvQUNKdUc0?= =?utf-8?B?QnZDTkpEOXE5NGplZlBvYk9yUGFjdDkyRlBwd2luL3Iva0ZwZ09jekNjQVpW?= =?utf-8?B?N1o1cGkvQVdXNVJlYzZmWENCYVVWQW11SmhOdWxYTmE0MFp1SkFZQ2ZJV3BZ?= =?utf-8?B?T2EvTnZaR09GZHpVOFdMdmlIZHVpeVVkOG9OdmhUeU9wKzRXN2U5Z1hqazI4?= =?utf-8?B?eVZROG1VS1Vab2ozTGN6dVBqbXBYWWlqd2Vyay9pMUhnYmFyOWNsYUdnYzB0?= =?utf-8?B?eDVnVTFoUWExV0lvY1NuQVBCZ2QwOE1OYzdGa1paY3ZPOTBTaUsveGpsOVJD?= =?utf-8?B?U3R3d2hLWFhoZ240QnVLR1hTa2xkeERzR0E5VGwwRzZhbjhWL0V5S2lEa0RW?= =?utf-8?B?cEh1bWhDb1JVSlh5SSsvMEJjK0EwR29KNkF5Rnl5RXhWdmI1RTV5cEdqbThJ?= =?utf-8?B?MWVvUnJkbWQwaWtOaXFpYXo0TUp0Y0JrWmN6V09PM2MwV1E2M21hOHQ4dDRp?= =?utf-8?B?VTkrSGRWcDhKQmVwVFhGUURQL3EyYlArQTVzdG8rdllONlpnU28zN3p5RGVD?= =?utf-8?B?YnZHWDg1Z29LNTZ2ME1sZHoyU3p4THFIVlcyb0VXWDRpM05nQTdBNmJoYzBC?= =?utf-8?B?NHBUQzNQRExoQVBWMGN6UTRQQTdqcWNxdkg3OWZUcFFDREJFTWhVZjROcWY5?= =?utf-8?Q?aDB9CgzfB5fXpDs25MIqWjB9s?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdc1302b-94c8-4bbd-83f3-08da6ece1d62 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:14:36.3379 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G5W9thCPcZxCAkVbQ5Z3vHNTeuFcZKdxFN24vBosfev+c0xlYnT1FqhkJ66EUPsKtD+hQmPtEvJI8y6MPcUMQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8474 On 25.07.2022 20:54, Andrew Cooper wrote: > On 25/07/2022 14:10, Jan Beulich wrote: >> Quite obviously to determine the split condition successive pages' >> attributes need to be evaluated, not always those of the initial page. >> >> Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap init") >> Signed-off-by: Jan Beulich >> --- >> Part of the problem was already introduced in 24a53060bd37 ("xen/heap: >> Split init_heap_pages() in two"), but there it was still benign. > > This also fixes the crash that XenRT found on loads of hardware, which > looks something like: > > (XEN) NUMA: Allocated memnodemap from 105bc81000 - 105bc92000 > (XEN) NUMA: Using 8 for the hash shift. > (XEN) Early fatal page fault at e008:ffff82d04022ae1e > (cr2=00000000000000b8, ec=0002) > (XEN) ----[ Xen-4.17.0  x86_64  debug=y  Not tainted ]---- > (XEN) CPU:    0 > (XEN) RIP:    e008:[] > common/page_alloc.c#free_heap_pages+0x2dd/0x850 > ... > (XEN) Xen call trace: > (XEN)    [] R > common/page_alloc.c#free_heap_pages+0x2dd/0x850 > (XEN)    [] F > common/page_alloc.c#init_heap_pages+0x55f/0x720 > (XEN)    [] F end_boot_allocator+0x187/0x1e7 > (XEN)    [] F __start_xen+0x1a06/0x2779 > (XEN)    [] F __high_start+0x94/0xa0 > > Debugging shows that it's always a block which crosses node 0 and 1, > where avail[1] has yet to be initialised. > > What I'm confused by is how this manages to manifest broken swiotlb > issues without Xen crashing. I didn't debug this in detail since I had managed to spot the issue by staring at the offending patch, but from the observations some of node 1's memory was actually accounted to node 0 (incl off-by- 65535 node_need_scrub[] values for both nodes), so I would guess avail[1] simply wasn't accessed before being set up in my case. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:18:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375024.607280 (Exim 4.92) (envelope-from ) id 1oGDtH-00037a-Tl; Tue, 26 Jul 2022 06:17:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375024.607280; Tue, 26 Jul 2022 06:17:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDtH-00037T-QP; Tue, 26 Jul 2022 06:17:59 +0000 Received: by outflank-mailman (input) for mailman id 375024; Tue, 26 Jul 2022 06:17:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDtG-00037J-0F for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:17:58 +0000 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [2607:f8b0:4864:20::52f]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id af4a68f8-0caa-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 08:17:55 +0200 (CEST) Received: by mail-pg1-x52f.google.com with SMTP id f65so12310053pgc.12 for ; Mon, 25 Jul 2022 23:17:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af4a68f8-0caa-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JPUEYwXa9Po3sGzwZHY31YLAuN0lGJa2gKdH2VeZSlg=; b=CzS6+pGF8tfulOvP8pOKqr10ilq63056Jba5SyklJq/KoQ+DrhZ0yWZ3u2/y1AZEGV Gf6YZewG7O6TAbyqkzWQCVEYL/M/TqNjo9QbLcBC4zRd7bqo6D60AvyzsfaVlJ9cv9YD CWtRGYUGtQD0ra1f8+tji3MwzDTut5pqjj4PScvUsB6PM7oh2nNGmTFKTGhNJ26v9VXf Lg/aALE5NtxxSEQ0bLHDpvimPeq/EDX93WdSs1KBhMxbv9bUWYXspdpP9T5/CTdQPIpx lagrWT09QyLvlHmYN8FiPzhTizacd6GXgHii6y47Iq8H71euIFbvcl6L7WWVIwL+FdKK Lr3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JPUEYwXa9Po3sGzwZHY31YLAuN0lGJa2gKdH2VeZSlg=; b=s5Pz/NJow2YupKLYmXDTHm7htXzqVleKEVl6QNoVzDvVjdr/Cj9hJvpj8aUrpy9bU4 O//U2jqPWs2ZY3R5N+ianxaHiK+/wPRnC47DIqcU9u4mDO01nB3MxvR+qSx3iOk/Zzn+ O6+AJnmNdlKjkFxIMvXW3p4DZGmzl7toHefyffFyi8zZDUeCItrHipCxi2HrKuZBg6zS YQdrBP5xaypeVMuU8uS/d1ayhEWaBiYFkEiN1yX8r/NCYqmyKFk8vway2qB6D43PhBXf pf9ygSQ8MEX4VL5CKz8dXeHj+hwQoYzDFcB+lidJsvO4I7zrdvZpTRw3aR7wXy8OwGqR vrVg== X-Gm-Message-State: AJIora+RH8H5MmodNc9O9/C/XYb5rxsaGoTzexk33NgYzJjw45zi4SCq EN/fYrB2L7wRvwbMDMah28zah6rBOUzusJSXVWwOC6mfgzM= X-Google-Smtp-Source: AGRyM1v/HfjVt3T8CpiKIsp8Nxte/mv7CgWyGzgPSDppPcG48uXZ0Gix0gn6zGlr4xv7huUe3fWEq2Arn91vzcx4yak= X-Received: by 2002:a62:ea18:0:b0:52a:c12b:9313 with SMTP id t24-20020a62ea18000000b0052ac12b9313mr15922821pfh.49.1658816273289; Mon, 25 Jul 2022 23:17:53 -0700 (PDT) MIME-Version: 1.0 References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> In-Reply-To: <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> From: Jens Wiklander Date: Tue, 26 Jul 2022 08:17:41 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu Content-Type: text/plain; charset="UTF-8" Hi Julien, On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: > > Hi Jens, > > I haven't checked whether the FFA driver is complaint with the spec. I > mainly checked whether the code makes sense from Xen PoV. > > This is a fairly long patch to review. So I will split my review in > multiple session/e-mail. > > On 22/06/2022 14:42, Jens Wiklander wrote: > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the bare minimum to be able to communicate with > > OP-TEE running as an SPMC at S-EL1. > > > > This is loosely based on the TEE mediator framework and the OP-TEE > > mediator. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > --- > > SUPPORT.md | 7 + > > tools/libs/light/libxl_arm.c | 3 + > > tools/libs/light/libxl_types.idl | 1 + > > tools/xl/xl_parse.c | 3 + > > These changes would need an ack from the toolstack maintainers. OK, I'll keep them in CC. > > > xen/arch/arm/Kconfig | 11 + > > xen/arch/arm/Makefile | 1 + > > xen/arch/arm/domain.c | 10 + > > xen/arch/arm/domain_build.c | 1 + > > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > > xen/arch/arm/include/asm/domain.h | 4 + > > xen/arch/arm/include/asm/ffa.h | 71 ++ > > xen/arch/arm/vsmc.c | 17 +- > > xen/include/public/arch-arm.h | 2 + > > 13 files changed, 1811 insertions(+), 3 deletions(-) > > create mode 100644 xen/arch/arm/ffa.c > > create mode 100644 xen/arch/arm/include/asm/ffa.h > > > > diff --git a/SUPPORT.md b/SUPPORT.md > > index 70e98964cbc0..215bb3c9043b 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > > > No support for QEMU backends in a 16K or 64K domain. > > > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > > + > > + Status, Arm64: Tech Preview > > + > > +There are still some code paths where a vCPU may hog a pCPU longer than > > +necessary. The FF-A mediator is not yet implemented for Arm32. > > + > > ### ARM: Guest Device Tree support > > > > Status: Supported > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > > index eef1de093914..a985609861c7 100644 > > --- a/tools/libs/light/libxl_arm.c > > +++ b/tools/libs/light/libxl_arm.c > > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > > return ERROR_FAIL; > > } > > > > + config->arch.ffa_enabled = > > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > > + > > return 0; > > } > > > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index 2a42da2f7d78..bf4544bef399 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > + ("ffa_enabled", libxl_defbool), > > This needs to be accompagnied with a define LIBXL_HAVE_* in > tools/include/libxl.h. Please see the examples in the header. OK, I'll add something. I'm not entirely sure how this is used so I'm afraid it will be a bit of Cargo Cult programming from my side. > > > ])), > > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > > ])), > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > > index b98c0de378b6..e0e99ed8d2b1 100644 > > --- a/tools/xl/xl_parse.c > > +++ b/tools/xl/xl_parse.c > > @@ -2746,6 +2746,9 @@ skip_usbdev: > > exit(-ERROR_FAIL); > > } > > } > > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > > + xlu_cfg_get_defbool(config, "ffa_enabled", > > + &b_info->arch_arm.ffa_enabled, 0); > > This option needs to be documented in docs/man/xl.cfg.5.pod.in. OK > > > > > parse_vkb_list(config, d_config); > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > index be9eff014120..e57e1d3757e2 100644 > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -139,6 +139,17 @@ config TEE > > > > source "arch/arm/tee/Kconfig" > > > > +config FFA > > + bool "Enable FF-A mediator support" if EXPERT > > + default n > > + depends on ARM_64 > > + help > > + This option enables a minimal FF-A mediator. The mediator is > > + generic as it follows the FF-A specification [1], but it only > > + implements a small subset of the specification. > > Where would a user be able to find which subset of the specification > that Xen implements? I'll add a bit more in docs/man/xl.cfg.5.pod.in where I'm describing ffa_enabled. > > > + > > + [1] https://developer.arm.com/documentation/den0077/latest > > + > > endmenu > > > > menu "ARM errata workaround via the alternative framework" > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > > index bb7a6151c13c..af0c69f793d4 100644 > > --- a/xen/arch/arm/Makefile > > +++ b/xen/arch/arm/Makefile > > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > > obj-y += domctl.o > > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > > obj-y += efi/ > > +obj-$(CONFIG_FFA) += ffa.o > > obj-y += gic.o > > obj-y += gic-v2.o > > obj-$(CONFIG_GICV3) += gic-v3.o > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > index 8110c1df8638..a3f00e7e234d 100644 > > --- a/xen/arch/arm/domain.c > > +++ b/xen/arch/arm/domain.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > > goto fail; > > > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > > + goto fail; > > + > > update_domain_wallclock_time(d); > > > > /* > > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > > enum { > > PROG_pci = 1, > > PROG_tee, > > + PROG_ffa, > > PROG_xen, > > PROG_page, > > PROG_mapping, > > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > > > PROGRESS(tee): > > ret = tee_relinquish_resources(d); > > + if ( ret ) > > + return ret; > > + > > + PROGRESS(ffa): > > + ret = ffa_relinquish_resources(d); > > if (ret ) > > return ret; > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 7ddd16c26da5..d708f76356f7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > > if ( gic_number_lines() > 992 ) > > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > > dom0_cfg.arch.tee_type = tee_get_type(); > > + dom0_cfg.arch.ffa_enabled = true; > > AFAICT, ffa_enabled is a uint8_t. So we should use 1. However, I am not > convinced that using a uint8_t for what looks like a boolean is warrant. > I will detail more on the definition. OK > > > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > > > if ( iommu_enabled ) > > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > > new file mode 100644 > > index 000000000000..3117ce5cec4d > > --- /dev/null > > +++ b/xen/arch/arm/ffa.c > > @@ -0,0 +1,1683 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > > + * > > + * Copyright (C) 2022 Linaro Limited > > + * > > + * Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without restriction, > > + * including without limitation the rights to use, copy, modify, merge, > > + * publish, distribute, sublicense, and/or sell copies of the Software, > > + * and to permit persons to whom the Software is furnished to do so, > > + * subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > This doesn't look like to be a GPLv2 license. Can you clarify which > license you are using? I'll switch to the GPLv2 license to keep things simple. > > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +/* Error codes */ > > All the #define below are using hard tab. Please use soft tab. OK > > > +#define FFA_RET_OK 0 > > +#define FFA_RET_NOT_SUPPORTED -1 > > +#define FFA_RET_INVALID_PARAMETERS -2 > > +#define FFA_RET_NO_MEMORY -3 > > +#define FFA_RET_BUSY -4 > > +#define FFA_RET_INTERRUPTED -5 > > +#define FFA_RET_DENIED -6 > > +#define FFA_RET_RETRY -7 > > +#define FFA_RET_ABORTED -8 > > + > > +/* FFA_VERSION helpers */ > > +#define FFA_VERSION_MAJOR _AC(1,U) > > NIT: The use of _AC() is a bit pointless given that you are only use the > values in C code. OK, I'll drop the _AC() usage. > > > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > > +#define FFA_VERSION_MINOR _AC(1,U) > > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > > +#define MAKE_FFA_VERSION(major, minor) \ > > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > > + ((minor) & FFA_VERSION_MINOR_MASK)) > > + > > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > > + FFA_VERSION_MINOR) > > NIT: I think it would be better that FFA_VERSION_MAJOR AND > FFA_VERSION_MINOR are defined closer to FFA_MY_VERSION and they are > renamed to FFA_MY_VERSION_*. OK > > I would also potentially move the 3 defines past all the definition > related to the specification. This would make clearer that this is what > Xen supports. I couldn't find a good spot below so I'll add a comment here instead to make it more clear. > > > + > > + > > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) > > Coding style: You seem to use a mix of FOO(... , ...) and FOO(...,...). > At mimimum, please be consistent within the file. > > For Xen, we usually add a space after the comma. I'll do that. > > [...] > > > +/* > > + * Our rx/rx buffer shared with the SPMC > > + */ > > Hmmm... The comment seems to be misplaced. > > > +static uint32_t ffa_version; > > This probably can be __read_mostly. > > > +static uint16_t *subsr_vm_created; > > What subsr stand for? Subscribers. Not sure how I came to shorten it in that way, maybe I slipped on the keyboard :-). But it is a bit long to spell out. I'll add a comment. > > > +static unsigned int subsr_vm_created_count; > > +static uint16_t *subsr_vm_destroyed; > > +static unsigned int subsr_vm_destroyed_count; > > +static void *ffa_rx; > > +static void *ffa_tx; > > subsr_vm_created, subsr_vm_destroyed, ffa_rx and ffa_tx can probably be > __read_mostly. Agree, I'll fix. > > > +static unsigned int ffa_page_count; > > Is this related to ffa_rx? Yes, the number of pages used each by ffa_rx and ffa_tx. I'll add a comment. > > > +static DEFINE_SPINLOCK(ffa_buffer_lock); > > + > > +static LIST_HEAD(ffa_mem_list); > > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > > + > > +static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; > > next_handle only seems to be used handle_mem_share(). So I think it > would be better to move the definition (as static) within the function. > > This will reduce the number of global variables. OK > > > + > > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > > +{ > > + return (uint64_t)reg0 << 32 | reg1; > > +} > > + > > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > > + uint64_t val) > > +{ > > + *reg0 = val >> 32; > > + *reg1 = val; > > +} > > Those two functions are the same as optee.c but with a different. I > would rather prefer if we avoid the duplication and provide generic > helpers in a pre-requisite. These functions are trivial but at the same time for a special purpose which happens to coincide with the usage in optee.c. I can't find a suitable common .h file and creating a new one seems a bit much. > > > + > > +static bool ffa_get_version(uint32_t *vers) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_VERSION, .a1 = FFA_MY_VERSION, > > Coding sytle: Please set each field on their own line. OK > > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > > + { > > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > > + return false; > > + } > > + > > + *vers = resp.a0; > > Coding style: We tend to add a newline before the last return. I am not > necessarily going to comment about this on all the instances. So please > have a look through the code. OK > > > + return true; > > +} > > + > > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > > FFA_RET_* will be negative, so shouldn't this return int32_t? You're right, I'll update as needed. > > > +{ > > + switch ( resp->a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp->a2 ) > > + return resp->a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + return FFA_RET_OK; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_features(uint32_t id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_FEATURES, .a1 = id, }; > > Coding style. Please split each field on their own line. OK > > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static bool check_mandatory_feature(uint32_t id) > > +{ > > + uint32_t ret = ffa_features(id); > > + > > + if (ret) > > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); > > + return !ret; > > +} > > + > > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > > + uint32_t page_count) > > Aside the parameters, the helper looks very similar to ffa_features(), > ffa_rxtx_unmap(). Can this be abstracted? Maybe using macro if you still > want to have separate helper name. OK, I'll try something. > > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > +#ifdef CONFIG_ARM_64 > > + .a0 = FFA_RXTX_MAP_64, > > +#endif > > +#ifdef CONFIG_ARM_32 > > + .a0 = FFA_RXTX_MAP_32, > > +#endif > > + .a1 = tx_addr, .a2 = rx_addr, > > Coding: Please don't use hard tab and put each field on their own line. OK > > > + .a3 = page_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_RXTX_UNMAP, .a1 = vm_id, > > Coding style. Please add each field on their own line. OK > > > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_PARTITION_INFO_GET, .a1 = w1, .a2 = w2, .a3 = w3, .a4 = w4, > > Ditto. OK > > > + .a5 = w5, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + uint32_t ret; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + ret = get_ffa_ret_code(&resp); > > + if ( !ret ) > > + *count = resp.a2; > > + > > + return ret; > > +} > > + > > +static uint32_t ffa_rx_release(void) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_RX_RELEASE, }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > > + register_t addr, uint32_t pg_count, > > + uint64_t *handle) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_SHARE_32, .a1 = tot_len, .a2 = frag_len, .a3 = addr, > > Ditto. OK > > > + .a4 = pg_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + /* > > + * For arm64 we must use 64-bit calling convention if the buffer isn't > > + * passed in our tx buffer. > > + */ > > Can you explain why we would want to use the 32-bit calling convention > if addr is 0? I was trying to avoid the 64-bit calling convention where possible, but ffa_rxtx_map() still depends on 64-bit calling convention. So it's useless here, I'll remove that check. > > > + if (sizeof(addr) > 4 && addr) > > sizeof(addr) > 4 is a bit odd to read. I think it would be better to > check that CONFIG_ARM_64 is set (i.e. IS_ENABLED()). Thanks, I'll fix. > > > + arg.a0 = FFA_MEM_SHARE_64; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + *handle = reg_pair_to_64(resp.a3, resp.a2); > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + *handle = reg_pair_to_64(resp.a2, resp.a1); > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > > + uint16_t sender_id) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_FRAG_TX, .a1 = handle & UINT32_MAX, .a2 = handle >> 32, > > + .a3 = frag_len, .a4 = (uint32_t)sender_id << 16, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > > + uint32_t flags) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_RECLAIM, .a1 = handle_lo, .a2 = handle_hi, .a3 = flags, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > > OOI, why is this call returns int32_t when all the other use uint32_t > (even if may returned negative values)? I'll fix all those other functions. > > > + uint8_t msg) > > +{ > > + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; > > + int32_t res; > > + > > + if ( msg != FFA_MSG_SEND_VM_CREATED && msg !=FFA_MSG_SEND_VM_DESTROYED ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + if ( msg == FFA_MSG_SEND_VM_CREATED ) > > + exp_resp |= FFA_MSG_RESP_VM_CREATED; > > + else > > + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; > > NIT: I think it would be easier to read if you drop the first 'if' and > instead write: > > if ( msg == ..._CREATED ) > ... > else if ( msg == ..._DESTROYED ) > ... > else > return FFA_RET_INVALID_PARAMETERS. Thanks, I'll fix. > > > + > > + do { > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, > > + .a1 = sp_id, > > + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, > > + .a5 = vm_id, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) > > + { > > + /* > > + * This is an invalid response, likely due to some error in the > > + * implementation of the ABI. > > + */ > > + return FFA_RET_INVALID_PARAMETERS; > > + } > > + res = resp.a3; > > + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); > > + > > + return res; > > +} > > + > > +static u16 get_vm_id(struct domain *d) > > d is not meant to be modified by the helper. So please use 'const'. OK > > > +{ > > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > > + return d->domain_id + 1; > > +} > > + > > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > > + register_t v2, register_t v3, register_t v4, register_t v5, > > + register_t v6, register_t v7) > > +{ > > + set_user_reg(regs, 0, v0); > > + set_user_reg(regs, 1, v1); > > + set_user_reg(regs, 2, v2); > > + set_user_reg(regs, 3, v3); > > + set_user_reg(regs, 4, v4); > > + set_user_reg(regs, 5, v5); > > + set_user_reg(regs, 6, v6); > > + set_user_reg(regs, 7, v7); > > +} > > + > > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) > > +{ > > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > > + uint32_t w3) > > +{ > > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, > > + uint32_t handle_hi, uint32_t frag_offset, > > + uint16_t sender_id) > > +{ > > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > > + (uint32_t)sender_id << 16, 0, 0, 0); > > +} > > + > > +static void handle_version(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t vers = get_user_reg(regs, 1); > > + > > + if ( vers < FFA_VERSION_1_1 ) > > + vers = FFA_VERSION_1_0; > > + else > > + vers = FFA_VERSION_1_1; > > I find a bit strange to 'cap' the version provided by the user. Is this > part of the spec? Yes, it's part of the spec. The user supplies its version and we reply with the version closest to that which we can handle. Then we must remember that so we use the correct version of structs etc. > > > + > > + ctx->guest_vers = vers; > > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > > +} > > + > > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > > + register_t rx_addr, uint32_t page_count) > > Xen, Linux, and the firmware may use different page size. Below, you > seem to have the page size will always be 4KB. Is this guaranteed by the > spec? If not, how do all the 3 components agree on it? The page size is always 4KB, but the smallest memory unit may be larger, 16KB or 64KB if I remember correctly. > > If yes, then I think this should be written down and we should have a > BUILD_BUG_ON(PAGE_SIZE != SZ_4K). However, here I've assumed 4KB as the smallest memory unit so I'll add the BUILD_BUG_ON() for now. > > > +{ > > + uint32_t ret = FFA_RET_INVALID_PARAMETERS; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + struct page_info *tx_pg; > > + struct page_info *rx_pg; > > + p2m_type_t t; > > + void *rx; > > + void *tx; > > + > > + if ( !smccc_is_conv_64(fid) ) > > + { > > + tx_addr &= UINT32_MAX; > > + rx_addr &= UINT32_MAX; > > + } > > + > > + /* For now to keep things simple, only deal with a single page */ > > + if ( page_count != 1 ) > > + return FFA_RET_NOT_SUPPORTED; > > + > > + /* Already mapped */ > > + if ( ctx->rx ) > > + return FFA_RET_DENIED; > > + > > + tx_pg = get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + return FFA_RET_INVALID_PARAMETERS; > > + /* Only normal RAM for now */ > > This comment suggests the check below should be p2m_is_ram() but you are > using p2m_ram_rw. Thanks, I'll fix. > > > + if (t != p2m_ram_rw) > > Coding style: if ( ... ) OK > > > + goto err_put_tx_pg; > > + > > + rx_pg = get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + goto err_put_tx_pg; > > + /* Only normal RAM for now */ > > Same about the comment. OK > > > + if ( t != p2m_ram_rw ) > > + goto err_put_rx_pg; > > + > > + tx = /(tx_pg); > > + if ( !tx ) > > + goto err_put_rx_pg; > > + > > + rx = __map_domain_page_global(rx_pg); > > + if ( !rx ) > > + goto err_unmap_tx; > > + > > + ctx->rx = rx; > > + ctx->tx = tx; > > + ctx->rx_pg = rx_pg; > > + ctx->tx_pg = tx_pg; > > + ctx->page_count = 1; > > + ctx->tx_is_mine = true; > > + return FFA_RET_OK; > > + > > +err_unmap_tx: > > + unmap_domain_page_global(tx); > > +err_put_rx_pg: > > + put_page(rx_pg); > > +err_put_tx_pg: > > + put_page(tx_pg); > > + return ret; > > +} > > + > > +static uint32_t handle_rxtx_unmap(void) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t ret; > > + > > + if ( !ctx->rx ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + ret = ffa_rxtx_unmap(get_vm_id(d)); > > + if ( ret ) > > + return ret; > > + > > + unmap_domain_page_global(ctx->rx); > > + unmap_domain_page_global(ctx->tx); > > + put_page(ctx->rx_pg); > > + put_page(ctx->tx_pg); > > + ctx->rx = NULL; > > + ctx->tx = NULL; > > + ctx->rx_pg = NULL; > > + ctx->tx_pg = NULL; > > + ctx->page_count = 0; > > + ctx->tx_is_mine = false; > > + > > + return FFA_RET_OK; > > +} > > + > > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ffa_page_count ) > > + return FFA_RET_DENIED; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || !ctx->tx_is_mine ) > > + goto out; > > + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); > > + if ( ret ) > > + goto out; > > + if ( ctx->guest_vers == FFA_VERSION_1_0 ) > > + { > > + size_t n; > > + struct ffa_partition_info_1_1 *src = ffa_rx; > > + struct ffa_partition_info_1_0 *dst = ctx->rx; > > + > > + for ( n = 0; n < *count; n++ ) > > Who is going to sanitize 'count' and how do you make sure that... > > > + { > > + dst[n].id = src[n].id; > > ... this will still be written within the page provided by the domain? Good point, I'll add some checks. > > > + dst[n].execution_context = src[n].execution_context; > > + dst[n].partition_properties = src[n].partition_properties; > > + } > > + } > > + else > > + { > > + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); > > + > > + memcpy(ctx->rx, ffa_rx, sz); > > + } > > + ffa_rx_release(); > > I saw above that you are expecting the ffa_rx to be "locked". Will it be > the firmware to block another thread that may need ffa_rx? It's firmware (SPMC) which writes into ffa_rx. At the same time it's marking ffa_rx as used and will refuse another call which would also mark ffa_rx as used until ffa_rx_release() has been called. If another thread also tries to use ffa_rx before it has been released the SPMC will return FFA_RET_BUSY. So SPMC isn't blocking it's rather preventing another thread. I'll add a spinlock for the ffa_rx buffer too. > > > + ctx->tx_is_mine = false; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static uint32_t handle_rx_release(void) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || ctx->tx_is_mine ) > > + goto out; > > + ret = FFA_RET_OK; > > + ctx->tx_is_mine = true; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; > > + struct arm_smccc_1_2_regs resp = { }; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t src_dst; > > + uint64_t mask; > > + > > + if ( smccc_is_conv_64(fid) ) > > + mask = 0xffffffffffffffff; > > + else > > + mask = 0xffffffff; > > Please use GENMASK() (or similar). So it is easier to confirm the number > of 'f' is correct. OK > > > + > > + src_dst = get_user_reg(regs, 1); > > + if ( (src_dst >> 16) != get_vm_id(d) ) > > + { > > + resp.a0 = FFA_ERROR; > > + resp.a2 = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + arg.a1 = src_dst; > > + arg.a2 = get_user_reg(regs, 2) & mask; > > + arg.a3 = get_user_reg(regs, 3) & mask; > > + arg.a4 = get_user_reg(regs, 4) & mask; > > + arg.a5 = get_user_reg(regs, 5) & mask; > > + arg.a6 = get_user_reg(regs, 6) & mask; > > + arg.a7 = get_user_reg(regs, 7) & mask; > > + > > + while ( true ) > > + { > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_INTERRUPT: > > + ctx->interrupted = true; > > + goto out; > > + case FFA_ERROR: > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + case FFA_MSG_SEND_DIRECT_RESP_32: > > + case FFA_MSG_SEND_DIRECT_RESP_64: > > + goto out; > > + default: > > + /* Bad fid, report back. */ > > + memset(&arg, 0, sizeof(arg)); > > + arg.a0 = FFA_ERROR; > > + arg.a1 = src_dst; > > + arg.a2 = FFA_RET_NOT_SUPPORTED; > > + continue; > > + } > > + } > > + > > +out: > > + set_user_reg(regs, 0, resp.a0); > > + set_user_reg(regs, 1, resp.a1 & mask); > > + set_user_reg(regs, 2, resp.a2 & mask); > > + set_user_reg(regs, 3, resp.a3 & mask); > > + set_user_reg(regs, 4, resp.a4 & mask); > > + set_user_reg(regs, 5, resp.a5 & mask); > > + set_user_reg(regs, 6, resp.a6 & mask); > > + set_user_reg(regs, 7, resp.a7 & mask); > > You have already an helper to set all the registers. Why not using it? OK > > > +} > > I will continue the rest of the review at a later point. Thanks for reviewing this far. Cheers, Jens From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:18:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:18:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375028.607291 (Exim 4.92) (envelope-from ) id 1oGDu3-0003ik-EA; Tue, 26 Jul 2022 06:18:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375028.607291; Tue, 26 Jul 2022 06:18:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDu3-0003id-9M; Tue, 26 Jul 2022 06:18:47 +0000 Received: by outflank-mailman (input) for mailman id 375028; Tue, 26 Jul 2022 06:18:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDu1-0003iQ-Uv for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:18:45 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60059.outbound.protection.outlook.com [40.107.6.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cd2b43eb-0caa-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 08:18:44 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5460.eurprd04.prod.outlook.com (2603:10a6:208:11c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 06:18:42 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:18:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cd2b43eb-0caa-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PUbEgq+lrDm7rVqGNkVIwCJIMJnAcvd50zereRNB6k+bm9kMm4xMryedRN+EhpMg4zkVqYZ+/AzwJhPNkVKBd97JdQqEEJK/6QRlkLKe9YjnhW2owLqIRkxpMbxAqDG0ySYXjbzhn7dbPOTIUKEos08hO8U3d6YiZuvAC+Y/17zksyeomcNrLYsmRnL3q4/oCPHl64mQireqQHnCBHkwmzgPaHzXaot8t83BMho6gq5FhzS4KbXrK81XZ7kv4XXEofR5zhHMp7lGHatmFv+d31FjIDVioJqPqxCMNZncmcapaTG6pmwc7f5yylUxpnq9+AryOgaKDC1ujjvCfDfScQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y5RYujZgjFif6S3liLZhQ6lf2sa7uD/E+mHPZvCqGaw=; b=lto08I3xMkJ/LtBR/Y7B7VTs51JGuWH2PSzrR4DMaaRORyUp+BrA8XOZU2maOEC1d9vPqpoasbE32SNBO8gbljJdtu3r7ZbgTLiBcOBXN8Q+FMJM6B+2yvwLjPJ+EjeTiTleB/994pdegRaHm1UUuhtYNlM3FT+ZC1WGuMB10jf0TLPl0s1J8U7+0LB8PNVfiqHl71e4vW8wUhJX9NZgdjFVvcDyvu5YfJFyxb8XUhp7RvxoEHiw11GfygjVY7vPqNCuYqti1pVN5dlRUdqhS+CMdLGrkmVWx7XxJPbvB3agAnsDxemBFCwdaetdUrOsHR1HDbhbaCQ0HT+mVs0Rwg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y5RYujZgjFif6S3liLZhQ6lf2sa7uD/E+mHPZvCqGaw=; b=H0ubM6jiwTeypbRY9l3rqG+3cvNJYT2ZTIp/Y+FYqbscwUfeHrcZie+GxiCNmhSidk5ZDOpAbtB+Ks9gZe454kLkSmBfnc6suoPDwoygsU/rWKPwBWHipMCZiMuj/sr14U0OFcZ7Pxurf/eTmtC0sECB9VT1pZwcxrEwLEP0iXlLbg0eaLGk4cdrRofmC4Yspx2ysZPRhw1AOebaNaZBZ/N39fpPir7bny5j1Iqsd/DHs+5LVZgktIE+VKHlU/X6+Z+3+rNiLKC5X5DTR1ZWayoFZ8MSp0pmB0HO01d0vXd0SBr7hQl6IVgJrPv/pWzSzW+2DtTFH5SWJ+oxHWZkkw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <49d7ee9e-effd-6385-c46d-2218f84e6ba3@suse.com> Date: Tue, 26 Jul 2022 08:18:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability Content-Language: en-US To: =?UTF-8?Q?Marek_Marczykowski-G=c3=b3recki?= Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0036.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bde011f3-772a-4b5d-935d-08da6eceb037 X-MS-TrafficTypeDiagnostic: AM0PR04MB5460:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LVdUBLfJ6KMgsdOwDUW5NqzPpkcZvebRXzVE0qWVJOB8WWrhPgRxOKabAlt5MOYDXDbsJT6h4myxlV5kEfbbnqgWm+G64+FCdrOVwRBh3ehuRwU/43Md3tGrvIMyZDReGNW/1UFY1cUdKuTA07RPiJnPi9kysvFJ2X2M55TXZhBP84F6lHC5D3/5L41km3x3tvw6CqJdGmKpmpmFvFDX9vbRrmacJlvPM10Br0dCAsPPUNnpgw6mXkcEIkXOpVogDCJpFP7/R14WcBvjsELgArVmxRob6O8js4GY7NBRf6WOJCDKEVGglkqzGW15u27m2592AN7zwLVa49Y7xZlPFrA5oUy04rZBdZBZV4LRL2pPyAvp660Tzu9jVCJAx1+nUjbR+bME+IxwXK2KzbqJ6fdMyYzdmotM78IF2TDF0ev24L24Y8c1l0HlcG3ybdZWw1VvOPQIqtzgqq/pgJw892kofFPmj8MUsWoiIfF488sHZWxVsrX4zJInZYmQOUkvIdydjd3RKSa1Q+Zb9Sb8qGQST3zhmYfoIPWMGSl2wMNUN26NS4WrUaJi82jTremuShlVfxvMyFg3J5G+ygYFOegPQ9v1x2LcOXip/WPSL90AJBMk/3yHTmxzg1m3+bN/SqtDc5hrkA5HYNLK/1lTnggCfSzas/UjRxUftg02GUKLUCO2lTp5TVT4v+eVyIOOYP9eYVIq+4Kqw+SVlKA30kBWPuDk4zlQstNBFjpSN69OlaX4lnK8DbglH8ZOUXu7qIJWRvdIB2ed1uydr1rkgBCVhMeRsMElrFXXx+3InKml6L0GHoJyYqanQrP9RfxYaHmL9pEhdaMHrg8vxO+kGyP29vLezhdUL1woWscNEdI= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(346002)(396003)(376002)(136003)(2616005)(66574015)(66476007)(316002)(41300700001)(66946007)(4326008)(8676002)(26005)(5660300002)(186003)(31696002)(86362001)(36756003)(31686004)(66556008)(6512007)(6506007)(53546011)(8936002)(7416002)(83380400001)(38100700002)(2906002)(478600001)(6486002)(966005)(54906003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dllDdjdSM1VyczFmTUUxdlFWVXBjaE5KNkd2WHpyL0hpdjIzdlVZdElxTW8w?= =?utf-8?B?a1d5Qm5UMVo5VUJyOGRvSmZKbEJoYWxQRU9XZkxEcnVUMG8rOGZmRG9DOWZE?= =?utf-8?B?bVRpMWEwdXdmYnYybnBCOVZjMk1PM2lWU0hBTm5tZmRJbTNGOVl3NE1DTmk2?= =?utf-8?B?dXlaekF4UDczMkM4R0lkOEdSc0Y0T05kazZOYlV3TDNETTQxditNbGk4Y21O?= =?utf-8?B?K3BqYnFPZDVOcWdvTVRONmtWWU9nOHI0UlI5UU51OW9QcmtaNzVsQnhOSFlx?= =?utf-8?B?bk8zTXUvTGQyMVBCR3NMUDlqUlpMUnBZWVM5RFZkSmZJWkR2M1lxVVYyRTZY?= =?utf-8?B?NzcwWnk1Y3dsYVZxTHpJQ3FCdUdyWjdma1dYZ2lLRUNaVE5WUmRSRTJabExT?= =?utf-8?B?akxrdlA4c0x2ckQrQWVONm5SRnF6MmRJbVk4bzJhUVk0SVEwVWdOUy9uZmE2?= =?utf-8?B?TUZtQVVTWGJPUWxjN3AzYmI2VjdicFU5VTZJUmFzclBMOUx5SHdzcXZ3STRx?= =?utf-8?B?Q08zbHZaNGZDdnlKMkRidlMwdE5xRU9SR1A0T0phKy91V0hDNkVTMThEL21r?= =?utf-8?B?aWhXeXZrdlc2eGxxeWtad0FkcjJmWkNTenR4UzBuOVloUWFIOE1jb1Z2SnBG?= =?utf-8?B?bHVCM3Rvczk0UGNGUG1VVlh0WHRSSFdjcjNsSmNWOGw2NjlMdDNQWEZySXh3?= =?utf-8?B?UTZ5NVl5UGhVWGViNTltc3pweWZJY1QxYlpsc0RyMUQzUjdxRklHNHdhSitF?= =?utf-8?B?RHZPWmIvMjZ1dUV0dERqdmNLRXJEdytYOUpGbElQTjFBejc1ZlJEUmYzbHAx?= =?utf-8?B?Zi9qZkVsdTdrOXFnWGtyaDJ1WHk5RUtud3Q2MFM2Ly8xUW1YUjM4Y045blU4?= =?utf-8?B?eUlSZE9aSm5DN0hwKzBRcGtMeThBTURXWEpnK0VUOXVkUGtYbHA4R3BHRitH?= =?utf-8?B?OERrSTl4Z1JvK0N2a2JBWkphMG9EODBwSk9UbmcxZWRSR0dHb1NWMy9KaSt4?= =?utf-8?B?bG9pcWhQek9rNzVRa1Ixdms1Q2FXVmlZSUpUWjRDTFphVENPWkNmbjE3QTdC?= =?utf-8?B?VjRJODU3ZnNqRTRUam9mRm9vL2JIWlNiN1V3OXdhdDhyOVpTQm80TXVPRTg5?= =?utf-8?B?MHNhYWx6VmFuTXZDV2NjaTIzVzVKYzZlYnQ3c2x2TDF1TFV0Q2N6TU1sVnBF?= =?utf-8?B?bkpPK056TkdJZEEzMGozVGZUdU44bC8wSzBRWjBWUVNubzloYVNpbE42a1VF?= =?utf-8?B?QlM2RGplNkM5YUJBQXRwMUNFS3BuaXgxT0ZxZUM5QkJlZlRGRGFLSTlOWnFL?= =?utf-8?B?bEF1c2Q0RWFHOHdDYzNZMEJteEpYZDNCaUVWSlA2bFdUUkRuNnQzYzdqa1lr?= =?utf-8?B?Wm83WDl6K0c2K000QW5ueThnN25DL3dic3h6bnZ0Q1BwdVVENWU0VVhRdFIy?= =?utf-8?B?UXVHRlpTRnRQLzFRdjFKMDJlWGRVK29UTW9aelVpaG5KbVZuMzhMN05PV2Jm?= =?utf-8?B?bExzQWNGYWRPTGFPbi93ajVHS3ZyYkxPcTBieXpyVXlKMFBLeThwMVBMWEpH?= =?utf-8?B?azJqeVZqQTRkSmtVdVhnS0NZenl1dnA2czVhYktINHdCRjFkZ1MyNC93dTNu?= =?utf-8?B?c1RwMnpONXRIRzl2N1pXZG1TenJRNjZ0VzI4UncyVDJ1MnJFRm5YTGdQWHVH?= =?utf-8?B?WVFKSUdoeHVrNFFDRlM3ei9uMmlzZjRqdytHVjlpZUFCZXVpL0ZZdmdaa2lr?= =?utf-8?B?QnZxbWFZRm94U2g1Y0NlSWZLblhic0VxZFFjZGljNlVIM1h5bm5odUZoN0N0?= =?utf-8?B?UWxhQUZrK2xPYndWQklkSlZWeVZVWngxM1Q5U2RmSHBqcmhYM0tBMVNaMlcz?= =?utf-8?B?bHVRQno2Zk5zNHlsSncyUWZwRUlpTEVyeFRZRGdIMmFBakhUMnB4VzU3SzhN?= =?utf-8?B?bFpvUUZiKzhaemNwTzdGek42VlhHQ1JZSXdrOHcweUk2TUxjdGRQbHJGWGds?= =?utf-8?B?bnRUUGVhNm1tVGhYbDdPYm5KVm9FVTQ5Njd1alk5NXVmY0F5OWUvdGRqZlJT?= =?utf-8?B?RXBManJXbndXUVNKV2tvcnB0cHFYQjkvcjQ1djhEVnd2YVUyR2NHWUxlbjJ1?= =?utf-8?Q?gz5fY7yZ2zxbvWdg2H2cVm+jU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bde011f3-772a-4b5d-935d-08da6eceb037 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:18:42.6190 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j5ihkcC1xj7kcQGLnfdaV4EkQIARUVUjPmsSXkdZv68B3dZroJly7VclGiEi0EU7XANmZnOriIBl1GOkOcQPJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5460 On 26.07.2022 05:23, Marek Marczykowski-Górecki wrote: > This is integration of https://github.com/connojd/xue into mainline Xen. > This patch series includes several patches that I made in the process, some are > very loosely related. > > The driver developed by Connor supports console via USB3 debug capability. The > capability is designed to operate mostly independently of normal XHCI driver, > so this patch series allows dom0 to drive standard USB3 controller part, while > Xen uses DbC for console output. > > Changes since RFC: > - move the driver to xue.c, remove non-Xen parts, remove now unneeded abstraction > - adjust for Xen code style > - build for x86 only > - drop patch hidding the device from dom0 > Changes since v1: > - drop ehci patch - already applied > - adjust for review comments from Jan (see changelogs in individual patches) > Changes since v2: > - add runtime option to share (or not) the controller with dom0 or other domains > - add RX support > - several smaller changes according to review comments > > Cc: Andrew Cooper > Cc: George Dunlap > Cc: Jan Beulich > Cc: Julien Grall > Cc: Stefano Stabellini > Cc: Wei Liu > Cc: "Roger Pau Monné" > Cc: Paul Durrant > Cc: Kevin Tian > Cc: Connor Davis > > Connor Davis (1): > drivers/char: Add support for USB3 DbC debugger I notice this patch was sent twice, about 4 min ahead of the full set. I take it that the set having come close together is the definitive one, and that one extra copy is the one to be ignored. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.374767.607302 (Exim 4.92) (envelope-from ) id 1oGDut-0004IO-M9; Tue, 26 Jul 2022 06:19:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 374767.607302; Tue, 26 Jul 2022 06:19:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDut-0004IH-J7; Tue, 26 Jul 2022 06:19:39 +0000 Received: by outflank-mailman (input) for mailman id 374767; Mon, 25 Jul 2022 19:59:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oG4EV-0001OY-Ux for xen-devel@lists.xenproject.org; Mon, 25 Jul 2022 19:59:16 +0000 Received: from server.lespinasse.org (server.lespinasse.org [2001:470:82ab::100:0]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3fbd5d41-0c54-11ed-924f-1f966e50362f; Mon, 25 Jul 2022 21:59:12 +0200 (CEST) Received: by server.lespinasse.org (Postfix, from userid 1000) id D99501607CF; Mon, 25 Jul 2022 12:43:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3fbd5d41-0c54-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-78-ed; t=1658778186; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=G+HAStA9EHnsDI70V3dAV7pog8N1VgTExz3TxhNjpNA=; b=PUonlSYHBmxO3XTVIYRAd2vU3rmLOQyp6Sfrv1oYCByaa8fxeg5VfvvbOFafuKlR4pnlq /UEBminQTAvEphABA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-78-rsa; t=1658778186; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=G+HAStA9EHnsDI70V3dAV7pog8N1VgTExz3TxhNjpNA=; b=V2febsr7b9mkuWEe8ZOqoyPy0TuKQXQ7mM1Z2B6zBbFzk0TChXGE+rOfv88S7GjFAbKBd 1Y5YftvwaniQh9eKbf0Ah91pEKMK5D66+BdY4dngOb/MsV+G2V5lHMU/xCOUlm58RaY47ny JYEX/1abh0RbCF5ykXjZUuRPnqmpQQ3xMIfTQ9nxED7uHRn1NZNrHvhOQvlyhHv8qil084L M3vg6V7kmpSuI7sL2cdvGmoA4Yeg+eSENUTP+PqzHwMotIWas5LBMFudNeSBWD5cvfIWVkI zSeF604Trtoy2A9GA+rc10I0jVN9uBkbuRiA0FqqMO9Yj7igivtFamhkf7/A== Date: Mon, 25 Jul 2022 12:43:06 -0700 From: Michel Lespinasse To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220725194306.GA14746@lespinasse.org> References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: <20220608144516.172460444@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > Xeons") wrecked intel_idle in two ways: > > - must not have tracing in idle functions > - must return with IRQs disabled > > Additionally, it added a branch for no good reason. > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > Signed-off-by: Peter Zijlstra (Intel) After this change was introduced, I am seeing "WARNING: suspicious RCU usage" when booting a kernel with debug options compiled in. Please see the attached dmesg output. The issue starts with commit 32d4fd5751ea and is still present in v5.19-rc8. I'm not sure, is this too late to fix or revert in v5.19 final ? Thanks, -- Michel "walken" Lespinasse --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename=dmesg [ 0.000000] microcode: microcode updated early to revision 0x2006d05, date = 2021-11-13 [ 0.000000] Linux version 5.19.0-rc8-test-00003-ge3a8d97e6a35 (walken@zeus) (gcc (Debian 8.3.0-6) 8.3.0, GNU ld (GNU Binutils for Debian) 2.31.1) #1 SMP PREEMPT_DYNAMIC Mon Jul 25 00:32:16 PDT 2022 [ 0.000000] Command line: BOOT_IMAGE=/vmlinuz-5.19.0-rc8-test-00003-ge3a8d97e6a35 root=/dev/mapper/budai--vg-root ro consoleblank=600 quiet [ 0.000000] KERNEL supported cpus: [ 0.000000] Intel GenuineIntel [ 0.000000] AMD AuthenticAMD [ 0.000000] x86/fpu: Supporting XSAVE feature 0x001: 'x87 floating point registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x002: 'SSE registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x004: 'AVX registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x008: 'MPX bounds registers' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x010: 'MPX CSR' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x020: 'AVX-512 opmask' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x040: 'AVX-512 Hi256' [ 0.000000] x86/fpu: Supporting XSAVE feature 0x080: 'AVX-512 ZMM_Hi256' [ 0.000000] x86/fpu: xstate_offset[2]: 576, xstate_sizes[2]: 256 [ 0.000000] x86/fpu: xstate_offset[3]: 832, xstate_sizes[3]: 64 [ 0.000000] x86/fpu: xstate_offset[4]: 896, xstate_sizes[4]: 64 [ 0.000000] x86/fpu: xstate_offset[5]: 960, xstate_sizes[5]: 64 [ 0.000000] x86/fpu: xstate_offset[6]: 1024, xstate_sizes[6]: 512 [ 0.000000] x86/fpu: xstate_offset[7]: 1536, xstate_sizes[7]: 1024 [ 0.000000] x86/fpu: Enabled xstate features 0xff, context size is 2560 bytes, using 'compacted' format. [ 0.000000] signal: max sigframe size: 3632 [ 0.000000] BIOS-provided physical RAM map: [ 0.000000] BIOS-e820: [mem 0x0000000000000000-0x000000000003efff] usable [ 0.000000] BIOS-e820: [mem 0x000000000003f000-0x000000000003ffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000000040000-0x000000000009ffff] usable [ 0.000000] BIOS-e820: [mem 0x00000000000a0000-0x00000000000fffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000000100000-0x0000000062a8efff] usable [ 0.000000] BIOS-e820: [mem 0x0000000062a8f000-0x000000006aef4fff] reserved [ 0.000000] BIOS-e820: [mem 0x000000006aef5000-0x000000006b0c2fff] ACPI data [ 0.000000] BIOS-e820: [mem 0x000000006b0c3000-0x000000006be0dfff] ACPI NVS [ 0.000000] BIOS-e820: [mem 0x000000006be0e000-0x000000006c7f1fff] reserved [ 0.000000] BIOS-e820: [mem 0x000000006c7f2000-0x000000006c8e5fff] type 20 [ 0.000000] BIOS-e820: [mem 0x000000006c8e6000-0x000000006c8e6fff] reserved [ 0.000000] BIOS-e820: [mem 0x000000006c8e7000-0x000000006c9a7fff] type 20 [ 0.000000] BIOS-e820: [mem 0x000000006c9a8000-0x000000006e6fffff] usable [ 0.000000] BIOS-e820: [mem 0x000000006e700000-0x000000008fffffff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fd000000-0x00000000fe010fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fec00000-0x00000000fec00fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fed00000-0x00000000fed00fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fed20000-0x00000000fed44fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000fee00000-0x00000000fee00fff] reserved [ 0.000000] BIOS-e820: [mem 0x00000000ff000000-0x00000000ffffffff] reserved [ 0.000000] BIOS-e820: [mem 0x0000000100000000-0x000000107fffffff] usable [ 0.000000] NX (Execute Disable) protection: active [ 0.000000] efi: EFI v2.70 by American Megatrends [ 0.000000] efi: TPMFinalLog=0x6bd97000 ACPI=0x6b0c2000 ACPI 2.0=0x6b0c2014 SMBIOS=0x6c47b000 SMBIOS 3.0=0x6c47a000 MEMATTR=0x5d04d018 ESRT=0x604e0718 [ 0.000000] SMBIOS 3.0.0 present. [ 0.000000] DMI: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 0.000000] tsc: Detected 3700.000 MHz processor [ 0.000000] tsc: Detected 3699.850 MHz TSC [ 0.000278] e820: update [mem 0x00000000-0x00000fff] usable ==> reserved [ 0.000281] e820: remove [mem 0x000a0000-0x000fffff] usable [ 0.000289] last_pfn = 0x1080000 max_arch_pfn = 0x400000000 [ 0.000397] x86/PAT: Configuration [0-7]: WB WC UC- UC WB WP UC- WT [ 0.001626] e820: update [mem 0x7e000000-0xffffffff] usable ==> reserved [ 0.001632] last_pfn = 0x6e700 max_arch_pfn = 0x400000000 [ 0.007772] esrt: Reserving ESRT space from 0x00000000604e0718 to 0x00000000604e0778. [ 0.007776] e820: update [mem 0x604e0000-0x604e0fff] usable ==> reserved [ 0.118600] Secure boot could not be determined [ 0.118602] RAMDISK: [mem 0x3629b000-0x37144fff] [ 0.118605] ACPI: Early table checksum verification disabled [ 0.118608] ACPI: RSDP 0x000000006B0C2014 000024 (v02 LENOVO) [ 0.118612] ACPI: XSDT 0x000000006B0C1728 00013C (v01 LENOVO TC-S03 00001330 AMI 01000013) [ 0.118617] ACPI: FACP 0x000000006B0C0000 000114 (v06 LENOVO TC-S03 00001330 AMI 00010013) [ 0.118622] ACPI: DSDT 0x000000006AFFF000 0C0B0C (v02 LENOVO TC-S03 00001330 INTL 20160422) [ 0.118625] ACPI: FACS 0x000000006BD96000 000040 [ 0.118628] ACPI: FIDT 0x000000006AFFE000 00009C (v01 LENOVO TC-S03 00001330 AMI 00010013) [ 0.118631] ACPI: MCFG 0x000000006AFFD000 00003C (v01 LENOVO TC-S03 00001330 MSFT 00000097) [ 0.118634] ACPI: HPET 0x000000006AFFC000 000038 (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118637] ACPI: APIC 0x000000006AFFB000 00071E (v03 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118640] ACPI: MIGT 0x000000006AFFA000 000040 (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118643] ACPI: MSCT 0x000000006AFF9000 00004E (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118646] ACPI: PCAT 0x000000006AFF8000 000068 (v02 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118649] ACPI: PCCT 0x000000006AFF7000 00006E (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118652] ACPI: RASF 0x000000006AFF6000 000030 (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118655] ACPI: SLIT 0x000000006AFF5000 00006C (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118657] ACPI: SRAT 0x000000006AFF4000 000B70 (v03 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118660] ACPI: SVOS 0x000000006AFF3000 000032 (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118663] ACPI: WDDT 0x000000006AFF2000 000040 (v01 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118666] ACPI: OEM4 0x000000006AFC8000 029A72 (v02 INTEL CPU CST 00003000 INTL 20160422) [ 0.118669] ACPI: OEM1 0x000000006AFBD000 00ABCB (v02 INTEL CPU EIST 00003000 INTL 20160422) [ 0.118672] ACPI: OEM2 0x000000006AFAB000 011208 (v02 INTEL CPU HWP 00003000 INTL 20160422) [ 0.118675] ACPI: SSDT 0x000000006AF9D000 00D427 (v02 LENOVO TC-S03 00001330 INTL 20160422) [ 0.118678] ACPI: NITR 0x000000006AF9C000 000071 (v02 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118681] ACPI: LPIT 0x000000006AF9A000 000094 (v01 LENOVO TC-S03 00001330 MSFT 0000005F) [ 0.118684] ACPI: WDAT 0x000000006AF98000 000134 (v01 LENOVO TC-S03 00001330 MSFT 0000005F) [ 0.118687] ACPI: SSDT 0x000000006AF94000 003002 (v02 LENOVO TC-S03 00001330 INTL 20160422) [ 0.118690] ACPI: DBGP 0x000000006AF93000 000034 (v01 LENOVO TC-S03 00001330 MSFT 0000005F) [ 0.118693] ACPI: DBG2 0x000000006AF92000 000054 (v00 LENOVO TC-S03 00001330 MSFT 0000005F) [ 0.118696] ACPI: BGRT 0x000000006AF91000 000038 (v01 LENOVO TC-S03 00001330 AMI 00010013) [ 0.118699] ACPI: TPM2 0x000000006AF90000 00004C (v03 LENOVO TC-S03 00001330 AMI 00000000) [ 0.118701] ACPI: LUFT 0x000000006AF5B000 0349E2 (v01 LENOVO TC-S03 00001330 AMI 00010013) [ 0.118704] ACPI: HEST 0x000000006AF5A000 0000A8 (v01 LENOVO TC-S03 00001330 INTL 00000001) [ 0.118707] ACPI: BERT 0x000000006AF59000 000030 (v01 LENOVO TC-S03 00001330 INTL 00000001) [ 0.118710] ACPI: ERST 0x000000006AF58000 000230 (v01 LENOVO TC-S03 00001330 INTL 00000001) [ 0.118713] ACPI: EINJ 0x000000006AF57000 000150 (v01 LENOVO TC-S03 00001330 INTL 00000001) [ 0.118716] ACPI: ASF! 0x000000006AF56000 0000A0 (v32 LENOVO TC-S03 00001330 TFSM 000F4240) [ 0.118719] ACPI: WSMT 0x000000006AF99000 000028 (v01 LENOVO TC-S03 00001330 AMI 00010013) [ 0.118722] ACPI: SSDT 0x000000006AF9B000 000ACE (v02 LENOVO TC-S03 00001330 INTL 20091013) [ 0.118725] ACPI: FPDT 0x000000006AF54000 000044 (v01 LENOVO TC-S03 00001330 AMI 01000013) [ 0.118727] ACPI: Reserving FACP table memory at [mem 0x6b0c0000-0x6b0c0113] [ 0.118729] ACPI: Reserving DSDT table memory at [mem 0x6afff000-0x6b0bfb0b] [ 0.118730] ACPI: Reserving FACS table memory at [mem 0x6bd96000-0x6bd9603f] [ 0.118731] ACPI: Reserving FIDT table memory at [mem 0x6affe000-0x6affe09b] [ 0.118732] ACPI: Reserving MCFG table memory at [mem 0x6affd000-0x6affd03b] [ 0.118733] ACPI: Reserving HPET table memory at [mem 0x6affc000-0x6affc037] [ 0.118734] ACPI: Reserving APIC table memory at [mem 0x6affb000-0x6affb71d] [ 0.118735] ACPI: Reserving MIGT table memory at [mem 0x6affa000-0x6affa03f] [ 0.118736] ACPI: Reserving MSCT table memory at [mem 0x6aff9000-0x6aff904d] [ 0.118737] ACPI: Reserving PCAT table memory at [mem 0x6aff8000-0x6aff8067] [ 0.118737] ACPI: Reserving PCCT table memory at [mem 0x6aff7000-0x6aff706d] [ 0.118738] ACPI: Reserving RASF table memory at [mem 0x6aff6000-0x6aff602f] [ 0.118739] ACPI: Reserving SLIT table memory at [mem 0x6aff5000-0x6aff506b] [ 0.118740] ACPI: Reserving SRAT table memory at [mem 0x6aff4000-0x6aff4b6f] [ 0.118741] ACPI: Reserving SVOS table memory at [mem 0x6aff3000-0x6aff3031] [ 0.118742] ACPI: Reserving WDDT table memory at [mem 0x6aff2000-0x6aff203f] [ 0.118743] ACPI: Reserving OEM4 table memory at [mem 0x6afc8000-0x6aff1a71] [ 0.118744] ACPI: Reserving OEM1 table memory at [mem 0x6afbd000-0x6afc7bca] [ 0.118745] ACPI: Reserving OEM2 table memory at [mem 0x6afab000-0x6afbc207] [ 0.118746] ACPI: Reserving SSDT table memory at [mem 0x6af9d000-0x6afaa426] [ 0.118747] ACPI: Reserving NITR table memory at [mem 0x6af9c000-0x6af9c070] [ 0.118748] ACPI: Reserving LPIT table memory at [mem 0x6af9a000-0x6af9a093] [ 0.118749] ACPI: Reserving WDAT table memory at [mem 0x6af98000-0x6af98133] [ 0.118750] ACPI: Reserving SSDT table memory at [mem 0x6af94000-0x6af97001] [ 0.118751] ACPI: Reserving DBGP table memory at [mem 0x6af93000-0x6af93033] [ 0.118752] ACPI: Reserving DBG2 table memory at [mem 0x6af92000-0x6af92053] [ 0.118753] ACPI: Reserving BGRT table memory at [mem 0x6af91000-0x6af91037] [ 0.118754] ACPI: Reserving TPM2 table memory at [mem 0x6af90000-0x6af9004b] [ 0.118755] ACPI: Reserving LUFT table memory at [mem 0x6af5b000-0x6af8f9e1] [ 0.118756] ACPI: Reserving HEST table memory at [mem 0x6af5a000-0x6af5a0a7] [ 0.118757] ACPI: Reserving BERT table memory at [mem 0x6af59000-0x6af5902f] [ 0.118758] ACPI: Reserving ERST table memory at [mem 0x6af58000-0x6af5822f] [ 0.118759] ACPI: Reserving EINJ table memory at [mem 0x6af57000-0x6af5714f] [ 0.118760] ACPI: Reserving ASF! table memory at [mem 0x6af56000-0x6af5609f] [ 0.118760] ACPI: Reserving WSMT table memory at [mem 0x6af99000-0x6af99027] [ 0.118762] ACPI: Reserving SSDT table memory at [mem 0x6af9b000-0x6af9bacd] [ 0.118763] ACPI: Reserving FPDT table memory at [mem 0x6af54000-0x6af54043] [ 0.194241] Zone ranges: [ 0.194243] DMA [mem 0x0000000000001000-0x0000000000ffffff] [ 0.194245] DMA32 [mem 0x0000000001000000-0x00000000ffffffff] [ 0.194247] Normal [mem 0x0000000100000000-0x000000107fffffff] [ 0.194248] Movable zone start for each node [ 0.194249] Early memory node ranges [ 0.194250] node 0: [mem 0x0000000000001000-0x000000000003efff] [ 0.194251] node 0: [mem 0x0000000000040000-0x000000000009ffff] [ 0.194252] node 0: [mem 0x0000000000100000-0x0000000062a8efff] [ 0.194253] node 0: [mem 0x000000006c9a8000-0x000000006e6fffff] [ 0.194254] node 0: [mem 0x0000000100000000-0x000000107fffffff] [ 0.194258] Initmem setup node 0 [mem 0x0000000000001000-0x000000107fffffff] [ 0.194261] On node 0, zone DMA: 1 pages in unavailable ranges [ 0.194263] On node 0, zone DMA: 1 pages in unavailable ranges [ 0.194283] On node 0, zone DMA: 96 pages in unavailable ranges [ 0.196467] On node 0, zone DMA32: 40729 pages in unavailable ranges [ 0.272303] On node 0, zone Normal: 6400 pages in unavailable ranges [ 0.272414] ACPI: PM-Timer IO Port: 0x1808 [ 0.272422] ACPI: X2APIC_NMI (uid[0xffffffff] high level lint[0x1]) [ 0.272424] ACPI: LAPIC_NMI (acpi_id[0xff] high level lint[0x1]) [ 0.272453] IOAPIC[0]: apic_id 8, version 32, address 0xfec00000, GSI 0-23 [ 0.272458] IOAPIC[1]: apic_id 9, version 32, address 0xfec01000, GSI 24-31 [ 0.272463] IOAPIC[2]: apic_id 10, version 32, address 0xfec08000, GSI 32-39 [ 0.272467] IOAPIC[3]: apic_id 11, version 32, address 0xfec10000, GSI 40-47 [ 0.272471] IOAPIC[4]: apic_id 12, version 32, address 0xfec18000, GSI 48-55 [ 0.272474] ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl) [ 0.272475] ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level) [ 0.272480] ACPI: Using ACPI (MADT) for SMP configuration information [ 0.272482] ACPI: HPET id: 0x8086a701 base: 0xfed00000 [ 0.272485] TSC deadline timer available [ 0.272486] smpboot: Allowing 12 CPUs, 0 hotplug CPUs [ 0.272510] [mem 0x90000000-0xfcffffff] available for PCI devices [ 0.272513] clocksource: refined-jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645519600211568 ns [ 0.275727] setup_percpu: NR_CPUS:64 nr_cpumask_bits:64 nr_cpu_ids:12 nr_node_ids:1 [ 0.276015] percpu: Embedded 55 pages/cpu s187744 r8192 d29344 u262144 [ 0.276021] pcpu-alloc: s187744 r8192 d29344 u262144 alloc=1*2097152 [ 0.276023] pcpu-alloc: [0] 00 01 02 03 04 05 06 07 [0] 08 09 10 11 -- -- -- -- [ 0.276055] Built 1 zonelists, mobility grouping on. Total pages: 16403655 [ 0.276063] Kernel command line: BOOT_IMAGE=/vmlinuz-5.19.0-rc8-test-00003-ge3a8d97e6a35 root=/dev/mapper/budai--vg-root ro consoleblank=600 quiet [ 0.276122] Unknown kernel command line parameters "BOOT_IMAGE=/vmlinuz-5.19.0-rc8-test-00003-ge3a8d97e6a35", will be passed to user space. [ 0.279040] Dentry cache hash table entries: 8388608 (order: 14, 67108864 bytes, linear) [ 0.280503] Inode-cache hash table entries: 4194304 (order: 13, 33554432 bytes, linear) [ 0.280599] mem auto-init: stack:off, heap alloc:off, heap free:off [ 0.280600] Stack Depot early init allocating hash table with memblock_alloc, 8388608 bytes [ 0.674510] Memory: 65128856K/66657812K available (12295K kernel code, 3277K rwdata, 3732K rodata, 1600K init, 14120K bss, 1528696K reserved, 0K cma-reserved) [ 0.674513] ********************************************************** [ 0.674514] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ** [ 0.674514] ** ** [ 0.674515] ** This system shows unhashed kernel memory addresses ** [ 0.674515] ** via the console, logs, and other interfaces. This ** [ 0.674516] ** might reduce the security of your system. ** [ 0.674517] ** ** [ 0.674517] ** If you see this message and you are not debugging ** [ 0.674518] ** the kernel, report this immediately to your system ** [ 0.674518] ** administrator! ** [ 0.674519] ** ** [ 0.674519] ** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ** [ 0.674520] ********************************************************** [ 0.675102] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=12, Nodes=1 [ 0.675135] Kernel/User page tables isolation: enabled [ 0.675384] ftrace: allocating 35586 entries in 140 pages [ 0.681271] ftrace: allocated 140 pages with 3 groups [ 0.682664] Dynamic Preempt: voluntary [ 0.682867] Running RCU self tests [ 0.682876] rcu: Preemptible hierarchical RCU implementation. [ 0.682876] rcu: RCU lockdep checking is enabled. [ 0.682877] rcu: RCU restricting CPUs from NR_CPUS=64 to nr_cpu_ids=12. [ 0.682878] Trampoline variant of Tasks RCU enabled. [ 0.682879] Rude variant of Tasks RCU enabled. [ 0.682880] Tracing variant of Tasks RCU enabled. [ 0.682880] rcu: RCU calculated value of scheduler-enlistment delay is 25 jiffies. [ 0.682881] rcu: Adjusting geometry for rcu_fanout_leaf=16, nr_cpu_ids=12 [ 0.694108] NR_IRQS: 4352, nr_irqs: 1064, preallocated irqs: 16 [ 0.694404] rcu: srcu_init: Setting srcu_struct sizes based on contention. [ 0.694526] random: crng init done [ 0.694636] Console: colour dummy device 80x25 [ 0.694668] printk: console [tty0] enabled [ 0.694671] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar [ 0.694672] ... MAX_LOCKDEP_SUBCLASSES: 8 [ 0.694673] ... MAX_LOCK_DEPTH: 48 [ 0.694674] ... MAX_LOCKDEP_KEYS: 8192 [ 0.694675] ... CLASSHASH_SIZE: 4096 [ 0.694676] ... MAX_LOCKDEP_ENTRIES: 32768 [ 0.694676] ... MAX_LOCKDEP_CHAINS: 65536 [ 0.694677] ... CHAINHASH_SIZE: 32768 [ 0.694678] memory used by lock dependency info: 6365 kB [ 0.694679] memory used for stack traces: 4224 kB [ 0.694680] per task-struct memory footprint: 1920 bytes [ 0.694693] ACPI: Core revision 20220331 [ 0.696202] clocksource: hpet: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 79635855245 ns [ 0.696324] APIC: Switch to symmetric I/O mode setup [ 0.696609] x2apic: IRQ remapping doesn't support X2APIC mode [ 0.696681] Switched APIC routing to physical flat. [ 0.698015] ..TIMER: vector=0x30 apic1=0 pin1=2 apic2=-1 pin2=-1 [ 0.716231] clocksource: tsc-early: mask: 0xffffffffffffffff max_cycles: 0x6aa99074b1c, max_idle_ns: 881590506587 ns [ 0.716245] Calibrating delay loop (skipped), value calculated using timer frequency.. 7399.70 BogoMIPS (lpj=14799400) [ 0.716248] pid_max: default: 32768 minimum: 301 [ 0.733242] LSM: Security Framework initializing [ 0.733269] Yama: becoming mindful. [ 0.733430] AppArmor: AppArmor initialized [ 0.733636] Mount-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear) [ 0.733720] Mountpoint-cache hash table entries: 131072 (order: 8, 1048576 bytes, linear) [ 0.734821] CPU0: Thermal monitoring enabled (TM1) [ 0.734913] process: using mwait in idle threads [ 0.734915] Last level iTLB entries: 4KB 64, 2MB 8, 4MB 8 [ 0.734917] Last level dTLB entries: 4KB 64, 2MB 0, 4MB 0, 1GB 4 [ 0.734925] Spectre V1 : Mitigation: usercopy/swapgs barriers and __user pointer sanitization [ 0.734927] Spectre V2 : Mitigation: IBRS [ 0.734928] Spectre V2 : Spectre v2 / SpectreRSB mitigation: Filling RSB on context switch [ 0.734929] RETBleed: Mitigation: IBRS [ 0.734931] Spectre V2 : mitigation: Enabling conditional Indirect Branch Prediction Barrier [ 0.734932] Speculative Store Bypass: Mitigation: Speculative Store Bypass disabled via prctl [ 0.734948] MDS: Mitigation: Clear CPU buffers [ 0.734949] TAA: Mitigation: Clear CPU buffers [ 0.734949] MMIO Stale Data: Mitigation: Clear CPU buffers [ 0.747944] debug: unmapping init [mem 0xffffffffbaa2e000-0xffffffffbaa35fff] [ 0.748520] smpboot: CPU0: Intel(R) Xeon(R) W-2135 CPU @ 3.70GHz (family: 0x6, model: 0x55, stepping: 0x4) [ 0.749364] cblist_init_generic: Setting adjustable number of callback queues. [ 0.749380] cblist_init_generic: Setting shift to 4 and lim to 1. [ 0.749478] cblist_init_generic: Setting shift to 4 and lim to 1. [ 0.749570] cblist_init_generic: Setting shift to 4 and lim to 1. [ 0.749654] Running RCU-tasks wait API self tests [ 0.852469] Performance Events: PEBS fmt3+, Skylake events, 32-deep LBR, full-width counters, Intel PMU driver. [ 0.852601] ... version: 4 [ 0.852603] ... bit width: 48 [ 0.852605] ... generic registers: 4 [ 0.852606] ... value mask: 0000ffffffffffff [ 0.852608] ... max period: 00007fffffffffff [ 0.852609] ... fixed-purpose events: 3 [ 0.852611] ... event mask: 000000070000000f [ 0.852875] Estimated ratio of average max frequency by base frequency (times 1024): 1217 [ 0.853014] rcu: Hierarchical SRCU implementation. [ 0.853015] rcu: Max phase no-delay instances is 1000. [ 0.855147] NMI watchdog: Enabled. Permanently consumes one hw-PMU counter. [ 0.855959] smp: Bringing up secondary CPUs ... [ 0.856688] x86: Booting SMP configuration: [ 0.856693] .... node #0, CPUs: #1 #2 #3 [ 0.870268] Callback from call_rcu_tasks_trace() invoked. [ 0.870268] #4 #5 #6 [ 0.880500] MDS CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/mds.html for more details. [ 0.880500] TAA CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/tsx_async_abort.html for more details. [ 0.880500] MMIO Stale Data CPU bug present and SMT on, data leak possible. See https://www.kernel.org/doc/html/latest/admin-guide/hw-vuln/processor_mmio_stale_data.html for more details. [ 0.880909] #7 #8 #9 #10 #11 [ 0.888406] smp: Brought up 1 node, 12 CPUs [ 0.888406] smpboot: Max logical packages: 1 [ 0.888406] smpboot: Total of 12 processors activated (88796.40 BogoMIPS) [ 0.898028] devtmpfs: initialized [ 0.903767] DMA-API: preallocated 65536 debug entries [ 0.903771] DMA-API: debugging enabled by kernel config [ 0.903774] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [ 0.903786] futex hash table entries: 4096 (order: 7, 524288 bytes, linear) [ 0.904810] NET: Registered PF_NETLINK/PF_ROUTE protocol family [ 0.905930] audit: initializing netlink subsys (disabled) [ 0.905975] audit: type=2000 audit(1658734470.212:1): state=initialized audit_enabled=0 res=1 [ 0.905975] thermal_sys: Registered thermal governor 'fair_share' [ 0.905975] thermal_sys: Registered thermal governor 'step_wise' [ 0.905975] thermal_sys: Registered thermal governor 'user_space' [ 0.905975] thermal_sys: Registered thermal governor 'power_allocator' [ 0.905975] cpuidle: using governor menu [ 0.905975] Detected 1 PCC Subspaces [ 0.905975] Registering PCC driver as Mailbox controller [ 0.905975] HugeTLB: can optimize 4095 vmemmap pages for hugepages-1048576kB [ 0.905975] ACPI FADT declares the system doesn't support PCIe ASPM, so disable it [ 0.905975] PCI: MMCONFIG for domain 0000 [bus 00-ff] at [mem 0x80000000-0x8fffffff] (base 0x80000000) [ 0.905975] PCI: MMCONFIG at [mem 0x80000000-0x8fffffff] reserved in E820 [ 0.905975] pmd_set_huge: Cannot satisfy [mem 0x80000000-0x80200000] with a huge-page mapping due to MTRR override. [ 0.905975] PCI: Using configuration type 1 for base access [ 0.909880] ENERGY_PERF_BIAS: Set to 'normal', was 'performance' [ 0.927108] kprobes: kprobe jump-optimization is enabled. All kprobes are optimized if possible. [ 0.927129] HugeTLB: can optimize 7 vmemmap pages for hugepages-2048kB [ 0.927129] HugeTLB registered 1.00 GiB page size, pre-allocated 0 pages [ 0.927129] HugeTLB registered 2.00 MiB page size, pre-allocated 0 pages [ 0.928547] cryptd: max_cpu_qlen set to 1000 [ 0.928740] ACPI: Added _OSI(Module Device) [ 0.928743] ACPI: Added _OSI(Processor Device) [ 0.928746] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.928748] ACPI: Added _OSI(Processor Aggregator Device) [ 0.928758] ACPI: Added _OSI(Linux-Dell-Video) [ 0.928766] ACPI: Added _OSI(Linux-Lenovo-NV-HDMI-Audio) [ 0.928774] ACPI: Added _OSI(Linux-HPI-Hybrid-Graphics) [ 0.956903] Callback from call_rcu_tasks_rude() invoked. [ 1.639894] ACPI: 4 ACPI AML tables successfully acquired and loaded [ 1.794837] ACPI: Dynamic OEM Table Load: [ 1.951626] ACPI: Dynamic OEM Table Load: [ 2.126419] ACPI: Dynamic OEM Table Load: [ 3.004573] ACPI: Interpreter enabled [ 3.004632] ACPI: PM: (supports S0 S5) [ 3.004641] ACPI: Using IOAPIC for interrupt routing [ 3.005237] HEST: Table parsing has been initialized. [ 3.007163] GHES: APEI firmware first mode is enabled by APEI bit and WHEA _OSC. [ 3.007167] PCI: Using host bridge windows from ACPI; if necessary, use "pci=nocrs" and report a bug [ 3.007169] PCI: Using E820 reservations for host bridge windows [ 3.069726] ACPI: Enabled 8 GPEs in block 00 to 7F [ 3.570026] ACPI: PCI Root Bridge [PC00] (domain 0000 [bus 00-15]) [ 3.570053] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3] [ 3.571652] acpi PNP0A08:00: _OSC: platform does not support [AER LTR] [ 3.574618] acpi PNP0A08:00: _OSC: OS now controls [PME PCIeCapability] [ 3.574621] acpi PNP0A08:00: FADT indicates ASPM is unsupported, using BIOS configuration [ 3.578025] acpi PNP0A08:00: host bridge window expanded to [mem 0xfd000000-0xfe7fffff window]; [mem 0xfd000000-0xfe7fffff window] ignored [ 3.580936] PCI host bridge to bus 0000:00 [ 3.580942] pci_bus 0000:00: root bus resource [io 0x0000-0x0cf7 window] [ 3.580949] pci_bus 0000:00: root bus resource [io 0x1000-0x3fff window] [ 3.580954] pci_bus 0000:00: root bus resource [mem 0x000c4000-0x000c7fff window] [ 3.580960] pci_bus 0000:00: root bus resource [mem 0xfd000000-0xfe7fffff window] [ 3.580965] pci_bus 0000:00: root bus resource [mem 0x90000000-0xa33fffff window] [ 3.580971] pci_bus 0000:00: root bus resource [mem 0x40000000000-0x43fffffffff window] [ 3.580977] pci_bus 0000:00: root bus resource [bus 00-15] [ 3.581138] pci 0000:00:00.0: [8086:2020] type 00 class 0x060000 [ 3.581983] pci 0000:00:04.0: [8086:2021] type 00 class 0x088000 [ 3.582004] pci 0000:00:04.0: reg 0x10: [mem 0x43ffff2c000-0x43ffff2ffff 64bit] [ 3.582666] pci 0000:00:04.1: [8086:2021] type 00 class 0x088000 [ 3.582686] pci 0000:00:04.1: reg 0x10: [mem 0x43ffff28000-0x43ffff2bfff 64bit] [ 3.583378] pci 0000:00:04.2: [8086:2021] type 00 class 0x088000 [ 3.583398] pci 0000:00:04.2: reg 0x10: [mem 0x43ffff24000-0x43ffff27fff 64bit] [ 3.584070] pci 0000:00:04.3: [8086:2021] type 00 class 0x088000 [ 3.584090] pci 0000:00:04.3: reg 0x10: [mem 0x43ffff20000-0x43ffff23fff 64bit] [ 3.584745] pci 0000:00:04.4: [8086:2021] type 00 class 0x088000 [ 3.584765] pci 0000:00:04.4: reg 0x10: [mem 0x43ffff1c000-0x43ffff1ffff 64bit] [ 3.585443] pci 0000:00:04.5: [8086:2021] type 00 class 0x088000 [ 3.585463] pci 0000:00:04.5: reg 0x10: [mem 0x43ffff18000-0x43ffff1bfff 64bit] [ 3.586126] pci 0000:00:04.6: [8086:2021] type 00 class 0x088000 [ 3.586146] pci 0000:00:04.6: reg 0x10: [mem 0x43ffff14000-0x43ffff17fff 64bit] [ 3.586813] pci 0000:00:04.7: [8086:2021] type 00 class 0x088000 [ 3.586833] pci 0000:00:04.7: reg 0x10: [mem 0x43ffff10000-0x43ffff13fff 64bit] [ 3.587498] pci 0000:00:05.0: [8086:2024] type 00 class 0x088000 [ 3.588170] pci 0000:00:05.2: [8086:2025] type 00 class 0x088000 [ 3.588519] pci 0000:00:05.4: [8086:2026] type 00 class 0x080020 [ 3.588537] pci 0000:00:05.4: reg 0x10: [mem 0xa3324000-0xa3324fff] [ 3.588906] pci 0000:00:08.0: [8086:2014] type 00 class 0x088000 [ 3.589557] pci 0000:00:08.1: [8086:2015] type 00 class 0x110100 [ 3.589856] pci 0000:00:08.2: [8086:2016] type 00 class 0x088000 [ 3.590221] pci 0000:00:14.0: [8086:a2af] type 00 class 0x0c0330 [ 3.590252] pci 0000:00:14.0: reg 0x10: [mem 0x43ffff00000-0x43ffff0ffff 64bit] [ 3.590378] pci 0000:00:14.0: PME# supported from D3hot D3cold [ 3.593485] pci 0000:00:14.2: [8086:a2b1] type 00 class 0x118000 [ 3.593516] pci 0000:00:14.2: reg 0x10: [mem 0x43ffff33000-0x43ffff33fff 64bit] [ 3.594219] pci 0000:00:16.0: [8086:a2ba] type 00 class 0x078000 [ 3.594250] pci 0000:00:16.0: reg 0x10: [mem 0x43ffff32000-0x43ffff32fff 64bit] [ 3.594370] pci 0000:00:16.0: PME# supported from D3hot [ 3.594977] pci 0000:00:1d.0: [8086:a298] type 01 class 0x060400 [ 3.595111] pci 0000:00:1d.0: PME# supported from D0 D3hot D3cold [ 3.601892] pci 0000:00:1d.2: [8086:a29a] type 01 class 0x060400 [ 3.602032] pci 0000:00:1d.2: PME# supported from D0 D3hot D3cold [ 3.608943] pci 0000:00:1e.0: [8086:a2a7] type 00 class 0x118000 [ 3.609152] pci 0000:00:1e.0: reg 0x10: [mem 0x43ffff31000-0x43ffff31fff 64bit] [ 3.612199] pci 0000:00:1f.0: [8086:a2d3] type 00 class 0x060100 [ 3.614707] pci 0000:00:1f.2: [8086:a2a1] type 00 class 0x058000 [ 3.614727] pci 0000:00:1f.2: reg 0x10: [mem 0xa3320000-0xa3323fff] [ 3.617240] pci 0000:00:1f.4: [8086:a2a3] type 00 class 0x0c0500 [ 3.617299] pci 0000:00:1f.4: reg 0x10: [mem 0x43ffff30000-0x43ffff300ff 64bit] [ 3.617372] pci 0000:00:1f.4: reg 0x20: [io 0x3000-0x301f] [ 3.618036] pci 0000:00:1f.6: [8086:15b7] type 00 class 0x020000 [ 3.618066] pci 0000:00:1f.6: reg 0x10: [mem 0xa3300000-0xa331ffff] [ 3.618244] pci 0000:00:1f.6: PME# supported from D0 D3hot D3cold [ 3.620825] pci 0000:00:1d.0: PCI bridge to [bus 01] [ 3.621099] pci 0000:02:00.0: [12d8:e113] type 01 class 0x060400 [ 3.621183] pci 0000:02:00.0: enabling Extended Tags [ 3.621331] pci 0000:02:00.0: PME# supported from D0 D3hot D3cold [ 3.622040] pci 0000:00:1d.2: PCI bridge to [bus 02-03] [ 3.622099] pci_bus 0000:03: extended config space not accessible [ 3.622285] pci 0000:02:00.0: PCI bridge to [bus 03] [ 3.622330] pci_bus 0000:00: on NUMA node 0 [ 3.634450] ACPI: PCI Root Bridge [PC01] (domain 0000 [bus 16-63]) [ 3.634468] acpi PNP0A08:01: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3] [ 3.636259] acpi PNP0A08:01: _OSC: platform does not support [AER LTR] [ 3.639640] acpi PNP0A08:01: _OSC: OS now controls [PME PCIeCapability] [ 3.639642] acpi PNP0A08:01: FADT indicates ASPM is unsupported, using BIOS configuration [ 3.644870] PCI host bridge to bus 0000:16 [ 3.644877] pci_bus 0000:16: root bus resource [io 0x4000-0x7fff window] [ 3.644883] pci_bus 0000:16: root bus resource [mem 0xa3400000-0xbe3fffff window] [ 3.644888] pci_bus 0000:16: root bus resource [mem 0x44000000000-0x47fffffffff window] [ 3.644891] pci_bus 0000:16: root bus resource [bus 16-63] [ 3.644989] pci 0000:16:02.0: [8086:2032] type 01 class 0x060400 [ 3.645038] pci 0000:16:02.0: enabling Extended Tags [ 3.645125] pci 0000:16:02.0: PME# supported from D0 D3hot D3cold [ 3.645784] pci 0000:16:05.0: [8086:2034] type 00 class 0x088000 [ 3.646136] pci 0000:16:05.2: [8086:2035] type 00 class 0x088000 [ 3.646482] pci 0000:16:05.4: [8086:2036] type 00 class 0x080020 [ 3.646500] pci 0000:16:05.4: reg 0x10: [mem 0xbe300000-0xbe300fff] [ 3.646861] pci 0000:16:08.0: [8086:208d] type 00 class 0x088000 [ 3.647468] pci 0000:16:08.1: [8086:208d] type 00 class 0x088000 [ 3.647758] pci 0000:16:08.2: [8086:208d] type 00 class 0x088000 [ 3.648046] pci 0000:16:08.3: [8086:208d] type 00 class 0x088000 [ 3.648336] pci 0000:16:08.4: [8086:208d] type 00 class 0x088000 [ 3.648624] pci 0000:16:08.5: [8086:208d] type 00 class 0x088000 [ 3.648915] pci 0000:16:08.6: [8086:208d] type 00 class 0x088000 [ 3.649203] pci 0000:16:08.7: [8086:208d] type 00 class 0x088000 [ 3.649504] pci 0000:16:09.0: [8086:208d] type 00 class 0x088000 [ 3.650109] pci 0000:16:09.1: [8086:208d] type 00 class 0x088000 [ 3.650410] pci 0000:16:0e.0: [8086:208e] type 00 class 0x088000 [ 3.651007] pci 0000:16:0e.1: [8086:208e] type 00 class 0x088000 [ 3.651299] pci 0000:16:0e.2: [8086:208e] type 00 class 0x088000 [ 3.651582] pci 0000:16:0e.3: [8086:208e] type 00 class 0x088000 [ 3.651872] pci 0000:16:0e.4: [8086:208e] type 00 class 0x088000 [ 3.652159] pci 0000:16:0e.5: [8086:208e] type 00 class 0x088000 [ 3.652451] pci 0000:16:0e.6: [8086:208e] type 00 class 0x088000 [ 3.652737] pci 0000:16:0e.7: [8086:208e] type 00 class 0x088000 [ 3.653026] pci 0000:16:0f.0: [8086:208e] type 00 class 0x088000 [ 3.653638] pci 0000:16:0f.1: [8086:208e] type 00 class 0x088000 [ 3.653946] pci 0000:16:1d.0: [8086:2054] type 00 class 0x088000 [ 3.654546] pci 0000:16:1d.1: [8086:2055] type 00 class 0x088000 [ 3.654835] pci 0000:16:1d.2: [8086:2056] type 00 class 0x088000 [ 3.655122] pci 0000:16:1d.3: [8086:2057] type 00 class 0x088000 [ 3.655413] pci 0000:16:1e.0: [8086:2080] type 00 class 0x088000 [ 3.656023] pci 0000:16:1e.1: [8086:2081] type 00 class 0x088000 [ 3.656314] pci 0000:16:1e.2: [8086:2082] type 00 class 0x088000 [ 3.656604] pci 0000:16:1e.3: [8086:2083] type 00 class 0x088000 [ 3.656897] pci 0000:16:1e.4: [8086:2084] type 00 class 0x088000 [ 3.657186] pci 0000:16:1e.5: [8086:2085] type 00 class 0x088000 [ 3.657478] pci 0000:16:1e.6: [8086:2086] type 00 class 0x088000 [ 3.658060] pci 0000:17:00.0: [144d:a808] type 00 class 0x010802 [ 3.658089] pci 0000:17:00.0: reg 0x10: [mem 0xbe200000-0xbe203fff 64bit] [ 3.658949] pci 0000:16:02.0: PCI bridge to [bus 17] [ 3.658954] pci 0000:16:02.0: bridge window [mem 0xbe200000-0xbe2fffff] [ 3.658971] pci_bus 0000:16: on NUMA node 0 [ 3.660567] ACPI: PCI Root Bridge [PC02] (domain 0000 [bus 64-b1]) [ 3.660584] acpi PNP0A08:02: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3] [ 3.662395] acpi PNP0A08:02: _OSC: platform does not support [AER LTR] [ 3.665795] acpi PNP0A08:02: _OSC: OS now controls [PME PCIeCapability] [ 3.665798] acpi PNP0A08:02: FADT indicates ASPM is unsupported, using BIOS configuration [ 3.670594] PCI host bridge to bus 0000:64 [ 3.670600] pci_bus 0000:64: root bus resource [mem 0x000a0000-0x000bffff window] [ 3.670606] pci_bus 0000:64: root bus resource [io 0x8000-0xbfff window] [ 3.670611] pci_bus 0000:64: root bus resource [io 0x03b0-0x03bb window] [ 3.670617] pci_bus 0000:64: root bus resource [io 0x03c0-0x03df window] [ 3.670625] pci_bus 0000:64: root bus resource [mem 0xbe400000-0xe0ffffff window] [ 3.670631] pci_bus 0000:64: root bus resource [mem 0x48000000000-0x4bfffffffff window] [ 3.670634] pci_bus 0000:64: root bus resource [bus 64-b1] [ 3.670724] pci 0000:64:00.0: [8086:2030] type 01 class 0x060400 [ 3.670852] pci 0000:64:00.0: PME# supported from D0 D3hot D3cold [ 3.671509] pci 0000:64:05.0: [8086:2034] type 00 class 0x088000 [ 3.671859] pci 0000:64:05.2: [8086:2035] type 00 class 0x088000 [ 3.672203] pci 0000:64:05.4: [8086:2036] type 00 class 0x080020 [ 3.672221] pci 0000:64:05.4: reg 0x10: [mem 0xe0100000-0xe0100fff] [ 3.672586] pci 0000:64:08.0: [8086:2066] type 00 class 0x088000 [ 3.673250] pci 0000:64:09.0: [8086:2066] type 00 class 0x088000 [ 3.673907] pci 0000:64:0a.0: [8086:2040] type 00 class 0x088000 [ 3.674560] pci 0000:64:0a.1: [8086:2041] type 00 class 0x088000 [ 3.674898] pci 0000:64:0a.2: [8086:2042] type 00 class 0x088000 [ 3.675227] pci 0000:64:0a.3: [8086:2043] type 00 class 0x088000 [ 3.675561] pci 0000:64:0a.4: [8086:2044] type 00 class 0x088000 [ 3.675899] pci 0000:64:0a.5: [8086:2045] type 00 class 0x088000 [ 3.676231] pci 0000:64:0a.6: [8086:2046] type 00 class 0x088000 [ 3.676562] pci 0000:64:0a.7: [8086:2047] type 00 class 0x088000 [ 3.676894] pci 0000:64:0b.0: [8086:2048] type 00 class 0x088000 [ 3.677548] pci 0000:64:0b.1: [8086:2049] type 00 class 0x088000 [ 3.677889] pci 0000:64:0b.2: [8086:204a] type 00 class 0x088000 [ 3.678218] pci 0000:64:0b.3: [8086:204b] type 00 class 0x088000 [ 3.678557] pci 0000:64:0c.0: [8086:2040] type 00 class 0x088000 [ 3.679201] pci 0000:64:0c.1: [8086:2041] type 00 class 0x088000 [ 3.679537] pci 0000:64:0c.2: [8086:2042] type 00 class 0x088000 [ 3.679874] pci 0000:64:0c.3: [8086:2043] type 00 class 0x088000 [ 3.680207] pci 0000:64:0c.4: [8086:2044] type 00 class 0x088000 [ 3.680539] pci 0000:64:0c.5: [8086:2045] type 00 class 0x088000 [ 3.680874] pci 0000:64:0c.6: [8086:2046] type 00 class 0x088000 [ 3.681215] pci 0000:64:0c.7: [8086:2047] type 00 class 0x088000 [ 3.681555] pci 0000:64:0d.0: [8086:2048] type 00 class 0x088000 [ 3.682197] pci 0000:64:0d.1: [8086:2049] type 00 class 0x088000 [ 3.682536] pci 0000:64:0d.2: [8086:204a] type 00 class 0x088000 [ 3.682866] pci 0000:64:0d.3: [8086:204b] type 00 class 0x088000 [ 3.683510] pci 0000:65:00.0: [10de:1cb1] type 00 class 0x030000 [ 3.683533] pci 0000:65:00.0: reg 0x10: [mem 0xdf000000-0xdfffffff] [ 3.683553] pci 0000:65:00.0: reg 0x14: [mem 0xc0000000-0xcfffffff 64bit pref] [ 3.683573] pci 0000:65:00.0: reg 0x1c: [mem 0xd0000000-0xd1ffffff 64bit pref] [ 3.683587] pci 0000:65:00.0: reg 0x24: [io 0xb000-0xb07f] [ 3.683601] pci 0000:65:00.0: reg 0x30: [mem 0xe0000000-0xe007ffff pref] [ 3.683689] pci 0000:65:00.0: BAR 1: assigned to efifb [ 3.683812] pci 0000:65:00.0: 32.000 Gb/s available PCIe bandwidth, limited by 2.5 GT/s PCIe x16 link at 0000:64:00.0 (capable of 126.016 Gb/s with 8.0 GT/s PCIe x16 link) [ 3.684420] pci 0000:65:00.1: [10de:0fb9] type 00 class 0x040300 [ 3.684439] pci 0000:65:00.1: reg 0x10: [mem 0xe0080000-0xe0083fff] [ 3.684914] pci 0000:64:00.0: PCI bridge to [bus 65] [ 3.684918] pci 0000:64:00.0: bridge window [io 0xb000-0xbfff] [ 3.684922] pci 0000:64:00.0: bridge window [mem 0xdf000000-0xe00fffff] [ 3.684926] pci 0000:64:00.0: bridge window [mem 0xc0000000-0xd1ffffff 64bit pref] [ 3.684940] pci_bus 0000:64: on NUMA node 0 [ 3.686316] ACPI: PCI Root Bridge [PC03] (domain 0000 [bus b2-ff]) [ 3.686332] acpi PNP0A08:03: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI HPX-Type3] [ 3.688137] acpi PNP0A08:03: _OSC: platform does not support [AER LTR] [ 3.691526] acpi PNP0A08:03: _OSC: OS now controls [PME PCIeCapability] [ 3.691528] acpi PNP0A08:03: FADT indicates ASPM is unsupported, using BIOS configuration [ 3.696303] PCI host bridge to bus 0000:b2 [ 3.696310] pci_bus 0000:b2: root bus resource [io 0xc000-0xffff window] [ 3.696316] pci_bus 0000:b2: root bus resource [mem 0xe1000000-0xfbffffff window] [ 3.696321] pci_bus 0000:b2: root bus resource [mem 0x4c000000000-0x4ffffffffff window] [ 3.696324] pci_bus 0000:b2: root bus resource [bus b2-ff] [ 3.696416] pci 0000:b2:00.0: [8086:2030] type 01 class 0x060400 [ 3.696467] pci 0000:b2:00.0: enabling Extended Tags [ 3.696552] pci 0000:b2:00.0: PME# supported from D0 D3hot D3cold [ 3.697209] pci 0000:b2:05.0: [8086:2034] type 00 class 0x088000 [ 3.697564] pci 0000:b2:05.2: [8086:2035] type 00 class 0x088000 [ 3.697907] pci 0000:b2:05.4: [8086:2036] type 00 class 0x080020 [ 3.697925] pci 0000:b2:05.4: reg 0x10: [mem 0xfbf00000-0xfbf00fff] [ 3.698300] pci 0000:b2:12.0: [8086:204c] type 00 class 0x110100 [ 3.698940] pci 0000:b2:12.1: [8086:204d] type 00 class 0x110100 [ 3.699233] pci 0000:b2:12.2: [8086:204e] type 00 class 0x088000 [ 3.699528] pci 0000:b2:15.0: [8086:2018] type 00 class 0x088000 [ 3.700142] pci 0000:b2:16.0: [8086:2018] type 00 class 0x088000 [ 3.700749] pci 0000:b2:16.4: [8086:2018] type 00 class 0x088000 [ 3.701314] pci 0000:b2:00.0: PCI bridge to [bus b3] [ 3.701333] pci_bus 0000:b2: on NUMA node 0 [ 3.703967] ACPI: PCI: Interrupt link LNKA configured for IRQ 11 [ 3.704806] ACPI: PCI: Interrupt link LNKB configured for IRQ 10 [ 3.705619] ACPI: PCI: Interrupt link LNKC configured for IRQ 11 [ 3.706427] ACPI: PCI: Interrupt link LNKD configured for IRQ 11 [ 3.707234] ACPI: PCI: Interrupt link LNKE configured for IRQ 11 [ 3.708040] ACPI: PCI: Interrupt link LNKF configured for IRQ 11 [ 3.708849] ACPI: PCI: Interrupt link LNKG configured for IRQ 11 [ 3.709659] ACPI: PCI: Interrupt link LNKH configured for IRQ 15 [ 3.712367] iommu: Default domain type: Translated [ 3.712369] iommu: DMA domain TLB invalidation policy: lazy mode [ 3.713049] SCSI subsystem initialized [ 3.713147] libata version 3.00 loaded. [ 3.713346] ACPI: bus type USB registered [ 3.713526] usbcore: registered new interface driver usbfs [ 3.713614] usbcore: registered new interface driver hub [ 3.713681] usbcore: registered new device driver usb [ 3.713821] EDAC MC: Ver: 3.0.0 [ 3.716473] Registered efivars operations [ 3.716473] PCI: Using ACPI for IRQ routing [ 3.722717] PCI: pci_cache_line_size set to 64 bytes [ 3.722899] e820: reserve RAM buffer [mem 0x0003f000-0x0003ffff] [ 3.722914] e820: reserve RAM buffer [mem 0x604e0000-0x63ffffff] [ 3.722920] e820: reserve RAM buffer [mem 0x62a8f000-0x63ffffff] [ 3.722926] e820: reserve RAM buffer [mem 0x6e700000-0x6fffffff] [ 3.725276] hpet0: at MMIO 0xfed00000, IRQs 2, 8, 0, 0, 0, 0, 0, 0 [ 3.725291] hpet0: 8 comparators, 64-bit 24.000000 MHz counter [ 3.729573] clocksource: Switched to clocksource tsc-early [ 3.730662] VFS: Disk quotas dquot_6.6.0 [ 3.730718] VFS: Dquot-cache hash table entries: 512 (order 0, 4096 bytes) [ 3.732169] AppArmor: AppArmor Filesystem Enabled [ 3.732169] pnp: PnP ACPI init [ 3.783368] system 00:01: [io 0x0500-0x05fe] has been reserved [ 3.783387] system 00:01: [io 0x0400-0x047f] could not be reserved [ 3.783397] system 00:01: [io 0x0600-0x061f] has been reserved [ 3.783406] system 00:01: [io 0x0ca0-0x0ca5] has been reserved [ 3.783415] system 00:01: [io 0x0880-0x0883] has been reserved [ 3.783423] system 00:01: [io 0x0800-0x081f] has been reserved [ 3.783440] system 00:01: [mem 0xfed1c000-0xfed3ffff] could not be reserved [ 3.783466] system 00:01: [mem 0xfed45000-0xfed8bfff] has been reserved [ 3.783476] system 00:01: [mem 0xff000000-0xffffffff] has been reserved [ 3.783490] system 00:01: [mem 0xfee00000-0xfeefffff] could not be reserved [ 3.783500] system 00:01: [mem 0xfed12000-0xfed1200f] has been reserved [ 3.783510] system 00:01: [mem 0xfed12010-0xfed1201f] has been reserved [ 3.783519] system 00:01: [mem 0xfed1b000-0xfed1bfff] has been reserved [ 3.785913] system 00:02: [io 0x0a00-0x0a0f] has been reserved [ 3.785927] system 00:02: [io 0x0a10-0x0a1f] has been reserved [ 3.785936] system 00:02: [io 0x0a20-0x0a2f] has been reserved [ 3.789763] system 00:03: [io 0x0a20-0x0a2f] has been reserved [ 3.790576] system 00:04: [mem 0xfd000000-0xfdabffff] has been reserved [ 3.790587] system 00:04: [mem 0xfdad0000-0xfdadffff] has been reserved [ 3.790601] system 00:04: [mem 0xfdb00000-0xfdffffff] could not be reserved [ 3.790611] system 00:04: [mem 0xfe000000-0xfe00ffff] has been reserved [ 3.790621] system 00:04: [mem 0xfe011000-0xfe01ffff] has been reserved [ 3.790630] system 00:04: [mem 0xfe036000-0xfe03bfff] has been reserved [ 3.790640] system 00:04: [mem 0xfe03d000-0xfe3fffff] has been reserved [ 3.790650] system 00:04: [mem 0xfe410000-0xfe7fffff] has been reserved [ 3.792356] system 00:05: [io 0x0f00-0x0ffe] has been reserved [ 3.792359] Callback from call_rcu_tasks() invoked. [ 3.804833] system 00:06: [mem 0xfdaf0000-0xfdafffff] has been reserved [ 3.804845] system 00:06: [mem 0xfdae0000-0xfdaeffff] has been reserved [ 3.804855] system 00:06: [mem 0xfdac0000-0xfdacffff] has been reserved [ 3.815354] pnp: PnP ACPI: found 7 devices [ 3.831021] clocksource: acpi_pm: mask: 0xffffff max_cycles: 0xffffff, max_idle_ns: 2085701024 ns [ 3.831205] NET: Registered PF_INET protocol family [ 3.831487] IP idents hash table entries: 262144 (order: 9, 2097152 bytes, linear) [ 3.834382] tcp_listen_portaddr_hash hash table entries: 32768 (order: 9, 2359296 bytes, linear) [ 3.835017] Table-perturb hash table entries: 65536 (order: 6, 262144 bytes, linear) [ 3.835141] TCP established hash table entries: 524288 (order: 10, 4194304 bytes, linear) [ 3.835545] TCP bind hash table entries: 65536 (order: 10, 4718592 bytes, vmalloc hugepage) [ 3.836824] TCP: Hash tables configured (established 524288 bind 65536) [ 3.837174] UDP hash table entries: 32768 (order: 10, 5242880 bytes, vmalloc hugepage) [ 3.838508] UDP-Lite hash table entries: 32768 (order: 10, 5242880 bytes, vmalloc hugepage) [ 3.840096] NET: Registered PF_UNIX/PF_LOCAL protocol family [ 3.840147] pci 0000:00:1d.0: bridge window [io 0x1000-0x0fff] to [bus 01] add_size 1000 [ 3.840155] pci 0000:00:1d.0: bridge window [mem 0x00100000-0x000fffff 64bit pref] to [bus 01] add_size 200000 add_align 100000 [ 3.840162] pci 0000:00:1d.0: bridge window [mem 0x00100000-0x000fffff] to [bus 01] add_size 200000 add_align 100000 [ 3.840189] clipped [mem size 0x00004000] to [mem size 0xfffffffffffc8000] for e820 entry [mem 0x000a0000-0x000fffff] [ 3.840201] pci 0000:00:1d.0: BAR 14: assigned [mem 0x90000000-0x901fffff] [ 3.840205] clipped [mem size 0x00000000 64bit pref] to [mem size 0xfffffffffffc4000 64bit pref] for e820 entry [mem 0x000a0000-0x000fffff] [ 3.840210] pci 0000:00:1d.0: BAR 15: assigned [mem 0x40000000000-0x400001fffff 64bit pref] [ 3.840216] pci 0000:00:1d.0: BAR 13: assigned [io 0x1000-0x1fff] [ 3.840248] pci 0000:00:1d.0: PCI bridge to [bus 01] [ 3.840251] pci 0000:00:1d.0: bridge window [io 0x1000-0x1fff] [ 3.840259] pci 0000:00:1d.0: bridge window [mem 0x90000000-0x901fffff] [ 3.840265] pci 0000:00:1d.0: bridge window [mem 0x40000000000-0x400001fffff 64bit pref] [ 3.840276] pci 0000:02:00.0: PCI bridge to [bus 03] [ 3.840302] pci 0000:00:1d.2: PCI bridge to [bus 02-03] [ 3.840323] pci_bus 0000:00: resource 4 [io 0x0000-0x0cf7 window] [ 3.840325] pci_bus 0000:00: resource 5 [io 0x1000-0x3fff window] [ 3.840327] pci_bus 0000:00: resource 6 [mem 0x000c4000-0x000c7fff window] [ 3.840329] pci_bus 0000:00: resource 7 [mem 0xfd000000-0xfe7fffff window] [ 3.840331] pci_bus 0000:00: resource 8 [mem 0x90000000-0xa33fffff window] [ 3.840333] pci_bus 0000:00: resource 9 [mem 0x40000000000-0x43fffffffff window] [ 3.840335] pci_bus 0000:01: resource 0 [io 0x1000-0x1fff] [ 3.840337] pci_bus 0000:01: resource 1 [mem 0x90000000-0x901fffff] [ 3.840339] pci_bus 0000:01: resource 2 [mem 0x40000000000-0x400001fffff 64bit pref] [ 3.841375] pci 0000:16:02.0: PCI bridge to [bus 17] [ 3.841383] pci 0000:16:02.0: bridge window [mem 0xbe200000-0xbe2fffff] [ 3.841398] pci_bus 0000:16: resource 4 [io 0x4000-0x7fff window] [ 3.841400] pci_bus 0000:16: resource 5 [mem 0xa3400000-0xbe3fffff window] [ 3.841402] pci_bus 0000:16: resource 6 [mem 0x44000000000-0x47fffffffff window] [ 3.841404] pci_bus 0000:17: resource 1 [mem 0xbe200000-0xbe2fffff] [ 3.841655] pci 0000:64:00.0: PCI bridge to [bus 65] [ 3.841658] pci 0000:64:00.0: bridge window [io 0xb000-0xbfff] [ 3.841665] pci 0000:64:00.0: bridge window [mem 0xdf000000-0xe00fffff] [ 3.841671] pci 0000:64:00.0: bridge window [mem 0xc0000000-0xd1ffffff 64bit pref] [ 3.841682] pci_bus 0000:64: resource 4 [mem 0x000a0000-0x000bffff window] [ 3.841684] pci_bus 0000:64: resource 5 [io 0x8000-0xbfff window] [ 3.841686] pci_bus 0000:64: resource 6 [io 0x03b0-0x03bb window] [ 3.841688] pci_bus 0000:64: resource 7 [io 0x03c0-0x03df window] [ 3.841690] pci_bus 0000:64: resource 8 [mem 0xbe400000-0xe0ffffff window] [ 3.841692] pci_bus 0000:64: resource 9 [mem 0x48000000000-0x4bfffffffff window] [ 3.841694] pci_bus 0000:65: resource 0 [io 0xb000-0xbfff] [ 3.841696] pci_bus 0000:65: resource 1 [mem 0xdf000000-0xe00fffff] [ 3.841698] pci_bus 0000:65: resource 2 [mem 0xc0000000-0xd1ffffff 64bit pref] [ 3.841880] pci 0000:b2:00.0: PCI bridge to [bus b3] [ 3.841899] pci_bus 0000:b2: resource 4 [io 0xc000-0xffff window] [ 3.841901] pci_bus 0000:b2: resource 5 [mem 0xe1000000-0xfbffffff window] [ 3.841903] pci_bus 0000:b2: resource 6 [mem 0x4c000000000-0x4ffffffffff window] [ 3.845645] pci 0000:16:05.0: disabled boot interrupts on device [8086:2034] [ 3.845709] pci 0000:17:00.0: CLS mismatch (64 != 32), using 64 bytes [ 3.845715] pci 0000:64:05.0: disabled boot interrupts on device [8086:2034] [ 3.846039] pci 0000:65:00.1: D0 power state depends on 0000:65:00.0 [ 3.846068] pci 0000:b2:05.0: disabled boot interrupts on device [8086:2034] [ 3.846219] PCI-DMA: Using software bounce buffering for IO (SWIOTLB) [ 3.846221] software IO TLB: mapped [mem 0x000000005904d000-0x000000005d04d000] (64MB) [ 3.846703] Unpacking initramfs... [ 3.864401] RAPL PMU: API unit is 2^-32 Joules, 2 fixed counters, 655360 ms ovfl timer [ 3.864405] RAPL PMU: hw unit of domain package 2^-14 Joules [ 3.864407] RAPL PMU: hw unit of domain dram 2^-16 Joules [ 3.876379] workingset: timestamp_bits=46 max_order=24 bucket_order=0 [ 3.908228] NET: Registered PF_ALG protocol family [ 3.908349] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252) [ 3.908558] io scheduler mq-deadline registered [ 3.908917] cryptomgr_test (104) used greatest stack depth: 14576 bytes left [ 3.912953] pcieport 0000:00:1d.0: PME: Signaling with IRQ 24 [ 3.915186] pcieport 0000:00:1d.2: PME: Signaling with IRQ 25 [ 3.917945] pcieport 0000:16:02.0: PME: Signaling with IRQ 27 [ 3.919998] pcieport 0000:64:00.0: PME: Signaling with IRQ 29 [ 3.921814] pcieport 0000:b2:00.0: PME: Signaling with IRQ 31 [ 3.923560] Monitor-Mwait will be used to enter C-1 state [ 3.923585] Monitor-Mwait will be used to enter C-2 state [ 3.923599] ACPI: \_SB_.SCK0.CP00: Found 2 idle states [ 3.928506] input: Sleep Button as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0C0E:00/input/input0 [ 3.928555] ACPI: button: Sleep Button [SLPB] [ 3.928964] input: Power Button as /devices/LNXSYSTM:00/LNXPWRBN:00/input/input1 [ 3.928974] ACPI: button: Power Button [PWRF] [ 3.944003] ERST: Error Record Serialization Table (ERST) support is initialized. [ 3.944059] pstore: Registered erst as persistent store backend [ 3.946100] Serial: 8250/16550 driver, 4 ports, IRQ sharing disabled [ 3.948521] AMD-Vi: AMD IOMMUv2 functionality not available on this system - This is not a bug. [ 3.956270] nvme nvme0: pci function 0000:17:00.0 [ 3.958564] e1000e: Intel(R) PRO/1000 Network Driver [ 3.958566] e1000e: Copyright(c) 1999 - 2015 Intel Corporation. [ 3.960404] e1000e 0000:00:1f.6: Interrupt Throttling Rate (ints/sec) set to dynamic conservative mode [ 3.965082] nvme nvme0: Shutdown timeout set to 8 seconds [ 3.972253] ------------[ cut here ]------------ [ 3.972255] ============================= [ 3.972255] WARNING: suspicious RCU usage [ 3.972256] 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 Not tainted [ 3.972257] ----------------------------- [ 3.972257] include/trace/events/lock.h:48 suspicious rcu_dereference_check() usage! [ 3.972258] other info that might help us debug this: [ 3.972258] rcu_scheduler_active = 2, debug_locks = 1 [ 3.972259] RCU used illegally from extended quiescent state! [ 3.972260] no locks held by swapper/0/0. [ 3.972261] stack backtrace: [ 3.972261] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 [ 3.972263] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.972264] Call Trace: [ 3.972265] [ 3.972267] dump_stack_lvl+0x44/0x5b [ 3.972273] lock_acquire.cold.74+0x1f/0x24 [ 3.972286] _raw_spin_lock_irqsave+0x38/0x60 [ 3.972290] ? down_trylock+0xf/0x40 [ 3.972296] down_trylock+0xf/0x40 [ 3.972298] ? vprintk_emit+0x7b/0x2c0 [ 3.972301] __down_trylock_console_sem+0x23/0x90 [ 3.972304] console_trylock+0x13/0x70 [ 3.972306] vprintk_emit+0x7b/0x2c0 [ 3.972314] _printk+0x58/0x73 [ 3.972324] ? rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972325] report_bug.cold.2+0xc/0x4c [ 3.972331] handle_bug+0x3f/0x70 [ 3.972335] exc_invalid_op+0x13/0x60 [ 3.972339] asm_exc_invalid_op+0x16/0x20 [ 3.972341] RIP: 0010:rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972343] Code: 12 ba 48 8b 83 40 01 00 00 48 85 c0 74 20 48 83 c0 01 48 89 83 40 01 00 00 5b c3 cc cc cc cc 65 8b 05 8c 48 63 46 85 c0 74 c2 <0f> 0b eb be e8 93 ff ff ff 48 83 bb 48 01 00 00 00 8b 83 50 01 00 [ 3.972344] RSP: 0000:ffffffffba203e28 EFLAGS: 00010002 [ 3.972346] RAX: 0000000000000001 RBX: ffffd358bfa07010 RCX: 0000000000000001 [ 3.972347] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001 [ 3.972348] RBP: 0000000000000001 R08: ffffffffffc40c55 R09: 000000000002be80 [ 3.972349] R10: 000004b18007d4f2 R11: ffff9f467802b7a4 R12: ffffffffba4a9d80 [ 3.972349] R13: ffffffffba4a9d00 R14: 0000000000000001 R15: 0000000000000000 [ 3.972367] cpuidle_enter_state+0x2f4/0x4b0 [ 3.972375] cpuidle_enter+0x29/0x40 [ 3.972378] do_idle+0x1d8/0x210 [ 3.972385] cpu_startup_entry+0x19/0x20 [ 3.972387] rest_init+0x117/0x1a0 [ 3.972390] arch_call_rest_init+0xa/0x14 [ 3.972394] start_kernel+0x6d8/0x703 [ 3.972402] secondary_startup_64_no_verify+0xce/0xdb [ 3.972421] [ 3.972422] ============================= [ 3.972422] WARNING: suspicious RCU usage [ 3.972422] 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 Not tainted [ 3.972423] ----------------------------- [ 3.972423] include/trace/events/lock.h:74 suspicious rcu_dereference_check() usage! [ 3.972424] other info that might help us debug this: [ 3.972424] rcu_scheduler_active = 2, debug_locks = 1 [ 3.972425] RCU used illegally from extended quiescent state! [ 3.972425] 1 lock held by swapper/0/0: [ 3.972426] #0: ffffffffba420cd8 ((console_sem).lock){....}-{2:2}, at: down_trylock+0xf/0x40 [ 3.972430] stack backtrace: [ 3.972431] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 [ 3.972432] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.972433] Call Trace: [ 3.972433] [ 3.972434] dump_stack_lvl+0x44/0x5b [ 3.972438] lock_release.cold.73+0x1f/0x24 [ 3.972446] _raw_spin_unlock_irqrestore+0x1b/0x60 [ 3.972450] down_trylock+0x25/0x40 [ 3.972453] ? vprintk_emit+0x7b/0x2c0 [ 3.972454] __down_trylock_console_sem+0x23/0x90 [ 3.972457] console_trylock+0x13/0x70 [ 3.972460] vprintk_emit+0x7b/0x2c0 [ 3.972468] _printk+0x58/0x73 [ 3.972478] ? rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972479] report_bug.cold.2+0xc/0x4c [ 3.972485] handle_bug+0x3f/0x70 [ 3.972488] exc_invalid_op+0x13/0x60 [ 3.972492] asm_exc_invalid_op+0x16/0x20 [ 3.972493] RIP: 0010:rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972495] Code: 12 ba 48 8b 83 40 01 00 00 48 85 c0 74 20 48 83 c0 01 48 89 83 40 01 00 00 5b c3 cc cc cc cc 65 8b 05 8c 48 63 46 85 c0 74 c2 <0f> 0b eb be e8 93 ff ff ff 48 83 bb 48 01 00 00 00 8b 83 50 01 00 [ 3.972496] RSP: 0000:ffffffffba203e28 EFLAGS: 00010002 [ 3.972497] RAX: 0000000000000001 RBX: ffffd358bfa07010 RCX: 0000000000000001 [ 3.972498] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001 [ 3.972499] RBP: 0000000000000001 R08: ffffffffffc40c55 R09: 000000000002be80 [ 3.972499] R10: 000004b18007d4f2 R11: ffff9f467802b7a4 R12: ffffffffba4a9d80 [ 3.972500] R13: ffffffffba4a9d00 R14: 0000000000000001 R15: 0000000000000000 [ 3.972519] cpuidle_enter_state+0x2f4/0x4b0 [ 3.972526] cpuidle_enter+0x29/0x40 [ 3.972529] do_idle+0x1d8/0x210 [ 3.972536] cpu_startup_entry+0x19/0x20 [ 3.972538] rest_init+0x117/0x1a0 [ 3.972541] arch_call_rest_init+0xa/0x14 [ 3.972542] start_kernel+0x6d8/0x703 [ 3.972551] secondary_startup_64_no_verify+0xce/0xdb [ 3.972569] [ 3.972577] WARNING: CPU: 0 PID: 0 at kernel/rcu/tree.c:864 rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972580] Modules linked in: [ 3.972582] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 [ 3.972584] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.972585] RIP: 0010:rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972587] Code: 12 ba 48 8b 83 40 01 00 00 48 85 c0 74 20 48 83 c0 01 48 89 83 40 01 00 00 5b c3 cc cc cc cc 65 8b 05 8c 48 63 46 85 c0 74 c2 <0f> 0b eb be e8 93 ff ff ff 48 83 bb 48 01 00 00 00 8b 83 50 01 00 [ 3.972588] RSP: 0000:ffffffffba203e28 EFLAGS: 00010002 [ 3.972591] RAX: 0000000000000001 RBX: ffffd358bfa07010 RCX: 0000000000000001 [ 3.972592] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001 [ 3.972593] RBP: 0000000000000001 R08: ffffffffffc40c55 R09: 000000000002be80 [ 3.972595] R10: 000004b18007d4f2 R11: ffff9f467802b7a4 R12: ffffffffba4a9d80 [ 3.972596] R13: ffffffffba4a9d00 R14: 0000000000000001 R15: 0000000000000000 [ 3.972598] FS: 0000000000000000(0000) GS:ffff9f4678000000(0000) knlGS:0000000000000000 [ 3.972599] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 3.972601] CR2: ffff9f46b81ff000 CR3: 0000000c6d212001 CR4: 00000000003706f0 [ 3.972603] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 3.972604] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 3.972605] Call Trace: [ 3.972607] [ 3.972608] cpuidle_enter_state+0x2f4/0x4b0 [ 3.972616] cpuidle_enter+0x29/0x40 [ 3.972620] do_idle+0x1d8/0x210 [ 3.972627] cpu_startup_entry+0x19/0x20 [ 3.972630] rest_init+0x117/0x1a0 [ 3.972633] arch_call_rest_init+0xa/0x14 [ 3.972635] start_kernel+0x6d8/0x703 [ 3.972644] secondary_startup_64_no_verify+0xce/0xdb [ 3.972662] [ 3.972663] irq event stamp: 196057 [ 3.972664] hardirqs last enabled at (196057): [] asm_sysvec_apic_timer_interrupt+0x16/0x20 [ 3.972667] hardirqs last disabled at (196055): [] __do_softirq+0x3f4/0x49c [ 3.972669] softirqs last enabled at (196056): [] __do_softirq+0x332/0x49c [ 3.972671] softirqs last disabled at (196045): [] irq_exit_rcu+0xaf/0xf0 [ 3.972674] ---[ end trace 0000000000000000 ]--- [ 3.972676] ============================= [ 3.972677] WARNING: suspicious RCU usage [ 3.972678] 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 Not tainted [ 3.972679] ----------------------------- [ 3.972680] include/trace/events/error_report.h:71 suspicious rcu_dereference_check() usage! [ 3.972682] other info that might help us debug this: [ 3.972683] rcu_scheduler_active = 2, debug_locks = 1 [ 3.972684] RCU used illegally from extended quiescent state! [ 3.972685] no locks held by swapper/0/0. [ 3.972686] stack backtrace: [ 3.972687] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 [ 3.972689] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.972690] Call Trace: [ 3.972691] [ 3.972693] dump_stack_lvl+0x44/0x5b [ 3.972697] __warn.cold.12+0x105/0x107 [ 3.972700] ? rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972705] report_bug+0xc1/0x100 [ 3.972713] handle_bug+0x3f/0x70 [ 3.972716] exc_invalid_op+0x13/0x60 [ 3.972721] asm_exc_invalid_op+0x16/0x20 [ 3.972722] RIP: 0010:rcu_eqs_exit.constprop.87+0x54/0xa0 [ 3.972724] Code: 12 ba 48 8b 83 40 01 00 00 48 85 c0 74 20 48 83 c0 01 48 89 83 40 01 00 00 5b c3 cc cc cc cc 65 8b 05 8c 48 63 46 85 c0 74 c2 <0f> 0b eb be e8 93 ff ff ff 48 83 bb 48 01 00 00 00 8b 83 50 01 00 [ 3.972726] RSP: 0000:ffffffffba203e28 EFLAGS: 00010002 [ 3.972728] RAX: 0000000000000001 RBX: ffffd358bfa07010 RCX: 0000000000000001 [ 3.972730] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000001 [ 3.972731] RBP: 0000000000000001 R08: ffffffffffc40c55 R09: 000000000002be80 [ 3.972732] R10: 000004b18007d4f2 R11: ffff9f467802b7a4 R12: ffffffffba4a9d80 [ 3.972734] R13: ffffffffba4a9d00 R14: 0000000000000001 R15: 0000000000000000 [ 3.972752] cpuidle_enter_state+0x2f4/0x4b0 [ 3.972759] cpuidle_enter+0x29/0x40 [ 3.972763] do_idle+0x1d8/0x210 [ 3.972770] cpu_startup_entry+0x19/0x20 [ 3.972773] rest_init+0x117/0x1a0 [ 3.972776] arch_call_rest_init+0xa/0x14 [ 3.972778] start_kernel+0x6d8/0x703 [ 3.972787] secondary_startup_64_no_verify+0xce/0xdb [ 3.972805] [ 3.972807] ------------[ cut here ]------------ [ 3.972808] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x2b/0x60 [ 3.972811] Modules linked in: [ 3.972813] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 5.19.0-rc8-test-00003-ge3a8d97e6a35 #1 [ 3.972815] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.972817] RIP: 0010:sched_clock_tick+0x2b/0x60 [ 3.972818] Code: eb 06 5b c3 cc cc cc cc 66 90 8b 05 fb 48 40 01 85 c0 74 18 65 8b 05 ec 10 ef 46 85 c0 75 0d 65 8b 05 35 0e ef 46 85 c0 74 02 <0f> 0b e8 fe cb 8b 00 48 c7 c3 40 d5 02 00 89 c0 48 03 1c c5 c0 98 [ 3.972820] RSP: 0000:ffffffffba203e28 EFLAGS: 00010002 [ 3.972823] RAX: 0000000000000001 RBX: ffffd358bfa07010 RCX: 0000000000000001 [ 3.972824] RDX: 0000000000000000 RSI: ffffffffba08e941 RDI: ffffffffba09b733 [ 3.972825] RBP: 0000000000000001 R08: ffffffffffc40c55 R09: 000000000002be80 [ 3.972827] R10: 000004b18007d4f2 R11: ffff9f467802b7a4 R12: ffffffffba4a9d80 [ 3.972829] R13: ffffffffba4a9d00 R14: 0000000000000001 R15: 0000000000000000 [ 3.972830] FS: 0000000000000000(0000) GS:ffff9f4678000000(0000) knlGS:0000000000000000 [ 3.972832] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 3.972834] CR2: ffff9f46b81ff000 CR3: 0000000c6d212001 CR4: 00000000003706f0 [ 3.972835] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 3.972837] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 3.972838] Call Trace: [ 3.972839] [ 3.972841] cpuidle_enter_state+0xb7/0x4b0 [ 3.972849] cpuidle_enter+0x29/0x40 [ 3.972853] do_idle+0x1d8/0x210 [ 3.972860] cpu_startup_entry+0x19/0x20 [ 3.972862] rest_init+0x117/0x1a0 [ 3.972866] arch_call_rest_init+0xa/0x14 [ 3.972868] start_kernel+0x6d8/0x703 [ 3.972876] secondary_startup_64_no_verify+0xce/0xdb [ 3.972893] [ 3.972895] irq event stamp: 196057 [ 3.972896] hardirqs last enabled at (196057): [] asm_sysvec_apic_timer_interrupt+0x16/0x20 [ 3.972898] hardirqs last disabled at (196055): [] __do_softirq+0x3f4/0x49c [ 3.972900] softirqs last enabled at (196056): [] __do_softirq+0x332/0x49c [ 3.972903] softirqs last disabled at (196045): [] irq_exit_rcu+0xaf/0xf0 [ 3.972905] ---[ end trace 0000000000000000 ]--- [ 3.978985] nvme nvme0: 12/0/0 default/read/poll queues [ 3.991754] nvme0n1: p1 p2 p3 [ 4.042581] debug: unmapping init [mem 0xffff9f367629b000-0xffff9f3677144fff] [ 4.104839] e1000e 0000:00:1f.6 eth0: (PCI Express:2.5GT/s:Width x1) a4:ae:11:14:fc:bd [ 4.104844] e1000e 0000:00:1f.6 eth0: Intel(R) PRO/1000 Network Connection [ 4.104949] e1000e 0000:00:1f.6 eth0: MAC: 12, PHY: 12, PBA No: FFFFFF-0FF [ 4.105276] ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver [ 4.105278] ehci-pci: EHCI PCI platform driver [ 4.107288] xhci_hcd 0000:00:14.0: xHCI Host Controller [ 4.107396] xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 1 [ 4.108843] xhci_hcd 0000:00:14.0: hcc params 0x200077c1 hci version 0x100 quirks 0x0000000000009810 [ 4.110564] xhci_hcd 0000:00:14.0: xHCI Host Controller [ 4.110587] xhci_hcd 0000:00:14.0: new USB bus registered, assigned bus number 2 [ 4.110599] xhci_hcd 0000:00:14.0: Host supports USB 3.0 SuperSpeed [ 4.111029] usb usb1: New USB device found, idVendor=1d6b, idProduct=0002, bcdDevice= 5.19 [ 4.111035] usb usb1: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 4.111038] usb usb1: Product: xHCI Host Controller [ 4.111040] usb usb1: Manufacturer: Linux 5.19.0-rc8-test-00003-ge3a8d97e6a35 xhci-hcd [ 4.111042] usb usb1: SerialNumber: 0000:00:14.0 [ 4.112211] hub 1-0:1.0: USB hub found [ 4.112314] hub 1-0:1.0: 16 ports detected [ 4.161426] usb usb2: New USB device found, idVendor=1d6b, idProduct=0003, bcdDevice= 5.19 [ 4.161430] usb usb2: New USB device strings: Mfr=3, Product=2, SerialNumber=1 [ 4.161433] usb usb2: Product: xHCI Host Controller [ 4.161435] usb usb2: Manufacturer: Linux 5.19.0-rc8-test-00003-ge3a8d97e6a35 xhci-hcd [ 4.161437] usb usb2: SerialNumber: 0000:00:14.0 [ 4.162266] hub 2-0:1.0: USB hub found [ 4.162323] hub 2-0:1.0: 10 ports detected [ 4.196355] mousedev: PS/2 mouse device common for all mice [ 4.196802] rtc_cmos 00:00: RTC can wake from S4 [ 4.197938] rtc_cmos 00:00: registered as rtc0 [ 4.198087] rtc_cmos 00:00: setting system clock to 2022-07-25T07:34:33 UTC (1658734473) [ 4.198237] rtc_cmos 00:00: alarms up to one month, y3k, 114 bytes nvram, hpet irqs [ 4.200008] i801_smbus 0000:00:1f.4: SPD Write Disable is set [ 4.200105] i801_smbus 0000:00:1f.4: SMBus using PCI interrupt [ 4.241068] i2c i2c-0: 4/8 memory slots populated (from DMI) [ 4.241071] i2c i2c-0: Systems with more than 4 memory slots not supported yet, not instantiating SPD [ 4.245778] device-mapper: ioctl: 4.46.0-ioctl (2022-02-22) initialised: dm-devel@redhat.com [ 4.246751] EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0: DEV 0000:64:0a.0 (INTERRUPT) [ 4.247229] EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1: DEV 0000:64:0c.0 (INTERRUPT) [ 4.247235] intel_pstate: Intel P-state driver initializing [ 4.249932] intel_pstate: HWP enabled [ 4.254032] efifb: probing for efifb [ 4.254118] efifb: framebuffer at 0xc0000000, using 9600k, total 9600k [ 4.254121] efifb: mode is 1920x1200x32, linelength=8192, pages=1 [ 4.254123] efifb: scrolling: redraw [ 4.254124] efifb: Truecolor: size=8:8:8:8, shift=24:16:8:0 [ 4.255002] Console: switching to colour frame buffer device 240x75 [ 4.258668] fb0: EFI VGA frame buffer device [ 4.258716] EFI Variables Facility v0.08 2004-May-17 [ 4.289201] pstore: ignoring unexpected backend 'efi' [ 4.289327] hid: raw HID events driver (C) Jiri Kosina [ 4.289510] usbcore: registered new interface driver usbhid [ 4.289512] usbhid: USB HID core driver [ 4.291432] NET: Registered PF_INET6 protocol family [ 4.294216] Segment Routing with IPv6 [ 4.294266] In-situ OAM (IOAM) with IPv6 [ 4.294333] NET: Registered PF_PACKET protocol family [ 4.304194] microcode: sig=0x50654, pf=0x2, revision=0x2006d05 [ 4.304656] microcode: Microcode Update Driver: v2.2. [ 4.304664] IPI shorthand broadcast: enabled [ 4.304700] AVX2 version of gcm_enc/dec engaged. [ 4.304931] AES CTR mode by8 optimization enabled [ 4.307293] sched_clock: Marking stable (4309428437, -2264104)->(4313172469, -6008136) [ 4.312720] registered taskstats version 1 [ 4.312823] debug_vm_pgtable: [debug_vm_pgtable ]: Validating architecture page table helpers [ 4.416262] usb 1-11: new high-speed USB device number 2 using xhci_hcd [ 4.502031] page_owner is disabled [ 4.502486] AppArmor: AppArmor sha1 policy hashing enabled [ 4.517910] debug: unmapping init [mem 0xffffffffba89e000-0xffffffffbaa2dfff] [ 4.536485] Write protecting the kernel read-only data: 18432k [ 4.537232] debug: unmapping init [mem 0xffffffffb9c02000-0xffffffffb9dfffff] [ 4.537413] debug: unmapping init [mem 0xffffffffba1a5000-0xffffffffba1fffff] [ 4.572753] usb 1-11: New USB device found, idVendor=0424, idProduct=2514, bcdDevice= b.b3 [ 4.572763] usb 1-11: New USB device strings: Mfr=0, Product=0, SerialNumber=0 [ 4.578033] hub 1-11:1.0: USB hub found [ 4.578206] hub 1-11:1.0: 3 ports detected [ 4.708260] usb 1-13: new high-speed USB device number 3 using xhci_hcd [ 4.857347] usb 1-13: New USB device found, idVendor=0bda, idProduct=0129, bcdDevice=39.60 [ 4.857352] usb 1-13: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 4.857355] usb 1-13: Product: USB2.0-CRW [ 4.857357] usb 1-13: Manufacturer: Generic [ 4.857360] usb 1-13: SerialNumber: 20100201396000000 [ 4.884325] tsc: Refined TSC clocksource calibration: 3695.999 MHz [ 4.884344] clocksource: tsc: mask: 0xffffffffffffffff max_cycles: 0x6a8d2284b57, max_idle_ns: 881590451434 ns [ 5.062316] x86/mm: Checked W+X mappings: passed, no W+X pages found. [ 5.062319] x86/mm: Checking user space page tables [ 5.062338] usb 1-11.1: new high-speed USB device number 4 using xhci_hcd [ 5.062370] clocksource: Switched to clocksource tsc [ 5.062512] x86/mm: Checked W+X mappings: passed, no W+X pages found. [ 5.062523] Run /init as init process [ 5.062525] with arguments: [ 5.062527] /init [ 5.062528] with environment: [ 5.062530] HOME=/ [ 5.062532] TERM=linux [ 5.062533] BOOT_IMAGE=/vmlinuz-5.19.0-rc8-test-00003-ge3a8d97e6a35 [ 5.068518] mkdir (144) used greatest stack depth: 13688 bytes left [ 5.165152] usb 1-11.1: New USB device found, idVendor=0424, idProduct=2640, bcdDevice= 0.00 [ 5.165164] usb 1-11.1: New USB device strings: Mfr=0, Product=0, SerialNumber=0 [ 5.167990] hub 1-11.1:1.0: USB hub found [ 5.168242] hub 1-11.1:1.0: 3 ports detected [ 5.200272] all_generic_ide (157) used greatest stack depth: 13672 bytes left [ 5.386694] setupcon (161) used greatest stack depth: 13640 bytes left [ 5.424678] systemd-udevd (166) used greatest stack depth: 13536 bytes left [ 5.460544] usb 1-11.1.1: new high-speed USB device number 5 using xhci_hcd [ 5.505409] udevadm (168) used greatest stack depth: 13384 bytes left [ 5.615936] usb 1-11.1.1: New USB device found, idVendor=0424, idProduct=4060, bcdDevice= 1.82 [ 5.615950] usb 1-11.1.1: New USB device strings: Mfr=1, Product=2, SerialNumber=3 [ 5.615958] usb 1-11.1.1: Product: Ultra Fast Media Reader [ 5.615965] usb 1-11.1.1: Manufacturer: Generic [ 5.615972] usb 1-11.1.1: SerialNumber: 000000264001 [ 5.633841] usb-storage 1-11.1.1:1.0: USB Mass Storage device detected [ 5.635351] scsi host0: usb-storage 1-11.1.1:1.0 [ 5.637795] usbcore: registered new interface driver usb-storage [ 5.641102] usbcore: registered new interface driver uas [ 5.700534] usb 1-11.1.2: new low-speed USB device number 6 using xhci_hcd [ 5.809537] usb 1-11.1.2: New USB device found, idVendor=17ef, idProduct=6099, bcdDevice= 1.14 [ 5.809550] usb 1-11.1.2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 [ 5.809558] usb 1-11.1.2: Product: Lenovo Traditional USB Keyboard [ 5.809565] usb 1-11.1.2: Manufacturer: LiteOn [ 5.825535] input: LiteOn Lenovo Traditional USB Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-11/1-11.1/1-11.1.2/1-11.1.2:1.0/0003:17EF:6099.0001/input/input2 [ 5.891349] hid-generic 0003:17EF:6099.0001: input,hidraw0: USB HID v1.11 Keyboard [LiteOn Lenovo Traditional USB Keyboard] on usb-0000:00:14.0-11.1.2/input0 [ 5.900145] input: LiteOn Lenovo Traditional USB Keyboard System Control as /devices/pci0000:00/0000:00:14.0/usb1/1-11/1-11.1/1-11.1.2/1-11.1.2:1.1/0003:17EF:6099.0002/input/input3 [ 5.959333] input: LiteOn Lenovo Traditional USB Keyboard Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-11/1-11.1/1-11.1.2/1-11.1.2:1.1/0003:17EF:6099.0002/input/input4 [ 5.961410] hid-generic 0003:17EF:6099.0002: input,hidraw1: USB HID v1.11 Device [LiteOn Lenovo Traditional USB Keyboard] on usb-0000:00:14.0-11.1.2/input1 [ 6.001527] e1000e 0000:00:1f.6 eno1: renamed from eth0 [ 6.052630] udev (165) used greatest stack depth: 13288 bytes left [ 6.155901] process '/usr/bin/ipconfig' started with executable stack [ 6.292529] lvm (220) used greatest stack depth: 13176 bytes left [ 6.653179] scsi 0:0:0:0: Direct-Access Generic Ultra HS-SD/MMC 1.82 PQ: 0 ANSI: 0 [ 6.666794] sd 0:0:0:0: [sda] Media removed, stopped polling [ 6.676026] sd 0:0:0:0: [sda] Attached SCSI removable disk [ 9.499125] e1000e 0000:00:1f.6 eno1: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx [ 9.499487] IPv6: ADDRCONF(NETDEV_CHANGE): eno1: link becomes ready [ 10.751097] readlink (290) used greatest stack depth: 12984 bytes left [ 10.828828] systemd-udevd (179) used greatest stack depth: 12408 bytes left [ 17.791051] EXT4-fs (dm-1): mounted filesystem with ordered data mode. Quota mode: none. [ 18.054819] e1000e 0000:00:1f.6 eno1: NIC Link is Down [ 18.713278] modprobe (841) used greatest stack depth: 12152 bytes left [ 18.729375] systemd[1]: systemd 241 running in system mode. (+PAM +AUDIT +SELINUX +IMA +APPARMOR +SMACK +SYSVINIT +UTMP +LIBCRYPTSETUP +GCRYPT +GNUTLS +ACL +XZ +LZ4 +SECCOMP +BLKID +ELFUTILS +KMOD -IDN2 +IDN -PCRE2 default-hierarchy=hybrid) [ 18.731182] systemd[1]: Detected architecture x86-64. [ 18.766343] systemd[1]: Set hostname to . [ 19.099821] systemd[1]: Started Dispatch Password Requests to Console Directory Watch. [ 19.100498] systemd[1]: Listening on Journal Socket (/dev/log). [ 19.100850] systemd[1]: Listening on Device-mapper event daemon FIFOs. [ 19.106316] systemd[1]: Created slice system-systemd\x2dfsck.slice. [ 19.106334] systemd[1]: Reached target Remote File Systems. [ 19.106347] systemd[1]: Reached target System Time Synchronized. [ 19.106829] systemd[1]: Listening on udev Control Socket. [ 19.222364] EXT4-fs (dm-1): re-mounted. Quota mode: none. [ 19.539657] systemd-journald[867]: Received request to flush runtime journal from PID 1 [ 20.771373] Adding 62496764k swap on /dev/mapper/budai--vg-swap. Priority:-2 extents:1 across:62496764k SS [ 20.909147] EXT4-fs (nvme0n1p2): mounting ext2 file system using the ext4 subsystem [ 20.915903] EXT4-fs (nvme0n1p2): mounted filesystem without journal. Quota mode: none. [ 20.915941] ext2 filesystem being mounted at /boot supports timestamps until 2038 (0x7fffffff) [ 20.997050] EXT4-fs (dm-3): mounted filesystem with ordered data mode. Quota mode: none. [ 21.197502] audit: type=1400 audit(1658734490.496:2): apparmor="STATUS" operation="profile_load" profile="unconfined" name="/usr/bin/man" pid=1019 comm="apparmor_parser" [ 21.197554] audit: type=1400 audit(1658734490.496:3): apparmor="STATUS" operation="profile_load" profile="unconfined" name="man_filter" pid=1019 comm="apparmor_parser" [ 21.197596] audit: type=1400 audit(1658734490.496:4): apparmor="STATUS" operation="profile_load" profile="unconfined" name="man_groff" pid=1019 comm="apparmor_parser" [ 21.199362] audit: type=1400 audit(1658734490.496:5): apparmor="STATUS" operation="profile_load" profile="unconfined" name="nvidia_modprobe" pid=1018 comm="apparmor_parser" [ 21.199412] audit: type=1400 audit(1658734490.496:6): apparmor="STATUS" operation="profile_load" profile="unconfined" name="nvidia_modprobe//kmod" pid=1018 comm="apparmor_parser" [ 21.202827] audit: type=1400 audit(1658734490.500:7): apparmor="STATUS" operation="profile_load" profile="unconfined" name="/usr/sbin/chronyd" pid=1017 comm="apparmor_parser" [ 24.686989] e1000e 0000:00:1f.6 eno1: NIC Link is Up 1000 Mbps Full Duplex, Flow Control: Rx/Tx [ 24.687075] IPv6: ADDRCONF(NETDEV_CHANGE): eno1: link becomes ready [ 323.629427] kworker/dying (22) used greatest stack depth: 10960 bytes left --mP3DRpeJDSE+ciuQ-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:21:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:21:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375041.607312 (Exim 4.92) (envelope-from ) id 1oGDwA-0005lF-5r; Tue, 26 Jul 2022 06:20:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375041.607312; Tue, 26 Jul 2022 06:20:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDwA-0005l8-39; Tue, 26 Jul 2022 06:20:58 +0000 Received: by outflank-mailman (input) for mailman id 375041; Tue, 26 Jul 2022 06:20:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGDw8-0005kx-EO for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:20:56 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1add2c31-0cab-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 08:20:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5460.eurprd04.prod.outlook.com (2603:10a6:208:11c::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 06:20:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:20:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1add2c31-0cab-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mPJ+BEggYo2WWKrZPemFUHLfWoF7swOVavXzWKzQefRSWPozQPInCAe+sNUekyzTyhiwnAZlOlPtzYogGXMO5mAtDW+BP4SUD319j0x9KkkX4vQKHGN+xd5/52qRfGS5PFvT0LtGfuYCsO033WKMNwLWZvhZ+ViOGsSH+mqz66h20mFdIJuK8t9NwRyeKboHxIRzgGDHlBfWyLyxRlrgec/AyEf+zaYtt85zfiQkl9UIk8ZIArs0aIidQwPY8a1H1kzUKXUelHSufcLHTzdrRZbmRgPM6jssd8w/xLMWw3SHrVOxebNJlvSlBI5EBfoF0E1JAkf7+U5nXWFC+XC/lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8cSomQr0M0vcuHInCIZf9QLKEYZyHCRGUQzSUs+uKhk=; b=Aate6pkoahVO2eiY9FPNQ+kTr0t2HPgxwt89RBkbzDRDud9r4D8uDkZRoyFhDM4COq3xds3NJn3T3U6JUtlLwLmpClBPnvx5+xuhaZ56cB/QINSmyNRjqutp8CgTzEb9WC1OziVneC84xcBc/Mxdk0iOaxLVuYAGweyHp7xt7mQp8oFFop2DHIqgeCaJew/BN8+ROgRY7zoGSU4j6OKiTkQfd5cCaSMf3WVdOruxf1zEhqne+Q8q0szBiyDo7XRzXKULiq+Cv4jT6wGIWCaTjbxopC+VQlLMTmTl9OAlpWxllusSMyH336aB2iHVskFuI6BfAK68fefHWSxTaI10nQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8cSomQr0M0vcuHInCIZf9QLKEYZyHCRGUQzSUs+uKhk=; b=WhemY3stSxn8kaT89T2dwBnRzmB5c1XTch2x0IB/wuOz4BF1sa0NNXf9Wj7Tw+3Yh9ENUGzQVgfRDBUAryFghcuxl4WcJTVUBjhLLQYwyiaCqO5JQt0JNDBVBgwwaU+QOO8EN7hUQR1OwbWgZC+Ir04mEtKRaOveTcpXwlzf1O7hCy1XZxm3gU9VgKrL68Y3LpqMYIIFdVXPoFHyyko3R3HzgijDgnFdv9C7Q0pBe8XOiDU8TrCRVlMBbGusrly+23XWnW22hiRGDonh80nulB9pyLpn0se/mAUw2bVNuvW8wYDcs7hi0ZGa4hreniyogRhMoGB4r/Zo+eMmUjD6mg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> Date: Tue, 26 Jul 2022 08:20:51 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Stefano Stabellini Cc: Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Xenia Ragiadakou References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0106.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca16422d-ea22-47ef-54d2-08da6ecefe0d X-MS-TrafficTypeDiagnostic: AM0PR04MB5460:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9mUfRmUd6K4+pxWIaqHoWmZh0ab7cwJ7zJUBmIXbNpwQ0mfNin5ii0XRjNimc7KEiiinI61sxe4rEMi5TuA7CNvVi8YjdbyWOxJ241WF6ngOuI9BF7ZmxrHP06g8oyDfSmVK2MmcDNjBeHJJOWjpImjhq2miotUJYnwXwge93PAnhTf7WU8hGgBsYHkIT7lwjuWQwm94s3X2FsOJWPS83189dA6a3DiGx3zer8TEDIM7rtxyf1yZQM85OANrLKSGTmd2gr3jBnGtTT/YqiPNvLY/lJY/V5Dloq3OSSLXutctcHQnenuCWmxdAgBAQ47k6hTMLiRVqg1L2KoTwinbUsJPiDpTbWLl9AN9A74JF6Z+bVHdGBK+k5n2DALfWxEoTnuyW+FPH0mzGhNqhfGa5If30nINiearoclJrnfXmtDoyihWU6k0meCjkTOGp+ruLB5ENoceucTDiPsfn4+a0lH5PpEQ2UbDfK+OAi6Egi6xcoZlP1y9Ma2q7MkOB2ky0NvC2t332ehekusf8+Zx/zpIfmIjDTM1z+RFGGX9264V12uEfY4Clrxs+w83l2Hci80+o7WZnnNatL3VPFsERfiMxg27Wz6gyKywJ1diyQrDZZZlCK94A0ykMJ1eLZ9eDhR9ESyt9PtMTApfB8tpIlMX3lj79V6gQnXHyIf/5qFgEDg7MhEsQDXOpAasSzl7psplqgkyZKqmBWkXWe5NTkY/fUqmOXvVrqHacXPlmK33Kp2a4BFVB2kUOXzmaG9N0EclfG+EAcrKOibWX49i8OTspcylwEoKtgNCVgnX5k2d0j8rodXz8j9XVCsxgNlC30TIxDETGXzGb4vEcrznEQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(346002)(396003)(376002)(136003)(2616005)(66476007)(316002)(41300700001)(66946007)(4326008)(8676002)(26005)(5660300002)(186003)(31696002)(86362001)(36756003)(31686004)(66556008)(6512007)(6506007)(53546011)(8936002)(83380400001)(38100700002)(2906002)(478600001)(6486002)(54906003)(6916009)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ck01VmtQQ2k4TW9CUE5hNjRzVGZ4TDhJdU0rblQ4ZE5HcDNKcWx5TUR0ek5o?= =?utf-8?B?STRKcG5DQnFwbkk4Ny90SjJ5TmZScFVQbzdWOTMzcHUwTzVaOGlwRFVML3Mv?= =?utf-8?B?YTdwcitiUit0a285dmU1b2dXWURUYmxNdzlabmE2QlczMkdLM3dUSVpTc09H?= =?utf-8?B?eGNITlZMd2dEa0hPNnRsNHRBWmRGYzdrQjF1Z2ZWTUlrQm5yVnlhZ2JLSVVL?= =?utf-8?B?RSt1TEFqTG1XRjlaazdzSGZBVmpNY042TmhMT1o0cmRUbjVEeDFkaGtlMzdN?= =?utf-8?B?M2tXM0VZWGFvRzdvSm9UNTU4Mkp5d0xuK0orb3k1ZjRSMmNFME1HeUwzdmV0?= =?utf-8?B?cDQzYm9ueStVV0N4eklLQTdEbU5HQTdtMW8zMC9obDZNYlNzamhoTTlncFJC?= =?utf-8?B?dnA2bFErWTEyeFowUHd2WmZZdDNNdHdvTkJUUktJd21adXpOTkF0N0UwT0lp?= =?utf-8?B?SHhNRjladXAxRFlQQk5oWDdqaXJ2Q3N2WVc0WDZuUVBYaHkxRmdRNFV2UHFo?= =?utf-8?B?YlNOMU9hRUtwZGREMU5RVElnVDJGb1ZONnZKaVI4OWlvSks2dEpoY29ieWd1?= =?utf-8?B?bDhiWDNXdzJtc0RQQUdBaTUySmt1MnM2ZkZCeG9MYUJGdlJUb0IvY0xKTHJB?= =?utf-8?B?RnI4dFVmTW0zNGlpTDJ5cmdxYnhjTWYyb0xBdkxlak1XUHhpNVQ4VXVtTEJY?= =?utf-8?B?Q1Q3MUVnSnFUT3pUWkFvMlZ1WGJxVk5UOEE5NmpKZ0FYYUNzaXZhUVRWakZS?= =?utf-8?B?SUQxUTJuaTlvaWEvVFdDQlIvTDRjazFpa1YrNmE3U1Jjc3IrRDZSaHEwSU90?= =?utf-8?B?c3JGdHJJcThDYUJxdkpIVGV1YmExaXdJK0hJbGlYU1JEQ0UzVXZIWmNEaVV3?= =?utf-8?B?NlV3enpkakJhMUxTWkl4bThOUXNxWGtiWGVGeHgxYmpjaXpOemRhbS9hMTFa?= =?utf-8?B?Z0d6NG1Ua09aQWs4TW9Lem1GUUkveWJITU4xVEtVL1o4cU5NNVBrOWs1QlBy?= =?utf-8?B?dVNnRnErQng0MTJCOVFtc1o5OW8wTU82RjRHMVZKV1pMNFI2RndVRmF5a1Jp?= =?utf-8?B?U1NjQ2szT2w3cXpvZ1dTYjJQNWlNMXFlZlVtdWJQRHJxUXVjRDJIcEU2eEs1?= =?utf-8?B?VEg1V3dmbmpyZVBOejBqbS9RcktabTl0VWk4UjZwS2FDekpIOUc1VGVTRGVL?= =?utf-8?B?NmRqckhnZWVTN3pndGRyVzlRLzlKOVhqQmRwYndNUWlVcTFxOHJSU2k5dHZG?= =?utf-8?B?VUJxeGRZeHRZRlNxZEg5MTF6OThNSjJqUUxvMUttOGpXU1RqZjgzeUZEVm9x?= =?utf-8?B?MGl1ZFdNdm5LeEEzWUNUY05rK24rMWFPNFhzMDNDdFpxbFBwVHZpaEVYZ0Js?= =?utf-8?B?VFZmSk5SN1ZIMmU2Z0g0MlpQYS8xZ0VHY04vcEx6WFFvMy9YajF2QmdSVGpO?= =?utf-8?B?dlJPVDNCeVIxOXlkMk8wMnpTS2FuZmwxaDJDcmh2bFJGYng2MmRHVGNvRW95?= =?utf-8?B?bTYwakJrdEpTVHY5TDVSRVJtUVhReVlGS2hNdGpUWUVYSnh1NDBRK0FRcEtG?= =?utf-8?B?SlMzT0J4WlQzSVFpMlo4ZTNlR3p1MDZ1RFpuR3A3dTMvN2xFbHBDQ1o2R1kw?= =?utf-8?B?dnQyelc2alF4cDJoZDBOOGxaZDVKN3p4dGt3QnBoclRiNkJVZWh5S3RaSS9n?= =?utf-8?B?bXJGekQrRGhaaFQ0NWlyOXcxY0lQbWlJa0VzN05FZUx4NlZUR3htRThROW1x?= =?utf-8?B?UU41M3FCcHJTT2dxOXpHNU45a1J6bjlJVkQ1amtkcXRSSk1nak9ldmNoZmJx?= =?utf-8?B?SWQ5bHVJVzNwMm5SalZ0VXg5cVNsKzlYeXhkT1BKeDJ5MlFCeXVxcENvd3NH?= =?utf-8?B?Sk53TGJKTFNWcldKb2g0SWUwS2tzOGdkbXhjYzVwUXFTOWdpV21VR21FWGZE?= =?utf-8?B?L2pwTWYzNkhhenhLL3dEWU1wQS8xNGFxTmg1aDdiWEpWRS9lZWoxVUJpcEFw?= =?utf-8?B?aUdqMUFBK201UmFmdEpNdW93UHdBVEZUdWhJanlnbVc2VDY5SFdDS1pyVHFk?= =?utf-8?B?MHlWVE9CQUpySXhtNkpxVURvWCsxcWdMWEZiQ0VZTWJucjgzQlQ3QjhWTkx6?= =?utf-8?Q?aZH/Sy/ZCHgAUbacctf4QLAmn?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca16422d-ea22-47ef-54d2-08da6ecefe0d X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:20:53.2201 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6sPQ1b4qMUbRn6NLHtnk8vqmzADAg/tinduNSJ+sw44hbZQjsGiqjT1+3Yp5j8DQuL+bDTJA3RH2lIhXNCPeow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5460 On 26.07.2022 02:33, Stefano Stabellini wrote: > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: >> On 7/25/22 09:32, Jan Beulich wrote: >>> On 24.07.2022 19:20, Xenia Ragiadakou wrote: >>>> On 7/7/22 10:55, Jan Beulich wrote: >>>>> On 07.07.2022 09:27, Xenia Ragiadakou wrote: >>>>>> On 7/6/22 11:51, Jan Beulich wrote: >>>>>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>>>>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>>>>>> The function idle_loop() is referenced only in domain.c. >>>>>>>>>> Change its linkage from external to internal by adding the >>>>>>>>>> storage-class >>>>>>>>>> specifier static to its definitions. >>>>>>>>>> >>>>>>>>>> Since idle_loop() is referenced only in inline assembly, add >>>>>>>>>> the 'used' >>>>>>>>>> attribute to suppress unused-function compiler warning. >>>>>>>>> >>>>>>>>> While I see that Julien has already acked the patch, I'd like to >>>>>>>>> point >>>>>>>>> out that using __used here is somewhat bogus. Imo the better >>>>>>>>> approach >>>>>>>>> is to properly make visible to the compiler that the symbol is >>>>>>>>> used by >>>>>>>>> the asm(), by adding a fake(?) input. >>>>>>>> >>>>>>>> I 'm afraid I do not understand what do you mean by "adding a >>>>>>>> fake(?) >>>>>>>> input". Can you please elaborate a little on your suggestion? >>>>>>> >>>>>>> Once the asm() in question takes the function as an input, the >>>>>>> compiler >>>>>>> will know that the function has a user (unless, of course, it finds >>>>>>> a >>>>>>> way to elide the asm() itself). The "fake(?)" was because I'm not >>>>>>> deeply >>>>>>> enough into Arm inline assembly to know whether the input could then >>>>>>> also be used as an instruction operand (which imo would be >>>>>>> preferable) - >>>>>>> if it can't (e.g. because there's no suitable constraint or operand >>>>>>> modifier), it still can be an input just to inform the compiler. >>>>>> >>>>>> According to the following statement, your approach is the recommended >>>>>> one: >>>>>> "To prevent the compiler from removing global data or functions which >>>>>> are referenced from inline assembly statements, you can: >>>>>> -use __attribute__((used)) with the global data or functions. >>>>>> -pass the reference to global data or functions as operands to inline >>>>>> assembly statements. >>>>>> Arm recommends passing the reference to global data or functions as >>>>>> operands to inline assembly statements so that if the final image does >>>>>> not require the inline assembly statements and the referenced global >>>>>> data or function, then they can be removed." >>>>>> >>>>>> IIUC, you are suggesting to change >>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) >>>>>> into >>>>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" >>>>>> ); >>>>> >>>>> Yes, except that I can't judge about the "S" constraint. >>>>> >>>> >>>> This constraint does not work for arm32. Any other thoughts? >>>> >>>> Another way, as Jan suggested, is to pass the function as a 'fake' >>>> (unused) input. >>>> I 'm suspecting something like the following could work >>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : >>>> "memory") >>>> What do you think? >>> >>> Well, yes, X should always be a fallback option. But I said already when >>> you suggested S that I can't judge about its use, so I guess I'm the >>> wrong one to ask. Even more so that you only say "does not work", without >>> any details ... >>> >> >> The question is addressed to anyone familiar with arm inline assembly. >> I added the arm maintainers as primary recipients to this email to make this >> perfectly clear. >> >> When cross-compiling Xen on x86 for arm32 with >> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); >> compilation fails with the error: impossible constraint in ‘asm' > > Unfortunately looking at the GCC manual pages [1], it doesn't seem to be > possible. The problem is that the definition of "S" changes between > aarch64 and arm (the 32-bit version). > > For aarch64: > > S An absolute symbolic address or a label reference > > This is what we want. For arm instead: > > S A symbol in the text segment of the current file > > This is not useful for what we need to do here. As far as I can tell, > there is no other way in GCC assembly inline for arm to do this. > > So we have 2 choices: we use the __used keyword as Xenia did in this > patch. Or we move the implementation of switch_stack_and_jump in > assembly. I attempted a prototype of the latter to see how it would come > out, see below. > > I don't like it very much. I prefer the version with __used that Xenia > had in this patch. But I am OK either way. You forgot the imo better intermediate option of using the "X" constraint. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:25:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:25:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375050.607324 (Exim 4.92) (envelope-from ) id 1oGE0U-0006QG-Og; Tue, 26 Jul 2022 06:25:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375050.607324; Tue, 26 Jul 2022 06:25:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGE0U-0006Q9-K6; Tue, 26 Jul 2022 06:25:26 +0000 Received: by outflank-mailman (input) for mailman id 375050; Tue, 26 Jul 2022 06:25:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGE0S-0006Q3-TQ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:25:24 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70044.outbound.protection.outlook.com [40.107.7.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bb09e6cf-0cab-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 08:25:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3571.eurprd04.prod.outlook.com (2603:10a6:208:18::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 06:25:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:25:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb09e6cf-0cab-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/yiY6AuHBT2ZR3w9TfEP0wQ5lmHkEEzzzVv5Zl/NbIiWi6zS2nFwmSiKhbaKMfCuz19Ylv49CNHNMXb5dq3ctYBF1OAVwoMQPmbmgnNr/CmbJQQaJnirVLEv55Z8+BQXPTAgkrmHdKAxT5fWuIBYSDqwsMi3xaP6o2fTmel12TxoTOX7xBCPuKQDw9JBclaVp/fHdD/24nU38qjDdyWBG+z6xMU+Gz7ajcw2EMpywWMY4B77GrOsxneZJBPqo9pnFV8nE5LS2rSefx2pT7rnFXMUC+e9ztoV+00fq/B0IeuCtgoKCnlOl9u35xbQcR3Qq3tJm9rmwVW7G9klNFGIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Tqwn1E7U4qBKmhrFy4yNBjSmu/J3YiePt13DAU78sy0=; b=FhOth/Vqm4RprwuJzKSdgv3/tSN3cwSqzOb7iGERFcYq0PNkWhHOTlsnycaX7WtbFEDpH75/QDMzM34lW3AgkNACIJgj+btngm0NAzLPleJlvweJKi5RtnCXC/+JxaS9PblzbP4lRRZA44sLQSq9hLk9jHpzjESccpHVTlU300cMwJY7zSs3T0LC59DnsWqPLcHJTAukaz5CxuHCzy2hvnNiooH10nUObFnwydjJeW+cwH89Aur4sH7aQryNLMhIQX8YWCx36QFjzea4SdWTY5MoPG1GjFevfbg6Hxi3Ch4ATEdNIPR7DbjykiYdDqTKu7xOdLvRiLcp/xSHaeSIiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tqwn1E7U4qBKmhrFy4yNBjSmu/J3YiePt13DAU78sy0=; b=v37Rj2Y1vWaE0d/Aui0YNy1r1DRSEUW12UigvFD45D9PoWdTuzoFcM9nq4AzmmIJEFCEIABNEem86suapypVopNlYiLgmH6/Ph8OoHQr9mpofMCGb8WjbRiv2IqC62mgErhlFGVeG6DVt4j7yC3PwFkImLIkfMMnayDp0UspZkUxEORFQoSNtjxr+Ttzp0BxW6D7gsv7vB927FGxWw/ubnW8iUK9dEvOQyDWD4hrOOsLusQmwjwziWsMNMR7C7/EpG8kLkdGTym4PYzIRnLzqQfpmv+ZqXPLKBZ5qBd0lme1s0F4eLlDgQNAD6ZNMuKUDNKAIdSihqrUiwvFpoBMpA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 08:25:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] livepatch: create-diff-object: Check that the section has a secsym Content-Language: en-US To: Sarah Newman Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com, xen-devel@lists.xenproject.org References: <20220725171302.25910-1-sarah.newman@computer.org> From: Jan Beulich In-Reply-To: <20220725171302.25910-1-sarah.newman@computer.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 077dbfe5-a907-4a3a-2cdc-08da6ecf9dd4 X-MS-TrafficTypeDiagnostic: AM0PR0402MB3571:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iDBJziNuV4HfUyo/jLPIHp11gYUTZU75GuvBcmVtYSRvv/WxKQBeJE0dBYmTnsnFjW5sb8WKxcuZKTna0V7inKaYW+sMtDIln0QwinLL3OiIedYPwqfK9s00vO5qwbK8aQOc7mO70m7qtzJEQjkUv8NFiEOX5HFXAukvXBR2U8g125xTz7SzqW2ZCWedgfVhjPN+bnuSkci6dlV4ovQO4BPKocC7287tmquu7d5uU9XYIRTbQJdZ0Xx8Mm850lXm8IfROICR70P3HmKPQv3BdIftGCZnS8kKuxu++eb9BSISS3AW2TDbnbDcS2UBmksLYM5VguIBBa2l3iBal0ANCfCwE6oRFMQDZvYtudzgtjmx9GPpo3ji56CLgOoH8ienfaXqM8J4sIzJBXWTrKvW+T5Qq7PseXx+BtGTUJaeF8WW8LMitWzm0/xsAmM4hMwpD3gdEdNVJqGLtcFlgRaJZQc2PTZqAHrZpiaEebHSte3tCE6G2++f4mqAz/zzWuL3EK2vz98wKI1/LNBkElVJh5J5PTJN5oheuYjCc66Ug0oi7mrCHCmQFWhMzVS5SbN90CMAwQPPvAeDzaAVCecozzfAJYtAvzteWeKo4mdIyifmwctqMvHi6MxDsQSKXwpmtMUjptFy73QZH+WwVm0boUErCAXQpNKEKJQKst+tEmubwZ2+qTW2GfHKGz7RFGFzC3ikbqprAFTQ2SjEOU1SvTR2ZQrCrf3vxHFMtj7QUHZEJezi9/rq97mbunJk7xbr0gTYD+01o9xkpXVmtAUk3hWprTxeI8VCnr+N76VdYNX1aEO3KDHE5gDTVP+f8hoUdbiMuasc70A0VdEW2jidcaJFdvOFUp02xMGmC4bTLpc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(346002)(376002)(136003)(396003)(5660300002)(6486002)(478600001)(2616005)(26005)(8936002)(966005)(6512007)(6506007)(53546011)(4744005)(2906002)(41300700001)(186003)(38100700002)(31686004)(66946007)(31696002)(36756003)(4326008)(6916009)(316002)(86362001)(66556008)(8676002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d1pPM1prbW16L3ZWbG9GUkZ5V08ydjM3SVFCa2x1MC9yTnBTTkp3ZUhEMWk5?= =?utf-8?B?WHZxMmhwK0ZKbVkzU0VmZlR1eCswWEF0aWlLanBYdjA4TVE2ekFBRFViS1dv?= =?utf-8?B?angwbzdHanBSRmIzWjUveDBJNkpYT3B2T0RsclhMdUVIQklaSTJYOGtQWXk1?= =?utf-8?B?MGpDQXc2b2NrbE1HeXlhU2t1aDYyLzJnR1hML3Z1SFNMeVAxZmNrTTkxMFdS?= =?utf-8?B?TXNCVDN2RGQvMzJNL29jVmZuTk9IangzSmUveGg3aEZybGY4WVNSWko1cjlo?= =?utf-8?B?UG1MY3oxWkdaL3NhY3VRZkVTazR0ZDBrb3lDZWtpVEpCVzg3Rzdjd04xbVY0?= =?utf-8?B?T3o2MGNZL1QwQ2l3Y0VhS2VMODkxUERmSFdPa2JudmZqczN3NzhYM21WV1BL?= =?utf-8?B?cXhpeFpzeCtrYnNMTUFhZlloaVFMTHpaVXYxZlJmWlcrZ0JwbnNoVnZqMkhX?= =?utf-8?B?N2F5L1ROYmxXc1lnTmdRY01uRTE0R05HZmZlMWkyMSs3TlhIK2E5Uzh4SlRs?= =?utf-8?B?aE41RkxpQ2RBc1FKcUo1eUoxQjRabkRmdm9pckt5QmVyZjRja3lJR3d6Qk1Z?= =?utf-8?B?Q05Ha2lzSVJpMUYvZUoxZnhKYnVaWnhEeEEycUdhaVJCaU93SXQ5R2hGNnc3?= =?utf-8?B?SjRpemswRTR4b0krckd1UHdLZDB2SEdtZlNhQzFndUJtb3JNdHZJMXlHOGJp?= =?utf-8?B?K3BWUDI3YU1pSUJnYlRheklNWXRDS2pYSURDemVvQlhOSzJsSFp0TnozM0No?= =?utf-8?B?aWlIUHNFM0xmaEtLenVrMDNqUTVORGJhMHpCc016Mk8rczFPbTJ3NXYvVWpr?= =?utf-8?B?OUgwdFd1THl6RmhabCtjS3EvNkVVZEUxbmViMEZxTEh2RVRPbXZPNm9vN0VG?= =?utf-8?B?M05PaVJkUThnZ3M1clptalNtQVdSaXA2N0tYMDIxc1N1Zi9WNStpZ2FlU2h2?= =?utf-8?B?TDBhU1BPdEg3Y2s0MVE0WngzZnRvclhWRVQzMjBBZFdEWUlUamZUeStqbXBC?= =?utf-8?B?QkQyN1haeEVucVMzWXE1aGFIS1NvUDZtWmJSVi84clZMbW5RTDc5ZVJxSTQ4?= =?utf-8?B?MWJWLzd1UkIrMmZiZkY4S080UWFod1ZDcXhoZHI0MVRscVNocU15OXgwT3B5?= =?utf-8?B?c0xwTjhNNlVKU2hQQmZNcUNieXpxZlBNYTAyY0wySXBxdXJBYVJlbFc5Yytw?= =?utf-8?B?dUR4c1EwVEIzZjU0aWlKbHNYVE9uV3lZZkhjdTYzNS9PQ2FjNnNPN3NkblQx?= =?utf-8?B?VmF0eDFmOHI1M3NUOGN2UmVBQlI3TTRmKzd6OUl2amFpRDFBRzlhUzJiWWVW?= =?utf-8?B?NjBwdWdkbzk0cTVocDZJU3JYNXl1dGdnT2FpL0xPVmhoc1hwdGQxZlhjMnlR?= =?utf-8?B?cHdsamw5SFdhOGxMdW5UWG9pNXFZUGg3NVd5S0J6SzV1S1Mrbm02REU1aTU5?= =?utf-8?B?TWgvRE0wZUp1YjJnRUhOZFRGM3VMRWVVcGVwWlQrTGZkOXZVZVFmRndpYldS?= =?utf-8?B?cnB0M09jbFFnbmt4NjdDV3Z6aFJQeEJyR3lnSHpURXJrUWJpVnFseVBxdjlu?= =?utf-8?B?bUlaeHFZVFoyRFAvM3FGczNCUXpoNHQ0bGdnK2xCVjZpRFhUWHFRZEdxV2Ru?= =?utf-8?B?eTJTNW9ralJ5QTF4YjArNFpZK25LU0lnd0t3bTZYOG42NVVNdGlib2FlZlFl?= =?utf-8?B?VWlwSTBIaldBM0dtWURiOVJwdGpCV0hzN1ZoS1dUdm5HdVQwQm9oYkwrSmdZ?= =?utf-8?B?bXhqL2lvNmRhWkptSTQzVWF4aU9Fd2dlb1cweUdpTHNuVFlGZnZadGpFVlF0?= =?utf-8?B?bUl6L296eEttemtWZktEeCtVMzBiaktTazh5TE5pdmYxV0laOFBjNEtpTGlK?= =?utf-8?B?cUVCT1BtZUN3UDV1eDZ4SFMxS2xwcXA3Y0RhRFZMSXEwZmpQNXB2Q25XV1Vj?= =?utf-8?B?bk0rbUxtejJRSmZHdHk2MXYxbjJSVmdxa3R0Ny84VkNhdEhBa0dXOE5aaTBO?= =?utf-8?B?TEhvTXNkMm4wZVBHNGVwR2trRExZb0ZFQmc0anhsa1drRHBWSlNkTy9MVU1C?= =?utf-8?B?VUhWb0MwOFlnaW8rZHJKVGN2OVN4WHJmTisyakJxdnI1ME45L1Z4Y1FKZWls?= =?utf-8?Q?5fESxKmq3v6/Q0Ai0zQt6pHyT?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 077dbfe5-a907-4a3a-2cdc-08da6ecf9dd4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:25:21.2966 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ywl7dxyg6Zv4WVSyMhFOa2/1qXMLPnbb2KcFHDHcmOeE1eyyqB1C6q6fTFhdPjdtrK9GogT0dkHDB8KcLdq7TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3571 On 25.07.2022 19:13, Sarah Newman wrote: > A STT_SECTION symbol is not needed if if it is not used as a relocation > target. Therefore, a section, in this case a debug section, may not have > a secsym associated with it. > > Signed-off-by: Bill Wendling Hmm - this wasn't here before. Does this then suggest the patch also wants to be marked From: Bill? > Origin: https://github.com/dynup/kpatch.git ba3defa06073 > Signed-off-by: Sarah Newman > Reviewed-by: Ross Lagerwall Sigh. I had given R-b on v1 as well. Actually I had meant to commit this yesterday (with all adjustments made), but as it turns out committers can't commit to that tree. So it'll be up to Ross or Konrad to actually take care of this. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:29:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:29:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375056.607334 (Exim 4.92) (envelope-from ) id 1oGE4n-0007Al-8B; Tue, 26 Jul 2022 06:29:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375056.607334; Tue, 26 Jul 2022 06:29:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGE4n-0007Ae-5W; Tue, 26 Jul 2022 06:29:53 +0000 Received: by outflank-mailman (input) for mailman id 375056; Tue, 26 Jul 2022 06:29:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGE4m-0007AY-9t for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:29:52 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2073.outbound.protection.outlook.com [40.107.22.73]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5a7cb5d4-0cac-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 08:29:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8155.eurprd04.prod.outlook.com (2603:10a6:10:24d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 06:29:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:29:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5a7cb5d4-0cac-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XLtSwTEaJMIGiN9gvNH+ExBgV67FD4+msqFm1xvFKTAoPoGavekLKu1NtTdcWHODm1HLrWNOtUL44DKgqe+mVMApjHgIYpsxQD0GcSlnXSllR/Z/TAV78t5FWeECwY6kNjFIXrFcmN2vw2d43YV6l7K1MoAPsXGFk1j27OviDxn+JXOYUOYZSJUK0dP6uUHc3EFoW94EyBqhngPrrbqzxgfs2vZK+SGEqYWrF9Puj1lgL3PszC75ZkhgTVkq5jhFjpcM9V1smSiCx325U45M6+r1S4gikN7WO5oAglpBOyaap0C+vSzggMrzIP+qtQyJRCfwm34NBapu+CvIH5kVSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=st+k8Ys+XWdrzUrpeNQQuwR2aWpv5futUnkxzwVhjNo=; b=cm3c+MU3Lpzai/gJjeIyJCTsF85Xx5FNkuLTMWuZIMBoWp//+9Rz3Yho2p20sRSyLFj/Vg/WjQpcnqTjW7eHbhZXB4Zlbi2efHPfd4N8Mfb8s8EUrr3w5twBdyUNbhG7WA7hjdXDS4G5Ii0HiFDyakbEggu8vB9JrAc7sEGF+QVklH+5Yp3YapRR2DQSV5Zi+5D+2ahzubyifMHusbOs3iGu5Qg3R3d9URUe6kNT2Tu9+NKj8F4t4UT3OBAKgA+eGA8h8HMk7gW90p2E9zICU5wGz2moikHguism2tUBUOq2fbmCu2GgpBBdSCP+Qs5JL5e1VuKqLhj7g9ssKZ/lWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=st+k8Ys+XWdrzUrpeNQQuwR2aWpv5futUnkxzwVhjNo=; b=UjRsERtUBDyFjvQ3Pl6vLXqDXILDSPdueLrEdRd0XVDYyXd+tqS7SP0J8WQGTh7Fb4jPC4BW1ShXDVfDnFPK2PO5+ZlUAq0E6gmmv8dtfoVcmttHUZ5noHUdJ6BoxE47/jytoZq0B/MIxozWM7a2HmW+hIpjA02YQzCpQPUeR5ZrcnuIRf7jdA4+gT2244Bys6CKgBAkW7+18ZMuFsOr312hcCiRAAiBroxtnhfUbud1ZPsgXsvErH9cDU2+zK14ATxeFsRitRhztG+t/tp6yLwcz2qJDc56IOU9rc1e0afAzt7STyOEP9SnFKOpAx//kljh6XljbzI6sqUBYWMVjg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 08:29:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/pv: Inject #GP for implicit grant unmaps Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Juergen Gross , Xen-devel References: <20220725175013.893-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220725175013.893-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0155.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::16) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1c3bf99-2c81-43f6-86f3-08da6ed03cf6 X-MS-TrafficTypeDiagnostic: DB9PR04MB8155:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 637kRxPOVJIktwixI6sxTeXo7d6RJl0J6kEZ3lWesLLV+dhh/oNMNEivzP6mEwkMCbO8MOlTbrSyeez4QbFlLVhZ2HdPGy6Y9eMaD+dME7QRkzH61jsh+KbldiJmxE9dFPgE1jfRFXMcJ28RKeFImFzRgOdipr5abZqyPtNMt/0Y2osnrirmNGgkjh3LWTInLuHCJCOZhq7ij9ZC/SnyvK1KarlAIQWaYTLK1ORWHydi7PacgWJWPPt+ZE4a94B0FQ6XC8WV15Xyedh/xLYh3HqTwNr09tHh7YWVKvGQYV4ILgwWAFNmMLVokaHyOuCpkIsOEtAvnadAWozkRAcmc+zajrq9+3jvRu8Lpj5ibbdqXSwjBW9R1h+HT+XC9CwzPm/1wEXBSOM9ceMFr0bVmfok9iZvGXcQk3wPgaZOGRkCRDBgKwL8ZOqQsRBhUDvpQKvZSccwFwyeZ04qkv+Jpt+2UbzJYJo6quB5SSGVBqpoeKF3YlpnIMQDy6aHcog82VxKfPiiTYrwXRXgd0m3uYoOmt9kDmFA4U5qiL1lFZBzkTNzM6w1FeI252V9TocBJnrz1Mvu5MebY03mP/9BNghdUPBUgcbhL+voI0Uqe5BqXKrs+TcayjBNYLJdlGmR+WYTO9l/Lr/xkkOc8xSNCNXNHaGCjxcoxVkyN3TeYImDMDIqS84EeDw2o2CG1LbIFIA/NcFXIO/7VkxpqpCN1CHetBb7Qc37RZryxo5D1reI+IyxU/Kf7cgHyFQlN6L6yk3d6EA+rbQPoDsea1Xn6qIJFbxfPjg+Ck0Yyajm+JnKBG2u2quTKELfRWAk3NyJkrmSfNxdMwTNYW/qRN279Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(136003)(39860400002)(366004)(6506007)(4326008)(8676002)(66556008)(66946007)(66476007)(31696002)(2906002)(41300700001)(86362001)(5660300002)(26005)(478600001)(8936002)(6512007)(6486002)(53546011)(83380400001)(31686004)(316002)(36756003)(2616005)(6916009)(54906003)(186003)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnFQa3hTbGxUcU1oWStwKzgxNCthcUwzZG50NklIUzVHRHQ1MEZIUjl6QWor?= =?utf-8?B?N203SFVLMnZQTEpta1B5Ylk2NHhWelJLVzN2TjZvT1FRZlpDL1VQS05mQkxi?= =?utf-8?B?a3VWVGFZZ0lpeWpKOFo5dVhLS01TQkVobTdwRENhRG13ZU5QRG0vZzdycE8y?= =?utf-8?B?R004ajBWdnRQWGFyTlZ2a3Zud0RyZ2w0MlJXVzJqZEpGV2dxbWNQNm9pMHM5?= =?utf-8?B?REtCZlQ5RWs1dlZxc2NGRUtaZFJ1MzIrWFpQMUZSVks2Z1RkT2JwbGh3UjBm?= =?utf-8?B?MHRaMHpidW5iVEc1N1ZPTVNERjQxSHk2bjArZHA4cVA1c0VqbElYMjUvcXdk?= =?utf-8?B?eFN2UjJwSWxWWnVxcTYveWd3QkpNaWRSYitoVVRJRlpySjU0RGZwbFZuYlRE?= =?utf-8?B?V0JmcEwrQXlTdGtVOTN4VU1YMEdtQy83NEVENUZIS2JJTW45dUEyeWVza2c1?= =?utf-8?B?eUowSG1CUUN0WjJxVFU1ODVNNkN1UWVZVnY1YU00ZEJycXZxY1NCM3R3OWhr?= =?utf-8?B?dFptMzBZZXZYakd1Z1JlWjNHRHpZU2FZZThPMVJJMWlWZEh6VWtIeXRtVjA0?= =?utf-8?B?WERpNTFCY2UwelBFYUhOYzNwVVloT085Vk5abzUyZUlydlBPZXdlZk02VGU1?= =?utf-8?B?Umg3bUs3VnRUSTliWkZ0MFB1WDNDUi9qOXRSQUVkN2tYRWNyRGN5K1lmZ3Vs?= =?utf-8?B?QjBYbjdjSHZobkt5RUtUMW1MeTRKVXJKR3JCMFQ4T1hFOHpEbWhUcDFXOXEz?= =?utf-8?B?VVBpM3ppdzR0VjRJL25USEd0aHJxcFJVV2JBOHdsOW9hNTFDUU5IUk9pZVNZ?= =?utf-8?B?dnFnTzhEVFpMWDFNeFY1UUphb2I1ZjBzNVFTRExWWk05aWR0R2Z1VUlpQmZx?= =?utf-8?B?QXhUKzNRSUM2eUdiaWRHK0tYYkxqSm12aEt5Y2ttazN3TEhMclhqSUNyUmF4?= =?utf-8?B?QVVJYmtmTGNwcGRFS3Z2V1M5YnNWc05xNUJqUVRKa1JrS1g3M3NJWnZyeHBj?= =?utf-8?B?c0NWZEtiY2Y4MlB3VmFqQk5GUnYzcCtRbEIrOE5VdkRIaDhLRWxJMHBFNUFT?= =?utf-8?B?ZnEwVysyOVpLSFNsK29WdDA2dmpDQzFvSjBUczAwUVhyQm92VTF4YkVZaDlF?= =?utf-8?B?MXB5NHZaT0N1bDFabDlOSnNpUG9tZ2JGQWQ1ZTBacHhKWEo4TTVFdTArcW01?= =?utf-8?B?bU91VEFoS0lFSDloY1VsRTdTTkdzeHVXbGREdElLREFQbUtNc1d4OW1WNFJT?= =?utf-8?B?VkxhdGpEUkM5SU12Qml1WjMyMS9QZGJ4QXlkaFpqb00yOWdmZlhRVDFmVndZ?= =?utf-8?B?NzE0OXdQaVhnN2wrbHJXTjZMVmdMcU1yTGlhdkg3eFYvL2hkZUFPcCtSTWdI?= =?utf-8?B?T2gvNkFIL1NORUQvTkdrV0Q5NzFNTnlpQk9FcmNDWEZYcFRrSExkQVhKeTRX?= =?utf-8?B?TFdsS1VXbWpQQjV4RnVwNjJZZ0F2WElLc244R3FQNXlzd0JJV3FyblVVMDNu?= =?utf-8?B?NURJRnIvMWcvUFFIcE9QNDNTS2hXeFdJdmdIalVETjdWamZnL1FtYjM3a1I5?= =?utf-8?B?d3lsaDhDeEg1bEVDY05KcTdqaWdIYTFqVWRvMGlNUlBiQlNTQUNiZmtQMVNF?= =?utf-8?B?cGIybTN6NmJwN3pxNUZkbElYUUpwZ0F2TlB6WFVsQ1RpdWcvMUFwMXNQM1JQ?= =?utf-8?B?a1BSVmpwNlBFaVIyZEp3VmpUSk5pVnNNUXFkbkxqcUdOb05meHNlK0EwZE1T?= =?utf-8?B?c0lNZmlKbzNTOThMbkZKTXU2bWtYQ1hDeFBSdTFqandtNG5PQVVyV3FSbVNF?= =?utf-8?B?Z3FvejMxZDhUZThka3VEZWpnQ1dNbHJDL3pwaVNVWFBwMDNrbGplOGtMTnEz?= =?utf-8?B?bUNFS0JBQmR3RVRvL3FXVUxXVEdwMlhiMzM4RVN3cURHVmUvMGFDRHBTZ3dn?= =?utf-8?B?UWRWRTlGelBCQkRFelVJb0JueFJzdDJFd0tOTXZ1Zm0xelZNMlg3QURxTVlF?= =?utf-8?B?OXFweUNCR0hTQWkrYnlidjhUUUdibGp1akFwZUlrN0hQeERRa0FUcG44cGhr?= =?utf-8?B?R21GMzQwZ0txVGY1MFF4R1puOE5NUVdDR1ZibzFMMG5rR3phcU43UDVmVXlz?= =?utf-8?Q?tWla5qp/6jWhWGtZX6k7OR09x?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1c3bf99-2c81-43f6-86f3-08da6ed03cf6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:29:48.2638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9GzgYAdq/UZuub893Mok8b/TgJY7wHsblHri4jvDZFiodGzx94mJpsfZb1qukwYdcZ1bvVYiXRUoRQWWfdMOBA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8155 On 25.07.2022 19:50, Andrew Cooper wrote: > This is a debug behaviour to identify buggy kernels. Crashing the domain is > the most unhelpful thing to do, because it discards the relevant context. > > Instead, inject #GP[0] like other permission errors in x86. In particular, > this lets the kernel provide a backtrace that's actually helpful to a > developer trying to figure out what's going wrong. > > As a bugfix, this always injects #GP[0] to current, not l1e_owner. It is not > l1e_owner's fault if dom0 using superpowers triggers an implicit unmap. > > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich Albeit preferably with ... > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1232,7 +1232,7 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner) > gdprintk(XENLOG_WARNING, > "Attempt to implicitly unmap a granted PTE %" PRIpte "\n", > l1e_get_intpte(l1e)); > - domain_crash(l1e_owner); > + pv_inject_hw_exception(TRAP_gp_fault, 0); > } > #endif ... the gdprintk() adjusted to also log l1e_owner. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:41:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:41:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375064.607345 (Exim 4.92) (envelope-from ) id 1oGEFO-0001Bg-Aa; Tue, 26 Jul 2022 06:40:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375064.607345; Tue, 26 Jul 2022 06:40:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEFO-0001BZ-7n; Tue, 26 Jul 2022 06:40:50 +0000 Received: by outflank-mailman (input) for mailman id 375064; Tue, 26 Jul 2022 06:40:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEFM-0001BP-TR; Tue, 26 Jul 2022 06:40:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEFM-00067U-ON; Tue, 26 Jul 2022 06:40:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEFM-0002jD-7E; Tue, 26 Jul 2022 06:40:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGEFM-0007fN-6n; Tue, 26 Jul 2022 06:40:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+nuk59bN7+p9QmU14nTkSvmJlyKxsUrdnIrUPX/+6XQ=; b=wNRZliEoBqAKXmOjXzr3cx8wtl ptag5NpNLYd1JMWo19JuE6V39nEpUq3BSp2tqVgHb36k8v6PuRSmw+Dd1e0ApNqDsx1gY24zA87qs CUW+McwEHtXtjK7diUdPK2mSb3RviOy5Z+WrPqZJzhx9xBBhDEuCSBKYZLMvzJ2q44qg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171860: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=30a067d94c87fd0d634486ebb2d2df98ce1d227c X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Tue, 26 Jul 2022 06:40:48 +0000 flight 171860 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171860/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 30a067d94c87fd0d634486ebb2d2df98ce1d227c baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 746 days Failing since 151818 2020-07-11 04:18:52 Z 745 days 727 attempts Testing same since 171860 2022-07-26 04:20:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117155 lines long.) From xen-devel-bounces@lists.xenproject.org Tue Jul 26 06:44:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 06:44:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375073.607360 (Exim 4.92) (envelope-from ) id 1oGEIY-0001nh-RE; Tue, 26 Jul 2022 06:44:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375073.607360; Tue, 26 Jul 2022 06:44:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEIY-0001na-OU; Tue, 26 Jul 2022 06:44:06 +0000 Received: by outflank-mailman (input) for mailman id 375073; Tue, 26 Jul 2022 06:44:05 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEIX-0001mI-T6 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 06:44:05 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50044.outbound.protection.outlook.com [40.107.5.44]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 571c3e10-0cae-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 08:44:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5132.eurprd04.prod.outlook.com (2603:10a6:10:15::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 06:43:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 06:43:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 571c3e10-0cae-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oMsUdrqHBBS+GlHzQ9Zn7IAR22Ac8GZwf4iYInjfuDzMUUNTusAnovwvpvZvGvPtkuVVt/o9Q00FhKnx17ioXzhH875sVVl6SXb17XOSgZJt67ZVlhUhucZ43BI9nQKqF2iahfUQIJkkmW6gotHSOj/uXH0TPtKkayhQU4RUJiBU5JEGk50j6cauJvAJmu2RrS5luHY//GS4mXcvw4rDiUQb5gJLW1nS2ESr1V4XhTLwNYTAaNUV7NvFOAOQFcLYVudBdOWse+pUpozhF6Yt2t6CpCHXXPcERMR19IVipbX/xIk34YqYAldiSU/Bu8MubUiTo+ZsQDv7uvUDzrVvmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JodecHY5wlWk92we986JthwxWXbstFcsY1oybc9Sdqk=; b=PiYk1xr/Fyy2FAm9N1noMf7bH7NW4M+Lc9ub2zO+QbzqvAGA1Hf96oNCCHorqhkuxVdwVhPyBAfsEwcioyclTfjCWj6SafiMJVSXZ6VSPMc6wsFQQzMO+B0pNDcftEMG75UVcOmqSaQ6Dl4NgkM2Fps6m2/qL98mOz7i66IYFxXcLY0u0FxPIfTup8EdgrePn/pY0JZGn/IvMW0YeNmYs0ph+980uZFKvtFJ4WuToEUHTRtpS/w7c5CKQmODGNzhwRGXsxItpupn/83XAkHIp6rmIKuzvggP34GCqmRsSU0b9mAK0AK9UQ217x2Mqlk0ZNRURI3g2uV0q3542036dQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JodecHY5wlWk92we986JthwxWXbstFcsY1oybc9Sdqk=; b=vTZ6pakDHC8P/HA1gpjks37vw9z0+Q5rew3RRV0vIHeCw7vcD0G5B+/mc1P0Md8U7ELWEeDryCNV1lEc2ZEQdSx+cjgOSSW8vDhwJprarVD0ldoa4dvP9VCfDmS31BEkNLwtIKGd08Xlh87MAgGs2y53cItzlMQ6j/QjU0uy1oVO020ka1Ufe2tqHMHwEDMZ1MGbCKiOTNVkOFp0GP24yyn46rgH1lLiuc+0FfY/5mJ3QJYlyPG0kTWGfx0AR79ecJjmuY+5JfqzKV48EdJgeVzKIFtG47+h083GtbXl+B5hz/NzOZIj/gtIjU8DDFM/vmS8NlZbMMBKkyk+likW4A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <181de4f8-3787-af7a-4c4a-aa5ab01580d8@suse.com> Date: Tue, 26 Jul 2022 08:43:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v9 6/8] xen/arm: unpopulate memory when domain is static Content-Language: en-US To: Penny Zheng Cc: Wei Chen , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , "xen-devel@lists.xenproject.org" References: <20220720054611.2695787-1-Penny.Zheng@arm.com> <20220720054611.2695787-7-Penny.Zheng@arm.com> <903b6203-a475-5a83-0b2a-f3a8fa345b73@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0076.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c276b1e-1b56-4cdd-b637-08da6ed23777 X-MS-TrafficTypeDiagnostic: DB7PR04MB5132:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yc6TAVllO+saWiUa5TwIWHTz+6VgPcMaCWUpVuIEIda4e1+nCV3SNFtYOIsFLf+W/QS2xGPLku5IpAibQjQE6iyKQwzD7PfYodkrx0jwaG8f1o7euWBljC4o6ENwkra80sPEGkSLgzmjQtmoBZsDTqX3akf0jMryfOi2E4nUn3/qgd/V0Z6TA9UaWUsBgSdP/DFrUFycizUJd/WZEtfKhk5GccJEaEA4ZupsTMbOTEZ54kncD/hsG/dR6FISRF1AFa0DP/IHS/pNxR8ScqaxX5SZrRDq3/dYcVYRW2Wguta2veclLtzWE9WZ5jpZCaIHGBHa4jZaFa2ag4YEAHiddI24qejTmh2vfl+1NjPMRMhITd0xdfa7BlXhBQEIs3DPbHIIrbz7NfQoZqZe7h4PQXVE4WFaCL+ypekg7VnUam2mysHjeU1gDqapra5qWdPg92Hr0aJxEjTzf7SoAcgak+nULz0aTOBJ9julR1NqeF/4FY6XeurFGrQyuE/hkURguz/fpnc7qmK1X3K1Akj5K3N+TrSnuY9qVphez02osg0cq5t6xmYcEKgQIwASABrAVwqWAYOKYxsJLY5cTxy2wWfIpcQVORsfbb6eDrEPnvW866W0fdkBQ+NzjCzwWS0/+O0bbU9hV/UHcxZ3RTqveTKrk6jvoRBFOsEgHtN2+w/cYdrmHp01DemYE1D/+AlZ4NdvCDg2vowCY9XkDnross+/Za1LoeuzwXk8ogdmgj4OQYyXGrBAZD1D0jKbpTBZLd3dPJnhi7PYMf2DmKG7iOT35/A6gNrbiFfFH1B/e67QkjX39yMdppQbEstHALmFd0c0tXyxzhlAyiwpIIDc5g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(396003)(39860400002)(346002)(5660300002)(478600001)(8676002)(6862004)(8936002)(31696002)(6486002)(86362001)(2616005)(83380400001)(2906002)(41300700001)(6512007)(26005)(186003)(6506007)(53546011)(36756003)(38100700002)(31686004)(66946007)(66476007)(66556008)(316002)(4326008)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDh0Rjc4VUN2YXdnd2MrTUdUQWVndFpVM0krWGpkVGRUTk1jL0lvb1VVQ3Fu?= =?utf-8?B?Q3ZzSUdMNlJ4STd1QVYraUpDazJ4MTFYdUdtSlJrSDV4c2I0TmFxVkhpSGhS?= =?utf-8?B?S2Ivc2xmRnRveVN0U0JkdklEeElGeTltVU1Db2FsTVFDc01QK1ZrZVk4amxX?= =?utf-8?B?cytacURVOTBwTFBKRStjaGxYaDlZbTVYcU5ENFhyR0FVZzF6YWErdEhDZ1pP?= =?utf-8?B?L0p4dWhjckdXTjhJa1dielhsN2ZhUElEeUQ5elBnTWd3SnB3ZDJYWDdydnVy?= =?utf-8?B?TDJKNGhnSE00ZWJucFIyeE1CZ3dWck4xYlovUFdBOVdvZEVxVkU3TnAyQUR3?= =?utf-8?B?K2hLMTZtaFgzTng5dE9BUzVjb1BqbHdpTEdVNUZtVmRoYzJTTE9QbWFuSWdJ?= =?utf-8?B?RVh4cXE4TlFHWTVxUEJ0aXpTR1JqM2d3NmZqUlYxSWpieC9qNElmb3h4MkdW?= =?utf-8?B?T0tkM3pCWGZXdE9tSmMwa2ZHZzZHajBEYjFwMkpiaDA4TEdiK1RnQVYzbkRO?= =?utf-8?B?NldIdVlFbDFIOEhpRlF1T2FGMm1CdzZoNTRkdVloU05xaEVtak9hcWNXMDBu?= =?utf-8?B?VjBsWlZITklVVVMvUjBWK0RFMHBxWSthcDNkWGIxaTFYVUNwSnRPWEViM2dx?= =?utf-8?B?VUs5L0ozSURBTHN1dlAwT1NMRFFNeUwrYjQzVEZpUFQ4aUdIbW93Tmx5RG1h?= =?utf-8?B?YTVhRmFVQmVhVjF5WFNSWm1GbUdpWk1BcVhZL2ZSMUJPOGR3MjRyMjJBTmxw?= =?utf-8?B?VnBhc1MzcVU1UEpBRHZoMGoydzJRcHprSUFXSExsVERhNFAvSGg1TXZmZUJz?= =?utf-8?B?Qm9zN25tNFNXcGRLVFFPTGVTOXFYNk41Zk1yUWR5RTdOaFgyeU9VR2hPZ1Iw?= =?utf-8?B?MXZLaWtuWllOb2V1UUpMWlFyaWNFeFB2V2hNYkNBTTRlbXdwNU4wcUJxMlZL?= =?utf-8?B?S0xWelh3U1VtUDBkYjNJY0xXdG9FVmZlNWZMVzZSTktyN051d1h1bEVVaDcv?= =?utf-8?B?Wmh2d0FJRFNqa3J4ZjJZbVhUWStpaDNTNE1GR1I5dWZUVTJ2RXB5QTdNZjVP?= =?utf-8?B?RzBpVXZjZWd0d1JmZ2UxbFRKSUJoZW1STmJLWThXaWtKUnNPUVNVTEkyTkdO?= =?utf-8?B?N3lLaEZETktKbkxWWEJsMVhEamFtM3doQ1ptczhuSHREWmZFVkQwdzdjbnlV?= =?utf-8?B?VXlGMEhzbjNCbXNIeVZtOVByekV3aURXc0VNS25VbnVwb002U2Y0dnh2QWdY?= =?utf-8?B?SnpyYzlaUC8yT29MZTRHWDE0Zjh5czh0a3pDbS9UdEk0NldHSW5mbGVabW1Y?= =?utf-8?B?M0hIYWR0cURhWGxxd0NTMTBEaUMrOEF6aGFVY2czRU1sZEl5eXFkd3laOXIv?= =?utf-8?B?SVR1VXBTb2xhMzc5THQvL1FBU2VPMHp4dnE0SVFsS2toL1RkeFZFejVDS000?= =?utf-8?B?SHluUklSeVhhOWpsV3lvcnRSVGMxQjBVcVE5S0FnVGFZRTFOc3lsbThFc0NB?= =?utf-8?B?UWpTajFaZDgzLzBLODZ6VEpQWGNQVHNiNUtWazg3akZYTEdaOHVFNlhmR3Ba?= =?utf-8?B?cWhiODFoTTdoNGhDV3h3L2NWSlJsRXk3cm5NeGdJVU5yTWdQN29CL3pBYWhy?= =?utf-8?B?cDFzRnRxRmtmVzh5NHBlYmY2bGtyOXUxQWtvT01pN05BbWlYVVJKYkduYVFG?= =?utf-8?B?Z3hNREZvbE9jVmM0aVFwc0ZtVXhpMXU1Uy8wb3JyZFkzR2Npc3YzQ3BwZFBD?= =?utf-8?B?STFhU0FLZ2FMMEFZazdDVm5kUGlyZ1JHR21SeEVqTkplcENUeE16OG5ldjFy?= =?utf-8?B?SVRmZTBIQUY1ZEVyQmRkeGdKMkZma1Z1S043MTR3UHhoaUI2dzgydDdPMVcz?= =?utf-8?B?VE1LbEhUd3VkNnhwUng4aWliZ1p1Qzk1MGU5KzJhT2VtU0RxeXQ5V0xIWXps?= =?utf-8?B?eUZvaC9jWk52UHlFcEhxaUkzaUxLWVE2dVVSdm9DVXBoNGFmY3lSNnZkWWZh?= =?utf-8?B?d1ZlR1U2c1RYdkVtS2VXZDAvdmhMenRUZ3IzRmlYd0tvWXRrVHB0RGZLOG5Y?= =?utf-8?B?ZEhsc0VzMDVaajRpTEc1elQxQktwc1lJamFaN2tpa3NGZ3gzL3VjSXdwTExa?= =?utf-8?Q?nE3Y+eGkg/yfz0jIYFBPAC5WA?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3c276b1e-1b56-4cdd-b637-08da6ed23777 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 06:43:58.0532 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kvYoQHA2UuQVegj+r0AYam/6rFRpHrM7OVb0BGFp06QQYlnN9/go2MI69IM1BZ5sVMUnn+WVDVR8S298YcNnnA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5132 On 26.07.2022 04:57, Penny Zheng wrote: >> -----Original Message----- >> From: Jan Beulich >> Sent: Monday, July 25, 2022 11:36 PM >> >> On 20.07.2022 07:46, Penny Zheng wrote: >>> Today when a domain unpopulates the memory on runtime, they will >>> always hand the memory back to the heap allocator. And it will be a >>> problem if domain is static. >>> >>> Pages as guest RAM for static domain shall be reserved to only this >>> domain and not be used for any other purposes, so they shall never go >>> back to heap allocator. >>> >>> This commit puts reserved pages on the new list resv_page_list only >>> after having taken them off the "normal" list, when the last ref dropped. >> >> I guess this wording somehow relates to ... >> >>> --- a/xen/common/page_alloc.c >>> +++ b/xen/common/page_alloc.c >>> @@ -2674,10 +2674,14 @@ void free_domstatic_page(struct page_info >>> *page) >>> >>> drop_dom_ref = !domain_adjust_tot_pages(d, -1); >>> >>> - spin_unlock_recursive(&d->page_alloc_lock); >>> - >>> free_staticmem_pages(page, 1, scrub_debug); >>> >>> + /* Add page on the resv_page_list *after* it has been freed. */ >>> + if ( !drop_dom_ref ) >>> + page_list_add_tail(page, &d->resv_page_list); >> >> ... the conditional used here. I cannot, however, figure why there is this >> conditional (and said part of the description also doesn't help me figure it >> out). >> > > I was thinking that if drop_dom_ref true, then later the whole domain struct > will be released, then there is no need to add the page to d->resv_page_list If that was the intention, then it should have been spelled out imo. But I think it's not a good idea to skip the list addition in that one special case, when keeping things uniform is actually cheaper _and_ more consistent. In the end I expect sooner or later there'll be a desire to restart DomU-s which have crashed, which would include re-using their designated static memory. Then you want to avoid leaking pages like it would happen with your approach. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 07:52:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 07:52:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375086.607376 (Exim 4.92) (envelope-from ) id 1oGFMV-0001Cx-2u; Tue, 26 Jul 2022 07:52:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375086.607376; Tue, 26 Jul 2022 07:52:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFMV-0001Cq-08; Tue, 26 Jul 2022 07:52:15 +0000 Received: by outflank-mailman (input) for mailman id 375086; Tue, 26 Jul 2022 07:52:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFMS-0001Ck-Rc for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 07:52:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80057.outbound.protection.outlook.com [40.107.8.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id da282a32-0cb7-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 09:52:10 +0200 (CEST) Received: from DU2PR04CA0251.eurprd04.prod.outlook.com (2603:10a6:10:28e::16) by DU0PR08MB7639.eurprd08.prod.outlook.com (2603:10a6:10:320::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 07:52:07 +0000 Received: from DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:28e:cafe::f) by DU2PR04CA0251.outlook.office365.com (2603:10a6:10:28e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25 via Frontend Transport; Tue, 26 Jul 2022 07:52:07 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT045.mail.protection.outlook.com (100.127.142.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 07:52:07 +0000 Received: ("Tessian outbound fccf984e7173:v123"); Tue, 26 Jul 2022 07:52:07 +0000 Received: from 82e95c8aea08.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 80D137AE-7316-4240-A01A-48F06EDFAA67.1; Tue, 26 Jul 2022 07:52:00 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 82e95c8aea08.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 07:52:00 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM0PR08MB4145.eurprd08.prod.outlook.com (2603:10a6:208:133::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 07:51:59 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 07:51:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: da282a32-0cb7-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=H4KHBNCiq6+jVEer135vGpkRh8vZlmIRa8r0LAQil1tIMH8SPO9YAFHsL7wbLOerFEHZJ4eVYbPffkqDb+KI0tcctT6Z8VwIHkEGUgEDBYHVKekUSomrjEJ1I7G7Wd4rxO3wRzpGSOxL/3mR4Z7T4udDcwvaTeV2iTPMtPPUNa61AJxEcEjoiowDlG4ZIVUYL3xbKCM8ZkXNKChr8x5OQgN2lbl/K9Op4YuN2p9chN3cfsGEVeOhiBijxwo9yQKtQZbSrs/DcOQok6Jtw3S8nR9KWRBXS98J3h3P30pewc/MGQqMihoN0byO0gvrXRHN9NDGlCZNv8jPaj4zX2UHnQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQnlmttYqOPT1dDCAwnA8aCVAkKTAhXyjkUyxzQkV44=; b=fS5DU3xGpYsPnuMW8ABnAPDm9Z0rywDYUvRxXg1sqm2Ax+1FTG4MGClkQEXKlUxipZsjGjjQx4b/l8A9jZNalhxm9SVH5dR/AYmYiVqGxHi9y1AmNW7pI+2f7Ee3A+haOPHZfEYkhCGN5l5ZB0ny2rRqRkHk0qWbi4VlqboqirEgPP5gi9I+6bkWl9B+rQN9HCx9UPfAnjiod6tGwcpOuDfU/c5qcY6Q5tC1zJ1wahpnP889KQGD4XqfXoKKUKFQiTOav77O/PNVQl8XCwPFW1thq2ytJ0UhUaOmZkPfgA23oYHUgCKVJVUTsITOxrqnsY2L655AkYjbCFl3NJrVKQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQnlmttYqOPT1dDCAwnA8aCVAkKTAhXyjkUyxzQkV44=; b=M+MXCrQETyl5U7deOBZ2GbWhGz+/DeNCajx2K0VCJVp7ez7D8ZmcjlGMqXqe3DWOiCVZVEQKUiDdSVW1PC1wokEIAtl482NEzUxf0YhsKKvRp2KGc1gxbRk2YTRtMvfPUPJnef7RroZPvIjeNac/LSpW4iBOPkXfDZJkzANcCl8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c2a480c9381b007a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jHwACtIZByjS6owe3Ucecd+G/YbxNAwQpJrdpKrlH/Lhf1NDCWZ5N6h3LIno1uXQoM3a2B6dQUnu2py5u8FVio5RmzW0fhK0JJoqwO2QvAuzzPLlTKiL0WSAy3ecWEHVhTmo1Mw+unoKC6U22UxSoi6/1Cby2tILb0bYA7gn/fvWKN6T4zkjkPeb+3hsjtMt3HF3uioootAqg3feWEk1w5rD/p9nXfoc45KknOpt4iO2uFMSzC+MO5Sjpk9JFggO1eK8zzxxfMBkTyTy1MEMnGPR2lG7kjXjD+jp8AOI5A4218yNlUeeXwmZZFMUPODQ6OhDs2/jTUt+kmxRPiBZ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQnlmttYqOPT1dDCAwnA8aCVAkKTAhXyjkUyxzQkV44=; b=GbrDzItAEIQiCPKTDOLDNfRLTbAp307Jy1cs1GQXcE1BbVX0FOWMTqMQE1aHcogfvzvVSpRu7RLPbDmozw49HX6nPZDZXpc5oxm+usc7oqBylFAn6WA5NaV5dkLnTEgGHfpJOZWccbfA5vFBariTs4h6RSBYAmvFIFF7jkodvXI46XJCE/4XcC7us+9s/pCoEYwz4p24lJfBGVuQL9eNr+yXHSYyaSJzCM4a/snXuNe6ye2tpjeb5buYMqHSYiw34VrvnYfuAIeloVNHLRUfLuSl03aRhoLSFdbswq8HQ3vylK73KcBttWxIb4TjwGw2VCHKVgl5N3SSZwrXe65oEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OQnlmttYqOPT1dDCAwnA8aCVAkKTAhXyjkUyxzQkV44=; b=M+MXCrQETyl5U7deOBZ2GbWhGz+/DeNCajx2K0VCJVp7ez7D8ZmcjlGMqXqe3DWOiCVZVEQKUiDdSVW1PC1wokEIAtl482NEzUxf0YhsKKvRp2KGc1gxbRk2YTRtMvfPUPJnef7RroZPvIjeNac/LSpW4iBOPkXfDZJkzANcCl8= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , xen-devel Subject: Re: Random crash during guest start on x86 Thread-Topic: Random crash during guest start on x86 Thread-Index: AQHYoD5xXkzOB8H120+6SchUWgFyYK2PQysAgAEFgQA= Date: Tue, 26 Jul 2022 07:51:58 +0000 Message-ID: <880625A9-C3C8-4D45-A4E8-BB443E9D4CEF@arm.com> References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> In-Reply-To: <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5853f7df-088d-4910-46c3-08da6edbbcd7 x-ms-traffictypediagnostic: AM0PR08MB4145:EE_|DBAEUR03FT045:EE_|DU0PR08MB7639:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: VDaYMtB+5oOG1rcBEzYb6vneTneYUzu1hRmwucGa4UaD5oiJyRO7btY+cnJtZGh4cdMbybgFtpXQWMVQB4OzgUOI0Rg0HyUuB+d5nit3kAJHHf+3z0TNHbb0+f1M7zQcgbSUVApcFoxBtYTnnOWcFM+1txcyHAFb8ayYQM5jtxq+gsDjRXcsec13q+Kgxx/UjgHODHhcaUIl3ckLK3PH+a9oFaIUevCP0kSfc5d7UqoH3Ui5u3nOUosqpo1UgbgiTIQHBj+d4N2netkwpoJWZcvrpk0FW21wfEF5U2rusYFFGq6jE50I4FKMITnJYF2gtqezu29l4sIxY1tPAyYw46ewd/53qer2vgjfr83UbvRAXV2oZXMHffpCN8v7A/QJiiVwpN92qDGHeiJLUEp3QigkCwOj6zGRJ1z1Q062GCXpSiQgyPloZ19g4JBbAY0HRw4FobCdoP9OQm/BHo2yEoDpGPjFYj4Trw8mGKiKy5bVxy0B2DkTJQ00SvL+HqkycXdmlN4/6xQBFk5Pl8JTujEmKXa28/smvDiHuwlv9tF+BZw8j3yPrFq1kFu22pm4fJUF2D5chOKae/d6Yc1qkwvKBjUV4UJh9Msw7TyypieSgZ1fokbkiiJbCNNl245LwTsEOiR56L2wq9XhaQQuJkYRJkmn3Yk8rO+L8LOwXD0RVMbOTBF/ajxJxfMFMAFZajkop/6EmQAuXiuWizV/eC86O12pLbi94fe99CC2OpNd1WQxv+ZeHg2rlsaEyjMYrsSUdNMMPCa187o6VbIUHQN882uuav3RXabPi6DiVDkBidtfqfFVp4/JHaE69Vmd3kDnXp9wXvPQO+TUEqSXsQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(366004)(396003)(376002)(346002)(38100700002)(122000001)(83380400001)(36756003)(66476007)(64756008)(66446008)(91956017)(76116006)(8676002)(45080400002)(66946007)(66556008)(38070700005)(4326008)(86362001)(54906003)(6916009)(316002)(478600001)(6512007)(8936002)(26005)(6506007)(2616005)(5660300002)(71200400001)(6486002)(41300700001)(2906002)(53546011)(186003)(33656002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <5697BC4DFB5DFE41A8C08C33E52950F7@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4145 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 45910c76-fdd2-42b0-334c-08da6edbb803 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SsKXAjHBfMuc9QmgOudsfK1j6arrJ9jpmfGvyAE/q25N5qIfTBmHJzMf3iAKXUAnsAZV5dS08hCDe9avdad1d7RXko5vWcsWMqdF/qkeDcBXv0PQ5vG9w8BXVmkp6L2jnA+z37VYJHZ3v8K5Ny2i0bqz12yFJ+vEzs/Ryvzg1rubMEKNpPQTA0rgGjbhhuusN5IIlpm6O9va/3u909O3Ewxv9WoM0fzSKMh+pUHQBHF4Tph8Xii9iClZ4vGvSzyCBkLZvE7e2wFFaRPq6CTIsqlv8wYu1zH8JH+ZJan5aLfXXpi4FJO3Ilwh5M+8xkjSCi6h3Y7wzAlEkhaSVZESm0FYMajrZMI69no6VhBPKCp66xnjgtNI3KLFsWT803MGoT2LLc1ErQImzvvdFi7TmvGR2E0uCNRe0rV2JScoO5tbVtkBs6JqApU9pRT2R8Cwv4eLhT0Z77ToMhNmSzOAu7hBOgJ3YhBU1t/ysmo1oMyl+I5XhZ8dAuy440fbo7TeQeh/6u9zwJKzpeshAg7V1S/HJ1r+LIDC/y5oZoWHdYrBQlm/SVzykyLptHZ1Il9l0H1+u1p7WQPHfI9kejfDsBvfR5NzAlO7gUTAhpjnIo6ZviquE7FQSwIzdBldwSd4fX98NSNV7vLxc9uQOyXsV9YMNmPr+4LmINHlW4TMLfzxO2DKVgu8gsZOBiVVymTijApoH0KD8zWJ90Zr2UTOaIuZ1RVQnKzo+oOj4F8VbO4dWvE7+sME5qLF5+ixA8ZNh9rgAlf8I1hIBAl6RSEidUbZHKplzbV+b3i1ysGQv/gBOmlSbtcb9W8fmaL5mYGE X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(396003)(39860400002)(36840700001)(46966006)(40470700004)(316002)(6862004)(54906003)(36860700001)(36756003)(6486002)(45080400002)(8936002)(70586007)(70206006)(5660300002)(4326008)(8676002)(2906002)(26005)(53546011)(2616005)(6512007)(40460700003)(478600001)(41300700001)(47076005)(82740400003)(336012)(6506007)(33656002)(83380400001)(40480700001)(81166007)(356005)(82310400005)(186003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 07:52:07.1464 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5853f7df-088d-4910-46c3-08da6edbbcd7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT045.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7639 > On 25 Jul 2022, at 17:16, Jan Beulich wrote: >=20 > On 25.07.2022 17:51, Bertrand Marquis wrote: >> On our CI we have randomly a crash during guest boot on x86. >=20 > Afaict of a PV guest. >=20 >> We are running on qemu x86_64 using Xen staging. >=20 > Which may introduce unusual timing. An issue never hit on actual hardware > _may_ (but doesn't have to be) one in qemu itself. >=20 >> The crash is happening randomly (something like 1 out of 20 times). >>=20 >> This is always happening on the first guest we start, we never got it af= ter first guest was successfully started. >>=20 >> Please tell me if you need any other info. >>=20 >> Here is the guest kernel log: >> [...] >> [ 6.679020] general protection fault, maybe for address 0x8800: 0000 [#1= ] PREEMPT SMP NOPTI >> [ 6.679020] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.6 #1 >> [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 >> [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 = 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f= > 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff >=20 > This is SWAPGS, which supposedly a PV guest should never hit. Data furthe= r > down suggests the kernel is still in the process of patching alternatives= , > which may be the reason for the insn to still be there (being at a point > where exceptions are still unexpected). So the exception path is using alternative code ? Sounds logic with the err= or output. But does explain the original error. >=20 >> [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 >> [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e= 00fa7 >> [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000= 000eb >> [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000000= 00000 >> [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000000= 00000 >> [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000000= 00000 >> [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0= 000000000000000 >> [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 >> [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 00000000000= 50660 >> [ 6.679020] Call Trace: >> [ 6.679020] >> [ 6.679020] RIP: e030:native_irq_return_iret+0x0/0x2 >> [ 6.679020] Code: 41 5d 41 5c 5d 5b 41 5b 41 5a 41 59 41 58 58 59 5a 5e = 5f 48 83 c4 08 eb 0a 0f 1f 00 90 66 0f 1f 44 00 00 f6 44 24 20 04 75 02 <48= > cf 57 0f 01 f8 eb 12 0f 20 df 90 90 90 90 90 48 81 e7 ff e7 ff >> [ 6.679020] RSP: e02b:ffffffff82803b48 EFLAGS: 00000046 ORIG_RAX: 000000= 000000e030 >> [ 6.679020] RAX: 0000000000008800 RBX: ffffffff82803be0 RCX: ffffffff81e= 00f95 >> [ 6.679020] RDX: ffffffff81e00f94 RSI: ffffffff81e00f95 RDI: 00000000000= 000eb >> [ 6.679020] RBP: 00000000000000eb R08: 0000000090001f0f R09: 00000000000= 00007 >> [ 6.679020] R10: ffffffff81e00f94 R11: ffffffff8285a6c0 R12: 00000000000= 00000 >> [ 6.679020] R13: ffffffff81e00f94 R14: 0000000000000006 R15: 00000000000= 00006 >> [ 6.679020] ? asm_exc_general_protection+0x8/0x30 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >> [ 6.679020] RIP: e030:insn_get_opcode.part.0+0xab/0x180 >> [ 6.679020] Code: 00 00 8b 43 4c a9 c0 07 08 00 0f 84 bf 00 00 00 c6 43 = 1c 01 31 c0 5b 5d c3 83 e2 03 be 01 00 00 00 eb b7 89 ef e8 65 e4 ff ff <89= > 43 4c a8 30 75 21 e9 8e 00 00 00 0f b6 7b 03 40 84 ff 75 73 8b >> [ 6.679020] RSP: e02b:ffffffff82803b70 EFLAGS: 00000246 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] insn_get_modrm+0x6c/0x120 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] insn_get_sib+0x40/0x80 >> [ 6.679020] insn_get_displacement+0x82/0x100 >> [ 6.679020] insn_decode+0xf8/0x100 >> [ 6.679020] optimize_nops+0x60/0x1e0 >> [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] ? native_iret+0x3/0x7 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >> [ 6.679020] apply_alternatives+0x165/0x2e0 >=20 > I have to admit that I'm a little lost with these "modern" stack traces, > where contexts apparently switch without being clearly annotated. It is > looking a little as if a #GP fault was happening somewhere here (hence > the asm_exc_general_protection further up), but I cannot work out where > (what insn) that would have come from. >=20 > You may want to add some debugging code to the hypervisor to tell you > where exactly that #GP (if there is one in the first place) originates > from. With that it may then become a little more clear what's actually > going on (and why the behavior is random). I will check what I can do there but as the crash is very random and only happening during our CI tests, this is not really easy to reproduce. If you have any example of code to do the debugging, I could run some tests with it. >=20 > As a final remark - you've Cc-ed the x86 hypervisor maintainers, but at > least from the data which is available so far this is more likely a > kernel issue. So kernel folks might be of more help ... I wanted to check if this could be a know issue first. The problem is happening in the kernel, I agree, but only when it started as a Xen guest so I assumed it could be related to Xen. At the end I wanted to signal the problem, but I will not have much resources to work on this. Bertrand >=20 > Jan >=20 >> [ 6.679020] ? insn_get_opcode.part.0+0xab/0x180 >> [ 6.679020] ? insn_get_modrm+0x6c/0x120 >> [ 6.679020] ? rcu_nmi_enter+0x2b/0xf0 >> [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 >> [ 6.679020] ? irqentry_exit+0x29/0x30 >> [ 6.679020] ? exc_xen_hypervisor_callback+0x8/0x10 >> [ 6.679020] ? relocate_restore_code+0x22a/0x240 >> [ 6.679020] alternative_instructions+0x8b/0x13a >> [ 6.679020] check_bugs+0xa87/0xadf >> [ 6.679020] ? __get_locked_pte+0xa8/0xf0 >> [ 6.679020] start_kernel+0x64c/0x680 >> [ 6.679020] xen_start_kernel+0x592/0x59f >> [ 6.679020] startup_xen+0x3e/0x3e >> [ 6.679020] >> [ 6.679020] Modules linked in: >> [ 6.679020] ---[ end trace 0000000000000000 ]--- >> [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 >> [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 = 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f= > 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff >> [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 >> [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e= 00fa7 >> [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000= 000eb >> [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000000000= 00000 >> [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000000= 00000 >> [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 00000000000= 00000 >> [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0= 000000000000000 >> [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 >> [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 00000000000= 50660 >> [ 6.679020] Kernel panic - not syncing: Attempted to kill the idle task! >>=20 >> Cheers >> Bertrand From xen-devel-bounces@lists.xenproject.org Tue Jul 26 07:54:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 07:54:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375083.607387 (Exim 4.92) (envelope-from ) id 1oGFOh-0001mC-EX; Tue, 26 Jul 2022 07:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375083.607387; Tue, 26 Jul 2022 07:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFOh-0001m5-Bn; Tue, 26 Jul 2022 07:54:31 +0000 Received: by outflank-mailman (input) for mailman id 375083; Tue, 26 Jul 2022 07:27:33 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGEyb-0006kf-1i for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 07:27:33 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2048.outbound.protection.outlook.com [40.107.92.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 682b3060-0cb4-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 09:27:31 +0200 (CEST) Received: from DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) by CH2PR12MB4876.namprd12.prod.outlook.com (2603:10b6:610:67::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 07:27:28 +0000 Received: from DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec80:e3fd:e3e2:605d]) by DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec80:e3fd:e3e2:605d%5]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 07:27:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 682b3060-0cb4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HTT0akrSmxMhMVNNIPxwAq2i+JWBVs9Dx4ziAPIzlqDomIKejSsHMs8DxPXiQNnYJWeJd31gfmUFHU6huCaEeDY5TK6eqoR8SC83/xrVAe19zZYtOj+5LRG9AIi4OqNdiye1WRBU7WdXgNmqCIjjjkUIsGJvI6ZyvV6zU3X9gYC23aOVYgcSoIux1+YaVXS+8d98matO/AjcSutrQviAoNkynGzUyfhfuv66oywjAzGApV1Tevgjc3XlT6uLrDf1VRQSitinJgg9tgtQ/Ls8Fn4hw63qbWO7/X0bEjttLDpPir484XRtP8OVS3dWlbMZHHAVGbpZb4v6X/05WX9sLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=22UwUfqLHVun0WsIx7T3Dig1cCtbEOkI11uEVVytnBg=; b=ljRouiX+SN1SEX7RRbJPYGhlkaH2idVhX/90yu/LOgnrJIk56RqtgzNzuUhkYBqZF7lzEGq/kuuRfPWecVbKZq3cRS9huc6jqPRo0eSjFwcURwKP2HTH3yaYyxJRetiDNlQRomp/ETl280VlUJwkh5fOm6Onm3fjbKzs0KuK1Bk0lPd2VkcBvyoS2MbpEBHjDsgi4hanQPTG8gpHzAXbHWdCZlwuzUypwDkOwEbp2cLG4Z1FufrPoqyNR+zV24YTlRUYFqJvHx6koTrx4ns+HJPmLGgyuiDOnnOaIlLVFygPGc8kK53LcqUILM92Dw2BT7/oXxY8+MhbqAtrkqz5jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=22UwUfqLHVun0WsIx7T3Dig1cCtbEOkI11uEVVytnBg=; b=vn7IlPcrRPz7HmSHiFigAqKNsC3fzL2yQUeUk08KKvW+FQ5MLXGjWtI4fkSuQ+FZDS+MKGOtu8/uX+fA3J388kmKVN6ZHbIHzI9rvOP8aaZP41SU803yAaHHJNyOlcXu1hqvl81EzWSGvnHB93XjHRom+TrlzIjLNkFODZ6v+uU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Date: Tue, 26 Jul 2022 15:27:07 +0800 From: Huang Rui To: anthony.perard@citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org Cc: Trigger Huang Subject: Question to mem-path support at QEMU for Xen Message-ID: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-ClientProxiedBy: SG2PR02CA0015.apcprd02.prod.outlook.com (2603:1096:3:17::27) To DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2d6d8da-9007-4d0f-8b0b-08da6ed84b1b X-MS-TrafficTypeDiagnostic: CH2PR12MB4876:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5HTpbED94Roz8ouAJpF5vu99VXvPWcgJirTwu8fSOuVqNgzGbloSC8iIFaToGUmouwAjxZQr+LVdfvulzQc7g4LKO70IDD+O8Snm62TeQa8jO1CgUaGj/ltpoJ05NTFTxWNVUZTC0eIF5eZGoAgUo3H7DnRWHP5aoUsbjWJ05AfKkmIsYuQZlwByqn5x1W2IMwDK8yHA3Kw7TGKPYmSfSt+Pbeu5xB8k3XA38SPanqtZh2wqu+H+4/vw6roMeZTajMfGgCbySYh+AEMb1oUpY9EMSJ6447uCNQjoe0DCnXHMinluEGnyJ2NgcYX3J3lPm/FBiyPP662TIvIYkCJg1mqiVnSYL+UF4ql9Z09jA57SgSNLmNYCt1Y9w/JjqiIZKVcXQRv5untl8SkskDiyfVbEeZ9bLOPyQqqrlv5PbsmtsNQsc3PieIkdJWgrkgiYSqdAphGXGOb6Y+hOTp5LIAocomg0Uc2UoE4/bj5bqV9uv6qXoouk7ZJwC9a9raUWL9bsa+vYV4Y2AGP+rdDdNaniBjW+ji1JTHvwIDCWNoBPjQJlMmXeiGna25qjczUZzoJ/CGoqjYholKWs0QF/YH+MIsBLEGn6339chnlqnk3geLwL93+MEf+jpXEsu4c+lQazrrrs9YlccXRi4K5puwvU7aIPbQrYB3adUEHwMhaQE1bhtjJn3Q3LjcYbO7qUNRaCLS9RD6C58sfuVdLOh3xFpT2DtBnQ6BLu17qfKz1THiTQrobn9g1pE00+pqh4wegIzeW1dIQOPn35SbESDYVgwnj5+REdFTqTF5tX7BM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB2504.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(366004)(396003)(346002)(66556008)(66946007)(8676002)(66476007)(38100700002)(6486002)(4326008)(6512007)(478600001)(26005)(316002)(2906002)(41300700001)(86362001)(6666004)(6506007)(83380400001)(4744005)(8936002)(36756003)(2616005)(5660300002)(186003)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/ZGtlzo7NQu79UfERErzBw0ueK0BGgF12+O4DYn3fCWlhyaxUxxMSd/hFbJl?= =?us-ascii?Q?wQxi+O0XWcN8bGq4RB9QlJYki/272puJAN/ti14tDNd1vodCnGDOBZnDYav6?= =?us-ascii?Q?L9PlsFE88eTaU03lS9iMRcbY9Y0IyLHqjoXJvMWfRo9n7tVRtIJd0ixBxj+m?= =?us-ascii?Q?RjTXqOp/lBwtKR06t1/6/3M2gEiJVCWDoyhYQdQJrGvJ61B6kVwprw8F6tuH?= =?us-ascii?Q?NmmY0R/OLuCEbCznaGrkx9oVYpSJI0VBICQB6Q6izJDPi47VfTB01KeV9Ntl?= =?us-ascii?Q?J/8drnHzgBwroXiD12wJUm855U3VyKErom/0LwCzwmV2A+1EU48rsE0X6CzR?= =?us-ascii?Q?NO69aQ9Hjlq4GW0UkUk2hloiIG1z07MFN6+vzc1TK1BR8DYfzQxuPYodnYc+?= =?us-ascii?Q?q4OzG331FZx6FbvkfakmC0Oz8pdEklDhEHWWy2zYLPKHn3COO8vAEBSCTEA8?= =?us-ascii?Q?EYOAvrfnCDoKDy7LHSUcnQrpPSSS9TuoM5mtnPwxQ/vcb64MCx1gWR3kMgej?= =?us-ascii?Q?L58qm6VpTwm0JEFYs91qQA2Wvc0Pw/APQhx2/4mxOlnc+bybb0k79yQqpJPZ?= =?us-ascii?Q?pAYLlw37Q54uCtLyt9TtxBEN223WrWrFjpAicjunDHGrQmYSOFpjitwxAhjR?= =?us-ascii?Q?adL4o835kqjPNIBgf1JkTUnVlm/5XWOeHsZWUEjU5r3PZxFuMW0f5HSJrXDP?= =?us-ascii?Q?7hD5thWw/fr9a7CDFpydwu/j/WAgqnAVhXpJ2wDHNdMftEqYoj6FG0TuiIbR?= =?us-ascii?Q?N1mG2EWTf8VTEAXwYqEkLMdsjfSAf6XBH4HpPIHDQseBfH858jU4zx8kFrPU?= =?us-ascii?Q?5S2MhTHWGcOAN2VpQxROMbaB04I4iJabfhwaimH+W5h2C89P73Ba2dHDDzjE?= =?us-ascii?Q?2RcPYs2FE16NP6Z2Nnc3BKi2lPxbbmy9dTkPy8ijeojKcIW2PVI0N/ATcJNe?= =?us-ascii?Q?BeMQNjeVXHsZYV37rUKGLi5vxpRFh0qo051hH5rx/EGuZuuyfAuP6E5nZJiZ?= =?us-ascii?Q?BCe2QcinUJPVBbkxiZparZ3XMcBkxR7MAliI0U7aEBJB2P7/RifWm7I280uW?= =?us-ascii?Q?9TB3nFEHnxAIUFwXr2KHm7D2jEEMeAFeLPoXAQDYI5kloCtRHfkZWyoLlnkJ?= =?us-ascii?Q?a3zSFgVn5LluEh0FfFtoRJ/3QOj402F7OKCGMIVUPwYYsDje/QcCSkxSIQrw?= =?us-ascii?Q?F6ALixn78QGU6gvgWsiGrpynyBM97I1pOW+NbdVex1uP94pIlY1hC/BtQ3LW?= =?us-ascii?Q?qWbcgw2czHYFKZ2tcfPzWPEWMUZxKiHZhTyzZF5VbjIlQBDVUWmYtlefmeNB?= =?us-ascii?Q?jBCKlB5/Xt6vK+mDMe4ivExBeKLwyaYYRq4UWYAyu/zmWWzIzRs/Se6TzyrV?= =?us-ascii?Q?9vbGlLjgs4Go/zm3BnNT+3B/aYl6w0SsbuDcmqkn2eD+/KawfPEBFnyxoi++?= =?us-ascii?Q?v1P1Xz5DiIUIC8gzM5jqnJJlBHjfL8cZLREXxmboEkVQNK3VZ5xTrwwwp5rh?= =?us-ascii?Q?myS0WnUSaJM4eHeFxEVUO8FmDw4W+YpuBTcCtWbi5I5BvBUr63vpdgqnL3Qi?= =?us-ascii?Q?cDPy+CL6ADg7Fytsb+eNHw6NM0juGvSnNIo9kDhb?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2d6d8da-9007-4d0f-8b0b-08da6ed84b1b X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 07:27:27.9683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ENv+5gf61BqVaY1rdExOwyOUAkRHY6kmNvTgwCQBZ+CHsIiYLW+MspTaVpx9BD5aIQGDcJKyccMa2MCdrWdRgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4876 Hi Anthony and other Qemu/Xen guys, We are trying to enable venus on Xen virtualization platform. And we would like to use the backend memory with memory-backend-memfd,id=mem1,size=4G options on QEMU, however, the QEMU will tell us the "-mem-path" is not supported with Xen. I verified the same function on KVM. qemu-system-i386: -mem-path not supported with Xen So may I know whether Xen has any limitation that support memory-backend-memfd in QEMU or just implementation is not done yet? Looking forward to your reply! Thanks a lot, Ray From xen-devel-bounces@lists.xenproject.org Tue Jul 26 08:27:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 08:27:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375100.607398 (Exim 4.92) (envelope-from ) id 1oGFuo-00068r-AG; Tue, 26 Jul 2022 08:27:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375100.607398; Tue, 26 Jul 2022 08:27:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFuo-00068k-7V; Tue, 26 Jul 2022 08:27:42 +0000 Received: by outflank-mailman (input) for mailman id 375100; Tue, 26 Jul 2022 08:27:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFun-00068Y-4v; Tue, 26 Jul 2022 08:27:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFum-0000eY-Uh; Tue, 26 Jul 2022 08:27:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGFum-0006fq-GX; Tue, 26 Jul 2022 08:27:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGFum-00034o-G6; Tue, 26 Jul 2022 08:27:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rh9koMzXobliLPs5XSZmnGmTubJOKxah7lIrK5MVQuM=; b=xG1dVMIA5KDX+BQ/MK+M8nbyvI dOr4kGSrrNX7C6eOaPVBzhnuCLc4e4FbajaqDNo7JhGnWI57LR6dnA9+xnRMEDroPwsqW3hAxl1mV TNQBRfbpMW50odgcVtroghIiqd2RXKrqKrUAsITI9UGE1jnevqnhJQeF8V4nwiaxPUHA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171859: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-i386-libvirt:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-raw:guest-start:fail:heisenbug xen-unstable:test-amd64-i386-examine:xen-install:fail:heisenbug xen-unstable:test-arm64-arm64-xl-credit1:guest-start.2:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 X-Osstest-Versions-That: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 From: osstest service owner Date: Tue, 26 Jul 2022 08:27:40 +0000 flight 171859 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171859/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-libvirt 7 xen-install fail in 171856 pass in 171859 test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail in 171856 pass in 171859 test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 7 xen-install fail in 171856 pass in 171859 test-arm64-arm64-libvirt-raw 13 guest-start fail in 171856 pass in 171859 test-amd64-i386-examine 6 xen-install fail pass in 171856 test-arm64-arm64-xl-credit1 19 guest-start.2 fail pass in 171856 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171856 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171856 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171856 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171856 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171856 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171856 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171856 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171856 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171856 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171856 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171856 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171856 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 baseline version: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 Last test of basis 171859 2022-07-26 01:54:33 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Tue Jul 26 09:27:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 09:27:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375110.607408 (Exim 4.92) (envelope-from ) id 1oGGqI-0004Q0-No; Tue, 26 Jul 2022 09:27:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375110.607408; Tue, 26 Jul 2022 09:27:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGqI-0004Pt-K7; Tue, 26 Jul 2022 09:27:06 +0000 Received: by outflank-mailman (input) for mailman id 375110; Tue, 26 Jul 2022 09:27:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGqG-0004Pn-HZ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 09:27:04 +0000 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1a8f96e2-0cc5-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 11:27:02 +0200 (CEST) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id DE2475C00D7; Tue, 26 Jul 2022 05:27:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 26 Jul 2022 05:27:00 -0400 Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 26 Jul 2022 05:26:58 -0400 (EDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a8f96e2-0cc5-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= invisiblethingslab.com; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1658827620; x= 1658914020; bh=+wJoavldm8HPsBPIDP3IZJuPjs0jO0zNoXJY/2Atyyc=; b=9 x6GUa48GKH6etSj4gMO3imx8w2jKRiDhX+Fa/56So6sBLWuMMVAVndo/VtmxPPgl 5bRTy+o26EiOtv6s6jZjOo59Y/X9clJmuxNuXq1J8C0STvlZ9viArJAf5Jws1PO+ iKXj839TMDf4IqZ/C+EzJ6lWByOAFc/UuvIv+Ry1aS69dF7LEO2rRUngLBXTwqIf gWEO3XGxpaxNyfsZvUMz+vUbBpooxR+UXwFXQ8DSlHz1oGHpHSiANMf6eKz7iT3O haZKOEGdVR1pdt6QCtWM1m+rXAhakp6of42PoFCDyF69w4E+ECnY1hQdUnhuRLxb 0YYN4g4Cgg9TjtxbfkC4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1658827620; x=1658914020; bh=+wJoavldm8HPsBPIDP3IZJuPjs0j O0zNoXJY/2Atyyc=; b=HAe7oFSuPJVtWKEL6zcAar7WRN0PYLyWZEyxJqfcoBl3 C5eK/u7Psgun26c04fN3u/Yp3w7KCq+ZW+Xsc3DCTL0bkX2WQLJ9MiqfIUm+KBLo voLb1zD4frNAZDjNs4IrDgIi3LYXPOD5J+oX+0Zw6Gals2ukPe5CQHwRF8iB+EeK ZPEsRWcDeQ8Z4OG5of6DK4EX86HShM0GKG5qjT3CA1fL1TphD1Bb590HBei6O2HW 8qj6ZiSBh8nUiplbB60YULhRWucYaVbxLsPIgaQI8FL9f2W2kQ94zQgl5pGbmvNz oCs9UMilbaWTwlsswY5qlRiOARCvolzFb5eheUOc2g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvddutddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofgrrhgv khcuofgrrhgtiiihkhhofihskhhiqdfikphrvggtkhhiuceomhgrrhhmrghrvghksehinh hvihhsihgslhgvthhhihhnghhslhgrsgdrtghomheqnecuggftrfgrthhtvghrnhepueek teetgefggfekudehteegieeljeejieeihfejgeevhfetgffgteeuteetueetnecuffhomh grihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgr mhepmhgrihhlfhhrohhmpehmrghrmhgrrhgvkhesihhnvhhishhisghlvghthhhinhhgsh hlrggsrdgtohhm X-ME-Proxy: Feedback-ID: i1568416f:Fastmail Date: Tue, 26 Jul 2022 11:26:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability Message-ID: References: <49d7ee9e-effd-6385-c46d-2218f84e6ba3@suse.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xK4aUJW9n77/dsBk" Content-Disposition: inline In-Reply-To: <49d7ee9e-effd-6385-c46d-2218f84e6ba3@suse.com> --xK4aUJW9n77/dsBk Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Tue, 26 Jul 2022 11:26:55 +0200 From: Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= To: Jan Beulich Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Roger Pau =?utf-8?B?TW9ubsOp?= , Paul Durrant , Kevin Tian , Connor Davis , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 00/10] Add Xue - console over USB 3 Debug Capability On Tue, Jul 26, 2022 at 08:18:40AM +0200, Jan Beulich wrote: > On 26.07.2022 05:23, Marek Marczykowski-G=C3=B3recki wrote: > > This is integration of https://github.com/connojd/xue into mainline Xen. > > This patch series includes several patches that I made in the process, = some are > > very loosely related. > >=20 > > The driver developed by Connor supports console via USB3 debug capabili= ty. The > > capability is designed to operate mostly independently of normal XHCI d= river, > > so this patch series allows dom0 to drive standard USB3 controller part= , while > > Xen uses DbC for console output. > >=20 > > Changes since RFC: > > - move the driver to xue.c, remove non-Xen parts, remove now unneeded = abstraction > > - adjust for Xen code style > > - build for x86 only > > - drop patch hidding the device from dom0 > > Changes since v1: > > - drop ehci patch - already applied > > - adjust for review comments from Jan (see changelogs in individual pa= tches) > > Changes since v2: > > - add runtime option to share (or not) the controller with dom0 or oth= er domains > > - add RX support > > - several smaller changes according to review comments > >=20 > > Cc: Andrew Cooper > > Cc: George Dunlap > > Cc: Jan Beulich > > Cc: Julien Grall > > Cc: Stefano Stabellini > > Cc: Wei Liu > > Cc: "Roger Pau Monn=C3=A9" > > Cc: Paul Durrant > > Cc: Kevin Tian > > Cc: Connor Davis > >=20 > > Connor Davis (1): > > drivers/char: Add support for USB3 DbC debugger >=20 > I notice this patch was sent twice, about 4 min ahead of the full set. > I take it that the set having come close together is the definitive > one, and that one extra copy is the one to be ignored. Yes, I noticed too late I forgot to drop Connor's broken address, that's the only difference. --=20 Best Regards, Marek Marczykowski-G=C3=B3recki Invisible Things Lab --xK4aUJW9n77/dsBk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhrpukzGPukRmQqkK24/THMrX1ywFAmLfs18ACgkQ24/THMrX 1yxoLwf7BrVKT67S+E+qRnigw+W2MeJsY9GtioTqQtYyuluj7a2wP4tR9DGfIlLd WxbCoGVhWhaz8LZCsZ3GQU8n53mYqTgqajR5MgFtHom2qt3oChJeaUMEqky8snVZ Ze5s2yGVE3dQJKt5j/QXY/MaUbXyBoTySZZDsBvX3uvmlcxyW/JhshtKJwYksG44 S46f3zJuJfkFgVvEUyktPxwJFvyXBqGVGAVORArzQDiV2wgxTr3AxQExec+DgiVO jmWN0PHfoXz80fFJyD+iC50v+KPVZsttLOoCzaXGLvwaeyBCMhPnQJaj5S8xOSrU H3k35ClgP8Wve9OfxkQsJSI4M9BbSQ== =Pwpe -----END PGP SIGNATURE----- --xK4aUJW9n77/dsBk-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 09:35:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 09:35:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375117.607420 (Exim 4.92) (envelope-from ) id 1oGGy2-0005qj-Gn; Tue, 26 Jul 2022 09:35:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375117.607420; Tue, 26 Jul 2022 09:35:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGy2-0005qc-Dr; Tue, 26 Jul 2022 09:35:06 +0000 Received: by outflank-mailman (input) for mailman id 375117; Tue, 26 Jul 2022 09:35:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGy1-0005qS-H5; Tue, 26 Jul 2022 09:35:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGy1-00026C-Dh; Tue, 26 Jul 2022 09:35:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGGy0-0008F2-T8; Tue, 26 Jul 2022 09:35:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGGy0-0001Ul-Sf; Tue, 26 Jul 2022 09:35:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UVxHohT+L+7BDQj8zs+kZMwenSmUCEV5b+TvIp1hrq8=; b=3he9UoSCVgDTM3+Ad+t3kesSrK A73f/qWwHVNKK+FiJtpoCE1wbMFkaYuXr8o2WJxCwV/E3YjmNlAqunumA3cNsm07GF8jrkBjXIUJx i51vGSbhskboFd930kPOBooIETfny5E6cLbAD+eGgS49Q8qtFaMPYHtn7YWKpauWFxAk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171861: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5707470bf3103ebae43697a7ac2faced6cd35f92 X-Osstest-Versions-That: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 From: osstest service owner Date: Tue, 26 Jul 2022 09:35:04 +0000 flight 171861 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171861/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 5707470bf3103ebae43697a7ac2faced6cd35f92 baseline version: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 Last test of basis 171854 2022-07-25 14:03:15 Z 0 days Testing same since 171861 2022-07-26 07:01:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Luca Fancellu jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f1c719d5cd..5707470bf3 5707470bf3103ebae43697a7ac2faced6cd35f92 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 26 10:30:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 10:30:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375127.607431 (Exim 4.92) (envelope-from ) id 1oGHp2-0003Gk-Na; Tue, 26 Jul 2022 10:29:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375127.607431; Tue, 26 Jul 2022 10:29:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGHp2-0003Gd-Ko; Tue, 26 Jul 2022 10:29:52 +0000 Received: by outflank-mailman (input) for mailman id 375127; Tue, 26 Jul 2022 10:29:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGHp0-0003GX-R1 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 10:29:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60074.outbound.protection.outlook.com [40.107.6.74]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dfd39807-0ccd-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 12:29:48 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR04MB3222.eurprd04.prod.outlook.com (2603:10a6:6:6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 10:29:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 10:29:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfd39807-0ccd-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kc6kvMyfxHwEf9wB40gGX+fFzqV2l4FIiMfONskT8uQ/s+V4OGuZYxw40a3itSUMjVcRIFkaIm8a7MWVgSMNIjIbE6AAJ3mG48FX/fKZI4SRW3MZGTy9/ig/7sAuqsqDJ3hhldBKOhUg9+8cMibyPr12TJH9JpGcR38N9B6hSq7KZyNejuwL7N7W+uAqTUzk/Zf2Czmnv3Yg2MSH4aadAtZsc7aoaNZzPBPdbuDvZSLwyZo/pwobEsC8gDelHEvRWA9QYS/4/0r7z8wBGqt37c2EBzuVLhpIzPmFfqe6EnOlsJh20r41I7IzPcO+6ZPy0BkGfMR/gQoHSsluGdZG/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=49ZnBPgO9dXMGmbO6aviSQ5MQWRp+CWRettBFSUT1kY=; b=J4gr54AfkCK0IEvLn+7gyQPjt8+i8vNPMLDOxUqDYCtDGj/P0q3kMuCBbOERnB95H5zL+FAcA51FOexxsGq/VNZeWVrKxjSoNnEKfr0l7DYDfe27TsupZGcg+8HZ6fYN2KgyDT4iVCHHcsPtN+HD06pLk505eHS7t5eSkUicsC839xyJ4fbtPDsa1F19x+Cy3tCMu3c0bREpzLfdB9ZTy3g6Z9VjfAYLJ6Ws/OzmJ4yYMDzb/RJx2JquukmANcxgGlahWGT+gtvkDTfsm84CzGAC4mTSCMhHyTa9ot2yiLVryLvbONJpVH/fLZCEXP+7AK3M0gnbfgR5qpz4AqsQUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=49ZnBPgO9dXMGmbO6aviSQ5MQWRp+CWRettBFSUT1kY=; b=y0Uku5OvRgxpQpzsl+L3EWNgtIzO0xG6n/8xb+xqr/5DezEBXv9EjRd4D3L/6EEpFATYNQeuzEgqPNPKegVlGjA0wnBSSN44P9gCWgi2j+BvIjPk0IgDVaJPByDVQq8hkKMukA/KGhAxtqBhsfBQoI4s4VlVICZ5Pj4ak3D/pgmW2/e+6zLvfV7a5KJ0BJTgiv80Y4/gmD+Blbn7GHSCbRMGHdawETxb4Rl1nxjz9b/P/yGYqnwn1P+uXzuq8hshfHKuqOr8q6hNJNJ4nphn1cQXe+5j+V+ttLaVN7nwU0uifv5qD6znLHUkp7h17DupX96tG0P9Fjbc2BLlBp1qiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <194eaccc-b05f-c1f2-d861-737f3a881966@suse.com> Date: Tue, 26 Jul 2022 12:29:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Random crash during guest start on x86 Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> <880625A9-C3C8-4D45-A4E8-BB443E9D4CEF@arm.com> From: Jan Beulich In-Reply-To: <880625A9-C3C8-4D45-A4E8-BB443E9D4CEF@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0747.eurprd06.prod.outlook.com (2603:10a6:20b:487::27) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d7732877-06ae-438a-f1f3-08da6ef1c215 X-MS-TrafficTypeDiagnostic: DB6PR04MB3222:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jb+O/36WtRqSXiXmam9ci/yZsjXYND/fMXKMhADfuuPSucD4Vgm7PJvpnOxCwuU+FKgUSV6/fgwJBZ3RlGCfSk6QSVJcZQfiRLerAYvEPx5gutZz5jyMoWlX4oebuZ9OigwF0ZxZq5JIEjIyxLSHTtUunplBZ6V+arOAw1bIsVES2/F6Hut+BNUNYY1e0Cjq5TSyQb4zZf3tzFWba1kdZpfC6DE4nx3QElajtp/2cRo57f9W8yg+KkqGmoZUEWMxkbDAWhXplmpmzIFd3x1iMNTT3ZEzyjiJY6iEWxQQhZgsviri1E13P7hepsBNrDHEPUTz3vy3bCSp1soLdF/ynDS+qlbnKQxqCWhXHE4PIkobRIDj8thjyTUfJAp8/cZ858wSbySADHXI6aQqeggpv20ue5XGD8nkoZhqeBHtXMusutBGP47GMB5tN+JgJONoa5xDwmB9e0AtPQVWD0YTycyivctdrHfI3ikshUFYaRz7a6EgY2fOCer2WeDWw9i16mNjAdRPdh+Z/yXycqaZGL2S7NpsmCnRc+eqRJyqDdsguLn2TGzRKCMsTU2tsYyx2Tl0hB5JlZgcez7D30dAfPKvqAKe5hAbQmJi6ia5nng8F4nYF1vMd/pn66ZqZCLrXLK8FtYkQtK5aU3nnNmwLbtTChNXQOAnSuMbsNFhuontJpG82ZTm7tGyHCJ/D3iLTc0cZMrIUY9+hueAhOuZ3HKDL4Lduec3iRcT0P3422hQ0Xi8aRlBFs6c+Z/hB42eGsNAvdupqQdpnqRggKJ3N6A7L0eafAMjUIxL559r02ECHrCAmuUvMYMbrNj8G1Jfqxd0YhZt3iVgT/6cyefRwA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(396003)(346002)(376002)(38100700002)(478600001)(186003)(66946007)(4326008)(8676002)(31686004)(6916009)(316002)(66556008)(36756003)(66476007)(54906003)(6486002)(6506007)(31696002)(2906002)(41300700001)(86362001)(6512007)(26005)(8936002)(2616005)(5660300002)(83380400001)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1E5NEJHR0RoK0VoNkdlQjBVUjJlK2cyVVBObjRyUGFUYWxrVjd1TzJUTXFL?= =?utf-8?B?QXlxVStpQzFjMTlFdmZVc2M1bDQ1MjYycVhpU0NDR3dobXlHN1NJakUzWXRu?= =?utf-8?B?TFVmemsyMjJScUFMYXc3V2hoT0tybzJONXZmZVU2QmgzNnp4blJadjBjUWlL?= =?utf-8?B?T04wVkVpWm1meWtUMXJ3WDRXRCtjbUs0QnZwSmdsZkdia05aaXFUV2VMSnhS?= =?utf-8?B?em53RGQ3d2p3MXZKZzFxN2dqWTN4U0lUTWlCMXFTc09lMzQ3R2doQXpOTW9E?= =?utf-8?B?L2VmUWtRc3Y3NlYvRGlrTEJkbHJzMUhOeHpNaFRoKzRWa0ppUDZiVXZIV3d1?= =?utf-8?B?Qy9HWXFaS2xRL0ZSRlpub0pIQ0I0ODlmUXdvUnFySkJ2UjYyTTNPZUkyZGd5?= =?utf-8?B?eDdqNlZsWW5ITkJ0b0RHaEZ4a0dYZ2o3Tmc1Qi9ETGtJbHBQUUNsOURabkZD?= =?utf-8?B?Ym5DZmVxKzJoWk9LZ2hoUjJNNjhaM3pUaXRxZUNCNmxMSzAvcG1NeFNiVUlM?= =?utf-8?B?N3pvazRhK3hzMzRmYTluazgxMlpPcUVDT1p6WXlhTHZCZWtLUVFjeXcvc2Ja?= =?utf-8?B?bHAvZUI1ckNYTVAwSlk5NVdCQVRWTlZjRVgyc3h5UkdQMmhYNFhKcDNMQXl0?= =?utf-8?B?Yk1pVGcveC8vanpObkVXVWtpNFhJeUQ2clJyMFdDeTRtRDkxeTNqS3FEYi9L?= =?utf-8?B?a0JPK3VMeE9GaWlJbmZKZnFEamh4YWxYeDNmb3JWVnJRQXJjN2RMRU42K1ZT?= =?utf-8?B?UVppSVZsWXZyMXdiMUhGdjRTTWVkTHdMaEJYNlN0MTZLc0gvb0I5SHRPbXVM?= =?utf-8?B?MXByclhpU0JZblk1UU9lenRYeEwwU1VhM1l3OTJMd3BraCtkdWlTR0U1Tnhw?= =?utf-8?B?MVJnOFJYNjkwWEtObTc4WVRzK2lCczZiU0dEZ2dQTFlUdDVLL3d5bTBSVFNS?= =?utf-8?B?TXhJRHhReUl1ZTBoTHFaRHlKb2Z0QjVTMkpRUjRkcUtScTdQWUN6eVdDVDI4?= =?utf-8?B?cjYzK2R6R2xGTkErWG16VVBwemczUEtURUhMVndkS0MzZHk4Wjh6OUw1S20x?= =?utf-8?B?ZUgveU9EeEh4SWc0S09oVlM1UGVuVEZHQ0NhVlFYbTBPeVFXRDFZQVpmaEsr?= =?utf-8?B?SGZ0aEM5Y0FDWVVnMm1YVWRuK053cEJVTTdNeXY2QVBEMjhyRy9xeEJOTDh3?= =?utf-8?B?YTk4c1ppQ3VKaDdvM0VFT2FPTkJkNXRYc092ZmdUd3c0YU9DdEpQSUxsYmhn?= =?utf-8?B?T0FGamlMMFFCSlRINFZhS04ybmdseGdwWW5vWUNCUWtsbXhFYzlaK2kvVy96?= =?utf-8?B?amRqelRmQW5NTXhtcUd5ZDRvUXk2MzlLYlBhTWZHL1hRNllvUlFkVFJlNGNK?= =?utf-8?B?cGlzQTVuQUExYWF2bVBEL2plcEdMQ1phRVBYc1V6QWJSbGVrbnRnTEtON3ZJ?= =?utf-8?B?Uy84UjBqRHJRWnZmelhpVG9BbVliM1Q1dVNNVloxbWFlQlNlNzdmNVlIbE8x?= =?utf-8?B?Z2ZZVlV6OTlaY1VCQ0k1SVNlUWNWbjFtQ2xrYlFPSlZlSFhOOHE5Nkt6UmV5?= =?utf-8?B?ZERWV0JMMTJTOTdDdWFyTTN1N1Z2QWxKYlJmQUprMDlHVkM2Q0xsOTYrTEdJ?= =?utf-8?B?S1pmOG1pV2EyYUI5dDhUTWlBZFpvbTdFbjZGSk9HOXlxemdZaG5GRFYwUys1?= =?utf-8?B?c29FZ2VDMlZoR3ZzckNiS0NkRlBBMkdrdXV6bkpXT05IK3hMcmhrTnRYNm92?= =?utf-8?B?RW1NVjhjRlpKakpSZHMzcVQ4bDBuSEMrVzQvZkc3RDNvL0FlbG0yOEg0QmVz?= =?utf-8?B?Q2ltUzFrZGIrZ0dHd2E0VWc2YmZUbGVWWGx1bEFqdzhvVG42UzlidEtzeFVN?= =?utf-8?B?Tjd3NEU1OHFaOGZ0K251eHNlL0Fad083SkVtK20vTTlDbVVkR2FXd2V1V3d2?= =?utf-8?B?T3E2cElkb2xvb251NlJaZjk5V3BkWFBDZGVtRi9mWUlYSm9ERVFHQ1RpTkxX?= =?utf-8?B?V3R4RUFzTmF0eXpTMnEyangxYUUxWmFSWmJXTmRnYW9zV2xEOC9JZU1BNEc3?= =?utf-8?B?dHltQ2k5NmRrZzcrU0U4aGRnZmc0TWtEN2Y3NllWZmE4U2lpTVU5Z2tMV0VP?= =?utf-8?Q?B6gKRgxDpp8MKPWqTcB/98oeD?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d7732877-06ae-438a-f1f3-08da6ef1c215 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 10:29:45.0456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fQzqwIK+9dciBfLkkCF7F98Q6ImejRcxgof8kEazQYxBvFFDdtg/DipmDtI2+NLmysEp2KtoVxBWJ+srC+Irbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3222 On 26.07.2022 09:51, Bertrand Marquis wrote: > > >> On 25 Jul 2022, at 17:16, Jan Beulich wrote: >> >> On 25.07.2022 17:51, Bertrand Marquis wrote: >>> On our CI we have randomly a crash during guest boot on x86. >> >> Afaict of a PV guest. >> >>> We are running on qemu x86_64 using Xen staging. >> >> Which may introduce unusual timing. An issue never hit on actual hardware >> _may_ (but doesn't have to be) one in qemu itself. >> >>> The crash is happening randomly (something like 1 out of 20 times). >>> >>> This is always happening on the first guest we start, we never got it after first guest was successfully started. >>> >>> Please tell me if you need any other info. >>> >>> Here is the guest kernel log: >>> [...] >>> [ 6.679020] general protection fault, maybe for address 0x8800: 0000 [#1] PREEMPT SMP NOPTI >>> [ 6.679020] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.6 #1 >>> [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 >>> [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 88 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <0f> 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff >> >> This is SWAPGS, which supposedly a PV guest should never hit. Data further >> down suggests the kernel is still in the process of patching alternatives, >> which may be the reason for the insn to still be there (being at a point >> where exceptions are still unexpected). > > So the exception path is using alternative code ? Sounds logic with the error output. > But does explain the original error. SWAPGS sits pretty early on all kernel entry paths. If any instance of it is subject to alternatives patching, then prior to patching such paths may not be taken when running as PV guest under Xen. >>> [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 >>> [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff81e00fa7 >>> [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 00000000000000eb >>> [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000 >>> [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000 >>> [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 >>> [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS:0000000000000000 >>> [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 >>> [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 0000000000050660 >>> [ 6.679020] Call Trace: >>> [ 6.679020] >>> [ 6.679020] RIP: e030:native_irq_return_iret+0x0/0x2 >>> [ 6.679020] Code: 41 5d 41 5c 5d 5b 41 5b 41 5a 41 59 41 58 58 59 5a 5e 5f 48 83 c4 08 eb 0a 0f 1f 00 90 66 0f 1f 44 00 00 f6 44 24 20 04 75 02 <48> cf 57 0f 01 f8 eb 12 0f 20 df 90 90 90 90 90 48 81 e7 ff e7 ff >>> [ 6.679020] RSP: e02b:ffffffff82803b48 EFLAGS: 00000046 ORIG_RAX: 000000000000e030 >>> [ 6.679020] RAX: 0000000000008800 RBX: ffffffff82803be0 RCX: ffffffff81e00f95 >>> [ 6.679020] RDX: ffffffff81e00f94 RSI: ffffffff81e00f95 RDI: 00000000000000eb >>> [ 6.679020] RBP: 00000000000000eb R08: 0000000090001f0f R09: 0000000000000007 >>> [ 6.679020] R10: ffffffff81e00f94 R11: ffffffff8285a6c0 R12: 0000000000000000 >>> [ 6.679020] R13: ffffffff81e00f94 R14: 0000000000000006 R15: 0000000000000006 >>> [ 6.679020] ? asm_exc_general_protection+0x8/0x30 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>> [ 6.679020] RIP: e030:insn_get_opcode.part.0+0xab/0x180 >>> [ 6.679020] Code: 00 00 8b 43 4c a9 c0 07 08 00 0f 84 bf 00 00 00 c6 43 1c 01 31 c0 5b 5d c3 83 e2 03 be 01 00 00 00 eb b7 89 ef e8 65 e4 ff ff <89> 43 4c a8 30 75 21 e9 8e 00 00 00 0f b6 7b 03 40 84 ff 75 73 8b >>> [ 6.679020] RSP: e02b:ffffffff82803b70 EFLAGS: 00000246 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] insn_get_modrm+0x6c/0x120 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] insn_get_sib+0x40/0x80 >>> [ 6.679020] insn_get_displacement+0x82/0x100 >>> [ 6.679020] insn_decode+0xf8/0x100 >>> [ 6.679020] optimize_nops+0x60/0x1e0 >>> [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] ? native_iret+0x3/0x7 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>> [ 6.679020] apply_alternatives+0x165/0x2e0 >> >> I have to admit that I'm a little lost with these "modern" stack traces, >> where contexts apparently switch without being clearly annotated. It is >> looking a little as if a #GP fault was happening somewhere here (hence >> the asm_exc_general_protection further up), but I cannot work out where >> (what insn) that would have come from. >> >> You may want to add some debugging code to the hypervisor to tell you >> where exactly that #GP (if there is one in the first place) originates >> from. With that it may then become a little more clear what's actually >> going on (and why the behavior is random). > > I will check what I can do there but as the crash is very random and only > happening during our CI tests, this is not really easy to reproduce. > If you have any example of code to do the debugging, I could run some > tests with it. Well, you want to show_execution_state() on the guest registers in do_general_protection() or perhaps pv_emulate_privileged_op(), but only for the first (or first few) #GP for every guest (or else things likely get too noisy), and presumably also only when the guest is in kernel mode. The resulting (guest) stack trace then would need taking apart, with the guest kernel binary on the side. >> As a final remark - you've Cc-ed the x86 hypervisor maintainers, but at >> least from the data which is available so far this is more likely a >> kernel issue. So kernel folks might be of more help ... > > I wanted to check if this could be a know issue first. The problem is > happening in the kernel, I agree, but only when it started as a Xen guest > so I assumed it could be related to Xen. It is quite likely related to Xen, yes, but then still quite likely to the Xen-specific parts in the kernel. In the end it all boils down to where the first (suspected) #GP is coming from. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 10:36:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 10:36:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375133.607441 (Exim 4.92) (envelope-from ) id 1oGHvP-0004iU-Cd; Tue, 26 Jul 2022 10:36:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375133.607441; Tue, 26 Jul 2022 10:36:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGHvP-0004iN-9t; Tue, 26 Jul 2022 10:36:27 +0000 Received: by outflank-mailman (input) for mailman id 375133; Tue, 26 Jul 2022 10:36:26 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGHvO-0004iH-0C for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 10:36:26 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70081.outbound.protection.outlook.com [40.107.7.81]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cbd47056-0cce-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 12:36:24 +0200 (CEST) Received: from FR3P281CA0055.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::18) by VI1PR08MB5424.eurprd08.prod.outlook.com (2603:10a6:803:136::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 10:36:21 +0000 Received: from VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:4b:cafe::32) by FR3P281CA0055.outlook.office365.com (2603:10a6:d10:4b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.13 via Frontend Transport; Tue, 26 Jul 2022 10:36:21 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT016.mail.protection.outlook.com (10.152.18.115) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 10:36:20 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Tue, 26 Jul 2022 10:36:20 +0000 Received: from bc0d96d79358.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0EE2A436-CE20-4AF1-BF3E-91C05A86B91E.1; Tue, 26 Jul 2022 10:36:14 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bc0d96d79358.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 10:36:14 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB4316.eurprd08.prod.outlook.com (2603:10a6:10:c6::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Tue, 26 Jul 2022 10:36:11 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 10:36:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cbd47056-0cce-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=RqzklDDOYzlaG1jRPOSbbbNUpRP+vtW7yeAattqnhoaCwP6dGPU4EqhWQlJyRies8K038LP4DR2pLbC4s1MpgP3kWQoRvbJTQnJhqr2FKelFViwKT/CMkzzoOh5/TqwHsGbCrXzp0h/jwoes3QxEFmYDUG92/tmTYjmUOwxx0FP/kVzOjdJY0yzoISVngl/2z2DfdgUDppVBpcnZBdDoarKH9D1rJlA24u98xzYOY++OhYyF4ocv4vCMijVQlC/cTj5yBG8eXV4ex99QSfmnngTW+5JHiJXeAZ8eCydec9V2fkNmByjrn1LF0cB0zg/SqVckyUbP/6x7DJzQGW9OMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LlxzfnK1CLj6Rmh5eUlspXLw61vZ68+AkKn0xuF1YZE=; b=WMOAK4TEiVIrcw07spRG1G0biDxCbmZl0A/itDIQeFJrzgDqzJqugqQiMLI6HaiV4KFxSXwIXSC8vxXv0zS/X4KCsWDu8hGpyuw47ASaS8U4hdFIU2ngJCw+83KHQc3asiQLMU7pOTOkRSi7GVvAN3ccZyhwbt7NS61mucKYKpLHJt49hNjxR2NIh7QyBEbNdei5MpwjkQ2iu12ZKLcvGHwjgelxLeUZibz6WLqUGZDJKiRrguW7cjN7Qr0H1VAyM1Plp7Chff1pkI9DIBQ/k/Bz9iUjb93kd2vza0v6vwOKO49nrE7ig8Fg1hQuLbI2m607zMZe1uRqTo2eF3eVzQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LlxzfnK1CLj6Rmh5eUlspXLw61vZ68+AkKn0xuF1YZE=; b=C+7bqCObP0Mvg86kS5d8NZ3J1brHNS8hgJ+z1YZ8Rp7j2Ek3sGxjiLN/Up6LO+5g27N/9T/QBfuv919cj3N392s1gfj6yXUfWu0cMzMR9E5EyE9+7e29JvSp/SD+r6ZoOV3hL1yOEQA4nZnYi/Mx+3jAOAAKy4mvxjviueSrsoY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3f222279b76957e2 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Nc5Kew39h4bcMrINiXsDmYb3cyw62pB82Vf1x46H94gGish7fZWlLFWP7bZFl2UW9KlNIT7NkAZkBnxiSUwU3QUngR3H6lnkOpLqMr5/U+Q9/hnUASq+DFG0HKxJmQYPXkfiwh4j8r6YduQe1VJ6WJYlpWJFQBfbOuu1UH3LKPk/aSBPO/Dg+DB6a6Qc6hkcgHZ7BBUFSzHsCpCbKiYRQhJqgV76aM9BWGa0mGZNqdolZvdEhby58EVTmItpAo8LAM1C+x/a9xr2j7Gbeka3hkep21CbpwgzC1ED//bJVuScYm62H5ZvRRPRQHwefgyPc2LBZHwLD/Ge+Ebyoo+KgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LlxzfnK1CLj6Rmh5eUlspXLw61vZ68+AkKn0xuF1YZE=; b=i95OB/g3O4vKLUlM7WXzd9EwT73+L2HwsSK68rkrEnt7w57rykiPXJ0XNm6dAgBR8ESNnvpOZrf7hG/sTuhQXh8wYFLkImbiYZmJ6psHzNDDprWg1/jKWp5q6fNPk5ei85r8eciBUP8Ewd93d10gg6R0mrq9m18wAYNMBnI38gdYlAZxFF0kSR4PEsE1TWP5i2enRxbQ/hazl6R6kgE0vEb0kE6e8PchQWZoJ6U8uFv9SBGLiHVNChLhIJH4nD/H15t5Escf/Fri4vxlaeMLzdqAARm7QbIk5+KRW9IScWDJJKeb+v1MJkctfGU6tVxNgInVI6jpUFYZHW+axhTSnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LlxzfnK1CLj6Rmh5eUlspXLw61vZ68+AkKn0xuF1YZE=; b=C+7bqCObP0Mvg86kS5d8NZ3J1brHNS8hgJ+z1YZ8Rp7j2Ek3sGxjiLN/Up6LO+5g27N/9T/QBfuv919cj3N392s1gfj6yXUfWu0cMzMR9E5EyE9+7e29JvSp/SD+r6ZoOV3hL1yOEQA4nZnYi/Mx+3jAOAAKy4mvxjviueSrsoY= From: Bertrand Marquis To: Jan Beulich CC: Andrew Cooper , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , xen-devel Subject: Re: Random crash during guest start on x86 Thread-Topic: Random crash during guest start on x86 Thread-Index: AQHYoD5xXkzOB8H120+6SchUWgFyYK2PQysAgAEFgQCAACwUgIAAAc6A Date: Tue, 26 Jul 2022 10:36:11 +0000 Message-ID: <03648C7A-D7E8-4348-B2CA-43CBAA7FC51A@arm.com> References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> <880625A9-C3C8-4D45-A4E8-BB443E9D4CEF@arm.com> <194eaccc-b05f-c1f2-d861-737f3a881966@suse.com> In-Reply-To: <194eaccc-b05f-c1f2-d861-737f3a881966@suse.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 83d2e774-21d2-4720-90f5-08da6ef2ae37 x-ms-traffictypediagnostic: DBBPR08MB4316:EE_|VE1EUR03FT016:EE_|VI1PR08MB5424:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: MR6pQBB4flzgFGZFRhQMhzE1KO8mqv5pyFHaKYhcKZapyrsE9Shz6TLQ7JxtsxZU6uqssT8hwwEw+3nkaFVgAJCZq0DGq/wMqbayZ3aso28fLop0iOLzComZYnzl07Kf5v1SgOviwbMFSDX2NvGzc6OrdhmxnouUwIgdhLmStl0uQKf/owdZZLhfySmpGaYkCgqwD2J8kHGnhpU08cF9Q9zu0WcHPHbGP3QuBJWCip6SKIBv0OdbLx96SbjvmA0dnst933NaOkXnsS8W/bvIXWNnD/qyOUe+f44opmtEP1aUrIX/VK4CYa+XH7ElQ54FSg6CmQ/hTBcXf4B52rKllMwFxHYhTgJK1pmB4yenYTmIHBSXRrCxqf2r3+DNrWsDN6eS7o73X3MDmnQNhTOOVYjqEUXOFBuNIBNbs+rRTMPgbFB5BhFtXe2kzAy+xxfQpvq5V0gsJ+QexGBGKMsir0N2VonDIaZZU/wHkuAnDF3+mvO1gZtxXK+0QgfLt9UlD3V03u6GR26BhjChu/ZsiYwbpMiNhu8vbndnvGJ/5wgsF+PrQNL2t1XXOjf7wlgQ9FJbzlvgFtB+P/R/pNSeH+hvCOYLH4Dx8adwsijuWj4TXFlbQ6hVlbFPB/449Fuoo88DVF37j7F1EurWmAIOGQzr8b74ARJbRclrQMGHh4i6y25WJla0bdbZdX6izZVSo817q3CFu1uyao5TAt05bS9sKAQN6KoB55MdKFAEHr0El0u2IZmYvuZ3wcJO9rdkagHNalCcDszb3psG8Hhef6oKW2VLfjp9w3eYF2qjapfhZbhhf92/JXH/9TIEA/w8x3RMCWep4GH9qiAA26add7UKee5Mi43gXh3hp4PeSmux5wNVqYg5jfA3WH5CxFRj X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(346002)(39860400002)(136003)(366004)(91956017)(36756003)(76116006)(6512007)(26005)(53546011)(71200400001)(6506007)(64756008)(66946007)(86362001)(66556008)(66446008)(2906002)(66476007)(41300700001)(38070700005)(4326008)(8676002)(6486002)(8936002)(316002)(478600001)(33656002)(186003)(38100700002)(6916009)(2616005)(5660300002)(122000001)(83380400001)(54906003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: <141B28013CFB5A44914DB519C9952C20@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4316 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 81484fd0-d753-4c74-577f-08da6ef2a8b7 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4YxEmheMOr5Iw73Re4jhB+bwD9C2CHSDcOplILFKtHXzekrHsPc5CLDhvJH4DglhuHhEpIiQkiHnByPK6oMUlBN8UNtmpAl/HH1kP2vVOgt8el+BXxha2oDKL188f/tetPYAObCveMxjzCdkw/FxekdFhzysy4bs3+MHC4Nmjtm4l19p+m4VXoao5AXaOp0gBQJEqgffAZM/cyaf0IsYqNVllQgrtY1tAclDb4Dci5EgXnKG94c+yG9zAtzOaStjj5djD1f5v18a2zSpYNfhHlrVU/Zex6wUlEHO3BicOjVYgFqgsn3lQD2ESvSzodOPJa2XTKacb0MAIR+6tA5cN9LHPeUwdqWTs/W+LCeFYh1WnXib2AXGC03MnS734/VBcqBgs/ZAnOlyFlilbiva/hbsXaKFm84f9vJ0mgDY/kqM+DW1EsYHVf+oFxak0uWG1L51wawH92ZJhlF1CLq2Hf+19ydvYc6CRZ6gZqSrhxmLNFBgLkmq3tGWGbpj/tslQ8zYAJoQsSDVJKns3hL8qFfzZBbypXm8BjLmyDCJCElumFrqOQ/CoVa6GgLAWROrenTkC98GEyBcFoNaIFTX+FnAkwTkLGxWlvjNzz0L9VHJl2TIShgt2MnWqSG8oPkrgYON8CkQzFgtNYIuzvyV46Jt2WJbxbAFD0tNriHqOwT2t7Kq4BS9JRSBNH25n2vTIeCZryuonLwFQqjy4fD7//F13ZMzH/M3mCvyLAcX6iClUiXoD/0XpPzQnVAgEEj1tO9tHzJXVXexlhKGcVj1AIiUEYFnQQgsfCLR7GEFPdErltPQoCF1Z6hoBEu8vDG4 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(376002)(39860400002)(396003)(40470700004)(36840700001)(46966006)(41300700001)(186003)(316002)(54906003)(36756003)(2616005)(40480700001)(356005)(83380400001)(86362001)(81166007)(2906002)(6506007)(36860700001)(82310400005)(82740400003)(8676002)(6486002)(53546011)(70586007)(70206006)(4326008)(478600001)(26005)(40460700003)(5660300002)(47076005)(6862004)(8936002)(336012)(33656002)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 10:36:20.8802 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83d2e774-21d2-4720-90f5-08da6ef2ae37 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5424 Hi Jan, > On 26 Jul 2022, at 11:29, Jan Beulich wrote: >=20 > On 26.07.2022 09:51, Bertrand Marquis wrote: >>=20 >>=20 >>> On 25 Jul 2022, at 17:16, Jan Beulich wrote: >>>=20 >>> On 25.07.2022 17:51, Bertrand Marquis wrote: >>>> On our CI we have randomly a crash during guest boot on x86. >>>=20 >>> Afaict of a PV guest. >>>=20 >>>> We are running on qemu x86_64 using Xen staging. >>>=20 >>> Which may introduce unusual timing. An issue never hit on actual hardwa= re >>> _may_ (but doesn't have to be) one in qemu itself. >>>=20 >>>> The crash is happening randomly (something like 1 out of 20 times). >>>>=20 >>>> This is always happening on the first guest we start, we never got it = after first guest was successfully started. >>>>=20 >>>> Please tell me if you need any other info. >>>>=20 >>>> Here is the guest kernel log: >>>> [...] >>>> [ 6.679020] general protection fault, maybe for address 0x8800: 0000 [= #1] PREEMPT SMP NOPTI >>>> [ 6.679020] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.17.6 #1 >>>> [ 6.679020] RIP: e030:error_entry+0xaf/0xe0 >>>> [ 6.679020] Code: 29 89 c8 48 39 84 24 88 00 00 00 74 15 48 81 bc 24 8= 8 00 00 00 63 10 e0 81 75 03 0f 01 f8 90 90 90 c3 48 89 8c 24 88 00 00 00 <= 0f> 01 f8 90 90 90 eb 11 0f 20 d8 90 90 90 90 90 48 25 ff e7 ff ff >>>=20 >>> This is SWAPGS, which supposedly a PV guest should never hit. Data furt= her >>> down suggests the kernel is still in the process of patching alternativ= es, >>> which may be the reason for the insn to still be there (being at a poin= t >>> where exceptions are still unexpected). >>=20 >> So the exception path is using alternative code ? Sounds logic with the = error output. >> But does explain the original error. >=20 > SWAPGS sits pretty early on all kernel entry paths. If any instance of it > is subject to alternatives patching, then prior to patching such paths > may not be taken when running as PV guest under Xen. >=20 >>>> [ 6.679020] RSP: e02b:ffffffff82803a90 EFLAGS: 00000046 >>>> [ 6.679020] RAX: 0000000000008800 RBX: 0000000000000000 RCX: ffffffff8= 1e00fa7 >>>> [ 6.679020] RDX: 0000000000000000 RSI: ffffffff81e009f8 RDI: 000000000= 00000eb >>>> [ 6.679020] RBP: 0000000000000000 R08: 0000000000000000 R09: 000000000= 0000000 >>>> [ 6.679020] R10: 0000000000000000 R11: 0000000000000000 R12: 000000000= 0000000 >>>> [ 6.679020] R13: 0000000000000000 R14: 0000000000000000 R15: 000000000= 0000000 >>>> [ 6.679020] FS: 0000000000000000(0000) GS:ffff88801f200000(0000) knlGS= :0000000000000000 >>>> [ 6.679020] CS: 10000e030 DS: 0000 ES: 0000 CR0: 0000000080050033 >>>> [ 6.679020] CR2: 0000000000000000 CR3: 000000000280c000 CR4: 000000000= 0050660 >>>> [ 6.679020] Call Trace: >>>> [ 6.679020] >>>> [ 6.679020] RIP: e030:native_irq_return_iret+0x0/0x2 >>>> [ 6.679020] Code: 41 5d 41 5c 5d 5b 41 5b 41 5a 41 59 41 58 58 59 5a 5= e 5f 48 83 c4 08 eb 0a 0f 1f 00 90 66 0f 1f 44 00 00 f6 44 24 20 04 75 02 <= 48> cf 57 0f 01 f8 eb 12 0f 20 df 90 90 90 90 90 48 81 e7 ff e7 ff >>>> [ 6.679020] RSP: e02b:ffffffff82803b48 EFLAGS: 00000046 ORIG_RAX: 0000= 00000000e030 >>>> [ 6.679020] RAX: 0000000000008800 RBX: ffffffff82803be0 RCX: ffffffff8= 1e00f95 >>>> [ 6.679020] RDX: ffffffff81e00f94 RSI: ffffffff81e00f95 RDI: 000000000= 00000eb >>>> [ 6.679020] RBP: 00000000000000eb R08: 0000000090001f0f R09: 000000000= 0000007 >>>> [ 6.679020] R10: ffffffff81e00f94 R11: ffffffff8285a6c0 R12: 000000000= 0000000 >>>> [ 6.679020] R13: ffffffff81e00f94 R14: 0000000000000006 R15: 000000000= 0000006 >>>> [ 6.679020] ? asm_exc_general_protection+0x8/0x30 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>>> [ 6.679020] RIP: e030:insn_get_opcode.part.0+0xab/0x180 >>>> [ 6.679020] Code: 00 00 8b 43 4c a9 c0 07 08 00 0f 84 bf 00 00 00 c6 4= 3 1c 01 31 c0 5b 5d c3 83 e2 03 be 01 00 00 00 eb b7 89 ef e8 65 e4 ff ff <= 89> 43 4c a8 30 75 21 e9 8e 00 00 00 0f b6 7b 03 40 84 ff 75 73 8b >>>> [ 6.679020] RSP: e02b:ffffffff82803b70 EFLAGS: 00000246 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] insn_get_modrm+0x6c/0x120 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] insn_get_sib+0x40/0x80 >>>> [ 6.679020] insn_get_displacement+0x82/0x100 >>>> [ 6.679020] insn_decode+0xf8/0x100 >>>> [ 6.679020] optimize_nops+0x60/0x1e0 >>>> [ 6.679020] ? rcu_nmi_exit+0x2b/0x140 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] ? native_iret+0x3/0x7 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1c/0x27 >>>> [ 6.679020] ? restore_regs_and_return_to_kernel+0x1b/0x27 >>>> [ 6.679020] apply_alternatives+0x165/0x2e0 >>>=20 >>> I have to admit that I'm a little lost with these "modern" stack traces= , >>> where contexts apparently switch without being clearly annotated. It is >>> looking a little as if a #GP fault was happening somewhere here (hence >>> the asm_exc_general_protection further up), but I cannot work out where >>> (what insn) that would have come from. >>>=20 >>> You may want to add some debugging code to the hypervisor to tell you >>> where exactly that #GP (if there is one in the first place) originates >>> from. With that it may then become a little more clear what's actually >>> going on (and why the behavior is random). >>=20 >> I will check what I can do there but as the crash is very random and onl= y >> happening during our CI tests, this is not really easy to reproduce. >> If you have any example of code to do the debugging, I could run some >> tests with it. >=20 > Well, you want to show_execution_state() on the guest registers in > do_general_protection() or perhaps pv_emulate_privileged_op(), but > only for the first (or first few) #GP for every guest (or else things > likely get too noisy), and presumably also only when the guest is in > kernel mode. >=20 > The resulting (guest) stack trace then would need taking apart, with > the guest kernel binary on the side. >=20 >>> As a final remark - you've Cc-ed the x86 hypervisor maintainers, but at >>> least from the data which is available so far this is more likely a >>> kernel issue. So kernel folks might be of more help ... >>=20 >> I wanted to check if this could be a know issue first. The problem is >> happening in the kernel, I agree, but only when it started as a Xen gues= t >> so I assumed it could be related to Xen. >=20 > It is quite likely related to Xen, yes, but then still quite likely > to the Xen-specific parts in the kernel. In the end it all boils > down to where the first (suspected) #GP is coming from. Would it make sense then for me to try a newer linux kernel first ? Cheers Bertrand >=20 > Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 10:57:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 10:57:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375142.607453 (Exim 4.92) (envelope-from ) id 1oGIFf-0007UC-5F; Tue, 26 Jul 2022 10:57:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375142.607453; Tue, 26 Jul 2022 10:57:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGIFf-0007U5-1V; Tue, 26 Jul 2022 10:57:23 +0000 Received: by outflank-mailman (input) for mailman id 375142; Tue, 26 Jul 2022 10:57:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGIFe-0007Te-3Z for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 10:57:22 +0000 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2067.outbound.protection.outlook.com [40.107.223.67]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6f56b5d-0cd1-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 12:57:18 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by MN0PR12MB6269.namprd12.prod.outlook.com (2603:10b6:208:3c3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 10:57:15 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814%8]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 10:57:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6f56b5d-0cd1-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oT1NsWB3tqlwMr9lvsMyOJygA+3WJh1PrwBQCGNxDPLGazJqSdNw+zH21udTwTOyFKSnuvXqSJimEX0+rj33XKwHDC/xNDtHd4ZysxOdiRK5hGLoCk6A5BNScvgu90+dgxTIdwJyWNKGgkFibAU7TdkXXYzWneYkoGZ/1p0DHoP8jOlSGXWazI4wgcNXYjAk4XAMyhR5597rqApERu/6dTvIg6bWF3ZvSjhYCbLNAifZB1d5YSfaP4nWw7GZ1TpC9nJ2BwUnlWpnqY/BwpNzENd/4Ne0PF/+Z0ymfnSJFXy0h0WbUAqYJ2qRW1QSgDZAn/Y9RLRMfyerPzeBpkrOXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=R7Gy3XqzN4zXHWjHLnQ448VIUa32XBboXl5wXO0XRRY=; b=SINtqbTwv1OlSmboSIabwDXzpx2tsY/tJ2Vsy8lCvQazrcyMeAlGk1/ozWf6NCWALFrOJj8ezzgokxUnG0LDjUR71bCqOjaj034Xu7iCtkViwbZfrsWF9BkNstdijKqJU0F3K0CuPzsabGrYSsMxFbXUNebF+Os7WWQWOJBf7Qc8ihMGeivb191QnujNZlTm4NdPFffVk8Vm5ZeIiHFig4LTtQvpJE0RWobOz70TT0HWgaHIT1+nzzPeylQi3fvCcGpDfrtOQAI0HDfiDvpRAzxc5+Z2bVToD4EPn/0aJnddRM5P+cTC5Yg8Eah7VT+oGJJwwrH30z/1pvwyM/X1Eg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=R7Gy3XqzN4zXHWjHLnQ448VIUa32XBboXl5wXO0XRRY=; b=ijZxn7rTZXKCv+FXJjQcFCXxAqB/gR/gyhGciAS4gwiWtE+lx4LzyeNNlc5HzQM1z8EFjji4zs1xLQt8ngMR8gLjdxr7s0SndoNsKSY2y0OOql0FHUZeurw+iYJ46c+czg/IIDF/mROOA2MBxtnWNQTkBYpWqn+KUG7xL8zaGGg= From: "SHARMA, JYOTIRMOY" To: Christopher Clark CC: "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: RE: Enable audio virtualization in Xen Thread-Topic: Enable audio virtualization in Xen Thread-Index: AdigFizJpGeQu9pXSearK44pKRlEjgAVU4KAABr1NcA= Date: Tue, 26 Jul 2022 10:57:15 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-26T10:57:11Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe043d7f-7e6e-4995-a203-34e5b5362b6a; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2289fb87-0d68-4b8a-ee2d-08da6ef599be x-ms-traffictypediagnostic: MN0PR12MB6269:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6gBrV3qKDvg3SpCnR1CuAWgocKTQk7h9P2Cidf5G9svYyS1E4+FXcaGj2TdvzAQpqMw03dRrbtjnKIy5hNXaUfznsx+5gPP6UZwy51/jUDiUqHGqb+pHNp3k5kEMoSyiyC0NHV8UtOHPGReutN/DO47u9odytZzY3g682fsWxisXWjjnzoFK0aAUuDI51XlLYNWKPACUvUBkEpRyKrJNV0ZzHj3Rc3EJbIzqYFcNZUTW7DaSbPgghKWg1Dr3Ph3TT5bkdijcTh32P7ZVmUOJqwXSrRf74nVSWxbw2MoO8kAZ9+q/eHt5GDaDWADLIk2eeww7qE1L95VsvdKWVH1NFbLb9TkJ5wn/x+EjPzuTKudaRrSj9B+kX15T2vkkA4RLGbso0xnvRmfEN+EBPkoCH27T/8aatdIlnWOPn33zPtQxT4vaKrLDTRv9OwU18iGUBfRfd/LLZkTynYrRiBU1pzoMe4f79MVy0gZsz/zK469j9ZtEIPHX15BzvX2RamUhrpzrPwbTW8ZDgUCW+qHrPlIvfdJVUDktridcs7cbacZ9rKhc9bq2nvwFqJXzjxah1rAj1Bd8Bl41dem/L6SH++47hrM+rw0NdpHpGde89SFtAk/+yNFwnbrHLSjUxXnLmQ/bg7Vqmlc9VaxUb6h16YzadTeF1m/ITw0RlpQ0xdXO1O2nJlma97iHaZFydbkL8afjHeyIP7AfPgWusNxf5vvCNMieXqfQDmE48Psq/dMpYzatMiCVM/1fQApsaccaI9xBs3w3OoSfS+mVwq6xW3RSXihtKhJITn4OupUbBny/t4+m4GvRmdtmLsBpZ/ZgLgFZTPlBxBgY2bmOlQeteg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(396003)(39860400002)(376002)(346002)(38070700005)(122000001)(8936002)(9686003)(83380400001)(186003)(33656002)(52536014)(2906002)(55016003)(5660300002)(71200400001)(76116006)(66476007)(64756008)(66446008)(8676002)(966005)(53546011)(4326008)(478600001)(6506007)(41300700001)(7696005)(66556008)(6916009)(38100700002)(66946007)(54906003)(86362001)(26005)(316002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WUVRZ3dtVDhqbWhJcVl0SVpPUVRNQmdyMWpEaTllWVpuRnZlSmp2NEFCK1pS?= =?utf-8?B?ak1FZzJEcFduRHdnQ3BsQkZUTGd2WHdkckN4UjhTRzdEcGdFakxEbWFQdlkx?= =?utf-8?B?VlRqU045Z2czU0xwdmV4ODUyZURSQ1phc3ROT3oza0ZBK1puSUVuN25QZ3JF?= =?utf-8?B?Q1VxdXcvRGJVWXE0VFBpNjZ6SU9rVy9vNWxNUnJtd2pSdGMvRmxoTThsVjN4?= =?utf-8?B?NGtnMitEK2hSenlsaWZPUC8zdVBOMVpaOEdicUllRFFtaGoyTStUSDFCajVT?= =?utf-8?B?SGttais4TUlpTVN6K3ZXamFCZzN0Q1VmUzRwTTlKL3VUcHVVejBaSElzRmlr?= =?utf-8?B?dWwxRGRMUHRIZzZlU2dQNExpTDBPQlRqajVLZEsrY2RUOG1qeW1XMmNVQWll?= =?utf-8?B?Q0VNUlNJMWVvbTVvd3pXdlkyOWpPaldzdStFUWdFYkpoRkd6Zk43K0tzTWI1?= =?utf-8?B?bWJFS1lGY0tiYmY4dHNLcW4ybG9RMm9IVVV5bTJDTVNHQWhlSG1hc21pZHdP?= =?utf-8?B?d1VaYU0yRGIvK3RiVm92WG5pdmU5RW9ReXZVT2hoZFlCbjEvVlZEWEhpb1Z6?= =?utf-8?B?aGhDZVZ2aEZiY1N5elFvVUZJOFB2WCtyZGh3VlZjR3luc3o0SnlpaHpqSU1y?= =?utf-8?B?K2RRaUl2enBtMDFEYWluOWFoUjNWVGM1eUpKeDRtSkpkSzhKVkpQeFNIMHFW?= =?utf-8?B?dk9heUlITG04akkxWFgwMjZUYkNZTk9WWGRjY3I3U2kvV2hvRFAwdW1zSjdK?= =?utf-8?B?WElhVGNGL0JQU0x0Y1RoYTNPT21hV2tQazl2dmtsSUZ3TDh3VXorWG12UU82?= =?utf-8?B?anJjWGRUU3NaT0I5Rmxlem03MzE5UGQ3WFNEYWhuVUFyK0dIMzY4dkJFNVhx?= =?utf-8?B?bUVORXRHcFhqSkZSV0pRRzhTcUFDZnNzNXViSGxLOFUzQmh5bFNHblp1YjZV?= =?utf-8?B?OFd3MzN4Tm0vQjBlYmMrTWNEazdpeVUrbWYxR2pqQitCS3daRlBxK0NtQ1hq?= =?utf-8?B?Nk9GQktla1dlcXY2U0MrZXBQMGkxYkJKVmEwN0lPVnBjOVlwZVZlVmd4eWc1?= =?utf-8?B?WERscWFpeVlqTHJESldYR3dRUFpmTTM3d3Zibjl0K2FqWXd4THRQdkE3a3Vl?= =?utf-8?B?ZXk4c1Q3QlZiZkkzdVZhRzhrUDVDMGdtNHd4bWhOR1N6WXkvNEpLM09qTlFa?= =?utf-8?B?N3Nyam41eEFJNVh0Q1VQWU9RbTBBSTJaamxHL3FsV2I0U0hVV3Y0cUFJOXJo?= =?utf-8?B?LzFnOTdZZm1GUlNTRndsTWdOSHpGcTNlNXhZOHFsVThUTzJxMEs2UTBJLzRN?= =?utf-8?B?bEJSQ2tTa0VZY0FjSklDM1Q4cUtybUs4Qy96S3RXeVNITnF3dTVVWVZiQzZQ?= =?utf-8?B?anRMWFBNMmFENTNVZU9RZ3pEc1Bna2ZwWU43cm1XL0JOQ2ZzbEl1WTUyU09m?= =?utf-8?B?a3B4a0M2N2ppcTNLOGlwU1NjdklIVkYxckFDK3o0MEJ6dXJhb2VsQTlYblBj?= =?utf-8?B?bElLQTJBR1pYN2wrYnkrclZ6TW8vMEFIM3dlRWxjT0lVTDdCeHlkODgwQVYy?= =?utf-8?B?bnlXR1hnallkMkVtUy9jTUlxaUxDSnMzNC9FaXpRaTlYNkVVb2c0THRZWldy?= =?utf-8?B?V21UMEV1aG13MHdka3VxbWs3bVozbFBLZzZIYldORE1Nc05RQys3OVhiSVlh?= =?utf-8?B?SEROTmtWYUtoOFRNTDU1Wnl1UDJkc2tjWG1TMWZoUmxmSGMzSDJ0WHJ1ZWtT?= =?utf-8?B?WUNCSzErYngyUldaMWNFMjFESjZiZzFKUVZrUTNGTXNZTStSNTZUSEhBaXpF?= =?utf-8?B?WS9Lb3hhUEpBWGNDOHZtRkZnb1Q5NFNTSk5WSGtIcFhzblNreFJVRTFTd29h?= =?utf-8?B?T1kvaFlBNFdLdGp0ZWRERUdkeVBVc2Y3MnI5NDZLakc5OUNGUnVwT3hXejBW?= =?utf-8?B?b0FBYzI1Nldzbmd5Ukg0NWdYYlZyaExJdHg1Z0ZZZ2VlSHo1VkRqNzRaQVFw?= =?utf-8?B?V2M1eGtjUyt2R214bUlIL0JqUEhQV0VOZ2M3SUhCYmw2aVNKTDZjSTY0bVRk?= =?utf-8?B?c3RJYWVLbUlIYmlFRTU0djNsd2ZiK3JEUnFBOW9PamxENW8xZ3VEMmMrbWRs?= =?utf-8?Q?anzp6yQmDMzEwvl5nBTveduxc?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2289fb87-0d68-4b8a-ee2d-08da6ef599be X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 10:57:15.1503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LeRGN/YOLZw8FiVzpRBhCpWB1RjgLcHR/Kc0V96j1ZXbi2ORfXqoID81Ixa+cXYfOP6DWXgbvqa1hAtWNZAM8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6269 W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEdlbmVyYWxdDQoNCkhpIENocmlzdG9waGVyLA0KDQpU aGFuayB5b3UgZm9yIHRoZSBxdWljayByZXNwb25zZS4gUGxlYXNlIGZpbmQgYW5zd2VycyBiZWxv dy4NCg0KPj4gRG9lcyBhdWRpbyBwbGF5YmFjayB3b3JrIE9LIGZyb20geW91ciBVYnVudHUgZG9t MD8NClllcy4NCg0KPj4gRG8geW91IGtub3cgd2hpY2ggdmVyc2lvbiBvZiBVYnVudHUgeW91IGFy ZSB1c2luZz8gKCdjYXQgL2V0Yy9sc2ItcmVsZWFzZScpDQpVYnVudHUgMjIuMDQgTFRTLg0KDQo+ PiBEbyB5b3Uga25vdyB3aGljaCB2ZXJzaW9uIG9mIFhlbiB5b3UgYXJlIHVzaW5nPyAoJ3hsIGlu Zm8nIGluIGRvbTAgc2hvdWxkIGhlbHApDQo0LjE2LjItcHJlLiANCg0KPj4gRG8geW91IGtub3cg d2hpY2ggdmVyc2lvbiBvZiBRZW11IHlvdSBoYXZlIGluc3RhbGxlZCBpbiBkb20wPw0KUUVNVSBl bXVsYXRvciB2ZXJzaW9uIDYuMS4xLg0KDQo+PiBEaWQgeW91IGJ1aWxkIGFuZCBpbnN0YWxsIFhl biBmcm9tIHNvdXJjZSBjb2RlLCBvciBhcmUgeW91IHVzaW5nIGJpbmFyeSBwYWNrYWdlcyBvZiBY ZW4gYW5kIGl0cyB0b29scz8NCldlIGJ1aWx0IGFuZCBpbnN0YWxsZWQgWGVuIGZyb20gc291cmNl IGNvZGUgKGdpdCBjbG9uZSBodHRwczovL3hlbmJpdHMueGVuLm9yZy9naXQtaHR0cC94ZW4uZ2l0 KS4NCg0KPj4gQXJlIHlvdSB1c2luZyB0aGUgeGwgdG9vbHMsIG9yIGxpYnZpcnQgdG9vbHMgZm9y IGNvbmZpZ3VyaW5nIGFuZCBydW5uaW5nIHlvdXIgZ3Vlc3Q/IC0tIGllLiBob3cgZG8geW91IHN0 YXJ0IHlvdXIgZG9tVSBWTT8NCldlIGFyZSB1c2luZyB4bCB0b29scyAoc3VkbyB4bCAtdiBjcmVh dGUgPHBhdGggdG8gaHZtIGNvbmZpZyBmaWxlPikuDQoNCj4+IFdoZW4geW91ciBkb21VIGlzIHJ1 bm5pbmcsIHBsZWFzZSBjb3VsZCB5b3UgcnVuICdwcyBhdXh3d3cnIGluIGRvbTAgYW5kIG9idGFp biB0aGUgcHJvY2VzcyBpbmZvcm1hdGlvbiBhYm91dCB0aGUgcWVtdSBpbnN0YW5jZSB0aGF0IGlz IHJ1bm5pbmcsIHNvIHRoYXQgd2UgY2FuIHNlZSB3aGF0IGNvbW1hbmQgbGluZSBhcmd1bWVudHMg aGF2ZSBiZWVuIHN1cHBsaWVkIHRvIGl0DQoNClRoaXMgaXMgdGhlIGxvZyB3ZSBnZXQgcmlnaHQg YWZ0ZXIgYm9vdGluZyBkb20gMDoNCg0Kcm9vdCA3MjMgMC4wIDAuMiAyNDM3OTIgMTQ0NjggPyBT bCAxNTo1MSAwOjAwIC91c3IvbG9jYWwvbGliL3hlbi9iaW4vcWVtdS1zeXN0ZW0taTM4NiAteGVu LWRvbWlkIDAgLXhlbi1hdHRhY2ggLW5hbWUgZG9tMCAtbm9ncmFwaGljIC1NIHhlbnB2IC1kYWVt b25pemUgLW1vbml0b3IgL2Rldi9udWxsIC1zZXJpYWwgL2Rldi9udWxsIC1wYXJhbGxlbCAvZGV2 L251bGwgLXBpZGZpbGUgL3Zhci9ydW4veGVuL3FlbXUtZG9tMC5waWQNCg0KVGhpcyBsb2cgaXMg c2VlbiBhZnRlciB3ZSBsYXVuY2ggZG9tIFUgKHN1ZG8geGwgLXYgY3JlYXRlIDxwYXRoIHRvIGh2 bSBjb25maWcgZmlsZT4pOg0KDQpyb290IDIxNTIgMjAuNyAyLjMgMjg1ODIwNCAxMzM0OTYgPyBT c2wgMTU6NTMgMDowOSAvdXNyL2xvY2FsL2xpYi94ZW4vYmluL3FlbXUtc3lzdGVtLWkzODYgLXhl bi1kb21pZCAxIC1uby1zaHV0ZG93biAtY2hhcmRldiBzb2NrZXQsaWQ9bGlieGwtY21kLHBhdGg9 L3Zhci9ydW4veGVuL3FtcC1saWJ4bC0xLHNlcnZlcj1vbix3YWl0PW9mZiAtbW9uIGNoYXJkZXY9 bGlieGwtY21kLG1vZGU9Y29udHJvbCAtY2hhcmRldiBzb2NrZXQsaWQ9bGlieGVuc3RhdC1jbWQs cGF0aD0vdmFyL3J1bi94ZW4vcW1wLWxpYnhlbnN0YXQtMSxzZXJ2ZXI9b24sd2FpdD1vZmYgLW1v biBjaGFyZGV2PWxpYnhlbnN0YXQtY21kLG1vZGU9Y29udHJvbCAtbm9kZWZhdWx0cyAtbm8tdXNl ci1jb25maWcgLW5hbWUgZG9tdS11YnVudHUuaHZtIC12bmMgMTI3LjAuMC4xOjAsdG89OTkgLWRp c3BsYXkgc2RsLGdsPW9uIC1zZGwgLWRldmljZSB2aXJ0aW8tdmdhLWdsIC1ib290IG9yZGVyPWRj IC11c2IgLXVzYmRldmljZSB0YWJsZXQgLXNtcCAyLG1heGNwdXM9MiAtbmV0IG5vbmUgLW1hY2hp bmUgeGVuZnYsc3VwcHJlc3Mtdm1kZXNjPW9uIC1tIDIwNDAgLWRyaXZlIGZpbGU9L2hvbWUvYW1k L3UyMDA0X3VidW50dS5xY293MixpZj1pZGUsaW5kZXg9MCxtZWRpYT1kaXNrLGZvcm1hdD1xY293 MixjYWNoZT13cml0ZWJhY2sNCg0KPj4gQSBsaXR0bGUgbW9yZSBpbmZvcm1hdGlvbiBhYm91dCB3 aGF0IHlvdSdyZSBydW5uaW5nIHdpbGwgaGVscCB3aXRoIHByb3ZpZGluZyBndWlkYW5jZSBoZXJl LiBUaGUgeGwgbWFuIHBhZ2UgaW5kaWNhdGVzIHRoYXQgdGhlcmUgaXMgYSAic291bmRodyIgb3B0 aW9uIGluIHRoZSBWTSBjb25maWd1cmF0aW9uIGZpbGUgZm9yIHBhc3Npbmcgc291bmQgaGFyZHdh cmUgY29uZmlndXRpb24gdGhyb3VnaCB0byBxZW11LCBzbyBpZiB5b3UgYXJlIHVzaW5nIHRoZSB4 bCB0b29sc3RhY2ssIHlvdSBjb3VsZCB0cnkgYWRkaW5nIHRoaXMgdG8gdGhlIGNvbmZpZyBmaWxl OiBzb3VuZGh3PSJoZGEiDQoNCkkgdHJpZWQgZ2l2aW5nIHNvdW5kaHc9ImhkYSIgb3B0aW9uIGlu IHRoZSBodm0gY29uZmlnIGZpbGUuIEhvd2V2ZXIsIEkgZG8gbm90IGhlYXIgYW55IHNvdW5kIHdo ZW4gSSBwbGF5IGEgd2F2ZSBmaWxlIGluIGRvbSBVLiBIZXJlIGlzIHRoZSAncHMgYXV4d3d3JyBv dXRwdXQgYWZ0ZXIgbWFraW5nIHRoaXMgY2hhbmdlOg0KDQpyb290IDI1NjggMTQuOCAyLjMgMjc3 MDg2NCAxMzQ3MjAgPyBTc2wgMTU6NTggMDowOSAvdXNyL2xvY2FsL2xpYi94ZW4vYmluL3FlbXUt c3lzdGVtLWkzODYgLXhlbi1kb21pZCAyIC1uby1zaHV0ZG93biAtY2hhcmRldiBzb2NrZXQsaWQ9 bGlieGwtY21kLHBhdGg9L3Zhci9ydW4veGVuL3FtcC1saWJ4bC0yLHNlcnZlcj1vbix3YWl0PW9m ZiAtbW9uIGNoYXJkZXY9bGlieGwtY21kLG1vZGU9Y29udHJvbCAtY2hhcmRldiBzb2NrZXQsaWQ9 bGlieGVuc3RhdC1jbWQscGF0aD0vdmFyL3J1bi94ZW4vcW1wLWxpYnhlbnN0YXQtMixzZXJ2ZXI9 b24sd2FpdD1vZmYgLW1vbiBjaGFyZGV2PWxpYnhlbnN0YXQtY21kLG1vZGU9Y29udHJvbCAtbm9k ZWZhdWx0cyAtbm8tdXNlci1jb25maWcgLW5hbWUgZG9tdS11YnVudHUtYXVkaW8uaHZtIC12bmMg MTI3LjAuMC4xOjAsdG89OTkgLWRpc3BsYXkgc2RsLGdsPW9uIC1zZGwgLWRldmljZSB2aXJ0aW8t dmdhLWdsIC1ib290IG9yZGVyPWRjIC11c2IgLXVzYmRldmljZSB0YWJsZXQgLXNvdW5kaHcgaGRh IC1zbXAgMixtYXhjcHVzPTIgLW5ldCBub25lIC1tYWNoaW5lIHhlbmZ2LHN1cHByZXNzLXZtZGVz Yz1vbiAtbSAyMDQwIC1kcml2ZSBmaWxlPS9ob21lL2FtZC91MjAwNF91YnVudHUucWNvdzIsaWY9 aWRlLGluZGV4PTAsbWVkaWE9ZGlzayxmb3JtYXQ9cWNvdzIsY2FjaGU9d3JpdGViYWNrDQoNCkFs c28sIEkgdHJpZWQgZ2l2aW5nIHNvdW5kaHc9ImFsbCIgaW4gdGhlIGNvbmZpZyBmaWxlLCBob3dl dmVyIHRoaXMgdGhyb3dzIGZvbGxvd2luZyBlcnJvcjoNCg0KbGlieGw6IGVycm9yOiBsaWJ4bF9k bS5jOjMxMzA6ZGV2aWNlX21vZGVsX3NwYXduX291dGNvbWU6IERvbWFpbiA0OmRvbWFpbiA0IGRl dmljZSBtb2RlbDogc3Bhd24gZmFpbGVkIChyYz0tMykNCmxpYnhsOiBlcnJvcjogbGlieGxfZG0u YzozMzUwOmRldmljZV9tb2RlbF9wb3N0Y29uZmlnX2RvbmU6IERvbWFpbiA0OlBvc3QgRE0gc3Rh cnR1cCBjb25maWdzIGZhaWxlZCwgcmM9LTMNCmxpYnhsOiBlcnJvcjogbGlieGxfY3JlYXRlLmM6 MTg2Nzpkb21jcmVhdGVfZGV2bW9kZWxfc3RhcnRlZDogRG9tYWluIDQ6ZGV2aWNlIG1vZGVsIGRp ZCBub3Qgc3RhcnQ6IC0zDQpsaWJ4bDogZXJyb3I6IGxpYnhsX2FvdXRpbHMuYzo2NDY6bGlieGxf X2tpbGxfeHNfcGF0aDogRGV2aWNlIE1vZGVsIGFscmVhZHkgZXhpdGVkDQpsaWJ4bDogZXJyb3I6 IGxpYnhsX2RvbWFpbi5jOjExODM6bGlieGxfX2Rlc3Ryb3lfZG9taWQ6IERvbWFpbiA0Ok5vbi1l eGlzdGFudCBkb21haW4NCmxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTEzNzpkb21haW5f ZGVzdHJveV9jYWxsYmFjazogRG9tYWluIDQ6VW5hYmxlIHRvIGRlc3Ryb3kgZ3Vlc3QNCmxpYnhs OiBlcnJvcjogbGlieGxfZG9tYWluLmM6MTA2NDpkb21haW5fZGVzdHJveV9jYjogRG9tYWluIDQ6 RGVzdHJ1Y3Rpb24gb2YgZG9tYWluIGZhaWxlZA0KDQpDYW4geW91IHBsZWFzZSBsZXQgbWUga25v dyB3aGF0IHBhcmFtZXRlcnMgSSBzaG91bGQgdXNlIGluIHRoZSBjb25maWcgZmlsZSB0byBwbGF5 IGF1ZGlvIGZyb20gZG9tIFU/DQoNClJlZ2FyZHMsDQpKeW90aXJtb3kNCg0KLS0tLS1PcmlnaW5h bCBNZXNzYWdlLS0tLS0NCkZyb206IENocmlzdG9waGVyIENsYXJrIDxjaHJpc3RvcGhlci53LmNs YXJrQGdtYWlsLmNvbT4gDQpTZW50OiBUdWVzZGF5LCBKdWx5IDI2LCAyMDIyIDI6NDQgQU0NClRv OiBTSEFSTUEsIEpZT1RJUk1PWSA8SllPVElSTU9ZLlNIQVJNQUBhbWQuY29tPg0KQ2M6IHhlbi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZzsgeGVuLXVzZXJzQGxpc3RzLnhlbnByb2plY3Qub3Jn DQpTdWJqZWN0OiBSZTogRW5hYmxlIGF1ZGlvIHZpcnR1YWxpemF0aW9uIGluIFhlbg0KDQpbQ0FV VElPTjogRXh0ZXJuYWwgRW1haWxdDQoNCk9uIE1vbiwgSnVsIDI1LCAyMDIyIGF0IDQ6NDUgQU0g U0hBUk1BLCBKWU9USVJNT1kgPEpZT1RJUk1PWS5TSEFSTUFAYW1kLmNvbT4gd3JvdGU6DQo+DQo+ IFtBTUQgT2ZmaWNpYWwgVXNlIE9ubHkgLSBHZW5lcmFsXQ0KPg0KPg0KPiBIaSBhbGwsDQoNCkhp IEp5b3Rpcm1veSwNCg0KSSBoYXZlIGFkZCB0aGUgeGVuLXVzZXJzIGxpc3QgdG8gQ0Mgc2luY2Ug dGhpcyB0aHJlYWQgbWF5IGJlIHVzZWZ1bCB0byB0aGF0IGZvcnVtLg0KDQo+IEkgYW0gdXNpbmcg dWJ1bnR1IGFzIGRvbSAwIGFuZCBhbHNvIGRvbSBVIChIVk0pLiBJIHdhbnQgdG8gcGxheSBhdWRp byBmcm9tIOKAnGRvbSBV4oCdIFVidW50dS4NCg0KSSB0aGluayB0aGF0IGl0IHNob3VsZCBiZSBw b3NzaWJsZSB0byBlbmFibGUgd2hhdCB5b3UgYXJlIGF0dGVtcHRpbmcgdG8gZG8uIGllLiBhdWRp byBvdXRwdXQgZnJvbSBhIEhWTSBVYnVudHUgZ3Vlc3QgVk0uDQoNClNvbWUgcXVlc3Rpb25zIHRv IHN1cHBvcnQgYXNzaXN0aW5nIHlvdToNCiogRG9lcyBhdWRpbyBwbGF5YmFjayB3b3JrIE9LIGZy b20geW91ciBVYnVudHUgZG9tMD8NCiogRG8geW91IGtub3cgd2hpY2ggdmVyc2lvbiBvZiBVYnVu dHUgeW91IGFyZSB1c2luZz8gKCdjYXQgL2V0Yy9sc2ItcmVsZWFzZScpDQoqIERvIHlvdSBrbm93 IHdoaWNoIHZlcnNpb24gb2YgWGVuIHlvdSBhcmUgdXNpbmc/ICgneGwgaW5mbycgaW4gZG9tMCBz aG91bGQgaGVscCkNCiogRG8geW91IGtub3cgd2hpY2ggdmVyc2lvbiBvZiBRZW11IHlvdSBoYXZl IGluc3RhbGxlZCBpbiBkb20wPw0KKiBEaWQgeW91IGJ1aWxkIGFuZCBpbnN0YWxsIFhlbiBmcm9t IHNvdXJjZSBjb2RlLCBvciBhcmUgeW91IHVzaW5nIGJpbmFyeSBwYWNrYWdlcyBvZiBYZW4gYW5k IGl0cyB0b29scz8NCiogQXJlIHlvdSB1c2luZyB0aGUgeGwgdG9vbHMsIG9yIGxpYnZpcnQgdG9v bHMgZm9yIGNvbmZpZ3VyaW5nIGFuZCBydW5uaW5nIHlvdXIgZ3Vlc3Q/IC0tIGllLiBob3cgZG8g eW91IHN0YXJ0IHlvdXIgZG9tVSBWTT8NCiogV2hlbiB5b3VyIGRvbVUgaXMgcnVubmluZywgcGxl YXNlIGNvdWxkIHlvdSBydW4gJ3BzIGF1eHd3dycgaW4gZG9tMCBhbmQgb2J0YWluIHRoZSBwcm9j ZXNzIGluZm9ybWF0aW9uIGFib3V0IHRoZSBxZW11IGluc3RhbmNlIHRoYXQgaXMgcnVubmluZywg c28gdGhhdCB3ZSBjYW4gc2VlIHdoYXQgY29tbWFuZCBsaW5lIGFyZ3VtZW50cyBoYXZlIGJlZW4g c3VwcGxpZWQgdG8gaXQNCg0KPiBJIGFtIG5ldyB0byBYZW4vdmlydHVhbGl6YXRpb24gaW4gZ2Vu ZXJhbC4NCg0KV2VsY29tZSEgOi0pDQoNCj4gRnJvbSB2YXJpb3VzIHJlYWRpbmcgSSB1bmRlcnN0 b29kIHRoYXQgSSBuZWVkIHRvIHRha2UgZm9sbG93aW5nIGFwcHJvYWNoOg0KPg0KPiAxLiBVc2Ug WGVuIGZyb250IGVuZCBBTFNBIGRyaXZlciBpbiBkb20gVQ0KDQpJJ20gbm90IGNlcnRhaW4gdGhh dCB0aGlzIGlzIG5lY2Vzc2FyeSBmb3IgeW91ciBIVk0gZ3Vlc3QuIEluc3RlYWQgb2YgdXNpbmcg dGhlIFhlbiBwYXJhdmlydHVhbGl6ZWQgYXVkaW8gcHJvdG9jb2wsIFFlbXUgc2hvdWxkIGJlIGFi bGUgdG8gcHJlc2VudCBhbiBlbXVsYXRlZCBhdWRpbyBkZXZpY2UgdG8gdGhlIEhWTSBndWVzdCBk b21VLCBhbmQgYSBzdGFuZGFyZCBhdWRpbyBkcml2ZXIgKGhkYSBvciBhYzk3KSBpbiBkb21VIHNo b3VsZCBzdWZmaWNlLg0KDQo+IDIuIFVzZSBRZW11IHRvIGNvbm5lY3QgdG8gdGhlIGJhY2tlbmQg QUxTQSBkcml2ZXIgaW4gRG9tIDANCg0KSSB0aGluayBpZiBRZW11IGlzIHN0YXJ0ZWQgd2l0aCB0 aGUgY29ycmVjdCBjb21tYW5kIGxpbmUgYXJndW1lbnRzLCBpdCBzaG91bGQgYmUgYWJsZSB0byBw bGF5IHNvdW5kIG9uIGJlaGFsZiBvZiB0aGUgZ3Vlc3QsIGlmIHNvdW5kIGlzIGNvcnJlY3RseSBj b25maWd1cmVkIGFuZCB3b3JraW5nIGluIGRvbTAuDQoNCj4gQ2FuIHlvdSBwbGVhc2UgbGV0IG1l IGtub3cgaWYgdGhpcyBhcHByb2FjaCBpcyBmaW5lPyBJZiB5ZXMsIEkgaGF2ZSBmb2xsb3dpbmcg cXVlc3Rpb25zOg0KPg0KPiAxLiBEbyBJIG5lZWQgdG8gcmVjb21waWxlIFVidW50dSB0byBzdXBw b3J0IFhlbiBmcm9udCBlbmQgQUxTQSBkcml2ZXI/IE9yIHdpbGwgVWJ1bnR1IGlzbyBmaWxlIGFs cmVhZHkgaGF2ZSBpdCBlbmFibGVkPw0KDQpJIHRoaW5rIHRoZSBsYXR0ZXIsIHRoYXQgdGhlIFVi dW50dSBpbnN0YWxsYXRpb24gSVNPIHNob3VsZCBhbHJlYWR5IGNvbnRhaW4gYSBzdWl0YWJsZSBh dWRpbyBkZXZpY2UgZHJpdmVyIHRoYXQgaXMgY29tcGF0aWJsZSB3aXRoIHRoZSB2aXJ0dWFsIGF1 ZGlvIGRldmljZSB0aGF0IGlzIGVtdWxhdGVkIGJ5IFFlbXUuDQoNCj4gMi4gSG8gZG8gSSBjb25m aWd1cmUgUWVtdSB0byBlbmFibGUgYmFja2VuZCBkcml2ZXI/DQoNCkEgbGl0dGxlIG1vcmUgaW5m b3JtYXRpb24gYWJvdXQgd2hhdCB5b3UncmUgcnVubmluZyB3aWxsIGhlbHAgd2l0aCBwcm92aWRp bmcgZ3VpZGFuY2UgaGVyZS4gVGhlIHhsIG1hbiBwYWdlIGluZGljYXRlcyB0aGF0IHRoZXJlIGlz IGEgInNvdW5kaHciIG9wdGlvbiBpbiB0aGUgVk0gY29uZmlndXJhdGlvbiBmaWxlIGZvciBwYXNz aW5nIHNvdW5kIGhhcmR3YXJlIGNvbmZpZ3V0aW9uIHRocm91Z2ggdG8gcWVtdSwgc28gaWYgeW91 IGFyZSB1c2luZyB0aGUgeGwgdG9vbHN0YWNrLCB5b3UgY291bGQgdHJ5IGFkZGluZyB0aGlzIHRv IHRoZSBjb25maWcgZmlsZTogc291bmRodz0iaGRhIg0KDQpDaHJpc3RvcGhlcg0K From xen-devel-bounces@lists.xenproject.org Tue Jul 26 11:00:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 11:00:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375125.607463 (Exim 4.92) (envelope-from ) id 1oGIIr-0000Rb-L1; Tue, 26 Jul 2022 11:00:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375125.607463; Tue, 26 Jul 2022 11:00:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGIIr-0000RU-Hx; Tue, 26 Jul 2022 11:00:41 +0000 Received: by outflank-mailman (input) for mailman id 375125; Tue, 26 Jul 2022 09:57:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGHJQ-00008p-Ga for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 09:57:12 +0000 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2053.outbound.protection.outlook.com [40.107.244.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4fccf840-0cc9-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 11:57:10 +0200 (CEST) Received: from BYAPR12MB3286.namprd12.prod.outlook.com (2603:10b6:a03:139::15) by BL1PR12MB5045.namprd12.prod.outlook.com (2603:10b6:208:310::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 09:57:05 +0000 Received: from BYAPR12MB3286.namprd12.prod.outlook.com ([fe80::54a6:6755:c7d4:4247]) by BYAPR12MB3286.namprd12.prod.outlook.com ([fe80::54a6:6755:c7d4:4247%4]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 09:57:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4fccf840-0cc9-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZtL8J5y5Aasq4TxBqLwum4ef/SB/S5Uysk5hq/Zs+rMtRvYQC4bWB67k+yh4VrkmoFcguGHU93M3MDi6rTrR/JNzqY+oRd9JZPUDMuGBOVK4Pr36hiSsbfD5YjDxPM0sLcyQ8HFWlMTcN5ynaIvvi/sJIi9B1BspTWFcwueaYMjpWVMy+C+PwduBuk4Io73Vi0nXENKzvRsY3JHsZpDlmRPe2UZbXZceStINeeprSJPgHhslAHrKONKrCJgNf9rSQh9SB/LyJPLWLbcrnyzeRT38AYHczWUltoh2ApUdvkGqAD8/cotP9FWPDlKCnWKnFCyRNbHB/Hxz1PKP2DitIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mJYeIaNluNlb95rtoIbwopKXqjHRtrKGQgf6RUU2lZI=; b=jNJGHbGfgqzSgrR6MgOpebXFLRC6m0WTVChBPMxQdE839UxGBYoQEEJ5BMNSIJUWznSgv2VKCtzTuHqvxynH2iMonDcBLRUWlKJygQ5y+QqzVq5vttU1A4KIoVKmn9LO3+XerU8T+yaqcVfkWBGOCPAWFeTv4xAMV7SIOe06faNT2zu8VF/tUdIeEBmSb2/Ze+Wha9N5Q7m5ACslYQFvJqRv+8hwPi/EvofhNVEbA/xLr5WfIm0bY0rH4VEZ39NMbVZveYVbs2Orqb+VdvUdyMHqeGO6mWFOSykvlVX0zHiWgS4t59hVR1Kc5DMBn3MThCfgkGn5nxgsRXEGleGdtg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mJYeIaNluNlb95rtoIbwopKXqjHRtrKGQgf6RUU2lZI=; b=mFQ6nrrDJCP7XAWh/cXUFi0jz/VengfyHAAxOaxAVd4+3Wvd614OYtXv3BCSHxTgHuMVcCsXS/F05W0CSy9jkJMiahyN1j3/MYPuYpL3assd+UYkvvHrEJC4EENMLSHpdjTOksvpZFKc49LveZyFDaobCKmyJtVPnsq7rfSvn4Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Date: Tue, 26 Jul 2022 15:26:19 +0530 From: "Gautham R. Shenoy" To: Peter Zijlstra Cc: rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, paulmck@kernel.org, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org Subject: Re: [PATCH 14/36] cpuidle: Fix rcu_idle_*() usage Message-ID: References: <20220608142723.103523089@infradead.org> <20220608144516.808451191@infradead.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220608144516.808451191@infradead.org> X-ClientProxiedBy: PN2PR01CA0114.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c01:27::29) To BYAPR12MB3286.namprd12.prod.outlook.com (2603:10b6:a03:139::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b218a5f-7771-4aee-c946-08da6eed317e X-MS-TrafficTypeDiagnostic: BL1PR12MB5045:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0rGd7TycVvllbrb5kpBgMBVy2g15TZH+MP69t8HeeLVf0o1ZuzZ7vx/Yiy+G4MTz0OBKXgFqqj2tklx7X+WILsnQUn05Arjqta3+XfgWeyTp4x4iptVBnQdtMWuJVWEif3B9XbQJ6zZetDTYoAS9l37gjsWGmajO3gqnvKKO78f+dQDbEh4fmqV5miM8aegf/IUcFpYVXCdcG49MqWFsDsKdzV1uz9xjY5t7tn1XbAUAgtRFmNAOiDVSnSDCOFjK4vPPjlD5jRW8nQ4yrq5P2LqJyGUU6ZF1/wAkJOgkCDtWwVDIGUZGHQhFNw91smlPTQw1CKhcO4XN5xT277O0WUAcKFjF5qreSTjXWZu99hN4Z07f0D12lFX20HO4omelf/ZfeiR8E0pPDaszR+hgsN5T2JuV35b1yUDy4XOHwFdiqUfya02Ua7ryYOv7sdyjegQzmAEVcXN+xbihmpGhGEz8GgYI7dV/9pEHbpQuM+Td84aBqrGGfBxA8wljxgWfJcBOMAYZTzEIveWg9XVUpg7YvfNjZU/yDaiTWdma5rQY92ZO5uICxwrG5DJDuXPVy7kpcRpQT134LYLRowyq3JL12hb37nC9NW8TEufHBHoroc313Rp83bcJjRMxOrmBQLWSOTFk5dUENZomuwyon9O9K+ExvObPR/ZgRMuP5AVvY+Yu4EFkLu9qfDGh6BHvghnDaqU3xvjP/oxNxIYpQOSRTAIUS+k/q0YHn3+23OCZYI3EpgPkfjP5k4PhjR5Ul56uCWNXmlqaw9PjEi/W2tnqx6ntTvV2iYdiWzJLVWc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB3286.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(396003)(366004)(39860400002)(376002)(66946007)(41300700001)(6512007)(7336002)(478600001)(7406005)(2906002)(86362001)(6916009)(6486002)(6666004)(4326008)(26005)(316002)(54906003)(8676002)(6506007)(38100700002)(83380400001)(186003)(7416002)(66556008)(30864003)(5660300002)(66476007)(8936002)(7366002)(7276002)(67856001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ez6DpKtdjPI+4H9OKkgE4Sd2xev8ToN1DfN6Bjmqv930WQL7QVV6TAdOm0ET?= =?us-ascii?Q?gnVLt55R0kfKFprsPYY8qeFWfDN1FK0eqHLTFAVCxlajQHBTshP5Ql+9wGrd?= =?us-ascii?Q?nWjAUEiEWKFckfD7OmTVW0KPhSdIZOPWo7RIRM59yK2SUUhysUapgXWGeTMa?= =?us-ascii?Q?bzRQqhC4WxCqr4vszqjbW4vRtBGIKovWM7tsxIULINXKIiemN4Hq7MI5RlcG?= =?us-ascii?Q?zbdXR6kE06PBcg4qEfBu1LgF7Ntn4+gyQJJ7H+qNfX8MvT6yCHr21P5oqPEy?= =?us-ascii?Q?VjpWPgJ6cr1czug8K8EscG3xva+PeRxFJgNoP2CdFOJZCOAQKg1t51DSv8Rl?= =?us-ascii?Q?/7IIrSTaPe3uM4Miigq+C4ewleS0OzlhdddrC1KPeSIctpYwS/b5UqjpFIt6?= =?us-ascii?Q?h2ipV2HN5HCuOkAACK5x1zlNyAQwp0qychRhZlRb7F5Hl6JwXkkdO7f5lm4h?= =?us-ascii?Q?OSjGjAskz2/t8npAmSgk9ElthoOQZQl9UHN4G2V1XggxXujNRI/CdwW/cu9f?= =?us-ascii?Q?CUTgyxMMh4UIgcj1B/WL5wUGNK06pa4cTaQz6OOuXrIaPQgPkognkIh/sbdR?= =?us-ascii?Q?1gAoCvZLv9sY9A4+Ne81LoLh/2wv1Q5/en2lJsWChpKuZht0jA6mGXmlqgyF?= =?us-ascii?Q?3Ue5It2C1bv5EF3QhM2hSZGzyDoz0KHVgjyLQEE9k0CYcdub4T1uHitzEhdX?= =?us-ascii?Q?6c/OHCErCh1bZty/G5dT5ObLEDoPqOZXDEcHhy1i1GH2Op/4E9yhD2vYZRL3?= =?us-ascii?Q?cjfTwK3SZl2M5Qq9o5eQd9SvEKGVrFjmKAvzMtx+dJj3N3VfxSPxVGFZlXIk?= =?us-ascii?Q?8eeg/sfUMI7gEcnsN0wrEHKlV8XdD6sHMYoMKq49FDR5tcEPrRafVH0pqvIK?= =?us-ascii?Q?qDCSZsGDpu2aoxx5t8TKLVeu/dUJiaVydXCCeGwxPphu3zmC4OqeC3ju8W66?= =?us-ascii?Q?1zEFcUzxm77d0fDbO+EP1HZgQnnctk7PKjM5A2PFDIrOuZKL10npR9IOHGrA?= =?us-ascii?Q?IBUymi0CR3LcNnBdJXVyjWO23/T/eOsdX0oHlxJ/09pyKiNnhh9M8055RNAj?= =?us-ascii?Q?ztYW2nU5CFqxdnA8E0F+YgkH+pQluU6cKhDNrhaZsLLlX4FoG4Dj/b1CKn2S?= =?us-ascii?Q?memz/H0lb4PJmJ+j5Bl31I05hgQzIUIqykJM9+fCRIzjzYciYNk4wbG9ZGZB?= =?us-ascii?Q?GlcFj4f7BpKF/c9Vq/LGcgBdtKFohLue9fFx1k56H3Yuh/MzNw8EgcT6g8ca?= =?us-ascii?Q?hZ4JLU2wV1EiBlG4PtsrMU5mb3XD7iDErGdxEVyZizYXYjVN4gqgmnExNJ+x?= =?us-ascii?Q?utreHOCHCx98Hlsm3Li0Zh1LXfx49/Q2gU9d7n4vdX9e5sDgOocLVTl5Stp1?= =?us-ascii?Q?2gl0Dos7bDgm2W9FUvAsIcgBzIner3eiNxeyW//rccZZFbj4G/m4k/BdIR7I?= =?us-ascii?Q?Z9pByYKWiO49WroUKpL2YlXHNLqKxTHDLRKZFK9QxbUKDT+aAa1l26Sg9qkz?= =?us-ascii?Q?/vxOuwblhzhI857GyijZCYm+WTJuAFm5YZTNLw/iHmvQjdq+49lSTo9Ixf9l?= =?us-ascii?Q?bdO0EFhuSm3I3OzNu1kjV8mcwsxTfPC+3n+DFbxI?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b218a5f-7771-4aee-c946-08da6eed317e X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3286.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 09:57:04.5231 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6SMKvEfRPtPiSRMM1M8dJmKDlP4yxlf6olkte9hw0IvAyuTX3j4zSZfu5E0/uNDvQ8s98+yjS30fLi2uWIFKkw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5045 On Wed, Jun 08, 2022 at 04:27:37PM +0200, Peter Zijlstra wrote: > The whole disable-RCU, enable-IRQS dance is very intricate since > changing IRQ state is traced, which depends on RCU. > > Add two helpers for the cpuidle case that mirror the entry code. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Gautham R. Shenoy > --- > arch/arm/mach-imx/cpuidle-imx6q.c | 4 +-- > arch/arm/mach-imx/cpuidle-imx6sx.c | 4 +-- > arch/arm/mach-omap2/cpuidle34xx.c | 4 +-- > arch/arm/mach-omap2/cpuidle44xx.c | 8 +++--- > drivers/acpi/processor_idle.c | 18 ++++++++------ > drivers/cpuidle/cpuidle-big_little.c | 4 +-- > drivers/cpuidle/cpuidle-mvebu-v7.c | 4 +-- > drivers/cpuidle/cpuidle-psci.c | 4 +-- > drivers/cpuidle/cpuidle-riscv-sbi.c | 4 +-- > drivers/cpuidle/cpuidle-tegra.c | 8 +++--- > drivers/cpuidle/cpuidle.c | 11 ++++---- > include/linux/cpuidle.h | 37 +++++++++++++++++++++++++--- > kernel/sched/idle.c | 45 ++++++++++------------------------- > kernel/time/tick-broadcast.c | 6 +++- > 14 files changed, 90 insertions(+), 71 deletions(-) > > --- a/arch/arm/mach-imx/cpuidle-imx6q.c > +++ b/arch/arm/mach-imx/cpuidle-imx6q.c > @@ -24,9 +24,9 @@ static int imx6q_enter_wait(struct cpuid > imx6_set_lpm(WAIT_UNCLOCKED); > raw_spin_unlock(&cpuidle_lock); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > cpu_do_idle(); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > raw_spin_lock(&cpuidle_lock); > if (num_idle_cpus-- == num_online_cpus()) > --- a/arch/arm/mach-imx/cpuidle-imx6sx.c > +++ b/arch/arm/mach-imx/cpuidle-imx6sx.c > @@ -47,9 +47,9 @@ static int imx6sx_enter_wait(struct cpui > cpu_pm_enter(); > cpu_cluster_pm_enter(); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > cpu_suspend(0, imx6sx_idle_finish); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > cpu_cluster_pm_exit(); > cpu_pm_exit(); > --- a/arch/arm/mach-omap2/cpuidle34xx.c > +++ b/arch/arm/mach-omap2/cpuidle34xx.c > @@ -133,9 +133,9 @@ static int omap3_enter_idle(struct cpuid > } > > /* Execute ARM wfi */ > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > omap_sram_idle(); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > /* > * Call idle CPU PM enter notifier chain to restore > --- a/arch/arm/mach-omap2/cpuidle44xx.c > +++ b/arch/arm/mach-omap2/cpuidle44xx.c > @@ -105,9 +105,9 @@ static int omap_enter_idle_smp(struct cp > } > raw_spin_unlock_irqrestore(&mpu_lock, flag); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > omap4_enter_lowpower(dev->cpu, cx->cpu_state); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > raw_spin_lock_irqsave(&mpu_lock, flag); > if (cx->mpu_state_vote == num_online_cpus()) > @@ -186,10 +186,10 @@ static int omap_enter_idle_coupled(struc > } > } > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > omap4_enter_lowpower(dev->cpu, cx->cpu_state); > cpu_done[dev->cpu] = true; > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > /* Wakeup CPU1 only if it is not offlined */ > if (dev->cpu == 0 && cpumask_test_cpu(1, cpu_online_mask)) { > --- a/drivers/acpi/processor_idle.c > +++ b/drivers/acpi/processor_idle.c > @@ -607,7 +607,7 @@ static DEFINE_RAW_SPINLOCK(c3_lock); > * @cx: Target state context > * @index: index of target state > */ > -static int acpi_idle_enter_bm(struct cpuidle_driver *drv, > +static noinstr int acpi_idle_enter_bm(struct cpuidle_driver *drv, > struct acpi_processor *pr, > struct acpi_processor_cx *cx, > int index) > @@ -626,6 +626,8 @@ static int acpi_idle_enter_bm(struct cpu > */ > bool dis_bm = pr->flags.bm_control; > > + instrumentation_begin(); > + > /* If we can skip BM, demote to a safe state. */ > if (!cx->bm_sts_skip && acpi_idle_bm_check()) { > dis_bm = false; > @@ -647,11 +649,11 @@ static int acpi_idle_enter_bm(struct cpu > raw_spin_unlock(&c3_lock); > } > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > acpi_idle_do_entry(cx); > > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > /* Re-enable bus master arbitration */ > if (dis_bm) { > @@ -661,11 +663,13 @@ static int acpi_idle_enter_bm(struct cpu > raw_spin_unlock(&c3_lock); > } > > + instrumentation_end(); > + > return index; > } > > -static int acpi_idle_enter(struct cpuidle_device *dev, > - struct cpuidle_driver *drv, int index) > +static noinstr int acpi_idle_enter(struct cpuidle_device *dev, > + struct cpuidle_driver *drv, int index) > { > struct acpi_processor_cx *cx = per_cpu(acpi_cstate[index], dev->cpu); > struct acpi_processor *pr; > @@ -693,8 +697,8 @@ static int acpi_idle_enter(struct cpuidl > return index; > } > > -static int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > - struct cpuidle_driver *drv, int index) > +static noinstr int acpi_idle_enter_s2idle(struct cpuidle_device *dev, > + struct cpuidle_driver *drv, int index) > { > struct acpi_processor_cx *cx = per_cpu(acpi_cstate[index], dev->cpu); > > --- a/drivers/cpuidle/cpuidle-big_little.c > +++ b/drivers/cpuidle/cpuidle-big_little.c > @@ -126,13 +126,13 @@ static int bl_enter_powerdown(struct cpu > struct cpuidle_driver *drv, int idx) > { > cpu_pm_enter(); > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > cpu_suspend(0, bl_powerdown_finisher); > > /* signals the MCPM core that CPU is out of low power state */ > mcpm_cpu_powered_up(); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > cpu_pm_exit(); > > --- a/drivers/cpuidle/cpuidle-mvebu-v7.c > +++ b/drivers/cpuidle/cpuidle-mvebu-v7.c > @@ -36,9 +36,9 @@ static int mvebu_v7_enter_idle(struct cp > if (drv->states[index].flags & MVEBU_V7_FLAG_DEEP_IDLE) > deepidle = true; > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > ret = mvebu_v7_cpu_suspend(deepidle); > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > cpu_pm_exit(); > > --- a/drivers/cpuidle/cpuidle-psci.c > +++ b/drivers/cpuidle/cpuidle-psci.c > @@ -74,7 +74,7 @@ static int __psci_enter_domain_idle_stat > else > pm_runtime_put_sync_suspend(pd_dev); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > state = psci_get_domain_state(); > if (!state) > @@ -82,7 +82,7 @@ static int __psci_enter_domain_idle_stat > > ret = psci_cpu_suspend_enter(state) ? -1 : idx; > > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > if (s2idle) > dev_pm_genpd_resume(pd_dev); > --- a/drivers/cpuidle/cpuidle-riscv-sbi.c > +++ b/drivers/cpuidle/cpuidle-riscv-sbi.c > @@ -121,7 +121,7 @@ static int __sbi_enter_domain_idle_state > else > pm_runtime_put_sync_suspend(pd_dev); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > if (sbi_is_domain_state_available()) > state = sbi_get_domain_state(); > @@ -130,7 +130,7 @@ static int __sbi_enter_domain_idle_state > > ret = sbi_suspend(state) ? -1 : idx; > > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > if (s2idle) > dev_pm_genpd_resume(pd_dev); > --- a/drivers/cpuidle/cpuidle-tegra.c > +++ b/drivers/cpuidle/cpuidle-tegra.c > @@ -183,7 +183,7 @@ static int tegra_cpuidle_state_enter(str > tegra_pm_set_cpu_in_lp2(); > cpu_pm_enter(); > > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > switch (index) { > case TEGRA_C7: > @@ -199,7 +199,7 @@ static int tegra_cpuidle_state_enter(str > break; > } > > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > > cpu_pm_exit(); > tegra_pm_clear_cpu_in_lp2(); > @@ -240,10 +240,10 @@ static int tegra_cpuidle_enter(struct cp > > if (index == TEGRA_C1) { > if (do_rcu) > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > ret = arm_cpuidle_simple_enter(dev, drv, index); > if (do_rcu) > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > } else > ret = tegra_cpuidle_state_enter(dev, index, cpu); > > --- a/drivers/cpuidle/cpuidle.c > +++ b/drivers/cpuidle/cpuidle.c > @@ -13,6 +13,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -150,12 +151,12 @@ static void enter_s2idle_proper(struct c > */ > stop_critical_timings(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > target_state->enter_s2idle(dev, drv, index); > if (WARN_ON_ONCE(!irqs_disabled())) > - local_irq_disable(); > + raw_local_irq_disable(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > tick_unfreeze(); > start_critical_timings(); > > @@ -233,14 +234,14 @@ int cpuidle_enter_state(struct cpuidle_d > > stop_critical_timings(); > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_enter(); > + cpuidle_rcu_enter(); > > entered_state = target_state->enter(dev, drv, index); > if (WARN_ONCE(!irqs_disabled(), "%ps leaked IRQ state", target_state->enter)) > raw_local_irq_disable(); > > if (!(target_state->flags & CPUIDLE_FLAG_RCU_IDLE)) > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > start_critical_timings(); > > sched_clock_idle_wakeup_event(); > --- a/include/linux/cpuidle.h > +++ b/include/linux/cpuidle.h > @@ -115,6 +115,35 @@ struct cpuidle_device { > DECLARE_PER_CPU(struct cpuidle_device *, cpuidle_devices); > DECLARE_PER_CPU(struct cpuidle_device, cpuidle_dev); > > +static __always_inline void cpuidle_rcu_enter(void) > +{ > + lockdep_assert_irqs_disabled(); > + /* > + * Idle is allowed to (temporary) enable IRQs. It > + * will return with IRQs disabled. > + * > + * Trace IRQs enable here, then switch off RCU, and have > + * arch_cpu_idle() use raw_local_irq_enable(). Note that > + * rcu_idle_enter() relies on lockdep IRQ state, so switch that > + * last -- this is very similar to the entry code. > + */ > + trace_hardirqs_on_prepare(); > + lockdep_hardirqs_on_prepare(); > + instrumentation_end(); > + rcu_idle_enter(); > + lockdep_hardirqs_on(_THIS_IP_); > +} > + > +static __always_inline void cpuidle_rcu_exit(void) > +{ > + /* > + * Carefully undo the above. > + */ > + lockdep_hardirqs_off(_THIS_IP_); > + rcu_idle_exit(); > + instrumentation_begin(); > +} > + > /**************************** > * CPUIDLE DRIVER INTERFACE * > ****************************/ > @@ -282,18 +311,18 @@ extern s64 cpuidle_governor_latency_req( > int __ret = 0; \ > \ > if (!idx) { \ > - rcu_idle_enter(); \ > + cpuidle_rcu_enter(); \ > cpu_do_idle(); \ > - rcu_idle_exit(); \ > + cpuidle_rcu_exit(); \ > return idx; \ > } \ > \ > if (!is_retention) \ > __ret = cpu_pm_enter(); \ > if (!__ret) { \ > - rcu_idle_enter(); \ > + cpuidle_rcu_enter(); \ > __ret = low_level_idle_enter(state); \ > - rcu_idle_exit(); \ > + cpuidle_rcu_exit(); \ > if (!is_retention) \ > cpu_pm_exit(); \ > } \ > --- a/kernel/sched/idle.c > +++ b/kernel/sched/idle.c > @@ -51,18 +51,22 @@ __setup("hlt", cpu_idle_nopoll_setup); > > static noinline int __cpuidle cpu_idle_poll(void) > { > + instrumentation_begin(); > trace_cpu_idle(0, smp_processor_id()); > stop_critical_timings(); > - rcu_idle_enter(); > - local_irq_enable(); > + cpuidle_rcu_enter(); > > + raw_local_irq_enable(); > while (!tif_need_resched() && > (cpu_idle_force_poll || tick_check_broadcast_expired())) > cpu_relax(); > + raw_local_irq_disable(); > > - rcu_idle_exit(); > + cpuidle_rcu_exit(); > start_critical_timings(); > trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id()); > + local_irq_enable(); > + instrumentation_end(); > > return 1; > } > @@ -85,44 +89,21 @@ void __weak arch_cpu_idle(void) > */ > void __cpuidle default_idle_call(void) > { > - if (current_clr_polling_and_test()) { > - local_irq_enable(); > - } else { > - > + instrumentation_begin(); > + if (!current_clr_polling_and_test()) { > trace_cpu_idle(1, smp_processor_id()); > stop_critical_timings(); > > - /* > - * arch_cpu_idle() is supposed to enable IRQs, however > - * we can't do that because of RCU and tracing. > - * > - * Trace IRQs enable here, then switch off RCU, and have > - * arch_cpu_idle() use raw_local_irq_enable(). Note that > - * rcu_idle_enter() relies on lockdep IRQ state, so switch that > - * last -- this is very similar to the entry code. > - */ > - trace_hardirqs_on_prepare(); > - lockdep_hardirqs_on_prepare(); > - rcu_idle_enter(); > - lockdep_hardirqs_on(_THIS_IP_); > - > + cpuidle_rcu_enter(); > arch_cpu_idle(); > - > - /* > - * OK, so IRQs are enabled here, but RCU needs them disabled to > - * turn itself back on.. funny thing is that disabling IRQs > - * will cause tracing, which needs RCU. Jump through hoops to > - * make it 'work'. > - */ > raw_local_irq_disable(); > - lockdep_hardirqs_off(_THIS_IP_); > - rcu_idle_exit(); > - lockdep_hardirqs_on(_THIS_IP_); > - raw_local_irq_enable(); > + cpuidle_rcu_exit(); > > start_critical_timings(); > trace_cpu_idle(PWR_EVENT_EXIT, smp_processor_id()); > } > + local_irq_enable(); > + instrumentation_end(); > } > > static int call_cpuidle_s2idle(struct cpuidle_driver *drv, > --- a/kernel/time/tick-broadcast.c > +++ b/kernel/time/tick-broadcast.c > @@ -622,9 +622,13 @@ struct cpumask *tick_get_broadcast_onesh > * to avoid a deep idle transition as we are about to get the > * broadcast IPI right away. > */ > -int tick_check_broadcast_expired(void) > +noinstr int tick_check_broadcast_expired(void) > { > +#ifdef _ASM_GENERIC_BITOPS_INSTRUMENTED_NON_ATOMIC_H > + return arch_test_bit(smp_processor_id(), cpumask_bits(tick_broadcast_force_mask)); > +#else > return cpumask_test_cpu(smp_processor_id(), tick_broadcast_force_mask); > +#endif > } > > /* > > From xen-devel-bounces@lists.xenproject.org Tue Jul 26 11:07:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 11:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375157.607475 (Exim 4.92) (envelope-from ) id 1oGIPq-0001KJ-H5; Tue, 26 Jul 2022 11:07:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375157.607475; Tue, 26 Jul 2022 11:07:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGIPq-0001KC-EN; Tue, 26 Jul 2022 11:07:54 +0000 Received: by outflank-mailman (input) for mailman id 375157; Tue, 26 Jul 2022 11:07:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGIPp-0001K6-FK for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 11:07:53 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60053.outbound.protection.outlook.com [40.107.6.53]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 311771fd-0cd3-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 13:07:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB4667.eurprd04.prod.outlook.com (2603:10a6:5:37::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 11:07:50 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 11:07:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 311771fd-0cd3-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lLdMSWeTQuUtIGUixKVgYRLdvVPvM8ci9lp+N+JEZ+KkyHxFeRzTj3I9b/t0UiAwxznvRspiXQEwtM88Z0dSAD3sKOigqnChIOaknVvKqRxf2nx3fkqdlFhctnP6OiXy6ZWKJOhIrWYpqBzUgIuv4xYTqriLeoFswMAat3Ce0XtrG7yoA5qfMBgzwvqxe3VAedec917773p6WgL0k7mwdwzNr4pJ6uCTvoguPm9O613DUrLC7N/NTvE5RgeKFgSlTAwgR+3w8EHVRILoEp8+Q+gmdDbgKNKCnlIV8dK9RlbcKw4tl56WbjktkMBjupUgOLCKjaj9xBVS+chzPctxUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LBeEMw4RG3ww4qAmAf0pPVxQdgV8XD7EGgOGB3Zumyc=; b=fYsGOpF8AixM1LN4/ld3uXfouhUbFyxwVwK5j37u4jvGFS0+TLWSyhzegDT+NG3a+5Ni3PRuP6fm5Soh20EUpgl7YJb1x2k0/s32SIRqbZVXXBtIe7SK5ufQc5tO3U5KOtn1qWnPlNTzYD+rIntgPEDNKEOtF9aO6wTrOnadjr68ZWAmp1LT6KK+Y9iA2dw2SBGNQBhgR8jRuSNjl4253cqUFuC/iyEDfHeuyqUX2DYzHf//AsMB3oQ4kqD6bBTIol8euoe4SISuVfm9MtiJq2qWKdKBn+m6Gs0u1dWD6TfxnOIHiKFST0LPJ28LZzRmMNiWx4wI1JVRob4Ka8NS4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LBeEMw4RG3ww4qAmAf0pPVxQdgV8XD7EGgOGB3Zumyc=; b=Jiy/buN3cFlgG/5qOVuTdZO84bktf6vNuEtdgMu/mBboCmlwn4dDCS/m2nbIcO0IIMnUAIZou8haX03grrdUxzKSa1HE6mMX2T1tC0zcW5zmlIESRAiwZTZp1yLA5j3IoX3Wvq6fccmkxX4afMehy3dAg6mi93qxhAOLiZDt+1TROJgHo6+UwgXyjWmyIUBbzL4EFPghdJPmcsjUMEOdUwcY+Y5Xv0M/hUu5vNQxu53O5tsyqChcXjML6Ku7AcC6ZzZcYDCKb4OFeevcPjdNIpcI0pyUurSc0jUY+RnYRw5OlAzoOJIRb+/tWO2LV8cTc2MQPG3CsMobgXP2XgZCoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <190b7280-e024-8870-0032-56cbe282c41b@suse.com> Date: Tue, 26 Jul 2022 13:07:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: Random crash during guest start on x86 Content-Language: en-US To: Bertrand Marquis Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel References: <65C0A220-EC7E-4915-AC45-77D87F4E411E@arm.com> <7d816c9d-412a-bcee-f1ab-3b4b46051b8a@suse.com> <880625A9-C3C8-4D45-A4E8-BB443E9D4CEF@arm.com> <194eaccc-b05f-c1f2-d861-737f3a881966@suse.com> <03648C7A-D7E8-4348-B2CA-43CBAA7FC51A@arm.com> From: Jan Beulich In-Reply-To: <03648C7A-D7E8-4348-B2CA-43CBAA7FC51A@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM5PR1001CA0034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:206:2::47) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 23923f1a-d35a-4acd-4cb6-08da6ef713df X-MS-TrafficTypeDiagnostic: DB7PR04MB4667:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 56Eeu0NDhaUu684XqTptfv9OUHxkffIFUG1asKcJ881hakcga/n0JtKBA4+A96pYwKRY2YGO3dkGfKVy2LjIYpF4s8kcw+KuB/PmsxL8j88feirxvYeafzwIpbq1MnkshPT2jHR1chj+iWOzIfYcYam8CvLrst79P6Ade9FYqli9VMNpczjWEpbkTt2wuAwYdVUQGxOmJ0SQT1Cy54cQ678QrYrI5nSnUV90D4ju6QJyWGo+Fop8N82Kov6Q32SF1ngTzDqy5RlAm3yUXXUazp4OpV8vVGDEM9X1V3vDcG4Yswp/u/+hKR7Hk/k+iaFptJQSPocHihS28Yh0T1LobQEhXV/OODRg1EQwNi+475B9sFSYHO++8UYZHglxv/Gv2BwTSO8wDY8xWC8iZvN/LveQ5tOPcaNDK8d2IjyCJ8vfZNHrhyv18CghnVk8cEl5NxFuKS95ty/8+e+cWWJL4OOY33YmdsYvrnDdqYEFwMVN0VQYR/ifDaCKSNNxu+YyfdgIxOApK7tVWWGqS+92qtjAm6dsYWdOv1hrwlJqlPv/btA0S7Nma9+RV+RgzI3yYdTkFgXYc6E0yhNg24eMnQHL0WAN3Yf0jTtycFri4DRdYnLtw5pVyXMUeIyWhW3Z07L6efJHDKvKU8ngYTqNCmcV77DQqo/HnYdcO5AG7h9mDfHCvDglokN/9goZnyTew0vqBusnAYtMDdWiTKNeLAkjQ0qtjiejzs7q0zhs5CftUtEsCspQyQ/n1T0TNKciAWLwPkaXVgpJOtlp5myZHtPqwcd2NkdloEJnHtzBuNus9U3N5VitPPwPVSHlNLF/+9ObCHIuW5wDRcxBQi1I+Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(39860400002)(376002)(366004)(2616005)(66946007)(6916009)(31686004)(186003)(53546011)(38100700002)(6506007)(26005)(54906003)(31696002)(6512007)(36756003)(86362001)(66556008)(4326008)(66476007)(478600001)(2906002)(5660300002)(8936002)(6486002)(8676002)(558084003)(316002)(41300700001)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dWJmYlpqWEhDNmRqbVI3SDVuZ240QnJyN2l0RDdEY00vSTljNHJsMy9XSy82?= =?utf-8?B?ZS8rUVo4YUZjL0JMOWpIeWpWY2pzL1VyWmpOcHRUMHprK3gyY0NVRnl3aG1C?= =?utf-8?B?NkU2MGV5eEVWdi9PbFIvWHBXM2UzdlA1ekhoVm9NRUpnNlFhL2I3V1kxbnZO?= =?utf-8?B?VzhRMW1oakthZ3lqZk1SWHk5YmxUdmx0ZXVwWVZScnVBSVpKekJhK1RQOHgv?= =?utf-8?B?SzRuZjhlY3hDRzNvWnZ1TWFGZHVUWVd3em83d3ZyQjJVMk1ObjRJVEdGTkp2?= =?utf-8?B?VkhrSFhqNVhzNXN0QkdHcHBNa0wraWdMS0xLNDhnZG1PZmFhTUFTd1BvTGlh?= =?utf-8?B?MEhBck9sc3M2akFFaHhrWFNWSmtmYUEzYnhRWXE4SmNSV3QxdGNFWUtuaUJ2?= =?utf-8?B?WWNPS29vb3puczBuMU41NHRJYmp6NHlPMHBQMnBGdENQdWFzb0FGcHliMVhN?= =?utf-8?B?YytZV29Jdm5QNjY0NzJ3bkw5TnhZYzV2UWJqbm9oMVM4OWg4S0lEeldtN2Ur?= =?utf-8?B?MTdEYTdOS0xUWmxFNXRQaC9FVk1SWm9Ka29EdTdKYzljbjBQWmQ1eFJXSGNr?= =?utf-8?B?b29acGlBWGdSd0JzZEpZTTBRWUlEOU9iVGE1UmgyQ0RJSVNQaEpKTWFNYVJQ?= =?utf-8?B?U2d4S3lHbjhVUEFocm0xTGx6T2dHSlk4UmNuSXdRTUF3WnpXV1VJd2ljcG1K?= =?utf-8?B?RmFvR0Q5c1VLTElRNlozeUVwSTN2UnE5MDJ1b2JvZ05qZHVTTnJmMDZUZll3?= =?utf-8?B?bzlhbkROZFM2cUczaVh1RTNjRjJHUFAzd0VBREJBR2VqYnY2VDVJWVl6eStL?= =?utf-8?B?ZVNGdU9McnJaZ1R2VVk5SDRYMkZ3ZzR6TGtONU5vb0lUODNxNDJvV3J2UlU0?= =?utf-8?B?aGo0UjNOVU01ckFmS2QzK0x2S1NKd3JsUFZLc0YrdlE5aUN2NWxzTytnQUVz?= =?utf-8?B?MWNFbHpPaDhUUWN4N3JYMUQ1YjRBQlpIY2ZXWDhUbEoxczEzUWpsQ1M4b3dn?= =?utf-8?B?ZFhWWFlrNXhGaXI0MzJFaTIyV2pzZVQ5N2MwNVhWcUlZaUVJTmFnR0NCY2lt?= =?utf-8?B?SUQ4K0QwSEpycSsyQnYyRDFxeEtTbzQ5bW4vMmVvMGRWSWhLZnhBd0E0cGFR?= =?utf-8?B?T0IyV1k1UHBQUVFFWm1xamFBNDIwQWw4UWhXTUNNdmxYL2VncldhSkV0RW04?= =?utf-8?B?cE5kNFlJVVFkVVF6dlNicklmYWRqNGcyeTIzMUllWGxOaUxIdzlhVWxjM3hY?= =?utf-8?B?S09YNXpFQVJsNjlvcC8xS280Vy9peHJreTZaOUxkTjBnaGJIckVkSmhmU2d0?= =?utf-8?B?NXhZYTBZU3I3Z2F5b2pXRmIvSmcrdzI3US95VVJSWUlheTVYemU3Si9YV2FQ?= =?utf-8?B?YVZ0dUNueE5oNzRXRTk2SjhqRnE3NktBS0p3b09lMWZERFRueWN3S0plOWNn?= =?utf-8?B?OUtaNStGTWVsZG1WeUJOREZBU3Q4elRnNzFTeURRU1FlbTY1dXdZOFA2RDVR?= =?utf-8?B?OVpDWGZZWUM4RkczOHBtODZWQkhtK2hmMmw0dHR2aW5ONlRyOWRlMk84YitN?= =?utf-8?B?cE5JdTVSZ3VsLzRma095T2ZFa3JrODZpVEdEVVphd3JadVNaNTJheTdQV0tE?= =?utf-8?B?YitBY0F2VUFZWS9KT0k4U1RDSmpadWVYcy9obFBWZURaK2l0MndQRnFOeXVI?= =?utf-8?B?elFwb2JHR1lzbnd0ZTJISXF3SHFJZ2NDTi84Tkk2bzRGYUQzbkk0eEVDK29s?= =?utf-8?B?bkpwM3M5ZmJsemR5d3c1OUlVc2J6UmJrY2gvL0w3RHk0UmREdlhPTnE4d0tU?= =?utf-8?B?Mm1mWHpEZllmbUM2WW9tTXFLa0o2NVVIc0t2YlI0dDg5VFNzS29jRkZ0dkJS?= =?utf-8?B?b21aMk52UFhMMzlQMmxOY2thQ1N1bTh0aGR1ZmUxLytscHlubEZ0Tit3NHJN?= =?utf-8?B?OXlpa3pwMUc0T3Z6ZGVWSVRveTZ4dWZPcS9jdWpsK3pmR28yREFYQ1FuSUEx?= =?utf-8?B?S1BjNjVDdnFsNHYvYVQyQlFHSzdTakl3VXV1MkZJNnhmc0lTaHpSbFExQStR?= =?utf-8?B?NHlKTDhDZFl1QVUvSHZSWnZkRXpuZmhCN21tTGRJaHhaTk45d2JXN2ZKYS9G?= =?utf-8?Q?HvasEdpjmb5cyZ0AjazA4l6bm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23923f1a-d35a-4acd-4cb6-08da6ef713df X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 11:07:49.8225 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /30MjT4bnm63qNxiGiPTIt2E5IS+mjrX6CqTMncUUqO753FMPck1ies7UbEUqy0lKwLzx4HoczXGLxb46Bepxw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4667 On 26.07.2022 12:36, Bertrand Marquis wrote: > Would it make sense then for me to try a newer linux kernel first ? While it's almost always worth a try, I can't really tell. That's precisely the kind of question that maintainers are in a better position to answer. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 11:52:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 11:52:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375164.607486 (Exim 4.92) (envelope-from ) id 1oGJ6E-0006lj-RY; Tue, 26 Jul 2022 11:51:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375164.607486; Tue, 26 Jul 2022 11:51:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJ6E-0006lc-MY; Tue, 26 Jul 2022 11:51:42 +0000 Received: by outflank-mailman (input) for mailman id 375164; Tue, 26 Jul 2022 11:51:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJ6D-0006lW-96 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 11:51:41 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4c0bb575-0cd9-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 13:51:37 +0200 (CEST) Received: from mail-dm6nam11lp2171.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 07:51:32 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5008.namprd03.prod.outlook.com (2603:10b6:208:1ac::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 11:51:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 11:51:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4c0bb575-0cd9-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658836297; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Nth+WSRqmnNZNtt/75bzbUKnlGqNX8w23rCVYKIJuKo=; b=LyPnSYcClexjnCUWP6U6/hUopEBJvKvYArAgpFvFsamT0ex6LFwOrVHf lhQ/Al1wCYAAuLQUN0qHG00IAUsgCMbIz/oxA6EK9SS5qZqzT9rIxqirn WAqYHTetF8h1WDcXcO5L93skcYq3qFUVUoJSbb/DcBBTHJPia+zUASNVd E=; X-IronPort-RemoteIP: 104.47.57.171 X-IronPort-MID: 76640460 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5uHLD64SPdjq7FLDG6AOPQxRtBDGchMFZxGqfqrLsTDasY5as4F+v mVJWWyCbPmKM2ekfNggb46w9E4GvZaEndYySFE+qSg2Hi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5qmq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJHoUYKMG4aU0Oj9f/ +I+LwACTVeohf3jldpXSsE07igiBO/CGdpG/11Fk3TeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LmIe8Q3MzUY0yzG7IAhZ+b7hKtfKPPeNQt1YhB2wr WPa5WXpRBodMbRzzBLarCzw3rORxUsXXqoINeWm+fla2Ga1z1QpCREqUUWi5sCA3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6bCXIDVSVpc8E9uYk9QjlC/ k+EmZblCCJitJWRSGmB7fGEoDWqIy8XIGQeIygeQmM4D8LLpYgyilfDS4hlGavs19ntQ2ivm naNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:jxPFIKNAp5yaj8BcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+76wOHHimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4KcuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76640460" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=epSsEYsNYfat0NkMoYEbX0BJggvdcxyyrvRyd4U3CO5sEe8NFvsuSSxiQhFQ+K43WcPluIPoup8yVnJscRkS/2vhJvrQ/EbutOOQpgLyM+8FiEMuEh+rpqmq37BFhADknravkfPpl/bvwsMa5YFyYmok4+mLF4SyUaF/bluEPdt5OtImBEp3D5Xq/Ru3wtaqoBsa3psRKdxgKonDhzhu73qAjHElmdt0h39mnotnJ1t0fWGpunfEK3Wg70rFGa9AZEIbTQh5yk/zKlYt+AiCxnVZYng5jUdVsMzkTeqb4XtZlXg2KWyKG9G8P4W5hWXEEe/Xtt/XY89+cBZFv7eQ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Nth+WSRqmnNZNtt/75bzbUKnlGqNX8w23rCVYKIJuKo=; b=JCotkaGe6FUkkZ4ZWawMUHHo68doySPqKskyHDMm69iTTF1SQk7kxOIZBGC72QZZDKBd1ZGDNm5uzIVivCLTdURhkSebkAxza9BchbwxfSTJAbO+qMo3YZZ6xTxCrigfrs0gWqrmVwdA/afsqoNWcfa/on+XoJc14g8iw8i8VAB9CFuais3EJoWzZR547knNDYfmE6q9aTw/pA9pYnMwde50S4bhp29AuY9Xw8gblTHbA/zOtciIVmG6lJ+aivtgB7bII+x52ZY7SIL0YnvYMGrZ1RcECl/ytoLvHiO7GwApud/niKi+iwdJn/kwrc/f5xqJjiDr/WHYAsQOgTf8Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Nth+WSRqmnNZNtt/75bzbUKnlGqNX8w23rCVYKIJuKo=; b=Fe4Yplo5+f0DBAJ6A4hcEUAC3VW21VxVDa9Nd18wY/Ipdg6iVy3Eesnv+TtKb1POEGaJP7PbvB64AIDuwhMNULGLkiwPHrh+VhQOuI9foj/Skv3jcRjtF8F6cG5t/E8haxJfru7p8Oa+lt30p0PsNFIAQpfywg63lhpXPBhXqDQ= From: Andrew Cooper To: Jan Beulich CC: Roger Pau Monne , Wei Liu , Juergen Gross , Xen-devel Subject: Re: [PATCH] x86/pv: Inject #GP for implicit grant unmaps Thread-Topic: [PATCH] x86/pv: Inject #GP for implicit grant unmaps Thread-Index: AQHYoE8VWDFxrfk+kEi+iIsPWlNsBq2QMZQAgABZ5AA= Date: Tue, 26 Jul 2022 11:51:30 +0000 Message-ID: References: <20220725175013.893-1-andrew.cooper3@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6d4f2c0-65bf-4383-c281-08da6efd2e5a x-ms-traffictypediagnostic: MN2PR03MB5008:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zGpxmL7sBUh+0l6CyT+92tKdqAs5Fp8Fav0xupx1nog/S+eV8e7LO2cCgVFKwqVxplKgQrMf5s/Il+E4WfH6kiRDpMprvI/U08J6vqqm60LWK+DvVJIwyHiKnjwRSPSS/JWAEqf+mKsOnIbzEQiv/o6bAumU1KcP9T385QQvuYyFJJK+WzXnjowqC8q2kDPASZt4HJ5/C0iqP5/xBXkONwu9gONJM0BIrJ8dXgwpNj1+Euyt+rAfab4wlvmi2Cm3U3GCgpAbcWewBf7KkxjEAVgXa+jmLngSSYORMNf/Jvtgi4RJWt2QsmzR2Wj7swIbFRUXNfax+fnroYlHCCPHMbdNztGMb8zGVHP8gChMhYBKC1JGsuCbm5DQsaD8xIRDTgezJGFzSruAKvmh421nARG+K49D5qY+gKgfpRndpOdDnvEmtji1sFQzd/YG8Z6kL/9IyU/L/Kl139J0WqhGtgMEAdKCs2+56jxXrKM7k/0L50IALUwP3fn5cX88eWGir9OqwhagP0JGuDRARHODh3paUJ6MK1MgFpWCxSXDNrjdGHE/zuZXaOgk4ZYjCgGIF5nLOKBC+2rOBse3PuruFgKjYyX4OSvnFE6eyAuu5r2bD27pxqNCrovwdJWOo0mZz0TqMjOlhhYLJEbg5tyQNzf2BTBdnaeKlGn8+e85Ow6+jNTXUEPxiPv1ykzcq+hf7hXEKd1N9cvFU9qagmJLdEhXIDdbNUa7I4aNHGuiQEyj5fwYSEzr0czWbY0t0fupQIQlhcpD3Lo+vGN0q6IeqVxSyUn50qeu85qkibMCwquVqBcNpGZTD+VoUoHPt3Uwxef9jm9AMLp63SIZeXReMvGxfFgycZh0KiT7NivUmvg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(136003)(366004)(39860400002)(71200400001)(66946007)(122000001)(76116006)(6916009)(54906003)(6486002)(316002)(478600001)(66446008)(5660300002)(66556008)(91956017)(66476007)(31686004)(8936002)(4326008)(64756008)(8676002)(36756003)(6512007)(2616005)(6506007)(41300700001)(26005)(53546011)(2906002)(186003)(38100700002)(82960400001)(83380400001)(31696002)(86362001)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?RjJjNFI1ZmtNSjRETEdyV25wd3JHWlBUMTE3Z2ZtVEs5NjB6ZUxSeG9HQTd6?= =?utf-8?B?enZhdms1Ukhzc25id1NYVC9jME9PKzIxekVqMUtmYmpWSVlXNFA2OHNwS1Ew?= =?utf-8?B?THhIeFN5d1JCMnhCOEhSRzdMQ0wxU0xPUVRueHVaQmcyaXloUklyZ2k3Zkd2?= =?utf-8?B?M1FXTjgwbVBIaDA3ckpLNElTRWpGRExaT29vdHc5ZUhkSEhKRDdaNmtuSGVR?= =?utf-8?B?ZXNoOHBRbENneklScmxOQ2JXUVlueXlSTXdRWG5kWWhRMCtjQTlJNmRhamov?= =?utf-8?B?dU14cmFWTXFjNkhQcXg1ZU5ZbU1pUm5vQjJTeTliL1orOEhOVFZkelQwTTV1?= =?utf-8?B?bGd5TW12b2gxcXJqMDRKS3pZanlTV2lFQkxmSXd3bHJVN1FRVVV5akpXUm44?= =?utf-8?B?SUVWVnFNMDRoaXVtempHOUVYVHVsSUdUVStJaXliTSs2OFFGMDE3VE1pU0E0?= =?utf-8?B?SUhiVTgxV3lVOGlwTDFkZnFpTXdkYWh6ei81UHdobjZsUENCcDZubGlUc3RW?= =?utf-8?B?Qi9ZZTVNc1BhTXZUNUhHMnFtSUxqbnBCandvTmlKMUR5WlhhSW80ejJhUEFr?= =?utf-8?B?MkNlQnpxQlBoT25VWGlRcFhMWGE4Q1ozWVBSSXR5MWZJTk9rcUxNeUhKZGhy?= =?utf-8?B?M0hDUzRxb2ExY0ppU1QxbjVrbHdPN2JoOUZjTlJmVHEyV0s1dFN5RVFHTVhX?= =?utf-8?B?cFQvWWJtenF0eVE2ZnlXajg3OGVlTDB3TzVIS3pmd1M0V0hvNmJQU2xmNDdS?= =?utf-8?B?REpxalF2WFgycU1YeXpIdFZOU3RJK1lJK1duTkN0L29aVEtXVktjemprcWFk?= =?utf-8?B?VXJrYWdMNzh3SThSSVpYd2RUSHNNa3FvejVkOE16bkk1Mis5aEtpT2JPTGw0?= =?utf-8?B?VktmMUJFSFJnM3VnWE90bnJaVk5CUnBnRi9RM1AxMk1UTHFtVGgzSzdOVGpW?= =?utf-8?B?d2ZGMUI3QmMvT1JpUjU4eHgwcHZFMGx4aklORkYyMXNDZ05JUXhGU1JpM2Ux?= =?utf-8?B?OGorYTdhellhK09reWFyOGwrQmtndFpmaW9LNkFSY2hvWjlwYloxOFp2aTdO?= =?utf-8?B?bUdWdmUwZFB0blVjcFFPVEF1QkZDTitxaHpiUnB5cVRuK05hVWZ3RnIvWDk5?= =?utf-8?B?UlZIZTlRQlhZb1o2MllGY3JEVU9VMVJxVlB1Wm5qbUtQSWJVSGVHV0JTcXBM?= =?utf-8?B?SHJiVUlmNG1tVmR3SHVlTm5vRmEyRHQyRGpoMHpqcVB5d3ROZ2lRd25lWnhk?= =?utf-8?B?eDFxa3dab3ZUMjl5YnZBTHp1Y2ViRXg5d0VrMFNJTkdDNlp6aUkwaitOZk41?= =?utf-8?B?aDU3OFA1ejZ2UCttaHJ3aTg2MkVxdHdxMWpBeGFQMjlMVm1hbWNxZ1J2UDJQ?= =?utf-8?B?RmYyTjVuWG00M2dZYXJDbFVxN1JjK3NTaFB4TDFFcnk5bS9VbzBjcDRFRXoy?= =?utf-8?B?R3c2K0pNOXpxbW9DNU44N2czOWcvUjBqRE9iVHczbEkrSFJjLzRGK1h0WmF5?= =?utf-8?B?SWU2RVRoSmdZSmhhK0wyN2VQbFVpTjZmY1Y4cVpKM3hTTTgvTGRTZk1UcWNH?= =?utf-8?B?VjRhMFlVUzNHeE40TU5PeEpxbWF5MU1kVXRxZEZrZ29EaGRENDF1Q20rUG9B?= =?utf-8?B?VE1iUThEL1VCRHg1M3VESEZaSlJmMFloQ0RyVFNRZVp0c0tIQVY4N0lGd0lW?= =?utf-8?B?M1V2NWI4MUVGV2dEVC81L3V2RkpXZGJ6SWV5SXZWQklJWWlaeTVDVTNFZ0d4?= =?utf-8?B?RTRqdnhrYlNYSWZlM2lNaFBhalo0bnRLWCttRERSWVlSMDF3WjZ0ZmprT0x1?= =?utf-8?B?dFUzbHkvdzlES080UWJKY21XRVNHd1V4U2NpcVI1bitRSlJpQk5SbHBYUTJm?= =?utf-8?B?blVDYldXSHhkTTRsd2RTR1B1ZHRCUHVYWEpwcGozeW42T3Bmak5LenFHb0RJ?= =?utf-8?B?andrU0JOMlBHRTQwMkRtMklGQjFkMkUxY0RjVTUvYzdIUWlTR1hGZEtaZG9J?= =?utf-8?B?UGVMdHpTRllMMkNiQTRRVmZwRW1NalRLNkhDVEdUZnFlYUwvS0o5K1RTRStM?= =?utf-8?B?aEpXV3VVRy9KOUZwemRIU1pWYTNZQmZiWlNlL2ZZdmdPeGhLTGlxZ2g4eU54?= =?utf-8?Q?2sSshN+MAzBXeGN0C0z6OqE3/?= Content-Type: text/plain; charset="utf-8" Content-ID: <0DC6AA56A17CC54883F141C96C902D7E@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6d4f2c0-65bf-4383-c281-08da6efd2e5a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 11:51:30.9671 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: IQ7XaAHBwIA7JO43PsgYC/xvhwUvfamLOgiUufThIaVnxSxWtULSAFEsXB+i8/Vk3HuLmg2eUjD/LopEhMVf1WkbaGP1HuJgIQo6dc7vpDw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5008 T24gMjYvMDcvMjAyMiAwNzoyOSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI1LjA3LjIwMjIg MTk6NTAsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBUaGlzIGlzIGEgZGVidWcgYmVoYXZpb3Vy IHRvIGlkZW50aWZ5IGJ1Z2d5IGtlcm5lbHMuICBDcmFzaGluZyB0aGUgZG9tYWluIGlzDQo+PiB0 aGUgbW9zdCB1bmhlbHBmdWwgdGhpbmcgdG8gZG8sIGJlY2F1c2UgaXQgZGlzY2FyZHMgdGhlIHJl bGV2YW50IGNvbnRleHQuDQo+Pg0KPj4gSW5zdGVhZCwgaW5qZWN0ICNHUFswXSBsaWtlIG90aGVy IHBlcm1pc3Npb24gZXJyb3JzIGluIHg4Ni4gIEluIHBhcnRpY3VsYXIsDQo+PiB0aGlzIGxldHMg dGhlIGtlcm5lbCBwcm92aWRlIGEgYmFja3RyYWNlIHRoYXQncyBhY3R1YWxseSBoZWxwZnVsIHRv IGENCj4+IGRldmVsb3BlciB0cnlpbmcgdG8gZmlndXJlIG91dCB3aGF0J3MgZ29pbmcgd3Jvbmcu DQo+Pg0KPj4gQXMgYSBidWdmaXgsIHRoaXMgYWx3YXlzIGluamVjdHMgI0dQWzBdIHRvIGN1cnJl bnQsIG5vdCBsMWVfb3duZXIuICBJdCBpcyBub3QNCj4+IGwxZV9vd25lcidzIGZhdWx0IGlmIGRv bTAgdXNpbmcgc3VwZXJwb3dlcnMgdHJpZ2dlcnMgYW4gaW1wbGljaXQgdW5tYXAuDQo+Pg0KPj4g U2lnbmVkLW9mZi1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNvbT4N Cj4gQWNrZWQtYnk6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCj4NCj4gQWxiZWl0 IHByZWZlcmFibHkgd2l0aCAuLi4NCj4NCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9tbS5jDQo+PiAr KysgYi94ZW4vYXJjaC94ODYvbW0uYw0KPj4gQEAgLTEyMzIsNyArMTIzMiw3IEBAIHZvaWQgcHV0 X3BhZ2VfZnJvbV9sMWUobDFfcGdlbnRyeV90IGwxZSwgc3RydWN0IGRvbWFpbiAqbDFlX293bmVy KQ0KPj4gICAgICAgICAgZ2RwcmludGsoWEVOTE9HX1dBUk5JTkcsDQo+PiAgICAgICAgICAgICAg ICAgICAiQXR0ZW1wdCB0byBpbXBsaWNpdGx5IHVubWFwIGEgZ3JhbnRlZCBQVEUgJSIgUFJJcHRl ICJcbiIsDQo+PiAgICAgICAgICAgICAgICAgICBsMWVfZ2V0X2ludHB0ZShsMWUpKTsNCj4+IC0g ICAgICAgIGRvbWFpbl9jcmFzaChsMWVfb3duZXIpOw0KPj4gKyAgICAgICAgcHZfaW5qZWN0X2h3 X2V4Y2VwdGlvbihUUkFQX2dwX2ZhdWx0LCAwKTsNCj4+ICAgICAgfQ0KPj4gICNlbmRpZg0KPiAu Li4gdGhlIGdkcHJpbnRrKCkgYWRqdXN0ZWQgdG8gYWxzbyBsb2cgbDFlX293bmVyLg0KDQpPaywg aG93IGFib3V0IHRoaXMgaW5jcmVtZW50YWw/DQoNCmRpZmYgLS1naXQgYS94ZW4vYXJjaC94ODYv bW0uYyBiL3hlbi9hcmNoL3g4Ni9tbS5jDQppbmRleCBiMzM5MzM4NWZmYjYuLjc0MDU0ZmI1ZjRl ZSAxMDA2NDQNCi0tLSBhL3hlbi9hcmNoL3g4Ni9tbS5jDQorKysgYi94ZW4vYXJjaC94ODYvbW0u Yw0KQEAgLTEyMjksOSArMTIyOSw5IEBAIHZvaWQgcHV0X3BhZ2VfZnJvbV9sMWUobDFfcGdlbnRy eV90IGwxZSwgc3RydWN0DQpkb21haW4gKmwxZV9vd25lcikNCsKgwqDCoMKgIGlmICggKGwxZV9n ZXRfZmxhZ3MobDFlKSAmIF9QQUdFX0dOVFRBQikgJiYNCsKgwqDCoMKgwqDCoMKgwqDCoCAhbDFl X293bmVyLT5pc19zaHV0dGluZ19kb3duICYmICFsMWVfb3duZXItPmlzX2R5aW5nICkNCsKgwqDC oMKgIHsNCi3CoMKgwqDCoMKgwqDCoCBnZHByaW50ayhYRU5MT0dfV0FSTklORywNCi3CoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAiQXR0ZW1wdCB0byBpbXBsaWNpdGx5IHVubWFwIGEg Z3JhbnRlZCBQVEUgJSIgUFJJcHRlICJcbiIsDQotwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgbDFlX2dldF9pbnRwdGUobDFlKSk7DQorwqDCoMKgwqDCoMKgwqAgZ3ByaW50ayhYRU5M T0dfV0FSTklORywNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIkF0dGVtcHQgdG8g aW1wbGljaXRseSAlcGQncyBnbnRtYXAgUFRFICUiIFBSSXB0ZSAiXG4iLA0KK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBsMWVfb3duZXIsIGwxZV9nZXRfaW50cHRlKGwxZSkpOw0KwqDC oMKgwqDCoMKgwqDCoCBwdl9pbmplY3RfaHdfZXhjZXB0aW9uKFRSQVBfZ3BfZmF1bHQsIDApOw0K wqDCoMKgwqAgfQ0KwqAjZW5kaWYNCg0KVGhlIHByaW50aygpIG5lZWRzIHRvIG5vdCBiZSBvbWl0 dGVkIGluIHJlbGVhc2UgYnVpbGRzIHdoaWNoIGhhcHBlbiB0bw0KaGF2ZSB0aGlzIGxvZ2ljIGNv bXBpbGVkIGluLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 12:04:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 12:04:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375178.607497 (Exim 4.92) (envelope-from ) id 1oGJIp-0000Bi-9n; Tue, 26 Jul 2022 12:04:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375178.607497; Tue, 26 Jul 2022 12:04:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJIp-0000Bb-6d; Tue, 26 Jul 2022 12:04:43 +0000 Received: by outflank-mailman (input) for mailman id 375178; Tue, 26 Jul 2022 12:04:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJIo-0000BV-Dr for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 12:04:42 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50084.outbound.protection.outlook.com [40.107.5.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2107afcf-0cdb-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 14:04:41 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8093.eurprd04.prod.outlook.com (2603:10a6:102:1c9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 12:04:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 12:04:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2107afcf-0cdb-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gYzJBAcFA/HTJiXov+tVZnxaEi/htdED5dU3wZpTIA7jOX7stV63DFMUFCKAHn6ZNgpIiIu4153ANKY8n5/R31rsYVOrruz5Runv0QiVyzkdkskC1ISPcWlAg1rpRB3nHSZiSW5wKCuOS8/Vtvov2KkTDFuDjSFCatsxE+MIi9Ix5fnzU8n1XSLPUiTnfyhuhCX+m10vtKGCaKCUEtvl7dGLLuMboTQGpHpAMQo9aVwznRIm6tGr2R1IK+SBaL9RZJBlfqKcUfqWrc9TUTVMOmnSf5Mx10501feN4LAYPyZls5ssVYqx47wWD9Vxa4ysZsQqh5ofWLeNs9Cmm8153Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UXh9gKNtud1ZrN19d0DgmDdiCO/IOG4r03VDESj3UDM=; b=W5Oc4+dHDDdrsdWpcUoTqOgRy9+cnxxi6kO0Gzn23NKIcmz/ZDu+miR/IaMJykrDAHSlZ+RO2PKePzO03NlOOUfgjVFBN3xw3p0dpaO6kaUar/CsvuqVon2oe2N/0K93cGGfxagw2p0nXJ03bw6qtDo/r7J2AlkkSt386Dh8WxVBP9G2ghAQ4rfOFHxjsGV2f/2w8PqVzCSnbdOozsaY43OGcOLJlaidwBEYYjrsyZoG87JmpaY3EqcsJdElCXLrzweyIBVxJL+Fj1hs6qi/c7c/pKR662NAvlUwug/cn2FnqvUxNur6omUwo0QQEXjppdPz/V3S1AxRzwE2QZcnxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UXh9gKNtud1ZrN19d0DgmDdiCO/IOG4r03VDESj3UDM=; b=mVLxA9k/e5eZWiehguLUO8wG9E2VYQtHmW9e1ZcGwifWC8yKJ4pA3VFo4Kslwyag99sjlE5foDxCqUQwJVx4CQZVQdhLuHUvAN2ufDzgtj1cxPW1lu8T+l7ShrUkJwA7RPDt3+vRT3DptvyJcbz3hrC4/UpL3ADfA/hwbwEnodt1T6+Inc57TUBlzoXQvIDYS2mDqgyYVNvZRs/dCU0REzcwBjiSNVfMx//NuBJaIrtY7JRW9EEygpw1XfnN26LVPnQl1yJJjmbrvvauUy8AnduvLILZGfIWkV4sTmYZDd5NIb46mwMtX5t0ZQ3bE5bwc9JsK0IPZMl/pzCmBPXISg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 14:04:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/pv: Inject #GP for implicit grant unmaps Content-Language: en-US To: Andrew Cooper Cc: Roger Pau Monne , Wei Liu , Juergen Gross , Xen-devel References: <20220725175013.893-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS9P194CA0028.EURP194.PROD.OUTLOOK.COM (2603:10a6:20b:46d::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 002e771c-bb69-44f4-7559-08da6eff0415 X-MS-TrafficTypeDiagnostic: PAXPR04MB8093:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jQEejHLaAT33LJVnHFgi18FX99hs55aDMxwTn+VmzsgQQxeNcCmsLiLGucu2brN2GvYTfETmQl1l8doRfcQYIQzTO0AicTbIYqtHS2kGvcqTnr4+DM6zk14pyZGrP1HNMso5LhkWlGYx8zYo9/8TWraZtgL1m8c/FvOaYvKEFodjY17lN9oHcy97MAA6lG1DarcuRDi/PXaLsZW2TIcskG6eX0AbvzfDdfUVnqB5yrljMQ/RjgcvxRKLX8A+G7qgLl63o/No+/E/IczqotG2NVreOoZr79tVEY32MJIDDGodsyb8qbrZmak1kgVmE4OWqQtxdnbLfI5q/J2CV9ECe7RXIi2OBLlEk/uBKJeb28s1cvKTQ7+9LQsEc2E3iKc7kuZNb/WeZMNTpr2sIJbwmv8UeanSdw/u27S/8ML2pKodk3hk3BdLz53caF0SgrvdyJU5wq7tYnU6FrX4qovmmWIIwDN00XJwTPeIH9fqVYSbHSFq18wWH07EKJuwiyQr0b5ALNZWn+zyehc+kQsv24Vefwd7uky6zK7qOseRKeGv/aNR7yAaRXtx8bl+oJKhiiqFchKLx+WrCughYWdUaEr+K/hwpvxSar+qTcnyB0k471EIoC3lSQngHsrSngtc+bTUH3nuL+FdXJbk+fcDCjgk19WA9ubq9AUVU5BS04WEQ6G7oFgOsJdT6HHLw+vSR3Y+QnnzK97CFcuIQLbXSXfPlsoRzM3i32yZ2kWA5Jg2IkTspgaGwNV7uHgaRZNm2Wu4Ledj8nn2oyEVrdrtDiI/iR/s/6SEqzABLBQwnsbP7UvRNKZ73ot6w8s/75LLU+nnLXRL814qMzHR7h1qFA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(366004)(346002)(396003)(376002)(36756003)(316002)(31686004)(2616005)(83380400001)(38100700002)(186003)(54906003)(6916009)(6506007)(8676002)(4326008)(2906002)(31696002)(66946007)(66476007)(66556008)(478600001)(26005)(8936002)(53546011)(6512007)(6486002)(5660300002)(86362001)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzloclQ1NlRFa0kvVXhwM3QweW1VcmljMkpTdlJ0VXBkbjlLOTAyZWdDemhP?= =?utf-8?B?anBOTlRzR0xkSkJKS09rdFJVa3RVQmhWVHQwL2pDK2xlRzl4ajd3TFpFWlpS?= =?utf-8?B?Ulo3QjBTbDU5RklxSVZ0T2ptZjFUczJnK3NlbnpMS0tuOGw1OU1VWm91MVJQ?= =?utf-8?B?S2FDOVZzTUxEa2NueXFMUFZmZ0M3N1FvV05aSlp0N2dhNDVqcXZ1SWJyNnRn?= =?utf-8?B?TXY2amNkRTliZ2JFWkpnMjhBRzZQbVFZazJjSk9yRkFlcUY0Uk1mbWhQcFQy?= =?utf-8?B?S1hTUmdhcnZzaGlVYjI5cjFSWjlRb3EzeFpiMXB4RVpNL1VvRml6UFlybnRD?= =?utf-8?B?VzhEQzYxMXFJYXFSdnljQkRyZHVvdnZraUh4WURXZXc0dmEyT3F6T0tFMzRn?= =?utf-8?B?enFqTitySjYrWTNYSGZWOFJtRm1FUjFkYkJuWmVES0ZjZW9Dbyt0U2pVdUkx?= =?utf-8?B?dWxvdGJkZWVXa0xwTjVzNkRCeXRhZmh4NVNkMXZ5SExicjg3SGQwUmhuelln?= =?utf-8?B?VXZQSnNhUWFJVmJqRE8rUG5qWmJJbUE0Z1Ziam9PUWdEeHNRNjQrN2dYRHgw?= =?utf-8?B?US9TenB5QWUxQkxkRWFiamhPVUpjRjAzOGRuZGVtZEtWS1BYVlpSQzhXS3BI?= =?utf-8?B?NUNvbndWYTFPeUhRQ3BwUjc5NW82MW1ycFJkbU1sYWxXZzVwamU1NGhnOG5m?= =?utf-8?B?SktqUHdhdHBzSStLMmxaekVSekxaeTlLYWUrNkpmSTl1cXRMYnBVejEzL01q?= =?utf-8?B?cFYvbzhMd0ZaVnk2cDBBMFB1N0VaZjVjUGphWXd2RUFtc0o4RGZleFh4TXlV?= =?utf-8?B?cmFha3UrRjdLSW5Kd2FTNWdjWjFGTytacDFwRVJQWGJpbEtkSUcvMUhPNzA3?= =?utf-8?B?Z3U2NjdycVlhL3lneVJkY0RlTjdXL2IrUnlpaW1ITUdMREtaV290bGRQSzhx?= =?utf-8?B?VlVDUlNlQTVZMVhhRXYxQWdVSUQ4Nmt0UmNkOEVNRzg4WU0rUFhTbHB6UzdG?= =?utf-8?B?NzVjREJhK0NVME1EMXhBSnc4RUlzMlhRZkl3UXgxSTdWeWpUOUJiTVpZWC9k?= =?utf-8?B?Y1pPa0ZVTWdHWjJlWjBwL29xRU9peUpycGFUQ3FmNWxKTDI4N0tNTVEvMytz?= =?utf-8?B?V3ZCTFlIaTdKV1prZzk4YTlQMHRUc21uVWRVVGhWemZtaGJDRlI1WjliZ2NH?= =?utf-8?B?YkI5LzMwQ0hSWTJDVW1LWjlPOFhrRjIrZHQxbE5CMUh6M1gxYjdFWGxSR1kr?= =?utf-8?B?OXJ6T0s4MTRBK3dwUXFlSC8zbG9PZHdOeDBCZFV3eTNoSE1JaFdBblZlSVRt?= =?utf-8?B?Uys0SEdhMlJpSmxrb2lNdXpKc29OdjBnS2RuTnBUS2lyb3U4cVM3TzFLSm9h?= =?utf-8?B?R0xiTEpqUlNTc2g3ZkVmQ2FEUG9WT1VEa2h6U0RFbjgxS3NHYzdTVndhbE9n?= =?utf-8?B?aFZqWUNCZkV4WjdoaXhoT25nQzFGOGdBUkxEZndkQjBIZDBGOGpYTGprNkRM?= =?utf-8?B?dmZ1NW1OZTl0QW91SWxGamNMWERRcFBid0J5TGVRbmIrZWJ2ZnpNd0p3Yzds?= =?utf-8?B?aWk3V0dQVnZUSm9RSWVxczNWWGdZbGRrNzdTdlZRN3ZBcjlNTmtRMDV6cld3?= =?utf-8?B?elFhc2hEY3d6V2p0aWFGNEtMWHEyZndOYlhMZHpsSTlkelRQU000Y0hxOEZv?= =?utf-8?B?bjZEQzBKRWFvazhMQVhTb3JzY01rZnJGOTNIeVlQaTJVYlFHU0Q1NmkxdlNT?= =?utf-8?B?ZEZVK2dMTFJWS0NFcnQyeVBGaXhLejI5NEJvWHVZWDN2NnpGNENPcVlocHJW?= =?utf-8?B?elUrU3BWRFpOWXVVbFFXZklqeXJEcnlPTXdPTlN4bEp1WlNwb0RWWXR3Y2tI?= =?utf-8?B?Ti9rRExEYUFJZ0QxcVJlejdaL2I3bUdsVlM2bmFmV0tKT0RaaEZ3eERpbHI3?= =?utf-8?B?Zk9SeXdXUmxPcnJ6MVdDQVJDSHBRSmRESWsybWpZLzZtRXN5d2ZvclcwTm45?= =?utf-8?B?bENPd0gxazkybS9rYmQ0ajRiNmo1bHByODdBM1JmZVBFbjRtNVhPNXBGYXVL?= =?utf-8?B?SXJOUTZ0MlB5U0ZtVSt3K3VhNGo0THJ2RXZFdERqbEJxWlJyVm0yeVB4MXJ6?= =?utf-8?Q?aHIGBuFbF3H4S0XBvtF0BS6R8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 002e771c-bb69-44f4-7559-08da6eff0415 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 12:04:39.2296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9JR0x8x/uIs2FPbOcxCzYmV9xuTX848CD86cBoCx09TV07TGDOpbTvNKWyFzgZA4F2q7B8B2WLtSDdxZrsbbyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8093 On 26.07.2022 13:51, Andrew Cooper wrote: > On 26/07/2022 07:29, Jan Beulich wrote: >> On 25.07.2022 19:50, Andrew Cooper wrote: >>> This is a debug behaviour to identify buggy kernels. Crashing the domain is >>> the most unhelpful thing to do, because it discards the relevant context. >>> >>> Instead, inject #GP[0] like other permission errors in x86. In particular, >>> this lets the kernel provide a backtrace that's actually helpful to a >>> developer trying to figure out what's going wrong. >>> >>> As a bugfix, this always injects #GP[0] to current, not l1e_owner. It is not >>> l1e_owner's fault if dom0 using superpowers triggers an implicit unmap. >>> >>> Signed-off-by: Andrew Cooper >> Acked-by: Jan Beulich >> >> Albeit preferably with ... >> >>> --- a/xen/arch/x86/mm.c >>> +++ b/xen/arch/x86/mm.c >>> @@ -1232,7 +1232,7 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct domain *l1e_owner) >>> gdprintk(XENLOG_WARNING, >>> "Attempt to implicitly unmap a granted PTE %" PRIpte "\n", >>> l1e_get_intpte(l1e)); >>> - domain_crash(l1e_owner); >>> + pv_inject_hw_exception(TRAP_gp_fault, 0); >>> } >>> #endif >> ... the gdprintk() adjusted to also log l1e_owner. > > Ok, how about this incremental? > > diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c > index b3393385ffb6..74054fb5f4ee 100644 > --- a/xen/arch/x86/mm.c > +++ b/xen/arch/x86/mm.c > @@ -1229,9 +1229,9 @@ void put_page_from_l1e(l1_pgentry_t l1e, struct > domain *l1e_owner) >      if ( (l1e_get_flags(l1e) & _PAGE_GNTTAB) && >           !l1e_owner->is_shutting_down && !l1e_owner->is_dying ) >      { > -        gdprintk(XENLOG_WARNING, > -                 "Attempt to implicitly unmap a granted PTE %" PRIpte "\n", > -                 l1e_get_intpte(l1e)); > +        gprintk(XENLOG_WARNING, > +                "Attempt to implicitly %pd's gntmap PTE %" PRIpte "\n", > +                l1e_owner, l1e_get_intpte(l1e)); DYM to drop "unmap"? With it restored (or anything similar to that effect), fine with me. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 12:25:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 12:25:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375185.607508 (Exim 4.92) (envelope-from ) id 1oGJdD-0002oA-WC; Tue, 26 Jul 2022 12:25:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375185.607508; Tue, 26 Jul 2022 12:25:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJdD-0002o3-T5; Tue, 26 Jul 2022 12:25:47 +0000 Received: by outflank-mailman (input) for mailman id 375185; Tue, 26 Jul 2022 12:25:46 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJdC-0002nx-Os for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 12:25:46 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1144932d-0cde-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 14:25:45 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1144932d-0cde-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658838345; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=JAcIuNG8+PUHD1HCk4H7xnYNap+DfbC0IKbljashmyk=; b=I4mx5yWhEHvRoDjY7Z6AIRkQw619lAv9nrOitQuQ32AZSMl+IRyU8p9H WiMaNmgs6JsxyCIUaFf7iScVKcwGr+3Iy///dG0Sjdz1KHkgKPeJ9za34 yDC1kCz2uekJQatMMCmhojD/pyUg38ONF4ZueGv5WcAfvJH4CgA23rosd A=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79209859 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:DZMJLqnfKLnhvy321fLVTMTo5gzoJkRdPkR7XQ2eYbSJt1+Wr1Gzt xJJUWCFPfyCYDT0Kt51OoXno00P6JPcxtdkTAY+r3xkFSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466v4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2k1MoRI/NZ6Rlhsy uA7EiAKSD2BxPiplefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVmPFsNBY14t+CvnnTlKBVTqU6PpLpx6G/WpOB0+Oe8aoKEKoHbLSlTth6er 1vD5D6mOw0xPcCmwmGro1uTpPCayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRqGSzRtZeI Ew84Tc1oO4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZ8hMcO7ZFsA2Zwj xnQwo2vVWcHXKCppWy19bid/TWCNG8sD1AeRhUUSi0o4Zr5v9Rm5v7QdeqPAJJZn/WsR2ygk 2jS9nNn71kApZVVjvvmpDgrlxrp/8GUFVBtu207S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBN7faVUweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPuc8MYyfzPf8oPtzZ5yEWIU/ITI+NaxwpRoAWPsgZmPGvp0mCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNJmLOAGeHr5FuZd2l39W+I8mbcqkp/hR+ebBOSX9pHZsGAfmU93VG4ve+lSIo o4BZpfbo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:CfIHgao2YQlgm7UvRu9XrMUaV5oneYIsimQD101hICG8cqSj+f xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ uIHZIQNDSJNykZsfrH X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="79209859" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/tboot: Drop mfn_in_guarded_stack() Date: Tue, 26 Jul 2022 13:25:21 +0100 Message-ID: <20220726122521.16091-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit To support CET Shadow Stacks, guard pages changed from being holes to being read-only. As such, they can be read. Moreover, they should be included in the integrity check. Fixes: 60016604739b ("x86/shstk: Rework the stack layout to support shadow stacks") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/arch/x86/tboot.c | 33 +-------------------------------- 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/xen/arch/x86/tboot.c b/xen/arch/x86/tboot.c index fe1abfdf08ff..03098450f788 100644 --- a/xen/arch/x86/tboot.c +++ b/xen/arch/x86/tboot.c @@ -242,29 +242,6 @@ static void tboot_gen_domain_integrity(const uint8_t key[TB_KEY_SIZE], memset(&ctx, 0, sizeof(ctx)); } -/* - * For stack overflow detection in debug build, a guard page is set up. - * This fn is used to detect whether a page is in the guarded pages for - * the above reason. - */ -static int mfn_in_guarded_stack(unsigned long mfn) -{ - void *p; - int i; - - for ( i = 0; i < nr_cpu_ids; i++ ) - { - if ( !stack_base[i] ) - continue; - p = (void *)((unsigned long)stack_base[i] + STACK_SIZE - - PRIMARY_STACK_SIZE - PAGE_SIZE); - if ( mfn == virt_to_mfn(p) ) - return -1; - } - - return 0; -} - static void tboot_gen_xenheap_integrity(const uint8_t key[TB_KEY_SIZE], vmac_t *mac) { @@ -288,15 +265,7 @@ static void tboot_gen_xenheap_integrity(const uint8_t key[TB_KEY_SIZE], continue; /* skip tboot and its page tables */ if ( is_page_in_use(page) && is_special_page(page) ) - { - void *pg; - - if ( mfn_in_guarded_stack(mfn) ) - continue; /* skip guard stack, see memguard_guard_stack() in mm.c */ - - pg = mfn_to_virt(mfn); - vmac_update((uint8_t *)pg, PAGE_SIZE, &ctx); - } + vmac_update(mfn_to_virt(mfn), PAGE_SIZE, &ctx); } *mac = vmac(NULL, 0, nonce, NULL, &ctx); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 12:44:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 12:44:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375194.607521 (Exim 4.92) (envelope-from ) id 1oGJvT-0005OS-I6; Tue, 26 Jul 2022 12:44:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375194.607521; Tue, 26 Jul 2022 12:44:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJvT-0005OL-FG; Tue, 26 Jul 2022 12:44:39 +0000 Received: by outflank-mailman (input) for mailman id 375194; Tue, 26 Jul 2022 12:44:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJvR-0005Md-VM for xen-devel@lists.xen.org; Tue, 26 Jul 2022 12:44:38 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3ad8bc1-0ce0-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 14:44:37 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGJv9-0006T0-TY; Tue, 26 Jul 2022 12:44:19 +0000 Received: from jbeulich by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGJv9-0001Jn-PZ; Tue, 26 Jul 2022 12:44:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3ad8bc1-0ce0-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=5zUc3GTVdkqv2U2hDzriHogHU6mxVsSzoLo34MiGpJ0=; b=AboCeRd2aTP+l7XRUXw8wY7tie npjepsApr6CcupUUck+czhQUNCDU2QU/X75jtcernPtsUC1ZodK83bXyKfcXtkMNTTTkha+tWSVkz RvYEv+DQ1Tk2LKqtQIux0F3rmr3BaVo64MXmgUdGeaW9+uscOJH2n50z653D9f6LfCA4=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 408 v2 (CVE-2022-33745) - insufficient TLB flush for x86 PV guests in shadow mode Message-Id: Date: Tue, 26 Jul 2022 12:44:19 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-33745 / XSA-408 version 2 insufficient TLB flush for x86 PV guests in shadow mode UPDATES IN VERSION 2 ==================== Added metadata Public release. ISSUE DESCRIPTION ================= For migration as well as to work around kernels unaware of L1TF (see XSA-273), PV guests may be run in shadow paging mode. To address XSA-401, code was moved inside a function in Xen. This code movement missed a variable changing meaning / value between old and new code positions. The now wrong use of the variable did lead to a wrong TLB flush condition, omitting flushes where such are necessary. IMPACT ====== The known (observed) impact would be a Denial of Service (DoS) affecting the entire host, due to running out of memory. Privilege escalation and information leaks cannot be ruled out. VULNERABLE SYSTEMS ================== All versions of Xen with the XSA-401 fixes applied are vulnerable. Only x86 PV guests can trigger this vulnerability, and only when running in shadow mode. Shadow mode would be in use when migrating guests or as a workaround for XSA-273 (L1TF). MITIGATION ========== Not running x86 PV guests will avoid the vulnerability. CREDITS ======= This issue was discovered by Charles Arnold of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa408.patch xen-unstable - Xen 4.14.x xsa408-4.13.patch Xen 4.13.x $ sha256sum xsa408* 7349445d53b68bc8e2be2aea9fa20409a9b87e0d6b78fc2515093a65668444a0 xsa408.meta f49cb67842c7576f1d59b965331956a9fa1f529a8e2da3531d7ebc4eb3f079b3 xsa408.patch 26871efbd3f834dd4af4fbab6f2cb09a83c509e49894f025ee656071419ed995 xsa408-4.13.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLfyP4MHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZSkAIAM3XDzBdUXux7ONc9nztSMGPBdWosC5f0SycveSq adplJeShw50aFYLxpZzqfCBAX/Jh0ooF+7gHnjVMuKKkg8vu5SfBpSGRdmva6jpc qNXoNyIc21PdNH4PVCKDQnO8Dq8wPSCnPpMZbFwk2uz7QGN5BKU/GM6XQrmXA3wz 3XYIcVVR377MdDuR8UQKyCSAG0JPr6SiozygRFHykGjg9NABWZwGyod64C9xBAyu K8CGTx12bAJEVcqJbGAVSEU6J5iKdWjSLHwy43ZOcAFvfiCAlolBOPlfjJTllYdQ Yhv0wQtOwsIDjQU6vbUtMsckuNEmfMPTEkRHPOpp46dPuVk= =33sr -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa408.meta" Content-Disposition: attachment; filename="xsa408.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MDgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJm ODYxNGM3MTUzZjk1ZGNkMWExMzIwMTU2Nzg3ZGJjNTMyNWZkOTQ2IiwKICAg ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTQwOC00LjEzLnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICI4N2Q5MGQ1MTFjODc0Nzc2MDljYzRiOGM4ODg2NmJmYmU5OTdk YTQ2IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQwOC5wYXRjaCIKICAgICAgICAg IF0KICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAiNC4xNSI6IHsKICAg ICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJT dGFibGVSZWYiOiAiMzViZjkxZDMwZjFhNDgwZGNmNWJmZDk5Yjc5Mzg0YjJi MjgzZGE3ZiIsCiAgICAgICAgICAiUHJlcmVxcyI6IFtdLAogICAgICAgICAg IlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MDgucGF0Y2giCiAgICAg ICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAogICAgIjQuMTYiOiB7 CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAg ICAiU3RhYmxlUmVmIjogIjBhNTM4N2EwMTE2NWI0NmM4Yzg1ZTdmN2UyZGRi ZTYwYTdmNWRiNDQiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDA4LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0 ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAg ICAgICAgICAiU3RhYmxlUmVmIjogIjM1NWNhYTllZjI5ZmQ0YmNkZjQ4YmMy NjNlNmNhM2IyNDM5MjQ5MGIiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwK ICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDA4LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0K fQ== --=separator Content-Type: application/octet-stream; name="xsa408.patch" Content-Disposition: attachment; filename="xsa408.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvbW06IGNvcnJlY3QgVExCIGZsdXNoIGNvbmRpdGlvbiBpbiBfZ2V0 X3BhZ2VfdHlwZSgpCgpXaGVuIHRoaXMgbG9naWMgd2FzIG1vdmVkLCBpdCB3 YXMgbW92ZWQgYWNyb3NzIHRoZSBwb2ludCB3aGVyZSBueCBpcwp1cGRhdGVk IHRvIGhvbGQgdGhlIG5ldyB0eXBlIGZvciB0aGUgcGFnZS4gSU9XIG9yaWdp bmFsbHkgaXQgd2FzCmVxdWl2YWxlbnQgdG8gdXNpbmcgeCAoYW5kIHBlcmhh cHMgeCB3b3VsZCBiZXR0ZXIgaGF2ZSBiZWVuIHVzZWQpLCBidXQKbm93IGl0 IGlzbid0IGFueW1vcmUuIFN3aXRjaCB0byB1c2luZyB4LCB3aGljaCB0aGVu IGJyaW5ncyB0aGluZ3MgaW4KbGluZSBhZ2FpbiB3aXRoIHRoZSBzbGlnaHRs eSBlYXJsaWVyIGNvbW1lbnQgdGhlcmUgKG5vdykgdGFsa2luZyBhYm91dAp0 cmFuc2l0aW9ucyBfZnJvbV8gd3JpdGFibGUuCgpJIGhhdmUgdG8gY29uZmVz cyB0aG91Z2ggdGhhdCBJIGNhbm5vdCBtYWtlIGEgZGlyZWN0IGNvbm5lY3Rp b24gYmV0d2Vlbgp0aGUgcmVwb3J0ZWQgb2JzZXJ2ZWQgYmVoYXZpb3Igb2Yg Z3Vlc3RzIGxlYXZpbmcgc2V2ZXJhbCBwYWdlcyBhcm91bmQKd2l0aCBwZW5k aW5nIGdlbmVyYWwgcmVmZXJlbmNlcyBhbmQgdGhlIGNoYW5nZSBoZXJlLiBS ZXBlYXRlZCB0ZXN0aW5nLApuZXZlcnRoZWxlc3MsIGNvbmZpcm1zIHRoZSBy ZXBvcnRlZCBpc3N1ZSBpcyBubyBsb25nZXIgdGhlcmUuCgpUaGlzIGlzIENW RS0yMDIyLTMzNzQ1IC8gWFNBLTQwOC4KClJlcG9ydGVkLWJ5OiBDaGFybGVz IEFybm9sZCA8Y2Fybm9sZEBzdXNlLmNvbT4KRml4ZXM6IDhjYzUwMzZiYzM4 NSAoIng4Ni9wdjogRml4IEFCQUMgY21weGNoZygpIHJhY2UgaW4gX2dldF9w YWdlX3R5cGUoKSIpClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Ci0tLQpJJ2QgYmUgaGFwcHkgdG8g dXBkYXRlIHRoZSBkZXNjcmlwdGlvbiB0byBhY3R1YWxseSBjb25uZWN0IHRo aW5ncywgYXMKbG9uZyBhcyBzb21lb25lIGNhbiBnaXZlIHNvbWUgcGxhdXNp YmxlIGV4cGxhbmF0aW9uLgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMKKysr IGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTMwMzgsNyArMzAzOCw3IEBAIHN0 YXRpYyBpbnQgX2dldF9wYWdlX3R5cGUoc3RydWN0IHBhZ2VfaW4KICAgICAg ICAgICAgIGlmICggdW5saWtlbHkoIWNwdW1hc2tfZW1wdHkobWFzaykpICYm CiAgICAgICAgICAgICAgICAgIC8qIFNoYWRvdyBtb2RlOiB0cmFjayBvbmx5 IHdyaXRhYmxlIHBhZ2VzLiAqLwogICAgICAgICAgICAgICAgICAoIXNoYWRv d19tb2RlX2VuYWJsZWQoZCkgfHwKLSAgICAgICAgICAgICAgICAgICgobngg JiBQR1RfdHlwZV9tYXNrKSA9PSBQR1Rfd3JpdGFibGVfcGFnZSkpICkKKyAg ICAgICAgICAgICAgICAgICgoeCAmIFBHVF90eXBlX21hc2spID09IFBHVF93 cml0YWJsZV9wYWdlKSkgKQogICAgICAgICAgICAgewogICAgICAgICAgICAg ICAgIHBlcmZjX2luY3IobmVlZF9mbHVzaF90bGJfZmx1c2gpOwogICAgICAg ICAgICAgICAgIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa408-4.13.patch" Content-Disposition: attachment; filename="xsa408-4.13.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvbW06IGNvcnJlY3QgVExCIGZsdXNoIGNvbmRpdGlvbiBpbiBfZ2V0 X3BhZ2VfdHlwZSgpCgpXaGVuIHRoaXMgbG9naWMgd2FzIG1vdmVkLCBpdCB3 YXMgbW92ZWQgYWNyb3NzIHRoZSBwb2ludCB3aGVyZSBueCBpcwp1cGRhdGVk IHRvIGhvbGQgdGhlIG5ldyB0eXBlIGZvciB0aGUgcGFnZS4gSU9XIG9yaWdp bmFsbHkgaXQgd2FzCmVxdWl2YWxlbnQgdG8gdXNpbmcgeCAoYW5kIHBlcmhh cHMgeCB3b3VsZCBiZXR0ZXIgaGF2ZSBiZWVuIHVzZWQpLCBidXQKbm93IGl0 IGlzbid0IGFueW1vcmUuIFN3aXRjaCB0byB1c2luZyB4LCB3aGljaCB0aGVu IGJyaW5ncyB0aGluZ3MgaW4KbGluZSBhZ2FpbiB3aXRoIHRoZSBzbGlnaHRs eSBlYXJsaWVyIGNvbW1lbnQgdGhlcmUgKG5vdykgdGFsa2luZyBhYm91dAp0 cmFuc2l0aW9ucyBfZnJvbV8gd3JpdGFibGUuCgpJIGhhdmUgdG8gY29uZmVz cyB0aG91Z2ggdGhhdCBJIGNhbm5vdCBtYWtlIGEgZGlyZWN0IGNvbm5lY3Rp b24gYmV0d2Vlbgp0aGUgcmVwb3J0ZWQgb2JzZXJ2ZWQgYmVoYXZpb3Igb2Yg Z3Vlc3RzIGxlYXZpbmcgc2V2ZXJhbCBwYWdlcyBhcm91bmQKd2l0aCBwZW5k aW5nIGdlbmVyYWwgcmVmZXJlbmNlcyBhbmQgdGhlIGNoYW5nZSBoZXJlLiBS ZXBlYXRlZCB0ZXN0aW5nLApuZXZlcnRoZWxlc3MsIGNvbmZpcm1zIHRoZSBy ZXBvcnRlZCBpc3N1ZSBpcyBubyBsb25nZXIgdGhlcmUuCgpUaGlzIGlzIENW RS0yMDIyLTMzNzQ1IC8gWFNBLTQwOC4KClJlcG9ydGVkLWJ5OiBDaGFybGVz IEFybm9sZCA8Y2Fybm9sZEBzdXNlLmNvbT4KRml4ZXM6IDhjYzUwMzZiYzM4 NSAoIng4Ni9wdjogRml4IEFCQUMgY21weGNoZygpIHJhY2UgaW4gX2dldF9w YWdlX3R5cGUoKSIpClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYv bW0uYworKysgYi94ZW4vYXJjaC94ODYvbW0uYwpAQCAtMzA4MCw3ICszMDgw LDcgQEAgc3RhdGljIGludCBfZ2V0X3BhZ2VfdHlwZShzdHJ1Y3QgcGFnZV9p bgogICAgICAgICAgICAgaWYgKCB1bmxpa2VseSghY3B1bWFza19lbXB0eSht YXNrKSkgJiYKICAgICAgICAgICAgICAgICAgLyogU2hhZG93IG1vZGU6IHRy YWNrIG9ubHkgd3JpdGFibGUgcGFnZXMuICovCiAgICAgICAgICAgICAgICAg ICghc2hhZG93X21vZGVfZW5hYmxlZChkKSB8fAotICAgICAgICAgICAgICAg ICAgKChueCAmIFBHVF90eXBlX21hc2spID09IFBHVF93cml0YWJsZV9wYWdl KSkgKQorICAgICAgICAgICAgICAgICAgKCh4ICYgUEdUX3R5cGVfbWFzaykg PT0gUEdUX3dyaXRhYmxlX3BhZ2UpKSApCiAgICAgICAgICAgICB7CiAgICAg ICAgICAgICAgICAgcGVyZmNfaW5jcihuZWVkX2ZsdXNoX3RsYl9mbHVzaCk7 CiAgICAgICAgICAgICAgICAgZmx1c2hfdGxiX21hc2sobWFzayk7Cg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 12:54:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 12:54:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375277.607565 (Exim 4.92) (envelope-from ) id 1oGK4g-0000ad-9K; Tue, 26 Jul 2022 12:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375277.607565; Tue, 26 Jul 2022 12:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGK4g-0000aW-5W; Tue, 26 Jul 2022 12:54:10 +0000 Received: by outflank-mailman (input) for mailman id 375277; Tue, 26 Jul 2022 12:54:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGK4f-0000aQ-0Y for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 12:54:09 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 07a63894-0ce2-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 14:54:07 +0200 (CEST) Received: from mail-bn8nam04lp2041.outbound.protection.outlook.com (HELO NAM04-BN8-obe.outbound.protection.outlook.com) ([104.47.74.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 08:54:02 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by BN8PR03MB4913.namprd03.prod.outlook.com (2603:10b6:408:df::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 12:54:01 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f%7]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 12:54:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07a63894-0ce2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658840046; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=dFaRabSKndev9DC9KfboEKdbF9TpCd7ahiXeOQrGxsk=; b=eGtNf/klR4dd/dI5i+4ofSmjAFRGtuXti1QaR4AkRf18B1dIP/apvgGP mwQ3cRJZJ8dqjjjaVFQCEkoWWbU/UY3R2U+HD8rHFG4nwWkXpy0W4mE20 hr+FsClz9/INnm4TAGzFmzGTbEhtcs0tGNPsetAJJwVvOjo7d8M4lNXcm k=; X-IronPort-RemoteIP: 104.47.74.41 X-IronPort-MID: 76641071 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AkGEYoKu2DWOwSwSvhNlrJ3A/h+fnOphVZqnMB?= =?us-ascii?q?8mfNqXej3nJ3QvKv2leTKMbkwGeOzwh8WQpuxkUZlUow8LJOHL7U+NTZM7qJ?= =?us-ascii?q?n8VHBlAg2A48ibQR3P6SI370Km1TSmZBW3y2k3ZCnoXK1cNFikj83MAtXxxo?= =?us-ascii?q?8+Y4up2pc+6+s4zPv8AG+C1OfKjAOt5z5f9fvgUpZumOr9CtYNSASi8cNTQO?= =?us-ascii?q?hJABq/qblXiaTWknx6JFtSlN6bSgbYvlBnN3YQacKHDSj9ImolLw3WqSWQyz?= =?us-ascii?q?OTbStNuO+Q578XZLFE4g8dXKo8dfDUvaXErAc2G1SGQ6y5cJj6TTKxdRPDDr?= =?us-ascii?q?7IjIx2PUCy9V5KLXWB/gaxuReT5fe4NBGpLWYSCzOLer8dRexH2wLvW9ZEJ5?= =?us-ascii?q?kjRR5GpRzKuAiwOgVLMcUMfSoK1P95i8L1q7jeuwVE1Y/YlBb2ad4MKr7Jn/?= =?us-ascii?q?8Md4DS5k6Ry1STVhPfqm2utP7UO+UZFsZJSlmeH+1ImkGAUA0ztnuKVz9xZM?= =?us-ascii?q?Sp4Mem74GlqzMQFIILHBHKxOp8tEnlDdm7hj1eXw54I2eQRkO1tTlHGcmnnL?= =?us-ascii?q?Ms5DiONzD1YK0FrcCZMbk1wdljv6Kyslgm40v0HO8NWHH+QU6xJl0BIMlDIC?= =?us-ascii?q?wvdxn0q7B3rm69sXspydwxjK1XtDM6sAEWoIIHmCPhkhKN6mlwXfEwuV02dC?= =?us-ascii?q?Bfb6OcOwp1az8AAQW8o1vDm/Ku6jM7r9MCz/rO04dMMpoOeHL5aX7BtnwCtz?= =?us-ascii?q?VFUFDDwO2uib2fm74Zn1isDiXs75Mc6TNtbknmBXkPITTVspVHlNDDzmEbn/?= =?us-ascii?q?UNOZpBo52VZN8Pz7srIWsLBUj5RVn6G/mZLtXaRNJAwUGsCdJxu2i07OhgXe?= =?us-ascii?q?M1Hu8AZzzcGtvP29n2+MaPFKAlUwWii20HhbPMpYBEsiZNEoOgRq+ar1ll5+?= =?us-ascii?q?W90fRrdGuEeLNxnM+AbqO5Hobb3mN4lsV7uC6vKGaYbOMLvHH4YBi5hqH/g7?= =?us-ascii?q?ZSJDD57X8ZyueKvZ8tdME6IbtbN2ojkFAVDpzgx5BMCT+myP8CbVGB3/f13j?= =?us-ascii?q?yKCpMSkeXERi1Agxs4vcoq1NHScI8s6mUc6VQ1bXn0DgujlNdS5FcsNSPXoI?= =?us-ascii?q?+kzWC4ovJTTm8rORCcx6/V/YlcMXX2Eg86sZGsEsvxlsOikbVKR/NOkOfRWI?= =?us-ascii?q?/eOQtGtF+0YTGVE9eBzoEZVwQtiRhrJn/X6TVsLfsrm7AVRKShk9NuDJFNwE?= =?us-ascii?q?6iG+seRbVwvnVeOEntXyamPWVuy4FcfWq4z3EhAM6OBApuAP0/iPZrw7alCV?= =?us-ascii?q?YwhIZRLR5c2Xzml74WTrqPcGVKet5VIslIM6WppQArmjm9pqa5WX0L/l/VAW?= =?us-ascii?q?8iEgT9q+geJfh3VOZ9oAgTZKsB/ILaJrFAWCP+hE3rYWPNQ3oPvUMMztKSEs?= =?us-ascii?q?nMOcuzsmZQH00lJlYzt0YPGosJ72laBls90n8RMLNOO2TBT6x0YTlXGsvzvT?= =?us-ascii?q?Jmvpkzfpn1+SKcPbXOmap/Ag5pfHflvX4C5U7tZ4fXUZ8vQIubTjUW0bjvgR?= =?us-ascii?q?V77pAOm1S71hfaZJK3XAa5YU5VNFuDbBQt7HRkQfSmaAi4Ct7b9gNiPP1yYj?= =?us-ascii?q?G23jsaad3WhEDDVPsj0qkp9Y7ko0XUa/b9YA5s+wIJuiEh9oD17AsTxJak24?= =?us-ascii?q?C9BpncbjENEyYP5CI+abFO9zyqYYDhTT0TP2r68lo9KrkOAe5VrWfkrJiTit?= =?us-ascii?q?Yu685Vn+oKVyZQoRMGYHYOybSQlLph2GdZE+oR+edai2wBWDsSkak5sBBmSo?= =?us-ascii?q?UnSmX44b/zNwE0xT3O+Cji6MOEFfGf8Z0mJIaBPDPZfCGjuaW3AEagZlaAp5?= =?us-ascii?q?fDln1HRthfNeDpOP65k326FA6ptSiSWOwpFRBEXKWWEDrYQX9qzlhN+bfFpT?= =?us-ascii?q?9Zhm6lPmJU2HKjKVWmSDCtgZ7s8jHrlxXoI9p3TQQ6e9KpMTngiTDMDLBGRm?= =?us-ascii?q?8mNjTkEc3fVYLxh46uiJARSoq6VJO86/PJ/HFYBGgmO5U0TdOM+CHDaA1WZ/?= =?us-ascii?q?jo9zDuj/JmkGpBDRMzvYC9SCX5UlXF5nvaH7aeDtyIxJ8nYay0JlqdbEKwU4?= =?us-ascii?q?MlybxEIi/778+6UxuoVyZS+zpWLMsEQpOrY0WQY1Sheb0sBr0awRZKQS2PYu?= =?us-ascii?q?qNLsot6Nojey2Tk+qE39O0qC2I+nwLYsyfSG1eAuE6Q/tWvhv3jD0Uh9+yQb?= =?us-ascii?q?LVvFfIf+ES0QKkY0Nvf0OBMUlLE2CjgLv9Qktu8vJoKKzBsZzC/KuDGEstcm?= =?us-ascii?q?S+mB50IuM43X5n+xVIgYRcfgARPt7gnN3W5aIfM37PG05B3mf/6ptaumUp/f?= =?us-ascii?q?ihvz9Zt4A3u3fr008jD6Op21gVXHeFYfHoWRjRZ9DImMYe37p0011o8PvQll?= =?us-ascii?q?UKV0wnReijaFISieqDOWrghPEWH7r1DLgsOJZq01magghtF3NTvbR5YsVums?= =?us-ascii?q?qpUTQXi6KZreq6Ew4jIkrhrvaRmuYmQOlYhveDj6mDiH5EsoULX2fnj+RxzW?= =?us-ascii?q?1eQp5uKrGggla+1q6XeitHkcazvNfPzZsMyFyPHwBt2zw3HCtqzkn+TjVcs1?= =?us-ascii?q?c/FRdOdQ1Ixpz1EuRJW0DEwxux0+jUWfJD0nMPg06BRlWKpSqsr9HeqI1eZq?= =?us-ascii?q?lsokDtH/9twoGhmofuIeVYU3aWbrxq/fMDngrkhUOt771WCc3RrVS/ESdKu2?= =?us-ascii?q?zpMLavm26jMSv/tTbjrXrsJGZnBEuQ5HTFwzAm8EhfbJOGEtG1ShIwR2DVYY?= =?us-ascii?q?Lg9RKj95iBZcf100cE+tFWjz3pVeHvv3buEMoRn8F7S6HXYySn34bcAL8Xrw?= =?us-ascii?q?C3e7XQu+v5Zc6nGVV0en8BVMrRqc73TBGCcvLSp40yJubTSX7GkdBeADo0dM?= =?us-ascii?q?4gc16tyCitCbG6OLysgdjOmg+UU81+n39KGQrGwwVtqi8LbWsOQE9EUzEVc7?= =?us-ascii?q?qU96J8o0bPse/RUTBHRb+c07cNC1DIAH+x6TomI2Vo/2dOtiK8PJdhTuspdc?= =?us-ascii?q?vwStwyIxDgDsvJEQ3mDBUlNWnUzrk9kmNcw5J5avQdHcn7Y54+u8cvHI/GcT?= =?us-ascii?q?yOcaVVaDfj0T1B8pich8nOrXtAY7FwRxxoLUw=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76641071" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AqknwbAQx3Nz1DAKkG5TZQaYNDcgKQ63lC8i3kPP1vftDQrvPjqOIKQLMwWkvmM1OIjMnM4A/K8nHRyUAu/RgfUrKpKfl2v/OwbBEW6dHSHCBkmSyNrUwbJQm1FwmX64WzuMJ8bmZRnrcoybPXkRVFEDr2br+FSs0WsAj6ueUsndh3apVBsthuHYryb8R8V+y0JoEN9uSaY5k+tUAUWQwu4qGUh9pThbOFuR/NAvbPQhM2v2+NoWSWmkiswhX4DJtXcAdl+7dof0ZRKpF4AF3xBms6d3q6xq83Gz/9JsdOsMR/LCxe9quCPpEsIqgnP2/TltC6Cy5+BZqgVuTlAxIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dFaRabSKndev9DC9KfboEKdbF9TpCd7ahiXeOQrGxsk=; b=U+Uk173QCwfYckb+DCxESdr2vUbQ1+V1Sx7/a5oYYIHwiI5kjIFrsXoE971cVGE6qeTeTgvyrwO0xk/xXIH0bKZsuwDh2gbotlj9Wbz0MngT/UG+kuu2JCpGVxlLK2roqBWS9i5ICiUkTVb5P+eoAi8ESw4DtDg0Lw4V+k8WfXu2e0P+6OEP8fqv8vFyqllRcdLQVlYGuJL4h2sWgMMxl45IYWBT2mZjTzVpm1Pguv6LaTVaumwR5tSveFKPSWeYpybcd0D4JaO+WgmcugSVe/nbBB6xVs6+j8Vl3aUL+klJSpbWGPfkFKTc9SSJp0nozbOFmRddicTXZyHttRTbHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dFaRabSKndev9DC9KfboEKdbF9TpCd7ahiXeOQrGxsk=; b=P8z6LbAMnpeA+fjbjCrZulxTXxNZ8YJlAdQZXtN1O45Rqa1UryUs9CmyTLmAKEu6E03CTP/D+E2OqHiWKCjVNc3cituqINBFpsSQhmo/S/4iWsqNNLJ27mBeinP1Xcc0u5hbWoT3cQ1dBvaa7mwJv/XeRprxFxP6Ol/Dqbq1LAU= From: Jane Malalane To: Boris Ostrovsky CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , LKML , Xen-devel Subject: Re: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYlTod5hgtPAUSGEuMopkQlGVYGq189b0AgAImowCAABm4gIAAOBkAgARvxACAAFS4gIAKvnyAgACzuoCAAQ4ygA== Date: Tue, 26 Jul 2022 12:54:00 +0000 Message-ID: <201dd409-1e84-e097-c1cd-61c4d244f106@citrix.com> References: <20220711152230.17749-1-jane.malalane@citrix.com> <272ea76d-0099-873e-b8a8-1cc43b7b1e11@oracle.com> <0b5ec408-197c-7e34-28d8-7505e1f031df@citrix.com> <01cc9e39-242a-3cbf-13b3-cb3ecccd5737@citrix.com> <3be61417-6e58-1d9f-dd3c-7de00daa8d0a@oracle.com> <41198c6c-22ad-1530-793a-e557f3c09415@oracle.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dff590c5-f979-4937-0f49-08da6f05e914 x-ms-traffictypediagnostic: BN8PR03MB4913:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uvV847nMrHM8hc8AV4QvIIHhTbDuIonn/mUGeeOnf6w5jIWhXOJKjl9HUXlHhNJBtCn7Z9cdL4yX8Eq8l1q28fiiOqXxd1gPeO7QpDz9YUbkJg6QdZlkViiEv6zLFkJFqMS0WgTxmc7jrC1p5W849GET/6d7n9HN3dVq61Zq9kHONtKrkxeoOV+O5Jg4lhbpoZUM0U/RpuTWATEPUkzub/dkxR4uSpGugQsRcdU+0qHtiHdlpalDmni54r8OBHpGvYVGgXOfxXcFXc65DU/c/kGLYIVsTPHQItPTjlxB8ElFNTQPWfyjWGcbbzYkIuGiDMSCz+QMzrgXzlxg21mfPf9MNck0rqEJAC+gRv5aA4Jqbygl82qVUNTezw+YchurdNAdzjo2rAisQvf0dt9os17P7vkmpOriqqy/EQbP6GCxI/G2K9e5/Q4GjTpSrqj6Hiu/Nk/Mg5I/BW2uXKNfE58WZwbcDP03qOy+tsnVi5HuInA1vS/ITxWkH0prfY8jYJ4rfX3vq4H+OQR8v95owkCniPGdPD2obznolosxwHxX0LP4xghXdlmBJC4ss0hnLiobkbs/ev7h0GXeUy/m0qBQ+J05iiyrvHLhuD5VVMBU2lQv9chfUOAoQbjrm2UeRGE2T2+G9icyTY1RRSA/44tngUMtFqOQigwmV5L3KQy41Kj96NFLuQkzfV3TEBnGYtPRYCsYg5LtyWA9dVOROR1TKL8DfMYvZE/IkTsvckbBy9RzzVSoXM6rbfTA0Kl0pJh9O+Wn9BofIMR++5pdzK5Ww3EhXYydhkiqbw2hhZ2zwKPXrTYoYKGZgGMiNICHAGcUme7hrPOUtchi60y9aw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(346002)(136003)(39860400002)(376002)(6486002)(4326008)(31696002)(8676002)(36756003)(478600001)(71200400001)(38100700002)(86362001)(122000001)(31686004)(5660300002)(54906003)(2616005)(66446008)(66476007)(91956017)(66556008)(8936002)(76116006)(64756008)(83380400001)(66946007)(7416002)(186003)(55236004)(38070700005)(82960400001)(41300700001)(26005)(6512007)(53546011)(316002)(6506007)(6916009)(2906002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZVU1SUNScmd0UW90eGl5YVlyVlR0M0JMNGRFMzM0ZTVXMmlITWdHWGZFKzYy?= =?utf-8?B?QURJY2wvTEUvTWFiSW0wN3ErMzVxWlYwWXhsVkpVK1pVZDlMbUd4UFBkL2Nv?= =?utf-8?B?NDlpcWtWM3lTUmwwSk92YVB1Y0ZEbzFCY25FbHE2Tzk1Tk5kYU9EbExraFcy?= =?utf-8?B?ZXRFdWZVY2hpTVpMZEc5WmU2VXo0ZS82WjJPQW82WFNET3BSalkyZXpSMEQv?= =?utf-8?B?a1VvaWJFeU9HRGhGeGY4eCs1RzkxclJDekpVSTJlMDJ4ZGFIZjNkaHVIM0Vm?= =?utf-8?B?ZlZ6cm9vNzh5bTRWaXE0V2NEbUhSL0p6TzhneGtvZUN4U1QyQmRSbEU4Zjgv?= =?utf-8?B?U3dsWWNEU3hCOFIyZlYzb1dGV1cxeWpZVlBLeFZiVWk1QzlpK0xRYlhrb1pU?= =?utf-8?B?dDdWZDZZUDRlMjJLd2FwZlJCUjRwR3ozNVRaQ2M5ZUFSV2x5OUZrSFlDdWRv?= =?utf-8?B?VmtpK1lrdmZpZHlJamJod1dkUFNpMUtHNUZiR3pnM1NnbnBoSGM1RHhZVGhZ?= =?utf-8?B?S3h5eEZBblNPbzVmQUJWamUvc3FxZjRiRkZMZGs4blpTdmMrK0ZKZkcwZlVP?= =?utf-8?B?YzVUcmE1eVMyOHErVjdRWnlXdzQ1K1F1WDhHL2ltNmxpVFMvS2JISUhJbm4z?= =?utf-8?B?MWVaa2FuNzg0TnBBa1QvYTZ1azlHTStXZG1MeVd3THNOMkF3QUlMVm1aVzRM?= =?utf-8?B?dERHWlUwZ05XUDlnOUVReFJENkh0MmFZRGRTd1JPU0h6L2FNc1kzTTRITTRj?= =?utf-8?B?aUFLQmFXdGN1M2RQRWU3aXdsSjd2WXNlK0duQ1pCUTJ5OUY2YUMzOHJIdWdo?= =?utf-8?B?TWRIcHdJY2FwYVVLNDd6MHkyRmRRZ3pzMVB3WVd5ZTZMV0JXVUdZZ216Y0VS?= =?utf-8?B?b2hndVhwUGN0Y1QvNlpPRjR5RXRyTEhUc1VlT2VvUWlVRTN0UWl1aWJBbHhk?= =?utf-8?B?andiTG9QQkZFTDJQK3ROWmovQTBXQWlnRGdYOERRSk5IaGpqOXloRFhUaVc3?= =?utf-8?B?bVdVSUN6V1BWSmxCQncveUdiL3YrMUsvRG9UUWlkY0hLMkY5cFNTZExTczVG?= =?utf-8?B?WjZ6VmEwc2I2bWw3Q3JxMlk5dFRTekNyT1Q2bXh1YS9NQXJ5Q1l4b3NIT3Zu?= =?utf-8?B?QWM4ZnlzdlRXTFFZSWw1UHJKeDdTdm9XTStOVmNMTnBwY0QwU1Q4SE1JUTY5?= =?utf-8?B?cEtKbW5yd1JZdk5KNzY3L0dwdExUU1BZNG81cW9pOWxUUVJVNlpQZlJxWGJy?= =?utf-8?B?aUY0dFdGQkRxdUxvTDBoMlpYVGZ3TUFWa0ZKOVV2VDFQdzdZblVJclRTbFhH?= =?utf-8?B?WFNvczVhQXFSQmdremtGbFMxZCt4bEtzMGkzbUJoYVpXeW9xTk1RNTFHL2V4?= =?utf-8?B?a2MyNERwUzRMeVNDb2doTnNkSzdFdE8zbU1UN2o4RFRuMlgxVDU2Q1ZCNHpm?= =?utf-8?B?UmZYdmJ2bWNsL2tLS0VNbkwyZ2Z3b0tuN0RYazJaTUVtSXZsNGdTOTB1dnlO?= =?utf-8?B?ZFBqMXVBZGRTYlNhNXhFNUxMKzJtS1hqcUJtNnlJSGVyNGJwL2JzZzZickNa?= =?utf-8?B?aWg3ZTF5cUNEYVY1VmV1Y21vN1lWR2tBWUZsQWZOZFoyUE80S0FjcWRJVC9y?= =?utf-8?B?UXZxSlBEa29ralU0L2NBdlY3VmNGNGZKcVhyTjhsNUluMXdxUjduaEJTdVFG?= =?utf-8?B?akF3WU51cVd5Vm5XRkNIempYaXNEZndXa1ZIeC8zam9mY2gzYkJlMFRXajVl?= =?utf-8?B?MWtKVmlhTEpjM1djQkdhVlp3RVB5SDdqaG9BbW9jOStHWVE2b2dDdmdLVmJJ?= =?utf-8?B?dHZpeVJUM3VQai9ORWN1R0kvanc3aWUrVWR5c1ExTlhxWTExbkE4RW55REVr?= =?utf-8?B?cUYvMmdpaWt2dnlRdDRFOHh4UEwxcmpVNHhqc00zRklVbnlHVUtlQjJSWHdp?= =?utf-8?B?RHYvT3dUeXE5MU1HdWNTSVRGaVVVSmxLWklzNzY4OXBQZVRZM2xHODVkWER6?= =?utf-8?B?OHdibFJQQjZ5REVsT3RBUmlLUVFnenQ5MU82TnUvRXBKbUgrcTM1OVFIVFVT?= =?utf-8?B?SkZEblRPU1NkVVMvMC9RQVFPWlgwRXNSVGhLVko2b0wrOGJ0MlByWVV4ZDI4?= =?utf-8?B?dTZBbThBNit4bHdQcW1TVmVpU3Vtem4wUmxkdkR1dFhmdGloS2oxQmxxMkVu?= =?utf-8?B?YXc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <863A8E8A6D5F4E47A52325C15EDD3AB4@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dff590c5-f979-4937-0f49-08da6f05e914 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 12:54:00.1959 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YBDA7k5i1CwaEvNVKnz7UItS3X4fQ4PReio4KUYIkT2rmNhslFw/tvBJfzOsHDcGGvJFFNs4LIiEIQQu009IdSboIwnw2LQmOYm/eoLTgCc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR03MB4913 T24gMjUvMDcvMjAyMiAyMTo0NiwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPiANCj4gT24gNy8y NS8yMiA2OjAzIEFNLCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4gT24gMTgvMDcvMjAyMiAxNDo1 OSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPj4+IE9uIDcvMTgvMjIgNDo1NiBBTSwgQW5kcmV3 IENvb3BlciB3cm90ZToNCj4+Pj4gT24gMTUvMDcvMjAyMiAxNDoxMCwgQm9yaXMgT3N0cm92c2t5 IHdyb3RlOg0KPj4+Pj4gT24gNy8xNS8yMiA1OjUwIEFNLCBBbmRyZXcgQ29vcGVyIHdyb3RlOg0K Pj4+Pj4+IE9uIDE1LzA3LzIwMjIgMDk6MTgsIEphbmUgTWFsYWxhbmUgd3JvdGU6DQo+Pj4+Pj4+ IE9uIDE0LzA3LzIwMjIgMDA6MjcsIEJvcmlzIE9zdHJvdnNreSB3cm90ZToNCj4+Pj4+Pj4+PiDC oMKgwqDCoMKgwqDCoMKgIHhlbl9odm1fc21wX2luaXQoKTsNCj4+Pj4+Pj4+PiDCoMKgwqDCoMKg wqDCoMKgIFdBUk5fT04oeGVuX2NwdWhwX3NldHVwKHhlbl9jcHVfdXBfcHJlcGFyZV9odm0sDQo+ Pj4+Pj4+Pj4geGVuX2NwdV9kZWFkX2h2bSkpOw0KPj4+Pj4+Pj4+IGRpZmYgLS1naXQgYS9hcmNo L3g4Ni94ZW4vc3VzcGVuZF9odm0uYyANCj4+Pj4+Pj4+PiBiL2FyY2gveDg2L3hlbi9zdXNwZW5k X2h2bS5jDQo+Pj4+Pj4+Pj4gaW5kZXggOWQ1NDhiMGM3NzJmLi5iZTY2ZTAyN2VmMjggMTAwNjQ0 DQo+Pj4+Pj4+Pj4gLS0tIGEvYXJjaC94ODYveGVuL3N1c3BlbmRfaHZtLmMNCj4+Pj4+Pj4+PiAr KysgYi9hcmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYw0KPj4+Pj4+Pj4+IEBAIC01LDYgKzUsNyBA QA0KPj4+Pj4+Pj4+IMKgwqDCoMKgICNpbmNsdWRlIDx4ZW4vaHZtLmg+DQo+Pj4+Pj4+Pj4gwqDC oMKgwqAgI2luY2x1ZGUgPHhlbi9mZWF0dXJlcy5oPg0KPj4+Pj4+Pj4+IMKgwqDCoMKgICNpbmNs dWRlIDx4ZW4vaW50ZXJmYWNlL2ZlYXR1cmVzLmg+DQo+Pj4+Pj4+Pj4gKyNpbmNsdWRlIDx4ZW4v ZXZlbnRzLmg+DQo+Pj4+Pj4+Pj4gwqDCoMKgwqAgI2luY2x1ZGUgInhlbi1vcHMuaCINCj4+Pj4+ Pj4+PiBAQCAtMTQsNiArMTUsMjMgQEAgdm9pZCB4ZW5faHZtX3Bvc3Rfc3VzcGVuZChpbnQgDQo+ Pj4+Pj4+Pj4gc3VzcGVuZF9jYW5jZWxsZWQpDQo+Pj4+Pj4+Pj4gwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHhlbl9odm1faW5pdF9zaGFyZWRfaW5mbygpOw0KPj4+Pj4+Pj4+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoCB4ZW5fdmNwdV9yZXN0b3JlKCk7DQo+Pj4+Pj4+Pj4gwqDCoMKgwqDCoMKg wqDCoCB9DQo+Pj4+Pj4+Pj4gLcKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+ Pj4+Pj4+Pj4gK8KgwqDCoCBpZiAoeGVuX2Fja191cGNhbGwpIHsNCj4+Pj4+Pj4+PiArwqDCoMKg wqDCoMKgwqAgdW5zaWduZWQgaW50IGNwdTsNCj4+Pj4+Pj4+PiArDQo+Pj4+Pj4+Pj4gK8KgwqDC oMKgwqDCoMKgIGZvcl9lYWNoX29ubGluZV9jcHUoY3B1KSB7DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKg wqDCoMKgwqDCoMKgwqAgeGVuX2h2bV9ldnRjaG5fdXBjYWxsX3ZlY3Rvcl90IG9wID0gew0KPj4+ Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAudmVjdG9yID0g SFlQRVJWSVNPUl9DQUxMQkFDS19WRUNUT1IsDQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIC52Y3B1ID0gcGVyX2NwdSh4ZW5fdmNwdV9pZCwgY3B1KSwN Cj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB9Ow0KPj4+Pj4+Pj4+ICsNCj4+Pj4+ Pj4+PiArDQo+Pj4+Pj4+Pj4gQlVHX09OKEhZUEVSVklTT1JfaHZtX29wKEhWTU9QX3NldF9ldnRj aG5fdXBjYWxsX3ZlY3RvciwNCj4+Pj4+Pj4+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgICZvcCkpOw0KPj4+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIC8qIFRyaWNrIHRvb2xzdGFjayB0byB0aGluayB3ZSBhcmUgZW5saWdodGVuZWQuICov DQo+Pj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKCFjcHUpDQo+Pj4+Pj4+Pj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdfT04oeGVuX3NldF9jYWxsYmFja192 aWEoMSkpOw0KPj4+Pj4+Pj4gV2hhdCBhcmUgeW91IHRyeWluZyB0byBtYWtlIHRoZSB0b29sc3Rh Y2sgYXdhcmUgb2Y/IFRoYXQgd2UgaGF2ZSANCj4+Pj4+Pj4+ICphKg0KPj4+Pj4+Pj4gY2FsbGJh Y2sgKGVpdGhlciBnbG9iYWwgb3IgcGVyY3B1KT8NCj4+Pj4+Pj4gWWVzLCBzcGVjaWZpY2FsbHkg Zm9yIHRoZSBjaGVjayBpbiANCj4+Pj4+Pj4gbGlieGxfX2RvbWFpbl9wdmNvbnRyb2xfYXZhaWxh YmxlLg0KPj4+Pj4+IEFuZCBvdGhlcnMuDQo+Pj4+Pj4NCj4+Pj4+PiBUaGlzIGlzIGFsbCBhIGdp YW50IGJvZGdlLCBidXQgYmFzaWNhbGx5IGEgbG90IG9mIHRvb2xpbmcgdXNlcyB0aGUNCj4+Pj4+ PiBub24temVyby1uZXNzIG9mIHRoZSBDQUxMQkFDS19WSUEgcGFyYW0gdG8gZGV0ZXJtaW5lIHdo ZXRoZXIgdGhlIA0KPj4+Pj4+IFZNIGhhcw0KPj4+Pj4+IFhlbi1hd2FyZSBkcml2ZXJzIGxvYWRl ZCBvciBub3QuDQo+Pj4+Pj4NCj4+Pj4+PiBUaGUgdmFsdWUgMSBpcyBhIENBTExCQUNLX1ZJQSB2 YWx1ZSB3aGljaCBlbmNvZGVzIEdTSSAxLCBhbmQgdGhlIG9ubHkNCj4+Pj4+PiByZWFzb24gdGhp cyBkb2Vzbid0IGV4cGxvZGUgZXZlcnl3aGVyZSBpcyBiZWNhdXNlIHRoZQ0KPj4+Pj4+IGV2dGNo bl91cGNhbGxfdmVjdG9yIHJlZ2lzdHJhdGlvbiB0YWtlcyBwcmlvcml0eSBvdmVyIEdTSSBkZWxp dmVyeS4NCj4+Pj4+Pg0KPj4+Pj4+IFRoaXMgaXMgZGVjYWRlcyBvZiB0ZWNoIGRlYnQgcGlsZWQg b24gdG9wIG9mIHRlY2ggZGVidC4NCj4+Pj4+IEZlZWxzIGxpa2UgaXQgKHNldHRpbmcgdGhlIGNh bGxiYWNrIHBhcmFtZXRlcikgaXMgc29tZXRoaW5nIHRoYXQgdGhlDQo+Pj4+PiBoeXBlcnZpc29y IHNob3VsZCBkbyAtLS0gbm8gbmVlZCB0byBleHBvc2UgZ3Vlc3RzIHRvIHRoaXMuDQo+Pj4+IFNl bnNpYmxlIG9yIG5vdCwgaXQgaXMgdGhlIEFCSS4NCj4+Pj4NCj4+Pj4gTGludXggc3RpbGwgbmVl ZHMgdG8gd29yayAobmljZWx5KSB3aXRoIG9sZGVyIFhlbidzIGluIHRoZSB3b3JsZCwgDQo+Pj4+ IGFuZCB3ZQ0KPj4+PiBjYW4ndCBqdXN0IHJldHJvZml0IGEgY2hhbmdlIGluIHRoZSBoeXBlcnZp c29yIHdoaWNoIHNheXMgImJ0dywgdGhpcyANCj4+Pj4gQUJJDQo+Pj4+IHdlJ3ZlIGp1c3QgY2hh bmdlZCBub3cgaGFzIGEgc2lkZSBlZmZlY3Qgb2YgbW9kaWZ5aW5nIGEgZmllbGQgdGhhdCB5b3UN Cj4+Pj4gYWxzbyBsb2dpY2FsbHkgb3duIi4NCj4+Pg0KPj4+IFRoZSBoeXBlcmNhbGwgaGFzIGJl ZW4gYXJvdW5kIGZvciBhIHdoaWxlIHNvIEkgdW5kZXJzdGFuZCBBQkkgY29uY2VybnMNCj4+PiB0 aGVyZSBidXQgWEVOX0hWTV9DUFVJRF9VUENBTExfVkVDVE9SIHdhcyBpbnRyb2R1Y2VkIG9ubHkg YSBtb250aCBhZ28uDQo+Pj4gV2h5IG5vdCB0aWUgcHJlc2VuY2Ugb2YgdGhpcyBiaXQgdG8gbm8g bG9uZ2VyIGhhdmluZyB0byBleHBsaWNpdGx5IHNldA0KPj4+IHRoZSBjYWxsYmFjayBmaWVsZD8N Cj4+Pg0KPj4gQW55IG90aGVyIG9waW5pb25zIG9uIHRoaXM/DQo+Pg0KPj4gKGkuZS4sIGNhbGxp bmcgeGVuX3NldF9jYWxsYmFja192aWEoMSkgYWZ0ZXINCj4+IEhWTU9QX3NldF9ldnRjaG5fdXBj YWxsX3ZlY3RvciBPUiBub3QgZXhwb3NpbmcgdGhpcyB0byBndWVzdHMgYW5kDQo+PiBpbnN0ZWFk IGhhdmluZyBYZW4gY2FsbCB0aGlzIGZ1bmN0aW9uIChpbiBodm1vcF9zZXRfZXZ0Y2huX3VwY2Fs bF92ZWN0b3INCj4+IG1heWJlKSBhbmQgdGllaW5nIGl0cyBwcmVzZW5zZSB0byBYRU5fSFZNX0NQ VUlEX1VQQ0FMTF9WRUNUT1Igd2hpY2ggd2FzDQo+PiByZWNlbnRseSBhZGRlZCkNCj4gDQo+IA0K PiBDUFVJRCB3b24ndCBoZWxwIGhlcmUsIEkgd2Fzbid0IHRoaW5raW5nIGNsZWFybHkuDQo+IA0K PiANCj4gQ2FuIHdlIHdyYXAgdGhlIEhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3RvciBoeXBl cmNhbGwgaW4gYSBmdW5jdGlvbiANCj4gdGhhdCB3aWxsIGRlY2lkZSB3aGV0aGVyIG9yIG5vdCB0 byBhbHNvIGRvIHhlbl9zZXRfY2FsbGJhY2tfdmlhKDEpPw0KPiANCk9rYXkuIFdpbGwgZG8gdGhp cyBpbiBhIHYyLg0KDQpUaGFua3MsDQoNCkphbmUu From xen-devel-bounces@lists.xenproject.org Tue Jul 26 12:57:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 12:57:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375283.607575 (Exim 4.92) (envelope-from ) id 1oGK7u-0001Kk-O9; Tue, 26 Jul 2022 12:57:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375283.607575; Tue, 26 Jul 2022 12:57:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGK7u-0001Kd-LS; Tue, 26 Jul 2022 12:57:30 +0000 Received: by outflank-mailman (input) for mailman id 375283; Tue, 26 Jul 2022 12:57:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGK7t-0001KX-17 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 12:57:29 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7eb5b352-0ce2-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 14:57:26 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eb5b352-0ce2-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658840246; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=nVsswOXwuLaTALgLmNaZg4gcGwG6EGeds9Y3uPMNHLc=; b=hNlv+4NZWRfxC98orPE3G+kq+g4QIb/o9AeDCMhyyjW/hBrnDlgS6Nkl wKPeWGS+Xq6w3xbwExAKtNPrsv/XtM6J5NR9QOYJsgrUvFrOJcZcQ5ReK A7LledihzakDfNI6MGMd4Cqvb2UyP8RkALX6GOB+fIvt5NU8F2N3/HGuV E=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75926172 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:DiEUdq5Dm0wQ5UfgUO9DFAxRtETAchMFZxGqfqrLsTDasY5as4F+v msZUTqAPKzeNDDzfI13bom//EMEu5Hcx4VlQQtrqXhnHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5qmq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJFNmA5YZ3t96OF9tq +0YcDcyN1edv+3jldpXSsE07igiBMziPYdZsXB81zDJS/0hRPgvQY2Tu4Uehm1pwJkTQ7COP KL1ahI2BPjESz9GPFpRLZs6leOhgHTXeDxEslOF46Ew5gA/ySQujem3boOKILRmQ+1wxEifu Eifwl34C1YGOPuj5yq+2G2F07qncSTTB9tJSezQGuRRqFiTy30VBTUfUFKppv//hkPWc9VbJ k8P8ywit58u5VerRdnwWR6/iHOctxtaUN1Ve8Uh8x2EwKfQ5wefB0AHQyRHZdhgs9U5LRQo2 UWOhMjBHiF0vfueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adhdrxGDe2w DGMowA/gakeiYgA0KDT1VLNji+op5PJZhUo/QiRVWWghitpNNCNZIGy71Xfq/FaI+6xUlaFr FAAms6D8PoJC5Cd0iCAKM0HG6uo/LCCKyHGhkB0HIgJ8C6k8HquO4tX5VlWIEZvL9ZBejLzZ kLXkR1e6YUVP3awa6JzJYWrBKwCyKnmGtPNTP3YbtNSJJN2cWev/DlnTVyBw2f31kMrlMkXN Z6FfICsBHABBKJPyDuwWvdb0Lk3yyR4zmTWLbjx1zyu1buTYi7TRbptDbeVRrlntuXe+lyTq osBcZvRo/lCbAHgSjuHz5USCWkHFEYYW4H288toL6mdGgUzTQnNFMTtLaMdl51NxvoIxreQp ivmAye023Kk2ySZdFzihmRLLeq2AM0h9S9T0TkEZw7A5pQ1XWq4AE7znbMTdKJvyuFsxOUco xItK5TZWaQnptgqFl0ggXjBQG9KLk3DafqmZXbNXdTGV8cIq/b10tHlZBDz0yIFEzC6s8Azy 5X5iF6LHsVfHlQyU5uIAB5K879WlSFG8N+eomOSeoUDEKkS2NMCx9PNYg8ffJhXdESrKsqy3 AeKGxYIzdTwT3sO2ICQ3cis8tb2e9aS62IAQAE3G57qanSBlodiqKccONu1kcf1Dzuupv/9N LgEkJkR8pQvxT53jma1KJ4zpYpW2jclj+YyIthMdJkTU2mWNw== IronPort-HdrOrdr: A9a23:OBZm46+cer3TyLayyEJuk+DWI+orL9Y04lQ7vn2YSXRuE/Bw8P re+sjztCWE7wr5N0tQ+uxoVJPufZq+z+8Q3WByB8bBYOCOggLBR+sOgbcKqweQYhEWndQ86U 4PScZD4aXLfD1Hsfo= X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="75926172" From: Jane Malalane To: LKML CC: Jane Malalane , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , "Jan Beulich" , Colin Ian King , Subject: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Date: Tue, 26 Jul 2022 13:56:57 +0100 Message-ID: <20220726125657.12151-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Implement support for the HVMOP_set_evtchn_upcall_vector hypercall in order to set the per-vCPU event channel vector callback on Linux and use it in preference of HVM_PARAM_CALLBACK_IRQ. If the per-VCPU vector setup is successful on BSP, use this method for the APs. If not, fallback to the global vector-type callback. Also register callback_irq at per-vCPU event channel setup to trick toolstack to think the domain is enlightened. Suggested-by: "Roger Pau Monné" Signed-off-by: Jane Malalane --- CC: Juergen Gross CC: Boris Ostrovsky CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: x86@kernel.org CC: "H. Peter Anvin" CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: Jane Malalane CC: Maximilian Heyne CC: Jan Beulich CC: Colin Ian King CC: xen-devel@lists.xenproject.org v2: * remove no_vector_callback * make xen_have_vector_callback a bool * rename xen_ack_upcall to xen_percpu_upcall * fail to bring CPU up on init instead of crashing kernel * add and use xen_set_upcall_vector where suitable * xen_setup_upcall_vector -> xen_init_setup_upcall_vector for clarity --- arch/x86/include/asm/xen/cpuid.h | 2 ++ arch/x86/include/asm/xen/events.h | 3 ++- arch/x86/xen/enlighten.c | 2 +- arch/x86/xen/enlighten_hvm.c | 24 ++++++++++++++----- arch/x86/xen/suspend_hvm.c | 10 +++++++- drivers/xen/events/events_base.c | 49 ++++++++++++++++++++++++++++++++++---- include/xen/hvm.h | 2 ++ include/xen/interface/hvm/hvm_op.h | 15 ++++++++++++ 8 files changed, 93 insertions(+), 14 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 78e667a31d6c..6daa9b0c8d11 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -107,6 +107,8 @@ * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* Per-vCPU event channel upcalls */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) diff --git a/arch/x86/include/asm/xen/events.h b/arch/x86/include/asm/xen/events.h index 068d9b067c83..62bdceb594f1 100644 --- a/arch/x86/include/asm/xen/events.h +++ b/arch/x86/include/asm/xen/events.h @@ -23,7 +23,7 @@ static inline int xen_irqs_disabled(struct pt_regs *regs) /* No need for a barrier -- XCHG is a barrier on x86. */ #define xchg_xen_ulong(ptr, val) xchg((ptr), (val)) -extern int xen_have_vector_callback; +extern bool xen_have_vector_callback; /* * Events delivered via platform PCI interrupts are always @@ -34,4 +34,5 @@ static inline bool xen_support_evtchn_rebind(void) return (!xen_hvm_domain() || xen_have_vector_callback); } +extern bool xen_percpu_upcall; #endif /* _ASM_X86_XEN_EVENTS_H */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 30c6e986a6cd..b8db2148c07d 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_start_info); struct shared_info xen_dummy_shared_info; -__read_mostly int xen_have_vector_callback; +__read_mostly bool xen_have_vector_callback = true; EXPORT_SYMBOL_GPL(xen_have_vector_callback); /* diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 8b71b1dd7639..198d3cd3e9a5 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -7,6 +7,8 @@ #include #include +#include +#include #include #include @@ -30,6 +32,9 @@ static unsigned long shared_info_pfn; +__ro_after_init bool xen_percpu_upcall; +EXPORT_SYMBOL_GPL(xen_percpu_upcall); + void xen_hvm_init_shared_info(void) { struct xen_add_to_physmap xatp; @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) { struct pt_regs *old_regs = set_irq_regs(regs); + if (xen_percpu_upcall) + ack_APIC_irq(); + inc_irq_stat(irq_hv_callback_count); xen_hvm_evtchn_do_upcall(); @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) if (!xen_have_vector_callback) return 0; + if (xen_percpu_upcall) { + rc = xen_set_upcall_vector(cpu); + if (rc) { + WARN(1, "HVMOP_set_evtchn_upcall_vector" + " for CPU %d failed: %d\n", cpu, rc); + return rc; + } + } + if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); @@ -188,8 +205,6 @@ static int xen_cpu_dead_hvm(unsigned int cpu) return 0; } -static bool no_vector_callback __initdata; - static void __init xen_hvm_guest_init(void) { if (xen_pv_domain()) @@ -211,9 +226,6 @@ static void __init xen_hvm_guest_init(void) xen_panic_handler_init(); - if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) - xen_have_vector_callback = 1; - xen_hvm_smp_init(); WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); xen_unplug_emulated_devices(); @@ -239,7 +251,7 @@ early_param("xen_nopv", xen_parse_nopv); static __init int xen_parse_no_vector_callback(char *arg) { - no_vector_callback = true; + xen_have_vector_callback = false; return 0; } early_param("xen_no_vector_callback", xen_parse_no_vector_callback); diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c index 9d548b0c772f..0c4f7554b7cc 100644 --- a/arch/x86/xen/suspend_hvm.c +++ b/arch/x86/xen/suspend_hvm.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "xen-ops.h" @@ -14,6 +15,13 @@ void xen_hvm_post_suspend(int suspend_cancelled) xen_hvm_init_shared_info(); xen_vcpu_restore(); } - xen_setup_callback_vector(); + if (xen_percpu_upcall) { + unsigned int cpu; + + for_each_online_cpu(cpu) + BUG_ON(xen_set_upcall_vector(cpu)); + } else { + xen_setup_callback_vector(); + } xen_unplug_emulated_devices(); } diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 46d9295d9a6e..2ad93595d03a 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -48,6 +48,7 @@ #include #endif #include +#include #include #include #include @@ -2195,11 +2196,48 @@ void xen_setup_callback_vector(void) callback_via = HVM_CALLBACK_VECTOR(HYPERVISOR_CALLBACK_VECTOR); if (xen_set_callback_via(callback_via)) { pr_err("Request for Xen HVM callback vector failed\n"); - xen_have_vector_callback = 0; + xen_have_vector_callback = false; } } } +/* Setup per-vCPU vector-type callbacks and trick toolstack to think + * we are enlightened. If this setup is unavailable, fallback to the + * global vector-type callback. */ +static __init void xen_init_setup_upcall_vector(void) +{ + unsigned int cpu = 0; + + if (!xen_have_vector_callback) + return; + + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && + !xen_set_upcall_vector(cpu) && !xen_set_callback_via(1)) + xen_percpu_upcall = true; + else if (xen_feature(XENFEAT_hvm_callback_vector)) + xen_setup_callback_vector(); + else + xen_have_vector_callback = false; +} + +int xen_set_upcall_vector(unsigned int cpu) +{ + int rc; + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, cpu), + }; + + rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op); + if (rc) + return rc; + + if (!cpu) + rc = xen_set_callback_via(1); + + return rc; +} + static __init void xen_alloc_callback_vector(void) { if (!xen_have_vector_callback) @@ -2210,6 +2248,8 @@ static __init void xen_alloc_callback_vector(void) } #else void xen_setup_callback_vector(void) {} +static inline void xen_init_setup_upcall_vector(void) {} +int xen_set_upcall_vector(unsigned int cpu) {} static inline void xen_alloc_callback_vector(void) {} #endif @@ -2271,10 +2311,9 @@ void __init xen_init_IRQ(void) if (xen_initial_domain()) pci_xen_initial_domain(); } - if (xen_feature(XENFEAT_hvm_callback_vector)) { - xen_setup_callback_vector(); - xen_alloc_callback_vector(); - } + xen_init_setup_upcall_vector(); + xen_alloc_callback_vector(); + if (xen_hvm_domain()) { native_init_IRQ(); diff --git a/include/xen/hvm.h b/include/xen/hvm.h index b7fd7fc9ad41..8da7a6747058 100644 --- a/include/xen/hvm.h +++ b/include/xen/hvm.h @@ -60,4 +60,6 @@ static inline int hvm_get_parameter(int idx, uint64_t *value) void xen_setup_callback_vector(void); +int xen_set_upcall_vector(unsigned int cpu); + #endif /* XEN_HVM_H__ */ diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h index f3097e79bb03..e714d8b6ef89 100644 --- a/include/xen/interface/hvm/hvm_op.h +++ b/include/xen/interface/hvm/hvm_op.h @@ -46,4 +46,19 @@ struct xen_hvm_get_mem_type { }; DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type); +/* + * HVMOP_set_evtchn_upcall_vector: Set a that should be used for event + * channel upcalls on the specified . If set, + * this vector will be used in preference to the + * domain global callback via (see + * HVM_PARAM_CALLBACK_IRQ). + */ +#define HVMOP_set_evtchn_upcall_vector 23 +struct xen_hvm_evtchn_upcall_vector { + uint32_t vcpu; + uint8_t vector; +}; +typedef struct xen_hvm_evtchn_upcall_vector xen_hvm_evtchn_upcall_vector_t; +DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_evtchn_upcall_vector_t); + #endif /* __XEN_PUBLIC_HVM_HVM_OP_H__ */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 13:14:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 13:14:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375305.607606 (Exim 4.92) (envelope-from ) id 1oGKOR-00046N-FS; Tue, 26 Jul 2022 13:14:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375305.607606; Tue, 26 Jul 2022 13:14:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKOR-00046G-CN; Tue, 26 Jul 2022 13:14:35 +0000 Received: by outflank-mailman (input) for mailman id 375305; Tue, 26 Jul 2022 13:14:34 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKOQ-00046A-Sa for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 13:14:34 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2fd7e16-0ce4-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 15:14:33 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2fd7e16-0ce4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658841273; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jaOrvQ16dO/XQyfOPMOgXIJZcD928SKh+qF+agx9Tic=; b=Z9b4s89iBgOlmOJFvK3TVrdGlykpIvjSsoMLI/N9F7Ow/Btm5IZFHpn2 ehQTKO9FHCDlQ8/sBPFuClyUdcggkizdhelDKPriHfd6p2tUNaOUC5euZ Mf0P6/2w/WGneG44+GZzNJNRqZDha/5JRngXBz1ZryyRznfl9hTZgUk6X g=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 75928194 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:OrKkp6wER95NXWCDSjh6t+c3xirEfRIJ4+MujC+fZmUNrF6WrkUPz mtNCmqCO6yLZ2CgeYtyb46x805XscXUmtJjTgs5pSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb90ky5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1RVlMxYII6o9x9GGpS9 f8FazQGMDGq0rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzpZRFVN0hRI5U5hOqy3VH0ciFCqULTrq0yi4TW5FMsgeK9aYuJEjCMbfVzx2bfl kyYxU6jXygmHsKu9h+q7Fv504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTvfC8g1X4X99ZJ F0Z/gIvq7Q/8AqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOluU7WDgr3 V+hhM7yCHpkt7j9dJ6G3u7K93XoY3FTdDJcI39fJecY3zX9iL5pnBWSQfQ6KqSshcH1Giyzx zvUjQFr0t3/kvU3O7WHEUHv2mzx9siRFlRuv207TUr+sFonOdfNi5iArAGCsK0edNvxokyp5 iBspiSI0AwZ4XhhfgSpSf5FIrym7u3t3Nb00Q82RMlJG9hAFheekWFsDNJWfh4B3j4sI2OBX aMqkVo5CGVvFHWrd7RrRIm6Ft4ny6Ptffy8CK2EMYUSO8ghK1LZlM2LWaJ39zm2+HXAbIllY cvLGSpSJS1y5VtbIMqeGL5GjO5DKtEWzmLPX5HrpymaPU6lTCfMEd8tbQrRBt3VGYve/205B f4DaJbRo/ieOcWiChTqHXk7dghQcyJkVM2n9KS6tIere2JbJY3oMNeJqZtJRmCvt/49ejvgl p1lZnJl9Q== IronPort-HdrOrdr: A9a23:Yj6wvK0DDbCz5rkmINSE2gqjBL4kLtp133Aq2lEZdPRUGvb3qy nIpoV96faUskd0ZJhOo7C90cW7LU80lqQFhLX5X43SPzUO0VHAROoJgLcKqweQfREWndQ96U 4PScdD4aXLfDpHsfo= X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="75928194" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu , Tamas K Lengyel Subject: [PATCH] x86/vpmu: Fix build following vmfork addition Date: Tue, 26 Jul 2022 14:13:57 +0100 Message-ID: <20220726131357.13722-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit GCC complains: arch/x86/cpu/vpmu.c:351:15: error: conflicting types for 'vpmu_save_force'; have 'void(void *)' with implied 'nocf_check' attribute 351 | void cf_check vpmu_save_force(void *arg) | ^~~~~~~~~~~~~~~ In file included from ./arch/x86/include/asm/domain.h:10, from ./include/xen/domain.h:8, from ./include/xen/sched.h:11, from ./include/xen/event.h:12, from arch/x86/cpu/vpmu.c:23: ./arch/x86/include/asm/vpmu.h:117:6: note: previous declaration of 'vpmu_save_force' with type 'void(void *)' 117 | void vpmu_save_force(void *arg); | ^~~~~~~~~~~~~~~ Adjust the declaraion. Fixes: 755087eb9b10 ("xen/mem_sharing: support forks with active vPMU state") Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu CC: Tamas K Lengyel --- xen/arch/x86/include/asm/vpmu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/vpmu.h b/xen/arch/x86/include/asm/vpmu.h index 8a3ae115623e..05e1fbfccfcf 100644 --- a/xen/arch/x86/include/asm/vpmu.h +++ b/xen/arch/x86/include/asm/vpmu.h @@ -114,7 +114,7 @@ void vpmu_do_interrupt(struct cpu_user_regs *regs); void vpmu_initialise(struct vcpu *v); void vpmu_destroy(struct vcpu *v); void vpmu_save(struct vcpu *v); -void vpmu_save_force(void *arg); +void cf_check vpmu_save_force(void *arg); int vpmu_load(struct vcpu *v, bool_t from_guest); void vpmu_dump(struct vcpu *v); -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 13:23:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 13:23:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375312.607618 (Exim 4.92) (envelope-from ) id 1oGKXM-0005h6-Bq; Tue, 26 Jul 2022 13:23:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375312.607618; Tue, 26 Jul 2022 13:23:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKXM-0005gz-89; Tue, 26 Jul 2022 13:23:48 +0000 Received: by outflank-mailman (input) for mailman id 375312; Tue, 26 Jul 2022 13:23:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKXL-0005gt-0M for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 13:23:47 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2b9f879c-0ce6-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 15:23:44 +0200 (CEST) Received: from mail-bn8nam11lp2168.outbound.protection.outlook.com (HELO NAM11-BN8-obe.outbound.protection.outlook.com) ([104.47.58.168]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 09:23:30 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by SA2PR03MB5947.namprd03.prod.outlook.com (2603:10b6:806:11f::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 13:23:27 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f%7]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 13:23:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2b9f879c-0ce6-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658841824; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=/NTreFgJG7w9rWLpliFWfM02CrLNgyrr3jJhubszJ0E=; b=B8mbYzdJRyEns16pIVPRYkiwsEXQV+A0iqDucf6Rr9g8l6nZ5FpaAtbc H3mr7gzdWAlR2s1+DMYxNCIWQuD2SsiPXNt6pygxNy5zJHaX7Sqvh2Y4x oSxoviei+ueRklHbifTSS3qlMKu+W76PpI4MVG+qQ/fF5728XSYwNK4yD c=; X-IronPort-RemoteIP: 104.47.58.168 X-IronPort-MID: 76444687 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:O8IYjaqV+mpVDw8ZBoKnQgUjIOxeBmI0ZRIvgKrLsJaIsI4StFCzt garIBmGOP2NNzOnLtF/Odzno0NTuZTWm4NkTAE4qXtkFn4S9puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUXpqVzWmJPy cYTC2gzUSqovMms5ry0H7wEasQLdKEHPas5k1Q5lHTzK6ZjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/F4/NpswA/zyQouFTpGPjcfNHMYMxRl0KRo G/u9GXlGBAKcteYzFJp91rz2LOTwX2rB+r+EpWyzK9wo2aI/1Y1GT0VBHqW/fWpzUSXDoc3x 0s8v3BGQbIJ3EiqSMTtGh61uniJujYCVNdKVe438geAzuzT+QnxLmoLVDlac/Q9qdQ7Azct0 zehldTzBCcpt6aJU3WD7bSFhTSoMCMRICkJYipsZRcK58nLpIA1kw7VSdBiAOi5g7XdHDD2z DeitiUyh7wPy8UM0s2T90jvijatq56ZCAI4ji3bV3yoqANwYpWoYaSs6F7G/bBBKpqUSh+Ku 31ss9jOssgNAIuLmSjLR/8CdJmp//+tIizAhkQpFJ4knxy24GKqd41U5DB4JW9qP9wCdDuvZ 1Xc0StW4JJQJ3KsYbVAf5OqC88qwK7jEvzoTvnRKNFJZ/BZcQ+K7SdjTUeV1nLqlg4gnMkXO 52WbMKtBnYyErl8wXy9QOJ1+bQswiE4g2DSQ5/TzhK73L7Yb3mQIZ8VPV3LYu0n4aespATO7 80ZJ8aM0w9YUuD1fm/Q64F7ELwRBX0yBJSzocoHcOeGe1NiADt4Va+Xxq49cYt4magTjv3P4 ny2Rk5fzhz4mGHDLgKJLHtkbdsDQKpCkJ7yBgR0VX7A5pTpSdzHAHs3H3fvQYQayQ== IronPort-HdrOrdr: A9a23:i/OcZqoZ/rQMJcR8JNkTsaQaV5uHL9V00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhd4tKLzOWwldAS7sSoLcKogeQUBEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZW6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lIn1y6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0eVjcVaKv2/VQIO0aOSAWUR4Z zxStAbToBOAkbqDyKISN3Wqk7dOXgVmjnfIBSj8AbeSITCNU4H4ox69M1km1LimjUdlcA536 RR022DsZ1LSRvGgSTm/tDNEwpnj0yuvBMZ4JguZlFkIP8jgYVq3Psi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwA/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFvxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiIsiYfzQTOdNSSj5uw7zvmWehTCYd3E8LAv27Fp/rvhWbHsLSqPDFgzjsrImYRtPvHm X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76444687" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VrPjEkUxwKDrjm+R5K2PqZ7kQEBChWxBFoXU5lHVc/dF73h5B9txSExE3RsfDBEfvYvJe5hMTpAas1niMQ5d2uHMh6nb2lxy/jkxBiMa6gqMKvPpH0tbDUHX43sv84YilUDzQAilMEqszksR4QHNOosTeXxXl5xbHl2wMPUyeD6eOzIwjXxbgEl1Z70KJgL32QPLu0fpoEgFv4FjTeYnZDV4+Ir7RahBAF/ZaA3RJrdA3+GuAExqj3t2wmv501W0KdGzhxehuAEpKTpgAgKC7IspmBSAQXjF5QAjtU2Co27e7IT/ZXOi5NAMxkKR2xQS/OYf9KLyOMLmLCc4mcizOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/NTreFgJG7w9rWLpliFWfM02CrLNgyrr3jJhubszJ0E=; b=FcrRswZmtbJo/Kt1Y63CUf5F1kymDHuV2/cTdg1lzMWg07ip1ULA6VqkR9HYWayTQLEGr9kAetKSZthO7ZlmSkKiW/UAdo22mGpnKekYLzfSqHFf2b+y/oX/r3+UDNJrs4ORO1vPZIx8ImC3nOZO7wlb02RFci7a2VwgJoNPRXl6HmL6BaUxtTZ/+BRxTS4FbxKCx+D1xFiO8fGFM6PfkrQavrKYy/aiMasLqhSi9nEGcS1Qyk48jLqEV/uZXXrNa8N5OPdje0mZR+Bjpz/EdNaSO6agw12JmIMw4qhVriLUUoxRKv0bq3LVckhdaScyeCeCza5KThMarNLT6iD/1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/NTreFgJG7w9rWLpliFWfM02CrLNgyrr3jJhubszJ0E=; b=mftkhmcNqWmjIsyJga7ztg1B/F9HfcaW7VS2flbtt3zCt6U0A7bbOxkZxoJKGRbW9Es1hO5h9Gv8DuiSzPsf513M4AVpiY1atirHPN+IorZDAZD2rXsujWz4S+K4pXJcxFpFuN5X1D2xGJAM0hVPYxSBwluuftCAslI9ty65S5c= From: Jane Malalane To: LKML CC: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYoO9LZ/coQoD4ekyAV2OZDcw3862Qo+SA Date: Tue, 26 Jul 2022 13:23:27 +0000 Message-ID: <0e514872-912e-5695-7ec2-5647b062f1be@citrix.com> References: <20220726125657.12151-1-jane.malalane@citrix.com> In-Reply-To: <20220726125657.12151-1-jane.malalane@citrix.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 16350029-a4d5-4460-34f2-08da6f0a0673 x-ms-traffictypediagnostic: SA2PR03MB5947:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L2DqZdqSDjPsCzb7vGb5XWCEiEiziGqDIGJCQE40Ph3gP9pOppnLP7TY/pnr5JQmILyo2w4JVahyAQwBEoIYjS8nxf4ulOix5ynsVyhXtO9IDCclfCvzXfDDKXhnhO03ukK09U1t4fgmpIpmAZg/81FnMZs4fdAzoIFtqRTJLhApZyMl/WUqU+NbV5/zED7RYB3U3+nQx1t6RUmJFHc5f6oK1VITGkNm+H8wUvhX7WxmXrWRgD0sgXMv2+IjuRjP8QuPsYf2lQJB/zGHsdSjPkhjy3jxhTnZUm+8nSL4PFpoiOXQlJZyjs87ao0I30yttqGHYfNwiw1v96o68fuiRbCvGEUDyeQ6UDOzB2Z3QyDvB92Z+hp7vzgUCvEAE/yxPB4cuoCdxYYCT5rDkmKQSHDet6VkwSxnO1TcFD05NUNno6siHCxoaCJLxiCzzPd+7uULBwLcKadLP5fSYNzbczrIipPbwpD20EP2+TtpI9WmjNwCP3CtcgYgDj5jwox75Luj3XiilWcFfg7dx4bDzKlNp7SHzNXqMy5mvyOg7zGv+eSeUBltd534Z7LCbZ74/am2RRArLuBovPiJ3PSj3qOS9G1DpEAIx9wMCflz57QY7gfZKwoIuoGT7+KhcdKm56BT6i4Kycmt+Zuo1whWvpPeqnHvaojQyGkNalbAxy3onrFo3Jxbl3ockGeHjBFR3cKptbm7NtQzWIRVrPLktQyvGT0vzr8SB26+GRkaAwsDCsH15Ivs+DRyEtZMMzJkV8lyiN7q9aBwHcC25ao+K2ENh85y+Xp0E5tq/1aAZyyrbNLgDAAL419JiGclwNf0uRDAK7rBALSdpbYPM/0xfQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(39860400002)(396003)(366004)(136003)(31696002)(2906002)(186003)(53546011)(316002)(122000001)(31686004)(55236004)(6506007)(86362001)(41300700001)(36756003)(7416002)(83380400001)(38070700005)(38100700002)(5660300002)(2616005)(82960400001)(6486002)(71200400001)(8936002)(91956017)(26005)(6512007)(6916009)(478600001)(54906003)(66946007)(64756008)(8676002)(4326008)(66476007)(66556008)(76116006)(66446008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1Vjb1RvRGhQQmlYd3M0UVdKRm0rWmRBMjhmY3RxVWxZVkFoWEJ5Z2I3S24v?= =?utf-8?B?YkhQcTNNTi9zeVBzL3pneXdGcGtrS3pSRUdHZUQweFpQN2VFMUpLQ1UvZmpR?= =?utf-8?B?NmszK29sVFJUcUNCTU9VdHIyVlczOGFoZEpsYWRPYUl2RGV6RGx6cnRQT1gx?= =?utf-8?B?RTRkNERnWTJ3c0FWWjdpdlFzTTc2Qk9SY0tjRVVKVCtQZDVMSjNpaXdIemdX?= =?utf-8?B?dHNtTzN0U3I4eEZmSmJ5UzQvY2tlTEc3YTl5TjJ2aVZSVEh2RXN3R3hsQWNF?= =?utf-8?B?SnFYKzdhMFNzWWNVN01PWWVFQWdNZ1ErZGZjc2kzZEQ1bHNkT2wyVXM1azVp?= =?utf-8?B?amRkTTRTckZZMHhwVnNvenlYOTFvQlJKaCswbTB3aFV2V3ZoVGNVSzB6MmRO?= =?utf-8?B?VlJVOE5wamFOMEhQY2VncFczckw1TElKUDl1K3pRclVHS1ovcktiRWFCNkh4?= =?utf-8?B?alB1VHVmWk5KUzlIV3ZzWnVXcFRUUGhodFpmZFdERS9aamxRdzVpeWVEZllX?= =?utf-8?B?ajJ3V2RVcTU1MGkxWHZMZ1JabXFPOUd5S3ZWT0NMTkVPVW0zL3F6RmI5NWto?= =?utf-8?B?RG9NQ0RBc0dJZnhmYTRyNDM4OFRndStSbmxPQTEyalV1WSs4YkIxbWZobU44?= =?utf-8?B?MXlWcFgydWpvM3lSNkE1R1J2STlpVGJ3M3ZER0JmbURCRUFrd1JRdkNCNDhE?= =?utf-8?B?RVYvRitUamVwazBFR0YzVy9Tby9rNTlBc3lPWTkwTGladzJoazZhZTdpMjNk?= =?utf-8?B?QzhyK3VOUWRwTmRKY3VZMmtVOVE4SnllMDhscFVLV1o3UzA0dVVvZDNEajY3?= =?utf-8?B?SnJibUNRK095RTZJOFZRaWxyZTA4RkoyOWszb0huVENmM2phanFqQ200WnRU?= =?utf-8?B?bnJOdG9oUjZHK2tzN3MwSjJIOHJKYmRoYm04NGg1bks5TDc3b0N0OHNjVGlK?= =?utf-8?B?UTdjc2JPK3NsdlhZOTBIdjZ2bmpqNnkzMXUrRGhDRFhNQXI4ZDZwa0RENFdt?= =?utf-8?B?OXZ4dDFsajhIQ0JyVTBlRGIrc2FXMlgyTTVpY2QrNVF1bnJReDg0TXZlRXht?= =?utf-8?B?RmJVaEhHT3Y5cXFZRUJPMUQzRVBYVTA0V1JCOUE3azlnamFZbkE1RG9GRTNJ?= =?utf-8?B?Q09venN1Z0Vma0hmdlhVdWRvd3BMZ0tuTEhUMlNQMVUyYWhzbHp4bFBTM1pC?= =?utf-8?B?ek4rTXJodG8wcjZ0dnpOZUh4OVo3WHc1bkNBVHZaK09SS0x4K3k3dFhPRUVP?= =?utf-8?B?b083bWE1OWcxV0d5cnJVM2ZhZnVnVGRad2d1aXBMR2IyQVNlb1h4OGl2UEsx?= =?utf-8?B?MCtuT2F3VHNrbVdwbWlyNDd6cDZILzJlZXFtWU9DNlRGU2luZzRuL3JGRUxH?= =?utf-8?B?TjlJeGtrODhFaDRBd1VBRFk2cVc1WDRBZ0JBTWxZaVZVZG9hcEIySkNsQUY1?= =?utf-8?B?RGpNZzhqZVRiUVNiR3AxMUZ2VDhOc294Vms0VWdKdmVVY3JBMUpXdGlodjZs?= =?utf-8?B?RXJXUjRjTnJNYTZKRnR5L2ZuUGU5L0lOM1p2UWd3aUNOUGhlOTZQbklIK2sr?= =?utf-8?B?WGtBMlkwRExYeUl5aW51RVNRTmJ1Y3VWQUpPQXN1VVFhYUFlZlJyU1FxUTBB?= =?utf-8?B?M0RYcTlVMGVyK0ptNGZSY1IzZEp4dktDaENyYUw4b0U1cTNlWkhFR3JFTGNk?= =?utf-8?B?MjZIb2NpcHg5T29ScDBqQ003YkhET1lIZ3VqRmduYnlRTnViK1dGNEdzTFZu?= =?utf-8?B?bEd4UklBS0Q5ZENQdGp0Qm5FcHYxeTBDRzJueDNWRVNiMXRFODNDNTI0Yk5Z?= =?utf-8?B?RnE3dm41aTNxNi9BRDh3SVQ2TmR3UStBRXo2NlFRc2I1azh6NTE4WXM2NE9W?= =?utf-8?B?bWYzMWVjSkRpemZNM2YvTFNRbWU1VVMzQXppZGFpK2RYVVFmejV3T3cyMkoy?= =?utf-8?B?SEZPa2JqalEzY0JyNmZndDd5cjVDU2xUYXNBT3RpYUZZcHRyNzhpSWIxMmtC?= =?utf-8?B?OWkvUVVwNUsxOWVkRUI1ZTBlMkFwSDBVRC9ycUxHK1RKYVF5eWRKS3RXQVI2?= =?utf-8?B?U0w3ekpDTVNkOVFLbmc1V1V6WFZjQjltdjNpUWlmVG9JWHA5blQ5RWZRbUpK?= =?utf-8?B?ZGhITjMvakxUdGtSTDhhMGxjN2xIbFBhdUhzdjNwdFFrTVV1TjVHRXJxK0xu?= =?utf-8?B?a1E9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <5C85771FD74B6D4CB5025B4A94C8BADB@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 16350029-a4d5-4460-34f2-08da6f0a0673 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 13:23:27.4447 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ku59ycA03PRdg0XPqy790Fo/fNojA7e3ksDmxLWpmiryaBtAiWBwkJAohoulaY/YD5ptcX1yTaajoxwhpH7W5r0OyNkpvG5/EC4y89GGk54= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5947 T24gMjYvMDcvMjAyMiAxMzo1NiwgSmFuZSBNYWxhbGFuZSB3cm90ZToNCj4gSW1wbGVtZW50IHN1 cHBvcnQgZm9yIHRoZSBIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IgaHlwZXJjYWxsIGlu DQo+IG9yZGVyIHRvIHNldCB0aGUgcGVyLXZDUFUgZXZlbnQgY2hhbm5lbCB2ZWN0b3IgY2FsbGJh Y2sgb24gTGludXggYW5kDQo+IHVzZSBpdCBpbiBwcmVmZXJlbmNlIG9mIEhWTV9QQVJBTV9DQUxM QkFDS19JUlEuDQo+IA0KPiBJZiB0aGUgcGVyLVZDUFUgdmVjdG9yIHNldHVwIGlzIHN1Y2Nlc3Nm dWwgb24gQlNQLCB1c2UgdGhpcyBtZXRob2QNCj4gZm9yIHRoZSBBUHMuIElmIG5vdCwgZmFsbGJh Y2sgdG8gdGhlIGdsb2JhbCB2ZWN0b3ItdHlwZSBjYWxsYmFjay4NCj4gDQo+IEFsc28gcmVnaXN0 ZXIgY2FsbGJhY2tfaXJxIGF0IHBlci12Q1BVIGV2ZW50IGNoYW5uZWwgc2V0dXAgdG8gdHJpY2sN Cj4gdG9vbHN0YWNrIHRvIHRoaW5rIHRoZSBkb21haW4gaXMgZW5saWdodGVuZWQuDQo+IA0KPiBT dWdnZXN0ZWQtYnk6ICJSb2dlciBQYXUgTW9ubsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+DQo+ IFNpZ25lZC1vZmYtYnk6IEphbmUgTWFsYWxhbmUgPGphbmUubWFsYWxhbmVAY2l0cml4LmNvbT4N Cj4gLS0tDQo+IENDOiBKdWVyZ2VuIEdyb3NzIDxqZ3Jvc3NAc3VzZS5jb20+DQo+IENDOiBCb3Jp cyBPc3Ryb3Zza3kgPGJvcmlzLm9zdHJvdnNreUBvcmFjbGUuY29tPg0KPiBDQzogVGhvbWFzIEds ZWl4bmVyIDx0Z2x4QGxpbnV0cm9uaXguZGU+DQo+IENDOiBJbmdvIE1vbG5hciA8bWluZ29AcmVk aGF0LmNvbT4NCj4gQ0M6IEJvcmlzbGF2IFBldGtvdiA8YnBAYWxpZW44LmRlPg0KPiBDQzogRGF2 ZSBIYW5zZW4gPGRhdmUuaGFuc2VuQGxpbnV4LmludGVsLmNvbT4NCj4gQ0M6IHg4NkBrZXJuZWwu b3JnDQo+IENDOiAiSC4gUGV0ZXIgQW52aW4iIDxocGFAenl0b3IuY29tPg0KPiBDQzogU3RlZmFu byBTdGFiZWxsaW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPg0KPiBDQzogT2xla3NhbmRyIFR5 c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPiBDQzogSmFuZSBNYWxh bGFuZSA8amFuZS5tYWxhbGFuZUBjaXRyaXguY29tPg0KPiBDQzogTWF4aW1pbGlhbiBIZXluZSA8 bWhleW5lQGFtYXpvbi5kZT4NCj4gQ0M6IEphbiBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4N Cj4gQ0M6IENvbGluIElhbiBLaW5nIDxjb2xpbi5raW5nQGludGVsLmNvbT4NCj4gQ0M6IHhlbi1k ZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZw0KPiANCj4gdjI6DQo+ICAgKiByZW1vdmUgbm9fdmVj dG9yX2NhbGxiYWNrDQo+ICAgKiBtYWtlIHhlbl9oYXZlX3ZlY3Rvcl9jYWxsYmFjayBhIGJvb2wN Cj4gICAqIHJlbmFtZSB4ZW5fYWNrX3VwY2FsbCB0byB4ZW5fcGVyY3B1X3VwY2FsbA0KPiAgICog ZmFpbCB0byBicmluZyBDUFUgdXAgb24gaW5pdCBpbnN0ZWFkIG9mIGNyYXNoaW5nIGtlcm5lbA0K PiAgICogYWRkIGFuZCB1c2UgeGVuX3NldF91cGNhbGxfdmVjdG9yIHdoZXJlIHN1aXRhYmxlDQo+ ICAgKiB4ZW5fc2V0dXBfdXBjYWxsX3ZlY3RvciAtPiB4ZW5faW5pdF9zZXR1cF91cGNhbGxfdmVj dG9yIGZvciBjbGFyaXR5DQo+IC0tLQ0KPiAgIGFyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9jcHVp ZC5oICAgfCAgMiArKw0KPiAgIGFyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9ldmVudHMuaCAgfCAg MyArKy0NCj4gICBhcmNoL3g4Ni94ZW4vZW5saWdodGVuLmMgICAgICAgICAgIHwgIDIgKy0NCj4g ICBhcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jICAgICAgIHwgMjQgKysrKysrKysrKysrKyst LS0tLQ0KPiAgIGFyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jICAgICAgICAgfCAxMCArKysrKysr LQ0KPiAgIGRyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jICAgfCA0OSArKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrLS0tLQ0KPiAgIGluY2x1ZGUveGVuL2h2bS5oICAgICAg ICAgICAgICAgICAgfCAgMiArKw0KPiAgIGluY2x1ZGUveGVuL2ludGVyZmFjZS9odm0vaHZtX29w LmggfCAxNSArKysrKysrKysrKysNCj4gICA4IGZpbGVzIGNoYW5nZWQsIDkzIGluc2VydGlvbnMo KyksIDE0IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUv YXNtL3hlbi9jcHVpZC5oIGIvYXJjaC94ODYvaW5jbHVkZS9hc20veGVuL2NwdWlkLmgNCj4gaW5k ZXggNzhlNjY3YTMxZDZjLi42ZGFhOWIwYzhkMTEgMTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2L2lu Y2x1ZGUvYXNtL3hlbi9jcHVpZC5oDQo+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9j cHVpZC5oDQo+IEBAIC0xMDcsNiArMTA3LDggQEANCj4gICAgKiBJRCBmaWVsZCBmcm9tIDggdG8g MTUgYml0cywgYWxsb3dpbmcgdG8gdGFyZ2V0IEFQSUMgSURzIHVwIDMyNzY4Lg0KPiAgICAqLw0K PiAgICNkZWZpbmUgWEVOX0hWTV9DUFVJRF9FWFRfREVTVF9JRCAgICAgICgxdSA8PCA1KQ0KPiAr LyogUGVyLXZDUFUgZXZlbnQgY2hhbm5lbCB1cGNhbGxzICovDQo+ICsjZGVmaW5lIFhFTl9IVk1f Q1BVSURfVVBDQUxMX1ZFQ1RPUiAgICAoMXUgPDwgNikNCj4gICANCj4gICAvKg0KPiAgICAqIExl YWYgNiAoMHg0MDAwMHgwNSkNCj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hl bi9ldmVudHMuaCBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9ldmVudHMuaA0KPiBpbmRleCAw NjhkOWIwNjdjODMuLjYyYmRjZWI1OTRmMSAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYvaW5jbHVk ZS9hc20veGVuL2V2ZW50cy5oDQo+ICsrKyBiL2FyY2gveDg2L2luY2x1ZGUvYXNtL3hlbi9ldmVu dHMuaA0KPiBAQCAtMjMsNyArMjMsNyBAQCBzdGF0aWMgaW5saW5lIGludCB4ZW5faXJxc19kaXNh YmxlZChzdHJ1Y3QgcHRfcmVncyAqcmVncykNCj4gICAvKiBObyBuZWVkIGZvciBhIGJhcnJpZXIg LS0gWENIRyBpcyBhIGJhcnJpZXIgb24geDg2LiAqLw0KPiAgICNkZWZpbmUgeGNoZ194ZW5fdWxv bmcocHRyLCB2YWwpIHhjaGcoKHB0ciksICh2YWwpKQ0KPiAgIA0KPiAtZXh0ZXJuIGludCB4ZW5f aGF2ZV92ZWN0b3JfY2FsbGJhY2s7DQo+ICtleHRlcm4gYm9vbCB4ZW5faGF2ZV92ZWN0b3JfY2Fs bGJhY2s7DQo+ICAgDQo+ICAgLyoNCj4gICAgKiBFdmVudHMgZGVsaXZlcmVkIHZpYSBwbGF0Zm9y bSBQQ0kgaW50ZXJydXB0cyBhcmUgYWx3YXlzDQo+IEBAIC0zNCw0ICszNCw1IEBAIHN0YXRpYyBp bmxpbmUgYm9vbCB4ZW5fc3VwcG9ydF9ldnRjaG5fcmViaW5kKHZvaWQpDQo+ICAgCXJldHVybiAo IXhlbl9odm1fZG9tYWluKCkgfHwgeGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNrKTsNCj4gICB9DQo+ ICAgDQo+ICtleHRlcm4gYm9vbCB4ZW5fcGVyY3B1X3VwY2FsbDsNCj4gICAjZW5kaWYgLyogX0FT TV9YODZfWEVOX0VWRU5UU19IICovDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4vZW5saWdo dGVuLmMgYi9hcmNoL3g4Ni94ZW4vZW5saWdodGVuLmMNCj4gaW5kZXggMzBjNmU5ODZhNmNkLi5i OGRiMjE0OGMwN2QgMTAwNjQ0DQo+IC0tLSBhL2FyY2gveDg2L3hlbi9lbmxpZ2h0ZW4uYw0KPiAr KysgYi9hcmNoL3g4Ni94ZW4vZW5saWdodGVuLmMNCj4gQEAgLTUxLDcgKzUxLDcgQEAgRVhQT1JU X1NZTUJPTF9HUEwoeGVuX3N0YXJ0X2luZm8pOw0KPiAgIA0KPiAgIHN0cnVjdCBzaGFyZWRfaW5m byB4ZW5fZHVtbXlfc2hhcmVkX2luZm87DQo+ICAgDQo+IC1fX3JlYWRfbW9zdGx5IGludCB4ZW5f aGF2ZV92ZWN0b3JfY2FsbGJhY2s7DQo+ICtfX3JlYWRfbW9zdGx5IGJvb2wgeGVuX2hhdmVfdmVj dG9yX2NhbGxiYWNrID0gdHJ1ZTsNCj4gICBFWFBPUlRfU1lNQk9MX0dQTCh4ZW5faGF2ZV92ZWN0 b3JfY2FsbGJhY2spOw0KPiAgIA0KPiAgIC8qDQo+IGRpZmYgLS1naXQgYS9hcmNoL3g4Ni94ZW4v ZW5saWdodGVuX2h2bS5jIGIvYXJjaC94ODYveGVuL2VubGlnaHRlbl9odm0uYw0KPiBpbmRleCA4 YjcxYjFkZDc2MzkuLjE5OGQzY2QzZTlhNSAxMDA2NDQNCj4gLS0tIGEvYXJjaC94ODYveGVuL2Vu bGlnaHRlbl9odm0uYw0KPiArKysgYi9hcmNoL3g4Ni94ZW4vZW5saWdodGVuX2h2bS5jDQo+IEBA IC03LDYgKzcsOCBAQA0KPiAgIA0KPiAgICNpbmNsdWRlIDx4ZW4vZmVhdHVyZXMuaD4NCj4gICAj aW5jbHVkZSA8eGVuL2V2ZW50cy5oPg0KPiArI2luY2x1ZGUgPHhlbi9odm0uaD4NCj4gKyNpbmNs dWRlIDx4ZW4vaW50ZXJmYWNlL2h2bS9odm1fb3AuaD4NCj4gICAjaW5jbHVkZSA8eGVuL2ludGVy ZmFjZS9tZW1vcnkuaD4NCj4gICANCj4gICAjaW5jbHVkZSA8YXNtL2FwaWMuaD4NCj4gQEAgLTMw LDYgKzMyLDkgQEANCj4gICANCj4gICBzdGF0aWMgdW5zaWduZWQgbG9uZyBzaGFyZWRfaW5mb19w Zm47DQo+ICAgDQo+ICtfX3JvX2FmdGVyX2luaXQgYm9vbCB4ZW5fcGVyY3B1X3VwY2FsbDsNCj4g K0VYUE9SVF9TWU1CT0xfR1BMKHhlbl9wZXJjcHVfdXBjYWxsKTsNCj4gKw0KPiAgIHZvaWQgeGVu X2h2bV9pbml0X3NoYXJlZF9pbmZvKHZvaWQpDQo+ICAgew0KPiAgIAlzdHJ1Y3QgeGVuX2FkZF90 b19waHlzbWFwIHhhdHA7DQo+IEBAIC0xMjUsNiArMTMwLDkgQEAgREVGSU5FX0lEVEVOVFJZX1NZ U1ZFQyhzeXN2ZWNfeGVuX2h2bV9jYWxsYmFjaykNCj4gICB7DQo+ICAgCXN0cnVjdCBwdF9yZWdz ICpvbGRfcmVncyA9IHNldF9pcnFfcmVncyhyZWdzKTsNCj4gICANCj4gKwlpZiAoeGVuX3BlcmNw dV91cGNhbGwpDQo+ICsJCWFja19BUElDX2lycSgpOw0KPiArDQo+ICAgCWluY19pcnFfc3RhdChp cnFfaHZfY2FsbGJhY2tfY291bnQpOw0KPiAgIA0KPiAgIAl4ZW5faHZtX2V2dGNobl9kb191cGNh bGwoKTsNCj4gQEAgLTE2OCw2ICsxNzYsMTUgQEAgc3RhdGljIGludCB4ZW5fY3B1X3VwX3ByZXBh cmVfaHZtKHVuc2lnbmVkIGludCBjcHUpDQo+ICAgCWlmICgheGVuX2hhdmVfdmVjdG9yX2NhbGxi YWNrKQ0KPiAgIAkJcmV0dXJuIDA7DQo+ICAgDQo+ICsJaWYgKHhlbl9wZXJjcHVfdXBjYWxsKSB7 DQo+ICsJCXJjID0geGVuX3NldF91cGNhbGxfdmVjdG9yKGNwdSk7DQo+ICsJCWlmIChyYykgew0K PiArCQkJV0FSTigxLCAiSFZNT1Bfc2V0X2V2dGNobl91cGNhbGxfdmVjdG9yIg0KPiArCQkJICAg ICAiIGZvciBDUFUgJWQgZmFpbGVkOiAlZFxuIiwgY3B1LCByYyk7DQo+ICsJCQlyZXR1cm4gcmM7 DQo+ICsJCX0NCj4gKwl9DQo+ICsNCj4gICAJaWYgKHhlbl9mZWF0dXJlKFhFTkZFQVRfaHZtX3Nh ZmVfcHZjbG9jaykpDQo+ICAgCQl4ZW5fc2V0dXBfdGltZXIoY3B1KTsNCj4gICANCj4gQEAgLTE4 OCw4ICsyMDUsNiBAQCBzdGF0aWMgaW50IHhlbl9jcHVfZGVhZF9odm0odW5zaWduZWQgaW50IGNw dSkNCj4gICAJcmV0dXJuIDA7DQo+ICAgfQ0KPiAgIA0KPiAtc3RhdGljIGJvb2wgbm9fdmVjdG9y X2NhbGxiYWNrIF9faW5pdGRhdGE7DQo+IC0NCj4gICBzdGF0aWMgdm9pZCBfX2luaXQgeGVuX2h2 bV9ndWVzdF9pbml0KHZvaWQpDQo+ICAgew0KPiAgIAlpZiAoeGVuX3B2X2RvbWFpbigpKQ0KPiBA QCAtMjExLDkgKzIyNiw2IEBAIHN0YXRpYyB2b2lkIF9faW5pdCB4ZW5faHZtX2d1ZXN0X2luaXQo dm9pZCkNCj4gICANCj4gICAJeGVuX3BhbmljX2hhbmRsZXJfaW5pdCgpOw0KPiAgIA0KPiAtCWlm ICghbm9fdmVjdG9yX2NhbGxiYWNrICYmIHhlbl9mZWF0dXJlKFhFTkZFQVRfaHZtX2NhbGxiYWNr X3ZlY3RvcikpDQo+IC0JCXhlbl9oYXZlX3ZlY3Rvcl9jYWxsYmFjayA9IDE7DQo+IC0NCj4gICAJ eGVuX2h2bV9zbXBfaW5pdCgpOw0KPiAgIAlXQVJOX09OKHhlbl9jcHVocF9zZXR1cCh4ZW5fY3B1 X3VwX3ByZXBhcmVfaHZtLCB4ZW5fY3B1X2RlYWRfaHZtKSk7DQo+ICAgCXhlbl91bnBsdWdfZW11 bGF0ZWRfZGV2aWNlcygpOw0KPiBAQCAtMjM5LDcgKzI1MSw3IEBAIGVhcmx5X3BhcmFtKCJ4ZW5f bm9wdiIsIHhlbl9wYXJzZV9ub3B2KTsNCj4gICANCj4gICBzdGF0aWMgX19pbml0IGludCB4ZW5f cGFyc2Vfbm9fdmVjdG9yX2NhbGxiYWNrKGNoYXIgKmFyZykNCj4gICB7DQo+IC0Jbm9fdmVjdG9y X2NhbGxiYWNrID0gdHJ1ZTsNCj4gKwl4ZW5faGF2ZV92ZWN0b3JfY2FsbGJhY2sgPSBmYWxzZTsN Cj4gICAJcmV0dXJuIDA7DQo+ICAgfQ0KPiAgIGVhcmx5X3BhcmFtKCJ4ZW5fbm9fdmVjdG9yX2Nh bGxiYWNrIiwgeGVuX3BhcnNlX25vX3ZlY3Rvcl9jYWxsYmFjayk7DQo+IGRpZmYgLS1naXQgYS9h cmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+ IGluZGV4IDlkNTQ4YjBjNzcyZi4uMGM0Zjc1NTRiN2NjIDEwMDY0NA0KPiAtLS0gYS9hcmNoL3g4 Ni94ZW4vc3VzcGVuZF9odm0uYw0KPiArKysgYi9hcmNoL3g4Ni94ZW4vc3VzcGVuZF9odm0uYw0K PiBAQCAtNSw2ICs1LDcgQEANCj4gICAjaW5jbHVkZSA8eGVuL2h2bS5oPg0KPiAgICNpbmNsdWRl IDx4ZW4vZmVhdHVyZXMuaD4NCj4gICAjaW5jbHVkZSA8eGVuL2ludGVyZmFjZS9mZWF0dXJlcy5o Pg0KPiArI2luY2x1ZGUgPHhlbi9ldmVudHMuaD4NCj4gICANCj4gICAjaW5jbHVkZSAieGVuLW9w cy5oIg0KPiAgIA0KPiBAQCAtMTQsNiArMTUsMTMgQEAgdm9pZCB4ZW5faHZtX3Bvc3Rfc3VzcGVu ZChpbnQgc3VzcGVuZF9jYW5jZWxsZWQpDQo+ICAgCQl4ZW5faHZtX2luaXRfc2hhcmVkX2luZm8o KTsNCj4gICAJCXhlbl92Y3B1X3Jlc3RvcmUoKTsNCj4gICAJfQ0KPiAtCXhlbl9zZXR1cF9jYWxs YmFja192ZWN0b3IoKTsNCj4gKwlpZiAoeGVuX3BlcmNwdV91cGNhbGwpIHsNCj4gKwkJdW5zaWdu ZWQgaW50IGNwdTsNCj4gKw0KPiArCQlmb3JfZWFjaF9vbmxpbmVfY3B1KGNwdSkNCj4gKwkJCUJV R19PTih4ZW5fc2V0X3VwY2FsbF92ZWN0b3IoY3B1KSk7DQo+ICsJfSBlbHNlIHsNCj4gKwkJeGVu X3NldHVwX2NhbGxiYWNrX3ZlY3RvcigpOw0KPiArCX0NCj4gICAJeGVuX3VucGx1Z19lbXVsYXRl ZF9kZXZpY2VzKCk7DQo+ICAgfQ0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2 ZW50c19iYXNlLmMgYi9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYw0KPiBpbmRleCA0 NmQ5Mjk1ZDlhNmUuLjJhZDkzNTk1ZDAzYSAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy94ZW4vZXZl bnRzL2V2ZW50c19iYXNlLmMNCj4gKysrIGIvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNl LmMNCj4gQEAgLTQ4LDYgKzQ4LDcgQEANCj4gICAjaW5jbHVkZSA8YXNtL3hlbi9wY2kuaD4NCj4g ICAjZW5kaWYNCj4gICAjaW5jbHVkZSA8YXNtL3N5bmNfYml0b3BzLmg+DQo+ICsjaW5jbHVkZSA8 YXNtL3hlbi9jcHVpZC5oPg0KPiAgICNpbmNsdWRlIDxhc20veGVuL2h5cGVyY2FsbC5oPg0KPiAg ICNpbmNsdWRlIDxhc20veGVuL2h5cGVydmlzb3IuaD4NCj4gICAjaW5jbHVkZSA8eGVuL3BhZ2Uu aD4NCj4gQEAgLTIxOTUsMTEgKzIxOTYsNDggQEAgdm9pZCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVj dG9yKHZvaWQpDQo+ICAgCQljYWxsYmFja192aWEgPSBIVk1fQ0FMTEJBQ0tfVkVDVE9SKEhZUEVS VklTT1JfQ0FMTEJBQ0tfVkVDVE9SKTsNCj4gICAJCWlmICh4ZW5fc2V0X2NhbGxiYWNrX3ZpYShj YWxsYmFja192aWEpKSB7DQo+ICAgCQkJcHJfZXJyKCJSZXF1ZXN0IGZvciBYZW4gSFZNIGNhbGxi YWNrIHZlY3RvciBmYWlsZWRcbiIpOw0KPiAtCQkJeGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNrID0g MDsNCj4gKwkJCXhlbl9oYXZlX3ZlY3Rvcl9jYWxsYmFjayA9IGZhbHNlOw0KPiAgIAkJfQ0KPiAg IAl9DQo+ICAgfQ0KPiAgIA0KPiArLyogU2V0dXAgcGVyLXZDUFUgdmVjdG9yLXR5cGUgY2FsbGJh Y2tzIGFuZCB0cmljayB0b29sc3RhY2sgdG8gdGhpbmsNCj4gKyAqIHdlIGFyZSBlbmxpZ2h0ZW5l ZC4gSWYgdGhpcyBzZXR1cCBpcyB1bmF2YWlsYWJsZSwgZmFsbGJhY2sgdG8gdGhlDQo+ICsgKiBn bG9iYWwgdmVjdG9yLXR5cGUgY2FsbGJhY2suICovDQo+ICtzdGF0aWMgX19pbml0IHZvaWQgeGVu X2luaXRfc2V0dXBfdXBjYWxsX3ZlY3Rvcih2b2lkKQ0KPiArew0KPiArCXVuc2lnbmVkIGludCBj cHUgPSAwOw0KPiArDQo+ICsJaWYgKCF4ZW5faGF2ZV92ZWN0b3JfY2FsbGJhY2spDQo+ICsJCXJl dHVybjsNCj4gKw0KPiArCWlmICgoY3B1aWRfZWF4KHhlbl9jcHVpZF9iYXNlKCkgKyA0KSAmIFhF Tl9IVk1fQ1BVSURfVVBDQUxMX1ZFQ1RPUikgJiYNCj4gKwkgICAgIXhlbl9zZXRfdXBjYWxsX3Zl Y3RvcihjcHUpICYmICF4ZW5fc2V0X2NhbGxiYWNrX3ZpYSgxKSkNCkkgc2hvdWxkIGhhdmUgcmVt b3ZlZCB4ZW5fc2V0X2NhbGxiYWNrX3ZpYSgxKSBoZXJlLiBXaWxsIHNlbmQgYW5vdGhlciANCnZl cnNpb24sIHdvdWxkIGp1c3QgbGlrZSB0byB3YWl0IGZvciBhbnkgY29tbWVudHMgYmVmb3JlIEkg ZG8uDQoNCkphbmUu From xen-devel-bounces@lists.xenproject.org Tue Jul 26 13:48:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 13:48:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375322.607629 (Exim 4.92) (envelope-from ) id 1oGKv6-0008SL-Ar; Tue, 26 Jul 2022 13:48:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375322.607629; Tue, 26 Jul 2022 13:48:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKv6-0008SE-7O; Tue, 26 Jul 2022 13:48:20 +0000 Received: by outflank-mailman (input) for mailman id 375322; Tue, 26 Jul 2022 13:48:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKv4-0008S7-FK for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 13:48:18 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150083.outbound.protection.outlook.com [40.107.15.83]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 99212e31-0ce9-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 15:48:16 +0200 (CEST) Received: from AM5PR0701CA0007.eurprd07.prod.outlook.com (2603:10a6:203:51::17) by AM8PR08MB6562.eurprd08.prod.outlook.com (2603:10a6:20b:355::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 13:48:13 +0000 Received: from VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com (2603:10a6:203:51:cafe::e2) by AM5PR0701CA0007.outlook.office365.com (2603:10a6:203:51::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Tue, 26 Jul 2022 13:48:13 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT012.mail.protection.outlook.com (10.152.18.211) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 13:48:12 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Tue, 26 Jul 2022 13:48:12 +0000 Received: from 9c946de4f959.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BA9FF737-4F53-4E54-B764-0F8D578D6792.1; Tue, 26 Jul 2022 13:48:02 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c946de4f959.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 13:48:02 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by VI1PR0801MB1790.eurprd08.prod.outlook.com (2603:10a6:800:5b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 13:47:59 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 13:47:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 99212e31-0ce9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=WQBrUClr+yrLufGStHl8H1dEzohRpvKA41y5m/eSSrazKJHKxZa2ELR8J6rKYoAES6WDGF1ha5xnQkP+CSU9nZfNLwxUeNAS+xOU3Wy8ejb37RBBKgUL8rHE8WPbgLwOEthlxWRnM5hmAlvWwGAOjwe/ypn8lCnro3Z+2esFTWp1kiR3fEzk1lw31KK9lHfAl4vENuVv6iAdJCJ1tA8pUxqXuSAsbMBkDZ/pyA8ooFGYvCWDMsgWl++XoAWkTL6/FmMBx7LvNSIeQRpO6dYy71Kg7Kg3a4G5crUpvofMTiXoCvgP7EUmt/mgyoqPu2aILFElt2S6pP+elZlK+66wow== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7B+pFb/N8Nt0CI6ybQ2DgiaZzn+77nUb4TRCrU8TpKU=; b=FSiUOjed09GOaEuI1MyrrYjYqkbb7oftWIvr7yqr+FqhF+FjeILvF0jLStlHrcxFr8taZB4JlVcziGCC+2DDcHB7cjYP+WJqHqXxOct/Wl4DgizecKq6LI97sMhyQ2/2+948W2RdM+o8cAyy+KH6XmbBPryfR+BJtGiez6wsn269oIXfWNpE89eDbqpZjFoidS1/bfFtJ5OjEUuBTOlkSBv8y4DkaBGPmvEj7B9f6esHS/rJN9qSpuIhxwVj9ELvCDIjsyR5qTts0TTKm+Uhp4rjWrRhMEXw5c0rIpXJaaqjGq5Y/grK8ufjgpQss41LBxO06UsxtGAJio9uAB3kwQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7B+pFb/N8Nt0CI6ybQ2DgiaZzn+77nUb4TRCrU8TpKU=; b=hALpxUfiVLoO79h1Sn2VkqD4QDSe4mjwkKKlG64jo6ymCRjF1OwcvKGuq/EjZ3eGgEXO2EXM3vwp+X4l8onL9zFNvSg0iEB4WlmVyjyMNihmxwKNaQwLUA7J9fnMTz07edKnRW7Q7VG2cBoDkXA0mI29IXZhmnMEiuOt/bvaDdg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 929f679986e06651 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aGVQRI4DaY2FwYJX/qOFDTVaJtT+t8Y6s8W6cxtjmL6vp6LHem02wbJfy661vl2EpxXjOlogLipoZDAfjB5OuYySmSVB7gwN0Dee7E8KzGVDE26glPidIiEF39hCon26pYg9t4K9ybrVdVbFecfVkrKyxhoCE8ylvFNpm0Xga33OyqRgoyqjXzisQ2E1bt1mCoZBdo8Qs7/BX4Ew68lbbfSyX0Sv7YZOUK3MkJZ7FYpyPH7E9VpyN2cMdRCWGC6Aahrz3ocSQuStx25hgMFil31Kkh9mbADd4UsGjXtsDCmq/nWnjzDK+iWrMUgHPFN/cw8f6ftYlyKZZGxk5BAUwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7B+pFb/N8Nt0CI6ybQ2DgiaZzn+77nUb4TRCrU8TpKU=; b=KW1HR6GZUa+GBr2VenPDnzl6ju5xHv5r5intJj7pA4Mq97rsfkkVY+GOP+uI69k4Bi5Oyq2hr2NkUblTClrfTLElT3Iq7VtlLRi/BpRJ+2Y2diLBnklRhEI4APGOrdhkiimAD5wv7T+dg0hObC/rEh2OfVjJl+08JjPCmL54L8LdBR7moOg4uiRY3ZUWWsUryXMqPezhlyyukYUJYmyI5Bxs3uGEqGzFP3STDQh/s1mjf0uoQMNrYQi3pdqYFuhTWDAFt8Lc2TeEGDyrpMdl+9Sh2ADslqz9UP8DzX+Uz93GRRo2I8IavUSAK+El5Z5r95/+oaM0p4OaHD/zF7Az0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7B+pFb/N8Nt0CI6ybQ2DgiaZzn+77nUb4TRCrU8TpKU=; b=hALpxUfiVLoO79h1Sn2VkqD4QDSe4mjwkKKlG64jo6ymCRjF1OwcvKGuq/EjZ3eGgEXO2EXM3vwp+X4l8onL9zFNvSg0iEB4WlmVyjyMNihmxwKNaQwLUA7J9fnMTz07edKnRW7Q7VG2cBoDkXA0mI29IXZhmnMEiuOt/bvaDdg= From: Rahul Singh To: Oleksandr Tyshchenko CC: xen-devel , Oleksandr Tyshchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= , Oleksandr Andrushchenko Subject: Re: [PATCH V7 00/11] PCI devices passthrough on Arm, part 3 Thread-Topic: [PATCH V7 00/11] PCI devices passthrough on Arm, part 3 Thread-Index: AQHYm5cOuiXPVkeraUmibOPVUdwdrK2QtXSA Date: Tue, 26 Jul 2022 13:47:59 +0000 Message-ID: <4B8A2C5D-194B-4C15-9F4A-C5703CCA5727@arm.com> References: <20220719174253.541965-1-olekstysh@gmail.com> In-Reply-To: <20220719174253.541965-1-olekstysh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fc396a19-be14-4a0a-eec5-08da6f0d7bc6 x-ms-traffictypediagnostic: VI1PR0801MB1790:EE_|VE1EUR03FT012:EE_|AM8PR08MB6562:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 1dGhobXcdZIi3kftodAXhL2v+j/d/KOQyTnvT/MKAHqZ9d9edAtavWAGsZcKpw+OnY8U2cx+pMa8UyyoMm+WiZ0n6LDhuhBdCILOq/duD+Qp/KpDVOiFzO9IIVxpx0mROLdIcGytBoV+eWf5QzItaY2mX4k9w5c3MUAtJLixPfNT5gkoGVGELgNdjCHSi1wnPfC+4vLHXeyCqmenfW2VQKGxjvxmphLjOPkgEpR9ozkziU/RzvbeRifCnfnkG3vEkFuQAgLoC1V62YLvOKdz6Xy3XHHjUh+JaVixCTD0V/WTxfkrwf44wV26UMVO/WFfquzOcsL9m848wyjZbsIEupHMM5lC8LshX+maUyxSh6sNNerVC470HeNIGKyR1F21XmMHpGcs7wU8uXorUpvCkBQP0OWoNojtMP1OdPLZIDD1oiI0TNferlryUf6wiu/uG+QCZzO6krlx0AxDtI7t4FQ8J4TNcn3Kj036nk08EKeZJQftvQRJHeaQ9buXN4Km2FWjsoEHG/cjTBlqV+J18tHlZoSuE5ves4wogbyoqXMoDtLir0bT/wmIOAgE9TAWcVSOEoV9lGX/FArGIJ4hFBHQTWB0JHcfuh1WYeTeDivA/bZ4B05UtPbj91Oxzf7ROWtdy3MoSvy3G/NpqNEcjwKCw7bZMNw1r1p9PpMbU4fRtMAP2KWUEMortPaE8B2azX5bUXJBT3wXwlvE+ZFjV7dmlLiT2DuqL12Rnp99wbN3A0a37pPxIFOqRAlwEO1MyJhvTmJUcYTXyFhvAd57/QE+xkI/R3eK9T21C6r9axGHHgxUrKXiDh7uaUH/gckZnckP4pjYFcDIFTtdtRPP/Dbvv8QVvvvPUz77pD/JfidQpJgMnFI7DW3hcAlybtATgKs0x3ogZ7weRil7N8Pvlg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(346002)(396003)(366004)(136003)(478600001)(6486002)(186003)(83380400001)(26005)(966005)(6512007)(38070700005)(7416002)(36756003)(8936002)(5660300002)(2906002)(2616005)(86362001)(6916009)(122000001)(6506007)(53546011)(54906003)(91956017)(66946007)(66556008)(38100700002)(33656002)(316002)(4326008)(76116006)(41300700001)(71200400001)(8676002)(66476007)(66446008)(64756008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1790 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8d1ae2d-5bb9-4b50-2784-08da6f0d73d6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uE4CLTnPqvkqYw4+Io6sH/KKhVVwlqSF5TKtqwk9oNciv40BIBo4KsIpByLjzcEKZvMGAJOtyryi0HYGOs/ioqlE7NqX7VlogXTXfOTXMDd9pFAYWAEL8DYn9aTgNVUp68IIMLqjjOoDyISd9e6BE2aDh5BnlPWm8zyz1372lQfjfvYLIF+a0g7jZni4Q3EatpF1On5KZVpMCzj0XHnP9qypdoO1X8587SuJf6Hkgo6kUbxB5njMkp26SIYfSJ5DK+duzrMuBTQ0kOgBPcwi/Geb39xSxfAG5i4eATK53uzC0wYmbbWBYz58oX4WFIkxZNhLjGNNRo/ukyqZ58RLXRCyulW2eCHYxw4wTWiJUK55mEls3CPj9CLVbEHRdAOhB/gnehCiOzaqLVxUSJfWOeyLaipaq/droHhYSTq2bDoGLoTVo3BefcYgdNZ3WhMURIVdYSV6oZ6voLAyaToygTSfHxcCjjF3PeLlTC5Qi8xIKuxLRlgO3/VScky1e6F5SBe92Fmnv25ayn6mg8mEt6m1chkZoUVBSUp27q89XOHpWM1BFOjnuEtj4wydrs+14R9VSeG4Wvdsv2uOsxPkX6hLIs+lZYJT2Kgz4Kph8vZdbPIK/aGdpd9PL35rDz6D4M6AIbReACf5+lQ38nqBKSBVnFuWOvZ6HKRlgbPRMeQ18AHN8yCPcOk76zUF0/KUP+n0HeGxwICRp1hBd8DifN2Uln5ZN+MmKUUw1w54rF+4LD5sySq91hmipuuiGQP8iX88lZVARIkRQFsvZ7qLR4y4Ka8JyGJ9rqxornzFEUcFkJ6bn+uwCpIOAnLjdrBMYLcEe5y3OFPzu5nrPhjJl3GaU5GfeBW8XmpnsBC9kmcxKyOnJM2rNZ6fcuza8oXX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(136003)(376002)(36840700001)(46966006)(40470700004)(6512007)(26005)(53546011)(107886003)(356005)(2616005)(6862004)(8936002)(5660300002)(478600001)(966005)(6486002)(41300700001)(33656002)(6506007)(2906002)(82310400005)(36860700001)(40480700001)(336012)(47076005)(186003)(81166007)(82740400003)(86362001)(83380400001)(40460700003)(36756003)(54906003)(70586007)(4326008)(70206006)(8676002)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 13:48:12.7111 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc396a19-be14-4a0a-eec5-08da6f0d7bc6 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT012.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6562 Hi Oleksandr, > On 19 Jul 2022, at 6:42 pm, Oleksandr Tyshchenko wr= ote: >=20 > From: Oleksandr Tyshchenko >=20 > Hi, all! >=20 > You can find previous discussion at [1]. >=20 > 1. This patch series is focusing on vPCI and adds support for non-identit= y > PCI BAR mappings which is required while passing through a PCI device to > a guest. The highlights are: >=20 > - Add relevant vpci register handlers when assigning PCI device to a doma= in > and remove those when de-assigning. This allows having different > handlers for different domains, e.g. hwdom and other guests. >=20 > - Emulate guest BAR register values based on physical BAR values. > This allows creating a guest view of the registers and emulates > size and properties probe as it is done during PCI device enumeration by > the guest. >=20 > - Instead of handling a single range set, that contains all the memory > regions of all the BARs and ROM, have them per BAR. >=20 > - Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value as set > up by the host bridge in the hardware domain. > This way hardware domain sees physical BAR values and guest sees > emulated ones. >=20 > 2. The series also adds support for virtual PCI bus topology for guests: > - We emulate a single host bridge for the guest, so segment is always 0. > - The implementation is limited to 32 devices which are allowed on > a single PCI bus. > - The virtual bus number is set to 0, so virtual devices are seen > as embedded endpoints behind the root complex. >=20 > 3. The series has been updated due to the new PCI(vPCI) locking scheme im= plemented > in the prereq series which is also on the review now [2]. >=20 > 4. For unprivileged guests vpci_{read|write} has been re-worked > to not passthrough accesses to the registers not explicitly handled > by the corresponding vPCI handlers: without that passthrough > to guests is completely unsafe as Xen allows them full access to > the registers. During development this can be reverted for debugging purp= oses. >=20 > !!! OT: please note, Oleksandr Andrushchenko who is the author of all thi= s stuff > has managed to address allmost all review comments given for v6 and pushe= d the updated > version to the github (23.02.22).=20 > So after receiving his agreement I just picked it up and did the followin= g before > pushing V7: > - rebased on the recent staging (resolving a few conflicts) > - updated according to the recent changes (added cf_check specifiers wher= e appropriate, etc) > and performed minor adjustments > - made sure that both current and prereq series [2] didn't really break x= 86 by testing > PVH Dom0 (vPCI) and PV Dom0 + HVM DomU (PCI passthrough to DomU) using Qe= mu > - my colleague Volodymyr Babchuk (who was involved in the prereq series) = rechecked that > both series worked on Arm using real HW >=20 > You can also find the series at [3]. >=20 > [1] https://lore.kernel.org/xen-devel/20220204063459.680961-1-andr2000@gm= ail.com/ > [2] https://lore.kernel.org/xen-devel/20220718211521.664729-1-volodymyr_b= abchuk@epam.com/ > [3] https://github.com/otyshchenko1/xen/commits/vpci7 >=20 I tested the whole series on ARM N1SDP board everything works as expected. So for the whole series: Tested-by: Rahul Singh Regards, Rahul From xen-devel-bounces@lists.xenproject.org Tue Jul 26 13:48:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 13:48:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375327.607639 (Exim 4.92) (envelope-from ) id 1oGKvf-0000XX-Mm; Tue, 26 Jul 2022 13:48:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375327.607639; Tue, 26 Jul 2022 13:48:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKvf-0000XQ-Jx; Tue, 26 Jul 2022 13:48:55 +0000 Received: by outflank-mailman (input) for mailman id 375327; Tue, 26 Jul 2022 13:48:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGKve-0008S7-ES for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 13:48:54 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00072.outbound.protection.outlook.com [40.107.0.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id af651224-0ce9-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 15:48:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DU2PR04MB8709.eurprd04.prod.outlook.com (2603:10a6:10:2dc::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 13:48:51 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 13:48:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: af651224-0ce9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UGHVNSz/z+p6MLmyfbpjOC6zbM0yk8RXe+rtMtJ3PyjpXMScXYKbXU7F6coyJJSieifBJlvhmz24Df921iKEtWNKeZzhOgCStoFrOzMwyXY1Vm9I/zTLWqTh8uqLG3owQglZE08f0d62oMIbrbuJ/JGFO9c3BvXs/98TZ7pACaClcbO/3wu3rrZs38JGKAaDW5jHRuBHEzBMX6VxfFUX1/z1t7zyAP7GKT9zlVgnP+6GnMRkDWfLbMrpO3KczF8t9k2y/8IrHhTb0lrNa/CvSmON1v2l5EvLHmOeWt0W1PLHFgqrdVtKSz/50QEn81/ikLsNFhynP4WIufclrDlktA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VK5J5IzrYvn7bVXSB1rdr68VYrfB8cOrDPtRDJ56ziY=; b=JDAHLQWcrtjYsysl6+6RZSqi/vkYc1d4QAGLh1vNjguUKUgopFcfdnjO2zzAWM+v4NMB+4VPjqyQAwy8ASzWQv+dpgIzf66dT6VDiusSq83CwUyLvSZbvoIlh0iY8VqY+1nxNslje+stX4nnmld8P6WN7SZllOhTjMBo2Y5Ji2zlEJslA/vxnpqEk30RtviMwgxthEEObaYOTQNYamiqI2UB43MrHp8S9HjPoQM5pzX7zh2GO8IN98shxpdXiEjyOy2e7U3xmcVdL5Y7ZEX7xCRMyqRGT2t4IXsytcjPvmJQJpXfLzQ5PAKSwMiX415KiOGpv0G1WJItBaOLCkI/lQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VK5J5IzrYvn7bVXSB1rdr68VYrfB8cOrDPtRDJ56ziY=; b=jjVqGHrjFcO2vOqI7PXYee0xKOesJUVKNhYCbd6HhqytHhgC8lLggMewZU9DrqIomQkVPb6CwyUWsIJtdXReGfEBjpfMk/KZaNwwwEh4vj+UFP3nWLNbFPUax1+YmCXHjcXh0F8jXgPhrrP0NTPMC5UR//rssqAnNBINY1Hif8FKbd5QZUWZCTcx9brAEAAWU1z6Dw5YadqOMa8KX3JO16rYhyJmEKubARYziGcRkNi6q39kl1EWhKk8C6MyYcQv3BX4z3aEBfSberrCwwWC3bvFDErHmTvyh8n3qIbAPYY2H8AXd8XKDDfxhItOe705cEA/jo8D/GrgG2GpviIFDA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 15:48:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/vpmu: Fix build following vmfork addition Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Tamas K Lengyel , Xen-devel References: <20220726131357.13722-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220726131357.13722-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0107.eurprd04.prod.outlook.com (2603:10a6:20b:31e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20766e12-f758-4824-b173-08da6f0d92a0 X-MS-TrafficTypeDiagnostic: DU2PR04MB8709:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: W8tEb926Y+MERDcHqRywQTMfwi12962s4wNAGPkB3+QkVgdGvj+UfHW4WtJxeArvQQqkvJnCybkBr8324xu2Jbvf5ECs3UKLV4SmzesjbYSowVviXk8rYnHp64VPyl4hHPCLbg8QLxgV1evhPjUoH5BoFD15SS6aayxUeZVBtM66Y3raI4pL5s/eL0skfh5r8lmn1OVBgYNw7C4tnVI7yRGQx3Qv0Sz7At9SMWx+mrFktuc8UK+j8njc46CuAN45EpP8IrEzMumqt31Jowjkj/FIy1h5Ls9lSZGohgbrZcLTHVbxIiQ2ojPMaRZ7fs1SYqFtFPGnTgvfJYg66Eb1SL+sQcUxAwRIFRqFUOIFRG35bZfV4la4WHGe1DoKPC1CMdkYsVaa0bnA6Tz4BjfuEuriFZtXXNYv8XfHH1sn2Ao/3ZLd6H5ONT0dal5FpKuGNgnMuJxxwKdlfD/LETorJS7gwpoptEU7DvJpYfV8HsjWGkXAErIWlFkR5p1nwHlNIxw+9v6ndmomaYwtLRc+Nvapl5zZSRI0xzrZJYfxBNUDiIpRmN7T8DIgAVRMatU94xIwo4OF1n0VfXVp/GytF1OPcBWk7eQM45dC0yNZ0DOFuRGAVHxL8zl1TDPmC/Z5qNdgtj6VI6663HUwsH4mdAL4YNGdIURgwzsUpkzId9u8ArEan6wLU+prBEjZpdc7J5uYdVOI85kfAwXeUJj1S3MVpK4TKUBm4Ng5X3rWXKZ/10A+5vAjUvpnpbf3qHzgu949E4OFZGgw/dCknFWnua1xKCDVLKf/wiW0DWmcewDR7F13Ab5EP3D7LxOIkgGQCHLTUl/fCuBwF+h/r0LAcQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(396003)(346002)(366004)(39860400002)(38100700002)(53546011)(6916009)(4744005)(2616005)(26005)(6512007)(6666004)(6506007)(8936002)(2906002)(36756003)(41300700001)(5660300002)(86362001)(54906003)(6486002)(478600001)(186003)(31696002)(4326008)(66556008)(8676002)(66476007)(66946007)(316002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R3gzYVZJOTFOUEdXbzlKS0ZVYkJTMEcrYkxUOWwrNDlIQVpMMzJNeXppNXZE?= =?utf-8?B?NFZOTWtmVlQwMHJyeHQ3TDB5Yi9XSFY5UWxadFl0aStLODRHQ2ZBdjhUMFpw?= =?utf-8?B?ajRUMGxVbTVYZEJSaURGQTFMM3J3QjlnRDlNcEgwcjUyV0txeDZDVzBNTnBa?= =?utf-8?B?dFJ1Q0JRZW00ZGhGUUVUYzVlc0ZlbWE4Q01yZGFzWWVtUmdiOUlkQ2Y0Qmlr?= =?utf-8?B?VEpGV2pOOXdVOXFGVUJkSTN1S2Q3eFl5YjF1cWhwWUZNRzd3SFFGOXlDeEdM?= =?utf-8?B?cVVGalUrUGcraTJKdmNmS2FWUzVhVHl1VG5GUHBqN1dnRTVXREtaZGs5eUhZ?= =?utf-8?B?emd5aUg2SDFGVkk1cGU1Y09WQTY0VU0yNTRvb2NtcThkWXRaZUNmYTc2YTk3?= =?utf-8?B?NVA1T1lkUVQ0RHg2V01DK2ZyckxmTVJRVXpOZyswR1BqQVZQeFdPUkhNalFK?= =?utf-8?B?ODUvMTJuOXlMb1NFZC90ZTRDMDRvNjNXS1g2aGMreUN3VWhkZVRvSHFTc0ps?= =?utf-8?B?eDFZS0FYbmpaT3NsUXoxK1psVVl0RDdrdTBtRnlSWlJqQUMvNGozU3htN3Rw?= =?utf-8?B?d3U3elJYcHFNSTZiWTVScnFXK1pVZnh1VnlTdGYzSUV1TkVqTWgyRWplOGJ1?= =?utf-8?B?b1BmZ0pSa3pPUWtPclRISVdObFdKUDRiV3huamdNSE1WOHUvR1h2TkF1NTNk?= =?utf-8?B?cXJlR1RRVHlLWjNyZEdIa3IwUUh4QnJkQXRFandCYUNTU1gvWmgvdmxwQjc0?= =?utf-8?B?d1NWeWp0V1VoK01PM0JLcTcvNEllNURKY0V5TkVMRjA1RkcxODRKMnloNENk?= =?utf-8?B?UEVHV2I2MXZtMFBpNUxoRkpLdDVvUDRtT3dLWXBidlRYYmdIZmdWSlRjVlJK?= =?utf-8?B?QlMxTjdPNlM4aU1QQmhsREtmamZZQnd4WTJWclJBQ1JnWFhYaFYyOXRFRG0v?= =?utf-8?B?bVBXbHQ2VnJRTVVjWmtZeHBhUkJjcFhDTCsxZmxsODk5QUJLRmROSm1MdkUx?= =?utf-8?B?ZVdwYXlqaTFEM3NKS1psRXRJcEhSTERyRXNBS2xTY2gyOEZvTzBTWG1WcEhj?= =?utf-8?B?Y0I3eUJHc1pNMXNHem5oQmZVUEFVcjBUY3k2ZGRQZmdSdmhwUGh2NkROOU1O?= =?utf-8?B?QjFnc244M0lzT1pEWUNucjlHOUZteXNYalF2MFBFb3dqV2lEUnR4ZHI4R0JO?= =?utf-8?B?NmtreUlRN00vME9EbGY0L2hUMDFtWi9kejI0VW5SWFk5T3ZLUy9VZFltZFRB?= =?utf-8?B?cSt6U1VwdGE2aW1hcGx3MUpiUzBZcGVRNGpMVW1LWHBEdzFPSUpnNFJZOXlL?= =?utf-8?B?TXVQSlRtK1FEaHo5L2JYb1Byb3Ywd3JqVTNiRmYrSzkyb01GaHdhWVAxeExt?= =?utf-8?B?YnErNExhM3QyZWRNc0hCL0VuVXFOKzdScXRkYXFSdkVtNWx5eE91Y3hqaVl2?= =?utf-8?B?S2NXdGd0SWVzR3h3Yy9tSWF5Z0gwMUJVNDdJYmZvSmJSVmV0STJVbXVYYko0?= =?utf-8?B?V1luTGRkQUlHR2JMZGhoTW5SVUp1MENWVmVSWEEya0dob2ZCVytTYXRwaGRh?= =?utf-8?B?WGYxZ1pMTFFuQ1JJdlQvNVhkd1hXdEdPNExLTUJEUHFXeno2ZGwwYWNLTkZj?= =?utf-8?B?dDdrZkNiZVNBTGNqNmJFQytGMjNsU3RxcnZELytDS2J1aGVnY3hiUmtEQTVI?= =?utf-8?B?V0w2RlpoTHdldEN4cllNbVhLTGdka1lKVzROU2haOWhFK3BEVnZRbDE5RzBx?= =?utf-8?B?VU1KRmxZanlWeE0rMTFLRWlhYzhUMnFGcExTL09wSlltYkJPempadTY0cElT?= =?utf-8?B?eGdQdzZFbkhoeTRtZnhoRDdMM2U2amQ1QmliT1k2bXVRZlp4cnFNZXZEclFh?= =?utf-8?B?RmxDbDNsdnJpVi9rcnY0V0VpMlJzZDI5UWNJVWZJMmhXY25BR3F3bU1nb3lp?= =?utf-8?B?eWJaTWdUS2hPRFNCa0xZVkJVUnJoTkNtOVBOdng0eVpqSEw0MlJubEdkUW0r?= =?utf-8?B?ZHVEanZIaHpySHNiZXdSWDVDUjg4WExFUTBLY0xCRWpLQ2pDa1oraVpzaVRY?= =?utf-8?B?QmhYbENRZStEc1JVaGpoVHhIOWZVS2FrMy9oZWRJOVduUzBsQjk3dUk3UVVY?= =?utf-8?Q?zc5WbKo79tq74HMwVom3AFDq2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20766e12-f758-4824-b173-08da6f0d92a0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 13:48:51.3171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cBkyDhCxfxQf1C7a2vPFYjXWYzcdjuyX0XYntpF0+Bk5Zw+5KddYUfGoVAX9pWBmRgfGMcb6qqKYCnlpiFeYSg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8709 On 26.07.2022 15:13, Andrew Cooper wrote: > GCC complains: > > arch/x86/cpu/vpmu.c:351:15: error: conflicting types for 'vpmu_save_force'; have 'void(void *)' with implied 'nocf_check' attribute > 351 | void cf_check vpmu_save_force(void *arg) > | ^~~~~~~~~~~~~~~ > In file included from ./arch/x86/include/asm/domain.h:10, > from ./include/xen/domain.h:8, > from ./include/xen/sched.h:11, > from ./include/xen/event.h:12, > from arch/x86/cpu/vpmu.c:23: > ./arch/x86/include/asm/vpmu.h:117:6: note: previous declaration of 'vpmu_save_force' with type 'void(void *)' > 117 | void vpmu_save_force(void *arg); > | ^~~~~~~~~~~~~~~ > > Adjust the declaraion. > > Fixes: 755087eb9b10 ("xen/mem_sharing: support forks with active vPMU state") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich Maybe worth mentioning that is is a non-default gcc? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:08:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:08:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375338.607651 (Exim 4.92) (envelope-from ) id 1oGLDy-0003KS-57; Tue, 26 Jul 2022 14:07:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375338.607651; Tue, 26 Jul 2022 14:07:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLDy-0003KI-24; Tue, 26 Jul 2022 14:07:50 +0000 Received: by outflank-mailman (input) for mailman id 375338; Tue, 26 Jul 2022 14:07:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLDx-0003KC-AJ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:07:49 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 53ab2cb8-0cec-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 16:07:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8622.eurprd04.prod.outlook.com (2603:10a6:102:219::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 14:07:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 14:07:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 53ab2cb8-0cec-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=adJStU0tLH5qmVz3ZhMRM0tAkKcE9dd4tUs9v8Lk8hb3ARax2xCOFPt8VCmhFDPrDgEgjTpyNFFbwMXnELB80JvwrHtxq45q7YaQgihU8h19GCfUnZc7FdpO5vW7ywu4lz3i5omhuMN9NTh6OL3Fr8mYjm13KjD8Pib6X++dn8xhYExib0XJjRcCNPfDZAwFUj75fzvRyb+FKLbYkysvVXTFAWTfgOjmYAKOmPAyEfAXP7vUnWgJG1GK+w8ykrgsc/Ti+ySSR38O5XMUmt2b9c1lQWUAjQx0EzmJFsbkWHNR4W9l5OzyIZQOxxQa2kbobV86XQBXdVRW01sCwT543w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtkIvKUFpUIzCJWUNG3vj5IkWmPNXnF1JPbQ5cZR1ig=; b=RaiOOgcBypuUqLnrnwodFhcLFSQLN2eT7aGATLOoQt88HKK/teCb3Y/t+pjp3HWEMQRNin0rVJvvvPtdP3bmRmklryNrtM4evp3prLGVSHZKt/Kvoar6bWr2igNcifryBLKK/V5WYdl0Hjrs/h4+SQNm3HKUwNaT5ZHkenmWKLO2+prhudV/jA5GPS+m+uAUbmxqHkt4IEvRHQKX13eX/eLQ+Z2kmuiGaZj8OuatlONn6Umy5iLliuP39gHkArWBYLs5ovJHmRfkXgMtwCewU/eQuIIs2BROyxkeyAnQAx7Eb9sVwOXRHL22OjSazCdekrpgLjyV5b1kTPw9m1GpGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtkIvKUFpUIzCJWUNG3vj5IkWmPNXnF1JPbQ5cZR1ig=; b=RuMcdzhtjBll2u3fH7WxVtyFB3+I3k+Y7J79OkUrwXkfI0TciL5Ep+7Zx1D1Z9VfTN9fJ6TI6Oh1FFwBHaI/maUPPcOcQMBrgAEO9K2gHxcpBoXW5hJhHMpAiU7V8py5n0ZXvQ4tYU95UQMS4TAeQBfojzNPAxQjb858WzVaopopbOQu0X6LbQVpqstItMqzvpIdQyJAOZg94M13ccAjiCXmUBrg/af/6Z6MnQcWrlmZAVcMFW92PWilIa6DYSuBEWRNGoQfXMbRFQG1+yYzZo9qOmtxPEkEvU6prdavLekS9xFYmDXiwlMQilg57AjLP2/Iq9phkX6fSnKgdOQQ/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <924ecfef-c9a0-b56c-f403-c4014e84d9d5@suse.com> Date: Tue, 26 Jul 2022 16:07:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/tboot: Drop mfn_in_guarded_stack() Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220726122521.16091-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220726122521.16091-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0147.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:96::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44747734-ccd8-4de1-7968-08da6f1036fc X-MS-TrafficTypeDiagnostic: PAXPR04MB8622:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WZ2qwqY+kwrdas1sC5FcEpEpCJ/MR9gyuF2uvSUhUTab15qC9AawbzTh4T/tIQt8PgMCuSfAsjatplgmdnanepB56vXIZw7Yhx1JMvasLRvB9vivyYxch54Y8DxU5Ki7YfzvN8gu3mUWSZ0RovJDFEV6VKLKWWTm15skgGlAm2hUMznjh4XylVXr/I0WAYAC4qEuPMqtkuSBfbsfxDuuYIF9DiglWxwBvdK3TjBXGOYOsFR7L7xg7dutd3dRhii9Gi08Rar7H8cN9+5Ip1oMCreV9yPFfumfExTWKM6ZiA69194negfo6+1PtqODPUOF2mshjxWcLU1tWYO/+9hjIe1PA/AiyWBTqh17L/2i9JPo2XIkVj7+59LUPMhJ7/2by3UnwuLAOPy3l2rgRwVRnSrZqOdvr+iTduubsnbWC4Ez+fiyUbpyQzyk7Hh8XBvZ5llLgPVNqfmIt5U1rrp8CP2UrYbbNCUKzBq4TvQKcfmscQOzenH+lASdAq07XFjiBv2BCPW79sZMAOMu62nage2TK+ZfbiuNWpcP27twLOdBVK4UDOVctgYXub0IKwEtxIkkSMLk73Qy8YKag60/3+ib2VkulCF+sp7jL2E8uLQS4xuvI/XHIW2Z02sLw4rfDn3Q0sOJ7Xh1Qcex4ByvcD/kGSSpva7hnUP/IuMHvfi0UjNO8YtardxvbTng9ujgO/+yx215/oXgyWMu0Mpnh1IE73G78e0s8c1q/u6f7Gmz32Xwl3A2+V+N5XuoMOFdqtN2T6bLsoQfFY6nNX9g4y5lh5r3vRD1qEqiJUyeP9Fajn910ZJcdwPr2CGxIZwSDXh8G1LqgqB5ITewNjZl3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(39860400002)(396003)(366004)(86362001)(38100700002)(31696002)(6486002)(8936002)(4744005)(478600001)(5660300002)(316002)(2906002)(8676002)(66476007)(66946007)(54906003)(66556008)(6916009)(4326008)(2616005)(186003)(6512007)(53546011)(41300700001)(26005)(36756003)(31686004)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aWFqcnJXMysvTXhRTHpxcko4Y0R6YjZXN2pHVi9BcFpMdW5qZVkrUG1vUlY5?= =?utf-8?B?d2ZGdEYzRFRWVzJaMDF1eTZlYWx0QnVSdXRoS3B6WEFNMFc4dWFkbm9GNFBw?= =?utf-8?B?eTVXb2NaMkowL1FEOHJZdFNjTG9HaGlydUU1bDJrMmplVTQ4VmJuYjBzaEN0?= =?utf-8?B?bkgwQXlqemFjcG9DeWxVeTVnMkx5TWRwMWFUK3UxTlgxYXRjbkxSdHgyZURo?= =?utf-8?B?MXdBN2dLcjY0ZmlNQUw5ZG9sRHkxYWtTYkFiYVRUaXRxbFk0SkJ5T1RkclB1?= =?utf-8?B?d3daSEx0Tmtsb0w4M0x5ZmZVaDV3c0FvYXYwMGQ2cjUzdDl5dmtDZitFeFJU?= =?utf-8?B?Y3hpZ3pzWUxQdkNQV2M1ZVFHVG9JT1FZQW9vTnEza01uK0wvWUk4aEgwcUk0?= =?utf-8?B?UWZidkhnRDJ2b2NUbkxralhXZHloYVhIeGdRaitWNTQ3ajhCTEVxUEtmQXBK?= =?utf-8?B?eG9rMllieW1OWXZqblpzYVZLUGZJalFTNS85NlliMGU1RWt2TVFiSENwRnlC?= =?utf-8?B?cTFsTU9hYXJvOTRtRElhMTlyUWxIV1g2SEhkYmg3cHM0OXVXeU91THh3dFU4?= =?utf-8?B?RVRBcGNUR2lESVY3Um5wZjlycTQ2QmJIM3VMaTBJbzkvNmp5S05YQVV2bUNU?= =?utf-8?B?TVU3MmtlaHdDc3ZWNzRZaWNmeWR2SEpSMmt6WGEzSHowVi9zd05qK2M5dmZ5?= =?utf-8?B?bGEvV0hwNCtwalFFNzNRcDVaTUwyQ2t3RitoMlJZMlZsOEJXWU9Ca1pYS0FH?= =?utf-8?B?VHpkK3R4V2d4NnpURllQN3FsNXcyQUxCRFU3MVBMWmlhQnZpK0FNVmI5dnZO?= =?utf-8?B?VUdZUlZTcTYzYTRpVlVoOXhoVVo2bUhaOHh5QUdIdjhTWnA5N1Z1Sm9YVnQ3?= =?utf-8?B?Q3ZUaFVrS0FuUUxBOTNnR25NV2NXTEh6Y3NVSHlvNmNqR0lNbCtLOVVla09S?= =?utf-8?B?RUwxVWtQZkJkdEZHTDZ0cnlwbW96RzBDc1M0djc3bVNOVDNPNURBT2hJRk9r?= =?utf-8?B?NHdEa3grUXYzbTMwVXdNZFdnRGFXNzVoUk94cTl5WUFHUERlVmpXTnRyU2tu?= =?utf-8?B?SCtSNlNrc1JTenNQZno1Ukt0TjB2MjhZS21EN1owQzZxZXg5RnB1VHIzUmgv?= =?utf-8?B?a0RmdmIvcXpqSTB4ODVpUkVmVlYrNFphTndUNWN2ZFp3Q2JneDhMekpVMmQw?= =?utf-8?B?N2hkRWp2L0grWGZIbCtqTExIdzdiSUtKVWh2MzdpSklLd1Z5cjJ5aW5wWHZG?= =?utf-8?B?Vlg4WjhqU1RJbThrejE0dGNJYWhiZnVIck5rMHNwWmIwRU9wQ2ZWQ3RNSzFp?= =?utf-8?B?a0lKOEsrRG1sTFUxRE54R0ZGSUU2YjdwY3pRQjUrTVY4dXMvZ3lqY1FnT21s?= =?utf-8?B?OCtvWkxzQkl3L3BTSnJ1eFB6ZG5kMHNlYXdPdlFHa1c1VkF5YkFtM2ZNNWY4?= =?utf-8?B?OEIxb29ZWm9QbzJXcDl5T21XeE5PYkx1NHhzeVlXTkgvK1VnMU5ZRkdVQUxx?= =?utf-8?B?MUp0MDVFYXRFZHdibkJaZ2M1Qjh6V0Z0a2txTzZQRlZXUGNtYi9IQzQrWnlp?= =?utf-8?B?TUExaGV4MkRsRVN0Mk9lSWQ5OEcwTEplVW4yWkdTanhpSEhCWDh4K29yNzhr?= =?utf-8?B?enFLRVptNkJ5ZE1oYTlEYTBLRk9jM01MVFVrUlR1dXlTQXI3Q1VLanFMWEEv?= =?utf-8?B?eWxaSzFvYXp1V01JblF0UTFZZk5CSnYzZkhBbGxEcXZCSjQyaVNMRGw5elg1?= =?utf-8?B?ZENrOTA4Y1lXYWk3cmdMVXEyMVdJckJ5T1RHZVpNTzZYME1VT1pack44SVJk?= =?utf-8?B?Q2tlY1NrUGdhcjRMYWt3bmVGaTl0SjVuNkc3QTVuNGtMSWFJNkZ0aVAzNUhr?= =?utf-8?B?d1c1QzcrRmo4RFFONlFFZnVrRC9LNE5adWxkclRRT0JuaHJmMUtYcm1Sa3FZ?= =?utf-8?B?OWtBdVFwSFRtS09TaFlPN2pxUXNpZUZwanhNR2hkZk81YUttNldLRVZvZmtn?= =?utf-8?B?bGU3K1ZrOVo3RDRaTDRZRGgrUUVwQVhZTUtqaUJmUVFRMG5RSDkyR3c3bVQ2?= =?utf-8?B?aWhlcnVwZkQyV3hwRzlwVENJWEIwRGVjT1lKUDFDcy9kRmFHNXduMndRaTRP?= =?utf-8?Q?JCO7e3MKtXKpHK6Ypj0nDoylH?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44747734-ccd8-4de1-7968-08da6f1036fc X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 14:07:46.0740 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: di/MZ0ewAgaGg/zBUQBAwEH12SiIKs/RY9HNNwfhChTpfUscUWP3TEDyTCs3V1YlTW2Hv12/DRKgiD1fe2N3xQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8622 On 26.07.2022 14:25, Andrew Cooper wrote: > To support CET Shadow Stacks, guard pages changed from being holes to being > read-only. As such, they can be read. > > Moreover, they should be included in the integrity check. As long as they're non-present mappings, I don't think they should be included here, so - not being a native speaker - I'm not sure about "moreover". > Fixes: 60016604739b ("x86/shstk: Rework the stack layout to support shadow stacks") > Signed-off-by: Andrew Cooper Reviewed-by: Jan Beulich You should have included the three TXT reviewers: I would have been curious who, if anyone, would actually have responded. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:22:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:22:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375347.607670 (Exim 4.92) (envelope-from ) id 1oGLSX-0005pj-HY; Tue, 26 Jul 2022 14:22:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375347.607670; Tue, 26 Jul 2022 14:22:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLSX-0005pc-EA; Tue, 26 Jul 2022 14:22:53 +0000 Received: by outflank-mailman (input) for mailman id 375347; Tue, 26 Jul 2022 14:22:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLSW-0005pW-Dt for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:22:52 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130052.outbound.protection.outlook.com [40.107.13.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6e0f743b-0cee-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 16:22:51 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB2747.eurprd04.prod.outlook.com (2603:10a6:3:e1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 14:22:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 14:22:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6e0f743b-0cee-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oJcvpiX0iNuMNtwFflw4zXcDrCKrEUP+EmjOX7nhpzew2Yx1RxAJLkegZRWkZCBDXPZiCkHBWj76vZK4X4h6UUCMR/P6hAXvDH6D4vtR4vKFRVNb2F+Li2hNN/1Oo5tbVXwHHhashS+nPA36Dzb2lpHmX23zMmD8n6UHyp/ofd9DDfU5wadh2O0xW4rDXv7v+/dovkO5d8EbGgCLeQ0ZUOgeAr9zUxHv9sq53fzyt1KQdG6yBbMx7Omt017+PI1vDiL3FJVYGr8bn1YxE8e8EkfFxyvHFEevuPoCfAPlzxJqFJZq6QpPefjI+AsOF1D3xlduwinnxbXkxrH7M1ChJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w5FDg5yIlwKx00AS1KOPVi2ZDa7fNr/Sis7oi5947cg=; b=LgLsXCbqcdZroXZESvi4pM3sqFwrtWIWY4gltAE7YLYF7l0Xiuf0zcXV8OsGOpfDTJJ9Yfs85G/FoqE/bG5WE/ht2yfy61l6+b0/Fq6Asd2yAbmlE96PrISmJ6awD/tXU+yxxBjC1h7QWccm/x1Jo62/kIUbbu37InHcWZ83wKXFz9Q9amSbvyjWn3OCcoqlaqjSbhBGuY41pmbQ9bg0BVlBawAlqnGGPuanVlan/qmYa6nHHVGhBmrzx0M4FnWMAv78X0Iyo3ubcIpJeYOmCkhmCnwpRoDgHWUZGJAusAPdJczCA/s9z3NRRL1IvFyI6p2WNs0fDbG57bSdangxsw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w5FDg5yIlwKx00AS1KOPVi2ZDa7fNr/Sis7oi5947cg=; b=5RwcFZ8gYae8Rigp10RP2P7uC2FMvO4xyKZnr+ubvygTBC3Uu8t1SdQWgaIh5uNym4aMANWxTQJTTPu4x4q01OLhuHLd2arug4Bf56yhx/MfVfrzPpGTNj/1aqAXlJKRPNPJ4t9DVdhT1Nt/Wvo2qUrPfJ5+tAdAQoxC+X+O5T6oqjumSDg1B1LWzVTSvdeJPTaCVyKPY3ZVNbbCgU/uuP5QfeqI5d6YUrgBN1Qi3Vybx/bwxL6/R5fJMo2ZIO20tpi+qCfRSSTmKb/REojpOYuoghdfDfZY8C7Aj/qkmOE0xRyKLt3T7BsXS/dZnSlT+nBK69o9Iv85MsX0c7vBCA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 16:22:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 09/18] x86: introduce abstractions for domain builder Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-10-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-10-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fdd31817-5b17-4247-824e-08da6f125108 X-MS-TrafficTypeDiagnostic: HE1PR0402MB2747:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dx2HS+g4y92rW6KrFahosZ2C/CYRbpgnR637O4wmDDaYzArOnOCpKAbdj66LobcuHCzfR//TkSm5Xe+kllesoQalXnW7mK5anjejM/6jdgUWPfQ0QI4+nLwKWaS6mRQGr8KKK87b/uMcuCyugOJB4WJ3GC8oz+lZ4SBqL3hKUlQjgnhsWlVTrQEgKrcobB+pJxAYt6gQcsEbHNfwi9RhToV64lTU3D6LCB/KbgobhZzUaoOkmzZABDvZhCW+w+kg89WtqwrnrpIr62STdkp49/J7Du8vTR2prJiZ5XuIzzzT3ItVlvgvbzOTsBoamB2P84nPsccVqk0wSW0dJqc+fEx0fMZJ1/5kFC6z4BucbHF9mWKBBeNDRC/SP7v4J9RzNfx8A0n8z6b6D565qSCTY6Od83WE2XdZ6zC9XsWbroehCVRlSxwpzB4tID3UM3NPlwZexog0XadtxLPTxhmG0eXRK/IFSNJG2daWlHsUQsro+RjIBk0QGtNsz6DsBsDk2+TOFBuakyykO33p4qBHNo0Ds3V+MCqsw5Z5V8KUYb2OfwAqZYSlZuxvC5HWsqCSuEAMJ+DfASDEb3ARQaBtOEACiSsEKySSNf8YXc9P4HGTxgQZhzRI7stut1hz9H8psgYPat3tmNsABLQFpJXzx9R5vvicc6fzp5xG5GBp/4/Zm98kPeVRyC5SFuaIiQWKHh7rKaAtgBizLdvj3svCvtlvxEO1K93p748Lr7+vJbwqYyObIti+PRMTEVMSlV0SLAB/2b9bAlv9R3G9/RBRCXzOeqN8OTeLfIzlmS9qar0ZGj0CDNvTrv742hGboZEfjtL4FVqLZntuijd/4f7ztg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(376002)(346002)(136003)(38100700002)(316002)(6916009)(54906003)(36756003)(31686004)(2616005)(186003)(66556008)(6486002)(86362001)(5660300002)(8936002)(26005)(41300700001)(7416002)(4326008)(66476007)(53546011)(2906002)(31696002)(478600001)(6506007)(66946007)(8676002)(6512007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K1JEcy9oQmNzMkJpbmYyVEM0Uy9WU1hZdzB0UkFnY2F6MitHRzRteHBrZm4y?= =?utf-8?B?UzY2bjJSWkZTRnBFZEZNNFIzeVBNbnpMU1VqSitKMCtzVUllUDVsb0hVOFFW?= =?utf-8?B?ZmZRWHU5SndZN2RXS3kvRlhabGhIRWkxdnNRSW5jNkJvNm9CS0tkbjVHSTRS?= =?utf-8?B?Um03SWxNL3JYZS8wUmVIN3BWeUtMNHl6cGNoaENXQnpXdDFLWllGaUtLdlVu?= =?utf-8?B?V1hjZkFtdFRaUEdobnA0ck9kYlgyS09CUHBKOUh1dnZaNDBzTHR0TmY4RWNQ?= =?utf-8?B?bmRpWjJUYy9oZFBUU3RDbmt6SVZuVlBubUZMV24wVy9VNjBhaStOeFRxOXEw?= =?utf-8?B?Wk1Sa3RyYVlBZldqZlNncU5OMnNRQ2twblZtaWJiUVdMdWMrdVQ4dDduWmJO?= =?utf-8?B?STJCTS9IQWFLTU80YVNOTUpYY0dlV2djVXNpbktUY2tjNjJiT3NkVzB2NWlo?= =?utf-8?B?bkE0NWlFSDdKaWIxYjNQSm41VmRna1FrZUJLNHdGWnk2R280TGo0R0Jic3pN?= =?utf-8?B?MkhycmUvSnpEUnBNRkFjSis2UW1RYzdNMVYwS0JFaEgzZnBCajJVemx4NnAx?= =?utf-8?B?Yk5XaW0reXRSRll2V3hNeXFka1Bab0orc3I5WWpBWm5Uam1WZmZoZTlpTzFH?= =?utf-8?B?cmkvdFVCQktwWG9DTjhzanBaNmU0cVlkUHM2VjlyUDdRbnk1RUNNOXdxMkNZ?= =?utf-8?B?OVloUmJCYU5vdlNuMWkrWnB5NlE3YS9Ob3NJMjJ5NysvL3dOS3BOZVVXbzJM?= =?utf-8?B?OFgzcmdZeXB2QVFiUWxqUHd0b3EvY2NTVCs4UWp6aStKa1RTelNPek1rYkky?= =?utf-8?B?OU5TUFp2M1M5T3FPMUtDMFp0cnUyQkNxSlRUNFFTcXV2WG5uN1N4QWNYMTAy?= =?utf-8?B?MXNHRXpndjQxRDY3QUdXVHpoYmNuc2FKVjVjNjh6TTArMEFTMlMrMGFtdGQv?= =?utf-8?B?RmtrYlBmMUNHS243V0JjSmJuSjF6bWJxcmFzY1lYRzVMNE1mN2RaWGZqS0p0?= =?utf-8?B?YmZxcHEvZzFqMVFDNnpQbXdSVndxbEJrbDFQWHViN3FnS0hSWEFYamVvbTA5?= =?utf-8?B?V2ZxMG5QYjd2dWlvWVBqNVNXZ0xZcjJlK01SZjdrckRjeVZySGhRMGdzUnU0?= =?utf-8?B?OHhkaTdxNVVYdzZOczFkTk9DWmdBaU8yLzY0dXQxcVpqMFZPZ0RWcHRUQjNa?= =?utf-8?B?V1REbnFXcHJiS2s3eTlReGlSRmtNb1ZCcW1PSVBmUDhZWUtjVFFxT3VsaVk3?= =?utf-8?B?ZWZLVmxtbVFZc0ltZDRlclZ1eW03dFNHZEZkV2Q1MkdRQnFZQ0hKSjh5a2k2?= =?utf-8?B?QkV4MjNsVWxNMkFpeG5aU0l2Zm84dGhtZkdmVGJ3eUQ1VGU4THRvNG12KzhT?= =?utf-8?B?MnZsb05xUEMwMVdiWHZ4VW5pK2JubXZzMDJKcmM4dHBjSVhKeFh1dk0vVklL?= =?utf-8?B?Rk1jTm5pWks2bEx1V0FiaVZOUEpYdFBKc2xMUHZPMUNMTm52cHNjK0xKVG1y?= =?utf-8?B?WjQ0RW8vM0RSNWFhYTNaNHAzckM5UkhUbGg4aTBOSnhnRXE1NVB2NjJudHIy?= =?utf-8?B?eWNzUzJlSEp0K2gzMHZOejdrRUg2OXpkUCtYWDk5L1FoT3MxMnhPaXBzWlVj?= =?utf-8?B?YlVxaDVJUEtnRVpJRGd5NndCR1ZEUTI5Q1R1cTR5MXQ4VkVLWDRGZkV5SXlJ?= =?utf-8?B?ek9tc2h5aW90ZjFzVGRhU05LUHljcStGY0tuVC8xby9HQzgrTTBLdnNFcE15?= =?utf-8?B?MlhNT0NOVXoycGYvQVc5V3ovQzhWNDFJTk5ONC9ybTF5YmY5LzhUaWVWaHV6?= =?utf-8?B?RE1uZnNCM25NSVhWTFQ5bGZYK1lWa09HY20yZ1FCaStkVlB1ZDNjcGsyYWpH?= =?utf-8?B?VkE4Z0JzWkpiU1NKK3Ercnlrb2prYll3b1pZMHVNYVRkT1pIQnZ5c0tEb2xL?= =?utf-8?B?QTJxSHFkYThFT0lwOW12M2R6UXBzcDNQY1AxSHV4WUI2aGp1Q0N4Y2Q0Mm54?= =?utf-8?B?dFhmMXVaaWdkbEdwRGU2R3JXZWgxcGRBN0QxU2ZUWEZiQTF5L200OWlCY2dj?= =?utf-8?B?Q2dXMFNxNjRKYU9obWR3OWpxYVk0YTFsUWwzZ09PTytsVGIvYTlUUHRKa3A1?= =?utf-8?Q?Ps/wIibHjmVqMluhYgMC9Bj8w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: fdd31817-5b17-4247-824e-08da6f125108 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 14:22:48.7515 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l4/jq1jGL/YydQ1yHs68JdpJKrSekgImeG2IkToEwhHAnfPCWyJuUYviKiDGdrmziEL/Soz406s5N7ZjMdgANQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2747 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/arch/x86/include/asm/bootdomain.h > @@ -0,0 +1,30 @@ > +#ifndef __ARCH_X86_BOOTDOMAIN_H__ > +#define __ARCH_X86_BOOTDOMAIN_H__ > + > +struct memsize { > + long nr_pages; > + unsigned int percent; > + bool minus; > +}; > + > +static inline bool memsize_gt_zero(const struct memsize *sz) > +{ > + return !sz->minus && sz->nr_pages; > +} > + > +static inline unsigned long get_memsize( > + const struct memsize *sz, unsigned long avail) > +{ > + unsigned long pages; > + > + pages = sz->nr_pages + sz->percent * avail / 100; > + return sz->minus ? avail - pages : pages; > +} For both functions I think you should retain the __init, just in case the compiler decides against actually inlining them (according to my observations Clang frequently won't). > +struct arch_domain_mem { > + struct memsize mem_size; > + struct memsize mem_min; > + struct memsize mem_max; > +}; How come this is introduced here without the three respective Dom0 variables being replaced by an instance of this struct? At which point a further question would be: What about dom0_mem_set? > --- /dev/null > +++ b/xen/include/xen/bootdomain.h > @@ -0,0 +1,52 @@ > +#ifndef __XEN_BOOTDOMAIN_H__ > +#define __XEN_BOOTDOMAIN_H__ > + > +#include > +#include > + > +#include > +#include > + > +struct domain; Why the forward decl? There's no function being declared here, and this is not C++. > +struct boot_domain { > +#define BUILD_PERMISSION_NONE (0) > +#define BUILD_PERMISSION_CONTROL (1 << 0) > +#define BUILD_PERMISSION_HARDWARE (1 << 1) > + uint32_t permissions; Why a fixed width type? And why no 'u' suffixes on the 1s being left shifted above? (Same further down from here.) > +#define BUILD_FUNCTION_NONE (0) > +#define BUILD_FUNCTION_BOOT (1 << 0) > +#define BUILD_FUNCTION_CRASH (1 << 1) > +#define BUILD_FUNCTION_CONSOLE (1 << 2) > +#define BUILD_FUNCTION_STUBDOM (1 << 3) > +#define BUILD_FUNCTION_XENSTORE (1 << 30) > +#define BUILD_FUNCTION_INITIAL_DOM (1 << 31) > + uint32_t functions; > + /* On | Off */ > +#define BUILD_MODE_PARAVIRTUALIZED (1 << 0) /* PV | PVH/HVM */ > +#define BUILD_MODE_ENABLE_DEVICE_MODEL (1 << 1) /* HVM | PVH */ > +#define BUILD_MODE_LONG (1 << 2) /* 64 BIT | 32 BIT */ I guess bitness would better not be a boolean-like value (and "LONG" is kind of odd anyway) - see RISC-V having provisions right away for 128-bit mode. > --- /dev/null > +++ b/xen/include/xen/domain_builder.h > @@ -0,0 +1,55 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef XEN_DOMAIN_BUILDER_H > +#define XEN_DOMAIN_BUILDER_H > + > +#include > +#include > + > +#include > + > +struct domain_builder { > + bool fdt_enabled; > +#define BUILD_MAX_BOOT_DOMAINS 64 > + uint16_t nr_doms; > + struct boot_domain domains[BUILD_MAX_BOOT_DOMAINS]; > + > + struct arch_domain_builder *arch; > +}; > + > +static inline bool builder_is_initdom(struct boot_domain *bd) const wherever possible, please. > +{ > + return bd->functions & BUILD_FUNCTION_INITIAL_DOM; > +} > + > +static inline bool builder_is_ctldom(struct boot_domain *bd) > +{ > + return (bd->functions & BUILD_FUNCTION_INITIAL_DOM || > + bd->permissions & BUILD_PERMISSION_CONTROL ); Please parenthesize the operands of &, |, or ^ inside && or ||. > +} > + > +static inline bool builder_is_hwdom(struct boot_domain *bd) > +{ > + return (bd->functions & BUILD_FUNCTION_INITIAL_DOM || > + bd->permissions & BUILD_PERMISSION_HARDWARE ); > +} > + > +static inline struct domain *builder_get_hwdom(struct boot_info *info) > +{ > + int i; unsigned int please when the value can't go negative. > + for ( i = 0; i < info->builder->nr_doms; i++ ) > + { > + struct boot_domain *d = &info->builder->domains[i]; > + > + if ( builder_is_hwdom(d) ) > + return d->domain; > + } > + > + return NULL; > +} > + > +void builder_init(struct boot_info *info); > +uint32_t builder_create_domains(struct boot_info *info); Both for these and for the inline functions - how is one to judge they are (a) needed and (b) fit their purpose without seeing even a single caller. And for the prototypes not even the implementation is there: What's wrong with adding those at the time they're actually implemented (and hopefully also used)? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:24:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:24:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375351.607681 (Exim 4.92) (envelope-from ) id 1oGLTi-0006RB-07; Tue, 26 Jul 2022 14:24:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375351.607681; Tue, 26 Jul 2022 14:24:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLTh-0006R4-SM; Tue, 26 Jul 2022 14:24:05 +0000 Received: by outflank-mailman (input) for mailman id 375351; Tue, 26 Jul 2022 14:24:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLTg-0006Qm-8O for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:24:04 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 97432ca5-0cee-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 16:24:02 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 97432ca5-0cee-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658845441; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=HxHygnpvgc7Ss4bF6OSZ6XL9TwL7xK96HAGSXOTqMLI=; b=f00ORTTUSGoq52UWPu/6CDpFf34k3E7Zej6/mlbFqt9Ly6pPn6T2RTHr bS2nRuGOz+d/g/ftQM8ldq1wZLvjjGpsDyiHB35a4n51UbVJEvFi/zTQE eO+HcC4J6JNP/Sh2MObWhmc/5xIt/Qjnj3fuNPj74aoezldYSKF51Uy3L s=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76451401 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GVHju6xD61E8W3nbwU56t+dexirEfRIJ4+MujC+fZmUNrF6WrkUPm DBKDzqFPPjZYTGjKIhwbY3k8BsBuZXWzYNnTAFq/CAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb90ky5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1CS3ARDYM2/d9TOllLz dMgORICciic0rfeLLKTEoGAh+wmJcjveogepmth3XfSCvNOrZLrGvuQo4UChXFp254ITa22i 8kxMFKDaDzpZRFVN0hRI5U5hOqy3VH0ciFCqULTrq0yi4TW5FMvjOW0bIKMEjCMbd1qmVvHv k38xlu6DQhKBYOjijW6z1v504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTg9O0l0q/UNJ3M FEP92wlqq1a3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9ZTWs0YeagzSLHRMtKFctXT4mQhc9/Iy2yG0stS4jXuqPAYbs0IClSWmom WvTxMQtr+5N1JBWjs1X6XiC2mvx/caRE2bZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/5nzvp5pyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN5FMOu8MKbCv1MPEfj2eN5yMClPOIKDgYfqqMMoomjmZZL2drAx2ClWbPhjuwwSDAYIk0O IuBcNbEMEv2/Z9PlWPuL89AgOBD+8zL7TmMLXwN50j4jOH2ib/8YettDWZimchitPna+lqEr ocAXyZIoj0GONDDjuDs2dZ7BTg3wbITX/gad+Q/mja/Hzdb IronPort-HdrOrdr: A9a23:ogktEqoFsoa/Q4IKFEz9jUcaV5oneYIsimQD101hICG8cqSj+f xG+85rsiMc6QxhPE3I9urhBEDtex/hHP1OkOws1NWZLWrbUQKTRekIh+bfKlXbakvDH4VmtJ uIHZIQNDSJNykZsfrH X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76451401" From: Andrew Cooper To: Xen-devel CC: Andrew Cooper , Jan Beulich , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] xen/check-endbr.sh: Explain the purpose of the script Date: Tue, 26 Jul 2022 15:23:28 +0100 Message-ID: <20220726142328.12246-1-andrew.cooper3@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Roger Pau Monné CC: Wei Liu --- xen/tools/check-endbr.sh | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/tools/check-endbr.sh b/xen/tools/check-endbr.sh index b97684ac25e9..bf153a570db4 100755 --- a/xen/tools/check-endbr.sh +++ b/xen/tools/check-endbr.sh @@ -2,6 +2,15 @@ # # Usage ./$0 xen-syms # +# When CET-IBT (Control-flow Enforcement Technology, Indirect Branch Tracking) +# is active, ENDBR instructions mark legal indirect branch targets in the +# .text section. +# +# However x86 is a variable length instruction set so the same byte pattern +# can exist embedded in other instructions, or crossing multiple instructions. +# This script searches .text for any problematic byte patterns which aren't +# legitimate ENDBR instructions. +# set -e # Pretty-print parameters a little for message -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:44:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:44:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375363.607692 (Exim 4.92) (envelope-from ) id 1oGLn7-0000dL-JN; Tue, 26 Jul 2022 14:44:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375363.607692; Tue, 26 Jul 2022 14:44:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLn7-0000dE-GL; Tue, 26 Jul 2022 14:44:09 +0000 Received: by outflank-mailman (input) for mailman id 375363; Tue, 26 Jul 2022 14:44:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLn7-0000d8-5b for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:44:09 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 65d3fd7a-0cf1-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 16:44:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65d3fd7a-0cf1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658846647; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=PDLwc3Aco3iQCsS4JF/aEn7uDmViPWgey2FgpMpNTbs=; b=accb0OsVUFzUw1VeQPohV+GcidhaPByKUTR9p5IlhvpJLrj2/xPQ8IzI lIDwyJfIJmClXo6mgfbQ0jnIfkclGgCfVmLIHUduQORitIHyOgR3vymKF hkC4KqZT1/OSQ2spCIj4IiE5Vzhp85aaghH3zAQ2+QRS0iMqosKMctZ78 E=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76657825 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:hTtjr6pVw5ACCCxTVd5RBq+9RR5eBmJ0ZRIvgKrLsJaIsI4StFCzt garIBmDM66LY2ujL953aYm0oEgHvsLRy99kQAs/pS1gRCka9ZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU89vhpE1EWr ccaFw4hRRWFl/CU+O60H7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8aBIw/mqG0gWP4cBVTqU6PpLpx6G/WpOB0+OezboeKKobXLSlTtmG9n D/5xEbbOzhZFcLHmAvG8y6OhvCayEsXX6pNTeblp5aGmma72Wg7GBAQE1yhrpGRiESzRtZeI Ew84Tc1oO4580nDZsnwWVi0rWCJujYYWsFMCKsq5QeV0K3W7g2FQG8eQVZ8hMcO7ZFsA2Zwj xnQwo2vVWcHXKCppWy10ruKsyGCYXAuL1A8SQQBSxsXweG/r9Rm5v7QdeqPAJJZn/WsR2ygk 2jS9nNn71kApZVVjvvmpDgrlxrp/8GUFVBtu207S0r/tmtEiJiZi5tEALQxxdJJN86nQ1aIp xDocODOvblVXflheMFgKdjh/Y1FBN7faVUweXY1Q/EcG82FohZPh7x47jBkP1tOOc0ZYzLva 0K7kVoPuc8MYyfzPf8oPtzZ5yEWIU/ITI+NaxwpRoAWPsgZmPGvp0mCmnJ8L0iyyRNxwMnTy L+QcNq2DGZyNJmLOAGeHr5FuZd2l39W+I8mbcqkp/hR+ebBOSX9pHZsGAfmU93VG4vf+F+Lq YkOaprVo/idOcWnChTqHUcoBQhiBRAG6Vre8qS7qsbrztJaJVwc IronPort-HdrOrdr: A9a23:VkYgAaGQmTti8n8HpLqE5MeALOsnbusQ8zAXP0AYc3Jom6uj5q eTdZUgpHvJYVkqOE3I9ertBEDiewK4yXcW2/hzAV7KZmCP0wHEEGgL1/qF/9SKIUzDH4Bmup uIC5IOauHNMQ== X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76657825" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH] x86/msr: fix X2APIC_LAST Date: Tue, 26 Jul 2022 15:43:36 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The latest Intel manual now says the X2APIC reserved range is only 0x800 to 0x8ff (NOT 0xbff). The AMD manual documents 0x800-0x8ff too. There are non-X2APIC MSRs in the 0x900-0xbff range now: e.g. 0x981 is IA32_TME_CAPABILITY, an architectural MSR. The new MSR in this range appears to have been introduced in Icelake, so this commit should be backported to Xen versions supporting Icelake. Backport: 4.13+ Signed-off-by: Edwin Török --- xen/arch/x86/include/asm/msr-index.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 8cab8736d8..1a928ea6af 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -148,7 +148,7 @@ #define MSR_INTERRUPT_SSP_TABLE 0x000006a8 #define MSR_X2APIC_FIRST 0x00000800 -#define MSR_X2APIC_LAST 0x00000bff +#define MSR_X2APIC_LAST 0x000008ff #define MSR_X2APIC_TPR 0x00000808 #define MSR_X2APIC_PPR 0x0000080a -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:46:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:46:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375368.607703 (Exim 4.92) (envelope-from ) id 1oGLpb-0001GQ-0N; Tue, 26 Jul 2022 14:46:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375368.607703; Tue, 26 Jul 2022 14:46:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLpa-0001GJ-Tj; Tue, 26 Jul 2022 14:46:42 +0000 Received: by outflank-mailman (input) for mailman id 375368; Tue, 26 Jul 2022 14:46:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLpZ-0001GB-JZ for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:46:41 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2065.outbound.protection.outlook.com [40.107.22.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c18635a4-0cf1-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 16:46:40 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB2910.eurprd04.prod.outlook.com (2603:10a6:800:b6::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 14:46:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 14:46:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c18635a4-0cf1-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D96nW4eesnmLfu3i+wfdS+tK0b2A81FG82+/AYgoRYYHemcXG0efT2HdzuzcQXOWrtln/YJL5s8j2hTPvnxK/57skzv0PcCGn0bkmg67YDkYkA0BjJZ9XNdExpUa6kH34j8HA9l8EsPcmf1a7NkEImX64jec6UQRKo16K1aZ2bWc6+fMEXCGqRQXIPSSYkbJpBqa3xSIwalkNg4pgREZoidLJSQvfcY21vedVB3EXa+TOxH5sdJKVOli8sOM5DDXtAlcTBiPyQG2h2NwGbRZeZ8L4nWeFtCjnBZWZ2fR62yf/Th2Qh9OL9eQZsc7kap1QTvCPKrmFyeSBVrnBPyVOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=47otvH0QGOxetC+Ve6b3lJi2AEIUHoi3xmK9BI04e5k=; b=CaMNIGnvSlnrQRw54NdquMdjAtZxLljY5KOM/yPnhoyafDobYbvwSSJsXb0mt0FSLI50Jh4DxfEs0UMtMjGZaK6Sna7CKg3cSGZwd5dwgH0laFmtCy0HTIpO4BS+s0EM7/ybGoWx2SNoUO2IjxBKJzJAUbtCmVEl1/G/ly0dCSIGWWIUjUWjLTd2iYZlcCTJjEQz6PiEJz+HfrKezX+CK91g0AUBeYoDTuDuQ7rIOtkNVtejbDGPM0sbQCSiT1byedSYBfmND84GeNpiVuWmrK1MswUkY+zn+AoBBhpEnXJKRszT3i55xA9aKOMc/nCpgTgCADVhA9qqbZunMip3tw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=47otvH0QGOxetC+Ve6b3lJi2AEIUHoi3xmK9BI04e5k=; b=u0Cu6pR6cT9kSAAUzQ9lU65lj7hqonWatFct0cfI2Xt269id2zmhpJBSjNJcNygCMF9jLfc2L4PS6CGtqBV83dzoIJvcK7Vo0uqD/kgSryVujQOd+ip9MzupRUiDuax4vMIHjY+/EFHMuQDOCVfjBvw+nZK71ft2bKDLpwCrBg1sQaZSWGaTMeKL0WyRraqh+7cCoO4q9kCkkgJ37FdgCwJd5K9o/AercqipMiT4Kknika+XyeARLMOYuvY3wdLQqIjJNb/SgNe4ME+DYrCsBP7V8yDDh33YYjllQyZeSVRA7cWQUKnpNM6SUYpETaGJTPk4s7PN7Y1IowRa7SYttA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <257e465e-b991-de77-1065-c4e8c7d61461@suse.com> Date: Tue, 26 Jul 2022 16:46:34 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 10/18] x86: introduce the domain builder Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-11-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-11-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0012.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0ad8360e-c67f-43ec-44ed-08da6f15a441 X-MS-TrafficTypeDiagnostic: VI1PR0402MB2910:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: I/LIiXfMO5vXGruxnZusyosIx03a2uZMaRGBCWxvbl1L7wmUF4El+aP8IYUcFWai7Ft53JjqFTXhYciOIj6yWGBElgwKJzwjHWhOqfUsGMJHQZfl1OZ1WNo8DzafmJ3PDJY0RBp9HEueRuFpLcsRIoNGt+loHho/ICQdElZQAG6UtUNA4U2i4KCHOrQquacYVdSMkjByC62AOasLn0CiPPe0tBw6D4VVoI1CaleNgmM1HujpEebtWzArIUUnNQAMutHFZ1VC4I4Fz/juQB97X2H39alwlBFUnnQkyo144ql+t9j7o05+RrbgYWEca6QK2N7l7zS5OZ4p6dVZs0MVCDLYdNHPdN9xE8PvoWbypRvOY+pwnNDFVXK1zhpWKh74iYV5mJMtbF41Pwji3CRmCbN4XyBj13ZH5s3Zo5JqPd3q5lQZPq3HCREU79GhOC+MrBSOJvaebqF7YPJTCk0L1QspksI4AaCvNVCxtuqwUXvkEIhZeZvAiYHPX9xsxk5ijvMDsrNxmrsOe1IdzYQX2f5FXsZLtaLr2VrQF0kURByf1rtomw0xfkAyLDxlKMkgopd50M8knsKlDq11o9c1bFG/f34HNH1i+SkKVoe+TV8hF9SfrmoUaJ9yKJKpFOBxy4R3sH8wSRKOOgFtX6yR8LYzqUTarlln6AK+Y2uHqmZkN0XbiWvADePQEUp6cFK9eHXuFkE2/MvB+Q2nKVnYGty2sypCznBGrAtjX10uqrKfyEB5SgrtWRCG5MhwuUQonqtU0Tx9LDSN4szEtiuApmtph+zZzeyBmgfbd/F1TjEKJuRHDS4I+Vjz9wYsvYddPomFK/+bZ+Zyv+x2HXCxtA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(136003)(39860400002)(366004)(376002)(2616005)(31696002)(38100700002)(6486002)(53546011)(6506007)(6512007)(26005)(7416002)(86362001)(30864003)(478600001)(5660300002)(41300700001)(8936002)(186003)(83380400001)(2906002)(316002)(31686004)(36756003)(8676002)(6916009)(54906003)(66946007)(66556008)(66476007)(4326008)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OGZnMjVMSHNZdksvRDNrV0ZQS3JLK2tYTlRxb25FdTAvdTlkRTFxbFlGM0w2?= =?utf-8?B?Y011amtmRXMxWXhUZ1MvRHlCcFZuank2T2krZldORDZ4MVExS1pPUURad0lG?= =?utf-8?B?K24vTExnZ3laOXBrcWZsWXNoSWo0TDNhRWl1L0xoUWxZdGR6Y0UzaWRrQUpI?= =?utf-8?B?d25KdjhMN0drYXh1MGhIMUNYUHg5K2VBOSsrdEFUNlQrQktrbDNBTGxXYUJL?= =?utf-8?B?Rng3Lzg5bkVDQ3c4NFoyQlVXUWhLS1lmQzVZaUpOZm1RRzV3NkJwYmN4aGxD?= =?utf-8?B?NmV1QnlOMHpSdTR5eEV4TWlITHJadjl0ZktDZVVoaHBMbEYwSFFkdTRnVXhm?= =?utf-8?B?VFdQdUcyaGVZZUJMZUZveDlwM1NUeXZFNEhzQm1rQnlqWlVFZ2NiaWNGWWZ5?= =?utf-8?B?bGhISE5VZG1ub2ZLMmpEaFVJTDFYeE9DWkhVY1ZzVGNMYXVESkUyZDJQSWMz?= =?utf-8?B?RThFSkpYT05QMlZWRGZ1R29QZXZpeDIxWUVIZE5aNUw3LzZmcjNZWGVVNVBN?= =?utf-8?B?TmJrMnFjVTVxN1ZPNk13Zy91UUZoYjNZRVVTMkJ1NFVla3hvYi9wa0NWc2pm?= =?utf-8?B?SndRY1JXbjlad1ZpQlJtd3JPWWZKVDR4SThIaldYME1rcUcxYlpSZ0xnWmN1?= =?utf-8?B?VWVYZDMwenJSWTVJcGRaRysyRnVCNjBHeEVtd3hwOUpOd25ORjFuR3h2ajJR?= =?utf-8?B?UkEvWUxCOFVsenlJWWJwN3pJbWxiTVk0ekU5ZzVhamxjeHM1UFV6NXoxWUZR?= =?utf-8?B?MzdUa01BSmxmbEJRTlZxODJyU1RkZXZCZldWeDg0MGxzY0xsVFgrVkxRejNM?= =?utf-8?B?NGkxdllWTHhGT2VoQkpsSkNQODF5ckRLOEo3NTcyYnV5c0ZaUE5FL21Bb3kx?= =?utf-8?B?MU0xNFFtaTd5WE8ybkhXckJxTW1Yb2M1dGErck1wZjZTQTRENWxKZ1VmTXpj?= =?utf-8?B?VXN0dlcrekF2M1dndHJMOHJZK1FtZEM5MjNRTUpjYXJuK2dEdy90NVhQVTQ2?= =?utf-8?B?bHo5d3hiMzdIRUdSRFk5V2FDdmx6dVMzN1UrbDZtUUpOL3U4QUdmN3kvclBX?= =?utf-8?B?Q3JocjNOT0s4dmRqbmZjeElERm9YcWZuWWYwNGRkM0dVL21lc1FNV2hJTUN3?= =?utf-8?B?eU1WbFkzVFVGR0c4anZ3LzdIMTNLR2N4eVlFOUwzaG1KblRJait4VGZ5TCtm?= =?utf-8?B?K1kvSzlDR0labFp1S0tPOFNhQThaN1N6aEdaM1Z6eVBSOVVhTFZSdHZHYitv?= =?utf-8?B?RnZKVGZHck4rUnhFQVNtSDl1clhyR21pMUNCSG9aNGtpQXdOVERUUXg3cTFD?= =?utf-8?B?UmRpMlpCQUo5Q0RIQXVvek5iL0VtQ2FCRTBNdFYreDgzTWhRSURNWFdRclZX?= =?utf-8?B?cjh2SllPTEJ6VElNd2toaW05WW5PdHRpVjE4N0owQThMYVllWGU4djE5bDNN?= =?utf-8?B?QW9WNFpZMDdBRHZoRHFZbTNURTA2SHlodTYvRGZUTitKRnNZVGU5SmUrMHFp?= =?utf-8?B?U0htVllIWFBSS1JDcVNOdHFWNXdLbEM0RG16VThjZk8zY3M2NzJ4aWJ6Sko2?= =?utf-8?B?VUNhVFRVOERkMUNGc1crWWIyaiswNENIVUJmZGpFQ2swb1BYYkR0aXVrNGxF?= =?utf-8?B?QUlBUmt5R0trd3UzZFNlVlJGWDhsUW5nMnpwZlgxREtZQk9vNlZGVTdlWnRo?= =?utf-8?B?KzVKZ0F4c1VzblQ5YkdqY2pSOHFCRHFXNm9BdU1qbndwY24yQUhYdGp1d1Bj?= =?utf-8?B?OG5UY2FncEZmNk1MK3UvQm42RXQ4V1d1UUJOOTUwT1NzUDl0b2pVWXgxK3Fi?= =?utf-8?B?ODRzcGtVRnJVNWN1bVhTdFpSSkNzakJGb2FwQkpjNUJyd2NSQ1BJendJS3dn?= =?utf-8?B?TDNnUzgwVjk3U0xEZWQxVlMweWJCdDMveXNKb2VoNmJVbnpvZ0FXVHNEYXlX?= =?utf-8?B?dGY2c2dpcHVlc2RYcENRZ0ZGMXVtRmVkSWJNdjluaU14M3M2UUFTb2VSYWRH?= =?utf-8?B?MWczNWE2d2U2Y2ZlWkJpY2dHaEFhcm1MNm5EUFFWYUhXVUZMQ1kyKy8yYXJm?= =?utf-8?B?di9sbzhYUHVuVm92UTdZL1BFdlFPUUJwQ0FHVUV5bFQ0bTlhQWVTbVljZXJm?= =?utf-8?Q?a77TkFu/vbsm12rrJ2Xv4gedf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0ad8360e-c67f-43ec-44ed-08da6f15a441 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 14:46:36.7864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +mYts91uqzy9E0+m55zpY6+35W6iVSPyKr2f34iXJJUip9pnSb+zqNB05TTGYnqciJpkJbMQLjGKqhtfCFDQvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2910 On 06.07.2022 23:04, Daniel P. Smith wrote: > This commit introduces the domain builder configuration FDT parser along with > the domain builder core for domain creation. To enable domain builder to be a > cross architecture internal API, a new arch domain creation call is introduced > for use by the domain builder. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark > --- > xen/arch/x86/setup.c | 9 + > xen/common/Makefile | 1 + > xen/common/domain-builder/Makefile | 2 + > xen/common/domain-builder/core.c | 96 ++++++++++ > xen/common/domain-builder/fdt.c | 295 +++++++++++++++++++++++++++++ > xen/common/domain-builder/fdt.h | 7 + > xen/include/xen/bootinfo.h | 16 ++ > xen/include/xen/domain_builder.h | 1 + > 8 files changed, 427 insertions(+) With this diffstat - why the x86: prefix in the subject? Also note the naming inconsistency: domain-builder/ (preferred) vs domain_builder.h (adjustment would require touching earlier patches). > --- a/xen/arch/x86/setup.c > +++ b/xen/arch/x86/setup.c > @@ -1,4 +1,6 @@ > +#include > #include > +#include > #include > #include > #include > @@ -826,6 +828,13 @@ static struct domain *__init create_dom0(const struct boot_info *bi) > return d; > } > > +void __init arch_create_dom( > + const struct boot_info *bi, struct boot_domain *bd) > +{ > + if ( builder_is_initdom(bd) ) > + create_dom0(bi); > +} You're not removing any code in exchange - is Dom0 now being built twice? Or is the function above effectively dead code? > --- a/xen/common/Makefile > +++ b/xen/common/Makefile > @@ -72,6 +72,7 @@ extra-y := symbols-dummy.o > obj-$(CONFIG_COVERAGE) += coverage/ > obj-y += sched/ > obj-$(CONFIG_UBSAN) += ubsan/ > +obj-y += domain-builder/ At least as long as all of this is still experimental I would really like to see a way to disable all of it via Kconfig. > --- /dev/null > +++ b/xen/common/domain-builder/core.c > @@ -0,0 +1,96 @@ > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "fdt.h" > + > +static struct domain_builder __initdata builder; > + > +void __init builder_init(struct boot_info *info) > +{ > + struct boot_domain *d = NULL; > + > + info->builder = &builder; > + > + if ( IS_ENABLED(CONFIG_BUILDER_FDT) ) > + { > + /* fdt is required to be module 0 */ > + switch ( check_fdt(info, __va(info->mods[0].start)) ) Besides requiring fixed order looking inflexible to me, what guarantees there is at least one module? (Perhaps there is, but once again - without seeing where this function is being called from, how am I to judge?) > + { > + case 0: > + printk("Domain Builder: initialized from config\n"); > + info->builder->fdt_enabled = true; > + return; > + case -EINVAL: > + info->builder->fdt_enabled = false; > + break; Aiui this is the case where no FDT is present. I'd strongly suggest to use a less common / ambiguous error code to cover that case. Maybe -ENODEV or -EOPNOTSUPP or ... > + case -ENODATA: ... -ENODATA, albeit you having that here suggests this has some other specific meaning already. > + default: > + panic("%s: error occured processing DTB\n", __func__); > + } > + } > + > + /* > + * No FDT config support or an FDT wasn't present, do an initial > + * domain construction > + */ > + printk("Domain Builder: falling back to initial domain build\n"); > + info->builder->nr_doms = 1; > + d = &info->builder->domains[0]; > + > + d->mode = opt_dom0_pvh ? 0 : BUILD_MODE_PARAVIRTUALIZED; > + > + d->kernel = &info->mods[0]; > + d->kernel->kind = BOOTMOD_KERNEL; > + > + d->permissions = BUILD_PERMISSION_CONTROL | BUILD_PERMISSION_HARDWARE; > + d->functions = BUILD_FUNCTION_CONSOLE | BUILD_FUNCTION_XENSTORE | > + BUILD_FUNCTION_INITIAL_DOM; Nit: Indentation. > + d->kernel->arch->headroom = bzimage_headroom(bootstrap_map(d->kernel), > + d->kernel->size); bzimage isn't an arch-agnostic concept afaict, so I don't see this function legitimately being called from here. And nit again: Indentation. (And at least one more further down.) > + bootstrap_map(NULL); > + > + if ( d->kernel->string.len ) > + d->kernel->string.kind = BOOTSTR_CMDLINE; > +} > + > +uint32_t __init builder_create_domains(struct boot_info *info) > +{ > + uint32_t build_count = 0, functions_built = 0; > + int i; > + > + for ( i = 0; i < info->builder->nr_doms; i++ ) > + { > + struct boot_domain *d = &info->builder->domains[i]; Can variables of this type please not be named "d", but e.g. "bd"? > + if ( ! IS_ENABLED(CONFIG_MULTIDOM_BUILDER) && > + ! builder_is_initdom(d) && Nit: Stray blanks after ! . > --- /dev/null > +++ b/xen/common/domain-builder/fdt.c > @@ -0,0 +1,295 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#include "fdt.h" > + > +#define BUILDER_FDT_TARGET_UNK 0 > +#define BUILDER_FDT_TARGET_X86 1 > +#define BUILDER_FDT_TARGET_ARM 2 > +static int __initdata target_arch = BUILDER_FDT_TARGET_UNK; > + > +static struct boot_module *read_module( > + const void *fdt, int node, uint32_t address_cells, uint32_t size_cells, > + struct boot_info *info) > +{ > + const struct fdt_property *prop; > + const __be32 *cell; > + struct boot_module *bm; > + bootmodule_kind kind = BOOTMOD_UNKNOWN; > + int len; > + > + if ( device_tree_node_compatible(fdt, node, "module,kernel") ) > + kind = BOOTMOD_KERNEL; > + > + if ( device_tree_node_compatible(fdt, node, "module,ramdisk") ) > + kind = BOOTMOD_RAMDISK; > + > + if ( device_tree_node_compatible(fdt, node, "module,microcode") ) > + kind = BOOTMOD_UCODE; > + > + if ( device_tree_node_compatible(fdt, node, "module,xsm-policy") ) > + kind = BOOTMOD_XSM; > + > + if ( device_tree_node_compatible(fdt, node, "module,config") ) > + kind = BOOTMOD_GUEST_CONF; > + > + if ( device_tree_node_compatible(fdt, node, "module,index") ) > + { > + uint32_t idx; > + > + idx = (uint32_t)device_tree_get_u32(fdt, node, "module-index", 0); Why the cast? > +static int process_domain_node( __init? > + const void *fdt, int node, const char *name, int depth, > + uint32_t address_cells, uint32_t size_cells, void *data) > +{ > + struct boot_info *info = (struct boot_info *)data; > + const struct fdt_property *prop; > + struct boot_domain *domain; > + int node_next, i, plen; > + > + if ( !info ) > + return -1; > + > + if ( info->builder->nr_doms >= BUILD_MAX_BOOT_DOMAINS ) > + return -1; > + > + domain = &info->builder->domains[info->builder->nr_doms]; > + > + domain->domid = (domid_t)device_tree_get_u32(fdt, node, "domid", 0); > + domain->permissions = device_tree_get_u32(fdt, node, "permissions", 0); > + domain->functions = device_tree_get_u32(fdt, node, "functions", 0); > + domain->mode = device_tree_get_u32(fdt, node, "mode", 0); > + > + prop = fdt_get_property(fdt, node, "domain-uuid", &plen); > + if ( prop ) > + for ( i=0; i < sizeof(domain->uuid) % sizeof(uint32_t); i++ ) > + *(domain->uuid + i) = fdt32_to_cpu((uint32_t)prop->data[i]); > + > + domain->ncpus = device_tree_get_u32(fdt, node, "cpus", 1); > + > + if ( target_arch == BUILDER_FDT_TARGET_X86 ) > + { > + prop = fdt_get_property(fdt, node, "memory", &plen); > + if ( prop ) > + { > + int sz = fdt32_to_cpu(prop->len); > + char s[64]; > + unsigned long val; > + > + if ( sz >= 64 ) > + panic("node %s invalid `memory' property\n", name); > + > + memcpy(s, prop->data, sz); > + s[sz] = '\0'; > + val = parse_size_and_unit(s, NULL); > + > + domain->meminfo.mem_size.nr_pages = PFN_UP(val); > + domain->meminfo.mem_max.nr_pages = PFN_UP(val); > + } > + else > + panic("node %s missing `memory' property\n", name); > + } > + else > + panic("%s: only x86 memory parsing supported\n", __func__); > + > + prop = fdt_get_property(fdt, node, "security-id", > + &plen); > + if ( prop ) > + { > + int sz = fdt32_to_cpu(prop->len); > + sz = sz > BUILD_MAX_SECID_LEN ? BUILD_MAX_SECID_LEN : sz; > + memcpy(domain->secid, prop->data, sz); > + } > + > + for ( node_next = fdt_first_subnode(fdt, node); > + node_next > 0; > + node_next = fdt_next_subnode(fdt, node_next)) > + { > + struct boot_module *bm = read_module(fdt, node_next, address_cells, > + size_cells, info); > + > + switch ( bm->kind ) > + { > + case BOOTMOD_KERNEL: > + /* kernel was already found */ > + if ( domain->kernel != NULL ) > + continue; > + > + bm->arch->headroom = bzimage_headroom(bootstrap_map(bm), bm->size); > + bootstrap_map(NULL); > + > + if ( bm->string.len ) > + bm->string.kind = BOOTSTR_CMDLINE; > + else > + { > + prop = fdt_get_property(fdt, node_next, "bootargs", &plen); > + if ( prop ) > + { > + int size = fdt32_to_cpu(prop->len); > + size = size > BOOTMOD_MAX_STRING ? > + BOOTMOD_MAX_STRING : size; > + memcpy(bm->string.bytes, prop->data, size); > + bm->string.kind = BOOTSTR_CMDLINE; > + } > + } > + > + domain->kernel = bm; > + > + break; > + case BOOTMOD_RAMDISK: > + /* ramdisk was already found */ > + if ( domain->ramdisk != NULL ) > + continue; > + > + domain->ramdisk = bm; > + > + break; > + case BOOTMOD_GUEST_CONF: > + /* guest config was already found */ > + if ( domain->configs[BUILD_DOM_CONF_IDX] != NULL ) > + continue; > + > + domain->configs[BUILD_DOM_CONF_IDX] = bm; > + > + break; > + default: > + continue; > + } For larger switch() statements please have blank lines between non-fall- through case blocks. > +/* check_fdt > + * Attempts to initialize hyperlaunch config > + * > + * Returns: > + * -EINVAL: Not a valid DTB > + * -ENODATA: Valid DTB but not a valid hyperlaunch device tree > + * 0: Valid hyperlaunch device tree > + */ > +int __init check_fdt(struct boot_info *info, void *fdt) > +{ > + int hv_node, ret; > + > + ret = fdt_check_header(fdt); > + if ( ret < 0 ) > + return -EINVAL; > + > + hv_node = fdt_path_offset(fdt, "/chosen/hypervisor"); > + if ( hv_node < 0 ) > + return -ENODATA; > + > + if ( !device_tree_node_compatible(fdt, hv_node, "hypervisor,xen") ) > + return -EINVAL; > + > + if ( IS_ENABLED(CONFIG_X86) && > + device_tree_node_compatible(fdt, hv_node, "xen,x86") ) > + target_arch = BUILDER_FDT_TARGET_X86; > + else if ( IS_ENABLED(CONFIG_ARM) && > + device_tree_node_compatible(fdt, hv_node, "xen,arm") ) > + target_arch = BUILDER_FDT_TARGET_ARM; > + > + if ( target_arch != BUILDER_FDT_TARGET_X86 && > + target_arch != BUILDER_FDT_TARGET_ARM ) > + return -EINVAL; So you'd happily accept BUILDER_FDT_TARGET_ARM on x86 or BUILDER_FDT_TARGET_X86 on Arm? And there's no distinction between Arm32 and Arm64? > --- /dev/null > +++ b/xen/common/domain-builder/fdt.h > @@ -0,0 +1,7 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef COMMON_BUILDER_FDT_H > +#define COMMON_BUILDER_FDT_H > + > +int __init check_fdt(struct boot_info *info, void *fdt); > +#endif Nit: Please put another blank line before #endif. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:48:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:48:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375376.607714 (Exim 4.92) (envelope-from ) id 1oGLrb-00020O-Gn; Tue, 26 Jul 2022 14:48:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375376.607714; Tue, 26 Jul 2022 14:48:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLrb-00020H-CF; Tue, 26 Jul 2022 14:48:47 +0000 Received: by outflank-mailman (input) for mailman id 375376; Tue, 26 Jul 2022 14:48:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLrZ-00020B-WD for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:48:46 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2050.outbound.protection.outlook.com [40.107.22.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b7aa94c-0cf2-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 16:48:43 +0200 (CEST) Received: from AS8PR07CA0044.eurprd07.prod.outlook.com (2603:10a6:20b:459::17) by AM0PR08MB3508.eurprd08.prod.outlook.com (2603:10a6:208:e1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 14:48:41 +0000 Received: from AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:459:cafe::13) by AS8PR07CA0044.outlook.office365.com (2603:10a6:20b:459::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Tue, 26 Jul 2022 14:48:41 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT061.mail.protection.outlook.com (10.152.16.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 14:48:40 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Tue, 26 Jul 2022 14:48:40 +0000 Received: from 2b7f6ee6c0c1.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id BC06DE17-B273-4434-9119-A3956C0BA213.1; Tue, 26 Jul 2022 14:48:33 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 2b7f6ee6c0c1.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 14:48:33 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM6PR08MB4373.eurprd08.prod.outlook.com (2603:10a6:20b:70::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Tue, 26 Jul 2022 14:48:32 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 14:48:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b7aa94c-0cf2-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=CwbMs2aKmxuFMuEqHBiJnyP8ZdUEzpBZ6Ic6ZJrEMjTl9YLa9GkUtLw68UvkKYTCUwxGaguCexSrFytIVJKi0s6YDIFbYNlcX0mwKsGW7CTlRVlmArpOIIVSVFPaiM8tA0iw4ffkRzjlGrIPhPeuKQY88unaBBZivVh+aEOhn1E7uaIhc0NG9Y5ydQ7/cbuAV1SeubVaMrnXrCc92xGX5HIaGYzgVXQ/kx3tXMF95flrXxpmqZz5jTqhZ039ulKvcIwuOYpgJXJZ64rdaDmpMIOlRtYMzGxbCSrMJz5cuZ++jGyIsWBf0coUGd9xYe3a2GK77QGb/zr6LULUxJ4qTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2Sdvd7kpsWyMQqQOIsNw/DIvnnUJ/yTjMJS9l6doAI=; b=jSI34CsAVB+94rqmYSLgOCoLVwTT9rZyMNeMReaZNVUvtIt6MriubDTdRnU2WSP/J6woDznctj96NDo1oVsSCqkQQ756hwauPl7dLRFigwdLEyCbEw30UKhnYo8qwgH3WLp3sD2AivZHEAun9LETo14KjJfd4h0aeaReZw9N5BOi1cgDfSIS750DBN7EdBB+idhDq8sYOQ0fEu369TSwUmqrBIDpciVMlBWqLPg19KCAoxkKWFWRBX8SiweLvGFO/1qpAsN/YYtDSh2EO66zIC2a2hrcB6hVokhuM8e6Ey5QH3RGWsoJH69Xvi3cDm43KbG7Yof5Jox16rYu89FPEw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2Sdvd7kpsWyMQqQOIsNw/DIvnnUJ/yTjMJS9l6doAI=; b=dM3BGeHfB9ahc/met/3JoP6SNaCGLZaOjE4lP1JhuxX/1FkrAMQWfZG+w1PWd2kb9Ue9CsL8EEbZKqx1yGQ41aFcXoRhBxwIMDjjAd5s+dPHqv9ZoK165psEx4SJFiHgPXGsCeICfJLQJIsZs3MJbWYX9VLJ5As99rOTXuq/0rk= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: bc0711f33ca28f02 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqV0qDIe3suect2LitfxEhwzaxvUJqC9ltsCNqZi29dWzb/skrFPmogheXm2wayB3RK5PWUh9Nmz+WCWT+sP4LvSoJ1w5yIWmZ7ZjjQe9iLGRn96eIVADY2ozVsY/msjVf3S9BXPp+//Idc9Klx5DGEN0p0AtJrYc0FKPf3RQE/KSZTIMBRGheKfoEkXTjryPHMGVh1VFcqhZsZHg6EfPt+NXVH7z/5MLVnJTLhua93IHM+rbm0RGJm7J4hsU4QzVYv8yEgs04HHw+2EOrLpSibxd7ykMAp/0ZkKuPKKyI5PYmtYzeiB78CTHVGtcRWWmORRjHd71z7GT7Wg71XSkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X2Sdvd7kpsWyMQqQOIsNw/DIvnnUJ/yTjMJS9l6doAI=; b=nnzxx4uJoF24HO1F9yj5dXn6Dx+6xMwbd5kvMq5anVjA2zokz5VtEfC3rSFbu/jnkVVxWcnBxtmkvLd1G5YGE7DMqsqZJK4fY/+zTyImve8EJ54iczfFkCr7SOAMgYk1yq/b96txOzaI6nw2vzTS1ZYbx8L+ZZHt1OWMdtW1cPtSlF6jH27mf3UdX6Ibux62Woj9+kO9PUD/h6hSAOg3g+o2TL819quXtWyppWd0S5+FuUD317ltMgF2QnofrWJ1wGhVvDegF4tlzoC4kd1IQubCr5fFjM3ngZYPfknEhbs0wTrSKtjFxj2kWx99wzU92eNxGqDXOmkMdV8Yyr6Cqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2Sdvd7kpsWyMQqQOIsNw/DIvnnUJ/yTjMJS9l6doAI=; b=dM3BGeHfB9ahc/met/3JoP6SNaCGLZaOjE4lP1JhuxX/1FkrAMQWfZG+w1PWd2kb9Ue9CsL8EEbZKqx1yGQ41aFcXoRhBxwIMDjjAd5s+dPHqv9ZoK165psEx4SJFiHgPXGsCeICfJLQJIsZs3MJbWYX9VLJ5As99rOTXuq/0rk= From: Rahul Singh To: Oleksandr Tyshchenko CC: xen-devel , Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu Subject: Re: [PATCH V7 04/11] rangeset: add RANGESETF_no_print flag Thread-Topic: [PATCH V7 04/11] rangeset: add RANGESETF_no_print flag Thread-Index: AQHYm5cO6TaiKD6of0yQx8q1sDkLSq2Qxl2A Date: Tue, 26 Jul 2022 14:48:31 +0000 Message-ID: <0A19A62B-0705-4C65-A3BF-CFDC0FA1547A@arm.com> References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-5-olekstysh@gmail.com> In-Reply-To: <20220719174253.541965-5-olekstysh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 5c29fe41-8ad9-49ff-dcdd-08da6f15ee43 x-ms-traffictypediagnostic: AM6PR08MB4373:EE_|AM5EUR03FT061:EE_|AM0PR08MB3508:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xVg13fqBwI5hV6PZsrGOnCBXhHowsNqN0Ug0ezFs23GpRv75ny8M07XblrfY+iddV9+JvtjIYHlAJiuKbzJI2JHziCyDytFJN7bbu9BAZfrO2hgnsD91efDV1VGLpwbgKpzCGARRD4Q65wrYSwrCSRd+OPfAd9aR+Vq+dqebseiqf3TvxuWIkW4yYCpVSMhRPRac0FjJrhLQ2XKHkgnuQvYmIum200CnT407iK7Be6eELbTkJgiVN5KFWoC2X7QpE/wNkwRR7xbCKjfBFj30q0Q6wHcKo3xCIr61hkx8Tjs915fbuUowg67/oTxQY3vaxq7bl1DfBP0gpILf0Q5isbKbtaO9PHGyX2HZ9YyicdMAa00YHPfhIotKgmAxN2TflJSjVE0T30m7w/94u8V0Kgeh3sZoUFAxV5bXa+sP7BVk330Xsd6GAthwCsrcFMuzGb8XyxXGR+Lui4rVml7Ya6oRJJ5MkYJgejKyIgcllNJJ7j1+nN+oKEMc7UZOaI+aPSdL7yC8LSwsW+B6U08TQ+ou45Wed2UlvYGe5NZeKUZU3hqeyg5pu2wFNSuukxQm/D58wSYCmWrB3uXiYIGRmJWec6F1k7lrQQz8I3QAy+28DPEdDyEbm64Ficz7po/AyPU8aDWLEHcVP/CTTlYFsy/VivcxAh3N5HLbInxMK/+/rlNYKOp5++Pl1+NDAjKTHUxLVRgBoBl4+hGCEUvLLZi7dU7xDWCk78MsTQiob0qwBaKT77pqfC1tBzSI6aY/Yfb9f732BpO6Bh2FwLgrcYODsg4k3/5rt5eWfXghPreecLdXdhPEuCPSwlp7VYJr+qZ9jSUeDYdPupKU8dV5NQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(396003)(136003)(376002)(39860400002)(5660300002)(8676002)(4326008)(8936002)(4744005)(54906003)(76116006)(6916009)(316002)(66446008)(6506007)(86362001)(6512007)(66946007)(66556008)(6486002)(66476007)(26005)(71200400001)(38070700005)(64756008)(41300700001)(91956017)(478600001)(53546011)(2616005)(36756003)(122000001)(186003)(33656002)(38100700002)(2906002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <117359476E236D4CB7CF4D2563497B3C@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4373 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a8bd4a53-6e61-4235-af70-08da6f15e8ba X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5JhxVi4dFtz1wsQL76bO3KtFQ97KEbM66UtTR6JNTxiOruWhz2xjQ+lKcabNLTkruQU4Udy0UXZytXyWe8ooaF4NYgmOfPzUW/6cBINDD6vKpmA9qyeYil6EwFUoeISAISq+7WPeeGGaAvtJ56UWyUCDYzJXL0zeJN7Phnd+urV19i5F+7yxolUVMFJAtAL8AZNDsjCFiQGTBR9YgiTR0h5Xtkv8N85djdxFANYIn63YDT62CF+h6HJ1gi8jbNJJmdLwiTa8yQlk2I7kZ5m/MyVQxaK20p2vgp1IzJiDtQ8N6pF2XsPgyB5hY1Z6/IBrNO6eIwSwS4R8Eb7r0eDFbEND/VJhioH5Et2TfrvgyNANMuaNRLvkiFTpZy+qN79Jp7fVbjb4BjeorE+Gqe5uMMAE+M70qzPbYlIag+qeqSiS6hEy5c6/maimzK9G9D/sWEAVooVtzgRxWj1UOUu30CdbL+pm7O+MrqambMnN+cwEiO9rjC07zpBlM8RcGo5VP8r36AHx2LXk+QTJVoG+ivXpeWWMFj+D9Ks3RpE4BqbdksxVwJ8PB7iKQcM++OLlTW3qOg4zuFEsydrjMhQgKYTy093jsgCsS8D9veL9Oc+LBITLkiPe0JGTpnBcKdPSRF65ATWDQ9sl0TfKGus34yZdyk2wArYLjF+tKPWkCyasief3bO39xQ3obi2tC4IZdfWype+WcJccLGP+R0+o6TXfPKZIzAM5/WqD1fLeXMgzdkZoDdEdcKXvHD4b4ajsHFlHBgGlEs/EYO5MLtFE8igtPp2gnR6eUq4n7KVmu4gzzvTd8U1jNNLQIu31j3ff X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(376002)(346002)(39860400002)(40470700004)(46966006)(36840700001)(36860700001)(53546011)(6506007)(40460700003)(2616005)(478600001)(6486002)(2906002)(4744005)(41300700001)(5660300002)(33656002)(86362001)(8936002)(316002)(36756003)(54906003)(6862004)(82310400005)(40480700001)(81166007)(336012)(186003)(6512007)(26005)(47076005)(4326008)(8676002)(70206006)(82740400003)(356005)(70586007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 14:48:40.8043 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5c29fe41-8ad9-49ff-dcdd-08da6f15ee43 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3508 Hi Oleksandr, > On 19 Jul 2022, at 6:42 pm, Oleksandr Tyshchenko wr= ote: >=20 > From: Oleksandr Andrushchenko >=20 > There are range sets which should not be printed, so introduce a flag > which allows marking those as such. Implement relevant logic to skip > such entries while printing. >=20 > While at it also simplify the definition of the flags by directly > defining those without helpers. >=20 > Suggested-by: Jan Beulich > Signed-off-by: Oleksandr Andrushchenko > Reviewed-by: Jan Beulich Reviewed-by: Rahul Singh =20 Regards, Rahul From xen-devel-bounces@lists.xenproject.org Tue Jul 26 14:51:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 14:51:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375382.607725 (Exim 4.92) (envelope-from ) id 1oGLty-0003ON-Tm; Tue, 26 Jul 2022 14:51:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375382.607725; Tue, 26 Jul 2022 14:51:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLty-0003OG-Qt; Tue, 26 Jul 2022 14:51:14 +0000 Received: by outflank-mailman (input) for mailman id 375382; Tue, 26 Jul 2022 14:51:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGLtx-0003OA-66 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 14:51:13 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2067.outbound.protection.outlook.com [40.107.20.67]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6403e8fb-0cf2-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 16:51:12 +0200 (CEST) Received: from DB7PR02CA0005.eurprd02.prod.outlook.com (2603:10a6:10:52::18) by AM0PR08MB3476.eurprd08.prod.outlook.com (2603:10a6:208:dd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 14:51:10 +0000 Received: from DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:52:cafe::d7) by DB7PR02CA0005.outlook.office365.com (2603:10a6:10:52::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Tue, 26 Jul 2022 14:51:10 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT061.mail.protection.outlook.com (100.127.143.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 14:51:09 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Tue, 26 Jul 2022 14:51:09 +0000 Received: from 96fa35068418.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 22B09FD4-217D-469E-BE6C-13DAB90E5D54.1; Tue, 26 Jul 2022 14:51:02 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 96fa35068418.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 14:51:02 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB9PR08MB6617.eurprd08.prod.outlook.com (2603:10a6:10:261::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 14:51:00 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 14:51:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6403e8fb-0cf2-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aD8GX9ztNvG4vPnWqePG6xEf3BH9mRAJlQPOldcDBCI6mC/kJWvdmNhBAsM5znMEhqNmUlguci7/QHXIhhvJypOo0xJU2YH4KAKKP5L/zAYeq6cm3+8SAeVDzCEhjTIB7KUFNzUJMq9Ja81tNpdqmP4hy973HE9GdlFkDOAQnM7iAFUAXq5ptxteErT6nYcYCHiDo//9xmWYoASHxe6xazduqMsrvJSsRBAXPQ7HzA6SBewxaXBSjMRzfFgvHxgTo+yYUAigT1r9Vi8mgwTECzEWLfa5WKgvvPwHsJ9dR718ecuuZkae08/wta7Ibk9CVS4j2FIbZ9v+ZbwAM1aENw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhwiUm89xg+3yZ4e6A8obhVLJ5u9gC4z9JCao1eTK5Q=; b=lOyzJICMrR1+6pH0uzIUedzmC9to8Rq4hBxqnljvHwjnj6hVrWKFZnKutq/VWz5Cmwrvl7Tb8za1LIwv5FbwPHSZKSSzC/MEfZX1dWBjNqXQOSZiaPQZd7bkLbBhF5HQVyO0LOtSnO946q6+JtKXcLjJiZuF9F3W+nYjP1jZrImXVRYGNoHNnZzLgDGIgp6gxDuI02Xc1PeOk0iLXFsGB4Oz2/WD/fZ5QErr0jn2ClwkiyL5x4Tfq4AO1b6vyEyUK6ov3PvvO8HcyN9ZJjBjoHdFftDviKgNvEh6u+9NPPh0ukU6hd72lzlyRKYK5vQnAsRDrdL3mAT1p7yu27vScA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhwiUm89xg+3yZ4e6A8obhVLJ5u9gC4z9JCao1eTK5Q=; b=xqMPQZH31HR0ulE8jj13BQibfoSH+iqyvogwkku0ZUta750yxEPEM0chvMJ3CZRQ31+0H1kirTLGxUfHOE6bADQOz7HOgiQEYgXviJ6rik2l6Gls29al5+PkJXbGreygoFgBmThsCUcY96S+euxhadcCji0SXJ4W5snY9yXDu1I= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 2ef176a711a58498 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZpWhPYcBJLQazWRrAKlxlovdyXQYM1jOYF8thytmpHJ0puKkzFgshvgZGEj+q+dixD2l+tpC1tNoxYlbmZ3TpZwgo8l0Do+x/f9fHIMIDXU+d6NIIZnryhRMD1zofXmN2erRxkAiqF6ZMFvAhe/V/c+Vh95l7ap0XoCwWEPTYJqiqQkTWAej1iA8rA0uCNFD7zfpIh0dGcx3HRGSl4wXtZKK8DWQLD8SoJTd6dIQ4D9ezVNuZYwRi8kUftLTXI04KMfiZweqYEARp9tyWtk3rjgLKIpZY+rBWAhkp131bdk3HTJSg/a7ig7ZoN7VSaRTGHuojlrf9tVb/p+BXvcXbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DhwiUm89xg+3yZ4e6A8obhVLJ5u9gC4z9JCao1eTK5Q=; b=A5tfFLvy6Jw49Lweph3DVSBh3QJAC8jObnEhIcAifyNoapHMI2syxdFC/q8zkPpIuwlnw39T+XK4KWJig+H8TDw8q+qzxeGwvIUNuzsPYUw2U3WtcowjB1qNHtvPzXjcUhCxIEPrP+42Hm/+7E2h2z5mt4Uq9tn8zbMTn4q92w+qT1OE4RtgJdSZ2+Gda4HVoYuwaKsxwxn+sbaxphuESpEQ1crhhFrObBLPQMwGpZ5iUzFEiIKjGB7cJF/xj7zZYt6aBTdU++v9dTCETJyr+00XDKBfdU8o19arzmbWSjKYhQhU6xWti/FR2E7YWV8vLShnk0vyLijpHAbgOa/Jkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DhwiUm89xg+3yZ4e6A8obhVLJ5u9gC4z9JCao1eTK5Q=; b=xqMPQZH31HR0ulE8jj13BQibfoSH+iqyvogwkku0ZUta750yxEPEM0chvMJ3CZRQ31+0H1kirTLGxUfHOE6bADQOz7HOgiQEYgXviJ6rik2l6Gls29al5+PkJXbGreygoFgBmThsCUcY96S+euxhadcCji0SXJ4W5snY9yXDu1I= From: Rahul Singh To: Oleksandr Tyshchenko CC: xen-devel , Oleksandr Andrushchenko , Bertrand Marquis , Volodymyr Babchuk , Julien Grall , Julien Grall , Stefano Stabellini Subject: Re: [PATCH V7 11/11] xen/arm: account IO handlers for emulated PCI MSI-X Thread-Topic: [PATCH V7 11/11] xen/arm: account IO handlers for emulated PCI MSI-X Thread-Index: AQHYm5cUcU3VrnySPEy+ivRgo8KSXq2Qxw6A Date: Tue, 26 Jul 2022 14:50:59 +0000 Message-ID: <71A6D8F4-5591-4869-B5A2-486E6B8243F9@arm.com> References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-12-olekstysh@gmail.com> In-Reply-To: <20220719174253.541965-12-olekstysh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 4d81a3d5-e7eb-4188-acfc-08da6f16470c x-ms-traffictypediagnostic: DB9PR08MB6617:EE_|DBAEUR03FT061:EE_|AM0PR08MB3476:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9tTaAIFSkqMyWRN/l7YvAsnxfuhjEumb3lZkyQAdVGzeEJvJVQf2EloJea4h0yqW3+pqkPnTvu5sixdZ9YPqTuWkMUQxHDFX1LwSVViQYkhehcyDqiqEalYIoR6EiScyag1B0O34ox27Y1BlxoiGNBRBB/ufmr65iYY2ny27A+BkoG+e1AqiCdf8Hp9vm2bPTgNmSZGwOHYIv2mX/s6VGMuKKluysL3rXTNCfCvSR2R5hZAtp6XyYmF0GMAUXg8Wj2O/N/brw0NEcxuWyNx2vr7ho8ZAKHleZF9psStXIW95wqpDFNrqZO/8P8U4swh95zsjO8tGhG7wHnfa0OmkGwd890qX7F/m1dBuhujDM1CuGYKaEdXaOzdgc02kV4ENzYwx/UYODkkKjqBUmocraV0f0K1VYQfPDk5YdoyISPEr3pLuafmk1iyAL5J+eLQrLFqILsZQYJcqLKjqod3hzasaqE7LqRj9trNse+CH5Dn6JD898OZanhTBT7vOpxe6EIJVHb+sF071e/CS6bpus1HbvZU6LC+Fc15hZQHcUaKEL7QJyjnxdOyW7QZQU3SC80gIQfqoTwVTyagMCGC5qMyoxWqHy6rful4M6xXW6uLJk2LdeTRLJmhj/gExPH69no+fmRr7xlLbxSUXLBFazfLDmWvYVMSjOf8Mswn8w7+cUlu9nvmvrpxG35itQX0ddEAYnxjlY+Mm6rtapdG5X0sUAPau/F/Zvf5yn4zO+03wl1/t4WVKHMCekrcItxyMrSg4kM4U7y3BERDnd5MDqtfhmTrJKb0Zy+Hl6xM2RB/ELqMO+ziPgbz+bcFwMOiz3XBTRUVJr3nvDwscqiBR7A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(376002)(346002)(366004)(396003)(316002)(54906003)(38070700005)(36756003)(2616005)(186003)(6916009)(33656002)(6486002)(2906002)(38100700002)(15650500001)(4744005)(122000001)(5660300002)(8936002)(4326008)(91956017)(66446008)(64756008)(66476007)(66946007)(76116006)(66556008)(83380400001)(6512007)(41300700001)(86362001)(71200400001)(478600001)(53546011)(26005)(6506007)(8676002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <21077206A8B39347B9D59283D3CCB984@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6617 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: a19e27cb-b8a8-434c-c2a6-08da6f164115 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eAtthxZB758DcPaWbI680KAmd5NRPq3RkmjipprR2NkK54lUP04b2bXGafMC8qsAZS0KV4XjZnTLHAly3Ur7yxXrc94iZnUkmM/YQGuk9V1a1potyqBvY/x9x+f4MY01Vf93Jp9cgvq1/XzPAmqrBTQPz9/3j6dIh60/Lgdm6RUJvO2rUeXhb9hYwEgr6PLY1oeV6DpKbvzsYx8R2kI3Uc+7yEhejEJEPDdbtS93ZSPyYza+g2K75UnRAmWq7pjVvKfpl0lXn1tnAxN7UgBwLjy1QwnXVbbqwYPAQDSpjNINst/GNsvUABMh0kNLQEXIqO1VfqKFocNdFnwLS7o9Jgc4CLzfJSw3GajM1s/1IQ5jKn2SvjCAfCcnRolTDvpCyEqCyMINhxIXWYBd8JCNjR8Id5TnSn9WlWJzDo0FoJ1VdXBpIJTf/GCpgnATPjRL0mDJoWvbn2jckwlq7FCfxd7GzVQaK240TEdwHyEL32HKrLfYFHpuZkpKsLDiylUTKMxg62I93kIpaF404cfY98FcxIxHP4magkgt1bplOC/4Epa3PTee2SDE3MpEnmKFcJ1c95R5N2krMfzC85A5j5EzPkIySxCBnKESCVLZcI83tNtbFZki3vOwpQwQD8lagvTz+uBZVa0ihs5XO46GJgZJrNMlkugO5s8/B5Xf4sUJSvLdVvzFacgI5qzg6oD00pKhb9WUBb5F1HaEUXzamUP/UoUyp3i+4NcKyD6iwYuUqntNNe+3rboWZMJuiCk2S0OHVZgwXB937IQ00Dtr4r230q4ZFKZL0nBQjIs6A+IDwGz9WU4A2Gr44DrTVG27 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(136003)(39860400002)(346002)(376002)(40470700004)(36840700001)(46966006)(2616005)(107886003)(70586007)(47076005)(41300700001)(336012)(316002)(8676002)(4326008)(82310400005)(15650500001)(26005)(86362001)(70206006)(36756003)(6506007)(186003)(33656002)(6512007)(53546011)(356005)(81166007)(82740400003)(40480700001)(36860700001)(83380400001)(8936002)(6862004)(5660300002)(54906003)(478600001)(40460700003)(6486002)(4744005)(2906002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 14:51:09.8323 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4d81a3d5-e7eb-4188-acfc-08da6f16470c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT061.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3476 Hi Oleksandr, > On 19 Jul 2022, at 6:42 pm, Oleksandr Tyshchenko wr= ote: >=20 > From: Oleksandr Andrushchenko >=20 > At the moment, we always allocate an extra 16 slots for IO handlers > (see MAX_IO_HANDLER). So while adding IO trap handlers for the emulated > MSI-X registers we need to explicitly tell that we have additional IO > handlers, so those are accounted. >=20 > Signed-off-by: Oleksandr Andrushchenko > Acked-by: Julien Grall Reviewed-by: Rahul Singh Regards, Rahul From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:01:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:01:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375390.607736 (Exim 4.92) (envelope-from ) id 1oGM46-000520-RH; Tue, 26 Jul 2022 15:01:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375390.607736; Tue, 26 Jul 2022 15:01:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM46-00051t-OO; Tue, 26 Jul 2022 15:01:42 +0000 Received: by outflank-mailman (input) for mailman id 375390; Tue, 26 Jul 2022 15:01:41 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM44-00051n-PP for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:01:41 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2045.outbound.protection.outlook.com [40.107.21.45]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d97716ca-0cf3-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:01:39 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6597.eurprd04.prod.outlook.com (2603:10a6:20b:d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:01:36 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:01:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d97716ca-0cf3-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jdTaIN3ooWhEbFxeU7G2ucmsWISjIgb6Cn9U90zyXpluoqZKFL1FkTtZAQ0s07z9dzVebSVAYn7zrFPSpjzpf6Fd27lMOlK8E4/1Cn1WZ4nBwieIgAx5awrMeVnfCbaYRHyjGA75jSrLO+YWlLcE/OVVS2o1IMl6Vei3sLEFmdkNJCcWVysQa/N1w8OjnP3NEgLwXQC9oZyv+XT35aO33o427rJLCux1btUXPK/ryy1VXQpaBKCQZCaGfAtibHv1oOE77lFnyCcoNo9++isNwJKQPHkMG4PzYQ3L/Y4Q8sdp/5a3hApP0BH2SapAHZKtOHOSP+gjQ738pt8HssBtRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pod+1bWAh2XWYCi0GKl0F4kY09Luzp6KkCoWHY/Umo0=; b=fE+mdD+i/GSamBgEvwfTg57PUBMaf5iwUHnysV4FSFahtEpCXs9Zvf9EvPqGamGI9eRX0UEa0wI9/iWHu4DNZQJDd4RFKrLj8uOv4jKMsXF+Y9YqcormOE+wufNsebbkt3CbQfdrUqSkk+cvqo+CTIlN/em6Riqm+g0mIBdIesIOTvhNiBQnk+ELrNZoYLQOkguEK3jHrJR38507McSjpBLIVblbv4gQM4f1yyvgjaGI7iorJiSsSHj4fNGtcz4/NZVdBAcTaAcjvevFT2yDyNkYBjkxiTOaQeobVIEnN1HaqggvRCQqtEC7+xhN/9I70Yds6exCIbem9TurmUVtVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pod+1bWAh2XWYCi0GKl0F4kY09Luzp6KkCoWHY/Umo0=; b=fhr5+LFQWkzo4C2D6yXCRBhUGGiWUFLdNXciSV2bdywQ4C31AWoKKZNImcHNOybZIZ42oMgq4doTMYWTBngWl69lpxaJVf4qhUYbbmf3jGhi9zoS0yB+4e+rXhVteddFVe9rFBVXxi4FRRH9rb+rgkyIixPG1oG17YTOUYBQsNcaChL10fX+OKpw4Jxkc/Jq6zUfFnh6iidFrFXPJ725/iaWtB5fkQt41w9j2pLFX1aqevTIlTbyvdF2/gPPWseElXLDM1VcdCrTDuACrr28jQlebE26H3YIfCViB8qKOT17lDeK+b857O66Jbt8rnRGJt75Wbdf+XfbKZZTjZZ2YQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8208dbdd-ca5a-a1c1-478c-cb7cdb0992bb@suse.com> Date: Tue, 26 Jul 2022 17:01:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 11/18] x86: initial conversion to domain builder Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-12-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-12-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0179.eurprd06.prod.outlook.com (2603:10a6:20b:45c::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5cf3af95-9e1b-48bf-3ade-08da6f17bc18 X-MS-TrafficTypeDiagnostic: AM6PR04MB6597:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sv6p5iFySziYdac2pW0bAnt0RS7j31FhyWsLA0dWFcXHMS10JfT9ROa5tT+8qYX+P+ckd+2NWJGTNltYysAM6y3eUo2shtibjDzJOChyLsZxxWNPyaOd2O/sRbaJl/2bWpZlsiWR281WJ8Te6rBeGf9OnsgpCfbL+Tog/IYTTNsI4WNbzQHfuGyTNP+PYaKTGikLk4C9k2WG0LetgLuektq1InTBvIQgFAjKzAaXSv7XGAJAozymG5AyyZk77VLuRyIzJP0TFVMh1YOdNbAN+A8IduHezZ+seR+rnIgyw6UetmsLBHV9q8vEUxd3O/xeX4yg1jOuLzH8IqYLoDgEGvzpTBmoo2AP/mTJPylpB07zZKKhVYba+z3jgRLOQNZxjaRSZAmX7oBepbYEv4yot8oXzWJBX89AmpL5hzh7f3YoXQRZthMaVWc4T8rrHCpepq5y4U+rz2vjIrU+8Scd0FVw0nm81I6hGOsbD+r6YoY7Kns3rPuM7aX7cGIQn8xBmUUkJBxad/9Z7ANX+AX1fv/G6LK0OCeJAqfcYvW2FLX5l0i9n0yOgPBg3jMv4E9UNvNXUGV5g4meZkXemxQKCR/eaS++IpU7uhhe4rvww5IfIXd6aCwKjRXi9m3qyfW/Y4T1EVFT4CvBwY/wvz07Ai4hiKXZvO2b2jag0+BUGElxpF/FBhKU1Dg87paaGz2zyX4kfkUlr7H78GzysxhdOIC/QX5sqTzUwv+hh/R7KwxpeSwNeflNpBBPWfSpHBC9153EUOKAe0j85y3dDOUU83yqToAY1bUfY+rCZK2Gvk7jIDL1M+9Aw/DsCslgyhehhFZn/wWA2DJQeCPp9xzbgg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(39860400002)(346002)(366004)(376002)(186003)(2616005)(83380400001)(6916009)(8676002)(4326008)(66946007)(66476007)(66556008)(54906003)(6512007)(36756003)(6506007)(53546011)(31686004)(41300700001)(26005)(2906002)(86362001)(31696002)(38100700002)(316002)(478600001)(6486002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d0N5cmU0TGY2cFNTbk5NOHIzdTM3aTdZQTdmVkdwa3ZlZEhZZHZjYTVwWlZh?= =?utf-8?B?c1Q4WEFrL1BQQmI2a1dEVFpsT09mMVJYVFRvYUtVNDBwVERyNzBwWEFYNkQv?= =?utf-8?B?TUNHZEFaNmRKYjhNWEUreFlQZzhVek1NWHFyeWtrYWJ0aUszd0JmLzgrYWtE?= =?utf-8?B?Q2cyV3E5T0ZKV1JjclpHYzczV3dvSVNCYjEvMXR0M2RCV2lVaVVOd2piWTA4?= =?utf-8?B?Z0FYYWNnQnFDNVNYdVJCZnRCYUdCK1Z5MmF3ZkRTYk92QUxXV3o5QnBNeFNW?= =?utf-8?B?cWhUOEl0cnZSTzdObWtMYVN0cENwVjRZbEdWdGNjT3MyUG1XdVJJMzlSQjRZ?= =?utf-8?B?RmF5bW1lb1NGVFByTDRuc1NWZWtlemV1bHJYNmR4V1FkejRDemRuQXJHbTdX?= =?utf-8?B?d1lhN1hVcWdva2dsOUIyUGd3alBUcmg5LzlWRTVyWVVKa3RmZE5wdU0ydUlt?= =?utf-8?B?ZkVsU2hDR090emxaM1AwRDlwTGVCN21kMTFMT2JHbDRZR3B3OG1yWEtKakFm?= =?utf-8?B?SjczRUJTRXpWNkpObkMyQ25ETHZ0T0k2VEdvak5pV2dETGtpSk9sMS9KSHEr?= =?utf-8?B?dGtNUGt5YkhVWVJ3bk9qejAzc2FRTzIvRXFIblFxdzBRUkljdStVdnduVlA3?= =?utf-8?B?MTJnZTR5cStvcnBMUDdHMjRWcTArT2pyTHJWT2E0b3lMWUVUbld5cHVwa3Z0?= =?utf-8?B?eG9oRVkweHc1MzNtRzJ2MFhEd3VZVTYydWlNeXNISnlwcjZibTNOSFA4TEpI?= =?utf-8?B?d1hUYUorbjk0bHNsMThQdURuQTEybnFycWtDcWlZUXdyNmROR3Rybk5URnN4?= =?utf-8?B?Z3JXNDJGaXdwS3Job3MyNGsyTEpLbG5XazBZd3Z5YUxNeGpzZXlEcUJkOTEz?= =?utf-8?B?djg5c1NpM0FNN2pPQVNHWTlQNE1vam1XUytMYUVOUGhIdnR0a0pUZ2ZucTFU?= =?utf-8?B?NTVhVkJKL0tldnhyQkRUTDVnWWNPbHdZdlBOWWR2TnpIbWdJYkJxK3JYbHQ3?= =?utf-8?B?TlUzT1A1ckNWN1lrcWdMaWRLMU1UQnMva1ZsVVdLeVVWY3k0ZVBQQ3N1NmRW?= =?utf-8?B?TklUSlZWc1ZzdzFXdjJNOFRuUzlKZDZoWmRIWE5USTljb2Z6VXZzR1RSdWVB?= =?utf-8?B?bWNmQ1Q1U2pyRDBXWUNZcUdjcWpIRWNvbDBoaHpKM1ZCZWlHdk96YjlXYjFp?= =?utf-8?B?ZlhmaWZrS3pqMndUMnBpS3Zoakh2dEtCS0Z1ZWVvMUprOUwxQVRlNkl0Q1M2?= =?utf-8?B?VnFxM1NsaUg3bVEyZ1kyM1FUT2d4MGlRV2J4TlRVckpVOXZpUXkveXhUTTRL?= =?utf-8?B?Q3psa2wyMEQrNVRUcUlnK1RZekFqTmhEWmRFWGdsTHZYMVFWbHY2dmFjT05X?= =?utf-8?B?cWg1b2VGd1BFb0pjeGxuV2U5b3BTM2FQKzVpaHViUWF0MS9VWmdKNS9lbnI1?= =?utf-8?B?WFdpMlhjMDhLTjUwcGp5TFR2MElmd25sbjlEbGhrN3Z0WmZGUnNMWUU2WWJ5?= =?utf-8?B?alF4aTJscVExQUxjV0VkZzFTTEhEZUllQVlYbHRnd3JyT3AydWhvODhjanlr?= =?utf-8?B?RE1Va005Q1duekdSazN5Y3BxTStyS1pXM2tOaE5WalQ5UGY5YnpRWmVRL3Jp?= =?utf-8?B?WUtxL3BxTUV1SU9CSGtHT014QmJteitEU2M3THVqMTVFenNTckJyaDFyR0Fo?= =?utf-8?B?ZHA1d20zMTgrWkhZUkM0VzdxVHYyNVV4QlR0UURBbkRQOUNKTGwrZVJGOHZp?= =?utf-8?B?K2dBc09YUGJtcHhuVkRlbXR4VmN3a2VabEZJVWRtVWRHbFQ0Y2pBL0xuU0d3?= =?utf-8?B?amx3SU1WL05JVEVicmRTL2x0YTdPS053VmVGa21tS2FmYW1QckgvMWh3bld3?= =?utf-8?B?bGVRTTUxVmlYZ0FwK3dQcm1BZFhSTC90QW5TWmtuQnBnUlZvaXVyVklsSC80?= =?utf-8?B?VFVJM3pWaWd4TGVhUWsyRVQ1MTU3WTZlUm1ENmFHTVgweXoyeWx0c3d3eC9R?= =?utf-8?B?NHdPTWR4Rkg3a2Q2SkQvNVl0Wnl0UDY4UTdWZkR5ajk1R0xRamhmZ1V4clF3?= =?utf-8?B?cUhVelJET0c4WUx2WmpHZzB1L0FleXpSQW1vNGJsUXp0TlJSSzgwd2hPQWpq?= =?utf-8?Q?u4YjHqYkLF152diezOFbl05pF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5cf3af95-9e1b-48bf-3ade-08da6f17bc18 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:01:35.8075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GTRdvWsGgHIjvYNK2FlrxCQ28U6YxCXXXbwmgcnWl/YDpI3Qi8H+96sdnHcCZ+/rf2SSciOhtzn1ZOZV68C7tw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6597 On 06.07.2022 23:04, Daniel P. Smith wrote: > This commit is the first step in adopting domain builder. It goes through the > dom0 creation and construction functions, converting them over to consume > struct boot_domaain and changes the startup sequence to use the domain builder > to create and construct dom0. > > Signed-off-by: Daniel P. Smith > Reviewed-by: Christopher Clark > --- > xen/arch/x86/dom0_build.c | 30 +++---- > xen/arch/x86/hvm/dom0_build.c | 10 +-- > xen/arch/x86/include/asm/dom0_build.h | 8 +- > xen/arch/x86/include/asm/setup.h | 5 +- > xen/arch/x86/pv/dom0_build.c | 39 ++++----- > xen/arch/x86/setup.c | 114 +++++++++++++++----------- > 6 files changed, 109 insertions(+), 97 deletions(-) > > diff --git a/xen/arch/x86/dom0_build.c b/xen/arch/x86/dom0_build.c > index e44f7f3c43..216c9e3590 100644 > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -556,31 +557,32 @@ int __init dom0_setup_permissions(struct domain *d) > return rc; > } > > -int __init construct_dom0( > - struct domain *d, const struct boot_module *image, > - struct boot_module *initrd, char *cmdline) > +int __init construct_domain(struct boot_domain *bd) > { > - int rc; > + int rc = 0; > > /* Sanity! */ > - BUG_ON(!pv_shim && d->domain_id != 0); > - BUG_ON(d->vcpu[0] == NULL); > - BUG_ON(d->vcpu[0]->is_initialised); > + BUG_ON(!pv_shim && bd->domid != 0); > + BUG_ON(bd->domain->vcpu[0] == NULL); > + BUG_ON(bd->domain->vcpu[0]->is_initialised); > > process_pending_softirqs(); > > - if ( is_hvm_domain(d) ) > - rc = dom0_construct_pvh(d, image, initrd, cmdline); > - else if ( is_pv_domain(d) ) > - rc = dom0_construct_pv(d, image, initrd, cmdline); > - else > - panic("Cannot construct Dom0. No guest interface available\n"); > + if ( builder_is_initdom(bd) ) > + { > + if ( is_hvm_domain(bd->domain) ) > + rc = dom0_construct_pvh(bd); > + else if ( is_pv_domain(bd->domain) ) > + rc = dom0_construct_pv(bd); > + else > + panic("Cannot construct Dom0. No guest interface available\n"); > + } Isn't there an "else" missing here, even if just to ASSERT_UNREACHABLE() and set rc to, say, -EOPNOTSUPP? > @@ -311,11 +310,12 @@ int __init dom0_construct_pv( > unsigned long count; > struct page_info *page = NULL; > start_info_t *si; > + struct domain *d = bd->domain; > struct vcpu *v = d->vcpu[0]; > - void *image_base = bootstrap_map(image); > - unsigned long image_len = image->size; > - void *image_start = image_base + image->arch->headroom; > - unsigned long initrd_len = initrd ? initrd->size : 0; > + void *image_base = bootstrap_map(bd->kernel); > + unsigned long image_len = bd->kernel->size; > + void *image_start = image_base + bd->kernel->arch->headroom; > + unsigned long initrd_len = bd->ramdisk ? bd->ramdisk->size : 0; > l4_pgentry_t *l4tab = NULL, *l4start = NULL; > l3_pgentry_t *l3tab = NULL, *l3start = NULL; > l2_pgentry_t *l2tab = NULL, *l2start = NULL; > @@ -355,7 +355,7 @@ int __init dom0_construct_pv( > d->max_pages = ~0U; > > if ( (rc = > - bzimage_parse(image_base, &image_start, image->arch->headroom, > + bzimage_parse(image_base, &image_start, bd->kernel->arch->headroom, > &image_len)) != 0 ) > return rc; > > @@ -545,7 +545,7 @@ int __init dom0_construct_pv( > initrd_pfn = vinitrd_start ? > (vinitrd_start - v_start) >> PAGE_SHIFT : > domain_tot_pages(d); > - initrd_mfn = mfn = mfn_x(initrd->mfn); > + initrd_mfn = mfn = mfn_x(bd->ramdisk->mfn); > count = PFN_UP(initrd_len); > if ( d->arch.physaddr_bitsize && > ((mfn + count - 1) >> (d->arch.physaddr_bitsize - PAGE_SHIFT)) ) > @@ -560,13 +560,13 @@ int __init dom0_construct_pv( > free_domheap_pages(page, order); > page += 1UL << order; > } > - memcpy(page_to_virt(page), maddr_to_virt(initrd->start), > + memcpy(page_to_virt(page), maddr_to_virt(bd->ramdisk->start), > initrd_len); > - mpt_alloc = initrd->start; > + mpt_alloc = bd->ramdisk->start; > init_domheap_pages(mpt_alloc, > mpt_alloc + PAGE_ALIGN(initrd_len)); > - bootmodule_update_mfn(initrd, page_to_mfn(page)); > - initrd_mfn = mfn_x(initrd->mfn); > + bootmodule_update_mfn(bd->ramdisk, page_to_mfn(page)); > + initrd_mfn = mfn_x(bd->ramdisk->mfn); > } > else > { > @@ -574,7 +574,7 @@ int __init dom0_construct_pv( > if ( assign_pages(mfn_to_page(_mfn(mfn++)), 1, d, 0) ) > BUG(); > } > - initrd->size = 0; > + bd->ramdisk->size = 0; >From an abstract pov: Is it legitimate to alter values under bd-> ? I would have assumed bd and everything under it is r/o at this point (and could/should be const-qualified). > @@ -272,6 +271,24 @@ static int __init cf_check parse_acpi_param(const char *s) > } > custom_param("acpi", parse_acpi_param); > > +void __init arch_builder_apply_cmdline( > + struct boot_info *info, struct boot_domain *bd) > +{ > + if ( skip_ioapic_setup && !strstr(bd->kernel->string.bytes, "noapic") ) > + strlcat(bd->kernel->string.bytes, " noapic", MAX_GUEST_CMDLINE); > + if ( (strlen(acpi_param) == 0) && acpi_disabled ) > + { > + printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); > + strlcpy(acpi_param, "off", sizeof(acpi_param)); > + } > + if ( (strlen(acpi_param) != 0) && > + !strstr(bd->kernel->string.bytes, "acpi=") ) > + { > + strlcat(bd->kernel->string.bytes, " acpi=", MAX_GUEST_CMDLINE); > + strlcat(bd->kernel->string.bytes, acpi_param, MAX_GUEST_CMDLINE); > + } > +} This duplicates existing code rather than replacing it. How do you envision the two to remain in sync? Such things should live in exactly one place imo. > @@ -816,7 +831,7 @@ static struct domain *__init create_dom0(const struct boot_info *bi) > write_cr4(read_cr4() & ~X86_CR4_SMAP); > } > > - if ( construct_dom0(d, image, initrd, cmdline) != 0 ) > + if ( construct_domain(bd) != 0 ) > panic("Could not construct domain 0\n"); You leave the log message text in place here, but ... > @@ -1905,22 +1912,29 @@ void __init noreturn __start_xen(unsigned long bi_p) > cpu_has_nx ? XENLOG_INFO : XENLOG_WARNING "Warning: ", > cpu_has_nx ? "" : "not "); > > - initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); > - if ( initrdidx < boot_info->nr_mods ) > - boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; > - > - if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) > - printk(XENLOG_WARNING > - "Multiple initrd candidates, picking module #%u\n", > - initrdidx); > - > /* > - * We're going to setup domain0 using the module(s) that we stashed safely > - * above our heap. The second module, if present, is an initrd ramdisk. > + * Boot description not provided, check to see if there are any remaining > + * boot modules, the first one found will be provided as the ramdisk. > */ > - dom0 = create_dom0(boot_info); > + if ( ! boot_info->builder->fdt_enabled ) > + { > + initrdidx = bootmodule_next_idx_by_kind(boot_info, BOOTMOD_UNKNOWN, 0); > + if ( initrdidx < boot_info->nr_mods ) > + { > + boot_info->builder->domains[0].ramdisk = &boot_info->mods[initrdidx]; > + boot_info->mods[initrdidx].kind = BOOTMOD_RAMDISK; > + } > + if ( bootmodule_count_by_kind(boot_info, BOOTMOD_UNKNOWN) > 1 ) > + printk(XENLOG_WARNING > + "Multiple initrd candidates, picking module #%u\n", > + initrdidx); > + } > + > + builder_create_domains(boot_info); > + > + dom0 = builder_get_hwdom(boot_info); > if ( !dom0 ) > - panic("Could not set up DOM0 guest OS\n"); > + panic("No hardware domain was built\n"); ... you change it here, neglecting that in the late-hwdom case what is being built here is only Dom0, not hwdom. This may also affect the name of the function that you call. Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:03:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:03:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375395.607747 (Exim 4.92) (envelope-from ) id 1oGM5v-0005eR-Bb; Tue, 26 Jul 2022 15:03:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375395.607747; Tue, 26 Jul 2022 15:03:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM5v-0005eI-7G; Tue, 26 Jul 2022 15:03:35 +0000 Received: by outflank-mailman (input) for mailman id 375395; Tue, 26 Jul 2022 15:03:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM5u-0005e8-4L for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:03:34 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2062.outbound.protection.outlook.com [40.107.21.62]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d8dfa83-0cf4-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:03:32 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6597.eurprd04.prod.outlook.com (2603:10a6:20b:d8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:03:31 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:03:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d8dfa83-0cf4-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlpIE6dHM5GGTkkMe1VroxPB3AW0ODExVW67WkCscbUXfDhQK9IJ7W2pXwajhgMkpkzpr+lB7b1PmgcPUOJzxRLUEItfu9OiIJlxlrzWy+vYnrZ+M6Y6Cmav3ImqgSs6XoylUin9iqI5B3x7gBS4dxm9C6XVASSPeDhLt/17d4Zbu8J54UJ76vzXKbAxKUqf7ygyhikFSRCgRolHrYypEJg80E9rBraeG56RNlxhKithgwCJ8t9pQGvppX3Mi75DGfj0QkC3JbFOmt9uwq4QgMrWwmXaMk3/MmT2T3sJb1LODKYAn01HEzwLdS/uA0viEb3QzRAFTZxqmStS7rEaVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XyLDKeaUM74v5FRmG63pbSzmEKAmc4NPj9pqzbOsBkg=; b=AonYRQqfCR06Qei3t+YP5brb4ScItBhpJ+BnCBpO6sKS2l0SwlEYjVptoXfvhzo1ef3lIYcLg5k2eWluXzYlSO+tVK5kqKvIHgDCOu0Q501CvHmfaGlKhCZoAfU9oy/jxuX7KvR1NmCIZxQWQ69iSl7j0F4L0wFJlQklv1gcV1pymBeum/tUZeOUg5Qitk1AfRpCYYxsQOTFqn5LlWj4im5XxelvjxQCin1B/qNtrXUbT1IWDKf9FQE2FQdv0vS949JhkSCP6HeMawjVSmHlQiMLq/x2l3DIrE9zGm/sfAk5imBYGXlOpARv4FdFSofEEVq28gMPZkVCl0hO8vdeWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XyLDKeaUM74v5FRmG63pbSzmEKAmc4NPj9pqzbOsBkg=; b=b7LRRYUbvgQp4wUViYaz3zaI+XWz9MLJd+UV/OYzM+z7oX4TiaLOOer6HYjukhmJ1nZXVEIe1mIQ9I8UKodCo7xTeLA5X6F6hgN/USEtlMtu0gNpWtL6e0dySryEuEPyJ+2e56qNil/gw68aFj2PtbijFkLOLiyIbyNwENRrd/R7mj6v+f10GqAjysuNelPtA+HGFiVm2ShrUAsunVtscf3ZQCbYGen7Npl/ALSh4mC9SrmunL2f5yioJAOP721t4s58VGKvJYJ80gU70b57qsIWaB87rUyNEe/H7PEDU7pBjm36WqVp1hE+42HIa9x9QbsSawQQeqQ86wr/PfI9sA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <47ae6b9b-eca1-7e42-a7c9-12cd9030eddb@suse.com> Date: Tue, 26 Jul 2022 17:03:29 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/check-endbr.sh: Explain the purpose of the script Content-Language: en-US To: Andrew Cooper Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , Xen-devel References: <20220726142328.12246-1-andrew.cooper3@citrix.com> From: Jan Beulich In-Reply-To: <20220726142328.12246-1-andrew.cooper3@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0143.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:95::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3894c676-6db6-4a9b-1784-08da6f1800e3 X-MS-TrafficTypeDiagnostic: AM6PR04MB6597:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dk9+VRctIZPLkY5kdst7N2e/mCrUwZQGtGfr/qiZ9vTK+fkKC5nySsYKELlepZjDDmKTrba69xcnW8/9K3TgGKUm0dqlR2C1zONKixnKivZbsybYQUrUSihNMo8jQIHLM4Q9tSXSOFQqBERKpy6uctiDa1uWODjp7tMiit750IbLXlvFdyqX4jLrwZ95bGdbMFUiDuvVqj0Jg/FNHd7KRRnFVPR0pHqtOcN8qtcs0xI4RHgeaLxE9eBrpOGmmglg8a+UfrGoQtwwMGp6dCPIiBv9J8UyZyqi/MaU8rvEt3dYG9XvgVyM9/bmRTtS9R2dlKQUMlcq2x841WFHzrHTVMHl7VBslOzouNVbfiEXkHGrYY/8Iah2W7ouRJIE7OXWIyO/i+YG3d2RbyjaQifregD25x2SkTaO3bfIZ7CXEQQq6F645/vTqSBz30O+jOjLNWBVz8CHiybHO78mHSDFeol6Wmu4jVdYxlp4mkImdKmwzNZqiH9P1JaVScBnHlpgvgviYEHEP+W0qjXc5kGOYXl93/lNQmj2kh01h/z61jnVDgYA1USV/BYcC9Xd8dfcsk7nuDAQpz78oUrVq03qVBDZShJ5OS8+JgfY7dqvHZjDtQ34WXFuRLLlBhujL1kQO8cTrfnrChYgi7cPz3gkoIKkOfXYx3R57XwhNHNozvvsM2gRvcq/lq0IeFbabsMJkFwj9SBbskXNiH1MdM1uTU05ZHkMlnkJ8j+yxQvdQ21mR5S06shIhAqqyZ8BxhbGJ9yhYazx5GoYNw/kxHGBL5Papzic7eR+mn27GpFLH5TkdLlnazkJs0HSMuHJ3O7n5uuaD4unbzf6iqSIeUXRkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(39860400002)(346002)(366004)(376002)(186003)(2616005)(6916009)(8676002)(4326008)(66946007)(66476007)(66556008)(54906003)(6512007)(36756003)(6506007)(53546011)(31686004)(41300700001)(26005)(2906002)(558084003)(86362001)(31696002)(38100700002)(316002)(478600001)(6486002)(8936002)(5660300002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V3IvaXVpVk85U0JJTGw3R1l5dklGZ0RqSHg0R2hKZ2NhdmptVUM1WW1TekdR?= =?utf-8?B?d005VUFXSjhvYjhyV0FZUXNkMUdBa3dJVDN4Sk5HUHljNG83LzNBSW5MUWY1?= =?utf-8?B?NGFHZFR6K3grbERHbVRYaW5wMkppb0dJeDlhTmVxdlBhdzBwT2NVUHZacU9V?= =?utf-8?B?OStSb3h0OE9LSGlxUjFMOUpSWEk4Q0h2Y3RkOVRNaDRSUDFJajM5clFrQ0ZP?= =?utf-8?B?MjZHWmNBaEFKVXpZODV6aTh0Qjl2cCtoNkR0WC9nNHlOTXY2dVVCek5xQ1pW?= =?utf-8?B?cEo0NnV6M25WS0c5MHlzaENWOHBJa0hibVpmbzFIdERCdWdBUHlTbGtZQldh?= =?utf-8?B?QVlJSkdCRU5LS1NBSzZTZWo1cXQ2WkFicERNeEtlZDk3QXJiUy9RWFhhWkZ4?= =?utf-8?B?L1ozLzJJTXZTQ0VVMHlvQXBjaFBuYyt5U2hmVFpURGNOc0E0ZUtOWnRqWFNV?= =?utf-8?B?dWIyWVpLZHA4MXFkMUpmWS9xcFNNUDVyUVdnNi8wWjFUYzdjRXJMSGtReWc5?= =?utf-8?B?dHkwTUFlWEhTSkdyRy8vVmhzV0phVkpTR3oyUmR5MW1UT2RnMWlhMFRiTCth?= =?utf-8?B?VzRJZnBzcnljUzZ4WnE2K21JZEZMSjZuMUN1Wlo4bXNuYy9TaW4vdUNLaE1U?= =?utf-8?B?Z3EwS0ZyQ2loMzh4aDhqNUNlVmxINnZLSXpyR08xdGV3dUhjN24vbHMrT1hD?= =?utf-8?B?bkw2OUQ0YVI0Ujg1SW1QRmVvSzhFWlpmNzFIME1TWnRhcGhXcloydW16WExR?= =?utf-8?B?UW9kcGllOVlZSUFCcGo5czI0WTQybWd5RUIzNkhqcDVvaVNUWXJNT0ZFd2ZF?= =?utf-8?B?RTZ3QlJ6anRYQ1NFZnV2S2I1cm1tbWJkellObDJ1UEk3allNdDRYWS85OFBv?= =?utf-8?B?VmZ3dHA2QmQ2ZEN0bUI0Z2Z6enRaU1MzZlZnb0FWcWtUcEpjdk9vangyT085?= =?utf-8?B?b3ptdEJxSHUvUHRBajVrYXc0RXk2UmFSYWRmVCt1TGhDYnpVUk83VTJDSitD?= =?utf-8?B?TE9hQjd0Tk0vNzZxem50YktMWXRxTnlvakVlY1h6ck8rRDRNbHhDNmhhTWVP?= =?utf-8?B?azM0dGhKeW96NWZQeUNnaWhxejAva1pneCtPMHlLd2VITE9EaTJ3Yy9ZeHQw?= =?utf-8?B?Z08wSkFhdXBURmJ6c0NNcll4M0tEeUVybWsyZEFJYWpaczNOTENwSmdnYVdN?= =?utf-8?B?MjVWZi8xeEJFK0FKeEsyTVlSWnk2Z1Q2NjU2bmRpTE1Xc0VzWG1YUlNIbFBB?= =?utf-8?B?QkYyMlV1RCtoSVREbE1JUnFCR05wZ0ZwT0t6cllaQTJETTl5SDg5Q2Z4US9q?= =?utf-8?B?UjE2eXR3Rms0UU5rT01IcXdKVGQ0K2ZtaE5oRUJKV2ZYaXlSeW9JRzFxQlRm?= =?utf-8?B?YUYwSnFmZkltTG9XSzRtbVZqNW9ucGE1Q2ErQUcxM1B6aDlLNWNrY1Bxc0Nv?= =?utf-8?B?Yjh4Sk5LZFZaVmJQRUEzejhtV2htbFpEYyt2ajcrUVc5V1FiV2VJcUlBdVhJ?= =?utf-8?B?L2RZbVhlYS9mbi9uMmVHeTRRMzY4VzlMZGdrY3UvU2llWG95S1g4SlZCMU1o?= =?utf-8?B?K2tSb2gwVlhOeG9hVzN4MDNaM1h2L01nMXMrVVlHUndQUlo1OS9FbTZ3b2xq?= =?utf-8?B?UGVLSUVRU2Fqekl1ODhESUdSZk0wWFZYNlhCY0U5OXJIbEpieFJ1ZDN1YUpv?= =?utf-8?B?UkpTUTVqZnpRbmNNVTBYVmFnN2pvL1FNVTZtS21uQXdDZXJKR3kvc2w4TklN?= =?utf-8?B?OENjcVR6bGgzZUxtcVk1OENkY1Z4V096anpJei83Q3JkTXpGaWlwTGJxQjYy?= =?utf-8?B?RC9VaHVqVFV2NTdYS094cE1vdVpLLzZvMkNVM21LR05NM3IyeWowejNETXcw?= =?utf-8?B?Z0NZSWNZSTVMYnRhY25ycDZ0UmsrN2ZkN2VlWlQrNVhzamdxSHpySFlEWmFD?= =?utf-8?B?K3ZlMjRQeXltMUFLckFsclE1ZWpDRnYrREtiNmExWm92aGYrcjZMU2ZZVUNK?= =?utf-8?B?Wk5hc0lVUHZoWVVBSDF3WHkxaWtSamYxQnNodVpHazRHSmhBU0dsZ3V0VDFD?= =?utf-8?B?R0Vxa296dG5sZlVwc1dpUTdjdWh6QWhnMnZPRS9NSE5CbDZGb0I1WE1OZkZF?= =?utf-8?Q?Zn+5NvmV+Q2HMc17v7pdm9TEa?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3894c676-6db6-4a9b-1784-08da6f1800e3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:03:31.2221 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mqB5IsRPSiyHxKJ6UdsFEri1dCzwvko/13ST02zOmbw3VpFY3ad6MRNUTES57ddWjiE6hljjCxSZaMweAmG46w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6597 On 26.07.2022 16:23, Andrew Cooper wrote: > Signed-off-by: Andrew Cooper Acked-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:03:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:03:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375397.607758 (Exim 4.92) (envelope-from ) id 1oGM6F-000613-JR; Tue, 26 Jul 2022 15:03:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375397.607758; Tue, 26 Jul 2022 15:03:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM6F-00060w-Fw; Tue, 26 Jul 2022 15:03:55 +0000 Received: by outflank-mailman (input) for mailman id 375397; Tue, 26 Jul 2022 15:03:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM6D-00060J-U9 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:03:54 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 286bfabc-0cf4-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:03:52 +0200 (CEST) Received: from mail-mw2nam12lp2046.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 11:03:44 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5264.namprd03.prod.outlook.com (2603:10b6:208:1e5::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 15:03:42 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 15:03:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 286bfabc-0cf4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658847832; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=6o9RvZbTsDfjC8LrRyMyCQQsobqoKLle2HPX71gNEQU=; b=O72JSrsmwp0U07ePn+6QFJW/6yj2wZBN1eKbcxwg7EOhJpnFKMw3Z/Fh d9teQ8pZ5o5MI6rNecMKvcsqBaRPbv5xq7TxpHfgHXLRjmpfyPVQhSe5H XoTNmWQDeVPyA7m8XBVNkafyIQyPAIJVDXbu9b2rH8bhk29mOVixIKYbR c=; X-IronPort-RemoteIP: 104.47.66.46 X-IronPort-MID: 75940355 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:5K77Sawko1PIMbAKXbJ6t+cpxyrEfRIJ4+MujC+fZmUNrF6WrkVVz GYfXz3VP63fMWCgfd8na9uwoUMDvp/cn9RiTQtqqiAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv676yEUOZigHtLUEPTDNj16WThqQSIgjQMLs+Mii8tjjMPR7zml4 LsemOWCfg7+s9JIGjhMsfjb90ky5K6aVA4w5TTSW9ga5DcyqFFNZH4vDfnZB2f1RIBSAtm7S 47rpF1u1jqEl/uFIorNfofTKiXmcJaLVeS9oiM+t5yZqgpDvkQPPpMTb5LwX6v1ZwKhxLidw P0V3XC5pJxA0qfkwIzxWDEAe81y0DEvFBYq7hFTvOTKp3AqfUcAzN1/VnwuZ9QHodx+GCYR1 fMeCxJXciiM0rfeLLKTEoGAh+wFBeyyZsY6hSslyjvUS/E7XZrEXqPGo8dC2ys9jdxPGvCYY NcFbT1ob1LLZBgn1lU/Ucpi2rv3wCehNWEGwL6WjfNfD2z75Qp9yrXydvHSfcSHX559lUeEv GPWuW/+B3n2MfTAlGvZqinx24cjmwv/ZLALM5nl+8Uz3nmS3EkjTxRRW1SS9KzRZkmWHog3x 1Yv0jojq+0++VKmSvH5XgakuziUsxgEQd1SHuYmrgaXxcL84QyUG2wFRT5pc8E9uYk9QjlC/ kCNt8PkA3poqrL9dJ6G3rKdrDf3PDdPK2YHPHUAVVFdv4elp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjzNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:Vh8MvaliCv76mb99WGk5e2pPHzjpDfOPimdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcIi7SdK9qXO1z+8X3WGIVY3SETUOy1HYVr2KirGSjwEIeheOvNK1sJ 0NT0EQMqyWMbEXt6fHCUyDYq4dKbq8ge+VbIXlvhFQpGhRAskOgTuRSDzra3GeLzM2Z6bRYa Dsgvav0ADQHEj/AP7aOlA1G8z44/HbnpPvZhALQzQ97hOVsD+u4LnmVzCFwxY3SVp0sPYf2F mAtza8yrSosvm9xBOZ/XTU9Y5qlNzozcYGLNCQi/ISNi7nhm+TFcRcsvy5zXMISdOUmRMXee r30lMd1gNImjTsl1SO0FnQMs/boXATAjHZuAalaDDY0LHErXoBerZ8bMRiA1XkAgMbza9BOO gg5RPni7NHSRzHhyjz/N7OSlVjkVe1u2MrlaoJg2VYSpZ2Us4ZkWUzxjIjLH47JlON1Kk3VO 11SM3M7vdfdl2XK3jfo2l02dSpGnA+BA2PTEQOstGcl2E+pgEz82IIgMgE2nsQ/pM0TJdJo+ zCL6RzjblLCssbd7h0CusNSda+TmbNXRXPOmSPJkmPLtBOB1vd75rspLkl7uCjf5IFiJM0hZ TaSVtd8XU/fkr/YPf+qKGjMiq9NVlVcQ6duv22vaIJy4EUbICbQhGrWRQpj9aqpekZD4nSR+ uzUagmccPeEQ== X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="75940355" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SIUCcP3S0kVeBU/+beJJVYXHTuwV071RBHn3xu0PTZEmsTXhh0qMtA6xd5rT3HxNcsXFNEAfkxNK7bKpoDbTgSf0nIQ21C+Uk0qX7S6LsPrneQyTHRzYtBvroZLB9tI9DGq2eVRp2esxLTQLd+dfNzi5iP48ZAlU8XOldA8Dw0MqzutjehiuvhoJC2tbN2qFSYpazEu5mPULnppfiEyquIVv+ab5A9PL+LHN1GxgHuYgjPPI9wdbz9i05N0VMwilttvQoPdcJArzLphoS6pJqgJ141SRTtB0wAJaYrOwj7N8Gm/43oQ1w6tAVVVMW2Gu6ErKQ51KS32BViC4G+5ciQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6o9RvZbTsDfjC8LrRyMyCQQsobqoKLle2HPX71gNEQU=; b=YeRH0M6a61LH+Vyv94Kn91y8j/T56Pg0VFH2KXu7pN/kp1Fea0qolImYg75t+s0WsFFfvnfNU8q7YEbTymxh6jn0YWocYX/byPiih96QBRIfmU3j1/0hqBMxbJS9zBRmQBEJRrdgNT80M1qwqEKLA5z4IDhJcO7xrLtg9BzINMEr8VmFY4THGPIyTuE+3L+yuAMWdGfxT3yFVHx4ur3HYAn0Ol91YZ9Hsp0nyN2aDBsKvmFgfv40vRSkiFN+I3A987ippMBhjaGpbslx5OzPjYIhWaX0cQsRa5V/6Qg4BnMGlaahZFQ/Sl3yq2bMIFug86adC2hotEXIDBzBS4ahYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6o9RvZbTsDfjC8LrRyMyCQQsobqoKLle2HPX71gNEQU=; b=xggJoV50svnIW3AuqRb/Fm5mtfFMYIM4HHuWqWprCW15tTxhMoywwekzjFBfifxgX7iOBRyTIREm2zo4ikYJYXCOoZNh1+l7FFVBTU8rbdqv0zBEJr59lL6J6Pe74YBNOOtMGf0KExgbT8M9alA66Bt2f8knbtF1prcCQh2FSn0= From: Andrew Cooper To: Edwin Torok , "xen-devel@lists.xenproject.org" CC: Jan Beulich , Roger Pau Monne , Wei Liu Subject: Re: [PATCH] x86/msr: fix X2APIC_LAST Thread-Topic: [PATCH] x86/msr: fix X2APIC_LAST Thread-Index: AQHYoP4rWPti1ZyqlkWj0N9bQww93a2Qv80A Date: Tue, 26 Jul 2022 15:03:42 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4a3aa32a-acfa-460b-118a-08da6f180797 x-ms-traffictypediagnostic: MN2PR03MB5264:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: srotp9IbVWvOIKZuNlaPNVsBRpDKF0i5Ry6gyJGyiwcqliMXe4yi6tSrjaR7J2vKtE7rVL4fnCVy1u7POmkRkF3eMRuvhfw2zUy2EKKD+wb0QsYIHe46fwRkPmdBU47jW6JAbREmknWJ01G4DLbg5aureWr3N9xCz57qi+FtW8Pa/55tvJsvPPQFRJziXpv+1ZdUjpmc8P97zKWfDdHa9WL0ZyGR1d+blQlRaPf7kVHAXPmiqeGhuHu3TGiiXSNbzu4jsVJ8Q4l7ZTI2qy4Tgc0ael21JjeC5OBFzB/42vCJGnBb4RVrhT959NG/ytBJhDpQSaEKqjeIVtLwXhAlB2x7RbvwUPh1WyqvcMwHpSIsBjraszouZ29GWUW5R/UHcTFcZZ/RM3VTNIqv0c6Xneiv9RIPH1J+GLbpVh5C+hRUHKwGegoHMKIUe7qu1ZaLTBJOB0SrMVQvmjFuntz9VgKKzP/nBnI543QdjUggWiuq0VkCDE+3mlcM5ZEWpVwlhyDm+R6vA+US1//jmnwc0q7tdK00h/fvEMqjZGDTnQIxRN0IkkrnbVDPeDinieieSJOhHIhkOn5D2Enik0xnpwF2P1YxEBUo3Gab3HBPH1Cp0GNmNE5Il8QDCf59Y5cqxd9Kok13yqDnSGvDsbjZhQuuPQora0zJWYm1pZJ93LGfsh9KeFdq41vBnnohulxF1emmi1jmtFoawofiHHxV3kHN+Do2diBMW0u/mKYD01FZ1TiNFdskjtUsvlMnfDpizit2e/qN5n7LeNPm8tHEh3oEeHV5maKeuMH593gFrffMWjasjI+S69HczZMtA79om6XHRQ7W+ENUv8k977/yH1gBbbzipv7/0cBHp4zjVu3pQFhOS2hQ4DB4cams1gJ3 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(2616005)(186003)(110136005)(54906003)(4326008)(76116006)(66446008)(8676002)(64756008)(71200400001)(66946007)(66556008)(66476007)(91956017)(53546011)(36756003)(31686004)(41300700001)(6512007)(6506007)(26005)(2906002)(38070700005)(31696002)(86362001)(122000001)(38100700002)(5660300002)(478600001)(8936002)(4744005)(316002)(82960400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?VjZIUjlqUUNpWVpXeng2dzNFMVYxUW4rZ21QOWF2Znc4U2lldnpoZTlZTTd6?= =?utf-8?B?dTZuNW1KSHcvV3ZQcnRPdDNMZC9mMG1LWGZRNjFveVFOcDdab25WTXh1K1hE?= =?utf-8?B?SHJRL3BQWmYrckl0WGtVbGViV1BPcVNhaVRKNEdqNkovS1JpR2kzQldacjFr?= =?utf-8?B?QXFmaTRRaUVKY2svZlp4QjJ2WjRjbkNOLzRpVHp3UG1iM1c3ZUhGQ2h2dlpZ?= =?utf-8?B?dVZWb0NMeUgrSEhqK0xVVHRGT2ozVVVPY1J6SG5HYUtQQmNIM3NQZGxvM1pE?= =?utf-8?B?Q01ZbjVDVVkzejU1NWp5RWN0TjJ2VXVDUEpuNUlGQXZwTnZUS1BvemdlOXlM?= =?utf-8?B?QlZrcEN1MjdSblA1N1JBSmRxeEpGcjhUNEhSZWgzWnI3cFN0ZnFlTm5BVTBi?= =?utf-8?B?TDBXZkpad0dtaUNqdm1Nai8xYnJEUTJGeFdkNm85aVpEVWNoK2ZadVNzTGF3?= =?utf-8?B?MFFMUjBkVVBoYjFVR3NWYkhtbzV0NExkZWhPcDJXZ0JtSHZMTGdNaVNGY2wz?= =?utf-8?B?cGd0N3oxNmtSdnpWbmhqenFQWmg0K0xNL0ZZVUJ2WC8wVWUwQTZhSFVuc2FZ?= =?utf-8?B?YUJoRUtpeTNNcnYxZ3MwbGQ0SFF6VEhOQTdkUG9YTTBQQ3BHVUY3bGo2TjQ4?= =?utf-8?B?N0J1cWxPbzNwejcyRmc5WExtaXMvS2dsQ1UwdytQbmZNYVB3Qlg2SkRqcUYz?= =?utf-8?B?bEJqMzZCNzM1eFUvTmFtcFg5YjFsMXFVbnVDMXdLRGtlbjJ4ZkkzaFpqZlpr?= =?utf-8?B?OG9Bb0V0NElSMy9BclBjYTYyb0tsVU9QZWU2cE1zbFd4MHFrTmxsdnp3Q0o5?= =?utf-8?B?NytXL01KVm5WZFh4S3FpSHI5QmNYa2dBZmFxQ3E1ZEdZVlFyZ2lWMlBiWmJC?= =?utf-8?B?OVdCU3RUZmdZMGFDa2dabUFHQzNRSXNjc0w1NTQ0RnI4OXptSTJWZEI4bXNV?= =?utf-8?B?eER1UUFVZnVOeVkydnpLRFNuS2pLSk40UEdhUXNjcFRKWDgyZVFJWU1JM05V?= =?utf-8?B?L1lMWnBNYlN0Y0Zxc0lBdmNGRkM2dVJGbzBmYW1Ibk1nM2Y3bElKaGFWNGZU?= =?utf-8?B?akk1TEV6RytycnR4eFI1dzVXcnBGUVc4c0lKajlhcnVOcXhLeXRFaC9KSDJB?= =?utf-8?B?Y0s0ZzkxSUxDMFpZdmF6ck5lOTdLaTlZNWtaSU1hTkw2OCtnbGI4S0x0WTQ4?= =?utf-8?B?Y1RjZDl2ZXZwaFllNEhkSitvTHNnL1Z3UndDSlJvV2twVmJzUmNvWThUUTdo?= =?utf-8?B?ZEZQSG0wRWdhM1Y3MEZLQ1l5TU01c3JEa3VEQ2JVWW95aUlKYU8rTFNUcU1l?= =?utf-8?B?NENuTjJ3WVhLM2U0d1dSZ2VpSnlXNVlKTUZRQ3QwcXpCMzdDZzFZTUNNb2lp?= =?utf-8?B?NGlwVmZyNTBGa3RSSHJETWZwVmxYd2V2Z1l5NDMzYWQ4NVhPd2d0Y3JUbUty?= =?utf-8?B?Y29UZzhSSExRb00rTlVvM1NKZmNoOEt2b0lxaEVEdE5HL2hHMmMyV25tMlky?= =?utf-8?B?NHN6aEpEM3Q2Qjk1R2ZrdGFZdUsyL09MbTZLczRQV25vY1RuS0V3d2FYOHdj?= =?utf-8?B?bXVnY2w0YVY1UmhlWkNITlJxZXhlOERwbEpWZUl0Z0NBSVIxWmNNR3NvK211?= =?utf-8?B?YWlQYmFUSG84TjNwaDZFZEd4cWRsdC9SOHRIeExucVBZOFU0dkVNL0JRZG51?= =?utf-8?B?bVRxZnk2UFdxSEpSMXZhdnpJR3NwelBncGJjRkticXVIVVJTZ1lEOTB1T1E0?= =?utf-8?B?N055Q0lTNWlvU3kwTHVtdnhYMFgyb3dwVkhZQnoxR2RIbGFWNTk3VVFFdmpz?= =?utf-8?B?QklZWGlodDRFQkhiS2x6WDdSLysrSjUwS0ttS296a2lMODJEaHVjM0o4bDdB?= =?utf-8?B?K0FaQVZvNzZZcGtwcHhqRjZLRzdhZjd4cjBnM2JZWHZRV0M3MFVBYVdXcGNJ?= =?utf-8?B?MDBwNCtHL2xiNFpuWVdkNlpBYjVjbDBsaFJSb3BYWWphOTBCNlk5YVJrdkIv?= =?utf-8?B?L3FLM2VxMTlsVkRmdmFaSFNRc2VkWVQ1TlZNelQ2WTJpMzhMdzdBVzNKazhY?= =?utf-8?B?cTE0b1hRM21DOGJScHA5VUFsZHkySmQyYTI1OWFJOEMzOVl3eGVNWmt2bC90?= =?utf-8?Q?mcMk5MP9NAjFJa2CoKmUekzxJ?= Content-Type: text/plain; charset="utf-8" Content-ID: <86F62CDCB7EEFD45A9200929C56DED46@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a3aa32a-acfa-460b-118a-08da6f180797 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 15:03:42.3429 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LTFMi0wN/lUTZ7VgU0fCUuQopMRn4Wf0l9E8vm0wpNuZTj25gkCncaiez0sbVnrvQEREDvxYULO0zzHe5aDG3+0Ko7BUha/gvMrVY7BpqHU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5264 T24gMjYvMDcvMjAyMiAxNTo0MywgRWR3aW4gVMO2csO2ayB3cm90ZToNCj4gVGhlIGxhdGVzdCBJ bnRlbCBtYW51YWwgbm93IHNheXMgdGhlIFgyQVBJQyByZXNlcnZlZCByYW5nZSBpcyBvbmx5DQo+ IDB4ODAwIHRvIDB4OGZmIChOT1QgMHhiZmYpLiBUaGUgQU1EIG1hbnVhbCBkb2N1bWVudHMgMHg4 MDAtMHg4ZmYgdG9vLg0KPg0KPiBUaGVyZSBhcmUgbm9uLVgyQVBJQyBNU1JzIGluIHRoZSAweDkw MC0weGJmZiByYW5nZSBub3c6DQo+IGUuZy4gMHg5ODEgaXMgSUEzMl9UTUVfQ0FQQUJJTElUWSwg YW4gYXJjaGl0ZWN0dXJhbCBNU1IuDQo+DQo+IFRoZSBuZXcgTVNSIGluIHRoaXMgcmFuZ2UgYXBw ZWFycyB0byBoYXZlIGJlZW4gaW50cm9kdWNlZCBpbiBJY2VsYWtlLA0KPiBzbyB0aGlzIGNvbW1p dCBzaG91bGQgYmUgYmFja3BvcnRlZCB0byBYZW4gdmVyc2lvbnMgc3VwcG9ydGluZyBJY2VsYWtl Lg0KPg0KPiBCYWNrcG9ydDogNC4xMysNCj4NCj4gU2lnbmVkLW9mZi1ieTogRWR3aW4gVMO2csO2 ayA8ZWR2aW4udG9yb2tAY2l0cml4LmNvbT4NCg0KSGF2aW5nIGRvbmUgc29tZSBhcmNoYWVvbG9n eSwgdGhpcyBjaGFuZ2VkIGJldHdlZW4gU0RNIDY4IChOb3YgMjAxOCkgYW5kDQpTRE0gNjkgKEph biAyMDE5KQ0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:07:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:07:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375409.607769 (Exim 4.92) (envelope-from ) id 1oGM9e-000709-1a; Tue, 26 Jul 2022 15:07:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375409.607769; Tue, 26 Jul 2022 15:07:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM9d-000702-V5; Tue, 26 Jul 2022 15:07:25 +0000 Received: by outflank-mailman (input) for mailman id 375409; Tue, 26 Jul 2022 15:07:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGM9c-0006zg-Dl for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:07:24 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2069.outbound.protection.outlook.com [40.107.22.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a7173820-0cf4-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:07:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5263.eurprd04.prod.outlook.com (2603:10a6:803:5f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:07:22 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:07:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a7173820-0cf4-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DFPCWEOBwEx7gJvAE6g9GCHi0KcFyABGQyUkiQIpjHMLqzepn6YHrXLIMv+BZmE78rvWd6QUKOlI/n2tyBUMwarFk+etp6Xp5DbwtIXgph1Jl6ayrQNsHiGvRWo2Qn5B2Xs49SNhvebw0SNwcJDb/y0i4TDmms6K1pmWe2eNqfal0kJmN6/iDwNtg8j71MVxjTV4HPDEnkyFo5gdA0ClL87iSIPmJ0XCzXC0wGV81eO7fSpfbfcHwu8rggPoRyTUlGYyn7ozYgU4VnVkxUX1g4GiDBtWJlhMVNL15dVOoar7t1Sl2Ywt3sc7HXfMudkVZ2b/dALUkhPj2DZ45+id/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=P39mLUMBFr+t+yPKzQ0SAp905mLsarWdbXQUoRfK9Ls=; b=nfOt/o4r5x+jPTLmPqhlba6bHYXo8hjrAw7/Ct8KTNs9JReUqczvczulgehQlsw1Oof3lLtmjNiDQcB/9cIxGiMsBH62s/9FuXStHd661vrjAQls0ZiFWbqvB9nUY1jFk4Uy+cSA+53Bs+PHy9/Rma1w7aSLKiegUIcR274HZaD3AIiEcS0CL7weHYsCXbbUZJeszzTTklRJ0KTgjHobtGdaDErEJWd4eTG3SOqdj+ofOIabjnxfh1pomypSoFe3PGJBWy/UoNxpmzdAPDY6JQmYSODBR0xJClHMkm5NMEAGd6n+4I62diELuashfWpKXLWVlqx1ZHfrl7dELvUm4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P39mLUMBFr+t+yPKzQ0SAp905mLsarWdbXQUoRfK9Ls=; b=LGmhI+rguRpxptW4SXu/rsw2ZFiodOJyayDct7+eXFeeBj4vktN4E9y47MLl48UQ3lSpDS/4Klb8nxo8locME42HeadJg1rWixB7aw3a1nBcRgSEcyE0rUyNZpfaR3SFiYZltYooYtLV58vlkThJii4V+3MO5+YGzT0fPCT5O90JU1E5tnNGDMA5BuaLYi2ifjFDl8zFDcs5vD+MTC+6fMjSDk2zU9aMwzMYlDRb0a2ex6OV4MtV5KDtCff0NE32LUc3wK4K1W2BfxiWeg5kPplRouMkva5LbyZA8ye0xvaFdOBGe9//6TNS224OgdZNgpwHEiou//NrCxCytjXyaA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 17:07:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/msr: fix X2APIC_LAST Content-Language: en-US To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Cc: Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 86a9887c-e2d3-493f-332b-08da6f188a7b X-MS-TrafficTypeDiagnostic: VI1PR04MB5263:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QgqIUJtgUEY6bRV5fKQH2X4mErGg5cxQAZDY/5HBABcmz0AD2jz6szybiaS/iLUL+hrCh91rVPYzG80p3cEYqjqp25RXBa2Hi9PpD4ek++dX1z75WcrsN4hWk8a8n8ppgsJAYcdb/oFkNAj9HyV9zPM0C/kPyfg+jq6bvKtIYfOuZwy4A++tc0gszMge/EnVqzbt2n3Yxyi3dDUT4txLo2byyM8GRsAqWPbxk3sHI9Ux/tlZPOre+hEDHCxzlDDHFTAGXF9bj8V6j9CZCXWI05BDgE9tN+FCHKeUD1dQ+bv4bTDlWQIvfkAhYHgWTY1ygczbY4tYw8uaGR81E9cA7qKb9e2Ul8EiDYTkORnLm3NFju9ooMi4/xrezvaCWCEudhrUxiz+JCsHFHrVUbgfnTwf1/cStQC7m0z1ZzLPkV8fBmpkH1niwHB6rBbz8om38YJ9vSE0j0nWEmI/RKgXpBrxJWS8rMvNwy9JbJx4hZ2ct/lrJ5Q6VC2iBncXYxliQfzSfN2Ve0KDddwv2wXDwqClGo1NTtjgc4sPrCNOEl1KMMLh9ITotd5BH4e6OmZExfOc6yFX7p72XnkV60eztNBq2BySKTcdquc2iHYVxg+T0O3kxtzfaqo69+O6/zEI7bNojThELQjo+0CxOeSs/7xlvF0FFfz6LJAFWMbK2+TjNjVYCd4xb/Jl//QqYYOW8Pj8LzUpTXWGyZUKClXCduTJ4ej7yP3JzMUOBsuHpTQIwsWVkErDSmiWI+fmNGJcD0hAkmdORlPnVA9iuKGOTMCSDlo6CzkN302009iWw5Bd/BkMNsNWDC1b+rC650evddbQOiEdmPbY179yMomjiw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(136003)(366004)(376002)(36756003)(316002)(2906002)(38100700002)(54906003)(26005)(6512007)(53546011)(2616005)(6916009)(86362001)(31696002)(31686004)(186003)(6506007)(66476007)(41300700001)(66556008)(66946007)(8676002)(4326008)(478600001)(5660300002)(6486002)(8936002)(4744005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG9UeXVwS240b0tRMFR5SmJSaFdzcU55Y0dzMFYwajhjYnRLeXNuSFFLdVlY?= =?utf-8?B?VHgwcEwwRHB5Nk1LSWlycVVDTUlYcEhVaXAvR2JseGdta0RXSElrUDVpTERp?= =?utf-8?B?RE43U1YyMytCRG01cCthR3ZUSlpENm9LZFVnRlhhd0tIZFB0TjdZb1BLNWFv?= =?utf-8?B?V3NCbkNOV1hqUWRpc09nU2I2NGFjdDZYbWdXeFhhd3FTNUk4Nkk0bUlyRU5q?= =?utf-8?B?aFdkdy9XaGJ2ZFhET0VScGxITGVvU0hXbnRkbmFJQTIyd3V1UjczMUpCR0U3?= =?utf-8?B?VUxzKzVYUDhqTHRMSFY3MU5hZzlTdzl3MmFMZjVxcHJWT1hFbkxITThTVksz?= =?utf-8?B?TG96alM5Z0hIcmdqVS9HMWtjYVVsY0l6bUdxMkM1QW9xa0t6cVlGRGs1V0xO?= =?utf-8?B?blNWdDFrY3RLaEhHK2x4Y0paaWVXVGVNdUNMc2R4V285N3FoZkNYZEVMSkRS?= =?utf-8?B?ZG5sem5xSzBrZHpxSnY5Vm5vWWJNcDdoUkpFMW41N2U3YThENkdZMjY1dzkr?= =?utf-8?B?STJ3ZjFVS0ZjVmNsSmowZkZYNGd0WW9oSDNYeVRaTkgvSWFLaTVUUzAzT3la?= =?utf-8?B?YnlUQUhrQ2pnUlhNU3FZaGhiZVIxaVZmL2hrYklaZEprK2o0dEZDN2Z3cEww?= =?utf-8?B?by9MTzlvdDkzN1A4b2FsOWVkZUxtT21IR1NTOVJrOWx1Ymt6VGg0TUY5Y2lU?= =?utf-8?B?cXpFTGdHcnA2L1doOEs5Umg5TWZlVytRZU9rdnRYZ3M2cEwvYWNRQVZrVWp4?= =?utf-8?B?UXRMVStEUllLNlZkRUxHT2R4RXpHRjVTQis4SFhOYklHdzVNNGZzU3lDSjZ1?= =?utf-8?B?enZ0UjVGNUxUVDZnZjNUMGtaRjE0dVBIdTExTmJ6VnphZWtEWmJTajlhTHAy?= =?utf-8?B?WmJ3Z05lcXN1UkNHTTVkTTRtRGh5aHVQNXhIdC9kN1lYR1lFM1VMNUhnRmMy?= =?utf-8?B?S2ZtYjRWRlBBMElYaG1FcVBUSDJOSzE1VHNPSkZoWnRoSWxmeDRKUTQvSy9L?= =?utf-8?B?cC9vVWUxdlRDTGdDam9abU9LNUpYNkFtUjVaWFFrbVFBbE8vSU5xVmdCSFFl?= =?utf-8?B?dGhITEczUHVrRUdPVjdESkpLU3VTaUptcWwzazJJNnBzNFc5RTM0UVBMbXR1?= =?utf-8?B?Rm80SzRhQmRpYzRhVWhNZ016TEk5NVpvNy9oM2w0Y3pEQlJkZXhFZ3ZCZmF1?= =?utf-8?B?dnJMSVZFYVgzcDVzZ3ZIdTNrenRSS3NNNmZhSjlYTDFPYy92NlhDc1ZVV1lO?= =?utf-8?B?aFlucFp0aXhOenNjRXptcEVBN3NRNHQ1RVBEKytidnBPOFc2VzZzQ0NsMG0v?= =?utf-8?B?bGtVVHBuUEpTTEFXaGgvSUZHU1YxWkdWYmdUdDlqd3ZqTWpkMm5RYXVuWDA2?= =?utf-8?B?RG1aZUQ1akE1emlYbmkwU0MxQzV0KzFMdTVXRWRrVU1hL1NISmRydXVFSEx6?= =?utf-8?B?QjdkbU5pdHNaS0c5bFQ4ZGVuMk9ZaFZUcW5iVnBHaG4vbjAzZWtPN29OclFD?= =?utf-8?B?d2xNcjcwRGZjKzh4V1BsZ0wxODdDaGtmdml5K2tjQUFSc0tDYnFidXBlV1RQ?= =?utf-8?B?SytHOW1WbElEVGQrOEJUKzlkeityT3FvYUZFUk1SQjR1VXBBSEIyQzRvazlV?= =?utf-8?B?ZjBPemNkSjBwQURXUmYzTU5KRWtST1FvakI2cDdWU2lxdHhYc1BWY0NLdVpv?= =?utf-8?B?S1hhOGxpQitEZ0ZCSmJXTkNrQnF3SHhVNlgrSHF1RnZoVE5GeU5ibWd1bXJL?= =?utf-8?B?SGxHRklWak9XcW9EOXFqaTgyME5uK1kxd3N6UVpjSnFYaGxIZHd6VjhXTHpM?= =?utf-8?B?QmcybkxFaWNNNjNjU3U3dVBZcjhGOTZESFg5cGJUQkZkNUJwSFFNZmVNeXRZ?= =?utf-8?B?V0s0cXU3SUE5eVRiUjhTUy9SOEowUHZnVVU5Q3lLRnp0TXZOaHhZTDlqRmhq?= =?utf-8?B?M043RWVlSG5uekVhNjArV2RINDN4NCtUS0x2VGMxeXBaYkJ3RllmeHpJdmN5?= =?utf-8?B?V1RXRndnSlcyVjdSV0o0dFI2S0VPQTVVWFd6QldBUnhnd0NqRWx1eXVhSFIx?= =?utf-8?B?UUQyZCt1cHBrcTk1WStiUWVmaGFtcnlobzg4ZTUvbGxPdkZqdlBVS0d2OG1E?= =?utf-8?Q?4vt7tU21/y+2L1P9m0oDolvrf?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86a9887c-e2d3-493f-332b-08da6f188a7b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:07:22.0824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0iyr190qya5EFBlz/BkcjQPYPZ+tPoOIhQZaf0ZmQ13ew4lpqzt+eS1+Ze7nWY+9RJsM0/NEqOpAflZajW7v+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5263 On 26.07.2022 16:43, Edwin Török wrote: > --- a/xen/arch/x86/include/asm/msr-index.h > +++ b/xen/arch/x86/include/asm/msr-index.h > @@ -148,7 +148,7 @@ > #define MSR_INTERRUPT_SSP_TABLE 0x000006a8 > > #define MSR_X2APIC_FIRST 0x00000800 > -#define MSR_X2APIC_LAST 0x00000bff > +#define MSR_X2APIC_LAST 0x000008ff May I ask that then the now open-coded values of MSR_X2APIC_LAST (two instances in vmx.c using MSR_X2APIC_FIRST + 0xff) be replaced at the same time? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:10:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:10:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375415.607780 (Exim 4.92) (envelope-from ) id 1oGMCN-0008Pp-Kz; Tue, 26 Jul 2022 15:10:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375415.607780; Tue, 26 Jul 2022 15:10:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMCN-0008Pi-IC; Tue, 26 Jul 2022 15:10:15 +0000 Received: by outflank-mailman (input) for mailman id 375415; Tue, 26 Jul 2022 15:10:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMCM-0008Pa-63 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:10:14 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140043.outbound.protection.outlook.com [40.107.14.43]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0bd5e491-0cf5-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:10:12 +0200 (CEST) Received: from AS9PR06CA0624.eurprd06.prod.outlook.com (2603:10a6:20b:46e::27) by VI1PR0801MB1742.eurprd08.prod.outlook.com (2603:10a6:800:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Tue, 26 Jul 2022 15:10:09 +0000 Received: from AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:46e:cafe::ed) by AS9PR06CA0624.outlook.office365.com (2603:10a6:20b:46e::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Tue, 26 Jul 2022 15:10:09 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT037.mail.protection.outlook.com (10.152.17.241) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 15:10:08 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Tue, 26 Jul 2022 15:10:08 +0000 Received: from 4e8266a0ddb0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D966AEBA-86B5-4CC3-94FD-CB8F038F0017.1; Tue, 26 Jul 2022 15:10:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 4e8266a0ddb0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 15:10:01 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by AM9PR08MB6850.eurprd08.prod.outlook.com (2603:10a6:20b:2fd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 15:09:59 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 15:09:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0bd5e491-0cf5-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Rwd+dgJvHu884DWt66eNozibCGOO9skRSjMP6PrI72osjxVDmlaECxpVEviwdVwuATu2uZxnUDFcsJOfJqY6NyfHhYcXAWynpemLodXls5ZVZmVa5FsbeNyWHD9GMwvNOKy1+vuDvH9CZWEdFUmtI0L2a1J87qjCCUWFCTEZyLkR0zbOWiCp+TJhVlCjpW/9R9aqMkJ6KBtn3u+bXovsWdDP1jjUJSt8oKJGTdbOSkN0emd2xKSDUjfnVFiHQYCY7ujCWpvl1wjkfe1CTrCmcEmUNirASsq0qsacKpjn6M9+Jw7d5kLDnA25S8mlrwtoD/cNhDPsGNO/GgzBFl+R+A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=YDDnI5+T1a/Cmjl3s0lpcr9DzJPJxZdLaHAA0YEps4K1EQ8VtNkbJ1F6BJkpFpnNtLfkYRZvG4YQXY2B0s1X/mPfnUobW0bwtcGwp5JVV+Unxrx1ExIztTvfsUg+WHFk16D8SiRbc1OWi70kkD0IH6tOe4czLxrmofd0hqjKeanVFPgWJpPAVCimQ62o/rWVohxjgxyWHpYWtMr1vMSPhpS66L9yEYKYZtxcE4jKdKvGS7mwMlVev9LYNzIG6sOFv+hUrXINwF9KzOKX/oUHJ36Nl+5j/ywOqXIEQZ6Q6m9RvW8+e6Jhdq/3IDk6J/LYkbnu7QljdpGbctsGD2ww+g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=uEF/Q0luYy4aDJaDP+9DNUtgzwXe6eRwDaosyncKFkEaA8asU+D9qh5bc96nyp37laZqiTIsJ6DPB99CsbcivBKlAHIdiWV/KBJ/6acem3qKRaIYO8M33odqPc69IJP6PyePqoio4irk2D7qbxq9moDqEX1PNmfj/uHRi2kX9Qw= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: c14c108640d208e0 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d7XP6k5u3JdMmRljeGQV0pxX4jTqAVYk7LDDT1AOS0z+kLmz5Di9xtpvfdbp2lv1gxl50N8tmYbO/i1uXtXFQc411V/VWgpBNHr4tjx6DchI0iyvCsNZe65A51b570EhcItkUdNv76jXvlK1bXCOagdJWdN+FW4OnBcN6ez0U5FRE+B/1vXQORrmbhKnfnjFPtJzIcjTU3R2XesUXs+oCZyIwgFxtpluaN8SKgagS/ZPUXi86/NDhPenP7odY647c8K0G9dnpxCy3u4l+kUKW7UhZyTMjtLTpM64TlkeYGllGpDrfRTi+aOTyr1sSCvj/Qwq1tfaEqZJEpYOV0yNnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=b0Zbh7jZ41eSJZ21HWikDD+k+7fSUp99zNYB3Qx68IpdTxucAQP3UANLPJwRXJfLFyIrx8d7kIWg/fgS0YNoEzYCOF9b+JFnvjYKn+kOlDuWgP10PMboXneaF1u3qYwvzD9WHyI5ixh91K/FRCINivAgf8lz8bAeWZSAp9YToZxaqaOQ2i3C+acT8cz/iyFdKvPFj+Db1tDVxpVMyTNOR3w9E9mfIMsN4RWTeZsk0g0rD4PODe9IQz4/u6PvlifcXUv2wrUCb7xmCT0B4xGCaGpah3+FO+9srSGvxaBmb0jUXJ5TjRxlbg4i3Rm35HpJ9tW3nMlmTDp2DFuMw3osXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SBSjKsQeYHjf8o02HUbbhuAyN3XwGnAXi1WwZGf5xd4=; b=uEF/Q0luYy4aDJaDP+9DNUtgzwXe6eRwDaosyncKFkEaA8asU+D9qh5bc96nyp37laZqiTIsJ6DPB99CsbcivBKlAHIdiWV/KBJ/6acem3qKRaIYO8M33odqPc69IJP6PyePqoio4irk2D7qbxq9moDqEX1PNmfj/uHRi2kX9Qw= From: Rahul Singh To: Oleksandr Tyshchenko CC: "xen-devel@lists.xenproject.org" , Oleksandr Andrushchenko , =?iso-8859-1?Q?Roger_Pau_Monn=E9?= Subject: Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Thread-Topic: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Thread-Index: AQHYm5cRehGtwJp7b0+IIGYzLnlX7a2QzFsA Date: Tue, 26 Jul 2022 15:09:58 +0000 Message-ID: References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-9-olekstysh@gmail.com> In-Reply-To: <20220719174253.541965-9-olekstysh@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 303f1c5d-6942-4e8d-a7e1-08da6f18ede3 x-ms-traffictypediagnostic: AM9PR08MB6850:EE_|AM5EUR03FT037:EE_|VI1PR0801MB1742:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ymj21X7uiR6W6dPJow3zrOw9/4H3nk4MwnOXNgYomjOvsMptoYh54PY+5CMrvqhR4qwHLb2LISL6LvY9s5qHDOkdiH+GAbketLklXQIwefyaEut0prM/nONIFwDV1azc+WvJlVQ/wls1pzgVsACjl+KrOGs0husKyBAWBNUl0BXOMG5+yyHYe/+tEG5YKvUWdjq7o2WqdawCb0KqLUqZ+VgR6sXJAIYdbzMRSbcu9ubMCuZP1wDH+mY96jGX10gHWp/JXtNZ3Sr23h8ubRbLQKPe7yRXNnB5k76EalKp3qkLDfPqWF0oTNAqZMiyVi1A/mfp1DCpniS2mgygzzThhm7Y8EJ+lVe1WqLJrpx7vhdVXYpSD3UZHVgfc/18lABDFEIiuqOUu9rIdCzHSvPZRUVyhxf3bn9yjEA9kcooep0pi0V7jrSzl3TV5hduOwovYpl1xHYyVsTa0ErXYBSP8oOXMeKvV6fxATxdyxSXZ/dgDdVpgThYP6SCANLvromDRYgf/5bRFKq1S+PE0LhrjfPN3UbENb4hvoHV+jCIVT7ZHB+kkdAkKAnuS6Nk4W/ojKcfXx43tkjVN9hBKGrLG8AKfQ4oSQh+XrHG2XW5QQ/u5DGAOQAjyjYWhHCKgXqVW2ZUyOi55dQ3/iYZtg+5r28/WLRZcdkvAuXkArmCdVjrWU2gIdxFH+vH6OSoXE27z7PnpyziQbzG1SANPbFMu+Y75+NK9VKMyYrJxP/P2/Q/6lxT+VR9zQHd1fpc3I+TzjIumyD1qoDguB5ChCTVW+ppLqBjQzFLw6SR7rK3qgVNLGI78+Q6uObj3yngKQPSNZDkqOY69dM+SQAx3+QOBQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(136003)(366004)(376002)(66476007)(64756008)(66946007)(71200400001)(66556008)(66446008)(8676002)(186003)(6916009)(33656002)(54906003)(6506007)(76116006)(91956017)(6486002)(36756003)(4326008)(316002)(83380400001)(2616005)(122000001)(38100700002)(86362001)(26005)(8936002)(38070700005)(6512007)(478600001)(53546011)(5660300002)(2906002)(41300700001)(4744005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6850 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: d15e0c6f-2d9b-4999-dfc2-08da6f18e80a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hu89KnNpPQpnO7GGMssWuPunZgLI5PW0AlQtpHRsUa1klzDrgj0wyUQXy2utYZ7ytAx/gRpkih57K0RZGY5agEo12c/cbNZXRZ/GE6PZaVXJvqh364pPVtvjGh8+OSQHAsDZlnMWGmV9hZa74mRtU4QQeUIfDJruOyDJY+4uEaQkAFhyhWOAXDLjmdbiJyifVLSztF9Q4L5INPJLwQ7zz3HYsadsVPvNjuBxeIvr6gDym2QhCwjFf3kYIcm1XvvUNWe6V75Iqktqqh1qOtMt8eEbAxlk0yiT5LvVEviUhDTcla8+fCLGiopjZ9FCzJPfC337vPf7DRsoWoI56x7QKnJGxK8yeRzPjnSD4xIiP2je4kfl0G3uP+dMcOo/rD2R3wh7DueXfYETTxopD4Ftqo3dpUrS6fH6gUSkbvCf5n5L3xAB7vUiCReNsDxS5ptH5ECOzXpaDAxRMI10vehon0ornWgIlcT+eeKafnIXqvB4CEJY8auzrAiB6S1+rCLHnXYpWto1eVChVbK7+RBWrh50meUfTAC2FeFDjgoty16hKNkqBOBdL8csllruqrcSdipxERziIYu0WtDAqnejWbETGnT2CCkyxBZgqzFOpWUpk8QxUvGQxuftAhe+JDDhpltps8kHeCvqxnha4sZdv2yAqcjzl9IcoDcZDLkRZ26X3pUIBX8N+oykG1gWsE3j+vkuoHVgl2WsaN/RVG6RO6MFmiS9fXfn0BQYtLGSmkSNGy9Xp7gZbNJQGUToJuvPfsE1lCGsmkelYlecJTwCoRpO1a0xHS/A+PphtZMn85Ov3/gW17A5qZIqR8YayFeX X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(36840700001)(46966006)(40470700004)(2616005)(40460700003)(336012)(33656002)(47076005)(41300700001)(2906002)(186003)(107886003)(6506007)(86362001)(53546011)(36860700001)(6512007)(26005)(82740400003)(82310400005)(83380400001)(5660300002)(40480700001)(81166007)(356005)(4744005)(4326008)(8676002)(70206006)(70586007)(6862004)(8936002)(478600001)(54906003)(36756003)(316002)(6486002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:10:08.6739 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 303f1c5d-6942-4e8d-a7e1-08da6f18ede3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT037.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1742 HI Oleksandr, > On 19 Jul 2022, at 6:42 pm, Oleksandr Tyshchenko wr= ote: >=20 > From: Oleksandr Andrushchenko >=20 > Reset the command register when assigning a PCI device to a guest: > according to the PCI spec the PCI_COMMAND register is typically all 0's > after reset, but this might not be true for the guest as it needs > to respect host's settings. > For that reason, do not write 0 to the PCI_COMMAND register directly, > but go through the corresponding emulation layer (cmd_write), which > will take care about the actual bits written. >=20 > Signed-off-by: Oleksandr Andrushchenko = =20 Reviewed-by: Rahul Singh Regards, Rahul= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:16:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:16:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375422.607791 (Exim 4.92) (envelope-from ) id 1oGMIC-0000er-AR; Tue, 26 Jul 2022 15:16:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375422.607791; Tue, 26 Jul 2022 15:16:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMIC-0000ek-7Q; Tue, 26 Jul 2022 15:16:16 +0000 Received: by outflank-mailman (input) for mailman id 375422; Tue, 26 Jul 2022 15:16:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMIB-0000ee-IB for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:16:15 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140072.outbound.protection.outlook.com [40.107.14.72]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e347f74a-0cf5-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:16:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB6483.eurprd04.prod.outlook.com (2603:10a6:208:16f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:16:12 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:16:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e347f74a-0cf5-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aLQ4oePvXTcbGQDpJ5FuZMIJPvpNomcgAO6wijIqwmQ07yKconfVHSxdg/X0I6V1Dzj8LUe5kjRjKjKv7XZ/iOOC3Ik9EUk0fgOvfoWplIZJACW7Mplw7fmFStcnKGze/g/AEhPB7/3dbVS165XnPky59XjCaDrSHWWKiVgws2xGXG1dPmk701YjFzlEBGg82kNKyG8k3IxXgTtDlMGWXapYZdmxEuNEiXSdoIMJoRjGWIHeyp90tnbv41xHLs5w5FcQYhTVO0vCFxtNubsmYfQmBcCCHHBWGMYkQW9Z85qM2tKD1UgAxiP43VkK4UcAxlNmj/xpdLnKOFV+F1DBrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hr6t49yUb79LjGrXkFo3m9F1lS3uPNtudkh55r7pH/o=; b=OxZTUu25Jlu3DfC5WlXF5Demo7y+1EyYfmDCTV8PleCT2cUNYWxvJnOizlgb0NUxP+31voBWJoTo0CkyrO5yNZlas3AZY1Puv0oHYj6GIQ+qlDqSCXwNCCiIL6XSVJds1Rwla1b/Www0pzYa2Hq2lvd8rLb0nftzYzkF8yFwesuR61fQpyTJCZu9u2QyfFG8OYTlQ5ZZM6FZibOFHIjw2oFmE+mw6E3x61hDehLKc4naQGUwzVyBFupaiJoXU6Zmu8p0bR65Z8gGy9p90Hfs2NZIdaw5B7kDw8XnrBFeAhKriG77annZLATIrZfH2pes2wpbamqhN3aIRpZqON5hfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hr6t49yUb79LjGrXkFo3m9F1lS3uPNtudkh55r7pH/o=; b=Zk6dAQdNLUUfoG+gbnhTYPycJcwKpUUDy1xD+18iJfqWVyc3F45y9zxvxC1sg9t8LdmTS4tDZTzbIWGfWpGhJ+6UmtcZ+dUqZ96ho0W8v+f27eGFRXd8AUzgmnH4iOTQaC8sz19yBWcy/EAqUPyPX0lyeT49eHznz0ARdJu9xGf+LkMp3fyEy8Zb9JzNmxrMefy6CyVoqG6egR+HNNVmMdjryEMDmG9/Wp6g/MMlB3gQiFvhSrGt2yIq3hmMv49AIqWT8j6FqCGZ/qz7y35LkteKnn2CwPidpcrsVmox0+zjyjXtKdxRg3XFQ1tfplfmmtQMGNX5FCiQkME3EfH5CA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> Date: Tue, 26 Jul 2022 17:16:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-11-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58e3cb54-20fc-473b-e185-08da6f19c66b X-MS-TrafficTypeDiagnostic: AM0PR04MB6483:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ipIbBXjJDbyE2SD/xKStHNkWHiwye1fsAUDcOoTX+SxzuDRJwg2EOmb1hv7/XuYegne3g6orrXwjeFFNl2IWsOTb6cS1buWyO9tSTlufZMBUU8I5ejD8qAXcBNxxUdaE1aSllydlwQsItBnwAcEH8umKIBzfI1vmx+o3S+teXXX/UqwGumzCi9YW+DU9fYMOKFU/XYBqLIUH9P5n4rZx5LCD4zxi+hHnyEMsAtEpiU2B8SgIiRe/lt8n+V7UENoLBW0Ls9jl+iGM9jrCfSqJQyv6F/aE2xDnFrzVfLfr09iv0T66YTf/RCd7Wl8+tMUgAYsDcpXTQQAqP1KK/zKUcRqlPc4Z+i16zbRqx29PSRUOE1xjqiZjJcUab6wEbv9GhxssBhVnzHGHzfy8pwKyGAGuF07hraPMKPgPk/dK6Q0NPjY+tGWao+6glgpielfZZlAAusxxodLowDzi6Bo6iqz3rbRfrcBpK+Z+7iFWKlUYcBxpYGVL1TgqCbAi3PyYdfZlQKD+WJ5/3qz97zJuoJKABAUZBVvA/3n5ep0oNM7Hsygo6ZwMk2uq8OX7me2lafJICqihjEQQH4lOIJbi0FrUGkG0ObHT0TAbfHXrias1EkSrPCN0igy44EraUfsd5R3icXOpW73cz4iOtZMxI72xmKXsNej2FzNYsOBzvLoHCv3deaMN0affCy19RwPejnJbebVAWImwL6OuruFPR563PrmJrFnWCa3xztJmHvvweEjzkfmdgtmat0i6FFf6KGifOK5BCTEHiLGtljb707rsQFfuZ/sfIlnmUZfcqhoVXBqoR5ShF/1yDLAk4I6x8I2zcGe6oEuNnOqleDcRaA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(346002)(376002)(39860400002)(366004)(36756003)(316002)(2906002)(38100700002)(6512007)(54906003)(6916009)(2616005)(26005)(53546011)(31696002)(86362001)(31686004)(186003)(6506007)(66476007)(66556008)(41300700001)(66946007)(4326008)(8676002)(478600001)(5660300002)(6486002)(8936002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RDNEdkIwczJ5eEljTFgrN1RSUkl1RHBGZm1LR0dweHJBUktud2YzL2lSVGxY?= =?utf-8?B?L0JyamdoV3B6YXYwVXBqV0dTc2NqUUdWQTkxQzRNT2VsT1duUEZlY241c3Uw?= =?utf-8?B?RU5BN2t4L2pLcHdJQlZ4eXpXZytnUm05MGl0dnRGQzlsTjFWTU03ZmVkMXRr?= =?utf-8?B?QjZLSGtIMllxeUsrMHJSc2dNYitoUWR1Mjc5RWk2TEhCcHh0YWo1NEdVd3RQ?= =?utf-8?B?anZweDFHakJqUFlCckZTNS80OUNUQjFnNysxdnllZXMyS2doaS9zQ3lQS095?= =?utf-8?B?NDczcUY4dkh4dkJGODBneWNnTEpsOHlVVkQvcnVzd1R5S1drNnl1N2IrVlVZ?= =?utf-8?B?ZzMvOTZZTUhKK1E1bmlLRFhiMnlib2J5Z3lYaTJ4dzhsMW96REF2YTFkb1Yr?= =?utf-8?B?eFQ0ZVd5YmRGdU1NbFh2WUNqWGlIN3BPRWpmOUY0bVlqNHFWcEx3TVRNSWc1?= =?utf-8?B?a3A2VXZlMzZJNDdpaXVtWFlJbkhUbEE4L09wTThlUmdUejcwWElIWW9xVUZY?= =?utf-8?B?eDB6dEE0Mm1JMHovRCtKMEdobXJoUUMwbTA2NW83MjRmeTIreWV1dnhqazV2?= =?utf-8?B?bjk0Zlc0Q0RQK0VIU0FzVmJKQXJxOXhZQmc3alQrSGlVNGl3R3dBL2VjUGZI?= =?utf-8?B?U0xFVDAxdjNWaGlMRm9KWG9zRmE1b3F3WnhtL2xmR213SVg0V2lHZlBxeThp?= =?utf-8?B?dUFxUjdBM1RBS3grT2tJWlRqMVhIc0pCcEF5Z1hnZnk5T0M3RFZCQ0RQcE1I?= =?utf-8?B?L2pKOHU4cDZQQjFyOHhvYktNZXhrT1JWTHJZRXdXMUREQnByS05ueHFTdkQz?= =?utf-8?B?R1lLSVJiNzZtT0ZsbHZxTHpRSW00dnRWQ1NEM1RraWU1M3lpN2pJK0hVaThG?= =?utf-8?B?NEhBTjRQaGgrNXFISmdLQWJCZVlzVDlsRzMrRU9pdG5aZXpwdHpXT0drUHFm?= =?utf-8?B?ZDVyU1ZGaHltdUNKQlJBOXBWSDZFRlJSL01xQzlSM1ZDWWZmbFFaTVl2QXA5?= =?utf-8?B?SmFaWkNJaE5IYmkwOUtYTUkybmRNTzJUS1RpOUdMOEk5Z2hPcGdTaFpLNGFS?= =?utf-8?B?WUpFZmg0RDlCd1U3UTlOdW16NzNZd0wwaHo4Zk5nQXhhT3dEMllMdW1kTERv?= =?utf-8?B?WjB5MS94MWtjelJpS2RQV2loRWNoUTZ3cG1HcjNBZHJYK2QvSEZwWnBHdndq?= =?utf-8?B?N25Ea010S2FQRkNwRGxjVHJOdTM3UzQ0cCtUUUFDZGlMa3FWaEQ5SlpGbUZn?= =?utf-8?B?TXpIL1NsWHN6ZVk3UjVOQVBkakxPMGs1M3FBS0hOMFVrVlVsVjBITTl1REdF?= =?utf-8?B?MnM0VEMyOG92cXZqSDFxbFZCdXZFZ2pqT1FLSGRDNnhVSTZJTkRUUXBsU2xV?= =?utf-8?B?OTBtd0UvU2t3R01EZ0h5L2E4SEtoUTl2Ym5pd2xYaVd4cU1PYlNDRUhRaWRW?= =?utf-8?B?Ni9PZXJBdzJIb0VVTFc5MnJvV2pmUGJ3cXlacHJSalJqWVJwNWZqNGxWNWRi?= =?utf-8?B?RzM0MXBQUWFSZndqZElFMUpxZktCRFR2QnEzL3J1MS83NXRpV2ZOSU91OGho?= =?utf-8?B?VkptUzlQdDFNZ2NzNURaakJyVGx6S0swVklUTDRZNUZ0ZUlCTGZ5TzlpMG1z?= =?utf-8?B?b2QyS0VTa2d0OVR2M25ybG1DNzh0V1FXUDd0TzdwV3NMQWZDQUZrcVJEcHRG?= =?utf-8?B?YjJkODlQd21zUWVwZXdUcExBUC9WYzcxcCtvL3lpQ1Vka0VDODhac2RiZUJq?= =?utf-8?B?YSt5bGFYR2ZUT21PSHpycUlhSk5FcUdZcGhBYm1kekFNNXlCSWRBdFpLZ1Fp?= =?utf-8?B?RThnaGJPeGtEdzlHNmw5T0xEdXZaMmp1NDBHeHZtV3RmbTJ3dGdzd1h6akor?= =?utf-8?B?V2JieG0wakwwUjVuTFFqbTU5elBkWnlLem9PVWQwTkZ0eU1ONTk2SVd2T1Qy?= =?utf-8?B?enppNXRBdFNYVDFzNEhjVTY4aGNGNGtNdFNyTVpQcUZDL1FjMGtkTHQ3cnhB?= =?utf-8?B?MmVpbW52aW5zZ05Wb29zNXF1NGdyWm5OZk84ZEo4bWF0OWkvWSt5Yy92NnFP?= =?utf-8?B?bkVTdjhZOVhQQWt0dmtpZWZoNGNYVWhoTHQxclZ3UG1GUXd6S0tzbDBmY2JR?= =?utf-8?Q?y3U/WmVcXXERHM1uLi6Rbxuq+?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58e3cb54-20fc-473b-e185-08da6f19c66b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:16:12.1733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Du9tnvIkFGzMDtmrL4cuZX1Z8wUp4nPGY8ssMjvKslK9VGyIMErxGA56Jd7MOvIiDV/zAu/L3/mn4ev+PhTkew== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6483 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > --- a/xen/arch/arm/vpci.c > +++ b/xen/arch/arm/vpci.c > @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info, > /* data is needed to prevent a pointer cast on 32bit */ > unsigned long data; > > + /* > + * For the passed through devices we need to map their virtual SBDF > + * to the physical PCI device being passed through. > + */ > + if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) > + { > + *r = ~0ul; > + return 1; > + } I'm probably simply lacking specific Arm-side knowledge, but it strikes me as odd that the need for translation would be dependent upon "bridge". > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -158,6 +158,32 @@ static void vpci_remove_virtual_device(const struct pci_dev *pdev) > } > } > > +/* > + * Find the physical device which is mapped to the virtual device > + * and translate virtual SBDF to the physical one. > + */ > +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf) > +{ > + struct pci_dev *pdev; const wherever possible please (i.e. likely also for the first function parameter). > --- a/xen/include/xen/vpci.h > +++ b/xen/include/xen/vpci.h > @@ -276,6 +276,7 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v) > /* Notify vPCI that device is assigned/de-assigned to/from guest. */ > int vpci_assign_device(struct pci_dev *pdev); > void vpci_deassign_device(struct pci_dev *pdev); > +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf); > #else > static inline int vpci_assign_device(struct pci_dev *pdev) > { > @@ -285,6 +286,12 @@ static inline int vpci_assign_device(struct pci_dev *pdev) > static inline void vpci_deassign_device(struct pci_dev *pdev) > { > }; > + > +static inline bool vpci_translate_virtual_device(struct domain *d, > + pci_sbdf_t *sbdf) > +{ > + return false; > +} Please don't add stubs which aren't really needed (which, afaict, is the case for this one). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:18:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:18:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375428.607802 (Exim 4.92) (envelope-from ) id 1oGMKW-0001Ms-Nb; Tue, 26 Jul 2022 15:18:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375428.607802; Tue, 26 Jul 2022 15:18:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMKW-0001Ml-Ks; Tue, 26 Jul 2022 15:18:40 +0000 Received: by outflank-mailman (input) for mailman id 375428; Tue, 26 Jul 2022 15:18:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMKV-0001Md-0N for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:18:39 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 382bc73b-0cf6-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:18:37 +0200 (CEST) Received: from pps.filterd (m0174679.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26QE4SSu007640; Tue, 26 Jul 2022 15:18:27 GMT Received: from eur05-vi1-obe.outbound.protection.outlook.com (mail-vi1eur05lp2173.outbound.protection.outlook.com [104.47.17.173]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hj7uyaffe-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 26 Jul 2022 15:18:26 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by VE1PR03MB5616.eurprd03.prod.outlook.com (2603:10a6:803:11b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 15:18:21 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 15:18:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 382bc73b-0cf6-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BdE9KfUEryrVVcLn5YqzOMXnzpBZKCrl6mGmU3BmV7DskyWF3ELjR6M51q/CQODyTpWLUTsMW2KuuERKYjqGMbMCo7uGUYRRiOLXOGUQGKQ8vom/nMNW0yZ+3pcw0SCB6Llm2YfBewLFD1JXvcc1YWS8PkZaqq6bs6w3gyFEoGUp7u3rtPrkH4CZIgAtaidb6BKuT7j79ArfhVvGvLJmVPCzOQXifjGXjLlhi2J80gOCqo38EwYn3BQUzR7myrbdBCJx6TYiytOCgvhvGPkB94JpYwhGLGSFLllW4QJ1W0nHTvDhcjCFXwox2VWrkJtrksaHzK633mDEwO7WhtD+Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CpcmGGqDjuqxt66c3UKMlaChzXpEtDoAbg6TvFyqMgk=; b=KPbPJVorF1XT3N5c32g/qy6EjkQ0JLViEWk/tgtTOPGRE11Dhi7x1e8zpsYCuyc08o6LCcVth19fkOYSc9z/YJlKeg3X8x4WHv6Wmita1mFf429PtIylz0+UWjRj7gNB0EtK05B54AP88HgO5u3tlkjoNOdZSWP9FtdbzmQKnTH8YAJ4wcvsJWbuTSCJlAGObIUwl/q9yUoL7kgSvQVifPlMdKOlhPLY81zrzF8v1ohAYVuHmB4VRNrhttr26VBQ/7VwONt6+GNSNPP7WBXufA9ZxtEjGKdkSkB9kC9DQzRmmQRSyIQWYVOPgDII4BHOF+HrwMKHJb8u5HbHLD07eQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CpcmGGqDjuqxt66c3UKMlaChzXpEtDoAbg6TvFyqMgk=; b=r7P5QeDTik5u4fqrTGkZMX0FG53hIUHRkfOYUMQ9lxQ/OTZTwr5fucsjr104Sc2a3cxRaZDKLEhohY9nJJDbCv+jTAXJxxTWlMUNcjOlzmPNnGaIX5QuPOQ0XYA9jg8wntnhxbKjKeJc2TGN5Jke+J3sgf2ImiWAF6OxEButccOhYNkWHJdXh3CWXhh74zcsEM9gQpkFRLOvzbSjjNzyt8hZY89TH0PYMoNQnGHCq7BpwkkTwilO2mvRre3hZGs0uYp1H5OLQrGONeyfxktHKnTGzWj2oLOCpN2e6XlJ4Vz4B0kJwkie8gaZA/Yu2mHqpLdsfIrMzrV8qXW4D8xNjw== From: Oleksandr Tyshchenko To: Rahul Singh CC: xen-devel , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , Paul Durrant , =?utf-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= , Oleksandr Andrushchenko , Oleksandr Tyshchenko Subject: Re: [PATCH V7 00/11] PCI devices passthrough on Arm, part 3 Thread-Topic: [PATCH V7 00/11] PCI devices passthrough on Arm, part 3 Thread-Index: AQHYm5cHu+4wDbWHSk2myAxnsrAvWa2QtXSAgAAZPgA= Date: Tue, 26 Jul 2022 15:18:21 +0000 Message-ID: References: <20220719174253.541965-1-olekstysh@gmail.com> <4B8A2C5D-194B-4C15-9F4A-C5703CCA5727@arm.com> In-Reply-To: <4B8A2C5D-194B-4C15-9F4A-C5703CCA5727@arm.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 47939d57-ad92-4281-4ab3-08da6f1a13a6 x-ms-traffictypediagnostic: VE1PR03MB5616:EE_ x-ld-processed: b41b72d0-4e9f-4c26-8a69-f949f367c91d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /mN+IIlJSzFuDkvk/h7x8+IIe0UEBfPijb0ACrAioFngaZQDS9N/t/NzZlqO3ZnqoGl/g0eF9aQcLx5xZy2DtlLGaeNx6RLggkjzD5G8oWLooOkGhlVCkbbSBsjL7gmXBfeOMjSiKsHMA9Q0DAR+WuX0Rok1oxKRQ+McN1B7BQIJj8fSNWIjHwgXQJpZACfkHQrjWQUKQw9j/Vjmk+1NeOmHpZ3ALmq69SQc8Lk3lsiVkK4oDhH7JFARF+BL2tYJYd1pW2ar1qrtLdEwm22+m9qUL09YLi8H/81UPU3fwzZmiTvxNY+yOcLRQ0XtgbESVJHpTJTHZzY4vD4GtwPiiFuyYRx5U6Zb+7y5zfbW49zbuFuf1T/3SqkMweEbz2WL7h6uWuv5duN0fnEYyqy1N3rgT/Y7OrpZkzSxAi+dR2ABZhp2wKZ/5xrhROaJd1FDfzqLakO0yQgdj5hwlAPF3kgrsLMfa1lMzcg2yhcg1hpKQdFX0fapzAvZs0QfFwBighHcn5mFVcIKJ4/5iIoML1zOEE//ImsmaH/tDlPkVpnZc0e58lE/5O5Ja8oS5NiwO4Il+eW51P4wimc0mSyRd2U+pjBh9WoMo1NKAf4Uxkxi5jSG/YZlaXi2cKZyfHzK3VQYHkQwSXJp6jXr6yklGX8flh5szHiKGAJ4URuQ8yCean6pbJcrzmULO5ehlXUKWoSoVp6HWn/d6pVdIsLn6x7H8REhXtoEOv4ROADvwDw+kR4AQXkrxJ954rojPSXdZzFHfDvutbPb8ryPhUKtogt8xASR7yuPhuVUTbKlDcCOrPvsdOuAgWjOSdnjQ48OwliSuL6JJ5XTAhUhnNK0HHvVRfCEbbmMIYjG+Bq9aun1Xw5WQ0+ybvldILVCC6/kvD4ypc2y4VGIU5a/H5tcNwLgD+I3IQ1K7YvIl9i+An0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(136003)(366004)(376002)(346002)(122000001)(66476007)(83380400001)(91956017)(4326008)(66946007)(66446008)(36756003)(8676002)(38100700002)(66556008)(6916009)(54906003)(316002)(5660300002)(71200400001)(2616005)(26005)(6506007)(38070700005)(41300700001)(966005)(55236004)(76116006)(6512007)(186003)(53546011)(6486002)(2906002)(31686004)(478600001)(86362001)(31696002)(7416002)(8936002)(64756008)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L28wZlNzSXp4SjVLRGQ3T0ZVbi9OQ2Uzd0VzMDY0ZktEQkNkaGFjY05YZG5F?= =?utf-8?B?ZWxndzJ5Smh6djhIL2lETlptbU1WeDlYSnp6cFNWdC9FZ3lBeGdOQ3RuenhZ?= =?utf-8?B?dEdZckw4UHlPZ1U2NlRWSmQ3MnRwenVPbDBDWUxuRG02T1lreG81WTR3dlN4?= =?utf-8?B?dXcwSi94a3ovVEh6TWlHNVVadXZVQ3VkZkZiWXkzdFRzN1NVejVuVEFqcDdM?= =?utf-8?B?U1g5NkVkMm9YYk90YUxMTktQV1B4QTJtRWwraGhRWi8ySk94WU1MQ2NmK1Zh?= =?utf-8?B?aEdra0tSQkdqUnc3STZpUGd5TXIyZDdlWU1RMWlOOXdVc2FnbFQrV2ZFYzll?= =?utf-8?B?cFA1S2hwSGM3UlZISFlSNVJ6V0xKNGVsWlBxaVNQTFk3cUVoTzBxeWlJNWp5?= =?utf-8?B?ejF0cEM4Ti9hTXBPNnBoN2NWQnZXWmVRUzY2QWN3VHZrZ3hibFZJdnVMckE5?= =?utf-8?B?RHk0UEFRRXZYcmloRXJKVjJiUXVWdkM4NjBIcjlDR05xVHg3UG5TdWF5Q0hD?= =?utf-8?B?a2Q2NktHR256MVNvTno1bUVTRmJBaDBmZXJlajNiWXZQSHdJaFlkWGhWNzRY?= =?utf-8?B?YTVwZTh2dHVkZHVZRXFMTTNRRmZ2NVpoSjNRWjZUVWtacU5QUTBCVmRwWFQy?= =?utf-8?B?S0VBWE9qMXVRVk1QbVRSVGp2S0MrL1JTMWZsWHVOK25BWUkwL01PU3BaUUtT?= =?utf-8?B?TVBlQXQ3L0NsREVjRzk0VDlKaENaYnBTYnJhcnN5dHhGNGVhQUE0bndTMTI5?= =?utf-8?B?bzRGa3ZPOVg3RTN4YjJzeDQ5ZmViSjc2bG5GcmpiL3lKNjJzZS93ckV5OGd0?= =?utf-8?B?N09LblFBM0hZRDVZNTJoV0JMWnN2REJ5bEJNZnhDZlZLcUJhakljbDVWeVBK?= =?utf-8?B?YVlOTzFNNlNoWG1hR3FRemFUajBqcDNEekdCZEtIT0p5V2dWbXhqcTM3anE3?= =?utf-8?B?MTkyMm9yN2Z6UjhtdEErY2NDM2VpSWh6dDYyQ3JyOVJGOW5tT0E2WCtPRnZD?= =?utf-8?B?ZUdGOGJwZ1FESjhrWkF3V1hyTlVlZHB4WUFqNEVjS0xFTkh6T3lHOUlNS1pP?= =?utf-8?B?alU0bGtkWVZ3YXI5V2Z3cVZreU1YK1pPM3hhVzAvdG41SkdBRkZ4cmVJZEM1?= =?utf-8?B?a242R0g4UlRkMkpQV2dySUViYWt6S3RLS3pITk5QZ3hnOUljV1UzUHFaV2NJ?= =?utf-8?B?Q1pndll0RHJPdU04QWltcGNIUVBxU1Vma1hyR3YwNUloUGVRbi9LalN3NU5q?= =?utf-8?B?dHloTEVOamVld092aXNQM3lXQ3lscXRiL2toc2diaC9RbDdieVloQzdmZ3Ry?= =?utf-8?B?cTBpYnkxZ0lDekQ5Z21iejlRRHdwRTlFNkt2Sm04VHljdjI3RnFLTkpGS3p2?= =?utf-8?B?cXdUMi95d2lGSDFiZkhsWFd1SGRuakNuWm9sWDVDVXR5TGV6c09IZUx1cDh2?= =?utf-8?B?WGlDQlhGQmxPS1hVNXpwbjhKalJwLy9sZkd2dW5hTmZUek1ZUlFmYnZhUWF0?= =?utf-8?B?ZkJEM1J3dHpGT2VVdEcydTRVUWNaYkpvUmtwT1ZENExFQW1vejZad2grMzlO?= =?utf-8?B?eks5VFl2Tmt0bHNKTUs5ZHN2VVZSakwzS1NudEpycnpIRDJHTDZBazFXMEVi?= =?utf-8?B?eFZIZnRyaGVUQ0hsN3lid2tOTlBGZ2V3c1luelpUbW9hN001ZDZ6aWJEZTk3?= =?utf-8?B?emRTQUxHSDhRanV3Sy94aDZVL05ZKzZjeTRVaENZK081R3crY29aVzlBcXlG?= =?utf-8?B?ajFnOFpUV3dMS2I3dEx5b3VMbWovMFBDQ3FscnRab2hNT3FNR2s3UWN3UHZi?= =?utf-8?B?c0lrKytmeU9CQW1iQnBjNnUvdkJKNG10YUxSWFFuckRtQXRBOE1OcHdFYlpN?= =?utf-8?B?QjlINHExdFBRY1hVMWlnbys5TDZwclhSSTF6OVUxQUd4cTBIMW9VaG1HN3p1?= =?utf-8?B?bFN0NmdOMWpSL2tiZnpKM2haWUNuTG1UQ1ppdHYrUlY1VzRodk1WZXFGSEtk?= =?utf-8?B?TG81a1E4d3RiZkdFN1BGS1p4ZzlQdkZXaVkrSEZuU1lHbEVjTWJtbVpqTUo0?= =?utf-8?B?TnRSVWtPWjZMOWtpd3IzNGMzcWh5cEN5Y2xma1FDeTV3dEt5elg3czZxcWlN?= =?utf-8?B?bW5TTFU1Q1JXOS9ONlpIZXc3dENxVDVKMXorWFdIMWZNVmtQZU5aMkQ2aVho?= =?utf-8?Q?8i4Xt7GL9zI055b6cXNs1fQ=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <1F7215C67D7B42449DF4C0014FB8AA13@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47939d57-ad92-4281-4ab3-08da6f1a13a6 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 15:18:21.5219 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xwjFb5Q+mxWi1EmJCyxLrhPE9qYeCvQKC8mD1oas8PDhGzBu08gjwx1XI6GKvn/VeQQg4FrDjiDRhrsYb3tpBUudcE0qHHUC/plXk4cQJWU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR03MB5616 X-Proofpoint-ORIG-GUID: _V07lLF1YSgkZXRT9vaB7QnGfgcO5UH6 X-Proofpoint-GUID: _V07lLF1YSgkZXRT9vaB7QnGfgcO5UH6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-26_04,2022-07-26_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 phishscore=0 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1011 impostorscore=0 spamscore=0 mlxlogscore=692 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207260059 DQpPbiAyNi4wNy4yMiAxNjo0NywgUmFodWwgU2luZ2ggd3JvdGU6DQo+IEhpIE9sZWtzYW5kciwN Cg0KDQpIZWxsbyBSYWh1bA0KDQoNCg0KPg0KPj4gT24gMTkgSnVsIDIwMjIsIGF0IDY6NDIgcG0s IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc3R5c2hAZ21haWwuY29tPiB3cm90ZToNCj4+DQo+ PiBGcm9tOiBPbGVrc2FuZHIgVHlzaGNoZW5rbyA8b2xla3NhbmRyX3R5c2hjaGVua29AZXBhbS5j b20+DQo+Pg0KPj4gSGksIGFsbCENCj4+DQo+PiBZb3UgY2FuIGZpbmQgcHJldmlvdXMgZGlzY3Vz c2lvbiBhdCBbMV0uDQo+Pg0KPj4gMS4gVGhpcyBwYXRjaCBzZXJpZXMgaXMgZm9jdXNpbmcgb24g dlBDSSBhbmQgYWRkcyBzdXBwb3J0IGZvciBub24taWRlbnRpdHkNCj4+IFBDSSBCQVIgbWFwcGlu Z3Mgd2hpY2ggaXMgcmVxdWlyZWQgd2hpbGUgcGFzc2luZyB0aHJvdWdoIGEgUENJIGRldmljZSB0 bw0KPj4gYSBndWVzdC4gVGhlIGhpZ2hsaWdodHMgYXJlOg0KPj4NCj4+IC0gQWRkIHJlbGV2YW50 IHZwY2kgcmVnaXN0ZXIgaGFuZGxlcnMgd2hlbiBhc3NpZ25pbmcgUENJIGRldmljZSB0byBhIGRv bWFpbg0KPj4gICBhbmQgcmVtb3ZlIHRob3NlIHdoZW4gZGUtYXNzaWduaW5nLiBUaGlzIGFsbG93 cyBoYXZpbmcgZGlmZmVyZW50DQo+PiAgIGhhbmRsZXJzIGZvciBkaWZmZXJlbnQgZG9tYWlucywg ZS5nLiBod2RvbSBhbmQgb3RoZXIgZ3Vlc3RzLg0KPj4NCj4+IC0gRW11bGF0ZSBndWVzdCBCQVIg cmVnaXN0ZXIgdmFsdWVzIGJhc2VkIG9uIHBoeXNpY2FsIEJBUiB2YWx1ZXMuDQo+PiAgIFRoaXMg YWxsb3dzIGNyZWF0aW5nIGEgZ3Vlc3QgdmlldyBvZiB0aGUgcmVnaXN0ZXJzIGFuZCBlbXVsYXRl cw0KPj4gICBzaXplIGFuZCBwcm9wZXJ0aWVzIHByb2JlIGFzIGl0IGlzIGRvbmUgZHVyaW5nIFBD SSBkZXZpY2UgZW51bWVyYXRpb24gYnkNCj4+ICAgdGhlIGd1ZXN0Lg0KPj4NCj4+IC0gSW5zdGVh ZCBvZiBoYW5kbGluZyBhIHNpbmdsZSByYW5nZSBzZXQsIHRoYXQgY29udGFpbnMgYWxsIHRoZSBt ZW1vcnkNCj4+ICAgcmVnaW9ucyBvZiBhbGwgdGhlIEJBUnMgYW5kIFJPTSwgaGF2ZSB0aGVtIHBl ciBCQVIuDQo+Pg0KPj4gLSBUYWtlIGludG8gYWNjb3VudCBndWVzdCdzIEJBUiB2aWV3IGFuZCBw cm9ncmFtIGl0cyBwMm0gYWNjb3JkaW5nbHk6DQo+PiAgIGdmbiBpcyBndWVzdCdzIHZpZXcgb2Yg dGhlIEJBUiBhbmQgbWZuIGlzIHRoZSBwaHlzaWNhbCBCQVIgdmFsdWUgYXMgc2V0DQo+PiAgIHVw IGJ5IHRoZSBob3N0IGJyaWRnZSBpbiB0aGUgaGFyZHdhcmUgZG9tYWluLg0KPj4gICBUaGlzIHdh eSBoYXJkd2FyZSBkb21haW4gc2VlcyBwaHlzaWNhbCBCQVIgdmFsdWVzIGFuZCBndWVzdCBzZWVz DQo+PiAgIGVtdWxhdGVkIG9uZXMuDQo+Pg0KPj4gMi4gVGhlIHNlcmllcyBhbHNvIGFkZHMgc3Vw cG9ydCBmb3IgdmlydHVhbCBQQ0kgYnVzIHRvcG9sb2d5IGZvciBndWVzdHM6DQo+PiAtIFdlIGVt dWxhdGUgYSBzaW5nbGUgaG9zdCBicmlkZ2UgZm9yIHRoZSBndWVzdCwgc28gc2VnbWVudCBpcyBh bHdheXMgMC4NCj4+IC0gVGhlIGltcGxlbWVudGF0aW9uIGlzIGxpbWl0ZWQgdG8gMzIgZGV2aWNl cyB3aGljaCBhcmUgYWxsb3dlZCBvbg0KPj4gICAgYSBzaW5nbGUgUENJIGJ1cy4NCj4+IC0gVGhl IHZpcnR1YWwgYnVzIG51bWJlciBpcyBzZXQgdG8gMCwgc28gdmlydHVhbCBkZXZpY2VzIGFyZSBz ZWVuDQo+PiAgICBhcyBlbWJlZGRlZCBlbmRwb2ludHMgYmVoaW5kIHRoZSByb290IGNvbXBsZXgu DQo+Pg0KPj4gMy4gVGhlIHNlcmllcyBoYXMgYmVlbiB1cGRhdGVkIGR1ZSB0byB0aGUgbmV3IFBD SSh2UENJKSBsb2NraW5nIHNjaGVtZSBpbXBsZW1lbnRlZA0KPj4gaW4gdGhlIHByZXJlcSBzZXJp ZXMgd2hpY2ggaXMgYWxzbyBvbiB0aGUgcmV2aWV3IG5vdyBbMl0uDQo+Pg0KPj4gNC4gRm9yIHVu cHJpdmlsZWdlZCBndWVzdHMgdnBjaV97cmVhZHx3cml0ZX0gaGFzIGJlZW4gcmUtd29ya2VkDQo+ PiB0byBub3QgcGFzc3Rocm91Z2ggYWNjZXNzZXMgdG8gdGhlIHJlZ2lzdGVycyBub3QgZXhwbGlj aXRseSBoYW5kbGVkDQo+PiBieSB0aGUgY29ycmVzcG9uZGluZyB2UENJIGhhbmRsZXJzOiB3aXRo b3V0IHRoYXQgcGFzc3Rocm91Z2gNCj4+IHRvIGd1ZXN0cyBpcyBjb21wbGV0ZWx5IHVuc2FmZSBh cyBYZW4gYWxsb3dzIHRoZW0gZnVsbCBhY2Nlc3MgdG8NCj4+IHRoZSByZWdpc3RlcnMuIER1cmlu ZyBkZXZlbG9wbWVudCB0aGlzIGNhbiBiZSByZXZlcnRlZCBmb3IgZGVidWdnaW5nIHB1cnBvc2Vz Lg0KPj4NCj4+ICEhISBPVDogcGxlYXNlIG5vdGUsIE9sZWtzYW5kciBBbmRydXNoY2hlbmtvIHdo byBpcyB0aGUgYXV0aG9yIG9mIGFsbCB0aGlzIHN0dWZmDQo+PiBoYXMgbWFuYWdlZCB0byBhZGRy ZXNzIGFsbG1vc3QgYWxsIHJldmlldyBjb21tZW50cyBnaXZlbiBmb3IgdjYgYW5kIHB1c2hlZCB0 aGUgdXBkYXRlZA0KPj4gdmVyc2lvbiB0byB0aGUgZ2l0aHViICgyMy4wMi4yMikuDQo+PiBTbyBh ZnRlciByZWNlaXZpbmcgaGlzIGFncmVlbWVudCBJIGp1c3QgcGlja2VkIGl0IHVwIGFuZCBkaWQg dGhlIGZvbGxvd2luZyBiZWZvcmUNCj4+IHB1c2hpbmcgVjc6DQo+PiAtIHJlYmFzZWQgb24gdGhl IHJlY2VudCBzdGFnaW5nIChyZXNvbHZpbmcgYSBmZXcgY29uZmxpY3RzKQ0KPj4gLSB1cGRhdGVk IGFjY29yZGluZyB0byB0aGUgcmVjZW50IGNoYW5nZXMgKGFkZGVkIGNmX2NoZWNrIHNwZWNpZmll cnMgd2hlcmUgYXBwcm9wcmlhdGUsIGV0YykNCj4+IGFuZCBwZXJmb3JtZWQgbWlub3IgYWRqdXN0 bWVudHMNCj4+IC0gbWFkZSBzdXJlIHRoYXQgYm90aCBjdXJyZW50IGFuZCBwcmVyZXEgc2VyaWVz IFsyXSBkaWRuJ3QgcmVhbGx5IGJyZWFrIHg4NiBieSB0ZXN0aW5nDQo+PiBQVkggRG9tMCAodlBD SSkgYW5kIFBWIERvbTAgKyBIVk0gRG9tVSAoUENJIHBhc3N0aHJvdWdoIHRvIERvbVUpIHVzaW5n IFFlbXUNCj4+IC0gbXkgY29sbGVhZ3VlIFZvbG9keW15ciBCYWJjaHVrICh3aG8gd2FzIGludm9s dmVkIGluIHRoZSBwcmVyZXEgc2VyaWVzKSByZWNoZWNrZWQgdGhhdA0KPj4gYm90aCBzZXJpZXMg d29ya2VkIG9uIEFybSB1c2luZyByZWFsIEhXDQo+Pg0KPj4gWW91IGNhbiBhbHNvIGZpbmQgdGhl IHNlcmllcyBhdCBbM10uDQo+Pg0KPj4gWzFdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19o dHRwczovL2xvcmUua2VybmVsLm9yZy94ZW4tZGV2ZWwvMjAyMjAyMDQwNjM0NTkuNjgwOTYxLTEt YW5kcjIwMDBAZ21haWwuY29tL19fOyEhR0ZfMjlkYmNRSVVCUEEhMVA5TGV5dEpDN2QzdG5TdVFD ams3WXFJcWZaUHBHbHJjNkVTMWwxc1VBUGJmR2JlWWcyWU00Nzd4aVV5MG9UVTl5czdxdjlNSEQ2 R05EV0NlSEhHX3Fzci1OWSQgW2xvcmVbLl1rZXJuZWxbLl1vcmddDQo+PiBbMl0gaHR0cHM6Ly91 cmxkZWZlbnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3hlbi1kZXZlbC8yMDIy MDcxODIxMTUyMS42NjQ3MjktMS12b2xvZHlteXJfYmFiY2h1a0BlcGFtLmNvbS9fXzshIUdGXzI5 ZGJjUUlVQlBBITFQOUxleXRKQzdkM3RuU3VRQ2prN1lxSXFmWlBwR2xyYzZFUzFsMXNVQVBiZkdi ZVlnMllNNDc3eGlVeTBvVFU5eXM3cXY5TUhENkdORFdDZUhIR2JTY1ROYjQkIFtsb3JlWy5da2Vy bmVsWy5db3JnXQ0KPj4gWzNdIGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRwczovL2dp dGh1Yi5jb20vb3R5c2hjaGVua28xL3hlbi9jb21taXRzL3ZwY2k3X187ISFHRl8yOWRiY1FJVUJQ QSExUDlMZXl0SkM3ZDN0blN1UUNqazdZcUlxZlpQcEdscmM2RVMxbDFzVUFQYmZHYmVZZzJZTTQ3 N3hpVXkwb1RVOXlzN3F2OU1IRDZHTkRXQ2VISEdocEFtcmNNJCBbZ2l0aHViWy5dY29tXQ0KPj4N Cj4gSSB0ZXN0ZWQgdGhlIHdob2xlIHNlcmllcyBvbiBBUk0gTjFTRFAgYm9hcmQgZXZlcnl0aGlu ZyB3b3JrcyBhcyBleHBlY3RlZC4NCg0KDQpTb3VuZHMgZ3JlYXQhDQoNCg0KPg0KPiBTbyBmb3Ig dGhlIHdob2xlIHNlcmllczoNCj4gVGVzdGVkLWJ5OiBSYWh1bCBTaW5naCA8cmFodWwuc2luZ2hA YXJtLmNvbT4NCg0KDQpUaGFuayB5b3UgZm9yIHRlc3RpbmchDQoNCg0KPg0KPiBSZWdhcmRzLA0K PiBSYWh1bA0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:24:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:24:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375436.607813 (Exim 4.92) (envelope-from ) id 1oGMPj-0002qP-Dq; Tue, 26 Jul 2022 15:24:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375436.607813; Tue, 26 Jul 2022 15:24:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMPj-0002qI-Af; Tue, 26 Jul 2022 15:24:03 +0000 Received: by outflank-mailman (input) for mailman id 375436; Tue, 26 Jul 2022 15:24:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMPi-0002qC-90 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:24:02 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130050.outbound.protection.outlook.com [40.107.13.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f9d97378-0cf6-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:24:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB6891.eurprd04.prod.outlook.com (2603:10a6:10:112::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Tue, 26 Jul 2022 15:23:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:23:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f9d97378-0cf6-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d95E6FHnWXCAImAxvtU/qRh1X7ee7iMP4RTngXInGrK5irX7iEPdFcSplchDYzvOzCQ4h4A6HhvO++1BJ3Mxz2FNNbqg3iQ8m1fCRgRriMzxQHw7uDKUW8lyL1iV9E/jjhBU6PhYGQv1vqAF5SNJpXECdfQuk3SXNeDMG8YpHuBFowGrpU0w788qVMU+EZJNIXegvhDzwal/T30uft5JPPFRuSqAUGxDqD5+X3VWogaSX8H3+3JNIpzLS8PpuSnp04eKI+TsA8coQbrJRA5uQobm/ysVKwyb8PCuxZu8YPgXgTgDnshMZeqsPvkriDlDmEUpVFVBtT7ggiHQ/22ZdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M7p2iaxgDH0aR8FX+tXM1Fvf5NfQywoIgZP+Tf3sW8k=; b=YS/wrwhh0X6uTpmWoK4H/ZleKweslFSCObbO5NY0Tuvwddfvj5YJIEqHbY7EILqHle1bMpvpwJGigbP7iP1S/VAvWfr0DnJShi2fdbdZ+ahmHp2tK+NlfXTXMqGoziq0lt2HnLU4BzoDvUBI0LicLSCqYU+ACQoBi3n6/AB8sMpwHogI526SGeFqAkbMeBPYsJRTBWCsRHN5jVOH3TZ72WDb+E63jVe+93gKHQ2PV0ui03OMCce53B/WZGT0p7wU//tc+sdMNg3vGmOuTPmT0iUvug+WwgGlZROHBmPgBYAPhEhNSGVORAluzX2FNAX1Rwmn2eQT4Xy4gsn1L7WZ/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M7p2iaxgDH0aR8FX+tXM1Fvf5NfQywoIgZP+Tf3sW8k=; b=CHJTXESCcYcojFmsbDMG/z1+8AU9cKyktVs2M2VMMSF7ViHsMI5Jx/ZOrUWKqbOYdQfL/q50Ehg6gGZCE7hKzIsuxf/ZXwizPvymkYvNkngeSOIezAAKGB5DX8ALYYLMBIWh7QXBypsb9s0Vab+2ueab5XjC9Q1Un3svzetQ/P5u1+RqdjThT/+rsaQadTHLcklR4xkVYn+aokZP2HthGo1slFWRkYiLxvcn53cFqNJR+dcoVIE59qx1NlS57XMfdEJD4/SOzLsjIOb2eqhjunR0uFsSADvSSHgdYKYyDmGz4oQJ6d0s5USRWfza25Cq8TmA57sJgofcXaIWtoKgFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 17:23:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-9-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-9-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0022.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bea6f6f2-a305-49b6-5d49-08da6f1adc3c X-MS-TrafficTypeDiagnostic: DB8PR04MB6891:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RYA3OPESGV2fR3FnUO7vZXGiCLqT0qzEX9rL11BRnFDxWUQo9Ruabw5mhCxZ0UDkpMaabGxHQVWNFdEEqnzdOddQN7+IqPDyjNYAhxWLU3hs80xzt1G+rIKGFdDt9JMV3ufBRUrMr4iZ+7MS4JVmrr6FPBYYefhApJnzTrmDTLY96IUqtQ8lGfb0IHchizjaX0+xW7IpuAZ8P03rdqOyJLBnfSTRHdapj1g1X7mvlDGe1GugQXqG3rzSlkQ22J1iQOkfJD2L9VT7RkdQDJp4XtCrh5pfGkN3A12L0LqVVn6pkeWVtUas2Y/KqRPnkc7s5GIv5AdBxjHXtk75JZzHb7TW5c7pQ2D7CWClhWAbHolVANt/HpJVZFBSfIBomwtankHh/+XVeD06H8bZweTrLxa/e/3rfA8BoPSy+TCjACU+M9E+NBfJz0NytTtnw+hDmYCqBiybNTOLsRo9D8Z5Qn7zSm/NXQEu3q05qx0cVW7lUygJl3UDAdjM7iQHoHa8F3vXRdgG4Ujkyw6D+AdmeEwcPMZb4puncP7xEv3/naZ1mV6UVaO9hpfhEsWBIRmEXl6zzFs3wvtIh07rsaZKEdXIOrNNonYbZo2fYge3G4qa7ly7kht085/kvFOu1KFVOpGnhUIEexLmx6DLuoTXnUYJBycdXkpR6sP9IrQjdw1HwiW24VSZRUVxtcEuFD/MFfIvYrX5heC9y422pZ62PLdSKDKsaLrKEDDmRyNE/KLnAp5beFHbeA4CCEstdqmEwcozOTkjPi1BKnHvX/WD7/dQs/CiaJAC1CYlEv+P3qkqfW3W0Df73bnV4PEzPd1Asj+OZ0ZAnYi2OVze4aB/Zg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(366004)(39860400002)(376002)(136003)(26005)(6512007)(2616005)(53546011)(6506007)(8936002)(5660300002)(4744005)(6486002)(478600001)(2906002)(41300700001)(31696002)(6916009)(83380400001)(186003)(66946007)(36756003)(38100700002)(54906003)(316002)(31686004)(66476007)(86362001)(4326008)(66556008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Ync2dG1velJBYzRXUldFV3ByM09wVGlDOG5Zemt3bnl4N1NERkQ1a3NPUVRE?= =?utf-8?B?SWFIa2dOVEZJN0hpOExaVkVRNkpEMW51a2s0emVBNU9hT2VLV25ha1Byc1FE?= =?utf-8?B?M1hlNzUzMytxa2NJdlRWcVZuOXcxVm9kRVBrSHhCdW0wdDhabjVGRzdGVDNk?= =?utf-8?B?a2dOY0FyaWE1SUF5b0phTUFvVFpkVUlDeVVZeEdBMkFvUk1oVGZVTWNFYThS?= =?utf-8?B?OWlTWGZlbVBXTGVTZ2N3L1pLRkhhWGNrK0I4SS9xZlV0eFFQQ1dkRVphdFZL?= =?utf-8?B?TEZ1Tld6UFRnY0JhZ05zZUJrbXlLTklZVE5tZ21mdk9ZaE4zeGtjaG5idFc4?= =?utf-8?B?NFEwV3Z4MkZEL1R6NHVoaS9OcnpNMnhsYlNyMjlaQ09NOGpMelluQTBsQTR5?= =?utf-8?B?cnQzN0djbEcrQW9hbzFyOGowRGxpUU5BRFd4V25KVTllUGNFMDJCY3F2dkNm?= =?utf-8?B?UTJKQlZxQ2ZHRUVqK3RxRnlLdTQxdGdYcDk3TzhFTnRyRFk3OXB2WUNwSnZr?= =?utf-8?B?KzV6SEhTR2dacGtQSkVxUTdydmczR0V5MVFxOWZtVjM2b3UzWE5IUWNFMjJk?= =?utf-8?B?RTZzVUN3SG1CcThQL2lCeEhTVWY4dXVvU3cvam15WGxVWjJYWUhIOGNXR1VZ?= =?utf-8?B?ZmlIWTB1R0JwMFBRNGFyZHZjRUdab0Q4dEg3VFlRSlVjYjBSVUlHak5JamYr?= =?utf-8?B?ekI0a2h2aitSOHpJbUNRUjl3Y0o5S0FsbDNvRGRYdXZZUFM4bHM5RElRSjBs?= =?utf-8?B?YmFISXlacGVReGkrbEpnaVdiNnFUcXhsOWI4YlNzRGt4OGZidUN0bWkreVE5?= =?utf-8?B?eUJlVE9vVElqMjNsa0tHNGNNL3FwZE15Rm0wWTRpN0dIRUFXQi9ZMjdJNTQx?= =?utf-8?B?M1d4SGptaHdKZkZkZTd1bjNjMDRzdHZQVXA4NkN0MW85dGoyNkZOTjRGSFFz?= =?utf-8?B?RkdwdVhPUHE2U09sRCtCK1NJSTZReVo4aCtmREFnVjlOTW1zdnBTL1RYeGd3?= =?utf-8?B?SGFIZ1pBM05tSmRHTGlpbHlFeHVyMDMzMWZjUUVDWlBXcEdqVWRNOEJZbUx0?= =?utf-8?B?a1FqdGdST2t1VmRrenU0dWlCRHhBRFFtTEE4U09mL1JsOGF0M1lpNTlSMHVh?= =?utf-8?B?WnZyZEJ2MyszbHA1c2tROTNpZkxPZmdQajF3NW9WdVJzOHhiZnZjQzgvNkJG?= =?utf-8?B?Skk5L1pPQklLZy8vQUcrcG1sb3VMa0tPS2Z2TEQ1SDJ3TlQ2TERsb1ppT2VP?= =?utf-8?B?SnBteGdUSUtEYTM3WXNONVBuRlBzaE5Neld3NDF5R1dsS0RWVDE2NkJkYUNo?= =?utf-8?B?R0lITmYwZEthandWT0ZTbklCcUVtZ1g0Tyt0bExNUXhYbmk4TE5UanZLL3VG?= =?utf-8?B?dGZoc3BXRlFmVjBMWDJSVTZ3dE41dU5uVFBpazlvU0xkZ0J5UFgvODRScms3?= =?utf-8?B?a0NMTGo2TTI5cHROL2lhRCt3WXcydC9uSzRtTlQ3M1p2SmlWbGYycS9KV3Fl?= =?utf-8?B?cWJqYVd5SFRvL1ZVaHBEL2lFdDRISys2VUdqMXZmUHdUQTk1czEwK0xDRE1x?= =?utf-8?B?S0FaVnd5dFBKS1A2YUp6U2dKY2Q2Z2l5Q3JnbFNITWdtK3hyZHZZVTlOS0FR?= =?utf-8?B?dnJ6MGR0YU9rQW1xc01xbDhCQUk5TUpGRS9Qc1VaKys1a2xJMENqMmVsYWM4?= =?utf-8?B?Rm5RYUlOWlRPZTE1R1E3TjVQbVk2eU1nR2ljMXVkUDhPejFiT2g1RDRLLzlG?= =?utf-8?B?VFowS3RnMnFHd25yUmh4bExvMmIrdFVqQVNDZFZJaVFNRzI4YnYvelB4NTIy?= =?utf-8?B?cmpnNHQ2U0dsOU8xYzJrVVh0ZmxiMjNKd0wrU1h6RjAxK1BkM1U3WEdwTFRR?= =?utf-8?B?d3UybG00VnpwOE1OaHVISWJaenVGV24yLyttM0FMelZjYWdRdlkxdk1xQ28z?= =?utf-8?B?UFZzYThDUlc0cUY3cnlvVXNkNHZsUTR4ekNYZGI0K3NiOTh6SFBFQ3dqWStR?= =?utf-8?B?RC9oSjJlNU1JTHNUblkrRk92SGUvcXRTNzJ4UzhOU2c1SzB2VkZoUEwzUU9W?= =?utf-8?B?RWlhZDk5M2xyT0xDbDVDend6L2tyOExiK0hPWnV0OFVnbC82Z2FXSWpJTlEx?= =?utf-8?Q?D1iU90f1Q2PrwEicYGyVnWVoK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bea6f6f2-a305-49b6-5d49-08da6f1adc3c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:23:58.2685 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JYdEoNEVPd63Ux/uuW9KJ0OSpgeh2UcsBRq931hu8lxEHA/ZMAy0wZzBBmt7f1jJzxe0+g3ZdKKbLmtsJE4kcw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB6891 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Reset the command register when assigning a PCI device to a guest: > according to the PCI spec the PCI_COMMAND register is typically all 0's > after reset, but this might not be true for the guest as it needs > to respect host's settings. > For that reason, do not write 0 to the PCI_COMMAND register directly, > but go through the corresponding emulation layer (cmd_write), which > will take care about the actual bits written. > > Signed-off-by: Oleksandr Andrushchenko > --- > Since v6: > - use cmd_write directly without introducing emulate_cmd_reg > - update commit message with more description on all 0's in PCI_COMMAND I agree with the change, but it's imo enough that you also need to sign off on the patch (and this likely also applies elsewhere in the series). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:29:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:29:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375442.607824 (Exim 4.92) (envelope-from ) id 1oGMUW-0003bV-06; Tue, 26 Jul 2022 15:29:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375442.607824; Tue, 26 Jul 2022 15:28:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMUV-0003bO-T9; Tue, 26 Jul 2022 15:28:59 +0000 Received: by outflank-mailman (input) for mailman id 375442; Tue, 26 Jul 2022 15:28:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMUU-0003bI-6K for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:28:58 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a8a26139-0cf7-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:28:56 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8a26139-0cf7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658849336; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=78DeRPXEX5Sq1wiXho6iKCVockOf/BEkWuFpqU82/Bk=; b=H6YE5uwaqnddfSZ7VRyvMPh3xTixL9aJi84HBx38cqheE1JneUHh3/6Q P7wdQGjxQhBYuTyOuiHd5C2DSZkC8wSTFx7z8NlLI/mYlGTLZEycwIRLR hMaZo9YfvFRRs0jS2VxC2BOzjYuF5ecyqz9atgqsVWvyRfTWFaDEC/JH+ g=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79229926 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:jFBzxKr9w2S3WdSi4vLPy9qSbDheBmIFZRIvgKrLsJaIsI4StFCzt garIBmDaf+LMDH1fth3a9yz8EpUvZbVy4BnGgY4rns9QXwQpJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lF5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUop+VKBzF2y cUoIQEkRAqigKWQ8KOCH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8aBIw/mqG0gWP4cBVTqU6PpLpx6G/WpOB0+Oe8aoCEK4bULSlTtkCVo yHE9Wj5OxAXEeSH7x6F7nClt/CayEsXX6pNTeblp5aGmma7xGYeFRkXXluTuuSihwi1XNc3A 1MQ0jojq+417kPDZtrwQRy+5mKFtxg0WtxMHul84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCA8PGSpDC7OykQJEcDYzMJSU0O5NyLnW0opkuRFJA5Svfz14CrX2Grq 9yXkMQgr4VOjvMNh52HxGDOshuGvLnOCSgF9zyCCwpJ8ThFiJ6Zi52AsAaGvaYYdNzCFzFtr 1BfxZHAsblm4YWl0XXUHb5TROzBC+OtamW0vLJ5I3U2G91BEVaHdJsY3jxxLVwB3i0sKW6wO x+7Ve+8CfZu0JqWgUxfOdvZ5zwCl/SIKDgcfqm8giBySpZwbhSb2ypleFSd2Wvg+GB1z/xvZ sjHKJb8UitEYUiC8NZRb75GuYLHOwhknT+DLXwF50/PPUWiiI69Fu5ebQrmghER56KYugTFm +ti2z+x40wGCIXWP3iImbP/2HhQchDX87iq9JEMHgNCSyI6cFwc5wj5mut7JdY6zvkEyY8lP BiVAydl9bY2vlWfQS3iV5ypQOm3NXqjhRrX5RARAGs= IronPort-HdrOrdr: A9a23:fxoSqKMUMPRQwsBcTs+jsMiBIKoaSvp037Eqv3oRdfUzSL3/qy nOpoV96faaskdzZJhNo7+90cq7MBfhHPxOkOss1N6ZNWGM0gbFEGgL1/qa/9SKIU3DH4Bmu5 uIC5IObeHNMQ== X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="79229926" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Jun Nakajima , Kevin Tian , Jan Beulich , Andrew Cooper , =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= , Wei Liu Subject: [PATCH v2] x86/msr: fix X2APIC_LAST Date: Tue, 26 Jul 2022 16:28:19 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The latest Intel manual now says the X2APIC reserved range is only 0x800 to 0x8ff (NOT 0xbff). This changed between SDM 68 (Nov 2018) and SDM 69 (Jan 2019). The AMD manual documents 0x800-0x8ff too. There are non-X2APIC MSRs in the 0x900-0xbff range now: e.g. 0x981 is IA32_TME_CAPABILITY, an architectural MSR. The new MSR in this range appears to have been introduced in Icelake, so this commit should be backported to Xen versions supporting Icelake. Backport: 4.13+ Signed-off-by: Edwin Török --- Notes: Changed since v1: * include version of Intel SDM where the change occured * remove opencoded MSR_X2APIC_FIRST + 0xff xen/arch/x86/hvm/vmx/vmx.c | 4 ++-- xen/arch/x86/include/asm/msr-index.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 47554cc004..17e103188a 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -3397,7 +3397,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) if ( cpu_has_vmx_apic_reg_virt ) { for ( msr = MSR_X2APIC_FIRST; - msr <= MSR_X2APIC_FIRST + 0xff; msr++ ) + msr <= MSR_X2APIC_LAST; msr++ ) vmx_clear_msr_intercept(v, msr, VMX_MSR_R); vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R); @@ -3418,7 +3418,7 @@ void vmx_vlapic_msr_changed(struct vcpu *v) if ( !(v->arch.hvm.vmx.secondary_exec_control & SECONDARY_EXEC_VIRTUALIZE_X2APIC_MODE) ) for ( msr = MSR_X2APIC_FIRST; - msr <= MSR_X2APIC_FIRST + 0xff; msr++ ) + msr <= MSR_X2APIC_LAST; msr++ ) vmx_set_msr_intercept(v, msr, VMX_MSR_RW); vmx_update_secondary_exec_control(v); diff --git a/xen/arch/x86/include/asm/msr-index.h b/xen/arch/x86/include/asm/msr-index.h index 8cab8736d8..1a928ea6af 100644 --- a/xen/arch/x86/include/asm/msr-index.h +++ b/xen/arch/x86/include/asm/msr-index.h @@ -148,7 +148,7 @@ #define MSR_INTERRUPT_SSP_TABLE 0x000006a8 #define MSR_X2APIC_FIRST 0x00000800 -#define MSR_X2APIC_LAST 0x00000bff +#define MSR_X2APIC_LAST 0x000008ff #define MSR_X2APIC_TPR 0x00000808 #define MSR_X2APIC_PPR 0x0000080a -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:30:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:30:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375447.607835 (Exim 4.92) (envelope-from ) id 1oGMVX-0004Oq-C6; Tue, 26 Jul 2022 15:30:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375447.607835; Tue, 26 Jul 2022 15:30:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMVX-0004Ni-85; Tue, 26 Jul 2022 15:30:03 +0000 Received: by outflank-mailman (input) for mailman id 375447; Tue, 26 Jul 2022 15:30:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMVW-00049I-0n for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:30:02 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cefa6907-0cf7-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:30:00 +0200 (CEST) Received: from mail-dm6nam12lp2177.outbound.protection.outlook.com (HELO NAM12-DM6-obe.outbound.protection.outlook.com) ([104.47.59.177]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 11:29:57 -0400 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com (2603:10b6:a03:2d6::7) by PH0PR03MB5798.namprd03.prod.outlook.com (2603:10b6:510:35::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 15:29:56 +0000 Received: from SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::b876:40ed:1507:6fea]) by SJ0PR03MB5888.namprd03.prod.outlook.com ([fe80::b876:40ed:1507:6fea%2]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 15:29:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cefa6907-0cf7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658849400; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=5hL7EQoyvMmCBQsG+KGVhCad1N/ciyZZhE8Vz9ykLWs=; b=AO5FO8PJsjM0uNICyFEj1smX9NfgtWFqhJxhMiMRu5BnqNl8BXijGYIN 0NRzY6JmyFmzFWXWqTpX3le911z/viy2Ely3TVeHczih8Otuc1UgWEUaQ 2LYrSajaQq3S5/LZBoAd6UhX52BPMWJY7lWytjH3eEpQGhNSuIywP+SiY 8=; X-IronPort-RemoteIP: 104.47.59.177 X-IronPort-MID: 79230016 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:BZd4F65efsqJ5mKc1P/KwgxRtCTGchMFZxGqfqrLsTDasY5as4F+v jEdWGnSO/jbNGLxLdonaoyy9RwA7J/XnNAwSlE9q3hjHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5qmq4lv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJFsmZokb3uxyO0pP3 8Y1AWEhVE2Ilu3jldpXSsE07igiBO/CGdpF/11Fk3TeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5Lmwe8Q3KzUY0yzG7IAhZ3bTzMdyTZtuQQsZ9lUeEv GPWuW/+B3n2MfTAmGDeqir12IcjmwvfBp0eDbKmrcRlnQa9ljAZChlLFl+09KzRZkmWHog3x 1Yv0igkoLU29UerZsLgRBD+q3mB1jYDX/JAHut87xuCooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9dJ6G3rKdrDf3NS1LK2YHPHUAVVFcvIalp5wvhBXSSNolCLSyktD+BTD3x XaNsTQ6gLIQy8UM0s1X4Gz6vt5lnbCRJiZd2+kddjjNAt9RDGJ9W7GV1A== IronPort-HdrOrdr: A9a23:4jq0CqODbvXjv8BcT2L155DYdb4zR+YMi2TDiHoddfUFSKalfp 6V98jzjSWE8wr4WBkb6LO90DHpewKQyXcH2/hqAV7EZnirhILIFvAp0WKG+VHd8kLFh4lgPM tbEpSWTeeAdWSS7vyKrzVQcexQpuVvmZrA7Yix854ud3ASV0gK1XYaNu/vKDwTeOAwP+tdKH Pz3Kp6jgvlXU5SQtWwB3EDUeSGjcbMjojabRkPAANiwBWSjBuzgYSKUiSw71M7aXdi0L0i+W /Kn0jS/aO4qcy2zRfayiv684lWot380dFObfb8yvT9aw+cyTpAVr4RHoFqjwpF5N1HL2xa1+ Ukli1QffibLUmhOF1d7yGdgjUImwxelkMKgWXo/UcL5/aJCg7SQvAx+75xY1/X7VEts8p717 8O12WFt4BPBReFhyjl4cPUPisa33ZdMRIZ4JEuZlFkIPwjgYVq3Poi1VIQFI1FEDPx6YghHu UrBMbA5OxOeVffa3zCpGFgzNGlQ3x2R369MwM/k93Q1yITkGFyzkMeysBalnAc9IglQ50B4+ jfKKxnmLxHU8dTZ6NgA+UKR9exFwX2MFrxGXPXJU6iGLAMOnrLpZKy6LIp5PuycJhN15c2kI SpaiItiYfzQTOaNSSj5uw6zvmWehTNYd3E8LAs27Fp/rvhWbHsLSqPDFgzjsrImYRsPvHm X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="79230016" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kL0EnB/O8qImq+wiT6CjD2oOn8Q9VEjs9Dgp4po6XMoB2gNm4YeN4mQDZebg0GgpZvO6riAaAl7EmnTb3H4QW1UQGhMj0mUnuOean4kO1AWoy1/x1O9e3VlXCfTFSevaUKyykofhfLLpSLlhM4K2q/pYZd3AxVUNkNUq37YIrUPd14NPQwLvcZ2loKGcBDGMENpwBimG+FqJJTQX3tczk6wGSyq87EMSz4qBq3v5O4TTG8GnS+wxkGMf6702/ZlD12cssWwdIl8wdt7lnU1os44Y+Zt4xgSGnsQf6dod4pq5tH84gBnrlRj32fFHKx8RSJqqztNvvIOzJxm96ArNcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5hL7EQoyvMmCBQsG+KGVhCad1N/ciyZZhE8Vz9ykLWs=; b=a2Wv2yOh9FUnQFC/ivjqSFhzqQdVxv5CxKPIQN+EDTn752Mz17es4bwQJZfCxExG0yvbaV5GbQDDsUUqOeNP+Vvc0n1xLCay4s+cbTomNjdbbUH7Soz1dsRRQclGxqu+Oy+AaJEiOol0jrcSGqUSDislkkqJcgOkbKoMq/DtezpLoAXaD2c1tfgf/B+GbDbYLfheCn2WbilLLSvgDFKc7ztD11aujhe863tPYyj7r2xogXrFoffKGJvvpVV85nnNSJdG4+lOkM4rJd0S5q6ZKL/65U6eQYP3bxXpdhBa5JHkA+O3C31k4TKyXHqh0etTjcOHXmQakdWhFOzIQ2rx/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5hL7EQoyvMmCBQsG+KGVhCad1N/ciyZZhE8Vz9ykLWs=; b=lRnvpT7EdEcUDO4nwtSFeW8UHkFvEzB1ZX24ZjX5DTymwFJA2Xu3izF2Rii94ICS6W0YVOBETaIAj7jsqYZ2ge9Ki+7i9Uq0TpvEme0DNx0f07amTQax6IKPg4EEnjeP4qdEdaG76JO1wOdvGjA/cBbpbPTFrU1nhOO6AaPY8LM= From: Edwin Torok To: Jan Beulich CC: Andrew Cooper , Roger Pau Monne , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] x86/msr: fix X2APIC_LAST Thread-Topic: [PATCH] x86/msr: fix X2APIC_LAST Thread-Index: AQHYoP4qyGlTjJTj1UaX3N7imIGaP62QwNEAgAAGTYA= Date: Tue, 26 Jul 2022 15:29:55 +0000 Message-ID: <41F06585-604C-479E-9B2A-BE61B2F93D0E@citrix.com> References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.120.41.1.1) authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 84a8ee33-e095-4b3b-76c5-08da6f1bb188 x-ms-traffictypediagnostic: PH0PR03MB5798:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KuFhRaQYOVdSARNZ0MKLApzl1IhdeH+PE19qEPtMn5SIC9Oy8invhAv7pa4LsNv2wHML7JKqJrGRepVqunovtsM4RZcEmwQ4Zc2aVIILL4Fcg5tTnMY0D2FXMKQrm1dC9y8e7uqulEUriWdXiIUt4aggBVMWpgcbz//JaLdNwt6SFFs69e3YcHM4FjM2tC5TPkMGtlv5jMtFkLToUoz2ECEhVp1je6tFNhwjEP2pUybiWC8fNJT6ASZ7szCrc174HUcKspL4pVOYGofYV8Bks4UF46cKHT6KhkMCtLaW0MJ2RfkCsNLRaXPWjsdDya/6Ua1q3dLQPs4W9qEUrMkCKqbvw2SY9tfZlj7sYnAHgKuFO5jJRufiiaQJRHIFjjN1IwCXrbhfKKSk5dzAw71Oesccv02ySTQPx81HV5M+Jny20BcviMAZgU7BUmopyTWvfiaoEnMo0tSpUxgdt2vWTHH9bWyhGQ6PvukSFpjFi6He9T+OIeEnJ6LNU3/WcpKNX3qGoq/z/4cJwraEPYlatAxqqtL8i7JRcpzwIgwRVgVPvCg+rvoRbzoAGJ4GLINY7fXbXzMBW1rcHQYKKxeBxsqkBq13hJVPjE9OoKTG7RP3/MUpYleaCTGHuzdVFMuePIC9IBKP5yiGYCZxukeG3D5UWhMG2sOIkdjYRKsSTO32jr3T3hIF66QrHug+stMcvgdIx2aU+xGLOlxjOyG+fL8CFN537ZL1Mflfy8OeZ1SrWW/tlJIJVWod39yXnVG+S/s8k98jwSj5NdfbgkLVjSOgfNyIyO01vpQwhwub7azg8Bvd1o4J5lZ2UeV9ryOuvxXLkU60O5ScFzhjxG8ozw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR03MB5888.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(366004)(396003)(39860400002)(136003)(376002)(8936002)(38070700005)(478600001)(186003)(6486002)(6506007)(41300700001)(5660300002)(36756003)(316002)(66556008)(91956017)(66446008)(66946007)(82960400001)(6512007)(83380400001)(26005)(53546011)(2616005)(66476007)(2906002)(71200400001)(122000001)(76116006)(64756008)(8676002)(38100700002)(6916009)(54906003)(4326008)(33656002)(86362001)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bmJhR3NJZm9Ua2cxUkZBRjVlTTFURlpLRVB3dkNjanNmVXZwT0hHUko3MXBR?= =?utf-8?B?ZFgzUGgydzMwZVVqSmFWSDlsMG9qTkx5UjFRdzFlcGlxWDhpUVNaYlluT0g2?= =?utf-8?B?N0xCN3NJa0NLa0xzdTNtSTZOQWpnRkh4cFcrQkVjSVA0STE3TTF3b3FUbHNK?= =?utf-8?B?KzlUSis5OHlQM0ZYWWk0Q2pQSE5ucjBPVG41bG1XZExNMDdXNXlaMkx6ZTl5?= =?utf-8?B?R29hR3hRU3p2UTB0amFKUy9pV1JLSjMwOEZQRXN5WlZvaTNueld1WmJkWk8v?= =?utf-8?B?QVhCSDh2bG9ZRHpxMTE5ZlV0VUJxczlsaDREYzVjaklwb01KcUtlT1JGVnIy?= =?utf-8?B?Q21Ea0t4amc4eUxLUWVjRW5XU3k0SXZFb25aVWRqamk2SDhibXgyeGZFR2VF?= =?utf-8?B?SkdjVzJtcVdIS0NZYlIxdXd1TGtYbDRPMjZtY1VMcGZ6V29uZVQvbmIzTlYw?= =?utf-8?B?Ykh6QitDSFlpdHJzWWxZam5jNFNScnR0T25nTi9DOEl2S2k3VkNhcXBQRWdM?= =?utf-8?B?b25YWVZueFYwVndpaXhLMjJBQVRObXFiMS81UUJsRmJFYmR5cnBHQjIwWElv?= =?utf-8?B?OGsycSszRTdCNUIxZk9rbnFUWGlFU0tmd21TcHhVZ1l1eXZxZzRFWVJiRVZD?= =?utf-8?B?R29KbzByeHEyRFRYbzdRNytNNkhpclVQQmQwL0FzTW96U3QxWFBtbm5SRGQy?= =?utf-8?B?K3Fmd3h2TWVJM3prVlhkcGZWWFgxN2YxeSs4U3ZWeWZtY2tWZ3JFWDdyZWdV?= =?utf-8?B?cVR1TEdqSlkyZWkyMXhKWkxtVTREcys2TWV1czBlOXJFbjR2aG5VUGV5R3d2?= =?utf-8?B?bFc1eFdKVkVXMU1YQnYzN25vTFB0TjBOeWhYYkcwbVphSENtWng4VStUMXdo?= =?utf-8?B?VnFTOWdseEF0T3BZWi96V1pXS2VseE1Xd0xsVWZWNDBiSHNjQW10QTgxa2JF?= =?utf-8?B?NFNObkt4SjZDU053VFEyQkZjVXpzcFdId0thM29WQW1jQmRJUjRQVDA0MHo4?= =?utf-8?B?K2dibEFCN1hrSnZaclk5cUtUckhDSEIrd0d4Y1VqR3IxZm9WSzErNjJMYXNy?= =?utf-8?B?NC9SK1RmbVB1ZmdnV05XNjFqOEwwbThxanRWbCtzSGlUd0c1d2V2STdJSUFl?= =?utf-8?B?SU5JRkk2MEMyM2NJVEErRTBlTHphTUc2NzB2b3BlQitsZHpuU2NRNkI3YXYw?= =?utf-8?B?ZTdQcnU5TWtQSzNScklIMExCYUtSMFlXYkl1N3p2VzBXVU9pRkR0WFVhRVFj?= =?utf-8?B?d2RQYVRlV010KytvdVZQTzVZSHR0bTRqdnNvaFhPakRTVzZQK3IzVTQ3aUR2?= =?utf-8?B?bU5ocUdLRWo3a2d0ZE1aYklYUTB4enp1NEgvcjJFUUg5N210T2phejVudkRw?= =?utf-8?B?dHhrV0JpNWk2Ym56cVhnY2NGZ1lrbzQ1d25MTkRjZlY0WC94T1BzcGZ6NzFr?= =?utf-8?B?amZUWnl5QzB1OVlDQndSSGtRTVBadXkwMWRyUnFVdncwa2tUdXJiSXdmWW1T?= =?utf-8?B?ZzgzSW45YjRtV1kycEdxR3JiTk1IWWlEWWZsZ0tDRjJTejhENjlENWxjRk5B?= =?utf-8?B?cURWZU1Ddk1tTjUzY1BQOW03M0hsVDNHZ0lIdXVPdzM1WHR3Z1MrOENnQ1pH?= =?utf-8?B?U2h0TW8zU2lTU0FQZUxOelhIWjF6aGdqdEM5WTQwU2NnYUxEWVZmb3NRZWNI?= =?utf-8?B?aHROakdZU2RTMml5ajdSS3hBNVVQMDFLNXhJL3p0RDZHYmdUWGFUSzNmcWNQ?= =?utf-8?B?eUUzazR0TnNuc0ZzM0RlS3MvOFNEbitaazl3OG9LSGJYdTFuZkZzRWRqWTVP?= =?utf-8?B?NlpZcmZsbWdOTXVIWUN6Z1A5d0Q5OXJXNGRzUCtLWnNxV3UvUWhCRGNMbUNW?= =?utf-8?B?SXdlWHV2T2xzbHMxWmZvVUsrR2lodm9UTGFvV2d2VjR5c2xiNnQwWUVIVExu?= =?utf-8?B?MjFyMlZyeUdKRXk4ZWdheS9OZytUcEV5bkdGQzlhUm5lanRLWmE0MkdKL0Fn?= =?utf-8?B?QStUVjBJeDdNazh6eEUweDh1TjNndWRiWFdNTDEvTXg3QnY0UXpDNzZ0cDRB?= =?utf-8?B?SFQvcXRobHZUUzdMOXpCNmM4a0swNWpPWFBxMElzRmhMYnVDcFE4L05sRUVP?= =?utf-8?B?WS9KeWdDNmxPbmo1SnZ2ekVTUGZSaE5hV3VlZGhrMHZmKzQrWXRmYkNrWkpy?= =?utf-8?B?b2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <45D3A85564503E47B4766586092D578F@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SJ0PR03MB5888.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84a8ee33-e095-4b3b-76c5-08da6f1bb188 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 15:29:55.9344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tz6paJsASddWmcc0K0pGwRC7smMkFdwhARnYq2dAjAxMELVOXOeELkZCnpDkBDlKok5wsnOV9+zikmAen9NTcg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR03MB5798 DQoNCj4gT24gMjYgSnVsIDIwMjIsIGF0IDE2OjA3LCBKYW4gQmV1bGljaCA8amJldWxpY2hAc3Vz ZS5jb20+IHdyb3RlOg0KPiANCj4gT24gMjYuMDcuMjAyMiAxNjo0MywgRWR3aW4gVMO2csO2ayB3 cm90ZToNCj4+IC0tLSBhL3hlbi9hcmNoL3g4Ni9pbmNsdWRlL2FzbS9tc3ItaW5kZXguaA0KPj4g KysrIGIveGVuL2FyY2gveDg2L2luY2x1ZGUvYXNtL21zci1pbmRleC5oDQo+PiBAQCAtMTQ4LDcg KzE0OCw3IEBADQo+PiAjZGVmaW5lIE1TUl9JTlRFUlJVUFRfU1NQX1RBQkxFICAgICAgICAgICAg IDB4MDAwMDA2YTgNCj4+IA0KPj4gI2RlZmluZSBNU1JfWDJBUElDX0ZJUlNUICAgICAgICAgICAg ICAgICAgICAweDAwMDAwODAwDQo+PiAtI2RlZmluZSBNU1JfWDJBUElDX0xBU1QgICAgICAgICAg ICAgICAgICAgICAweDAwMDAwYmZmDQo+PiArI2RlZmluZSBNU1JfWDJBUElDX0xBU1QgICAgICAg ICAgICAgICAgICAgICAweDAwMDAwOGZmDQo+IA0KPiBNYXkgSSBhc2sgdGhhdCB0aGVuIHRoZSBu b3cgb3Blbi1jb2RlZCB2YWx1ZXMgb2YgTVNSX1gyQVBJQ19MQVNUDQo+ICh0d28gaW5zdGFuY2Vz IGluIHZteC5jIHVzaW5nIE1TUl9YMkFQSUNfRklSU1QgKyAweGZmKSBiZSByZXBsYWNlZA0KPiBh dCB0aGUgc2FtZSB0aW1lPw0KDQoNCj4gT24gMjYgSnVsIDIwMjIsIGF0IDE2OjAzLCBBbmRyZXcg Q29vcGVyIDxBbmRyZXcuQ29vcGVyM0BjaXRyaXguY29tPiB3cm90ZToNCj4gDQo+IE9uIDI2LzA3 LzIwMjIgMTU6NDMsIEVkd2luIFTDtnLDtmsgd3JvdGU6DQo+PiBUaGUgbGF0ZXN0IEludGVsIG1h bnVhbCBub3cgc2F5cyB0aGUgWDJBUElDIHJlc2VydmVkIHJhbmdlIGlzIG9ubHkNCj4+IDB4ODAw IHRvIDB4OGZmIChOT1QgMHhiZmYpLiBUaGUgQU1EIG1hbnVhbCBkb2N1bWVudHMgMHg4MDAtMHg4 ZmYgdG9vLg0KPj4gDQo+PiBUaGVyZSBhcmUgbm9uLVgyQVBJQyBNU1JzIGluIHRoZSAweDkwMC0w eGJmZiByYW5nZSBub3c6DQo+PiBlLmcuIDB4OTgxIGlzIElBMzJfVE1FX0NBUEFCSUxJVFksIGFu IGFyY2hpdGVjdHVyYWwgTVNSLg0KPj4gDQo+PiBUaGUgbmV3IE1TUiBpbiB0aGlzIHJhbmdlIGFw cGVhcnMgdG8gaGF2ZSBiZWVuIGludHJvZHVjZWQgaW4gSWNlbGFrZSwNCj4+IHNvIHRoaXMgY29t bWl0IHNob3VsZCBiZSBiYWNrcG9ydGVkIHRvIFhlbiB2ZXJzaW9ucyBzdXBwb3J0aW5nIEljZWxh a2UuDQo+PiANCj4+IEJhY2twb3J0OiA0LjEzKw0KPj4gDQo+PiBTaWduZWQtb2ZmLWJ5OiBFZHdp biBUw7Zyw7ZrIDxlZHZpbi50b3Jva0BjaXRyaXguY29tPg0KPiANCj4gSGF2aW5nIGRvbmUgc29t ZSBhcmNoYWVvbG9neSwgdGhpcyBjaGFuZ2VkIGJldHdlZW4gU0RNIDY4IChOb3YgMjAxOCkgYW5k DQo+IFNETSA2OSAoSmFuIDIwMTkpDQoNClRoYW5rcywgSSd2ZSBkb25lIGJvdGggb2YgdGhlc2Ug dXBkYXRlcyBpbiB0aGUgdjIgSSd2ZSBzZW50IG91dC4NCg0KQmVzdCByZWdhcmRzLA0KLS1FZHdp bg== From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:30:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:30:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375453.607846 (Exim 4.92) (envelope-from ) id 1oGMWI-0005ZL-SN; Tue, 26 Jul 2022 15:30:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375453.607846; Tue, 26 Jul 2022 15:30:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMWI-0005ZC-Ot; Tue, 26 Jul 2022 15:30:50 +0000 Received: by outflank-mailman (input) for mailman id 375453; Tue, 26 Jul 2022 15:30:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMWH-0005ND-MW for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:30:49 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80074.outbound.protection.outlook.com [40.107.8.74]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ecb40b7b-0cf7-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:30:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3706.eurprd04.prod.outlook.com (2603:10a6:8:5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 15:30:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:30:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ecb40b7b-0cf7-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AZipmgCRp2BX3J3iZuFTG8m4MboiHhUUMCwBdvAoH+POjktK7uCKofB+777AWgwTP838BYfny4Ule6DDCzB1qoV4KMHoSLDK5H/BvKQ5AI4qvXu64p9ymYL56xAB3udOzfMmp93UjILEzjkLUsREaUHNkRD85y8s7CPEPL4tU5otBakxe0VRHC40BMtIdCOa7W0SUpYPE0amH5jkRglGDqqO0X21+eygCVgQgJJKlhl3a0LdVoyWWi/ceupF+7hqR0iccvuSuK3FQqKIH33ZK1n32arAQ/ZGiIsSI2xCbsV0wRybVuweMKjzd8GgaA2DPghqDLhr2fvFdAaIpIRSRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JocGxLVhaQThOw6xbD3S6s9QzLjFqr/F2wA3rOCr5Yc=; b=IFDZVs2Y1qtqe88nYWeGwxhQmFqBxVYpYiJl/p85DpcW7tj/RRAT5PpzTg1tNjvDDtWzHadYRMLNBoZo9bXuq0QwZjTuHVj2rsxKd+fRmYjzeSrfZeQ356u+pO5dwxkQIstfCJMpNYx3IeAYr1ywJ1GKeloZR/ETvu65IuZSgk3kz6egXP3r5eclwaQzcTe0U1HUUBI2Z2T+MY6e3iEitZtuJ6VrgUGmAB3hWvyPOG2CFUZu9ypc4VNJjtoVQoyF9p1JrBQB3Bp1Vx8gCaUxsphjP13S0tjWaCuqlysTD+Ecl+YSUVuXAFy+wDA9HcZmZpcq2JDCGzrC1FMI8mwhgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JocGxLVhaQThOw6xbD3S6s9QzLjFqr/F2wA3rOCr5Yc=; b=JQ9+ifu3QwM4d9blWLzdiqQUbeM9Yo/IbzuP7aYx4zoe3fPdYKjec5izG6nHNqOdvE/uEdSNt6AnEEdKattd+fTo1C2JaGvBFYhkJ6bwvglG3n4TNMW6x7IsBmp8ct94Nh3EcPBBLfdB3FbHNancrLs1KQaduD3fWpCQWlfiIHeTUK4cBDbVQmMktYRDA1ZY5cNo1NOvPymiCZB8rwLhdc+WbhjRfNcXK72tOgODMSOS0vakeFvtzbLrHo2x9qKpA/NZCH/9xwcAKC7lgDWINo39jdHhUEqyJuhkXQp1qqAeFXt6xiw6Hc8xV0uS8GQobbZ77Q7kd0l++IvitrbfDQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9f2bd47d-cd48-f544-4e8d-a8a698470889@suse.com> Date: Tue, 26 Jul 2022 17:30:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 07/11] vpci/header: emulate PCI_COMMAND register for guests Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-8-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-8-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:94::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6f2ebb8f-dfd2-45bb-c0dd-08da6f1bcf71 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3706:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BTg6mIulQ9rEEwp15WXd2y/BH26/+DZ8iQ19ETdF5NiTKViCeCOzvGmhTKFPzLIh4xuu3Nl7wotoQ+DUQ10BEgtdkRaujPWFqfeOQ3KjHCS5d8e9lRHgfz2luTAzsuTWPx9TYw/1ZTYRxr8lOT3TrIj0p6lA86umxEEQ8cwCfeC1P5CrQ2FibyydjwcIhhiOodXs8baKeted8nMWv/MDqW302nsboe/vQF0ZeeJplXCwiUfzj2tMvqwL6I1gf57RdvMJ1KhXABkfoLsSBHssxi94OSGaxgFCXr2Bc1dzKwl+x5Z4XnKrLMak4QAUKtGIiBHsQNSjqStES9yCDMGlcAUgQEIEfk38BUAc/jYCYY3U6HjzIRHbNZ3cj+JG/kTaMgfPeFFBVAu5oL6fJBqywFb+UHF3zYpd9vp9YhA2buk3pXZLQGVxYEH0RipQvEnTlzYNSaKK+6WziMTIiCE4bzASie5YRY2SXJbE4+nAhgdUCs7QDAUAjwBHFWQdNOpmIs+ukj+uhtMmUtliknJdkZjScxEgxksfX/ooD70x6/nTLdMSZ/LXeY0WfT900OcogPIXgrn6wQeYHOGGi1+gURZZBAGtnLfpCW4Da0GB0AG9MRAFD9RVHXWAGvdsH9yzv4ALMoJW8PgmC/xFC9t4WK0HTayRvOuqaP1PoFgPFBNZ+aHWV4yQ35pqcXDgFAncF7E4Nk0rb2HAwa4JJkTEMFYj5k0l6Ym2vzh2kJTsAomOl8qNTfO2G0nDaI/aAyHyUUt6+jUVOtVWVLFeXWZ33cRA9UTIqev0nHuDWb/XpjFPgdUHtiZyiwjsqo9dHPsV1p/BUPt8xHqXC1s+3/sjsw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(39860400002)(346002)(376002)(2906002)(41300700001)(478600001)(36756003)(66476007)(66946007)(86362001)(8936002)(6486002)(66556008)(6916009)(31696002)(54906003)(6512007)(186003)(2616005)(316002)(38100700002)(26005)(4326008)(5660300002)(53546011)(31686004)(6506007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OUNjSkdPVy9tckJybTd3bU5lTFF5TXBPdWdWL0JpRG5wMVlmSHFHVmxOZitx?= =?utf-8?B?OVBobjF2ZEo1ZXNjQnVReTYwUU5mRnhKSGx4VW1ERFJNQmZjdjFyQ2wxQTlz?= =?utf-8?B?c2RkV1pybUhUaGVqQXFOclB3TlVCQWY1ek1jaHIwemNMTXZxMm54NXZPL0Vi?= =?utf-8?B?R3FaTEpCWU5vRDF2RHkwUHJ1Tkk1SFYreVhKcHdRZGlvWkIwMHVtbWJ2SUo3?= =?utf-8?B?bC9xalRGRzRyemRreVlZUmZOQklyWmNYcmhNRGRJQnExNlBJeU1hZUJlQlBC?= =?utf-8?B?ZFhJQ3RhSUdGWFkvYkJ4SXpQcUdyZjExb1M2c1dERC9ZZnhENVZXM0UxVC9B?= =?utf-8?B?bUd2Z2JTTTlMRVEyODJSNXNlUVhSU0w3WGw0VW5GWitvSzBWdFMzNmltcU9F?= =?utf-8?B?YTczN1o3cFBENHo4SGFydWcxSjdaOGMxQWFZb2ZRV1JSNkR2UFZiRHZjTHdZ?= =?utf-8?B?cTVKTWpoYjVxUWZBQUlPeXNvRlhyeGFTZVQ0emNTdHphUnZ2Yi9jcW9MUm5L?= =?utf-8?B?eHF3T1J4bzI1T1IyOUQrUWRxU090NkVlNk9xTmlVUTJ1cmpHcVlXSjEyYXRr?= =?utf-8?B?cnVqOGRLazl6SXlHVndWMEJocHgraGdZYXZ0SHcraUV6aHZUTklTU1hqdUxk?= =?utf-8?B?bmlGaTVOd3NpVXRDSXI5eEM1SDJyOFdORDJlSDh0K0hKbUNtNlVVRzVsc2cz?= =?utf-8?B?azdJbFdNOWxVWXNwZWVLcmZXRTQrZS9TTXVrUWFaWGY5eEdyUFRYODYzQ3Vi?= =?utf-8?B?TkNwVGNrcXlLU04wS0pRSGQvVlZsc015QTlZcnc2QXNpWXFaMkFIZjRIVEpD?= =?utf-8?B?L3dINmZSeDIxWkF0TG41b09wTld5SmlvQ3RKaXNTSkFweTE3L0Q0cDV5bU96?= =?utf-8?B?SS9ya1lOZmdKRkw4NEJZaUtyVW5uUFNCTGhlS1loOENuams5UzZtZTRTUG5o?= =?utf-8?B?aHBQS1oxZHljZDE4OUJOcWVMR2N1SjF3VkJEL2tkU3MwK0tPNGFqV09XbEt1?= =?utf-8?B?K3AyUVpOU2t0dm5kMXhTV1J6NTZLSFloVEFFWWZZSFptbVVZazFYL284NXIz?= =?utf-8?B?dEM1Y2FXRzFITkw2TVJ3K2w4cDZsR3hBMDAzWFBpUUdRaWY3eldoQU5sR1Uw?= =?utf-8?B?b3VHVU9abHJYQ2JiOWh0Yk9ENjdSZWs4Y3MweE1haXpWQ0hMSWp6K1I0MHBx?= =?utf-8?B?Wm5sSW9VZlozVXl6MW5wczZJZWkxNy9SYkNxUXZHcmpTU09DVEZUZFB5YXJ4?= =?utf-8?B?RzNpUHh5SkkvTGNFYnNDQmFydGlac0pGVEV1NldKMmp0aDh1YWVZMUZnMCs3?= =?utf-8?B?MW9yZWVRaFFEN09mVjlZUmpHNXlEcW00NWFRNytUWG42RHFjM2lFbFZTZ3U2?= =?utf-8?B?UmY0anZWSjFxbE5uck9wSVpjQ0RKSURiNXVzenNNcWFQZzQ0dm50MDQ0bC91?= =?utf-8?B?RkM3WXdNNlI3QW1CZlk4azI3djAraFdSNHVSNDdDMFBhdUoyY2FTS1NLbUFQ?= =?utf-8?B?dUcxQlVDalA5MzBwd2hVWU1OSjhqUXp1SEYxY2xNeWowbFFFM0NTQnlkMDda?= =?utf-8?B?QURVZEQxanJ6aDg3eE1aZ3JyMDNTeEk3MnF1WUZ2bkluUUcvNkZYOXI1ZlQ0?= =?utf-8?B?MnJ0VnFyK202cWpyL1FlUGdUMlBuUnRLbGhBUjI0UXJ5WDYxMlQ2VHlxVDNr?= =?utf-8?B?Q0xEQk8vTnBwUUEyVUN2c2hQN3JucUF0ZFlGMWZheGNZM2pOdVVQWTlxaUlO?= =?utf-8?B?blJpQWJqUmtTL3BqVEltVVRoM211Rmd0eTE5Z0xUb1ZiYTBvbzhYY3JxZEI5?= =?utf-8?B?VHVtbUVzMjQ1WUdoTFZhak1lYUNKaUJxQVFJUVFocjlPcG44bkdrQ2VGUnBi?= =?utf-8?B?MUlRenBUb29PQmZ1Z1dpNWdtdkFiaE11eHA3MEszemVNSTJwcS96T2s5bmtM?= =?utf-8?B?MFp3bUR4OThMQmdyU21ydzVOcDVCbGNhcmZoVFNFVVgvY3RUM3JNRDA0RmZ4?= =?utf-8?B?dndYcjIvQko5R3RaWHVXVStkN09keGNKVE9UL21nZS9XV2ZiUFRjSlFFSWxK?= =?utf-8?B?V0o0U2Z0TllmRWs2bFhMenpUUUVyUGtJbWdUa1FtL29kUnQ2MXIzRUxITlpD?= =?utf-8?Q?YdJfLsyhA8IVTmKXuiAwz0EvQ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6f2ebb8f-dfd2-45bb-c0dd-08da6f1bcf71 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:30:46.2735 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iSFU1tWg0IaN1Xo1dnJLlWhUIpUA5odnMMhbpkQf1CJYCD5kOTCiDwZ1pAuyxss1P/ynCIvkUCLO7bsXS8njiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3706 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > --- a/xen/drivers/vpci/header.c > +++ b/xen/drivers/vpci/header.c > @@ -443,11 +443,27 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) > return 0; > } > > +/* TODO: Add proper emulation for all bits of the command register. */ > static void cf_check cmd_write( > const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data) > { > uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg); > > + if ( !is_hardware_domain(pdev->domain) ) > + { > + struct vpci_header *header = data; > + > + header->guest_cmd = cmd; > +#ifdef CONFIG_HAS_PCI_MSI > + if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled ) > + /* > + * Guest wants to enable INTx, but it can't be enabled > + * if MSI/MSI-X enabled. > + */ > + cmd |= PCI_COMMAND_INTX_DISABLE; > +#endif > + } > + > /* > * Let Dom0 play with all the bits directly except for the memory > * decoding one. > @@ -464,6 +480,19 @@ static void cf_check cmd_write( > pci_conf_write16(pdev->sbdf, reg, cmd); > } > > +static uint32_t cf_check cmd_read( > + const struct pci_dev *pdev, unsigned int reg, void *data) > +{ > + if ( !is_hardware_domain(pdev->domain) ) > + { > + struct vpci_header *header = data; > + > + return header->guest_cmd; > + } > + > + return pci_conf_read16(pdev->sbdf, reg); > +} This function wants the same leading comment as cmd_write(). I also think you better wouldn't give the guest the impression that r/o bits can actually be written to (but getting this right may well fall under the TODO). Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:33:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:33:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375459.607857 (Exim 4.92) (envelope-from ) id 1oGMYU-0006Cu-9F; Tue, 26 Jul 2022 15:33:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375459.607857; Tue, 26 Jul 2022 15:33:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMYU-0006Cn-5R; Tue, 26 Jul 2022 15:33:06 +0000 Received: by outflank-mailman (input) for mailman id 375459; Tue, 26 Jul 2022 15:33:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMYS-0006Cc-Qr for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:33:04 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2063.outbound.protection.outlook.com [40.107.20.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3d259b04-0cf8-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:33:04 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB3PR0402MB3706.eurprd04.prod.outlook.com (2603:10a6:8:5::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 15:33:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:33:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3d259b04-0cf8-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LV4URFKUZWpJVpX32TVEFqsK7jp/GHnB2LDcR4h8eFoGeYskvyGG54M2Ht1RyLq0wwDrZifuOQPrMVC1PKqd7Ra/on80elIgLNIYXQXYIId3PQCQGB2hySZvAAf096LwRaAwTBBD9XIniWfjI4Mi9KmREbq7HFYf3ySPqbDyEj98GBb1KVZinoc1Zwz2ndQ5oqcn/byXcZNSnm0MbcfCoRRfHZIX33ILvfmPtmdWFzkPgPoHIYwzaNgEFpF9R47KYPgOhc03hdQg9BhVuzI2UIqnLbqR9hpAmv2KbRcwbEd76ojYcMaZWy/s7l5NOo3VDk30rw0n5x6XAYVDJ7oMEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jznMdVRgf2kH4jvT2e7CgJ2TFLUs6FjzqKhnCeI0niw=; b=Jgp3J7AsJ5F9T1sNpwSU3S86oUX7Z5FIkaJe0cZbFXsPm6Xavfe0eA6L3W6IAMxtEJiYIKR5/RfYDQEpwDlEIcdSSn1n7MAXilv8cL2imsbcx+D++aKYJkhsX/qBKZOhtD9yw4gWlVeEkMhMiuXfjVv3YjE4oO4q2mga9eZ6DRanOcs1lwBUUEWFq4YM9WRYPoFSWc55Bmi6LKyuE5PwGJHojFL1FwotE5Y+gijTQaiUebs7t1Z3mYtNjhTUzra30nSad84HcSOm/4hnCHVmTDXtvLoMJ2SHDzYiQ+pkdNhkU9iIwCctCl37z7qYlwMow3Vbb9HC3280iVKoi6X07g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jznMdVRgf2kH4jvT2e7CgJ2TFLUs6FjzqKhnCeI0niw=; b=d/GyYrfbG+UV7eOGyomgEESs4gqDnbwn/+Bhl/DkCBkv4Uq6fGL7n90Azi5PwFwO/2WgDyMNzZGFVdzQZs8lEjxagJXsMgK1Qw2obDov6jMccGyZ/4zR3x/O+7B2N259b3Bh51fZ6BdYP0l2Jeg9iNwZmyR8QSwo6MjxBz+fk35G6kUQ7rUFqjm4V+nPhB0EIQVIR7nmcszHsBM/83JM9nzxxu7WUB9+dqovXqHxmlcE90elGocUSA/+qq4R0USiWVUsUNz2m5oY1sA464jaNbthFEHjNm1v22txigCMo6mEpLJLtXDd8lgKiosAbsa/8xA0noTD+YHknRFivMnQFA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3e5ceee7-533b-1cae-262e-b05b5b22692b@suse.com> Date: Tue, 26 Jul 2022 17:33:00 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] x86/msr: fix X2APIC_LAST Content-Language: en-US To: =?UTF-8?B?RWR3aW4gVMO2csO2aw==?= Cc: Jun Nakajima , Kevin Tian , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , xen-devel@lists.xenproject.org References: From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM6PR08CA0006.eurprd08.prod.outlook.com (2603:10a6:20b:b2::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 110c5926-e53e-4baa-6d8b-08da6f1c2074 X-MS-TrafficTypeDiagnostic: DB3PR0402MB3706:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GfWAxqmwUpxqwFlk4IvEItKfsg6ELiDwcaeg17cO8EWjY6TVA5+ingN4qdI1XiMD+vRE5xH3OvtxYhIOY4HPZR4zFHPE5LVKN2qK2Hp81XkAQ0un1s7RQ2Z+kfJMpU7E+Wn9sK9uHi3PMt+P5Juk4ol7dRp7wLw99G55UOUAgazluKUwUkWWLfslOsrk/L27GX0R0DSCmyaaAnYVESPgKinynU858rih89craCWS9qvyTHNIKPiFqbfOFmnj0jmSZ+f2INpPMA3Y3kNUCVHmceiULShXKmwlk1QWCPj9MVwxsfjWdiqXkFW8P9AzjFrMKG+tZqSQS0Gud6Ur/rUA2NYFT9aSqZ3zpLP5WnwYg1PlIfA9p1gczk5XPwY8AmKcBcGxEPynIMs3dQToTjvEnVbszlrmpPBKchWhDZWA0siB4RoCUQvvxugNrNI1o6Ql581nH+kzl2chIEeyDvPKZg+ThbV5czYgfVFzlCl5VqYK8Xvh8kDGPtUOD8BjRZG/7djdi2/XnEcd0MR6HaT5a6ObdI7NzD+ACZ9qvkvKqOigY6hR+GMZOaqtOG1IKDYfBaTYimYjPI3lpVgYLPePYCtZD+NsK+68/XiMTtdLb4jJkRwEA41DVTP2Mt8YywKdoHrUb/5IyG9haqklgHVLhdVWCART7o/NBrvS7w+QGl3jUi1b1fENGWNYAJR9imez1npCef9bKp6iGJry/Et9FqierW7DFFnYPd0//P0Ym/rw9AOjUFAjEZvolbCEJtlqGpZ29Qm8hBaVBlBomMoTt9CwMylHrOZv9PsQuNX7+a3WL+k5npkyvnF033GgG+tU/Rhsn+NHQGa6zeeS45+atg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(366004)(39860400002)(346002)(376002)(2906002)(4744005)(41300700001)(478600001)(36756003)(66476007)(66946007)(86362001)(8936002)(6486002)(66556008)(6916009)(31696002)(54906003)(6512007)(186003)(2616005)(316002)(38100700002)(26005)(4326008)(5660300002)(53546011)(31686004)(6506007)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHlzYWMwcUY5ekNXekxtcGY0RlJmeXo1THpibWJ5NGQ5UFZ0MXZ5VWwzeFFz?= =?utf-8?B?QXN2WGw0amZhT2RQZE1tdjdReXpzSjlJalVGRlZjSWhscVZuYlJXTkpqcTFi?= =?utf-8?B?V0dOTkNvZHlmaURKOUlJN2hkd0dLNmNoeWNyc2pGWGdmYlU3QmJCTXo0bTN4?= =?utf-8?B?Sm9hMGhwNGZPVXZFNVhyU1RFWDFldWhBN2I0WGliOVlER01UaTdkaTlOQnNn?= =?utf-8?B?eitPcFppQ1dyd0xvaU1LMGV5SFZxWlFXVGRUM0xkZG5xUEJ4a3ByUGNFUy8y?= =?utf-8?B?dHVTLy9mMWNzY0h3bHZUUzJ2QXQ1d0w3S3M4clBRYmZkTjdMNDVoK0Vib21t?= =?utf-8?B?VDFYT2crQmV5bE5kTHBNMUtITmZmQWJjTVhYRHBDODgxNFBCSlg5V1VSZEw3?= =?utf-8?B?ZTRzRVk4ampjRDgzdmNSS0x1TXBvNkZBTWRMbFdMN1ZDVFBFQTRubVpJYUxs?= =?utf-8?B?U2tkY0xVbDRNZDdyVW1WeXpEaFZqYzBYUWtmNDVxcllsVnZyby82V0ppNzA0?= =?utf-8?B?NXgyRU9XNjg1R0pteUwrT0d4L3ZneEkyTmJDT1BxKy9VVkxDeUI1bGFMT1hC?= =?utf-8?B?dUQ5UnQ5Vk1kRlY0UkM2SVZwRElNV0RqaE5BQWxybE81VVJIZlZ6WU4vbDNJ?= =?utf-8?B?OGRVNS9zSUU5Q0w5UVVWYWpOZjdBOFNvWUdBZXBxd3lkQ1Fna1QxV0RtT3cw?= =?utf-8?B?VGZFRE9XK1VRQjZGcENSWWJHc2JkVUJabGFFbWV1amNpMkxZZkZOMC9CZ01h?= =?utf-8?B?K0lJWjE5eXNGaEJ0RmFJdzJ2QTB2ZExNZWJiZ1Q3c0x6QWFDSkswZU81QWRp?= =?utf-8?B?WWphNG9NYUppMGJoMmpSTEdUa21QeDBUeCtUdElWcmVCUFF5RENzWG5HMFhK?= =?utf-8?B?Q05kSFo0bEx5d2htQ0JzbHlpWVhONHpuWmhPVzRKejJTWVJoNHlyYTZKeGV2?= =?utf-8?B?VTk2VFpTcGtSMG9sVDF3ald5VlErOE5tVFhqSkhudjN5SVdYQUkyVmtrc3FV?= =?utf-8?B?RVBueEpyVy85MkVoT0xLQ3BMU1crZjFzckhUR3hGakpVZlZVZWZpTUNaNEpm?= =?utf-8?B?V1d5c1A3a29SbDBmb2c3OGtvQmRBaHlRUjMyYWxhZXFrdUtQWHNOWTlvRDV3?= =?utf-8?B?UU5vVExuNDhtVEhxRzVRRGJzMWhtWTBCV0FXcVBZdDdWejM5U05xVkc3SW1U?= =?utf-8?B?WU9JK3h5bDNqbmZEbXowYmtmTzhuYllCVUdiRHI0a05oQld2aEhDSERremYy?= =?utf-8?B?QWRlcC80V0JSRDVYOXFlZ1Zac3J0K1VZMUFRT24xcnhHWStsellyanZzRGsy?= =?utf-8?B?alk5aEVFakpnVk1iYUNSTWNFWUVDQk1oWUVReUN3RlVxUkRTNWtiQkJVUXoz?= =?utf-8?B?R2tzMktOQVVTeVQvNEczMXpacjBXVmIxWTEzc0pXQUhaUEpYSVA1eFYrSG80?= =?utf-8?B?RGdDWmlDc0lTb2ljaVM3NWVFTDUzcWxzRjdYbVRTV2Y3R0pJa09XMVNTUVJY?= =?utf-8?B?dko5WXVrYU96QlJldm50a280OUxYczByV2JHbVVOaU91aEora0JzS3NNSVBj?= =?utf-8?B?R0RHRXJxN2lxUlV1ZjJiR3pGdDN4Q2d5cXNXYnJvYWpDaWVLcEF2N3NMb0JS?= =?utf-8?B?aklYZ3ZQSUQrSGxaVXB4NUNTbGwrdGpna1Z5TGRlYWxNU0pXcGpia2hNRmFD?= =?utf-8?B?YllFWk9pWVR0bVdxNk0rVStWMnJQektLdkhlSmZabzBob3dFWHRmOElpZVYr?= =?utf-8?B?MkpRQXFmRXJXcUUyMThNQUZudC9naXNnYVF3cmpjMW5FT2NmRm5hcHhWTFJ4?= =?utf-8?B?bThuYTFaenBFajFZNnBOUFpxTW5UdXVwRnJVR3JXQmdUcUZpV0FqMjg3eVU0?= =?utf-8?B?a2ptWUdQNWxLTW5FdlBFaERETnNxbGJ0d0FRRUhhb1pzaVl1TGRPUFpuVCtm?= =?utf-8?B?ZFgweHpadFRpdlJHYy9VcHZ2NVlQNThtZW1GMFkrcjBmK0dmeU13dEdVbGUz?= =?utf-8?B?L3NDY2lpT2xDYzhXS1FaM1d4M1hUT1FVZlFTVDI3ZG9KTFg3MEZTSm1nbVg2?= =?utf-8?B?cmlUb0Y0OE44VThrWDJ6MGZaN2p1YXI5dzgveU01S2I1cEc1dndETElEbk5z?= =?utf-8?Q?DJ+KvbDA1PACdXlXJTeVHccja?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 110c5926-e53e-4baa-6d8b-08da6f1c2074 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:33:02.1864 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VdESBOod1vzTbAJeo0Kp1CNgN3qwzF0dj/YZ40cd2PiH0Mbj9SoBrJ7IEorrnTIjcTmrwD613aw1yacPCvHQoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3706 On 26.07.2022 17:28, Edwin Török wrote: > The latest Intel manual now says the X2APIC reserved range is only > 0x800 to 0x8ff (NOT 0xbff). > This changed between SDM 68 (Nov 2018) and SDM 69 (Jan 2019). > The AMD manual documents 0x800-0x8ff too. > > There are non-X2APIC MSRs in the 0x900-0xbff range now: > e.g. 0x981 is IA32_TME_CAPABILITY, an architectural MSR. > > The new MSR in this range appears to have been introduced in Icelake, > so this commit should be backported to Xen versions supporting Icelake. > > Backport: 4.13+ FAOD nevertheless it'll be applied only back to 4.15. > Signed-off-by: Edwin Török Reviewed-by: Jan Beulich From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:42:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:42:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375467.607868 (Exim 4.92) (envelope-from ) id 1oGMhy-0007oE-5j; Tue, 26 Jul 2022 15:42:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375467.607868; Tue, 26 Jul 2022 15:42:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMhy-0007o7-2r; Tue, 26 Jul 2022 15:42:54 +0000 Received: by outflank-mailman (input) for mailman id 375467; Tue, 26 Jul 2022 15:42:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMhw-0007o1-AD for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:42:52 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9a08a47e-0cf9-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 17:42:50 +0200 (CEST) Received: from mail-dm6nam04lp2046.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.46]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jul 2022 11:42:47 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by MN2PR03MB5293.namprd03.prod.outlook.com (2603:10b6:208:1ec::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 15:42:45 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 15:42:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a08a47e-0cf9-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658850170; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=RdOaLCovUqWBLqbLJOTx5EZ+Qx+Q+jv4/3hEm+KlMyU=; b=el0QjnOYAliOYng4TJB2sqqHu7DG1ZdaqeCxOipZTovAHoZ0BDGJPHls Tnagj617FBB5DJ4w+6OuZ0kZn9yhgaS63hiHclNZ8edLyGr1/uFUxcXLG rKz9iDJq1Q5kDpiO+KMGS6DJxTMndneHgiT7dyt080bQ/6ZnOionRpyf+ Q=; X-IronPort-RemoteIP: 104.47.73.46 X-IronPort-MID: 76659829 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A6SD3RaiVleHCAFPNvnt0IpK1X17brhtdHk7Pu?= =?us-ascii?q?qucsGbki+go9Ph2qTc8TtiQWGqXv2RR8IzxNKYuej64ZLRmY4KgerYD4pZG/?= =?us-ascii?q?vDzYglWbDVAgRz/mVc9ZRkDipJ/WiXDL1IR1e2HTi46tiZ58V2RglN52RoaU?= =?us-ascii?q?BYXl+26HI4lJuRcnLyAGv57FZXObsiRR68rqXoKWJzZ5Ibp9B0bFxrwD1mq/?= =?us-ascii?q?hCblt+K7tV/6qUF5i0d7wZ+2AwQuSdwvzLETrgbzgiAw1itq30WuvgeygubQ?= =?us-ascii?q?BzO0n0M4Hrm0Zts5d7MyZ4uM1bKP9mEYqX7ZCxVigIUolcd61i2U9/OQPfPs?= =?us-ascii?q?n/CVCA8eA+RBXQ3k6AnIwHdaCiANwK3Cc6VuXwTJaBhiCFHo9MNewf+xe3fs?= =?us-ascii?q?YU3BsAcqwonehsefVz52tL8kp95AB759TW/deSntBncbqWXJrUcaL+aGexRp?= =?us-ascii?q?zYnYmaIiy/LTvuVoQ1j3CR8lbTaFYUDrnGTm5Ya1wByiBVcq1QDmu8rWQoit?= =?us-ascii?q?we2Smf0Ar+mBdYz8OQZdTDee256YGN0Xac6FSIke/b2xBIohBXD0UJVMvgJ/?= =?us-ascii?q?kIaWp1i5Syjzl/nY+Sct0J5F0Q9k5vShdBx47ReC8s1s/G17AxHv5UAOhdtQ?= =?us-ascii?q?vbxo4+uePpDSTWl5ibSgElXigy1D5hPMnNXDlY71d7blPKJbT2DL6PIZPGuM?= =?us-ascii?q?mFnYZZ08CKMxsvab12MEhAuB23sNaJugw3aQfZJGwiL0eS+d4t2WB7Uup6oa?= =?us-ascii?q?Xg0pBpdkRTZ21PGsWzyVXW9bgX0lw8ogEXFInchlC87+k6LFV8fdd8NHc7FT?= =?us-ascii?q?AfeFQpXYhTIkDjdiiqqn9oDAZJg4+KrGxScVkPfxHBj1dlb//1q1gKDD188B?= =?us-ascii?q?QxWY05Yzpsi6uhkL97jtM7b+UlI3z8dw8gfOBE3rC6lX77LrBDiec4PW1355?= =?us-ascii?q?A1C+N0Wc9uAMuGAozWm3zvUIGdV/F2HYDh7+C3KCVJ7RJsOb6e3Drh6YHYVO?= =?us-ascii?q?s0tFXHjF6wo33u+zkmt2ZWFUOZdFIE5OO/4RbzBo6UEv8WwiKSU9WS5E6wLc?= =?us-ascii?q?iRJp3e92li0j8vrUMDJkIwM4E7JfUynOKkqVyWAvVDsnJQ6wfcmNJglCiadP?= =?us-ascii?q?T9HJJ2UjnxatRhmXYdHVgDSA5QkVBZ0UMZnFKvP0OPzHTBxoRMoO5r48ZnmX?= =?us-ascii?q?CPZni6UNjf/Z7pk7UqZTKYq0dOTG897x/byIPTgwKCLxSW0uLQccfp82XUzd?= =?us-ascii?q?SrFyck1NQtWWOqeQ/KZvolLFbWabDQS0zLmlBX0i+lHhKvs2MpE9vYcSKAic?= =?us-ascii?q?2YCiaBYnozCCDnPZUQWFOKC4ML9BPg04FKGGj4+z6sbRBPHkjnLbbKla6DSa?= =?us-ascii?q?qpx1MhoboT86Cb3u+h/89jEgzZOkxxLqadfoWo4a4aTl9VHsn304HVpsC/GV?= =?us-ascii?q?MwmCTsdR/OTJ1iNhDGe3INkpY5OckH3kTL9dzIh+rxUTF4f8v/mHVZyf47LI?= =?us-ascii?q?y4lJqmamvzX6tl0/jWcr2yTZwZuiklCLpg/ccpyB0Lvi4SMU4fpM9ZXBr3ta?= =?us-ascii?q?VEca6O9OYIEoCYQSPPVInuqXTWw8LAaHcB16F9BnZpFp+Twzrbn5WAbpmvIH?= =?us-ascii?q?cwx1MR7gA5CYpd+UNbSI0BIYJjsWHa/DMF/ZP1Os5OGUqEZhuPQJUO90BCqV?= =?us-ascii?q?nvGykX4qOMf44hhfkW6ZP0f+EkcO/QvYgI1pPP+ue1ychK/xGI8b9sVEKnn8?= =?us-ascii?q?XRrSB/TCbAUQQewdpVOUOPeUeQ2kzqTJfniPD7cG1KKlJrjKSKbv+yr2tWCi?= =?us-ascii?q?EbJE+fcXqdQjqNWKAenXATnsljgOmiPGG3izxelylRjMF10uk5u0aHvCtw6y?= =?us-ascii?q?pdreJDpMM2c8ML0ObL9qVKH9HkTwypFFgXMWncNoHPNWLCc8rTWcidMGzFUU?= =?us-ascii?q?gornoz1Qb5gOcrJ7zQ646pm9U0rDE/dzUWt5QA9ufZjOccNNEqbqTgRA2FJM?= =?us-ascii?q?Qk8LRld6v4GIrsvBpUTJkI3L26QkRK112H0ArVjoMbUYozsfZ8xDtBODPQQD?= =?us-ascii?q?pIZ76E7DYB66YZpRX9G0U3WoUgECxpcNt0tCQu7+GMOoG4VtsBPM+seiehK7?= =?us-ascii?q?S9GpKLi1k23p29sUjaz+4yJirNX9WRkLVvNRjwbA1t1pAOfguYAzPPhe7i4V?= =?us-ascii?q?lHr4fPPpIW0zTzB5zyizutln69UGu/DWl0zKn32WNPAh/4dKk2lh5CzDzdzp?= =?us-ascii?q?3ord4dHZw0eQqHX53nHb61VxpwGQgS5qO/MLS93j5cYRjj8GiNNEL/RFW1FH?= =?us-ascii?q?t6bJq+iasjBDOBeyHqrh/fDfBi4OVpovDlJfUnzkihe8xpDGTfRmzb0YgfIs?= =?us-ascii?q?GixHosInAUDbCJw0bJcSz8+H4sfTTvRGmKlzEMY2DvbQtua59ZQhiPBZzBHq?= =?us-ascii?q?UuQh94nlaeZiGD4qTRQjVhkYNnRm6jqmceIDFbID7+MC/z1TUHLiziZkAZUs?= =?us-ascii?q?fn/3pwxB5K/6Xoz5+FYRWaesUALRLj5HUzCVtrDMG9cu0zRt9yWYsoGJc9DK?= =?us-ascii?q?tC3o6L6sPx3GAZBexUaQ2knkn4JSK5BKuLieFiRJ2mJAqtaUQOkQNFivA=3D?= =?us-ascii?q?=3D?= X-IronPort-AV: E=Sophos;i="5.93,193,1654574400"; d="scan'208";a="76659829" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AbslKTEGy5+4Ccc2kIb0fOeIVkX+RiwzX9LgK24qBh6petcde0tkNlgMUm+hZHdwa4cUQN41Ijxw+DGZrE/wR3QNQJaPbB19lT8cdcDj4l+Y3FvTxKL8hgHMFNDd8WYh1/mAwxt45EouVw24KGjWOUu2BFPkcPphtKlsdBdJhA35A+8k3n9tfmH3RDg1o2dctHtsHbuZ3GoCpooyCRITN6kXhA+wyNnyWYDQJnN1itDXQZdM5MEzYPviQYBVlvejQClRu91CjmwP226ScD9NWHSdv6060rUZXxczqWsMrL/LKXAD05cu49oAbLP4BDqeGG6uju2OWeKWy3rsL6elDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RdOaLCovUqWBLqbLJOTx5EZ+Qx+Q+jv4/3hEm+KlMyU=; b=I/g8GkCtmi4mkiEQrGLoukvUEUUY2ogYVvCCfFAVzeTij8yrpqLGUD8CMQTc0KHJ44hMnr/KpkVziS1weD3HazC4g4AodrwbHruNOOmEKMfR42rHUCRmPafz6Rk5GkYqx9odeI3xWrdZ6aNLEaAdwStoCbKmjKtoja8Sh4Raul2WnnYrifyAI8qXxtXAiUCub32qCYz7f+imLlI2Pf9PIbfu+3fkIh/cia0E94M3j4yXL0i2sz0mh5eB4g2IQRw6NtWC6zcA/VWqmhxiLRIz8ZlUDjeolvTKNbNSMvAYWmtTQBj5A3HPOQbIqwa40pHDsYoOzcQkh52Lqfj4SLW7oA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RdOaLCovUqWBLqbLJOTx5EZ+Qx+Q+jv4/3hEm+KlMyU=; b=es7PnxoPXutxxGFzffmmTPlCcwWGhsm9QHon6XB6fPBkAJbjpVsILNruM5AIMUOel7AgDp/yEtfiZ9/Gj88CCiWHzD13xJV460Nmg0XL33QQgTxZh9noIGtSz0Ex2d7E0lk9iPOBsb2uHt1TOKzuly6HCXvU5k0WQuFp/2etYm0= From: Andrew Cooper To: Jan Beulich , Edwin Torok CC: Jun Nakajima , Kevin Tian , Roger Pau Monne , Wei Liu , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] x86/msr: fix X2APIC_LAST Thread-Topic: [PATCH v2] x86/msr: fix X2APIC_LAST Thread-Index: AQHYoQRqcpYxNv8GZ0++T/cX45qn262Qx/AAgAACuoA= Date: Tue, 26 Jul 2022 15:42:45 +0000 Message-ID: <3b23d5a1-4b49-6c12-2539-dcd1bb2de735@citrix.com> References: <3e5ceee7-533b-1cae-262e-b05b5b22692b@suse.com> In-Reply-To: <3e5ceee7-533b-1cae-262e-b05b5b22692b@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 367e389f-e5eb-4e33-4820-08da6f1d7c28 x-ms-traffictypediagnostic: MN2PR03MB5293:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tsWedfHEX0lhfkiozWIEcC4YAlxogKbkNFwm4Axg5G/zcwE9KsfGYhYUk+kWMRa8TZnbbWCKiNIjLVhR3oC+7SmDk3j2NZtJsvCtYXTIRXNWdHbGGgDeY5dt9nWHj+0RxZQbo7Xed4zQf+WTqXVyHtvV8pf3X9a9G9ACcspFqM13L2fwB/OAINWGEY92nHom8qF5wgzYzj3VqbHczUC17Bp0m7LuGJUha7wxRKP//cz1UVnYLH20mlo0dLAx1QpBpBxMob2igP5tZteNzmwq19qnfFRt3YLHOHeSS7YjV/ZXweLrTIM+cVDH9Xu+5Uh7CG3Tgo1q4g20CSGZmItq9HQdw7RNFJyIIR/zHyLhiTjcqswSxaLIIgQNaS9u4ayq3yBRUDfrg04JLYUSZ3aBIwTvulEEWq8i2Fss7+UjF6pJiOlkzktn1Ar/ZThlWXYbC3ridzcI+vDg5YMxQrkS0UrtTPlf17m5Ggcgi783pS/UvrVr2G4D+GKLlZyhzAi7hkhuYaL+Cu7bH0CnNdM+sctipq/eyIHi5Z6IbOb/9AyWDCnmvscruJ8KMovzinE5Ouw5jr+DH9JWztNL1hORBV2gHfh2lHsp6IjaxvXiMz4f8FplZkkfd/N5z8C7FwsZzQ/VNkpFDW11jNvMQLwniz3k0PsFTFyN5ZuxQVAmCeiey+7o9eZLCcLVotFyc3fJYe6FVz5COEfOGN0yqbZpJ93IVbrdoIot71iF7J+sT0XCGC3TgRupEWep0tVB2C0z7lGoCAG80H1F+cFIyT02Ry1EzMnueEIFDWSUdW/q4I6m0SIWrjx7Y8VO7M6DJtFxjF+fk769WHHQ90/hZTkEdyGjdBLlEVpZj3XEtK4qqEQ0UInAJH05BXc1OzUb6bbZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(39860400002)(346002)(396003)(366004)(122000001)(6636002)(110136005)(38100700002)(54906003)(36756003)(316002)(8936002)(82960400001)(66556008)(8676002)(4326008)(91956017)(76116006)(66476007)(66446008)(64756008)(38070700005)(66946007)(26005)(6512007)(186003)(2616005)(6486002)(478600001)(6506007)(53546011)(71200400001)(86362001)(31696002)(31686004)(4744005)(2906002)(5660300002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dUI1TE9BL0pzNndVR3FWeGtIQ0VJUFlsRjMrVTdpQWRWRjhVUkFXM3Y2MzBl?= =?utf-8?B?UWpWeDJ3M09XQzc2RkU4cndCUUlRaGFlWmVwamc2NHdaSWMxamU1RFEvMGNo?= =?utf-8?B?NVBLYWQwMU5YOXVhR29MOVUyN3RRdlIwTTRTYlV2dzhBVGV1WkJ4dTQxNTBk?= =?utf-8?B?aHJCSTA1d1I3azNMZGdRNGtiREFHeUFJN20zOTdIa21xYVhiTDBKcVhhZ0pq?= =?utf-8?B?QzVVNmhUN0NXeVlkT0NNbXcwbm00Q3RPR0FOcHlFdXNwckdCSks5aWNBOEtU?= =?utf-8?B?Mk52NDlTaytuTlZUNXp0UHcvUHMyU1ZrTFNjdUUySzVRdk9GVXNFZW44a3lC?= =?utf-8?B?dG1RRCtXbGlOR2hBcHByOVN5aVhvblBMTXhlVVBlWDZYbytrdnJ1ak5VMGhL?= =?utf-8?B?T01SNVBrTHh2MXlNdXNyK0ZjU1h0S1lLbFZpSjQwcU5KTE14RzRFV21iMklV?= =?utf-8?B?Wm5OYXVVVkNydlIzNkZ5Skg5MDlGZGVTL2xhMTFpeWs0K3dPamdXenRJZXBn?= =?utf-8?B?Lys1RkFTZXhIV3pGa2J2RXhySTJWSzdwRE9MRmZJZ2ZUOUoxT2NVT2JTOTE0?= =?utf-8?B?Q2ROMlNyU0FPeC81R2cvNGJuN0J1OFhDTVpjcXN5MlJ5U3k3ajZCOFd0a2o0?= =?utf-8?B?TXJib1loZ3NQY1pnS0VsUTZPMU4rZ0JrZWhEbHR4ck9GaDZqYnZRNG5hZHlm?= =?utf-8?B?NWM4Q3hKZHpRVEZtYm5mUXlIU1RONTVLcnZCdU1XNzN1OGNTUDlZNTdzdks5?= =?utf-8?B?TnIxeXE3VloxTVVHa2pXL2V1YmtnVForTVBObkVlbGZuc2NIYkpsWmFmV1N1?= =?utf-8?B?RHZrUVZrYjdlZGhsMG9XZk5BZkdUMXZkMnhIM1c0U0ovVDYrcHd5ZklhUS9H?= =?utf-8?B?Sk45NHRuYjh5dVlVRmFvZjB4WWFvUUIyMW9Td051ZG93QUhzVXdMM3RoS1hE?= =?utf-8?B?SkpKdEU0NGR6R2JvY05TR0JLeDlzaU15RHlJNXpWRWo2blUyaGtGYjdnazJa?= =?utf-8?B?TG9td3crWncyR0pLZjNIRk1xd0xEUHd2UXRQN1VYMFdvcjcwa1V2Z254TkpD?= =?utf-8?B?S2FSZVh0ckVOSGJkd3JxNVc4cm1aNmdLeFk0aW5kSzhlUTc0UWhtNFhhdnJ5?= =?utf-8?B?M3VjdDVSR0VCc251MndsZWNaOWc0cnJtUEZWUjdYYkVCQjNqQkJaejZhelZG?= =?utf-8?B?WFh5aFp4L2xnTHRZY0RaemM2RkhmbFJWZnRjcjNtdm5LWXAwYk0zK0hONkVT?= =?utf-8?B?bVZFRHVZMFpnblo0ZFFuOFBSNENNaE5jTmtwdDhhNUNxTDlBaXdtZS9rOGd1?= =?utf-8?B?S2dHOTR3WWo0blJGV3FGUDBmRC9WRWFpUmV6RngrWmdrZEVlaDh5WnB0M1pE?= =?utf-8?B?SzI1OEgwdStLRDhUU1lVczZhYkh0MUhvL2FXM2M0a1ZwMVlwbGVBZjdQUXly?= =?utf-8?B?SEFGRDcyOW5GZ21FQnUxTU9kcDNhVVE2ZnNEeU1haFZGK1hWcDJaWVlxT0Jt?= =?utf-8?B?N0traGpmQk5oaFdPMkdQMnpaOVdFdFRhQ3FiaURzV2FXQzlRdTY4Q000QTJM?= =?utf-8?B?c2QyOWd5OFpRYWt5SW45cUhzL1RTRlR5NVdwRS9tSnJQeW1VVFl4S2h3d3VF?= =?utf-8?B?c0hqSjJtdFB0VENiQmJrRk05YXBSOFVMekRXZXBlRXcrZ28zOUlTYnNLWE1H?= =?utf-8?B?MDZjU0pSQVBYdXY2b3ZQeGRVRjlWc2crK1VRUUo3R1gwM2M5eXJKNWk5c1JQ?= =?utf-8?B?U2JJT3F0cUxOdExBcUVHeVprbWd5RGsrck5ycS9RVkZpMStHcm5MczlKTlRl?= =?utf-8?B?MThRdGYzdUozYldkck9KS3pyLzFxZlV2YXVxaVY4NnRQNVp2NVpkZFMxYnJm?= =?utf-8?B?TUp3SGNWMkRnZ1lsS1NTclZQK2hneEZ2bjJWU1BNNnhlUUJZOEVVaUtiSjVD?= =?utf-8?B?WTI5aFFZTDUxUmRTaDk0dDE5LzNmYnNwVlRKK2FCVnpCeXBxNUNUaXdGSEpK?= =?utf-8?B?YzBqZXBOMkhpNXZpNXVuV2lPZHcrQUVMN2cySE1FZjlBeGg5RmdlODF5d0tQ?= =?utf-8?B?ME9kaDQyQS81SnNMQ1kwcGowSEdaUXpxb2VYRzlNVUVhRVJseU1iVWhLNUFz?= =?utf-8?Q?G0Ce31XDgREZPT/l+/RSZoBBe?= Content-Type: text/plain; charset="utf-8" Content-ID: <1E82570BD148CD4CBAF14E14E1A41DA2@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 367e389f-e5eb-4e33-4820-08da6f1d7c28 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2022 15:42:45.3939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q7ujVJkhVLgsmpFnpiWfq6ay7Td9th96aIc4jgr74TiN7rSvpJGsd5DJDTUOQbXU478y+LTK9tbTgJIMm2iQg/sbs17HIg5iQZSqwSYtN9w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR03MB5293 T24gMjYvMDcvMjAyMiAxNjozMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjA3LjIwMjIg MTc6MjgsIEVkd2luIFTDtnLDtmsgd3JvdGU6DQo+PiBUaGUgbGF0ZXN0IEludGVsIG1hbnVhbCBu b3cgc2F5cyB0aGUgWDJBUElDIHJlc2VydmVkIHJhbmdlIGlzIG9ubHkNCj4+IDB4ODAwIHRvIDB4 OGZmIChOT1QgMHhiZmYpLg0KPj4gVGhpcyBjaGFuZ2VkIGJldHdlZW4gU0RNIDY4IChOb3YgMjAx OCkgYW5kIFNETSA2OSAoSmFuIDIwMTkpLg0KPj4gVGhlIEFNRCBtYW51YWwgZG9jdW1lbnRzIDB4 ODAwLTB4OGZmIHRvby4NCj4+DQo+PiBUaGVyZSBhcmUgbm9uLVgyQVBJQyBNU1JzIGluIHRoZSAw eDkwMC0weGJmZiByYW5nZSBub3c6DQo+PiBlLmcuIDB4OTgxIGlzIElBMzJfVE1FX0NBUEFCSUxJ VFksIGFuIGFyY2hpdGVjdHVyYWwgTVNSLg0KPj4NCj4+IFRoZSBuZXcgTVNSIGluIHRoaXMgcmFu Z2UgYXBwZWFycyB0byBoYXZlIGJlZW4gaW50cm9kdWNlZCBpbiBJY2VsYWtlLA0KPj4gc28gdGhp cyBjb21taXQgc2hvdWxkIGJlIGJhY2twb3J0ZWQgdG8gWGVuIHZlcnNpb25zIHN1cHBvcnRpbmcg SWNlbGFrZS4NCj4+DQo+PiBCYWNrcG9ydDogNC4xMysNCj4gRkFPRCBuZXZlcnRoZWxlc3MgaXQn bGwgYmUgYXBwbGllZCBvbmx5IGJhY2sgdG8gNC4xNS4NCg0KSXQgc2hvdWxkbid0IGdvIGJhY2sg YmVmb3JlIDQuMTYsIGJlY2F1c2Ugb3RoZXJ3aXNlIHdlIHN0YXJ0IGV4cG9zaW5nIGENCmJ1bmNo IG9mIE1TUnMgKGluY2x1ZGluZyB1bmRvY3VtZW50ZWQgb25lcyBvbiBIYXN3ZWxsL0Jyb2Fkd2Vs bCkgd2hpY2gNCndlcmUgcHJldmlvdXNseSBkaXNhbGxvd2VkLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:47:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:47:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375476.607879 (Exim 4.92) (envelope-from ) id 1oGMme-0000A7-Si; Tue, 26 Jul 2022 15:47:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375476.607879; Tue, 26 Jul 2022 15:47:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMme-00009q-Pe; Tue, 26 Jul 2022 15:47:44 +0000 Received: by outflank-mailman (input) for mailman id 375476; Tue, 26 Jul 2022 15:47:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMmd-00009k-Oo for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:47:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 48f84f92-0cfa-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:47:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8379.eurprd04.prod.outlook.com (2603:10a6:10:241::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:47:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Tue, 26 Jul 2022 15:47:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 48f84f92-0cfa-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kaAiUXt3ZTicNT2tobxphGDg72mOeMm97rMzysEVy0moRa9spkS1fYE5Xmd2XM0z9LoN+Vn12DljJiWWc1gKpVGVB84dyzHavzk+QZ9fWlEy7xQ6jqsDBeH6UG9xxA9mQ/PAIhFnopkedF8MyeBD/r1NMAdw6du2eERWm5/LpCOnIzWFgV1HRjeX20QZGD6vBvXe5WSfu+Z0eMbdTiJ3VeDhfLdCtLYrsaZ4zBI4x/NMfCz5mECvsvzwkAUzs/o61mxTkM0eRj156VdORQI0UPB5A7BjrXgnrGruKc0CI8lSx50+6Y60tf+4Xs779tklhott1VhyE82M5dw54k8PUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YJVgy2h8KL58ca9SLkpUIZ7kl9xylz5GmOf1zkLhxng=; b=TQaGxR0HC7O4SHFdaVJEcTLmLZgZwnpOpTQE385h3bq8BBTB7/xeRXrJQM4BIsRFcZV2UsQb2+lFNPc7FPtZq/0BY58rIVgsYdO9sDnJTK73h566DReSJi4jAUdT37EhSq0TDLolmBnBDFnVQNN6gaPuPU6VzZE8Yyf6krCnY9DajJxqKNF5kuoKr+fS5fHTqmrIJb5oOUKrJ8GlGPKHS8VRCikBD6axjhVwz2tduKYltx7N/3QFnkHzothv80IEszeJNiAf1/bD7acz03vMpehTl/UcEkn4magjlXV3+y00PyjzObIB9ARPzkfNUtYELe5i1PBnQ5x8majc/W+MNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YJVgy2h8KL58ca9SLkpUIZ7kl9xylz5GmOf1zkLhxng=; b=QWNIOo8HQzoeUc+nOrxGMbEe3WLrfYcQMSU1ajpvIYlZPxGwmpCeExCgnVmIEIMCVWqfc0C4EwPnYbUrLsGthPINQpWdZfBQgkbb5lfzyeZxY383+dO28EtS3qgqXR9/RtYUwbY9EulaYCV9RfUniDgSH9BJ/pgCo4k+73ErUdm4P2+5FyMbgLBnSrCFIPOBz9eJe1wjndjE9EIk5L8bOy5bL8hOgZiEOc/JNMw0bVc2Frsbummkf0k9rE5QdQHaxorSrJqvgrguCURFuk9gJz5GssyoKVgSBjPNps1nYD7bBC46WxptLw5OsPWcWr3VEYyT/IHTTpI7p+cf7ayOFw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83c1b506-27d5-19e0-89b0-a6a27b4e5535@suse.com> Date: Tue, 26 Jul 2022 17:47:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] x86/msr: fix X2APIC_LAST Content-Language: en-US To: Andrew Cooper Cc: Jun Nakajima , Kevin Tian , Roger Pau Monne , Wei Liu , "xen-devel@lists.xenproject.org" , Edwin Torok References: <3e5ceee7-533b-1cae-262e-b05b5b22692b@suse.com> <3b23d5a1-4b49-6c12-2539-dcd1bb2de735@citrix.com> From: Jan Beulich In-Reply-To: <3b23d5a1-4b49-6c12-2539-dcd1bb2de735@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0119.eurprd04.prod.outlook.com (2603:10a6:20b:31e::34) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 97629aea-9834-4fdd-72ca-08da6f1e2bf4 X-MS-TrafficTypeDiagnostic: DB9PR04MB8379:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5K4FQkbHmp05yarn6spZIUffDN7So/NJV1/JJG5KdD5gJcNzchpoajKwEr4HrkQPUqMgxmzpz05Fpsfyh3YTL8AAT4ql8QGkyid/segmjReNsu/BOH429zstvxFzfsgua6faoQ7Io+xNnn8SeMUFFkzpP+w8sA2OC8fLbF4OorEEKI80VvJMEYpfCz+nrwToJ+Vez9GUEZEyj2+T1bM15LBLSVi7JzzX8kLmllt0IAIT9FpNgEFtbXNIGFbPfgkh78jVxyntchbT88CFHoAnW/vZ2MsD9aDf7cDFmPpPElxiLPlYNCQn3k3KGo+gPorYonhQeUPbqO5mDNMSa1x8JD1CsaMQZ5MQyGlt6FRjJBfbZ5Qvl4q8pnO2XwulHRHlDujYQ5zp7RFKkTP9ZDBU7gIr9NY4ZV2bE1PqhUakPsz9SxjZLoCvNC1sq3aethc6dFFn4CS5lVD/C8gyoSdwfEFxFXMNmj1qCfAs1fP7fpzzSp0fVhwxHUfQAYBbqUt8gObMjG/faRdt00SCh70ppvmrMPWf6yE/PHXsh5UKvPAhGZS8iUX4yHjvyunoWYS+36lVnkB6+r0EOdQ29ITh61kEWOFCa/lnrhhVeQk1qzAwXgMIfao+OG5KvUhsP9JaieNM3SKIt+vEO/uprgVTDcbc6ij0PunA0XoYh8p+PRTeQpZd/NMIde5xbI4fs2Of9X0JQHFRCXnn+7Dui/b7dQjv5zWkI6SrWxLrAaNYboem40p9CdyxZ6kUo+3M7NrxL5rq5YlNN7eWNDaNVJiNbHqAa5NPwDANOe8G5b7FrXQcGZJN4bTgSG4gvGA2YngtrXNzkH92huXlcH1+ksCOgA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(136003)(39860400002)(346002)(376002)(366004)(186003)(2616005)(6916009)(66556008)(54906003)(66946007)(4326008)(8676002)(83380400001)(66476007)(6512007)(31686004)(6506007)(36756003)(41300700001)(53546011)(26005)(2906002)(31696002)(86362001)(38100700002)(478600001)(5660300002)(4744005)(316002)(6486002)(8936002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzBYTWt4R1J6ZDB4eldyQ0tPNzI2dWRhN016VjlxS2dDTEdPRkFxTFFqQ3VL?= =?utf-8?B?SDltQ2R4TzhWU0N1UDRueW81Sk8veFBFTW9nb1JNUDJoZjFXYTdQNC9ub08z?= =?utf-8?B?dS9ldng0aWtPemJnd0RzMENIZk9ualN2cVlCTW4vaG5sd2NZcTJXZUFIdFBT?= =?utf-8?B?R1lTQUVYZ05qR0hEWElDUDI2bzhrcVc1Mlc4eXhnN3o3ampTbEhqTGVjSS9C?= =?utf-8?B?L3ZacktnaU93b3Y5elVWdVBxOTd0UGdYWGFBNUZraDdEbTNNMWhyUURWUWRJ?= =?utf-8?B?YVZBNlpzOG5acG5lbmNIWUVmQmtuMFZlNENoUWJBZGVUQVZRS0NqUEJGdldt?= =?utf-8?B?TW9YTFVzRGFLM00vRWJMWnpHVWVHazN2SGVKWXE3OXRqOStUUkVvUUZLazNt?= =?utf-8?B?QXNTR0JtWGZCOFhEekxTOG1FYjIzbGpzZzMxUlA3ZlEyVGU3dWlQU3hnVW5l?= =?utf-8?B?UHZZS0ZvV0kyQjQ5VThvOVNiZWNIUkNKNUQxdS9sU2dZRVkyNHFETkVnQU56?= =?utf-8?B?QlB4ZHE4ZEhITVc2M0loMkhxWjN4WkhITTU5WVd5dWRvN0J2cEJpaUhDU2xq?= =?utf-8?B?YzZtY2xKa01rYVdlRGp3dDdmS1VFR3V1MzdjOFRRRCt0c0lnaC9vc250SDVV?= =?utf-8?B?M2JhNUlRZzJVNW92anlNYXF1Wlp5UWRFOUlSOGoydytCSUo5OTU3ZlFIeTJZ?= =?utf-8?B?SG1ETnd5dk11amFZbzZ3UjQyMjhvcjFzaXZhNnF1VElEWENLN2dVSFNQaG5D?= =?utf-8?B?MTY4eUM2bVJiaWpFQS9MdW4rWnJtNjdYUUpobk16Nm4xd0lHRGdHQlBlaTNB?= =?utf-8?B?R0RSenZOd3ZlZUNkRThYZkd5TUVxSUpjakdublE2djE0NkdFMlZ1Um4yY3h4?= =?utf-8?B?K1RqcnBqSkxaNXFqSm9obFltOC9mUWNNUDBGeGhkeFZvMlBDTFpBSG5iaVFL?= =?utf-8?B?V0orS0RHMHIwQkkzYmJGSmZmRHQ4akxydys5T3ZPcVNLQlZudTRZUlhjeE1z?= =?utf-8?B?c2tkeGhaeU5qNDRWaUpzRGwreCtsdmtmUGxUMGw3aTdSTjNNbXgxMkdkNnJM?= =?utf-8?B?aXhMN3dnak91aEhjKzk3aDJ2bmJaQlBLNXBRVnl4R0JLZnFCZUREbFpPZElo?= =?utf-8?B?RHhvTllrNHBHRWhyMGVzSS9XclFYZUQyYVppTnVqSUQ1c1FpVXdJb0s3bVpp?= =?utf-8?B?cTlwbklramF0c2dkd3B6T1lnczdQL3BBWGxNS1pZTWFMR2I0ODYzTU1NdnBZ?= =?utf-8?B?bVZHR0NPc0xiSk5SRm84a3dOdWYxdlB2NzdodWVhWVk2NUhCUGVUeVBtNDI2?= =?utf-8?B?WGxOcjdncTM0bjhTTDFwclkyUzVnai9FRHhSblNUb01NQ0E3OHB4Y1NwSWFM?= =?utf-8?B?ZFd3SzVhUXB0ZTJjMldWV28yZ1ZGaGJQLys5aHFWRDVycVJMRC8zeTlEZ2o0?= =?utf-8?B?NGJEeGlnWnA0eWxmUDJkSzYvRXk2RklJN2dKNENlR1gvTUl0ekNmWEJkOW9P?= =?utf-8?B?WS8zOHQ1YmE4MmprU2wvamM0NG1PZmJkdlk3bXY2clVKQlYwdExmcFhucnFE?= =?utf-8?B?QXg1ZnhxZEh2L0hicDR4b0I1ZG54cEtKUm5GMWhUMjNBSXRJTFFWQlpUTGpP?= =?utf-8?B?U0srYlpEamptbzJWKzNxU2VPNlRhbkp1cXRYZFdTRE1NNUc2WkpQOU1xalVa?= =?utf-8?B?UVdyUkRZaDkwUkl0TUpRRWl6dnJhMldRYkdQakgwVkZpVmpsdTFIZVJzaEg1?= =?utf-8?B?YmlEZEplbGUzUDFZV1NyRnNHdURYakJmWElKcThONElWektSVlUzMUdDQU8z?= =?utf-8?B?V1ZjendKbkkrdEp3eDRPWHpxd0wvaitiZTRuMTNZT3pneTZzYjIrWkYvbVgr?= =?utf-8?B?R1dCamVvL1FUakVPaTFwNTVDaUdHZllTL2U5Y212V0x6QlBLN3g5SjJ0dlFp?= =?utf-8?B?eEVOQVNxV2JMNzRqeEJRZFFVZDZVVXU4SkZNQWhkOUg4bHpBaDRHU21XTk8z?= =?utf-8?B?eStLWjRiYzh3aHFxNXBQL2FiQjFSNmhhUGtSaFpZRnlUNWYySGRwbGJiTFRR?= =?utf-8?B?WGJmQk1jK29adys4Zm4zMGp1cVJFUGIxZjI2YTRZRU5WWExQSGZZWlN4OGJu?= =?utf-8?Q?JAHZxJD6y6UZpzhWcd5Wm1Bqu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97629aea-9834-4fdd-72ca-08da6f1e2bf4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:47:40.5363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pTotQ6W8U1dvOW1Jdf2zP9sGeBbxVUADFgBa8jDdAy9WH6Dqav+PQdNWso7RL+j5+yIHlUDgobWlj8MDJtS66A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8379 On 26.07.2022 17:42, Andrew Cooper wrote: > On 26/07/2022 16:33, Jan Beulich wrote: >> On 26.07.2022 17:28, Edwin Török wrote: >>> The latest Intel manual now says the X2APIC reserved range is only >>> 0x800 to 0x8ff (NOT 0xbff). >>> This changed between SDM 68 (Nov 2018) and SDM 69 (Jan 2019). >>> The AMD manual documents 0x800-0x8ff too. >>> >>> There are non-X2APIC MSRs in the 0x900-0xbff range now: >>> e.g. 0x981 is IA32_TME_CAPABILITY, an architectural MSR. >>> >>> The new MSR in this range appears to have been introduced in Icelake, >>> so this commit should be backported to Xen versions supporting Icelake. >>> >>> Backport: 4.13+ >> FAOD nevertheless it'll be applied only back to 4.15. > > It shouldn't go back before 4.16, because otherwise we start exposing a > bunch of MSRs (including undocumented ones on Haswell/Broadwell) which > were previously disallowed. Hmm, I'm confused - how would the limiting of this range cause more MSRs to be exposed in 4.15? Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 15:59:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 15:59:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375482.607890 (Exim 4.92) (envelope-from ) id 1oGMxY-0001oi-Sp; Tue, 26 Jul 2022 15:59:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375482.607890; Tue, 26 Jul 2022 15:59:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMxY-0001ob-Q5; Tue, 26 Jul 2022 15:59:00 +0000 Received: by outflank-mailman (input) for mailman id 375482; Tue, 26 Jul 2022 15:58:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMxX-0001oV-UE for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 15:58:59 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150042.outbound.protection.outlook.com [40.107.15.42]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dbbe1c18-0cfb-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 17:58:58 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBAPR04MB7208.eurprd04.prod.outlook.com (2603:10a6:10:1a8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 15:58:56 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 15:58:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dbbe1c18-0cfb-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JEiDuMz00USppvBuL+2buMmzx5u2V7ohqMJ98LeyQ3G7TfEjeUncn6v6LtZX95ngbq7rMGKBbzXu6se9Ez5qf63Va5vRFK3S7qXvSGeeiYl2TqiVUrUVPCt4OLkYnEaaL4nPj4Ag0lp488uN8o1QS907Z5rWe3zVK4eqEm0sZK98TZMrmPIrQc3wq5n4CNeBY4L9hCBKfHx4JCf7Ihaxl0kJW+bPO+n5TsFqQj2Bx2v1F5PeU+SR3WSHIbhOOGTeH0IzvTAiJwR3luNet/pmz+40lUwLyp3rp6d6lG14NsAVPhysaRvcntD9mVApcpIagzgbmbSZ0jZo2HEpztzUOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jLOj6yoCnkqIWB4fGvFMXNthb57eDnQEkou6bf1+w1Q=; b=LlNUwyG/2F/Gi9pT7dUHvXSWCQTzB91Ak7YH2VO41wtBWgiLvOVsiamaKdH8jMi5JirxXlTkGkZGzYWeBAIgyOSOvcxSL+684jVIjMdRnYC9S25yePZLcmceNVQU+b+3nW0+Xr8GNgeUTv3Cj2evZQlOa/7uQwYkTK0JW3tUrSoN+ainvI/R3DML/iocO3r5aYSMGhbfBAjKoGGz/CfwhxEGqOnQEgRpb7+4jad65fUVinPrY/2TMq1ovXzNh1F8NZFNTSfnD3dP5V4+mRjr8XjP8X8IwOWfLLKyztqLL4W9OwNAkqSI4DDgEGMbKxhmtvGQ5AeakyTSBEjxoRMnrw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jLOj6yoCnkqIWB4fGvFMXNthb57eDnQEkou6bf1+w1Q=; b=xVMMnHNDwJLecGXDLQzj2EYkQZVVkJxn5n22LR26hlQ8Pa4v87hGZYcA0jYwR/hpXC+TiVf6X/Cly0rfqKa/Mdsghr1pBDMEmQovDajWIVt4AUB3QLhiMFgmLCe7/2KsGum38IzYKnS0gTK+dwyxmWabTZmSO4XIOCnFLcpRmmVKTcg/WtpK6+ELFl/hERjyVR3ARdWw7bh2vzcBOqCoWKAS+s3KeUVXEI1tSE3yFSulHtlxQgIqrzSqf3Ha19hhiX7xGtt90YecM6iOV89jaFs8sf1mheoSecCKZ+Pr0M+NsvPw22Brd2bCDuj9ArlS0pGu3jmNZuXPtSnfGS/j2A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Date: Tue, 26 Jul 2022 17:58:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan From: Jan Beulich Subject: [PATCH 0/8] x86: XSA-40{1,2,8} follow-up Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0132.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::14) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c4e1688-a131-47f5-f44e-08da6f1fbdf5 X-MS-TrafficTypeDiagnostic: DBAPR04MB7208:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YAZsHlmYYsT62VH2y1dRR6IcbM2seq1muvilhqB6wrpx+uayba3WbMxq1ebbqTcrw8g2xZs0KnEDaXNu6CHPvjmtX/3ZtafNzZHyyqQ5AuzDB+mI/4OC35ipo9LOv/ucFzZvMAXFWtRgdQ2J/jemnf8soY9c/+W+cRIckFLSMlR+Be7SLajl77lBNt7OxRZg2GDbK9PxfGlcpH4M4aenMXVZ44B0iIcEAUDi/FA6psN7ndrG6OzpyXPf7/TiVCvmaotiEvKHJ5eAiLIX1vrRFNcBPPr5rVblo43BrhsgMKXVeVGYuNw+Nf2PjhRU+u+uKmXZeMTycq4mRXUvFLOj+SD9QG/GK8OuGPbPQCtOgXCWshQbrVeDVLFCBF5+uqTb8FJ23sClep1MUDHvvYgAsXdMVUg1BkmJFmEGsQdIQYjchQZr07qRNJyjNu6S0RjTU9WoVkkYU16l5kBLrA3AxFQwGMSSx+aHltrY+2Z+NvFk+F/+scs06+bgB3pxZCQJStSL4AHIMWDFtSgayiSNuVPfDnVmza/1Ieg36FBSpYJv8sy7KzNRHIYfKKepB0icEwtjxnb6jF6EYOhs9vQVXX6RYcEGy+8XwteYyfx9kkbvpsZLJcBwrT0C0BtWsRd0mTqjnS4n4RM9tj1BGro04Uqf3tDgZoqnhH2IuyQp7UdXgcw78fQjaO6ztQaoOCBroasGtAdopHrnVDF4I66Vcuw/jHdlQgQURpl/jwagHS/m7Ei6pUB+bsA3oJUozBmaZACXShT2QP60MfGk9ZhLXeCkmL4f4xjUVByI0zBekzFUMn694MB/Yx9lYsxMEfNjx0TPje4wppy101gqQHp2hA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(376002)(346002)(396003)(136003)(366004)(316002)(54906003)(2616005)(6916009)(31696002)(186003)(36756003)(6486002)(38100700002)(4744005)(2906002)(5660300002)(8936002)(31686004)(8676002)(4326008)(66476007)(66946007)(66556008)(83380400001)(6512007)(41300700001)(478600001)(6666004)(86362001)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGpKWG1NdW1Sc2FOR2p5UU1PR2U5TDZjYWtlRVBENVg3OTkybzlFMFRiTWJu?= =?utf-8?B?YVU0UEh6eWNrOWJ2YzFpQUZYckhPaUVyRGxRblZsZ21HRGw5RjgwSng5Y2lr?= =?utf-8?B?UVVEbjFEZWNqZklFTmQ2YitlbCs3SzB1eExHSmNoTXlOV3Y0SVRtTHI2M3dn?= =?utf-8?B?Wmt4L1RYcEhlMVE0OWZZUCt6RnZmaWJMcW0weWFwVXNjdVRYK1g2WXVweVhZ?= =?utf-8?B?cFVSSWpOS2p2NERrVll6NE9jZmlQQTNjNmZ3TVpiYXN5TmdhRFB5Nk1UR3Mx?= =?utf-8?B?aUszOTd2YTV0VjlGK2xBTjc1VGQzaVYzSWpDNUZxbzltSWx1azFoaVNnTW1z?= =?utf-8?B?S0dvb3NEMFFzMkxzOVlna3dZMFdBZndTSi8yeThnWk1DZ3VrK2ZhSlY0R04r?= =?utf-8?B?RzdDZ21wb1F3NG9yNEpjTmh4WjMrNENSdWRTV3pUQTFlNDFBK2RLSnM5ektC?= =?utf-8?B?TVV5Nit2ZmtKSm1BR09kNmNVZk5wdEY0Ni8yRVNRYVhRTG11ZUhsZ1JRcFF4?= =?utf-8?B?QzdXL1pBTGJ4UERCVERXZlBVMTE0TVQ4SjgxNjY2K1hWMHBCS21kUUNEb3Fp?= =?utf-8?B?blI4dlJpOUdDdDcxU04wR3JMSUU1YzFlRWlGc1BRSGV2cTYyOXlLeVFYL3hk?= =?utf-8?B?OVUvZ3RKbTVHU1gzUEd2bk5aR2dQRkN5d2ZXdlEwdmRIN0RhTjVzNnZzY3Rp?= =?utf-8?B?RitmYUcwRTZpWW1pem5TREd4UGhqUG1heXhrMXhYRFo5cTFzb3NhMWVwZEs0?= =?utf-8?B?YnVXbnBHd0RXWFJINHhrcnhpQUdKU3hCZ2pqZUVJQXpLYnYvcnVRRGhYckhi?= =?utf-8?B?cUZPSyszUDFNeHppSFdoVEFCUktBYkpzY1k3eTZLM29rdWtqOXdZVCtvZ0py?= =?utf-8?B?VHV3R1Jic2dQZ3RzOVFpY2xWTVBMNTZRbkFWaCtVTUNNZHJWYk91YVArOEZQ?= =?utf-8?B?VnlmTjJvL2c2cDdlZXM1VnRsLzhDY3I1Y1dzWDVaaEpNUFhMUTFBZjZGVE1R?= =?utf-8?B?dkdSckJyWGx0TE9sQU4yRWNYSW1GNUIxQjB6SDlYNVEyclJUQTlWT01ZMFIz?= =?utf-8?B?QWZsRW1CcVNXVjdiVTdTRjZWT0dJVlgrYmlUSUQ4YmlaU0RiMEJtZnpWQTlQ?= =?utf-8?B?UGRsOUkwcnhmZnROcW1vNlh1TXd4Sy9FbDdrS1BUWC9zZjRyUVNZQVJxdHdv?= =?utf-8?B?RTV1U1Y5NGJMNE9YeUlraVJoUStYTVNjeEFVR2k5bzQ1eU9PazdMU1dFOHhM?= =?utf-8?B?SkpSRjNMQ0NYeVpGLy9iUjdPTjF6a1NTQzdyUFJqUjMzMkQrWTNMdnRGMUhW?= =?utf-8?B?bEdwWXl0RFlFbHdXNGgxTTZhM0Z5ZXlRV0hzRnE4eEZwb2JCc1MvQWh2L1JW?= =?utf-8?B?b3dFc09IV1pTWVhyVzdVMjNJdWJFcWMveHpyaFZjdFIyYmE0eXFKVzYrcVVq?= =?utf-8?B?b1c4QkpHaitJdUhSMS8zem90N2l3aXh4czNVUjJLbjlPWStGUDdudGpUTy9U?= =?utf-8?B?VkhPeFltNzA1czZSVm1vWXBmdnlmTGJBVlpSblBaR2RmdXl2a0IrbWJTMXJN?= =?utf-8?B?NUdtaWFBbndJakYzNHowMmwyMnA1cldOWmZpMk1nK0dyVzl0Qno4MW02a3Y1?= =?utf-8?B?UC90cTQ3bzJVZjlBL3kxZER4am41Mk11M3dqTHZ1aXovTkEzYXVNL053NHBn?= =?utf-8?B?M3hicTA0RWZJS3k5TGFMRlhZZTBxQURqM2d5UU5MNDJjSHdhT0g4bkFjc1Ur?= =?utf-8?B?TFhLMG9wdzI5T095Ylh6NXkvMGRrYVZHT0JyMDVSdmYrdTJ3QlUxTjNZVjJq?= =?utf-8?B?LzB4eGFTajNkRnZnL29KVjQraFRoSVU5OWVDWkFkd0d2TEVuOUQ3L3ArSGVs?= =?utf-8?B?aTVWakpCNHFOMDUxS3ppN081anJXY2szNzlVOEJQMFpzbXpkZk1uUnRKZi90?= =?utf-8?B?czJ1SEJCeTN3cTcxczdhditnVGlZSXdCYi9KUE5RWk8vRlEwWVZHTkltV092?= =?utf-8?B?TnNIZEhCZERLNXBkcDlmTXBPdng3Zm9Nbnczb1pEWkdoSUxYb1pOMkhlSDJq?= =?utf-8?B?dUNJd1N6NytKWjlsbUQvZTNrcXVrSW8rN2s4b0wrMkNNeWM4OUt4b2xEZkRu?= =?utf-8?Q?asHtQPVtg8UnQ/1vV9Vg/HeWV?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c4e1688-a131-47f5-f44e-08da6f1fbdf5 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 15:58:55.5371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4GInIJtu3m047rmd5/ZXNDrcpfGsOPxIh4qmNZ6wGNjrzkB+QBHFIQc1eTQ8Y+j2OGxdZty801mA5PNxuC/iJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7208 Perhaps not entirely unexpected the work there has turned up a few further items which want dealing with. Most if not all of these aren't interdependent, so could probably be looked at (and go in) in (about) any order. There's one more change I'd like to make, but I didn't get around to making (trying to make) yet: PGC_page_table being a shadow-only concept, it can apparently simply be 0 when !SHADOW_PAGING. 1: shadow: drop shadow_prepare_page_type_change()'s 3rd parameter 2: shadow: properly handle get_page() failing 3: mm: enforce return value checking on get_page() 4: shadow: exclude HVM-only code from sh_remove_shadows() when !HVM 5: shadow: don't open-code shadow_remove_all_shadows() 6: shadow: drop CONFIG_HVM conditionals from sh_update_cr3() 7: mm: adjust type check around _get_page_type()'s TLB flush 8: mm: re-arrange type check around _get_page_type()'s TLB flush Jan From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:00:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:00:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375487.607901 (Exim 4.92) (envelope-from ) id 1oGMyv-0003fz-6p; Tue, 26 Jul 2022 16:00:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375487.607901; Tue, 26 Jul 2022 16:00:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMyv-0003fs-3c; Tue, 26 Jul 2022 16:00:25 +0000 Received: by outflank-mailman (input) for mailman id 375487; Tue, 26 Jul 2022 16:00:24 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMyu-0003ff-27; Tue, 26 Jul 2022 16:00:24 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMyt-0003Za-U7; Tue, 26 Jul 2022 16:00:23 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGMyt-0002yf-Dc; Tue, 26 Jul 2022 16:00:23 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGMyt-0005WN-BK; Tue, 26 Jul 2022 16:00:23 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=WQArU4Opbol7PgfJKS6BEJV8G9TwChL428LBp58LrCs=; b=ISTYY9aJ3XrhKOesOCGCOpJN7S 0Ry8pw9CERsPUdIT0HOFinpDEuXBjOnJpAMC8AhhihqA0z9IMqp07YWTE3v69J0Vui3HlzkrD7Dss guesoZ3HfFByZexCQkp3Et04QdbzBUDRUmFXX+1aEW7fEsBdYmCB76g4bej8JCpu5Bm8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171864: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a9949efb288fd6e21bbaf9d5826207c7c41cda27 X-Osstest-Versions-That: xen=5707470bf3103ebae43697a7ac2faced6cd35f92 From: osstest service owner Date: Tue, 26 Jul 2022 16:00:23 +0000 flight 171864 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171864/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen a9949efb288fd6e21bbaf9d5826207c7c41cda27 baseline version: xen 5707470bf3103ebae43697a7ac2faced6cd35f92 Last test of basis 171861 2022-07-26 07:01:41 Z 0 days Testing same since 171864 2022-07-26 13:01:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5707470bf3..a9949efb28 a9949efb288fd6e21bbaf9d5826207c7c41cda27 -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:03:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:03:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375496.607912 (Exim 4.92) (envelope-from ) id 1oGN2E-0004Kr-Ma; Tue, 26 Jul 2022 16:03:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375496.607912; Tue, 26 Jul 2022 16:03:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN2E-0004Kk-JC; Tue, 26 Jul 2022 16:03:50 +0000 Received: by outflank-mailman (input) for mailman id 375496; Tue, 26 Jul 2022 16:03:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN2D-0004Kb-Cl for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:03:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2055.outbound.protection.outlook.com [40.107.22.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 887ca3dd-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:03:48 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7532.eurprd04.prod.outlook.com (2603:10a6:10:207::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:03:41 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:03:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 887ca3dd-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BIsewXBuinDiU6BWlep3Kw0xfVyWr3/hkR75U4tM78IIJN1mWcZ9d/SA/f8gmXeDKe2lS0t2p+ji/eXvpF6SG/aQcL8GGuK12OoWVwCgAi8sOWZ9mC4oaiWvks8prnumwl03Ai1In0cxdx8y6HS0LytoN/OG+KPskTXd4hZ/QMVxbrSQE1QidR0QtoVCqIVZ/KnxviD4TVf2nZOiuE9NmoohEt17DEZOeod6Dap7yNoLadGqMsSF/3qMTF6QpZHHIYUwbR9VxhCVGEmnwGXwisPjVrV/X37ZG/CGLCZBuviBJcPfGnUDfwC5dXW5V/tuaU1jaqhJYDTXuzZ+HT2ATg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5J6VHiXD4VRqnlBRJoS4Bi+7owZxh4DSFzpTxUKvMX4=; b=WZkJujO4AXI2Hdo7p2KfaHNAJ7Ukf8eN3I+y9lKI4zLiUitkWPFtCakPxYpcTp1hBLakvyNVTzp+KNlIemmsVODeX/VjSSXklKtDKzdzHUI3p/m+GjUYbBTolWEHOTBDtz4dXvXrDPLkICq5alnPdTmuYi5zLkEhQ2appKiR7crbRKl1lN0pDuO2b+DtAVTDg/vybjJFN7mVHZrxZFqR7jxvZTO+AdYGmNP9mu5JvhhFWR/OYwF7tVyix1Q/isFuszUaU/jeI9qJAqnaaxvEvX+R38wmnKIBdhYTaG496h+vSbMFW1OacMjN9JSAg8yG92J9impEwrzCSvGdHSDzIw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5J6VHiXD4VRqnlBRJoS4Bi+7owZxh4DSFzpTxUKvMX4=; b=KPTvcddME0TE/pwUKDg7OwmIeggQWrMSQcGNISNyM+KwraL6jAIbHuidThvftYKJOEoB2fHuYByXMBNiXtZCqu7j/26xoRtha0lXvtNHecgA2XksSmm8KkifbT7XU64Tpttf2ajtsMFm25ueVMxxxVmTcm9dQIxmRzCdLg7BRoqYkK5hVveZeVOx4OheRYnQozBzlW2WVB0aW+uAdEdZiTuqTznBOFieyOepVBSMdjx2imZTCnXY1pSd/yai1uFKY7LxfrM/QUCXuOZs+etUiSUozQIZWJSzXS/sYnQoY/6HP7NnFUMw+9zuBMhB7ZROghV/TLfpUJveyFNkyM1Q3A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <50abcb9b-8f69-0789-5f12-c422ff71c3ac@suse.com> Date: Tue, 26 Jul 2022 18:03:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 1/8] x86/shadow: drop shadow_prepare_page_type_change()'s 3rd parameter Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0189.eurprd06.prod.outlook.com (2603:10a6:20b:45d::7) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 049105d3-9bc2-4823-e063-08da6f206880 X-MS-TrafficTypeDiagnostic: DBBPR04MB7532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DPxeoeQ9foYRKH856maPe6KNA4wi42EwGrUk4Vu1GamaK+EiKUbyNT/U0CLAhFUx5P3r811YvoTm65YdUCXAz4n+p/k7K9ZIb7QxkdIqZlQBavZvfObpYZNUzfe7iJW9d79cWgY7aePyc81dT6MMCAwagaJYPZvX0CSqwxw8lNjAsMCqAZy32fxVgwKN5xjNj3Ui3ZELlAkTWPik4R7RSIlkslcIE0UJThOjadZi6E6RQCRtj+9a+enh2kaynHcdUj+W1ShVL5/ZQtT0lfLgYPVfxuRHLrZ7IJIkZVh2Qs9VMEU0lvaP9NqC0UMgwt2PsVkqFJOyfNRV3JoUirbJB8kOhxWG5ImJyY+k9F9CSLPLxr2go3zmFoaDY0jAfx+d/REVoz24eujfuet2JqY66Dx/BZnP1+jT6kniXSHFZsgAYMX6CXodRN8DuNNdI/jEfKQ3Y3pMZ/Opy4CAPc3X1gyVcgKGRNIxts/MMQxnImlwY5x2EEiL3DCOldLij8F9PukceVYb1aagoc0x9M4k+wFYoQ/HAd98Io2OiiZELf/F8NLm1VVzH57NsooskpJW1oS5X+X9c+K4RReZyEqDY0TUfG7KUEh7w2jKUKYd11xoom6UdUxea+zV+My7Sd3+ElpX5tYZl87SU02fseHUKBeUzaMUeesyT2Hds7NSwHfADuAGqy0qjyTiO+lNLy9ZhhtajWWyKsd6oXF5IqLatZShnezUd+diLWaLXSdFs5jTJxJGcWQVGgfbqtDFKR+aEmo64LKQAmJq2gfDApoBAvCbiTyoyYXgxsyd0CvtEdm4Xntqwy6XuZVWdnqt6e+vlOxiZEjlwQdCbG6L21YMhw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(396003)(366004)(54906003)(6512007)(26005)(6916009)(66556008)(4326008)(86362001)(66476007)(8676002)(186003)(6506007)(66946007)(31696002)(83380400001)(2616005)(8936002)(316002)(6486002)(478600001)(5660300002)(2906002)(41300700001)(31686004)(38100700002)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SVFlMjBmN0ZEWTQvalg3dHp5OW5IT0c0cTVRMkczZSs0V0YrOStKWVhrcjdC?= =?utf-8?B?ektpUUx2TEZjdjJtUTBEM2VMQTlYb0M2UWJsRk5YaCt6VFRyRXQ5dlRhbUpH?= =?utf-8?B?dGpzV3pGTnpLeWRPR1ZBQjJweFp6M2Z6aVNjeTJEWG1CTGk4TzNOakoyTzMz?= =?utf-8?B?aXBadVNBWEpvVWdNODhvTllEb0htc2Nvc1ZYNXIyVG5tV1FBeXBiQ1FwdTc4?= =?utf-8?B?SjZSTHVUaUREbWpzM2VyYVFUcTI0Zm5hc09KR05lT2JuK3RRaHk4MjBuR0Fm?= =?utf-8?B?b0hmSjNXQVJqNEk3R0p6Sm9kV1RiNGdCUEZkN0VzVldCakQ3YnZaMjZ5TWJM?= =?utf-8?B?di8ycnF4b0h0WWx6QkxjWWJzUmN2QzcrbTVzOHlpTVM0Ym14S294c0VvK2FC?= =?utf-8?B?QjdSenZDOFNWL1llcFhkSjk5ckhESlpXYVVScHBMRmw3VkpWZlluUitYTW4v?= =?utf-8?B?Z1cvVklWdmk5eDJyZ3E4WE54OGF0eU9wR000NW1DcDRiNEZtSU80bEQwV04y?= =?utf-8?B?c1kzVzBDZG1JcDQ5eHNWSzhHSkhrL1ZNRU5OWGFyMnVORUpMRTZsNDFBY3Js?= =?utf-8?B?NTUxKzFrUWtzaWU1SElBdk1jM3N3a2F6cUlJMEZ5dFRUUnZJTlUwNk90dTVG?= =?utf-8?B?MXNGUXpYZFFTc0pEQ3dHcXkveEh4ZWRkc2RBM3BrNDZBM1VXVWhLSUNOMkZO?= =?utf-8?B?L010NkJXbU1EazdMWWlOS2FCbDBKeG1ydFJYSUxzT2tDeE5jTE12N05ZaWNT?= =?utf-8?B?ZHh2c3p0OXZ5bHRVKzNIS3dLMGV4VFBEbTBRRVcyYWdoUGgwZXpqTlpxQUlC?= =?utf-8?B?NXdZbWdvbWM4aXBDeVBjcVV0UTdVRTB0QjJ5aWZ3Z0gxMXNmVmhTdzU4REgz?= =?utf-8?B?dE5HNU40RzFOVjNoUEtmQnVQaG11Vmx0K1IrTE5QajNmbW5YdCtiaDdSVHhs?= =?utf-8?B?N1JsMC94eVgvWXF0Mm1LelNkSnExVkVFeS9IRVFGZ2l0ZEJPa3hGZDBGZkNL?= =?utf-8?B?ZHBhd3ZaT24xanVlOHEweUJIWGgyOG9VSGJjQjYvcEQxMFZuUWZMd1F2WDhX?= =?utf-8?B?dTkzZGF3Tk9xSzl6SnQrQVN5VHMwWXlxVGpIeWhKUTRrSDlwakorT280bUw1?= =?utf-8?B?UVNKZG55TEN5TWFGMUVMV00ydnk0b2FmQ20zWUFCOTRFUEFrYWtOQ0R3MCt1?= =?utf-8?B?YUVQbmkwTGkrK2FlV2daOWczamc5SjFidEdhbXgzNlRSaHdxM2hOaVUzOWZK?= =?utf-8?B?SUlBOEp5ZW02VDRlanAzelpCK0tPcXBVV1lOanRuWEhrK0JuL3BkcUFmV2JR?= =?utf-8?B?U1RSMHhSQjF1Tk5Wd3JIdjRvR1NMSkhnbVlGQUNRaFc5aC9Xd1NNSDdPUDhD?= =?utf-8?B?UmVnVFpkMDRJRzB1cTJBRGVRUGRKaEgyRFR0Uk5wUnkvajQ5SVZDVE1yVUc4?= =?utf-8?B?NHFaeXBSWnFCWUFHdElpbHlTeG9qeW9YVFVzRitLb1ZiR3hGSGg3NDRzWG5k?= =?utf-8?B?bzZHaHQ0U05aVm5XT0Fjb3htdGtBRlp6eW1VVGxwbDhCRXVsK0VEUU0rLzVR?= =?utf-8?B?STF3a1NFSENkWGc0eXBlS3J2MUlJNjNOWWtvVUdvZzhMUUc5WkwrbStkV2ZE?= =?utf-8?B?V0FJMWdlNjkxVCt0RHFLcXM2QnduOGFjS2o1RVJnQ1A0clpTUmR5cUxMSkRV?= =?utf-8?B?K09RNkcvMXFCZ01JOFdqeXZ2Z09FdmlUVVZHUTRsdlM4Qm5xNmFmek9WTDlq?= =?utf-8?B?V3lDQjY1QjdQSnJueVNWYUZ0UWhCQU1DaEZUeWhjNUFuU2VWNW1LR3dNelha?= =?utf-8?B?OFRNeHBaNXdmNGFYKzMyNFBxMHVtQlZOeE9hVjNEZTNmY3R1U3ZQUDcvTjNt?= =?utf-8?B?QUFjV1BKWGdNZksxNndPaS8yOTZtNWIxVnhLUUc0UzdYeG1rbFlzRFpYZG1D?= =?utf-8?B?UVdMM09jdGlHKzhVeW9SQVlOeXJjVCsrSitkS1JWbG52bnlweXROR3p2Nzk0?= =?utf-8?B?UFhpNG1WVm5yU08reGpzMlB3a3pkVTZseEZma3lpS3RwL0dkbnRtaE1BNDFo?= =?utf-8?B?VnJZUHN1VlU4WUN4VFlNSzRLcjc0dlJLbENSUkRKNGlQeUV4NGpnUno4TEps?= =?utf-8?Q?a/lU0NGkgq7DMxKN/fUU+S1T2?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 049105d3-9bc2-4823-e063-08da6f206880 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:03:41.0353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Dx3lNN++gmLy3rVh0U249Lzw5bt6EjBSZrPUUKocUSY8Xu9lt1kVSRXU70SfWbySKxOtNQMvr/ICgpP0GTnC/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7532 As of 8cc5036bc385 ("x86/pv: Fix ABAC cmpxchg() race in _get_page_type()") this no longer needs passing separately - the type can now be read from struct page_info, as the call now happens after its writing. While there also constify the 2nd parameter. Signed-off-by: Jan Beulich --- a/xen/arch/x86/include/asm/shadow.h +++ b/xen/arch/x86/include/asm/shadow.h @@ -84,8 +84,8 @@ void shadow_final_teardown(struct domain void sh_remove_shadows(struct domain *d, mfn_t gmfn, int fast, int all); /* Adjust shadows ready for a guest page to change its type. */ -void shadow_prepare_page_type_change(struct domain *d, struct page_info *page, - unsigned long new_type); +void shadow_prepare_page_type_change(struct domain *d, + const struct page_info *page); /* Discard _all_ mappings from the domain's shadows. */ void shadow_blow_tables_per_domain(struct domain *d); @@ -113,8 +113,7 @@ static inline void sh_remove_shadows(str int fast, int all) {} static inline void shadow_prepare_page_type_change(struct domain *d, - struct page_info *page, - unsigned long new_type) {} + const struct page_info *page) {} static inline void shadow_blow_tables_per_domain(struct domain *d) {} --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3018,7 +3018,7 @@ static int _get_page_type(struct page_in struct domain *d = page_get_owner(page); if ( d && shadow_mode_enabled(d) ) - shadow_prepare_page_type_change(d, page, type); + shadow_prepare_page_type_change(d, page); if ( (x & PGT_type_mask) != type ) { --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2265,8 +2265,8 @@ void sh_remove_shadows(struct domain *d, paging_unlock(d); } -void shadow_prepare_page_type_change(struct domain *d, struct page_info *page, - unsigned long new_type) +void shadow_prepare_page_type_change(struct domain *d, + const struct page_info *page) { if ( !(page->count_info & PGC_page_table) ) return; @@ -2278,7 +2278,7 @@ void shadow_prepare_page_type_change(str * pages are allowed to become writeable. */ if ( (page->shadow_flags & SHF_oos_may_write) && - new_type == PGT_writable_page ) + (page->u.inuse.type_info & PGT_type_mask) == PGT_writable_page ) return; #endif From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:04:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:04:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375498.607922 (Exim 4.92) (envelope-from ) id 1oGN2l-0004ro-18; Tue, 26 Jul 2022 16:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375498.607922; Tue, 26 Jul 2022 16:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN2k-0004rh-Uf; Tue, 26 Jul 2022 16:04:22 +0000 Received: by outflank-mailman (input) for mailman id 375498; Tue, 26 Jul 2022 16:04:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN2k-0004qN-5c for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:04:22 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9c332135-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:04:21 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7532.eurprd04.prod.outlook.com (2603:10a6:10:207::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:04:20 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:04:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9c332135-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ILxcUxJLb7q9yy1y5PRcRAIVslwpqfmSuIL82NVIb+nxzvFTOWy96TWhcL9gxtLE1C4Rg0X1fBOjk1C247J/R2nDegcPakx1HqE06PIBKSAdjG69n0enhms3AqnlmH40Ag9FPP/sZA3n7H+OwGShBNJQ7qIAKp0X4xpc8m7AgbVkqeMxcJg+SdM2niendm78S5KrACvCT95lUE93s71esZPhF8UVLHwEFrmREl5UTh42UK4JeUkin3wGXsHcyEBE8d0OQQ8t15bnsZq+jzfTOY91qW4bcpyeEsyrabA+6kzsQDmYS/83Mj6n3P+XcPi+dXriujYWus9LF5AQGFYBNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zrAeJ+7JwL3BaEmhi04AyXYTC/yrxXIxXKPGzKWit1k=; b=JaE4PxB/feSaTEZa8MSQRCrS9wwef6BETjInWBg1M0Q+9/moESrHdqLYDZ8OGzrQehAeXgTJraA4plylB1qtsFyf5WTN/XTGBdOXeCYKy0dKU03cu/Vt426t7hXgC7GerfBssu9EgZEuZUxfqVlU8/HyjAsY/DQxqSfqrjt2C0mTLFkNLnQgjdYHmjRSY8qNOgCvr8SuqC3UVC2+O3K0PsjidVimG5e+aSsrsLQVwwcS/K2p4haoPwg5WE89yBZYeAlk1AHQkT7urzA4N5OOuUXO1yo2AVNXA/UkwvgMBtrInKovb0uYdRiVeFckqqx0XQLOWF7MZf+iPGCLGaGvyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zrAeJ+7JwL3BaEmhi04AyXYTC/yrxXIxXKPGzKWit1k=; b=2hO1q4da9PgrGJOKCsrZvH5I8ssBkjwnzGbrYYtY6wr6x3hT/wzWlocQZpA3ZBjM+vbg8aHF6Gt7+Tl0VvrLWVNUdLIbS2+wu0mRNRtVfPjznFp+C9kq3n5Yn9ow/w+Onmd6aYnkkrbOVHDpPkVuV2ajilFQ4icBcp6lhpRxvxIN752512GaV3WnPqh+DdhI3x2xFN8+9aQ9/bRN8EI7vzeqc3EHxFaTUlzVDWgRwklnTTiodUIE2skTIVkqKlCyWTbBOND+0THc22CDRlmDAQK9x4vdHi97q4S1W5xstV51LE7gCPV6E+iUpnGBjF5ZvU9aR2H0bk1keYv80qXa5g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 18:04:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 2/8] x86/shadow: properly handle get_page() failing Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0188.eurprd06.prod.outlook.com (2603:10a6:20b:45d::15) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a961b870-8995-478a-3513-08da6f207fc4 X-MS-TrafficTypeDiagnostic: DBBPR04MB7532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: e8qw2uv5ETEeFEMU8WfBMkRIPCFz4G2LadShFmtgnQ+gvYXn7z6/bp7uMkpbke25qc0IRkY3i96nLLGlevJUl6mG87uRxwvXykn37kDhfleLkhLF4FvwEMuVb1DE2HFt1H/W/JEWeQENIxdLwsJk7qoVBVDT89d9NdaGWobaHtteEDrGAA7kDZwhqsG0t43xEc3OVg6wLEOxnm758zGa9acasBJf05mJjcpYcZn5b6kpp5KQzX9tKukHA78EvfajgZlS++ux2EMAGMDC5l0xL3W8+9g2J9smafwr5+0g+1DhoWbDZtgGpPhTO4zpS6yc/d/OrNZsA8QD0elXbwuxMOzEowQ4H9dvQJZ4/z1cOpP/q2SafihTwWsWpuhisK1xYXPOMpo3Lf+mfErjTnFO8Q/MGgqAPRd1cWqFBa/cjvgEmTRnIoz9vhBXJ/ls6rXORBGEAUyzHNen5liDWs6ReFY90ZRQIwEJZk0wOGOgrLvuZXRElaf0kC/lCzVm7gzh8jJuuVTq8HBalljrd5fhoCO+bwad0oXzI24iKt8gX3ozxoEPwei9pfbtnB7K/ujPyhlAf9qI0N5zuYznrNMzvK1T4QxRRyavjG/7lskmmJsjhIDXwFTdeS2H5SXVUVkrHj1MvFsspIGuyb2yvpo9urM7l38Uhptdmy6KZ66QtqFiwLLuyaavZUrNnesZCWUEz+YC3YchaAYVqW1USoB97TxfDBfl1VcmfVPBIa1RhnJjZzNNMMgJACk22JJEX/QKKooYp4TWo+dwFjVsxYtZC9QlmOtokJbt8jxdRw4VJQhdQG/5fWgEyKcQDWbvn1HxfBRFOgYT98DEjF8aNvAwWg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(316002)(8936002)(83380400001)(38100700002)(2906002)(36756003)(41300700001)(31686004)(6486002)(5660300002)(478600001)(6916009)(26005)(6512007)(54906003)(31696002)(66556008)(8676002)(66476007)(4326008)(86362001)(66946007)(186003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWNFdlNrZElPZXRzeVNoMXQ4MjVjczFYdnM5d05GRC9kaExMUExReThWVng4?= =?utf-8?B?S3RvM0RoMTkxZnZsSnY1R1RQcWlVaGJiUE5saVhORTBqUTRUWWZucFJYT21V?= =?utf-8?B?WWM1SnNyWHBidFd0cCswSHhrUU9tK3RZUHVkUnM2bTRURHlBRWZ4c3Arb3Ev?= =?utf-8?B?NDhCUmo1RXNXZ2M1RWRPTlFDNi9CenlWYUovRWgzTWFqdkh5d3JTUkcvVXAw?= =?utf-8?B?RW1iMnU3V0VQWDZFUXFIMGhIcHFZMlREMCtRajRKRjZNc094Nnk0ajBpWmhO?= =?utf-8?B?L0lKdTVzM0UrQTJQNVUyRlROYzROYlFIY1ZNMDk4dFoyLzNtU0xXUFBlQ0o2?= =?utf-8?B?ay9mTEpnY3dzQjNWZFNrT25vanpBTWpyWlY3UEFvK2huelkxdGt5Q3htaXJ4?= =?utf-8?B?RnUwQm55eWJJa00rZXV6SGJCUWVLdVBpa1FHSlBnRm9jeEo1WWNLQXlHRk0z?= =?utf-8?B?TGZ1aUdRUExDQWhhVlhtMVJXcWw3cGZKRUdDUEhFMUtjM0tPNktTQTcwZzd2?= =?utf-8?B?NEh6VHM3RnByamhpcjV1SHVYQVhmUHdyeWpvVjkvZHR6QzlLaWh0ZnFibity?= =?utf-8?B?VWhoTVBhTVBadjNFL3gzOHhKLy9QWXNTY2hySXpURnNTWjE2ZlJ5dHdkcEJQ?= =?utf-8?B?dkxNMHByQ1ltaFdtY0UvMFI2VlNzSHlGMEl6SUx2SU1aUnRhMVEyWk9jSVlv?= =?utf-8?B?K2NWUjVURVJmTE5zOWF2RktCRjQxZkhpYVZxM2ZhSEZOOTZBY3Rad0VITkdv?= =?utf-8?B?SC9zM3hhcEhsdWtuNDhCbHNQejRkblc1cU5oOHp3RVZHc216UXZuQ1drcjUz?= =?utf-8?B?dTc1ajdCNk9ZaW5Wd0dWWE5TRDJOcXB2YS8ySHFzSlhrYkVJSnlJQTF4SXJv?= =?utf-8?B?MWkyYWR3Qm5QckViUVliOXN1b3hDaHFtbkFuU21EdklNQVJHTFN0b09jNWo1?= =?utf-8?B?WlNuZEZBVklkK0x2ZE1qdWhzU0s0cm9FeWVqU2VYMi9qeHUrNlpzc1RHTXlP?= =?utf-8?B?eFJoSGNhNTlwT1BDZXhvTm9TR1A0TlNxR29HanQ5Y3hoUWFNRytRWHliRG1S?= =?utf-8?B?OEs4bExaaThxY0g4UDRXdDJ5eFNEWkVjMXNuVzBHVWlhMWhoUzFWbUtEakVh?= =?utf-8?B?S3ZUbHlsU1Z0U1oxbnhLSlk5WXVBL28rQ1Z0emhtVnFnTlBnYVh2QWdJa0NK?= =?utf-8?B?aFdKSE9xT3NRQlFZRzkyUjRyZDlsS2x0MTR2RjdjU1JqN0RYQW5xekZwVFQz?= =?utf-8?B?MkhZOVVKQWpoVkJlMFdQUlBFNi82OXBMWUpMOVNudTlGSEpEWHFlUG51SmRj?= =?utf-8?B?WWUwdG9oazRIQVB1cFE4SXBuMVVJaTB4ck9jMkJvbko5QnJMRTh0M2xCejhY?= =?utf-8?B?aHEwMjZiTTN5Q3hpbU1hcjcvU3h2OHFzU1ZIbUZTc2Uvc3o0VkJPVkhsNGxj?= =?utf-8?B?M25ybXBLRVpFOFN6VTY3SDdxWlRaN3B1R3h4ZlVxN0RUblVVMSs0UnY1TExP?= =?utf-8?B?b3MvbE0yemtRV25pVTBKQW96QTZaWnhaQjZ3VEhSUUJHcm84enZxc2FyUWxk?= =?utf-8?B?bW5XVjFtcFdkTVNIYzg2REswekhadWhEVXhuNmVwVWJNMjNHdWxlQWFjVE1r?= =?utf-8?B?SWh0S0RxWVZtUVFrbm5HTTlwQVp3blk5a0N2WW1GblNTeHdPRkxJd1MxbHB5?= =?utf-8?B?Z0Y3V1B3NUtjdEtRN3F2aTVHT3ljQTd5NlJVdHRSYzhiT3NvRVI3a3QwWHZz?= =?utf-8?B?OGFBN21uM1B3cUdxRldzRG5LcGhIS3Y2MXlXZEg5SDhFVjRnZTdJaXpMOSs5?= =?utf-8?B?Y1NWVVBXbGc1WlBwMSszQnhhNENyTnhzTUtNd1J1VVF2SFg3LzlYVWN3M2Uy?= =?utf-8?B?VjRIUHV0QTYxTHdiU3lXeXdNRUwyTXhTRVhGbi8yOUo5dm1hL0Nwc1ZQdTNS?= =?utf-8?B?UHV2RkpXdW5HRU0rbDdwa1ZRZ0tsdWdETG9PY3NmbVh3R01jUHozdzBNK0M5?= =?utf-8?B?RnVRS05mbTIrZld4N1BiWmFhNnFDOU52Z250QThtM3plR2U3dG5kQkNJa1lQ?= =?utf-8?B?cWlOeFN0RjRtclFmWTMyUlhEVnZ3RGIxa0J4ajJvSzN4dks0NHFXRTRmbkdE?= =?utf-8?Q?hyn0ca5/7Kq6oEn5o4ZTEN9Yz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a961b870-8995-478a-3513-08da6f207fc4 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:04:20.0485 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JO9FxrYO8nc0Okp9G8Xi5sRPolurkK9QHd0xYEfbgxPPScWEgcbwTyCxia7U9U+NKxF6lqZbvLBnv4xpYFPlXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7532 We should not blindly (in a release build) insert the new entry in the hash if a reference to the guest page cannot be obtained, or else an excess reference would be put when removing the hash entry again. Crash the domain in that case instead. The sole caller doesn't further care about the state of the guest page: All it does is return the corresponding shadow page (which was obtained successfully before) to its caller. To compensate we further need to adjust hash removal: Since the shadow page already has had its backlink set, domain cleanup code would try to destroy the shadow, and hence still cause a put_page() without corresponding get_page(). Leverage that the failed get_page() leads to no hash insertion, making shadow_hash_delete() no longer assume it will find the requested entry. Instead return back whether the entry was found. This way delete_shadow_status() can avoid calling put_page() in the problem scenario. For the other caller of shadow_hash_delete() simply reinstate the otherwise dropped assertion at the call site. While touching the conditionals in {set,delete}_shadow_status() anyway, also switch around their two pre-existing parts, to have the cheap one first (frequently allowing to avoid evaluation of the expensive - due to evaluate_nospec() - one altogether). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1581,7 +1581,7 @@ void shadow_hash_insert(struct domain *d sh_hash_audit_bucket(d, key); } -void shadow_hash_delete(struct domain *d, unsigned long n, unsigned int t, +bool shadow_hash_delete(struct domain *d, unsigned long n, unsigned int t, mfn_t smfn) /* Excise the mapping (n,t)->smfn from the hash table */ { @@ -1606,10 +1606,8 @@ void shadow_hash_delete(struct domain *d { /* Need to search for the one we want */ x = d->arch.paging.shadow.hash_table[key]; - while ( 1 ) + while ( x ) { - ASSERT(x); /* We can't have hit the end, since our target is - * still in the chain somehwere... */ if ( next_shadow(x) == sp ) { x->next_shadow = sp->next_shadow; @@ -1617,10 +1615,14 @@ void shadow_hash_delete(struct domain *d } x = next_shadow(x); } + if ( !x ) + return false; } set_next_shadow(sp, NULL); sh_hash_audit_bucket(d, key); + + return true; } typedef int (*hash_vcpu_callback_t)(struct vcpu *v, mfn_t smfn, mfn_t other_mfn); --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -132,7 +132,8 @@ delete_fl1_shadow_status(struct domain * SHADOW_PRINTK("gfn=%"SH_PRI_gfn", type=%08x, smfn=%"PRI_mfn"\n", gfn_x(gfn), SH_type_fl1_shadow, mfn_x(smfn)); ASSERT(mfn_to_page(smfn)->u.sh.head); - shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn); + if ( !shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn) ) + ASSERT_UNREACHABLE(); } --- a/xen/arch/x86/mm/shadow/private.h +++ b/xen/arch/x86/mm/shadow/private.h @@ -375,7 +375,7 @@ shadow_size(unsigned int shadow_type) mfn_t shadow_hash_lookup(struct domain *d, unsigned long n, unsigned int t); void shadow_hash_insert(struct domain *d, unsigned long n, unsigned int t, mfn_t smfn); -void shadow_hash_delete(struct domain *d, +bool shadow_hash_delete(struct domain *d, unsigned long n, unsigned int t, mfn_t smfn); /* shadow promotion */ @@ -773,18 +773,19 @@ static inline void set_shadow_status(struct domain *d, mfn_t gmfn, u32 shadow_type, mfn_t smfn) /* Put a shadow into the hash table */ { - int res; - SHADOW_PRINTK("d%d gmfn=%lx, type=%08x, smfn=%lx\n", d->domain_id, mfn_x(gmfn), shadow_type, mfn_x(smfn)); ASSERT(mfn_to_page(smfn)->u.sh.head); /* 32-bit PV guests don't own their l4 pages so can't get_page them */ - if ( !is_pv_32bit_domain(d) || shadow_type != SH_type_l4_64_shadow ) + if ( (shadow_type != SH_type_l4_64_shadow || !is_pv_32bit_domain(d)) && + !get_page(mfn_to_page(gmfn), d) ) { - res = get_page(mfn_to_page(gmfn), d); - ASSERT(res == 1); + printk(XENLOG_G_ERR "%pd: cannot get page for MFN %" PRI_mfn "\n", + d, mfn_x(gmfn)); + domain_crash(d); + return; } shadow_hash_insert(d, mfn_x(gmfn), shadow_type, smfn); @@ -797,9 +798,9 @@ delete_shadow_status(struct domain *d, m SHADOW_PRINTK("d%d gmfn=%"PRI_mfn", type=%08x, smfn=%"PRI_mfn"\n", d->domain_id, mfn_x(gmfn), shadow_type, mfn_x(smfn)); ASSERT(mfn_to_page(smfn)->u.sh.head); - shadow_hash_delete(d, mfn_x(gmfn), shadow_type, smfn); - /* 32-bit PV guests don't own their l4 pages; see set_shadow_status */ - if ( !is_pv_32bit_domain(d) || shadow_type != SH_type_l4_64_shadow ) + if ( shadow_hash_delete(d, mfn_x(gmfn), shadow_type, smfn) && + /* 32-bit PV guests don't own their l4 pages; see set_shadow_status */ + (shadow_type != SH_type_l4_64_shadow || !is_pv_32bit_domain(d)) ) put_page(mfn_to_page(gmfn)); } From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:04:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:04:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375505.607934 (Exim 4.92) (envelope-from ) id 1oGN3E-0005Pk-9w; Tue, 26 Jul 2022 16:04:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375505.607934; Tue, 26 Jul 2022 16:04:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN3E-0005Pd-6N; Tue, 26 Jul 2022 16:04:52 +0000 Received: by outflank-mailman (input) for mailman id 375505; Tue, 26 Jul 2022 16:04:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN3C-0004qN-RG for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:04:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2067.outbound.protection.outlook.com [40.107.22.67]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id acddf9ba-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:04:49 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7532.eurprd04.prod.outlook.com (2603:10a6:10:207::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:04:48 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:04:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: acddf9ba-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Emh5IvoUsjG/La8T6T1iozSiR/dDOjnEO4hxifz5fnilXmNZgZCQkM0/FyxgA0oGoiAei9ib26eS3rmJpn8lJQeym4Ebutp4BOfRps8KFKkh23USjbk/au7CJLSlc6ToeD8u8XimOtHRSTQ9iqeLu22VQS5ILK4kV6ZrXyn5n5zyQacG75yux6/a3BLd6dykXVTDhtlLKvbMrz9YCvmIUUXKb8SP3OCx2GJlXf/myz+iFTdAvH4bsJM7q2EB193WZFAcE8ganldHK+NTE5LiujkELnfZS4YYf4/ILEbx/vatd9CbIx75NkbVAJoCwbhMJ3955QtL6LAMRslJjGGFsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wpdBYL7DGs8sd5XkLM9xP2jAqMKLzNp/KEuELZbnd8A=; b=GhQy2IGPiYtRfhJNQrv+kNx+Uo55l0MoyFtmmw9aBlzLqDNQVNEIrGB4lpsfRV+NMZOVQitWofIyVDNoMQjDQzv2Z9evjzljvyTS/pYV6M0lgTjFDI/E/7Kmw/YHXyppge+qiHKQEV5xz4Ep/lR0Ctfd2DAXijzrAabz6+1zrnD4BYIW4kfGXExVulT5JteDI9KuXr7CRV2OEZHYwS0SVzMS4mSA3o6J0dvou7ywtRzPThgl9ZNMqq0ae2Svbpx2hOmUW2ikCpR9FJGe+41SDsQeNr4aJ03r1bQ8cfSIIF6Hu6oUPsG72Fk01HsMtZG6wih+eX1wipPAXNq7sHFDbA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wpdBYL7DGs8sd5XkLM9xP2jAqMKLzNp/KEuELZbnd8A=; b=lKcsJxSkbh4Z+awVEQv5uvkzGdVIL9YJdq+O6UNR181NPF3wcMR5pQrd9SS8Ww3KCuwyvOsRHNOAPkn79f+rCsNB3i7x8c+fz02LrRWLpPyCAjwYyEdgUW56+P6WZRX7gHinivbaY6IgwdWGaU2PAYha9OTYbYSH+t5efJhDlaa4yfwULDWwe9l3THTXwXM8JnOgBcIPWXqCHhLf6f35alb2EeiJnUWMloWx938ZJqDRrDc8/4gUGO0zQoM3+3ayzE3PK4+2SJW9//F2W8XTOeY4cOy87J9zafstx6Av2EL8SmiuOuy9yY9aFBlMpTKF31mBpHVOTWj/O2Q3KqJjqw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 18:04:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 3/8] mm: enforce return value checking on get_page() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR04CA0104.eurprd04.prod.outlook.com (2603:10a6:20b:50e::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6957a700-7d7a-480e-3d42-08da6f2090ab X-MS-TrafficTypeDiagnostic: DBBPR04MB7532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2gYGTyu7u//wFO9YVVleHJOi7fAi9QwGHGlNWnFqEAp6LzVwG37vDh/uvaUDio9yN7GjT7/6OK13VGWX/qJ5sJf0CivZfWbjffAS6uCkQtaZoMkNl/txIRUrDHLpd8G3XwPSIbVYojMlRORrRlbUp9gX9STW9L/hVb31A+tYRANqkc82U7tJUof2z3kpunZ/UFozcGWaqIFm+iZcdgbdVp/ayeC46DOmKrOaGTvhmPuSOioXVtye8d/W7oKbfiRNNdV6nbjq/wY5+On+kCya5Tbo9zyIgaeMdkA3IRsbvtbKEOXUpvs6d/f5mBzJW711BAVEmvBPhO8yXwOEsANftntyy5I66OXsUkgS63iDkdRSTMhF11oMVdiCpzl4/j8Zn16ZKIplEk/60so9Kt37ImDr8Xqn+QvkhrtLaXYKy5ca2ia5GeyuZ/BbxnHeNmUfkJvlzr1dT3wJ6csQvmDJZvLTS4YCL+sWm/YU7c2UuDU2K4alRbbC84AZekMIvNF6FvtbfNwMybvS/ARlfTxtE2DtTELs0XP0TgqbtrOi2U1eA2S3N1n4H0DFf76jt1eN2LR6QkW1PBbylyMt0uZ+MrYsizOentGvmmUKjhlpYV9lf8X0cQ4OXA8QEvBfPUBvqexWQ6RWyWNrCSAgrCGJ0DWzojUvKvWyqRRtXbqE04RDZJlAQBUiNn2oYzr/yN6HmPbLlEPFoPjD+bZHHoQrdXyxNlr6NWvZYL6+Ra1RByhd/OTCTZVZ5LuNEO1jLqG2kkOOgiL5fhdmZHkrNo32jJPgoQ8D1X65YgFwHQ2PRYCBQJWwLh7VdlynBdt3yaByDg6Dp9oLBLpCg04WuGjEEg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(316002)(8936002)(38100700002)(2906002)(4744005)(36756003)(41300700001)(31686004)(6486002)(5660300002)(478600001)(6916009)(26005)(6512007)(54906003)(31696002)(66556008)(8676002)(66476007)(4326008)(86362001)(66946007)(186003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WjR1ckQ4RXBhVVJHM1lkY1BrSnBURnRXRVVrc0hSSlB1dWRPdDN6Q0JnVitX?= =?utf-8?B?bk96OVZ0bGF2ZUhUaWhaRnFnSjRiV292VCtiL0QycHRvRDBYQ29xcU9Od2Jx?= =?utf-8?B?cEEyVWphSXJQb2wvSWFnVWloeE40RGJSc0ZKU3pTNVA1a2FHSDBrZTJpNmQx?= =?utf-8?B?M1lLajRzZDdjUGZaUlV3ajdsbGZTem4yQ1MzUTVUU1I3bm1MYU1RdDhGUU1K?= =?utf-8?B?YTJEZHFNaU41bVR5aklUSUNMN3hrU1BSbU1yb1NKbFpXM3VyUnZDeWdnL2s1?= =?utf-8?B?WWpFclZlNzAwSnNIa0hDQXEyZklFdXphbmNMd0xnWkNpRjEyODVRTFFnOVlj?= =?utf-8?B?Ry9vejQ4UkU1RUNHSzBzMlZqWXRvZnYycjFSOGNhRTJGNzJ5aHlKdVlXZzBx?= =?utf-8?B?M3pXSHlTVjZiVjJodXc2WGVRT3R2OXM3RS9xTUl1L0I0ay93TFFub0dxNjJQ?= =?utf-8?B?R0M0YUN6UEgwa05iaS92TWJpYzNzb2N0WGlrK1NkOUJuRjRqNjNORDExY20w?= =?utf-8?B?U1NibXBWMUtreFNKRGFJNUtTaFJkS3QzcmswMGtTSlNBQ3d6cThOTDVCa1lO?= =?utf-8?B?TENKYyt6d0VXL0pmYTJhQXBEaWVlNHhUVjNXZnVpajVEaVdQZFFKWXJ2eTJE?= =?utf-8?B?U015Z0o5aTNtMmJLRHMwZmZQVVVSVGxLRXFoc3o4enZvY3N6dFAySVE5ajd4?= =?utf-8?B?Q1hpelU3d2dHc3FNMmMyUDNPWXoyTTluQ2J4azArS1g2U1ppZDRxczErNDVQ?= =?utf-8?B?VVA4cnFjKzIvZFA3VUxHazhGa0hQd0ovcVFDMnJ6aUlDUlYrNnJMcWcyYUtZ?= =?utf-8?B?eEVqYkJzejlDY2hDVGNITVkzV2FXSnVJQjFoNklpTlJiNEVySXVSTnVxbGZU?= =?utf-8?B?MnJySXZJV0FQbm1BdTA0OGJsQ28rU0U4NzcvZVFyRFdyUi9yOVZWMER6OU15?= =?utf-8?B?Z3phM2M4dTI2QXRmV2Mxd1BHakM0VlRBR2E0SU1CUkhGaGFaK2I4K2h4OFpR?= =?utf-8?B?VVZHZWRhNFhmUnRMNlBOaDJxVkhmaDBMdHVQSG1sSnhDZXE5SXdTL3IvMjRp?= =?utf-8?B?R01ZdDhzRXlTT29XbDRpbjA1YXhjWDZpMTJQQ0NBK3B6OEJIdjMvd1hMY0wy?= =?utf-8?B?SHlVVGt6eTZzdk9MOWlvVDM1TWw4M1JFMFJrRk1QeEpxZ2tXS3NTc0s2TXRv?= =?utf-8?B?SDB1dXRlWUVjbUlXSkFOanVybWhxU2RxVGt1VEtUZEhBL3JZbU5PeWpyRENw?= =?utf-8?B?djNrMFJsWEJOaGhNcStxSlpwOEpXTVhTSElJK1Vjd0Y5dU5SejNDSmlzRFBn?= =?utf-8?B?cUZmNFFNTHdJTmNPUFh1Q1JDZHVkZmhJRzM1M0E4TzJUMThZRmw5c2hOVlMr?= =?utf-8?B?a0dkOTFTQS84c3A3Yjh4bUJOUTZGRWt0K3pVMkJkTTBoRkJFOVJrSGU1QWFX?= =?utf-8?B?RGxBSVYzamVwK25ieXMrLy9QTVJXUkpwUkQ1WWV3NVBkQzdvSUJuSGp4NmZU?= =?utf-8?B?M0hPYUdnRFN3ZHlXVjYyQzl4cm5LakhSbTNBd2VWd24xU3BraFExdit0dk1j?= =?utf-8?B?eGh6ZUpEV1NYY0RSdStvaFdGUThLbisxWUN5SmNGdVVveDVNMW5DaEtoakRC?= =?utf-8?B?M0prVjlSSkNDcVVRVGpUT0FiTlpSRzVnNWhZdVV1b3hzNnovL0lYbEpUL1Av?= =?utf-8?B?bTV3N00vU1c0citLclFvbnJPcGdWNnpOSHRpNmJCNFJqaDQrTjFtM2lBOG1m?= =?utf-8?B?NzNOcVRPbUNRa3orVUl1d0o1MmRJRGNXTTVRODFXMlRPNVJYb1RrTm9QSFdj?= =?utf-8?B?b2IzTzlaaUxEclBOUXNiTStRMFd0MVVKSHpiT3IwVzNRLzkxSDNhM29NelZr?= =?utf-8?B?K3VXY3lNUVNOZC9jZ25YTzJ1K055akFIOE5UdjMrL0Z6NStqa29iTnVNcmty?= =?utf-8?B?UWNyRmp6ZnMvWHp0NmlqdTd2czlxNDBNR3V6VEp6U3BXYnVhTW5QYkMxMGkx?= =?utf-8?B?a1lmYmZnQ04yR2xoTzJFOEt3T3hBQy9uT1hsWHlzYk9iS2c4dzhjM2xWTVF6?= =?utf-8?B?dkE4cEk2aytYK1FKOFBHK09wUHZRVFdmeDJ4U3RRVy96K0NGWmFiTStVbndY?= =?utf-8?Q?Sm+HfJ1Xg3djDNQ9ZBka3wJwi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6957a700-7d7a-480e-3d42-08da6f2090ab X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:04:48.4218 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fSvm2rAanrlQVrj0raNTWzGWKubM5EgVgM75YZ0S3eqrqEK/xjOoZ6eamcxnv4v4LiDsYMG9prw45fW+vcTdKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7532 It's hard to imagine a case where an error may legitimately be ignored here. It's bad enough that in at least one case (set_shadow_status()) the return value was checked only by way of ASSERT()ing. Signed-off-by: Jan Beulich --- a/xen/include/xen/mm.h +++ b/xen/include/xen/mm.h @@ -61,7 +61,7 @@ struct page_info; void put_page(struct page_info *); -bool get_page(struct page_info *, const struct domain *); +bool __must_check get_page(struct page_info *, const struct domain *); struct domain *__must_check page_get_owner_and_reference(struct page_info *); /* Boot-time allocator. Turns into generic allocator after bootstrap. */ From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:05:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:05:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375509.607945 (Exim 4.92) (envelope-from ) id 1oGN3i-0005zg-IK; Tue, 26 Jul 2022 16:05:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375509.607945; Tue, 26 Jul 2022 16:05:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN3i-0005zZ-FM; Tue, 26 Jul 2022 16:05:22 +0000 Received: by outflank-mailman (input) for mailman id 375509; Tue, 26 Jul 2022 16:05:21 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN3h-0005zG-Jo for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:05:21 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id bf7e644f-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:05:20 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7532.eurprd04.prod.outlook.com (2603:10a6:10:207::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:05:19 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:05:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bf7e644f-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fU5YvNEHqQNoOuJjEs+mMOo71ElNLgyJi/GwyLshbhKUcXohr6Spx4BewGX1c5mDfe0skvVVIyJ6tCnW7DNt3f1f2iXBjM7PkAPDgNtL5XmYnYIEDGUJEPpUz7xFENoVPS061rSJ0TRmOnMUe6hADh18LZsEj78FCB/fGurqMYUQtkm5lCxc4BZuVxHHyLCRmPMxW+RapinPpcg1rCq6J3VfX8sezXsFZEjQulUFsO2iRWZLO+9eZJVngeCkID1MzMSXSdWmgYIZ6c0MeMDl8Nq0Hjuftv/uXm/C5zKv4MfEwoZTizvGVWTEVdZAaPLNO4GhMTCdEM7HWIz/eAcp/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNV26NOfufeFyGjTdaxcVFoXazfc7X52s6BuntjbBgI=; b=Mm3mHhVvjuQjo90oBhYOf40r3acid5scgEX6jx2GfMzgycg2n2heHb0MOSRtYRJHvkeYWuMfhTFnkaNMkMB+xyXBc/geyNA7/gkzyDyvQlst9KIq3Fv7yPTsc0dtP5fCSLuBCN1WtaSl3SMM/JaFFrcQ3zTAHhFk1YRaOgO4KQl0CxlqlGnI5abxOZx+e7v1VvrPIq1aeJ3a9SwnQs9qegmh3OlN3ySqBBy5CoxLfvTsI6boxNjiid3oZW9135OX7uR+DhjsxaSJBCfbWS7sTm4nxCM4QJCyQf66EXRsTkk7wgCKVDHacbr6OEe6BI68aTNuzTHVcktt3wCALqnzQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vNV26NOfufeFyGjTdaxcVFoXazfc7X52s6BuntjbBgI=; b=LZVRVnvcQfYhCvisa4qFlBSJlTHwWP7zEyTIYuNGqEp0v12NpWnvYwUobRzOvUSloJoLZd1rwClWVYVoHmdPc6eajpIArkHtWfpLJMGiUPfhVqgwAWFM4kRqZwq/gOcknhX7iuy7PMZ7MdGH2oFsj7DB4MrZ5oZxyOGvdGOqpfINK3oG/jWU7X1Jz7Gx4iZrKetPa0C3zsXA45uzAw0t9DqRaGyennIa2aTlir7RkQIg37WvGeRPPW2Czx2EBbILgKsEsn1P206zibUJ7CistZ+3rw1v8WE55+XyklnroAOJaXuhVFW3G46Svbilvae5V/4wZUrBUlddEZ3MznZJrg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <75dd380e-5dab-8d19-b9da-b59188bc4997@suse.com> Date: Tue, 26 Jul 2022 18:05:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0108.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::8) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 504a1d27-1975-47eb-f324-08da6f20a30a X-MS-TrafficTypeDiagnostic: DBBPR04MB7532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mvF2OrRIAG55LmR7cH/h5/AnxvuNQSOWST55yuaOhiLeGl/OO0WrheiEE+ck+Ce7VzKJWSP6Un/N1CGUe85OyRjP3u+STSAPhfilJ6GxWLIg8R0tQza1u8Mh+6QGUx10UHWuw7rE+vqKz81+4O5PcwPWMc9tfMk6l2/5tzYmAKa05Qt0ns/yLrtnC4elXg44O2eEJ1tAyU+VIfLuqG1SSmHZ5LfrARL4KpisQepj5BXuisG743p+TzKOAp2wx3hF8m0K/t5pZW7hanKdBOjpZCi/ynqgb5DVaVMeT/eIzrQ5gWtgFbY0M7uIwVFNRrTH6ahShUPp+mlugnd1qmEHI/xe8njtyOEGjgqzcksGY8HbwS4tEalb2rYtTJXgAO8rDhDp+dCjbfo7PoYipnB6z1bCcSNdIjEfoMquqlRCENAkjTMjQJXmKNtphtrb+TBJnbObF5MvzyyDFo607bSj/TlBcwJn5WlL+rL1r27XHHK4oPYQ/W+RbbzdP+2ZvUJ7gPZuunrdFlqFVXL2g8Hgi12CnUPKgFCTwr+SiGKwPouxrVPQhD5+AkzenzNFVUJQoTeHcqokfRKEzM33KT1uKyxWdUZGKRN1IwlH31Chp/azUxZs6QLGmUtsD2gKAgN2C5NPjKhtz58TP2Q8uSxSo+eXbaW3DDayiZWyo6T9I66E+5qsfDlgrZ1fpgA4/9Q4kP93wgpehXLitVG8OqCPCMrCipQoZyGnxmIXkVRD6AePJLbReeW+bpCsn88840Zz4i2nffZNbuzvxgeVDeFz4RDouVv9Q4FXY+WjQvYRLB3NNYSwdhDuSMo6OIYTOsuwr35P0wQx229F99n7ArWeYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(316002)(8936002)(38100700002)(2906002)(4744005)(36756003)(41300700001)(31686004)(6486002)(5660300002)(478600001)(6916009)(26005)(6512007)(54906003)(31696002)(66556008)(8676002)(66476007)(4326008)(86362001)(66946007)(186003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wko0dUdoOGg3bmxUeFdGV0cxZmZHZnMwKzBNOThERWwxZSs3UENxQmFOV0gr?= =?utf-8?B?ZVVpS0Z1TDRpcjZEOVpLWmUvY3NYSDhaWnordWZ3SjBqV0FwK2g1NDJHQXZj?= =?utf-8?B?OEN6TVRKelFyZ2EzV3AySmxlMUJoYWJqdWlJRS9MWU9SOW5VdVpYcko5VGJi?= =?utf-8?B?UXBYbFRLei9DcEViejFnWjMxTm9mWnYrTlVOMk9XSDBSREw1K3pyVlNYZWVE?= =?utf-8?B?amFiR1hvZVlsSDFYOW9kV3FBQ0JVdkFwSTJBK1ZlaVRsb1JKWU9VRHA5VUw4?= =?utf-8?B?N2ZSdXhKcThQNER2VFp6QktCSjJkUjJVT1ZxZkVvUjdadjNQTDRPOEZpUFNG?= =?utf-8?B?SW5TaGYvUGhId0o5enJiWmdET1hOWVhKak5YNzhBQVFpQkZIa1V1WWhoMXlx?= =?utf-8?B?ZHIrUy9kTy9QMnVud0t1c0tzbFFkek52TjhteGs3T3pqaFllVGdZK0VDMEhT?= =?utf-8?B?Z3JjbytBcC9OQkdvNEU5MEVib1NDMmE3RTRVZTBJeWp5dDlTSWxSMktDWWxh?= =?utf-8?B?TE9KU2pMV1Y4MTZud0hJdW9oOGErVnZxa0hzWjE4VlpaM3lkOTZqcHBjN05O?= =?utf-8?B?SEM4Zkc3RzlhWHpENmJvVjd1Y2tFb3RuSHFTT054eFI4Szk2NkZzQ3ZtQVFT?= =?utf-8?B?czhkeWw2UXkzLzVJeWlsT0hacTRrcG92Ymlzb0tRWXRHUWF0bE9DaU9YTmQv?= =?utf-8?B?T3Y1UUE2VGZxTU1JalJ6dkkwZmJhS2RjcEU5T2cwVW10WEt2NklROWI3VG96?= =?utf-8?B?blZrc1hINkVRYXI5Njd6c1FTYk1Kai9sck9jMXBLZXZnMW5kZk1EK2dIcUFF?= =?utf-8?B?dWJ4N21xMVl1eFZkcjd3a1plMld4eFRmM0xmTndkdlN4Qi8ySnhOdmRtWU4w?= =?utf-8?B?RkRnemh5eks5amxMaTZHWERyUEJGYk5OcVJzS25IdjMxdnZKVTNkNTN4NTZM?= =?utf-8?B?dmt3bnQzdUZKaTdRNlhTcHg4UDN4S2pWc05GZzFrb1hvSFc2T2ljMDdhQjdD?= =?utf-8?B?MmhLTXZOalpBR2QvR3BHVTBtZWwwSXp3ckJBWG1Ld3pOb3d2eVJ3bnpLTEgw?= =?utf-8?B?dFpzdmU4aG90U1ZRZWpSTTM4VEQxYlJGb3prWG1MNjJWUnpjNjFIeG9xSDlp?= =?utf-8?B?cjhIZWhPOXhXRE1oUnZuNm1KeWorMTkwekNzUlFQcHIwTkpBckZVVnh2cVMv?= =?utf-8?B?Z2VicnYwNXZQR3VCNi9pcGY4QjMyR0xwQ2cvY1FheFZnVjNjYmNkWXR3ZW1o?= =?utf-8?B?WkpOeWZzaXhtV2RNV25samhOYi9TR0xsZ2NTc2VWTEVHZkZ3MU9lU2d1K2FQ?= =?utf-8?B?K1ArSlZwc0JocDMvV3hzc08vWjV5Qy81bVNZM000Nk1CZEVKKzVtcXBLZFVx?= =?utf-8?B?bUF5aXJYK0l2R3BTS3ZnR2hDS1ZsWVdncVQ1K05Zc0RmTFQxRXIxZmpGZ3hu?= =?utf-8?B?aU9YTkF5NVBqZzZOdDljOWF0RFlDWVhuUjhmZmRQb2VObEJiK0x4K3d2SEZT?= =?utf-8?B?WmNueUg0dStUanY3bW5HM01RWk41dCtTRVFPd0FnbjhQMDJHeWI3eWNhOEFq?= =?utf-8?B?YjZTU0dBYmkxamxFU0g4NEMxNmdsdDh3bUNQTThhZHFkVWcyR1RtZHE2NGdz?= =?utf-8?B?cEpuZjVWZmtUZnk3SU5naENNV2hqcks3T1diYUJLVGxYM1ZkVzVQdXBZckpz?= =?utf-8?B?amhqUXpXQ1BqRkNaN1NvTXJncUFCckxOcXBBRk9WRnZsTkFEZXVCMmIzVFhr?= =?utf-8?B?RkJiRWNpSUNvV3hiWUVEcThBMnhrZW5HSm5rcmU5UjYvVzVQNFdseWE5Z2FC?= =?utf-8?B?QjQ1VlN0NklGQmlqZEo5T1VpWmlab3VyeDAzamFzWXlSQmhvUlVNb1puOGRh?= =?utf-8?B?U0NTb2YxSDJvVGxOZmkwSjBHMjlMR3k1cm5obXdOa3BEUDB3MTFJak1XQ1JW?= =?utf-8?B?dVNGT1dtT3BvYjlsalZ0UCtHWS9iSFhTZ3IvZnNrdFB6bmdqM0JES0pZWkkv?= =?utf-8?B?YkJYNmc0SWRBRnp2Y3NaOHRtbmZnZUxSUzJQQWlMUjU2dGZkNFo3NXJURDFy?= =?utf-8?B?TnpKSStSUHNXY2wrUzk5UVVDelJldVcxbXBpUVZDdHZUajRnUFFTa3BjYjVE?= =?utf-8?Q?H6ZDJ/9bK3Z+uA/zXE70gCxY5?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 504a1d27-1975-47eb-f324-08da6f20a30a X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:05:19.2168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hWn/Ob8IMMiZoclI88lLaLwc5TnK22xzdab/7d0nLMNkZbv8jDcFJKCbDDpUnZIFUSr2gGF9U61rs6h47wNgTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7532 In my (debug) build this amounts to well over 500 bytes of dead code. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -2240,10 +2240,12 @@ void sh_remove_shadows(struct domain *d, } \ } while (0) +#ifdef CONFIG_HVM DO_UNSHADOW(SH_type_l2_32_shadow); DO_UNSHADOW(SH_type_l1_32_shadow); DO_UNSHADOW(SH_type_l2_pae_shadow); DO_UNSHADOW(SH_type_l1_pae_shadow); +#endif DO_UNSHADOW(SH_type_l4_64_shadow); DO_UNSHADOW(SH_type_l3_64_shadow); DO_UNSHADOW(SH_type_l2h_64_shadow); From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:05:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:05:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375516.607956 (Exim 4.92) (envelope-from ) id 1oGN4G-0006fc-10; Tue, 26 Jul 2022 16:05:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375516.607956; Tue, 26 Jul 2022 16:05:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN4F-0006fV-UD; Tue, 26 Jul 2022 16:05:55 +0000 Received: by outflank-mailman (input) for mailman id 375516; Tue, 26 Jul 2022 16:05:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN4E-0005zG-Bb for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:05:54 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2080.outbound.protection.outlook.com [40.107.21.80]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d3284579-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:05:53 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7532.eurprd04.prod.outlook.com (2603:10a6:10:207::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:05:50 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:05:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d3284579-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZWMypyfxcoStgzw3imPIRWUl04DLwak49WfhFmf6OOzQdpkR9ojZRlQwQAoKW6h+0rrHu5CMMkxjF0aYdEPzb5IgLO3iRs5DU2SHDJYAM5FxSEWHXC0eCl6L8zvBhdqnHf9TPeHol9ijFxMoZhokt1f5P5q0rpYRaMrZrakbGivVuJtzztMtFW+6RGyOcv7iZipYXkCvK7Hv4K8kPIFGgZ1eqavjHOxuvpSntOr9AmD5XfbxFZAglHrROOJJ0xaPBm3Np7JIDtJewQ0GG0NmUKXgs3hRdoNiQNN21E2SsItplJxhZs2UsiRzRxq3k23fgGdUgqGsXMdWcKiVPP4dKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PaVObIIKwSsNFmuQ6pXbbqRuzlKrtGx5TcJJvcCnz5M=; b=GmYDE6n/HAqG8k7JrqpWc5zhZjr9medaA/jWzhjRRUQAbJE4WPZUxg4muXXetm1ZomS8MzU2CvtwR8FGtqacoXTQPFzncbvxxjFb+5Jn5BXY0s3Br47N5C7+19mLaG75FqGoP2ai99Ctapdl5fOYcRmqyjr46WolgbRMET6/4HRSoKkQQnKqoknY0ZW9c8cqYjLcJm6bU4eUQjzmpdBi9aD/pu77d1sUIAFpahVo5WHd0XBu+zqRH4N3PydHs1ojK4CEoJJmynUN7bdwosiybHAqTdCpSPsOYX8Z8+CV/C97P2PqTgBFfKUFoRTdKdSV3GnFI/V+9XA9o+/H58qJjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PaVObIIKwSsNFmuQ6pXbbqRuzlKrtGx5TcJJvcCnz5M=; b=wNHNedfhu2VIgCiNYN7M3qfHRdksfhI8Bqo/QnK82DFFCo0aJ4QuHIeCpZ54euKK7b41P1MvT2r4S+K/LEltJf2uAJhqACumVLLu4JRckyz7g9XFiH4ETNB4uslyOsh7Me+0EmxyD3/W0xqLkMgv5AXcJjNcJnZLNb9SztJKb0350OstMAVRaIkm03VwJS8+pGimIYzN3ZU7XViX3KY1pvwxMay2gojb4gdy33+UarnynrXHmCA5u3s6j48Of7yWaHBu0EOEUYVLkZhiqm/4ckvQOS50Ao261jQr2XQGh2hpKvpkPaBMVzKwG2z+GAkTi0GYlFzcfmKua52FLN8U/Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9af0bb78-f419-b4f7-d20f-cd46a5073f01@suse.com> Date: Tue, 26 Jul 2022 18:05:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 5/8] x86/shadow: don't open-code shadow_remove_all_shadows() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0078.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1e::17) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e0ce0f70-cf2e-404a-2198-08da6f20b542 X-MS-TrafficTypeDiagnostic: DBBPR04MB7532:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wIeM2wE3Cy2H3m6E057OvXYEmamOmpyHYJPRSsl4T0KhhNlmiKBWX4EaCru6ZZRgJWIsr2//XPg7l9+eqEyau47CC4W4Iv9zEipOOE97hJWRCKzqO5iR680moEqk52hbb70YukAdzmhqmMZPaCnPXgkMuRFOItL/WG31K0/0YOGscF5/wb99hd8vaCu3Cp3o+xYM5SVOVeU0RcrWmNt40DnFmzyjhlkjzjSMRxEO4cC2RW9suSloQ5wGkJOFe9om8FKtyIXUTH6velI8KKS6EURuM5fxGbOIUcSz8M0hLOJLmOlFnlLsFDpf+NLgumKWN6JnbQDDExr7BI4PW1GDic7RkTGdOdEaItxgc0EFjJlIaEjaLDU/DJ+GPjnOW1B/jwKzLSu9GlMZnqMzuFANMyCv7UbEbC1ovxfUv11gnIOpmaZhnyp9nJjOeDNg0Ca4Zhc6qOS64dAFINAbKoSpCbCk1OwobZXlMdLFPXYvQm4K8M1y58OYfcDZYxsm1PN5Bq8T3EG2CLJpiw8k89a90b+EIQc3feGJbhS01Mh3ZtwrDnzoIcxwSyAmE2O1bNRMIlKSFinxnJcrT7LOHtA7oZZLxWiaeeAI9aT41IuJqNUxad3NDHRF3LcAU+p4fh6MtVoNSaiZcmrA0LJuZ8XqYGXJxpQdmShefNjEC8ohsTotB7OFYbp5lJiTt9CxjbtVo5AhsQQTpGD/dBbriYEKHysj07JKsIPzR5ubSTz5P9rbs9V7FQZozKxEqZ1V+swq0DO+8IISl1bOlGK4CTuqJJZkrxOycDIEcNznxSfsHix8ISZ9oLwxycbmADo4WuY4KR84EZMHfRhsqmu4S/l0/ZctZJsVkF8OPyJRf4kDesY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(346002)(376002)(136003)(39860400002)(2616005)(316002)(8936002)(83380400001)(38100700002)(2906002)(36756003)(41300700001)(31686004)(6486002)(5660300002)(478600001)(6916009)(26005)(6512007)(54906003)(31696002)(66556008)(8676002)(66476007)(4326008)(86362001)(66946007)(186003)(6506007)(21314003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y1prYnJCQlF6dGpVUU9LTitKWllLQTBtVnFaSjBXb3RMSUt5Wi90V0ZmOEJE?= =?utf-8?B?ME1KRFVzbFRrWDg3RDk5Z254VHJaclhicXh1OUYwRWNERU14L1QrcDB0Nk1R?= =?utf-8?B?MXpvY2V2NnVkRGxYRGZMRXhrL2pYSCtrOGlVdERaQlhoNnRmRiszNVd4amtK?= =?utf-8?B?SWZpNTQ4VFdCSStpaVFYUDdZNjF0VHlZQWNraGRJWThWeWxXY0pyVWJ6Sndk?= =?utf-8?B?TXQzdGJtaTBFa29sbjBQSlBEdVRCNy9XUmExZWhqTzJuek5IWHZLdS9oOEp2?= =?utf-8?B?MzZDOW9iL09vbGlUSjloeVBXdndCZGpMeUIxUHhYaGtDRDJRL2dUNXhZNjlG?= =?utf-8?B?WkoxN2tLRURoNW9QMFBHbnVvMDNpaEgwRmY0L0hzNXVwZWNiRW5JNnZGZDBO?= =?utf-8?B?U2VGK1VEY05ZeTRmb0sxMEFBblNNYnJLb2MzVFlEL1lkd1dPME1rTzZGMTJq?= =?utf-8?B?ZFdSc3p4NkZtMTRub2lyc1VYeUFjSHJzVlVtemdIQjV4TFUrRXRrMm5GS24v?= =?utf-8?B?WVIwaFYxd2VEYnlJSWIrc2FlWWpKTEplQlBNclIyTFhUdU83WTJCZUdmRVF5?= =?utf-8?B?SnhRV25TQ3hKRWJBZHlIMWswdmtBMVlpZDFURWpjTlNaSDVaYWRCc1RGT1I1?= =?utf-8?B?c1JNUkM4Y2hxYWphVDB5OFJCcVMrSGNsdFBFdGJTbWw3b2tGb1NVa2pndndO?= =?utf-8?B?blduNEludms4aXBCOElWZ2JHWE04Zlg3VjIwdzdMVFh5UEpqTGIvYzNudzV1?= =?utf-8?B?ZmlmYjJlT2VqMTFjQ3RmZ3dHYXZwVm1pSzU4UEgrMlpQcEp4cEpMMkcwN1RC?= =?utf-8?B?SUhFSHZ2dVA0Q3BHVHRCWkp1Z3hIblB3MkdOZkFpV290cFppa1JxZVc1V1J2?= =?utf-8?B?cUYxcUMwc1dOb2pZNFBoc1lpRENQSnRSRGRIcXozSVdmYWl2anZyS2VieDlU?= =?utf-8?B?WjNaL3RSM0s1dXM5ZWlJVmxqaWZRY1hqR3hRY1FaTE9CQXh0WWRjaHJGRnZs?= =?utf-8?B?NUtaTmdwT2tLV1N3WFlUaE5iUDVkUUd4OXExTjFmV1RVWUR6QXBoOUphZTlP?= =?utf-8?B?dzVMWlhPaklFYWk4Y2pST1A4d1FWYndRckpkSTFUT2JjZ25kdzRhT2c2ZHRR?= =?utf-8?B?cGVnN1N5MmFZT1ljQVlIei9iN3IxYnJSWmNieXRIbjYxOEs2VjJBeVovblM4?= =?utf-8?B?OFoxTms5dzBQOUhOUjU0OThPeDNtVFBaNTNnemlvcVIwdUJqRWNFVDVQSGNG?= =?utf-8?B?QWV1NXlpWGxFNi8vK1FFcjZzVGRrbTk4NllyQmFCYlltRkl4endrcjBxWGJK?= =?utf-8?B?TmtSNUdJT2xMam1KWEJYMExtSkFPK0VZQ3p6Rk11QnVsb2JHYXdTaTFRTkhr?= =?utf-8?B?VjJNMmNTMGdUNHpCSFJRWVJqaURxaUFVVnNEcFVTc2p5RDJhMm1meTRWdkxz?= =?utf-8?B?WC9jZGNnWStONDhpcExoQXE3TVVRekdZSUVJa2dFdmNYWW5DSHVoVGJRSW5E?= =?utf-8?B?eTNuSkxLVGxCcHZJWW94SUMyekVFQ0ZxWlIzVmRqem9ySnQ5cU1TZ3ZlUEEr?= =?utf-8?B?alFacTdSMm1yV2x3L285b3RCeTh2OS8wZ1NsUmFEQk9nZGQ3ZlIxbFVscHpB?= =?utf-8?B?SE0rdnFtcjdDTk1Wb2YvOUpzRTFYMGJKNzNTOXhDOFdXcEZLZFRXQml0UkN4?= =?utf-8?B?aVFSOWJ5MFFrcm5DNlNVbVdQK0FWT3NNTjljeThQSGNvZXpJM2EwZ2Q0ZmJG?= =?utf-8?B?RU5BMmhwUmtXVUh5c1BON3A4alFJY0M0M0NGMjVNeWJIbE1TL3lkTXN5RWlG?= =?utf-8?B?bHVYNUlMWWlqQUpROWV5UDFEbEcwclJaam5xQWtCS2hDU3VveEZBVnhJK3U5?= =?utf-8?B?dnVkeHEwSld3MkNkanVQWlZ4MEx1OU9IMUdDazhZYnE0UkNTZm5RSHl0TGRL?= =?utf-8?B?eWVucHF3MVl6cmNuMG9kTjUxMmw4MDRLb3E5S3BOQ1B3c1RxL2tuKy9GSlFZ?= =?utf-8?B?OGkxdkRhY1lzM0syQ2RzelozclZHUEF1VkpERi8xZ0IwMm1pMFRlelh4NHN1?= =?utf-8?B?MkQ2MHk4SitUZDFTQkNsZHFXVTZSSnJueVlSemM1QVdwL25hTUpaQkRUZ2Ev?= =?utf-8?Q?GB0ZkMn+91RK7joW+jdvkvmj3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e0ce0f70-cf2e-404a-2198-08da6f20b542 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:05:49.8086 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +kNMhtrAlHC6LL2HZETkkkWXu+mq7AuraTjF9Dk2R0Ysd39mebETulS0+ShpibKoIkCT6EcV8B5JVDU7H5NggQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7532 Let's use the existing inline wrapper instead of repeating respective commentary at every site. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -389,7 +389,7 @@ static int oos_remove_write_access(struc * the page. If that doesn't work either, the guest is granting * his pagetables and must be killed after all. * This will flush the tlb, so we can return with no worries. */ - sh_remove_shadows(d, gmfn, 0 /* Be thorough */, 1 /* Must succeed */); + shadow_remove_all_shadows(d, gmfn); return 1; } --- a/xen/arch/x86/mm/shadow/hvm.c +++ b/xen/arch/x86/mm/shadow/hvm.c @@ -783,7 +783,7 @@ sh_remove_all_shadows_and_parents(struct /* Even harsher: this is a HVM page that we thing is no longer a pagetable. * Unshadow it, and recursively unshadow pages that reference it. */ { - sh_remove_shadows(d, gmfn, 0, 1); + shadow_remove_all_shadows(d, gmfn); /* XXX TODO: * Rework this hashtable walker to return a linked-list of all * the shadows it modified, then do breadth-first recursion --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -2632,7 +2632,7 @@ static int cf_check sh_page_fault( SHADOW_PRINTK("user-mode fault to PT, unshadowing mfn %#lx\n", mfn_x(gmfn)); perfc_incr(shadow_fault_emulate_failed); - sh_remove_shadows(d, gmfn, 0 /* thorough */, 1 /* must succeed */); + shadow_remove_all_shadows(d, gmfn); trace_shadow_emulate_other(TRC_SHADOW_EMULATE_UNSHADOW_USER, va, gfn); goto done; @@ -2718,7 +2718,7 @@ static int cf_check sh_page_fault( v->arch.paging.last_write_emul_ok = 0; } #endif - sh_remove_shadows(d, gmfn, 0 /* thorough */, 1 /* must succeed */); + shadow_remove_all_shadows(d, gmfn); trace_shadow_emulate_other(TRC_SHADOW_EMULATE_UNSHADOW_EVTINJ, va, gfn); return EXCRET_fault_fixed; From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:06:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:06:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375522.607967 (Exim 4.92) (envelope-from ) id 1oGN4o-0007FD-9A; Tue, 26 Jul 2022 16:06:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375522.607967; Tue, 26 Jul 2022 16:06:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN4o-0007F6-6D; Tue, 26 Jul 2022 16:06:30 +0000 Received: by outflank-mailman (input) for mailman id 375522; Tue, 26 Jul 2022 16:06:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN4n-0005Nn-MR for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:06:29 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2046.outbound.protection.outlook.com [40.107.20.46]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e82a5372-0cfc-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 18:06:28 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7772.eurprd04.prod.outlook.com (2603:10a6:10:1e3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:06:26 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:06:26 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e82a5372-0cfc-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qz5cIIKurAc6jEq8H27vU6WZrLmn9Hs/L1M0bEHSRlUaEjDssZx8vFC7mRk7QA0e9WTbdcekJlua+ElCF6UJfElkfOWzNITFKHCkUgOy0fh3cQeW5CXgk8EQZRyHnphcqUvNsSw0hCHr2aywUVGYGNAr1SAEofQI02iCIIIfzVCiWo66km/maB1VO5jDHxzbqYWact2eGFcxk9S1x6w9pTLoz9dRg9CVRXr/8im5t4c5qlsby+odEv3aIAWX8lj82wSyEY5EcgAaFdztEW5oooLMQecBRYQhHYpkX9MAWnQB40lGbbsvwWIWQRdC1P+e6/IVWj4YFkR7bDdWiH++kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=td/gCrrRCkDZYLC/FRwdlmkxYPkOjvQqTnNypaVN5WA=; b=mNcrB+BlOKWKXGLQlNCKFc7rp4A22OqLxuyW/smUFzj23y8OgDJy0iDSnqY72lSUIFsM0inSYIctHRZUEPlUraFQKqx3aTNFsoMpAfPhg94SJ1O/cR4+DmChCSFAF17SsDEKZpovtbGVAaWD16xj51auMHnib6UcrKT1U/vUtnh/AC+cRgqbEWgFk3VrlLSYcq/+kzK1IyfQZhSpSMfbuCc0aK+YlbqTyky6iTpscHWOTOpqnYDp6ZQsO/X+yVbdNQhp+g/Y1rFcJGt0vhdFKiqsT3ls0zT2G0BPWI2vLRtsnAeY/QaJfn+ti4uzHjX5jVGszY3KAzpDj9dnW2Aqug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=td/gCrrRCkDZYLC/FRwdlmkxYPkOjvQqTnNypaVN5WA=; b=aqmYC09rv5pmdNxtTqvJMYsyOR/i4hyQRkN6pftRImbhrEE4sovkHRPD6CVYPEX67UQWI01rfkqUFm7r1dy3QrIppo0Wwp8h5gajrzWAZ2//jrzasVoYuL2j/ulmoR/pntVNam5Wnc3DuG1DhfyP6i5v1k6X1kKCn6RWHOsVZoI/Uv43jlMdgs/wPngw6oCmymjoHXHXd3KJ+CZWwehdhNIkL/y3Bn1EbWOB3KPC7O0g+knSo2AvkCa87BQ/GNdWhNajRfUB0KwZSvszp5GanOoHmubs+nAmsdwUcNl50xtrPxkyXDGfUqnSFxxjBKnFLjR6NQ385f2Zeb0DydK8Uw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <03ef104f-91a5-596b-235d-1a0fa47963e4@suse.com> Date: Tue, 26 Jul 2022 18:06:25 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 6/8] x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0116.eurprd04.prod.outlook.com (2603:10a6:20b:31e::31) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ffc06cc4-9299-47d2-b060-08da6f20cb56 X-MS-TrafficTypeDiagnostic: DBBPR04MB7772:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iMi6jD8qL98z1OcsJE7sUapntf9wQu073LVho5xTW9T6V/i1CuQw8h0AFWnbejIgbWgbjxKcZy4+k9jbykCGd2mNWvBgvzol9APfHb4HUOkoisE2yHb44SwkDTtPOCLLMg1o7apgCNPdUh2H3xD4xE/Ng5MOaqgwD1i68xI0KmMELyUtTPbn+qODwTd9dU6hc8Vz8ZX2MliFtjsj56yXwIKvDfGAJxtcnO2fWADvAV6vPg1WcBTCOm0DGcyfsCAsB5Rau20KKuxGRSxq/fEL652KhV29S1HY/OFCyXWGC7nKCVPOMpHUkyeOyJ/sJkJmRgdvRP8jsFFG8Hg2STa+AqRBYncikeIaGFOi49zW/jU50mFF7mYpX4kcY+NHU4slZ8CxOEMnool5emA24c+z970NvMg5Mg27gWLIzrdBunsOYYhyCN6Oo7GwbhukZBgbpv4HPiARD613MmKSgJ7RDhCXf4nff3tEpfi6XrzMLk1lxyXwVhtdRYCYtepQndxJOL8BclJG0gwPwLXgxeHvxlmXmxF0qFMQHiA1zhmi7EZC4zL52JxYJLq9nzcGt5Fycpc72tDdFhgDrBK6q095p68BErBKQf2I5SKbO9UsFwfp/WBbgpuW0jLx9EjIgUEn/Il7OCY8Fut79vGQjFUXmsjCwbIhhAX75Oj0WAuc6tV6h39j0lXb2qEG6cjKZfE4Lxxj6g89bgh1TCgAhlMlrn4OcjbFqZasWCtp/MsX40zUo588qDqKdNFwim8JWb0nOhoYpSk28y6JhTrBY5iRZ4ZLuinpr0WtFV2qR2Vowz2l/jgoa3+ik6Q0cqyM3BwZEvcwBUZzyEJ/PNALvi7Rag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(346002)(366004)(136003)(376002)(41300700001)(186003)(2906002)(6506007)(6512007)(26005)(5660300002)(86362001)(6486002)(31696002)(478600001)(2616005)(8936002)(83380400001)(6916009)(31686004)(36756003)(316002)(54906003)(38100700002)(66946007)(66556008)(4326008)(8676002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUV2KytDMmIrcGxpL1RoWGo1em9LK0EycTY4dkx3UlIrbnlpRG94VkNNT2p4?= =?utf-8?B?S3AyN0s1alp3WXRvRXI3dzZZaWZpcWZpeXR6dGlDYXhCdHRkdkt5N1IvUzF2?= =?utf-8?B?WlVmODJkNlpqK05KNlRlT0Vvcno3SEVJZElPbFI5dmJJUDlPRHZNNE5jWkhy?= =?utf-8?B?M3hKRDN3YTVEZXRHNGdnb2lDTUx3eHFiVGI1R3BVaS9FSVF2V1JlZFRvaWdG?= =?utf-8?B?Y25Xelp6eFJDeGJTUEQyY2dVV21QUjJuOTZjUG15bk5kNGIvSE5ncUVZVEN3?= =?utf-8?B?VXpHU1c4a0VqOTJrdWx5TGJkTitlN1R6ZkplWm5NdmZnQVcyYmNQMUhRYnk2?= =?utf-8?B?bnBOQlpEbXBkZ2k3L1ZHMFFGUUZmSHU1ZmlmSHJWbVAwa1ZjVkJPM2MwSUEw?= =?utf-8?B?UHFFU2xSN2UzU2FOSjEvQ2g3OFROaXF3ZE9maytRK2NSUVcvQ0JuMW5STS9v?= =?utf-8?B?RE5lWU16SE90SmdSWHpCdXpLcThOaHdrelRrMW9XZEczVFZDZ0h0WmxtbHBn?= =?utf-8?B?K3l3QW01SllTZ3ZPSVdocDNEMlhhM2RiRElzUEhRRnBIVzgxYlN0cmpwUnB6?= =?utf-8?B?OGYyaDJsM2QycnRKTERtU0ZTUEpQTUlHcURvRC9ZUG1PMWJSZllRdmVKVGNG?= =?utf-8?B?MVIxQ0pDY3JkQk1wUnB1NmhGSFlLSEMwZmIyL0NPNnV6YUhGYzdtTU5qd0ln?= =?utf-8?B?RUNuYmx3a04xRXh6dG5tSEt5aSt1TFljVXEweVgxTlZtK0JGNWZxVUhmUHQv?= =?utf-8?B?eVBwZzBBbjBhUkhMcW9mVlA3dnVGblhYZjlhc2plUzFRbDg2bG5jdFlEQXZH?= =?utf-8?B?UXp0TVpOZjJjVk4vV2JUVVdRZWVqdmVSMXlyWXNKM0hXM2hlWWJuY2F6SjJB?= =?utf-8?B?SlM1RU5oODJCQXROS3FaSXJRaVpmR3oraHNrNzdnS3ZpZUtWUWhYbkpScHM0?= =?utf-8?B?b2ZKY1FvNUJxMzJ5bnl5M0VhRk93QnNGQmtCZUlNYmUzWDI2MThXaUlNQlBi?= =?utf-8?B?cnIrMnhGYmk3VHd5cnFQWTUrWG1DQmtvaGcrMHhMYnZjM3J2L0ZIUytxdDV1?= =?utf-8?B?K0svaytaZjlIYjVzZVdSaTMrNXR5a0xFN3c2Tmkvb3E2WWM5UU1Pc2pLQkls?= =?utf-8?B?cEIvbWZJRFNvb0UvU29GMTFxdEdxaWQ1aUhnajFCWW5XODdzSW80NTRnb3JZ?= =?utf-8?B?eFJyRXdJd282UDI4WUdrRncyclZSUU9rbCtrcHU4MUxsakVObTdkQTBpVFlR?= =?utf-8?B?aVE2bEFseGtiMHJTYnJUY3lUbzlUU0FtRlZnU05PdnBRU0R2aWNNb2dnNTQz?= =?utf-8?B?bDRzbmZmMk9EbXh3REtUczFHRGVkZ2JFdFk0MTNrQUtiTEljbTRSa3dPOWs2?= =?utf-8?B?b1BWMTBNSGp2ekRMRVN1dEtNSTRYcnUrdmE0Q3JiQWE4RHlJc2tENFZjV05I?= =?utf-8?B?Z3lIcjh6dmIwcGlzcDlFOUw3RE5kazlsc0dTSHV1YUtUczlTbXpHUmJFc3hZ?= =?utf-8?B?L1hML1VSRXh1emRLbnlGSHJzdlpXZUcwWE5VbmFhdGZtS053aHAyenM2dUQ5?= =?utf-8?B?OGhKN0FZQmdjZUVFTXdTM2ZmejFXQVFyN1FNcm1Cck1WbG5STGJ6TnVKcEVL?= =?utf-8?B?TTE5MktoS1dOUkZvc1Q5TVlYbldYMHFHemlaSnpuMVBYMU50VEVzQ3Z3d2dU?= =?utf-8?B?cWxHY1NWUkdvTnVmTlBTTWZYRGFLWGFDb1BtNzUzWW1xbGVWYU1CL21yaDBQ?= =?utf-8?B?Uis4RGlwWDNYUnJVbUQxcmc1Vm00K1hmSitQYlpoOWpPcUUyMmovSGZRODc0?= =?utf-8?B?eTdhY3IwT1ZERjcrQmlCSFlzNWE4OXhPS1BxM3o3K3FGVFNCNzdSYmZGK2lP?= =?utf-8?B?WURPWld4VzFzSXRoSEpMRURmN1hCdktqSkp5bFY0eUZFM1oyeHMzM1FRbGJG?= =?utf-8?B?dFg2bzV2em9iOWUyZU13TmxBY29GL2RZUjNzWGpVSVF5bGlyQTY3b25kK241?= =?utf-8?B?a0gvYi84ZkYrL1VNVVIwME5ydG9rSVVDcGVGZGNMRm4vMFMvMzZ0T3diRzZJ?= =?utf-8?B?QUU2YU02MG0yM2lkWk5EYW9FNS8rSDNUWlFYcGVVcWFqSEx0Rkptdk14S2My?= =?utf-8?Q?X3gFMm8u6T5/9d08WlPKhNjPN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ffc06cc4-9299-47d2-b060-08da6f20cb56 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:06:26.8220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eQItRQ7G+e4e9//94ccpNgfjnAHoR+tll4DEBw9hZLjeir019nKJA1CVEcH/CDu3CD3e4maqVBparkYtKSrPkA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7772 Now that we're not building multi.c anymore for 2 and 3 guest levels when !HVM, there's no point in having these conditionals anymore. (As somewhat a special case, the last of the removed conditionals really builds on shadow_mode_external() always returning false when !HVM.) This way the code becomes a tiny bit more readable. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm/shadow/multi.c +++ b/xen/arch/x86/mm/shadow/multi.c @@ -3228,7 +3228,7 @@ static void cf_check sh_update_cr3(struc { struct domain *d = v->domain; mfn_t gmfn; -#if GUEST_PAGING_LEVELS == 3 && defined(CONFIG_HVM) +#if GUEST_PAGING_LEVELS == 3 const guest_l3e_t *gl3e; unsigned int i, guest_idx; #endif @@ -3279,7 +3279,7 @@ static void cf_check sh_update_cr3(struc #endif gmfn = pagetable_get_mfn(v->arch.guest_table); -#if GUEST_PAGING_LEVELS == 3 && defined(CONFIG_HVM) +#if GUEST_PAGING_LEVELS == 3 /* * On PAE guests we don't use a mapping of the guest's own top-level * table. We cache the current state of that table and shadow that, @@ -3321,8 +3321,6 @@ static void cf_check sh_update_cr3(struc !VM_ASSIST(d, m2p_strict) ) fill_ro_mpt(smfn); } -#elif !defined(CONFIG_HVM) - ASSERT_UNREACHABLE(); #elif GUEST_PAGING_LEVELS == 3 /* PAE guests have four shadow_table entries, based on the * current values of the guest's four l3es. */ @@ -3373,8 +3371,6 @@ static void cf_check sh_update_cr3(struc #error This should never happen #endif - -#ifdef CONFIG_HVM /// /// v->arch.paging.shadow.l3table /// @@ -3400,7 +3396,6 @@ static void cf_check sh_update_cr3(struc } } #endif /* SHADOW_PAGING_LEVELS == 3 */ -#endif /* CONFIG_HVM */ /// /// v->arch.cr3 @@ -3419,8 +3414,6 @@ static void cf_check sh_update_cr3(struc } #endif - -#ifdef CONFIG_HVM /// /// v->arch.hvm.hw_cr[3] /// @@ -3437,7 +3430,6 @@ static void cf_check sh_update_cr3(struc #endif hvm_update_guest_cr3(v, noflush); } -#endif /* CONFIG_HVM */ /* Fix up the linear pagetable mappings */ sh_update_linear_entries(v); From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:06:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:06:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375527.607978 (Exim 4.92) (envelope-from ) id 1oGN58-0007uY-Im; Tue, 26 Jul 2022 16:06:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375527.607978; Tue, 26 Jul 2022 16:06:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN58-0007uR-FL; Tue, 26 Jul 2022 16:06:50 +0000 Received: by outflank-mailman (input) for mailman id 375527; Tue, 26 Jul 2022 16:06:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN57-0007rh-UX for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:06:49 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2058.outbound.protection.outlook.com [40.107.22.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f44b3d0b-0cfc-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 18:06:49 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7772.eurprd04.prod.outlook.com (2603:10a6:10:1e3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:06:47 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:06:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f44b3d0b-0cfc-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IhNPEsT0LgljoV7L82WarQM96DOb/sgRxWn4swUtd3UEXavXmfBgj61v0wq4R8Vd1s0HOXhqTIwL5/+8My5MqlhWaEcV/GzwS79jDlPjdwtdmldlPko40YhFhBuBJ/GC+w5uooDsJLqMC5F9iFDeUt2fFWyGMzK9BjpDdX76SJjje9LaGh3wf9mxreaD2HLYpnCQCuHlDLbIk0RsndX+XXOSvYO2obV1Y1EThyC+aEkLQp4ApBkELVqsR96awgTO2o0OdQqsiPAkN4Ea8E8tToO0P3LX74uYdjo3IIDveE1u1rXsfjoMWtVBvF+X+CcW56HNneNeMISXCrfGBnVpCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qiM5Ep+GIGxc9iGqIuErdW/YkbCSwfcFyzej4dHa1nU=; b=gSmfItKeTbY2YEHkO2k0nanqGRuZ5jY6XIN15HakqnhJaqPbCEMb/+H+J63/Zt6PO5j0oWH3mXp9/3sXfiWNBe6EG1vOnwfWas6cKA7JwqnwniBhxGhObV3YDPEnNfLn45PtAf97mnG+dFpWCOhodePfwfaejYS/jQ68w8MbAedR100J7MuNvX91yh7tdHUAfYCFz+Y+APSzq2SCJt2LGu+6RjLEy2nFk2HPI9KYRgYTr/Zn4aHlJBrQAB9C/iMqvMVyRIJGIB4bhEdLkyknv8KQ6xlINvs3y4LRAiPPDn9PGRUg6aE8mb4yx/ZgTwBziCIWxkpKimASFe9xBJ4wZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qiM5Ep+GIGxc9iGqIuErdW/YkbCSwfcFyzej4dHa1nU=; b=HFU1uTKC1lzquHMpuCUhAoa6J6wr1Ld1Ih+RPYRQhbPsFE+s134VvO5/EFAhOUipihbJHrtW9HYOp81tn1WBQQ9d0S5yLIktKdw54Dp+P1c4vDC2Q3twqsdJFffnh47M7PHj7Vuc7RMQnJlRqtEBV3a0vL3en7bb4KCA683IhkR9gfaqnbiXCDbpxX0utj3zmJhKApaw7+3aMu57z3sep80i3TanfbecTZyQhmGPDePzzhvV0XKtNykvzcxvp9U3dEOQX2KHHzg5CrQ0UkTvSE6AnyInbzgLIWrBI7vE2q4w62a2FJ4r3gSiTZEsbTh0bRCn48ZwFsG2SaGImWVOBg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <40042c40-a2ba-e491-d16a-4bacbfc6154e@suse.com> Date: Tue, 26 Jul 2022 18:06:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0095.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a9::12) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cdd2baa-d08a-48b0-fd75-08da6f20d7e1 X-MS-TrafficTypeDiagnostic: DBBPR04MB7772:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wghQfK+DMVXn1DNLhpAJTqoETZwwBydw5sXL3W37g6OZWzKgJgiUlITY8uv6sihGJlp5tPTLlAE5yoO5ZmyIZB6tgwXRFtBwkSLgUUbBwk2rCav0p+6vZvPDg5+2SmKMGZsVgO1xLw2Bj4XVvSed8Jmc6rvnfOOAGjlvpvNlMLMdHrWH/hxpY18ON3Gzh3WsoGgR9bP1reHUQ4Dzera6OhVFrDEtzgMhyJ2nGWnH4btkJvYvXQsERk7/XQQuQmPLbWo5q1TWemFmslklsfd1wrPPmpbDOnFARQq+8FKvFHxhd7MC/ygW3EF5FvyYmu/7Vc6QSj4neR9ZkygCxBzjLLaGvfgJoqfTRAbqf1WrC2GZXbw0fVm2XgI/I2XAZUBdit7A0Dq1zljXsrTtotHWI/yws7EZXqtsVBkEgAkIiP1HJyuNLGRC2bU0K4XS0iHYhWNiLjsIuc81LGZJcBFVmLNjpD9DNWlu5Nb0kKzFZMwPEmY6uTEsa7D1OBnelKm/UmUDmyHdj8FnyoE+/l//GN8ogpDpasXIYlJUEXyVXFdt09Pt0OVCp/9Fwx5eJJFcjHvyEiI29FoRW3mVKFpeqLQJ3SXgIugj0dOtLOQK6rseNtU5DM81233pm59EWp8mSsF33MH3nGoVmuDeRZxnm0mTe9MTtX9uD7voEF0/w84PeTgXu4SwQIIR0Z0+/6bvKpJmrMN0Bkqlex9fBktJWw7rtGmA0m8DyW3M3lTfFAm1cmV50NhidgXWYLgygJpN8XQiOuH7RU1BR5Hk9PBMnPsjLhQE/niY64sdISk48AamRa3KfOTJA7HerumPScQJuBVRleYap/hFJ2h2F8Awzw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(346002)(366004)(136003)(376002)(41300700001)(186003)(6666004)(2906002)(6506007)(6512007)(26005)(5660300002)(86362001)(4744005)(6486002)(31696002)(478600001)(2616005)(8936002)(6916009)(31686004)(36756003)(316002)(54906003)(38100700002)(66946007)(66556008)(4326008)(8676002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkdkNG5YL1NoWS9FelpqYXZqWGllTGszMklyZXdHdnA4M0NpMWNMOUJ5WDdp?= =?utf-8?B?eTJ1eFU4L2NQWUYyZGp0dGNURFJzVFl5VEp1RksrRGNPelBVTW9ibzVjWnBY?= =?utf-8?B?bU5xQWxmKzF5cndHMnBxek1NUEV6SVVyRE1TOUlGTDd2WkZPUHNpRFBLdlB5?= =?utf-8?B?ZmpqOWNrYSt0ek82dEJtbWpPc3NJcVo5b242WHpnTTEvc0VwSWdMSml0eHNk?= =?utf-8?B?NjR6YVpDNDU0UFZoZHNVa2JiNEh6TDY4MWE4ZGQxZ3pOMERhSnhoWEhQaCto?= =?utf-8?B?Yk1BcDZaNTV4djk3djJFcVNPN2JycHlQb1BPcEZ3aFltbVFWMzlaRVRKSmdR?= =?utf-8?B?SGl6aHB1ZDR5OXlBc3hva1NFOUE3Z2xzRWV5aXVqS3loblFpL3Z0MFd1eVM1?= =?utf-8?B?V2FIY1lROTJEcWlrT0xjYVBKejh2OFUvZGt2WlRiQ2xVZ2FGQmpBUDZpaXhZ?= =?utf-8?B?WVV6NkJTRmcrZDQwWTl2bXR1UUY2RWU2UGtySS9BUW9TVGtweE1QVEFlbG1D?= =?utf-8?B?MnZQY09PdS9UdDZwTVJLeWI1ZkVIaXROWjEyOFFJK2pvc0FQNVlYd0RJa21D?= =?utf-8?B?V0FYZ3A1Q0VsTEM5R2pxU05VRzhERnBKUEtkZVl3a3drdkRFaVN6QVl6Z2R4?= =?utf-8?B?Y1NNN3IwSW1Ob3JST3JMR215Sk94R2MwT2sydXBOT3ptdnQzcDNzZXhhbmVj?= =?utf-8?B?aFQ5a1ZZY3J0c0FLNUpzQTlkdXhROHVXVkRPU3Z1NDk4NTdhaTM3YW5KQ1hv?= =?utf-8?B?ZkJQSWtpNklYdWJvZDVKeDhMaHg1aUpraFBLeWh0Yi9aSlprT0xNYnl3TGQz?= =?utf-8?B?L1MvSWdWNVJWYy9MUThtbkVFVlJvY1dSSDVwUEdmOWt3QUxwUit2TU0zTnpz?= =?utf-8?B?N1Ira2tkc0kxL3hnZmhOSUZieGlzK3RHYnNac1VJc3JHTDNyWHgwS3RINThz?= =?utf-8?B?VkZWUzFtLytyM3RaY2NKTHpxdkNTZTlLamxVTE1EUXV3WnprYUJrVC8vemlu?= =?utf-8?B?SDZZK21oU0RidFg1c2ZNcHpjUzJGTmxZQUp1TUdJeEJLUU94TkZ2WjV4bndm?= =?utf-8?B?VHJuNE9HT3cyWjFGQXp0UzI0c3l6ZnlOTjFPZHd4bkVPc0dMeklUMTNyS05w?= =?utf-8?B?VVBKS2JLVzNiL00zVUZSMU03NlkxVThxSjNWNUlSRFB5QjM2eHdDckJJVFd3?= =?utf-8?B?UW9GSEFUaXRDNWk4aFdGZExlNHIwaFd6ZkhwUWl1WmFQek8yMldYL2pQUWpC?= =?utf-8?B?OGovejRWb0pyNGN6VjdWYkRzZXI4VnFSMnR1UERXR0UydHlGQ2ZlQXFWWS9O?= =?utf-8?B?OVExQ1ZIMlV6YVZoSElnUUdmaGN4TzF5blFyUzljQXFiL3VxanJzTHE0dUtp?= =?utf-8?B?UHJVcmxDRHA4S1FicXZkT3VEQi9NaXZ1QVkrMWk0MjRiMUNwK0cxZDMrWXJ4?= =?utf-8?B?SWFOUnI1bnJ1dVZ0NUQyaDFjdE1iVFMyRjRUenNrdEdISUdIRzRDTzVYRUxZ?= =?utf-8?B?U0pPMlpBNnpoSFJnSko4c2REcE1xdXpkMXVRZERkSG1Ld0hCbytmakQ4dldu?= =?utf-8?B?QUdkWGhnSFIvalU5VnA2R0duT0ExdUUwMlJMRmNsS1krK1dWbmFmMDVLVndT?= =?utf-8?B?M01LK1JTZ0hTalFpMm9HQ1RvNWpwc3ZodmI5MmtLazFRdmdxdUI5YXZ2QjlT?= =?utf-8?B?clVhems1VWwvSFZLQVhzc1EzQnlVcVAySk1aSERRd3cwcVFKRjdXOSt1aEZn?= =?utf-8?B?MEtud21wWVBJa0ZkTG5IZUw3MFhiVlJhd3FJUGFFZzFaaEh1RXgzWU8wc0JC?= =?utf-8?B?STJRb0ZLSWFDN2J5ZjhueGV3K3NiMUVvSFBJelN2OWJzTkxsYnV5Z0ttQ2o2?= =?utf-8?B?TUl1Zit6K2xHN3RsT1VhTlNyeGlndVUvTmpNb1VLT2lLYzNtUTZtM0Y5dEY3?= =?utf-8?B?dGFteXRnRWtHVXRZeXdTbnJwMElGNzRma3dlQVpqMW9yMWN4QmVsZ0hMdkNj?= =?utf-8?B?c0VocXRUYUIwcGcvT0NIUXVYN1RhOFRieEdFeVYrOE5HSjU1cEd0NTgzbG9k?= =?utf-8?B?MjdFOFk1clFZZmx0TXE2cTFocG1EeENYSUZ4a3hwVlgvN0tlOEo5eDBvMXhT?= =?utf-8?Q?gX603axYp4HLVgxeJxkUrEi3r?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdd2baa-d08a-48b0-fd75-08da6f20d7e1 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:06:47.8832 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7zkxIyuKLu3vR0xiks8dxE597UsSDjv9p+UthVbE21RZbaQiOX4rEMnQEzjNv5L2/iDdxmJFTBW8ojuxxMESrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7772 While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is cleared upon de-validation (see also the respective assertion earlier in the function). Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3020,7 +3020,7 @@ static int _get_page_type(struct page_in if ( d && shadow_mode_enabled(d) ) shadow_prepare_page_type_change(d, page); - if ( (x & PGT_type_mask) != type ) + if ( (x ^ type) & PGT_type_mask ) { /* * On type change we check to flush stale TLB entries. It is From xen-devel-bounces@lists.xenproject.org Tue Jul 26 16:07:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 16:07:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375533.607989 (Exim 4.92) (envelope-from ) id 1oGN5c-00007T-0U; Tue, 26 Jul 2022 16:07:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375533.607989; Tue, 26 Jul 2022 16:07:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN5b-00007M-SG; Tue, 26 Jul 2022 16:07:19 +0000 Received: by outflank-mailman (input) for mailman id 375533; Tue, 26 Jul 2022 16:07:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGN5a-0008Mo-2k for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 16:07:18 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2053.outbound.protection.outlook.com [40.107.22.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0507d35a-0cfd-11ed-bd2d-47488cf2e6aa; Tue, 26 Jul 2022 18:07:17 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by DBBPR04MB7772.eurprd04.prod.outlook.com (2603:10a6:10:1e3::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Tue, 26 Jul 2022 16:07:16 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Tue, 26 Jul 2022 16:07:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0507d35a-0cfd-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktA7nN6zAq3AbE/KoNY5DyGI/cFOI3j9W01sKmpKyZnnbmK3MsBWetaWpAY3JcSfpoRRBAbuxK0AOhLeAPgbsYG8VcgABGzpHA75+Afb4dYZ9VpZP794ichuy3vTEJ61ETHFffW6Yt7qLxpPG5CzLz2EUU1mnjyvziEMfXYQKdvvk5bBNFpA1NZezgHAhHfjY1UIKtzLfiH7hEgFJaI1BSrKlWRoDHr0CFsZS/hEG5i/d8OzS3n/VQ5kf3e0XtopLVRjU3yaP28YIllUK7EdH6ZC3cGe+bJiTI1cH4RREJ9Yj0FWVB2h6HUZDY06NL9Soxz87lAsr7Zc5pmWwUO6dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HL14tmU18Cp4BQe+e29MGYjb1FaYInGq5siSnr2Mod8=; b=e5EzArV5hs+bs9alpdeSnIT3UBGaljOZScU80EqjLPSwv6Cwgw1565vzTAyg3LszDjPswjDbcmqDdcJ02G2oLt0WrcDM8AFg9KqIJM70InhX27BXdGcXK49R6mPwOJoV4QUkGrYMhcMrFzSdYiBnmzqUZ8CeI6GqxLjgIzvG4QL0v1j2QNUMfBIWS4Gg578gUEzDcHClylGeLAKiArf1fE/EN7y4uvLWvLQLgd04NM64FZ1ThOanwE/SyIivw4HKPXS8eT6tvBkiZSwgJ4scGP/LSobkcB1aDzmIeOJfG8r4Iwj/bSirOlKAUZPEFM27+7f5pdniqyYFFYgyhER6xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HL14tmU18Cp4BQe+e29MGYjb1FaYInGq5siSnr2Mod8=; b=1RP9IRPEu0sGKc2jeJcgcP75xp4XaAGrfVyBSqznNo4ZEpGAXtfsBa7WvPyZmh85yj2UFFItWpvTkIHLsP3FbXFRYJII42a0ABejipRsBJsJU4O488WCNeyX31o6PDnLurs4pXBvKH2OO7LzWBGtb+71nRsUOxjrhWS8sNq9qiQzybWV8Uwm86VzDxfG4xK+mQyXlAnsxbxuyCYWaMJh5+aWwLXHnGZ2fp4ICn87dLbIkh1x/o/uKD+pAitFaXzF1eYRjcPrCfVW13z4n2MGmR6ESjJGDD+V7mwjKhn5r2mMQDf2HPxRZnVTpqvD8ZN7sSPf7ha3BWwHF5W2xR3BEQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Tue, 26 Jul 2022 18:07:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush Content-Language: en-US From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Tim Deegan References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0050.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::13) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 02585d12-4562-4112-7e35-08da6f20e8a0 X-MS-TrafficTypeDiagnostic: DBBPR04MB7772:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AEm64qTKRLumjDJ+ucK02p7g+pZezDTZ2RP7QbEuW0e54AWKo+OJWG9wC5rY03dpg9f/EN6OYhihtHyeRlh86zudoQBLFFi9H+GLTWmhvga6O6KikRBGz4wXK/RVdG3qfLPrAzfCNN+8DIYIGPlvoCD0xmlABbmCdzotrqkEuXnKQQobFq1U090zN5uZ0/acLdDUlSgHkANjirtkNmwqcGh5yQpM3+tmlZ1Tz/OclR+gzOXuLMi3ZvxQmLwLoFnadn0nHtgbcvy8JSWMiT5LRYI+1Rmjz5uV8NAHu95n70RSXkc7lPoZ4n4HeorFN6TaE3pwBGUelwYbTcR+rakh0hzCdIGA6+d+h3dd84iJe38Xf7br4gzgSX3n0lbOsRqIsCj3+g50SS8nvhNgKR6V9BWVvEGFquAa9OL8+43828GAbZIZ+NX6ybW3/1JwgdnyltkFcwM97rvU7RY1JmtEWZzhUw33GjwrDiZKHV4WqAz4sSbdgUTTJamL/piiNXjOOVEIG440SMBHylLgVQoX7ig73zs5jzS6JpjjmXhF5BIykxwc4FjOTjfvvKeJCZhZgyuYQEPoQp595cQCqHtVamBrQzowODUWd3pE+l57K1o9s2Wc+92dMpEU71qXmpYS4H2iUoPbSO6SeCrT1Rv/34is1qOU9ludAvLL4/Q3LkrvC4Uy1D2aF2ab5htS6oNH/F+A5mKiDaBIJVJZIP7S8k44jZLJwCH62W/GG002MwBZ7hbe/A+OrjMFAJcPEzv+Hid7e3n0ROuTZRxAvTGb27aJNwszO8O1bCnlPgwtELZXfrBfNf9k+Ut3bu8VZKON0QeOMRTK7ETDPsFGCPwDEA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(346002)(366004)(136003)(376002)(41300700001)(186003)(2906002)(6506007)(6512007)(26005)(5660300002)(86362001)(6486002)(31696002)(478600001)(2616005)(8936002)(6916009)(31686004)(36756003)(316002)(54906003)(38100700002)(66946007)(66556008)(4326008)(8676002)(66476007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cjhvMGtOMU4xc3BZbU8xaHFveU1zVWtOWW5VUnFxeFJaOEgyUkVwM25ZdDg3?= =?utf-8?B?WVMrK01vL21jRGM1OVBzL0FnZmhGTmV2S1V1eUx0cDl0MU84cVJyK0tSRWMv?= =?utf-8?B?a0RkdHpOMzJBWitHdTlqRkFjR3Z4cEJUZTd4Z0sxSDhwOVJvdTdsTGNJQ1VV?= =?utf-8?B?VTF1N1QzLy9UMDcyTnBhbUhzb0hkKzNtL2xrOFppbjZJT0VLZTRyZGFZOUtX?= =?utf-8?B?T3dvT2lnRGRib0kzdGw3N2x1clFBM0xldmZvWWovMHl5c2RKTTBWMlFjQUdS?= =?utf-8?B?d1FmZW96QzZMdDk5Sjl3TjFzR01LNVpsWHFRdFdZR3NudCtSUnBsS2RMR1ox?= =?utf-8?B?R3BWQXl3NlBzbmhDTzB6RmR2RjlRNHIzSkxLUzJvcENEOG12WXB6OE84YlpT?= =?utf-8?B?ZWJobUlVZkZxMXAvNUZONXFRa005bVJESDZoV2FVZ0dpMjdqSzFRMmZUeS94?= =?utf-8?B?ZFVuZ0xtRGlad3FVdWExODhRU2xBNnc0U0xCQjRFTjc4UjBIM1dCZWRmWmw4?= =?utf-8?B?aGhXNHRFYWdQWDl3MmE1SllkMi9rK3J4dGU5YmtSSXhTME9VbEtPRW83dXJO?= =?utf-8?B?bllFVE9UVFhuQ1dFd3BBb2lhdVpVbVRYVXRlM0NiMlhlczIrU2xYSUw3RHpH?= =?utf-8?B?ZGd4ejI0QzFUTUxOSXprakx2RkdNUmc5WFduZ1FYamowTzBjTXlyRGZDWFdW?= =?utf-8?B?UDUwVjNGdEp4L205SFlHbUt3RWhjMUpJNTltMDJRSGdqcFhZTWt6OW1DdTYz?= =?utf-8?B?UVdrWm1wV1hDbmRVQkVCWC9yelBRU1o0UUU1S0UwTDRIcWdaVW5tWVZNRzhQ?= =?utf-8?B?M200dmhaRThFZVJwb3dJUGhiOFN2Z3Vtb1RPVmdCYWEyaHZoQVRxYmYrVkIy?= =?utf-8?B?QmphWGM0bjNFZlVvdGxRajFVeE5PZ2JxQVcvc09XL3FGT0dadG5vK3V5amxR?= =?utf-8?B?TXV6bDZDWUlPcXJNUjJsRk9VV1dERFFQcU90dWRGRU56U2JISTZjNE9KMS9y?= =?utf-8?B?TGt1L2hjcnhYL3RRdjBmby9kdXpNd0JPdDdkWkJyQzNlcHQrS3dNTnEvUjgv?= =?utf-8?B?K2RHWWZib3VlUnRNZmx4QSs1elo1Q0tJd00vc2JaNzdtMEFUbE5ROHhLdGNP?= =?utf-8?B?VGI1VlNlbllBY2VnS1lGeEsrQjg5RlYxTG9ZRTNXMkNBUFZIVXRlbWN1Ujk1?= =?utf-8?B?dlFaL0RkcmpVQVlXcFRSejFSTERhNk9SVVIxdjVEZ0U3ZEFSNVpHQ0NRK2Fq?= =?utf-8?B?OUFJSkN0OVFxT1lHS0NHTmt3bkVxMERNTjlhSzBJWUVnWWt1dSsyMW5kVWhr?= =?utf-8?B?MFF5NGR5YkxkQ3pGQnNzZ2swVHVndHYzUVhYa3hNa1g4amdVZkxQaFpyMzdC?= =?utf-8?B?OGtQcld3d1NZUlBDUDFmUExlRUphZDA3QlRIblA3cm15NmkzbFNjak9sQW5W?= =?utf-8?B?N1AxVVRBeTgxdWdnNVp5Zk12bGlyVjgrY252SlJma3dNcGRhWituU1pvdUp4?= =?utf-8?B?VWRzZ0F6TzA2aGtkWW1SbDVPZUhkODFlTlk5MXdHSHk5d3FFc2R6Q05Fa2tZ?= =?utf-8?B?WmFwMWtjNlVoQ2VKdnZoS1lWbndzRk1ram5haHBUL3NBSlhwc0VvOGlOejVE?= =?utf-8?B?VXJNSEpTUTZUaXNGSDVUOXpkaVVTMGpaZG5RclloUWpSRmJMM3NFaTdVQjZ5?= =?utf-8?B?bGVCa1Z4VlVwdUdPaS9qU0ZBeGptQkRVTFp4SFFXMitmR0txNGRrNWxPcUph?= =?utf-8?B?M3I0dk5KbXROeUUrVmQ5aWdzVUlJMmRERS95bjI0NHMzM2VaVFdoUUtPeS9k?= =?utf-8?B?Mzl1NXY4WmhwTzFoRFkrTEJueUt4Q0dkdTkzR0RjdGd0QUlhVENzRktFSTh4?= =?utf-8?B?dWhMeVFxSmc2V3RzVkV2WlhNeTZud3BranJKZWdpTHUva2Y3THdsR0tyOXpa?= =?utf-8?B?S3Q3WGIzd0tvQUswL2tyTEI3cWZtM2tHc0VSQUJjQ0I4QVlQM3c3emx1eUZn?= =?utf-8?B?Q0FCRmpqVjFPMlZ4ejJNcUtDWGQySHVQQU1iVnVaKzM2eFQrcWNJYWJpTEla?= =?utf-8?B?NFpSTWNSbWptZ09aOVlZV2pvQ2g5L215RHR2dnRCM1UrLzdqMGd2UVNVTkJp?= =?utf-8?Q?Thz2Yo4iHXiyNnOzFMWJa78rI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02585d12-4562-4112-7e35-08da6f20e8a0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 16:07:16.0065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2RAwXEg+VBe2dvUhRn8P4KhIOD6Wx6vlAzPCvE/pHmR7lmRq2t+frp0eeMrxQC51zGhg9tSMOnwHX/zxvTo4hw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7772 Checks dependent on only d and x can be pulled out, thus allowing to skip the flush mask calculation. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3020,7 +3020,10 @@ static int _get_page_type(struct page_in if ( d && shadow_mode_enabled(d) ) shadow_prepare_page_type_change(d, page); - if ( (x ^ type) & PGT_type_mask ) + if ( ((x ^ type) & PGT_type_mask) && + /* Shadow mode: track only writable pages. */ + (!shadow_mode_enabled(d) || + ((x & PGT_type_mask) == PGT_writable_page)) ) { /* * On type change we check to flush stale TLB entries. It is @@ -3035,10 +3038,7 @@ static int _get_page_type(struct page_in /* Don't flush if the timestamp is old enough */ tlbflush_filter(mask, page->tlbflush_timestamp); - if ( unlikely(!cpumask_empty(mask)) && - /* Shadow mode: track only writable pages. */ - (!shadow_mode_enabled(d) || - ((x & PGT_type_mask) == PGT_writable_page)) ) + if ( unlikely(!cpumask_empty(mask)) ) { perfc_incr(need_flush_tlb_flush); /* From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:18:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:18:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375564.608000 (Exim 4.92) (envelope-from ) id 1oGOCY-00085X-5w; Tue, 26 Jul 2022 17:18:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375564.608000; Tue, 26 Jul 2022 17:18:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOCY-00085Q-2N; Tue, 26 Jul 2022 17:18:34 +0000 Received: by outflank-mailman (input) for mailman id 375564; Tue, 26 Jul 2022 17:18:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOCW-00085F-AK for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:18:32 +0000 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [2a00:1450:4864:20::631]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f76c9d10-0d06-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 19:18:31 +0200 (CEST) Received: by mail-ej1-x631.google.com with SMTP id mf4so27424542ejc.3; Tue, 26 Jul 2022 10:18:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f76c9d10-0d06-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to; bh=r48lO1KcX4H/r85dS2DpPqDwqQL+nXXdTD4DhticW/g=; b=eH8Qqv8DRNj9BwV/NaXDx+uGQj3ZtAdO98f+trGz68PPBYddBQlAuD3R6Gg0qNQ4Rm 1qbFg15UKszCbBxcvt43NHc7NIyCsKlOGCBOo2W/5VjbahEYVMmAiE8ZkDxNNwP5KG/G 3mI71iBFAe/7ahL+FzteSOXfVNmNwKh/2mbXpY436PjUrsaga6TyHhNE9rBVxMuhB6q9 Fby9xqVb8hgsi/pwDFVwmcsEr5U74fadGC9StQtIeyYm6XpPVKj0sDgBb/2IsPl3mV31 c1++b8eNZvUxk4z5+H6KGowT4trwofFEl/AM6YGhoxTLg9sgAnyVRlCz9l+zk3Nb5rgY dITQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=r48lO1KcX4H/r85dS2DpPqDwqQL+nXXdTD4DhticW/g=; b=nWQjeEOarv+6zVf/a3DdCGQbP60pPGPYWMUkqU13uuqMJM45R4n2DxA8LGiIbRB0bO INAY1XoaMvCKSTXCosoJ7BsI62oQ1EIWSgH86Zas2K+fe3ZKOe3N3QqRpwPyL/AbFtL1 76YxXpjbx5WDxK7YXFntu3DTn0Nemr2HKF0vZJWL6pqc/jQe8nxB7MEJTXEfXS3Hs6iA PkzmwePaBC6yrAvkdVx7P0HzNQZydJJUagqwEm/D96ee31XnZdI4CKVlxWMmcWKDSHnt bg9SU1TIyLqr98WMkpvpzMpf7fIfUCbIpLY8TfOhNmfvDZrQkUINi62ci1dep98/qmxX LY3g== X-Gm-Message-State: AJIora/ck28DHOQ2QDseAML31DuGNIVdPr6EcSNeAb8e/xveTsOc4iix U5MsRrxlE2Ok2e/dkp8dBdmP0UFJHiBncTeey/6k5O5hEvybBL2o X-Google-Smtp-Source: AGRyM1u8qVUAggX3bGychPPe0Cb1eEcYIcCzMXFnYkrE4xiyZxbXj+K2igSzlPdgi29jcI0uIizfaUyM/FtixB4R2IE= X-Received: by 2002:a17:907:6297:b0:72f:9aad:fcb with SMTP id nd23-20020a170907629700b0072f9aad0fcbmr14527805ejc.161.1658855908395; Tue, 26 Jul 2022 10:18:28 -0700 (PDT) MIME-Version: 1.0 From: A Sudheer Date: Tue, 26 Jul 2022 22:48:16 +0530 Message-ID: Subject: access usb mass storage from multiple DomUs To: xen-devel@lists.xenproject.org, xen-users@lists.xenproject.org Content-Type: multipart/alternative; boundary="000000000000274ec805e4b87d81" --000000000000274ec805e4b87d81 Content-Type: text/plain; charset="UTF-8" Hi all, i am able to passthrough usb mass storage to DomUs but only one DomU at a time. For passthrough mode, added below parameters in cfg file and is working. usbctrl=['type=auto, version=2, ports=6'] usbdev=['hostbus=2, hostaddr=2'] Is there a way to share the mass storage between multiple DomUs at a time ? How do i configure to access usb mass storage in multiple DomU simultaneously. Thanks Sudheer --000000000000274ec805e4b87d81 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi all,

i am able to passthrough usb ma= ss storage to DomUs but only one DomU at a time.=C2=A0=C2=A0

=
For=C2=A0passthrough mode, added below parameters in cfg file an= d is working.
usbctrl=3D['type=3Dauto, version=3D2, ports=3D6= ']
usbdev=3D['hostbus=3D2, hostaddr=3D2']

=
Is there a way to share the mass storage between multiple DomUs = at a time ? How do i configure to access usb mass storage in multiple DomU = simultaneously.=C2=A0

Thanks
Sudheer=
--000000000000274ec805e4b87d81-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:32:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:32:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375605.608029 (Exim 4.92) (envelope-from ) id 1oGOQ4-00038F-SC; Tue, 26 Jul 2022 17:32:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375605.608029; Tue, 26 Jul 2022 17:32:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOQ4-000388-PV; Tue, 26 Jul 2022 17:32:32 +0000 Received: by outflank-mailman (input) for mailman id 375605; Tue, 26 Jul 2022 17:32:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOQ3-000382-23 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:32:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOPz-0005cc-Qd; Tue, 26 Jul 2022 17:32:27 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGOPz-0005Lw-JW; Tue, 26 Jul 2022 17:32:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=TDMSdmuhgwrJYKAEjV1l+Nk7/bhrNPugEBq81jGeU2w=; b=yxAtFOI6Lej1lzXWXdlDq/lLS/ n+JqEWhoWzTxCxj+4Wo+YTePz6YB4n7JvV+uNOKdwKBmydBAVGKUyYwLOG8x6mVD6+x4hAgjrIpvc S11JLHZsquRH09GslLP61HwVfVoGRQdQ3YVGTeoCbZiKZemxsWfVYrqy4D3/Zr1gwiVg=; Message-ID: Date: Tue, 26 Jul 2022 18:32:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/8] mm: enforce return value checking on get_page() To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Tim Deegan , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 26/07/2022 17:04, Jan Beulich wrote: > It's hard to imagine a case where an error may legitimately be ignored > here. It's bad enough that in at least one case (set_shadow_status()) > the return value was checked only by way of ASSERT()ing. > > Signed-off-by: Jan Beulich Acked-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:35:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:35:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375610.608040 (Exim 4.92) (envelope-from ) id 1oGOTC-0003kT-Aq; Tue, 26 Jul 2022 17:35:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375610.608040; Tue, 26 Jul 2022 17:35:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOTC-0003kM-7W; Tue, 26 Jul 2022 17:35:46 +0000 Received: by outflank-mailman (input) for mailman id 375610; Tue, 26 Jul 2022 17:35:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOTA-0003kB-Ro for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:35:44 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOT8-0005hZ-OT; Tue, 26 Jul 2022 17:35:42 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGOT8-0005ff-GN; Tue, 26 Jul 2022 17:35:42 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6Z/NZ3KAbfhXFRA6u6VXMWJRceC17hHIFkndbGPG6Y8=; b=4CwgsNw5dXCOHD8Cmvr0ou7PXb 5847YKHLIY/j8ybE/vCXmQjsubjPiXTUKfBoK5/l0h0iGdEQbo3Ey0fRSTv3Bw5GT+pP5PhBLTxzQ niynTWSWN9eibEcLjmGqBRpLoccglAEomdX/z10OtCuIBhvrH7mju9OVX/JbrStdUVDE=; Message-ID: <53703921-12a2-90cc-55bd-94a4d86a5d70@xen.org> Date: Tue, 26 Jul 2022 18:35:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device To: Rahul Singh , Mykyta Poturai Cc: Bertrand Marquis , "Volodymyr_Babchuk@epam.com" , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" References: <0A58139F-CA6F-4E18-B44A-2066AEF0C8F6@arm.com> <20220628172338.1637121-1-mykyta_poturai@epam.com> <69C0FF69-98E3-440B-9CE7-3025EE5E0E4C@arm.com> From: Julien Grall In-Reply-To: <69C0FF69-98E3-440B-9CE7-3025EE5E0E4C@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 21/07/2022 16:53, Rahul Singh wrote: >> On 28 Jun 2022, at 6:23 pm, Mykyta Poturai wrote: >> With this patch I get the same results, here is the error message: >> >> (XEN) smmu: /iommu@51400000: Unexpected global fault, this could be serious >> (XEN) smmu: /iommu@51400000: GFSR 0x00000001, GFSYNR0 0x00000004, GFSYNR1 0x00001055, GFSYNR2 0x00000000 >> > > As you mentioned earlier, this fault is observed because GPU continues to access memory when the context is > already invalidated, and therefore triggers the "Invalid context fault". This is a different issue and is not related to this patch. > > @Julien are you okay if I will send the below patch for official review as this issue pending for a long time? I am OK in principle. I will do a proper review on you send a formal patch. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:37:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:37:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375616.608050 (Exim 4.92) (envelope-from ) id 1oGOVI-0004TP-Mm; Tue, 26 Jul 2022 17:37:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375616.608050; Tue, 26 Jul 2022 17:37:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOVI-0004TI-Jz; Tue, 26 Jul 2022 17:37:56 +0000 Received: by outflank-mailman (input) for mailman id 375616; Tue, 26 Jul 2022 17:37:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOVI-0004TC-08 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:37:56 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOVF-0005jL-Pk; Tue, 26 Jul 2022 17:37:53 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGOVF-0005kf-JY; Tue, 26 Jul 2022 17:37:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=858EOI/8hkdn5r97Z5UqHlsyophybJ/tSH3CID88NPY=; b=WpmoAv/DKsnxl/rpvvIDmJKV2L kqFWCmHkHn3PJP9CsnXdhI65IzpK7ZIyzLD6h5Ky9oaCoiK4LHtYVnO0bWkdbev1vqeQQeQQJ/3M7 FpdTJJVCrx5pyiD+7hRd9HhuNEG5GEShvVu9ObHyVNVUOv235puZU8+7YwbhQkQ6fnpU=; Message-ID: Date: Tue, 26 Jul 2022 18:37:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port To: Rahul Singh Cc: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/07/2022 16:37, Rahul Singh wrote: > Hi Julien, Hi Rahul, >> On 21 Jul 2022, at 2:29 pm, Julien Grall wrote: >> >> On 21/07/2022 13:50, Rahul Singh wrote: >>> Hi Julien, >> >> Hi Rahul, >> >>>> On 20 Jul 2022, at 12:16 pm, Julien Grall wrote: >>>> >>>> Hi Rahul, >>>> >>>> On 20/07/2022 10:59, Rahul Singh wrote: >>>>>> On 13 Jul 2022, at 1:29 pm, Julien Grall wrote: >>>>>> >>>>>> >>>>>> >>>>>> On 13/07/2022 13:12, Bertrand Marquis wrote: >>>>>>>> On 13 Jul 2022, at 12:31, Julien Grall wrote: >>>>>>>>> I can't >>>>>>>>> see why it would be wrong to have a more tight limit on static ports >>>>>>>>> than on traditional ("dynamic") ones. Even if only to make sure so >>>>>>>>> many dynamic ones are left. >>>>>>>> >>>>>>>> This is similar to Xen forbidding to close a static port: it is not the hypervisor business to check that there are enough event channel ports freed for dynamic allocation. >>>>>>> On other side we need to be cautious not to add too much complexity in the code by trying to make things always magically work. >>>>>>> If you want Xen to be accessible to non expert by magically working all the time, there would be a lot of work to do. >>>>>> >>>>>> It is not clear to me whether you are referring to a developper or admin here. >>>>>> >>>>>> On the admin side, we need to make sure they have an easy way to configure event channels. One knob is always going to easier than two knobs. >>>>>> >>>>>> On the developper side, this could be resolved by better documentation in the code/interface. >>>>>> >>>>>> Cheers, >>>>> To conclude the discussion, If everyone agree I will add the below patch or similar in the next version to restrict the >>>>> max number of evtchn supported as suggested. >>>> >>>> I am fine if the limit for domU is fixed by Xen for now. However, for dom0, 4096 is potentially too low if you have many PV drivers (each backend will need a few event channels). So I don't think this wants to be fixed by Xen. >>> Agree. >>>> >>>> I am not entirely sure we want to limit the number of event channels for dom0. But if you want to, then this will have to be done via a command line option (or device-tree property). >>> We need to support the static event channel for dom0 also, in that case, we need to restrict the max number of evtchn for dom0 to mitigate the security issue. >> >> It sounds like there are some misundertanding or I am missing some context. The static event channels will be allocated at boot, so the worse that can happen is it will be slower to boot. >> >> My point regarding fifo was more in the generic case of allowing the caller to select the port. This would be a concern in the context of non-cooperative live-migration. An easy way is to restrict the number of ports. For you, this is just an increase in boot time. >> >> Furthermore, there is an issue for dom0less domUs because we don't limit the number of port by default. This means that a domU can allocate a large amount of memory in Xen (we need some per-event channel state). Hence why I suggested to update max_evtchn_channel. > > Thanks for the clarification. >> >>> If the admin set the value greater than 4096 (or what we agreed on) and static event channel support is enabled we will print the warning to the user related to fill >>> the hole issue for FIFO ABI. >> >> See above. I don't see the need for a warning. The admin will notice that it is slower to boot. > > Ok. I will not add the warning. Just to confirm again is that okay If I add new command line option "max_event_channels” in > next version for dom0 to restrict the max number of evtchn. Personally I am fine with a command line option to *globally* restrict the number of events channel. But Jan seemed to have some reservation. Quoting what he wrote previously: "Imo there would need to be a very good reason to limit Dom0's port range. " Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:39:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:39:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375622.608061 (Exim 4.92) (envelope-from ) id 1oGOXF-00054S-2c; Tue, 26 Jul 2022 17:39:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375622.608061; Tue, 26 Jul 2022 17:39:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOXE-00054L-VY; Tue, 26 Jul 2022 17:39:56 +0000 Received: by outflank-mailman (input) for mailman id 375622; Tue, 26 Jul 2022 17:39:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOXE-00054D-1x for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:39:56 +0000 Received: from d.mail.sonic.net (d.mail.sonic.net [64.142.111.50]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f386a02d-0d09-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 19:39:52 +0200 (CEST) Received: from [192.168.2.47] (c-174-62-72-237.hsd1.ca.comcast.net [174.62.72.237]) (authenticated bits=0) by d.mail.sonic.net (8.16.1/8.16.1) with ESMTPSA id 26QHdm9u012338 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Tue, 26 Jul 2022 10:39:49 -0700 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f386a02d-0d09-11ed-924f-1f966e50362f Message-ID: Date: Tue, 26 Jul 2022 10:39:48 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] livepatch: create-diff-object: Check that the section has a secsym Content-Language: en-US To: Jan Beulich Cc: konrad.wilk@oracle.com, ross.lagerwall@citrix.com, xen-devel@lists.xenproject.org References: <20220725171302.25910-1-sarah.newman@computer.org> From: Sarah Newman In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Sonic-CAuth: UmFuZG9tSVapvIjvXbpgdhFjSWO0QIOseVs+z6nG1rfRK/ZBWSzD9sPxSkZb9O5WkJmReVZe2a1qaF0U4xdHGjXYnKGkEqlN X-Sonic-ID: C;DmBY8gkN7RGrCbBQfcNRkQ== M;JMql8gkN7RGrCbBQfcNRkQ== X-Spam-Flag: No X-Sonic-Spam-Details: 0.0/5.0 by cerberusd On 7/25/22 23:25, Jan Beulich wrote: > On 25.07.2022 19:13, Sarah Newman wrote: >> A STT_SECTION symbol is not needed if if it is not used as a relocation >> target. Therefore, a section, in this case a debug section, may not have >> a secsym associated with it. >> >> Signed-off-by: Bill Wendling > > Hmm - this wasn't here before. Does this then suggest the patch also > wants to be marked From: Bill? I don't know what the etiquette is here since this was a commit originally committed to kpatch, I just added that back because the xen patch submission guidelines said to preserve original tags. > >> Origin: https://github.com/dynup/kpatch.git ba3defa06073 >> Signed-off-by: Sarah Newman >> Reviewed-by: Ross Lagerwall > > Sigh. I had given R-b on v1 as well. Actually I had meant to commit this > yesterday (with all adjustments made), but as it turns out committers > can't commit to that tree. So it'll be up to Ross or Konrad to actually > take care of this. > > Jan > My apologies, I simply missed that. I am doing this in my spare time. This is the first time I've gone through this process in a couple of years and have only done it a few times total. Thanks, Sarah From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:44:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:44:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375631.608073 (Exim 4.92) (envelope-from ) id 1oGObg-0006Y7-Nm; Tue, 26 Jul 2022 17:44:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375631.608073; Tue, 26 Jul 2022 17:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGObg-0006Y0-KV; Tue, 26 Jul 2022 17:44:32 +0000 Received: by outflank-mailman (input) for mailman id 375631; Tue, 26 Jul 2022 17:44:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGObf-0006Xu-1g for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:44:31 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGObe-00060M-Ml; Tue, 26 Jul 2022 17:44:30 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGObe-0006BE-G1; Tue, 26 Jul 2022 17:44:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: References:Cc:To:Subject:From:MIME-Version:Date:Message-ID; bh=JtrIj46UVhxRXI8fxuylATUFcBOimi8VcUTEXe6VWG0=; b=avppsieiLCSOAOLtd/wUBno+X+ Qkwem6CDXIJ0rP1Eo5VQED468Y5oCKiQ2+esbr9IbIdNdpt/O3fIYBmIZWGaaP55P2BawpQL8Cxxz XO0i+HBbhGM8cZFdSplzVqrV5yxK4Tb19/8jR5WWcWmfDjFlY5lVnfLBa8perixW2eZc=; Message-ID: Date: Tue, 26 Jul 2022 18:44:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Julien Grall Subject: Re: [PATCH] arm/vgic-v3: fix virq offset in the rank To: Hongda Deng , xen-devel@lists.xenproject.org Cc: nd@arm.com, Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220715104620.3929121-1-Hongda.Deng@arm.com> In-Reply-To: <20220715104620.3929121-1-Hongda.Deng@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Title: I would suggest to mention the irouter in the title. On 15/07/2022 11:46, Hongda Deng wrote: > When vgic performs irouter registers emulation, to get the target vCPU > via virq conveniently, Xen doesn't store the irouter value directly, > instead it will use the value (affinities) in irouter to calculate the > target vCPU, and then save the target vCPU in irq rank->vCPU[offset]. NIT: The field is technically called "vcpu". > But there seems to be a bug in the way the offset is calculated when > vgic tries to store irouter. NIT: I would drop this sentence because below you suggest this is a bug. > > When vgic tries to get the target vcpu, it first calculates the target Typo: When the vGIC... > vcpu index via > int target = read_atomic(&rank->vcpu[virq & INTERRUPT_RANK_MASK]); > and then get the target vcpu via > v->domain->vcpu[target]; > > When vgic tries to store irouter for one virq, the target vcpu index > in the rank is got via > offset &= virq & INTERRUPT_RANK_MASK; > finally it gets the target vcpu via > d->vcpu[read_atomic(&rank->vcpu[offset])]; > > There is a difference between them when gets the target vcpu index in > the rank. Typo: I think you mean 'getting' rather than 'gets'. > > Here (virq & INTERRUPT_RANK_MASK) would already get the target vcpu > index in the rank, so we don't need the '&' before '=' when calculate > the offset. This is a bit confusing to read. Through the commit message you give mix information about the issue. "don't need" to me means this is pointless but harmless. But then a bit below, you write this is a bug. I would suggest to change the order with the next paragraph (it may need some tweaks) and replace the "don't need" with something more assertive. > For example, the target vcpu index in the rank should be 6 for virq 38, > but vgic will get offset=0 when vgic stores the irouter for this virq, > and finally vgic will access wrong target vcpu index in the rank when > it updates the irouter. > > Fixes: 5d495f4349b5 ("xen/arm: vgic: Optimize the way to store the target vCPU in the rank") > Signed-off-by: Hongda Deng > --- > xen/arch/arm/vgic-v3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c > index e4ba9a6476..7fb99a9ff2 100644 > --- a/xen/arch/arm/vgic-v3.c > +++ b/xen/arch/arm/vgic-v3.c > @@ -135,7 +135,7 @@ static void vgic_store_irouter(struct domain *d, struct vgic_irq_rank *rank, > ASSERT(virq >= 32); > > /* Get the index in the rank */ > - offset &= virq & INTERRUPT_RANK_MASK; > + offset = virq & INTERRUPT_RANK_MASK; AFAICT, vgic_fetch_irouter() has the same problem. Can you update it here as well? > > new_vcpu = vgic_v3_irouter_to_vcpu(d, irouter); > old_vcpu = d->vcpu[read_atomic(&rank->vcpu[offset])]; Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 17:54:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 17:54:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375638.608084 (Exim 4.92) (envelope-from ) id 1oGOlR-00089L-Kn; Tue, 26 Jul 2022 17:54:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375638.608084; Tue, 26 Jul 2022 17:54:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOlR-00089E-Hf; Tue, 26 Jul 2022 17:54:37 +0000 Received: by outflank-mailman (input) for mailman id 375638; Tue, 26 Jul 2022 17:54:36 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOlQ-000898-1K for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 17:54:36 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2057.outbound.protection.outlook.com [40.107.20.57]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0112c3e1-0d0c-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 19:54:33 +0200 (CEST) Received: from DB6PR0802CA0048.eurprd08.prod.outlook.com (2603:10a6:4:a3::34) by AM0PR08MB4481.eurprd08.prod.outlook.com (2603:10a6:208:148::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.20; Tue, 26 Jul 2022 17:54:30 +0000 Received: from DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::df) by DB6PR0802CA0048.outlook.office365.com (2603:10a6:4:a3::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Tue, 26 Jul 2022 17:54:29 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT026.mail.protection.outlook.com (100.127.142.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Tue, 26 Jul 2022 17:54:29 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Tue, 26 Jul 2022 17:54:29 +0000 Received: from 7c4cde0860f9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0CD7A060-B7A9-456F-B227-5A7952886530.1; Tue, 26 Jul 2022 17:54:18 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7c4cde0860f9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 26 Jul 2022 17:54:18 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by DBBPR08MB4458.eurprd08.prod.outlook.com (2603:10a6:10:c8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Tue, 26 Jul 2022 17:54:15 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.024; Tue, 26 Jul 2022 17:54:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0112c3e1-0d0c-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lMfMiMxNPx1DQd8nddOfMoejmp5FZNb/fpXoXiU2GqMqoo7w916UJdmUxMnRsfYBebFUBVSV0g7+Q0S2Uj7HYvmJqVJ0Z1kFjoDKY1ElyGEJtGzXqdl+0ZcdKGNovOPzz4k7HaCBYFnzL5T8YhVOfcIFdnQZukrBr5P54t7WE6jD5PKEVnER+GqexrOaDpMNasyi1FV9YpcDzlqHb2IpKkuV8IS0Y7A1CHoWesVC0IZ6pvsE+zFn638sNH+T1Xq+rwo3PRHY8ro3bvxJmzra/0bwBvEgFjWI0/QtCwyuVB1VDZTxlrODnWyvuO23KmIDyRuKES9qjpNWDuGUWulaMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yqf2HrM5cwNlZb1sRn9sgOYekHVMARMf1nskCLjgsNg=; b=K/H57BJN82CpPgw+NFmq5wTe0FpJFdpzWoGKvE7aYkuGgk4ntRsDxwSgj+b50gs/Gg3BbqGiXSGOHOaaeFA/IdqxG2EQM3Fw7SgV4Pa+L49T9LdhchLy+fMA1narwvnJr0B9HtI/0q/vG4VHc//Djn2XbONoCjFkK1uadF1TJq0KPYZE8+1kNLPt4+9IH3GY+kMbgCVopZUAl3I2iKdKkG57ATNnPdeupkM7zD0rizLKJrOl9MhO15Y+ULF1XObLaAuS8eydjHMvwXq82sQ2dv3QyZeDa95gQ23NmDs1JVk980Cnayev4+b97nUeir2zW94tpNKmOPEB1BA0ICsljQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqf2HrM5cwNlZb1sRn9sgOYekHVMARMf1nskCLjgsNg=; b=jc3Fy6IQ/+1I36nflsVl1KbnwmqzaUhaHL4wS7sqgUVMxHE1l38FRiwLld2MN6sTYrEDz8Wc/lHYElQKo8E4Ff12zbQneC+sugX/IYLsu0sF7DU1kNOFhcw7cjYG3fCsKq5/kPdHvW7q1lgHkyi8RoPTZ8D46AbbIepRa3oBKqo= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 3451fc0f16a722b7 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EgSr1P95KSyHfx747T17Qgmot+/m0ni0bJzUVw/LdGAd9NcoRGdWFpVRoiLqzO+2Wd4ztt8VHy0XbefFs9+dY7QcQWrvotp2mvfOGF4M3gPzAoAMkknNMpHC/KexpN2I947x4M3xP6w3nMWyVpKTgWolH+8j2h1HodtelixNdUApKbAOe/G/Bo6ftccNFT0PVfGCo5IRD4kmBS/kpfN1VdoOdI/mz5uTqLStsrIscUGHbIgntXsNP+SSg9eNWkgoWE7uih9cKZ8p41K/x+KUIhOjfha4aQ16aY/my3UWLQbO/22GCLMMhiEkzkpj36AZz4StnZZQjhnM0O2YOmUQGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yqf2HrM5cwNlZb1sRn9sgOYekHVMARMf1nskCLjgsNg=; b=Ws/ztLCFgwEleruslGLhVZYT2q8reFcFrQaDWah53cp7LEfQZbvnXBZl4ch7tbXFlUV4fzPii0S/73LNT1Iu8x/J/1misOzVkmtE9CwsYR8a9gYZR/QESKXxnqb/SyPX+/IGyrae60fewqRwOSAReiDI1VvmZBuP543qpwyHqWha/r3VXwKoLicIDCguPo0WTORWCtUu2TtlAe7EBZNc67VOkQbLqVtuBWdDv4FJlhdcuQntTF/W/8RAIxaBrpfSTdS8oPA5ek1U7uxsMtnqxKtGqWV1ozhuJn+AhiXyZq4pCbZLXL8+cWVrVvvDpPlwnA45QVOP7g74+jLmF/YG4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yqf2HrM5cwNlZb1sRn9sgOYekHVMARMf1nskCLjgsNg=; b=jc3Fy6IQ/+1I36nflsVl1KbnwmqzaUhaHL4wS7sqgUVMxHE1l38FRiwLld2MN6sTYrEDz8Wc/lHYElQKo8E4Ff12zbQneC+sugX/IYLsu0sF7DU1kNOFhcw7cjYG3fCsKq5/kPdHvW7q1lgHkyi8RoPTZ8D46AbbIepRa3oBKqo= From: Luca Fancellu To: Julien Grall CC: Hongda Deng , Xen development discussion , nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH] arm/vgic-v3: fix virq offset in the rank Thread-Topic: [PATCH] arm/vgic-v3: fix virq offset in the rank Thread-Index: AQHYmDhKpSlCCmBtRkalGlTcUHBM2q2Q/kQAgAACugA= Date: Tue, 26 Jul 2022 17:54:15 +0000 Message-ID: <64095CA8-C1FC-4EF1-874C-E3E1962567EA@arm.com> References: <20220715104620.3929121-1-Hongda.Deng@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 21e0c7f0-0f35-4785-f97f-08da6f2fe362 x-ms-traffictypediagnostic: DBBPR08MB4458:EE_|DBAEUR03FT026:EE_|AM0PR08MB4481:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: qUEO9GG6IIaWyc2TeXxMcPUWgP18I2HeaFNu1h+UkC4Z38H3QXdjiMO7mAPL67ynlav0Ax4EARvGrHc2Y+i7QsQffPgbF7Y7EBSBEZIWqhzzcI5FPojHz2qfCPM9usEADrc+7TKDb5MJ8n5Ji0JROkcs3AGcjvKOTE/r+d1Tdul3Jtt4esEmc4vfPuA+BuOaZsilhugCIz+xuW7OVoP9wXuBt1Res0WcuLae2+2k64Q2jp/O3WkFBjy8Fv7XN3ZF0h8bfU+YksDa1STLET47bLJXaPdZInFqP4okHAxICvmSBEh98R2rgUoE63Vf9Kx7aEpvGLt+DZth7b8MyE151yogLhCDKzSKVsQtjomV8LPpXWKaULmzgMRZ8r8T4S0OUgHIScatBC++VWmhiBkQ9pwQ0z9B8rhL2XP0LHMsMJb8RpgIvRPnVBH+vTWGiJMTyS2bEqkw2M1jhPnfnIv6OYCHJEajF1GnUqdAtiU9EcPrq2hXCRnX2E+GZHuinfjvu+ALttnn4G0rVcYn897OXdezoZdV2c/YutOGlR5DDJWf4ZvlRwJtk9bvdEn1xrv7uTHLmk2VFxoYUrG68qIyEF34P3U9cCOh3TMsUuRIpOlEfudYJXtL3etzSJjuNy12Ew3TA7FWtQIwOQWrrJvqz4Fejea0q/T2uxUqlbaDEVQq6IAKxfGIS1ReuO1fIEcP36M1QFgE/0Rl/cByLGdbUZGT6+S+SwZDZ7sYIrSy7Ub37QVyhZs+NeHsr07jHAnfO5v2WgV60MpK9L1dM+HO3rf1qzQrCDlFANJqcsHZ0bO3WnyDzWmd8kh/xgQ+rtR6yFgFv3/xZP2PCmzgpt12IA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(5660300002)(26005)(6512007)(38100700002)(6506007)(64756008)(4744005)(8936002)(36756003)(186003)(6486002)(478600001)(83380400001)(66946007)(41300700001)(76116006)(33656002)(91956017)(66476007)(2906002)(86362001)(4326008)(122000001)(6916009)(2616005)(8676002)(66446008)(38070700005)(71200400001)(54906003)(66556008)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <91E4CF8F3C1E0640A27B195B2896AA2D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4458 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ee71a0b7-8dff-4385-aca5-08da6f2fdaca X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0OyPMJYEuJKY0ShbM3H0Zt2yM0fCOwsNwji5Ko92YokZiFa7qELPJw1V4glGzhxUesfTwwCQmKB/bSu/EJsNwScdfFywo39c0JvPKH84FmFEP2DjWhEp5FZK56b2L0fUi4E4lovOEw9xtgeU6D9M3IyCE0L6Tpep3bvElg2uszFJN1hFFmS20NDfaxPVoXAiIRtKtd9mvlvdfYM1M+0yR+S2Pta/LQfeQ9xVqL/8VB0QTIAsUA6/wTQVDMgCSyA8UlLo9E9dSxyx6Y8XqYaoGtk+zcTJZP1Md/I+2cIPfRHf/rmZizgtCM/uyv7DKXY0lkYsSjLxRMa7Cu8i2UId8q/3U6W4nY0U/MFY3LVRa9Gn652XLvTcwX31llKAOGugUBSo3R006X0eTtqkVayoeXJ6SWXz8MILdTUzO7UV6sZNxsI/L/bHpjTeBS68Ti4ixFblpvyKyvlTvdVe8WIUQfOZTmmo7Wf9bB44RqX22Mene+5FXD/3wGhrsdXM1/YZmGE56Jc5jUqGA//7tvldHYp1glefBAPKYA8KhkAyEVrVldYSjlUV2tBfnOiqzE9aU4rG6ttZ6MfpoDZmNA0wwZRFwcscQpmxAwF9RpDMG+AOsiArOnnl10zHdAPwx4FnmHysgy6+eRe9jlRf77LnoFhVS6SmnQaFAYo2y9PF+O8YmTtwEZyI7y2Kvr88wW0sTvJvkJFb1KtJ42LOmZoDDTYi/2V2uJuIsbyWdYyfDCwbh9SzsL+Z9kUeQxxpUKepOV7dEgQO8YLauee0XwkJx2rJkcTRtXhUdW8meXzMrFAEEAh3Tpv6mZbtz/9GaRsC X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(376002)(396003)(36840700001)(46966006)(40470700004)(6506007)(36860700001)(4744005)(8936002)(6512007)(40480700001)(107886003)(6862004)(2906002)(186003)(33656002)(5660300002)(26005)(47076005)(41300700001)(2616005)(40460700003)(36756003)(356005)(4326008)(70206006)(478600001)(8676002)(83380400001)(54906003)(82740400003)(82310400005)(316002)(6486002)(336012)(70586007)(86362001)(81166007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 17:54:29.5406 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21e0c7f0-0f35-4785-f97f-08da6f2fe362 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT026.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4481 DQpIaSBKdWxpZW4sDQoNCj4+IC8qIEdldCB0aGUgaW5kZXggaW4gdGhlIHJhbmsgKi8NCj4+IC0g b2Zmc2V0ICY9IHZpcnEgJiBJTlRFUlJVUFRfUkFOS19NQVNLOw0KPj4gKyBvZmZzZXQgPSB2aXJx ICYgSU5URVJSVVBUX1JBTktfTUFTSzsNCj4gDQo+IEFGQUlDVCwgdmdpY19mZXRjaF9pcm91dGVy KCkgaGFzIHRoZSBzYW1lIHByb2JsZW0uIENhbiB5b3UgdXBkYXRlIGl0IGhlcmUgYXMgd2VsbD8N Cg0KSSB0aGluayB0aGF0IGZ1bmN0aW9uIGlzIG9rLCBiZWNhdXNlIGluIHRoZXJlIHdlIGhhdmU6 DQoNCi8qIFRoZXJlIGlzIGV4YWN0bHkgMSB2SVJRIHBlciBJUk9VVEVSICovDQpvZmZzZXQgPSBv ZmZzZXQgIC8gTlJfQllURVNfUEVSX0lST1VURVI7DQoNCi8qIEdldCB0aGUgaW5kZXggaW4gdGhl IHJhbmsgKi8NCm9mZnNldCA9IG9mZnNldCAmIElOVEVSUlVQVF9SQU5LX01BU0s7DQoNCldoaWNo IGlzIGJhc2ljYWxseSBvZmZzZXQgPSAob2Zmc2V0ICAvIE5SX0JZVEVTX1BFUl9JUk9VVEVSKSAm IElOVEVSUlVQVF9SQU5LX01BU0s7DQoNCkxpa2UgaW4gdGhlIGNvdW50ZXJwYXJ0ICh1cGRhdGVk IGJ5IHRoaXMgcGF0Y2gpIHZnaWNfc3RvcmVfaXJvdXRlciB3aG8gaGFzOg0KDQovKiBUaGVyZSBp cyAxIHZJUlEgcGVyIElST1VURVIgKi8NCnZpcnEgPSBvZmZzZXQgLyBOUl9CWVRFU19QRVJfSVJP VVRFUjsNCg0KW+KApl0NCg0KLyogR2V0IHRoZSBpbmRleCBpbiB0aGUgcmFuayAqLw0Kb2Zmc2V0 ID0gdmlycSAmIElOVEVSUlVQVF9SQU5LX01BU0s7DQoNCldoaWNoIGlzIHRoZSBzYW1lIGFzIGFi b3ZlDQoNCkNoZWVycywNCkx1Y2E= From xen-devel-bounces@lists.xenproject.org Tue Jul 26 18:08:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 18:08:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375647.608095 (Exim 4.92) (envelope-from ) id 1oGOyG-0001ac-QR; Tue, 26 Jul 2022 18:07:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375647.608095; Tue, 26 Jul 2022 18:07:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOyG-0001aV-N4; Tue, 26 Jul 2022 18:07:52 +0000 Received: by outflank-mailman (input) for mailman id 375647; Tue, 26 Jul 2022 18:07:50 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOyE-0001aP-H4 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 18:07:50 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGOyD-0006To-58; Tue, 26 Jul 2022 18:07:49 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGOyC-0007L2-TH; Tue, 26 Jul 2022 18:07:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=l8bWrkiASMfyQa8reDRgMmg4Z303ORAVDy22/WUEJE0=; b=5VSduaUGb3ourZa9umZneUg5E6 Qqy+gLDpKLgPMvfQrThjJ/hj1sR1+406nF4d+ppbN1ZRKNYkryAP/cMLAqrDAjx9hoXCTKnjC6guo aVO90lx33VJlhcbDT6rlCLEstdlk+XAY806TRdzGau+hUs+so0U9o2LPGxy8kj0ocb/g=; Message-ID: <04c7adfd-e978-b911-fef9-f068ec624849@xen.org> Date: Tue, 26 Jul 2022 19:07:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules To: "Daniel P. Smith" , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Jan Beulich , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> <78c3f88a-4f36-087d-31b1-d02bfbc8df30@apertussolutions.com> From: Julien Grall In-Reply-To: <78c3f88a-4f36-087d-31b1-d02bfbc8df30@apertussolutions.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Daniel, On 19/07/2022 17:36, Daniel P. Smith wrote: > > On 7/15/22 15:16, Julien Grall wrote: >> Hi Daniel, >> >> On 06/07/2022 22:04, Daniel P. Smith wrote: >>> For x86 the number of allowable multiboot modules varies between the >>> different >>> entry points, non-efi boot, pvh boot, and efi boot. In the case of >>> both Arm and >>> x86 this value is fixed to values based on generalized assumptions. With >>> hyperlaunch for x86 and dom0less on Arm, use of static sizes results >>> in large >>> allocations compiled into the hypervisor that will go unused by many >>> use cases. >>> >>> This commit introduces a Kconfig variable that is set with sane >>> defaults based >>> on configuration selection. This variable is in turned used as the >>> array size >>> for the cases where a static allocated array of boot modules is declared. >>> >>> Signed-off-by: Daniel P. Smith >>> Reviewed-by: Christopher Clark >> >> I am not entirely sure where this reviewed-by is coming from. Is this >> from internal review? > > Yes. > >> If yes, my recommendation would be to provide the reviewed-by on the >> mailing list. Ideally, the review should also be done in the open, but I >> understand some company wish to do a fully internal review first. > > Since this capability is being jointly developed by Christopher and I, > with myself being the author of code, Christopher reviewed the code as > the co-developer. He did so as a second pair of eyes for any obvious > mistakes and to concur that the implementation was in line with the > approach the two of us architected. Perhaps a SoB line might be more > appropriate than an R-b line. > >> At least from a committer perspective, this helps me to know whether the >> reviewed-by still apply. An example would be if you send a v2, I would >> not be able to know whether Christoffer still agreed on the change. > > If an SoB line is more appropriate, then on the next version I can > switch it Thanks for the explanation. To me "signed-off-by" means the person wrote some code (or sent the patches) code. So from above, it sounds more like Christoffer did a review. So I think it is more suitable for him to provide a reviewed-by. For follow-up, my preference would be Christoffer to provide the reviewed-by on the ML. If it is too much overhead, I would suggest to log the latest version Christoffer reviewed-by in the changelog. I usually do: Changes in vX: - Add Christoffer's reviewed-by Or if he will reviewing every version, just mention it in the cover letter. >> >> Please explain in the commit message why the number of modules was >> bumped from 5 to 9. > > The number of modules were inconsistent between the different entry > points into __start_xen(). By switching to a Kconfig variable, whose > default was set to the largest value used across the entry points, > results in change for the locations using another value. Ok. Can you add something like: "For x86, the number of modules is not consistent across the code base. Use the maximum"? > > See below for +1 explanation. > >>>     static void __init edd_put_string(u8 *dst, size_t n, const char *src) >>>   { >>> diff --git a/xen/arch/x86/guest/xen/pvh-boot.c >>> b/xen/arch/x86/guest/xen/pvh-boot.c >>> index 498625eae0..834b1ad16b 100644 >>> --- a/xen/arch/x86/guest/xen/pvh-boot.c >>> +++ b/xen/arch/x86/guest/xen/pvh-boot.c >>> @@ -32,7 +32,7 @@ bool __initdata pvh_boot; >>>   uint32_t __initdata pvh_start_info_pa; >>>     static multiboot_info_t __initdata pvh_mbi; >>> -static module_t __initdata pvh_mbi_mods[8]; >>> +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; >> >> What's the +1 for? > > I should clarify in the commit message, but the value set in > CONFIG_NR_BOOTMOD is the max modules that Xen would accept from a > bootloader. Xen startup code expects to be able to append Xen itself as > the array. The +1 allocates an additional entry to store Xen in the > array should a bootloader actually pass CONFIG_NR_BOOTMOD modules to > Xen. There is an existing comment floating in one of these locations > that explained it. This makes sense. So every use of CONFIG_NR_BOOTMOD would end up to require +1. Is that correct? If yes, then I think it would be better to require CONFIG_NR_BOOTMOD to be at minimum 1. This would reduce the risk to have different array size again. That said, this is x86 code, so the call is for the x86 maintainers. > >>>   static const char *__initdata pvh_loader = "PVH Directboot"; >>>     static void __init convert_pvh_info(multiboot_info_t **mbi, >>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >>> index f08b07b8de..2aa1e28c8f 100644 >>> --- a/xen/arch/x86/setup.c >>> +++ b/xen/arch/x86/setup.c >>> @@ -1020,9 +1020,9 @@ void __init noreturn __start_xen(unsigned long >>> mbi_p) >>>           panic("dom0 kernel not specified. Check bootloader >>> configuration\n"); >>>         /* Check that we don't have a silly number of modules. */ >>> -    if ( mbi->mods_count > sizeof(module_map) * 8 ) >>> +    if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) >>>       { >>> -        mbi->mods_count = sizeof(module_map) * 8; >>> +        mbi->mods_count = CONFIG_NR_BOOTMODS; >>>           printk("Excessive multiboot modules - using the first %u >>> only\n", >>>                  mbi->mods_count); >>>       } >> >> AFAIU, this check is to make sure that we will not overrun module_map in >> the next line: >> >> bitmap_fill(module_map, mbi->mods_count); >> >> The current definition of module_map will allow 64 modules. But you are >> allowing 32768. So I think you either want to keep the check or define >> module_map as: >> >> DECLARE_BITMAP(module_map, CONFIG_NR_BOOTMODS); > > Yes, in the RFC I had it capped to 64 and lost track of this related > changed when it was bumped to 32768 per the review discussion. Later in > the series, module_map goes away. To ensure stability at this point I > would be inclined to restore the 64 module clamp down check. Thoughts? I don't know what would a sensible value for x86. I will leave this question to the x86 maintainers. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 18:11:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 18:11:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375652.608106 (Exim 4.92) (envelope-from ) id 1oGP1R-0002z1-7a; Tue, 26 Jul 2022 18:11:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375652.608106; Tue, 26 Jul 2022 18:11:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGP1R-0002yu-4i; Tue, 26 Jul 2022 18:11:09 +0000 Received: by outflank-mailman (input) for mailman id 375652; Tue, 26 Jul 2022 18:11:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGP1Q-0002ym-Ji for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 18:11:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGP1Q-0006kC-B9; Tue, 26 Jul 2022 18:11:08 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGP1Q-0007lB-51; Tue, 26 Jul 2022 18:11:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=v35Sb7seWJdYScUDX7CES2kRKTJFMczWf6NQ9bdr4bU=; b=ZrZapO6IKbKZ2afNDAv2yna9vk Yn7ZwefO0CZ6n2lNfn/ieJE9VISdo4iT5KsAfLom9Ys26ocFd6yTVqyHD8PNrI1LjFPulk4ntsz8l 4ToPeTpXSeqIDcLI8SensvPewRUmmzNnjKAO5RiDHEajgGqneuDMsXUB7kjnOEmgrCwY=; Message-ID: <90dea818-accc-5c04-39f3-913ca366a3a9@xen.org> Date: Tue, 26 Jul 2022 19:11:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] arm/vgic-v3: fix virq offset in the rank To: Luca Fancellu Cc: Hongda Deng , Xen development discussion , nd , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220715104620.3929121-1-Hongda.Deng@arm.com> <64095CA8-C1FC-4EF1-874C-E3E1962567EA@arm.com> From: Julien Grall In-Reply-To: <64095CA8-C1FC-4EF1-874C-E3E1962567EA@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/07/2022 18:54, Luca Fancellu wrote: > > Hi Julien, Hi Luca, >>> /* Get the index in the rank */ >>> - offset &= virq & INTERRUPT_RANK_MASK; >>> + offset = virq & INTERRUPT_RANK_MASK; >> >> AFAICT, vgic_fetch_irouter() has the same problem. Can you update it here as well? > > I think that function is ok, because in there we have: > > /* There is exactly 1 vIRQ per IROUTER */ > offset = offset / NR_BYTES_PER_IROUTER; > > /* Get the index in the rank */ > offset = offset & INTERRUPT_RANK_MASK; > > Which is basically offset = (offset / NR_BYTES_PER_IROUTER) & INTERRUPT_RANK_MASK; > > Like in the counterpart (updated by this patch) vgic_store_irouter who has: > > /* There is 1 vIRQ per IROUTER */ > virq = offset / NR_BYTES_PER_IROUTER; > > […] > > /* Get the index in the rank */ > offset = virq & INTERRUPT_RANK_MASK; > > Which is the same as above You are right. So the patch looks correct to me. Although, I would still like the commit message to be clarified. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 18:20:44 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 18:20:44 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375662.608116 (Exim 4.92) (envelope-from ) id 1oGPAO-0004gR-7s; Tue, 26 Jul 2022 18:20:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375662.608116; Tue, 26 Jul 2022 18:20:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPAO-0004gK-5K; Tue, 26 Jul 2022 18:20:24 +0000 Received: by outflank-mailman (input) for mailman id 375662; Tue, 26 Jul 2022 18:20:22 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPAM-0004gE-Fd for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 18:20:22 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPAL-0006sM-8v; Tue, 26 Jul 2022 18:20:21 +0000 Received: from 54-240-197-230.amazon.com ([54.240.197.230] helo=[10.7.237.34]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGPAL-0007ym-1c; Tue, 26 Jul 2022 18:20:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=hhn8BvzTgZh6i8oaH+6cF0772+3Ozdc2gbiQ6dC18ok=; b=jRrG/pZYjfka0zV8zFLhd9l2kP wZXMVXoIxdYRrCKkcQt0NuKN8YGr6Uq8ii+JDIZYVqsLWfQuNWRZ+7WcQwfbbpnWgQBQ87vqy4fz8 4U0WmzdXLMIZ+x3SDFEaPawTGDw9DEo2Am5iPXUE471MPyvKYBe/IDDWiglYuNeaW2zk=; Message-ID: Date: Tue, 26 Jul 2022 19:20:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] page-alloc: fix initialization of cross-node regions To: Jan Beulich , Julien Grall Cc: xen-devel , Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , "Xia, Hongyan" References: <473c82d9-0f81-b4f4-70a3-8dfc3beb2be2@suse.com> <5ea40e1c-6be4-ea82-accb-8bfc21cdf987@suse.com> From: Julien Grall In-Reply-To: <5ea40e1c-6be4-ea82-accb-8bfc21cdf987@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 25/07/2022 17:18, Jan Beulich wrote: > On 25.07.2022 18:05, Julien Grall wrote: >> (Sorry for the formatting) > > No issues seen. Good to know. I sent it from my phone and the gmail app used to mangle e-mails. > >> On Mon, 25 Jul 2022, 14:10 Jan Beulich, wrote: >> >>> Quite obviously to determine the split condition successive pages' >>> attributes need to be evaluated, not always those of the initial page. >>> >>> Fixes: 72b02bc75b47 ("xen/heap: pass order to free_heap_pages() in heap >>> init") >>> Signed-off-by: Jan Beulich >>> --- >>> Part of the problem was already introduced in 24a53060bd37 ("xen/heap: >>> Split init_heap_pages() in two"), but there it was still benign. >>> >> >> Is this because range will never cross numa node? How about the fake NUMA >> node? > > No (afaict), because pages were still freed one by one (and hence node > boundaries still wouldn't end up in the middle of a buddy). So I agree that free_heap_pages() would be called with one page at the time. However, I think _init_heap_pages() would end up to be called with the full range. So we would initialize the first node but not the others (if the range spans over multiple ones). Therefore, I think free_heap_pages() could dereference a NULL pointer. Anyway, I would not expect anyone to only backport the patch to split _init_heap_pages() and... in any case you already committed it (which is fine given this is a major regression). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Tue Jul 26 18:37:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 18:37:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375668.608127 (Exim 4.92) (envelope-from ) id 1oGPQt-0006V3-Kq; Tue, 26 Jul 2022 18:37:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375668.608127; Tue, 26 Jul 2022 18:37:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPQt-0006Uw-IA; Tue, 26 Jul 2022 18:37:27 +0000 Received: by outflank-mailman (input) for mailman id 375668; Tue, 26 Jul 2022 18:37:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPQs-0006Oz-IN; Tue, 26 Jul 2022 18:37:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPQs-00079s-Eq; Tue, 26 Jul 2022 18:37:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPQr-0003tQ-W0; Tue, 26 Jul 2022 18:37:26 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGPQr-0003T6-U3; Tue, 26 Jul 2022 18:37:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=jyiB0vPKXcEHLCdJa52ucO5MHLF4PJVyaMz4c3/67A8=; b=YIit3k7HMqLhk+JiKhA31p2447 t2wsFyTPswvlcGpfZaMfZ6I5cHm63ysRm+BQ0X1S4arGnRk80z2cR2uV6G6NPPMhkUT6N3ORQAaZ6 tsgORcHU3O1mDniEzS2shLUAJtaEynm/gIZ0Y7IZ2oiIJVAxWg4ge3prv4gO9owZRLxc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171863: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=616a6459d878999b37c7cfbf1ed8d4ca84b3751f X-Osstest-Versions-That: qemuu=5288bee45fbd33203b61f8c76e41b15bb5913e6e From: osstest service owner Date: Tue, 26 Jul 2022 18:37:25 +0000 flight 171863 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171863/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171749 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171749 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171749 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171749 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171749 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171749 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171749 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171749 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 616a6459d878999b37c7cfbf1ed8d4ca84b3751f baseline version: qemuu 5288bee45fbd33203b61f8c76e41b15bb5913e6e Last test of basis 171749 2022-07-21 21:10:51 Z 4 days Testing same since 171863 2022-07-26 10:07:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Bulekov Bin Meng Jason A. Donenfeld Paolo Bonzini Peter Maydell jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 5288bee45f..616a6459d8 616a6459d878999b37c7cfbf1ed8d4ca84b3751f -> upstream-tested From xen-devel-bounces@lists.xenproject.org Tue Jul 26 19:07:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 19:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375680.608150 (Exim 4.92) (envelope-from ) id 1oGPtv-00021r-95; Tue, 26 Jul 2022 19:07:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375680.608150; Tue, 26 Jul 2022 19:07:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPtv-00021k-61; Tue, 26 Jul 2022 19:07:27 +0000 Received: by outflank-mailman (input) for mailman id 375680; Tue, 26 Jul 2022 19:07:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPtu-0001mA-Le for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 19:07:26 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2f9589ca-0d16-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 21:07:25 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id j22so27863547ejs.2 for ; Tue, 26 Jul 2022 12:07:25 -0700 (PDT) Received: from uni.router.wind (adsl-45.176.58.224.tellas.gr. [176.58.224.45]) by smtp.googlemail.com with ESMTPSA id eg47-20020a05640228af00b0043bbcd94ee4sm8952306edb.51.2022.07.26.12.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 12:07:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2f9589ca-0d16-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KuhC1kxwd9csR35zZXVNzYXhV5vaAkNKgTfykKJEjLA=; b=U3henfgLSkyzH5mr8ZBE40xVwJ8yWiGKYEXKCAmdE5nS3ywp7is/6BRL4DADq3Vvxr /4ZGd2XU7u5+RL3cFTCmbONYnadPDemw5LnrmkwClym3qS60YC87EE7Y41mkpFZAQOF+ Psdzb0nn1UuxfEmfvdVCW7wiCdlQwDronuO+Wn0GnZLZ73HFmy05NRoEPJJGuBOv7Ote ygVuMlIRLrAisR7bJG80t3E9iLeXPKa0qTrfds6ao7JGlj84IAB//F8nG4Jh3t3aqa+6 gKYA9zoJSJ7flz0kkDGdRgszea9gf0OlGb3g47bSFSLM2sb/aHlBsVa9ki+VqizKKZsa hSoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KuhC1kxwd9csR35zZXVNzYXhV5vaAkNKgTfykKJEjLA=; b=gU92YnLt6GoSQzddSnwKn+bmF7gLabScTo+wkzukHrKFTjrAs3PypQDaPs00xgQpny JejmyTXhUC6wLXu/D/MecoWp4/hhf1apRUP2kqm4uZ6AZTq8ssopvNpcKqSkrBTJLyaA yeCgqqDgkYcdrOolrQTbuCObXaCK9uO6BjSaXTF+6TEfY8D3WyRpt5ca97xSQOEAUbDQ J/jKikaeAW9gi0Io0x9lCbXyYtDdPbGyy3RAhfwzmyh6g6DjwnsPQoT9dNN/HnTlb5Eg 60AOeQ6MzgsRsIaT74mmWyhHjMsicV3RegmdXpQBIVadgcJWL4nYVlM2x4LkGWXbdqPU UFBQ== X-Gm-Message-State: AJIora/xF32To8iwoyEUXYjSS+pMkmBpkN424M3OfW0U2Je/N7vpeZl6 nuBqYOzCBn3uVtXwJMTPwanPEek8VXQ= X-Google-Smtp-Source: AGRyM1uXQsxs32z/UGYWbc6C54OE0fAhSrD/HZ5ulNk4vTDQTPhDUYUNbUKjeIjcMrDaIqynd13AMA== X-Received: by 2002:a17:906:5a51:b0:72b:5cdf:ed77 with SMTP id my17-20020a1709065a5100b0072b5cdfed77mr14908863ejc.505.1658862445179; Tue, 26 Jul 2022 12:07:25 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 1/2] automation: Remove XEN_CONFIG_EXPERT leftovers Date: Tue, 26 Jul 2022 22:07:00 +0300 Message-Id: <20220726190701.1048824-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220726190701.1048824-1-burzalodowa@gmail.com> References: <20220726190701.1048824-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- Changes in v2: - add Stefano's R-b tag automation/build/README.md | 3 --- automation/scripts/build | 4 ++-- automation/scripts/containerize | 1 - 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 2137957408..00305eed03 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -65,9 +65,6 @@ understands. - CONTAINER_NO_PULL: If set to 1, the script will not pull from docker hub. This is useful when testing container locally. -- XEN_CONFIG_EXPERT: If this is defined in your shell it will be - automatically passed through to the container. - If your docker host has Linux kernel > 4.11, and you want to use containers that run old glibc (for example, CentOS 6 or SLES11SP4), you may need to add diff --git a/automation/scripts/build b/automation/scripts/build index 281f8b1fcc..21b3bc57c8 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -91,6 +91,6 @@ for cfg in `ls ${cfg_dir}`; do echo "Building $cfg" make -j$(nproc) -C xen clean rm -f xen/.config - make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig - make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y + make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig + make -j$(nproc) -C xen done diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 8992c67278..9d4beca4fa 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -101,7 +101,6 @@ exec ${docker_cmd} run \ -v "${CONTAINER_PATH}":/build:rw${selinux} \ -v "${HOME}/.ssh":/root/.ssh:ro \ ${SSH_AUTH_DIR:+-v "${SSH_AUTH_DIR}":/tmp/ssh-agent${selinux}} \ - ${XEN_CONFIG_EXPERT:+-e XEN_CONFIG_EXPERT=${XEN_CONFIG_EXPERT}} \ ${CONTAINER_ARGS} \ -${termint}i --rm -- \ ${CONTAINER} \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 19:07:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 19:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375679.608139 (Exim 4.92) (envelope-from ) id 1oGPtt-0001mN-1g; Tue, 26 Jul 2022 19:07:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375679.608139; Tue, 26 Jul 2022 19:07:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPts-0001mG-VA; Tue, 26 Jul 2022 19:07:24 +0000 Received: by outflank-mailman (input) for mailman id 375679; Tue, 26 Jul 2022 19:07:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPtr-0001mA-HV for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 19:07:23 +0000 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [2a00:1450:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2d8a5a8a-0d16-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 21:07:22 +0200 (CEST) Received: by mail-ej1-x62c.google.com with SMTP id bp15so27845657ejb.6 for ; Tue, 26 Jul 2022 12:07:22 -0700 (PDT) Received: from uni.router.wind (adsl-45.176.58.224.tellas.gr. [176.58.224.45]) by smtp.googlemail.com with ESMTPSA id eg47-20020a05640228af00b0043bbcd94ee4sm8952306edb.51.2022.07.26.12.07.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 12:07:21 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2d8a5a8a-0d16-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LdLrT8Wu/165k8es4dUu/NbOhpow/H7kiPk94jnel3M=; b=OnvHf7vq+Huy178VtcbeI/0he3xDr5OIjys5gnpbn+7mGQFnxzsXcNYjvUkpAB5tLe ZcKLMyIYsufVdwdggGOXZXGp0Zo47PcFkUNFuXNsYgaXAgOQI5RvNAHgm773WRhiNtvT 1wsT/nBKIA9pJs8/nr6oIG5dtF/kqPxm6VKDdP92RUf2l5pv96Jkf7P7FJFkYxA28L/U DQunVhDdslPnAyZj01LMehHoW5u2WY3Fksz/5IFEkAJype3hBzNmuo0sxJG5rnoMXn9P 8+LL84nItGNjdH8IY5woNuFpC9mD0HGRjrV6mlCfbCmUchQsKXc2wRQxTC3e8cNNHL13 Yk5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LdLrT8Wu/165k8es4dUu/NbOhpow/H7kiPk94jnel3M=; b=ezsoCTIZi00YQp/ZSv01kzRasTr1nqxNkfQKOsEsZYh31ruQ15QVAQP4rAofUgzgpD YfR5I3Z0o500AIGW3Y4j3UAw35p+3wk6Ptv3Df5R1/KX0VYYZSxR25zdiQZAJhHFj7Nj FuDjq4WS1ctTZyGeTVh6RCs/89hpJoU7PIFL9eX3gZqRlyPSvd7gvcLAwVe/ghaaRu/m 2N6QkG56i7oByRKriZijOfd+wXcNKJbfP1NF0DGrzKaDTy3BDcSAhiBGQiUeMNMbEwPC M89omQpdZ15oVQ+gr1XgKEMgTdmMn7oT9k0RiyxdauB0wx/QkBL/K+/ulACNLha859j/ X/TA== X-Gm-Message-State: AJIora++Wlm1mlIxcttYXamaRr1skvuCnmtnSkfaqYRMfLO0DskK4Fee 2fA0kXSX8jGx4DyhR2w98YV8i5hFfyI= X-Google-Smtp-Source: AGRyM1vCfVV5xaR/wwAG2DGXZfXXncNYuGlgrfOIX1VTE0qzaT1soom3bCOw7jUTfAeWGDfCe4Ujwg== X-Received: by 2002:a17:907:16a6:b0:72b:5ce6:1f7d with SMTP id hc38-20020a17090716a600b0072b5ce61f7dmr15759083ejc.28.1658862441682; Tue, 26 Jul 2022 12:07:21 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 0/2] Create a test job for testing static memory on qemu Date: Tue, 26 Jul 2022 22:06:59 +0300 Message-Id: <20220726190701.1048824-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series - removes all the references to the XEN_CONFIG_EXPERT environmental variable which is not used anymore - creates a trivial arm64 test job that boots xen on qemu with dom0 and a direct mapped dom0less domu with static memory and verifies that domu's memory ranges are the same as the static memory ranges with which it was configured The static memory test relies on the existing qemu-smoke-arm64.sh script. This script uses the kernel-5.9.9 from the test-artifacts container as domu kernel. This particular kernel does not work with dom0less enhanced enabled. More specifically, domu crashes when it attempts to dereference the xenstore interface which is still uninitialized, So, qemu-smoke-arm64-gcc test, as well as its static memory version, fails. To be able to test, I had to disable dom0less enhanced by adding the following commands to the script. sed -i 's/xen,enhanced "enabled"/xen,enhanced "disabled"/g' binaries/boot.source mkimage -A arm64 -T script -C none -d binaries/boot.source binaries/boot.scr These commands are not part of the patch. Since dom0less enhanced is enabled by default, a newer kernel version would be more appropriate for testing dom0less. Xenia Ragiadakou (2): automation: Remove XEN_CONFIG_EXPERT leftovers automation: arm64: Create a test job for testing static allocation on qemu automation/build/README.md | 3 -- automation/gitlab-ci/test.yaml | 18 +++++++++++ automation/scripts/build | 12 ++++++-- automation/scripts/containerize | 1 - automation/scripts/qemu-smoke-arm64.sh | 42 ++++++++++++++++++++++++-- 5 files changed, 67 insertions(+), 9 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 19:07:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 19:07:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375681.608160 (Exim 4.92) (envelope-from ) id 1oGPty-0002KN-JV; Tue, 26 Jul 2022 19:07:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375681.608160; Tue, 26 Jul 2022 19:07:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPty-0002KG-Gu; Tue, 26 Jul 2022 19:07:30 +0000 Received: by outflank-mailman (input) for mailman id 375681; Tue, 26 Jul 2022 19:07:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGPtx-0001mA-94 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 19:07:29 +0000 Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [2a00:1450:4864:20::632]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 313f4ee2-0d16-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 21:07:28 +0200 (CEST) Received: by mail-ej1-x632.google.com with SMTP id j22so27863737ejs.2 for ; Tue, 26 Jul 2022 12:07:28 -0700 (PDT) Received: from uni.router.wind (adsl-45.176.58.224.tellas.gr. [176.58.224.45]) by smtp.googlemail.com with ESMTPSA id eg47-20020a05640228af00b0043bbcd94ee4sm8952306edb.51.2022.07.26.12.07.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Jul 2022 12:07:27 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 313f4ee2-0d16-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0Ux4cJFi9/ACsXCBrKM47orXeCmFYl/0tvZHbq+8ADQ=; b=IedBqstLflJ+RQBTnGH7SS0+bEthSnRN8uPfkib0G8d0HJVrB9zMg1teW6YSd51fol S9AJBxJ8DytETO93EjR2zrtnNzPw47vwXRz1HK6/St/PRg1ilJ9lcLgU1gU5CLzbsg1I 00qQUT6NsnhXO2rEtbzqQ77FIBdcBL3kR+o+bIIaAjsofGbZmy5FYkx+BdftUOx/t6dH MHjtds6cmu1UJPG1pVQA1A1x4OJoDO6l7moiLdbEx+4KNvwmw3jHj2xes2Mfsas5V+lI 1xKdnNHHgbt5oKPqsVrxo+3exPy4vU/jROq4dxzNCqVf7Kf9unrMrVhYu8n+uUBfnZw/ Aisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0Ux4cJFi9/ACsXCBrKM47orXeCmFYl/0tvZHbq+8ADQ=; b=cCm3SPxnRbo1wIWscF0Ysq7YdXgODBnB43WDNFab9ogoEbBkMXYtw0IVzrrXQ/13qY BTHK864/xEofttn2IPdzCZsr3EYmq9OmoRinASNMsD8mDQX2Re0X0lsHRppih8Q/iX5x CKhsK+rhdthLpg/uBh/f5E8vGEZYn1dcWg9ItXcSEjAmbiHvfl31WyfPVLIMOzx7WON2 2FjDPeoONl5s+U/zNrVUjckOegfKlBuXcg/MtaGcUYALKaWL/HnNqnzVjbuT22y4m+mE CYr11jY0V3UwnKjllqD8SQAj6coATYvIypXuH4Bj5Uu2U61SLJJufgU9ibSnOfus9Q6+ CVag== X-Gm-Message-State: AJIora9MFjZW0ycGqYJHsLo6xPjM9DLVsrHFLZEERhE7lou45cazYGxi W0myrNyYplAnLsabFwtc2Fel4xeEkVA= X-Google-Smtp-Source: AGRyM1t+ZAeZOtA8CtOkuowGI2el9zO/c1e4I/zzw2Zkg9z/Y/aBLp0VmCs06DxE1ilwnwGznEhSag== X-Received: by 2002:a17:906:5a68:b0:72b:3e88:fec1 with SMTP id my40-20020a1709065a6800b0072b3e88fec1mr15092081ejc.741.1658862447975; Tue, 26 Jul 2022 12:07:27 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu Date: Tue, 26 Jul 2022 22:07:01 +0300 Message-Id: <20220726190701.1048824-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220726190701.1048824-1-burzalodowa@gmail.com> References: <20220726190701.1048824-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - enable CONFIG_STATIC_MEMORY for all arm64 builds - use the existing qemu-smoke-arm64.sh with an argument passed for distinguishing between tests, instead of creating a new script - test does not rely on kernel logs but prints a message itself on success - remove the part that enables custom configs for arm64 builds - add comments - adapt commit message automation/gitlab-ci/test.yaml | 18 +++++++++++ automation/scripts/build | 8 +++++ automation/scripts/qemu-smoke-arm64.sh | 42 ++++++++++++++++++++++++-- 3 files changed, 65 insertions(+), 3 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 26bdbcc3ea..6f9f64a8da 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -80,6 +80,24 @@ qemu-smoke-arm64-gcc: tags: - arm64 +qemu-smoke-arm64-gcc-staticmem: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + needs: + - debian-unstable-gcc-arm64 + - kernel-5.9.9-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/build b/automation/scripts/build index 21b3bc57c8..1941763315 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -18,6 +18,14 @@ else make -j$(nproc) -C xen defconfig fi +if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then + echo " +CONFIG_EXPERT=y +CONFIG_UNSUPPORTED=y +CONFIG_STATIC_MEMORY=y" > xen/.config + make -j$(nproc) -C xen olddefconfig +fi + # Save the config file before building because build failure causes the script # to exit early -- bash is invoked with -e. cp xen/.config xen-config diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 53086a5ac7..48513a7832 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -2,6 +2,15 @@ set -ex +test_variant=$1 + +if [[ "${test_variant}" == "static-mem" ]]; then + # Memory range that is statically allocated to DOM1 + domu_base="50000000" + domu_size="10000000" + passed="static-mem test passed" +fi + # Install QEMU export DEBIAN_FRONTENT=noninteractive apt-get -qy update @@ -42,8 +51,22 @@ echo "#!/bin/sh mount -t proc proc /proc mount -t sysfs sysfs /sys -mount -t devtmpfs devtmpfs /dev -/bin/sh" > initrd/init +mount -t devtmpfs devtmpfs /dev" > initrd/init + +if [[ "${test_variant}" == "static-mem" ]]; then + # Verify that DOM1 booted with the expected memory layout by checking the + # contents of the memory entry in /proc/device-tree. + echo " +current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) +expected=\"$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size})\" +if [[ ${expected} == \"\${current}\" ]]; then + echo \"${passed}\" +fi" >> initrd/init +fi + +echo " +/bin/sh" >> initrd/init + chmod +x initrd/init cd initrd find . | cpio --create --format='newc' | gzip > ../binaries/initrd @@ -68,6 +91,12 @@ DOMU_MEM[0]="256" LOAD_CMD="tftpb" UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr"' > binaries/config + +if [[ "${test_variant}" == "static-mem" ]]; then + echo " +DOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config @@ -89,5 +118,12 @@ timeout -k 1 240 \ -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial set -e -(grep -q "^BusyBox" smoke.serial && grep -q "DOM1: BusyBox" smoke.serial) || exit 1 +grep -q "^BusyBox" smoke.serial || exit 1 + +if [[ "${test_variant}" == "static-mem" ]]; then + grep -q "DOM1: ${passed}" smoke.serial || exit 1 +else + grep -q "DOM1: BusyBox" smoke.serial || exit 1 +fi + exit 0 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Tue Jul 26 19:17:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 19:17:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375698.608172 (Exim 4.92) (envelope-from ) id 1oGQ3e-0004cZ-Io; Tue, 26 Jul 2022 19:17:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375698.608172; Tue, 26 Jul 2022 19:17:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQ3e-0004cS-F4; Tue, 26 Jul 2022 19:17:30 +0000 Received: by outflank-mailman (input) for mailman id 375698; Tue, 26 Jul 2022 19:17:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQ3d-0004cI-5b; Tue, 26 Jul 2022 19:17:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQ3d-00085B-16; Tue, 26 Jul 2022 19:17:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQ3c-0006te-P0; Tue, 26 Jul 2022 19:17:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGQ3c-0004fw-OG; Tue, 26 Jul 2022 19:17:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FNo2dX/z55PQ0DGUx0SqqbrQD/vXQwPHLh0vBraX6+E=; b=hmIK90JrPXU5QbTqKcfeYkb8y1 SNvlhCManFbjtd0610DLaY52PVPT5g0FQ3DzjjI8ZEwrchv7I9VsH8RRMtag5g6UgynOepEG0JV5J ZSU9N3z/nkD0KGG2Bn8k/2IXOWyQuz830Ft4L+Pj/Y8mW2g8RQnLYXHH5fjbxKQchBVc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171862: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-arm64-arm64-xl-vhd:guest-start/debian.repeat:fail:heisenbug xen-unstable:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=5707470bf3103ebae43697a7ac2faced6cd35f92 X-Osstest-Versions-That: xen=f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 From: osstest service owner Date: Tue, 26 Jul 2022 19:17:28 +0000 flight 171862 xen-unstable real [real] flight 171869 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171862/ http://logs.test-lab.xenproject.org/osstest/logs/171869/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-vhd 17 guest-start/debian.repeat fail pass in 171869-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171859 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171859 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171859 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171859 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171859 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171859 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171859 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171859 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171859 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171859 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171859 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171859 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171859 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen 5707470bf3103ebae43697a7ac2faced6cd35f92 baseline version: xen f1c719d5cd8ab4d5d4c8df139b9df3c2c47221d1 Last test of basis 171859 2022-07-26 01:54:33 Z 0 days Testing same since 171862 2022-07-26 09:38:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd fail test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f1c719d5cd..5707470bf3 5707470bf3103ebae43697a7ac2faced6cd35f92 -> master From xen-devel-bounces@lists.xenproject.org Tue Jul 26 19:24:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 19:24:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375711.608198 (Exim 4.92) (envelope-from ) id 1oGQAU-0006HQ-Vw; Tue, 26 Jul 2022 19:24:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375711.608198; Tue, 26 Jul 2022 19:24:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQAU-0006Gv-Py; Tue, 26 Jul 2022 19:24:34 +0000 Received: by outflank-mailman (input) for mailman id 375711; Tue, 26 Jul 2022 19:24:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQAT-0006Ce-8C for xen-devel@lists.xen.org; Tue, 26 Jul 2022 19:24:33 +0000 Received: from mail.xenproject.org (mail.xenproject.org [104.130.215.37]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 90de2a88-0d18-11ed-924f-1f966e50362f; Tue, 26 Jul 2022 21:24:31 +0200 (CEST) Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQAC-0008C5-HI; Tue, 26 Jul 2022 19:24:16 +0000 Received: from julieng by xenbits.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGQAC-0002wB-Fy; Tue, 26 Jul 2022 19:24:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 90de2a88-0d18-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Date:Message-Id:Subject:CC:From:To:MIME-Version: Content-Transfer-Encoding:Content-Type; bh=NKD2gL2NTr6m9WCIt6RoJNR++SWs8pJVg7FANzTK5Ag=; b=gVFgv/Msh3fcXBjUlzEP9lbRSS OeJeZ8gDwjyQYlASqiZjYuzlAESrobslthLViPB5fb61H1nAEkOuNmORlhcGCLaFS89SPyd6Bejw6 boirKfmQ/RHNs9TPcrkjhuWaoEc4jxqs6szqgbntW3+Dms7mp76qa5sHvC2xcfE2LiKk=; Content-Type: multipart/mixed; boundary="=separator"; charset="utf-8" Content-Transfer-Encoding: binary MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) To: xen-announce@lists.xen.org, xen-devel@lists.xen.org, xen-users@lists.xen.org, oss-security@lists.openwall.com From: Xen.org security team CC: Xen.org security team Subject: Xen Security Advisory 408 v3 (CVE-2022-33745) - insufficient TLB flush for x86 PV guests in shadow mode Message-Id: Date: Tue, 26 Jul 2022 19:24:16 +0000 --=separator Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Xen Security Advisory CVE-2022-33745 / XSA-408 version 3 insufficient TLB flush for x86 PV guests in shadow mode UPDATES IN VERSION 3 ==================== Update hash for metadata file. ISSUE DESCRIPTION ================= For migration as well as to work around kernels unaware of L1TF (see XSA-273), PV guests may be run in shadow paging mode. To address XSA-401, code was moved inside a function in Xen. This code movement missed a variable changing meaning / value between old and new code positions. The now wrong use of the variable did lead to a wrong TLB flush condition, omitting flushes where such are necessary. IMPACT ====== The known (observed) impact would be a Denial of Service (DoS) affecting the entire host, due to running out of memory. Privilege escalation and information leaks cannot be ruled out. VULNERABLE SYSTEMS ================== All versions of Xen with the XSA-401 fixes applied are vulnerable. Only x86 PV guests can trigger this vulnerability, and only when running in shadow mode. Shadow mode would be in use when migrating guests or as a workaround for XSA-273 (L1TF). MITIGATION ========== Not running x86 PV guests will avoid the vulnerability. CREDITS ======= This issue was discovered by Charles Arnold of SUSE. RESOLUTION ========== Applying the appropriate attached patch resolves this issue. Note that patches for released versions are generally prepared to apply to the stable branches, and may not apply cleanly to the most recent release tarball. Downstreams are encouraged to update to the tip of the stable branch before applying these patches. xsa408.patch xen-unstable - Xen 4.14.x xsa408-4.13.patch Xen 4.13.x $ sha256sum xsa408* 9411b563c71445d2c95e36aba9d71fa3b9341f0230e4b3e2549a63292df11669 xsa408.meta f49cb67842c7576f1d59b965331956a9fa1f529a8e2da3531d7ebc4eb3f079b3 xsa408.patch 26871efbd3f834dd4af4fbab6f2cb09a83c509e49894f025ee656071419ed995 xsa408-4.13.patch $ DEPLOYMENT DURING EMBARGO ========================= Deployment of the patches and/or mitigations described above (or others which are substantially similar) is permitted during the embargo, even on public-facing systems with untrusted guest users and administrators. But: Distribution of updated software is prohibited (except to other members of the predisclosure list). Predisclosure list members who wish to deploy significantly different patches and/or mitigations, please contact the Xen Project Security Team. (Note: this during-embargo deployment notice is retained in post-embargo publicly released Xen Project advisories, even though it is then no longer applicable. This is to enable the community to have oversight of the Xen Project Security Team's decisionmaking.) For more information about permissible uses of embargoed information, consult the Xen Project community's agreed Security Policy: http://www.xenproject.org/security-policy.html -----BEGIN PGP SIGNATURE----- iQFABAEBCAAqFiEEI+MiLBRfRHX6gGCng/4UyVfoK9kFAmLgPzsMHHBncEB4ZW4u b3JnAAoJEIP+FMlX6CvZT5cIAKtisZZvdcSolZ+RHFzAdVEP2lbEW2TyoG6oy0st kMsV/ZSabthow9PiUp48DoZOXSIh/7hn2qyXqx5X0VYjiWOISVRCldm5g4p0+tA/ GN6FztbRR1GargLkvtuWj38K9E7HIqfBRFLbtJD6X97NFSAPeNNZg8nqQPqwkhK+ yeGBjPPO5pTjNwsRt91A1qEttTPjbBpipEcit/qjqqCBxX6NT/pYSE5Ltn2OHm38 eYM25X901rJl0rPsyOeUN312FAL0bEunKVKJbiNcHVBZoR37YoJ5HE5trDxoxPrz XYJdR7gzcB028lbGU4jt9FVHdYCh0htWpdpdWci4A3DCH7U= =C02g -----END PGP SIGNATURE----- --=separator Content-Type: application/octet-stream; name="xsa408.meta" Content-Disposition: attachment; filename="xsa408.meta" Content-Transfer-Encoding: base64 ewogICJYU0EiOiA0MDgsCiAgIlN1cHBvcnRlZFZlcnNpb25zIjogWwogICAg Im1hc3RlciIsCiAgICAiNC4xNiIsCiAgICAiNC4xNSIsCiAgICAiNC4xNCIs CiAgICAiNC4xMyIKICBdLAogICJUcmVlcyI6IFsKICAgICJ4ZW4iCiAgXSwK ICAiUmVjaXBlcyI6IHsKICAgICI0LjEzIjogewogICAgICAiUmVjaXBlcyI6 IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJsZVJlZiI6ICJm ODYxNGM3MTUzZjk1ZGNkMWExMzIwMTU2Nzg3ZGJjNTMyNWZkOTQ2IiwKICAg ICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0Y2hlcyI6IFsK ICAgICAgICAgICAgInhzYTQwOC00LjEzLnBhdGNoIgogICAgICAgICAgXQog ICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICI0LjE0IjogewogICAgICAi UmVjaXBlcyI6IHsKICAgICAgICAieGVuIjogewogICAgICAgICAgIlN0YWJs ZVJlZiI6ICI4N2Q5MGQ1MTFjODc0Nzc2MDljYzRiOGM4ODg2NmJmYmU5OTdk YTQ2IiwKICAgICAgICAgICJQcmVyZXFzIjogW10sCiAgICAgICAgICAiUGF0 Y2hlcyI6IFsKICAgICAgICAgICAgInhzYTQwOC5wYXRjaCIKICAgICAgICAg IF0KICAgICAgICB9CiAgICAgIH0KICAgIH0sCiAgICAiNC4xNSI6IHsKICAg ICAgIlJlY2lwZXMiOiB7CiAgICAgICAgInhlbiI6IHsKICAgICAgICAgICJT dGFibGVSZWYiOiAiMzViZjkxZDMwZjFhNDgwZGNmNWJmZDk5Yjc5Mzg0YjJi MjgzZGE3ZiIsCiAgICAgICAgICAiUHJlcmVxcyI6IFtdLAogICAgICAgICAg IlBhdGNoZXMiOiBbCiAgICAgICAgICAgICJ4c2E0MDgucGF0Y2giCiAgICAg ICAgICBdCiAgICAgICAgfQogICAgICB9CiAgICB9LAogICAgIjQuMTYiOiB7 CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAgICAgICAg ICAiU3RhYmxlUmVmIjogIjBhNTM4N2EwMTE2NWI0NmM4Yzg1ZTdmN2UyZGRi ZTYwYTdmNWRiNDQiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwKICAgICAg ICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDA4LnBhdGNoIgog ICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfSwKICAgICJtYXN0 ZXIiOiB7CiAgICAgICJSZWNpcGVzIjogewogICAgICAgICJ4ZW4iOiB7CiAg ICAgICAgICAiU3RhYmxlUmVmIjogIjM1NWNhYTllZjI5ZmQ0YmNkZjQ4YmMy NjNlNmNhM2IyNDM5MjQ5MGIiLAogICAgICAgICAgIlByZXJlcXMiOiBbXSwK ICAgICAgICAgICJQYXRjaGVzIjogWwogICAgICAgICAgICAieHNhNDA4LnBh dGNoIgogICAgICAgICAgXQogICAgICAgIH0KICAgICAgfQogICAgfQogIH0K fQ== --=separator Content-Type: application/octet-stream; name="xsa408.patch" Content-Disposition: attachment; filename="xsa408.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvbW06IGNvcnJlY3QgVExCIGZsdXNoIGNvbmRpdGlvbiBpbiBfZ2V0 X3BhZ2VfdHlwZSgpCgpXaGVuIHRoaXMgbG9naWMgd2FzIG1vdmVkLCBpdCB3 YXMgbW92ZWQgYWNyb3NzIHRoZSBwb2ludCB3aGVyZSBueCBpcwp1cGRhdGVk IHRvIGhvbGQgdGhlIG5ldyB0eXBlIGZvciB0aGUgcGFnZS4gSU9XIG9yaWdp bmFsbHkgaXQgd2FzCmVxdWl2YWxlbnQgdG8gdXNpbmcgeCAoYW5kIHBlcmhh cHMgeCB3b3VsZCBiZXR0ZXIgaGF2ZSBiZWVuIHVzZWQpLCBidXQKbm93IGl0 IGlzbid0IGFueW1vcmUuIFN3aXRjaCB0byB1c2luZyB4LCB3aGljaCB0aGVu IGJyaW5ncyB0aGluZ3MgaW4KbGluZSBhZ2FpbiB3aXRoIHRoZSBzbGlnaHRs eSBlYXJsaWVyIGNvbW1lbnQgdGhlcmUgKG5vdykgdGFsa2luZyBhYm91dAp0 cmFuc2l0aW9ucyBfZnJvbV8gd3JpdGFibGUuCgpJIGhhdmUgdG8gY29uZmVz cyB0aG91Z2ggdGhhdCBJIGNhbm5vdCBtYWtlIGEgZGlyZWN0IGNvbm5lY3Rp b24gYmV0d2Vlbgp0aGUgcmVwb3J0ZWQgb2JzZXJ2ZWQgYmVoYXZpb3Igb2Yg Z3Vlc3RzIGxlYXZpbmcgc2V2ZXJhbCBwYWdlcyBhcm91bmQKd2l0aCBwZW5k aW5nIGdlbmVyYWwgcmVmZXJlbmNlcyBhbmQgdGhlIGNoYW5nZSBoZXJlLiBS ZXBlYXRlZCB0ZXN0aW5nLApuZXZlcnRoZWxlc3MsIGNvbmZpcm1zIHRoZSBy ZXBvcnRlZCBpc3N1ZSBpcyBubyBsb25nZXIgdGhlcmUuCgpUaGlzIGlzIENW RS0yMDIyLTMzNzQ1IC8gWFNBLTQwOC4KClJlcG9ydGVkLWJ5OiBDaGFybGVz IEFybm9sZCA8Y2Fybm9sZEBzdXNlLmNvbT4KRml4ZXM6IDhjYzUwMzZiYzM4 NSAoIng4Ni9wdjogRml4IEFCQUMgY21weGNoZygpIHJhY2UgaW4gX2dldF9w YWdlX3R5cGUoKSIpClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Ci0tLQpJJ2QgYmUgaGFwcHkgdG8g dXBkYXRlIHRoZSBkZXNjcmlwdGlvbiB0byBhY3R1YWxseSBjb25uZWN0IHRo aW5ncywgYXMKbG9uZyBhcyBzb21lb25lIGNhbiBnaXZlIHNvbWUgcGxhdXNp YmxlIGV4cGxhbmF0aW9uLgoKLS0tIGEveGVuL2FyY2gveDg2L21tLmMKKysr IGIveGVuL2FyY2gveDg2L21tLmMKQEAgLTMwMzgsNyArMzAzOCw3IEBAIHN0 YXRpYyBpbnQgX2dldF9wYWdlX3R5cGUoc3RydWN0IHBhZ2VfaW4KICAgICAg ICAgICAgIGlmICggdW5saWtlbHkoIWNwdW1hc2tfZW1wdHkobWFzaykpICYm CiAgICAgICAgICAgICAgICAgIC8qIFNoYWRvdyBtb2RlOiB0cmFjayBvbmx5 IHdyaXRhYmxlIHBhZ2VzLiAqLwogICAgICAgICAgICAgICAgICAoIXNoYWRv d19tb2RlX2VuYWJsZWQoZCkgfHwKLSAgICAgICAgICAgICAgICAgICgobngg JiBQR1RfdHlwZV9tYXNrKSA9PSBQR1Rfd3JpdGFibGVfcGFnZSkpICkKKyAg ICAgICAgICAgICAgICAgICgoeCAmIFBHVF90eXBlX21hc2spID09IFBHVF93 cml0YWJsZV9wYWdlKSkgKQogICAgICAgICAgICAgewogICAgICAgICAgICAg ICAgIHBlcmZjX2luY3IobmVlZF9mbHVzaF90bGJfZmx1c2gpOwogICAgICAg ICAgICAgICAgIC8qCg== --=separator Content-Type: application/octet-stream; name="xsa408-4.13.patch" Content-Disposition: attachment; filename="xsa408-4.13.patch" Content-Transfer-Encoding: base64 RnJvbTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpTdWJqZWN0 OiB4ODYvbW06IGNvcnJlY3QgVExCIGZsdXNoIGNvbmRpdGlvbiBpbiBfZ2V0 X3BhZ2VfdHlwZSgpCgpXaGVuIHRoaXMgbG9naWMgd2FzIG1vdmVkLCBpdCB3 YXMgbW92ZWQgYWNyb3NzIHRoZSBwb2ludCB3aGVyZSBueCBpcwp1cGRhdGVk IHRvIGhvbGQgdGhlIG5ldyB0eXBlIGZvciB0aGUgcGFnZS4gSU9XIG9yaWdp bmFsbHkgaXQgd2FzCmVxdWl2YWxlbnQgdG8gdXNpbmcgeCAoYW5kIHBlcmhh cHMgeCB3b3VsZCBiZXR0ZXIgaGF2ZSBiZWVuIHVzZWQpLCBidXQKbm93IGl0 IGlzbid0IGFueW1vcmUuIFN3aXRjaCB0byB1c2luZyB4LCB3aGljaCB0aGVu IGJyaW5ncyB0aGluZ3MgaW4KbGluZSBhZ2FpbiB3aXRoIHRoZSBzbGlnaHRs eSBlYXJsaWVyIGNvbW1lbnQgdGhlcmUgKG5vdykgdGFsa2luZyBhYm91dAp0 cmFuc2l0aW9ucyBfZnJvbV8gd3JpdGFibGUuCgpJIGhhdmUgdG8gY29uZmVz cyB0aG91Z2ggdGhhdCBJIGNhbm5vdCBtYWtlIGEgZGlyZWN0IGNvbm5lY3Rp b24gYmV0d2Vlbgp0aGUgcmVwb3J0ZWQgb2JzZXJ2ZWQgYmVoYXZpb3Igb2Yg Z3Vlc3RzIGxlYXZpbmcgc2V2ZXJhbCBwYWdlcyBhcm91bmQKd2l0aCBwZW5k aW5nIGdlbmVyYWwgcmVmZXJlbmNlcyBhbmQgdGhlIGNoYW5nZSBoZXJlLiBS ZXBlYXRlZCB0ZXN0aW5nLApuZXZlcnRoZWxlc3MsIGNvbmZpcm1zIHRoZSBy ZXBvcnRlZCBpc3N1ZSBpcyBubyBsb25nZXIgdGhlcmUuCgpUaGlzIGlzIENW RS0yMDIyLTMzNzQ1IC8gWFNBLTQwOC4KClJlcG9ydGVkLWJ5OiBDaGFybGVz IEFybm9sZCA8Y2Fybm9sZEBzdXNlLmNvbT4KRml4ZXM6IDhjYzUwMzZiYzM4 NSAoIng4Ni9wdjogRml4IEFCQUMgY21weGNoZygpIHJhY2UgaW4gX2dldF9w YWdlX3R5cGUoKSIpClNpZ25lZC1vZmYtYnk6IEphbiBCZXVsaWNoIDxqYmV1 bGljaEBzdXNlLmNvbT4KUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CgotLS0gYS94ZW4vYXJjaC94ODYv bW0uYworKysgYi94ZW4vYXJjaC94ODYvbW0uYwpAQCAtMzA4MCw3ICszMDgw LDcgQEAgc3RhdGljIGludCBfZ2V0X3BhZ2VfdHlwZShzdHJ1Y3QgcGFnZV9p bgogICAgICAgICAgICAgaWYgKCB1bmxpa2VseSghY3B1bWFza19lbXB0eSht YXNrKSkgJiYKICAgICAgICAgICAgICAgICAgLyogU2hhZG93IG1vZGU6IHRy YWNrIG9ubHkgd3JpdGFibGUgcGFnZXMuICovCiAgICAgICAgICAgICAgICAg ICghc2hhZG93X21vZGVfZW5hYmxlZChkKSB8fAotICAgICAgICAgICAgICAg ICAgKChueCAmIFBHVF90eXBlX21hc2spID09IFBHVF93cml0YWJsZV9wYWdl KSkgKQorICAgICAgICAgICAgICAgICAgKCh4ICYgUEdUX3R5cGVfbWFzaykg PT0gUEdUX3dyaXRhYmxlX3BhZ2UpKSApCiAgICAgICAgICAgICB7CiAgICAg ICAgICAgICAgICAgcGVyZmNfaW5jcihuZWVkX2ZsdXNoX3RsYl9mbHVzaCk7 CiAgICAgICAgICAgICAgICAgZmx1c2hfdGxiX21hc2sobWFzayk7Cg== --=separator-- From xen-devel-bounces@lists.xenproject.org Tue Jul 26 20:11:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 20:11:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375796.608237 (Exim 4.92) (envelope-from ) id 1oGQuB-0005bZ-Up; Tue, 26 Jul 2022 20:11:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375796.608237; Tue, 26 Jul 2022 20:11:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQuB-0005bS-Ry; Tue, 26 Jul 2022 20:11:47 +0000 Received: by outflank-mailman (input) for mailman id 375796; Tue, 26 Jul 2022 20:11:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQuA-0005bI-BM; Tue, 26 Jul 2022 20:11:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQuA-0000uq-76; Tue, 26 Jul 2022 20:11:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGQu9-0002kw-T3; Tue, 26 Jul 2022 20:11:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGQu9-0001iY-Sb; Tue, 26 Jul 2022 20:11:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=B+3+LthW7zCRnRjlbtqIaSzRUXYxar8fKekc9NkqWxU=; b=DIivaOfj3a+2MNpJgiCoGVNYB+ e1t56a5YU91i7/HW2DlkQbPK9lcVldSp24tljqNgM8uKdwMePkN/0Yci6Z9aliFcmQqLB11YAxXSi 3ilG6fXs1gM9m8vOKQzmC/JMZG1AIAmaZEz5k+/1EcNpJqReNCVDqy9kqzUqq9pWLNy0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171870: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b1f0183e5067fbcb87517795e27929982b2404fb X-Osstest-Versions-That: xen=a9949efb288fd6e21bbaf9d5826207c7c41cda27 From: osstest service owner Date: Tue, 26 Jul 2022 20:11:45 +0000 flight 171870 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171870/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen b1f0183e5067fbcb87517795e27929982b2404fb baseline version: xen a9949efb288fd6e21bbaf9d5826207c7c41cda27 Last test of basis 171864 2022-07-26 13:01:53 Z 0 days Testing same since 171870 2022-07-26 17:00:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a9949efb28..b1f0183e50 b1f0183e5067fbcb87517795e27929982b2404fb -> smoke From xen-devel-bounces@lists.xenproject.org Tue Jul 26 23:33:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Tue, 26 Jul 2022 23:33:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375808.608248 (Exim 4.92) (envelope-from ) id 1oGU3E-0001as-F5; Tue, 26 Jul 2022 23:33:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375808.608248; Tue, 26 Jul 2022 23:33:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGU3E-0001al-C9; Tue, 26 Jul 2022 23:33:20 +0000 Received: by outflank-mailman (input) for mailman id 375808; Tue, 26 Jul 2022 23:33:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGU3C-0001ae-86 for xen-devel@lists.xenproject.org; Tue, 26 Jul 2022 23:33:18 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 515b8b31-0d3b-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 01:33:14 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26QKn4up024544; Tue, 26 Jul 2022 23:31:41 GMT Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg940qqnv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jul 2022 23:31:40 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26QMg2Ha006242; Tue, 26 Jul 2022 23:31:39 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2168.outbound.protection.outlook.com [104.47.58.168]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hh65c6394-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Jul 2022 23:31:39 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by CH0PR10MB5260.namprd10.prod.outlook.com (2603:10b6:610:c4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Tue, 26 Jul 2022 23:31:37 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%5]) with mapi id 15.20.5458.025; Tue, 26 Jul 2022 23:31:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 515b8b31-0d3b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=b6wO/3pdjGedZMm568xlqM2fZJwXioknbMs8JiVAnn0=; b=mY0C3SzRLUXhjuGmRGzknUUjX8rUQEUBXgatvEsC7WBZtV4vlY43bsDlsYz7JUbAoA9x X1rpgoqjcJduUmt3R4p1LnQcMtwro1mRToVBhLnC0hXNeBHnVFcUD5PhPk1fVU6KZ7cR Kv7ad8N96LtQQyUa2KbTVMxwVM5CvCPLyO40PInnjTPPmCzgMqUtCu7QZeZ6Up9sfN1q 5Nq72kIYMAi/ZI9PdQVklPATeCtnxvkKBgMYGHlUZyYY3+GXItNq8hNqGwf4Mlw4rwsi pSOzYvp+NF2NvCyy17izAigPXZFqI/GgCelNbYKR2rFRY8W3yRW7NcUO4n3kl0PRJB3H jQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+2X0JzZzsnHRHgXINMMFFu6uo//+HMRucI6ZhjmwWI4t2Vuvlw2FjjRz6JHSUf1TviYx4QBBPLqvz9QlpxfvL+H5DQEzvN98Oth5X+04dHPpzh2ZemgzpcwyuNyLyloI7fj5+NCiIS0lTVESGW4iOJ11dZo7osI8RJ8obZFaaWGBC1g2Zb/NSuNkxyZ42hnNtT9vB9OXPVEn4qXsdDMNcaiNvsYLo1qZ3bgZwbVTIT0QBUmKle/4VTGo+5XmRuBETgepR/eu9+hg7POG7hO3DgVFtqtnm9SEOU0U6OEspM6dpr4hvACNwBBtw4YBZwniuctyNvSEt5LfcDAhAth6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b6wO/3pdjGedZMm568xlqM2fZJwXioknbMs8JiVAnn0=; b=Tw99YD/ZMNKXaDiFzBMI3tBAjrPS6qOqJTHweiPqxapiO3ra7NY1IQVb+onptM0/NXYNZgA2EmaLgM3MeyHWD2Df0LmyWY/MEtNaJq2emvp2M50bglGWUV8ZSTFg7WiqF+SIdqgVjQJXsa2sGW9fDcQ9SAkgxs4vz/HF8kZoLiushu0cg6zvYlcM1Rdt56sJ9HCVw+8lFFhQzFqHQdTWTDNCBZ6PVS1KX9yYeu0u8BxSVH3iibcBup8rH+ke++ow+hyStFvM5hw/iEQ2mVpOm4ZiaWO2fPtqMWC+KoE+SG5/QJh2SLOR7l1bskf2UjYjFF/VfqGziRr1QVAemZDGyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b6wO/3pdjGedZMm568xlqM2fZJwXioknbMs8JiVAnn0=; b=oVgw7SnTwaZ5+aDT4BAGkZO5zkV5kLLl1DjDPvjou4QJDHlCJRDp0BvT04L6ALf3fa6HCX1FchAfpLBl4UY/Tf4psshlrIqtBevtcsaXNUMEvgVzJALwqlC+H+dttcy6nCxmO5fJwqteyFOrdo6T+WkYaLTvAW1FUhbCJsCx0No= Message-ID: Date: Tue, 26 Jul 2022 19:31:33 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane , LKML Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , xen-devel@lists.xenproject.org References: <20220726125657.12151-1-jane.malalane@citrix.com> From: Boris Ostrovsky In-Reply-To: <20220726125657.12151-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA0PR11CA0130.namprd11.prod.outlook.com (2603:10b6:806:131::15) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0123e62b-c3ef-4dbe-75ae-08da6f5efc3a X-MS-TrafficTypeDiagnostic: CH0PR10MB5260:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XvWQC2Az8/IdCmk2GttLKMkToRrHZpqOehE89Qf3X4mQ8MfJUPq1bA3DQ7yufvWITg56UsNXAuXhf/11wWVcIdMsCsgmPlaYGNci5Krncy+p9dr439DKAi0hFU1zUJQJ43Ca3zj6aCc6I3oMWQIgATx/x636npFw56cGZWV2Z5cZCbMsQwsEesMP/DkpMz6IlAyCA92r8V7By+imGydq+UtZpXl1ZdhHf8u8QSTPFDPpdjHOp7iwSRbc9IXF+Qh+hLCiKT6uVH7s9wJ2w8h7kTay3KTp+e2soBzgH3svHXhRDo82Mv8C2d8eJfvP28EOPp68CnxO62ijEl2GEarDdXtKQQ1xZfqiaV8plTZ+ApS7yzbbLG0arfaneWST3OYL4IgNgSVLChyBu1KBliHHOwNHpFlawVgWhL1ZlaHTsu8PuYVpeS9a2/XUD9SGbO5fS1aS6sNzTwBxwT4Q7DXBWlKrUlXK+euGyvSSZoB6XB5nJTkjiCb/doBgSWfx/54x4erosae/r7mmCWDNBxw/ObyE/nEsIhD7UKrJ9psPtPtpynHh8IXYWzq8Mbh3CQQujqQteiBxxEHCcWedKOHvZPo1dEAAORBdoWpBWaucF9s3rVnXZtZpE5fmycZmGUb/Yq5IzyZd5yKGm/ic/tiQ4Fdrv/r77HUBlcBD3Mrj/6Wasf29HCR6MeFH8Cp94t1yOPci+r9Z7miihscdQ/KxO8ffpquCmGUSlqMtX/crb094j6bMwd5Z7R07J1RYcnLT+lX+9UDzJQaBM5LFQsT4bQ7QRC23jSGMnRTh8KKk2y0xzQfI4vOK1j5upUkKpKoNpk7rhRxPczrbQ6pdNmqggg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(136003)(39860400002)(396003)(366004)(6506007)(41300700001)(36756003)(6666004)(38100700002)(186003)(2616005)(54906003)(316002)(31686004)(2906002)(110136005)(86362001)(31696002)(4326008)(66556008)(8676002)(6486002)(44832011)(53546011)(66946007)(66476007)(7416002)(5660300002)(478600001)(8936002)(6512007)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SjE5cjN3UXFxd2FHOUd4dGVEZHZVdmltK1NoWHV5MVozdGJRVzBINnhoY29R?= =?utf-8?B?ajlXR3MvdXlaOCtaN3VLaitNRWpueU1jd29OdVF4RFhML2tLeHNwOWtFVmdr?= =?utf-8?B?bldGUEdlV0tORWFiMUF6aXUxSzBOOVhXRVRZc1llQWl5VVE1ZG1CWHNKelo0?= =?utf-8?B?RnRwUHV1emdjK2FXWkc1ZThPenkrRkpJY3NDSWhSSnJySkt4aUluSGk1S0tV?= =?utf-8?B?UHFlUmNIa09aYjdnSzUzTUZWRXNab25KYkNCZ0txRlphK1BXSHpOcVNoVHFt?= =?utf-8?B?RmY4cUpqRTY0UGd5eVlsODY0ZVIvLzk5RzNqT1ordFFRc2tOelYvUFdPajY4?= =?utf-8?B?QXlPa3FZbVRySFFIams4WHpZdWdQOU13OERoRUZTOEk4YzNJVTNxVDNVS2JF?= =?utf-8?B?bko3dlZ3MnBvcWkzcTF3Qm95SDNMeXJ6cGN3N3JoUlh2TFlRc2swYmY2Rmsy?= =?utf-8?B?eUJKbU96K2tRY0FOQi95b21nMm1KZ1BtMk9mYm14Nm9EZ0tsdEpyMlBLbjBK?= =?utf-8?B?R0lGQjlGaG0zQWFkNUFWbGZCR2tXOStFemM2R0pTUnBHNmMxdzhDNHdNWmNY?= =?utf-8?B?RXBpZTlOdzBzR3d6OEMyS0NkZmlZT0hkY3ZuUVROZ3ZjWVdKVWZaOEU3ZGQ4?= =?utf-8?B?ZjdLczU5QkJodUY2YkppYlViaGJpQkFraE5jUnJBdDdMaVZxcXRCRG55V2h5?= =?utf-8?B?ZmpLdmg2eXJ1WkNuQXJXTUdqS1BGVHJsQW5ZZk53MFp6dVhvMk1mcW5QMDVt?= =?utf-8?B?RFZOeUVDQ1FhOGtJQ0dNeVRNdkdyOVNabWNoRS9oZHQwQWE5MjZON0wzNlJP?= =?utf-8?B?MFdPcnp5TDBnQjdUeGxMODNDbThaWnhHNVVIaE4yWG0zYnowbkR0Mk92UUdY?= =?utf-8?B?R3R3TzYwY3lIV1JBcmo3U1NUcVQ0cVhRWHZBTW5uakZUOEZLYVMwa29IMjh6?= =?utf-8?B?dzYvdU9PREhXYmNETU0zTnRnS0JMR09sNlJjM1JWQld0S1FibG9IOHZPdmxO?= =?utf-8?B?L0JzNjVhZDd5MzZKUjhYai95WU5DTlNvUjFrc1l1K1FMQ0kyanZpOGFRN282?= =?utf-8?B?b1JUMzZVQ3NZSHpPVmNLMWczWnVWWmhjSmtGSjU0ZThhLzlYSjBWOElqY1Vn?= =?utf-8?B?RUl3aVNqSzRyMU11UE9EUVF0cXdIamJCd1dXd2Y3SmpLekV6TVZJS01FbEdC?= =?utf-8?B?R2ZwRUVLSUFaMWxnelVvblp2d052OXBYM3B3Slp3THYzZ0NYMTF2V3F1MkFo?= =?utf-8?B?RDhyK1R1ZEhQM1BvaTFUa2F3NnFTY1hnV1NzTDZTNEFINHBXakZCQm1KS29V?= =?utf-8?B?NkVCbjRRcTR1ZnFsOUE5M29tWDZnTkRkdkNPOGdjanVmbUF2VmI5Y2pONHl3?= =?utf-8?B?TW9JUEFvZXNoS2xtTm1LNWxLYkx5dWh2NmY2cURyNWUwdjM3Q0F6Q0ZHZDdm?= =?utf-8?B?SW5JTGhiSFd2cEk0ZWhhcGszVHQ2YUNHcE95ejVxZ1Q0WEIzRG1wWnJNMlRD?= =?utf-8?B?UzAwcGdldVBYS0N1SG0yMVdWeWJ1UUV4bFlMc2w4enRFT2RaMlptb2xrSHow?= =?utf-8?B?ei80T3NGRG9pOXFzVFpSZExyUXJBY1dMdkwxNWtOVlROUzdtQ2NCMDhoUHFP?= =?utf-8?B?Nm9RaU9DYmthQ0lSZkdxV0RVV1RtTVZsTnlUbDN2Qy9FRmlDVEdESXlEQzk5?= =?utf-8?B?ZjRlUnJWdG9QeTVLZ3poU04xcE4vZnZkT1hXbzg2RVpTNjJRSEdmVTNndG9j?= =?utf-8?B?OFpOTzM1ZHRqeEIzejhUUStwRUYrK2w4OVdwTmVxdHEwazl3N1lJKzZsRnNQ?= =?utf-8?B?SStSRjVtVmw0TG44YU9NdHROWWg1Vm9RSkNpYzRXUmtJQVVESEhIYWFUeElv?= =?utf-8?B?M2prYndSTE9Selp0NnVSbnE4Y0dFdDhHZWlOaEd1SzBnN3gvMEh1RnB2alBE?= =?utf-8?B?Y2dwOG12UHVQWmtidjNtd0FCSEpyRG4zNk1hVjBtT1dVYWJuT1JXSkZvV2dz?= =?utf-8?B?eFA5eXhIb2kxS3daT0s4Y3RVNS9SYzNpVjFodkwzaXZjbjhpK2tDT053MHBs?= =?utf-8?B?YnNRcnlJaUg1dWlmcHFlM1hmMHp6enJ5NVpiQzB3TG04TUVuVFV6NzYxV3d0?= =?utf-8?B?NWdFVGtmWmtKRzlNZ2VDKzNQNDhncm9IZG5Bd0dJaXM5U0RnMmEyWXhrOVV2?= =?utf-8?B?VWc9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0123e62b-c3ef-4dbe-75ae-08da6f5efc3a X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2022 23:31:37.7363 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UkxT0vvuYbbA0d9A+baZevCP+EUoo7tuHTlT4EFGQ9sNvVrOhkTDwWFj0cM6fD8e0SyotLKiBYB3WTj0hg6v/RI9WaeY78vGYEhHqplQfMM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5260 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-26_07,2022-07-26_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0 spamscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207260089 X-Proofpoint-GUID: Ul6hWfnwxE-yWm59F8N7TnJNRPUNyOHC X-Proofpoint-ORIG-GUID: Ul6hWfnwxE-yWm59F8N7TnJNRPUNyOHC On 7/26/22 8:56 AM, Jane Malalane wrote: > > +/* Setup per-vCPU vector-type callbacks and trick toolstack to think > + * we are enlightened. If this setup is unavailable, fallback to the > + * global vector-type callback. */ Comment style. > +static __init void xen_init_setup_upcall_vector(void) > +{ > + unsigned int cpu = 0; Unnecessary variable. > + > + if (!xen_have_vector_callback) > + return; > + > + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && > + !xen_set_upcall_vector(cpu) && !xen_set_callback_via(1)) > + xen_percpu_upcall = true; > + else if (xen_feature(XENFEAT_hvm_callback_vector)) > + xen_setup_callback_vector(); > + else > + xen_have_vector_callback = false; > +} > + > +int xen_set_upcall_vector(unsigned int cpu) > +{ > + int rc; > + xen_hvm_evtchn_upcall_vector_t op = { > + .vector = HYPERVISOR_CALLBACK_VECTOR, > + .vcpu = per_cpu(xen_vcpu_id, cpu), > + }; > + > + rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op); > + if (rc) > + return rc; > + > + if (!cpu) A comment (e.g. "Let toolstack know that we are enlightened." or something along these lines) would be useful here. -boris > + rc = xen_set_callback_via(1); > + From xen-devel-bounces@lists.xenproject.org Wed Jul 27 00:10:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 00:10:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375815.608258 (Exim 4.92) (envelope-from ) id 1oGUdL-0006uk-Tb; Wed, 27 Jul 2022 00:10:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375815.608258; Wed, 27 Jul 2022 00:10:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGUdL-0006ud-Qt; Wed, 27 Jul 2022 00:10:39 +0000 Received: by outflank-mailman (input) for mailman id 375815; Wed, 27 Jul 2022 00:10:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGUdK-0006uX-Gl for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 00:10:38 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8973a7e7-0d40-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 02:10:36 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D278661723; Wed, 27 Jul 2022 00:10:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1919C433D7; Wed, 27 Jul 2022 00:10:33 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8973a7e7-0d40-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658880634; bh=ERe/UoPccwHe1lujJO8w2fdoWuNzcQ22xInflxw3VrU=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=OZoyd5Sv3L2P4ZILtptpRRgSTmX3QKllHNCSJeb5IX8ABZGnUn1Dmj4h+5svCTFOX yBpSo6hzvDlB6b3VcJUttuBmQxLTbCunhN2C8vv2BibDHwRw7Rgo2LyM7LFpXnFHOJ m8omy3eTWtJQiSl77RDUIT4lZraEAzor8VLe7YlENnQaycvk/gaxT2FHhufLiNVb1M 5fdqLWPQxaM0MRt7Pd6wg1fElqI/c9mbsI826hGR8JLET5DNlFeaHSU2K0v5mJi9zj KV2VjsWCitr5AruRgzVKKewW2e0mnix9BqdQIfxV/8SdRKre2nVmGNq009+V84rvzp HubHPd3BbcM9g== Date: Tue, 26 Jul 2022 17:10:32 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Xenia Ragiadakou Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation In-Reply-To: <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> Message-ID: References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-26634204-1658880634=:4648" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-26634204-1658880634=:4648 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Tue, 26 Jul 2022, Jan Beulich wrote: > On 26.07.2022 02:33, Stefano Stabellini wrote: > > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > >> On 7/25/22 09:32, Jan Beulich wrote: > >>> On 24.07.2022 19:20, Xenia Ragiadakou wrote: > >>>> On 7/7/22 10:55, Jan Beulich wrote: > >>>>> On 07.07.2022 09:27, Xenia Ragiadakou wrote: > >>>>>> On 7/6/22 11:51, Jan Beulich wrote: > >>>>>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: > >>>>>>>> On 7/6/22 10:10, Jan Beulich wrote: > >>>>>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: > >>>>>>>>>> The function idle_loop() is referenced only in domain.c. > >>>>>>>>>> Change its linkage from external to internal by adding the > >>>>>>>>>> storage-class > >>>>>>>>>> specifier static to its definitions. > >>>>>>>>>> > >>>>>>>>>> Since idle_loop() is referenced only in inline assembly, add > >>>>>>>>>> the 'used' > >>>>>>>>>> attribute to suppress unused-function compiler warning. > >>>>>>>>> > >>>>>>>>> While I see that Julien has already acked the patch, I'd like to > >>>>>>>>> point > >>>>>>>>> out that using __used here is somewhat bogus. Imo the better > >>>>>>>>> approach > >>>>>>>>> is to properly make visible to the compiler that the symbol is > >>>>>>>>> used by > >>>>>>>>> the asm(), by adding a fake(?) input. > >>>>>>>> > >>>>>>>> I 'm afraid I do not understand what do you mean by "adding a > >>>>>>>> fake(?) > >>>>>>>> input". Can you please elaborate a little on your suggestion? > >>>>>>> > >>>>>>> Once the asm() in question takes the function as an input, the > >>>>>>> compiler > >>>>>>> will know that the function has a user (unless, of course, it finds > >>>>>>> a > >>>>>>> way to elide the asm() itself). The "fake(?)" was because I'm not > >>>>>>> deeply > >>>>>>> enough into Arm inline assembly to know whether the input could then > >>>>>>> also be used as an instruction operand (which imo would be > >>>>>>> preferable) - > >>>>>>> if it can't (e.g. because there's no suitable constraint or operand > >>>>>>> modifier), it still can be an input just to inform the compiler. > >>>>>> > >>>>>> According to the following statement, your approach is the recommended > >>>>>> one: > >>>>>> "To prevent the compiler from removing global data or functions which > >>>>>> are referenced from inline assembly statements, you can: > >>>>>> -use __attribute__((used)) with the global data or functions. > >>>>>> -pass the reference to global data or functions as operands to inline > >>>>>> assembly statements. > >>>>>> Arm recommends passing the reference to global data or functions as > >>>>>> operands to inline assembly statements so that if the final image does > >>>>>> not require the inline assembly statements and the referenced global > >>>>>> data or function, then they can be removed." > >>>>>> > >>>>>> IIUC, you are suggesting to change > >>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) > >>>>>> into > >>>>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" > >>>>>> ); > >>>>> > >>>>> Yes, except that I can't judge about the "S" constraint. > >>>>> > >>>> > >>>> This constraint does not work for arm32. Any other thoughts? > >>>> > >>>> Another way, as Jan suggested, is to pass the function as a 'fake' > >>>> (unused) input. > >>>> I 'm suspecting something like the following could work > >>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : > >>>> "memory") > >>>> What do you think? > >>> > >>> Well, yes, X should always be a fallback option. But I said already when > >>> you suggested S that I can't judge about its use, so I guess I'm the > >>> wrong one to ask. Even more so that you only say "does not work", without > >>> any details ... > >>> > >> > >> The question is addressed to anyone familiar with arm inline assembly. > >> I added the arm maintainers as primary recipients to this email to make this > >> perfectly clear. > >> > >> When cross-compiling Xen on x86 for arm32 with > >> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); > >> compilation fails with the error: impossible constraint in ‘asm' > > > > Unfortunately looking at the GCC manual pages [1], it doesn't seem to be > > possible. The problem is that the definition of "S" changes between > > aarch64 and arm (the 32-bit version). > > > > For aarch64: > > > > S An absolute symbolic address or a label reference > > > > This is what we want. For arm instead: > > > > S A symbol in the text segment of the current file > > > > This is not useful for what we need to do here. As far as I can tell, > > there is no other way in GCC assembly inline for arm to do this. > > > > So we have 2 choices: we use the __used keyword as Xenia did in this > > patch. Or we move the implementation of switch_stack_and_jump in > > assembly. I attempted a prototype of the latter to see how it would come > > out, see below. > > > > I don't like it very much. I prefer the version with __used that Xenia > > had in this patch. But I am OK either way. > > You forgot the imo better intermediate option of using the "X" constraint. I couldn't get "X" to compile in any way (not even for arm64). Do you have a concrete example that you think should work using "X" as constraint? --8323329-26634204-1658880634=:4648-- From xen-devel-bounces@lists.xenproject.org Wed Jul 27 00:17:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 00:17:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375821.608269 (Exim 4.92) (envelope-from ) id 1oGUji-0007ih-Jb; Wed, 27 Jul 2022 00:17:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375821.608269; Wed, 27 Jul 2022 00:17:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGUji-0007ia-Gv; Wed, 27 Jul 2022 00:17:14 +0000 Received: by outflank-mailman (input) for mailman id 375821; Wed, 27 Jul 2022 00:17:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGUji-0007iU-37 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 00:17:14 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7584de6f-0d41-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 02:17:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DDEC861723; Wed, 27 Jul 2022 00:17:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1BD25C433C1; Wed, 27 Jul 2022 00:17:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7584de6f-0d41-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658881030; bh=6Qn9kezw6JDiNR1QZruzKrDCMxbOB9yqQKz2MDiNRvY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dWzws4qV+AsFRjDgMOCBipFubSXkR4l/U5iq+HJ1S4+C3GpFCpbr9XymaqBs9K5uB xOCnEqRsgYSQxHNzGD4+r9w37d8zcvvmtqxwBXM7fZUrN23sqRwyWXIQV49K+x/HhI gkCgWxADKJ+ox7SUg8KS/Oof7Q5QQzzLvpgX7i2BH0PgjlFJUAK5sWwwH/FP86HMgt GBSxGNJkjm0mTQYnJSRrek4cuTwIJp/GmYAUkzg25b2XwGdTd8a80LOZSHmSlLY86u bD52xjCo76DPgnSy8tmQGzKOuK2eUZ5XuiXxeTD+TrI8k/Hx3ch6bqGA77RPdghoP5 D6tz3L+GEcpkg== Date: Tue, 26 Jul 2022 17:17:09 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Smith, Jackson" cc: Xen-devel , Stefano Stabellini Subject: Re: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Mon, 25 Jul 2022, Smith, Jackson wrote: > Hi Stefano, > > My colleague Jason Lei and I would like to submit a patch to imagebuilder. > > It seems that generating a .fit with a true dom0less configuration fails because an extraneous comma is included in the its file. > > We believe this change resolves the issue. Hi Jackson, thanks for your contribution! Yes, I see the problem: the code assumes there is a dom0 kernel. If there is no dom0 kernel then load_files will be wrongly starting with a "," I would be happy to commit your patch. I assume I can add your Signed-off-by to it, right? Signed-off-by: Jackson Smith Signed-off-by is the "Developer Certificate of Origin" which means: https://developercertificate.org/ > > Remove extraneous comma in generated its file when no DOM0_KERNEL is specified. > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index 8f08cd6..6f94fce 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -676,7 +676,12 @@ create_its_file_xen() > i=$(( $i + 1 )) > continue > fi > - load_files+=", \"domU${i}_kernel\"" > + if test -z "$load_files" > + then > + load_files+="\"domU${i}_kernel\"" > + else > + load_files+=", \"domU${i}_kernel\"" > + fi > cat >> "$its_file" <<- EOF > domU${i}_kernel { > description = "domU${i} kernel binary"; > > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 01:03:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 01:03:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375828.608285 (Exim 4.92) (envelope-from ) id 1oGVRv-0003B4-2v; Wed, 27 Jul 2022 01:02:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375828.608285; Wed, 27 Jul 2022 01:02:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGVRu-0003Ax-Vy; Wed, 27 Jul 2022 01:02:54 +0000 Received: by outflank-mailman (input) for mailman id 375828; Wed, 27 Jul 2022 01:02:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGVRt-0003An-U0; Wed, 27 Jul 2022 01:02:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGVRt-0005hy-RI; Wed, 27 Jul 2022 01:02:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGVRt-0006Ug-9O; Wed, 27 Jul 2022 01:02:53 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGVRt-00031I-6h; Wed, 27 Jul 2022 01:02:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GP9XOtKMNRJprns1cgYDZYk95cFrbmuaLPPxypQPO94=; b=D3q09GW3IqpnUOGpcrwMunBPWs jXFDqsjGkfQYgtbtCl1XbNoVo8qcczOwGjo/pzVzfwinQHUpZEySX2C7MzyEzHo0Bje3gx6TIIeU1 fbI8/rwXxGL1cN9my6LBS9ECBMJEZTWs2xhJrGeBXI4Jd5/r2wTk2xYe0Nch8239KByE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.14-testing test] 171865: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:xen-boot:fail:heisenbug xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.14-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.14-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ef571a5a11e70365106db15144236d7bb5117abe X-Osstest-Versions-That: xen=87d90d511c87477609cc4b8c88866bfbe997da46 From: osstest service owner Date: Wed, 27 Jul 2022 01:02:53 +0000 flight 171865 xen-4.14-testing real [real] flight 171874 xen-4.14-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171865/ http://logs.test-lab.xenproject.org/osstest/logs/171874/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-libvirt-qcow2 8 xen-boot fail pass in 171874-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail in 171874 like 171604 test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail in 171874 never pass test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171604 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171604 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171604 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171604 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171604 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171604 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171604 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171604 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171604 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171604 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171604 test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen ef571a5a11e70365106db15144236d7bb5117abe baseline version: xen 87d90d511c87477609cc4b8c88866bfbe997da46 Last test of basis 171604 2022-07-12 17:08:06 Z 14 days Testing same since 171865 2022-07-26 13:07:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 fail test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 87d90d511c..ef571a5a11 ef571a5a11e70365106db15144236d7bb5117abe -> stable-4.14 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 03:34:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 03:34:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375850.608300 (Exim 4.92) (envelope-from ) id 1oGXo5-0003gJ-9Y; Wed, 27 Jul 2022 03:33:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375850.608300; Wed, 27 Jul 2022 03:33:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGXo5-0003gC-5N; Wed, 27 Jul 2022 03:33:57 +0000 Received: by outflank-mailman (input) for mailman id 375850; Wed, 27 Jul 2022 03:33:55 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGXo3-0003g1-KN; Wed, 27 Jul 2022 03:33:55 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGXo3-0000pO-Hp; Wed, 27 Jul 2022 03:33:55 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGXo3-0001zM-2v; Wed, 27 Jul 2022 03:33:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGXo3-0002vy-0E; Wed, 27 Jul 2022 03:33:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=y08bcw/VVkCCTL/je6IhvjiqTEPbjbawyDXi44zwhOw=; b=pkD/MUrmgZ64LVvnFkkjiqXVkJ eT5TGcIfriL3KscRd8PRXAQBApniYuuUlcz2x0tiITs0T78rMjKUOtvXZwTc9rAZjLraVPd6MADbe xSPgvBIdyYgPR8fcic4/8n0ETp9b7jCjdfxHppOrsb0wQ3oe4aVNDWvO2n3zyI1GHbG8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 171866: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-arm64-arm64-xl-xsm:xen-boot:fail:heisenbug xen-4.15-testing:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=3859f3ee7e37323ae5e0014c07ba8d3a4d7890b2 X-Osstest-Versions-That: xen=35bf91d30f1a480dcf5bfd99b79384b2b283da7f From: osstest service owner Date: Wed, 27 Jul 2022 03:33:55 +0000 flight 171866 xen-4.15-testing real [real] flight 171875 xen-4.15-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171866/ http://logs.test-lab.xenproject.org/osstest/logs/171875/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-xsm 8 xen-boot fail pass in 171875-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171609 Tests which did not succeed, but are not blocking: test-arm64-arm64-xl-xsm 15 migrate-support-check fail in 171875 never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail in 171875 never pass test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171609 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171609 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171609 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171609 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171609 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171609 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171609 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171609 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171609 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171609 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171609 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171609 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen 3859f3ee7e37323ae5e0014c07ba8d3a4d7890b2 baseline version: xen 35bf91d30f1a480dcf5bfd99b79384b2b283da7f Last test of basis 171609 2022-07-13 00:09:31 Z 14 days Testing same since 171866 2022-07-26 13:07:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm fail test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 35bf91d30f..3859f3ee7e 3859f3ee7e37323ae5e0014c07ba8d3a4d7890b2 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 03:50:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 03:50:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375864.608311 (Exim 4.92) (envelope-from ) id 1oGY3h-00065v-LY; Wed, 27 Jul 2022 03:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375864.608311; Wed, 27 Jul 2022 03:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGY3h-00065H-I1; Wed, 27 Jul 2022 03:50:05 +0000 Received: by outflank-mailman (input) for mailman id 375864; Wed, 27 Jul 2022 03:50:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGY3f-0005jl-Pa for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 03:50:03 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31240def-0d5f-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 05:50:02 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id j22so29393625ejs.2 for ; Tue, 26 Jul 2022 20:50:01 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id e16-20020a1709061e9000b0072b4da1ed9asm7040338ejj.225.2022.07.26.20.49.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Jul 2022 20:50:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31240def-0d5f-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=boGGPKrt7e0pNKjASz0sLnC9Bi3HtxzAQW/9tbujYKg=; b=OMdwfSr45Tr+BcTjX3JL8pUeRHM/BPXX6mmU12xHUSSHvyPODwVG+Nu/FGHwF/g7O8 NvhelgWGRk487pQPiN8SC4l7KgE8KxlXjw0iw3AmfJfjLlbHGvvFlOyUMQ7Zv+ceAYh9 eUIMPydp63IbbtEPU683E6H+HOs7BSX8ctubTlUlt2XyH2gz+OwQlZeh5AUnpqITfT+C RDCSbWzVV5H36knQuGTjEpv9xZnZWAne3cJUMyLNeF9OmHvuX/HfU86YRfFNTRd+fdqp rFwUqWdqi4i6alo7QPvxTbrFvtg3yGjo54CzkrNpR7pwB3tJxFQVeal07hHDbSrQkhZ4 93dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=boGGPKrt7e0pNKjASz0sLnC9Bi3HtxzAQW/9tbujYKg=; b=o5Psc/BJQn9+Jlhiamlnp4jtd2mZisfHHmqqDpPAbS5qpNT8JoiML0GZAD23Htkw+X 09404nbCVJLQNdQ4h6Zj/K+p9iFNxnroK2cGQ3vHEFHWxShHWzqaeXvVfM43+bPfm/AW 2Z6c/SXR42p9b2EXuA3QBxaxsvQIdl9t9Fzf08Lvd3u0N5q8ccj98fzK9Ht7EbIg4osN obSli0/hXpek14GAwDf6K8ujo2y55pb61yzeiR55mwANATQ/nZ8WXx4HC1B01HfwrnBk OcsVSGD/DDQvUJpjgoemcdzSxE4NpLOIXh7rRRbhLsOATXCpeHxvLpnmtOLFok05+HF7 YjNA== X-Gm-Message-State: AJIora/4yImBqiq9YPXG3/mcDCzjAtP3I2WKotU5k294WIaVdIhFsLi0 9+2/fSUvK/VeQxgW7FiEcig= X-Google-Smtp-Source: AGRyM1th2IaGOqsHNKXlQaz2oB5qGxUwRO+ey34OHYumpCL+y4T9TybmvnvDBc+Dh3Y2Kq6Sw+OTbg== X-Received: by 2002:a17:907:3daa:b0:72b:7656:d4d2 with SMTP id he42-20020a1709073daa00b0072b7656d4d2mr16277528ejc.166.1658893801201; Tue, 26 Jul 2022 20:50:01 -0700 (PDT) Message-ID: <649c2902-0d36-bfc7-43a8-98e6c38b6ecd@gmail.com> Date: Wed, 27 Jul 2022 06:49:59 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Stefano Stabellini , Jan Beulich Cc: Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/27/22 03:10, Stefano Stabellini wrote: > On Tue, 26 Jul 2022, Jan Beulich wrote: >> On 26.07.2022 02:33, Stefano Stabellini wrote: >>> On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: >>>> On 7/25/22 09:32, Jan Beulich wrote: >>>>> On 24.07.2022 19:20, Xenia Ragiadakou wrote: >>>>>> On 7/7/22 10:55, Jan Beulich wrote: >>>>>>> On 07.07.2022 09:27, Xenia Ragiadakou wrote: >>>>>>>> On 7/6/22 11:51, Jan Beulich wrote: >>>>>>>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>>>>>>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>>>>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>>>>>>>> The function idle_loop() is referenced only in domain.c. >>>>>>>>>>>> Change its linkage from external to internal by adding the >>>>>>>>>>>> storage-class >>>>>>>>>>>> specifier static to its definitions. >>>>>>>>>>>> >>>>>>>>>>>> Since idle_loop() is referenced only in inline assembly, add >>>>>>>>>>>> the 'used' >>>>>>>>>>>> attribute to suppress unused-function compiler warning. >>>>>>>>>>> >>>>>>>>>>> While I see that Julien has already acked the patch, I'd like to >>>>>>>>>>> point >>>>>>>>>>> out that using __used here is somewhat bogus. Imo the better >>>>>>>>>>> approach >>>>>>>>>>> is to properly make visible to the compiler that the symbol is >>>>>>>>>>> used by >>>>>>>>>>> the asm(), by adding a fake(?) input. >>>>>>>>>> >>>>>>>>>> I 'm afraid I do not understand what do you mean by "adding a >>>>>>>>>> fake(?) >>>>>>>>>> input". Can you please elaborate a little on your suggestion? >>>>>>>>> >>>>>>>>> Once the asm() in question takes the function as an input, the >>>>>>>>> compiler >>>>>>>>> will know that the function has a user (unless, of course, it finds >>>>>>>>> a >>>>>>>>> way to elide the asm() itself). The "fake(?)" was because I'm not >>>>>>>>> deeply >>>>>>>>> enough into Arm inline assembly to know whether the input could then >>>>>>>>> also be used as an instruction operand (which imo would be >>>>>>>>> preferable) - >>>>>>>>> if it can't (e.g. because there's no suitable constraint or operand >>>>>>>>> modifier), it still can be an input just to inform the compiler. >>>>>>>> >>>>>>>> According to the following statement, your approach is the recommended >>>>>>>> one: >>>>>>>> "To prevent the compiler from removing global data or functions which >>>>>>>> are referenced from inline assembly statements, you can: >>>>>>>> -use __attribute__((used)) with the global data or functions. >>>>>>>> -pass the reference to global data or functions as operands to inline >>>>>>>> assembly statements. >>>>>>>> Arm recommends passing the reference to global data or functions as >>>>>>>> operands to inline assembly statements so that if the final image does >>>>>>>> not require the inline assembly statements and the referenced global >>>>>>>> data or function, then they can be removed." >>>>>>>> >>>>>>>> IIUC, you are suggesting to change >>>>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ) >>>>>>>> into >>>>>>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" >>>>>>>> ); >>>>>>> >>>>>>> Yes, except that I can't judge about the "S" constraint. >>>>>>> >>>>>> >>>>>> This constraint does not work for arm32. Any other thoughts? >>>>>> >>>>>> Another way, as Jan suggested, is to pass the function as a 'fake' >>>>>> (unused) input. >>>>>> I 'm suspecting something like the following could work >>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : >>>>>> "memory") >>>>>> What do you think? >>>>> >>>>> Well, yes, X should always be a fallback option. But I said already when >>>>> you suggested S that I can't judge about its use, so I guess I'm the >>>>> wrong one to ask. Even more so that you only say "does not work", without >>>>> any details ... >>>>> >>>> >>>> The question is addressed to anyone familiar with arm inline assembly. >>>> I added the arm maintainers as primary recipients to this email to make this >>>> perfectly clear. >>>> >>>> When cross-compiling Xen on x86 for arm32 with >>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" ); >>>> compilation fails with the error: impossible constraint in ‘asm' >>> >>> Unfortunately looking at the GCC manual pages [1], it doesn't seem to be >>> possible. The problem is that the definition of "S" changes between >>> aarch64 and arm (the 32-bit version). >>> >>> For aarch64: >>> >>> S An absolute symbolic address or a label reference >>> >>> This is what we want. For arm instead: >>> >>> S A symbol in the text segment of the current file >>> >>> This is not useful for what we need to do here. As far as I can tell, >>> there is no other way in GCC assembly inline for arm to do this. >>> >>> So we have 2 choices: we use the __used keyword as Xenia did in this >>> patch. Or we move the implementation of switch_stack_and_jump in >>> assembly. I attempted a prototype of the latter to see how it would come >>> out, see below. >>> >>> I don't like it very much. I prefer the version with __used that Xenia >>> had in this patch. But I am OK either way. >> >> You forgot the imo better intermediate option of using the "X" constraint. > > I couldn't get "X" to compile in any way (not even for arm64). Do you > have a concrete example that you think should work using "X" as > constraint? I proposed the X constraint for the case that the function is used as a fake (unused) input operand to the inline asm. For instance, in the example below, the function is listed in the input operands but there is not corresponding reference to it. asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 27 04:11:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 04:11:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375838.608322 (Exim 4.92) (envelope-from ) id 1oGYNp-0000dR-DR; Wed, 27 Jul 2022 04:10:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375838.608322; Wed, 27 Jul 2022 04:10:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGYNp-0000dK-9X; Wed, 27 Jul 2022 04:10:53 +0000 Received: by outflank-mailman (input) for mailman id 375838; Wed, 27 Jul 2022 01:20:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGViR-00053m-Jv for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 01:20:00 +0000 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 37be9bcb-0d4a-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 03:19:55 +0200 (CEST) Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2022 18:19:52 -0700 Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 26 Jul 2022 18:19:52 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 18:19:51 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Tue, 26 Jul 2022 18:19:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Tue, 26 Jul 2022 18:19:51 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Tue, 26 Jul 2022 18:19:50 -0700 Received: from BL1PR11MB5461.namprd11.prod.outlook.com (2603:10b6:208:30b::17) by BY5PR11MB4136.namprd11.prod.outlook.com (2603:10b6:a03:192::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 01:19:46 +0000 Received: from BL1PR11MB5461.namprd11.prod.outlook.com ([fe80::34e1:61a:2e14:5a8b]) by BL1PR11MB5461.namprd11.prod.outlook.com ([fe80::34e1:61a:2e14:5a8b%5]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 01:19:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 37be9bcb-0d4a-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658884795; x=1690420795; h=from:to:subject:date:message-id:mime-version; bh=GP5fXwnW19NS47ByjXWGji+eWtOVeub19IYGZh28moI=; b=oKqYRkuSFQgziOrMaIWdp40Ya0TtOEnrEtpvCY8uSEsTkc2VAE0N05O7 0beFMQZqY5AOqvyQMT10UEbRrv72b66qez0GT3oOMfAbDoGQQrfYdHE+1 iU20hl38UkYF/jtUsvfAEZuJdfxSrYQzpqBv1LeSekrXMyFf7ZTk0WQly 6AbaK54FU9CHK+EaS0q7GXRQboUX5mf1oYA/6Yshe83P7O4k8kLtfCwqs 3Ga8tmBIzLONkX7JCuuLlHLqCgspBlpiCE+wkGd6gyGFEzXyBeXMZqW1w iAOtgCwqql0vWWR6Zsm3mb+bMw8aWiQHcz9hqhICnTiTq+ibcT5ePefBe g==; X-IronPort-AV: E=McAfee;i="6400,9594,10420"; a="285663826" X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="log'?scan'208";a="285663826" X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,194,1654585200"; d="log'?scan'208";a="658962471" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FKQ+VRRxuD1SJ4uBTW/rH6PCWtiR3y/pxR41lBVlcC2RvbhZxUPCD4A/d1333EM3VA3S4C8zpnm8YV/0GWillQFWeoI8+6nK+U75YxyKL3Q7oC3T2xtLGruyiNgq0Oa0Q4H/yIBaMK1Tzyz4zZ46XHjXKoRwdpZTZM+cmtgDIqvHJDLOb2r9iUnfiCVCcWvlbhMWG0ub79gIv5aJDgA7mfeMUOWT2il8ekYHOToIWa2PWCUxYd2M57kiSzjWXApqPLLNH4/XOoDL9K2FXswkouhv1siod7rkZosDW/RG3Rc1ea2DybFC4OmkkRhRmGw6soHgCQFKCi/X23yDVo1adg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AtIWbaQf/xawa3bLuWnhKVwiN8vOXyA33nTyvx+cc+s=; b=Y9rHd8E5heVQszPhpa6wxiiYCY6PgFVhHmDn5Xjz3vSUgIZNuT3dmu9U+EiHJCjyqkucs6FyrFcLiOC1FK5dpINTDyd3CH6FxHuPLWnOtBQ67kJPTaavgPHAAy6JjYVZlFLPXQbmFd+wByZE9Zpj26G7znxRp80sggrJLJZBC3VXiaoPWFai5UkpeIEnaULLVudCUJ0BBqk7AUHhoBLpyEdhgbb+TPMsAqLAvydtuvEKdq1rsbKxQqfRZbFoucGOMHvdV4iMbrLcMxI+k+5pOCUxl8oZSKWWJr+mwISnCB0BC41Y0DWOVlUbtrHwyprp3BFlUVv2HiPqqacP3Zwd0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none From: "Gao, Ruifeng" To: "xen-devel@lists.xenproject.org" Subject: [BUG] Xen causes a host hang by using xen-hptool cpu-offline Thread-Topic: [BUG] Xen causes a host hang by using xen-hptool cpu-offline Thread-Index: AdihT5m7mvST/DbqR8ay9ayHgdYZGg== Date: Wed, 27 Jul 2022 01:19:46 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.500.17 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c91e0c71-4d6a-49ec-1630-08da6f6e17d1 x-ms-traffictypediagnostic: BY5PR11MB4136:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xDOfpbytAvGdPsqMuxSvPDu7mTLYBBHjoUu675TrwNLvXgwaZKLGKdkQ8HL8/Xb9uRmuGyVLg1Y73wkvRK5Z4FX7oidl4m+tImII//0sBgEx8xi71drhWHo8VZj/lIq/eW7Eo9/P+Lghz8nxOU3VLAJWclyf+dU216fBvqeVwn5gtcYf9lRcQZv0SB2KRhgR46nSiWkLXdvj3zPhZfTq0YcyUTmOAlx1JTcOsM9OxGzrVO3L+WikBkoWswY2YvVA79WibXSp9KQYubavAmnf0uNEP+1VSspb6cMHSVIfXN5uaajmzwhoqKIkp6kgoEemFYFQlLeUMm+fEoWYROOR8yf9iuPZpBbNLzc/Q9/zn0i/A9sMjmOltcIgB5y4lZBoLyKkFxJpl7SdaAjdjvKrhx8m2jvWVtc3pAjkQCS1WGCka85u3XtXeJ7GBzQRbl3AZLM7MG97J9qhjIrMofHd7BnNurW3+ibQZ3XKaYRov9MRz9qLy+70mZZE4Irv5cvYTnmfXgFXKAJvi1lbYxHTehv+222enBve7Rz3ZYv+ERg3LttpIVDjeVo9jKNjNsV2c25VqhTJSo93AttltgWVEUZKMDaAMFT8LGCpClC9ychIu+0UOWz894ZtyJQ8RllRJ3kYNW7vZqzTVjA/aDTRAT5prlxCFIg1W1kvcHVaOTTyxZeCgQe3ednd/8aZm7a//0K+i0+3LlVuD5LEQ/nsQ3We+1x0agiXTOhJoXqBrbeosLPzJ7Lg1GPimImYEVD2+5iwxVqH4Q3pJfGl3TC/2hTRlNQqLcVSial3wDc39e71PHK4Iv/Q5EG0fUstcfXg x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL1PR11MB5461.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(366004)(136003)(396003)(39860400002)(346002)(71200400001)(478600001)(99936003)(41300700001)(38070700005)(82960400001)(26005)(6506007)(9686003)(6916009)(7696005)(186003)(316002)(66556008)(122000001)(66946007)(8676002)(55016003)(8936002)(5660300002)(52536014)(64756008)(38100700002)(86362001)(83380400001)(66446008)(33656002)(76116006)(2906002)(66476007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?qVTri7zcQ4hwjT+AwlXOtnL+4ugkt+V3dAoQjyr5jJA6O1eDQwlYqUqGqZQV?= =?us-ascii?Q?eWjO+YDf5wzIq8RpDPlxN6tYz0/xj8igzf0rqLuohkevKukOXLhAPDlsmqDW?= =?us-ascii?Q?D9ePTV3PobAmIyPxcgLogx69NQfrq2wquyi1u83Um30J4ZBzqDkQVAq26OZZ?= =?us-ascii?Q?uS7h47dpFRgbzWKud284wySdmoooMyimmIiJv/ZecH74dqgvleD1QaFfP7RW?= =?us-ascii?Q?zHSm8OaMkQb9JyRLl4yceqWjr/+KVvkEQG7B954XjzjAOowzvCEWAiItZXOe?= =?us-ascii?Q?0vZesKNUQCZ2X/NN4sanxva1NLCUCsAOKJI8wlr/rVuulepD6aa96XRAFPk4?= =?us-ascii?Q?P8Oo10u9LcZRNV9KNH9KncbtlfapysPADRAjCnZH52Smc0Ceh2mHbl5kTi57?= =?us-ascii?Q?oeh86WIsgahHD7RcxeIYaY+ySlrRZ8vhWGr7ZJIdTA2XkQEnXEgrRn6it1sa?= =?us-ascii?Q?yRo29idlvIY6pNMwScUFUOfdtlpHmBkMTqPUG6vkizYV92mW3Ium3sPO3OBF?= =?us-ascii?Q?qJlNjOV6OBjd4+wJur5r0fI7KTjRhIW3a4xrFcqRBs/9/4H3RQAtDSliO80/?= =?us-ascii?Q?9uPLxEd/4j8QmPAqrcL9Sgrt18PBuCcklu5U4IvwnInNjmbMwQRxS3Qilvct?= =?us-ascii?Q?dJPRx+vLGqINUJf7Xg6H2EBwloIZpv8MDY8nXagA4tYV0X8PW/a9OgXtZeSo?= =?us-ascii?Q?zGSF4+8rXpZ2feRBYnhXVX3T5YEnzzr0OiEz6J+lSl93f57s0kwYUPQ6Uv2+?= =?us-ascii?Q?QonDpKO4YmwTTgzJmKPPGeNaUMTRv2TEe+PMtrmtIdCJOW0fER1epqXXXjgz?= =?us-ascii?Q?TaMbAhQ8FEA+dFKRc80qIDw3uUMh7x6dzp2XSxWlNmeYjB/7G1v0YRT44FIS?= =?us-ascii?Q?pWeGyeuM+uoX7GJQ7ouN6aJGClRUYhR0I+RarLEnCJoK7PFB6Kr+ARmO6U2Q?= =?us-ascii?Q?jNhjZsbukQyVo/jlcje8JDPDGUqSg6EbVTpCA8auOl3aw1lM/0DVWPT0SNxd?= =?us-ascii?Q?UcQALLu1+yiKD9zM/khd04K55K1u61iYTU+iaztIHr/NJYGYYtx31MZAQ/nP?= =?us-ascii?Q?UySsbZtBi5Wf+nI+Xiwaw9xg3UdfKT+hkkBSqJQ3MYewJsqr0FPUnPBucHJA?= =?us-ascii?Q?9S2v+VwVojCGOh4ss7EJH27NNtQ0goYssb2BTxmlgF1TJFtX666Q/g4QN5Y5?= =?us-ascii?Q?weCqRNgEaZGCFPH5QyBKd75zfhcljJzJfpm56TG6yaRxfNB9DPFLOMQd6otx?= =?us-ascii?Q?tjMRm+kVgFkhnkCLB5jElW00FCKM6hNR4K5irgRlAov0/mv0PFmhoFn0urZb?= =?us-ascii?Q?ioeDA9AfT7ekHR0ivTegHvrWvT4pZustk2BNqVS3HW8pxV8OEu56uEiDN7eF?= =?us-ascii?Q?A/ysVkPGY++fJJfor7CqqWK3mzl8Sl/tmhvwEFl91UQYMhREuysJlHR/ehGe?= =?us-ascii?Q?XtXvt7Xg4wlJOno8+B/eYQa12uf4Fa7IEGPGJWBib8uUevyrhLy3uYw0Uzgp?= =?us-ascii?Q?r26frBWQ2CVl5QMHAZs43vs403ktLnXpGSrG4RpEJQH6T4s4vsu7ZRuVrdD2?= =?us-ascii?Q?269DNT6jMzPeijhT9ea3iiezjNI60DszKtieijuA?= Content-Type: multipart/mixed; boundary="_002_BL1PR11MB546193E001A425E0B9B7848EEC979BL1PR11MB5461namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5461.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c91e0c71-4d6a-49ec-1630-08da6f6e17d1 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 01:19:46.2855 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CYKFweXHtVpcUF2RAKjd9yTjGLs21Ppbnj8LYFK2qUkeYAhV2dB8UKJtYCwMf+Lrou2eWtefgExBr0K0Uqi+yA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4136 X-OriginatorOrg: intel.com --_002_BL1PR11MB546193E001A425E0B9B7848EEC979BL1PR11MB5461namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Problem Description: Trying to execute "/usr/local/sbin/xen-hptool cpu-offline ", the hos= t will hang immediately. Version-Release and System Details: Platform: Ice Lake Server Host OS: Red Hat Enterprise Linux 8.3 (Ootpa) Kernel: 5.19.0-rc6 HW: Intel(R) Xeon(R) Gold 6336Y CPU @ 2.40GHz=20 Xen Version: 4.17-unstable(ab2977b027-dirty) Reproduce Steps: 1. Boot from Xen and check the information: [root@icx-2s1 ~]# xl info host : icx-2s1 release : 5.19.0-rc6 xen_version : 4.17-unstable xen_caps : xen-3.0-x86_64 hvm-3.0-x86_32 hvm-3.0-x86_32p hvm-= 3.0-x86_64 platform_params : virt_start=3D0xffff800000000000 xen_changeset : Thu Jul 14 19:45:36 2022 +0100 git:ab2977b027-dirt= y 2. Execute the cpu-offline command, here cpuid is 48 as an example: [root@icx-2s1 ~]# /usr/local/sbin/xen-hptool cpu-offline 48 Actual Results: The host will hang immediately. Expected Results: The selected CPUs will be offline after executing the "xen-hptool cpu-offli= ne" command. Additional Info: On previous Xen commit 4.17-unstable(58ce5b6c-dirty), after executing the s= ame command, the host works normally. --_002_BL1PR11MB546193E001A425E0B9B7848EEC979BL1PR11MB5461namp_ Content-Type: application/octet-stream; name="icx-2s1.log" Content-Description: icx-2s1.log Content-Disposition: attachment; filename="icx-2s1.log"; size=193525; creation-date="Tue, 26 Jul 2022 05:25:39 GMT"; modification-date="Wed, 27 Jul 2022 01:19:45 GMT" Content-Transfer-Encoding: base64 IFhlbiA0LjE3LXVuc3RhYmxlCihYRU4pIFhlbiB2ZXJzaW9uIDQuMTctdW5zdGFibGUgKGdjYyAo R0NDKSA4LjMuMSAyMDE5MTEyMSAoUmVkIEhhdCA4LjMuMS01KSkgZGVidWc9eSBTdW4gSnVsIDE3 IDAzOjExOjAyIENTVCAyMDIyCihYRU4pIExhdGVzdCBDaGFuZ2VTZXQ6IFRodSBKdWwgMTQgMTk6 NDU6MzYgMjAyMiArMDEwMCBnaXQ6YWIyOTc3YjAyNy1kaXJ0eQooWEVOKSBidWlsZC1pZDogNDkw NGQxNDJhM2NlMTZiNTgxNjA3NTZkNmY0YTgyNDUKKFhFTikgQ29uc29sZSBvdXRwdXQgaXMgc3lu Y2hyb25vdXMuCihYRU4pIEJvb3Rsb2FkZXI6IEVGSQooWEVOKSBDb21tYW5kIGxpbmU6IGRvbTBf bWVtPTgxOTJNIGRvbTBfbWF4X3ZjcHVzPTggbG9nbHZsPWFsbCBndWVzdF9sb2dsdmw9YWxsIG1z aT0xIGNvbnJpbmdfc2l6ZT00TSBjb25zb2xlPXZnYSxjb20xIGNvbnNvbGU9Y29tMSBjb20xPTEx NTIwMCw4bjEgc3luY19jb25zb2xlIHZwaWQ9MSB2cG11PTEgYWx0cDJtPTEgcHNyPWNtdCBwc3I9 Y2F0IHBzcj1jZHAgcHNyPW1iYSBlcHQ9cG1sIGlvbW11PW9uLGludHBvc3QgaHZtX2ZlcD10cnVl IGV4dHJhX2d1ZXN0X2lycXM9MTAyNCwxMDI0CihYRU4pIFhlbiBpbWFnZSBsb2FkIGJhc2UgYWRk cmVzczogMHg1OTQwMDAwMAooWEVOKSBWaWRlbyBpbmZvcm1hdGlvbjoKKFhFTikgIFZHQSBpcyBn cmFwaGljcyBtb2RlIDEwMjR4NzY4LCAzMiBicHAKKFhFTikgRGlzYyBpbmZvcm1hdGlvbjoKKFhF TikgIEZvdW5kIDAgTUJSIHNpZ25hdHVyZXMKKFhFTikgIEZvdW5kIDEgRUREIGluZm9ybWF0aW9u IHN0cnVjdHVyZXMKKFhFTikgQ1BVIFZlbmRvcjogSW50ZWwsIEZhbWlseSA2ICgweDYpLCBNb2Rl bCAxMDYgKDB4NmEpLCBTdGVwcGluZyA2IChyYXcgMDAwNjA2YTYpCihYRU4pIEVGSSBSQU0gbWFw OgooWEVOKSAgWzAwMDAwMDAwMDAwMDAwMDAsIDAwMDAwMDAwMDAwOWRmZmZdICh1c2FibGUpCihY RU4pICBbMDAwMDAwMDAwMDA5ZTAwMCwgMDAwMDAwMDAwMDA5ZWZmZl0gKHJlc2VydmVkKQooWEVO KSAgWzAwMDAwMDAwMDAwOWYwMDAsIDAwMDAwMDAwMDAwOWZmZmZdIChBQ1BJIE5WUykKKFhFTikg IFswMDAwMDAwMDAwMGEwMDAwLCAwMDAwMDAwMDAwMGZmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBb MDAwMDAwMDAwMDEwMDAwMCwgMDAwMDAwMDA2MzU4MmZmZl0gKHVzYWJsZSkKKFhFTikgIFswMDAw MDAwMDYzNTgzMDAwLCAwMDAwMDAwMDY0ZWNiZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAw MDA2NGVjYzAwMCwgMDAwMDAwMDA2NjUxYWZmZl0gKEFDUEkgTlZTKQooWEVOKSAgWzAwMDAwMDAw NjY1MWIwMDAsIDAwMDAwMDAwNjY5ZmRmZmZdIChBQ1BJIGRhdGEpCihYRU4pICBbMDAwMDAwMDA2 NjlmZTAwMCwgMDAwMDAwMDA2ZjdmZmZmZl0gKHVzYWJsZSkKKFhFTikgIFswMDAwMDAwMDZmODAw MDAwLCAwMDAwMDAwMDhmZmZmZmZmXSAocmVzZXJ2ZWQpCihYRU4pICBbMDAwMDAwMDBmZTAwMDAw MCwgMDAwMDAwMDBmZTAxMGZmZl0gKHJlc2VydmVkKQooWEVOKSAgWzAwMDAwMDAxMDAwMDAwMDAs IDAwMDAwMDQwN2ZmZmZmZmZdICh1c2FibGUpCihYRU4pIEFDUEk6IFJTRFAgNjY5RkQwMTQsIDAw MjQgKHIyIElOVEVMICkKKFhFTikgQUNQSTogWFNEVCA2NjdGMjE4OCwgMDEwQyAocjEgSU5URUwg IElOVEVMIElEICAgICAgICAwIElOVEwgIDEwMDAwMTMpCihYRU4pIEFDUEk6IEZBQ1AgNjY5RjIw MDAsIDAxMTQgKHI2IElOVEVMICBJTlRFTCBJRCAgICAgICAgMCBJTlRMIDIwMDkxMDEzKQooWEVO KSBBQ1BJOiBEU0RUIDY2OTg1MDAwLCA2NTMyMCAocjIgSU5URUwgIElOVEVMIElEICAgICAgICAz IElOVEwgMjAwOTEwMTMpCihYRU4pIEFDUEk6IEZBQ1MgNjY0ODIwMDAsIDAwNDAKKFhFTikgQUNQ STogU1NEVCA2NjlGQjAwMCwgMDk0MyAocjIgIElOVEVMIHhoX3djY3JiICAgICAgICAwIElOVEwg MjAyMDA5MjUpCihYRU4pIEFDUEk6IFNTRFQgNjY5RkEwMDAsIDA0QzUgKHIyIElOVEVMICBJTlRF TCBJRCAgICAgICAgMCBNU0ZUICAxMDAwMDBEKQooWEVOKSBBQ1BJOiBTU0RUIDY2OUY5MDAwLCAw NzQ4IChyMiAgSU5URUwgUkFTX0FDUEkgICAgICAgIDEgSU5UTCAyMDIwMDkyNSkKKFhFTikgQUNQ STogU1NEVCA2NjlGODAwMCwgMDYzMiAocjIgSU5URUwgIFRwbTJUYWJsICAgICAxMDAwIElOVEwg MjAyMDA5MjUpCihYRU4pIEFDUEk6IFRQTTIgNjY5RjcwMDAsIDAwNEMgKHI0IElOVEVMICBJTlRF TCBJRCAgICAgICAgMiBJTlRMICAxMDAwMDEzKQooWEVOKSBBQ1BJOiBTU0RUIDY2OUY2MDAwLCAw NzQ1IChyMiAgSU5URUwgQUREUlhMQVQgICAgICAgIDEgSU5UTCAyMDIwMDkyNSkKKFhFTikgQUNQ STogQkVSVCA2NjlGNTAwMCwgMDAzMCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAxIElOVEwg ICAgICAgIDEpCihYRU4pIEFDUEk6IEVSU1QgNjY5RjQwMDAsIDAyMzAgKHIxIElOVEVMICBJTlRF TCBJRCAgICAgICAgMSBJTlRMICAgICAgICAxKQooWEVOKSBBQ1BJOiBCREFUIDY2OUYzMDAwLCAw MDMwIChyMSBJTlRFTCAgSU5URUwgSUQgICAgICAgIDAgSU5UTCAyMDA5MTAxMykKKFhFTikgQUNQ STogSE1BVCA2NjlGMTAwMCwgMDE4MCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAxIElOVEwg MjAwOTEwMTMpCihYRU4pIEFDUEk6IEhQRVQgNjY5RjAwMDAsIDAwMzggKHIxIElOVEVMICBJTlRF TCBJRCAgICAgICAgMSBJTlRMIDIwMDkxMDEzKQooWEVOKSBBQ1BJOiBNQ0ZHIDY2OUVGMDAwLCAw MDNDIChyMSBJTlRFTCAgSU5URUwgSUQgICAgICAgIDEgSU5UTCAyMDA5MTAxMykKKFhFTikgQUNQ STogTUlHVCA2NjlFRTAwMCwgMDA0MCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAwIElOVEwg MjAwOTEwMTMpCihYRU4pIEFDUEk6IE1TQ1QgNjY5RUQwMDAsIDAwOTAgKHIxIElOVEVMICBJTlRF TCBJRCAgICAgICAgMSBJTlRMIDIwMDkxMDEzKQooWEVOKSBBQ1BJOiBXRERUIDY2OUVDMDAwLCAw MDQwIChyMSBJTlRFTCAgSU5URUwgSUQgICAgICAgIDAgSU5UTCAyMDA5MTAxMykKKFhFTikgQUNQ STogV1NNVCA2NjlFQjAwMCwgMDAyOCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAwIElOVEwg MjAwOTEwMTMpCihYRU4pIEFDUEk6IEFQSUMgNjY5ODQwMDAsIDAzNUUgKHI0IElOVEVMICBJTlRF TCBJRCAgICAgICAgMCBJTlRMIDIwMDkxMDEzKQooWEVOKSBBQ1BJOiBTTElUIDY2OTgyMDAwLCAx MDJDIChyMSBJTlRFTCAgSU5URUwgSUQgICAgICAgIDEgSU5UTCAgMTAwMDAxMykKKFhFTikgQUNQ STogU1JBVCA2Njk3QjAwMCwgNjQzMCAocjMgSU5URUwgIElOVEVMIElEICAgICAgICAyIElOVEwg IDEwMDAwMTMpCihYRU4pIEFDUEk6IE9FTTQgNjY3RjMwMDAsIDE4N0E2MSAocjIgIElOVEVMIENQ VSAgQ1NUICAgICAzMDAwIElOVEwgMjAyMDA5MjUpCihYRU4pIEFDUEk6IE9FTTEgNjY2REUwMDAs IDExMzQ4OSAocjIgIElOVEVMIENQVSBFSVNUICAgICAzMDAwIElOVEwgMjAyMDA5MjUpCihYRU4p IEFDUEk6IE9FTTIgNjY2OTcwMDAsIDQ2MDMxIChyMiAgSU5URUwgQ1BVICBIV1AgICAgIDMwMDAg SU5UTCAyMDIwMDkyNSkKKFhFTikgQUNQSTogU1NEVCA2NjYyMDAwMCwgNzY0QTUgKHIyICBJTlRF TCBTU0RUICBQTSAgICAgNDAwMCBJTlRMIDIwMjAwOTI1KQooWEVOKSBBQ1BJOiBIRVNUIDY2OUZD MDAwLCAwMTNDIChyMSBJTlRFTCAgSU5URUwgSUQgICAgICAgIDEgSU5UTCAgICAgICAgMSkKKFhF TikgQUNQSTogRE1BUiA2NjYxRjAwMCwgMDE4MCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAx IElOVEwgMjAwOTEwMTMpCihYRU4pIEFDUEk6IFNTRFQgNjY2MTcwMDAsIDc4QkEgKHIyICBJTlRF TCBTcHNObSAgICAgICAgICAgMiBJTlRMIDIwMjAwOTI1KQooWEVOKSBBQ1BJOiBTUENSIDY2NjE2 MDAwLCAwMDUwIChyMiBJTlRFTCAgSU5URUwgSUQgICAgICAgIDAgSU5UTCAgMTAwMDAxMykKKFhF TikgQUNQSTogRlBEVCA2NjYxNTAwMCwgMDA0NCAocjEgSU5URUwgIElOVEVMIElEICAgICAgICAy IElOVEwgIDEwMDAwMTMpCihYRU4pIFN5c3RlbSBSQU06IDI2MTgyN01CICgyNjgxMTA5ODhrQikK KFhFTikgU1JBVDogTm9kZSAwIFBYTSAwIFswMDAwMDAwMDAwMDAwMDAwLCAwMDAwMDAwMDdmZmZm ZmZmXQooWEVOKSBTUkFUOiBOb2RlIDAgUFhNIDAgWzAwMDAwMDAxMDAwMDAwMDAsIDAwMDAwMDIw N2ZmZmZmZmZdCihYRU4pIFNSQVQ6IE5vZGUgMSBQWE0gMSBbMDAwMDAwMjA4MDAwMDAwMCwgMDAw MDAwNDA3ZmZmZmZmZl0KKFhFTikgTlVNQTogQWxsb2NhdGVkIG1lbW5vZGVtYXAgZnJvbSA0MDdi OGVlMDAwIC0gNDA3YjhlZjAwMAooWEVOKSBOVU1BOiBVc2luZyAxOSBmb3IgdGhlIGhhc2ggc2hp ZnQuCihYRU4pIERvbWFpbiBoZWFwIGluaXRpYWxpc2VkIERNQSB3aWR0aCAzMiBiaXRzCihYRU4p IEFsbG9jYXRlZCBjb25zb2xlIHJpbmcgb2YgNDA5NiBLaUIuCihYRU4pIFNNQklPUyAzLjMgcHJl c2VudC4KKFhFTikgVXNpbmcgQVBJQyBkcml2ZXIgZGVmYXVsdAooWEVOKSBBQ1BJOiBQTS1UaW1l ciBJTyBQb3J0OiAweDUwOCAoMjQgYml0cykKKFhFTikgQUNQSTogdjUgU0xFRVAgSU5GTzogY29u dHJvbFswOjBdLCBzdGF0dXNbMDowXQooWEVOKSBBQ1BJOiBTTEVFUCBJTkZPOiBwbTF4X2NudFsx OjUwNCwxOjBdLCBwbTF4X2V2dFsxOjUwMCwxOjBdCihYRU4pIEFDUEk6IDMyLzY0WCBGQUNTIGFk ZHJlc3MgbWlzbWF0Y2ggaW4gRkFEVCAtIDY2NDgyMDAwLzAwMDAwMDAwMDAwMDAwMDAsIHVzaW5n IDMyCihYRU4pIEFDUEk6ICAgICAgICAgICAgIHdha2V1cF92ZWNbNjY0ODIwMGNdLCB2ZWNfc2l6 ZVsyMF0KKFhFTikgQUNQSTogTG9jYWwgQVBJQyBhZGRyZXNzIDB4ZmVlMDAwMDAKKFhFTikgT3Zl cnJpZGluZyBBUElDIGRyaXZlciB3aXRoIGJpZ3NtcAooWEVOKSBBQ1BJOiBJT0FQSUMgKGlkWzB4 MDhdIGFkZHJlc3NbMHhmZWMwMDAwMF0gZ3NpX2Jhc2VbMF0pCihYRU4pIElPQVBJQ1swXTogYXBp Y19pZCA4LCB2ZXJzaW9uIDMyLCBhZGRyZXNzIDB4ZmVjMDAwMDAsIEdTSSAwLTExOQooWEVOKSBB Q1BJOiBJTlRfU1JDX09WUiAoYnVzIDAgYnVzX2lycSAwIGdsb2JhbF9pcnEgMiBkZmwgZGZsKQoo WEVOKSBBQ1BJOiBJTlRfU1JDX09WUiAoYnVzIDAgYnVzX2lycSA5IGdsb2JhbF9pcnEgOSBoaWdo IGxldmVsKQooWEVOKSBBQ1BJOiBJUlEwIHVzZWQgYnkgb3ZlcnJpZGUuCihYRU4pIEFDUEk6IElS UTIgdXNlZCBieSBvdmVycmlkZS4KKFhFTikgQUNQSTogSVJROSB1c2VkIGJ5IG92ZXJyaWRlLgoo WEVOKSBBQ1BJOiBIUEVUIGlkOiAweDgwODZhNzAxIGJhc2U6IDB4ZmVkMDAwMDAKKFhFTikgUENJ OiBNQ0ZHIGNvbmZpZ3VyYXRpb24gMDogYmFzZSA4MDAwMDAwMCBzZWdtZW50IDAwMDAgYnVzZXMg MDAgLSBmZgooWEVOKSBQQ0k6IE1DRkcgYXJlYSBhdCA4MDAwMDAwMCByZXNlcnZlZCBpbiBFODIw CihYRU4pIFBDSTogVXNpbmcgTUNGRyBmb3Igc2VnbWVudCAwMDAwIGJ1cyAwMC1mZgooWEVOKSBY ZW4gRVJTVCBzdXBwb3J0IGlzIGluaXRpYWxpemVkLgooWEVOKSBIRVNUOiBUYWJsZSBwYXJzaW5n IGhhcyBiZWVuIGluaXRpYWxpemVkCihYRU4pIFVzaW5nIEFDUEkgKE1BRFQpIGZvciBTTVAgY29u ZmlndXJhdGlvbiBpbmZvcm1hdGlvbgooWEVOKSBTTVA6IEFsbG93aW5nIDk2IENQVXMgKDAgaG90 cGx1ZyBDUFVzKQooWEVOKSBJUlEgbGltaXRzOiAxMjAgR1NJLCAxOTg0OCBNU0kvTVNJLVgKKFhF TikgW1ZULURdZHJpdmVycy9wYXNzdGhyb3VnaC92dGQvcWludmFsLmM6NDIzOiBRSTogdXNpbmcg MjU2LWVudHJ5IHJpbmcocykKKFhFTikgU3dpdGNoZWQgdG8gQVBJQyBkcml2ZXIgeDJhcGljX2Ns dXN0ZXIKKFhFTikgQ1BVMDogVFNDOiByYXRpbzogMTkyIC8gMgooWEVOKSBDUFUwOiBidXM6IDEw MCBNSHogYmFzZTogMjQwMCBNSHogbWF4OiAzNjAwIE1IegooWEVOKSBDUFUwOiA4MDAgLi4uIDI0 MDAgTUh6CihYRU4pIHhzdGF0ZTogc2l6ZTogMHhhODggYW5kIHN0YXRlczogMHgyZTcKKFhFTikg YXJjaC94ODYvY3B1L21jaGVjay9tY2VfaW50ZWwuYzo3NzY6IE1DQSBDYXBhYmlsaXR5OiBmaXJz dGJhbmsgMCwgZXh0ZW5kZWQgTUNFIE1TUiAwLCBCQ0FTVCwgU0VSLCBDTUNJLCBMTUNFCihYRU4p IENQVTA6IEludGVsIG1hY2hpbmUgY2hlY2sgcmVwb3J0aW5nIGVuYWJsZWQKKFhFTikgVW5yZWNv Z25pc2VkIENQVSBtb2RlbCAweDZhIC0gYXNzdW1pbmcgdnVsbmVyYWJsZSB0byBMYXp5RlBVCihY RU4pIFNwZWN1bGF0aXZlIG1pdGlnYXRpb24gZmFjaWxpdGllczoKKFhFTikgICBIYXJkd2FyZSBo aW50czogUkRDTF9OTyBJQlJTX0FMTCBTS0lQX0wxREZMIE1EU19OTyBUQUFfTk8KKFhFTikgICBI YXJkd2FyZSBmZWF0dXJlczogSUJQQiBJQlJTIFNUSUJQIFNTQkQgTDFEX0ZMVVNIIE1EX0NMRUFS IFRTWF9DVFJMCihYRU4pICAgQ29tcGlsZWQtaW4gc3VwcG9ydDogSU5ESVJFQ1RfVEhVTksgU0hB RE9XX1BBR0lORwooWEVOKSAgIFhlbiBzZXR0aW5nczogQlRJLVRodW5rIEpNUCwgU1BFQ19DVFJM OiBJQlJTKyBTVElCUCsgU1NCRC0gVFNYKywgT3RoZXI6IElCUEItY3R4dCBCUkFOQ0hfSEFSREVO CihYRU4pICAgU3VwcG9ydCBmb3IgSFZNIFZNczogTVNSX1NQRUNfQ1RSTCBSU0IgRUFHRVJfRlBV IE1EX0NMRUFSCihYRU4pICAgU3VwcG9ydCBmb3IgUFYgVk1zOiBNU1JfU1BFQ19DVFJMIEVBR0VS X0ZQVSBNRF9DTEVBUgooWEVOKSAgIFhQVEkgKDY0LWJpdCBQViBvbmx5KTogRG9tMCBkaXNhYmxl ZCwgRG9tVSBkaXNhYmxlZCAod2l0aCBQQ0lEKQooWEVOKSAgIFBWIEwxVEYgc2hhZG93aW5nOiBE b20wIGRpc2FibGVkLCBEb21VIGRpc2FibGVkCihYRU4pIFVzaW5nIHNjaGVkdWxlcjogU01QIENy ZWRpdCBTY2hlZHVsZXIgcmV2MiAoY3JlZGl0MikKKFhFTikgSW5pdGlhbGl6aW5nIENyZWRpdDIg c2NoZWR1bGVyCihYRU4pICBsb2FkX3ByZWNpc2lvbl9zaGlmdDogMTgKKFhFTikgIGxvYWRfd2lu ZG93X3NoaWZ0OiAzMAooWEVOKSAgdW5kZXJsb2FkX2JhbGFuY2VfdG9sZXJhbmNlOiAwCihYRU4p ICBvdmVybG9hZF9iYWxhbmNlX3RvbGVyYW5jZTogLTMKKFhFTikgIHJ1bnF1ZXVlcyBhcnJhbmdl bWVudDogc29ja2V0CihYRU4pICBjYXAgZW5mb3JjZW1lbnQgZ3JhbnVsYXJpdHk6IDEwbXMKKFhF TikgbG9hZCB0cmFja2luZyB3aW5kb3cgbGVuZ3RoIDEwNzM3NDE4MjQgbnMKKFhFTikgUGxhdGZv cm0gdGltZXIgaXMgMjQuMDAwTUh6IEhQRVQKKFhFTikgRGV0ZWN0ZWQgMjM5NC4zNzUgTUh6IHBy b2Nlc3Nvci4KKFhFTikgRUZJIG1lbW9yeSBtYXA6CihYRU4pICAwMDAwMDAwMDAwMDAwLTAwMDAw MDAwODZmZmYgdHlwZT03IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDAwMDA4NzAw MC0wMDAwMDAwMDg3ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAw MDAwODgwMDAtMDAwMDAwMDA5YmZmZiB0eXBlPTcgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4p ICAwMDAwMDAwMDljMDAwLTAwMDAwMDAwOWRmZmYgdHlwZT0yIGF0dHI9MDAwMDAwMDAwMDAwMDAw ZgooWEVOKSAgMDAwMDAwMDA5ZTAwMC0wMDAwMDAwMDllZmZmIHR5cGU9MCBhdHRyPTAwMDAwMDAw MDAwMDAwMGYKKFhFTikgIDAwMDAwMDAwOWYwMDAtMDAwMDAwMDA5ZmZmZiB0eXBlPTEwIGF0dHI9 MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDAwMDEwMDAwMC0wMDAwMDU2N2UwZmZmIHR5cGU9 NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNTY3ZTEwMDAtMDAwMDA1ODM4NGZm ZiB0eXBlPTIgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDU4Mzg1MDAwLTAwMDAw NTg0NjRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ODQ2NTAw MC0wMDAwMDU4YTczZmZmIHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAw NThhNzQwMDAtMDAwMDA1OTI3MmZmZiB0eXBlPTIgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4p ICAwMDAwMDU5MjczMDAwLTAwMDAwNWE0NzJmZmYgdHlwZT0xIGF0dHI9MDAwMDAwMDAwMDAwMDAw ZgooWEVOKSAgMDAwMDA1YTQ3MzAwMC0wMDAwMDVhNDc1ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAw MDAwMDAwMGYKKFhFTikgIDAwMDAwNWE0NzYwMDAtMDAwMDA1YTdiM2ZmZiB0eXBlPTcgYXR0cj0w MDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVhN2I0MDAwLTAwMDAwNWE5YjdmZmYgdHlwZT00 IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YTliODAwMC0wMDAwMDVhOWM0ZmZm IHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWE5YzUwMDAtMDAwMDA1 YWE1ZmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVhYTYwMDAw LTAwMDAwNWFhNjNmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1 YWE2NDAwMC0wMDAwMDVhYTY2ZmZmIHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikg IDAwMDAwNWFhNjcwMDAtMDAwMDA1YWYwMmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBm CihYRU4pICAwMDAwMDVhZjAzMDAwLTAwMDAwNWFmMGRmZmYgdHlwZT03IGF0dHI9MDAwMDAwMDAw MDAwMDAwZgooWEVOKSAgMDAwMDA1YWYwZTAwMC0wMDAwMDViMTI0ZmZmIHR5cGU9NCBhdHRyPTAw MDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWIxMjUwMDAtMDAwMDA1YjEyOGZmZiB0eXBlPTcg YXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViMTI5MDAwLTAwMDAwNWIxZmVmZmYg dHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjFmZjAwMC0wMDAwMDVi MjAyZmZmIHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWIyMDMwMDAt MDAwMDA1YjJhN2ZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVi MmE4MDAwLTAwMDAwNWIzNmFmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAg MDAwMDA1YjM2YjAwMC0wMDAwMDViNDJkZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYK KFhFTikgIDAwMDAwNWI0MmUwMDAtMDAwMDA1YjQ1ZmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAw MDAwMDBmCihYRU4pICAwMDAwMDViNDYwMDAwLTAwMDAwNWI1MTNmZmYgdHlwZT00IGF0dHI9MDAw MDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjUxNDAwMC0wMDAwMDViNTQ3ZmZmIHR5cGU9MyBh dHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI1NDgwMDAtMDAwMDA1YjU1M2ZmZiB0 eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViNTU0MDAwLTAwMDAwNWI1 N2JmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjU3YzAwMC0w MDAwMDViNWQzZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI1 ZDQwMDAtMDAwMDA1YjczZWZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAw MDAwMDViNzNmMDAwLTAwMDAwNWI3NDRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgoo WEVOKSAgMDAwMDA1Yjc0NTAwMC0wMDAwMDViNzg2ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAw MDAwMGYKKFhFTikgIDAwMDAwNWI3ODcwMDAtMDAwMDA1Yjc4YmZmZiB0eXBlPTQgYXR0cj0wMDAw MDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViNzhjMDAwLTAwMDAwNWI3YThmZmYgdHlwZT0zIGF0 dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjdhOTAwMC0wMDAwMDViN2FlZmZmIHR5 cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI3YWYwMDAtMDAwMDA1Yjgx ZmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViODIwMDAwLTAw MDAwNWI4MmFmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1Yjgy YjAwMC0wMDAwMDViODU2ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAw MDAwNWI4NTcwMDAtMDAwMDA1Yjg1YWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihY RU4pICAwMDAwMDViODViMDAwLTAwMDAwNWI4YjVmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAw MDAwZgooWEVOKSAgMDAwMDA1YjhiNjAwMC0wMDAwMDViOGI2ZmZmIHR5cGU9NCBhdHRyPTAwMDAw MDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI4YjcwMDAtMDAwMDA1YjhlMGZmZiB0eXBlPTMgYXR0 cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViOGUxMDAwLTAwMDAwNWI4ZTNmZmYgdHlw ZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjhlNDAwMC0wMDAwMDViOGYz ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI4ZjQwMDAtMDAw MDA1YjhmNGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViOGY1 MDAwLTAwMDAwNWI5MDBmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAw MDA1YjkwMTAwMC0wMDAwMDViOTA2ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhF TikgIDAwMDAwNWI5MDcwMDAtMDAwMDA1YjkwYmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAw MDBmCihYRU4pICAwMDAwMDViOTBjMDAwLTAwMDAwNWI5MTBmZmYgdHlwZT00IGF0dHI9MDAwMDAw MDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjkxMTAwMC0wMDAwMDViOTYyZmZmIHR5cGU9MyBhdHRy PTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI5NjMwMDAtMDAwMDA1Yjk2NWZmZiB0eXBl PTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDViOTY2MDAwLTAwMDAwNWI5NzNm ZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1Yjk3NDAwMC0wMDAw MDViOTc2ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWI5Nzcw MDAtMDAwMDA1Yjk5M2ZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAw MDViOTk0MDAwLTAwMDAwNWI5OTdmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVO KSAgMDAwMDA1Yjk5ODAwMC0wMDAwMDViOWE5ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAw MGYKKFhFTikgIDAwMDAwNWI5YWEwMDAtMDAwMDA1YjlhYWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAw MDAwMDAwMDBmCihYRU4pICAwMDAwMDViOWFiMDAwLTAwMDAwNWI5YjRmZmYgdHlwZT0zIGF0dHI9 MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YjliNTAwMC0wMDAwMDVjM2RmZmZmIHR5cGU9 NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWMzZTAwMDAtMDAwMDA1YzQwZmZm ZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjNDEwMDAwLTAwMDAw NWM0M2ZmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzQ0MDAw MC0wMDAwMDVjNDUyZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAw NWM0NTMwMDAtMDAwMDA1YzQ2NWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4p ICAwMDAwMDVjNDY2MDAwLTAwMDAwNWM0NzBmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAw ZgooWEVOKSAgMDAwMDA1YzQ3MTAwMC0wMDAwMDVjNDcxZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAw MDAwMDAwMGYKKFhFTikgIDAwMDAwNWM0NzIwMDAtMDAwMDA1YzQ3NWZmZiB0eXBlPTMgYXR0cj0w MDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjNDc2MDAwLTAwMDAwNWM0NzlmZmYgdHlwZT00 IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzQ3YTAwMC0wMDAwMDVjNDgyZmZm IHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM0ODMwMDAtMDAwMDA1 YzQ4M2ZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjNDg0MDAw LTAwMDAwNWM0ODZmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1 YzQ4NzAwMC0wMDAwMDVjNTgwZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikg IDAwMDAwNWM1ODEwMDAtMDAwMDA1YzVhM2ZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBm CihYRU4pICAwMDAwMDVjNWE0MDAwLTAwMDAwNWM1YjVmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAw MDAwMDAwZgooWEVOKSAgMDAwMDA1YzViNjAwMC0wMDAwMDVjNWY0ZmZmIHR5cGU9MyBhdHRyPTAw MDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM1ZjUwMDAtMDAwMDA1YzY3M2ZmZiB0eXBlPTQg YXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjNjc0MDAwLTAwMDAwNWM2YzJmZmYg dHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzZjMzAwMC0wMDAwMDVj NmYzZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM2ZjQwMDAt MDAwMDA1YzZmZGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVj NmZlMDAwLTAwMDAwNWM3MDdmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAg MDAwMDA1YzcwODAwMC0wMDAwMDVjNzg0ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYK KFhFTikgIDAwMDAwNWM3ODUwMDAtMDAwMDA1YzdhMGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAw MDAwMDBmCihYRU4pICAwMDAwMDVjN2ExMDAwLTAwMDAwNWM3YThmZmYgdHlwZT0zIGF0dHI9MDAw MDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzdhOTAwMC0wMDAwMDVjN2FiZmZmIHR5cGU9NCBh dHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM3YWMwMDAtMDAwMDA1YzdkM2ZmZiB0 eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjN2Q0MDAwLTAwMDAwNWM3 ZDRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzdkNTAwMC0w MDAwMDVjN2Q4ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM3 ZDkwMDAtMDAwMDA1YzdkY2ZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAw MDAwMDVjN2RkMDAwLTAwMDAwNWM4MGNmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgoo WEVOKSAgMDAwMDA1YzgwZDAwMC0wMDAwMDVjODBmZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAw MDAwMGYKKFhFTikgIDAwMDAwNWM4MTAwMDAtMDAwMDA1YzgxOWZmZiB0eXBlPTMgYXR0cj0wMDAw MDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjODFhMDAwLTAwMDAwNWM4MWFmZmYgdHlwZT00IGF0 dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzgxYjAwMC0wMDAwMDVjODNmZmZmIHR5 cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM4NDAwMDAtMDAwMDA1Yzg0 NGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjODQ1MDAwLTAw MDAwNWM4NGVmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1Yzg0 ZjAwMC0wMDAwMDVjODUzZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAw MDAwNWM4NTQwMDAtMDAwMDA1Yzg1OGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihY RU4pICAwMDAwMDVjODU5MDAwLTAwMDAwNWM5NzBmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAw MDAwZgooWEVOKSAgMDAwMDA1Yzk3MTAwMC0wMDAwMDVjOTdjZmZmIHR5cGU9MyBhdHRyPTAwMDAw MDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM5N2QwMDAtMDAwMDA1Yzk4OGZmZiB0eXBlPTQgYXR0 cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjOTg5MDAwLTAwMDAwNWM5OTlmZmYgdHlw ZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1Yzk5YTAwMC0wMDAwMDVjOTll ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM5OWYwMDAtMDAw MDA1YzlhNGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjOWE1 MDAwLTAwMDAwNWM5YWFmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAw MDA1YzlhYjAwMC0wMDAwMDVjOWI1ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhF TikgIDAwMDAwNWM5YjYwMDAtMDAwMDA1YzliNmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAw MDBmCihYRU4pICAwMDAwMDVjOWI3MDAwLTAwMDAwNWM5YmJmZmYgdHlwZT0zIGF0dHI9MDAwMDAw MDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzliYzAwMC0wMDAwMDVjOWMwZmZmIHR5cGU9NCBhdHRy PTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM5YzEwMDAtMDAwMDA1YzlkMWZmZiB0eXBl PTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVjOWQyMDAwLTAwMDAwNWM5ZDNm ZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1YzlkNDAwMC0wMDAw MDVjOWRhZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWM5ZGIw MDAtMDAwMDA1YzllNGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAw MDVjOWU1MDAwLTAwMDAwNWM5ZThmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVO KSAgMDAwMDA1YzllOTAwMC0wMDAwMDVkNmI3ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAw MGYKKFhFTikgIDAwMDAwNWQ2YjgwMDAtMDAwMDA1ZDZkOGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAw MDAwMDAwMDBmCihYRU4pICAwMDAwMDVkNmQ5MDAwLTAwMDAwNWQ2ZThmZmYgdHlwZT00IGF0dHI9 MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZDZlOTAwMC0wMDAwMDVkNmVjZmZmIHR5cGU9 MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWQ2ZWQwMDAtMDAwMDA1ZDZmMGZm ZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkNmYxMDAwLTAwMDAw NWQ2ZmJmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZDZmYzAw MC0wMDAwMDVkNmZkZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAw NWQ2ZmUwMDAtMDAwMDA1ZDcwMWZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4p ICAwMDAwMDVkNzAyMDAwLTAwMDAwNWQ3MDZmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAw ZgooWEVOKSAgMDAwMDA1ZDcwNzAwMC0wMDAwMDVkNzQ0ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAw MDAwMDAwMGYKKFhFTikgIDAwMDAwNWQ3NDUwMDAtMDAwMDA1ZDc0NWZmZiB0eXBlPTQgYXR0cj0w MDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkNzQ2MDAwLTAwMDAwNWQ3NjlmZmYgdHlwZT0z IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZDc2YTAwMC0wMDAwMDVkNzZhZmZm IHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWQ3NmIwMDAtMDAwMDA1 ZDc2ZGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkNzZlMDAw LTAwMDAwNWQ3NzBmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1 ZDc3MTAwMC0wMDAwMDVkNzc2ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikg IDAwMDAwNWQ3NzcwMDAtMDAwMDA1ZDc3OWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBm CihYRU4pICAwMDAwMDVkNzdhMDAwLTAwMDAwNWQ3YzBmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAw MDAwMDAwZgooWEVOKSAgMDAwMDA1ZDdjMTAwMC0wMDAwMDVkN2MzZmZmIHR5cGU9NCBhdHRyPTAw MDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWQ3YzQwMDAtMDAwMDA1ZDdmM2ZmZiB0eXBlPTMg YXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkN2Y0MDAwLTAwMDAwNWRlMDJmZmYg dHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGUwMzAwMC0wMDAwMDVk ZTIwZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRlMjEwMDAt MDAwMDA1ZGUyM2ZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVk ZTI0MDAwLTAwMDAwNWRlMjVmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAg MDAwMDA1ZGUyNjAwMC0wMDAwMDVkZTI2ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYK KFhFTikgIDAwMDAwNWRlMjcwMDAtMDAwMDA1ZGUzOWZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAw MDAwMDBmCihYRU4pICAwMDAwMDVkZTNhMDAwLTAwMDAwNWRlNDdmZmYgdHlwZT00IGF0dHI9MDAw MDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGU0ODAwMC0wMDAwMDVkZTYyZmZmIHR5cGU9MyBh dHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRlNjMwMDAtMDAwMDA1ZGU2NWZmZiB0 eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZTY2MDAwLTAwMDAwNWRl NjlmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGU2YTAwMC0w MDAwMDVkZTZhZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRl NmIwMDAtMDAwMDA1ZGU3MmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAw MDAwMDVkZTczMDAwLTAwMDAwNWRlNzdmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgoo WEVOKSAgMDAwMDA1ZGU3ODAwMC0wMDAwMDVkZjAwZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAw MDAwMGYKKFhFTikgIDAwMDAwNWRmMDEwMDAtMDAwMDA1ZGYwMmZmZiB0eXBlPTQgYXR0cj0wMDAw MDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjAzMDAwLTAwMDAwNWRmMGRmZmYgdHlwZT0zIGF0 dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGYwZTAwMC0wMDAwMDVkZjExZmZmIHR5 cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmMTIwMDAtMDAwMDA1ZGYy MmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjIzMDAwLTAw MDAwNWRmMjNmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGYy NDAwMC0wMDAwMDVkZjI2ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAw MDAwNWRmMjcwMDAtMDAwMDA1ZGYyYmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihY RU4pICAwMDAwMDVkZjJjMDAwLTAwMDAwNWRmMmVmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAw MDAwZgooWEVOKSAgMDAwMDA1ZGYyZjAwMC0wMDAwMDVkZjMxZmZmIHR5cGU9NCBhdHRyPTAwMDAw MDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmMzIwMDAtMDAwMDA1ZGYzN2ZmZiB0eXBlPTMgYXR0 cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjM4MDAwLTAwMDAwNWRmM2JmZmYgdHlw ZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGYzYzAwMC0wMDAwMDVkZjQx ZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmNDIwMDAtMDAw MDA1ZGY0NGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjQ1 MDAwLTAwMDAwNWRmNThmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAw MDA1ZGY1OTAwMC0wMDAwMDVkZjU5ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhF TikgIDAwMDAwNWRmNWEwMDAtMDAwMDA1ZGY2M2ZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAw MDBmCihYRU4pICAwMDAwMDVkZjY0MDAwLTAwMDAwNWRmNjVmZmYgdHlwZT00IGF0dHI9MDAwMDAw MDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGY2NjAwMC0wMDAwMDVkZjY4ZmZmIHR5cGU9MyBhdHRy PTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmNjkwMDAtMDAwMDA1ZGY2OWZmZiB0eXBl PTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjZhMDAwLTAwMDAwNWRmNzJm ZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGY3MzAwMC0wMDAw MDVkZjczZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmNzQw MDAtMDAwMDA1ZGY3NmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAw MDVkZjc3MDAwLTAwMDAwNWRmNzdmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVO KSAgMDAwMDA1ZGY3ODAwMC0wMDAwMDVkZjgxZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAw MGYKKFhFTikgIDAwMDAwNWRmODIwMDAtMDAwMDA1ZGY4MmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAw MDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjgzMDAwLTAwMDAwNWRmODRmZmYgdHlwZT0zIGF0dHI9 MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGY4NTAwMC0wMDAwMDVkZjg2ZmZmIHR5cGU9 NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWRmODcwMDAtMDAwMDA1ZGY4OWZm ZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVkZjhhMDAwLTAwMDAw NWRmZjBmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZGZmMTAw MC0wMDAwMDVlMDIwZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAw NWUwMjEwMDAtMDAwMDA1ZTAyMWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4p ICAwMDAwMDVlMDIyMDAwLTAwMDAwNWUwMjNmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAw ZgooWEVOKSAgMDAwMDA1ZTAyNDAwMC0wMDAwMDVlMDI2ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAw MDAwMDAwMGYKKFhFTikgIDAwMDAwNWUwMjcwMDAtMDAwMDA1ZTAyZGZmZiB0eXBlPTMgYXR0cj0w MDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVlMDJlMDAwLTAwMDAwNWUwMzBmZmYgdHlwZT00 IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZTAzMTAwMC0wMDAwMDVlMDMyZmZm IHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWUwMzMwMDAtMDAwMDA1 ZTAzNGZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVlMDM1MDAw LTAwMDAwNWUwMzVmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1 ZTAzNjAwMC0wMDAwMDVlMDM3ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikg IDAwMDAwNWUwMzgwMDAtMDAwMDA1ZTA0MWZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBm CihYRU4pICAwMDAwMDVlMDQyMDAwLTAwMDAwNWUwNDRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAw MDAwMDAwZgooWEVOKSAgMDAwMDA1ZTA0NTAwMC0wMDAwMDVlMDQ3ZmZmIHR5cGU9MyBhdHRyPTAw MDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWUwNDgwMDAtMDAwMDA1ZTA0YWZmZiB0eXBlPTQg YXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVlMDRiMDAwLTAwMDAwNWUwNGNmZmYg dHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA1ZTA0ZDAwMC0wMDAwMDVl MDRmZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNWUwNTAwMDAt MDAwMDA1ZTA1MWZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDVl MDUyMDAwLTAwMDAwNWUwNTRmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAg MDAwMDA1ZTA1NTAwMC0wMDAwMDVlMDVhZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYK KFhFTikgIDAwMDAwNWUwNWIwMDAtMDAwMDA2MzU4MmZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAw MDAwMDBmCihYRU4pICAwMDAwMDYzNTgzMDAwLTAwMDAwNjM2ODJmZmYgdHlwZT02IGF0dHI9ODAw MDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2MzY4MzAwMC0wMDAwMDYzODQ0ZmZmIHR5cGU9NSBh dHRyPTgwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNjM4NDUwMDAtMDAwMDA2NGVjYmZmZiB0 eXBlPTAgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDY0ZWNjMDAwLTAwMDAwNjY1 MWFmZmYgdHlwZT0xMCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNjY1MWIwMDAt MDAwMDA2NjlmZGZmZiB0eXBlPTkgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDY2 OWZlMDAwLTAwMDAwNjZiZmZmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAg MDAwMDA2NmMwMDAwMC0wMDAwMDY2ZGNhZmZmIHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYK KFhFTikgIDAwMDAwNjZkY2IwMDAtMDAwMDA2NmRlYWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAw MDAwMDBmCihYRU4pICAwMDAwMDY2ZGViMDAwLTAwMDAwNjZlMzJmZmYgdHlwZT0zIGF0dHI9MDAw MDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2NmUzMzAwMC0wMDAwMDY2ZTQ2ZmZmIHR5cGU9NCBh dHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNjZlNDcwMDAtMDAwMDA2NmU0OWZmZiB0 eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDY2ZTRhMDAwLTAwMDAwNjZl NWNmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2NmU1ZDAwMC0w MDAwMDY2ZTkyZmZmIHR5cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNjZl OTMwMDAtMDAwMDA2YmY3YWZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAw MDAwMDZiZjdiMDAwLTAwMDAwNmJmN2VmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgoo WEVOKSAgMDAwMDA2YmY3ZjAwMC0wMDAwMDZiZjkyZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAw MDAwMGYKKFhFTikgIDAwMDAwNmJmOTMwMDAtMDAwMDA2YmY5NWZmZiB0eXBlPTMgYXR0cj0wMDAw MDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDZiZjk2MDAwLTAwMDAwNmJmYThmZmYgdHlwZT00IGF0 dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2YmZhOTAwMC0wMDAwMDZiZmIxZmZmIHR5 cGU9MyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNmJmYjIwMDAtMDAwMDA2YzIw Y2ZmZiB0eXBlPTQgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDZjMjBkMDAwLTAw MDAwNmMyMTdmZmYgdHlwZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2YzIx ODAwMC0wMDAwMDZjMjMyZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAw MDAwNmMyMzMwMDAtMDAwMDA2YzI1YmZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihY RU4pICAwMDAwMDZjMjVjMDAwLTAwMDAwNmMyNmZmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAw MDAwZgooWEVOKSAgMDAwMDA2YzI3MDAwMC0wMDAwMDZjMjcyZmZmIHR5cGU9MyBhdHRyPTAwMDAw MDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNmMyNzMwMDAtMDAwMDA2YzJjN2ZmZiB0eXBlPTQgYXR0 cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDZjMmM4MDAwLTAwMDAwNmMyZDJmZmYgdHlw ZT0zIGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAwMDA2YzJkMzAwMC0wMDAwMDZjMmQ0 ZmZmIHR5cGU9NCBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhFTikgIDAwMDAwNmMyZDUwMDAtMDAw MDA2YzJlNGZmZiB0eXBlPTMgYXR0cj0wMDAwMDAwMDAwMDAwMDBmCihYRU4pICAwMDAwMDZjMmU1 MDAwLTAwMDAwNmMzN2ZmZmYgdHlwZT00IGF0dHI9MDAwMDAwMDAwMDAwMDAwZgooWEVOKSAgMDAw MDA2YzM4MDAwMC0wMDAwMDZmN2ZmZmZmIHR5cGU9NyBhdHRyPTAwMDAwMDAwMDAwMDAwMGYKKFhF TikgIDAwMDAxMDAwMDAwMDAtMDAwNDA3ZmZmZmZmZiB0eXBlPTcgYXR0cj0wMDAwMDAwMDAwMDAw MDBmCihYRU4pICAwMDAwMDAwMGEwMDAwLTAwMDAwMDAwZmZmZmYgdHlwZT0wIGF0dHI9MDAwMDAw MDAwMDAwMDAwMAooWEVOKSAgMDAwMDA2ZjgwMDAwMC0wMDAwMDZmZmZmZmZmIHR5cGU9MCBhdHRy PTAwMDAwMDAwMDAwMDAwMDAKKFhFTikgIDAwMDAwNzAwMDAwMDAtMDAwMDA3N2JmZmZmZiB0eXBl PTAgYXR0cj0wMDAwMDAwMDAwMDAwMDA5CihYRU4pICAwMDAwMDc3YzAwMDAwLTAwMDAwN2ZmZmZm ZmYgdHlwZT0wIGF0dHI9MDAwMDAwMDAwMDAwMDAwMAooWEVOKSAgMDAwMDA4MDAwMDAwMC0wMDAw MDhmZmZmZmZmIHR5cGU9MTEgYXR0cj04MDAwMDAwMDAwMDAwMDAxCihYRU4pICAwMDAwMGZlMDAw MDAwLTAwMDAwZmUwMTBmZmYgdHlwZT0xMSBhdHRyPTgwMDAwMDAwMDAwMDAwMDEKKFhFTikgYWx0 IHRhYmxlIGZmZmY4MmQwNDA2OTMwZjAgLT4gZmZmZjgyZDA0MDZhMTMyMAooWEVOKSAwMDAwOjAw OjFmLjUgZGlzYWJsZWQ6IEJBUiBbMHhmZTAxMCwgMHhmZTAxMF0gb3ZlcmxhcHMgd2l0aCBtZW1v cnkgbWFwCihYRU4pIEludGVsIFZULWQgaW9tbXUgOCBzdXBwb3J0ZWQgcGFnZSBzaXplczogNGtC LCAyTUIsIDFHQgooWEVOKSBJbnRlbCBWVC1kIGlvbW11IDcgc3VwcG9ydGVkIHBhZ2Ugc2l6ZXM6 IDRrQiwgMk1CLCAxR0IKKFhFTikgSW50ZWwgVlQtZCBpb21tdSA2IHN1cHBvcnRlZCBwYWdlIHNp emVzOiA0a0IsIDJNQiwgMUdCCihYRU4pIEludGVsIFZULWQgaW9tbXUgNSBzdXBwb3J0ZWQgcGFn ZSBzaXplczogNGtCLCAyTUIsIDFHQgooWEVOKSBJbnRlbCBWVC1kIGlvbW11IDQgc3VwcG9ydGVk IHBhZ2Ugc2l6ZXM6IDRrQiwgMk1CLCAxR0IKKFhFTikgSW50ZWwgVlQtZCBpb21tdSAzIHN1cHBv cnRlZCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdCCihYRU4pIEludGVsIFZULWQgaW9tbXUgMiBz dXBwb3J0ZWQgcGFnZSBzaXplczogNGtCLCAyTUIsIDFHQgooWEVOKSBJbnRlbCBWVC1kIGlvbW11 IDEgc3VwcG9ydGVkIHBhZ2Ugc2l6ZXM6IDRrQiwgMk1CLCAxR0IKKFhFTikgSW50ZWwgVlQtZCBp b21tdSAwIHN1cHBvcnRlZCBwYWdlIHNpemVzOiA0a0IsIDJNQiwgMUdCCihYRU4pIEludGVsIFZU LWQgaW9tbXUgOSBzdXBwb3J0ZWQgcGFnZSBzaXplczogNGtCLCAyTUIsIDFHQgooWEVOKSBJbnRl bCBWVC1kIFNub29wIENvbnRyb2wgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBEb20wIERNQSBQ YXNzdGhyb3VnaCBub3QgZW5hYmxlZC4KKFhFTikgSW50ZWwgVlQtZCBRdWV1ZWQgSW52YWxpZGF0 aW9uIGVuYWJsZWQuCihYRU4pIEludGVsIFZULWQgSW50ZXJydXB0IFJlbWFwcGluZyBlbmFibGVk LgooWEVOKSBJbnRlbCBWVC1kIFBvc3RlZCBJbnRlcnJ1cHQgZW5hYmxlZC4KKFhFTikgSW50ZWwg VlQtZCBTaGFyZWQgRVBUIHRhYmxlcyBlbmFibGVkLgooWEVOKSBJL08gdmlydHVhbGlzYXRpb24g ZW5hYmxlZAooWEVOKSAgLSBEb20wIG1vZGU6IFJlbGF4ZWQKKFhFTikgSW50ZXJydXB0IHJlbWFw cGluZyBlbmFibGVkCihYRU4pIG5yX3NvY2tldHM6IDIKKFhFTikgRW5hYmxlZCBkaXJlY3RlZCBF T0kgd2l0aCBpb2FwaWNfYWNrX29sZCBvbiEKKFhFTikgRW5hYmxpbmcgQVBJQyBtb2RlOiAgQ2x1 c3RlcmVkLiAgVXNpbmcgMSBJL08gQVBJQ3MKKFhFTikgRU5BQkxJTkcgSU8tQVBJQyBJUlFzCihY RU4pICAtPiBVc2luZyBvbGQgQUNLIG1ldGhvZAooWEVOKSAuLlRJTUVSOiB2ZWN0b3I9MHhGMCBh cGljMT0wIHBpbjE9MiBhcGljMj0tMSBwaW4yPS0xCihYRU4pIFRTQyBkZWFkbGluZSB0aW1lciBl bmFibGVkCihYRU4pIERlZmF1bHRpbmcgdG8gYWx0ZXJuYXRpdmUga2V5IGhhbmRsaW5nOyBzZW5k ICdBJyB0byBzd2l0Y2ggdG8gbm9ybWFsIG1vZGUuCihYRU4pIG13YWl0LWlkbGU6IE1XQUlUIHN1 YnN0YXRlczogMHgxMDIwCihYRU4pIG13YWl0LWlkbGU6IHYwLjQuMSBtb2RlbCAweDZhCihYRU4p IG13YWl0LWlkbGU6IGxhcGljX3RpbWVyX3JlbGlhYmxlX3N0YXRlcyAweGZmZmZmZmZmCihYRU4p IFZQTVU6IFBNVSB2ZXJzaW9uIDUgaXMgbm90IGZ1bGx5IHN1cHBvcnRlZC4gRW11bGF0aW5nIHZl cnNpb24gMwooWEVOKSBWUE1VOiB2ZXJzaW9uIDAuMQooWEVOKSBWTVg6IFN1cHBvcnRlZCBhZHZh bmNlZCBmZWF0dXJlczoKKFhFTikgIC0gQVBJQyBNTUlPIGFjY2VzcyB2aXJ0dWFsaXNhdGlvbgoo WEVOKSAgLSBBUElDIFRQUiBzaGFkb3cKKFhFTikgIC0gRXh0ZW5kZWQgUGFnZSBUYWJsZXMgKEVQ VCkKKFhFTikgIC0gVmlydHVhbC1Qcm9jZXNzb3IgSWRlbnRpZmllcnMgKFZQSUQpCihYRU4pICAt IFZpcnR1YWwgTk1JCihYRU4pICAtIE1TUiBkaXJlY3QtYWNjZXNzIGJpdG1hcAooWEVOKSAgLSBV bnJlc3RyaWN0ZWQgR3Vlc3QKKFhFTikgIC0gQVBJQyBSZWdpc3RlciBWaXJ0dWFsaXphdGlvbgoo WEVOKSAgLSBWaXJ0dWFsIEludGVycnVwdCBEZWxpdmVyeQooWEVOKSAgLSBQb3N0ZWQgSW50ZXJy dXB0IFByb2Nlc3NpbmcKKFhFTikgIC0gVk1DUyBzaGFkb3dpbmcKKFhFTikgIC0gVk0gRnVuY3Rp b25zCihYRU4pICAtIFZpcnR1YWxpc2F0aW9uIEV4Y2VwdGlvbnMKKFhFTikgIC0gUGFnZSBNb2Rp ZmljYXRpb24gTG9nZ2luZwooWEVOKSAgLSBUU0MgU2NhbGluZwooWEVOKSBIVk06IEFTSURzIGVu YWJsZWQuCihYRU4pIEhWTTogVk1YIGVuYWJsZWQKKFhFTikgSFZNOiBIYXJkd2FyZSBBc3Npc3Rl ZCBQYWdpbmcgKEhBUCkgZGV0ZWN0ZWQKKFhFTikgSFZNOiBIQVAgcGFnZSBzaXplczogNGtCLCAy TUIsIDFHQgooWEVOKSBDYWNoZSBNb25pdG9yaW5nIFRlY2hub2xvZ3kgZW5hYmxlZAooWEVOKSBh bHQgdGFibGUgZmZmZjgyZDA0MDY5MzBmMCAtPiBmZmZmODJkMDQwNmExMzIwCihYRU4pIEJyb3Vn aHQgdXAgOTYgQ1BVcwooWEVOKSBTY2hlZHVsaW5nIGdyYW51bGFyaXR5OiBjcHUsIDEgQ1BVIHBl ciBzY2hlZC1yZXNvdXJjZQooWEVOKSBJbml0aWFsaXppbmcgQ3JlZGl0MiBzY2hlZHVsZXIKKFhF TikgIGxvYWRfcHJlY2lzaW9uX3NoaWZ0OiAxOAooWEVOKSAgbG9hZF93aW5kb3dfc2hpZnQ6IDMw CihYRU4pICB1bmRlcmxvYWRfYmFsYW5jZV90b2xlcmFuY2U6IDAKKFhFTikgIG92ZXJsb2FkX2Jh bGFuY2VfdG9sZXJhbmNlOiAtMwooWEVOKSAgcnVucXVldWVzIGFycmFuZ2VtZW50OiBzb2NrZXQK KFhFTikgIGNhcCBlbmZvcmNlbWVudCBncmFudWxhcml0eTogMTBtcwooWEVOKSBsb2FkIHRyYWNr aW5nIHdpbmRvdyBsZW5ndGggMTA3Mzc0MTgyNCBucwooWEVOKSBBZGRpbmcgY3B1IDAgdG8gcnVu cXVldWUgMAooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nCihYRU4pIEFk ZGluZyBjcHUgMSB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgMiB0byBydW5xdWV1ZSAw CihYRU4pIEFkZGluZyBjcHUgMyB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgNCB0byBy dW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgNSB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBj cHUgNiB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgNyB0byBydW5xdWV1ZSAwCihYRU4p IEFkZGluZyBjcHUgOCB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgOSB0byBydW5xdWV1 ZSAwCihYRU4pIEFkZGluZyBjcHUgMTAgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDEx IHRvIHJ1bnF1ZXVlIDAKKFhFTikgQWRkaW5nIGNwdSAxMiB0byBydW5xdWV1ZSAwCihYRU4pIEFk ZGluZyBjcHUgMTMgdG8gcnVucXVldWUgMAooWEVOKSBBZGRpbmcgY3B1IDE0IHRvIHJ1bnF1ZXVl IDAKKFhFTikgQWRkaW5nIGNwdSAxNSB0byBydW5xdWV1ZSAwCihYRU4pIEFkZGluZyBjcHUgMTYg dG8gcnVucXVldWUgMQooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nCihY RU4pIEFkZGluZyBjcHUgMTcgdG8gcnVucXVldWUgMQooWEVOKSBBZGRpbmcgY3B1IDE4IHRvIHJ1 bnF1ZXVlIDEKKFhFTikgQWRkaW5nIGNwdSAxOSB0byBydW5xdWV1ZSAxCihYRU4pIEFkZGluZyBj cHUgMjAgdG8gcnVucXVldWUgMQooWEVOKSBBZGRpbmcgY3B1IDIxIHRvIHJ1bnF1ZXVlIDEKKFhF TikgQWRkaW5nIGNwdSAyMiB0byBydW5xdWV1ZSAxCihYRU4pIEFkZGluZyBjcHUgMjMgdG8gcnVu cXVldWUgMQooWEVOKSBBZGRpbmcgY3B1IDI0IHRvIHJ1bnF1ZXVlIDEKKFhFTikgQWRkaW5nIGNw dSAyNSB0byBydW5xdWV1ZSAxCihYRU4pIEFkZGluZyBjcHUgMjYgdG8gcnVucXVldWUgMQooWEVO KSBBZGRpbmcgY3B1IDI3IHRvIHJ1bnF1ZXVlIDEKKFhFTikgQWRkaW5nIGNwdSAyOCB0byBydW5x dWV1ZSAxCihYRU4pIEFkZGluZyBjcHUgMjkgdG8gcnVucXVldWUgMQooWEVOKSBBZGRpbmcgY3B1 IDMwIHRvIHJ1bnF1ZXVlIDEKKFhFTikgQWRkaW5nIGNwdSAzMSB0byBydW5xdWV1ZSAxCihYRU4p IEFkZGluZyBjcHUgMzIgdG8gcnVucXVldWUgMgooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVl LCBhY3RpdmF0aW5nCihYRU4pIEFkZGluZyBjcHUgMzMgdG8gcnVucXVldWUgMgooWEVOKSBBZGRp bmcgY3B1IDM0IHRvIHJ1bnF1ZXVlIDIKKFhFTikgQWRkaW5nIGNwdSAzNSB0byBydW5xdWV1ZSAy CihYRU4pIEFkZGluZyBjcHUgMzYgdG8gcnVucXVldWUgMgooWEVOKSBBZGRpbmcgY3B1IDM3IHRv IHJ1bnF1ZXVlIDIKKFhFTikgQWRkaW5nIGNwdSAzOCB0byBydW5xdWV1ZSAyCihYRU4pIEFkZGlu ZyBjcHUgMzkgdG8gcnVucXVldWUgMgooWEVOKSBBZGRpbmcgY3B1IDQwIHRvIHJ1bnF1ZXVlIDIK KFhFTikgQWRkaW5nIGNwdSA0MSB0byBydW5xdWV1ZSAyCihYRU4pIEFkZGluZyBjcHUgNDIgdG8g cnVucXVldWUgMgooWEVOKSBBZGRpbmcgY3B1IDQzIHRvIHJ1bnF1ZXVlIDIKKFhFTikgQWRkaW5n IGNwdSA0NCB0byBydW5xdWV1ZSAyCihYRU4pIEFkZGluZyBjcHUgNDUgdG8gcnVucXVldWUgMgoo WEVOKSBBZGRpbmcgY3B1IDQ2IHRvIHJ1bnF1ZXVlIDIKKFhFTikgQWRkaW5nIGNwdSA0NyB0byBy dW5xdWV1ZSAyCihYRU4pIEFkZGluZyBjcHUgNDggdG8gcnVucXVldWUgMwooWEVOKSAgRmlyc3Qg Y3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nCihYRU4pIEFkZGluZyBjcHUgNDkgdG8gcnVucXVl dWUgMwooWEVOKSBBZGRpbmcgY3B1IDUwIHRvIHJ1bnF1ZXVlIDMKKFhFTikgQWRkaW5nIGNwdSA1 MSB0byBydW5xdWV1ZSAzCihYRU4pIEFkZGluZyBjcHUgNTIgdG8gcnVucXVldWUgMwooWEVOKSBB ZGRpbmcgY3B1IDUzIHRvIHJ1bnF1ZXVlIDMKKFhFTikgQWRkaW5nIGNwdSA1NCB0byBydW5xdWV1 ZSAzCihYRU4pIEFkZGluZyBjcHUgNTUgdG8gcnVucXVldWUgMwooWEVOKSBBZGRpbmcgY3B1IDU2 IHRvIHJ1bnF1ZXVlIDMKKFhFTikgQWRkaW5nIGNwdSA1NyB0byBydW5xdWV1ZSAzCihYRU4pIEFk ZGluZyBjcHUgNTggdG8gcnVucXVldWUgMwooWEVOKSBBZGRpbmcgY3B1IDU5IHRvIHJ1bnF1ZXVl IDMKKFhFTikgQWRkaW5nIGNwdSA2MCB0byBydW5xdWV1ZSAzCihYRU4pIEFkZGluZyBjcHUgNjEg dG8gcnVucXVldWUgMwooWEVOKSBBZGRpbmcgY3B1IDYyIHRvIHJ1bnF1ZXVlIDMKKFhFTikgQWRk aW5nIGNwdSA2MyB0byBydW5xdWV1ZSAzCihYRU4pIEFkZGluZyBjcHUgNjQgdG8gcnVucXVldWUg NAooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5nCihYRU4pIEFkZGluZyBj cHUgNjUgdG8gcnVucXVldWUgNAooWEVOKSBBZGRpbmcgY3B1IDY2IHRvIHJ1bnF1ZXVlIDQKKFhF TikgQWRkaW5nIGNwdSA2NyB0byBydW5xdWV1ZSA0CihYRU4pIEFkZGluZyBjcHUgNjggdG8gcnVu cXVldWUgNAooWEVOKSBBZGRpbmcgY3B1IDY5IHRvIHJ1bnF1ZXVlIDQKKFhFTikgQWRkaW5nIGNw dSA3MCB0byBydW5xdWV1ZSA0CihYRU4pIEFkZGluZyBjcHUgNzEgdG8gcnVucXVldWUgNAooWEVO KSBBZGRpbmcgY3B1IDcyIHRvIHJ1bnF1ZXVlIDQKKFhFTikgQWRkaW5nIGNwdSA3MyB0byBydW5x dWV1ZSA0CihYRU4pIEFkZGluZyBjcHUgNzQgdG8gcnVucXVldWUgNAooWEVOKSBBZGRpbmcgY3B1 IDc1IHRvIHJ1bnF1ZXVlIDQKKFhFTikgQWRkaW5nIGNwdSA3NiB0byBydW5xdWV1ZSA0CihYRU4p IEFkZGluZyBjcHUgNzcgdG8gcnVucXVldWUgNAooWEVOKSBBZGRpbmcgY3B1IDc4IHRvIHJ1bnF1 ZXVlIDQKKFhFTikgQWRkaW5nIGNwdSA3OSB0byBydW5xdWV1ZSA0CihYRU4pIEFkZGluZyBjcHUg ODAgdG8gcnVucXVldWUgNQooWEVOKSAgRmlyc3QgY3B1IG9uIHJ1bnF1ZXVlLCBhY3RpdmF0aW5n CihYRU4pIEFkZGluZyBjcHUgODEgdG8gcnVucXVldWUgNQooWEVOKSBBZGRpbmcgY3B1IDgyIHRv IHJ1bnF1ZXVlIDUKKFhFTikgQWRkaW5nIGNwdSA4MyB0byBydW5xdWV1ZSA1CihYRU4pIEFkZGlu ZyBjcHUgODQgdG8gcnVucXVldWUgNQooWEVOKSBBZGRpbmcgY3B1IDg1IHRvIHJ1bnF1ZXVlIDUK KFhFTikgQWRkaW5nIGNwdSA4NiB0byBydW5xdWV1ZSA1CihYRU4pIEFkZGluZyBjcHUgODcgdG8g cnVucXVldWUgNQooWEVOKSBBZGRpbmcgY3B1IDg4IHRvIHJ1bnF1ZXVlIDUKKFhFTikgQWRkaW5n IGNwdSA4OSB0byBydW5xdWV1ZSA1CihYRU4pIEFkZGluZyBjcHUgOTAgdG8gcnVucXVldWUgNQoo WEVOKSBBZGRpbmcgY3B1IDkxIHRvIHJ1bnF1ZXVlIDUKKFhFTikgQWRkaW5nIGNwdSA5MiB0byBy dW5xdWV1ZSA1CihYRU4pIEFkZGluZyBjcHUgOTMgdG8gcnVucXVldWUgNQooWEVOKSBBZGRpbmcg Y3B1IDk0IHRvIHJ1bnF1ZXVlIDUKKFhFTikgQWRkaW5nIGNwdSA5NSB0byBydW5xdWV1ZSA1CihY RU4pIG1jaGVja19wb2xsOiBNYWNoaW5lIGNoZWNrIHBvbGxpbmcgdGltZXIgc3RhcnRlZC4KKFhF TikgUnVubmluZyBzdHViIHJlY292ZXJ5IHNlbGZ0ZXN0cy4uLgooWEVOKSBGaXh1cCAjVURbMDAw MF06IGZmZmY4MmQwN2ZmZmUwNDQgW2ZmZmY4MmQwN2ZmZmUwNDRdIC0+IGZmZmY4MmQwNDAzOTgz ZjkKKFhFTikgRml4dXAgI0dQWzAwMDBdOiBmZmZmODJkMDdmZmZlMDQ1IFtmZmZmODJkMDdmZmZl MDQ1XSAtPiBmZmZmODJkMDQwMzk4M2Y5CihYRU4pIEZpeHVwICNTU1swMDAwXTogZmZmZjgyZDA3 ZmZmZTA0NCBbZmZmZjgyZDA3ZmZmZTA0NF0gLT4gZmZmZjgyZDA0MDM5ODNmOQooWEVOKSBGaXh1 cCAjQlBbMDAwMF06IGZmZmY4MmQwN2ZmZmUwNDUgW2ZmZmY4MmQwN2ZmZmUwNDVdIC0+IGZmZmY4 MmQwNDAzOTgzZjkKKFhFTikgTlggKEV4ZWN1dGUgRGlzYWJsZSkgcHJvdGVjdGlvbiBhY3RpdmUK KFhFTikgKioqIEJ1aWxkaW5nIGEgUFYgRG9tMCAqKioKKFhFTikgRUxGOiBwaGRyOiBwYWRkcj0w eDEwMDAwMDAgbWVtc3o9MHgxMjU0MDg4CihYRU4pIEVMRjogcGhkcjogcGFkZHI9MHgyNDAwMDAw IG1lbXN6PTB4OGYxMDAwCihYRU4pIEVMRjogcGhkcjogcGFkZHI9MHgyY2YxMDAwIG1lbXN6PTB4 MmNhZTgKKFhFTikgRUxGOiBwaGRyOiBwYWRkcj0weDJkMWUwMDAgbWVtc3o9MHhiMGEwMDAKKFhF TikgRUxGOiBtZW1vcnk6IDB4MTAwMDAwMCAtPiAweDM4MjgwMDAKKFhFTikgRUxGOiBub3RlOiBH VUVTVF9PUyA9ICJsaW51eCIKKFhFTikgRUxGOiBub3RlOiBHVUVTVF9WRVJTSU9OID0gIjIuNiIK KFhFTikgRUxGOiBub3RlOiBYRU5fVkVSU0lPTiA9ICJ4ZW4tMy4wIgooWEVOKSBFTEY6IG5vdGU6 IFZJUlRfQkFTRSA9IDB4ZmZmZmZmZmY4MDAwMDAwMAooWEVOKSBFTEY6IG5vdGU6IElOSVRfUDJN ID0gMHg4MDAwMDAwMDAwCihYRU4pIEVMRjogbm90ZTogRU5UUlkgPSAweGZmZmZmZmZmODJkMWUx NjAKKFhFTikgRUxGOiBub3RlOiBIWVBFUkNBTExfUEFHRSA9IDB4ZmZmZmZmZmY4MThmMDAwMAoo WEVOKSBFTEY6IG5vdGU6IEZFQVRVUkVTID0gIiF3cml0YWJsZV9wYWdlX3RhYmxlc3xwYWVfcGdk aXJfYWJvdmVfNGdiIgooWEVOKSBFTEY6IG5vdGU6IFNVUFBPUlRFRF9GRUFUVVJFUyA9IDB4ODgw MQooWEVOKSBFTEY6IG5vdGU6IFBBRV9NT0RFID0gInllcyIKKFhFTikgRUxGOiBub3RlOiBMT0FE RVIgPSAiZ2VuZXJpYyIKKFhFTikgRUxGOiBub3RlOiB1bmtub3duICgweGQpCihYRU4pIEVMRjog bm90ZTogU1VTUEVORF9DQU5DRUwgPSAweDEKKFhFTikgRUxGOiBub3RlOiBNT0RfU1RBUlRfUEZO ID0gMHgxCihYRU4pIEVMRjogbm90ZTogSFZfU1RBUlRfTE9XID0gMHhmZmZmODAwMDAwMDAwMDAw CihYRU4pIEVMRjogbm90ZTogUEFERFJfT0ZGU0VUID0gMAooWEVOKSBFTEY6IGFkZHJlc3NlczoK KFhFTikgICAgIHZpcnRfYmFzZSAgICAgICAgPSAweGZmZmZmZmZmODAwMDAwMDAKKFhFTikgICAg IGVsZl9wYWRkcl9vZmZzZXQgPSAweDAKKFhFTikgICAgIHZpcnRfb2Zmc2V0ICAgICAgPSAweGZm ZmZmZmZmODAwMDAwMDAKKFhFTikgICAgIHZpcnRfa3N0YXJ0ICAgICAgPSAweGZmZmZmZmZmODEw MDAwMDAKKFhFTikgICAgIHZpcnRfa2VuZCAgICAgICAgPSAweGZmZmZmZmZmODM4MjgwMDAKKFhF TikgICAgIHZpcnRfZW50cnkgICAgICAgPSAweGZmZmZmZmZmODJkMWUxNjAKKFhFTikgICAgIHAy bV9iYXNlICAgICAgICAgPSAweDgwMDAwMDAwMDAKKFhFTikgIFhlbiAga2VybmVsOiA2NC1iaXQs IGxzYgooWEVOKSAgRG9tMCBrZXJuZWw6IDY0LWJpdCwgUEFFLCBsc2IsIHBhZGRyIDB4MTAwMDAw MCAtPiAweDM4MjgwMDAKKFhFTikgUEhZU0lDQUwgTUVNT1JZIEFSUkFOR0VNRU5UOgooWEVOKSAg RG9tMCBhbGxvYy46ICAgMDAwMDAwMjAyODAwMDAwMC0+MDAwMDAwMjAyYzAwMDAwMCAoMjA3MzY5 MiBwYWdlcyB0byBiZSBhbGxvY2F0ZWQpCihYRU4pICBJbml0LiByYW1kaXNrOiAwMDAwMDA0MDdl NDVjMDAwLT4wMDAwMDA0MDdmZmZmZjRjCihYRU4pIFZJUlRVQUwgTUVNT1JZIEFSUkFOR0VNRU5U OgooWEVOKSAgTG9hZGVkIGtlcm5lbDogZmZmZmZmZmY4MTAwMDAwMC0+ZmZmZmZmZmY4MzgyODAw MAooWEVOKSAgUGh5cy1NYWNoIG1hcDogMDAwMDAwODAwMDAwMDAwMC0+MDAwMDAwODAwMTAwMDAw MAooWEVOKSAgU3RhcnQgaW5mbzogICAgZmZmZmZmZmY4MzgyODAwMC0+ZmZmZmZmZmY4MzgyODRi OAooWEVOKSAgUGFnZSB0YWJsZXM6ICAgZmZmZmZmZmY4MzgyOTAwMC0+ZmZmZmZmZmY4Mzg0YTAw MAooWEVOKSAgQm9vdCBzdGFjazogICAgZmZmZmZmZmY4Mzg0YTAwMC0+ZmZmZmZmZmY4Mzg0YjAw MAooWEVOKSAgVE9UQUw6ICAgICAgICAgZmZmZmZmZmY4MDAwMDAwMC0+ZmZmZmZmZmY4M2MwMDAw MAooWEVOKSAgRU5UUlkgQUREUkVTUzogZmZmZmZmZmY4MmQxZTE2MAooWEVOKSBEb20wIGhhcyBt YXhpbXVtIDggVkNQVXMKKFhFTikgRUxGOiBwaGRyIDAgYXQgMHhmZmZmZmZmZjgxMDAwMDAwIC0+ IDB4ZmZmZmZmZmY4MjI1NDA4OAooWEVOKSBFTEY6IHBoZHIgMSBhdCAweGZmZmZmZmZmODI0MDAw MDAgLT4gMHhmZmZmZmZmZjgyY2YxMDAwCihYRU4pIEVMRjogcGhkciAyIGF0IDB4ZmZmZmZmZmY4 MmNmMTAwMCAtPiAweGZmZmZmZmZmODJkMWRhZTgKKFhFTikgRUxGOiBwaGRyIDMgYXQgMHhmZmZm ZmZmZjgyZDFlMDAwIC0+IDB4ZmZmZmZmZmY4MmY1ZDAwMAooWEVOKSBJbml0aWFsIGxvdyBtZW1v cnkgdmlycSB0aHJlc2hvbGQgc2V0IGF0IDB4NDAwMCBwYWdlcy4KKFhFTikgU2NydWJiaW5nIEZy ZWUgUkFNIGluIGJhY2tncm91bmQKKFhFTikgU3RkLiBMb2dsZXZlbDogQWxsCihYRU4pIEd1ZXN0 IExvZ2xldmVsOiBBbGwKKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqCihYRU4pIFdBUk5JTkc6IENPTlNPTEUgT1VUUFVUIElTIFNZTkNIUk9O T1VTCihYRU4pIFRoaXMgb3B0aW9uIGlzIGludGVuZGVkIHRvIGFpZCBkZWJ1Z2dpbmcgb2YgWGVu IGJ5IGVuc3VyaW5nCihYRU4pIHRoYXQgYWxsIG91dHB1dCBpcyBzeW5jaHJvbm91c2x5IGRlbGl2 ZXJlZCBvbiB0aGUgc2VyaWFsIGxpbmUuCihYRU4pIEhvd2V2ZXIgaXQgY2FuIGludHJvZHVjZSBT SUdOSUZJQ0FOVCBsYXRlbmNpZXMgYW5kIGFmZmVjdAooWEVOKSB0aW1la2VlcGluZy4gSXQgaXMg Tk9UIHJlY29tbWVuZGVkIGZvciBwcm9kdWN0aW9uIHVzZSEKKFhFTikgKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqCihYRU4pIFdBUk5JTkc6IEhWTSBG T1JDRUQgRU1VTEFUSU9OIFBSRUZJWCBJUyBBVkFJTEFCTEUKKFhFTikgVGhpcyBvcHRpb24gaXMg Kk9OTFkqIGludGVuZGVkIHRvIGFpZCB0ZXN0aW5nIG9mIFhlbi4KKFhFTikgSXQgaGFzIGltcGxp Y2F0aW9ucyBvbiB0aGUgc2VjdXJpdHkgb2YgdGhlIHN5c3RlbS4KKFhFTikgUGxlYXNlICpETyBO T1QqIHVzZSB0aGlzIGluIHByb2R1Y3Rpb24uCihYRU4pICoqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqKgooWEVOKSAzLi4uIDIuLi4gMS4uLiAKKFhFTikg KioqIFNlcmlhbCBpbnB1dCB0byBET00wICh0eXBlICdDVFJMLWEnIHRocmVlIHRpbWVzIHRvIHN3 aXRjaCBpbnB1dCkKKFhFTikgRnJlZWQgMjA0OGtCIGluaXQgbWVtb3J5Cm1hcHBpbmcga2VybmVs IGludG8gcGh5c2ljYWwgbWVtb3J5CmFib3V0IHRvIGdldCBzdGFydGVkLi4uClsgICAgMC4wMDAw MDBdIExpbnV4IHZlcnNpb24gNS4xOS4wLXJjNiAgKGdjYyAoR0NDKSA4LjMuMSAyMDE5MTEyMSAo UmVkIEhhdCA4LjMuMS01KSwgR05VIGxkIChHTlUgQmludXRpbHMpIDIuMzIpICMxIFNNUCBQUkVF TVBUX0RZTkFNSUMgU3VuIEp1bCAxNyAwMzoyNzowNiBDU1QgMjAyMgpbICAgIDAuMDAwMDAwXSBD b21tYW5kIGxpbmU6IHJvb3Q9L2Rldi9tYXBwZXIvcmhlbC1yb290IHJvIGNyYXNoa2VybmVsPWF1 dG8gY29uc29sZT1odmMwLGNvbnNvbGU9dHR5UzAsMTE1MjAwLDhuMSBpbnRlbF9pb21tdT1vbgpb ICAgIDAuMDAwMDAwXSAtLS0tLS0tLS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KWyAgICAw LjAwMDAwMF0gWFNBVkUgY29uc2lzdGVuY3kgcHJvYmxlbSwgZHVtcGluZyBsZWF2ZXMKWyAgICAw LjAwMDAwMF0gV0FSTklORzogQ1BVOiAwIFBJRDogMCBhdCBhcmNoL3g4Ni9rZXJuZWwvZnB1L3hz dGF0ZS5jOjYwNiBmcHVfX2luaXRfc3lzdGVtX3hzdGF0ZSsweDdlYS8weGE5OApbICAgIDAuMDAw MDAwXSBNb2R1bGVzIGxpbmtlZCBpbjoKWyAgICAwLjAwMDAwMF0gQ1BVOiAwIFBJRDogMCBDb21t OiBzd2FwcGVyIE5vdCB0YWludGVkIDUuMTkuMC1yYzYgIzEKWyAgICAwLjAwMDAwMF0gUklQOiBl MDMwOmZwdV9faW5pdF9zeXN0ZW1feHN0YXRlKzB4N2VhLzB4YTk4ClsgICAgMC4wMDAwMDBdIENv ZGU6IGJlIGM5IDQ4IGZmIGU4IDExIDQyIDMxIGZlIDQxIDM5IGM2IDc0IDIzIDgwIDNkIDQ0IGI2 IGJkIGZmIDAwIDc1IDhiIDQ4IGM3IGM3IGUwIGFmIDBlIDgyIGM2IDA1IDM0IGI2IGJkIGZmIDAx IGU4IDM1IGYzIGI3IGZlIDwwZj4gMGIgZTkgNzEgZmYgZmYgZmYgOGIgNDQgMjQgMTAgNDQgODkg MzUgN2UgYzkgNDggZmYgYmEgNDAgMDIgMDAKWyAgICAwLjAwMDAwMF0gUlNQOiBlMDJiOmZmZmZm ZmZmODI0MDNkNTAgRUZMQUdTOiAwMDAxMDA4MiBPUklHX1JBWDogMDAwMDAwMDAwMDAwMDAwMApb ICAgIDAuMDAwMDAwXSBSQVg6IDAwMDAwMDAwMDAwMDAwMDAgUkJYOiAwMDAwMDAwMDAwMDAwMDQw IFJDWDogMDAwMDAwMDAwMDAwMDAwMgpbICAgIDAuMDAwMDAwXSBSRFg6IDAwMDAwMDAwMDAwMDAw MDIgUlNJOiAwMDAwMDAwMDAwMDAwMDAwIFJESTogMDAwMDAwMDBmZmZmZmZmZgpbICAgIDAuMDAw MDAwXSBSQlA6IDAwMDAwMDAwMDAwMDA0MDAgUjA4OiBmZmZmZmZmZjgyNDZmOTgwIFIwOTogNzM2 NTc2NjE2NTZjMjA2NwpbICAgIDAuMDAwMDAwXSBSMTA6IDY1NmM2MjZmNzI3MDIwNzkgUjExOiA2 OTcwNmQ3NTY0MjAyYzZkIFIxMjogMDAwMDAwMDAwMDAwMDAwMQpbICAgIDAuMDAwMDAwXSBSMTM6 IDAwMDAwMDAwMDAwMDAwMDEgUjE0OiAwMDAwMDAwMDAwMDAwMDAwIFIxNTogMDAwMDAwMDAwMDAw MDBlNwpbICAgIDAuMDAwMDAwXSBGUzogIDAwMDAwMDAwMDAwMDAwMDAoMDAwMCkgR1M6ZmZmZmZm ZmY4MmNmMTAwMCgwMDAwKSBrbmxHUzowMDAwMDAwMDAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENT OiAgMTAwMDBlMDMwIERTOiAwMDAwIEVTOiAwMDAwIENSMDogMDAwMDAwMDA4MDA1MDAzMwpbICAg IDAuMDAwMDAwXSBDUjI6IDAwMDAwMDAwMDAwMDAwMDAgQ1IzOiAwMDAwMDAwMDAyNDBhMDAwIENS NDogMDAwMDAwMDAwMDA0MDY2MApbICAgIDAuMDAwMDAwXSBDYWxsIFRyYWNlOgpbICAgIDAuMDAw MDAwXSAgPFRBU0s+ClsgICAgMC4wMDAwMDBdICA/IGZwdV9faW5pdF9zeXN0ZW0rMHgxNDcvMHgx OGMKWyAgICAwLjAwMDAwMF0gID8gZWFybHlfY3B1X2luaXQrMHgzNjMvMHgzOGQKWyAgICAwLjAw MDAwMF0gID8gc2V0dXBfYXJjaCsweDVhLzB4Y2E1ClsgICAgMC4wMDAwMDBdICA/IF9wcmludGsr MHg1OC8weDZmClsgICAgMC4wMDAwMDBdICA/IHN0YXJ0X2tlcm5lbCsweDcwLzB4NmM5ClsgICAg MC4wMDAwMDBdICA/IHhlbl9zdGFydF9rZXJuZWwrMHg1MDAvMHg1MGEKWyAgICAwLjAwMDAwMF0g ID8gc3RhcnR1cF94ZW4rMHgxZi8weDFmClsgICAgMC4wMDAwMDBdICA8L1RBU0s+ClsgICAgMC4w MDAwMDBdIC0tLVsgZW5kIHRyYWNlIDAwMDAwMDAwMDAwMDAwMDAgXS0tLQpbICAgIDAuMDAwMDAw XSBDUFVJRFswZCwgMDBdOiBlYXg9MDAwMDAwZTcgZWJ4PTAwMDAwYTgwIGVjeD0wMDAwMGE4MCBl ZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDAxXTogZWF4PTAwMDAwMDA3IGVi eD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlE WzBkLCAwMl06IGVheD0wMDAwMDEwMCBlYng9MDAwMDAyNDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAw MDAwMApbICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMDNdOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAw MDAwIGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDA0 XTogZWF4PTAwMDAwMDAwIGVieD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsg ICAgMC4wMDAwMDBdIENQVUlEWzBkLCAwNV06IGVheD0wMDAwMDA0MCBlYng9MDAwMDA0NDAgZWN4 PTAwMDAwMDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMDZdOiBlYXg9 MDAwMDAyMDAgZWJ4PTAwMDAwNDgwIGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAw MDAwMF0gQ1BVSURbMGQsIDA3XTogZWF4PTAwMDAwNDAwIGVieD0wMDAwMDY4MCBlY3g9MDAwMDAw MDAgZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlEWzBkLCAwOF06IGVheD0wMDAwMDAw MCBlYng9MDAwMDAwMDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBD UFVJRFswZCwgMDldOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAwMDAwIGVjeD0wMDAwMDAwMCBlZHg9 MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDBhXTogZWF4PTAwMDAwMDAwIGVieD0w MDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlEWzBk LCAwYl06IGVheD0wMDAwMDAwMCBlYng9MDAwMDAwMDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAwMDAw MApbICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMGNdOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAwMDAw IGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDBkXTog ZWF4PTAwMDAwMDAwIGVieD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAg MC4wMDAwMDBdIENQVUlEWzBkLCAwZV06IGVheD0wMDAwMDAwMCBlYng9MDAwMDAwMDAgZWN4PTAw MDAwMDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMGZdOiBlYXg9MDAw MDAwMDAgZWJ4PTAwMDAwMDAwIGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAw MF0gQ1BVSURbMGQsIDEwXTogZWF4PTAwMDAwMDAwIGVieD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAg ZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlEWzBkLCAxMV06IGVheD0wMDAwMDAwMCBl Yng9MDAwMDAwMDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBDUFVJ RFswZCwgMTJdOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAwMDAwIGVjeD0wMDAwMDAwMCBlZHg9MDAw MDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDEzXTogZWF4PTAwMDAwMDAwIGVieD0wMDAw MDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlEWzBkLCAx NF06IGVheD0wMDAwMDAwMCBlYng9MDAwMDAwMDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAwMDAwMApb ICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMTVdOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAwMDAwIGVj eD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDE2XTogZWF4 PTAwMDAwMDAwIGVieD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAgMC4w MDAwMDBdIENQVUlEWzBkLCAxN106IGVheD0wMDAwMDAwMCBlYng9MDAwMDAwMDAgZWN4PTAwMDAw MDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBDUFVJRFswZCwgMThdOiBlYXg9MDAwMDAw MDAgZWJ4PTAwMDAwMDAwIGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAwMDAKWyAgICAwLjAwMDAwMF0g Q1BVSURbMGQsIDE5XTogZWF4PTAwMDAwMDAwIGVieD0wMDAwMDAwMCBlY3g9MDAwMDAwMDAgZWR4 PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIENQVUlEWzBkLCAxYV06IGVheD0wMDAwMDAwMCBlYng9 MDAwMDAwMDAgZWN4PTAwMDAwMDAwIGVkeD0wMDAwMDAwMApbICAgIDAuMDAwMDAwXSBDUFVJRFsw ZCwgMWJdOiBlYXg9MDAwMDAwMDAgZWJ4PTAwMDAwMDAwIGVjeD0wMDAwMDAwMCBlZHg9MDAwMDAw MDAKWyAgICAwLjAwMDAwMF0gQ1BVSURbMGQsIDFjXTogZWF4PTAwMDAwMDAwIGVieD0wMDAwMDAw MCBlY3g9MDAwMDAwMDAgZWR4PTAwMDAwMDAwClsgICAgMC4wMDAwMDBdIHNpZ25hbDogbWF4IHNp Z2ZyYW1lIHNpemU6IDE0NDAKWyAgICAwLjAwMDAwMF0gUmVsZWFzZWQgMCBwYWdlKHMpClsgICAg MC4wMDAwMDBdIEJJT1MtcHJvdmlkZWQgcGh5c2ljYWwgUkFNIG1hcDoKWyAgICAwLjAwMDAwMF0g WGVuOiBbbWVtIDB4MDAwMDAwMDAwMDAwMDAwMC0weDAwMDAwMDAwMDAwOWRmZmZdIHVzYWJsZQpb ICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMDAwMDllMDAwLTB4MDAwMDAwMDAwMDA5 ZWZmZl0gcmVzZXJ2ZWQKWyAgICAwLjAwMDAwMF0gWGVuOiBbbWVtIDB4MDAwMDAwMDAwMDA5ZjAw MC0weDAwMDAwMDAwMDAwOWZmZmZdIEFDUEkgTlZTClsgICAgMC4wMDAwMDBdIFhlbjogW21lbSAw eDAwMDAwMDAwMDAwYTAwMDAtMHgwMDAwMDAwMDAwMGZmZmZmXSByZXNlcnZlZApbICAgIDAuMDAw MDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMDAwMTAwMDAwLTB4MDAwMDAwMDA2MzU4MmZmZl0gdXNh YmxlClsgICAgMC4wMDAwMDBdIFhlbjogW21lbSAweDAwMDAwMDAwNjM1ODMwMDAtMHgwMDAwMDAw MDY0ZWNiZmZmXSByZXNlcnZlZApbICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMDY0 ZWNjMDAwLTB4MDAwMDAwMDA2NjUxYWZmZl0gQUNQSSBOVlMKWyAgICAwLjAwMDAwMF0gWGVuOiBb bWVtIDB4MDAwMDAwMDA2NjUxYjAwMC0weDAwMDAwMDAwNjY5ZmRmZmZdIEFDUEkgZGF0YQpbICAg IDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMDY2OWZlMDAwLTB4MDAwMDAwMDA2ZjdmZmZm Zl0gdXNhYmxlClsgICAgMC4wMDAwMDBdIFhlbjogW21lbSAweDAwMDAwMDAwNmY4MDAwMDAtMHgw MDAwMDAwMDhmZmZmZmZmXSByZXNlcnZlZApbICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAw MDAwMDliN2ZjMDAwLTB4MDAwMDAwMDA5YjdmY2ZmZl0gcmVzZXJ2ZWQKWyAgICAwLjAwMDAwMF0g WGVuOiBbbWVtIDB4MDAwMDAwMDBhNjNmYzAwMC0weDAwMDAwMDAwYTYzZmNmZmZdIHJlc2VydmVk ClsgICAgMC4wMDAwMDBdIFhlbjogW21lbSAweDAwMDAwMDAwYjBmZmMwMDAtMHgwMDAwMDAwMGIw ZmZjZmZmXSByZXNlcnZlZApbICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMGJiYmZj MDAwLTB4MDAwMDAwMDBiYmJmY2ZmZl0gcmVzZXJ2ZWQKWyAgICAwLjAwMDAwMF0gWGVuOiBbbWVt IDB4MDAwMDAwMDBjNWZmYzAwMC0weDAwMDAwMDAwYzVmZmNmZmZdIHJlc2VydmVkClsgICAgMC4w MDAwMDBdIFhlbjogW21lbSAweDAwMDAwMDAwZDBmZmMwMDAtMHgwMDAwMDAwMGQwZmZjZmZmXSBy ZXNlcnZlZApbICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMGRiYmZjMDAwLTB4MDAw MDAwMDBkYmJmY2ZmZl0gcmVzZXJ2ZWQKWyAgICAwLjAwMDAwMF0gWGVuOiBbbWVtIDB4MDAwMDAw MDBlNjdmYzAwMC0weDAwMDAwMDAwZTY3ZmNmZmZdIHJlc2VydmVkClsgICAgMC4wMDAwMDBdIFhl bjogW21lbSAweDAwMDAwMDAwZjEzZmMwMDAtMHgwMDAwMDAwMGYxM2ZjZmZmXSByZXNlcnZlZApb ICAgIDAuMDAwMDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMGZiN2ZjMDAwLTB4MDAwMDAwMDBmYjdm Y2ZmZl0gcmVzZXJ2ZWQKWyAgICAwLjAwMDAwMF0gWGVuOiBbbWVtIDB4MDAwMDAwMDBmZTAwMDAw MC0weDAwMDAwMDAwZmUwMTBmZmZdIHJlc2VydmVkClsgICAgMC4wMDAwMDBdIFhlbjogW21lbSAw eDAwMDAwMDAwZmVjMDAwMDAtMHgwMDAwMDAwMGZlYzAwZmZmXSByZXNlcnZlZApbICAgIDAuMDAw MDAwXSBYZW46IFttZW0gMHgwMDAwMDAwMGZlZTAwMDAwLTB4MDAwMDAwMDBmZWVmZmZmZl0gcmVz ZXJ2ZWQKWyAgICAwLjAwMDAwMF0gWGVuOiBbbWVtIDB4MDAwMDAwMDEwMDAwMDAwMC0weDAwMDAw MDE1ZmZmZmZmZmZdIHVzYWJsZQpbICAgIDAuMDAwMDAwXSBOWCAoRXhlY3V0ZSBEaXNhYmxlKSBw cm90ZWN0aW9uOiBhY3RpdmUKWyAgICAwLjAwMDAwMF0gZWZpOiBFRkkgdjIuNzAgYnkgRURLIElJ ClsgICAgMC4wMDAwMDBdIGVmaTogQUNQST0weDY2OWZkMDAwIEFDUEkgMi4wPTB4NjY5ZmQwMTQg VFBNRmluYWxMb2c9MHg2NjQ5MTAwMCBTTUJJT1M9MHg2MzYwODAwMCBTTUJJT1MgMy4wPTB4NjM2 MDYwMDAgTUVNQVRUUj0weDVhZjBlMDE4IApbICAgIDAuMDAwMDAwXSBTTUJJT1MgMy4zLjAgcHJl c2VudC4KWyAgICAwLjAwMDAwMF0gRE1JOiBJbnRlbCBDb3Jwb3JhdGlvbiBTMjYwMFdDL1MyNjAw V0MsIEJJT1MgV0xZRENSQjEuU1lTLjAwMjAuUDk1LjIxMDQwMTAyMzMgMDQvMDEvMjAyMQpbICAg IDAuMDAwMDAwXSBIeXBlcnZpc29yIGRldGVjdGVkOiBYZW4gUFYKWyAgICAwLjAwMDgwNF0gdHNj OiBEZXRlY3RlZCAyMzk0LjM3NCBNSHogcHJvY2Vzc29yClsgICAgMC4wMDExMzFdIGxhc3RfcGZu ID0gMHgxNjAwMDAwIG1heF9hcmNoX3BmbiA9IDB4NDAwMDAwMDAwClsgICAgMC4wMDExMzJdIERp c2FibGVkClsgICAgMC4wMDExMzNdIHg4Ni9QQVQ6IE1UUlJzIGRpc2FibGVkLCBza2lwcGluZyBQ QVQgaW5pdGlhbGl6YXRpb24gdG9vLgpbICAgIDAuMDAxMTM3XSB4ODYvUEFUOiBDb25maWd1cmF0 aW9uIFswLTddOiBXQiAgV1QgIFVDLSBVQyAgV0MgIFdQICBVQyAgVUMgIApbICAgIDAuMDAxMTM4 XSBsYXN0X3BmbiA9IDB4NmY4MDAgbWF4X2FyY2hfcGZuID0gMHg0MDAwMDAwMDAKWyAgICAxLjMw MTA1NF0gU2VjdXJlIGJvb3QgZGlzYWJsZWQKWyAgICAxLjMwMTA1N10gUkFNRElTSzogW21lbSAw eDA0MDAwMDAwLTB4MDViYTNmZmZdClsgICAgMS4zMDEwNjFdIEFDUEk6IEVhcmx5IHRhYmxlIGNo ZWNrc3VtIHZlcmlmaWNhdGlvbiBkaXNhYmxlZApbICAgIDEuMzAxMDY5XSBBQ1BJOiBSU0RQIDB4 MDAwMDAwMDA2NjlGRDAxNCAwMDAwMjQgKHYwMiBJTlRFTCApClsgICAgMS4zMDEwODBdIEFDUEk6 IFhTRFQgMHgwMDAwMDAwMDY2N0YyMTg4IDAwMDEwQyAodjAxIElOVEVMICBJTlRFTCBJRCAwMDAw MDAwMCBJTlRMIDAxMDAwMDEzKQpbICAgIDEuMzAxMTI1XSBBQ1BJOiBGQUNQIDB4MDAwMDAwMDA2 NjlGMjAwMCAwMDAxMTQgKHYwNiBJTlRFTCAgSU5URUwgSUQgMDAwMDAwMDAgSU5UTCAyMDA5MTAx MykKWyAgICAxLjMwMTE5N10gQUNQSTogRFNEVCAweDAwMDAwMDAwNjY5ODUwMDAgMDY1MzIwICh2 MDIgSU5URUwgIElOVEVMIElEIDAwMDAwMDAzIElOVEwgMjAwOTEwMTMpClsgICAgMS4zMDEyMDld IEFDUEk6IEZBQ1MgMHgwMDAwMDAwMDY2NDgyMDAwIDAwMDA0MApbICAgIDEuMzAxMjIyXSBBQ1BJ OiBTU0RUIDB4MDAwMDAwMDA2NjlGQjAwMCAwMDA5NDMgKHYwMiBJTlRFTCAgeGhfd2NjcmIgMDAw MDAwMDAgSU5UTCAyMDIwMDkyNSkKWyAgICAxLjMwMTIzNF0gQUNQSTogU1NEVCAweDAwMDAwMDAw NjY5RkEwMDAgMDAwNEM1ICh2MDIgSU5URUwgIElOVEVMIElEIDAwMDAwMDAwIE1TRlQgMDEwMDAw MEQpClsgICAgMS4zMDEyNDddIEFDUEk6IFNTRFQgMHgwMDAwMDAwMDY2OUY5MDAwIDAwMDc0OCAo djAyIElOVEVMICBSQVNfQUNQSSAwMDAwMDAwMSBJTlRMIDIwMjAwOTI1KQpbICAgIDEuMzAxMjU5 XSBBQ1BJOiBTU0RUIDB4MDAwMDAwMDA2NjlGODAwMCAwMDA2MzIgKHYwMiBJTlRFTCAgVHBtMlRh YmwgMDAwMDEwMDAgSU5UTCAyMDIwMDkyNSkKWyAgICAxLjMwMTI3MV0gQUNQSTogVFBNMiAweDAw MDAwMDAwNjY5RjcwMDAgMDAwMDRDICh2MDQgSU5URUwgIElOVEVMIElEIDAwMDAwMDAyIElOVEwg MDEwMDAwMTMpClsgICAgMS4zMDEyODRdIEFDUEk6IFNTRFQgMHgwMDAwMDAwMDY2OUY2MDAwIDAw MDc0NSAodjAyIElOVEVMICBBRERSWExBVCAwMDAwMDAwMSBJTlRMIDIwMjAwOTI1KQpbICAgIDEu MzAxMjk2XSBBQ1BJOiBCRVJUIDB4MDAwMDAwMDA2NjlGNTAwMCAwMDAwMzAgKHYwMSBJTlRFTCAg SU5URUwgSUQgMDAwMDAwMDEgSU5UTCAwMDAwMDAwMSkKWyAgICAxLjMwMTMwOF0gQUNQSTogRVJT VCAweDAwMDAwMDAwNjY5RjQwMDAgMDAwMjMwICh2MDEgSU5URUwgIElOVEVMIElEIDAwMDAwMDAx IElOVEwgMDAwMDAwMDEpClsgICAgMS4zMDEzMjFdIEFDUEk6IEJEQVQgMHgwMDAwMDAwMDY2OUYz MDAwIDAwMDAzMCAodjAxIElOVEVMICBJTlRFTCBJRCAwMDAwMDAwMCBJTlRMIDIwMDkxMDEzKQpb ICAgIDEuMzAxMzMzXSBBQ1BJOiBITUFUIDB4MDAwMDAwMDA2NjlGMTAwMCAwMDAxODAgKHYwMSBJ TlRFTCAgSU5URUwgSUQgMDAwMDAwMDEgSU5UTCAyMDA5MTAxMykKWyAgICAxLjMwMTM0NV0gQUNQ STogSFBFVCAweDAwMDAwMDAwNjY5RjAwMDAgMDAwMDM4ICh2MDEgSU5URUwgIElOVEVMIElEIDAw MDAwMDAxIElOVEwgMjAwOTEwMTMpClsgICAgMS4zMDEzNThdIEFDUEk6IE1DRkcgMHgwMDAwMDAw MDY2OUVGMDAwIDAwMDAzQyAodjAxIElOVEVMICBJTlRFTCBJRCAwMDAwMDAwMSBJTlRMIDIwMDkx MDEzKQpbICAgIDEuMzAxMzcwXSBBQ1BJOiBNSUdUIDB4MDAwMDAwMDA2NjlFRTAwMCAwMDAwNDAg KHYwMSBJTlRFTCAgSU5URUwgSUQgMDAwMDAwMDAgSU5UTCAyMDA5MTAxMykKWyAgICAxLjMwMTM4 Ml0gQUNQSTogTVNDVCAweDAwMDAwMDAwNjY5RUQwMDAgMDAwMDkwICh2MDEgSU5URUwgIElOVEVM IElEIDAwMDAwMDAxIElOVEwgMjAwOTEwMTMpClsgICAgMS4zMDEzOTRdIEFDUEk6IFdERFQgMHgw MDAwMDAwMDY2OUVDMDAwIDAwMDA0MCAodjAxIElOVEVMICBJTlRFTCBJRCAwMDAwMDAwMCBJTlRM IDIwMDkxMDEzKQpbICAgIDEuMzAxNDA2XSBBQ1BJOiBXU01UIDB4MDAwMDAwMDA2NjlFQjAwMCAw MDAwMjggKHYwMSBJTlRFTCAgSU5URUwgSUQgMDAwMDAwMDAgSU5UTCAyMDA5MTAxMykKWyAgICAx LjMwMTQxOF0gQUNQSTogQVBJQyAweDAwMDAwMDAwNjY5ODQwMDAgMDAwMzVFICh2MDQgSU5URUwg IElOVEVMIElEIDAwMDAwMDAwIElOVEwgMjAwOTEwMTMpClsgICAgMS4zMDE0MzFdIEFDUEk6IFNM SVQgMHgwMDAwMDAwMDY2OTgyMDAwIDAwMTAyQyAodjAxIElOVEVMICBJTlRFTCBJRCAwMDAwMDAw MSBJTlRMIDAxMDAwMDEzKQpbICAgIDEuMzAxNDQzXSBBQ1BJOiBTUkFUIDB4MDAwMDAwMDA2Njk3 QjAwMCAwMDY0MzAgKHYwMyBJTlRFTCAgSU5URUwgSUQgMDAwMDAwMDIgSU5UTCAwMTAwMDAxMykK WyAgICAxLjMwMTQ1NV0gQUNQSTogT0VNNCAweDAwMDAwMDAwNjY3RjMwMDAgMTg3QTYxICh2MDIg SU5URUwgIENQVSAgQ1NUIDAwMDAzMDAwIElOVEwgMjAyMDA5MjUpClsgICAgMS4zMDE0NjhdIEFD UEk6IE9FTTEgMHgwMDAwMDAwMDY2NkRFMDAwIDExMzQ4OSAodjAyIElOVEVMICBDUFUgRUlTVCAw MDAwMzAwMCBJTlRMIDIwMjAwOTI1KQpbICAgIDEuMzAxNDgwXSBBQ1BJOiBPRU0yIDB4MDAwMDAw MDA2NjY5NzAwMCAwNDYwMzEgKHYwMiBJTlRFTCAgQ1BVICBIV1AgMDAwMDMwMDAgSU5UTCAyMDIw MDkyNSkKWyAgICAxLjMwMTQ5M10gQUNQSTogU1NEVCAweDAwMDAwMDAwNjY2MjAwMDAgMDc2NEE1 ICh2MDIgSU5URUwgIFNTRFQgIFBNIDAwMDA0MDAwIElOVEwgMjAyMDA5MjUpClsgICAgMS4zMDE1 MDVdIEFDUEk6IEhFU1QgMHgwMDAwMDAwMDY2OUZDMDAwIDAwMDEzQyAodjAxIElOVEVMICBJTlRF TCBJRCAwMDAwMDAwMSBJTlRMIDAwMDAwMDAxKQpbICAgIDEuMzAxNTE4XSBBQ1BJOiBSTUFEIDB4 MDAwMDAwMDA2NjYxRjAwMCAwMDAxODAgKHYwMSBJTlRFTCAgSU5URUwgSUQgMDAwMDAwMDEgSU5U TCAyMDA5MTAxMykKWyAgICAxLjMwMTUzMF0gQUNQSTogU1NEVCAweDAwMDAwMDAwNjY2MTcwMDAg MDA3OEJBICh2MDIgSU5URUwgIFNwc05tICAgIDAwMDAwMDAyIElOVEwgMjAyMDA5MjUpClsgICAg MS4zMDE1NDNdIEFDUEk6IFNQQ1IgMHgwMDAwMDAwMDY2NjE2MDAwIDAwMDA1MCAodjAyIElOVEVM ICBJTlRFTCBJRCAwMDAwMDAwMCBJTlRMIDAxMDAwMDEzKQpbICAgIDEuMzAxNTU4XSBBQ1BJOiBG UERUIDB4MDAwMDAwMDA2NjYxNTAwMCAwMDAwNDQgKHYwMSBJTlRFTCAgSU5URUwgSUQgMDAwMDAw MDIgSU5UTCAwMTAwMDAxMykKWyAgICAxLjMwMTU2NF0gQUNQSTogUmVzZXJ2aW5nIEZBQ1AgdGFi bGUgbWVtb3J5IGF0IFttZW0gMHg2NjlmMjAwMC0weDY2OWYyMTEzXQpbICAgIDEuMzAxNTY2XSBB Q1BJOiBSZXNlcnZpbmcgRFNEVCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2OTg1MDAwLTB4NjY5 ZWEzMWZdClsgICAgMS4zMDE1NjddIEFDUEk6IFJlc2VydmluZyBGQUNTIHRhYmxlIG1lbW9yeSBh dCBbbWVtIDB4NjY0ODIwMDAtMHg2NjQ4MjAzZl0KWyAgICAxLjMwMTU2OF0gQUNQSTogUmVzZXJ2 aW5nIFNTRFQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2NjlmYjAwMC0weDY2OWZiOTQyXQpbICAg IDEuMzAxNTY4XSBBQ1BJOiBSZXNlcnZpbmcgU1NEVCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2 OWZhMDAwLTB4NjY5ZmE0YzRdClsgICAgMS4zMDE1NjldIEFDUEk6IFJlc2VydmluZyBTU0RUIHRh YmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY5ZjkwMDAtMHg2NjlmOTc0N10KWyAgICAxLjMwMTU3MF0g QUNQSTogUmVzZXJ2aW5nIFNTRFQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2NjlmODAwMC0weDY2 OWY4NjMxXQpbICAgIDEuMzAxNTcxXSBBQ1BJOiBSZXNlcnZpbmcgVFBNMiB0YWJsZSBtZW1vcnkg YXQgW21lbSAweDY2OWY3MDAwLTB4NjY5ZjcwNGJdClsgICAgMS4zMDE1NzFdIEFDUEk6IFJlc2Vy dmluZyBTU0RUIHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY5ZjYwMDAtMHg2NjlmNjc0NF0KWyAg ICAxLjMwMTU3Ml0gQUNQSTogUmVzZXJ2aW5nIEJFUlQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2 NjlmNTAwMC0weDY2OWY1MDJmXQpbICAgIDEuMzAxNTczXSBBQ1BJOiBSZXNlcnZpbmcgRVJTVCB0 YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2OWY0MDAwLTB4NjY5ZjQyMmZdClsgICAgMS4zMDE1NzRd IEFDUEk6IFJlc2VydmluZyBCREFUIHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY5ZjMwMDAtMHg2 NjlmMzAyZl0KWyAgICAxLjMwMTU3NF0gQUNQSTogUmVzZXJ2aW5nIEhNQVQgdGFibGUgbWVtb3J5 IGF0IFttZW0gMHg2NjlmMTAwMC0weDY2OWYxMTdmXQpbICAgIDEuMzAxNTc1XSBBQ1BJOiBSZXNl cnZpbmcgSFBFVCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2OWYwMDAwLTB4NjY5ZjAwMzddClsg ICAgMS4zMDE1NzZdIEFDUEk6IFJlc2VydmluZyBNQ0ZHIHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4 NjY5ZWYwMDAtMHg2NjllZjAzYl0KWyAgICAxLjMwMTU3N10gQUNQSTogUmVzZXJ2aW5nIE1JR1Qg dGFibGUgbWVtb3J5IGF0IFttZW0gMHg2NjllZTAwMC0weDY2OWVlMDNmXQpbICAgIDEuMzAxNTc3 XSBBQ1BJOiBSZXNlcnZpbmcgTVNDVCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2OWVkMDAwLTB4 NjY5ZWQwOGZdClsgICAgMS4zMDE1NzhdIEFDUEk6IFJlc2VydmluZyBXRERUIHRhYmxlIG1lbW9y eSBhdCBbbWVtIDB4NjY5ZWMwMDAtMHg2NjllYzAzZl0KWyAgICAxLjMwMTU3OV0gQUNQSTogUmVz ZXJ2aW5nIFdTTVQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2NjllYjAwMC0weDY2OWViMDI3XQpb ICAgIDEuMzAxNTgwXSBBQ1BJOiBSZXNlcnZpbmcgQVBJQyB0YWJsZSBtZW1vcnkgYXQgW21lbSAw eDY2OTg0MDAwLTB4NjY5ODQzNWRdClsgICAgMS4zMDE1ODFdIEFDUEk6IFJlc2VydmluZyBTTElU IHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY5ODIwMDAtMHg2Njk4MzAyYl0KWyAgICAxLjMwMTU4 MV0gQUNQSTogUmVzZXJ2aW5nIFNSQVQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2Njk3YjAwMC0w eDY2OTgxNDJmXQpbICAgIDEuMzAxNTgyXSBBQ1BJOiBSZXNlcnZpbmcgT0VNNCB0YWJsZSBtZW1v cnkgYXQgW21lbSAweDY2N2YzMDAwLTB4NjY5N2FhNjBdClsgICAgMS4zMDE1ODNdIEFDUEk6IFJl c2VydmluZyBPRU0xIHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY2ZGUwMDAtMHg2NjdmMTQ4OF0K WyAgICAxLjMwMTU4NF0gQUNQSTogUmVzZXJ2aW5nIE9FTTIgdGFibGUgbWVtb3J5IGF0IFttZW0g MHg2NjY5NzAwMC0weDY2NmRkMDMwXQpbICAgIDEuMzAxNTg1XSBBQ1BJOiBSZXNlcnZpbmcgU1NE VCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2NjIwMDAwLTB4NjY2OTY0YTRdClsgICAgMS4zMDE1 ODZdIEFDUEk6IFJlc2VydmluZyBIRVNUIHRhYmxlIG1lbW9yeSBhdCBbbWVtIDB4NjY5ZmMwMDAt MHg2NjlmYzEzYl0KWyAgICAxLjMwMTU4N10gQUNQSTogUmVzZXJ2aW5nIFJNQUQgdGFibGUgbWVt b3J5IGF0IFttZW0gMHg2NjYxZjAwMC0weDY2NjFmMTdmXQpbICAgIDEuMzAxNTg4XSBBQ1BJOiBS ZXNlcnZpbmcgU1NEVCB0YWJsZSBtZW1vcnkgYXQgW21lbSAweDY2NjE3MDAwLTB4NjY2MWU4Yjld ClsgICAgMS4zMDE1ODhdIEFDUEk6IFJlc2VydmluZyBTUENSIHRhYmxlIG1lbW9yeSBhdCBbbWVt IDB4NjY2MTYwMDAtMHg2NjYxNjA0Zl0KWyAgICAxLjMwMTU4OV0gQUNQSTogUmVzZXJ2aW5nIEZQ RFQgdGFibGUgbWVtb3J5IGF0IFttZW0gMHg2NjYxNTAwMC0weDY2NjE1MDQzXQpbICAgIDEuMzAx NjMwXSBTZXR0aW5nIEFQSUMgcm91dGluZyB0byBYZW4gUFYuClsgICAgMS4zMDE3MDBdIE5VTUEg dHVybmVkIG9mZgpbICAgIDEuMzAxNzAxXSBGYWtpbmcgYSBub2RlIGF0IFttZW0gMHgwMDAwMDAw MDAwMDAwMDAwLTB4MDAwMDAwMTVmZmZmZmZmZl0KWyAgICAxLjMwMTcxMV0gTk9ERV9EQVRBKDAp IGFsbG9jYXRlZCBbbWVtIDB4MWY1NDRjMDAwLTB4MWY1NDZkZmZmXQpbICAgIDEuMzAxOTY3XSBj cmFzaGtlcm5lbDogbWVtb3J5IHZhbHVlIGV4cGVjdGVkClsgICAgMS43MTQwMzNdIFpvbmUgcmFu Z2VzOgpbICAgIDEuNzE0MDM1XSAgIERNQSAgICAgIFttZW0gMHgwMDAwMDAwMDAwMDAxMDAwLTB4 MDAwMDAwMDAwMGZmZmZmZl0KWyAgICAxLjcxNDAzN10gICBETUEzMiAgICBbbWVtIDB4MDAwMDAw MDAwMTAwMDAwMC0weDAwMDAwMDAwZmZmZmZmZmZdClsgICAgMS43MTQwMzldICAgTm9ybWFsICAg W21lbSAweDAwMDAwMDAxMDAwMDAwMDAtMHgwMDAwMDAxNWZmZmZmZmZmXQpbICAgIDEuNzE0MDQx XSBNb3ZhYmxlIHpvbmUgc3RhcnQgZm9yIGVhY2ggbm9kZQpbICAgIDEuNzE0MDQ0XSBFYXJseSBt ZW1vcnkgbm9kZSByYW5nZXMKWyAgICAxLjcxNDA0NV0gICBub2RlICAgMDogW21lbSAweDAwMDAw MDAwMDAwMDEwMDAtMHgwMDAwMDAwMDAwMDlkZmZmXQpbICAgIDEuNzE0MDQ3XSAgIG5vZGUgICAw OiBbbWVtIDB4MDAwMDAwMDAwMDEwMDAwMC0weDAwMDAwMDAwNjM1ODJmZmZdClsgICAgMS43MTQw NDhdICAgbm9kZSAgIDA6IFttZW0gMHgwMDAwMDAwMDY2OWZlMDAwLTB4MDAwMDAwMDA2ZjdmZmZm Zl0KWyAgICAxLjcxNDA0OV0gICBub2RlICAgMDogW21lbSAweDAwMDAwMDAxMDAwMDAwMDAtMHgw MDAwMDAxNWZmZmZmZmZmXQpbICAgIDEuNzE0MDU3XSBJbml0bWVtIHNldHVwIG5vZGUgMCBbbWVt IDB4MDAwMDAwMDAwMDAwMTAwMC0weDAwMDAwMDE1ZmZmZmZmZmZdClsgICAgMS43MTQwNjJdIE9u IG5vZGUgMCwgem9uZSBETUE6IDEgcGFnZXMgaW4gdW5hdmFpbGFibGUgcmFuZ2VzClsgICAgMS43 MTQwODVdIE9uIG5vZGUgMCwgem9uZSBETUE6IDk4IHBhZ2VzIGluIHVuYXZhaWxhYmxlIHJhbmdl cwpbICAgIDEuNzE2NTcxXSBPbiBub2RlIDAsIHpvbmUgRE1BMzI6IDEzNDM1IHBhZ2VzIGluIHVu YXZhaWxhYmxlIHJhbmdlcwpbICAgIDEuODcxMzAwXSBPbiBub2RlIDAsIHpvbmUgTm9ybWFsOiAy MDQ4IHBhZ2VzIGluIHVuYXZhaWxhYmxlIHJhbmdlcwpbICAgIDEuODcxMzA0XSBwMm0gdmlydHVh bCBhcmVhIGF0IChfX19fcHRydmFsX19fXyksIHNpemUgaXMgNDAwMDAwMDAKWyAgICAyLjE0MDAy Ml0ga21lbWxlYWs6IE1lbW9yeSBwb29sIGVtcHR5LCBjb25zaWRlciBpbmNyZWFzaW5nIENPTkZJ R19ERUJVR19LTUVNTEVBS19NRU1fUE9PTF9TSVpFClsgICAgMi4xNDAwMjVdIGttZW1sZWFrOiBD YW5ub3QgYWxsb2NhdGUgYSBrbWVtbGVha19vYmplY3Qgc3RydWN0dXJlClsgICAgMi4xNDAwMjVd IGttZW1sZWFrOiBLZXJuZWwgbWVtb3J5IGxlYWsgZGV0ZWN0b3IgZGlzYWJsZWQKWyAgICAzLjQ5 Mzc3NF0gUmVtYXBwZWQgNjA1NDA1IHBhZ2UocykKWyAgICAzLjQ5NDM4MF0gQUNQSTogUE0tVGlt ZXIgSU8gUG9ydDogMHg1MDgKWyAgICAzLjQ5NDUyM10gQUNQSTogWDJBUElDX05NSSAodWlkWzB4 ZmZmZmZmZmZdIGhpZ2ggZWRnZSBsaW50WzB4MV0pClsgICAgMy40OTQ1NTFdIEFDUEk6IExBUElD X05NSSAoYWNwaV9pZFsweGZmXSBoaWdoIGVkZ2UgbGludFsweDFdKQpbICAgIDMuNDk0NjA1XSBJ T0FQSUNbMF06IGFwaWNfaWQgOCwgdmVyc2lvbiAzMiwgYWRkcmVzcyAweGZlYzAwMDAwLCBHU0kg MC0xMTkKWyAgICAzLjQ5NDYzM10gQUNQSTogSU5UX1NSQ19PVlIgKGJ1cyAwIGJ1c19pcnEgMCBn bG9iYWxfaXJxIDIgZGZsIGRmbCkKWyAgICAzLjQ5NDYzNl0gQUNQSTogSU5UX1NSQ19PVlIgKGJ1 cyAwIGJ1c19pcnEgOSBnbG9iYWxfaXJxIDkgaGlnaCBsZXZlbCkKWyAgICAzLjQ5NDY5M10gQUNQ STogVXNpbmcgQUNQSSAoTUFEVCkgZm9yIFNNUCBjb25maWd1cmF0aW9uIGluZm9ybWF0aW9uClsg ICAgMy40OTQ2OTddIEFDUEk6IEhQRVQgaWQ6IDB4ODA4NmE3MDEgYmFzZTogMHhmZWQwMDAwMApb ICAgIDMuNDk0NzA4XSBBQ1BJOiBTUENSOiBjb25zb2xlOiB1YXJ0LGlvLDB4M2Y4LDExNTIwMApb ICAgIDMuNTAwNDEzXSBzbXBib290OiBBbGxvd2luZyA4IENQVXMsIDAgaG90cGx1ZyBDUFVzClsg ICAgMy41MDA0MzldIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBb bWVtIDB4MDAwMDAwMDAtMHgwMDAwMGZmZl0KWyAgICAzLjUwMDQ0Ml0gUE06IGhpYmVybmF0aW9u OiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHgwMDA5ZTAwMC0weDAwMDllZmZmXQpb ICAgIDMuNTAwNDQzXSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTog W21lbSAweDAwMDlmMDAwLTB4MDAwOWZmZmZdClsgICAgMy41MDA0NDRdIFBNOiBoaWJlcm5hdGlv bjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4MDAwYTAwMDAtMHgwMDBmZmZmZl0K WyAgICAzLjUwMDQ0NV0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6 IFttZW0gMHg2MzU4MzAwMC0weDY0ZWNiZmZmXQpbICAgIDMuNTAwNDQ2XSBQTTogaGliZXJuYXRp b246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTogW21lbSAweDY0ZWNjMDAwLTB4NjY1MWFmZmZd ClsgICAgMy41MDA0NDddIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5 OiBbbWVtIDB4NjY1MWIwMDAtMHg2NjlmZGZmZl0KWyAgICAzLjUwMDQ0OV0gUE06IGhpYmVybmF0 aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHg2ZjgwMDAwMC0weDhmZmZmZmZm XQpbICAgIDMuNTAwNDQ5XSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9y eTogW21lbSAweDkwMDAwMDAwLTB4OWI3ZmJmZmZdClsgICAgMy41MDA0NTBdIFBNOiBoaWJlcm5h dGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4OWI3ZmMwMDAtMHg5YjdmY2Zm Zl0KWyAgICAzLjUwMDQ1MV0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1v cnk6IFttZW0gMHg5YjdmZDAwMC0weGE2M2ZiZmZmXQpbICAgIDMuNTAwNDUyXSBQTTogaGliZXJu YXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTogW21lbSAweGE2M2ZjMDAwLTB4YTYzZmNm ZmZdClsgICAgMy41MDA0NTJdIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVt b3J5OiBbbWVtIDB4YTYzZmQwMDAtMHhiMGZmYmZmZl0KWyAgICAzLjUwMDQ1M10gUE06IGhpYmVy bmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHhiMGZmYzAwMC0weGIwZmZj ZmZmXQpbICAgIDMuNTAwNDUzXSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1l bW9yeTogW21lbSAweGIwZmZkMDAwLTB4YmJiZmJmZmZdClsgICAgMy41MDA0NTRdIFBNOiBoaWJl cm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4YmJiZmMwMDAtMHhiYmJm Y2ZmZl0KWyAgICAzLjUwMDQ1NV0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBt ZW1vcnk6IFttZW0gMHhiYmJmZDAwMC0weGM1ZmZiZmZmXQpbICAgIDMuNTAwNDU1XSBQTTogaGli ZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTogW21lbSAweGM1ZmZjMDAwLTB4YzVm ZmNmZmZdClsgICAgMy41MDA0NTZdIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUg bWVtb3J5OiBbbWVtIDB4YzVmZmQwMDAtMHhkMGZmYmZmZl0KWyAgICAzLjUwMDQ1Nl0gUE06IGhp YmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHhkMGZmYzAwMC0weGQw ZmZjZmZmXQpbICAgIDMuNTAwNDU3XSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZl IG1lbW9yeTogW21lbSAweGQwZmZkMDAwLTB4ZGJiZmJmZmZdClsgICAgMy41MDA0NTddIFBNOiBo aWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4ZGJiZmMwMDAtMHhk YmJmY2ZmZl0KWyAgICAzLjUwMDQ1OF0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2 ZSBtZW1vcnk6IFttZW0gMHhkYmJmZDAwMC0weGU2N2ZiZmZmXQpbICAgIDMuNTAwNDU5XSBQTTog aGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTogW21lbSAweGU2N2ZjMDAwLTB4 ZTY3ZmNmZmZdClsgICAgMy41MDA0NTldIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3Nh dmUgbWVtb3J5OiBbbWVtIDB4ZTY3ZmQwMDAtMHhmMTNmYmZmZl0KWyAgICAzLjUwMDQ2MF0gUE06 IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHhmMTNmYzAwMC0w eGYxM2ZjZmZmXQpbICAgIDMuNTAwNDYwXSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9z YXZlIG1lbW9yeTogW21lbSAweGYxM2ZkMDAwLTB4ZmI3ZmJmZmZdClsgICAgMy41MDA0NjFdIFBN OiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4ZmI3ZmMwMDAt MHhmYjdmY2ZmZl0KWyAgICAzLjUwMDQ2Ml0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5v c2F2ZSBtZW1vcnk6IFttZW0gMHhmYjdmZDAwMC0weGZkZmZmZmZmXQpbICAgIDMuNTAwNDYyXSBQ TTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQgbm9zYXZlIG1lbW9yeTogW21lbSAweGZlMDAwMDAw LTB4ZmUwMTBmZmZdClsgICAgMy41MDA0NjNdIFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBu b3NhdmUgbWVtb3J5OiBbbWVtIDB4ZmUwMTEwMDAtMHhmZWJmZmZmZl0KWyAgICAzLjUwMDQ2M10g UE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVkIG5vc2F2ZSBtZW1vcnk6IFttZW0gMHhmZWMwMDAw MC0weGZlYzAwZmZmXQpbICAgIDMuNTAwNDY0XSBQTTogaGliZXJuYXRpb246IFJlZ2lzdGVyZWQg bm9zYXZlIG1lbW9yeTogW21lbSAweGZlYzAxMDAwLTB4ZmVkZmZmZmZdClsgICAgMy41MDA0NjRd IFBNOiBoaWJlcm5hdGlvbjogUmVnaXN0ZXJlZCBub3NhdmUgbWVtb3J5OiBbbWVtIDB4ZmVlMDAw MDAtMHhmZWVmZmZmZl0KWyAgICAzLjUwMDQ2NV0gUE06IGhpYmVybmF0aW9uOiBSZWdpc3RlcmVk IG5vc2F2ZSBtZW1vcnk6IFttZW0gMHhmZWYwMDAwMC0weGZmZmZmZmZmXQpbICAgIDMuNTAwNDY3 XSBbbWVtIDB4OTAwMDAwMDAtMHg5YjdmYmZmZl0gYXZhaWxhYmxlIGZvciBQQ0kgZGV2aWNlcwpb ICAgIDMuNTAwNDcxXSBCb290aW5nIGtlcm5lbCBvbiBYZW4KWyAgICAzLjUwMDQ3MV0gWGVuIHZl cnNpb246IDQuMTctdW5zdGFibGUgKHByZXNlcnZlLUFEKQpbICAgIDMuNTAwNDc0XSBjbG9ja3Nv dXJjZTogcmVmaW5lZC1qaWZmaWVzOiBtYXNrOiAweGZmZmZmZmZmIG1heF9jeWNsZXM6IDB4ZmZm ZmZmZmYsIG1heF9pZGxlX25zOiAxOTEwOTY5OTQwMzkxNDE5IG5zClsgICAgMy41MDUxNDJdIHNl dHVwX3BlcmNwdTogTlJfQ1BVUzo4MTkyIG5yX2NwdW1hc2tfYml0czo4IG5yX2NwdV9pZHM6OCBu cl9ub2RlX2lkczoxClsgICAgMy41MDU0OTFdIHBlcmNwdTogRW1iZWRkZWQgNTQgcGFnZXMvY3B1 IHMxODMwMTYgcjgxOTIgZDI5OTc2IHUyNjIxNDQKWyAgICAzLjUwNTU3MV0gUFYgcXNwaW5sb2Nr IGhhc2ggdGFibGUgZW50cmllczogMjU2IChvcmRlcjogMCwgNDA5NiBieXRlcywgbGluZWFyKQpb ICAgIDMuNTA1NTc2XSBGYWxsYmFjayBvcmRlciBmb3IgTm9kZSAwOiAwIApbICAgIDMuNTA1NTgw XSBCdWlsdCAxIHpvbmVsaXN0cywgbW9iaWxpdHkgZ3JvdXBpbmcgb24uICBUb3RhbCBwYWdlczog MjIxMTIxMTgKWyAgICAzLjUwNTU4MV0gUG9saWN5IHpvbmU6IE5vcm1hbApbICAgIDMuNTA1NTgz XSBLZXJuZWwgY29tbWFuZCBsaW5lOiByb290PS9kZXYvbWFwcGVyL3JoZWwtcm9vdCBybyBjcmFz aGtlcm5lbD1hdXRvIGNvbnNvbGU9aHZjMCxjb25zb2xlPXR0eVMwLDExNTIwMCw4bjEgaW50ZWxf aW9tbXU9b24KWyAgICAzLjUwNTY0NF0gRE1BUjogSU9NTVUgZW5hYmxlZApbICAgIDMuNTEzNTI2 XSBEZW50cnkgY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiA4Mzg4NjA4IChvcmRlcjogMTQsIDY3 MTA4ODY0IGJ5dGVzLCBsaW5lYXIpClsgICAgMy41MTc1MzZdIElub2RlLWNhY2hlIGhhc2ggdGFi bGUgZW50cmllczogNDE5NDMwNCAob3JkZXI6IDEzLCAzMzU1NDQzMiBieXRlcywgbGluZWFyKQpb ICAgIDMuNTE4NDg1XSBtZW0gYXV0by1pbml0OiBzdGFjazpvZmYsIGhlYXAgYWxsb2M6b2ZmLCBo ZWFwIGZyZWU6b2ZmClsgICAgMy44MDg0NzhdIE1lbW9yeTogNjM5MjE0MEsvODk4NTMwNjRLIGF2 YWlsYWJsZSAoMTIyOTRLIGtlcm5lbCBjb2RlLCA1NDE0SyByd2RhdGEsIDQ0MzZLIHJvZGF0YSwg MjQ0NEsgaW5pdCwgODg0NEsgYnNzLCA4MzQ2MDY3MksgcmVzZXJ2ZWQsIDBLIGNtYS1yZXNlcnZl ZCkKWyAgICAzLjgwODY1M10gU0xVQjogSFdhbGlnbj02NCwgT3JkZXI9MC0zLCBNaW5PYmplY3Rz PTAsIENQVXM9OCwgTm9kZXM9MQpbICAgIDMuODA5NzM0XSBmdHJhY2U6IGFsbG9jYXRpbmcgMzg3 OTcgZW50cmllcyBpbiAxNTIgcGFnZXMKWyAgICAzLjgxNjg0NV0gZnRyYWNlOiBhbGxvY2F0ZWQg MTUyIHBhZ2VzIHdpdGggMyBncm91cHMKWyAgICAzLjgxNzYxNV0gRHluYW1pYyBQcmVlbXB0OiB2 b2x1bnRhcnkKWyAgICAzLjgxNzcyNV0gcmN1OiBQcmVlbXB0aWJsZSBoaWVyYXJjaGljYWwgUkNV IGltcGxlbWVudGF0aW9uLgpbICAgIDMuODE3NzI2XSByY3U6IAlSQ1UgcmVzdHJpY3RpbmcgQ1BV cyBmcm9tIE5SX0NQVVM9ODE5MiB0byBucl9jcHVfaWRzPTguClsgICAgMy44MTc3MjddIAlUcmFt cG9saW5lIHZhcmlhbnQgb2YgVGFza3MgUkNVIGVuYWJsZWQuClsgICAgMy44MTc3MjhdIAlSdWRl IHZhcmlhbnQgb2YgVGFza3MgUkNVIGVuYWJsZWQuClsgICAgMy44MTc3MjhdIHJjdTogUkNVIGNh bGN1bGF0ZWQgdmFsdWUgb2Ygc2NoZWR1bGVyLWVubGlzdG1lbnQgZGVsYXkgaXMgMTAwIGppZmZp ZXMuClsgICAgMy44MTc3MjldIHJjdTogQWRqdXN0aW5nIGdlb21ldHJ5IGZvciByY3VfZmFub3V0 X2xlYWY9MTYsIG5yX2NwdV9pZHM9OApbICAgIDMuODI2OTU1XSBVc2luZyBOVUxMIGxlZ2FjeSBQ SUMKWyAgICAzLjgyNjk1Nl0gTlJfSVJRUzogNTI0NTQ0LCBucl9pcnFzOiAyMDQ4LCBwcmVhbGxv Y2F0ZWQgaXJxczogMApbICAgIDMuODI3MDI5XSB4ZW46ZXZlbnRzOiBVc2luZyBGSUZPLWJhc2Vk IEFCSQpbICAgIDMuODI3MjE4XSByY3U6IHNyY3VfaW5pdDogU2V0dGluZyBzcmN1X3N0cnVjdCBz aXplcyBiYXNlZCBvbiBjb250ZW50aW9uLgpbICAgIDMuODI3MjM4XSByYW5kb206IGNybmcgaW5p dCBkb25lClsgICAgMy44MjcyODVdIENvbnNvbGU6IGNvbG91ciBkdW1teSBkZXZpY2UgODB4MjUK WyAgICAzLjgyNzY0N10gcHJpbnRrOiBjb25zb2xlIFt0dHkwXSBlbmFibGVkClsgICAgNS42Mzg5 NTZdIHByaW50azogY29uc29sZSBbaHZjMF0gZW5hYmxlZApbICAgIDUuNjQzMTM5XSBBQ1BJOiBD b3JlIHJldmlzaW9uIDIwMjIwMzMxClsgICAgNi4wNjU3MjRdIGNsb2Nrc291cmNlOiB4ZW46IG1h c2s6IDB4ZmZmZmZmZmZmZmZmZmZmZiBtYXhfY3ljbGVzOiAweDFjZDQyZTRkZmZiLCBtYXhfaWRs ZV9uczogODgxNTkwNTkxNDgzIG5zClsgICAgNi4wNzU1NjNdIGluc3RhbGxpbmcgWGVuIHRpbWVy IGZvciBDUFUgMApbICAgIDYuMDc5NzQ1XSBjbG9ja3NvdXJjZTogdHNjLWVhcmx5OiBtYXNrOiAw eGZmZmZmZmZmZmZmZmZmZmYgbWF4X2N5Y2xlczogMHgyMjgzNzRkYWU1ZCwgbWF4X2lkbGVfbnM6 IDQ0MDc5NTI2ODM1MiBucwpbICAgIDYuMDkwMzAxXSBDYWxpYnJhdGluZyBkZWxheSBsb29wIChz a2lwcGVkKSwgdmFsdWUgY2FsY3VsYXRlZCB1c2luZyB0aW1lciBmcmVxdWVuY3kuLiA0Nzg4Ljc0 IEJvZ29NSVBTIChscGo9MjM5NDM3NCkKWyAgICA2LjA5MTMwNV0gcGlkX21heDogZGVmYXVsdDog MzI3NjggbWluaW11bTogMzAxClsgICAgNi4wOTIzNDhdIExTTTogU2VjdXJpdHkgRnJhbWV3b3Jr IGluaXRpYWxpemluZwpbICAgIDYuMDkzMzIyXSBTRUxpbnV4OiAgSW5pdGlhbGl6aW5nLgpbICAg IDYuMDk0MzA0XSBTRUxpbnV4OiBDT05GSUdfU0VDVVJJVFlfU0VMSU5VWF9DSEVDS1JFUVBST1Rf VkFMVUUgaXMgbm9uLXplcm8uICBUaGlzIGlzIGRlcHJlY2F0ZWQgYW5kIHdpbGwgYmUgcmVqZWN0 ZWQgaW4gYSBmdXR1cmUga2VybmVsIHJlbGVhc2UuClsgICAgNi4wOTUzMDZdIFNFTGludXg6IGh0 dHBzOi8vZ2l0aHViLmNvbS9TRUxpbnV4UHJvamVjdC9zZWxpbnV4LWtlcm5lbC93aWtpL0RFUFJF Q0FURS1jaGVja3JlcXByb3QKWyAgICA2LjA5NjUzM10gTW91bnQtY2FjaGUgaGFzaCB0YWJsZSBl bnRyaWVzOiAxMzEwNzIgKG9yZGVyOiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5lYXIpClsgICAgNi4w OTc0MDddIE1vdW50cG9pbnQtY2FjaGUgaGFzaCB0YWJsZSBlbnRyaWVzOiAxMzEwNzIgKG9yZGVy OiA4LCAxMDQ4NTc2IGJ5dGVzLCBsaW5lYXIpClsgICAgNi4wOTg5MDJdIExhc3QgbGV2ZWwgaVRM QiBlbnRyaWVzOiA0S0IgMCwgMk1CIDAsIDRNQiAwClsgICAgNi4wOTkzMDddIExhc3QgbGV2ZWwg ZFRMQiBlbnRyaWVzOiA0S0IgMCwgMk1CIDAsIDRNQiAwLCAxR0IgMApbICAgIDYuMTAwMzEwXSBT cGVjdHJlIFYxIDogTWl0aWdhdGlvbjogdXNlcmNvcHkvc3dhcGdzIGJhcnJpZXJzIGFuZCBfX3Vz ZXIgcG9pbnRlciBzYW5pdGl6YXRpb24KWyAgICA2LjEwMTMwN10gU3BlY3RyZSBWMiA6IE1pdGln YXRpb246IEVuaGFuY2VkIElCUlMKWyAgICA2LjEwMjMwNF0gU3BlY3RyZSBWMiA6IFNwZWN0cmUg djIgLyBTcGVjdHJlUlNCIG1pdGlnYXRpb246IEZpbGxpbmcgUlNCIG9uIGNvbnRleHQgc3dpdGNo ClsgICAgNi4xMDMzMDVdIFNwZWN0cmUgVjIgOiBtaXRpZ2F0aW9uOiBFbmFibGluZyBjb25kaXRp b25hbCBJbmRpcmVjdCBCcmFuY2ggUHJlZGljdGlvbiBCYXJyaWVyClsgICAgNi4xMDQzMDVdIFNw ZWN1bGF0aXZlIFN0b3JlIEJ5cGFzczogTWl0aWdhdGlvbjogU3BlY3VsYXRpdmUgU3RvcmUgQnlw YXNzIGRpc2FibGVkIHZpYSBwcmN0bApbICAgIDYuMTA1MzEwXSBNTUlPIFN0YWxlIERhdGE6IFZ1 bG5lcmFibGU6IENsZWFyIENQVSBidWZmZXJzIGF0dGVtcHRlZCwgbm8gbWljcm9jb2RlClsgICAg Ni4xMTAzOThdIEZyZWVpbmcgU01QIGFsdGVybmF0aXZlcyBtZW1vcnk6IDMySwpbICAgIDYuMTEx MzgyXSBjcHUgMCBzcGlubG9jayBldmVudCBpcnEgMTIxClsgICAgNi4xMTI3NDhdIGNibGlzdF9p bml0X2dlbmVyaWM6IFNldHRpbmcgYWRqdXN0YWJsZSBudW1iZXIgb2YgY2FsbGJhY2sgcXVldWVz LgpbICAgIDYuMTEzMzAzXSBjYmxpc3RfaW5pdF9nZW5lcmljOiBTZXR0aW5nIHNoaWZ0IHRvIDMg YW5kIGxpbSB0byAxLgpbICAgIDYuMTE0MzQwXSBjYmxpc3RfaW5pdF9nZW5lcmljOiBTZXR0aW5n IHNoaWZ0IHRvIDMgYW5kIGxpbSB0byAxLgooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3Au YzoxMDI3OmQwdjAgUkRNU1IgMHgwMDAwMDFjOSB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2 L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MCBSRE1TUiAweDAwMDAwMWE2IHVuaW1wbGVtZW50 ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYwIFJETVNSIDB4MDAw MDAxYTcgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3 OmQwdjAgUkRNU1IgMHgwMDAwMDNmNiB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2Vt dWwtcHJpdi1vcC5jOjEwMjc6ZDB2MCBSRE1TUiAweDAwMDAwM2Y3IHVuaW1wbGVtZW50ZWQKKFhF TikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYwIFJETVNSIDB4MDAwMDAxOGEg dW5pbXBsZW1lbnRlZApbICAgIDYuMTE1MzM1XSBQZXJmb3JtYW5jZSBFdmVudHM6IEljZWxha2Ug ZXZlbnRzLCBQTVUgbm90IGF2YWlsYWJsZSBkdWUgdG8gdmlydHVhbGl6YXRpb24sIHVzaW5nIHNv ZnR3YXJlIGV2ZW50cyBvbmx5LgpbICAgIDYuMTIyMzg0XSByY3U6IEhpZXJhcmNoaWNhbCBTUkNV IGltcGxlbWVudGF0aW9uLgpbICAgIDYuMTIzNzY1XSBOTUkgd2F0Y2hkb2c6IFBlcmYgTk1JIHdh dGNoZG9nIHBlcm1hbmVudGx5IGRpc2FibGVkClsgICAgNi4xMjQ0ODddIHNtcDogQnJpbmdpbmcg dXAgc2Vjb25kYXJ5IENQVXMgLi4uClsgICAgNi4xMjU0NjddIGluc3RhbGxpbmcgWGVuIHRpbWVy IGZvciBDUFUgMQpbICAgIDYuMTI2NzQ5XSBjcHUgMSBzcGlubG9jayBldmVudCBpcnEgMTMzClsg ICAgNi4xMzA3MzJdIE1NSU8gU3RhbGUgRGF0YSBDUFUgYnVnIHByZXNlbnQgYW5kIFNNVCBvbiwg ZGF0YSBsZWFrIHBvc3NpYmxlLiBTZWUgaHR0cHM6Ly93d3cua2VybmVsLm9yZy9kb2MvaHRtbC9s YXRlc3QvYWRtaW4tZ3VpZGUvaHctdnVsbi9wcm9jZXNzb3JfbW1pb19zdGFsZV9kYXRhLmh0bWwg Zm9yIG1vcmUgZGV0YWlscy4KWyAgICA2LjEzMTQ5NV0gaW5zdGFsbGluZyBYZW4gdGltZXIgZm9y IENQVSAyClsgICAgNi4xMzI2ODldIGNwdSAyIHNwaW5sb2NrIGV2ZW50IGlycSAxNDAKWyAgICA2 LjEzNjQ4NV0gaW5zdGFsbGluZyBYZW4gdGltZXIgZm9yIENQVSAzClsgICAgNi4xMzc2MTRdIGNw dSAzIHNwaW5sb2NrIGV2ZW50IGlycSAxNDcKWyAgICA2LjE0MTQ3NV0gaW5zdGFsbGluZyBYZW4g dGltZXIgZm9yIENQVSA0ClsgICAgNi4xNDI1ODVdIGNwdSA0IHNwaW5sb2NrIGV2ZW50IGlycSAx NTQKWyAgICA2LjE0NjQ2N10gaW5zdGFsbGluZyBYZW4gdGltZXIgZm9yIENQVSA1ClsgICAgNi4x NDc2NDVdIGNwdSA1IHNwaW5sb2NrIGV2ZW50IGlycSAxNjEKWyAgICA2LjE1MTUwMV0gaW5zdGFs bGluZyBYZW4gdGltZXIgZm9yIENQVSA2ClsgICAgNi4xNTI2MTldIGNwdSA2IHNwaW5sb2NrIGV2 ZW50IGlycSAxNjgKWyAgICA2LjE1NjQ2Nl0gaW5zdGFsbGluZyBYZW4gdGltZXIgZm9yIENQVSA3 ClsgICAgNi4xNTc2MzBdIGNwdSA3IHNwaW5sb2NrIGV2ZW50IGlycSAxNzUKWyAgICA2LjE2MTQy MV0gc21wOiBCcm91Z2h0IHVwIDEgbm9kZSwgOCBDUFVzClsgICAgNi4xNjIzMDZdIHNtcGJvb3Q6 IE1heCBsb2dpY2FsIHBhY2thZ2VzOiAxClsgICAgNi4xNjYzNTBdIGRldnRtcGZzOiBpbml0aWFs aXplZApbICAgIDYuMTY3MzQ3XSB4ODYvbW06IE1lbW9yeSBibG9jayBzaXplOiAyMDQ4TUIKWyAg ICA2LjE2ODg1Ml0gQUNQSTogUE06IFJlZ2lzdGVyaW5nIEFDUEkgTlZTIHJlZ2lvbiBbbWVtIDB4 MDAwOWYwMDAtMHgwMDA5ZmZmZl0gKDQwOTYgYnl0ZXMpClsgICAgNi4xNjkzMDZdIEFDUEk6IFBN OiBSZWdpc3RlcmluZyBBQ1BJIE5WUyByZWdpb24gW21lbSAweDY0ZWNjMDAwLTB4NjY1MWFmZmZd ICgyMzM5MjI1NiBieXRlcykKWyAgICA2LjE3MDYzMF0gY2xvY2tzb3VyY2U6IGppZmZpZXM6IG1h c2s6IDB4ZmZmZmZmZmYgbWF4X2N5Y2xlczogMHhmZmZmZmZmZiwgbWF4X2lkbGVfbnM6IDE5MTEy NjA0NDYyNzUwMDAgbnMKWyAgICA2LjE3MTMxMl0gZnV0ZXggaGFzaCB0YWJsZSBlbnRyaWVzOiAy MDQ4IChvcmRlcjogNSwgMTMxMDcyIGJ5dGVzLCBsaW5lYXIpClsgICAgNi4xNzQwMjNdIE5FVDog UmVnaXN0ZXJlZCBQRl9ORVRMSU5LL1BGX1JPVVRFIHByb3RvY29sIGZhbWlseQpbICAgIDYuMTc0 MzIwXSB4ZW46Z3JhbnRfdGFibGU6IEdyYW50IHRhYmxlcyB1c2luZyB2ZXJzaW9uIDEgbGF5b3V0 ClsgICAgNi4xNzUzMzBdIEdyYW50IHRhYmxlIGluaXRpYWxpemVkClsgICAgNi4xNzY1MTddIGF1 ZGl0OiBpbml0aWFsaXppbmcgbmV0bGluayBzdWJzeXMgKGRpc2FibGVkKQpbICAgIDYuMTc3MzM5 XSBhdWRpdDogdHlwZT0yMDAwIGF1ZGl0KDE2NTgzODI4MDIuNDIzOjEpOiBzdGF0ZT1pbml0aWFs aXplZCBhdWRpdF9lbmFibGVkPTAgcmVzPTEKWyAgICA2LjE3NzM3MF0gdGhlcm1hbF9zeXM6IFJl Z2lzdGVyZWQgdGhlcm1hbCBnb3Zlcm5vciAnZmFpcl9zaGFyZScKWyAgICA2LjE3ODMxMV0gdGhl cm1hbF9zeXM6IFJlZ2lzdGVyZWQgdGhlcm1hbCBnb3Zlcm5vciAnYmFuZ19iYW5nJwpbICAgIDYu MTc5MzA2XSB0aGVybWFsX3N5czogUmVnaXN0ZXJlZCB0aGVybWFsIGdvdmVybm9yICdzdGVwX3dp c2UnClsgICAgNi4xODAzMDRdIHRoZXJtYWxfc3lzOiBSZWdpc3RlcmVkIHRoZXJtYWwgZ292ZXJu b3IgJ3VzZXJfc3BhY2UnClsgICAgNi4xODEzMzVdIGFjcGlwaHA6IEFDUEkgSG90IFBsdWcgUENJ IENvbnRyb2xsZXIgRHJpdmVyIHZlcnNpb246IDAuNQpbICAgIDYuMTg0MDc4XSBQQ0k6IE1NQ09O RklHIGZvciBkb21haW4gMDAwMCBbYnVzIDAwLWZmXSBhdCBbbWVtIDB4ODAwMDAwMDAtMHg4ZmZm ZmZmZl0gKGJhc2UgMHg4MDAwMDAwMCkKWyAgICA2LjE4NDMwNl0gUENJOiBNTUNPTkZJRyBhdCBb bWVtIDB4ODAwMDAwMDAtMHg4ZmZmZmZmZl0gcmVzZXJ2ZWQgaW4gRTgyMAooWEVOKSBkMDogRm9y Y2luZyB3cml0ZSBlbXVsYXRpb24gb24gTUZOcyA4MDAwMC04ZmZmZgpbICAgIDYuMjY4NTE3XSBQ Q0k6IFVzaW5nIGNvbmZpZ3VyYXRpb24gdHlwZSAxIGZvciBiYXNlIGFjY2VzcwpbICAgIDYuMjcw NjA4XSBrcHJvYmVzOiBrcHJvYmUganVtcC1vcHRpbWl6YXRpb24gaXMgZW5hYmxlZC4gQWxsIGtw cm9iZXMgYXJlIG9wdGltaXplZCBpZiBwb3NzaWJsZS4KWyAgICA2LjI3MTM3M10gQUNQSTogQWRk ZWQgX09TSShNb2R1bGUgRGV2aWNlKQpbICAgIDYuMjc1MzA3XSBBQ1BJOiBBZGRlZCBfT1NJKFBy b2Nlc3NvciBEZXZpY2UpClsgICAgNi4yODAzMDhdIEFDUEk6IEFkZGVkIF9PU0koMy4wIF9TQ1Ag RXh0ZW5zaW9ucykKWyAgICA2LjI4NDMwNl0gQUNQSTogQWRkZWQgX09TSShQcm9jZXNzb3IgQWdn cmVnYXRvciBEZXZpY2UpClsgICAgNi4yOTAzMDhdIEFDUEk6IEFkZGVkIF9PU0koTGludXgtRGVs bC1WaWRlbykKWyAgICA2LjI5NDMwNl0gQUNQSTogQWRkZWQgX09TSShMaW51eC1MZW5vdm8tTlYt SERNSS1BdWRpbykKWyAgICA2LjMwMDMwOF0gQUNQSTogQWRkZWQgX09TSShMaW51eC1IUEktSHli cmlkLUdyYXBoaWNzKQpbICAgIDYuNDc3NDM2XSBBQ1BJOiA4IEFDUEkgQU1MIHRhYmxlcyBzdWNj ZXNzZnVsbHkgYWNxdWlyZWQgYW5kIGxvYWRlZApbICAgIDYuNDk3MTc2XSBBQ1BJOiBEeW5hbWlj IE9FTSBUYWJsZSBMb2FkOgpbICAgIDYuNjgyODIzXSBBQ1BJOiBEeW5hbWljIE9FTSBUYWJsZSBM b2FkOgpbICAgIDYuNzMyOTA3XSBBQ1BJOiBEeW5hbWljIE9FTSBUYWJsZSBMb2FkOgpbICAgIDcu MTA3MDk5XSBBQ1BJOiBJbnRlcnByZXRlciBlbmFibGVkClsgICAgNy4xMDczMjJdIEFDUEk6IFBN OiAoc3VwcG9ydHMgUzAgUzUpClsgICAgNy4xMDgzMDVdIEFDUEk6IFVzaW5nIElPQVBJQyBmb3Ig aW50ZXJydXB0IHJvdXRpbmcKWyAgICA3LjEwOTQwN10gSEVTVDogVGFibGUgcGFyc2luZyBoYXMg YmVlbiBpbml0aWFsaXplZC4KWyAgICA3LjExMDQzNF0gR0hFUzogQVBFSSBmaXJtd2FyZSBmaXJz dCBtb2RlIGlzIGVuYWJsZWQgYnkgQVBFSSBiaXQgYW5kIFdIRUEgX09TQy4KWyAgICA3LjExMTMw OF0gUENJOiBVc2luZyBob3N0IGJyaWRnZSB3aW5kb3dzIGZyb20gQUNQSTsgaWYgbmVjZXNzYXJ5 LCB1c2UgInBjaT1ub2NycyIgYW5kIHJlcG9ydCBhIGJ1ZwpbICAgIDcuMTEyMzA4XSBQQ0k6IFVz aW5nIEU4MjAgcmVzZXJ2YXRpb25zIGZvciBob3N0IGJyaWRnZSB3aW5kb3dzClsgICAgNy4xMzY5 MTBdIEFDUEk6IEVuYWJsZWQgNSBHUEVzIGluIGJsb2NrIDAwIHRvIDdGClsgICAgNy4yMjczMTVd IEFQSUM6IE5SX0NQVVMvcG9zc2libGVfY3B1cyBsaW1pdCBvZiA4IHJlYWNoZWQuIFByb2Nlc3Nv ciA4LzB4MTAgaWdub3JlZC4KWyAgICA3LjIzNDMwOF0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBp YyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjI0MDcxMl0gQVBJQzogTlJfQ1BVUy9wb3Nz aWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDkvMHgxMiBpZ25vcmVkLgpb ICAgIDcuMjQ4MzEzXSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51 bWJlcgpbICAgIDcuMjUzNjY5XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2Yg OCByZWFjaGVkLiBQcm9jZXNzb3IgMTAvMHgxNCBpZ25vcmVkLgpbICAgIDcuMjYxMzA2XSBBQ1BJ OiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuMjY3NjY1 XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNz b3IgMTEvMHgxNiBpZ25vcmVkLgpbICAgIDcuMjc1MzA2XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxh cGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuMjgxNjYzXSBBUElDOiBOUl9DUFVTL3Bv c3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTIvMHgxOCBpZ25vcmVk LgpbICAgIDcuMjg5MzA3XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1 IG51bWJlcgpbICAgIDcuMjk0NjYzXSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQg b2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTMvMHgxYSBpZ25vcmVkLgpbICAgIDcuMzAyMzA3XSBB Q1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuMzA4 NjY0XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9j ZXNzb3IgMTQvMHgxYyBpZ25vcmVkLgpbICAgIDcuMzE2MzA3XSBBQ1BJOiBVbmFibGUgdG8gbWFw IGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuMzIyNjU1XSBBUElDOiBOUl9DUFVT L3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTUvMHgxZSBpZ25v cmVkLgpbICAgIDcuMzMwMzA2XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwg Y3B1IG51bWJlcgpbICAgIDcuMzM1NjYyXSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGlt aXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTYvMHgyMCBpZ25vcmVkLgpbICAgIDcuMzQzMzA3 XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcu MzQ5NjU5XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQ cm9jZXNzb3IgMTcvMHgyMiBpZ25vcmVkLgpbICAgIDcuMzU3MzA3XSBBQ1BJOiBVbmFibGUgdG8g bWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuMzYzNjY0XSBBUElDOiBOUl9D UFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTgvMHgyNCBp Z25vcmVkLgpbICAgIDcuMzcxMzExXSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2lj YWwgY3B1IG51bWJlcgpbICAgIDcuMzc2NjY1XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMg bGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMTkvMHgyNiBpZ25vcmVkLgpbICAgIDcuMzg0 MzEyXSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAg IDcuMzkwNjYyXSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVk LiBQcm9jZXNzb3IgMjAvMHgyOCBpZ25vcmVkLgpbICAgIDcuMzk4MzA3XSBBQ1BJOiBVbmFibGUg dG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuNDA0NjU2XSBBUElDOiBO Ul9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMjEvMHgy YSBpZ25vcmVkLgpbICAgIDcuNDEyMzA2XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxv Z2ljYWwgY3B1IG51bWJlcgpbICAgIDcuNDE3NjYwXSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2Nw dXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMjIvMHgyYyBpZ25vcmVkLgpbICAgIDcu NDI1MzA2XSBBQ1BJOiBVbmFibGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpb ICAgIDcuNDMxNjU4XSBBUElDOiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFj aGVkLiBQcm9jZXNzb3IgMjMvMHgyZSBpZ25vcmVkLgpbICAgIDcuNDM5MzA3XSBBQ1BJOiBVbmFi bGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuNDQ1NjU3XSBBUElD OiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMjQv MHgxIGlnbm9yZWQuClsgICAgNy40NTMzMDZdIEFDUEk6IFVuYWJsZSB0byBtYXAgbGFwaWMgdG8g bG9naWNhbCBjcHUgbnVtYmVyClsgICAgNy40NTg2NjJdIEFQSUM6IE5SX0NQVVMvcG9zc2libGVf Y3B1cyBsaW1pdCBvZiA4IHJlYWNoZWQuIFByb2Nlc3NvciAyNS8weDMgaWdub3JlZC4KWyAgICA3 LjQ2NjMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA3LjQ3MjY1OV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDI2LzB4NSBpZ25vcmVkLgpbICAgIDcuNDgwMzA4XSBBQ1BJOiBVbmFi bGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuNDg1NjYxXSBBUElD OiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMjcv MHg3IGlnbm9yZWQuClsgICAgNy40OTMzMDddIEFDUEk6IFVuYWJsZSB0byBtYXAgbGFwaWMgdG8g bG9naWNhbCBjcHUgbnVtYmVyClsgICAgNy40OTk2NTldIEFQSUM6IE5SX0NQVVMvcG9zc2libGVf Y3B1cyBsaW1pdCBvZiA4IHJlYWNoZWQuIFByb2Nlc3NvciAyOC8weDkgaWdub3JlZC4KWyAgICA3 LjUwNzMxMl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA3LjUxMzY2Nl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDI5LzB4YiBpZ25vcmVkLgpbICAgIDcuNTIxMzEyXSBBQ1BJOiBVbmFi bGUgdG8gbWFwIGxhcGljIHRvIGxvZ2ljYWwgY3B1IG51bWJlcgpbICAgIDcuNTI2NjYxXSBBUElD OiBOUl9DUFVTL3Bvc3NpYmxlX2NwdXMgbGltaXQgb2YgOCByZWFjaGVkLiBQcm9jZXNzb3IgMzAv MHhkIGlnbm9yZWQuClsgICAgNy41MzQzMDZdIEFDUEk6IFVuYWJsZSB0byBtYXAgbGFwaWMgdG8g bG9naWNhbCBjcHUgbnVtYmVyClsgICAgNy41NDA2NThdIEFQSUM6IE5SX0NQVVMvcG9zc2libGVf Y3B1cyBsaW1pdCBvZiA4IHJlYWNoZWQuIFByb2Nlc3NvciAzMS8weGYgaWdub3JlZC4KWyAgICA3 LjU0ODMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA3LjU1MzY1N10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDMyLzB4MTEgaWdub3JlZC4KWyAgICA3LjU2MTMwN10gQUNQSTogVW5h YmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjU2NzY2MV0gQVBJ QzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDMz LzB4MTMgaWdub3JlZC4KWyAgICA3LjU3NTMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0 byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjU4MDY1N10gQVBJQzogTlJfQ1BVUy9wb3NzaWJs ZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDM0LzB4MTUgaWdub3JlZC4KWyAg ICA3LjU4ODMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1i ZXIKWyAgICA3LjU5NDY2NF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDgg cmVhY2hlZC4gUHJvY2Vzc29yIDM1LzB4MTcgaWdub3JlZC4KWyAgICA3LjYwMjMwN10gQUNQSTog VW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjYwODY1OF0g QVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29y IDM2LzB4MTkgaWdub3JlZC4KWyAgICA3LjYxNjMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBp YyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjYyMTY2M10gQVBJQzogTlJfQ1BVUy9wb3Nz aWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDM3LzB4MWIgaWdub3JlZC4K WyAgICA3LjYyOTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBu dW1iZXIKWyAgICA3LjYzNTY2M10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9m IDggcmVhY2hlZC4gUHJvY2Vzc29yIDM4LzB4MWQgaWdub3JlZC4KWyAgICA3LjY0MzMxMl0gQUNQ STogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjY0OTY2 NV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vz c29yIDM5LzB4MWYgaWdub3JlZC4KWyAgICA3LjY1NzMxM10gQUNQSTogVW5hYmxlIHRvIG1hcCBs YXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjY2MjY2NF0gQVBJQzogTlJfQ1BVUy9w b3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQwLzB4MjEgaWdub3Jl ZC4KWyAgICA3LjY3MDMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNw dSBudW1iZXIKWyAgICA3LjY3NjY2MF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0 IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQxLzB4MjMgaWdub3JlZC4KWyAgICA3LjY4NDMwNl0g QUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjY5 MDY2MF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJv Y2Vzc29yIDQyLzB4MjUgaWdub3JlZC4KWyAgICA3LjY5ODMwNl0gQUNQSTogVW5hYmxlIHRvIG1h cCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjcwMzY2MV0gQVBJQzogTlJfQ1BV Uy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQzLzB4MjcgaWdu b3JlZC4KWyAgICA3LjcxMTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2Fs IGNwdSBudW1iZXIKWyAgICA3LjcxNzY2MV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxp bWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQ0LzB4MjkgaWdub3JlZC4KWyAgICA3LjcyNTMw N10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3 LjczMTY2MF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4g UHJvY2Vzc29yIDQ1LzB4MmIgaWdub3JlZC4KWyAgICA3LjczOTMwOV0gQUNQSTogVW5hYmxlIHRv IG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljc0NDY2MF0gQVBJQzogTlJf Q1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQ2LzB4MmQg aWdub3JlZC4KWyAgICA3Ljc1MjMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dp Y2FsIGNwdSBudW1iZXIKWyAgICA3Ljc1ODY1OV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVz IGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQ3LzB4MmYgaWdub3JlZC4KWyAgICA3Ljc2 NjMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAg ICA3Ljc3NTM2NV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hl ZC4gUHJvY2Vzc29yIDQ4LzB4NDAgaWdub3JlZC4KWyAgICA3Ljc4MjMwNl0gQUNQSTogVW5hYmxl IHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljc4ODY2Ml0gQVBJQzog TlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDQ5LzB4 NDIgaWdub3JlZC4KWyAgICA3Ljc5NjMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBs b2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjgwMjY2Ml0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9j cHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDUwLzB4NDQgaWdub3JlZC4KWyAgICA3 LjgxMDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA3LjgxNTY2MV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDUxLzB4NDYgaWdub3JlZC4KWyAgICA3LjgyMzMwN10gQUNQSTogVW5h YmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjgyOTY1OF0gQVBJ QzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDUy LzB4NDggaWdub3JlZC4KWyAgICA3LjgzNzMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0 byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljg0MzY2M10gQVBJQzogTlJfQ1BVUy9wb3NzaWJs ZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDUzLzB4NGEgaWdub3JlZC4KWyAg ICA3Ljg1MTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1i ZXIKWyAgICA3Ljg1NjY3MF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDgg cmVhY2hlZC4gUHJvY2Vzc29yIDU0LzB4NGMgaWdub3JlZC4KWyAgICA3Ljg2NDMwN10gQUNQSTog VW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljg3MDY2MV0g QVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29y IDU1LzB4NGUgaWdub3JlZC4KWyAgICA3Ljg3ODMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBp YyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljg4NDUwOV0gQVBJQzogTlJfQ1BVUy9wb3Nz aWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDU2LzB4NTAgaWdub3JlZC4K WyAgICA3Ljg5MjMwOV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBu dW1iZXIKWyAgICA3Ljg5NzczN10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9m IDggcmVhY2hlZC4gUHJvY2Vzc29yIDU3LzB4NTIgaWdub3JlZC4KWyAgICA3LjkwNjMxMV0gQUNQ STogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjkxMTcz MV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vz c29yIDU4LzB4NTQgaWdub3JlZC4KWyAgICA3LjkxOTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBs YXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3LjkyNTcyNl0gQVBJQzogTlJfQ1BVUy9w b3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDU5LzB4NTYgaWdub3Jl ZC4KWyAgICA3LjkzMzMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNw dSBudW1iZXIKWyAgICA3LjkzOTcyNl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0 IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDYwLzB4NTggaWdub3JlZC4KWyAgICA3Ljk0NzMwNV0g QUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljk1 MjcyM10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJv Y2Vzc29yIDYxLzB4NWEgaWdub3JlZC4KWyAgICA3Ljk2MTMwNV0gQUNQSTogVW5hYmxlIHRvIG1h cCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3Ljk2NjcyM10gQVBJQzogTlJfQ1BV Uy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDYyLzB4NWMgaWdu b3JlZC4KWyAgICA3Ljk3NDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2Fs IGNwdSBudW1iZXIKWyAgICA3Ljk4MDcyNl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxp bWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDYzLzB4NWUgaWdub3JlZC4KWyAgICA3Ljk4ODMw Nl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA3 Ljk5NDcyMl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4g UHJvY2Vzc29yIDY0LzB4NjAgaWdub3JlZC4KWyAgICA4LjAwMjMwNl0gQUNQSTogVW5hYmxlIHRv IG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjAwNzcyNl0gQVBJQzogTlJf Q1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDY1LzB4NjIg aWdub3JlZC4KWyAgICA4LjAxNTMwOF0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dp Y2FsIGNwdSBudW1iZXIKWyAgICA4LjAyMTcyN10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVz IGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDY2LzB4NjQgaWdub3JlZC4KWyAgICA4LjAy OTMxMV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAg ICA4LjAzNTcyNV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hl ZC4gUHJvY2Vzc29yIDY3LzB4NjYgaWdub3JlZC4KWyAgICA4LjA0MzMxMV0gQUNQSTogVW5hYmxl IHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjA0ODcyNl0gQVBJQzog TlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDY4LzB4 NjggaWdub3JlZC4KWyAgICA4LjA1NzMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBs b2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjA2MjcyNV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9j cHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDY5LzB4NmEgaWdub3JlZC4KWyAgICA4 LjA3MDMwNV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA4LjA3NjcyMl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDcwLzB4NmMgaWdub3JlZC4KWyAgICA4LjA4NDMwNl0gQUNQSTogVW5h YmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjA5MDcyNF0gQVBJ QzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDcx LzB4NmUgaWdub3JlZC4KWyAgICA4LjA5ODMwN10gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0 byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjEwMzcyNl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJs ZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDcyLzB4NDEgaWdub3JlZC4KWyAg ICA4LjExMTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1i ZXIKWyAgICA4LjExNzcyM10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDgg cmVhY2hlZC4gUHJvY2Vzc29yIDczLzB4NDMgaWdub3JlZC4KWyAgICA4LjEyNTMwNl0gQUNQSTog VW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjEzMTcyNF0g QVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29y IDc0LzB4NDUgaWdub3JlZC4KWyAgICA4LjEzOTMwNV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBp YyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjE0NTczOV0gQVBJQzogTlJfQ1BVUy9wb3Nz aWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDc1LzB4NDcgaWdub3JlZC4K WyAgICA4LjE1MzMxMl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBu dW1iZXIKWyAgICA4LjE1ODcyNl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9m IDggcmVhY2hlZC4gUHJvY2Vzc29yIDc2LzB4NDkgaWdub3JlZC4KWyAgICA4LjE2NjMxMV0gQUNQ STogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjE3Mjcy OV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vz c29yIDc3LzB4NGIgaWdub3JlZC4KWyAgICA4LjE4MDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBs YXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjE4NjcyM10gQVBJQzogTlJfQ1BVUy9w b3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDc4LzB4NGQgaWdub3Jl ZC4KWyAgICA4LjE5NDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNw dSBudW1iZXIKWyAgICA4LjE5OTcyNF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0 IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDc5LzB4NGYgaWdub3JlZC4KWyAgICA4LjIwODMwNl0g QUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjIx MzcyM10gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJv Y2Vzc29yIDgwLzB4NTEgaWdub3JlZC4KWyAgICA4LjIyMTMwNl0gQUNQSTogVW5hYmxlIHRvIG1h cCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjIyNzcyNl0gQVBJQzogTlJfQ1BV Uy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDgxLzB4NTMgaWdu b3JlZC4KWyAgICA4LjIzNTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2Fs IGNwdSBudW1iZXIKWyAgICA4LjI0MTcyNF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxp bWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDgyLzB4NTUgaWdub3JlZC4KWyAgICA4LjI0OTMw Nl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4 LjI1NDcyNF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4g UHJvY2Vzc29yIDgzLzB4NTcgaWdub3JlZC4KWyAgICA4LjI2MjMwNl0gQUNQSTogVW5hYmxlIHRv IG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjI2ODcyNF0gQVBJQzogTlJf Q1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDg0LzB4NTkg aWdub3JlZC4KWyAgICA4LjI3NjMwOF0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dp Y2FsIGNwdSBudW1iZXIKWyAgICA4LjI4MjcyNF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVz IGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDg1LzB4NWIgaWdub3JlZC4KWyAgICA4LjI5 MDMxMV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAg ICA4LjI5NjcyMl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hl ZC4gUHJvY2Vzc29yIDg2LzB4NWQgaWdub3JlZC4KWyAgICA4LjMwNDMxMV0gQUNQSTogVW5hYmxl IHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjMwOTcyNF0gQVBJQzog TlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDg3LzB4 NWYgaWdub3JlZC4KWyAgICA4LjMxNzMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBs b2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjMyMzczMV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9j cHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDg4LzB4NjEgaWdub3JlZC4KWyAgICA4 LjMzMTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIK WyAgICA4LjMzNzcyMl0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVh Y2hlZC4gUHJvY2Vzc29yIDg5LzB4NjMgaWdub3JlZC4KWyAgICA4LjM0NTMwNl0gQUNQSTogVW5h YmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjM1MDcyN10gQVBJ QzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDkw LzB4NjUgaWdub3JlZC4KWyAgICA4LjM1OTMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0 byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjM2NDcyNV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJs ZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDkxLzB4NjcgaWdub3JlZC4KWyAg ICA4LjM3MjMwNV0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1i ZXIKWyAgICA4LjM3ODcyOF0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDgg cmVhY2hlZC4gUHJvY2Vzc29yIDkyLzB4NjkgaWdub3JlZC4KWyAgICA4LjM4NjMwNl0gQUNQSTog VW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjM5MjcyM10g QVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29y IDkzLzB4NmIgaWdub3JlZC4KWyAgICA4LjQwMDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBp YyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjQwNTcyNV0gQVBJQzogTlJfQ1BVUy9wb3Nz aWJsZV9jcHVzIGxpbWl0IG9mIDggcmVhY2hlZC4gUHJvY2Vzc29yIDk0LzB4NmQgaWdub3JlZC4K WyAgICA4LjQxNDMwNl0gQUNQSTogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBu dW1iZXIKWyAgICA4LjQxOTcxOV0gQVBJQzogTlJfQ1BVUy9wb3NzaWJsZV9jcHVzIGxpbWl0IG9m IDggcmVhY2hlZC4gUHJvY2Vzc29yIDk1LzB4NmYgaWdub3JlZC4KWyAgICA4LjQyNzMxMF0gQUNQ STogVW5hYmxlIHRvIG1hcCBsYXBpYyB0byBsb2dpY2FsIGNwdSBudW1iZXIKWyAgICA4LjQzNzIx MV0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQzAwXSAoZG9tYWluIDAwMDAgW2J1cyAwMC0xNV0p ClsgICAgOC40NDMzMTFdIGFjcGkgUE5QMEEwODowMDogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVu ZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgIDguNTA4 ODAxXSBhY3BpIFBOUDBBMDg6MDA6IF9PU0M6IHBsYXRmb3JtIGRvZXMgbm90IHN1cHBvcnQgW0FF UiBMVFJdClsgICAgOC41MTU4MjBdIGFjcGkgUE5QMEEwODowMDogX09TQzogT1Mgbm93IGNvbnRy b2xzIFtQQ0llSG90cGx1ZyBQTUUgUENJZUNhcGFiaWxpdHldClsgICAgOC41MjYyODhdIFBDSSBo b3N0IGJyaWRnZSB0byBidXMgMDAwMDowMApbICAgIDguNTMwMzA2XSBwY2lfYnVzIDAwMDA6MDA6 IHJvb3QgYnVzIHJlc291cmNlIFtpbyAgMHgwMDAwLTB4MGNmNyB3aW5kb3ddClsgICAgOC41Mzcz MDldIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2lvICAweDEwMDAtMHg0ZmZm IHdpbmRvd10KWyAgICA4LjU0MzMxMl0gcGNpX2J1cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJj ZSBbbWVtIDB4MDAwYTAwMDAtMHgwMDBiZmZmZiB3aW5kb3ddClsgICAgOC41NTAzMDddIHBjaV9i dXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweDAwMGM4MDAwLTB4MDAwY2ZmZmYg d2luZG93XQpbICAgIDguNTU4MzA1XSBwY2lfYnVzIDAwMDA6MDA6IHJvb3QgYnVzIHJlc291cmNl IFttZW0gMHhmZTAxMDAwMC0weGZlMDEwZmZmIHdpbmRvd10KWyAgICA4LjU2NTMwNV0gcGNpX2J1 cyAwMDAwOjAwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4OTAwMDAwMDAtMHg5YjdmZmZmZiB3 aW5kb3ddClsgICAgOC41NzMzMDZdIHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2Ug W21lbSAweDIwMDAwMDAwMDAwMC0weDIwMGZmZmZmZmZmZiB3aW5kb3ddClsgICAgOC41ODEzMDZd IHBjaV9idXMgMDAwMDowMDogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyAwMC0xNV0KWyAgICA4LjU4 NzM1Ml0gcGNpIDAwMDA6MDA6MDAuMDogWzgwODY6MDlhMl0gdHlwZSAwMCBjbGFzcyAweDA4ODAw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAwLjAKWyAgICA4LjU5NjM0MF0gcGNpIDAw MDA6MDA6MDAuMTogWzgwODY6MDlhNF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjAwOjAwLjEKWyAgICA4LjYwNTMzOV0gcGNpIDAwMDA6MDA6MDAuMjog WzgwODY6MDlhM10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjAwOjAwLjIKWyAgICA4LjYxNDM0N10gcGNpIDAwMDA6MDA6MDAuNDogWzgwODY6MDk5OF0g dHlwZSAwMCBjbGFzcyAweDA2MDAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAwLjQK WyAgICA4LjYyMzM1NF0gcGNpIDAwMDA6MDA6MDEuMDogWzgwODY6MGIwMF0gdHlwZSAwMCBjbGFz cyAweDA4ODAwMApbICAgIDguNjI5MzU0XSBwY2kgMDAwMDowMDowMS4wOiByZWcgMHgxMDogW21l bSAweDIwMGZmZmY1MDAwMC0weDIwMGZmZmY1M2ZmZiA2NGJpdF0KKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDowMDowMS4wClsgICAgOC42NDAzMzhdIHBjaSAwMDAwOjAwOjAxLjE6IFs4MDg2OjBi MDBdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKWyAgICA4LjY0NjM1N10gcGNpIDAwMDA6MDA6MDEu MTogcmVnIDB4MTA6IFttZW0gMHgyMDBmZmZmNGMwMDAtMHgyMDBmZmZmNGZmZmYgNjRiaXRdCihY RU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MDEuMQpbICAgIDguNjU2MzQzXSBwY2kgMDAwMDow MDowMS4yOiBbODA4NjowYjAwXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAgOC42NjIzNjRd IHBjaSAwMDAwOjAwOjAxLjI6IHJlZyAweDEwOiBbbWVtIDB4MjAwZmZmZjQ4MDAwLTB4MjAwZmZm ZjRiZmZmIDY0Yml0XQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAxLjIKWyAgICA4LjY3 MzMzOF0gcGNpIDAwMDA6MDA6MDEuMzogWzgwODY6MGIwMF0gdHlwZSAwMCBjbGFzcyAweDA4ODAw MApbICAgIDguNjc5MzUzXSBwY2kgMDAwMDowMDowMS4zOiByZWcgMHgxMDogW21lbSAweDIwMGZm ZmY0NDAwMC0weDIwMGZmZmY0N2ZmZiA2NGJpdF0KKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDow MDowMS4zClsgICAgOC42OTAzNDhdIHBjaSAwMDAwOjAwOjAxLjQ6IFs4MDg2OjBiMDBdIHR5cGUg MDAgY2xhc3MgMHgwODgwMDAKWyAgICA4LjY5NjM1N10gcGNpIDAwMDA6MDA6MDEuNDogcmVnIDB4 MTA6IFttZW0gMHgyMDBmZmZmNDAwMDAtMHgyMDBmZmZmNDNmZmYgNjRiaXRdCihYRU4pIFBDSSBh ZGQgZGV2aWNlIDAwMDA6MDA6MDEuNApbICAgIDguNzA2MzM5XSBwY2kgMDAwMDowMDowMS41OiBb ODA4NjowYjAwXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAgOC43MTIzNTNdIHBjaSAwMDAw OjAwOjAxLjU6IHJlZyAweDEwOiBbbWVtIDB4MjAwZmZmZjNjMDAwLTB4MjAwZmZmZjNmZmZmIDY0 Yml0XQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjAxLjUKWyAgICA4LjcyMzMzOF0gcGNp IDAwMDA6MDA6MDEuNjogWzgwODY6MGIwMF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMApbICAgIDgu NzI5MzUzXSBwY2kgMDAwMDowMDowMS42OiByZWcgMHgxMDogW21lbSAweDIwMGZmZmYzODAwMC0w eDIwMGZmZmYzYmZmZiA2NGJpdF0KKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDowMS42Clsg ICAgOC43MzkzMzddIHBjaSAwMDAwOjAwOjAxLjc6IFs4MDg2OjBiMDBdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKWyAgICA4Ljc0NTM1M10gcGNpIDAwMDA6MDA6MDEuNzogcmVnIDB4MTA6IFttZW0g MHgyMDBmZmZmMzQwMDAtMHgyMDBmZmZmMzdmZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6MDA6MDEuNwpbICAgIDguNzU2MzMxXSBwY2kgMDAwMDowMDowMi4wOiBbODA4NjowOWE2 XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAgOC43NjIzNDRdIHBjaSAwMDAwOjAwOjAyLjA6 IHJlZyAweDEwOiBbbWVtIDB4OTI0ODgwMDAtMHg5MjQ4OWZmZl0KKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDowMDowMi4wClsgICAgOC43NzEzMzBdIHBjaSAwMDAwOjAwOjAyLjE6IFs4MDg2OjA5 YTddIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKWyAgICA4Ljc3NzM0NF0gcGNpIDAwMDA6MDA6MDIu MTogcmVnIDB4MTA6IFttZW0gMHg5MjQwMDAwMC0weDkyNDdmZmZmXQpbICAgIDguNzg0MzI3XSBw Y2kgMDAwMDowMDowMi4xOiByZWcgMHgxNDogW21lbSAweDkyMzgwMDAwLTB4OTIzZmZmZmZdCihY RU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MDIuMQpbICAgIDguNzkzMzM4XSBwY2kgMDAwMDow MDowMi4yOiBbODA4NjowOWE4XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAgOC43OTkzNDVd IHBjaSAwMDAwOjAwOjAyLjI6IHJlZyAweDEwOiBbbWVtIDB4OTIzMDAwMDAtMHg5MjM3ZmZmZl0K KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDowMi4yClsgICAgOC44MDgzNDZdIHBjaSAwMDAw OjAwOjAyLjQ6IFs4MDg2OjM0NTZdIHR5cGUgMDAgY2xhc3MgMHgxMzAwMDAKWyAgICA4LjgxNDM1 N10gcGNpIDAwMDA6MDA6MDIuNDogcmVnIDB4MTA6IFttZW0gMHgyMDBmZmZlMDAwMDAtMHgyMDBm ZmZlZmZmZmYgNjRiaXRdClsgICAgOC44MjIzMzVdIHBjaSAwMDAwOjAwOjAyLjQ6IHJlZyAweDE4 OiBbbWVtIDB4MjAwZmZmZjMwMDAwLTB4MjAwZmZmZjMzZmZmIDY0Yml0XQpbICAgIDguODI5MzM1 XSBwY2kgMDAwMDowMDowMi40OiByZWcgMHgyMDogW21lbSAweDIwMGZmZmYwMDAwMC0weDIwMGZm ZmYxZmZmZiA2NGJpdF0KKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDowMi40ClsgICAgOC44 NDA0NDFdIHBjaSAwMDAwOjAwOjExLjA6IFs4MDg2OmExZWNdIHR5cGUgMDAgY2xhc3MgMHhmZjAw MDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxMS4wClsgICAgOC44NDkzNTJdIHBjaSAw MDAwOjAwOjExLjE6IFs4MDg2OmExZWRdIHR5cGUgMDAgY2xhc3MgMHhmZjAwMDAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDowMDoxMS4xClsgICAgOC44NTgzNzddIHBjaSAwMDAwOjAwOjExLjU6 IFs4MDg2OmExZDJdIHR5cGUgMDAgY2xhc3MgMHgwMTA2MDEKWyAgICA4Ljg2NDM1N10gcGNpIDAw MDA6MDA6MTEuNTogcmVnIDB4MTA6IFttZW0gMHg5MjQ4NjAwMC0weDkyNDg3ZmZmXQpbICAgIDgu ODcxMzM1XSBwY2kgMDAwMDowMDoxMS41OiByZWcgMHgxNDogW21lbSAweDkyNDhjMDAwLTB4OTI0 OGMwZmZdClsgICAgOC44NzczMzFdIHBjaSAwMDAwOjAwOjExLjU6IHJlZyAweDE4OiBbaW8gIDB4 NDA2OC0weDQwNmZdClsgICAgOC44ODIzMzRdIHBjaSAwMDAwOjAwOjExLjU6IHJlZyAweDFjOiBb aW8gIDB4NDA3NC0weDQwNzddClsgICAgOC44ODgzMzVdIHBjaSAwMDAwOjAwOjExLjU6IHJlZyAw eDIwOiBbaW8gIDB4NDA0MC0weDQwNWZdClsgICAgOC44OTQzMzRdIHBjaSAwMDAwOjAwOjExLjU6 IHJlZyAweDI0OiBbbWVtIDB4OTIyODAwMDAtMHg5MjJmZmZmZl0KWyAgICA4LjkwMDQ2MF0gcGNp IDAwMDA6MDA6MTEuNTogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEM2hvdAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjAwOjExLjUKWyAgICA4LjkwODM3NV0gcGNpIDAwMDA6MDA6MTQuMDogWzgwODY6 YTFhZl0gdHlwZSAwMCBjbGFzcyAweDBjMDMzMApbICAgIDguOTE0MzY2XSBwY2kgMDAwMDowMDox NC4wOiByZWcgMHgxMDogW21lbSAweDIwMGZmZmYyMDAwMC0weDIwMGZmZmYyZmZmZiA2NGJpdF0K WyAgICA4LjkyMjU0Ml0gcGNpIDAwMDA6MDA6MTQuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBEM2hv dCBEM2NvbGQKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxNC4wClsgICAgOC45MzEzNjNd IHBjaSAwMDAwOjAwOjE0LjI6IFs4MDg2OmExYjFdIHR5cGUgMDAgY2xhc3MgMHgxMTgwMDAKWyAg ICA4LjkzNzM3MF0gcGNpIDAwMDA6MDA6MTQuMjogcmVnIDB4MTA6IFttZW0gMHgyMDBmZmZmNTgw MDAtMHgyMDBmZmZmNThmZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTQu MgpbICAgIDguOTQ4Mzg2XSBwY2kgMDAwMDowMDoxNi4wOiBbODA4NjphMWJhXSB0eXBlIDAwIGNs YXNzIDB4MDc4MDAwClsgICAgOC45NTQzNzVdIHBjaSAwMDAwOjAwOjE2LjA6IHJlZyAweDEwOiBb bWVtIDB4MjAwZmZmZjU3MDAwLTB4MjAwZmZmZjU3ZmZmIDY0Yml0XQpbICAgIDguOTYxNTY3XSBw Y2kgMDAwMDowMDoxNi4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQzaG90CihYRU4pIFBDSSBhZGQg ZGV2aWNlIDAwMDA6MDA6MTYuMApbICAgIDguOTY5MzYwXSBwY2kgMDAwMDowMDoxNi4xOiBbODA4 NjphMWJiXSB0eXBlIDAwIGNsYXNzIDB4MDc4MDAwClsgICAgOC45NzUzNzFdIHBjaSAwMDAwOjAw OjE2LjE6IHJlZyAweDEwOiBbbWVtIDB4MjAwZmZmZjU2MDAwLTB4MjAwZmZmZjU2ZmZmIDY0Yml0 XQpbICAgIDguOTgzNTYyXSBwY2kgMDAwMDowMDoxNi4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQz aG90CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTYuMQpbICAgIDguOTkxMzY3XSBwY2kg MDAwMDowMDoxNi40OiBbODA4NjphMWJlXSB0eXBlIDAwIGNsYXNzIDB4MDc4MDAwClsgICAgOC45 OTczNzVdIHBjaSAwMDAwOjAwOjE2LjQ6IHJlZyAweDEwOiBbbWVtIDB4MjAwZmZmZjU1MDAwLTB4 MjAwZmZmZjU1ZmZmIDY0Yml0XQpbICAgIDkuMDA1NTYzXSBwY2kgMDAwMDowMDoxNi40OiBQTUUj IHN1cHBvcnRlZCBmcm9tIEQzaG90CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MDA6MTYuNApb ICAgIDkuMDEzMzc0XSBwY2kgMDAwMDowMDoxNy4wOiBbODA4NjphMTgyXSB0eXBlIDAwIGNsYXNz IDB4MDEwNjAxClsgICAgOS4wMTkzNTZdIHBjaSAwMDAwOjAwOjE3LjA6IHJlZyAweDEwOiBbbWVt IDB4OTI0ODQwMDAtMHg5MjQ4NWZmZl0KWyAgICA5LjAyNTMzM10gcGNpIDAwMDA6MDA6MTcuMDog cmVnIDB4MTQ6IFttZW0gMHg5MjQ4YjAwMC0weDkyNDhiMGZmXQpbICAgIDkuMDMyMzMzXSBwY2kg MDAwMDowMDoxNy4wOiByZWcgMHgxODogW2lvICAweDQwNjAtMHg0MDY3XQpbICAgIDkuMDM3MzM0 XSBwY2kgMDAwMDowMDoxNy4wOiByZWcgMHgxYzogW2lvICAweDQwNzAtMHg0MDczXQpbICAgIDku MDQzMzMzXSBwY2kgMDAwMDowMDoxNy4wOiByZWcgMHgyMDogW2lvICAweDQwMjAtMHg0MDNmXQpb ICAgIDkuMDQ4MzI5XSBwY2kgMDAwMDowMDoxNy4wOiByZWcgMHgyNDogW21lbSAweDkyMjAwMDAw LTB4OTIyN2ZmZmZdClsgICAgOS4wNTU0NTRdIHBjaSAwMDAwOjAwOjE3LjA6IFBNRSMgc3VwcG9y dGVkIGZyb20gRDNob3QKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxNy4wClsgICAgOS4w NjMzNjldIHBjaSAwMDAwOjAwOjFjLjA6IFs4MDg2OmExOTRdIHR5cGUgMDEgY2xhc3MgMHgwNjA0 MDAKWyAgICA5LjA2OTU5OF0gcGNpIDAwMDA6MDA6MWMuMDogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE MCBEM2hvdCBEM2NvbGQKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxYy4wClsgICAgOS4w NzkzNjhdIHBjaSAwMDAwOjAwOjFjLjU6IFs4MDg2OmExOTVdIHR5cGUgMDEgY2xhc3MgMHgwNjA0 MDAKWyAgICA5LjA4NTU5OV0gcGNpIDAwMDA6MDA6MWMuNTogUE1FIyBzdXBwb3J0ZWQgZnJvbSBE MCBEM2hvdCBEM2NvbGQKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxYy41ClsgICAgOS4w OTUzNTRdIHBjaSAwMDAwOjAwOjFmLjA6IFs4MDg2OmExY2JdIHR5cGUgMDAgY2xhc3MgMHgwNjAx MDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDoxZi4wClsgICAgOS4xMDQzNDFdIHBjaSAw MDAwOjAwOjFmLjI6IFs4MDg2OmExYTFdIHR5cGUgMDAgY2xhc3MgMHgwNTgwMDAKWyAgICA5LjEx MDM0N10gcGNpIDAwMDA6MDA6MWYuMjogcmVnIDB4MTA6IFttZW0gMHg5MjQ4MDAwMC0weDkyNDgz ZmZmXQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAwOjFmLjIKWyAgICA5LjExOTMzN10gcGNp IDAwMDA6MDA6MWYuNDogWzgwODY6YTFhM10gdHlwZSAwMCBjbGFzcyAweDBjMDUwMApbICAgIDku MTI2MzY0XSBwY2kgMDAwMDowMDoxZi40OiByZWcgMHgxMDogW21lbSAweDIwMGZmZmY1NDAwMC0w eDIwMGZmZmY1NDBmZiA2NGJpdF0KWyAgICA5LjEzMzM2NF0gcGNpIDAwMDA6MDA6MWYuNDogcmVn IDB4MjA6IFtpbyAgMHg0MDAwLTB4NDAxZl0KKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDowMDox Zi40ClsgICAgOS4xNDIzMzVdIHBjaSAwMDAwOjAwOjFmLjU6IFs4MDg2OmExYTRdIHR5cGUgMDAg Y2xhc3MgMHgwYzgwMDAKWyAgICA5LjE0ODM0OF0gcGNpIDAwMDA6MDA6MWYuNTogcmVnIDB4MTA6 IFttZW0gMHhmZTAxMDAwMC0weGZlMDEwZmZmXQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAw OjFmLjUKWyAgICA5LjE1NzY2OF0gcGNpIDAwMDA6MDE6MDAuMDogd29ya2luZyBhcm91bmQgUk9N IEJBUiBvdmVybGFwIGRlZmVjdApbICAgIDkuMTYzMzA1XSBwY2kgMDAwMDowMTowMC4wOiBbODA4 NjoxNTMzXSB0eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgOS4xNjk0MThdIHBjaSAwMDAwOjAx OjAwLjA6IHJlZyAweDEwOiBbbWVtIDB4OTIxMDAwMDAtMHg5MjE3ZmZmZl0KWyAgICA5LjE3NjQx Ml0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4MTg6IFtpbyAgMHgzMDAwLTB4MzAxZl0KWyAgICA5 LjE4MTM4OF0gcGNpIDAwMDA6MDE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHg5MjE4MDAwMC0weDky MTgzZmZmXQpbICAgIDkuMTg5MDMxXSBwY2kgMDAwMDowMTowMC4wOiBQTUUjIHN1cHBvcnRlZCBm cm9tIEQwIEQzaG90IEQzY29sZAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAxOjAwLjAKWyAg ICA5LjE5NjQ2NF0gcGNpIDAwMDA6MDA6MWMuMDogUENJIGJyaWRnZSB0byBbYnVzIDAxXQpbICAg IDkuMTk3MzE3XSBwY2kgMDAwMDowMDoxYy4wOiAgIGJyaWRnZSB3aW5kb3cgW2lvICAweDMwMDAt MHgzZmZmXQpbICAgIDkuMTk4MzE2XSBwY2kgMDAwMDowMDoxYy4wOiAgIGJyaWRnZSB3aW5kb3cg W21lbSAweDkyMTAwMDAwLTB4OTIxZmZmZmZdClsgICAgOS4xOTk1MDJdIHBjaSAwMDAwOjAyOjAw LjA6IFsxYTAzOjExNTBdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgICA5LjIwMDUxN10gcGNp IDAwMDA6MDI6MDAuMDogZW5hYmxpbmcgRXh0ZW5kZWQgVGFncwpbICAgIDkuMjAxNTMwXSBwY2kg MDAwMDowMjowMC4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDkuMjAyMzA1XSBwY2kgMDAwMDowMjow MC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQzaG90IEQzY29sZAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjAyOjAwLjAKWyAgICA5LjIwNDM4MF0gcGNpIDAwMDA6MDA6MWMuNTog UENJIGJyaWRnZSB0byBbYnVzIDAyLTAzXQpbICAgIDkuMjA1MzE2XSBwY2kgMDAwMDowMDoxYy41 OiAgIGJyaWRnZSB3aW5kb3cgW2lvICAweDIwMDAtMHgyZmZmXQpbICAgIDkuMjA2MzE1XSBwY2kg MDAwMDowMDoxYy41OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDkxMDAwMDAwLTB4OTIwZmZmZmZd ClsgICAgOS4yMDc0NjBdIHBjaV9idXMgMDAwMDowMzogZXh0ZW5kZWQgY29uZmlnIHNwYWNlIG5v dCBhY2Nlc3NpYmxlClsgICAgOS4yMDgzNTJdIHBjaSAwMDAwOjAzOjAwLjA6IFsxYTAzOjIwMDBd IHR5cGUgMDAgY2xhc3MgMHgwMzAwMDAKWyAgICA5LjIwOTM3Ml0gcGNpIDAwMDA6MDM6MDAuMDog cmVnIDB4MTA6IFttZW0gMHg5MTAwMDAwMC0weDkxZmZmZmZmXQpbICAgIDkuMjEwMzQ1XSBwY2kg MDAwMDowMzowMC4wOiByZWcgMHgxNDogW21lbSAweDkyMDAwMDAwLTB4OTIwMWZmZmZdClsgICAg OS4yMTEzNDRdIHBjaSAwMDAwOjAzOjAwLjA6IHJlZyAweDE4OiBbaW8gIDB4MjAwMC0weDIwN2Zd ClsgICAgOS4yMTI0NjVdIHBjaSAwMDAwOjAzOjAwLjA6IEJBUiAwOiBhc3NpZ25lZCB0byBlZmlm YgpbICAgIDkuMjEzNDMyXSBwY2kgMDAwMDowMzowMC4wOiBzdXBwb3J0cyBEMSBEMgpbICAgIDku MjE0MzA0XSBwY2kgMDAwMDowMzowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQxIEQyIEQz aG90IEQzY29sZAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjAzOjAwLjAKWyAgICA5LjIxNjQ1 OF0gcGNpIDAwMDA6MDI6MDAuMDogUENJIGJyaWRnZSB0byBbYnVzIDAzXQpbICAgIDkuMjE3MzMw XSBwY2kgMDAwMDowMjowMC4wOiAgIGJyaWRnZSB3aW5kb3cgW2lvICAweDIwMDAtMHgyZmZmXQpb ICAgIDkuMjE4MzIwXSBwY2kgMDAwMDowMjowMC4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDkx MDAwMDAwLTB4OTIwZmZmZmZdClsgICAgOS4yMjAwNDZdIEFDUEk6IFBDSSBSb290IEJyaWRnZSBb UEMwMV0gKGRvbWFpbiAwMDAwIFtidXMgMTYtMmZdKQpbICAgIDkuMjIwMzA3XSBhY3BpIFBOUDBB MDg6MDE6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2Vn bWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA5LjIzMzgzMF0gYWNwaSBQTlAwQTA4OjAxOiBfT1ND OiBwbGF0Zm9ybSBkb2VzIG5vdCBzdXBwb3J0IFtBRVJdClsgICAgOS4yMzQ4MjJdIGFjcGkgUE5Q MEEwODowMTogX09TQzogT1Mgbm93IGNvbnRyb2xzIFtQQ0llSG90cGx1ZyBQTUUgUENJZUNhcGFi aWxpdHkgTFRSXQpbICAgIDkuMjM1NDMwXSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDA6MTYK WyAgICA5LjIzNjMwNV0gcGNpX2J1cyAwMDAwOjE2OiByb290IGJ1cyByZXNvdXJjZSBbaW8gIDB4 NTAwMC0weDZmZmYgd2luZG93XQpbICAgIDkuMjM3MzA0XSBwY2lfYnVzIDAwMDA6MTY6IHJvb3Qg YnVzIHJlc291cmNlIFttZW0gMHg5YjgwMDAwMC0weGE2M2ZmZmZmIHdpbmRvd10KWyAgICA5LjIz ODMwNV0gcGNpX2J1cyAwMDAwOjE2OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MjAxMDAwMDAw MDAwLTB4MjAxZmZmZmZmZmZmIHdpbmRvd10KWyAgICA5LjIzOTMwNV0gcGNpX2J1cyAwMDAwOjE2 OiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDE2LTJmXQpbICAgIDkuMjQwMzM5XSBwY2kgMDAwMDox NjowMC4wOiBbODA4NjowOWEyXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQg ZGV2aWNlIDAwMDA6MTY6MDAuMApbICAgIDkuMjQyMzM3XSBwY2kgMDAwMDoxNjowMC4xOiBbODA4 NjowOWE0XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6 MTY6MDAuMQpbICAgIDkuMjQ0MzM3XSBwY2kgMDAwMDoxNjowMC4yOiBbODA4NjowOWEzXSB0eXBl IDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MTY6MDAuMgpbICAg IDkuMjQ2MzQwXSBwY2kgMDAwMDoxNjowMC40OiBbODA4NjowOTk4XSB0eXBlIDAwIGNsYXNzIDB4 MDYwMDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MTY6MDAuNApbICAgIDkuMjQ4MzU0XSBw Y2kgMDAwMDoxNjowMi4wOiBbODA4NjozNDdhXSB0eXBlIDAxIGNsYXNzIDB4MDYwNDAwClsgICAg OS4yNDkzNThdIHBjaSAwMDAwOjE2OjAyLjA6IHJlZyAweDEwOiBbbWVtIDB4MjAxZmZmZDAwMDAw LTB4MjAxZmZmZDFmZmZmIDY0Yml0XQpbICAgIDkuMjUwMzc2XSBwY2kgMDAwMDoxNjowMi4wOiBl bmFibGluZyBFeHRlbmRlZCBUYWdzClsgICAgOS4yNTE0MzldIHBjaSAwMDAwOjE2OjAyLjA6IFBN RSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6MTY6MDIuMApbICAgIDkuMjUzNzM3XSBwY2kgMDAwMDoxNzowMC4wOiBbODA4NjoxNTYzXSB0 eXBlIDAwIGNsYXNzIDB4MDIwMDAwClsgICAgOS4yNTQzNjJdIHBjaSAwMDAwOjE3OjAwLjA6IHJl ZyAweDEwOiBbbWVtIDB4MjAxZmZmODAwMDAwLTB4MjAxZmZmYmZmZmZmIDY0Yml0IHByZWZdClsg ICAgOS4yNTUzNzVdIHBjaSAwMDAwOjE3OjAwLjA6IHJlZyAweDIwOiBbbWVtIDB4MjAxZmZmYzA0 MDAwLTB4MjAxZmZmYzA3ZmZmIDY0Yml0IHByZWZdClsgICAgOS4yNTYzMjddIHBjaSAwMDAwOjE3 OjAwLjA6IHJlZyAweDMwOiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgIDku MjU3NTE4XSBwY2kgMDAwMDoxNzowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90Clsg ICAgOS4yNTgzOTJdIHBjaSAwMDAwOjE3OjAwLjA6IHJlZyAweDE4NDogW21lbSAweDliODAwMDAw LTB4OWI4MDNmZmYgNjRiaXRdClsgICAgOS4yNTkzMDVdIHBjaSAwMDAwOjE3OjAwLjA6IFZGKG4p IEJBUjAgc3BhY2U6IFttZW0gMHg5YjgwMDAwMC0weDliOGZmZmZmIDY0Yml0XSAoY29udGFpbnMg QkFSMCBmb3IgNjQgVkZzKQpbICAgIDkuMjYwMzMzXSBwY2kgMDAwMDoxNzowMC4wOiByZWcgMHgx OTA6IFttZW0gMHg5YjkwMDAwMC0weDliOTAzZmZmIDY0Yml0XQpbICAgIDkuMjYxMzA1XSBwY2kg MDAwMDoxNzowMC4wOiBWRihuKSBCQVIzIHNwYWNlOiBbbWVtIDB4OWI5MDAwMDAtMHg5YjlmZmZm ZiA2NGJpdF0gKGNvbnRhaW5zIEJBUjMgZm9yIDY0IFZGcykKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDoxNzowMC4wClsgICAgOS4yNjMzNjNdIHBjaSAwMDAwOjE3OjAwLjE6IFs4MDg2OjE1NjNd IHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAKWyAgICA5LjI2NDM2MV0gcGNpIDAwMDA6MTc6MDAuMTog cmVnIDB4MTA6IFttZW0gMHgyMDFmZmY0MDAwMDAtMHgyMDFmZmY3ZmZmZmYgNjRiaXQgcHJlZl0K WyAgICA5LjI2NTM3Nl0gcGNpIDAwMDA6MTc6MDAuMTogcmVnIDB4MjA6IFttZW0gMHgyMDFmZmZj MDAwMDAtMHgyMDFmZmZjMDNmZmYgNjRiaXQgcHJlZl0KWyAgICA5LjI2NjMyN10gcGNpIDAwMDA6 MTc6MDAuMTogcmVnIDB4MzA6IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAg OS4yNjc1MTFdIHBjaSAwMDAwOjE3OjAwLjE6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QK WyAgICA5LjI2ODM3Ml0gcGNpIDAwMDA6MTc6MDAuMTogcmVnIDB4MTg0OiBbbWVtIDB4OWJhMDAw MDAtMHg5YmEwM2ZmZiA2NGJpdF0KWyAgICA5LjI2OTMwNV0gcGNpIDAwMDA6MTc6MDAuMTogVkYo bikgQkFSMCBzcGFjZTogW21lbSAweDliYTAwMDAwLTB4OWJhZmZmZmYgNjRiaXRdIChjb250YWlu cyBCQVIwIGZvciA2NCBWRnMpClsgICAgOS4yNzAzMzNdIHBjaSAwMDAwOjE3OjAwLjE6IHJlZyAw eDE5MDogW21lbSAweDliYjAwMDAwLTB4OWJiMDNmZmYgNjRiaXRdClsgICAgOS4yNzEzMDVdIHBj aSAwMDAwOjE3OjAwLjE6IFZGKG4pIEJBUjMgc3BhY2U6IFttZW0gMHg5YmIwMDAwMC0weDliYmZm ZmZmIDY0Yml0XSAoY29udGFpbnMgQkFSMyBmb3IgNjQgVkZzKQooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjE3OjAwLjEKWyAgICA5LjI3MzQ0M10gcGNpIDAwMDA6MTY6MDIuMDogUENJIGJyaWRn ZSB0byBbYnVzIDE3LTE4XQpbICAgIDkuMjc0MzE3XSBwY2kgMDAwMDoxNjowMi4wOiAgIGJyaWRn ZSB3aW5kb3cgW21lbSAweDliODAwMDAwLTB4OWJiZmZmZmZdClsgICAgOS4yNzUzMTddIHBjaSAw MDAwOjE2OjAyLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjAxZmZmNDAwMDAwLTB4MjAxZmZm Y2ZmZmZmIDY0Yml0IHByZWZdClsgICAgOS4yNzY0MjddIEFDUEk6IFBDSSBSb290IEJyaWRnZSBb UEMwMl0gKGRvbWFpbiAwMDAwIFtidXMgMzAtNDldKQpbICAgIDkuMjc3MzA2XSBhY3BpIFBOUDBB MDg6MDI6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2NrUE0gU2Vn bWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA5LjI5MDY4MF0gYWNwaSBQTlAwQTA4OjAyOiBfT1ND OiBwbGF0Zm9ybSBkb2VzIG5vdCBzdXBwb3J0IFtBRVJdClsgICAgOS4yOTE4MTRdIGFjcGkgUE5Q MEEwODowMjogX09TQzogT1Mgbm93IGNvbnRyb2xzIFtQQ0llSG90cGx1ZyBQTUUgUENJZUNhcGFi aWxpdHkgTFRSXQpbICAgIDkuMjkyNDI5XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAwMDA6MzAK WyAgICA5LjI5MzMwNV0gcGNpX2J1cyAwMDAwOjMwOiByb290IGJ1cyByZXNvdXJjZSBbaW8gIDB4 NzAwMC0weDhmZmYgd2luZG93XQpbICAgIDkuMjk0MzA1XSBwY2lfYnVzIDAwMDA6MzA6IHJvb3Qg YnVzIHJlc291cmNlIFttZW0gMHhhNjQwMDAwMC0weGIwZmZmZmZmIHdpbmRvd10KWyAgICA5LjI5 NTMwNV0gcGNpX2J1cyAwMDAwOjMwOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4MjAyMDAwMDAw MDAwLTB4MjAyZmZmZmZmZmZmIHdpbmRvd10KWyAgICA5LjI5NjMwNV0gcGNpX2J1cyAwMDAwOjMw OiByb290IGJ1cyByZXNvdXJjZSBbYnVzIDMwLTQ5XQpbICAgIDkuMjk3MzM4XSBwY2kgMDAwMDoz MDowMC4wOiBbODA4NjowOWEyXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQg ZGV2aWNlIDAwMDA6MzA6MDAuMApbICAgIDkuMjk5MzM2XSBwY2kgMDAwMDozMDowMC4xOiBbODA4 NjowOWE0XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6 MzA6MDAuMQpbICAgIDkuMzAxMzM2XSBwY2kgMDAwMDozMDowMC4yOiBbODA4NjowOWEzXSB0eXBl IDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MzA6MDAuMgpbICAg IDkuMzAzMzQzXSBwY2kgMDAwMDozMDowMC40OiBbODA4NjowOTk4XSB0eXBlIDAwIGNsYXNzIDB4 MDYwMDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6MzA6MDAuNApbICAgIDkuMzA1NTEzXSBB Q1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDMDRdIChkb21haW4gMDAwMCBbYnVzIDRhLTYzXSkKWyAg ICA5LjMwNjMwNl0gYWNwaSBQTlAwQTA4OjA0OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRD b25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgOS4zMTk2Nzld IGFjcGkgUE5QMEEwODowNDogX09TQzogcGxhdGZvcm0gZG9lcyBub3Qgc3VwcG9ydCBbQUVSXQpb ICAgIDkuMzIwODE0XSBhY3BpIFBOUDBBMDg6MDQ6IF9PU0M6IE9TIG5vdyBjb250cm9scyBbUENJ ZUhvdHBsdWcgUE1FIFBDSWVDYXBhYmlsaXR5IExUUl0KWyAgICA5LjMyMTQyNF0gUENJIGhvc3Qg YnJpZGdlIHRvIGJ1cyAwMDAwOjRhClsgICAgOS4zMjIzMDVdIHBjaV9idXMgMDAwMDo0YTogcm9v dCBidXMgcmVzb3VyY2UgW2lvICAweDkwMDAtMHg5ZmZmIHdpbmRvd10KWyAgICA5LjMyMzMwNV0g cGNpX2J1cyAwMDAwOjRhOiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4YjEwMDAwMDAtMHhiYmJm ZmZmZiB3aW5kb3ddClsgICAgOS4zMjQzMDZdIHBjaV9idXMgMDAwMDo0YTogcm9vdCBidXMgcmVz b3VyY2UgW21lbSAweDIwMzAwMDAwMDAwMC0weDIwM2ZmZmZmZmZmZiB3aW5kb3ddClsgICAgOS4z MjUzMTBdIHBjaV9idXMgMDAwMDo0YTogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyA0YS02M10KWyAg ICA5LjMyNjM0MF0gcGNpIDAwMDA6NGE6MDAuMDogWzgwODY6MDlhMl0gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjRhOjAwLjAKWyAgICA5LjMyODMzNl0g cGNpIDAwMDA6NGE6MDAuMTogWzgwODY6MDlhNF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOjRhOjAwLjEKWyAgICA5LjMzMDMzNl0gcGNpIDAwMDA6NGE6 MDAuMjogWzgwODY6MDlhM10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjRhOjAwLjIKWyAgICA5LjMzMjM0MF0gcGNpIDAwMDA6NGE6MDAuNDogWzgwODY6 MDk5OF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjRh OjAwLjQKWyAgICA5LjMzNDQ5MF0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQzA1XSAoZG9tYWlu IDAwMDAgW2J1cyA2NC03ZF0pClsgICAgOS4zMzUzMDZdIGFjcGkgUE5QMEEwODowNTogX09TQzog T1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kgSFBY LVR5cGUzXQpbICAgIDkuMzQ4NjY1XSBhY3BpIFBOUDBBMDg6MDU6IF9PU0M6IHBsYXRmb3JtIGRv ZXMgbm90IHN1cHBvcnQgW0FFUl0KWyAgICA5LjM0OTczMV0gYWNwaSBQTlAwQTA4OjA1OiBfT1ND OiBPUyBub3cgY29udHJvbHMgW1BDSWVIb3RwbHVnIFBNRSBQQ0llQ2FwYWJpbGl0eSBMVFJdClsg ICAgOS4zNTc0NzRdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwMDo2NApbICAgIDkuMzYxMzA2 XSBwY2lfYnVzIDAwMDA6NjQ6IHJvb3QgYnVzIHJlc291cmNlIFtpbyAgMHhhMDAwLTB4YWZmZiB3 aW5kb3ddClsgICAgOS4zNjgzMDVdIHBjaV9idXMgMDAwMDo2NDogcm9vdCBidXMgcmVzb3VyY2Ug W21lbSAweGJiYzAwMDAwLTB4YzVmZmZmZmYgd2luZG93XQpbICAgIDkuMzc1MzA1XSBwY2lfYnVz IDAwMDA6NjQ6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyMDQwMDAwMDAwMDAtMHgyMDRmZmZm ZmZmZmYgd2luZG93XQpbICAgIDkuMzg0MzA2XSBwY2lfYnVzIDAwMDA6NjQ6IHJvb3QgYnVzIHJl c291cmNlIFtidXMgNjQtN2RdClsgICAgOS4zODkzNDJdIHBjaSAwMDAwOjY0OjAwLjA6IFs4MDg2 OjA5YTJdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo2 NDowMC4wClsgICAgOS4zOTgzNDBdIHBjaSAwMDAwOjY0OjAwLjE6IFs4MDg2OjA5YTRdIHR5cGUg MDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo2NDowMC4xClsgICAg OS40MDczMzhdIHBjaSAwMDAwOjY0OjAwLjI6IFs4MDg2OjA5YTNdIHR5cGUgMDAgY2xhc3MgMHgw ODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo2NDowMC4yClsgICAgOS40MTYzNDFdIHBj aSAwMDAwOjY0OjAwLjQ6IFs4MDg2OjA5OThdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDo2NDowMC40ClsgICAgOS40MjY1MTNdIEFDUEk6IFBDSSBSb290 IEJyaWRnZSBbVUMwNl0gKGRvbWFpbiAwMDAwIFtidXMgN2VdKQpbICAgIDkuNDMyMzA3XSBhY3Bp IFBOUDBBMDM6MDA6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENvbmZpZyBBU1BNIENsb2Nr UE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgICA5LjQ0MTQ0NF0gYWNwaSBQTlAwQTAzOjAw OiBfT1NDOiBwbGF0Zm9ybSBkb2VzIG5vdCBzdXBwb3J0IFtBRVIgTFRSXQpbICAgIDkuNDQ3NTU4 XSBhY3BpIFBOUDBBMDM6MDA6IF9PU0M6IE9TIG5vdyBjb250cm9scyBbUENJZUhvdHBsdWcgUE1F IFBDSWVDYXBhYmlsaXR5XQpbICAgIDkuNDU1NDQ3XSBQQ0kgaG9zdCBicmlkZ2UgdG8gYnVzIDAw MDA6N2UKWyAgICA5LjQ1OTMwNV0gcGNpX2J1cyAwMDAwOjdlOiByb290IGJ1cyByZXNvdXJjZSBb YnVzIDdlXQpbICAgIDkuNDY0MzM4XSBwY2kgMDAwMDo3ZTowMC4wOiBbODA4NjozNDUwXSB0eXBl IDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDAuMApbICAg IDkuNDczMzM2XSBwY2kgMDAwMDo3ZTowMC4xOiBbODA4NjozNDUxXSB0eXBlIDAwIGNsYXNzIDB4 MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDAuMQpbICAgIDkuNDgyMzM2XSBw Y2kgMDAwMDo3ZTowMC4yOiBbODA4NjozNDUyXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4p IFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDAuMgpbICAgIDkuNDkyMzM3XSBwY2kgMDAwMDo3ZTow MC4zOiBbODA4NjowOTk4XSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwCihYRU4pIFBDSSBhZGQgZGV2 aWNlIDAwMDA6N2U6MDAuMwpbICAgIDkuNTAxMzQwXSBwY2kgMDAwMDo3ZTowMC41OiBbODA4Njoz NDU1XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6 MDAuNQpbICAgIDkuNTEwMzUzXSBwY2kgMDAwMDo3ZTowMi4wOiBbODA4NjozNDQwXSB0eXBlIDAw IGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDIuMApbICAgIDku NTE5MzQyXSBwY2kgMDAwMDo3ZTowMi4xOiBbODA4NjozNDQxXSB0eXBlIDAwIGNsYXNzIDB4MDg4 MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDIuMQpbICAgIDkuNTI4MzQzXSBwY2kg MDAwMDo3ZTowMi4yOiBbODA4NjozNDQyXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBD SSBhZGQgZGV2aWNlIDAwMDA6N2U6MDIuMgpbICAgIDkuNTM3MzU1XSBwY2kgMDAwMDo3ZTowMy4w OiBbODA4NjozNDQwXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6N2U6MDMuMApbICAgIDkuNTQ2MzM4XSBwY2kgMDAwMDo3ZTowMy4xOiBbODA4NjozNDQx XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDMu MQpbICAgIDkuNTU1MzM4XSBwY2kgMDAwMDo3ZTowMy4yOiBbODA4NjozNDQyXSB0eXBlIDAwIGNs YXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDMuMgpbICAgIDkuNTY0 MzYwXSBwY2kgMDAwMDo3ZTowNC4wOiBbODA4NjozNDQwXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAw CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDQuMApbICAgIDkuNTc0MzQ0XSBwY2kgMDAw MDo3ZTowNC4xOiBbODA4NjozNDQxXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBh ZGQgZGV2aWNlIDAwMDA6N2U6MDQuMQpbICAgIDkuNTgzMzQzXSBwY2kgMDAwMDo3ZTowNC4yOiBb ODA4NjozNDQyXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6N2U6MDQuMgpbICAgIDkuNTkyMzQ0XSBwY2kgMDAwMDo3ZTowNC4zOiBbODA4NjozNDQzXSB0 eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDQuMwpb ICAgIDkuNjAxMzU2XSBwY2kgMDAwMDo3ZTowNS4wOiBbODA4NjozNDQ1XSB0eXBlIDAwIGNsYXNz IDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDUuMApbICAgIDkuNjEwMzQz XSBwY2kgMDAwMDo3ZTowNS4xOiBbODA4NjozNDQ2XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihY RU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDUuMQpbICAgIDkuNjE5MzQzXSBwY2kgMDAwMDo3 ZTowNS4yOiBbODA4NjozNDQ3XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQg ZGV2aWNlIDAwMDA6N2U6MDUuMgpbICAgIDkuNjI4MzU1XSBwY2kgMDAwMDo3ZTowNi4wOiBbODA4 NjozNDQ1XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6 N2U6MDYuMApbICAgIDkuNjM4MzM4XSBwY2kgMDAwMDo3ZTowNi4xOiBbODA4NjozNDQ2XSB0eXBl IDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDYuMQpbICAg IDkuNjQ3MzQwXSBwY2kgMDAwMDo3ZTowNi4yOiBbODA4NjozNDQ3XSB0eXBlIDAwIGNsYXNzIDB4 MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDYuMgpbICAgIDkuNjU2MzYwXSBw Y2kgMDAwMDo3ZTowNy4wOiBbODA4NjozNDQ1XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4p IFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MDcuMApbICAgIDkuNjY1MzQzXSBwY2kgMDAwMDo3ZTow Ny4xOiBbODA4NjozNDQ2XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2 aWNlIDAwMDA6N2U6MDcuMQpbICAgIDkuNjc0MzQ0XSBwY2kgMDAwMDo3ZTowNy4yOiBbODA4Njoz NDQ3XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6 MDcuMgpbICAgIDkuNjgzMzUxXSBwY2kgMDAwMDo3ZTowYi4wOiBbODA4NjozNDQ4XSB0eXBlIDAw IGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MGIuMApbICAgIDku NjkyMzI1XSBwY2kgMDAwMDo3ZTowYi4xOiBbODA4NjozNDQ4XSB0eXBlIDAwIGNsYXNzIDB4MDg4 MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MGIuMQpbICAgIDkuNzAxMzI1XSBwY2kg MDAwMDo3ZTowYi4yOiBbODA4NjozNDRiXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBD SSBhZGQgZGV2aWNlIDAwMDA6N2U6MGIuMgpbICAgIDkuNzEwMzU3XSBwY2kgMDAwMDo3ZTowYy4w OiBbODA4NjozNDRhXSB0eXBlIDAwIGNsYXNzIDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNl IDAwMDA6N2U6MGMuMApbICAgIDkuNzIwMzYxXSBwY2kgMDAwMDo3ZTowZC4wOiBbODA4NjozNDRh XSB0eXBlIDAwIGNsYXNzIDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MGQu MApbICAgIDkuNzI5MzY4XSBwY2kgMDAwMDo3ZTowZS4wOiBbODA4NjozNDRhXSB0eXBlIDAwIGNs YXNzIDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MGUuMApbICAgIDkuNzM4 MzcwXSBwY2kgMDAwMDo3ZTowZi4wOiBbODA4NjozNDRhXSB0eXBlIDAwIGNsYXNzIDB4MTEwMTAw CihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MGYuMApbICAgIDkuNzQ3Mzk2XSBwY2kgMDAw MDo3ZToxYS4wOiBbODA4NjoyODgwXSB0eXBlIDAwIGNsYXNzIDB4MTEwMTAwCihYRU4pIFBDSSBh ZGQgZGV2aWNlIDAwMDA6N2U6MWEuMApbICAgIDkuNzU2MzYxXSBwY2kgMDAwMDo3ZToxYi4wOiBb ODA4NjoyODgwXSB0eXBlIDAwIGNsYXNzIDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6N2U6MWIuMApbICAgIDkuNzY1MzY4XSBwY2kgMDAwMDo3ZToxYy4wOiBbODA4NjoyODgwXSB0 eXBlIDAwIGNsYXNzIDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MWMuMApb ICAgIDkuNzc0MzcwXSBwY2kgMDAwMDo3ZToxZC4wOiBbODA4NjoyODgwXSB0eXBlIDAwIGNsYXNz IDB4MTEwMTAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6N2U6MWQuMApbICAgIDkuNzg0NDA5 XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1VDMDddIChkb21haW4gMDAwMCBbYnVzIDdmXSkKWyAg ICA5Ljc5MDMwN10gYWNwaSBQTlAwQTAzOjAxOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRD b25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAgOS43OTk0NDNd IGFjcGkgUE5QMEEwMzowMTogX09TQzogcGxhdGZvcm0gZG9lcyBub3Qgc3VwcG9ydCBbQUVSIExU Ul0KWyAgICA5LjgwNTU1OF0gYWNwaSBQTlAwQTAzOjAxOiBfT1NDOiBPUyBub3cgY29udHJvbHMg W1BDSWVIb3RwbHVnIFBNRSBQQ0llQ2FwYWJpbGl0eV0KWyAgICA5LjgxMzQ2MF0gUENJIGhvc3Qg YnJpZGdlIHRvIGJ1cyAwMDAwOjdmClsgICAgOS44MTczMDVdIHBjaV9idXMgMDAwMDo3Zjogcm9v dCBidXMgcmVzb3VyY2UgW2J1cyA3Zl0KWyAgICA5LjgyMjM0M10gcGNpIDAwMDA6N2Y6MDAuMDog WzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjdmOjAwLjAKWyAgICA5LjgzMTM0MV0gcGNpIDAwMDA6N2Y6MDAuMTogWzgwODY6MzQ0Y10g dHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAwLjEK WyAgICA5Ljg0MTM0M10gcGNpIDAwMDA6N2Y6MDAuMjogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAwLjIKWyAgICA5Ljg1MDM0 MV0gcGNpIDAwMDA6N2Y6MDAuMzogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAwLjMKWyAgICA5Ljg1OTM0MV0gcGNpIDAwMDA6 N2Y6MDAuNDogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjdmOjAwLjQKWyAgICA5Ljg2NjM0Nl0gcGNpIDAwMDA6N2Y6MDAuNTogWzgw ODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OjdmOjAwLjUKWyAgICA5Ljg2ODMzOF0gcGNpIDAwMDA6N2Y6MDAuNjogWzgwODY6MzQ0Y10gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAwLjYKWyAg ICA5Ljg3MDM0NF0gcGNpIDAwMDA6N2Y6MDAuNzogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAwLjcKWyAgICA5Ljg3MjMzOV0g cGNpIDAwMDA6N2Y6MDEuMDogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAxLjAKWyAgICA5Ljg3NDMzOF0gcGNpIDAwMDA6N2Y6 MDEuMTogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjdmOjAxLjEKWyAgICA5Ljg3NjM0M10gcGNpIDAwMDA6N2Y6MDEuMjogWzgwODY6 MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdm OjAxLjIKWyAgICA5Ljg3ODMzN10gcGNpIDAwMDA6N2Y6MDEuMzogWzgwODY6MzQ0Y10gdHlwZSAw MCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAxLjMKWyAgICA5 Ljg4MDM0Ml0gcGNpIDAwMDA6N2Y6MDEuNDogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAxLjQKWyAgICA5Ljg4MjM0Ml0gcGNp IDAwMDA6N2Y6MDEuNTogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjdmOjAxLjUKWyAgICA5Ljg4NDM0M10gcGNpIDAwMDA6N2Y6MDEu NjogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjdmOjAxLjYKWyAgICA5Ljg4NjM0M10gcGNpIDAwMDA6N2Y6MDEuNzogWzgwODY6MzQ0 Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAx LjcKWyAgICA5Ljg4ODM0NF0gcGNpIDAwMDA6N2Y6MDIuMDogWzgwODY6MzQ0Y10gdHlwZSAwMCBj bGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAyLjAKWyAgICA5Ljg5 MDM0NF0gcGNpIDAwMDA6N2Y6MDIuMTogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAyLjEKWyAgICA5Ljg5MjM0NF0gcGNpIDAw MDA6N2Y6MDIuMjogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjdmOjAyLjIKWyAgICA5Ljg5NDM0NV0gcGNpIDAwMDA6N2Y6MDIuMzog WzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjdmOjAyLjMKWyAgICA5Ljg5NjM0NV0gcGNpIDAwMDA6N2Y6MDIuNDogWzgwODY6MzQ0Y10g dHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAyLjQK WyAgICA5Ljg5ODM0NV0gcGNpIDAwMDA6N2Y6MDIuNTogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAyLjUKWyAgICA5LjkwMDM0 Nl0gcGNpIDAwMDA6N2Y6MDIuNjogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAyLjYKWyAgICA5LjkwMjM0N10gcGNpIDAwMDA6 N2Y6MDIuNzogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjdmOjAyLjcKWyAgICA5LjkwNDM0Nl0gcGNpIDAwMDA6N2Y6MDMuMDogWzgw ODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OjdmOjAzLjAKWyAgICA5LjkwNjM0Ml0gcGNpIDAwMDA6N2Y6MDMuMTogWzgwODY6MzQ0Y10gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAzLjEKWyAg ICA5LjkwODM0M10gcGNpIDAwMDA6N2Y6MDMuMjogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAzLjIKWyAgICA5LjkxMDM0NV0g cGNpIDAwMDA6N2Y6MDMuMzogWzgwODY6MzQ0Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjAzLjMKWyAgICA5LjkxMjM3M10gcGNpIDAwMDA6N2Y6 MGEuMDogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjdmOjBhLjAKWyAgICA5LjkxNDM0MF0gcGNpIDAwMDA6N2Y6MGEuMTogWzgwODY6 MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdm OjBhLjEKWyAgICA5LjkxNjM0Ml0gcGNpIDAwMDA6N2Y6MGEuMjogWzgwODY6MzQ0ZF0gdHlwZSAw MCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBhLjIKWyAgICA5 LjkxODMzOV0gcGNpIDAwMDA6N2Y6MGEuMzogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBhLjMKWyAgICA5LjkyMDM0MV0gcGNp IDAwMDA6N2Y6MGEuNDogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjdmOjBhLjQKWyAgICA5LjkyMjM0M10gcGNpIDAwMDA6N2Y6MGEu NTogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjdmOjBhLjUKWyAgICA5LjkyNDMzOV0gcGNpIDAwMDA6N2Y6MGEuNjogWzgwODY6MzQ0 ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBh LjYKWyAgICA5LjkyNjM0M10gcGNpIDAwMDA6N2Y6MGEuNzogWzgwODY6MzQ0ZF0gdHlwZSAwMCBj bGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBhLjcKWyAgICA5Ljky ODMzOF0gcGNpIDAwMDA6N2Y6MGIuMDogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBiLjAKWyAgICA5LjkzMDMzOF0gcGNpIDAw MDA6N2Y6MGIuMTogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjdmOjBiLjEKWyAgICA5LjkzMjM0NF0gcGNpIDAwMDA6N2Y6MGIuMjog WzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjdmOjBiLjIKWyAgICA5LjkzNDMzN10gcGNpIDAwMDA6N2Y6MGIuMzogWzgwODY6MzQ0ZF0g dHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBiLjMK WyAgICA5LjkzNjM0NF0gcGNpIDAwMDA6N2Y6MGIuNDogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBiLjQKWyAgICA5LjkzODM0 M10gcGNpIDAwMDA6N2Y6MGIuNTogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBiLjUKWyAgICA5Ljk0MDM0M10gcGNpIDAwMDA6 N2Y6MGIuNjogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjdmOjBiLjYKWyAgICA5Ljk0MjM0M10gcGNpIDAwMDA6N2Y6MGIuNzogWzgw ODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OjdmOjBiLjcKWyAgICA5Ljk0NDM0NF0gcGNpIDAwMDA6N2Y6MGMuMDogWzgwODY6MzQ0ZF0gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjAKWyAg ICA5Ljk0NjM0NF0gcGNpIDAwMDA6N2Y6MGMuMTogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjEKWyAgICA5Ljk0ODM0NF0g cGNpIDAwMDA6N2Y6MGMuMjogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjIKWyAgICA5Ljk1MDM0NV0gcGNpIDAwMDA6N2Y6 MGMuMzogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjdmOjBjLjMKWyAgICA5Ljk1MjM0N10gcGNpIDAwMDA6N2Y6MGMuNDogWzgwODY6 MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdm OjBjLjQKWyAgICA5Ljk1NDM0NV0gcGNpIDAwMDA6N2Y6MGMuNTogWzgwODY6MzQ0ZF0gdHlwZSAw MCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjUKWyAgICA5 Ljk1NjM0Nl0gcGNpIDAwMDA6N2Y6MGMuNjogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjYKWyAgICA5Ljk1ODM0OF0gcGNp IDAwMDA6N2Y6MGMuNzogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjdmOjBjLjcKWyAgICA5Ljk2MDM0NV0gcGNpIDAwMDA6N2Y6MGQu MDogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOjdmOjBkLjAKWyAgICA5Ljk2MjM0Ml0gcGNpIDAwMDA6N2Y6MGQuMTogWzgwODY6MzQ0 ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBk LjEKWyAgICA5Ljk2NDM0M10gcGNpIDAwMDA6N2Y6MGQuMjogWzgwODY6MzQ0ZF0gdHlwZSAwMCBj bGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBkLjIKWyAgICA5Ljk2 NjM0Nl0gcGNpIDAwMDA6N2Y6MGQuMzogWzgwODY6MzQ0ZF0gdHlwZSAwMCBjbGFzcyAweDA4ODAw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjBkLjMKWyAgICA5Ljk2ODQwOF0gcGNpIDAw MDA6N2Y6MWQuMDogWzgwODY6MzQ0Zl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOjdmOjFkLjAKWyAgICA5Ljk3MDM0MV0gcGNpIDAwMDA6N2Y6MWQuMTog WzgwODY6MzQ1N10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOjdmOjFkLjEKWyAgICA5Ljk3MjM0N10gcGNpIDAwMDA6N2Y6MWUuMDogWzgwODY6MzQ1OF0g dHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjAK WyAgICA5Ljk3NDMyNV0gcGNpIDAwMDA6N2Y6MWUuMTogWzgwODY6MzQ1OV0gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjEKWyAgICA5Ljk3NjMy NV0gcGNpIDAwMDA6N2Y6MWUuMjogWzgwODY6MzQ1YV0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjIKWyAgICA5Ljk3ODMyNV0gcGNpIDAwMDA6 N2Y6MWUuMzogWzgwODY6MzQ1Yl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjdmOjFlLjMKWyAgICA5Ljk4MDMyNV0gcGNpIDAwMDA6N2Y6MWUuNDogWzgw ODY6MzQ1Y10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OjdmOjFlLjQKWyAgICA5Ljk4MjMyNV0gcGNpIDAwMDA6N2Y6MWUuNTogWzgwODY6MzQ1ZF0gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjUKWyAg ICA5Ljk4NDMyNV0gcGNpIDAwMDA6N2Y6MWUuNjogWzgwODY6MzQ1ZV0gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjYKWyAgICA5Ljk4NjMyNV0g cGNpIDAwMDA6N2Y6MWUuNzogWzgwODY6MzQ1Zl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOjdmOjFlLjcKWyAgICA5Ljk4ODM5Nl0gQUNQSTogUENJIFJv b3QgQnJpZGdlIFtQQzA2XSAoZG9tYWluIDAwMDAgW2J1cyA4MC05Nl0pClsgICAgOS45ODkzMDld IGFjcGkgUE5QMEEwODowNjogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0g Q2xvY2tQTSBTZWdtZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgMTAuMDAyNTQ2XSBhY3BpIFBOUDBB MDg6MDY6IF9PU0M6IHBsYXRmb3JtIGRvZXMgbm90IHN1cHBvcnQgW0FFUl0KWyAgIDEwLjAwMzY0 MV0gYWNwaSBQTlAwQTA4OjA2OiBfT1NDOiBPUyBub3cgY29udHJvbHMgW1BDSWVIb3RwbHVnIFBN RSBQQ0llQ2FwYWJpbGl0eSBMVFJdClsgICAxMC4wMDQ0NjFdIFBDSSBob3N0IGJyaWRnZSB0byBi dXMgMDAwMDo4MApbICAgMTAuMDA1MzA1XSBwY2lfYnVzIDAwMDA6ODA6IHJvb3QgYnVzIHJlc291 cmNlIFtpbyAgMHhiMDAwLTB4YmZmZiB3aW5kb3ddClsgICAxMC4wMDYzMDRdIHBjaV9idXMgMDAw MDo4MDogcm9vdCBidXMgcmVzb3VyY2UgW21lbSAweGM2ODAwMDAwLTB4ZDBmZmZmZmYgd2luZG93 XQpbICAgMTAuMDA3MzA1XSBwY2lfYnVzIDAwMDA6ODA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0g MHgyMDUwMDAwMDAwMDAtMHgyMDVmZmZmZmZmZmYgd2luZG93XQpbICAgMTAuMDA4MzA1XSBwY2lf YnVzIDAwMDA6ODA6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgODAtOTZdClsgICAxMC4wMDkzMzhd IHBjaSAwMDAwOjgwOjAwLjA6IFs4MDg2OjA5YTJdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDo4MDowMC4wClsgICAxMC4wMTEzMzddIHBjaSAwMDAwOjgw OjAwLjE6IFs4MDg2OjA5YTRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBk ZXZpY2UgMDAwMDo4MDowMC4xClsgICAxMC4wMTMzMzZdIHBjaSAwMDAwOjgwOjAwLjI6IFs4MDg2 OjA5YTNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo4 MDowMC4yClsgICAxMC4wMTUzNDFdIHBjaSAwMDAwOjgwOjAwLjQ6IFs4MDg2OjA5OThdIHR5cGUg MDAgY2xhc3MgMHgwNjAwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo4MDowMC40ClsgICAx MC4wMTczNDZdIHBjaSAwMDAwOjgwOjAxLjA6IFs4MDg2OjBiMDBdIHR5cGUgMDAgY2xhc3MgMHgw ODgwMDAKWyAgIDEwLjAxODM1M10gcGNpIDAwMDA6ODA6MDEuMDogcmVnIDB4MTA6IFttZW0gMHgy MDVmZmZmNDAwMDAtMHgyMDVmZmZmNDNmZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6ODA6MDEuMApbICAgMTAuMDIwMzM2XSBwY2kgMDAwMDo4MDowMS4xOiBbODA4NjowYjAwXSB0 eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAxMC4wMjEzNTJdIHBjaSAwMDAwOjgwOjAxLjE6IHJl ZyAweDEwOiBbbWVtIDB4MjA1ZmZmZjNjMDAwLTB4MjA1ZmZmZjNmZmZmIDY0Yml0XQooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjgwOjAxLjEKWyAgIDEwLjAyMzMzNl0gcGNpIDAwMDA6ODA6MDEu MjogWzgwODY6MGIwMF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMApbICAgMTAuMDI0MzUyXSBwY2kg MDAwMDo4MDowMS4yOiByZWcgMHgxMDogW21lbSAweDIwNWZmZmYzODAwMC0weDIwNWZmZmYzYmZm ZiA2NGJpdF0KKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo4MDowMS4yClsgICAxMC4wMjYzMzZd IHBjaSAwMDAwOjgwOjAxLjM6IFs4MDg2OjBiMDBdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKWyAg IDEwLjAyNzM1Ml0gcGNpIDAwMDA6ODA6MDEuMzogcmVnIDB4MTA6IFttZW0gMHgyMDVmZmZmMzQw MDAtMHgyMDVmZmZmMzdmZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6ODA6MDEu MwpbICAgMTAuMDI5MzM2XSBwY2kgMDAwMDo4MDowMS40OiBbODA4NjowYjAwXSB0eXBlIDAwIGNs YXNzIDB4MDg4MDAwClsgICAxMC4wMzAzNTJdIHBjaSAwMDAwOjgwOjAxLjQ6IHJlZyAweDEwOiBb bWVtIDB4MjA1ZmZmZjMwMDAwLTB4MjA1ZmZmZjMzZmZmIDY0Yml0XQooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOjgwOjAxLjQKWyAgIDEwLjAzMjMzNl0gcGNpIDAwMDA6ODA6MDEuNTogWzgwODY6 MGIwMF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMApbICAgMTAuMDMzMzUyXSBwY2kgMDAwMDo4MDow MS41OiByZWcgMHgxMDogW21lbSAweDIwNWZmZmYyYzAwMC0weDIwNWZmZmYyZmZmZiA2NGJpdF0K KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDo4MDowMS41ClsgICAxMC4wMzUzMzZdIHBjaSAwMDAw OjgwOjAxLjY6IFs4MDg2OjBiMDBdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKWyAgIDEwLjAzNjM1 Ml0gcGNpIDAwMDA6ODA6MDEuNjogcmVnIDB4MTA6IFttZW0gMHgyMDVmZmZmMjgwMDAtMHgyMDVm ZmZmMmJmZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6ODA6MDEuNgpbICAgMTAu MDM4MzM2XSBwY2kgMDAwMDo4MDowMS43OiBbODA4NjowYjAwXSB0eXBlIDAwIGNsYXNzIDB4MDg4 MDAwClsgICAxMC4wMzkzNTJdIHBjaSAwMDAwOjgwOjAxLjc6IHJlZyAweDEwOiBbbWVtIDB4MjA1 ZmZmZjI0MDAwLTB4MjA1ZmZmZjI3ZmZmIDY0Yml0XQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OjgwOjAxLjcKWyAgIDEwLjA0MTMzMF0gcGNpIDAwMDA6ODA6MDIuMDogWzgwODY6MDlhNl0gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMApbICAgMTAuMDQyMzQ0XSBwY2kgMDAwMDo4MDowMi4wOiByZWcg MHgxMDogW21lbSAweGM2OTgwMDAwLTB4YzY5ODFmZmZdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAw MDA6ODA6MDIuMApbICAgMTAuMDQ0MzMwXSBwY2kgMDAwMDo4MDowMi4xOiBbODA4NjowOWE3XSB0 eXBlIDAwIGNsYXNzIDB4MDg4MDAwClsgICAxMC4wNDUzNDRdIHBjaSAwMDAwOjgwOjAyLjE6IHJl ZyAweDEwOiBbbWVtIDB4YzY5MDAwMDAtMHhjNjk3ZmZmZl0KWyAgIDEwLjA0NjMyN10gcGNpIDAw MDA6ODA6MDIuMTogcmVnIDB4MTQ6IFttZW0gMHhjNjg4MDAwMC0weGM2OGZmZmZmXQooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOjgwOjAyLjEKWyAgIDEwLjA0ODMzMF0gcGNpIDAwMDA6ODA6MDIu MjogWzgwODY6MDlhOF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMApbICAgMTAuMDQ5MzQ0XSBwY2kg MDAwMDo4MDowMi4yOiByZWcgMHgxMDogW21lbSAweGM2ODAwMDAwLTB4YzY4N2ZmZmZdCihYRU4p IFBDSSBhZGQgZGV2aWNlIDAwMDA6ODA6MDIuMgpbICAgMTAuMDUxMzQwXSBwY2kgMDAwMDo4MDow Mi40OiBbODA4NjozNDU2XSB0eXBlIDAwIGNsYXNzIDB4MTMwMDAwClsgICAxMC4wNTIzNTRdIHBj aSAwMDAwOjgwOjAyLjQ6IHJlZyAweDEwOiBbbWVtIDB4MjA1ZmZmZTAwMDAwLTB4MjA1ZmZmZWZm ZmZmIDY0Yml0XQpbICAgMTAuMDUzMzM0XSBwY2kgMDAwMDo4MDowMi40OiByZWcgMHgxODogW21l bSAweDIwNWZmZmYyMDAwMC0weDIwNWZmZmYyM2ZmZiA2NGJpdF0KWyAgIDEwLjA1NDMzNF0gcGNp IDAwMDA6ODA6MDIuNDogcmVnIDB4MjA6IFttZW0gMHgyMDVmZmZmMDAwMDAtMHgyMDVmZmZmMWZm ZmYgNjRiaXRdCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6ODA6MDIuNApbICAgMTAuMDU2NDc5 XSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1BDMDddIChkb21haW4gMDAwMCBbYnVzIDk3LWFmXSkK WyAgIDEwLjA1NzMwNl0gYWNwaSBQTlAwQTA4OjA3OiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5k ZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAxMC4wNzA2 NjhdIGFjcGkgUE5QMEEwODowNzogX09TQzogcGxhdGZvcm0gZG9lcyBub3Qgc3VwcG9ydCBbQUVS XQpbICAgMTAuMDcxODIxXSBhY3BpIFBOUDBBMDg6MDc6IF9PU0M6IE9TIG5vdyBjb250cm9scyBb UENJZUhvdHBsdWcgUE1FIFBDSWVDYXBhYmlsaXR5IExUUl0KWyAgIDEwLjA3MjQyM10gUENJIGhv c3QgYnJpZGdlIHRvIGJ1cyAwMDAwOjk3ClsgICAxMC4wNzMzMDVdIHBjaV9idXMgMDAwMDo5Nzog cm9vdCBidXMgcmVzb3VyY2UgW2lvICAweGMwMDAtMHhjZmZmIHdpbmRvd10KWyAgIDEwLjA3NDMw NV0gcGNpX2J1cyAwMDAwOjk3OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4ZDEwMDAwMDAtMHhk YmJmZmZmZiB3aW5kb3ddClsgICAxMC4wNzUzMDVdIHBjaV9idXMgMDAwMDo5Nzogcm9vdCBidXMg cmVzb3VyY2UgW21lbSAweDIwNjAwMDAwMDAwMC0weDIwNmZmZmZmZmZmZiB3aW5kb3ddClsgICAx MC4wNzYzMDVdIHBjaV9idXMgMDAwMDo5Nzogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyA5Ny1hZl0K WyAgIDEwLjA3NzMzOF0gcGNpIDAwMDA6OTc6MDAuMDogWzgwODY6MDlhMl0gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjk3OjAwLjAKWyAgIDEwLjA3OTMz N10gcGNpIDAwMDA6OTc6MDAuMTogWzgwODY6MDlhNF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOjk3OjAwLjEKWyAgIDEwLjA4MTMzN10gcGNpIDAwMDA6 OTc6MDAuMjogWzgwODY6MDlhM10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOjk3OjAwLjIKWyAgIDEwLjA4MzM0MF0gcGNpIDAwMDA6OTc6MDAuNDogWzgw ODY6MDk5OF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw Ojk3OjAwLjQKWyAgIDEwLjA4NTUxMl0gQUNQSTogUENJIFJvb3QgQnJpZGdlIFtQQzA4XSAoZG9t YWluIDAwMDAgW2J1cyBiMC1jOF0pClsgICAxMC4wODYzMDZdIGFjcGkgUE5QMEEwODowODogX09T QzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdtZW50cyBNU0kg SFBYLVR5cGUzXQpbICAgMTAuMDk5OTY1XSBhY3BpIFBOUDBBMDg6MDg6IF9PU0M6IHBsYXRmb3Jt IGRvZXMgbm90IHN1cHBvcnQgW0FFUl0KWyAgIDEwLjEwMDgxMF0gYWNwaSBQTlAwQTA4OjA4OiBf T1NDOiBPUyBub3cgY29udHJvbHMgW1BDSWVIb3RwbHVnIFBNRSBQQ0llQ2FwYWJpbGl0eSBMVFJd ClsgICAxMC4xMDE0MzBdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwMDpiMApbICAgMTAuMTAy MzA1XSBwY2lfYnVzIDAwMDA6YjA6IHJvb3QgYnVzIHJlc291cmNlIFtpbyAgMHhkMDAwLTB4ZGZm ZiB3aW5kb3ddClsgICAxMC4xMDMzMDVdIHBjaV9idXMgMDAwMDpiMDogcm9vdCBidXMgcmVzb3Vy Y2UgW21lbSAweGRiYzAwMDAwLTB4ZTY3ZmZmZmYgd2luZG93XQpbICAgMTAuMTA0MzA1XSBwY2lf YnVzIDAwMDA6YjA6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHgyMDcwMDAwMDAwMDAtMHgyMDdm ZmZmZmZmZmYgd2luZG93XQpbICAgMTAuMTA1MzA1XSBwY2lfYnVzIDAwMDA6YjA6IHJvb3QgYnVz IHJlc291cmNlIFtidXMgYjAtYzhdClsgICAxMC4xMDYzMzldIHBjaSAwMDAwOmIwOjAwLjA6IFs4 MDg2OjA5YTJdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDpiMDowMC4wClsgICAxMC4xMDgzMzddIHBjaSAwMDAwOmIwOjAwLjE6IFs4MDg2OjA5YTRdIHR5 cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpiMDowMC4xClsg ICAxMC4xMTAzMzhdIHBjaSAwMDAwOmIwOjAwLjI6IFs4MDg2OjA5YTNdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpiMDowMC4yClsgICAxMC4xMTIzNDBd IHBjaSAwMDAwOmIwOjAwLjQ6IFs4MDg2OjA5OThdIHR5cGUgMDAgY2xhc3MgMHgwNjAwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDpiMDowMC40ClsgICAxMC4xMTQzNTVdIHBjaSAwMDAwOmIw OjAyLjA6IFs4MDg2OjM0N2FdIHR5cGUgMDEgY2xhc3MgMHgwNjA0MDAKWyAgIDEwLjExNTM1OV0g cGNpIDAwMDA6YjA6MDIuMDogcmVnIDB4MTA6IFttZW0gMHgyMDdmZmZiMDAwMDAtMHgyMDdmZmZi MWZmZmYgNjRiaXRdClsgICAxMC4xMTY1MjJdIHBjaSAwMDAwOmIwOjAyLjA6IFBNRSMgc3VwcG9y dGVkIGZyb20gRDAgRDNob3QgRDNjb2xkCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6YjA6MDIu MApbICAgMTAuMTE4NjczXSBhY3BpcGhwOiBTbG90IFs5XSByZWdpc3RlcmVkClsgICAxMC4xMTk0 MDFdIHBjaSAwMDAwOmIxOjAwLjA6IFs4MDg2OjE1NzJdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAK WyAgIDEwLjEyMDM2MV0gcGNpIDAwMDA6YjE6MDAuMDogcmVnIDB4MTA6IFttZW0gMHgyMDdmZmU4 MDAwMDAtMHgyMDdmZmVmZmZmZmYgNjRiaXQgcHJlZl0KWyAgIDEwLjEyMTM1N10gcGNpIDAwMDA6 YjE6MDAuMDogcmVnIDB4MWM6IFttZW0gMHgyMDdmZmY4MDgwMDAtMHgyMDdmZmY4MGZmZmYgNjRi aXQgcHJlZl0KWyAgIDEwLjEyMjM0NF0gcGNpIDAwMDA6YjE6MDAuMDogcmVnIDB4MzA6IFttZW0g MHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZdClsgICAxMC4xMjM1MTZdIHBjaSAwMDAwOmIxOjAw LjA6IFBNRSMgc3VwcG9ydGVkIGZyb20gRDAgRDNob3QgRDNjb2xkClsgICAxMC4xMjQ0MzVdIHBj aSAwMDAwOmIxOjAwLjA6IHJlZyAweDE4NDogW21lbSAweDIwN2ZmZjQwMDAwMC0weDIwN2ZmZjQw ZmZmZiA2NGJpdCBwcmVmXQpbICAgMTAuMTI1MzA1XSBwY2kgMDAwMDpiMTowMC4wOiBWRihuKSBC QVIwIHNwYWNlOiBbbWVtIDB4MjA3ZmZmNDAwMDAwLTB4MjA3ZmZmN2ZmZmZmIDY0Yml0IHByZWZd IChjb250YWlucyBCQVIwIGZvciA2NCBWRnMpClsgICAxMC4xMjYzMzJdIHBjaSAwMDAwOmIxOjAw LjA6IHJlZyAweDE5MDogW21lbSAweDIwN2ZmZjkxMDAwMC0weDIwN2ZmZjkxM2ZmZiA2NGJpdCBw cmVmXQpbICAgMTAuMTI3MzA1XSBwY2kgMDAwMDpiMTowMC4wOiBWRihuKSBCQVIzIHNwYWNlOiBb bWVtIDB4MjA3ZmZmOTEwMDAwLTB4MjA3ZmZmYTBmZmZmIDY0Yml0IHByZWZdIChjb250YWlucyBC QVIzIGZvciA2NCBWRnMpCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6YjE6MDAuMApbICAgMTAu MTI5MzYxXSBwY2kgMDAwMDpiMTowMC4xOiBbODA4NjoxNTcyXSB0eXBlIDAwIGNsYXNzIDB4MDIw MDAwClsgICAxMC4xMzAzNjFdIHBjaSAwMDAwOmIxOjAwLjE6IHJlZyAweDEwOiBbbWVtIDB4MjA3 ZmZlMDAwMDAwLTB4MjA3ZmZlN2ZmZmZmIDY0Yml0IHByZWZdClsgICAxMC4xMzEzNTddIHBjaSAw MDAwOmIxOjAwLjE6IHJlZyAweDFjOiBbbWVtIDB4MjA3ZmZmODAwMDAwLTB4MjA3ZmZmODA3ZmZm IDY0Yml0IHByZWZdClsgICAxMC4xMzIzNDRdIHBjaSAwMDAwOmIxOjAwLjE6IHJlZyAweDMwOiBb bWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgMTAuMTMzNTEzXSBwY2kgMDAwMDpi MTowMC4xOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZApbICAgMTAuMTM0Mzcy XSBwY2kgMDAwMDpiMTowMC4xOiByZWcgMHgxODQ6IFttZW0gMHgyMDdmZmYwMDAwMDAtMHgyMDdm ZmYwMGZmZmYgNjRiaXQgcHJlZl0KWyAgIDEwLjEzNTMwNV0gcGNpIDAwMDA6YjE6MDAuMTogVkYo bikgQkFSMCBzcGFjZTogW21lbSAweDIwN2ZmZjAwMDAwMC0weDIwN2ZmZjNmZmZmZiA2NGJpdCBw cmVmXSAoY29udGFpbnMgQkFSMCBmb3IgNjQgVkZzKQpbICAgMTAuMTM2MzMyXSBwY2kgMDAwMDpi MTowMC4xOiByZWcgMHgxOTA6IFttZW0gMHgyMDdmZmY4MTAwMDAtMHgyMDdmZmY4MTNmZmYgNjRi aXQgcHJlZl0KWyAgIDEwLjEzNzMwNV0gcGNpIDAwMDA6YjE6MDAuMTogVkYobikgQkFSMyBzcGFj ZTogW21lbSAweDIwN2ZmZjgxMDAwMC0weDIwN2ZmZjkwZmZmZiA2NGJpdCBwcmVmXSAoY29udGFp bnMgQkFSMyBmb3IgNjQgVkZzKQooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmIxOjAwLjEKWyAg IDEwLjEzOTQ0Ml0gcGNpIDAwMDA6YjA6MDIuMDogUENJIGJyaWRnZSB0byBbYnVzIGIxLWIyXQpb ICAgMTAuMTQwMzMwXSBwY2kgMDAwMDpiMDowMi4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIw N2ZmZTAwMDAwMC0weDIwN2ZmZmFmZmZmZiA2NGJpdCBwcmVmXQpbICAgMTAuMTQxNDYyXSBBQ1BJ OiBQQ0kgUm9vdCBCcmlkZ2UgW1BDMTBdIChkb21haW4gMDAwMCBbYnVzIGM5LWUxXSkKWyAgIDEw LjE0MjMwNl0gYWNwaSBQTlAwQTA4OjBhOiBfT1NDOiBPUyBzdXBwb3J0cyBbRXh0ZW5kZWRDb25m aWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlwZTNdClsgICAxMC4xNTYwMDddIGFj cGkgUE5QMEEwODowYTogX09TQzogcGxhdGZvcm0gZG9lcyBub3Qgc3VwcG9ydCBbQUVSXQpbICAg MTAuMTU2ODE3XSBhY3BpIFBOUDBBMDg6MGE6IF9PU0M6IE9TIG5vdyBjb250cm9scyBbUENJZUhv dHBsdWcgUE1FIFBDSWVDYXBhYmlsaXR5IExUUl0KWyAgIDEwLjE1NzQyOV0gUENJIGhvc3QgYnJp ZGdlIHRvIGJ1cyAwMDAwOmM5ClsgICAxMC4xNTgzMDVdIHBjaV9idXMgMDAwMDpjOTogcm9vdCBi dXMgcmVzb3VyY2UgW2lvICAweGUwMDAtMHhlZmZmIHdpbmRvd10KWyAgIDEwLjE1OTMwNV0gcGNp X2J1cyAwMDAwOmM5OiByb290IGJ1cyByZXNvdXJjZSBbbWVtIDB4ZTY4MDAwMDAtMHhmMTNmZmZm ZiB3aW5kb3ddClsgICAxMC4xNjAzMDVdIHBjaV9idXMgMDAwMDpjOTogcm9vdCBidXMgcmVzb3Vy Y2UgW21lbSAweDIwODAwMDAwMDAwMC0weDIwOGZmZmZmZmZmZiB3aW5kb3ddClsgICAxMC4xNjEz MDVdIHBjaV9idXMgMDAwMDpjOTogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyBjOS1lMV0KWyAgIDEw LjE2MjMzOF0gcGNpIDAwMDA6Yzk6MDAuMDogWzgwODY6MDlhMl0gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmM5OjAwLjAKWyAgIDEwLjE2NDMzN10gcGNp IDAwMDA6Yzk6MDAuMTogWzgwODY6MDlhNF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOmM5OjAwLjEKWyAgIDEwLjE2NjMzN10gcGNpIDAwMDA6Yzk6MDAu MjogWzgwODY6MDlhM10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOmM5OjAwLjIKWyAgIDEwLjE2ODM0M10gcGNpIDAwMDA6Yzk6MDAuNDogWzgwODY6MDk5 OF0gdHlwZSAwMCBjbGFzcyAweDA2MDAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmM5OjAw LjQKWyAgIDEwLjE3MDM1NV0gcGNpIDAwMDA6Yzk6MDIuMDogWzgwODY6MzQ3YV0gdHlwZSAwMSBj bGFzcyAweDA2MDQwMApbICAgMTAuMTcxMzU4XSBwY2kgMDAwMDpjOTowMi4wOiByZWcgMHgxMDog W21lbSAweDIwOGZmZmYwMDAwMC0weDIwOGZmZmYxZmZmZiA2NGJpdF0KWyAgIDEwLjE3MjM3OF0g cGNpIDAwMDA6Yzk6MDIuMDogZW5hYmxpbmcgRXh0ZW5kZWQgVGFncwpbICAgMTAuMTczNDQyXSBw Y2kgMDAwMDpjOTowMi4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOmM5OjAyLjAKWyAgIDEwLjE3NTY2N10gYWNwaXBocDogU2xv dCBbOF0gcmVnaXN0ZXJlZApbICAgMTAuMTc2NDIyXSBwY2kgMDAwMDpjYTowMC4wOiB3b3JraW5n IGFyb3VuZCBST00gQkFSIG92ZXJsYXAgZGVmZWN0ClsgICAxMC4xNzczMDVdIHBjaSAwMDAwOmNh OjAwLjA6IFs4MDg2OjE1MzNdIHR5cGUgMDAgY2xhc3MgMHgwMjAwMDAKWyAgIDEwLjE3ODM2M10g cGNpIDAwMDA6Y2E6MDAuMDogcmVnIDB4MTA6IFttZW0gMHhlNjgwMDAwMC0weGU2OGZmZmZmXQpb ICAgMTAuMTc5Mzc5XSBwY2kgMDAwMDpjYTowMC4wOiByZWcgMHgxYzogW21lbSAweGU2OTAwMDAw LTB4ZTY5MDNmZmZdClsgICAxMC4xODAzODBdIHBjaSAwMDAwOmNhOjAwLjA6IHJlZyAweDMwOiBb bWVtIDB4ZmZmMDAwMDAtMHhmZmZmZmZmZiBwcmVmXQpbICAgMTAuMTgxNTU1XSBwY2kgMDAwMDpj YTowMC4wOiBQTUUjIHN1cHBvcnRlZCBmcm9tIEQwIEQzaG90IEQzY29sZAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOmNhOjAwLjAKWyAgIDEwLjE4MzQyNF0gcGNpIDAwMDA6Yzk6MDIuMDogUENJ IGJyaWRnZSB0byBbYnVzIGNhXQpbICAgMTAuMTg0MzE4XSBwY2kgMDAwMDpjOTowMi4wOiAgIGJy aWRnZSB3aW5kb3cgW21lbSAweGU2ODAwMDAwLTB4ZTY5ZmZmZmZdClsgICAxMC4xODU0NDVdIEFD UEk6IFBDSSBSb290IEJyaWRnZSBbUEMxMV0gKGRvbWFpbiAwMDAwIFtidXMgZTItZmFdKQpbICAg MTAuMTg2MzA2XSBhY3BpIFBOUDBBMDg6MGI6IF9PU0M6IE9TIHN1cHBvcnRzIFtFeHRlbmRlZENv bmZpZyBBU1BNIENsb2NrUE0gU2VnbWVudHMgTVNJIEhQWC1UeXBlM10KWyAgIDEwLjE5OTY2MF0g YWNwaSBQTlAwQTA4OjBiOiBfT1NDOiBwbGF0Zm9ybSBkb2VzIG5vdCBzdXBwb3J0IFtBRVJdClsg ICAxMC4yMDA4MTZdIGFjcGkgUE5QMEEwODowYjogX09TQzogT1Mgbm93IGNvbnRyb2xzIFtQQ0ll SG90cGx1ZyBQTUUgUENJZUNhcGFiaWxpdHkgTFRSXQpbICAgMTAuMjAxNDI1XSBQQ0kgaG9zdCBi cmlkZ2UgdG8gYnVzIDAwMDA6ZTIKWyAgIDEwLjIwMjMwNV0gcGNpX2J1cyAwMDAwOmUyOiByb290 IGJ1cyByZXNvdXJjZSBbaW8gIDB4ZjAwMC0weGZmZmYgd2luZG93XQpbICAgMTAuMjAzMzA1XSBw Y2lfYnVzIDAwMDA6ZTI6IHJvb3QgYnVzIHJlc291cmNlIFttZW0gMHhmMTQwMDAwMC0weGZiN2Zm ZmZmIHdpbmRvd10KWyAgIDEwLjIwNDMwNF0gcGNpX2J1cyAwMDAwOmUyOiByb290IGJ1cyByZXNv dXJjZSBbbWVtIDB4MjA5MDAwMDAwMDAwLTB4MjA5ZmZmZmZmZmZmIHdpbmRvd10KWyAgIDEwLjIw NTMwNV0gcGNpX2J1cyAwMDAwOmUyOiByb290IGJ1cyByZXNvdXJjZSBbYnVzIGUyLWZhXQpbICAg MTAuMjA2MzM4XSBwY2kgMDAwMDplMjowMC4wOiBbODA4NjowOWEyXSB0eXBlIDAwIGNsYXNzIDB4 MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6ZTI6MDAuMApbICAgMTAuMjA4MzM3XSBw Y2kgMDAwMDplMjowMC4xOiBbODA4NjowOWE0XSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4p IFBDSSBhZGQgZGV2aWNlIDAwMDA6ZTI6MDAuMQpbICAgMTAuMjEwMzM3XSBwY2kgMDAwMDplMjow MC4yOiBbODA4NjowOWEzXSB0eXBlIDAwIGNsYXNzIDB4MDg4MDAwCihYRU4pIFBDSSBhZGQgZGV2 aWNlIDAwMDA6ZTI6MDAuMgpbICAgMTAuMjEyMzQwXSBwY2kgMDAwMDplMjowMC40OiBbODA4Njow OTk4XSB0eXBlIDAwIGNsYXNzIDB4MDYwMDAwCihYRU4pIFBDSSBhZGQgZGV2aWNlIDAwMDA6ZTI6 MDAuNApbICAgMTAuMjE0NTAzXSBBQ1BJOiBQQ0kgUm9vdCBCcmlkZ2UgW1VDMTZdIChkb21haW4g MDAwMCBbYnVzIGZlXSkKWyAgIDEwLjIxNTMwNl0gYWNwaSBQTlAwQTAzOjAyOiBfT1NDOiBPUyBz dXBwb3J0cyBbRXh0ZW5kZWRDb25maWcgQVNQTSBDbG9ja1BNIFNlZ21lbnRzIE1TSSBIUFgtVHlw ZTNdClsgICAxMC4yMTY0MThdIGFjcGkgUE5QMEEwMzowMjogX09TQzogcGxhdGZvcm0gZG9lcyBu b3Qgc3VwcG9ydCBbQUVSIExUUl0KWyAgIDEwLjIxNzUwNl0gYWNwaSBQTlAwQTAzOjAyOiBfT1ND OiBPUyBub3cgY29udHJvbHMgW1BDSWVIb3RwbHVnIFBNRSBQQ0llQ2FwYWJpbGl0eV0KWyAgIDEw LjIxODQzOV0gUENJIGhvc3QgYnJpZGdlIHRvIGJ1cyAwMDAwOmZlClsgICAxMC4yMTkzMDVdIHBj aV9idXMgMDAwMDpmZTogcm9vdCBidXMgcmVzb3VyY2UgW2J1cyBmZV0KWyAgIDEwLjIyMDMzN10g cGNpIDAwMDA6ZmU6MDAuMDogWzgwODY6MzQ1MF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAwLjAKWyAgIDEwLjIyMjMzNl0gcGNpIDAwMDA6ZmU6 MDAuMTogWzgwODY6MzQ1MV0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOmZlOjAwLjEKWyAgIDEwLjIyNDMzNl0gcGNpIDAwMDA6ZmU6MDAuMjogWzgwODY6 MzQ1Ml0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZl OjAwLjIKWyAgIDEwLjIyNjMzNl0gcGNpIDAwMDA6ZmU6MDAuMzogWzgwODY6MDk5OF0gdHlwZSAw MCBjbGFzcyAweDA2MDAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAwLjMKWyAgIDEw LjIyODMzOF0gcGNpIDAwMDA6ZmU6MDAuNTogWzgwODY6MzQ1NV0gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAwLjUKWyAgIDEwLjIzMDM1Ml0gcGNp IDAwMDA6ZmU6MDIuMDogWzgwODY6MzQ0MF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOmZlOjAyLjAKWyAgIDEwLjIzMjM0Ml0gcGNpIDAwMDA6ZmU6MDIu MTogWzgwODY6MzQ0MV0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOmZlOjAyLjEKWyAgIDEwLjIzNDM0Ml0gcGNpIDAwMDA6ZmU6MDIuMjogWzgwODY6MzQ0 Ml0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAy LjIKWyAgIDEwLjIzNjM1NV0gcGNpIDAwMDA6ZmU6MDMuMDogWzgwODY6MzQ0MF0gdHlwZSAwMCBj bGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAzLjAKWyAgIDEwLjIz ODMzOF0gcGNpIDAwMDA6ZmU6MDMuMTogWzgwODY6MzQ0MV0gdHlwZSAwMCBjbGFzcyAweDA4ODAw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjAzLjEKWyAgIDEwLjI0MDMzOF0gcGNpIDAw MDA6ZmU6MDMuMjogWzgwODY6MzQ0Ml0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOmZlOjAzLjIKWyAgIDEwLjI0MjM2MF0gcGNpIDAwMDA6ZmU6MDQuMDog WzgwODY6MzQ0MF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOmZlOjA0LjAKWyAgIDEwLjI0NDM0Nl0gcGNpIDAwMDA6ZmU6MDQuMTogWzgwODY6MzQ0MV0g dHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA0LjEK WyAgIDEwLjI0NjM0M10gcGNpIDAwMDA6ZmU6MDQuMjogWzgwODY6MzQ0Ml0gdHlwZSAwMCBjbGFz cyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA0LjIKWyAgIDEwLjI0ODM0 OF0gcGNpIDAwMDA6ZmU6MDQuMzogWzgwODY6MzQ0M10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA0LjMKWyAgIDEwLjI1MDM1N10gcGNpIDAwMDA6 ZmU6MDUuMDogWzgwODY6MzQ0NV0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOmZlOjA1LjAKWyAgIDEwLjI1MjM0Ml0gcGNpIDAwMDA6ZmU6MDUuMTogWzgw ODY6MzQ0Nl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAw OmZlOjA1LjEKWyAgIDEwLjI1NDM0NF0gcGNpIDAwMDA6ZmU6MDUuMjogWzgwODY6MzQ0N10gdHlw ZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA1LjIKWyAg IDEwLjI1NjM1NV0gcGNpIDAwMDA6ZmU6MDYuMDogWzgwODY6MzQ0NV0gdHlwZSAwMCBjbGFzcyAw eDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA2LjAKWyAgIDEwLjI1ODMzOF0g cGNpIDAwMDA6ZmU6MDYuMTogWzgwODY6MzQ0Nl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVO KSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA2LjEKWyAgIDEwLjI2MDMzOF0gcGNpIDAwMDA6ZmU6 MDYuMjogWzgwODY6MzQ0N10gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRl dmljZSAwMDAwOmZlOjA2LjIKWyAgIDEwLjI2MjM2MF0gcGNpIDAwMDA6ZmU6MDcuMDogWzgwODY6 MzQ0NV0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZl OjA3LjAKWyAgIDEwLjI2NDM0M10gcGNpIDAwMDA6ZmU6MDcuMTogWzgwODY6MzQ0Nl0gdHlwZSAw MCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA3LjEKWyAgIDEw LjI2NjM0M10gcGNpIDAwMDA6ZmU6MDcuMjogWzgwODY6MzQ0N10gdHlwZSAwMCBjbGFzcyAweDA4 ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjA3LjIKWyAgIDEwLjI2ODM1MV0gcGNp IDAwMDA6ZmU6MGIuMDogWzgwODY6MzQ0OF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQ Q0kgYWRkIGRldmljZSAwMDAwOmZlOjBiLjAKWyAgIDEwLjI3MDMyNV0gcGNpIDAwMDA6ZmU6MGIu MTogWzgwODY6MzQ0OF0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmlj ZSAwMDAwOmZlOjBiLjEKWyAgIDEwLjI3MjMyNF0gcGNpIDAwMDA6ZmU6MGIuMjogWzgwODY6MzQ0 Yl0gdHlwZSAwMCBjbGFzcyAweDA4ODAwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjBi LjIKWyAgIDEwLjI3NDMwMF0gcGNpIDAwMDA6ZmU6MGMuMDogWzgwODY6MzQ0YV0gdHlwZSAwMCBj bGFzcyAweDExMDEwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjBjLjAKWyAgIDEwLjI4 NTM2NF0gcGNpIDAwMDA6ZmU6MGQuMDogWzgwODY6MzQ0YV0gdHlwZSAwMCBjbGFzcyAweDExMDEw MAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjBkLjAKWyAgIDEwLjI5NDM2OF0gcGNpIDAw MDA6ZmU6MGUuMDogWzgwODY6MzQ0YV0gdHlwZSAwMCBjbGFzcyAweDExMDEwMAooWEVOKSBQQ0kg YWRkIGRldmljZSAwMDAwOmZlOjBlLjAKWyAgIDEwLjMwMzM3MF0gcGNpIDAwMDA6ZmU6MGYuMDog WzgwODY6MzQ0YV0gdHlwZSAwMCBjbGFzcyAweDExMDEwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAw MDAwOmZlOjBmLjAKWyAgIDEwLjMxMjM5N10gcGNpIDAwMDA6ZmU6MWEuMDogWzgwODY6Mjg4MF0g dHlwZSAwMCBjbGFzcyAweDExMDEwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjFhLjAK WyAgIDEwLjMyMTM2Ml0gcGNpIDAwMDA6ZmU6MWIuMDogWzgwODY6Mjg4MF0gdHlwZSAwMCBjbGFz cyAweDExMDEwMAooWEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjFiLjAKWyAgIDEwLjMzMDM3 MF0gcGNpIDAwMDA6ZmU6MWMuMDogWzgwODY6Mjg4MF0gdHlwZSAwMCBjbGFzcyAweDExMDEwMAoo WEVOKSBQQ0kgYWRkIGRldmljZSAwMDAwOmZlOjFjLjAKWyAgIDEwLjM0MDM3MV0gcGNpIDAwMDA6 ZmU6MWQuMDogWzgwODY6Mjg4MF0gdHlwZSAwMCBjbGFzcyAweDExMDEwMAooWEVOKSBQQ0kgYWRk IGRldmljZSAwMDAwOmZlOjFkLjAKWyAgIDEwLjM0OTQxMl0gQUNQSTogUENJIFJvb3QgQnJpZGdl IFtVQzE3XSAoZG9tYWluIDAwMDAgW2J1cyBmZl0pClsgICAxMC4zNTUzMDddIGFjcGkgUE5QMEEw MzowMzogX09TQzogT1Mgc3VwcG9ydHMgW0V4dGVuZGVkQ29uZmlnIEFTUE0gQ2xvY2tQTSBTZWdt ZW50cyBNU0kgSFBYLVR5cGUzXQpbICAgMTAuMzY0NDI5XSBhY3BpIFBOUDBBMDM6MDM6IF9PU0M6 IHBsYXRmb3JtIGRvZXMgbm90IHN1cHBvcnQgW0FFUiBMVFJdClsgICAxMC4zNzA1MTFdIGFjcGkg UE5QMEEwMzowMzogX09TQzogT1Mgbm93IGNvbnRyb2xzIFtQQ0llSG90cGx1ZyBQTUUgUENJZUNh cGFiaWxpdHldClsgICAxMC4zNzg0NjJdIFBDSSBob3N0IGJyaWRnZSB0byBidXMgMDAwMDpmZgpb ICAgMTAuMzgyMzA1XSBwY2lfYnVzIDAwMDA6ZmY6IHJvb3QgYnVzIHJlc291cmNlIFtidXMgZmZd ClsgICAxMC4zODczNDNdIHBjaSAwMDAwOmZmOjAwLjA6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xh c3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMC4wClsgICAxMC4zOTYz NDFdIHBjaSAwMDAwOmZmOjAwLjE6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAK KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMC4xClsgICAxMC40MDYzNDNdIHBjaSAwMDAw OmZmOjAwLjI6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFk ZCBkZXZpY2UgMDAwMDpmZjowMC4yClsgICAxMC40MTUzNDBdIHBjaSAwMDAwOmZmOjAwLjM6IFs4 MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDpmZjowMC4zClsgICAxMC40MjQzNDNdIHBjaSAwMDAwOmZmOjAwLjQ6IFs4MDg2OjM0NGNdIHR5 cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMC40Clsg ICAxMC40MzMzNDBdIHBjaSAwMDAwOmZmOjAwLjU6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMC41ClsgICAxMC40NDIzNDVd IHBjaSAwMDAwOmZmOjAwLjY6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMC42ClsgICAxMC40NTEzMzhdIHBjaSAwMDAwOmZm OjAwLjc6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBk ZXZpY2UgMDAwMDpmZjowMC43ClsgICAxMC40NjAzNDBdIHBjaSAwMDAwOmZmOjAxLjA6IFs4MDg2 OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpm ZjowMS4wClsgICAxMC40NjkzNDRdIHBjaSAwMDAwOmZmOjAxLjE6IFs4MDg2OjM0NGNdIHR5cGUg MDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMS4xClsgICAx MC40NzkzMzhdIHBjaSAwMDAwOmZmOjAxLjI6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgw ODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMS4yClsgICAxMC40ODgzNDVdIHBj aSAwMDAwOmZmOjAxLjM6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMS4zClsgICAxMC40OTczNDNdIHBjaSAwMDAwOmZmOjAx LjQ6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDpmZjowMS40ClsgICAxMC41MDYzNDRdIHBjaSAwMDAwOmZmOjAxLjU6IFs4MDg2OjM0 NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjow MS41ClsgICAxMC41MTQzNDldIHBjaSAwMDAwOmZmOjAxLjY6IFs4MDg2OjM0NGNdIHR5cGUgMDAg Y2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMS42ClsgICAxMC41 MjQzNDRdIHBjaSAwMDAwOmZmOjAxLjc6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgw MDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMS43ClsgICAxMC41MzMzNDZdIHBjaSAw MDAwOmZmOjAyLjA6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDpmZjowMi4wClsgICAxMC41NDIzNDRdIHBjaSAwMDAwOmZmOjAyLjE6 IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDpmZjowMi4xClsgICAxMC41NTEzNDVdIHBjaSAwMDAwOmZmOjAyLjI6IFs4MDg2OjM0NGNd IHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMi4y ClsgICAxMC41NjAzNDVdIHBjaSAwMDAwOmZmOjAyLjM6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xh c3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMi4zClsgICAxMC41Njkz NDZdIHBjaSAwMDAwOmZmOjAyLjQ6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAK KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMi40ClsgICAxMC41NzkzNDZdIHBjaSAwMDAw OmZmOjAyLjU6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFk ZCBkZXZpY2UgMDAwMDpmZjowMi41ClsgICAxMC41ODgzNDZdIHBjaSAwMDAwOmZmOjAyLjY6IFs4 MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDpmZjowMi42ClsgICAxMC41OTczNDZdIHBjaSAwMDAwOmZmOjAyLjc6IFs4MDg2OjM0NGNdIHR5 cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMi43Clsg ICAxMC42MDYzNDFdIHBjaSAwMDAwOmZmOjAzLjA6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMy4wClsgICAxMC42MTUzNDNd IHBjaSAwMDAwOmZmOjAzLjE6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowMy4xClsgICAxMC42MjQzNDZdIHBjaSAwMDAwOmZm OjAzLjI6IFs4MDg2OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBk ZXZpY2UgMDAwMDpmZjowMy4yClsgICAxMC42MzMzNDhdIHBjaSAwMDAwOmZmOjAzLjM6IFs4MDg2 OjM0NGNdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpm ZjowMy4zClsgICAxMC42NDMzNzRdIHBjaSAwMDAwOmZmOjBhLjA6IFs4MDg2OjM0NGRdIHR5cGUg MDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYS4wClsgICAx MC42NTIzNDFdIHBjaSAwMDAwOmZmOjBhLjE6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgw ODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYS4xClsgICAxMC42NjEzNDNdIHBj aSAwMDAwOmZmOjBhLjI6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYS4yClsgICAxMC42NzAzNDBdIHBjaSAwMDAwOmZmOjBh LjM6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDpmZjowYS4zClsgICAxMC42NzkzNDRdIHBjaSAwMDAwOmZmOjBhLjQ6IFs4MDg2OjM0 NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjow YS40ClsgICAxMC42ODgzNDBdIHBjaSAwMDAwOmZmOjBhLjU6IFs4MDg2OjM0NGRdIHR5cGUgMDAg Y2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYS41ClsgICAxMC42 OTczNDVdIHBjaSAwMDAwOmZmOjBhLjY6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgw MDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYS42ClsgICAxMC43MDczMzhdIHBjaSAw MDAwOmZmOjBhLjc6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDpmZjowYS43ClsgICAxMC43MTYzMzldIHBjaSAwMDAwOmZmOjBiLjA6 IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDpmZjowYi4wClsgICAxMC43MjUzNDVdIHBjaSAwMDAwOmZmOjBiLjE6IFs4MDg2OjM0NGRd IHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYi4x ClsgICAxMC43MzQzMzhdIHBjaSAwMDAwOmZmOjBiLjI6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xh c3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYi4yClsgICAxMC43NDMz NDZdIHBjaSAwMDAwOmZmOjBiLjM6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAK KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYi4zClsgICAxMC43NTIzNDRdIHBjaSAwMDAw OmZmOjBiLjQ6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFk ZCBkZXZpY2UgMDAwMDpmZjowYi40ClsgICAxMC43NjEzNDRdIHBjaSAwMDAwOmZmOjBiLjU6IFs4 MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDpmZjowYi41ClsgICAxMC43NzAzNDRdIHBjaSAwMDAwOmZmOjBiLjY6IFs4MDg2OjM0NGRdIHR5 cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYi42Clsg ICAxMC43ODAzNDVdIHBjaSAwMDAwOmZmOjBiLjc6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYi43ClsgICAxMC43ODkzNDVd IHBjaSAwMDAwOmZmOjBjLjA6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYy4wClsgICAxMC43OTgzNDRdIHBjaSAwMDAwOmZm OjBjLjE6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBk ZXZpY2UgMDAwMDpmZjowYy4xClsgICAxMC44MDczNDVdIHBjaSAwMDAwOmZmOjBjLjI6IFs4MDg2 OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpm ZjowYy4yClsgICAxMC44MTYzNDVdIHBjaSAwMDAwOmZmOjBjLjM6IFs4MDg2OjM0NGRdIHR5cGUg MDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYy4zClsgICAx MC44MjUzNDhdIHBjaSAwMDAwOmZmOjBjLjQ6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgw ODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYy40ClsgICAxMC44MzQzNDZdIHBj aSAwMDAwOmZmOjBjLjU6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikg UENJIGFkZCBkZXZpY2UgMDAwMDpmZjowYy41ClsgICAxMC44NDQzNDddIHBjaSAwMDAwOmZmOjBj LjY6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZp Y2UgMDAwMDpmZjowYy42ClsgICAxMC44NTMzNDZdIHBjaSAwMDAwOmZmOjBjLjc6IFs4MDg2OjM0 NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjow Yy43ClsgICAxMC44NjIzNDFdIHBjaSAwMDAwOmZmOjBkLjA6IFs4MDg2OjM0NGRdIHR5cGUgMDAg Y2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowZC4wClsgICAxMC44 NzEzNDNdIHBjaSAwMDAwOmZmOjBkLjE6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgw MDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjowZC4xClsgICAxMC44ODAzNTJdIHBjaSAw MDAwOmZmOjBkLjI6IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJ IGFkZCBkZXZpY2UgMDAwMDpmZjowZC4yClsgICAxMC44ODkzNTBdIHBjaSAwMDAwOmZmOjBkLjM6 IFs4MDg2OjM0NGRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2Ug MDAwMDpmZjowZC4zClsgICAxMC44OTk0MTNdIHBjaSAwMDAwOmZmOjFkLjA6IFs4MDg2OjM0NGZd IHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZC4w ClsgICAxMC45MDgzNDNdIHBjaSAwMDAwOmZmOjFkLjE6IFs4MDg2OjM0NTddIHR5cGUgMDAgY2xh c3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZC4xClsgICAxMC45MTcz NDhdIHBjaSAwMDAwOmZmOjFlLjA6IFs4MDg2OjM0NThdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAK KFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZS4wClsgICAxMC45MjYzMjZdIHBjaSAwMDAw OmZmOjFlLjE6IFs4MDg2OjM0NTldIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFk ZCBkZXZpY2UgMDAwMDpmZjoxZS4xClsgICAxMC45MzUzMjZdIHBjaSAwMDAwOmZmOjFlLjI6IFs4 MDg2OjM0NWFdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAw MDpmZjoxZS4yClsgICAxMC45NDQzMjddIHBjaSAwMDAwOmZmOjFlLjM6IFs4MDg2OjM0NWJdIHR5 cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZS4zClsg ICAxMC45NTMzMjZdIHBjaSAwMDAwOmZmOjFlLjQ6IFs4MDg2OjM0NWNdIHR5cGUgMDAgY2xhc3Mg MHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZS40ClsgICAxMC45NjIzMjVd IHBjaSAwMDAwOmZmOjFlLjU6IFs4MDg2OjM0NWRdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhF TikgUENJIGFkZCBkZXZpY2UgMDAwMDpmZjoxZS41ClsgICAxMC45NzEzMjZdIHBjaSAwMDAwOmZm OjFlLjY6IFs4MDg2OjM0NWVdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBk ZXZpY2UgMDAwMDpmZjoxZS42ClsgICAxMC45ODAzMjZdIHBjaSAwMDAwOmZmOjFlLjc6IFs4MDg2 OjM0NWZdIHR5cGUgMDAgY2xhc3MgMHgwODgwMDAKKFhFTikgUENJIGFkZCBkZXZpY2UgMDAwMDpm ZjoxZS43ClsgICAxMC45OTAwNTddIHhlbjpiYWxsb29uOiBJbml0aWFsaXNpbmcgYmFsbG9vbiBk cml2ZXIKWyAgIDExLjcyMTUzMF0gaW9tbXU6IERlZmF1bHQgZG9tYWluIHR5cGU6IFRyYW5zbGF0 ZWQgClsgICAxMS43MjYzMDldIGlvbW11OiBETUEgZG9tYWluIFRMQiBpbnZhbGlkYXRpb24gcG9s aWN5OiBsYXp5IG1vZGUgClsgICAxMS43MzIzOTJdIFNDU0kgc3Vic3lzdGVtIGluaXRpYWxpemVk ClsgICAxMS43MzUzMjFdIEFDUEk6IGJ1cyB0eXBlIFVTQiByZWdpc3RlcmVkClsgICAxMS43NDAz MThdIHVzYmNvcmU6IHJlZ2lzdGVyZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgdXNiZnMKWyAgIDEx Ljc0NTMxMF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgaW50ZXJmYWNlIGRyaXZlciBodWIKWyAg IDExLjc1MDMxMF0gdXNiY29yZTogcmVnaXN0ZXJlZCBuZXcgZGV2aWNlIGRyaXZlciB1c2IKWyAg IDExLjc1NjMzM10gRURBQyBNQzogVmVyOiAzLjAuMApbICAgMTEuNzYxNTA2XSBSZWdpc3RlcmVk IGVmaXZhcnMgb3BlcmF0aW9ucwpbICAgMTEuNzY1NDU5XSBOZXRMYWJlbDogSW5pdGlhbGl6aW5n ClsgICAxMS43NjgzMDZdIE5ldExhYmVsOiAgZG9tYWluIGhhc2ggc2l6ZSA9IDEyOApbICAgMTEu NzczMzA1XSBOZXRMYWJlbDogIHByb3RvY29scyA9IFVOTEFCRUxFRCBDSVBTT3Y0IENBTElQU08K WyAgIDExLjc3ODMxOF0gTmV0TGFiZWw6ICB1bmxhYmVsZWQgdHJhZmZpYyBhbGxvd2VkIGJ5IGRl ZmF1bHQKWyAgIDExLjc4NDMwNV0gUENJOiBVc2luZyBBQ1BJIGZvciBJUlEgcm91dGluZwpbICAg MTEuODE0MzMwXSBwY2kgMDAwMDowMzowMC4wOiB2Z2FhcmI6IHNldHRpbmcgYXMgYm9vdCBWR0Eg ZGV2aWNlClsgICAxMS44MTUzMDBdIHBjaSAwMDAwOjAzOjAwLjA6IHZnYWFyYjogYnJpZGdlIGNv bnRyb2wgcG9zc2libGUKWyAgIDExLjgxNTMwMF0gcGNpIDAwMDA6MDM6MDAuMDogdmdhYXJiOiBW R0EgZGV2aWNlIGFkZGVkOiBkZWNvZGVzPWlvK21lbSxvd25zPW5vbmUsbG9ja3M9bm9uZQpbICAg MTEuODM0MzM5XSB2Z2FhcmI6IGxvYWRlZApbICAgMTEuODM3NDQ2XSBjbG9ja3NvdXJjZTogU3dp dGNoZWQgdG8gY2xvY2tzb3VyY2UgdHNjLWVhcmx5ClsgICAxMS44NDI3NjJdIFZGUzogRGlzayBx dW90YXMgZHF1b3RfNi42LjAKWyAgIDExLjg0NjY0N10gVkZTOiBEcXVvdC1jYWNoZSBoYXNoIHRh YmxlIGVudHJpZXM6IDUxMiAob3JkZXIgMCwgNDA5NiBieXRlcykKWyAgIDExLjg1MzU4MV0gaHVn ZXRsYmZzOiBkaXNhYmxpbmcgYmVjYXVzZSB0aGVyZSBhcmUgbm8gc3VwcG9ydGVkIGh1Z2VwYWdl IHNpemVzClsgICAxMS44NjA4NThdIHBucDogUG5QIEFDUEkgaW5pdApbICAgMTEuODc2OTIzXSBz eXN0ZW0gMDA6MDE6IFtpbyAgMHgwNTAwLTB4MDVmZV0gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgIDEx Ljg4MjY5M10gc3lzdGVtIDAwOjAxOiBbaW8gIDB4MDQwMC0weDA0MWZdIGhhcyBiZWVuIHJlc2Vy dmVkClsgICAxMS44ODg2NjldIHN5c3RlbSAwMDowMTogW2lvICAweDA2MDAtMHgwNjFmXSBoYXMg YmVlbiByZXNlcnZlZApbICAgMTEuODk0NjQ4XSBzeXN0ZW0gMDA6MDE6IFtpbyAgMHgwY2EwLTB4 MGNhMV0gaGFzIGJlZW4gcmVzZXJ2ZWQKWyAgIDExLjkwMDYyOF0gc3lzdGVtIDAwOjAxOiBbaW8g IDB4MGNhNC0weDBjYTZdIGhhcyBiZWVuIHJlc2VydmVkClsgICAxMS45MDY2MDhdIHN5c3RlbSAw MDowMTogW21lbSAweGZmMDAwMDAwLTB4ZmZmZmZmZmZdIGhhcyBiZWVuIHJlc2VydmVkClsgICAx MS45MTM2MzhdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6NApbICAgMTEuOTE3NjM0XSBzeXN0ZW0g MDA6MDQ6IFttZW0gMHhmZDAwMDAwMC0weGZkYWJmZmZmXSBoYXMgYmVlbiByZXNlcnZlZApbICAg MTEuOTI0MDg4XSBzeXN0ZW0gMDA6MDQ6IFttZW0gMHhmZGFkMDAwMC0weGZkYWRmZmZmXSBoYXMg YmVlbiByZXNlcnZlZApbICAgMTEuOTMwNzU5XSBzeXN0ZW0gMDA6MDQ6IFttZW0gMHhmZGIwMDAw MC0weGZkZmZmZmZmXSBoYXMgYmVlbiByZXNlcnZlZApbICAgMTEuOTM3NDMzXSBzeXN0ZW0gMDA6 MDQ6IFttZW0gMHhmZTAwMDAwMC0weGZlMDBmZmZmXSBoYXMgYmVlbiByZXNlcnZlZApbICAgMTEu OTQ0MTA1XSBzeXN0ZW0gMDA6MDQ6IFttZW0gMHhmZTAxMTAwMC0weGZlMDFmZmZmXSBoYXMgYmVl biByZXNlcnZlZApbICAgMTEuOTUwNzc3XSBzeXN0ZW0gMDA6MDQ6IFttZW0gMHhmZTAzNjAwMC0w eGZlMDNiZmZmXSBoYXMgYmVlbiByZXNlcnZlZApbICAgMTEuOTU3NDUwXSBzeXN0ZW0gMDA6MDQ6 IFttZW0gMHhmZTAzZDAwMC0weGZlM2ZmZmZmXSBoYXMgYmVlbiByZXNlcnZlZApbICAgMTEuOTY0 MTIzXSBzeXN0ZW0gMDA6MDQ6IFttZW0gMHhmZTQxMDAwMC0weGZlN2ZmZmZmXSBoYXMgYmVlbiBy ZXNlcnZlZApbICAgMTEuOTcxMjM5XSBzeXN0ZW0gMDA6MDU6IFtpbyAgMHgxMDAwLTB4MTBmZV0g aGFzIGJlZW4gcmVzZXJ2ZWQKWyAgIDExLjk3Nzg4Ml0gcG5wOiBQblAgQUNQSTogZm91bmQgNiBk ZXZpY2VzClsgICAxMS45OTk4MjhdIFBNLVRpbWVyIGZhaWxlZCBjb25zaXN0ZW5jeSBjaGVjayAg KDB4ZmZmZmZmKSAtIGFib3J0aW5nLgpbICAgMTIuMDA2MTU5XSBORVQ6IFJlZ2lzdGVyZWQgUEZf SU5FVCBwcm90b2NvbCBmYW1pbHkKWyAgIDEyLjAxMTI1OV0gSVAgaWRlbnRzIGhhc2ggdGFibGUg ZW50cmllczogMjYyMTQ0IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgMTIu MDIxOTQzXSB0Y3BfbGlzdGVuX3BvcnRhZGRyX2hhc2ggaGFzaCB0YWJsZSBlbnRyaWVzOiA2NTUz NiAob3JkZXI6IDgsIDEwNDg1NzYgYnl0ZXMsIGxpbmVhcikKWyAgIDEyLjAzMDY3OF0gVGFibGUt cGVydHVyYiBoYXNoIHRhYmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjogNiwgMjYyMTQ0IGJ5dGVz LCBsaW5lYXIpClsgICAxMi4wMzg1MTldIFRDUCBlc3RhYmxpc2hlZCBoYXNoIHRhYmxlIGVudHJp ZXM6IDUyNDI4OCAob3JkZXI6IDEwLCA0MTk0MzA0IGJ5dGVzLCBsaW5lYXIpClsgICAxMi4wNDcx MTNdIFRDUCBiaW5kIGhhc2ggdGFibGUgZW50cmllczogNjU1MzYgKG9yZGVyOiA4LCAxMDQ4NTc2 IGJ5dGVzLCBsaW5lYXIpClsgICAxMi4wNTQ0ODBdIFRDUDogSGFzaCB0YWJsZXMgY29uZmlndXJl ZCAoZXN0YWJsaXNoZWQgNTI0Mjg4IGJpbmQgNjU1MzYpClsgICAxMi4wNjEwOTRdIFVEUCBoYXNo IHRhYmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjogOSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpb ICAgMTIuMDY4MzA4XSBVRFAtTGl0ZSBoYXNoIHRhYmxlIGVudHJpZXM6IDY1NTM2IChvcmRlcjog OSwgMjA5NzE1MiBieXRlcywgbGluZWFyKQpbICAgMTIuMDc1ODU5XSBORVQ6IFJlZ2lzdGVyZWQg UEZfVU5JWC9QRl9MT0NBTCBwcm90b2NvbCBmYW1pbHkKWyAgIDEyLjA4MTM3Ml0gcGNpIDAwMDA6 MTc6MDAuMDogY2FuJ3QgY2xhaW0gQkFSIDYgW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJl Zl06IG5vIGNvbXBhdGlibGUgYnJpZGdlIHdpbmRvdwpbICAgMTIuMDkxMzM4XSBwY2kgMDAwMDox NzowMC4xOiBjYW4ndCBjbGFpbSBCQVIgNiBbbWVtIDB4ZmZmODAwMDAtMHhmZmZmZmZmZiBwcmVm XTogbm8gY29tcGF0aWJsZSBicmlkZ2Ugd2luZG93ClsgICAxMi4xMDEzMDRdIHBjaSAwMDAwOmIx OjAwLjA6IGNhbid0IGNsYWltIEJBUiA2IFttZW0gMHhmZmY4MDAwMC0weGZmZmZmZmZmIHByZWZd OiBubyBjb21wYXRpYmxlIGJyaWRnZSB3aW5kb3cKWyAgIDEyLjExMTI2MV0gcGNpIDAwMDA6YjE6 MDAuMTogY2FuJ3QgY2xhaW0gQkFSIDYgW21lbSAweGZmZjgwMDAwLTB4ZmZmZmZmZmYgcHJlZl06 IG5vIGNvbXBhdGlibGUgYnJpZGdlIHdpbmRvdwpbICAgMTIuMTIxMjMyXSBwY2kgMDAwMDpjYTow MC4wOiBjYW4ndCBjbGFpbSBCQVIgNiBbbWVtIDB4ZmZmMDAwMDAtMHhmZmZmZmZmZiBwcmVmXTog bm8gY29tcGF0aWJsZSBicmlkZ2Ugd2luZG93ClsgICAxMi4xMzEyMTNdIHBjaSAwMDAwOjAwOjFj LjA6IFBDSSBicmlkZ2UgdG8gW2J1cyAwMV0KWyAgIDEyLjEzNjIzNF0gcGNpIDAwMDA6MDA6MWMu MDogICBicmlkZ2Ugd2luZG93IFtpbyAgMHgzMDAwLTB4M2ZmZl0KWyAgIDEyLjE0MjM5N10gcGNp IDAwMDA6MDA6MWMuMDogICBicmlkZ2Ugd2luZG93IFttZW0gMHg5MjEwMDAwMC0weDkyMWZmZmZm XQpbICAgMTIuMTQ5MjUyXSBwY2kgMDAwMDowMjowMC4wOiBQQ0kgYnJpZGdlIHRvIFtidXMgMDNd ClsgICAxMi4xNTQyNThdIHBjaSAwMDAwOjAyOjAwLjA6ICAgYnJpZGdlIHdpbmRvdyBbaW8gIDB4 MjAwMC0weDJmZmZdClsgICAxMi4xNjA0MjRdIHBjaSAwMDAwOjAyOjAwLjA6ICAgYnJpZGdlIHdp bmRvdyBbbWVtIDB4OTEwMDAwMDAtMHg5MjBmZmZmZl0KWyAgIDEyLjE2NzI3N10gcGNpIDAwMDA6 MDA6MWMuNTogUENJIGJyaWRnZSB0byBbYnVzIDAyLTAzXQpbICAgMTIuMTcyNTQ3XSBwY2kgMDAw MDowMDoxYy41OiAgIGJyaWRnZSB3aW5kb3cgW2lvICAweDIwMDAtMHgyZmZmXQpbICAgMTIuMTc4 Njk2XSBwY2kgMDAwMDowMDoxYy41OiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDkxMDAwMDAwLTB4 OTIwZmZmZmZdClsgICAxMi4xODU1NTRdIHBjaV9idXMgMDAwMDowMDogcmVzb3VyY2UgNCBbaW8g IDB4MDAwMC0weDBjZjcgd2luZG93XQpbICAgMTIuMTkxNzc1XSBwY2lfYnVzIDAwMDA6MDA6IHJl c291cmNlIDUgW2lvICAweDEwMDAtMHg0ZmZmIHdpbmRvd10KWyAgIDEyLjE5ODAxNV0gcGNpX2J1 cyAwMDAwOjAwOiByZXNvdXJjZSA2IFttZW0gMHgwMDBhMDAwMC0weDAwMGJmZmZmIHdpbmRvd10K WyAgIDEyLjIwNDk0OF0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA3IFttZW0gMHgwMDBjODAw MC0weDAwMGNmZmZmIHdpbmRvd10KWyAgIDEyLjIxMTg4MF0gcGNpX2J1cyAwMDAwOjAwOiByZXNv dXJjZSA4IFttZW0gMHhmZTAxMDAwMC0weGZlMDEwZmZmIHdpbmRvd10KWyAgIDEyLjIxODgwNV0g cGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSA5IFttZW0gMHg5MDAwMDAwMC0weDliN2ZmZmZmIHdp bmRvd10KWyAgIDEyLjIyNTc0Nl0gcGNpX2J1cyAwMDAwOjAwOiByZXNvdXJjZSAxMCBbbWVtIDB4 MjAwMDAwMDAwMDAwLTB4MjAwZmZmZmZmZmZmIHdpbmRvd10KWyAgIDEyLjIzMzQ1MV0gcGNpX2J1 cyAwMDAwOjAxOiByZXNvdXJjZSAwIFtpbyAgMHgzMDAwLTB4M2ZmZl0KWyAgIDEyLjIzOTA4MV0g cGNpX2J1cyAwMDAwOjAxOiByZXNvdXJjZSAxIFttZW0gMHg5MjEwMDAwMC0weDkyMWZmZmZmXQpb ICAgMTIuMjQ1NDEwXSBwY2lfYnVzIDAwMDA6MDI6IHJlc291cmNlIDAgW2lvICAweDIwMDAtMHgy ZmZmXQpbICAgMTIuMjUxMDQ3XSBwY2lfYnVzIDAwMDA6MDI6IHJlc291cmNlIDEgW21lbSAweDkx MDAwMDAwLTB4OTIwZmZmZmZdClsgICAxMi4yNTczNjldIHBjaV9idXMgMDAwMDowMzogcmVzb3Vy Y2UgMCBbaW8gIDB4MjAwMC0weDJmZmZdClsgICAxMi4yNjMwMDJdIHBjaV9idXMgMDAwMDowMzog cmVzb3VyY2UgMSBbbWVtIDB4OTEwMDAwMDAtMHg5MjBmZmZmZl0KWyAgIDEyLjI2OTQzMl0gcGNp IDAwMDA6MTc6MDAuMDogQkFSIDY6IG5vIHNwYWNlIGZvciBbbWVtIHNpemUgMHgwMDA4MDAwMCBw cmVmXQpbICAgMTIuMjc2NDUxXSBwY2kgMDAwMDoxNzowMC4wOiBCQVIgNjogZmFpbGVkIHRvIGFz c2lnbiBbbWVtIHNpemUgMHgwMDA4MDAwMCBwcmVmXQpbICAgMTIuMjgzODk1XSBwY2kgMDAwMDox NzowMC4xOiBCQVIgNjogbm8gc3BhY2UgZm9yIFttZW0gc2l6ZSAweDAwMDgwMDAwIHByZWZdClsg ICAxMi4yOTA5OTJdIHBjaSAwMDAwOjE3OjAwLjE6IEJBUiA2OiBmYWlsZWQgdG8gYXNzaWduIFtt ZW0gc2l6ZSAweDAwMDgwMDAwIHByZWZdClsgICAxMi4yOTg0NTNdIHBjaSAwMDAwOjE2OjAyLjA6 IFBDSSBicmlkZ2UgdG8gW2J1cyAxNy0xOF0KWyAgIDEyLjMwMzc0OV0gcGNpIDAwMDA6MTY6MDIu MDogICBicmlkZ2Ugd2luZG93IFttZW0gMHg5YjgwMDAwMC0weDliYmZmZmZmXQpbICAgMTIuMzEw NTg5XSBwY2kgMDAwMDoxNjowMi4wOiAgIGJyaWRnZSB3aW5kb3cgW21lbSAweDIwMWZmZjQwMDAw MC0weDIwMWZmZmNmZmZmZiA2NGJpdCBwcmVmXQpbICAgMTIuMzE5MDg0XSBwY2lfYnVzIDAwMDA6 MTY6IHJlc291cmNlIDQgW2lvICAweDUwMDAtMHg2ZmZmIHdpbmRvd10KWyAgIDEyLjMyNTMxNl0g cGNpX2J1cyAwMDAwOjE2OiByZXNvdXJjZSA1IFttZW0gMHg5YjgwMDAwMC0weGE2M2ZmZmZmIHdp bmRvd10KWyAgIDEyLjMzMjI1MF0gcGNpX2J1cyAwMDAwOjE2OiByZXNvdXJjZSA2IFttZW0gMHgy MDEwMDAwMDAwMDAtMHgyMDFmZmZmZmZmZmYgd2luZG93XQpbICAgMTIuMzM5ODc1XSBwY2lfYnVz IDAwMDA6MTc6IHJlc291cmNlIDEgW21lbSAweDliODAwMDAwLTB4OWJiZmZmZmZdClsgICAxMi4z NDYxOTldIHBjaV9idXMgMDAwMDoxNzogcmVzb3VyY2UgMiBbbWVtIDB4MjAxZmZmNDAwMDAwLTB4 MjAxZmZmY2ZmZmZmIDY0Yml0IHByZWZdClsgICAxMi4zNTQyODVdIHBjaV9idXMgMDAwMDozMDog cmVzb3VyY2UgNCBbaW8gIDB4NzAwMC0weDhmZmYgd2luZG93XQpbICAgMTIuMzYwNDIxXSBwY2lf YnVzIDAwMDA6MzA6IHJlc291cmNlIDUgW21lbSAweGE2NDAwMDAwLTB4YjBmZmZmZmYgd2luZG93 XQpbICAgMTIuMzY3MzQxXSBwY2lfYnVzIDAwMDA6MzA6IHJlc291cmNlIDYgW21lbSAweDIwMjAw MDAwMDAwMC0weDIwMmZmZmZmZmZmZiB3aW5kb3ddClsgICAxMi4zNzQ5ODVdIHBjaV9idXMgMDAw MDo0YTogcmVzb3VyY2UgNCBbaW8gIDB4OTAwMC0weDlmZmYgd2luZG93XQpbICAgMTIuMzgxMjA1 XSBwY2lfYnVzIDAwMDA6NGE6IHJlc291cmNlIDUgW21lbSAweGIxMDAwMDAwLTB4YmJiZmZmZmYg d2luZG93XQpbICAgMTIuMzg4MTQxXSBwY2lfYnVzIDAwMDA6NGE6IHJlc291cmNlIDYgW21lbSAw eDIwMzAwMDAwMDAwMC0weDIwM2ZmZmZmZmZmZiB3aW5kb3ddClsgICAxMi4zOTU3ODJdIHBjaV9i dXMgMDAwMDo2NDogcmVzb3VyY2UgNCBbaW8gIDB4YTAwMC0weGFmZmYgd2luZG93XQpbICAgMTIu NDAyMDAzXSBwY2lfYnVzIDAwMDA6NjQ6IHJlc291cmNlIDUgW21lbSAweGJiYzAwMDAwLTB4YzVm ZmZmZmYgd2luZG93XQpbICAgMTIuNDA4OTM3XSBwY2lfYnVzIDAwMDA6NjQ6IHJlc291cmNlIDYg W21lbSAweDIwNDAwMDAwMDAwMC0weDIwNGZmZmZmZmZmZiB3aW5kb3ddClsgICAxMi40MTY2MDZd IHBjaV9idXMgMDAwMDo4MDogcmVzb3VyY2UgNCBbaW8gIDB4YjAwMC0weGJmZmYgd2luZG93XQpb ICAgMTIuNDIyODAxXSBwY2lfYnVzIDAwMDA6ODA6IHJlc291cmNlIDUgW21lbSAweGM2ODAwMDAw LTB4ZDBmZmZmZmYgd2luZG93XQpbICAgMTIuNDI5NzM1XSBwY2lfYnVzIDAwMDA6ODA6IHJlc291 cmNlIDYgW21lbSAweDIwNTAwMDAwMDAwMC0weDIwNWZmZmZmZmZmZiB3aW5kb3ddClsgICAxMi40 MzczNjddIHBjaV9idXMgMDAwMDo5NzogcmVzb3VyY2UgNCBbaW8gIDB4YzAwMC0weGNmZmYgd2lu ZG93XQpbICAgMTIuNDQzNTk5XSBwY2lfYnVzIDAwMDA6OTc6IHJlc291cmNlIDUgW21lbSAweGQx MDAwMDAwLTB4ZGJiZmZmZmYgd2luZG93XQpbICAgMTIuNDUwNTMzXSBwY2lfYnVzIDAwMDA6OTc6 IHJlc291cmNlIDYgW21lbSAweDIwNjAwMDAwMDAwMC0weDIwNmZmZmZmZmZmZiB3aW5kb3ddClsg ICAxMi40NTgxODFdIHBjaSAwMDAwOmIwOjAyLjA6IEJBUiAxNDogYXNzaWduZWQgW21lbSAweGRi YzAwMDAwLTB4ZGJjZmZmZmZdClsgICAxMi40NjUwOTJdIHBjaSAwMDAwOmIxOjAwLjA6IEJBUiA2 OiBhc3NpZ25lZCBbbWVtIDB4ZGJjMDAwMDAtMHhkYmM3ZmZmZiBwcmVmXQpbICAgMTIuNDcyMzcy XSBwY2kgMDAwMDpiMTowMC4xOiBCQVIgNjogYXNzaWduZWQgW21lbSAweGRiYzgwMDAwLTB4ZGJj ZmZmZmYgcHJlZl0KWyAgIDEyLjQ3OTY1Ml0gcGNpIDAwMDA6YjA6MDIuMDogUENJIGJyaWRnZSB0 byBbYnVzIGIxLWIyXQpbICAgMTIuNDg0OTQ4XSBwY2kgMDAwMDpiMDowMi4wOiAgIGJyaWRnZSB3 aW5kb3cgW21lbSAweGRiYzAwMDAwLTB4ZGJjZmZmZmZdClsgICAxMi40OTE3OTBdIHBjaSAwMDAw OmIwOjAyLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVtIDB4MjA3ZmZlMDAwMDAwLTB4MjA3ZmZmYWZm ZmZmIDY0Yml0IHByZWZdClsgICAxMi41MDAyOTBdIHBjaV9idXMgMDAwMDpiMDogcmVzb3VyY2Ug NCBbaW8gIDB4ZDAwMC0weGRmZmYgd2luZG93XQpbICAgMTIuNTA2NTE0XSBwY2lfYnVzIDAwMDA6 YjA6IHJlc291cmNlIDUgW21lbSAweGRiYzAwMDAwLTB4ZTY3ZmZmZmYgd2luZG93XQpbICAgMTIu NTEzNDQ5XSBwY2lfYnVzIDAwMDA6YjA6IHJlc291cmNlIDYgW21lbSAweDIwNzAwMDAwMDAwMC0w eDIwN2ZmZmZmZmZmZiB3aW5kb3ddClsgICAxMi41MjEwNzVdIHBjaV9idXMgMDAwMDpiMTogcmVz b3VyY2UgMSBbbWVtIDB4ZGJjMDAwMDAtMHhkYmNmZmZmZl0KWyAgIDEyLjUyNzQwMV0gcGNpX2J1 cyAwMDAwOmIxOiByZXNvdXJjZSAyIFttZW0gMHgyMDdmZmUwMDAwMDAtMHgyMDdmZmZhZmZmZmYg NjRiaXQgcHJlZl0KWyAgIDEyLjUzNTM5Ml0gcGNpIDAwMDA6Y2E6MDAuMDogQkFSIDY6IG5vIHNw YWNlIGZvciBbbWVtIHNpemUgMHgwMDEwMDAwMCBwcmVmXQpbICAgMTIuNTQyNDgwXSBwY2kgMDAw MDpjYTowMC4wOiBCQVIgNjogZmFpbGVkIHRvIGFzc2lnbiBbbWVtIHNpemUgMHgwMDEwMDAwMCBw cmVmXQpbICAgMTIuNTQ5OTMxXSBwY2kgMDAwMDpjOTowMi4wOiBQQ0kgYnJpZGdlIHRvIFtidXMg Y2FdClsgICAxMi41NTQ5NjhdIHBjaSAwMDAwOmM5OjAyLjA6ICAgYnJpZGdlIHdpbmRvdyBbbWVt IDB4ZTY4MDAwMDAtMHhlNjlmZmZmZl0KWyAgIDEyLjU2MTgyNF0gcGNpX2J1cyAwMDAwOmM5OiBy ZXNvdXJjZSA0IFtpbyAgMHhlMDAwLTB4ZWZmZiB3aW5kb3ddClsgICAxMi41NjgwNDRdIHBjaV9i dXMgMDAwMDpjOTogcmVzb3VyY2UgNSBbbWVtIDB4ZTY4MDAwMDAtMHhmMTNmZmZmZiB3aW5kb3dd ClsgICAxMi41NzQ5NzZdIHBjaV9idXMgMDAwMDpjOTogcmVzb3VyY2UgNiBbbWVtIDB4MjA4MDAw MDAwMDAwLTB4MjA4ZmZmZmZmZmZmIHdpbmRvd10KWyAgIDEyLjU4MjYwM10gcGNpX2J1cyAwMDAw OmNhOiByZXNvdXJjZSAxIFttZW0gMHhlNjgwMDAwMC0weGU2OWZmZmZmXQpbICAgMTIuNTg4OTQ0 XSBwY2lfYnVzIDAwMDA6ZTI6IHJlc291cmNlIDQgW2lvICAweGYwMDAtMHhmZmZmIHdpbmRvd10K WyAgIDEyLjU5NTE3MV0gcGNpX2J1cyAwMDAwOmUyOiByZXNvdXJjZSA1IFttZW0gMHhmMTQwMDAw MC0weGZiN2ZmZmZmIHdpbmRvd10KWyAgIDEyLjYwMjEwMV0gcGNpX2J1cyAwMDAwOmUyOiByZXNv dXJjZSA2IFttZW0gMHgyMDkwMDAwMDAwMDAtMHgyMDlmZmZmZmZmZmYgd2luZG93XQpbICAgMTIu NjEwMjg4XSBwY2kgMDAwMDoxNzowMC4wOiBDTFMgbWlzbWF0Y2ggKDEyOCAhPSAzMiksIHVzaW5n IDY0IGJ5dGVzClsgICAxMi42MTY4MjRdIFBDSS1ETUE6IFVzaW5nIHNvZnR3YXJlIGJvdW5jZSBi dWZmZXJpbmcgZm9yIElPIChTV0lPVExCKQpbICAgMTIuNjE2ODc1XSBUKFhFTikgYXJjaC94ODYv cHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2MzkgdW5pbXBsZW1lbnRl ZApyeWluZyB0byB1bnBhY2sgKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpk MHYxIFJETVNSIDB4MDAwMDA2MTEgdW5pbXBsZW1lbnRlZApyb290ZnMgaW1hZ2UgYXMgKFhFTikg YXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2MTkgdW5p bXBsZW1lbnRlZAppbml0cmFtZnMuLi4KKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6 MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2MDYgdW5pbXBsZW1lbnRlZApbICAgMTIuNjIzMTU5XSBz KFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2 NGUgdW5pbXBsZW1lbnRlZApvZnR3YXJlIElPIFRMQjogKFhFTikgYXJjaC94ODYvcHYvZW11bC1w cml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDAwMzQgdW5pbXBsZW1lbnRlZAptYXBwZWQg W21lbSAweDAwMDAwMDAyODlhMDAwMDAtMHgwMDAwMDAwMjhkYTAwMDAwXSAoNjRNQikKWyAgIDEy LjY3MDM5Nl0gY2xvY2tzb3VyY2U6IHRzYzogbWFzazogMHhmZmZmZmZmZmZmZmZmZmZmIG1heF9j eWNsZXM6IDB4MjI4Mzc0ZGFlNWQsIG1heF9pZGxlX25zOiA0NDA3OTUyNjgzNTIgbnMKWyAgIDEy LjY4NTg4MV0gY2xvY2tzb3VyY2U6IFN3aXRjaGVkIHRvIGNsb2Nrc291cmNlIHRzYwpbICAgMTIu NzE2MjkwXSBJbml0aWFsaXNlIHN5c3RlbSB0cnVzdGVkIGtleXJpbmdzClsgICAxMi43MjA3MDZd IHdvcmtpbmdzZXQ6IHRpbWVzdGFtcF9iaXRzPTM2IG1heF9vcmRlcj0yMSBidWNrZXRfb3JkZXI9 MApbICAgMTIuNzI4MjU2XSB6YnVkOiBsb2FkZWQKWyAgIDEyLjc0MzE1OV0gTkVUOiBSZWdpc3Rl cmVkIFBGX0FMRyBwcm90b2NvbCBmYW1pbHkKWyAgIDEyLjc0NzgwMF0gS2V5IHR5cGUgYXN5bW1l dHJpYyByZWdpc3RlcmVkClsgICAxMi43NTE5NTVdIEFzeW1tZXRyaWMga2V5IHBhcnNlciAneDUw OScgcmVnaXN0ZXJlZApbICAgMTIuNzU2OTA4XSBCbG9jayBsYXllciBTQ1NJIGdlbmVyaWMgKGJz ZykgZHJpdmVyIHZlcnNpb24gMC40IGxvYWRlZCAobWFqb3IgMjUxKQpbICAgMTIuNzY0NDI1XSBp byBzY2hlZHVsZXIgbXEtZGVhZGxpbmUgcmVnaXN0ZXJlZApbICAgMTIuNzY4OTQyXSBpbyBzY2hl ZHVsZXIga3liZXIgcmVnaXN0ZXJlZApbICAgMTIuNzc0Mzc3XSBhdG9taWM2NF90ZXN0OiBwYXNz ZWQgZm9yIHg4Ni02NCBwbGF0Zm9ybSB3aXRoIENYOCBhbmQgd2l0aCBTU0UKWyAgIDEyLjc4MTU3 MF0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpbICAgMTIuNzg1MzEyXSBwY2llcG9ydCAwMDAw OjAwOjFjLjA6IFBNRTogU2lnbmFsaW5nIHdpdGggSVJRIDE3OApbICAgMTIuNzkxNDM2XSBwY2ll cG9ydCAwMDAwOjAwOjFjLjU6IFBNRTogU2lnbmFsaW5nIHdpdGggSVJRIDE3OQpbICAgMTIuNzk3 NDY4XSBwY2llcG9ydCAwMDAwOjE2OjAyLjA6IFBNRTogU2lnbmFsaW5nIHdpdGggSVJRIDE4MApb ICAgMTIuODAzMzE2XSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE4ClsgICAxMi44MDY5OTBdIHBj aWVwb3J0IDAwMDA6YjA6MDIuMDogUE1FOiBTaWduYWxpbmcgd2l0aCBJUlEgMTgxClsgICAxMi44 MTI5MjVdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTgKWyAgIDEyLjgxNjYxMF0gcGNpZXBvcnQg MDAwMDpjOTowMi4wOiBQTUU6IFNpZ25hbGluZyB3aXRoIElSUSAxODIKWyAgIDEyLjgyMjg4MV0g QUNQSTogXF9TQl8uU0NLMC5DMDAwOiBGb3VuZCAyIGlkbGUgc3RhdGVzClsgICAxMi44MjgyOTVd IGlucHV0OiBQb3dlciBCdXR0b24gYXMgL2RldmljZXMvTE5YU1lTVE06MDAvTE5YUFdSQk46MDAv aW5wdXQvaW5wdXQwClsgICAxMi44MzU1OTJdIEFDUEk6IGJ1dHRvbjogUG93ZXIgQnV0dG9uIFtQ V1JGXQpbICAgMTIuODQwMTc0XSBBQ1BJOiBcX1NCXy5TQ0swLkMwMDA6IEZvdW5kIDIgaWRsZSBz dGF0ZXMKWyAgIDEyLjg0NTM2Nl0gQUNQSTogXF9TQl8uU0NLMC5DMDAxOiBGb3VuZCAyIGlkbGUg c3RhdGVzClsgICAxMi44NTA2NjZdIEFDUEk6IFxfU0JfLlNDSzAuQzAwMjogRm91bmQgMiBpZGxl IHN0YXRlcwpbICAgMTIuODU1OTEyXSBBQ1BJOiBcX1NCXy5TQ0swLkMwMDM6IEZvdW5kIDIgaWRs ZSBzdGF0ZXMKWyAgIDEyLjg4MDUzN10gQUNQSTogXF9TQl8uU0NLMC5DMDA0OiBGb3VuZCAyIGlk bGUgc3RhdGVzClsgICAxMi44ODk1MzFdIEFDUEk6IFxfU0JfLlNDSzAuQzAwNTogRm91bmQgMiBp ZGxlIHN0YXRlcwpbICAgMTIuODk0ODI4XSBBQ1BJOiBcX1NCXy5TQ0swLkMwMDY6IEZvdW5kIDIg aWRsZSBzdGF0ZXMKWyAgIDEyLjkwMDA0NF0gQUNQSTogXF9TQl8uU0NLMC5DMDA3OiBGb3VuZCAy IGlkbGUgc3RhdGVzClsgICAxMi45MDU4ODFdIEVSU1Q6IEVycm9yIFJlY29yZCBTZXJpYWxpemF0 aW9uIFRhYmxlIChFUlNUKSBzdXBwb3J0IGlzIGluaXRpYWxpemVkLgpbICAgMTIuOTEzMjAxXSBw c3RvcmU6IFJlZ2lzdGVyZWQgZXJzdCBhcyBwZXJzaXN0ZW50IHN0b3JlIGJhY2tlbmQKWyAgIDEy LjkxOTQ5MV0geGVuOnhlbl9ldnRjaG46IEV2ZW50LWNoYW5uZWwgZGV2aWNlIGluc3RhbGxlZApb ICAgMTIuOTI0OTAyXSB4ZW5fcGNpYmFjazogYmFja2VuZCBpcyB2cGNpClsgICAxMi45MjkyODVd IFNlcmlhbDogODI1MC8xNjU1MCBkcml2ZXIsIDQgcG9ydHMsIElSUSBzaGFyaW5nIGVuYWJsZWQK WyAgIDEyLjkzNTU3MV0gMDA6MDM6IHR0eVMxIGF0IEkvTyAweDJmOCAoaXJxID0gMywgYmFzZV9i YXVkID0gMTE1MjAwKSBpcyBhIDE2NTUwQQooWEVOKSBkMDogRm9yY2luZyByZWFkLW9ubHkgYWNj ZXNzIHRvIE1GTiBmZWQwMApbICAgMTIuOTQ3NDY4XSBocGV0X2FjcGlfYWRkOiBubyBhZGRyZXNz IG9yIGlycXMgaW4gX0NSUwpbICAgMTIuOTUyNjYwXSBOb24tdm9sYXRpbGUgbWVtb3J5IGRyaXZl ciB2MS4zClsgICAxMi45NTY4MTZdIExpbnV4IGFncGdhcnQgaW50ZXJmYWNlIHYwLjEwMwpbICAg MTIuOTY1NjAzXSB0cG1fdGlzIElGWDA3NDA6MDA6IDIuMCBUUE0gKGRldmljZS1pZCAweDFCLCBy ZXYtaWQgMTYpClsgICAxMi45NzU1MDhdIHRwbSB0cG0wOiBbRmlybXdhcmUgQnVnXTogVFBNIGlu dGVycnVwdCBub3Qgd29ya2luZywgcG9sbGluZyBpbnN0ZWFkClsgICAxMy4wMDc2NjldIHJkYWM6 IGRldmljZSBoYW5kbGVyIHJlZ2lzdGVyZWQKWyAgIDEzLjAxMTc4MV0gaHBfc3c6IGRldmljZSBo YW5kbGVyIHJlZ2lzdGVyZWQKWyAgIDEzLjAxNjAzMV0gZW1jOiBkZXZpY2UgaGFuZGxlciByZWdp c3RlcmVkClsgICAxMy4wMjAyOTldIGFsdWE6IGRldmljZSBoYW5kbGVyIHJlZ2lzdGVyZWQKWyAg IDEzLjAyNDU4N10gZWhjaV9oY2Q6IFVTQiAyLjAgJ0VuaGFuY2VkJyBIb3N0IENvbnRyb2xsZXIg KEVIQ0kpIERyaXZlcgpbICAgMTMuMDMxMDI3XSBlaGNpLXBjaTogRUhDSSBQQ0kgcGxhdGZvcm0g ZHJpdmVyClsgICAxMy4wMzU1NjNdIG9oY2lfaGNkOiBVU0IgMS4xICdPcGVuJyBIb3N0IENvbnRy b2xsZXIgKE9IQ0kpIERyaXZlcgpbICAgMTMuMDQxNzczXSBvaGNpLXBjaTogT0hDSSBQQ0kgcGxh dGZvcm0gZHJpdmVyClsgICAxMy4wNDYzMDFdIHVoY2lfaGNkOiBVU0IgVW5pdmVyc2FsIEhvc3Qg Q29udHJvbGxlciBJbnRlcmZhY2UgZHJpdmVyClsgICAxMy4wNTI4MTZdIEFscmVhZHkgc2V0dXAg dGhlIEdTSSA6MTYKWyAgIDEzLjA1NjUxOF0geGhjaV9oY2QgMDAwMDowMDoxNC4wOiB4SENJIEhv c3QgQ29udHJvbGxlcgpbICAgMTMuMDYxNzU1XSB4aGNpX2hjZCAwMDAwOjAwOjE0LjA6IG5ldyBV U0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1iZXIgMQpbICAgMTMuMDcwMjUyXSB4 aGNpX2hjZCAwMDAwOjAwOjE0LjA6IGhjYyBwYXJhbXMgMHgyMDAwNzdjMSBoY2kgdmVyc2lvbiAw eDEwMCBxdWlya3MgMHgwMDAwMDAwMDAwMDA5ODEwClsgICAxMy4wNzk2NTNdIHhoY2lfaGNkIDAw MDA6MDA6MTQuMDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDEzLjA4NDc2M10geGhjaV9oY2Qg MDAwMDowMDoxNC4wOiBuZXcgVVNCIGJ1cyByZWdpc3RlcmVkLCBhc3NpZ25lZCBidXMgbnVtYmVy IDIKWyAgIDEzLjA5MjE3Nl0geGhjaV9oY2QgMDAwMDowMDoxNC4wOiBIb3N0IHN1cHBvcnRzIFVT QiAzLjAgU3VwZXJTcGVlZApbICAgMTMuMDk4NjQ5XSB1c2IgdXNiMTogTmV3IFVTQiBkZXZpY2Ug Zm91bmQsIGlkVmVuZG9yPTFkNmIsIGlkUHJvZHVjdD0wMDAyLCBiY2REZXZpY2U9IDUuMTkKWyAg IDEzLjEwNjgxN10gdXNiIHVzYjE6IE5ldyBVU0IgZGV2aWNlIHN0cmluZ3M6IE1mcj0zLCBQcm9k dWN0PTIsIFNlcmlhbE51bWJlcj0xClsgICAxMy4xMTQwOTVdIHVzYiB1c2IxOiBQcm9kdWN0OiB4 SENJIEhvc3QgQ29udHJvbGxlcgpbICAgMTMuMTE5MDMyXSB1c2IgdXNiMTogTWFudWZhY3R1cmVy OiBMaW51eCA1LjE5LjAtcmM2IHhoY2ktaGNkClsgICAxMy4xMjQ4MzldIHVzYiB1c2IxOiBTZXJp YWxOdW1iZXI6IDAwMDA6MDA6MTQuMApbICAgMTMuMTI5NjczXSBodWIgMS0wOjEuMDogVVNCIGh1 YiBmb3VuZApbICAgMTMuMTMzMzg0XSBodWIgMS0wOjEuMDogMTYgcG9ydHMgZGV0ZWN0ZWQKWyAg IDEzLjE0MDUyNF0gdXNiIHVzYjI6IE5ldyBVU0IgZGV2aWNlIGZvdW5kLCBpZFZlbmRvcj0xZDZi LCBpZFByb2R1Y3Q9MDAwMywgYmNkRGV2aWNlPSA1LjE5ClsgICAxMy4xNDMxNTddIEZyZWVpbmcg aW5pdHJkIG1lbW9yeTogMjgzMDRLClsgICAxMy4xNDg2MjldIHVzYiB1c2IyOiBOZXcgVVNCIGRl dmljZSBzdHJpbmdzOiBNZnI9MywgUHJvZHVjdD0yLCBTZXJpYWxOdW1iZXI9MQpbICAgMTMuMTU5 OTg4XSB1c2IgdXNiMjogUHJvZHVjdDogeEhDSSBIb3N0IENvbnRyb2xsZXIKWyAgIDEzLjE2NDkx N10gdXNiIHVzYjI6IE1hbnVmYWN0dXJlcjogTGludXggNS4xOS4wLXJjNiB4aGNpLWhjZApbICAg MTMuMTcwNzI2XSB1c2IgdXNiMjogU2VyaWFsTnVtYmVyOiAwMDAwOjAwOjE0LjAKWyAgIDEzLjE3 NTU0N10gaHViIDItMDoxLjA6IFVTQiBodWIgZm91bmQKWyAgIDEzLjE3OTI1NF0gaHViIDItMDox LjA6IDEwIHBvcnRzIGRldGVjdGVkClsgICAxMy4xODQ0ODNdIHVzYjogcG9ydCBwb3dlciBtYW5h Z2VtZW50IG1heSBiZSB1bnJlbGlhYmxlClsgICAxMy4xOTA0NDVdIHVzYmNvcmU6IHJlZ2lzdGVy ZWQgbmV3IGludGVyZmFjZSBkcml2ZXIgdXNic2VyaWFsX2dlbmVyaWMKWyAgIDEzLjE5NjgxN10g dXNic2VyaWFsOiBVU0IgU2VyaWFsIHN1cHBvcnQgcmVnaXN0ZXJlZCBmb3IgZ2VuZXJpYwpbICAg MTMuMjAyODg4XSBpODA0MjogUE5QOiBObyBQUy8yIGNvbnRyb2xsZXIgZm91bmQuClsgICAxMy4y MDc2OTBdIG1vdXNlZGV2OiBQUy8yIG1vdXNlIGRldmljZSBjb21tb24gZm9yIGFsbCBtaWNlClsg ICAxMy4yMTMzNzhdIHJ0Y19jbW9zIDAwOjAwOiBSVEMgY2FuIHdha2UgZnJvbSBTNApbICAgMTMu MjE4NjAzXSBydGNfY21vcyAwMDowMDogcmVnaXN0ZXJlZCBhcyBydGMwClsgICAxMy4yMjMwMTBd IHJ0Y19jbW9zIDAwOjAwOiBzZXR0aW5nIHN5c3RlbSBjbG9jayB0byAyMDIyLTA3LTIxVDA1OjUz OjMyIFVUQyAoMTY1ODM4MjgxMikKWyAgIDEzLjIzMTA1Ml0gcnRjX2Ntb3MgMDA6MDA6IGFsYXJt cyB1cCB0byBvbmUgbW9udGgsIHkzaywgMTE0IGJ5dGVzIG52cmFtClsgICAxMy4yMzc4MDddIGlu dGVsX3BzdGF0ZTogQ1BVIG1vZGVsIG5vdCBzdXBwb3J0ZWQKWyAgIDEzLjI0MzM0MF0gZWZpZmI6 IHByb2JpbmcgZm9yIGVmaWZiClsgICAxMy4yNDc4NTNdIGVmaWZiOiBmcmFtZWJ1ZmZlciBhdCAw eDkxMDAwMDAwLCB1c2luZyAzMDcyaywgdG90YWwgMzA3MmsKWyAgIDEzLjI1NDIyMV0gZWZpZmI6 IG1vZGUgaXMgMTAyNHg3Njh4MzIsIGxpbmVsZW5ndGg9NDA5NiwgcGFnZXM9MQpbICAgMTMuMjYw Mjg4XSBlZmlmYjogc2Nyb2xsaW5nOiByZWRyYXcKWyAgIDEzLjI2MzkyN10gZWZpZmI6IFRydWVj b2xvcjogc2l6ZT04Ojg6ODo4LCBzaGlmdD0yNDoxNjo4OjAKWyAgIDEzLjI3ODA1N10gQ29uc29s ZTogc3dpdGNoaW5nIHRvIGNvbG91ciBmcmFtZSBidWZmZXIgZGV2aWNlIDEyOHg0OApbICAgMTMu MjkyMzI2XSBmYjA6IEVGSSBWR0EgZnJhbWUgYnVmZmVyIGRldmljZQpbICAgMTMuMjk2NjM2XSBF RkkgVmFyaWFibGVzIEZhY2lsaXR5IHYwLjA4IDIwMDQtTWF5LTE3ClsgICAxMy4zMDI3MDVdIGhp ZDogcmF3IEhJRCBldmVudHMgZHJpdmVyIChDKSBKaXJpIEtvc2luYQpbICAgMTMuMzA3ODUxXSB1 c2Jjb3JlOiByZWdpc3RlcmVkIG5ldyBpbnRlcmZhY2UgZHJpdmVyIHVzYmhpZApbICAgMTMuMzEz NDA2XSB1c2JoaWQ6IFVTQiBISUQgY29yZSBkcml2ZXIKWyAgIDEzLjMxNzMyOV0gZHJvcF9tb25p dG9yOiBJbml0aWFsaXppbmcgbmV0d29yayBkcm9wIG1vbml0b3Igc2VydmljZQpbICAgMTMuMzIz NzA5XSBJbml0aWFsaXppbmcgWEZSTSBuZXRsaW5rIHNvY2tldApbICAgMTMuMzI4MDM1XSBORVQ6 IFJlZ2lzdGVyZWQgUEZfSU5FVDYgcHJvdG9jb2wgZmFtaWx5ClsgICAxMy4zMzM2MDldIFNlZ21l bnQgUm91dGluZyB3aXRoIElQdjYKWyAgIDEzLjMzNzE5MF0gSW4tc2l0dSBPQU0gKElPQU0pIHdp dGggSVB2NgpbICAgMTMuMzQxMTkxXSBORVQ6IFJlZ2lzdGVyZWQgUEZfUEFDS0VUIHByb3RvY29s IGZhbWlseQooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjEgUkRNU1Ig MHhjMDAxMTAyMCB1bmltcGxlbWVudGVkClsgICAxMy4zNTM0NzVdIElQSSBzaG9ydGhhbmQgYnJv YWRjYXN0OiBlbmFibGVkClsgICAxMy4zNTc2NzddIHNjaGVkX2Nsb2NrOiBNYXJraW5nIHN0YWJs ZSAoMTEwOTU1MDQ0NDcsIDIyNjIwODAxMjApLT4oMTU4MTE4NjY0MDQsIC0yNDU0MjgxODM3KQpb ICAgMTMuMzY3MDA2XSByZWdpc3RlcmVkIHRhc2tzdGF0cyB2ZXJzaW9uIDEKWyAgIDEzLjM3MTAy Nl0gTG9hZGluZyBjb21waWxlZC1pbiBYLjUwOSBjZXJ0aWZpY2F0ZXMKWyAgIDEzLjM4MzM0M10g dXNiIDEtMjogbmV3IGhpZ2gtc3BlZWQgVVNCIGRldmljZSBudW1iZXIgMiB1c2luZyB4aGNpX2hj ZApbICAgMTMuNDMzODgwXSBMb2FkZWQgWC41MDkgY2VydCAnQnVpbGQgdGltZSBhdXRvZ2VuZXJh dGVkIGtlcm5lbCBrZXk6IGJlM2QwZWRlOTJhNDA0ZGNlYTkwOTNlMWJkMGY1ZjllNjk0MDUwN2Qn ClsgICAxMy40NDYxNjBdIHpzd2FwOiBsb2FkZWQgdXNpbmcgcG9vbCBsem8vemJ1ZApbICAgMTMu NDU0NjM1XSBwc3RvcmU6IFVzaW5nIGNyYXNoIGR1bXAgY29tcHJlc3Npb246IGRlZmxhdGUKWyAg IDEzLjQ3MzQyOV0gS2V5IHR5cGUgdHJ1c3RlZCByZWdpc3RlcmVkClsgICAxMy40ODkwMDRdIEtl eSB0eXBlIGVuY3J5cHRlZCByZWdpc3RlcmVkClsgICAxMy40OTYxODNdIGltYTogQWxsb2NhdGVk IGhhc2ggYWxnb3JpdGhtOiBzaGExClsgICAxMy41MTg3NTNdIHVzYiAxLTI6IE5ldyBVU0IgZGV2 aWNlIGZvdW5kLCBpZFZlbmRvcj0xZDZiLCBpZFByb2R1Y3Q9MDEwNywgYmNkRGV2aWNlPSAxLjAw ClsgICAxMy41MzAxNzRdIHVzYiAxLTI6IE5ldyBVU0IgZGV2aWNlIHN0cmluZ3M6IE1mcj0zLCBQ cm9kdWN0PTIsIFNlcmlhbE51bWJlcj0xClsgICAxMy41NDA3NjRdIHVzYiAxLTI6IFByb2R1Y3Q6 IFVTQiBWaXJ0dWFsIEh1YgpbICAgMTMuNTQzNzU3XSBpbWE6IE5vIGFyY2hpdGVjdHVyZSBwb2xp Y2llcyBmb3VuZApbICAgMTMuNTQ0OTY1XSB1c2IgMS0yOiBNYW51ZmFjdHVyZXI6IEFzcGVlZApb ICAgMTMuNTQ5NTcxXSBldm06IEluaXRpYWxpc2luZyBFVk0gZXh0ZW5kZWQgYXR0cmlidXRlczoK WyAgIDEzLjU1MzYzMl0gdXNiIDEtMjogU2VyaWFsTnVtYmVyOiAwMDAwMDAwMApbICAgMTMuNTU4 ODI2XSBldm06IHNlY3VyaXR5LnNlbGludXgKWyAgIDEzLjU1ODgyOF0gZXZtOiBzZWN1cml0eS5T TUFDSzY0IChkaXNhYmxlZCkKWyAgIDEzLjU1ODgyOV0gZXZtOiBzZWN1cml0eS5TTUFDSzY0RVhF QyAoZGlzYWJsZWQpClsgICAxMy41NTg4MjldIGV2bTogc2VjdXJpdHkuU01BQ0s2NFRSQU5TTVVU RSAoZGlzYWJsZWQpClsgICAxMy41NjM4MTBdIGh1YiAxLTI6MS4wOiBVU0IgaHViIGZvdW5kClsg ICAxMy41NjY0NTFdIGV2bTogc2VjdXJpdHkuU01BQ0s2NE1NQVAgKGRpc2FibGVkKQpbICAgMTMu NTY2NDUzXSBldm06IHNlY3VyaXR5LmFwcGFybW9yIChkaXNhYmxlZCkKWyAgIDEzLjU2NjQ1NF0g ZXZtOiBzZWN1cml0eS5pbWEKWyAgIDEzLjU2NjQ1NF0gZXZtOiBzZWN1cml0eS5jYXBhYmlsaXR5 ClsgICAxMy41NzA5OTBdIGh1YiAxLTI6MS4wOiA1IHBvcnRzIGRldGVjdGVkClsgICAxMy41NzU0 NjhdIGV2bTogSE1BQyBhdHRyczogMHgxClsgICAxMy42ODg2NTFdIEZyZWVpbmcgdW51c2VkIGtl cm5lbCBpbWFnZSAoaW5pdG1lbSkgbWVtb3J5OiAyNDQ0SwpbICAgMTMuNzA4MzYxXSBXcml0ZSBw cm90ZWN0aW5nIHRoZSBrZXJuZWwgcmVhZC1vbmx5IGRhdGE6IDIwNDgwawpbICAgMTMuNzMyOTA1 XSBGcmVlaW5nIHVudXNlZCBrZXJuZWwgaW1hZ2UgKHRleHQvcm9kYXRhIGdhcCkgbWVtb3J5OiAy MDQwSwpbICAgMTMuNzQzNTQwXSBGcmVlaW5nIHVudXNlZCBrZXJuZWwgaW1hZ2UgKHJvZGF0YS9k YXRhIGdhcCkgbWVtb3J5OiAxNzA4SwpbICAgMTMuNzUzMDA0XSBSdW4gL2luaXQgYXMgaW5pdCBw cm9jZXNzClsgICAxMy43ODY0MDRdIHN5c3RlbWRbMV06IHN5c3RlbWQgMjM5ICgyMzktNDAuZWw4 KSBydW5uaW5nIGluIHN5c3RlbSBtb2RlLiAoK1BBTSArQVVESVQgK1NFTElOVVggK0lNQSAtQVBQ QVJNT1IgK1NNQUNLICtTWVNWSU5JVCArVVRNUCArTElCQ1JZUFRTRVRVUCArR0NSWVBUICtHTlVU TFMgK0FDTCArWFogK0xaNCArU0VDQ09NUCArQkxLSUQgK0VMRlVUSUxTICtLTU9EICtJRE4yIC1J RE4gK1BDUkUyIGRlZmF1bHQtaGllcmFyY2h5PWxlZ2FjeSkKWyAgIDEzLjc5NDMxOV0gdXNiIDEt NTogbmV3IGZ1bGwtc3BlZWQgVVNCIGRldmljZSBudW1iZXIgMyB1c2luZyB4aGNpX2hjZApbICAg MTMuODA4NzY1XSBzeXN0ZW1kWzFdOiBEZXRlY3RlZCBhcmNoaXRlY3R1cmUgeDg2LTY0LgpbICAg MTMuODMzNDI0XSBzeXN0ZW1kWzFdOiBSdW5uaW5nIGluIGluaXRpYWwgUkFNIGRpc2suCgpXZWxj b21lIHRvIFJlZCBIYXQgRW50ZXJwcmlzZSBMaW51eCA4LjMgKE9vdHBhKSBkcmFjdXQtMDQ5LTk1 LmdpdDIwMjAwODA0LmVsOCAoSW5pdHJhbWZzKSEKClsgICAxMy44NjEzNjhdIHN5c3RlbWRbMV06 IFNldCBob3N0bmFtZSB0byA8aWN4LTJzMT4uClsgICAxMy45NDgzMjddIHVzYiAxLTU6IE5ldyBV U0IgZGV2aWNlIGZvdW5kLCBpZFZlbmRvcj0xNGRkLCBpZFByb2R1Y3Q9MTAwNSwgYmNkRGV2aWNl PSAwLjAwClsgICAxMy45NTk2ODNdIHVzYiAxLTU6IE5ldyBVU0IgZGV2aWNlIHN0cmluZ3M6IE1m cj0xLCBQcm9kdWN0PTIsIFNlcmlhbE51bWJlcj0zClsgICAxMy45Njk5OThdIHVzYiAxLTU6IFBy b2R1Y3Q6IEQyQ0lNLVZVU0IKWyAgIDEzLjk3NzA5Ml0gdXNiIDEtNTogTWFudWZhY3R1cmVyOiBS YXJpdGFuClsgICAxMy45ODQyNTldIHVzYiAxLTU6IFNlcmlhbE51bWJlcjogN0MwNzQ3OENERkE0 OTQ3ClsgICAxMy45OTk5MjldIGlucHV0OiBSYXJpdGFuIEQyQ0lNLVZVU0IgS2V5Ym9hcmQgYXMg L2RldmljZXMvcGNpMDAwMDowMC8wMDAwOjAwOjE0LjAvdXNiMS8xLTUvMS01OjEuMC8wMDAzOjE0 REQ6MTAwNS4wMDAxL2lucHV0L2lucHV0MQpbICAgMTQuMDQ5Nzc0XSBzeXN0ZW1kWzFdOiBMaXN0 ZW5pbmcgb24gSm91cm5hbCBTb2NrZXQgKC9kZXYvbG9nKS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9u IEpvdXJuYWwgU29ja2V0ICgvZGV2L2xvZykuClsgICAxNC4wNjQzNjRdIHVzYiAxLTIuMTogbmV3 IGhpZ2gtc3BlZWQgVVNCIGRldmljZSBudW1iZXIgNCB1c2luZyB4aGNpX2hjZApbICAgMTQuMDY0 NDAwXSBzeXN0ZW1kWzFdOiBMaXN0ZW5pbmcgb24gdWRldiBDb250cm9sIFNvY2tldC4KWyAgIDE0 LjA3MTA1M10gaW5wdXQ6IFJhcml0YW4gRDJDSU0tVlVTQiBNb3VzZSBhcyAvZGV2aWNlcy9wY2kw MDAwOjAwLzAwMDA6MDA6MTQuMC91c2IxLzEtNS8xLTU6MS4wLzAwMDM6MTRERDoxMDA1LjAwMDEv aW5wdXQvaW5wdXQyClsgICAxNC4xMDE3NjBdIGhbICBPSyAgXSBMaXN0ZW5pbmcgb24gdWRldiBD b250cm9sIFNvY2tldC5pZC1nZW5lcmljIDAwMDM6CjE0REQ6MTAwNS4wMDAxOiBpbnB1dCxoaWRy YXcwOiBVU0IgSElEIHYxLjExIEtleWJvYXJkIFtSYXJpdGFuIEQyQ0lNLVZVU0JdIG9uIHVzYi0w MDAwOjAwOjE0LjAtNS9pbnB1dDAKWyAgIDE0LjEwOTIyM10gc3lzdGVtZFsxXTogUmVhY2hlZCB0 YXJnZXQgU2xpY2VzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTbGljZXMuClsgICAxNC4xMzc3 MDJdIHN5c3RlbWRbMV06IFJlYWNoZWQgdGFyZ2V0IFN3YXAuClsgIE9LICBdIFJlYWNoZWQgdGFy Z2V0IFN3YXAuClsgICAxNC4xNDkzODNdIHN5c3RlbWRbMV06IExpc3RlbmluZyBvbiBKb3VybmFs IFNvY2tldC4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIEpvdXJuYWwgU29ja2V0LgpbICAgMTQuMTY1 Mzk0XSBzeXN0ZW1kWzFdOiBTdGFydGVkIEhhcmR3YXJlIFJORyBFbnRyb3B5IEdhdGhlcmVyIERh ZW1vbi4KWyAgT0sgIF0gU3RhcnRlZCBIYXJkd2FyZSBSTkcgRW50cm9weSBHYXRoZXJlciBEYWVt b24uCiAgICAgICAgIFN0YXJ0aW5nIEpvdXJuYWwgU2VydmljZS4uLgogICAgICAgICBTdGFydGlu ZyBMb2FkIEtlcm5lbCBNb2R1bGVzLi4uCiAgICAgICAgIFN0YXJ0aW5nIFNldHVwIFZpcnR1YWwg Q29uc29sZS4uLgpbICAgMTQuMjAwNjQ1XSB1c2IgMS0yLjE6IE5ldyBVU0IgZGV2aWNlIGZvdW5k LCBpZFZlbmRvcj0xZDZiLCBpZFByb2R1Y3Q9MDEwNCwgYmNkRGV2aWNlPSAxLjAwClsgICAxNC4y MTI1NzNdIHVzYiAxLTIuMTogTmV3IFVTQiBkZXZpY2Ugc3RyaW5nczogTWZyPTEsIFByb2R1Y3Q9 MiwgU2VyaWFsTnVtYmVyPTMKWyAgIDE0LjIxMjU3NV0gdXNiIDEtMi4xOiBQcm9kdWN0OiB2aXJ0 dWFsX2lucHV0ClsgICAxNC4yMTI1NzddIHVzYiAxLTIuMTogTWFudWZhY3R1cmVyOiBPcGVuQk1D ClsgICAxNC4yMTI1NzddIHVzYiAxLTIuMTogU2VyaWFsTnVtYmVyOiBPQk1DMDAwMQpbICBPSyAg XSBTdGFydGVkIE1lbXN0cmFjayBBbnlsYXppbmcgU2VydmljZS4KWyAgIDE0LjI1NDYzNl0gZiAg ICAgICAgIFN0YXJ0aW5nIENyZWF0ZSBsaXN0IG9mIHJlcXVpcmVkIHN04oCmY2Ugbm9kZXMgZm9y IHRoZSBjdXJyZW50IGtlcm5lbC4uLnVzZTogaW5pdCAoQVBJIHYKZXJzaW9uIDcuMzYpClsgIE9L ICBdIExpc3RlbmluZyBvbiB1ZGV2IEtlcm5lbCBTb2NrZXQuClsgIE9LICBdIFJlYWNoZWQgdGFy Z2V0IFNvY2tldHMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IExvY2FsIEZpbGUgU3lzdGVtcy4K ICAgICAgICAgU3RhcnRpbmcgQ3JlYXRlIFZvbGF0aWxlIEZpbGVzIGFuZCBEaXJlY3Rvcmllcy4u LgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBUaW1lcnMuClsgIE9LICBdIFN0YXJ0ZWQgQ3JlYXRl IGxpc3Qgb2YgcmVxdWlyZWQgc3Rh4oCmdmljZSBub2RlcyBmb3IgdGhlIGN1cnJlbnQga2VybmVs LgogICAgICAgICBTdGFydGluZyBDcmVhdGUgU3RhdGljIERldmljZSBOb2RlcyBpbiAvZGV2Li4u ClsgIE9LICBdIFN0YXJ0ZWQgTG9hZCBLZXJuZWwgTW9kdWxlcy4KICAgICAgICAgU3RhcnRpbmcg QXBwbHkgS2VybmVsIFZhcmlhYmxlcy4uLgpbICBPSyAgXSBTdGFydGVkIENyZWF0ZSBWb2xhdGls ZSBGaWxlcyBhbmQgRGlyZWN0b3JpZXMuClsgIE9LICBdIFN0YXJ0ZWQgQ3JlYXRlIFN0YXRpYyBE ZXZpY2UgTm9kZXMgaW4gL2Rldi4KWyAgT0sgIF0gU3RhcnRlZCBBcHBseSBLZXJuZWwgVmFyaWFi bGVzLgpbICBPSyAgXSBTdGFydGVkIFNldHVwIFZpcnR1YWwgQ29uc29sZS4KICAgICAgICAgU3Rh cnRpbmcgZHJhY3V0IGNtZGxpbmUgaG9vay4uLgpbICBPSyAgXSBTdGFydGVkIEpvdXJuYWwgU2Vy dmljZS4KWyAgT0sgIF0gU3RhcnRlZCBkcmFjdXQgY21kbGluZSBob29rLgogICAgICAgICBTdGFy dGluZyBkcmFjdXQgcHJlLXVkZXYgaG9vay4uLgpbICAgMTQuNzMxMDQ5XSBkZXZpY2UtbWFwcGVy OiBjb3JlOiBDT05GSUdfSU1BX0RJU0FCTEVfSFRBQkxFIGlzIGRpc2FibGVkLiBEdXBsaWNhdGUg SU1BIG1lYXN1cmVtZW50cyB3aWxsIG5vdCBiZSByZWNvcmRlZCBpbiB0aGUgSU1BIGxvZy4KWyAg IDE0Ljc1MTA2OF0gZGV2aWNlLW1hcHBlcjogdWV2ZW50OiB2ZXJzaW9uIDEuMC4zClsgICAxNC43 NTk3OTBdIGRldmljZS1tYXBwZXI6IGlvY3RsOiA0LjQ2LjAtaW9jdGwgKDIwMjItMDItMjIpIGlu aXRpYWxpc2VkOiBkbS1kZXZlbEByZWRoYXQuY29tClsgIE9LICBdIFN0YXJ0ZWQgZHJhY3V0IHBy ZS11ZGV2IGhvb2suCiAgICAgICAgIFN0YXJ0aW5nIHVkZXYgS2VybmVsIERldmljZSBNYW5hZ2Vy Li4uClsgIE9LICBdIFN0YXJ0ZWQgdWRldiBLZXJuZWwgRGV2aWNlIE1hbmFnZXIuCiAgICAgICAg IFN0YXJ0aW5nIHVkZXYgQ29sZHBsdWcgYWxsIERldmljZXMuLi4KICAgICAgICAgTW91bnRpbmcg S2VybmVsIENvbmZpZ3VyYXRpb24gRmlsZSBTeXN0ZW0uLi4KWyAgT0sgIF0gTW91bnRlZCBLZXJu ZWwgQ29uZmlndXJhdGlvbiBGaWxlIFN5c3RlbS4KWyAgT0sgIF0gU3RhcnRlZCB1ZGV2IENvbGRw bHVnIGFsbCBEZXZpY2VzLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBTeXN0ZW0gSW5pdGlhbGl6 YXRpb24uCiAgICAgICAgIFN0YXJ0aW5nIFNob3cgUGx5bW91dGggQm9vdCBTY3JlZW4uLi4KICAg ICAgICAgU3RhcnRpbmcgZHJhY3V0IGluaXRxdWV1ZSBob29rLi4uClsgICAxNS44MTUxMTddIGRj YSBzZXJ2aWNlIHN0YXJ0ZWQsIHZlcnNpb24gMS4xMi4xClsgICAxNS44MzgzMzZdIEFDUEk6IGJ1 cyB0eXBlIGRybV9jb25uZWN0b3IgcmVnaXN0ZXJlZApbICAgMTUuODU4MDY4XSBwcHNfY29yZTog TGludXhQUFMgQVBJIHZlci4gMSByZWdpc3RlcmVkClsgICAxNS44NjcyNTddIHBwc19jb3JlOiBT b2Z0d2FyZSB2ZXIuIDUuMy42IC0gQ29weXJpZ2h0IDIwMDUtMjAwNyBSb2RvbGZvIEdpb21ldHRp IDxnaW9tZXR0aUBsaW51eC5pdD4KWyAgIDE1Ljg4MjM2NF0gUFRQIGNsb2NrIHN1cHBvcnQgcmVn aXN0ZXJlZApbICAgMTUuOTA5MjAyXSBpZ2I6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0 d29yayBEcml2ZXIKWyAgIDE1LjkxOTA2N10gaWdiOiBDb3B5cmlnaHQgKGMpIDIwMDctMjAxNCBJ bnRlbCBDb3Jwb3JhdGlvbi4KWyAgIDE1LjkyOTE0MF0gaWdiIDAwMDA6MDE6MDAuMDogZW5hYmxp bmcgZGV2aWNlICgwMTQwIC0+IDAxNDIpClsgICAxNS45MzkzNzddIEFscmVhZHkgc2V0dXAgdGhl IEdTSSA6MTYKWyAgIDE1Ljk1OTY0M10gaXhnYmU6IEludGVsKFIpIDEwIEdpZ2FiaXQgUENJIEV4 cHJlc3MgTmV0d29yayBEcml2ZXIKWyAgIDE1Ljk1OTY0Nl0gaXhnYmU6IENvcHlyaWdodCAoYykg MTk5OS0yMDE2IEludGVsIENvcnBvcmF0aW9uLgpbICAgMTUuOTgxOTA5XSBDb25zb2xlOiBzd2l0 Y2hpbmcgdG8gY29sb3VyIGR1bW15IGRldmljZSA4MHgyNQpbICAgMTUucCB0aGUKIEdTSSA6MTcK WyAgT0sgIF0gU3RhcnRlZCBGb3J3YXJkIFBhc3N3b3JkIFJlcXVlc3RzIHRvIFBseW1vdXRoIERp cmVjdG9yeSBXYXRjaC5bICAgMTUuOTg5OTgzXSBpCnhnYmUgMDAwMDoxNzowMC5bICBPSyAgXSBS ZWFjaGVkIHRhcmdldCBQYXRocy4wOiBlbmFibGluZyBkZXZpCmNlICgwMTQwIC0+IDAxNDJbICBP SyAgXSBSZWFjaGVkIHRhcmdldCBCYXNpYyBTeXN0ZW0uKQoKWyAgIDE2LjAxOTU2Nl0gQWxyZWFk eSBzZXR1cCB0aGUgR1NJIDoxNwpbICAgMTYuMDE5ODM4XSBwcHMgcHBzMDogbmV3IFBQUyBzb3Vy Y2UgcHRwMApbICAgMTYuMDIwNjkzXSBpZ2IgMDAwMDowMTowMC4wOiBhZGRlZCBQSEMgb24gZXRo MApbICAgMTYuMDIwNjk1XSBpZ2IgMDAwMDowMTowMC4wOiBJbnRlbChSKSBHaWdhYml0IEV0aGVy bmV0IE5ldHdvcmsgQ29ubmVjdGlvbgpbICAgMTYuMDIwNjk3XSBpZ2IgMDAwMDowMTowMC4wOiBl dGgwOiAoUENJZToyLjVHYi9zOldpZHRoIHgxKSBhNDpiZjowMTo2OTo3Mzo3YQpbICAgMTYuMDIw ODA3XSBpZ2IgMDAwMDowMTowMC4wOiBldGgwOiBQQkEgTm86IDAwMDMwMC0wMDAKWyAgIDE2LjAy MDgwOF0gaWdiIDAwMDA6MDE6MDAuMDogVXNpbmcgTVNJLVggaW50ZXJydXB0cy4gNCByeCBxdWV1 ZShzKSwgNCB0eCBxdWV1ZShzKQpbICAgMTYuMDIwODk5XSBpZ2IgMDAwMDpjYTowMC4wOiBlbmFi bGluZyBkZXZpY2UgKDAxNDAgLT4gMDE0MikKWyAgIDE2LjAyMDkzNV0gQWxyZWFkeSBzZXR1cCB0 aGUgR1NJIDoxOApbICAgMTYuMDIzNzE4XSBhc3QgMDAwMDowMzowMC4wOiBbZHJtXSBVc2luZyBQ MkEgYnJpZGdlIGZvciBjb25maWd1cmF0aW9uClsgICAxNi4wMzIyMjNdIGFzdCAwMDAwOjAzOjAw LjA6IFtkcm1dIEFTVCAyNTAwIGRldGVjdGVkClsgICAxNi4wODAzNjVdIGFzdCAwMDAwOjAzOjAw LjA6IFtkcm1dIFVzaW5nIGFuYWxvZyBWR0EKWyAgIDE2LjA4MDM3N10gYXN0IDAwMDA6MDM6MDAu MDogW2RybV0gZHJhbSBNQ0xLPTgwMCBNaHogdHlwZT03IGJ1c193aWR0aD0xNgpbICAgMTYuMDg4 NTU2XSBpNDBlOiBJbnRlbChSKSBFdGhlcm5ldCBDb25uZWN0aW9uIFhMNzEwIE5ldHdvcmsgRHJp dmVyClsgICAxNi4wODg1NjBdIGk0MGU6IENvcHlyaWdodCAoYykgMjAxMyAtIDIwMTkgSW50ZWwg Q29ycG9yYXRpb24uClsgICAxNi4wOTUyNThdIGk0MGUgMDAwMDpiMTowMC4wOiBlbmFibGluZyBk ZXZpY2UgKDAxNDAgLT4gMDE0MikKWyAgIDE2LjExMjUwMF0gcHBzIHBwczE6IG5ldyBQUFMgc291 cmNlIHB0cDEKWyAgIDE2LjExNDI0NV0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpbICAgMTYu MTE0MjUwXSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE4ClsgICAxNi4xMzE2NTRdIGlnYiAwMDAw OmNhOjAwLjA6IGFkZGVkIFBIQyBvbiBldGgxClsgICAxNi4xMzYxNzVdIGlnYiAwMDAwOmNhOjAw LjA6IEludGVsKFIpIEdpZ2FiaXQgRXRoZXJuZXQgTmV0d29yayBDb25uZWN0aW9uClsgICAxNi4x NDMxMDddIGlnYiAwMDAwOmNhOjAwLjA6IGV0aDE6IChQQ0llOjIuNUdiL3M6V2lkdGggeDEpIGEw OjM2OjlmOmM4OjljOjc0ClsgICAxNi4xNTA0NjRdIGlnYiAwMDAwOmNhOjAwLjA6IGV0aDE6IFBC QSBObzogRzY5MDE2LTAwMwpbICAgMTYuMTUzNzI1XSBpNDBlIDAwMDA6YjE6MDAuMDogZncgNi4w LjQ4NDQyIGFwaSAxLjcgbnZtIDYuMDEgMHg4MDAwMzQ4MyAxLjE3NDcuMCBbODA4NjoxNTcyXSBb ODA4NjowMDA4XQpbICAgMTYuMTU1NDkyXSBpZ2IgMDAwMDpjYTowMC4wOiBVc2luZyBNU0ktWCBp bnRlcnJ1cHRzLiA0IHJ4IHF1ZXVlKHMpLCA0IHR4IHF1ZXVlKHMpClsgICAxNi4xNzQ4NzJdIFtk cm1dIEluaXRpYWxpemVkIGFzdCAwLjEuMCAyMDEyMDIyOCBmb3IgMDAwMDowMzowMC4wIG9uIG1p bm9yIDAKWyAgIDE2LjE3ODIxN10gYWhjaSAwMDAwOjAwOjExLjU6IEFIQ0kgMDAwMS4wMzAxIDMy IHNsb3RzIDIgcG9ydHMgNiBHYnBzIDB4MyBpbXBsIFNBVEEgbW9kZQpbICAgMTYuMTg5OTI0XSBh aGNpIDAwMDA6MDA6MTEuNTogZmxhZ3M6IDY0Yml0IG5jcSBzbnRmIHBtIGxlZCBjbG8gb25seSBw aW8gc2x1bSBwYXJ0IGVtcyBkZXNvIHNhZG0gc2RzIGFwc3QgClsgICAxNi4zMjAzNThdIGlnYiAw MDAwOjAxOjAwLjAgZW5wMXMwOiByZW5hbWVkIGZyb20gZXRoMApbICAgMTYuNDY5NTY0XSBpNDBl IDAwMDA6YjE6MDAuMDogTUFDIGFkZHJlc3M6IDNjOmZkOmZlOmFhOjdlOjkwClsgICAxNi40NzU2 NzZdIGk0MGUgMDAwMDpiMTowMC4wOiBGVyBMTERQIGlzIGVuYWJsZWQKWyAgIDE2LjcyNTg1N10g c2NzaSBob3N0MDogYWhjaQpbICAgMTYuNzI4NzczXSBzY3NpIGhvc3QxOiBhaGNpClsgICAxNi43 MzE1OTJdIGF0YTE6IFNBVEEgbWF4IFVETUEvMTMzIGFiYXIgbTUyNDI4OEAweDkyMjgwMDAwIHBv cnQgMHg5MjI4MDEwMCBpcnEgMTk1ClsgICAxNi43Mzc4NzBdIGl4Z2JlIDAwMDA6MTc6MDAuMDog TXVsdGlxdWV1ZSBFbmFibGVkOiBSeCBRdWV1ZSBjb3VudCA9IDgsIFR4IFF1ZXVlIGNvdW50ID0g OCBYRFAgUXVldWUgY291bnQgPSAwClsgICAxNi43MzkyNjZdIGF0YTI6IFNBVEEgbWF4IFVETUEv MTMzIGFiYXIgbTUyNDI4OEAweDkyMjgwMDAwIHBvcnQgMHg5MjI4MDE4MCBpcnEgMTk1ClsgICAx Ni43NTcxMTVdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTYKWyAgIDE2Ljc2MTE2Ml0gYWhjaSAw MDAwOjAwOjE3LjA6IEFIQ0kgMDAwMS4wMzAxIDMyIHNsb3RzIDggcG9ydHMgNiBHYnBzIDB4ZmYg aW1wbCBTQVRBIG1vZGUKWyAgIDE2Ljc2OTE4OF0gYWhjaSAwMDAwOjAwOjE3LjA6IGZsYWdzOiA2 NGJpdCBuY3Egc250ZiBwbSBsZWQgY2xvIG9ubHkgcGlvIHNsdW0gcGFydCBlbXMgZGVzbyBzYWRt IHNkcyBhcHN0IApbICAgMTYuNzk5ODI2XSBzY3NpIGhvc3QyOiBhaGNpClsgICAxNi44MDI3NTFd IHNjc2kgaG9zdDM6IGFoY2kKWyAgIDE2LjgwNTY1Ml0gc2NzaSBob3N0NDogYWhjaQpbICAgMTYu ODA4NjIyXSBzY3NpIGhvc3Q1OiBhaGNpClsgICAxNi44MTE1NzBdIHNjc2kgaG9zdDY6IGFoY2kK WyAgIDE2LjgxNDUzMl0gc2NzaSBob3N0NzogYWhjaQpbICAgMTYuODE3NDM3XSBzY3NpIGhvc3Q4 OiBhaGNpClsgICAxNi44MjA0MjJdIHNjc2kgaG9zdDk6IGFoY2kKWyAgIDE2LjgyMzIzMF0gYXRh MzogU0FUQSBtYXggVURNQS8xMzMgYWJhciBtNTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDkyMjAw MTAwIGlycSAyMjMKWyAgIDE2LjgzMDkwNV0gYXRhNDogU0FUQSBtYXggVURNQS8xMzMgYWJhciBt NTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDkyMjAwMTgwIGlycSAyMjMKWyAgIDE2LjgzODYxM10g YXRhNTogU0FUQSBtYXggVURNQS8xMzMgYWJhciBtNTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDky MjAwMjAwIGlycSAyMjMKWyAgIDE2Ljg0NjMxNV0gYXRhNjogU0FUQSBtYXggVURNQS8xMzMgYWJh ciBtNTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDkyMjAwMjgwIGlycSAyMjMKWyAgIDE2Ljg0ODM0 Ml0gaXhnYmUgMDAwMDoxNzowMC4wOiAzMS41MDQgR2IvcyBhdmFpbGFibGUgUENJZSBiYW5kd2lk dGggKDguMCBHVC9zIFBDSWUgeDQgbGluaykKWyAgIDE2Ljg1NDA0NV0gYXRhNzogU0FUQSBtYXgg VURNQS8xMzMgYWJhciBtNTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDkyMjAwMzAwIGlycSAyMjMK WyAgIDE2Ljg3MDI1MF0gYXRhODogU0FUQSBtYXggVURNQS8xMzMgYWJhciBtNTI0Mjg4QDB4OTIy MDAwMDAgcG9ydCAweDkyMjAwMzgwIGlycSAyMjMKWyAgIDE2Ljg3Nzk2Nl0gYXRhOTogU0FUQSBt YXggVURNQS8xMzMgYWJhciBtNTI0Mjg4QDB4OTIyMDAwMDAgcG9ydCAweDkyMjAwNDAwIGlycSAy MjMKWyAgIDE2Ljg4NTY3NV0gYXRhMTA6IFNBVEEgbWF4IFVETUEvMTMzIGFiYXIgbTUyNDI4OEAw eDkyMjAwMDAwIHBvcnQgMHg5MjIwMDQ4MCBpcnEgMjIzClsgICAxNi45NzQzMTFdIGl4Z2JlIDAw MDA6MTc6MDAuMDogTUFDOiA0LCBQSFk6IDAsIFBCQSBObzogSDg2Mzc3LTAwNgpbICAgMTYuOTgw MzQ0XSBpeGdiZSAwMDAwOjE3OjAwLjA6IGI0Ojk2OjkxOjQ5OjhiOjcwClsgICAxNy4wNjE2Nzld IGF0YTI6IFNBVEEgbGluayBkb3duIChTU3RhdHVzIDQgU0NvbnRyb2wgMzAwKQpbICAgMTcuMDY2 OTUwXSBhdGExOiBTQVRBIGxpbmsgZG93biAoU1N0YXR1cyA0IFNDb250cm9sIDMwMCkKWyAgIDE3 LjE5NzY4OV0gYXRhODogU0FUQSBsaW5rIGRvd24gKFNTdGF0dXMgNCBTQ29udHJvbCAzMDApClsg ICAxNy4yMDI5NjRdIGF0YTc6IFNBVEEgbGluayBkb3duIChTU3RhdHVzIDQgU0NvbnRyb2wgMzAw KQpbICAgMTcuMjA4NDI2XSBhdGE1OiBTQVRBIGxpbmsgdXAgNi4wIEdicHMgKFNTdGF0dXMgMTMz IFNDb250cm9sIDMwMCkKWyAgIDE3LjIxNDY1MV0gYXRhMTA6IFNBVEEgbGluayBkb3duIChTU3Rh dHVzIDQgU0NvbnRyb2wgMzAwKQpbICAgMTcuMjIwMTk2XSBhdGE0OiBTQVRBIGxpbmsgZG93biAo U1N0YXR1cyA0IFNDb250cm9sIDMwMCkKWyAgIDE3LjIyNTY1NV0gYXRhNS4wMDogQVRBLTEwOiBJ TlRFTCBTU0RTQzJLRzk2MEc4LCBYQ1YxMDExMCwgbWF4IFVETUEvMTMzClsgICAxNy4yMzIzOTRd IGF0YTUuMDA6IDE4NzUzODUwMDggc2VjdG9ycywgbXVsdGkgMTogTEJBNDggTkNRIChkZXB0aCAz MikKWyAgIDE3LjIzOTAwNV0gYXRhMzogU0FUQSBsaW5rIGRvd24gKFNTdGF0dXMgNCBTQ29udHJv bCAzMDApClsgICAxNy4yNDQ0NzJdIGF0YTk6IFNBVEEgbGluayBkb3duIChTU3RhdHVzIDQgU0Nv bnRyb2wgMzAwKQpbICAgMTcuMjQ5OTk3XSBhdGE2OiBTQVRBIGxpbmsgZG93biAoU1N0YXR1cyA0 IFNDb250cm9sIDMwMCkKWyAgIDE3LjI1NTQ2Ml0gYXRhNS4wMDogY29uZmlndXJlZCBmb3IgVURN QS8xMzMKWyAgIDE3LjI1OTgxNl0gc2NzaSA0OjA6MDowOiBEaXJlY3QtQWNjZXNzICAgICBBVEEg ICAgICBJTlRFTCBTU0RTQzJLRzk2IDAxMTAgUFE6IDAgQU5TSTogNQpbICAgMTcuMjgzOTQzXSBz Y3NpIDQ6MDowOjA6IEF0dGFjaGVkIHNjc2kgZ2VuZXJpYyBzZzAgdHlwZSAwClsgICAxNy4zMDQ1 MTRdIEVESUQgYmxvY2sgMCAodGFnIDB4MDApIGNoZWNrc3VtIGlzIGludmFsaWQsIHJlbWFpbmRl ciBpcyAxMjUKWyAgIDE3LjMxMjYwMF0gZmJjb246IGFzdGRybWZiIChmYjApIGlzIHByaW1hcnkg ZGV2aWNlClsgICAxNy4zMTQ3MTJdIGF0YTUuMDA6IEVuYWJsaW5nIGRpc2NhcmRfemVyb2VzX2Rh dGEKWyAgIDE3LjMxNDcyN10gc2QgNDowOjA6MDogW3NkYV0gMTg3NTM4NTAwOCA1MTItYnl0ZSBs b2dpY2FsIGJsb2NrczogKDk2MCBHQi84OTQgR2lCKQpbICAgMTcuMzE0NzI4XSBzZCA0OjA6MDow OiBbc2RhXSA0MDk2LWJ5dGUgcGh5c2ljYWwgYmxvY2tzClsgICAxNy4zMTQ3NDFdIHNkIDQ6MDow OjA6IFtzZGFdIFdyaXRlIFByb3RlY3QgaXMgb2ZmClsgICAxNy4zMTQ3NjddIHNkIDQ6MDowOjA6 IFtzZGFdIFdyaXRlIGNhY2hlOiBlbmFibGVkLCByZWFkIGNhY2hlOiBlbmFibGVkLCBkb2Vzbid0 IHN1cHBvcnQgRFBPIG9yIEZVQQpbICAgMTcuMzE0Nzk4XSBzZCA0OjA6MDowOiBbc2RhXSBQcmVm ZXJyZWQgbWluaW11bSBJL08gc2l6ZSA0MDk2IGJ5dGVzClsgICAxNy4zMTQ5OTRdIGF0YTUuMDA6 IEVuYWJsaW5nIGRpc2NhcmRfemVyb2VzX2RhdGEKWyAgIDE3LjMxNzEyM10gIHNkYTogc2RhMSBz ZGEyIHNkYTMKWyAgIDE3LjMxNzMzNF0gc2QgNDowOjA6MDogW3NkYV0gQXR0YWNoZWQgU0NTSSBk aXNrClsgICAxNy4zNDY4NzBdIENvbnNvbGU6IHN3aXRjaGluZyB0byBjb2xvdXIgZnJhbWUgYnVm ZmVyIGRldmljZSAxMjh4NDgKWyAgIDE3LjQxMDM4MF0gYXN0IDAwMDA6MDM6MDAuMDogW2RybV0g ZmIwOiBhc3Rkcm1mYiBmcmFtZSBidWZmZXIgZGV2aWNlClsgICAxOS4yNjExNjVdIGlucHV0OiBP cGVuQk1DIHZpcnR1YWxfaW5wdXQgYXMgL2RldmljZXMvcGNpMDAwMDowMC8wMDAwOjAwOjE0LjAv dXNiMS8xLTIvMS0yLjEvMS0yLjE6MS4wLzAwMDM6MUQ2QjowMTA0LjAwMDIvaW5wdXQvaW5wdXQz ClsgICAxOS4zMjQ1MDFdIGhpZC1nZW5lcmljIDAwMDM6MUQ2QjowMTA0LjAwMDI6IGlucHV0LGhp ZHJhdzE6IFVTQiBISUQgdjEuMDEgS2V5Ym9hcmQgW09wZW5CTUMgdmlydHVhbF9pbnB1dF0gb24g dXNiLTAwMDA6MDA6MTQuMC0yLjEvaW5wdXQwClsgICAxOS4zMzgyMjddIGlucHV0OiBPcGVuQk1D IHZpcnR1YWxfaW5wdXQgYXMgL2RldmljZXMvcGNpMDAwMDowMC8wMDAwOjAwOjE0LjAvdXNiMS8x LTIvMS0yLjEvMS0yLjE6MS4xLzAwMDM6MUQ2QjowMTA0LjAwMDMvaW5wdXQvaW5wdXQ0ClsgICAx OS4zNTA4MjVdIGhpZC1nZW5lcmljIDAwMDM6MUQ2QjowMTA0LjAwMDM6IGlucHV0LGhpZHJhdzI6 IFVTQiBISUQgdjEuMDEgTW91c2UgW09wZW5CTUMgdmlydHVhbF9pbnB1dF0gb24gdXNiLTAwMDA6 MDA6MTQuMC0yLjEvaW5wdXQxClsgICAxOS40NjcyMTZdIGlnYiAwMDAwOmNhOjAwLjAgZW5zODog cmVuYW1lZCBmcm9tIGV0aDEKWyAgIDE5LjQ4NjQ2Nl0gaXhnYmUgMDAwMDoxNzowMC4wOiBJbnRl bChSKSAxMCBHaWdhYml0IE5ldHdvcmsgQ29ubmVjdGlvbgpbICAgMTkuNDg2ODE4XSBpNDBlIDAw MDA6YjE6MDAuMDogUENJLUV4cHJlc3M6IFNwZWVkIDguMEdUL3MgV2lkdGggeDgKWyAgIDE5LjQ5 Mjk3MV0gaXhnYmUgMDAwMDoxNzowMC4xOiBlbmFibGluZyBkZXZpY2UgKDAxNDAgLT4gMDE0MikK WyAgIDE5LjQ5OTU2M10gaTQwZSAwMDAwOmIxOjAwLjA6IEZlYXR1cmVzOiBQRi1pZFswXSBWRnM6 IDY0IFZTSXM6IDY2IFFQOiA4IFJTUyBGRF9BVFIgRkRfU0IgTlRVUExFIERDQiBWeExBTiBHZW5l dmUgUFRQIFZFUEEKWyAgIDE5LjUxNjExOF0gaTQwZSAwMDAwOmIxOjAwLjE6IGVuYWJsaW5nIGRl dmljZSAoMDE0MCAtPiAwMTQyKQpbICAgMTkuNTE2NDc0XSBBbHJlYWR5IHNldHVwIHRoZSBHU0kg OjE4ClsgICAxOS41MjcwMTVdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTgKWyAgIDE5LjU0NjU5 OF0gaTQwZSAwMDAwOmIxOjAwLjE6IGZ3IDYuMC40ODQ0MiBhcGkgMS43IG52bSA2LjAxIDB4ODAw MDM0ODMgMS4xNzQ3LjAgWzgwODY6MTU3Ml0gWzgwODY6MDAwOF0KWyAgIDE5LjYyNzY3MF0gaTQw ZSAwMDAwOmIxOjAwLjE6IE1BQyBhZGRyZXNzOiAzYzpmZDpmZTphYTo3ZTo5MQpbICAgMTkuNjM0 MTE3XSBpNDBlIDAwMDA6YjE6MDAuMTogRlcgTExEUCBpcyBlbmFibGVkClsgICAxOS42NTE0ODNd IGk0MGUgMDAwMDpiMTowMC4xIGV0aDE6IE5JQyBMaW5rIGlzIFVwLCAxMCBHYnBzIEZ1bGwgRHVw bGV4LCBGbG93IENvbnRyb2w6IE5vbmUKWyAgIDE5LjY2MjE0M10gaTQwZSAwMDAwOmIxOjAwLjE6 IFBDSS1FeHByZXNzOiBTcGVlZCA4LjBHVC9zIFdpZHRoIHg4ClsgICAxOS42Nzc2NDFdIGk0MGUg MDAwMDpiMTowMC4xOiBGZWF0dXJlczogUEYtaWRbMV0gVkZzOiA2NCBWU0lzOiA2NiBRUDogOCBS U1MgRkRfQVRSIEZEX1NCIE5UVVBMRSBEQ0IgVnhMQU4gR2VuZXZlIFBUUCBWRVBBClsgICAxOS42 OTA3MDZdIGk0MGUgMDAwMDpiMTowMC4xIGVuczlmMTogcmVuYW1lZCBmcm9tIGV0aDEKWyAgIDE5 LjcxMTYxOV0gaTQwZSAwMDAwOmIxOjAwLjAgZW5zOWYwOiByZW5hbWVkIGZyb20gZXRoMApbICAg MjAuMjA3NDQxXSBpeGdiZSAwMDAwOjE3OjAwLjE6IE11bHRpcXVldWUgRW5hYmxlZDogUnggUXVl dWUgY291bnQgPSA4LCBUeCBRdWV1ZSBjb3VudCA9IDggWERQIFF1ZXVlIGNvdW50ID0gMApbICAg MjAuMzE2MjE5XSBpeGdiZSAwMDAwOjE3OjAwLjE6IDMxLjUwNCBHYi9zIGF2YWlsYWJsZSBQQ0ll IGJhbmR3aWR0aCAoOC4wIEdUL3MgUENJZSB4NCBsaW5rKQpbICAgMjAuNDM3Mjg2XSBpeGdiZSAw MDAwOjE3OjAwLjE6IE1BQzogNCwgUEhZOiAwLCBQQkEgTm86IEg4NjM3Ny0wMDYKWyAgIDIwLjQ0 MzY2Nl0gaXhnYmUgMDAwMDoxNzowMC4xOiBiNDo5Njo5MTo0OTo4Yjo3MQpbICAgMjAuNjA5MzU4 XSBpeGdiZSAwMDAwOjE3OjAwLjE6IEludGVsKFIpIDEwIEdpZ2FiaXQgTmV0d29yayBDb25uZWN0 aW9uClsgICAyMC42MTc5MzVdIGl4Z2JlIDAwMDA6MTc6MDAuMCBlbnM2ZjA6IHJlbmFtZWQgZnJv bSBldGgyClsgICAyMC42MzU1NzRdIGl4Z2JlIDAwMDA6MTc6MDAuMSBlbnM2ZjE6IHJlbmFtZWQg ZnJvbSBldGgwClsgIE9LICBdIEZvdW5kIGRldmljZSAvZGV2L21hcHBlci9yaGVsLXJvb3QuClsg IE9LICBdIFJlYWNoZWQgdGFyZ2V0IEluaXRyZCBSb290IERldmljZS4KWyAgT0sgIF0gU3RhcnRl ZCBkcmFjdXQgaW5pdHF1ZXVlIGhvb2suClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBG aWxlIFN5c3RlbXMgKFByZSkuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBGaWxlIFN5 c3RlbXMuCiAgICAgICAgIFN0YXJ0aW5nIEZpbGUgU3lzdGVtIENoZWNrIG9uIC9kZXYvbWFwcGVy L3JoZWwtcm9vdC4uLgpbICBPSyAgXSBTdGFydGVkIEZpbGUgU3lzdGVtIENoZWNrIG9uIC9kZXYv bWFwcGVyL3JoZWwtcm9vdC4KICAgICAgICAgTW91bnRpbmcgL3N5c3Jvb3QuLi4KWyAgIDIxLjMy MjU3M10gU0dJIFhGUyB3aXRoIEFDTHMsIHNlY3VyaXR5IGF0dHJpYnV0ZXMsIHF1b3RhLCBubyBk ZWJ1ZyBlbmFibGVkClsgICAyMS4zMzM1ODFdIFhGUyAoZG0tMCk6IE1vdW50aW5nIFY1IEZpbGVz eXN0ZW0KWyAgIDIxLjM2NzM1OV0gWEZTIChkbS0wKTogRW5kaW5nIGNsZWFuIG1vdW50ClsgIE9L ICBdIE1vdW50ZWQgL3N5c3Jvb3QuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEluaXRyZCBSb290 IEZpbGUgU3lzdGVtLgogICAgICAgICBTdGFydGluZyBSZWxvYWQgQ29uZmlndXJhdGlvbiBmcm9t IHRoZSBSZWFsIFJvb3QuLi4KWyAgT0sgIF0gU3RhcnRlZCBSZWxvYWQgQ29uZmlndXJhdGlvbiBm cm9tIHRoZSBSZWFsIFJvb3QuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEluaXRyZCBGaWxlIFN5 c3RlbXMuClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IEluaXRyZCBEZWZhdWx0IFRhcmdldC4KICAg ICAgICAgU3RhcnRpbmcgZHJhY3V0IHByZS1waXZvdCBhbmQgY2xlYW51cCBob29rLi4uClsgIE9L ICBdIFN0YXJ0ZWQgZHJhY3V0IHByZS1waXZvdCBhbmQgY2xlYW51cCBob29rLgogICAgICAgICBT dGFydGluZyBDbGVhbmluZyBVcCBhbmQgU2h1dHRpbmcgRG93biBEYWVtb25zLi4uClsgIE9LICBd IFN0b3BwZWQgZHJhY3V0IHByZS1waXZvdCBhbmQgY2xlYW51cCBob29rLgpbICBPSyAgXSBTdG9w cGVkIHRhcmdldCBJbml0cmQgRGVmYXVsdCBUYXJnZXQuClsgIE9LICBdIFN0b3BwZWQgdGFyZ2V0 IEluaXRyZCBSb290IERldmljZS4KWyAgT0sgIF0gU3RvcHBlZCB0YXJnZXQgQmFzaWMgU3lzdGVt LgpbICBPSyAgXSBTdG9wcGVkIHRhcmdldCBTeXN0ZW0gSW5pdGlhbGl6YXRpb24uCiAgICAgICAg IFN0b3BwaW5nIHVkZXYgS2VybmVsIERldmljZSBNYW5hZ2VyLi4uClsgIE9LICBdIFN0b3BwZWQg Q3JlYXRlIFZvbGF0aWxlIEZpbGVzIGFuZCBEaXJlY3Rvcmllcy4KWyAgT0sgIF0gU3RvcHBlZCB0 YXJnZXQgUGF0aHMuClsgIE9LICBdIFN0b3BwZWQgdGFyZ2V0IExvY2FsIEZpbGUgU3lzdGVtcy4K WyAgT0sgIF0gU3RvcHBlZCB0YXJnZXQgUmVtb3RlIEZpbGUgU3lzdGVtcy4KWyAgT0sgIF0gU3Rv cHBlZCB0YXJnZXQgUmVtb3RlIEZpbGUgU3lzdGVtcyAoUHJlKS4KWyAgT0sgIF0gU3RvcHBlZCBk cmFjdXQgaW5pdHF1ZXVlIGhvb2suClsgIE9LICBdIFN0b3BwZWQgdGFyZ2V0IFNvY2tldHMuClsg IE9LICBdIFN0b3BwZWQgQXBwbHkgS2VybmVsIFZhcmlhYmxlcy4KWyAgT0sgIF0gU3RvcHBlZCBM b2FkIEtlcm5lbCBNb2R1bGVzLgpbICBPSyAgXSBTdG9wcGVkIHVkZXYgQ29sZHBsdWcgYWxsIERl dmljZXMuCiAgICAgICAgIFN0YXJ0aW5nIFNldHVwIFZpcnR1YWwgQ29uc29sZS4uLgpbICBPSyAg XSBTdG9wcGVkIHRhcmdldCBTd2FwLgogICAgICAgICBTdGFydGluZyBQbHltb3V0aCBzd2l0Y2gg cm9vdCBzZXJ2aWNlLi4uClsgIE9LICBdIFN0b3BwZWQgdGFyZ2V0IFRpbWVycy4KWyAgT0sgIF0g U3RvcHBlZCB0YXJnZXQgU2xpY2VzLgpbICBPSyAgXSBTdG9wcGVkIHVkZXYgS2VybmVsIERldmlj ZSBNYW5hZ2VyLgpbICBPSyAgXSBTdG9wcGVkIGRyYWN1dCBwcmUtdWRldiBob29rLgpbICBPSyAg XSBTdG9wcGVkIGRyYWN1dCBjbWRsaW5lIGhvb2suCiAgICAgICAgIFN0b3BwaW5nIEhhcmR3YXJl IFJORyBFbnRyb3B5IEdhdGhlcmVyIERhZW1vbi4uLgpbICBPSyAgXSBTdG9wcGVkIENyZWF0ZSBT dGF0aWMgRGV2aWNlIE5vZGVzIGluIC9kZXYuClsgIE9LICBdIFN0b3BwZWQgQ3JlYXRlIGxpc3Qg b2YgcmVxdWlyZWQgc3Rh4oCmdmljZSBub2RlcyBmb3IgdGhlIGN1cnJlbnQga2VybmVsLgpbICBP SyAgXSBDbG9zZWQgdWRldiBLZXJuZWwgU29ja2V0LgpbICBPSyAgXSBDbG9zZWQgdWRldiBDb250 cm9sIFNvY2tldC4KICAgICAgICAgU3RhcnRpbmcgQ2xlYW51cCB1ZGV2ZCBEQi4uLgpbICBPSyAg XSBTdGFydGVkIENsZWFuaW5nIFVwIGFuZCBTaHV0dGluZyBEb3duIERhZW1vbnMuClsgIE9LICBd IFN0b3BwZWQgSGFyZHdhcmUgUk5HIEVudHJvcHkgR2F0aGVyZXIgRGFlbW9uLgpbICBPSyAgXSBT dGFydGVkIENsZWFudXAgdWRldmQgREIuClsgIE9LICBdIFN0YXJ0ZWQgUGx5bW91dGggc3dpdGNo IHJvb3Qgc2VydmljZS4KWyAgT0sgIF0gU3RhcnRlZCBTZXR1cCBWaXJ0dWFsIENvbnNvbGUuClsg IE9LICBdIFJlYWNoZWQgdGFyZ2V0IFN3aXRjaCBSb290LgogICAgICAgICBTdGFydGluZyBTd2l0 Y2ggUm9vdC4uLgpbICAgMjIuMTkwNzg2XSBzeXN0ZW1kLWpvdXJuYWxkWzIwMF06IFJlY2VpdmVk IFNJR1RFUk0gZnJvbSBQSUQgMSAoc3lzdGVtZCkuClsgICAyMi4yMjU0NzFdIHByaW50azogc3lz dGVtZDogMjIgb3V0cHV0IGxpbmVzIHN1cHByZXNzZWQgZHVlIHRvIHJhdGVsaW1pdGluZwpbICAg MjIuMzE1NTM3XSBTRUxpbnV4OiAgUnVudGltZSBkaXNhYmxlIGlzIGRlcHJlY2F0ZWQsIHVzZSBz ZWxpbnV4PTAgb24gdGhlIGtlcm5lbCBjbWRsaW5lLgpbICAgMjIuMzIzNzk2XSBTRUxpbnV4OiAg aHR0cHM6Ly9naXRodWIuY29tL1NFTGludXhQcm9qZWN0L3NlbGludXgta2VybmVsL3dpa2kvREVQ UkVDQVRFLXJ1bnRpbWUtZGlzYWJsZQpbICAgMjcuNTYwNDM1XSBTRUxpbnV4OiAgRGlzYWJsZWQg YXQgcnVudGltZS4KWyAgIDI3LjU5MjQzOV0gYXVkaXQ6IHR5cGU9MTQwNCBhdWRpdCgxNjU4Mzgy ODI2Ljg2ODoyKTogZW5mb3JjaW5nPTAgb2xkX2VuZm9yY2luZz0wIGF1aWQ9NDI5NDk2NzI5NSBz ZXM9NDI5NDk2NzI5NSBlbmFibGVkPTAgb2xkLWVuYWJsZWQ9MSBsc209c2VsaW51eCByZXM9MQpb ICAgMjcuNjM3NjY5XSBzeXN0ZW1kWzFdOiBzeXN0ZW1kIDIzOSAoMjM5LTQwLmVsOCkgcnVubmlu ZyBpbiBzeXN0ZW0gbW9kZS4gKCtQQU0gK0FVRElUICtTRUxJTlVYICtJTUEgLUFQUEFSTU9SICtT TUFDSyArU1lTVklOSVQgK1VUTVAgK0xJQkNSWVBUU0VUVVAgK0dDUllQVCArR05VVExTICtBQ0wg K1haICtMWjQgK1NFQ0NPTVAgK0JMS0lEICtFTEZVVElMUyArS01PRCArSUROMiAtSUROICtQQ1JF MiBkZWZhdWx0LWhpZXJhcmNoeT1sZWdhY3kpClsgICAyNy42NjA1NTFdIHN5c3RlbWRbMV06IERl dGVjdGVkIGFyY2hpdGVjdHVyZSB4ODYtNjQuCgpXZWxjb21lIHRvIFJlZCBIYXQgRW50ZXJwcmlz ZSBMaW51eCA4LjMgKE9vdHBhKSFbICAgMjcuNjc1OTkwXSBzCnlzdGVtZFsxXTogU2V0IGhvc3Ru YW1lIHRvIDxpY3gtCjJzMT4uClsgICAyOC4wMjI5NzhdIHN5c3RlbWRbMV06IGJhc2ljLnRhcmdl dDogRm91bmQgb3JkZXJpbmcgY3ljbGUgb24gcGF0aHMudGFyZ2V0L3N0YXJ0ClsgICAyOC4wMzA1 MzhdIHN5c3RlbWRbMV06IGJhc2ljLnRhcmdldDogRm91bmQgZGVwZW5kZW5jeSBvbiBwbWxvZ2dl cl9jaGVjay5wYXRoL3N0YXJ0ClsgICAyOC4wMzgzMjZdIHN5c3RlbWRbMV06IGJhc2ljLnRhcmdl dDogRm91bmQgZGVwZW5kZW5jeSBvbiBwbWxvZ2dlci5zZXJ2aWNlL3N0YXJ0ClsgICAyOC4wNDU4 MTJdIHN5c3RlbWRbMV06IGJhc2ljLnRhcmdldDogRm91bmQgZGVwZW5kZW5jeSBvbiBwbWNkLnNl cnZpY2Uvc3RhcnQKWyAgIDI4LjA1Mjk0M10gc3lzdGVtZFsxXTogYmFzaWMudGFyZ2V0OiBGb3Vu ZCBkZXBlbmRlbmN5IG9uIGJhc2ljLnRhcmdldC9zdGFydApbICAgMjguMDYwMTQyXSBzeXN0ZW1k WzFdOiBiYXNpYy50YXJnZXQ6IEpvYiBwYXRocy50YXJnZXQvc3RhcnQgZGVsZXRlZCB0byBicmVh ayBvcmRlcmluZyBjeWNsZSBzdGFydGluZyB3aXRoIGJhc2ljLnRhcmdldC9zdGFydApbIFNLSVAg XSBPcmRlcmluZyBjeWNsZSBmb3VuZCwgc2tpcHBpbmcgUGF0aHMKWyAgIDI4LjA3NzYyMF0gc3lz dGVtZFsxXTogc3lzdGVtZC1qb3VybmFsZC5zZXJ2aWNlOiBTdWNjZWVkZWQuClsgIE9LICBdIFN0 b3BwZWQgU3dpdGNoIFJvb3QuClsgIE9LICBdIFN0b3BwZWQgSm91cm5hbCBTZXJ2aWNlLgogICAg ICAgICBTdGFydGluZyBKb3VybmFsIFNlcnZpY2UuLi4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIERl dmljZS1tYXBwZXIgZXZlbnQgZGFlbW9uIEZJRk9zLgogICAgICAgICBNb3VudGluZyBQT1NJWCBN ZXNzYWdlIFF1ZXVlIEZpbGUgU3lzdGVtLi4uClsgIE9LICBdIFN0YXJ0ZWQgRm9yd2FyZCBQYXNz d29yZCBSZXF1ZXN0cyB0byBXYWxsIERpcmVjdG9yeSBXYXRjaC4KICAgICAgICAgU3RhcnRpbmcg Q3JlYXRlIGxpc3Qgb2YgcmVxdWlyZWQgc3TigKZjZSBub2RlcyBmb3IgdGhlIGN1cnJlbnQga2Vy bmVsLi4uCiAgICAgICAgIFN0YXJ0aW5nIExvYWQgS2VybmVsIE1vZHVsZXMuLi4KWyAgT0sgIF0g TGlzdGVuaW5nIG9uIHVkZXYgQ29udHJvbCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBp bml0Y3RsIENvbXBhdGliaWxpdHkgTmFtZWQgUGlwZS4KWyAgT0sgIF0gQ3JlYXRlZCBzbGljZSBV c2VyIGFuZCBTZXNzaW9uIFNsaWNlLgogICAgICAgICBTdGFydGluZyBNb25pdG9yaW5nIG9mIExW TTIgbWlycm9yc+KApm5nIGRtZXZlbnRkIG9yIHByb2dyZXNzIHBvbGxpbmcuLi4KWyAgT0sgIF0g U2V0IHVwIGF1dG9tb3VudCBBcmJpdHJhcnkgRXhlY3V0YWLigKZybWF0cyBGaWxlIFN5c3RlbSBB dXRvbW91bnQgUG9pbnQuClsgIE9LICBdIExpc3RlbmluZyBvbiB1ZGV2IEtlcm5lbCBTb2NrZXQu ClsgIE9LICBdIENyZWF0ZWQgc2xpY2Ugc3lzdGVtLXNzaGRceDJka2V5Z2VuLnNsaWNlLgpbICBP SyAgXSBDcmVhdGVkIHNsaWNlIHN5c3RlbS1nZXR0eS5zbGljZS4KWyAgT0sgIF0gQ3JlYXRlZCBz bGljZSBzeXN0ZW0tc2VyaWFsXHgyZGdldHR5LnNsaWNlLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdl dCBTbGljZXMuClsgIE9LICBdIFN0b3BwZWQgRmlsZSBTeXN0ZW0gQ2hlY2sgb24gUm9vdCBEZXZp Y2UuCiAgICAgICAgIFN0YXJ0aW5nIFJlbW91bnQgUm9vdCBhbmQgS2VybmVsIEZpbGUgU3lzdGVt cy4uLgogICAgICAgICBTdGFydGluZyBSZWFkIGFuZCBzZXQgTklTIGRvbWFpbm5hbWUgZnJvbSAv ZXRjL3N5c2NvbmZpZy9uZXR3b3JrLi4uClsgIE9LICBdIENyZWF0ZWQgc2xpY2Ugc3lzdGVtLXN5 c3RlbWRceDJkZnNjay5zbGljZS4KWyAgT0sgIF0gTGlzdGVuaW5nIG9uIFByb2Nlc3MgQ29yZSBE dW1wIFNvY2tldC4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTG9jYWwgRW5jcnlwdGVkIFZvbHVt ZXMuCiAgICAgICAgIEFjdGl2YXRpbmcgc3dhcCAvZGV2L21hcHBlci9yaGVsLXN3YXAuLi4KWyAg T0sgIF0gTGlzdGVuaW5nIG9uIFJQQ2JpbmQgU2VydmVyIEFjdGl2YXRpb24gU29ja2V0LgpbICBP SyAgXSBSZWFjaGVkIHRhcmdldCBSUEMgUG9ydCBNYXBwZXIuClsgICAyOC4yNzkxOTVdIHhmcyBm aWxlc3lzdGVtIGJlaW5nIHJlbW91bnRlZCBhdCAvIHN1cHBvcnRzIHRpbWVzdGFtcHMgdW50aWwg MjAzOCAoMHg3ZmZmZmZmZikKICAgICAgICAgTW91bnRpbmcgS2VybmVsIERlYnVnIEZpbGUgU3lz dGVtLi4uClsgIE9LICBdIFN0b3BwZWQgdGFyZ2V0IFN3aXRjaCBSb290LgogICAgICAgICBTdGFy dGluZyBTZXR1cCBWaXJ0dWFsIENvbnNvbGUuLi4KWyAgT0sgIF0gU3RvcHBlZCB0YXJnZXQgSW5p dHJkIEZpbGUgU3lzdGVtcy4KWyAgT0sgIF0gU3RvcHBlZCB0YXJnZXQgSW5pdHJkIFJvb3QgRmls ZSBTeXN0ZW0uClsgIE9LICBdIFN0b3BwZWQgUGx5bW91dGggc3dpdGNoIHJvb3Qgc2VydmljZS4K ICAgICAgICAgU3RhcnRpbmcgdWRldiBDb2xkcGx1ZyBhbGwgRGV2aWNlcy4uLgpbICBPSyAgXSBM aXN0ZW5pbmcgb24gTFZNMiBwb2xsIGRhZW1vbiBzb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBv biBtdWx0aXBhdGhkIGNvbnRyb2wgc29ja2V0LgpbICBPSyAgXSBNb3VudGVkIFBPU0lYIE1lc3Nh Z2UgUXVldWUgRmlsZSBTeXN0ZW0uClsgIE9LICBdIFN0YXJ0ZWQgQ3JlYXRlIGxpc3Qgb2YgcmVx dWlyZWQgc3Rh4oCmdmljZSBub2RlcyBmb3IgdGhlIGN1cnJlbnQga2VybmVsLgpbICBPSyAgXSBT dGFydGVkIExvYWQgS2VybmVsIE1vZHVsZXMuClsgIE9LICBdIFN0YXJ0ZWQgUmVtb3VudCBSb290 IGFuZCBLZXJuZWwgRmlsZSBTeXN0ZW1zLgpbICBPSyAgXSBTdGFydGVkIFJlYWQgYW5kIHNldCBO SVMgZG9tYWlubmFtZSBmcm9tIC9ldGMvc3lzY29uZmlnL25ldHdvcmsuClsgICAyOC4zNzMxNThd IEFkZGluZyAyMDk3MTQ4ayBzd2FwIG9uIC9kZXYvbWFwcGVyL3JoZWwtc3dhcC4gIFByaW9yaXR5 Oi0yIGV4dGVudHM6MSBhY3Jvc3M6MjA5NzE0OGsgU1NGUwogICAgICAgICBTdGFydGluZyBMb2Fk L1NhdmUgUmFuZG9tIFNlZWQuLi4KICAgICAgICAgU3RhcnRpbmcgQXBwbHkgS2VybmVsIFZhcmlh Ymxlcy4uLgogICAgICAgICBNb3VudGluZyBGVVNFIENvbnRyb2wgRmlsZSBTeXN0ZW0uLi4KICAg ICAgICAgU3RhcnRpbmcgQ3JlYXRlIFN0YXRpYyBEZXZpY2UgTm9kZXMgaW4gL2Rldi4uLgpbICBP SyAgXSBBY3RpdmF0ZWQgc3dhcCAvZGV2L21hcHBlci9yaGVsLXN3YXAuClsgIE9LICBdIFN0YXJ0 ZWQgSm91cm5hbCBTZXJ2aWNlLgpbICBPSyAgXSBNb3VudGVkIEtlcm5lbCBEZWJ1ZyBGaWxlIFN5 c3RlbS4KWyAgT0sgIF0gU3RhcnRlZCBMb2FkL1NhdmUgUmFuZG9tIFNlZWQuClsgIE9LICBdIE1v dW50ZWQgRlVTRSBDb250cm9sIEZpbGUgU3lzdGVtLgogICAgICAgICBTdGFydGluZyBGbHVzaCBK b3VybmFsIHRvIFBlcnNpc3RlbnQgU3RvcmFnZS4uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBT d2FwLgpbICBPSyAgXSBTdGFydGVkIEFwcGx5IEtlcm5lbCBWYXJpYWJsZXMuClsgICAyOC40OTI0 MTFdIHN5c3RlbWQtam91cm5hbGRbNjYxXTogUmVjZWl2ZWQgcmVxdWVzdCB0byBmbHVzaCBydW50 aW1lIGpvdXJuYWwgZnJvbSBQSUQgMQpbICBPSyAgXSBTdGFydGVkIEZsdXNoIEpvdXJuYWwgdG8g UGVyc2lzdGVudCBTdG9yYWdlLgpbICBPSyAgXSBTdGFydGVkIENyZWF0ZSBTdGF0aWMgRGV2aWNl IE5vZGVzIGluIC9kZXYuCiAgICAgICAgIFN0YXJ0aW5nIHVkZXYgS2VybmVsIERldmljZSBNYW5h Z2VyLi4uClsgIE9LICBdIFN0YXJ0ZWQgU2V0dXAgVmlydHVhbCBDb25zb2xlLgpbICBPSyAgXSBT dGFydGVkIHVkZXYgS2VybmVsIERldmljZSBNYW5hZ2VyLgpbICBPSyAgXSBTdGFydGVkIHVkZXYg Q29sZHBsdWcgYWxsIERldmljZXMuCiAgICAgICAgIFN0YXJ0aW5nIHVkZXYgV2FpdCBmb3IgQ29t cGxldGUgRGV2aWNlIEluaXRpYWxpemF0aW9uLi4uClsgICAyOS40OTY3MDhdIHBvd2VyX21ldGVy IEFDUEkwMDBEOjAwOiBGb3VuZCBBQ1BJIHBvd2VyIG1ldGVyLgpbICAgMjkuNTAyNTQ3XSBwb3dl cl9tZXRlciBBQ1BJMDAwRDowMDogSWdub3JpbmcgdW5zYWZlIHNvZnR3YXJlIHBvd2VyIGNhcCEK WyAgIDI5LjUwOTM3Ml0gcG93ZXJfbWV0ZXIgQUNQSTAwMEQ6MDA6IGh3bW9uX2RldmljZV9yZWdp c3RlcigpIGlzIGRlcHJlY2F0ZWQuIFBsZWFzZSBjb252ZXJ0IHRoZSBkcml2ZXIgdG8gdXNlIGh3 bW9uX2RldmljZV9yZWdpc3Rlcl93aXRoX2luZm8oKS4KWyogICAgIF0gKDEgb2YgMikgQSBzdGFy dCBqb2IgaXMgcnVubmluZyBmb3LigKZyIHByb2dyZXNzIHBvbGxpbmcgKDZzIC8gbm8gbGltaXQp WyoqICAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZyIHByb2dyZXNz IHBvbGxpbmcgKDZzIC8gbm8gbGltaXQpWyoqKiAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMg cnVubmluZyBmb3LigKZyIHByb2dyZXNzIHBvbGxpbmcgKDdzIC8gbm8gbGltaXQpWyAqKiogIF0g KDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZ2aWNlIEluaXRpYWxpemF0aW9u ICg3cyAvIDNtaW4gMXMpWyAgKioqIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBm b3LigKZ2aWNlIEluaXRpYWxpemF0aW9uICg4cyAvIDNtaW4gMXMpWyAgICoqKl0gKDIgb2YgMikg QSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZ2aWNlIEluaXRpYWxpemF0aW9uICg4cyAvIDNt aW4gMXMpWyAgICAqKl0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZyIHBy b2dyZXNzIHBvbGxpbmcgKDlzIC8gbm8gbGltaXQpWyAgICAgKl0gKDEgb2YgMikgQSBzdGFydCBq b2IgaXMgcnVubmluZyBmb3LigKZyIHByb2dyZXNzIHBvbGxpbmcgKDlzIC8gbm8gbGltaXQpWyAg ICAqKl0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9s bGluZyAoMTBzIC8gbm8gbGltaXQpWyAgICoqKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVu bmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDEwcyAvIDNtaW4gMXMpWyAgKioqIF0gKDIg b2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDEx cyAvIDNtaW4gMXMpWyAqKiogIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3Li gKZpY2UgSW5pdGlhbGl6YXRpb24gKDExcyAvIDNtaW4gMXMpWyoqKiAgIF0gKDEgb2YgMikgQSBz dGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMTJzIC8gbm8gbGlt aXQpWyoqICAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jl c3MgcG9sbGluZyAoMTJzIC8gbm8gbGltaXQpWyogICAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2Ig aXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMTNzIC8gbm8gbGltaXQpWyoqICAg IF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRp b24gKDEzcyAvIDNtaW4gMXMpWyoqKiAgIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmlu ZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDE0cyAvIDNtaW4gMXMpWyAqKiogIF0gKDIgb2Yg MikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDE0cyAv IDNtaW4gMXMpWyAgKioqIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYg cHJvZ3Jlc3MgcG9sbGluZyAoMTVzIC8gbm8gbGltaXQpWyAgICoqKl0gKDEgb2YgMikgQSBzdGFy dCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMTVzIC8gbm8gbGltaXQp WyAgICAqKl0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3Mg cG9sbGluZyAoMTZzIC8gbm8gbGltaXQpWyAgICAgKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMg cnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDE2cyAvIDNtaW4gMXMpWyAgICAqKl0g KDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24g KDE3cyAvIDNtaW4gMXMpWyAgICoqKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBm b3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDE3cyAvIDNtaW4gMXMpWyAgKioqIF0gKDEgb2YgMikg QSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMThzIC8gbm8g bGltaXQpWyAqKiogIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJv Z3Jlc3MgcG9sbGluZyAoMThzIC8gbm8gbGltaXQpWyoqKiAgIF0gKDEgb2YgMikgQSBzdGFydCBq b2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMTlzIC8gbm8gbGltaXQpWyoq ICAgIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6 YXRpb24gKDE5cyAvIDNtaW4gMXMpWyogICAgIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVu bmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDIwcyAvIDNtaW4gMXMpWyoqICAgIF0gKDIg b2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDIw cyAvIDNtaW4gMXMpWyoqKiAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3Li gKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjFzIC8gbm8gbGltaXQpWyAqKiogIF0gKDEgb2YgMikgQSBz dGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjFzIC8gbm8gbGlt aXQpWyAgKioqIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jl c3MgcG9sbGluZyAoMjJzIC8gbm8gbGltaXQpWyAgICoqKl0gKDIgb2YgMikgQSBzdGFydCBqb2Ig aXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDIycyAvIDNtaW4gMXMpWyAgICAq Kl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRp b24gKDIzcyAvIDNtaW4gMXMpWyAgICAgKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmlu ZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDIzcyAvIDNtaW4gMXMpWyAgICAqKl0gKDEgb2Yg MikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjRzIC8g bm8gbGltaXQpWyAgICoqKl0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYg cHJvZ3Jlc3MgcG9sbGluZyAoMjRzIC8gbm8gbGltaXQpWyAgKioqIF0gKDEgb2YgMikgQSBzdGFy dCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjVzIC8gbm8gbGltaXQp WyAqKiogIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlh bGl6YXRpb24gKDI1cyAvIDNtaW4gMXMpWyoqKiAgIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMg cnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDI2cyAvIDNtaW4gMXMpWyoqICAgIF0g KDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24g KDI2cyAvIDNtaW4gMXMpWyogICAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBm b3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjdzIC8gbm8gbGltaXQpWyoqICAgIF0gKDEgb2YgMikg QSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMjdzIC8gbm8g bGltaXQpWyoqKiAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJv Z3Jlc3MgcG9sbGluZyAoMjhzIC8gbm8gbGltaXQpWyAqKiogIF0gKDIgb2YgMikgQSBzdGFydCBq b2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDI4cyAvIDNtaW4gMXMpWyAg KioqIF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6 YXRpb24gKDI5cyAvIDNtaW4gMXMpWyAgICoqKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVu bmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDI5cyAvIDNtaW4gMXMpWyAgICAqKl0gKDEg b2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMzBz IC8gbm8gbGltaXQpWyAgICAgKl0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3Li gKYgcHJvZ3Jlc3MgcG9sbGluZyAoMzBzIC8gbm8gbGltaXQpWyAgICAqKl0gKDEgb2YgMikgQSBz dGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMzFzIC8gbm8gbGlt aXQpWyAgICoqKl0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5p dGlhbGl6YXRpb24gKDMxcyAvIDNtaW4gMXMpWyAgKioqIF0gKDIgb2YgMikgQSBzdGFydCBqb2Ig aXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRpb24gKDMycyAvIDNtaW4gMXMpWyAqKiog IF0gKDIgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKZpY2UgSW5pdGlhbGl6YXRp b24gKDMycyAvIDNtaW4gMXMpWyoqKiAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmlu ZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMzNzIC8gbm8gbGltaXQpWyoqICAgIF0gKDEgb2Yg MikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYgcHJvZ3Jlc3MgcG9sbGluZyAoMzNzIC8g bm8gbGltaXQpWyogICAgIF0gKDEgb2YgMikgQSBzdGFydCBqb2IgaXMgcnVubmluZyBmb3LigKYg cHJvZ3Jlc3MgcG9sbGluZyAoMzRzIC8gbm8gbGltaXQpWyAgIDYyLjUzMzU3N10gSVBNSSBtZXNz YWdlIGhhbmRsZXI6IHZlcnNpb24gMzkuMgpbICAgNjIuNTQ4MzIyXSBpcG1pIGRldmljZSBpbnRl cmZhY2UKWyAgIDYyLjU2MzcxMV0gaXBtaV9zaTogSVBNSSBTeXN0ZW0gSW50ZXJmYWNlIGRyaXZl cgpbICAgNjIuNTc2OTg0XSBpcG1pX3NpIGRtaS1pcG1pLXNpLjA6IGlwbWlfcGxhdGZvcm06IHBy b2JpbmcgdmlhIFNNQklPUwpbICAgNjIuNTgzNDUxXSBpcG1pX3BsYXRmb3JtOiBpcG1pX3NpOiBT TUJJT1M6IGlvIDB4Y2EyIHJlZ3NpemUgMSBzcGFjaW5nIDEgaXJxIDAKWyAgIDYyLjU5MDgyNF0g aXBtaV9zaTogQWRkaW5nIFNNQklPUy1zcGVjaWZpZWQga2NzIHN0YXRlIG1hY2hpbmUKWyAgIDYy LjU5NjkxOV0gaXBtaV9zaSBJUEkwMDAxOjAwOiBpcG1pX3BsYXRmb3JtOiBwcm9iaW5nIHZpYSBB Q1BJClsgICA2Mi42MDMwMzBdIGlwbWlfc2kgSVBJMDAwMTowMDogaXBtaV9wbGF0Zm9ybTogW2lv ICAweDBjYTItMHgwY2EzXSByZWdzaXplIDEgc3BhY2luZyAxIGlycSAwClsgICA2Mi42MzA5ODJd IGlwbWlfc2kgZG1pLWlwbWktc2kuMDogUmVtb3ZpbmcgU01CSU9TLXNwZWNpZmllZCBrY3Mgc3Rh dGUgbWFjaGluZSBpbiBmYXZvciBvZiBBQ1BJClsgICA2Mi42Mzk3ODVdIGlwbWlfc2k6IEFkZGlu ZyBBQ1BJLXNwZWNpZmllZCBrY3Mgc3RhdGUgbWFjaGluZQpbICAgNjIuNjU0MDk5XSBpcG1pX3Np OiBUcnlpbmcgQUNQSS1zcGVjaWZpZWQga2NzIHN0YXRlIG1hY2hpbmUgYXQgaS9vIGFkZHJlc3Mg MHhjYTIsIHNsYXZlIGFkZHJlc3MgMHgyMCwgaXJxIDAKWyAgIDYyLjc5NDMxM10gaXBtaV9zaSBJ UEkwMDAxOjAwOiBUaGUgQk1DIGRvZXMgbm90IHN1cHBvcnQgY2xlYXJpbmcgdGhlIHJlY3YgaXJx IGJpdCwgY29tcGVuc2F0aW5nLCBidXQgdGhlIEJNQyBuZWVkcyB0byBiZSBmaXhlZC4KWyAgIDYy LjkyNzcxNl0gaXBtaV9zaSBJUEkwMDAxOjAwOiBJUE1JIG1lc3NhZ2UgaGFuZGxlcjogRm91bmQg bmV3IEJNQyAobWFuX2lkOiAweDAwMDE1NywgcHJvZF9pZDogMHgwMDdiLCBkZXZfaWQ6IDB4MjMp ClsqKiAgICBdICgyIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmaWNlIEluaXRp YWxpemF0aW9uICgzNHMgLyAzbWluIDFzKVsgICA2My4xNzI0MDZdIGlwbWlfc2kgSVBJMDAwMTow MDogSVBNSSBrY3MgaW50ZXJmYWNlIGluaXRpYWxpemVkClsqKiogICBdICgyIG9mIDIpIEEgc3Rh cnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmaWNlIEluaXRpYWxpemF0aW9uICgzNXMgLyAzbWluIDFz KVsgKioqICBdICgyIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmaWNlIEluaXRp YWxpemF0aW9uICgzNXMgLyAzbWluIDFzKVsgICA2NC4zMzYxMDJdIGlvYXRkbWE6IEludGVsKFIp IFF1aWNrRGF0YSBUZWNobm9sb2d5IERyaXZlciA1LjAwClsgICA2NC4zNTA5MzZdIGlvYXRkbWEg MDAwMDowMDowMS4wOiBlbmFibGluZyBkZXZpY2UgKDAxNDQgLT4gMDE0NikKWyAgIDY0LjM2NTYy Ml0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNwpbICAgNjQuMzkxMjIyXSBpb2F0ZG1hIDAwMDA6 MDA6MDEuMTogZW5hYmxpbmcgZGV2aWNlICgwMTQ0IC0+IDAxNDYpClsgICA2NC40MDEyNTRdIEFs cmVhZHkgc2V0dXAgdGhlIEdTSSA6MTcKWyAgIDY0LjQxODcxOF0gaW9hdGRtYSAwMDAwOjAwOjAx LjI6IGVuYWJsaW5nIGRldmljZSAoMDE0NCAtPiAwMTQ2KQpbICAgNjQuNDMyODQ1XSBBbHJlYWR5 IHNldHVwIHRoZSBHU0kgOjE3ClsgICoqKiBdICgxIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5p bmcgZm9y4oCmIHByb2dyZXNzIHBvbGxpbmcgKDM2cyAvIG5vIGxpbWl0KVsgICA2NC40NTkwOTdd IGlvYXRkbWEgMDAwMDowMDowMS4zOiBlbmFibGluZyBkZXZpY2UgKDAxNDQgLT4gMDE0NikKWyAg IDY0LjQ2NTkyMl0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNwpbICAgNjQuNDgzMTE4XSBpb2F0 ZG1hIDAwMDA6MDA6MDEuNDogZW5hYmxpbmcgZGV2aWNlICgwMTQ0IC0+IDAxNDYpClsgICA2NC40 OTAzNTZdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTcKWyAgIDY0LjUwNzEzN10gaW9hdGRtYSAw MDAwOjAwOjAxLjU6IGVuYWJsaW5nIGRldmljZSAoMDE0NCAtPiAwMTQ2KQpbICAgNjQuNTEzNTA5 XSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE3ClsgICA2NC41Mjk3OThdIGlvYXRkbWEgMDAwMDow MDowMS42OiBlbmFibGluZyBkZXZpY2UgKDAxNDQgLT4gMDE0NikKWyAgIDY0LjUzNjYzNl0gQWxy ZWFkeSBzZXR1cCB0aGUgR1NJIDoxNwpbICAgNjQuNTUzOTkxXSBpb2F0ZG1hIDAwMDA6MDA6MDEu NzogZW5hYmxpbmcgZGV2aWNlICgwMTQ0IC0+IDAxNDYpClsgICA2NC41NjAzOTFdIEFscmVhZHkg c2V0dXAgdGhlIEdTSSA6MTcKWyAgIDY0LjU3NzUwOV0gaW9hdGRtYSAwMDAwOjgwOjAxLjA6IGVu YWJsaW5nIGRldmljZSAoMDE0NCAtPiAwMTQ2KQpbICAgNjQuNTg0NjAwXSBBbHJlYWR5IHNldHVw IHRoZSBHU0kgOjE2ClsgICA2NC42MDE2NDJdIGlvYXRkbWEgMDAwMDo4MDowMS4xOiBlbmFibGlu ZyBkZXZpY2UgKDAxNDQgLT4gMDE0NikKWyAgIDY0LjYwODA3N10gQWxyZWFkeSBzZXR1cCB0aGUg R1NJIDoxNgpbICAgNjQuNjI0NDE2XSBpb2F0ZG1hIDAwMDA6ODA6MDEuMjogZW5hYmxpbmcgZGV2 aWNlICgwMTQ0IC0+IDAxNDYpClsgICA2NC42MzEzNzVdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6 MTYKWyAgIDY0LjY0ODM3OF0gaW9hdGRtYSAwMDAwOjgwOjAxLjM6IGVuYWJsaW5nIGRldmljZSAo MDE0NCAtPiAwMTQ2KQpbICAgNjQuNjU1MzEzXSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE2Clsg ICA2NC42NzE0MzJdIGlvYXRkbWEgMDAwMDo4MDowMS40OiBlbmFibGluZyBkZXZpY2UgKDAxNDQg LT4gMDE0NikKWyAgIDY0LjY3ODU2OF0gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpbICAgNjQu Njk0OTAxXSBpb2F0ZG1hIDAwMDA6ODA6MDEuNTogZW5hYmxpbmcgZGV2aWNlICgwMTQ0IC0+IDAx NDYpClsgICA2NC43MDE1OTRdIEFscmVhZHkgc2V0dXAgdGhlIEdTSSA6MTYKWyAgIDY0LjcxODc0 OV0gaW9hdGRtYSAwMDAwOjgwOjAxLjY6IGVuYWJsaW5nIGRldmljZSAoMDE0NCAtPiAwMTQ2KQpb ICAgNjQuNzI1NjM5XSBBbHJlYWR5IHNldHVwIHRoZSBHU0kgOjE2ClsgICA2NC43NDI3NjVdIGlv YXRkbWEgMDAwMDo4MDowMS43OiBlbmFibGluZyBkZXZpY2UgKDAxNDQgLT4gMDE0NikKWyAgIDY0 Ljc0OTEzM10gQWxyZWFkeSBzZXR1cCB0aGUgR1NJIDoxNgpbICAgNjQuODg1NzM2XSBtZWlfbWUg MDAwMDowMDoxNi4wOiBEZXZpY2UgZG9lc24ndCBoYXZlIHZhbGlkIE1FIEludGVyZmFjZQpbICAg KioqXSAoMSBvZiAyKSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvcuKApiBwcm9ncmVzcyBwb2xs aW5nICgzNnMgLyBubyBsaW1pdClbICAgNjQuOTY0MTY1XSBpODAxX3NtYnVzIDAwMDA6MDA6MWYu NDogZW5hYmxpbmcgZGV2aWNlICgwMDAwIC0+IDAwMDMpClsgICA2NC45Nzk3OTNdIEFscmVhZHkg c2V0dXAgdGhlIEdTSSA6MTYKWyAgIDY0Ljk5MjI3MF0gaTgwMV9zbWJ1cyAwMDAwOjAwOjFmLjQ6 IFNQRCBXcml0ZSBEaXNhYmxlIGlzIHNldApbICAgNjUuMDA2OTIzXSBpODAxX3NtYnVzIDAwMDA6 MDA6MWYuNDogU01CdXMgdXNpbmcgUENJIGludGVycnVwdApbICAgNjUuMDMwOTcwXSBpMmMgaTJj LTE6IDgvMzIgbWVtb3J5IHNsb3RzIHBvcHVsYXRlZCAoZnJvbSBETUkpClsgICA2NS4wMzcwMjFd IGkyYyBpMmMtMTogU3lzdGVtcyB3aXRoIG1vcmUgdGhhbiA0IG1lbW9yeSBzbG90cyBub3Qgc3Vw cG9ydGVkIHlldCwgbm90IGluc3RhbnRpYXRpbmcgU1BEClsgIE9LICBdIENyZWF0ZWQgc2xpY2Ug c3lzdGVtLWx2bTJceDJkcHZzY2FuLnNsaWNlLgogICAgICAgICBTdGFydGluZyBMVk0gZXZlbnQg YWN0aXZhdGlvbiBvbiBkZXZpY2UgODozLi4uClsgIE9LICBdIFN0YXJ0ZWQgTW9uaXRvcmluZyBv ZiBMVk0yIG1pcnJvcnMs4oCmc2luZyBkbWV2ZW50ZCBvciBwcm9ncmVzcyBwb2xsaW5nLgpbICAg NjUuMjA0NjM1XSBpbnB1dDogUEMgU3BlYWtlciBhcyAvZGV2aWNlcy9wbGF0Zm9ybS9wY3Nwa3Iv aW5wdXQvaW5wdXQ1ClsgIE9LICBdIFN0YXJ0ZWQgTFZNIGV2ZW50IGFjdGl2YXRpb24gb24gZGV2 aWNlIDg6My4KWyAgIDY2Ljk2NzQ1NV0gY3J5cHRkOiBtYXhfY3B1X3FsZW4gc2V0IHRvIDEwMDAK WyAgIDY2Ljk4MjI5NF0gU1NFIHZlcnNpb24gb2YgZ2NtX2VuYy9kZWMgZW5nYWdlZC4KKFhFTikg YXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYyIFJETVNSIDB4MDAwMDA2MGQgdW5p bXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjIgUkRN U1IgMHgwMDAwMDNmOCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1v cC5jOjEwMjc6ZDB2MiBSRE1TUiAweDAwMDAwM2Y5IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94 ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYyIFJETVNSIDB4MDAwMDAzZmEgdW5pbXBsZW1l bnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjIgUkRNU1IgMHgw MDAwMDYzMCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEw Mjc6ZDB2MiBSRE1TUiAweDAwMDAwNjMxIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYv ZW11bC1wcml2LW9wLmM6MTAyNzpkMHYyIFJETVNSIDB4MDAwMDA2MzIgdW5pbXBsZW1lbnRlZApb ICAgNjcuMTQ1NzI2XSBpbnRlbF9wb3dlcmNsYW1wOiBObyBwYWNrYWdlIEMtc3RhdGUgYXZhaWxh YmxlCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MCBSRE1TUiAweDAw MDAwNjBkIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAy NzpkMHYwIFJETVNSIDB4MDAwMDAzZjggdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9l bXVsLXByaXYtb3AuYzoxMDI3OmQwdjAgUkRNU1IgMHgwMDAwMDNmOSB1bmltcGxlbWVudGVkCihY RU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MCBSRE1TUiAweDAwMDAwM2Zh IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYw IFJETVNSIDB4MDAwMDA2MzAgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXBy aXYtb3AuYzoxMDI3OmQwdjAgUkRNU1IgMHgwMDAwMDYzMSB1bmltcGxlbWVudGVkCihYRU4pIGFy Y2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MCBSRE1TUiAweDAwMDAwNjMyIHVuaW1w bGVtZW50ZWQKWyAgIDY3LjIyODE3NV0gaW50ZWxfcG93ZXJjbGFtcDogTm8gcGFja2FnZSBDLXN0 YXRlIGF2YWlsYWJsZQooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjIg UkRNU1IgMHgwMDAwMDYwZCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJp di1vcC5jOjEwMjc6ZDB2MiBSRE1TUiAweDAwMDAwM2Y4IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJj aC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYyIFJETVNSIDB4MDAwMDAzZjkgdW5pbXBs ZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjIgUkRNU1Ig MHgwMDAwMDNmYSB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5j OjEwMjc6ZDB2MiBSRE1TUiAweDAwMDAwNjMwIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYv cHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYyIFJETVNSIDB4MDAwMDA2MzEgdW5pbXBsZW1lbnRl ZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjIgUkRNU1IgMHgwMDAw MDYzMiB1bmltcGxlbWVudGVkClsgICA2Ny4zMTcwNTVdIGludGVsX3Bvd2VyY2xhbXA6IE5vIHBh Y2thZ2UgQy1zdGF0ZSBhdmFpbGFibGUKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6 MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2MGQgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9w di9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjEgUkRNU1IgMHgwMDAwMDNmOCB1bmltcGxlbWVudGVk CihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MSBSRE1TUiAweDAwMDAw M2Y5IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpk MHYxIFJETVNSIDB4MDAwMDAzZmEgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVs LXByaXYtb3AuYzoxMDI3OmQwdjEgUkRNU1IgMHgwMDAwMDYzMCB1bmltcGxlbWVudGVkCihYRU4p IGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2MSBSRE1TUiAweDAwMDAwNjMxIHVu aW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJE TVNSIDB4MDAwMDA2MzIgdW5pbXBsZW1lbnRlZApbICAgNjcuNDA0MTY1XSBpbnRlbF9wb3dlcmNs YW1wOiBObyBwYWNrYWdlIEMtc3RhdGUgYXZhaWxhYmxlCihYRU4pIGFyY2gveDg2L3B2L2VtdWwt cHJpdi1vcC5jOjEwMjc6ZDB2MSBSRE1TUiAweDAwMDAwNjBkIHVuaW1wbGVtZW50ZWQKKFhFTikg YXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDAzZjggdW5p bXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjEgUkRN U1IgMHgwMDAwMDNmOSB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1v cC5jOjEwMjc6ZDB2MSBSRE1TUiAweDAwMDAwM2ZhIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94 ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYxIFJETVNSIDB4MDAwMDA2MzAgdW5pbXBsZW1l bnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjEgUkRNU1IgMHgw MDAwMDYzMSB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEw Mjc6ZDB2MSBSRE1TUiAweDAwMDAwNjMyIHVuaW1wbGVtZW50ZWQKWyAgIDY3LjU5MjEwNl0gaW50 ZWxfcG93ZXJjbGFtcDogTm8gcGFja2FnZSBDLXN0YXRlIGF2YWlsYWJsZQooWEVOKSBhcmNoL3g4 Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjYgUkRNU1IgMHgwMDAwMDYwZCB1bmltcGxlbWVu dGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2NiBSRE1TUiAweDAw MDAwM2Y4IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAy NzpkMHY2IFJETVNSIDB4MDAwMDAzZjkgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9l bXVsLXByaXYtb3AuYzoxMDI3OmQwdjYgUkRNU1IgMHgwMDAwMDNmYSB1bmltcGxlbWVudGVkCihY RU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2NiBSRE1TUiAweDAwMDAwNjMw IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHY2 IFJETVNSIDB4MDAwMDA2MzEgdW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXBy aXYtb3AuYzoxMDI3OmQwdjYgUkRNU1IgMHgwMDAwMDYzMiB1bmltcGxlbWVudGVkClsgICA2Ny42 ODIwNTJdIGludGVsX3Bvd2VyY2xhbXA6IE5vIHBhY2thZ2UgQy1zdGF0ZSBhdmFpbGFibGUKKFhF TikgYXJjaC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHY1IFJETVNSIDB4MDAwMDA2MGQg dW5pbXBsZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjUg UkRNU1IgMHgwMDAwMDNmOCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJp di1vcC5jOjEwMjc6ZDB2NSBSRE1TUiAweDAwMDAwM2Y5IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJj aC94ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHY1IFJETVNSIDB4MDAwMDAzZmEgdW5pbXBs ZW1lbnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjUgUkRNU1Ig MHgwMDAwMDYzMCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5j OjEwMjc6ZDB2NSBSRE1TUiAweDAwMDAwNjMxIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYv cHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHY1IFJETVNSIDB4MDAwMDA2MzIgdW5pbXBsZW1lbnRl ZApbICAgNjcuODYxMzIxXSBpbnRlbF9wb3dlcmNsYW1wOiBObyBwYWNrYWdlIEMtc3RhdGUgYXZh aWxhYmxlClsgICA2Ny44NzQyNDldIGlUQ09fdmVuZG9yX3N1cHBvcnQ6IHZlbmRvci1zdXBwb3J0 PTAKWyAgIDY3Ljg4MTcyMF0gaVRDT193ZHQgaVRDT193ZHQ6IHVuYWJsZSB0byByZXNldCBOT19S RUJPT1QgZmxhZywgZGV2aWNlIGRpc2FibGVkIGJ5IGhhcmR3YXJlL0JJT1MKKFhFTikgYXJjaC94 ODYvcHYvZW11bC1wcml2LW9wLmM6MTAyNzpkMHYwIFJETVNSIDB4MDAwMDA2MGQgdW5pbXBsZW1l bnRlZAooWEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjAgUkRNU1IgMHgw MDAwMDNmOCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEw Mjc6ZDB2MCBSRE1TUiAweDAwMDAwM2Y5IHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYv ZW11bC1wcml2LW9wLmM6MTAyNzpkMHYwIFJETVNSIDB4MDAwMDAzZmEgdW5pbXBsZW1lbnRlZAoo WEVOKSBhcmNoL3g4Ni9wdi9lbXVsLXByaXYtb3AuYzoxMDI3OmQwdjAgUkRNU1IgMHgwMDAwMDYz MCB1bmltcGxlbWVudGVkCihYRU4pIGFyY2gveDg2L3B2L2VtdWwtcHJpdi1vcC5jOjEwMjc6ZDB2 MCBSRE1TUiAweDAwMDAwNjMxIHVuaW1wbGVtZW50ZWQKKFhFTikgYXJjaC94ODYvcHYvZW11bC1w cml2LW9wLmM6MTAyNzpkMHYwIFJETVNSIDB4MDAwMDA2MzIgdW5pbXBsZW1lbnRlZApbICAgNjcu OTk2NDM4XSBpbnRlbF9wb3dlcmNsYW1wOiBObyBwYWNrYWdlIEMtc3RhdGUgYXZhaWxhYmxlClsg IE9LICBdIFN0YXJ0ZWQgdWRldiBXYWl0IGZvciBDb21wbGV0ZSBEZXZpY2UgSW5pdGlhbGl6YXRp b24uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IExvY2FsIEZpbGUgU3lzdGVtcyAoUHJlKS4KICAg ICAgICAgTW91bnRpbmcgL2Jvb3QuLi4KICAgICAgICAgU3RhcnRpbmcgRmlsZSBTeXN0ZW0gQ2hl Y2sgb24gL2Rldi9kaXNrL2J5LXV1aWQvRjZGMS1FMTE3Li4uClsgICA2OC41MTg2MTZdIFhGUyAo c2RhMik6IE1vdW50aW5nIFY1IEZpbGVzeXN0ZW0KWyAgIDY4LjU0OTMzN10gWEZTIChzZGEyKTog RW5kaW5nIGNsZWFuIG1vdW50ClsgICA2OC41NTcyODBdIHhmcyBmaWxlc3lzdGVtIGJlaW5nIG1v dW50ZWQgYXQgL2Jvb3Qgc3VwcG9ydHMgdGltZXN0YW1wcyB1bnRpbCAyMDM4ICgweDdmZmZmZmZm KQpbICBPSyAgXSBNb3VudGVkIC9ib290LgpbICBPSyAgXSBTdGFydGVkIEZpbGUgU3lzdGVtIENo ZWNrIG9uIC9kZXYvZGlzay9ieS11dWlkL0Y2RjEtRTExNy4KICAgICAgICAgTW91bnRpbmcgL2Jv b3QvZWZpLi4uClsgIE9LICBdIE1vdW50ZWQgL2Jvb3QvZWZpLgpbICBPSyAgXSBSZWFjaGVkIHRh cmdldCBMb2NhbCBGaWxlIFN5c3RlbXMuCiAgICAgICAgIFN0YXJ0aW5nIFRlbGwgUGx5bW91dGgg VG8gV3JpdGUgT3V0IFJ1bnRpbWUgRGF0YS4uLgogICAgICAgICBTdGFydGluZyBJbXBvcnQgbmV0 d29yayBjb25maWd1cmF0aW9uIGZyb20gaW5pdHJhbWZzLi4uCiAgICAgICAgIFN0YXJ0aW5nIFJl c3RvcmUgL3J1bi9pbml0cmFtZnMgb24gc2h1dGRvd24uLi4KWyAgT0sgIF0gU3RhcnRlZCBSZXN0 b3JlIC9ydW4vaW5pdHJhbWZzIG9uIHNodXRkb3duLgpbICBPSyAgXSBTdGFydGVkIFRlbGwgUGx5 bW91dGggVG8gV3JpdGUgT3V0IFJ1bnRpbWUgRGF0YS4KWyAgT0sgIF0gU3RhcnRlZCBJbXBvcnQg bmV0d29yayBjb25maWd1cmF0aW9uIGZyb20gaW5pdHJhbWZzLgogICAgICAgICBTdGFydGluZyBD cmVhdGUgVm9sYXRpbGUgRmlsZXMgYW5kIERpcmVjdG9yaWVzLi4uClsgIE9LICBdIFN0YXJ0ZWQg Q3JlYXRlIFZvbGF0aWxlIEZpbGVzIGFuZCBEaXJlY3Rvcmllcy4KICAgICAgICAgTW91bnRpbmcg UlBDIFBpcGUgRmlsZSBTeXN0ZW0uLi4KICAgICAgICAgU3RhcnRpbmcgU2VjdXJpdHkgQXVkaXRp bmcgU2VydmljZS4uLgogICAgICAgICBTdGFydGluZyBSUEMgQmluZC4uLgpbICBPSyAgXSBTdGFy dGVkIFJQQyBCaW5kLgpbICAgNjguOTI2Mjk1XSBSUEM6IFJlZ2lzdGVyZWQgbmFtZWQgVU5JWCBz b2NrZXQgdHJhbnNwb3J0IG1vZHVsZS4KWyAgIDY4LjkzMjM4Nl0gUlBDOiBSZWdpc3RlcmVkIHVk cCB0cmFuc3BvcnQgbW9kdWxlLgpbICAgNjguOTM3MjQyXSBSUEM6IFJlZ2lzdGVyZWQgdGNwIHRy YW5zcG9ydCBtb2R1bGUuClsgICA2OC45NDIwMzVdIFJQQzogUmVnaXN0ZXJlZCB0Y3AgTkZTdjQu MSBiYWNrY2hhbm5lbCB0cmFuc3BvcnQgbW9kdWxlLgpbICBPSyAgXSBTdGFydGVkIFNlY3VyaXR5 IEF1ZGl0aW5nIFNlcnZpY2UuCiAgICAgICAgIFN0YXJ0aW5nIFVwZGF0ZSBVVE1QIGFib3V0IFN5 c3RlbSBCb290L1NodXRkb3duLi4uClsgIE9LICBdIE1vdW50ZWQgUlBDIFBpcGUgRmlsZSBTeXN0 ZW0uClsgIE9LICBdIFJlYWNoZWQgdGFyZ2V0IHJwY19waXBlZnMudGFyZ2V0LgpbICBPSyAgXSBT dGFydGVkIFVwZGF0ZSBVVE1QIGFib3V0IFN5c3RlbSBCb290L1NodXRkb3duLgpbICBPSyAgXSBS ZWFjaGVkIHRhcmdldCBTeXN0ZW0gSW5pdGlhbGl6YXRpb24uClsgIE9LICBdIFN0YXJ0ZWQgRGFp bHkgcHJvY2Vzc2luZyBvZiBQTUlFIGxvZ3MuClsgIE9LICBdIFN0YXJ0ZWQgR2VuZXJhdGUgc3Vt bWFyeSBvZiB5ZXN0ZXJkYXkncyBwcm9jZXNzIGFjY291bnRpbmcuClsgIE9LICBdIFN0YXJ0ZWQg RGFpbHkgQ2xlYW51cCBvZiBUZW1wb3JhcnkgRGlyZWN0b3JpZXMuClsgIE9LICBdIExpc3Rlbmlu ZyBvbiBPcGVuLWlTQ1NJIGlzY3NpZCBTb2NrZXQuClsgIE9LICBdIExpc3RlbmluZyBvbiBPcGVu LWlTQ1NJIGlzY3NpdWlvIFNvY2tldC4KWyAgT0sgIF0gU3RhcnRlZCBDVVBTIFNjaGVkdWxlci4K WyAgT0sgIF0gU3RhcnRlZCBkbmYgbWFrZWNhY2hlIC0tdGltZXIuClsgIE9LICBdIExpc3Rlbmlu ZyBvbiBTU1NEIEtlcmJlcm9zIENhY2hlIE1hbmFnZXIgcmVzcG9uZGVyIHNvY2tldC4KWyAgT0sg IF0gU3RhcnRlZCBkYWlseSB1cGRhdGUgb2YgdGhlIHJvb3QgdHJ1c3QgYW5jaG9yIGZvciBETlNT RUMuClsgIE9LICBdIFN0YXJ0ZWQgSGFsZi1ob3VybHkgY2hlY2sgb2YgUE1JRSBpbnN0YW5jZXMu ClsgIE9LICBdIFN0YXJ0ZWQgcG1pZV9jaGVjay5wYXRoLgpbICBPSyAgXSBTdGFydGVkIFJ1biBz eXN0ZW0gYWN0aXZpdHkgYWNjb3VudGluZyB0b29sIGV2ZXJ5IDEwIG1pbnV0ZXMuClsgIE9LICBd IExpc3RlbmluZyBvbiBQQy9TQyBTbWFydCBDYXJkIERhZW1vbiBBY3RpdmF0aW9uIFNvY2tldC4K WyAgT0sgIF0gTGlzdGVuaW5nIG9uIENVUFMgU2NoZWR1bGVyLgpbICBPSyAgXSBMaXN0ZW5pbmcg b24gQXZhaGkgbUROUy9ETlMtU0QgU3RhY2sgQWN0aXZhdGlvbiBTb2NrZXQuClsgIE9LICBdIExp c3RlbmluZyBvbiBELUJ1cyBTeXN0ZW0gTWVzc2FnZSBCdXMgU29ja2V0LgpbICBPSyAgXSBMaXN0 ZW5pbmcgb24gQWN0aXZhdGlvbiBzb2NrZXQgZm9yIHNwaWNlIGd1ZXN0IGFnZW50IGRhZW1vbi4K WyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgU29ja2V0cy4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQg QmFzaWMgU3lzdGVtLgogICAgICAgICBTdGFydGluZyBBdmFoaSBtRE5TL0ROUy1TRCBTdGFjay4u LgogICAgICAgICBTdGFydGluZyBBQlJUIEF1dG9tYXRlZCBCdWcgUmVwb3J0aW5nIFRvb2wuLi4K ICAgICAgICAgU3RhcnRpbmcgR2VuZXJhdGUgc3lzdGVtIGFjdGl2aXR5IHJlcG9ydHMuLi4KWyAg T0sgIF0gU3RhcnRlZCBNYWNoaW5lIENoZWNrIEV4Y2VwdGlvbiBMb2dnaW5nIERhZW1vbi4KICAg ICAgICAgU3RhcnRpbmcgU2VsZiBNb25pdG9yaW5nIGFuZCBSZXBvcnRpbmcgVGVjaG5vbG9neSAo U01BUlQpIERhZW1vbi4uLgogICAgICAgICBTdGFydGluZyBOVFAgY2xpZW50L3NlcnZlci4uLgog ICAgICAgICBTdGFydGluZyBNb2RlbSBNYW5hZ2VyLi4uCiAgICAgICAgIFN0YXJ0aW5nIERpc2sg TWFuYWdlci4uLgpbICBPSyAgXSBTdGFydGVkIGxpYnN0b3JhZ2VtZ210IHBsdWctaW4gc2VydmVy IGRhZW1vbi4KICAgICAgICAgU3RhcnRpbmcgSGFyZHdhcmUgTW9uaXRvcmluZyBTZW5zb3JzLi4u CiAgICAgICAgIFN0YXJ0aW5nIFJlc2V0cyBTeXN0ZW0gQWN0aXZpdHkgTG9ncy4uLgogICAgICAg ICBTdGFydGluZyBSb2xsYmFjayB1bmNvbW1pdHRlZCBuZXRjZuKApndvcmsgY29uZmlnIGNoYW5n ZSB0cmFuc2FjdGlvbnMuLi4KICAgICAgICAgU3RhcnRpbmcgSGFyZHdhcmUgUk5HIEVudHJvcHkg R2F0aGVyZXIgV2FrZSB0aHJlc2hvbGQgc2VydmljZS4uLgogICAgICAgICBTdGFydGluZyBSZWFs dGltZUtpdCBTY2hlZHVsaW5nIFBvbGljeSBTZXJ2aWNlLi4uClsgIE9LICBdIFN0YXJ0ZWQgaXJx YmFsYW5jZSBkYWVtb24uCiAgICAgICAgIFN0YXJ0aW5nIEtlcm5lbCBTYW1lcGFnZSBNZXJnaW5n Li4uClsgIE9LICBdIFN0YXJ0ZWQgRC1CdXMgU3lzdGVtIE1lc3NhZ2UgQnVzLgogICAgICAgICBT dGFydGluZyBBdXRob3JpemF0aW9uIE1hbmFnZXIuLi4KICAgICAgICAgU3RhcnRpbmcgU3lzdGVt IFNlY3VyaXR5IFNlcnZpY2VzIERhZW1vbi4uLgogICAgICAgICBTdGFydGluZyBQb2xsIHN5c3Rl bSBhY3Rpdml0eSByZXBvcnQgZ2VuZXJhdGlvbi4uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBz c2hkLWtleWdlbi50YXJnZXQuCiAgICAgICAgIFN0YXJ0aW5nIFZETyB2b2x1bWUgc2VydmljZXMu Li4KWyAgT0sgIF0gU3RhcnRlZCBTZWxmIE1vbml0b3JpbmcgYW5kIFJlcG9ydGluZyBUZWNobm9s b2d5IChTTUFSVCkgRGFlbW9uLgpbICBPSyAgXSBTdGFydGVkIFJvbGxiYWNrIHVuY29tbWl0dGVk IG5ldGNmIG5ldHdvcmsgY29uZmlnIGNoYW5nZSB0cmFuc2FjdGlvbnMuClsgIE9LICBdIFN0YXJ0 ZWQgSGFyZHdhcmUgUk5HIEVudHJvcHkgR2F0aGVyZXIgV2FrZSB0aHJlc2hvbGQgc2VydmljZS4K WyAgT0sgIF0gU3RhcnRlZCBLZXJuZWwgU2FtZXBhZ2UgTWVyZ2luZy4KICAgICAgICAgU3RhcnRp bmcgQ2hlY2sgUE1JRSBpbnN0YW5jZXMgYXJlIHJ1bm5pbmcuLi4KICAgICAgICAgU3RhcnRpbmcg S2VybmVsIFNhbWVwYWdlIE1lcmdpbmcgKEtTTSkgVHVuaW5nIERhZW1vbi4uLgpbICBPSyAgXSBT dGFydGVkIEhhcmR3YXJlIFJORyBFbnRyb3B5IEdhdGhlcmVyIERhZW1vbi4KICAgICAgICAgU3Rh cnRpbmcgTmV0d29yayBNYW5hZ2VyLi4uClsgIE9LICBdIFN0YXJ0ZWQgUmVzZXRzIFN5c3RlbSBB Y3Rpdml0eSBMb2dzLgpbICBPSyAgXSBTdGFydGVkIEhhcmR3YXJlIE1vbml0b3JpbmcgU2Vuc29y cy4KWyAgT0sgIF0gU3RhcnRlZCBOVFAgY2xpZW50L3NlcnZlci4KWyAgT0sgIF0gU3RhcnRlZCBL ZXJuZWwgU2FtZXBhZ2UgTWVyZ2luZyAoS1NNKSBUdW5pbmcgRGFlbW9uLgpbICBPSyAgXSBTdGFy dGVkIFJlYWx0aW1lS2l0IFNjaGVkdWxpbmcgUG9saWN5IFNlcnZpY2UuClsgIE9LICBdIFN0YXJ0 ZWQgQXZhaGkgbUROUy9ETlMtU0QgU3RhY2suClsgIE9LICBdIFN0YXJ0ZWQgTmV0d29yayBNYW5h Z2VyLgogICAgICAgICBTdGFydGluZyBOZXR3b3JrIE1hbmFnZXIgV2FpdCBPbmxpbmUuLi4KWyAg T0sgIF0gUmVhY2hlZCB0YXJnZXQgTmV0d29yay4KICAgICAgICAgU3RhcnRpbmcgT3BlblNTSCBz ZXJ2ZXIgZGFlbW9uLi4uCiAgICAgICAgIFN0YXJ0aW5nIENVUFMgU2NoZWR1bGVyLi4uCiAgICAg ICAgIFN0YXJ0aW5nIEdTU0FQSSBQcm94eSBEYWVtb24uLi4KICAgICAgICAgU3RhcnRpbmcgRHlu YW1pYyBTeXN0ZW0gVHVuaW5nIERhZW1vbi4uLgogICAgICAgICBTdGFydGluZyAvZXRjL3JjLmQv cmMubG9jYWwgQ29tcGF0aWJpbGl0eS4uLgogICAgICAgICBTdGFydGluZyBFbmFibGUgcGVyaW9k aWMgdXBkYXRlIG9mIGVudGl0bGVtZW50IGNlcnRpZmljYXRlcy4uLi4KICAgICAgICAgU3RhcnRp bmcgTG9nb3V0IG9mZiBhbGwgaVNDU0kgc2Vzc2lvbnMgb24gc2h1dGRvd24uLi4KWyAgT0sgIF0g U3RhcnRlZCBMb2dvdXQgb2ZmIGFsbCBpU0NTSSBzZXNzaW9ucyBvbiBzaHV0ZG93bi4KWyAgT0sg IF0gU3RhcnRlZCBFbmFibGUgcGVyaW9kaWMgdXBkYXRlIG9mIGVudGl0bGVtZW50IGNlcnRpZmlj YXRlcy4uCiAgICAgICAgIFN0YXJ0aW5nIEhvc3RuYW1lIFNlcnZpY2UuLi4KWyAgT0sgIF0gU3Rh cnRlZCBPcGVuU1NIIHNlcnZlciBkYWVtb24uClsgIE9LICBdIFN0YXJ0ZWQgR1NTQVBJIFByb3h5 IERhZW1vbi4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTkZTIGNsaWVudCBzZXJ2aWNlcy4KWyAg T0sgIF0gU3RhcnRlZCBNb2RlbSBNYW5hZ2VyLgpbICBPSyAgXSBTdGFydGVkIENVUFMgU2NoZWR1 bGVyLgpbICBPSyAgXSBTdGFydGVkIEF1dGhvcml6YXRpb24gTWFuYWdlci4KWyAgT0sgIF0gU3Rh cnRlZCBQb2xsIHN5c3RlbSBhY3Rpdml0eSByZXBvcnQgZ2VuZXJhdGlvbi4KWyAgT0sgIF0gU3Rh cnRlZCBHZW5lcmF0ZSBzeXN0ZW0gYWN0aXZpdHkgcmVwb3J0cy4KWyAgT0sgIF0gU3RhcnRlZCBI b3N0bmFtZSBTZXJ2aWNlLgpbICBPSyAgXSBMaXN0ZW5pbmcgb24gTG9hZC9TYXZlIFJGIEtpbGwg U3dpdGNoIFN0YXR1cyAvZGV2L3Jma2lsbCBXYXRjaC4KICAgICAgICAgU3RhcnRpbmcgTmV0d29y ayBNYW5hZ2VyIFNjcmlwdCBEaXNwYXRjaGVyIFNlcnZpY2UuLi4KWyAgT0sgIF0gU3RhcnRlZCBO ZXR3b3JrIE1hbmFnZXIgU2NyaXB0IERpc3BhdGNoZXIgU2VydmljZS4KWyAgT0sgIF0gU3RhcnRl ZCBWRE8gdm9sdW1lIHNlcnZpY2VzLgpbICAgNzAuMTMwODMzXSBwcHMgcHBzMjogbmV3IFBQUyBz b3VyY2UgcHRwNApbICAgNzAuMTQzNDc4XSBpeGdiZSAwMDAwOjE3OjAwLjA6IHJlZ2lzdGVyZWQg UEhDIGRldmljZSBvbiBlbnM2ZjAKWyAgT0sgIF0gU3RhcnRlZCBTeXN0ZW0gU2VjdXJpdHkgU2Vy dmljZXMgRGFlbW9uLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdldCBVc2VyIGFuZCBHcm91cCBOYW1l IExvb2t1cHMuCiAgICAgICAgIFN0YXJ0aW5nIExvZ2luIFNlcnZpY2UuLi4KICAgICAgICAgU3Rh cnRpbmcgQWNjb3VudHMgU2VydmljZS4uLgpbICBPSyAgXSBTdGFydGVkIERpc2sgTWFuYWdlci4K WyAgT0sgIF0gU3RhcnRlZCBBY2NvdW50cyBTZXJ2aWNlLgpbICAgNzAuMzY0MTgzXSBwcHMgcHBz MzogbmV3IFBQUyBzb3VyY2UgcHRwNQpbICAgNzAuMzc2OTI1XSBpeGdiZSAwMDAwOjE3OjAwLjE6 IHJlZ2lzdGVyZWQgUEhDIGRldmljZSBvbiBlbnM2ZjEKWyAgT0sgIF0gU3RhcnRlZCBMb2dpbiBT ZXJ2aWNlLgpbICAgNzAuNTg1MDg2XSBJUHY2OiBBRERSQ09ORihORVRERVZfQ0hBTkdFKTogZW5z OWYxOiBsaW5rIGJlY29tZXMgcmVhZHkKWyAgIDcwLjYzMDc0OF0gYnJpZGdlOiBmaWx0ZXJpbmcg dmlhIGFycC9pcC9pcDZ0YWJsZXMgaXMgbm8gbG9uZ2VyIGF2YWlsYWJsZSBieSBkZWZhdWx0LiBV cGRhdGUgeW91ciBzY3JpcHRzIHRvIGxvYWQgYnJfbmV0ZmlsdGVyIGlmIHlvdSBuZWVkIHRoaXMu ClsgICA3MC43MTcyNDZdIHhlbmJyMDogcG9ydCAxKGVucDFzMCkgZW50ZXJlZCBibG9ja2luZyBz dGF0ZQpbICAgNzAuNzIyODE1XSB4ZW5icjA6IHBvcnQgMShlbnAxczApIGVudGVyZWQgZGlzYWJs ZWQgc3RhdGUKWyAgIDcwLjczMDE4Ml0gZGV2aWNlIGVucDFzMCBlbnRlcmVkIHByb21pc2N1b3Vz IG1vZGUKWyAgT0sgIF0gU3RhcnRlZCBDaGVjayBQTUlFIGluc3RhbmNlcyBhcmUgcnVubmluZy4K WyAgT0sgIF0gU3RhcnRlZCBEeW5hbWljIFN5c3RlbSBUdW5pbmcgRGFlbW9uLgpbICBPSyAgXSBT dGFydGVkIEFCUlQgQXV0b21hdGVkIEJ1ZyBSZXBvcnRpbmcgVG9vbC4KWyAgT0sgIF0gU3RhcnRl ZCBBQlJUIFhvcmcgbG9nIHdhdGNoZXIuClsgIE9LICBdIFN0YXJ0ZWQgQUJSVCBrZXJuZWwgbG9n IHdhdGNoZXIuCiAgICAgICAgIFN0YXJ0aW5nIEluc3RhbGwgQUJSVCBjb3JlZHVtcCBob29rLi4u ClsgIE9LICBdIFN0YXJ0ZWQgSW5zdGFsbCBBQlJUIGNvcmVkdW1wIGhvb2suClsgICA3My40NTA0 NzhdIGlnYiAwMDAwOmNhOjAwLjAgZW5zODogaWdiOiBlbnM4IE5JQyBMaW5rIGlzIFVwIDEwMDAg TWJwcyBGdWxsIER1cGxleCwgRmxvdyBDb250cm9sOiBSWApbICAgNzMuNTY5MDgzXSBJUHY2OiBB RERSQ09ORihORVRERVZfQ0hBTkdFKTogZW5zODogbGluayBiZWNvbWVzIHJlYWR5ClsgICA3My42 OTc1NTFdIGlnYiAwMDAwOjAxOjAwLjAgZW5wMXMwOiBpZ2I6IGVucDFzMCBOSUMgTGluayBpcyBV cCAxMDAwIE1icHMgRnVsbCBEdXBsZXgsIEZsb3cgQ29udHJvbDogUlgKWyAgIDczLjgxNzExOF0g SVB2NjogQUREUkNPTkYoTkVUREVWX0NIQU5HRSk6IGVucDFzMDogbGluayBiZWNvbWVzIHJlYWR5 ClsgICA3My44MjM3MDZdIHhlbmJyMDogcG9ydCAxKGVucDFzMCkgZW50ZXJlZCBibG9ja2luZyBz dGF0ZQpbICAgNzMuODI5MjA4XSB4ZW5icjA6IHBvcnQgMShlbnAxczApIGVudGVyZWQgbGlzdGVu aW5nIHN0YXRlClsgICA3NC44NTk4MzFdIGl4Z2JlIDAwMDA6MTc6MDAuMSBlbnM2ZjE6IE5JQyBM aW5rIGlzIFVwIDEgR2JwcywgRmxvdyBDb250cm9sOiBOb25lClsgICA3NC44NzY1NTFdIElQdjY6 IEFERFJDT05GKE5FVERFVl9DSEFOR0UpOiBlbnM2ZjE6IGxpbmsgYmVjb21lcyByZWFkeQpbICAg NzQuOTIzMTU4XSB4ZW5fYWNwaV9wcm9jZXNzb3I6IFVwbG9hZGluZyBYZW4gcHJvY2Vzc29yIFBN IGluZm8KKFhFTikgY3B1ZnJlcSBmYWlsIHRvIGFkZCBDUFUxOmluY29ycmVjdCBfUFNEKDI1Mjoy KSwgZXhwZWN0KDI1NC8yKQooWEVOKSBjcHVmcmVxIGZhaWwgdG8gYWRkIENQVTM6aW5jb3JyZWN0 IF9QU0QoMjUyOjIpLCBleHBlY3QoMjU0LzIpCihYRU4pIGNwdWZyZXEgZmFpbCB0byBhZGQgQ1BV NTppbmNvcnJlY3QgX1BTRCgyNTI6MiksIGV4cGVjdCgyNTQvMikKKFhFTikgY3B1ZnJlcSBmYWls IHRvIGFkZCBDUFU3OmluY29ycmVjdCBfUFNEKDI1MjoyKSwgZXhwZWN0KDI1NC8yKQooWEVOKSBj cHVmcmVxIGZhaWwgdG8gYWRkIENQVTk6aW5jb3JyZWN0IF9QU0QoMjUyOjIpLCBleHBlY3QoMjU0 LzIpCihYRU4pIGNwdWZyZXEgZmFpbCB0byBhZGQgQ1BVMTE6aW5jb3JyZWN0IF9QU0QoMjUyOjIp LCBleHBlY3QoMjU0LzIpCihYRU4pIGNwdWZyZXEgZmFpbCB0byBhZGQgQ1BVMTM6aW5jb3JyZWN0 IF9QU0QoMjUyOjIpLCBleHBlY3QoMjU0LzIpCihYRU4pIGNwdWZyZXEgZmFpbCB0byBhZGQgQ1BV MTU6aW5jb3JyZWN0IF9QU0QoMjUyOjIpLCBleHBlY3QoMjU0LzIpClsgICAgKipdICgxIG9mIDIp IEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmbmFnZXIgV2FpdCBPbmxpbmUgKDQ4cyAvIG5v IGxpbWl0KVsgICAgICpdICgyIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmY2Fs IENvbXBhdGliaWxpdHkgKDQ5cyAvIG5vIGxpbWl0KVsgICAgKipdICgyIG9mIDIpIEEgc3RhcnQg am9iIGlzIHJ1bm5pbmcgZm9y4oCmY2FsIENvbXBhdGliaWxpdHkgKDQ5cyAvIG5vIGxpbWl0KVsg ICAqKipdICgyIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmY2FsIENvbXBhdGli aWxpdHkgKDUwcyAvIG5vIGxpbWl0KVsgICoqKiBdICgxIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1 bm5pbmcgZm9y4oCmbmFnZXIgV2FpdCBPbmxpbmUgKDUwcyAvIG5vIGxpbWl0KVsgKioqICBdICgx IG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmbmFnZXIgV2FpdCBPbmxpbmUgKDUx cyAvIG5vIGxpbWl0KVsqKiogICBdICgxIG9mIDIpIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y 4oCmbmFnZXIgV2FpdCBPbmxpbmUgKDUxcyAvIG5vIGxpbWl0KVsqKiAgICBdICgyIG9mIDIpIEEg c3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9y4oCmY2FsIENvbXBhdGliaWxpdHkgKDUycyAvIG5vIGxp bWl0KVsgIE9LICBdIFN0YXJ0ZWQgL2V0Yy9yYy5kL3JjLmxvY2FsIENvbXBhdGliaWxpdHkuCiAg ICAgICAgIFN0YXJ0aW5nIE5ldHdvcmsgTWFuYWdlciBTY3JpcHQgRGlzcGF0Y2hlciBTZXJ2aWNl Li4uClsgIE9LICBdIFN0YXJ0ZWQgTmV0d29yayBNYW5hZ2VyIFNjcmlwdCBEaXNwYXRjaGVyIFNl cnZpY2UuClsqICAgICBdIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9yIE5ldHdvcmsg4oCmbmFn ZXIgV2FpdCBPbmxpbmUgKDU5cyAvIG5vIGxpbWl0KVsqKiAgICBdIEEgc3RhcnQgam9iIGlzIHJ1 bm5pbmcgZm9yIE5ldHdvcmsg4oCmYWdlciBXYWl0IE9ubGluZSAoMW1pbiAvIG5vIGxpbWl0KVsq KiogICBdIEEgc3RhcnQgam9iIGlzIHJ1bm5pbmcgZm9yIE5ldHdvcmsg4oCmYWdlciBXYWl0IE9u bGluZSAoMW1pbiAvIG5vIGxpbWl0KVsgICA4OC45OTg1NjhdIHhlbmJyMDogcG9ydCAxKGVucDFz MCkgZW50ZXJlZCBsZWFybmluZyBzdGF0ZQpbICoqKiAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5n IGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gMXMgLyBubyBsaW1pdClbICAqKiog XSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFt aW4gMXMgLyBubyBsaW1pdClbICAgKioqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3 b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gMnMgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0 IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gMnMgLyBu byBsaW1pdClbICAgICAqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIg V2FpdCBPbmxpbmUgKDFtaW4gM3MgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0IGpvYiBpcyBy dW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gM3MgLyBubyBsaW1pdClb ICAgKioqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxp bmUgKDFtaW4gNHMgLyBubyBsaW1pdClbICAqKiogXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZv ciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gNHMgLyBubyBsaW1pdClbICAgOTMuMDMw MjIzXSB4ZW5icjA6IHBvcnQgMShlbnAxczApIGVudGVyZWQgZm9yd2FyZGluZyBzdGF0ZQpbICoq KiAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUg KDFtaW4gNXMgLyBubyBsaW1pdClbKioqICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBO ZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gNXMgLyBubyBsaW1pdClbKiogICAgXSBBIHN0 YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gNnMg LyBubyBsaW1pdClbKiAgICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKA pnIgV2FpdCBPbmxpbmUgKDFtaW4gNnMgLyBubyBsaW1pdClbKiogICAgXSBBIHN0YXJ0IGpvYiBp cyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gN3MgLyBubyBsaW1p dClbKioqICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBP bmxpbmUgKDFtaW4gN3MgLyBubyBsaW1pdClbICoqKiAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5n IGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gOHMgLyBubyBsaW1pdClbICAqKiog XSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFt aW4gOHMgLyBubyBsaW1pdClbICAgKioqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3 b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gOXMgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0 IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApnIgV2FpdCBPbmxpbmUgKDFtaW4gOXMgLyBu byBsaW1pdClbICAgICAqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBX YWl0IE9ubGluZSAoMW1pbiAxMHMgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0IGpvYiBpcyBy dW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxMHMgLyBubyBsaW1pdClb ICAgKioqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGlu ZSAoMW1pbiAxMXMgLyBubyBsaW1pdClbICAqKiogXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZv ciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxMXMgLyBubyBsaW1pdClbICoqKiAgXSBB IHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAx MXMgLyBubyBsaW1pdClbKioqICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3Jr IOKApiBXYWl0IE9ubGluZSAoMW1pbiAxMnMgLyBubyBsaW1pdClbKiogICAgXSBBIHN0YXJ0IGpv YiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxMnMgLyBubyBs aW1pdClbKiAgICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0 IE9ubGluZSAoMW1pbiAxM3MgLyBubyBsaW1pdClbKiogICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5u aW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxM3MgLyBubyBsaW1pdClbKioq ICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAo MW1pbiAxNHMgLyBubyBsaW1pdClbICoqKiAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBO ZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxNHMgLyBubyBsaW1pdClbICAqKiogXSBBIHN0 YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxNXMg LyBubyBsaW1pdClbICAgKioqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKA piBXYWl0IE9ubGluZSAoMW1pbiAxNXMgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0IGpvYiBp cyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxNnMgLyBubyBsaW1p dClbICAgICAqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9u bGluZSAoMW1pbiAxNnMgLyBubyBsaW1pdClbICAgICoqXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5n IGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxN3MgLyBubyBsaW1pdClbICAgKioq XSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1p biAxN3MgLyBubyBsaW1pdClbICAqKiogXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3 b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxOHMgLyBubyBsaW1pdClbICoqKiAgXSBBIHN0YXJ0 IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxOHMgLyBu byBsaW1pdClbKioqICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBX YWl0IE9ubGluZSAoMW1pbiAxOXMgLyBubyBsaW1pdClbKiogICAgXSBBIHN0YXJ0IGpvYiBpcyBy dW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAxOXMgLyBubyBsaW1pdClb KiAgICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGlu ZSAoMW1pbiAyMHMgLyBubyBsaW1pdClbKiogICAgXSBBIHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZv ciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAyMHMgLyBubyBsaW1pdClbKioqICAgXSBB IHN0YXJ0IGpvYiBpcyBydW5uaW5nIGZvciBOZXR3b3JrIOKApiBXYWl0IE9ubGluZSAoMW1pbiAy MXMgLyBubyBsaW1pdCkgICAgICAgICBTdGFydGluZyBOZXR3b3JrIE1hbmFnZXIgU2NyaXB0IERp c3BhdGNoZXIgU2VydmljZS4uLgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgTWFuYWdlciBTY3Jp cHQgRGlzcGF0Y2hlciBTZXJ2aWNlLgpbICBPSyAgXSBTdGFydGVkIE5ldHdvcmsgTWFuYWdlciBX YWl0IE9ubGluZS4KWyAgT0sgIF0gUmVhY2hlZCB0YXJnZXQgTmV0d29yayBpcyBPbmxpbmUuClsg IE9LICBdIFJlYWNoZWQgdGFyZ2V0IFJlbW90ZSBGaWxlIFN5c3RlbXMgKFByZSkuCiAgICAgICAg IE1vdW50aW5nIC9zaGFyZS94dnMvaW1nLi4uCiAgICAgICAgIFN0YXJ0aW5nIFN5c3RlbSBMb2dn aW5nIFNlcnZpY2UuLi4KICAgICAgICAgU3RhcnRpbmcgTm90aWZ5IE5GUyBwZWVycyBvZiBhIHJl c3RhcnQuLi4KICAgICAgICAgU3RhcnRpbmcgTFNCOiBUZWxlY29tIExpbnV4IFZhbGlkYXRpb24g c3VpdGUuLi4KICAgICAgICAgU3RhcnRpbmcgUGVyZm9ybWFuY2UgTWV0cmljcyBDb2xsZWN0b3Ig RGFlbW9uLi4uCiAgICAgICAgIE1vdW50aW5nIC9zaGFyZS94dnMvdG9vbHMuLi4KWyAgT0sgIF0g U3RhcnRlZCBOb3RpZnkgTkZTIHBlZXJzIG9mIGEgcmVzdGFydC4KWyAgT0sgIF0gU3RhcnRlZCBT eXN0ZW0gTG9nZ2luZyBTZXJ2aWNlLgpbICAxMDkuNTUzNTQyXSBGUy1DYWNoZTogTG9hZGVkClsg IDEwOS42MzEyOTFdIEtleSB0eXBlIGRuc19yZXNvbHZlciByZWdpc3RlcmVkClsgIDEwOS44MjI1 NjZdIE5GUzogUmVnaXN0ZXJpbmcgdGhlIGlkX3Jlc29sdmVyIGtleSB0eXBlClsgIDEwOS44Mjg1 MjddIEtleSB0eXBlIGlkX3Jlc29sdmVyIHJlZ2lzdGVyZWQKWyAgMTA5LjgzMzc1N10gS2V5IHR5 cGUgaWRfbGVnYWN5IHJlZ2lzdGVyZWQKWyAgT0sgIF0gTW91bnRlZCAvc2hhcmUveHZzL3Rvb2xz LgpbICBPSyAgXSBNb3VudGVkIC9zaGFyZS94dnMvaW1nLgpbICBPSyAgXSBSZWFjaGVkIHRhcmdl dCBSZW1vdGUgRmlsZSBTeXN0ZW1zLgogICAgICAgICBTdGFydGluZyBDcmFzaCByZWNvdmVyeSBr ZXJuZWwgYXJtaW5nLi4uCiAgICAgICAgIFN0YXJ0aW5nIFBlcm1pdCBVc2VyIFNlc3Npb25zLi4u ClsgIE9LICBdIFN0YXJ0ZWQgUGVybWl0IFVzZXIgU2Vzc2lvbnMuCiAgICAgICAgIFN0YXJ0aW5n IEdOT01FIERpc3BsYXkgTWFuYWdlci4uLgogICAgICAgICBTdGFydGluZyBIb2xkIHVudGlsIGJv b3QgcHJvY2VzcyBmaW5pc2hlcyB1cC4uLgpbICBPSyAgXSBTdGFydGVkIEpvYiBzcG9vbGluZyB0 b29scy4KWyAgT0sgIF0gU3RhcnRlZCBDb21tYW5kIFNjaGVkdWxlci4KW0ZBSUxFRF0gRmFpbGVk IHRvIHN0YXJ0IENyYXNoIHJlY292ZXJ5IGtlcm5lbCBhcm1pbmcuClNlZSAnc3lzdGVtY3RsIHN0 YXR1cyBrZHVtcC5zZXJ2aWNlJyBmb3IgZGV0YWlscy4KWyAgT0sgIF0gU3RhcnRlZCBHTk9NRSBE aXNwbGF5IE1hbmFnZXIuClsgIDExMi40MzQwMzBdIEVESUQgYmxvY2sgMCAodGFnIDB4MDApIGNo ZWNrc3VtIGlzIGludmFsaWQsIHJlbWFpbmRlciBpcyAxMjUKWyAgMTEzLjM2OTkwOV0gRURJRCBi bG9jayAwICh0YWcgMHgwMCkgY2hlY2tzdW0gaXMgaW52YWxpZCwgcmVtYWluZGVyIGlzIDEyNQpb ICAxMTYuMjA4OTYzXSBFRElEIGJsb2NrIDAgKHRhZyAweDAwKSBjaGVja3N1bSBpcyBpbnZhbGlk LCByZW1haW5kZXIgaXMgMTI1ClsgIDExNy40MjAzMDNdIEVESUQgYmxvY2sgMCAodGFnIDB4MDAp IGNoZWNrc3VtIGlzIGludmFsaWQsIHJlbWFpbmRlciBpcyAxMjUKClJlZCBIYXQgRW50ZXJwcmlz ZSBMaW51eCA4LjMgKE9vdHBhKQpLZXJuZWwgNS4xOS4wLXJjNiBvbiBhbiB4ODZfNjQKCkFjdGl2 YXRlIHRoZSB3ZWIgY29uc29sZSB3aXRoOiBzeXN0ZW1jdGwgZW5hYmxlIC0tbm93IGNvY2twaXQu c29ja2V0CgppY3gtMnMxIGxvZ2luOiAoWEVOKSBSZW1vdmluZyBjcHUgNDggZnJvbSBydW5xdWV1 ZSAzCihYRU4pIEFzc2VydGlvbiAnIWluX2lycSgpICYmIChsb2NhbF9pcnFfaXNfZW5hYmxlZCgp IHx8IG51bV9vbmxpbmVfY3B1cygpIDw9IDEpJyBmYWlsZWQgYXQgY29tbW9uL3htYWxsb2NfdGxz Zi5jOjcwNAooWEVOKSAtLS0tWyBYZW4tNC4xNy11bnN0YWJsZSAgeDg2XzY0ICBkZWJ1Zz15ICBU YWludGVkOiAgIEMgICAgXS0tLS0KKFhFTikgQ1BVOiAgICA0OAooWEVOKSBSSVA6ICAgIGUwMDg6 WzxmZmZmODJkMDQwMjNiZTc2Pl0geGZyZWUrMHgxNTAvMHgxZjcKKFhFTikgUkZMQUdTOiAwMDAw MDAwMDAwMDEwMDE2ICAgQ09OVEVYVDogaHlwZXJ2aXNvcgooWEVOKSByYXg6IDAwMDAwMDAwMDAw MDAwNjAgICByYng6IDAwMDAwMDAwMDAwMDAwMDAgICByY3g6IDAxMDEwMTAxMDEwMTAxMDEKKFhF TikgcmR4OiAwMDAwMDAwMDAwMDAwMDIwICAgcnNpOiAzMzMzMzMzMzMzMzMzMzMzICAgcmRpOiBm ZmZmODJkMDQwODBiODIwCihYRU4pIHJicDogZmZmZjgzNDA3YjgwZmNlMCAgIHJzcDogZmZmZjgz NDA3YjgwZmNiOCAgIHI4OiAgMzMzMzMzMzMzMzMzMzMzMwooWEVOKSByOTogIDAwMDAwMDAwMDAw MDAwMDEgICByMTA6IDAwMDAwMDAwMDAwMDAwMDEgICByMTE6IDAxMDEwMTAxMDEwMTAxMDEKKFhF TikgcjEyOiBmZmZmODMyMDJlN2IwODEwICAgcjEzOiBmZmZmODJkMDQwOTNjNDgwICAgcjE0OiBm ZmZmODJkMDQwODAwMDQwCihYRU4pIHIxNTogZmZmZjgzMjAyZWYxMjA0MCAgIGNyMDogMDAwMDAw MDA4MDA1MDAzYiAgIGNyNDogMDAwMDAwMDAwMDc1MjZlMAooWEVOKSBjcjM6IDAwMDAwMDAwNTlj MTYwMDAgICBjcjI6IDAwMDAwMDAwMDAwMDAwMDAKKFhFTikgZnNiOiAwMDAwMDAwMDAwMDAwMDAw ICAgZ3NiOiAwMDAwMDAwMDAwMDAwMDAwICAgZ3NzOiAwMDAwMDAwMDAwMDAwMDAwCihYRU4pIGRz OiAwMDAwICAgZXM6IDAwMDAgICBmczogMDAwMCAgIGdzOiAwMDAwICAgc3M6IDAwMDAgICBjczog ZTAwOAooWEVOKSBYZW4gY29kZSBhcm91bmQgPGZmZmY4MmQwNDAyM2JlNzY+ICh4ZnJlZSsweDE1 MC8weDFmNyk6CihYRU4pICBmOCAwMSAwZiA4ZSBlZSBmZSBmZiBmZiA8MGY+IDBiIDBmIDBiIDBm IDBiIDQ4IGI4IGZmIGZmIGZmIGZmIGZmIDgyIGZmIGZmCihYRU4pIFhlbiBzdGFjayB0cmFjZSBm cm9tIHJzcD1mZmZmODM0MDdiODBmY2I4OgooWEVOKSAgICBmZmZmODMyMDJlN2MxZGYwIGZmZmY4 MzIwMmU3YjA3MTAgZmZmZjgyZDA0MDkzYzQ4MCBmZmZmODJkMDQwODAwMDQwCihYRU4pICAgIGZm ZmY4MzIwMmVmMTIwNDAgZmZmZjgzNDA3YjgwZmNmMCBmZmZmODJkMDQwMjQ4Nzk1IGZmZmY4MzQw N2I4MGZkNzAKKFhFTikgICAgZmZmZjgyZDA0MDI1OTE2OSBmZmZmODMyMDJlN2IwNzEwIGZmZmY4 MzIwMmU3YjA4MTAgZmZmZjgzMjAyZTdiMDZkMAooWEVOKSAgICAwMDAwMDAwMDAwMDAwMDgyIGZm ZmY4MzIwMmU3YzFkZjAgMDAwMDAwMDA0MDI1NThlNSBmZmZmODMyMDJlZjEyMDQwCihYRU4pICAg IDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMzAwMDAwMDAwMCBmZmZmODMyMDJlZjEyMGUwIGZmZmY4 MzIwMmU3YzFkMzAKKFhFTikgICAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDMwIGZm ZmY4MzIwMmVmMDUwNmMgZmZmZjgzNDA3YjgwZmRhOAooWEVOKSAgICBmZmZmODJkMDQwMjQzMGNh IDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAwMDAzMCBmZmZmODJkMDQwODE4NDMwCihYRU4p ICAgIDAwMDAwMDAwMDAwMDgwMDcgMDAwMDAwMDAwMDAwODAwMCBmZmZmODM0MDdiODBmZGQ4IGZm ZmY4MmQwNDAyMWQ0MDIKKFhFTikgICAgZmZmZjgyZDA0MDgxODYyOCBmZmZmODJkMDQwODE4NjIw IGZmZmY4MmQwNDA4MTg0MzAgMDAwMDAwMDAwMDAwODAwNwooWEVOKSAgICBmZmZmODM0MDdiODBm ZTIwIGZmZmY4MmQwNDAyMjlmYzMgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAwMDAwMDMwCihY RU4pICAgIDAwMDAwMDAwMDAwMDAwMDEgZmZmZjgyZDA0MDkyMjFmMCAwMDAwMDA0ZmVlNWUzMDAw IDAwMDAwMDAwMDAwMDAwMzAKKFhFTikgICAgMDAwMDAwMDAwMDAwMDAzMCBmZmZmODM0MDdiODBm ZTM4IGZmZmY4MmQwNDAyMDRkZjcgMDAwMDAwMDAwMDAwMDAwMwooWEVOKSAgICBmZmZmODM0MDdi ODBmZTQ4IGZmZmY4MmQwNDAyMDRlMzMgZmZmZjgzNDA3YjgwZmU1OCBmZmZmODJkMDQwMjA0ZTQz CihYRU4pICAgIGZmZmY4MzQwN2I4MGZlNzAgZmZmZjgyZDA0MDIzMTUxNyBmZmZmODMyMDJlZjA1 MWEwIGZmZmY4MzQwN2I4MGZlODgKKFhFTikgICAgZmZmZjgyZDA0MDIzMWNjNSBmZmZmODMyMDJl ZjA1MWUwIGZmZmY4MzQwN2I4MGZlYjggZmZmZjgyZDA0MDIzMWY0MgooWEVOKSAgICAwMDAwMDAw MDAwMDAwMDMwIGZmZmY4MmQwNDA5MmE3ODAgMDAwMDAwMDAwMDAwN2ZmZiAwMDAwMDAwMDAwMDAw MDMwCihYRU4pICAgIGZmZmY4MzQwN2I4MGZlZjAgZmZmZjgyZDA0MDMyMGI2MCBmZmZmODJkMDQw MzIwYWQzIGZmZmY4MzIwMmVmMTEwMDAKKFhFTikgICAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAw MDAwMDAwMDAxIDAwMDAwMDMzZWFiNGYyYWEgZmZmZjgzNDA3YjgwZmRlOAooWEVOKSAgICAwMDAw MDAwMDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAwMDAw MDAwMDAwCihYRU4pICAgIDAwMDAwMDAwMDAwMDAwMDAgMDAwMDAwMDAwMDAwMDAwMCAwMDAwMDAw MDAwMDAwMDAwIDAwMDAwMDAwMDAwMDAwMDAKKFhFTikgWGVuIGNhbGwgdHJhY2U6CihYRU4pICAg IFs8ZmZmZjgyZDA0MDIzYmU3Nj5dIFIgeGZyZWUrMHgxNTAvMHgxZjcKKFhFTikgICAgWzxmZmZm ODJkMDQwMjQ4Nzk1Pl0gRiBjb21tb24vc2NoZWQvY3JlZGl0Mi5jI2NzY2hlZDJfZnJlZV91ZGF0 YSsweGMvMHhlCihYRU4pICAgIFs8ZmZmZjgyZDA0MDI1OTE2OT5dIEYgc2NoZWR1bGVfY3B1X3Jt KzB4MzhkLzB4NGIzCihYRU4pICAgIFs8ZmZmZjgyZDA0MDI0MzBjYT5dIEYgY29tbW9uL3NjaGVk L2NwdXBvb2wuYyNjcHVwb29sX3VuYXNzaWduX2NwdV9maW5pc2grMHgxN2UvMHgyMmMKKFhFTikg ICAgWzxmZmZmODJkMDQwMjFkNDAyPl0gRiBjb21tb24vc2NoZWQvY3B1cG9vbC5jI2NwdV9jYWxs YmFjaysweDNmYi8weDRkYwooWEVOKSAgICBbPGZmZmY4MmQwNDAyMjlmYzM+XSBGIG5vdGlmaWVy X2NhbGxfY2hhaW4rMHg2Yi8weDk2CihYRU4pICAgIFs8ZmZmZjgyZDA0MDIwNGRmNz5dIEYgY29t bW9uL2NwdS5jI2NwdV9ub3RpZmllcl9jYWxsX2NoYWluKzB4MWIvMHgzMwooWEVOKSAgICBbPGZm ZmY4MmQwNDAyMDRlMzM+XSBGIGNvbW1vbi9jcHUuYyNfdGFrZV9jcHVfZG93bisweDI0LzB4MmIK KFhFTikgICAgWzxmZmZmODJkMDQwMjA0ZTQzPl0gRiBjb21tb24vY3B1LmMjdGFrZV9jcHVfZG93 bisweDkvMHgxMAooWEVOKSAgICBbPGZmZmY4MmQwNDAyMzE1MTc+XSBGIGNvbW1vbi9zdG9wX21h Y2hpbmUuYyNzdG9wbWFjaGluZV9hY3Rpb24rMHg4Ni8weDk2CihYRU4pICAgIFs8ZmZmZjgyZDA0 MDIzMWNjNT5dIEYgY29tbW9uL3Rhc2tsZXQuYyNkb190YXNrbGV0X3dvcmsrMHg3Mi8weGE1CihY RU4pICAgIFs8ZmZmZjgyZDA0MDIzMWY0Mj5dIEYgZG9fdGFza2xldCsweDU4LzB4OGEKKFhFTikg ICAgWzxmZmZmODJkMDQwMzIwYjYwPl0gRiBhcmNoL3g4Ni9kb21haW4uYyNpZGxlX2xvb3ArMHg4 ZC8weGVlCihYRU4pIAooWEVOKSAKKFhFTikgKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKioqKioqKgooWEVOKSBQYW5pYyBvbiBDUFUgNDg6CihYRU4pIEFzc2VydGlvbiAnIWluX2ly cSgpICYmIChsb2NhbF9pcnFfaXNfZW5hYmxlZCgpIHx8IG51bV9vbmxpbmVfY3B1cygpIDw9IDEp JyBmYWlsZWQgYXQgY29tbW9uL3htYWxsb2NfdGxzZi5jOjcwNAooWEVOKSAqKioqKioqKioqKioq KioqKioqKioqKioqKioqKioqKioqKioqKioqCihYRU4pIAooWEVOKSBSZWJvb3QgaW4gZml2ZSBz ZWNvbmRzLi4uCg== --_002_BL1PR11MB546193E001A425E0B9B7848EEC979BL1PR11MB5461namp_-- From xen-devel-bounces@lists.xenproject.org Wed Jul 27 05:24:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 05:24:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375879.608336 (Exim 4.92) (envelope-from ) id 1oGZWo-0000Yt-Te; Wed, 27 Jul 2022 05:24:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375879.608336; Wed, 27 Jul 2022 05:24:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGZWo-0000Ym-Qx; Wed, 27 Jul 2022 05:24:14 +0000 Received: by outflank-mailman (input) for mailman id 375879; Wed, 27 Jul 2022 05:24:13 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGZWn-0000Yc-JQ; Wed, 27 Jul 2022 05:24:13 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGZWn-0003c6-GX; Wed, 27 Jul 2022 05:24:13 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGZWm-0007on-Su; Wed, 27 Jul 2022 05:24:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGZWm-0001pV-SL; Wed, 27 Jul 2022 05:24:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+jnxs4ixOqYo4lHCYLlftTsqDiYRla98jZpMWq3l+BM=; b=wydhv9gEhV63mCyee/xWVV5q6G vSiZsbPKr/itAgfsA2KlxnxbDxfRXuh/I0WGozcldg1bzyFecFxZpBgd5lcAdsX5kKIVt+fA61twq Kb43SLqa2/ookMmm4Me0O2ohgwe4CxskY5vVR1rU8baSrbNdfUqexl6RoUNqHTQ5flRI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171867: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:debian-hvm-install:fail:heisenbug xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=221f6a97b59e008f11eb310ad0c9b802f3bea233 X-Osstest-Versions-That: xen=0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 From: osstest service owner Date: Wed, 27 Jul 2022 05:24:12 +0000 flight 171867 xen-4.16-testing real [real] flight 171876 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171867/ http://logs.test-lab.xenproject.org/osstest/logs/171876/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 12 debian-hvm-install fail pass in 171876-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171637 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171637 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171637 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171637 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171637 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171637 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171637 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171637 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171637 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171637 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171637 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171637 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen 221f6a97b59e008f11eb310ad0c9b802f3bea233 baseline version: xen 0a5387a01165b46c8c85e7f7e2ddbe60a7f5db44 Last test of basis 171637 2022-07-15 02:31:18 Z 12 days Testing same since 171867 2022-07-26 13:07:16 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict fail test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 0a5387a011..221f6a97b5 221f6a97b59e008f11eb310ad0c9b802f3bea233 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:05:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:05:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375888.608347 (Exim 4.92) (envelope-from ) id 1oGaAK-0005Lp-20; Wed, 27 Jul 2022 06:05:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375888.608347; Wed, 27 Jul 2022 06:05:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaAJ-0005Li-VT; Wed, 27 Jul 2022 06:05:03 +0000 Received: by outflank-mailman (input) for mailman id 375888; Wed, 27 Jul 2022 06:05:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaAI-0005Lc-9I for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:05:02 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2056.outbound.protection.outlook.com [40.107.21.56]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0c933607-0d72-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 08:05:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB5900.eurprd04.prod.outlook.com (2603:10a6:10:a3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 06:04:58 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 06:04:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0c933607-0d72-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EUkWNWTpeY9Kzg/7oKJ7zCg9Hc9t53IRp546a29xw4pWzMKf5rwxYGWbRMWaQ9dILmpiFQJOfciAN9asuMKXMmhYpIoju16bF8iz4wsU3X4PEmCfMy6wNuy2bU9KLEfzHLFG4tzFZoET+fBmvnZdfGkKJRhme8mPbNAfY2dzbmNcU4TjfJHEGVe6bV9lvZTA1DC+vLrvUDq6FKkPxFKvCZEq9+c6PBCs16d7/bvmCY8TDcb88TyzgxOapewd3Q6LG6Pr+RjGuBxRo6qM3Itfa1D6xBOzKLf8FSwnvx0ck/gN8KVDRwG3PzG0IdHuO3zLhbmar6vZezE+/O3FJCcPNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qUVtUkz17XygCM73T+G+5WAHtTDh/scwptkqbJYoMJk=; b=fRwxi+yQYmGHTByqngUM8/9a4aCpbzVddWXNcniU1PYJUk6iITskSb6dUeDmbfugMVn+Ik3EXLl3LIsvKx42lwKnz1MG5fYXh3odDv+pm+pNbqDCe2/MIrGa6PqIwCRAUGaJokjIdiTDFXLw02D4saBZihZIu2HY5GKHSPDd6i7jZgFnQMyPrfIlzowobFW1ht8roGLnAlyLxHcTmYL7w4p37wUJ66TB6vh4eY52xe/VNjfjptuqw7bQHkzWAA/cQDdeAfSDpvP7VXf65ksNPPrKWi6ccCeRPqtguBYaRquXc5kb/uvgLxKOFi7jHcxSB8+yxdiZ1ACWuxO+CZEERw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qUVtUkz17XygCM73T+G+5WAHtTDh/scwptkqbJYoMJk=; b=rxqCXU63awtLJrMMeBzdpnjky9fj4pcoDvF52J+BkbK6EzuwbAdwnm80rzZsfo87i9jaf8aOwWgEbAKSze8GYBhkX1OyW6w0l6YiHyFmIOk4xeDuxovjZJ444gfNBEWRoAXtN5gpuMwwM7RF/63OX5VlK5vnwszBJW/rw9EFVkn87SsouDWtMQg5tEjaG6iOVr0MrccS58FwUGd26e0C6UUXrn6mEX9ymtzN9Uv1OW1ARERDAEvN49ltM1pKrRwUlOCSfY0zK1v0ILI8/YUveIyHYz5KeBcVsAMCTTl6kcf6YiziZ+gShWUBYgjtMaGJfJXr1wL+va54hkvRzvA8JQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <7208eec8-05f1-cced-5396-1fa1f87965d3@suse.com> Date: Wed, 27 Jul 2022 08:04:56 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Stefano Stabellini Cc: Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Xenia Ragiadakou References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0046.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b7721ebd-15ad-43df-0f43-08da6f95eee5 X-MS-TrafficTypeDiagnostic: DB8PR04MB5900:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FlscTX6G1oI/dFks1h5vLuEN/nF7TO8OcHQb9hOMM7gNLps2XdmmARDgmYVwrjfW1LLuZQX/UzsNn3SVR/kyfMbYfUNBPKTuuwVQCUBKxPe7S0aIPNSIuCrmfIprbBsldFrtLbFbelwGWKgpppflgyKcTpStN9M3ajNrW2W41BToEy1YcVuaJnKJ2yt4GycV+DIEYk/bajjQUpsYgAsTSCg8yC7JU3q7wQeMtejnvuOy8ZGFlDQhw+6VSDVYUut/NMsn/swgOyvaXw/NPNanoOkRpyLeELPAACpLbsqzyZVUthWZ7nFM56B1nC2oCaoNo25eB+xP33kkFJxIf1jvXyWmcwgbNCv5dLNKW0+dLH0t3pVDstw4BtGcVYna63JEOST0VQIVKNir0VN7X+VWY7go/oyruD3JSal8D8+Kqps59pnJ95lDVzwkdgFnfHJxqBYoNUBOx71En0UG1vT4NjDJFQ4qiWC9HW+yQYZ3ZBRN6T/CiJHdyMGtfDPFefMk9q+eHwztkLqV05tsz27DyXaLg+UxmW/BlGHJKK5EzF7ktIhK4EOG85Vg9rz4WqSiMpD3kus44d92PuYkOlWh4HHn+APGbfn8QNA/P9GAm8v12BXIQ2TBzk3kLZGboHCJM6sUKPbKpUaGooOKLaNlCc9NJnDPrnKTZ1PKkoax1OBdr0Ekv7Nw6Tj7nWylH3tfCT6LxJSdA6AsF/q/J7f+OyYwGA8NBiDQu5Y3al2TYSqnwo30LfdfmW1BZOYf5I3GMwKHNUOYgdpcLjWBH60Kb7ChhenXm1XYK2ZJiU51+G0w2QrcEQuDoalXuS+6vsFvsmajb/MoJIl4iPl5xZyIyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(366004)(376002)(136003)(6486002)(66476007)(31686004)(316002)(36756003)(478600001)(31696002)(6916009)(4326008)(66556008)(8936002)(5660300002)(8676002)(66946007)(86362001)(2616005)(54906003)(41300700001)(4744005)(2906002)(38100700002)(53546011)(6506007)(6512007)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?REE3WUJVZTU5VFRvdEMveWI0eCtNL0NrQS9yOUtjNXpBdUlqMFJQbHNYT1lJ?= =?utf-8?B?WHlCVWF1dEFMQm4xSHVmTDZndVUxTnhwMVNJQ21LcEJwbStpOWYzblRjRS9U?= =?utf-8?B?bEkycnBQMnFXOWhGU0N1K2xUMWlqVmxvdS85RHdQWVhJTm95V05hdElKUm0y?= =?utf-8?B?cThRa2ZRdTJCdjhxTXlKbHczd01XUmQwMTBnUzVCUFhrMXE5amUvYlFJd1hl?= =?utf-8?B?SzBGYkpJa0pYd2ZBOFd2cWtJa0ZpY1YzcXg0Q3hRYllMK0Y3UzJFalZqeWRF?= =?utf-8?B?dEd5Yi94aGlUS3pCY0cyUzJ0cm5TVWNYUjd3RWFXNTlKTlprSkxzS3FPNjBX?= =?utf-8?B?QlVXdXp4R09YYjlKNC8vRm5JWkx0dEM2dXBlbGc5Q3pic0JuSFZuWkJGaXBF?= =?utf-8?B?b2hPOWVZNVBBTXdVRkw0dmIzWmlYUVJWVEhHUmpXZzVNOHBpV1Fvalk4c0pl?= =?utf-8?B?Y2YyWFo3aVNKNmRCMHJVVGJPT3RRc1ZUT3ljMkJ4Vmc0MlpITjRGelZwZWJR?= =?utf-8?B?UXR2bFBXOEhYUEJXNFhwaTZ3cTJsdjZuUnFibEVGdUN2TkRlMk1qOVdSdWRY?= =?utf-8?B?Zk1ITExsWTdpSVJzc25scDZ4U1EzUG4wcXoyMTFnWXE2ZjdISDZYUjA5eG55?= =?utf-8?B?NVF0WGRsdmtKVWljN0VOUDloV2hLQlJ0UGFpVUFOQXJrMGVtWkJUbDI2bE11?= =?utf-8?B?UTFQTDJhYUZwcDVRVXk2R3FrK2dHUEZOaFRtL0d2U3NtSWxXcFNGQWR1L3Qx?= =?utf-8?B?UTNHWm5acE9NcXVUMnpFS1lLT2wvNjRhWnZ1bkJhMTdVRWE1a2hqY0IvVENj?= =?utf-8?B?THBrQSsxTjAwRWxrUS9qbmhhRHVQa0t2MTZpVjZVa2xsbkRXU0ZHdFltWjdu?= =?utf-8?B?a3UydVVXZXBpc1ZhZUlnaDh2ektFQUVpbkJUNlpsQ1FMN2o5WE45dVQ0d0Vo?= =?utf-8?B?YU1meVN4VVZ0alNaYmFod0M3d1pkV2Q1enBhajFkSENTMU01cGJ3cHRHaVpm?= =?utf-8?B?aTFkbE9jaHA2bkJuVkJtL2llUkFqM2JkVjVBMG9xRGtEMWQyazJKdkpseTRx?= =?utf-8?B?T1dwSU5aK3hGZjRXUzFZY3RSMThCeVJybUFBeStRUFhKVDN1MFhKc0crOFZk?= =?utf-8?B?eU56clV6T2N0ZXdtd3gzUytoa3FJOTE3UnM0aTZpOEFxbWJjNVQvT3RUby9j?= =?utf-8?B?Qkl6NjhHWDBURk5FSEV5OVlLN1lRdFUxU09WcXdDcm14WDFpS0xXUUJraVpJ?= =?utf-8?B?M0s1bTdHeTg4ZHZqMFEyUWRMVU1vdE1xOGlSNGVCT1plaUVpckp6d3ZtR0pP?= =?utf-8?B?T0dWbW80UkQ5WVpRK2VMbUp3MG5ubEpmQnRYYkl5ZURJYUdpTmZRZ1JsMUhT?= =?utf-8?B?WEZuOVU1b0xGOUw0N0tuZ05UNmFscUxFVmNqTHVhL1o5Q05SREtLK2xlM1pq?= =?utf-8?B?ajJCNFgyY29VQmdmVjRnbzJzbU9XYUdqeWVaWUYzSlZoUFJjT0RrekNQK1cr?= =?utf-8?B?VDg4RUg4c00rbXlsNjBMdFNPd3FPcW1XSzB4eTJmdHl2MkJvRzBBR1c0NWt1?= =?utf-8?B?WmltTXlwSDVCVlpma0tnOGJFeHl4Yk40QzMzdk1zbkp4S25SRGw1dXZya3Fi?= =?utf-8?B?QXd0b3VBdVNGejNUU2JhRkxTdW1KcWZSRWVFSFBvTkZ6aXBjSlBQMFNjZjFB?= =?utf-8?B?Z2tBUFc1RC9WU2xXRVkySDBOd2pPWXQ2YTlEeDYrbEJiYTFObjFoVFlPaXNh?= =?utf-8?B?a1RkZDkvbm1oNDV0cFgwN3NCMnJLcXVXQ2hwTFp4SGx0aEZBenRLV0trZEEw?= =?utf-8?B?TjRUMm8yamJSZjVnV2MwakZRR2VnSEt4TzkxWGhZbmMyd2xnMlNkekVaMk1o?= =?utf-8?B?QUJCMVcvM3E1YWFQYXdlc2E5cUx5d0hxRE9XTFdjTjB5M1lSbExXYWErUk54?= =?utf-8?B?amcybnQrNmgyRXNkbmRuU2FwR2RMWWVPdkVtTUZqMzJHZXZJYzNPT3AvMUk3?= =?utf-8?B?WSs4cUtRaFp0dDFDSml4RHprR0VRdjc1L3FDVm9DYk93aTJ6VlJpZjVIenov?= =?utf-8?B?ZGtoTlhZWFhnam9RTXJPaHYrUWVXTFpvYzJoTnE1SUpSeWxhTjlKbzVCTUlW?= =?utf-8?Q?vvDoQ/60VsrleAIL6QRLo5MrS?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b7721ebd-15ad-43df-0f43-08da6f95eee5 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 06:04:57.6708 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9o9RUYaFCr7KRnQ5UrM57KZGwS3Jn9Jc6KGPYtAUTA8tIIDMxbDWGxNLN0CFrZVONyds6HUyBQ7oI4Y9er7+nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5900 On 27.07.2022 02:10, Stefano Stabellini wrote: > On Tue, 26 Jul 2022, Jan Beulich wrote: >> You forgot the imo better intermediate option of using the "X" constraint. > > I couldn't get "X" to compile in any way (not even for arm64). Do you > have a concrete example that you think should work using "X" as > constraint? Perhaps you tried to use the respective input then as an operand to the insn? That won't work afaik - as Xenia says, it can be used only as a "fake" operand (i.e. one that tells the compiler something, but having no direct meaning for the insn). Actually I thought we had uses of "X" already somewhere in Xen and/or XTF, but now that I looked I can't find any. (Anymore?) Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:12:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:12:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375896.608358 (Exim 4.92) (envelope-from ) id 1oGaHR-0006zv-Sn; Wed, 27 Jul 2022 06:12:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375896.608358; Wed, 27 Jul 2022 06:12:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaHR-0006zo-QG; Wed, 27 Jul 2022 06:12:25 +0000 Received: by outflank-mailman (input) for mailman id 375896; Wed, 27 Jul 2022 06:12:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaHQ-0006zi-LD for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:12:24 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60079.outbound.protection.outlook.com [40.107.6.79]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 144829b2-0d73-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 08:12:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB8PR04MB5900.eurprd04.prod.outlook.com (2603:10a6:10:a3::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 06:12:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 06:12:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 144829b2-0d73-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MrRpy3ywqCs50QKsQNxvCMJXGZtukzMYokti/pcEjEX1F2usfXsgMXq+oFP3yffq6mTqQtPreew4mfowFaY7ZNdkOPu1RmtTM9ne2VifscTQCCg7gSPoUXakaxzzHxr6JHa16PAdouYY3JXPDHyHwcnmzoxUBeN1aooM/3X5S6gHE6wS4yBI7FWxC2Uk3VtMOKinaT4DTMUMJIzCLhk7F8qzuhgZ31QjyT1JNuDQJ4gUerrOeBU/boK3bO1zVkGckJCzQkDqL95BPoZGUu5YIfyWxkGY8oxO4kGi79QiJPFTm6oXNYw513bJAB1PgDccAZUi95MBwsM4UaUU6yfctA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uKlc9qlkG3eQVbleKvULKXHW1GLOYmflS/AAI9cST4I=; b=fb5Y1KHrsiI973RcUIVhJZJ7ZaWd4Y70RdkD+DVCSdrSpxWVJJjXNzg0x5pEevna982ig0tW2A7j/gO8OC3xYsyTpb6Ej75taQzW6pKRlddd7tJUALfIkKIL7R5MzI424/L6uyIbkZrl6kUUA5dIeEsXxoW1gO29rVZ4toMjTfC4eczqU5V1SQ72Xx7wZvO9mZ6slRolq67bsRjn+XRPmR5FDLoEzVHQlv2nqJC9rOLckVRKj5aKKm7zk/2QIO6RHXIUWt4TAmEzG4s9PfUGmXy05ONJR0Wdvy578MB1XvH3rMivoHKwWQT9qkHiLw0qGk6hbg9NHxrTHK8g3c90Bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uKlc9qlkG3eQVbleKvULKXHW1GLOYmflS/AAI9cST4I=; b=UUFi66FPSTwjbW2D2MP4nl+7ZJFu5wiSp729MqITYNbaOXTS0B0us7Joi0krJ1PAw/sh99dTXIY0qI918Puh7oPGnMj00CQ/2Zj9J3xaeAdCPZ9a+7r/dnYulgNETDOuiWiQHCcFNlg0lumuZT5ww3qQ3AaJoN5gVZMetD8KfAhz7Mdv2XTe034jMiGNs6Vg53+ZBDDN4KGZJObiJtCGaMikWEzXTqQHZpcMtF1a26JvPYCqM8o4FwItLO8VUKNHtSk0H4CmjeXZ94VE7Laj32hWKWGNZKJWRqa6xYLwW8ziLmhGNhzAFqwA2ZtDOnD82u4cZDYeU8JJguli01fFmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <247dffe6-17b6-570e-7848-65c1c92be41a@suse.com> Date: Wed, 27 Jul 2022 08:12:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 01/18] kconfig: allow configuration of maximum modules Content-Language: en-US To: Julien Grall , "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Stefano Stabellini , Bertrand Marquis , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Volodymyr Babchuk , Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-2-dpsmith@apertussolutions.com> <78c3f88a-4f36-087d-31b1-d02bfbc8df30@apertussolutions.com> <04c7adfd-e978-b911-fef9-f068ec624849@xen.org> From: Jan Beulich In-Reply-To: <04c7adfd-e978-b911-fef9-f068ec624849@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0074.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::12) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b24a098-f540-4ac3-02fa-08da6f96f762 X-MS-TrafficTypeDiagnostic: DB8PR04MB5900:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oa3Kjp+KBZHkZQgZIjZHIfeklFcKKOIIRzKx8FTwDDrSsjvKT9sZe3C04FCB/7VQxw6wSCmBz0aunqVxl/zSqEd9ykaFj6Ol5vTS2f/ibVzsMF+Q2JmFu7vVnNeG6iOtNhS4KGmoIyQCIDINZ+BB9f0vLkYhIQjG8yRRDrTx0rWQDZkfVhsusjs4OtVOnGmJTwsUxONt5ljZXg3qXnx1mQAw+7Xx8L9kKI8Dc9ycKm/4dNM+YuJIBobqIkgmCCfAglTEXeW0AwPO2d8YZG1d8+VXYDnPK2tFVHJ8yPSksdWWmtjgvkb9yN6lmYd/88HJeaeYSd5A1gnQPzmNv9PhaXRI3/yuEz1fMkIODySYy8NBm+v3k1mtTBl75iOf1TNTf3Gpt4j6Uw2PAQF+CiLgC0axGdG38CBVYBwcl/uZmP+DoYokUscofkXb5mXfFZ8sy9ab2FrzrTRnykDMEhaapDUUCJXgqwkq35gBY2KicpW5hXhAVnvv7b5UXBtqvDrXPaa7Nc5fdCCe/5HF/6RIGskMxFvUSKin9FueoncKWw2f1Yrf9cbDqY19E9yl42zwP6BXXr5jD28u6qFrfJFw4OSy5xRIcC7o106nAk8ZnZbfmh0UCPWufmIuhHVqLe4ZsdPnGUkYXKFrN0+1YoNiWB4NX3dr0FUx2JziN6gCxmHDsVqMXNTN+CQlrgnVFS91hMwclvZbc5/IShO872hMQf+Yes7Z2gl3h4h/N4ynM38ttLbmaA0j3Pyb578GdnAQ4eCShEkLIDK2q8qSZg/yHCizTMuR39OxHa0hDFbMNR+nWbeC92+mus/zrp9eiNdA6gpUQVILf0TZo/U9AsTBnA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(39860400002)(396003)(366004)(376002)(136003)(6486002)(66476007)(31686004)(316002)(36756003)(478600001)(7416002)(31696002)(83380400001)(4326008)(66556008)(110136005)(8936002)(5660300002)(8676002)(66946007)(86362001)(2616005)(54906003)(41300700001)(2906002)(38100700002)(53546011)(6506007)(6512007)(186003)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aVdRZlJKZUhqZWxsRDJMazNlZFZyeWlpTHpkdUZEaWw1elkvRXZFYlJHQTl2?= =?utf-8?B?MXR5Q0N5MjlBamt3YmJoZWlnYjlvOFljQjVrY0VxblFYRVY5ZzNkbkVZZTgw?= =?utf-8?B?d011U25vOUdvQU1KL3BSeXd6ZmRTY3VBOFl1WkVaZmpkVkx0dmlnRFVPaWRa?= =?utf-8?B?Z0FyZW1zR1c3bDdZOGN4N3NaMkc4dUZ6cmVZN2l3T1VjR0pjUkd0U2hJanBO?= =?utf-8?B?eE1oVWllSHBjWTJDTWJaR2JidHF3bWI0QUlacTBSdHp6Zms5TkNrQkY1NlFZ?= =?utf-8?B?UmxxcjdRVlBkMTNPdWlJSW5zMlRNMHR1YVR3RkNOOXM0cFllMkQ2UXhQYklI?= =?utf-8?B?WXlCTG43UDBDR0tpN3ZETGtodG4yOGJpS2JhRDlyQVAxZDBTZGJUeEdtWjJ0?= =?utf-8?B?b2dMYTJCcW8vaVNWME9Vc0REcEpCaTRFZDkwKzhTdUZWUS9CaG9yb3pPTDR1?= =?utf-8?B?U3NmSUs1YXp2T2hzS3VtbnFsby85ZGJRNy9XWlRVdzBhV1dMY3Jack1aQkRv?= =?utf-8?B?N3ZNaWREWFRuOC9sTElIbWJkTmd2VTVMTW5EODgzTjVneGFLM05VblhUMVZZ?= =?utf-8?B?S2VOVmdNWEtCUUpPUnNQancvaUpDNWlpQ0h4Z09uUUYzSkFrV3hXUWoxbXpP?= =?utf-8?B?K0UzNitUdXlWcjFObHZKZGVYMWwvTUt4cW8zTGZnNWxOWXNwQ3UrdWFQV29P?= =?utf-8?B?T1ZlZDhZbC8yRkJpM2NaN2tRRTVuOUdiek1PNXlyTHJwbTdPUENweVJUUFVH?= =?utf-8?B?eFZ2b3QwWUVjUUZVcXJ0TnJGNEZyOERxeEZBT1htWm5oY1pWU0l2WXNMVjB4?= =?utf-8?B?Q1F1QTE2d0JiZlZ5eVhZMWwzVWQ0NXl4Qk40U01rTFV4K1NySHIvbHdjOVNa?= =?utf-8?B?dTFyVGEvV2ZVZGg0WjF2ZkgweExVZkQ3ZTFzekR4YkpsOUNzS2dCTk9NU2R6?= =?utf-8?B?UkpWY1dwbUlsNkZ4ZDVpZEl3MTNEbWdEUXpLK28yK0VOZ2VXUU5ZUFNrL0Er?= =?utf-8?B?Zk5qT1d4RzVrT2pLUHJlSXcxYUdFbGtNTGttN0xLd0YzNU1oNjc0QTFIMndM?= =?utf-8?B?ZDdkdzNqd3JYZVArVHFOTWtiVERKQ1hRaVQwN1cxUjdkaytDSjJMTm5ITDgy?= =?utf-8?B?R0R2TnZIZ25va1dEVVlWWnA3enNJUksvS01PODVFNlMyVnh4MFVhQ0h2RzNR?= =?utf-8?B?NmY0b0M4aHoySkpzcElZelV5UTJoM3dZSFQwbEhtOG80L3Z3WlNsM2dITUxx?= =?utf-8?B?ZVlOUFFNdHkxU3FDcmNJYmduQlpoWDV0MHBzWTVETTJ6VFpzU09XR1d0Y0xJ?= =?utf-8?B?UXZBdFFEV0NWTWthM2hNcUdRcm1DNmtEM3ZpZE9qVmZaOEh1aGFBSWUzbFUw?= =?utf-8?B?c01DOG1tblRGVjBnRzd3QUM5bXErdXFiMlZlTTFhWDZrbmpJOWRtd1VndWRJ?= =?utf-8?B?NTJxUklkQzVvclZxdGprb1Q4K0hYeTVOWGF3L3preCtOcWJSaDQ5M2wyRFla?= =?utf-8?B?QWdZczlDZkJqSnBMQVZYb0g2TmZsYjV0MUVHZk9ZaEQxbjY3UWhBRjExVmwr?= =?utf-8?B?YXNITGhUQ25ZbHV0OHBXcWVFYnRJK2h1a2xsU09uR0VVSXlrYTBBZ1dwRmpw?= =?utf-8?B?RWxIRGtNNWZnMHBXYjlWMEF2MzZ0SGdHZldEaTdjdzRKM1FJNEdkY3JzakhR?= =?utf-8?B?US9KZHd2TVpZcTF3alZaMXR6L3ljSDNaV09SaVJZaDRrTnAyNkE4UEpqOUZT?= =?utf-8?B?S3lxV3ZZclNpbjRCcitOVTFaNkEwdk1EbldUeS9qcTBKMjQycEx0Z0dDdHQ2?= =?utf-8?B?b3AyY1NvZ2FWSkZZQ2pMd0RwM3F4bUUxQjJMODYyamhlQldaaXA3emtERUpu?= =?utf-8?B?NGJLSStoSEx3Zm4yWnBqR29YcnRRSEsrTHBwWFdCVE91a0FRNzRoQjBaR1FJ?= =?utf-8?B?OG5Qb2J2SjJ4QndUK2YzY2k3d1pKTG03R0JLc1liVVZEQW1HTm9teW5TZFZs?= =?utf-8?B?MDZpM3h5RzdEQ0VndnhpZUpwR3B2NUFEUzJJUWZkT0JJL2Y3TXBXNlhhVFRq?= =?utf-8?B?dGVzc1pMRHF0U3N1cWdGelpacE1kemtpaGprdmZjak9ITTYzb3pwaXdra0Jt?= =?utf-8?Q?Xe68DP+hs6BURaQOCcGgiBCz7?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b24a098-f540-4ac3-02fa-08da6f96f762 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 06:12:21.3925 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0V0M18qCwWCugb+YwiiF4UI+TSn5YIe7L7gufF/UaXX2r/A3rAEh7rgdbMzRaO7+WQgBUwG9eZ3nUJD5ww5e0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR04MB5900 On 26.07.2022 20:07, Julien Grall wrote: > On 19/07/2022 17:36, Daniel P. Smith wrote: >> On 7/15/22 15:16, Julien Grall wrote: >>> On 06/07/2022 22:04, Daniel P. Smith wrote: >>>> index 498625eae0..834b1ad16b 100644 >>>> --- a/xen/arch/x86/guest/xen/pvh-boot.c >>>> +++ b/xen/arch/x86/guest/xen/pvh-boot.c >>>> @@ -32,7 +32,7 @@ bool __initdata pvh_boot; >>>>   uint32_t __initdata pvh_start_info_pa; >>>>     static multiboot_info_t __initdata pvh_mbi; >>>> -static module_t __initdata pvh_mbi_mods[8]; >>>> +static module_t __initdata pvh_mbi_mods[CONFIG_NR_BOOTMOD + 1]; >>> >>> What's the +1 for? >> >> I should clarify in the commit message, but the value set in >> CONFIG_NR_BOOTMOD is the max modules that Xen would accept from a >> bootloader. Xen startup code expects to be able to append Xen itself as >> the array. The +1 allocates an additional entry to store Xen in the >> array should a bootloader actually pass CONFIG_NR_BOOTMOD modules to >> Xen. There is an existing comment floating in one of these locations >> that explained it. > > This makes sense. So every use of CONFIG_NR_BOOTMOD would end up to > require +1. Is that correct? > > If yes, then I think it would be better to require CONFIG_NR_BOOTMOD to > be at minimum 1. This would reduce the risk to have different array size > again. That said, this is x86 code, so the call is for the x86 maintainers. I think the Kconfig setting should stand for "true" modules. Anywhere that x86 code internally uses one extra slot this should be expressed by an explicit "+ 1" imo. >>>>   static const char *__initdata pvh_loader = "PVH Directboot"; >>>>     static void __init convert_pvh_info(multiboot_info_t **mbi, >>>> diff --git a/xen/arch/x86/setup.c b/xen/arch/x86/setup.c >>>> index f08b07b8de..2aa1e28c8f 100644 >>>> --- a/xen/arch/x86/setup.c >>>> +++ b/xen/arch/x86/setup.c >>>> @@ -1020,9 +1020,9 @@ void __init noreturn __start_xen(unsigned long >>>> mbi_p) >>>>           panic("dom0 kernel not specified. Check bootloader >>>> configuration\n"); >>>>         /* Check that we don't have a silly number of modules. */ >>>> -    if ( mbi->mods_count > sizeof(module_map) * 8 ) >>>> +    if ( mbi->mods_count > CONFIG_NR_BOOTMODS ) >>>>       { >>>> -        mbi->mods_count = sizeof(module_map) * 8; >>>> +        mbi->mods_count = CONFIG_NR_BOOTMODS; >>>>           printk("Excessive multiboot modules - using the first %u >>>> only\n", >>>>                  mbi->mods_count); >>>>       } >>> >>> AFAIU, this check is to make sure that we will not overrun module_map in >>> the next line: >>> >>> bitmap_fill(module_map, mbi->mods_count); >>> >>> The current definition of module_map will allow 64 modules. But you are >>> allowing 32768. So I think you either want to keep the check or define >>> module_map as: >>> >>> DECLARE_BITMAP(module_map, CONFIG_NR_BOOTMODS); >> >> Yes, in the RFC I had it capped to 64 and lost track of this related >> changed when it was bumped to 32768 per the review discussion. Later in >> the series, module_map goes away. To ensure stability at this point I >> would be inclined to restore the 64 module clamp down check. Thoughts? > > I don't know what would a sensible value for x86. I will leave this > question to the x86 maintainers. I guess I'd be fine either way, as long as the code is correct. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:19:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:19:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375902.608370 (Exim 4.92) (envelope-from ) id 1oGaOf-0007my-L5; Wed, 27 Jul 2022 06:19:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375902.608370; Wed, 27 Jul 2022 06:19:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaOf-0007mr-Ht; Wed, 27 Jul 2022 06:19:53 +0000 Received: by outflank-mailman (input) for mailman id 375902; Wed, 27 Jul 2022 06:19:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGaOd-0007mj-D5 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:19:51 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140084.outbound.protection.outlook.com [40.107.14.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1e63763b-0d74-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 08:19:49 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB6314.eurprd04.prod.outlook.com (2603:10a6:10:c3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 27 Jul 2022 06:19:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 06:19:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1e63763b-0d74-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jzc2ua35zDz76mr9gG6Q7Ac/6joC0x3KFw1DCoqEeBsd6HkKEeZSFKmGmjQYbI1JmxtZNDzU+9ZjWnyU7IuAIRUDiWGeYfcxkUrHOr5r1Qv1IqDDKJRdoNhT2BdvV9r5MzJkJl34NjHlvW9W+5qfrfm0JbMIp/h5JGZEeYoYY1wYq0eVJG0x4hzYfi+5XOqwJZoVwECMNwgoYaa4uoCcXbJOjcWSjBH/uXJOPSna99WnUSEKtfeJEoQbLiQvDC7zUxNOU2FhTovIU8tBcZXB0PNNPMUMX3yncBCVAp2WlZlKXOEN7CUOf7IHtz9FMxeFSb0w9eXFv8B93hF1y+TVhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kfFdOSv5zxRvwJrqNP27myQOEUmuP3OpZqLriS7N3VI=; b=kvwFTP8m8XNPbkGe0riOFTXQMqBSIh5gU0upsOUnhJohU4dl4hZSwSJlpRNAxz3ZJpwwAm+7gpR+uqIw+UzWYBD+xJpzI4q5FLCA4wtEVpzXHjFbrffmqR+uyrlECHq8ODC1IxDdu9jrSrtmpIl3v5x4798hOkwjHSua4UvwstJpSzmcV+QF1zAR8SSrFEwtpYiy6SJaiZsvN3WlcJCjOHJuIEzZSduZWGt2aCYgnnStxuvfDJ3KWyqGKRjNjdwo0eZodYRqlDlHjoZ774FwelWyjrT6qCdBCZxCLHcRmRbTtfaizLklGS/0Oa+ADjE0fTUXK/dQza0vaHf/TwThzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kfFdOSv5zxRvwJrqNP27myQOEUmuP3OpZqLriS7N3VI=; b=4fQTOW7d1L8eUTs6hUjFv0VLs/ctsYS1Cbc8L9uDjUHb31gHbPQrcBt0GI1Gmh1h8OGEQ2E6b6mrUrb0QGnt/IDOfwruHambvntIzOiqLR+cQm9RmUF8cbJdzh7GjyfHc5xlZEzCLGPz+iVKscJZiisWev2ThMdLZPiUcUz1KEgHmTe/38boXy/1WDhjLv/u0BD7icC/S4Y/P1HbJnntBGXm92cBom1k6IhKFUEMYBweWkkICXS0OqBOAc7JqNE0Cxg6x97S9GeEjOBa5DdPCcYGAePd4DstYf/vi05hMrSlLnahApOMq+BWxGC5/2axQQKYM55KxfVR5fzR19AXTA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <1c810532-8d2f-58ce-ca6b-a9f70ea083ca@suse.com> Date: Wed, 27 Jul 2022 08:19:44 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86: make "dom0_nodes=" work with credit2 Content-Language: en-US To: Dario Faggioli Cc: "roger.pau@citrix.com" , "ohering@suse.de" , "george.dunlap@citrix.com" , "xen-devel@lists.xenproject.org" References: <1617b87a-640f-d235-701d-df2c57314b73@suse.com> <2d56bb1015a263b6d1b196050d088b84c320b808.camel@suse.com> <30ac2ce8cca7217775eaa704aab45a62deb1272e.camel@suse.com> <35599105-b441-96cf-7537-ccf9dfac0934@suse.com> <85c55676-b21f-1eb4-0471-19ca9b6de39f@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57e6ed81-0ec0-41d4-ca00-08da6f980034 X-MS-TrafficTypeDiagnostic: DBBPR04MB6314:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s9HvUZaP4l/qtedRLzT3aDJRLdU0x4l0kJyLp8wQwwow+ZlTwDMCQMXpDmytMz4JPRDSxZkRkypKmFFqDbCmF3rtTnDE6P8/3ALqRzmn5P46gB7PCRnMI8YUGoBC0hsCH5q3c40mVp0juCe3HLxOjN57bQq+h7nXOHMYQ/Dxo9HglARWgAEP2lniwhVxSqXnNcoMi1qdH4nq7MofsEwLtWlprDfrj+plbUdkrKFhleo4R5RCi2deYSEZOvpTH3DDemkDIxSnlFa7/QPIQjtxPjNKJ+jKjsUGHDo4UH7elQA8VJPPNblLXmP1SxA/bU7RsJ7XoyYnWaUO1rz2UFFkmlHId2ZeUoSHdAB2v4EIfvOGcix7GX/NYPR7D+6IDwQx+PAo84XglI5C64EWOoUORk+WIWQmyOcD7Gz+HEb92x5F0zFUWyzazpGj4s8EfVZEHzeS4gyF+taX5L6+EyJ+jF6HJN8IcEZdeSL1V1xPwT8C9LdGLbQQig34it6LXPf/OBuELjrTDCrZPWsC5Q5+mmCyKkGXX0be9SK2LGJZRSn+VSIrW/mtXPwGNxfbEGUXVacv2N7EYQfNih1V5jRnniam7I9dSWZ9+vu7Bd9rUcOrKVnw8cXoLfPPrX92GARxmHi7Gc7NdIelNS6gSHi92S7OGpTFvlBLF5XpWjeSZnjeVX4EXMsYfWwGVSB/qS1pmRqct68NIZz8V8/2DxAR499CNOdrev3sqSF+4J+sVoEEPAGy13UCCMAYp1Ba6+wewPBQjT8CLwkkzy9v+jJ+g+QI0DOcywNr8NpV4wgGHubi037vMWmMLama2MgzxxtSrMyLOYMj6tGgm0VeNS5YAnWrC62YTsfr/lZisT9evugOUse6GzexxqL1Wbknqlqi X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(136003)(346002)(396003)(39860400002)(366004)(6862004)(38100700002)(86362001)(31696002)(8936002)(5660300002)(478600001)(316002)(6486002)(83380400001)(66476007)(54906003)(4326008)(37006003)(6636002)(66556008)(66946007)(2616005)(6512007)(186003)(31686004)(41300700001)(8676002)(2906002)(26005)(36756003)(6506007)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUI5UjUvZy9zczR1TlU4b0hqdWRCRUY2bkF5ME5TK2hpNWdmT1o5T3UwR2xJ?= =?utf-8?B?Vkg4OXg5bXFDd20xT09VUDlIZ0ZQYVN4a1BTR1BhMTdTOXhzUUFuZjA2UzFq?= =?utf-8?B?cFE4RVBsTURHVGdRZHNQTFFwL2V0eWl0ZHNkMlJMZ2NWTWZINXVDallZWE16?= =?utf-8?B?L3ZybHM1MjZ6Z3R5SU9CcVFyS0Z3N3pGSWVTWjQxZFhvNzF1R2xCaHlYSEV6?= =?utf-8?B?WWVhWk04T1hodysycnBxblQxYlBEMDVJRS93LytHMXVMSWVjaEpNMzIwSm1n?= =?utf-8?B?dnZsMkdyQWlaRnUwRGRSU0xQcXd2ZGhjUCtkQVIxWkRoSXc4YXZmYzRjQ3k3?= =?utf-8?B?aEJUZWhUTkNuamhKakhWUDA1YVp4UUdDV2xNL0Y4Y01MOUNHOGJXbzNxeFp4?= =?utf-8?B?eHJKaVBISVB2VGtzTW9abW1tMU8xNjY3WFYzaXpEUVhKOW9nYWJHM2JDMHBF?= =?utf-8?B?N1I1d0pUMzVYMjIvVDg3ODQvM1hsNnh5ekd0c2RLSW5JNmg3RkwyTHVsYUxt?= =?utf-8?B?RG92VFVWOTU5YmVtVGJFTjJqRU5BV3NIZ1p0TUFYbG9CM3R4U094TUp4Z25N?= =?utf-8?B?M2g4R0VSK3hvaExLeUNZbkhIUUl3QXlaZG5aUmhmaFJCVEptRjNBYk93L3Bt?= =?utf-8?B?R2pMbEpHUS9lQUxqWWdFMFMvV1NWUFM0YkI0b1ZqbVNPUTkybWVwT1pFamJB?= =?utf-8?B?azNDaFdpeGt2ZzZlYStBcUxmOE54bWlGSTBHaXpRUFpQbnE1Ulh1a2c0WkNB?= =?utf-8?B?S2YyVjdnT01rTjRZaWhQM04vQlo2OS85R2dNVVZLbmVDWndzS2I5aElJZk9E?= =?utf-8?B?VTdWVXE1dGdsU1FNWGllWEo3YzBZYkFnVFE4NHB5ZERGYU01azJ3MTBZOU9F?= =?utf-8?B?T3NjOXY5R0RaTXVRQTJEbHp2RE1SejhPMjhCQzZJbHNRL0k5QWM4MTYzRGNz?= =?utf-8?B?K1lBcStkMDRNWHFuRy8zQVk4UkxJeTgrUzBpeWJBSDRWTkhaN1p1aTF1SjJ3?= =?utf-8?B?SUxmRXlsWENaZmFDN0FCZUxjWVo0enJFcnNlOFQ5ZHBQZWc1RElEekVKQ2ln?= =?utf-8?B?T3Vaa2ViM1lXM3pvS2VlQVpubExjUHNEOWszdEsySjBCUUFhZHU5NkJWQnpY?= =?utf-8?B?NC9NYzN5RUxGWGEvZWFzK2F0MHV6eDhiUnArNTZwZ2w0VCtaaG9HTEE0eEk5?= =?utf-8?B?akVkZzl0SlBoSFdNc2JJVFpQWllxTG5xRTJSd2EwR2xLSVpSamxuNG11SXJq?= =?utf-8?B?c05QcVF3VU0wNElla2E3SzI5VWt0cjNidFdrbTcrVHdGeFl2bVkyY0xSUzBJ?= =?utf-8?B?bmo4a0pheTFxTlpIb01rcU16eFNEa29RdGp5elRsS3JCdUFmeE9oYlM5N2Zq?= =?utf-8?B?bjVGTGgzS0hFcTVsa0FOSU4xTnJCd1BwdkJhWFhlSTZGSkNlbC85YW5Zb0F0?= =?utf-8?B?VU50QjAvVFJPL1o2N04xSTYyNzF4cUpZT2oreCtqT0lkeHlwbXBHYnlERU93?= =?utf-8?B?OTJuL2R6SnExNC9OazVRSllUMTZHSVk3b0Q0bU53RnNETTVLN3RIZXoxOTRC?= =?utf-8?B?Zy81Yk9MKytLdUVlTUNyT090aWNWejVkT1J0OUtuZWNaT29MZ0JlcEhnRjl1?= =?utf-8?B?Q0czN0g4dEhSd2NIa2hubHJSVkpkcTN1bHUyemY4RzAwSmhHQjZRdFgvNGlJ?= =?utf-8?B?ZWR6QUpIR0RJaU0xdDl2STNTRHFpTW0yZmRNWVJGS0ZzdkJKaEVFZ2FJQndY?= =?utf-8?B?Kzk5b2NMdmlXZ0JpVlk5b01Oc3VaVTZlRDZkRTZNbDhoK2ZLdmtyc2tqL1dX?= =?utf-8?B?U3d3bVYxUVVwaEZDU0h5Y2drTEY3VFMrZWdkWnJieXc4c3ZWRVF5T1ZFSm0r?= =?utf-8?B?bk8yUTBkMis2L21xcWFmNnAvcitya2lKWk1OY2dKWmMzSnZZeFR0OW1yU2lO?= =?utf-8?B?YUZrUXAwb3NmUmlOVVBBVHp4c0hCaEZXazA1VlhJTk9qS2RvOVhHeVo2aUVk?= =?utf-8?B?SUc1SXo0VDRxVURCYTN4bENCVnBtWGlGN0lLWldRSkFORUVjQ2lMUWxhZ0Uw?= =?utf-8?B?UnRZcENXSnY5aTc3aWtyUjN1ckJEN2xUdzNCNnJZbldpMVhiYk1vYXQvaFIx?= =?utf-8?Q?f13zo10YY5Vsri2+jGgJtWP4H?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57e6ed81-0ec0-41d4-ca00-08da6f980034 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 06:19:45.8330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: T4E+is1ENrNboS1sZXf2QjqPzjqZyDeBA5mUV1bzMApmePh5a/7aSxiJTC8Q5vNh5KvH9Tzt1MqaUmjl+BwK/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB6314 On 29.04.2022 16:09, Dario Faggioli wrote: > On Fri, 2022-04-29 at 14:16 +0200, Jan Beulich wrote: >> On 29.04.2022 12:52, Dario Faggioli wrote: >>>> Is that mainly >>>> to have a way to record preferences even when all preferred CPUs >>>> are >>>> offline, to be able to go back to the preferences once CPUs come >>>> back >>>> online? >>>> >>> That's another example/use case, yes. We want to record the user's >>> preference, whatever the status of the system (and of other aspects >>> of >>> the configuration) is. >>> >>> But I'm not really sure I've answered... Have I? >> >> You did.  >> > Ok, great! :-) > >>> >>> If dom0_nodes is in "strict" mode, >>> we want to control hard affinity only. So we set soft to the >>> default, >>> which is "all". During operations, since hard is a subset of "all", >>> soft-affinity will be just ignored. >> >> Right - until such point that all (original) Dom0 CPUs have gone >> offline. Hence my 2nd question. >> >>> So I'm using "all" because soft-affinity is just "all", unless >>> someone >>> sets it differently. >> >> How would "someone set it differently"? Aiui you can't control both >> affinities at the same time. >> > Yeah, the argument here is basically the one that I put below, and that > you say you understand. I guess I could have put it a bit more upfront, > sorry about that. :-) > >>>> >>>> Hmm, you leave this alone. Wouldn't it be better to further >>>> generalize >>>> things, in case domain affinity was set already? I was referring >>>> to >>>> the mask calculated by sched_select_initial_cpu() also in this >>>> regard. >>>> And when I did suggest to re-use the result, I did mean this >>>> literally. >>>> >>> Technically, I think we can do that. Although, it's probably >>> cumbersome >>> to do, without adding at least one cpumask on the stack, or >>> reshuffle >>> the locking between sched_select_initial_cpu() and >>> sched_init_vcpu(), >>> in a way that I (personally) don't find particularly pretty. >> >> Locking? sched_select_initial_cpu() calculates into a per-CPU >> variable, >> which I sincerely hope cannot be corrupted by another CPU. >> > No, not by another CPU, hopefully. > > And this is probably fine, during boot, when there should be no (other) > scheduling activity. However, during normal operation, a vCPU being > scheduled on CPU X, or in general having X in v->processor, could be > using the scratch cpumask of X already. So, if we use it without > locking, we'd risk using the wrong mask. > > Therefore, we require the scheduler lock to be held, for playing with > the scratch cpumasks: > > /* > * Scratch space, for avoiding having too many cpumask_t on the stack. > * Within each scheduler, when using the scratch mask of one pCPU: > * - the pCPU must belong to the scheduler, > * - the caller must own the per-pCPU scheduler lock (a.k.a. runqueue > * lock). > */ > DECLARE_PER_CPU(cpumask_t, cpumask_scratch); > #define cpumask_scratch (&this_cpu(cpumask_scratch)) > #define cpumask_scratch_cpu(c) (&per_cpu(cpumask_scratch, c)) > > And sched_init_vcpu() (and hence sched_select_initial_cpu()) can be > called during normal operation. > > In fact, sched_select_initial_cpu() does pcpu_schedule_lock_irqsave() > before starting using it. > >> >>> And again, soft and hard affinity should be set to what the user >>> wants >>> and asks for. And if, for instance, he/she passes >>> dom0_nodes="1,strict", soft-affinity should just be all. If, e.g., >>> we >>> set both hard and soft affinity to the CPUs of node 1, and if later >>> hard affinity is manually changed to "all", soft affinity will >>> remain >>> to node 1, even if it was never asked for it to be that way, and >>> the >>> user will need to change that explicitly as well. (Of course, it's >>> not >>> particularly clever to boot with dom0_nodes="1,strict" and then >>> change >>> dom0's vCPUs' hard affinity to node 0... but the user is free to do >>> that.) >> >> I can certainly accept this as justification for using "all" further >> up. >> > Good then. I notice this issue is still open. May I ask what the plans are here? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:33:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:33:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375908.608381 (Exim 4.92) (envelope-from ) id 1oGabG-0001m6-QI; Wed, 27 Jul 2022 06:32:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375908.608381; Wed, 27 Jul 2022 06:32:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGabG-0001lz-NH; Wed, 27 Jul 2022 06:32:54 +0000 Received: by outflank-mailman (input) for mailman id 375908; Wed, 27 Jul 2022 06:32:53 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGabF-0001lt-NO for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:32:53 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70048.outbound.protection.outlook.com [40.107.7.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f0cac56c-0d75-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 08:32:52 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5467.eurprd04.prod.outlook.com (2603:10a6:10:80::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 06:32:48 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 06:32:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f0cac56c-0d75-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kdpAkA5EBnhOgULm6HOrJ9LI+tyrAjxIc5/k1vzq/I0c0X3ic61SwoRSYhchtNgit6c8JQ0a9Hpfutots4pe7e2MPOiLRXSEMzLl8MwK/jE3mnLOBIjPIbGC+AI0MEUs77UI9k5KcRPG+qgL0EFUg8IESSrATxT/IRsdp/4RIOE7UTqQ+yLjFVhk+pam9U92hiwgQ9BoQGrwXB6XxVddmcOQiCw1sfaXX58Ru10kKUphMkTpgvYvYnavsk2uegDBL3mtIoAsZz4bB1fd5iIix7I/NG9A7rGXNQSs+T67mp+3j1zqpzgulyCckfMPOEFrsXf0AU7SIlynV/Xj8kmSSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YgtaUsS5yF/v4t7ZXNu2/g/7jMosFjQ8zb6pO9YeMwc=; b=fegIrrZBu8Kuz7pmWc1w7ylUBNgldc6AgTY3+LxyCiG3X9fZ03nhUyyz6JFy5fydc6bvfkw65HoXzkLA/ctv8NoxSwDJ9hq+aZCivYRoPeZYS0uq3rtSXxdv2KgR5E/d5srjSBnWvH2W0aMhT4JRqvImGVjUY7s5Lq0XGnN/UVKUi4D16uQ0Kvkp/tOIH0tYFOUM6Wxk61QZPwL4bLC9Qu8nDuj2/XRB97VCs12jqZN8ZycCXZGjK+7GTvkBsMIl3o16Zy8r8RUoAuxNEZMEGu6+5OrACNnFIUOOVbFez6z5OWjSF5vwTUXlw5paktBgzTWQYYO9yD+ZPumedo9XPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YgtaUsS5yF/v4t7ZXNu2/g/7jMosFjQ8zb6pO9YeMwc=; b=1xgqZxzKXjT9cFg7Ckm6/PHqpgbSqyFXiSIebyU3nvRRojQb0ZjP8M65cDY8YyGvo67IMWdh9HO9oxDHVOgQH6lmXPNZ0sEY6jmgrlM7OffkKq8kc3Vn4MRmm5nabiuYHUKLpAjs/qB4RhAMPVhgQK2m1Lb3N11kwUcb6ktapAFVUYv4+F//+n3rBnKvkh0t2ANIBt/H0B3q/tCWoliArjpqKQ5QKrlROi94P/pTGP0LQOo5fRzOp9pnC0NdD90PqXIMA3vMFvmMRXlCQihXvjH8k/jXm2edxSDsT28snFKr/ofX0oZygRV9w0k8D1E2y5WXHZQYfr6P4Du0COnRVw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 08:32:46 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: cpupool / credit2 misuse of xfree() (was: Re: [BUG] Xen causes a host hang by using xen-hptool cpu-offline) Content-Language: en-US To: "Gao, Ruifeng" , Juergen Gross References: Cc: "xen-devel@lists.xenproject.org" , Dario Faggioli , George Dunlap From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0126.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: df59f344-01e7-4776-48ab-08da6f99d2c7 X-MS-TrafficTypeDiagnostic: DB7PR04MB5467:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5UM3vQUb+nQ345qMEl35TfAkclK88QXnxUId07BfKxVYWsG2lVAPDd9fkHbNaEfTBS3dtNRGU0qXPZw/ipliCzVqeLudV6Ggj6xx0fNgqMlqGthMpYO+2KNTUybd40rTxlJt4eUbmW7boTCqf8S+IOCvvOcrg2n1ek192IIqXlBhn0+isQ9vKu4FZ8ZDln8u1SqW/5mTdAj4ypjkwrgne7DDtSHypkiIzy5PUcLmA51zDO3OlKqS5XifQ+HHvIF6xwuN6dDYiJneHnQDu8qpXjDf3p7G6sDYL5Bp+ISo012p5qEBfec77CyJNwUeWweOfKT+qaAB9CS9YgG83I6/tfDoG8tf1T2NWgULlNDiq8kG6td3l28LnHoc708L06xyEtY97WTuQ68JEdrZ2kb2/fIbbE5CPWT5eubCMeBmp8ZfQ4gbM2cOrVx9Guv7jhzLam27bZKyWecvdEFlE2TTuYnwsL5Xmb6q6XCMDfBXoN5EtFYOUky7lyRixq2fZAgmpKx9wKPGEb5zT+TySS1aFWl0P3U0AF2121ynZd4ORF9sKra31KvGatrK4IUAcmnHeQPdpok/e1Uo+e9e7rNOVsXXOFELHCwR6eM6x7G8Z90fkSSDYVCfhdnAk9CorSrSrVpP4bKg3IFMQXpl81ccnZy5lGub55Zbjf7kfHdKS1lZwpRGlhthycS25pZiDlHbA+POuHWQJqI979WoLzdX/SbCqHGC0KUMpJQTzzAd7t+xFkE3gnssKW1Ik4NWci72nWeFCdZrKbEk5zGUypdZRANR/JpCGmeWmrHQWa/ElLqY7E5Cc7V2YnnElXRDKdpYadKgKFI59bJJ+yX+moT31g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(396003)(346002)(376002)(39860400002)(26005)(53546011)(6486002)(66574015)(478600001)(6512007)(36756003)(83380400001)(6636002)(8936002)(316002)(31686004)(41300700001)(186003)(31696002)(66476007)(2616005)(38100700002)(86362001)(66946007)(66556008)(2906002)(5660300002)(8676002)(4326008)(6506007)(54906003)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OXN1bERmVHY0akRUWEtSS1NxSVk4V2RlVWw3dmtQNzUwUVgzdStNY1lsKzBU?= =?utf-8?B?MktIMVo4RDAwZUJoWW1KNWlLR2VYUzJicFNDOVZyRVB6dzlmZjhNa0Vqam83?= =?utf-8?B?RkRjZExWeDNacjF1eGdHVTdFdlBMOUdKVTRBc1R1N1k1QjR3RStjNE5BVWF3?= =?utf-8?B?TTZLckhDMG9QWEowY0pmbzR5d0hLYy9xWnUvb0ZRY29JUkZwWU92MUU1UVdY?= =?utf-8?B?SmtKeFA0eVhiV0k0dXdjS3BtYzNGcXB2enB1ZkkrMURDYkdMMk5lL29iOWZ1?= =?utf-8?B?RU8yeVViR05ucGFZa09zY2ZrOVk0MFplUTVxbGxLMXdYVnRTVXg0UWk4WElQ?= =?utf-8?B?WmtUejJReEYyckRFbmJrUmtSaGQvamx4VXpOOGFTTk1JaHpyUjR3RHlDOG13?= =?utf-8?B?bGlibWlSbWh5S1hFTi9SbmdSYmRIc293NUFBS1AyS1NTZ3BBMTd1YkFEeDZw?= =?utf-8?B?NEVDcnJ1MktsMWd4ZGkydFV1SWJZdjkzZ0c3dmhGL0NYVVRvcmkySTB6cmNU?= =?utf-8?B?cU1tMFpGVVRFQnlwMGRSSSszL2dISmFORnkvS05JY0U3aXMxa2o1WGhOd3Z5?= =?utf-8?B?OUMzUlB3a1VQdFlWT3B1M01UMmttQ3BvYlMvbnRhdXZDNXlMOXV6WjVXM1hx?= =?utf-8?B?MFFCWkZuZUNFb0tNS2Q2RFQxR1FYQ1ptMml3bVJxeERHcTJnNWlDT2JxbWFs?= =?utf-8?B?MUZGZDNEZ3NyQXorNm1WY1ZCUHd1K1JvN0pWOWh3NjY1M1Z4NS91Z3NWM1J6?= =?utf-8?B?dU0rYmx4UVJoclVpTVNNTFQwemVrZnNDeDhEZXRwQkxUVkJkZzFMeGZqK2lm?= =?utf-8?B?ZkJDVk1abnJJZlpJaCtwTlRvRmZaaTFIeGpLVng0a3QxZXlpWjJHNzRrNXZ4?= =?utf-8?B?Q0JaV0VkV3pCWVAxQ2puQ3dpbU1yRkxGeHFrdHR4SFVCQkd6RDJwbDliaUlo?= =?utf-8?B?NDlDdzhyTTdaL0pEQXl6aE94QWR2N1JzTFpaSEhoWXZWSDV2RXV2OFRNRVpH?= =?utf-8?B?STRnMVFYb2ZuQ3ZxcGRxVm1DVzRUV0NVRUR1aGhzZWYyQmhQdWhwcHhjbHhT?= =?utf-8?B?Tm5kOVRsR2VCVSs4aW5IaGVJSmV5SWxNZXJDUXhXdDVPMVFNV25qMTlqRUc1?= =?utf-8?B?N0hJUmthblF5ZEJvVTl5NVJ1bHB2anFGZWZvclloZGYzMEZXOVZOd0UwOWxw?= =?utf-8?B?bmFibjg1bHAxV3dDKzY1UW5SSlFkcnh6NFVVTStqSVYyaldwR2hwOUlkUldk?= =?utf-8?B?dXJjaG9XMDU0SnJkOUhMOHFibnpXblUrSmJGNWgwM082Nys1d21sSTRiNmxp?= =?utf-8?B?RFd5SUR1ZUhlekp3aURNa0VMdmZ1WnZKSGU1TzE1emNlS3RyUnhxNWlhVU9z?= =?utf-8?B?cnVWNHpmTHV6SC9kWi9kSnJyeFNaRTQ0UU5WR3d1aGpGOUxDM2R5V0lnbEgv?= =?utf-8?B?aHFMU0RnOGxLQ0VydFF4OUdFR3BTR210Sld6N2JjYkJ0WWZybzFmelRhb3hh?= =?utf-8?B?VXJrRW4rVWFYdXBpVm9zNEJHOHBjc3NCbXlENlQ3cmVqRUtvRDF0ZmhUVyt5?= =?utf-8?B?SUQvcC9JSWJGUmtMOFd4bk9xQVZHQjBiV3JORzFTNUYyZndvMzY3aDhuWkRp?= =?utf-8?B?V2tyaldUdFhtVGlOTmVONi9sUXlUcDJvaW8wSW9FaFZPY28yWEZjS085Z2hT?= =?utf-8?B?LzBqbGlodlB3M2FDU1RaVXA5WExZdVB5M05nNGxVNGdGOWtZWWluOURxaWlP?= =?utf-8?B?N3o0d0hNbVN3bWw5TzlDTkthS3NEczRjZFdqNk5Va2ZTeXByWjJFRVVWZFJS?= =?utf-8?B?eXdNek9ENjJKN3JMYm5uMEsxazZ1ckswbWh3aEg4SHVUbk5UQXZjV3MxYllB?= =?utf-8?B?aTk4YVAwWGx5dHdrdkUyRlBCVjQzRmFKbjFrV2ZYUHBXMVdUMDhDWjRSVGU0?= =?utf-8?B?TmNYWTdEQWVlRlRhQkxHYnd5SXI5VDNpb3dxSnhvVUZRWFRhaHdpNlRwT3I2?= =?utf-8?B?MnhmS1QzeWltdGVxc3ZkZjY4aGNyMXpxSE9Ua01DNGpHTVBGbEZzTXBIQ3Mw?= =?utf-8?B?cEhKVmsyeld6eGtiV1VzY3BYUDcxenExb1JZM0t3YUlpVHRUanptK2tLTzg2?= =?utf-8?Q?0VZ7D/qMrooOSTEauzuSwqNPi?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: df59f344-01e7-4776-48ab-08da6f99d2c7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 06:32:48.4395 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4BFz488eh+A1zOmaUg9MNmzb/uxVxyAUeHlUQqQAJ19htb8mEew1Xd5bQkmCxbbDPveYWj3pP/aiOzO4XCdWAQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5467 On 27.07.2022 03:19, Gao, Ruifeng wrote: > Problem Description: > Trying to execute "/usr/local/sbin/xen-hptool cpu-offline ", the host will hang immediately. > > Version-Release and System Details: > Platform: Ice Lake Server > Host OS: Red Hat Enterprise Linux 8.3 (Ootpa) > Kernel: 5.19.0-rc6 > HW: Intel(R) Xeon(R) Gold 6336Y CPU @ 2.40GHz > Xen Version: 4.17-unstable(ab2977b027-dirty) > > Reproduce Steps: > 1. Boot from Xen and check the information: > [root@icx-2s1 ~]# xl info > host : icx-2s1 > release : 5.19.0-rc6 > xen_version : 4.17-unstable > xen_caps : xen-3.0-x86_64 hvm-3.0-x86_32 hvm-3.0-x86_32p hvm-3.0-x86_64 > platform_params : virt_start=0xffff800000000000 > xen_changeset : Thu Jul 14 19:45:36 2022 +0100 git:ab2977b027-dirty > 2. Execute the cpu-offline command, here cpuid is 48 as an example: > [root@icx-2s1 ~]# /usr/local/sbin/xen-hptool cpu-offline 48 > > Actual Results: > The host will hang immediately. Well, it crashes (which is an important difference). Also you've hidden the important details (allowing to easily identify what area the issue is in) quite well in the attachment. Jürgen (and possibly George / Dario), this (XEN) Xen call trace: (XEN) [] R xfree+0x150/0x1f7 (XEN) [] F common/sched/credit2.c#csched2_free_udata+0xc/0xe (XEN) [] F schedule_cpu_rm+0x38d/0x4b3 (XEN) [] F common/sched/cpupool.c#cpupool_unassign_cpu_finish+0x17e/0x22c (XEN) [] F common/sched/cpupool.c#cpu_callback+0x3fb/0x4dc (XEN) [] F notifier_call_chain+0x6b/0x96 (XEN) [] F common/cpu.c#cpu_notifier_call_chain+0x1b/0x33 (XEN) [] F common/cpu.c#_take_cpu_down+0x24/0x2b (XEN) [] F common/cpu.c#take_cpu_down+0x9/0x10 (XEN) [] F common/stop_machine.c#stopmachine_action+0x86/0x96 (XEN) [] F common/tasklet.c#do_tasklet_work+0x72/0xa5 (XEN) [] F do_tasklet+0x58/0x8a (XEN) [] F arch/x86/domain.c#idle_loop+0x8d/0xee (XEN) (XEN) (XEN) **************************************** (XEN) Panic on CPU 48: (XEN) Assertion '!in_irq() && (local_irq_is_enabled() || num_online_cpus() <= 1)' failed at common/xmalloc_tlsf.c:704 (XEN) **************************************** is pointing at the problem quite clearly. Conceptually I think it has always been wrong to call xfree() from stop-machine context. It just so happened that we got away with that so far, because the CPU being brought down was the only one using respective functions (and hence there was no other risk of locking issues). Question is whether we want to continue building upon this (and hence the involved assertion would need to "learn" to ignore stop-machine context) or whether instead the freeing of the memory here can be deferred, e.g. to be taken care of by the CPU driving the offlining process. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:33:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:33:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375914.608392 (Exim 4.92) (envelope-from ) id 1oGacD-0002MO-8s; Wed, 27 Jul 2022 06:33:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375914.608392; Wed, 27 Jul 2022 06:33:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGacD-0002MH-6C; Wed, 27 Jul 2022 06:33:53 +0000 Received: by outflank-mailman (input) for mailman id 375914; Wed, 27 Jul 2022 06:33:52 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGacB-0002JA-Jh for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:33:51 +0000 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [2607:f8b0:4864:20::1030]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 128b14d4-0d76-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 08:33:49 +0200 (CEST) Received: by mail-pj1-x1030.google.com with SMTP id y1so7346731pja.4 for ; Tue, 26 Jul 2022 23:33:49 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 128b14d4-0d76-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d4rxJWNrLd69Ca2jXUvOX0vvmXMraa+M4D9+dM6eV/M=; b=iOmhnTfNuWjkT5X4vWmQfkpttxb7FK321LIkNFTPPk2qWp08yPGB9OKhCAdpMVirar bO4wez85HSO4tszFmjDXldczwzLM38T0kP5MStaD21G0sXQi4o1qMWQybacbDT5SUwyP PvZpavFyIRWU/i7iVkofAV0Sy5N5fgfcW9gAtMZV7p6vZY+Q1TgUyF0Eig9nwZLibazu BQXnofA6ZWJdmG0cmI86+KrkO0Cyv4mIWIgC/GWNtPbTLdy64FOqsmNJPWKLTbz23+OE qSiEilPAIpJlp+9VhKJgbR79OY4n7n0WmVKWXdhW5maPBFV3iqDdIkIRKoNJGr47+ClT xZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d4rxJWNrLd69Ca2jXUvOX0vvmXMraa+M4D9+dM6eV/M=; b=2Dq4eiR1F2PK2doNRZPb8SJk+jUISpyvJYmnsenpSUA1Z4EzRFDHZKdgKa2hPl1n86 8fJWKeh53JaXhghV2l3YG8PuU2rnS9vteVF/ckBWT3zYqJuVgq3Mgi2BiY52I/fImwYp rGv+ddMGyxYSssOrYGoKyR3drr9JcovG/fQCmIX3QrCrzVL+OdPRpjMDQOvhPJ5ktZav tEWmEVd3E7jKY7MVKcYtCge6bapB1nS/6rma1cyKqaiAtHOeDO0fAHDtS5DGMjrTmVJS GuhQOXdshkKDKn037sQqPiQuUWqVveUAPVLGeHbGvfb5SzkpUqkHVgsukm9OkqDSf5vZ 0ixg== X-Gm-Message-State: AJIora9SyK8ZuLYKI2ZmF+kqL/tfu4zEwF0T1kjJm/HxYUsrsRZ8fzn+ Vgcm6QeZiWPyjsQL9z4A99htt4g3Ez9KcvLHO7521w== X-Google-Smtp-Source: AGRyM1vWG0HrZFqdtDAJstboin+IS+fZLr0EYz+pN3Pa0pBrzQjF6oC2t8jiiQJorKLzWn9g/mWfNlFvwJQa7MNaMv4= X-Received: by 2002:a17:902:f68e:b0:16d:784f:ba with SMTP id l14-20020a170902f68e00b0016d784f00bamr12585084plg.174.1658903627923; Tue, 26 Jul 2022 23:33:47 -0700 (PDT) MIME-Version: 1.0 References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> In-Reply-To: From: Jens Wiklander Date: Wed, 27 Jul 2022 08:33:36 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com Content-Type: text/plain; charset="UTF-8" Hi Julien, On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote: > > Hi Jens, > > This is the second part of the review. > > On 22/06/2022 14:42, Jens Wiklander wrote: > > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > > + struct ffa_address_range *range, uint32_t range_count, > > AFAICT, 'range' is not meant to be modified. So I would add 'const'. OK > > > + unsigned int start_page_idx, > > + unsigned int *last_page_idx) > > +{ > > + unsigned int pg_idx = start_page_idx; > > + unsigned long gfn; > > Below you are using gaddr_to_gfn() which will return gfn_t. This is > using the typesafe infrastructure: gfn_t will be a structure with > CONFIG_DEBUG=y to allow type checking and a plain 'unsigned long' when > CONFIG_DEBUG=n. > > Please make sure to test build with CONFIG_DEBUG=y. > > As a side note, I would suggest to try booting as CONFIG_DEBUG as it > enables extra check for the common pitfalls. Thanks, I'll do that. > > > + unsigned int n; > > + unsigned int m; > > + p2m_type_t t; > > + uint64_t addr; > > + > > + for ( n = 0; n < range_count; n++ ) > > + { > > + for ( m = 0; m < range[n].page_count; m++ ) > > + { > > + if ( pg_idx >= shm->page_count ) > > + return FFA_RET_INVALID_PARAMETERS; > > Shouldn't we call put_page() to drop the references taken by > get_page_from_gfn()? Yes, and that's done by put_shm_pages(). One would normally expect get_shm_pages() to do this on error, but that's not needed here since we're always calling put_shm_pages() just before freeing the shm. I can change to let get_shm_pages() do the cleanup on error instead if you prefer that. > > > + > > + addr = read_atomic(&range[n].address); > > IIUC, range is part of the shared page with the guest. Where do you > check that all the access will be within the shared page? It's checked by the callers. > > > + gfn = gaddr_to_gfn(addr + m * PAGE_SIZE); > > Is addr meant to be page-aligned? Also, you are using the hypervisor > page size here when AFAICT page_count is provided by the domain. You're right, this is confusing. I'll define a FFA_PAGE_SIZE to SZ_4K and use that instead. Note that with FF-A a page is always 4K even if the smallest unit/granule may be larger (16kB or 64kB). > > How do you guarantee that both Xen and the domain agree on the page size? For now, I'll add a BUILD_BUG_ON() to check that the hypervisor page size is 4K to simplify the initial implementation. We can update to support a larger minimal memory granule later on. > > > + shm->pages[pg_idx] = get_page_from_gfn(d, gfn, &t, P2M_ALLOC); > > + if ( !shm->pages[pg_idx] ) > > + return FFA_RET_DENIED; > > + pg_idx++; > > + /* Only normal RAM for now */ > > Similar to my earlier remark, the comment doesn't match the check below. I'll fix. > > > + if ( t != p2m_ram_rw ) > > + return FFA_RET_DENIED; > > + } > > + } > > + > > + *last_page_idx = pg_idx; > > + > > + return FFA_RET_OK; > > +} > > + > > +static void put_shm_pages(struct ffa_shm_mem *shm) > > +{ > > + unsigned int n; > > + > > + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) > > + { > > + put_page(shm->pages[n]); > > + shm->pages[n] = NULL; > > + } > > +} > > + > > +static void init_range(struct ffa_address_range *addr_range, > > + paddr_t pa) > +{ > > + memset(addr_range, 0, sizeof(*addr_range)); > > + addr_range->address = pa; > > + addr_range->page_count = 1; > > +} > > + > > +static int share_shm(struct ffa_shm_mem *shm) > > AFAIU, share_shm() cannot be concurrently called. You seem to use > ffa_buffer_lock to guarantee that. So I would suggest to add: > 1) an ASSERT(spin_is_Locked(&ffa_buffer_lock)) > 2) a comment on top of share_shm() explaining that the function > should be called with ffa_buffer_lock taken. Yes, it's the ffa_tx buffer that must be protected against concurrent use. I'll update. > > > +{ > > + uint32_t max_frag_len = ffa_page_count * PAGE_SIZE; > > + struct ffa_mem_transaction_1_1 *descr = ffa_tx; > > + struct ffa_mem_access *mem_access_array; > > + struct ffa_mem_region *region_descr; > > + struct ffa_address_range *addr_range; > > + paddr_t pa; > > + paddr_t last_pa; > > + unsigned int n; > > + uint32_t frag_len; > > + uint32_t tot_len; > > + int ret; > > + unsigned int range_count; > > + unsigned int range_base; > > + bool first; > > + > > + memset(descr, 0, sizeof(*descr)); > > + descr->sender_id = shm->sender_id; > > + descr->global_handle = shm->handle; > > + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; > > + descr->mem_access_count = 1; > > + descr->mem_access_size = sizeof(*mem_access_array); > > + descr->mem_access_offs = sizeof(*descr); > > + mem_access_array = (void *)(descr + 1); > > + region_descr = (void *)(mem_access_array + 1); > > The (void *)(descr + 1) seems to be very common in your comment. Can you > consider to add a wrapper? This will make easier to read the code? OK, I'll try something different. > > > + > > + memset(mem_access_array, 0, sizeof(*mem_access_array)); > > + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; > > + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; > > + mem_access_array[0].region_offs = (vaddr_t)region_descr - (vaddr_t)ffa_tx; > > Same for calculating the offset. OK > > > + > > + memset(region_descr, 0, sizeof(*region_descr)); > > + region_descr->total_page_count = shm->page_count; > > + > > + region_descr->address_range_count = 1; > > + last_pa = page_to_maddr(shm->pages[0]); > For hardening purpose, I would suggest to check if shm->page_count is at > least 1. If you think this could be a programming error then you could > write: > > if ( .... ) > { > ASSERT_UNREACHABLE() > return ; > } OK > > > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > > + { > > + pa = page_to_maddr(shm->pages[n]); > > + if ( last_pa + PAGE_SIZE == pa ) > > + { > > Coding style: We usually avoid {} for single line. OK > > > + continue; > > + } > > + region_descr->address_range_count++; > > + } > > + > > + tot_len = sizeof(*descr) + sizeof(*mem_access_array) + > > + sizeof(*region_descr) + > > + region_descr->address_range_count * sizeof(*addr_range); > > How do you make sure that you will not write past the end of ffa_tx? > > I think it would be worth to consider adding an helper that would allow > you to allocate space in ffa_tx and zero it. This would return an error > if there is not enough space. That's what I'm doing with frag_len. If the descriptor cannot fit it's divided into fragments that will fit. > > > + > > + addr_range = region_descr->address_range_array; > > + frag_len = (vaddr_t)(addr_range + 1) - (vaddr_t)ffa_tx; > > + last_pa = page_to_maddr(shm->pages[0]); > > + init_range(addr_range, last_pa); > > + first = true; > > + range_count = 1; > > + range_base = 0; > > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > > + { > > + pa = page_to_maddr(shm->pages[n]); > > + if ( last_pa + PAGE_SIZE == pa ) > > + { > > + addr_range->page_count++; > > + continue; > > + } > > + > > + if ( frag_len == max_frag_len ) > > + { > > + if ( first ) > > + { > > + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > > + first = false; > > + } > > + else > > + { > > + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > > + } > > + if ( ret <= 0) > > Coding style: Missing space before ). > > > + return ret; > > + range_base = range_count; > > You set range_base but don't seem to read it > > > + range_count = 0; > > Same here. I'll remove them. > > > + frag_len = sizeof(*addr_range); > > + addr_range = ffa_tx; > > + } > > + else > > + { > > + frag_len += sizeof(*addr_range); > > + addr_range++; > > + } > > + init_range(addr_range, pa); > > + range_count++; > > + } > > + > > + if ( first ) > > + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > > + else > > + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > > +} > > + > > +static int read_mem_transaction(uint32_t ffa_vers, void *buf, size_t blen, > > buf should be const if it is not meant to be modified by the function. OK > > > + struct ffa_mem_transaction_x *trans) > > +{ > > + uint16_t mem_reg_attr; > > + uint32_t flags; > > + uint32_t count; > > + uint32_t offs; > > + uint32_t size; > > + > > + if ( ffa_vers >= FFA_VERSION_1_1 ) > > + { > > + struct ffa_mem_transaction_1_1 *descr; > > + > > + if ( blen < sizeof(*descr) ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + descr = buf; > > + trans->sender_id = read_atomic(&descr->sender_id); > AFAIU, descr point to guest data. If yes, then we can't trust input. In > which case, is this really necessary to use read_atomic() for every access? > > The reason I am asking is read_atomic() is quite a hammer when a > compiler barrier should be sufficient. I see, I'll use barrier() instead. > > > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > > + flags = read_atomic(&descr->flags); > > + trans->global_handle = read_atomic(&descr->global_handle); > > + trans->tag = read_atomic(&descr->tag); > > + > > + count = read_atomic(&descr->mem_access_count); > > + size = read_atomic(&descr->mem_access_size); > > + offs = read_atomic(&descr->mem_access_offs); > > + } > > + else > > + { > > + struct ffa_mem_transaction_1_0 *descr; > > + > > + if ( blen < sizeof(*descr) ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + descr = buf; > > + trans->sender_id = read_atomic(&descr->sender_id); > > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > > + flags = read_atomic(&descr->flags); > > + trans->global_handle = read_atomic(&descr->global_handle); > > + trans->tag = read_atomic(&descr->tag); > > + > > + count = read_atomic(&descr->mem_access_count); > > + size = sizeof(struct ffa_mem_access); > > + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); > > + } > > + > > + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || > > AFAIU, these checks are to ensure that the fields fit in your structure > below. However, it is not clear to me why we are capping the values > provided by the domain. > > I think this would be good to explain it in a comment. OK, I'll add something. > > > + count > UINT8_MAX || offs > UINT16_MAX ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + /* Check that the endpoint memory access descriptor array fits */ > > + if ( size * count + offs > blen ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + trans->mem_reg_attr = mem_reg_attr; > > + trans->flags = flags; > > + trans->mem_access_size = size; > > + trans->mem_access_count = count; > > + trans->mem_access_offs = offs; > > + return 0; > > +} > > + > > +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, > > + unsigned int frag_len) > > +{ > > + struct domain *d = current->domain; > > + unsigned int o = offs; > > + unsigned int l; > > + int ret; > > + > > + if ( frag_len < o ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + /* Fill up the first struct ffa_address_range */ > > + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); > > + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); > > + s->range_offset += l; > > + o += l; > > + if ( s->range_offset != sizeof(s->range) ) > > + goto out; > > + s->range_offset = 0; > > + > > + while ( true ) > > + { > > + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, > > + &s->current_page_idx); > > + if ( ret ) > > + return ret; > > + if ( s->range_count == 1 ) > > + return 0; > > + s->range_count--; > > + if ( frag_len - o < sizeof(s->range) ) > > + break; > > + memcpy(&s->range, s->buf + o, sizeof(s->range)); > > + o += sizeof(s->range); > > + } > > + > > + /* Collect any remaining bytes for the next struct ffa_address_range */ > > + s->range_offset = frag_len - o; > > + memcpy(&s->range, s->buf + o, frag_len - o); > > +out: > > + s->frag_offset += frag_len; > > + return s->frag_offset; > > +} > > + > > +static void handle_mem_share(struct cpu_user_regs *regs) > > +{ > > + uint32_t tot_len = get_user_reg(regs, 1); > > + uint32_t frag_len = get_user_reg(regs, 2); > > + uint64_t addr = get_user_reg(regs, 3); > > + uint32_t page_count = get_user_reg(regs, 4); > > + struct ffa_mem_transaction_x trans; > > + struct ffa_mem_access *mem_access; > > + struct ffa_mem_region *region_descr; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + struct ffa_shm_mem *shm = NULL; > > + unsigned int last_page_idx = 0; > > + uint32_t range_count; > > + uint32_t region_offs; > > + int ret = FFA_RET_DENIED; > > + uint32_t handle_hi = 0; > > + uint32_t handle_lo = 0; > > + > > + /* > > + * We're only accepting memory transaction descriptors via the rx/tx > > + * buffer. > > + */ > > + if ( addr ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + /* Check that fragment legnth doesn't exceed total length */ > > Typo: s/legnth/length/ > > > + if ( frag_len > tot_len ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out_unlock; > > + } > > + > > + spin_lock(&ctx->lock); > > + > > + if ( frag_len > ctx->page_count * PAGE_SIZE ) > > + goto out_unlock; > > + > > + if ( !ffa_page_count ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out_unlock; > > + } > > + > > + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); > > + if ( ret ) > > + goto out_unlock; > > + > > + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out; > > + } > > + > > + /* Only supports sharing it with one SP for now */ > > + if ( trans.mem_access_count != 1 ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + if ( trans.sender_id != get_vm_id(d) ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out_unlock; > > + } > > + > > + /* Check that it fits in the supplied data */ > > + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) > > + goto out_unlock; > > + > > + mem_access = (void *)((vaddr_t)ctx->tx + trans.mem_access_offs); > > There are a bit too much open-cast in this series. Please try to reduce > the numbers. OK > > In this case, the two casts are unnecessary because tx is already a void > pointer. Thanks, I didn't realize that void pointer arithmetics was allowed here. > > In addition to that, ctx->tx could be a "const void *" because it is not > meant to be written by Xen. The const would also needs to be propagated > to mem_access & co. OK > > > + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + region_offs = read_atomic(&mem_access->region_offs); > > + if ( sizeof(*region_descr) + region_offs > frag_len ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + region_descr = (void *)((vaddr_t)ctx->tx + region_offs); > > + range_count = read_atomic(®ion_descr->address_range_count); > > + page_count = read_atomic(®ion_descr->total_page_count); > > + > > + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count) > This will allow a guest to allocate an arbitrarily large array in Xen. > So please sanitize page_count before using it. This is tricky, what is a reasonable limit? If we do set a limit the guest can still share many separate memory ranges. > > > + if ( !shm ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out; > > + } > > + shm->sender_id = trans.sender_id; > > + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); > > + shm->page_count = page_count; > > + > > + if ( frag_len != tot_len ) > > + { > > + struct mem_frag_state *s = xzalloc(struct mem_frag_state); > > + > > + if ( !s ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out; > > + } > > + s->shm = shm; > > + s->range_count = range_count; > > + s->buf = ctx->tx; > > + s->buf_size = ffa_page_count * PAGE_SIZE; > > + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, > > + frag_len); > > + if ( ret <= 0 ) > > + { > > + xfree(s); > > + if ( ret < 0 ) > > + goto out; > > + } > > + else > > + { > > + shm->handle = next_handle++; > > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > > + list_add_tail(&s->list, &ctx->frag_list); > > + } > > + goto out_unlock; > > + } > > + > > + /* > > + * Check that the Composite memory region descriptor fits. > > + */ > > + if ( sizeof(*region_descr) + region_offs + > > + range_count * sizeof(struct ffa_address_range) > frag_len ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, > > + 0, &last_page_idx); > > + if ( ret ) > > + goto out; > > + if ( last_page_idx != shm->page_count ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + /* Note that share_shm() uses our tx buffer */ > > + spin_lock(&ffa_buffer_lock); > > + ret = share_shm(shm); > > + spin_unlock(&ffa_buffer_lock); > > + if ( ret ) > > + goto out; > > + > > + spin_lock(&ffa_mem_list_lock); > > + list_add_tail(&shm->list, &ffa_mem_list); > > A couple of questions: > - What is the maximum size of the list? Currently, there is no limit. I'm not sure what is a reasonable limit more than five for sure, but depending on the use case more than 100 might be excessive. > - Why is the list is global rather than per domain? In fact, looking > at handle_mem_reclaim() it looks like a domain could potentially reclaim > in memory (we don't seem to sanitize the input other than checking the > handle is used). So it seems to me the list should be per-domain. OK, I'll move it into struct ffa_ctx. > > > + spin_unlock(&ffa_mem_list_lock); > + > > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > > + > > +out: > > + if ( ret && shm ) > > + { > > + put_shm_pages(shm); > > + xfree(shm); > > + } > > +out_unlock: > > + spin_unlock(&ctx->lock); > > + > > + if ( ret > 0 ) > > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); > > + else if ( ret == 0) > > Coding style: missing space before ). OK > > > + set_regs_success(regs, handle_lo, handle_hi); > > + else > > + set_regs_error(regs, ret); > > +} > > + > > I will continue the review later on. Thanks for the comments so far. Cheers, Jens From xen-devel-bounces@lists.xenproject.org Wed Jul 27 06:53:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 06:53:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375921.608402 (Exim 4.92) (envelope-from ) id 1oGav7-000539-SL; Wed, 27 Jul 2022 06:53:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375921.608402; Wed, 27 Jul 2022 06:53:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGav7-000532-PT; Wed, 27 Jul 2022 06:53:25 +0000 Received: by outflank-mailman (input) for mailman id 375921; Wed, 27 Jul 2022 06:53:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGav5-00052w-PT for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 06:53:24 +0000 Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [2607:f8b0:4864:20::52b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cc02e944-0d78-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 08:53:19 +0200 (CEST) Received: by mail-pg1-x52b.google.com with SMTP id h132so15149909pgc.10 for ; Tue, 26 Jul 2022 23:53:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cc02e944-0d78-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=txeBvpRYndVIAGQRHJPi4zzoJCMmBPS2I42xMV3xNg4=; b=J2OrxZGh5TlAeN/3R9+sKkG4PoYZOEXCRa8dZui0QbDoFyNFfuNM9HPwo4vwPcFN8O Ynd6kGKFqHItAKgNPxkQMRQa+i/0bn5ycwUQ78STNc1VpuqP28d7+y5167BuV35H/FHv thZ6Mawlxbj11Q19GpEspcgcUnXsHXsE3lWeDzO+eiq2DYR82ubh2hp5HExJAdQIIwaC hd8epCIF+CkESvgITuWVwVeXCm4ap+xGddug5BLDml1o1XGACkk8YjkgJtoyPT4CFG/a km3+1YqMG1b+KZCF9ME00TqM/CNs0PPJBOV0Lku/CapPSgaXVgeF7lMSnuty75dYCStu k21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=txeBvpRYndVIAGQRHJPi4zzoJCMmBPS2I42xMV3xNg4=; b=Nw0028SOr8nUqplts784KVKTZzzxGvCxbYCf1YaGnZeMEjyuuJYmfSKsgPZat261MR E5+sWnjg/90TNPQq1SZj0wJcy8qwqn3l7viURSutze2mW7MVNToC0Fkyt8k4AXbLTbTq ScZgcWBS/7g40Y36WxxJcHJSxsz/jwX5GuBwFiGMNjHI3q1sbhzN1P87fogmMfY3y7k+ qGZIU4fLu5WnrY967jRBP44YBJmzUP5biBmPDi+rZ6TkkyZZXaB1aOMJBPwoS9z3JkqH WauEgH/5rWFLUUxEqU7F5M9EpMx0gRaUl4b6FSlICfkSQtLI9qQOycM8uV4DFsP7IUZv Ua3A== X-Gm-Message-State: AJIora+SYS8Bt+A3yjPLOwC9kGyGn7W/Ma6cz/Uts0Lk34by/QVjtLMt bw0rbXTT4wHpZJurD82mepNu35bJaepbJNPxshEBdg== X-Google-Smtp-Source: AGRyM1sZaxgMvQCoJ745oTSUqAITjfq5yQ9JhRJrE06lLJIhWu2TV6h6Vypslfa15U8d+tmvSFMSVucQX5SfBzqI0tI= X-Received: by 2002:a63:e102:0:b0:41b:3901:990e with SMTP id z2-20020a63e102000000b0041b3901990emr3389084pgh.107.1658904797840; Tue, 26 Jul 2022 23:53:17 -0700 (PDT) MIME-Version: 1.0 References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> <2E5B1159-9569-40D9-9BA1-92022378B9C6@arm.com> In-Reply-To: <2E5B1159-9569-40D9-9BA1-92022378B9C6@arm.com> From: Jens Wiklander Date: Wed, 27 Jul 2022 08:53:06 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Bertrand Marquis Cc: Xen-devel , Stefano Stabellini , Julien Grall , Volodymyr Babchuk Content-Type: text/plain; charset="UTF-8" Hi Bertrand, On Thu, Jul 14, 2022 at 11:51 AM Bertrand Marquis wrote: > > Hi Jens, > > > On 22 Jun 2022, at 14:42, Jens Wiklander wrote: > > > > Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > > Partition in secure world. > > > > The implementation is the bare minimum to be able to communicate with > > OP-TEE running as an SPMC at S-EL1. > > > > This is loosely based on the TEE mediator framework and the OP-TEE > > mediator. > > > > [1] https://developer.arm.com/documentation/den0077/latest > > Signed-off-by: Jens Wiklander > > I spent quite some time on this patch and on the spec and there are far to > much code and concepts introduced here to be able to do a review in one go. > > Could you try to split the patch to introduce each concept in a specific patch ? > I would suggest something like introducing each call in its own patch, having > a specific patch for the tool support, etc. > > At this stage I am not convinced that there is no issue here where a guest could > access information from an other guest and reviewing smaller patches will help > me following the spec for each subject and ask questions along the way. OK, I'll try to split it up a bit in the next version. Cheers, Jens > > Cheers > Bertrand > > > --- > > SUPPORT.md | 7 + > > tools/libs/light/libxl_arm.c | 3 + > > tools/libs/light/libxl_types.idl | 1 + > > tools/xl/xl_parse.c | 3 + > > xen/arch/arm/Kconfig | 11 + > > xen/arch/arm/Makefile | 1 + > > xen/arch/arm/domain.c | 10 + > > xen/arch/arm/domain_build.c | 1 + > > xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > > xen/arch/arm/include/asm/domain.h | 4 + > > xen/arch/arm/include/asm/ffa.h | 71 ++ > > xen/arch/arm/vsmc.c | 17 +- > > xen/include/public/arch-arm.h | 2 + > > 13 files changed, 1811 insertions(+), 3 deletions(-) > > create mode 100644 xen/arch/arm/ffa.c > > create mode 100644 xen/arch/arm/include/asm/ffa.h > > > > diff --git a/SUPPORT.md b/SUPPORT.md > > index 70e98964cbc0..215bb3c9043b 100644 > > --- a/SUPPORT.md > > +++ b/SUPPORT.md > > @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > > > > No support for QEMU backends in a 16K or 64K domain. > > > > +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > > + > > + Status, Arm64: Tech Preview > > + > > +There are still some code paths where a vCPU may hog a pCPU longer than > > +necessary. The FF-A mediator is not yet implemented for Arm32. > > + > > ### ARM: Guest Device Tree support > > > > Status: Supported > > diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > > index eef1de093914..a985609861c7 100644 > > --- a/tools/libs/light/libxl_arm.c > > +++ b/tools/libs/light/libxl_arm.c > > @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > > return ERROR_FAIL; > > } > > > > + config->arch.ffa_enabled = > > + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > > + > > return 0; > > } > > > > diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > > index 2a42da2f7d78..bf4544bef399 100644 > > --- a/tools/libs/light/libxl_types.idl > > +++ b/tools/libs/light/libxl_types.idl > > @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > > > > ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > > ("vuart", libxl_vuart_type), > > + ("ffa_enabled", libxl_defbool), > > ])), > > ("arch_x86", Struct(None, [("msr_relaxed", libxl_defbool), > > ])), > > diff --git a/tools/xl/xl_parse.c b/tools/xl/xl_parse.c > > index b98c0de378b6..e0e99ed8d2b1 100644 > > --- a/tools/xl/xl_parse.c > > +++ b/tools/xl/xl_parse.c > > @@ -2746,6 +2746,9 @@ skip_usbdev: > > exit(-ERROR_FAIL); > > } > > } > > + libxl_defbool_setdefault(&b_info->arch_arm.ffa_enabled, false); > > + xlu_cfg_get_defbool(config, "ffa_enabled", > > + &b_info->arch_arm.ffa_enabled, 0); > > > > parse_vkb_list(config, d_config); > > > > diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig > > index be9eff014120..e57e1d3757e2 100644 > > --- a/xen/arch/arm/Kconfig > > +++ b/xen/arch/arm/Kconfig > > @@ -139,6 +139,17 @@ config TEE > > > > source "arch/arm/tee/Kconfig" > > > > +config FFA > > + bool "Enable FF-A mediator support" if EXPERT > > + default n > > + depends on ARM_64 > > + help > > + This option enables a minimal FF-A mediator. The mediator is > > + generic as it follows the FF-A specification [1], but it only > > + implements a small subset of the specification. > > + > > + [1] https://developer.arm.com/documentation/den0077/latest > > + > > endmenu > > > > menu "ARM errata workaround via the alternative framework" > > diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile > > index bb7a6151c13c..af0c69f793d4 100644 > > --- a/xen/arch/arm/Makefile > > +++ b/xen/arch/arm/Makefile > > @@ -20,6 +20,7 @@ obj-y += domain_build.init.o > > obj-y += domctl.o > > obj-$(CONFIG_EARLY_PRINTK) += early_printk.o > > obj-y += efi/ > > +obj-$(CONFIG_FFA) += ffa.o > > obj-y += gic.o > > obj-y += gic-v2.o > > obj-$(CONFIG_GICV3) += gic-v3.o > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > > index 8110c1df8638..a3f00e7e234d 100644 > > --- a/xen/arch/arm/domain.c > > +++ b/xen/arch/arm/domain.c > > @@ -27,6 +27,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -756,6 +757,9 @@ int arch_domain_create(struct domain *d, > > if ( (rc = tee_domain_init(d, config->arch.tee_type)) != 0 ) > > goto fail; > > > > + if ( (rc = ffa_domain_init(d, config->arch.ffa_enabled)) != 0 ) > > + goto fail; > > + > > update_domain_wallclock_time(d); > > > > /* > > @@ -998,6 +1002,7 @@ static int relinquish_memory(struct domain *d, struct page_list_head *list) > > enum { > > PROG_pci = 1, > > PROG_tee, > > + PROG_ffa, > > PROG_xen, > > PROG_page, > > PROG_mapping, > > @@ -1043,6 +1048,11 @@ int domain_relinquish_resources(struct domain *d) > > > > PROGRESS(tee): > > ret = tee_relinquish_resources(d); > > + if ( ret ) > > + return ret; > > + > > + PROGRESS(ffa): > > + ret = ffa_relinquish_resources(d); > > if (ret ) > > return ret; > > > > diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c > > index 7ddd16c26da5..d708f76356f7 100644 > > --- a/xen/arch/arm/domain_build.c > > +++ b/xen/arch/arm/domain_build.c > > @@ -3450,6 +3450,7 @@ void __init create_dom0(void) > > if ( gic_number_lines() > 992 ) > > printk(XENLOG_WARNING "Maximum number of vGIC IRQs exceeded.\n"); > > dom0_cfg.arch.tee_type = tee_get_type(); > > + dom0_cfg.arch.ffa_enabled = true; > > dom0_cfg.max_vcpus = dom0_max_vcpus(); > > > > if ( iommu_enabled ) > > diff --git a/xen/arch/arm/ffa.c b/xen/arch/arm/ffa.c > > new file mode 100644 > > index 000000000000..3117ce5cec4d > > --- /dev/null > > +++ b/xen/arch/arm/ffa.c > > @@ -0,0 +1,1683 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A (FF-A) mediator > > + * > > + * Copyright (C) 2022 Linaro Limited > > + * > > + * Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without restriction, > > + * including without limitation the rights to use, copy, modify, merge, > > + * publish, distribute, sublicense, and/or sell copies of the Software, > > + * and to permit persons to whom the Software is furnished to do so, > > + * subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include > > +#include > > +#include > > +#include > > + > > +/* Error codes */ > > +#define FFA_RET_OK 0 > > +#define FFA_RET_NOT_SUPPORTED -1 > > +#define FFA_RET_INVALID_PARAMETERS -2 > > +#define FFA_RET_NO_MEMORY -3 > > +#define FFA_RET_BUSY -4 > > +#define FFA_RET_INTERRUPTED -5 > > +#define FFA_RET_DENIED -6 > > +#define FFA_RET_RETRY -7 > > +#define FFA_RET_ABORTED -8 > > + > > +/* FFA_VERSION helpers */ > > +#define FFA_VERSION_MAJOR _AC(1,U) > > +#define FFA_VERSION_MAJOR_SHIFT _AC(16,U) > > +#define FFA_VERSION_MAJOR_MASK _AC(0x7FFF,U) > > +#define FFA_VERSION_MINOR _AC(1,U) > > +#define FFA_VERSION_MINOR_SHIFT _AC(0,U) > > +#define FFA_VERSION_MINOR_MASK _AC(0xFFFF,U) > > +#define MAKE_FFA_VERSION(major, minor) \ > > + ((((major) & FFA_VERSION_MAJOR_MASK) << FFA_VERSION_MAJOR_SHIFT) | \ > > + ((minor) & FFA_VERSION_MINOR_MASK)) > > + > > +#define FFA_MIN_VERSION MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_0 MAKE_FFA_VERSION(1, 0) > > +#define FFA_VERSION_1_1 MAKE_FFA_VERSION(1, 1) > > +#define FFA_MY_VERSION MAKE_FFA_VERSION(FFA_VERSION_MAJOR, \ > > + FFA_VERSION_MINOR) > > + > > + > > +#define FFA_HANDLE_HYP_FLAG BIT(63,ULL) > > + > > +/* Memory attributes: Normal memory, Write-Back cacheable, Inner shareable */ > > +#define FFA_NORMAL_MEM_REG_ATTR _AC(0x2f,U) > > + > > +/* Memory access permissions: Read-write */ > > +#define FFA_MEM_ACC_RW _AC(0x2,U) > > + > > +/* Clear memory before mapping in receiver */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR BIT(0, U) > > +/* Relayer may time slice this operation */ > > +#define FFA_MEMORY_REGION_FLAG_TIME_SLICE BIT(1, U) > > +/* Clear memory after receiver relinquishes it */ > > +#define FFA_MEMORY_REGION_FLAG_CLEAR_RELINQUISH BIT(2, U) > > + > > +/* Share memory transaction */ > > +#define FFA_MEMORY_REGION_TRANSACTION_TYPE_SHARE (_AC(1,U) << 3) > > + > > +#define FFA_HANDLE_INVALID _AC(0xffffffffffffffff,ULL) > > + > > +/* Framework direct request/response */ > > +#define FFA_MSG_FLAG_FRAMEWORK BIT(31, U) > > +#define FFA_MSG_TYPE_MASK _AC(0xFF,U); > > +#define FFA_MSG_PSCI _AC(0x0,U) > > +#define FFA_MSG_SEND_VM_CREATED _AC(0x4,U) > > +#define FFA_MSG_RESP_VM_CREATED _AC(0x5,U) > > +#define FFA_MSG_SEND_VM_DESTROYED _AC(0x6,U) > > +#define FFA_MSG_RESP_VM_DESTROYED _AC(0x7,U) > > + > > +/* > > + * Flags used for the FFA_PARTITION_INFO_GET return message: > > + * BIT(0): Supports receipt of direct requests > > + * BIT(1): Can send direct requests > > + * BIT(2): Can send and receive indirect messages > > + * BIT(3): Supports receipt of notifications > > + * BIT(4-5): Partition ID is a PE endpoint ID > > + */ > > +#define FFA_PART_PROP_DIRECT_REQ_RECV BIT(0,U) > > +#define FFA_PART_PROP_DIRECT_REQ_SEND BIT(1,U) > > +#define FFA_PART_PROP_INDIRECT_MSGS BIT(2,U) > > +#define FFA_PART_PROP_RECV_NOTIF BIT(3,U) > > +#define FFA_PART_PROP_IS_PE_ID (_AC(0,U) << 4) > > +#define FFA_PART_PROP_IS_SEPID_INDEP (_AC(1,U) << 4) > > +#define FFA_PART_PROP_IS_SEPID_DEP (_AC(2,U) << 4) > > +#define FFA_PART_PROP_IS_AUX_ID (_AC(3,U) << 4) > > +#define FFA_PART_PROP_NOTIF_CREATED BIT(6,U) > > +#define FFA_PART_PROP_NOTIF_DESTROYED BIT(7,U) > > +#define FFA_PART_PROP_AARCH64_STATE BIT(8,U) > > + > > +/* Function IDs */ > > +#define FFA_ERROR _AC(0x84000060,U) > > +#define FFA_SUCCESS_32 _AC(0x84000061,U) > > +#define FFA_SUCCESS_64 _AC(0xC4000061,U) > > +#define FFA_INTERRUPT _AC(0x84000062,U) > > +#define FFA_VERSION _AC(0x84000063,U) > > +#define FFA_FEATURES _AC(0x84000064,U) > > +#define FFA_RX_ACQUIRE _AC(0x84000084,U) > > +#define FFA_RX_RELEASE _AC(0x84000065,U) > > +#define FFA_RXTX_MAP_32 _AC(0x84000066,U) > > +#define FFA_RXTX_MAP_64 _AC(0xC4000066,U) > > +#define FFA_RXTX_UNMAP _AC(0x84000067,U) > > +#define FFA_PARTITION_INFO_GET _AC(0x84000068,U) > > +#define FFA_ID_GET _AC(0x84000069,U) > > +#define FFA_SPM_ID_GET _AC(0x84000085,U) > > +#define FFA_MSG_WAIT _AC(0x8400006B,U) > > +#define FFA_MSG_YIELD _AC(0x8400006C,U) > > +#define FFA_MSG_RUN _AC(0x8400006D,U) > > +#define FFA_MSG_SEND2 _AC(0x84000086,U) > > +#define FFA_MSG_SEND_DIRECT_REQ_32 _AC(0x8400006F,U) > > +#define FFA_MSG_SEND_DIRECT_REQ_64 _AC(0xC400006F,U) > > +#define FFA_MSG_SEND_DIRECT_RESP_32 _AC(0x84000070,U) > > +#define FFA_MSG_SEND_DIRECT_RESP_64 _AC(0xC4000070,U) > > +#define FFA_MEM_DONATE_32 _AC(0x84000071,U) > > +#define FFA_MEM_DONATE_64 _AC(0xC4000071,U) > > +#define FFA_MEM_LEND_32 _AC(0x84000072,U) > > +#define FFA_MEM_LEND_64 _AC(0xC4000072,U) > > +#define FFA_MEM_SHARE_32 _AC(0x84000073,U) > > +#define FFA_MEM_SHARE_64 _AC(0xC4000073,U) > > +#define FFA_MEM_RETRIEVE_REQ_32 _AC(0x84000074,U) > > +#define FFA_MEM_RETRIEVE_REQ_64 _AC(0xC4000074,U) > > +#define FFA_MEM_RETRIEVE_RESP _AC(0x84000075,U) > > +#define FFA_MEM_RELINQUISH _AC(0x84000076,U) > > +#define FFA_MEM_RECLAIM _AC(0x84000077,U) > > +#define FFA_MEM_FRAG_RX _AC(0x8400007A,U) > > +#define FFA_MEM_FRAG_TX _AC(0x8400007B,U) > > +#define FFA_MSG_SEND _AC(0x8400006E,U) > > +#define FFA_MSG_POLL _AC(0x8400006A,U) > > + > > +/* Partition information descriptor */ > > +struct ffa_partition_info_1_0 { > > + uint16_t id; > > + uint16_t execution_context; > > + uint32_t partition_properties; > > +}; > > + > > +struct ffa_partition_info_1_1 { > > + uint16_t id; > > + uint16_t execution_context; > > + uint32_t partition_properties; > > + uint8_t uuid[16]; > > +}; > > + > > +/* Constituent memory region descriptor */ > > +struct ffa_address_range { > > + uint64_t address; > > + uint32_t page_count; > > + uint32_t reserved; > > +}; > > + > > +/* Composite memory region descriptor */ > > +struct ffa_mem_region { > > + uint32_t total_page_count; > > + uint32_t address_range_count; > > + uint64_t reserved; > > + struct ffa_address_range address_range_array[]; > > +}; > > + > > +/* Memory access permissions descriptor */ > > +struct ffa_mem_access_perm { > > + uint16_t endpoint_id; > > + uint8_t perm; > > + uint8_t flags; > > +}; > > + > > +/* Endpoint memory access descriptor */ > > +struct ffa_mem_access { > > + struct ffa_mem_access_perm access_perm; > > + uint32_t region_offs; > > + uint64_t reserved; > > +}; > > + > > +/* Lend, donate or share memory transaction descriptor */ > > +struct ffa_mem_transaction_1_0 { > > + uint16_t sender_id; > > + uint8_t mem_reg_attr; > > + uint8_t reserved0; > > + uint32_t flags; > > + uint64_t global_handle; > > + uint64_t tag; > > + uint32_t reserved1; > > + uint32_t mem_access_count; > > + struct ffa_mem_access mem_access_array[]; > > +}; > > + > > +struct ffa_mem_transaction_1_1 { > > + uint16_t sender_id; > > + uint16_t mem_reg_attr; > > + uint32_t flags; > > + uint64_t global_handle; > > + uint64_t tag; > > + uint32_t mem_access_size; > > + uint32_t mem_access_count; > > + uint32_t mem_access_offs; > > + uint8_t reserved[12]; > > +}; > > + > > +/* > > + * The parts needed from struct ffa_mem_transaction_1_0 or struct > > + * ffa_mem_transaction_1_1, used to provide an abstraction of difference in > > + * data structures between version 1.0 and 1.1. This is just an internal > > + * interface and can be changed without changing any ABI. > > + */ > > +struct ffa_mem_transaction_x { > > + uint16_t sender_id; > > + uint8_t mem_reg_attr; > > + uint8_t flags; > > + uint8_t mem_access_size; > > + uint8_t mem_access_count; > > + uint16_t mem_access_offs; > > + uint64_t global_handle; > > + uint64_t tag; > > +}; > > + > > +/* Endpoint RX/TX descriptor */ > > +struct ffa_endpoint_rxtx_descriptor_1_0 { > > + uint16_t sender_id; > > + uint16_t reserved; > > + uint32_t rx_range_count; > > + uint32_t tx_range_count; > > +}; > > + > > +struct ffa_endpoint_rxtx_descriptor_1_1 { > > + uint16_t sender_id; > > + uint16_t reserved; > > + uint32_t rx_region_offs; > > + uint32_t tx_region_offs; > > +}; > > + > > +struct ffa_ctx { > > + void *rx; > > + void *tx; > > + struct page_info *rx_pg; > > + struct page_info *tx_pg; > > + unsigned int page_count; > > + uint32_t guest_vers; > > + bool tx_is_mine; > > + bool interrupted; > > + struct list_head frag_list; > > + spinlock_t lock; > > +}; > > + > > +struct ffa_shm_mem { > > + struct list_head list; > > + uint16_t sender_id; > > + uint16_t ep_id; /* endpoint, the one lending */ > > + uint64_t handle; /* FFA_HANDLE_INVALID if not set yet */ > > + unsigned int page_count; > > + struct page_info *pages[]; > > +}; > > + > > +struct mem_frag_state { > > + struct list_head list; > > + struct ffa_shm_mem *shm; > > + uint32_t range_count; > > + unsigned int current_page_idx; > > + unsigned int frag_offset; > > + unsigned int range_offset; > > + uint8_t *buf; > > + unsigned int buf_size; > > + struct ffa_address_range range; > > +}; > > + > > +/* > > + * Our rx/rx buffer shared with the SPMC > > + */ > > +static uint32_t ffa_version; > > +static uint16_t *subsr_vm_created; > > +static unsigned int subsr_vm_created_count; > > +static uint16_t *subsr_vm_destroyed; > > +static unsigned int subsr_vm_destroyed_count; > > +static void *ffa_rx; > > +static void *ffa_tx; > > +static unsigned int ffa_page_count; > > +static DEFINE_SPINLOCK(ffa_buffer_lock); > > + > > +static LIST_HEAD(ffa_mem_list); > > +static DEFINE_SPINLOCK(ffa_mem_list_lock); > > + > > +static uint64_t next_handle = FFA_HANDLE_HYP_FLAG; > > + > > +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > > +{ > > + return (uint64_t)reg0 << 32 | reg1; > > +} > > + > > +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > > + uint64_t val) > > +{ > > + *reg0 = val >> 32; > > + *reg1 = val; > > +} > > + > > +static bool ffa_get_version(uint32_t *vers) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_VERSION, .a1 = FFA_MY_VERSION, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 == FFA_RET_NOT_SUPPORTED ) > > + { > > + printk(XENLOG_ERR "ffa: FFA_VERSION returned not supported\n"); > > + return false; > > + } > > + > > + *vers = resp.a0; > > + return true; > > +} > > + > > +static uint32_t get_ffa_ret_code(const struct arm_smccc_1_2_regs *resp) > > +{ > > + switch ( resp->a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp->a2 ) > > + return resp->a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + return FFA_RET_OK; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_features(uint32_t id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_FEATURES, .a1 = id, }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static bool check_mandatory_feature(uint32_t id) > > +{ > > + uint32_t ret = ffa_features(id); > > + > > + if (ret) > > + printk(XENLOG_ERR "ffa: mandatory feature id %#x missing\n", id); > > + return !ret; > > +} > > + > > +static uint32_t ffa_rxtx_map(register_t tx_addr, register_t rx_addr, > > + uint32_t page_count) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > +#ifdef CONFIG_ARM_64 > > + .a0 = FFA_RXTX_MAP_64, > > +#endif > > +#ifdef CONFIG_ARM_32 > > + .a0 = FFA_RXTX_MAP_32, > > +#endif > > + .a1 = tx_addr, .a2 = rx_addr, > > + .a3 = page_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_rxtx_unmap(uint16_t vm_id) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_RXTX_UNMAP, .a1 = vm_id, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static uint32_t ffa_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_PARTITION_INFO_GET, .a1 = w1, .a2 = w2, .a3 = w3, .a4 = w4, > > + .a5 = w5, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + uint32_t ret; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + ret = get_ffa_ret_code(&resp); > > + if ( !ret ) > > + *count = resp.a2; > > + > > + return ret; > > +} > > + > > +static uint32_t ffa_rx_release(void) > > +{ > > + const struct arm_smccc_1_2_regs arg = { .a0 = FFA_RX_RELEASE, }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_mem_share(uint32_t tot_len, uint32_t frag_len, > > + register_t addr, uint32_t pg_count, > > + uint64_t *handle) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_SHARE_32, .a1 = tot_len, .a2 = frag_len, .a3 = addr, > > + .a4 = pg_count, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + /* > > + * For arm64 we must use 64-bit calling convention if the buffer isn't > > + * passed in our tx buffer. > > + */ > > + if (sizeof(addr) > 4 && addr) > > + arg.a0 = FFA_MEM_SHARE_64; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + *handle = reg_pair_to_64(resp.a3, resp.a2); > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + *handle = reg_pair_to_64(resp.a2, resp.a1); > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static int32_t ffa_mem_frag_tx(uint64_t handle, uint32_t frag_len, > > + uint16_t sender_id) > > +{ > > + struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_FRAG_TX, .a1 = handle & UINT32_MAX, .a2 = handle >> 32, > > + .a3 = frag_len, .a4 = (uint32_t)sender_id << 16, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_ERROR: > > + if ( resp.a2 ) > > + return resp.a2; > > + else > > + return FFA_RET_NOT_SUPPORTED; > > + case FFA_SUCCESS_32: > > + return FFA_RET_OK; > > + case FFA_MEM_FRAG_RX: > > + return resp.a3; > > + default: > > + return FFA_RET_NOT_SUPPORTED; > > + } > > +} > > + > > +static uint32_t ffa_mem_reclaim(uint32_t handle_lo, uint32_t handle_hi, > > + uint32_t flags) > > +{ > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MEM_RECLAIM, .a1 = handle_lo, .a2 = handle_hi, .a3 = flags, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + return get_ffa_ret_code(&resp); > > +} > > + > > +static int32_t ffa_direct_req_send_vm(uint16_t sp_id, uint16_t vm_id, > > + uint8_t msg) > > +{ > > + uint32_t exp_resp = FFA_MSG_FLAG_FRAMEWORK; > > + int32_t res; > > + > > + if ( msg != FFA_MSG_SEND_VM_CREATED && msg !=FFA_MSG_SEND_VM_DESTROYED ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + if ( msg == FFA_MSG_SEND_VM_CREATED ) > > + exp_resp |= FFA_MSG_RESP_VM_CREATED; > > + else > > + exp_resp |= FFA_MSG_RESP_VM_DESTROYED; > > + > > + do { > > + const struct arm_smccc_1_2_regs arg = { > > + .a0 = FFA_MSG_SEND_DIRECT_REQ_32, > > + .a1 = sp_id, > > + .a2 = FFA_MSG_FLAG_FRAMEWORK | msg, > > + .a5 = vm_id, > > + }; > > + struct arm_smccc_1_2_regs resp; > > + > > + arm_smccc_1_2_smc(&arg, &resp); > > + if ( resp.a0 != FFA_MSG_SEND_DIRECT_RESP_32 || resp.a2 != exp_resp ) > > + { > > + /* > > + * This is an invalid response, likely due to some error in the > > + * implementation of the ABI. > > + */ > > + return FFA_RET_INVALID_PARAMETERS; > > + } > > + res = resp.a3; > > + } while ( res == FFA_RET_INTERRUPTED || res == FFA_RET_RETRY ); > > + > > + return res; > > +} > > + > > +static u16 get_vm_id(struct domain *d) > > +{ > > + /* +1 since 0 is reserved for the hypervisor in FF-A */ > > + return d->domain_id + 1; > > +} > > + > > +static void set_regs(struct cpu_user_regs *regs, register_t v0, register_t v1, > > + register_t v2, register_t v3, register_t v4, register_t v5, > > + register_t v6, register_t v7) > > +{ > > + set_user_reg(regs, 0, v0); > > + set_user_reg(regs, 1, v1); > > + set_user_reg(regs, 2, v2); > > + set_user_reg(regs, 3, v3); > > + set_user_reg(regs, 4, v4); > > + set_user_reg(regs, 5, v5); > > + set_user_reg(regs, 6, v6); > > + set_user_reg(regs, 7, v7); > > +} > > + > > +static void set_regs_error(struct cpu_user_regs *regs, uint32_t error_code) > > +{ > > + set_regs(regs, FFA_ERROR, 0, error_code, 0, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_success(struct cpu_user_regs *regs, uint32_t w2, > > + uint32_t w3) > > +{ > > + set_regs(regs, FFA_SUCCESS_32, 0, w2, w3, 0, 0, 0, 0); > > +} > > + > > +static void set_regs_frag_rx(struct cpu_user_regs *regs, uint32_t handle_lo, > > + uint32_t handle_hi, uint32_t frag_offset, > > + uint16_t sender_id) > > +{ > > + set_regs(regs, FFA_MEM_FRAG_RX, handle_lo, handle_hi, frag_offset, > > + (uint32_t)sender_id << 16, 0, 0, 0); > > +} > > + > > +static void handle_version(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t vers = get_user_reg(regs, 1); > > + > > + if ( vers < FFA_VERSION_1_1 ) > > + vers = FFA_VERSION_1_0; > > + else > > + vers = FFA_VERSION_1_1; > > + > > + ctx->guest_vers = vers; > > + set_regs(regs, vers, 0, 0, 0, 0, 0, 0, 0); > > +} > > + > > +static uint32_t handle_rxtx_map(uint32_t fid, register_t tx_addr, > > + register_t rx_addr, uint32_t page_count) > > +{ > > + uint32_t ret = FFA_RET_INVALID_PARAMETERS; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + struct page_info *tx_pg; > > + struct page_info *rx_pg; > > + p2m_type_t t; > > + void *rx; > > + void *tx; > > + > > + if ( !smccc_is_conv_64(fid) ) > > + { > > + tx_addr &= UINT32_MAX; > > + rx_addr &= UINT32_MAX; > > + } > > + > > + /* For now to keep things simple, only deal with a single page */ > > + if ( page_count != 1 ) > > + return FFA_RET_NOT_SUPPORTED; > > + > > + /* Already mapped */ > > + if ( ctx->rx ) > > + return FFA_RET_DENIED; > > + > > + tx_pg = get_page_from_gfn(d, gaddr_to_gfn(tx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + return FFA_RET_INVALID_PARAMETERS; > > + /* Only normal RAM for now */ > > + if (t != p2m_ram_rw) > > + goto err_put_tx_pg; > > + > > + rx_pg = get_page_from_gfn(d, gaddr_to_gfn(rx_addr), &t, P2M_ALLOC); > > + if ( !tx_pg ) > > + goto err_put_tx_pg; > > + /* Only normal RAM for now */ > > + if ( t != p2m_ram_rw ) > > + goto err_put_rx_pg; > > + > > + tx = __map_domain_page_global(tx_pg); > > + if ( !tx ) > > + goto err_put_rx_pg; > > + > > + rx = __map_domain_page_global(rx_pg); > > + if ( !rx ) > > + goto err_unmap_tx; > > + > > + ctx->rx = rx; > > + ctx->tx = tx; > > + ctx->rx_pg = rx_pg; > > + ctx->tx_pg = tx_pg; > > + ctx->page_count = 1; > > + ctx->tx_is_mine = true; > > + return FFA_RET_OK; > > + > > +err_unmap_tx: > > + unmap_domain_page_global(tx); > > +err_put_rx_pg: > > + put_page(rx_pg); > > +err_put_tx_pg: > > + put_page(tx_pg); > > + return ret; > > +} > > + > > +static uint32_t handle_rxtx_unmap(void) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t ret; > > + > > + if ( !ctx->rx ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + ret = ffa_rxtx_unmap(get_vm_id(d)); > > + if ( ret ) > > + return ret; > > + > > + unmap_domain_page_global(ctx->rx); > > + unmap_domain_page_global(ctx->tx); > > + put_page(ctx->rx_pg); > > + put_page(ctx->tx_pg); > > + ctx->rx = NULL; > > + ctx->tx = NULL; > > + ctx->rx_pg = NULL; > > + ctx->tx_pg = NULL; > > + ctx->page_count = 0; > > + ctx->tx_is_mine = false; > > + > > + return FFA_RET_OK; > > +} > > + > > +static uint32_t handle_partition_info_get(uint32_t w1, uint32_t w2, uint32_t w3, > > + uint32_t w4, uint32_t w5, > > + uint32_t *count) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + if ( !ffa_page_count ) > > + return FFA_RET_DENIED; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || !ctx->tx_is_mine ) > > + goto out; > > + ret = ffa_partition_info_get(w1, w2, w3, w4, w5, count); > > + if ( ret ) > > + goto out; > > + if ( ctx->guest_vers == FFA_VERSION_1_0 ) > > + { > > + size_t n; > > + struct ffa_partition_info_1_1 *src = ffa_rx; > > + struct ffa_partition_info_1_0 *dst = ctx->rx; > > + > > + for ( n = 0; n < *count; n++ ) > > + { > > + dst[n].id = src[n].id; > > + dst[n].execution_context = src[n].execution_context; > > + dst[n].partition_properties = src[n].partition_properties; > > + } > > + } > > + else > > + { > > + size_t sz = *count * sizeof(struct ffa_partition_info_1_1); > > + > > + memcpy(ctx->rx, ffa_rx, sz); > > + } > > + ffa_rx_release(); > > + ctx->tx_is_mine = false; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static uint32_t handle_rx_release(void) > > +{ > > + uint32_t ret = FFA_RET_DENIED; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + > > + spin_lock(&ctx->lock); > > + if ( !ctx->page_count || ctx->tx_is_mine ) > > + goto out; > > + ret = FFA_RET_OK; > > + ctx->tx_is_mine = true; > > +out: > > + spin_unlock(&ctx->lock); > > + > > + return ret; > > +} > > + > > +static void handle_msg_send_direct_req(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct arm_smccc_1_2_regs arg = { .a0 = fid, }; > > + struct arm_smccc_1_2_regs resp = { }; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t src_dst; > > + uint64_t mask; > > + > > + if ( smccc_is_conv_64(fid) ) > > + mask = 0xffffffffffffffff; > > + else > > + mask = 0xffffffff; > > + > > + src_dst = get_user_reg(regs, 1); > > + if ( (src_dst >> 16) != get_vm_id(d) ) > > + { > > + resp.a0 = FFA_ERROR; > > + resp.a2 = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + arg.a1 = src_dst; > > + arg.a2 = get_user_reg(regs, 2) & mask; > > + arg.a3 = get_user_reg(regs, 3) & mask; > > + arg.a4 = get_user_reg(regs, 4) & mask; > > + arg.a5 = get_user_reg(regs, 5) & mask; > > + arg.a6 = get_user_reg(regs, 6) & mask; > > + arg.a7 = get_user_reg(regs, 7) & mask; > > + > > + while ( true ) > > + { > > + arm_smccc_1_2_smc(&arg, &resp); > > + > > + switch ( resp.a0 ) > > + { > > + case FFA_INTERRUPT: > > + ctx->interrupted = true; > > + goto out; > > + case FFA_ERROR: > > + case FFA_SUCCESS_32: > > + case FFA_SUCCESS_64: > > + case FFA_MSG_SEND_DIRECT_RESP_32: > > + case FFA_MSG_SEND_DIRECT_RESP_64: > > + goto out; > > + default: > > + /* Bad fid, report back. */ > > + memset(&arg, 0, sizeof(arg)); > > + arg.a0 = FFA_ERROR; > > + arg.a1 = src_dst; > > + arg.a2 = FFA_RET_NOT_SUPPORTED; > > + continue; > > + } > > + } > > + > > +out: > > + set_user_reg(regs, 0, resp.a0); > > + set_user_reg(regs, 1, resp.a1 & mask); > > + set_user_reg(regs, 2, resp.a2 & mask); > > + set_user_reg(regs, 3, resp.a3 & mask); > > + set_user_reg(regs, 4, resp.a4 & mask); > > + set_user_reg(regs, 5, resp.a5 & mask); > > + set_user_reg(regs, 6, resp.a6 & mask); > > + set_user_reg(regs, 7, resp.a7 & mask); > > +} > > + > > +static int get_shm_pages(struct domain *d, struct ffa_shm_mem *shm, > > + struct ffa_address_range *range, uint32_t range_count, > > + unsigned int start_page_idx, > > + unsigned int *last_page_idx) > > +{ > > + unsigned int pg_idx = start_page_idx; > > + unsigned long gfn; > > + unsigned int n; > > + unsigned int m; > > + p2m_type_t t; > > + uint64_t addr; > > + > > + for ( n = 0; n < range_count; n++ ) > > + { > > + for ( m = 0; m < range[n].page_count; m++ ) > > + { > > + if ( pg_idx >= shm->page_count ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + addr = read_atomic(&range[n].address); > > + gfn = gaddr_to_gfn(addr + m * PAGE_SIZE); > > + shm->pages[pg_idx] = get_page_from_gfn(d, gfn, &t, P2M_ALLOC); > > + if ( !shm->pages[pg_idx] ) > > + return FFA_RET_DENIED; > > + pg_idx++; > > + /* Only normal RAM for now */ > > + if ( t != p2m_ram_rw ) > > + return FFA_RET_DENIED; > > + } > > + } > > + > > + *last_page_idx = pg_idx; > > + > > + return FFA_RET_OK; > > +} > > + > > +static void put_shm_pages(struct ffa_shm_mem *shm) > > +{ > > + unsigned int n; > > + > > + for ( n = 0; n < shm->page_count && shm->pages[n]; n++ ) > > + { > > + put_page(shm->pages[n]); > > + shm->pages[n] = NULL; > > + } > > +} > > + > > +static void init_range(struct ffa_address_range *addr_range, > > + paddr_t pa) > > +{ > > + memset(addr_range, 0, sizeof(*addr_range)); > > + addr_range->address = pa; > > + addr_range->page_count = 1; > > +} > > + > > +static int share_shm(struct ffa_shm_mem *shm) > > +{ > > + uint32_t max_frag_len = ffa_page_count * PAGE_SIZE; > > + struct ffa_mem_transaction_1_1 *descr = ffa_tx; > > + struct ffa_mem_access *mem_access_array; > > + struct ffa_mem_region *region_descr; > > + struct ffa_address_range *addr_range; > > + paddr_t pa; > > + paddr_t last_pa; > > + unsigned int n; > > + uint32_t frag_len; > > + uint32_t tot_len; > > + int ret; > > + unsigned int range_count; > > + unsigned int range_base; > > + bool first; > > + > > + memset(descr, 0, sizeof(*descr)); > > + descr->sender_id = shm->sender_id; > > + descr->global_handle = shm->handle; > > + descr->mem_reg_attr = FFA_NORMAL_MEM_REG_ATTR; > > + descr->mem_access_count = 1; > > + descr->mem_access_size = sizeof(*mem_access_array); > > + descr->mem_access_offs = sizeof(*descr); > > + mem_access_array = (void *)(descr + 1); > > + region_descr = (void *)(mem_access_array + 1); > > + > > + memset(mem_access_array, 0, sizeof(*mem_access_array)); > > + mem_access_array[0].access_perm.endpoint_id = shm->ep_id; > > + mem_access_array[0].access_perm.perm = FFA_MEM_ACC_RW; > > + mem_access_array[0].region_offs = (vaddr_t)region_descr - (vaddr_t)ffa_tx; > > + > > + memset(region_descr, 0, sizeof(*region_descr)); > > + region_descr->total_page_count = shm->page_count; > > + > > + region_descr->address_range_count = 1; > > + last_pa = page_to_maddr(shm->pages[0]); > > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > > + { > > + pa = page_to_maddr(shm->pages[n]); > > + if ( last_pa + PAGE_SIZE == pa ) > > + { > > + continue; > > + } > > + region_descr->address_range_count++; > > + } > > + > > + tot_len = sizeof(*descr) + sizeof(*mem_access_array) + > > + sizeof(*region_descr) + > > + region_descr->address_range_count * sizeof(*addr_range); > > + > > + addr_range = region_descr->address_range_array; > > + frag_len = (vaddr_t)(addr_range + 1) - (vaddr_t)ffa_tx; > > + last_pa = page_to_maddr(shm->pages[0]); > > + init_range(addr_range, last_pa); > > + first = true; > > + range_count = 1; > > + range_base = 0; > > + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) > > + { > > + pa = page_to_maddr(shm->pages[n]); > > + if ( last_pa + PAGE_SIZE == pa ) > > + { > > + addr_range->page_count++; > > + continue; > > + } > > + > > + if ( frag_len == max_frag_len ) > > + { > > + if ( first ) > > + { > > + ret = ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > > + first = false; > > + } > > + else > > + { > > + ret = ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > > + } > > + if ( ret <= 0) > > + return ret; > > + range_base = range_count; > > + range_count = 0; > > + frag_len = sizeof(*addr_range); > > + addr_range = ffa_tx; > > + } > > + else > > + { > > + frag_len += sizeof(*addr_range); > > + addr_range++; > > + } > > + init_range(addr_range, pa); > > + range_count++; > > + } > > + > > + if ( first ) > > + return ffa_mem_share(tot_len, frag_len, 0, 0, &shm->handle); > > + else > > + return ffa_mem_frag_tx(shm->handle, frag_len, shm->sender_id); > > +} > > + > > +static int read_mem_transaction(uint32_t ffa_vers, void *buf, size_t blen, > > + struct ffa_mem_transaction_x *trans) > > +{ > > + uint16_t mem_reg_attr; > > + uint32_t flags; > > + uint32_t count; > > + uint32_t offs; > > + uint32_t size; > > + > > + if ( ffa_vers >= FFA_VERSION_1_1 ) > > + { > > + struct ffa_mem_transaction_1_1 *descr; > > + > > + if ( blen < sizeof(*descr) ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + descr = buf; > > + trans->sender_id = read_atomic(&descr->sender_id); > > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > > + flags = read_atomic(&descr->flags); > > + trans->global_handle = read_atomic(&descr->global_handle); > > + trans->tag = read_atomic(&descr->tag); > > + > > + count = read_atomic(&descr->mem_access_count); > > + size = read_atomic(&descr->mem_access_size); > > + offs = read_atomic(&descr->mem_access_offs); > > + } > > + else > > + { > > + struct ffa_mem_transaction_1_0 *descr; > > + > > + if ( blen < sizeof(*descr) ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + descr = buf; > > + trans->sender_id = read_atomic(&descr->sender_id); > > + mem_reg_attr = read_atomic(&descr->mem_reg_attr); > > + flags = read_atomic(&descr->flags); > > + trans->global_handle = read_atomic(&descr->global_handle); > > + trans->tag = read_atomic(&descr->tag); > > + > > + count = read_atomic(&descr->mem_access_count); > > + size = sizeof(struct ffa_mem_access); > > + offs = offsetof(struct ffa_mem_transaction_1_0, mem_access_array); > > + } > > + > > + if ( mem_reg_attr > UINT8_MAX || flags > UINT8_MAX || size > UINT8_MAX || > > + count > UINT8_MAX || offs > UINT16_MAX ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + /* Check that the endpoint memory access descriptor array fits */ > > + if ( size * count + offs > blen ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + trans->mem_reg_attr = mem_reg_attr; > > + trans->flags = flags; > > + trans->mem_access_size = size; > > + trans->mem_access_count = count; > > + trans->mem_access_offs = offs; > > + return 0; > > +} > > + > > +static int add_mem_share_frag(struct mem_frag_state *s, unsigned int offs, > > + unsigned int frag_len) > > +{ > > + struct domain *d = current->domain; > > + unsigned int o = offs; > > + unsigned int l; > > + int ret; > > + > > + if ( frag_len < o ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + /* Fill up the first struct ffa_address_range */ > > + l = min_t(unsigned int, frag_len - o, sizeof(s->range) - s->range_offset); > > + memcpy((uint8_t *)&s->range + s->range_offset, s->buf + o, l); > > + s->range_offset += l; > > + o += l; > > + if ( s->range_offset != sizeof(s->range) ) > > + goto out; > > + s->range_offset = 0; > > + > > + while ( true ) > > + { > > + ret = get_shm_pages(d, s->shm, &s->range, 1, s->current_page_idx, > > + &s->current_page_idx); > > + if ( ret ) > > + return ret; > > + if ( s->range_count == 1 ) > > + return 0; > > + s->range_count--; > > + if ( frag_len - o < sizeof(s->range) ) > > + break; > > + memcpy(&s->range, s->buf + o, sizeof(s->range)); > > + o += sizeof(s->range); > > + } > > + > > + /* Collect any remaining bytes for the next struct ffa_address_range */ > > + s->range_offset = frag_len - o; > > + memcpy(&s->range, s->buf + o, frag_len - o); > > +out: > > + s->frag_offset += frag_len; > > + return s->frag_offset; > > +} > > + > > +static void handle_mem_share(struct cpu_user_regs *regs) > > +{ > > + uint32_t tot_len = get_user_reg(regs, 1); > > + uint32_t frag_len = get_user_reg(regs, 2); > > + uint64_t addr = get_user_reg(regs, 3); > > + uint32_t page_count = get_user_reg(regs, 4); > > + struct ffa_mem_transaction_x trans; > > + struct ffa_mem_access *mem_access; > > + struct ffa_mem_region *region_descr; > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + struct ffa_shm_mem *shm = NULL; > > + unsigned int last_page_idx = 0; > > + uint32_t range_count; > > + uint32_t region_offs; > > + int ret = FFA_RET_DENIED; > > + uint32_t handle_hi = 0; > > + uint32_t handle_lo = 0; > > + > > + /* > > + * We're only accepting memory transaction descriptors via the rx/tx > > + * buffer. > > + */ > > + if ( addr ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + /* Check that fragment legnth doesn't exceed total length */ > > + if ( frag_len > tot_len ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out_unlock; > > + } > > + > > + spin_lock(&ctx->lock); > > + > > + if ( frag_len > ctx->page_count * PAGE_SIZE ) > > + goto out_unlock; > > + > > + if ( !ffa_page_count ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out_unlock; > > + } > > + > > + ret = read_mem_transaction(ctx->guest_vers, ctx->tx, frag_len, &trans); > > + if ( ret ) > > + goto out_unlock; > > + > > + if ( trans.mem_reg_attr != FFA_NORMAL_MEM_REG_ATTR ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out; > > + } > > + > > + /* Only supports sharing it with one SP for now */ > > + if ( trans.mem_access_count != 1 ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + if ( trans.sender_id != get_vm_id(d) ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out_unlock; > > + } > > + > > + /* Check that it fits in the supplied data */ > > + if ( trans.mem_access_offs + trans.mem_access_size > frag_len ) > > + goto out_unlock; > > + > > + mem_access = (void *)((vaddr_t)ctx->tx + trans.mem_access_offs); > > + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + region_offs = read_atomic(&mem_access->region_offs); > > + if ( sizeof(*region_descr) + region_offs > frag_len ) > > + { > > + ret = FFA_RET_NOT_SUPPORTED; > > + goto out_unlock; > > + } > > + > > + region_descr = (void *)((vaddr_t)ctx->tx + region_offs); > > + range_count = read_atomic(®ion_descr->address_range_count); > > + page_count = read_atomic(®ion_descr->total_page_count); > > + > > + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count); > > + if ( !shm ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out; > > + } > > + shm->sender_id = trans.sender_id; > > + shm->ep_id = read_atomic(&mem_access->access_perm.endpoint_id); > > + shm->page_count = page_count; > > + > > + if ( frag_len != tot_len ) > > + { > > + struct mem_frag_state *s = xzalloc(struct mem_frag_state); > > + > > + if ( !s ) > > + { > > + ret = FFA_RET_NO_MEMORY; > > + goto out; > > + } > > + s->shm = shm; > > + s->range_count = range_count; > > + s->buf = ctx->tx; > > + s->buf_size = ffa_page_count * PAGE_SIZE; > > + ret = add_mem_share_frag(s, sizeof(*region_descr) + region_offs, > > + frag_len); > > + if ( ret <= 0 ) > > + { > > + xfree(s); > > + if ( ret < 0 ) > > + goto out; > > + } > > + else > > + { > > + shm->handle = next_handle++; > > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > > + list_add_tail(&s->list, &ctx->frag_list); > > + } > > + goto out_unlock; > > + } > > + > > + /* > > + * Check that the Composite memory region descriptor fits. > > + */ > > + if ( sizeof(*region_descr) + region_offs + > > + range_count * sizeof(struct ffa_address_range) > frag_len ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, > > + 0, &last_page_idx); > > + if ( ret ) > > + goto out; > > + if ( last_page_idx != shm->page_count ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + /* Note that share_shm() uses our tx buffer */ > > + spin_lock(&ffa_buffer_lock); > > + ret = share_shm(shm); > > + spin_unlock(&ffa_buffer_lock); > > + if ( ret ) > > + goto out; > > + > > + spin_lock(&ffa_mem_list_lock); > > + list_add_tail(&shm->list, &ffa_mem_list); > > + spin_unlock(&ffa_mem_list_lock); > > + > > + reg_pair_from_64(&handle_hi, &handle_lo, shm->handle); > > + > > +out: > > + if ( ret && shm ) > > + { > > + put_shm_pages(shm); > > + xfree(shm); > > + } > > +out_unlock: > > + spin_unlock(&ctx->lock); > > + > > + if ( ret > 0 ) > > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, trans.sender_id); > > + else if ( ret == 0) > > + set_regs_success(regs, handle_lo, handle_hi); > > + else > > + set_regs_error(regs, ret); > > +} > > + > > +static struct mem_frag_state *find_frag_state(struct ffa_ctx *ctx, > > + uint64_t handle) > > +{ > > + struct mem_frag_state *s; > > + > > + list_for_each_entry(s, &ctx->frag_list, list) > > + if ( s->shm->handle == handle ) > > + return s; > > + > > + return NULL; > > +} > > + > > +static void handle_mem_frag_tx(struct cpu_user_regs *regs) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t frag_len = get_user_reg(regs, 3); > > + uint32_t handle_lo = get_user_reg(regs, 1); > > + uint32_t handle_hi = get_user_reg(regs, 2); > > + uint64_t handle = reg_pair_to_64(handle_hi, handle_lo); > > + struct mem_frag_state *s; > > + uint16_t sender_id = 0; > > + int ret; > > + > > + spin_lock(&ctx->lock); > > + s = find_frag_state(ctx, handle); > > + if ( !s ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + sender_id = s->shm->sender_id; > > + > > + if ( frag_len > s->buf_size ) > > + { > > + ret = FFA_RET_INVALID_PARAMETERS; > > + goto out; > > + } > > + > > + ret = add_mem_share_frag(s, 0, frag_len); > > + if ( ret == 0 ) > > + { > > + /* Note that share_shm() uses our tx buffer */ > > + spin_lock(&ffa_buffer_lock); > > + ret = share_shm(s->shm); > > + spin_unlock(&ffa_buffer_lock); > > + if ( ret == 0 ) > > + { > > + spin_lock(&ffa_mem_list_lock); > > + list_add_tail(&s->shm->list, &ffa_mem_list); > > + spin_unlock(&ffa_mem_list_lock); > > + } > > + else > > + { > > + put_shm_pages(s->shm); > > + xfree(s->shm); > > + } > > + list_del(&s->list); > > + xfree(s); > > + } > > + else if ( ret < 0 ) > > + { > > + put_shm_pages(s->shm); > > + xfree(s->shm); > > + list_del(&s->list); > > + xfree(s); > > + } > > +out: > > + spin_unlock(&ctx->lock); > > + > > + if ( ret > 0 ) > > + set_regs_frag_rx(regs, handle_lo, handle_hi, ret, sender_id); > > + else if ( ret == 0) > > + set_regs_success(regs, handle_lo, handle_hi); > > + else > > + set_regs_error(regs, ret); > > +} > > + > > +static int handle_mem_reclaim(uint64_t handle, uint32_t flags) > > +{ > > + struct ffa_shm_mem *shm; > > + uint32_t handle_hi; > > + uint32_t handle_lo; > > + int ret; > > + > > + spin_lock(&ffa_mem_list_lock); > > + list_for_each_entry(shm, &ffa_mem_list, list) > > + { > > + if ( shm->handle == handle ) > > + goto found_it; > > + } > > + shm = NULL; > > +found_it: > > + spin_unlock(&ffa_mem_list_lock); > > + > > + if ( !shm ) > > + return FFA_RET_INVALID_PARAMETERS; > > + > > + reg_pair_from_64(&handle_hi, &handle_lo, handle); > > + ret = ffa_mem_reclaim(handle_lo, handle_hi, flags); > > + if ( ret ) > > + return ret; > > + > > + spin_lock(&ffa_mem_list_lock); > > + list_del(&shm->list); > > + spin_unlock(&ffa_mem_list_lock); > > + > > + put_shm_pages(shm); > > + xfree(shm); > > + > > + return ret; > > +} > > + > > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + struct domain *d = current->domain; > > + struct ffa_ctx *ctx = d->arch.ffa; > > + uint32_t count; > > + uint32_t e; > > + > > + if ( !ctx ) > > + return false; > > + > > + switch ( fid ) > > + { > > + case FFA_VERSION: > > + handle_version(regs); > > + return true; > > + case FFA_ID_GET: > > + set_regs_success(regs, get_vm_id(d), 0); > > + return true; > > + case FFA_RXTX_MAP_32: > > +#ifdef CONFIG_ARM_64 > > + case FFA_RXTX_MAP_64: > > +#endif > > + e = handle_rxtx_map(fid, get_user_reg(regs, 1), get_user_reg(regs, 2), > > + get_user_reg(regs, 3)); > > + if ( e ) > > + set_regs_error(regs, e); > > + else > > + set_regs_success(regs, 0, 0); > > + return true; > > + case FFA_RXTX_UNMAP: > > + e = handle_rxtx_unmap(); > > + if ( e ) > > + set_regs_error(regs, e); > > + else > > + set_regs_success(regs, 0, 0); > > + return true; > > + case FFA_PARTITION_INFO_GET: > > + e = handle_partition_info_get(get_user_reg(regs, 1), > > + get_user_reg(regs, 2), > > + get_user_reg(regs, 3), > > + get_user_reg(regs, 4), > > + get_user_reg(regs, 5), &count); > > + if ( e ) > > + set_regs_error(regs, e); > > + else > > + set_regs_success(regs, count, 0); > > + return true; > > + case FFA_RX_RELEASE: > > + e = handle_rx_release(); > > + if ( e ) > > + set_regs_error(regs, e); > > + else > > + set_regs_success(regs, 0, 0); > > + return true; > > + case FFA_MSG_SEND_DIRECT_REQ_32: > > +#ifdef CONFIG_ARM_64 > > + case FFA_MSG_SEND_DIRECT_REQ_64: > > +#endif > > + handle_msg_send_direct_req(regs, fid); > > + return true; > > + case FFA_MEM_SHARE_32: > > +#ifdef CONFIG_ARM_64 > > + case FFA_MEM_SHARE_64: > > +#endif > > + handle_mem_share(regs); > > + return true; > > + case FFA_MEM_RECLAIM: > > + e = handle_mem_reclaim(reg_pair_to_64(get_user_reg(regs, 2), > > + get_user_reg(regs, 1)), > > + get_user_reg(regs, 3)); > > + if ( e ) > > + set_regs_error(regs, e); > > + else > > + set_regs_success(regs, 0, 0); > > + return true; > > + case FFA_MEM_FRAG_TX: > > + handle_mem_frag_tx(regs); > > + return true; > > + > > + default: > > + printk(XENLOG_ERR "ffa: unhandled fid 0x%x\n", fid); > > + return false; > > + } > > +} > > + > > +int ffa_domain_init(struct domain *d, bool ffa_enabled) > > +{ > > + struct ffa_ctx *ctx; > > + unsigned int n; > > + unsigned int m; > > + unsigned int c_pos; > > + int32_t res; > > + > > + if ( !ffa_version || !ffa_enabled ) > > + return 0; > > + > > + ctx = xzalloc(struct ffa_ctx); > > + if ( !ctx ) > > + return -ENOMEM; > > + > > + for ( n = 0; n < subsr_vm_created_count; n++ ) > > + { > > + res = ffa_direct_req_send_vm(subsr_vm_created[n], get_vm_id(d), > > + FFA_MSG_SEND_VM_CREATED); > > + if ( res ) > > + { > > + printk(XENLOG_ERR "ffa: Failed to report creation of vm_id %u to %u: res %d\n", > > + get_vm_id(d), subsr_vm_created[n], res); > > + c_pos = n; > > + goto err; > > + } > > + } > > + > > + INIT_LIST_HEAD(&ctx->frag_list); > > + > > + d->arch.ffa = ctx; > > + > > + return 0; > > + > > +err: > > + /* Undo any already sent vm created messaged */ > > + for ( n = 0; n < c_pos; n++ ) > > + for ( m = 0; m < subsr_vm_destroyed_count; m++ ) > > + if ( subsr_vm_destroyed[m] == subsr_vm_created[n] ) > > + ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(d), > > + FFA_MSG_SEND_VM_DESTROYED); > > + return -ENOMEM; > > +} > > + > > +int ffa_relinquish_resources(struct domain *d) > > +{ > > + struct ffa_ctx *ctx = d->arch.ffa; > > + unsigned int n; > > + int32_t res; > > + > > + if ( !ctx ) > > + return 0; > > + > > + for ( n = 0; n < subsr_vm_destroyed_count; n++ ) > > + { > > + res = ffa_direct_req_send_vm(subsr_vm_destroyed[n], get_vm_id(d), > > + FFA_MSG_SEND_VM_DESTROYED); > > + > > + if ( res ) > > + printk(XENLOG_ERR "ffa: Failed to report destruction of vm_id %u to %u: res %d\n", > > + get_vm_id(d), subsr_vm_destroyed[n], res); > > + } > > + > > + XFREE(d->arch.ffa); > > + > > + return 0; > > +} > > + > > +static bool __init init_subscribers(void) > > +{ > > + struct ffa_partition_info_1_1 *fpi; > > + bool ret = false; > > + uint32_t count; > > + uint32_t e; > > + uint32_t n; > > + uint32_t c_pos; > > + uint32_t d_pos; > > + > > + if ( ffa_version < FFA_VERSION_1_1 ) > > + return true; > > + > > + e = ffa_partition_info_get(0, 0, 0, 0, 1, &count); > > + ffa_rx_release(); > > + if ( e ) > > + { > > + printk(XENLOG_ERR "ffa: Failed to get list of SPs: %d\n", (int)e); > > + goto out; > > + } > > + > > + fpi = ffa_rx; > > + subsr_vm_created_count = 0; > > + subsr_vm_destroyed_count = 0; > > + for ( n = 0; n < count; n++ ) > > + { > > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED) > > + subsr_vm_created_count++; > > + if (fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED) > > + subsr_vm_destroyed_count++; > > + } > > + > > + if ( subsr_vm_created_count ) > > + subsr_vm_created = xzalloc_array(uint16_t, subsr_vm_created_count); > > + if ( subsr_vm_destroyed_count ) > > + subsr_vm_destroyed = xzalloc_array(uint16_t, subsr_vm_destroyed_count); > > + if ( (subsr_vm_created_count && !subsr_vm_created) || > > + (subsr_vm_destroyed_count && !subsr_vm_destroyed) ) > > + { > > + printk(XENLOG_ERR "ffa: Failed to allocate subscription lists\n"); > > + subsr_vm_created_count = 0; > > + subsr_vm_destroyed_count = 0; > > + XFREE(subsr_vm_created); > > + XFREE(subsr_vm_destroyed); > > + goto out; > > + } > > + > > + for ( c_pos = 0, d_pos = 0, n = 0; n < count; n++ ) > > + { > > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_CREATED ) > > + subsr_vm_created[c_pos++] = fpi[n].id; > > + if ( fpi[n].partition_properties & FFA_PART_PROP_NOTIF_DESTROYED ) > > + subsr_vm_destroyed[d_pos++] = fpi[n].id; > > + } > > + > > + ret = true; > > +out: > > + ffa_rx_release(); > > + return ret; > > +} > > + > > +static int __init ffa_init(void) > > +{ > > + uint32_t vers; > > + uint32_t e; > > + unsigned int major_vers; > > + unsigned int minor_vers; > > + > > + /* > > + * psci_init_smccc() updates this value with what's reported by EL-3 > > + * or secure world. > > + */ > > + if ( smccc_ver < ARM_SMCCC_VERSION_1_2 ) > > + { > > + printk(XENLOG_ERR > > + "ffa: unsupported SMCCC version %#x (need at least %#x)\n", > > + smccc_ver, ARM_SMCCC_VERSION_1_2); > > + return 0; > > + } > > + > > + if ( !ffa_get_version(&vers) ) > > + return 0; > > + > > + if ( vers < FFA_MIN_VERSION || vers > FFA_MY_VERSION ) > > + { > > + printk(XENLOG_ERR "ffa: Incompatible version %#x found\n", vers); > > + return 0; > > + } > > + > > + major_vers = (vers >> FFA_VERSION_MAJOR_SHIFT) & FFA_VERSION_MAJOR_MASK; > > + minor_vers = vers & FFA_VERSION_MINOR_MASK; > > + printk(XENLOG_INFO "ARM FF-A Mediator version %u.%u\n", > > + FFA_VERSION_MAJOR, FFA_VERSION_MINOR); > > + printk(XENLOG_INFO "ARM FF-A Firmware version %u.%u\n", > > + major_vers, minor_vers); > > + > > + if ( !check_mandatory_feature(FFA_PARTITION_INFO_GET) || > > + !check_mandatory_feature(FFA_RX_RELEASE) || > > +#ifdef CONFIG_ARM_64 > > + !check_mandatory_feature(FFA_RXTX_MAP_64) || > > + !check_mandatory_feature(FFA_MEM_SHARE_64) || > > +#endif > > +#ifdef CONFIG_ARM_32 > > + !check_mandatory_feature(FFA_RXTX_MAP_32) || > > +#endif > > + !check_mandatory_feature(FFA_RXTX_UNMAP) || > > + !check_mandatory_feature(FFA_MEM_SHARE_32) || > > + !check_mandatory_feature(FFA_MEM_FRAG_TX) || > > + !check_mandatory_feature(FFA_MEM_RECLAIM) || > > + !check_mandatory_feature(FFA_MSG_SEND_DIRECT_REQ_32) ) > > + return 0; > > + > > + ffa_rx = alloc_xenheap_pages(0, 0); > > + if ( !ffa_rx ) > > + return 0; > > + > > + ffa_tx = alloc_xenheap_pages(0, 0); > > + if ( !ffa_tx ) > > + goto err_free_ffa_rx; > > + > > + e = ffa_rxtx_map(__pa(ffa_tx), __pa(ffa_rx), 1); > > + if ( e ) > > + { > > + printk(XENLOG_ERR "ffa: Failed to map rxtx: error %d\n", (int)e); > > + goto err_free_ffa_tx; > > + } > > + ffa_page_count = 1; > > + ffa_version = vers; > > + > > + if ( !init_subscribers() ) > > + goto err_free_ffa_tx; > > + > > + return 0; > > + > > +err_free_ffa_tx: > > + free_xenheap_pages(ffa_tx, 0); > > + ffa_tx = NULL; > > +err_free_ffa_rx: > > + free_xenheap_pages(ffa_rx, 0); > > + ffa_rx = NULL; > > + ffa_page_count = 0; > > + ffa_version = 0; > > + XFREE(subsr_vm_created); > > + subsr_vm_created_count = 0; > > + XFREE(subsr_vm_destroyed); > > + subsr_vm_destroyed_count = 0; > > + return 0; > > +} > > + > > +__initcall(ffa_init); > > diff --git a/xen/arch/arm/include/asm/domain.h b/xen/arch/arm/include/asm/domain.h > > index ed63c2b6f91f..b3dee269bced 100644 > > --- a/xen/arch/arm/include/asm/domain.h > > +++ b/xen/arch/arm/include/asm/domain.h > > @@ -103,6 +103,10 @@ struct arch_domain > > void *tee; > > #endif > > > > +#ifdef CONFIG_FFA > > + void *ffa; > > +#endif > > + > > bool directmap; > > } __cacheline_aligned; > > > > diff --git a/xen/arch/arm/include/asm/ffa.h b/xen/arch/arm/include/asm/ffa.h > > new file mode 100644 > > index 000000000000..4f4a739345bd > > --- /dev/null > > +++ b/xen/arch/arm/include/asm/ffa.h > > @@ -0,0 +1,71 @@ > > +/* > > + * xen/arch/arm/ffa.c > > + * > > + * Arm Firmware Framework for ARMv8-A(FFA) mediator > > + * > > + * Copyright (C) 2021 Linaro Limited > > + * > > + * Permission is hereby granted, free of charge, to any person > > + * obtaining a copy of this software and associated documentation > > + * files (the "Software"), to deal in the Software without restriction, > > + * including without limitation the rights to use, copy, modify, merge, > > + * publish, distribute, sublicense, and/or sell copies of the Software, > > + * and to permit persons to whom the Software is furnished to do so, > > + * subject to the following conditions: > > + * > > + * The above copyright notice and this permission notice shall be > > + * included in all copies or substantial portions of the Software. > > + * > > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF > > + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. > > + * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY > > + * CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, > > + * TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE > > + * SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > + */ > > + > > +#ifndef __ASM_ARM_FFA_H__ > > +#define __ASM_ARM_FFA_H__ > > + > > +#include > > + > > +#include > > +#include > > + > > +#define FFA_FNUM_MIN_VALUE _AC(0x60,U) > > +#define FFA_FNUM_MAX_VALUE _AC(0x86,U) > > + > > +static inline bool is_ffa_fid(uint32_t fid) > > +{ > > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > > + > > + return fn >= FFA_FNUM_MIN_VALUE && fn <= FFA_FNUM_MAX_VALUE; > > +} > > + > > +#ifdef CONFIG_FFA > > +#define FFA_NR_FUNCS 11 > > + > > +bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid); > > +int ffa_domain_init(struct domain *d, bool ffa_enabled); > > +int ffa_relinquish_resources(struct domain *d); > > +#else > > +#define FFA_NR_FUNCS 0 > > + > > +static inline bool ffa_handle_call(struct cpu_user_regs *regs, uint32_t fid) > > +{ > > + return false; > > +} > > + > > +static inline int ffa_domain_init(struct domain *d, bool ffa_enabled) > > +{ > > + return 0; > > +} > > + > > +static inline int ffa_relinquish_resources(struct domain *d) > > +{ > > + return 0; > > +} > > +#endif > > + > > +#endif /*__ASM_ARM_FFA_H__*/ > > diff --git a/xen/arch/arm/vsmc.c b/xen/arch/arm/vsmc.c > > index 6f90c08a6304..34586025eff8 100644 > > --- a/xen/arch/arm/vsmc.c > > +++ b/xen/arch/arm/vsmc.c > > @@ -20,6 +20,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -32,7 +33,7 @@ > > #define XEN_SMCCC_FUNCTION_COUNT 3 > > > > /* Number of functions currently supported by Standard Service Service Calls. */ > > -#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS) > > +#define SSSC_SMCCC_FUNCTION_COUNT (3 + VPSCI_NR_FUNCS + FFA_NR_FUNCS) > > > > static bool fill_uid(struct cpu_user_regs *regs, xen_uuid_t uuid) > > { > > @@ -196,13 +197,23 @@ static bool handle_existing_apis(struct cpu_user_regs *regs) > > return do_vpsci_0_1_call(regs, fid); > > } > > > > +static bool is_psci_fid(uint32_t fid) > > +{ > > + uint32_t fn = fid & ARM_SMCCC_FUNC_MASK; > > + > > + return fn >= 0 && fn <= 0x1fU; > > +} > > + > > /* PSCI 0.2 interface and other Standard Secure Calls */ > > static bool handle_sssc(struct cpu_user_regs *regs) > > { > > uint32_t fid = (uint32_t)get_user_reg(regs, 0); > > > > - if ( do_vpsci_0_2_call(regs, fid) ) > > - return true; > > + if ( is_psci_fid(fid) ) > > + return do_vpsci_0_2_call(regs, fid); > > + > > + if ( is_ffa_fid(fid) ) > > + return ffa_handle_call(regs, fid); > > > > switch ( fid ) > > { > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h > > index ab05fe12b0de..53f8d44a6a8e 100644 > > --- a/xen/include/public/arch-arm.h > > +++ b/xen/include/public/arch-arm.h > > @@ -318,6 +318,8 @@ struct xen_arch_domainconfig { > > /* IN/OUT */ > > uint8_t gic_version; > > /* IN */ > > + uint8_t ffa_enabled; > > + /* IN */ > > uint16_t tee_type; > > /* IN */ > > uint32_t nr_spis; > > -- > > 2.31.1 > > > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 07:27:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 07:27:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375928.608414 (Exim 4.92) (envelope-from ) id 1oGbRb-0000aR-Js; Wed, 27 Jul 2022 07:26:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375928.608414; Wed, 27 Jul 2022 07:26:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbRb-0000aK-HM; Wed, 27 Jul 2022 07:26:59 +0000 Received: by outflank-mailman (input) for mailman id 375928; Wed, 27 Jul 2022 07:26:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbRa-0000aE-Az for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 07:26:58 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2060.outbound.protection.outlook.com [40.107.21.60]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7eba871d-0d7d-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 09:26:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBBPR04MB7803.eurprd04.prod.outlook.com (2603:10a6:10:1e5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 07:26:54 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 07:26:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7eba871d-0d7d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bl9fWKGMtiwNMZiqYGix0ln5LC38NpxI1VoWQFWoxsKEL//K7EPcfuHmDdE7fQebdzd7PI39ZfWOn8o0JjErrvK0WSJmtjVG2jkKvjqEq4uVDYh3ueQ0uQhv7sHjR2ZczLQKeeiTs+nZol6lMUHMpfEwAMzZnWoFQ5O0Sg87mYngNAjFeDDf3RwHoCdpjKeA0KLoJUY6GJ8OgWmL9kwH3rJ2uh+eoOXBUTPW5gwexqHZvqZx3nUa7ZtKmPNLDq5t8gQQrghrZj0l76tC/ZH4flbd+3TF+PzUeJUDIvRKHlAwEgVbbZzDM34mOYSH+rcN0YA3kiayH2Vhk4GQuet+Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=k3f0nXNe/ZXkFu9A3Q65gE1NYfpQBS1d/vi0bHTAZ1M=; b=ayePkV5f+yG9ugDdA0s4vc8q2au5gWfyp1t0TQlCBMOzr9RzLoS0J53QTANUXQU0jzu7qnmcMpRa6YXybeRne2PFyB28kjklSqmY7fDca88dZrDNBQAEJE3g46v3zBA7oRy+7j2qKorKzJtbl1B1uSubyZADhIhUFyZxCTlSGtBv7KImHwnsE75j8G299nYYGZ3CfpoR/0vC6xsFM8QVRbCJyHoL7L1gfZWkxvy8gNDieenr/ZayPhvO6SsvNh567oqeS1iNb6WqLX4fc4RInH8jZQHm6LyPsPFKpiM2JaVkNuDurP7ccgw8QeAfqDEyunEFJtE9mMULhPUu4jjw4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=k3f0nXNe/ZXkFu9A3Q65gE1NYfpQBS1d/vi0bHTAZ1M=; b=px8PU4fqqbapdmAm3gcOyzddMfb1uiTKavp7JTBsGyYrTFc1cjqPaCoiWfmEOR46d14XCneyNxzgzMwJ2Cu2SvZ65pQMBkM88yYVBrLeQB1XqrmEiG/KLufhZTBNG5wrfMH7eKNX+zMjPu1YCRvmtQ4InDoWbmv+7TAn0eCMmteS7JPpZW3K0d5srVn0eqQ43NS3pDH8RBUJqLjL44JA7y7Df38q6PWcxnRDcxmiUvdLmbWbHTmMTqk5rYftW54S3L1aUY3PyGd/fmj6U/fixAR8pfk7glef9T4IGCFU0Xbb/axxdOwbiLB1zQAjQjEarzfXiuxxDpYcg53S7x+FGg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5622e17f-c424-87a4-d7c4-bbe1dee4743c@suse.com> Date: Wed, 27 Jul 2022 09:26:52 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 From: Jan Beulich Subject: preparations for 4.16.2 To: "xen-devel@lists.xenproject.org" Cc: George Dunlap , Stefano Stabellini , Wei Liu , Anthony Perard , Julien Grall Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0013.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:83::26) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a331da78-9b8d-4288-5f37-08da6fa1614f X-MS-TrafficTypeDiagnostic: DBBPR04MB7803:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RxJatjBCicAvkz7XKGWWzK740ktYCs4Y8mKw18o4k5O/fjtBGVMESiqDJII8ZH1Mu8IhnQ8tSRb2jXP+wCuqylDsB8H7oehy6dpg/CheKc9BJFA2kt0TmN6wDVCUDHS+RxcLBI03+MrR7S8YBWAPRkUx70JzIRKEKDqueuxsJE6tlQmKgHRFLf/Qe6NAQmqeql/wmu8pWhzWBxLZB3WDm98pi/qV6rCR+sB4RfPxp+fKQfRRv+bBCbIj7H7edwVIJ9l6T8dL7WNczYbTAv6RjER7ienuVUlcx6tzcULNAJV4a6TMnO4l744BvSA5VYR+pQh4t3Zhw3vI5JF5Gp0YIxUrFGR64rz8Q2t+dMmxzGh6g7ZYERWH2812p4lcHfGMeghOnlIt6ONHHV/da2F40MA9cCCpqog8ydh+C51rI8oDXQkRCrYtgUIbZ6Lb4WFy99PIIn5mxgmpfRSSJ0/6nYpaAn4vj93NWdRARUjAS8dM193dq78tMwvfjQacDmppa1SkRy50248sV116SSjkTvGITYGTLbnmiUwzb/4VDc9b7b8umYETnxS4J3kRSlMHi4Pzkc/AeUswnKSWYYHYfBpg1w8q68joCPJohcezenWk3Cwk3XJ+ADwaFcc13IgW66jZfhoSZEcNcyyV+krmbYw4NDgGzFPbGbLUBdF+0D1ttwIc82DCgoxqiU6V7DzvnbKmdQ3KE2TktBlkj+ZwvT4IOyfGkEBQ8ocul9KAuu2nZdevNlEoqBRRODy+/Zx2umuNWQMJc7UWp3rbfqwy5nbBMVdONOE+2Zg2fr8JS86T99jzMQZwXkiqw0sDdq1DZS14Xq+YHOGUqAtNONPekA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(396003)(376002)(346002)(136003)(186003)(6486002)(38100700002)(66556008)(8676002)(66946007)(4326008)(66476007)(7116003)(31696002)(478600001)(86362001)(54906003)(6916009)(558084003)(316002)(6506007)(2616005)(26005)(6512007)(8936002)(31686004)(36756003)(5660300002)(2906002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MndhVUMyc3BUdWJYS2hEZmtBcjN5T2JEV2gwK3hRNFNobTNWUk43YkgvODd5?= =?utf-8?B?ditSbXlTeHpjRXFvSDBVb3pUVC9QZk80NER6eVpRQVlFejgzdDRBU3pETWJO?= =?utf-8?B?WUc2dHU3S0d3bkZoV3lReElnbVNOdkdkUmRLS3pEeUNkUlpKa1FyVC9xc0cr?= =?utf-8?B?S1pVUkZWSFZyK1JoZFQ2eVRsTmI3S0h6RndGaWRzRWdwaWhjcUI2Tk45SlQ2?= =?utf-8?B?TktoM0pZbHBQbklmMzNleGsyeGRDanRPUkQ3QjlObmNYMmprSlYxNk9oREF3?= =?utf-8?B?SUZOUU9FeGIxbnFYMDlGQWZaR1JZWmQzcFpwRXUvbi9RcnNOK0Z1VzJraWxO?= =?utf-8?B?cUhhQVNRMU5kSWc4d1p4MFFQbEx2bDRPZzZnZGRHcHRnOXNieWdHY29kYXhi?= =?utf-8?B?d1NFYWdoNmF1Q01nalUvTzJmNDMydWk2STBGQWhhaU5JaGR4cjNDdVJTWWI4?= =?utf-8?B?QkV1NnJ3Z3BJenRwSHZYVW11am16WE9EY3Aza3gwM3FJdWM5UEZQMHJiTkM5?= =?utf-8?B?RVRNaTllWXU2d1FROVVTMHB4aEpWQmF3TXJsU1lhNng0MllncUhmbjlmUVFD?= =?utf-8?B?QWVXRGJzcHIvMHY0U2hocXhGbmtQVFF6dHIyYTRPMVZsMGRaUXM5dy93c2xr?= =?utf-8?B?bHlRSGZucHNIdXdKVThSeHRtOWxaajFvNTdNa3Qza3dSM1Q4K3IzZVA1YmJu?= =?utf-8?B?YjN2UTltWXBjSERza2dJajVZUEgveElXS0Fjcmx3VFZ3N3R2V25zVTNwVjMr?= =?utf-8?B?TUkzRzdJQVRVbGdWb3JGQWRxTVYyZmZoZ1dOT255Ym4wM3BKYzVIeXl5U0w0?= =?utf-8?B?aEVSZEhQMEk0YURTN2R4VVdDLzlQT0xCQ0VLRWN6a1k3ekFHQXFQQmQ3ODVX?= =?utf-8?B?OWF2MXZDREd3aStMc1dTTzNFZFpuUldZL1MyZFArMmFzSkFqOWFvNWlHOWpp?= =?utf-8?B?a24xb1dzeUl3M3IzNlhKUGE2L3E1dE5DRHczSXNCRlpZRGY3amFsek5WZS9I?= =?utf-8?B?bEVzYW55NFN2NkE3TllpYU9QMkRublJJVWFMZmhQL3pucVBGTXVDZXUzNEJW?= =?utf-8?B?Z2JUZm5DalpWaVpsa3labHdWWkVOaGhNU2xtbHhEVjljRkYya2JSTG5uQ0xT?= =?utf-8?B?V3A5b2lIaHNNc2ZPck5LQ0lsMk9IdEd6cUM5R0pObEJhM0wyUUNQUkFxNFNm?= =?utf-8?B?QUh5SCtQTjh2bUpQdVk4KzFMeTFPbjNkUjIyeGhhMjA2dnkzZTNoU1ZxQlRl?= =?utf-8?B?VER6bFJ3T2szY1d1alZPRzlCUGI5Uk1aaVQzcVo2N1FjUHozTEFrdmJEa2c5?= =?utf-8?B?STRyM1F4YmoyY1NVMHgvdjdRTFY0REpFRVVsNjdpVmE1djk5TUR0OG9nZHRt?= =?utf-8?B?KzFZb0FtMHFYWGtmVEtsSmp2aEowMGZDWi8vNWk1dlhFZGlibUU0V1YvTFFK?= =?utf-8?B?c016UlU0TjMyRE55Y3B6UUpKMG56WUdkU1pYb0F6SFdDT1lNb1E0UzJzbGZt?= =?utf-8?B?dlU3dGJsU1NkMitpRFkxcExWMEdybTVyS3oxZy9QRHowWWhOdWVhT0hrYzVQ?= =?utf-8?B?V2xIVytNWmRvS0lGcCtUT0JETjg3dzU4WnhHNVFYR0lMWXlmS2tmQUxWR0xW?= =?utf-8?B?ZVRxYldYWGpjTEwvbjhDaWRjTysxUmRMV3lsZzFydVZ0MUE4bklRc1Q1MHZv?= =?utf-8?B?SnZROGRpTnBnV0pkL2tOeG9hN2lhQVJYUXFEODRqT3pYeUF0bDlDMGplZVlX?= =?utf-8?B?N25CVmdGVC8zQUlodFdIM242dUF2dTlrdThIbnFCRkF1Y0wzOFNEVlRvMUVp?= =?utf-8?B?QVRHT092Qmc1QnBYVit2c2lEbnlGMUNCMENVVEd6cG51K1Q0blVtYS9kdElV?= =?utf-8?B?QU5UYTdwN2RUVVBVc2ZuQ1I0Szlrd0lpR25rbUN6cjM2QmFlVkRWN3BmVDIy?= =?utf-8?B?Um1MUzhVdWhLcW9ocXBJUThHSTltcmdnOHRLeThYTlovQ2lqdi8xZWFqQkpN?= =?utf-8?B?UzF6YUZBMUxIQmt0SlJiRUpPajQ3Q1pDbUNDMVBDQjZoR2NsMm1XTVpRbzBn?= =?utf-8?B?V1RZcVhCVGJCOFp1VlFmN09mVHJ4Mjk5QlZSRnFDMEVyY3QyaEpldWFUM3Vj?= =?utf-8?Q?PuQ1JiKUIUhWb1GYKOwFdi/Oq?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: a331da78-9b8d-4288-5f37-08da6fa1614f X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 07:26:54.1074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xqKwF/AUug2gn9UombTyzs9ZJofBqS5bvW1VMEyorvt6pnSKRdt04D5tIhNaiO27Jrjyb2taTYucmtoii1v/wA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7803 All, the release is due in about two weeks time. Please point out backports you find missing from the respective staging branch, but which you consider relevant. I'm surprised in particular that no Arm backports have appeared on the branch at all since 4.16.1 had gone out. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 07:57:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 07:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375951.608493 (Exim 4.92) (envelope-from ) id 1oGbuR-00051k-Qe; Wed, 27 Jul 2022 07:56:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375951.608493; Wed, 27 Jul 2022 07:56:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbuR-00051d-My; Wed, 27 Jul 2022 07:56:47 +0000 Received: by outflank-mailman (input) for mailman id 375951; Wed, 27 Jul 2022 07:56:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbuQ-00051T-MV; Wed, 27 Jul 2022 07:56:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbuQ-0006sI-Ju; Wed, 27 Jul 2022 07:56:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGbuQ-0001E7-3J; Wed, 27 Jul 2022 07:56:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGbuQ-0002Nq-2r; Wed, 27 Jul 2022 07:56:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=wGI4hQOaZLH2ukxNNJ7BjDVl5V8IeVcTrhfuS7CAnKc=; b=u9/GIBsvWzf1pqHebwgRFLlsD3 zICHts2IYgGzYG/QxuZfHdeKovjgsgTdssM1jRxRb1f1JgtqiNcUZKUH1eer0MNcE55B5PZEO0vgo jcq38fhrZPA56XOKpkYaXXm9PU4pTSwflTDk44EjQmYRmMj1dB0KdwZBYWKwViLZLj5U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.13-testing test] 171868: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.13-testing:test-amd64-i386-migrupgrade:xen-install/src_host:fail:heisenbug xen-4.13-testing:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-4.13-testing:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug xen-4.13-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.13-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.13-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: xen=c946524a65f3f7b795c48d304953be6d7672cfb6 X-Osstest-Versions-That: xen=f8614c7153f95dcd1a1320156787dbc5325fd946 From: osstest service owner Date: Wed, 27 Jul 2022 07:56:46 +0000 flight 171868 xen-4.13-testing real [real] flight 171879 xen-4.13-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171868/ http://logs.test-lab.xenproject.org/osstest/logs/171879/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-migrupgrade 10 xen-install/src_host fail in 171879 pass in 171868 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 171879-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171879-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171603 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171603 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171603 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171603 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171603 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171603 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171603 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171603 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171603 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171603 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171603 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171603 test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: xen c946524a65f3f7b795c48d304953be6d7672cfb6 baseline version: xen f8614c7153f95dcd1a1320156787dbc5325fd946 Last test of basis 171603 2022-07-12 17:08:06 Z 14 days Testing same since 171868 2022-07-26 13:36:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git f8614c7153..c946524a65 c946524a65f3f7b795c48d304953be6d7672cfb6 -> stable-4.13 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 08:19:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 08:19:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375966.608504 (Exim 4.92) (envelope-from ) id 1oGcGc-0008Jr-7w; Wed, 27 Jul 2022 08:19:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375966.608504; Wed, 27 Jul 2022 08:19:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGcGc-0008Jk-4u; Wed, 27 Jul 2022 08:19:42 +0000 Received: by outflank-mailman (input) for mailman id 375966; Wed, 27 Jul 2022 08:19:40 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGcGa-0008Je-Ow for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 08:19:40 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id db020544-0d84-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 10:19:39 +0200 (CEST) Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-477-t_pY58LBOLGN__e3qCx1Ew-1; Wed, 27 Jul 2022 04:19:33 -0400 Received: by mail-ed1-f72.google.com with SMTP id h15-20020a056402280f00b0043bd8412fe0so7425651ede.16 for ; Wed, 27 Jul 2022 01:19:33 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id 11-20020a170906310b00b00722fc0779e3sm7213889ejx.85.2022.07.27.01.19.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 01:19:31 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: db020544-0d84-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658909977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZuT/qe1DCcJGnSW38Ka6ZQWh4Y3+XNV+VTCNVSBHbvs=; b=JO/xzLkPL1mgBIijC3VerS/zd8NHw9yAP7EwB/ihu59HI2z5Rk9raKc6zp8fC5XJaoiWoi 8tHIOw4ztDD0r0fNU8Dr41H2FstiFtHsK5T1G7AZGw0GkcavZN53GCTj3wbOA6Cfm8do94 PrG33k4y8dsfk2m/acf0FWmgbQNGc9c= X-MC-Unique: t_pY58LBOLGN__e3qCx1Ew-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZuT/qe1DCcJGnSW38Ka6ZQWh4Y3+XNV+VTCNVSBHbvs=; b=QMdN+Xwl62UYgBl1aVR863G0DVcRwPRCpfrTyRH2XKFW3hdA97/HPYwHMb0qoaMaIS Rm+NCRVPzv1I/iJKjL5OZ74+LMltEmuwgFP6pe7A8VfqWu56ZV8JCdfY9mOJ83F9TNf5 9Rjxrg9H2gpd3PDTlcf5zd8iO/w3eTUA81im+N8z2REt2Z6XUoHGstvjtkzZqhsQzf4t cil1ZtihrVZ69x2j1tBe8g/Vrm/HFAq1TxJUFxoodK42pQn/MptakgrQtsQKyvMoBger fAeYtBt46iOxWjOOGT0UdPB86gkGier6JjDfSQpxBcVNNxCm4W2+zohUNpDhkzHBapjT NtNA== X-Gm-Message-State: AJIora+Ew6gdlKjZr+Ay/BsTVTxAv+Au7++Ss92Lo25fqVUlBVkmDWSA cTVlm+NXusGDv8yUABq6xwVTKsFs2QhBhJCdkp8fJulOtw/offY4MwvTBlgN5cBsLm+kV9jEXZ/ qgZ/lsUThhdEzs7BaRwmfCpbzxcQ= X-Received: by 2002:a05:6402:354c:b0:43c:2cd0:49bc with SMTP id f12-20020a056402354c00b0043c2cd049bcmr10446058edd.48.1658909972338; Wed, 27 Jul 2022 01:19:32 -0700 (PDT) X-Google-Smtp-Source: AGRyM1u1KG8ZK0GVys0wHa72IOIPmOKk2BY6xOgr/8AEf2x+4dmdaKNHM/PcWIuoPQ+mfc3SsNuwpw== X-Received: by 2002:a05:6402:354c:b0:43c:2cd0:49bc with SMTP id f12-20020a056402354c00b0043c2cd049bcmr10446040edd.48.1658909972039; Wed, 27 Jul 2022 01:19:32 -0700 (PDT) Date: Wed, 27 Jul 2022 10:19:30 +0200 From: Igor Mammedov To: Huang Rui Cc: anthony.perard@citrix.com, qemu-devel@nongnu.org, xen-devel@lists.xenproject.org, Trigger Huang Subject: Re: Question to mem-path support at QEMU for Xen Message-ID: <20220727101930.66ed56e1@redhat.com> In-Reply-To: References: X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 26 Jul 2022 15:27:07 +0800 Huang Rui wrote: > Hi Anthony and other Qemu/Xen guys, > > We are trying to enable venus on Xen virtualization platform. And we would > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > options on QEMU, however, the QEMU will tell us the "-mem-path" is not > supported with Xen. I verified the same function on KVM. > > qemu-system-i386: -mem-path not supported with Xen > > So may I know whether Xen has any limitation that support > memory-backend-memfd in QEMU or just implementation is not done yet? Currently Xen doesn't use guest RAM allocation the way the rest of accelerators do. (it has hacks in memory_region/ramblock API, that divert RAM allocation calls to Xen specific API) The sane way would extend Xen to accept RAM regions (whatever they are ram or fd based) QEMU allocates instead of going its own way. This way it could reuse all memory backends that QEMU provides for the rest of the non-Xen world. (not to mention that we could drop non trivial Xen hacks so that guest RAM handling would be consistent with other accelerators) > Looking forward to your reply! > > Thanks a lot, > Ray > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 08:59:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 08:59:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375972.608514 (Exim 4.92) (envelope-from ) id 1oGcsa-0004ZW-7o; Wed, 27 Jul 2022 08:58:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375972.608514; Wed, 27 Jul 2022 08:58:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGcsa-0004ZP-56; Wed, 27 Jul 2022 08:58:56 +0000 Received: by outflank-mailman (input) for mailman id 375972; Wed, 27 Jul 2022 08:58:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGcsY-0004ZI-1n for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 08:58:54 +0000 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [2a00:1450:4864:20::12b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 564c6e8a-0d8a-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 10:58:52 +0200 (CEST) Received: by mail-lf1-x12b.google.com with SMTP id q23so12940239lfr.3 for ; Wed, 27 Jul 2022 01:58:52 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g16-20020a2ea4b0000000b0025d55600855sm3802691ljm.25.2022.07.27.01.58.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 01:58:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 564c6e8a-0d8a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=tUM6XkTEVuhSGjq206ahZtlJP5+K+IK66plJSJOZ1eM=; b=jTwOcyEUZ9E0NomN1l7hB/vxr1AMLBjg5igREYUsw9wuQnjrRttzxG4Cjp20MbOX6L A/icpM5RF8/MKk8X/FPZaOYuDpiRuaMPyN5p1cRLgaEqcUlD+g7xwq2tbDh0jjBNgyXV ZX57G8Unn4zcBt6itMCwSY6wu57JgXH9apLC9YWNsY4fcYAuVZhHsX2Qd9AdVLQMoxdE 9Ju8RqneuFta59xLoO2COVuDdanHxopimsMP1QLvZo9znlDj/xFyMnngeJYVEE4kOvLe +I33gI6xZzFY6ehwD2xnRUqXI2Vj5fZSDilTqQWuEyebnDCAUzbegyNkmGhVdOw/AtUC zCfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=tUM6XkTEVuhSGjq206ahZtlJP5+K+IK66plJSJOZ1eM=; b=mubgE6SV/oacMRdAh80tSztyQboTvWzmYfhQLJj9OSdSZOSDaW4kiK14Pa6TbwLJ0/ /jHvj4e4T8k42gYVpwZMoHzH0xFFrwfQcvPId6oDB1Ug5/bef71kh+yppnSNFM5zWVX1 QCm+jCmlH4uoPzW2W3zKsT0mOEFSRMV5kejLq0DcKS47ZbYBc0i3qoXLzs2yuAYbCOA6 btc79RJUzSvI5zhq6Br8MHW7i3n++zGRnF66lFPaLEi8qpuCxNg0gXSf0j6ByDlg0abO wNx2NuVLJ8nnvR77r9QHBqW9gNYRxTFLEaehf/bimER9/I3riHWeFXg0NPA4aOeICf7d IapA== X-Gm-Message-State: AJIora9+8gFHFh/cVhh+SNoIJ1C17ea3ANt5i5UKT/p64gzA1yUppT/W FXj9e0BUKcKiIIOWB7pfuk8= X-Google-Smtp-Source: AGRyM1s+Kc2V1FWbdqBUptnBy430WNdkRpgddDknrNfymmqs/N+JkW0rl1Z282qoip3nEzpYtAv8KQ== X-Received: by 2002:a05:6512:b97:b0:48a:781c:8901 with SMTP id b23-20020a0565120b9700b0048a781c8901mr8737043lfv.193.1658912331843; Wed, 27 Jul 2022 01:58:51 -0700 (PDT) Message-ID: <450660e2-69cb-ea3c-2d91-4e671eb5d552@gmail.com> Date: Wed, 27 Jul 2022 11:58:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-9-olekstysh@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.07.22 18:23, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> From: Oleksandr Andrushchenko >> >> Reset the command register when assigning a PCI device to a guest: >> according to the PCI spec the PCI_COMMAND register is typically all 0's >> after reset, but this might not be true for the guest as it needs >> to respect host's settings. >> For that reason, do not write 0 to the PCI_COMMAND register directly, >> but go through the corresponding emulation layer (cmd_write), which >> will take care about the actual bits written. >> >> Signed-off-by: Oleksandr Andrushchenko >> --- >> Since v6: >> - use cmd_write directly without introducing emulate_cmd_reg >> - update commit message with more description on all 0's in PCI_COMMAND > I agree with the change, thanks, may I please ask can this be converted to some tag? > but it's imo enough that you also need to sign > off on the patch (and this likely also applies elsewhere in the series). I got your point. Regarding the current patch, I didn't make any changes to it. As I mentioned in the cover letter [1] after "!!! OT: please note," Oleksandr Andrushchenko has addressed almost all review comments given for v6 by himself. For the patches which I had to touch I added "OT:" to the change log. For example, like here [2]. I will consider signing off these patches. [1] https://lore.kernel.org/xen-devel/20220719174253.541965-1-olekstysh@gmail.com/ [2] https://lore.kernel.org/xen-devel/20220719174253.541965-8-olekstysh@gmail.com/ > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 09:10:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 09:10:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375980.608525 (Exim 4.92) (envelope-from ) id 1oGd3x-00072a-B4; Wed, 27 Jul 2022 09:10:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375980.608525; Wed, 27 Jul 2022 09:10:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGd3x-00072T-8N; Wed, 27 Jul 2022 09:10:41 +0000 Received: by outflank-mailman (input) for mailman id 375980; Wed, 27 Jul 2022 09:10:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGd3w-00072J-Nz; Wed, 27 Jul 2022 09:10:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGd3w-0000Yw-9n; Wed, 27 Jul 2022 09:10:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGd3v-0005y8-4H; Wed, 27 Jul 2022 09:10:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGd3v-000476-0C; Wed, 27 Jul 2022 09:10:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TZGyeJDAAaGh0nnAYBRgGlBAQHF3y1BRxzJiqMnN35s=; b=NadYWBeoSWFFpFkoC2j9rewRgt 1jySgYJdIOpGcvEz0Zdmwshktb8UjyQsaArh/4YpXxDYw7PRYmRdyJJMemZqteGiXAAX4f9rDvt3r dG0pM2KlQ0flEQxC6UX3MhFTl4mStJumCnIa5edwIIijLFYZMYcXlcYnBHscGnyNynm8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171871: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=5de64d44968e4ae66ebdb0a2d08b443f189d3651 X-Osstest-Versions-That: linux=e0dccc3b76fb35bb257b4118367a883073d7390e From: osstest service owner Date: Wed, 27 Jul 2022 09:10:39 +0000 flight 171871 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171871/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171847 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171847 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171847 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171847 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171847 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171847 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171847 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171847 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 5de64d44968e4ae66ebdb0a2d08b443f189d3651 baseline version: linux e0dccc3b76fb35bb257b4118367a883073d7390e Last test of basis 171847 2022-07-24 23:42:33 Z 2 days Testing same since 171871 2022-07-26 17:41:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alexander Gordeev Harald Freudenberger Jason A. Donenfeld Linus Torvalds Qi Zheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git e0dccc3b76fb..5de64d44968e 5de64d44968e4ae66ebdb0a2d08b443f189d3651 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Wed Jul 27 09:25:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 09:25:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375989.608537 (Exim 4.92) (envelope-from ) id 1oGdIH-0000GZ-Ls; Wed, 27 Jul 2022 09:25:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375989.608537; Wed, 27 Jul 2022 09:25:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdIH-0000GS-Iq; Wed, 27 Jul 2022 09:25:29 +0000 Received: by outflank-mailman (input) for mailman id 375989; Wed, 27 Jul 2022 09:25:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdIG-0000GL-Kh for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 09:25:28 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0b73eac2-0d8e-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 11:25:26 +0200 (CEST) Received: from mail-dm6nam04lp2043.outbound.protection.outlook.com (HELO NAM04-DM6-obe.outbound.protection.outlook.com) ([104.47.73.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 05:25:23 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BN9PR03MB6106.namprd03.prod.outlook.com (2603:10b6:408:11b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 09:25:21 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 09:25:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b73eac2-0d8e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658913926; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=1Ghs9AO0+gGzUaPsy9UZGxgKzDe5BU0R3MyrsQB1VSk=; b=SOIJPDsOb/+0SKO7u/FeN68i/X248WaGPtzLuJttyzsjpf27yR+sWtH5 /gTjx4SKUDyg05FAN3qLMMHIQmDhytQgGlJ4q+6U1wvNgyVLeAdVPOi26 6JRceqaH8ypjSnmuhXXMwMlybjj4zikuvT9ji3UbtU7M7H5+txljgIYXe s=; X-IronPort-RemoteIP: 104.47.73.43 X-IronPort-MID: 76720124 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A6+Gx56m9XGS2/OwoGW1tM3zo5mJPLRPZYqRN2?= =?us-ascii?q?KgSY23mBrAEGkRwzqurT4snDBXTOmeg7fBgWQLCS5ckCjuBDOdex8xwGmv+V?= =?us-ascii?q?29XL6G/tmIvGER1spMmSz4xVfEB7nonVNn5MgVOlYfhK+QZqYlBIE+gIC5l+?= =?us-ascii?q?F5ZSHNKJCbWSwj/uaQ4D4GHIGafWdo74Yy/mtwhxDoB8MufO+2rJ8l4AT8/V?= =?us-ascii?q?fixpta73PXBDsZPST2Rsz5LLqnfLqcJS1R+w9wVKsyBhPymz8mOdlEDknKU5?= =?us-ascii?q?cAmGVBZHXcH0eBv7ZkPc9Ruof6AxcOKgeqtS51nU+1PPnQEwabEJV2DUzPLK?= =?us-ascii?q?Qs32x5/d5XGq/kPzq0VSmk4HTuqUIizOKWZxYr7ZNYha7BMZXtGVBBTXfK17?= =?us-ascii?q?p8Dc1zRcbbJtZB9KyTd8PXMyCDKN9tkaqx8U9yxXD9sZaLDJUUUv8beJyy3O?= =?us-ascii?q?Y74dD2hP1mO5h6eIZuOeKDkeyb8vC9k2yUm7BsCoftaz0ot61C5UGLbEHc1C?= =?us-ascii?q?iB2ASLVIwAMfoZtVOhauJUUgxJh1cQ9eOU3MM76GjxUD1wtWaxp7hmFYtlBX?= =?us-ascii?q?2bYMPCtkVf4PBQdR+q6dhzJX9SYI3kms/0lIu9c0VXrDgU5VSReosgfap6Oi?= =?us-ascii?q?0w3CtvayzvT55vTYmNvJ0eOanvONyDpcPXSEqeR1ppzuOH7CQkTXcv39WPKa?= =?us-ascii?q?ar2E+/wWocKEUj6NGu8rYmkBBGo4BwUNtSQPs53Imv3EcWYuWnztxuY9lV/3?= =?us-ascii?q?BHIjzsCmfbqXyC+4A6L8FDD+sD7Pa1oHuccmu8k/JFf8kxtADNzKAXgaP/oG?= =?us-ascii?q?amI0ZPKPILavXW2gjkvGi+YvEsaPczxiY7MqVOK05eJXuK3TeJopiSx3uzFY?= =?us-ascii?q?OgbwyoWgNrawn8a3j/8wXrzcTX4FJniG42x/zjl1vJeFjbSkcHVy/V2tBtr9?= =?us-ascii?q?jEkZZ7xFap+TSIRsgURXWPVYKIR1hbzgLO+kNp6Oi90N9sN6xKJzOrV41+MG?= =?us-ascii?q?zMN8KEzQJE8032+ColdILWdbmlEt0SnCLXBBhcI+/wEZWsHkZU8udI7d6Exf?= =?us-ascii?q?eTH1UxFMkwoVvxeHUww1/5VXtz0R6NdEevEphpioPyp2mfoBRvHu+0JqU+Y5?= =?us-ascii?q?7p4TrC0fLQoJasqkfvxdTmNi4DtWwX0fTDJvFI/idkMVZP5AZLMoIoJU5xLk?= =?us-ascii?q?mfBA5btnnLUQSHS7GucOMgXNwRrMVRIYs6ldk70iuRfJ3Tsvl+l8sSkhX//N?= =?us-ascii?q?z1OMOEzSAO3nnSCgXYq1GD21hmDIt/CDdnmFCLBYzLatZPYP+d+8v6YIhDLr?= =?us-ascii?q?SX5QRCxXOVzjxTcHRTcP9wYb03VOgmIWzhRwQ1lT1EPKR5Bv/Bj3QDyFZTxa?= =?us-ascii?q?WG6Du2uEhUfUIsCb3iiLOet8jx3eDyY07whySGM547VEFzsQoyefmPCLs6/j?= =?us-ascii?q?7xIlbbtTRHoHTaP8IJFdVNKaJu1TltZiKzhO1Mkgo7aLHJYf+d8Y4TNHJg/F?= =?us-ascii?q?qUZDepgZTASmAijuWNerjOpuJqCoEwk1fZ+sHGtSpx4rIbErKOOrAXetX4pk?= =?us-ascii?q?LKQBsCX7JiFK3E7cq2kK9Sh/0AyPwXnBoDID5on7YhXxbcQ/Xaa4MTbVYloB?= =?us-ascii?q?EzQ5gWGwEZ565lc+yMydHWbfLpdP1o5RbIfnV8+sStYRyeaAcsVgMG47nlIH?= =?us-ascii?q?u5tQU8qqMeMMwz3TGBtvBUH0VHqEX2wvAvnW2P8uIySF4L39LjdlsQSp5zS6?= =?us-ascii?q?7Pt2AhjEWgVpBw83BGlMu+zzYqKT1SXo59L9wnxQIVa0MQ2rdVGQjmPrXYO7?= =?us-ascii?q?k/NpCFnxtB5au8q6kmWCOAl/NzvwasS1uUoiVtWFIsWvUDy6DwoN7iAF5So2?= =?us-ascii?q?/VMTvKAl/DAkjKCA4b2k3HNe/mcEYG4+Ftc0J8mJh7XiP8V5/omFEKc0qRfg?= =?us-ascii?q?5obcqnVcQ8Pn9AU8w1jsHtbHBJOvEn8XTWpvovPTyIYMkDsEzjKwIsyG1935?= =?us-ascii?q?dvQvEWdk/mCr9HqEtN/g6SASD5BB1T92mehAsna5rU+IbuxiLq4I5aTrX204?= =?us-ascii?q?ZwYa6NHDs+Dk/3ypv0jR1HeAaJv5CXkLNy7PxehLZsA+EqcHMEnDJxIyB/fG?= =?us-ascii?q?lwzqzNNEp5k4C5w1YwN4v6tqnVO9h6V61xZ8gn+xbKBG0jc8sal9IpkzzOH9?= =?us-ascii?q?d+1ODn0Sh40R6ZwM1DxpeY6/XYXzYqY9ycmJz1gBIqFemOdAICBhWDFpzMNa?= =?us-ascii?q?6aPwqgmxWJBSZ2yMxVHj1YJ/jc62SsqwmScdbjuSpcee3Rkn2HjseO+tnP7I?= =?us-ascii?q?gZbRdTOcSVgayu94atkjFI/onuEgUL7VnFkEshB1gaP/hq7IYjtBcrwJqppA?= =?us-ascii?q?wCDYePG7Gf2EInnPhbwzb0oOafeVARAufJZQk/oD0nLV9rgMLMnZzJ6mJ1A2?= =?us-ascii?q?oOo4Dp1StKuZZ792ISXuooaT4ju5HaX8/RRPYIUs/LPvLZcq9GG+YSNsxaox?= =?us-ascii?q?GuPGwX7u/Nsj3sIUAY0ZYRm?= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76720124" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrcCCp/Ivh+mWoTAtcI0tuc9p/xmFkjJetxV8oKjmtgxHpmTBEDRQqHkcbSfnwmh3XzHPPWyBkwvle7iES8xxywnroPzXbCFAPCcxdPIMu98Seces8Mlqfiq0rFJugIOFOFCRVfm+Bou7TcJCw/ciWIkzFQTE4e11jHCu0ua9Y+OISnOyKJg0ALexHAUMChcZbUjDMSxnu90eAwm6aamb/lJVPxGt7LK0IR36qC3fFd6nUCLv8IHdPXVjJxhOLA2mqlUqz2AZoHlxTO/mcvVrZ0zgjs6RlQx2gE2m6lNCGx8+ud1YmaCVaO1NNLV7VjJxRIgiwuS2+5fi+RnUzsOBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1Ghs9AO0+gGzUaPsy9UZGxgKzDe5BU0R3MyrsQB1VSk=; b=e7RiPTqSrxRJ2BhPstc+cLB7uReoCR/DELggTLEpqwiAWRHhmzsgiLZUgQADSJuRi2yPlxlkhSeWRKM+BCUEVmE008UTOIF7YutyYUvnDzcaMVRJpGJsZF8bjzcXwUjaYNMU6pe+rHaWI07AXSm5Uh+Eg+XGZnHk0LONsbO6OLnP4qXA7hGrBxyQ8iF1lS2jPbi+A/nH+u4D97QCnbJDjYCr1sMxX/Aqo9uOsAlVDH1UVux6UiaCiJripMEYTH5Xi36H2IDw+AKrErm/eAf+wa6BG4dotSBboQvfkU2HVNA6oa88cKt8XQLVVYPy26vwiF+mM6xkhIgemLqah4GFOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1Ghs9AO0+gGzUaPsy9UZGxgKzDe5BU0R3MyrsQB1VSk=; b=aeY2SNykzHSiqU4rVjreOyRCdw5xbmGATCi+fPDrjXnEQBUQPoAaoR64a4zZhxn2LE8r+97UOlu5JR+pHy627JxstHsFCBADDKT3Fw4z+CeAzHVgHdVTZ3qctTj2tRdgDAsM7/IOLwZLg7W0TErPgpQ+a5NYht24bYCTXB1GN1M= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 1/8] x86/shadow: drop shadow_prepare_page_type_change()'s 3rd parameter Thread-Topic: [PATCH 1/8] x86/shadow: drop shadow_prepare_page_type_change()'s 3rd parameter Thread-Index: AQHYoQlKUZG91kJy+0mCRkr+mGKzn62R84IA Date: Wed, 27 Jul 2022 09:25:21 +0000 Message-ID: <2b1230fd-bd2f-6905-c99d-5ce7ba10af42@citrix.com> References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <50abcb9b-8f69-0789-5f12-c422ff71c3ac@suse.com> In-Reply-To: <50abcb9b-8f69-0789-5f12-c422ff71c3ac@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 52d353e1-0af8-4425-cf66-08da6fb1edae x-ms-traffictypediagnostic: BN9PR03MB6106:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: y6Rtop5V1vfTNgcxEOWtEMl0H9HKEJs0RG1EgO9cyw+AEGaW3+aG+0H0krCcKKd6Lo4kwmfUW+01HQCjY0yxZn73QFmf0SuGaM9lY/3LrXwb8+YE75FN1NP2/Mksov7MjPX5IIZ55QwUlOkQF5lkT6gU4PDBkVTzlxKUTCCDafgSFhNQW1gkXMU71MhxvHknfdC50/hjCIcHQXB33K+PSeRfe4jk6dxu5fLpbTo+LpHDJDEutHcb5deMSxwGOkhN9S1RWLTirMWk6DHvYvrxnmURHNGRwEB2IcUHsy30MNBNWqCW6kYa6qsXnFSQJA0wTivOtkMB8ehryMVt1EpFHXhIwwB1p6Md2VClvT4V8J44g8O1bVI+twbGnSsnXh/lrF2ZijjAchEo0O3uOlzXQ5h8v63Ob627I9/d7oT5OZV+K1H9VgzEqGL5s6bsiS/VzB62U2vb7Qs3xRLU9hbTKsArgJapLkAO+HDKlRm+gud/n7OjSMVxjm9X+1kdxVBumkzG9oRo/WSITiQ81km8mPuI3qJc9jooHgvQu+lwlxoICmmgfPplfmDXeAlgVsZ3QyIuvFf3u4NPB6Wv5TvQJu14l3xaoBlLFBHoPZ9bvRF9cug/adwpMA+XYfSXz7o4ed2+OfL5w8LLElv1l4bpi1r1ioNZwKhG3fHbMfcI+j2B2te9bbkDtUZm1/6n5/2RfY+NccTo4XJCHFO4PCLOBbYYUA7QTlRvGXrL7UN7YwiMEA7fdfAOVIU9u3Vg83vE480NxORNrKPp46jM8f92cUYOXmU8xguoVs/FyUDVz+pUExuMnwXgBB0EfG128FT5dqHnM+NZO51VQh3HnEBzIASvBdwF1cHtsCTp9AU20eGEX+Zs/r8HijX6OiGu2oqg9Hv2QD8SY5ARrLMFlIxppsRPRjrz0aKVkXD4KPiB8QY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(39860400002)(376002)(346002)(366004)(53546011)(66476007)(66946007)(76116006)(4744005)(66446008)(4326008)(66556008)(64756008)(6486002)(91956017)(8676002)(71200400001)(8936002)(478600001)(6512007)(26005)(5660300002)(82960400001)(31686004)(2616005)(122000001)(316002)(38070700005)(54906003)(38100700002)(6506007)(36756003)(86362001)(41300700001)(2906002)(186003)(31696002)(110136005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?V3kzMHAvNGVQY0c5a2VEMmxFVG9rTnVHWnZZUGl6WG5udHZxcy9lSFRJWkFl?= =?utf-8?B?QWNQb0NkS09WaUY1amhCWjZtcEM2dHZVQ2pQZ21zTXJRME1NeTJabC9NaTlU?= =?utf-8?B?UXk2QkhsYzQvYTgrR29uM0FSM1hYUFVpb1JpY2ZhdWVFVkFIR2UyMmZVUGpS?= =?utf-8?B?NTY3R0gxbHFPaHpKRFRtNTBYK0VoRW9FVmdXd0djdTZNanQraGU0eFhFbmRQ?= =?utf-8?B?a21kdXpiS2hEMjQrQ3NKRnNZd0dWQ0prL3dPcUUzZ1d5N3RrWkNyRlBRNGVR?= =?utf-8?B?cDdZWGpQQXYzbGVlZVlhV0VRd2d0eDA2YThjWjBGU3lBNVVyZDF5UlBPakdp?= =?utf-8?B?MythZHpmcDVVYURJNERmeSt2L1RWcytHWVYwM25uWllUSTZyTzFDbGdRNTVi?= =?utf-8?B?alJTNTZIQ3dSdDlyQXlkQ2VOTXl1elpiWjI5YkFWVTdxdHE3alREVmpOR0Rq?= =?utf-8?B?bmowY0tUcW9zVHRZLzNyZEtDZjI4Qm51bSszWUcvWVBYM3pNbm53ckY1bXBB?= =?utf-8?B?bGs1QUdMTGRMMjNDRVdXRVVsQ1p5VTJ0SGhvNVlneTdCbm93SmFWYWs4UTM2?= =?utf-8?B?dEdacTZnZWtwaHlqanRuZ1M5azZVem5CaG5zYW81dDF1M09zSmlqeFNNMkpx?= =?utf-8?B?ZUdnNVJUeURURlhmNlJvcU1iL3N6TE5RcUdONDlvbGthM0JoZnRvNE4rWG5w?= =?utf-8?B?cTg0T1J2UUxLeVNyS05HVHoydTJPWlNyN3o2SHFGaUY3dHZkTWVCZ2RUak84?= =?utf-8?B?TlZYTzNyQ2Y4dTNKQk1tZkFvU1Q4S0tQcTlyclZYRWNEQ0V6N1JJZy9XcWQ5?= =?utf-8?B?djdUbjR4SlJiWkpNai81ZmE4clJIV1IzRCtUNmltUUZwR0JXbmpzV3FZMTFr?= =?utf-8?B?SzVBd0JzcTBpYTJTSHlwTnRyR1pPNG5LekkzSndoVzdBQW9qdHp0NnR2ajVo?= =?utf-8?B?MXZNNnBpUGlNTHRWNkRnYzRJSHVSeGE0ZnVnZW43cGFpNlFaR3RnQ3J6N0xs?= =?utf-8?B?TEQ4eU1qajczMTYwZlZtQ2lSeVJUcHJxeFVQc25yR0d4UzRzc1pDdjhQNFhP?= =?utf-8?B?VjgzZ3hSMUVGR3dUd1RDcXJ3aldqOXJ4SVRSK1prL3d5YnQycXozaktBUUV5?= =?utf-8?B?dEtRTThXWnc0VUU0a2V6Q1BscW04QlR2ODFDRDB1Sk5RSERsS3YyZHdnamFU?= =?utf-8?B?RjdZN0prK2Y0Y1FCMWdDU1hHS1E0STFycUxTOWJ1SEhkQzd4NGtUNHpvcXJ0?= =?utf-8?B?SGFVMVNiV0piRm9OS1dJNDE2bG1oblFRb2I2R1AxcFNLcXlQdjFRejdTSTNr?= =?utf-8?B?MEtmbnBJWTh4TWNHb0pCWEUyNlgzNE01N1NGRU45Y0ZHQ01tNC9TcEh6M0hU?= =?utf-8?B?cW84N29FdmRxdytGY2RJM1E2SXM5TGlDU0pNSTJMRkltM1laMlVLK0JZWWJ6?= =?utf-8?B?eGZCMGQ2Vnh6cjIvNlk2eWE1Z1RsWGVrRFR4RmU4Zm9PQTk1ME5oOXMwU29r?= =?utf-8?B?bFZRakVNVC9LL3NwYlRYV0JMYzNjRE1vRDl2cXM0TDB1NHMyQ1FqbkUwZjhN?= =?utf-8?B?VzNDWXptNHNDQnkxano1eTNyeFF5Nnk2alk2T05OV2NEUmRGWFpVZDZZTFd0?= =?utf-8?B?UWwzWENKY3ZYdEtORTYwOERUZkp4Tm0wM0V2dEZ3TFpScTl1R2hncE5JbVo5?= =?utf-8?B?K2hXbk9Ic3dNUzJQc1VlalZCZm5RVDRNY2VSZlhPakdKWHdTMmtCdGtRVjFZ?= =?utf-8?B?WTFNUSs2YWhIbmw1V1F6K1RDUERYOTVwc1BXOFZ4ZVNrRVc3QWIvZzBzR1Bj?= =?utf-8?B?MGtVcWdra0JESnFEbU9sbnRlQ0VPMlV4TlJhQ3lHQjNTTUdjbVFvdEc3enJ0?= =?utf-8?B?YlVSbUtQT2habUlsZEtrUVVmTWF2U1BrWFZkNGMrREdXZEZLSW8yNk9FNG0z?= =?utf-8?B?SkwyWkxBaUpzdE1mS0orOG5DNElTamdISVhsdmJZOElOSHV5STJiUC8vWU5Z?= =?utf-8?B?Tmk2NXpJZndDbUNyU3h0UVlrdlBjSi9IYmJHWHhtZ0FpcHVNaFd1N0ZsUE4v?= =?utf-8?B?VDZ1Zys0TUpMTFIrZWJLSnpoTHgrZnZhL0VXOXZYRFhCOHJUQVV2Wm5RcFph?= =?utf-8?Q?ADiePl4SFREM8RrX6+cg2w/Mg?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52d353e1-0af8-4425-cf66-08da6fb1edae X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 09:25:21.3272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hQjrP/Nclidgfe8fRkY8wZn6pWKtEFxggQ7lWRwaPdTc7Eqdf3BCocvkZ6wc5wq638YbSmkfA+5W60ExQgVN618AJbRHO0m/HOrxdgyNrrc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR03MB6106 T24gMjYvMDcvMjAyMiAxNzowMywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEFzIG9mIDhjYzUwMzZi YzM4NSAoIng4Ni9wdjogRml4IEFCQUMgY21weGNoZygpIHJhY2UgaW4NCj4gX2dldF9wYWdlX3R5 cGUoKSIpIHRoaXMgbm8gbG9uZ2VyIG5lZWRzIHBhc3Npbmcgc2VwYXJhdGVseSAtIHRoZSB0eXBl DQo+IGNhbiBub3cgYmUgcmVhZCBmcm9tIHN0cnVjdCBwYWdlX2luZm8sIGFzIHRoZSBjYWxsIG5v dyBoYXBwZW5zIGFmdGVyIGl0cw0KPiB3cml0aW5nLg0KPg0KPiBXaGlsZSB0aGVyZSBhbHNvIGNv bnN0aWZ5IHRoZSAybmQgcGFyYW1ldGVyLg0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGlj aCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRy ZXcuY29vcGVyM0BjaXRyaXguY29tPg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 27 09:46:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 09:46:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.375998.608548 (Exim 4.92) (envelope-from ) id 1oGdcf-0002zw-Cb; Wed, 27 Jul 2022 09:46:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 375998.608548; Wed, 27 Jul 2022 09:46:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdcf-0002zp-9K; Wed, 27 Jul 2022 09:46:33 +0000 Received: by outflank-mailman (input) for mailman id 375998; Wed, 27 Jul 2022 09:46:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdce-0002zj-CF for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 09:46:32 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2046.outbound.protection.outlook.com [40.107.21.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fe03e741-0d90-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 11:46:31 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0402MB2761.eurprd04.prod.outlook.com (2603:10a6:3:e2::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 09:46:27 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 09:46:27 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fe03e741-0d90-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jy43txEGITCCYPiwniR6t1Ln2fQ+LKC2dQa38N7ClvL1KQCW1tc5XW3jZFCInv5pnMjaVebuXO0aU3Its9LJUyxf3cCXGxHWdGKbDqY2hGswJCj41E/1ud01VccbbB754ECg3TDGKXwxhHxS+OgU1yY2np7WHmzKREq/5txMBuyDqwVWFMvxp0Ioe0BTRdTUpl1kJCiL8odiJwWC3wGuh0WpzsBNRRz5FdyWgzCQP1LY643Y6v54amyT6EMtfHWghgbItGy3jXtYWvM3kIpLmr5QzcrjbS3gp4jvibIU8T3vlkFhoF1a1CBAWcn3Ij47Dt/J3TXhcHNzdMgAD5isAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/Xt5HD5Ukv10fyymRJ5SNLoHRutJlWLCUTfphG9cX24=; b=hBm5gFDkeqGhBmffuQ3/dFGfXMYNUtZX5G5AEHdIV/LzxE/5QsYZyBvBXe/vnuCh5/k/EycUk2EKMpC61OqsHmZJcOeJ+Fi7RDFmQoZwZyvxqL0R+2nHyM/kh7Kie6MjWFrejhdv21gsuw+fj1+USC8VxEcrfqPKzUG9zwjtSJj/Y085ty30WOXEad09nZ1JDgdVLXSwfRdNlKTzjCxPMXcr3b/HaAJVtX2xIdSh1lagSKcqYrscwh9oMPqETG2A7alKe0pGk1b2eSAQcJWU3s6+2cCGLrO4P1sfhOHV7xaxYD9ClROl2wd3GziLjbVN5JW3VGkFlWOK4CznN9Ip2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/Xt5HD5Ukv10fyymRJ5SNLoHRutJlWLCUTfphG9cX24=; b=Cwgd4+f0PrBEZU6egsMuK4NQBaigXmdOQ3Ng/Yfsymz3dFqx0V/G5svsaJur3gYbr9AbC+BTzSBvNz/hcUJTdTPHfwx9C65gyNux78Ay/ykagekNOZknygwFzki2yeh3sEYvr2MSZg46K8kD1lSnjrC+Nq+8Ja64JqPf63YGSkBLb4716oP73v65n4Iy44G57wgwY1CVvIRUxBj++xQmZIxf/rhYw5qxPYTMdH68mWGzczYRJlGyAWxyDuxFlFNeoB0BNTGlhyEYyggkbAvdCYG4pa9ZIeYAZzSYlmiKIMCPSexd9h1MjHVGdjmzGBtRzrA8s2nCdR3+DkyIW0DWBA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 11:46:26 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-9-olekstysh@gmail.com> <450660e2-69cb-ea3c-2d91-4e671eb5d552@gmail.com> From: Jan Beulich In-Reply-To: <450660e2-69cb-ea3c-2d91-4e671eb5d552@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P192CA0054.EURP192.PROD.OUTLOOK.COM (2603:10a6:209:82::31) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e4f3e2d6-36a9-41e9-0f8f-08da6fb4e049 X-MS-TrafficTypeDiagnostic: HE1PR0402MB2761:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MF9c7+84ArIFMPCzi/vwumLMuCuCEKOKJkDTq7Tfu59Zho6qspC63JX0Ec7tEq5qUjHdSDKVh4nZ4HhnjENAumVrThKqV/u9LW/hzxgaB206b+uiUuwCKEQCvIbhsyX2LcHqGJkp+KNkvHpYvDvSjot+MJ+DWaJzQXIh2fB9+1QV+vVrkmwz9k0Q9z5Omzs/M+f9Foi5e/K1Ve6U+2kRqIPWgAKOztyEN25xpDjSw1YM4Kgg0gtkmsxSJlxJxsSOrNLVJRgMMN3ciJHwt7FnxnvhyZ5VGitELsHMVp6dXqOtCgBPa3bTrhBaTsHQVTxolMpVAhu/DDTzT0j+anp+hiI+yTwM9bs4PXYI5lPOypR070z1f2qX71KYLISXJv3ErkIFFYSwrmYnhSWEzmavG2Rl8s2xo/aDBXJqJc/l5BVhvsNIxiQ0uvrsiBz+4HHBeHt6qLSCMNAjEbZ70hfrp+qT7Pk/wipQKBtiT8r6Wonyf+pZue1/eOvmWY8vjGEZzPirclyc4gFIikOedrxT3EfqAsD3HD6CBs9alXGndA/QShSjAWkF0QZxcbC/Sr3/05AvumWaO8CwZzmCY8cfG1BhDyW6wo6q5Lj2/f3GbW063WwJw5fEMFj82P1KBZs/KZHkYQcoYIBXdwymqUik9+vBv8xVp0lw7GXnFfptfPVAwjdmKP1g91F6r0GHYxE4rjhaQKKJSqzIY1gsR9wOkIo4aRm4ZHwMDlnVpMTeHD8fii92RZ7y+Vt2bKyGdtzvNYPA8mDcjYHuwZiubEBHplBgBq1Dq3kaHyOZEg+H4ZJQu+bleHGrlLgstk050RUyRjvfi8vyBDq+/eZY4rhKBA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(39860400002)(366004)(136003)(346002)(4326008)(8676002)(41300700001)(66476007)(66946007)(66556008)(8936002)(478600001)(186003)(5660300002)(86362001)(6486002)(31696002)(6512007)(6916009)(2616005)(6506007)(54906003)(53546011)(26005)(2906002)(83380400001)(316002)(38100700002)(31686004)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0xrRmtCSjdvQllmcnRKbXc0Zktwc3dRTis2bTQ5T3RMMkt3cGI0VE9HNUww?= =?utf-8?B?R1JxN2paOU44K21RMzNsb2QzL0xnSlBtMkRTOUlxNG5qQ2YraTROUnJjT1Vs?= =?utf-8?B?NlVnVUgrQnBPeWgzNi9ueHB4NlJTaWRKOStXNStnazBzaGZhS1p1UFQ2OXVG?= =?utf-8?B?R1FDVGo3TVZYSS9iTC9qWEROeDdKQmFiMi9hWTZ6TFRtSEZ2Ky8yeHV6NHNu?= =?utf-8?B?R0tTTWFzMlZERlVaTEpyN1BBYkpGbkJQOGh0UVZSc1Zsb052dm52eWFSa2Rt?= =?utf-8?B?Uk1NSGpBWGFaOCtmM0FvMERVUXVNT0M3cnRqWGFTSUlsakVuTUljaC81dm50?= =?utf-8?B?dnRxTUpIcXphdGN0Q3JHbFZROWhrWThEU1BCSHdINTZqT0E1NnRKS1IwaVhP?= =?utf-8?B?cTZ0T0lLRGZxV0FyUlYxaG85aWtwR2ZtdjFDRjVtaTZLczlRWFFwMzZITVNh?= =?utf-8?B?dkJadC8wVWNYcTNieC94OWhROGJ2OFhWVzA4KzZpclNnY08rMFc3dXRQelQ1?= =?utf-8?B?clpRa2VHUFJoMUFNMklvQnVRNnIrVGZXU3VkNUpqU3RtVHJ5bkE1MVZacThi?= =?utf-8?B?VFhVV3JoWW9lemlXWlhmY0R0WnVmTXlEUkNsb3FHY3JxOTd4RCsxR2luWGhP?= =?utf-8?B?dGVpMzR5bWxGUE5IQjFhQXY5S1VLT2NZZmZocUVaVUNKZU9RemVGbDJrUndx?= =?utf-8?B?T0U5aXJWelRNMzRjTVhlOE03SDN2bUZieXZzOEtuTWwzQjlyU1JBQm9naEd0?= =?utf-8?B?VUlrbFMwZFBYbGUrQlNzSXVDWnlvL2RVSmI5Q2pwdDBlMEZSK2ZMV2xSck9v?= =?utf-8?B?OEsrRVI3cFlBTU1SNEtzYk1zc3ZyOXNQK201dllrNDFFRGpIN0h3NnJPREYr?= =?utf-8?B?eTZZdC9yNnBlM0xGNGQ1MlVsbjZYY3F1azVjbXZQMzkwbEgzYlZyNmxUM2pF?= =?utf-8?B?QTkxT2FrcHo3cldRSUc5YlByMkU2TVU5ZmROdWtITlE3aWQzOFF4UFM2b0xG?= =?utf-8?B?MkpoOGRnR3JVRUpoeS9WODJJNEw3OVJxbXJ4TXpCTXF4UWNBN3VRR2c5L2VU?= =?utf-8?B?WHlsLzZoQnlOZjFoeTY3c1cwaGM0MTdibFVJZ0VQVFMxQ1NXbkdSbEhRend4?= =?utf-8?B?bVRJTVVpRDlycjFlR0FXZzFIcVhBQUdhSnJ5T29xdVZBT08wZThMSzFEV2NS?= =?utf-8?B?VDF2T3FaQytaQjNhdG5CK1g2L3BTYURydVFSbHdMaDRLc1NURHVjOU1qZTc4?= =?utf-8?B?Si9zYnJGc3d4SmZqMW1OUlQ5QjhiZ3c2UUQrMnFSTG5RUXk2RVY0MGZ6NGl4?= =?utf-8?B?a3NXc1Y2Rlk2TkJYdWRWMGhmd0RpaGZEWGUxTHdaQVhSV056bUhjUGFaN2sy?= =?utf-8?B?MDA3T1p1RFlnQ0xVcFk3NE55Yi81dkNTZE5FeGpZd0J4dnMxckNZRlpEcnhV?= =?utf-8?B?MnBwS01oeWkvVkxhK2d2MVA0a21DbTl1dE4ybGpJWFlrSEtSVEJ5VzV0ZXR3?= =?utf-8?B?bi81Yk1WeDBnMlJSUWRKZ0hDQnpwUmVtRHFQbHp4bXIxRHBHUHY2MTZpUTRQ?= =?utf-8?B?RG1YRml2V3Y3V2VUMXJPT1NRUGpxVmgzeklMM3luMGYzSWpqWlhQNTE5RG02?= =?utf-8?B?RXludEVVNTFyVGJPV1FHZjFwQjJ4M3hNc1VCS0FadEt4WmxReDVHSTlRNDVC?= =?utf-8?B?NjNWQVNUbHJhTU9MQWpkOXJsbi9DTHdTRTlhejFwNnI2S0J4TnZ3K3lWL3lr?= =?utf-8?B?eW1MUVg1dlU3bU5iNkRxTHZpdUtNcEpBbEF4UTAwc2NhUEZ0cXRQVFFaOEdq?= =?utf-8?B?aSt4ZnFvNFRZMWxUaHY5TjlEN2kzUS9Gcm1VWDJlaFN6U24rL1FJVG5zWjhL?= =?utf-8?B?K3lkVlBVd2QwdGVwa0RVcXVhZnZiKy9YUDduNzJKU0pnS0FBa1JDYXNERkFS?= =?utf-8?B?TDRMaW9jTHVzUnE4aUorQzRud3Y5cXhzd1MvWHZQamsySWZrZkd0WE9Vdzhm?= =?utf-8?B?TDFyLzgwb1ZiZlNqWkpVUG1GVFBGajhBdXFOblJNUUJNTFBkcS9RODZ4RDFE?= =?utf-8?B?NW44REw5S0E2TU1HaEtVMTA4K3ZmQXVnd2ZoelBlQXZDSEhBWk9jVjRpdEpT?= =?utf-8?Q?i7Mlwd20QhN32dSVeBnOsucTm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e4f3e2d6-36a9-41e9-0f8f-08da6fb4e049 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 09:46:27.6214 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: be+QYab2PRwBwHMO71vFFAWBqWdpsibYIk0Qge1fkw1/B8U4F91AN45II6yyyk1LYB3CwmjrigGBArrV0SQUDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0402MB2761 On 27.07.2022 10:58, Oleksandr wrote: > On 26.07.22 18:23, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Reset the command register when assigning a PCI device to a guest: >>> according to the PCI spec the PCI_COMMAND register is typically all 0's >>> after reset, but this might not be true for the guest as it needs >>> to respect host's settings. >>> For that reason, do not write 0 to the PCI_COMMAND register directly, >>> but go through the corresponding emulation layer (cmd_write), which >>> will take care about the actual bits written. >>> >>> Signed-off-by: Oleksandr Andrushchenko >>> --- >>> Since v6: >>> - use cmd_write directly without introducing emulate_cmd_reg >>> - update commit message with more description on all 0's in PCI_COMMAND >> I agree with the change, > > thanks, may I please ask can this be converted to some tag? I could offer a R-b, but you've got one from Rahul already, so mine won't buy you anything further. What you will need is a maintainer ack, which imo isn't a priority since this is only patch 8 in a series which itself depends on a further series likely continuing to be controversial (didn't get there yet). Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:03:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:03:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376004.608559 (Exim 4.92) (envelope-from ) id 1oGdsl-0005fb-Pi; Wed, 27 Jul 2022 10:03:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376004.608559; Wed, 27 Jul 2022 10:03:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdsl-0005fU-Mb; Wed, 27 Jul 2022 10:03:11 +0000 Received: by outflank-mailman (input) for mailman id 376004; Wed, 27 Jul 2022 10:03:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdsk-0005fI-Ac for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:03:10 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60050.outbound.protection.outlook.com [40.107.6.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 509c539c-0d93-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 12:03:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4242.eurprd04.prod.outlook.com (2603:10a6:208:5e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 10:03:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:03:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 509c539c-0d93-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVIbKDcdUie00KiJyt4b9zSTO8sSKlBHdorAecxxsdap0Jxr/KogyPuwsjArp7V2DUOu9n56ek87wQGA6GFkINOLmNz/76nCe/vTWaPU/KhpLJK5CXr8YFYafzCtrTYK0vTyxHeHqmZHVBO8hq3K2GwE92sph0WG9lUp2QbBsI7204oAxY9bvyqL6lfBBHoUe6TkHYXTttpcisRhKhov0a3RP1C9qYRubyQJknOR6TMmjROAoC5y5xmNtIQU20/imd4Pp3iZI7Tiv0g248rGDwYr4gJ1Td/lIY3uBrG/hdyNPBFBKSboQ9ZOeIsLVU8+yz8kHz2CQBy18YWZVqdTaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=20WCdnFKcg8tMGaKS2EGRh5BbCB1Drrb+6HRMX83pUw=; b=Rr8IKWeUacH4Zt2Ers8amLVRL6BekJ0YxFmUB0gqSmbuAfysJfhPdtSdIFXrtnQShzrOIkvolRR4QhEpnqAKwJquC9CY+anh87c11z2uJmt+JngGuCQf93efgYidb7T+PBLmO6b44BXAig3dSzogvdHn68E36tKKnTQ6zIiCKjoioNGR3Md4yktoYExOe7HHDOXjd51GMjhHtWaHnOoIzey9hdG41iXdyh1S+a0IX9hr8V2Lr+3QgXZ+lkVJRM33/TTjz9CWy0VG2Jntho3OgiINbo2lYJuPpEcCXIeX0JGuL/vrKW50j/5YLEo/JFEqmOVyPi3QYSqm4yplVtxlIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=20WCdnFKcg8tMGaKS2EGRh5BbCB1Drrb+6HRMX83pUw=; b=XDD7ooby0VaZsNEU+B6ecJ7bnmNByjGigFJoz9a3Lig4FCym0Zo0xzoO66rEB7/hlgPoM5qTX0vdN5jwqYwUisHRtyYmLwBKcM1WdvCT06LX86SiAESQ57GGzNLmvVSl4zszJtmGGYISQeQYehdqVxOSCC4U2D+BAO85bjEiNwanqYbfG+pcXtlQuMqyqHWepsRT7azV4qscs0bX7/Fs2jW6WxshFg8OznsBDlBrzbMwKJWlanjmQSY9434rMy4DhUYoNSRomfR6PA8F+Y2ehE4O6YGI0AQzBgq7w1l9JHO6C+lvpbtriAMB/m8JRhzEUXpuQRL0M1gp/mvId/jTjA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <51afa25b-93ea-2685-b238-2edd9292bece@suse.com> Date: Wed, 27 Jul 2022 12:03:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-3-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-3-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P194CA0079.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:8f::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 37f97321-0281-421f-5369-08da6fb733c3 X-MS-TrafficTypeDiagnostic: AM0PR04MB4242:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4dS0O8CzN++9ZT602b61/ydcpyvNFumBRWFpt/ExvkZhhRqkUV91JA9Kaj5N52ojcWDGgUrHXGVlHg5kYg1NVLjyIKJ0SXsOcJr9PaZ4iCVvMoO8xQN54lPMbUfzji47Le+/Sauxt2lxPOea11szLfK+z0nf/xq/ZqvbBbNBhajxKvkNJDiBEGZLjxDX9yzuKvLzYyQVRaXG02Vtn6sdkJoXQdt7bq6exOGfhPYBAiXENu1PxYonuT64L/l5B87tja4gHcnsOIQAnQ0wPdw9AUtu0sRQWoODtv/klSIgASMFl+1D7I3mVoNkNqvn/dc5LMxV4xyjdO02uzXc5yMBFZISp1fv7dUKgCRjC+8msa19Xytvaj5fibB43mgB4GaZOc5/+x8tPEts5cK45B4BdHMBl84ColR+7Y1z2akbAX2Z1G5hDclPqVqQ5OAEzaxutqZlHKv20pVYlKk1rY66jVenyr6w8+TBtlD6iFw2slSXanG9XtyFMFeuslfRJZ1YTmSz4FYl2z/EvfFkPfPh0GDWeTLYDm9fsT3L4XKTZBKdkR3Thlrp6ZhofE3Xyx6VC8mt6aOvUrxDuUWyUbT1ZbpiJY77pBrz3ZNfEgE0d/65wnSN/2ic3IP38GStNT+J5AwGcBCM20zgNUnHRgUlDEh44bz9LqKpy4dZnGJn49jWCrlKpoHwcm6krJlWo64zfWeBxA4pMNcRqfww/XcLleTg+VNt29MaNS7U7D0qj95KPbEzWIvr8IGoS4lMcttTsIaA7t9JuTpfbyVNAWbnavSWE2ACfKYYug4cHmgDUwzFG/unkMVcLy6PKN3NcPclMk5QTTg2MaZ2XNH8fTOyKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(366004)(39860400002)(346002)(376002)(5660300002)(7416002)(8936002)(8676002)(38100700002)(2906002)(66476007)(66946007)(4326008)(83380400001)(66556008)(54906003)(31686004)(6916009)(41300700001)(26005)(53546011)(6512007)(31696002)(36756003)(6486002)(6506007)(478600001)(186003)(316002)(86362001)(2616005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHF6eFFtUmpTTDR1VVVwaXl6L3RVTlBYTWpjTU1wdTVxcnZPVHE2YTU5MFFU?= =?utf-8?B?S2RPd0ViZEtsNHBvaW1weUgwRURCTkUwbXRaRncyQXY5cWh0djNZbFhGMXp3?= =?utf-8?B?eDJTaWxnejl2TThrUDFtSzc1ZWVpdStEQmRTVlpLTFdGWWpPMXFpSHFVYVhW?= =?utf-8?B?akM4cEQ3Vk9NL2MvRDZ4K0NNQ21OcEwyZTJ5Q09KalFnUTgyY0hSbmZtQ2py?= =?utf-8?B?dDd2VG5qZmEvWmRNLzVjbHNxQzV5NGlMRlU1bWxPQ2xvSEgrcGZ1YUlXNnVL?= =?utf-8?B?T042dm5YVnFTYUJXUkdRb3lqMDVTV3ZKajliWWR1NG1LRTIzckRLNnZvK1d2?= =?utf-8?B?Q1hPdjVoOGxXblQ4bUhBT1pKUzRKRHFBeTU5ajhuY3FZQjcyd3c0WWtSQmNv?= =?utf-8?B?bFZyV0NZelFXZUNTc1hhbnNLR3pDT1JHUGVVYW5kS3ZXM3gxT2lnaTQzMkUr?= =?utf-8?B?VlZ0bzdDSEtGQTJINTFpUjJ5dGlQL3VITjFZd0hiTUtIRFhVSVdIcEVtSUN2?= =?utf-8?B?cVpYTkg1eGhwUWdWcytOVVp4QWZvWGJOVmZMVFVLK0paQ0V0U1M0SUNiU01E?= =?utf-8?B?MFFXRlA2bUUzOG9QRWsza2VJUi9FMFJoWC9vL2k3Tnp1RUpBdFRPeXkxa01B?= =?utf-8?B?SEFkY1hXYnhUN3RTWHBSU1A1WEtZK25Dc1NFbjk1ZzVidXR6K0x2QzV5bWFt?= =?utf-8?B?SlFEUGQ0djZoczZwUHpxZzFBNC9QQVljVzdHRDZkUnVnL2t2SlJCNWQyV1dS?= =?utf-8?B?NG5QYVkrR2tJcFJwRGV6VjNJcXVrb1pWc0VJRWZob1IyZklzMWdOajQwb3dT?= =?utf-8?B?WmlvdmtIWE04OUFEcW90K1NvYlpBYlkydmdKdThJMFFUdlY4QjBqR25xUVhv?= =?utf-8?B?Wm4vVlYxNG94ZEdwU1cyREhYcFE0RnpYK2lLa3pRTWthSkp3QlFoUnIvRjEx?= =?utf-8?B?QzhQY0toajhGSWRtZ2JLL1JsSHEzMnQya1JWMU00dGh4dUZndTE3bkgvMjA1?= =?utf-8?B?eXN2M3VocGNEREk1b3N1czM0YVg0OGFDUXFvWUJMNjJTWndtRTZFaGVON2cw?= =?utf-8?B?a1BQVzA3Z2E1blJJSjVmTDBvK2FLV0Z3TDZyWEFleW5tZU91WlVxZk1oNjlC?= =?utf-8?B?WnQ5RkloUzhiYngxeTNCMDVadTc2VHJ2bDFLaFExa2pTcmFlM3pjdW9oaWZu?= =?utf-8?B?NTB6eEp0QnBvUzhNV0o0MTVzbVpyUldaRDg1UUt1Vm43NzEvZ1Z1VC9zdThI?= =?utf-8?B?anYyQXRrS2FUSml5dG0vdVEwaUlob0VvdWZyWnhSTTl3RXptdlhBZ3d2NHNN?= =?utf-8?B?VVNIWnJNcTltaDRmSWhXT25HSThkU0xTbGNteWdQQVFCbys2N2JYRFUwaW5T?= =?utf-8?B?YUlKb2Q4Q2tFd0U5eHVFWHh6YitiNDJuUEpKbEduaU5wNUkyZGRXUlEvNnJm?= =?utf-8?B?bWN4R3BwT0xBeHFsOWVMeGpoeStOZDRhZnV0enZLM0lSZjBRQVRnbHhVd21u?= =?utf-8?B?MkR1ZHJjWmxHSFhwRzJENU1PZHB3Vk8wcnZ1RExLOG9QUVZ0ZkhVS3NCM2ZV?= =?utf-8?B?eGlqL3RpRHZ0NFlFelQ4Y2FjbjB5V2c0T1VQVU40TDJ0WVNPSHQxT0w0dlRr?= =?utf-8?B?Vjcwb2tDbVc4elNxSVNGUXlveU5lMWpkc0N1MXRJc2w5Y21UdCt4WHkzbE5q?= =?utf-8?B?K3VuS3NSdDZ0Rk1IM3FIbGZlWTUrWnFvQlRDODAyQjhVNndHZDZFMlhaMmZV?= =?utf-8?B?eXNCSWUxUENuN1RxSjlCVnlDekZwVThORENyN2JQRThTTWdjUGFiZVMwNUFQ?= =?utf-8?B?SWh6UjlQWjFndWQ5VXpRT1FkNjN0dUwzeHRsRFNKMkxoOU9nM0QydEpWUmFY?= =?utf-8?B?Zm43S29QZWh3QWszc0ZQbVlHZkZYeWZkdm92d3BXdkp3cm5FbkVTRWtlUWwv?= =?utf-8?B?eUFQRmJzbDNxcVd2MzRIK2plaUpPdk1WSlhqYlAzVUh3NmYrUXFjallnR3pJ?= =?utf-8?B?NkFDclJDZjNqdC9vOENEOWRBSFhOWWgxWWl0OFlnVkJIUkNqODNuSTJJNmt4?= =?utf-8?B?ZEFEUlJXdVIvN3MvN1hzdzdIYVZESUJ5VVBOcGZBRnF6RDdEMW1YNCtoTklI?= =?utf-8?Q?BVZT59/V8zCcOT+JnHYqLoAXX?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 37f97321-0281-421f-5369-08da6fb733c3 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:03:06.5889 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D7JqkHarF/wwRQFjXiH2CAHZzkK96y6Mta3wjpufRSnMbiebwXf1/yDoi/2iUudysk/f6/lrKBooO6gH9olf2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4242 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > @@ -1558,6 +1560,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > { > const struct domain_iommu *hd = dom_iommu(d); > struct pci_dev *pdev; > + uint8_t old_devfn; Why "old"? There's nothing "new" here. Perhaps "orig", considering ... > @@ -1594,6 +1599,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > pci_to_dev(pdev), flag)) ) > goto done; > > + old_devfn = devfn; > + > for ( ; pdev->phantom_stride; rc = 0 ) > { > devfn += pdev->phantom_stride; ... this updating of devfn is what you mean to deal with? Then again I see no need for a separate variable in the first place. The input (seg,bus,devfn) tuple is translated to a pdev, so you can simply ... > @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) > pci_to_dev(pdev), flag); > } > > + rc = vpci_assign_device(pdev); > + if ( rc && deassign_device(d, seg, bus, old_devfn) ) ... use pdev->devfn here. > + domain_crash(d); > + > done: > if ( rc ) > printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", This log message will want to appear _before_ the domain_crash() related output, or you will want to add another log message there. > --- a/xen/drivers/vpci/vpci.c > +++ b/xen/drivers/vpci/vpci.c > @@ -92,6 +92,37 @@ int vpci_add_handlers(struct pci_dev *pdev) > > return rc; > } > + > +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT > +/* Notify vPCI that device is assigned to guest. */ > +int vpci_assign_device(struct pci_dev *pdev) > +{ > + int rc; > + > + ASSERT(pcidevs_write_locked()); > + > + if ( !has_vpci(pdev->domain) ) > + return 0; > + > + rc = vpci_add_handlers(pdev); > + if ( rc ) > + vpci_deassign_device(pdev); > + > + return rc; > +} > + > +/* Notify vPCI that device is de-assigned from guest. */ > +void vpci_deassign_device(struct pci_dev *pdev) > +{ > + ASSERT(pcidevs_write_locked()); > + > + if ( !has_vpci(pdev->domain) ) > + return; There's no need for this check since ... > + vpci_remove_device(pdev); ... this function already has it. At which point the question is why a separate function needs to exist in the first place. To match with vpci_assign_device(), a simple #define to alias is would be enough. (This is one of the cases where personally I think a #define is superior to an inline wrapper.) Unless, of course, later patches extend this function. If so, the commit message giving this as justification for the introduction of (apparent) redundancy would be helpful. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:03:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:03:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376008.608570 (Exim 4.92) (envelope-from ) id 1oGdtW-0006BL-2S; Wed, 27 Jul 2022 10:03:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376008.608570; Wed, 27 Jul 2022 10:03:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdtV-0006BE-V0; Wed, 27 Jul 2022 10:03:57 +0000 Received: by outflank-mailman (input) for mailman id 376008; Wed, 27 Jul 2022 10:03:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdtU-0006B0-2T; Wed, 27 Jul 2022 10:03:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdtU-0001ca-0a; Wed, 27 Jul 2022 10:03:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGdtT-0000v5-JC; Wed, 27 Jul 2022 10:03:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGdtT-0002O5-Ik; Wed, 27 Jul 2022 10:03:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=4qcH6FaXy/TAqvYX7BUgZog9ls1ORI4zCTstWu2Cl/8=; b=xuR5Mxh0xqd73M8ZyVFyM2Ln2U uAjGWGTqKMoqLkSshsCKG/FBNr3sFJP6sraBGbTLkW7r0F6yd8nugqHjIlWZjOf7RVGiGncUjatzm J6SClg7h/nG1HbonqYtZE9yXhmTN/hw19cthmGYA10tGw7t/3fPZm36wwLBhesmiznk4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171878: all pass - PUSHED X-Osstest-Versions-This: ovmf=b68d566439683d0ebe60d52c85ff0e90331db740 X-Osstest-Versions-That: ovmf=7f1c89f16790fc2fa8bc88330dc896941b9b40bb From: osstest service owner Date: Wed, 27 Jul 2022 10:03:55 +0000 flight 171878 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171878/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf b68d566439683d0ebe60d52c85ff0e90331db740 baseline version: ovmf 7f1c89f16790fc2fa8bc88330dc896941b9b40bb Last test of basis 171858 2022-07-25 23:40:21 Z 1 days Testing same since 171878 2022-07-27 05:12:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jason1 Lin jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 7f1c89f167..b68d566439 b68d566439683d0ebe60d52c85ff0e90331db740 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:15:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:15:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376018.608581 (Exim 4.92) (envelope-from ) id 1oGe4J-0007rO-3c; Wed, 27 Jul 2022 10:15:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376018.608581; Wed, 27 Jul 2022 10:15:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGe4I-0007rH-W3; Wed, 27 Jul 2022 10:15:06 +0000 Received: by outflank-mailman (input) for mailman id 376018; Wed, 27 Jul 2022 10:15:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGe4I-0007rB-ML for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:15:06 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2082.outbound.protection.outlook.com [40.107.20.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fbca2848-0d94-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 12:15:05 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5716.eurprd04.prod.outlook.com (2603:10a6:208:128::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 10:15:02 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:15:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbca2848-0d94-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BwuctuR748CPoWeAkQR37So0HkDskZ1xqTbsRyQiVb6uka/y5J6lsZYFsEg5Qw4MN9LoZVo5ZS2bDfIIIjOuBkLjpMqd5uk3Vz7DPwQviyDlU7vVITbkvXLKwCSP5tP48Kt9Dv1NmsSAAfJpg9VxXEZQ6krHpCXFUN8goRFV5txiiS0Np7gtPfsoNmoVAT9Aw23dV4zwKQ8tHps1ZczgvVow/7C6q7sx/dRQYQoU/cZS/dAf0v8Rld8s/5wFt0gjeXy70uSJFLMnavf855c8qQL6E6S5tnVI0cPfElFM5jfEsgkJ+pgZR4jBhObAL3sNRYFD5oaWNsfHK2c1bc7ODQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fI5OjZMBjxRFOx5Eo+MCYD+WJsXwTXC2IsyNyarfdbA=; b=SE7iKzRAX/qDU7O+uFNTZMvPJHsJS8vCp/uZrj54xXLmDeZQ8pg21QvUveq0D25lS2TXjUjaYu8PWmv+FW8wX+khOhF0xfu2AKH6XEq+/T/3U2zXdcaUlHDQrrlJZNHvwfKkuQufBv3ym9wOh2rTKk6FZTW+RkN/17heAOy/y8oRasQ+sol347w1wcb+EBW4NaR1OOsqtWV6qzXAzeOVrv+fW9NYaVMzx9qd+6aX6ced6Pmv6/jA3IH6gyOQcARFjkRWpoTCWss7cUcejHtS+QidQEXM7A5XjCchFanYo54TtjO+cN7LHmIqMwYa+XGHYG/5LjWI7/yIcJZ+gJIpdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fI5OjZMBjxRFOx5Eo+MCYD+WJsXwTXC2IsyNyarfdbA=; b=3H8taOF8/XFqEHcA4q/OEI/bmy3aofrcgUXM1B7A2cp++KkiYkb0D7O6qFfYDQPulIkGFWhTG0nSxs77d98rvLS2Q7eVvpwyGKrHQp8n7pP3mbvrjSGQlFuXH+uC8iE584wwLa8SLlA9ln3y0Ww/gGhFJnniB330tu2cwY7JTDE2St5p8pKtTe33wwK4+biXqPqk58PdiTltofiZ6y397jtS7MxadGDSJdMWTSn6diRAlTFOQBzjGV8C+qaMm7pWLhOgxLyQPlMpd0jnCC3eFv8AHBgvxzzSoYm7l6j1Tz4T2IeCRFhNM8O78iL18dHvckh8eT/okLDlGQWMtuj6aA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 12:15:01 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-4-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-4-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0011.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::17) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 62b50083-3ae0-464c-6113-08da6fb8de94 X-MS-TrafficTypeDiagnostic: AM0PR04MB5716:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: fMEqkJ0IpyhPRawHywDrystpu8DC8w0P39kCcHL6AqqV7OvfLcsTBDDepYV6AgqoNGBEqVg6YvbjMMiqxMvlDi5XTwbLDBAaR8Z1iL7NHb8GURlirnu+vsQsfgsgD7o7PkO5SLsjIQtU2srli/zcySZKtKQ55waCeVsMsAvCbobbDpHpx1Lb5WJVjQFdk7N/3Bn6bWx0f58sCaIJUOTXEFZNN7r3w95lOAqDyGxuvSpDlxAc1k+cVq99SecqjeAdmumpcwBI09l9BHv8jGqcbg4KbpDZ79pPTLphVSjc9j2/xr2TxUTYHsd/OSerkublDqksfu5ka/i6lXNnip4cepY2AKuAIkJCvBm5z0b1MJZPoJ435RdMk/0hHivMamot2iD/LqiSITMGKbhSZTQVD/FOLpvv0pcKCOE19cksgaJSp70+uU5YgLcZHjwAm+iKLKpAZ3hn4H6Hb05+5yp08JS51NNIbGtnA8vZQkp8jOI1sTphP6k1eGBt6fS5GeFnnh6HI/gNzXS4EtGKrx2I9+23bK7N6URBl9OVW7NYEmrOVWLi4atxCtcTiAT4yTIJbqldZeNBQ86tM6uhisa8XG0WwwL+L0LKyonwR1KgyQHljMI+oDuNxdmR1xmHNTiXbEVbaKLvTdlsX9NQMfSbeAQhrXoOMpNVkVRjX/Ol8lvRCT20lySflz1Ov7je6NN8Is991BVwB8GACBu0b0V2l0SdpPZyS6Hokg4EoXVQasrWox+XLbAau5QzvhxPAIXks1m45Ok/4mBkB/UyuGey5b2r3P634rNBIwnHcMNPNRIQ8DQmYq6eS+n523SUX/WOKmhwz5L1aJN3+u8nYIM/Pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(376002)(396003)(39860400002)(366004)(6512007)(31686004)(36756003)(186003)(316002)(31696002)(86362001)(6506007)(4326008)(66476007)(66556008)(8676002)(66946007)(5660300002)(2906002)(53546011)(478600001)(6486002)(54906003)(8936002)(26005)(2616005)(6916009)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDlZcnVNRnpOeHV2OVNSMzUwcTBST2M4NEdMYTEyYWF1NXlLOFJtZnBYOUlZ?= =?utf-8?B?Wm96STZQdWlhd09kVkwzSWhMM0x5RW1GaGQ4em10T3JRenNPRVNTbnBpM3NF?= =?utf-8?B?RVBnck9VUzJhNDBENkhzSHQxUy9vOVVtMlVMSmxqaHFaRit2bVBOcWlZdWxa?= =?utf-8?B?NWJMTzdGQkplQjdibU5hQS9senF0cEhlUjdibDAxTGlNZjB5di9wS1FUNGI5?= =?utf-8?B?b2prUlE1L2gyendNbnFJTlI4ZVVXM1RxS3NPWVJRNXNrcVh5RGtkdVBXUzVW?= =?utf-8?B?ODFiTSt3Tm9iZ0hvTzJGblpGdXYwR3BTa3ZqQnNtbklPWks2MFB3aTZxdkJt?= =?utf-8?B?VG9LQjhhbklseVhnd09jZXNHcG5meDJEYUQ0dlpMNUNpYUsrT05ZNnM0akZS?= =?utf-8?B?QzNkUndlT2phd2taRlB1Zkh2Z2NDRFdESjQ1RE9CbFZPSnN0UUplVEY0aTds?= =?utf-8?B?YjR6T3ZmYjQwQUlTbG43UEJsRlpZelFiNHZyYURpT0k5ejRTVkZIbE8wUWg2?= =?utf-8?B?emt6cW9aZ3pIaFBvamZtMGp0K09mOE43c3BZa2tZcmZQbldJa3FKSWE2clYx?= =?utf-8?B?MzRWUEpWbUw3cW5NYThhbnJjQkpJN09HNmJjL3BtbU1sN3hYWm9hVzFScHFz?= =?utf-8?B?YUJmeWFjRUt1VDJtN2szelFhTUdzalh2ZnhKNzBWYXZueDd3dktWamRjQW02?= =?utf-8?B?Q0d2Vmh5SVVPNVVUQVVRakdvNit1bHpVZnJsYWZOdEFmYitzVmNTYTU0a0lI?= =?utf-8?B?ODJaUmZXNUtMY3hKRnlRN2hRaDlWc05vVndSTEZZVUhQdGZlMi9XWHZGcjhK?= =?utf-8?B?bUlhNG5kVnFTV3ltMEo2bThWY1VlVWhOOUpYQUsxZ2ljQzdCdmdJOE91WDRk?= =?utf-8?B?OW01UXBxd1dVRTVSbUdwSjc5dnRDYkZ1NCttUVgwd3gybHYrM1hJMjdYZjRs?= =?utf-8?B?c0FiVTAwZ2VQU3djd2srMlJvQmFVQ2JpQXMvd0orLzJJTnR1NDgwYUdGeEFz?= =?utf-8?B?TlY2M0FYMDh5MHNHSzBBWTBMUVZ0TWdNU203UExXTDVwVHNnLy9hTmE5QSsz?= =?utf-8?B?V1lBNktxTmZpWGdVcTM0cmxjL3hPbGlMOFpCYkRLNFdnQklKcUJoK1hobHZN?= =?utf-8?B?Y1NiMS83YllWY1VBWnRKa2o4aHJJMzdXb0o2azd0Rm55aGJUVGxxOXBobzBp?= =?utf-8?B?VHRQMjlaR2YwT1ppL09oTVU0eml5R293cUlqTi9wQkExYlRvdkZOd25sTEtj?= =?utf-8?B?SGpJdWMxV2hoc3ZqQ21JRmw2T0ZySzFabENSUVZmWFptUEVrdDU0aklFei9h?= =?utf-8?B?YXBRMlVTWUJBK2s1clp6bDFpSVBDV1poVkhYaW52VjBpT1dBN1k0dHVWUVNO?= =?utf-8?B?dXVqcG15QTR0cjB2TjJyLzNFZVBxTHZ4REZXaytjNExJUlUrYWFIVGVxNllT?= =?utf-8?B?dHJKM25UWFBIU085UUdPT3M2WkRHRGtFKytKaFBBYWw5emN0elBtUVQwN0JZ?= =?utf-8?B?cDBDTHFNaFpHZWlRNWp3a2lTdUhybFlLbXdaMTdwdHVVN3hJbW9vV1o5Y2pM?= =?utf-8?B?Zm5TNFRuTG5pN3RKbE1weG1qYlNXN2h3UnZOY1ZtSUo1dDFoM2tYQ2ZnZUVR?= =?utf-8?B?RUpGVVlUYkFZVU9sMWtjV3hwSlEzUnNyU21VSVNnRFB3OXYvQ3hHd1VMNnJi?= =?utf-8?B?ZWp6eFF2WHFZNDg3WWE0UDdiZGU5WWo0azRRQzU3UWdmWWNjNCtlNHRVZGFq?= =?utf-8?B?Q0FCNE9QSnhsN1l4bk9QQjZiNjkwYWFENFR5Ny8rQU5QZnZKTDVBRTdaVlI2?= =?utf-8?B?WUJHRCs1UFB1RHE4Zmt3MmRQM3IvNENLZWFJNENWTU43L3pOYlVWNzMyMFpV?= =?utf-8?B?b2h6NzI5Mms2UlJMemNlNUNMV0toQXl1VHNTTUNHRmIxeGVNWEZzTU56NWVk?= =?utf-8?B?d0dlT1hjcXl0bEJlTExFeUxKQmVQWnJSSFRCUjRsck81RzV3Z0FDdldIWTh2?= =?utf-8?B?a0UzM2ZKbExEcDl3VXc3NlBEd3pFUG1YQ1dzdW1sNXV0NFRNckFMeWRnODE5?= =?utf-8?B?UUc1YTdVeGoxbmcwWGNzbkZ1WHRGcUpGTFhycm9OV1dQQjhUUExvUEdGTW1B?= =?utf-8?Q?rLq70DTWHtXimCwW+XXMuxFTP?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 62b50083-3ae0-464c-6113-08da6fb8de94 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:15:02.6371 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gXgH68XHNpONZ2MN3t6pgGfTsXZ+Zea8vSG43BxSR//ayLKJHSJcAuMYn3s4eQX3BS7ivM6/5aLpUx7n/3hN4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5716 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) > if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) > { > bars[i].type = VPCI_BAR_IO; > + > +#ifndef CONFIG_X86 > + if ( !is_hwdom ) > + { > + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, > + reg, 4, &bars[i]); > + if ( rc ) > + goto fail; > + } > +#endif Since long term this can't be correct, it wants a TODO comment put next to it. > @@ -553,34 +635,47 @@ static int cf_check init_bars(struct pci_dev *pdev) > bars[i].size = size; > bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; > > - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, > - &bars[i]); > + rc = vpci_add_register(pdev->vpci, > + is_hwdom ? vpci_hw_read32 : guest_bar_read, > + is_hwdom ? bar_write : guest_bar_write, > + reg, 4, &bars[i]); > if ( rc ) > - { > - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); > - return rc; > - } > + goto fail; > } > > - /* Check expansion ROM. */ > - rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); > - if ( rc > 0 && size ) > + /* Check expansion ROM: we do not handle ROM for guests. */ > + if ( is_hwdom ) This again can't be right long-term. Personally I'd prefer if the code was (largely) left as is, with adjustments (with suitable TODO comments) made on a much smaller scope only. But I'm not the maintainer of this code - Roger may have a different view on this. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376025.608591 (Exim 4.92) (envelope-from ) id 1oGe8g-0000GH-Oy; Wed, 27 Jul 2022 10:19:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376025.608591; Wed, 27 Jul 2022 10:19:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGe8g-0000GA-M5; Wed, 27 Jul 2022 10:19:38 +0000 Received: by outflank-mailman (input) for mailman id 376025; Wed, 27 Jul 2022 10:19:37 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGe8f-0000Fo-Ri for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:19:37 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2089.outbound.protection.outlook.com [40.107.20.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d88b5d1-0d95-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 12:19:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB5716.eurprd04.prod.outlook.com (2603:10a6:208:128::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 10:19:34 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:19:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d88b5d1-0d95-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebVK4gnVysKCVll73kDc4IQgLEmgUmizR+bohzZmWSKSwIY+ztylQXwbtRBsPpFG5AKohvhB2magSSWXT4NJHOgyd39nTgkGbnZ3w3esIoFHHAbTcOObnIId5yUvj1xWuJBT/dYnv7iJKSOMFBZzxUWCYuK44RNi93wCabzuLcCjzviQaNxTCDldfKhWSmYQESfnSTeLy9UexYz8txa+//L9bWtVLbZKKIuE97JhvOTPJzVP9rVz4a8Yzpi8ILvFWkpyg8wChDMSxOTuAtrfTgVLxatJ0GWjAtFQqVGCY5N04AScccXPkK0Hf+lRy4gbeIgpTNbyTX73dGezxxPmqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hSLipPpo2w+945nQ/m68bLTaXDY/ElVjdIGuB9QCK8Y=; b=COSRjL1k24iskyV+1+sIqQ5HxCfvVpquk25BDbq8YxWcGonBaZg08jFPhE8W3XKSIVAv0XmvCwKB2YUJQCSuzfNyn2IZgmN9SwjggWk3ixaUNVoam9lL1i22ZNOqkmuwRom0S213DF7aw2gQZ7JEK00/ZMifkmLBUKmCPRSxiMyggctge0U7pPTXFh9cwCe7VITqAEpoxJ5Fi8QhOD3vBmCMYVFsa28WEJgH/4xqqRZ5KjFaNwgTxACzCih2E6TRGP2rQIEHrN2uQLhS/lUeZauk9Xhsb6bwclz6/NefcUNoE0vErYIAG7QFQfjpnzoc9XVkaBf1AT4n/NdIhHfh+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hSLipPpo2w+945nQ/m68bLTaXDY/ElVjdIGuB9QCK8Y=; b=qX58jKi1kjdu0Z4A3urLAuuy9CFEqxAton+wt1Nx/6l/7x9rmjTvKiPrAKJDcc4pQgx1p3a6wa7ljOXBl6JsBo+jCG/KaRCct0t64PRyMzwS0XsXiEeogCaWjxQOSZ0dwesD1OTv8UavuUJ/YmjJcNumXd98/dLSrLbk84Ny42f1YJkT18Gw6WT7W1moij2ebPusX8Dh2dY9HB0ytlYgWU0+/Jp9qw6RMzgS1Mhn/0QdaWi2lu5PT7McEa1gcrwDyaueiAvMY6Nmr1UXPhmeI40vSwpR2hiWJnVKw9nROU2U1Tn/6kqSlLr58phXVuDdtMhrwUy+kjNNo4jEx9efMw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <85853c9f-5706-22dc-4798-48c775a17d12@suse.com> Date: Wed, 27 Jul 2022 12:19:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-7-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-7-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0118.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::19) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 70bdbf70-2f23-4205-31c1-08da6fb980bb X-MS-TrafficTypeDiagnostic: AM0PR04MB5716:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Yg0VMySPNBt2Xy/aLSwp9k5qBttMtAiY/BBJNNmjfGtZPgQ3proaJTlaHGdP4AJvw9E85FG0M/UD5UZ7fWemxvxPXMsbRMZERIKiJqxy7i9FXn9nIm15JXTnoQEpCtpTu7swuE23e71mnwL+rcv66MCHV5EQ1qh6a/UAQoaLezKqbbBFoGraIFwgtNgCrkGB0IY/0SyBo/86K6x0WdWqjUeKW0RYMtnsRyZsPAzQ15b7tyXjviMJdVkfvwDInDoGQxhCYCLL/e+JiUTZijb0xVPatB9sUKghqg/E62jN4wkI29ibb5wedvcvvcwYxZWBRUsqFbIu3AlIP7WSFZaegfZGA1+sWn/epfnUFW1gSNVxIALyYFbrEdnJKzGBR5/wnCQDj8LDhjhKws++w8RumBq0NON5Z6yNblsQ5AP2itj0gqikd6b0dSC71GJ3DGgAvSlHdl58/CMZtcS4YHLRoHwKcxDP45X6KZ5exF7X3HiyUrNKkdjPGpzcwc88As5XGEbKjpMlkqb83jDF9Jl6+p2mbE/yKRn5evhcre/OhLBwGNJh2c3dGwiTUmUxiQpishPwigHLO+9I0LIoqeUuQNjnz0uyDXQQpmob83dVtWo4zfWL16eiXAH6wf4TkPlhumT+JKmDwzw04abI4RKav/jvgVblylpR5tSpTpzc2L3y5rtLlshGohVxcCGymL+8WlHD8rDgLCxXIVAaonMjuypRy0F+ZvRAGEbuBCs0nXllqZyYa2A8w2u5R0LCB4khuQzJj1D7JZONj8GAz17wdus5mRtguXe9JEMgyPykobhhwSH7L5QRWRHSpHrPKALGL3tUEBYjLfPV4JFMSm6mHA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(136003)(376002)(346002)(366004)(6512007)(31686004)(36756003)(186003)(316002)(31696002)(86362001)(6506007)(4326008)(66556008)(66476007)(66946007)(8676002)(5660300002)(83380400001)(2906002)(53546011)(4744005)(478600001)(6486002)(54906003)(8936002)(26005)(2616005)(6916009)(38100700002)(41300700001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWR1MlhiaVJwUVY5RWpSMzc1ejFlVisvRUJDQnR5dUllSXkvNnMvcFQxN0tq?= =?utf-8?B?dnZrdGNsMEwzN01tY2lBQTYwaG1aTlc2MXNzQzZGdGxaVWd5bkk4RVBmRVlY?= =?utf-8?B?YjR0cHJDMXNTZUJiOW1IQys5S3RDUkpVa3FRUnQyNWZqWXdNenBhSUhaUFB5?= =?utf-8?B?TWIrTk03SmR3SmVUbkwxRDVpMWlnb2l6RW9scGVCS1lpN01aNTAxVDJpdlg0?= =?utf-8?B?TWZralRVaEdHOVFRNTF1WXVqaVRHclJDWXhUUWRxeEtiOG00THp0a3BwWEhM?= =?utf-8?B?emUvUWFCZFFNcXcxbFdzam1LSWRaMWZxVFlFUVcweFJKMU1iMmM4Wi9iUjhO?= =?utf-8?B?SHJoKzUzMDMwaFBIekZaRFpKRWJSNkJvaCt0TGZpM0RwRTNRNHZWVEgyUHhx?= =?utf-8?B?OXp5aWFWV0tVTHlJU2ZDODJGeWhVTUlqOE0xRVdKekEwNVNiSktRaXg0aEZv?= =?utf-8?B?UVlPQ2pTSTViTm8vOUQvUVA1cnFTendPSlRRZXBTTWo0YW5VejhEY3l6UUk1?= =?utf-8?B?bmhuN2VjK21Ga2Z3cGRTdS93OS8zdHZWTDNBVkRRNXN1TWZ5NTNqMG1PRTFp?= =?utf-8?B?WTc3NmtPTFdRNzQvalgyc2VmSDV1TEsyWHhpT1JSSFFTUitSL2o4UnlCdUNZ?= =?utf-8?B?SG9vK1hsaWpyMnJuWU5jVnczUXZPQzA3bnVpS0xBdDZDM0JDTGNJWlNzOWRy?= =?utf-8?B?NjYveXExTTNFUmQxamhVL0tEbVBnd0Qzd0lKTXJPTU5vV2l4OVVEU2dxNG43?= =?utf-8?B?eWhPZ2tqNlJDSEs2RUh3ZTMrRjgwNEg3NGNtSXNkRm9pZ0UxM0VrT1NsRWsw?= =?utf-8?B?czdhdXRPTjF2ZU5ieW9QU0RYRG1FNWxGOHA3Q0YyS3hHaEtrazJiRjhuVFA4?= =?utf-8?B?c0lpL0twNFJOQ2N4SW14aUJIRUlvWWFYZ1F0UWJFQ2RiTHNDTHBZZnluNEZL?= =?utf-8?B?VUorU0NRa0JmVkVtRDVBZ1dWQXZ0Q0pQcnZhYXB3N3RuL2ZjMXRYUjNqdkQy?= =?utf-8?B?WTNabUVhS0YwMk9kTzN6SnlZS2tVMTNmdUJlbXZ5dHppVHpyeis2aWN4YmlI?= =?utf-8?B?dUQrc2UrS1crTWt3dDE2Tit2WFU0SFM5WDRUcTZVdzhLTmFBN1F6MVYrSnhG?= =?utf-8?B?c1B4RjVqRW1qV2VIdmZJR3NGV1BQZWxtR2VFS2ZIc1I3Z2JHVStWMUdCajdj?= =?utf-8?B?VWNUV0tlTWV5TU4xbHg4NHh4YXA1ZmJqR24zendFOXM2cFVSQ2VkaVRIang0?= =?utf-8?B?bnVVUWpuUDZmVjVvcnRmYUhRK1hQZHg4aWVRUCtnREUrRFRUSnprbHYyTnVj?= =?utf-8?B?MFhHcEhGWFNmUUJENE4rdzBFdUtmbTNLNjVHTERHcUV2OGF1M2NpemUrZU51?= =?utf-8?B?UXFMaUp5dzNBMm5jd1E0R1VrU1BrYTlENFNsY3VEUTVhcW9XeUlKU0svQVpQ?= =?utf-8?B?VDNia0p0TTRFSTMybDhrc0ZzcEpQNUhNWmZWTzdXMTdNRURGOWJqZFAyQ2tD?= =?utf-8?B?bzBxRHRvM2Zvb2RZTTBtSC8vUFN2dUZMbG9KRGJNZ051TTlvZWJOQUNkUDRo?= =?utf-8?B?N001Y0FPWkRVVEorR3orN1FFWGxEQlNwcU5yYWwvZHRjcXlzY0xiclB5VTR6?= =?utf-8?B?dFlrbXczR2FWT3luci9kQ0RvNjNDZllKM1VnSG1LREI3eDNGOEpRQkJIZEJ5?= =?utf-8?B?WlpFUVd2MEFSN3Zja1BRbEM3MmY1MjRCWC85QXp4eXY1UjExenBmd2YrSHlw?= =?utf-8?B?NE5KdzVza0hRUVNEV2ExUjRMb2xPNEhYUkJldXh3YUpDSzY2UTIxaXovUHIx?= =?utf-8?B?VTR0QUNtUThiNldZUHArd3M5R1l4T0I4WWRXT05PUmJKdkFsTVBlTVBJK243?= =?utf-8?B?b3VieTNFTFJmbzRKY2pxSVdCVm5SSENLWTVWOVduaEFhQmRqMWd0WmlQNDQx?= =?utf-8?B?ZGFzbDRtRFc0MTlhcy8rU0MzcnlTRTExOWRZY1RxcmQrOUNqMW1wdEN1emRL?= =?utf-8?B?UUtsdWpDeFFrbkREdzFoZjkrWUVkdThTUEtDeHFDOWVNOHdDVEoraE9xTDZR?= =?utf-8?B?N1dpdnNYZFZPL3hQTEMwc216Y0ZWdTJwREV3TGh6YnE0TVRUekxzWnd5SUZY?= =?utf-8?Q?4AUsaOqAaS8ZI7maZu9sRlpVF?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 70bdbf70-2f23-4205-31c1-08da6fb980bb X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:19:34.7293 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fw3++z07WTYaH3LQY+ixa7qCmwxSBH4VG9eIJSDLB6m+d+rQTWAfV9pSpitEYQl3Yj48BP72+Gha+ianSdX5Ug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB5716 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Take into account guest's BAR view and program its p2m accordingly: > gfn is guest's view of the BAR and mfn is the physical BAR value as set > up by the PCI bus driver in the hardware domain. > This way hardware domain sees physical BAR values and guest sees > emulated ones. > > Signed-off-by: Oleksandr Andrushchenko If taking the previous patch as given, the patch here looks okay to me. But since I'm still not really agreeing with what the previous patch does, both that and this one will need to be judged on by Roger once he's back. I'm sorry for the therefore resulting further delay. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:32:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:32:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376032.608602 (Exim 4.92) (envelope-from ) id 1oGeLN-0002gf-UL; Wed, 27 Jul 2022 10:32:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376032.608602; Wed, 27 Jul 2022 10:32:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeLN-0002gY-Rg; Wed, 27 Jul 2022 10:32:45 +0000 Received: by outflank-mailman (input) for mailman id 376032; Wed, 27 Jul 2022 10:32:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeLL-0002gS-UD for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:32:43 +0000 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50041.outbound.protection.outlook.com [40.107.5.41]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71fc4593-0d97-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 12:32:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB5392.eurprd04.prod.outlook.com (2603:10a6:803:cb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 10:32:39 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:32:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71fc4593-0d97-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IzmlCq5U2F/9pysmYUatCBhPj0ttkqX68ym0Gx0Gol5Hl9HsQTxZ68yyRdo4y7hh3HBVejzNqaNueKgWAlf5Ubs8/tUZldi1/CvteovyT81T+gccv4Fy9jxjPcBFQ7MhxQLDiBxcra7P7dnnO8XK6GbhwdVf2S32pcgnmCcgsk0BNjI+6Ej186duWCCE6BbkTmVpwo0Z8LX2S4CdHhXefya0moCOriJR1VeXjFwOF4id19aNL19JHh9PN7VT68gMOSRuJQ8ZDDmeZGlU+LUBG8yxlPRBr0W+TPJCDthcr2CPD/w0Gq4GKOhm7mAd3K5lpxnG2zOdcygLbEbs6JsW/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OjtxdT6/eZ9e59bZ9i80obumBGxdA+CdvBsaCdcuZUg=; b=MnRimjRhDFwxxdKQ6q8ssYRcFJz3AW/CV/8TEObIUHLD1YA0Ze8urBqPGDlogs7kZlUay18lUzsHkY3mp1nR6CBIoCKETHOZjfpQA5KeSHOEFnCES+jm/1HZjzqAGPt45WWmdMtrt0OSS6BmYyDZI/Hs1JseEEwqWg/EdDCBrKciSdpTT1oS0kWxIgbHijPYMJVJnGNUfBg28/79MBLfUOHgG0CX2GfNKQv0osWoRSdc8SqIc9hvcnbjNeXWo831z7PO4O93Oed+tzkz68a7H6RFmTm8jm3TkrAE7IM9rw26lHR5o7HC3PMUmY/2wm+MzFwZwaXSCkXMgLE5bH7jww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OjtxdT6/eZ9e59bZ9i80obumBGxdA+CdvBsaCdcuZUg=; b=df07r2QK32X/tTGglgzQvHgHmTiT1o6UGbx9ZG5PoHt5CVT6ePDG43P5BqPM6fFGTQQUts0w0cM2o+klMiPpcOdjPXca9K7qIjoguj1RqnU2vWlas1v5YVtnuv4pT1vulMnHclCgxBrRE25QLDTVrRmT3MBXoE0M7ziIMTInPv46pIpabVFcxde4iyz8BJXVaa43Afv89KOg6/1bp+hRBEKAGT5EzSYKEXXKboVXOS2XmivPCHJAgOxr5awuTDo6XUlc1NuVC9sFNEuKhmRi6i7iSgNUmUznZHWm3/cgyK4m8l9Bo6HcFLN4gVHIxMldM2ygzXVp5hKxfBGzIhVPVQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3b3dd7bf-b528-b7ab-aec9-c912a30d9cd0@suse.com> Date: Wed, 27 Jul 2022 12:32:37 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology Content-Language: en-US To: Oleksandr Tyshchenko Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-10-olekstysh@gmail.com> From: Jan Beulich In-Reply-To: <20220719174253.541965-10-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0053.eurprd04.prod.outlook.com (2603:10a6:20b:312::28) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4be9db88-5df6-4829-170b-08da6fbb545b X-MS-TrafficTypeDiagnostic: VI1PR04MB5392:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZCwV2+X9+tqzn3TgmtJLDFDCXuQv82Rl7DWSsDEtVV7+iPVdWoa602FQnRhuTBSPq48HEeIxbKnwesgjWXRtl/VuxcxIBE6K9VBqjCiK+RdysPkM0mWC59z+1vgBarmdwlFDRvwwqa6Xo5wU9p0q237cfUTRNQHc10wlaXjLpieXr/TZl7jg4PX7uQnfTbh9ACmP87PBDkFAZiq9G19qlylvLWh2TB+Rvl5WIupkxzf4BYR5CL27wtcrTdEcB8j4mEOFnvazWcTuaT1e2jDbFRblG+CZJygNpiGUVRph1Fa5fECSnLDL1GHBHQSPuMcgAjVjY0cFiOFQyZNDXKehMN3RfPsgLiuz0u1MDTLgS+IUpFIr8poJ+dF0IsdbmyC4k2pTXoVJofUwEh8NBpPe6CYU9dw0amL0T37fFcHdymQARvyfpZgFhyoYoX5zOtO7PQaHY9kUHiVCeDWECYrJeVyFjIDTz0fMGAbDkYVgt65t4A5gXiKpxSwRrlaZeeU9gATNaoEdkmpXBlq1gr5DOxEKzwIbTQSTrVYmFrt+M9dNQmH+EA/ElMNbux2lKR7dJpFTCmOfCtUqjNywN7TSD0weP4DY70ShVNaB4ZIDooNdiKK8fMSYE3LEJWSuVEKH8zm94jdCCEHqGdwvxtfyGR2G2hz7oEr+tDsgfzPzffF4MKEJjgV9txB2V5xYFelSr/9Uir5hJ9AfqiXVvrFAsidats+SELNZk0UVVJoghNVSOxq/JHEOrStaQbCPbVqq7I93f1t5c7BhT29CRHSmc7EODA6ZoS79YRy68bhVdj2K4dPmeMFGIvwNDEgOcv/9sNFUKyAyvh4g7DqyRXJn3Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(366004)(346002)(396003)(39860400002)(376002)(8936002)(31686004)(5660300002)(66556008)(38100700002)(36756003)(54906003)(31696002)(316002)(66476007)(86362001)(6916009)(66946007)(4326008)(8676002)(2906002)(41300700001)(53546011)(6506007)(2616005)(6512007)(478600001)(6486002)(26005)(83380400001)(186003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YnVsQ3Q4VlJRUkhDLzV4QW1SOFE4dWx1cytLc1h0UXlVOXBJN0xQK0Zla1Nx?= =?utf-8?B?ZG1UWUJCQWRjWWxwNjZwenNLNGlNb1lJK1hEQVd0aDJuV3N5QUx6K3UyTjFG?= =?utf-8?B?L2JIMk5qbUVZMDRIOFp6SE1zS1FsYmZ2Um84T3Y5dXZKMGlFZk1ORXBObmJo?= =?utf-8?B?c05iWmlidDlFZTc1eExhMzZPQnVLWWtZdWFSbERsdkVWb2JHd01kcFpnME0v?= =?utf-8?B?cGMvNHZJKzhMemNFcit5c083WldVSkw0dU52bnVoVllkeXRRNmtqc1JPZU4r?= =?utf-8?B?RzNramFzbzZTM01RR2VhTUdiQjZ0WG1CT28yNXNIdWcxOUtxejV4Q1JaYzdz?= =?utf-8?B?djVpUTVCbVAwM2Y1TEJDaGNzQUVzUU5xd2FvS0hzVGVuWXRZdUdhQUo4dU1u?= =?utf-8?B?RHJUbVR4emFpNThWQlI0ZTVybEVPSXp1d1FDcm15VU13UXhITkYwcUtpa2lC?= =?utf-8?B?NEQ0S1NwVkI0eUFDUVE5aXRBb1JUWldFdUZFN3Q0dGVQaTRsU1p1WFFZSm5G?= =?utf-8?B?NzJHSGpwS1k0enRDdlVuM2F3UHNRRElRM1E3cGRWTiswNHNWcUlJL01WTS9q?= =?utf-8?B?TVJ3amtJVlB5RTF0bk9vNGZOdCtIMjNncjErV0hhT0tzcGxiUWxVMWRwYjR2?= =?utf-8?B?N2hIZCtnc1RBQTZJRnlseFdNN3kvWXhDOHJNSW9DTXBDeDZlbkRHdGlkMjF3?= =?utf-8?B?RTZGQWZHa29aMWZSMDVkVUJVRTFLbjRlNWUvQXNMeUY1QmhYUXlhRUdnK3Nu?= =?utf-8?B?RVdvYmdZOWNIT0h0U3VYMHkrcnQySVVqNlJLTGRzRkYyRTF1Y2xneTBwMjNQ?= =?utf-8?B?RGN3K2VyRWJNUmdKTGRpVGVJWDdLQzlUdUtzdW5ITzBHcVZSUEZML3UvQ1FV?= =?utf-8?B?WVBRRnV3SDJUWUxuam13OFM3ZUZWa2NjRWhNTmxiSGtidzFYWEFSc0VrQldT?= =?utf-8?B?WllFdFhBcVFSM2sxT1VIQi9yV2hBTUJQUG1Lc3pxYk9WZExYSkRhazQwYm1N?= =?utf-8?B?NlBZdXpIdE9mYWpXYWJNS3J0K0luaDNlRVdvZzR1NCtJNTUreEU0cC9NQ0Rl?= =?utf-8?B?dUdEOTIwOUJDMUtTUDAwdENEQXg1TjRkWTg5QVZqZGI0bmxFcGEvdDFJeVcz?= =?utf-8?B?RXBicWtDQTY2R2l4a29kZDNsbThGai9VWFhqZWk0Tzl6ZFJaZk5NWkpFSjVV?= =?utf-8?B?cVY5eTI1THhYTmh4WFU3R2l2dnFVUzlvMEhKL3RhTHVyTU1zWjkwc1cwSkVH?= =?utf-8?B?WnVHelJITGJlbXYwQUZoTGFRZktZdGpTQnVVb1lTY0ZmTC9HR1lUMjhZNzVx?= =?utf-8?B?a1hjdUZTZTdGQUJkRndHc1h6dzZ4bmJuVDc2Q3BHZVQyUnRsNkF3c1UrMnpl?= =?utf-8?B?NmtEREtkNjl0RW9rWUhVMEo2N3pwbXNxY0xXTUt3TTk3YlZJcTAySjNSRXl6?= =?utf-8?B?ZTFKeCtMbEhrcHRQeEVaTWhoa3JMbVU4KzdMY2sybjNFcE9pbVU4ZDVsS1F5?= =?utf-8?B?bC9aNFdHRkl5ZThoZzNDUUZtaG1NRU1hUHdvNVBLemtGWGEzdzlBOE9XSUY0?= =?utf-8?B?ejlsSEpnZVdneStBSWtKZm55YThrZ1QwUHdxM1lyVDlRM09TQTRMdVQvOUkz?= =?utf-8?B?bGtScE5zcEJDM3pLdm5NaXBUSldoY3BsQ096VzBVcGtRZzVjdmFxRmI4aS9B?= =?utf-8?B?eFZjb2M4dEhxeExDZmVhaURqOTcvSWZocVpXS282U292V1RRdXhPK1hkUHNH?= =?utf-8?B?ZFpsNHNJcnVaa0lvZjkwU0lYdkV2NW5QczNGa0ZkV1FWcy9yQ1hWQ2R1c2o2?= =?utf-8?B?Q1hXSGhPV2Y1T2VwRUlsRzl3d0l6SjJGQVBYRlhGUC9PSG5YbkcycjVQWGtV?= =?utf-8?B?VkVEQWkxQnBHanN3ak1XaS82UEFCU2ptMU5zSEZTcXNwR3VyZkQ0aXFEQk9F?= =?utf-8?B?VDhnZWxhTkVDNVd5cUx1elhwb3o2eVl2RWtIRnkrWEQ1bjVOcWQ0bEhKQ2VG?= =?utf-8?B?S0N2T05md2tqQ0hiMlRUdDFFNG9raVJVOGJmUnhFdXkwd1JGUkwrLytyZWdl?= =?utf-8?B?dTM1aUYvU3ZpMUNGQnFIU1NnUzVYdlpCclJvZnhLNm1JSlJaNTRpMnNOcmVx?= =?utf-8?Q?RZaV7EdbXj6iU0FRQHN1mJRMY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4be9db88-5df6-4829-170b-08da6fbb545b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:32:39.4919 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WVXaY/9kX/SAMaYEpKP6c31CC8zxqV465ygOLAvuSQ+oUr8I/KINq/+BNGDNoAwB/xOXZWp6Eh7VIIQQsijXbg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5392 On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Assign SBDF to the PCI devices being passed through with bus 0. > The resulting topology is where PCIe devices reside on the bus 0 of the > root complex itself (embedded endpoints). > This implementation is limited to 32 devices which are allowed on > a single PCI bus. > > Please note, that at the moment only function 0 of a multifunction > device can be passed through. I've not been able to spot where this restriction is being enforced - can you please point me at the respective code? > @@ -99,6 +102,62 @@ int vpci_add_handlers(struct pci_dev *pdev) > } > > #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT > +static int add_virtual_device(struct pci_dev *pdev) > +{ > + struct domain *d = pdev->domain; > + pci_sbdf_t sbdf = { 0 }; > + unsigned long new_dev_number; > + > + if ( is_hardware_domain(d) ) > + return 0; > + > + ASSERT(pcidevs_write_locked()); > + > + /* > + * Each PCI bus supports 32 devices/slots at max or up to 256 when > + * there are multi-function ones which are not yet supported. > + */ > + if ( pdev->info.is_extfn ) > + { > + gdprintk(XENLOG_ERR, "%pp: only function 0 passthrough supported\n", > + &pdev->sbdf); > + return -EOPNOTSUPP; > + } > + > + new_dev_number = find_first_zero_bit(d->vpci_dev_assigned_map, > + VPCI_MAX_VIRT_DEV); > + if ( new_dev_number >= VPCI_MAX_VIRT_DEV ) > + return -ENOSPC; > + > + __set_bit(new_dev_number, &d->vpci_dev_assigned_map); > + > + /* > + * Both segment and bus number are 0: > + * - we emulate a single host bridge for the guest, e.g. segment 0 > + * - with bus 0 the virtual devices are seen as embedded > + * endpoints behind the root complex > + * > + * TODO: add support for multi-function devices. > + */ > + sbdf.devfn = PCI_DEVFN(new_dev_number, 0); > + pdev->vpci->guest_sbdf = sbdf; > + > + return 0; > + > +} > + > +static void vpci_remove_virtual_device(const struct pci_dev *pdev) > +{ > + ASSERT(pcidevs_write_locked()); > + > + if ( pdev->vpci ) > + { > + __clear_bit(pdev->vpci->guest_sbdf.dev, > + &pdev->domain->vpci_dev_assigned_map); > + pdev->vpci->guest_sbdf.sbdf = ~0; > + } > +} Feels like I did comment on this before: When ... > @@ -111,8 +170,16 @@ int vpci_assign_device(struct pci_dev *pdev) > > rc = vpci_add_handlers(pdev); > if ( rc ) > - vpci_deassign_device(pdev); > + goto fail; ... this path is taken and hence ... > + rc = add_virtual_device(pdev); ... this is bypassed, ... > + if ( rc ) > + goto fail; > + > + return 0; > > + fail: > + vpci_deassign_device(pdev); ... the function here will see guest_sbdf still as ~0, while pdev->vpci is non-NULL. Therefore mistakenly bit 31 of vpci_dev_assigned_map will be cleared. > @@ -124,6 +191,7 @@ void vpci_deassign_device(struct pci_dev *pdev) > if ( !has_vpci(pdev->domain) ) > return; > > + vpci_remove_virtual_device(pdev); > vpci_remove_device(pdev); > } And other call sites of vpci_remove_device() do not have a need of cleaning up guest_sbdf / vpci_dev_assigned_map? IOW I wonder if it wouldn't be better to have vpci_remove_device() do this as well (retaining - see my comment on the earlier patch) the simple aliasing of vpci_deassign_device() to vpci_remove_device()). > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -457,6 +457,14 @@ struct domain > > #ifdef CONFIG_HAS_PCI > struct list_head pdev_list; > +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT > + /* > + * The bitmap which shows which device numbers are already used by the > + * virtual PCI bus topology and is used to assign a unique SBDF to the > + * next passed through virtual PCI device. > + */ > + DECLARE_BITMAP(vpci_dev_assigned_map, VPCI_MAX_VIRT_DEV); > +#endif > #endif Hmm, yet another reason to keep sched.h including vpci.h, which imo would better be dropped - sched.h already has way too many dependencies. (Just a remark, not strictly a request to change anything.) Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:41:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:41:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376038.608613 (Exim 4.92) (envelope-from ) id 1oGeU9-0004Hi-Pf; Wed, 27 Jul 2022 10:41:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376038.608613; Wed, 27 Jul 2022 10:41:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeU9-0004Hb-N3; Wed, 27 Jul 2022 10:41:49 +0000 Received: by outflank-mailman (input) for mailman id 376038; Wed, 27 Jul 2022 10:41:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeU8-0004HV-Ev for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:41:48 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2081.outbound.protection.outlook.com [40.107.104.81]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b6c48218-0d98-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 12:41:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2263.eurprd04.prod.outlook.com (2603:10a6:4:49::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 10:41:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:41:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6c48218-0d98-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PF7fg2INjWL+tlmoWK1I8Z/3KMieIP0ebd9HhQjTAzMPQmTF+V/TQAC17YJrs7Zw0CRHcOn04wRzXYrDrV2Hqf7ac6PtyYRBS3EtFP6+1agoPoUNIG1bBVCUSbW6hjImZW3ReIi5SELEd2ezZu7ejkcLu/VOTv2VYM1NUBlDbACgyObyO3ulBtbGusDwnT9VF+6TIGmFY7ul9X2mhJXECW0EYriio9QF/RIifM8l8BCOwgK15KQgXwTAnZ+gf7v7i4lylduAkZWhmunE9Z4SC+yhQ6Q36bnC+Kf5yKpR3WIX5zAnMTEra4jw5HfPvgYW7N9Rb/R//FMfJbWdcFpvRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=abVLJPaXhdvr7TD3QprCKD6PStejJb80/q+pxQSuBV4=; b=Jn4uB0jXFhFI0mj1Gqj50g7fsLRwIAxrJm3Xlfr4mOeC57+6zZQF/kHf0KHWR+Nt89vOJ6Dp0F0FODdQ/IcHIAyFpysI6J1tIZMjH2rNQ0R92PrEPGSYH/rxZ6NH5oi3kZ69GTB9KCReLB1V3KdpVJ7MNwFIEEIGPcKOSoDOztxag1YRtAA63e881q29L947/3tmygpVxqsS9WUOUObdrXCjuuyJI5G6NHd2YOEIdGVEOew2ff5z2ovy5kJuA2iSVcOxw7YWkmRurbRvF+lqZY2oYCxpmnAPI6O4XWEaOm0Vr5Xqmf+RqmSBl2HuPN6mK5pkCboVDn9ZFBFH8PAylw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=abVLJPaXhdvr7TD3QprCKD6PStejJb80/q+pxQSuBV4=; b=qvhkLwmlA9TXz6RHMx3lTzIUSVX8NemzR7zWiJt02W8pzA+PPwXCOonabzIPWSoqxHP57P74Ju0FdXO/TLoFtR0WEEl+EOj4/vQAOsT1llX4DOfWOeXxH2nn+NNfkFbHHS/ZlfHEX754BLD/zb7CdA4oXn8U+O6jCtm7DcopyXKhB6U9Cp8L4T8v/7LAPCdg1+KGoaVPOC8qL0snh7rxM+YfNDLdQzlj/7EneqxorZ5nIWLuMQL/sn3WtN5bQJct7tui7H7xH1XpWui+m4uXtGNH27kRo4iRvQpB2VLKLXhQr3PLJtG0nMQFwvwY8SKVxF+pF1E5KRktu6nLQfc0lQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <13f6ca1c-559d-b89e-207b-d2685ea80bef@suse.com> Date: Wed, 27 Jul 2022 12:41:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant From: Jan Beulich Subject: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0003.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 52e20b5d-a248-4764-72ff-08da6fbc99d7 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2263:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4jyMaDRVc+1X/TQdn7CcQyFO7u8aawv09WBijP4HhXG/n2WAFrfG3Cyk2aeZgJMpaHI0dfxcx0ydfO4MwgXl+XcljjZ5LsUQfKx6qBAHkL39AGrBuszslf4Chnvje1IpW1dbf1oVNsV6D49y85US4zSrJmB3fyoXCbQPLSwCBV8yIG/FxQksWN8m8prjwG7eAwXJ9hm/PQN4KciCYMsDK7j56FWeSt/rf5wmMtRyGMWqLcR3EaJQSB4KfQUmOvkhx8/8qZOI+Haqhf/xr5SZ4uQOE2T42e9oB0wqzEcT5qe9Y5xrioSinKFRokAPPSHdlOIr7EPSH4bQjPJZZ8KkwtyYKusbksRasK6PuBIEmqZ/HpEgOIZQch0vCHxRrwWNCnNYEGhfl+YSCVfjTk3wbygH6xJSBowA572R4InQwcWeerS/pl9ejTMXiEfIveVAGLZUe8TyXlNJqCqqldjdGQfLQyyoAWtpTswH9K5Mkske85ArN9lOXKwQoKkMDLklzYLj63Ou8VZXCUmyAGrgRNzYN4oEX9u7HoSuPGhDdjnprsL9nHwNUMTT82ai2TcFmoVv3iEYbJSTFwA4gYVc0pMw+4l0q2n6DEs6zHyrgauVHOAqRulFPQ8mpk/YtgxLavcn1wf629P3X506qQERwRhn11f2gyUw3etAnfZgf8cGsp57cpblZLDOulENosfGW1rrOk6kj9GcIpirIh2wjJFUp0cAxRlKFUAxq/t6We4LY7lREsMoCbjgjRbus5OS/S1FCUnIpb1j5jmR6YQ58VWMKktiiPmYw1nA5b2i29Gd2TdYtlqjPawIhNfPfkgvyWF97Gje6mP21q5jvsE+w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(39860400002)(376002)(136003)(396003)(346002)(31696002)(186003)(2616005)(6506007)(86362001)(2906002)(6486002)(41300700001)(478600001)(38100700002)(66946007)(8676002)(6512007)(66556008)(4326008)(8936002)(54906003)(66476007)(6916009)(31686004)(26005)(5660300002)(316002)(4744005)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TG9MdDdNQkxMNUcwRGJrVGN6SUJWckFSTnV1ZFUvbFNNQlpJd2JqVllZUWF2?= =?utf-8?B?WjZna1p2Z0hLT05ERHJSajYyY3BBMS9qN3d4T3hiMjdqWjdCcUg1VjRWdGUr?= =?utf-8?B?djMrazRKb0loQndlWis1WktJTnFrYUk1WEhMMzNZUno1SmtMQ1A3bDk0V1E3?= =?utf-8?B?RWt1VzlkbXAyQkQyeHRvMVhkUERGOHBLTjFMZTE2WVkxWVB6Y2JJZExlMFlv?= =?utf-8?B?cTVjWElEcjczeWZscUYzdjlPamdSb2ZTYlFKV002cVhOVHNjSmxIMDlhSC9M?= =?utf-8?B?RnhDa21UL004bElhbmlvSTl4RmEwQ1V6WFJvRlZXYkxhZk1XRkpRSFBBOSti?= =?utf-8?B?STBYamNXQnVKVXNBR2Y5MjhFYU5sd3pjTkVkVE1oOTBzYkFFaGN1UWdlMzU4?= =?utf-8?B?UmtZbzJ1U0RzUDNaT2xkaHc2U3dqZ09qU1poNEVsWnVGSGoyZlRYb2JkUmlt?= =?utf-8?B?WEcvY0lUY3Z4bW45QU1BQnA5WWo0ZC9CL3B2MWlEZ0laWXFwNjNTeCtzNXNS?= =?utf-8?B?VGJwSnBVYVBjNzc4WGI1UHNqNmdUYXNUQnY5aXNlR2U5YmJMaCtFTkQxbmJS?= =?utf-8?B?bjJXcG16Sm1RdlU1a1JQZDNIMkp4bldlR2RQcHZ2cTMveDhBMjd5cEhBRHNX?= =?utf-8?B?THJXUzFBWFo5QkIwZ0JuRTNYb2VWK2lBWENYalZocisyNFdmcEpnT0ZkQUt6?= =?utf-8?B?c0ROdFhSNWlUWWZ2bjhZK3M1V0tES2hGMm82WDkwUlhjby8rVE5iaUVkUzkv?= =?utf-8?B?dWlDUTkxQ2FEN2RNZW5abHc0MzVnb3d3b3JmVG5NeXZnUzYwaXZDbDZEdHB1?= =?utf-8?B?YkNOY1VTVFY2V0cvMnlvRHEzenFRZDBWemhZS0UxZy92MGU5WU1WSWsrTjZn?= =?utf-8?B?MXQxYTc2ekdjM1lEcjBlRTZVdkRWeDZxc2p2UUlCMm96VHp0VkxOby9jcDNB?= =?utf-8?B?SmQ0TEZFL1g5K1ExdzdEYlRXaTBWZG5mRDV0d1pSWVJueWc3d2RhN1Z6eWZ2?= =?utf-8?B?SGRUa0F4RmxyYkt3b1N4TXRVQ2ZlOHBPazVsdDZXQmlVM0ZrQ29ZVHI4aDYz?= =?utf-8?B?bXFIMDZCejd0OHRmTGhpbWp6cDRSMXZJR1NvSldrTHA0Nk03N0RBTjJjT0xy?= =?utf-8?B?RG11UGN0WExSYzNTSnZNVk5LMnhJT0V6ZGt1NUVoeWVHbzZRWlJGRVdVbVpk?= =?utf-8?B?cndWYkxDcTdyeTBxaldwd2dRZnFSdERLdlBBelZRQlM5SSsrN0Q0akg3Z0lU?= =?utf-8?B?OWx5MTlWYUVwaXFQQ25LdFFRVU1GeENwbXNMNEcwWC93MjFKN08wRnlBeFpP?= =?utf-8?B?QmhNcmh6dytkaVJ4ZXJyalJ1SFFidkU4TjBPSjZvVGNyaUN0QkZhSkNOSkNa?= =?utf-8?B?aG03QjhzTCtLT2xySWVqR3RTc1FwZ1k2cHROU2ZGTm5WdThUZHpOd3FvdmZo?= =?utf-8?B?WVgvdGladkJIOGtuYWN4aktYTXNxOGkzQ09SL2d0RjBHQ1gzL213V1hmT2tl?= =?utf-8?B?a3QyUDJnZXliZFp3dkI5WGVLZ1B2andacUtGMlpXSTJPeFp5K1NCaTRzRXpw?= =?utf-8?B?eFZ3OFQ4MzZpMzRsb2Nqa1dva1lsZmxnazBnY2dYUW8yNHRXejV2U2ZoWEVv?= =?utf-8?B?L0pQRzhtL2w0dm9SMUJvMFFhNThpMzRRYkZYY0tZQnlqNXBYZkZibUJwWTFX?= =?utf-8?B?NlUvZFYrL2lyMklsc3BWK2dYKzhiOERTU3QzYzNYSjNUWmxLT1VKbDViQ0Y1?= =?utf-8?B?VHlzNWNSaFMwMk4vSnlvSWp6TFNyQTRLSVZ4V1plQVVXY2R4Z3ZENW1IR3RU?= =?utf-8?B?bkR6Mnl4UGliN1drS1hXVmRhVDY1dHZ3b0d4ZElXNUh0VWIvZXlyMXhxdG1q?= =?utf-8?B?Ni9TQlgyRWhYRm9ab1RhaGFtYjQydjE0a3JMRzlrdGtaQ1ptQjRYQ3BVelVs?= =?utf-8?B?VE1SbmsvQ3JpdzQrTGwxS2w5RlJNL05FL0s1a2dTN2g4U2NNQTZteWtOWlpP?= =?utf-8?B?dUt6RS9mQzlRa29xTFhHM0VVbE5DK0ErS3M5Y29zamt1MldQNWllOTRXQlJM?= =?utf-8?B?V2h1em1KaHl3QlY1TEFNdXV6RFZacVI0RUpMbE9iYjRoenlrNGY2c3dDcGY3?= =?utf-8?Q?JJvmYCE+zIIZ027XranfMNXCu?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52e20b5d-a248-4764-72ff-08da6fbc99d7 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:41:45.3321 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iNR8XKQV18XQaqxFmdi2fe9ZNub59TNmAjizDHvc3o4DqRnUUAteSy+BP6H7HnLMpljM+mOMBnhdk5ux0lV5gQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2263 Coverity validly points out that the mfn_add() as used was dead code. Coverity ID: 1507475 Signed-off-by: Jan Beulich --- a/xen/arch/x86/pv/dom0_build.c +++ b/xen/arch/x86/pv/dom0_build.c @@ -130,7 +130,7 @@ static void __init iommu_memory_setup(st IOMMUF_readable | IOMMUF_writable | IOMMUF_preempt, flush_flags)) > 0 ) { - mfn_add(mfn, rc); + mfn = mfn_add(mfn, rc); nr -= rc; /* See comment below. */ for ( ; rc--; ++page ) From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:44:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:44:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376044.608625 (Exim 4.92) (envelope-from ) id 1oGeWX-0004up-A7; Wed, 27 Jul 2022 10:44:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376044.608625; Wed, 27 Jul 2022 10:44:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeWX-0004ui-7Q; Wed, 27 Jul 2022 10:44:17 +0000 Received: by outflank-mailman (input) for mailman id 376044; Wed, 27 Jul 2022 10:44:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeWW-0004uY-CR for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:44:16 +0000 Received: from ppsw-42.srv.uis.cam.ac.uk (ppsw-42.srv.uis.cam.ac.uk [131.111.8.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0e857b44-0d99-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 12:44:15 +0200 (CEST) Received: from hades.srcf.societies.cam.ac.uk ([131.111.179.67]:54812) by ppsw-42.srv.uis.cam.ac.uk (ppsw.cam.ac.uk [131.111.8.138]:25) with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) id 1oGeWU-000AB7-Cw (Exim 4.96) (return-path ); Wed, 27 Jul 2022 11:44:14 +0100 Received: from [10.80.3.248] (default-46-102-197-194.interdsl.co.uk [46.102.197.194]) (Authenticated sender: amc96) by hades.srcf.societies.cam.ac.uk (Postfix) with ESMTPSA id BECE11FB69; Wed, 27 Jul 2022 11:44:13 +0100 (BST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0e857b44-0d99-11ed-924f-1f966e50362f X-Cam-AntiVirus: no malware found X-Cam-ScannerInfo: https://help.uis.cam.ac.uk/email-scanner-virus Message-ID: Date: Wed, 27 Jul 2022 11:44:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup() Content-Language: en-GB To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Paul Durrant References: <13f6ca1c-559d-b89e-207b-d2685ea80bef@suse.com> From: Andrew Cooper In-Reply-To: <13f6ca1c-559d-b89e-207b-d2685ea80bef@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/07/2022 11:41, Jan Beulich wrote: > Coverity validly points out that the mfn_add() as used was dead code. > > Coverity ID: 1507475 > Signed-off-by: Jan Beulich Acked-by: Andrew Cooper From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:46:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:46:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376050.608636 (Exim 4.92) (envelope-from ) id 1oGeYP-0005XC-NO; Wed, 27 Jul 2022 10:46:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376050.608636; Wed, 27 Jul 2022 10:46:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeYP-0005X5-Jr; Wed, 27 Jul 2022 10:46:13 +0000 Received: by outflank-mailman (input) for mailman id 376050; Wed, 27 Jul 2022 10:46:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeYO-0005Wz-29 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:46:12 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 522bd99d-0d99-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 12:46:10 +0200 (CEST) Received: from mail-mw2nam10lp2100.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 06:46:06 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DM6PR03MB5129.namprd03.prod.outlook.com (2603:10b6:5:1eb::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 10:46:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 10:46:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 522bd99d-0d99-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658918770; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=2H7Xk5nN2/wEUsdUiR9+iVtjYWT9AOUJiLQr+li5S1U=; b=SDgKZIxzOuXOxEdHBDOjHkRUhPEsPIbQoIpgxf6b2YY0SFQ4a3w+Dq9Y l2dPpylHsrSTnPBtWmp8sPvGN4nlA8glX23w1niLKEATNBo1CSFmk+MHA Ta9UVAqHsIa27D3YgQcQ+VYBn/0irAEIAAODTUbSelCoIjscTV4bQIHhe M=; X-IronPort-RemoteIP: 104.47.55.100 X-IronPort-MID: 76725124 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AFWkt/aL7wWltGRF5FE//H55yqmolRxNeyxNyt?= =?us-ascii?q?3ClJ83I83tWLY9U/1M1TtTqPb7RdcPX9eFSkeUyjDPjDhmbA/iZCYnXWPvbo?= =?us-ascii?q?GfyAjKero8WSuoJKROtBLe51pzqpRrcaqoL6uoNMAjO69CH84cjrJbXTerwM?= =?us-ascii?q?DPeGvqEFFcHIFtJJVYz3Vr3ibL1CUf0Dfc9wNp6gIRO3srlfoB3mr1fgAIiJ?= =?us-ascii?q?0fV6ja7NemqagnkSmh60j914TrpVoJ+kTxUX5k81MN91yCpADO7/cR+w6acl?= =?us-ascii?q?U4ySVRuh1pyDVd0M7EEfepn/9o3h2MroSFK5Mxbpn+J0MkYn/VsV1oW2IxH6?= =?us-ascii?q?GRz06WgdxXPY1rJOKE5Wg4SfTh9Z6Ww+TecUQ3lXvpLobz9JJThmeAqStCdD?= =?us-ascii?q?sCU9DFrQx9YffjkO3ZGVeF3HZXADRUyAraniTZOYa3O2ncZ+kLjugSw1IEFw?= =?us-ascii?q?FbfeXMfynuQl/BL3kPuLv2eFiImUyVZPmdivZUCv6Bxx2LUKRq8g5R1REMZk?= =?us-ascii?q?dTS+uZr0lIZLRK/vGrGojm7zwkLlmdaGuN9f803V2CB2+sbB/VtQsFS568fM?= =?us-ascii?q?C/saP0aBHR2zCYbN3zvkAkzDCGoBbd1ntLz/2lPaj5+ZGgUmHXSHoknR4nqu?= =?us-ascii?q?m/s5Ym73bhADLYolOt/X3oplVlI7FA6SyMeckDraosUC2vH7WVqwty20z0MQ?= =?us-ascii?q?XSn8FIcHaR0cDbbVBfUcgznoKBQsY6zGMfcncqS+6lUfA/T9Bb6mdT1mNf4U?= =?us-ascii?q?Ik8mJu3f1/f5U+aiesDw2BIaWRJAJZrWHqcUYPXobKBV1mgwq2XIP28Qmy2v?= =?us-ascii?q?Kq8NWfKx6Sx+nCk601IfPT15zFU2rkZYD71/51Lst8YVKX6rDrgcFxCNCwpR?= =?us-ascii?q?aQL4evRDR47Zv0QwZllU9wY/FGEIJw7DZ3z4bd7erqHnpRDdgLOJisxexJpf?= =?us-ascii?q?pmqdjq3r10vUsbkld7JtA7uH2ehE2EnSmeY3OHvfJfy79HW/apNlwmS2jDjq?= =?us-ascii?q?vIfGAQBE+l5yC6CzWiqMKY5+oBDhKZXSISh7n0l1YCk8m/6KoYWykOTP6WO+?= =?us-ascii?q?+YO+fDp1Fq4+97uczbM0saVEiA/m6/J4vO+gz//kZQVEbR6z07sRSLf90Zlu?= =?us-ascii?q?u1mIPv7g4VlSrOQjHaxhhBcmsH3lic2WlRvL5PNHpjrc2mnouyO2kuIs7lMV?= =?us-ascii?q?TW7ndIdp5Cr6Q3poH3Htc/T+9LXpWgm2IUDEgg4R864UcPiXcpVauAPAmfbC?= =?us-ascii?q?UkuKKLE+BS0hblroCMG7nc2F90JuTJEDv5J2FGvB9Y29C/K4C0z7s/KX0shb?= =?us-ascii?q?yjuH39lFo9QuxmjTU7lqs4rQUF9DNl+syMPtZGjXhEVuOVIZluNthINajQgs?= =?us-ascii?q?jWRE9BxkXmakbNS78YYoIdqkj/KW0Qyds1YoNmIqDC0K5+uwmjEtukkbQunF?= =?us-ascii?q?uDjtVf9eGn85JCxaYqqbC6kzKdcKo5rTUKO4Y8WG1LTr95a+yY2eOqFVw7rR?= =?us-ascii?q?Zia0upDtbcYTE5N12ypj+4huhMC7TWJidLxliqimZx3MvOt/bFl4fMurE+/x?= =?us-ascii?q?6VdzLuXppYFuFH4XiYzOhoTP1+N+se5XVzxQ7shmg2p72KP6zLSTgOHvqf1P?= =?us-ascii?q?xKn8X4Fp8UFeIcFtDYx5c+INp87Y8YjLNzDAci2ZbX+ESXYGiERCe5fi8Hsl?= =?us-ascii?q?+nlCAoSXUFKogLCWJ+XeILHKoUwRcihx8tjYSOpOW+jP66I/jXnTfQAQVKCZ?= =?us-ascii?q?TFXuJ4XFKM98Bc8/OWiGwnv8rM1DBxZIcrZId9XO5vr+LsL2/RHXt3WQC1ty?= =?us-ascii?q?a/r0zZThnkyc78xljRXbSUTn+N5JXoQxmdqecaVIasdstvPLgco6xy1UQY7T?= =?us-ascii?q?/+g/O54nqKjuM3Kuj58f0+TsttYgzBFOZsff95sBlOY0yuTLzftFgwn0zyWi?= =?us-ascii?q?/B6/ZC+vi4AxutBy9cG43+Nbcet0C6lpVsFNszAR5FYCO/de2cL5AgPRmiwT?= =?us-ascii?q?tzvLYCwUHKCtiIgJY/lI4GKWv+m6kgl5lJoVhfIWw8WwTPkpfwwc5BJtTpdG?= =?us-ascii?q?ss5l9/z96a+yqi2bt8ll5F+9OaUV4B0TtEdl2kQSAgiKL0wYodFukhLYLgAm?= =?us-ascii?q?fDaZSTHE/15wK5EsDvj/iVMvn866XkW8EB5Ls7Qm1pFB8cjP1Sh9LvPRjkGl?= =?us-ascii?q?k+yTXMGHyEwD4x2T8UUeESUSooherbObajcMs5QV7Q01FRfYP56HgQFcgX8J?= =?us-ascii?q?KYZn+dIRv702H8uLUTCP3adaAlVZEfsSjm3DM9ASrCZ26+w6+nD00U6AFMci?= =?us-ascii?q?hFYmtdiktz0qvihReHz6EJGrPTqxuUsxYsg64SwGGbVueDKeYaNKUJ0XJm45?= =?us-ascii?q?Npj7ZoBOQUPrHshtC79gL4fBBA8Um+gumkxr9ZPjoLgHyt60Gt2Jc+tj2fM7?= =?us-ascii?q?R/Dh2AHOM2/RIKKKcZi5fEVjdG1ToyJumMzX8qlAP10j6E8plBMZHGS3qVtW?= =?us-ascii?q?0DzJHNYKmUKd7r4fJVcPZlgakgv9XVZ1nYnCK9bdP29RWZhhatZdB2g+vha4?= =?us-ascii?q?oXPQQ=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76725124" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BciU5WhWTpSjg/xC7TBz6v9Li6PZ+sqm56r2So5H6pDVrVr1KB1p5BiSp3mRY+h/CHnsWxaaOaunBvX0ZCkfzzeTIBLTmAM4Jh0tOETuGtTKbrAXPT7n631zikIj0fzbk2di+SPOkupDb9C7xRQvX/B3O1ogDz8jag/zaqc3ird7bJ5/Mv3p7Ixvh4hOVIU9NaXxiDDGmIr4GseobNpzjXovd/wGa0PGTF12rH1P7d50aXMdqV2tP0O88OssdZzTJaZQVRoVigBaX52hy5BMEK6QC5nwHj8aLvUe1a5HoeVqb+FHlMgnbM5VbS6wOyEcJ6iDKC7qlGJH0a6fpeTJzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2H7Xk5nN2/wEUsdUiR9+iVtjYWT9AOUJiLQr+li5S1U=; b=YQ66EAut6zTVOmBAWIVtU1jTMK7fXFrMcRQ32Qzc9IkatTVJ1ocA0kgUQw9+buccuD1k0KT3GVXGMpOtNmSDl0c9Phycmn1tXo8scg/8n4AeZnXyaIj7LqINS+cXB08A4d+/1CN3pnm5PPxluMq7r5uhpkXktaQYYs3PXtQ6/QtxFqf+xKi88YupeADW9WpUmVxpeSMvyicmlT0tMJ2S2Hm6BW7zYJp0/HniY/Fqb6BTcOs8TVxrytr6mFHr1AD+Jx26VPEXCyrYSXzyRTB50t+16OibrN3b5jHqpuRitlbv00x0cCicDkUcsDu9zrblkBkRMwhQd+aWnQVNWFYlKw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2H7Xk5nN2/wEUsdUiR9+iVtjYWT9AOUJiLQr+li5S1U=; b=qkRpcCwV6jk9+c5yOoP6Xv16S0medFuEJnHgtvyc9UI40dSQ45fJCXoL/+5P/Oq/qvV8ab85wLkLc6ONdwNKrwwxgvExMfXW/dstx5oCInGnIFxKyOTKYd1e1RkPLhxYnn9Nhdw/6ibYr1DbNpjm2gxvKPVscIzbvwhVDWkPi+I= From: Andrew Cooper To: Andrew Cooper , Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , Paul Durrant Subject: Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup() Thread-Topic: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup() Thread-Index: AQHYoaV9YQ4YmJ68iEaHOmfXphsBA62SCFOAgAAAhIA= Date: Wed, 27 Jul 2022 10:46:04 +0000 Message-ID: References: <13f6ca1c-559d-b89e-207b-d2685ea80bef@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ea79ce87-f753-407f-d8b3-08da6fbd3427 x-ms-traffictypediagnostic: DM6PR03MB5129:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uiK34nOr4uClvZw4nixoL7yNy1yfNluzb2vgPuEIsu25oeyxPXwM2odRixtoXz3kKREB0BJSYb+CxmsHednb4AMYAOEUDGBjzefM+cTzumCIIzQY0uzBynywKnvreItdLxl/7iOngE/Lhoe+M7kSUNQbcNxat/QEqy/WjrwPYn42XP8RiB+hrP2/5cOwvbzVSvxlYtBdqWjruT7kzPiPHSHhjO8yS9+36Y0vyg2DHZZKQD1YHv4yQtQjeD90pHsKqr8LA1LQaveAGb9hTbk1yn51YNrFwxFLfBypSmfaLDaNEOsIpm036hVMw/lb6SkokfSAw0EDk9KRSUosycHyb8P04FAKxKlmdVxOPHajcVyTw35RyDuxHI5daHgZ3YiSeLZpUhbeQkGCppHpxC1dQ0v/qVaN1nO1AKSeEbLm2NyahtPzu7jo7VpSR3nYWP4zyRVNMz8wvSMePdL7eXgafSFkeZ8VnmWQL1SXdPu3TWeokSdDxnK80CiBf7CWLoN/Fu9tP7HcxmBEvRWNcADLxfqWeV36ZEvhMpmcv8pSSX66+JEI4ofjX2Udfzbg2hRI6xqyZu+ErQNAH8IkTmgDRXHuQT4YFkTuG1qEm1LCo7TdKX1tF3JIcso9lytHcldy0YZsGaM+bEXuwxto1yCoKs9DnkQO1YiNhwchrTtoU1LBmyipT0+iZ0LpqA9bDPKgTziwIWvNm+WZ0PPCElG/IpoJjm/cpi9dwisvx4MkTglDKWNV6FH6F5qFbJukq8Rn6czD1i4jKWM3sbZ96boqTPZG6a2X/TPzdNTocGo/vaNofiYnXcTekFqffa0gWxEt/Wkxnly0FCmKIT7PBJ+1v+1fjCKpYQyPqomqSGZ7Rfz59UiBJixO7mwbvzTJXyIa x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(136003)(39860400002)(376002)(346002)(396003)(8936002)(66476007)(186003)(5660300002)(8676002)(4326008)(66946007)(76116006)(316002)(66556008)(91956017)(110136005)(54906003)(64756008)(6512007)(26005)(2616005)(53546011)(36756003)(31686004)(6506007)(41300700001)(4744005)(38070700005)(38100700002)(122000001)(66446008)(86362001)(31696002)(2906002)(478600001)(71200400001)(82960400001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?dDF3ekE5em9XN0F4ZmxUUW1wRElnVytCd3NPMk9SeC9YUm5KNENUVDEzV0lM?= =?utf-8?B?bWVHQ1lIS3RIaHJEamxVeTFxdUpnU0l2YWdoYm5tOGFWVUhQc0FtMGhpVzRB?= =?utf-8?B?aWNUc2x1TGh5dzB2NzVtZGVTSEFkQUJWdnppdWYwNWJrampMMW80ZXZhS3F3?= =?utf-8?B?dzRSQXQvazQxMUpaNmJtbmFNSXk4MUFXdTlCNUlBZ3pSTW82a2xsL1FPanBm?= =?utf-8?B?b2FHUll5K0psNWFWU1dXa0gxSkFCQlAxSUltTTF0Q3JHQXRCVUJKVlI0V3JU?= =?utf-8?B?VUwzc2FJSDVod3U3SUlNL0U5R2FKOVY0eHdGZ0dxRHdxVzNCeHFlVGExYVRL?= =?utf-8?B?V3U1ZVhMZEpPd1cxL2s3QlMvK1Z6d3V3aXhSeUIzTDZ5MGlLOU96SFo5OU9k?= =?utf-8?B?WnMxMGZtbnMwNGxNVkFwRUNHUkVUOXVmUlJ5UDY3NEkrcmlZbDFhcU1hNGVM?= =?utf-8?B?WDV6OWVHZFRFckllTjBRbmlocjZWVlhWck00QklxaWpQRGJwcDNjQkMwUUM3?= =?utf-8?B?YnFFWjlPVmtralFiWlpnc20rNUxHS2gvdlJSZ1JZQS9WUUVmYmsyMElVc0dP?= =?utf-8?B?MFYxNk8vZmtpQUxwbm9YRUJrRUJjNUppT0EvNUY4ZktRVUJBZlE5TnRoNlhT?= =?utf-8?B?VmxEdXZMMnJrZmdTb0k4R0t5RjdqNUxkdHJWc2NhazNMbGpqakIzeW5rbVQ2?= =?utf-8?B?UnVIZENVQXIzenBzRnFHY0EwNE9iT3l1RHRWTUpGWlBNMWNTMkMycmgyRGZq?= =?utf-8?B?U1luOVZKMkUxRHgyaGk3S2IrT0xTbzY2Sk5PTWxzLzNTcW5RYTRhR2czRDQ5?= =?utf-8?B?d0RpRkhLWnovcmo2Q1hqMkp6Vy9uREhacmM2aDdHclpmT2dnRzBIVFJybm5j?= =?utf-8?B?YXFiTEdWZHNGbnV3YTRNZXMveEpDWjdjeEhDa25rQm42MkZaWWttYU11NUFP?= =?utf-8?B?VmJKaFk4VXlOZDlWbzFqN20yZWVYNEV4TDUvY1FRWkZpeUNDY3dFWVpGNW1M?= =?utf-8?B?UUtLYXI5T0RCRnZoSlMrWmN2RTJYUWdVQzZuVmtDY3BJREl4dVJyTk9LNVRP?= =?utf-8?B?NVRaYVlBMVJyaGhlRysySHA5WlB4ZSt6ak15ZjJPdG1qckVtVFlxNHd3Zjl2?= =?utf-8?B?eU9xTE1kTnEvRXpZZ3phc1Q0anZyaEkrSnFTbktZVzVSN2JvTXVKcnlLcU1S?= =?utf-8?B?RUE3ZTNSdTNCMXYxVUoxZUgyaDlzQVFpRDNtK0dJb1F0bm80NWNHaTNSSFlO?= =?utf-8?B?ZkRzeHR4aE5PelA4RkF5bElRQzBlc2lkakVYQ2wrZVk2eVJLMjl3OEd1eVhx?= =?utf-8?B?bW1JaDdCS3Q3dE43cUFBWC94b3lUbjFEMmJIT05HRDkyNTJZWGZGWVlJS1Bk?= =?utf-8?B?YkRCdjVjV0I0M2xId0N1SXFjY1hLa3ZsUlVwWTZFbWtKZ1NuU2RzenVZdndP?= =?utf-8?B?WGEya29CcE10N0lzbnhsN3lpTzlROUxyTWRXRXpwRUYzZDlzSWtJK1Z2c0tZ?= =?utf-8?B?cXEzbStsTy9jVlhmeHk1UlQyL25MME9EbFcrZ3d4MVU3VEdvOTJUYmhUZXQ4?= =?utf-8?B?dGwzaWtGZ2N4bWR6UzZ3ZzhiM1o4bUtYTm1WcU45VGpsL2F5RUYxSnpUKzBp?= =?utf-8?B?MFdjTTNGT2lXaGNvT21MTXJJeThjdWt1c1BtN0hBU1NLRktMclg3YjVUU2VH?= =?utf-8?B?KzFWM09wazVRRVplT0YvMEdpNXhpNzJNc0dILzlLOVZCMlVjMHZBS3g2cWFX?= =?utf-8?B?Z3hmb3puUlo3RG1PRnZNUTYyQjBvR2wyNzg4dTgyOVhKTzlzYWpYZzZ2dEtu?= =?utf-8?B?MFo1NXd6YnA3Q2NyQzdoR3orVUlIVDVtYjhQajhzbjJaclhWMnlsdVR2a3gv?= =?utf-8?B?dDdZM21RZ09RRld3TGljaDM5d05JdkRyRklEcnhCZERRSkNMRlowOUZNTGR0?= =?utf-8?B?TU1aeEh3RkoveTdIUWMyQkd6OHk4TTB4cmp6MFpjK28rZ3BqOXRHbXE5Nzla?= =?utf-8?B?NEUrYUVQcVkvRmNBRkhIUnBXbkt0Tm1nYU1JZ3YwMjJKSmVJNm8rZ2lxckd1?= =?utf-8?B?Y2tZZTZtUHdLWTZhalpvNG8rWWNHemowVmYyL3RyM3dtWWhpbjNlTE1pVDVU?= =?utf-8?Q?yz378ApiX284Xxq264pDL3qGg?= Content-Type: text/plain; charset="utf-8" Content-ID: <9AE70D71CFA62D4DA02635049A1E3B61@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ea79ce87-f753-407f-d8b3-08da6fbd3427 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 10:46:04.0406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XwC8GB8wawvIAsMbzJ/0ss8fBEcNF36XQ1hrs0zQzfx9R1n5/4UT9PMiZwb9lFIE22/v/i06uF+/DZkX7894oeuTVHUWNckIvFnFs6bWSqE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR03MB5129 T24gMjcvMDcvMjAyMiAxMTo0NCwgQW5kcmV3IENvb3BlciB3cm90ZToNCj4gT24gMjcvMDcvMjAy MiAxMTo0MSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+PiBDb3Zlcml0eSB2YWxpZGx5IHBvaW50cyBv dXQgdGhhdCB0aGUgbWZuX2FkZCgpIGFzIHVzZWQgd2FzIGRlYWQgY29kZS4NCj4+DQo+PiBDb3Zl cml0eSBJRDogMTUwNzQ3NQ0KPj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNo QHN1c2UuY29tPg0KPiBBY2tlZC1ieTogQW5kcmV3IENvb3BlciA8YW5kcmV3LmNvb3BlcjNAY2l0 cml4LmNvbT4NCg0KQWx0aG91Z2ggb24gc2Vjb25kIHRob3VnaHRzLCB0aGlzIG5lZWRzIGEgZml4 ZXMgYzFlMTU2NGM4OTk1ZCB0YWcgdG9vLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:48:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:48:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376055.608647 (Exim 4.92) (envelope-from ) id 1oGeaQ-0006He-2z; Wed, 27 Jul 2022 10:48:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376055.608647; Wed, 27 Jul 2022 10:48:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeaP-0006HX-Vr; Wed, 27 Jul 2022 10:48:17 +0000 Received: by outflank-mailman (input) for mailman id 376055; Wed, 27 Jul 2022 10:48:16 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeaO-0006HL-BO for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:48:16 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9df90f98-0d99-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 12:48:15 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB7PR04MB5497.eurprd04.prod.outlook.com (2603:10a6:10:8a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 10:48:13 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 10:48:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9df90f98-0d99-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TaaQ4duVb5dqT5GK4vg5YAWUcbH3VyzDruD4Jv2cX4e6r496jMLONxfLK+TEef+YMYmfJ0Ra4o8Q2lTaMBWPnCQOY1tGsaF+21hsAxRs4z0WMaDFqCF7anJfLK4pBcvV7K77PIwox3ZDkP4LVlgVYq77R9z3/138NFdUQyNI2VX1CH46Ago3RrlWBmDZ8fEmlcKS2RUHFx+IpS/H57EcG+Z99YASgxj8X+xHxqJPk9bGiuSd3E7Z1aLRvdErahW4gfOLavM1sY9oJijIsRjriwzmils6wZOurBNivaifyhImhbMOrTCKI/P8oKXEoT89Nm/Voxai1Eb09AFIEh6q1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ZodIK44oQNCpMRJ6hqorMeZoI7hGSt0V3b6pyUE9Xw=; b=LHKGb4rhcjSoQhPcfv/H4ObnMzIgtU6dtZi97RBmId7zHeoMRBFkwYWhwlPcg7tNtDU09ZFCKoctF5+0R5EqwyMoUBGFWfCc+dd8BCH/66KGTRBIuVVKsj7OnEjfydUP+IZbvztb5gaJ9XXl8Q20N3U6qsYK2MxRHrN+wdwq+FvAoPPQHYQmogMPlP4j42TKK0n2A3/H1uLKxntffSPBiROv9xgcp9FMGiod/N9OfnQhFonZY7mcAannJ12wyG+uBr8mpoDcYf8sm5E3RTGElIy5FCGTS/8w122JOYie47GhPLf0SJdziVptgkBPBVucsqiPgOehrtwm+0Hd6gvYNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ZodIK44oQNCpMRJ6hqorMeZoI7hGSt0V3b6pyUE9Xw=; b=VPGuJTTqvcRTikvU0A83iuiOT02ZnVjW0/auQLh23wHiwkVJlZXt549L2rx3aljMX/p+GFak//ezdDXUSLnkF6DNxr1nKoKed6wl23GcJLYQ5MMrsONP2pbjCD+qXwAahkgRbZh5Vj1KfvBO/lb0jdh5WW+m5lwkMxxebvBmDBzGAejPw5R6pFkQP5rr31BHAzLEtTc2hrAcgzbEUWHSaei78LA0D+JXolI4qjYFwjq/hOYPGIgsXHdlkWpkkjv45NQkHL8zJ7HARQhYTPVJTL0NluBrq5TFZPlvsOz991i+OGhD1rBEWAPWVxOZGd7p2gLXafPKvpUNl95vfctJhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <5ffd7303-2814-37a0-b1ba-aaf5b21837f0@suse.com> Date: Wed, 27 Jul 2022 12:48:12 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] x86/PV: correct post-preemption progress recording in iommu_memory_setup() Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , Paul Durrant , Andrew Cooper , "xen-devel@lists.xenproject.org" References: <13f6ca1c-559d-b89e-207b-d2685ea80bef@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0129.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4ed4bf4c-acf8-4c0d-16f3-08da6fbd8126 X-MS-TrafficTypeDiagnostic: DB7PR04MB5497:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Tb1HeTFddxfu+wFuAZ/nH+XZUDijAM1OcqxPJvuo9uB/JsifiPCG7BJ1LxEDXB57aQ90NF07tc4stq1F/0zwRrTBBM76k5v8m04/1tjixw7EKDwzyVXyf35hheTlcFH5m/RL5lJE3MC51bgHHBOjZklAjM+VGE+TNj85oXoIwkvcl2DRgC4b8xSwXcw9xhqr2qD+Z8dfqiQhYGVS+MjUlEZuTNq6rUgqlCMeLbqb8q5iXBjavI8DP/IifBf2UjqvoXLsY9Pk8jnkbsHS/fYwLv1sWRz7l74aXSGtaVFz+iUg8TlRdjelRzJ7XzjnyHwm42Kuy2EPf6/Md6+hWUEV7nZAovfTK8wqsBP6ReQ8DMZhLugmRQ+VyM74GQVSzkKeubIqHjghwefQLoFapr+RT/d30nPzWcOZdylZcnLqc4AyT31q0beQuNowCpYi5nw+QtAXMjM2bt77r0Nkw9/d+r2pxsQgyw3hr574582DaprXb9Ud266Rxh2w72OUBtGUr2VXFnOqDofFwfepg04s5PrSUvIAn9218lInfYnIyEbS+RVAmSwl8RNobrIsuZrdU6m+XCR5mzWjRMnsDX6e3aMdoXHxqVqICeP+S8B+4lz1nE0w4Y3RO+suFRHRAlc8NdkEnWmENYLpnHIb3pfOgoDEI0dseDMe5lnLxVkcEXm0c/Jz9Wu+ncNNIrEAr0sYLZaguOTYnkm62091CNMWNMVpgcWpipD1ZzlhErAApga0HNPDfFznqPSH4Z3Nlx2VZgx+ZwSp/VvupGDfkRJJ58zMj6viVLlhG3/n9O6ENVfb0A1JlsUvxfv09mblM9pMqOw1rU2AWB7B93fk7+jO2A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(346002)(136003)(376002)(39860400002)(366004)(5660300002)(6486002)(54906003)(41300700001)(6916009)(8936002)(36756003)(66476007)(4744005)(66946007)(31686004)(66556008)(8676002)(316002)(4326008)(478600001)(2616005)(186003)(6506007)(2906002)(31696002)(53546011)(6512007)(38100700002)(86362001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cGpwU1NkRFppTjF3SnA0TXVyQXpRQU05UzJiSjA1UUo1dUJGdnVJZCt1MjJI?= =?utf-8?B?WW5OS0hXajBYQjFBaWNlUjd6NVBPanF0cldUQmk2d25oVHJnRWlJczFuelYy?= =?utf-8?B?T0NyS3NFVm5yVStaT0U0WTA2ZlVzdFFwOGF5MnN4YjdBbzdUWU90Yk42K202?= =?utf-8?B?ZDUrUHNFeVh1b0xYQ2dEUlVoQmtqM2VmbDF0aEo3NzFXckNvdXU2NVVIZjZW?= =?utf-8?B?SUtwZEFYc1RRcnBQS0dCakNFSmtMbFoxRU5IWlNJcVpJZnVtY3YxZDVZV0pJ?= =?utf-8?B?WFFqc3NxV3NoNVBVRmpYR2d4L3p0YmlwRkFhK0tnMVFsUmx3YXdMUUlLUjlp?= =?utf-8?B?OXRScnhTWk1OMEtNM0xsL2VtazBIYmFXc0pudWZRQjB3dnJ5WGJCKy9LZGVm?= =?utf-8?B?M1NPbkRXVlpyb2o2L3RhQ0UweWlCVmNJUnBvckQyaXY1QnlKZGlqdjBDb2dU?= =?utf-8?B?QThaUmdGekF3b2RER3dMU1RnU1NDYVRWWnVJMVoyUkRZTjFhRWxjN3ZvdlZB?= =?utf-8?B?eHJ1WG9Ja3k1eTZ6SmpWYlZubTNHYW1FeE5RUUxneGYyU1hTM2toUnRJdXFV?= =?utf-8?B?Si9JUkxwRTZZTUp0dk5RY1ZqbUdiczBpUXMwTVNWRHE3VHptQThLRkE5REZu?= =?utf-8?B?M0RTZEJwN21aODR3NVlVaTUzTUllV3pRWHd0V3FKcWdCRitSWVVOdVRCTy9s?= =?utf-8?B?TmQzZGV1SXprMWo1aVhxeFZBNS9RZ3NEd1VxUmllNE1UYVp1QjJGZ0NiMDBt?= =?utf-8?B?RjBQczlnVktXSGJxY3ZVQlRDQitja01YZWVuTFNYelJMb0dhOEN3NnpES1Rj?= =?utf-8?B?MjB4NGNiVVRZQnd1SXJVRHUvTTZpRy91Z3NEbG93Rm9NTHNWR1UrSEt1dFhX?= =?utf-8?B?NEx5RjVpNE1ieG1lb292SDdKSEdEOTBVWG0ybC9WY2dNQVZHY1RoVDRmNm9i?= =?utf-8?B?bm1Ock96aEFxTWRtTDBldFRsSVYyMEFrbklOTjFaSGQ4ZFVidk1PdUlvUU85?= =?utf-8?B?MDRHbDd3anovRWpnYXBGSTlFdGJsN2pZcHNqMG1paTZlRjc5VWI5K0hlVE4w?= =?utf-8?B?Q2pxSHJrUW52ckRMU05ieER0ZXp1RkFCMmp4cFJJbk1RV1RrK1BtU08rSENr?= =?utf-8?B?QmhLM0NPMzBjVXdHSlgra3NIS05TK3hFQ2N2b2FvWW5EeVFEMEVLNG1oSlVL?= =?utf-8?B?NFRZN01vNnE1QzViSFEwekxjSkR5RW9EMVFsRUh6VDBCQ1dJb3h0aXd6OG1s?= =?utf-8?B?bzhLUDQvQnBFTVpZMDNEam1ONTM5cjB2bC9YTmdPYzJGVWhQdTBGOXl3TTVs?= =?utf-8?B?elp5NUpQZTJiZ0dPNW1kQW9jaWJaR1BZU1ZhbUVud2FSOWFjb2ZRL29oc0pr?= =?utf-8?B?NFpDY0JDZEIrcXdrcXJnekxDd2lKSG9VUmJtTFBoclRJZTNta2NpNHM1QTNq?= =?utf-8?B?UEc4Y2pEVXRDTjV0ZEc4L2lXR3FzY25NdXZObWR5TUZMWlRVeFdZRGxKZmhU?= =?utf-8?B?dWY5Z2U2S2plS3lFREtCNHZ6dG1RUEZOeHZwazdYc3BRaGFaR2NRNWhaNjBw?= =?utf-8?B?TFF5bmhINzZSWjBVd2ZCL3UwbXhBb2ZFenFhdlVWWlBoZDlZQ1NZODhWWllD?= =?utf-8?B?S0M4MnBqdFFHSi9aVnIxSnpwTklUaXRsQSsyRDNUVXM5a0UvUWcvVSt2VHZ6?= =?utf-8?B?QUoyMHl2TEdsTGRwdDNPa1ZFVEtWZ08yNUxRdWM2N0JpL1RXd0R6Y2FKdFhl?= =?utf-8?B?TjhsVVdIYi9VL2E2NDdMemh6TVVvSjRHNUQySE56U0w2UTBlL1M0UjdGZmN2?= =?utf-8?B?b2JqZ1pjNTVkVlI0b0FZTTlZUWFrblVZRXVKeWNuOC9LTk4wWkpnNEFiTVdE?= =?utf-8?B?U0hnMG9IOGxNZFJuek5naU9XTmwrTG50MjdtSVJ4QVgwc080WDBod0VwdEZR?= =?utf-8?B?N0xlcm5nYnU4VkZTNzE5K3p4TlhtaUNic1haUlFaQjRSa0VjaytBWEdhTzBO?= =?utf-8?B?MVk0Q3M2Tis3K0crMDJMd2ZXMytaaEFTVW5VNk1DVGNCWHhKVEV4QnNZUEpt?= =?utf-8?B?aXNFcTIveVB2cDRweTVES05CQmFLL3E5L3g0QzYvTTJFZThXUEE1YzR5Zit0?= =?utf-8?Q?+u00iDYi2Cg53tA1EWPz8p2Fm?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ed4bf4c-acf8-4c0d-16f3-08da6fbd8126 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 10:48:13.4168 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5gxuexYUMOas5O6vRRuPAAtsSKkwRCbQmq35W8398bIUHnicRHm7g4pk583G5e5rRzd76QNd0elu/Y2Fl74zZQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB5497 On 27.07.2022 12:46, Andrew Cooper wrote: > On 27/07/2022 11:44, Andrew Cooper wrote: >> On 27/07/2022 11:41, Jan Beulich wrote: >>> Coverity validly points out that the mfn_add() as used was dead code. >>> >>> Coverity ID: 1507475 >>> Signed-off-by: Jan Beulich >> Acked-by: Andrew Cooper > > Although on second thoughts, this needs a fixes c1e1564c8995d tag too. Oh, of course. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 10:57:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 10:57:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376064.608658 (Exim 4.92) (envelope-from ) id 1oGeit-0007tq-To; Wed, 27 Jul 2022 10:57:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376064.608658; Wed, 27 Jul 2022 10:57:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeit-0007tj-QH; Wed, 27 Jul 2022 10:57:03 +0000 Received: by outflank-mailman (input) for mailman id 376064; Wed, 27 Jul 2022 10:57:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGeis-0007td-CG for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 10:57:02 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d662d130-0d9a-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 12:57:01 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 06:56:50 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA1PR03MB6562.namprd03.prod.outlook.com (2603:10b6:806:1c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 10:56:48 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 10:56:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d662d130-0d9a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658919421; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=Jo4v3tCyTo7UsiCgD6FlMYvgg1umXOt+HzjEdqsAhXw=; b=Mf13GOV4R6NGlvL6WHhT1aoYyIIk9kQgPUpD+QSy5V56Pp+bVmjwjBQe T7LgUrzTXgeMZgVEiENLDsp3Mat77MvkVDXbYsXjwI3qU9mGfcFQOceH7 0HTYZ0hGSbf4T16s1WjOaZsBuwYSlYaIujDFo7CXs/qrsoPigJRgMzQ1K 0=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 76521717 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:9naJwqrZD3KlSPEzFWZ1bQemWABeBmLXZBIvgKrLsJaIsI4StFCzt garIBmBb/6KYDSkKo9zb4W0/EkBvMLXyIJrTAJu/i1mQnkVpZuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqVG0O17B2QVs sYTIXMANRuqhMWXwfGCH7wEasQLdKEHPas5k1Q5lXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NvuQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE2bGSx3qkAd16+LuQxtFDwwTM91IvCDoLbGun/um3lxKBYocKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS6hyLjKzd4A+bB20NZj9HdNEi8sQxQFQC1 VKXntWvGT1mtpWUT26Q8vGfqjbaETcRBX8PY2kDVwRty8nupsQ/gwzCSv5nEbWplZvlFDfo2 TeIoSMiwbIJgqY2O76T+FnGh3epucLPRwtsvgHPBDv9tEV+eZKvYJGu5R7D9/FcIY2FT16H+ n8Zh8yZ6+NIBpaI/MCQfNgw8HiSz67tGFXhbZRHRfHNKxzFF6afQL1t IronPort-HdrOrdr: A9a23:3Vsgq6ypLVOgNCN8FOVnKrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2x4Uh37D30XklZqvoJhiKobwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76521717" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KFsr+NfTVuS2k9nqtL5RE4vg4yaIcJX2aJbYKN054oRKX8/lDMJYARJ1JFTnEqMRW6Umi0aomC5W6yW7pREyWVknyg5ABGezLxFccf5ad8pmiQwf2QHjgy6x8xbxBmqtaN3IBHVK1A3y+MCg5R0Vphf6fayhmcNdG3qtoIBRzm8aaDdPk29EIIcHRUXwKrsbYT9bzCoe4e082SZb8lOi0M1nyjLuz3MAhtjL7VmZh97ZB78pgxeLRk1M1eK5h1bOFkXi3AriMztkJSAWYRlUMkNoyr9rxoO5eu25+yLAAB721Xg5e9ICUzs0S+SZjuZ8hMyIwYvxdyQQV04QC78HCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jo4v3tCyTo7UsiCgD6FlMYvgg1umXOt+HzjEdqsAhXw=; b=Eyeiilu2TiJJqVKnytSICwx07g9hWP1Q2q0I6B3+/77t+lHrC9CSPSk8wfk/KxV7D+ucYPG1B2aOBr3vEWPe9rtmV5Vk6jrnwSKGT2JdkQ/gK7CFlU/qOONNtaDKxo1jrl6oxymMdTPi4lgakBxvbEGwllkRiUwnbWyZE+iCJfaRpSOHUMOWhDhT6RS9B8J9KN24SnODNSagUavlxDJMaz5vpqqDAibheHvfZ81o0KaJAEcbbMlPqsMFk7jJSgQin0IhlHMC9r6xee/faMa5Edd5IvZMfA1yuiLw67IUd5HaNA1kJrCv6SMdQe+tdeoh4xouOlGyaogA69jI+wbR8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jo4v3tCyTo7UsiCgD6FlMYvgg1umXOt+HzjEdqsAhXw=; b=IOWPkxWnfi+oOaKLbJPpnGXKhreP00Ydky1VYrzqBedyYD8Bnb5rJMMdVHoK95bGNEe4aCcdvwV5sQ9mkF4nJXLRq+TsLCPh3Jczr0PPXyaJxj164b2ZFeRrVkK4iEiVBLIJXC5AP8Ar6MrmkahMG7XhU97YgsdpA0HYeNg9Sf0= From: Andrew Cooper To: Jan Beulich CC: Jun Nakajima , Kevin Tian , Roger Pau Monne , Wei Liu , "xen-devel@lists.xenproject.org" , Edwin Torok Subject: Re: [PATCH v2] x86/msr: fix X2APIC_LAST Thread-Topic: [PATCH v2] x86/msr: fix X2APIC_LAST Thread-Index: AQHYoQRqcpYxNv8GZ0++T/cX45qn262Qx/AAgAACuoCAAAFdAIABQRAA Date: Wed, 27 Jul 2022 10:56:47 +0000 Message-ID: <229f6385-0078-978c-41ac-b321b31fe34e@citrix.com> References: <3e5ceee7-533b-1cae-262e-b05b5b22692b@suse.com> <3b23d5a1-4b49-6c12-2539-dcd1bb2de735@citrix.com> <83c1b506-27d5-19e0-89b0-a6a27b4e5535@suse.com> In-Reply-To: <83c1b506-27d5-19e0-89b0-a6a27b4e5535@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f2b63f9-08bb-48ed-52a7-08da6fbeb378 x-ms-traffictypediagnostic: SA1PR03MB6562:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: hrmGaik/4QM+rfnm/OmXpTa+vRZLCtFPbX1uoFkDE2hTger1NxHuinR9GSJJFOQYLuHjAKTsB70eqZuBMG6xlrN2mWghiv0W6F+JNAtBjQowvDIyjpRfyyYZvwr6ARXzrXnDy1yC+YXC2FrW7k18e0bWzRw09p7HLla2q5R2RHJFzuNCHpXfJAZAY4gbjUn6NnrCo128DgxWJ9lqMMxXnezTypzeXFYZZaLIFB8UBSFe9dGBlsFly6W6YTCWfxjWIaTwV4dPQqVUiijIuHIwbM3jz9uGTSxeR6ejYZzTfLS+mlDSzBmQEux7nUFxe1ZzERLRGd2MvFWdoZDSrYHCwq9Okx+dcBM6BsNtrbEDj5w8FX6HvGlshbAgyyBsX0/OrUEHNzvB4/hQLdN6XJwChWvNvIwX/yLN0BGTQwlrfaR9Bd3GxrVOwP8lgMo4aOv1h60137QRxmsUpINedRmWaRMAbq5RPfEBkevUq5tU2Egx8eIHM/dhzK8Fw5ysnCYp3yG201srvpPjSbkeIz64I4KUfscw0jh89x2ZVqlJ+9LrSsquo3r9ys0X3F4sW55psxhx7XsBpe+/e+9GDuD0fz93jrmx59WVLhWWMsmEDdU2BspS9qJ9R5TxxhFbOkBnaQcyLy4NLFrbbzyDd+7PjLgSneh40eik6mhfLTMT83xyV81iKH13hh9Y9ImeusNWuw2ABhvfUbSIrcsUKb048Rxu++B8oEYyleO82T7Vp2jLGdueGP1p7r8vFSdsICQYlRM1s5fZiOxIZeuQiU16na9mzvWDqXmmGfYjrDLChljqWXotfg5L0nElfA9lbA4AMagPg4hFs4EweBUFcOSvMyMxqDcF30+irNhSqy/2AbcFvExSCaz/OMZvZvtoOU0V x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(346002)(396003)(136003)(366004)(36756003)(86362001)(2616005)(8936002)(31686004)(478600001)(54906003)(91956017)(5660300002)(76116006)(66556008)(71200400001)(6486002)(8676002)(64756008)(66946007)(66476007)(4326008)(66446008)(6916009)(53546011)(41300700001)(122000001)(83380400001)(6506007)(107886003)(6512007)(186003)(38100700002)(31696002)(26005)(82960400001)(316002)(2906002)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YklieEcvdE10Tm9jdlZQby9DRVc0YmtybEhtY2lHSmMva1JWa3hhL3Rrekt3?= =?utf-8?B?M2VpeEw2SGphRjNYbGV6L0ZMOUErczBxcFNFT3MyZ0Zwckk1ZE04M3NZRWc4?= =?utf-8?B?Sm5JSzRsNU9ZRUd2RFliUHFwMThxQm51UzQ0a3c5RGRHVkNmV24zaWNjKy9R?= =?utf-8?B?ZjFqVUMya05uYVU4YVIzT25FY3IySzBvVXBRcmljY1BJOC8rOU9oTGtQU0o0?= =?utf-8?B?UjRVa0laV1pLTHkvSmJZWlYzVXFqdk93VmxVNTZSTGtLUU5WemZrSGRBQXJ2?= =?utf-8?B?M2JyUzQ3MktrRTRlMWU5aXpJeitacXd5Zm1BeExmM3RwRlZNOVREb2l1NElV?= =?utf-8?B?Q3BXMjgzL2draHJGTk9HdHJ3dEhDYzhtWjZkWk84YllTMSt0V2E1SW9zVFNn?= =?utf-8?B?VEMrRkN0REMyblpMeE43dUh2OTJPTUtQbE9vTjc2Vmx0eUQ5MWlLTERzNnJL?= =?utf-8?B?Rmp2ZWd1eEdKMlpvbklOZURJMTZ3dVF1MnE1TzNwR3RwU2VJNFRVOE1rUjZo?= =?utf-8?B?V2hmUWVQM3k5QUsrL0tDSFQwU2hsa0swdGlNVHRqS3V4OE1lRG1paEdqS0p2?= =?utf-8?B?Nk9CL1FvV2p5dzI3K3oxb1lMZU81ZG5WNFBsMUZLVEdIMEpGMDl5S0FuY2Zy?= =?utf-8?B?L3pqa1BGNlBQZWVUMXd6ZFMzZzZrNGF5RFozVXAzMUViaHowY2xLamZhakp1?= =?utf-8?B?cE9CaUdLaEFwS01SU1FvU0h6bHJZR0h1OHFCdDlpODdNZm9WK1pMd2xQYWQw?= =?utf-8?B?SHpaM1pJNS9xSXhrR29penJaYmlzOXZTdEJnTFhiYkZ3Rzd0VXJQbHlHL3pE?= =?utf-8?B?NHFDZEFqRTBZM3lxRUZ1dXl4SStNZ0NwOTBxejNRakZUTjl2SmFTM0QyUHhZ?= =?utf-8?B?SnhoQ3NzdXlHeU5VUnhyVHZNdFZXTDBUeDFmV2I0OXVLMlpYMEFvdmJBQUVZ?= =?utf-8?B?R3orTC9rUk9TM3ZLdUFibVY3ajc2aWZKZGp0ZkpmeXgzd1Vna1kya2JvenF5?= =?utf-8?B?elJpZiszOXRVWHJ6K0FHdll2QUh3emtSN2xTc2hWTStjWFdoczRhaUtROUhu?= =?utf-8?B?M2hZU3FINGhab2FXd0dWdFVFbmNhRTYzMWpDOGdxbkxoTnFhQ2loa05XMi84?= =?utf-8?B?eFVhMDhsRVdlMzJGT3l5U0JvUEpPNlFjQlVlSU56VCtqWnQwQWZoRFo2WDdt?= =?utf-8?B?WjA3blpKRnFLRE1YMU91dE4vOEpzR1lqVGQySmNnZFdzc3RtdklWNjMvQkVM?= =?utf-8?B?d0RlQjUvSFpaUllvZnpSWEQ1WmM2TlZKUk5oRjRNck1HRWc4Vjl2SitFRmxK?= =?utf-8?B?RjJuWm5EdGEwekpoTXNzV25yeUpTTk1KZ2JwU20vWERFY2FFS3BzeVZ3Rlla?= =?utf-8?B?N2k5ek9XaEM4VGkxZ0YrYThPMjQxY2FkSHArNFZRc0pwL3hmc0h5N2JZYUF5?= =?utf-8?B?L1RNdy9NUUZQNGgrNUtPR3FSSENEd1F4Z0lFcFlVTmsrcEc4STRybHhJV0xk?= =?utf-8?B?T1NKRS9ISFVXWWk3UG9VZmJnY05rNDlMcFFBU002NTRKZnpaV2wrQXB3NXgw?= =?utf-8?B?MzdQc1BLN1MxVTZ5N2FRSG5lU0VMMlpWNG1Jbm56anNXOU5KaldEeTd1Ny9G?= =?utf-8?B?d0tpbEVtZlplSkpaeWdOb1RBSkQ1SHZYaFFub0xEYnJ3Q1FFZkp2T3hQU0Zy?= =?utf-8?B?cTVZUURQem4yeXZDakxyOUljRUcxZ0FMRDNqT3Jyam5GL1lobDZDT29YN0hh?= =?utf-8?B?TzRGM3dFdVRaWHNLWFpyMFd3cE1hWDIxa3J4SDBTWXVSRmhiRFY2S3FHVEZU?= =?utf-8?B?eUxsaHdqT2tGZlp4U1drWmszZkR2MmtleXdNREIyaVljY3BVT2V1NTBEZFVC?= =?utf-8?B?UUJtR3JmbEtOSlMwbVN4VTVRaUJqSEtpVFlic0d5eVVTRy9abW5NY1dZVE1v?= =?utf-8?B?d1NvYmxOKzVvVkRudGxQYnlNdUtHQVVPZTdNQjdZWnJKSS96cW9rSXZ1MXNa?= =?utf-8?B?M01IdTBDMW1qQU5OVTlHTVFhM0lLaDNETVpVclZWWDFNeHZ1RGRyb3dQTEo3?= =?utf-8?B?QkdzNkw2QVFIa2JxRUVSbE1STDhwSS9IeFAxaHJneXJobytPM2FYMDUyMVRK?= =?utf-8?Q?Ny5BK1QVptKMYoeH/xdGt3i7k?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8f2b63f9-08bb-48ed-52a7-08da6fbeb378 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 10:56:47.1510 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m0RfmkkQRNgcbY0Gm2n1ovbJNAM4aAJpY6C9LyH7JNTqmBoMvuVmKikxj9IcBJvR1T9ohrLD3Qbj8nzpOYb485/npkX9pzhGt0keH3780tU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR03MB6562 T24gMjYvMDcvMjAyMiAxNjo0NywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI2LjA3LjIwMjIg MTc6NDIsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyNi8wNy8yMDIyIDE2OjMzLCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiBPbiAyNi4wNy4yMDIyIDE3OjI4LCBFZHdpbiBUw7Zyw7ZrIHdy b3RlOg0KPj4+PiBUaGUgbGF0ZXN0IEludGVsIG1hbnVhbCBub3cgc2F5cyB0aGUgWDJBUElDIHJl c2VydmVkIHJhbmdlIGlzIG9ubHkNCj4+Pj4gMHg4MDAgdG8gMHg4ZmYgKE5PVCAweGJmZikuDQo+ Pj4+IFRoaXMgY2hhbmdlZCBiZXR3ZWVuIFNETSA2OCAoTm92IDIwMTgpIGFuZCBTRE0gNjkgKEph biAyMDE5KS4NCj4+Pj4gVGhlIEFNRCBtYW51YWwgZG9jdW1lbnRzIDB4ODAwLTB4OGZmIHRvby4N Cj4+Pj4NCj4+Pj4gVGhlcmUgYXJlIG5vbi1YMkFQSUMgTVNScyBpbiB0aGUgMHg5MDAtMHhiZmYg cmFuZ2Ugbm93Og0KPj4+PiBlLmcuIDB4OTgxIGlzIElBMzJfVE1FX0NBUEFCSUxJVFksIGFuIGFy Y2hpdGVjdHVyYWwgTVNSLg0KPj4+Pg0KPj4+PiBUaGUgbmV3IE1TUiBpbiB0aGlzIHJhbmdlIGFw cGVhcnMgdG8gaGF2ZSBiZWVuIGludHJvZHVjZWQgaW4gSWNlbGFrZSwNCj4+Pj4gc28gdGhpcyBj b21taXQgc2hvdWxkIGJlIGJhY2twb3J0ZWQgdG8gWGVuIHZlcnNpb25zIHN1cHBvcnRpbmcgSWNl bGFrZS4NCj4+Pj4NCj4+Pj4gQmFja3BvcnQ6IDQuMTMrDQo+Pj4gRkFPRCBuZXZlcnRoZWxlc3Mg aXQnbGwgYmUgYXBwbGllZCBvbmx5IGJhY2sgdG8gNC4xNS4NCj4+IEl0IHNob3VsZG4ndCBnbyBi YWNrIGJlZm9yZSA0LjE2LCBiZWNhdXNlIG90aGVyd2lzZSB3ZSBzdGFydCBleHBvc2luZyBhDQo+ PiBidW5jaCBvZiBNU1JzIChpbmNsdWRpbmcgdW5kb2N1bWVudGVkIG9uZXMgb24gSGFzd2VsbC9C cm9hZHdlbGwpIHdoaWNoDQo+PiB3ZXJlIHByZXZpb3VzbHkgZGlzYWxsb3dlZC4NCj4gSG1tLCBJ J20gY29uZnVzZWQgLSBob3cgd291bGQgdGhlIGxpbWl0aW5nIG9mIHRoaXMgcmFuZ2UgY2F1c2Ug bW9yZQ0KPiBNU1JzIHRvIGJlIGV4cG9zZWQgaW4gNC4xNT8NCg0KTXkgbWlzdGFrZS7CoCBJIGZv cmdvdCB3aGVuIHdlIGNoYW5nZWQgdGhlIE1TUiBkZWZhdWx0IHJlYWRhYmlsaXR5Lg0KDQpUaGlz IHNob3VsZCBnbyBiYWNrIHRvIDQuMTUuDQoNCn5BbmRyZXcNCg== From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:00:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:00:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376114.608703 (Exim 4.92) (envelope-from ) id 1oGfiF-00004u-CK; Wed, 27 Jul 2022 12:00:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376114.608703; Wed, 27 Jul 2022 12:00:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGfiF-0008WT-9N; Wed, 27 Jul 2022 12:00:27 +0000 Received: by outflank-mailman (input) for mailman id 376114; Wed, 27 Jul 2022 12:00:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGfiD-0008WB-DG; Wed, 27 Jul 2022 12:00:25 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGfiD-000481-9z; Wed, 27 Jul 2022 12:00:25 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGfiC-00007W-De; Wed, 27 Jul 2022 12:00:24 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGfiC-0007rL-DA; Wed, 27 Jul 2022 12:00:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=CuXUQDYUk9DtsLQwyTL/Du3OqYjBqE+EBcfByApu1mw=; b=nCJsBvPUkMKLe41KBBIWMiz4Sv 8+L8cbO0unxJ3jPVRLdK3XmzXJjn7U1/xTGJ2OnRAqXVi2pfWTdQmPjfMPSCR7M4oRr64W4G3ZzZp vNhGpKV9YtRmoSWSNYuHLulPCQDbxMu4FS5mFs3Pfrr6nZGqzlqrgtqh6rImrm2lP++w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171872: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d X-Osstest-Versions-That: qemuu=616a6459d878999b37c7cfbf1ed8d4ca84b3751f From: osstest service owner Date: Wed, 27 Jul 2022 12:00:24 +0000 flight 171872 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171872/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171863 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171863 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171863 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171863 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171863 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171863 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171863 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171863 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d baseline version: qemuu 616a6459d878999b37c7cfbf1ed8d4ca84b3751f Last test of basis 171863 2022-07-26 10:07:00 Z 1 days Testing same since 171872 2022-07-26 19:07:49 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ake Koomsin Alan Jian Alan Jian Dr. David Alan Gilbert Eugenio Pérez Helge Deller Jason Wang Laurent Vivier Paolo Bonzini Peter Maydell Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 616a6459d8..f6cce6bcb2 f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d -> upstream-tested From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:25:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376144.608714 (Exim 4.92) (envelope-from ) id 1oGg6C-00033z-Da; Wed, 27 Jul 2022 12:25:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376144.608714; Wed, 27 Jul 2022 12:25:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGg6C-00033s-Ah; Wed, 27 Jul 2022 12:25:12 +0000 Received: by outflank-mailman (input) for mailman id 376144; Wed, 27 Jul 2022 12:25:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGg6A-00033m-4b for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:25:10 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10059.outbound.protection.outlook.com [40.107.1.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 26ec0ede-0da7-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 14:25:08 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4017.eurprd04.prod.outlook.com (2603:10a6:208:5b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 12:25:06 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 12:25:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26ec0ede-0da7-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejrFcOLO/H53pOQqR8RUumwpImCplgOAnp7br21jN21WC/pfL8aIIbF8ISAcmhyGyZCsez1BZeQ7sArj2fIHzpYQ4dOrNzCZpTlIf25VBJGbeb3c+JJpMrEnTkBF5UaklXaEE1+LqjBLu3c5Lw+p1YqzN+r1VEPsmvhPFG38jFgZCz9Toi5WsuCXCfPmqyav+4IR8jawOxMZ/acpJD3pPHgSjKIzToWIgnz6Mo8fUhteV1iCauae+/ypPvXc51NvL5kdwP8mY+2IHXxrQNjQHVKZmeSrKFp9BPGfGHUmFiyeoODQ8SRRPK+QUGvhFF8zMw4e9cG1PLFYJjBU4QUISA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CtzhcsiHCHjulapMScTLDR09bCy43he6C9mapoEDS/s=; b=a9+wmjZNrUSyM2cLPsVp04mlFeqMyF0365ey+02lEpJJnmQd4HrKXV6EH/Yc+oU7JSUVkuZyR9+2vSSOLUuMYTKRRDOONl37Hre8F84qLxNJnqlwpRyBksMtEq+7k7GJ7N+f+hJ6yC60VN5JipXca1cgwscBkq8KUT3HMskjjGlPTxCOXZNjInYcOHxMvBqBx2rpCXW6+B1mHTGtFPXDueGOBXg/56a5I2NBUtd3sBOPeB51NEgjXIZH3vzJd888m1gOJe0K6pOF+Z/iv9OqCfTCNpivz/9EjyLG5UqegZBva4/3hE4DdfLH9b6yIf8JQgBxapLGU4wiBo9dsjZVZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CtzhcsiHCHjulapMScTLDR09bCy43he6C9mapoEDS/s=; b=DWv0H75jNsJ1UkcV+mYO2LTzACiYueARZ8y8fTyyFjvcwbd4B+CXdRzx7iFHrVoppW9Y8t27AZAQj+3r09G1Zm66mPg60unvYwfRd7qLJ5MnqSBtK2mncxuYn4d0rFVT+xV0q5jm9KppmyHB6K0gq1VQfRZju+x8t7X8hUVUvilh6ccNP5zZpNwNzPWLUCM1XSE4a420zgigJWWPKBd+yA7jttaGaHGmTwdgHVkHXVeZbcCaUIDKOkUVdhRsTcS4U42ZXXGZVIUq4cBhrfQiaznyf8xsOuR+DcIqnQLJ2SUy+HH8k/brg+LjlIEo7ZG+YYoEDXgJsDglda8+W7zOJw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <95a90911-df4b-2946-9f01-86d78acb94d5@suse.com> Date: Wed, 27 Jul 2022 14:25:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 12/18] x86: convert dom0 creation to domain builder Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-13-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-13-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0090.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f4cdf666-ba06-4fff-456e-08da6fcb09ec X-MS-TrafficTypeDiagnostic: AM0PR04MB4017:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: He8nMoS04p8/AT9liNGwCVoRR+GgwGLqX372eYJK084EU7oja0nGfSrYPrTNyjH9+zxMvtGyOnxsPefZYhP0V9d5kZl1zYFQ07tS0XmdVd7Rffa80rbO4UQtA9u8A39LGx+rASKuo2Hzf3oo5QZdjp5IV1pUq2ut5olQwrLh9qVM/+y1naTmoSKAC00e2UXUtOEyiNcbOHLtzp9JIiTVPZvRIH51YzUuZ+y7bESzVDix+5nQtZV23ddSo7uNlFzUKxzFP9phXGc0CdpgwgtD0BxcDhB2PWxZfQJf7FRJxY0+dXOO3vIHhg17lNTO6h/9F/K8TLUqAXBr62QAg0wYr3mfnqKyvZSPGGPWkpWjX972fNgqIwoUaZ6mtcQ03vNjHbU+SHYujF1LBdZmn4PLxslMGIkcuh1MRSyE+gVLxBqsjDfXItkf6t0rnYho+l4eIfCDRyGmjhIV7P+EyyLIOXEjozBGXArpuDxKhQU14n4EvxInJU9AUotPFhM/QyZvo4UQIb/i0C0Ts6OAy8DpRIx70a97S1oO0vd0WsVEDcOhc09VE+cRNm9mmridFE4Zso7bmxPGflVHOkVJu8y5JTsQSj12zW4iP00NlL1ZV+SzglhxbU0g+3OzfWLxYXthAeSbNHm3acfzhiw9q35ECT/8OJDRONlq1thJCpe3RZ+ZCoxcAPa8qtHWVsgkEvl0bKINMlECTYRyxaKAM69BUlRbf6W38bvpzplwm4psoTZbUNziO9YJrLVpuOghiqJz/Pfs7FFKsTxOpalmG3NZ0jLDOc/O/5U+PO2aF72T/js5UpcuebyEsq54i6QvdRKLsD6hPR1/I2pQNewp0OE/sA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(346002)(396003)(376002)(136003)(53546011)(83380400001)(5660300002)(2906002)(478600001)(8936002)(6486002)(41300700001)(54906003)(6916009)(2616005)(26005)(38100700002)(86362001)(186003)(31686004)(6512007)(36756003)(66476007)(8676002)(6506007)(4326008)(66556008)(316002)(66946007)(31696002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVJGbmhUSVhBZnpjbVRDWDM4L3NqdFJldWY2cnVRZEszVEt6MUYwOVIzOUxY?= =?utf-8?B?YmhqdFlKbFV3cnFCOGlHa0Y2T1I4RlRqTjkrQVZ3WVhFTEZmOVYrR1BOM0JM?= =?utf-8?B?b09hbjUvSG56b0xYbTlXa3c3dDk5QzlZY0haWURTeVJzODRTTkVzYWdBTUpl?= =?utf-8?B?ZElFSVJYRXA2cUtTZ0N5Rm5uY3hZSkRMc3RtTTNPZnpVMEd4ZWZqMnphdHhs?= =?utf-8?B?RlpnQ2hvUXFlTVlOQkZnclExOTRmVTMvRXlzQ1ZHbFJZZ2ZDWjR5bGhhbUVl?= =?utf-8?B?a0w4dVpPRHlRT1E5OFVGdUNQcW9jS3M1Z2pYZXdmVGhxY2UyWmtoNjJSNmJp?= =?utf-8?B?cmIzRXNGTkt1eTB0QXhDcjVtUzlWc1k3QkdhTGRMc1N2TGdWU1lFbWlHYkJk?= =?utf-8?B?Ung4NXRzNjN5dFI5Y1VuSnRrZnh5d1JMWGtQbWFxeWg2OVBNWitUdUlCUDFC?= =?utf-8?B?TEY0Z2l1VmZGRWxhbDJFczJiemVmMy9oNHcvZVhGYzNUQy9BNFpicmFWWmJl?= =?utf-8?B?WUtPNDNIdENadDFuWG1aT0NZMVZPTVkyU1pkYmc2a3lHRUZVajkyalpQWHA5?= =?utf-8?B?L1M2UHQ0TEZ1SWRRQWV5OEkzNGFqL1pTV0tvMGJjZFh0c2g4YTkrRmtkVWVm?= =?utf-8?B?UkZrYkdIN3FVZ2orMTB2RmwrUFlQUGJtNnpoQjRqeTBqQ1VOYzJjazlHVnJL?= =?utf-8?B?YUo4LzE3bk4xLzd6NUpPYnFKRGxVMWRLOTVZYkJFVWNtalNmdmRtNlNZSDg0?= =?utf-8?B?UWJidU80R0thSVhzSnQyTWNFV0FQTlRIYzFqazYwSmx3S0ZSc0labG1QS2du?= =?utf-8?B?Wklua3VoZnN6bFA4aFNrVmc4OVhiMm1QNWhPQ2N0TmdtYk5qT3N0djliVjky?= =?utf-8?B?L1FFR1hEYnJVcWxadC9jdDZ6Z3Z1Z2kxTUJrVFYrTVR1QWFDMVRXaVVnSTly?= =?utf-8?B?Z0JJMmpWMkczSFNkVStiOEJlRVliSmdHdXZHQXROb0czVmlmM2Ryczh4byt4?= =?utf-8?B?WEQrZ0ZqRHh6cGw1VndqeWhxTEhqRFEwZkIwa2pUYVY4a2tud0xTUjQ3Q3hY?= =?utf-8?B?UkhwMlJmOGwwQi8rcitKRWVxTkd1bkRBVitsY25pTjRrdWRBZ1FIZXk0T0JX?= =?utf-8?B?d2dQQWl5c3JoajVqNXV6U0NydVJ1S1NrUjBERGd0d3JRckFhTUZDdVE1a2Nt?= =?utf-8?B?UVcyaWJBd2xydEgzKzQydm80Y3Z2eVZHL3VJNGRBbTgrckRFRGd0SHUwYVFT?= =?utf-8?B?OGV1QmJuQWdvR0dGeEtMNmlzQXJXSEVRV1haSTA0UlhpSWMwV3VSRmdqRXU2?= =?utf-8?B?ZTVUVXMyMjJDa3Bqc0tTai9NZ1YvaUZlY1o1dTQyWXZmQVczSjFNd01jT0NB?= =?utf-8?B?dDhTMHh3M21HaE5zYWttSWkvSFA3eDNzWEE5U1lYRlBscGwvazBIK3NuNlVT?= =?utf-8?B?UnQ2b2JuWG9vTC9LQU9ydzNJb1hWa0ZnbzBkdU9wYnU0azg3a0Evb3VOblBs?= =?utf-8?B?R2x4OXIxOU1FeElmQkkyOTlOZkYvS0d2aHluNzZHMmVva3dMbmVJemZiUE5D?= =?utf-8?B?YzNZRjg1ZmVEaVBPeHc3cVlXa3pyb3hCN0MzTldCZVJaeC8rTlR1c1lLakNB?= =?utf-8?B?ck01eU8yTnZ0WVZlWVhuTXJDNmZiRnc0WVRzZmpueWJFWkZkSHJtUkN4SXZF?= =?utf-8?B?dHliRzFsUGJIV2d3ZDBqbXlVVVZHdzd5NkFwSUlnRTgzZEJ2ZHR4OUdSVSt1?= =?utf-8?B?Q3VBM2VCa1g0bWF3b2I1VFBKSlZzTHNsSUFOQ1FOcWl5RVAwRHZZMDdqM01R?= =?utf-8?B?ZVVmdUh5ZitxdVBqdGQrblB5RTBXQTQ4clBBcmViR1hCa3RJdTZXV2ZobUJh?= =?utf-8?B?aS9HVVJPS2JacnYzZVBUbjFqRit5VEpiZzhzdFlZQmowb203Zy9vZStrMzJ1?= =?utf-8?B?dDlFTS91QXFidjVobjY0aGplTmdhMTBaQ1V2UnU3bTdidzdGcEdvMXh3eDFO?= =?utf-8?B?RlRoV3Q5ZVlCdkp5QkpBMVVTSys3clBuaUZ5RFhEK1EzazdxcCtzTHRPUzEr?= =?utf-8?B?V09ndyszUDVpdEMrbCtiOTRYRGhwNmNpLzlRa0tiQk9PbFlQUERUV1FJSzBZ?= =?utf-8?Q?WcdvR89FHsHZaV+laOBoUYi2G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: f4cdf666-ba06-4fff-456e-08da6fcb09ec X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 12:25:06.3119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BJCYvTquItBhUd4b8RkhJCfRjlAngkm/nBj7HcKL9s9WoNzn/hz3O1Yi+YjQUimn64GFPqMrrwElqusTBMFA3Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4017 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- /dev/null > +++ b/xen/arch/x86/domain_builder.c > @@ -0,0 +1,128 @@ > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +extern unsigned long cr4_pv32_mask; Such declarations need to go in a header which both producer and consumer(s) include. > +static unsigned int __init dom_max_vcpus(struct boot_domain *bd) > +{ > + unsigned int limit; > + > + if ( builder_is_initdom(bd) ) > + return dom0_max_vcpus(); > + > + limit = bd->mode & BUILD_MODE_PARAVIRTUALIZED ? > + MAX_VIRT_CPUS : HVM_MAX_VCPUS; Nit: Indentation. > + if ( bd->ncpus > limit ) > + return limit; > + else > + return bd->ncpus; return min(bd->ncpus, limit); > +} > + > +void __init arch_create_dom( > + const struct boot_info *bi, struct boot_domain *bd) > +{ > + struct xen_domctl_createdomain dom_cfg = { > + .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, > + .max_evtchn_port = -1, > + .max_grant_frames = -1, > + .max_maptrack_frames = -1, > + .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), > + .max_vcpus = dom_max_vcpus(bd), > + .arch = { > + .misc_flags = bd->functions & BUILD_FUNCTION_INITIAL_DOM && > + opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, > + }, > + }; > + unsigned int is_privileged = 0; Either this is bool and retains its name, or it remains unsigned int and changes its name (to e.g. "cdf"). > + char *cmdline; > + > + if ( bd->kernel == NULL ) > + panic("Error creating d%uv0\n", bd->domid); This gives too little information and, by mentioning vCPU 0, is imo actively misleading. > + /* mask out PV and device model bits, if 0 then the domain is PVH */ > + if ( !(bd->mode & > + (BUILD_MODE_PARAVIRTUALIZED|BUILD_MODE_ENABLE_DEVICE_MODEL)) ) Shouldn't you outright reject BUILD_MODE_ENABLE_DEVICE_MODEL, since you can't fulfill that request? > + { > + dom_cfg.flags |= (XEN_DOMCTL_CDF_hvm | > + (hvm_hap_supported() ? XEN_DOMCTL_CDF_hap : 0)); > + > + /* > + * If shadow paging is enabled for the initial domain, mask out > + * HAP if it was just enabled. > + */ > + if ( builder_is_initdom(bd) ) > + if ( opt_dom0_shadow ) > + dom_cfg.flags |= ~XEN_DOMCTL_CDF_hap; Please combine such if()s into a single one using &&. And I suppose you mean &= ? Furthermore - how would a DomU be started without using HAP when HAP is available? > + /* TODO: review which flags should be present */ > + dom_cfg.arch.emulation_flags |= > + XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; > + } > + > + if ( iommu_enabled && builder_is_hwdom(bd) ) > + dom_cfg.flags |= XEN_DOMCTL_CDF_iommu; Why would only hwdom get an IOMMU? > + if ( !pv_shim && builder_is_ctldom(bd) ) > + is_privileged = CDF_privileged; > + > + /* Create initial domain. Not d0 for pvshim. */ Up to here I was assuming this function would deal with more than just Dom0, based on conditionals seen. What's the intention? Mixing things is at best confusing. > + bd->domid = get_initial_domain_id(); Higher up in the panic() invocation you did use bd->domid already. > + bd->domain = domain_create(bd->domid, &dom_cfg, is_privileged); > + if ( IS_ERR(bd->domain) ) > + panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); > + > + init_dom0_cpuid_policy(bd->domain); > + > + if ( alloc_dom0_vcpu0(bd->domain) == NULL ) > + panic("Error creating d%uv0\n", bd->domid); > + > + /* Grab the DOM0 command line. */ > + cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? > + bd->kernel->string.bytes : NULL; > + if ( cmdline || bi->arch->kextra ) > + { > + char dom_cmdline[MAX_GUEST_CMDLINE]; > + > + cmdline = arch_prepare_cmdline(cmdline, bi->arch); > + strlcpy(dom_cmdline, cmdline, MAX_GUEST_CMDLINE); > + > + if ( bi->arch->kextra ) > + /* kextra always includes exactly one leading space. */ > + strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); I don't think the comment belongs here - there's no insertion of a blank in sight anywhere. > + apply_xen_cmdline(dom_cmdline); > + > + strlcpy(bd->kernel->string.bytes, dom_cmdline, MAX_GUEST_CMDLINE); Further up using MAX_GUEST_CMDLINE is acceptable, because it's easy to see that this is the array's size. But here this isn't the case - you want to use ARRAY_SIZE() at least in this one case (ideally everywhere). > + } > + > + /* > + * Temporarily clear SMAP in CR4 to allow user-accesses in construct_dom0(). dom0 here, but ... > + * This saves a large number of corner cases interactions with > + * copy_from_user(). > + */ > + if ( cpu_has_smap ) > + { > + cr4_pv32_mask &= ~X86_CR4_SMAP; > + write_cr4(read_cr4() & ~X86_CR4_SMAP); > + } > + > + if ( construct_domain(bd) != 0 ) ... domain here, yet then ... > + panic("Could not construct domain 0\n"); ... domain 0 again here. > @@ -745,109 +746,21 @@ static unsigned int __init copy_bios_e820(struct e820entry *map, unsigned int li > return n; > } > > -static struct domain *__init create_dom0( > - const struct boot_info *bi, struct boot_domain *bd) > +void __init apply_xen_cmdline(char *cmdline) > { > - struct xen_domctl_createdomain dom0_cfg = { > - .flags = IS_ENABLED(CONFIG_TBOOT) ? XEN_DOMCTL_CDF_s3_integrity : 0, > - .max_evtchn_port = -1, > - .max_grant_frames = -1, > - .max_maptrack_frames = -1, > - .grant_opts = XEN_DOMCTL_GRANT_version(opt_gnttab_max_version), > - .max_vcpus = dom0_max_vcpus(), > - .arch = { > - .misc_flags = opt_dom0_msr_relaxed ? XEN_X86_MSR_RELAXED : 0, > - }, > - }; > - char *cmdline; > - > - if ( bd->kernel == NULL ) > - panic("Error creating d%uv0\n", bd->domid); > - > - if ( opt_dom0_pvh ) > - { > - dom0_cfg.flags |= (XEN_DOMCTL_CDF_hvm | > - ((hvm_hap_supported() && !opt_dom0_shadow) ? > - XEN_DOMCTL_CDF_hap : 0)); > - > - dom0_cfg.arch.emulation_flags |= > - XEN_X86_EMU_LAPIC | XEN_X86_EMU_IOAPIC | XEN_X86_EMU_VPCI; > - } > - > - if ( iommu_enabled ) > - dom0_cfg.flags |= XEN_DOMCTL_CDF_iommu; > - > - /* Create initial domain. Not d0 for pvshim. */ > - bd->domid = get_initial_domain_id(); > - bd->domain = domain_create(bd->domid, &dom0_cfg, pv_shim ? > - 0 : CDF_privileged); > - if ( IS_ERR(bd->domain) ) > - panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); > - > - init_dom0_cpuid_policy(bd->domain); > - > - if ( alloc_dom0_vcpu0(bd->domain) == NULL ) > - panic("Error creating d%uv0\n", bd->domid); > - > - /* Grab the DOM0 command line. */ > - cmdline = (bd->kernel->string.kind == BOOTSTR_CMDLINE) ? > - bd->kernel->string.bytes : NULL; > - if ( cmdline || bi->arch->kextra ) > - { > - char dom0_cmdline[MAX_GUEST_CMDLINE]; > - > - cmdline = arch_prepare_cmdline(cmdline, bi->arch); > - strlcpy(dom0_cmdline, cmdline, MAX_GUEST_CMDLINE); > - > - if ( bi->arch->kextra ) > - /* kextra always includes exactly one leading space. */ > - strlcat(dom0_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); > - > - /* Append any extra parameters. */ > - if ( skip_ioapic_setup && !strstr(dom0_cmdline, "noapic") ) > - strlcat(dom0_cmdline, " noapic", MAX_GUEST_CMDLINE); > - if ( (strlen(acpi_param) == 0) && acpi_disabled ) > - { > - printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); > - strlcpy(acpi_param, "off", sizeof(acpi_param)); > - } > - if ( (strlen(acpi_param) != 0) && !strstr(dom0_cmdline, "acpi=") ) > - { > - strlcat(dom0_cmdline, " acpi=", MAX_GUEST_CMDLINE); > - strlcat(dom0_cmdline, acpi_param, MAX_GUEST_CMDLINE); > - } > - > - strlcpy(bd->kernel->string.bytes, dom0_cmdline, MAX_GUEST_CMDLINE); > - } > - > - /* > - * Temporarily clear SMAP in CR4 to allow user-accesses in construct_dom0(). > - * This saves a large number of corner cases interactions with > - * copy_from_user(). > - */ > - if ( cpu_has_smap ) > + if ( skip_ioapic_setup && !strstr(cmdline, "noapic") ) > + strlcat(cmdline, " noapic", MAX_GUEST_CMDLINE); > + if ( (strlen(acpi_param) == 0) && acpi_disabled ) > { > - cr4_pv32_mask &= ~X86_CR4_SMAP; > - write_cr4(read_cr4() & ~X86_CR4_SMAP); > + printk("ACPI is disabled, notifying Domain 0 (acpi=off)\n"); > + strlcpy(acpi_param, "off", sizeof(acpi_param)); > } > - > - if ( construct_domain(bd) != 0 ) > - panic("Could not construct domain 0\n"); > - > - if ( cpu_has_smap ) > + if ( (strlen(acpi_param) != 0) && > + !strstr(cmdline, "acpi=") ) > { > - write_cr4(read_cr4() | X86_CR4_SMAP); > - cr4_pv32_mask |= X86_CR4_SMAP; > + strlcat(cmdline, " acpi=", MAX_GUEST_CMDLINE); > + strlcat(cmdline, acpi_param, MAX_GUEST_CMDLINE); > } > - > - return bd->domain; > -} > - > -void __init arch_create_dom( > - const struct boot_info *bi, struct boot_domain *bd) > -{ > - if ( builder_is_initdom(bd) ) > - create_dom0(bi, bd); > } Earlier on a function was introduced to deal with this cmdline handling. And now you introduce a 2nd such function? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:33:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:33:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376151.608725 (Exim 4.92) (envelope-from ) id 1oGgDt-0004iW-BK; Wed, 27 Jul 2022 12:33:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376151.608725; Wed, 27 Jul 2022 12:33:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgDt-0004iP-8Z; Wed, 27 Jul 2022 12:33:09 +0000 Received: by outflank-mailman (input) for mailman id 376151; Wed, 27 Jul 2022 12:33:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgDs-0004iJ-Ng for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:33:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgDU-0004ih-79; Wed, 27 Jul 2022 12:32:44 +0000 Received: from [54.239.6.186] (helo=[192.168.6.7]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGgDT-0008Pi-VU; Wed, 27 Jul 2022 12:32:44 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=E6+gj7hdT4Zrz9hBQQ/b6zaYk6fh+BZKunB47YG96+k=; b=OCAUvZFu5ee5MYoUnfUBLlXn0o 2TC3qv2dP8aUNapSne3agJCSYl1uC90+RCFSpxZZlb5BD5J7s6Fn9Ed3aB0biUnIt4hy+Iv53ZtQD Qq18ySSH64SAAQ2Da6lCkEeHTMdJZ8aQNlQGlVIsaxoAYEVxn58NPsuf9CKLuFYFtbv4=; Message-ID: <51ba135e-a105-036f-b891-e7d9e1bb607d@xen.org> Date: Wed, 27 Jul 2022 13:32:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane , LKML Cc: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , xen-devel@lists.xenproject.org References: <20220726125657.12151-1-jane.malalane@citrix.com> From: Julien Grall In-Reply-To: <20220726125657.12151-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jane, On 26/07/2022 13:56, Jane Malalane wrote: > diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c > index 9d548b0c772f..0c4f7554b7cc 100644 > --- a/arch/x86/xen/suspend_hvm.c > +++ b/arch/x86/xen/suspend_hvm.c > @@ -5,6 +5,7 @@ > #include > #include > #include > +#include > > #include "xen-ops.h" > > @@ -14,6 +15,13 @@ void xen_hvm_post_suspend(int suspend_cancelled) > xen_hvm_init_shared_info(); > xen_vcpu_restore(); > } > - xen_setup_callback_vector(); > + if (xen_percpu_upcall) { > + unsigned int cpu; > + > + for_each_online_cpu(cpu) > + BUG_ON(xen_set_upcall_vector(cpu)); > + } else { > + xen_setup_callback_vector(); > + } > xen_unplug_emulated_devices(); > } > diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c > index 46d9295d9a6e..2ad93595d03a 100644 > --- a/drivers/xen/events/events_base.c > +++ b/drivers/xen/events/events_base.c > @@ -48,6 +48,7 @@ > #include > #endif > #include > +#include This include doesn't exist on Arm and will result to a build failure: linux/drivers/xen/events/events_base.c:51:10: fatal error: asm/xen/cpuid.h: No such file or directory 51 | #include | ^~~~~~~~~~~~~~~~~ > #include > #include > #include > @@ -2195,11 +2196,48 @@ void xen_setup_callback_vector(void) > callback_via = HVM_CALLBACK_VECTOR(HYPERVISOR_CALLBACK_VECTOR); > if (xen_set_callback_via(callback_via)) { > pr_err("Request for Xen HVM callback vector failed\n"); > - xen_have_vector_callback = 0; > + xen_have_vector_callback = false; > } > } > } > > +/* Setup per-vCPU vector-type callbacks and trick toolstack to think > + * we are enlightened. If this setup is unavailable, fallback to the > + * global vector-type callback. */ > +static __init void xen_init_setup_upcall_vector(void) > +{ > + unsigned int cpu = 0; > + > + if (!xen_have_vector_callback) > + return; > + > + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && > + !xen_set_upcall_vector(cpu) && !xen_set_callback_via(1)) xen_cpuid_base() is an x86-ism. This is going to build because CONFIG_XEN_PVHVM is only set for x86. However, I think this is quite fragile. You are also using more variable defined only on x86. So it feels to me that these functions should be implemented in x86 code. > + xen_percpu_upcall = true; > + else if (xen_feature(XENFEAT_hvm_callback_vector)) > + xen_setup_callback_vector(); > + else > + xen_have_vector_callback = false; > +} > + > +int xen_set_upcall_vector(unsigned int cpu) > +{ > + int rc; > + xen_hvm_evtchn_upcall_vector_t op = { > + .vector = HYPERVISOR_CALLBACK_VECTOR, > + .vcpu = per_cpu(xen_vcpu_id, cpu), > + }; > + > + rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op); > + if (rc) > + return rc; > + > + if (!cpu) > + rc = xen_set_callback_via(1); > + > + return rc; > +} > + > static __init void xen_alloc_callback_vector(void) > { > if (!xen_have_vector_callback) > @@ -2210,6 +2248,8 @@ static __init void xen_alloc_callback_vector(void) > } > #else > void xen_setup_callback_vector(void) {} > +static inline void xen_init_setup_upcall_vector(void) {} > +int xen_set_upcall_vector(unsigned int cpu) {} > static inline void xen_alloc_callback_vector(void) {} > #endif > > @@ -2271,10 +2311,9 @@ void __init xen_init_IRQ(void) > if (xen_initial_domain()) > pci_xen_initial_domain(); > } > - if (xen_feature(XENFEAT_hvm_callback_vector)) { > - xen_setup_callback_vector(); > - xen_alloc_callback_vector(); > - } > + xen_init_setup_upcall_vector(); > + xen_alloc_callback_vector(); > + > > if (xen_hvm_domain()) { > native_init_IRQ(); > diff --git a/include/xen/hvm.h b/include/xen/hvm.h > index b7fd7fc9ad41..8da7a6747058 100644 > --- a/include/xen/hvm.h > +++ b/include/xen/hvm.h > @@ -60,4 +60,6 @@ static inline int hvm_get_parameter(int idx, uint64_t *value) > > void xen_setup_callback_vector(void); > > +int xen_set_upcall_vector(unsigned int cpu); > + > #endif /* XEN_HVM_H__ */ > diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h > index f3097e79bb03..e714d8b6ef89 100644 > --- a/include/xen/interface/hvm/hvm_op.h > +++ b/include/xen/interface/hvm/hvm_op.h > @@ -46,4 +46,19 @@ struct xen_hvm_get_mem_type { > }; > DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type); > > +/* > + * HVMOP_set_evtchn_upcall_vector: Set a that should be used for event > + * channel upcalls on the specified . If set, > + * this vector will be used in preference to the > + * domain global callback via (see > + * HVM_PARAM_CALLBACK_IRQ). > + */ Technically this hypercall is x86 specific. IOW, it would be possible for another architecture to define 23 for something different. If it is not possible (or desired) to surround with an #ifdef, then I think we should at least be mentioned it in the comment. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:33:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:33:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376156.608736 (Exim 4.92) (envelope-from ) id 1oGgEf-0005Fu-KM; Wed, 27 Jul 2022 12:33:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376156.608736; Wed, 27 Jul 2022 12:33:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgEf-0005Fn-H8; Wed, 27 Jul 2022 12:33:57 +0000 Received: by outflank-mailman (input) for mailman id 376156; Wed, 27 Jul 2022 12:33:56 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgEe-0005Fd-JG for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:33:56 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20068.outbound.protection.outlook.com [40.107.2.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 60e3abc5-0da8-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 14:33:55 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR04MB6941.eurprd04.prod.outlook.com (2603:10a6:803:12e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 12:33:53 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 12:33:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60e3abc5-0da8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AHg57wS0xtWa7LB052MMoDhA/4RM7arqWEbW0cW5TxnxdVnEk1Dwjsy60AGqBF5AU6/c3nxYJOGJ7FobWwyWeuqHzwzX8SJ12/67HPAxy9jB7v4ottYSY15XalcrTXB4cdAiyJHihVX9WV93eQ2FPub/CG9mRfg5UDC6pPRd7WmWxqU7rDsRqw3NXvnjFwFU4u1qFjBLdayj/fqH0YOoXbuRJ4O/GIqjtvpyzT/ThtCDRYOelULGh15Iq/Yd0IMmRHXH5k9e2H7cuITgfz6TqnfMWRKlLDdOZNubk+uX33l1T9HwIKGQyRXjgeLIURJwZosDhphNNHeRFuSdnM5kCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OH8u1EK+MWbdCTuijn8lnPbRejOugNUpmf0KVQdhE9k=; b=I2qE/nOzR9qBqj+CBP30JMcu5Rg0kE+W7VeTzBy0XOVAfOnbNs/oDjwR6McFBtAZPEB/k8mKhC4t7+Q5IrODZuhG1Ggt0EHvRoB5LoE7acMWhjCJHy55Xz1HCZim2vI6DDGFH9iu57lhUBaL9/5HB8vLPOCNHlcWH8dhXb8AWTgJMflqDtATIdPS7fkFpDCSE/r44AO1McebMB739flTZ+PZnzR4bgO6pQjqmPykmzTJjatgpBiOsokc0KAB3jxmDYKu1NxOA1VRFr9XztJ8K8oTqtRRic9aEGJqrO6FXQY7GAIAIwbjmk340sQ9GGSGC1SSsWZM+vxHJuPfF0hc7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OH8u1EK+MWbdCTuijn8lnPbRejOugNUpmf0KVQdhE9k=; b=Za5QaEMjqgBTDZEhcpxiE0nPTY3b5uMMLHA8tI7CpKIx4MTUZphfuT8S2zOB5uKPbfThy+ctqPGWt+Uk6rVMFvoliYaFfnTde773Lv8TCcZP8U3Rf7ZkbHAZv0tlYMie13lVCLO6JFmOxLzkJ9dXOe1PkdMl0LrBiNaXIydlg01ffsQEoNSo0KRnGAZZnFWHuNn334hOAuO8V5/kainhOPK0vgG1Tb0Bh8/EO1S7u0aTYt79EZgiB+1vLdVEtUjpza16JVYM6l5R3JPcDP/b4/MeGhVAERkiPwgOv2VUJFEBNSGbZqQFX5l46Re+pmT4KEQCC6i6Tc6y0K7RGW+pnA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <266606f5-dad6-a1dc-b4f7-96a81152e08b@suse.com> Date: Wed, 27 Jul 2022 14:33:50 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 13/18] x86: generalize physmap logic Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-14-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-14-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS8PR04CA0084.eurprd04.prod.outlook.com (2603:10a6:20b:313::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9c298e56-fef7-4223-52ce-08da6fcc4397 X-MS-TrafficTypeDiagnostic: VI1PR04MB6941:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zljnZjvhQvwPP1di/UNLq5jqkL7F+rpjgLtJffTZn+9B2QM/OrfWeGkqipH9NMWMGo2h7td6pNOaKaYKxvX7QTpk9a8y8fXtddOkxjldbkKX+1MZwEOovP4ev8VcLz4Z4MsIBhXS0b+eDPOdYbD8f62IRjV/kYoDQnl2Xbxr+uOFJsQj2Ni5gFCx6VSkfHGz49cIgGTuIe/oTBacnacZGWoNZOVytTlKeeMaHWCXWpkfb7JVpJtMmFSkakXU/twBAa986RuNNx0W3K6S6rHhezUuygA+xnn5XII6j/35zzCmdfu4YpF9A995qQ9gw1dY9fuD6lY2H+ASQa71mozsL8Lg91lPIpIrfLa6WC2n4GaOSxfRoAs1aeuSk3xde4cx7CwixJWHGPvjQIq/xsfzgiBHRIjhkBMNDCQdFbAwapC0Eh36RCx/hATjuZjQDnP/W4FOeNJOdlJVDWgnptsCsUH8KE/X0/vhtCrZHfFNLFlB/tesRuKrEeYU61H6vGJf74nqBsIzSikAzHQzMGla+GMrzs/+mDrdg8wwqwX//sqnNPdo0CBYeoD7WwjMawnXtMcFI3bTNcQmrRqiAkU4dlKqNcW5B8xyCGP940J/ZIFnZEZn2rblQCnv4wovfV73GqDtK7noIw5QfbgG4GptB9IFJNaoHcUdvz3e48tkZypiqCFSUDCXmag1K5q4gFvh9DQus/Xv5C6/bvM6pwvBsXnj90MFZ+TCXq32jsG32Yc9PhEmaPXvlrarYyGhBdvy5OwsnepGlieJnlQN49k+vDu2Idfhdqk6AOYLSmHN4wNi6bSCc28fjtK57zL0A72ot50IlltwWj9ZkI2M+JkR6g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(366004)(396003)(346002)(136003)(478600001)(6512007)(31696002)(86362001)(6486002)(41300700001)(38100700002)(6506007)(26005)(53546011)(83380400001)(2616005)(186003)(8936002)(31686004)(54906003)(36756003)(66476007)(5660300002)(2906002)(4326008)(8676002)(66946007)(66556008)(316002)(6916009)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlcrNE8xYVpsWCtxSm9XTWxHMUIwL05td2dIbUVIWUZ0ZXhhRVgvREdPS1Yx?= =?utf-8?B?Zlg0N1k2bzFQWTVCenJJcFovOXl3cnJpMUVlU00zUjlkaHhVVjZjeW5IdWJO?= =?utf-8?B?aTRNejZYbmFYMUQ1T2dzOC9pNVpGdUZ1SFFUanBPbDc0VWhDZ2p5YUxyZU9x?= =?utf-8?B?aDYzVzdKRC9zTkxvVnR2Qkh5aU5xUFFtSU9JanZKaHFER3NpcWpzN3h5RXBH?= =?utf-8?B?UHJncDd1dXNVQm5xMzQ5UXFUN3RqMWZ2bUYyT2RpMnQyNFpYV284VWNmMDFx?= =?utf-8?B?Slg5WmdWejB6MDB6N3lJVk1qeVY4NGt5akptdnJhVHhXQmNNVXl1aGlJb2Iv?= =?utf-8?B?ZGZmREk4MHlwMW1WZ3FKRGhOYXZ5RHJGMXIwRzJlVXlRZ1FnNm11SUxqRkZU?= =?utf-8?B?U0V6WmZ0RmpZOFBqamw5V09VK21iQk1hc3lWaDQrTUtQVU9ZaTRMckVHYWY5?= =?utf-8?B?alNYZytsRVJNdTkxVnk5MWo0NEw0cVd2ZFlESExKbUYwR21NUzFldExCcU1z?= =?utf-8?B?dmNycHZSUHhUbG5xVjRyak92YkRzQUszNkZ1N1FmUDVNeDJPTCtjbWpnN01H?= =?utf-8?B?aTIyZkdWQzFpOHRCM1k2S1pDck8xVGVsV0NzTnhrUml0YTFtZ0ZHcmlERFlM?= =?utf-8?B?MVZVZHRkUDlPOW9CT1M4cElsdlBRQ3B5S1pmblNQRGIyNlhlR214Q2doek1B?= =?utf-8?B?amVQUjI0TVU5N0tsQ2JIQlB0SDUvcE80UzJsSEZxM2pId1U4MFdwbXd6MjdN?= =?utf-8?B?VzR5ZWtoa3hrbDVFd0lheWJzdzJkdHRDbDRRTFJZZ0pZRGpveGVrMndIVmdQ?= =?utf-8?B?Vk9oMHMxckJKWWN6RlhRSHc4dVlaUnZmbVhYNWhoVFZUQUJoWExYMHkzSmRB?= =?utf-8?B?em4vdGE5cnBmRGhLOHBramJobVkvQzhnZDJKZEdsOWJnMWxXcTkzNGJwV2ln?= =?utf-8?B?VmZuT2FRQ2JBaFI0U0c0VGVkUmllN1BaYWdUS293WVE4dFlma0FyVU0wajdJ?= =?utf-8?B?LzZwMXREVmdmQ1RZcWpKdDk0dGRHVnBNV3gvb0VCQVBPNjhXMk9nZUVLTWt5?= =?utf-8?B?cEtsL1NJRExMY0hzMitwRWVTdjBHS0swUHZzdVZSQ3RyWmtZNS9qaDZNSEMr?= =?utf-8?B?VWlBdFNLcEoxd1dMd2pwWHVGRUQ1MFZ3VXlRVkUvOHU4TW9INnYvMEFTc0pm?= =?utf-8?B?aUdVUXRlV1FDNkhHZzUySVlyMFlhWXovRW9KYlE4TDErV0tmL2RJUlphZ3ov?= =?utf-8?B?VEI2RTlrM2lSaEpaakdkeGZVNGJkbGdsNTZzN2FYWi9OZkg5cWxBSWVSOXBs?= =?utf-8?B?QUhtUFg1UXkrWCtyYWFjMUVrQVI1a3NncDcwQlY3UHJYM0Y4bWRiNEtWY3hB?= =?utf-8?B?aTVUUlRwcERIamZ6NEV5bzRuVThhY1kyRmswS0M1eWxsUk9OT2Zhc3hOUFNs?= =?utf-8?B?MExPek1tUndid1hlZ3hyK05uMVYzaVhsYW9taDFnb2YzekhuUWhDcVJnYklt?= =?utf-8?B?bFgyajBCaDJIeXN1bUN2TnZVU0lFRFFzVmVaVWtoY0VTT1J4clBJT3dpd1Z4?= =?utf-8?B?czVUMUZQN3ZZOEpNb256V1BaRGd5OGFWeE8xdnl3WmZWMDQwM3pYeDFQTnNI?= =?utf-8?B?Mmk1WlBFRHNvcURUOEJhSDRrTmk4L1l2Nlg5WHJhVzZYejBObXM3VXNCWnV6?= =?utf-8?B?NWJ0NEdLN2RoZGhrYThVMEdXb09YdkE1K3JkRUUvMEo0RnpINzV2cXBmSWZn?= =?utf-8?B?K3BtbytGOFpNR2QreXVBcW4xYkRpdjlXUmcyYVpPUlJ3bEJqQitJL3JxTFRF?= =?utf-8?B?Z01NVVROOVhMaitkR01UbWxVNTRxVjhJeE50bzlNUHZMcGkrdlRoaHVXM1lF?= =?utf-8?B?d1UyKzhNMXg5Q0gydFNYYUJFNWljSFZ5VUErNTI4dzJOc0dnbmNlZkdQMWlz?= =?utf-8?B?ak05VHR2NzhtTVFpZ1B6TC9CSlJnY1M2VFlTejA4MG8yYlF1RnFvckFXMS9E?= =?utf-8?B?elRGeGNwelN1QzQvVE1pM3lYMEJnY2Y3c2dvWWlSRWJHekMzd0d5bXNJK3pQ?= =?utf-8?B?UnU4Nzlvb1VvN2JlNEIvTHlhalFsTm8yV3o0NDhPVmRIbFdLSmVEZjBzNVA2?= =?utf-8?Q?o/b+co/Sa5wnoRXG8BihKfvqB?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c298e56-fef7-4223-52ce-08da6fcc4397 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 12:33:52.5754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Lqd78RV5qhmgKj0kXCVhiiKXxVWKQUm7Jtt2rZHBMbA5639Njq4HcwBaHalJTjpma9A+gLMLb3PJmrAhnLMPSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6941 On 06.07.2022 23:04, Daniel P. Smith wrote: > The existing physmap code is specific to dom0. I think this needs better wording. Either you name the function or you explain what piece of code you're talking about. "physmap" alone is just not meaningful enough. (Also applies to the title.) > --- a/xen/arch/x86/include/asm/dom0_build.h > +++ b/xen/arch/x86/include/asm/dom0_build.h > @@ -21,7 +21,7 @@ int dom0_construct_pvh(struct boot_domain *bd); > unsigned long dom0_paging_pages(const struct domain *d, > unsigned long nr_pages); > > -void dom0_update_physmap(bool compat, unsigned long pfn, > +void dom_update_physmap(bool compat, unsigned long pfn, > unsigned long mfn, unsigned long vphysmap_s); So my initial inclination was to suggest domain_ as a name prefix, matching what we have elsewhere. But when we're already giving the thing a new name, its PV-only nature also wants expressing. Hence I'd like to suggest pv_update_physmap(). And then please fix indentation of the continuation lines here and below. > --- a/xen/arch/x86/pv/dom0_build.c > +++ b/xen/arch/x86/pv/dom0_build.c > @@ -34,8 +34,8 @@ > #define L3_PROT (BASE_PROT|_PAGE_DIRTY) > #define L4_PROT (BASE_PROT|_PAGE_DIRTY) > > -void __init dom0_update_physmap(bool compat, unsigned long pfn, > - unsigned long mfn, unsigned long vphysmap_s) > +void __init dom_update_physmap( > + bool compat, unsigned long pfn, unsigned long mfn, unsigned long vphysmap_s) > { Personally I dislike this further change to re-flow the parameter list, as I see no particular reason for doing so. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:46:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:46:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376163.608747 (Exim 4.92) (envelope-from ) id 1oGgQT-00072i-NG; Wed, 27 Jul 2022 12:46:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376163.608747; Wed, 27 Jul 2022 12:46:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgQT-00072b-Jh; Wed, 27 Jul 2022 12:46:09 +0000 Received: by outflank-mailman (input) for mailman id 376163; Wed, 27 Jul 2022 12:46:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgQS-00072V-Nf for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:46:08 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 146b2f16-0daa-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 14:46:06 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB9639.eurprd04.prod.outlook.com (2603:10a6:102:260::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 12:46:04 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 12:46:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 146b2f16-0daa-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDRfXKRJTe6GTYhJgqRsINqQO3OKRWb7cORYqjJjh91MgfsMd1k5ywmJJ0DjnWuI0UuouwXDgaDa+czlv3yjSvVa+K+jjeNf3CWHlADTqXce9F8tHWjTHoX26kk8s6cR+U7AJQE6TTutk1Tlm0N8noLwBSu3lThe+Tns7JVU8r6y6hbHKhJ2VC9rnVLD6UxasaIeBCX261DD4RZphuEmZUpBN0Cef0RSGOLalK7p2RmbOMUDeHrdNUaIiU+6aof3n7KLv02ZN8W66093rfxIdPbhiv5IIIolN8mx0TQC3ymi96o0aUo8Ke/frc908IJ46NZ2CW4wn2szILx6DTiH+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zqd+48DSo0RjELBHKVqgoD0AjchervHlYUoDIDGCM84=; b=ciBb/WvIF+1A+ANl3+A9O+F9f+Nxkx/w/ksDR4XIb4CqBXZV5K/sJ2ArH/HREsfRoW75jfI6HqUMDUYmTRbrkEPKaEXhmNSKkuBzkqfPum+MT9HQDzMHz+dvvTgCnlm6AA10aM75OYKp0wS9FIF3ezaWcI/bYHsqykv6j7Dp2QPnNnuJ4qfYv6UQh/xmp+lvB4lOJFmKLwePGi5U4qMJs0EyomQN5HUs3TZUCrcZbeR7yFC0GWtAmrAhZ25RP51fat/SudQTk6s7NG9/154LCpd3I+pYdRD6w3YZZHUnzB00jaQe1TgiCoTX5VOmS8sgqw6JTsZhr3uodurbjNH3Dw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zqd+48DSo0RjELBHKVqgoD0AjchervHlYUoDIDGCM84=; b=MeEYvlS3H8zL+8CzRGtxjM1qKLXKvb6YTMz/0AWBgymFp84VcrKMrxFvZO+jVZxaJGknQqZ2fBwyXVR+Z9G9xS7FZh6oWqeVQfv1f00tpTk75LDldnvmPHe5BC5mTkM1//ezBN/8fB1D6AJp0/lamM4W6OpoM4F/cyTWoCkIH2/QgnefPcaLCuE7DZLB50Tx0B9xtOC9yyoKAWC9sKZ7uhMqfIE+L+9sbI1KiBtXeOYphimua8xqeCoBVhphckkAbZZXuFH2+UHSgonNQwYsg8h2bNQciOUaTniIZN4S5/FG3QEgKkUl+ngWI/IMKPmgzCSwRgHAZT8JXd0QBfiGAQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <481ea371-df3f-287f-5952-262433342f28@suse.com> Date: Wed, 27 Jul 2022 14:46:02 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 14/18] x86: generalize vcpu for domain building Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , Dario Faggioli , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-15-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-15-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0079.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::7) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f3bf51c-4d71-428d-d45f-08da6fcdf77c X-MS-TrafficTypeDiagnostic: PA4PR04MB9639:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WVTaJ1+exDw3aFSZn0KVLcnb9goPihnNHVQ5qY+58d9AQ/rknesA1q3ftOhKeNRKEYy/vRQdF81MUqPi3abQmjnd9LpuOoCaM95XXyFQ584q4kM6CdhIw5F0LuPeFuct4ymgp+ZHQXFsIre3oJ0ef8wOg1Sn1CYcvkdWh47XBAcB7tkETVaaqK6UaYx7KTDAGDvLOFmAhGUkie/Fm5gbpcn6HAjVCvvunw+o+YsC84q3SIRYYNmgFXjqy3xzez4glwJbR68tuwq8cdRXGdJR/P15Ji8aqbYCqngROp1HmUAC7Zon0L//ITEAVS/lJ70kqLaBXzhTEbZ7VFkeHt19zEvZ+rCulKhXPs5QqQEZPUbpa2Eu3mnmjSkiKJcgeIAqN2ykk5GKaPFyYFIDZXD1mBk8BURxcOoUjOngDDyu58sswEYMX+eaz3NOgjGLS/01NstphVoY/lqaf7LPBRSs71hIJAgAH/jHIRyKp/Dha49aOuwvP1wigTSff3Dy17KjMXLlUCh/F3ZYLPJKMZ06al/V684wX+FZHl7sEfmC63U67smIIMs/sWTc+03kCOa7Lyh0WyyDLblxCOLZZWPMiGgs/3M5cHfdp/y4RX0ivSEVIVkarSntthq9zejDtM3hcTi0uMPVoBVkYHwPoDklgGE/174VxNnwugQn/cbSM0cvjGg5LB4DRoPA4UJ1a/if6+Z1W7D3de0vpFCG9agvYbWUJYx+8VYktAVQL1tXQXRSY1TspS8b84VK3c5I+1mmLIAT8Yops+rfQmoSZ09ILcQE8p/6kUpbg5Txp372tNl6bNyLP8DCj6iteqNujFgUS8k+3JaNxnO4ah2t4eEUCw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(366004)(136003)(396003)(346002)(376002)(186003)(38100700002)(7416002)(31686004)(8676002)(316002)(4326008)(66556008)(6916009)(54906003)(36756003)(66476007)(26005)(53546011)(6506007)(66946007)(5660300002)(2906002)(6512007)(86362001)(31696002)(2616005)(8936002)(41300700001)(83380400001)(478600001)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2h4WUt0ZTA4UnExSlZBK2M4MURjamY4QS9OZDV0MU9XOGJzSG9lajRlMDhy?= =?utf-8?B?TWVha09JRXRTWkhWZkFROHd6WU1rZENRb2F3RWg0dk05OE4ralZSVm5zVGxo?= =?utf-8?B?RnpGc1VMaUNSU2trY1lGRytDL1JGcVFiYS9naVlsbTlOM0JxZ0tQaHhxVnVR?= =?utf-8?B?WFdxUmhlTURraUZvbVhXRnlpcG4rQWtXV3hJdXNyZjRwdUpFcVBsTE1KcTJM?= =?utf-8?B?WEFIdUJPSzltY0hSbitGWWFmdStiNGI0SUNKY3VjbkYrQnhUYy92M2ZJTGVv?= =?utf-8?B?R1lxRGFUOXBpeDFiYyt4OGJ3ZVpYbVNJVzRqaWdkMXl1UGpuNWdKeEwvdWh5?= =?utf-8?B?QTB4RlNaVG5kNG5VRFBMdU9ENEFVRDMwa1VBcGhKMEFEbGlZeE0waDZGVENk?= =?utf-8?B?NHZzSCtiWHFMYjlaYVdKUldqNGNtZmtLNWllYVk1eVovcXBCQitpMHZHK1Zv?= =?utf-8?B?TUZXQXgrN1h1U2pudTh2QUtrL0R0bkc4eTd0WnVIVFhoQzZBZ2krTkVYUnpl?= =?utf-8?B?K2doN21pZnFVcVFlT2U5bVdPR0hQRmJWK0dQTk1DQ1RFSEJ2VmpaZ2IwOVRB?= =?utf-8?B?WnhYSzYvcUNhZFJWelZ1YVBvbjJla1ZIdkJPbTg1VVNZaVl4VDRUT0xSbHo2?= =?utf-8?B?dDRTU0ZCcGcvQ2s3TTI1dXRYRmpTSHFvNEZsWjlQbllsK3pXVndKNEFNTkV4?= =?utf-8?B?TzU4VFVjV2Y0bXg3TjkvZ3c2NnJkcTc5UWYvRnp1QUJnaU8zTllpRUs1U0V5?= =?utf-8?B?aENGNE0vWENZaTl4NWR0UnFOT05xZU1lY1d1L01sK3E3SUhmUVFMSFppRDJ6?= =?utf-8?B?c000UXhzS2J4cDhQcHVrSThLWmd3UE9VbnNYY3owUnJ0TjRmWUU0emJseFBG?= =?utf-8?B?NEErTCtURFBvSVByNUVraThtaldVZm5ZWmMzWG5PeFlPVmFlUmg5aVp6NFNF?= =?utf-8?B?UGFGcHZtODRsdGRTVGpyb1M1NlZRZlNlcEtjYlgzNE9MaGp0djVSR0k3OGlu?= =?utf-8?B?Z0ZlYnNFZGd0L2F1Z2NNbTB2WmJRSU1VbmU1L3U2cW9iR2dOb3BsNVgrL2dO?= =?utf-8?B?VGpVKzE5TTIzSnpFNEo4akFmZmNuTG5qSTVseSszYzU0WmVod2lPK3JaM0Ry?= =?utf-8?B?Mk1Zb1pMWW9ZRVdTazhqOXVQelRrbDMxSFhBVnRaVzVGNXdlUUtraE43eENt?= =?utf-8?B?T2JtMkVsRzM5N0hHL3ZRTWxMUFFPQUlNM0liS056QjI1UU1yQWtrSDVKU05T?= =?utf-8?B?cWE3dFduemVZVDcxMDdQRW8vQWFHQm1tU0lTMVNFOUtVb1gvZHR5czJtNVdV?= =?utf-8?B?L1ZRYytTejhBWnROR3EvekRkUjVRNGZzZERnb1NXV2VFNFhYRXVVRG85dElD?= =?utf-8?B?NUZudmlicUhwQ3hvZnNjY0l5TTUxZ3YrQWZIanExQi85YXBZYTltNloyRTA2?= =?utf-8?B?MUxxTitCVnRTWGxPZlphbCtKeDF6NGlyWTNWMmlNVmF3SEtyc3JpZDNJTGFC?= =?utf-8?B?YjNLODZTblJodWE4anJ3ZU4yUWxOcXUvUHZvTUN2MDA1UUpUWFV0SkZlWVFz?= =?utf-8?B?YVNBTXZML0NXcTk4d1lBWTl5UHk2L0htb1ZocjlRQ1R0bmVGOEFDa3NrVlZO?= =?utf-8?B?ZG5GdFB1amZ3bUpzV2VQdTdOd1ZqUzRUYzZTdVBNUnk4SUFscUtwMlhLbFBH?= =?utf-8?B?bzJWTDVSK3hhbC9FTFB1aGp0ME12YWF4bEF5VytJWlgvZ2VrME9IejNTRE5j?= =?utf-8?B?N2tQTVhkcHZCeXA4SlpuT2FuVzZ0OS9vOUtMMWl0dmcyYVZRZ3Ara0J0LzBp?= =?utf-8?B?N0YyVkRHSUR4QkR2UXdQbXBuaDJqcUNJYWRMa3JScXBRaXo3V0x1WDZ4MEd6?= =?utf-8?B?NWVYNnZ4QU1JQ3MwTFRQR0RGNmFjQlF3ZVl3am5LdlRtT29EUE9sL0t4VTgv?= =?utf-8?B?ZlpSRGQ0MUhzdE8vcyt2dUFNZTIwb2tjcUVTS1l0elRRYTV3ZitsUTdhZExS?= =?utf-8?B?R2xKNXh6YnE1dVhaekhhSmIzUk04bC92K1FWM0s3WjBoMUNSc1N5bkhEc3VR?= =?utf-8?B?ZkpYYjhkUUJjSVJsN2pvT25HTEhFWlhuM0ZTMjJvWXl0R0gvKzVUU3N2ZlVr?= =?utf-8?Q?XyNA6TCjKJdptMktf4grnsWUg?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0f3bf51c-4d71-428d-d45f-08da6fcdf77c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 12:46:03.9353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pSqKF66wq2qwKriFEe0mtY29Uj0IYP1qrnkF7wcjHCXvnhNwdW/DQfe+b63Nb8MHyIgeqdEqC+Lo8dV0PIvDvw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB9639 On 06.07.2022 23:04, Daniel P. Smith wrote: > Here, the vcpu initialization code for dom0 creation is generalized for use for > other domains. Yet with "other domains" still only ones created during boot, aiui. Imo such details want spelling out. The title also is too generic / imprecise. > --- a/xen/arch/x86/domain_builder.c > +++ b/xen/arch/x86/domain_builder.c > @@ -28,6 +28,18 @@ static unsigned int __init dom_max_vcpus(struct boot_domain *bd) > return bd->ncpus; > } > > +struct vcpu *__init alloc_dom_vcpu0(struct boot_domain *bd) domain_alloc_vcpu0()? > +{ > + if ( bd->functions & BUILD_FUNCTION_INITIAL_DOM ) > + return alloc_dom0_vcpu0(bd->domain); > + > + bd->domain->node_affinity = node_online_map; > + bd->domain->auto_node_affinity = true; I can spot neither consumers of nor code being replaced by this. > + return vcpu_create(bd->domain, 0); > +} > + > + > void __init arch_create_dom( No double blank lines please. > --- a/xen/common/sched/core.c > +++ b/xen/common/sched/core.c > @@ -14,6 +14,8 @@ > */ > > #ifndef COMPAT > +#include > +#include > #include > #include > #include > @@ -3399,13 +3401,13 @@ void wait(void) > } > > #ifdef CONFIG_X86 > -void __init sched_setup_dom0_vcpus(struct domain *d) > +void __init sched_setup_dom_vcpus(struct boot_domain *bd) Perhaps simply drop the original _dom0 infix? > { > unsigned int i; > struct sched_unit *unit; > > - for ( i = 1; i < d->max_vcpus; i++ ) > - vcpu_create(d, i); > + for ( i = 1; i < bd->domain->max_vcpus; i++ ) > + vcpu_create(bd->domain, i); Seeing the further uses below, perhaps better introduce a local variable "d", like you do elsewhere? > @@ -3413,19 +3415,24 @@ void __init sched_setup_dom0_vcpus(struct domain *d) > * onlining them. This avoids pinning a vcpu to a not yet online cpu here. > */ > if ( pv_shim ) > - sched_set_affinity(d->vcpu[0]->sched_unit, > + sched_set_affinity(bd->domain->vcpu[0]->sched_unit, > cpumask_of(0), cpumask_of(0)); > else > { > - for_each_sched_unit ( d, unit ) > + for_each_sched_unit ( bd->domain, unit ) > { > - if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed ) > - sched_set_affinity(unit, &dom0_cpus, NULL); > - sched_set_affinity(unit, NULL, &dom0_cpus); > + if ( builder_is_initdom(bd) ) > + { > + if ( !opt_dom0_vcpus_pin && !dom0_affinity_relaxed ) > + sched_set_affinity(unit, &dom0_cpus, NULL); > + sched_set_affinity(unit, NULL, &dom0_cpus); > + } > + else > + sched_set_affinity(unit, NULL, cpupool_valid_cpus(cpupool0)); Hard-coded cpupool0? > --- a/xen/include/xen/sched.h > +++ b/xen/include/xen/sched.h > @@ -2,6 +2,7 @@ > #ifndef __SCHED_H__ > #define __SCHED_H__ > > +#include Please don't - this header has already too many dependencies. All you really need ... > @@ -1003,7 +1004,7 @@ static inline bool sched_has_urgent_vcpu(void) > } > > void vcpu_set_periodic_timer(struct vcpu *v, s_time_t value); > -void sched_setup_dom0_vcpus(struct domain *d); > +void sched_setup_dom_vcpus(struct boot_domain *d); ... for this is a forward declaration of struct boot_domain. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:47:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:47:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376169.608758 (Exim 4.92) (envelope-from ) id 1oGgRU-0007nG-5k; Wed, 27 Jul 2022 12:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376169.608758; Wed, 27 Jul 2022 12:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgRU-0007n9-2t; Wed, 27 Jul 2022 12:47:12 +0000 Received: by outflank-mailman (input) for mailman id 376169; Wed, 27 Jul 2022 12:47:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgRR-00072V-IZ for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:47:09 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 38fa3d0f-0daa-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 14:47:08 +0200 (CEST) Received: from mail-bn7nam10lp2100.outbound.protection.outlook.com (HELO NAM10-BN7-obe.outbound.protection.outlook.com) ([104.47.70.100]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 08:46:55 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SA0PR03MB5515.namprd03.prod.outlook.com (2603:10b6:806:b3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 12:46:51 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 12:46:50 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 38fa3d0f-0daa-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658926028; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=0qISryQ9rNGSgvE/QLjbWx0uIyXwCUUkFfqeYJOve8s=; b=dAXdCGZfTSApCkTLJrMAIBAYzd6XEQdR0pkltpoonDwJGzdlIOyLb7Sj f8LsMB9YMZrgJvS0B8cisCeOU4K6dw29dNfaPK4i5wfRNV5i2l97bNdyb mTMaZTTiHz3P4XkLbPSP1zgD0IQ/Newhz62Ox6/dXhLmpxct2Ufgf/v4N s=; X-IronPort-RemoteIP: 104.47.70.100 X-IronPort-MID: 76529251 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:THmPkKMfi7HOF/PvrR2JlsFynXyQoLVcMsEvi/4bfWQNrUpxhD1Tx zQXXWnXOP7cM2PwfY93bI609kgGusDcnd5jGwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMtPjc8EoHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPH2edlNEQ3FLYA3cgrK2J8x fMVeAo0O0Xra+KemNpXS8FKr+F6dIzBGtxavXttizbEEfwhXJbPBb3Q4sNV1ysxgcYIGuvCY 80eanxkaxGojx9nYw9LTs5h2rjwwCCnK1W0q3rMzUYzy0HVwBZ8z/7GN93Nd8bRbc5UglyZt iTN+GGR7hQya4LCk2vfryvEaunnuQWjaYZRFLGD+fc13H6t7FQ9CDARbA7uyRW+ogvkMz5FE GQW8Cczqak59GSwU8LwGRa/pRasrhMaHtZdDeA+wAWM0bbPpRaUAHAeSTxMY8Bgs9U5LRQ10 neZktWvAiZg2JWJSHe15rqS6zSoNkAowXQqYCYFSU4P5YblqYRq1hbXFI87SOiyk8H/Hiz2z 3aSti8iir4PjMkNkaKm4VTAhDHqrZ/MJuIo2jjqsquexlsRTOaYi0aAsDA3Md4owF6lc2S8 IronPort-HdrOrdr: A9a23:o01+OK2rMsa1XBGmbhziaAqjBK8kLtp133Aq2lEZdPUzSL37qy nOpoV56faaslsssR0b9exoW5PhfZq/z/BICOAqVN/INjUO0FHYSb2KhrGC/9SPIULDytI= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76529251" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TUPIPub54G4MY8Aj2uIN+9Iw92XbOvPzkKeMqnGW3pRzYqoT8g3HNnrsBAa7eYj2uaAjHNOoGYa4+jKJqD9SFc1MFNvgUYupzs20NMT9rL1XCwrA2qug74Sy+uMNe0hIvlA5c2Hn0EMYOS6LCW6reetY7RUjPYKeCj8vqr9LtF6BOFv4WthDnk3i0gbRBEBvlwdK7gJr/4Pxncawig9Ael9/PCICq76l38a51oQOge/MN1H1lvorJQvY3Jf7ZFS8xuKucVtRtFTgzk7eSG+OpzvbBlrhJcavqu/L55skhN1AiJttvIFmgEfYNT5ZkQO1ulPRtODeaaxf2VJGoQYZ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0qISryQ9rNGSgvE/QLjbWx0uIyXwCUUkFfqeYJOve8s=; b=REadaCjUO+0cxMeVaOPmyPKmY+ZF8mSMZgQsDb6WN5NzQSiX/RuLDMt1fPJzvYpJci/AGqcVmD4H7wCBstsXCowL4KccvaBQFURxyuMkT3F3q3Hh+VoU4FceWvqzo78e8GSVjGegpXnU2NOLQLwyNEuu5l/Fj26l8In0Q+0FLtJdSMqRsgKd3RB7MLjKB3EPzwb6mg4paOvot7jsqh6PEeztZbCRDXjG7v68DMhuor5H+45j1R+2Fudf2wTOxjO5JMHWNt2UcWOGe8WajA5EnYkhCpfJBaP2HuuQ/TfReWWqgRf4OhppXlfzw0Vsi0p7UujfzMbXSc3PbJbzj5a2fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0qISryQ9rNGSgvE/QLjbWx0uIyXwCUUkFfqeYJOve8s=; b=T9CZTZukcnhZm+4WeQLPvNmHAxjSnhh0ru64znGJvenlXNbzbg5TQ+GhmmqZfnexz43EUcUR/8Wgvd8B/hUsipFsZRvh1U6ZwDg/CvGaEdKN+ZJULzYuFAwcrnwqAwVEbtnlViuU0ifoU0qehzwbyo/1qzDce6AOy9m06qNwiiU= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing Thread-Topic: [PATCH 2/8] x86/shadow: properly handle get_page() failing Thread-Index: AQHYoQlhV37xX0Hh2kWLBKJVPAkGN62SK82A Date: Wed, 27 Jul 2022 12:46:50 +0000 Message-ID: <6c5b5339-f645-4214-bc53-2b7ead004367@citrix.com> References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 343dd74d-99d4-4ef0-94e7-08da6fce1348 x-ms-traffictypediagnostic: SA0PR03MB5515:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MNUOLW31BDt0r9SmOx2gausWerZ7rE3tnlTqFPikKldfCXZWCjguCUH5RVMau2cAUIrx60fMg6dAkUe58lgE5EvKGuCiMlIur441Qrqm8qwYJBGwSBsI/8/fb7wv1pCjPNr6lQpMTsNB/7goCgqyGyu3r3lRGf5eaJMp3Kds/hIbco8phWWpl02/ITwHtlzDJ/mJaW1NEVCVSPxhNyk0b9tiJl46PVZzmT/YUqugUeEdnxQ7W9Fau2NK5UC3ApVixO/N2w776D0vIBgF/hxL2UFzPlUP2OvqeE3R4bhMEom26Ux98F1UL7XFUxHeM3Uc5B+nUTPD7n1BziLeVx7OSZ3BVto8xAq3AqTnmeUeydmx32DegdKzz6cdoFBKIS4/4d/Ym3x8OW3qd08GGEX9y09X9fl0RCEafNUTtg+tipfGaLtdE8BCgeQnZZx+gR8HldEZaoMWJa4lOeLAPJkZzUFBF9Gl8Joj9jNiIeklAYCRSg5mo5qpodiIBHMhrAbYgfLOU5/2G4l6K2VOWamQwi0Vc+7nagO5cR0bqED3WFAk+9IV6VFYrg6Ds4rmJaMES7VEiVhb/X0Ehb7ih81c/W1OKAN891kgCi4/ZHYULjZkGA04tho8jYFaymlpNyyA6H5rp0gfcxzyLi3+DjTGyy4+iwBqYgKlwgRQXlc3iYP4kDDiI4reRVdpujggoKXKWySOSSUHTeV8nSAP1meZmpYc22IU264T/InfdxXtyNvSUh2aqI7yIXsUkCMMhJlBdFhi+cI7QT9EJTfkrpf5b+8Wa5jC4x/FskzsI7SNEKdBzO1DrGrUBLmH52X++M2zlcM9q0oMmXk2jQU3KVS/FjoihJMnx4tLT97vrp3YMgYirerT0R5AXTBGnY2K/0aN x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(110136005)(54906003)(36756003)(38070700005)(6486002)(2616005)(316002)(31696002)(186003)(8936002)(122000001)(2906002)(31686004)(38100700002)(5660300002)(8676002)(91956017)(76116006)(82960400001)(64756008)(83380400001)(6506007)(66476007)(66446008)(4326008)(53546011)(6512007)(41300700001)(66946007)(478600001)(71200400001)(66556008)(86362001)(26005)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cHRaYVRDQXQzbWpXT1dLaklBYTNyRHVjYUhlWHQ2d3FIbHZDcWh1RGNReGtI?= =?utf-8?B?aWc4djZpL2xoUkNjWVlqb2NpZmhrVWZGYks4TFBRL2thQWd5MTlybituQXF6?= =?utf-8?B?ZVJBclhYUWdoZFMyakdENFhNZlpvc2xpeWdORlVqSW44NGpaMlJhTG5CbGJW?= =?utf-8?B?SmE4RFZydjZxZWFKbkMySlVPVU1PYUlFQkpmN0REMFpKSTU2aDB6NFRYRlI2?= =?utf-8?B?ZHBCeDlpb214eE0vb2QzdkV1d2w3ay9XWWUzOU56TFhaR25zd1dMbFVmM0Rr?= =?utf-8?B?emxpWHdKZjM3QWk1Tk9LeEpkNXhoZnhmRmRCY2tqWGo4UGUyNytDeDU0Wml1?= =?utf-8?B?SGFoemxDNWlvZVNBZTlPVFlCUDd0L1JMRzVGb2ZFZm9mQ0wyNGZIb1hNQ2Zj?= =?utf-8?B?U3VEZkM0Q0p3WWFpTFplQ1RuV0xiakpaT2Zyei8vQ3ZyRkpvbXpFMGtFV1N3?= =?utf-8?B?dVh5UVBsbDRrYmhqZUtlNCtwYXBFbFZKT3ZsREhWL0hNbVZiMG94NWNhZkdS?= =?utf-8?B?UUdlZy90VmFYWnNzcEVvaUVmUEt2OGJCOUdoT0hvMDJuUlpLcklEQ0ZDR2lp?= =?utf-8?B?TXBPR0lrOHVyVS9pazNiZzJCYlBUSjllREpJWm5DNC9EeGUzNGxtbFFkN0Z1?= =?utf-8?B?UVlpb2dWLzBkd2c3WWNUeFRIRGI2QTFTanZKLy9kRXRpSnpMMmM5WHBEZldn?= =?utf-8?B?Y0pUdUIxOXM2d3JqbGJKcHEwcWc3a3ZMdnJGRzR4dVU4VTlienVHZklCeC9X?= =?utf-8?B?aFY0S2lBc01tUkFGQXdxSEM1ZDV3TXdiSEZBd2NoTWVRcVk4eE5kazRZV0g0?= =?utf-8?B?Vk1rZzc5WDF1VVlDNUJRbGtDSVR1Zi9FVXV4SEFURWIvZ3dQVW96eStCL3Zl?= =?utf-8?B?U3hzbXB4QTBXUkxBSk9Kd3UxNnN0VUNLZmJ0eUtEOFFtVFhQQzZXanJnNWZW?= =?utf-8?B?Tm5RZDNQNGJ3QUJ3SnoxVjFOdktqZCtrUGppTS9ra05YajZtK1htQ01FL2JZ?= =?utf-8?B?YnNCcnR1M0Jsdmd4QWxpYmRFTnhSTGhvS1ZFd2VxeThYQUNwT1BLQ2ZBanNy?= =?utf-8?B?cDVWZUNDeFVtUjhMUFVIbTNWUDd6MEQ4bXlUYm5rK0pJbFlIRVg0aTh6clBP?= =?utf-8?B?QXppU0dPRGgrSWtHSDE3a3VhRWd3MUJQSkkrUFdyVk81S2RRWEluY09wLyt4?= =?utf-8?B?SWdMWEwzRC9YOXEvRDN2TWhZSERRMG9QS28rK3lzMjRMYldZQ3R6UC9nMDla?= =?utf-8?B?bHdnSTdKYnM4VVhXNjVKb3ZWN3ZoTmU1eHhMWi9RZDZjdUpmZ2NtTk5zZWlo?= =?utf-8?B?R1RNbnBsOWdoODRqR2ZldkZZYVh3VENiMk1ZaHUwMkkyenZhY3NCRisxejlt?= =?utf-8?B?M0trVEp4VDkvT3ViNXRNZHJBWWc5M09kbk03eE5CWGZDSVlDL2Fzai9MSmZD?= =?utf-8?B?RDdOMmgyYjIzY21aZ2ZKUTlPOGlXVTV4WFRXek1aSjBHeGlURnRwYkRIQlh1?= =?utf-8?B?Q3p0ZWJzOW1oL3ZOdDFQN0hKbEs5R0g4UFpJS1lqcldiQUkyM2lhWVQ0Slow?= =?utf-8?B?M2RwWmxEMXFmZ2I3MU82cEVLc0YrQVJyY0Fkb3A0anlmUjlKS3JGK0dCdDF4?= =?utf-8?B?MWN5TWNvYlNLTXFmdHpSUnpCb3FzTmVoOUxpalIzMSt4Y250M3NWc0ZrbXdi?= =?utf-8?B?TnJJSjFldTJPR1dzNldRR0FLci81Q1BoTWhKOHJZMGZWc2xRdlI0RzBCUTcr?= =?utf-8?B?OEl2QTU2Ni8wcFE1bEtSVXZGcnRxQWJtV1c5ZGtDUUZ1OHRGdW5ZR25wVVox?= =?utf-8?B?UXRPOTBxSEQ1WVNpSUNnWFBGSlhzWTI1MTcyK1NHM0RmR2FqaGd4NXNpMm9a?= =?utf-8?B?VDBjYzdzMmo2OWlLVk1vMDBoWDBDNS9IV2laOGJuTVEvT0NwN2ltOGdTcHN3?= =?utf-8?B?S3BUczhCcVBGanlKdFg3WUpWZzBrTXpWdFRFSnRyR28wZDRYbU56d1BCVUlq?= =?utf-8?B?dStIand0bzl6eTJ2Q0JkZFJZSGFQNDR2STJBUTJ3b0s2QTAxdjErWC9oeDNP?= =?utf-8?B?Rjc3SjVodUpNZzIyb1hJOHVNVGo0MUNWRjRROTdZa09SOUI3RHFiYk9sMGln?= =?utf-8?Q?4ZDYT4i9LPm5bNPnJbJKeccW9?= Content-Type: text/plain; charset="utf-8" Content-ID: <68EEB6B7299488448897B4D4B5A743F0@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 343dd74d-99d4-4ef0-94e7-08da6fce1348 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 12:46:50.3503 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JITR6PxupmZYOIFsQY/nMlcByEK7gr8mgxr3BRTnim95k15UndWulGpTfF2afga/dFXgSOq6rLeRpIP+wpEztznxnDQpTs7DgryVWrD4jTY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR03MB5515 T24gMjYvMDcvMjAyMiAxNzowNCwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdlIHNob3VsZCBub3Qg YmxpbmRseSAoaW4gYSByZWxlYXNlIGJ1aWxkKSBpbnNlcnQgdGhlIG5ldyBlbnRyeSBpbiB0aGUN Cj4gaGFzaCBpZiBhIHJlZmVyZW5jZSB0byB0aGUgZ3Vlc3QgcGFnZSBjYW5ub3QgYmUgb2J0YWlu ZWQsIG9yIGVsc2UgYW4NCj4gZXhjZXNzIHJlZmVyZW5jZSB3b3VsZCBiZSBwdXQgd2hlbiByZW1v dmluZyB0aGUgaGFzaCBlbnRyeSBhZ2Fpbi4gQ3Jhc2gNCj4gdGhlIGRvbWFpbiBpbiB0aGF0IGNh c2UgaW5zdGVhZC4gVGhlIHNvbGUgY2FsbGVyIGRvZXNuJ3QgZnVydGhlciBjYXJlDQo+IGFib3V0 IHRoZSBzdGF0ZSBvZiB0aGUgZ3Vlc3QgcGFnZTogQWxsIGl0IGRvZXMgaXMgcmV0dXJuIHRoZQ0K PiBjb3JyZXNwb25kaW5nIHNoYWRvdyBwYWdlICh3aGljaCB3YXMgb2J0YWluZWQgc3VjY2Vzc2Z1 bGx5IGJlZm9yZSkgdG8NCj4gaXRzIGNhbGxlci4NCj4NCj4gVG8gY29tcGVuc2F0ZSB3ZSBmdXJ0 aGVyIG5lZWQgdG8gYWRqdXN0IGhhc2ggcmVtb3ZhbDogU2luY2UgdGhlIHNoYWRvdw0KPiBwYWdl IGFscmVhZHkgaGFzIGhhZCBpdHMgYmFja2xpbmsgc2V0LCBkb21haW4gY2xlYW51cCBjb2RlIHdv dWxkIHRyeSB0bw0KPiBkZXN0cm95IHRoZSBzaGFkb3csIGFuZCBoZW5jZSBzdGlsbCBjYXVzZSBh IHB1dF9wYWdlKCkgd2l0aG91dA0KPiBjb3JyZXNwb25kaW5nIGdldF9wYWdlKCkuIExldmVyYWdl IHRoYXQgdGhlIGZhaWxlZCBnZXRfcGFnZSgpIGxlYWRzIHRvDQo+IG5vIGhhc2ggaW5zZXJ0aW9u LCBtYWtpbmcgc2hhZG93X2hhc2hfZGVsZXRlKCkgbm8gbG9uZ2VyIGFzc3VtZSBpdCB3aWxsDQo+ IGZpbmQgdGhlIHJlcXVlc3RlZCBlbnRyeS4gSW5zdGVhZCByZXR1cm4gYmFjayB3aGV0aGVyIHRo ZSBlbnRyeSB3YXMNCj4gZm91bmQuIFRoaXMgd2F5IGRlbGV0ZV9zaGFkb3dfc3RhdHVzKCkgY2Fu IGF2b2lkIGNhbGxpbmcgcHV0X3BhZ2UoKSBpbg0KPiB0aGUgcHJvYmxlbSBzY2VuYXJpby4NCj4N Cj4gRm9yIHRoZSBvdGhlciBjYWxsZXIgb2Ygc2hhZG93X2hhc2hfZGVsZXRlKCkgc2ltcGx5IHJl aW5zdGF0ZSB0aGUNCj4gb3RoZXJ3aXNlIGRyb3BwZWQgYXNzZXJ0aW9uIGF0IHRoZSBjYWxsIHNp dGUuDQo+DQo+IFdoaWxlIHRvdWNoaW5nIHRoZSBjb25kaXRpb25hbHMgaW4ge3NldCxkZWxldGV9 X3NoYWRvd19zdGF0dXMoKSBhbnl3YXksDQo+IGFsc28gc3dpdGNoIGFyb3VuZCB0aGVpciB0d28g cHJlLWV4aXN0aW5nIHBhcnRzLCB0byBoYXZlIHRoZSBjaGVhcCBvbmUNCj4gZmlyc3QgKGZyZXF1 ZW50bHkgYWxsb3dpbmcgdG8gYXZvaWQgZXZhbHVhdGlvbiBvZiB0aGUgZXhwZW5zaXZlIC0gZHVl IHRvDQo+IGV2YWx1YXRlX25vc3BlYygpIC0gb25lIGFsdG9nZXRoZXIpLg0KPg0KPiBTaWduZWQt b2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNClJldmlld2VkLWJ5OiBB bmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPiwgYWx0aG91Z2ggd2l0aA0K c29tZSBvYnNlcnZhdGlvbnMgYW5kIGEgc3VnZ2VzdGlvbi4NCg0KPg0KPiAtLS0gYS94ZW4vYXJj aC94ODYvbW0vc2hhZG93L2NvbW1vbi5jDQo+ICsrKyBiL3hlbi9hcmNoL3g4Ni9tbS9zaGFkb3cv Y29tbW9uLmMNCj4gQEAgLTE1ODEsNyArMTU4MSw3IEBAIHZvaWQgc2hhZG93X2hhc2hfaW5zZXJ0 KHN0cnVjdCBkb21haW4gKmQNCj4gICAgICBzaF9oYXNoX2F1ZGl0X2J1Y2tldChkLCBrZXkpOw0K PiAgfQ0KPiAgDQo+IC12b2lkIHNoYWRvd19oYXNoX2RlbGV0ZShzdHJ1Y3QgZG9tYWluICpkLCB1 bnNpZ25lZCBsb25nIG4sIHVuc2lnbmVkIGludCB0LA0KPiArYm9vbCBzaGFkb3dfaGFzaF9kZWxl dGUoc3RydWN0IGRvbWFpbiAqZCwgdW5zaWduZWQgbG9uZyBuLCB1bnNpZ25lZCBpbnQgdCwNCj4g ICAgICAgICAgICAgICAgICAgICAgICAgIG1mbl90IHNtZm4pDQo+ICAvKiBFeGNpc2UgdGhlIG1h cHBpbmcgKG4sdCktPnNtZm4gZnJvbSB0aGUgaGFzaCB0YWJsZSAqLw0KPiAgew0KPiBAQCAtMTYw NiwxMCArMTYwNiw4IEBAIHZvaWQgc2hhZG93X2hhc2hfZGVsZXRlKHN0cnVjdCBkb21haW4gKmQN Cj4gICAgICB7DQo+ICAgICAgICAgIC8qIE5lZWQgdG8gc2VhcmNoIGZvciB0aGUgb25lIHdlIHdh bnQgKi8NCj4gICAgICAgICAgeCA9IGQtPmFyY2gucGFnaW5nLnNoYWRvdy5oYXNoX3RhYmxlW2tl eV07DQo+IC0gICAgICAgIHdoaWxlICggMSApDQo+ICsgICAgICAgIHdoaWxlICggeCApDQo+ICAg ICAgICAgIHsNCj4gLSAgICAgICAgICAgIEFTU0VSVCh4KTsgLyogV2UgY2FuJ3QgaGF2ZSBoaXQg dGhlIGVuZCwgc2luY2Ugb3VyIHRhcmdldCBpcw0KPiAtICAgICAgICAgICAgICAgICAgICAgICAg KiBzdGlsbCBpbiB0aGUgY2hhaW4gc29tZWh3ZXJlLi4uICovDQo+ICAgICAgICAgICAgICBpZiAo IG5leHRfc2hhZG93KHgpID09IHNwICkNCj4gICAgICAgICAgICAgIHsNCj4gICAgICAgICAgICAg ICAgICB4LT5uZXh0X3NoYWRvdyA9IHNwLT5uZXh0X3NoYWRvdzsNCj4gQEAgLTE2MTcsMTAgKzE2 MTUsMTQgQEAgdm9pZCBzaGFkb3dfaGFzaF9kZWxldGUoc3RydWN0IGRvbWFpbiAqZA0KPiAgICAg ICAgICAgICAgfQ0KPiAgICAgICAgICAgICAgeCA9IG5leHRfc2hhZG93KHgpOw0KPiAgICAgICAg ICB9DQo+ICsgICAgICAgIGlmICggIXggKQ0KPiArICAgICAgICAgICAgcmV0dXJuIGZhbHNlOw0K PiAgICAgIH0NCg0KVGhpcyBlbnRpcmUgaWYvZWxzZSBibG9jayBpcyAiZGVsZXRlIG1hdGNoaW5n IGVsZW1lbnQgZnJvbSBzaW5nbGUgbGlua2VkDQpsaXN0Iiwgb3BlbmNvZGVkIGluIGEgdmVyeSBj b25mdXNpbmcgd2F5IHRvIGZvbGxvdy7CoCBJIGNhbid0IGhlbHAgYnV0DQpmZWVsIHRoZXJlJ3Mg YSB3YXkgdG8gc2ltcGxpZnkgaXQuwqAgKE5vdCBpbiB0aGlzIHBhdGNoLCBidXQgZm9yIGZ1dHVy ZQ0KY2xlYW4tdXAuKQ0KDQo+ICAgICAgc2V0X25leHRfc2hhZG93KHNwLCBOVUxMKTsNCj4gIA0K PiAgICAgIHNoX2hhc2hfYXVkaXRfYnVja2V0KGQsIGtleSk7DQo+ICsNCj4gKyAgICByZXR1cm4g dHJ1ZTsNCj4gIH0NCj4gIA0KPiAgdHlwZWRlZiBpbnQgKCpoYXNoX3ZjcHVfY2FsbGJhY2tfdCko c3RydWN0IHZjcHUgKnYsIG1mbl90IHNtZm4sIG1mbl90IG90aGVyX21mbik7DQo+IC0tLSBhL3hl bi9hcmNoL3g4Ni9tbS9zaGFkb3cvbXVsdGkuYw0KPiArKysgYi94ZW4vYXJjaC94ODYvbW0vc2hh ZG93L211bHRpLmMNCj4gQEAgLTEzMiw3ICsxMzIsOCBAQCBkZWxldGVfZmwxX3NoYWRvd19zdGF0 dXMoc3RydWN0IGRvbWFpbiAqDQo+ICAgICAgU0hBRE9XX1BSSU5USygiZ2ZuPSUiU0hfUFJJX2dm biIsIHR5cGU9JTA4eCwgc21mbj0lIlBSSV9tZm4iXG4iLA0KPiAgICAgICAgICAgICAgICAgICAg IGdmbl94KGdmbiksIFNIX3R5cGVfZmwxX3NoYWRvdywgbWZuX3goc21mbikpOw0KPiAgICAgIEFT U0VSVChtZm5fdG9fcGFnZShzbWZuKS0+dS5zaC5oZWFkKTsNCj4gLSAgICBzaGFkb3dfaGFzaF9k ZWxldGUoZCwgZ2ZuX3goZ2ZuKSwgU0hfdHlwZV9mbDFfc2hhZG93LCBzbWZuKTsNCj4gKyAgICBp ZiAoICFzaGFkb3dfaGFzaF9kZWxldGUoZCwgZ2ZuX3goZ2ZuKSwgU0hfdHlwZV9mbDFfc2hhZG93 LCBzbWZuKSApDQo+ICsgICAgICAgIEFTU0VSVF9VTlJFQUNIQUJMRSgpOw0KDQpJJ2QgcmVjb21t ZW5kIGNyYXNoaW5nIHRoZSBkb21haW4gaGVyZSB0b28uwqAgSSBrbm93IHRoZSB3ZSd2ZSBhbHJl YWR5DQpnb3QgdGhlIHJldHVybiB2YWx1ZSB3ZSB3YW50LCBidXQgdGhpcyByZXByZXNlbnRzIGNv cnJ1cHRpb24gaW4gdGhlDQpzaGFkb3cgcGFnZXRhYmxlIG1ldGFkYXRhLCBhbmQgSSBoaWdobHkg ZG91YnQgaXQgaXMgc2FmZSB0byBsZXQgdGhlDQpndWVzdCBjb250aW51ZSB0byBleGVjdXRlIGlu IHN1Y2ggY2lyY3Vtc3RhbmNlcy4NCg0KPiAgfQ0KPiAgDQo+ICANCj4gLS0tIGEveGVuL2FyY2gv eDg2L21tL3NoYWRvdy9wcml2YXRlLmgNCj4gKysrIGIveGVuL2FyY2gveDg2L21tL3NoYWRvdy9w cml2YXRlLmgNCj4gQEAgLTM3NSw3ICszNzUsNyBAQCBzaGFkb3dfc2l6ZSh1bnNpZ25lZCBpbnQg c2hhZG93X3R5cGUpDQo+ICBtZm5fdCBzaGFkb3dfaGFzaF9sb29rdXAoc3RydWN0IGRvbWFpbiAq ZCwgdW5zaWduZWQgbG9uZyBuLCB1bnNpZ25lZCBpbnQgdCk7DQo+ICB2b2lkICBzaGFkb3dfaGFz aF9pbnNlcnQoc3RydWN0IGRvbWFpbiAqZCwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICB1 bnNpZ25lZCBsb25nIG4sIHVuc2lnbmVkIGludCB0LCBtZm5fdCBzbWZuKTsNCj4gLXZvaWQgIHNo YWRvd19oYXNoX2RlbGV0ZShzdHJ1Y3QgZG9tYWluICpkLA0KPiArYm9vbCAgc2hhZG93X2hhc2hf ZGVsZXRlKHN0cnVjdCBkb21haW4gKmQsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgbG9uZyBuLCB1bnNpZ25lZCBpbnQgdCwgbWZuX3Qgc21mbik7DQo+ICANCj4gIC8qIHNo YWRvdyBwcm9tb3Rpb24gKi8NCj4gQEAgLTc3MywxOCArNzczLDE5IEBAIHN0YXRpYyBpbmxpbmUg dm9pZA0KPiAgc2V0X3NoYWRvd19zdGF0dXMoc3RydWN0IGRvbWFpbiAqZCwgbWZuX3QgZ21mbiwg dTMyIHNoYWRvd190eXBlLCBtZm5fdCBzbWZuKQ0KPiAgLyogUHV0IGEgc2hhZG93IGludG8gdGhl IGhhc2ggdGFibGUgKi8NCj4gIHsNCj4gLSAgICBpbnQgcmVzOw0KPiAtDQo+ICAgICAgU0hBRE9X X1BSSU5USygiZCVkIGdtZm49JWx4LCB0eXBlPSUwOHgsIHNtZm49JWx4XG4iLA0KPiAgICAgICAg ICAgICAgICAgICAgZC0+ZG9tYWluX2lkLCBtZm5feChnbWZuKSwgc2hhZG93X3R5cGUsIG1mbl94 KHNtZm4pKTsNCj4gIA0KPiAgICAgIEFTU0VSVChtZm5fdG9fcGFnZShzbWZuKS0+dS5zaC5oZWFk KTsNCj4gIA0KPiAgICAgIC8qIDMyLWJpdCBQViBndWVzdHMgZG9uJ3Qgb3duIHRoZWlyIGw0IHBh Z2VzIHNvIGNhbid0IGdldF9wYWdlIHRoZW0gKi8NCj4gLSAgICBpZiAoICFpc19wdl8zMmJpdF9k b21haW4oZCkgfHwgc2hhZG93X3R5cGUgIT0gU0hfdHlwZV9sNF82NF9zaGFkb3cgKQ0KPiArICAg IGlmICggKHNoYWRvd190eXBlICE9IFNIX3R5cGVfbDRfNjRfc2hhZG93IHx8ICFpc19wdl8zMmJp dF9kb21haW4oZCkpICYmDQoNClRoaXMgaXMgdGhlIHNlbnNpYmxlIHdheSBhcm91bmQgYW55d2F5 LCBidXQgdGhpcyBpcyBhbHNvIGEgZ3JlYXQgZXhhbXBsZQ0Kb2YgYSBwcmVkaWNhdGUgd2hpY2gg cmVhbGx5IGRvZXNuJ3Qgd2FudCB0byBiZSBldmFsX25vc3BlYygpLg0KDQpXZSd2ZSBnb3QgYSBn cm93aW5nIHBpbGUgb2Ygc3VjaCB1c2VjYXNlcywgc28gcmVhbGx5IGRvIG5lZWQgdG8gZmluZCBh DQpwcmVkaWNhdGUgd2UgY2FuIHVzZSB3aGljaCBpbmRpY2F0ZXMgInNhZmVseSBub3Qgc3BlY3Vs YXRpb24gcmVsZXZhbnQiLg0KDQp+QW5kcmV3DQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:53:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:53:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376176.608768 (Exim 4.92) (envelope-from ) id 1oGgXM-0000p0-PY; Wed, 27 Jul 2022 12:53:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376176.608768; Wed, 27 Jul 2022 12:53:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgXM-0000ot-Mz; Wed, 27 Jul 2022 12:53:16 +0000 Received: by outflank-mailman (input) for mailman id 376176; Wed, 27 Jul 2022 12:53:15 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgXL-0000on-Gc for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:53:15 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2053.outbound.protection.outlook.com [40.107.104.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 13c314f0-0dab-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 14:53:14 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR0402MB3412.eurprd04.prod.outlook.com (2603:10a6:208:1c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 12:53:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 12:53:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 13c314f0-0dab-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ShAaVYo2pp186om5l95BHj82tHk72ykLGdH7/yd8fwChe0kDFD8TrjDW57tymtI7H+XvLVR/zcvQYcd64OuWAEzVNnzL2hTFN0ou/Ze1LIiJVbteI/wKQQrqfEbhURKDtbN8RHdOyiah0LCoET4UyBHr2KpuITllrWMNn3SBel4IuIMVMhIvPHrgvNMlzWx+vDUXSGbIhcG4cy1aX820i05KbtLc5JnY+OEdCH6azQYaF/Z6BEPNP3objPZmUbSXswlO9jLxjUVwvk7rC23iLP7Bv1XmDo74xILsB84eaKZILWn5Fnrl4p0wcaKOTqeVshvIi7OYcStyB6RSJGHCew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1NSeQmfm0TmXIBRpni0a/g/m8ad3ZqQCjtk2S8LffOY=; b=Mp5Pzv61GUz4E9JSZ080RhAhdUFy3wR7pJ5y3nh/nqH1wdN9vK4bkvI7sxNPw0w+FCLmzC+V6aUSo4xZW+7ObUxf3ytdt4MiFqHEGEv7TpTcsXyoVtKTfo+AMvREaSkD9u855T1ha4TTCFfso82CEIIhKIhGfiwf40n48n558bfY+d8lk6FPiH3WK0BQsjfvTkrgj0koWu8TueMYepUE+oGcRVoBmtzZPFK2Ern8kdSOQlsFsgju74A8t7zehSGSIfvkckjFbkizTGtX2sunk/eb5a0Ugq8fTxKL7oobz1RvOhhSDxH8NG0XWt4xaRanFRaM1O3ippgM35Fd1U1sxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1NSeQmfm0TmXIBRpni0a/g/m8ad3ZqQCjtk2S8LffOY=; b=cMpU/5w2pMZmDCBrPFcOEz7Nhom97Q4uL031DjlgzXFXTJ/2fqOtfIhiCr7fSd5JrJF45GiBchV1DHJq4V0WXDCtqV4jQr+79H936YEJzn55Otczk5R8tI7VGKwHwXSQ2823A0Dp7AsqIA2AK0l5T0ORXnlG8aDQ10rT1mAQn/NXHfAeTig5XhwD//IW6vFOwClpQIuR8LKd6cP42L+SHVdBHzQPxJUKnOm8SivYXxi5euIauzmIC7doZiffeGWjTw9/p9/guvRFcJ/+rxRaq0Z9AZrApUE/S3Qdu4GcFyH+i7xO7mUhZWBj83BaUm6pxqCNxm0dpBNeLjawjYq18g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 14:53:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <6c5b5339-f645-4214-bc53-2b7ead004367@citrix.com> From: Jan Beulich In-Reply-To: <6c5b5339-f645-4214-bc53-2b7ead004367@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0018.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e79cdd1-b9ba-4c42-13b8-08da6fcef67a X-MS-TrafficTypeDiagnostic: AM0PR0402MB3412:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PQdp56x75ubo5X6MdDaq9m8EPl6dblERRz3a8ZGBApPt2mm6TZSxXgj9c8F1yrtfN2x5M4CflVJM8YNSOs00aRsbm75gi+lSDA+pv1bO10Ef5thxjYMQh02U3OW7cKUAy2bDzlN0AQeR6AviH1XaKX9WGS7nXmAgnUhsBxfDpuSuD6TW4HZvLGItFkkOHx8BZDAXsaEudmfTKXOED3a1VliN4wiBNRHP1Czvmp6orhF+0jTupur/WhvwC90leVYTr0V4laVBivGdPkFnjeJwKd028YdJ4AwuaeT1q47PFJmKyZiQO90FtmIpFFJAE3DNpqstjBkLnulcw3gkGZIGZd+BTae9iKy0boy1GphRIHelIED63/Fg7iLq62/NHKUFHMw9e58w+gKzO+4GWvRbWRGNZU3bzVY1tle+i7dMq2syKRiCC8xX4tzfn8gJ0rAnJTm5IRzTVj0zgCbF4zol6rD+6nGy8Y/FSAuOdLxQAG9u1tq5mKhfNrnKMuE+uaMchcNPljiHUuaTOqcVYsql2Smcnsa5Zo3IfuApRFJe1RRiNeHzMdwjHY+AYChdxXI3tJVV84maTMeel+5VYdaKz9r2hjXzFRoHBKpHYkXs62S1vTd2k7NrQO+epb+8t5E5hbQ5LWdNebcrFTLkMmtYArg8NaKWLUe5WMOaNXz11mh6nnbHvA2ylRbXYZ/wPm3z1QdwY2+UGnizwPn/Tp0rUfiBvdVExbUOZWw72kgImqs344pJ1tHlHt5Mik4orCOE/i40JkoNdfRdr7trvWgiwFJAOMNYBYCFIw/TEjjKN3IjXQ5jmaYqVy1oPwuHX+yk6Pj7F7pUiAt3P1+UEBV5xQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(396003)(136003)(376002)(83380400001)(5660300002)(53546011)(2906002)(6486002)(54906003)(6916009)(478600001)(26005)(38100700002)(2616005)(31696002)(316002)(31686004)(86362001)(8936002)(6512007)(36756003)(186003)(66946007)(6506007)(4326008)(41300700001)(66556008)(66476007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajNNSXc3LzNBbVdqQ1BoOFJWZXJqRkNKV2hhTEFVMDRzeWZTRXRMOTZOU0sw?= =?utf-8?B?UnN0SU9LR2l0enpQV0hEaE5KNUVxbENvT2tIelo5SFFzSVJBWFJodHU0azE1?= =?utf-8?B?K3VMMXV1L2NDeVY0VVJiOU54Rzg4dlJueUJPRGZ5eXdlVzVPZ3lZQlY1bnhp?= =?utf-8?B?MUVZMllMQnZTY2JQdmUwS21RY0pRZUlzbU1OSGlFZmNnbXB5c0JoNTBjdDQw?= =?utf-8?B?UW81blA0UjNxYzNpbmNwMkIya1RjK29wQlBJVGppZFI0WUhhQWkzSHpOYy9O?= =?utf-8?B?YXFsTS9wYUkrcE02MDhiTm5Rb2pkZWI5Wkd0ay9CaXZFdlpvUlRUUGJPd05z?= =?utf-8?B?cHBNM0FzQ0grbVpycmYrb3FtbG1IdlY2RUpoSzA3UTNJOC9sZlBJc3hPdGMv?= =?utf-8?B?TTlHRURJZHFNdmJTM3grUGxtQ3NuSmsrTHVTVDVHcHBJTTdOa1BzbUFXSmk3?= =?utf-8?B?djNnd2hQT1JDb1B4NVJvSGtNaGxWUzg2bTBqUlk1b1Z2Vnk4R0ZGYVpJamI3?= =?utf-8?B?Qnc3OWxTbmFud041eEZ0S0E0STg1V3loUEtlWG8xcVdzZk1nSnhmYm1Ka2lG?= =?utf-8?B?WTJyWUdUeDJ3VHVtVFMyTUR4TEdwQzZ0OTROY05TeVJRVHhySlAyWHFwS01y?= =?utf-8?B?SWFFVDByUkFpUGNZdmMyQW9DUWd4cXl0WHZlMmVZOXFyS3pGb0YzU01jNEcy?= =?utf-8?B?eHcyYldBTncxMWtvbTRrWDI5K25tcnlFeEhBdGF2QlBQZWVPUXJhQ09JbHhW?= =?utf-8?B?WGlPUzlzL1ZFcWVBTjlqWkJtTUtSMXRRcSsxV1N0YzluVmZhaGl1UHV2bXlG?= =?utf-8?B?Mmp0Tkpjb0RrbGx4Ui8xVEU2MjR5Z2ltVXB2Y3pDUkh4RHRvZlRyWXo1TkJL?= =?utf-8?B?ckNTa3hFeGtDUFYva0FGYnBsTFVaaHRwWW1od1VvQ3FuQjFwdmhSeUVST0Jt?= =?utf-8?B?YWI3a1ZOS2tWS3BOK296VjU0amJGdTBXSndkTXZzQy8xRXg2VytUY2xYQTNM?= =?utf-8?B?QkluYngza3lPQ2I1NmZZd1lZSm1wbC9GdEVWMlhNTFN1OEx0QjdYWjJpRFdM?= =?utf-8?B?RDYyaElMblBhT0RWQ1JCY3ArMUVTeTdDN0d5UFNQZHBDdHBUVFhXa1p5QmtN?= =?utf-8?B?U1BYdHl2emdDa2ZJbGpRZUYzZWxWOEVDME9nbWNvL3ArUjVaZkl2OEFYUllH?= =?utf-8?B?aFQydXMyaVdxbEdtcDNJZVJWOHErdExQd1EzM0RibUNyOWdieG1zQXdJQ3FH?= =?utf-8?B?WHJIWjB3MktuUGFqRGxBV3FscVRrN0FUZ0tlNHBNc05HdnZoUDladGR3NFNK?= =?utf-8?B?eXhLWkRFYTQ2dVcwNk10b3Y1YXpoVWszVmpORTBGMmJUazJ0N1ZveldXR3do?= =?utf-8?B?b0dCOEVZSE02Vjd4akx4b0RKYW1rd2VOVDFpRGs3SkhFU1hVaUVKZHJYdlFn?= =?utf-8?B?WmtKYlBWeFFmeTd6VitJRnNsc21CM083OXVmMXlRaCtENzdRVFZ2RmEya08y?= =?utf-8?B?NnJ5eTV0ZDE5bk53RmI2L0xLZ0xJR29nSnRqdElqREtmTyt0ZEl2NC94VXhz?= =?utf-8?B?R0l4WGY1bjN3d0J2cEVqZnhhblJ2YlBtc3VGUGR2cFBjU2pjOGtPbUcvbUNH?= =?utf-8?B?bmxVOTVWb3Q3YUYwMnozWldFRkY3Z3FCSFUrZTV3TWpORmZZMWNSWWwvRUxx?= =?utf-8?B?RVh6dCtNZEtOaWhMUjd3RWphNy81cmJCN2x4T2ZCT1NZSlNKVUR3SVN4ci9p?= =?utf-8?B?S0piVXJWa1lMN1FQZ09mS0ZMZ2dWb0xGenNaQkNESXJlT25OZzhkbXdHalFi?= =?utf-8?B?OXNSYk80TWJtZmRTTXlIcGowRDk4YlcxQ3puZklXV2c1ZnlEN2JmSUJYNU12?= =?utf-8?B?ZzJpdkh0bXZReXpkMGZEZnF4cGVRdzE2L2wyQzRTSmUxVUtpUXhjK29Od0tp?= =?utf-8?B?TGZSSXdiM3NzaUlsRlRGM2czOGZudlBrYlp2bTFhMGZ1WFZ4U0NNbEZOTnBo?= =?utf-8?B?STZhSU5JWU9aN3Y4ZVIzTDJjdVBYYVhzakZCR0liUG9qT1Rra2gxQWJERGta?= =?utf-8?B?aGlFYkxSU1o5NncvM3JrL0xML0xkSDc2VCt0bG9nbklWSHc2T0Q1c3U2YWdn?= =?utf-8?Q?WeXjXniQjpUpN2Ys9WkhlfWlY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e79cdd1-b9ba-4c42-13b8-08da6fcef67a X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 12:53:11.7206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WUjZNmDOI+P5gTOdIWjXWpwuybgpe4ZYJvkGta8kUdSreH8xjKDRLariAMXZeBDO1Md1tjloRbqVLtvzA1XN9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0402MB3412 On 27.07.2022 14:46, Andrew Cooper wrote: > On 26/07/2022 17:04, Jan Beulich wrote: >> We should not blindly (in a release build) insert the new entry in the >> hash if a reference to the guest page cannot be obtained, or else an >> excess reference would be put when removing the hash entry again. Crash >> the domain in that case instead. The sole caller doesn't further care >> about the state of the guest page: All it does is return the >> corresponding shadow page (which was obtained successfully before) to >> its caller. >> >> To compensate we further need to adjust hash removal: Since the shadow >> page already has had its backlink set, domain cleanup code would try to >> destroy the shadow, and hence still cause a put_page() without >> corresponding get_page(). Leverage that the failed get_page() leads to >> no hash insertion, making shadow_hash_delete() no longer assume it will >> find the requested entry. Instead return back whether the entry was >> found. This way delete_shadow_status() can avoid calling put_page() in >> the problem scenario. >> >> For the other caller of shadow_hash_delete() simply reinstate the >> otherwise dropped assertion at the call site. >> >> While touching the conditionals in {set,delete}_shadow_status() anyway, >> also switch around their two pre-existing parts, to have the cheap one >> first (frequently allowing to avoid evaluation of the expensive - due to >> evaluate_nospec() - one altogether). >> >> Signed-off-by: Jan Beulich > > Reviewed-by: Andrew Cooper , although with > some observations and a suggestion. Thanks. >> --- a/xen/arch/x86/mm/shadow/multi.c >> +++ b/xen/arch/x86/mm/shadow/multi.c >> @@ -132,7 +132,8 @@ delete_fl1_shadow_status(struct domain * >> SHADOW_PRINTK("gfn=%"SH_PRI_gfn", type=%08x, smfn=%"PRI_mfn"\n", >> gfn_x(gfn), SH_type_fl1_shadow, mfn_x(smfn)); >> ASSERT(mfn_to_page(smfn)->u.sh.head); >> - shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn); >> + if ( !shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn) ) >> + ASSERT_UNREACHABLE(); > > I'd recommend crashing the domain here too.  I know the we've already > got the return value we want, but this represents corruption in the > shadow pagetable metadata, and I highly doubt it is safe to let the > guest continue to execute in such circumstances. I'm happy to add or convert, but please clarify: DYM in addition to the assertion or in place of it? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:55:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:55:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376182.608779 (Exim 4.92) (envelope-from ) id 1oGgZp-0001UF-96; Wed, 27 Jul 2022 12:55:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376182.608779; Wed, 27 Jul 2022 12:55:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgZp-0001U8-6A; Wed, 27 Jul 2022 12:55:49 +0000 Received: by outflank-mailman (input) for mailman id 376182; Wed, 27 Jul 2022 12:55:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgZo-0001U2-8c for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:55:48 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6d3c5103-0dab-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 14:55:46 +0200 (CEST) Received: from mail-dm6nam11lp2174.outbound.protection.outlook.com (HELO NAM11-DM6-obe.outbound.protection.outlook.com) ([104.47.57.174]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 08:55:42 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6423.namprd03.prod.outlook.com (2603:10b6:a03:38d::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 12:55:41 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 12:55:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6d3c5103-0dab-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658926546; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=IUQ5M5smgcllFfc/of3Q+QuHOk2V/Ps1SDY+rc2/hY4=; b=HiAB2FRvq8fPjXVmjlca6klDOM38OrQCUq8MM9jb2jrjISri4Xh0gGEn 3IJcuw/tBWDvOpREQtYyvXUC6jrsW4uQ15dUP6Kz7LjYxPz0MTlsjkhH4 sQ1S5o5zJws7XEvT7CdN74BW1XKbPaxOCCIzKK90jHB32QKjVcAEPP8lg M=; X-IronPort-RemoteIP: 104.47.57.174 X-IronPort-MID: 76734291 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3A3JJ66quS2V7sONfEzS7JbT892efnOphVZooaO?= =?us-ascii?q?cmfNp3fP2Tx3xfKXtTyy3cAL686JMBLl3fIf8uht7YhyIT8ddAa0UetcPLyd?= =?us-ascii?q?5SZthP1oYAdxS6PDh7GM+v6YcRK8mhOI+B+8rF3kifZbbvtOHXwUkoqN3E8p?= =?us-ascii?q?HRhna5bEA5rsnbDA6wAx7ibvsCowvUOJmgZdO7bpkPhKSxnm2riIQPK/hNDS?= =?us-ascii?q?2xHDxLE5g+sInlUp8gfPYYqQ2vri2c30ZLtIeJ3Sb2DpKjcfAmWWWGcCm16w?= =?us-ascii?q?5jnNcG8KYzdlA7o/wBd1SGEJHxnMOYIeM9ohBRDiFWrPSCDVbGpqHllu0/fi?= =?us-ascii?q?ezMhVJ9Rkq/e8WybtfpxuzXegXzkB2OeZKs27XOfnWCTaktEfcmQHG7oRunI?= =?us-ascii?q?6uF+y/qpBvD/+qcU0xtexx1IRJBoy1yuLb8H8C4RfHeyc1mFSNngsXj/4qE8?= =?us-ascii?q?P7jLO/tZpYQj74V/8QUueLEHdkyXqktx0zkQBi6qolzx9rByygAnt62QzUWt?= =?us-ascii?q?opeFJi3/pZTn5NT9Npaok73SBKP6mKq2hzhQwtsDNQWlSkHdRL4T+dqjOS8x?= =?us-ascii?q?G5Ve59QPpDFkfKtlVgvt3FF5miJV3qF6FSppWkPvWHvjjIA0aYOWt0qUJOBN?= =?us-ascii?q?3HMMcymsA7D7NfGke3tA8+1y+rF5gyqtrrBmCSJUdxjcLSkjL7a53vjcpmBN?= =?us-ascii?q?TYIfEg5Y9eORNslN4KCinXkfbnkbhezaTwDHu7cnpuZBnKjdi5/OFeBmaBe+?= =?us-ascii?q?cimi7pHn2aij1l396q23hY851W3z51gDtLG163R+3digXStOPgbDV+odcJaE?= =?us-ascii?q?fbwT5KrdNkBL2kyAlbIphhxCO1PdS9y9UPXnXP2P88M0fSyeeo30Tb0cx2FM?= =?us-ascii?q?m2c9eiQUh/BaNkMJYDsjiOzPL1kcDV65LV+gfMa5YqhS5tl4vlkA56ewxza8?= =?us-ascii?q?aW+n0VHcEwqz2IvzXwckQRMTjfSXUbdGrKmjcqVRwv4xHh5JsbFRA7UioYV6?= =?us-ascii?q?mWIgiII2QlD3HyBQSOA2dZIW9Zo7owo6+Il3GA3Y6yAvBJiDJhguByKIWiyX?= =?us-ascii?q?qMZ0moLlm5gz7FV/zEE/uRmtxMY0P9DpB+2mxGs/lpKoLU/rwWwlo/SB9B0Y?= =?us-ascii?q?34n8tRQY3U6hTmCokdIm7zc2U7FmSPYIVaev0h3lrOdsvBSqfT9NYuxk3UO5?= =?us-ascii?q?wes1cONZObE53cjXAq0d9JYNi5oat5BTbQCx6hSS8tqVtnaDjIpgW2/L5BJV?= =?us-ascii?q?KpFVMexDKmYzuxwzdRt9D4f07T7XPth2MxxyifvAlvTWpgbKg5+pOc4Hw2Yi?= =?us-ascii?q?5kgPURoGneV4nsMSJ3+423tuwaGZ9OJUNlUTlJYNANX1n/Uqz2egQTHO7Mrz?= =?us-ascii?q?F5HhzD1p++IAeNWySfHxb5JWAvbrBxLreQuBHMxZdXfUm5DwUZdLpzm6Ly8K?= =?us-ascii?q?VbiE4qNtEFIXcIUDJUO1e3UADoZVFB8dQVvJDaaITUytRguvu8kGaC0105N6?= =?us-ascii?q?2RBVyDmrkjkmga4jC1xDWfU+eoyTFFQEU0nmokEFsPFFRSIDDo4ds1wsixuJ?= =?us-ascii?q?7tyFY5bnMb+Z7WCnarL+OCuoCdRVR1qHs7/RBQnb4htmmEYnjfVKjaGS2726?= =?us-ascii?q?8JuIhDj64h3dbeg5vhd51ZC1YCjftT5lFSxtx6G5Tfr66xf2FV1Ufv2Zm2qZ?= =?us-ascii?q?KWY0XeYl8I2/5oryBDl4iLZzdxSYzhkWN73T5OgHzMQWkLVNIjUjurQ/XrjQ?= =?us-ascii?q?jfnGOJPwlya+MnTi5KgEGLqXfMPjFaWt/HG7lv+KNSivGeLplUjSPGChtHba?= =?us-ascii?q?ubJdI7pu5GWzeUVzFJ1QLU2MFqqaSuEMzseILN2Ht9jsMsU3V2s4b3vNRz1p?= =?us-ascii?q?vOcS425Fd0+GZXT0tF90S8/6/alGuiHHdqmug7zRzFvnibDN9snl9qmbU6dz?= =?us-ascii?q?FBP6B//ld8zbZNGXJkYGHQDQ58Vd1FZpiVHqMcYG6ERlXGRyT1q1m9SbrOrT?= =?us-ascii?q?k/WbuyGo/NzIXA1cTHYPSRk4tNFJTi2VmOzyEQ93bSmJK5wmOND6uftYrnYH?= =?us-ascii?q?59T76/VvgSnPjvATGaIenPrlFUga/TxTyzV5RB70OGKT2SpyLkT+zQkQN+/C?= =?us-ascii?q?Z/rFLzc9ii2QVItd4mkFI5f8gFYNZrMCVlIpQV6ToJuYgernkwE1G+BkhYjQ?= =?us-ascii?q?MDzawkmamp9l3N97Och7MOBJJCuIBtcM9PmW6wgq1t8SpUtB54nHnOCj0Nye?= =?us-ascii?q?7YQtIsh5zAVJPhKWE/JRxiEafzP0bQr+LcidQ5CaRi1po03KYW+oHhRSr1fo?= =?us-ascii?q?eBo28zOgKQairt0A4DDiP05rv7YeuskZ/QtDkzTsSzRpBP2f8y3czVvf49mu?= =?us-ascii?q?tHNJyAMoAqABx6olhSfqPbFHDeoxa+G5jAwmBsCdxbpCZz11ZNFcsFKfidf/?= =?us-ascii?q?CaJm6Ej1qhU93B3vfb8pXoV41g=3D?= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76734291" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iy8ZdEOvrzqwhYTSd8wwLWXMvhBbM52W7W1uTTSxsZ6zYBXqv9BfWMB76vwqaD01Xva3Bl0kCXrDMiTtSOgj5/u1M1RAwkjQf2PQYrAm0DP07zouxwLiQtt/nm9kjDfQlmOi9wTy27bDeO4oJAeUS1CA/33/+PLaM+xPNJAhKTCO2LmetVHwaRMPLCwY3Kb2bG2HNcpp1akYbR6vX/4CJPPMaZH2sACxEjgAWhZUXc3ycqO3rJ0s+37IJ0CMNSmmEMzYxRUxQxLNByOKmHfUOGcYfwH8G+0b64yoe3/QknNxS6U1Q/AETq1dEaoCcpe0U8Mrpl2ascTiF3INGQxW2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IUQ5M5smgcllFfc/of3Q+QuHOk2V/Ps1SDY+rc2/hY4=; b=Y0XBvWLStXMxCNUt/FNMC87dzkwbMRZSCxnfp7EPZeiODA5mnrDF0D0kwvasvoBoRc3LZ5NwsvyxQwwmxFO26QjIfDAeP//eRgXkQN8NAToBPMI82ROD15HDpucHdj2y+P/xCJCeNyCiki2MpQgI+BSqZxmzJ1dCfp1qANwl9ZSoE0gFc0yhf30mLu7TZ00zL4hOOsZhxHshYsCqVfPbLO2o0/GkM2Qm/0dwyd2WX0QvZutTi8V03WFVL9h9yyjRh0ukBrX1o4E6bacABGh2aGG1gYGI7utH5IfwHBbfGmRkMEvSHA7soTae+jSglLdXcvgSdbXPC8A/deAdx7bdnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IUQ5M5smgcllFfc/of3Q+QuHOk2V/Ps1SDY+rc2/hY4=; b=ndJu/bG5IVD0XdTCnKrtEDz+HYD9QZXWKaa5hu1ARTiCXLt2zPX+WKfc7RMMWDYes0pC4eKLgoo/mgCKU3c/0Enboiiu5fOqj+Aj302p/9EBjbsFBInITUXQYAdHQHWNpAELw6R6E4ZPHA2+HCVx1LGIElf60SGdodyqSX9iWs0= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM Thread-Topic: [PATCH 4/8] x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM Thread-Index: AQHYoQmDLSMXSfDjDUKeSEk6muWLxa2SLkUA Date: Wed, 27 Jul 2022 12:55:41 +0000 Message-ID: References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <75dd380e-5dab-8d19-b9da-b59188bc4997@suse.com> In-Reply-To: <75dd380e-5dab-8d19-b9da-b59188bc4997@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26fa6380-b573-4d1c-2b49-08da6fcf4fa8 x-ms-traffictypediagnostic: SJ0PR03MB6423:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RRUSxCKgOvasyq+uTYU+Q53v+YzbYhAj8CmvgcfqqkQyv+i7PoOK4YSEi9P8Sr1RFixuHf14mfBeezHrdjsfvDXX+RqOIuxg+pNrv67a2qBcz8rz8iAuTXhn1/ITaWzS5n6GwSsUdclXv1Dl6Ec+HJmkOcFvWso+viwHnYsOUpBAIpztfwfcvfSuZ1wMOxCO0ZPmUtvGanfozozrN/qamrksEcSLQ8p1svY7FjJloMcqwHo+0UXW+lfWRbMT/z4ivqP8S/fTCqiFiFGsxITT3WgJGt5LSQamJ0vK/5wii7Tn8qzt0fhwDCi9Ldyx8hFv5tI75Assekxmf8RfjaaDETlGWfEP9Oh0Wt2R602Lp7SMGMdlJHwqNKrVEt8DOES/sg8AP9aXZ3fYXAyvCpHD/+wcosTdrb4YoPEvHSuJWKjSfjPvWjHFi0vdyyXpRU33A1lMfh0DhWDD99rffoVxs6aJy3T3EXvFc2cPij8VfKD8Y6NFoh0vZ2khgT6NlfI97Fhc00hlNaTbg9MLJzmmNp5AZ1Il2t2pQ9vggPDW4K4Qk4tnB1NRJXN52x9z6WdPEdA88Eb9T8nUvf8heeNkSqcWfutJDpYdFK4NlqjCY5PusE61Rclh3glydoBFjYpETHAJN7AH08sz3OaEHE5U9gNRv5nz3MMrkqE4dGWxKSOqa3+oDIJ4Xey5WFOvgJeWQcEKV9YZI6Nw5g1Wj1rQxUDX1xwsop0noldOZUBBuiqB/7Uzk47LZ+NHcbgWW2zGImY3A5YPS2ozkkVglzc2V6CUwoGREUxWf1TRLxErElRGfh8KWB2RdxQ1vcE5tsgtp5BeSUnGTph1ivobWF1oTlSnDA8Wy7p82qQQXEx31pGSuyWTl6lN46XxmEaIkQVf x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(136003)(396003)(366004)(39860400002)(376002)(41300700001)(316002)(31686004)(38100700002)(66476007)(91956017)(76116006)(66556008)(186003)(66946007)(36756003)(8936002)(110136005)(5660300002)(66446008)(2906002)(2616005)(558084003)(82960400001)(54906003)(53546011)(6512007)(6506007)(478600001)(122000001)(31696002)(6486002)(4326008)(71200400001)(64756008)(38070700005)(86362001)(26005)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?TjRLeGlhaHVKQmNyNW43RURWT2JLVE94cm0xL1RVV2p6N2FyNG5Mcy9FL0FX?= =?utf-8?B?czNaODN5MFhLZ1c5alo0d0hjVU1Sd1hwdW14NGNBNHBQWkV3RG92QU5PeTNI?= =?utf-8?B?SmhGaXUzYkt3Y3VQTGhwUWQ5UUF0OXNLb3NhY3dPcVpoYkYvRkJIQW4zWFd3?= =?utf-8?B?MG1qM1F0R0lBVWY3QWxDMEcwRGxvbGFRZEV6VjdIRkVUbHFhMVlWMStySmtC?= =?utf-8?B?czdUb0xuVExaRzl6ZHZvTzNBTE9aU1JKd0phKzlzQy9Ldk1veEZRL3YxRnl0?= =?utf-8?B?dHdnMXkzWFN5MDhNOW9INzh2ZWdvZnhxRzBRWVlxVkJIUDVWNkpEbXRaZDYy?= =?utf-8?B?S2hsMDh6YXl0NGp0dEJrNXBPQUlGdU84ck5TMEFPbmV2TlFwRzRQbEhqZUl0?= =?utf-8?B?YUpLMXpoQ2MyNVh1V0tUOTJQY3ZTekRrWlpGOXN6QXhpWDM1U01BYkQwWitU?= =?utf-8?B?KzQ5RjlwdWlQSlROWW4vaGkvV29ZWlZGMzJBSnl1MFJQM0RHSU41M1NRNnhs?= =?utf-8?B?Ylo3MjlUcGZZRDRNVnJQaWVSVU01MzlWNXNkMlNialBTTUc1Yjg5VWRBUml3?= =?utf-8?B?WC9LbTdJa1A5dXFDTUNsZXhia0lUcWN5UnV3MkpLTnRBMGpOMWxwdTRyOXlU?= =?utf-8?B?ejRoSkh3ZlJyenRJclFJQ2RXYXFSTEt0dVZGeTJ4MUlUR25DbUtUMzh3eit6?= =?utf-8?B?NnJSUU5wUk8zKzRONkJxWUFGSldoUDZDdU1tSVFSQzNPQ1lXQmEreUVHWTZu?= =?utf-8?B?Q3pEajQ0U0pGaC83WHV1UTMxUFkxVWFSbU85T3YyLzRZM2YxRE9xT3ZOSm9Z?= =?utf-8?B?WFVEcnhCdFkxOVkxem5KYnV1clhUczV4aDdSYnYrTFA2Vmo3Ri9nT1VvVnFY?= =?utf-8?B?cWx3SWZ3OU5jYVNCcldyZElRa0ZwNGlWdFk1L2VNRHh1NnE1QlJheE9MNHRx?= =?utf-8?B?bE1sNURSV2F4TCtDYzlXb0lGMzNuVUE2QjZHU2c5b3J4SlhCRTlSV2FhTGdv?= =?utf-8?B?bXhnY2FNNzNyUEFpMmhPWXFEZkdVNm1Wd3d3bVorVkIwNnJYYUhROSszVi9M?= =?utf-8?B?RURxa3lCU3VoVG5mUjBsbjdOS01JWkxEMFhMaUpyV3JKUnlkU3ZoUWN6UEkz?= =?utf-8?B?aC9ibGRtZEFMTFlNVXVkSmpIdmtiUkk4NStzTlJhMjVYampKK2c0SnlGSE9L?= =?utf-8?B?SGl1VWxLNDEvZ2V3TWppeTc1ZnFvbXM1NlcwQUVQR2gxTzdZWGJnNjh5OUR6?= =?utf-8?B?QmY1UmFCM1Y5SW05bkxURVY0UUZ6ZzIwTVJjQTl2Z0IwS3IzNVN6YVVUQTBo?= =?utf-8?B?WU1BVncrYWNPQ1NncU9NVWlQdjdRRi9INzdRbVRJTStWQno5ditxRGwwQnZG?= =?utf-8?B?bHZhd1I2RmRYeWV5ZnNjUFgrK3NLNEp1RmxsY2lnSk5ldTVCeGNtRzYyaXRo?= =?utf-8?B?Z2IrZTkzMk9OVERYQ3pXVUF3ZDlSeTFNNGs0TFNjQU9XcElnU2NMa2hFaFpI?= =?utf-8?B?alZhaVh1Q296cjBsOXo4aHE1R3JxUE12OG11OFBKUkN2cHJ6Ty90Vi96dkF6?= =?utf-8?B?a3RlVXdwWU5qc2lzZUQ1K0RFTU1rSlZTVTNqdEFQYm85VHJhZkhvSUlUM1Fu?= =?utf-8?B?TnMzbWZpclQrQy9yVk1ZeXZwQXhxclBvcGNkR3FSa2JiUGFJT242Yi9VTGFm?= =?utf-8?B?NUZOLzk1bTFwbkdScU9ZZUhnc1UwWUY3Nk5Ba1hCWTU4MDJ2Z3ZnaEhOTjlq?= =?utf-8?B?MUlZRUttQ2xzZVBrKzZtZUtFRFhNU1hlRGtmRlRQemxudERQOGUrOHRMZ3Fm?= =?utf-8?B?VTViZVZSckRmdHNCZDlmVXd3UkdRNHlvam5CUFlmNW1oZmZVRlBNdWtWS0ZY?= =?utf-8?B?MWc0ZVVkRUVUVmxrbVdDT1FmdUpyQW84M0xGODNvQ3JzMXdoUTBiU0w4Wi8r?= =?utf-8?B?Z3BEWWw4dzNLWVlQNG1Md1dYdVh2MGYzZTFjcjhJQnBwbFE4NGo5VzMwT1pJ?= =?utf-8?B?Vi82VGx0b3RuRldFVnNoKy8yQXhaYnJlOE9ZZ0VTenlPYno2T3dUWG9leng2?= =?utf-8?B?ajBRaE9naTFlcjBRZkwwL3FsQzFDYllsdlhLTlJqU3pGQWtBcnFYRE12RlpG?= =?utf-8?Q?CB95/IR9JWgKA+qewZMDjaMUZ?= Content-Type: text/plain; charset="utf-8" Content-ID: <5985A9DB981F984EAF6F5D3CDF60828B@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26fa6380-b573-4d1c-2b49-08da6fcf4fa8 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 12:55:41.1524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TNRHnuWoAUwhL+jGBYeJmUd1FxVxkI695t8ac1hQoESEgHzWL6oto/Vw8zs6MnT3OC2Fql9AjICRuyWTDXRwrjKQzIIhkXSRq21YAoP9U+o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6423 T24gMjYvMDcvMjAyMiAxNzowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IEluIG15IChkZWJ1Zykg YnVpbGQgdGhpcyBhbW91bnRzIHRvIHdlbGwgb3ZlciA1MDAgYnl0ZXMgb2YgZGVhZCBjb2RlLg0K Pg0KPiBTaWduZWQtb2ZmLWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkFj a2VkLWJ5OiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:57:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:57:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376187.608790 (Exim 4.92) (envelope-from ) id 1oGgb2-0002DT-Kf; Wed, 27 Jul 2022 12:57:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376187.608790; Wed, 27 Jul 2022 12:57:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgb2-0002DM-Hp; Wed, 27 Jul 2022 12:57:04 +0000 Received: by outflank-mailman (input) for mailman id 376187; Wed, 27 Jul 2022 12:57:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgb1-0002DC-0G for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:57:03 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9a4a869e-0dab-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 14:57:01 +0200 (CEST) Received: from mail-mw2nam10lp2102.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.102]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 08:56:58 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6987.namprd03.prod.outlook.com (2603:10b6:a03:43b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 12:56:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 12:56:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9a4a869e-0dab-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658926621; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=SaU3rbelZEF2pKEPulzwdR1rFELP7z1MoC08BG2xuck=; b=WtlgMnawmFiAisZPaj3/Zd7Y35wEbclqM4acTjznQu56XpnDQ9iJUmpu KEh4GwR44zj02rIPSin6qyEHF3pNWGBHlj8Q/5Ml9OxOuoZdoDoYOkPGs ZjuHrDb1kFw86xnS9cOrwcSPoJl0QU0pI7eRXeubdiyBPcZ8moIL/aTv5 U=; X-IronPort-RemoteIP: 104.47.55.102 X-IronPort-MID: 76530055 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:n4tsOaob7/Pfba1rBFFxD/736BReBmI0ZBIvgKrLsJaIsI4StFCzt garIBmPbK6JY2D3c4p+PN7k9EgOsMCHy9ZkSgI9pXsxHn5D8JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUc9vlNLD9ur sZbOSs8bFOb2MSzmrekH7wEasQLdKEHPas5k1Q5lXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NvuQA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE2bGSxnujBd96+LuQ8eUtiViSzXcvAiYraWm/mOmkpGqQVIcKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxRuuOC09PWIEIygeQmM4D8LLpYgyilfKUYxlGavs1tntQ2iom XaNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:pjdvo63pFNG+sW9Fv03SOQqjBJokLtp133Aq2lEZdPUMSL3+qy iv9M516faGskd2ZJhAo6H6BEDuewK+yXcY2+Qs1PKZLW3bUQiTXftfBOnZsl/d8kTFn4Y3v5 uIMZIObeEYZmIVsS+O2mmF+qEboeVvnprFuQ6U9QYVcegjUdAZ0ztE X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76530055" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmjEUcxBkI/AkMgtBSdwixIah+h1G5Hc5l9OmkbP9fdj7/rIYc16COyoF3DAT5hyDgrjEzJn92w055DP0cX8gZdRy39hXMeZD0t4sK7pr5u1O2YfG+j5xTlLUNCMFqwVYo541npiSUxsHjlFPrNqwjncz28bAZyX9Fb11tNKJTVsbZPviDSCbpSrPEXFNwIza+CpbNIRvazhf8/H8J6nyvRy2WWe5QhOaA0j/VGE5YGVnKnMjC/KXjWPS/fFQCpwAxemLJDf+ln6BsX4owg3Cahj7f628RHGzmdWbnvfeGbDaJJYtHrMJKctOwLk4+2J6Gn/U64y/hTUpWmT54qF+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SaU3rbelZEF2pKEPulzwdR1rFELP7z1MoC08BG2xuck=; b=Kt4nIh6LL2fUl7rhaMx/oOkAq3pwpL3bxaA3/bAWThGhFGaYFQyNsr5pbb6OuwqOslyvFvBOFoe2YHxF8i+EH6r/x8ZgSNutR79H+vVP3lcn168ze41Mk2PiO7Lf3P38q7YE50MMK6TEXwAT0cYGMeMsMqfF9NvE/FEmRQoo+jYndxa8hUx01SLGdnemdyLbA9Ck90388hhmLVC6xTtPmstwN4Hgv8tqOy7Fh0xGU0z5HziGnVuQxzmTiGiud8rpblU2nmfW8iYlY3C4fSxHiV5S8pcFfq5BPybLHxh8aGIFxICxo8yB1NaYuGoULph2q3km68ymiFEXveHpcB2H5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SaU3rbelZEF2pKEPulzwdR1rFELP7z1MoC08BG2xuck=; b=O4a1RXOICdXCNKinsbGm13FR0lnK+W/hPYGnDx/pMWBbK06V3VuSBYsbOjkdVRST394tjP8JbMDQa1VfN1iYZ7mm9vvMt+Lq7p/u61NwtUkls2udzTF6IkwceFgd0SC6eDWpw2AmMQGpMatLroRAjieU2qL3/iwbXyw5h8+65lA= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 5/8] x86/shadow: don't open-code shadow_remove_all_shadows() Thread-Topic: [PATCH 5/8] x86/shadow: don't open-code shadow_remove_all_shadows() Thread-Index: AQHYoQmWhrHij1z4oUm+1Z4MS61G4K2SLp4A Date: Wed, 27 Jul 2022 12:56:55 +0000 Message-ID: <8c073201-cf91-bd14-5e1a-51f52e8aeb7e@citrix.com> References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <9af0bb78-f419-b4f7-d20f-cd46a5073f01@suse.com> In-Reply-To: <9af0bb78-f419-b4f7-d20f-cd46a5073f01@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cfb42ac2-be0c-4482-6066-08da6fcf7bcc x-ms-traffictypediagnostic: SJ0PR03MB6987:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IKRNWzg6fHaiZKpCKu0jNjIOcaVU99wUtAxtroe2q9YCofOPvk1m7Y7kchnXRi9/1Z7VDbcK5UGnz9Dm3r23BmF8o/gTNeekWUFlr6IZ02ZOGMdhEWQzPl3DlsHdJe+P07yQKuKYuPbDot5v52J15vUgLftBbZqKf8e5bX+jCYluX3BymiKCXHvNB9KrQlP6cITzLQ6oljIp2qklPTNR62IpxAMZhrsxWkTkxowLUoUkmqfj4pAby7fAoCX66tUE+8RIRRm5V79ayPDWeBhmJ/6ns7jntY/fvi8VdYc5RcfejYG+Hpx+JNW8en8bFJZjUfV+HKNHM3+fpOkvo/81ugalUbyOXU1tdzUHBcP2xjE/KIPNs8a97VE+YXbmt7V59yDm7mpC9NIeCwsKZBx/XwPm+fVsOKgWJCTwsU+SFGKrg25CUw8K5y7NYzKcbxnwJ2Bb4/lY6V+JpgtTpyyNZMPugCBIT8duliLUcJKSk7drhL+HYWpOhTSEVUJ6kgSEttke1v8ZQ1+5LY71piNRj3IUTiw+wDE2FBKwbtPavQxcg0Ihw5hILZpA4BIZcmm2E0os95kUBRBGCEibjchGl9TsG7GS/5YiN3Eum2dEmr5ZP+C27zb+5lz3/Na2CFn/XivENnWglFQZCzCairXo7PnjDxm8WsOPACFgfJU1egdNjfW9a4JL1qwDVw7kbDdJZj/uJ50KYqMpCjoVsw/yVLk6C9rg1YxKajSlUUeqDUiDYJXUjpzNpOEAFpY4aL1XY1Mgq26pLtFtApsjmEFipCAo/6pUiqgq2f11poO51CV7XOhYaSDXbqSUnAk5TUKVNwl8kG0Teh8mVV7XHyrejWptjLJKMKE2SUWmp5ruSyfnyb8C/nQACSalDwmJ5sgX x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(396003)(346002)(376002)(366004)(91956017)(186003)(66556008)(316002)(76116006)(66476007)(558084003)(66946007)(26005)(6512007)(41300700001)(4326008)(64756008)(38100700002)(122000001)(66446008)(8676002)(6506007)(82960400001)(53546011)(110136005)(38070700005)(2616005)(8936002)(5660300002)(71200400001)(2906002)(478600001)(31686004)(54906003)(86362001)(6486002)(31696002)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NisycUFMd2VJUUZyNFNGOXYvMXJkUWVLMHk4WDl0WHFNZHNqQlA0eTZId1Fs?= =?utf-8?B?WngySkkrOWtpR3VYcWZKdmJVak5mUDBFUUZCN1ZRTUpOaVRLMlYzaUd4Yzc2?= =?utf-8?B?MkJwZmNlTGJiaEdGOTNhdE0rM2o3MEJON3NROUZjY3RDQ0hMV1liR0lZSjdl?= =?utf-8?B?b0tHSW1rM01QVlk0WGRCSzE3VkFUSzFqZW5pNyt5TTQ1VjlCVTdiakxadThO?= =?utf-8?B?V2pRVE1mTk4xNmdqL1dOWFViSGk4TDF3dE9ZTlQ1aXpXNmVRdzVSaXQraFdh?= =?utf-8?B?YWgramg3bFo0QmU4TXZ5aTZNanZBR3JETUwyRmhNb1piOWVPUEI4ZzlmKy9t?= =?utf-8?B?Q1JvNVhsMjZOa3Z2Yi9HdFhRWm4ya2J3eW81Q1NEU0xZcUY2ZitQM1ZGVG5i?= =?utf-8?B?Nys2T3Y2aFVMOWNYRkpuNGpXdlRnNmZMTE11UXI2YUlHL1haN3ljQ1RNdXVw?= =?utf-8?B?cENobndCWkhuSGo0SVpWUUgzTXZmUWtPME1sT1BVTlBaekdtdFROR1JPRzI4?= =?utf-8?B?QUVUMEZGLzh4UDVSc2dWNmJJMHpNWmhHRmhaMW5hdE9EWUNIakN5WlExeWxT?= =?utf-8?B?b3NFVG1nbWxYQy8vclBzMVhodDNvRndPRk1sR2J1RGxRdmJvNU5vazdyais2?= =?utf-8?B?Uy9RbmI2a1pmRzFvVmNtTlBIdk5rTGVwdU80NjVINUxmMzlvaldnd2tqcjhj?= =?utf-8?B?ZUN2RC9CV3VCTDBNejN3TVllV2gzOTlEcURDQmpKbndNeEM3c2pGNUZIdGR0?= =?utf-8?B?aWNxNFRLVkQ0Q21GVnpjZmVsRlF4SE5ZMG9rZ2gvUFNrY2FOTFh3UFdDb1Nl?= =?utf-8?B?RXBwQndFR21kRkRrLzNwemdVYVIrL2xPOWtjSG9UWWIvNExwK29mYTI0Z01s?= =?utf-8?B?VzhVUlM4dUpFZXdLY0dWN1ZoK2dOTTZ1UXc3WHcwdVJPK29tZzROdUV5cVlz?= =?utf-8?B?eVhENGdvSDI5SDViWlp2VkI2TlpCQzZNOU5QT3lyUGNSK3pKN0FCUzJaOWRJ?= =?utf-8?B?cWlnby9QNnBrWFFJRURzQy9pVlI2djA1SHpzZ29icDVkMjIvUHI4b2hLbkJ5?= =?utf-8?B?d28zMWE2N1RQZTBrSHc4SkI4NmI2eERYRVFMUktJTDVyV0ZzekMySTQ2UTVu?= =?utf-8?B?ZC9MZ0FINXhxRzJtVk9tUlI3U0U4L280dS9ENGxvMUdiODZpZ2lqaXlTYTRp?= =?utf-8?B?MlAwekJmUTIzOThndmZ2U0F0NUVsSVk0U1dGWm5OTmtlRWljbGxnSWREQ0J2?= =?utf-8?B?ODdibGQxUCtrQkFUc21IbmhpdW54SWNtMjQzWEs3WWZhVGJvZ3lHVFZicFE0?= =?utf-8?B?SUJnRDJFem0yb3laTHFlYk9kTHdGRzIvbDAyY1BuK2tiYzVsSkh5STN2N01i?= =?utf-8?B?WFE5QnBNOVk4bEJwbzZyL014Vm0xOExFcDhOQTlGN25sYnFKT2J2TWt3KzhP?= =?utf-8?B?ZmpzRGxGWmRIVHlBek9oc1hkT3RvWVJod0tYOUYraVRpMWdMWFVwV2IxY3pu?= =?utf-8?B?RUNvU0YycWtqNGJMWlJRL29Sb1ZhVm9GRVJKcGh1YlJkRlRacWZXZk9lZFdI?= =?utf-8?B?NlFtcVphNkJOU3BnVFR0RTJScUl2cktKTkE3akpoMjFRUW5Za2t3eC9QY0xV?= =?utf-8?B?STBxaENCOTc5RmlZSVpsRlVZZUdMM1ZsaGtVd3laTTI2TlJMTXJpM3d0dDFu?= =?utf-8?B?aUxTYzc4YkYrWGZYS1MyZUx6RkxnWXI0RTRhSytTWTJtSXcvOW1QTjltN0hI?= =?utf-8?B?dEJMNzlLdjZtNVR0UlhPNzl0UnZmbTJOVTJJZTZzT0hKK09ZTlJPaFlsd3V2?= =?utf-8?B?QjMxTVBBdW9zTWs4Ky8vckFNTU5IQU4wTEYwSVlaTENSYUdCZzNsRkE4bnlv?= =?utf-8?B?UG5EaFJqazBpU3RJZnhYMUJnd0RjQURreU56d0kzUEdkdERxRDlpdlF3S3Na?= =?utf-8?B?V1VtWTdMcGkwRzRlTVNNQXJob2FIcFBEc0tCY1FLa1pycVI1Tmt2bUdLcHEv?= =?utf-8?B?UHFFOXYrNmlKUWJFdlpPaTg1dWJyeVN4dk4rT09rUXF2aWNqVGZ4b1dsMUly?= =?utf-8?B?T0ZxaFAwdWZpcjRueW9oWDNvb2xGS1BVcm1KRVlhTUVXbkc0UGNhczl6MTNT?= =?utf-8?Q?6TxGE+/CBFhA9xFwXNLwM+Kai?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cfb42ac2-be0c-4482-6066-08da6fcf7bcc X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 12:56:55.1782 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Zgl76qFGRvLUgtL3ezT9iknCoFHunMOsPzvI8cP/+H8jw23NzLQ+sDysYx7YTlcQ8ZidZfCEh9mG7D3I/Lp6tHEaHe6mttBU7nCSOfmHo+M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6987 T24gMjYvMDcvMjAyMiAxNzowNSwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IExldCdzIHVzZSB0aGUg ZXhpc3RpbmcgaW5saW5lIHdyYXBwZXIgaW5zdGVhZCBvZiByZXBlYXRpbmcgcmVzcGVjdGl2ZQ0K PiBjb21tZW50YXJ5IGF0IGV2ZXJ5IHNpdGUuDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEphbiBCZXVs aWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KQWNrZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJl dy5jb29wZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 27 12:58:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 12:58:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376193.608802 (Exim 4.92) (envelope-from ) id 1oGgbv-0002mH-Us; Wed, 27 Jul 2022 12:57:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376193.608802; Wed, 27 Jul 2022 12:57:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgbv-0002mA-S8; Wed, 27 Jul 2022 12:57:59 +0000 Received: by outflank-mailman (input) for mailman id 376193; Wed, 27 Jul 2022 12:57:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgbu-0002ly-BM for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 12:57:58 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bb367685-0dab-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 14:57:56 +0200 (CEST) Received: from mail-mw2nam10lp2109.outbound.protection.outlook.com (HELO NAM10-MW2-obe.outbound.protection.outlook.com) ([104.47.55.109]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 08:57:53 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by SJ0PR03MB6987.namprd03.prod.outlook.com (2603:10b6:a03:43b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 12:57:52 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 12:57:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bb367685-0dab-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658926676; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=YXBIJbRcPcNK1frr5weoB4MVBG20k3YcTGS5TKPeX5E=; b=PFGYyHOp7RsTLGmx3zHN6Wdy0TiDvQeYi8kvM9AnovyV/4XmhfMxgUdS wMFpVR1ISz3091A2Wrrj0CUoPxTVo8PH3U/kjwKhyFLHZJYg3cIoOgg4n Kgl/IFBzs2vtX4+45AZGCIk5EOaIt64JVmo66mUpDW7M6J57vIr5ceS34 w=; X-IronPort-RemoteIP: 104.47.55.109 X-IronPort-MID: 76737663 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:x3DKK6omahBKojELLazVPTcKZ2teBmI0ZBIvgKrLsJaIsI4StFCzt garIBmEbvbZZGejKtskaIm/oR4DuJWDyoRlSAFkrSkwEHtDoJuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lH5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUkw/4tXmBHy cA8KSAXUBycvPin+eqSH7wEasQLdKEHPas5k1Q5lXT8MqxjRprOBaLX+dVfwTE8wNhUGurTb NYYbjwpawncZxpIOREcD5dWcOWA3yGjNWEH7g/I4/NvsgA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE2bGQxnylBtl6+LuQzNp2gwKcl2MoJAw2TgD8jPzklG2GRIcKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS+AyLj6bZ/QudLmwFVSJaLswrstcsQj4n3 UPPmMnmbRRwtJWFRHTb8a2bxRuuOC09PWIEIygeQmM4D8LLpYgyilfKUYxlGavs1tntQ2iok naNsTQ0gKgVgYgTzaKn8FvbgjWq4J/UUgoy4QaRVWWghu9kWLOYi0WTwQCzxZ59wEyxFzFtY FBsdxCi0d0z IronPort-HdrOrdr: A9a23:L4VFx6r1tpOjYpDsyRG7icoaV5tyLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFb/l/1swKp5KuZ3IMvB0vFvLM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsul6SR4IeMNYYDGRfzO2wGgo+nv+gVBNHdVr K6JI9WasWTWFfTJQ== X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76737663" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Mayc0HgpNh8zWoi3VJ3P3+045yBkybS6MZG/E+qW+L+tv1k3RcvVA2rqPN35LdXQBJY5npYvIJ7noWUKLx3XcgpMM5yj4Q78tKu8YDXP+Y9frD/yQHT8ueb7raLirnqMiNwHwKvmKjqIND+lNBpAZfjznI5kejsLwJjH17V3/gTn11y3drEyjSMRbFaVxqT+IXYAQX+w1HUOI7LGoc//zTTNsMwVY6ufKMoATQh8Piz2bpbu5ttfPBE/mM56z/q/7na8EJu7mIIQHV5lRsIOsCobqAhoYuQ1rhzz4EENSTAcj/IwRvUDgE0UymI8jqJ10gxixyBujky8WqBnp5sP+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YXBIJbRcPcNK1frr5weoB4MVBG20k3YcTGS5TKPeX5E=; b=Uq84Kb04DLaKkJczqvf1XGkbJIzmEPoe4cYIEm4bVmYjX+0yvkBq+ovZm7C7Cn2bp5W2vGGBrfAtUqKAh8MHCfI6qstqpxhdI+HVPRv1I7WA3MPY5jU25wBzsOQVwS6JPD6ec9eTdFruvGbXdaOXKVU1QitmqOkpgd5F33kTiZxIDGfa/panvTVRjPzVd9V1fCRuSOtA8c7e5JD4j5EZ2tai5s5APfMxFn6qxcPYFqEK94jL2RBlFkB3Dso84ESznp/ri/35HgH6U6uODQywF20/Vt0fVNiljWHDoxUlvudNk68xGrDbUiWLys/Jnvb969G2ree9NDzJc+nnfXHN1w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YXBIJbRcPcNK1frr5weoB4MVBG20k3YcTGS5TKPeX5E=; b=PiMYcvyHBPg1YdtbBPaJ2YV9mhSRtnm0ecuiuMMLpK4FfdK+aJzCsBS5EciirbKuV+u3V4XdSytK6BmzrVDAFzYi0KraTqJ2brkiiAmOC1Zd8oxv9zwTDtNb22CyzyhF/a6IL5A7//vNcUwL/W4RRO6pJlJ9Xl99URH9/WPTsO8= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 6/8] x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Thread-Topic: [PATCH 6/8] x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Thread-Index: AQHYoQmtxh8Uz5Bps02ppMm24Q1Niq2SLuIA Date: Wed, 27 Jul 2022 12:57:52 +0000 Message-ID: References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <03ef104f-91a5-596b-235d-1a0fa47963e4@suse.com> In-Reply-To: <03ef104f-91a5-596b-235d-1a0fa47963e4@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88709425-e2d6-43e4-897d-08da6fcf9e11 x-ms-traffictypediagnostic: SJ0PR03MB6987:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0ofX9+gSnqdLWOeUKDMpOcWsdga66pmF11ngxBfiI4H7yBVEoTQmEeLefUFVT0rCTjLyfVGI+sFMQEfZz1rETj+0rWNcaXJkmP/mVgBqcbAJpIicZpZD7jIaA25JoBZDAebGVAxUOeZgRR5Qyuxp2SBbLGWM9D8bR0k4iiY1IZ0HNtzuCUQg/q+0G314KKATyp5lGzjPCnK9hd1EUpu5OujitbLaM3mNM7fNovfIsAklK3TgVZJ2y8p5iVCMvXjYKejfIoDXgsZmPAL8YaYQuMOo+L7bsutqcNnajnRhFczNteizEbUWjZUYKuardey3gSHvpM3QiHo0xSx19yfsMTvFMHyw+TNG33r3rPGw8yKySiGzF59AGvFikrkbmv9gW6+eyeskVUhPQ14Ld3CLQ1QXDyKquN5YKJm9oqnMTd4eiRuaVXSuWmvV5dDty+0SbojHoN0/SCGi4QM01pSIhfwdP6ECYyD4rUggOPDjhs2EyaRVzIp4Nn0WGydZ4YQEqyLPR7UjsOz/X7okQGUFlH/qsXQ/eQRMEzhaUVQTYZ6wUUEo6ncprtWzX42pupkYdI3g/UpN+0zqR9XewFxcoK9n2akeFLgX7RRdd/WCvC4Md545/gwxgOfXADCs1lU+AKFgVUSYg9DcS19roVFwISI9ZM9/V1N0Mdr3IV1Y7zFXY6YsP8K+V1LdWiY1YcNOuwX08MESYnJpg+g+BgX0KcitJ6Xd/rX8loyY9Lz09CPgac3t4t2/n65YnyioUM0EgF5txkthpVju8hw4ZdZqjkVWzzqlRKHMULyEVDgLWZbinUfVAbURfpKxROaGnY3wrddq3xFZ4AFO5x8tzaACn83Ot18jtSLZDgYOtmNfM62+hFuWPhveBmtJ0C8btZdV x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(376002)(346002)(396003)(136003)(39860400002)(4744005)(8936002)(5660300002)(71200400001)(110136005)(2616005)(38070700005)(31696002)(6486002)(86362001)(36756003)(54906003)(2906002)(478600001)(31686004)(64756008)(66476007)(66946007)(91956017)(66556008)(76116006)(316002)(186003)(53546011)(4326008)(41300700001)(6512007)(26005)(8676002)(66446008)(82960400001)(6506007)(122000001)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Qzh0eXFSSVluaHZvcUNpSkJRb0ZzM0ZCZzlTc0pQbElnRXM3ZC9QTE8rNVNI?= =?utf-8?B?YnNENERsenluMktOWFpMU05UL200bEMzZnlEL3A2cW5UQTJIS2lRdklyZS9X?= =?utf-8?B?SEtnNi9tcEdzaS9sZ3g3RTBLYkdBYmJ5SEM2NmlNanZMaC9ONW9kY3RXWXVG?= =?utf-8?B?bEhpbFZzRUpNQkZrNnpORUpVY1lZUHpmOThBZnFwWVJ1NTNqMDRkc0wrWEd5?= =?utf-8?B?S3prdVp1bWdFMS9SMW5XMTFZMHFjN2hqK2Jyd2s0RFBxcjcwNWZjRGRIYjJE?= =?utf-8?B?cmVwRDl2ZnRaa1ZzaWV0Vm5RZFRDd05pdzE0RmtOSGtGZVFLODl2SVBPd0ZI?= =?utf-8?B?Sy94Z3hSYzFvaHlHWVRqSTNtN2RhWWExS21RMzY2NXRpUElkdnRlSFlnWDlR?= =?utf-8?B?ZzVWZkRDOFFCTHRHRXNVQXhYZzFOdGtvTnZ5WU42K2FPeEcrZWRkeHE1b1JT?= =?utf-8?B?OUJXZkgwZDl2TnhVY0tJQnd3Z095WThScitWQU9hanphcVR6SXRyVE03UHF3?= =?utf-8?B?YXk3MUhxck4wT2F6NkhuaGcyU0RDdXJSVm9BNUdWd2VXK2JtWmZ3c3VyWExn?= =?utf-8?B?QmhsVFUwY2dpUFd4NmZNdUtUaUFtN0RCRmVVMWZqWmpycVBNZGJyenFhN3E4?= =?utf-8?B?d3IxWmh4ZnRQQkl4ZENRM2p4TUxWL01EMFpxd21DVkNwaHY1S2VNNDFNM0Nz?= =?utf-8?B?QUVJSzEvV1BIZURnOTBLNytPMk1UUWpxRmxvZFNYVHB6a3pJSHh4RGhyM1BN?= =?utf-8?B?VmxQZE5jbGJmU2lVRW1GUDFlei9LMDJUTE9nL3Y2TnVSZktZcUpZdzhSTFZ0?= =?utf-8?B?T2IzQW93d1BPbVk2MmlHQTEvZE43WmNvTFlXYkdqbVFLVVFGV00vVDBBYm5T?= =?utf-8?B?VUxMN2FJb0lUd3lnUVBZWFJGL0FVK3h2elNQUU5YZU5ObkR1WStBdDJSY1hz?= =?utf-8?B?TGNwMy8vb21JTVoyV0tsUzVkU093MnUxSmNab1QwUnNpQmo5R3dmaWJ5a3RJ?= =?utf-8?B?dUI3TmFKRTZVdTZMeWNFNU9NVTEveCtKQkE1WkxqNUk4b2IyUFhsUCtjWnpj?= =?utf-8?B?ZFFNWmRoeHpLNmVCVkZPR1VQMmxHVkdsVVNxQWI4SUVxeVJSVXF3Y2ZuWjBm?= =?utf-8?B?UG01MlM3QytSaS9LaHB4SzdOd3NvaGlzQmZabTlKaFVwK0k0WU5URloyc1R1?= =?utf-8?B?N21ya3dxU20rR3BsK1F1MXd2WkdWSW9qRXBBN1ZrdmR2K1BqSFQxbnZ5QnJV?= =?utf-8?B?UWFBWU8wa1lXaTJXM1hHVERKeTMyRHY5N0sveXF6WFcrVEQ0aEFJNjhybHNx?= =?utf-8?B?RGNGS2t3QXZvdWNhV3ZoVERkVkJpckNrWUtmb2lUWW84Q3pVZzBWYVZIdDFI?= =?utf-8?B?TStwTXhyWW1kaTdKMURWUnVWL2JEN0tNRjhsa0U1R2tUUEZMYmxwbjhxQjZQ?= =?utf-8?B?dmhKcGJMNzN1VUJLcjV6WWhUeUxjWHJYdlhRV0d0aENJeTIreGx5MUNUOFk0?= =?utf-8?B?T1E0MENFcEdyME5XVVNKRjU0UExUYXVQTHZ2bVFWUUd5YldsQWZRTVoxeStH?= =?utf-8?B?OHhCcW9DTFladWZ4LytPazNyWXFybjdTaUZGNVVzUTkraXVjdFJpYk11R212?= =?utf-8?B?TzcvR056YUJ3ditOVDZ4QzNub2kwdjlFa0dCMllURGdOa3R6TFl6eHFUL1VT?= =?utf-8?B?czJna2RoeGF1dmJOUk5GNTdyQjNzSkJhSXhuSEN5QVRFUHdTT3VlNFBKcWRP?= =?utf-8?B?UXdXZVdOVENwRUc2R2JEK3g0Z3hnblJtS2NUTUwxZ01jOUoyQVBlY2RaZlhU?= =?utf-8?B?S2ZGK3NZazFmZXhZMDVENzhVdDRnRDZWb0VWaWNEc1BlcmRJYW05cFBjeEpQ?= =?utf-8?B?NXRRSE55MHhBM056aGNtdFdkNzRXSXZtdUI2YVlIdWg3TlViWUkrL29KbC9j?= =?utf-8?B?WGZSbXh2UHAwV3Y5THA1cEVuSmUxa2V1WnAxT1pndE1jMGJlR3VNcGVNcFhD?= =?utf-8?B?dHJTVU5JcVhlTHBSUS9XWitadjZXdFR2MTIwem1FbW80R01rNFhlaFhUVGNR?= =?utf-8?B?T243NDhGb01sai8yTURDTHFxTkZjMG5KUEIyZllLQVNsekNMWlZoUmFzUFUr?= =?utf-8?B?QzFSRi80R1k3Z1Fwd0MvNFByWU5jRlQ5WkthMFhIYUNqc2cxVHRKdWt0T1Jp?= =?utf-8?B?b2c9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <68A426244D9CDF49B5058D53391DCD51@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88709425-e2d6-43e4-897d-08da6fcf9e11 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 12:57:52.6740 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: P/cRuxqCwVKwvSJKwbcznhEnlVWEi/7zlIekydsim8SwQai88gcmQbNhHng6kVRFaal0dOKn6grX9gCHwbrhz/H6rG9Qx/SkgjRxg0MtCrQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6987 T24gMjYvMDcvMjAyMiAxNzowNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE5vdyB0aGF0IHdlJ3Jl IG5vdCBidWlsZGluZyBtdWx0aS5jIGFueW1vcmUgZm9yIDIgYW5kIDMgZ3Vlc3QgbGV2ZWxzDQo+ IHdoZW4gIUhWTSwgdGhlcmUncyBubyBwb2ludCBpbiBoYXZpbmcgdGhlc2UgY29uZGl0aW9uYWxz IGFueW1vcmUuIChBcw0KPiBzb21ld2hhdCBhIHNwZWNpYWwgY2FzZSwgdGhlIGxhc3Qgb2YgdGhl IHJlbW92ZWQgY29uZGl0aW9uYWxzIHJlYWxseQ0KPiBidWlsZHMgb24gc2hhZG93X21vZGVfZXh0 ZXJuYWwoKSBhbHdheXMgcmV0dXJuaW5nIGZhbHNlIHdoZW4gIUhWTS4pIFRoaXMNCj4gd2F5IHRo ZSBjb2RlIGJlY29tZXMgYSB0aW55IGJpdCBtb3JlIHJlYWRhYmxlLg0KPg0KPiBTaWduZWQtb2Zm LWJ5OiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5jb20+DQoNCkFja2VkLWJ5OiBBbmRyZXcg Q29vcGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPg0K From xen-devel-bounces@lists.xenproject.org Wed Jul 27 13:22:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 13:22:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376202.608814 (Exim 4.92) (envelope-from ) id 1oGgzQ-0006Qn-2i; Wed, 27 Jul 2022 13:22:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376202.608814; Wed, 27 Jul 2022 13:22:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgzP-0006Qg-Tt; Wed, 27 Jul 2022 13:22:15 +0000 Received: by outflank-mailman (input) for mailman id 376202; Wed, 27 Jul 2022 13:22:15 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGgzP-0006Qa-2r for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 13:22:15 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2063.outbound.protection.outlook.com [40.107.20.63]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 20130af4-0daf-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 15:22:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7830.eurprd04.prod.outlook.com (2603:10a6:20b:2ac::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 13:22:10 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 13:22:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20130af4-0daf-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4tjM0nVtB8NfrraIpCZSsHIpn5YLuoT9YU+B21UYBJMT6+wcP0K3iRhAvpDb4mXX/QnBFEip2d1cdR8MWlGBHpJRHrogBgb7s9U62aV5JDdts+UJDx52jdayiItazw4f9kekO7ADtIKeUyfSEMChHE6hM006Eix8vVhqSHtNvHdcbRhY4Qvjy2ZS6vrjaKlV3RycnLXUcoScpZK9p2kp/wsKcS5Ghv8iaK+C8iiCGbkQwAqc7k2kubVYHeWZGpmpxnuhrd7uJRkD5CrFu/jrB1VNlFCY8JvWt6jSPr7oVjETGaXUY8mxkQEQgSWSL5KvVTliLyRXxoZpu2bBBxfng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uz1Pzwt+NpeMuxYKJIKtLCQNN3fyW25kuPYevPazw7U=; b=kO1XAAhsmrzQUKDvr8TFFGe32N5jFVPYaLuCIRnAcMm2w/YtdkcF2J2TQEIURN0hT4INn0msxBPfXC8Jl9muk0dwd/5v8DfI73ly+DA0NKVGgttMBPO4/SvksceYr6lGP0VaLQ/4VeRmrLrTiT0kYeFHPnQLOYV5VXoyzow3BYcXi9u/Z/yfUsel3r0/REl5YWbFkUdKSTPr4fJT0dlcOOpXHYwQ/2DxmiAKJlVpznqgjbGR6oSfNvFsLsSlW20jBWVV/DZYD47ZoyJwpRWjNBBwrjh2kMIZ4voW4BhdVq/lZN5OBct1w6PqlY6mxkqELPQ5yURSZRBt/ySJRdDmJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uz1Pzwt+NpeMuxYKJIKtLCQNN3fyW25kuPYevPazw7U=; b=NEV0CdzrQngAGW1howjY814ACi8RvMlZzh4hFpjQGQNLHvn2c2IyY5xn1e5/ePLTGjZkRwlGoayoHmfrxSJ4dkhXPukTou5qdLlfhytbo6rv4cPPwVjHe+7CNJJq6BuU6S4d2ph68h9St2YdtpPhO+95c+uwanfy5N/185z5DqCXeMT8P4XKUI6aV8IDODO/gniBgm8xpsir24a70wEaAPHDE8j+gGIFcdy0JP+aZOyV31OThuJbrJQCTUnn721sB4nD9/I87iwr2iaRI2vEFzP31arXEC7+bsPQTsrNa62E9eUaCAqg3lPUK2PAJfXXxvnUwsupOo8TcXcAvRKc2w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0832fa09-8b1e-86e8-1291-fd071fe44575@suse.com> Date: Wed, 27 Jul 2022 15:22:08 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 15/18] x86: rework domain page allocation Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-16-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-16-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: VI1PR0101CA0076.eurprd01.prod.exchangelabs.com (2603:10a6:800:1f::44) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e6205476-cb5f-44b0-9247-08da6fd302b1 X-MS-TrafficTypeDiagnostic: AS8PR04MB7830:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: skoV3PxZ3mle/naNucgVHSlfswfa+/k/Ww+bNS39a3pbYMiHtKAwmcpQjDhzVXlOVy5kbbgAVq+iDo6h74bTrcZ9Xy8w1FqGh9Bu1DF3aupvwORM8lKAVsjEPF24Lna2xxPf1uZO7oXiKrofYeQ9EfCQy5nm0P83UoZC96V2o2AcvGA9zi8HuIY2OHwlH4XQtRYpH2RwcPNLpuDmHJM6cvZ4gVrsU+nkeFKExekkUQb2CWhGyEvvhf1cIxu8XPLJryKaiVbG0MRdi4UcJnVtWKAs9O3qoMeEeUsEWJudwVb+j7qk+kU/V/Bl7U05JNrfI5pnwp8n2h3+1h6WbvbeOc19poeWX3w9aybpQ/7aVvWsd/rYB1Q7TI9HJHUndoP9fsb7cYF9PmAqj+RdJNnZBB5sTBbRdx6gy0LAzbTwoKp5eWsrpEGYZjg9eLOQmc6HK59AhRxmqjrVHBpgJOfiFRrPqcKoGjvG+h+VhxKf5hdTNJXlRincWyNqxIBAfgWZLQ3Q8Gx4WQK0VYFw7ExRF7NowG5PBoPdzuJtliQBAq4OUDoSCJoAYktHDh8PjqV4HMOol8kxEhjK6vYYOxN1ySqKr7kTyNi44ZOBCmAPeshiU5fY5q7Ph2HdQFpgBu/rWNqufSWm3x9zJSyKDzYLR10n1pCOeBluc3RUDTGg0bY97w+OcRymJ7m5jtEGCvaVmt/sNRipMn70N5P0nksOysR20VcUq/zkIyk3aXYK1stAAZMrTISaHuNxF2pVNHNlSKgH1U982PplAbX18QCvmUGynqniyLKWDvEMco0/erechMosVqy4NejBdgfAP2lrjE4OWt9IuqsPveJVfqVZNA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(366004)(136003)(39860400002)(396003)(38100700002)(86362001)(5660300002)(31686004)(31696002)(478600001)(6486002)(8936002)(316002)(66946007)(4326008)(83380400001)(2616005)(186003)(54906003)(66556008)(2906002)(6916009)(53546011)(26005)(41300700001)(6512007)(66476007)(8676002)(36756003)(6506007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzlhYnZCSHFsRDJucGJpNjdVNzE4NDdHUzViTE52QnpUTUFWZ1FTSzkyUUJr?= =?utf-8?B?L1N4WFM0UExVRVVFZFBxdHRPUm41ME84V0I4NStRVzVhWlpkcWZ0Q2tsbmxZ?= =?utf-8?B?S2xPSGRXZElNZzQ5c1JHd0VUdmtKR3g4UVVJdGgvc1Z6L2h2bVZ3cVIrVjlo?= =?utf-8?B?STFUb0lrTDNNV0wwQUxwUEh5NFdxSVljVHozVmIzeDBoWXpCblRUQWtZbE1p?= =?utf-8?B?S0VPZWRQYXVGN3NnSHRGVStHZmw4NjZFVTNCNXJzWjFlNk9BVXpXcjZxNnh3?= =?utf-8?B?LzdYbVVnMW50UGx5aDhqbkp3anhwcE9yU21xVU5jM0o4TEdWVlhhR0doS0c2?= =?utf-8?B?OU1kVzFJTnVTeGhpcTFUUjJCTWZJblpHY3JycG1qSUdMa1ovMjJlbURmTXla?= =?utf-8?B?U1ErdEROUTdYY25Hb2p2TWl0MkNKMDdxMDlDQjkrYzdkbFVPZGxkVi9wVnlV?= =?utf-8?B?anc3VG5ER215eVpSOVlRRnN1RENZYktDSXY5TXBCN3RrVDJpcTlEMXZZZ24w?= =?utf-8?B?NkZOcU1sRkZqTzlPbG13YUd6QUJGQjhnQTI0WCttSzJmeXJnak1vSFVabFpC?= =?utf-8?B?L1RFckh6bDZ3VEc3SmxHL1RrQTIzTU5nYTdxQTdPNHZjMGh5eUVNZDhDWldL?= =?utf-8?B?VytPU2tQR0lwU3gvaDN6UGN5ZXhBRTVJTWdabXZhSmFTeThvMnp4dStSbjhp?= =?utf-8?B?cmdDZUNXNWs0RUpuYTNaOUliSFhUTzFQYlhBUUZjZGszM1NlcmtHOUhuc1NK?= =?utf-8?B?a3daYmdPS24rQmdNV0ZveXNJNnIwSTBmZnJrRUFmZ2hrOTZJVGNxNE9UUVRZ?= =?utf-8?B?ZUlpNXJtbVBBdHF0ZWFNaXl1QnJkNEVJL1J2N0QrUkNNWFdWdmQwNjdnMlV6?= =?utf-8?B?cGc2dFlOL3h1dittUW43SGNwS1crT3U3WXdYb3VaUUtGSkdXMzBGS3lUbjM2?= =?utf-8?B?d2xtWW1oNWR0RHlpcndlTjF1OEM0ZG95eS9JcDJjamxmWjdYVllEMU9Yekdn?= =?utf-8?B?SjJabVpLYTViVGVaU0NhVmVCU0YzODJ3VEp2UUY2RjhqUGVHMS92RllZeUxX?= =?utf-8?B?aXpuSGZha3pKdStHZDdyT2FwRDVNaWZzQ1phYUpjMi9QZnBmaVZGclRYdHhh?= =?utf-8?B?MllGUmgrUzhDTmhoVG45RXErVEQweENuejdiMUJlbHlMWmppTHdxcWMxbDRM?= =?utf-8?B?MEdiSmczS0pMQkdUSlZGNzdXMzRaZ1M2czZ1Tm5Uc3EwTUxCalM2UHJjN1VE?= =?utf-8?B?WWJvM1lWQmxTbEVjQnZpcUlubTZra2NDZ0w3OW1rQlhheHdFbGlWUGU4M1Zj?= =?utf-8?B?R1lQWStkVlNmT2xiUGxROXBLV0ZpSFpQMmkvY29HcGhIeWJwK2ttVVRuODIy?= =?utf-8?B?WGRna29HaktNMjhjeEVhM1RDK2JELzJUZWd6TFRsQlByWHZKc0hnL0R1Q0tE?= =?utf-8?B?Z01LMFo4aVlZb3kyU1FIVVo4L0xNampPQVp3eUVZLzROcUIyRU9qZVp5Z0FW?= =?utf-8?B?NGJtUVp3ZGNHZTc5QmJGMjBSRDVzM2duUnRlODVzYlU3SmwvNmJ2RWNhMDhF?= =?utf-8?B?ZGxzOXQ1V1QyRnk4bnhxamNWQzY4SmRlTEwveSt2VnUrQm51V0MwcmNTRGVp?= =?utf-8?B?WDJYL0hIc1E5bUJid3BGZWtSWWhoRmFQRVQyL1JSYWRLdjViTEJRTWZGRVo4?= =?utf-8?B?d1JqT0tBWDhTTkpNakp6V3hXemNvTXIrS1hJblN4d0ErSGR6c2lzbkJGZ0Vw?= =?utf-8?B?MDVtbEcyU2w4bTZCQ1JzL2JOUHZNOG5FVHgyWmkvNUlDOWNtdm13c29pQnRi?= =?utf-8?B?Wm9lRXRSaTVnS3kvc05WMUtUNVVDOWF5bC9OY0VJdmdaNGl1dkpSekJCam0v?= =?utf-8?B?bWtENVU3YUxxVzRzQXU3V1JQT0JmYTVOSEljanJOVUJlUGdHMlNuWEh2TUw5?= =?utf-8?B?dGhsNGxLN3NOcVVMbUR3VFVhMWU4OUJUOElWRkFpdGpyQU5UQVlka2h2Mk1v?= =?utf-8?B?Z0pWbk56UVFEWmlWWFd1OXJGOXZDWjBXcDBpMTFVRys5V2dpdUJ0cEs1ekl6?= =?utf-8?B?OExNckFnOEd0azZ5NEdvMUtMZElNV05KM0hnMkJZRzFlZFI3UkdLQkgwS1Qx?= =?utf-8?Q?7+ST2L5K3RAOH8iyTFSPtUhIY?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6205476-cb5f-44b0-9247-08da6fd302b1 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 13:22:10.1727 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FbvanboEq2YveMGXM23g5udQl6HKlTGyfnsUrkOPrACp1RPa/ni37RkWacsfSIi//i1EjkNLAcR0/X7UqDaHPg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7830 On 06.07.2022 23:04, Daniel P. Smith wrote: > This reworks all the dom0 page allocation functions for general domain > construction. Where possible, common logic between the two was split into a > separate function for reuse by the two functions. You absolutely need to mention what behavioral / functional changes there are (intended), even in case it is "none". > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -320,69 +320,31 @@ static unsigned long __init default_nr_pages(unsigned long avail) > } > > unsigned long __init dom0_compute_nr_pages( > - struct domain *d, struct elf_dom_parms *parms, unsigned long initrd_len) > + struct boot_domain *bd, struct elf_dom_parms *parms, > + unsigned long initrd_len) > { > - nodeid_t node; > - unsigned long avail = 0, nr_pages, min_pages, max_pages, iommu_pages = 0; > + unsigned long avail, nr_pages, min_pages, max_pages; > > /* The ordering of operands is to work around a clang5 issue. */ > if ( CONFIG_DOM0_MEM[0] && !dom0_mem_set ) > parse_dom0_mem(CONFIG_DOM0_MEM); > > - for_each_node_mask ( node, dom0_nodes ) > - avail += avail_domheap_pages_region(node, 0, 0) + > - initial_images_nrpages(node); > - > - /* Reserve memory for further dom0 vcpu-struct allocations... */ > - avail -= (d->max_vcpus - 1UL) > - << get_order_from_bytes(sizeof(struct vcpu)); > - /* ...and compat_l4's, if needed. */ > - if ( is_pv_32bit_domain(d) ) > - avail -= d->max_vcpus - 1; > - > - /* Reserve memory for iommu_dom0_init() (rough estimate). */ > - if ( is_iommu_enabled(d) && !iommu_hwdom_passthrough ) > - { > - unsigned int s; > - > - for ( s = 9; s < BITS_PER_LONG; s += 9 ) > - iommu_pages += max_pdx >> s; > - > - avail -= iommu_pages; > - } > + avail = dom_avail_nr_pages(bd, dom0_nodes); > > - if ( paging_mode_enabled(d) || opt_dom0_shadow || opt_pv_l1tf_hwdom ) > + /* command line overrides configuration */ > + if ( dom0_mem_set ) Nit: Stray double blanks. > { > - unsigned long cpu_pages; > - > - nr_pages = get_memsize(&dom0_size, avail) ?: default_nr_pages(avail); > - > - /* > - * Clamp according to min/max limits and available memory > - * (preliminary). > - */ > - nr_pages = max(nr_pages, get_memsize(&dom0_min_size, avail)); > - nr_pages = min(nr_pages, get_memsize(&dom0_max_size, avail)); > - nr_pages = min(nr_pages, avail); > - > - cpu_pages = dom0_paging_pages(d, nr_pages); > - > - if ( !iommu_use_hap_pt(d) ) > - avail -= cpu_pages; > - else if ( cpu_pages > iommu_pages ) > - avail -= cpu_pages - iommu_pages; I can't see any of this represented in the new code. Have you gone through the history of this code, to understand why things are the way they are, and hence what (corner) cases need to remain behaviorally unchanged? > @@ -40,6 +42,106 @@ struct vcpu *__init alloc_dom_vcpu0(struct boot_domain *bd) > } > > > +unsigned long __init dom_avail_nr_pages( > + struct boot_domain *bd, nodemask_t nodes) > +{ > + unsigned long avail = 0, iommu_pages = 0; > + bool is_ctldom = false, is_hwdom = false; > + unsigned long nr_pages = bd->meminfo.mem_size.nr_pages; > + nodeid_t node; > + > + if ( builder_is_ctldom(bd) ) > + is_ctldom = true; > + if ( builder_is_hwdom(bd) ) > + is_hwdom = true; > + > + for_each_node_mask ( node, nodes ) > + avail += avail_domheap_pages_region(node, 0, 0) + > + initial_images_nrpages(node); I don't think this is suitable for other than Dom0, so I question the splitting out and generalizing of this logic. For "ordinary" domains their memory size should be well-defined rather than inferred from host capacity. Starting from host capacity also means you become ordering dependent when it comes to creating (not starting) all the domains: Which one is to come first? And even with this limited to just Dom0 - is its size calculated before or after all the other domains were created? > + /* Reserve memory for further dom0 vcpu-struct allocations... */ dom0? > + avail -= (bd->domain->max_vcpus - 1UL) > + << get_order_from_bytes(sizeof(struct vcpu)); > + /* ...and compat_l4's, if needed. */ > + if ( is_pv_32bit_domain(bd->domain) ) > + avail -= bd->domain->max_vcpus - 1; > + > + /* Reserve memory for iommu_dom0_init() (rough estimate). */ > + if ( is_hwdom && is_iommu_enabled(bd->domain) && !iommu_hwdom_passthrough ) Again the question why this would be Dom0-only. > + { > + unsigned int s; > + > + for ( s = 9; s < BITS_PER_LONG; s += 9 ) > + iommu_pages += max_pdx >> s; > + > + avail -= iommu_pages; > + } > + > + if ( paging_mode_enabled(bd->domain) || > + (is_ctldom && opt_dom0_shadow) || > + (is_hwdom && opt_pv_l1tf_hwdom) ) An interesting combination of conditions. It (again) looks to me as if it first needs properly separating Dom0 from hwdom, in an abstract sense. > + { > + unsigned long cpu_pages = dom0_paging_pages(bd->domain, nr_pages); > + > + if ( !iommu_use_hap_pt(bd->domain) ) > + avail -= cpu_pages; > + else if ( cpu_pages > iommu_pages ) > + avail -= cpu_pages - iommu_pages; > + } > + > + return avail; > +} > + > +unsigned long __init dom_compute_nr_pages( > + struct boot_domain *bd, struct elf_dom_parms *parms, > + unsigned long initrd_len) > +{ > + unsigned long avail, nr_pages = bd->meminfo.mem_size.nr_pages; > + > + if ( builder_is_initdom(bd) ) > + return dom0_compute_nr_pages(bd, parms, initrd_len); > + > + avail = dom_avail_nr_pages(bd, node_online_map); > + > + if ( is_pv_domain(bd->domain) && (parms->p2m_base == UNSET_ADDR) ) > + { > + /* > + * Legacy Linux kernels (i.e. such without a XEN_ELFNOTE_INIT_P2M > + * note) require that there is enough virtual space beyond the initial > + * allocation to set up their initial page tables. This space is > + * roughly the same size as the p2m table, so make sure the initial > + * allocation doesn't consume more than about half the space that's > + * available between params.virt_base and the address space end. > + */ This duplicates an existing comment (and hence below likely also existing code) rather than replacing / moving the original. As in an earlier case - how are the two going to remain in sync? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 13:27:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 13:27:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376208.608823 (Exim 4.92) (envelope-from ) id 1oGh4T-0007DW-KQ; Wed, 27 Jul 2022 13:27:29 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376208.608823; Wed, 27 Jul 2022 13:27:29 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGh4T-0007DP-Hi; Wed, 27 Jul 2022 13:27:29 +0000 Received: by outflank-mailman (input) for mailman id 376208; Wed, 27 Jul 2022 13:27:28 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGh4S-0007DJ-7W for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 13:27:28 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20069.outbound.protection.outlook.com [40.107.2.69]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dab3ea89-0daf-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 15:27:26 +0200 (CEST) Received: from DU2PR04CA0305.eurprd04.prod.outlook.com (2603:10a6:10:2b5::10) by DB6PR0801MB2021.eurprd08.prod.outlook.com (2603:10a6:4:79::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Wed, 27 Jul 2022 13:27:20 +0000 Received: from DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::2c) by DU2PR04CA0305.outlook.office365.com (2603:10a6:10:2b5::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Wed, 27 Jul 2022 13:27:20 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT035.mail.protection.outlook.com (100.127.142.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Wed, 27 Jul 2022 13:27:20 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Wed, 27 Jul 2022 13:27:20 +0000 Received: from f102c05ecde9.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5F44A81B-B2DE-4460-8E59-53B837A6B3C0.1; Wed, 27 Jul 2022 13:27:09 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id f102c05ecde9.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 27 Jul 2022 13:27:09 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by GV1PR08MB7939.eurprd08.prod.outlook.com (2603:10a6:150:8c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Wed, 27 Jul 2022 13:27:06 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::5cc5:d9b5:e3b0:c8d7%9]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 13:27:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dab3ea89-0daf-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=mwX98lu9kWL881FrwAkDccxy90awztPBihVj9reTFtHTZUHHC3GhQmLUdwKhoQfykjoV2pFp91LXI0sS+vjSd3vrBlcQKpUS/hs8TvR1U10BJt1nxu3dMbB0bELYBoGvShfLBDyO24+gyeOAB3Kw1V+ERrkzXKXQrPKYrXyY7ghZl7xnR3JT5r1GeDd6Qhkr0Tqmfh4ijfdwt+6unV9BrhKAw7kwdeL+E2QDrDDBSz4uC82vlc6o8D/ygkhj5axEX9S+fxtEcFFF1PzQ3WWbSlswbJqm+4HfOFdqKHIttisogMP9DQw8t+KV1vkdN6avpKzXoS9Tc61b6nVF9cVVMg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kow4sXle+3sWRlyVMFxh1A0emb2wKI58TcxvzhzMUGc=; b=kdyJXa67MwiUZk/7b0x+STMMZla3ZCU6ujqnd2Fci+bIcyEo0Hmq7DJUpUZTif7nJdt31ckQ1ju1egpY+tLq6j+8mJYZx1MtnHPyCpfeMqlWYY/nGoZrr5qEiGXN19+ak2/j403cPnh1RRmfU20s/qBiI2MvA4/sQwCSvRCEZBRWLLnNE8h10ibBoDGurCREczI92NhOdkRTsfN2g/EkODMDMnniRydkQSOtYDHblujFt1jQCrWPRIoxgmhANmz4nN8x4KqWIugigpUD+lxZQtCFU6mvd1p9xSfzMcGaFRRjqYQcPBpyAUhl93ZwdCJgSS3Hm8vaAHT03CUtTO6lKg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kow4sXle+3sWRlyVMFxh1A0emb2wKI58TcxvzhzMUGc=; b=583jnbcPwecj4+9ZZKiIHZ9HrnUl2qhqABjB065fl2VE4U0N7VbyTNNn2rCDlHk7+5LJ0Rx9fqSPdgiaAlwRfExEEtUFaAlKa7Cjii4IZShuMXV+wBiNcotjRJCruOTYx9pKSyyhHbDJm4/D0gVZypa9xo2ZgKHXUrTnN/wQt34= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 7aebe9e4f5ac8c6a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O88rgpIeDcS3RoqCQ3krTf9L96pp2tViGrEWqvusjnIDdsovTLlYIlHlaEThA2ZWxB6I9jqRGEl5PqMUgXEUCRcIxZ2dXNK1omjYnqNXG+cYDgqlYIb/EPztzeyo6lTZ3eEWPi1RM5KzgO5pzxL5fbyoXNTToHwzF7Wzv6CQOuuXs+b5Gf4OJ9qhCcZ56uGXw8vBiTCA6Avw3tF0ZNESPWr+PxxjFafdcMp5U2RkGu05SPIZNVl6p8E0mTCVyvkxQmjAePg9IQ4fROSgtZci1E2NqI7dqc0BzLO5hf1uBsNO8JYKaoAJ+AcaenXtZ5TdNjq4NYD6ZAJYe0HA4wRZpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kow4sXle+3sWRlyVMFxh1A0emb2wKI58TcxvzhzMUGc=; b=UmXs7Bnmdv0Wi+8Ibr0rt66kU6hGCmzWko31vTko2uD6QY76Hw7+01EQ7vWjw+h1lCG1kdTEwlH6wd+Sd5gyMh5+Xr9KMBo0bQd9I6ucwKVgUi/i45io+SXiL0ERjBtwcEA4w1MYlSFsKyhf2QL2soQRIUMrdCoigDBsfPcZA968zW6CRWO9nGCMGRnzv2NBATp5lyxemVxCgaeDqW5/H397uZe8IV3ctVBvrnvsfQI4EOVYmNg9iOOycsjqrUky7EQ3pn/s8PlmLYnlwb+mmXA4GIdkbPLNAFAQyvhiZY0ZbKI9bc7Z1Wzd5GHLOR6eaR8QyrO8e24tNIa/B04XzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kow4sXle+3sWRlyVMFxh1A0emb2wKI58TcxvzhzMUGc=; b=583jnbcPwecj4+9ZZKiIHZ9HrnUl2qhqABjB065fl2VE4U0N7VbyTNNn2rCDlHk7+5LJ0Rx9fqSPdgiaAlwRfExEEtUFaAlKa7Cjii4IZShuMXV+wBiNcotjRJCruOTYx9pKSyyhHbDJm4/D0gVZypa9xo2ZgKHXUrTnN/wQt34= From: Rahul Singh To: Julien Grall CC: Mykyta Poturai , Bertrand Marquis , "Volodymyr_Babchuk@epam.com" , "sstabellini@kernel.org" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device Thread-Topic: [PATCH] xen/arm: smmuv1: remove iommu group when deassign a device Thread-Index: AQHYWlIekEFYa4Z+ZkOKg6prrRxnv60EB7eAgALvxoCABl1EgIBEoW2AgAA0fACAAZfdAIAEm8YAgAGSSQCAAEbogIALO3kAgCQMb4CAB/g1AIABTOIA Date: Wed, 27 Jul 2022 13:27:06 +0000 Message-ID: <0959FB77-458C-419C-BFE8-A2474517DBC3@arm.com> References: <0A58139F-CA6F-4E18-B44A-2066AEF0C8F6@arm.com> <20220628172338.1637121-1-mykyta_poturai@epam.com> <69C0FF69-98E3-440B-9CE7-3025EE5E0E4C@arm.com> <53703921-12a2-90cc-55bd-94a4d86a5d70@xen.org> In-Reply-To: <53703921-12a2-90cc-55bd-94a4d86a5d70@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 367f8cd2-40d0-4698-75fc-08da6fd3bbb3 x-ms-traffictypediagnostic: GV1PR08MB7939:EE_|DBAEUR03FT035:EE_|DB6PR0801MB2021:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: R7o0hrNhM00rYLod0YjMisHPx+g9dbAFxNx5JZVYS9XCob7u9Rif9EAO0oNwfrtGZU1MPpMV1p/TlO5RO0lMrU2p9XGt0jIDMqNR8bdH6FQ04Hw0lfLlcKVTKSsXSwtlwpOfiy+Z0b0LrDAiEwXB2x9QixESsgqNBtHwMKMDqvSloZOGgkK/T5lholVXDfLDVwnr1oZs+pLXNQdEIE1Ham3tjUh8NbEErVgCDAiWYBzDRgDfgHSlcLe13cH/T6niElbn55WOOQ5pQtqWW6n3DbWUgdwOy4GDBYhBgqjIyXuvTcRHB/lQK1J/rxeWzzTgXXtC6ci93u3Mj0UQse43DDIR1rgeBoixtoteRmZMeLhCe4qomIkNNyY2cfnxeSlxhAF5mm9NyNhkayMY/q/m+bx7xXyhCYiRx2IK25JTzo23Ql2hgDvQxcWkb82EnzILctxC/DmfUwYn8Hf0XavcjK7bhsJ4Z+Y7+JL6Ol7NiApbJlpklOcoY45XOgapXRAyX1KimqGCqpbazfjNBYlj50fcfavF41gRkQb5zwtnwT9xumjGp5hRi/5lKZ+KCuXTjzsXCkH2aYre2pK2ypP22UqetGlCUFEhkfqXHDCmp5MEXHFtA8be8fHnEhs6swtQGC643WSjjG9v46158D+l2U/TIBXwbiSCboVdhfsiU1oqVmHnGoOIPMe4gDM5cl/dpA9VnPLy6AmF+zaHSQKhtL+LQs6mWKmjld7IOPkydxPXLcgx4uF8HkccwMaeD9FCmhQPvUFoLXibQv5HTXyKbh1BJIKVZneTxcjI0M4BUf9YFaDl9bmayjqviPwsqyKu5LTPEnBtMjVXwq4q2MiXPQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(396003)(376002)(346002)(366004)(39860400002)(41300700001)(38100700002)(2616005)(8936002)(53546011)(26005)(6512007)(36756003)(6506007)(186003)(4744005)(2906002)(5660300002)(6486002)(316002)(478600001)(6916009)(83380400001)(64756008)(33656002)(66446008)(66556008)(66946007)(8676002)(76116006)(71200400001)(91956017)(66476007)(86362001)(38070700005)(54906003)(122000001)(4326008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR08MB7939 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 0f873c90-88c5-484d-afc2-08da6fd3b38a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2emc+nGhtWBgdOhmXc9lckuIwDu632wjWZXXsJCumnG5kfuvGL7zWErwXTfiIi9BLXRqMi++OxPsj0fYvvWuThJ7nG8ynbydX20rZpuFAq2hDObtE4jPkIrQS9DeHRCDisBo/QeGizydTwZ6SONK/lvcHBlQydai8HU9za+qQLajVbcxkBj4qfVW59lM+11dNs6kLbtMwlM6MjWZ09ISym/DH0T4mPklE6ZwXF9+15dGT51jsuopV1nsTVnMjy+EGczMtMZZt+YafN3hvKUBPzP3792jl3bmBe2KOBUU84MUv08k30tNzfYRMspf/ryHY2zqeXnm6x7g8kix0dXZUVzkjsi9A7GAFXzIpLjgtQC4IazRGjL7govyUuu4ZICsJAxGJcVNVAh7rw7tAsBuKEFVWZDbTDOxo7GMSULPtnSIbDQ+kufPEq+aelK644jq+Zvi3tI63zxy1D7rLHHxH59Es+vh8XY52Nyx0SYW8llyHaDzUwm10D7HB2dEotz1wmfSkcOW9fhwh8p6uHEBQaxAjTWDXNHXPsrDqPQ0vWtkj/TtTDapwTtfpdb0NoZjTICOxKpGiYg2/nsJnmk0/sSyyaMHzX2UKkJW30InEzc9tM++e8/yth+LmoXPgh6ZI56nXt5UyLjriZVjSXVJ3xfCTWeSGyrGH3Tr5PrLLn3LinEpjGE1Z96N2ZxV1iA9ai4ZGhF1cVqxjKfiopbakxbPmc5UKlwkA7G6kIN7yLFZsSl24XepryJIYgZgp0+NziHZ8qz1viYz0PbjibnIyvx+LAh0s7CAc+CUikDCO4hZkRCNWCUyTz4gnTR8h/hG X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(376002)(396003)(136003)(40470700004)(46966006)(36840700001)(54906003)(6512007)(33656002)(26005)(6506007)(6486002)(82740400003)(70586007)(4326008)(336012)(8676002)(40460700003)(86362001)(36860700001)(186003)(81166007)(47076005)(316002)(83380400001)(40480700001)(53546011)(36756003)(2616005)(70206006)(356005)(82310400005)(8936002)(2906002)(478600001)(41300700001)(6862004)(5660300002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 13:27:20.4229 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 367f8cd2-40d0-4698-75fc-08da6fd3bbb3 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT035.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2021 Hi Julien, > On 26 Jul 2022, at 6:35 pm, Julien Grall wrote: >=20 > Hi, >=20 > On 21/07/2022 16:53, Rahul Singh wrote: >>> On 28 Jun 2022, at 6:23 pm, Mykyta Poturai w= rote: >>> With this patch I get the same results, here is the error message: >>>=20 >>> (XEN) smmu: /iommu@51400000: Unexpected global fault, this could be ser= ious >>> (XEN) smmu: /iommu@51400000: GFSR 0x00000001, GFSYNR0 0x00000004, GF= SYNR1 0x00001055, GFSYNR2 0x00000000 >>>=20 >> As you mentioned earlier, this fault is observed because GPU continues t= o access memory when the context is >> already invalidated, and therefore triggers the "Invalid context fault".= This is a different issue and is not related to this patch. >> @Julien are you okay if I will send the below patch for official review = as this issue pending for a long time? >=20 > I am OK in principle. I will do a proper review on you send a formal patc= h. Thanks for the confirmation. I will send the formal patch for review. Regards. Rahul From xen-devel-bounces@lists.xenproject.org Wed Jul 27 14:02:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 14:02:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376215.608834 (Exim 4.92) (envelope-from ) id 1oGhbw-0003SZ-HO; Wed, 27 Jul 2022 14:02:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376215.608834; Wed, 27 Jul 2022 14:02:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGhbw-0003SS-Dx; Wed, 27 Jul 2022 14:02:04 +0000 Received: by outflank-mailman (input) for mailman id 376215; Wed, 27 Jul 2022 14:02:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGhbu-0003SM-OD for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 14:02:02 +0000 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [2a00:1450:4864:20::22b]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id afd69d98-0db4-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 16:02:01 +0200 (CEST) Received: by mail-lj1-x22b.google.com with SMTP id v21so1333650ljh.3 for ; Wed, 27 Jul 2022 07:02:01 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id bj24-20020a2eaa98000000b0025df34d252dsm2993086ljb.123.2022.07.27.07.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 07:02:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: afd69d98-0db4-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=liOPwzxukm0VKCZGkJLonni9TQL8JmSo9qll0CJUb+8=; b=p35FIcnGqxPwZsXdKDr9NDS1Np5wAZFbpOAUPnDc5sfas6Fi+q5LhtIVqeSJQuikL/ hR8E2HsOuKqreNgHAbvbI/vTLQOmGfpaOqrEW/T/g0q86JBIcSLxiz/9sh4jcJWI7qoe 4eJFB77T2E+XhVuoAHimmCqcXHJBGjAc8sToJWKev6XBNxczQ2FVvPGrAANH+Jbel/Yi oTYtt54HTzSx9q3Jq3fzv3KEm84Gf9QzM9bWIKb9uNUeTb7fltakYW10/OMPBrp3aMTQ oM1m78eGo4iopo+4YUG4ZUni5XWwEYDCOai5jkK/lv3u7AwIOPd3g1jbZVj/g48GBcQZ V/yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=liOPwzxukm0VKCZGkJLonni9TQL8JmSo9qll0CJUb+8=; b=3RBUG7+BQR753IlotR5JvO9UcXziQlBHR/A8IZkpqRc8pbIxAmQPo4yJZU7KgXqgPR Y4PAt6vUcAbCEQ1aGbxGHx00ryNNBpVCv385rUXfXRUbaQOJGMX82c9uskTSZin+uvpQ ME8QcMShE5SPMbXwC9pnHAkznMPxWW0Dt6KWk9NXCCuDg4XWOV8mQDv6NV6CfexBy817 dI+TxEdrumCSEzahDYUb4sFdFfyehvXkZCiwinwJKycpYnrb0yHR13UFRdtSeg1e8YV7 /gn5OQXkqH9GfJ5c0Q0zlSZAJK8Lj6VYoJ1iOgMYZr503g5y/rEzZ+6dg2DZGdhDU31x 5d8Q== X-Gm-Message-State: AJIora9wnkzhgk8W5CcDVED4wkjctfsJaEQbfkCFHSjztwL7FDIdcMde i4rbARWPkpzwXo1pQxmtfr0= X-Google-Smtp-Source: AGRyM1tPTHXR/okcSrHREDkJEjpUSNHIdi9ugZNkYUyzvtw+lHjvg3FL8p0LcvFPeUFyI5I6E++W8A== X-Received: by 2002:a2e:a884:0:b0:25d:ea06:6a3f with SMTP id m4-20020a2ea884000000b0025dea066a3fmr7407187ljq.335.1658930520687; Wed, 27 Jul 2022 07:02:00 -0700 (PDT) Message-ID: <2e0efae5-27f7-831d-6f9e-06d03374b716@gmail.com> Date: Wed, 27 Jul 2022 17:01:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-3-olekstysh@gmail.com> <51afa25b-93ea-2685-b238-2edd9292bece@suse.com> From: Oleksandr In-Reply-To: <51afa25b-93ea-2685-b238-2edd9292bece@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.07.22 13:03, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> @@ -1558,6 +1560,7 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >> { >> const struct domain_iommu *hd = dom_iommu(d); >> struct pci_dev *pdev; >> + uint8_t old_devfn; > Why "old"? There's nothing "new" here. Perhaps "orig", considering ... ok > >> @@ -1594,6 +1599,8 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >> pci_to_dev(pdev), flag)) ) >> goto done; >> >> + old_devfn = devfn; >> + >> for ( ; pdev->phantom_stride; rc = 0 ) >> { >> devfn += pdev->phantom_stride; > ... this updating of devfn is what you mean to deal with? As I understand that was the intention of the author. At least I don't see other reasons. > Then again > I see no need for a separate variable in the first place. The input > (seg,bus,devfn) tuple is translated to a pdev, so you can simply ... > >> @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >> pci_to_dev(pdev), flag); >> } >> >> + rc = vpci_assign_device(pdev); >> + if ( rc && deassign_device(d, seg, bus, old_devfn) ) > ... use pdev->devfn here. Thanks, good point, will drop old_devfn and use pdev->devfn. I am wondering whether the printk after "done:" label (and other possible printk-s down the code) should really use pdev->devfn instead of devfn in PCI_SBDF construct? > >> + domain_crash(d); >> + >> done: >> if ( rc ) >> printk(XENLOG_G_WARNING "%pd: assign (%pp) failed (%d)\n", > This log message will want to appear _before_ the domain_crash() > related output, or you will want to add another log message there. I will probably add another log message before domain_crash() leaving this one as is. printk(XENLOG_ERR "%pd: %pp was left partially assigned\n", d, &PCI_SBDF(seg, bus, devfn)); > >> --- a/xen/drivers/vpci/vpci.c >> +++ b/xen/drivers/vpci/vpci.c >> @@ -92,6 +92,37 @@ int vpci_add_handlers(struct pci_dev *pdev) >> >> return rc; >> } >> + >> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT >> +/* Notify vPCI that device is assigned to guest. */ >> +int vpci_assign_device(struct pci_dev *pdev) >> +{ >> + int rc; >> + >> + ASSERT(pcidevs_write_locked()); >> + >> + if ( !has_vpci(pdev->domain) ) >> + return 0; >> + >> + rc = vpci_add_handlers(pdev); >> + if ( rc ) >> + vpci_deassign_device(pdev); >> + >> + return rc; >> +} >> + >> +/* Notify vPCI that device is de-assigned from guest. */ >> +void vpci_deassign_device(struct pci_dev *pdev) >> +{ >> + ASSERT(pcidevs_write_locked()); >> + >> + if ( !has_vpci(pdev->domain) ) >> + return; > There's no need for this check since ... > >> + vpci_remove_device(pdev); > ... this function already has it. At which point the question is why > a separate function needs to exist in the first place. To match with > vpci_assign_device(), a simple #define to alias is would be enough. > (This is one of the cases where personally I think a #define is > superior to an inline wrapper.) Agree, but ... > > Unless, of course, later patches extend this function. If so, the > commit message giving this as justification for the introduction of > (apparent) redundancy would be helpful. ... exactly, the later patches extend this function. I will update commit description. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 14:12:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 14:12:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376221.608845 (Exim 4.92) (envelope-from ) id 1oGhly-00054Q-HS; Wed, 27 Jul 2022 14:12:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376221.608845; Wed, 27 Jul 2022 14:12:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGhly-00054J-EW; Wed, 27 Jul 2022 14:12:26 +0000 Received: by outflank-mailman (input) for mailman id 376221; Wed, 27 Jul 2022 14:12:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGhlx-00054D-DK for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 14:12:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2085.outbound.protection.outlook.com [40.107.21.85]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 225fd994-0db6-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 16:12:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4549.eurprd04.prod.outlook.com (2603:10a6:20b:24::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.24; Wed, 27 Jul 2022 14:12:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 14:12:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 225fd994-0db6-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6V/fX36IfJplI2VsqcXuRzxtHsdq+7IWRv9KB6egR2ZZk51kN0/dqvX+IgQEn6PIt9Vbf8Jcvmn6D43Idx4EHebczeV1qbjlkkD/F9ywWBtZqXxARNYGw3dqh3KwMTRc7LQRXp9DgvMAUQ2XLPyJpIdbfSBRic3Og1vIKcUHhS0lmKDoG/MbEvKy5qZeXG4/Hygslf22tGK6/r73esv9W+c0jnnDhfu1KwexhMfGCzH6q6idCMrQktAlEHqZ+rQWHWj+0GsDRhpkzeUEl6YSFI+1q/f/8BEap44oGnIhd/MYWFxjVK3ixnzFrC4/URrpT2sj0izmTJtTPFlfunvzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jLap+y/wGPsGo3VqfNP/zcxddxSLtPmyoTigp2bz2ug=; b=GMZbs8RVoTkRKgC9xbZImcdzSeu90/xigJ2ME8QJrAEon9cL23SfVwUbMTLOZHlekbwDPmAIf5MX10ApmAPv3KxpKlc6Ur/oKKWGOYOnoto9rjwU3SIi4aejOIXHSnke2T7XKXVFZzlv+MBAwRAP6hMII1ZniBDIIVyY6id79SvzukpPCNOdFcej5OOf8imZ+xmZOgwRABkNrajnbZjB13rnBzfJK/CNZ9Z/euYm/x1Gsdx/kHu8AvV9lD+QCfaNwkKdDjt9zfPvOdO4qsJe/xwRE8F/8oVtpgxbvPRlCqC5a8+Hdo5bmNnFusB0rU+QFWwm81sN2EkQfqPhvq8X0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jLap+y/wGPsGo3VqfNP/zcxddxSLtPmyoTigp2bz2ug=; b=NidpBPyaRZS4w05ZOMcXLqo1MHEbytDVLeBhGqppPdzbBDbUfl50W5FFo8+jm+bGRaI8eEnpl5Gk6QColjZcr2yMTuC3Flzg3RwK/uzGbK5UUINZhiOhPzzGKf4jf5vGULOD6S3Fo3th+nxo3AP13EVbx9LgQj4+CHqbkea3YCVIeyzkvkpknGY41IMvooPan6zqTMuBtxleOYDE7C71EoWT4fkd/pjDHXy0PnLYa9OXk1CxThgRLSGriVpgMV7N8h2MKl8PvDP1egCRLH48fqFOu5mAImnh2+wnY9/7SzX7yNtWC6C12h1yezGOlEYL2wa3fiJFQcJJojvO2xVgzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <3d35ac8a-51b7-5b78-4d5b-9ee4c06e71d8@suse.com> Date: Wed, 27 Jul 2022 16:12:17 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 16/18] x86: add pv multidomain construction Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , George Dunlap , Julien Grall , Stefano Stabellini , xen-devel@lists.xenproject.org, Wei Liu References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-17-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-17-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0170.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a0::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b3906429-9aef-474b-ea66-08da6fda0487 X-MS-TrafficTypeDiagnostic: AM6PR04MB4549:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZlTtVcrFxKZ3/vlE/7e5sJsIP03LXlTKcqKn9gzocSJmxQoMk3DDcErQWsYwkNcjqC7qJt0JERQER2jREUQAxa50/y7YGK1W3nm6SZLjBwSXYeUhe3GBt+GgLBzKs+8Vu6Z6TsRiSaJrisroqzi4bRFQR42ZBVjVUXYTPx2s543sysW3dGQDFLD10uFK4mBpVmVaOHuFEtQt0OZYf15R95QXse3u+p6hzxJuCTQgZfIDtteAS+yPnM4jaWx1inlyaMnV9+3F39JWxnnenM4IVT6Ffb9cHu+Zu+ST20G6TdlHz7qLiy/iwcRl3hP3udIVW+vZY6lOal6F+qQv8hdnp7nQlKpFD1HHuBGndFPRBUz90JJ8jbkbM3rVO0pDKzDMqNxtIeyAaDSJbNr5llj2jJCUgl11WG12i5Fwb+CZfaH3G2T6ewjm8wYFPqyHveXOLnwW4/R2yOC1le+LOt9+At+dWAQKjcM6SiwiY0IRSWfYGnpJjDFzBq3KJIbH32zpnDyrl2A9xvhAovEQ7mfTeJ3/FZPl9HEo59Zg6/Tfp3TzCtyF44jrbzQ5SrREA7OBVxSjaHSoUyC2nCcyLeFwzaQpeZIPk5TNrGs5RizMFC5zDMC5UDWeQmKeqTwiQxLdFS0B/8GRio7pLHT8Mbp5LUz5lzQ889eBHl6yoluXC0wQHRiTluSvQwxE9sYP2/kmpfUTGraHjERIAqKFb6jLZ9r0cdE1Maav5zgrL1fQkcDXzisWw2GNryYSohCABjSOof4yAp4GS1l1WBmVORpx9y+Dw7gIQS+5SzQGE6j5W6hg/R6NmTyeChsFsY8bGR7lb+GYV/jyQXoMhiwR3ZPffg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(136003)(376002)(346002)(396003)(39860400002)(6916009)(66946007)(6506007)(30864003)(6512007)(86362001)(6486002)(8936002)(31696002)(83380400001)(478600001)(5660300002)(41300700001)(8676002)(7416002)(53546011)(31686004)(66476007)(26005)(4326008)(38100700002)(186003)(316002)(2906002)(2616005)(54906003)(66556008)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VUMyNE55eHNQR0lrTVpLZ291VzJtUWJMd0ZsSklBa0FQSDl1aHExOGhITXZB?= =?utf-8?B?aS9vTEFJUXIyYUphVWQxdkhIOGdVYmF0ZkdSaS9WeFQyVnlwSGFiR2VDTnFT?= =?utf-8?B?eXUvQUdYWUVxM0t2b2NaZzc1RmN2Vzg4ODBsQkxQNDZ6aDJOZzEvRTZzQmpE?= =?utf-8?B?OXJpNDcvdGdvZ255R2xIK0dVc2dOaWtZS2J2R29mTnJuN1lZdFZuWUFOQ1dq?= =?utf-8?B?NHJ2TWdkWmJiUDdtL0tJd3JvQTJUZW9YdE8wTlBhNnIrSU96eFl0amFoK2Fi?= =?utf-8?B?c3VuSklBVFN2eUlxeUIvcDRlZTM0bHlDbzh3cE1EY204RGFwYVkxTTVoQ3RK?= =?utf-8?B?Q0ZXOVlKSmpkdG9xOUtac1Mwdm41K1hXZXpjN1dZMFpuWVNjdDRDSm1aQ1hD?= =?utf-8?B?bkFjUm5lQThobEdLSW1xV0lMRHA4bnhObkF4bnFYWktRMmhmcDVVcEtaSU5S?= =?utf-8?B?V0dieitDRnJNNmU2U0VhNElXY1JQVUJzRUJxcG1ubEF4bTNEMzhKeWJtb3NW?= =?utf-8?B?ZjhwNzBPc1JsZG13T1pyQkFxbzd1VjVaZnIrZllOVFh0N0kzWGpObHFtS3cv?= =?utf-8?B?QlBkU1QyNXREeXViRzE2YWdGS1JjQU1UOWZ5cEFORVZCWjN0K2ZwUnNxTmk1?= =?utf-8?B?UzQ4TzJJRGFtV0MvSmI2YlRyaGZ3ZkVTeW95amRRQUl6MEk4dDRxblZDY3hw?= =?utf-8?B?S3FYNmViYzQ4NEdkWmhuZ09JdCtyRHVmNWxVbDI1ZkRUeFRIR1ppcTlzQ2NM?= =?utf-8?B?RmhSdU11Z1pWMUNmSkcxSHNLaEFaUC8xcndLWmlRRFBxbUNSUmRITElHaTVD?= =?utf-8?B?UncwSmE2YkhpTy9UMHl5bnVYSjhJWTZSbnZvUkNOcDFQVm1rSVowUnRnODFu?= =?utf-8?B?MTJaeUVqVDhuT0FhYXNkdVczU1AxN3lCMEV1RkVYUjZtYjdMNGZCYS8xTDRP?= =?utf-8?B?cUNFcURTUnJoVk1DZjd0dGJDRmFKL0MyOTZ5a3UzeWdHR0p5bytFcDJRTm9J?= =?utf-8?B?S2Yxd2hDRmxBUXJjOCtkSGs3SjJXeVE0SWlhb2hHVFJnM3BNVFE2T05nd0Nk?= =?utf-8?B?VlBPUFg3QTdRUU9lWUY1ZEpJaHNiaCtXbnM5Vks5Y1lrVkVxZThkMXVqOGhJ?= =?utf-8?B?TW5LMWxmY3lpUTJUMS85OE1BM09wdGUrYWJGenVxVUIyZ2hYYVBsdE9pYXBX?= =?utf-8?B?YldwTjVkbHlUeFJkUThqVWl0cU1WTjdnUGZQOVBFNk5KWFBkQVBJd0R5dURC?= =?utf-8?B?Z3hWc2pZMTR3ZTRHVHV6enRQSW1Nc3lKaFV0QmNSVTBqQ0l6dUh0Wm5SekdD?= =?utf-8?B?U1NyQnhwQ29HSVozQ1lhbjBLL2ZoRnp3Rkc5QkZzRDlaNXc2Tm9kTkNpYTdL?= =?utf-8?B?TGdDbTlQcGxYLzNTN3RjTUNNbGhPOG5LOThrMllUM1VSSUJrSDdpRzcvdzVj?= =?utf-8?B?YnpZc0ZMbFc2NzF3QUo5TEJZL3pvbTNMRmJxMmJ6SHhQaERlWU9YdEsrQUZ5?= =?utf-8?B?TG1kRys3R1ZlelZLdHFnaEdDYnlVZjZFNng3Nk02dG9mcDd0eGhVUVI1bm9V?= =?utf-8?B?L2JaZFlDZ3lUbERzTzFsNHlZMEprRWdmUDdsTmcxc0VaTGtueTg2cWJTUTI5?= =?utf-8?B?dCtVc0ZsY0MyR3QwM0dXNjBPaWh6MjVCNEdMVnN4UWRpVHQyaFIyc3FPV2I1?= =?utf-8?B?Vmt3c2laTnVpTEFwM01lMGFzVHY0L0pkdDAxMERpSkZoMkVRREpBcUNqQzZl?= =?utf-8?B?aGtpL2FQZ3dSWUt5SlZjY0k1aTRmR0JlNXozWGRWajFNMDA1TXZXTWhsUjFK?= =?utf-8?B?WStIWFJ2c0F1WDhuVDJLVFBmZ1F3ajlBZ3FjUHpQVnZCMWVlbWtaUFhVMHg1?= =?utf-8?B?T05VY3lzZG9MUFdYdk9zQXVFR0tJazQwMHJhKzQwN2xLelRWVUlQUmk5WEVB?= =?utf-8?B?ZU1MZUc4M1Jhd01qV1VVMmM3Y2V1dHorbk5yL1VHTWlPL25CdlNqcm5RN2xE?= =?utf-8?B?TmxKL3Y0U1dQc0F4dnBDT2lqN1pLTGppQmk1eWJ1TnB5MmpRbVgxRkQrb21Y?= =?utf-8?B?N1hNTkh5V2lSR3BpeGtCMFE3ZHpXeUNOMkZPOVlJUUU3dEN3YzZWaWVOUVIz?= =?utf-8?Q?W4k3a9eAp6ppBN+4Pn+5lhL0Y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3906429-9aef-474b-ea66-08da6fda0487 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 14:12:19.7322 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fvUQa8Av/Gj2qhMUKgVwhLOA3XUjaJRQRUteBpXDb1qL6f8uqrAzLk33lJPCtK/Gr2wSev+jQin/ywI1ps0tyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4549 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -524,37 +524,6 @@ int __init dom0_setup_permissions(struct domain *d) > > return rc; > } > - > -int __init construct_domain(struct boot_domain *bd) > -{ > - int rc = 0; > - > - /* Sanity! */ > - BUG_ON(!pv_shim && bd->domid != 0); > - BUG_ON(bd->domain->vcpu[0] == NULL); > - BUG_ON(bd->domain->vcpu[0]->is_initialised); > - > - process_pending_softirqs(); > - > - if ( builder_is_initdom(bd) ) > - { > - if ( is_hvm_domain(bd->domain) ) > - rc = dom0_construct_pvh(bd); > - else if ( is_pv_domain(bd->domain) ) > - rc = dom0_construct_pv(bd); > - else > - panic("Cannot construct Dom0. No guest interface available\n"); > - } > - > - if ( rc ) > - return rc; > - > - /* Sanity! */ > - BUG_ON(!bd->domain->vcpu[0]->is_initialised); > - > - return 0; > -} Iirc this function was introduced earlier in the series. Just for it to now be moved around? Why can't it be introduced in the intended source file right away? > @@ -189,18 +190,22 @@ void __init arch_create_dom( > if ( !pv_shim && builder_is_ctldom(bd) ) > is_privileged = CDF_privileged; > > - /* Create initial domain. Not d0 for pvshim. */ > - bd->domid = get_initial_domain_id(); > + /* Determine proper domain id. */ > + if ( builder_is_initdom(bd) ) > + bd->domid = get_initial_domain_id(); > + else > + bd->domid = bd->domid ? bd->domid : get_next_domid(); We prefer to omit the middle operand in such cases. Where to you guarantee no two domains would use the same domain ID? I can't help thinking that a predetermined one may have been assigned earlier on to a domain which got it from get_next_domid(). > bd->domain = domain_create(bd->domid, &dom_cfg, is_privileged); > if ( IS_ERR(bd->domain) ) > panic("Error creating d%u: %ld\n", bd->domid, PTR_ERR(bd->domain)); > > - init_dom0_cpuid_policy(bd->domain); > + if ( builder_is_initdom(bd) ) > + init_dom0_cpuid_policy(bd->domain); What about other than Dom0? > @@ -210,15 +215,23 @@ void __init arch_create_dom( > cmdline = arch_prepare_cmdline(cmdline, bi->arch); > strlcpy(dom_cmdline, cmdline, MAX_GUEST_CMDLINE); > > - if ( bi->arch->kextra ) > - /* kextra always includes exactly one leading space. */ > - strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); > + if ( builder_is_initdom(bd) ) > + { > + if ( bi->arch->kextra ) > + /* kextra always includes exactly one leading space. */ > + strlcat(dom_cmdline, bi->arch->kextra, MAX_GUEST_CMDLINE); > > - apply_xen_cmdline(dom_cmdline); > + apply_xen_cmdline(dom_cmdline); > + } Why is kextra applicable to Dom0 only? Shouldn't each domain have a way to append to its command line? > strlcpy(bd->kernel->string.bytes, dom_cmdline, MAX_GUEST_CMDLINE); > } > > + if ( alloc_system_evtchn(bi, bd) != 0 ) > + printk(XENLOG_WARNING "%s: " > + "unable set up system event channels for Dom%d\n", > + __func__, bd->domid); So if Dom0 is created after e.g. a separate xenstore domain, it'll also have a xenstore event channel assigned (changing behavior from what we have today)? > @@ -240,3 +253,32 @@ void __init arch_create_dom( > } > } > > +int __init construct_domain(struct boot_domain *bd) > +{ > + int rc = 0; > + > + /* Sanity! */ > + BUG_ON(bd->domid != bd->domain->domain_id); > + BUG_ON(bd->domain->vcpu[0] == NULL); > + BUG_ON(bd->domain->vcpu[0]->is_initialised); > + > + process_pending_softirqs(); > + > + if ( is_hvm_domain(bd->domain) ) > + if ( builder_is_initdom(bd) ) > + rc = dom0_construct_pvh(bd); > + else > + panic("Cannot construct HVM DomU. Not supported.\n"); > + else if ( is_pv_domain(bd->domain) ) Please properly use braces to enclose the inner if/else pair. > + rc = dom_construct_pv(bd); > + else > + panic("Cannot construct Dom0. No guest interface available\n"); Dom0? > --- a/xen/arch/x86/pv/dom0_build.c > +++ b/xen/arch/x86/pv/domain_builder.c > @@ -1,5 +1,5 @@ > /****************************************************************************** > - * pv/dom0_build.c > + * pv/domain_builder.c > * > * Copyright (c) 2002-2005, K A Fraser > */ > @@ -8,6 +8,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -296,7 +297,7 @@ static struct page_info * __init alloc_chunk(struct domain *d, > return page; > } > > -int __init dom0_construct_pv(struct boot_domain *bd) > +int __init dom_construct_pv(struct boot_domain *bd) > { > int i, rc, order, machine; > bool compatible, compat; > @@ -350,7 +351,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) > /* Machine address of next candidate page-table page. */ > paddr_t mpt_alloc; > > - printk(XENLOG_INFO "*** Building a PV Dom%d ***\n", d->domain_id); > + printk(XENLOG_INFO "*** Constructing a PV Dom%d ***\n", d->domain_id); When touching things like here and even more so when ... > @@ -384,7 +385,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) > { > if ( unlikely(rc = switch_compat(d)) ) > { > - printk("Dom0 failed to switch to compat: %d\n", rc); > + printk("Dom%d failed to switch to compat: %d\n", > + d->domain_id, rc); ... adding new logging of domain IDs, please use %pd whenever possible. > @@ -404,22 +406,23 @@ int __init dom0_construct_pv(struct boot_domain *bd) > if ( elf_msb(&elf) ) > compatible = false; > > - printk(" Dom0 kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", > - elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", > + printk(" Dom%d kernel: %s-bit%s, %s, paddr %#" PRIx64 " -> %#" PRIx64 "\n", > + d->domain_id, elf_64bit(&elf) ? "64" : elf_32bit(&elf) ? "32" : "??", > parms.pae ? ", PAE" : "", > elf_msb(&elf) ? "msb" : "lsb", > elf.pstart, elf.pend); > if ( elf.bsd_symtab_pstart ) > - printk(" Dom0 symbol map %#" PRIx64 " -> %#" PRIx64 "\n", > - elf.bsd_symtab_pstart, elf.bsd_symtab_pend); > + printk(" Dom%d symbol map %#" PRIx64 " -> %#" PRIx64 "\n", > + d->domain_id, elf.bsd_symtab_pstart, elf.bsd_symtab_pend); > > if ( !compatible ) > { > - printk("Mismatch between Xen and DOM0 kernel\n"); > + printk("Mismatch between Xen and DOM%d kernel\n", d->domain_id); > return -EINVAL; > } > > - if ( parms.elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type != XEN_ENT_NONE ) > + if ( builder_is_initdom(bd) && > + parms.elf_notes[XEN_ELFNOTE_SUPPORTED_FEATURES].type != XEN_ENT_NONE ) > { > if ( !pv_shim && !test_bit(XENFEAT_dom0, parms.f_supported) ) > { > @@ -443,7 +446,8 @@ int __init dom0_construct_pv(struct boot_domain *bd) > > if ( value > __HYPERVISOR_COMPAT_VIRT_START ) > { > - printk("Dom0 expects too high a hypervisor start address\n"); > + printk("Dom%d expects too high a hypervisor start address\n", > + d->domain_id); > return -ERANGE; > } > HYPERVISOR_COMPAT_VIRT_START(d) = > @@ -487,7 +491,7 @@ int __init dom0_construct_pv(struct boot_domain *bd) > vstartinfo_start = round_pgup(vphysmap_end); > vstartinfo_end = vstartinfo_start + sizeof(struct start_info); > > - if ( pv_shim ) > + if ( pv_shim || ! builder_is_initdom(bd) ) As elsewhere - stray blank after ! . Also wouldn't it make sense for builder_is_initdom() to return false in the pv_shim case, thus making the || here (and again below) unnecessary? > @@ -789,6 +790,19 @@ int __init dom0_construct_pv(struct boot_domain *bd) > snprintf(si->magic, sizeof(si->magic), "xen-3.0-x86_%d%s", > elf_64bit(&elf) ? 64 : 32, parms.pae ? "p" : ""); > > + if ( !builder_is_initdom(bd) ) > + { > + si->store_mfn = ((vxenstore_start - v_start) >> PAGE_SHIFT) > + + alloc_spfn; > + bd->store.mfn = si->store_mfn; > + si->store_evtchn = bd->store.evtchn; > + > + si->console.domU.mfn = ((vconsole_start - v_start) >> PAGE_SHIFT) > + + alloc_spfn; > + bd->console.mfn = si->console.domU.mfn; > + si->console.domU.evtchn = bd->console.evtchn; > + } While elsewhere you allow separate hwdom and ctrldom, aiui only one of the two would fail the entry condition to this if(). Which one would that be? And in how far are there kernels knowing how to deal with the situation? I'm not even certain this can be properly expressed in the present start_info structure, as a non-Dom0 control domain would e.g. need to have xenstore coordinates passed, but might act as the domain handling consoles. > @@ -871,23 +885,24 @@ int __init dom0_construct_pv(struct boot_domain *bd) > sizeof(si->cmd_line)); > > #ifdef CONFIG_VIDEO > - if ( !pv_shim && fill_console_start_info((void *)(si + 1)) ) > - { > - si->console.dom0.info_off = sizeof(struct start_info); > - si->console.dom0.info_size = sizeof(struct dom0_vga_console_info); > - } > + if ( builder_is_hwdom(bd) ) > + if ( !pv_shim && fill_console_start_info((void *)(si + 1)) ) As before - please combine such if()s. > + { > + si->console.dom0.info_off = sizeof(struct start_info); > + si->console.dom0.info_size = sizeof(struct dom0_vga_console_info); > + } I don't view it as a given that hwdom is the domain to have access to the physical VGA. While it may follow from its name, it may be more useful to have the control domain direct its output there. > #endif > > /* > * TODO: provide an empty stub for fill_console_start_info in the > * !CONFIG_VIDEO case so the logic here can be simplified. > */ > - if ( pv_shim ) > + if ( builder_is_hwdom(bd) && pv_shim ) > pv_shim_setup_dom(d, l4start, v_start, vxenstore_start, vconsole_start, > vphysmap_start, si); ??? > #ifdef CONFIG_COMPAT > - if ( compat ) > + if ( builder_is_hwdom(bd) && compat ) > xlat_start_info(si, pv_shim ? XLAT_start_info_console_domU > : XLAT_start_info_console_dom0); Even more so here: ??? (This is a clear sign that your commit messages are lacking helpful detail.) > @@ -926,15 +941,18 @@ int __init dom0_construct_pv(struct boot_domain *bd) > if ( test_bit(XENFEAT_supervisor_mode_kernel, parms.f_required) ) > panic("Dom0 requires supervisor-mode execution\n"); > > - rc = dom0_setup_permissions(d); > - BUG_ON(rc != 0); > + if ( builder_is_hwdom(bd) ) > + { > + rc = dom0_setup_permissions(d); > + BUG_ON(rc != 0); > + } What about other domains? > if ( d->domain_id == hardware_domid ) > iommu_hwdom_init(d); > > #ifdef CONFIG_SHADOW_PAGING > /* Fill the shadow pool if necessary. */ > - if ( opt_dom0_shadow || opt_pv_l1tf_hwdom ) > + if ( builder_is_hwdom(bd) && (opt_dom0_shadow || opt_pv_l1tf_hwdom) ) With this I'd like to refer you back to my "An interesting combination of conditions" comment on patch 15. > --- a/xen/common/domain-builder/Kconfig > +++ b/xen/common/domain-builder/Kconfig > @@ -12,4 +12,14 @@ config BUILDER_FDT > > If unsure, say N. > > +config MULTIDOM_BUILDER > + bool "Multidomain building (UNSUPPORTED)" if UNSUPPORTED > + depends on BUILDER_FDT Shouldn't this be "select", with that other option perhaps not even needing a prompt? > --- a/xen/common/domain-builder/core.c > +++ b/xen/common/domain-builder/core.c > @@ -1,6 +1,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -60,37 +61,144 @@ void __init builder_init(struct boot_info *info) > d->kernel->string.kind = BOOTSTR_CMDLINE; > } > > +static bool __init build_domain(struct boot_info *info, struct boot_domain *bd) > +{ > + if ( bd->constructed == true ) Please omit "== true" / replace "== false" or alike. > + return true; > + > + if ( bd->kernel == NULL ) > + return false; > + > + printk(XENLOG_INFO "*** Building Dom%d ***\n", bd->domid); > + > + arch_create_dom(info, bd); > + if ( bd->domain ) > + { > + bd->constructed = true; > + return true; > + } > + > + return false; > +} > + > uint32_t __init builder_create_domains(struct boot_info *info) > { > uint32_t build_count = 0, functions_built = 0; > + struct boot_domain *bd; > int i; > > + if ( IS_ENABLED(CONFIG_MULTIDOM_BUILDER) ) > + { > + bd = builder_dom_by_function(info, BUILD_FUNCTION_XENSTORE); > + if ( build_domain(info, bd) ) > + { > + functions_built |= bd->functions; > + build_count++; > + } > + else > + printk(XENLOG_WARNING "Xenstore build failed, system may be unusable\n"); > + > + bd = builder_dom_by_function(info, BUILD_FUNCTION_CONSOLE); > + if ( build_domain(info, bd) ) > + { > + functions_built |= bd->functions; > + build_count++; If both are the same domain, you'll end up with a count of 2 here even though only one domain was built. This looks misleading. > + } > + else > + printk(XENLOG_WARNING "Console build failed, system may be unusable\n"); I think this and the similar earlier message want to include the word "domain". You also want to split the lines at the start of the literal strings. > + } > + > for ( i = 0; i < info->builder->nr_doms; i++ ) > { > - struct boot_domain *d = &info->builder->domains[i]; > + bd = &info->builder->domains[i]; > > if ( ! IS_ENABLED(CONFIG_MULTIDOM_BUILDER) && Interesting - this config option is being introduced only here. > - ! builder_is_initdom(d) && > + ! builder_is_initdom(bd) && > functions_built & BUILD_FUNCTION_INITIAL_DOM ) > continue; > > - if ( d->kernel == NULL ) > + if ( !build_domain(info, bd) ) > { > - if ( builder_is_initdom(d) ) > + if ( builder_is_initdom(bd) ) > panic("%s: intial domain missing kernel\n", __func__); > > - printk(XENLOG_ERR "%s:Dom%d definiton has no kernel\n", __func__, > - d->domid); > + printk(XENLOG_WARNING "Dom%d build failed, skipping\n", bd->domid); > continue; > } > > - arch_create_dom(info, d); > - if ( d->domain ) > + functions_built |= bd->functions; > + build_count++; > + } > + > + if ( IS_ENABLED(CONFIG_X86) ) > + /* Free temporary buffers. */ > + discard_initial_images(); I guess this won't build on Arm. Plus Arm has a similarly named function (discard_initial_modules()) which likely wants calling here (or rather: adding suitable abstraction for the right function to be called). > + return build_count; > +} > + > +domid_t __init get_next_domid(void) > +{ > + static domid_t __initdata last_domid = 0; > + domid_t next; > + > + for ( next = last_domid + 1; next < DOMID_FIRST_RESERVED; next++ ) > + { > + struct domain *d; > + > + if ( (d = rcu_lock_domain_by_id(next)) == NULL ) > { > - functions_built |= d->functions; > - build_count++; > + last_domid = next; > + return next; > } > + > + rcu_unlock_domain(d); > } > > - return build_count; > + return 0; > +} This looks suspiciously similar to code in common/domctl.c. Perhaps you want to make a function usable by both (introduced in a separate patch)? > --- a/xen/include/xen/bootdomain.h > +++ b/xen/include/xen/bootdomain.h > @@ -47,6 +47,12 @@ struct boot_domain { > struct boot_module *configs[BUILD_MAX_CONF_MODS]; > > struct domain *domain; > + struct { > + xen_pfn_t mfn; > + unsigned int evtchn; > + } store, console; > + bool constructed; > + > }; Stray blank line? Or maybe you meant it to go in front of "constructed"? Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 14:31:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 14:31:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376228.608857 (Exim 4.92) (envelope-from ) id 1oGi3n-0007oC-6a; Wed, 27 Jul 2022 14:30:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376228.608857; Wed, 27 Jul 2022 14:30:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGi3n-0007o5-2w; Wed, 27 Jul 2022 14:30:51 +0000 Received: by outflank-mailman (input) for mailman id 376228; Wed, 27 Jul 2022 14:30:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGi3l-0007nz-VT for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 14:30:50 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70059.outbound.protection.outlook.com [40.107.7.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b4ba0fc0-0db8-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 16:30:47 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7254.eurprd04.prod.outlook.com (2603:10a6:10:1a4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 14:30:45 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 14:30:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4ba0fc0-0db8-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RFAdwMIRl79b06CYB0FVzB9HZxVgtBnmt1YCmuoAAzciSty9LlgM/+5AQK0rtHbSO91X6GiuRosc8rVpoUfN+I/tLHx0Re+iyd6bv2cB7KGy/f73iJCGbpPKtcIFYWXRa5GsAIS2wbFoKKy2vy84lLlluV7HF3G1DPvbZXLkn5Zgs5DDLjAR/q+Ua6dq+01Jt4TtBzOaYeZmmqKKE+aG7ntVO9taf6jomDKH2potFfIs/RTX1r6CM5q79Z419zSU1k/Yp7RRp9x2TtrDWIzIwUa+6K/0/4HHua8cbKsiB4ud8z5fBiKeaid+0za+x2YgSWKPj2sZV4SC8zlMMFpLJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=axuX18RS7W5qUjIfqjMh+CQO5ugvudP9Jor8Vpxq43E=; b=f03jcYRo2gcmtJjxD44vJTOEq3ziFdJkgeZajdS7mW6xmqn6KqHv3QRzMtb6JCV2aHrXaubJLQbf9xbM0jpZrtV8FvzdDZa7Xi8f2TL5FoSa3xmx+KPQVz9vXImFfHgOZWjgayHubfvXe6vPSjmLxh1XvPtI+Gv6c8FniXP5Pp4QIxd7ZjgMuLgSz6SrmD9FI1JPtI9pqYdRSwBT/imaETUoI+hWU/GDaBdc1tT9QQfpYMr1Oz3m0gJkvs1iQ/t5fh7ablkBbuRn0qIA/+jWZrQqR12swUE8tzIaifmMt6owUXqfLYbDH3HmWl4rDkMDatY6ZpjV/OGFLhs9A1aMNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=axuX18RS7W5qUjIfqjMh+CQO5ugvudP9Jor8Vpxq43E=; b=ihYYgb2pwa6Ju7aBwHGCgmTSXooIrO2k0FSbJgr4mKPGb4hqYg0d/wml6yHZbhDyo2WFybRfCcdEYjPBT+V4AeNO2hQ2DMn5CntOSLN/5je1nHZmWca3/eoaLi8IX90lZOB1NTvoDTjfpe8Zg1U78KZchs+Xzi6Ozp5XZxBnA0gfThI4PymePzMvHddAFYcLhSJBhRHDyzyNHw8OFw/P3u6maZZSQ4wdItMC1gEzf4R5YfYkkuUIld9LpM6UjazBfZ0n9Mh4C0Wo7qFsupWuEzOXGs8xkTdSQgf4AD8TPWW1/eLGq3gdshLwxZZMTooHmAFmF+BFeIUPi09rVhAP3g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 16:30:43 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1 17/18] builder: introduce domain builder hypfs tree Content-Language: en-US To: "Daniel P. Smith" Cc: scott.davis@starlab.io, christopher.clark@starlab.io, Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220706210454.30096-1-dpsmith@apertussolutions.com> <20220706210454.30096-18-dpsmith@apertussolutions.com> From: Jan Beulich In-Reply-To: <20220706210454.30096-18-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR0301CA0046.eurprd03.prod.outlook.com (2603:10a6:20b:469::6) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3553e971-fe71-4d6c-4e97-08da6fdc97b0 X-MS-TrafficTypeDiagnostic: DBAPR04MB7254:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: v/E3ReGc8YA+oZBteGjS4A0Cf0obIZSS+3B93dtA1eU2cjvvN0tu5VLxsbqs+i+brpbiGr8eKfZoh6Zh2HXD4vHZmnN14urnKXKf3nyykEl9mA5nDtwcpcWlgAayIoOqMwaMfdLlByQEQzCaRnTHuUweQ+yHwaooYwdLRcaq5Ts4lmkBYOVJcmofE52t8PQEk7dWoH9jS1s60y+Su9EU3Hsg9LS/GKEUKqLBZ1te9QEC4DqApyEWousi0VFD1Lk8lHHZgMRsS2bIk8QD0OdHISHJB0D3Hg4Gn1kSaW0zSS5rBTXvRMbSu0ZKWHUHBWEd/nY+7UOZAvCdwfkUGbtTtDTtNIdK1XjHN4HHLE/po3SWzDcntm9lSkrPGUebqte5PL8h4M2a7Re4puU1B5k/CbDRfApr7d43bNOlkGDcfYzIQhdZF8BksuaQDMgmqQHAScksG1WAW98FkPt+xv/e8xCLNvnnA5N2EYk97nXL4Ba+Vr2WI63pU9/hwtoUS7HYC+POgzjfDZvCSAx4LaBxPww2TSfH2Vgw3ZmP/BeFhrgHkyPQUuho6fm/NNdCSq5nAu+GG9GY9OAkGsU3uvUQnsaUCW63kR8JnubaQvbw0/6VGSefMlJFg4U53ZmmG+T9MyW5d+BJJNCn3Ubmmxn32Ph8yPI3kb2LOr2LgmTD1VjXlVM+r956OSAQIE//AQvW8Gw1oJ6jRFGd0qyrxPFcIZcxo69RYTP05AmwNkQUBNCiKWa368miy8zbEC2+WD+A8J+wpDeGpzA5TQymRkuZ97WvldiQCkP1rp73KBOlkW0sKuyW90QRrboRGzAyMK2b+lIj5LivZm5y31IOWvufUw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(366004)(396003)(136003)(39860400002)(31696002)(478600001)(6486002)(38100700002)(8936002)(86362001)(5660300002)(66476007)(186003)(66946007)(8676002)(316002)(2616005)(66556008)(6916009)(83380400001)(2906002)(53546011)(41300700001)(26005)(6512007)(31686004)(4326008)(54906003)(36756003)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1lDM0pVR2kyWVVSQ0tHeDkwSmFxdzNIZUdiRU5MR3BMSVpCWktnMnJOMEx4?= =?utf-8?B?c203TDNHdWtHSk1pd1JSMGhQNXBNT1ZuOTYxVHVJS05xRHZUUStWTmoxdFJa?= =?utf-8?B?VUZSV1Z4MVZ2NXJyd2xrVWhQY3E0WUkyZHhac3oyME5hQjRQSk9laHRwMHR6?= =?utf-8?B?R1dpL1p2djZlRGJkWVFGTTlXbXJXekUyK015WDhseG9FZVRpY3E2VVJBcU1q?= =?utf-8?B?WnRqQUkxcGt0RlB1OHM3YkM0U2cvaERDWkJCWHU3YjYyTThMWE5YWUIxbFhC?= =?utf-8?B?QUNKQmJDOTQ0Qm90aW9ORmtEM0p4NVV3QTREajlMZEhROWI3TlpveDJkRFVI?= =?utf-8?B?RWYrSVAwUUpzUC9BUW5lMHRYaEwvRXFlenlzWlNDQjRtM1gwcGtDb202dXRZ?= =?utf-8?B?NHExdWhZZ2tPTW5wblZUcUQrV2ZZTlN4LzdTUy83YkdMcmh5cy95RkNhWmx6?= =?utf-8?B?TWE0SWROOW5ET25RQ0FKWjlEUWFiOW5zSTFFNHFlMWhLVFRwR2VPUU9KQi9y?= =?utf-8?B?NDN6ZDY4T2kxQTZPTFVqdlAwUlhIYUxlQ3N1eXIyMnJvV2x4ZHVVUFVMTC83?= =?utf-8?B?d2hFcG4yTTdSVmkyZkd6RTBvaWYrQUJzbEdmVmk5RmhCc1J0Sk5TQTcwVWRK?= =?utf-8?B?YjBrVEt4TnhMODI4SVpVV3J3VnVqRi9Vb0lhTStMQUFSeGk3bGM2MFRQaXg1?= =?utf-8?B?S09mSHdnRWl6a3VvVDl6N1NGemZuaUlEU2d6RkxSNzJFcWc2U0hiMXRmMkZ3?= =?utf-8?B?WFZoUUlyT3ZySlBCRUNoSFJYc21KNUx6eDBSazJwN0FoTkIvZnVHS1h6bGo4?= =?utf-8?B?WndkWmgzcTdJWU0vN3FjTVhxQU9PK0VDRExWS2MyMGxrZ1VLMjdNY3FTbHhq?= =?utf-8?B?WFZUdFJqWlRRcll2VFlqaU9VYVRwL1JWZG5Fa2ZQNWhkb0pNTVdCdzJnTzVp?= =?utf-8?B?T0hVamM4WEFYVmJPR0dTaGx3RHY4VEFJYVFzYVVycnNLdURJMW5veGRuc0J0?= =?utf-8?B?QjBxZXVYNHNYaWFoSXJVTHdoak5SWHRTbjFwd0hPRzU5bHNaWU5pQVlWRmFk?= =?utf-8?B?Q1gyQi9aOHJ3Sk1YdkUrSVdQS05ycit1NytsOThwL2NaZzBxWURXSHdONkRn?= =?utf-8?B?Q2EvT1B4cnp3ejFTMjhpRWlOeTdFSWhYWTlDTHNkT1pNQkE3WGJ4RExhZVdz?= =?utf-8?B?UkxhZVIrR0NacWkxNGJRbzdLY0pWcWthK1RkTkJUdjRXOXV5b1Q3djdWaGxL?= =?utf-8?B?ekhsMkp5ZzljRzg1OFFUNEc4UXlzVjhCVWhVa2FrTXIvMUZiMDFvczBhcDhI?= =?utf-8?B?WUlaS3doZDdYaGhHRFJnVFVnVStjdlhRQUdOMFNFcFIrMW9KVXRlbkErTVJN?= =?utf-8?B?aVI4R0ZaRG1xZWZuSEJGbFBpclBsdmZDdmtEYjVoV0RXOTFnUCtKd0JveEhK?= =?utf-8?B?TElKY3JGN1ByZTJMSjBFK0tURkZaSlJtRktQWE52ajk3b2NhTjlzcmQveTN6?= =?utf-8?B?NnhoU1oyK2ZMM0NPelI4c0lNdllLTzNBSTdlNk5uR01OV1RsOXA0K0pkQlNy?= =?utf-8?B?ZWRsVHgxUDc1dmdxemRFQ1hIUlNvaERkRGR6UDFQL1NnY0t2UHVmZ3VEQ3FT?= =?utf-8?B?aWpqMENyejR6eHQ4VVdoNmNqU0pueHVvWXd6d2NUZjh2R0N4MmRpcDV1cTN0?= =?utf-8?B?ZkM3d0lLVTRuZVU5NTBwbTFaZzU1Q3dUQStCMVRjb3JPaFBFUER5a1NoUFpZ?= =?utf-8?B?czVuUER4d0lvYkhNbVhjZnhIL0dWU2xZSkJKQjRhMVZaY3I2Q0RtUDAzUllt?= =?utf-8?B?akF2cFRWSVNZSmM3SmY4S0p3MHYvWHZ1dUs2UitMdW1PbnVKeEhWOHFyMjgr?= =?utf-8?B?YlRGenhhbldvaVJzQWRDV0VueGVoZzNjVUE3Mm42MEJxVzY3bWVHV3J1aXp0?= =?utf-8?B?TEwzTnAxcGJxeTcxb1lJNGtvQkxPSFF4eCszM0d1OFpHc09vdmNZZXJXdEYw?= =?utf-8?B?TWEyQUw2Q1Q4ak5vVGYyakt6TGlCb3FlZGxjYWwxVVhZQnNjdDQySjFDb0RR?= =?utf-8?B?K05FM3ZvazVHaFNlcXNuTm81UnQ0dWpmRW5NT1RWcFN3cU5jSW1xR0dKcnND?= =?utf-8?Q?+pT3NKX8638bxopgv7x2Db0L8?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3553e971-fe71-4d6c-4e97-08da6fdc97b0 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 14:30:45.7092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 81z8q5BWDE/WaNe5PCFhxhcO8yWsaHHuZNTEndubGK/kMwMjqRsTXRVe4UQAjj0bQo+042d/kFAjU0xZvVRmtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7254 On 06.07.2022 23:04, Daniel P. Smith wrote: > --- a/xen/common/domain-builder/core.c > +++ b/xen/common/domain-builder/core.c > @@ -134,6 +134,9 @@ uint32_t __init builder_create_domains(struct boot_info *info) > /* Free temporary buffers. */ > discard_initial_images(); > > + if ( IS_ENABLED(CONFIG_BUILDER_HYPFS) ) > + builder_hypfs(info); No need for the if() here when you provide a stub in the header file. Just that of course the stub vs prototype there needs to depend on CONFIG_BUILDER_HYPFS, not CONFIG_HYPFS. > +static int __init alloc_hypfs(struct boot_info *info) > +{ > + if ( !(builder_dir = (struct hypfs_entry_dir *)xmalloc_bytes( > + sizeof(struct hypfs_entry_dir))) ) Why not xmalloc() (or xzalloc()), which specifically exists to avoid open-coded casts like the one here? > + { > + printk(XENLOG_WARNING "%s: unable to allocate hypfs dir\n", __func__); > + return -ENOMEM; > + } > + > + builder_dir->e.type = XEN_HYPFS_TYPE_DIR; > + builder_dir->e.encoding = XEN_HYPFS_ENC_PLAIN; > + builder_dir->e.name = "builder"; > + builder_dir->e.size = 0; > + builder_dir->e.max_size = 0; > + INIT_LIST_HEAD(&builder_dir->e.list); > + builder_dir->e.funcs = &hypfs_dir_funcs; > + INIT_LIST_HEAD(&builder_dir->dirlist); > + > + if ( !(entries = (struct domain_node *)xmalloc_bytes( > + sizeof(struct domain_node) * info->builder->nr_doms)) ) xmalloc_array()? > + { > + printk(XENLOG_WARNING "%s: unable to allocate hypfs nodes\n", __func__); > + return -ENOMEM; > + } > + > + return 0; > +} > + > +void __init builder_hypfs(struct boot_info *info) > +{ > + int i; > + > + printk("Domain Builder: creating hypfs nodes\n"); If at all, then dprintk(). > + if ( alloc_hypfs(info) != 0 ) > + return; > + > + for ( i = 0; i < info->builder->nr_doms; i++ ) > + { > + struct domain_node *e = &entries[i]; > + struct boot_domain *bd = &info->builder->domains[i]; > + uint8_t *uuid = bd->uuid; > + > + snprintf(e->dir_name, sizeof(e->dir_name), "%d", bd->domid); > + > + snprintf(e->uuid, sizeof(e->uuid), "%08x-%04x-%04x-%04x-%04x%08x", > + *(uint32_t *)uuid, *(uint16_t *)(uuid+4), > + *(uint16_t *)(uuid+6), *(uint16_t *)(uuid+8), > + *(uint16_t *)(uuid+10), *(uint32_t *)(uuid+12)); Perhaps better introduce a properly typed structure? Endian-ness-wise I'm also unsure about the last 12 nibbles: Isn't this an array of bytes really? Actually the second-to-last 16-bit item is an array of two bytes as well, if Linux'es %pU vsprintf() formatting is to be trusted. > + e->functions = bd->functions; > + e->constructed = bd->constructed; > + > + e->ncpus = bd->ncpus; > + e->mem_size = (bd->meminfo.mem_size.nr_pages * PAGE_SIZE)/1024; > + e->mem_max = (bd->meminfo.mem_max.nr_pages * PAGE_SIZE)/1024; Nit: Blanks around / please. > + e->xs.evtchn = bd->store.evtchn; > + e->xs.mfn = bd->store.mfn; > + > + e->con_dev.evtchn = bd->console.evtchn; > + e->con_dev.mfn = bd->console.mfn; > + > + /* Initialize and construct builder hypfs tree */ > + INIT_HYPFS_DIR(e->dir, e->dir_name); > + INIT_HYPFS_DIR(e->xs.dir, "xenstore"); > + INIT_HYPFS_DIR(e->dev_dir, "devices"); > + INIT_HYPFS_DIR(e->con_dev.dir, "console"); > + > + INIT_HYPFS_STRING(e->uuid_leaf, "uuid"); > + hypfs_string_set_reference(&e->uuid_leaf, e->uuid); > + INIT_HYPFS_UINT(e->func_leaf, "functions", e->functions); > + INIT_HYPFS_UINT(e->ncpus_leaf, "ncpus", e->ncpus); > + INIT_HYPFS_UINT(e->mem_sz_leaf, "mem_size", e->mem_size); > + INIT_HYPFS_UINT(e->mem_mx_leaf, "mem_max", e->mem_max); May I suggest to prefer - over _ in node names? > --- a/xen/include/xen/domain_builder.h > +++ b/xen/include/xen/domain_builder.h > @@ -72,4 +72,17 @@ int alloc_system_evtchn( > const struct boot_info *info, struct boot_domain *bd); > void arch_create_dom(const struct boot_info *bi, struct boot_domain *bd); > > +#ifdef CONFIG_HYPFS > + > +void builder_hypfs(struct boot_info *info); > + > +#else > + > +static inline void builder_hypfs(struct boot_info *info) > +{ > + return; > +} > + > +#endif This would better go in a private header in xen/common/domain-builder/. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 14:35:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 14:35:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376234.608868 (Exim 4.92) (envelope-from ) id 1oGi8P-0008PZ-Pb; Wed, 27 Jul 2022 14:35:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376234.608868; Wed, 27 Jul 2022 14:35:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGi8P-0008PS-MS; Wed, 27 Jul 2022 14:35:37 +0000 Received: by outflank-mailman (input) for mailman id 376234; Wed, 27 Jul 2022 14:35:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGi8O-0008PM-Km for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 14:35:36 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 600dcd6b-0db9-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 16:35:35 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB4822.eurprd04.prod.outlook.com (2603:10a6:20b:a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 14:35:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 14:35:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 600dcd6b-0db9-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ROIVX14GLnxT/J6ZPk5YVu1kMVGMH/xfq3GkxW+jB5zZ7tQwYCHrFtDCEJJVEuGSF5pokqsQ8cQUgsS3Whgwv0+ChIXh/GcK49D5wyg0kvh+3W08RMrx3OW9lxDknIl7LNNIxs0N6WzkM7+HFp6IyZioef3Jtgsp/CDlgldbPrBnEpS5xKloBHQK0AM/NmGh1x1elPz2lX9ciBFonZUp8xaqfYQpJNO0Sm1siTG4Qlx+oDmHCHwxHzfKjkSZuhrLZQ0EWhC759yyu1g6ZDWEHzhJrocKh9YPp4jMb8rgPhsnj0iwx9rSFhPDQ9H6LjmYSNgvKVe7OJegAXTlJx5cEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BXqUcNOF3G5Yb9/Q8ml6EsXPGSoHXS4xG436JcArDjY=; b=kY3pMGGo1TuSA4y2W5X7jFLMCabcqy0zJEb9zssIfATunT5rufk7j+9r+1xnaG+mUo0Vk++jaw6whQ9XhCJJJT/3JhyZWCwyta2/KTnMbz2lXoSxh6hLpNV/hYmFHHulrry5YOHuNX/dzxnoa88q/pr8i3n1p+Vmvmct0zDhYYt9ia+sfQcSj/3zPkXYoRZv1kGUBm+e9d7wvA83nAnceWXP5Yn/4gGqJq0NGmF1RKSPXNuoVm4X6eOvhjJ1GTSQXhzOk/IroXSvWeAa2QtiVzqQRwf02y7/qty4A2x2w33w0HU957eID9/RK4sLV3eNCewylHbCtIu+55MdJWQHyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BXqUcNOF3G5Yb9/Q8ml6EsXPGSoHXS4xG436JcArDjY=; b=4pjQtrmuGO8l1X7e4VZETz3Kmda3IT5ro2CnCRb1YUyR5uzVbb/ZDaEumZN1bwTUe+Rwl483l782ywaPVWqMs7IQzz3qQMSndE89c4WpSbSz/N5eSa6pVwjZQ2hTSkqEPm56L6GIAeK7PaeaQgfXYFb3kjlvK7k02d9IclTsBPxFRQR99aO9ZUuDxd2hVv7zBsip6YHJsrgmv38CR6mgRvE7rH9l5J2QKaioxJn2X4umSCC/mjh+vIiQHJ8T19l7LZw3LODsmY0Jehib4G3uIY7Ws+ucX5FIxpu9EyePyexO/wFkhDjtInC6V+QBSo+C8GEkp3sPahzCM3eAULmQbQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 16:35:31 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-3-olekstysh@gmail.com> <51afa25b-93ea-2685-b238-2edd9292bece@suse.com> <2e0efae5-27f7-831d-6f9e-06d03374b716@gmail.com> From: Jan Beulich In-Reply-To: <2e0efae5-27f7-831d-6f9e-06d03374b716@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0123.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 47769f27-d847-43db-69c9-08da6fdd4341 X-MS-TrafficTypeDiagnostic: AM6PR04MB4822:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GaYOVk97aUhaPpNNjybRRdI0HGWsvU1ERImiv5pq45p8ioHv6L8xm/5SXawUqYCYEt/OZdLh4Z6rb+3649T89UYeWv8G9qKwaMMylT70LpQ0rJY5IkSN2Q5x5idv0+2L+Izgnmm4t3+BkzXWVejQTXyGMLCShcJZOdw6oBv/XlOIHWiMYFYyyCorHPFBlK7p7Yr4uHCrIY90PHqevdb8bGBWKqZNYuy1Fj9P1pZ6qc8Xkki3Iqr25PPH3HuwC5GqASj3y6bY88EpuM0r3rGsWZBRpNKgChc+ROCCURflmPlnw6NX3n36q3vIvGyxvyjSao9BWuZN7wk7yk7CMa5rAoyAtb1OEZK+4F/XG3LVno4lkuJZs++ty/sa6sNihQlH25uxPrUaGGtLfRGJaSEqYDxZnUuDeWQHHnxfq7F/3x7xKWUEiaLIkokw5McPC5u1hKylfIqW39ZYKnfKSNHPhI1yVgiy848YYqLx/B1PrvoATxMF685aK4rYliXlYPbIjsaqhaZKNXE5dcavnePGNFFva9MdGiRv6tyOIV25O2aFYqokB7QOEwagQTMnCzpYfWe+hrVRmj8lWsanvtbsaVkeNJnec6gxXlGjJ/BRbo7ZkDtrqEFZXAlKsqGaKrNxPTEbSmLKaNt9iOfyzIoQo5gwvJ7nLQBLNZ0VYVGD1KH21Yq9wQiDoULqKiF6WIM9YySIm0EMkg6kmUydV9K09tRo9jM18kiZKyU8IVjG153P6vYia4UQvZqEVPHqwWJm/AgMS7pqPSXS5m756i2e/0vln7lkv15ma0GeHAIguWv2UFHp+r8rrmES/ZA6lpGku5uWuJSenMrXvz/RWlL6Og== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(396003)(376002)(346002)(39860400002)(366004)(8936002)(316002)(36756003)(2906002)(38100700002)(53546011)(2616005)(26005)(31696002)(6916009)(54906003)(83380400001)(86362001)(186003)(31686004)(66476007)(6512007)(8676002)(4326008)(6506007)(66556008)(41300700001)(66946007)(478600001)(6486002)(4744005)(5660300002)(7416002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MllCbFRMdTZIaVY4eTVKS29OTmVtb0RYbzFtcjd5NE50R2tqVmdkeGd4N2Jp?= =?utf-8?B?clZhVnRHSEM0SzlGTXloR1JmcnVyUzBWRE9RMnJ4SkJiY3VPNk53bVN0QUZ1?= =?utf-8?B?WGY3SmJuWHNGS1NtdWkvSUxXWjhzdGJOVVdUVHFDTDlaV2ExNWhQc1VVN2dO?= =?utf-8?B?NExNUGVHeHRGazgzZlk3V2UxUFpXcW9mL1U2LzY5OWVYb3pkM005anZBbUxN?= =?utf-8?B?L1ZmU1BOSXJJeUxkU2g5ZDFITzFJRlBHWHZkVENRMEFzUlpkOU1XM21DaEtx?= =?utf-8?B?bDF4R2FmMFdwd29WbmFrUlV1ZHBLUkh4MWxwYkdQS0VDVU1mN29zN1lSVGFH?= =?utf-8?B?VE01cmVXZE9QbDJreVE5RXltcm9SYzNQNXBaQ3pqRnpuSEhjRlVFR3lHekps?= =?utf-8?B?UTRkajF5ZjF6cjJmUm1jSFZaemozTUFBNGdVYjRwaDkwekZpS1VYNmc4TzJh?= =?utf-8?B?c2VyQzY5YzVUaUdFeFJCZHFWbksxcHNtYnpuSlFOc1JPSVNhc1JpSzNmMGVX?= =?utf-8?B?UEZveFpxTGdKV3FtS0RHa29VRVhRaGF1MFQxU1NCR3RibHNKMHUwRnprTk1r?= =?utf-8?B?NWhZT3VVMWJuM3RMdkN5akttV2RYN0VsRU5Id1ZKZmZ3aXVMNGxiK3RkZVNB?= =?utf-8?B?bTlpTk94ckV3UXZOYlpXTE9lTlFzdzcxMDFES1dVRDVVQUN5Z01oT1JEUHQ3?= =?utf-8?B?SnNGOWRMRzlMQWVuMFAweHcvMXJKTUxrUU5aeGdOQ3dOSU54SElVSDJrWDQy?= =?utf-8?B?Qy9jQXRFMHNVZGdQM2x4UkVYaFYrS2ZYR1kwUi9nNFV5NlRDUkJqdVZQOUsx?= =?utf-8?B?UUF6YU96TnE5bTlUL0tENHdXcWFKWU1Vd1V6d0t4SHVYTHBUd1pxQjhGUjR2?= =?utf-8?B?SnZXRkw5bWhTanRRWjllZm9IeWMveE8wSUYxd0NsWDhSeXEzNU9hdTk5NHBC?= =?utf-8?B?akZqNTZOVzBNWWJxQ0FpRjJ2czZtQ3N3Z05uZGdLaVIzMUtvWjVNaU4xWENk?= =?utf-8?B?d0ozUDYrbmd2ZGJoUkpwMEtZbCt3a1JqNVNKWDhhbHVBN2o4empPUktlaVJw?= =?utf-8?B?b01FZDduSnNuYlZvQ2tPc0wyZXg4ZFI4TjVWamJnRHEwaGFzbjlndHRBY056?= =?utf-8?B?TnhQVmdaVFdrK0N4MkMvOVJnV0NJN0NWUWVEM29SN0lVcjFEeWI2VTZyL0Er?= =?utf-8?B?YlFnYlh0SHhhQW12UWtORnpSTndDUDk0RGl1Z0Fub2ZqWTBRYnRFTStCeGk3?= =?utf-8?B?K0RWaEFkYWpxUGl1d25mQkd1NHI3Q3NNNTBpOW1hNGVXVjFQUkkyN0dyTDhs?= =?utf-8?B?cWgxRFVmbGJwOGt5QUVuVUp2ek94RU1wV3N2WiswbnJML1NYMy91bVQ0ZkR6?= =?utf-8?B?aXJId2M4VWQyQU5Rb0cxSlBTK2lzVDFKRDhWUll3SEUvYWRQc2xqYnN4cEsx?= =?utf-8?B?dnpOQmU3dDc1Y3FwaUdMYlFoNkNTMVFkUjFOZUVTYmhpWlZTbFM1MUNtTlo4?= =?utf-8?B?bzRjQUx6NUsxU1lQQm9mWU52cWVNb2RpcTZTN2trdExSQ3gwYldjTmNVRUlu?= =?utf-8?B?cHdHb3ZSTHcvQkowUFhDTzdkZjNMdUlJV3VnM09IK1VCT2syZ0xqRk9teEN5?= =?utf-8?B?bEpiYkswMytNNmVScHRVWDdXbnloWGY5NUNlWXV2cFIyTFp2TWNrdmJKbC9h?= =?utf-8?B?bGlnWHMxUGF1UUJaKzVNeWx4UU9lUEdpWWVoL2phT1Yvd051R0NmNDdjS1dQ?= =?utf-8?B?Z0E4VUZsczhtV0dsY0dMdjJBNVp3TTFvUDhDamRIUmNXaWs0ZWh3MzNjL3Vw?= =?utf-8?B?Y0tzQ2xRMThHUkRiNnpSVHhTaTR2S3FGYmFhWDVZbC9PWXIxU3kwWllmRnNz?= =?utf-8?B?S3pubzEzbTgzUitnUTBEazF5R0tWSWNVaW9pVXlJVHBkcGk3eEw2aTZCMTYx?= =?utf-8?B?RG1tUVlQQTZQc3p4T0diQ0tsdHRGYmc3WkFCdDN3TTJmRWJrc2lJM0RaRHBu?= =?utf-8?B?RnZBaC9TVHlvVG4xZEVpRWVwL3pYcVgzdnFWRE5TSEwzQlBDRHJKRjI5MnVU?= =?utf-8?B?cnFpRGtFeGdVR1B0bkVheXNwNk5KNmhSK2d0VFAwY0UrVnRBdlMwU1dyQWhL?= =?utf-8?Q?ZwGDzVIryh5f9PvtqucAxwtUU?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 47769f27-d847-43db-69c9-08da6fdd4341 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 14:35:33.4881 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XIxSAQoewpZYQTioBKNHkKa8yA+Z4Hf3zGQWUhXdPwOSj8GG+ZiWco7VxswQ3PuFLW65EbAwlpAVBcuZ4YLRLQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4822 On 27.07.2022 16:01, Oleksandr wrote: > On 27.07.22 13:03, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >>> pci_to_dev(pdev), flag); >>> } >>> >>> + rc = vpci_assign_device(pdev); >>> + if ( rc && deassign_device(d, seg, bus, old_devfn) ) >> ... use pdev->devfn here. > > > Thanks, good point, will drop old_devfn and use pdev->devfn. I am > wondering whether the printk after "done:" label (and other possible > printk-s down the code) should really use pdev->devfn instead of devfn > in PCI_SBDF construct? Yes, that's intended: If assigning a phantom function fails, this should be distinguishable from failure to assign the real device. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 14:54:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 14:54:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376240.608879 (Exim 4.92) (envelope-from ) id 1oGiQW-0002ql-Bo; Wed, 27 Jul 2022 14:54:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376240.608879; Wed, 27 Jul 2022 14:54:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGiQW-0002qe-7Y; Wed, 27 Jul 2022 14:54:20 +0000 Received: by outflank-mailman (input) for mailman id 376240; Wed, 27 Jul 2022 14:54:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGiQU-0002qY-LJ for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 14:54:18 +0000 Received: from USG02-BN3-obe.outbound.protection.office365.us (mail-bn3usg02on0119.outbound.protection.office365.us [23.103.208.119]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fbb12767-0dbb-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 16:54:17 +0200 (CEST) Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:185::22) by BN0P110MB1611.NAMP110.PROD.OUTLOOK.COM (2001:489a:200:187::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 14:54:13 +0000 Received: from BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27]) by BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM ([fe80::5c73:fd8e:2a33:be27%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 14:54:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fbb12767-0dbb-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector5401; d=microsoft.com; cv=none; b=AacsjLrjIhxanx5m3a2JTlbPRI9Ux36awgIooz3vV54bCFEwvW3nHZXCFhb3QjMq/xEbJkkokSXx5jcQjaJNPlsWf1GbGgfy0VL34sDJ/RzgG0Vo1Vt5rfGwRDE0H90ep0nLIoHYSfeLkxVusvWqCITVe3YOIoXDTcTpU0fROC2A+KWLuUftGd6KJ9YpLpGYaC6du8xTaGDLI8Qg+66nacMEyiFPSD77kNpQjNXmDCFkms9XCwIDSHLIboW+vB42W/UJ6JiN8ynaq0AJwpNGerpBBhKfPomC4PAT9F1tCYqRlBSiCkT8pIMy8U/8+g5qbqv+nG44BYFfH1rQUxqQdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector5401; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Mws4yGJ0axrAhY3l1tCcfs8haik85+aRQB1niqx8sQw=; b=kM3Juu10S0OokPOigP39O3zLtOB0QswCTv866WjtHid8NEBYjlUhIZ8TUEwPawIp83RJUnHpFLEpuzhLycddTwThvh6v0jYFChjkEfyXr48HNjgmGqK6IDgPVoMMBS5AiS5lcTnZuohAl2GBTAP23a3XI/WE8sKlbb+nBIhV0BrHtS9rMTqXkvKbaYxmBCQBxGu1d0tJD3K/tbVqdGQKM3+O8gMakNDpE6Zr+9mU5miwmFVuTpdetjBQi/pckPaxZqaiLEdF97hfdb+RWI9oZ7sh9QIOIUX51WkoLobyT5KXPlLa/97BiuN6aYV8XS6kaGr+KCyDBaKIXvFPhTRgzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=riversideresearch.org; dmarc=pass action=none header.from=riversideresearch.org; dkim=pass header.d=riversideresearch.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riversideresearch.org; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Mws4yGJ0axrAhY3l1tCcfs8haik85+aRQB1niqx8sQw=; b=NxnvwjpO0hp34OuA44fWqng/26z1XHKGF/O7UnUiX4quaiJOZITenEAtuNUp+s0A1naNoDzHpxuXEzadBIG7ssEEqN25xkDRBQSt57qXzTS5Cvfu7HZa6cxFZEP0dmZ2CBWF1PFE6fbNztfFyiNfLUlw/mFOV78/ZMKfAQAqf7eWqvbYK/o9DA8cIpg86Q5mR2i2UYAh7GbBzdo8W43atnx5F084hs9RdFzoPVBnYLbs7ryFxvK+xyAFbY7oh/O3s+CodoBbU/7KFtKYy37qDrctTNqkYTDF9AWUTNS47E5A5km4KGpr/Fz5HkD1ROZRiY0YlktWZ4OmSv9+HuZCxQ== From: "Smith, Jackson" To: Stefano Stabellini CC: Xen-devel , "lei56@purdue.edu" Subject: RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Topic: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Index: AdigP3XkakTWEwukTeurpU94cGpQzABDr/uAAB0Pf2A= Date: Wed, 27 Jul 2022 14:54:13 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=RiversideResearch.org; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 256a1f76-63b1-4be5-14fe-08da6fdfdef7 x-ms-traffictypediagnostic: BN0P110MB1611:EE_ x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZNfRry73CEazHqKPiasVedsujKzzkV3BpL8UluKpH1Mwr0ffL7WnLNqdaOlh7NOJoorL8ExH4bIEM2B3Pqcl94MUgMxhOMHHlwBkx6zoJQX4GVUWb+5JcTg0toczNVRzrZV0k8JWJ316JUg4qgAN0s4cJeIS8kv/RsFQpKBGiznodSrYLbKp5BAZ9KuD+C8NdFXZVi23xxxJ7KweWEbMgLzS0lnIXuAXA83mZ9BTX4S009qI2xU0+UH5vZ749cvGbNhZXWVogT5y7K4nzu32PorAIMtUnljjNAF8RTWKKOiogZybhHFTLbxJDJGroIvIs3uBDVwUAOxx5vicSnTOb3zx4yOJWaSoO5G+jrSPOmVZ6auhnSTYV7GobBQ/dMUYpUPaCLQm3fVZ84RUyNin99y2vWwcSBCm8SAkqhKsR1ZXP5LL8FW1gPpKCSUzMq6lDhn7ufFSgIg457hVECENZi+z3+9dJfubmpCbMtiarNN9m/GFFGMLKUDTVlRWsrPQ+xyQf+z4MER9tMKmYuXSMmRrEIXJOH0Gkhts7C13HTFG8TJvd6Ybujqva2UmcKCCNFSSt85abzmJHAPLhHUKsSh+VyolhTrYmQfBFe0BTFtwdWmJx9PXMmgpT4CoV5PmXroW36Xa/0tbxqgq/+g1/xfGq5cM9kO6mdORJEcO2h+w0pfS/r/aHvno/ZqFl86SFlQ4vDutyHbRHpyh/iL+9oCzUCpskHoDW9yWshoW00EEF1Yig+LIZfQyxdIK0zHFmvqNu2ETL58pcu/O6RXkGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230016)(366004)(5660300002)(52536014)(33656002)(8936002)(38100700002)(2906002)(6916009)(54906003)(66556008)(66946007)(66476007)(66446008)(64756008)(55016003)(76116006)(4326008)(8676002)(26005)(7696005)(9686003)(6506007)(86362001)(966005)(186003)(498600001)(71200400001)(83380400001)(82960400001)(38070700005)(122000001)(85282002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: obRkT1K5MfZJyCEYj6xkInkGb24T/1RUs5TMcb3RX8GLxMsbv6/6p8c36ujsjqVyXYLQuRBkvsMn59DgHzH8oy77AUulyjf31Nfg93IVd0OBRNi7cMFyl+kM4pswNCTrDdXcz8yu9menaUpgfIcK9Ps6suI+/nOwB9U4T2ZiLJx4tgtUnhVssEh3yZfH08hc426ztXB9RxUsS75Hoxztt1ynfJb/Q+8Z2SVwh2cu0n4/+urORLbLdd9K3HXZqK8Ro7kGTUqU5p/y0i8KZ+F4Sy/P9MyO/Erqqz0Pmcw7970JI0wtO3F+eH3/l3XkJD3RLIGJU7quqzYJO0pDmvy+jjJvg4EVUeJgwzPiwrbAVYZ1zf6Wy5SBLMlZWUeowvJOYKIomAAB8fcx04cMIousSvcYIiStHOqb0wTJCpLvKRg= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: riversideresearch.org X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN0P110MB1642.NAMP110.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 256a1f76-63b1-4be5-14fe-08da6fdfdef7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 14:54:13.5002 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: bfc64a8d-9064-4c64-91c3-9d10b44c1cb6 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0P110MB1611 > -----Original Message----- > From: Stefano Stabellini > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > Hi Stefano, > > > > My colleague Jason Lei and I would like to submit a patch to imagebuild= er. > > > > It seems that generating a .fit with a true dom0less configuration fail= s > because an extraneous comma is included in the its file. > > > > We believe this change resolves the issue. > > Hi Jackson, thanks for your contribution! > > Yes, I see the problem: the code assumes there is a dom0 kernel. If there= is no > dom0 kernel then load_files will be wrongly starting with a "," > > I would be happy to commit your patch. I assume I can add your Signed-off= -by > to it, right? Yes, that is fine. Could you also add Jason, as he worked this out initiall= y? I've added him to the message so he can give his ok. > > Signed-off-by: Jackson Smith > > Signed-off-by is the "Developer Certificate of Origin" which means: > https://developercertificate.org/ > > > > > > > Remove extraneous comma in generated its file when no DOM0_KERNEL is > specified. > > > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index > > 8f08cd6..6f94fce 100755 > > --- a/scripts/uboot-script-gen > > +++ b/scripts/uboot-script-gen > > @@ -676,7 +676,12 @@ create_its_file_xen() > > i=3D$(( $i + 1 )) > > continue > > fi > > - load_files+=3D", \"domU${i}_kernel\"" > > + if test -z "$load_files" > > + then > > + load_files+=3D"\"domU${i}_kernel\"" > > + else > > + load_files+=3D", \"domU${i}_kernel\"" > > + fi > > cat >> "$its_file" <<- EOF > > domU${i}_kernel { > > description =3D "domU${i} kernel binary"; > > > > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:07:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:07:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376249.608890 (Exim 4.92) (envelope-from ) id 1oGidV-0004li-KK; Wed, 27 Jul 2022 15:07:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376249.608890; Wed, 27 Jul 2022 15:07:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGidV-0004lb-G2; Wed, 27 Jul 2022 15:07:45 +0000 Received: by outflank-mailman (input) for mailman id 376249; Wed, 27 Jul 2022 15:07:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGidU-0004lR-AC; Wed, 27 Jul 2022 15:07:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGidU-0007wV-7r; Wed, 27 Jul 2022 15:07:44 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGidT-0006r7-Pg; Wed, 27 Jul 2022 15:07:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGidT-0006sV-NG; Wed, 27 Jul 2022 15:07:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=T9WE6BmT6k32DoFlYk90IeY7XhKzFRKk+lo3NeqYQnw=; b=wbaiahK0R3gheYua3y3Nvh1Bdb hPDAHylZt7FG5kjprLUH6VtqYCMhh2G8mJjmDxl/MvFUGOISk5USY87eaMKrSFrZboslbwZOJBuJ7 YKjlWTko2Wj6/Y6fXOD0i6JoW0/ci+2y9o1AsMbU5rQRrdb1/EOwNc7vAA8gRkbVvSqA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171884: tolerable all pass - PUSHED X-Osstest-Failures: xen-unstable-smoke:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=b1f0183e5067fbcb87517795e27929982b2404fb From: osstest service owner Date: Wed, 27 Jul 2022 15:07:43 +0000 flight 171884 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171884/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen b1f0183e5067fbcb87517795e27929982b2404fb Last test of basis 171870 2022-07-26 17:00:31 Z 0 days Testing same since 171884 2022-07-27 12:03:31 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Edwin Török Jan Beulich Julien Grall jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt pass test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git b1f0183e50..f732240fd3 f732240fd3bac25116151db5ddeb7203b62e85ce -> smoke From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:20:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:20:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376257.608901 (Exim 4.92) (envelope-from ) id 1oGipN-0006Q5-OH; Wed, 27 Jul 2022 15:20:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376257.608901; Wed, 27 Jul 2022 15:20:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGipN-0006Pl-KL; Wed, 27 Jul 2022 15:20:01 +0000 Received: by outflank-mailman (input) for mailman id 376257; Wed, 27 Jul 2022 15:20:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGipM-0006Pf-4M for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:20:00 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 93f5f035-0dbf-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 17:19:59 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id s9so2588023edd.8 for ; Wed, 27 Jul 2022 08:19:59 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id kw26-20020a170907771a00b0072124df085bsm7771342ejc.15.2022.07.27.08.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 08:19:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 93f5f035-0dbf-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ENJiX+GT8DTpmIxLHxpEmpNV9lAnwpSdJhPDIIPKRss=; b=VGCHeLtRJfQVpQjXeM/lEPXU9cQL8TF5C/21G+FUzJof82rPNpCP67V9/638rstCg0 fD+Xlim9jAjbPrCrZIQOqXa7vOl0vAJs0YnPXt6PAYHv0RqTElhW4SO2BQtAHtWHeKep 8K/SJyOK2z1dy4IMpbLkaes7oB5XTt+2ssEaRlmkWFAMf5gzriTR/Fiv2RgbgtP8UWcr rjBnTpasuFicQ4AIPk0DTFvmYoe1hERBRGquN8sBi7ocZYsnloFO71VLgWCgbeyFkFgZ phdZwzlHO3IidrerXuKSNzJKEsvfl6h3sw4Hr1lE0NC1B4EAzH8FQ0TjN91252xwMyBG 8Q4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ENJiX+GT8DTpmIxLHxpEmpNV9lAnwpSdJhPDIIPKRss=; b=V3ZXIajUDTj6NgIwSEdLrleYG1Y47YMXaM4B39XpT/8DtEKpDFXKwvR5iteAqglvqU hAX9zt/D/MT6E0cxGRyYv6q0+xxVJxfCMseAVAR6abXmG+HRP9gCr8XOAHSpt8MJLmhW 1DgyDNKD0eGGTSf3ibBg9utWPfzSpmnwsb5fmZPGG0vO2tGAxTRtVML0m/XXL0gh8/pL KozzX0Dtzru87IbIl79ApTRnM1RGsW8wpYD9eLStbt1WOiqo9DopWV7sCasYe5jzZNfH l1MWkmcvFWWdHesdKR0wheMA0pW6EBo8eMANWU1dimcGhItTDgaPeJpdQQcPmDw5uc/Z n/2g== X-Gm-Message-State: AJIora+SL+XTYa9mYbn+xfQAzC4wx+dX92dIFJuGRNFqwGq0RiQgJF4p GBwoS2BPi1RXM+CNML1BtUG+4rFh59A= X-Google-Smtp-Source: AGRyM1sWglpGzkh2mvtL+5h0Xpqx9GMqjfDBVKa8M0SsivwWU1s0CIbxcdyl+FSRfnPfYF+YodGFNA== X-Received: by 2002:a05:6402:1d48:b0:43c:13fc:d01 with SMTP id dz8-20020a0564021d4800b0043c13fc0d01mr13790272edb.207.1658935198256; Wed, 27 Jul 2022 08:19:58 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: "Daniel P. Smith" Subject: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation Date: Wed, 27 Jul 2022 18:19:53 +0300 Message-Id: <20220727151953.1125331-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou --- xen/include/xsm/dummy.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h index 77f27e7163..8671af1ba4 100644 --- a/xen/include/xsm/dummy.h +++ b/xen/include/xsm/dummy.h @@ -15,6 +15,9 @@ * value of action. */ +#ifndef __XEN_XSM_DUMMY_H__ +#define __XEN_XSM_DUMMY_H__ + #include #include #include @@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map( XSM_ASSERT_ACTION(XSM_DM_PRIV); return xsm_default_action(action, current->domain, d); } + +#endif /* __XEN_XSM_DUMMY_H__ */ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376268.608934 (Exim 4.92) (envelope-from ) id 1oGj2J-0000zw-DO; Wed, 27 Jul 2022 15:33:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376268.608934; Wed, 27 Jul 2022 15:33:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj2J-0000zp-AJ; Wed, 27 Jul 2022 15:33:23 +0000 Received: by outflank-mailman (input) for mailman id 376268; Wed, 27 Jul 2022 15:33:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj2I-0000xr-PR for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:33:22 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7125ff42-0dc1-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 17:33:19 +0200 (CEST) Received: by mail-ed1-x52d.google.com with SMTP id z22so21856670edd.6 for ; Wed, 27 Jul 2022 08:33:19 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id ev6-20020a056402540600b0043af8007e7fsm10260725edb.3.2022.07.27.08.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 08:33:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7125ff42-0dc1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hHQQpVHcsAAoHD76EjQX32hczFF76kD+YJC2T3vRv/U=; b=g5oZIyaxtcTk7+udJ/kTuMhz05RtWlo3t7krco9nVhtapAEd+nqGua2/jZeg34u24E bjGIXHK3OmA8n5fOibqTOSyLf3fvuxGceRstsP4BnbjZfOc3tlABokkKL2K4h+ruWMUH sVFKrOdV+mpdhHlJm6UaKlQCmJJBJQLDDG0rKwCqQk44IInWHgeEvdFkJD6tyf9jS3Vz UTXZiA8H5XSAUd4/3FHVvXDBweDpnV7ZZLXuvIL9ObChty7ijkmrmUuExNpK1sKOFhoY CigCUy5lu/jJN8m1TnmVKFiTbLgLAhQnBEjF7+Ek8U4z6u9u7w/ztjXcV3iPHVTqYZYw 85Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hHQQpVHcsAAoHD76EjQX32hczFF76kD+YJC2T3vRv/U=; b=Wjh5kOy5lU6AXKuz10akP+CRuPNfL11OjAku7W6Y3SkMjbh001cJ2+POVxT0Oqu5Dh rgR5I+X9kJ+NS2IU1/BAvnm/SpxEpMIRVh6/Yp03//Kho51CiQBwg7TWvtWs6YIGan2j g4PrGVUCGqpi94mxZ7boJjqaqkcgNoQyEDF7QrbBkKzVC+lgpZ++bUPw2RU3U+PVEZfK uyFm+f4vRmPzDUC132HA0SdNXGPvPoUFFFhNb3grGFquD+BrBZba+WxiHtlz7FQQSrJH Xu8yuBqlZQeKuZZiDFXB8oT3kE76xFsKqjTmWNMZWTsrcnbjf7lpt+Z84O7DESpPDju6 5kXQ== X-Gm-Message-State: AJIora9h17s6Ukycf30z8MTD7c3PoJ893nfUCcVcAVa9dHdvnM3dgxpK UDa6dYw0c+4aEFL9Qg0Mi6nJGAk/Xio= X-Google-Smtp-Source: AGRyM1vReZVTQq4Hf3nNssIW3G0zShhaMKp8MxnkQOpmPITnTz6zzydu+8GwQuNEwPgAS0hvccu1+Q== X-Received: by 2002:a50:ed0b:0:b0:43c:83bd:fd5d with SMTP id j11-20020a50ed0b000000b0043c83bdfd5dmr7318020eds.237.1658935999193; Wed, 27 Jul 2022 08:33:19 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Date: Wed, 27 Jul 2022 18:32:54 +0300 Message-Id: <20220727153254.1143503-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220727153254.1143503-1-burzalodowa@gmail.com> References: <20220727153254.1143503-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove unused macro atomic_xchg(). Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index f5ef744b4b..a2dc125291 100644 --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u) return __atomic_add_unless(v, a, u); } -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) - #endif /* __ARCH_ARM_ATOMIC__ */ /* * Local variables: -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:33:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:33:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376267.608922 (Exim 4.92) (envelope-from ) id 1oGj2F-0000h9-4l; Wed, 27 Jul 2022 15:33:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376267.608922; Wed, 27 Jul 2022 15:33:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj2F-0000h2-27; Wed, 27 Jul 2022 15:33:19 +0000 Received: by outflank-mailman (input) for mailman id 376267; Wed, 27 Jul 2022 15:33:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj2D-0000Po-13 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:33:17 +0000 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [2a00:1450:4864:20::636]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f0def9f-0dc1-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 17:33:16 +0200 (CEST) Received: by mail-ej1-x636.google.com with SMTP id mf4so32169323ejc.3 for ; Wed, 27 Jul 2022 08:33:16 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id ev6-20020a056402540600b0043af8007e7fsm10260725edb.3.2022.07.27.08.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 08:33:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f0def9f-0dc1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gsFJdYQm5IaUi4s94A+NUxnT5djgg725ifru2jn4FWk=; b=c20B698felpQIJIxGetf7JzxzaPCF8irPc7bB7io8OzCIjHtZqWwSuoRBXzgmn5mH8 ZEoJX0vVNKqQqhmh1qrJqLQYzOfxfg+bWG5iZTFtaUoLHzFNChNRYcsFg9RKsOphAVHW tBLHY3yLeMxzClv11hNOwicB59rK8t0QIUHEDSJTAe/Su0dOMkfHcoiw6/ECjxRk0Ypj 7tM0f7CGdiWhXI03hOdqM3xheKk9rDfKs/rqCtN++pQmpINnsAlO2wufBoM5EcjQ8LJf 7r8BFAJa4Vu2s+aBDzDky+66+d6XK2aQMoq8F1vi/kgGJzFnFdfGkHJy9rSe+CXPxhQF FZqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gsFJdYQm5IaUi4s94A+NUxnT5djgg725ifru2jn4FWk=; b=Pe/6s1s/3f66ckRRbb09LqF2v/eq5lF87cuVhLBGSw6p9bnWkehQSdGTrus1qZtvMx 0MbSqx3qYfjjVd8OSuE3tA4OQ8AKN31+eJeirdbe3s+JAb0ajaRkSISDCoEpKI4KxRJi Ao4KKOBpNL7g1k+f8/rNY8nni8ScqQWTLqNbekSJfwbRYBUWLf432if542alvTFYuD05 Vke7hVddNKQMkh0jwQnmTpoTI0dB/HWvQFcgG6Ak29K4gN4wNC8kDgv6Fi6cPmI/83jP YErJeJGT3stm00Q2O0+55goVdNajHo37UJDNJ5HaEWmWN0jcD1tc7t9DDz4E6Mqana4G sBSw== X-Gm-Message-State: AJIora+MarMGQDCpemsCXE4EgFqbp+5BW3t1TzFgjk2ZWd4bowr295eu yth95xm/0/lDfW5kzJLwzh6eKTobNl4= X-Google-Smtp-Source: AGRyM1s5sEijfF2Y3L1wOME2jcsEw0+NDBPvAcEid4NnSHaVd4In3G51ouPUr/OyVJNtPPtcAJ92UQ== X-Received: by 2002:a17:906:847c:b0:72b:4188:f940 with SMTP id hx28-20020a170906847c00b0072b4188f940mr18251339ejc.552.1658935995255; Wed, 27 Jul 2022 08:33:15 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation Date: Wed, 27 Jul 2022 18:32:53 +0300 Message-Id: <20220727153254.1143503-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220727153254.1143503-1-burzalodowa@gmail.com> References: <20220727153254.1143503-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/atomic.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index ac2798d095..f5ef744b4b 100644 --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, } #define read_atomic(p) ({ \ - union { typeof(*p) val; char c[0]; } x_; \ - read_atomic_size(p, x_.c, sizeof(*p)); \ + union { typeof(*(p)) val; char c[0]; } x_; \ + read_atomic_size((p), x_.c, sizeof(*(p))); \ x_.val; \ }) #define write_atomic(p, x) \ do { \ - typeof(*p) x_ = (x); \ - write_atomic_size(p, &x_, sizeof(*p)); \ + typeof(*(p)) x_ = (x); \ + write_atomic_size((p), &x_, sizeof(*(p))); \ } while ( false ) #define add_sized(p, x) ({ \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:33:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:33:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376265.608912 (Exim 4.92) (envelope-from ) id 1oGj28-0000Q7-U4; Wed, 27 Jul 2022 15:33:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376265.608912; Wed, 27 Jul 2022 15:33:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj28-0000Q0-R9; Wed, 27 Jul 2022 15:33:12 +0000 Received: by outflank-mailman (input) for mailman id 376265; Wed, 27 Jul 2022 15:33:11 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj27-0000Po-BG for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:33:11 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6b0a70d0-0dc1-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 17:33:09 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id w5so9440288edd.13 for ; Wed, 27 Jul 2022 08:33:09 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id ev6-20020a056402540600b0043af8007e7fsm10260725edb.3.2022.07.27.08.33.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 08:33:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b0a70d0-0dc1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p8Cy3IKT6/AflZoLkcKNavrDiqUoPXLAJcSHK2voDa8=; b=bwmxrUqXArzNP+KEmQQa/pH/4D8DF2VJleeqaG5o3MleGaCVptHTT7ing+38TLVlex qjfoCimpdKHfmDekQ7kb5M7GetZJYCl85TY6PZmcq2s+xW5Je+rFUML95oB3NRez+vGp 9joxl0hfXe4sytRBD/HkeQACC/ii5VP8Qd750TylQLRftnOgNxdhF6LSobY7sfsA72c2 4hEm3Jtlr+ipb8GLqVnsv0C0ciAH7i+eDMpBbe71ycT8DUIsrBCwpq8Tf7UTC/qk0Kda VwHRJIYgDxn6b/v3yr+cGZ0nhJ2nhXDlR+6qwfJ5mdRqQiyoNwo61w7alN6+APS/WUcS QJ5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p8Cy3IKT6/AflZoLkcKNavrDiqUoPXLAJcSHK2voDa8=; b=lXM5rBIPBrb/3hgUjgurBkfnXIS9aMIyH/gjLlfuD4/56pxf5zAQTBZSF4dSAhX5Hb T4q6Vpupuz42P+nnEfOVukuI1f2Apl/JDTsY2gtP+6Npn2AMnaCTr2NHVbMUFAQScRdl DkWyPUtOhqKca6L7l40Mle5szmbdug+l7CmR+Mgjg9vkggKCsrvZU3GRTNNl8i8sq9aX 9y3kZdA2nRoCZGBQUzkuJHk34HH/AaX7/Sob7kyvKVdl54jW1A33eadWPODzomlWz2Ut qE+54ztfqLdCA1OnDQ9kO0ZsSAS1v+UB1wBJoZ3t1iuSuyT2+kMUZpP5c5Y4MLHNqLkl 4dWg== X-Gm-Message-State: AJIora8G3kdYx2lbUk5yhVfJt1oLBM6ItUNAnIptgSLjm7TsGKwO87U+ zsiWPhZUqsEZzK9DWubZjHKzXk6yPCc= X-Google-Smtp-Source: AGRyM1tySdZvhNo9NxfFtTQf7YJ0bNDhZyvCOV9LdVP3ZYXfHDSG5tuCuV0ZSB50D2DXc6eMHzPXlg== X-Received: by 2002:a05:6402:d05:b0:425:b7ab:776e with SMTP id eb5-20020a0564020d0500b00425b7ab776emr24440762edb.142.1658935987169; Wed, 27 Jul 2022 08:33:07 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH 0/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule violations Date: Wed, 27 Jul 2022 18:32:52 +0300 Message-Id: <20220727153254.1143503-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series fixes violations of rules 20.7 and 2.5 found in xen/arch/arm/include/asm/atomic.h. Rule 2.5 (a project should not contain unused macro declarations) is advisory. Xenia Ragiadakou (2): xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation xen/arch/arm/include/asm/atomic.h | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:36:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:36:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376283.608946 (Exim 4.92) (envelope-from ) id 1oGj5b-0002OR-VC; Wed, 27 Jul 2022 15:36:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376283.608946; Wed, 27 Jul 2022 15:36:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj5b-0002OK-Pr; Wed, 27 Jul 2022 15:36:47 +0000 Received: by outflank-mailman (input) for mailman id 376283; Wed, 27 Jul 2022 15:36:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGj5b-0002OE-0y for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:36:47 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2066.outbound.protection.outlook.com [40.107.104.66]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id eba6790e-0dc1-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 17:36:45 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM0PR04MB4931.eurprd04.prod.outlook.com (2603:10a6:208:c1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Wed, 27 Jul 2022 15:36:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 15:36:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: eba6790e-0dc1-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X5ZEl7bB451Txc70q/CLbse2XGEEf4te2SBD3SjbzJtZs7/wcK8Yt9/vpYxLAjrMHKzvDUw5sMSks4+W6mGj+qAEoqwFPTz9Cua+R/T3RdZWt3j1KHz9J/FpNwYW857+jJM8VV0fBAyUxql3QwgB/9K5FaNiB725Rjvz8hkRtz2W/8WvYnOf5RLVMOzsNnFmSrQB+QZwOP0JFwnwCgxYaSZ+QxVVPqk1jyXqzdMFD9EDf+yw3ewSdhjAUAUTu6gW0HTA4oqXRbQbCcjHJ6FgV3ZFnzdbRn3/PiW9entc1e4NeNHBDfjAiLbTC9ShWaJMUA831lcsxI4VXgRT+RX3sQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cN5o6lWAgUERhcBQ3a1gWXNIEjwgU/cBpWcwDYvqMrk=; b=g/oaMEZwqMOM+3lmMK9FAgp4BMeIKtO8FXRh693umwFB+3FR3+au4rfc7FWlgrZgWY0etSITkZIbN0QEux1mf3KQV/GDFWkA37zFMamC5LVuJ6HvSB2TSHZK0AKTHq9ae5wzYIenixmHSiRJinmz2PWK5CrqxfVUDYDyxFgvN/2KQlyeBw+NmrFYMtYnPIluqcYw7PdBa6Q0SOfu/cLEarjDGIOpgkJ9oDLd5selHe0B6Ha6f09DGZQxAuXjVw5DbWaw5fko1MWwdKIbyZ0VWBLa2XW9XSJ+an9WlPdQ248hZLGyEDcN0JDmASYv0nzfXa1lDBPa0lpPUKfBFJEW5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cN5o6lWAgUERhcBQ3a1gWXNIEjwgU/cBpWcwDYvqMrk=; b=m3mqJWjHiSI/zWR/sWSHiSiqz0ltHDQsltyOERC2IwSNdahaDXReFL4sAm9VpxtDsSEeDqtO4pm/U9MH/K0M+cAwHCVCPBMxihNjZFE0TG5pPwAUL5S41jt5sjGqFsfCOOabCz/5lyc8fXCjpbEvBvTaBmOmIlQpa40Of5MKdIl/clcKaGVDtsybvPAKR4cE2eWZvecUXaP2MCsYJeLATZavF44SQ4FNIPt70AqdTYpPEiT43gxHXq75rHqaau+zOmTO66QYiXhfFh9TPpyaoLMFTya2BvPTRSN1itGkqSLZy9e0qbIgUXNmZExl5QKzHHqDDJ/R3gFcrQIppM6UYA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9db28ce4-d4dd-3806-75c7-a6746d40cbb4@suse.com> Date: Wed, 27 Jul 2022 17:36:40 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-2-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220727153254.1143503-2-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0010.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::15) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 901cf67f-57f0-4bb7-089e-08da6fe5cdad X-MS-TrafficTypeDiagnostic: AM0PR04MB4931:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xegoS4vPkZQYXpolLOJY5bVfaPR9Bd4H10UenjLk3+jh2DapSuybIvI5x13xd356TU4yn8lMcMBOsSp5wNsbanZAF9FXMFU8owIWCDZSX93qgfT4iJB3M32Qfo0pTpUvZQQ9C13sRDNrV0cHwSi0eQXRsF2+YEGKasjzlYa34IjTqMIHw6UQz4NyImjkI7UDyMM66Q0ryYfSnl+Q9fKM5XxDylge+UZS8vjwyWP1cvmpNGT3oMekW/LBR+JGIzyd4IPMGaxIM4U3m8dJXKFMOLYhW0ReL+2O3WWVFDiYlq4aHgegdba45NoShr/oT8XNJvTVYWlhy5wxBfwUq1e6adUw0LIR/Swyjrp7FvBcjE2DmlmaiqpY/HQtjMRLoLHfCr+CI8AwNTvR+XMlcaKR8XExCtTxrQI2L1V+uL33JRcPTzoRE+QGLC4rolH32nfe9tx3ktXarpeROKmQNbl5BQpPH0DSAxX1S4abC/NXJhBXi227NM7SPtWVnhxwm0CqBxadjgSnRln5wvtItw+g2kiXs0xGme2CdbuMmEaOma/Dhn14Y/4r1P+N+y5Igs4YOqv7PIsSqk4E2LVaeKlZWPIYIiVYtd/v6TKpfU80DCLokI0H5vn9WIddvWpv3g3oaTI/bfp4VmYwktDwhjsNsCze02qG+pRpbs26IXnOL7tnmLA1cO47zRG5PDsMrfGL0o1X1qdp4C2NBP9GCciNC1eYpeMJkxWfFblEOif5sgHwhPAbbV0sPH0YMwi6BXT/RVBDnf4LL6V9zRvmSZpaO28JdFyddTcaPBTRuVzpqrxcHWP3wNqJpCrv45+WG1Qxm0hv2UzUdGOp1T4CBifmKw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(376002)(346002)(366004)(396003)(316002)(31696002)(54906003)(2616005)(6916009)(186003)(6486002)(38100700002)(2906002)(4744005)(36756003)(8936002)(31686004)(5660300002)(66556008)(66476007)(83380400001)(53546011)(41300700001)(66946007)(478600001)(8676002)(86362001)(6512007)(4326008)(26005)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWlCZWRFZGkreDJ6TE9WbHlxenV2TVFNQkFYd0hSRkcxbE1rdE5qcW1zcXdM?= =?utf-8?B?VzVjYWFLbExBRCtnOHdHSUF2ZEhXYjhIdkc5NDhsREp6WVR0U2lwSmhDLytG?= =?utf-8?B?TThrNEpSZytsaVh4QVZQUUNVdk9BNHBnN0FaVmcySmt2MlA2Wnp5QmxxRWlx?= =?utf-8?B?Skh4eWE2VHBIdnhEV1lUdnBHM2Qwak5qeHRPRUZNZnBqaFJIcGlzTU9NNkhr?= =?utf-8?B?ODA0UHFPazU5M2FNb1JJV3RodzNRenI3bDlSVWhUUThTQW1NRkdkYVBuMnlT?= =?utf-8?B?LzNPNGRBdSs5NDIrbkt1OUpkdjJkYW9TNjNnZ3FPU2FreDVjMWNlbW9peGt6?= =?utf-8?B?M2tYWXUzVWNCTS9xUWphb1dCUGcvZ0dBdkxKbmRCQ2dkT3lFWk1BSlUzY3Bw?= =?utf-8?B?UkJFU0RLMVhYYXlpck14cEdNd2lUQ1ozUUptekRCdVJCdkgzRTVhdENtaDk2?= =?utf-8?B?UUJqektIRFlZNFh5YmRqOVBtRVFSSTNVb3Ntb2lqcnpwYVVIUmZzV3NsK21Y?= =?utf-8?B?WVJCYmRvQ2dvUU92NnI2bWVHbnZkYUhaanI2VHBMK2EzTEtSNlljMUJ4bmtQ?= =?utf-8?B?cHN4K0xKWm5uWFUrcGVkV3c0bWgwR1RodlFONW01RFB2YmZvTnRJcXFFcmZq?= =?utf-8?B?OTRJOG8xU0hucVpyRUxveHRxS1VGVFBVT0lxMFRDMWVTaDd3SUJjZXZHSnpQ?= =?utf-8?B?Zk43d0VTR09lQzA5ZHZqaWtDV0dTK3JTNEVxNkRxWEVRTGlTY0J1K3ZzVGU3?= =?utf-8?B?eU5GRHpjZ1NEald0aUZ6MUFNWEpwRW1YaWJjTnhDaXA5STZyR0FHQ3pxQ2Mw?= =?utf-8?B?UGkvMTBFOHUySmoxTW15SWlQNXRFVEU3dG85VER2OW1lR3lQenV3aEpLTFhI?= =?utf-8?B?TDM3eGxuaFIyZGNvZUFoN213YTJqMmtUMk4zekZuMzh2eUE0NW90TE1BclNu?= =?utf-8?B?eW5FaGdJWWt6TGUyN3lVNDVqalI4bEpZdFhaazBJZzRPTTBGMUk3dE9Da2JQ?= =?utf-8?B?T1VxRStQdFVzMjRDVlV4RUsvb0VUTXhYNW1SWVhFUGU0azYzOEFTd0ZDKytq?= =?utf-8?B?a2dzaldtaGVRUEFuRFNWcERYWnZMMTMyamtmZzcvRTRzUlhEUlpGNHgwckR3?= =?utf-8?B?UGNCT3Z5cm5JZUtsM3VnNXFEZ1dzUVJEUklBY09yWUt1ekJaaTQ4YUlud0VW?= =?utf-8?B?NnMxb3BxY2xOZGRKVVdRN2g0Q1VwZU0vUW1ENHF3OVphYTdGT2JmRlByM1I1?= =?utf-8?B?TUdhRFBYOTd4dVEwdlc5L2hOQkJETHBQdk5PNTZuSXkzNzRjMExuWkpzRTl5?= =?utf-8?B?ZzA2bGpiOXN1U2lsa2YrZVFoMnJEUmNYdE1XaVViWm9UMG50MXltMm55QkFX?= =?utf-8?B?b3lIZyswUU41TXNJMDFmbC8weVVlM3FtaDc0czNkWEJSQXlVL1lScExLT0Ur?= =?utf-8?B?ZTlEUm5Lc0JqYThUK244ZFlLNUVJTnVMcUZhQ0VBY3JhZTdiVllrSjFMK3pQ?= =?utf-8?B?Q1UwZkNGaGt3WUZEMyt5OHU0NlUyeXN2WDUwZDJaMmd0N3R6OGdXNlFXU3Jq?= =?utf-8?B?bXhtd29CZGpWNG53enpCNkZScmJWUStic1dDdTNpbTI4RTdJbitiMTZTV3Ju?= =?utf-8?B?ajJKUHRGbDJkQTFZZW9IS1FQT09ZYXBPRnF5UUcySk1uSHBydThFcU9CMU9M?= =?utf-8?B?Ynl1SXJ1RTZwRjA4ZDhnbURJbUV1YzZoN0doRk5YR1VaRkoveTJjalBZcTA4?= =?utf-8?B?cEtmK09OUXNLbTloUHMvNXA3OHdGazF2R3I1c3hVM3ZaQlZZTjVuMmNhUWpo?= =?utf-8?B?STJrWXdKQ2puTFdMcnJ3RmtpOWlWcGxXVlV0R2lrL2o4dWN6VkRzcXJzSVlI?= =?utf-8?B?cFZYT3J2TksrempLMTNuSDAzYW5tRElWdXUyS25zaWZHZThKdi9aL1E5SjdF?= =?utf-8?B?bHFYSVhuTnkwZDVDK0VldmFrREVLZjNkeHRFaHdXRmM0a1dQTllhVmhXcFRH?= =?utf-8?B?c3FtUlhoWW5QUVZvRHdUcUhUcEV2SVlYRzJIZm53MStjUFFpZHl3REN6MjZw?= =?utf-8?B?ZkxKYjRhTDFIVDJsTUtIVGNaU2NqUnZUWTVIYWpCWmlOVk9vSUY3Z3VBTDdh?= =?utf-8?Q?q/tkUi77f2HokBjXW2Q3gM5Hb?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 901cf67f-57f0-4bb7-089e-08da6fe5cdad X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 15:36:41.6928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S7BoSLbg/s2SgfwXaEx9ufK5TiyIlFQ2x3qyzuS9/8NaT9WLC9XLBHBFpPuckjjDmFy+/EbBvrIv/gYh+j0B5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4931 On 27.07.2022 17:32, Xenia Ragiadakou wrote: > The macro parameter 'p' is used as an expression and needs to be enclosed in > parentheses. Yes, but ... > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, > } > > #define read_atomic(p) ({ \ > - union { typeof(*p) val; char c[0]; } x_; \ > - read_atomic_size(p, x_.c, sizeof(*p)); \ > + union { typeof(*(p)) val; char c[0]; } x_; \ > + read_atomic_size((p), x_.c, sizeof(*(p))); \ ... not in the first argument's case - that's not an expression. Too few parentheses are a risk, but too many are as well, as they negatively affect readability. Jan From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:43:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:43:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376290.608956 (Exim 4.92) (envelope-from ) id 1oGjBe-0003ra-OD; Wed, 27 Jul 2022 15:43:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376290.608956; Wed, 27 Jul 2022 15:43:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjBe-0003rT-Kg; Wed, 27 Jul 2022 15:43:02 +0000 Received: by outflank-mailman (input) for mailman id 376290; Wed, 27 Jul 2022 15:43:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjBd-0003rN-B6 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:43:01 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9591f8b-0dc2-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 17:42:59 +0200 (CEST) Received: from mail-mw2nam12lp2043.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.43]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 11:42:48 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by SJ0PR03MB6951.namprd03.prod.outlook.com (2603:10b6:a03:419::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 15:42:46 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f%7]) with mapi id 15.20.5458.026; Wed, 27 Jul 2022 15:42:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9591f8b-0dc2-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658936579; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=tPfBYACwUw/V8DzgjfYnPeUUskCCCURJ9k4kfqMQBFI=; b=LABtJv7PV2B5UFEkg3WJVlCOYbMNQwkN1k9pFcJsFOYemp5WEfKtZqpl PzwbYDsJVpoIQAVJY8w2/yM8KeBDTrDeWEb+8ER7UJkuu+ObOcyScvgw8 dnmdiqu05zGioaPiIM1HI94YB45b1MUPZjmZLLg60Bk/FNgyy98e781tl c=; X-IronPort-RemoteIP: 104.47.66.43 X-IronPort-MID: 79322944 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ob9V5K4E8W5tVW55mk+PoAxRtBXHchMFZxGqfqrLsTDasY5as4F+v mIdCmjVbPiCM2P9et9xYIW08EIPvsTXm4dnTgM5qn8yHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yM6jclkf5KkYMbcICd9WAR4fykojBNnioYRj5VhxNO0GGthg /uryyHkEALjimUc3l48sfrZ8ksw5quq4Vv0g3RlDRx1lA6G/5UqJMp3yZGZdxPQXoRSF+imc OfPpJnRErTxpkpF5nuNy94XQ2VSKlLgFVHmZkl+AsBOtiNqtC0qupvXAdJHAathZ5dlqPgqo DlFncTYpQ7EpcQgksxFO/VTO3kW0aGrZNYriJVw2CCe5xSuTpfi/xlhJHtxBoMX2cdFOjkQ3 voeLGlTUAuSoP3jldpXSsE07igiBO/CGdpF/1Rfl3TeB/tgRo3fSaLX49MexC03ms1FAffZY YwedCZraxPDJRZIPz/7CrpnxLvu2ia5LWMe9An9SakfugA/yCRT2b7gdv/cftWOTMNYtk2Zu njH7yLyBRRy2Nm3lmveqCj92rOncSXTfrBKE6Cfq69Qomaf1nABLBYxC3Clrqzs4qK5c5cFQ 6AOwQIkqrIz7wqsVcXnWAOjo2+suQQVUN5dVeY97WmlzqvS/hbcBWUeSDNFQMIpudVwRjEw0 FKN2dTzClRHsrKPTmmG3qyJtj70Mi8QRUceaisUZQ8E5cT/uoY1jwKJQtsLOKu0iNLyMSv9z zCDsG41gLB7pcQT/6y//F3B03Sgq/DhQgcr60PXV2S+4wVRYI+jepzu6F7H4PIGJ4GcJnGR7 CYsmMWE6u0KS5aXm0SlQP0ENKO4+/GfdjbbhDZHBII9/j6g/3qie4F44zxkIkptdMEedlfBZ 0veuhhY4pNJC2e7dq98Y4+3CMMCwLDpEJLuUfW8Rt9Ob4l3eSeO+Sh8YkjW022FuEomnLw7O JybWd2xFntcAqNipBK9QOMc1/koxyYx7WLVWZ3/iR+g1NK2dHOTDLsILlaKRuQ497+f5hXY9 c5FMMmHwAkZV/fxChQ76qYWJFEOaH0kX5b/rpUNcvbZelY9XmY8F/XW3LUtPZR/mLhYnfvJ+ Xf7XVJEzF34hjvMLgDihm1fVY4DlK1X9RoTVRHA937xs5T/Se5DNJsiSqY= IronPort-HdrOrdr: A9a23:pPJtgK0sPQ9zzYfzRdv3xgqjBEgkLtp133Aq2lEZdPU0SKGlfg 6V/MjztCWE7Ar5PUtLpTnuAsa9qB/nm6KdgrNhWItKPjOW21dARbsKheffKlXbcBEWndQtt5 uIHZIeNDXxZ2IK8PoT4mODYqodKA/sytHWuQ/cpU0dMz2Dc8tbnmBE4p7wKDwMeOFBb6BJcq a01458iBeLX28YVci/DmltZZm4mzWa/KiWGCLvHnQcmXGzsQ8= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="79322944" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mYyIyqkT3nc3AzJ35YZxKyTRoFGLnmuXK0ak/jMD99iCz4saej1LIme00TjRtS+m56Tb4mItRTsL8yX1TQzufHJ/+EzrwCwALAweaTg2GgfN/tTm7M4ZfCwCpRhy8b+Kf2UlMRwGAhE5ADEdOmRqnJ1LJyWKqRdogpGKcE42asZXtWFw9ZiBzJlmN2GA7TPITzlnXvMN7PlqmXhy6dg+czlG5NfEYdx3sdXAXd93M2v9FERzeL+4GUmHihcut+R6xfvevqt9NmuCymOBv3xWq1Ta2UEHJvEYO7445CuGgXFR7RMqiDMLpp6muW+e8e7gEIkRAPB9ClyaBRKJ12KPKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tPfBYACwUw/V8DzgjfYnPeUUskCCCURJ9k4kfqMQBFI=; b=dxBasgvD7PlUaCfKLWC+Sth3xIMMZfRiesALxYItE3DC7s4/XdmZx3gusWTJsckDlgerv6dEE0vtwI6gMMYbd7X4ufrIK3NDQFBSdHsWAuPD3PVTf+LvQV296YqEprkaqc3/GYIJEu0A/iO6KeZzmcF/vFJY1arBiSyHT7TH9HeH+dxlj41FiNHC0OB3uMubI96D+Ecb3LjI6pKbUgGxbNaD0aT5vP33a8rX0S6MRuJuw8ZZ7WiwDz39Gveirygom4TM8itTv08TYkm0ARfUl56My0g6j8laHYpP28ITFEUNEX+nV/64X71q2n9yCs0BJ/ZVa4l8poTNx00SaqtlJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tPfBYACwUw/V8DzgjfYnPeUUskCCCURJ9k4kfqMQBFI=; b=UQUtpQ796WjFVVwdfFj9d031wgA9UBi7lpcpKaV6z8Ay+ovQXLUmdLicxQyYHhYyTubATidrO+2XuWLLxm4iB3agEH1fLm2VHVhDvc6VVHJedTQ+Xkm2bInoIBakujXO2N5lvB4Y0JSNzloQDlDp/r7VpIFv2CzgULrZzxINsBI= From: Jane Malalane To: Boris Ostrovsky , LKML CC: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYoO9LZ/coQoD4ekyAV2OZDcw3862RTc+AgAEPVgA= Date: Wed, 27 Jul 2022 15:42:46 +0000 Message-ID: <31a17555-5890-9c8f-bd3a-371815453a6c@citrix.com> References: <20220726125657.12151-1-jane.malalane@citrix.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0232b356-1cbd-495f-5273-08da6fe6a759 x-ms-traffictypediagnostic: SJ0PR03MB6951:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zMR1ZYNO6OessrLF37DoDcRp3+i7BYown6MZQSkFJTYtWgA8sMiYRtCdRo3lRuxzZRz9a5SFoODKObSI3GGV1zhIWCgnU0wZp0XZPQLjtnjQDTZbKZJg2MUsHrXeUqw7+xN5lP4GVD6Ey8qr8XnKrtDTmBMlkHwf66qctSQQlxOqu8tFgGrK3i9VcDFDRSeBdQUvKp8RSAubulRT+f3zV8w1rFqg+t93ZwQmDZd6EA7hvMoepiY0HAGTEO6PiiCvtnWwcYse/nQMzMVsgTsIv9eHh4az3FY7H69acMeSAsMXO8WomURAkxzbjCkufBdaHe+It2jq63lzzoq4/qOLMttI4yYpJ48bJB0BClQ6b9UyLsNeJzIjRnXOh3ie8pw4mxnTgak79j+6s6B8xa6kqMWqFiB6EGbFk44fS0LMyLJRtlt32IXhAezRMk/xiaXdY48+t/KCIa7c6nhY3fGdf7xPM9JEQyBkUnUc4m7VBU6q5X6dEjYX/V3K5TQUWsMsEYuF2YjiVzonLrGaqUf85R6o82vjjOSSiSMRqHqDG4g2ws+TCIDipu70eaQ7yCOHS+8IbJS/UWnkkhTwZJw9D4l01BtLx6nGQPzIZ5CFD5Z7/ZqgUr8Dd+LXiwiksbs1UOAvaSCzeCqkgutOeHTvf9DSvydN2AgWeZ76QJuT7Fsz5GtnHoZeBaxnpk9m+EBgmALT4TB+i95Hh6+Kb2Nb2aSkT2zlojVjEbdGSzjYQaqEXRUh/me3ybwUQudsbbJ2aRlmCnFe5KwxQqKUX3CejaVrMikcJvXWepnAE5u8wV2kNdG87wX9Mc8jsUL7nvGAxkjxjkrXB1EyCPbGWbVqbw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(38070700005)(8936002)(478600001)(6486002)(76116006)(6506007)(7416002)(53546011)(82960400001)(31696002)(122000001)(55236004)(2616005)(5660300002)(86362001)(36756003)(26005)(6512007)(41300700001)(38100700002)(316002)(31686004)(83380400001)(8676002)(64756008)(2906002)(66446008)(66476007)(4326008)(54906003)(71200400001)(91956017)(66946007)(110136005)(66556008)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YkZzQmV6R01kaDRQQ3RzN0RoU28zeTZ5VzVZdmJ5T1A0Ui9HK1VuS1RpRU5Z?= =?utf-8?B?cHB2S0I4amRNMU54YUt5dWQ5SGswZGFxYUVZdWNUQTFLRVVabUM4bjREL1pv?= =?utf-8?B?N2ZDMDV6eEZJVzEydW80TjU2RENZYlBZdDl5bGdmZzNOQ2lCcWtteUxuWk9Q?= =?utf-8?B?NmY0b2VjMkYzMmZYeWJ4Y0VPenltb1Y2ajdQN0xNQ3VqSWJCVkN0VkJTR1ZV?= =?utf-8?B?RlJUL0w5M2hodWlFWVRnSEp1Z1VRQnJ3Q2toY1h1TXV6ODhtOHREeWt5cFdW?= =?utf-8?B?RFdIYkEyM2ZEUzVRSzM1dnRSSm40MitRaWdJQ1VrVlhjd1F5Smx6K01WcXJJ?= =?utf-8?B?SkxQTWd1S2tDVThSWWpZRmZqd3I1aGRkRjc1em9tMUttdXRmQlBDV0RaV0Jk?= =?utf-8?B?OVR4akdueUNKOWxwRFBjaHZmUXVCZjU1MFJ3QmF3UU1UYkxObmdnbU81UUpJ?= =?utf-8?B?OEFZUTllcHh3ZDdUd0w4dkVPVkNQN2NWZkIwS2Q0Q2FNMktxZTRYaXdtaFpF?= =?utf-8?B?QW5Vd1NIU2IwbmliV2lDSUtEZzRzcTVRQ0VvbmF3bTFQaXhGNHIrYk03Lys4?= =?utf-8?B?QVlJcFdBNkNSSHZzb0RqZStGR2IvNEl0c3M4aU5IUkh4ZU1BUUY2cHNJYXZG?= =?utf-8?B?QWVuS0xWTERjK3U3dWVCdFY3WFRIZHFMNk11REJjeHZkdmdFWGhycStCMEtS?= =?utf-8?B?VW5TelFhbitmbndScVhFRkt1a3lHQ3Frb1ZrNGxqY1RObXZPMjdNNVp5K0RG?= =?utf-8?B?ZFBUVWdUWC9rYjgyelFSeFFSOW5RbUdjMHJ4RmlKMzYwTEwyYkpIWHRBZGdm?= =?utf-8?B?VE5LVEFVRTE2ZTZ0Sk5vUzREWXR0c3NUYXlMSUR0UkdTelVKMFp4clpGck5N?= =?utf-8?B?clREK0RIbC8yMzNxUDlvUlArbmx5NXVoR0pxaXBWNmViR3A0aG1EN2dUeXVN?= =?utf-8?B?WFQwa1dtNXA5ZXVXb1pXM3I0YUtKNU5MTklZdVNUN0gxYk5yM3BwYUFHbWFj?= =?utf-8?B?REhKOFZZeE9uS3RwNEd3NldITGZYYXhGWjJ1V3U3aVc5TU1oSXM4bFpNcTBB?= =?utf-8?B?dC9vZGZoSEI2NjlldWxlNW5CQTV2L3FkMVlTa09jVnlvMHBWUDBieXhhRzJT?= =?utf-8?B?ZGRtWFhWam1EajlLTnEwc1k0bWZtOGxxZXM3aUlRZ1M1ZkgwQjFtL0puRGFa?= =?utf-8?B?cTYzRWZPZ2FKSklQczlDenJXQ25idk55Q0lLZVlHYmJzaUoySjI4RWV0N2Uz?= =?utf-8?B?WGRXK3IzWGxTYStnc1RGaVFuMlc5eThPSENia25TWTdwM0dvaFVxMFNsZjJH?= =?utf-8?B?VkpSQnU4cGZTaGErcE4yQmpEdjgrN2l4azNNRU1Iai8wRnhJSzVoK0NmWHdm?= =?utf-8?B?aU5mYUIzN1pUenk4TlZnbUtIelloL3hwbEo3ckNzNEtqTEV1a2RUWS9RaGtZ?= =?utf-8?B?aHFEYW8wZjJ3amdyS2FlcFJITXBzYlFsWnZReWF2UWVYTVJnTXd5TVFGMDJo?= =?utf-8?B?cS8zVzNPbW5jTlZXdFhPejU4Q3NxR3Zyc3FwNkQ3VXlydlc5aXdaYmxYZUFF?= =?utf-8?B?bEticzhKdVdQdUFmSGtLR1RXWFNOclZSbmVuSmN6Uk40ek1TRmlYbTZXL2RY?= =?utf-8?B?RTd5UzZwMXB3VE5vN1phVG5IK01vZ2RzSW9MT21tN0w5QnV6bjN6Njc2SUdm?= =?utf-8?B?L2ZEVmJjbzZRTnVMMFBqSXFMMEF5aFA0VnI2TXQzaGk4ODVuRTlZekpWVmxG?= =?utf-8?B?OTUyM3U1cG8yclo1WlN1WklYdXNQNjRXeTBzQ3FtYTFMS2c4WXpQZUJhczJ5?= =?utf-8?B?b2hsalRZSlMwYzBkT1loSXJibXp0Q2swOUF2TXlQVGhTOExxMVhkdWZqS3E3?= =?utf-8?B?ZUN1T0RCbzZzT2crcWRURUVsNW5pTk9TbUpFVTZPWUpibG5reTFTb3gvZEVN?= =?utf-8?B?S2srOFNMNUg4Z2ZWRno3clNPejlZWEZWM3FuN0xFeWFnanliNVBNcGVWQzdv?= =?utf-8?B?eFE3UDBSeGRSRFhWUDlTZ2pTL2VJWHJqK0ltN25HOU8ybEFoR1FaM3RST1Fx?= =?utf-8?B?eWNmcXVacEc4Wk9HYkRYaWZVZFNDOU10ZXIyNHRHZDBXOGl0dnBYK21ORkcv?= =?utf-8?B?eW1OL1lXK2M4dklKYnlDMmVPRVNBOWtobVE3dGRmTW9acXEvRWxuVUdPcitp?= =?utf-8?B?Znc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: <827104CC019BAA48BF1E0C5F8EF4DBA7@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0232b356-1cbd-495f-5273-08da6fe6a759 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 15:42:46.7000 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0yVEPX4byjyShqv5ZGB++6DB9Nm9N9bVPNHWtR7RsffwXrkA1/jwH4I0bXzBo3mU0H9qJlm/AqMPQOOdGymB0YpCoV1rJHOzhqq4kCSlYsE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6951 T24gMjcvMDcvMjAyMiAwMDozMSwgQm9yaXMgT3N0cm92c2t5IHdyb3RlOg0KPiBbQ0FVVElPTiAt IEVYVEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIA0KPiBh dHRhY2htZW50cyB1bmxlc3MgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0 aGUgY29udGVudCBpcyANCj4gc2FmZS4NCj4gDQo+IE9uIDcvMjYvMjIgODo1NiBBTSwgSmFuZSBN YWxhbGFuZSB3cm90ZToNCj4+ICsvKiBTZXR1cCBwZXItdkNQVSB2ZWN0b3ItdHlwZSBjYWxsYmFj a3MgYW5kIHRyaWNrIHRvb2xzdGFjayB0byB0aGluaw0KPj4gKyAqIHdlIGFyZSBlbmxpZ2h0ZW5l ZC4gSWYgdGhpcyBzZXR1cCBpcyB1bmF2YWlsYWJsZSwgZmFsbGJhY2sgdG8gdGhlDQo+PiArICog Z2xvYmFsIHZlY3Rvci10eXBlIGNhbGxiYWNrLiAqLw0KPiANCj4gDQo+IENvbW1lbnQgc3R5bGUu DQo+IA0KPiANCj4+ICtzdGF0aWMgX19pbml0IHZvaWQgeGVuX2luaXRfc2V0dXBfdXBjYWxsX3Zl Y3Rvcih2b2lkKQ0KPj4gK3sNCj4+ICvCoMKgwqAgdW5zaWduZWQgaW50IGNwdSA9IDA7DQo+IA0K PiANCj4gVW5uZWNlc3NhcnkgdmFyaWFibGUuDQo+IA0KPiANCj4+ICsNCj4+ICvCoMKgwqAgaWYg KCF4ZW5faGF2ZV92ZWN0b3JfY2FsbGJhY2spDQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0K Pj4gKw0KPj4gK8KgwqDCoCBpZiAoKGNwdWlkX2VheCh4ZW5fY3B1aWRfYmFzZSgpICsgNCkgJiAN Cj4+IFhFTl9IVk1fQ1BVSURfVVBDQUxMX1ZFQ1RPUikgJiYNCj4+ICvCoMKgwqDCoMKgwqDCoCAh eGVuX3NldF91cGNhbGxfdmVjdG9yKGNwdSkgJiYgIXhlbl9zZXRfY2FsbGJhY2tfdmlhKDEpKQ0K Pj4gK8KgwqDCoMKgwqDCoMKgIHhlbl9wZXJjcHVfdXBjYWxsID0gdHJ1ZTsNCj4+ICvCoMKgwqAg ZWxzZSBpZiAoeGVuX2ZlYXR1cmUoWEVORkVBVF9odm1fY2FsbGJhY2tfdmVjdG9yKSkNCj4+ICvC oMKgwqDCoMKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+PiArwqDCoMKgIGVs c2UNCj4+ICvCoMKgwqDCoMKgwqDCoCB4ZW5faGF2ZV92ZWN0b3JfY2FsbGJhY2sgPSBmYWxzZTsN Cj4+ICt9DQo+PiArDQo+PiAraW50IHhlbl9zZXRfdXBjYWxsX3ZlY3Rvcih1bnNpZ25lZCBpbnQg Y3B1KQ0KPj4gK3sNCj4+ICvCoMKgwqAgaW50IHJjOw0KPj4gK8KgwqDCoCB4ZW5faHZtX2V2dGNo bl91cGNhbGxfdmVjdG9yX3Qgb3AgPSB7DQo+PiArwqDCoMKgwqDCoMKgwqAgLnZlY3RvciA9IEhZ UEVSVklTT1JfQ0FMTEJBQ0tfVkVDVE9SLA0KPj4gK8KgwqDCoMKgwqDCoMKgIC52Y3B1ID0gcGVy X2NwdSh4ZW5fdmNwdV9pZCwgY3B1KSwNCj4+ICvCoMKgwqAgfTsNCj4+ICsNCj4+ICvCoMKgwqAg cmMgPSBIWVBFUlZJU09SX2h2bV9vcChIVk1PUF9zZXRfZXZ0Y2huX3VwY2FsbF92ZWN0b3IsICZv cCk7DQo+PiArwqDCoMKgIGlmIChyYykNCj4+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gcmM7DQo+ PiArDQo+PiArwqDCoMKgIGlmICghY3B1KQ0KPiANCj4gDQo+IEEgY29tbWVudCAoZS5nLiAiTGV0 IHRvb2xzdGFjayBrbm93IHRoYXQgd2UgYXJlIGVubGlnaHRlbmVkLiIgb3IgDQo+IHNvbWV0aGlu ZyBhbG9uZyB0aGVzZSBsaW5lcykgd291bGQgYmUgdXNlZnVsIGhlcmUuDQo+VGhhbmtzLCB3aWxs IGluY2x1ZGUgYWxsIHRoZXNlIGNoYW5nZXMgaW4gYSB2My4NCg0KSmFuZS4= From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:43:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:43:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376294.608967 (Exim 4.92) (envelope-from ) id 1oGjCG-0004M9-0N; Wed, 27 Jul 2022 15:43:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376294.608967; Wed, 27 Jul 2022 15:43:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjCF-0004M2-Tf; Wed, 27 Jul 2022 15:43:39 +0000 Received: by outflank-mailman (input) for mailman id 376294; Wed, 27 Jul 2022 15:43:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjCD-0004Lj-QF for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:43:37 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dee9e17d-0dc2-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 17:43:35 +0200 (CEST) Received: from mail-mw2nam12lp2041.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.41]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 11:43:31 -0400 Received: from DM5PR03MB3386.namprd03.prod.outlook.com (2603:10b6:4:46::36) by SJ0PR03MB6951.namprd03.prod.outlook.com (2603:10b6:a03:419::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Wed, 27 Jul 2022 15:43:29 +0000 Received: from DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f]) by DM5PR03MB3386.namprd03.prod.outlook.com ([fe80::81f3:95a3:4853:a11f%7]) with mapi id 15.20.5458.026; Wed, 27 Jul 2022 15:43:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dee9e17d-0dc2-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658936615; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=lmlnHnArL5v80qKyMZxUKO3fUF2TRhOSDyN3EhMWdb4=; b=ManXEuJeQvuR6f9bKLBdXdazabBaKanAfVJV8ATTUoVT4budB3rb6/5s o559A00hT3Jch8nd/aZMeKdGpoMrGw5V3DEGGzfchYUIjess7boE0lTUW yttk0esLqr8WMwalnk19IfOiojR7ZMZQed5OZ1D6xBBjtVVnqvxoCag+S s=; X-IronPort-RemoteIP: 104.47.66.41 X-IronPort-MID: 76754590 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AcGuzb6nLvUM3QxzrwbS6JRTo5mJPLRN5O6RN2?= =?us-ascii?q?KgSYk/6f7AAGkVYHNDTQj8QOYZgVIWol2/guFWZSjo8ma2h7z6V58zBmKLov?= =?us-ascii?q?MHZLz/hCwAjLFrumKVI1MYEijjmPTMeGCDMwYJHjcJ4hTM8yHf7I9go6H95Y?= =?us-ascii?q?m4D+coK4wL/vp92hpslD/CcOo0iTCjEeD7LRE03QJR7k4hxYSy2ynPwDMIB7?= =?us-ascii?q?Yc2rRYlHjFXn3EHS/2jeaZwGCri9WChcjAt3GOYxiobk9pZHGqom3mgc298I?= =?us-ascii?q?9bnPcGthddnImpEkKiO1GxVb+5kiVcUhbufMay+/YvHNhabBeoxqrSjg7gxb?= =?us-ascii?q?sBMzdm+6S/PcIv7zb5ueicxYu2GyZe8BwF0WQuKkcaDQBWj7Nb8Rh/LF3RuV?= =?us-ascii?q?V/5wrhd/j3STLDlBacXM58wqJsypZ4FjIkaDJ4vmZCD0RD6xwQibBkck/Vos?= =?us-ascii?q?8hkQPB36X4vxIUoeMz1++2DBsJbpyemAQVO00Q2cJjmr5JJBi0AL6nvengMx?= =?us-ascii?q?8iiP46sZqh0azHr+B9iS9LvvOSfEu6imiuEBVwr1iKD7W2RgCsOFOAw5eUJN?= =?us-ascii?q?s+nARPwn5W8l2f8Txk5GymnG1lYnjYEibsZ4dKfZL/tbunkL9FHDFpBCVLDd?= =?us-ascii?q?jOoPerY82IJyCm9ekxlMHqhinIA1HvgZCctcHfLAwVVC5Xj59OBvIMhApMb2?= =?us-ascii?q?LJQH3MGJ6TY/rhHPZQ43PDaaNbN7/j+NwxU5PQh1+EBC7qpWEIsrEzF0fUK3?= =?us-ascii?q?AzZ5xRoGZYmDyVjvSl1fZywir9x9a6o5bmTqcmdTpegJF3OOTore30OHRlml?= =?us-ascii?q?4OaQb0HHtZzmF4TsLxQQOX987K1lSXh1VMn6L783ZnfS58ukROhNj27dMyuJ?= =?us-ascii?q?bcZrZ9BeLOqMAjy2sgf7HkUBeQ029Z9bDEit1yLWUZoWkQId4vMvbCpGoggn?= =?us-ascii?q?Ssl8zE23tsvEmNDAssbzgnaoNevrs16cmNVT4Tig2BZpF0H75ZSDiCunK/fK?= =?us-ascii?q?nksORDgXOVlQPNmzaY01TCum3ql8xdJIIt4ULEOXCl77ifSFYzJUfMP7ABzh?= =?us-ascii?q?JdVcxlwuHlk2Wjx3V/rJJYQ0EcIu1yxgvLt5wUb6Huk6mefMZrcrZzVqtn/G?= =?us-ascii?q?08s6y7Gd72rx8YxD2HZSz6IfD2tI9cyteJ4LU8FZJzBXtOApNuu0Ic1Y1jBV?= =?us-ascii?q?0W6NeD82qsq08FcKZe321wAPsijT5szlSGvlgTfY5Vo0p1sanQKWYCeibW7g?= =?us-ascii?q?NowFuzfDmySQzWWJJ88GjdLSXs2kFyHabRfqKQq5loe0Klxfqup8fQxpPGbf?= =?us-ascii?q?vwDIawbSir2DX80aQE2cv7D8wVUqRlZF2ptXVNQQBiAxXJREkN+vBG7cTQuB?= =?us-ascii?q?ZNTRrvz0w+YFifrneM5t0bJDlGVDnD3KWyIS7Pn0Akr8L7J86AW9AeEuXRA7?= =?us-ascii?q?asrM3vE4ncsl2Im1XOeh+P7tC05ZBeUWDcYM3hSzWswD9XuFbmknhYJuykmn?= =?us-ascii?q?aEYTD0M18PPmWk+ud6+nO32ii3zL/qOhFdqr95VgbcZqGMxHhJU8OVe8TmeP?= =?us-ascii?q?ogqG44PMHHi0O5ZX6RiMhsSuJxAdlN8EBVhcYPZ1KRmYaqRAkfElQL4+TGRP?= =?us-ascii?q?DPvoRk3gCMPDYbFIbZR7VlwHPfVqhVo1HWz+q7lllPYf33EYyfQyJe50Kn1w?= =?us-ascii?q?h9UsV0QAatCswe1sKCWh1Au9dnhcThTT2TP5JaYz/zimI9WOHZaPCEd+g1f0?= =?us-ascii?q?YpatYLL+G/vsHcnZrCejK0FZFluIyu4Yio7QH63KXoq4Iopx4IcxmLL9DPQJ?= =?us-ascii?q?TdJA8mu3491PVkIi/VHZ3277CWC0vHD0ObI550Joasv60aO//aP8A4fFXVJo?= =?us-ascii?q?l5mEyyPJs2iFoVcXL0gSrvd+lnMlfmI70RM3PBd6Cuv3QdYs4eZmmbCYUKNU?= =?us-ascii?q?DSL+yok+7d6vJHB8Na1O+pCYmMhxNokBrXW1ZcHA5YFds+mpbWcAOXsxU6qd?= =?us-ascii?q?U9HzSYWpOXZZ3CPFy87MQvxfpfrkcFAlNOZhnrqmj9pgdJoCXsDzi32JC0DP?= =?us-ascii?q?JG+hebvio8NrZlug3bAEOKDYA06pjysBtlHGKwsFC4HWwncYwJrMGR+JL30b?= =?us-ascii?q?kv7uo6LqY6CxA54I5D32+mly3Tn5utEpy2bnQLYmji4NRzOhDy408vVvlSLQ?= =?us-ascii?q?DQgCETZgRg3azWFimzxbNwebOxBIAC+B9cUtJXC66LVtobACgwUYJkk1CKVs?= =?us-ascii?q?BYYHkYWCOqksSM6Uz06D1bL/Yjv1qDYWeRjUb9YNQOKfyaA8Eb3oKPrL/7bW?= =?us-ascii?q?bfuSYc0xMM4Z0NuOuJe64Aa0PtTcRYiJ8UsMWzfsDn7s5Bz0c7ipBBV8RH1G?= =?us-ascii?q?Bzm4f8T/KN3lBgfSUR/bVdFY4FHfP4CnrADGTFdigVsCy5pK4IanBbrVMLei?= =?us-ascii?q?Rj/U5qyvhDKukvXqNTl3Mth0pztivm/oreZuAbjjTi+ABETBRnrcCuazesSk?= =?us-ascii?q?CUHM795D4YTfBfUj4+iqT/dW2nKPgw/WiQV0Mi4kR8GnslyM5Oshu0RjtZ9t?= =?us-ascii?q?ZU9jH6AsGq2QG3m5x9AlFS8wXp0DuelkeXCz+G+Z5dK5F8vpMUpAlKcBha/P?= =?us-ascii?q?t++g4JjgmYyb2AcwoMR19c7J8YiuotIJhAnLSlASEWtaiZMP9o5Oez2nq+D0?= =?us-ascii?q?rOS8EOTZS8PnjFE7m3TQd+yUwkDIAppM0oYWpcQV6/AwkHCUljwkzh0M57Vt?= =?us-ascii?q?Wdyv5u3A4cYJjt/5BsIoHaZHD65m9YPA7nw1CyMLZ7cp4IqNoxUdXeaT9TA9?= =?us-ascii?q?j7O3dClLiuY2u+V0LmL2LF9wxGGuS6W/oGoA4DBqGLlaSpaJ7aGGW7FoptIP?= =?us-ascii?q?TPxwIaDf2I56OkdifLZ3HCiIGbPUNmoWOipiewuwwqsuLaAMnyAX/U6LKyFO?= =?us-ascii?q?yF4zyXIlBM7lOt2sE18zDpgIZdir9W72Q9BXXcLwzII48ado0/e1gcyJGJN+?= =?us-ascii?q?BgGG0rGKBU9U5kYiFr2khmLwr9wU3NW9PK+yvukxjrIqhBqAr9wS2nQlPImM?= =?us-ascii?q?FN1p5CQLZ18mcPi64kMAO+JR1poHxqG+H+a+14BAIzC3tRW8QXSFh1PhGk5w?= =?us-ascii?q?/+2znYFRUykijU7fs77glHlUjY75k8OvK30p2HvjFk65rPgGvDJY3luGKZxB?= =?us-ascii?q?2LC6diq2tbE9OlqrOB7+Eo1JDV8FaUaZBFOFd4OAMoo2flcbvgcbYFGeSfE9?= =?us-ascii?q?I+6vg=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,195,1654574400"; d="scan'208";a="76754590" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L20fj5+G8DQqAVfiDEDzSA4jJp4ARy59J7N5eThtmCupTHsXJFrrX76RBfECQHo7O3TrRAILkvCYQWKdiK7fRw9/LfKhAfXuTRhme4tnDyPH9kbZQbmnI04GePGSJU2+23xEsMA4CCw/y0rcfAVnxAMmK6FhvaY6LuLmM6+VFJoGDlHm9uchqKpCsqjEUg256GAYPpD82A2gPVFMy/Us+eBctukbUAXFEQx1yP4TnBEPkIWT599eO+Oiab3lGQTeTfn15AvYejptfGc0nftuT58zL+ZfP/6q7H9aj7N/mHNuKSS1wB3Iu+zvOixaAmJjGgNasHRJk3w/9gZ57J4opA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lmlnHnArL5v80qKyMZxUKO3fUF2TRhOSDyN3EhMWdb4=; b=Z48fT7NFStzGeEWfJxJEminx9rGITdKcHUixM3Hz4rpVWzxt2fGDhNYDiaMxg1fx/02O12LvpOL00UmNMctrDVMteahzO8thcksSY8th9wwf+8eLZwnqN0wBMzHDb8tmOGAIxNTF6OKjk/YnwUcl3+tkFt4mmVFIWpBQNzkXCXN4MzdQDZjcFxgDbC2p3AL24pMeajWeyIZZIOsALlwfAtDv/D7QW6A8/ieObR7pr7PnStJKcrWk90TShSQW0GYmd3o4nxibiMeeGfhF5d/oYw5dwczxrWJxX8XfeRiQ/yqw4lkoCq2aaTP4WZDGgdgEZ8iDcJ3N1Rk/vck3XpWo5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lmlnHnArL5v80qKyMZxUKO3fUF2TRhOSDyN3EhMWdb4=; b=Tu4l40y7jTT2mUK8oRh4fOIzk2cO4apLcYGXs8qY/qzZPPyzsF7TC3xWQpw+jBusXkYg2i3HXcg7Mycab1NpMYvQIMv/+p7whAh0xQNDMdgyphaz8UxBO8ed/cmiS2rgMXwI52Mw7qLhSDSNon+z0dO+9ZIGE5K5wpm2bROAmkI= From: Jane Malalane To: Julien Grall , LKML CC: Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Maximilian Heyne , Jan Beulich , Colin Ian King , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Topic: [PATCH v2] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Thread-Index: AQHYoO9LZ/coQoD4ekyAV2OZDcw3862SKA0AgAA1ToA= Date: Wed, 27 Jul 2022 15:43:29 +0000 Message-ID: <5524b096-e7c5-5b43-eb32-66cc32d9c70f@citrix.com> References: <20220726125657.12151-1-jane.malalane@citrix.com> <51ba135e-a105-036f-b891-e7d9e1bb607d@xen.org> In-Reply-To: <51ba135e-a105-036f-b891-e7d9e1bb607d@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fe9127ba-0b04-425e-03ce-08da6fe6c106 x-ms-traffictypediagnostic: SJ0PR03MB6951:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XMTMLfGIU3fwMCGdyIHq1GQviXsMmyr2HRbqgxQPkj0mnZOSBu9GkHUQFFqqmoYCn2pUu2O42Qfo0oAhPUZLs8ApD11YS8LKxWTLkgX6d7vKe50oc4gZ4Bpo2xD7eWhN0z7C8cPfbBrzjHpb6gM1X0gMI2U7xy2WysETedPSQESDbbchrBz0Sen69cyhAgDY/t3qNG/AJXyNavxRzJ7UXL1BaRS0WG4oxQA7qok7GqxgBhl6acc/3w18SFs5QGzugYyVz0+mNRiNuF9zdVuP4ZzeVYrUm0i5Hr7jSPP2JOPxeadP4Wqc70jpblegpFNEHZrDQYT834+QHlAIQMZctcMAqMnwvCgMkVx7AoGHZw7dVTiJ5SP0NrYvCm6ociCC11/hsO+GUYdjK5FUHFnW2mkulD+2q/Lhgm3lLpiFtxztnfz2/OGTZiN6PY0P5sY+/sWxK0B1hoKNUeHz84ybaAcdre0hIt6OzU+v8FV2bOxvq2bcH1A43tF0yrdmCE8MBFdNaMM5pMvhGLbF+n6NwQnQ8MRGeiEbTmyeG/mbEpyYi8wlQkZGV47MazSw1CvbhRq8qUuJAJO8Fsq5ISh7TYnwGtO13MPBICtyTZx5XWG+NWZqO39/5rIBbXyuRydVPHZz6FYfpzL+4H4QJLMXveRtKPoFOgCTgANz9pW3orEzBQplPFLNY7Yf+9eBhtrA7I4obf62qvDasT4JadUqS57Fnv/8zKwXXh9fWaoqlMDCdldm9Alvg0/wn1VDRmmuuRN3JAL6AEcIjafLURj6u5O51wPamiul5DOeRo5Lymlt1HkEFP3yCHFPFUIp0oJzmze1qcL1sZIl8HHC8fVOnw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR03MB3386.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(39860400002)(366004)(136003)(346002)(38070700005)(8936002)(478600001)(6486002)(76116006)(6506007)(7416002)(53546011)(82960400001)(31696002)(122000001)(55236004)(2616005)(5660300002)(86362001)(36756003)(26005)(6512007)(41300700001)(38100700002)(316002)(31686004)(83380400001)(8676002)(64756008)(2906002)(66446008)(66476007)(4326008)(54906003)(71200400001)(91956017)(66946007)(110136005)(66556008)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?THhNVlNIMzR5bmxDZVByRWRVRm4zaVo4RVZyOXgyanptZkdneng2NXRkcDdh?= =?utf-8?B?RlJLVVFDSUNRZXFUWjV5ZnhOdC9aK3ZEZXpBWXBjK1JGTEFXdmN5RFlGdmpT?= =?utf-8?B?SEFzS05mZWo0TVl0MXhJOTdmL0dZRlNEUlFESjB2QVFLMjM5UVRxQjRTVTlt?= =?utf-8?B?NTFTMjZGWkthL245RXM3WDdQbjFmOEhoNlc1VldqdkxpaWpEazgzamRDVU1L?= =?utf-8?B?bHNrTkpjYUxEMGk4bzljbS9ZT0VNang2eGlQNFp3ZnU5R3QwQmgxZ2xJL2dM?= =?utf-8?B?UU9ZUjhYVHptc2dnMXphSkp6R1pvZnRoMzB4cnJJYlRMOHU3anM2REpoQVhG?= =?utf-8?B?T0Z1MW9Bd0VPT0sxNXJtTG9xN29nMExSaG1QdnFlOU5meVducnNmOHB0MTVk?= =?utf-8?B?VEI1Mk8wZHVrVU1vQmd2VFZBSEU5Z21DMGhqaEdrNjVPN2VTczhEekhnMEQ5?= =?utf-8?B?QjJOcG9FVE1xanhsMGpsVmIxREF6WGg5SGZXbElCWm1LWjFrOFdLOVJWSFdw?= =?utf-8?B?SVVUS0prTmRLWHA5ZStoT2NpWDkvK0V0NnhxYURyOVJOZkY3QWJ3a250Tm1J?= =?utf-8?B?V2svUVgwWmI3QUtMSEhkOG9Lc3FHWEtqb3N4djd5YXczbG5kMnpTZmdkSGpB?= =?utf-8?B?SVlIWVdPaTRncldwNW1hRDlIVXk3d2V6YWJGOHV5cVZUTzdOcXBQRk0vcHRG?= =?utf-8?B?K24wR1VUUEtQS09KM3cvWWFxeVI0RlBDdFB3cXUzWDZzajZoQjd1UUhtbElE?= =?utf-8?B?V3N1Nm9NUlVYY0RreitXSFJ6MDMyQXEySFVHSHN5d0NrQ2ExSVp5eVJWa3Vp?= =?utf-8?B?d2hnQ2hHWW5NUUNyc0hYL3psMDFWajZTdFlua1hrby9WdUFuRFJtMXJLR25N?= =?utf-8?B?QXRZSG5IOXp6TFB3MzNkTDBvdkZEL0kvelVndnV2WmlzQ01zOUNQMFFHS1ZN?= =?utf-8?B?dGVPdWw2b2kzMVVFK0RRN1RETmNsV01zb0JLQUh2RlhyU0RIZG5CU05ONWZF?= =?utf-8?B?dEQwTmZmaENBUVdDT3lCdzZDdjk5NmlQKzlvWW5LNG44dndqT1BTcW5SNCtr?= =?utf-8?B?d3ltQTY2YXA1QzloSHhpNHBTWmRiVzI4WnZJSGM3TEJkbHg0YnBjUHUvSEwr?= =?utf-8?B?SVdsS0d4Y08wMFY5UXlWenhrQmVxcysrOTVkanlvUnZYcWpyMVhYRXlRVkpa?= =?utf-8?B?UGtuVW5UOHJYbWdqRWhRRTNPbzRXbVdBdmxPN0FQNjljZU5OVGdmSkZPaFpB?= =?utf-8?B?WHRrMmVaZDdVOWZOaGhERnluaU5qSm1sTmJMZGFtSUlMcjFQWlV4M29TMXBG?= =?utf-8?B?UFk2K3B0a214WDUvQmJQMFRhVnFyWlBoQjJhcXFNTHdCVUlpYnV0UDdXZHBh?= =?utf-8?B?eWdSRVA1bDhKSjNEOGR3cVgvMllqWFJJblBpT1ZXSnhOcXVRMHA4K1AxakJU?= =?utf-8?B?ZS85UlRVcS9qNDJRQTE0UnlsM2VQTDNsNmY1TC9MeUpDMW5kUjl4T0UxWnZJ?= =?utf-8?B?cHdmSEppaFJlaDZ0MGZxZ2pibFNLZDlrWjZoUzZNY2V2cjQ4c1F3Y01xRjBN?= =?utf-8?B?cTNKbnJONFFtS01ZanRTcVlYbGV3RzVReVpaRnBiTm1YeFJXamtQOUwyeXpF?= =?utf-8?B?UjVPSWEzdms5RGlDalBkYTdyQTFmM0VPaWFQcGNFamFaU0ZwTittRkFtWjVU?= =?utf-8?B?d3dNL2hzTC8veDhOZlBVc3E5V2hnOFU2THZqUVJpWHUxclU0R1RETnhJd1VX?= =?utf-8?B?OUxzcGRHUm9Bd29INVQwWmV4YVdSNjVjUldoaE9Hb2FIL3BWaml5YmJQamUz?= =?utf-8?B?cGNVajM2RHprNm1IT25PcUV5SG1PVE5aSDg4R2lqdFFaWFI1UkgvbW00cVBP?= =?utf-8?B?eFJZMHNNQ3FHZWNMVVViV3AwTFJ0MDdseDhNTmltcklaQnB2Skk2eCtiVk01?= =?utf-8?B?YlNSMnlUN1pqZTBMRjdtOUpCQXdPMU5LdHc5OCtRdzFhWG9GOURkRzhPR094?= =?utf-8?B?R3B2clFpbVlZMWxFc29yTDJFZU9tRHNnT1djM1R1RDh2eTR1T3o1VEJPczlF?= =?utf-8?B?T3pBZDFBN1BuaFU0TzRhcllOcHIxakpLVGY3YXdSQ2FnVExJK25FKzAxNzBO?= =?utf-8?B?cW02dTgvVWRpcTl1bS9hOVFkRkZXelg1dVN6UDFLRlBHU1MvUC9wenlOa2Ru?= =?utf-8?B?YWc9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR03MB3386.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fe9127ba-0b04-425e-03ce-08da6fe6c106 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 15:43:29.7748 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: uDVEaXBpzlGRwrCjJD+220HQTtkn6sSsdVnceeHP+7U4rYPAS/j/2fDDwkm3xW5oUueBVeEbs4yx2PqV2CFZ+XI8Wi3T/+pHsajLBsozqf0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR03MB6951 T24gMjcvMDcvMjAyMiAxMzozMiwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KPiBbQ0FVVElPTiAtIEVY VEVSTkFMIEVNQUlMXSBETyBOT1QgcmVwbHksIGNsaWNrIGxpbmtzLCBvciBvcGVuIA0KPiBhdHRh Y2htZW50cyB1bmxlc3MgeW91IGhhdmUgdmVyaWZpZWQgdGhlIHNlbmRlciBhbmQga25vdyB0aGUg Y29udGVudCBpcyANCj4gc2FmZS4NCj4gDQo+IEhpIEphbmUsDQo+IA0KPiBPbiAyNi8wNy8yMDIy IDEzOjU2LCBKYW5lIE1hbGFsYW5lIHdyb3RlOg0KPj4gZGlmZiAtLWdpdCBhL2FyY2gveDg2L3hl bi9zdXNwZW5kX2h2bS5jIGIvYXJjaC94ODYveGVuL3N1c3BlbmRfaHZtLmMNCj4+IGluZGV4IDlk NTQ4YjBjNzcyZi4uMGM0Zjc1NTRiN2NjIDEwMDY0NA0KPj4gLS0tIGEvYXJjaC94ODYveGVuL3N1 c3BlbmRfaHZtLmMNCj4+ICsrKyBiL2FyY2gveDg2L3hlbi9zdXNwZW5kX2h2bS5jDQo+PiBAQCAt NSw2ICs1LDcgQEANCj4+IMKgICNpbmNsdWRlIDx4ZW4vaHZtLmg+DQo+PiDCoCAjaW5jbHVkZSA8 eGVuL2ZlYXR1cmVzLmg+DQo+PiDCoCAjaW5jbHVkZSA8eGVuL2ludGVyZmFjZS9mZWF0dXJlcy5o Pg0KPj4gKyNpbmNsdWRlIDx4ZW4vZXZlbnRzLmg+DQo+PiDCoCAjaW5jbHVkZSAieGVuLW9wcy5o Ig0KPj4gQEAgLTE0LDYgKzE1LDEzIEBAIHZvaWQgeGVuX2h2bV9wb3N0X3N1c3BlbmQoaW50IHN1 c3BlbmRfY2FuY2VsbGVkKQ0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHhlbl9odm1faW5pdF9zaGFy ZWRfaW5mbygpOw0KPj4gwqDCoMKgwqDCoMKgwqDCoMKgIHhlbl92Y3B1X3Jlc3RvcmUoKTsNCj4+ IMKgwqDCoMKgwqAgfQ0KPj4gLcKgwqDCoCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKCk7DQo+ PiArwqDCoMKgIGlmICh4ZW5fcGVyY3B1X3VwY2FsbCkgew0KPj4gK8KgwqDCoMKgwqDCoMKgIHVu c2lnbmVkIGludCBjcHU7DQo+PiArDQo+PiArwqDCoMKgwqDCoMKgwqAgZm9yX2VhY2hfb25saW5l X2NwdShjcHUpDQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBCVUdfT04oeGVuX3NldF91cGNh bGxfdmVjdG9yKGNwdSkpOw0KPj4gK8KgwqDCoCB9IGVsc2Ugew0KPj4gK8KgwqDCoMKgwqDCoMKg IHhlbl9zZXR1cF9jYWxsYmFja192ZWN0b3IoKTsNCj4+ICvCoMKgwqAgfQ0KPj4gwqDCoMKgwqDC oCB4ZW5fdW5wbHVnX2VtdWxhdGVkX2RldmljZXMoKTsNCj4+IMKgIH0NCj4+IGRpZmYgLS1naXQg YS9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRzX2Jhc2UuYyANCj4+IGIvZHJpdmVycy94ZW4vZXZl bnRzL2V2ZW50c19iYXNlLmMNCj4+IGluZGV4IDQ2ZDkyOTVkOWE2ZS4uMmFkOTM1OTVkMDNhIDEw MDY0NA0KPj4gLS0tIGEvZHJpdmVycy94ZW4vZXZlbnRzL2V2ZW50c19iYXNlLmMNCj4+ICsrKyBi L2RyaXZlcnMveGVuL2V2ZW50cy9ldmVudHNfYmFzZS5jDQo+PiBAQCAtNDgsNiArNDgsNyBAQA0K Pj4gwqAgI2luY2x1ZGUgPGFzbS94ZW4vcGNpLmg+DQo+PiDCoCAjZW5kaWYNCj4+IMKgICNpbmNs dWRlIDxhc20vc3luY19iaXRvcHMuaD4NCj4+ICsjaW5jbHVkZSA8YXNtL3hlbi9jcHVpZC5oPg0K PiANCj4gVGhpcyBpbmNsdWRlIGRvZXNuJ3QgZXhpc3Qgb24gQXJtIGFuZCB3aWxsIHJlc3VsdCB0 byBhIGJ1aWxkIGZhaWx1cmU6DQo+IA0KPiBsaW51eC9kcml2ZXJzL3hlbi9ldmVudHMvZXZlbnRz X2Jhc2UuYzo1MToxMDogZmF0YWwgZXJyb3I6IA0KPiBhc20veGVuL2NwdWlkLmg6IE5vIHN1Y2gg ZmlsZSBvciBkaXJlY3RvcnkNCj4gIMKgwqAgNTEgfCAjaW5jbHVkZSA8YXNtL3hlbi9jcHVpZC5o Pg0KPiAgwqDCoMKgwqDCoCB8wqDCoMKgwqDCoMKgwqDCoMKgIF5+fn5+fn5+fn5+fn5+fn5+DQpU aGFua3MsIHdpbGwgcGxhY2UgaXQgaW5zaWRlIHRoZSAjaWZkZWYgQ09ORklHX1g4Ni4NCj4gDQo+ PiDCoCAjaW5jbHVkZSA8YXNtL3hlbi9oeXBlcmNhbGwuaD4NCj4+IMKgICNpbmNsdWRlIDxhc20v eGVuL2h5cGVydmlzb3IuaD4NCj4+IMKgICNpbmNsdWRlIDx4ZW4vcGFnZS5oPg0KPj4gQEAgLTIx OTUsMTEgKzIxOTYsNDggQEAgdm9pZCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9yKHZvaWQpDQo+ PiDCoMKgwqDCoMKgwqDCoMKgwqAgY2FsbGJhY2tfdmlhID0gSFZNX0NBTExCQUNLX1ZFQ1RPUihI WVBFUlZJU09SX0NBTExCQUNLX1ZFQ1RPUik7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgaWYgKHhl bl9zZXRfY2FsbGJhY2tfdmlhKGNhbGxiYWNrX3ZpYSkpIHsNCj4+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgIHByX2VycigiUmVxdWVzdCBmb3IgWGVuIEhWTSBjYWxsYmFjayB2ZWN0b3IgZmFp bGVkXG4iKTsNCj4+IC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHhlbl9oYXZlX3ZlY3Rvcl9jYWxs YmFjayA9IDA7DQo+PiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB4ZW5faGF2ZV92ZWN0b3JfY2Fs bGJhY2sgPSBmYWxzZTsNCj4+IMKgwqDCoMKgwqDCoMKgwqDCoCB9DQo+PiDCoMKgwqDCoMKgIH0N Cj4+IMKgIH0NCj4+ICsvKiBTZXR1cCBwZXItdkNQVSB2ZWN0b3ItdHlwZSBjYWxsYmFja3MgYW5k IHRyaWNrIHRvb2xzdGFjayB0byB0aGluaw0KPj4gKyAqIHdlIGFyZSBlbmxpZ2h0ZW5lZC4gSWYg dGhpcyBzZXR1cCBpcyB1bmF2YWlsYWJsZSwgZmFsbGJhY2sgdG8gdGhlDQo+PiArICogZ2xvYmFs IHZlY3Rvci10eXBlIGNhbGxiYWNrLiAqLw0KPj4gK3N0YXRpYyBfX2luaXQgdm9pZCB4ZW5faW5p dF9zZXR1cF91cGNhbGxfdmVjdG9yKHZvaWQpDQo+PiArew0KPj4gK8KgwqDCoCB1bnNpZ25lZCBp bnQgY3B1ID0gMDsNCj4+ICsNCj4+ICvCoMKgwqAgaWYgKCF4ZW5faGF2ZV92ZWN0b3JfY2FsbGJh Y2spDQo+PiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuOw0KPj4gKw0KPj4gK8KgwqDCoCBpZiAoKGNw dWlkX2VheCh4ZW5fY3B1aWRfYmFzZSgpICsgNCkgJiANCj4+IFhFTl9IVk1fQ1BVSURfVVBDQUxM X1ZFQ1RPUikgJiYNCj4+ICvCoMKgwqDCoMKgwqDCoCAheGVuX3NldF91cGNhbGxfdmVjdG9yKGNw dSkgJiYgIXhlbl9zZXRfY2FsbGJhY2tfdmlhKDEpKQ0KPiANCj4geGVuX2NwdWlkX2Jhc2UoKSBp cyBhbiB4ODYtaXNtLiBUaGlzIGlzIGdvaW5nIHRvIGJ1aWxkIGJlY2F1c2UgDQo+IENPTkZJR19Y RU5fUFZIVk0gaXMgb25seSBzZXQgZm9yIHg4Ni4gSG93ZXZlciwgSSB0aGluayB0aGlzIGlzIHF1 aXRlIA0KPiBmcmFnaWxlLg0KPiANCj4gWW91IGFyZSBhbHNvIHVzaW5nIG1vcmUgdmFyaWFibGUg ZGVmaW5lZCBvbmx5IG9uIHg4Ni4gU28gaXQgZmVlbHMgdG8gbWUgDQo+IHRoYXQgdGhlc2UgZnVu Y3Rpb25zIHNob3VsZCBiZSBpbXBsZW1lbnRlZCBpbiB4ODYgY29kZS4NCkkgY2FuIHN1cnJvdW5k IHRob3NlIDQgY2FsbGJhY2svdXBjYWxsIGZ1bmN0aW9ucyB3aXRoIGFuICMjaWZkZWYuPj4gDQor wqDCoMKgwqDCoMKgwqAgeGVuX3BlcmNwdV91cGNhbGwgPSB0cnVlOw0KPj4gK8KgwqDCoCBlbHNl IGlmICh4ZW5fZmVhdHVyZShYRU5GRUFUX2h2bV9jYWxsYmFja192ZWN0b3IpKQ0KPj4gK8KgwqDC oMKgwqDCoMKgIHhlbl9zZXR1cF9jYWxsYmFja192ZWN0b3IoKTsNCj4+ICvCoMKgwqAgZWxzZQ0K Pj4gK8KgwqDCoMKgwqDCoMKgIHhlbl9oYXZlX3ZlY3Rvcl9jYWxsYmFjayA9IGZhbHNlOw0KPj4g K30NCj4+ICsNCj4+ICtpbnQgeGVuX3NldF91cGNhbGxfdmVjdG9yKHVuc2lnbmVkIGludCBjcHUp DQo+PiArew0KPj4gK8KgwqDCoCBpbnQgcmM7DQo+PiArwqDCoMKgIHhlbl9odm1fZXZ0Y2huX3Vw Y2FsbF92ZWN0b3JfdCBvcCA9IHsNCj4+ICvCoMKgwqDCoMKgwqDCoCAudmVjdG9yID0gSFlQRVJW SVNPUl9DQUxMQkFDS19WRUNUT1IsDQo+PiArwqDCoMKgwqDCoMKgwqAgLnZjcHUgPSBwZXJfY3B1 KHhlbl92Y3B1X2lkLCBjcHUpLA0KPj4gK8KgwqDCoCB9Ow0KPj4gKw0KPj4gK8KgwqDCoCByYyA9 IEhZUEVSVklTT1JfaHZtX29wKEhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3RvciwgJm9wKTsN Cj4+ICvCoMKgwqAgaWYgKHJjKQ0KPj4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiByYzsNCj4+ICsN Cj4+ICvCoMKgwqAgaWYgKCFjcHUpDQo+PiArwqDCoMKgwqDCoMKgwqAgcmMgPSB4ZW5fc2V0X2Nh bGxiYWNrX3ZpYSgxKTsNCj4+ICsNCj4+ICvCoMKgwqAgcmV0dXJuIHJjOw0KPj4gK30NCj4+ICsN Cj4+IMKgIHN0YXRpYyBfX2luaXQgdm9pZCB4ZW5fYWxsb2NfY2FsbGJhY2tfdmVjdG9yKHZvaWQp DQo+PiDCoCB7DQo+PiDCoMKgwqDCoMKgIGlmICgheGVuX2hhdmVfdmVjdG9yX2NhbGxiYWNrKQ0K Pj4gQEAgLTIyMTAsNiArMjI0OCw4IEBAIHN0YXRpYyBfX2luaXQgdm9pZCB4ZW5fYWxsb2NfY2Fs bGJhY2tfdmVjdG9yKHZvaWQpDQo+PiDCoCB9DQo+PiDCoCAjZWxzZQ0KPj4gwqAgdm9pZCB4ZW5f c2V0dXBfY2FsbGJhY2tfdmVjdG9yKHZvaWQpIHt9DQo+PiArc3RhdGljIGlubGluZSB2b2lkIHhl bl9pbml0X3NldHVwX3VwY2FsbF92ZWN0b3Iodm9pZCkge30NCj4+ICtpbnQgeGVuX3NldF91cGNh bGxfdmVjdG9yKHVuc2lnbmVkIGludCBjcHUpIHt9DQo+PiDCoCBzdGF0aWMgaW5saW5lIHZvaWQg eGVuX2FsbG9jX2NhbGxiYWNrX3ZlY3Rvcih2b2lkKSB7fQ0KPj4gwqAgI2VuZGlmDQo+PiBAQCAt MjI3MSwxMCArMjMxMSw5IEBAIHZvaWQgX19pbml0IHhlbl9pbml0X0lSUSh2b2lkKQ0KPj4gwqDC oMKgwqDCoMKgwqDCoMKgIGlmICh4ZW5faW5pdGlhbF9kb21haW4oKSkNCj4+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHBjaV94ZW5faW5pdGlhbF9kb21haW4oKTsNCj4+IMKgwqDCoMKgwqAg fQ0KPj4gLcKgwqDCoCBpZiAoeGVuX2ZlYXR1cmUoWEVORkVBVF9odm1fY2FsbGJhY2tfdmVjdG9y KSkgew0KPj4gLcKgwqDCoMKgwqDCoMKgIHhlbl9zZXR1cF9jYWxsYmFja192ZWN0b3IoKTsNCj4+ IC3CoMKgwqDCoMKgwqDCoCB4ZW5fYWxsb2NfY2FsbGJhY2tfdmVjdG9yKCk7DQo+PiAtwqDCoMKg IH0NCj4+ICvCoMKgwqAgeGVuX2luaXRfc2V0dXBfdXBjYWxsX3ZlY3RvcigpOw0KPj4gK8KgwqDC oCB4ZW5fYWxsb2NfY2FsbGJhY2tfdmVjdG9yKCk7DQo+PiArDQo+PiDCoMKgwqDCoMKgIGlmICh4 ZW5faHZtX2RvbWFpbigpKSB7DQo+PiDCoMKgwqDCoMKgwqDCoMKgwqAgbmF0aXZlX2luaXRfSVJR KCk7DQo+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS94ZW4vaHZtLmggYi9pbmNsdWRlL3hlbi9odm0u aA0KPj4gaW5kZXggYjdmZDdmYzlhZDQxLi44ZGE3YTY3NDcwNTggMTAwNjQ0DQo+PiAtLS0gYS9p bmNsdWRlL3hlbi9odm0uaA0KPj4gKysrIGIvaW5jbHVkZS94ZW4vaHZtLmgNCj4+IEBAIC02MCw0 ICs2MCw2IEBAIHN0YXRpYyBpbmxpbmUgaW50IGh2bV9nZXRfcGFyYW1ldGVyKGludCBpZHgsIA0K Pj4gdWludDY0X3QgKnZhbHVlKQ0KPj4gwqAgdm9pZCB4ZW5fc2V0dXBfY2FsbGJhY2tfdmVjdG9y KHZvaWQpOw0KPj4gK2ludCB4ZW5fc2V0X3VwY2FsbF92ZWN0b3IodW5zaWduZWQgaW50IGNwdSk7 DQo+PiArDQo+PiDCoCAjZW5kaWYgLyogWEVOX0hWTV9IX18gKi8NCj4+IGRpZmYgLS1naXQgYS9p bmNsdWRlL3hlbi9pbnRlcmZhY2UvaHZtL2h2bV9vcC5oIA0KPj4gYi9pbmNsdWRlL3hlbi9pbnRl cmZhY2UvaHZtL2h2bV9vcC5oDQo+PiBpbmRleCBmMzA5N2U3OWJiMDMuLmU3MTRkOGI2ZWY4OSAx MDA2NDQNCj4+IC0tLSBhL2luY2x1ZGUveGVuL2ludGVyZmFjZS9odm0vaHZtX29wLmgNCj4+ICsr KyBiL2luY2x1ZGUveGVuL2ludGVyZmFjZS9odm0vaHZtX29wLmgNCj4+IEBAIC00Niw0ICs0Niwx OSBAQCBzdHJ1Y3QgeGVuX2h2bV9nZXRfbWVtX3R5cGUgew0KPj4gwqAgfTsNCj4+IMKgIERFRklO RV9HVUVTVF9IQU5ETEVfU1RSVUNUKHhlbl9odm1fZ2V0X21lbV90eXBlKTsNCj4+ICsvKg0KPj4g KyAqIEhWTU9QX3NldF9ldnRjaG5fdXBjYWxsX3ZlY3RvcjogU2V0IGEgPHZlY3Rvcj4gdGhhdCBz aG91bGQgYmUgdXNlZCANCj4+IGZvciBldmVudA0KPj4gKyAqwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBjaGFubmVsIHVwY2Fs bHMgb24gdGhlIHNwZWNpZmllZCANCj4+IDx2Y3B1Pi4gSWYgc2V0LA0KPj4gKyAqwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB0 aGlzIHZlY3RvciB3aWxsIGJlIHVzZWQgaW4gDQo+PiBwcmVmZXJlbmNlIHRvIHRoZQ0KPj4gKyAq wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBkb21haW4gZ2xvYmFsIGNhbGxiYWNrIHZpYSAoc2VlDQo+PiArICrCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIEhW TV9QQVJBTV9DQUxMQkFDS19JUlEpLg0KPj4gKyAqLw0KPiANCj4gVGVjaG5pY2FsbHkgdGhpcyBo eXBlcmNhbGwgaXMgeDg2IHNwZWNpZmljLiBJT1csIGl0IHdvdWxkIGJlIHBvc3NpYmxlIA0KPiBm b3IgYW5vdGhlciBhcmNoaXRlY3R1cmUgdG8gZGVmaW5lIDIzIGZvciBzb21ldGhpbmcgZGlmZmVy ZW50Lg0KPiANCj4gSWYgaXQgaXMgbm90IHBvc3NpYmxlIChvciBkZXNpcmVkKSB0byBzdXJyb3Vu ZCB3aXRoIGFuICNpZmRlZiwgdGhlbiBJIA0KPiB0aGluayB3ZSBzaG91bGQgYXQgbGVhc3QgYmUg bWVudGlvbmVkIGl0IGluIHRoZSBjb21tZW50Lg0KSW4gWGVuIGl0IGlzIHN1cnJvdW5kZWQgd2l0 aCBhbiAjaWZkZWYuIEkgYW0gaGFwcHkgdG8gZG8gc28gaGVyZSB0b28sIA0KdW5sZXNzIHRoZXJl IGlzIGFueSBvcHBvc2l0aW9uLg0KDQpUaGFuayB5b3UsDQoNCkphbmUu From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:47:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:47:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376303.608978 (Exim 4.92) (envelope-from ) id 1oGjFT-0005IG-JY; Wed, 27 Jul 2022 15:46:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376303.608978; Wed, 27 Jul 2022 15:46:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjFT-0005I9-GU; Wed, 27 Jul 2022 15:46:59 +0000 Received: by outflank-mailman (input) for mailman id 376303; Wed, 27 Jul 2022 15:46:58 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjFS-0005I3-I6 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:46:58 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjFS-0000SW-6C; Wed, 27 Jul 2022 15:46:58 +0000 Received: from [54.239.6.186] (helo=[192.168.6.7]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGjFR-0001xT-Vs; Wed, 27 Jul 2022 15:46:58 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=aAwzEbIlutvB8c35pb6mLQLOgTLWg9DYdy1tiprim1E=; b=4IwU4Q+jqCcQuc1gk3lDhP1DtE XpyZF2fjt8PVF7tqap86WlN/nMlFe9WP+HKf8J6nFBQMDrWowZ3J8mGN963FrPPAbF0hvVwecL640 QhmMEYH3I/RO5PA3rl7xniqjVJw7wtrd56W+iOJ3PNpnufga/d/r+pvP0KWTGWF2/dys=; Message-ID: Date: Wed, 27 Jul 2022 16:46:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Content-Language: en-US To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220727153254.1143503-3-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Xenia, On 27/07/2022 16:32, Xenia Ragiadakou wrote: > Remove unused macro atomic_xchg(). > > Signed-off-by: Xenia Ragiadakou > --- > xen/arch/arm/include/asm/atomic.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h > index f5ef744b4b..a2dc125291 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u) > return __atomic_add_unless(v, a, u); > } > > -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) > - While I agree this is unused today, the wrapper is quite trivial and part of the generic API (x86 also provides one). So I am not in favor of removing it just to please MISRA. That said, if Bertrand and Stefano agrees with removing it then you should also remove the x86 version to avoid inconsistency. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 27 15:57:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 15:57:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376309.608988 (Exim 4.92) (envelope-from ) id 1oGjOw-0006tx-Gm; Wed, 27 Jul 2022 15:56:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376309.608988; Wed, 27 Jul 2022 15:56:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjOw-0006tq-Dp; Wed, 27 Jul 2022 15:56:46 +0000 Received: by outflank-mailman (input) for mailman id 376309; Wed, 27 Jul 2022 15:56:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjOv-0006tk-5x for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:56:45 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20084.outbound.protection.outlook.com [40.107.2.84]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b4fff7f2-0dc4-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 17:56:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7694.eurprd04.prod.outlook.com (2603:10a6:102:e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 15:56:38 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 15:56:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b4fff7f2-0dc4-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lxIkiPFrRM4a2DLLPHmk/ZeaqJEEt0IF8p5+Juod3Ye0+DqcGppvuEodBAKJ+XwTCHEh1cyEOOQLu2mpZe2P0IWD8SnDTmpIYLIwZB2hlH1car779MuiGSCleLrdEiwcSqNtHeQrfrb499ffbKI37rOZ4iVatK4yHeKeQWdqXw236HiOv5mGQag13mt212FeklgTPL9Aheg9DCbm6+MM7sbEZZfdJYmQRTKlDnaJIGR8rAl6C2015dVErSr+BPr4F9WUAf6ryRAEITMYMtRAtdd/X54xtQobr/BZ+4f+QdXTUdF7sxEE34+fezOJjjrXEBpDrmdkd6I9VC/JctWIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2bdapOjrM0mh21LtRsdRRgEqDq8ZlHL5BzanCOVJ5Y=; b=lNwqYXqe8fG15IUNRIBPyhm+W/8+yauIwP+FWds5UZ73Eapb4x/8Pvs3kH8QrGXzLHZb18EuHTKlFSmVzKC8qF7/QkA2Ik6Q0BNt/FEz9UBp3cYwyQXtTYhNtTaxxSgCktrtGN5vpMYLu6syb38mRmd0RId3s0EGfKd3KLTonAi8/9bNCYS4k2co9vzSMM610X1pUSwWe610rDDWjSOwjhJngrJcEjHkbSmuzbpu6zGkSzYTsSxg+WNHqPHu25hUv1/WkId6ARJ1LBcBG6SbYB/OoDzKGRlyUor88npOh9UBUu/wmFTk6QdwKmU1iY0tna9dB1mDqYwi3ZwevtdSQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2bdapOjrM0mh21LtRsdRRgEqDq8ZlHL5BzanCOVJ5Y=; b=cE++8ZcKt1iCPyd69AjVva/qLjUxoeUxw4BA3I8JpZZLN5YG7+aL+I/bg2F1djYns50dQLWT3sNqvNQCjBzCN1cei5cKriPPECqDhwW99ZPQjIfwHNDExhSlpNVM734YlBmas01b+Ahlc+tFcJjWeYaeM4jWb111dDm72sdA2Og8iDt4+Pg42g/euN1pbHySi/6RBI4Y02uM/wD5AmudVFRDfulRBcHs10OHjQefxlLOHvghwBlu0p0I8hjN2G07NubZ42Okxl7fu9ulvRvGZKS//lK49kmNpUGTZbGWkXx6Gznd1AmpQ3Pvug497R2IplV2s0J6aHI2/26wlG489A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 17:56:36 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Daniel Smith From: Jan Beulich Subject: [PATCH v7] evtchn: convert domain event lock to an r/w one Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P193CA0045.EURP193.PROD.OUTLOOK.COM (2603:10a6:209:8e::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 176dcc51-2613-4a6f-bae0-08da6fe89735 X-MS-TrafficTypeDiagnostic: PA4PR04MB7694:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zJxPArtwwsBc4+LAaYbzuVhsPsgkb6Q3XnDelrpN18n9jr4ADj3NYUzTJzzFNAmduZ9rJpOTcdtWtg6YnXdZWzr/P3fAniUbR++nYl4Ik8elXyUfta+ffgSienw5evDj15xVnPqHQZfM6fwXRmrqAY/qrOcPMYiMKH7G/xv+xU7PixlSIZjAQvj8lcMw9PDiCInLocjaWwoGz4Nixyl3fMNKjhBxDkJ8RSsapc9cXqAoFUb3f8jnSVq2V/mq9njADyDBqKv6Zex9OtdWv+7gszTaT578VtsqccwY8hTMEZv1lJ+oiLkRpbCzSXxETnRO6Dt1IRhl1TaTM8IMoGWZKIKX4oCQPq6vrELlZSYjrKZWYdgEXgwVCQN4rHu0GAQGFUm18AEbBWbDkmJv77MME+tm7CC+gxrmxO9MdlksDU2Rx4yV/m0xnUTnaabvQv36+fvM6SXywrqwquB6uNojIT7IXzlriqOTMgJ+b90C9l1s6ZT+/uudQzh0u8CoRAyRvfNU6PjkZZwcK1ri/A0nMgjrr+pYp+OEqv/WJ9LSjUVU5fNrn7Bpiku8UAakODhF2gw+JM+Ixjs7vdusP0VNMDjv0dK7uLo5gM9/mppTgRq2oie7Uq/A2/cHV7eEbvxeXFoJ7mgM3UR8Z8k/n602jABx5ZxUPnJ1UnH7Tc95uotyzxPhfywAyMo1f0wdBSdIPuZBa8kgNlxl7cIvIP8nu/U+vYu5/3IT4jxqDIvE4Y/h0FKaKxkOnWqir2c3gtghnCuegdRuj5WT2rXgKDhoQWEHILHbnp0vMXK3GZZwSFrT8NGuG7/Sek2TegzeWsTpQxcX5QeoGyI+aw0gW3Wt2g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(376002)(136003)(366004)(186003)(83380400001)(38100700002)(2616005)(31686004)(6916009)(316002)(36756003)(54906003)(8676002)(4326008)(45080400002)(66476007)(66556008)(66946007)(26005)(6486002)(6512007)(6506007)(86362001)(8936002)(31696002)(478600001)(5660300002)(41300700001)(2906002)(30864003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ajFueHFRTWx1cTNKQ09XT3RhcVI0bEQ5ZVF2d25aOUcwdkVRZmpOWkx1Skx5?= =?utf-8?B?MVNtQkZtN2xHdFM4TTlXdXZrN2plOXJpM1FDTHlYRnVGWDZEM3NZcGpUdk5r?= =?utf-8?B?VEwxL2lVR0hQd1p0dWhjMXNFL3dpQ29UcDdBalZoYTFrUkd6MDJTVVBkMklX?= =?utf-8?B?M0I1Ri83VWtiUHBkUUptdmV0SnhuNVlzQlJRa1pLd2dvTkt0ZkVOZTBxcHI1?= =?utf-8?B?RUY2UDQ3Z2x1T1JyaXdYcnU5bVR1UEJHK3k3YitZbVdHWmR0NDVoUlNhbFBO?= =?utf-8?B?aUhZNnR6WnBxWjJHMWx2WXhzR1g4UFR1QUw4NWQyZkdidkZvNDFRZ3hnVmI4?= =?utf-8?B?N0ZCZFQ4dHE3V1c2NzVneXhrUWsxZ1BENTVsWmYyY09ucGtvYnZkSGFwMnNi?= =?utf-8?B?VWdDN0ZBaE96WkUvWXhwVjlxZEx2TlV2dEF3UGZjSC8rcG9yUWhyWjVMTytx?= =?utf-8?B?WVZML2RuV2ZFbTlZQUt2MndENCtYZW1hYVFHU0I4VTZqdkpJMlBGSm9JcWRN?= =?utf-8?B?ZEFOOGtwVHV0aWJJd2VSUTdpczMxVytQZUg1VW5tSzRwMVpuWldrQlpsRkVx?= =?utf-8?B?MXJQRzFxUzRPTnpueGlOZEpnMDFJR3A5OXFsdG9PK3B5TmJTNzVPVHRRS1Aw?= =?utf-8?B?YTA2cHdsTWdnU2J0WFMzbGd5ZVR3MEVOeXpBWFl6TnpmWHJQV3pLWDdMaGpl?= =?utf-8?B?dEhERE1DVVpOd1B1RFFHWXNmNmRzbFo3Q1R4NnlXVUdwSCtmV1hZTDd1Yjhs?= =?utf-8?B?THRUelE1SUZQY0IwNG9PVnZSUnFFZFZYRVZLbW9TUG1YaktuOXdMUXNIQ29h?= =?utf-8?B?SFJXNjZUaDNxK01nY2QrekZCZ0FVWjJ4c0drMXo2UnZRSjBzSkkrNXJFWWg2?= =?utf-8?B?WlJPQlova0lHaXV6UGFFN3R2dExtQjZramZFVkhvdlZyejVya1V3akpiWm00?= =?utf-8?B?YTJZdXFRRjVqQmtTUlVpSmxFZkpRVTVYOTRIZXA3NS9kUUNMelU2cFpnR0pl?= =?utf-8?B?ZW9yWHFMbEI1WjN3YlplaFZhRVpSWG9sRVE4Q05hc1JFSW5DSVlRaElSc2tP?= =?utf-8?B?aXkrazBhd0srSUxVVW9rZ3hjRFEyOUNrWXBORzFnRWdYRWllTHh2U3FuUGZT?= =?utf-8?B?b0Z1SHlrY09ibTQ2ZDNwK3pOQ2JmWEQ0eGtXdFlBdjZaWElEREpDUzU2aTRz?= =?utf-8?B?aytHeDNZZmR4Nk9KbG96UGwwYVV4K0JhanZRSktQclpoajdLallBSnhJTFMv?= =?utf-8?B?WExhM0czYU5vR2w2Q3lXdnRYNkt1NnZsVFhIZ2I2OUhOb2tITmJrVXo4Tm1u?= =?utf-8?B?a1oxaitBbUoxRW4wV1lzZVhFbHUzdGFnVGdoNlpydWNMYzAzSi9OUWdWNTZS?= =?utf-8?B?RG56UmZBRFh6SkpHTDZ4V3RRMlBMdCtPN3RQeW8vZUp4N2I2Y2I3NmZXY21x?= =?utf-8?B?bXFDYmJwSGZFTnpHVDdiQkhSVXkrTUNVM2g4NEtoL0FPMXR4ODFyODRNNTU1?= =?utf-8?B?VnZlZzE5dmtaZUFIWGJWdUdLNWhOaTZwOUxrbHlaYjlOa0pYYlNJUlBIcFpQ?= =?utf-8?B?MGlMV1dMMjlqM3NwNFNiMUMxa3ZOWVRjQ0V5cWJMTUJSa3FSaDQ5UEoxTDRy?= =?utf-8?B?UXVSYmhVQ2tpTFNVUE05VzNWNEVKSER6V0F1VVpqRkZmcHA3MzlydVFFbjJC?= =?utf-8?B?V2JHbVBGc3BWKzQ0S0hlcTc1ZkxPYVB2T2NXSXlKK1gwSGhvbGltaTVmRXBW?= =?utf-8?B?MXBLTFNzZEtHUnNMN1NsUjY1R0R3d2ppTGlwMkdjcDhVTHNUTHdqc3NZK1Zy?= =?utf-8?B?MkVUWGc5M0VQZnk3cWQycGFqKzVyVjhwL2p3UTY0NElWOVlWcGV1STBQa1BJ?= =?utf-8?B?TS9XMDN3NEh2Qm1heTJyZDQ3UWZtSzRxVUlaNDlRTVphTXpFbnVKSEV4MkZy?= =?utf-8?B?ajZuSXZWRms4ekJIdzY5dHdvbXUvMWxWQ0ljeGYwcFoxVWs2TjIvaTViUkg3?= =?utf-8?B?dlZ5OXlLL0M5anhJcTRrYmZXQUE3aWROT1ZsNjR5TXlzZGNKWjN3OEUrL0hl?= =?utf-8?B?MVYzUlV1N2dtcE9nanFVeTV6RHQ0Z2NGcVNFMmdTUi9KeTJRQkdod09uRER1?= =?utf-8?Q?/wWInCOxIwQdrdU3irmkwTER1?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 176dcc51-2613-4a6f-bae0-08da6fe89735 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 15:56:38.7729 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 50woD/oxpJA86Pnz6bORdyQQNXGNsUKSlj/3p6AYrfs6wQcJT4k/hOrkfXahgtlQRe+/0HP1/K7mFNgIa7MTaw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7694 Especially for the use in evtchn_move_pirqs() (called when moving a vCPU across pCPU-s) and the ones in EOI handling in PCI pass-through code, serializing perhaps an entire domain isn't helpful when no state (which isn't e.g. further protected by the per-channel lock) changes. Unfortunately this implies dropping of lock profiling for this lock, until r/w locks may get enabled for such functionality. While ->notify_vcpu_id is now meant to be consistently updated with the per-channel lock held, an extension applies to ECS_PIRQ: The field is also guaranteed to not change with the per-domain event lock held for writing. Therefore the link_pirq_port() call from evtchn_bind_pirq() could in principle be moved out of the per-channel locked regions, but this further code churn didn't seem worth it. Signed-off-by: Jan Beulich --- v6: Re-vive and re-base. v5: Re-base, also over dropped earlier patch. v4: Re-base, in particular over new earlier patches. Acquire both per-domain locks for writing in evtchn_close(). Adjust spin_barrier() related comments. v3: Re-base. v2: Consistently lock for writing in evtchn_reset(). Fix error path in pci_clean_dpci_irqs(). Lock for writing in pt_irq_time_out(), hvm_dirq_assist(), hvm_dpci_eoi(), and hvm_dpci_isairq_eoi(). Move rw_barrier() introduction here. Re-base over changes earlier in the series. --- a/xen/arch/x86/domain.c +++ b/xen/arch/x86/domain.c @@ -967,7 +967,7 @@ int arch_domain_soft_reset(struct domain if ( !is_hvm_domain(d) ) return -EINVAL; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); for ( i = 0; i < d->nr_pirqs ; i++ ) { if ( domain_pirq_to_emuirq(d, i) != IRQ_UNBOUND ) @@ -977,7 +977,7 @@ int arch_domain_soft_reset(struct domain break; } } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( ret ) return ret; --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -492,9 +492,9 @@ void hvm_migrate_pirqs(struct vcpu *v) if ( !is_iommu_enabled(d) || !hvm_domain_irq(d)->dpci ) return; - spin_lock(&d->event_lock); + read_lock(&d->event_lock); pt_pirq_iterate(d, migrate_pirq, v); - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); } static bool hvm_get_pending_event(struct vcpu *v, struct x86_event *info) --- a/xen/arch/x86/hvm/irq.c +++ b/xen/arch/x86/hvm/irq.c @@ -404,9 +404,9 @@ int hvm_inject_msi(struct domain *d, uin { int rc; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); rc = map_domain_emuirq_pirq(d, pirq, IRQ_MSI_EMU); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( rc ) return rc; info = pirq_info(d, pirq); --- a/xen/arch/x86/hvm/vioapic.c +++ b/xen/arch/x86/hvm/vioapic.c @@ -203,9 +203,9 @@ static int vioapic_hwdom_map_gsi(unsigne { gprintk(XENLOG_WARNING, "vioapic: error binding GSI %u: %d\n", gsi, ret); - spin_lock(&currd->event_lock); + write_lock(&currd->event_lock); unmap_domain_pirq(currd, pirq); - spin_unlock(&currd->event_lock); + write_unlock(&currd->event_lock); } pcidevs_unlock(); --- a/xen/arch/x86/hvm/vmsi.c +++ b/xen/arch/x86/hvm/vmsi.c @@ -467,7 +467,7 @@ int msixtbl_pt_register(struct domain *d int r = -EINVAL; ASSERT(pcidevs_locked()); - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); if ( !msixtbl_initialised(d) ) return -ENODEV; @@ -537,7 +537,7 @@ void msixtbl_pt_unregister(struct domain struct msixtbl_entry *entry; ASSERT(pcidevs_locked()); - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); if ( !msixtbl_initialised(d) ) return; @@ -591,13 +591,13 @@ void msixtbl_pt_cleanup(struct domain *d if ( !msixtbl_initialised(d) ) return; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); list_for_each_entry_safe( entry, temp, &d->arch.hvm.msixtbl_list, list ) del_msixtbl_entry(entry); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); } void msix_write_completion(struct vcpu *v) @@ -811,9 +811,9 @@ static void vpci_msi_disable(const struc ASSERT(!rc); } - spin_lock(&pdev->domain->event_lock); + write_lock(&pdev->domain->event_lock); unmap_domain_pirq(pdev->domain, pirq); - spin_unlock(&pdev->domain->event_lock); + write_unlock(&pdev->domain->event_lock); pcidevs_unlock(); } --- a/xen/arch/x86/io_apic.c +++ b/xen/arch/x86/io_apic.c @@ -2457,10 +2457,10 @@ int ioapic_guest_write(unsigned long phy } if ( pirq >= 0 ) { - spin_lock(&hardware_domain->event_lock); + write_lock(&hardware_domain->event_lock); ret = map_domain_pirq(hardware_domain, pirq, irq, MAP_PIRQ_TYPE_GSI, NULL); - spin_unlock(&hardware_domain->event_lock); + write_unlock(&hardware_domain->event_lock); if ( ret < 0 ) return ret; } --- a/xen/arch/x86/irq.c +++ b/xen/arch/x86/irq.c @@ -1550,7 +1550,7 @@ int pirq_guest_bind(struct vcpu *v, stru unsigned int max_nr_guests = will_share ? irq_max_guests : 1; int rc = 0; - WARN_ON(!spin_is_locked(&v->domain->event_lock)); + WARN_ON(!rw_is_write_locked(&v->domain->event_lock)); BUG_ON(!local_irq_is_enabled()); retry: @@ -1764,7 +1764,7 @@ void pirq_guest_unbind(struct domain *d, struct irq_desc *desc; int irq = 0; - WARN_ON(!spin_is_locked(&d->event_lock)); + WARN_ON(!rw_is_write_locked(&d->event_lock)); BUG_ON(!local_irq_is_enabled()); desc = pirq_spin_lock_irq_desc(pirq, NULL); @@ -1801,7 +1801,7 @@ static bool pirq_guest_force_unbind(stru unsigned int i; bool bound = false; - WARN_ON(!spin_is_locked(&d->event_lock)); + WARN_ON(!rw_is_write_locked(&d->event_lock)); BUG_ON(!local_irq_is_enabled()); desc = pirq_spin_lock_irq_desc(pirq, NULL); @@ -2043,7 +2043,7 @@ int get_free_pirq(struct domain *d, int { int i; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); if ( type == MAP_PIRQ_TYPE_GSI ) { @@ -2068,7 +2068,7 @@ int get_free_pirqs(struct domain *d, uns { unsigned int i, found = 0; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); for ( i = d->nr_pirqs - 1; i >= nr_irqs_gsi; --i ) if ( is_free_pirq(d, pirq_info(d, i)) ) @@ -2096,7 +2096,7 @@ int map_domain_pirq( DECLARE_BITMAP(prepared, MAX_MSI_IRQS) = {}; DECLARE_BITMAP(granted, MAX_MSI_IRQS) = {}; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); if ( !irq_access_permitted(current->domain, irq)) return -EPERM; @@ -2314,7 +2314,7 @@ int unmap_domain_pirq(struct domain *d, return -EINVAL; ASSERT(pcidevs_locked()); - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); info = pirq_info(d, pirq); if ( !info || (irq = info->arch.irq) <= 0 ) @@ -2420,13 +2420,13 @@ void free_domain_pirqs(struct domain *d) int i; pcidevs_lock(); - spin_lock(&d->event_lock); + write_lock(&d->event_lock); for ( i = 0; i < d->nr_pirqs; i++ ) if ( domain_pirq_to_irq(d, i) > 0 ) unmap_domain_pirq(d, i); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); pcidevs_unlock(); } @@ -2669,7 +2669,7 @@ int map_domain_emuirq_pirq(struct domain int old_emuirq = IRQ_UNBOUND, old_pirq = IRQ_UNBOUND; struct pirq *info; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); if ( !is_hvm_domain(d) ) return -EINVAL; @@ -2735,7 +2735,7 @@ int unmap_domain_pirq_emuirq(struct doma if ( (pirq < 0) || (pirq >= d->nr_pirqs) ) return -EINVAL; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); emuirq = domain_pirq_to_emuirq(d, pirq); if ( emuirq == IRQ_UNBOUND ) @@ -2783,7 +2783,7 @@ static int allocate_pirq(struct domain * { int current_pirq; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); current_pirq = domain_irq_to_pirq(d, irq); if ( pirq < 0 ) { @@ -2855,7 +2855,7 @@ int allocate_and_map_gsi_pirq(struct dom } /* Verify or get pirq. */ - spin_lock(&d->event_lock); + write_lock(&d->event_lock); pirq = allocate_pirq(d, index, *pirq_p, irq, MAP_PIRQ_TYPE_GSI, NULL); if ( pirq < 0 ) { @@ -2868,7 +2868,7 @@ int allocate_and_map_gsi_pirq(struct dom *pirq_p = pirq; done: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return ret; } @@ -2909,7 +2909,7 @@ int allocate_and_map_msi_pirq(struct dom pcidevs_lock(); /* Verify or get pirq. */ - spin_lock(&d->event_lock); + write_lock(&d->event_lock); pirq = allocate_pirq(d, index, *pirq_p, irq, type, &msi->entry_nr); if ( pirq < 0 ) { @@ -2922,7 +2922,7 @@ int allocate_and_map_msi_pirq(struct dom *pirq_p = pirq; done: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); pcidevs_unlock(); if ( ret ) { --- a/xen/arch/x86/physdev.c +++ b/xen/arch/x86/physdev.c @@ -34,7 +34,7 @@ static int physdev_hvm_map_pirq( ASSERT(!is_hardware_domain(d)); - spin_lock(&d->event_lock); + write_lock(&d->event_lock); switch ( type ) { case MAP_PIRQ_TYPE_GSI: { @@ -84,7 +84,7 @@ static int physdev_hvm_map_pirq( break; } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return ret; } @@ -154,18 +154,18 @@ int physdev_unmap_pirq(domid_t domid, in if ( is_hvm_domain(d) && has_pirq(d) ) { - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( domain_pirq_to_emuirq(d, pirq) != IRQ_UNBOUND ) ret = unmap_domain_pirq_emuirq(d, pirq); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( domid == DOMID_SELF || ret ) goto free_domain; } pcidevs_lock(); - spin_lock(&d->event_lock); + write_lock(&d->event_lock); ret = unmap_domain_pirq(d, pirq); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); pcidevs_unlock(); free_domain: @@ -192,10 +192,10 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H ret = -EINVAL; if ( eoi.irq >= currd->nr_pirqs ) break; - spin_lock(&currd->event_lock); + read_lock(&currd->event_lock); pirq = pirq_info(currd, eoi.irq); if ( !pirq ) { - spin_unlock(&currd->event_lock); + read_unlock(&currd->event_lock); break; } if ( currd->arch.auto_unmask ) @@ -214,7 +214,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H && hvm_irq->gsi_assert_count[gsi] ) send_guest_pirq(currd, pirq); } - spin_unlock(&currd->event_lock); + read_unlock(&currd->event_lock); ret = 0; break; } @@ -578,7 +578,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H if ( copy_from_guest(&out, arg, 1) != 0 ) break; - spin_lock(&currd->event_lock); + write_lock(&currd->event_lock); ret = get_free_pirq(currd, out.type); if ( ret >= 0 ) @@ -591,7 +591,7 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_H ret = -ENOMEM; } - spin_unlock(&currd->event_lock); + write_unlock(&currd->event_lock); if ( ret >= 0 ) { --- a/xen/arch/x86/pv/shim.c +++ b/xen/arch/x86/pv/shim.c @@ -431,7 +431,7 @@ long pv_shim_event_channel_op(int cmd, X if ( rc ) \ break; \ \ - spin_lock(&d->event_lock); \ + write_lock(&d->event_lock); \ rc = evtchn_allocate_port(d, op.port_field); \ if ( rc ) \ { \ @@ -440,7 +440,7 @@ long pv_shim_event_channel_op(int cmd, X } \ else \ evtchn_reserve(d, op.port_field); \ - spin_unlock(&d->event_lock); \ + write_unlock(&d->event_lock); \ \ if ( !rc && __copy_to_guest(arg, &op, 1) ) \ rc = -EFAULT; \ @@ -568,11 +568,11 @@ long pv_shim_event_channel_op(int cmd, X if ( rc ) break; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); rc = evtchn_allocate_port(d, ipi.port); if ( rc ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); close.port = ipi.port; BUG_ON(xen_hypercall_event_channel_op(EVTCHNOP_close, &close)); @@ -581,7 +581,7 @@ long pv_shim_event_channel_op(int cmd, X evtchn_assign_vcpu(d, ipi.port, ipi.vcpu); evtchn_reserve(d, ipi.port); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( __copy_to_guest(arg, &ipi, 1) ) rc = -EFAULT; --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -301,7 +301,7 @@ int evtchn_alloc_unbound(evtchn_alloc_un if ( d == NULL ) return -ESRCH; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( (port = get_free_port(d)) < 0 ) ERROR_EXIT_DOM(port, d); @@ -324,7 +324,7 @@ int evtchn_alloc_unbound(evtchn_alloc_un out: check_free_port(d, port); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); rcu_unlock_domain(d); return rc; @@ -361,14 +361,14 @@ static int evtchn_bind_interdomain(evtch /* Avoid deadlock by first acquiring lock of domain with smaller id. */ if ( ld < rd ) { - spin_lock(&ld->event_lock); - spin_lock(&rd->event_lock); + write_lock(&ld->event_lock); + write_lock(&rd->event_lock); } else { if ( ld != rd ) - spin_lock(&rd->event_lock); - spin_lock(&ld->event_lock); + write_lock(&rd->event_lock); + write_lock(&ld->event_lock); } if ( (lport = get_free_port(ld)) < 0 ) @@ -409,9 +409,9 @@ static int evtchn_bind_interdomain(evtch out: check_free_port(ld, lport); - spin_unlock(&ld->event_lock); + write_unlock(&ld->event_lock); if ( ld != rd ) - spin_unlock(&rd->event_lock); + write_unlock(&rd->event_lock); rcu_unlock_domain(rd); @@ -442,7 +442,7 @@ int evtchn_bind_virq(evtchn_bind_virq_t if ( (v = domain_vcpu(d, vcpu)) == NULL ) return -ENOENT; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( read_atomic(&v->virq_to_evtchn[virq]) ) ERROR_EXIT(-EEXIST); @@ -483,7 +483,7 @@ int evtchn_bind_virq(evtchn_bind_virq_t write_atomic(&v->virq_to_evtchn[virq], port); out: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -499,7 +499,7 @@ static int evtchn_bind_ipi(evtchn_bind_i if ( domain_vcpu(d, vcpu) == NULL ) return -ENOENT; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( (port = get_free_port(d)) < 0 ) ERROR_EXIT(port); @@ -517,7 +517,7 @@ static int evtchn_bind_ipi(evtchn_bind_i bind->port = port; out: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -563,7 +563,7 @@ static int evtchn_bind_pirq(evtchn_bind_ if ( !is_hvm_domain(d) && !pirq_access_permitted(d, pirq) ) return -EPERM; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( pirq_to_evtchn(d, pirq) != 0 ) ERROR_EXIT(-EEXIST); @@ -603,7 +603,7 @@ static int evtchn_bind_pirq(evtchn_bind_ out: check_free_port(d, port); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -619,7 +619,7 @@ int evtchn_close(struct domain *d1, int return -EINVAL; again: - spin_lock(&d1->event_lock); + write_lock(&d1->event_lock); /* Guest cannot close a Xen-attached event channel. */ if ( unlikely(consumer_is_xen(chn1)) && guest ) @@ -682,13 +682,11 @@ int evtchn_close(struct domain *d1, int rcu_lock_domain(d2); if ( d1 < d2 ) - { - spin_lock(&d2->event_lock); - } + write_lock(&d2->event_lock); else if ( d1 != d2 ) { - spin_unlock(&d1->event_lock); - spin_lock(&d2->event_lock); + write_unlock(&d1->event_lock); + write_lock(&d2->event_lock); goto again; } } @@ -733,11 +731,11 @@ int evtchn_close(struct domain *d1, int if ( d2 != NULL ) { if ( d1 != d2 ) - spin_unlock(&d2->event_lock); + write_unlock(&d2->event_lock); rcu_unlock_domain(d2); } - spin_unlock(&d1->event_lock); + write_unlock(&d1->event_lock); return rc; } @@ -977,7 +975,7 @@ int evtchn_status(evtchn_status_t *statu return -EINVAL; } - spin_lock(&d->event_lock); + read_lock(&d->event_lock); if ( consumer_is_xen(chn) ) { @@ -1023,7 +1021,7 @@ int evtchn_status(evtchn_status_t *statu status->vcpu = chn->notify_vcpu_id; out: - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); rcu_unlock_domain(d); return rc; @@ -1045,7 +1043,7 @@ int evtchn_bind_vcpu(evtchn_port_t port, if ( !chn ) return -EINVAL; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); /* Guest cannot re-bind a Xen-attached event channel. */ if ( unlikely(consumer_is_xen(chn)) ) @@ -1081,7 +1079,7 @@ int evtchn_bind_vcpu(evtchn_port_t port, } out: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -1125,7 +1123,7 @@ int evtchn_reset(struct domain *d, bool if ( d != current->domain && !d->controller_pause_count ) return -EINVAL; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); /* * If we are resuming, then start where we stopped. Otherwise, check @@ -1136,7 +1134,7 @@ int evtchn_reset(struct domain *d, bool if ( i > d->next_evtchn ) d->next_evtchn = i; - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( !i ) return -EBUSY; @@ -1148,14 +1146,14 @@ int evtchn_reset(struct domain *d, bool /* NB: Choice of frequency is arbitrary. */ if ( !(i & 0x3f) && hypercall_preempt_check() ) { - spin_lock(&d->event_lock); + write_lock(&d->event_lock); d->next_evtchn = i; - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -ERESTART; } } - spin_lock(&d->event_lock); + write_lock(&d->event_lock); d->next_evtchn = 0; @@ -1168,7 +1166,7 @@ int evtchn_reset(struct domain *d, bool evtchn_2l_init(d); } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -1360,7 +1358,7 @@ int alloc_unbound_xen_event_channel( struct evtchn *chn; int port, rc; - spin_lock(&ld->event_lock); + write_lock(&ld->event_lock); port = rc = get_free_port(ld); if ( rc < 0 ) @@ -1388,7 +1386,7 @@ int alloc_unbound_xen_event_channel( out: check_free_port(ld, port); - spin_unlock(&ld->event_lock); + write_unlock(&ld->event_lock); return rc < 0 ? rc : port; } @@ -1399,7 +1397,7 @@ void free_xen_event_channel(struct domai { /* * Make sure ->is_dying is read /after/ ->valid_evtchns, pairing - * with the spin_barrier() and BUG_ON() in evtchn_destroy(). + * with the kind-of-barrier and BUG_ON() in evtchn_destroy(). */ smp_rmb(); BUG_ON(!d->is_dying); @@ -1419,7 +1417,7 @@ void notify_via_xen_event_channel(struct { /* * Make sure ->is_dying is read /after/ ->valid_evtchns, pairing - * with the spin_barrier() and BUG_ON() in evtchn_destroy(). + * with the kind-of-barrier and BUG_ON() in evtchn_destroy(). */ smp_rmb(); ASSERT(ld->is_dying); @@ -1474,7 +1472,8 @@ int evtchn_init(struct domain *d, unsign return -ENOMEM; d->valid_evtchns = EVTCHNS_PER_BUCKET; - spin_lock_init_prof(d, event_lock); + rwlock_init(&d->event_lock); + if ( get_free_port(d) != 0 ) { free_evtchn_bucket(d, d->evtchn); @@ -1499,9 +1498,10 @@ int evtchn_destroy(struct domain *d) { unsigned int i; - /* After this barrier no new event-channel allocations can occur. */ + /* After this kind-of-barrier no new event-channel allocations can occur. */ BUG_ON(!d->is_dying); - spin_barrier(&d->event_lock); + read_lock(&d->event_lock); + read_unlock(&d->event_lock); /* Close all existing event channels. */ for ( i = d->valid_evtchns; --i; ) @@ -1559,13 +1559,13 @@ void evtchn_move_pirqs(struct vcpu *v) unsigned int port; struct evtchn *chn; - spin_lock(&d->event_lock); + read_lock(&d->event_lock); for ( port = v->pirq_evtchn_head; port; port = chn->u.pirq.next_port ) { chn = evtchn_from_port(d, port); pirq_set_affinity(d, chn->u.pirq.irq, mask); } - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); } @@ -1578,7 +1578,7 @@ static void domain_dump_evtchn_info(stru "Polling vCPUs: {%*pbl}\n" " port [p/m/s]\n", d->domain_id, d->max_vcpus, d->poll_mask); - spin_lock(&d->event_lock); + read_lock(&d->event_lock); for ( port = 1; ; ++port ) { @@ -1627,7 +1627,7 @@ static void domain_dump_evtchn_info(stru } } - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); } static void cf_check dump_evtchn_info(unsigned char key) --- a/xen/common/event_fifo.c +++ b/xen/common/event_fifo.c @@ -602,7 +602,7 @@ int evtchn_fifo_init_control(struct evtc if ( offset & (8 - 1) ) return -EINVAL; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); /* * If this is the first control block, setup an empty event array @@ -638,13 +638,13 @@ int evtchn_fifo_init_control(struct evtc else rc = map_control_block(v, gfn, offset); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; error: evtchn_fifo_destroy(d); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } @@ -697,9 +697,9 @@ int evtchn_fifo_expand_array(const struc if ( !d->evtchn_fifo ) return -EOPNOTSUPP; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); rc = add_page_to_event_array(d, expand_array->array_gfn); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } --- a/xen/drivers/passthrough/vtd/x86/hvm.c +++ b/xen/drivers/passthrough/vtd/x86/hvm.c @@ -51,7 +51,7 @@ void hvm_dpci_isairq_eoi(struct domain * if ( !is_iommu_enabled(d) ) return; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); dpci = domain_get_irq_dpci(d); @@ -60,5 +60,5 @@ void hvm_dpci_isairq_eoi(struct domain * /* Multiple mirq may be mapped to one isa irq */ pt_pirq_iterate(d, _hvm_dpci_isairq_eoi, (void *)(long)isairq); } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); } --- a/xen/drivers/passthrough/x86/hvm.c +++ b/xen/drivers/passthrough/x86/hvm.c @@ -117,7 +117,7 @@ static void pt_pirq_softirq_reset(struct { struct domain *d = pirq_dpci->dom; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_write_locked(&d->event_lock)); switch ( cmpxchg(&pirq_dpci->state, 1 << STATE_SCHED, 0) ) { @@ -229,7 +229,7 @@ int pt_irq_create_bind( return -EINVAL; restart: - spin_lock(&d->event_lock); + write_lock(&d->event_lock); hvm_irq_dpci = domain_get_irq_dpci(d); if ( !hvm_irq_dpci && !is_hardware_domain(d) ) @@ -245,7 +245,7 @@ int pt_irq_create_bind( hvm_irq_dpci = xzalloc(struct hvm_irq_dpci); if ( hvm_irq_dpci == NULL ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -ENOMEM; } for ( i = 0; i < NR_HVM_DOMU_IRQS; i++ ) @@ -257,7 +257,7 @@ int pt_irq_create_bind( info = pirq_get_info(d, pirq); if ( !info ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -ENOMEM; } pirq_dpci = pirq_dpci(info); @@ -272,7 +272,7 @@ int pt_irq_create_bind( */ if ( pt_pirq_softirq_active(pirq_dpci) ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); cpu_relax(); goto restart; } @@ -330,7 +330,7 @@ int pt_irq_create_bind( pirq_dpci->dom = NULL; pirq_dpci->flags = 0; pirq_cleanup_check(info, d); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return rc; } } @@ -340,7 +340,7 @@ int pt_irq_create_bind( if ( (pirq_dpci->flags & mask) != mask ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -EBUSY; } @@ -364,7 +364,7 @@ int pt_irq_create_bind( dest_vcpu_id = hvm_girq_dest_2_vcpu_id(d, dest, dest_mode); pirq_dpci->gmsi.dest_vcpu_id = dest_vcpu_id; - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); pirq_dpci->gmsi.posted = false; vcpu = (dest_vcpu_id >= 0) ? d->vcpu[dest_vcpu_id] : NULL; @@ -424,7 +424,7 @@ int pt_irq_create_bind( if ( !digl || !girq ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); xfree(girq); xfree(digl); return -ENOMEM; @@ -451,7 +451,7 @@ int pt_irq_create_bind( if ( pt_irq_bind->irq_type != PT_IRQ_TYPE_PCI || pirq >= hvm_domain_irq(d)->nr_gsis ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -EINVAL; } @@ -487,7 +487,7 @@ int pt_irq_create_bind( if ( mask < 0 || trigger_mode < 0 ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); ASSERT_UNREACHABLE(); return -EINVAL; @@ -530,14 +530,14 @@ int pt_irq_create_bind( } pirq_dpci->flags = 0; pirq_cleanup_check(info, d); - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); xfree(girq); xfree(digl); return rc; } } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( iommu_verbose ) { @@ -555,7 +555,7 @@ int pt_irq_create_bind( } default: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -EOPNOTSUPP; } @@ -608,13 +608,13 @@ int pt_irq_destroy_bind( return -EOPNOTSUPP; } - spin_lock(&d->event_lock); + write_lock(&d->event_lock); hvm_irq_dpci = domain_get_irq_dpci(d); if ( !hvm_irq_dpci && !is_hardware_domain(d) ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -EINVAL; } @@ -647,7 +647,7 @@ int pt_irq_destroy_bind( if ( girq ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return -EINVAL; } @@ -689,7 +689,7 @@ int pt_irq_destroy_bind( pirq_cleanup_check(pirq, d); } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); if ( what && iommu_verbose ) { @@ -733,7 +733,7 @@ int pt_pirq_iterate(struct domain *d, unsigned int pirq = 0, n, i; struct pirq *pirqs[8]; - ASSERT(spin_is_locked(&d->event_lock)); + ASSERT(rw_is_locked(&d->event_lock)); do { n = radix_tree_gang_lookup(&d->pirq_tree, (void **)pirqs, pirq, @@ -818,9 +818,9 @@ void hvm_dpci_msi_eoi(struct domain *d, (!hvm_domain_irq(d)->dpci && !is_hardware_domain(d)) ) return; - spin_lock(&d->event_lock); + read_lock(&d->event_lock); pt_pirq_iterate(d, _hvm_dpci_msi_eoi, (void *)(long)vector); - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); } static void hvm_dirq_assist(struct domain *d, struct hvm_pirq_dpci *pirq_dpci) @@ -831,7 +831,7 @@ static void hvm_dirq_assist(struct domai return; } - spin_lock(&d->event_lock); + write_lock(&d->event_lock); if ( test_and_clear_bool(pirq_dpci->masked) ) { struct pirq *pirq = dpci_pirq(pirq_dpci); @@ -875,7 +875,7 @@ static void hvm_dirq_assist(struct domai } out: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); } static void hvm_pirq_eoi(struct pirq *pirq) @@ -935,7 +935,7 @@ void hvm_dpci_eoi(struct domain *d, unsi if ( is_hardware_domain(d) ) { - spin_lock(&d->event_lock); + write_lock(&d->event_lock); hvm_gsi_eoi(d, guest_gsi); goto unlock; } @@ -946,7 +946,7 @@ void hvm_dpci_eoi(struct domain *d, unsi return; } - spin_lock(&d->event_lock); + write_lock(&d->event_lock); hvm_irq_dpci = domain_get_irq_dpci(d); if ( !hvm_irq_dpci ) @@ -956,7 +956,7 @@ void hvm_dpci_eoi(struct domain *d, unsi __hvm_dpci_eoi(d, girq); unlock: - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); } static int cf_check pci_clean_dpci_irq( @@ -991,7 +991,7 @@ int arch_pci_clean_pirqs(struct domain * if ( !is_hvm_domain(d) ) return 0; - spin_lock(&d->event_lock); + write_lock(&d->event_lock); hvm_irq_dpci = domain_get_irq_dpci(d); if ( hvm_irq_dpci != NULL ) { @@ -999,14 +999,14 @@ int arch_pci_clean_pirqs(struct domain * if ( ret ) { - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return ret; } hvm_domain_irq(d)->dpci = NULL; free_hvm_irq_dpci(hvm_irq_dpci); } - spin_unlock(&d->event_lock); + write_unlock(&d->event_lock); return 0; } --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -429,7 +429,7 @@ struct domain unsigned int xen_evtchns; /* Port to resume from in evtchn_reset(), when in a continuation. */ unsigned int next_evtchn; - spinlock_t event_lock; + rwlock_t event_lock; const struct evtchn_port_ops *evtchn_port_ops; struct evtchn_fifo_domain *evtchn_fifo; --- a/xen/xsm/flask/flask_op.c +++ b/xen/xsm/flask/flask_op.c @@ -530,7 +530,7 @@ static int flask_get_peer_sid(struct xen struct evtchn *chn; struct domain_security_struct *dsec; - spin_lock(&d->event_lock); + read_lock(&d->event_lock); if ( !port_is_valid(d, arg->evtchn) ) goto out; @@ -548,7 +548,7 @@ static int flask_get_peer_sid(struct xen rv = 0; out: - spin_unlock(&d->event_lock); + read_unlock(&d->event_lock); return rv; } From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376316.609004 (Exim 4.92) (envelope-from ) id 1oGjSK-0000Ml-Cg; Wed, 27 Jul 2022 16:00:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376316.609004; Wed, 27 Jul 2022 16:00:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSK-0000Lj-8m; Wed, 27 Jul 2022 16:00:16 +0000 Received: by outflank-mailman (input) for mailman id 376316; Wed, 27 Jul 2022 16:00:14 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSI-0000JP-BU for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:00:14 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80049.outbound.protection.outlook.com [40.107.8.49]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 32b20bac-0dc5-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:00:13 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7694.eurprd04.prod.outlook.com (2603:10a6:102:e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 16:00:11 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::d4c4:d01d:5d39:920c%7]) with mapi id 15.20.5458.019; Wed, 27 Jul 2022 16:00:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 32b20bac-0dc5-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d0fvM9kHDGc1X4J1iLxhgJNIL7jV9+I3F47+m6SWR0/TXr564JScnCjr+6nJXzkZ578gedbdF67kqD1RGHiL90u2DQEW5KMunvANIR6diDzqnlUWMa2ghHQMAt8Vn9DFOsVw4TcSHtiI0Ux8IzFGG4O6JlujMPYawHWePnobxlEDJ+kTeWfwxLFuBmTawEbHnE+RjH3JFeGbVD+FTGH/2Solq27nRI12rm4tvDw9mvShc6yWcMVSwOvR2dHle/KlkkG5h+xlAJ4nbtvDc5fj6ns4MI5VnCdb7z3eLvTRX36Sk3r9o1VcDkUjPPQLtbgIvAFwwT/BcIPFgBLctqZsLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KiKQ2q0lgHbyBHN7HUm074QjCFaoPiIZWv42M+fpFog=; b=QoYBePyMYhPnwVzGZEUWusbfRO5RjDcKGDLXPMU/pT1VX64QfR7OcSU4fK/zExxHD3svMzBfFBz0E1sSidWttxSmcSCTqUFre0VB7CrYFhQJVuuoteJLbMAndAxhtZDbmi2HjrTnSzlpJzuVTGdKp/zLY4IclVYwlWp47taYv7LvEs9+7oyA6dWVOUrLV9iHyVYH/14lZ8PSQ9hNxIQ+3qxPMXTznFyRB+6qqyT9rD16S9dVyMmQfV4h7HzEvaMosiFLfhxfaNN2oedywpWJ8OD2wWRvAXE16dapJZHmXAKqM2qbdZUsGR3KPDoSX/V9viK6qNNDBsXOk/2mH3tY0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KiKQ2q0lgHbyBHN7HUm074QjCFaoPiIZWv42M+fpFog=; b=wyTMgI7Li2BBf1wggs/MpIMoJK4eTCfciJDpMA7fF1aU2Df113Pw/GbXUjHbImzockkfJrYKSJyo/6/zHNXsNxyZuP2QU9gHTAvuwgGkuSuYabg5ubICQKVYXxlaiCKgOl4svxft/V/25WRESyAqk65LKEkSLpr9yFY27Ga2R3uto4Z5GaaIRHXFC8JKq5G2J//RJ6NZWGDT5lpAGFw6TyYlU+kR2XVUAc+0LDRPHC9T8wGn42wA6QUJdzF6ipy/E1hQnGZloZOloKsGVIZWCfSgkQ8PiX1jUKmgXySFo11vmTFRPkdKYeYYYVrvHLC32o7aOzvewfNsKKE+RPS74w== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Wed, 27 Jul 2022 18:00:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Juergen Gross From: Jan Beulich Subject: [PATCH] x86: rework hypercall argument count table instantiation & use Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0042.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad7abee2-81b1-4466-612b-08da6fe915f4 X-MS-TrafficTypeDiagnostic: PA4PR04MB7694:EE_ X-LD-Processed: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba,ExtFwd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IfQO6NcmpFvOV13y66tQRRWLG3ej1vaDP2azbzP+wZz9sRvoykdV6z08KBqudvSY3WWPAGM7lbz82n+Vk8/jwve9lyom6nIzhi2Lzg83vRLTgaOt0QlVtzAappnql0W27Wa2uSMDeFIXp0lca15ZdKeLI5nSW6OeHpkf+SEcNfl5hpplWi2DZ7yZeJcj3ENOQwebwGZt11/bwKlOVgJjFWtXcPVqwAjJ/HuZigwzcMVQipjy4hwnQ8n5XbfZt1xFXlIbOcHQ4kyyVddRo5NEIntQSjLmUm9vWF5ly5EDgdUXg9JOKsDOWrXV6ie65UXfI1wzlrbW0cXarIKn2qmYcHdFh4k6ruutewAEZkhI2lyoIpfpE3b/9G5S/cYwMcSPHW1bluUn0lxTBfQY1T74ZNK9OZRS5mtZ2DXmQUqPsvJrbsIEVsunRGwpGvlY00w/dNLirlmCwPYbWTVseT5eUWG9ofestGI2kpT36o71FxlgU8sT4FPl1T5Kh/Afav+HCUlZVFJiV61gGsCoa9C4+tVG64iv+GF0LmtmCKnjKO2WdNch5P6oqi3uoL6p+G9VgQV8uecQEdXPPD5To/SmSC/jfPu2VJ5od2Uepy9gTjesWCBtpUnyEgIjPyGz8d0Cgw1ZWttcd/PZGCQPq/OvHmjliPIFp/3kxABrI7AtSuLEhESzZSF3dKEo0To3pIHlirZr0/A1nAZidEJf0CqOhh/6aO7djW2WDCN8qIv2O3/RGQg4OxwxneV7yHgHY9uv5s0clAnA6TkO9R/MvwGS291hLWtVSVOZXyUcfOvNMLjmlHn7bEjrrrAbjrpj0DsuWVtDp7OXPIPaWqUsP8sI6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(396003)(346002)(376002)(136003)(366004)(107886003)(186003)(83380400001)(38100700002)(2616005)(31686004)(6916009)(316002)(36756003)(54906003)(8676002)(4326008)(66476007)(66556008)(66946007)(26005)(6486002)(6512007)(6506007)(86362001)(8936002)(31696002)(478600001)(5660300002)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QUxGM1ltY0hsa00wcFVyaGxVRGxzNFRicFB4T1EwNDcyYXZHRTczWWc4MTBC?= =?utf-8?B?VTVKYWNSWkNvNVNCZzNjVnY2aElYQkNqWWE2Uy9UYytlUjNwbkt3R0psZC9y?= =?utf-8?B?eW1nSDNxTVM4M3JUb1NXR3NiaE9wb3pyeFFjN2FiTkJXSHY3MDZZRUFvdlIy?= =?utf-8?B?ZEFTaE1vL1NpdXlucEx5Tk9OVTNOYTgzL3JYS2thSGpBaDN5Q1VJakFFR016?= =?utf-8?B?VHBxTER3R1JZMzRZMnNKd1M3UWtUclNxSmh3eHdUNzVoaGkxSEx0SVcwOG5j?= =?utf-8?B?ZzRoS0puNGw4TXF1dkxkSXpzUmMrK2Jjem5JbUJHQ3pTQkVCUU8rT1c3L2x0?= =?utf-8?B?YVlTS213S2FPbG1ic2ttSi9nZURtN2hZUEY0UlBUQTh4TDlnVklzS21zNVh4?= =?utf-8?B?Vmg0Z04vVnUwRFd4VFpJV2x2Y3BOb3k4VjVDTUUwOEk2bmdvdndvdEg3cHNt?= =?utf-8?B?Q2lJMXg4eWZvOVhqUzg5Y3dUYmh2V2lYOTc0ZjluNzhPaHJRclltbGhLN3dl?= =?utf-8?B?bGN0aGFvOUdVUEhDb1FPV0xiRVdnN3FPUEZNa0xzMzdDbC9kbmxpekM3LzUz?= =?utf-8?B?NUUxeVVDemhkUFpZMUFlTXZSeGwzRS9xRW1MWUxYQlptMVl4SmFiZ2tnMzI5?= =?utf-8?B?cFgzOENBU2NJb0lDcHJKZitBaEVnbTE1UEp5YXg2c1V6WkJyMWJiTmFkeXF2?= =?utf-8?B?elA5UE1hSkVwamdWMHN6NWszWldocUd0RlhaNkFGZ1hieVhlcE1ERWhQOFky?= =?utf-8?B?cXcrWnpqb1pEbG1TaUpsKyt1WnhFU0JHUEJ5bFRTcTV4bXBZRWlHa3VPRUx4?= =?utf-8?B?bktVaFNYTDlXNDkvMzhZaEticy9uWHRQL0VNa24zd3JqQlprYm9QendldlJB?= =?utf-8?B?MkRaanJVS2FURGkwL2tzekJvSUYxZ2JDdXBBVXNzWVROenRGWTNQUThYYjJx?= =?utf-8?B?ZHRITDJvaDdCWEVwRFZuakFVMXhNQlBTbm5oZmx4TGpkRERqcUIyd3A1enJJ?= =?utf-8?B?b3hMei9NcGZiNG9SWk9IUVpQYnVIK281Q25waWlxU3NNK3VOTnhMeThEWkVX?= =?utf-8?B?YnBpeWdzcmx2OUpwckdVQWNOU3dDK1FyY0ZPM2FhODM5UmVpRms4SEhoVk4v?= =?utf-8?B?UGFJbWgxNHZwVUFZajUzdjFXSGk2SUpjTWZMenJVdnNTTmZWQmJKZnhtWHQ4?= =?utf-8?B?VzFwWWYzc3BpTTRXNUllQXpFd2pQMFVTV0Z3c0NJWEROQ1l6NUczbkxIenpp?= =?utf-8?B?VlJXQmVCVWZoT2Z4YlNhS3dFUGcvcU93UmJieVV2dmgrK0l3dkhRc3d4TGlo?= =?utf-8?B?MWxsY2liV1VSNlF5bm1QcUdNZjR1em5hSHJDcVAyL0h3VVRNZFVrTElTYVRE?= =?utf-8?B?TDJxTHVqbk1yZmxmc3A2c2ZiMWl2NmVGUFRhMitqcy8ySUdZVCtnMllMLzN3?= =?utf-8?B?aDlEdXduSm5NOXYzRVp0cjdPZDBvWjlTdmYxZFRJV2NWZHBJMmwvQ3RtcDV3?= =?utf-8?B?emhFV2NXbklJV0h6d2xWZGx4ZTVEcUo4NG95TDZ5MnNDV2t5a2FncnBFZFhO?= =?utf-8?B?QkpmVHYzVGxreVJpWmFrZGt2V1F5NEMrM2VGVGk2RVRTaTR3OURiNjViWE1M?= =?utf-8?B?d1VyUzFnSWY4VEE5SGtvZTNadGVRUHJJOUxpeUdJcXYyeThnbE1EN0VTaWNQ?= =?utf-8?B?MW9FR2hOTnFlNGc5QlJ6MThXRlYxY3prRDZ2U0Z0YlZ1T3M2bkFwZjB1Sy93?= =?utf-8?B?RTJNSEY2dFpmbHNQaHhpUUpCT1YzOXVnREpSMFJyZHFVQ3lscC9NdGluY0tU?= =?utf-8?B?cXgybWtsMEZTa1NCZmVXQ0lmdCtoRkRkRnZjSkhDSmQwenNIS3NlZUpjRDZk?= =?utf-8?B?TVRjSGFhZEl4dVFZeStRd3QzNmFUcXBoSG9QdUZaQmdBQ0hxMkJQTGtuMXlL?= =?utf-8?B?azBaTmJ6TEM0eVJwSFhwVm5UM0FyVi9KUm1lbTBhTDdGT0Z1TlZWeFJ0aE9a?= =?utf-8?B?RFUwbUN3dCtNUitGaHBUOEpXd0djQVUzSU9aeTkyVzFhaWNNb2Ruai9QM1h1?= =?utf-8?B?L0p2eDJuWDM5NDYzclpmaTJYcnk0Zm5vVGhHdVlZdW1GdVRmUmVtaThSSnor?= =?utf-8?Q?k+qPESH77bMMz+T9F9YqxUHSC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad7abee2-81b1-4466-612b-08da6fe915f4 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2022 16:00:11.3840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t8H7RJt95daXUzc193z2q9pElzkSXO4BPt3FySzk5BX4FULjUJA+JpVN2pDCIIOIDfuqlx26r8Q9kd00bJ7+Og== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7694 The initial observation were duplicate symbols that our checking warns about. Instead of merely renaming one or both pair(s) of symbols, reduce #ifdef-ary at the same time by moving the instantiation of the arrays into macros (a native and a 32-bit one each, where likely more redundancy could be eliminated, if we really wanted to). While doing the conversion also stop open-coding array_access_nospec(). Signed-off-by: Jan Beulich --- A tentative variant with yet less redundancy (only a single macro needed) would be #define clobber_regs(r, n, t, b) ({ \ static const unsigned char t ## b[] = hypercall_args_ ## t ## b; \ clobber_regs ## b(r, array_access_nospec(t ## b, n)); \ }) with invocations then being e.g. clobber_regs(regs, eax, hvm, 64); and with the clobber_regs() inline function renamed to clobber_regs64(). --- a/xen/arch/x86/hvm/hypercall.c +++ b/xen/arch/x86/hvm/hypercall.c @@ -111,11 +111,6 @@ long hvm_physdev_op(int cmd, XEN_GUEST_H return compat_physdev_op(cmd, arg); } -#ifndef NDEBUG -static const unsigned char hypercall_args_64[] = hypercall_args_hvm64; -static const unsigned char hypercall_args_32[] = hypercall_args_hvm32; -#endif - int hvm_hypercall(struct cpu_user_regs *regs) { struct vcpu *curr = current; @@ -177,7 +172,7 @@ int hvm_hypercall(struct cpu_user_regs * regs->r10, regs->r8); if ( !curr->hcall_preempted && regs->rax != -ENOSYS ) - clobber_regs(regs, get_nargs(hypercall_args_64, eax)); + clobber_regs(regs, eax, hvm64); } else { @@ -190,7 +185,7 @@ int hvm_hypercall(struct cpu_user_regs * curr->hcall_compat = false; if ( !curr->hcall_preempted && regs->eax != -ENOSYS ) - clobber_regs32(regs, get_nargs(hypercall_args_32, eax)); + clobber_regs32(regs, eax, hvm32); } hvmemul_cache_restore(curr, token); --- a/xen/arch/x86/include/asm/hypercall.h +++ b/xen/arch/x86/include/asm/hypercall.h @@ -43,16 +43,6 @@ compat_common_vcpu_op( #endif /* CONFIG_COMPAT */ -#ifndef NDEBUG -static inline unsigned int _get_nargs(const unsigned char *tbl, unsigned int c) -{ - return tbl[c]; -} -#define get_nargs(t, c) _get_nargs(t, array_index_nospec(c, ARRAY_SIZE(t))) -#else -#define get_nargs(tbl, c) 0 -#endif - static inline void clobber_regs(struct cpu_user_regs *regs, unsigned int nargs) { @@ -69,6 +59,11 @@ static inline void clobber_regs(struct c #endif } +#define clobber_regs(r, n, t) ({ \ + static const unsigned char t[] = hypercall_args_ ## t; \ + clobber_regs(r, array_access_nospec(t, n)); \ +}) + static inline void clobber_regs32(struct cpu_user_regs *regs, unsigned int nargs) { @@ -85,4 +80,9 @@ static inline void clobber_regs32(struct #endif } +#define clobber_regs32(r, n, t) ({ \ + static const unsigned char t[] = hypercall_args_ ## t; \ + clobber_regs32(r, array_access_nospec(t, n)); \ +}) + #endif /* __ASM_X86_HYPERCALL_H__ */ --- a/xen/arch/x86/pv/hypercall.c +++ b/xen/arch/x86/pv/hypercall.c @@ -27,13 +27,6 @@ #include #include -#ifndef NDEBUG -static const unsigned char hypercall_args_64[] = hypercall_args_pv64; -#ifdef CONFIG_PV32 -static const unsigned char hypercall_args_32[] = hypercall_args_pv32; -#endif -#endif - /* Forced inline to cause 'compat' to be evaluated at compile time. */ static void always_inline _pv_hypercall(struct cpu_user_regs *regs, bool compat) @@ -65,7 +58,7 @@ _pv_hypercall(struct cpu_user_regs *regs call_handlers_pv64(eax, regs->rax, rdi, rsi, rdx, r10, r8); if ( !curr->hcall_preempted && regs->rax != -ENOSYS ) - clobber_regs(regs, get_nargs(hypercall_args_64, eax)); + clobber_regs(regs, eax, pv64); } #ifdef CONFIG_PV32 else @@ -90,7 +83,7 @@ _pv_hypercall(struct cpu_user_regs *regs curr->hcall_compat = false; if ( !curr->hcall_preempted && regs->eax != -ENOSYS ) - clobber_regs32(regs, get_nargs(hypercall_args_32, eax)); + clobber_regs32(regs, eax, pv32); } #endif /* CONFIG_PV32 */ From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:00:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:00:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376315.609000 (Exim 4.92) (envelope-from ) id 1oGjSK-0000Jq-3m; Wed, 27 Jul 2022 16:00:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376315.609000; Wed, 27 Jul 2022 16:00:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSK-0000Jj-0j; Wed, 27 Jul 2022 16:00:16 +0000 Received: by outflank-mailman (input) for mailman id 376315; Wed, 27 Jul 2022 16:00:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSI-0000JQ-6Y; Wed, 27 Jul 2022 16:00:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSI-0001E2-2n; Wed, 27 Jul 2022 16:00:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjSH-0001fQ-IK; Wed, 27 Jul 2022 16:00:13 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGjSH-0000vY-Hu; Wed, 27 Jul 2022 16:00:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=rJmmDC293UpAQgohcK6IEo4yKsG6u7nY8xw6ciIEmrs=; b=EEGegHl7umEC7M2ziiZhMan8MB /HpDZ2xVKX/6xv4IBTPoLfxDk3kGFjgjpMzm318RJ6xVvSJs0oMEsJbsKX3gfuQSookMsBsSrLrrf IWJap3UMgLoTuz+BD3lsYh3xlDNee1J8oHeygZLjxgcBo4k6wccEx4ZJ4hqrNWzizdZA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171877: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=ef53798ab645496002aa8da2b3650dde19832f3d X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Wed, 27 Jul 2022 16:00:13 +0000 flight 171877 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171877/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt ef53798ab645496002aa8da2b3650dde19832f3d baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 747 days Failing since 151818 2020-07-11 04:18:52 Z 746 days 728 attempts Testing same since 171877 2022-07-27 04:19:09 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117414 lines long.) From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:18:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:18:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376331.609022 (Exim 4.92) (envelope-from ) id 1oGjjD-0002z7-3U; Wed, 27 Jul 2022 16:17:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376331.609022; Wed, 27 Jul 2022 16:17:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjjD-0002z0-0d; Wed, 27 Jul 2022 16:17:43 +0000 Received: by outflank-mailman (input) for mailman id 376331; Wed, 27 Jul 2022 16:17:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjjB-0002ye-QM for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:17:41 +0000 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [2a00:1450:4864:20::22e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a305c374-0dc7-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:17:40 +0200 (CEST) Received: by mail-lj1-x22e.google.com with SMTP id u20so12571541ljk.0 for ; Wed, 27 Jul 2022 09:17:40 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id q10-20020a19f20a000000b00489dd78bdacsm3850979lfh.299.2022.07.27.09.17.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:17:37 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a305c374-0dc7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=A1/uiDtrnUdSsuTb9m5A95mVj7LtpZz99YG5vTx9pKg=; b=AE9NGzJrkd1O5AzNkANK+bf7gjL/XNcgxVcISxvT7KwKGYiv4kpWZ2ULy7sOnn0aew DsBmthvEjK9FwzAWoTaAbYeVjmrVmc3BfsEgcvA+jlWMrPh2ijaqPGKi0CFVgkKKzDb8 IPlMr3LgutK3iUbu9N1w267dI4F0bI47Sjid68UYqTaa0lTmuKAaB7I/RHTvMvCnI9+S iTe/Y1WK7qNP+J/pOuzmGI6rl7XW6pBvNNgCsHJvRWeB8pEJY96nXOmeB157stOQoYD/ DVlL6miWikCqZG5uoKpY7E7yrEk0lu5u0E466L7+7UbPjomTIu7cjrikrxS0tRRgzCJc 9rvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=A1/uiDtrnUdSsuTb9m5A95mVj7LtpZz99YG5vTx9pKg=; b=uySiVDuZ94KnQQeP+TgUJgoald7k4U57zaLiSnVZZyrfYxf5i8QTY0LdP+xGTjlw1g 6uKJRM4ayxqFjuTOAHkH84ZeoWlRs1Q6Ab19VUQcJvKGGsdyN8wQHsHV7nL7RyC6FzsR fiYGlpch6bzcxn9XiRYXvxcLAPnonjV4I3o6l5B0iHZxt3HclJL2lACQ0qk+MnHoIdMn rJwhLgsaPe9BiZDvvXaz+HL1qKl2UnrLujOgxwIRF7WE/Idj8lnYUqDCWZtfU5sWM5Xi o+2pQM2cJiix+aGFmCIEg8fakvHzVYs01gS9mRJaIIjdvsDkBhqM3hU8A1QVB5tiyVAQ tw0Q== X-Gm-Message-State: AJIora/5B1ejB5X5UTnLzNvM6Oss0uRIbKoCd7ortHufAHGLPiDGZFYR K6t4SSqufXwxyFBTDgRkGr75S3uvOTSma1n7 X-Google-Smtp-Source: AGRyM1senhLAUo75mOvUnRK2V9Rfha2mEQ6N8BPuM6ywhbbI5/74u28L5MBEGwwCk6c4Wlsu4Kvh6A== X-Received: by 2002:a2e:84ca:0:b0:25d:77e0:2566 with SMTP id q10-20020a2e84ca000000b0025d77e02566mr8271642ljh.78.1658938658386; Wed, 27 Jul 2022 09:17:38 -0700 (PDT) Message-ID: <25d96933-5582-ff1e-f685-d48b5380d531@gmail.com> Date: Wed, 27 Jul 2022 19:17:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-4-olekstysh@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.07.22 13:15, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) >> if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) >> { >> bars[i].type = VPCI_BAR_IO; >> + >> +#ifndef CONFIG_X86 >> + if ( !is_hwdom ) >> + { >> + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, >> + reg, 4, &bars[i]); >> + if ( rc ) >> + goto fail; >> + } >> +#endif > Since long term this can't be correct, it wants a TODO comment put next > to it. Looking into the previous versions of this patch (up to V3) I failed to find any changes in current version which hadn't been discussed (and agreed in some form). Could you please clarify what exactly can't be correct the long term, for me to put the proper TODO here. Do you perhaps mean that TODO needs to explain why we have to diverge? > >> @@ -553,34 +635,47 @@ static int cf_check init_bars(struct pci_dev *pdev) >> bars[i].size = size; >> bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; >> >> - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, >> - &bars[i]); >> + rc = vpci_add_register(pdev->vpci, >> + is_hwdom ? vpci_hw_read32 : guest_bar_read, >> + is_hwdom ? bar_write : guest_bar_write, >> + reg, 4, &bars[i]); >> if ( rc ) >> - { >> - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); >> - return rc; >> - } >> + goto fail; >> } >> >> - /* Check expansion ROM. */ >> - rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); >> - if ( rc > 0 && size ) >> + /* Check expansion ROM: we do not handle ROM for guests. */ >> + if ( is_hwdom ) > This again can't be right long-term. Personally I'd prefer if the code > was (largely) left as is, with adjustments (with suitable TODO comments) > made on a much smaller scope only. I can revive a comment that Oleksandr Andrushchenko provided for earlier version by transforming into TODO: ROM BAR is only handled for the hardware domain and for guest domains there is a stub: at the moment PCI expansion ROM handling is supported for x86 only and it might not be used by other architectures without emulating x86. Other use-cases may include using that expansion ROM before Xen boots, hence no emulation is needed in Xen itself. Or when a guest wants to use the ROM code which seems to be rare. > But I'm not the maintainer of this > code - Roger may have a different view on this. Well, let's wait for Roger's input here. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:18:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:18:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376334.609033 (Exim 4.92) (envelope-from ) id 1oGjje-0003OK-CB; Wed, 27 Jul 2022 16:18:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376334.609033; Wed, 27 Jul 2022 16:18:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjje-0003OB-97; Wed, 27 Jul 2022 16:18:10 +0000 Received: by outflank-mailman (input) for mailman id 376334; Wed, 27 Jul 2022 16:18:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjjc-0002ye-Kz for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:18:08 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b33cf3c1-0dc7-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:18:08 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id f15so13611714edc.4 for ; Wed, 27 Jul 2022 09:18:07 -0700 (PDT) Received: from [192.168.1.93] (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.gmail.com with ESMTPSA id r9-20020a17090609c900b0072fd1e563e2sm4177577eje.177.2022.07.27.09.18.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:18:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b33cf3c1-0dc7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=D6Z74H1QnjiAxJgRth53+k0Aaa8dEJYp3Z2ikE/yk6Q=; b=kuIik6nzwflLuzsmNH9WdUuUxFZNl46TgNoS2D+jqIkGMQhZQ41Dvi+HufCvOKEbJx fPzesN/MEY8j6dyajY3DnW4Z5X1Tl7HNwyY6f9VJgfFqRZAr0zSRNSLJXUPFYhFhvp1t aIgswFa9aBEWX+km+KtnCeTKlej32LThDz+HiJf5JKZkbdSQ5kV+0TYc55lqFA9Nl3Ro pfSGIygLqaaAw/XxcZTsGOBBnFWYfJ3vLRdRW0nwtiHvgnIWobQ+9sXKSbK7w3KxvRWG X/+NLN6yheLUD1glR2VZKRkZhyaFYWzD700ygrpGLl/CW0w7jNOTAywLFoNJUVMGdeHb f62Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=D6Z74H1QnjiAxJgRth53+k0Aaa8dEJYp3Z2ikE/yk6Q=; b=sV8LwRFDH1tffOvb5LOcP6ZhhM/9mP8ZbC1PhckYaiJM06yRKkJ2kNKkvGkEUtEaVU Pe2XxUTdb24jDnvV5htaZTLJgA99U0zMvbcbf6R7IuRqd46pcfOzBmOJ4OUHiD7ZHyt4 eiGLN13IaIl7pyHKaWzgkD+L6LS6xpzLrLF2vhvyRp0wMhNGT6VapEDUmD3V4FCCSIm7 f1ggQ2oejTHCfX8evY/oaPFHiBM7chpzcbZKK48cx4fthOw4WJjufmCcCs/wEpm9fpHc ExpTzkXbf0zUeYgdfWRTRrtGInNZ26uM76fL6Jq3oKvS5bvHNRlWAdeNP9tVzRgZXhNT 2f2w== X-Gm-Message-State: AJIora8GPCjbrRRXdXN81xzRa2CLrc13eYCZNEJsDdQ5R7J0P6pF9P7D AixLirx2whCi76XyzAzXH5E= X-Google-Smtp-Source: AGRyM1vgyhXRnZYWO+inoKaatYt2BGwiLbzpgQnXH4AQl+TX6/kiUoY+6pyn559NIypeLDlMGzogBw== X-Received: by 2002:a05:6402:1c01:b0:43a:f714:bcbe with SMTP id ck1-20020a0564021c0100b0043af714bcbemr23782567edb.14.1658938686980; Wed, 27 Jul 2022 09:18:06 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 19:18:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-2-burzalodowa@gmail.com> <9db28ce4-d4dd-3806-75c7-a6746d40cbb4@suse.com> From: Xenia Ragiadakou In-Reply-To: <9db28ce4-d4dd-3806-75c7-a6746d40cbb4@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/27/22 18:36, Jan Beulich wrote: > On 27.07.2022 17:32, Xenia Ragiadakou wrote: >> The macro parameter 'p' is used as an expression and needs to be enclosed in >> parentheses. > > Yes, but ... > >> --- a/xen/arch/arm/include/asm/atomic.h >> +++ b/xen/arch/arm/include/asm/atomic.h >> @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, >> } >> >> #define read_atomic(p) ({ \ >> - union { typeof(*p) val; char c[0]; } x_; \ >> - read_atomic_size(p, x_.c, sizeof(*p)); \ >> + union { typeof(*(p)) val; char c[0]; } x_; \ >> + read_atomic_size((p), x_.c, sizeof(*(p))); \ > > ... not in the first argument's case - that's not an expression. > Too few parentheses are a risk, but too many are as well, as they > negatively affect readability. > Yes you are right. Here write_atomic_size((p), &x_, sizeof(*(p))); as well. I will fix and resend. -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:23:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:23:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376343.609044 (Exim 4.92) (envelope-from ) id 1oGjom-0004xg-VT; Wed, 27 Jul 2022 16:23:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376343.609044; Wed, 27 Jul 2022 16:23:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjom-0004xZ-SS; Wed, 27 Jul 2022 16:23:28 +0000 Received: by outflank-mailman (input) for mailman id 376343; Wed, 27 Jul 2022 16:23:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjok-0004xT-Us for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:23:26 +0000 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [2a00:1450:4864:20::62a]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 70c07bc8-0dc8-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:23:25 +0200 (CEST) Received: by mail-ej1-x62a.google.com with SMTP id oy13so32415723ejb.1 for ; Wed, 27 Jul 2022 09:23:25 -0700 (PDT) Received: from [192.168.1.93] (adsl-141.176.58.136.tellas.gr. [176.58.136.141]) by smtp.gmail.com with ESMTPSA id f5-20020a50fc85000000b0043bc4b28464sm10378953edq.34.2022.07.27.09.23.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:23:24 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 70c07bc8-0dc8-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=G08N5bSFGkYSDwBXKJmOXPlcD7JJ7qUNPKUzzL2YRMo=; b=jH/aUNJhGEN2yDr7xmJg50wJhLtoOLP2Lnee96Joo+252KIel/gEr4r1l63NOgZNRT kh37tl8nRA6lXA74eWWdGzlOqbmC9xo4ZhyK1+o/eZ9qQje2wTV+3UVXLOg30bfexRiF jSCK4bT6M0h5aoRchm1InB6Msp8oqPcnHZqaD4+Cd4Y9MFzprMJ4Y1kTw7badxnmtGMJ Dahjj8FumR6YUuvh69/02emuhRUFVg81gdiJcqcmt7p+y/Qrr3G5wBTQSp1amcnbQi7E OeM9svmfqZrmbZ6KRLXFh+K4PbofkchkpFyuc0BI1yeRpBERiCdHSe7QLODliFrgq0bZ 4apQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=G08N5bSFGkYSDwBXKJmOXPlcD7JJ7qUNPKUzzL2YRMo=; b=3wfhZLgVAOFpZrKsIHUjwxM/MZ5ECK1zPSSNugqMyvKMrn9cPxx62HI+RccPCOHsUr M58pBDuNlVFTTEES7pN20iizMEshhfybywjQndppelPGo7vr+rSUqM1rBUGGpiMQZdAs LO+YfTJNKGOwpgk/qcKmKVAbv1wBv1U1wmru5QUfi+co/r4hid+bxn9W+m2fNdhiE+7g 7U8dHJ2pLbUM3+FXTWXBHswWNNFf7O4xyTGZZf93AlBuUYQrR0gTJyQsf4zpSzFMB6iE S7vfYKYoICpruaq3fZpuzKE+tEERjeB3W3HFZOVOgqIB0lCuvrW5JqZ3NDVy6fzPmGcm Iw4w== X-Gm-Message-State: AJIora8rdCEtX/mW+33SkOu6wtiI2t39JZtQX5ScG8J15f2PKpfkCKcy M2shtc6oWstSqB+/U5ZE3EU= X-Google-Smtp-Source: AGRyM1usJOxVG0oiNbvsRebl/ycuSg1W+h4IJ+Si5kFTp0R4ehTdG+LMcSPXJWGJXa59MyUo4INXaQ== X-Received: by 2002:a17:906:7482:b0:722:edf9:e72f with SMTP id e2-20020a170906748200b00722edf9e72fmr17865294ejl.92.1658939005123; Wed, 27 Jul 2022 09:23:25 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 19:23:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 7/27/22 18:46, Julien Grall wrote: > Hi Xenia, > > On 27/07/2022 16:32, Xenia Ragiadakou wrote: >> Remove unused macro atomic_xchg(). >> >> Signed-off-by: Xenia Ragiadakou >> --- >>   xen/arch/arm/include/asm/atomic.h | 2 -- >>   1 file changed, 2 deletions(-) >> >> diff --git a/xen/arch/arm/include/asm/atomic.h >> b/xen/arch/arm/include/asm/atomic.h >> index f5ef744b4b..a2dc125291 100644 >> --- a/xen/arch/arm/include/asm/atomic.h >> +++ b/xen/arch/arm/include/asm/atomic.h >> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, >> int a, int u) >>       return __atomic_add_unless(v, a, u); >>   } >> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >> - > > While I agree this is unused today, the wrapper is quite trivial and > part of the generic API (x86 also provides one). So I am not in favor of > removing it just to please MISRA. That's fine, the rule 2.5 is advisory. I sent the patch because I noticed that the macro was unused, just in case ... > > That said, if Bertrand and Stefano agrees with removing it then you > should also remove the x86 version to avoid inconsistency. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:23:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:23:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376344.609055 (Exim 4.92) (envelope-from ) id 1oGjp0-0005Ib-6k; Wed, 27 Jul 2022 16:23:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376344.609055; Wed, 27 Jul 2022 16:23:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjp0-0005IP-35; Wed, 27 Jul 2022 16:23:42 +0000 Received: by outflank-mailman (input) for mailman id 376344; Wed, 27 Jul 2022 16:23:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjoy-0005H9-1L; Wed, 27 Jul 2022 16:23:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjoy-0001io-0A; Wed, 27 Jul 2022 16:23:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGjox-0002fk-F0; Wed, 27 Jul 2022 16:23:39 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGjox-0003XM-EV; Wed, 27 Jul 2022 16:23:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=yb6j3VgW2M85ABnvCLmeInK3H9VPt5HloHYeA+lBps0=; b=KsOY2Qe/AN/dsLyCulhAu49p+w 5MVpBc2QzOAm3FfNSUh7RufpJiD9spOKEduB3tSrgl1MR/cyPGLCWBFGSBPs2gvxfgsBMKy657MDA wvrNXB90h0ZzzgBjTUfTTfX4dG8zF1PA6303CYrl1nOv8uQF+cPVY6AecOt8wDgSZjQs=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171883: all pass - PUSHED X-Osstest-Versions-This: ovmf=e3d468acb9ce26a75fee45d742619ac1c6683280 X-Osstest-Versions-That: ovmf=b68d566439683d0ebe60d52c85ff0e90331db740 From: osstest service owner Date: Wed, 27 Jul 2022 16:23:39 +0000 flight 171883 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171883/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e3d468acb9ce26a75fee45d742619ac1c6683280 baseline version: ovmf b68d566439683d0ebe60d52c85ff0e90331db740 Last test of basis 171878 2022-07-27 05:12:12 Z 0 days Testing same since 171883 2022-07-27 10:10:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Konstantin Aladyshev jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git b68d566439..e3d468acb9 e3d468acb9ce26a75fee45d742619ac1c6683280 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:40:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:40:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376357.609065 (Exim 4.92) (envelope-from ) id 1oGk55-0008BH-La; Wed, 27 Jul 2022 16:40:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376357.609065; Wed, 27 Jul 2022 16:40:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGk55-0008BA-Ig; Wed, 27 Jul 2022 16:40:19 +0000 Received: by outflank-mailman (input) for mailman id 376357; Wed, 27 Jul 2022 16:40:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGk54-0008B0-MW; Wed, 27 Jul 2022 16:40:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGk54-000292-H1; Wed, 27 Jul 2022 16:40:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGk54-0003P4-2i; Wed, 27 Jul 2022 16:40:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGk54-0004F2-2G; Wed, 27 Jul 2022 16:40:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=DFqDivQaioINn3i3eU+jIDUZWUm0Uq3zvedyW2IOTn8=; b=Ui0i3pphwpObPufraLUDXvLWV0 heA0rvNTcwLNFj1z1EeQPC9Keu2ZGtHkhnwn9Iwd1yvL5ttJdr1XRu9SOg10bZiwXgC0vZvIWt402 bO4cFAgB6/v2D2rAnm4B7XPhhnFA9WKuo2XIyfbgwwAVKwNB6IOxazdXLtN6zdldWTzg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171873: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:windows-install:fail:heisenbug xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=a9949efb288fd6e21bbaf9d5826207c7c41cda27 X-Osstest-Versions-That: xen=5707470bf3103ebae43697a7ac2faced6cd35f92 From: osstest service owner Date: Wed, 27 Jul 2022 16:40:18 +0000 flight 171873 xen-unstable real [real] flight 171886 xen-unstable real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171873/ http://logs.test-lab.xenproject.org/osstest/logs/171886/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 171886-retest test-amd64-amd64-xl-qemuu-win7-amd64 12 windows-install fail pass in 171886-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail in 171886 like 171862 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171862 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171862 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171862 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171862 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171862 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171862 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171862 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171862 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171862 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171862 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171862 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen a9949efb288fd6e21bbaf9d5826207c7c41cda27 baseline version: xen 5707470bf3103ebae43697a7ac2faced6cd35f92 Last test of basis 171862 2022-07-26 09:38:13 Z 1 days Testing same since 171873 2022-07-26 19:38:29 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Jan Beulich jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 5707470bf3..a9949efb28 a9949efb288fd6e21bbaf9d5826207c7c41cda27 -> master From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:49:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:49:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376367.609081 (Exim 4.92) (envelope-from ) id 1oGkDd-0000iR-NZ; Wed, 27 Jul 2022 16:49:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376367.609081; Wed, 27 Jul 2022 16:49:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkDd-0000iK-KR; Wed, 27 Jul 2022 16:49:09 +0000 Received: by outflank-mailman (input) for mailman id 376367; Wed, 27 Jul 2022 16:49:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkDc-0000iE-Sm for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:49:08 +0000 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [2a00:1450:4864:20::232]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0802353a-0dcc-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:49:07 +0200 (CEST) Received: by mail-lj1-x232.google.com with SMTP id a13so20282981ljr.11 for ; Wed, 27 Jul 2022 09:49:07 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id m11-20020a056512358b00b0048a9c80b1e0sm1253989lfr.222.2022.07.27.09.49.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:49:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0802353a-0dcc-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=J+BIu8dvT0r9UxhXK/5a+hhRnuG2ihMDgGlCzp9aa9M=; b=A+RiozcYBpUWbMcD4KJfzXbEiScLtIeGNWtel9SOQpXL88xpLqBy/RTBm4GLWhcqqE AUsDe7OifKPd54OOSSG6l+bhY7xbiDv6+USTEGOeIeVTIVyAeRmzUg9PN8QgFjYazCBa blD03+kBqbc+iO24B0WXgxXwvYC6rbAXiuG+CCRCI14b3Oq2Mowdl+xrYBBdLy65+crk oCbKICo/4i5espo2alQmiw1MVk7AivyOcl6fjsWlE+M/afP6msM52OQ1i1YevF1zknMU AcXTBnIw7zxPuxHylbGfep5Ue2kZP9lISElUjEFkkbQbbSw+BuOp30DDiIJc8tbaQfUy qmmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=J+BIu8dvT0r9UxhXK/5a+hhRnuG2ihMDgGlCzp9aa9M=; b=8Nfz3hbqL8zj3I5RSOW6hOl2k8GMiq0F5eWxWPROi++bh+FXrWZtlwB+Ldny0zpZgs lx4GxPKDNBOmWDfur7p3D5LMliueS3NZdgWAWfYNANV+I9HsHN85JgWT0bC8acocku1/ PIHW3vSE8ODj0R3hnqdxtjY61nLTrga7SRjhun5NIEaqCo1JIDWZE46RtrSVxdjTYxfR 1KHZTR6rmsRiyBd60SUe6UNTTY9SXKdhvRyHWkpCKWu1rF92DD2vVb77NjB7JGjSjjjn GQSXXryOJTScdMXJL56UHnQkqdp9OF2kozzieDJe5r6bTC+2ZS6klWJtKjb8zimMvYpG i4Kg== X-Gm-Message-State: AJIora/+Y/43OnRKuvWZKa0fvsOsP7MjS5pwocxkQ8jxqTFc1K/NJ2/5 exm9E1RASDkNoQagsBlxuGc= X-Google-Smtp-Source: AGRyM1s2O7maffbnF7LSKnmwAcpbaPHjZm2fgkJAw8ECnae1P8fulcT2Ml5CTC/7Pah98/Lwx12hVw== X-Received: by 2002:a05:651c:1a08:b0:25e:228c:a0e3 with SMTP id by8-20020a05651c1a0800b0025e228ca0e3mr1372463ljb.480.1658940547299; Wed, 27 Jul 2022 09:49:07 -0700 (PDT) Message-ID: <6960a01d-f0a8-bedc-1e64-a64be29f8e88@gmail.com> Date: Wed, 27 Jul 2022 19:49:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 02/11] vpci: add hooks for PCI device assign/de-assign Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , Paul Durrant , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-3-olekstysh@gmail.com> <51afa25b-93ea-2685-b238-2edd9292bece@suse.com> <2e0efae5-27f7-831d-6f9e-06d03374b716@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27.07.22 17:35, Jan Beulich wrote: Hello Jan > On 27.07.2022 16:01, Oleksandr wrote: >> On 27.07.22 13:03, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>> @@ -1603,6 +1610,10 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag) >>>> pci_to_dev(pdev), flag); >>>> } >>>> >>>> + rc = vpci_assign_device(pdev); >>>> + if ( rc && deassign_device(d, seg, bus, old_devfn) ) >>> ... use pdev->devfn here. >> >> Thanks, good point, will drop old_devfn and use pdev->devfn. I am >> wondering whether the printk after "done:" label (and other possible >> printk-s down the code) should really use pdev->devfn instead of devfn >> in PCI_SBDF construct? > Yes, that's intended: If assigning a phantom function fails, this > should be distinguishable from failure to assign the real device. Thank you for the clarification. Hmm, so before this patch the assigning of phantom functions was the last action before the "done:" label. So I will probably need to check for "rc" before calling vpci_assign_device(). Something like that: [snip] @@ -1602,6 +1606,17 @@ static int assign_device(struct domain *d, u16 seg, u8 bus, u8 devfn, u32 flag)          rc = iommu_call(hd->platform_ops, assign_device, d, devfn,                          pci_to_dev(pdev), flag);      } +    if ( rc ) +        goto done; + +    devfn = pdev->devfn; +    rc = vpci_assign_device(pdev); +    if ( rc && deassign_device(d, seg, bus, devfn) ) +    { +        printk(XENLOG_ERR "%pd: %pp was left partially assigned\n", +               d, &PCI_SBDF(seg, bus, devfn)); +        domain_crash(d); +    }   done:      if ( rc ) [snip] > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 16:53:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 16:53:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376373.609091 (Exim 4.92) (envelope-from ) id 1oGkHe-000278-8o; Wed, 27 Jul 2022 16:53:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376373.609091; Wed, 27 Jul 2022 16:53:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkHe-000271-6I; Wed, 27 Jul 2022 16:53:18 +0000 Received: by outflank-mailman (input) for mailman id 376373; Wed, 27 Jul 2022 16:53:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkHc-00026u-J1 for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 16:53:16 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9bb88305-0dcc-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 18:53:15 +0200 (CEST) Received: by mail-lj1-x235.google.com with SMTP id p21so12820907ljh.12 for ; Wed, 27 Jul 2022 09:53:15 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id h19-20020ac25973000000b0048a95c0ff47sm1462705lfp.213.2022.07.27.09.53.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 09:53:14 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9bb88305-0dcc-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=5cZCO3x1nF3vmQsZHzH3PFGIKTP7h8r5EymDgu+bUpA=; b=DGAbpn5P4rOAxZSLeTePCMLOngZ0NHpPinw2u9WdYmXIbmu8yjOMnL1DA3q3aAFErx NLyVW/RgDjm/xcZBM6TpxrPG9FrOp0SWXuehEcUujmSvDd07VSnIixX4UHbd2Z8TIObd ILuAP3moVgz7w9FUUdOi2SxyYEAGnSklwYVyH1HxY8EfDup/mVXLoxac0JIYBapuikoS MhO93Jb/dPweqrZ6QMEgOWoLDevbVwm7oarJvmJpaKnfxQmYUNU9HngKyNV1oAQZhKrk N3WA+6amgKzhmmhpRvz6A2xyP9cyK8A6O0dEtpI+kXCaILuglGas45PB6ppDdB7nJZnN 01Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=5cZCO3x1nF3vmQsZHzH3PFGIKTP7h8r5EymDgu+bUpA=; b=4Hlw1W9qwM6SFrFweQGjv9PLEjLfxji0nor/aNx1wJgj50IhZbCFkRr8sbVG/Pjrzi jE+IS9xLw4LE6LuaracKOdVQ15hQPkk94/F0tC+JDPDpUvF/+ZBgRVS0lIlpSHH+QcvY laqw133nvG49x1UEmlLh2ekgkKZma0XpjgljWnohxRRfSbhHxo8+E8FfTzGSHioxEO7v E7NbjcoVmhaES34EM9VPPg/Hv9XE/ZW6UCg7hDa+5dCiX2Tcz5YqnqBLWauhFQfzn3m2 HK2afmzkjatUPeBuWcHWFvt/WETGWIfl4PbTq6zWrzaCpNWo1r/TqRbi6kynKTQiLo8H pFwg== X-Gm-Message-State: AJIora9mgLPjf3OwK0OK/RpUx3BtJUlIMYZPyFH1ZGOGG9jYQgGaBQEi 2n0HkccprxWTDEVfNK5E/SA= X-Google-Smtp-Source: AGRyM1uFUnwMCpYJdwvfIQSfdvDdFA9cCdVGJIis5qYJv+cZnglJZOawSvAO2n/ewTbSga02oTpPow== X-Received: by 2002:a2e:a591:0:b0:25d:7366:3344 with SMTP id m17-20020a2ea591000000b0025d73663344mr8339394ljp.242.1658940795296; Wed, 27 Jul 2022 09:53:15 -0700 (PDT) Message-ID: <46ef9a6b-f13d-c751-8fb2-fb7293646bd2@gmail.com> Date: Wed, 27 Jul 2022 19:53:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 08/11] vpci/header: reset the command register when adding devices Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-9-olekstysh@gmail.com> <450660e2-69cb-ea3c-2d91-4e671eb5d552@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.07.22 12:46, Jan Beulich wrote: Hello Jan > On 27.07.2022 10:58, Oleksandr wrote: >> On 26.07.22 18:23, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Andrushchenko >>>> >>>> Reset the command register when assigning a PCI device to a guest: >>>> according to the PCI spec the PCI_COMMAND register is typically all 0's >>>> after reset, but this might not be true for the guest as it needs >>>> to respect host's settings. >>>> For that reason, do not write 0 to the PCI_COMMAND register directly, >>>> but go through the corresponding emulation layer (cmd_write), which >>>> will take care about the actual bits written. >>>> >>>> Signed-off-by: Oleksandr Andrushchenko >>>> --- >>>> Since v6: >>>> - use cmd_write directly without introducing emulate_cmd_reg >>>> - update commit message with more description on all 0's in PCI_COMMAND >>> I agree with the change, >> thanks, may I please ask can this be converted to some tag? > I could offer a R-b, but you've got one from Rahul already, so mine > won't buy you anything further. What you will need is a maintainer > ack, which imo isn't a priority since this is only patch 8 in a > series which itself depends on a further series likely continuing > to be controversial (didn't get there yet). ok, fair enough. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 17:06:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 17:06:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376380.609103 (Exim 4.92) (envelope-from ) id 1oGkUH-0003yk-Eu; Wed, 27 Jul 2022 17:06:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376380.609103; Wed, 27 Jul 2022 17:06:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkUH-0003yd-Ba; Wed, 27 Jul 2022 17:06:21 +0000 Received: by outflank-mailman (input) for mailman id 376380; Wed, 27 Jul 2022 17:06:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkUG-0003yX-4j for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 17:06:20 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6eab4ed7-0dce-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 19:06:19 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id t22so21622690lfg.1 for ; Wed, 27 Jul 2022 10:06:19 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id u14-20020a19790e000000b0048a7e6ed48esm1569458lfc.40.2022.07.27.10.06.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 10:06:18 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6eab4ed7-0dce-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=A3BFnm6quA5PZHzhF6DcYZSnvXb4YsoaToHYvHfSHd4=; b=GYnRJ5zgTT5cQFueHn9+27vDGkbgM0bGsk30nd+IuDfEpTtMfjvTDVomPNvUHQ+ujB j5sj9aK/4OQsxQso92hXPmzCbNa8LK31CiWyiVIIuo/5oK3zGcv8QWAQeQjV4DtVMzjf uEO5D3G0pbhWiGxEVTHaeJnTvtl53cs2xgWcZW2hj3B1RIas+bhysRBsBzvdk0pkYNLo iqD4XwUUC/8ACMfbW1NK6GNnIz7RvhMsgnYFGY+83lZSTzD2EvDFxaX9eSN/7AVBrN2v K3FzhywKVi8NT3006wjEsbBIkvyAefrYyA++wnBVQMyH+HcfrX0C9XhOQZmDCyNieogT qUzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=A3BFnm6quA5PZHzhF6DcYZSnvXb4YsoaToHYvHfSHd4=; b=kOrtbMf43cnZu8uER0qOEJD02ESP1yrVEbRuciRpWbrvAHDDlUeFoxPpPbCYDOON+J J+WDrQHKR4YSRuKWeqZRhqWjEq+wnKGUGA3qg9Xtd21mSu3AvfOtMXF1KmHhpulwObve B8SfUedhiwQGBKLibw/CnIvKaJ++RVg+kv5gm29ymoRWups5rIS0J0lVuJK7q8nAwQcu uifpEQ+TTHjcTiQelpm4puf0Lr2sNLroSHeTjB7O3TLHdjU4Bdv6dKUQdGRJ6GB3Pp5v W3Up1AGnzp93FrUCCjiU9o/B9psv5F8c5tXmPpqGCVzwMEcTBYY2tlRTCjl+AwhXNlAe tZQw== X-Gm-Message-State: AJIora/ck94wFJth7NHxaVY0eCutokeMvCo0Nzy5b6vkbs2/s3W8+fSJ xPE2Osf6EjJ1FEYO3RQFKmI= X-Google-Smtp-Source: AGRyM1vjHWvXg2f/9ghvsBJA4UuHZ7ZgUBwde/SkI9p/MywwdpCPx9uo8dpwJtnhED6QQ9WgUfEcJA== X-Received: by 2002:a05:6512:23a6:b0:48a:8844:3f61 with SMTP id c38-20020a05651223a600b0048a88443f61mr6044588lfv.652.1658941578522; Wed, 27 Jul 2022 10:06:18 -0700 (PDT) Message-ID: <6a687fa9-aae0-2257-5d95-91b00db1613a@gmail.com> Date: Wed, 27 Jul 2022 20:06:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-7-olekstysh@gmail.com> <85853c9f-5706-22dc-4798-48c775a17d12@suse.com> From: Oleksandr In-Reply-To: <85853c9f-5706-22dc-4798-48c775a17d12@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 27.07.22 13:19, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> From: Oleksandr Andrushchenko >> >> Take into account guest's BAR view and program its p2m accordingly: >> gfn is guest's view of the BAR and mfn is the physical BAR value as set >> up by the PCI bus driver in the hardware domain. >> This way hardware domain sees physical BAR values and guest sees >> emulated ones. >> >> Signed-off-by: Oleksandr Andrushchenko > If taking the previous patch as given, the patch here looks okay to me. This is a good news, thank you. > But since I'm still not really agreeing with what the previous patch > does, Previous? Sorry, I didn't see any comments given for "[PATCH V7 05/11] vpci/header: handle p2m range sets per BAR". Or do you perhaps mean "[PATCH V7 03/11] vpci/header: implement guest BAR register handlers" where you explicitly mentioned concerns? > both that and this one will need to be judged on by Roger once > he's back. Let's wait for Roger's input here as well. > I'm sorry for the therefore resulting further delay. no problem > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 17:19:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 17:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376388.609113 (Exim 4.92) (envelope-from ) id 1oGkgT-0005pk-LF; Wed, 27 Jul 2022 17:18:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376388.609113; Wed, 27 Jul 2022 17:18:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkgT-0005pd-Ia; Wed, 27 Jul 2022 17:18:57 +0000 Received: by outflank-mailman (input) for mailman id 376388; Wed, 27 Jul 2022 17:18:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkgT-0005pW-4W for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 17:18:57 +0000 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [2a00:1450:4864:20::531]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31dae75d-0dd0-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 19:18:56 +0200 (CEST) Received: by mail-ed1-x531.google.com with SMTP id f15so13868880edc.4 for ; Wed, 27 Jul 2022 10:18:56 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id k14-20020a170906578e00b0072f03d10fa0sm7826551ejq.207.2022.07.27.10.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 10:18:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31dae75d-0dd0-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6dc4z0oKWGxuRUkvqyuKc5/mNW97MFIan+sLcG8xT44=; b=hyHH8GyxXttS+QeEhdoDw4/erFOXrx6xBxlE5c0sdMZ6CG2yTJVIi+Dr2H/Qzq8KMn gfLY1vIcUBEXq81y+UKbnv3q1fZYXDRS+lpxuS4UVaWaO8KgIvF2hnS06qDs2UOmyvV0 3X59ibFyNGewcmMUPSbat6xyspvGNPwCK5BMHlA/FAdPnB3cpe0EM7BJ9dnSa8G2XSra w+wUX1qGq0yIgXGecMrCEF4F6Udob5BgsD4DLn01uFX0yv0LoDJBYfRvgPVXGIbl82Hd TIjnCOBXSwuxry89AKpmFw7zyf1tsAoQsiLLTG5pZVW4mledMydNAxSPBO+0zPTkOtzB ia7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6dc4z0oKWGxuRUkvqyuKc5/mNW97MFIan+sLcG8xT44=; b=Q4djabd9ELD5rKlbjDZqBPgwto6al6qz7o9RqN/SbydfX8Dtj8jeli4er23dmmNHYy xU6YAJ9hBdejZfNaYUNa5PKgYW0FoVbEgN+/6IcQbFCtN7+mkmHyygtMtpql5fwFBqvu 2JIn1Bb5Ce2a43zzGIqmvfOx7GTvXmDrAPOW0SlEMKttpOUgi3bsBlc/vnxAtgGvTKlx 0AQa8+/R3UduiHe1Uj6JvJ/ttJ3DL6R5nofFz1ou0M5J5eesKb2jMizQV4gdWlEZP414 mavUjQdfvdHHAh7RDXEPnVRykJ2lN5uiD6/7Q/KiLek8KRVZ4ftn0e846IsVIk9+SzHt Uimg== X-Gm-Message-State: AJIora91k5tGNfH6nBy3MWBa23vgZha/9PmmSGlfEG1YzbnVk2Qayei4 wJtlLaTlT1g9xb2LDZsxWoBlTVcm82E= X-Google-Smtp-Source: AGRyM1uvZH/I4fshtv90uZKvfa2I+EYfM+xq27caYRGuw7brhwyXtxKzyH/WVPU88ybx6rzsaE2nsg== X-Received: by 2002:a05:6402:5384:b0:431:6d84:b451 with SMTP id ew4-20020a056402538400b004316d84b451mr24037645edb.46.1658942335109; Wed, 27 Jul 2022 10:18:55 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 0/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule violations Date: Wed, 27 Jul 2022 20:18:40 +0300 Message-Id: <20220727171841.1163075-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series fixes violations of rule 20.7 found in xen/arch/arm/include/asm/atomic.h. Changes in v2: - removed redundant parentheses in patch 1/2 - dropped patch 2/2 that removes unused atomic_xchg() because changes Xen's atomic API, and such a change cannot be justified since compliance to MISRA C Rule 2.5 is advisory. If at some point it is decided to remove the relevant macro, this will be done for both arm and x86 with a separate patch. Xenia Ragiadakou (1): xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation xen/arch/arm/include/asm/atomic.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 17:19:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 17:19:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376389.609125 (Exim 4.92) (envelope-from ) id 1oGkgW-00065q-T5; Wed, 27 Jul 2022 17:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376389.609125; Wed, 27 Jul 2022 17:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkgW-00065h-Q7; Wed, 27 Jul 2022 17:19:00 +0000 Received: by outflank-mailman (input) for mailman id 376389; Wed, 27 Jul 2022 17:19:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGkgV-000656-Vo for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 17:18:59 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3389cc29-0dd0-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 19:18:58 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id e15so22338044edj.2 for ; Wed, 27 Jul 2022 10:18:58 -0700 (PDT) Received: from uni.router.wind (adsl-141.176.58.226.tellas.gr. [176.58.226.141]) by smtp.googlemail.com with ESMTPSA id k14-20020a170906578e00b0072f03d10fa0sm7826551ejq.207.2022.07.27.10.18.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 10:18:57 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3389cc29-0dd0-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xnvVfEqmjRjBCDFSJi6lf9ny0uz/eCXL5W95bOdHMNI=; b=DGsBaG4xMJe+ddRa1N2bJw9VnBLwbm/L9aGKv0ks+WcxlHdTCuF2qgq69KGHAQMYC9 5iePU7cOcNmGGN75wtNrHN3QIJfUdEqyKrR++ZCAwr6M4566tD2q0cTPoVUuVxMjmOAa CaDtuDLr83G/S6YgM56QKyJnIjRhIF0zb2favD8IwPR8ZiUwYGMpM2uZxxUw9nG8pvJ5 9UjIAMHhDKb5R+3etzRj/Bur5qrNb5pTTDz4FGx0WD6hF7RSu211pWdeTt2ZXetU3aAu UoTmjEKfN8yqODI/HYFV/Giwom7Wlw+gIV0BzrmH2X2L7RI45Evu70Im9OMPbo+ccwpP edag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xnvVfEqmjRjBCDFSJi6lf9ny0uz/eCXL5W95bOdHMNI=; b=IF6X19KZHa05zDWFv4tqgQrdqR1gJK8xfPK0+ok5rWV67ppK5QAcd5ubYpxumr1q7U btpyysUAHWNreZ4CXENoQOy7f+c3tA0hhi5f0YcxwxXqn+8Qo0m13VbvHXUJUfN183vo wpZRBd2XOoxZYLBGUX+MJDYu0OcNO4WutQz8Wo4zaBJC+eeBErjOPB2uJJWt/Hl3clzN NUQPul+aaxbjvWcT8fkqevn6hJTqab8Icd/eD8aPt4s2MAKf1pS1UshRPWYxNF+DdJgC rMtZ1HOtMccJ2zlD+QVii0+VDaUJykyNUMDXTKCKuEKUIZx9Jk7N60WqDwkAghaCVK6f Slbg== X-Gm-Message-State: AJIora+AoQyf34BryGx+qaljOump6kqRqT0Nxr7FFi6/I6fQX3whnUpx gv3GURAT0tWJNqPXhydVaDKS6qkt1yE= X-Google-Smtp-Source: AGRyM1vn7nqAOUUi+fkgDrp93OtyZL9CGKqBf/LuYHdTgy7AMla4pcV2+H7eEJwimLaA5SK6GajvQA== X-Received: by 2002:a05:6402:4390:b0:43b:e9d9:f9e4 with SMTP id o16-20020a056402439000b0043be9d9f9e4mr18768578edc.361.1658942337935; Wed, 27 Jul 2022 10:18:57 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2 1/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation Date: Wed, 27 Jul 2022 20:18:41 +0300 Message-Id: <20220727171841.1163075-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220727171841.1163075-1-burzalodowa@gmail.com> References: <20220727171841.1163075-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove parentheses in the cases that p is not used as an expression that is when it is used as a function argument xen/arch/arm/include/asm/atomic.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h index ac2798d095..1f60c28b1b 100644 --- a/xen/arch/arm/include/asm/atomic.h +++ b/xen/arch/arm/include/asm/atomic.h @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, } #define read_atomic(p) ({ \ - union { typeof(*p) val; char c[0]; } x_; \ - read_atomic_size(p, x_.c, sizeof(*p)); \ + union { typeof(*(p)) val; char c[0]; } x_; \ + read_atomic_size(p, x_.c, sizeof(*(p))); \ x_.val; \ }) #define write_atomic(p, x) \ do { \ - typeof(*p) x_ = (x); \ - write_atomic_size(p, &x_, sizeof(*p)); \ + typeof(*(p)) x_ = (x); \ + write_atomic_size(p, &x_, sizeof(*(p))); \ } while ( false ) #define add_sized(p, x) ({ \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 17:31:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 17:31:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376400.609136 (Exim 4.92) (envelope-from ) id 1oGks8-0000Ra-0H; Wed, 27 Jul 2022 17:31:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376400.609136; Wed, 27 Jul 2022 17:30:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGks7-0000RT-SN; Wed, 27 Jul 2022 17:30:59 +0000 Received: by outflank-mailman (input) for mailman id 376400; Wed, 27 Jul 2022 17:30:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGks6-0000RN-DF for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 17:30:58 +0000 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [2a00:1450:4864:20::235]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id dfcd726c-0dd1-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 19:30:57 +0200 (CEST) Received: by mail-lj1-x235.google.com with SMTP id e11so20592895ljl.4 for ; Wed, 27 Jul 2022 10:30:57 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k6-20020a05651c10a600b0025dd5b3fabesm3889541ljn.102.2022.07.27.10.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 10:30:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfcd726c-0dd1-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=zjfjI1qOAot5uSZpRbjgv22gTCd0jDySVkMsyPMiU0k=; b=lYykyt7oEGtZAkPJXwWKoxcUUaBf9jN6Uc6qvIg8LUPv1K4adfqgJ05Qm4XQoiEUTh udcMS7bKzmgl7lFZ82APMhBrHzD4M2zzZ8af4idoaY60ozHuti/tZe5hAwjolFlWw8Tc 2+X1DYJiz6+ySBMGBEpJFAqZYjSHCtGGbqPCx0hBY+6qEb/2NUtnmwlIljCvRONczafd PQYs6xzBucZJ+tyBArfdySHxkHaqfO+1bUwm8UC94ogfjCzwQHMWf+lg7a3SjJ2HHYmw eHzeuXbBuAGBt/QSnCF7f8BFcrayjFhqUG97kkiyBVXX1FrdO4QXWENQ66H4U7aMaH/W 9UlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=zjfjI1qOAot5uSZpRbjgv22gTCd0jDySVkMsyPMiU0k=; b=zyk2/V3KzKamGwzR1PNZQBnrC7VDsJ0GR3l5NLp+EHL8DLgh+hDZOuba7nftMztgae PtGSt3OlIbaDXiopigqYrhqulBk0gwkRdis1Zg1eHkLz1uaJ0rJ3wNA9oDfR8akW9Rqu qW/gZtP9Nlz8C7DCPiZKjo7w6K0EuviQpD6DPne1Yf7MQOgC+ciLRy9t7HXCPPo7PJHa hVN0d/qpcRKaMqMUwVuKTy4DG540YClydRnKedy2eaW9w6BSUx1zZHc6IXTYhn9ygSPg DGpR68PenGUwkf+nhtUngxCPp68tsxnfd0mGvfY3rNjlugyncWIcrLhww+QgKdHhVDIL sG+w== X-Gm-Message-State: AJIora+lqLyHUrwYIOlIR5vwaTKV+BhjcYsGXm9BoCiC2aiwjMNDspNE RH3m+3OZIWPlSjCUFXtZbPI= X-Google-Smtp-Source: AGRyM1u7vpeIEM6smt9OW6QpOYV5TJhbyYdRQ6x+O9VPk9VsGynVqN77BRh9zs4ffzSo+Aty2rkXoQ== X-Received: by 2002:a05:651c:981:b0:253:b87e:ba6c with SMTP id b1-20020a05651c098100b00253b87eba6cmr8063323ljq.530.1658943056989; Wed, 27 Jul 2022 10:30:56 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 20:30:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 07/11] vpci/header: emulate PCI_COMMAND register for guests Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-8-olekstysh@gmail.com> <9f2bd47d-cd48-f544-4e8d-a8a698470889@suse.com> From: Oleksandr In-Reply-To: <9f2bd47d-cd48-f544-4e8d-a8a698470889@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.07.22 18:30, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> --- a/xen/drivers/vpci/header.c >> +++ b/xen/drivers/vpci/header.c >> @@ -443,11 +443,27 @@ static int modify_bars(const struct pci_dev *pdev, uint16_t cmd, bool rom_only) >> return 0; >> } >> >> +/* TODO: Add proper emulation for all bits of the command register. */ >> static void cf_check cmd_write( >> const struct pci_dev *pdev, unsigned int reg, uint32_t cmd, void *data) >> { >> uint16_t current_cmd = pci_conf_read16(pdev->sbdf, reg); >> >> + if ( !is_hardware_domain(pdev->domain) ) >> + { >> + struct vpci_header *header = data; >> + >> + header->guest_cmd = cmd; >> +#ifdef CONFIG_HAS_PCI_MSI >> + if ( pdev->vpci->msi->enabled || pdev->vpci->msix->enabled ) >> + /* >> + * Guest wants to enable INTx, but it can't be enabled >> + * if MSI/MSI-X enabled. >> + */ >> + cmd |= PCI_COMMAND_INTX_DISABLE; >> +#endif >> + } >> + >> /* >> * Let Dom0 play with all the bits directly except for the memory >> * decoding one. >> @@ -464,6 +480,19 @@ static void cf_check cmd_write( >> pci_conf_write16(pdev->sbdf, reg, cmd); >> } >> >> +static uint32_t cf_check cmd_read( >> + const struct pci_dev *pdev, unsigned int reg, void *data) >> +{ >> + if ( !is_hardware_domain(pdev->domain) ) >> + { >> + struct vpci_header *header = data; >> + >> + return header->guest_cmd; >> + } >> + >> + return pci_conf_read16(pdev->sbdf, reg); >> +} > This function wants the same leading comment as cmd_write(). ok > I also > think you better wouldn't give the guest the impression that r/o bits > can actually be written to (but getting this right may well fall > under the TODO). ok > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 17:54:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 17:54:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376407.609147 (Exim 4.92) (envelope-from ) id 1oGlEv-0003Dm-Sy; Wed, 27 Jul 2022 17:54:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376407.609147; Wed, 27 Jul 2022 17:54:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlEv-0003Df-Pp; Wed, 27 Jul 2022 17:54:33 +0000 Received: by outflank-mailman (input) for mailman id 376407; Wed, 27 Jul 2022 17:54:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlEu-0003DZ-2k for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 17:54:32 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2a1dc586-0dd5-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 19:54:30 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id p10so20670498lfd.9 for ; Wed, 27 Jul 2022 10:54:30 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id v19-20020a056512349300b0048a87545d8csm2131106lfr.27.2022.07.27.10.54.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 10:54:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2a1dc586-0dd5-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=X+hQaMwAGilNS0iZC2ZT3X/kn1lU1jZ3sAkL6hnlqTc=; b=q7BO7OfJMH8XO5TbKt39Y/aRqeksAFgMjykRh12WXVsKNoM2gMPAKOsh5PFJ13iKjF g8+UXgXwmV7iT2EhK66wXGrHXgaF0wy2ZgfpGPaadBfDUuNoLD1aHiqHyy/1NVYKO5xb 4KFl/sPWRNI3B4sMJ42yF8mjsBvcCV8nILS5EY5Egwc7CYLgtCLcRRWOIYD5eT4e2nYE FzhFLLcDOul7XEmlEOsbPhq4lhwLf/5GzXqWrnEICPvcHHB1Gxt7ZRhQL1WT1MQk+Uu3 Kc6B+sjXC7wdPCLE5RF6ZiZvcyd0xMiARfwCIaepn1dtfDJIvn91PBeb+brEgOUEZrfX sVRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=X+hQaMwAGilNS0iZC2ZT3X/kn1lU1jZ3sAkL6hnlqTc=; b=29jivkp8gUN97g49nk/yubGwh4FkDX1vnym+/LsgbRNNmWkdhClL9TqRADe5Zd9OTr +B8hOfdg3E4aKVAkw7mjevrWG+JGo4bV6HSHRtQ+6dIvenU5uB2CdKbsB+FMYfOg34cb a+5TVQhYE605y6yONO56w9Ozlh2Wc4KQxhOH1isSbuCAni/ADUtwGyIHBU6qfYbo4m/X Gxv18AyKWcyrizaU8FxUoVc4oMGRvY+9Kq7ngjo9pSYnzRtXVEO5cj+1f9PBdShhIfMd +cbweKydqq+44Ue5fnoLBb629ohA1K7WoJB9pP/VhnkYvQsp5691nuT+Cda7Yjuvio5m 4R5w== X-Gm-Message-State: AJIora8xu2hA7qlIwoaKoQVj2wZnaBs4mldy0MHYKLPADUWOtqauc7gQ qkiAypNa7JJX7SAANk2Rsqs= X-Google-Smtp-Source: AGRyM1tloiZkFjhDCP21u9n9erWRSDPNYCgCPJD6oQx/MgFpS9iYt0KfAoTPIyRkgFPJIzDPv8BiNQ== X-Received: by 2002:a05:6512:33cc:b0:48a:9f6a:8bfb with SMTP id d12-20020a05651233cc00b0048a9f6a8bfbmr3395900lfg.381.1658944470003; Wed, 27 Jul 2022 10:54:30 -0700 (PDT) Message-ID: Date: Wed, 27 Jul 2022 20:54:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> From: Oleksandr In-Reply-To: <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.07.22 18:16, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> --- a/xen/arch/arm/vpci.c >> +++ b/xen/arch/arm/vpci.c >> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info, >> /* data is needed to prevent a pointer cast on 32bit */ >> unsigned long data; >> >> + /* >> + * For the passed through devices we need to map their virtual SBDF >> + * to the physical PCI device being passed through. >> + */ >> + if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >> + { >> + *r = ~0ul; >> + return 1; >> + } > I'm probably simply lacking specific Arm-side knowledge, but it strikes > me as odd that the need for translation would be dependent upon "bridge". I am afraid I cannot answer immediately. I will analyze that question and provide an answer later on. > >> --- a/xen/drivers/vpci/vpci.c >> +++ b/xen/drivers/vpci/vpci.c >> @@ -158,6 +158,32 @@ static void vpci_remove_virtual_device(const struct pci_dev *pdev) >> } >> } >> >> +/* >> + * Find the physical device which is mapped to the virtual device >> + * and translate virtual SBDF to the physical one. >> + */ >> +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf) >> +{ >> + struct pci_dev *pdev; > const wherever possible please (i.e. likely also for the first function > parameter). ok, will do > >> --- a/xen/include/xen/vpci.h >> +++ b/xen/include/xen/vpci.h >> @@ -276,6 +276,7 @@ static inline bool __must_check vpci_process_pending(struct vcpu *v) >> /* Notify vPCI that device is assigned/de-assigned to/from guest. */ >> int vpci_assign_device(struct pci_dev *pdev); >> void vpci_deassign_device(struct pci_dev *pdev); >> +bool vpci_translate_virtual_device(struct domain *d, pci_sbdf_t *sbdf); >> #else >> static inline int vpci_assign_device(struct pci_dev *pdev) >> { >> @@ -285,6 +286,12 @@ static inline int vpci_assign_device(struct pci_dev *pdev) >> static inline void vpci_deassign_device(struct pci_dev *pdev) >> { >> }; >> + >> +static inline bool vpci_translate_virtual_device(struct domain *d, >> + pci_sbdf_t *sbdf) >> +{ >> + return false; >> +} > Please don't add stubs which aren't really needed (which, afaict, is the > case for this one). I assume, this is needed if HAS_VPCI is present, but HAS_VPCI_GUEST_SUPPORT is not. And the author added that stub specifically to drop a few "#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT" from Arm's code. Or I really missed something? > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 18:25:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 18:25:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376413.609157 (Exim 4.92) (envelope-from ) id 1oGlid-00074J-7r; Wed, 27 Jul 2022 18:25:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376413.609157; Wed, 27 Jul 2022 18:25:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlid-00074C-5B; Wed, 27 Jul 2022 18:25:15 +0000 Received: by outflank-mailman (input) for mailman id 376413; Wed, 27 Jul 2022 18:25:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlib-000746-Ed for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 18:25:13 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 71cd0ccb-0dd9-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 20:25:10 +0200 (CEST) Received: from mail-bn8nam12lp2171.outbound.protection.outlook.com (HELO NAM12-BN8-obe.outbound.protection.outlook.com) ([104.47.55.171]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 14:25:06 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by DS7PR03MB5446.namprd03.prod.outlook.com (2603:10b6:5:2c8::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Wed, 27 Jul 2022 18:25:04 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 18:25:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71cd0ccb-0dd9-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658946310; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=eQzNJuj920UfW/Be2q487o/iz2aiVXytfzwbZjlyfp0=; b=WKHA5/1mymzCdbXpis4Md7yabyApGsoqYsGaJp71btGNRWh7rOv+6uHc sc0v+pcjmfH79wuuCtlGdBIGycSmeiuoHa4KCHss9Owd6P+nhihaHGvvQ VjJGLk4VMTRjMHaaJcIDtT2M+AYjQE+A+fFPbY0MkQ9tlQ3Wc+DWPRw8O M=; X-IronPort-RemoteIP: 104.47.55.171 X-IronPort-MID: 79339942 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:Vg28T6KsFYyNE266FE+R/ZQlxSXFcZb7ZxGr2PjKsXjdYENSgj0Cm GcaUG3QMveMMGD3eIp2bITjpksFvsTWzoVmT1BlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vraP65xZVF/fngbqLmD+LZMTxGSwZhSSMw4TpugOd8iYNz6TSDK1rlV eja/ouOYzdJ5xYuajhOs/3Z90s11BjPkGhwUmIWNKgjUGD2zxH5PLpHTYmtIn3xRJVjH+LSb 44vG5ngows1Vz90Yj+Uuu6Tnn8iG9Y+DiDX4pZiYICwgwAqm8AH+v1T2Mzwy6tgo27hc9hZk L2hvHErIOsjFvWkdO81C3G0H8ziVEHvFXCuzXWX6KSuI0P6n3TE5+RXXWIPJL8k8OspQmNw9 uUfJi4LYUXW7w626OrTpuhEoO0GdZOuFqVP/3ZqwHfeEOosRo3FT+PS/9hE0Twsh8dIW/HDe 84ebjkpZxPFC/FNEg5PVNRiw6H12z+mLGQwRFG9/MLb50D6ygBr3aerG93SYtGQHu1en1qCp 3KA9GP8av0fHIPOkmHUoy727gPJtST1ZK0qKue8z+NjnlPImV1QF0EVV3Lu9JFVjWb7AbqzM Xc8+CAjsKwz/0yDVcTmUluzp3vslg4RXZ9cHvM37CmJy7HI+ECJC24cVDlDZdc68sgsSlQCy Vuhj97vQzt1v9W9VXOY3qeZq3W1Iyd9EIMZTSoNTA9A6d+zpog210jLVow6T/fzicDpEzbtx TzMtDI5m7gYkc8M0eO84EzDhDWv4JPOS2bZ+znqY45s1SshDKbNWmBiwQKzASpoRGpBcmS8g Q== IronPort-HdrOrdr: A9a23:KWYU9a7cfiFTD++LWwPXwZGCI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhI03Jmbi7Scq9qeu1z+843WBjB8bZYOCAghrmEGgC1/qu/9SEIUHDH4FmpM BdmsRFaeEYSGIK9foSgzPIXerIouP3lpxA7N22pxgCcegpUdAY0+4TMHf4LqQCfngjOXNPLu v42iMonVqdUEVSSv7+KmgOXuDFqdGOvonhewQ6Cxku7xTLpS+06ZbheiLonis2Yndq+/MP4G LFmwv26uGIqPeg0CLR0GfV8tB/hMbh8N1eH8aB4/JlaQkEyzzYJriJaYfy+Azdk9vfr2rCV+ O85SvICv4Drk85uFvF+CcFlTOQiArGoEWStGNwyUGT3fARAghKSvapzLgpDCcwoSAbza5B+b MO0GSDu5VNCxTc2Cz7+tjTThlv0lG5uHw4jIco/jRiuCQlGc1sRKEkjTVo+a07bWvHwZFiFP MrANDX5f5Qf1/fZ3fFvnN3yNjpWngoBB+JTkULp8TQilFt7TpE5lpdwNZakmYL9Zo7RZUB7+ PYMr5wnLULSsMNd6pyCOoIXMPyAG3QRhDHNn6UPD3cZeo6EmOIr4Sy7KQ+5emsdpBNxJwumI 7ZWFcdrmI2c1KGM7z44HSKyGG4fIyQZ0Wc9igF3ekJhlTVfsuZDQSTDFYzjsCnv/ITRsXGRv fbAuMiP8Pe X-IronPort-AV: E=Sophos;i="5.93,196,1654574400"; d="scan'208";a="79339942" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mhKFUMJdNqyzgQfaGRYDyJzJERdbeMEKTYDJbQ+MLJHm3zSREI2FmlnrMjry1V6cj940pzP9UTYhjFiQ6PTYcPexdOhFPKa61w1zpvGvDK898/rPBWf3lEoMEi8ykHfzlNjqaOxYlbzIaOiHUxSL5jxGk/4F8Wdd7ATXfhLiR6UEIIYdeZBEhH1X+DVsPyEM1rXodF9vlXLDu+HwR6SlNDBWUt7sh2ZrlAto7rpAybLFwf5CPQ0rdwIE70uSLSSJTPM4jroaWEgv4BDJQ++6uneiWsWEJWPjyMfL4IPUGIVQwRIuTuXuNB+PTMJOJw/CwVnLFbNyKB0cj9wA6w7a3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQzNJuj920UfW/Be2q487o/iz2aiVXytfzwbZjlyfp0=; b=fjzEGqoN8de9QMUA3dWJOaURu1jjB2/efvKtUIco7wgYIkr5nn290wRzXSsKP+sXcUfFJSryy/M9Bx+IGiIUrYSGQWDvddmIvsv3vQrByW75Kugl11DKDVCx87kkE6hxGEUKJ0AhqKyj9bwuPZgOHDN/mk+w4GGu+WgSxa0rB/+GhXPsgR4p3Xan0JQ8PL0OPS23OvdtjK1DNFXdkNlBjIuFA5js6TccZKHVBwkz7aaAY/0sjMZf7CKmJDcWA4pIiToIhpnRcAYpmls2xxk7eLrm0ubh3k527q7L5jQEasux3wIMhQIi+qOmjs4qEWSaCGhRF0dUWhuwVAD3uFqI6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQzNJuj920UfW/Be2q487o/iz2aiVXytfzwbZjlyfp0=; b=SvmTyWMeZB10CFTZR/txXslZms+jarT3HXdlFzz5BPxCpAmGTVpkVfHQG3Ao5R4y4Jp9MHZmCIO4UyJAeEdp+evqZpbjAyt47iAsFKndna7jPARwrbqPGCJy3YJ4uGdAIYV8K57kRwsz88ic1rzz2XWFDYqhd5yQgPPkMT4CFiY= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush Thread-Topic: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush Thread-Index: AQHYoQm4BqyiOS+zvEeDI26X0DRJza2SikyA Date: Wed, 27 Jul 2022 18:25:03 +0000 Message-ID: <764ae641-d445-f4ba-662a-c965ebcc582e@citrix.com> References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <40042c40-a2ba-e491-d16a-4bacbfc6154e@suse.com> In-Reply-To: <40042c40-a2ba-e491-d16a-4bacbfc6154e@suse.com> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ba3dafc1-84c9-4ee8-e175-08da6ffd5320 x-ms-traffictypediagnostic: DS7PR03MB5446:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w9td1j1GuAQrp/Z3PXSJZyH9y1SU1Zn13gYdaix+MLk6ykC3Vepc0yHwAlZR921+JSvdgNyy9bznkeLApQFtAiPorY08Ub8bhO/NKhzThsLg8VflQw/qYDJRwzHOduzfMPAKJHE5MOHHXD4tWr+p1ZrJlliqRCFu4ip+r7QaWqdqw3LmtXV1VMnm/pIAAvth48ppaHwiT7wEFg0TD8HI7UBByITjFWSHoxob8T45Tr0JEs6k+DpxnnlYQ1UTcDKt+MwWOg6JFknQDbb3y4nkmqNaxrqHpJpr88PuxZSuhx2AQYcTRFbNQhmmHsSl1h/MRTk22x2/EQsJ9+F2EupLnlK0Y0RaYhHmXUi1JEk9XuGDCR81NACe/WnZ0amRzGFWQWbJ/jS0nYoJz86qRSh7ruKMjkL8+G+3DDh4v8WQedkWF46niSRisTccxpTa4aex8Vsj8fF2eWLOuzxuLE57K02om3HDvjKV6eVKoW6Jz4L1wvU5heYSW75kKmCk70Dt6Y7meaohUCX0q6p8b4y54NZ+GYZWQXkVdaS86l94nlchJpJrc1rpz7nTa051roHgFKHWivC30ddkhs2/qCO0oh51tOt0kcoRu6cUKOa/7jKfTvLsvy91zF0p5vLj00LOPS9QAURXTeK2YtWoPaxb4RMkgTyBf68lllRd2umUIYJixMH6kDElKWtYNXxBSHjYqwueDcVyUSKN6PWDK4JnEPAcX/OBfcGK+c1x7lghp/Io3z087oBYj0V74a3ldv6wXdJEmFssvLoIJC4sC797t/QRUL06HN7PxM6gnCu3MdsZdA090qQfcqgns+RIA0ewwJ3lP2+taC87R/8hyE3HVKU0Ag06kW89vehz0OFT1DU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(346002)(376002)(396003)(136003)(186003)(53546011)(110136005)(6506007)(41300700001)(316002)(6486002)(2906002)(71200400001)(66446008)(82960400001)(4744005)(478600001)(66946007)(91956017)(8676002)(54906003)(66476007)(64756008)(4326008)(36756003)(2616005)(66556008)(31686004)(86362001)(26005)(8936002)(76116006)(6512007)(5660300002)(38100700002)(122000001)(31696002)(38070700005)(45980500001)(43740500002);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?N0hSVnFQSUpQdzE1UTFxWXZ1Z1hLVlVWK1NjLzVobk0vcWcyQ3o3SHkvTStv?= =?utf-8?B?djVSYTdPWVgzLzFEakwwZUNPL1VyMmJJdC9ENnAva3MzSmRGaUc3aUdGQ3V6?= =?utf-8?B?Z2pXaEhBQTBQODZjZW9yb1JaUGdNN1NtOVFkTUI1ZDlnOENaSzY5cW1DaVFr?= =?utf-8?B?TmRCRmdGVkVvZStVOTl4S0p5Q2lZV0ZIREltTTAwMHo4RU16SjNkdk1GdHd2?= =?utf-8?B?UjdudU45Qjc3UlFDM1k3YlFWY0dRSndybHJCc0lPTVBweVNxMEo1VFdhcnZo?= =?utf-8?B?U2Qyd3VyTFpTQjNWdFRldnlJakhFdXp0R0w2R2tHMS8yN2xvbXVhZEVKQXMr?= =?utf-8?B?VFN6dEw2OU4yUkdmeXJNOU9wc3ZmRnVCeXQ3enhRenI4ZUlSMVVPTEd5blhT?= =?utf-8?B?bEhubWxNYmVjdUw2dW9UVHBkeTIwWFQ3UEtGVjg5SU9kWjJrK1N3YlBVNXdo?= =?utf-8?B?aS92bW14Mk9IMmRWNFE2RnlLZjVBZ3Fidkp5QmZhMHhvb3p4cHRGNjlkNSt1?= =?utf-8?B?R0hHeVNPa0ZNZGluRmMxVnZMWWtnanVIM3FkMHBhalhYYzY1V001Y1NuS3ht?= =?utf-8?B?L3FCZ0pYNGIrcGxISXJyWlI1MEQrZzNHY3JFekx5aU51eWR5UVRNZkVrMnhF?= =?utf-8?B?QXlTa0VvVWNpZXgrUS9yZDBBTStjTnE3cXdxbzQ2M2V5UG1MWHB6SjFUZWNT?= =?utf-8?B?YXI2R0FVa0JVTTkyVExkbGhVd2hLRXFuWlFYQTh4TkJMblVmR2xiellOUmdV?= =?utf-8?B?N0tDQXJxU2tuQlNybWZHNzF5ajlzc3ZCYWFIaDNEaVpqUklzTi9FU1BwVWFx?= =?utf-8?B?am1nZ01TdU11aUR5ZXVpY3M1ZnNDbFVtem1LYXJGVTk2ZnpYU3ZJeEpQd1lL?= =?utf-8?B?UnFCQmxENEZzV0ZxZ0lGdTFXalhlY3VOL0RHLzZXYS9aTWMrYTVqM1E2UWIy?= =?utf-8?B?YVlKZExROVJ3eUlwTjhZeUlmTW9wM0xFU2trTzQwWEpCMzRvVG0yb3NBYjEy?= =?utf-8?B?aS9xZkw1YUpHWmUxbVJ1Ump4ejJjOTdIYllxK3Z1MkJYdGorQXQ0RU9BSkwy?= =?utf-8?B?TTZoR3RyOXhKM0hmdEVzRjFhcGh2MEdaTlJjbWNNZXNHbUI0cEN4T1RKSmpJ?= =?utf-8?B?Vkw5dlVZVjVxSVgwdTVOQW5NVDc0TTg5ckxSL1ZQcnJJbTljNDN4bDNpWnYy?= =?utf-8?B?dHRLZXA2YXdUKyt0b3R5QzVaUUVOdXluZDBPc2NLZmV1UE0wSEY3RE9XYThx?= =?utf-8?B?ZFNQdDNObXNMbTl6d214MDZHUTZUeWgraVBQVDVuTE9VdUhtRWVFc05vVzBa?= =?utf-8?B?T29kaElGbWsyUWdKNTU1dzd0QmM5OXFhVWVGekZ6RlUxZElKWWNmZUYvYjJE?= =?utf-8?B?YWx4UW9jeGQyQXl6SVFiTXpKN01rRnJqRjBLMWVDRGY5ZE9GQ1JZN294emU2?= =?utf-8?B?eDUyS0pzZjRZcE5leDkxaU8xM1BaQ2hPbys0NTBmUEFZZ1VQM3dkbitibG5N?= =?utf-8?B?eDFhMGVDVmdsYzR5TlBTSjAyNlhtSHFBNVVmbnU5VHpqeEc3Skcwak41RExL?= =?utf-8?B?Q3pDWlFrQzA4M2pQclJCVlpzMWFzWUZvNy96QVRsajBLck5SbFh6dmU4dUJw?= =?utf-8?B?SFhtbGtZNmpNM2EwdEFjc3NlOW02MXUxSUhHYUdpYXVqZjJjSjNOTW1WaTB3?= =?utf-8?B?S3BRUzZHUUNibW81Z2k5aVNNRy9OQzNrUTNYazIxdE53MjZWWWI4Z2JLWWFy?= =?utf-8?B?b1kwZzg3L3UxeklOQ0FTSDRDaGZ0aTNlS09Mc3pNUHhVcENKbk9sWm5CLytD?= =?utf-8?B?eUttOEhtTjFIUFVDSFV2cjVXVW1vM2NQVWx6aC9SZkxmbjlPY08wc2hDWXIz?= =?utf-8?B?OU52RWp6QjJ1eHFwZnJoSmVxcko4bXB4a3pQV3FLVlFxZXoyTkk5UzRjMnRH?= =?utf-8?B?bDR2S2tYcGUzdXJ2MjNlNmhCN3BORXZYeU9WYXMrS1k4VDZ1aDZKdXdkaFVa?= =?utf-8?B?eStyZGt6KzI3ek9vV1p1VVJiN3ExZG5jdjRQcmhZaDYrYys3UWlNM0JJMVBX?= =?utf-8?B?R0RybEVPTUZkbmYyK0hRZXQ1YkkvUkQ5U3BteXQ1RDVuN0g5V3M1M3laclkv?= =?utf-8?Q?n3SI/XojFWDKqvTvYWpYJzKUb?= Content-Type: text/plain; charset="utf-8" Content-ID: <6384283B9EE58A4F8BFE68CF26F1D958@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba3dafc1-84c9-4ee8-e175-08da6ffd5320 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 18:25:03.7794 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: XMu572EB4R09HHmVlk/vel1TGUONkfJpDwCRtAN1/xSWJZpN9iF8C24lpAi/CMX73eEOS1JJZ7w45rKCayYzk5cT0m4Ug4J2gVMD0jyL37U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR03MB5446 T24gMjYvMDcvMjAyMiAxNzowNiwgSmFuIEJldWxpY2ggd3JvdGU6DQo+IFdoaWxlICJ0eXBlIiBj YW4gaW5jbHVkZSBQR1RfcGFlX3hlbl9sMiwgIngiIGNhbid0LCBhcyB0aGUgYml0IGlzDQo+IGNs ZWFyZWQgdXBvbiBkZS12YWxpZGF0aW9uIChzZWUgYWxzbyB0aGUgcmVzcGVjdGl2ZSBhc3NlcnRp b24gZWFybGllciBpbg0KPiB0aGUgZnVuY3Rpb24pLg0KDQpXaGlsZSB0aGlzIHN0YXRlbWVudCBp cyB0cnVlLCBpdCBkb2Vzbid0IHJlYWxseSBleHBsYWluIHdoeSB0aGlzIGlzDQpyZWxldmFudCAo b3Igbm90KSB0byBUTEIgZmx1c2hpbmcuDQoNCkFzIGZhciBhcyB0aGUgY2hhbmdlIGdvZXMsIGl0 J3Mgc2FmZSBvbiA2NGJpdCBidWlsZHMgb2YgWGVuIChJIHRoaW5rKSwNCmJ1dCB3b3VsZCBub3Qg YmUgb24gMzJiaXQgYnVpbGRzIHdoZW4gdGhpcyBsb2dpYyB3YXMgZmlyc3Qgd3JpdHRlbi4NCg0K fkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jul 27 18:32:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 18:32:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376419.609169 (Exim 4.92) (envelope-from ) id 1oGlpC-0000FD-Ut; Wed, 27 Jul 2022 18:32:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376419.609169; Wed, 27 Jul 2022 18:32:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlpC-0000F6-Ri; Wed, 27 Jul 2022 18:32:02 +0000 Received: by outflank-mailman (input) for mailman id 376419; Wed, 27 Jul 2022 18:32:02 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlpC-0000F0-3y for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 18:32:02 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 65f239e2-0dda-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 20:32:00 +0200 (CEST) Received: from mail-mw2nam12lp2042.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.42]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 14:31:57 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by CH2PR03MB5160.namprd03.prod.outlook.com (2603:10b6:610:a3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 18:31:55 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 18:31:54 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 65f239e2-0dda-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658946720; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=s8GfIK9qtpk5yq4g8U3sd9KpWmv+v9lj+ReXvn3Xrek=; b=eP9janOOC6SMtUxijSBEMsVWwYIz/iW66V+V5HnRHA+EkFuSQfDJXEAC tYSO43W7UCmW8akrEAzrExe0Ielej86c24JN35GGLTjK1pPk7yXl/t0BF wStcYk0GZN+ETcCGYI5xj3gfAWiL+nKa7/z+z6SzHCIL6OzbQWqycSYeD A=; X-IronPort-RemoteIP: 104.47.66.42 X-IronPort-MID: 76771307 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AiX/t4aoO4EOqQ63HxSvpXVsvf55eBgzWbkWyX?= =?us-ascii?q?Er9NTMEsledRL0lAxOEDZn2NF/8yPai0Z0tYoZLMTjUnqJTxd6LuMDNqeDwX?= =?us-ascii?q?FawGq36OsfuZIp0/bnD4W8TnMk4sk7A7xb10xoAraXfW+c89vpWIJDbwefvj?= =?us-ascii?q?D/It5HOzDGdJQiS7WILDQ1gwh3o8wXLMEtNR32uRuBm9tdzgv5FUJ0mN5noH?= =?us-ascii?q?K6w9TjVZijWiiJhBIKKiK+83VXpomWH9ZKm+yCYGw4Yn33naJdcwhUW64WYS?= =?us-ascii?q?aOHPjo2lSwJ6RqIp5foJSkHOjtw4idDe1NZgipzW3eFzGk3Nr8J3IRx+QXzy?= =?us-ascii?q?RZGl6jKhGNkhjXrNysvxhFF6lOKngQ0n/F9Epx0iX584wuhCzjKMv0N9kKdS?= =?us-ascii?q?jSF7graJmMNoAQ73zhJwTynsIRdof8c2hvZy4nfV3Y+kWvNym8r0BOxC+zMP?= =?us-ascii?q?pWYMIjglCCIG5SR0BbDBPJvafM/qn1wVjuJtQDT6vZZ8JXViBHyZ9WUkzb61?= =?us-ascii?q?KUH27dVXtbT5gF095GXaiABG7Io0AOjl3ZPKXuAlIRogqT8nkjUpNRdlja2f?= =?us-ascii?q?+LTtwxeTTd7JCJqF+Eu+a9t0UE+S/8L68TRDL5rHlBoOwYA0qaO253aFvGdN?= =?us-ascii?q?3nLATwICk4m7ZBdgK33gp160ATC4kwkzc9g3QymPwvcc9ROi6sGXwo6Zlkse?= =?us-ascii?q?txrt8iIrAqDyGiMtIkAjaS0EkStX5GOdMey4pJ2d47lzvScRLJW5DKE2YVvM?= =?us-ascii?q?cT7TqOgmo3hjFNFErxr6Bnzvp0fs09je2NMnm0WdeWZcyjF1HTOx/g2H8Ba0?= =?us-ascii?q?xbYqw4B4Z5C2AO2G7wrhQOwidHfmc2Vh5ZtPozz85SXc19ugN7M5i7HYQBSc?= =?us-ascii?q?mygdQhTYl/BbNEMPYfUM33b45DzMBmegSBZlhE7NftyHTX7X1lShsTiKInLk?= =?us-ascii?q?TH+lU8rUDVjsRMXPYLzSHTs3F3xZVIm0YN3EDISD5N5vjsLO5ZYwtdHxCshI?= =?us-ascii?q?uTDwXPYG7vwMz0UzKm6QxJ5coBFyAN5V2ZyjX0nEqkowHCgq7qM01rmbjuGY?= =?us-ascii?q?drq8G9xtZooadCKFzLRrNQb9guaEAe0HKDnlA90M9Zmg3n3nEcrDOl4TO6gt?= =?us-ascii?q?LJQAa5/fCWBNJN4Dclzcx9gsierFUXbsgEjtGC3VaeUXOQ76JCL2cD0ysseO?= =?us-ascii?q?hbh+s/k/cpLSukjNY6bEXqxdiKQLxyEFKYq+KaGhNhZ+swqfW0CCD1cRGejO?= =?us-ascii?q?ubm2LTZ+omfKFI532BquGrIQHnbb0ANZz7iUBRg6ARZKaNUefmTRHruMRQdZ?= =?us-ascii?q?YC/cQ4mY9hDIJjrMVy2zZsIbFjpW59iAuBK66Knq+YRC1VbeYM0W824Srrs3?= =?us-ascii?q?XkTyGqcp7m0G91h+pTOpNI5FHVGwIet/NHjdhdQapqplsVut0K5NsY3491S2?= =?us-ascii?q?Gmy7Uyzx+qW9Z+XXwp6RWLjt+vhkJ8iOK5+vydT4CNkNR7NisW17Sz7UeG72?= =?us-ascii?q?bI+44/FnSJjuJqC4nIypQrStGfhZ/gCvta2LjnMCXSsfYC9VHKE9SE5OXmgD?= =?us-ascii?q?rR8L84aNo8oL6RRXjg1m0H0yYRKFSgiLworOb3NOUC4+cG+SbhwbtMUd+Hrx?= =?us-ascii?q?FSl1gEbqZCXmn2SFSXRaDVWx5aJcDtWfEVKjvqqKzDEYy00ZKiHsORZGco+J?= =?us-ascii?q?TLa2O7Z+rC5K1tN40oiGLEcuAKyjahvSZ1kYmffOFfJadUIQ2ETowp/ik2SN?= =?us-ascii?q?c8W5MFNErYWaoU9cJJlD5VOcBXjSiebjhhQG1I+5OAiApS8Rnp6plA9ZNz8Q?= =?us-ascii?q?/CMmUb+XYFzCaZVcnZN5fL6j9cKHCX0aMhn31ozC/n+cNEVvrbghGuy1ly+M?= =?us-ascii?q?+htPhDhi9BPa+UoM1qa7mk178JnWrm1vXlcL2YyjgJ3M0cG0aZ1uJbywzZ4n?= =?us-ascii?q?7ubnYemHXc5x8hmFtSAfEfNHbzMnhv9qXxfQAsN8zLcwoYUgXWdmLRkDmMWE?= =?us-ascii?q?dUY75v0HJ2oADkePZXeo+f5mTXak6tsNww5DFjB/1JUzJlZMWdPro7M3v79B?= =?us-ascii?q?UbuZS1tARNylvnEf6uiaMMtTHNXJybrBlYAru9wMnYR+XQtcJP7GugNQ2moU?= =?us-ascii?q?DGVZIHpT75p8w9cPdTrHcjnd1OYaAAK7HdaUmRRPZZGoJyPdAuctQ92nR7C+?= =?us-ascii?q?e7s0ZEVptUH3kYRw+q20eR8HcIL1mamMW5/i25c9DSdq9UtI1RitihY4I6WJ?= =?us-ascii?q?jIwYxIBy0fhIWqDABgq1raB4Y6RHAjNTOT1ADX89QlONLfj6ld8+VFtPImLC?= =?us-ascii?q?Qzd0pVPWfq5sys+ZDz1STyOTMZHSa5uvAZlSkD4nRKjRFAw8x30zZPL/WRTS?= =?us-ascii?q?ZjBZ+4+pZ0A1J4V3ZdnVD7pecgTYrmFKC2BMXOnF8eThWPrOsSx5piVFeXDt?= =?us-ascii?q?Auvz1GOZDmn36JdAUxbcDPKKg3u4Ueut0F13TrZp2msBpkRoioDdQRoAInq3?= =?us-ascii?q?1ZwgyBgc991GsmmxOeIbukvp8dSRVRB?= X-IronPort-AV: E=Sophos;i="5.93,196,1654574400"; d="scan'208";a="76771307" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eJGj6Ms6Bns/ybFUDDccY9tqz0HctoG9xD3bibqJc+Yjlpi1C2wF7CYpOMcX41puokeiM9npa8nz7uEue+byjZOj4z0Nlk0n739ERv6DzB1v2ySWVhsnVUsUN/EdaPu7iColh3HIduBOxYu+yNLIhrznU/9PDAogo+sXSuKXJF+NngS/XLqteuXhZ7zkZR+48WjcFC3TxMkrbgJzf8xBcmBhhOQnHgTaCzedCFkOgul4RtX/qx7T+NPrMfcMoxkYiTXvVcWS2pYtVPPUUOe++UjrjhopBgx+zAuoIUadBXO8xhf/jq+uiFp7mDzNCHBzuQgpoWK53p/zefknKSFqJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s8GfIK9qtpk5yq4g8U3sd9KpWmv+v9lj+ReXvn3Xrek=; b=PuL7T+vqkSOLBvpGDb8uvA4bEO88bYxaLXgxmX8dvHrP9Mqccg/M5WqmkFQvS6KOK41iPlC+fRk2XVevv70gwkKlFoaGvjikr1W0HAsQc3/witWLYmv4oZq2kIzV+ssT0o1c5GFCDprI/g8C4RS9E0wb9vv3nAucE/sHJHvYHbnDby7Lb23YsoznGHExkbbRJ+uj2aRMDLiZCxdt5JPHhJXwYIEueeeml67NE02BuUKCGS98Zzx/feRn4fATovWrpDkIsG06GKXdeb/kTrVNOdOBKan9i7HhiY7Ub5GwKTBkizuMBwWKfSi6XS5+zyZGiHsqEPu8/HF7FYNDIUfYiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s8GfIK9qtpk5yq4g8U3sd9KpWmv+v9lj+ReXvn3Xrek=; b=D7RtQs5aD2qGIt4RiL7BCka5ytefsBF8UoGDJk1Qm/bn6xKZFDuK7HHXPI03gWZ3V9hBiBmmTeO3blFNuc7Z0MuxVlhyw+oUNaCXm96dJ+HDqp/AZGOtYdWkgWK5zjI7KZmRDItP3euFNxJbAujo39SS71svt6jQ5VlQEPheBeg= From: Andrew Cooper To: Jan Beulich , "xen-devel@lists.xenproject.org" CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" Subject: Re: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush Thread-Topic: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush Thread-Index: AQHYoQnO8OzlkeZzjkmlyR5O1pgYna2SjDYA Date: Wed, 27 Jul 2022 18:31:54 +0000 Message-ID: References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1dd8c3f2-2011-442a-ea14-08da6ffe480e x-ms-traffictypediagnostic: CH2PR03MB5160:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NXTdMVG+y7AWEwORWrw5kJzDPs5MZP3TMpKIu3uYXpMZEzttYJcUcdvnMbLzqcmXCYUUCizD4ZXojK0s5taPhjs8IB6LRNu5NYIXxGyA5OHwY/uNnnZWXSIlb5gjlZa/kSFd8dF9Q6FYpg1WcF3ut95JDfrJM5vboOJE+X8CdAyk1Os4qvYvqzexmAileqjxAWpYWVWwI8afC/STwSTIm/Qo/hsSF1XqQTlDJkGxRwWjQ0oA6AIoZkt6jImyUeXeVSDH1EASlNrTtszXxmVbROqzfZyvOLHx7dUqqZKNFI9vxGKHXlyoLUJSHU9C3KBO5yfLrKr8miBuaQdSkgfy734ovm9CLJkBejMxxLcsL2S5DCYiaOYL4Zii+ZhR7BM/OZ6KNqLMV/sesedUoCi3toI194dUwyveDht0z4PK0TD4fX8sVTBBjGOrTczh2MymThwxVDeouxykRHsNoeYxSwY8XLj33ahwdaQnBti9T18Ud9CwGQD2e7IQEcNhdHkjLAMF8cDF/Ib8Qwm8iJnkTF24H/X0aAZUclELT0UUZeKODVfvYKLsIY6WSGTaoL2rbd0N/zpVJDfjWmUmQx0bzrR9V6F6fCT27DmU7wJaCVIDVqq+/uM67hmjUzRzDF9QmtngQ9yZejGmjoOY7shi8wC0JZ3yI6ma6Z/ycPEmtfKnT7jiPt6CHheg9PjxBrpPkgqYUgKRsQh8utz3Hie3xUIa0qvBaeOkZm3UNlLlndayZIHAbwONMHrXM7DJcsKpX3d+TeLOwhn/XlbCIG3Lcg8HeiYahGbOeYPXXue1HALi+SBVHBzEyENK+kZSU8T8/8O6WzANi05bPZQzPqeooN8zTgwppqMVuWnEXpt8RYWRkYTf8YtorS3WcqnIHgeT x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(366004)(346002)(39860400002)(136003)(6506007)(8936002)(41300700001)(53546011)(5660300002)(2906002)(71200400001)(6486002)(4326008)(478600001)(31696002)(86362001)(2616005)(186003)(558084003)(6512007)(26005)(38100700002)(122000001)(8676002)(110136005)(54906003)(316002)(38070700005)(82960400001)(31686004)(36756003)(91956017)(66556008)(64756008)(66446008)(66476007)(66946007)(76116006)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aWpmQkc0UFcvY1ptZG4vd0x6bWxSUnRBaWQ0dDFYdjZtbTJZR0xybUVZVUxh?= =?utf-8?B?aXJ1dGlSZC9JcTZMaDhKNTFheVJ3Y3RvNFpXVTI4dEcxb0VzSU5uMm1DTHN1?= =?utf-8?B?R2dJSzJiM0kxQU9YZ3pjZVVHZjdmM243WUZXbk90TzFYMEdXL3ZFeHA5dEJW?= =?utf-8?B?ZHVaTmlNenUyZ0w0NklDcGwvNHpOQjRDVzNwMjlYVXdoMW1PZmM5VnBlaDF2?= =?utf-8?B?NmN5K0JSU1g2WlNkUzFjb0hCQVZEUTh0RlNJdXI5QmFNTEt1UHFEcUVXRE92?= =?utf-8?B?bXpZOU9zM2p2RFd5QUtFMkNaVHJ6WTRxZHY3N2FuVkoyNzVhdjlwRTlRYUll?= =?utf-8?B?UFJTY1hMNXBWeE5tL3FSU0pwVlhHK05hbCtXT3ZVdFQrSkE4Y3B0c0Vhcmoz?= =?utf-8?B?RWR2YVdGZWYyaE9aTi95N2x0Nm1YTnh2MDJqdkpMVTgwRW1uRyswMjhvZ2Zj?= =?utf-8?B?VVc2UVAyT2dPMTFuZ2NqY0xkd0xEb1h5NlV4U1JWQTFwZ01ranRmdlhtdXRx?= =?utf-8?B?TXZpMWtBMU9DZytOOHp4K3A5TkpVQ3Q1WitwczhqcXlzclFrZ0FJWC9oeDN0?= =?utf-8?B?QzA1Y2wrRkxibS93Q3NxckREd2FYTnpOVGdlaXpNNzkyUlZDbENNRVh6bVpj?= =?utf-8?B?UjgvVS9ucFV6azlDSU9SZW01Nk9oM1NSU2VoWituQkRTaDFvMWhobmRvR051?= =?utf-8?B?eVJGZEJkRFo1QlpZRUJDL3JKMmM4MEpzNTJ5M09SVk5Yc0FzbXNadSs4aFVr?= =?utf-8?B?bnJCTWU3NWZaVVlwY3BJUTFKTzFGNGtQS1JVeW1CUEtyTHp3b3RTU01BYnJQ?= =?utf-8?B?UTFsVlRoK2t0endMWmpUb3ZyM3JHWnhLODhKNDdSWnd1R0QvMk5rYS8zNUt1?= =?utf-8?B?S2NFVXV0SGJuQnhsUGYxTXBEUmxOSmQ2UERtMThTQ1lIZDdGbElsd1Z6QzVv?= =?utf-8?B?M3lYOHQ5L3hZaXNhWjEwQk1hMjdiMzA2L2QvVGNKc0puMTd4SXhudCt3WFNO?= =?utf-8?B?bG9mMFg4bWJpcG93aWxLWkJYNVVYV3BVbjY1a0ZDTURnQ3NuNkY3KzBYNTZP?= =?utf-8?B?enI0TkdRTWZHT0pTMDJFWm9xamJXcUN4Q3BLZVJOUE9URWxaZzB5ckZ3Wm5Z?= =?utf-8?B?YzlZSTdZMFJmdGFlbDVaTWVMeUQ1YVhOM1NPcGdPVzhmenZtaHdzMTRDZjNr?= =?utf-8?B?elRmeXNEd093alhabXpEWG9RRFRrSkRMcWV3eUgwNlVUeHVlbk5KeHNhczh5?= =?utf-8?B?cGRhYUI1emhyL3p5b3AzcFhod0R1Tm5YcFY2YXEyMEw0Vll4dnVSc0JFTU45?= =?utf-8?B?T1ltM1QzVVplNTZIRCtEWjE2bE1panY2ME1xVTlhVkt4YlRwV3ZpS1hEM0xV?= =?utf-8?B?cHVWbWxxQlNla3FKYXBEM1NWNjYrZ1FEcVdKSm0yR0JCWUtjZlphVXRLYXFh?= =?utf-8?B?eVVZVkhzTCtNMWVXcUFCeEROWUZMYzh4L2tnTzgyam1BVUEyeW9QazBpQ0Uw?= =?utf-8?B?V2pCWUJSdzBYMW1HalFmQ2wwSTBaN2NMOWdNM3dEQ0JCMFZpYk5jWWdtczRx?= =?utf-8?B?Nk9LZFF1aVk4WHM4R1ZhWjBhTFdubFdFS1Vndmxva1M5REhvSTd1S2FhYW1J?= =?utf-8?B?RjVwNVJWMlFzV2JOZm1sRVVjdnRuQXVhN1BLSENJSVFHMmtIM1RYZG9XeWFH?= =?utf-8?B?TWV3cU84QTBmN1JWejNiaTYvWUFqdFhVTWl1aml4VTcwTjZ0UTBaZlIvNVBr?= =?utf-8?B?TTg1Z0pRZEZvV1g3bXlZNEFrc0gvOGRaL2lXcGhjV3VTTVlrbGdxRlRvZTR3?= =?utf-8?B?MXI2N1E0NTMwZjhxUnJUNW1nVCs0U2RYRjl1Z0ROWG8yclZSUkE4NnNNOVE1?= =?utf-8?B?UU8xN0VSYkVRb3IyRjBJWms1eUs1TGZQeU9wMlA4emdhR2Yyb1NOYXBUeEpw?= =?utf-8?B?VUZJS2xiNGVrTFRRZ2tvUUZFQlVsdjUzd0RZbzk4MGIwZ0Vsd0d1eXJBeDJ4?= =?utf-8?B?dWM4ampMSnlRYzE2NVFIeU5wcFVVeU9aNmNja2dNZXE4NlNmeExiR1Rhak9M?= =?utf-8?B?azZScDdWUTZTcGx5MlQwalRnY2hpZDlMOTZUVVhLU3lvU2xzUGgvMHdiNTZE?= =?utf-8?Q?v5fI+Lq4iEgKj+IKmLJhBkerx?= Content-Type: text/plain; charset="utf-8" Content-ID: <9EDE999BAF2E6D44AF1959A533B9337A@namprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1dd8c3f2-2011-442a-ea14-08da6ffe480e X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 18:31:54.7191 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hcKAxu8JlaE8/tmRS7UXcOp0X1zDCHucPK995L0hsm74zXZO8iRmkwYj7qYnkm5StNMVMRAKSjh/mT3UgLx0iH5vCmOreOmxLLtgU5kv94g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR03MB5160 T24gMjYvMDcvMjAyMiAxNzowNywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IENoZWNrcyBkZXBlbmRl bnQgb24gb25seSBkIGFuZCB4IGNhbiBiZSBwdWxsZWQgb3V0LCB0aHVzIGFsbG93aW5nIHRvDQo+ IHNraXAgdGhlIGZsdXNoIG1hc2sgY2FsY3VsYXRpb24uDQo+DQo+IFNpZ25lZC1vZmYtYnk6IEph biBCZXVsaWNoIDxqYmV1bGljaEBzdXNlLmNvbT4NCg0KRG8gSSBnZXQgYSBTdWdnZXN0ZWQtYnkg c2VlaW5nIGFzIHRoaXMgd2FzIG9uIHRoZSB2ZXJ5IGxvbmcgbGlzdCBvZg0KaW1wcm92ZW1lbnRz ID8NCg0KRWl0aGVyIHdheSwgUmV2aWV3ZWQtYnk6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29w ZXIzQGNpdHJpeC5jb20+DQo= From xen-devel-bounces@lists.xenproject.org Wed Jul 27 18:34:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 18:34:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376423.609180 (Exim 4.92) (envelope-from ) id 1oGlrA-0000sq-DV; Wed, 27 Jul 2022 18:34:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376423.609180; Wed, 27 Jul 2022 18:34:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlrA-0000sj-AP; Wed, 27 Jul 2022 18:34:04 +0000 Received: by outflank-mailman (input) for mailman id 376423; Wed, 27 Jul 2022 18:34:03 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlr9-0000sb-Cb for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 18:34:03 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGlr6-0004Q9-C5; Wed, 27 Jul 2022 18:34:00 +0000 Received: from [54.239.6.186] (helo=[192.168.6.7]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGlr6-0006Wx-5k; Wed, 27 Jul 2022 18:34:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bv4MA8qCouhTy0sn7RM1g97aMwrZIgBG2t39tdfZ2TY=; b=Gq3LsgEHmLmEAzLLm/wxKPzaeK RkjiykUIqTUNGEVmeYy4lf/Qt5q2AWuRmame6opr5fUAbdN2mT8aMvl9LjqCyKQgpxNOZgotqBAgz VQ0L5xhxWK0jSEYCJq2GUzqnm8hEZwtILGKxCK6ma/VHelITCRRtisSkfBtiW8M/Dx3I=; Message-ID: Date: Wed, 27 Jul 2022 19:33:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v7] evtchn: convert domain event lock to an r/w one Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian , Daniel Smith References: From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 27/07/2022 16:56, Jan Beulich wrote: > Especially for the use in evtchn_move_pirqs() (called when moving a vCPU > across pCPU-s) and the ones in EOI handling in PCI pass-through code, > serializing perhaps an entire domain isn't helpful when no state (which > isn't e.g. further protected by the per-channel lock) changes. > > Unfortunately this implies dropping of lock profiling for this lock, > until r/w locks may get enabled for such functionality. > > While ->notify_vcpu_id is now meant to be consistently updated with the > per-channel lock held, an extension applies to ECS_PIRQ: The field is > also guaranteed to not change with the per-domain event lock held for > writing. Therefore the link_pirq_port() call from evtchn_bind_pirq() > could in principle be moved out of the per-channel locked regions, but > this further code churn didn't seem worth it. > > Signed-off-by: Jan Beulich Reviewed-by: Julien Grall Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Wed Jul 27 19:07:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 19:07:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376432.609191 (Exim 4.92) (envelope-from ) id 1oGmMp-0004y4-U0; Wed, 27 Jul 2022 19:06:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376432.609191; Wed, 27 Jul 2022 19:06:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGmMp-0004xx-Qp; Wed, 27 Jul 2022 19:06:47 +0000 Received: by outflank-mailman (input) for mailman id 376432; Wed, 27 Jul 2022 19:06:46 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGmMo-0004xr-8G for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 19:06:46 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3f3e476c-0ddf-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 21:06:42 +0200 (CEST) Received: from mail-mw2nam12lp2040.outbound.protection.outlook.com (HELO NAM12-MW2-obe.outbound.protection.outlook.com) ([104.47.66.40]) by ob1.hc3370-68.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 27 Jul 2022 15:06:33 -0400 Received: from BYAPR03MB3623.namprd03.prod.outlook.com (2603:10b6:a02:aa::12) by BLAPR03MB5474.namprd03.prod.outlook.com (2603:10b6:208:285::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Wed, 27 Jul 2022 19:06:31 +0000 Received: from BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c]) by BYAPR03MB3623.namprd03.prod.outlook.com ([fe80::bd46:feab:b3:4a5c%4]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 19:06:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3f3e476c-0ddf-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1658948802; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=w3X0sSNPYg3fWQo3nObExbbQryl3IJ699yK/+vB1REU=; b=M7vF1etD6IYo/gVm73DquBV0FFYimubDU3lIgT15ps1dqrdvGylMDUuL kPC+GTaGGgFPibG5Rfrh83kvqCOWXRgbWmto0Isde8yyaiJvtBv7SFogo 64Bw2axMMw+31IAa3WhIAefNK0dNC61RpLzoF7kVlS2tYvdpGrZi2CXnY o=; X-IronPort-RemoteIP: 104.47.66.40 X-IronPort-MID: 76568630 X-IronPort-Reputation: None X-IronPort-Listener: OutboundMail X-IronPort-SenderGroup: RELAY_O365 X-IronPort-MailFlowPolicy: $RELAYED IronPort-Data: A9a23:ddYj16haUXtqFdIVUvWAUd0tX161TREKZh0ujC45NGQN5FlHY01je htvW2+FaKqIYGSmLYogbo62p0JU6JLRnIRrSVBtri9mH3sb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15Kuo52tC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eDdUdocBZPXl1q +URciwtKR+oit+S+efuIgVsrpxLwMjDGqo64ysl6A6DSPEsTNbEXrnA4sJe0HEonMdSEP3CZ s0fLz1ycBDHZB4JMVASYH48tL7w2j+jLHsG9hTJ/cLb4ECKpOB1+JHrPMDYZZqhQsJNk1zDj mnH4374ElcRM9n3JT+trSzx2L+RxnuTtIQ6P7S12OYzkRqpxUsvFzdHWWaV5vXghRvrMz5YA wlOksY0loAw/kG2Stj2XzWjvWWJ+BUbXrJ4DOkS+AyLjK3O7G6xGmkBZi5MbpohrsBebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ2kUjJR9M6Sqqt1IWpQXf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj IronPort-HdrOrdr: A9a23:9wxUwaylCzH91j+4Q8G/KrPxdegkLtp133Aq2lEZdPULSKGlfp GV9sjziyWetN9IYgBapTiBUJPwIk81bfZOkMUs1MSZLXPbUQyTXc5fBOrZsnDd8kjFmtK1up 0QFJSWZOeQMbE+t7eD3ODaKadv/DDkytHPuQ629R4EIm9XguNbnn5E422gYy9LrXx9dP4E/e 2nl696TlSbGUg/X4CePD0oTuLDr9rEmNbNehgdHSMq7wGIkHeB9KP6OwLw5GZfbxp/hZMZtU TVmQ3w4auu99uhzAXH6mPV55NK3PP819p4AtCWgMR9EESutu/oXvUiZ1SxhkFwnAid0idsrD AKmWZnAy1H0QKVQohym2q15+Cv6kd315ao8y7kvZKqm72EeNt9MbsBuWsRSGqm16Jr1usMr5 5jziaXsYFaAgjHmzm479/UVwtynk7xunY6l/UP5kYvGbf2x4Uh37D30XklZqvoJhiKobwPAa 1rFoXR9fxWeVSVYzTQuXRu2sWlWjA2Eg2dSkYPt8SJ23wO9UoJhXcw1YgahDMN5Zg9Q55L66 DNNblpjqhHSosTYbhmDOkMTMOrAijGQA7KMmiVPVP7fZt3cE7lutry+vE49euqcJsHwN87n4 nASkpRsSood0fnGaS1rep2G9D2MRGAtBjWu7FjDsJCy8zBrZLQQF6+YUFrlde8qPMCBcCeU+ qvOfttcoreEVc= X-IronPort-AV: E=Sophos;i="5.93,196,1654574400"; d="scan'208";a="76568630" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EJQ11MICVY0qhdeIYDJtZVNjBUewDVcap5kTcVj8hUmx/CCXXdvmvt5vB58l8n6E5GuOF9VvAMn3IODWaeYh8jxyoVON9L20Omtw/fD7feohPT2H+ijOInqL6puYK+9g1vmOw1abw+2MTBoihZptBYwqrmmZwgmAZWM0r/eTSHgUxRmpBLz7xvA/Hqu3/BVQ4ilmPj2bOvjyPGxyx4a5gEV7htMzZU0aTdDitv1+FvjHOggRkVKjBkXN5YxwrBOUJnxZlXPIgvEoSL59fAfu8exSBE5YJwp+ESmIn87JU6BTN4t3je5JYq8FamjJuZJZoJYABVFNplrqDne2ZzuyFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=w3X0sSNPYg3fWQo3nObExbbQryl3IJ699yK/+vB1REU=; b=f27/Dgkw2O/Y0T5jrtX6/sZsc5owWfxXc/X4FoVkaWESrJ1jCX1mzRUdp0etiGhziPxyTKzGxh6Yfg0d3bVlS4nQEuYtoFuHOKHgI6oBcufpcwJRRzdNDBxXcEMBia996TaAKZ6eOBEB43tGZ/iMeATe1GUV2s2u4+Crg+0jA76nLYPAR7iTsmZQK0w2ys4Zrd1rWge4zG8ctjOmzzxrnVT5n+pHNOKNfoPPBwUU3MNmui7VuG4Kh/1VYtf+BFkeeoieobUH1GkGTx2AMxP+VWZjYwYu2eD85nomps8Des+/MjcdASoxmmZBLQEpM1AWsWWd9QIk4LFq35HIac5iDA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w3X0sSNPYg3fWQo3nObExbbQryl3IJ699yK/+vB1REU=; b=f/+MyPKFZ0sbwgH3cIhBiKd8ofWoX/kG2IEX6jDHdTkViiYJHx74assnZrnr0Db1SwvVeN1jakUr/g1twF/S2V4hiv+62VP2pFshnKd3Bf0Vg25L4Ryd3xUk6j6pamE0BewoSNvH1Pt+gcQFCEFOLVlAV3mCBgLDtS2VvXV4Hb4= From: Andrew Cooper To: Jan Beulich CC: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing Thread-Topic: [PATCH 2/8] x86/shadow: properly handle get_page() failing Thread-Index: AQHYoQlhV37xX0Hh2kWLBKJVPAkGN62SK82AgAABxgCAAGhPAA== Date: Wed, 27 Jul 2022 19:06:31 +0000 Message-ID: References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <6c5b5339-f645-4214-bc53-2b7ead004367@citrix.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2b379c93-ec79-4af3-5919-08da70031dbe x-ms-traffictypediagnostic: BLAPR03MB5474:EE_ x-ld-processed: 335836de-42ef-43a2-b145-348c2ee9ca5b,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7CoYjKz5VwRhnPTbMGDFgtv73ZkPGbG5WJg3+GMpskIy4zeKuLSmgSR/wS8sYEufLOEoe3YzfBZz1tB4Kt1hdW7bmkVKQFcnmpPXX83MxnqgKPiXn00KBr6uU6R5u3jnNKpg1F8WIpxb3KF3FyGqb4w56iZSC/72uQuR5CUg7d22pCBqmGD5KE6I44UyTcuPEFWFUEgmmWSW25PecS5JxPNtIvVbkf3c9f0sK5s1RwWnL1mscd/UEuBRT0rc/dgLgNTPtdGJpeSP+m0qN88rOpL5+raiQLTo0SeXuVLACy+K/feeis9t+kcI8R/eY4fM2D1+/90lHjsX11VgWqA5JnswzWZp15fwM+kx8s7mkZf/gPFVWpelvHUF0Ouw2n2NMv4iLIPX11B+kTAEliVeQS396kiGkVMVC55OVO3hQw7eoWJb/d87QeIGhPqGJvkNZYLGOwQ1cC5Je59s0CLUlb1evfWuLlYNgzFUj7OwsxeqI0jAMWBvT7URkcqAQW9hmvBksqPOtmixRRUbL11pdy/NzpPvq5Hj+HI5JPbtjTkL9ojH9t5b54J4rNnQvOIE75bR9irQ/wOkfjU68SLDLTbYnxgwTTGWavup0/oz/7GZmwIC2QbUogQtZrsJ3sHO4BViAcE0oLeP2JeUvaYS8UlJ6w1JjHfp3UZDfLbF5Rdc8wG947vpcIT+faoPme9UCXgjoZ1JmwW7PNg0vUeQ5YP+/rSUEjEfX9FcWARi/VJaCqLS2tqmOgqnSDlsR95txsnprn5C12cfzU/Ar42WC1f2OlPEWaS1xN47XL3HtlhLp+anvYcvQKpLuse/9Pz/00wMEajNpmLUPlekalJ2IUZw4A/a6IVaatU5kdxQWDh48f9A5jXdonvUOA9ice0n x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR03MB3623.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(346002)(366004)(376002)(396003)(39860400002)(38070700005)(83380400001)(2616005)(38100700002)(186003)(66946007)(54906003)(76116006)(66446008)(31686004)(71200400001)(64756008)(4326008)(6916009)(66476007)(91956017)(36756003)(316002)(8676002)(66556008)(6486002)(6506007)(26005)(41300700001)(478600001)(31696002)(6512007)(86362001)(53546011)(5660300002)(2906002)(8936002)(82960400001)(122000001)(43740500002)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WXBUWUtxYmY2QWxnVmVWclNRd3QxRTNNNTZxZTFUamFyallGbVNhYklFNW9E?= =?utf-8?B?bU44UWdQaWNDNDhMYzRKdFpjeW5yRmxMam9oOHZuY2VlVG1rRjdpVXlJanQy?= =?utf-8?B?VVJVbDY2MXFPNUlOOVRSRWx0NDFXYTIzQ0drTHR1Y1duN2FybkljdFZWazVt?= =?utf-8?B?ODVCTEFZTWJVTUliZm1Cb2VhSlo5Nlc2bzJFTFJHK0RXZ2NjSW8wVkNQRnJX?= =?utf-8?B?dytMYjNoekNoR1FOZ09sdzhsVXFPczFFdDNyUEI2ZVpvdytmak1mdXIxaStn?= =?utf-8?B?Z2U4ZG5nRnpHYUFobUQ2SUJqQjhQcC83a1RoRXdRbWF4eUlzSDhURGdJbnJh?= =?utf-8?B?N1FDRStRTDd4clZhKzFnWmxUOWFNa0UweGp4dGdSY0lad21YNGViMDQwOEhL?= =?utf-8?B?SE0vcG5QYmdkaVl0dXhpNXZBaGtza1pIeHlyUEkxWEswdXdXK1o4b2MyVnp1?= =?utf-8?B?TzF0MjR2b29lOU5PTWFNRThvc0VQeExDaTYvaUhsSm9CSnBxYmkvdFVabGJO?= =?utf-8?B?WUpMekUwdkUzeDcxV29UQitPWGZyTVVtV2w2QUJPQmJaakNicHRXdTJNY2kw?= =?utf-8?B?b3V2Rll1ZGp2OFVrbDNzM3NCQ3V6TEFiSTVoRGwwbGVNWHdZSlJRMVFPNnRy?= =?utf-8?B?TXlFanh4VFdySjNPMko2cTcrOWhLdm9pTTF6RUlqRXI4VGhDUUxNQVMwWHpm?= =?utf-8?B?bVVNejczakpqeDFyU1ZtVGYzS0lZOWE5Y3dVRzl4RGJPVW5ISXdaMjdtUnV0?= =?utf-8?B?NFVMa0VOVDlXT25ITUlIN2poLy9RYXRUZDYrMVJmeGh6MnQ2c1I3b01tdEM5?= =?utf-8?B?eGgwS0d2cWc2SFFIa0VUb0EvN25idkN6T2NhT2lkRWZBaVlhYk1MNWVSKzRo?= =?utf-8?B?SVM1SkwxKzQrQjZRZXlnVzJYWHNpVlJ6SWIwNGsxWXErN3FycEZyQ2cyTWRJ?= =?utf-8?B?UmgyeUpFYjNWYkNFZmFQMHJZdW9LNHg1cjhraWxyL2M4RGZjQVdNV0hEajl4?= =?utf-8?B?c3dEN1dzTFVmeXl2K0ZHKzNyd1lEbmREWmhMdldBck1MVE03SUZZeGVLdzBI?= =?utf-8?B?VmZYY3p6RGxFVmd1WEdubWZKYnFGbmNka0lIWkIvd2taQlZWYWhUelFiUzZx?= =?utf-8?B?STRHWHJVSjBlKzMrUkhOOUhGQnB4ZC9DdC9EcnNJbmdoMW9vRi9pTVJXYUFi?= =?utf-8?B?dVF3VUhHbkU5VTBLWlY3aVlOYlpYYnRGeHZnOEdEeGVDaUJBbk5zRVN2L3VT?= =?utf-8?B?SUlFVFdweVBiOVFNYjUzNjA4RGhHMGd0RERPSkluL0JJeFN3WXBDQkNYY2lk?= =?utf-8?B?N3pjZVhQb3k4c2JmWFZjS3RkdHNlMXBqTnNnaXhiMERKVFp1SllBU0kwcnJB?= =?utf-8?B?RXUrUVpGMU1hQXJnWml6dlNkMUtsVTgxV2I3WU9qZ0hJbW9yWndpUFNoYjVa?= =?utf-8?B?K0xHU2R2eXByS0ZPbkNXeEZsYjkxWTBMdkhhTDNLR205SExuTmRLZEVBTWFW?= =?utf-8?B?OEtadlljdWR6YW9NdCs1ZURSNE9HUW1DeVVHV3NENVR2Q2NMWEJhcG9YWGpD?= =?utf-8?B?VEdGbTlxR2xKN09sa1NhMEhISkJmTUNXdmdPdnN6bUthRDRMTmVsM0ZjWno3?= =?utf-8?B?RlJGS0JHU29qdXJRR0lWZEJtTGJoVURYN2ExK2Jwdy8yM1h6MTM4eE05Y1U4?= =?utf-8?B?bm5McjlldWhDQWJzSjhscnpnTTk5Sy96QVpESzZyODhFK2pPQmErYmMyZ0Fi?= =?utf-8?B?ZzZBZ0E1TW1aZWNNVkdSK3ZEeW04a1Z5NTBFRkl5NjJZV3dodFovaVd6OS9v?= =?utf-8?B?cHE0ZVFYWStJc1haeXZSQ2h3bUN0QnAvdDV4ZEdCaHNQWThmZmVINE1XNlFC?= =?utf-8?B?Q3BEbi85U3cwSm9ROE0zeEVwNmVTdUJKVG9zNWpPVjVURlVnVVZSanFET2w3?= =?utf-8?B?YnY1WlMyV3lUQTZTNXMvdmI1NTI4SEQ5Qm93Y2svcjdLQ0I0VitDYlprWHd3?= =?utf-8?B?Lzk3eXVIMFdDSVBkTmtPTjhUTlJTeHpGaExEcm1MSnN4TzltaUxtUDY0d1FQ?= =?utf-8?B?dHVjUHFRc3ZxSkRuMmdaQXZReHpFT3NUV0dzbTlzSGpLYldpNnhEdnJteEtn?= =?utf-8?B?dWRSa0dQQmgvc25GdjMrUENxSmNnOGthWVRsUTIzSzNHNTN2TCtyYVcrcm9r?= =?utf-8?B?QVE9PQ==?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: citrix.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR03MB3623.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b379c93-ec79-4af3-5919-08da70031dbe X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 19:06:31.1948 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eSUoVdsSHZ0QqgJ+hdUTByPKY4xufKTJwkqiuwq6jCIn/VEedJ3D7oiEnbCflYjgd0XocrXxLpa/D9EXk2LQfrEEdy5pEhdU+ycHve9OVwc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR03MB5474 T24gMjcvMDcvMjAyMiAxMzo1MywgSmFuIEJldWxpY2ggd3JvdGU6DQo+IE9uIDI3LjA3LjIwMjIg MTQ6NDYsIEFuZHJldyBDb29wZXIgd3JvdGU6DQo+PiBPbiAyNi8wNy8yMDIyIDE3OjA0LCBKYW4g QmV1bGljaCB3cm90ZToNCj4+PiAtLS0gYS94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMN Cj4+PiArKysgYi94ZW4vYXJjaC94ODYvbW0vc2hhZG93L211bHRpLmMNCj4+PiBAQCAtMTMyLDcg KzEzMiw4IEBAIGRlbGV0ZV9mbDFfc2hhZG93X3N0YXR1cyhzdHJ1Y3QgZG9tYWluICoNCj4+PiAg ICAgIFNIQURPV19QUklOVEsoImdmbj0lIlNIX1BSSV9nZm4iLCB0eXBlPSUwOHgsIHNtZm49JSJQ UklfbWZuIlxuIiwNCj4+PiAgICAgICAgICAgICAgICAgICAgIGdmbl94KGdmbiksIFNIX3R5cGVf ZmwxX3NoYWRvdywgbWZuX3goc21mbikpOw0KPj4+ICAgICAgQVNTRVJUKG1mbl90b19wYWdlKHNt Zm4pLT51LnNoLmhlYWQpOw0KPj4+IC0gICAgc2hhZG93X2hhc2hfZGVsZXRlKGQsIGdmbl94KGdm biksIFNIX3R5cGVfZmwxX3NoYWRvdywgc21mbik7DQo+Pj4gKyAgICBpZiAoICFzaGFkb3dfaGFz aF9kZWxldGUoZCwgZ2ZuX3goZ2ZuKSwgU0hfdHlwZV9mbDFfc2hhZG93LCBzbWZuKSApDQo+Pj4g KyAgICAgICAgQVNTRVJUX1VOUkVBQ0hBQkxFKCk7DQo+PiBJJ2QgcmVjb21tZW5kIGNyYXNoaW5n IHRoZSBkb21haW4gaGVyZSB0b28uwqAgSSBrbm93IHRoZSB3ZSd2ZSBhbHJlYWR5DQo+PiBnb3Qg dGhlIHJldHVybiB2YWx1ZSB3ZSB3YW50LCBidXQgdGhpcyByZXByZXNlbnRzIGNvcnJ1cHRpb24g aW4gdGhlDQo+PiBzaGFkb3cgcGFnZXRhYmxlIG1ldGFkYXRhLCBhbmQgSSBoaWdobHkgZG91YnQg aXQgaXMgc2FmZSB0byBsZXQgdGhlDQo+PiBndWVzdCBjb250aW51ZSB0byBleGVjdXRlIGluIHN1 Y2ggY2lyY3Vtc3RhbmNlcy4NCj4gSSdtIGhhcHB5IHRvIGFkZCBvciBjb252ZXJ0LCBidXQgcGxl YXNlIGNsYXJpZnk6IERZTSBpbiBhZGRpdGlvbiB0bw0KPiB0aGUgYXNzZXJ0aW9uIG9yIGluIHBs YWNlIG9mIGl0Pw0KDQpFcm0gcGFzcy4NCg0KV2Ugc3RpbGwgZG9uJ3QgaGF2ZSBhIHNlbnNpYmxl IGNvbnN0cnVjdCBmb3IgQVNTRVJUX09SX0RPTUFJTl9DUkFTSCgpLA0Kb3IgYSB3ZWxsLXRob3Vn aHQtdGhyb3VnaCBwaWVjZSBvZiBndWlkYW5jZS4NCg0KUHJvYmFibHkga2VlcCB0aGUgQVNTRVJU KCkgP8KgIEFsbW9zdCBhbGwgc3RhdGUgY2hlY2tpbmcgaW4gdGhlIHNoYWRvdw0KY29kZSBpcyB2 aWEgYXNzZXJ0cy4NCg0KDQpNb3N0bHkgd2hhdCBJJ20gY29uY2VybmVkIGJ5IGlzIGl0IGZlZWxp bmcgd2VpcmQgdG8gaGF2ZSBvbmUgcGF0aCB3aGljaA0Kb25seSBkb21haW4gY3Jhc2hlcywgYW5k IG9uZSBwYXRoIHdoaWNoIG9ubHkgYXNzZXJ0cy4NCg0KfkFuZHJldw0K From xen-devel-bounces@lists.xenproject.org Wed Jul 27 19:39:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 19:39:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376438.609201 (Exim 4.92) (envelope-from ) id 1oGms8-0000Ko-E9; Wed, 27 Jul 2022 19:39:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376438.609201; Wed, 27 Jul 2022 19:39:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGms8-0000Kh-BX; Wed, 27 Jul 2022 19:39:08 +0000 Received: by outflank-mailman (input) for mailman id 376438; Wed, 27 Jul 2022 19:39:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGms6-0000Kb-CM for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 19:39:06 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c61f1831-0de3-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 21:39:05 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id t22so22136479lfg.1 for ; Wed, 27 Jul 2022 12:39:05 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id q23-20020a05651232b700b0047f6b4a53cdsm3924130lfe.172.2022.07.27.12.39.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 12:39:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c61f1831-0de3-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=fJ2Ae/vdufhtrjHgsvvHcimV/8iioJZZmT29p5C1vVc=; b=mJ65Syy8nn9oZNPstgGmJKpAnhe2vKJYIOsNXOVBY9S10NEHg6VL7Gp1WJG9TsJ0+N /0Y79fw9tpCUHdmRpaZVCH+Vlq2Ch2obcnBVq+fvArfQkcuqU+N6MuB4nHN6hdmu6U63 hsXCIoZR2xQAh++kSMB89Rg34IZvcyNXi8RXk3VletvnxhwX3jeCTI/lBGrfsbR46CD5 Y7GrVWwv18he2IPlEPAyQ6zz0TchS199io0xzPSUScfwOZZN+NZiwlhybFsZEwpcCVGz /PGX6KqePyc1w2b7Gp3M5VPYLIs/jz9fDzV4ZYwB2ulrW8zbFaAv6p5wWPgMv8VpVr1q duMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=fJ2Ae/vdufhtrjHgsvvHcimV/8iioJZZmT29p5C1vVc=; b=DcNYnfwD+ltJos6Z7yVdIFdHp6T15HVUUxbcvp749V5Q8EIIcjgDgxzPJ9eBV7wNO0 GVKZC7ILPMLgnfxI416KveuTpd/Aym0HWwX9pQpih9KffGa4ejJaJN0R6gymIlw4IiJc +dJpmxxb5MbBeCwnzhedZ4Jt1U9qQNPqXvqfOECy2BG6rvwp00hR4H4Vjd5uoUiP09xK bgIIzrGl8BiemAcGRnhsi4DuPq9BQqP8oN2iw1b7T9T7kevsVgzd8vXN7dz2dMtiD5h3 hcKYVXYCROLxxB+6e9vHrsfpJCW5EdyJv7nb79GTkb5Twf3u7dV8kLIGvW+jpSkN2JqF VQ4Q== X-Gm-Message-State: AJIora+HdVapZbieC+sy36Uhd2v6aYeQUTCs5tsVSc1qeTCMxY0GWf4+ bIaHNBSqprEC0Q3V54fUOYc= X-Google-Smtp-Source: AGRyM1tHQiiqgIMJcDdTnRDgyrfUmGGEi2GEotBvvBvsEtloM94SjEIz0j4ffeK/3QZQogwsMQoZoA== X-Received: by 2002:ac2:5498:0:b0:48a:86f1:86a5 with SMTP id t24-20020ac25498000000b0048a86f186a5mr7130338lfk.158.1658950744571; Wed, 27 Jul 2022 12:39:04 -0700 (PDT) Message-ID: <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> Date: Wed, 27 Jul 2022 22:39:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US From: Oleksandr To: Jan Beulich Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello Jan On 27.07.22 20:54, Oleksandr wrote: > > On 26.07.22 18:16, Jan Beulich wrote: > > Hello Jan > >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> --- a/xen/arch/arm/vpci.c >>> +++ b/xen/arch/arm/vpci.c >>> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, >>> mmio_info_t *info, >>>       /* data is needed to prevent a pointer cast on 32bit */ >>>       unsigned long data; >>>   +    /* >>> +     * For the passed through devices we need to map their virtual >>> SBDF >>> +     * to the physical PCI device being passed through. >>> +     */ >>> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >>> +    { >>> +        *r = ~0ul; >>> +        return 1; >>> +    } >> I'm probably simply lacking specific Arm-side knowledge, but it strikes >> me as odd that the need for translation would be dependent upon >> "bridge". > > > I am afraid I cannot answer immediately. > > I will analyze that question and provide an answer later on. Well, most likely that "valid" bridge pointer here is just used as an indicator of hwdom currently, so no need to perform virt->phys translation for sbdf. You can see that domain_vpci_init() passes a valid value for hwdom and NULL for other domains when setting up vpci_mmio* callbacks. Alternatively, I guess we could use "!is_hardware_domain(v->domain)" instead of "!bridge" in the first part of that check. Shall I? -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:02:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:02:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376446.609213 (Exim 4.92) (envelope-from ) id 1oGnEA-0003wd-7z; Wed, 27 Jul 2022 20:01:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376446.609213; Wed, 27 Jul 2022 20:01:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnEA-0003wW-4v; Wed, 27 Jul 2022 20:01:54 +0000 Received: by outflank-mailman (input) for mailman id 376446; Wed, 27 Jul 2022 20:01:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnE8-0003wQ-7S for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 20:01:52 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f41c0db6-0de6-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 22:01:51 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0CF40B82279; Wed, 27 Jul 2022 20:01:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C0BDC433C1; Wed, 27 Jul 2022 20:01:46 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f41c0db6-0de6-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658952108; bh=dJZDq9TeojWaAeb5Tu3v7rbFJ9sd5XQ035WL4Vgv74k=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=pesfyF1ImnQgavp/Y3wz3b63NaZ6uaErRuYJLdfS8p28Tl0lfRZ5YwNQ6CXtCMvbc znyjyH6FUmrjJmmq9m4BSPrZy4Cv7I2P9DoUcLvK5WDVG8McUNRCs8GLFZFeUV5C6z 4Q1vGoCsdnLi+7huizv20KgOZGJcNDT1AS4+MLzHNePskqGaNV1hSt4R9GAtMxuN9o xeCyxPrDHoXiKMfmUJzs+yYScgx23PAcs25cAX7jJEw/yiGf0rhC9kOPPs9mtgX+HO Gf1jxW16Fd4ECKczURRLJh0rht3FguwHGNMrGHf685Yu5odUek7uG5kjqhCLJ/mZf7 pxLokSumxnB2w== Date: Wed, 27 Jul 2022 13:01:45 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jason Shuhua Lei cc: "Smith, Jackson" , Stefano Stabellini , Xen-devel Subject: RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 27 Jul 2022, Jason Shuhua Lei wrote: > Hello, > > -----Original Message----- > > From: Smith, Jackson > > > > > -----Original Message----- > > > From: Stefano Stabellini > > > > > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > > > Hi Stefano, > > > > > > > > My colleague Jason Lei and I would like to submit a patch to imagebuilder. > > > > > > > > It seems that generating a .fit with a true dom0less configuration > > > > fails > > > because an extraneous comma is included in the its file. > > > > > > > > We believe this change resolves the issue. > > > > > > Hi Jackson, thanks for your contribution! > > > > > > Yes, I see the problem: the code assumes there is a dom0 kernel. If > > > there is no > > > dom0 kernel then load_files will be wrongly starting with a "," > > > > > > I would be happy to commit your patch. I assume I can add your > > > Signed-off-by to it, right? > > > > Yes, that is fine. Could you also add Jason, as he worked this out initially? > > I've added him to the message so he can give his ok. > > > Yes, I would like to be signed off on the patch as well using this email. Done, thanks! From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:09:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:09:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376452.609224 (Exim 4.92) (envelope-from ) id 1oGnLO-0004mE-0D; Wed, 27 Jul 2022 20:09:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376452.609224; Wed, 27 Jul 2022 20:09:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnLN-0004m7-Tp; Wed, 27 Jul 2022 20:09:21 +0000 Received: by outflank-mailman (input) for mailman id 376452; Wed, 27 Jul 2022 20:09:20 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnLM-0004m1-Jr for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 20:09:20 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fee93fc6-0de7-11ed-924f-1f966e50362f; Wed, 27 Jul 2022 22:09:19 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F33BA61ABC; Wed, 27 Jul 2022 20:09:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A92DFC433D6; Wed, 27 Jul 2022 20:09:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fee93fc6-0de7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658952557; bh=+ziZoc0NaaHvSKuewK1m2bfgZ3HyLK9FPgHIebUFAZk=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Op9zKx5e8VhHEHYUT0RrxT006ZDrDc+8EY9qPleaiYPN5wCKNLB0Tf+OphapU06Pu 9HVnBrCQTWjXAn5PAiR4GgCXZzxaZBVnA73kmquJkTymAiMdAky6Wj6R17AYjMxkWC SBxAzf0jRESCjAgrWctHm/fl1mNUjMEvntzHI7BkGOtPCSzptaBO2xQs7Ff4E8E0NS qZYbsaT6cFXft4PpvtiTWkjIMKLDhyaB5VCz9/cCMCnLhLcfbrMLW2MCwOdPDDWZhI Fl4E2leMLZuFurgOxq/3IX4xJ+jzZVsujX8c0MvmBJmhTt/05EqpZMjFwjA8ANtcZg 9p3NJCefNBibg== Date: Wed, 27 Jul 2022 13:09:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: Re: [ImageBuilder][PATCH v3 2/3] uboot-script-gen: Enable appending extra commands to boot script In-Reply-To: <20220713163044.3541661-3-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> <20220713163044.3541661-3-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 13 Jul 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > Added the parsing for APPEND_EXTRA_CMDS variable, which enables the > user to specify the path to a text file that contains, on each line, > u-boot commands that will be added to the generated script as > "fixups", before the boot command. > > The file specified by the APPEND_EXTRA_CMDS variable parameter will be > copied as-is in the generated script. > > Signed-off-by: Andrei Cherechesu Reviewed-by: Stefano Stabellini > --- > README.md | 5 +++++ > scripts/uboot-script-gen | 11 +++++++++++ > 2 files changed, 16 insertions(+) > > diff --git a/README.md b/README.md > index cb15ca5..3566a6d 100644 > --- a/README.md > +++ b/README.md > @@ -64,6 +64,7 @@ BOOT_AUX_FILE[1]="uboot.cfg" > > UBOOT_SOURCE="boot.source" > UBOOT_SCRIPT="boot.scr" > +APPEND_EXTRA_CMDS="extra.txt" > FDTEDIT="imagebuilder.dtb" > FIT="boot.fit" > FIT_ENC_KEY_DIR="dir/key" > @@ -197,6 +198,10 @@ Where: > as you can pass -o FILENAME to uboot-script-gen as a command line > parameter > > +- APPEND_EXTRA_CMDS: is optional and specifies the path to a text file > + containing extra u-boot commands to be added to the boot script before > + the boot command. Useful for running custom fixup commands. > + > - FDTEDIT is an optional and is off by default. Specifies the output > modified dtb, used for reference and fdt_std. > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index f8d2fb0..f72551a 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -416,6 +416,10 @@ function check_file_type() > elif [ "$type" = "Device Tree Blob" ] > then > type="Device Tree Blob\|data" > + > + elif [ "$type" = "text" ] > + then > + type="ASCII text" > fi > > file -L $filename | grep "$type" &> /dev/null > @@ -1238,6 +1242,13 @@ device_tree_editing $device_tree_addr > # disable device tree reloation > echo "setenv fdt_high 0xffffffffffffffff" >> $UBOOT_SOURCE > > +# append extra u-boot commands (fixups) to script before boot command > +if test "$APPEND_EXTRA_CMDS" > +then > + check_file_type "$APPEND_EXTRA_CMDS" "text" > + cat $APPEND_EXTRA_CMDS >> $UBOOT_SOURCE > +fi > + > if test "$dynamic_loading_opt" > then > echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:13:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:13:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376459.609234 (Exim 4.92) (envelope-from ) id 1oGnPc-0006FY-Ma; Wed, 27 Jul 2022 20:13:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376459.609234; Wed, 27 Jul 2022 20:13:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnPc-0006FR-Jz; Wed, 27 Jul 2022 20:13:44 +0000 Received: by outflank-mailman (input) for mailman id 376459; Wed, 27 Jul 2022 20:13:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGnPa-0006F5-Rf for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 20:13:42 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 9b900ff0-0de8-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 22:13:41 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A58AB8225E; Wed, 27 Jul 2022 20:13:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7226CC433D6; Wed, 27 Jul 2022 20:13:38 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9b900ff0-0de8-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658952819; bh=YH5zMYlyZYs8//oUEqbK8GQc0YiP9Sp80pteJSo3czs=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Odz671DV0RJ4bvpaecTa4BrCBFtCfVmtNrV5NY4jg1c3/l8cCRvWhmZySInyzpl/Y cWj05Lbr27Kzfy4kfEw7TIDgYmYYtetTkaBYLZSv2YivLmsYWJcC9MTE93Dlhqf9bL Q2IeI9HggslH4FqvAU34M45nEi+mge+twezF3cqxaw4Zld9s4zcQc/ytCONsOHTrJE V0QLx1Rxax4ywvzhNZfqLQJHkjFM1rRkMxMIa4aoGHNIso+hM+eDIIa9JgVKoEoI9X OGrP3AgZwUTue2kwN3xusYfY76SiSbwAQeg0qDgDNkrxc7D1jQVtI/wlGF0hgiOmUf xbLaVC7VjAIFQ== Date: Wed, 27 Jul 2022 13:13:36 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu Subject: Re: [ImageBuilder][PATCH v3 3/3] uboot-script-gen: Enable not adding boot command to script In-Reply-To: <20220713163044.3541661-4-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> <20220713163044.3541661-4-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 13 Jul 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > If the "BOOT_CMD" variable is set to "none" inside the config > file, the boot command (i.e. "booti") will not by added to the > generated script, to allow the user to customize the u-boot env > or the device-tree after executing the script commands and before > actually booting. > > Added commands to store the addresses where the Xen image and > device-tree file are loaded, in 'host_kernel_addr' and 'host_fdt_addr' > variables, if BOOTCMD = "none". > > The `booti` command can then be executed as part of the 'bootcmd' variable > in u-boot, which should contain: > 1. fetching the generated u-boot script > 2. executing the script > 3. running `booti ${host_kernel_addr} - ${host_fdt_addr}` command > > Signed-off-by: Andrei Cherechesu Reviewed-by: Stefano Stabellini Given that this patch is non-controversial, I committed it before patch #1. The small part affecting the "$dynamic_loading_opt" case will need rebasing. > --- > README.md | 5 ++++- > scripts/uboot-script-gen | 16 +++++++++++++--- > 2 files changed, 17 insertions(+), 4 deletions(-) > > diff --git a/README.md b/README.md > index 3566a6d..07ad432 100644 > --- a/README.md > +++ b/README.md > @@ -81,7 +81,10 @@ Where: > > - BOOT_CMD specifies the u-boot command used to boot the binaries. > By default, it is 'booti'. The acceptable values are 'booti', 'bootm' > - and 'bootefi'. > + and 'bootefi' and 'none'. If the value is 'none', the BOOT_CMD is not > + added to the boot script, and the addresses for the Xen binary and the > + DTB are stored in 'host_kernel_addr' and 'host_fdt_addr' u-boot > + env variables respectively, to be used manually when booting. > > - DEVICE_TREE specifies the DTB file to load. > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > index f72551a..6a8a2b8 100755 > --- a/scripts/uboot-script-gen > +++ b/scripts/uboot-script-gen > @@ -966,7 +966,7 @@ function check_depends() > > function check_boot_cmd() > { > - if ! [[ " bootm booti bootefi " =~ " ${BOOT_CMD}" ]] > + if ! [[ " bootm booti bootefi none " =~ " ${BOOT_CMD}" ]] > then > echo "\"BOOT_CMD=$BOOT_CMD\" is not valid" > exit 1 > @@ -1251,9 +1251,19 @@ fi > > if test "$dynamic_loading_opt" > then > - echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE > + if [ "$BOOT_CMD" != "none" ] > + then > + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE > + fi > else > - echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE > + if [ "$BOOT_CMD" != "none" ] > + then > + echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE > + else > + # skip boot command but store load addresses to be used later > + echo "setenv host_kernel_addr $kernel_addr" >> $UBOOT_SOURCE > + echo "setenv host_fdt_addr $device_tree_addr" >> $UBOOT_SOURCE > + fi > fi > > if test "$FIT" > -- > 2.35.1 > From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:27:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:27:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376465.609246 (Exim 4.92) (envelope-from ) id 1oGncS-00087C-TB; Wed, 27 Jul 2022 20:27:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376465.609246; Wed, 27 Jul 2022 20:27:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGncS-000875-Oa; Wed, 27 Jul 2022 20:27:00 +0000 Received: by outflank-mailman (input) for mailman id 376465; Wed, 27 Jul 2022 20:26:59 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGncR-00086z-MN for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 20:26:59 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 768fdd20-0dea-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 22:26:58 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 87349B82282; Wed, 27 Jul 2022 20:26:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 477E2C433C1; Wed, 27 Jul 2022 20:26:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 768fdd20-0dea-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658953616; bh=TLiDUjVEo7v3zFvmH/RZk624bWJTIvZF5/mUW78k9tA=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jbSU1NASspwAIl6lH81vVaGGmRpl0tjIg7FCbesrJtv6IbMQooY/XuKAn7RIJwcCv FYcRUZkO4bK6A11y5a6Efdj4h3eWI5gMC37dtBkkk4CbEG3/vvi89SQJvH4+qMPfSt EvYaHtk6naFGnVRscGtXpG0/KzuySOdZzi4pRv0THZNMJI1IexwDUt3HvX0Do2tP9i iYzzB3eecFflxQ1iIyiKR1HwKxJzZGeOnufQruvgRzcdCja4dgwNTx88pAkaLoWB/i JKMt8O2N4bRaBAkXJG03LV641AeuAHhmlArCPbAEBGY3+1vxs40+yHfrqJpxbP7ruR 7dl1m1S10f6ug== Date: Wed, 27 Jul 2022 13:26:53 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: Stefano Stabellini , Jan Beulich , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation In-Reply-To: <649c2902-0d36-bfc7-43a8-98e6c38b6ecd@gmail.com> Message-ID: References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> <649c2902-0d36-bfc7-43a8-98e6c38b6ecd@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; BOUNDARY="8323329-1700696390-1658953582=:4648" Content-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1700696390-1658953582=:4648 Content-Type: text/plain; CHARSET=UTF-8 Content-Transfer-Encoding: 8BIT Content-ID: On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > On 7/27/22 03:10, Stefano Stabellini wrote: > > On Tue, 26 Jul 2022, Jan Beulich wrote: > > > On 26.07.2022 02:33, Stefano Stabellini wrote: > > > > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > > > > > On 7/25/22 09:32, Jan Beulich wrote: > > > > > > On 24.07.2022 19:20, Xenia Ragiadakou wrote: > > > > > > > On 7/7/22 10:55, Jan Beulich wrote: > > > > > > > > On 07.07.2022 09:27, Xenia Ragiadakou wrote: > > > > > > > > > On 7/6/22 11:51, Jan Beulich wrote: > > > > > > > > > > On 06.07.2022 10:43, Xenia Ragiadakou wrote: > > > > > > > > > > > On 7/6/22 10:10, Jan Beulich wrote: > > > > > > > > > > > > On 05.07.2022 23:02, Xenia Ragiadakou wrote: > > > > > > > > > > > > > The function idle_loop() is referenced only in > > > > > > > > > > > > > domain.c. > > > > > > > > > > > > > Change its linkage from external to internal by adding > > > > > > > > > > > > > the > > > > > > > > > > > > > storage-class > > > > > > > > > > > > > specifier static to its definitions. > > > > > > > > > > > > > > > > > > > > > > > > > > Since idle_loop() is referenced only in inline > > > > > > > > > > > > > assembly, add > > > > > > > > > > > > > the 'used' > > > > > > > > > > > > > attribute to suppress unused-function compiler > > > > > > > > > > > > > warning. > > > > > > > > > > > > > > > > > > > > > > > > While I see that Julien has already acked the patch, I'd > > > > > > > > > > > > like to > > > > > > > > > > > > point > > > > > > > > > > > > out that using __used here is somewhat bogus. Imo the > > > > > > > > > > > > better > > > > > > > > > > > > approach > > > > > > > > > > > > is to properly make visible to the compiler that the > > > > > > > > > > > > symbol is > > > > > > > > > > > > used by > > > > > > > > > > > > the asm(), by adding a fake(?) input. > > > > > > > > > > > > > > > > > > > > > > I 'm afraid I do not understand what do you mean by > > > > > > > > > > > "adding a > > > > > > > > > > > fake(?) > > > > > > > > > > > input". Can you please elaborate a little on your > > > > > > > > > > > suggestion? > > > > > > > > > > > > > > > > > > > > Once the asm() in question takes the function as an input, > > > > > > > > > > the > > > > > > > > > > compiler > > > > > > > > > > will know that the function has a user (unless, of course, > > > > > > > > > > it finds > > > > > > > > > > a > > > > > > > > > > way to elide the asm() itself). The "fake(?)" was because > > > > > > > > > > I'm not > > > > > > > > > > deeply > > > > > > > > > > enough into Arm inline assembly to know whether the input > > > > > > > > > > could then > > > > > > > > > > also be used as an instruction operand (which imo would be > > > > > > > > > > preferable) - > > > > > > > > > > if it can't (e.g. because there's no suitable constraint or > > > > > > > > > > operand > > > > > > > > > > modifier), it still can be an input just to inform the > > > > > > > > > > compiler. > > > > > > > > > > > > > > > > > > According to the following statement, your approach is the > > > > > > > > > recommended > > > > > > > > > one: > > > > > > > > > "To prevent the compiler from removing global data or > > > > > > > > > functions which > > > > > > > > > are referenced from inline assembly statements, you can: > > > > > > > > > -use __attribute__((used)) with the global data or functions. > > > > > > > > > -pass the reference to global data or functions as operands to > > > > > > > > > inline > > > > > > > > > assembly statements. > > > > > > > > > Arm recommends passing the reference to global data or > > > > > > > > > functions as > > > > > > > > > operands to inline assembly statements so that if the final > > > > > > > > > image does > > > > > > > > > not require the inline assembly statements and the referenced > > > > > > > > > global > > > > > > > > > data or function, then they can be removed." > > > > > > > > > > > > > > > > > > IIUC, you are suggesting to change > > > > > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : > > > > > > > > > "memory" ) > > > > > > > > > into > > > > > > > > > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : > > > > > > > > > "memory" > > > > > > > > > ); > > > > > > > > > > > > > > > > Yes, except that I can't judge about the "S" constraint. > > > > > > > > > > > > > > > > > > > > > > This constraint does not work for arm32. Any other thoughts? > > > > > > > > > > > > > > Another way, as Jan suggested, is to pass the function as a 'fake' > > > > > > > (unused) input. > > > > > > > I 'm suspecting something like the following could work > > > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : > > > > > > > "memory") > > > > > > > What do you think? > > > > > > > > > > > > Well, yes, X should always be a fallback option. But I said already > > > > > > when > > > > > > you suggested S that I can't judge about its use, so I guess I'm the > > > > > > wrong one to ask. Even more so that you only say "does not work", > > > > > > without > > > > > > any details ... > > > > > > > > > > > > > > > > The question is addressed to anyone familiar with arm inline assembly. > > > > > I added the arm maintainers as primary recipients to this email to > > > > > make this > > > > > perfectly clear. > > > > > > > > > > When cross-compiling Xen on x86 for arm32 with > > > > > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" > > > > > ); > > > > > compilation fails with the error: impossible constraint in ‘asm' > > > > > > > > Unfortunately looking at the GCC manual pages [1], it doesn't seem to be > > > > possible. The problem is that the definition of "S" changes between > > > > aarch64 and arm (the 32-bit version). > > > > > > > > For aarch64: > > > > > > > > S An absolute symbolic address or a label reference > > > > > > > > This is what we want. For arm instead: > > > > > > > > S A symbol in the text segment of the current file > > > > > > > > This is not useful for what we need to do here. As far as I can tell, > > > > there is no other way in GCC assembly inline for arm to do this. > > > > > > > > So we have 2 choices: we use the __used keyword as Xenia did in this > > > > patch. Or we move the implementation of switch_stack_and_jump in > > > > assembly. I attempted a prototype of the latter to see how it would come > > > > out, see below. > > > > > > > > I don't like it very much. I prefer the version with __used that Xenia > > > > had in this patch. But I am OK either way. > > > > > > You forgot the imo better intermediate option of using the "X" constraint. > > > > I couldn't get "X" to compile in any way (not even for arm64). Do you > > have a concrete example that you think should work using "X" as > > constraint? > > I proposed the X constraint for the case that the function is used as a fake > (unused) input operand to the inline asm. > For instance, in the example below, the function is listed in the input > operands but there is not corresponding reference to it. > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); Also replying to Jan, yes, this doesn't build for me, not even for arm64. The error is below. arch/arm/domain.c: In function ‘continue_new_vcpu’: arch/arm/domain.c:345:30: error: ‘return_to_new_vcpu32’ undeclared (first use in this function) 345 | reset_stack_and_jump(return_to_new_vcpu32); | ^~~~~~~~~~~~~~~~~~~~ ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ | ^~ arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ 345 | reset_stack_and_jump(return_to_new_vcpu32); | ^~~~~~~~~~~~~~~~~~~~ arch/arm/domain.c:345:30: note: each undeclared identifier is reported only once for each function it appears in 345 | reset_stack_and_jump(return_to_new_vcpu32); | ^~~~~~~~~~~~~~~~~~~~ ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ | ^~ arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ 345 | reset_stack_and_jump(return_to_new_vcpu32); | ^~~~~~~~~~~~~~~~~~~~ CC arch/arm/domain_build.o arch/arm/domain.c:348:30: error: ‘return_to_new_vcpu64’ undeclared (first use in this function) 348 | reset_stack_and_jump(return_to_new_vcpu64); | ^~~~~~~~~~~~~~~~~~~~ ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ | ^~ arch/arm/domain.c:348:9: note: in expansion of macro ‘reset_stack_and_jump’ 348 | reset_stack_and_jump(return_to_new_vcpu64); | ^~~~~~~~~~~~~~~~~~~~ make[2]: *** [Rules.mk:246: arch/arm/domain.o] Error 1 --8323329-1700696390-1658953582=:4648-- From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:52:55 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:52:55 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376472.609256 (Exim 4.92) (envelope-from ) id 1oGo1R-0003J4-Px; Wed, 27 Jul 2022 20:52:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376472.609256; Wed, 27 Jul 2022 20:52:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo1R-0003Ix-NO; Wed, 27 Jul 2022 20:52:49 +0000 Received: by outflank-mailman (input) for mailman id 376472; Wed, 27 Jul 2022 20:52:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo1Q-0003In-7E; Wed, 27 Jul 2022 20:52:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo1Q-0007Jn-4W; Wed, 27 Jul 2022 20:52:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo1P-0002wc-NV; Wed, 27 Jul 2022 20:52:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGo1P-0007yz-N5; Wed, 27 Jul 2022 20:52:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=/T4BI7Mgd4oen2WXaxjMhnCQs1+LZupRfkvEZLvaVVk=; b=OYI+mD47QsRbvvrlLOqHg/SUF+ kfH41iv6TEy+AE1Ucf/unDLiLnTLYM1B+iTNjrGFvVykNakEXWtY08kOlERcNo3lUni5dDMuLrs5h QK7dxyvRnZLq6rxL1n69DMTE+GZFVTx5J3MECA0mw7u7E8lPTVKNoz03Pz3kly4l3JQo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.15-testing test] 171880: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.15-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.15-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.15-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=b64f1c9e3e3a2a416c7bb5aab77ba5d2cba98638 X-Osstest-Versions-That: xen=3859f3ee7e37323ae5e0014c07ba8d3a4d7890b2 From: osstest service owner Date: Wed, 27 Jul 2022 20:52:47 +0000 flight 171880 xen-4.15-testing real [real] http://logs.test-lab.xenproject.org/osstest/logs/171880/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171866 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171866 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171866 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171866 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171866 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171866 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171866 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171866 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171866 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171866 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171866 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171866 test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen b64f1c9e3e3a2a416c7bb5aab77ba5d2cba98638 baseline version: xen 3859f3ee7e37323ae5e0014c07ba8d3a4d7890b2 Last test of basis 171866 2022-07-26 13:07:13 Z 1 days Testing same since 171880 2022-07-27 07:37:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 3859f3ee7e..b64f1c9e3e b64f1c9e3e3a2a416c7bb5aab77ba5d2cba98638 -> stable-4.15 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 20:59:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 20:59:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376489.609300 (Exim 4.92) (envelope-from ) id 1oGo87-0004ZQ-2f; Wed, 27 Jul 2022 20:59:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376489.609300; Wed, 27 Jul 2022 20:59:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo86-0004ZJ-W3; Wed, 27 Jul 2022 20:59:42 +0000 Received: by outflank-mailman (input) for mailman id 376489; Wed, 27 Jul 2022 20:59:41 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo85-0004Z9-Bw; Wed, 27 Jul 2022 20:59:41 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo85-0007RO-A9; Wed, 27 Jul 2022 20:59:41 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGo85-0003Br-16; Wed, 27 Jul 2022 20:59:41 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGo85-0004CM-0g; Wed, 27 Jul 2022 20:59:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UPsckrbMvRWa8+uDEt2rJHpe7dJZ/G5QrxE3LPx/30E=; b=O690Hv67cFrt7W/0dKG6pxrivZ eJwxCK8bY7wEmQ+xkLVN9bKYfIriTsWTLqeqQWVH5vdRvyxv4RVcCPU65WgMlwPfusLQp+Bz+zC7n 8/c+maPnOLhhmX3sZ0byCvGjvRGRUO4M2bAKm134qPeG3yTRAl1h/Cir43iIaiZiVaUU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171888: all pass - PUSHED X-Osstest-Versions-This: ovmf=2677286307c67b62c198cf6890d62ec540dd8c99 X-Osstest-Versions-That: ovmf=e3d468acb9ce26a75fee45d742619ac1c6683280 From: osstest service owner Date: Wed, 27 Jul 2022 20:59:41 +0000 flight 171888 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171888/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 2677286307c67b62c198cf6890d62ec540dd8c99 baseline version: ovmf e3d468acb9ce26a75fee45d742619ac1c6683280 Last test of basis 171883 2022-07-27 10:10:34 Z 0 days Testing same since 171888 2022-07-27 17:10:40 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: James Lu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e3d468acb9..2677286307 2677286307c67b62c198cf6890d62ec540dd8c99 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Wed Jul 27 22:02:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 22:02:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376498.609311 (Exim 4.92) (envelope-from ) id 1oGp6n-000441-NB; Wed, 27 Jul 2022 22:02:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376498.609311; Wed, 27 Jul 2022 22:02:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGp6n-00043u-KZ; Wed, 27 Jul 2022 22:02:25 +0000 Received: by outflank-mailman (input) for mailman id 376498; Wed, 27 Jul 2022 22:02:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGp6l-00043o-Me for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 22:02:23 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c9641831-0df7-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 00:02:20 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id fy29so33723470ejc.12 for ; Wed, 27 Jul 2022 15:02:20 -0700 (PDT) Received: from [192.168.1.93] (adsl-141.176.58.136.tellas.gr. [176.58.136.141]) by smtp.gmail.com with ESMTPSA id j15-20020aa7de8f000000b0043be16f5f4csm7423304edv.52.2022.07.27.15.02.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Jul 2022 15:02:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c9641831-0df7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=1KecFxKnpsM2MDCQw+NB1wExFKOHJH7W6XV6HWWmZ6s=; b=eJjh6oruyfl4UFpEkqnZdqGdw7CQ7pg4pWpkccw/yEv/2bCEhvN1i2Q/NMDq6jBKnd D3iu+8WQFFK5hSi1igXi1KCyLdUXyk12Fux1oMDDxlEmO1n5f9ttpFq58iYz66O90D+P +Yfj8+VG2unqUNM7OVpjaRh3lWXN9VctpirBk98JDrvxdZIzXb4Kg404eN4xDMy7VjXf 85b8H8KPQwPK1Po89Flp+I/SX0ExywHqYxB2HroRRd5BGYfvf5X/twFXdL89ibW9YAlC H4miMOUAELawLJO2DBIt/gIXxdVKrM6ZczjURpg9MZePkwZvc037IAp/E9yLdiJ0qUTH u0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=1KecFxKnpsM2MDCQw+NB1wExFKOHJH7W6XV6HWWmZ6s=; b=s0KfUxfA+PmKntsQE4BJHLjw1kalRBXKV58uJxpAohJDd3noRhzGw/v36XZWbJUGqF 8H6AFN0noMlzHlyXeJJHQPwC95W912gcFTod6kIqtzO6SjstG7RngYBSCODuAECryb0a fGnJnkV0UnQYqzFvjNU9Dr1cC32g6xU8gZ4V3yUIOxKo3SA1LNBLny+APjlj4YcCkAZC qxNbRT/QXECcofXa+titAZUdcy7daaHlvgRoHUZkOcuRAU/li0LpGTxC0Bs8TgO0lUV5 /qJV5UYx1X2uJ5XoUaL7jPvnNYpdnZ3weaHcGd3RYYNS7czGrx8gLfbcNMQJ3VpnlEpO yaFg== X-Gm-Message-State: AJIora88NwkrHTz75aokqUcFxeKLGSuQGaek9fIersV13TFqlzNSYyus r45wsa5TtzdI0qMc/Nhfzw8= X-Google-Smtp-Source: AGRyM1v6RMSc85PiICLT8i4w284srzSrO432Uz/M+C8aRZ5CiILsx7Z10snRib69c4c966dy50gRTw== X-Received: by 2002:a17:906:84e1:b0:72b:b109:7636 with SMTP id zp1-20020a17090684e100b0072bb1097636mr20585560ejb.10.1658959339936; Wed, 27 Jul 2022 15:02:19 -0700 (PDT) Message-ID: <68c7f43c-221a-299e-ee5b-3262dcf10fca@gmail.com> Date: Thu, 28 Jul 2022 01:02:17 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Stefano Stabellini Cc: Jan Beulich , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> <649c2902-0d36-bfc7-43a8-98e6c38b6ecd@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Stefano, On 7/27/22 23:26, Stefano Stabellini wrote: > On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: >> On 7/27/22 03:10, Stefano Stabellini wrote: >>> On Tue, 26 Jul 2022, Jan Beulich wrote: >>>> On 26.07.2022 02:33, Stefano Stabellini wrote: >>>>> On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: >>>>>> On 7/25/22 09:32, Jan Beulich wrote: >>>>>>> On 24.07.2022 19:20, Xenia Ragiadakou wrote: >>>>>>>> On 7/7/22 10:55, Jan Beulich wrote: >>>>>>>>> On 07.07.2022 09:27, Xenia Ragiadakou wrote: >>>>>>>>>> On 7/6/22 11:51, Jan Beulich wrote: >>>>>>>>>>> On 06.07.2022 10:43, Xenia Ragiadakou wrote: >>>>>>>>>>>> On 7/6/22 10:10, Jan Beulich wrote: >>>>>>>>>>>>> On 05.07.2022 23:02, Xenia Ragiadakou wrote: >>>>>>>>>>>>>> The function idle_loop() is referenced only in >>>>>>>>>>>>>> domain.c. >>>>>>>>>>>>>> Change its linkage from external to internal by adding >>>>>>>>>>>>>> the >>>>>>>>>>>>>> storage-class >>>>>>>>>>>>>> specifier static to its definitions. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Since idle_loop() is referenced only in inline >>>>>>>>>>>>>> assembly, add >>>>>>>>>>>>>> the 'used' >>>>>>>>>>>>>> attribute to suppress unused-function compiler >>>>>>>>>>>>>> warning. >>>>>>>>>>>>> >>>>>>>>>>>>> While I see that Julien has already acked the patch, I'd >>>>>>>>>>>>> like to >>>>>>>>>>>>> point >>>>>>>>>>>>> out that using __used here is somewhat bogus. Imo the >>>>>>>>>>>>> better >>>>>>>>>>>>> approach >>>>>>>>>>>>> is to properly make visible to the compiler that the >>>>>>>>>>>>> symbol is >>>>>>>>>>>>> used by >>>>>>>>>>>>> the asm(), by adding a fake(?) input. >>>>>>>>>>>> >>>>>>>>>>>> I 'm afraid I do not understand what do you mean by >>>>>>>>>>>> "adding a >>>>>>>>>>>> fake(?) >>>>>>>>>>>> input". Can you please elaborate a little on your >>>>>>>>>>>> suggestion? >>>>>>>>>>> >>>>>>>>>>> Once the asm() in question takes the function as an input, >>>>>>>>>>> the >>>>>>>>>>> compiler >>>>>>>>>>> will know that the function has a user (unless, of course, >>>>>>>>>>> it finds >>>>>>>>>>> a >>>>>>>>>>> way to elide the asm() itself). The "fake(?)" was because >>>>>>>>>>> I'm not >>>>>>>>>>> deeply >>>>>>>>>>> enough into Arm inline assembly to know whether the input >>>>>>>>>>> could then >>>>>>>>>>> also be used as an instruction operand (which imo would be >>>>>>>>>>> preferable) - >>>>>>>>>>> if it can't (e.g. because there's no suitable constraint or >>>>>>>>>>> operand >>>>>>>>>>> modifier), it still can be an input just to inform the >>>>>>>>>>> compiler. >>>>>>>>>> >>>>>>>>>> According to the following statement, your approach is the >>>>>>>>>> recommended >>>>>>>>>> one: >>>>>>>>>> "To prevent the compiler from removing global data or >>>>>>>>>> functions which >>>>>>>>>> are referenced from inline assembly statements, you can: >>>>>>>>>> -use __attribute__((used)) with the global data or functions. >>>>>>>>>> -pass the reference to global data or functions as operands to >>>>>>>>>> inline >>>>>>>>>> assembly statements. >>>>>>>>>> Arm recommends passing the reference to global data or >>>>>>>>>> functions as >>>>>>>>>> operands to inline assembly statements so that if the final >>>>>>>>>> image does >>>>>>>>>> not require the inline assembly statements and the referenced >>>>>>>>>> global >>>>>>>>>> data or function, then they can be removed." >>>>>>>>>> >>>>>>>>>> IIUC, you are suggesting to change >>>>>>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : >>>>>>>>>> "memory" ) >>>>>>>>>> into >>>>>>>>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : >>>>>>>>>> "memory" >>>>>>>>>> ); >>>>>>>>> >>>>>>>>> Yes, except that I can't judge about the "S" constraint. >>>>>>>>> >>>>>>>> >>>>>>>> This constraint does not work for arm32. Any other thoughts? >>>>>>>> >>>>>>>> Another way, as Jan suggested, is to pass the function as a 'fake' >>>>>>>> (unused) input. >>>>>>>> I 'm suspecting something like the following could work >>>>>>>> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : >>>>>>>> "memory") >>>>>>>> What do you think? >>>>>>> >>>>>>> Well, yes, X should always be a fallback option. But I said already >>>>>>> when >>>>>>> you suggested S that I can't judge about its use, so I guess I'm the >>>>>>> wrong one to ask. Even more so that you only say "does not work", >>>>>>> without >>>>>>> any details ... >>>>>>> >>>>>> >>>>>> The question is addressed to anyone familiar with arm inline assembly. >>>>>> I added the arm maintainers as primary recipients to this email to >>>>>> make this >>>>>> perfectly clear. >>>>>> >>>>>> When cross-compiling Xen on x86 for arm32 with >>>>>> asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : "memory" >>>>>> ); >>>>>> compilation fails with the error: impossible constraint in ‘asm' >>>>> >>>>> Unfortunately looking at the GCC manual pages [1], it doesn't seem to be >>>>> possible. The problem is that the definition of "S" changes between >>>>> aarch64 and arm (the 32-bit version). >>>>> >>>>> For aarch64: >>>>> >>>>> S An absolute symbolic address or a label reference >>>>> >>>>> This is what we want. For arm instead: >>>>> >>>>> S A symbol in the text segment of the current file >>>>> >>>>> This is not useful for what we need to do here. As far as I can tell, >>>>> there is no other way in GCC assembly inline for arm to do this. >>>>> >>>>> So we have 2 choices: we use the __used keyword as Xenia did in this >>>>> patch. Or we move the implementation of switch_stack_and_jump in >>>>> assembly. I attempted a prototype of the latter to see how it would come >>>>> out, see below. >>>>> >>>>> I don't like it very much. I prefer the version with __used that Xenia >>>>> had in this patch. But I am OK either way. >>>> >>>> You forgot the imo better intermediate option of using the "X" constraint. >>> >>> I couldn't get "X" to compile in any way (not even for arm64). Do you >>> have a concrete example that you think should work using "X" as >>> constraint? >> >> I proposed the X constraint for the case that the function is used as a fake >> (unused) input operand to the inline asm. >> For instance, in the example below, the function is listed in the input >> operands but there is not corresponding reference to it. >> >> asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); > > > Also replying to Jan, yes, this doesn't build for me, not even for > arm64. The error is below. > > > arch/arm/domain.c: In function ‘continue_new_vcpu’: > arch/arm/domain.c:345:30: error: ‘return_to_new_vcpu32’ undeclared (first use in this function) > 345 | reset_stack_and_jump(return_to_new_vcpu32); > | ^~~~~~~~~~~~~~~~~~~~ > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ > | ^~ > arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ > 345 | reset_stack_and_jump(return_to_new_vcpu32); > | ^~~~~~~~~~~~~~~~~~~~ > arch/arm/domain.c:345:30: note: each undeclared identifier is reported only once for each function it appears in > 345 | reset_stack_and_jump(return_to_new_vcpu32); > | ^~~~~~~~~~~~~~~~~~~~ > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ > | ^~ > arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ > 345 | reset_stack_and_jump(return_to_new_vcpu32); > | ^~~~~~~~~~~~~~~~~~~~ > CC arch/arm/domain_build.o > arch/arm/domain.c:348:30: error: ‘return_to_new_vcpu64’ undeclared (first use in this function) > 348 | reset_stack_and_jump(return_to_new_vcpu64); > | ^~~~~~~~~~~~~~~~~~~~ > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro ‘switch_stack_and_jump’ > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ > | ^~ > arch/arm/domain.c:348:9: note: in expansion of macro ‘reset_stack_and_jump’ > 348 | reset_stack_and_jump(return_to_new_vcpu64); > | ^~~~~~~~~~~~~~~~~~~~ > make[2]: *** [Rules.mk:246: arch/arm/domain.o] Error 1 With this change, the compiler becomes aware that the functions idle_loop, return_to_new_vcpu32 and return_to_new_vcpu64 are used by the inline assembly. For idle loop, there is a previous declaration but for the other two there is not and when the compiler encounters their references complains. So, for this to compile, it is also required to declare return_to_new_vcpu32 and return_to_new_vcpu64. -- Xenia From xen-devel-bounces@lists.xenproject.org Wed Jul 27 23:26:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 23:26:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376512.609354 (Exim 4.92) (envelope-from ) id 1oGqPj-0005Iw-54; Wed, 27 Jul 2022 23:26:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376512.609354; Wed, 27 Jul 2022 23:26:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqPj-0005Ip-1y; Wed, 27 Jul 2022 23:26:03 +0000 Received: by outflank-mailman (input) for mailman id 376512; Wed, 27 Jul 2022 23:26:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqPi-0005If-9g; Wed, 27 Jul 2022 23:26:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqPi-0001kS-6z; Wed, 27 Jul 2022 23:26:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqPh-0000zg-Ns; Wed, 27 Jul 2022 23:26:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGqPh-00054Y-NE; Wed, 27 Jul 2022 23:26:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=oxycqYEO/cUhF1JnPvcqUMjYbq7HTp1Xy+mvAVzwLV0=; b=7PdF6Sj6tLL1kfkoICZBi+UkOQ QLuTeGl5mr+sgvtUstn3LelVEaARLqQWZvSMj8bcO7wPS7yPZVO0v/4rIAUnE492jhU7WrHo/TtXP Ou7zqjGN5qdfpJFfh6wSYDrrONMoYUh+1w9VEJDk55Y15JB/AxcB9/N937hCAch2U25c=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-4.16-testing test] 171881: tolerable FAIL - PUSHED X-Osstest-Failures: xen-4.16-testing:test-amd64-i386-xl-xsm:xen-install:fail:heisenbug xen-4.16-testing:test-armhf-armhf-libvirt-raw:guest-start/debian.repeat:fail:heisenbug xen-4.16-testing:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-4.16-testing:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=d77bb6e5375f19c64d182fb7b2e53138152421b5 X-Osstest-Versions-That: xen=221f6a97b59e008f11eb310ad0c9b802f3bea233 From: osstest service owner Date: Wed, 27 Jul 2022 23:26:01 +0000 flight 171881 xen-4.16-testing real [real] flight 171890 xen-4.16-testing real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171881/ http://logs.test-lab.xenproject.org/osstest/logs/171890/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-xl-xsm 7 xen-install fail pass in 171890-retest test-armhf-armhf-libvirt-raw 17 guest-start/debian.repeat fail pass in 171890-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171867 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171867 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171867 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171867 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171867 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171867 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171867 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171867 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171867 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171867 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171867 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171867 test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass version targeted for testing: xen d77bb6e5375f19c64d182fb7b2e53138152421b5 baseline version: xen 221f6a97b59e008f11eb310ad0c9b802f3bea233 Last test of basis 171867 2022-07-26 13:07:16 Z 1 days Testing same since 171881 2022-07-27 07:37:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Jan Beulich Juergen Gross Luca Fancellu jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm fail test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git 221f6a97b5..d77bb6e537 d77bb6e5375f19c64d182fb7b2e53138152421b5 -> stable-4.16 From xen-devel-bounces@lists.xenproject.org Wed Jul 27 23:26:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Wed, 27 Jul 2022 23:26:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376518.609365 (Exim 4.92) (envelope-from ) id 1oGqQS-0005sH-Kc; Wed, 27 Jul 2022 23:26:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376518.609365; Wed, 27 Jul 2022 23:26:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqQS-0005sA-Hu; Wed, 27 Jul 2022 23:26:48 +0000 Received: by outflank-mailman (input) for mailman id 376518; Wed, 27 Jul 2022 23:26:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqQQ-0005rb-UZ; Wed, 27 Jul 2022 23:26:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqQQ-0001l7-Te; Wed, 27 Jul 2022 23:26:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGqQQ-000121-F9; Wed, 27 Jul 2022 23:26:46 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGqQQ-0005bw-Ek; Wed, 27 Jul 2022 23:26:46 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xKbHlqPAVBbT9tW098Sx90cLVvT7oQ5asa7AY3SAMRE=; b=VEjsF3v95d6ppK6VS0P2PiqWLp sqsggd8DNwKi6HfLKQLSHw+IDjT4xND52SNBHcs1c5tg9usEqIFmz5sEB5QpGPDC/T3wR7Rdflixd HTvgU/cJms/hBYFhOahyyIcw1nygz9Hej9yhN3kojdHAQWStDeR9Cl2uYM3SdMM1vm60=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171889: all pass - PUSHED X-Osstest-Versions-This: ovmf=f26b70cb9f1367ceb25190ba2777631ee42c69fe X-Osstest-Versions-That: ovmf=2677286307c67b62c198cf6890d62ec540dd8c99 From: osstest service owner Date: Wed, 27 Jul 2022 23:26:46 +0000 flight 171889 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171889/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf f26b70cb9f1367ceb25190ba2777631ee42c69fe baseline version: ovmf 2677286307c67b62c198cf6890d62ec540dd8c99 Last test of basis 171888 2022-07-27 17:10:40 Z 0 days Testing same since 171889 2022-07-27 21:13:18 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Benjamin Doron jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 2677286307..f26b70cb9f f26b70cb9f1367ceb25190ba2777631ee42c69fe -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 28 00:38:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 00:38:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376530.609375 (Exim 4.92) (envelope-from ) id 1oGrX1-0006Rj-Ak; Thu, 28 Jul 2022 00:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376530.609375; Thu, 28 Jul 2022 00:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGrX1-0006Rc-7k; Thu, 28 Jul 2022 00:37:39 +0000 Received: by outflank-mailman (input) for mailman id 376530; Thu, 28 Jul 2022 00:37:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGrWz-0006RS-8I; Thu, 28 Jul 2022 00:37:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGrWz-0003ex-4i; Thu, 28 Jul 2022 00:37:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGrWy-0003N0-L4; Thu, 28 Jul 2022 00:37:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGrWy-0003GN-Ke; Thu, 28 Jul 2022 00:37:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lX4A9Kse1/RB9wfasS8uRF4fapeKrpyIdHimq25ILc8=; b=esXoYCdu1pqVaOnFVmmCiitDzr AL5QfAfv9V2kYlOIDauo9+X+sCQ03oldiTJVLLk4TDt/mMO9yoxJBz9Gz4jb5+vlPhrpCxPZytMb3 bfVBtmEEvczwkdwl2m9KYbWOG50tAXeDRJPSVSaYNMavlofGePCgtpXVB4LbNhDcp6y4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171882: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=39c3c396f8131f3db454c80e0fcfcdc54ed9ec01 X-Osstest-Versions-That: linux=5de64d44968e4ae66ebdb0a2d08b443f189d3651 From: osstest service owner Date: Thu, 28 Jul 2022 00:37:36 +0000 flight 171882 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171882/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171871 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171871 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171871 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171871 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171871 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171871 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171871 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171871 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171871 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 39c3c396f8131f3db454c80e0fcfcdc54ed9ec01 baseline version: linux 5de64d44968e4ae66ebdb0a2d08b443f189d3651 Last test of basis 171871 2022-07-26 17:41:56 Z 1 days Testing same since 171882 2022-07-27 09:15:12 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrei Vagin Andrew Morton ChenXiaoSong Chris Mason Gao Xiang Geert Uytterhoeven Hawkins Jiawei Josef Bacik Joseph Qi Junxiao Bi Junxiao Bi Kirill A. Shutemov Linus Torvalds Miaohe Lin Mike Rapoport Muchun Song Nadav Amit Naoya Horiguchi Rik van Riel Seth Forshee Seth Forshee Yee Lee ZhaoLong Wang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 5de64d44968e..39c3c396f813 39c3c396f8131f3db454c80e0fcfcdc54ed9ec01 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Jul 28 01:21:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 01:21:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376538.609387 (Exim 4.92) (envelope-from ) id 1oGsD7-0001yz-JD; Thu, 28 Jul 2022 01:21:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376538.609387; Thu, 28 Jul 2022 01:21:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGsD7-0001ys-GU; Thu, 28 Jul 2022 01:21:09 +0000 Received: by outflank-mailman (input) for mailman id 376538; Thu, 28 Jul 2022 01:21:08 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGsD6-0001ym-Q0 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 01:21:08 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8d81b90d-0e13-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 03:21:06 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7E9E0617F2; Thu, 28 Jul 2022 01:21:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83B7AC433C1; Thu, 28 Jul 2022 01:21:04 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8d81b90d-0e13-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658971264; bh=T/78ugJVrOb9//QDgI8sVG76tJA6AnlZrbbGlxzlizQ=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=FJewovG/gnvYG7tEdcXSeuY0VAC1TABFwWayhazCDxaj03AP30+x6+E0J1jPll7PX bWa57Li/ND5AnvFrMFsdkMEj3j9HGfssyDU3NEo+qtXHRaYhEeA4/o+VDUiXva1pSY CAWCOspsYWXYjqGlBjcGR08DeAJWlyGNi+ubUAfL0TzXeYE35tgyN+Bsq9+zLefMUj WbyHqa007pCMZrGeL8HFNgnu6uqOeIJu5EBusNtByuIN4f9V9zvLBz7z2oWxKDnU3c sMY25lRZQMjmBvVgXRqY/OfmVQQ3+Lhek5SWOIxLEfeqgcqgrKKA81SvumBA17KSn8 uqjcE008fy5jw== Date: Wed, 27 Jul 2022 18:21:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: Stefano Stabellini , Jan Beulich , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org Subject: Re: [PATCH 3/4] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation In-Reply-To: <68c7f43c-221a-299e-ee5b-3262dcf10fca@gmail.com> Message-ID: References: <20220705210218.483854-1-burzalodowa@gmail.com> <20220705210218.483854-4-burzalodowa@gmail.com> <115c89bc-259e-8ca1-5533-49c98f637a0d@suse.com> <3f4c9270-56e5-f9fe-6de8-01c997ad2ddb@gmail.com> <910119aa-69c6-6736-49f1-3b51da1c4fb0@suse.com> <99d585dc-9bee-b0a1-7f5b-db67b2ea0944@suse.com> <8522a9aa-e7f5-9b8a-5a8f-4c6d1403317b@gmail.com> <981e2fb9-6f99-2113-86ab-f3da860b74b9@suse.com> <649c2902-0d36-bfc7-43a8-98e6c38b6ecd@gmail.com> <68c7f43c-221a-299e-ee5b-3262dcf10fca@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-1685691866-1658971264=:4648" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-1685691866-1658971264=:4648 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Thu, 28 Jul 2022, Xenia Ragiadakou wrote: > Hi Stefano, > > On 7/27/22 23:26, Stefano Stabellini wrote: > > On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > > > On 7/27/22 03:10, Stefano Stabellini wrote: > > > > On Tue, 26 Jul 2022, Jan Beulich wrote: > > > > > On 26.07.2022 02:33, Stefano Stabellini wrote: > > > > > > On Mon, 25 Jul 2022, Xenia Ragiadakou wrote: > > > > > > > On 7/25/22 09:32, Jan Beulich wrote: > > > > > > > > On 24.07.2022 19:20, Xenia Ragiadakou wrote: > > > > > > > > > On 7/7/22 10:55, Jan Beulich wrote: > > > > > > > > > > On 07.07.2022 09:27, Xenia Ragiadakou wrote: > > > > > > > > > > > On 7/6/22 11:51, Jan Beulich wrote: > > > > > > > > > > > > On 06.07.2022 10:43, Xenia Ragiadakou wrote: > > > > > > > > > > > > > On 7/6/22 10:10, Jan Beulich wrote: > > > > > > > > > > > > > > On 05.07.2022 23:02, Xenia Ragiadakou wrote: > > > > > > > > > > > > > > > The function idle_loop() is referenced only in > > > > > > > > > > > > > > > domain.c. > > > > > > > > > > > > > > > Change its linkage from external to internal by > > > > > > > > > > > > > > > adding > > > > > > > > > > > > > > > the > > > > > > > > > > > > > > > storage-class > > > > > > > > > > > > > > > specifier static to its definitions. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Since idle_loop() is referenced only in inline > > > > > > > > > > > > > > > assembly, add > > > > > > > > > > > > > > > the 'used' > > > > > > > > > > > > > > > attribute to suppress unused-function compiler > > > > > > > > > > > > > > > warning. > > > > > > > > > > > > > > > > > > > > > > > > > > > > While I see that Julien has already acked the patch, > > > > > > > > > > > > > > I'd > > > > > > > > > > > > > > like to > > > > > > > > > > > > > > point > > > > > > > > > > > > > > out that using __used here is somewhat bogus. Imo > > > > > > > > > > > > > > the > > > > > > > > > > > > > > better > > > > > > > > > > > > > > approach > > > > > > > > > > > > > > is to properly make visible to the compiler that the > > > > > > > > > > > > > > symbol is > > > > > > > > > > > > > > used by > > > > > > > > > > > > > > the asm(), by adding a fake(?) input. > > > > > > > > > > > > > > > > > > > > > > > > > > I 'm afraid I do not understand what do you mean by > > > > > > > > > > > > > "adding a > > > > > > > > > > > > > fake(?) > > > > > > > > > > > > > input". Can you please elaborate a little on your > > > > > > > > > > > > > suggestion? > > > > > > > > > > > > > > > > > > > > > > > > Once the asm() in question takes the function as an > > > > > > > > > > > > input, > > > > > > > > > > > > the > > > > > > > > > > > > compiler > > > > > > > > > > > > will know that the function has a user (unless, of > > > > > > > > > > > > course, > > > > > > > > > > > > it finds > > > > > > > > > > > > a > > > > > > > > > > > > way to elide the asm() itself). The "fake(?)" was > > > > > > > > > > > > because > > > > > > > > > > > > I'm not > > > > > > > > > > > > deeply > > > > > > > > > > > > enough into Arm inline assembly to know whether the > > > > > > > > > > > > input > > > > > > > > > > > > could then > > > > > > > > > > > > also be used as an instruction operand (which imo would > > > > > > > > > > > > be > > > > > > > > > > > > preferable) - > > > > > > > > > > > > if it can't (e.g. because there's no suitable constraint > > > > > > > > > > > > or > > > > > > > > > > > > operand > > > > > > > > > > > > modifier), it still can be an input just to inform the > > > > > > > > > > > > compiler. > > > > > > > > > > > > > > > > > > > > > > According to the following statement, your approach is the > > > > > > > > > > > recommended > > > > > > > > > > > one: > > > > > > > > > > > "To prevent the compiler from removing global data or > > > > > > > > > > > functions which > > > > > > > > > > > are referenced from inline assembly statements, you can: > > > > > > > > > > > -use __attribute__((used)) with the global data or > > > > > > > > > > > functions. > > > > > > > > > > > -pass the reference to global data or functions as > > > > > > > > > > > operands to > > > > > > > > > > > inline > > > > > > > > > > > assembly statements. > > > > > > > > > > > Arm recommends passing the reference to global data or > > > > > > > > > > > functions as > > > > > > > > > > > operands to inline assembly statements so that if the > > > > > > > > > > > final > > > > > > > > > > > image does > > > > > > > > > > > not require the inline assembly statements and the > > > > > > > > > > > referenced > > > > > > > > > > > global > > > > > > > > > > > data or function, then they can be removed." > > > > > > > > > > > > > > > > > > > > > > IIUC, you are suggesting to change > > > > > > > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : > > > > > > > > > > > "memory" ) > > > > > > > > > > > into > > > > > > > > > > > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) > > > > > > > > > > > : > > > > > > > > > > > "memory" > > > > > > > > > > > ); > > > > > > > > > > > > > > > > > > > > Yes, except that I can't judge about the "S" constraint. > > > > > > > > > > > > > > > > > > > > > > > > > > > > This constraint does not work for arm32. Any other thoughts? > > > > > > > > > > > > > > > > > > Another way, as Jan suggested, is to pass the function as a > > > > > > > > > 'fake' > > > > > > > > > (unused) input. > > > > > > > > > I 'm suspecting something like the following could work > > > > > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" > > > > > > > > > (fn) : > > > > > > > > > "memory") > > > > > > > > > What do you think? > > > > > > > > > > > > > > > > Well, yes, X should always be a fallback option. But I said > > > > > > > > already > > > > > > > > when > > > > > > > > you suggested S that I can't judge about its use, so I guess I'm > > > > > > > > the > > > > > > > > wrong one to ask. Even more so that you only say "does not > > > > > > > > work", > > > > > > > > without > > > > > > > > any details ... > > > > > > > > > > > > > > > > > > > > > > The question is addressed to anyone familiar with arm inline > > > > > > > assembly. > > > > > > > I added the arm maintainers as primary recipients to this email to > > > > > > > make this > > > > > > > perfectly clear. > > > > > > > > > > > > > > When cross-compiling Xen on x86 for arm32 with > > > > > > > asm volatile ("mov sp,%0; b %1" : : "r" (stack), "S" (fn) : > > > > > > > "memory" > > > > > > > ); > > > > > > > compilation fails with the error: impossible constraint in ‘asm' > > > > > > > > > > > > Unfortunately looking at the GCC manual pages [1], it doesn't seem > > > > > > to be > > > > > > possible. The problem is that the definition of "S" changes between > > > > > > aarch64 and arm (the 32-bit version). > > > > > > > > > > > > For aarch64: > > > > > > > > > > > > S An absolute symbolic address or a label reference > > > > > > > > > > > > This is what we want. For arm instead: > > > > > > > > > > > > S A symbol in the text segment of the current file > > > > > > > > > > > > This is not useful for what we need to do here. As far as I can > > > > > > tell, > > > > > > there is no other way in GCC assembly inline for arm to do this. > > > > > > > > > > > > So we have 2 choices: we use the __used keyword as Xenia did in this > > > > > > patch. Or we move the implementation of switch_stack_and_jump in > > > > > > assembly. I attempted a prototype of the latter to see how it would > > > > > > come > > > > > > out, see below. > > > > > > > > > > > > I don't like it very much. I prefer the version with __used that > > > > > > Xenia > > > > > > had in this patch. But I am OK either way. > > > > > > > > > > You forgot the imo better intermediate option of using the "X" > > > > > constraint. > > > > > > > > I couldn't get "X" to compile in any way (not even for arm64). Do you > > > > have a concrete example that you think should work using "X" as > > > > constraint? > > > > > > I proposed the X constraint for the case that the function is used as a > > > fake > > > (unused) input operand to the inline asm. > > > For instance, in the example below, the function is listed in the input > > > operands but there is not corresponding reference to it. > > > > > > asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" > > > ); > > > > > > Also replying to Jan, yes, this doesn't build for me, not even for > > arm64. The error is below. > > > > > > arch/arm/domain.c: In function ‘continue_new_vcpu’: > > arch/arm/domain.c:345:30: error: ‘return_to_new_vcpu32’ undeclared (first > > use in this function) > > 345 | reset_stack_and_jump(return_to_new_vcpu32); > > | ^~~~~~~~~~~~~~~~~~~~ > > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro > > ‘switch_stack_and_jump’ > > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) > > : "memory" ); \ > > | ^~ > > arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ > > 345 | reset_stack_and_jump(return_to_new_vcpu32); > > | ^~~~~~~~~~~~~~~~~~~~ > > arch/arm/domain.c:345:30: note: each undeclared identifier is reported only > > once for each function it appears in > > 345 | reset_stack_and_jump(return_to_new_vcpu32); > > | ^~~~~~~~~~~~~~~~~~~~ > > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro > > ‘switch_stack_and_jump’ > > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) > > : "memory" ); \ > > | ^~ > > arch/arm/domain.c:345:9: note: in expansion of macro ‘reset_stack_and_jump’ > > 345 | reset_stack_and_jump(return_to_new_vcpu32); > > | ^~~~~~~~~~~~~~~~~~~~ > > CC arch/arm/domain_build.o > > arch/arm/domain.c:348:30: error: ‘return_to_new_vcpu64’ undeclared (first > > use in this function) > > 348 | reset_stack_and_jump(return_to_new_vcpu64); > > | ^~~~~~~~~~~~~~~~~~~~ > > ./arch/arm/include/asm/current.h:48:65: note: in definition of macro > > ‘switch_stack_and_jump’ > > 48 | asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) > > : "memory" ); \ > > | ^~ > > arch/arm/domain.c:348:9: note: in expansion of macro ‘reset_stack_and_jump’ > > 348 | reset_stack_and_jump(return_to_new_vcpu64); > > | ^~~~~~~~~~~~~~~~~~~~ > > make[2]: *** [Rules.mk:246: arch/arm/domain.o] Error 1 > > With this change, the compiler becomes aware that the functions idle_loop, > return_to_new_vcpu32 and return_to_new_vcpu64 are used by the inline assembly. > For idle loop, there is a previous declaration but for the other two there is > not and when the compiler encounters their references complains. > So, for this to compile, it is also required to declare > return_to_new_vcpu32 and return_to_new_vcpu64. Ah, right! I didn't read close enough the error message. I can see now that it builds just fine on both arm32 and arm64. I am fine with this. --8323329-1685691866-1658971264=:4648-- From xen-devel-bounces@lists.xenproject.org Thu Jul 28 01:27:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 01:27:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376545.609398 (Exim 4.92) (envelope-from ) id 1oGsIu-0002tB-Be; Thu, 28 Jul 2022 01:27:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376545.609398; Thu, 28 Jul 2022 01:27:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGsIu-0002t4-8Q; Thu, 28 Jul 2022 01:27:08 +0000 Received: by outflank-mailman (input) for mailman id 376545; Thu, 28 Jul 2022 01:27:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGsIs-0002sy-Rs for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 01:27:06 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 63338e8d-0e14-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 03:27:05 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 69F34CE2409; Thu, 28 Jul 2022 01:27:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E5A2C433C1; Thu, 28 Jul 2022 01:27:01 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 63338e8d-0e14-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658971621; bh=kZvWyMfOxQe8a61w4boVUHXl/mfeigG/DPDDQE/zMBM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=EQPKmee2Z7RFPqPDxhWc+isi7CrXVh+r+JAZS5m2rY7OF2poJiuNRmQVjFIdrFss6 oChkWhYvdHcX4Ouqzz7H8lYHlKFWrXzgBGYeBq3CbzjLIQhbp51HRAV9fTLTyOmb8C pNwCfyz9by3VwWcQ8214yKAHVJyoXeud19lB1lOd5ROlvtElygSRkywx0ZTyUPklDp xy1JOavM7PN8VKy2cL4zqRssDR53wUfaEUo40tZtdt4AD610htA8JH0iAhhDWLsA0S eeP0LyxolnjvubqSVsZjVk5MqPRyac9v434EbT0WehhZOvJPocGKEgfyetLUSTwkY4 IMJ5X3KD84WiA== Date: Wed, 27 Jul 2022 18:26:59 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: Re: [PATCH v2 1/1] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 20.7 violation In-Reply-To: <20220727171841.1163075-2-burzalodowa@gmail.com> Message-ID: References: <20220727171841.1163075-1-burzalodowa@gmail.com> <20220727171841.1163075-2-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 27 Jul 2022, Xenia Ragiadakou wrote: > The macro parameter 'p' is used as an expression and needs to be enclosed in > parentheses. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > > Changes in v2: > - remove parentheses in the cases that p is not used as an expression that is > when it is used as a function argument > > xen/arch/arm/include/asm/atomic.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h > index ac2798d095..1f60c28b1b 100644 > --- a/xen/arch/arm/include/asm/atomic.h > +++ b/xen/arch/arm/include/asm/atomic.h > @@ -123,15 +123,15 @@ static always_inline void write_atomic_size(volatile void *p, > } > > #define read_atomic(p) ({ \ > - union { typeof(*p) val; char c[0]; } x_; \ > - read_atomic_size(p, x_.c, sizeof(*p)); \ > + union { typeof(*(p)) val; char c[0]; } x_; \ > + read_atomic_size(p, x_.c, sizeof(*(p))); \ > x_.val; \ > }) > > #define write_atomic(p, x) \ > do { \ > - typeof(*p) x_ = (x); \ > - write_atomic_size(p, &x_, sizeof(*p)); \ > + typeof(*(p)) x_ = (x); \ > + write_atomic_size(p, &x_, sizeof(*(p))); \ > } while ( false ) > > #define add_sized(p, x) ({ \ > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Thu Jul 28 01:47:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 01:47:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376551.609409 (Exim 4.92) (envelope-from ) id 1oGscK-0005cA-Vi; Thu, 28 Jul 2022 01:47:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376551.609409; Thu, 28 Jul 2022 01:47:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGscK-0005c3-RM; Thu, 28 Jul 2022 01:47:12 +0000 Received: by outflank-mailman (input) for mailman id 376551; Thu, 28 Jul 2022 01:47:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGscJ-0005bx-9i for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 01:47:11 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3030e8ce-0e17-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 03:47:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA629617A9; Thu, 28 Jul 2022 01:47:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0CF3C433C1; Thu, 28 Jul 2022 01:47:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3030e8ce-0e17-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658972826; bh=4BuM9UUBrMzehpctv26xVQjo1BpaMJnIU2W3i/gIt10=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=O8CzyyynWplGxjNpvy57PgQFR90c0XzxuCrm9rtX1WUozmXygsXP+IiU6SjYSAiPe 9IdU9p5ZcHzxziPuv2ov782sNt1hJm49QvNtjcBxKlSExc8BorVzNi4RnM5Imn8u2W L+I7b3LaTNhWA9mJF7+5aLIEeD++ygYA4osPRAsMvqL817Pe1Oo886PeV9FJbbycLi 9TmSFpcCiqXjiQKIfuISfqsEJKsvCNJPGzLnQ71WmbCZgOQvweyBRIb82Ar0w5K516 dHivqALP494Lm3nSrZ1shd/rda2Bkoz1MwmRw8RGV0LsXNtVgT/nK7B6X5dyMpbzod wPqAPMfvT75nQ== Date: Wed, 27 Jul 2022 18:47:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu In-Reply-To: <20220726190701.1048824-3-burzalodowa@gmail.com> Message-ID: References: <20220726190701.1048824-1-burzalodowa@gmail.com> <20220726190701.1048824-3-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Tue, 26 Jul 2022, Xenia Ragiadakou wrote: > Enable CONFIG_STATIC_MEMORY in the existing arm64 build. > > Create a new test job, called qemu-smoke-arm64-gcc-staticmem. > > Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a > new test variant. The test variant is determined based on the first argument > passed to the script. For testing static memory, the argument is 'static-mem'. > > The test configures DOM1 with a static memory region and adds a check in the > init script. > The check consists in comparing the contents of the /proc/device-tree > memory entry with the static memory range with which DOM1 was configured. > If the memory layout is correct, a message gets printed by DOM1. > > At the end of the qemu run, the script searches for the specific message > in the logs and fails if not found. > > Signed-off-by: Xenia Ragiadakou This looks good, I only have a couple of minor comments about code style and a small suggestion for improvements. > --- > > Changes in v2: > - enable CONFIG_STATIC_MEMORY for all arm64 builds > - use the existing qemu-smoke-arm64.sh with an argument passed for > distinguishing between tests, instead of creating a new script > - test does not rely on kernel logs but prints a message itself on success > - remove the part that enables custom configs for arm64 builds > - add comments > - adapt commit message > > automation/gitlab-ci/test.yaml | 18 +++++++++++ > automation/scripts/build | 8 +++++ > automation/scripts/qemu-smoke-arm64.sh | 42 ++++++++++++++++++++++++-- > 3 files changed, 65 insertions(+), 3 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 26bdbcc3ea..6f9f64a8da 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -80,6 +80,24 @@ qemu-smoke-arm64-gcc: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-staticmem: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - debian-unstable-gcc-arm64 > + - kernel-5.9.9-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > diff --git a/automation/scripts/build b/automation/scripts/build > index 21b3bc57c8..1941763315 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -18,6 +18,14 @@ else > make -j$(nproc) -C xen defconfig > fi > > +if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > + echo " > +CONFIG_EXPERT=y > +CONFIG_UNSUPPORTED=y > +CONFIG_STATIC_MEMORY=y" > xen/.config > + make -j$(nproc) -C xen olddefconfig > +fi I think we should do this within the not "${RANDCONFIG}" == "y" case above to avoid calling make defconfig needlessly. > + > # Save the config file before building because build failure causes the script > # to exit early -- bash is invoked with -e. > cp xen/.config xen-config > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 53086a5ac7..48513a7832 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -2,6 +2,15 @@ > > set -ex > > +test_variant=$1 > + > +if [[ "${test_variant}" == "static-mem" ]]; then > + # Memory range that is statically allocated to DOM1 > + domu_base="50000000" > + domu_size="10000000" > + passed="static-mem test passed" > +fi I think we should set passed to "BusyBox" for the regular case so that we don't need an if/else at the bottom to check for passed > # Install QEMU > export DEBIAN_FRONTENT=noninteractive > apt-get -qy update > @@ -42,8 +51,22 @@ echo "#!/bin/sh > > mount -t proc proc /proc > mount -t sysfs sysfs /sys > -mount -t devtmpfs devtmpfs /dev > -/bin/sh" > initrd/init > +mount -t devtmpfs devtmpfs /dev" > initrd/init > + > +if [[ "${test_variant}" == "static-mem" ]]; then > + # Verify that DOM1 booted with the expected memory layout by checking the > + # contents of the memory entry in /proc/device-tree. > + echo " > +current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) > +expected=\"$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size})\" This works but it is hard to read. I am suggesting the follow to improve readability: --- echo "#!/bin/sh mount -t proc proc /proc mount -t sysfs sysfs /sys mount -t devtmpfs devtmpfs /dev current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) expected=\"$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size})\" if [[ ${expected} == \"\${current}\" ]]; then echo \"${passed}\" fi " > initrd/init --- I know that it is going to be a couple of extra instructions on the non-static case to run inside QEMU but the advantage is that the init script is identical between the two cases which makes the code easier. > +if [[ ${expected} == \"\${current}\" ]]; then > + echo \"${passed}\" > +fi" >> initrd/init > +fi > + > +echo " > +/bin/sh" >> initrd/init Is this needed? > chmod +x initrd/init > cd initrd > find . | cpio --create --format='newc' | gzip > ../binaries/initrd > @@ -68,6 +91,12 @@ DOMU_MEM[0]="256" > LOAD_CMD="tftpb" > UBOOT_SOURCE="boot.source" > UBOOT_SCRIPT="boot.scr"' > binaries/config > + > +if [[ "${test_variant}" == "static-mem" ]]; then > + echo " > +DOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config please keep it on a single line for readability (even if it will push it above 80 chars): echo "DOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config > +fi > + > rm -rf imagebuilder > git clone https://gitlab.com/ViryaOS/imagebuilder > bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config > @@ -89,5 +118,12 @@ timeout -k 1 240 \ > -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial > > set -e > -(grep -q "^BusyBox" smoke.serial && grep -q "DOM1: BusyBox" smoke.serial) || exit 1 > +grep -q "^BusyBox" smoke.serial || exit 1 > + > +if [[ "${test_variant}" == "static-mem" ]]; then > + grep -q "DOM1: ${passed}" smoke.serial || exit 1 > +else > + grep -q "DOM1: BusyBox" smoke.serial || exit 1 > +fi No need for this if/else/fi if we set $passed in both cases at the top From xen-devel-bounces@lists.xenproject.org Thu Jul 28 02:45:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 02:45:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376557.609420 (Exim 4.92) (envelope-from ) id 1oGtWO-0004Uh-3S; Thu, 28 Jul 2022 02:45:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376557.609420; Thu, 28 Jul 2022 02:45:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGtWO-0004Ua-0T; Thu, 28 Jul 2022 02:45:08 +0000 Received: by outflank-mailman (input) for mailman id 376557; Thu, 28 Jul 2022 02:45:06 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGtWM-0004UU-Dx for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 02:45:06 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80089.outbound.protection.outlook.com [40.107.8.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47db2a6b-0e1f-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 04:45:03 +0200 (CEST) Received: from DB6P191CA0002.EURP191.PROD.OUTLOOK.COM (2603:10a6:6:28::12) by AM6PR08MB3639.eurprd08.prod.outlook.com (2603:10a6:20b:51::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Thu, 28 Jul 2022 02:45:00 +0000 Received: from DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:28:cafe::11) by DB6P191CA0002.outlook.office365.com (2603:10a6:6:28::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 02:45:00 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT015.mail.protection.outlook.com (100.127.142.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.17 via Frontend Transport; Thu, 28 Jul 2022 02:44:59 +0000 Received: ("Tessian outbound 73dd6a25223d:v123"); Thu, 28 Jul 2022 02:44:59 +0000 Received: from 121d2fc0c062.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 116B3332-6463-4F1C-A18A-CBF1943C4118.1; Thu, 28 Jul 2022 02:44:54 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 121d2fc0c062.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 02:44:54 +0000 Received: from AS8PR08MB7322.eurprd08.prod.outlook.com (2603:10a6:20b:441::18) by PR2PR08MB4779.eurprd08.prod.outlook.com (2603:10a6:101:1e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Thu, 28 Jul 2022 02:44:51 +0000 Received: from AS8PR08MB7322.eurprd08.prod.outlook.com ([fe80::913a:db53:869e:6f8a]) by AS8PR08MB7322.eurprd08.prod.outlook.com ([fe80::913a:db53:869e:6f8a%5]) with mapi id 15.20.5482.006; Thu, 28 Jul 2022 02:44:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47db2a6b-0e1f-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iYQEMQCHmUDj9Yyvr/K0bjzasMkRyOYd3n+lcvTYFb956wKuCfBdtWHQV0njVYWWIxpgu4wmGXpFW+moErvNlZDVRJyMRQzjjg+fKDmg+wHMo5GjunC0sAziSvLc9mu8+EtJugv4wmCY01v1RU5yXU1AszsWB7eH4F9ZOpXYlZo7y9Ph/162NCVbhuozp7uRndAJRfILNsgCClbpDsbDrKw1lkUB58pI/ggo8wsNbfVcBO99quX+gHz92LXajmQasIw7omumkmoC//3ctRIDBaGZE/eCGmgVbxIZD8Pmetf06S46orXvh6X1EvJcAROWtCo6OdPyqrHfkhb2jJlaDg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2zw1EPhTDzuVVdza3X2TteNN3V3EcL5T8D0q2uXB90=; b=m4i8qizd5nA6GH0iP6XoEGO8unuio1EOnW6jgRorijKbkt1oqWsdf+JjiwNPfPls/dXLpuUUyRskdfD+RgcaBH+Af3AJ3Fosn8cGex0LiIbQyvNju8uNinBU7uwADfSObiKoI2aDuKpWuLkycOSa8Z6qxN0MzssRAAJkCiUMq+uzEUTD+Wp9nV9iGd2O+q6I4UCSTSMUpqPrGusWIOlqW6ieqaTpThHZvCz/4hS8tIF3G1yRFJXnrKrnQWxuUbTJHamXV4a/luk4ExBZ+j38rkoBgu3/i5cEI5796oZaKVPmFCdQ0CoXmNpdhvbrf7mi3wkJ57qaXlGbVsFRGv7+XQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2zw1EPhTDzuVVdza3X2TteNN3V3EcL5T8D0q2uXB90=; b=1LcG9xg2l6h5LtP/mF+b0d8ldsa35AD+tQi7PSaKIV06AgOVDeUdAShGrhZaFUd2YYSXTLw/MVBnQr8gTRZlRN0wIn1XeiWIkCRpB7mJgrhQk0RCmtXTJ+RP/EhLLFVNOkEWZpt5PuHSU8jL4fJQxj9RJhrpj288BNxoqbFb4uI= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CUW7aBBgzkzU/vFRM+y5J0t7ivr4yPdV+oQMRdvX06yEncIBKwhm0lRGK6OLkTzJN5dKyWi8PoBTT5MaOzRvEvb8pRrobhQ6vdbu53g6C5EV/c6XITqTzakx6572CENe9iAPV1GH/uuoyTAImzbPkBIg5OqzDJMu2h9OPxbEjyGw90gxSCXzmOMA2C5lmM/Ba2AlIczqfI2rZT2tEu/U2okOd0twZRZ5LGMxkKiBQsRBI3M9P+SDXMWnihjKMQJv2ORhUaAninTfzeetQZbyiWj13UD08Qx8Dik+hXVJFwRFzexB7eIQ1sz1XPIw7b82lCLIb8pbMPa4BbwiQ9JSlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j2zw1EPhTDzuVVdza3X2TteNN3V3EcL5T8D0q2uXB90=; b=nV2f+XelH2lTZihm0ky4SysGt3+hQ+YY0oN3qL+qFKmjSwghbrOOcBnHVXXxv11f5vZAWXH3+U6Zc9Hd9KkKUuV6DxTQezrMinb5WPWgagyAZNDRwrGgY1wKxrhh9l4IAy4q/5oyAjSCsRKaSuHT/jK2bWe6AgeLg5BUfq11UNVUiuO2i/FOor7BRBwBL4+Puc2Kj1yBXGwcZqPbYRkUZnT4EaWJAsg9m35vfiyLXnVXKSYLYoS1p+jEsgQRKt9lq83E9deIMC6gl0QATIkcHfrEKfpzTSEBt2hx7J9cyeG47islBmjeodohaivetx3DVLk3qz97kfW1NM99r5SkhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j2zw1EPhTDzuVVdza3X2TteNN3V3EcL5T8D0q2uXB90=; b=1LcG9xg2l6h5LtP/mF+b0d8ldsa35AD+tQi7PSaKIV06AgOVDeUdAShGrhZaFUd2YYSXTLw/MVBnQr8gTRZlRN0wIn1XeiWIkCRpB7mJgrhQk0RCmtXTJ+RP/EhLLFVNOkEWZpt5PuHSU8jL4fJQxj9RJhrpj288BNxoqbFb4uI= From: Penny Zheng To: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" CC: Doug Goldstein , Stefano Stabellini Subject: RE: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Topic: [PATCH v2 2/2] automation: arm64: Create a test job for testing static allocation on qemu Thread-Index: AQHYoSMC2K2+YPID60uDh7r2pIYcLK2TFTgg Date: Thu, 28 Jul 2022 02:44:51 +0000 Message-ID: References: <20220726190701.1048824-1-burzalodowa@gmail.com> <20220726190701.1048824-3-burzalodowa@gmail.com> In-Reply-To: <20220726190701.1048824-3-burzalodowa@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: D3627F4B9637BB42AA8A3C15FC2D4EA3.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 663e599e-df94-47aa-fa91-08da70432a2a x-ms-traffictypediagnostic: PR2PR08MB4779:EE_|DBAEUR03FT015:EE_|AM6PR08MB3639:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: +OX4aEKPG57udGOF21U4ncYg4qY0Z/a/12qaAKPEXqnaoH0lx39NrLfokP6pp1/YuGghZjOzAZBi1V3mO1UtmQZL8l9dUpOGYFiWAMOP4JWzswlspdP/XYMwK45gO3kW3D7TiSWsJUuW+ut+U/bbZZ7YJB0r11o0Yg6rod74sXRkJtkwmhVFt+Uxr3JGFJJsrosr+H/NVaYBeZ2tmme2bZLs+oX7v5j7T6wNSjTscxuepaW02WzsAXyRMNAMfS2L4us75I3xjftw5wBHW7mCFrc5NXY9uCaudP3CBa9TSXGamsCstaZarh1bZk6kLbh6MApnLibd/lhjaz82WoGEyfvpuLf8dIVKtSYgMu3cxrR55zzuWsxKtQE1Smf0Li8kfyOcDKzOLygmCSbpcpX7fJqzwUMwq22wht/8vldo/F15C6UbAlZ+18atlCYsQKxh7AsdWVTpA/H9PksYdVcfA9EbUPrWVDuw+1OAcQwTNjr/CdjqGzTZHStWuGOBwKGFuhcXG54i2ZEkBicfq02lrXYY0lmm8UY6itLiQFmGba4uuVPMhc4Z3f/YALrn9exCq9+IuL0QN6oVhLjvsuygoaic931CWf5tFRoi0876rgBkyClHIHkURlAqGhTSrk6fUsOS4cxPrHjbxnuzy7gHsGr5rbsPW8uu9WKgsnrUCC1vBhsNXe3HeMojNYrFHJgPzazcEHT+aVPtXxAOlINMaHR5fj+ailHMC+yzt+cWesM/aOxJ3ApEjGTX5p1zerlGozTDznc9GfZpKCAZ2/JGDn/bfnAaqQ8T4e4kDPxBALhi5bEv+Mgh+CdYgW65MaDQ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7322.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(366004)(376002)(346002)(39860400002)(396003)(55016003)(53546011)(26005)(38100700002)(478600001)(86362001)(6506007)(7696005)(9686003)(66476007)(41300700001)(71200400001)(2906002)(122000001)(38070700005)(52536014)(83380400001)(8936002)(54906003)(4326008)(316002)(8676002)(66556008)(66446008)(110136005)(64756008)(186003)(5660300002)(76116006)(66946007)(33656002);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4779 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 63691bbc-562f-4590-8fc3-08da70432503 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CZ7F+/O3aIB2N2Olm6xC1Q9x2fO9tWeSPyG7LOViavo7kV10UqcUKbsIpT/B3QVFDQaxonSGg4FQeQc9W0IEtqk1OkwcKIbjyQBS1LpcsJZDXx6EBiFU4HPLBukkkLbgdc1uZvi6LTLcmM9+w7bqVhmkit4S1bldVvPPC66dIwWhgxAkLRBcpoS/IRnBlGJtG/4Ek3nN/DY13p/wPvzq2fzeHO8JhVutfv0XOtqXYbx5CP4jla6vpvHAdFdTi56pal24YUrs6l3uMx9G2/CfYJallLqHXm3vyekvTYIniW2eeno8PZV0/oM3yWTZEimLUzgIpNqVcP45zvMXO5bhbn/AYXF459e6VgqJhxxUsVqeZaN0N7zFEyfXPL7fBZ6FAlOnTJdc6fVVYQYmokxH+quYhtl7UZIh9NlRWumCO0nLuJBF1m3dT/T7Kc22AQyaJftd09BlJajh1hF5PjL/OnfglNVNAmUqiCmMMXTcnxnSo8SPqxfzGZLmOmpAl2BaewXlKutUNzK3O+su+NR8yT/wzPn0iuHhTfwEikLbdTWh7PlivN5twP3Fe7sAshZs9Mfy4KVVUWzgnjQpQF7ydH7wlqsQDNqSES0BCh60F4NnPscW5MbpWA2q3ZlLbFHOl9K+uVrQulPwN0yyKHQLdlVYITFTqfl7+44BRCehKEKFwiXZtTq2yj5PrqGGKhTgzUEnAOayVpTTYSlvKQxo1i/5qDjSNHsvDJg/hswlW5HEqr/u6A0zsXX7MVdi8YSqJKxkA51SDHHs+TwnbToBHvbsDK2hBb1L8VTU84PIxnXES+wL9nbl8CYIl7Ip17yL X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(136003)(396003)(346002)(36840700001)(40470700004)(46966006)(55016003)(316002)(52536014)(40480700001)(36860700001)(5660300002)(33656002)(53546011)(82740400003)(4326008)(82310400005)(70206006)(70586007)(356005)(2906002)(81166007)(336012)(8936002)(186003)(8676002)(54906003)(107886003)(26005)(86362001)(40460700003)(110136005)(6506007)(47076005)(41300700001)(7696005)(83380400001)(9686003)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 02:44:59.8925 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 663e599e-df94-47aa-fa91-08da70432a2a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT015.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3639 Hi Xenia > -----Original Message----- > From: Xen-devel On Behalf Of > Xenia Ragiadakou > Sent: Wednesday, July 27, 2022 3:07 AM > To: xen-devel@lists.xenproject.org > Cc: Doug Goldstein ; Stefano Stabellini > > Subject: [PATCH v2 2/2] automation: arm64: Create a test job for testing > static allocation on qemu >=20 > Enable CONFIG_STATIC_MEMORY in the existing arm64 build. >=20 > Create a new test job, called qemu-smoke-arm64-gcc-staticmem. >=20 > Adjust qemu-smoke-arm64.sh script to accomodate the static memory test > as a new test variant. The test variant is determined based on the first > argument passed to the script. For testing static memory, the argument is > 'static-mem'. >=20 > The test configures DOM1 with a static memory region and adds a check in > the init script. > The check consists in comparing the contents of the /proc/device-tree > memory entry with the static memory range with which DOM1 was > configured. > If the memory layout is correct, a message gets printed by DOM1. >=20 > At the end of the qemu run, the script searches for the specific message = in > the logs and fails if not found. >=20 > Signed-off-by: Xenia Ragiadakou Reviewed-by: Penny Zheng > --- >=20 > Changes in v2: > - enable CONFIG_STATIC_MEMORY for all arm64 builds > - use the existing qemu-smoke-arm64.sh with an argument passed for > distinguishing between tests, instead of creating a new script > - test does not rely on kernel logs but prints a message itself on succes= s > - remove the part that enables custom configs for arm64 builds > - add comments > - adapt commit message >=20 > automation/gitlab-ci/test.yaml | 18 +++++++++++ > automation/scripts/build | 8 +++++ > automation/scripts/qemu-smoke-arm64.sh | 42 > ++++++++++++++++++++++++-- > 3 files changed, 65 insertions(+), 3 deletions(-) >=20 >=20 --- Cheers, Penny Zheng From xen-devel-bounces@lists.xenproject.org Thu Jul 28 03:43:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 03:43:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376564.609431 (Exim 4.92) (envelope-from ) id 1oGuQQ-0003B2-Do; Thu, 28 Jul 2022 03:43:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376564.609431; Thu, 28 Jul 2022 03:43:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuQQ-0003Av-AB; Thu, 28 Jul 2022 03:43:02 +0000 Received: by outflank-mailman (input) for mailman id 376564; Thu, 28 Jul 2022 03:43:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuQP-0003Al-Nk; Thu, 28 Jul 2022 03:43:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuQP-00060w-LB; Thu, 28 Jul 2022 03:43:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuQO-0003GE-VU; Thu, 28 Jul 2022 03:43:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGuQO-0004dk-Un; Thu, 28 Jul 2022 03:43:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=38MWIl5LtrUnuu+WPAk3cMvlZ38wmbKxLTgM25JRRoc=; b=Bs605gwA9/pe+KR5h920mFWW/a EiqAGj2TxqjbBx7sIvep7BpQtssshIg9/A2wxM9rjbN9Jvaruqragizlir1+hKouY5YLatXeHJwrf 14p11vvJ2JmFAx8XfG/W5Pqtf/ruCVr5cqATeTyvfIEEVhe4OuI62cDtHfr6r4q/afWc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171892: all pass - PUSHED X-Osstest-Versions-This: ovmf=1774a44ad91d01294bace32b0060ce26da2f0140 X-Osstest-Versions-That: ovmf=f26b70cb9f1367ceb25190ba2777631ee42c69fe From: osstest service owner Date: Thu, 28 Jul 2022 03:43:00 +0000 flight 171892 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171892/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 1774a44ad91d01294bace32b0060ce26da2f0140 baseline version: ovmf f26b70cb9f1367ceb25190ba2777631ee42c69fe Last test of basis 171889 2022-07-27 21:13:18 Z 0 days Testing same since 171892 2022-07-28 00:43:04 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Ard Biesheuvel Michael D Kinney jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git f26b70cb9f..1774a44ad9 1774a44ad91d01294bace32b0060ce26da2f0140 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 28 03:57:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 03:57:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376575.609442 (Exim 4.92) (envelope-from ) id 1oGuds-00059l-Qn; Thu, 28 Jul 2022 03:56:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376575.609442; Thu, 28 Jul 2022 03:56:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuds-00059e-NW; Thu, 28 Jul 2022 03:56:56 +0000 Received: by outflank-mailman (input) for mailman id 376575; Thu, 28 Jul 2022 03:56:56 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuds-00059U-6e; Thu, 28 Jul 2022 03:56:56 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuds-0006H7-4F; Thu, 28 Jul 2022 03:56:56 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGudr-0003eH-PX; Thu, 28 Jul 2022 03:56:55 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGudr-0002NO-P4; Thu, 28 Jul 2022 03:56:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XY0DpkGmakg3ilBCpqZ8XmlH/9cJUWJKC33Q/hxDqM0=; b=TNlG2mtwE1Xqq0Az1viFZL8RNY ANbyd8tj7huJqIrIxtVsHTwPqhwtm6gOopKepPeoT8Rkf7odjM0QV6n1IkYjFtY+79No1EbTlMYZz GuzunCqGw3qbyDZXvzyF5l2JpZWw0aNB3BQBWBwulmK4aMttYzPDRuGYDvT18aRa12t4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171885: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-libvirt-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=7b17a1a841fc2336eba53afade9cadb14bd3dd9a X-Osstest-Versions-That: qemuu=f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d From: osstest service owner Date: Thu, 28 Jul 2022 03:56:55 +0000 flight 171885 qemu-mainline real [real] flight 171893 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171885/ http://logs.test-lab.xenproject.org/osstest/logs/171893/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-libvirt-vhd 19 guest-start/debian.repeat fail pass in 171893-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171872 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171872 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171872 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171872 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171872 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171872 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171872 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171872 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 7b17a1a841fc2336eba53afade9cadb14bd3dd9a baseline version: qemuu f6cce6bcb2ef959cdd4da0e368f7c72045f21d6d Last test of basis 171872 2022-07-26 19:07:49 Z 1 days Testing same since 171885 2022-07-27 12:04:19 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Dr. David Alan Gilbert Igor Mammedov Jean-Philippe Brucker Joao Martins Jonathan Cameron Michael S. Tsirkin Richard Henderson Robert Hoo Tina Zhang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd fail test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git f6cce6bcb2..7b17a1a841 7b17a1a841fc2336eba53afade9cadb14bd3dd9a -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 28 04:07:59 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 04:07:59 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376262.609452 (Exim 4.92) (envelope-from ) id 1oGuoJ-0006tQ-QL; Thu, 28 Jul 2022 04:07:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376262.609452; Thu, 28 Jul 2022 04:07:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGuoJ-0006tJ-NP; Thu, 28 Jul 2022 04:07:43 +0000 Received: by outflank-mailman (input) for mailman id 376262; Wed, 27 Jul 2022 15:21:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGir5-0007ln-NN for xen-devel@lists.xenproject.org; Wed, 27 Jul 2022 15:21:47 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2093.outbound.protection.outlook.com [40.107.93.93]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d2835a5c-0dbf-11ed-bd2d-47488cf2e6aa; Wed, 27 Jul 2022 17:21:45 +0200 (CEST) Received: from CH2PR22MB1926.namprd22.prod.outlook.com (2603:10b6:610:5f::21) by CY4PR2201MB1111.namprd22.prod.outlook.com (2603:10b6:910:49::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.23; Wed, 27 Jul 2022 15:21:39 +0000 Received: from CH2PR22MB1926.namprd22.prod.outlook.com ([fe80::d0ab:e499:78b1:6e87]) by CH2PR22MB1926.namprd22.prod.outlook.com ([fe80::d0ab:e499:78b1:6e87%3]) with mapi id 15.20.5458.025; Wed, 27 Jul 2022 15:21:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d2835a5c-0dbf-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iImqCGDk7AoSLWQnXV9FzrfCCK7Rxxwd/8mXmjf0C3K92lBoUG6rFoa7IFWzp+XnrFAcGYR9/u1X3EGJS0wLRKBEthAk6fd6CWPAJSbdy+jLHcLWlB/KX3mZ6JnrdahTTzatAimSKDGvQ946ckwaE74Z4fedi1b0ZlRBrTRnkVvO5IBGtGzTWvI5P/q+7xnv/dxCDAcSJ3fMr/0S0h9P8LfsM3qKCpmdxc7lYVSv93XcPcHWRCzXYmb5j/+mMpiICIhrf/CHhKEZXpHjZOwTpaKyq1El7k2MDbTGrEduD5R38G3Udo1hvMjQaawPY8ePxlGF4i1Cm7zhLbgc8UuuJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lQSEppn7nPi0ogDwjER+B1GKslGgEmav8cGFc6aJF4k=; b=dSCPtpT2UqA716AyWA2J2oVNx+t/IzW/zNMhP2kUB9FIA8S2SGlgdFUj30rwqcA/X1Avu6whxdlVOVPrY5yR6VlZ73MrIqF8t+MQ4243DNt4B3321RO+hnKJ+0P9UZ4SZHRvPcx8k6L4nerD+CvFtinB+Q6nqJWsV3TyXbfXCRxboBYLGmUUn0AJP+SSrL59bhWbPV+GcXc4VP+Msd3+zBzHCSHVCi14vJkhtaW/H/UVwd3wwW0n1trn+QyNEucsTJszXOcRKDd16f4eSuXdgbwT2d5yXcgo28TQ+3SqvtwdyZ2JxGSioFrpvwObWOwnDcg7FsmslClY5YJYuNljYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=purdue.edu; dmarc=pass action=none header.from=purdue.edu; dkim=pass header.d=purdue.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purdue0.onmicrosoft.com; s=selector2-purdue0-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lQSEppn7nPi0ogDwjER+B1GKslGgEmav8cGFc6aJF4k=; b=OQd8LV5LdczRhImp/8MVYjDLK3Wc9Oo/iy2WMIndxADr+bmCwGUTrNdOVcfkx9TL8fFfVXf7xHBXe1Onns+CZM1XYL/egyXQ1X095q2sx6DDLo6tZ/ROr5pqRAv3/46XCbixJ54vaCoymIRXP1ZwHQYIvBR9rONDYcmxKAZiRuY= From: Jason Shuhua Lei To: "Smith, Jackson" , Stefano Stabellini CC: Xen-devel Subject: RE: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Topic: [IMAGEBUILDER PATCH] uboot-script-gen: allow fit generation with no dom0 kernel Thread-Index: AdigP3XkakTWEwukTeurpU94cGpQzABDr/uAAB0Pf2AAAb+csA== Date: Wed, 27 Jul 2022 15:21:39 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=purdue.edu; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 801d349a-f803-4616-232c-08da6fe3b3db x-ms-traffictypediagnostic: CY4PR2201MB1111:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SJOdA2P2a2KenvEKlkypHPmvfz9DEECpDfnpOM4M4PUT7sohpgyGpeXkuLE26WXKAqeO0Ua9w+IJwkwniIOKZR8OQcKOaFOzkU+uL/7iU1O+Ts7R0iKq/F9q4uXf0aVAv0RXqthElFQ5YANlPs2nzGKb0JzZLqX3Py6EKIsJecasNymeawpQllhfiJP/M4I7iU5+sn1ylgUSoOWUavCS32PHh6vZ8Bj7TF0LFe6MYWONDd+qePmi+3ABZ4TEiZnhsdSjf51WR56Qyo3t6tUyOUOdDmIT9GEoXwsDh0UjTqYOIVlnz3SXCyzVPjf+Hn8lhUmlTInF+vgfN0zQK+HZHqnLjiaARaBOadmzs9FisLuCJZYhVoiMTkrW+GNQ7cR4e0HV+6b1KPDUpx3Cs2LAkZVsiWQ08oQbDybdtN6Kco2QJB52yvVcHdmUmFM8ImWWG31KY0LNDRHPWigE7C8hVXhLACbF4CKuctuILfh2ZFvAPn27Fd0sH0iI2wg1BbxJOxCwn5hmFVMu11CdlaDaw6cjr13BQILvglt2cAFAu46vhPqZklVaVa8BvK0ent/1ALczNmSuWdheKQqeimq8awzUs4x/ownxc7+6ljTWEIkqmgAnx75DCWMN5cp1eSYNIiTQY2AAzuYzrt0hRzeN5eA9oQ0BEuFnKPHwbWt3x/j6kSe2ahKdVMdgZWn0fzwi20OJwszVqQ9zKp5zz6JNW00K6F/Anf2LxcZv+yklpmwvtm3JYx/RQfZGP74CbIuOYFaY9LWqQXGU0U4hDJk0bJD3lVOrEAgSgLA3Wj4+6EbFp2PVHQQY2DkIWw4LhdMl3obZOYJsPGvrTgJ44Bh2vg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CH2PR22MB1926.namprd22.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(366004)(39860400002)(346002)(136003)(396003)(376002)(75432002)(41320700001)(316002)(41300700001)(83380400001)(55016003)(9686003)(38100700002)(6506007)(66556008)(71200400001)(38070700005)(26005)(64756008)(110136005)(122000001)(186003)(66946007)(4326008)(66476007)(66446008)(478600001)(8676002)(52536014)(8936002)(2906002)(786003)(966005)(7696005)(33656002)(86362001)(76116006)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VKP6ucwY0NBlxoJhtmYE2I0/1ePDx2chZEo+9Jc6JmAfLGWin8I+as4XGmUq?= =?us-ascii?Q?S3INAYWyAwgpHlfJNwYpuZ9L6EsRY4fdWm6CTLLB5YsNQGXVsrXJ1GrSnrM7?= =?us-ascii?Q?deD1bbu0i3LZC3RzPWHC+KF1wREUX+ONLPKjICdUgeforDn45J2NJR7Eb77R?= =?us-ascii?Q?ufy8bGJogVHK4r2vQRpSUvW0jF2w1BwkWe4DifaC+ktEFFWo0AOv3DiJToFx?= =?us-ascii?Q?7bDsPRr8aeKsuH0/R41oSxVHafAdGtnpV3IlLjaYHJIzGENt2Kel5oeVokBa?= =?us-ascii?Q?tzxnEj4YIWQ5Mpp0GNKuDWAMO5hEszrFMTKdtsJbkKWpaeIPzEDl5ly35tH0?= =?us-ascii?Q?qupa6Eav4ChRz7cU6NP8pnrplytdETkn+HwlAxkdwzsSAY09sFh2Na/SN+Z9?= =?us-ascii?Q?KDWRWdVKAd/Z+dHDP56HNeI0DH2iItRiyQb98ZKan9vX2Y/seePVnW+Vjee6?= =?us-ascii?Q?OvXRVb16i40vrrFhOqGQuUr8wohhYNfhaP4pzsqazwluaVLyKnlB/RSItQ6K?= =?us-ascii?Q?RhlvG6oy5zLyP026sZ1dB//S8IOFdtTF4rLI0tiuiDGytbVjq164Hc6xr7jV?= =?us-ascii?Q?M8BEJ1JggrjwpX8jH9YPuxQ+OTtVlHPLU+0ZwWUhoYiK5Jex27bUJd+HYFco?= =?us-ascii?Q?zhpqU0cxuipTyaWJP6j+jDieUJBololkqt7II1EEDfu+gzbZamsq7oPiwFV6?= =?us-ascii?Q?d7QtDREu4xmjumMc9taeyeIu5HYO1+zd3y8Yi6lefT/TK3RlnD2Ke8Wotz/u?= =?us-ascii?Q?tgXJDJjiIaclIG4azTTzqTD9svQQI5X+1cJR8X9EZdIkO5nkjLLxLkrHqA0q?= =?us-ascii?Q?u3JR8CGKy4CjmAlPag2hi9WcrKKmPCPiZKlBAb2GQnYjbJexkH0LizhNsnfP?= =?us-ascii?Q?SB23ISiBWkTRtSaEYZfYF0DZtliOjtu2VUEW1IrrHJGiIodDo4tf7zO8lKme?= =?us-ascii?Q?vaztud4cwNCi7J5JfvYYKXo32nM7/MvLeglMGxYYrjW5DUDD7io4qq6DrRiE?= =?us-ascii?Q?opUbbWyr4Kuavf8dMvtpsASaJ97eYzqXtUZMgCcK1uKEgvloLg/5SNsJmOKl?= =?us-ascii?Q?bPiusdZUkhLOMEZhRbV1syMa18HmZPA7KffbGm1qyRHR5JAWCibHeh4ATcLU?= =?us-ascii?Q?AMUeb7rMX09uY50JvBIAie6KKxtlmR8APERyq6irLZE5zGqdeghRDmOeblzj?= =?us-ascii?Q?WD3boKQpzkSyw89v0GOvO1/42z7YU6wqq35Pao6Wac9Wfo8TOm6Lja8eEYR4?= =?us-ascii?Q?9pVAslFTCQXYgzjIEsnsO83pE/LvRNLmS5/k1QzH77LicRc6qpLBMJJDeVrT?= =?us-ascii?Q?8fp0DZFbETFQcY0yOyN/2uvhSAz5YwBzjeVFNbV1h8coh+MLeWRSoDpbmOsn?= =?us-ascii?Q?B5sKlqVgSbMQFLiH+ljm1AqWwURLpZOma+fSU7qNBsRs9IMrdMXidbYFykQN?= =?us-ascii?Q?HSo2pkyKXYbyw9GAYFXGYhPdrRhGBJ1f4R1P3pkYTcbG14AiT3+KCzwyxsOZ?= =?us-ascii?Q?Cp//78uiCvB9wpoNARTh/BrQRtTQpsuWxzhhIS+xIpk4gIQdJ1EnMoC/UVuh?= =?us-ascii?Q?LdXtwbmrwd1K2p0ahbo=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: purdue.edu X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CH2PR22MB1926.namprd22.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 801d349a-f803-4616-232c-08da6fe3b3db X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 15:21:39.1607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4130bd39-7c53-419c-b1e5-8758d6d63f21 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: drM1ELMd09aHvIDgrUvrNqpwl0Y4uLnNjL8GrlrmH/kM5niF/LVtLrbZ75VWrZ9Nxjya7v8fv7vGq+Tcj80aUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR2201MB1111 Hello, > -----Original Message----- > From: Smith, Jackson >=20 > > -----Original Message----- > > From: Stefano Stabellini > > > > On Mon, 25 Jul 2022, Smith, Jackson wrote: > > > Hi Stefano, > > > > > > My colleague Jason Lei and I would like to submit a patch to imagebui= lder. > > > > > > It seems that generating a .fit with a true dom0less configuration > > > fails > > because an extraneous comma is included in the its file. > > > > > > We believe this change resolves the issue. > > > > Hi Jackson, thanks for your contribution! > > > > Yes, I see the problem: the code assumes there is a dom0 kernel. If > > there is no > > dom0 kernel then load_files will be wrongly starting with a "," > > > > I would be happy to commit your patch. I assume I can add your > > Signed-off-by to it, right? >=20 > Yes, that is fine. Could you also add Jason, as he worked this out initia= lly? > I've added him to the message so he can give his ok. >=20 Yes, I would like to be signed off on the patch as well using this email. Thanks, Jason Lei > > > > Signed-off-by: Jackson Smith > > > > Signed-off-by is the "Developer Certificate of Origin" which means: > > https://developercertificate.org/ > > > > > > > > > > > > Remove extraneous comma in generated its file when no DOM0_KERNEL > is > > specified. > > > > > > diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen > > > index 8f08cd6..6f94fce 100755 > > > --- a/scripts/uboot-script-gen > > > +++ b/scripts/uboot-script-gen > > > @@ -676,7 +676,12 @@ create_its_file_xen() > > > i=3D$(( $i + 1 )) > > > continue > > > fi > > > - load_files+=3D", \"domU${i}_kernel\"" > > > + if test -z "$load_files" > > > + then > > > + load_files+=3D"\"domU${i}_kernel\"" > > > + else > > > + load_files+=3D", \"domU${i}_kernel\"" > > > + fi > > > cat >> "$its_file" <<- EOF > > > domU${i}_kernel { > > > description =3D "domU${i} kernel binary"; > > > > > > From xen-devel-bounces@lists.xenproject.org Thu Jul 28 06:02:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 06:02:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376594.609464 (Exim 4.92) (envelope-from ) id 1oGwbV-0003n1-8g; Thu, 28 Jul 2022 06:02:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376594.609464; Thu, 28 Jul 2022 06:02:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwbV-0003mu-5d; Thu, 28 Jul 2022 06:02:37 +0000 Received: by outflank-mailman (input) for mailman id 376594; Thu, 28 Jul 2022 06:02:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwbT-0003mk-DS; Thu, 28 Jul 2022 06:02:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwbT-0000fp-BZ; Thu, 28 Jul 2022 06:02:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwbS-0006uK-SM; Thu, 28 Jul 2022 06:02:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGwbS-0003mI-Rs; Thu, 28 Jul 2022 06:02:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ru04v/J9dAtXyQ/foJjDJNCmpeRukly8568107o2Xjs=; b=xgWEIfmW22lblAXr37FEu8glZ/ KX908S4wnWipFr4BXGWJDMpTEXh8jYEJvs8Pk8Mm09fNY3B+u9c9Ui9ksX4vqxjFlUl0wg4xZExx2 LLF8bGhhWnobZGYBn/JifiDgYR0KQfycHYmqGzAVGWSlpxXUFzgrzmFUrptFPXUGlb8o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171894: all pass - PUSHED X-Osstest-Versions-This: ovmf=0e7add1d75fc75762208af84579e6809589ea6e5 X-Osstest-Versions-That: ovmf=1774a44ad91d01294bace32b0060ce26da2f0140 From: osstest service owner Date: Thu, 28 Jul 2022 06:02:34 +0000 flight 171894 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171894/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0e7add1d75fc75762208af84579e6809589ea6e5 baseline version: ovmf 1774a44ad91d01294bace32b0060ce26da2f0140 Last test of basis 171892 2022-07-28 00:43:04 Z 0 days Testing same since 171894 2022-07-28 03:43:30 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Anthony PERARD Ard Biesheuvel jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 1774a44ad9..0e7add1d75 0e7add1d75fc75762208af84579e6809589ea6e5 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 28 06:13:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 06:13:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376602.609474 (Exim 4.92) (envelope-from ) id 1oGwla-0005R7-8O; Thu, 28 Jul 2022 06:13:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376602.609474; Thu, 28 Jul 2022 06:13:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwla-0005R0-5O; Thu, 28 Jul 2022 06:13:02 +0000 Received: by outflank-mailman (input) for mailman id 376602; Thu, 28 Jul 2022 06:13:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwlY-0005Qu-JZ for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 06:13:00 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2084.outbound.protection.outlook.com [40.107.21.84]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 541b254a-0e3c-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 08:12:59 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM9PR04MB8697.eurprd04.prod.outlook.com (2603:10a6:20b:43c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 06:12:57 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Thu, 28 Jul 2022 06:12:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 541b254a-0e3c-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l/QgJEYr8EsTlhLze2ApEbO0ZMevwFBZoYV6rCnM2G8Al+j0gAayo/UCHTG9XtElurSuh1oQCsPXX5uEvIlhsforlynGlbEHrWsOA/fsSq8g51u9AUIKtsj+toyTQR7SRrdKKQ7yxFWacTyMjadGaz5DQQp/8gi4ZTAABxsL0hLvPTzQUJpXYEBt8gVcgESVrwxveAJPSbxhwk1kOIV6WaqNlTsiuJ81BoHFmtQlncXUJ0H8hmRhF40zZ/9qU2ZBj45tvYQJeAjMyAWjau1k3h0LhjoosT0Awa7BnKfHEpxOHGOjGSmemVOr6wDRoz2yq8+7cQonsECOFChvADMXJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GEtgO99dbcglkKouCHuwMDT3wwTwuScGtyOxb3zIuPU=; b=aHnheZj71Z6lsuJRaJhM0dRZs6CWCFZo9Ra6QvcTggd6gMm36IizmpnWjdp7Bavto1le49vhBUx/BWJgD/bI2RgasA2wNqBedfL05Wl5Zk6wtjJ8X4nQxsZ05wna0WzqY4T16GG2uzZT5vXBMV0ALLWDNgbe3xvdx7ha+hGU3zcGYhhCEj/tPsVbB/B4/bSFM8T6c4jlyYYtEVb1NeN6NZ5jrJ+9Y88+mm7PZjgF1L/qkiyga90AN1avHh3FD1H9vmYQSAkst2O+hMWVAoreI5wqY95y6QdFQUHViHOS7+K0usgU9/3i+2Mskf3J5yiAtyuSj2usMFh3pUpd/IQyww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GEtgO99dbcglkKouCHuwMDT3wwTwuScGtyOxb3zIuPU=; b=Co7A0zVpDitackqq1oa1fcF5vvC6aGF1NHDTTPHLMe2+7J2jtkaO+FP4SDEVOa+S64B1rJcB5Y9LqsjjWn4CyjuCydcnowPBuybCwSEvdDO1b5Vq7axI0OkXm/t/pcSgsrcUjUXll/nU++zUxKIyWEnCtqFLfpGJ6RVkC8zLUd1wJxQ5lXp/1jYSJFJsBQ1nZ5sKDt2YcYu3D+s+3WHiPbh9rwEOozeLXcvpfcZVat/uh6ckIpaO14eClKbQTtWoB3jiru0J1uxf4MOoqeuEr/2VJInM7UBrallL3AwrOOB14YQs1zS1R9f12pSKa2OYtzyTEECEMsBshkYpubOxHQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <634c9f20-0a0a-fa8d-7b22-04791dc90a8c@suse.com> Date: Thu, 28 Jul 2022 08:12:55 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] x86/shadow: properly handle get_page() failing Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <6c5b5339-f645-4214-bc53-2b7ead004367@citrix.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0107.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a8::20) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8a6c37a9-74c1-4d7b-de2d-08da70603703 X-MS-TrafficTypeDiagnostic: AM9PR04MB8697:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UICoo9A5Py6XZafMyLdil75h8D5m8Jpm7xAe4iRAS0RCn1OaAr+VDKncDPu+LIyZ+Z0OvB5VlBajFbobM6owe2cLBT+UQq1XsluO71ATs3yYvOGQY5OpKlZxpnZGaWIDip4sr5OSK3SyT79Q5t7MNbSbvnaD/BXDdRa6J24ogB++furJXTYSQgqaNb2iIUD8upn/Q0/j4Bofm5dXcaLWUJCBXG30nOoxv3madY+Z6AZz/qFtfYB1SRUWMh5AXzgBxixS43DbOVsbVgCDCn+z0K7QoGblDwX1Q+wMeIYu2pSu/w80gr4pFV2zOaaBr/gLKCzB6J8Fq4kOR3GTY4vyh+xXyu5YTjenBJsClCSwT/2sSRnnnUF0DNbayAxoiWxJ4B8AB2TiPhwapP0M3xbuU/HDc3jMnZnJ0owuEWeDiJhmSv0Ivc7YSifjXaWaNzdPhYA619590yvw0XQlJHsK94f5AcgeHNkKT+uASlzGVc5oEIOsjzwmgb8FPH/pTreRXnQYRyWVGNXOCpZQ/92XAUqa8TIs3OA0crj4NNkUxXZf0qFdhz/4wqmCcQkP1Lv+fq1kzkfPhJBNBANY5+r93Dh2A9fuoMSPDnD8iI3ctYt3rgro52DuXMpKpeX/YMLn6WZz3nUjER4O3dxYDDPAQw11N9+/nIPm+T95PdKieVNxzUX8phuCYOSFUUxQInlawO2R5XAIuLN8qtNqWsfeYN0IKGmIYMnnFUyqjCrjDXrFH9J4+o2GCjwpdAV2q+HHtA0YAx2bUwobkhpncYodt3wG0ZYLKYJUNZk34WNQ0sT5QGebfTYwNZegM0ekQJzordhfd2iQEFI5bUj5zRGaGw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(346002)(376002)(39860400002)(136003)(86362001)(2616005)(6486002)(6506007)(6512007)(26005)(53546011)(38100700002)(31696002)(478600001)(5660300002)(83380400001)(41300700001)(36756003)(8676002)(316002)(8936002)(186003)(6916009)(54906003)(66946007)(31686004)(66556008)(66476007)(2906002)(4326008)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U1NKanpMQkl6eTJOZHBaaDJjNk13d3JXTk9JQWIzWG1WNjFDMnpWanpBRHZt?= =?utf-8?B?SGx3NDFLc21XZjNWMVpXek5qbWZOL3kwOTBZcDZzK0trNUEvSEtNd3ZvaHph?= =?utf-8?B?RitSQ3BuWXpPOXQvelZwbWJwRmN1T1NtZUNESzVqc3J3RkdlenZRK3d3U0Nn?= =?utf-8?B?Z0tqOC9oejA0eHpZbG9LMUxRcFQ0TyttdjNiZUIrSlk5TlpHWDhGZjJzNXoy?= =?utf-8?B?UFRobXp0cDdZSDBwYkRLZUgxYy9rVEw5ODdqelZ4bXovTVZLeExST2VBRzZE?= =?utf-8?B?ZjhiaHVnTHpSVTlTaUx2OGUyL01mMGFld3R5Y1RHWHUwcGFuNE8rV1BsamUv?= =?utf-8?B?NUpYWG9UcTE3UHRXZlIxTVZLVllFNWdvWFNkNUxidUdLY3cyRjgrSk9hZjBt?= =?utf-8?B?dHpQdE1iOUNhOGkvdGkrNW5BTHE3bnVQdWM2djZGMnFyRFJiemhsOXIyL3VF?= =?utf-8?B?MjNOYTNBM08yRGJnUGlvYy93SmZWakRKUjltbTJ2c0l1bC9Scjhwcnk0RFV0?= =?utf-8?B?L3QwbUl5RG5xQTBHUkRKRXQvSllMQ0hIZkkyWFdZd2xZZU9tYUJQNDdmWGVy?= =?utf-8?B?U1pBTEx4bDBnam5jYnBVcHNTdmd1eHF4bVB4TmpZQjZSMytlQnp1N3RyZjl1?= =?utf-8?B?ZmE1YVVPWGgzNXlueWo0UFJkNnMxVFdyWndjSDFhczYrWVJJKzBhWGpudW45?= =?utf-8?B?MjY5dTVvZlVYbmFQZHZ1aGtXS0RrYVUrRG9hdmlSWVlMQlI3U1hSYkJUbklE?= =?utf-8?B?dWR0SnhzRVI1bldZZjlRRms1djNxRkI3UUV6WUZUNk1QQXViNnpRNVV4VEli?= =?utf-8?B?ejM4VUFoNUlLNXM5V3lTVjJCM3A0aGdnM29uRVorTkZDN1VWU1RpZk5OMWI0?= =?utf-8?B?cHViU2ZBazdEM1JZTVlhUDdiVlQ5am1hSThDUndrRFdWRGc5dFVIbVQwNnQz?= =?utf-8?B?Uk42US9TMVpSTGlTZkxBd0ZCeGwwS1cwSDBUTGZibit2WVhvV0hLTkpnK0Vt?= =?utf-8?B?bG5MSlVUMHlYcGF3NkxyWFphQXp5SVRRcHFkL0pqMU9tUmNUb3NrQmxqdjRW?= =?utf-8?B?ZGhoZ2sxR0JkSGtrNXJBZGhHZEtBcC9idlY5SzJJV0hMakNidzJDRWlpZDly?= =?utf-8?B?TkZVOFcrTm5JMzZZcWhhUEthcjJpYnNObU83NFJIcDFzTDRvYVIwUGpEYWJj?= =?utf-8?B?bURLSjNwdnJ1Rm90dTdCQ3I3MEwzTmU0ZGU0LzJ6YXhJbDN1Q0I4QXNhY2Ja?= =?utf-8?B?NUpLN0prenEzYnZZOUNlRzJVZWRuWlU2MERSY0ovSDdDZzdPTkt2SnJHTFBV?= =?utf-8?B?c3R6alMveGozOVBYWGUyQ1FFd1E4Wi9OcTdZZFl5aTBlN3BLK3lzMzJBYmFP?= =?utf-8?B?MTducnlaZHE5bXk2Szhmc0JGbDhzK0JsdkRrcW03MGYwbzk0N2NkTjhkOFJL?= =?utf-8?B?RG1CUjVDMGtnVWhpRDRXUUhxcEV0N0tvWDhPaXhDUXk5c2p5STNobVp6aFBM?= =?utf-8?B?aU1PYUdTQmZIV0VmU1lCMThQV0lLNHE3VHBIV2JjYUZjQ0wwazFaOXpzNy80?= =?utf-8?B?RHc2d1lCQ2Ztd1hYOUtsanlyYW05U1VObjY0T21PdDZrdEY3YnBLcTZjalJD?= =?utf-8?B?Qm9mS3pUcWd4NXhpbStNNXpCclhzSTdaaHNtZFFPZnpqYm5DTlNmMlJ5ODU0?= =?utf-8?B?cWM0SEdCb1lBTkFSNE1KRVVqckVYNGtTeW9mZUJLRU4wV2hwaGYrWE9ZWmxI?= =?utf-8?B?UDlzOGZFcE5JMllla1ZWb1gxRWpuOU1YQjNBb2RQNllrRnBjYmk4QVFoRUo4?= =?utf-8?B?OGNMUjJncGFobTdLbWF1dmF6eEpHS1RFNTBvajROckJQejNvQXV6N2p5K2R3?= =?utf-8?B?T2N1a3RDWG91K3U1eHRzNjBWVGhScjQ3RGZhcmxlOEIxNDF2MERveHJzd01G?= =?utf-8?B?NHRlTlBBREh4dlMwZmJ2cXo0N290ZlpGWTlFM3kzMnF6NDhCTlZMZnFha1dk?= =?utf-8?B?cmNLR1ZFTjJMQTZRQW1MT0pyZklaNmsyNzRNTDFsemYyOC9wUW9KY04vZSs2?= =?utf-8?B?NkRma2pzdWtBd21Taml1RUFMQkJmNFhJSU1xOUM4S0o0d0JkQXdMWU51ZW9q?= =?utf-8?Q?AMYeGfSY+quTG5uAQLvNLqFuK?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a6c37a9-74c1-4d7b-de2d-08da70603703 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 06:12:56.9611 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lZkv+7y41oPeMbRF+p3VeeleKeHZXc4tLqNrYsBwwtQm7ZWJXxnSUuwW2OF04ykUq47ENOQW9//TQ7Sl8mzTdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8697 On 27.07.2022 21:06, Andrew Cooper wrote: > On 27/07/2022 13:53, Jan Beulich wrote: >> On 27.07.2022 14:46, Andrew Cooper wrote: >>> On 26/07/2022 17:04, Jan Beulich wrote: >>>> --- a/xen/arch/x86/mm/shadow/multi.c >>>> +++ b/xen/arch/x86/mm/shadow/multi.c >>>> @@ -132,7 +132,8 @@ delete_fl1_shadow_status(struct domain * >>>> SHADOW_PRINTK("gfn=%"SH_PRI_gfn", type=%08x, smfn=%"PRI_mfn"\n", >>>> gfn_x(gfn), SH_type_fl1_shadow, mfn_x(smfn)); >>>> ASSERT(mfn_to_page(smfn)->u.sh.head); >>>> - shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn); >>>> + if ( !shadow_hash_delete(d, gfn_x(gfn), SH_type_fl1_shadow, smfn) ) >>>> + ASSERT_UNREACHABLE(); >>> I'd recommend crashing the domain here too.  I know the we've already >>> got the return value we want, but this represents corruption in the >>> shadow pagetable metadata, and I highly doubt it is safe to let the >>> guest continue to execute in such circumstances. >> I'm happy to add or convert, but please clarify: DYM in addition to >> the assertion or in place of it? > > Erm pass. > > We still don't have a sensible construct for ASSERT_OR_DOMAIN_CRASH(), > or a well-thought-through piece of guidance. > > Probably keep the ASSERT() ?  Almost all state checking in the shadow > code is via asserts. Meanwhile I was actually leaning towards dropping the assertion. The goal is to catch attention when things go wrong. A suddenly dying domain surely ought to be as noticable as an assertion triggering. > Mostly what I'm concerned by is it feeling weird to have one path which > only domain crashes, and one path which only asserts. I'm afraid I've not been successful in determining which other path it is you're referring to. If I knew, I might be up for converting that as well (not in this same patch, perhaps). I don't think you mean set_shadow_status(), since there we can't validly ASSERT(), as the condition is (in principle) guest controllable. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 06:18:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 06:18:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376609.609485 (Exim 4.92) (envelope-from ) id 1oGwrD-0006Fu-TM; Thu, 28 Jul 2022 06:18:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376609.609485; Thu, 28 Jul 2022 06:18:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwrD-0006Fn-Qm; Thu, 28 Jul 2022 06:18:51 +0000 Received: by outflank-mailman (input) for mailman id 376609; Thu, 28 Jul 2022 06:18:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwrD-0006FO-3V for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 06:18:51 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130058.outbound.protection.outlook.com [40.107.13.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 252858da-0e3d-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 08:18:50 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM6PR04MB4901.eurprd04.prod.outlook.com (2603:10a6:20b:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Thu, 28 Jul 2022 06:18:48 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Thu, 28 Jul 2022 06:18:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 252858da-0e3d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f/UGEfhOIAmqeKv8/xgq6g2rquqVr6vGvR1scdJBFDipYl87iGn55cyHDC6KuUSeG93WI/i6OykILMB1kE7igWgoimsO2GE3IxEriVhzTgvcclk/uATWDdDgGvXDuyDUEUsea1AcTYwAk+8g60EeVEB+qraYIIDK73+cq5cF1gN46Neo3nfS1oLzkH05CWfYwTT3jnc/GjsjRV3FPqtTYyFN25t9YomepUnYsZtiYaQAfSjZ13tuhnIR4/GNJDhnKz+2BhbrU6rXOtXxadYml2UR3kKlh75fZIIxz2jGGYRiNMcGpAKEmYabKIm7B3+Ky/c9IOwQhSrUDZm+YoCZHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ctjXa7nPPm7otd0pZFWiekKrS2ikQDzfOS4K/XiAfPA=; b=UT1Gvse1jyX6h9y89S0JkvaL0mRuSJJ4+zF5xOIf3qGU3FfvK4kDlkEYJEuXSa9VK0pJyl+P6wGqAMNaBDAPxM0B/iAYPhm5/BaQv2EkATSf3CxTgt/umndO0WyWxdHHfzVN7BS/mc1bN/7ZvxqxROzo5KQnXH7Vrdxe8/tSydAtvlqPwgO1n1aUhM6eJgedeMc/LN93RxAklZjJB+KW3bZw72G3FnKTtbjORrsJBJGaniwy5Fcx8AvBPxvLYXl1/ahO4PUvKc705fp5soc+LYJFl8jToTJNggMJ1KkaRDUU76Bzz5TI1kPWEHVmUl4+ku3yEPtPVa6NVqNM07voZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ctjXa7nPPm7otd0pZFWiekKrS2ikQDzfOS4K/XiAfPA=; b=NFjwiVFy0X9v0T/2e/L/0XG7lsalwGPZYaQn8/f32TaAU3/YSNvAfKLlQ/LKIlIBhFvhBQ3cUiS/GDmPp7CiY+kW58e7PPumjADaRfL2NqDNMhNRvoaMvW/JREg3+ddJBlU9cWxGfRrqpBGV1AJ7Zn7U3ccp6zekcoluWrwjYItfoCXbgPbVMcI2umy5P2Ya20IyGoHcDVZdoW7gvh6Of4Pn1OcLOFzfC/A9LMD78z3KWeuqQfM/h7SmxVxjEKnIHdDC/4VMe4qMAU9llCaQurBlRK5jLvsXgNxIy8D8prq2eroPddrQCldnYG1Xmaw0IeuBgkKvUDojT/4UGyyIyw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 28 Jul 2022 08:16:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 7/8] x86/mm: adjust type check around _get_page_type()'s TLB flush Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> <40042c40-a2ba-e491-d16a-4bacbfc6154e@suse.com> <764ae641-d445-f4ba-662a-c965ebcc582e@citrix.com> From: Jan Beulich In-Reply-To: <764ae641-d445-f4ba-662a-c965ebcc582e@citrix.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AS9PR06CA0408.eurprd06.prod.outlook.com (2603:10a6:20b:461::31) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c65ffd4-e433-40e1-55a5-08da70610858 X-MS-TrafficTypeDiagnostic: AM6PR04MB4901:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2tF1CWWXlDhakWAEkrjZyWYuYnmPYfE10jw+ciIq4h0l+/5HM+lJTCQ4faoRxy4tHQ8aNuGAZNEfrHmxEvBaJxHgbMKfd7mirZk/GwMFBnpcqpI3tSEC8D4uO5cL+v6/QgYlZqaiOg1LolcWDWtztuBDcpyLvh55x4/dB3r+x8Qf+7aTx6LyIJk3m+XEW10bgrfMvU/KjARTDcivZSxkJJzjD4+BxjUAqFuAv5e5scyJZ2G7/8YF9+9rFuo8Vs0JU3E9KzkskseweApgIOhf2Q1a6ye4qQDjY0lonJ0tHKd4zkOI7ggpe8LXn3lALHcdB2RKaFQAX0pRPnHZexG0T8JLJOJTaa8SddKc0jjVK+yR5PSHHMofbwylfJgiCP+LBsTXcUNh5hsXQtO8VzCXa5ndyxsUaGNdfya2Q1yx5P3xhOX27I47ojnlAnMfEccCj6h2Ulf+ypYxyap0lUjvjRA/3Nd898vr/YOOoiy+UG9nnFxlIthXBRiaaR76XtA5NgvXYGLXehNuvmeFB4SWlH3VR3w+izF9P161Aj3nWwZY4D0SFRkkxQ3L0+o5nMlZRZ6rkIaV2EsIlDw0OvAQ4j/W7npkKnDzYx546nFSQnFVrFq/Y+e9hAQ9q8JJ+rY3PtSm+FpD8C6gM6wvNf5LH/54rvDP7vTmn3wktqacIEdmV8bUB2YjpTLIDrZVrTCjbKglsPXMj9YogGqND8Xk3rqYFRZoIcsMtx9dBiVFGt6B4rlA/P1rvQQ1gfcj/kAcpI2L6D/fBjSp+SxpI3xGM06FDoJCrzKjreAZGAIEWH6wBhiAxw0gFLuYu+Cs5K8ujXm+dpKwop4tr2HP6XKUdg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(396003)(39860400002)(376002)(366004)(136003)(186003)(2616005)(38100700002)(36756003)(316002)(54906003)(31686004)(6916009)(4326008)(66946007)(8676002)(66476007)(66556008)(26005)(53546011)(86362001)(6512007)(8936002)(31696002)(6506007)(478600001)(6486002)(5660300002)(4744005)(6666004)(41300700001)(2906002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aTNjNG8ycHpBVGZIbGs2T01iUnRLNG1rRTlSQk1GL3lYbWlMVjV6clNlblR5?= =?utf-8?B?Uk9RQjJUU2R0d2wxY3VIN21NenVoOGpWT3ZrKytrQ3hEWVgxckszc3RHemRD?= =?utf-8?B?cTRNVWZuZnlPSXE4dG1YelpZZ3hnQ2ZKMFFXU2h1WjNlRFo2WVFCNFJaMXFH?= =?utf-8?B?UWNzYXpaNmc2L3dpWnV2a1NiZC9YcTJnMUl5Z09oWUZvNjZUVm5Pd3Znc1dL?= =?utf-8?B?UitNN3dSd3lUY0M1M1dvZFdnZmF1cDZFeDFXbmd3UEVEVlAvdFVoMVZGbUEw?= =?utf-8?B?RkJFR0hsM05ZRHd2NzRrKzBsZ3lOeFg2d3RQTlZpdmVub1JoeWE2YTNaWEJx?= =?utf-8?B?My9UcmNsb0xiUzNlVVczMDJiT3hKRkNDY2tjWHlBOGpMa1lnRitKaEhxVGN4?= =?utf-8?B?dTJIMnVJMkFMOVoyeEZLdUZ5c3JSWTZkRkhxakJnVVRycDZuVU1YOTA3dFR4?= =?utf-8?B?ZG1GOVRHVWRmcjdaMno4K01yN0xVdDdQK1Fxd1ZzbHFma1FiVmZETm5uOGk2?= =?utf-8?B?QXRSWGtaczYwTm1yYUU4UENhUDBqMFdWT0ZYWWxMams3RjRlTWRkOUg5cysr?= =?utf-8?B?NVUySTE5bjg0Uk92djVwRE5zakJZd1BXZ2xsK2FXN0IxbGVVMnlxU21nbFZy?= =?utf-8?B?b2t5ZVFLRFNodkVSYlhGc3hpSHpzOW1RQ0xXUlBrU0NMRVErQTlrUTRWSGU2?= =?utf-8?B?emY3UlNRS1JnTGFQZzN3cXJPelBmNFJYWkNQWnBGbjFUeFBDSzltOHFsaGdJ?= =?utf-8?B?WGxtNGpCQll1UEwvTTVjWnVBelhwN0RybWJDYTNBNkMzOEt5SUthUDlsRUtU?= =?utf-8?B?cm1iamdyRkdiT1ZyVlc1UHk2V2NIQzQvTFVuK2w5SWpRcjhQcmE4ZFFHS0lM?= =?utf-8?B?SEtUYnFnL2R5NndVakpFY1dWOEFMcndNZkR1THVadHVFODI1dkNuaVBoaEgv?= =?utf-8?B?UWdBdndZSm5kbFU4djRQa1RkV0hHaGQ2eWYyVWI1TmVsWEZrdmpsTlpQR20r?= =?utf-8?B?MHVPUnY2am1oVE5mb3pibXhtTGpXc0c4Rk9NMkFsdys2UkZhOFJrMVd6NWtS?= =?utf-8?B?TFl0bjVwN0ZtcTdscVhwd1Q0eEtXOTYwVjB6TXkwY0RqZXhmeHNnREl4NDZM?= =?utf-8?B?RUpKNmdYZUJuS2YxZ04vZzZyVlNuV01vN3ZSU0xqVWdlMzJBbkkzc1pKb0tK?= =?utf-8?B?ZlJTVjZqdjlBVTcwK3pKbEVLak5xZzQ4c1pUcWs0RG9NRHNoZldxbWFOVTI1?= =?utf-8?B?OGVIV3FacDJEL0RBTzFZTDBFWVU0YUhpTUlkdHpIY2xGKzFPYTZTbzI1MDE2?= =?utf-8?B?NEpOWVc4RUk0dHIxNmtSWkpjYkhPcmNVajIvc0RsTjNTYlQraHNURGhZcTg3?= =?utf-8?B?NDRTRGcycktVMldhQmZydno1aHl1K3VPdFdNSjU1VUJRQTYzc1UweHorbHZJ?= =?utf-8?B?Q3loWUMzY1JTTGtGQ0grNG9OU3FYU3A5SnJuZzk2R2grQk0yTDE4b1F3a2Fz?= =?utf-8?B?azQ4TzNKRnpoR2tULzh1ZHV6SU84aUd2VW9KVGJtWTV3T0Z2aTdIZzg0VmxJ?= =?utf-8?B?K05BMDRwc0lQU2gwRHgzOHRPWTdlelovczMwZURBVHFhbjhKWE5YVnlGTTB2?= =?utf-8?B?Kzc1YlhSUVZVUGNqTnJtVGZld25yWmNpMTZOVlJ2Tm9xNzMxTDJacTZmRVpz?= =?utf-8?B?ZmJMdmY1alVDVm1DWGZNdS95UWRwVk00eFY2VXNBT091NWcwWTZCSFREU0d6?= =?utf-8?B?VXM0eFBhVkVYYVNsQmlpRWlzc0xvY2tocEd0c1R1Umd4YTMrLythS0grWCtZ?= =?utf-8?B?c0Q3V2FoM3F6WnBFVjl0bXJwVWlELy94SDNxbkRxVi9ycm5pNW8xS3Nwb3lj?= =?utf-8?B?bEhzUCtvWmc4aGlwZlVBYkV0M0Iza2VCUzFvMVQ2dGt5VGVsekFpaVBVZDRh?= =?utf-8?B?anFkRDFkWXhZNUhpeE1QNFFlUHFHaEx1dHBlWEhud2gzZzZkbzMzRE5CNnRT?= =?utf-8?B?bjBlZjNIOEJpQ1FRellkMlhWNGtxZjlmNzBVTXA3dG8yMEdtUHArYUc2N3M0?= =?utf-8?B?Z2ZtNi96ODBmNzdkWGEvbmxkc3FidVJhdXphRTRVY0VyY2RHalJKUnVsTEFo?= =?utf-8?Q?QcXoxthzbJ7w63p/+6SitB11y?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c65ffd4-e433-40e1-55a5-08da70610858 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 06:18:48.1429 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Kyz/cDl/D+m2Vmdh+PIyI3FBma7zGBQUFdaZXPr3sUPx0NF7o9VxYDvuusIHUbQTmZH5Ev1DrPNHBivpGEsrlQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4901 On 27.07.2022 20:25, Andrew Cooper wrote: > On 26/07/2022 17:06, Jan Beulich wrote: >> While "type" can include PGT_pae_xen_l2, "x" can't, as the bit is >> cleared upon de-validation (see also the respective assertion earlier in >> the function). > > While this statement is true, it doesn't really explain why this is > relevant (or not) to TLB flushing. > > As far as the change goes, it's safe on 64bit builds of Xen (I think), > but would not be on 32bit builds when this logic was first written. How that? The flush is needed if the type changes. If (for the purposes here) PGT_pae_xen_l2 was considered part of the type, then the bit being lost upon de-validation would mean we're flushing too little. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 06:20:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 06:20:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376614.609496 (Exim 4.92) (envelope-from ) id 1oGwsq-0007af-7u; Thu, 28 Jul 2022 06:20:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376614.609496; Thu, 28 Jul 2022 06:20:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwsq-0007aY-54; Thu, 28 Jul 2022 06:20:32 +0000 Received: by outflank-mailman (input) for mailman id 376614; Thu, 28 Jul 2022 06:20:30 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGwso-0007aR-Tq for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 06:20:30 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130044.outbound.protection.outlook.com [40.107.13.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 60c056bb-0e3d-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 08:20:30 +0200 (CEST) Received: from AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) by AM6PR04MB4901.eurprd04.prod.outlook.com (2603:10a6:20b:1::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23; Thu, 28 Jul 2022 06:20:29 +0000 Received: from AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e]) by AM6PR04MB6551.eurprd04.prod.outlook.com ([fe80::dd30:2cbc:361d:2d1e%6]) with mapi id 15.20.5438.023; Thu, 28 Jul 2022 06:20:29 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 60c056bb-0e3d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MKxoOLvhUcVwD0v+ZnAXgmxwcDgJ4ICaDprMwJkXwGXGr5StSz+R7soY+cZwfiU6eCaybLIj6J85gkWXUaw7qbr9eqpOjDUPzXiiNalFHJaBy+RwHf1Snic2dAaoV+Sc3ILUY0pcj4qA8mvC45Umo+ZEOTVQmlhLsLzOocsOBOGYywfSCmDQeygdl/EZKd7I0VYIbfvSCxy/4pmrsJfKJYnLQxckfNUAPUKHcZPnUFt5ib3DBCGKMVhM/SRQ2rEkWYPaXD2tXEW7q9OLXWAPX0RQer7MfGowVAII4sXd9lyTlD2zDC+UL9xmDMlT6iqKBtnkEF9yaV6A4AYRJbtRWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vjakR/UdeynQV2CjnqJ70tftLPefDvz1RaUbh/BdTcU=; b=gQnl5+pop9+5O5C54WcBcijcM5NgJYJgle3riryRTMah/O4dII1/qd1sgLpjzwEKzui+fyuFqdGzzza54rGOfXylCuosG8jahvPS4NmFPGWFba5EtE5zfgJ9X+b/6KRLLESBVNLgCJI41SsGHL4az9jDT78AlsJj1ab7DrJyqMc/XUYvAAUEj755Wpo3TDb1iQeN5RocYP6UZFjJJ8SoDyal3AcYg5f1jhdGc3v6oNomYHa0D2/03ezaQ+/2/giF3yJ6f7cVaprxIclsyMd8vuv7CEhub4gURH5Ijw3BFG5daHJVGmqEH3eLfwZ3BpBaVAbmM33eNd0B5D/w+uGK1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vjakR/UdeynQV2CjnqJ70tftLPefDvz1RaUbh/BdTcU=; b=qEmx2EVotyofBLyz4ciN37Y9Ob+hZS0ZFCRQo+NOVL6mCBGht1yoHgR+5FZ6VTxk1yt3M0zd3in7Qk2pRmGTk54bykHaY3IJ60ceTbW0aNB5pBbkwrZo/wpCPJ+2dV6Q3n4rJOF+dBo4DkuYdh/P2M3it6rsIrKQ873f5jXNvaJHXoAmLzDgCrtjVi/RkvNogmB6bjX0PgBdgcky4/SjtYAzKYnwWJTr5QfOCyiydlXob6R09JqFEZbLAPXaN0qZeAwaWCPX4wkqH5UYFuI8cKZdqYOACJpqBj9pvnyVSrQR7NE9AcJ2AZaO6EE7Uwo6c/ISPA8dpg1yNK9yu56X5A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <00df654e-2423-7021-32b7-62b12619bae4@suse.com> Date: Thu, 28 Jul 2022 08:20:20 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 8/8] x86/mm: re-arrange type check around _get_page_type()'s TLB flush Content-Language: en-US To: Andrew Cooper Cc: Wei Liu , Roger Pau Monne , George Dunlap , "Tim (Xen.org)" , "xen-devel@lists.xenproject.org" References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0151.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a2::12) To AM6PR04MB6551.eurprd04.prod.outlook.com (2603:10a6:20b:fa::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8532d716-7560-4291-6235-08da70614488 X-MS-TrafficTypeDiagnostic: AM6PR04MB4901:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A171sJqU4+zkHf0QkU1ApxxgCPyMFaAii48TnSkSzlb3ou9gm2zuaOZOhZdyUwJCE+Ac/AcfHpaj7ftcoav7p/JAwN1aKLkD1fXaPckdX6mwiFicM1hMEzxbjFW2zpKkZWUs1swBX4MoTpUMz5o7DL9+doBCJ7YNfXZciA/FfZR5eszpMAOU/jE9bOorhZWW8U3dVFyMTqcI0+3q8o/m3ZOWCwOtvnwpghGZFj2wjrw/uWvYmELlUafCG9Tqpt6ASbUMKyAdvxQ3p/RRudqv5JNJuNl0GaRP6+9bOmq6QF0LTqJavhgvUatjauILUtjZOdL23NP2EZlvRXs/wqHJBipTfzrvueUCZ6EFfa5Ez1gLnjKECpmMbe23xOUKokW8/5LITgjZK/x3tO+JW+m5AUTk5CJ/rcorK03O/quJ8qhA1NcHN+EErX7dN5uT4IIp4Qr2wV2FM+4BnClnwuulXO7oP8J4Pp+er428XoPtbxOJWoyzcza/DUur1TD58v1KSikcxY7nEIFgJ1LZCi/Iau1rARsku1z+/b8uavBgWWW+6opvsrkOmhTu/yWNFnke2sQPHAN+hXvpiMbdvCOg7C4IeY7ur5GUcwx+j+9Uz2JHGBbamOw6WIsgAlWczOimduLVhRFaTfS/8u35SwJ9jASdeDdCaRezuG3WCKX4YMuIlbOn/lijJidTQQ9E4RR0FQN7jIQR2kU856/sXl/mY028zdsB98pJ04qhXlNECoIysTdq/d1k73y7ztlR4WZdmgVCpOw8ipX1vrnYlFUVcoLANACjrUbKBeFJjBnduytUvTjIx9ArZdTsBmjZFqtRBQ1/q+HD+jfjEDwCjFCNtw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB6551.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(376002)(136003)(39860400002)(396003)(346002)(31696002)(8936002)(6486002)(5660300002)(478600001)(6506007)(26005)(86362001)(6512007)(53546011)(2906002)(41300700001)(6666004)(4744005)(2616005)(38100700002)(83380400001)(186003)(66946007)(4326008)(66556008)(66476007)(8676002)(36756003)(54906003)(316002)(6916009)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UkFtSXdXWFdtbnRhS2wwVy90Skl0dUxBOHUycHRiUklPNFIybno2KzNkWkta?= =?utf-8?B?VUVyZ0h5Y0JrQ0JZbzdUT2FmeTdYL3o5b1V4d29ISXBwajFtOXVUS0dKR1l5?= =?utf-8?B?ZUUvOUw2UnNvS1dvYTRBT3g5NHRWaXBuK25BalNMUDZQUERnd21wN1diVGZo?= =?utf-8?B?RXFmRkJSRzFjWXV2T29xM04wSEQ0bkMxWVBlZ1dQMUdudytxTUxvVkZIUG1o?= =?utf-8?B?ZTZjT1NTcVRrY0NKa0R0NWdwNXhJQTdVZ2hTN2hueHdXd3M0OG44VmVkanRG?= =?utf-8?B?ZTdjRkJrWDVubUthTVh2QWlUaHFyTGdYUWdMVzFmYXlYWU40ZUhGem9pUW1s?= =?utf-8?B?cm9pUjhZZVArUFBzRXZlYnRnSkVhVGR1T3B4RkVZYnoxWHNHSG9DYnVMTlBM?= =?utf-8?B?TGdqVGZrcThyeGxzbHBYN1JYRytNalNMSXVCUjArTGRNcExKMlRTeG5KMjly?= =?utf-8?B?M0NaL3FRdWp6NlhtbWpNdGNrOFVNMXVWUTI0WW9IYkVETkdCa3Fua3pMbHF6?= =?utf-8?B?RG1ra1g2blRDa2ZBSXFqMzdjUVZZWWduUUU5bS9kWmZlclltK2FwWjdUajFs?= =?utf-8?B?cXR2U2FZWElhSmV3cEp6djhKSzdYemE2RU1FWHF2RUg1cloya3F4VVd0Mzlr?= =?utf-8?B?RUljTUdVdy96Q2h4d0xZa2UrOVpqaG10R0RLSXk2ZE1zWUJCVFo4dFA5Z3Nr?= =?utf-8?B?N3kwNy8xalo0SlJJSUVGb0tXM1pwZnBFL3NhTm9OanhQbGtzd1lCUVE4Q3V3?= =?utf-8?B?SSs2d3FhT3ZKcTdmUWNVU09ydG9lK3Z6alhHQzNUQ3NBc2kwaTIrbUdtZ044?= =?utf-8?B?cFV1VnZRQlVYYWdRdVV6T1lGQWhUd2pFSmlPVk15ZW43WUhjMHVUa0dIcnFk?= =?utf-8?B?MHpORUc0SFdCR2hYLzltaWdvaHFkOUlNblN2K2I1SkNTYktPRzRmbE5MbXNT?= =?utf-8?B?VVQ1K1NYYzl5WGF2TUh5Y2hxZHJUUHJJWFlLdGZwdS9SVjRtUmExd3d3L3Z2?= =?utf-8?B?V0l2ZWhXbXRZYXIwZDZOVi84R3NwNVgxNWF5SUdjVUhjU1lzZ3M4Yy9NQzN1?= =?utf-8?B?M0wybVNPaTQwR0o5dWZUR0lqZjFOVmxmYWlRVmpSNjkvZUhqTUp2ek5DUnBI?= =?utf-8?B?RWJSN1R2SXRHck9BOENZTC9pdE0wNWJBaXJlbE85NW1nNVN2elh5clFPU1Q0?= =?utf-8?B?MDFUT2s3QWhHamdSY2FQREh5SHVPWlJvNU95R3FTZ3c2ZjhGU3Q4SUpLRmJG?= =?utf-8?B?MmlsczM3OTlhZFhjT1UvcXJ4MFZpTC95a2tsSkpEVThkRFRUeUNnYzZta3g2?= =?utf-8?B?R0F0clhBS0hWSVF1N1FZZWhaNFcvZUJESHpLa250QzYrTkdxN2JMRndLZTBY?= =?utf-8?B?L3JOb2hEU0xwZlh3eTRkYU50UE1lODFyZzNEUkNIUTNOSWhRQXg3TTk5czFS?= =?utf-8?B?V3dWYXBFMUdpS2Z5WHEvUjIvcVhsaStzZGdmTk1tc3pHcENZZ1pQcDZ4ZWk0?= =?utf-8?B?S21DY0w0SDcwajI5RjFKR3FOSFBKczhWUnE0S28rT25KNFVhZk5hSnVWNi96?= =?utf-8?B?aENOQUJxeUZNWGpOLy9GU1k0SjduYWx6VW4vcThHN3dDeWR1MnRmRVBkdUtQ?= =?utf-8?B?cHd1WnJsTldoMmlOY09peFFrcFl3Z1RxVVNBMmQ1eFdRZ1FJZUNnWmtLQ0Rm?= =?utf-8?B?WVFHY2J1emdwWWgzUWJxTitxQnhrTWZEeGE4V0pQREFjdGdsUnh6NWtOc0sy?= =?utf-8?B?Vnlyd1Y0MFZYUjkxNm5jN0F5dzBJSDlhNlZBaGl6bHV5MXU5dXpRNEtSNG40?= =?utf-8?B?R2J0R2xGcXF6elp5MHRtWVZKbTYvbEpLZGNuSDVnTkttdno3TmVjRzlpYmUw?= =?utf-8?B?NDBUekJwR3FnWlNNNGVXa3ZWWTRNRk55MHZlNnRacTNuUy9lVmV3N2N3VVJx?= =?utf-8?B?ZGJKRldpMjJUSGxHckxDNitNV2ROMlNVc2JReENLSEE3VG1GMjBNRnVWYUdt?= =?utf-8?B?K3pMQkFpd05oUXBpcUFRTkZKZmRVbEwxOEY4bWZmSU9uV0lxNEQwM0JoZDZj?= =?utf-8?B?eElOK21qdzRXREJVZGN3Y2dTTHVtVGhpVWo1b3lZSmFxTTN4WUEyWTZZMzFH?= =?utf-8?Q?WqXUDnfK0IXGGPGGgpOBC5czE?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8532d716-7560-4291-6235-08da70614488 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB6551.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 06:20:29.1680 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: h7OISF5+wgCEoLRA26nExCjii5U2LApA1OMqdJ6NzO0KSulgM40Qw05gkkDAsv4d8qXSeN2JDGUOoC7VUPukFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB4901 On 27.07.2022 20:31, Andrew Cooper wrote: > On 26/07/2022 17:07, Jan Beulich wrote: >> Checks dependent on only d and x can be pulled out, thus allowing to >> skip the flush mask calculation. >> >> Signed-off-by: Jan Beulich > > Do I get a Suggested-by seeing as this was on the very long list of > improvements ? I can add one, but you weren't the only one to notice. > Either way, Reviewed-by: Andrew Cooper Thanks. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:01:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:01:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376623.609507 (Exim 4.92) (envelope-from ) id 1oGxWV-0004AY-F9; Thu, 28 Jul 2022 07:01:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376623.609507; Thu, 28 Jul 2022 07:01:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxWV-0004AR-CV; Thu, 28 Jul 2022 07:01:31 +0000 Received: by outflank-mailman (input) for mailman id 376623; Thu, 28 Jul 2022 07:01:29 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxWT-0004AL-JT for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:01:29 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140052.outbound.protection.outlook.com [40.107.14.52]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 19d2be9c-0e43-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 09:01:28 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB9108.eurprd04.prod.outlook.com (2603:10a6:102:22b::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Thu, 28 Jul 2022 07:01:26 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 07:01:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 19d2be9c-0e43-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mn3P0HPPn0r/iXIA6a80UvZn0Rj/VZTxnGNIvenEeEj/DnPpOVbGSgc1D9CJ9sihHab7zaIxQx+B2eycjFhx4523C3gdZsXpPXOQlr0KJDWzeg45KTXmAwCu1ZZUlH573MQk16KlLqAw7N22ilX32sxkdu86FfV7j5u2HmEP04DbIaXuMa1nowIuMsCDwyg726+9e5olxbkD2qEFYG3DDDIKK2VrVdzEQGceB7Ik6PD1ZOIiU4SvFdR20uL2EB3NmBdken7w1UJdfIKOzN6FpK6fXn7aFKMI3RXk8J9X2ndspaJBsGf2rqw5WS6LsKpNaKCFIXbCg+P/YA7gu7p80A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=g8w0QFlNxtccf0wz4v93VCyvBgfGFiQ40dpDtjNXi2E=; b=kVExEsGt93fBiF8mCUdZQa6Iv0F8yPrFiCF/Yy6/0KIWa+GmEeTGm15tZFCcQLAj2/7514/vyLQZ38NJxpmDR2za/J2rCd2WD6P6qfLiitWDPh0WB2l6aRd8LoSrCGqp7Hzx2pwOFmn56DrPRV92XC2jWiLjUHeoJwdJvMlfhGqVRwwINhdjJ6TGBucCwlvFQ/6syeT1zUJIfP8IOeHxVSfHbkGc05NCtlNS0/zdpMslYqE6pufwqBu8N2yNsIY/JhN89CGSfEFGjijgPCxnVbigf06rU5lUJ3I+p68+JWflvFapvTchWr7y9vMiiid49pAXinKchKRjBaxgodnkGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=g8w0QFlNxtccf0wz4v93VCyvBgfGFiQ40dpDtjNXi2E=; b=agxu3ras2oC0sapauNrYl0y0wCFlHNhPDvzYoYHJcy9e3iSLm0A2xwfBvsfc1bZ8aMQVO4Msr2JpvcnvNEuxmBwl2OY2dk9ZotPJKSC+OQPz5UotKBlzj7BiVljL7rVuZAWaRHcNJXNzKtH90Z5hkWG/GmJ13U0gqb0mWQUWRlpbjk9eSWRGrXry6xPoQvxZ70IybwudX3ublXpsX1ATJdSERG8QpgTlq+fgybZFpr6kLert7jSZXuRTTJ9gpt+naM+8gV2RiCmqPsKIm0SF5t2bBvPtYjety7VNXMwxiGi7OE8rJ1iFn3zYjrfNkqDhUW+pCiPHbWwfmcfuTx2TAA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 28 Jul 2022 09:01:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-4-olekstysh@gmail.com> <25d96933-5582-ff1e-f685-d48b5380d531@gmail.com> From: Jan Beulich In-Reply-To: <25d96933-5582-ff1e-f685-d48b5380d531@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0134.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:97::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 035c8ee2-d643-4ea3-a17d-08da7066fc61 X-MS-TrafficTypeDiagnostic: PAXPR04MB9108:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tObGffKBib1aODyLCORmer8OeeLgaUFVkwu51DosK4E4U3XBiZwuJrLO1QIVU46Cj+XhzVqw6/ZvkpLfkqjnrvRY5eFQk/aM0IVrHuLyhrXtTkBs6otRsQqkmhpmA1A8VkCg8UEcWUpDsUsPJo9t0ozHW4o8lKIDxbjoqAIK/mzDUUwzwdJIZ8RPAo+gzi2XZ38FIdxPpIVtlo+mB3ok0uvTuJXqXgz7ojbB1Z9VgS77jx7IqTUQYZ2LhFj0fS60MpE4m8zgYvED/OPsTIgE9jIN8mBGD2BTlljGkSOXvfxhNqAmn6nxmOYPmrOIVSj6BlIS8aHNy9ri4nr2yBEnH78BuQC6iT4QiNbseDFUvMnUmmHW1RKShawbBL92LwshYGcpJdRf9tQoCEAwgrDPmhbHKKgeVlVxxRwV/Ud3xSHopYaNESGO+TLxRDaEpKIudwQBz9JOTRNBGcUtDhzXDxDR/nUDbXhX8XYR6JKJRmqcfSs/lraYiYnZY8Gca5egavtb+rslj2noyu40mamPA4rQmDpDnVpdBuUw+FH1pYD5YYPZ/0HaMKf9WzxFd2fosCj8rljhifDWN9nfkzKNQRlP6jdb24dp82Flum+a8iiJYTNFRAu5MOaC0EJnWONQQlOiF9v8q6dtdXFL1rxBNSpXUiS6NM8xsLDDTcDBdpwQAMn2dOpu+FreBcVlFTzRjB5w38lw0fNDoJwBD+XQpWy77pvJDmkOcd/xJDuB3Uv0QFIZC2tP32NrvnLW1JXOEIW7rBOMMdmgpmxUEVUD+CrXs6CiKaaH5Jar8pFgT/D9E+VzBKvdFbUvr4CsxeBApaOPCXc/GqEv3l/9/k5VDg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(346002)(366004)(136003)(396003)(36756003)(38100700002)(186003)(6486002)(2906002)(8936002)(478600001)(86362001)(66946007)(5660300002)(4326008)(316002)(66476007)(41300700001)(26005)(6506007)(31696002)(6666004)(31686004)(2616005)(6916009)(53546011)(66556008)(6512007)(54906003)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S3JwdFdYeWkvZHU0MDBib0RuRjRJSnVFbVNBTkZoNzlQREMxNVh3bU96VVVG?= =?utf-8?B?SUdJeitlcE5IYnFJMHRYVWMrbGhUUTNXVlAvZDc2SjE0aXJ1N1JvVlU4aldJ?= =?utf-8?B?ZDlhbHlFdGE5NFN1NWI2RzRtWEk2WHZCbTZwU0hFaGVLN3pibGlDRW9kU0U0?= =?utf-8?B?bXJQc1RKa0laMDdjQU5wMWJmYXExdTNaVnJBaGdwdjZFL1h5OElPb0w1Njdz?= =?utf-8?B?SUZNdEluNVg5anYzUkREY0h4bTNvVEJ4b0d4V2VmWlJYYnZCWXZWbUFTMDRC?= =?utf-8?B?VVZMczhJUFJNQVk0WlFLdENueERvS2tlRHh1cnN0UjJpMW9ScElpWnZHZzdW?= =?utf-8?B?d2t1eXVESS93N1BGbTZaaWJiQXR5TmhMQmFZcExqVm9vYllSblpTMXNJaFhz?= =?utf-8?B?RVJVZ1Z6RWltd01LR3BaNWU3WDlQSWc1TXZnTWF3Y3lOd01yL1RrN21DcHRI?= =?utf-8?B?L2Vlc2lpbW40K2dEdXlKT0hXUmVtYWlWRG8wQlkwWTkyTkludTQ1YmZwakd6?= =?utf-8?B?SnNPdUQ2QUR3Ky9aT092dzdLd2YwV2hkYXlUSW03elNOb0VmL1hOSklOaG42?= =?utf-8?B?QlA3RmYwSFhQYVRBUk1yN2hSVVgrMjdQbU9iMDY4TUpKTldGVlhRNlM0WnlY?= =?utf-8?B?dHA3QW1NbkNERFcvVU9PS2oxNWVRVGFGb09jQ2IvNS9xdDFHVmFQZy9sN2lC?= =?utf-8?B?T2hFT3VZNnVWVEtUYXd0UzlnUEIvOEd2YnNPeEZVZE9NamQxL0tJT0tvdXpu?= =?utf-8?B?VFFkU3Q4UU5sU09JczJhdnM0WXp0RHJwNzlGUE53MVZsZnFqUGE4S3VCbHFR?= =?utf-8?B?NzZ2Rk5mY0lBUkxLeGpiTEplTWJHOWliRldkaVFSek9Scy93Y202K0xOMVdK?= =?utf-8?B?ZXRMdUZsL1hwWmhoRUJaR2YrK21xdHhNZVdycUVXNFNCZzdYcjA4RVRpaGdz?= =?utf-8?B?SGdvRFZDMEd3eFNSRVdvcDdwVk5JMjIyVUdwUjVpNnl4VWFNQWFvTFBuZnJQ?= =?utf-8?B?aHQ1UmNLeTFBK2pnbDhxYUwzbmtLNUphYmMreFNKUVE3a29USVppUjIvUUVj?= =?utf-8?B?ZTdGWk1pMkU3M0FzbzlDUVhyR0wvTmtxQVl6M3NyNHg5UTIxTCs1Y1B6NFZJ?= =?utf-8?B?NHZPTXlXK2ozcDNaT0RoVkltNHRJNkN0Q2FUdWZucTN0OVZFWmtuU3YvSytt?= =?utf-8?B?WjNTdW0ydDJLVU1ybjVTQUdUYU1ZMmNBWDdaeTN0Y1VFSzB5YytoeFJiY0lX?= =?utf-8?B?ZEJvTmdpL0dSTGF0bUhuZnladHJ0Y2phd3Y4ajdmd28vS2RHeWR6N2NLUGYw?= =?utf-8?B?QmtsT0NMVWsvbEorL2FETHJnay9tTDZNcmNGbWxjQ3pONUttTEVsZmNnQk53?= =?utf-8?B?ZW1HL240dHorUzJBTHRXZ2xnQjhIUUlzVlhrbDZndDllYmtXaXl4TlovNzFP?= =?utf-8?B?aldXQUJ6dmtoaTN4bXJIVmthSVpmNjdvU00weDRHaGxaejdYdGZMdjJld1Nx?= =?utf-8?B?VVVCRTlSWHJwa1pkWTZ0a2JxZ2lXdnk3TXZ2YWZhVW8rdUZDMTFGd1puTnla?= =?utf-8?B?Wm5IVzFGNW5aZXVvU09qaDhDakVyc3Z2YkZISkRNT2xUVFVwb0h3ZnZQYUEy?= =?utf-8?B?Vi9TVFlKVnFBUUliK20wR1dKbm1iT1A5NlhKTHZXaHRoUlJWYUhubmhoYVlZ?= =?utf-8?B?QlMxQXBBcGxSS0lISHpCZkloTVFOeVo3a0szR0RqVzZ4Vk9EeWRPdWlMV0lp?= =?utf-8?B?eUg2eE1wck5RSDVPNnd0UGZydlFlWkdYZHJXWWtOVmxERlpEdFFjT1hCU2NE?= =?utf-8?B?SUFac2hPRUZWNG1jaGVKQzRrZm9xdno4d05qcnhDYmkrTFJrZElRbUV6RHFF?= =?utf-8?B?RW5sOXBSOG5wY2MzSU9TS28zNURCTVluVTBEcjFPaGNieW5oalNJNitrOWpk?= =?utf-8?B?UG1hdjVrenBDKzdLTVRzb1NmdWFJaWZBK0VpNjRrUWJySHBzNVNDRDZRdVMr?= =?utf-8?B?MnFjMWhHMEhReS8vcVUyN1JWRjZiY1hBMFhQVml5bTdxRUkyNXhFa0RuTVNY?= =?utf-8?B?YnhBOWtNdVVmZWdhYTFzVkFjZnFyc3doQUo3cmU5L0xwckh4eXU5TE1uSi9m?= =?utf-8?Q?0Isx5FLmsRMP2TIJy8vTCzK4S?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 035c8ee2-d643-4ea3-a17d-08da7066fc61 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:01:25.5202 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9XuYjM6mxqA7tWG98z9SM1rXd7DikgDED5BJPSOZB385R37jdVloccDvvsbsJmAzU9jz1n6cyUlUtBu7KOc6mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9108 On 27.07.2022 18:17, Oleksandr wrote: > On 27.07.22 13:15, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) >>> if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) >>> { >>> bars[i].type = VPCI_BAR_IO; >>> + >>> +#ifndef CONFIG_X86 >>> + if ( !is_hwdom ) >>> + { >>> + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, >>> + reg, 4, &bars[i]); >>> + if ( rc ) >>> + goto fail; >>> + } >>> +#endif >> Since long term this can't be correct, it wants a TODO comment put next >> to it. > > > Looking into the previous versions of this patch (up to V3) I failed to > find any changes in current version which hadn't been discussed (and > agreed in some form). > > Could you please clarify what exactly can't be correct the long term, > for me to put the proper TODO here. Do you perhaps mean that TODO needs > to explain why we have to diverge? If a device has I/O port ranges, then that's typically for a reason. Drivers (in the guest) may therefore want to use those ranges to communicate with the device. Imagine in particular a device without any MMIO BARs, and with only I/O port one(s). >>> @@ -553,34 +635,47 @@ static int cf_check init_bars(struct pci_dev *pdev) >>> bars[i].size = size; >>> bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; >>> >>> - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, >>> - &bars[i]); >>> + rc = vpci_add_register(pdev->vpci, >>> + is_hwdom ? vpci_hw_read32 : guest_bar_read, >>> + is_hwdom ? bar_write : guest_bar_write, >>> + reg, 4, &bars[i]); >>> if ( rc ) >>> - { >>> - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); >>> - return rc; >>> - } >>> + goto fail; >>> } >>> >>> - /* Check expansion ROM. */ >>> - rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); >>> - if ( rc > 0 && size ) >>> + /* Check expansion ROM: we do not handle ROM for guests. */ >>> + if ( is_hwdom ) >> This again can't be right long-term. Personally I'd prefer if the code >> was (largely) left as is, with adjustments (with suitable TODO comments) >> made on a much smaller scope only. > > > I can revive a comment that Oleksandr Andrushchenko provided for earlier > version by transforming into TODO: > > > ROM BAR is only handled for the hardware domain and for guest domains > there is a stub: at the moment PCI expansion ROM handling is supported > for x86 only and it might not be used by other architectures without > emulating x86. Other use-cases may include using that expansion ROM before > Xen boots, hence no emulation is needed in Xen itself. Or when a guest > wants to use the ROM code which seems to be rare. ROMs can contain other than x86 code. While reportedly mostly dead, EFI bytecode was an example of an abstraction layer supporting arbitrary architectures. Therefore a comment along these lines would be okay, but personally I'd prefer it to be less verbose - along the lines of the one to be supplied for the I/O port restriction. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:04:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:04:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376628.609519 (Exim 4.92) (envelope-from ) id 1oGxZW-0004ke-UW; Thu, 28 Jul 2022 07:04:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376628.609519; Thu, 28 Jul 2022 07:04:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxZW-0004kX-QP; Thu, 28 Jul 2022 07:04:38 +0000 Received: by outflank-mailman (input) for mailman id 376628; Thu, 28 Jul 2022 07:04:37 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxZV-0004kR-LI for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:04:37 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2066.outbound.protection.outlook.com [40.107.22.66]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 89e53591-0e43-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 09:04:36 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by VI1PR0402MB2847.eurprd04.prod.outlook.com (2603:10a6:800:b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 07:04:33 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 07:04:33 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 89e53591-0e43-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wi3DmqpSdUjCf1a/yGbwf95N+1btNCpv/o3qhbYKhidv5geMnP3kX+7Wd0JzuX3A0NHZ4T07k254EbZuQpcVL2L9+tbtIo9jdgUlo/9Xls9cBp4T7RME10o1zS4NxGGo8AR0VWN8+0qdxbPTBAYCOn6+m7qT9e+S8k3AGS+TJgxdTotOsdBkJz2oFsY9WcDYCzP1GCwetnatt9QkElqnnzv2y6e7LAWQL/KlECN4+bpv/Uka9vsR5CTfVFC0hHfjOe+RAlcrNJhocx0gpjDOSTOFPXGuHMir9574E34thc3ro/aJnN5k9+W6fPrFnXClPSzgLCwiyRtlK5JQYDF8bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Eb3PDVQs7FlAqnRbsY4JVCnfJzt6AEgUfDJbtfulbcc=; b=AVJdVYLF1Bu8TWI2E4TixZkfiJnuGZstBKq3gp2BLoA87mQg2TpUtBNFR9tOjsU09OBWDjLsz0kV7zD+J0uWbvna1xUEFoRccoWunZb0pWajEzIWEkCYsfGdetCCKjRSXffDkM8Vax6Q7f93c3XZc5Jasg7SIj7bpGXpoGxVy7vbXO8Bbkdofamv9oRTkCGpPW/l8m7Z3dV/vrlLAKWsv8D+TMZHokzOKx1AYeVhlGDaPyf5OTuDEHV47x3MtuZdaF8nD5If3khZXWL1YuOpA8mhvqt8nv4L/iAvR0Wy0mDMPxJRCG60mrbdPhm0BhMG5m/qFkdG2U48MQXoPAtTdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Eb3PDVQs7FlAqnRbsY4JVCnfJzt6AEgUfDJbtfulbcc=; b=H0zOcTVwlhhdHIrkuO6sieRdyID/hgXUUVD+TtKG7vt7230eeDG9g1rjr2s4ziw0/QE9P7NyIW/JrgFhGrou8ixcXjLokA6ceY2jXh6ukvKcuE495r0dVJ435ZgoDs/7gwOKoOA33Tm7fCHBHwsOFlY8FTTLlsdUD/U+ue+hPZ4cN5nPg88vuCbASvxYPAUEJBIJh9vIU0k5YG3p5ihddyZaTu2crRr16huZWiLxksch8bb0fV+zXuXGAyu5pam2JYWwu0s6uyUFgzpjw6xTn3cninh86o0pLZuHH8b1x+km0K/71UjARcEiPbtt3ywBFwDczX8PKHqTeEtZnm98zQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <9359c032-1cdc-542a-da9a-99a42a67d27e@suse.com> Date: Thu, 28 Jul 2022 09:04:30 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 06/11] vpci/header: program p2m with guest BAR view Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-7-olekstysh@gmail.com> <85853c9f-5706-22dc-4798-48c775a17d12@suse.com> <6a687fa9-aae0-2257-5d95-91b00db1613a@gmail.com> From: Jan Beulich In-Reply-To: <6a687fa9-aae0-2257-5d95-91b00db1613a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0085.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::22) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f6f7bb4-bcaf-40fa-dc49-08da70676c41 X-MS-TrafficTypeDiagnostic: VI1PR0402MB2847:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: SDg1vsBUQOu2yJZv11y9sNPw4l5GIq6AGWHpRr8IQQv6BWk3G5u7qXaBlEqtEztyWAys1T8xGmD27OKnjZ4GogFDk3qLJoRuUpGA9zyG7ICnSavCaINobMXK+bM0++vElOvyjn+wAyZJnHxMB+wXYPLhZrHepjXICvo2x0NfIlmWlJOn7h03Org2fprIUBJpnZ7UDZ4FKXm1t0nNK2pa2pxzgbI7OVGbOI9MtCXYum5kNpnmfl0iXfvz65iK9I50yhgEGo5u1rNxKxeQHSAzFizWn6YJHvmOwxiDe6AHZ1+A7ezfCOXL2PjZzdP+wd83/zL6u+y7kb4rkoSr92Mjo/J2cLZohZGKhWKU94gLr/sgfyG4dOc5fQ4sbN0QsncDStegE78RYS14XRlRpy5sErurFzssZlTifmqyZbnNjNxkfR7F5Lg23iIVl3NWSy8LLbBlLmaY7YW3WCkAcCBu9i71S+QnA1Km//JywaAg/JQuQN2F9GhJEqkuF/GHw7Cd97kbn3czF3rqE6/wryG2IC+gadwdRO8rQhm9CQWFECG+RziPmYEoyCpGrHCKhqpgBe/e3Hp/cwXSI0uitL/a1Q0mLPXxW9rMSVhCCfg87cTf8jGVu8nMsNMdBLtjOy9G+P9+mEHmwQ7VXaB+KWIyYPFLMbjWtKhzaSVO7XetrVeqnxl5r1CQBmxR0IXVSlCYxGLxKw/qKhvyujWsdIiw0qdeGAKqXFJGgETz3XFxLg3QQ/Oy+YwY3JV7vSSy1QTSrPY9kLzP6Yh7Zl//qo3b9MpLyBUY3vjkMTrNkaTMP/RCAxrQhLapUAqF1PSIJ0S7bUAgaWsx5rGl7qAbfoNJ2g== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(346002)(366004)(136003)(39860400002)(2616005)(41300700001)(2906002)(186003)(6506007)(36756003)(26005)(53546011)(31696002)(6512007)(66946007)(83380400001)(86362001)(38100700002)(31686004)(4326008)(8676002)(66476007)(8936002)(478600001)(5660300002)(66556008)(316002)(6916009)(54906003)(6486002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UCtReFk2S3lWeTdMSENVbUFpWXZKRCtrYmpTNFFNSGVHeW5DcG1FdWY2U3Z5?= =?utf-8?B?ZVJyMGhHTG9IcDlFTllyMVVDbk50NFdRRzM1NkJvbnE5RUdOU0QwbUJiQ3dJ?= =?utf-8?B?eW1DL3FaUUU4UnNJNll2M2hwc1A4Y0NONnpPWGRORzB6NTRXd3VzVjdFNTls?= =?utf-8?B?OS9MMmNJYXFzTFU1VmpiQnVxeDg1THcxTjlRaktPYnVvMnpIUGFNRm5aUCt0?= =?utf-8?B?NDIvVVh1amdPallVNlQ3eW0vbWJtYXFpdm1CS2N3aS85QSs0aUpIOFM3a0l6?= =?utf-8?B?dU5sUDBhMTFCTVhUL21vN2Y5Z1RYamZqQTl0cVNhZ1kycTNxaG5zRlIxYzFp?= =?utf-8?B?a1E4OWJWM2lsbGRZRDJUZlVYNmRSTGdHcTJtMWx2cElvQ3RJdDM3YWEyVFB5?= =?utf-8?B?SzEvZzUySDlkMVlLcEE4MHJNVVRrdDVYTEwzWnVQRzNMT0dKT1EzaVJHSTJK?= =?utf-8?B?ZDNoQnJncWMyZGlUR0xGOWdwQ0k3Y3dPMUY4N1hUbDNiQ0VkSUZINmNlQ2J2?= =?utf-8?B?RmRlbmtKbGh3ZStsdjl6VWt1dkllTHY2SFVYTkQxYjVJd1dxTzFjSFU5Zi9W?= =?utf-8?B?TGVVZlZRZ2lNYXk5NE83THNvczUzakpRR2tobDBZazRIMFdKZVhMUXN5L0dC?= =?utf-8?B?K2tuQXRRdFVEaEp6dzN1WTBHOVB3aWlGelJDbEtPclRheHlUU2k0WmxFdVVK?= =?utf-8?B?U0loQk94SEovN1N6eldxQmdkUklUYkczalhTdFNtSjVNbUFNSXJRWW0wekhP?= =?utf-8?B?YzFhK3NmK1M3SGZydCtWYlN2eU5rTERtcGxlQU5mSW91ME1IeXpIUitqeEZw?= =?utf-8?B?RnRnaU05VjVpZU5pdWlwZktMeWI0MDZ4N3lYWGNZd2YyR25MMzBybGhHR3BB?= =?utf-8?B?UU1ZR0RkQ1FWQnNsK0dQNFhKWVR1WkRuaXF6ejdJbWVHMGFmalhncU1QODNN?= =?utf-8?B?eVJadDMwTFNZQUJXS3NPWHoxeVVnMEEzL09pYWhZRmRkUHpJYlpHeElvRFRW?= =?utf-8?B?SWxsbHNkdzJWSFFLYmRLQm9PR0JKRk9Kb2U3WTNPRHduYUpHb2tQQUg4VzEz?= =?utf-8?B?MFlOSXl4OHpSVXhHVEpKVTJCazFjSGozZHR0SUpZWWhUMFJMNzNnSk5IbW8x?= =?utf-8?B?bWNMcnFVV3l4bm1OWkQwY21LWlFscEJ0ZENkQkg1aEtvUVpiSlNpa2pSd0kw?= =?utf-8?B?aUwybkxTdFFrV1pCWk1uVklEbGpnVlFvMGNDS1N6Zmg4azRDMnlPQ2V0aC9D?= =?utf-8?B?a2U0MVFqUXN4NUVPeEhMcUU1S0dpYldMM0I0Zlo4dVF6NXlEalZVUWlRL05k?= =?utf-8?B?M3NMbk9KS0pXNTFaNXU1Q3BOVWM4OGdOTFdoajR2V2E2c1FCYUVTU3lWTzNj?= =?utf-8?B?Q00xS2krOHRjQ1hFSTc4dWdGZ252RnhmaHhlL1hCS0NmTjR5bG5McEZwdEtk?= =?utf-8?B?S201MGtlQ05YQ0RhbFBqL3o0T01Mekc1NlpmUVQ2Sy8vVnBVUnphVGlkKzFw?= =?utf-8?B?Zyt6OU50QTM0WVg0b3dTb2Q2ekVhbUJrUE1nRmk3NDlqZVMwdW1wYW9pRWZy?= =?utf-8?B?d2ZlaDVUVjJ0L3pVWE5pcnhMUGMyeUtENm5IdXB4UDhhOURwYjZBSXhnZ3ZL?= =?utf-8?B?VU9jMDZSQ3BzRWtvc0Q1UlYvSUcwK2pld2NSM3RwSW1hUGFlQ1ZXYjV0WmNW?= =?utf-8?B?aFJSYW5aQmd0MG9sVFR0Qk5rODYrZGpUcTBuamEzcEtzZ2l3VXJsZ05MeFk2?= =?utf-8?B?eG5wakZBazVOVCs4WFFoTU9Dd0VBemNYTzlQOEtaYlNnOCt0V2diUytUWk9l?= =?utf-8?B?RDNsamZ1OWlDMFhvS2JzeFhvTnVMbk1adU1NWmlzS2N0em1nTmU4RWdvNVY1?= =?utf-8?B?RTR5ZEx2R0VMcWdIOVZrcjVweEE4a1VUWHU4bHBzcE5xclRyQWxZWG1rUU95?= =?utf-8?B?VHZUZHIrdHZEaDJ2R3V3RTZSbFJIRVI1Rk5HRVQvdG1tWUxneG9ySjJRekpU?= =?utf-8?B?M2pMTm9keUU2SCtuZVpSVkhYeXM4ajFUN3RNMmJjVzkzeDhnR1FsUlR2NW1P?= =?utf-8?B?a3k0R1lHUlNVZ2JoLzBjR0Vmck1xbHR1TUFIdk83YVh0NlBYS25SUVFPWXpk?= =?utf-8?Q?gldYwEOcureNdH0xoFHD1cT6G?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f6f7bb4-bcaf-40fa-dc49-08da70676c41 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:04:33.4514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LLoAud4vmsPqwV1rCeNPI9fW2C0QXEv6rISLRUWZXbZS0GH0Kq4c/VLQk7kqi2/zMKsiLYGngEH1suBHtExsGQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB2847 On 27.07.2022 19:06, Oleksandr wrote: > On 27.07.22 13:19, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Take into account guest's BAR view and program its p2m accordingly: >>> gfn is guest's view of the BAR and mfn is the physical BAR value as set >>> up by the PCI bus driver in the hardware domain. >>> This way hardware domain sees physical BAR values and guest sees >>> emulated ones. >>> >>> Signed-off-by: Oleksandr Andrushchenko >> If taking the previous patch as given, the patch here looks okay to me. > > This is a good news, thank you. > > >> But since I'm still not really agreeing with what the previous patch >> does, > > Previous? Sorry, I didn't see any comments given for "[PATCH V7 05/11] > vpci/header: handle p2m range sets per BAR". > > Or do you perhaps mean "[PATCH V7 03/11] vpci/header: implement guest > BAR register handlers" where you explicitly mentioned concerns? No, I mean the previous patch, to which I had given comments in a much earlier version. Roger looks to agree with the approach taken, so my comments were (legitimately) put off. But with me not agreeing with the approach, it's not very reasonable for me to (further) review that change. Hence my deferral to Roger. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:15:30 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:15:30 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376635.609530 (Exim 4.92) (envelope-from ) id 1oGxjw-0006Pz-TZ; Thu, 28 Jul 2022 07:15:24 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376635.609530; Thu, 28 Jul 2022 07:15:24 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxjw-0006Ps-QC; Thu, 28 Jul 2022 07:15:24 +0000 Received: by outflank-mailman (input) for mailman id 376635; Thu, 28 Jul 2022 07:15:23 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxjv-0006Pm-NT for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:15:23 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-eopbgr130059.outbound.protection.outlook.com [40.107.13.59]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0b3a87d8-0e45-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 09:15:22 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8406.eurprd04.prod.outlook.com (2603:10a6:102:1c4::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Thu, 28 Jul 2022 07:15:20 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 07:15:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0b3a87d8-0e45-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j6Wfnin+9CQkebd4lt+u6v4B9N1lkclcO/XYsvibTSuK7zpHN5vJq0wP6NT+VdpSFO9LCVwa3GZsqZ9gSoNtkf/SQy2GVWYLoo7R/H/Ko/0bCrKVUNwiLuShVoc/CjN758BMrGaTqDR8PHDDmUD2+aeohax/I8HuDZkBi58nWJzBljUgr+IQN0Uh3jyRFpMd2hF0k5b2rqE5GCVk8xpKSWTUfcl4VSz88MM+lPbGIV1zNhNwEgzm5fHBvPBvtcBjH3nKH5zU0qgFYhU57934MBbMqNHR8ORd5Zrgwlo3BoKRVbO4Ow9tg827Qky0U2qH9kjQmgA5TxFhpqaIB8xnMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GdJki4lXX/9RXeJXlObYah0Eu7wwmTyIQJdhQdmEDsU=; b=HTuesXlDUa0jC+YV0nk9G6rz/vw0abRv8+Daf93RCd20RSudFNDVxGBwt7qf3EOhPW0rb4K70SRmeciBnjXi3u0cntIFI5vTaMWzrvjFAgOlH+hY0tb9mjr+NQXSpPWxPFxceDUlycdEuTDNn5Y5wTndt5kRj3emUCx2RBsVT/wRjy2Sao5YPdfCoFOoD5ef5F74Zk1CA1XhICF8doOr5LvHgQe2hg3IoGgsuje7uUNghbuKaa8TSmqR7++dPWKQ+9/4Vhp8Rh/ZgpDGYm51fxiuAdrk0bQOOH5bc5lO61KqviusKECSECEuf4S3BMkZP+ZlQdJvCmj3q0kxkZy94Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GdJki4lXX/9RXeJXlObYah0Eu7wwmTyIQJdhQdmEDsU=; b=1TeT2l5W/Gqoqw5pKzozRSNHJocErwoML66Fnqw8CPcejDSy9GFTHDbXW6OtsrzqOZbgn3QBjaaRH2o1blsiiTuxUzwKCpZFU6bcGs8zU2oWpYo+JJq2XhC4TQAkowH4itVe4SXHQcOokkLgn/XMMApT4OjXUBXR9P9+NTKs0XfS2VMBCWBqCSwT0H0GRIoAT9+YZ+eu9/dhMRGCM3h6mYfUswnAkEeqCwxblL/Lsf74GU9nKbDznIwXwHUDgoB/hemJ5HrpFCEVcSv/giwZfYozbLb8LMJ4TUEeRn4S/LrZpSzi/RyiZjsa+Qhq8WJgGx5OWgeRc4+7DLPOcL9R/A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 28 Jul 2022 09:15:18 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> From: Jan Beulich In-Reply-To: <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0111.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b566d3e-91ee-429d-1073-08da7068ee25 X-MS-TrafficTypeDiagnostic: PAXPR04MB8406:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wii1An8ZU32pKRMeRFxM1pMgfu58PhHA0+piv2wr9OGw0LAbIYK04kAMd2aQsHHsSp0tfpG9Cjj5IZK4xsAMdw+vzyqgrMbo8RoR/GMiKJt9lcG39TOMLiOOMPg0dX8Q/GY5LMeIqoJQv3criLP1QWBQKt+/2UgG9PoRLeVaNjLZtx2vb5KH6B+owJ4ag1FhEMgecqi1A2gwiNBktBVVLwCDRI/1oG2E1ZVna+SXK/u4C1rmRhvsqI7jvmBoR7NNBcXXI8cAm2V2iJCBa7hvqkODtvFouw2vzrH1OfL+pEyY6GvrLNRO0dI4Etammvljq3tZOJkLMquUrm6HEHWlixmxFf4JFOc0ESYz0sPCrYhEKS3WdP8fTb3Cb6abgy4AYJ9rWMGJieLqwGeMCynVPaWscENdWwwsrPN7eX60Ixxm1n+9HDrdPjUsike2Z7CTjOicioM9qI5V130djc6AjuVo1jSNzP+xfcxSHLvegQTdoE7zQVBvkriw77rkVo/9gl4SpbIznBQVCkLLmAstW4ZeMMHSTPLtMeBRIB78A8u7wk3vLdFl9RppHFtDf4j74N1a8Rm1Ty1z7M7+CvrUzHGKiOUyQE7hW8yxKhGrxa540F78q+6osWxOUMKIDPsIwEzsaVxdw75ESIRJlkP55oo/O6OM1I0PXGNXFyPKZ4uOjFaM3KI29vNNfJiWuI9sTtTrCU8ihu4tto0eUMDk9VvARcEWJZgvKulF7MQrEt3yuO/Uqz+iZ6SPfDmlaLssKC0aIjj4QBGXJpA5KbJKqnJq72gENGluicwDSrSav43CWZfmBwbnroZ/4juy7qDuVhcpR7Rr61fiWGkSQXZ/Lw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(366004)(376002)(39860400002)(136003)(346002)(31696002)(86362001)(83380400001)(38100700002)(66476007)(66556008)(66946007)(8676002)(4326008)(316002)(6916009)(54906003)(2906002)(8936002)(26005)(5660300002)(6512007)(6506007)(53546011)(2616005)(186003)(41300700001)(6486002)(478600001)(31686004)(36756003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVl3bmp6bkdTZ2FSYVEvbW9DVlB5NmRnV0ZZQ21KM2ZZTWpjSmR3ck56Zncx?= =?utf-8?B?d0RoS241aWlMak5BaDNWOU1selAvM1NGMEg5TEd4aEUrNmxaVkJPOVNzUUhF?= =?utf-8?B?Z0JoMnlhVUVJWktZV09hUUpraXNhU1oxaXRGaThFL1BDYVBjN09rWFYwSFIx?= =?utf-8?B?RXhweDcxOStxNk9tY3NKN0dpTXpmOG1Qb3Y2YmtwaG9kdFZOaGkvWEJVR0lt?= =?utf-8?B?VnVtRGVRN1cxdXh2dFRkSnNOdW84cXM0R1dtUm1PaWJwbitiV2g0ZWNnK09o?= =?utf-8?B?bVF3V2o5VkRCL2F4N3dNeHZldHlNK0VqelBicmtuSVNEOFZOejN6QUpjNWJT?= =?utf-8?B?aFVmUW5jMFJOOC9tN1MrVnV5L3VoYUI5TWJQTjRzTGZlUFBLQmY3NzY2TFd1?= =?utf-8?B?RDZNZ1N2bHhhclRCR2xveFd3eDZnVlFkOFphd2tyRWlFaWdMeTRaNUZpRi9B?= =?utf-8?B?MXlSdDdmWnQrcVkzaWlHNzNZSVA3eElIdTBEOGh3aHJIaEJJUFdDTjUzdGl0?= =?utf-8?B?RVVRVXZjcnUyejZFYWhVUGlya0h5ZCszeWs4THhyd2dSR1hjd0tKVmpqWmhH?= =?utf-8?B?c0RHVGprem10UXRWODV1TmVuNHRHb01TcjVuNDBJazJ1WVp2RkVUWkRWZFAx?= =?utf-8?B?RjZQcWtSSkVMaXNqQzJOWFJ1ZWZISFZ0VUpUY2NlR2dHNk84MCtvaEFmQzg0?= =?utf-8?B?bTF1NWMyc0VlSlQyc09Nd2l5ZzllTjBUejdQdnJUUzB1OGFHZVNsVXZaVWx0?= =?utf-8?B?S0pCcnhHOWRGVHJOSGNHZ3NEQUQ0OUtmV2xXcEZqbmcxZVMvNWFvTGtMeHlF?= =?utf-8?B?L1VEYXFoN3NQQkVvMnRzZ25rNnhISDBkVkdpQ1lIajFrLzZLaVZoengyOEZ4?= =?utf-8?B?RUEyN214Zk9pcFlUY080cXNsMXBxd1dlV05tK2hxUnl5OVE3bjNNWjVnNTVO?= =?utf-8?B?Mk83TXhabkxPYWRaQk42VG1IZ3ZuRkRvNjB6Q09OdDR3bll2cXZYWFpvKzU5?= =?utf-8?B?Y2x5T3VZazFDRVUvYkM5bWR2MzdsdWR0OWdUTWVtQmxSMUI2WVhHMDUzbTNE?= =?utf-8?B?bVNQcXZRaDUxUXRJNlBlVFV2QWxpVTdkUU5MSUg5VGlRVDdscnNlbncyNVIx?= =?utf-8?B?eDhCeDU4YjF0b3Nkc2M2ZU4rUkxqUVBYV1RFaHAvNGhsUHUvUXlBc09ub0hB?= =?utf-8?B?L2xxSTUxZEJBcDhaY1A2NG9TOEg5R0xUMzIzM1pObThpdHpFZHU0WXlLb0pq?= =?utf-8?B?RU85TEw4dmpOdDhoT1JlK3dtZWV5eDZCam5Mb3VJVG9kVXdlOTYvK0RGM0Mx?= =?utf-8?B?Q0ZIeVRFeHdFcjViZ0ZsUjZhT1pPNDZ5TGFQdWtmUkV2ZXlQamlwUDIya3NL?= =?utf-8?B?RWlXVEZKUkhZN0lMTHBFZmczeEJ0RXRwcXFpcGtFZW1zaURMbm0xdVNWcGow?= =?utf-8?B?ZHF1Tit1NmUvMHJMdFJEblZ4aGdLajNQVnJtdjhZMnZZd1h3SFZrUnRmS0ph?= =?utf-8?B?RHdqTXJtMUVDa2pWSE80QlREL2RCcExsNDJCQ2RieE42S0l1c1MvMmZNNThT?= =?utf-8?B?YUJ2TEdNRUxMR1MvdytuUTZDeGlDRDRVU3E4QTFSYnR2NnhEZ01sbmtvaFlZ?= =?utf-8?B?dHFEblV1TFpEd1JyaTNqUWRjNFJNS0VMUitqdXBBUWp2VWtlZm5QQUZyTktt?= =?utf-8?B?b28zbHdaNHlHSWlXRW5IK3lnS0lJelRkU3JzQ3AzUkJOTDRsK2ZiVHgrRzRY?= =?utf-8?B?VWRDMTE2YXBWWEFjMGsrb29seEdhbUUvdUlvNGZaYXVGOCtTd1NpaXJHVlBk?= =?utf-8?B?c3phQUxDcThSUW1QZ0dsaHJ6Y0dKbXJTaU8wcTlxS3VuVkttb3ZEekZIYkQ1?= =?utf-8?B?UlRPUnBXVmUxcWVJbmxIN0lvQUVKc3JqQkFCLytCMTdYRStqNEJSZnpFcUxi?= =?utf-8?B?cUN5RGd3Ym9PcjArM2FxejBRZ0E0UCtSOUNacnhJaFE0LzVwSU02S2ZIOE5M?= =?utf-8?B?L3R5bm5ONXE1MFJyTHROdnRJMTBjV3FWVlAwazJVSEFIZHZKUElkT29XaTFY?= =?utf-8?B?Rk1kemRHVmhpaWgyekM4enNlME5rUWFwNnA1bjBlWHNGNkdrcWdVSWJGMFdx?= =?utf-8?Q?pIoln4nEgb/Xc3pk+tsRkMWWZ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3b566d3e-91ee-429d-1073-08da7068ee25 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:15:20.2381 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ad1F+XNDEnKmQAN5sQeowuBahZxRumOQ51ILv3e4OJ8yNRgFlT+gvhiqRT7rLGDinsqjoyePCAu+ipPFXh4YFg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8406 On 27.07.2022 21:39, Oleksandr wrote: > On 27.07.22 20:54, Oleksandr wrote: >> On 26.07.22 18:16, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>> --- a/xen/arch/arm/vpci.c >>>> +++ b/xen/arch/arm/vpci.c >>>> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, >>>> mmio_info_t *info, >>>>       /* data is needed to prevent a pointer cast on 32bit */ >>>>       unsigned long data; >>>>   +    /* >>>> +     * For the passed through devices we need to map their virtual >>>> SBDF >>>> +     * to the physical PCI device being passed through. >>>> +     */ >>>> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >>>> +    { >>>> +        *r = ~0ul; >>>> +        return 1; >>>> +    } >>> I'm probably simply lacking specific Arm-side knowledge, but it strikes >>> me as odd that the need for translation would be dependent upon >>> "bridge". >> >> >> I am afraid I cannot answer immediately. >> >> I will analyze that question and provide an answer later on. > > > Well, most likely that "valid" bridge pointer here is just used as an > indicator of hwdom currently, so no need to perform virt->phys > translation for sbdf. > > You can see that domain_vpci_init() passes a valid value for hwdom and > NULL for other domains when setting up vpci_mmio* callbacks. Oh, I see. > Alternatively, I guess we could use "!is_hardware_domain(v->domain)" > instead of "!bridge" in the first part of that check. Shall I? Maybe simply add a comment? Surely checking "bridge" is cheaper than using is_hardware_domain(), so I can see the benefit. But the larger arm/vpci.c grows, the less obvious the connection will be without a comment. (Instead of a comment, an alternative may be a suitable assertion, which then documents the connection at the same time, e.g. ASSERT(!bridge == !is_hardware_domain(v->domain)). But that won't be possible in e.g. vpci_sbdf_from_gpa(), where apparently a similar assumption is being made.) Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:18:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:18:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376641.609541 (Exim 4.92) (envelope-from ) id 1oGxmm-0007Gj-G8; Thu, 28 Jul 2022 07:18:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376641.609541; Thu, 28 Jul 2022 07:18:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxmm-0007Gc-Cp; Thu, 28 Jul 2022 07:18:20 +0000 Received: by outflank-mailman (input) for mailman id 376641; Thu, 28 Jul 2022 07:18:19 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGxml-0007GW-4Z for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:18:19 +0000 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2089.outbound.protection.outlook.com [40.107.92.89]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73243da4-0e45-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 09:18:17 +0200 (CEST) Received: from DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) by MN2PR12MB3935.namprd12.prod.outlook.com (2603:10b6:208:168::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 07:18:12 +0000 Received: from DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec80:e3fd:e3e2:605d]) by DM5PR12MB2504.namprd12.prod.outlook.com ([fe80::ec80:e3fd:e3e2:605d%5]) with mapi id 15.20.5458.025; Thu, 28 Jul 2022 07:18:12 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73243da4-0e45-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OH2/21JpN852iGsRsRsJgZHyXPa78n7YWkigWDdoCm5rfb2lT0UL5l4EhlxSwBPws3gZA3PfLRNeihZCN7HAqmXD4xnPUUIm/J1lUuY1pIPhlNmiE5cH5Bk0YETciB6IDud9+OWqktHzpAnDxK5ZXACkMS7RxTJDwHynfPuQHKGqdfp9wXLsPSgQI1HHgSkJ7Ydy3QRwbAdOfKHNBQ9IBU18+5tIIiyqxRJV5zdtecEEJMdBLZ2oOnFFXjvXyMzapV6b3NdfS8SJGJFadls0CD7xFvtLU/xBQ+bSOSKMSWXRwtaBzqhT5A0+RBknJEsR1BAYY2dho9ijGJJWLkZSCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JVtWydABZS9UVNKHKOuqwYPe3aWGg5rbzuVhbSD4ULI=; b=KwUzJ4jhWtTd0i1G65KFRD0JRQVzNpFE/zGvPzLfxftBEwwUj/FFuGjo+FbHjE+ktY+m6+Zm3GLwBxmM/o8WrcnKKc5h2eVKaXR1hJHCfoZfoCymALEtr5+jc1AMknvfDypWgDPUjzCWEX5HeEppA/IogFCsM9KE2qtMx6jGpAQJTincg0z5qVlQJlpPwIjoKrrAVPhJVSN3gfuAFEMb+KuLdHNx4gNjwjbOq+1ZwAYTmvGhH+NxEhbkGIM7XJ4l34UwVwrTDMNWidVjYWQmANsCMbi/YIJeBemBQgt6uDWtg1HOo+vohrO5vfZywgeOhsWHTe94x6B+iz9jY2y3uQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JVtWydABZS9UVNKHKOuqwYPe3aWGg5rbzuVhbSD4ULI=; b=PnOIgGI188mq1nplPxBFjUeTE33ya/Z2/iVTX0FLF3syadDIaMITPfvs3aWR2L6HlZfcJaAsDN+dVymleKsZgqM12H/UkshvXd/8ghx7csawSsoyvIFlBALYBVRcPVSuvcQly2ZLyaHahG6kRRex4msSkq9leFzLKhoyKEkaIX4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Date: Thu, 28 Jul 2022 15:17:49 +0800 From: Huang Rui To: Igor Mammedov Cc: "anthony.perard@citrix.com" , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , "Huang, Trigger" Subject: Re: Question to mem-path support at QEMU for Xen Message-ID: References: <20220727101930.66ed56e1@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220727101930.66ed56e1@redhat.com> X-ClientProxiedBy: SI2PR01CA0050.apcprd01.prod.exchangelabs.com (2603:1096:4:193::21) To DM5PR12MB2504.namprd12.prod.outlook.com (2603:10b6:4:b5::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 75e122b7-116b-49ec-db96-08da70695505 X-MS-TrafficTypeDiagnostic: MN2PR12MB3935:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JxxMHokLlN3zmJXA13qIHOsvsOEYi1KXj1IEya4deqizHbsGO883Fu+10crgMg7B/ECRrQyVYZsME2z6Y4BURkiqhiV+XobV1xiXJkYNGlxfnwh2i2KeTlOUtoLn1aVjItidZBvZIYd1+eW/Hj/aTGwCJVbx3Em9svxRZHpcQI1O5V1K0AMaCYmjPdoHGS2qTKAwcHUbyXOg4mxAJYWfS0dVTN9a7i4gMjM0mgfqL7E9mP1rjJMj3K+iKdKUbqSHlBNG57nfMAsE4TevopFLfLdE0Cf16+YDKYZGm6vZQNsevT0zg744SXLCx4tODNlqFop4E88ZPrIWrPws2ht54WW3fvg3uX4n+RXwCbZQbXoCD/voXGhMLzrun+hr5jAy9sUMJInuv+Z3UpH36TqYHLcpEysN/godpo3wR33eW87Mv3tnKckTIYHzXq4543CUMK1o24NA0NV5EYe92c1PLzBuouUj6ye18iLKSaEmnjBfX/ob/Rj0IxPLmgtMiZ/HHsk8Fa/wP8sOkxVuL0jD6JNdgrrahQSdpcpXT0V7aQYvsGKV3pwZSrha9o2hm5rRKj3EaFBMn8eMEt0x93Hn+KAg2JWHf1YWfq8dA9jQ4cw51gThVqwwbjXk42ke65SHEKYJ1p9WU346uJGuAwXX8+DETLJovOvm2F+LVAfRb9KXKeBXJRF/yaJQEahc1yksz0ycQ3UcwTP/IGlUiPSWwdHPp19U//N7s/oZSxB6zonR5B1ozqwuF4xZs1/K9ijl X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB2504.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(136003)(39860400002)(366004)(396003)(41300700001)(26005)(36756003)(6512007)(6666004)(6506007)(8676002)(6486002)(478600001)(66946007)(66556008)(66476007)(38100700002)(4326008)(83380400001)(8936002)(5660300002)(2616005)(54906003)(86362001)(316002)(186003)(2906002)(6916009);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KEqfQ6Vifx4G6sz3S7Q7Lbs5N2ZlBkepJtyHnl6GmiBj5npSNUo8IvuesaLp?= =?us-ascii?Q?J8yj9shP7NdDO/sI8Rj4bl8pIyNFa7Eo/G2qURKswDHWwZex63Mr5GrbS+kV?= =?us-ascii?Q?2PZ/Fri5dmfn8M3pSwaocw8eHXPQdqNk2Gtf56xjnxXW35xKtDmh8JiavHdV?= =?us-ascii?Q?WqMiQ0ioN9NgYU8o9I21+xKbribsyWBRtQhXo62qolCPQCjmj0uiAazEUNsZ?= =?us-ascii?Q?ZSMn3Jf1A0jGGGW2lqYGHd4UzMe1agbLny4HvYU/UvRbTIgyAV0GDNFudaJd?= =?us-ascii?Q?34mquZzvKSJ05xLl1N7rpQAIXn7aiSxMWSUP/E7/l1nWcPZkItzBzvCARmvD?= =?us-ascii?Q?T8oN4YnVYVK2ULc36HsAtcTVGkM/HPoWMF4B+AsKVOczHw+vWFd+EeVgj1s7?= =?us-ascii?Q?wREN/d++dUCILX4yv1L6ft6ixGAnRFagmnwBpQ3cFj+LVi/lBoW2cbWGWbLC?= =?us-ascii?Q?UvKc9feEmoqu9C0m7fEwF2hZDQnsbQ3OiCjeJnI3/5pW5gKJLwXoEFxCn+xg?= =?us-ascii?Q?BpfSufYiZPQIYs57/nlm3oN/xyO58LQEltpHHL0xjJf4XH+Eb4FKKlDrztpz?= =?us-ascii?Q?5yXDt9+kYbQYRM+ppW5FljAenWz5Bu/BZRT44JZRlIlGXRuBz/a26UL4C3No?= =?us-ascii?Q?nqd8Ehvd5BmWN4aV53OsKnAKvvXHhBRtFyvUkdV3taev2Xbsvx06QgkURzA9?= =?us-ascii?Q?Slg0riC2npx73Sv8ztbrwsIs4oYjbsW8v76NXU5bdflAz8px4cpZTWRzAPsQ?= =?us-ascii?Q?W1ilqZgnWvmGRroRReDDgqvxS2kOL7vbHzFIHsCWNQBGhzlo518owAi+XqYj?= =?us-ascii?Q?GTh6wjPUTA4ycM6M7KWBOHbMbnOAwaCL31qfNE1lDiFjEL9VHbiSkY62A87c?= =?us-ascii?Q?+cqfWv9v0UB1tOBezTC3Gdg0TorlIMFimCoeXxbjp499Fs0eNaotj9NPUtdy?= =?us-ascii?Q?10sR2Zf1ubhdq0WTQPNebVfSVw4HYTcdNJatvG3hWxRYxu8n1iOr4kGXFBvv?= =?us-ascii?Q?GhDFVWyV28dw479ICxj/4fdj7G+r5ph5s6dIhSZra1sky0V/H+ksADR6rmEh?= =?us-ascii?Q?JdhjUL5/ymJjUU49gHQbcyV13V0gVNOmo3bE3euI9tiOyrFpZYn0qG0oXHQI?= =?us-ascii?Q?JRZUay/NThRmfBglkPBqUK9qBIl4e/sk8un11emMv9hPgPtDI5/k8NvZg9X5?= =?us-ascii?Q?GIg9oBEMy5duK7XvuBHYiA/afWBNwD2NTzOKCxImJoB4mM+nH9x42qqLUSpP?= =?us-ascii?Q?t18dfdVIAGr2G6YXQmDrd/joGFZgbAuDyPVrILQil8a6DFNFW/TZ9kQE8a59?= =?us-ascii?Q?ejtH8eG+y1JAv7c60VxFTLbZaan42fIrQ4Ht+3xsgDcPBsz75Esp7CN3+bMr?= =?us-ascii?Q?mmAopwKXQU9hmUgQutn8P5U1PKMKwGyPHUbODSYSGBf1NtoMFTVQ7yP+r4KO?= =?us-ascii?Q?eLJWmCRRNssyLxEsUSbLw/nIX31PfpzP80OxxQIjN7dXR5+eWA7QaPUHUxrN?= =?us-ascii?Q?eu+pzXiNNIjERS1d4KFI0EBMZG6CYo/gqQ+6tU9iA6iMdB6+NK9m9D4FbDUU?= =?us-ascii?Q?nMAMupKfPPknKb7P3Mawa2yiW4EF2o15pJRbuuYX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75e122b7-116b-49ec-db96-08da70695505 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB2504.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:18:12.8076 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AUHjGMhFxkTB/QGy2WCt9r2AHbSwJxuWmEL68dCbBB84dTGSP/1X9g/AQp32xQLR58U5Z6kvzT8dlaDIASNA5A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB3935 Hi Igor, Appreciate you for the reply! On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > On Tue, 26 Jul 2022 15:27:07 +0800 > Huang Rui wrote: > > > Hi Anthony and other Qemu/Xen guys, > > > > We are trying to enable venus on Xen virtualization platform. And we would > > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > > options on QEMU, however, the QEMU will tell us the "-mem-path" is not > > supported with Xen. I verified the same function on KVM. > > > > qemu-system-i386: -mem-path not supported with Xen > > > > So may I know whether Xen has any limitation that support > > memory-backend-memfd in QEMU or just implementation is not done yet? > > Currently Xen doesn't use guest RAM allocation the way the rest of > accelerators do. (it has hacks in memory_region/ramblock API, > that divert RAM allocation calls to Xen specific API) I am new for Xen and QEMU, we are working on GPU. We would like to have a piece of backend memroy like video memory for VirtIO GPU to support guest VM Mesa Vulkan (Venus). Do you mean we can the memory_region/ramblock APIs to work around it? > > The sane way would extend Xen to accept RAM regions (whatever they are > ram or fd based) QEMU allocates instead of going its own way. This way > it could reuse all memory backends that QEMU provides for the rest of > the non-Xen world. (not to mention that we could drop non trivial > Xen hacks so that guest RAM handling would be consistent with other > accelerators) > May I know what do you mean by "going its own way"? This sounds good, could you please elaborate on how can we implement this? We would like to give a try to address the problem on Xen. Would you mind to point somewhere that I can learn and understand the RAM region. Very happy to see your suggestions! Thanks & Best Regards, Ray From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:44:43 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:44:43 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376648.609552 (Exim 4.92) (envelope-from ) id 1oGyCA-0002OT-Hh; Thu, 28 Jul 2022 07:44:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376648.609552; Thu, 28 Jul 2022 07:44:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyCA-0002OM-EU; Thu, 28 Jul 2022 07:44:34 +0000 Received: by outflank-mailman (input) for mailman id 376648; Thu, 28 Jul 2022 07:44:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyC8-0002OG-Ic for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:44:32 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2044.outbound.protection.outlook.com [40.107.20.44]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1d11a36d-0e49-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 09:44:30 +0200 (CEST) Received: from AS9PR05CA0041.eurprd05.prod.outlook.com (2603:10a6:20b:489::21) by AM0PR08MB4337.eurprd08.prod.outlook.com (2603:10a6:208:13d::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Thu, 28 Jul 2022 07:44:28 +0000 Received: from VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:489:cafe::40) by AS9PR05CA0041.outlook.office365.com (2603:10a6:20b:489::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 07:44:28 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT046.mail.protection.outlook.com (10.152.19.226) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 07:44:27 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 28 Jul 2022 07:44:27 +0000 Received: from 10c67d2d28b3.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A79A3FED-A548-4252-8E13-1954450F25DE.1; Thu, 28 Jul 2022 07:44:20 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 10c67d2d28b3.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 07:44:20 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM9PR08MB6228.eurprd08.prod.outlook.com (2603:10a6:20b:281::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Thu, 28 Jul 2022 07:44:18 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022 07:44:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d11a36d-0e49-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=TzOGbTxrGHnT668Nl9x8u4HAOcXYxSnqro7b6XCS+e33TunDA1e1DH9ow4V87fVWjv2P0V+HIGtydcULblkoryKPHIarfqeq/rRytfwfdlMf27y9vzgeH665m2yw+RPx+mJrkwzG3OPs3LJ6LlXbsbqOX2dmkeWQTkRNlTym1be9QTx7H5R+G6yPXuMlzuaF+ie7OgcnRs0VkJhhYoUncpmaelmR/quvwmED3AeQHvJW9PRdAlJ82g20HzW3qwZhOiAAObh/ufEJ5yvPOVGprBgT3jWMODzsJElHr0jCEoWqStlJsch8YUChuKnp3pkx59GqcP7yX/Y6p3d3GwVi4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XrUADJBNWozHG+GIAokSBOrpOcYUlc9ScSm+9yKHsLU=; b=UoKHJehtqpybJRn2jVkrH7MhZjn7YlxFkj0GEi/cOSa+A1bLx6fLJwJOLlmPGVuHQy6FHCh4daZ7/yW3PMwZjM+NoYUGToaUDk5fVab7kj5JE03dR5DnMasFvn/BZHBsobHkzwMGDqWq0fmdVtNqQxrWqoUARJuaQo6x1LfH2qILQNp3vXWfENNYSHJA4V76cD2B2Jz/eFghCWchtsp4vFjIOgsY8k0iXSzxkpmf9QKOfY0N7DuX3FsrJ3b8zc4UwdYoLsph/i3a5rPhs1dZcP6OFbT9Ik7I3vWUqCGG38kfzKWX1bqH/u804Pb4YZS+BVu66atenREE4wyy38xRIQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrUADJBNWozHG+GIAokSBOrpOcYUlc9ScSm+9yKHsLU=; b=DWFszjmxdHWvVGznT1vHAbLnaQg1UhhaUhwDpyTNfic8x5XE/WkcmXztuxbmtzilNoq24m+peH/ZCMFMg0YA3WjfMpl4Qhv8Zeme1x8e8bQ6Qq3CEa3xSRRS1+A3EfIuH3LEz5IlcM6wDonrsJxubnTsveAEM0ig5nc1gmAtIGY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 97e52c562a3af1ca X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i9XQZoCBfouhFfm3Q/6ZEURpoVVg2HK8A2+7ZRbIzS2RGY/L9YwqjT3LC0yC5Tufn+jYwy5QwciujRgCwZmM1bGWg8U3qmq7ZCnYDMfmHw6kmJLuNXQ6JL62vigTj/exiBbbHmIJ+WvQLLbnJw/KNBZ0Dvl2WCHCcfvOOQelMRsdkDZgIuLqnkHdu2duOmP3DUNc2nr6TjrSEkrsAcZA7DUfOEU96mvVPjOseBPc6GDaz+rym0EpXGvFU1wik1EDapQhzc1NwsdtU02hBbvebHorkDY9YZkXSJmTpHr8qsJ0bfyRrsx2T1MWpcrl0xa1HvfKOrg/KDFwe2WnOgE0PA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XrUADJBNWozHG+GIAokSBOrpOcYUlc9ScSm+9yKHsLU=; b=O+dRkq86pPMcDgjt/k+onmXgorxI7PSJdKcGf4n2DZmqMEpEMaQHpfsqVBbjjMcjFBTRgRTMuh73Jl0GxVQwUlpzY2UBu7jsY5rsc9GVt1FgKpkMI2tT+/J8IxXbGxFJUq1HbwtGR+zd+cT9/V0Qya4C0OwOPqBdPu1FsxLKYaMDYdT11JgKk6a7czggXhNSf9btpLI7rlUbK135tq0hTdrXqgH1VQ5oTdlfs5UT4at1l0dBwEAinZraai0ijayvPlhAlrgjD7EsVxgoPlFWOqvmnYTjLRo9pyx8Or5B3z5IU4zMDzHYsXZffOtRARsfLG0qf9spu3rn/DIaTmh8mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XrUADJBNWozHG+GIAokSBOrpOcYUlc9ScSm+9yKHsLU=; b=DWFszjmxdHWvVGznT1vHAbLnaQg1UhhaUhwDpyTNfic8x5XE/WkcmXztuxbmtzilNoq24m+peH/ZCMFMg0YA3WjfMpl4Qhv8Zeme1x8e8bQ6Qq3CEa3xSRRS1+A3EfIuH3LEz5IlcM6wDonrsJxubnTsveAEM0ig5nc1gmAtIGY= From: Luca Fancellu To: Xenia Ragiadakou CC: "xen-devel@lists.xenproject.org" , "Daniel P. Smith" Subject: Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation Thread-Topic: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation Thread-Index: AQHYocxnMww85Hdpe0SsTcfV9898uq2TaBWA Date: Thu, 28 Jul 2022 07:44:17 +0000 Message-ID: <2899DC8B-39B3-41CE-B5DA-60350C8F0677@arm.com> References: <20220727151953.1125331-1-burzalodowa@gmail.com> In-Reply-To: <20220727151953.1125331-1-burzalodowa@gmail.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 18e2872f-196a-41d0-de61-08da706cffde x-ms-traffictypediagnostic: AM9PR08MB6228:EE_|VE1EUR03FT046:EE_|AM0PR08MB4337:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: hP6zPl2loZf6rjtWzCHVnYNOs0qpeLSHWcoWy13ydqqq0XHtUghSHV2lO84GlMbAKZhVXl6JY+SOG0WxLfJJfYRhBEir7l2FZZfK3/3OhVF4d7jB89j7oAFsI+Wiw/BfT2zo6NhWXHSNE+uaUdaJvsrzZGxsde1yCxs1c5U5OPU8Nc8Y+rrvyBhWceB4r+uZeS/bNTNvOkj+S7BIxXXhOtwz31fiWE8AdMETsDkuW7fEkOZtISoOfioXM/temyHpEzKuIX0iAPIW5YaPqaM81iNpEyr6zoxI7b82rdfX8nSvEp+tRZDX3T6qZ1hn5Cjt2bCU+HB2jM3Ko/Gd71bg0ZI+Q454Mv9gVdGOUj/gFsh/H+Y1jz+1se5JCfxjdWBWXNNcC4/X2C6TbWpYKsHHP1t1dRv53t9tc0wygkLsDLa8ZFuj+D3epx1EMfaZF8wlecUUKsYBBuprSH+abq5NpBk+oP9o1pgW92Ari/Aks/hkpsLOJmykXH9BCYK28Y+XHkBYjCGcihtq7QhkLmSZyMPZGI6FYcpuP3ghyZ38KR+FJXQnAXLG0lnvkNsD52LQznXl0VdK6ANsfSDUhG8BeM1JynJwpSKOBBS69FNRJk5tDc9NWO0uEHbQZHG20iBWf/y7fh+D6EaEOYJjnw/QRuvLdbKykPadmoWzbhlDzvO71GlPXS9eJnCvotT7blWNypC/HF8QQnMaI6RO2v2qH6Sol1g7WLqn6xlRQ6kGE8zGtwdxP6/Woa720pTwk3HWrV59bXX2QaWQVj7AbGEexnALkO8uHhSkok2iqgmdGMsyk9GnfPXUHq4jJN5KPQQfu0RsB9D0fljP7KXVI36L2w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(366004)(376002)(39860400002)(136003)(346002)(86362001)(38100700002)(66476007)(38070700005)(66556008)(66446008)(66946007)(76116006)(64756008)(8676002)(122000001)(4326008)(316002)(6916009)(54906003)(91956017)(2906002)(8936002)(26005)(5660300002)(6512007)(6506007)(53546011)(2616005)(186003)(41300700001)(6486002)(478600001)(71200400001)(33656002)(558084003)(36756003)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7E079A4025C4714A9DEB294E3772A0CD@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR08MB6228 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: caafb22a-6b23-4af7-6f0a-08da706cf9da X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGMSQs7VPPk5DrSa9UwXqn3gGON//JmakYBYTJnzEuq+JdrcoVibhYdAfckQ2Eu62NjCDkuHrR9GkFrxcBslMS66iQaP/yZjDEQLEPjfQs+KM4Id1DrOU9GmJru8rSIwGdcT1BM8UE5b3k69f3xGWjDmXCyvkWs1iG81A7BR1fHVqd8OK0ucsmmV9HxVTx7/ma6QX6k+TYlZAnUOlVyd1xG1iksRo6mCbiHFJX49ofvxfADboUz3/ipBOyNyW4USclg7me2bvxNoUnixAOCX/orVChQ71qtc1hTNb0dZnazmDEGVogEAMoKcb3RXkwIbdqGSM+xmQEeTGhuFisJ2ov3uN2AY76aX4VHjJY0CPUOeziiGFUYFRMnY+xdd38uG3oUo+watDafCfghYXm8c4+TKz+YPkakNJSCZRwyTsNRUxetsLvtfdTjy2qkI/JJQhu0J3aTdrqED7tZNJmkdCNqqKuDHQHbgmcDSXcGPABrcSF2YY0WbIqn/p+z0aYcn67RdV4engttYXXNmJRX3BW5WbBCykusNqbCkxpVSQbZFnhpqEe7CO5WTSx7u+YzP/oXDxkaNiWsdW4Q64UoMbGAuADVBlSvd3Rk7aSJJM8xdKsiI5Ic/5KV4DHFAAtrdaSX8BvJpgcaQTs+W92lQhxvE8UmBLSzN/Gsoq1zxH0U4mG+GsjWtEnjHgaghMn1Xw7moEqJx1xFZPap8ZwSho5hnh4KbJh5DRRvsNfyx2U+ck9oTSHeccZHzOAxxAKY1QRE0LmJbW48BnWT6YsjM9OBfgh8Ip9LHN6xyedD+6rxEKPcZOz/Ei6JqUJHw1r9Z X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(39860400002)(346002)(36840700001)(40470700004)(46966006)(36860700001)(82310400005)(53546011)(8936002)(86362001)(40460700003)(356005)(6486002)(478600001)(316002)(558084003)(82740400003)(81166007)(5660300002)(33656002)(107886003)(40480700001)(47076005)(70206006)(54906003)(70586007)(83380400001)(4326008)(186003)(2616005)(2906002)(6506007)(8676002)(336012)(41300700001)(26005)(6512007)(6862004)(36756003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:44:27.6823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 18e2872f-196a-41d0-de61-08da706cffde X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4337 > On 27 Jul 2022, at 16:19, Xenia Ragiadakou wrote: >=20 > Protect header file from being included more than once by adding ifndef g= uard. >=20 > Signed-off-by: Xenia Ragiadakou It makes sense! Reviewed-by: Luca Fancellu From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:57:24 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:57:24 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376654.609563 (Exim 4.92) (envelope-from ) id 1oGyOV-0004ID-Mr; Thu, 28 Jul 2022 07:57:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376654.609563; Thu, 28 Jul 2022 07:57:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyOV-0004I6-K3; Thu, 28 Jul 2022 07:57:19 +0000 Received: by outflank-mailman (input) for mailman id 376654; Thu, 28 Jul 2022 07:57:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyOV-0004Hz-1B for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:57:19 +0000 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [2a00:1450:4864:20::635]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e66f4fb6-0e4a-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 09:57:17 +0200 (CEST) Received: by mail-ej1-x635.google.com with SMTP id va17so1894633ejb.0 for ; Thu, 28 Jul 2022 00:57:17 -0700 (PDT) Received: from uni.router.wind (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.googlemail.com with ESMTPSA id w26-20020a170906481a00b0072b4da1ed9asm99716ejq.225.2022.07.28.00.57.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:57:15 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e66f4fb6-0e4a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6S9vbWXJDGLHN0JT0DaEmuF3WQSnBWY9TAd3JcK8jJ4=; b=cfBscJ7L5Dp7UgSi8DXoSjp0aqOPpe4KGShS9oRQBP4Tx+Zux3XswNBMPF3E08QEA/ V1bEAQPM38kyL1+y5V3MeyOJGehADiXH9+Rs7Xwewz1NpZedlkExEjyLdpuYpxq1EOQs N2v4uWxAmzCdCGnKAPR0N1DVphp4tdGS6fMjSjvxRGFq1wM4aYxqqdBN2CJ/q6fHorEG hpH1UPCu6A9nbK5o0zS4GUVlVUpTM38LC9bBt/1MrizTLWZS9+Li5FgbSeI2uebqHDdR IWWOb73dvbQm84X1b7nppwrFqXpdkqxD1zkxmU28nCVDugeS09X7Y7SFe50ZpM8zfexh tTdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=6S9vbWXJDGLHN0JT0DaEmuF3WQSnBWY9TAd3JcK8jJ4=; b=JPvso3oHnvwULP30rj7Jh8/WhReTZszqWRwMe3khHP8L26GPIxdDPINMEWayEGwxy3 V7AJuxcAmhUvQYC0VqjuxZH2pCMG0pc1b7TR4ckRnYj69c0aktHUpAP2WP90lLXZe2SN H+vy11lIdVCLS02vNnVZKfBQ7wVOj1KNegrYQtqSVxPPETLAyAPCHqVwgRlRDhqsRgVA KdtaHhrvrtafBW4cRXluUFDRDks7SDkJMd0OpgGEbQ2SHf4iIpSBCOXjcjmuGHz4wZxz T5VfCuApDwUFKXaHpCX93HzIp9f/qPwCVUdw0KJXOu7PLl/UT5btIjwtIkhCfJg5Tl/F /REA== X-Gm-Message-State: AJIora8mZe8bT2krEDtWxpXPCLJC4JNWYRWFt9CsUmJPUgBAPcdwXk44 UwSmIeArleoEJKmTVPd6ZhRtQst1qw4= X-Google-Smtp-Source: AGRyM1t+/flxtA298czkQLBiuBgoFtzGQZltUeC3b5qfRow5CyGVH3NkVgYYGAOJ1fq6So4po0g+7A== X-Received: by 2002:a17:906:7308:b0:72f:3294:8002 with SMTP id di8-20020a170906730800b0072f32948002mr19642706ejc.311.1658995036631; Thu, 28 Jul 2022 00:57:16 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Date: Thu, 28 Jul 2022 10:57:09 +0300 Message-Id: <20220728075709.1175445-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function idle_loop() is referenced only in domain.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Add the function as a 'fake' input operand to the inline assembly statement, to make the compiler aware that the function is used. Fake means that the function is not actually used as an operand by the asm code. That is because there is not a suitable gcc arm32 asm constraint for labels. Declare return_to_new_vcpu32() and return_to_new_vcpu64() that are also referenced by this inline asm statement. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove the 'used' attribute and pass the function as input operand to the inline asm statement - declare return_to_new_vcpu32() and return_to_new_vcpu64() xen/arch/arm/domain.c | 2 +- xen/arch/arm/include/asm/current.h | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b5..780b6bcfaa 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -63,7 +63,7 @@ static void do_idle(void) rcu_idle_exit(cpu); } -void idle_loop(void) +static void idle_loop(void) { unsigned int cpu = smp_processor_id(); diff --git a/xen/arch/arm/include/asm/current.h b/xen/arch/arm/include/asm/current.h index 73e81458e5..225e00af71 100644 --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) +extern void return_to_new_vcpu32(void); +extern void return_to_new_vcpu64(void); + #define switch_stack_and_jump(stack, fn) do { \ - asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ); \ + asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ unreachable(); \ } while ( false ) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:57:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:57:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376659.609574 (Exim 4.92) (envelope-from ) id 1oGyP3-0004oe-0E; Thu, 28 Jul 2022 07:57:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376659.609574; Thu, 28 Jul 2022 07:57:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyP2-0004oX-Ti; Thu, 28 Jul 2022 07:57:52 +0000 Received: by outflank-mailman (input) for mailman id 376659; Thu, 28 Jul 2022 07:57:52 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyP1-0004d2-PW for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:57:52 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id fa69b95a-0e4a-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 09:57:51 +0200 (CEST) Received: from AS9PR05CA0021.eurprd05.prod.outlook.com (2603:10a6:20b:488::17) by PAXPR08MB7573.eurprd08.prod.outlook.com (2603:10a6:102:24f::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.26; Thu, 28 Jul 2022 07:57:49 +0000 Received: from VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::24) by AS9PR05CA0021.outlook.office365.com (2603:10a6:20b:488::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 07:57:48 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT021.mail.protection.outlook.com (10.152.18.117) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 07:57:48 +0000 Received: ("Tessian outbound c883b5ba7b70:v123"); Thu, 28 Jul 2022 07:57:47 +0000 Received: from eb55467d1661.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 59E68FC7-B25A-465A-962C-B83BD5225E2B.1; Thu, 28 Jul 2022 07:57:40 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id eb55467d1661.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 07:57:40 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DU2PR08MB7311.eurprd08.prod.outlook.com (2603:10a6:10:2e6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 07:57:39 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5482.010; Thu, 28 Jul 2022 07:57:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fa69b95a-0e4a-11ed-924f-1f966e50362f ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=iSBo+fpXSzwvfqwXLXTqkWs8g1+q7iojx0wQbXJAmXMS9RZS1iiCfV97HZyR9u83LrCT4jZYmCqencAzXtXgDtvam4pqIIIHwqmrnwJsFZPGswUYxTkpol25VKgngRcnW6oiq1Szc32ytSJ0ZdYs6fDKSkHTsdmvJ8ZjMMRZiG90ROS6ZbdBrqPVVxi1LgXuY4ZIujj+nh+VnY4R7KiT61aOnqOs4Y6QxuVPFDyva6cV6iWwE2lg8TwEaUfmragkwnc5vDTDukugUnHXos174d9rz2+ueUZD6rtYok5Vt585XH4rIyDxJFeyjrxAV9t5wAEszcVjiVJY2bptxCDGDQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=SWHqqpO6bUlDCvSl68yzhRmSWf3qAvTkV4rTqozw8A27e2BIWEYy3OBQXJjXsvXTsO5zD4yBqoqILYRcu/WfyzYVfTRqInscfR7jwkR0LllSO0FFQ7moawu4DzRztuIzlnpnDtry+H47zkRy+O8PtvV+tQDMo459NXcF8PwJf3ABZKVqUGLJNuCJfdfopqV8POw7JrKdhebWCg7tj2Qymtnz9R8hk4/xGv3qHuJwwPeaKYdAhlFK2L11jfy5puvgObhwKs1/+0rcHXbaj4rGQQBH9y/Dl47x3jGqt2+jODa4g6o8zvMdMVDo3YxRzBWh4ph5EtNoG/nWbtJWI5sNmg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=td5hE+R4P+ZqrxMfYMfDTjlzz6zQdLvmSgLT4HFtqTAwWkNYzAk3mlnf8rUJyzOuU6BGezwVfNhvIzrH3mT4YNx8w/9zMrra+GPcr70PXGmCHY/bLgMMpGHMSDXyaWYXQIfw6vDji5qyZ07fGF1raNycTeF+/GPW+2meKQDv8N8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: be3c35da8464cc35 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ijkgkTJtJwcVeQT5OixMMp277xf8AJAxvZiCE+HHB45pxliGyayeYymJ94kwQ2y3OWiXdiPkAPXiGszNx+JxuBaDVcSLpbwRJbETiBNCiukZuOZkeYXawjiaxLcXknAPGtqz3GU7c0KhCIFVtZJZG97Fu8AbhgwnH0mYpC4cQJK5E6UK9NXMeaE7BxNwHaOUiKC5QvCZsDYuTFq/M0qX17AqpGqJhzBqIWS9d42B4mJqjomSwm0i77zY+4djj8cgvOtvifLugHZ3Ch0JgI3yV8nATYxmAqXZetnQukU6LZSpxIPalSab5gn2acKMV0UdiGRgcH9M2N/T3XKeIGCAWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=RXh8Z38jrGg5mg8JmO0sWYuohTiNIMm43F3W+H4rw7PrboW7SroRLh1lHhl1FuFe/tu7j3XPDknzrNkOMF4CUFUfCHUY/btuoLy5uYoJPr9oB+66di6nflBXnY6WwNXbDx1r906gkZUsKuHOx4tBJl3ejeaIvCzb5zkpC/jjnY1OzpzpZfZDc4q4guKiZV8Hlg4YZJljWsutHf6IqDkAigLkeGgDEJwM21WvBerg7cf1JiEA3x1Hnqp4ZChWlAmLUI0vasx0z01u+1IOx6p5h6MH/WRRKHRSqtSb86lZHbQDt3ZDfKvsWqODpy/xdezcvVpntZakaE+jpSYK1aMU0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=518BQPcRIgn/1beATg9RVQUAzXF2X4/va0UYn3KBO/0=; b=td5hE+R4P+ZqrxMfYMfDTjlzz6zQdLvmSgLT4HFtqTAwWkNYzAk3mlnf8rUJyzOuU6BGezwVfNhvIzrH3mT4YNx8w/9zMrra+GPcr70PXGmCHY/bLgMMpGHMSDXyaWYXQIfw6vDji5qyZ07fGF1raNycTeF+/GPW+2meKQDv8N8= From: Bertrand Marquis To: Julien Grall CC: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Topic: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Index: AQHYoc45O9kZLijXrUyjjlrBuGCX1a2SXJWAgAEPNoA= Date: Thu, 28 Jul 2022 07:57:39 +0000 Message-ID: <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 611a8948-7d1c-4364-3a01-08da706edce7 x-ms-traffictypediagnostic: DU2PR08MB7311:EE_|VE1EUR03FT021:EE_|PAXPR08MB7573:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: E5utZcJvsg/N8COfmsyI0KPVXrOWPMer38ETWQIiYOSCPtjk/sRD9erU9SAxSUV8rG3/tcUjNf7lm1awl/1rHBDQOiskGgAYIOH/pgm7GSVCMWTcm31dqMIUzO3PzxQ2SGHcNh+R/MLrj0NaiBAq3vmjisCMHZRvGWVDtNch5Zun12N78ywJcOzulotLvgpBzIz3IWRr4ezkxihXp/NW7Ui39E44Gu1HDGlH6zRsFfcDAd1KRgTqn1jv7XjdfwsK0JvcLb6iU2opjAnPotnydPj50HFsgqFUBrCUBmgI7qbXggZMqo2x8wQ/ZlNhInunEpiMI367XrncqQ7m8rPQ+xD+AGkIRtGpa5JkZELqZEVnJuLClWIfJsCLldw4b2nStD7AL8XWSNg+3M7QG+WeqiWq741JFZKG0BtmIt6znGO9zFI/525wuFLps0QI5szxD28y0gazLIzADEaBJOpwQLSmhGxnLSM6aV7PP5H8/ya7u2bZMbEOyP2gtfX8TKntwqH5DD0HJZzHM/8cbOz8/xQ2SGmgKo2YXqKbVAWJo5U47OoyDT6CjVdbj1UGOYwfKZjNvFww7W+ji0kndjzRaQobUE9aK9jUqbXVuwVVYwKWPtjeAIeMY/O+zvqqxqVfNULZdyWujf40wdYYn9+XyCEJ+Qu7pUmxplTP9jkQze9lZ2zdD1207TYaIuJA3cJeNVW6C3Q18zg632H8Cd+9m6F6sh/7QMVB1dO0lB03gpFTnvkwGrFEaAdgFVZpqZqncVRlBgYqMt74NfQ0FyrgKUMura6O8j/tCaJm61hRzvXkgawsC2MOwzNtm5RikJ7AGcjyhlSGPvMmFDvaW+7H2A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(366004)(39860400002)(136003)(346002)(71200400001)(83380400001)(6506007)(64756008)(186003)(76116006)(66556008)(316002)(91956017)(66946007)(6916009)(66476007)(54906003)(8676002)(4326008)(36756003)(8936002)(2906002)(53546011)(41300700001)(66446008)(86362001)(2616005)(6486002)(26005)(5660300002)(6512007)(478600001)(38070700005)(122000001)(33656002)(38100700002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <7D9B5649B147894298367099E1AC6736@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR08MB7311 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: ba12da40-2f8e-4a06-bf94-08da706ed782 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rWZTQeQUa47e79Ot2kSHTKIU8DF2rAhrPf7vR2ociPPymkNMLnqAraKyEBSPuoqbQ+opYMhTnrLtU6uObQvgu4zMHuv8ffWQiab1ZHubSGAfxD4FKWOncxi9Zt9oW27v/PC5ETxHBb8eLYX3GZrozT4CwTDS5wwJyYHs373LNaNgfqtTCunL2ngYgXJksSW/XjN5h5+94XO8//4FbeeEwy0YVIxuaSnrsges/9jQk4H3DQAJyueg4FrbnkP3nzDHqdlgZNRj+eUFC4wqRpAS4v64fbOUt354koHHaw+dBLVHEta06mifcge0+x1SfyhdQtj1qlvXU/dil3pxgKNKz30Msy1bgrQ2L7KXWHJl05110xcDYET6GKUVzyrMm7uM3FIZ8uskAq9WMulf4xgdrCRPmCcQMFTTOUeQQF9p/c+Sj0oLHBmJVWxFt10EUccMVq7NS0fXcfytqsb8FFGZ/LbhOjDW+fAjkvBqe20a9Ies9z1uH+0VMwauzTIUc93pFC++RqBAb8OIY3E+qhJH9cIRSwkW+94iBSiJYSdyCwjr+pWYN8EXbiikd3P4uumtSRRDnX2pFHs0ncSUTp9jW4+ugrrQRyBJ6Krnfcq9yTFFYGLxD9wZ8BHas10mfNYx6R3iKs4DzhGMXzTPhe6C0L3bR/1h2ps7iepJzUSDBozcZmacgu8O/+xcSstxtLqjsA4OYJx2V7+ogxgDlNbAAS8yfxrXIi8DWrDO9elYuAMwnqUdf50+AaU/zwk5dZpQN2XsqhDBzdacuvh4QIyBm1ncJRSlsC2Ve8hu+9IgYE6QdCBefeZWITZ+si2wA5rm X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(36840700001)(46966006)(40470700004)(40460700003)(82740400003)(36860700001)(356005)(40480700001)(33656002)(86362001)(82310400005)(81166007)(6486002)(478600001)(316002)(5660300002)(6862004)(8936002)(54906003)(4326008)(8676002)(70586007)(70206006)(336012)(47076005)(107886003)(2616005)(186003)(6506007)(83380400001)(53546011)(41300700001)(2906002)(36756003)(26005)(6512007);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 07:57:48.0107 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 611a8948-7d1c-4364-3a01-08da706edce7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7573 Hi Julien, > On 27 Jul 2022, at 16:46, Julien Grall wrote: >=20 > Hi Xenia, >=20 > On 27/07/2022 16:32, Xenia Ragiadakou wrote: >> Remove unused macro atomic_xchg(). >> Signed-off-by: Xenia Ragiadakou >> --- >> xen/arch/arm/include/asm/atomic.h | 2 -- >> 1 file changed, 2 deletions(-) >> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/as= m/atomic.h >> index f5ef744b4b..a2dc125291 100644 >> --- a/xen/arch/arm/include/asm/atomic.h >> +++ b/xen/arch/arm/include/asm/atomic.h >> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int= a, int u) >> return __atomic_add_unless(v, a, u); >> } >> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >> - >=20 > While I agree this is unused today, the wrapper is quite trivial and part= of the generic API (x86 also provides one). So I am not in favor of removi= ng it just to please MISRA. >=20 > That said, if Bertrand and Stefano agrees with removing it then you shoul= d also remove the x86 version to avoid inconsistency. I think we can keep this and maybe add a comment on top to document a known= violation: /* TODO: MISRA_VIOLATION 2.5 */ The FUSA SIG is still working on defining how to document those in the code= . I think I suggested one way to do this at some point but the discussion nev= er finished. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:59:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:59:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376665.609585 (Exim 4.92) (envelope-from ) id 1oGyQB-0005UJ-Fl; Thu, 28 Jul 2022 07:59:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376665.609585; Thu, 28 Jul 2022 07:59:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQB-0005UC-Bb; Thu, 28 Jul 2022 07:59:03 +0000 Received: by outflank-mailman (input) for mailman id 376665; Thu, 28 Jul 2022 07:59:02 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQA-0005U6-Bs for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:59:02 +0000 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [2a00:1450:4864:20::535]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2444d247-0e4b-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 09:59:01 +0200 (CEST) Received: by mail-ed1-x535.google.com with SMTP id v17so1179959edc.1 for ; Thu, 28 Jul 2022 00:59:01 -0700 (PDT) Received: from uni.router.wind (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.googlemail.com with ESMTPSA id l2-20020a1709060cc200b00722e4bab163sm105413ejh.200.2022.07.28.00.58.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:59:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2444d247-0e4b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c3TxKve5pKEJCP5h37jSixpvAyP6PRIDSzPuepm/z4I=; b=h8Nek/xFAd9+FaQ2zpvTNk9u1oFpYkDVzEDUw/+NMqyImOX26wSgKsTXCgjj/ifsdp Hs1eQH3GV2Ed9xN3fsuIXwZpFJ33y7RSQd5oOplxJB7rjlQ0fik1yMOwTPhcW65ZqlvV lJPUsxbvXFrjpZ+d7U55e9OJrwD/pzeEuB34BVpQtYTwmhoED6iXk0cVIhQsTndttBRY 35ZgPnOsD8GzRR7kelsq90B38BCTuA/wh2jixWtnfHhwrJLyT2+y4jlAJ7AR/NbHhKrj qX53Ha2ewx3+eGwfCwkuxiRSaIo4DrpNB/pacKRMRYplIzLjVob7NeYGQkhYXsOH+0zX qFsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c3TxKve5pKEJCP5h37jSixpvAyP6PRIDSzPuepm/z4I=; b=Qp9rYs36DMl+UGNbEbDVubji1kxt0z1e0ztdKcpiftjl9v+YAwptyIYR42PCS9Km/U msXBYbrABHJrWKnSnaDwH4jpDtEoq4FoGxATOCO0Lm8UmMpRbHBvMU6icBXfJU52uEal qq+fJ+sCQzK7RmG/2bS68rSNXi+uEblaQ2T0qt2FzMSjVA+KSgthYk78J8m8L5sBghaL i8P32vXPqH+r/q26R4SS41ucDKBI1uWVZNs7a2JebTk0FBJ3M+2A4fT+bI1pdfV08HPR W5uYQCH44vFgwEIifZ9A3ougwUOpZM2cWtfnVgRfX3mk4AAnSdqoym5zK8aeLixkLYsz H6Ug== X-Gm-Message-State: AJIora+xR5RH3O1/ZtjobcCOJXsPplCBIppKlb1250hsTe7LQDqrdoZD drm846EukbmLZVIdspong7ALcHLRQ+E= X-Google-Smtp-Source: AGRyM1t86kLTof2/POweXLjj+Z8VujzUS78wBLNcE8N03jtK5IKhGQq2VZ15ePrqte6leyJYAvZzEw== X-Received: by 2002:a05:6402:529a:b0:43b:b8e4:fca5 with SMTP id en26-20020a056402529a00b0043bb8e4fca5mr26749539edb.344.1658995140612; Thu, 28 Jul 2022 00:59:00 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 0/2] Create a test job for testing static memory on qemu Date: Thu, 28 Jul 2022 10:58:54 +0300 Message-Id: <20220728075856.1175504-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series - removes all the references to the XEN_CONFIG_EXPERT environmental variable which is not used anymore - creates a trivial arm64 test job that boots xen on qemu with dom0 and a direct mapped dom0less domu with static memory and verifies that domu's memory ranges are the same as the static memory ranges with which it was configured The static memory test relies on the existing qemu-smoke-arm64.sh script. This script uses the kernel-5.9.9 from the test-artifacts container as domu kernel. This particular kernel does not work with dom0less enhanced enabled. More specifically, domu crashes when it attempts to dereference the xenstore interface which is still uninitialized, So, qemu-smoke-arm64-gcc test, as well as its static memory version, fails. To be able to test, I had to disable dom0less enhanced by adding the following commands to the script. sed -i 's/xen,enhanced "enabled"/xen,enhanced "disabled"/g' binaries/boot.source mkimage -A arm64 -T script -C none -d binaries/boot.source binaries/boot.scr These commands are not part of the patch. Since dom0less enhanced is enabled by default, a newer kernel version would be more appropriate for testing dom0less. Xenia Ragiadakou (2): automation: Remove XEN_CONFIG_EXPERT leftovers automation: arm64: Create a test job for testing static allocation on qemu automation/build/README.md | 3 --- automation/gitlab-ci/test.yaml | 18 ++++++++++++++++++ automation/scripts/build | 14 +++++++++++--- automation/scripts/containerize | 1 - automation/scripts/qemu-smoke-arm64.sh | 25 ++++++++++++++++++++++++- 5 files changed, 53 insertions(+), 8 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:59:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:59:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376666.609596 (Exim 4.92) (envelope-from ) id 1oGyQD-0005kn-N7; Thu, 28 Jul 2022 07:59:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376666.609596; Thu, 28 Jul 2022 07:59:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQD-0005ke-Jp; Thu, 28 Jul 2022 07:59:05 +0000 Received: by outflank-mailman (input) for mailman id 376666; Thu, 28 Jul 2022 07:59:04 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQC-0005ej-ER for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:59:04 +0000 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [2a00:1450:4864:20::530]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 258a63fd-0e4b-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 09:59:03 +0200 (CEST) Received: by mail-ed1-x530.google.com with SMTP id z18so1137421edb.10 for ; Thu, 28 Jul 2022 00:59:03 -0700 (PDT) Received: from uni.router.wind (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.googlemail.com with ESMTPSA id l2-20020a1709060cc200b00722e4bab163sm105413ejh.200.2022.07.28.00.59.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:59:02 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 258a63fd-0e4b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kwgwn4nxDPHONxfpv9ST7ryL+LvQhvZMH1dAza0ugw4=; b=jxd1jcy1EJS/n1CrAeDDR7rQZpPPusX//xpWTC0F4BeuwvRVdc96VHQ/vETtXAd7fQ k/ElpAHARj+YsIDek8vlqt3KmJoasOVWfrK2oBeCMC9qsq3uA6zfa1Kk8DpZgxCB7Rsz 3vmhMt7Zi7gt2JLJpW0yCEnT6Q5dFeCdiZaOGah3LgfYGUsqmCk/ExewOIblISlKvpFW xLVdJS2RcpdWbNk4ZxxiYnAKcjYR8ZqDQtEQwshQGCERy9U2dcalrwjZD+rug2hXydc0 99Q2hpJbI0+l412uDyKuEjTGycIr3GMsqOSkzDfivGpbTfAtVwoMXaZ5SPXx+2Di9gUu bWEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kwgwn4nxDPHONxfpv9ST7ryL+LvQhvZMH1dAza0ugw4=; b=du5T5MO4rvSS4o+rHOLbXlnNERPIY41LVcaxYeIaigo3gx/YmPFlofRV8WE11VYKbL GpTYW5k/cLzynEoosLRY1FBPL62YTNT1h+R4wcN+h++XJwyCTtE6HMGKlxVTrQrBGRCz Y6s2R24pSYc4N7WuS3/o8DiwrF6r/bBBiyUkfsBN74iq1uIBww1nNGBYBw6P9uQRKEfO giABT1zrmA1C9NAuZSxTTEY6lsBPKJJkyliuSsgeoJYh6doZaMAAFU3BtbyIlLC53nNn TUgxOiTztY9E7GATwGQPe0YU9P1PPdt8L420CW4IcmthUUIbNyBD/eJ2YWtaMOCobjgP RG3Q== X-Gm-Message-State: AJIora+oIJiMuxtr3X1woM7quEouCIHDQcwjqq6a7xyKDk86hRnR4gZC 6NZo3mUIZs/EtoWJUxx2pZBv3/6UCrg= X-Google-Smtp-Source: AGRyM1txKVD4jrGj5FhdZ0+s6cFNOSlkkgdZ1++x7l43ZviyW333xQ9oQT6rQ0X/+6NCfXUHh4h9cQ== X-Received: by 2002:a05:6402:194d:b0:43b:f21b:e9f4 with SMTP id f13-20020a056402194d00b0043bf21be9f4mr20274505edz.180.1658995142575; Thu, 28 Jul 2022 00:59:02 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH v3 1/2] automation: Remove XEN_CONFIG_EXPERT leftovers Date: Thu, 28 Jul 2022 10:58:55 +0300 Message-Id: <20220728075856.1175504-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220728075856.1175504-1-burzalodowa@gmail.com> References: <20220728075856.1175504-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini --- Changes in v2: - add Stefano's R-b tag Changes in v3: - none automation/build/README.md | 3 --- automation/scripts/build | 4 ++-- automation/scripts/containerize | 1 - 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/automation/build/README.md b/automation/build/README.md index 2137957408..00305eed03 100644 --- a/automation/build/README.md +++ b/automation/build/README.md @@ -65,9 +65,6 @@ understands. - CONTAINER_NO_PULL: If set to 1, the script will not pull from docker hub. This is useful when testing container locally. -- XEN_CONFIG_EXPERT: If this is defined in your shell it will be - automatically passed through to the container. - If your docker host has Linux kernel > 4.11, and you want to use containers that run old glibc (for example, CentOS 6 or SLES11SP4), you may need to add diff --git a/automation/scripts/build b/automation/scripts/build index 281f8b1fcc..21b3bc57c8 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -91,6 +91,6 @@ for cfg in `ls ${cfg_dir}`; do echo "Building $cfg" make -j$(nproc) -C xen clean rm -f xen/.config - make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} XEN_CONFIG_EXPERT=y defconfig - make -j$(nproc) -C xen XEN_CONFIG_EXPERT=y + make -C xen KBUILD_DEFCONFIG=../../../../${cfg_dir}/${cfg} defconfig + make -j$(nproc) -C xen done diff --git a/automation/scripts/containerize b/automation/scripts/containerize index 8992c67278..9d4beca4fa 100755 --- a/automation/scripts/containerize +++ b/automation/scripts/containerize @@ -101,7 +101,6 @@ exec ${docker_cmd} run \ -v "${CONTAINER_PATH}":/build:rw${selinux} \ -v "${HOME}/.ssh":/root/.ssh:ro \ ${SSH_AUTH_DIR:+-v "${SSH_AUTH_DIR}":/tmp/ssh-agent${selinux}} \ - ${XEN_CONFIG_EXPERT:+-e XEN_CONFIG_EXPERT=${XEN_CONFIG_EXPERT}} \ ${CONTAINER_ARGS} \ -${termint}i --rm -- \ ${CONTAINER} \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 07:59:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 07:59:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376668.609606 (Exim 4.92) (envelope-from ) id 1oGyQF-00062S-Vl; Thu, 28 Jul 2022 07:59:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376668.609606; Thu, 28 Jul 2022 07:59:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQF-00062L-SQ; Thu, 28 Jul 2022 07:59:07 +0000 Received: by outflank-mailman (input) for mailman id 376668; Thu, 28 Jul 2022 07:59:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyQE-0005U6-Nf for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 07:59:06 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26e899c4-0e4b-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 09:59:05 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id ez10so1736800ejc.13 for ; Thu, 28 Jul 2022 00:59:05 -0700 (PDT) Received: from uni.router.wind (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.googlemail.com with ESMTPSA id l2-20020a1709060cc200b00722e4bab163sm105413ejh.200.2022.07.28.00.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 00:59:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26e899c4-0e4b-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/yzGIK2WwUM9PEPFz0+ZahCjAacTI+5nDzYSTopw8Ts=; b=M0cNJH2zhlkpeo8XXDiOm7SfO4krIBzji+YhF7TmZS8anUKzk/y+WcdQ2/XtAKoz/D hlNENv+pge/lfDBSlCUQipjoNUVi7tm1V+iTYlk2hYcI/DDheCQoGd2XTmZ61xOPh79E DMGSgqGdK8mm/FRw1YKduSypcaZxwu6n2hLmtKLDbX/5kzncHRFPfytHUDomce3zuM/v ZuP7d8IQOBaULncfTHIBm1rq2pLVy2JNsOuegjGNkhE015Kwx/agSJJyc2164mC3eorq OjJHokKmC4gIpo8+dxyECAeC8TFjUvi8H+AyoDuouh7Ap7xfYCSG32I82/HoaPv745PQ yweQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/yzGIK2WwUM9PEPFz0+ZahCjAacTI+5nDzYSTopw8Ts=; b=ROG9/03MpyNQdjKsdOVR4kgyC6sWcEBSS1GUXRRejoQOpeU9GgM8cLfx4DwX8ZFKz+ 94JH7N/mnUymzmf0RCMmRq6Ku6ycDqE8/VMZs4lDRBrBgqI4PL50BDbDV1qjdHdEJ1gf 7Zzy5OlHb88Mi8j69syBDZ/C/1HJ1I4Z/BeSV9mDhjYxEbr5/PYOA5l2TJDq5BHROkjH V8yyjqiuUMq6znl84ASB6cn1UPB9l6llbFwdQTlvTWATOfQv9NT7XiX9M5nM/zaNzhEH vaxZdkCzXmLhv8Wj9kuSk6if4TC3HsL2K4m2Mr0ArFkdHWL285eNn5mPr96emg9fhja4 2eRw== X-Gm-Message-State: AJIora82PRmyjbwpthmCBX1/ciG+VVhOdfXzBap+LNb1hwZSoTntp3mG h1o7cQHjL73LJlKYfnnJGoCiw3x9cYc= X-Google-Smtp-Source: AGRyM1uuYqJjK5utoLyYZGuSAR9RoXypk1dlKzOB00lmoVcAPKW2HClruhluLhrBviRmZHDzL7Wahw== X-Received: by 2002:a17:907:738a:b0:72e:8510:6bfd with SMTP id er10-20020a170907738a00b0072e85106bfdmr19411003ejc.688.1658995145128; Thu, 28 Jul 2022 00:59:05 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini , Penny Zheng Subject: [PATCH v3 2/2] automation: arm64: Create a test job for testing static allocation on qemu Date: Thu, 28 Jul 2022 10:58:56 +0300 Message-Id: <20220728075856.1175504-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220728075856.1175504-1-burzalodowa@gmail.com> References: <20220728075856.1175504-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Reviewed-by: Penny Zheng --- Changes in v2: - enable CONFIG_STATIC_MEMORY for all arm64 builds - use the existing qemu-smoke-arm64.sh with an argument passed for distinguishing between tests, instead of creating a new script - test does not rely on kernel logs but prints a message itself on success - remove the part that enables custom configs for arm64 builds - add comments - adapt commit message Changes in v3: - refactor the changes to improve readability, no functionality change intended - add Penny's R-b tag automation/gitlab-ci/test.yaml | 18 ++++++++++++++++++ automation/scripts/build | 10 +++++++++- automation/scripts/qemu-smoke-arm64.sh | 25 ++++++++++++++++++++++++- 3 files changed, 51 insertions(+), 2 deletions(-) diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml index 26bdbcc3ea..6f9f64a8da 100644 --- a/automation/gitlab-ci/test.yaml +++ b/automation/gitlab-ci/test.yaml @@ -80,6 +80,24 @@ qemu-smoke-arm64-gcc: tags: - arm64 +qemu-smoke-arm64-gcc-staticmem: + extends: .test-jobs-common + variables: + CONTAINER: debian:unstable-arm64v8 + script: + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log + needs: + - debian-unstable-gcc-arm64 + - kernel-5.9.9-arm64-export + - qemu-system-aarch64-6.0.0-arm64-export + artifacts: + paths: + - smoke.serial + - '*.log' + when: always + tags: + - arm64 + qemu-smoke-arm32-gcc: extends: .test-jobs-common variables: diff --git a/automation/scripts/build b/automation/scripts/build index 21b3bc57c8..2b9f2d2b54 100755 --- a/automation/scripts/build +++ b/automation/scripts/build @@ -15,7 +15,15 @@ if [[ "${RANDCONFIG}" == "y" ]]; then make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig hypervisor_only="y" else - make -j$(nproc) -C xen defconfig + if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then + echo " +CONFIG_EXPERT=y +CONFIG_UNSUPPORTED=y +CONFIG_STATIC_MEMORY=y" > xen/.config + make -j$(nproc) -C xen olddefconfig + else + make -j$(nproc) -C xen defconfig + fi fi # Save the config file before building because build failure causes the script diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 53086a5ac7..69d9eae7a9 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -2,6 +2,23 @@ set -ex +test_variant=$1 + +passed="BusyBox" +check="" + +if [[ "${test_variant}" == "static-mem" ]]; then + # Memory range that is statically allocated to DOM1 + domu_base="50000000" + domu_size="10000000" + passed="${test_variant} test passed" + check="current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) +expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) +if [[ \"\${expected}\" == \"\${current}\" ]]; then + echo \"${passed}\" +fi" +fi + # Install QEMU export DEBIAN_FRONTENT=noninteractive apt-get -qy update @@ -43,6 +60,7 @@ echo "#!/bin/sh mount -t proc proc /proc mount -t sysfs sysfs /sys mount -t devtmpfs devtmpfs /dev +${check} /bin/sh" > initrd/init chmod +x initrd/init cd initrd @@ -68,6 +86,11 @@ DOMU_MEM[0]="256" LOAD_CMD="tftpb" UBOOT_SOURCE="boot.source" UBOOT_SCRIPT="boot.scr"' > binaries/config + +if [[ "${test_variant}" == "static-mem" ]]; then + echo -e "\nDOMU_STATIC_MEM[0]=\"0x${domu_base} 0x${domu_size}\"" >> binaries/config +fi + rm -rf imagebuilder git clone https://gitlab.com/ViryaOS/imagebuilder bash imagebuilder/scripts/uboot-script-gen -t tftp -d binaries/ -c binaries/config @@ -89,5 +112,5 @@ timeout -k 1 240 \ -bios /usr/lib/u-boot/qemu_arm64/u-boot.bin |& tee smoke.serial set -e -(grep -q "^BusyBox" smoke.serial && grep -q "DOM1: BusyBox" smoke.serial) || exit 1 +(grep -q "^BusyBox" smoke.serial && grep -q "DOM1: ${passed}" smoke.serial) || exit 1 exit 0 -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 08:33:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 08:33:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376691.609626 (Exim 4.92) (envelope-from ) id 1oGyxF-0003Vq-TL; Thu, 28 Jul 2022 08:33:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376691.609626; Thu, 28 Jul 2022 08:33:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyxF-0003Vj-QN; Thu, 28 Jul 2022 08:33:13 +0000 Received: by outflank-mailman (input) for mailman id 376691; Thu, 28 Jul 2022 08:33:12 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyxE-0003U5-7F; Thu, 28 Jul 2022 08:33:12 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyxE-0003va-4i; Thu, 28 Jul 2022 08:33:12 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGyxD-0002aZ-O8; Thu, 28 Jul 2022 08:33:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oGyxD-00047b-Ng; Thu, 28 Jul 2022 08:33:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZdMyIlkNlYZ3jfJm+xdvS/W/47Ont5TFKaJsxaEy6Q8=; b=XHzF9uxZbh2s/tMZUIZH4MGJQ6 H589fabgcyDlgOItT/O7L7xQESOnI/O2t8UzrCnm7+s+4XrQraObP2+tT//EJOGd7SpZoMd3IurvE nj8zOnd/5AOiqlglkkS8hVNEXg27HBTTOT/aphEqHjqBHF4Jc1icXpO/FSo0VIM0NScc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171887: tolerable FAIL - PUSHED X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=a9949efb288fd6e21bbaf9d5826207c7c41cda27 From: osstest service owner Date: Thu, 28 Jul 2022 08:33:11 +0000 flight 171887 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171887/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail blocked in 171873 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171873 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171873 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171873 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171873 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171873 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171873 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171873 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171873 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171873 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171873 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171873 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen a9949efb288fd6e21bbaf9d5826207c7c41cda27 Last test of basis 171873 2022-07-26 19:38:29 Z 1 days Testing same since 171887 2022-07-27 16:42:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Edwin Török Jan Beulich Julien Grall jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/xen.git a9949efb28..f732240fd3 f732240fd3bac25116151db5ddeb7203b62e85ce -> master From xen-devel-bounces@lists.xenproject.org Thu Jul 28 09:22:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 09:22:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376706.609653 (Exim 4.92) (envelope-from ) id 1oGzjG-0001MN-09; Thu, 28 Jul 2022 09:22:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376706.609653; Thu, 28 Jul 2022 09:22:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGzjF-0001MG-TX; Thu, 28 Jul 2022 09:22:49 +0000 Received: by outflank-mailman (input) for mailman id 376706; Thu, 28 Jul 2022 09:22:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGzjE-0001MA-68 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 09:22:48 +0000 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id d42d05c8-0e56-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 11:22:45 +0200 (CEST) Received: from epcas2p3.samsung.com (unknown [182.195.41.55]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220728092239epoutp018122922ac80b514e8a3918167113bce6~F89sNsGZG2474724747epoutp01W for ; Thu, 28 Jul 2022 09:22:39 +0000 (GMT) Received: from epsnrtp1.localdomain (unknown [182.195.42.162]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20220728092239epcas2p4c29b025679f9f31a5d042827e64e8741~F89rjRNh62808728087epcas2p4F; Thu, 28 Jul 2022 09:22:39 +0000 (GMT) Received: from epsmges2p3.samsung.com (unknown [182.195.36.68]) by epsnrtp1.localdomain (Postfix) with ESMTP id 4LtlYB1KfLz4x9Pv; Thu, 28 Jul 2022 09:22:38 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p3.samsung.com (Symantec Messaging Gateway) with SMTP id 2C.15.09642.D5552E26; Thu, 28 Jul 2022 18:22:38 +0900 (KST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: d42d05c8-0e56-11ed-bd2d-47488cf2e6aa DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220728092239epoutp018122922ac80b514e8a3918167113bce6~F89sNsGZG2474724747epoutp01W DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1659000159; bh=NEhLs3qbIQVYxE0925xjiV67d8egu/jXxPFdzksmxxM=; h=Date:Subject:Reply-To:From:To:CC:References:From; b=iR4pOKx4OgGvSGchnXnWhPT6YVWgY0jaRho7o6JBybSM5U/3a/qEWvjzSQhsLpRVX 1tNscWKwq9+2+tHmwmPboQjuZhpO5a3fF9nuihzrdwegeYXVVsdDau3+Y37GEPwHLo hhcRy2nHa4xgirNqaTiNLsTJBiEgXzVxtPWS0NH8= X-AuditID: b6c32a47-5e1ff700000025aa-12-62e2555d6eb5 Date: Thu, 28 Jul 2022 18:22:37 +0900 Message-ID: <97499212.9948800.1659000157467@mail-kr2-3> Mime-Version: 1.0 Subject: [PATCH v1] xen: add late init call in start_xen Reply-To: boyoun.park@samsung.com Sender: Boyoun Park From: Boyoun Park To: "xen-devel@lists.xenproject.org" CC: "sstabellini@kernel.org" , "julien@xen.org" , "bertrand.marquis@arm.com" , "Volodymyr_Babchuk@epam.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "jbeulich@suse.com" , "wl@xen.org" , "roger.pau@citrix.com" , Chungwoo Park , SoungKwan Kimn , DongJin PARK , Gang Li , Lei Wang X-Priority: 3 X-Content-Kind-Code: NORMAL X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N X-CMS-MailID: 20220728092237epcms2p53821bba31388763f45b5204d56520c20 Content-Type: multipart/mixed; boundary="----=_Part_9948799_1563422700.1659000157466" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnl+LIzCtJLcpLzFFi42LZdljTXDcu9FGSwb8GJovFj3exWyxdspnJ 4tSsTiaLZYfvsVtc+LiXxWJ+xyEmi597HrJZfJ49mc2ibcdlVosZ5xezWjQujLdYvS7e4t/S CIuPa8Qtvm+ZzOTA77Fm3hpGj9eTJzB63Fm6k9Fj06pONo/DH66wePRtWcXosX7LVRaP07dm sQVwRGXbZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl5gCd rqRQlphTChQKSCwuVtK3synKLy1JVcjILy6xVUotSMkpMC/QK07MLS7NS9fLSy2xMjQwMDIF KkzIzvh6dy97wb2TjBUb1vWxNjAuPcLYxcjJISFgIvHx5VoWEFtIYAejxNJzCSA2i4CqxLEV S5lAbF4Bc4kb26YxdzFyANmCEn93CIOEhQUsJCZPmc8M0aoo0XpmITtEXFeip2svG4jNJqAt 8eLmLbDxIgKuEj3/nwHVc3EwC3xhkbi+cwEbxA28EjPan7JA2NIS25dvhbpNQ+LHsl5mCFtU 4ubqt+ww9vtj86FqRCRa752FqhGUePBzN1RcSqLx0yGo+mKJOX3r2UEWSwg0MErcvHiRCSKh LzGlZQ4rhO0i8erObiaQJ5kFwiX61luBmBICyhJHIO5nFuCT6Dj8lx3m5B3znkBNUZX41fSC Eeb8PWfboWwPicMvnkCDNlBiyeHzrBMY5WchQnEWwq5ZYAsUJaZ0P2SHsDUkWufMhbLVJKb0 f2GDsF0kLq8+xoypHqYGZGSsRM9cIWQlCxi5VjGKpRYU56anFhsVGMMTSXJ+7iZGcG7Qct/B OOPtB71DjEwcjIcYVYB6H21YfYFRiiUvPy9VSYQ3Ifp+khBvSmJlVWpRfnxRaU5q8SFGU2BK mcgsJZqcD8xaeSXxhiaWBiZmZobmRqYG5krivF4pGxKFBNITS1KzU1MLUotg+pg4OKUamATL /i+wW/xMwkl434X4+tV/J1r9rVl7oPySgkj/r0m/7X0uvbqrmHnp4cO+D7WzRb5JKq/fcSn/ qP3pP5un/ytuMDKOPX/QsuZymFzYuSm2B0u+J2gwFzLcspL7LMkhW1nn4bKa/cmPMqu4mqQ2 +XTO9Laf4bLVfJxL+k9v3HTt8OLin0FulRzlQdMlZt4JrCj2sJi2/a+ov+K9L7/bfCY0L8g9 zpud1cmfWl/P4D7BtD0+sCnRo5K1zHvf5Xj3m9fbRTQ+dVh805m1gvVtSuyMa9scdkmVzXnk 3adxb7PjyriMn5ybZn7ZtXvtc8Z4oZNXcqSmhTxTeyhnoTzf2tki9W7ta+Gz97y+nShdrMRS nJFoqMVcVJwIAElH07iiBAAA DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220728092237epcms2p53821bba31388763f45b5204d56520c20 References: ------=_Part_9948799_1563422700.1659000157466 Content-Transfer-Encoding: base64 Content-Type: text/html; charset="utf-8" PCFET0NUWVBFIGh0bWw+DQo8aHRtbD4NCjxoZWFkPg0KPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVu dC1UeXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9VVRGLTgiIGNsYXNzPSJjdWktY29u dGVudC1kZWZhdWx0Ij4NCjxzdHlsZSBjbGFzcz0iY3VpLWNvbnRlbnQtZGVmYXVsdCIgZGF0YS1j YWZlLWRlZmF1bHQ9InRydWUiPi8qISBjYWZlIG5vdGUgdjIuMi4yNC4xIHwgQ29weXJpZ2h0IDIw MTQsIFMtQ29yZSwgSW5jLiBBbGwgUmlnaHQgUmVzZXJ2ZWQuICovDQpAY2hhcnNldCAiVVRGLTgi O2JvZHl7ZGlzcGxheTpibG9jazttYXJnaW46MTBweDt9Ym9keSBvbCxib2R5IHVse21hcmdpbjow O3BhZGRpbmctbGVmdDo0MHB4O31ib2R5IHAsYm9keSBsaXtsaW5lLWhlaWdodDoxLjk7bWFyZ2lu OjAgYXV0bzt9dGFibGUuY3VpLWRpdnt3aWR0aDoxMDAlO2Rpc3BsYXk6YmxvY2s7fXRhYmxlLmN1 aS1kaXYgPiB0Ym9keXtkaXNwbGF5OmJsb2NrO310YWJsZS5jdWktZGl2ID4gdGJvZHkgPiB0cntk aXNwbGF5OmJsb2NrO310YWJsZS5jdWktZGl2ID4gdGJvZHkgPiB0ciA+IHRkLHRhYmxlLmN1aS1k aXYgPiB0Ym9keSA+IHRyID4gdGh7ZGlzcGxheTpibG9jazt9dGFibGUuY3VpLXBhc3RlZC10YWJs ZSB0aCx0YWJsZS5jdWktcGFzdGVkLXRhYmxlIHRkLHRhYmxlLmN1aS1wYXN0ZWQtdGFibGUgcCx0 YWJsZS5jdWktcGFzdGVkLXRhYmxlIGgxLHRhYmxlLmN1aS1wYXN0ZWQtdGFibGUgaDIsdGFibGUu Y3VpLXBhc3RlZC10YWJsZSBoMyx0YWJsZS5jdWktcGFzdGVkLXRhYmxlIGg0LHRhYmxlLmN1aS1w YXN0ZWQtdGFibGUgaDUsdGFibGUuY3VpLXBhc3RlZC10YWJsZSBoNix0YWJsZS5jdWktcGFzdGVk LXRhYmxlIGxpe2xpbmUtaGVpZ2h0Om5vcm1hbDt9aW1nW2RhdGEtY3VpLWFsdC1pbWFnZV0sZGl2 W2RhdGEtY3VpLWFsdC1pbWFnZV17YmFja2dyb3VuZDp1cmwoImRhdGE6aW1hZ2UvcG5nO2Jhc2U2 NCxpVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBQllBQUFBVUNBWUFBQUNKZk0wd0FBQUJIMGxFUVZR NGpiWFUyNnFFSUJRR1lGK3d0eExNZ2c0UWRHZEJSRVVoRkVGQkJ4L3RuNnNHcGNQZXpUVENBaS8w UTExclNRZ2hoREdHSjRQOEFuM2oyMFFJZ1N6THZvb2tTZmF3VWdycnVrSXA5VlZjd2tJSWNNN2gr ejY2cm5zR2JwckdlQ3ZmOTUrQjh6dzNZTTc1TS9BNGpuQWNCM3BTOVkzelBLUHYrMHZZS0RmOWpj ZHhSSjduYUpyRzJEUk5FOEl3QkdNTVpWa2V3bVFiT253Vnk3SWdpcUwzVFd6YlJ0dTJ4K2dWbktZ cFhOZEYyN1pZMXhWeEhPK2F3SFZkRE1NQUthV0puc0ZabGhrbjh6enZ0TU9DSUFDbDFObzhTcW0x UzU1U0NrVlIzR3JkSTNRSDEzVjkvN1BSeG1HNVNTbGgyL2JIS0dNTVZWWHRZYzc1YlpSU2F1blgx dzkyKzl2VVQ2bWp1M1dmSnVxdnYvemY4Rm1aWHE3L0Jmb0NBMVZSc3ZLNEFmZ0FBQUFBU1VWT1JL NUNZSUk9Iikgbm8tcmVwZWF0IGNlbnRlciAjYzFjMWMxO31fOi1tcy1sYW5nKHgpLHRhYmxlIHRy Om5vdCg6Zmlyc3QtY2hpbGQpIHRkW2NvbHNwYW5de2JvcmRlci10b3Atc3R5bGU6bm9uZVw5ICFp bXBvcnRhbnQ7fV86LW1zLWxhbmcoeCksdGFibGUgdHI6bm90KDpmaXJzdC1jaGlsZCkgdGhbY29s c3Bhbl17Ym9yZGVyLXRvcC1zdHlsZTpub25lXDkgIWltcG9ydGFudDt9Xzo6c2VsZWN0aW9uLGJv ZHksYm9keSAqe3dvcmQtd3JhcDpicmVhay13b3JkXDA7fTwvc3R5bGU+DQo8c3R5bGUgY2xhc3M9 ImN1aS1jb250ZW50LWRlZmF1bHQiIGRhdGEtdXNlci1jb25maWc9InRydWUiPmJvZHkge21hcmdp bjogMTBweDsgZm9udC1zaXplOiAxMHB0OyBmb250LWZhbWlseTon66eR7J2AIOqzoOuUlSc7IGxp bmUtaGVpZ2h0OjEuOTt9DQpib2R5LGJvZHkgcCxib2R5IGxpLGJvZHkgaDEsYm9keSBoMiwgYm9k eSBoMyxib2R5IGg0LGJvZHkgaDUsYm9keSBoNiB7Zm9udC1mYW1pbHk6J+unkeydgCDqs6DrlJUn OyBsaW5lLWhlaWdodDoxLjk7fQ0KPC9zdHlsZT48L2hlYWQ+DQo8Ym9keT48cD5IZWxsbyw8L3A+ DQo8cD4mbmJzcDs8L3A+DQo8cD5UaGlzJm5ic3A7cGF0Y2gmbmJzcDthZGRlZCZuYnNwO2xhdGVf aW5pdGNhbGwmbmJzcDt0byZuYnNwO2RlYWwmbmJzcDt3aXRoPC9wPg0KPHA+c29tZSZuYnNwO2lu aXQmbmJzcDtmdW5jdGlvbnMmbmJzcDt3aGljaCZuYnNwO3Nob3VsZCZuYnNwO2JlJm5ic3A7Y2Fs bGVkPC9wPg0KPHA+YWZ0ZXImbmJzcDtvdGhlciZuYnNwO2luaXQmbmJzcDtmdW5jdGlvbnMgaW4g c3RhcnRfeGVuLjwvcD4NCjxwPiZuYnNwOzwvcD4NCjxwPklmJm5ic3A7dGhpcyZuYnNwO3BhdGNo Jm5ic3A7aXMmbmJzcDthZGRlZCw8L3A+DQo8cD50aGVuJm5ic3A7dGhlJm5ic3A7b3JpZ2luYWwm bmJzcDtpbml0Y2FsbCZuYnNwO2luJm5ic3A7eGVuJm5ic3A7d2lsbCZuYnNwO2JlJm5ic3A7dHJl YXRlZDwvcD4NCjxwPmFzJm5ic3A7ZWFybHlfaW5pdGNhbGwmbmJzcDthbmQmbmJzcDt0aGUmbmJz cDtsYXRlX2luaXRjYWxsPC9wPg0KPHA+d2hpY2gmbmJzcDtpcyZuYnNwO2FkZGVkJm5ic3A7Ynkm bmJzcDt0aGlzJm5ic3A7cGF0Y2gmbmJzcDt3aWxsJm5ic3A7YmU8L3A+DQo8cD5jYWxsZWQmbmJz cDtzZXF1ZW50aWFsbHkuPC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+SSBjYW5ub3Qgc2VuZCBwYXRj aGVzIHRocm91Z2ggZ2l0IHNlbmQtZW1haWw8L3A+DQo8cD5kdWUgdG8gc29tZSBzZWN1cml0eSBp c3N1ZXMgaW4gbXkgd29yay48L3A+DQo8cD5TbyBpbnRlYWQsIEkganVzdCBzZW5kIHRoZSBwYXRj aGVzIG1hbnVhbGx5LjwvcD4NCjxwPlNvcnJ5IGZvciB0aGUgaW5jb252ZW5pZW5jZS48L3A+DQo8 cD4mbmJzcDs8L3A+DQo8cD5JIG1hZGUgdGhpcyBwYXRjaCBkdXJpbmcgdXNpbmcgeGVuIGZvciBh IHByb2plY3QuPC9wPg0KPHA+QW5kIEkgd2FudCB0byBzaGFyZSBpdCBhbmQgYXNrIGZvciByZXZp ZXcuPC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+Qm95b3VuIFBhcmsuPC9wPg0KPHA+Jm5ic3A7PC9w Pg0KPHA+RnJvbTombmJzcDtCb3lvdW4mbmJzcDtQYXJrJm5ic3A7Jmx0O2JveW91bi5wYXJrQHNh bXN1bmcuY29tJmd0OzwvcD4NCjxwPlRvOiZuYnNwO3hlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0 Lm9yZzwvcD4NCjxwPkNjOiZuYnNwO1N0ZWZhbm8mbmJzcDtTdGFiZWxsaW5pJm5ic3A7Jmx0O3Nz dGFiZWxsaW5pQGtlcm5lbC5vcmcmZ3Q7PC9wPg0KPHA+Q2M6Jm5ic3A7SnVsaWVuJm5ic3A7R3Jh bGwmbmJzcDsmbHQ7anVsaWVuQHhlbi5vcmcmZ3Q7PC9wPg0KPHA+Q2M6Jm5ic3A7QmVydHJhbmQm bmJzcDtNYXJxdWlzJm5ic3A7Jmx0O2JlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbSZndDs8L3A+DQo8 cD5DYzombmJzcDtWb2xvZHlteXImbmJzcDtCYWJjaHVrJm5ic3A7Jmx0O1ZvbG9keW15cl9CYWJj aHVrQGVwYW0uY29tJmd0OzwvcD4NCjxwPkNjOiZuYnNwO0FuZHJldyZuYnNwO0Nvb3BlciZuYnNw OyZsdDthbmRyZXcuY29vcGVyM0BjaXRyaXguY29tJmd0OzwvcD4NCjxwPkNjOiZuYnNwO0dlb3Jn ZSZuYnNwO0R1bmxhcCZuYnNwOyZsdDtnZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20mZ3Q7PC9wPg0K PHA+Q2M6Jm5ic3A7SmFuJm5ic3A7QmV1bGljaCZuYnNwOyZsdDtqYmV1bGljaEBzdXNlLmNvbSZn dDs8L3A+DQo8cD5DYzombmJzcDtXZWkmbmJzcDtMaXUmbmJzcDsmbHQ7d2xAeGVuLm9yZyZndDs8 L3A+DQo8cD5DYzombmJzcDsiUm9nZXImbmJzcDtQYXUmbmJzcDtNb25uw6kiJm5ic3A7Jmx0O3Jv Z2VyLnBhdUBjaXRyaXguY29tJmd0OzwvcD4NCjxwPkRhdGU6Jm5ic3A7VHVlLCZuYnNwOzE1Jm5i c3A7TWFyJm5ic3A7MjAyMiZuYnNwOzEyOjU3OjU5Jm5ic3A7KzA5MDA8L3A+DQo8cD5TdWJqZWN0 OiZuYnNwO1tQQVRDSCZuYnNwO3YxXSZuYnNwO3hlbjombmJzcDthZGQmbmJzcDtsYXRlJm5ic3A7 aW5pdCZuYnNwO2NhbGwmbmJzcDtpbiZuYnNwO3N0YXJ0X3hlbjwvcD4NCjxwPiZuYnNwOzwvcD4N CjxwPlRoaXMmbmJzcDtwYXRjaCZuYnNwO2FkZGVkJm5ic3A7bGF0ZV9pbml0Y2FsbCZuYnNwO3Nl Y3Rpb24mbmJzcDtpbiZuYnNwO2luaXQuZGF0YS48L3A+DQo8cD5UaGUmbmJzcDtsYXRlJm5ic3A7 aW5pdGNhbGwmbmJzcDt3b3VsZCZuYnNwO2JlJm5ic3A7Y2FsbGVkJm5ic3A7YWZ0ZXImbmJzcDtp bml0Y2FsbDwvcD4NCjxwPmluJm5ic3A7dGhlJm5ic3A7c3RhcnRfeGVuJm5ic3A7ZnVuY3Rpb24u PC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+U29tZSZuYnNwO2luaXRpYWxpemluZyZuYnNwO3dvcmtz Jm5ic3A7b24mbmJzcDtwcmlvcml0eSZuYnNwO3Nob3VsZCZuYnNwO2JlJm5ic3A7cnVuPC9wPg0K PHA+aW4mbmJzcDtkb19pbml0Y2FsbHMmbmJzcDthbmQmbmJzcDtvdGhlciZuYnNwO25vbi1wcmlv cml0aXplZCZuYnNwO3dvcmtzPC9wPg0KPHA+d291bGQmbmJzcDtiZSZuYnNwO3J1biZuYnNwO2lu Jm5ic3A7ZG9fbGF0ZV9pbml0Y2FsbHMuPC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+VG8mbmJzcDtj YWxsJm5ic3A7c29tZSZuYnNwO2Z1bmN0aW9ucyZuYnNwO2J5Jm5ic3A7bGF0ZV9pbml0Y2FsbCw8 L3A+DQo8cD50aGVuJm5ic3A7aXQmbmJzcDtpcyZuYnNwO3Bvc3NpYmxlJm5ic3A7YnkmbmJzcDt1 c2luZzwvcD4NCjxwPl9fbGF0ZV9pbml0Y2FsbCgvKkZ1bmN0aW9uJm5ic3A7TmFtZSovKTs8L3A+ DQo8cD4mbmJzcDs8L3A+DQo8cD5TaWduZWQtb2ZmLWJ5OiZuYnNwO0JveW91biZuYnNwO1Bhcmsm bmJzcDsmbHQ7Ym95b3VuLnBhcmtAc2Ftc3VuZy5jb20mZ3Q7PC9wPg0KPHA+LS0tPC9wPg0KPHA+ Jm5ic3A7eGVuL2FyY2gvYXJtL3NldHVwLmMmbmJzcDsmbmJzcDsmbmJzcDt8Jm5ic3A7MiZuYnNw OysrPC9wPg0KPHA+Jm5ic3A7eGVuL2FyY2gvYXJtL3hlbi5sZHMuUyZuYnNwO3wmbmJzcDsyJm5i c3A7Kys8L3A+DQo8cD4mbmJzcDt4ZW4vYXJjaC94ODYvc2V0dXAuYyZuYnNwOyZuYnNwOyZuYnNw O3wmbmJzcDszJm5ic3A7KysrPC9wPg0KPHA+Jm5ic3A7eGVuL2FyY2gveDg2L3hlbi5sZHMuUyZu YnNwO3wmbmJzcDsyJm5ic3A7Kys8L3A+DQo8cD4mbmJzcDt4ZW4vY29tbW9uL2tlcm5lbC5jJm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7fCZuYnNwOzkmbmJzcDsrKysrKysrKy08L3A+DQo8cD4mbmJz cDt4ZW4vaW5jbHVkZS94ZW4vaW5pdC5oJm5ic3A7fCZuYnNwOzMmbmJzcDsrKys8L3A+DQo8cD4m bmJzcDs2Jm5ic3A7ZmlsZXMmbmJzcDtjaGFuZ2VkLCZuYnNwOzIwJm5ic3A7aW5zZXJ0aW9ucygr KSwmbmJzcDsxJm5ic3A7ZGVsZXRpb24oLSk8L3A+DQo8cD4mbmJzcDs8L3A+DQo8cD5kaWZmJm5i c3A7LS1naXQmbmJzcDthL3hlbi9hcmNoL2FybS9zZXR1cC5jJm5ic3A7Yi94ZW4vYXJjaC9hcm0v c2V0dXAuYzwvcD4NCjxwPmluZGV4Jm5ic3A7ODVmZjk1Ni4uMzMyYTIwNyZuYnNwOzEwMDY0NDwv cD4NCjxwPi0tLSZuYnNwO2EveGVuL2FyY2gvYXJtL3NldHVwLmM8L3A+DQo8cD4rKysmbmJzcDti L3hlbi9hcmNoL2FybS9zZXR1cC5jPC9wPg0KPHA+QEAmbmJzcDstMTA2Myw2Jm5ic3A7KzEwNjMs OCZuYnNwO0BAJm5ic3A7dm9pZCZuYnNwO19faW5pdCZuYnNwO3N0YXJ0X3hlbih1bnNpZ25lZCZu YnNwO2xvbmcmbmJzcDtib290X3BoeXNfb2Zmc2V0LDwvcD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOy8qJm5ic3A7SGlkZSZuYnNwO1VBUlQmbmJzcDtmcm9tJm5ic3A7RE9NMCZu YnNwO2lmJm5ic3A7d2UncmUmbmJzcDt1c2luZyZuYnNwO2l0Jm5ic3A7Ki88L3A+DQo8cD4mbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtzZXJpYWxfZW5kYm9vdCgpOzwvcD4NCjxwPiZuYnNw OzwvcD4NCjxwPismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtkb19sYXRlX2luaXRjYWxscygpOzwv cD4NCjxwPis8L3A+DQo8cD4mbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtpZiZuYnNwOygm bmJzcDsocmMmbmJzcDs9Jm5ic3A7eHNtX3NldF9zeXN0ZW1fYWN0aXZlKCkpJm5ic3A7IT0mbmJz cDswJm5ic3A7KTwvcD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwO3BhbmljKCJ4c206Jm5ic3A7dW5hYmxlJm5ic3A7dG8mbmJzcDtzd2l0 Y2gmbmJzcDt0byZuYnNwO1NZU1RFTV9BQ1RJVkUmbmJzcDtwcml2aWxlZ2U6Jm5ic3A7JWRcbiIs Jm5ic3A7cmMpOzwvcD4NCjxwPiZuYnNwOzwvcD4NCjxwPmRpZmYmbmJzcDstLWdpdCZuYnNwO2Ev eGVuL2FyY2gvYXJtL3hlbi5sZHMuUyZuYnNwO2IveGVuL2FyY2gvYXJtL3hlbi5sZHMuUzwvcD4N CjxwPmluZGV4Jm5ic3A7MWU5ODZlMi4uMjE1ZTJjMyZuYnNwOzEwMDY0NDwvcD4NCjxwPi0tLSZu YnNwO2EveGVuL2FyY2gvYXJtL3hlbi5sZHMuUzwvcD4NCjxwPisrKyZuYnNwO2IveGVuL2FyY2gv YXJtL3hlbi5sZHMuUzwvcD4NCjxwPkBAJm5ic3A7LTE2Myw2Jm5ic3A7KzE2Myw4Jm5ic3A7QEAm bmJzcDtTRUNUSU9OUzwvcD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwO19fcHJlc21wX2luaXRjYWxsX2VuZCZuYnNwOz0mbmJzcDsuOzwvcD4NCjxw PiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyooLmluaXRj YWxsMS5pbml0KTwvcD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwO19faW5pdGNhbGxfZW5kJm5ic3A7PSZuYnNwOy47PC9wPg0KPHA+KyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyooLmluaXRjYWxsbGF0ZS5pbml0KTwv cD4NCjxwPismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtfX2xhdGVf aW5pdGNhbGxfZW5kJm5ic3A7PSZuYnNwOy47PC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+Jm5ic3A7 Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7LiZuYnNwOz0mbmJzcDtB TElHTig0KTs8L3A+DQo8cD4mbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDtfX2FsdF9pbnN0cnVjdGlvbnMmbmJzcDs9Jm5ic3A7Ljs8L3A+DQo8cD5kaWZmJm5i c3A7LS1naXQmbmJzcDthL3hlbi9hcmNoL3g4Ni9zZXR1cC5jJm5ic3A7Yi94ZW4vYXJjaC94ODYv c2V0dXAuYzwvcD4NCjxwPmluZGV4Jm5ic3A7ZjA4YjA3Yi4uZDU5Mjk4YiZuYnNwOzEwMDY0NDwv cD4NCjxwPi0tLSZuYnNwO2EveGVuL2FyY2gveDg2L3NldHVwLmM8L3A+DQo8cD4rKysmbmJzcDti L3hlbi9hcmNoL3g4Ni9zZXR1cC5jPC9wPg0KPHA+QEAmbmJzcDstMTk1Miw2Jm5ic3A7KzE5NTIs OCZuYnNwO0BAJm5ic3A7dm9pZCZuYnNwO19faW5pdCZuYnNwO25vcmV0dXJuJm5ic3A7X19zdGFy dF94ZW4odW5zaWduZWQmbmJzcDtsb25nJm5ic3A7bWJpX3ApPC9wPg0KPHA+Jm5ic3A7PC9wPg0K PHA+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7c2V0dXBfaW9fYml0bWFwKGRvbTApOzwv cD4NCjxwPiZuYnNwOzwvcD4NCjxwPismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtkb19sYXRlX2lu aXRjYWxscygpOzwvcD4NCjxwPis8L3A+DQo8cD4mbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDtpZiZuYnNwOygmbmJzcDtic3BfZGVsYXlfc3BlY19jdHJsJm5ic3A7KTwvcD4NCjxwPiZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO3s8L3A+DQo8cD4mbmJzcDsmbmJzcDsmbmJzcDsmbmJz cDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtpbmZvLSZndDtzcGVjX2N0cmxfZmxhZ3Mm bmJzcDsmYW1wOz0mbmJzcDt+U0NGX3VzZV9zaGFkb3c7PC9wPg0KPHA+QEAmbmJzcDstMTk2NCw2 Jm5ic3A7KzE5NjYsNyZuYnNwO0BAJm5ic3A7dm9pZCZuYnNwO19faW5pdCZuYnNwO25vcmV0dXJu Jm5ic3A7X19zdGFydF94ZW4odW5zaWduZWQmbmJzcDtsb25nJm5ic3A7bWJpX3ApPC9wPg0KPHA+ Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7YnNwX2luZm8mbmJzcDs9Jm5ic3A7Z2V0X2Nw dV9pbmZvX2Zyb21fc3RhY2soKHVuc2lnbmVkJm5ic3A7bG9uZylic3Bfc3RhY2spOzwvcD4NCjxw PiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOypic3BfaW5mbyZuYnNwOz0mbmJzcDsqaW5m bzs8L3A+DQo8cD4mbmJzcDs8L3A+DQo8cD4rJm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7LyombmJz cDtKdW1wJm5ic3A7dG8mbmJzcDt0aGUmbmJzcDsxOjEmbmJzcDt2aXJ0dWFsJm5ic3A7bWFwcGlu Z3MmbmJzcDtvZiZuYnNwO2NwdTBfc3RhY2suJm5ic3A7Ki88L3A+DQo8cD4mbmJzcDsmbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDthc20mbmJzcDt2b2xhdGlsZSZuYnNwOygibW92Jm5ic3A7JVtzdGtd LCZuYnNwOyUlcnNwOyZuYnNwO2ptcCZuYnNwOyVjW2ZuXSImbmJzcDs6OjwvcD4NCjxwPiZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO1tzdGtd Jm5ic3A7ImciJm5ic3A7KCZhbXA7YnNwX2luZm8tJmd0O2d1ZXN0X2NwdV91c2VyX3JlZ3MpLDwv cD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwO1tmbl0mbmJzcDsiaSImbmJzcDsocmVpbml0X2JzcF9zdGFjaykmbmJzcDs6Jm5ic3A7 Im1lbW9yeSIpOzwvcD4NCjxwPmRpZmYmbmJzcDstLWdpdCZuYnNwO2EveGVuL2FyY2gveDg2L3hl bi5sZHMuUyZuYnNwO2IveGVuL2FyY2gveDg2L3hlbi5sZHMuUzwvcD4NCjxwPmluZGV4Jm5ic3A7 ODkzMGUxNC4uYzkwYzdiMCZuYnNwOzEwMDY0NDwvcD4NCjxwPi0tLSZuYnNwO2EveGVuL2FyY2gv eDg2L3hlbi5sZHMuUzwvcD4NCjxwPisrKyZuYnNwO2IveGVuL2FyY2gveDg2L3hlbi5sZHMuUzwv cD4NCjxwPkBAJm5ic3A7LTI1MCw2Jm5ic3A7KzI1MCw4Jm5ic3A7QEAmbmJzcDtTRUNUSU9OUzwv cD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO19f cHJlc21wX2luaXRjYWxsX2VuZCZuYnNwOz0mbmJzcDsuOzwvcD4NCjxwPiZuYnNwOyZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyooLmluaXRjYWxsMS5pbml0KTwvcD4N CjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO19faW5p dGNhbGxfZW5kJm5ic3A7PSZuYnNwOy47PC9wPg0KPHA+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwOyooLmluaXRjYWxsbGF0ZS5pbml0KTwvcD4NCjxwPismbmJzcDsm bmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtfX2xhdGVfaW5pdGNhbGxfZW5kJm5i c3A7PSZuYnNwOy47PC9wPg0KPHA+Jm5ic3A7PC9wPg0KPHA+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5i c3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7KiguaW5pdC5kYXRhKTwvcD4NCjxwPiZuYnNwOyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyooLmluaXQuZGF0YS5yZWwp PC9wPg0KPHA+ZGlmZiZuYnNwOy0tZ2l0Jm5ic3A7YS94ZW4vY29tbW9uL2tlcm5lbC5jJm5ic3A7 Yi94ZW4vY29tbW9uL2tlcm5lbC5jPC9wPg0KPHA+aW5kZXgmbmJzcDtmODEzNGQzLi41YTNkMDM3 Jm5ic3A7MTAwNjQ0PC9wPg0KPHA+LS0tJm5ic3A7YS94ZW4vY29tbW9uL2tlcm5lbC5jPC9wPg0K PHA+KysrJm5ic3A7Yi94ZW4vY29tbW9uL2tlcm5lbC5jPC9wPg0KPHA+QEAmbmJzcDstMzY5LDcm bmJzcDsrMzY5LDcmbmJzcDtAQCZuYnNwO3ZvaWQmbmJzcDthZGRfdGFpbnQodW5zaWduZWQmbmJz cDtpbnQmbmJzcDtmbGFnKTwvcD4NCjxwPiZuYnNwO308L3A+DQo8cD4mbmJzcDs8L3A+DQo8cD4m bmJzcDtleHRlcm4mbmJzcDtjb25zdCZuYnNwO2luaXRjYWxsX3QmbmJzcDtfX2luaXRjYWxsX3N0 YXJ0W10sJm5ic3A7X19wcmVzbXBfaW5pdGNhbGxfZW5kW10sPC9wPg0KPHA+LSZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwO19faW5pdGNhbGxfZW5kW107PC9wPg0KPHA+KyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwO19faW5pdGNhbGxfZW5kW10sJm5ic3A7X19sYXRlX2luaXRjYWxsX2VuZFtdOzwvcD4N CjxwPiZuYnNwOzwvcD4NCjxwPiZuYnNwO3ZvaWQmbmJzcDtfX2luaXQmbmJzcDtkb19wcmVzbXBf aW5pdGNhbGxzKHZvaWQpPC9wPg0KPHA+Jm5ic3A7ezwvcD4NCjxwPkBAJm5ic3A7LTM4NSw2Jm5i c3A7KzM4NSwxMyZuYnNwO0BAJm5ic3A7dm9pZCZuYnNwO19faW5pdCZuYnNwO2RvX2luaXRjYWxs cyh2b2lkKTwvcD4NCjxwPiZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOygqY2FsbCkoKTs8L3A+DQo8cD4mbmJzcDt9PC9wPg0KPHA+Jm5ic3A7PC9w Pg0KPHA+K3ZvaWQmbmJzcDtfX2luaXQmbmJzcDtkb19sYXRlX2luaXRjYWxscyh2b2lkKTwvcD4N CjxwPit7PC9wPg0KPHA+KyZuYnNwOyZuYnNwOyZuYnNwOyZuYnNwO2NvbnN0Jm5ic3A7aW5pdGNh bGxfdCZuYnNwOypjYWxsOzwvcD4NCjxwPismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDtmb3ImbmJz cDsoJm5ic3A7Y2FsbCZuYnNwOz0mbmJzcDtfX2luaXRjYWxsX2VuZDsmbmJzcDtjYWxsJm5ic3A7 Jmx0OyZuYnNwO19fbGF0ZV9pbml0Y2FsbF9lbmQ7Jm5ic3A7Y2FsbCsrJm5ic3A7KTwvcD4NCjxw PismbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsmbmJzcDsoKmNhbGwp KCk7PC9wPg0KPHA+K308L3A+DQo8cD4rPC9wPg0KPHA+Jm5ic3A7I2lmZGVmJm5ic3A7Q09ORklH X0hZUEZTPC9wPg0KPHA+Jm5ic3A7c3RhdGljJm5ic3A7dW5zaWduZWQmbmJzcDtpbnQmbmJzcDtf X3JlYWRfbW9zdGx5Jm5ic3A7bWFqb3JfdmVyc2lvbjs8L3A+DQo8cD4mbmJzcDtzdGF0aWMmbmJz cDt1bnNpZ25lZCZuYnNwO2ludCZuYnNwO19fcmVhZF9tb3N0bHkmbmJzcDttaW5vcl92ZXJzaW9u OzwvcD4NCjxwPmRpZmYmbmJzcDstLWdpdCZuYnNwO2EveGVuL2luY2x1ZGUveGVuL2luaXQuaCZu YnNwO2IveGVuL2luY2x1ZGUveGVuL2luaXQuaDwvcD4NCjxwPmluZGV4Jm5ic3A7MGFmMGUyMy4u NDgyMTBlZSZuYnNwOzEwMDY0NDwvcD4NCjxwPi0tLSZuYnNwO2EveGVuL2luY2x1ZGUveGVuL2lu aXQuaDwvcD4NCjxwPisrKyZuYnNwO2IveGVuL2luY2x1ZGUveGVuL2luaXQuaDwvcD4NCjxwPkBA Jm5ic3A7LTY4LDExJm5ic3A7KzY4LDE0Jm5ic3A7QEAmbmJzcDt0eXBlZGVmJm5ic3A7dm9pZCZu YnNwOygqZXhpdGNhbGxfdCkodm9pZCk7PC9wPg0KPHA+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7 Jm5ic3A7Y29uc3QmbmJzcDtzdGF0aWMmbmJzcDtpbml0Y2FsbF90Jm5ic3A7X19pbml0Y2FsbF8j I2ZuJm5ic3A7X19pbml0X2NhbGwoInByZXNtcCIpJm5ic3A7PSZuYnNwO2ZuPC9wPg0KPHA+Jm5i c3A7I2RlZmluZSZuYnNwO19faW5pdGNhbGwoZm4pJm5ic3A7XDwvcD4NCjxwPiZuYnNwOyZuYnNw OyZuYnNwOyZuYnNwOyZuYnNwO2NvbnN0Jm5ic3A7c3RhdGljJm5ic3A7aW5pdGNhbGxfdCZuYnNw O19faW5pdGNhbGxfIyNmbiZuYnNwO19faW5pdF9jYWxsKCIxIikmbmJzcDs9Jm5ic3A7Zm48L3A+ DQo8cD4rI2RlZmluZSZuYnNwO19fbGF0ZV9pbml0Y2FsbChmbikmbmJzcDtcPC9wPg0KPHA+KyZu YnNwOyZuYnNwOyZuYnNwOyZuYnNwO2NvbnN0Jm5ic3A7c3RhdGljJm5ic3A7aW5pdGNhbGxfdCZu YnNwO19faW5pdGNhbGxfIyNmbiZuYnNwO19faW5pdF9jYWxsKCJsYXRlIikmbmJzcDs9Jm5ic3A7 Zm48L3A+DQo8cD4mbmJzcDsjZGVmaW5lJm5ic3A7X19leGl0Y2FsbChmbikmbmJzcDtcPC9wPg0K PHA+Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7Jm5ic3A7c3RhdGljJm5ic3A7ZXhpdGNhbGxfdCZu YnNwO19fZXhpdGNhbGxfIyNmbiZuYnNwO19fZXhpdF9jYWxsJm5ic3A7PSZuYnNwO2ZuPC9wPg0K PHA+Jm5ic3A7PC9wPg0KPHA+Jm5ic3A7dm9pZCZuYnNwO2RvX3ByZXNtcF9pbml0Y2FsbHModm9p ZCk7PC9wPg0KPHA+Jm5ic3A7dm9pZCZuYnNwO2RvX2luaXRjYWxscyh2b2lkKTs8L3A+DQo8cD4r dm9pZCZuYnNwO2RvX2xhdGVfaW5pdGNhbGxzKHZvaWQpOzwvcD4NCjxwPiZuYnNwOzwvcD4NCjxw PiZuYnNwOyNlbmRpZiZuYnNwOy8qJm5ic3A7X19BU1NFTUJMWV9fJm5ic3A7Ki88L3A+DQo8cD4m bmJzcDs8L3A+DQo8cD4tLSZuYnNwOzwvcD4NCjxwPjIuNy40PC9wPg0KPHA+Jm5ic3A7PC9wPg0K PC9ib2R5Pg0KPC9odG1sPjx0YWJsZSBzdHlsZT0nZGlzcGxheTogbm9uZTsnPjx0Ym9keT48dHI+ PHRkPjxpbWcgc3R5bGU9J2Rpc3BsYXk6IG5vbmU7JyBib3JkZXI9MCBzcmM9J2h0dHA6Ly9leHQu c2Ftc3VuZy5uZXQvbWFpbC9leHQvdjEvZXh0ZXJuYWwvc3RhdHVzL3VwZGF0ZT91c2VyaWQ9Ym95 b3VuLnBhcmsmZG89YldGcGJFbEVQVEl3TWpJd056STRNRGt5TWpNM1pYQmpiWE15Y0RVek9ESXhZ bUpoTXpFek9EZzNOak5tTkRWaU5USXdOR1ExTmpVeU1HTXlNQ1p5WldOcGNHbGxiblJCWkdSeVpY TnpQWGhsYmkxa1pYWmxiRUJzYVhOMGN5NTRaVzV3Y205cVpXTjBMbTl5WndfXycgd2lkdGg9MCBo ZWlnaHQ9MD48L3RkPjwvdHI+PC90Ym9keT48L3RhYmxlPg== ------=_Part_9948799_1563422700.1659000157466 Content-Type: application/octet-stream Content-Disposition: attachment; filename="v1-0000-cover-letter.patch" Content-Transfer-Encoding: base64 RnJvbSBjMzBkNTAyMjUyOTIwMGIzYTExZjM5N2FjYzJiNDk0YTVkZjI2YWUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8Y292ZXIuMTY1ODk5ODg3Mi5naXQuYm95b3VuLnBh cmtAc2Ftc3VuZy5jb20+CkZyb206IEJveW91biBQYXJrIDxib3lvdW4ucGFya0BzYW1zdW5nLmNv bT4KVG86IHhlbi1kZXZlbEBsaXN0cy54ZW5wcm9qZWN0Lm9yZwpDYzogU3RlZmFubyBTdGFiZWxs aW5pIDxzc3RhYmVsbGluaUBrZXJuZWwub3JnPgpDYzogSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4KQ2M6IEJlcnRyYW5kIE1hcnF1aXMgPGJlcnRyYW5kLm1hcnF1aXNAYXJtLmNvbT4KQ2M6 IFZvbG9keW15ciBCYWJjaHVrIDxWb2xvZHlteXJfQmFiY2h1a0BlcGFtLmNvbT4KQ2M6IEFuZHJl dyBDb29wZXIgPGFuZHJldy5jb29wZXIzQGNpdHJpeC5jb20+CkNjOiBHZW9yZ2UgRHVubGFwIDxn ZW9yZ2UuZHVubGFwQGNpdHJpeC5jb20+CkNjOiBKYW4gQmV1bGljaCA8amJldWxpY2hAc3VzZS5j b20+CkNjOiBXZWkgTGl1IDx3bEB4ZW4ub3JnPgpDYzogIlJvZ2VyIFBhdSBNb25uw6kiIDxyb2dl ci5wYXVAY2l0cml4LmNvbT4KRGF0ZTogVGh1LCAyOCBKdWwgMjAyMiAxODowMToxMiArMDkwMApT dWJqZWN0OiBbUEFUQ0ggdjFdIEFkZCBsYXRlX2luaXRjYWxsIGZvciBzdGFydF94ZW4KCkhlbGxv LAoKVGhpcyBwYXRjaCBhZGRlZCBsYXRlX2luaXRjYWxsIHRvIGRlYWwgd2l0aApzb21lIGluaXQg ZnVuY3Rpb25zIHdoaWNoIHNob3VsZCBiZSBjYWxsZWQKYWZ0ZXIgb3RoZXIgaW5pdCBmdW5jdGlv bnMuCgpJZiB0aGlzIHBhdGNoIGlzIG1lcmdlZCwKdGhlbiB0aGUgb3JpZ2luYWwgaW5pdGNhbGwg aW4geGVuIHdpbGwgYmUgdHJlYXRlZAphcyBlYXJseV9pbml0Y2FsbCBhbmQgdGhlIGxhdGVfaW5p dGNhbGwKd2hpY2ggaXMgYWRkZWQgYnkgdGhpcyBwYXRjaCB3aWxsIGJlIApjYWxsZWQgc2VxdWVu dGlhbGx5LgoKQm95b3VuIFBhcmsgKDEpOgogIHhlbjogYWRkIGxhdGUgaW5pdCBjYWxsIGluIHN0 YXJ0X3hlbgoKIHhlbi9hcmNoL2FybS9zZXR1cC5jICAgfCAyICsrCiB4ZW4vYXJjaC9hcm0veGVu Lmxkcy5TIHwgMiArKwogeGVuL2FyY2gveDg2L3NldHVwLmMgICB8IDMgKysrCiB4ZW4vYXJjaC94 ODYveGVuLmxkcy5TIHwgMiArKwogeGVuL2NvbW1vbi9rZXJuZWwuYyAgICB8IDkgKysrKysrKyst CiB4ZW4vaW5jbHVkZS94ZW4vaW5pdC5oIHwgMyArKysKIDYgZmlsZXMgY2hhbmdlZCwgMjAgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKLS0gCjIuNy40Cgo= ------=_Part_9948799_1563422700.1659000157466 Content-Type: application/octet-stream Content-Disposition: attachment; filename="v1-0001-xen-add-late-init-call-in-start_xen.patch" Content-Transfer-Encoding: base64 RnJvbSBjMzBkNTAyMjUyOTIwMGIzYTExZjM5N2FjYzJiNDk0YTVkZjI2YWUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpNZXNzYWdlLUlkOiA8YzMwZDUwMjI1MjkyMDBiM2ExMWYzOTdhY2MyYjQ5 NGE1ZGYyNmFlMS4xNjU4OTk4ODcyLmdpdC5ib3lvdW4ucGFya0BzYW1zdW5nLmNvbT4KSW4tUmVw bHktVG86IDxjb3Zlci4xNjU4OTk4ODcyLmdpdC5ib3lvdW4ucGFya0BzYW1zdW5nLmNvbT4KUmVm ZXJlbmNlczogPGNvdmVyLjE2NTg5OTg4NzIuZ2l0LmJveW91bi5wYXJrQHNhbXN1bmcuY29tPgpG cm9tOiBCb3lvdW4gUGFyayA8Ym95b3VuLnBhcmtAc2Ftc3VuZy5jb20+ClRvOiB4ZW4tZGV2ZWxA bGlzdHMueGVucHJvamVjdC5vcmcKQ2M6IFN0ZWZhbm8gU3RhYmVsbGluaSA8c3N0YWJlbGxpbmlA a2VybmVsLm9yZz4KQ2M6IEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+CkNjOiBCZXJ0cmFu ZCBNYXJxdWlzIDxiZXJ0cmFuZC5tYXJxdWlzQGFybS5jb20+CkNjOiBWb2xvZHlteXIgQmFiY2h1 ayA8Vm9sb2R5bXlyX0JhYmNodWtAZXBhbS5jb20+CkNjOiBBbmRyZXcgQ29vcGVyIDxhbmRyZXcu Y29vcGVyM0BjaXRyaXguY29tPgpDYzogR2VvcmdlIER1bmxhcCA8Z2VvcmdlLmR1bmxhcEBjaXRy aXguY29tPgpDYzogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgpDYzogV2VpIExpdSA8 d2xAeGVuLm9yZz4KQ2M6ICJSb2dlciBQYXUgTW9ubsOpIiA8cm9nZXIucGF1QGNpdHJpeC5jb20+ CkRhdGU6IFR1ZSwgMTUgTWFyIDIwMjIgMTI6NTc6NTkgKzA5MDAKU3ViamVjdDogW1BBVENIIHYx XSB4ZW46IGFkZCBsYXRlIGluaXQgY2FsbCBpbiBzdGFydF94ZW4KClRoaXMgcGF0Y2ggYWRkZWQg bGF0ZV9pbml0Y2FsbCBzZWN0aW9uIGluIGluaXQuZGF0YS4KVGhlIGxhdGUgaW5pdGNhbGwgd291 bGQgYmUgY2FsbGVkIGFmdGVyIGluaXRjYWxsCmluIHRoZSBzdGFydF94ZW4gZnVuY3Rpb24uCgpT b21lIGluaXRpYWxpemluZyB3b3JrcyBvbiBwcmlvcml0eSBzaG91bGQgYmUgcnVuCmluIGRvX2lu aXRjYWxscyBhbmQgb3RoZXIgbm9uLXByaW9yaXRpemVkIHdvcmtzCndvdWxkIGJlIHJ1biBpbiBk b19sYXRlX2luaXRjYWxscy4KClRvIGNhbGwgc29tZSBmdW5jdGlvbnMgYnkgbGF0ZV9pbml0Y2Fs bCwKdGhlbiBpdCBpcyBwb3NzaWJsZSBieSB1c2luZwpfX2xhdGVfaW5pdGNhbGwoLypGdW5jdGlv biBOYW1lKi8pOwoKU2lnbmVkLW9mZi1ieTogQm95b3VuIFBhcmsgPGJveW91bi5wYXJrQHNhbXN1 bmcuY29tPgotLS0KIHhlbi9hcmNoL2FybS9zZXR1cC5jICAgfCAyICsrCiB4ZW4vYXJjaC9hcm0v eGVuLmxkcy5TIHwgMiArKwogeGVuL2FyY2gveDg2L3NldHVwLmMgICB8IDMgKysrCiB4ZW4vYXJj aC94ODYveGVuLmxkcy5TIHwgMiArKwogeGVuL2NvbW1vbi9rZXJuZWwuYyAgICB8IDkgKysrKysr KystCiB4ZW4vaW5jbHVkZS94ZW4vaW5pdC5oIHwgMyArKysKIDYgZmlsZXMgY2hhbmdlZCwgMjAg aW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9z ZXR1cC5jIGIveGVuL2FyY2gvYXJtL3NldHVwLmMKaW5kZXggODVmZjk1Ni4uMzMyYTIwNyAxMDA2 NDQKLS0tIGEveGVuL2FyY2gvYXJtL3NldHVwLmMKKysrIGIveGVuL2FyY2gvYXJtL3NldHVwLmMK QEAgLTEwNjMsNiArMTA2Myw4IEBAIHZvaWQgX19pbml0IHN0YXJ0X3hlbih1bnNpZ25lZCBsb25n IGJvb3RfcGh5c19vZmZzZXQsCiAgICAgLyogSGlkZSBVQVJUIGZyb20gRE9NMCBpZiB3ZSdyZSB1 c2luZyBpdCAqLwogICAgIHNlcmlhbF9lbmRib290KCk7CiAKKyAgICBkb19sYXRlX2luaXRjYWxs cygpOworCiAgICAgaWYgKCAocmMgPSB4c21fc2V0X3N5c3RlbV9hY3RpdmUoKSkgIT0gMCApCiAg ICAgICAgIHBhbmljKCJ4c206IHVuYWJsZSB0byBzd2l0Y2ggdG8gU1lTVEVNX0FDVElWRSBwcml2 aWxlZ2U6ICVkXG4iLCByYyk7CiAKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS94ZW4ubGRzLlMg Yi94ZW4vYXJjaC9hcm0veGVuLmxkcy5TCmluZGV4IDFlOTg2ZTIuLjIxNWUyYzMgMTAwNjQ0Ci0t LSBhL3hlbi9hcmNoL2FybS94ZW4ubGRzLlMKKysrIGIveGVuL2FyY2gvYXJtL3hlbi5sZHMuUwpA QCAtMTYzLDYgKzE2Myw4IEBAIFNFQ1RJT05TCiAgICAgICAgX19wcmVzbXBfaW5pdGNhbGxfZW5k ID0gLjsKICAgICAgICAqKC5pbml0Y2FsbDEuaW5pdCkKICAgICAgICBfX2luaXRjYWxsX2VuZCA9 IC47CisgICAgICAgKiguaW5pdGNhbGxsYXRlLmluaXQpCisgICAgICAgX19sYXRlX2luaXRjYWxs X2VuZCA9IC47CiAKICAgICAgICAuID0gQUxJR04oNCk7CiAgICAgICAgX19hbHRfaW5zdHJ1Y3Rp b25zID0gLjsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL3g4Ni9zZXR1cC5jIGIveGVuL2FyY2gveDg2 L3NldHVwLmMKaW5kZXggZjA4YjA3Yi4uZDU5Mjk4YiAxMDA2NDQKLS0tIGEveGVuL2FyY2gveDg2 L3NldHVwLmMKKysrIGIveGVuL2FyY2gveDg2L3NldHVwLmMKQEAgLTE5NTIsNiArMTk1Miw4IEBA IHZvaWQgX19pbml0IG5vcmV0dXJuIF9fc3RhcnRfeGVuKHVuc2lnbmVkIGxvbmcgbWJpX3ApCiAK ICAgICBzZXR1cF9pb19iaXRtYXAoZG9tMCk7CiAKKyAgICBkb19sYXRlX2luaXRjYWxscygpOwor CiAgICAgaWYgKCBic3BfZGVsYXlfc3BlY19jdHJsICkKICAgICB7CiAgICAgICAgIGluZm8tPnNw ZWNfY3RybF9mbGFncyAmPSB+U0NGX3VzZV9zaGFkb3c7CkBAIC0xOTY0LDYgKzE5NjYsNyBAQCB2 b2lkIF9faW5pdCBub3JldHVybiBfX3N0YXJ0X3hlbih1bnNpZ25lZCBsb25nIG1iaV9wKQogICAg IGJzcF9pbmZvID0gZ2V0X2NwdV9pbmZvX2Zyb21fc3RhY2soKHVuc2lnbmVkIGxvbmcpYnNwX3N0 YWNrKTsKICAgICAqYnNwX2luZm8gPSAqaW5mbzsKIAorICAgIC8qIEp1bXAgdG8gdGhlIDE6MSB2 aXJ0dWFsIG1hcHBpbmdzIG9mIGNwdTBfc3RhY2suICovCiAgICAgYXNtIHZvbGF0aWxlICgibW92 ICVbc3RrXSwgJSVyc3A7IGptcCAlY1tmbl0iIDo6CiAgICAgICAgICAgICAgICAgICBbc3RrXSAi ZyIgKCZic3BfaW5mby0+Z3Vlc3RfY3B1X3VzZXJfcmVncyksCiAgICAgICAgICAgICAgICAgICBb Zm5dICJpIiAocmVpbml0X2JzcF9zdGFjaykgOiAibWVtb3J5Iik7CmRpZmYgLS1naXQgYS94ZW4v YXJjaC94ODYveGVuLmxkcy5TIGIveGVuL2FyY2gveDg2L3hlbi5sZHMuUwppbmRleCA4OTMwZTE0 Li5jOTBjN2IwIDEwMDY0NAotLS0gYS94ZW4vYXJjaC94ODYveGVuLmxkcy5TCisrKyBiL3hlbi9h cmNoL3g4Ni94ZW4ubGRzLlMKQEAgLTI1MCw2ICsyNTAsOCBAQCBTRUNUSU9OUwogICAgICAgIF9f cHJlc21wX2luaXRjYWxsX2VuZCA9IC47CiAgICAgICAgKiguaW5pdGNhbGwxLmluaXQpCiAgICAg ICAgX19pbml0Y2FsbF9lbmQgPSAuOworICAgICAgICooLmluaXRjYWxsbGF0ZS5pbml0KQorICAg ICAgIF9fbGF0ZV9pbml0Y2FsbF9lbmQgPSAuOwogCiAgICAgICAgKiguaW5pdC5kYXRhKQogICAg ICAgICooLmluaXQuZGF0YS5yZWwpCmRpZmYgLS1naXQgYS94ZW4vY29tbW9uL2tlcm5lbC5jIGIv eGVuL2NvbW1vbi9rZXJuZWwuYwppbmRleCBmODEzNGQzLi41YTNkMDM3IDEwMDY0NAotLS0gYS94 ZW4vY29tbW9uL2tlcm5lbC5jCisrKyBiL3hlbi9jb21tb24va2VybmVsLmMKQEAgLTM2OSw3ICsz NjksNyBAQCB2b2lkIGFkZF90YWludCh1bnNpZ25lZCBpbnQgZmxhZykKIH0KIAogZXh0ZXJuIGNv bnN0IGluaXRjYWxsX3QgX19pbml0Y2FsbF9zdGFydFtdLCBfX3ByZXNtcF9pbml0Y2FsbF9lbmRb XSwKLSAgICBfX2luaXRjYWxsX2VuZFtdOworICAgIF9faW5pdGNhbGxfZW5kW10sIF9fbGF0ZV9p bml0Y2FsbF9lbmRbXTsKIAogdm9pZCBfX2luaXQgZG9fcHJlc21wX2luaXRjYWxscyh2b2lkKQog ewpAQCAtMzg1LDYgKzM4NSwxMyBAQCB2b2lkIF9faW5pdCBkb19pbml0Y2FsbHModm9pZCkKICAg ICAgICAgKCpjYWxsKSgpOwogfQogCit2b2lkIF9faW5pdCBkb19sYXRlX2luaXRjYWxscyh2b2lk KQoreworICAgIGNvbnN0IGluaXRjYWxsX3QgKmNhbGw7CisgICAgZm9yICggY2FsbCA9IF9faW5p dGNhbGxfZW5kOyBjYWxsIDwgX19sYXRlX2luaXRjYWxsX2VuZDsgY2FsbCsrICkKKyAgICAgICAg KCpjYWxsKSgpOworfQorCiAjaWZkZWYgQ09ORklHX0hZUEZTCiBzdGF0aWMgdW5zaWduZWQgaW50 IF9fcmVhZF9tb3N0bHkgbWFqb3JfdmVyc2lvbjsKIHN0YXRpYyB1bnNpZ25lZCBpbnQgX19yZWFk X21vc3RseSBtaW5vcl92ZXJzaW9uOwpkaWZmIC0tZ2l0IGEveGVuL2luY2x1ZGUveGVuL2luaXQu aCBiL3hlbi9pbmNsdWRlL3hlbi9pbml0LmgKaW5kZXggMGFmMGUyMy4uNDgyMTBlZSAxMDA2NDQK LS0tIGEveGVuL2luY2x1ZGUveGVuL2luaXQuaAorKysgYi94ZW4vaW5jbHVkZS94ZW4vaW5pdC5o CkBAIC02OCwxMSArNjgsMTQgQEAgdHlwZWRlZiB2b2lkICgqZXhpdGNhbGxfdCkodm9pZCk7CiAg ICAgY29uc3Qgc3RhdGljIGluaXRjYWxsX3QgX19pbml0Y2FsbF8jI2ZuIF9faW5pdF9jYWxsKCJw cmVzbXAiKSA9IGZuCiAjZGVmaW5lIF9faW5pdGNhbGwoZm4pIFwKICAgICBjb25zdCBzdGF0aWMg aW5pdGNhbGxfdCBfX2luaXRjYWxsXyMjZm4gX19pbml0X2NhbGwoIjEiKSA9IGZuCisjZGVmaW5l IF9fbGF0ZV9pbml0Y2FsbChmbikgXAorICAgIGNvbnN0IHN0YXRpYyBpbml0Y2FsbF90IF9faW5p dGNhbGxfIyNmbiBfX2luaXRfY2FsbCgibGF0ZSIpID0gZm4KICNkZWZpbmUgX19leGl0Y2FsbChm bikgXAogICAgIHN0YXRpYyBleGl0Y2FsbF90IF9fZXhpdGNhbGxfIyNmbiBfX2V4aXRfY2FsbCA9 IGZuCiAKIHZvaWQgZG9fcHJlc21wX2luaXRjYWxscyh2b2lkKTsKIHZvaWQgZG9faW5pdGNhbGxz KHZvaWQpOwordm9pZCBkb19sYXRlX2luaXRjYWxscyh2b2lkKTsKIAogI2VuZGlmIC8qIF9fQVNT RU1CTFlfXyAqLwogCi0tIAoyLjcuNAoK ------=_Part_9948799_1563422700.1659000157466-- From xen-devel-bounces@lists.xenproject.org Thu Jul 28 09:27:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 09:27:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376712.609664 (Exim 4.92) (envelope-from ) id 1oGznM-0002FB-LN; Thu, 28 Jul 2022 09:27:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376712.609664; Thu, 28 Jul 2022 09:27:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGznM-0002F4-Ho; Thu, 28 Jul 2022 09:27:04 +0000 Received: by outflank-mailman (input) for mailman id 376712; Thu, 28 Jul 2022 09:27:03 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGznL-0002Ey-3e for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 09:27:03 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2046.outbound.protection.outlook.com [40.107.22.46]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6f449301-0e57-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 11:27:01 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PA4PR04MB7774.eurprd04.prod.outlook.com (2603:10a6:102:cc::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 09:26:59 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 09:26:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f449301-0e57-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FnQ2NK3OOlXkxV8gOfjd621AuVqlbjvmXnJwDzOLos8ebymDtJhC8VJ4c5vvIa3B2XdFanDSnweAZ9GeXfZY0e3nCQX3CsoE6bCwjFmPvjJrb4IQPML1Vpr4QwDNbJX31lLPSPLb0aEcaytuT2Ua4iMF0tbBs6chrtkUQ83Q5/4D+zbsNMnBlI1ifVN3kRBdrzTAE+B3NafE26ZtUIPKntqEc8tnaaxQtAZs/mYDPrjLaYkbJFicY0uJNhX8wbA71ArMpcsGynekLH/FBPl5L+fm/C5l+dqlYATyf3yGEJXl+bi44S6nRoVIqdNQeaAhLX1TDJm+649rRmbEe5+6Rg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8Z5sZRmGAOzPBz1xFfN/4/KVaxEVUoXwzI6FaPG+h7w=; b=Cj5xE7AAaMRWeR64Mxpv64Bc2gNFFGtpxYOz8tSZvUhYK+pOaW5mhtxuVLpvtOPmAIqSjqSewePb8xNHh1LLkBD3GCAkhv6InToFHf5qqhxINb9cp+l/y61EmYKFnIRFDA6bEs+s2vKwUwclBWbHocXvRt2l+ih94KkP2aPs4huamFZ5cWDkiTDfbl+tN7ejn/d2JS3G4kbsWMN9N5TL8X/YDzZ3kcJdOXWpdvWz4I/Bqfp9pRKP2Evq40L2TVzD5H5eCBGrDQL+Cuw19Bwje74RK+bshC3Ei+3euimK2M4VL6gngu6T0oQa5omNY0QsK88dH1dop0nPfhuSRhzYXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8Z5sZRmGAOzPBz1xFfN/4/KVaxEVUoXwzI6FaPG+h7w=; b=ZsmXmwoiXGFjrwVd9wtm77yDHzdeUwb1UKm1UYab12yuVpTo1VKNrXE7ZDv4Lact0yh236JU+UL/pml7qGwcmiswspwrbElHUFNguULUGom4CHrELgNdLskvea5sT95h9SU6mlqS+ZN7XHB2pwT/vnkNijJx8gVxRg08XjjYi4wtYCCTDO835WLqgPgzVrwZQ+p/WoW3TmkqZM8zITkyPcj4MuTMAzldNfLiyJ85V3/wpPF9SL4JRirIluhtPhUs5vKunLODVBUN7UJp5oljN+5TA1u8VrxNZNQEQV4q3PXOOLzevfWRnF0o4UNJR41C+HUxot1qq/ySwRbf86l3Eg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> Date: Thu, 28 Jul 2022 11:26:57 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728075709.1175445-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220728075709.1175445-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: AM6P191CA0058.EURP191.PROD.OUTLOOK.COM (2603:10a6:209:7f::35) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bd865230-0793-4c97-fb55-08da707b5275 X-MS-TrafficTypeDiagnostic: PA4PR04MB7774:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lTsu67mXMe94JieAaMpakMgzfcSbI3Qd7vW/DkQ42q4sVMvWEiHDLHrwd/bNF6PV8oQ4V+Ha5UADjahYoFf6nxdL+0rQWJEoAhmb3HxvoL5GK1d4dNVk3yOQ9gLUpMtg2y78x836TXsMHyqgk5a8HnjOHtjJOePUE16MPS3DIVXRMXN+Ww9vIDH+bTIireBgfpD7caRsedcZ+GhGge5mPytgYeUwD4FsKO6pPcAKhiJ/lzI7gIiOW0ULiuBgDkHJQh6xCckuRlfDbAHr7WSJye1uxxCC/bsbLgTSKnzzEpyVPys5uaiD/19RzLiswsRZSgGfOsbAo3XoPHp1bd/yghfWIsH4wapIkpy6kq6fLb0CaW50rIDLzCZP7eXUGzlwCwGqaPSO+OFL8HFhGRAz0mzo+Eld9TCtnnccyXsgsGyR8AioL14GoHwZiE6Z9s2vtp+Ho8jDMxye7Pe0KxBnawAKLeEIvnch74a/IZeRbX44RYPYilbM5bGfp5tJqImimv0ikBbgCoCvttpPYbH/fydDm5Wj72H2/0nkPulDVeaoCLE0rfLyE4NnLx1zZgDtcZyqfLjZfLsFXQIvBoo3fNtKr+S7whw1eGMmYOy3KCelZLCuuinSgP3k6bgyEhU356ot69drrx6+M1rIusmX3MupNluj1TF0vf++G7i9ykh/8/IngGGu7iAeNLpEV6acaDrv87A+aqbRpgbtd1MHRD/vuAVrUwA8/Jle7mnK1mtUtcWAgD/GwK6g22cQhConzyI7xEVgERGOzoGruEXkhns3rxE7zji+BzTY6g5YJePalPVLq37ZyhLqu2OdGQvJkbPMf7O17q9rLZQT+5zvNQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(346002)(39860400002)(396003)(366004)(376002)(41300700001)(83380400001)(8936002)(4744005)(6486002)(2616005)(478600001)(186003)(36756003)(5660300002)(31686004)(6506007)(26005)(53546011)(6512007)(86362001)(66946007)(31696002)(316002)(2906002)(66556008)(8676002)(38100700002)(4326008)(54906003)(6916009)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NE5YYk41WTdoQkREMWVJejlBbWkyN1p3NCtWam8xbkUzclpEamN6QWxsRWU2?= =?utf-8?B?clZMSDhSdEdTTzUxWVhRYW1CWTZTYmJuclFrU3RSTXVYK3dEV0FsTmRpemJ5?= =?utf-8?B?KzhDVmszS013N0pnOXVCZ0FyVUtVdUduMkIwb2xpMFBPRUtHaUJpNnptMmlN?= =?utf-8?B?Y0FoNEtnS04zSFVvSkM3WGxybzBaejhGeFhyNEJ0ZFhGM3dpajVVRG8yeS8w?= =?utf-8?B?cWR5Z1VkckI0RnIvMlh0T0VHSk1yVGljazJleWtLSkZuZkp6a04zd21xdmlq?= =?utf-8?B?WERvTHppZkJoQitnU2tleVdnNy9YeDVRdnc5K1dRdlZqTnlpNHNsVkRJZklF?= =?utf-8?B?VXJUVzJkc3RSd0F5Nzg0RFZPeG4rQ3F1d3NwZTJtZzBwWWVYRVhkakFmYkp4?= =?utf-8?B?U1NzM2JWZThRVDQ4cWFpWUVZZ25jVTdVaW5sM2Iwemc5ekdjcU1GKzY3L0Mz?= =?utf-8?B?RWFzNUtqTUlLbWk0MDZHRDlaRjJmdzZRSWJINEN0bGk1Y0pKQ1p4RXBoemRC?= =?utf-8?B?Smd0blVueERyekJ3Mi9lQkE4d0JHejhsaVBjY3B1L3JIcmVzTU0rTEE1clJ4?= =?utf-8?B?RDErU1ZPenJaY3RDcjRPaXJkMWZmakZBTElvUC9sYUg4STErUjNRVmpTQTJC?= =?utf-8?B?bXQ5RE1RbjFJMTRtcXpyOXVJemFCbUpVWXNFTm0yK3FabmhjTWVleFN5bDMy?= =?utf-8?B?T1lPMEt1UEYrN3NQeVNKck56MXNHL2psSEFpNnpwSlNiSi9DYk1McHhrN0N6?= =?utf-8?B?UlpxeittUDdZYVg4cFdQU1k2MU5ZdU9FYVpxZlBKd0dnTDVFc1ZkNnFqYU9J?= =?utf-8?B?QlZJUndpdDVaT1dTbFBQdzBkRGJzNHVwRUVHcmczRzVtVG1jb1ZtQmlERnVr?= =?utf-8?B?aHJpci9QLzdheHUrdmhjVzdjV1JsOWVSUGpUVVNQZlFUY2tHUk8ySmNGTVhy?= =?utf-8?B?bHlRZHQvQ09lWjBLdGltSjBiU29jNVBXNlhQYUtnckV3T0JlVnR1cERobkZP?= =?utf-8?B?OFVGenozb1ZjU0hKcDBFakhVMjA0cW11SFRqaTlPU0ZFSThYOWtZZ05GeS9L?= =?utf-8?B?WEhxa0RzNk5jaGlteU1yYS9Day9jV2JpSllyWWhsZWxuYVJRRndsQWwrcXBs?= =?utf-8?B?Y25FM011eW0vZXJyN0NVOG1iZU5DUVRmL1F2TE81RmpqT2w5ZTdqZTlCU0l1?= =?utf-8?B?S2N3eDZhUU9TT1EyRmFIODU1cTA2anE5b3VJMitJcEFGYVNmdnc1SlJCdEJ4?= =?utf-8?B?RXpSUDJFYXIyZytiMWk4Q0NCeUI2cDByTnBTV1o1b2lFRCtVSVpEMmNuRklh?= =?utf-8?B?ODRtTExxeCtsVVhDUjVNcTFxVVgzZkJ1a0tuQjBhOElaV2tOSmtqWlloc3Za?= =?utf-8?B?NjlMbDBJUHpTc09YSjNCVDRrM3dRTTFKTGFuSHEwMnU1Qzl4dlF5WTFrSEpa?= =?utf-8?B?TE1GcU51NzZxM2tSM3p0TmlyZEU5QVZSUUVjdlIwR1A0ekk2NW9zMldnTGM5?= =?utf-8?B?ZXBORThoeUhWcEpZR1RSRFNSdS9WaVlHVEtuQ0hSQkE3bWlTOGVXL3k2WElO?= =?utf-8?B?OThTaSt6Q2Q2S0dGMUZDYmVFMVVSTi81RVFIajZuSE53T1FhUDJTcmFMQ1ln?= =?utf-8?B?VXptbGo4My9mcGVEWVp0R0EvNUxHd0gyQWhDd2s2QlJEUXJMNmFSSG9NL0Zx?= =?utf-8?B?TG9ydjRHVnZ5MUw2S211RnNsbDNuaExMckI3SnpSSE13VEdsNjB6YmxBMUFF?= =?utf-8?B?SWRjVmM4MU5ubWRwdEJJQkhyMVRRMkpLRkJobXpqRUlQTnN0TjFHMXllZW9t?= =?utf-8?B?ck5Xbm5TUFVKOWpacUpBNDN2MUluanJsSThFb0JrVkVFTnFwNVVtV00xaXhx?= =?utf-8?B?T3UrUmxCYnFuMnp0bi9wSHBJb01hZjZpM2VValhWREpiTlQxY0E0cktxV29Q?= =?utf-8?B?djBhYk9tbSswdnRWbFhnTUM0L3NQVkJ1OXZvSnBiK2lERDNZYnlKSlkyOFJU?= =?utf-8?B?VHUyM0NncWt4alBZbTVvSFZRQlJmZ1Fud3BxdE9DajYxOUNVNXVaaEMvQWdo?= =?utf-8?B?YjZYMkc0cnNsQWNEdzZocms4bDlEbEk1SVBPT2h0czY4SXc5ZGNDeE1WVUM5?= =?utf-8?Q?5F55DjGP9740JxoGtxhZB4C9g?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: bd865230-0793-4c97-fb55-08da707b5275 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 09:26:59.4973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UMLJNjxBv5X2pHKCKQAIRiFFjunWf8b6Fe0wFATvPNi/RjmPPHS4od2Xck0fGcvVP4XVka8seNHLEYC4aQvKPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7774 On 28.07.2022 09:57, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/include/asm/current.h > +++ b/xen/arch/arm/include/asm/current.h > @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) > > #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) > > +extern void return_to_new_vcpu32(void); > +extern void return_to_new_vcpu64(void); While ultimately it's the Arm maintainers to judge, may I suggest that these be put in arm/domain.c to limit visibility? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 09:36:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 09:36:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376719.609675 (Exim 4.92) (envelope-from ) id 1oGzvt-0003uv-Gv; Thu, 28 Jul 2022 09:35:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376719.609675; Thu, 28 Jul 2022 09:35:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGzvt-0003uo-DE; Thu, 28 Jul 2022 09:35:53 +0000 Received: by outflank-mailman (input) for mailman id 376719; Thu, 28 Jul 2022 09:35:52 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGzvs-0003uS-Fv for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 09:35:52 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oGzvr-00052P-Ip; Thu, 28 Jul 2022 09:35:51 +0000 Received: from [54.239.6.185] (helo=[192.168.5.18]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oGzvr-0002Be-CD; Thu, 28 Jul 2022 09:35:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=T0vdA59yfPVzgSOjk2kk/p/YIypWJXGCmrzn6PTyHpY=; b=HHU6cJ+wOVrey1OMJBBo8Km0ns 52/1P4X5tKf+0D+CW1OANHgD74iO0HGtGdOB1NV63gXWhR42K2YPnf+uEBPZhhJi/QHKhD6datJe1 DAv2mqb/nREQkhQFzopThBlnHVjtH8ExLeNo99OVjtA2i1PP5W0U9M0qnM6+tFAdYcHg=; Message-ID: <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> Date: Thu, 28 Jul 2022 10:35:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Content-Language: en-US To: Bertrand Marquis Cc: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> From: Julien Grall In-Reply-To: <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/07/2022 08:57, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, > >> On 27 Jul 2022, at 16:46, Julien Grall wrote: >> >> Hi Xenia, >> >> On 27/07/2022 16:32, Xenia Ragiadakou wrote: >>> Remove unused macro atomic_xchg(). >>> Signed-off-by: Xenia Ragiadakou >>> --- >>> xen/arch/arm/include/asm/atomic.h | 2 -- >>> 1 file changed, 2 deletions(-) >>> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h >>> index f5ef744b4b..a2dc125291 100644 >>> --- a/xen/arch/arm/include/asm/atomic.h >>> +++ b/xen/arch/arm/include/asm/atomic.h >>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u) >>> return __atomic_add_unless(v, a, u); >>> } >>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >>> - >> >> While I agree this is unused today, the wrapper is quite trivial and part of the generic API (x86 also provides one). So I am not in favor of removing it just to please MISRA. >> >> That said, if Bertrand and Stefano agrees with removing it then you should also remove the x86 version to avoid inconsistency. > > I think we can keep this and maybe add a comment on top to document a known violation: > /* TODO: MISRA_VIOLATION 2.5 */ While I am fine with this goal of the comment (i.e. indicating where Xen is not MISRA compliant), I think this is one place where I would rather not want one because it can get stale if someones decide to use the function. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 09:45:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 09:45:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376725.609686 (Exim 4.92) (envelope-from ) id 1oH05T-0005YN-EV; Thu, 28 Jul 2022 09:45:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376725.609686; Thu, 28 Jul 2022 09:45:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH05T-0005YG-B2; Thu, 28 Jul 2022 09:45:47 +0000 Received: by outflank-mailman (input) for mailman id 376725; Thu, 28 Jul 2022 09:45:45 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH05R-0005YA-QX for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 09:45:45 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2082.outbound.protection.outlook.com [40.107.21.82]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0cafe7bb-0e5a-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 11:45:44 +0200 (CEST) Received: from AS9PR06CA0731.eurprd06.prod.outlook.com (2603:10a6:20b:487::22) by DB9PR08MB7193.eurprd08.prod.outlook.com (2603:10a6:10:2cc::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 09:45:42 +0000 Received: from AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:487:cafe::5) by AS9PR06CA0731.outlook.office365.com (2603:10a6:20b:487::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 09:45:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT046.mail.protection.outlook.com (10.152.16.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 09:45:41 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Thu, 28 Jul 2022 09:45:41 +0000 Received: from 7fbeba7b5338.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 47FE19CF-B222-46E5-B3A0-DB6483479CB0.1; Thu, 28 Jul 2022 09:45:33 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 7fbeba7b5338.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 09:45:33 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DBBPR08MB4759.eurprd08.prod.outlook.com (2603:10a6:10:f3::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 09:45:31 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5482.010; Thu, 28 Jul 2022 09:45:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0cafe7bb-0e5a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=i5HLOiu9HDFDlqEEtz8jx1uHvgeYA6fxgVajrQ3yx4MpG9CoSOx9G6PhI57jOgAelDsnXlncSZPNBmacDsfqNmvdrbMpKZJy/VIxo0WqfYf6q53HMNJm9GUsz9DHm9fRt8OdRAfz5KyPen3Ln2FzwBNKdsJJJ54VT37boK73eAo5MITcTKQt09Mko0T4Xy+sf2WBoCuI1gHltG0DM09hT6BddwjRh1hop2B3cwJOaYJMzDhg5y+WffVSNz3dzCWyAwXkpjwsgFrGnK6sUXbOT0/hlTKlPtzLZj30bQtMU9fkz0t7jvtb7Ljdnwevm8nWSC7cKRZ8eCMT7VhFBS1aMw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZIynvujiCOEswQ21LIeQ0Ct0RPettGAUKixNuXN3nA=; b=GuRptSGCkYOsWIL6H7pL60h84fok5GfqVGMdgsip+uMegPyMxge9jETPhA0gG8jIUEgvvYP4MaCWSPd0N9KEuS7lYJZ/kWHKEiUX3M91aaI8G9+qJV0PKUXtKjHM3bOEYAW+x0tRuF6yn7izdgV0vBYYvaj7aBeXUiJ22RpRaYmlVbG+QwCSlRoVx7WW5r4EouoRRR0hc9GMus6xsX/rN4YmMMOR30iqIVfQ2w2hCX/rXymI6gcOkH3phTLwIXUCeapuZWJhwIdqxs+8+NpHPBLIbFxnr+EVDush2Zn0JkUw/bLSyM7wTWiaf+pz13NnqAZ7f8smAH536ZFAZIuhpw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZIynvujiCOEswQ21LIeQ0Ct0RPettGAUKixNuXN3nA=; b=saU+e4GSmffhF2s7ULFPnxIqVQlTwJ7fZTpFmyL5frXFgEZIJDbHYyic1z0a78oMBJq7qi7A+GcGrTptwBHX+1aXPd3EibjugAj3JIWgCFvgxYDpgTOdV/K0tP13j1Q10+T1hWG5PfO/uBRJo+Q5nsJ8/wAdV0saRewbYZ5Jm+M= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 79526fe0e1348e3c X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XX6wau96tdcTLFGeqQQ269osijeOUaiHkzECFqXeU54ai+/hZtbhyUwJ4E4P0xmK3fe94PzskBMhkq0GVjMdFHJYzO8R31vtcaWCA4dNrdsDujarciTa2jepuLxGUkkDFXJW2UvQ8V9/2/Ur9QJuFrC4rkAVQE4vwBnXOs5yFTkJnqM14zNO866bRUNAaG7gIhivJ+v4ZYhNQlah7E7C03gBp28mrDmoMivzhsQr7oZj9rffs8KC5y2cLXBukjJsma5zA7Oi9NZqaXP5lkhUa4tf4LT6sKiGQEUxn0vRFvb6iFSqXEcVDr4MeofZaVRv7C6fDYMRZwPDOIcOmGCCqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IZIynvujiCOEswQ21LIeQ0Ct0RPettGAUKixNuXN3nA=; b=SIllx8t0huBWWdFIqNnwt2b2BjNrce8rGyT3u/OWKFkoz1gu8s+6teAvyMOjW62GPxekEtZ/awxQVp6Uosdlw9NpDKZQMmMNDaSSCtiGh8GO7j2gAEOQAMeEGrd3/tAVyHMk+bDvgEaXdwedD8BNoBz/+hZbu+qhhrtbx2SV/92/34nkUt9azIHYTcAV07h2nzzOUwYqgSBCGO6buDBQbmRApNy9s0n06TMvKIMjhIvSM+Rdj8oe9TQVzfYAzuJuSZWaMviSntrOZXAkvxsOpjQhi9tBHpVZ9mPWUFBsepNbomJwVt81bnbjlQHkx9jeD5OJM5g3/OIQGIlJKPFx9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IZIynvujiCOEswQ21LIeQ0Ct0RPettGAUKixNuXN3nA=; b=saU+e4GSmffhF2s7ULFPnxIqVQlTwJ7fZTpFmyL5frXFgEZIJDbHYyic1z0a78oMBJq7qi7A+GcGrTptwBHX+1aXPd3EibjugAj3JIWgCFvgxYDpgTOdV/K0tP13j1Q10+T1hWG5PfO/uBRJo+Q5nsJ8/wAdV0saRewbYZ5Jm+M= From: Bertrand Marquis To: Julien Grall CC: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Topic: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Index: AQHYoc45O9kZLijXrUyjjlrBuGCX1a2SXJWAgAEPNoCAABtvgIAAArUA Date: Thu, 28 Jul 2022 09:45:31 +0000 Message-ID: <27786AF4-37EA-4C54-9330-1C9B674BAC87@arm.com> References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> In-Reply-To: <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 2c253321-e156-4cd6-e750-08da707def8f x-ms-traffictypediagnostic: DBBPR08MB4759:EE_|AM5EUR03FT046:EE_|DB9PR08MB7193:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 9wP4+2d1EZTVEjam4HerGotlY6R+PgYVsAOetDQRddwTq1ZWt7oRBk8xDC9PtHNuznME/59iP4twGzXNPcqLGzawFVKVSPbikk2mZkAhtf6Ph1fE4timqfhEBTxAoSgZDM2d4/u43+iD593eiACzjoz4Eo9Owcu9gRZGDjeEwhiXhk2VWRYvss2e80S3V8Qh5vXtV8v45aeUbDVEAxT3hPEvKQbXYo/51/8Yf5xIgGWQZwN4EQ8pxhvF8tam0LvD8inaurum2Ttf2/7fbwBsTljSQ/ujVs+heGIlW3EbwRnpzC+mAhjTjurJ/Mps4/Pg4+NscZoDY4sueno+WQznwWC7sDwAiMTiiAySPRS8yidpi6bgTO7Kjzm9cotUvUaaf4n0zZPVpujiiXpbfSevtgU1m0HlE43oAsXLpuqP2mwPEBldP5E4TDpCyB04RK3Vgen8QFYjYHuRAjHeze6ULFXBlv5QvtkscaKla6unoqjsFyXGaoeez4Yuo0xjMhJn5rzTaOJzVpscRJ1yvQ11N9QkMU0Y4W1x38eKvP2dev5ozMuyLDr5vaxGBQ+ksA6tkSj3tWJBPY3nrgMmKc/gYXxsgG3iUCaC6znS8szQdAnG8HFX6z0RDTZpNEJPeTKPSKNikY25BoBySbPbFpZQPV+BkxQEMOaNVYfujR/LpiWKj//N1ON+4/llLmTIYUUbl9L5QhjMp5bGQOoKKy+T9LPMeka5m5rDbY1Y5wrzV/FuQ4dnUAAgasMI6b0+wZK1N5goF0GNy430nvQD2wvvkvMUxO204xXFlXxXn0So3j9z95DAjeMFw12DhfOFqO7QESGj7De7oJ0aPR9LKgDA/Q== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(366004)(136003)(346002)(38070700005)(54906003)(6486002)(186003)(36756003)(6916009)(2616005)(33656002)(2906002)(5660300002)(316002)(8936002)(122000001)(38100700002)(76116006)(6506007)(64756008)(91956017)(8676002)(66556008)(66446008)(41300700001)(83380400001)(4326008)(66476007)(6512007)(53546011)(66946007)(86362001)(478600001)(71200400001)(26005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <0DC22141D3662341AF61E4A0084E6A4A@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4759 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: af6fd4d9-f38a-4efe-ca16-08da707de96f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wY4z/QMw7BWGkxBk2zM39i1R/heqwcqIxdbgFaacCl2pOtMFcluHTADzRXrzHydutVkb8GHk5zA+pXNtNAFo4eFVUaN/eONrxlx9Wt2318pN26KmaPIw1X5ni9NTiE8L0S93GNvRoibA4U8aWhLOrrT5T1HmiuI+YOU8/ECSJmsqtV0R1pF4VXuye4Kxk7U7Pj9j63jawEj7jB0uYclR0eRZ6yROFUxnVeJNnjxYOj9H8PjKPgX+gjLWbTIJVL+NUmn+fikX4/NDKTk+L+WHsMAfNpJcPCWc14iSFFFaGQV7aTAa9nZPpMESTv2cXzWGlrFivTS9iYoly8g2v9QiSRzsbO2d/62V8OJJQUUn0cy4a7THbDEwTHtSEwWG4wnhJ/N4wNe9itA0Lo6swJCjsUT1lYj8sLcwjPEj6nmAoUFCTtJtTP8gDDX7qQhNEsdgzMz1T4xTiGCBtbyvt0UMMD+RadhIadbUbJg/9akA3t9Z016wVDECnEp3IAtvKwncZIzBX5dwBjsEhRgf5+slQA9UULj+Dg8ML2D697qnYXy4El0wZLOMxDjPButBrLvQBewWfCsUBLI59HQG+NLAgx7k3X3aaktgyUe8fDA499LEaPWIFG+GTBQDpNkhwuw5wbYO6OmiPKDOSIU989G8JM/97bBb1USCzKC3QV++664oMGg/rwjifsi7OgnHbR/BIZXeDiZk+cHV9+oGapzC0+Z44vGCMJmSkZAR3TAsAkFd0xfjpg1LRcAXqbSNEx16Ks+ItY9vlnYPCIFmjsC5fjZKG/TlfPDduiuqSejp94DgRLk49hD1olfE5vsx3B7O X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(396003)(346002)(376002)(136003)(40470700004)(36840700001)(46966006)(8936002)(6862004)(70206006)(81166007)(316002)(40480700001)(26005)(6512007)(82740400003)(6486002)(4326008)(86362001)(70586007)(33656002)(36860700001)(36756003)(41300700001)(53546011)(478600001)(82310400005)(47076005)(8676002)(186003)(40460700003)(2616005)(5660300002)(54906003)(2906002)(6506007)(356005)(83380400001)(336012)(107886003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 09:45:41.7973 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c253321-e156-4cd6-e750-08da707def8f X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT046.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7193 Hi Julien, > On 28 Jul 2022, at 10:35, Julien Grall wrote: >=20 >=20 >=20 > On 28/07/2022 08:57, Bertrand Marquis wrote: >> Hi Julien, >=20 > Hi Bertrand, >=20 >>> On 27 Jul 2022, at 16:46, Julien Grall wrote: >>>=20 >>> Hi Xenia, >>>=20 >>> On 27/07/2022 16:32, Xenia Ragiadakou wrote: >>>> Remove unused macro atomic_xchg(). >>>> Signed-off-by: Xenia Ragiadakou >>>> --- >>>> xen/arch/arm/include/asm/atomic.h | 2 -- >>>> 1 file changed, 2 deletions(-) >>>> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/= asm/atomic.h >>>> index f5ef744b4b..a2dc125291 100644 >>>> --- a/xen/arch/arm/include/asm/atomic.h >>>> +++ b/xen/arch/arm/include/asm/atomic.h >>>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, i= nt a, int u) >>>> return __atomic_add_unless(v, a, u); >>>> } >>>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >>>> - >>>=20 >>> While I agree this is unused today, the wrapper is quite trivial and pa= rt of the generic API (x86 also provides one). So I am not in favor of remo= ving it just to please MISRA. >>>=20 >>> That said, if Bertrand and Stefano agrees with removing it then you sho= uld also remove the x86 version to avoid inconsistency. >> I think we can keep this and maybe add a comment on top to document a kn= own violation: >> /* TODO: MISRA_VIOLATION 2.5 */ >=20 > While I am fine with this goal of the comment (i.e. indicating where Xen = is not MISRA compliant), I think this is one place where I would rather not= want one because it can get stale if someones decide to use the function. I think the one doing that will have to update the comment otherwise we wil= l never manage to have an analysis without findings. Having those kind of comments in the code for violation also means that the= y must be updated if the violation is solved. Maybe we will need a run ignoring those to identify possible violations whi= ch are not violations anymore but this might be hard to do. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 10:10:36 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 10:10:36 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376732.609697 (Exim 4.92) (envelope-from ) id 1oH0TM-0000tv-BV; Thu, 28 Jul 2022 10:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376732.609697; Thu, 28 Jul 2022 10:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0TM-0000to-8i; Thu, 28 Jul 2022 10:10:28 +0000 Received: by outflank-mailman (input) for mailman id 376732; Thu, 28 Jul 2022 10:10:26 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0TK-0000te-4P; Thu, 28 Jul 2022 10:10:26 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0TK-0005lk-0u; Thu, 28 Jul 2022 10:10:26 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0TJ-0006ZR-Jx; Thu, 28 Jul 2022 10:10:25 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oH0TJ-0000IQ-JS; Thu, 28 Jul 2022 10:10:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=2n3ojMO9wLnEKVrBqiA4nyrflqqB48tt5QUligsN29I=; b=ZQayjRGaACAjFGsfsmCupXASPs JcN9MMdrlEyY+XxWr1+kTGdQX2RWGw/mjY63Jxq1XVsUsxujxx7bcsYabqbDk0kilsSuhDTDjHBHC mTM4nLM10zU0KXfOY38m8ulGcs1XSNYMe1kZsHvkFi+3DuRT9RsNjZIgfHt5vMxU6CjM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171891: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6e7765cb477a9753670d4351d14de93f1e9dbbd4 X-Osstest-Versions-That: linux=39c3c396f8131f3db454c80e0fcfcdc54ed9ec01 From: osstest service owner Date: Thu, 28 Jul 2022 10:10:25 +0000 flight 171891 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171891/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171882 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171882 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171882 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171882 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171882 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171882 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171882 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171882 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 6e7765cb477a9753670d4351d14de93f1e9dbbd4 baseline version: linux 39c3c396f8131f3db454c80e0fcfcdc54ed9ec01 Last test of basis 171882 2022-07-27 09:15:12 Z 1 days Testing same since 171891 2022-07-28 00:42:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Arnd Bergmann Baolin Wang Claudiu Beznea Florian Fainelli Linus Torvalds Linus Walleij Lukas Bulwahn Michael Walle jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 39c3c396f813..6e7765cb477a 6e7765cb477a9753670d4351d14de93f1e9dbbd4 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Thu Jul 28 10:22:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 10:22:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376741.609708 (Exim 4.92) (envelope-from ) id 1oH0eR-0002f1-Gq; Thu, 28 Jul 2022 10:21:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376741.609708; Thu, 28 Jul 2022 10:21:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0eR-0002eu-EH; Thu, 28 Jul 2022 10:21:55 +0000 Received: by outflank-mailman (input) for mailman id 376741; Thu, 28 Jul 2022 10:21:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0eQ-0002eo-Td for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 10:21:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0eQ-0005x3-16; Thu, 28 Jul 2022 10:21:54 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH0eP-0004Mq-RL; Thu, 28 Jul 2022 10:21:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=1EhoKiSeiMjgqkW85Q78vSoWSdbljzL0Fj8Qtks2E4c=; b=d8VPTZoNNwFeFjQtuzZQ9gZI7l hEKoQCzxOqoLdSwl+8Ug6jl2cNp7mtp9eZ8siXx5WDWynQ3bzLpG1VHZOTGh8ukmviCfECta7muci pDYXHddCnAUR4WqhGGkNBAOgZPHchpu45y53kkNtMG5okOOXRSUoxtxVeXL6z7QOus6I=; Message-ID: Date: Thu, 28 Jul 2022 11:21:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Content-Language: en-US To: Bertrand Marquis Cc: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> <27786AF4-37EA-4C54-9330-1C9B674BAC87@arm.com> From: Julien Grall In-Reply-To: <27786AF4-37EA-4C54-9330-1C9B674BAC87@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28/07/2022 10:45, Bertrand Marquis wrote: >> On 28 Jul 2022, at 10:35, Julien Grall wrote: >> >> >> >> On 28/07/2022 08:57, Bertrand Marquis wrote: >>> Hi Julien, >> >> Hi Bertrand, >> >>>> On 27 Jul 2022, at 16:46, Julien Grall wrote: >>>> >>>> Hi Xenia, >>>> >>>> On 27/07/2022 16:32, Xenia Ragiadakou wrote: >>>>> Remove unused macro atomic_xchg(). >>>>> Signed-off-by: Xenia Ragiadakou >>>>> --- >>>>> xen/arch/arm/include/asm/atomic.h | 2 -- >>>>> 1 file changed, 2 deletions(-) >>>>> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h >>>>> index f5ef744b4b..a2dc125291 100644 >>>>> --- a/xen/arch/arm/include/asm/atomic.h >>>>> +++ b/xen/arch/arm/include/asm/atomic.h >>>>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u) >>>>> return __atomic_add_unless(v, a, u); >>>>> } >>>>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >>>>> - >>>> >>>> While I agree this is unused today, the wrapper is quite trivial and part of the generic API (x86 also provides one). So I am not in favor of removing it just to please MISRA. >>>> >>>> That said, if Bertrand and Stefano agrees with removing it then you should also remove the x86 version to avoid inconsistency. >>> I think we can keep this and maybe add a comment on top to document a known violation: >>> /* TODO: MISRA_VIOLATION 2.5 */ >> >> While I am fine with this goal of the comment (i.e. indicating where Xen is not MISRA compliant), I think this is one place where I would rather not want one because it can get stale if someones decide to use the function. > > I think the one doing that will have to update the comment otherwise we will never manage to have an analysis without findings. I was under the impression that Xen will never officially follow some of the MISRA rules. So I would expect the tools to be able to detect such cases so we don't have to add a comment for every deviation on something we will never support. > Having those kind of comments in the code for violation also means that they must be updated if the violation is solved. Right, but for thing like unused function, this is quite easy to miss by both the developer and reviewers. So we are going to end up to comments for nothing. > > Maybe we will need a run ignoring those to identify possible violations which are not violations anymore but this might be hard to do. TBH, I think it would be best if we can teach the tools to ignore certain rules. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 10:26:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 10:26:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376747.609719 (Exim 4.92) (envelope-from ) id 1oH0it-0003IA-4v; Thu, 28 Jul 2022 10:26:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376747.609719; Thu, 28 Jul 2022 10:26:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0it-0003I3-1Q; Thu, 28 Jul 2022 10:26:31 +0000 Received: by outflank-mailman (input) for mailman id 376747; Thu, 28 Jul 2022 10:26:30 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH0is-0003Hx-7r for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 10:26:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2070.outbound.protection.outlook.com [40.107.22.70]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id be0d8f4e-0e5f-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 12:26:29 +0200 (CEST) Received: from FR3P281CA0110.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::7) by DU0PR08MB7945.eurprd08.prod.outlook.com (2603:10a6:10:3c9::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.20; Thu, 28 Jul 2022 10:26:27 +0000 Received: from VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com (2603:10a6:d10:a3:cafe::d2) by FR3P281CA0110.outlook.office365.com (2603:10a6:d10:a3::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.1 via Frontend Transport; Thu, 28 Jul 2022 10:26:27 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT041.mail.protection.outlook.com (10.152.19.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 10:26:27 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Thu, 28 Jul 2022 10:26:26 +0000 Received: from aa6c87bb7988.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 9C0AEE14-9F53-4E54-A3C6-5494B82B762D.1; Thu, 28 Jul 2022 10:26:19 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id aa6c87bb7988.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 10:26:19 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by DB9PR08MB6459.eurprd08.prod.outlook.com (2603:10a6:10:256::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 10:26:18 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5482.010; Thu, 28 Jul 2022 10:26:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: be0d8f4e-0e5f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=gsxySUZncXLxvXwyIZrM2czTAogVMFVLCHEMuqzbNfLEhmuqX2lenh6dfWXpnACG/czkWov6oh0oNIEB6NIx/69bG3o3L7jdEqca/a2mUFwIGG5nobJ9hV1Q7todmUPCASUUmPZ/WIHzb8WlIEmcs0hiIeqcKfQKPTwLYIoffzaq9yXyYsE7AOAubZlDJjXHGHdya32CbO1N28AtlYP9DthrtZppXHjlcuuU5zL0MKsECQy4Iob+tlC+86y0rSNlwymy6Jje0qC6en7UNauMTwOLEh1J7RqfYCOv/yLNoQ1t5W8ir3EOdxAc6/0SJRzqe3vG7t2y1nitPN7nSKSxYw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcuKVD3NoJzgb4ZjBlCwVtjxzF18jfH0aGMtqb0ImSo=; b=XLy2XJKImvQA4rQfpVMZBVqqo2LKP5ouw1pc0kUFPVtOb3mgx72BdHnKIjJAKp5B37UDL5Qp42dBEDYU4pjEuv/GNNBnC9k9PwpbBnn44SrbBqB3bTwKA0KAmo1zqzZhGzCSeSm/6u22v4QV0S49tNN2lLFMql9lcYpNtt8cdwARN0G3WCh3Wd4E5qBwSzz0RMVqZ1CsIwo/bzZLD16Bk+SBdLrIfZhK8acU16p1wDKw4m5EHHx5mrZ+DXDc+0FM/b+VMzE3gL76lSeGFDZP3JJZ/dwKxl6IW6mYIScFZRwuw0iV9irX9rGE2RvEnMTpc7gzfuwLFXRqwv/b3J8Tzw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcuKVD3NoJzgb4ZjBlCwVtjxzF18jfH0aGMtqb0ImSo=; b=G58ohe5MwcW3VixxUrtj1QoIg9ucLuW2XbAef6FxFkwh3b6K6y5Zlpfd8B7XLfAhuNBQvJ1iqmymXQPnmYO+L/2MJlGWKJPE2Cp5r3PkQgvJTtaXwQPth/o0DWeg3ozVDO50XzDEhp72fUrBUo0b+ENRxWu2DUT/69OyLJ40h+o= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 07983d8748755b9b X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U/+5K0GvQRuGKWDOL6xmu28oRpKP12zop2xtXO2ZEHsS/JLXFM4zqNnyACL4ElUEu8PI8Alo8596nYBTTIddP8gb0motakob18a7AM9RBsEfo6HfABCwls8aDxtpNa4FriWvwoYtH+89/0/2ktkhvlgMJ+VqLok+theyFSK2Sccm0mWpct94daEafHCT5SuNUFBuXoJMtnL7OcDq+EJNxXpVWuvQ/YsHGIn3pzG/cwEyeTMGqP9iDXHFY38EF8Es9qPWBo2p33pTtVJFOxytZg2raRNT/GoZ1yhxTdVIHZqltui9tNS62mPXlxSAMUe2fChNA+1EpT3KQF9CT35/Qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AcuKVD3NoJzgb4ZjBlCwVtjxzF18jfH0aGMtqb0ImSo=; b=Yeers/MWzdu1kRqQuSokqOJNtZm0ZbUdicRk5A4x88gY/K+OA9jHTZUvdcjl/Ut1mC1+uQ0Sy5YEKEYdR4k5kKspVaUW5enPe5Yu7MzWe/dNsru/rwnOS6+IwZP6Knm5JmAnIW3+bfsP8bOK+z5GfjXHZQ0tRuhzCHBHRmoyeNNEElAXPSIp7PVVvy6N8L9Gd6wrPx+ae8kO//GOhBCHIrvaxbY2TEybsWtis2UPIX35eeTvINX/1Qpoz73vrUcpA4JyblSFBY/ZtcoWfC2swL11/aJsex3wg7HoAQt+KFiI+N2gScRzJurQsmPi1jxcclK5TB66RvpT/P2INT1TRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AcuKVD3NoJzgb4ZjBlCwVtjxzF18jfH0aGMtqb0ImSo=; b=G58ohe5MwcW3VixxUrtj1QoIg9ucLuW2XbAef6FxFkwh3b6K6y5Zlpfd8B7XLfAhuNBQvJ1iqmymXQPnmYO+L/2MJlGWKJPE2Cp5r3PkQgvJTtaXwQPth/o0DWeg3ozVDO50XzDEhp72fUrBUo0b+ENRxWu2DUT/69OyLJ40h+o= From: Bertrand Marquis To: Julien Grall CC: Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Topic: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation Thread-Index: AQHYoc45O9kZLijXrUyjjlrBuGCX1a2SXJWAgAEPNoCAABtvgIAAArUAgAAKKICAAAE+AA== Date: Thu, 28 Jul 2022 10:26:18 +0000 Message-ID: References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> <27786AF4-37EA-4C54-9330-1C9B674BAC87@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 914a6a52-5afa-4ee1-ae09-08da7083a127 x-ms-traffictypediagnostic: DB9PR08MB6459:EE_|VE1EUR03FT041:EE_|DU0PR08MB7945:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: o0M2jukTVudpVoJxPqOojrueu9BeOM1A3bVeD6s9Xu79h+jny+QkaEUOoZvd+k2df1BWC4cojjhv9nhZApUqMHPHhAlzaidpyZP+9X9HS3HOccdtgeoze+Wx0uvIm+DF0NlDo8RyibjwuR8Z2FVWifVP9474VNkeF9VnQWHw5eTfwJH+KYcBiW2UYxROmgWMkkPvPuWMrRhRazAOQjUOssmIHaBndMcMRNnGGTFRRgFV8fj+XPQIWScWFDRuR1eUOCP6ZZAZ7ddFeq47Sh8xz4DRsFIMVqwOWPyqsFWUGgwNVnYZtuQ5HPUUYpB819hEUkbsR1xz7/15noHDI7ciMjpa918eGwhkqkbw8KBPbcqHaIgfyNRDnXfs5gWnfh8yEhBL99khUhPjZ61Q6TQevUAEOvvWIfFG+hbl/Tx871GbwuQiI8msuywLtwF3U5WJzzdRLWagEKwlc/8m7zm5m7bZmSQbzCpgKgHEB8EmxCmSJLM/6IMwhmv4it24FoYteCTjthZfL9EcvkokDllb3MlO5tD1uT1A2Z07S91onmvA0STOO8UDvH8iWZsy1MSYQrUkLI7DqcOKl0XFYkjHivb+8sVKewhvE0+xJWKj5TN5GZPNy+5cWzF8sxhj+S+HTMnc5pgj0vaBZ0REx7MDqCQoc/l7rqkAvIQUqfDiJI/xrkmHYyrtLjjt0GsyIGWl+Xxoi1aYRp6WTlgGO6yFSTLrU6ZZRkJYnbvznuR5EWbfpmWsP/k29AcTOUhTcwUc9MgsUKz34VlWuAe9J9bTmuXK8j76+oWv1r32SeyS/TfcZsOS43YTOJt5sFWCImFzw0ci7o1VlceoIUNP90Cz6A== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(366004)(136003)(39860400002)(396003)(2616005)(41300700001)(186003)(86362001)(316002)(66946007)(53546011)(36756003)(6506007)(5660300002)(122000001)(38070700005)(83380400001)(38100700002)(2906002)(66476007)(4326008)(91956017)(6486002)(54906003)(6512007)(8936002)(33656002)(26005)(71200400001)(76116006)(6916009)(64756008)(478600001)(8676002)(66556008)(66446008)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: <26D1206C212ED64287D7830A763E1A26@eurprd08.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6459 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c6236345-fa1d-4f2b-10b8-08da70839bdd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oAkUozfSUqj5tAzrAWkiAvNd/NmUJLbNnhmWMKvUBtIENgpaRjq+k/eMeBK6q4OnzAlKksMUmCiGLnvceJLXh9rbQUHEQn6RZCN+7ki4R6Z72wM177lTX2im3H1S/eLyFYtBhqbUqxVAT8l5FIv9wU4eBUzpiXRGVX9Y3+T2ZTIdIxlvV9cTfO6HKWgPJaJBDCSW2WVakqLNfIr54eu//jhYG5/NMRj3De/gR6P+A+krY2wOWyzmX8C3AKMyYLFo9f1KAbZjGBhqvBQt/dqBZmURMINimiOHHKamUpVJPqPe5Pka95bnd71arG5H04PQvMBnGgBVfOiCsdRzuSlD/qXVX2FjIUrF8p2Vcpa4sjEDrt0oN3pwyE/e4MY/hxICWaV9V+HgQrzkqAXWmlavF8I4v6chiKHFFzSFzOs66C8n1eqPd0ly4QrqgpAj0euB3s5J5XUjGQimxIJU5wC10opVhC0o88fj8vVf2PKrLiSQhHqwqsY4RYv0aFmJjz3YpG+4GXlNFrJ8tZc3hwl4OUfv1DWSGkTQW9WskhZeWjdOsZlHPbu1iqiuCEEHHh90sVldCjR5XW9Tv3fSEaqb4t7s2NZt6A6IGclVP7BSqqm9cPo7SbrR2nxoFrEB+onA1/F4fYCv6pZORV7eLKHkiBBCjSwjZGrafxV594WFIN0tf9IH3r5H7nVPQYsjvRYQJwdCaDeYtk6E1Xpq8Y6xJp1yS146DzLGoiQqVmaF808KcoAuKfLSzJmyUHyVcVztSZV3GZ5ucVqwB7O70Y/vQ5SLH3QxixDwcRDcOv0B135TufI9fRtEOpNCsWcobxnx X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(136003)(39860400002)(376002)(36840700001)(40470700004)(46966006)(40460700003)(53546011)(47076005)(6512007)(478600001)(83380400001)(86362001)(41300700001)(2906002)(6506007)(2616005)(336012)(5660300002)(186003)(107886003)(40480700001)(36756003)(70206006)(70586007)(356005)(6862004)(8676002)(8936002)(81166007)(4326008)(6486002)(36860700001)(82740400003)(316002)(54906003)(33656002)(26005)(82310400005);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 10:26:27.1855 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 914a6a52-5afa-4ee1-ae09-08da7083a127 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT041.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR08MB7945 Hi Julien, > On 28 Jul 2022, at 11:21, Julien Grall wrote: >=20 >=20 >=20 > On 28/07/2022 10:45, Bertrand Marquis wrote: >>> On 28 Jul 2022, at 10:35, Julien Grall wrote: >>>=20 >>>=20 >>>=20 >>> On 28/07/2022 08:57, Bertrand Marquis wrote: >>>> Hi Julien, >>>=20 >>> Hi Bertrand, >>>=20 >>>>> On 27 Jul 2022, at 16:46, Julien Grall wrote: >>>>>=20 >>>>> Hi Xenia, >>>>>=20 >>>>> On 27/07/2022 16:32, Xenia Ragiadakou wrote: >>>>>> Remove unused macro atomic_xchg(). >>>>>> Signed-off-by: Xenia Ragiadakou >>>>>> --- >>>>>> xen/arch/arm/include/asm/atomic.h | 2 -- >>>>>> 1 file changed, 2 deletions(-) >>>>>> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/includ= e/asm/atomic.h >>>>>> index f5ef744b4b..a2dc125291 100644 >>>>>> --- a/xen/arch/arm/include/asm/atomic.h >>>>>> +++ b/xen/arch/arm/include/asm/atomic.h >>>>>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v,= int a, int u) >>>>>> return __atomic_add_unless(v, a, u); >>>>>> } >>>>>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) >>>>>> - >>>>>=20 >>>>> While I agree this is unused today, the wrapper is quite trivial and = part of the generic API (x86 also provides one). So I am not in favor of re= moving it just to please MISRA. >>>>>=20 >>>>> That said, if Bertrand and Stefano agrees with removing it then you s= hould also remove the x86 version to avoid inconsistency. >>>> I think we can keep this and maybe add a comment on top to document a = known violation: >>>> /* TODO: MISRA_VIOLATION 2.5 */ >>>=20 >>> While I am fine with this goal of the comment (i.e. indicating where Xe= n is not MISRA compliant), I think this is one place where I would rather n= ot want one because it can get stale if someones decide to use the function= . >> I think the one doing that will have to update the comment otherwise we = will never manage to have an analysis without findings. >=20 > I was under the impression that Xen will never officially follow some of = the MISRA rules. So I would expect the tools to be able to detect such case= s so we don't have to add a comment for every deviation on something we wil= l never support. >=20 >> Having those kind of comments in the code for violation also means that = they must be updated if the violation is solved. >=20 > Right, but for thing like unused function, this is quite easy to miss by = both the developer and reviewers. So we are going to end up to comments for= nothing. >=20 >> Maybe we will need a run ignoring those to identify possible violations = which are not violations anymore but this might be hard to do. >=20 > TBH, I think it would be best if we can teach the tools to ignore certain= rules. Definitely it is possible to instruct the tool to ignore this you are right= and for 2.5 we should (for some reason I was under the impression that we = said we would follow 2.5 but accept deviations). @Xenia: please ignore and do not add a comment for this. I think we will need to distinguish 2 kind of not following: - not following at all (disable in the tools) - accepting some deviations (documented in the code) As much as we can, I think we should target the second unless we have a lot= of violations. Cheers Bertrand >=20 > Cheers, >=20 > --=20 > Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 10:54:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 10:54:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376753.609729 (Exim 4.92) (envelope-from ) id 1oH19K-00072c-89; Thu, 28 Jul 2022 10:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376753.609729; Thu, 28 Jul 2022 10:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH19K-00072V-5U; Thu, 28 Jul 2022 10:53:50 +0000 Received: by outflank-mailman (input) for mailman id 376753; Thu, 28 Jul 2022 10:53:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH19J-00072L-6e; Thu, 28 Jul 2022 10:53:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH19J-0006Z8-3C; Thu, 28 Jul 2022 10:53:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH19I-0000vA-Ig; Thu, 28 Jul 2022 10:53:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oH19I-0008C8-IG; Thu, 28 Jul 2022 10:53:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=Mm6FxvfMpGULkxBl/qsac/8Rj4ZUghbGu/LKb3JHJ2M=; b=AOdifJMH9DN82ADFhf9Tg2Sx0a yypOfRh/z2IMXvpbJP8tmial1prnHpDaxXZvNqneQVhQT7c+UVgwyLeg1yGsVQEJSyigws6ek2p5y gTEj04jLe1kf1HLROq1Qnp03gD6iwCFpTMe/04GUzw47MGgCHZJIO/+/JJPcypUy5/JM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171895: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=9c3d398df11024ef6c00a50c98fcc0f1f66c16a1 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Thu, 28 Jul 2022 10:53:48 +0000 flight 171895 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171895/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 9c3d398df11024ef6c00a50c98fcc0f1f66c16a1 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 748 days Failing since 151818 2020-07-11 04:18:52 Z 747 days 729 attempts Testing same since 171895 2022-07-28 04:20:13 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117428 lines long.) From xen-devel-bounces@lists.xenproject.org Thu Jul 28 11:48:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 11:48:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376763.609741 (Exim 4.92) (envelope-from ) id 1oH1zx-0004tT-Fc; Thu, 28 Jul 2022 11:48:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376763.609741; Thu, 28 Jul 2022 11:48:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH1zx-0004tM-Bf; Thu, 28 Jul 2022 11:48:13 +0000 Received: by outflank-mailman (input) for mailman id 376763; Thu, 28 Jul 2022 11:48:12 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH1zv-0004tA-Lc for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 11:48:11 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2054.outbound.protection.outlook.com [40.107.21.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 26ac4f52-0e6b-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 13:48:09 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AM6PR04MB6454.eurprd04.prod.outlook.com (2603:10a6:20b:f4::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 11:48:07 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 11:48:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 26ac4f52-0e6b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAE9UWw7VxfWXvW+4mOxy5HODyiI6YOUdScrj5fiZ2ImfDPEk3YsUUKajs9nMKvqxd83t7qf3ki6fqTa10FfpYrWBeor9XtngQajHF9AwrB++Pcuk25OJfmEhSqXKRTx7tUUZ0MacRTdCsjHUAHILsch64dm+o+LmDthaarfU8bdNCKCqly703ZW7dJ+kWKz4jHy6dlkP0dWTZZ/5Cq7UkrNkdMJbIHqazFfXQC8Pgu5+adi24+7fMHHkGSX+TWfrq9xErOsJPHOO9Lw1uIJ3OAGmBGXOQ1d5m2+Gx6x00scQI0piZsyR761EC5qmR5aENAWL0ilOitpdWxDnm4kfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8p5OZ2TJ5c9CrAJ0KNTAbYyFf1npzTfjTLEFRILvDjY=; b=LPMNW8sfiHt4qPl1kB6B71csAkmGFqIiNcneUvPyXrHs0T5L5eVSsUX6w3XIZQ6oN49o31sImZZDDEUxVBMWGDZl4gYG5azPgml4kWHnPhoUTMYQ/0OgnGth2KbLvsrjGJikkA4eTaikf7SAAOTNNuOCkReOQ0CJ9Gc1sBvu57DRcSy2Ju7tIPulxJpnlKAN6i78YlgPi6dgKFLff0Cu1o9ThkHf1deAN+iNmyh2GIdjSJwuClo0/MaVjQSoPeqWb4jETN5evnKcM1d+xkTcGwS8K+cm1GPg1rOzDgeMJDd3rH5r10LzbZ8W2WT3WG8RwGqRjIM4/f4L8n7Cf78PsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8p5OZ2TJ5c9CrAJ0KNTAbYyFf1npzTfjTLEFRILvDjY=; b=su6ScJ1ceW4sKEqqcuirTXMtTnoErsc11udzqzCFUePE8jIaybQOrkUFHOxQ4bnoUjqWpwfHXYE+GsHaLrxxPNormmX6z7rzWLwuuRM4dzuXX6bj8v4ZRlUOcv1Ssvi1MaDkSF72tvjtZlo9HjroWQ5XDXOGHWzE1rU57O9yblkd0SSfGVW//tIHSd5hS3T4P+NVnVXQ+0u0Z5grbnfz6RqElC4CMXznEULaoMsDcYtrHYJefuGweF/pKVNfm5BMhEOZfeFII75vIa3q9KF7qZD0kdFR0KRHkaZ4gZajtfD4bV2HupnMm4HlAebAtaEwUqICY6Ux1dMzGCF77UCIOg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <88025800-66e2-4fb4-facf-5989e75ba08f@suse.com> Date: Thu, 28 Jul 2022 13:48:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v1] xen: add late init call in start_xen Content-Language: en-US To: boyoun.park@samsung.com Cc: "sstabellini@kernel.org" , "julien@xen.org" , "bertrand.marquis@arm.com" , "Volodymyr_Babchuk@epam.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "wl@xen.org" , "roger.pau@citrix.com" , Chungwoo Park , SoungKwan Kimn , DongJin PARK , Gang Li , Lei Wang , "xen-devel@lists.xenproject.org" References: <97499212.9948800.1659000157467@mail-kr2-3> From: Jan Beulich In-Reply-To: <97499212.9948800.1659000157467@mail-kr2-3> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AS8PR04CA0156.eurprd04.prod.outlook.com (2603:10a6:20b:331::11) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 633e0874-e5cf-4c6e-c27d-08da708f0989 X-MS-TrafficTypeDiagnostic: AM6PR04MB6454:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eVGh/lJ6m1IoXCwltC4Dws+Ykedmjj4KxZNFRwt8N4Ur1UjVFxCNwvMfR0Z5Q9J5N2tiF9BhJLCoyqBESH+vcfzlXSafuYKH3IodUSPt2U2xDtXfjfLstzDOFpqT+s6bEXz7ufeW7R3omGCY9gDJLp/c9FJq1ljVOV+EeSuRxfcrrYVlxOpktIZlUJ5yxZn4ZtknFNb7M6VDTlFeqDjpJjQO2wRipEF3h7a1nLXiqEbMvXQm57bo2Sqf+62rXD8Dnxr6qDikzFFYob9ygJjca18+xlC11z3U9Gm3f1oDPQRNH1ZMk6MRur3OgqqrPKly9KJdRmzv+NW2WJyBeL81NT++1Spc7SPn6S6cyRvKWulIEpH9FH+iUucov0LFyk3CbkAFwlUIs+Ni3tTcNqqGXyauCVHG+HS2XszFm0v2+0nnuBphm4TUY6z5LhYY7Xd+aLQ2L6QoEVTFIxh+g/ax6DNZBxi2UGdpbOr/Vqfe7vGr0yisrn0UIH/h6PkDAx5DMnstHSoRVZ6dLoMYn1/uWaGDtcZ0dX58TOFJ2bal1sPLppplu31+GCsHwE4HcA47lna6KdT+4YgZuEYK9+9ymNMBVW9WFsp8pFypTDx+lH9zjmV9//qUfI4IrznhZtLOJY8XaHBsex0TLXUpB7bHNiC+BYQA9SWbuebnGAp0XdeDPKFoeN0p8JBX0opSTOXwOii5s/K6kHa5Poh5fgN6UYqiu1ZpNc27CgVRAjLJDd2Gtwrb5+UJlxU4VTHb69N3bQxJWZfehvk7ww7kSUCTBMiZwl8ElgddoPKy7TRd0Lk7v0/xWBBnIcH7y9QxYTzTf7f97Ud2QcESFmkc17LvcA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(396003)(366004)(39860400002)(346002)(136003)(31686004)(7416002)(5660300002)(6916009)(6506007)(31696002)(316002)(478600001)(66946007)(8676002)(6486002)(66476007)(54906003)(4326008)(53546011)(8936002)(66556008)(86362001)(83380400001)(38100700002)(186003)(6512007)(26005)(6666004)(2906002)(36756003)(41300700001)(2616005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YzlFd1ZKNytLTTFGdFlGcDBBNDN5dUIwaGIvTGMxZzNKQS9pREtoQ2ZMSU1C?= =?utf-8?B?aWRzd0EvTlVtdUlXcUcxVUFCd1BQdFNVSXlnTjJRTGJMS2dZM3owcVg1TVpH?= =?utf-8?B?QVBCWTJoUHYwaDdpU0hyQXQwU25icWYvZkxieHA2bGRNNjlMRGJySytpeDJ6?= =?utf-8?B?TkRwbC82Z3JBUlZheU54VUxpU3dTT29pSm1UOXM5QjJMOS85TCs4SFVGbzNZ?= =?utf-8?B?TjNpNHBOQWtQaUZTOWVTbEpSR2M3MFBjY0d0Sko2cml1NjRGL1laMW9jeFhq?= =?utf-8?B?ditzNDZyVEZUNnJ3bFJaU2RtWWUwTEY1ZUhvOXdITGRLRFVmUUplcWxON2Fv?= =?utf-8?B?WWhTVkIrNDZQSGVzMXZhcVpuUWxCRFZuQm4yY1hqTDBrMXI2YWlmQnNKSEV2?= =?utf-8?B?eXNsaDRmMDl3eHlQSDFNVmdwOWJEcU0wZVZtTC9sMFpPa3R5aHQxeHJOYTJO?= =?utf-8?B?OFVZMm1HVEpORmF3K3ZZVkt2OWl2eVlsaUh2cG9WUHBIdjNGcFptUFFSUiti?= =?utf-8?B?VVZTT1NHTk5kM2NCZ0RzNk9IajEzRWhJY1lHUnBETVN6TDl0c0hkWHZiUHky?= =?utf-8?B?ZzEvZ0h5MmFXcmRwU0RDaklDbGcxdHFGcG1MZlZIOUdQTXFGMkJYN29pUGZQ?= =?utf-8?B?TnRqTEh1Z2x6K0pXYXMrQzNUYjEzYmttY1RCbWJZNzErY0NyZnRwQnN0dzQz?= =?utf-8?B?MmFEMXR2c2ZUSm9ER0VaOU41eFNoYnNuNm9QU3cyVFNSNk5aNmpuL2FYRzlj?= =?utf-8?B?V25naFZKUC9VODBxRzZqM1BCd3pJcHhIb2ovM21xa0UrY1VtSHNvRkd3NXBy?= =?utf-8?B?elo5TmJGSHN2MnZEZmtQbmpFb3grekZWc0o1ZHAxRTdianM0OXdWVFI3T3Yv?= =?utf-8?B?TGNXSG1iamE5MktuODRRN2s4Yzh3TXI4MlE4N3JEQldXblordXpBR2MrUks1?= =?utf-8?B?Nm5uSjgvZ2JLU1pWZGt0cFE3Y0dDWDhEbFAyYXFqV1B0MDNyd3Flbnk2Nkt0?= =?utf-8?B?UzBvbGFrVlVTTFJvMThNcjdWSEU2dFJHU0ZtZEZDQjU2YURwZVJ3WXZESGdP?= =?utf-8?B?NVNvNGZycC9TRnEvbVd4OWhEb0VOVzFKMzdZb0c0MkptY3ZNNno0MlZsUlRV?= =?utf-8?B?TURqcEo5NUtteCtjaHFSb29rWnVwWDdBaEpmRmJrMDAzV09TTG1OcFR2cXhk?= =?utf-8?B?UldidG9rMENodFg4eXI5OERhM2tOSDJhSHdwQ0FhTVByWWcxdkZxWUxFdnlt?= =?utf-8?B?bmhEUjRORjQwTERDb29IMElzM3VvcEYvWit0TUdXaGZYTDBIaVh3SjFvMi9z?= =?utf-8?B?cU1zcmxRbE1HbFZQM2NPamFaS1J0d0VCdW9HelMzbm9KZHJMWU9UZHJWc1g0?= =?utf-8?B?c3hpcWJGaGlYQS9UcXlSUG84NzQ3eEdsT0pXOVUrMDRWcUI5QTkyUW4zZzZj?= =?utf-8?B?bG0xUkxiNUVTS0tTd3hQWDdWNTkrMnZ2bmtLTE9GSHJmYjlyeUpYenkzL3JT?= =?utf-8?B?NTFvazRzVWZGemMwWjhlT09OdXkrY1hubDI3VEs3b3QvQW9YbWJZalVHTk1u?= =?utf-8?B?K3BSU2pnK0ZFK1g5OEg5OVpYVEJRS2Y0T1FIT2FydXlpQ05rMytLdHlVa2NW?= =?utf-8?B?bEJJcEQxV2pwaGJYay8yaUsyTWY2ZkI3T0RnTUpac3N0ckx3S1NCa3dHN05M?= =?utf-8?B?akswQXdQWXE1WWhrNXpNcFhGaDJOWlpZYnJtRkZweFIxdS9ERVVQNWM5Ykpj?= =?utf-8?B?NmQ0aXV6MUxIVEt1ZXRKZ3R5ZVJUVDg4cUhMZitOOEJHTjIyZ1FRU3g5eHll?= =?utf-8?B?dTdLWGpLdFhoa3lFeVR3c09RT2lCeHkyd2dXNmd3dDhUWEk0dnBoUFJGWjVN?= =?utf-8?B?VTJtNmpKSTFBejdjWHhiLzFkSE1CWFU0RzdmVkpYYi9rWnB3Z0IxYVgwcVZU?= =?utf-8?B?MGZQYWNmbWdLakpuREx3ZW40WmFINmdRVThPb05ZT0x4d1pPVUFDczl1QzZM?= =?utf-8?B?QWtFY01jYkRYb1BlbEh1OXpyeDNyUStNTnc1V0ZpU0xRaEpNQnRpcHM2aDFK?= =?utf-8?B?bWwyeEtQZ2UxSDh3dGJMaDZRMXZMZmx4L3o1YTlnQVdFZ1BQS0liQXhScmJX?= =?utf-8?Q?/k98m5G3MzxxwgKlmA1HfJYBz?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 633e0874-e5cf-4c6e-c27d-08da708f0989 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 11:48:06.9941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eqzfJmMwdvj+bWCc0Q+vwkXv7sVetYAuhlPFgssCNVFVv1i1PUixXQivn2k/6Nlc96VLvc5XVTFoxQQdqufIQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6454 On 28.07.2022 11:22, Boyoun Park wrote: > Hello, > > This patch added late_initcall to deal with > > some init functions which should be called > > after other init functions in start_xen. > > If this patch is added, > > then the original initcall in xen will be treated > > as early_initcall and the late_initcall > > which is added by this patch will be > > called sequentially. > > I cannot send patches through git send-email > > due to some security issues in my work. > > So intead, I just send the patches manually. Which is fine, but you want to configure your mail client such that it doesn't mangle the patch. Albeit I see that to cover for that at least you've also attached both the patch and a cover letter. For a single patch a cover letter can normally be omitted, but if you don't then even if you're sending without "git send-email" you will want to send both as separate mails, with the patch being a reply to the cover letter thread root. > Sorry for the inconvenience. > > I made this patch during using xen for a project. > > And I want to share it and ask for review. > > Boyoun Park. > > From: Boyoun Park > > To: xen-devel@lists.xenproject.org > > Cc: Stefano Stabellini > > Cc: Julien Grall > > Cc: Bertrand Marquis > > Cc: Volodymyr Babchuk > > Cc: Andrew Cooper > > Cc: George Dunlap > > Cc: Jan Beulich > > Cc: Wei Liu > > Cc: "Roger Pau Monné" > > Date: Tue, 15 Mar 2022 12:57:59 +0900 > > Subject: [PATCH v1] xen: add late init call in start_xen > > This patch added late_initcall section in init.data. > > The late initcall would be called after initcall > > in the start_xen function. > > Some initializing works on priority should be run > > in do_initcalls and other non-prioritized works > > would be run in do_late_initcalls. > > To call some functions by late_initcall, > > then it is possible by using > > __late_initcall(/*Function Name*/); > > Signed-off-by: Boyoun Park So I could imagine this patch to be in a series where a subsequent patch then adds an actual use of the new functionality. Without that what you're proposing is to add dead code. > @@ -1964,6 +1966,7 @@ void __init noreturn __start_xen(unsigned long mbi_p) > > bsp_info = get_cpu_info_from_stack((unsigned long)bsp_stack); > > *bsp_info = *info; > > + /* Jump to the 1:1 virtual mappings of cpu0_stack. */ > > asm volatile ("mov %[stk], %%rsp; jmp %c[fn]" :: > > [stk] "g" (&bsp_info->guest_cpu_user_regs), > > [fn] "i" (reinit_bsp_stack) : "memory"); How does this addition of a comment relate to the purpose of the patch? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 12:53:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 12:53:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376770.609752 (Exim 4.92) (envelope-from ) id 1oH31D-0004Qe-BO; Thu, 28 Jul 2022 12:53:35 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376770.609752; Thu, 28 Jul 2022 12:53:35 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH31D-0004QX-81; Thu, 28 Jul 2022 12:53:35 +0000 Received: by outflank-mailman (input) for mailman id 376770; Thu, 28 Jul 2022 12:53:34 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH31C-0004QR-EZ for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 12:53:34 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 47bc9eb9-0e74-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 14:53:32 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 47bc9eb9-0e74-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659012812; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ng7b+AAgMXcZ/+TJuJcCEeWQ4bsCFjToHv0fp7P5JkI=; b=VPwook7Tzvu0O6kA9FYyJapx1D9tGOyQIAdb+rf9h87KypRj+11U6Jz3 sONbzX0kFVF1xuKUEO99i2Q/ZZ7gpmuTH1TejsL6BZqXZSJUDxBl06uzI ZsehT/Ll17WfGMpXFZz47WTq6hF9PXLANaDfvAbVSZgDG1iHgDiIqKbUh w=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76112333 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:c5VvaqhWJ3cMKYa7cwBnfNCNX161BhcKZh0ujC45NGQN5FlHY01je htvW2uEO/3bN2HyLo1yaI7koxkAsMXWnIUxTQA4/n0zF3wb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oDJ9CU6j+fQLlbFILasEjhrQgN5QzsWhxtmmuoo6qZlmtH8CA6W0 T/Ii5S31GSNhnglaQr414rZ8Ek15Kuo6GtC1rADTasjUGH2xiF94K03fcldH1OgKqFIE+izQ fr0zb3R1gs1KD90V7tJOp6iGqE7aua60Tqm0xK6aID76vR2nQQg075TCRYpQRw/ZwNlPTxG4 I4lWZSYEW/FN0BX8QgXe0Ew/ypWZcWq9FJbSJQWXAP6I0DuKhPRL/tS4E4eFs40x8h2JzF33 uESEwsRT02FucS6z+fuIgVsrpxLwMjDOYoevjdrzC3DDOZgSpfGK0nIzYYGhnFq3JkIRKuAI ZpCAdZsRE2ojxlnGF4RBdQbleOhgnD5fhVTqU6PpLpx6G/WpOB0+OezaYOPIYfRLSlTthuSi HPE3UDTOFIDJsW42AqL0S6slNaayEsXX6pNTeblp5aGmma7wWgeCwYfU1ehluWokU61W99ZK Es89zInqO4580nDZsLmQxSyrXqAvxgdc9ldCes37EeK0KW8yxbJWEAHQyRHZdhgs9U5LRQo2 UWOhMjBHiF0vfueTnf13qeZq3a+NDYYKUcGZDQYVk0V7t/7uoYxgxnTCNF5H8adi934CDf96 zmPpTo5gfMfgKYj1a+24FTGiDKEvYXSQ0g+4QC/dn6q6hNRYI+jepCy7l7a/bBMIe6xRF6bv WNCnNOC9ucQFpKcvCuXSe4JEfei4PPtGDndh0N/Wpos7TKg/1a9co1KpjJzPkFkNoADYzCBS ErSvwxWzIVeMHujcel8ZIfZI8QyxIDyBMjiTLbfad8mSpR4agLB/ChofkOW92TsllU816A5J ZqfN82rCB4yA7xPxT63SuFNl7Mmrh3S3kuKG8q9lU7+l+PDOjjFEt/pLWdicMgSr4+5jgTzo +90KsGx8Al+DevARCXYpNt7wU8xEZQrOXzng5UJK77Sf1s4RDhJ5+z5mu14JdE890hBvqKRp yzmBBcFoLbqrSefQThmfEyPf18GsXxXiXsgdRIhMl+zs5TISdb+tfxPH3fbkFROyQCC8RKXZ 6NcEyl4Kq4TIgkrAhxEBXUHkKRsdQ6wmSWFNDe/bT40cvZIHlKUqo64IFq/qnhUU0JbUPfSR JX5jGvmrWcrHVw+XK46ltr0p79OgZTtsL0rBBaZSjWiUE7t7JJrO0TMsxPDGOlVcE2r7mbLi G6r7eIw/7alT3kdrIaU3shpbu6BT4NDI6atNzKKs+7naneBozvLLE0peL/gQA0xnVjcoM2KD di5BdmlWBHbtD6ma7ZBLos= IronPort-HdrOrdr: A9a23:XtZmI6wElHoWjHQ9EVstKrPwIL1zdoMgy1knxilNoRw8SKKlfq eV7ZMmPH7P+VIssR4b+exoVJPtfZq+z+8R3WByB8bAYOCOggLBR+sO0WKL+UyHJ8SUzI9gPM lbHJSWcOeAb2RHsQ== X-IronPort-AV: E=Sophos;i="5.93,198,1654574400"; d="scan'208";a="76112333" From: Jane Malalane To: LKML CC: Jane Malalane , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "Maximilian Heyne" , Subject: [PATCH v3] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Date: Thu, 28 Jul 2022 13:52:44 +0100 Message-ID: <20220728125244.19163-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Implement support for the HVMOP_set_evtchn_upcall_vector hypercall in order to set the per-vCPU event channel vector callback on Linux and use it in preference of HVM_PARAM_CALLBACK_IRQ. If the per-VCPU vector setup is successful on BSP, use this method for the APs. If not, fallback to the global vector-type callback. Also register callback_irq at per-vCPU event channel setup to trick toolstack to think the domain is enlightened. Suggested-by: "Roger Pau Monné" Signed-off-by: Jane Malalane --- CC: Juergen Gross CC: Boris Ostrovsky CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: x86@kernel.org CC: "H. Peter Anvin" CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: Jan Beulich CC: Maximilian Heyne CC: xen-devel@lists.xenproject.org v3: * comment style * add comment on toolstack trick * remove unnecessary variable and function call * surround x86-specific code with #ifdef v2: * remove no_vector_callback * make xen_have_vector_callback a bool * rename xen_ack_upcall to xen_percpu_upcall * fail to bring CPU up on init instead of crashing kernel * add and use xen_set_upcall_vector where suitable * xen_setup_upcall_vector -> xen_init_setup_upcall_vector for clarity --- arch/x86/include/asm/xen/cpuid.h | 2 ++ arch/x86/include/asm/xen/events.h | 3 ++- arch/x86/xen/enlighten.c | 2 +- arch/x86/xen/enlighten_hvm.c | 24 ++++++++++++----- arch/x86/xen/suspend_hvm.c | 10 ++++++- drivers/xen/events/events_base.c | 54 +++++++++++++++++++++++++++++++++----- include/xen/hvm.h | 2 ++ include/xen/interface/hvm/hvm_op.h | 19 ++++++++++++++ 8 files changed, 101 insertions(+), 15 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 78e667a31d6c..6daa9b0c8d11 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -107,6 +107,8 @@ * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* Per-vCPU event channel upcalls */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) diff --git a/arch/x86/include/asm/xen/events.h b/arch/x86/include/asm/xen/events.h index 068d9b067c83..62bdceb594f1 100644 --- a/arch/x86/include/asm/xen/events.h +++ b/arch/x86/include/asm/xen/events.h @@ -23,7 +23,7 @@ static inline int xen_irqs_disabled(struct pt_regs *regs) /* No need for a barrier -- XCHG is a barrier on x86. */ #define xchg_xen_ulong(ptr, val) xchg((ptr), (val)) -extern int xen_have_vector_callback; +extern bool xen_have_vector_callback; /* * Events delivered via platform PCI interrupts are always @@ -34,4 +34,5 @@ static inline bool xen_support_evtchn_rebind(void) return (!xen_hvm_domain() || xen_have_vector_callback); } +extern bool xen_percpu_upcall; #endif /* _ASM_X86_XEN_EVENTS_H */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 30c6e986a6cd..b8db2148c07d 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_start_info); struct shared_info xen_dummy_shared_info; -__read_mostly int xen_have_vector_callback; +__read_mostly bool xen_have_vector_callback = true; EXPORT_SYMBOL_GPL(xen_have_vector_callback); /* diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 8b71b1dd7639..198d3cd3e9a5 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -7,6 +7,8 @@ #include #include +#include +#include #include #include @@ -30,6 +32,9 @@ static unsigned long shared_info_pfn; +__ro_after_init bool xen_percpu_upcall; +EXPORT_SYMBOL_GPL(xen_percpu_upcall); + void xen_hvm_init_shared_info(void) { struct xen_add_to_physmap xatp; @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) { struct pt_regs *old_regs = set_irq_regs(regs); + if (xen_percpu_upcall) + ack_APIC_irq(); + inc_irq_stat(irq_hv_callback_count); xen_hvm_evtchn_do_upcall(); @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) if (!xen_have_vector_callback) return 0; + if (xen_percpu_upcall) { + rc = xen_set_upcall_vector(cpu); + if (rc) { + WARN(1, "HVMOP_set_evtchn_upcall_vector" + " for CPU %d failed: %d\n", cpu, rc); + return rc; + } + } + if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); @@ -188,8 +205,6 @@ static int xen_cpu_dead_hvm(unsigned int cpu) return 0; } -static bool no_vector_callback __initdata; - static void __init xen_hvm_guest_init(void) { if (xen_pv_domain()) @@ -211,9 +226,6 @@ static void __init xen_hvm_guest_init(void) xen_panic_handler_init(); - if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) - xen_have_vector_callback = 1; - xen_hvm_smp_init(); WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); xen_unplug_emulated_devices(); @@ -239,7 +251,7 @@ early_param("xen_nopv", xen_parse_nopv); static __init int xen_parse_no_vector_callback(char *arg) { - no_vector_callback = true; + xen_have_vector_callback = false; return 0; } early_param("xen_no_vector_callback", xen_parse_no_vector_callback); diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c index 9d548b0c772f..0c4f7554b7cc 100644 --- a/arch/x86/xen/suspend_hvm.c +++ b/arch/x86/xen/suspend_hvm.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "xen-ops.h" @@ -14,6 +15,13 @@ void xen_hvm_post_suspend(int suspend_cancelled) xen_hvm_init_shared_info(); xen_vcpu_restore(); } - xen_setup_callback_vector(); + if (xen_percpu_upcall) { + unsigned int cpu; + + for_each_online_cpu(cpu) + BUG_ON(xen_set_upcall_vector(cpu)); + } else { + xen_setup_callback_vector(); + } xen_unplug_emulated_devices(); } diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 46d9295d9a6e..3681770589f5 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #endif #include @@ -2183,6 +2184,7 @@ static struct irq_chip xen_percpu_chip __read_mostly = { .irq_ack = ack_dynirq, }; +#ifdef CONFIG_X86 #ifdef CONFIG_XEN_PVHVM /* Vector callbacks are better than PCI interrupts to receive event * channel notifications because we can receive vector callbacks on any @@ -2195,11 +2197,49 @@ void xen_setup_callback_vector(void) callback_via = HVM_CALLBACK_VECTOR(HYPERVISOR_CALLBACK_VECTOR); if (xen_set_callback_via(callback_via)) { pr_err("Request for Xen HVM callback vector failed\n"); - xen_have_vector_callback = 0; + xen_have_vector_callback = false; } } } +/* + * Setup per-vCPU vector-type callbacks and trick toolstack to think + * we are enlightened. If this setup is unavailable, fallback to the + * global vector-type callback. + */ +static __init void xen_init_setup_upcall_vector(void) +{ + if (!xen_have_vector_callback) + return; + + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && + !xen_set_upcall_vector(0)) + xen_percpu_upcall = true; + else if (xen_feature(XENFEAT_hvm_callback_vector)) + xen_setup_callback_vector(); + else + xen_have_vector_callback = false; +} + +int xen_set_upcall_vector(unsigned int cpu) +{ + int rc; + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, cpu), + }; + + rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op); + if (rc) + return rc; + + /* Trick toolstack to think we are enlightened. */ + if (!cpu) + rc = xen_set_callback_via(1); + + return rc; +} + static __init void xen_alloc_callback_vector(void) { if (!xen_have_vector_callback) @@ -2210,8 +2250,11 @@ static __init void xen_alloc_callback_vector(void) } #else void xen_setup_callback_vector(void) {} +static inline void xen_init_setup_upcall_vector(void) {} +int xen_set_upcall_vector(unsigned int cpu) {} static inline void xen_alloc_callback_vector(void) {} -#endif +#endif /* CONFIG_XEN_PVHVM */ +#endif /* CONFIG_X86 */ bool xen_fifo_events = true; module_param_named(fifo_events, xen_fifo_events, bool, 0); @@ -2271,10 +2314,9 @@ void __init xen_init_IRQ(void) if (xen_initial_domain()) pci_xen_initial_domain(); } - if (xen_feature(XENFEAT_hvm_callback_vector)) { - xen_setup_callback_vector(); - xen_alloc_callback_vector(); - } + xen_init_setup_upcall_vector(); + xen_alloc_callback_vector(); + if (xen_hvm_domain()) { native_init_IRQ(); diff --git a/include/xen/hvm.h b/include/xen/hvm.h index b7fd7fc9ad41..8da7a6747058 100644 --- a/include/xen/hvm.h +++ b/include/xen/hvm.h @@ -60,4 +60,6 @@ static inline int hvm_get_parameter(int idx, uint64_t *value) void xen_setup_callback_vector(void); +int xen_set_upcall_vector(unsigned int cpu); + #endif /* XEN_HVM_H__ */ diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h index f3097e79bb03..03134bf3cec1 100644 --- a/include/xen/interface/hvm/hvm_op.h +++ b/include/xen/interface/hvm/hvm_op.h @@ -46,4 +46,23 @@ struct xen_hvm_get_mem_type { }; DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type); +#if defined(__i386__) || defined(__x86_64__) + +/* + * HVMOP_set_evtchn_upcall_vector: Set a that should be used for event + * channel upcalls on the specified . If set, + * this vector will be used in preference to the + * domain global callback via (see + * HVM_PARAM_CALLBACK_IRQ). + */ +#define HVMOP_set_evtchn_upcall_vector 23 +struct xen_hvm_evtchn_upcall_vector { + uint32_t vcpu; + uint8_t vector; +}; +typedef struct xen_hvm_evtchn_upcall_vector xen_hvm_evtchn_upcall_vector_t; +DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_evtchn_upcall_vector_t); + +#endif /* defined(__i386__) || defined(__x86_64__) */ + #endif /* __XEN_PUBLIC_HVM_HVM_OP_H__ */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 12:54:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 12:54:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376775.609763 (Exim 4.92) (envelope-from ) id 1oH32X-0004xb-MT; Thu, 28 Jul 2022 12:54:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376775.609763; Thu, 28 Jul 2022 12:54:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH32X-0004xU-Jn; Thu, 28 Jul 2022 12:54:57 +0000 Received: by outflank-mailman (input) for mailman id 376775; Thu, 28 Jul 2022 12:54:56 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH32W-0004uo-02 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 12:54:56 +0000 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [2a00:1450:4864:20::52e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a775d95-0e74-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 14:54:55 +0200 (CEST) Received: by mail-ed1-x52e.google.com with SMTP id o13so2105659edc.0 for ; Thu, 28 Jul 2022 05:54:55 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id r15-20020aa7d58f000000b0043cc1611581sm629027edq.85.2022.07.28.05.54.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 05:54:54 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a775d95-0e74-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=x0LXF7PM4Q0j1gUk4V6+jfW2368b3X14IEK5LIspfOk=; b=E0riyxrVLkc+roCiHi5ouTTA8ghMCs/AGens+hxc3W+6l8Lh8LatFVI2WokoYkd88Y pYtOmUNh7oFihFcy5+HAzaixXZrM6+ViwYDbuex1sVaaFywfQLgftWwyU0nAPG8JPHzE KhgNw6yvefy18dCS/eSzdOlul0CFFDfUK/WkVVnW1+0HJzaVncH9OJkZT8d2LG9WuFJ4 88risnOBAyCTmpnSqpHxWVxxwtBbw85ENzVMV9jAZfOC3TStFX3m0HfXLQiN3jlM06ns EV18nSlPmi6pNo8FQ1vczdg1Kc3YwLVGbqgp0N32+OvyyPz5CJbocE/Ns+Lg0/044Vy8 8ttA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x0LXF7PM4Q0j1gUk4V6+jfW2368b3X14IEK5LIspfOk=; b=K1Q6X9C7BG+KYy7YVdkdDRfUWj7p0ePa187y6xLqGOUlifn1H9RTxrck0nwgVyBVYx NKBIhj2D5zESUo0cCX+8wWC1zXFDuPKTBDoOXyxqN1S1r47UOJeD+xMjiywDun0XLdpP zvqUPOARV6yMduSQ+h1rACojusIKM4ggg36SB7YdjRu9605WbWZOqF7zTQOvp4BePSpg zoVQuUdCzRajn7MzfMJFNeBKOlYt+X6LTxbvUX+KWWn4pfQJaWxIVVSbsx8cpBRYgMPi YcfElitm8XKaWFGKB/62zP2opdXUfYdtMpH2P3WzvMtVLDP5yKQ9TLZSaRcZ2xFmc3SL u8tw== X-Gm-Message-State: AJIora+e0101VHqWbVJDBOeZKcGq2Y7fGGm0S/9ywJCeBemoMAM8AuCd hmmHdIrdnU01/P1s8K33bPg= X-Google-Smtp-Source: AGRyM1sAoREU39SNHdZjGj04VlT27SvRvX8uLh9wkRDLg/FddfpMgHhqSRxdUMumSv9ciBre+EDgVw== X-Received: by 2002:a05:6402:1859:b0:43c:b0db:3f9a with SMTP id v25-20020a056402185900b0043cb0db3f9amr8097267edy.120.1659012894789; Thu, 28 Jul 2022 05:54:54 -0700 (PDT) Message-ID: <3942ab28-95ef-b7ca-fa81-9243572dca9c@gmail.com> Date: Thu, 28 Jul 2022 15:54:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728075709.1175445-1-burzalodowa@gmail.com> <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> From: Xenia Ragiadakou In-Reply-To: <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/28/22 12:26, Jan Beulich wrote: > On 28.07.2022 09:57, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/include/asm/current.h >> +++ b/xen/arch/arm/include/asm/current.h >> @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) >> >> #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) >> >> +extern void return_to_new_vcpu32(void); >> +extern void return_to_new_vcpu64(void); > > While ultimately it's the Arm maintainers to judge, may I suggest that > these be put in arm/domain.c to limit visibility? I agree with you. Will fix and resend. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:06:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:06:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376782.609774 (Exim 4.92) (envelope-from ) id 1oH3DG-0006jB-OJ; Thu, 28 Jul 2022 13:06:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376782.609774; Thu, 28 Jul 2022 13:06:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3DG-0006j4-JU; Thu, 28 Jul 2022 13:06:02 +0000 Received: by outflank-mailman (input) for mailman id 376782; Thu, 28 Jul 2022 13:06:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3DF-0006iy-Ea for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:06:01 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3DB-0000s9-1B; Thu, 28 Jul 2022 13:05:57 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH3DA-0004BS-Pw; Thu, 28 Jul 2022 13:05:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=bWNYgr7B6E95S2zwtcIdKCehnHgLISxp9qvCAtKhwok=; b=eKNZkqm9dLaFjWVxey+qRt0XiU mWEKb/ROiPWOOYaV+CzAf096JLEXxGkdVEGkLrTkwxHH/cZdOVB+xLIwlN5yihWS/0egsN+xAoC1G CWMdDLVwSChnd8082N2w4NGv/mxibNW9r2K5lU6tQTTJq+wn7uCxM93+OCi8KNEhCGDc=; Message-ID: <4ba6b639-61c2-12e4-8210-07115d7e50ba@xen.org> Date: Thu, 28 Jul 2022 14:05:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich , Xenia Ragiadakou Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728075709.1175445-1-burzalodowa@gmail.com> <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> From: Julien Grall In-Reply-To: <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/07/2022 10:26, Jan Beulich wrote: > On 28.07.2022 09:57, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/include/asm/current.h >> +++ b/xen/arch/arm/include/asm/current.h >> @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) >> >> #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) >> >> +extern void return_to_new_vcpu32(void); >> +extern void return_to_new_vcpu64(void); > > While ultimately it's the Arm maintainers to judge, may I suggest that > these be put in arm/domain.c to limit visibility? In general, I am not in favor of declaring prototype outside of headers. That said, I would be okay with it for the two prototypes because: 1) they are prototypes for assembly functions 2) declaring in current.h sounds wrong. A better place would be domain.h but this would not reduce the visibility too much 3) this is unlikely to be used by other part of Xen Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:41:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:41:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376790.609785 (Exim 4.92) (envelope-from ) id 1oH3lp-00039T-9O; Thu, 28 Jul 2022 13:41:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376790.609785; Thu, 28 Jul 2022 13:41:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3lp-00039M-5V; Thu, 28 Jul 2022 13:41:45 +0000 Received: by outflank-mailman (input) for mailman id 376790; Thu, 28 Jul 2022 13:41:43 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3ln-00039G-SZ for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:41:43 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 038ea223-0e7b-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 15:41:42 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id l23so3230694ejr.5 for ; Thu, 28 Jul 2022 06:41:42 -0700 (PDT) Received: from [192.168.1.93] (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.gmail.com with ESMTPSA id e26-20020a170906315a00b0072b16a57cdcsm432024eje.118.2022.07.28.06.41.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 06:41:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 038ea223-0e7b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=hz8YQr4+g0Y9Ik+45wwXLUukS9ICs1DRPl41cz+x0kY=; b=IJNCHwpBA3KvaD70ce/XE0T6zrZHuge7M7cjX77ef8mdTzhtvNC0b2SWYS3czm10RX b4ZnlzWW2zwod6eC35czBI9KRFviPbVwI5IqyGvfZbK8N28V6s32q8AUVj9jskH9y9NE gKuzWBc7+OEAJ98xAVfZJRiRaMEr9860VoMeqondhWoECB60Xj6b7g6PP3VgQ7eTXWON rGVC2TFp/VSFeW+GKDB2bHHv/PhPsJGFAiAuSWDoMHQfdYM/gYKMgrRPF8HiQplTS6EI X30B6H6AS5byc2+1T2BEbL6PO4sg4NK+ZmWM9NRjLedVl4RJt/w1kr8k4/cBK21CnysF kLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hz8YQr4+g0Y9Ik+45wwXLUukS9ICs1DRPl41cz+x0kY=; b=seOV5/kv4UWdUg6Pay/eOmmx4abImQ+LdfbMPByVP0C6WOx2vFZJN0I0AWOkag8Smo Ms3Xm2DhoFDm63c06qlp3LEtjL5I4kGgiAs1fsTZDrjpy/clKDXtug6JFbkd67u3+9CO zzzM9lmMygvVIEYM8tA8PNm9UlORS5WNXnjFVr+9ezrjF9fps6VtwPhq5kwcdMrZim8z mPBAtsQTYVGhDOz8jtEOtfyeNiIS1TyGNAxqhQbgUEhvAYXf0z1D0WPjumFFO8Un2/qR 8RLfrUFQGBMRgW5/QV4ErivvZmEca9OjFsZQanABd+EcQ3s7H2Xi9NNSEuQixJ305PrK dg6Q== X-Gm-Message-State: AJIora91VdGvN6LBjUUGK2L3FPPD/6l00CwsRGTfmcTIMqFa4ZCeG95P tUjPldmFsWAWcTMdWiPB9Ug= X-Google-Smtp-Source: AGRyM1vphgCd7zYw4krmLNHu2KaGYkJNk9iV2aaDzE8oh6XRXjscc8Bn4QVWliSxtTrKnzCVi6C2Aw== X-Received: by 2002:a17:907:724c:b0:72e:e6fe:5ea4 with SMTP id ds12-20020a170907724c00b0072ee6fe5ea4mr21672530ejc.421.1659015701970; Thu, 28 Jul 2022 06:41:41 -0700 (PDT) Message-ID: <96788863-8fd3-97c0-2c7b-8f1fc5a1e8f3@gmail.com> Date: Thu, 28 Jul 2022 16:41:40 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728075709.1175445-1-burzalodowa@gmail.com> <8d2bbddf-f871-5c64-6f95-f6f34edfb730@suse.com> <4ba6b639-61c2-12e4-8210-07115d7e50ba@xen.org> From: Xenia Ragiadakou In-Reply-To: <4ba6b639-61c2-12e4-8210-07115d7e50ba@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/28/22 16:05, Julien Grall wrote: > Hi, > > On 28/07/2022 10:26, Jan Beulich wrote: >> On 28.07.2022 09:57, Xenia Ragiadakou wrote: >>> --- a/xen/arch/arm/include/asm/current.h >>> +++ b/xen/arch/arm/include/asm/current.h >>> @@ -44,8 +44,11 @@ static inline struct cpu_info *get_cpu_info(void) >>>   #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) >>> +extern void return_to_new_vcpu32(void); >>> +extern void return_to_new_vcpu64(void); >> >> While ultimately it's the Arm maintainers to judge, may I suggest that >> these be put in arm/domain.c to limit visibility? > > In general, I am not in favor of declaring prototype outside of headers. > That said, I would be okay with it for the two prototypes because: >   1) they are prototypes for assembly functions >   2) declaring in current.h sounds wrong. A better place would be > domain.h but this would not reduce the visibility too much >   3) this is unlikely to be used by other part of Xen What I will ask is irrelevant to the placement but relevant to the declaration itself. I should also have declared them noreturn, right? -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:44:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:44:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376795.609795 (Exim 4.92) (envelope-from ) id 1oH3oD-0003jR-LS; Thu, 28 Jul 2022 13:44:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376795.609795; Thu, 28 Jul 2022 13:44:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3oD-0003jK-Ij; Thu, 28 Jul 2022 13:44:13 +0000 Received: by outflank-mailman (input) for mailman id 376795; Thu, 28 Jul 2022 13:44:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3oC-0003jC-Tm for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:44:13 +0000 Received: from sender4-of-o51.zoho.com (sender4-of-o51.zoho.com [136.143.188.51]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 59b6deb0-0e7b-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 15:44:10 +0200 (CEST) Received: from [10.10.1.164] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 165901584069079.73373381885733; Thu, 28 Jul 2022 06:44:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 59b6deb0-0e7b-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; t=1659015846; cv=none; d=zohomail.com; s=zohoarc; b=GD4tUhfVP2lCne6+H74NmvjGCf7IqGsr4qtgni6GVzMg4SpyMaUIXTDGyIggrS5mv90azfoKjfOE9YkD6slnMv9ykpF4xjgv4oZihA2sD3CNI0iDdnydFyF0SCs8kuvdTHZqjhC1bulYzqcYOCymB9OiJ0uSnEYxbw/vwTHMkIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659015846; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=WhkfHmQIFWCfqZmvNGvalf8cSH4ULdgERHVpM9FNsYk=; b=SVHTP9EatwlWwsVEUrzlnzW31DxYp79SAUM4ktYuh5ROuntx3eV4biM/r3HEX1cBeEm5JNQjLr1o6rmCjzUXPUfQT0sC2VboLXlIEiE6SMMIettX1TerKiBIccuH69DPy8Nv2by67yyYQg6+G1NjYcN9RnOfMatrRocvkfaHlh0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1659015846; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=WhkfHmQIFWCfqZmvNGvalf8cSH4ULdgERHVpM9FNsYk=; b=NDCUPS8Ksqp5ruKPqzmiv6ymOP0szvuK4T0CewbkXNHlXJUvhhJRa97nkD1VNgeG xKuOQ+0cZw1LjbrEbIsw89ZwJ1ukDdGusuIWARfuVwQIO82cLRY8jPVtLQ2qFgpuQFI sSMvvgkRHNguE/SH1ax7oT5XbzLwxL0GoeTeQ8O0= Message-ID: <472e25cf-79aa-0969-177a-0cf4846d707e@apertussolutions.com> Date: Thu, 28 Jul 2022 09:42:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v7] evtchn: convert domain event lock to an r/w one Content-Language: en-US To: Jan Beulich , "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Kevin Tian References: From: "Daniel P. Smith" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/27/22 11:56, Jan Beulich wrote: > Especially for the use in evtchn_move_pirqs() (called when moving a vCPU > across pCPU-s) and the ones in EOI handling in PCI pass-through code, > serializing perhaps an entire domain isn't helpful when no state (which > isn't e.g. further protected by the per-channel lock) changes. > > Unfortunately this implies dropping of lock profiling for this lock, > until r/w locks may get enabled for such functionality. > > While ->notify_vcpu_id is now meant to be consistently updated with the > per-channel lock held, an extension applies to ECS_PIRQ: The field is > also guaranteed to not change with the per-domain event lock held for > writing. Therefore the link_pirq_port() call from evtchn_bind_pirq() > could in principle be moved out of the per-channel locked regions, but > this further code churn didn't seem worth it. > > Signed-off-by: Jan Beulich > --- > v6: Re-vive and re-base. > v5: Re-base, also over dropped earlier patch. > v4: Re-base, in particular over new earlier patches. Acquire both > per-domain locks for writing in evtchn_close(). Adjust > spin_barrier() related comments. > v3: Re-base. > v2: Consistently lock for writing in evtchn_reset(). Fix error path in > pci_clean_dpci_irqs(). Lock for writing in pt_irq_time_out(), > hvm_dirq_assist(), hvm_dpci_eoi(), and hvm_dpci_isairq_eoi(). Move > rw_barrier() introduction here. Re-base over changes earlier in the > series. > > --- a/xen/xsm/flask/flask_op.c > +++ b/xen/xsm/flask/flask_op.c > @@ -530,7 +530,7 @@ static int flask_get_peer_sid(struct xen > struct evtchn *chn; > struct domain_security_struct *dsec; > > - spin_lock(&d->event_lock); > + read_lock(&d->event_lock); > > if ( !port_is_valid(d, arg->evtchn) ) > goto out; > @@ -548,7 +548,7 @@ static int flask_get_peer_sid(struct xen > rv = 0; > > out: > - spin_unlock(&d->event_lock); > + read_unlock(&d->event_lock); > return rv; > } Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:49:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:49:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376803.609807 (Exim 4.92) (envelope-from ) id 1oH3ta-0004dD-DE; Thu, 28 Jul 2022 13:49:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376803.609807; Thu, 28 Jul 2022 13:49:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3ta-0004d6-AX; Thu, 28 Jul 2022 13:49:46 +0000 Received: by outflank-mailman (input) for mailman id 376803; Thu, 28 Jul 2022 13:49:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3tY-0004d0-MC for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:49:44 +0000 Received: from sender4-of-o50.zoho.com (sender4-of-o50.zoho.com [136.143.188.50]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 20ce845e-0e7c-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 15:49:43 +0200 (CEST) Received: from [10.10.1.164] (static-72-81-132-2.bltmmd.fios.verizon.net [72.81.132.2]) by mx.zohomail.com with SMTPS id 1659016175847317.65226815143023; Thu, 28 Jul 2022 06:49:35 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 20ce845e-0e7c-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; t=1659016178; cv=none; d=zohomail.com; s=zohoarc; b=RZ3/5+OgMnn7+i4WOylOm9oMJtBE29tVxj6LMMFZj2P6LOq35s2H6y5xK26KRot0wU/93NRsCKGSPv0b9hunZvEch1tBva9NsmYEjUJha5RK1Sh4MQb/KotjPE1MSPsJZWM2f/SmXGrTdainauQKWtSgdyMvvWZDc86deDYp5Bc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1659016178; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=afEealVpeYYQ911mkvyUU5lYhSkqtAYFJ71SELmAqOw=; b=eXb0Ulq7C1tdaWv6RKe0uy27S/+OexMmRv5UfhCV3GoSv4ulJkdM1TwPxA1qI4yRV0uQB8L6GSmM9ffYNn55OYq6pRSETGD8/pNfUhtLzP6mj0W7n8AEo9WeM2tbmDCM0Ld/w0/MqxTxgrqRnfSKyqtyqpjvN9w0ssdu8rwOfj0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@apertussolutions.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1659016178; s=zoho; d=apertussolutions.com; i=dpsmith@apertussolutions.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=afEealVpeYYQ911mkvyUU5lYhSkqtAYFJ71SELmAqOw=; b=MQVAUv/Mx0HLttTef6MHBbFVOw7C6KlHQSQ32R+nylvBnqxF99QCiPJBhx1h22zO o04iyhyY8EhhJTmpDG3Iokos1ypf6N2tbZEwLrwpRYxFUaoKzJl6uCJNZC5HxW6oA8k pcgmrFj6n9BoAm36nCz/HmV3CIQ2sVTXJ6syqsDI= Message-ID: <7f11413d-659d-cc4e-9af7-bef7b0331d49@apertussolutions.com> Date: Thu, 28 Jul 2022 09:48:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] xen/xsm: dummy.h: Fix MISRA C 2012 Directive 4.10 violation Content-Language: en-US To: Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20220727151953.1125331-1-burzalodowa@gmail.com> From: "Daniel P. Smith" In-Reply-To: <20220727151953.1125331-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMailClient: External On 7/27/22 11:19, Xenia Ragiadakou wrote: > Protect header file from being included more than once by adding ifndef guard. > > Signed-off-by: Xenia Ragiadakou > --- > xen/include/xsm/dummy.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/xen/include/xsm/dummy.h b/xen/include/xsm/dummy.h > index 77f27e7163..8671af1ba4 100644 > --- a/xen/include/xsm/dummy.h > +++ b/xen/include/xsm/dummy.h > @@ -15,6 +15,9 @@ > * value of action. > */ > > +#ifndef __XEN_XSM_DUMMY_H__ > +#define __XEN_XSM_DUMMY_H__ > + > #include > #include > #include > @@ -843,3 +846,5 @@ static XSM_INLINE int cf_check xsm_domain_resource_map( > XSM_ASSERT_ACTION(XSM_DM_PRIV); > return xsm_default_action(action, current->domain, d); > } > + > +#endif /* __XEN_XSM_DUMMY_H__ */ Acked-by: Daniel P. Smith From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:49:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376804.609818 (Exim 4.92) (envelope-from ) id 1oH3te-0004tx-MA; Thu, 28 Jul 2022 13:49:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376804.609818; Thu, 28 Jul 2022 13:49:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3te-0004tq-Hj; Thu, 28 Jul 2022 13:49:50 +0000 Received: by outflank-mailman (input) for mailman id 376804; Thu, 28 Jul 2022 13:49:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH3td-0004d0-2y for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:49:49 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 254e16f5-0e7c-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 15:49:48 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id tk8so3260961ejc.7 for ; Thu, 28 Jul 2022 06:49:48 -0700 (PDT) Received: from uni.router.wind (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.googlemail.com with ESMTPSA id i8-20020aa7dd08000000b0043bea0a48d0sm726038edv.22.2022.07.28.06.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 06:49:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 254e16f5-0e7c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AGvhw52qZ7yhX++JHeFH0Mw9fFAY30IDyCfGWdJWM5A=; b=hfwMuJI0tFFN3Nzwlg4bbRD1MHy8xjGTbR5sIrtGc/6gXXGVAOEJSuzTJf4mRv07IP sh+LX4KM860zdiC9hnGIU5ftYTCXsgrUQIKXgosU5gGs3tAXi4FH69g1SaAPfW2OowwU BK3pgCZc2ZPHa5EW0+PvOs+S/HvC7qfjzL72ndQZubIIy7+Yvm/OMddH2bMo/4l8e3ZB T8U+3M48EIekRS7jJ4fzsIisSG1smO6vivzR/UAKo6piEqgJUNji2Nun1vr1/SAJbHxT nLm9kjMykKqPANw7Qt4+095/DhcMktR1iRebkmkVDUhn/KoBqnUNpE5Haa7BNcTaD1e6 /fQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=AGvhw52qZ7yhX++JHeFH0Mw9fFAY30IDyCfGWdJWM5A=; b=m2ZPNadnF7NX7bP0dQw3RDgxETWiwL4ogh4xb5CuDu8H6SFo7ASr5kFEk16jDJ/WaW JvuLo2SfZ7jzTdFzcg9NJTveXK62EGNwvrJg/FVjAH7qOlx/GPJMdNcUTvjf7J+vwjK2 fPudv7Zg6lfZS9/YZtHdvi+V2SzdTHEHwEZ7cPcCvIQOtIpJEHHseqNYHP2Y0WVx9sAx E1JpdGypjPa/mLJh131r89NV/ZdrpGmB2VgzWGwkI9II+vUGRosD5E3QxuPbC3ouhDkk rwPV9pO/0PIilYuMG2tMwBqwO7vCnEBSAX4gFH005DN/zWnxi6CuZ5mSONqclmEvvSu6 FsiA== X-Gm-Message-State: AJIora8qALJDDebgU3gZJsPRdM7DFyKrmRer9crvF4/Uo8r+cxv1OY2y kFrlvrFvT869duK/t66ajSqKByj/HjI= X-Google-Smtp-Source: AGRyM1u+HXbTeWKD3fQrligIHWFLnCzwsu/mZ++K3zohb3LEU1+xDS930v9zbzeJ+i00/FgeTrL32A== X-Received: by 2002:a17:907:762f:b0:72b:3203:2f52 with SMTP id jy15-20020a170907762f00b0072b32032f52mr21579149ejc.395.1659016187439; Thu, 28 Jul 2022 06:49:47 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Date: Thu, 28 Jul 2022 16:49:43 +0300 Message-Id: <20220728134943.1185621-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou --- xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h index 54670084c3..f5a7269a27 100644 --- a/xen/arch/arm/include/asm/arm64/sysregs.h +++ b/xen/arch/arm/include/asm/arm64/sysregs.h @@ -461,7 +461,7 @@ /* Access to system registers */ #define WRITE_SYSREG64(v, name) do { \ - uint64_t _r = v; \ + uint64_t _r = (v); \ asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \ } while (0) #define READ_SYSREG64(name) ({ \ -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:56:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:56:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376815.609829 (Exim 4.92) (envelope-from ) id 1oH403-0006dj-Ac; Thu, 28 Jul 2022 13:56:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376815.609829; Thu, 28 Jul 2022 13:56:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH403-0006dc-7l; Thu, 28 Jul 2022 13:56:27 +0000 Received: by outflank-mailman (input) for mailman id 376815; Thu, 28 Jul 2022 13:56:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH401-0006dW-3F for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:56:25 +0000 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 10206557-0e7d-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 15:56:23 +0200 (CEST) Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-172-PpOK6jCFMG6uVJEJO-0KTA-1; Thu, 28 Jul 2022 09:56:21 -0400 Received: by mail-ej1-f72.google.com with SMTP id hs16-20020a1709073e9000b0072b73a28465so656537ejc.17 for ; Thu, 28 Jul 2022 06:56:20 -0700 (PDT) Received: from localhost (nat-pool-brq-t.redhat.com. [213.175.37.10]) by smtp.gmail.com with ESMTPSA id g10-20020a1709067c4a00b0072ab06bf296sm452703ejp.23.2022.07.28.06.56.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 06:56:19 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10206557-0e7d-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659016582; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xzeK8l/uhh2RfJXF9pYM//ZAFUY+QQVx2w6hysVQfyA=; b=XqLqCannSyPdVeNLsD3h2kEDaprXBikiKUZh0R1S0JiVOivj8FKsFz7gOL7KXuoQu8lHh6 pg+Aq1r9j4dCpt8rnPnwf1uxt6j6hgzwG1L8q5pRldGpaW1+suCbZj/LnsNVI3FC7Qzw5e hxOa9ZxU6pQ2HLtofLVTqxxsP2rnUFA= X-MC-Unique: PpOK6jCFMG6uVJEJO-0KTA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xzeK8l/uhh2RfJXF9pYM//ZAFUY+QQVx2w6hysVQfyA=; b=guFyZCnQFdY4WGjFpAmZpiFAuh3yEHbCk9VIS0nDN2czTpNPOUxZ/JPk0WVGMV5gaG 35BrvzVrJ7M97ka5MyyL5HHF/3Evs+/nbqvffRwZc22KD24/MM19iIKyvM5GUfZ7NvBR 38ggjLrJ7D6fgGn17HLzsxbhz6Ssn8/kF5ifwc5m+dt03lzFvbyawCcTPTzdRnq9WJuP f3Sn7wNV1nm2er6cj/yA2jVZVe/cXEtWjc0k3WRqbE93ClIF2W5dBKP5knCfppx/ns4r RDJxc/kqTp1LI1rQu2bkLLoloLl+MO0GvNNiFZIalN3Akgewe9tHNVxIEzqtfQ63s+lw WUZA== X-Gm-Message-State: AJIora8dvLkop2Hghs2dNgZ7TKlNf+eKxFPYYpeotPYv97qdgxLtPprf kkihslS9dsIbeZEeri1ops83XZj4oB4jRZNEQt08JXOpTDqINCpPWyu0GibItuGIQG8pq+/WVKy l14LuJq0OifIJU2ki/vLM461rsZU= X-Received: by 2002:a17:907:2cd3:b0:72b:5cc2:bc1f with SMTP id hg19-20020a1709072cd300b0072b5cc2bc1fmr20747962ejc.574.1659016580023; Thu, 28 Jul 2022 06:56:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v/Wp9CFeFCCLrSsPscRefsCFJJMjFEMt0m//2qi2v8fgpX1ZbFUyoGPrJhRbdCCU7dofFG0w== X-Received: by 2002:a17:907:2cd3:b0:72b:5cc2:bc1f with SMTP id hg19-20020a1709072cd300b0072b5cc2bc1fmr20747937ejc.574.1659016579561; Thu, 28 Jul 2022 06:56:19 -0700 (PDT) Date: Thu, 28 Jul 2022 15:56:18 +0200 From: Igor Mammedov To: Huang Rui Cc: "anthony.perard@citrix.com" , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , "Huang, Trigger" , kraxel@redhat.com, mst@redhat.com Subject: Re: Question to mem-path support at QEMU for Xen Message-ID: <20220728155618.2c390be3@redhat.com> In-Reply-To: References: <20220727101930.66ed56e1@redhat.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=imammedo@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 28 Jul 2022 15:17:49 +0800 Huang Rui wrote: > Hi Igor, > > Appreciate you for the reply! > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > On Tue, 26 Jul 2022 15:27:07 +0800 > > Huang Rui wrote: > > > > > Hi Anthony and other Qemu/Xen guys, > > > > > > We are trying to enable venus on Xen virtualization platform. And we would > > > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > > > options on QEMU, however, the QEMU will tell us the "-mem-path" is not > > > supported with Xen. I verified the same function on KVM. > > > > > > qemu-system-i386: -mem-path not supported with Xen > > > > > > So may I know whether Xen has any limitation that support > > > memory-backend-memfd in QEMU or just implementation is not done yet? > > > > Currently Xen doesn't use guest RAM allocation the way the rest of > > accelerators do. (it has hacks in memory_region/ramblock API, > > that divert RAM allocation calls to Xen specific API) > > I am new for Xen and QEMU, we are working on GPU. We would like to have a > piece of backend memroy like video memory for VirtIO GPU to support guest > VM Mesa Vulkan (Venus). Do you mean we can the memory_region/ramblock APIs > to work around it? > > > > > The sane way would extend Xen to accept RAM regions (whatever they are > > ram or fd based) QEMU allocates instead of going its own way. This way > > it could reuse all memory backends that QEMU provides for the rest of > > the non-Xen world. (not to mention that we could drop non trivial > > Xen hacks so that guest RAM handling would be consistent with other > > accelerators) > > > > May I know what do you mean by "going its own way"? This sounds good, could > you please elaborate on how can we implement this? We would like to give a > try to address the problem on Xen. Would you mind to point somewhere that I > can learn and understand the RAM region. Very happy to see your > suggestions! see for example see ram_block_add(), if Xen could be persuaded to use memory allocated by '!xen_enabled()' branch then it's likely file base backends would also become usable. Whether it is possible for Xen or not I don't know, I guess CCed Xen folks will suggest something useful. > Thanks & Best Regards, > Ray > From xen-devel-bounces@lists.xenproject.org Thu Jul 28 13:56:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 13:56:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376819.609839 (Exim 4.92) (envelope-from ) id 1oH40V-0007Hs-LG; Thu, 28 Jul 2022 13:56:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376819.609839; Thu, 28 Jul 2022 13:56:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH40V-0007Hl-IE; Thu, 28 Jul 2022 13:56:55 +0000 Received: by outflank-mailman (input) for mailman id 376819; Thu, 28 Jul 2022 13:56:54 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH40U-0007HX-Fn for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 13:56:54 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH40T-0001m3-AZ; Thu, 28 Jul 2022 13:56:53 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH40T-0006cu-4J; Thu, 28 Jul 2022 13:56:53 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BEJ0o307PAotTTzZF4En/zIAWbhlASmp+bfSYacuPQk=; b=p4K5XJCHFstmzOtTibN7ejYnFU STr5Mp33DUJmATsyMhQG1EkxWxrKUz8EaYIQ0lofhAMaSXEcsvJ1I9F+Aunrp6G1Ri29Urq/d8Ik0 POuUUVE+6wWR7mXbu62lny55AO+BDlRyF00TNAlcD2CTodz9iPyhQYLTRodImSs/TzG0=; Message-ID: <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> Date: Thu, 28 Jul 2022 14:56:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220728134943.1185621-1-burzalodowa@gmail.com> From: Julien Grall In-Reply-To: <20220728134943.1185621-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/07/2022 14:49, Xenia Ragiadakou wrote: > The macro parameter 'v' is used as an expression and needs to be enclosed in > parentheses. > > Signed-off-by: Xenia Ragiadakou > --- > xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h b/xen/arch/arm/include/asm/arm64/sysregs.h > index 54670084c3..f5a7269a27 100644 > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -461,7 +461,7 @@ > /* Access to system registers */ > > #define WRITE_SYSREG64(v, name) do { \ > - uint64_t _r = v; \ > + uint64_t _r = (v); \ I am failing to see why the parentheses are necessary here. Could you give an example where the lack of them would end up to different code? > asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \ > } while (0) > #define READ_SYSREG64(name) ({ \ Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:17:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:17:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376828.609851 (Exim 4.92) (envelope-from ) id 1oH4Jo-0001oh-A4; Thu, 28 Jul 2022 14:16:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376828.609851; Thu, 28 Jul 2022 14:16:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4Jo-0001oa-6z; Thu, 28 Jul 2022 14:16:52 +0000 Received: by outflank-mailman (input) for mailman id 376828; Thu, 28 Jul 2022 14:16:50 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4Jm-0001oU-MY for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:16:50 +0000 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [2a00:1450:4864:20::12d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ea939c6d-0e7f-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 16:16:48 +0200 (CEST) Received: by mail-lf1-x12d.google.com with SMTP id y11so3056240lfs.6 for ; Thu, 28 Jul 2022 07:16:47 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id s20-20020a056512315400b0048905c6103csm223997lfi.9.2022.07.28.07.16.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 07:16:46 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ea939c6d-0e7f-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=uLGV/ivQm/gN1RxftsIYR5A5kG96FtC2aToVdlXspR4=; b=XlM/vPczUoIC6bLr/ZY2UIogJ0oKcJkERvKMaTy2lT+uH4P0oU7fcMM2Dq0/CdKMMT 6K4ApZ/h+6nqEOpwaquZ1k5ymzDmv5beOGvLoeoY1i4gidoTiD07UtlJkxcJBiu9WUaP D4xKBHZNJwlykr4nqCBIUI3e1ZKWdwohu7oG+69KdiX7MIPEWP7Q5p17rLo1bGpQisew cm8dLpVufHnS8SEtDI6PyJzPQhc+75cHMHolFr69W+4W+ZGVFxkjjMo38HRq2AHrzfHB YSfUoQEgs0gttlsWPdwswdPd+jlGPfPSt0eEChKNRX+UxfmoDu4+Swyfsm07fsIoBpT2 jYlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=uLGV/ivQm/gN1RxftsIYR5A5kG96FtC2aToVdlXspR4=; b=0G1qbqa4vSTdNL2MR9thKGA6TzMyaV9V4v/RbRra0UPl6+Hm+5SfbCb7e2kCS4jQM+ 1iKp0BDm89qr9NnWLNr2ztI86xrdwAAdth+DCCUT/ogwlUvdEc4GBJOM/dxGDSs4IrCw FTLDL2GPj1eJQBEBYqj+KcWNeiyFWEfX9VQ4ENQwoKbcixVUD0O6a5fnmmMpJSfFmV01 wgZRuy9lgFsRqalINQz93yDOUXG5VgIBSOWozXaT5wMw91LXKr4z6S9vbCn2A4Jq9JPO HrFXO0t6lJ9hC5AA57a9Mxq4n0C4bb0k5/Emm0rQPxKuwzuQsRRgCDVkHfoT1m8xjwsY RCvA== X-Gm-Message-State: AJIora/Pja4n1Xh0vokBs9PwnBqrbAfXAycA54vAR7tNQfAIOIDxlv+b 4b8ccpUN56dYl810XMFdmCg= X-Google-Smtp-Source: AGRyM1sfrHtR5vRFz4+UY3goMb2y4Ogony8hYZbNN7R8OEgNLqQ/6GpehZKfPYFZCTVawWE43oitHA== X-Received: by 2002:a05:6512:baa:b0:48a:b09e:f299 with SMTP id b42-20020a0565120baa00b0048ab09ef299mr3975621lfv.38.1659017806974; Thu, 28 Jul 2022 07:16:46 -0700 (PDT) Message-ID: <65aad251-2775-45cb-e642-3314f253ace6@gmail.com> Date: Thu, 28 Jul 2022 17:16:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-10-olekstysh@gmail.com> <3b3dd7bf-b528-b7ab-aec9-c912a30d9cd0@suse.com> From: Oleksandr In-Reply-To: <3b3dd7bf-b528-b7ab-aec9-c912a30d9cd0@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 27.07.22 13:32, Jan Beulich wrote: Hello Jan > On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >> From: Oleksandr Andrushchenko >> >> Assign SBDF to the PCI devices being passed through with bus 0. >> The resulting topology is where PCIe devices reside on the bus 0 of the >> root complex itself (embedded endpoints). >> This implementation is limited to 32 devices which are allowed on >> a single PCI bus. >> >> Please note, that at the moment only function 0 of a multifunction >> device can be passed through. > I've not been able to spot where this restriction is being enforced - > can you please point me at the respective code? Nor have I found the respective code. Could you please suggest a place where to put such enforcement (I guess, this should be present in the toolstack)? > >> @@ -99,6 +102,62 @@ int vpci_add_handlers(struct pci_dev *pdev) >> } >> >> #ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT >> +static int add_virtual_device(struct pci_dev *pdev) >> +{ >> + struct domain *d = pdev->domain; >> + pci_sbdf_t sbdf = { 0 }; >> + unsigned long new_dev_number; >> + >> + if ( is_hardware_domain(d) ) >> + return 0; >> + >> + ASSERT(pcidevs_write_locked()); >> + >> + /* >> + * Each PCI bus supports 32 devices/slots at max or up to 256 when >> + * there are multi-function ones which are not yet supported. >> + */ >> + if ( pdev->info.is_extfn ) >> + { >> + gdprintk(XENLOG_ERR, "%pp: only function 0 passthrough supported\n", >> + &pdev->sbdf); >> + return -EOPNOTSUPP; >> + } >> + >> + new_dev_number = find_first_zero_bit(d->vpci_dev_assigned_map, >> + VPCI_MAX_VIRT_DEV); >> + if ( new_dev_number >= VPCI_MAX_VIRT_DEV ) >> + return -ENOSPC; >> + >> + __set_bit(new_dev_number, &d->vpci_dev_assigned_map); >> + >> + /* >> + * Both segment and bus number are 0: >> + * - we emulate a single host bridge for the guest, e.g. segment 0 >> + * - with bus 0 the virtual devices are seen as embedded >> + * endpoints behind the root complex >> + * >> + * TODO: add support for multi-function devices. >> + */ >> + sbdf.devfn = PCI_DEVFN(new_dev_number, 0); >> + pdev->vpci->guest_sbdf = sbdf; >> + >> + return 0; >> + >> +} >> + >> +static void vpci_remove_virtual_device(const struct pci_dev *pdev) >> +{ >> + ASSERT(pcidevs_write_locked()); >> + >> + if ( pdev->vpci ) >> + { >> + __clear_bit(pdev->vpci->guest_sbdf.dev, >> + &pdev->domain->vpci_dev_assigned_map); >> + pdev->vpci->guest_sbdf.sbdf = ~0; >> + } >> +} > Feels like I did comment on this before: When ... > >> @@ -111,8 +170,16 @@ int vpci_assign_device(struct pci_dev *pdev) >> >> rc = vpci_add_handlers(pdev); >> if ( rc ) >> - vpci_deassign_device(pdev); >> + goto fail; > ... this path is taken and hence ... > >> + rc = add_virtual_device(pdev); > ... this is bypassed, ... > >> + if ( rc ) >> + goto fail; >> + >> + return 0; >> >> + fail: >> + vpci_deassign_device(pdev); > ... the function here will see guest_sbdf still as ~0, while pdev->vpci > is non-NULL. Therefore mistakenly bit 31 of vpci_dev_assigned_map will > be cleared. Indeed, good catch, thanks! I assume this can be just fixed by extending a check in vpci_remove_virtual_device(): if ( pdev->vpci && (pdev->vpci->guest_sbdf.sbdf != ~0) ) > >> @@ -124,6 +191,7 @@ void vpci_deassign_device(struct pci_dev *pdev) >> if ( !has_vpci(pdev->domain) ) >> return; >> >> + vpci_remove_virtual_device(pdev); >> vpci_remove_device(pdev); >> } > And other call sites of vpci_remove_device() do not have a need of > cleaning up guest_sbdf / vpci_dev_assigned_map? I am not 100% sure, but it looks like they don't need. On the other hand, even if they don't need that, doing the cleaning won't be an issue at all, there is a check before cleaning (which will be extended as I proposed above), so ... > IOW I wonder if it > wouldn't be better to have vpci_remove_device() do this as well > (retaining - see my comment on the earlier patch) the simple aliasing > of vpci_deassign_device() to vpci_remove_device()).    ... maybe yes. Shall I do that change? > >> --- a/xen/include/xen/sched.h >> +++ b/xen/include/xen/sched.h >> @@ -457,6 +457,14 @@ struct domain >> >> #ifdef CONFIG_HAS_PCI >> struct list_head pdev_list; >> +#ifdef CONFIG_HAS_VPCI_GUEST_SUPPORT >> + /* >> + * The bitmap which shows which device numbers are already used by the >> + * virtual PCI bus topology and is used to assign a unique SBDF to the >> + * next passed through virtual PCI device. >> + */ >> + DECLARE_BITMAP(vpci_dev_assigned_map, VPCI_MAX_VIRT_DEV); >> +#endif >> #endif > Hmm, yet another reason to keep sched.h including vpci.h, which > imo would better be dropped - sched.h already has way too many > dependencies. (Just a remark, not strictly a request to change > anything.) I see. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:17:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:17:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376832.609862 (Exim 4.92) (envelope-from ) id 1oH4KM-0002IJ-IG; Thu, 28 Jul 2022 14:17:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376832.609862; Thu, 28 Jul 2022 14:17:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4KM-0002IC-FZ; Thu, 28 Jul 2022 14:17:26 +0000 Received: by outflank-mailman (input) for mailman id 376832; Thu, 28 Jul 2022 14:17:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4KL-0002Gv-Dh for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:17:25 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2052.outbound.protection.outlook.com [40.107.21.52]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id ffd77ef8-0e7f-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 16:17:23 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB7702.eurprd04.prod.outlook.com (2603:10a6:20b:23f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 14:17:21 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 14:17:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ffd77ef8-0e7f-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ji8V2yJc/ERM5mHrxU0Xwr2ZgPyelgGxVWmyZqW+6QvlkPZmuRA7Tmy0ex7ahz8Gi5UZr6FS9IYhb2CxxOLOjR8LawbUDNqLRbAm4o75Sxs7vMXAT2Ahyg5w4PKyKUjwOQqfdguHBY+9fvEl9ahYuU+AHNJ4LArhgWcv+Rta3rxWNd0pfsmyNt5PAnFiN6c5PEIfOGibq/iiQH6fnDYPXL7gWHagpgXjneCJNizBzRPmrNNsXZIPqyuY1zYJrnodpgnx2iC/vwKeQA1nNhkKKOcAfWEa6L9fphbk8An2s+XS5h6U36g5aOVm0Rol5Z1tl+2XV2dNMTsvCXjB9J+iXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mo7sOtI6KgCguR/fGcGZ2tlVZjkl9xKuor/v6/nyoG8=; b=DYYN7Gwpi4Jq/JoU3kdsImsBtmiMK2pRN0PYKRyjMt4hmghxukeOkOudLRz5KlA2m4pSZKvU5IjPjE2pQb+jhwO+piXCDOCW3Y/FNDa4232dadXkCO14Yl4EssRTyiRfZR2hnVt6G+xf9hGfACbat7dHSOnopvBfCB5H+hM9RuXq5NX0W2tjObVAJDQ5lmtKl6CzpRDFvCLNh7Nq33nXcVyHYyf5hHdH+g+ACetrT+eBPVyUFVv7lYim9cmTu1pGD+7OQEC9kG572q7E0HN3i8LIayZhi88GZMKTDob6F1G6GWL+yj99kPYfXJoivEBz1EbsQ9grv5VGfFg1nzOT2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mo7sOtI6KgCguR/fGcGZ2tlVZjkl9xKuor/v6/nyoG8=; b=U0aZETQa3ZtQUV3NZ+qyv+ToCGutt9Z9dDcmKXjfbXydv9S16GPkJaKZ0GHRGBVJhe89pDmL5b3cSZaGoObSexaTjXVdPMYZlchdge58HIegSB6Hv/YonLMoro4mp+XxQ0WqTMgquxbPxmDaFnBLLA6kGiaXGTqiDw6lxBeIuO0ndPcN3iBYOJdM+Y12tPkn1oUuRoRjyOTWTIZ9qa7PM8WN6gpchdOAfYMR6HJ+2rvjt5144gnnlg+1HvCBXjg4CKW7rGf9PFfbDHxN4q+N6SUb4DhgxeT61/7G0khM0eEVextvFe+pSzMuc4QwbFVmdTQGzaMQXG/w+h60hH4OQQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <818c0331-ae00-d0f6-327f-56606514aaca@suse.com> Date: Thu, 28 Jul 2022 16:17:19 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220728134943.1185621-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0043.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::8) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dc230213-e0d0-4555-2fb1-08da70a3e2da X-MS-TrafficTypeDiagnostic: AS8PR04MB7702:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9P/ErxXYFslS09CwKsyqyEFLo9bkBM7za/jAPmxBlOEWHh4pwITkAVZwl0aRtxrQ+LszlPv7c1qYowwVthbrPrhGvjx5ygBNkyeRHLkDFzcq78uPTU0G6C62eHQD1/71fvHBInzhSCRgDSZSLjmFV3JvpwH1J6cH0Wq7qBVziFx5fJ4tlngdZ/owwOilPrUSo8lHMpL709rYymmvBZPQrqBEHere1pDbuBwHBBLOs2bvPVaelRuWxOlI1qbYRVt9Jxtm5E5xmkaGtxuDFeGNE3cpxYR9HSZwRgK3Nh09NU9n/O/4Mf0HaBw90GRm0nsjMx80s5ngt/c2IWYnfqkQLR4fTXYB7tcfM98GAnCElGaHNLQmkpTUId5a9H/gJUk/4owv9Wuc12PurUQ8xq9Cd9FjJ6uiW8keBfjTC1crHQQiT45dihmFHgSjFvLF5MS5LYw5tYL4Wl5arEe9oqPHMykosOYturrJ/5TqcKV2B9cvqM60ZXs8wBV467cthR9L4KlaynXDZ6q6BeWiexTBwm6NhMMiVRZ1PDhK0FlDdR4YjBhRwW1PuTXqi+87j7j+afHt04oFDSFQXtor8Qagekut4iQQBMhXoJBQRX0Rf+4bTwjj/jaAeY9QDdkcIIUqEBHut93xx7Bf2kehVofrZKro6NkWYMTvGUmaRBuDiGyD0NV4l7DXNBIN4K0FMYFJHMzkk3qhly/m7t9N+IMYNvTkpsApHmsexrEvTye7hsSP44geRRuusaYymiF+aEebSLmKVyWdw/w2ycd5X1bBp7M2NSRKNk91w72tpIw/Gc1sUM8I1zZVp/GqIp/hSVXUghpXtdoY5l1AxGLpCF5Nfw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(366004)(346002)(396003)(136003)(83380400001)(186003)(2616005)(66946007)(38100700002)(4326008)(36756003)(8676002)(316002)(31686004)(54906003)(66556008)(66476007)(26005)(6486002)(6506007)(2906002)(478600001)(6916009)(86362001)(5660300002)(8936002)(53546011)(41300700001)(31696002)(6512007)(4744005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WE5WMG41Zm8wK2lhRTNyNmtiOVdCSjUxSjdxbFRNa0FWTmY4ai9TQUFRYnNh?= =?utf-8?B?RnFFQnA0VWRuQ2pCSkhzcFoxdnFrNVRXbEE3dmJMQitVU1RhRzlvVFdMRzV1?= =?utf-8?B?RXYwcktSck5KalVFUTM5TWZ6b3hQV2xtenJad3ZnQmtWVHlhVHMzOEZqOTIy?= =?utf-8?B?Z084ejRSTFNKKzdlenJPWGtvVFVKaFRFZFVKN2JBZnFQY3EzSHBXRmlsWDVQ?= =?utf-8?B?OFJoT0pDSHU2azBpRUR3UzZzaHRDRjNrczByOFZJVUZ6T0p0c2UyYzgrNFlK?= =?utf-8?B?ZHMxdk5ETmNxWDcxM1IrakEzUGVMeG9YbXVsTHFpZUpQR0lDK29ueTVBbm9L?= =?utf-8?B?ZmlBNlBLYVRRUFdaK2lEV2Z1TTU1b2oxR3F3SkttdjV3emNpa1NIOGhnMy9l?= =?utf-8?B?QUNKcDhZek0waTJSZ01TaFVnWW5WRWxDQUdLR1JKcXNkRVBUdS8rdVA0RmNx?= =?utf-8?B?V1pQKzJQL0VoOWd1NWVOM3JuclB3RmI3OHg3dS90Zm5OOWk5UzJwOFFxNlFz?= =?utf-8?B?TWZrYk93UUZvdERRMTNQRFhBK3FjcGhGQ3FVRFVmWVAzQjVySFJjbWpuVXhG?= =?utf-8?B?ZnBZZjVXZ2grZEVnODQ0SW5kcHRjVGNkQkpGR29qTm82bktVcXAzYmczVUl6?= =?utf-8?B?cSt3M3Y2QS81NDh5OTl5S2w2NjQ5S2ppYm13dmp1WXdBWlN3NG1UZXZuSVNx?= =?utf-8?B?VmN1NXg3SFNXNXVQWHMzL1c5RzQvWHdXMWt5YzdqL29BcXp2Y3VFZmhhZkJv?= =?utf-8?B?UXo4TkpFZlJGZGN1cC9vVVBuZWVnUzJZOWNTUTRIWisycll4SUZhbUFEcFdJ?= =?utf-8?B?RW1iTEdTdllwaGxBblRsNWFMYnJlOFV1QXFFL0dLazd6ai9CSS9wZGJucXRI?= =?utf-8?B?b0ZWenpYR0dUUyt5ZEI1Nk9aek53QUN2TXg3QU10ME03eGNaMkV4ZDFaQ2hh?= =?utf-8?B?WGZMZGxnSU5aMEo0bDJBQ25HdEdNUlFTLzg4ZXJydzd2VkFyTWZKUkFXNlJ2?= =?utf-8?B?ZWdLcGh5VDhBM3lPN2RERVd4QXFQYXo2Q2t0V2RXTmtYUnNyTFg5TTFOeDQ1?= =?utf-8?B?bHRwL0d3cUhRY1A1NXFtT2tlYXhTcWl6SkNIODZseG9VTFZNc2JaTklzUmRi?= =?utf-8?B?MTJmd29iTkh4bWhIdXNqWGJYNTZ3bFRidWRHdnd1RXNsUWF4WHBtSzVmVkZ6?= =?utf-8?B?NWdJSzVKNmtvZXpCVTJFYUJVeVFyYjJHbGNaa21JdjF5ZFJoSTAwZzJyTUtW?= =?utf-8?B?WVptYWRnems0MmdEV2l0NGZOcU8yVzRqUk1qZjNTZnF1UC9zbVpZekVyMWgv?= =?utf-8?B?MmtudHRiLzlRSU9GMWUxZHYzaFR6am94Y011R3VvWHpRK29qOUV6NFN5QjJK?= =?utf-8?B?c25QdWU3K3VZVWFwYlg3RDd6Z3RGM0VEdFljR1VBUUFFa1JLUHR6MWd2L3Q2?= =?utf-8?B?QlNUTjJaTmFtMnRBL1JhcGsyaDlWNytPWXN0Y2xIMFdiZy9jMzA1TEZ3alJL?= =?utf-8?B?NERmd2swckluUms4WG5YZFhOM2hkN01tQWZXRFZRYnd6bWNKL3hmSUdYUDM3?= =?utf-8?B?bmNuQlFKYjR1dTMrU2JEM2pxMW5nWjAybHNKdjlrSktNWTZUY2trMFlhWEIx?= =?utf-8?B?VFFNL3E0SmZhSFBlZjc0ZTUyNFZkWGZ0VnlsOHF3L0h2UVNpeTlyejJTczFa?= =?utf-8?B?Wmc1NU15bmJzcXFoMFFPdURBZkNsVSswOWlmZk5PQ2JWVHFJVG85eTdld1VN?= =?utf-8?B?QTB5M2hhcUdSOVBHbTRHajV1WWhmMjRRMkJMLzJUQlRmbkN5YmlUYm5oUVdv?= =?utf-8?B?UUowSng1bVpZbk5PelNNaEhiM3piY0J2WG1JZ09JbURHbWM1Vm9rV0tOS0xa?= =?utf-8?B?TUFlUzdBWkVndnVDQlRiZVB2Q2I4RVMwdzZBNTNPM05SYjVIYk00MWZXd1Bu?= =?utf-8?B?b1lEN0MwelFvaHVLemxFem9yeE5EeDJXOTZEZHVvbUVqK3A4a0V6cjBDMDhK?= =?utf-8?B?VzBtS3B5NGtEUkF1bldRMzdkUDhrRW5JSXNGTTI5dWVSUVFRVDNsUzV3U1Y1?= =?utf-8?B?K0w4d2UvamZ3cXh6UytOL1hndHR5aStzNVJOZ0I4N0pVRXJkMCtiTndTWU0x?= =?utf-8?Q?j2NrinALfd6lPTFuHirzL/785?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc230213-e0d0-4555-2fb1-08da70a3e2da X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 14:17:21.5838 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gVSr4aXS1PKs7lrUiHuyIOH2HYZNVxGkUy+S5VUJOAqjD7KAIGTV/45lczRKMI2hxI2lixV6iaQIxDgEAN0Hlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7702 On 28.07.2022 15:49, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > @@ -461,7 +461,7 @@ > /* Access to system registers */ > > #define WRITE_SYSREG64(v, name) do { \ > - uint64_t _r = v; \ > + uint64_t _r = (v); \ > asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \ Out of curiosity - why is the intermediate variable necessary? Can't v be used directly in the asm(), possibly with a suitable modifier added to %0 such that it'll always be x (and not w) which is used as the operand to "msr"? Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:20:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:20:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376838.609873 (Exim 4.92) (envelope-from ) id 1oH4Nh-0003rM-4k; Thu, 28 Jul 2022 14:20:53 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376838.609873; Thu, 28 Jul 2022 14:20:53 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4Nh-0003rF-17; Thu, 28 Jul 2022 14:20:53 +0000 Received: by outflank-mailman (input) for mailman id 376838; Thu, 28 Jul 2022 14:20:51 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4Nf-0003r9-60 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:20:51 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2063.outbound.protection.outlook.com [40.107.21.63]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ad305da-0e80-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 16:20:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB9PR04MB8172.eurprd04.prod.outlook.com (2603:10a6:10:249::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 14:20:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 14:20:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ad305da-0e80-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ndCS1omBHznKx88iPoWAUn3BthfzfRtCojrUKTjB/sz6suhq5iGrkBWHKwsw8H1MNgIzpkSYNX5PjguDbbEA1pS0yKvxVT3p1ikzEuOBYyBvS+BPSIimqYsyljUeyDVhwkJHGC87BXkm/n/p7vqE+NyUr8caINAOyGX05Z+K2gjEEUQmmzkPFFbxcbFCGMZRD+lf5pUmz3Ed6Pap+v06kCIYIV9HaDPpl1d2nbS74b/q++wsi/KQkm4jZ4aJEucoNAhpb1B3gsqGzO8LIq1fFDWzhvt20gkfvL3mTBY7bX5KKroFD4MPEWO/pEPmRGeh233WrLDwzgxUQL0NjnxWeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YEEYTecIwfQViuafC873OhjTtNQD5vxg6NG9mUvXe6A=; b=e3bpDxYsZw6m7Zmx/xW2CVv6PE9dQ8WdUZu07/InPvccG0fdUBNPI1Zu09cpJ8LHZtkP7smOcrrK0/1GNYckQfs3t91q1uGX1zCt1fBGLQNeAroxZK9wPmwKWn/bVhMWdhkNXphzYCGHkiaZhdzWogQwR5jVvlC7LFd1w5tbg1aMV0bdfdjc5/UI+iAl+WfBA+Gtu4hMsWaAQIHIIDwc3osEt1sq7iMgyTYs2u/vadhFuhTHSOUtmsXQ9YHKlJFqsDFGSJ1Su8zRh2mV9HYcHVuL42RpUEfC3rUwHr0XE614ukH9V1+K2vYgmmitzrEJhYF+STVMQZA6HXEXpjQEUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YEEYTecIwfQViuafC873OhjTtNQD5vxg6NG9mUvXe6A=; b=TEYJerdGYx46UOc4hi5HS2+EJMbTESDXAPV/LOxdv0UCrku3zj9DzTbyyO0pYymiH0k7j2xMpl3ahM0qCrJJRnVZrDglLBZrEau6heh3FlgK8Zojldr11ybMy/BVLVfPzOj6kp1WrHHU8N7lPYrEBn0sJv3f36wsWHRgAi8qitXgFBAsnPw+OWxHRjDOG29cwB1p4G3OPHBAdIifNaSi5Y9vNYXbQTYaMs3XOdHB11xC/14PhBdvu8r8Jd01l3rGB8tGvEoTbZgZ37RkGtkJKX4WQ0MTb6ULuEbP6jwdfUr7fntlyPzz+i3AcEJBTtCrQzZ7OPY/rAsWEznRsYzvww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> Date: Thu, 28 Jul 2022 16:20:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Julien Grall Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> From: Jan Beulich In-Reply-To: <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0104.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a1::20) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4151b83e-6c7b-4505-a08d-08da70a45d65 X-MS-TrafficTypeDiagnostic: DB9PR04MB8172:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +lDTSLIB2UiCGz72loN9YS2jsNFXkr2zo1m5KYEUbr0SYysZ21LHGAOzDux786yK4TGdwnRoknu3yq3SZz8lCFEkLDxqit6Y/8QBUkpm7wD1X0UCRrkwVhQuhC/Zd9pom6UPnrvKnkGiSjv0LjDjRgekq/Uig4xipRPdEpnQHHIVUlYFPBeTfgrVqK3P/JI/aQhpWh8gkaTmk2SAGAjrzpK/I2lhf2x+TCbSBggpGxVs6ltJD8QYChl+jZls+cz55X0KOyQxznqGlMKzVj4VAdPNZAAXdxue1vd5C4CwG6raz+omS24kkfWBdOKCP8ITU0k9ISD0FpoYV1HSkAg/IGkoZ2h/Qhl72p252Gozjdvp5FhasWsj1lM5ISbLm167PBqWoylmML7ac5PCo1y+VPOXxzIPByrMXUnYKc3vsh6PTxRV2lTcuHKd+jzSV8s7mskcG/A3XxFjvAgGRm+u0Uz7bOjgGjDT9yG4JSHkSX1l6RXaVF/1l9FFOIzlQblAgvwVrGLqVLXchp6zdxn2Ed8rCbrCT61xU7BS5x2+ihm7PBpRLSUr7MaCZrgzMAZgL3q5hFFy7Z9D5pLyvPQ+SMie5lRa9ZBmTRn2L1cpIhc4p2LMjuRs0pohwKJAXKsyD1TULqv8fb+bqt5GASftLGDpPvyB0TTWbXxwQPdv+8SADt//AxQa0hya9AgNSAl4KeJaO9fYg7Ra1z8YnqZ55aDHvaIffLXYi3Z6lcA3IO0xGHqRLn/AXeL/Xdac8gUYhC4+2HEhPSkhoix092GOLIueWzbgo+5k7uRblbbSHNIMUpw+9/162LbNenBv/xysRsFETCGI5uq/oCyMPvh+iQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(396003)(346002)(376002)(366004)(186003)(2616005)(4326008)(66476007)(66946007)(6916009)(8676002)(53546011)(31686004)(41300700001)(2906002)(54906003)(36756003)(6506007)(5660300002)(26005)(66556008)(86362001)(31696002)(83380400001)(38100700002)(316002)(4744005)(478600001)(8936002)(6486002)(6512007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cE9zeTMwdTZZZGptZXhGWC93WXhuODZvd1lCUXRhb0wzYWs5eUpveVA2dXpS?= =?utf-8?B?UVUvVlpyWVFmaHdkQTExRW1aREdLNkZZcWhaN2pTUEpzTDFtM0hldzhKQlV6?= =?utf-8?B?bmRob3RvcG9Dc3RUSE5SKysydmhkVUw3K3hHUlNIaXZGd3JPRmNBQkJBSE5l?= =?utf-8?B?c21BRjRqWjJvRUliL1pXKzF5L0FuTVpqVk9nU0FSRHhsR1FCR2t3dVJTT0VI?= =?utf-8?B?UERiZjNxcDRrSHgvR0tpcE4wcGRlcXF3MGY5MlFuOVdpNEt3Q3Y5STJZM25j?= =?utf-8?B?WlJ2T0l3Rnl0bTQ2SnBXVmQ0Lzl5SENvZ0VCQURMdnFtbHdabVFzY2tJbVNq?= =?utf-8?B?UnAwRm1talFvejBNNGxVV2JiQkNPWDQrQWN6SGRvNENSRWRKM21TYXFkb09u?= =?utf-8?B?MWV4MjJmVEtaWVdyN0hkK2E3RGl5NUFKd2xPcVZnTVNYNFpDc1JTQnpTYUQy?= =?utf-8?B?OHhKa3cwbTI3NHorTk5vcERMelFLTkQzUUQ1bWk0UFJrcGJJcUx5cTdRaW1h?= =?utf-8?B?UVVNcFBEem5CUDZZeFk0endDWGU4Q2FZc052cEhYZWVGVktsZUFvcHN5U2tU?= =?utf-8?B?aE9RU1dkaDEyRld1ZFZ2SDBSM2JzYWhWVWV5OHlGb3BKaTlnYU5sY05CV05l?= =?utf-8?B?c0pDcWhTb0F4R1lTS05sOS9INEFDZGljd2pXN0R1REFaYk00bUJad3VvQkts?= =?utf-8?B?ZERwVUJsYXBaL216UUIrL2dDeVQzamNaQlNIWWtKdWptNjVpdGoxUi9kcjZS?= =?utf-8?B?NWMwU2VmTDA5dVFudTZOaVhxbHM3OUt3UVhyazhvOHF1Z3JDRDdQamlwUDcr?= =?utf-8?B?emZXbnJhck40MVk4czhyOEZoVGpqSjdxWVI5YnFCVUV4aE4rdldHcSt2RWZK?= =?utf-8?B?dTVnUDB1ZlducDEvN2tQSHp5MEt1NHRDNndEUTRKYWVPRE1yb01EZHdUMGpM?= =?utf-8?B?di9GMnZnc3hXZG8xRFQ0bkdzak1lS044SEdzN3NwQ0JXTUl0RmVxYXBHM3pj?= =?utf-8?B?T1lCcTNRb3pkemZydFl5UWhyWnUwbEhNRjFLNFB2YTRuaHVJdk54cVBBWGps?= =?utf-8?B?ZldDZERjUVcyLzdsZGp2eFlkbWcvYzhCVHB5QWYwZUZPeHZsYzlWejdzQ2Vz?= =?utf-8?B?ZXBLOVZwTFlrdTBJVnhERUY5eS9VRXQ3enI1QjFFVmxvbGFQK3ozZXMrTktV?= =?utf-8?B?MzVpL29CeWdTdG9TZmpaRElzTDhaeGxqVCtGWlhMalhmckE0bmtISmZZOU9K?= =?utf-8?B?ZzRrSC9YY1dZWWNNSmZ6T2JqQkpWZkZJMUJMYUltajQzQzVRTGVYaXBySlJu?= =?utf-8?B?RnZoU1F3QWZUbmZHcXE0cEEzWUZxVlR2d3dJQVRvSVA3R1FnOWJ2UU8xWFJR?= =?utf-8?B?MnlZYjJ6NGdVSSsrUnVkT2QybzluaFBXQys4NVN5SFhvRXE2ek9oai9tTndE?= =?utf-8?B?b091YzczMnJxQi8wNXVra24xcUZuem45dVd4eHk5S1haUDNKTm4yVDIvSFV2?= =?utf-8?B?TmUzaWQrZGlDWnZvVUhoNWh6R2QyWjhEZW43S1RxSGlFdW82d1BlT0tGbU9N?= =?utf-8?B?WFQ3WFB3ZFFjS0pNbU82bUJBUER0bG1ia3NhalRScnZqUnN2VThKb0R5dGM5?= =?utf-8?B?Z2ZRaVdoUzNtc3ZOM0Q3Q0JvWkpkN0JtUlJnRzdZTUltU040QW1oVWZaZ3Nl?= =?utf-8?B?czBQNGRJcGdEUEErMVA0UWpuclFic1VwMm1XcFYra3FWOGZKVXZWaFBHWkZx?= =?utf-8?B?S0lYc3d2RnZrdVBtbi9jWFRBUlUzN2FmU0lHbVVvazBHWDRRZkFlQXYvWHE1?= =?utf-8?B?QXhQUytKajZRUzd3SUg0SWVpY3lOZG5DNGJacjcvQUxhbW1tOTYxQkNuWmIz?= =?utf-8?B?MVVtVTR1djhWQ29CN05hN1QxMGs3N3d2anNwQTAyOWpzZHpER3EvNExpWHAy?= =?utf-8?B?UVV4ZUZxUFFVTG5aQjIzemZJelJoZDVBcFBNb0dyLytSNlFYQ3J4b1E0THhK?= =?utf-8?B?Q1VPOTgyOHMzTHhmY01BbkFLanI3NGdMMVg1Qk5KRFhGcWxlWHEwdHJmTTls?= =?utf-8?B?azA3TWxxblUvVTRHOFczMm9UUkhieFhSRFNGbGtHVnZtSVR2QWM5S3ZTRXdZ?= =?utf-8?Q?Az4WGCay8grk2+sLlZSsWJeKI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4151b83e-6c7b-4505-a08d-08da70a45d65 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 14:20:47.1328 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BVjJUUhf4rwDnQQtLPamn54c0i4jCR8engFJnhcbGZQVOuCWamljw2eSe8mxNg7NrbSUvsjQno17pvJuKAw3Bg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8172 On 28.07.2022 15:56, Julien Grall wrote: > On 28/07/2022 14:49, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -461,7 +461,7 @@ >> /* Access to system registers */ >> >> #define WRITE_SYSREG64(v, name) do { \ >> - uint64_t _r = v; \ >> + uint64_t _r = (v); \ > > I am failing to see why the parentheses are necessary here. Could you > give an example where the lack of them would end up to different code? I think it is merely good practice to parenthesize the right sides of =. Indeed with assignment operators having second to lowest precedence, and with comma (the lowest precedence one) requiring parenthesization at the macro invocation site, there should be no real need for parentheses here. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:26:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376843.609884 (Exim 4.92) (envelope-from ) id 1oH4TU-0004gk-OW; Thu, 28 Jul 2022 14:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376843.609884; Thu, 28 Jul 2022 14:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4TU-0004gd-Lo; Thu, 28 Jul 2022 14:26:52 +0000 Received: by outflank-mailman (input) for mailman id 376843; Thu, 28 Jul 2022 14:26:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4TT-0004gX-Q4 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:26:51 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60065.outbound.protection.outlook.com [40.107.6.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 5186d7fb-0e81-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 16:26:50 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2533.eurprd04.prod.outlook.com (2603:10a6:4:37::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Thu, 28 Jul 2022 14:26:47 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 14:26:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5186d7fb-0e81-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B1EWFd9m1gBboBXZBXCOSBh7VlQz6xlhFJJ1avUfrBAtrhfWjSwpoGEG706YhPLwkIKZQSpg6Qrd30PQugWQxSD/nvRDF1bivlH6V9i9aaJ83QHOkBagMsxiRg6jQ2YYZ6rOVhQpYmKqlH/6VkL9+JEv7bW8QD0ZFP+jo3nNOHbNbkQhD00MmthCytDHjSxg4+95Ni3WNrST+jxmtSqBdiyq/vdhJu9ZkuraYVFvljMpkChj0iJtILimGByxkSHt/IPonRXhHVNnDyKoWPqbz1WGTBbslOUGYmDAwdzj4XLVMHrqexfhygjoxa7NeesrS9pCd2xUsu1Bc4pdgEc3zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LfRGgEhkGeIOHRJqxjbjIEei+ZFgwTgGMNrwXM3A7Q0=; b=lMYqO/5P7VPdqv5EdT3T+5GlAQtwHJXxtOhwWpqlWlSJ86k0ZiT+VlCCAUi/rFxDGY5Pg7Yk+F+1e5kvWmb9KQdPOiF8OJT0+Kv65Kjde1qg2s+jHV+hUpEZgqk8Y6ewjOnJXqeF2vlR6GlhP2ozPc0YEisTRlzT69R0fO0MH1aeNBvFN/q90RTsExUTTBDgOq0ob89YvujZGU97hvkX1lZBRd3qhcGo2GEOTqgebqOADQaZRM93ob8vDozYmeiqkgBMGaKqtX/LRLTL/obB75Ff7RxXrpzGKsXaxaKHGtonGziasxa8f54NqyjGA+F5WmhCMMPCsNuKBcOQU9hQ7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LfRGgEhkGeIOHRJqxjbjIEei+ZFgwTgGMNrwXM3A7Q0=; b=bvtdUY3DGYrgE1ssKWrENlkNstO8+u8CFrBjm42LK07s2zf7trLT7TFJNE8HE1lKy6C6kdLsy03AP6N+vp1K9dUZQJE8CDnikFhbtoKBBaLnGAn7pzMILRWG391sl8E4sC4bU/VVZKN8voQfWa/QsFKNNzUz+HsT/BckTI1ko7eWwqXICBWz80fT8I+QtHXNkPBZ2UL0qJ2Xdb6F0J4Lq/VGGU8n4bTFQieFE1vw1RJQL1JMwNw7BRg6ky8GGuEOLxWqtaCuPV+88/AcrWvINVGaW/tiAVNnXqMgj7ZJfqwYOMnTPHwL7e28+cgnlVD6lrHi3jQp1VSRlZtFBm9d2g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Thu, 28 Jul 2022 16:26:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-10-olekstysh@gmail.com> <3b3dd7bf-b528-b7ab-aec9-c912a30d9cd0@suse.com> <65aad251-2775-45cb-e642-3314f253ace6@gmail.com> From: Jan Beulich In-Reply-To: <65aad251-2775-45cb-e642-3314f253ace6@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: AM5PR0601CA0043.eurprd06.prod.outlook.com (2603:10a6:203:68::29) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d9662c18-0fad-46da-c8ef-08da70a5342e X-MS-TrafficTypeDiagnostic: DB6PR0401MB2533:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H60qMWWXEDzCSNdVpqqan5lqH/wnGQG6Hc4nD1dx398Fi8g1cALmfjd+9XjkhX5L8aswbinWII7Rm9c6glmD3a/gXDkHetk053Pq7suzVAW4IkPbU8wRsQLloRi8IINfcMFfQ4qJLGliHeeIXy/0zkgWv6CxEhm0JEr4wJwQ166CkeeMczFDdSo/c/MI5TKgmq/cfO1RxwzkVIxxLle4ZEUVp454CLA8K41iyayplcF52e2GjAF6LGk7lZbtMgRvhQueZqlMAA/luPY7dExAO9w3OIDpe3OsB7XE3BIJwPYb4E4uqrWIMi4SUadwsaQPGadFd/DbvtwU480c6gY1BseV1tqYxhFPrgerM6WLPoKlgsPH3uh+iftk7mRZI/FRrA0JwmHWAx0Qu3MXpc/6huKMXU+8v/0qIY0s2NfZ7S1xUJwr7X3PMhYesAUBTjxrUynYUSTHvJwMflcgpJhGJqYW2JWoQcBf1xBZDeSrz8KPXeYudD7aWoOAtftTWoaw0U5V8qUqda8oLJjmNJMcJVVLKq3y+IGVrONYOCs9kPeh0q+F18KGMPv5m6y54Qu+oL+FxIdHY+VRHPf/SyZPK/SAV2xxWEZc420pUqjdmP7VewLPHLx029rlefR3qu67X1REpYh5Lvi3RcaltINJFaZXyfWI4XQHaOR9miA0UJrMjmL7wRf7YuwbQfi6rPLZwf/G9yJl9YPpXrKMjqWTFbTDpvl1hCxcmWfe1wN1qd8W4uDTwM9Unq06LhDng7lwtZwgk+WUqTRcsQiLoBVE51TV07jH7ox4a4qAZZQhMrp9IR0BEDXrn6nYbJff8k/iVfZ34SHgrJ5Qar0i0CWXFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(376002)(366004)(136003)(346002)(39860400002)(186003)(2616005)(41300700001)(6512007)(6506007)(54906003)(53546011)(26005)(36756003)(8936002)(5660300002)(31696002)(6916009)(31686004)(478600001)(316002)(86362001)(6486002)(38100700002)(83380400001)(2906002)(66476007)(66946007)(66556008)(4326008)(8676002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3BqSU45Q0tXMk9hWjEyQTdnL1pGVGVNUG5ZejdWZ2o4MzB1VEh4MkkvVjlu?= =?utf-8?B?L2Jzb21sOForMG84VmcvbXFDUFFWaDBxTHVVblBkVVljZDZJaWRxU1I0MEVQ?= =?utf-8?B?Y0hoUDNuemVBWGdPa0EvSFVyNWg0b3NLTGRlR1hIWUt1T1J2MlJXTzd0L1V2?= =?utf-8?B?eGg1S1VndXd3dURFTmlibVZTU1puc28wcnd0ZElWVW4rbUxXZVIxRUZiNEJZ?= =?utf-8?B?WTJGc3AxKzZQcjFYYjVTS01kZjBDTU0rQ1RJS0xIMVlrRFFFdys4MjFBTW9r?= =?utf-8?B?ajBXMUx4TFM3cXplQjFvTWE3blpxdzUycWNyUkNGcSt1SjU0SUNXNXczUjhS?= =?utf-8?B?YVE5SlRWWHNKdTZqYmJxb0FVK0RwMVFkbElUSENZY3FzT1hISnQrcVo4VjVQ?= =?utf-8?B?clo3N005MHhzVTc0V0RGK3lnRU91eUYrQy9tWkJHNkgwRU0xelpYWmdyRlBF?= =?utf-8?B?MWZnc1NTQ0N2aW00TU1xUEtZQ0VUMUIyRFdWU3dQalVrVmZwREs4ZnBNZjBx?= =?utf-8?B?bGU2bXNMakpxQTNuWFBzQXZDeWFLSVRNdzJEV0dIQVBQUnI1dnBoTlRIYkhi?= =?utf-8?B?a2dDc2xiR0o3ZUs2T2FMbXhRdjE5RjJZVGZ5VmNqME10akZqVTV5bEdHbXNm?= =?utf-8?B?azI0R3JxeDk1QzhXK25IRFNWWGI5Y0pueDVYNVAvQkl5QXZTTzZGN1VkTm51?= =?utf-8?B?STQwUkNVSUtYZmYvRU1kdFlIUGlvREF2Zy9USjJPTUNaM1gwK1VlZUNtV2F4?= =?utf-8?B?MDB0ZXM4NmJPTTZwcitzUWFWNTBIdi9acThxWExJNHpOSkV5MGdxQllxMUxX?= =?utf-8?B?TXZSTjJvOU1Ma0wxS1gvV01hSnpadkFQdnZZV2xka1A1UGhqY0ZTYWQ4OEtD?= =?utf-8?B?aHpyN1NWamh0K3ZoU0RzUUxxazNiS2dxSk1KNUN6S09UMWRHZEFPUnZYRHpm?= =?utf-8?B?bXdxVVBlVEdCaDBZb0VmR29PKzNBVUp2dUJDVUNvRUwwL1VJYTFHeERjbW9t?= =?utf-8?B?UWcxNStTMXBrYkJhWHVkUzZEV0FkeFlicEpwNnpiMUMrOHZxa3hOendBbEg4?= =?utf-8?B?eS9TSHR3UzlaMGd5R212emZKZXlJMzZ2b1FsbjczR0tINEwrSmh3enNoeXEw?= =?utf-8?B?NjNrUHc3ak5nSTdHMFdzbkoyZEVucUxndGJJVERKUVF3eU1ud2duYWx6NDcx?= =?utf-8?B?MVJuWmNIRUJpK1hBSWsvdllLRW8yS2EwU05RMVZhdzBqcjJaU1VVWHY2cUI3?= =?utf-8?B?QzJtdkN2Q0x3TXVSUnYzdzNHamwyKzlEdEloZTBrTFJ1WXBDQU94UlFZRzVJ?= =?utf-8?B?eUdUN2FyejNTQlE1WGdwZjI5UHR6K0w4b2hVNklaUXQxbUlqU1d0M1Y2Ukpp?= =?utf-8?B?bEE3djhlamJpQmphbm1tVU92YS9Ya1p6MEVueHEwczg4bkMxNnFDK3JZYjk2?= =?utf-8?B?NVV6OEZhZGlIQnNOaExpb0wrcDVaSUVTcG9sSWZOdkFLNzVPWnl5SVJ4djBO?= =?utf-8?B?WnhvNnA4UmRIMEpESklzRmZGRFlaUXBDZ2k2blB0S3VEcGt3OFRNemFNV2NU?= =?utf-8?B?ejBlNTRIcWd1SnZoWGRZWkJWaEFzZFpWZkNHT2hvTW5pOU1XOGdPVnNRUmRT?= =?utf-8?B?REZ6ZkwybXoyT25USVdjejZJSlBtbzU0WDJxNFphRC9lMDB5VWdaZ1BxazNR?= =?utf-8?B?N0I5c3E1ODZaeGNZcUp0UDdNMkJKYXYvTmh6cVVzakRxeVlQdTlPV2lUZWxh?= =?utf-8?B?YnB5T2MwWEo4UW80alNFTlhuZk1pT3RiK0dqNlgrd3FEa09qVG9wMzZxRXR6?= =?utf-8?B?Uy9FR3pDcmNBZUswZHdtQkU4eUNWVW5NSUFlUFRCV3RHR3ZyQTFYbXYvdXZK?= =?utf-8?B?OFg1aXdIZ0FBd3c1cUNKM0srNjh0SDFZaVV2a3RoNzR1YVZlQ0RTZUpmZUVV?= =?utf-8?B?TEY5QlQxS3lhOFpFTThiQkdrVkJnUzdQS2ZxUit5T2NJbFlWK3AvWGR4WUFm?= =?utf-8?B?eXhPcTQrNkpNWHpaTlBOOW5GdGhuMmdVT0pyT2x6QnVnSUNCSExUOHZPRkly?= =?utf-8?B?T0hYcG8zNHFjL2hvWVhwTXVaSFg4SDlpZjZyaUluSWpEeXlpN3htOWZXc0RL?= =?utf-8?Q?TuMo8ymptHX8ObEax35NDGSNN?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9662c18-0fad-46da-c8ef-08da70a5342e X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 14:26:47.5148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: azRfAbLaTH8+/pFZaBtrL3xUWGj1h7d0TAa7vuLLrJmUzC1ofinHWg3Ww/kVm+vXZ5X3h4ITaY37bOD7oE36rQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2533 On 28.07.2022 16:16, Oleksandr wrote: > On 27.07.22 13:32, Jan Beulich wrote: >> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>> From: Oleksandr Andrushchenko >>> >>> Assign SBDF to the PCI devices being passed through with bus 0. >>> The resulting topology is where PCIe devices reside on the bus 0 of the >>> root complex itself (embedded endpoints). >>> This implementation is limited to 32 devices which are allowed on >>> a single PCI bus. >>> >>> Please note, that at the moment only function 0 of a multifunction >>> device can be passed through. >> I've not been able to spot where this restriction is being enforced - >> can you please point me at the respective code? > > Nor have I found the respective code. > > Could you please suggest a place where to put such enforcement (I guess, > this should be present in the toolstack)? Such check should be in the tool stack primarily to give a sensible error message to the user. Yet the hypervisor needs to check itself nevertheless. You know the code you're adding much better than I do, so I guess I'm a little puzzled by you asking me to suggest a place. (And for the tool stack I guess asking tool stack folks would get you better mileage.) >>> @@ -124,6 +191,7 @@ void vpci_deassign_device(struct pci_dev *pdev) >>> if ( !has_vpci(pdev->domain) ) >>> return; >>> >>> + vpci_remove_virtual_device(pdev); >>> vpci_remove_device(pdev); >>> } >> And other call sites of vpci_remove_device() do not have a need of >> cleaning up guest_sbdf / vpci_dev_assigned_map? > > I am not 100% sure, but it looks like they don't need. On the other > hand, even if they don't need that, doing the cleaning won't be an issue > at all, > > there is a check before cleaning (which will be extended as I proposed > above), so ... > > >> IOW I wonder if it >> wouldn't be better to have vpci_remove_device() do this as well >> (retaining - see my comment on the earlier patch) the simple aliasing >> of vpci_deassign_device() to vpci_remove_device()). > > >    ... maybe yes. Shall I do that change? Well - yes please, afaic. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:34:37 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:34:37 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376853.609894 (Exim 4.92) (envelope-from ) id 1oH4au-00067W-HW; Thu, 28 Jul 2022 14:34:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376853.609894; Thu, 28 Jul 2022 14:34:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4au-00067P-Ex; Thu, 28 Jul 2022 14:34:32 +0000 Received: by outflank-mailman (input) for mailman id 376853; Thu, 28 Jul 2022 14:34:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4as-00067J-Ty for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:34:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4ak-0002Wp-Mj; Thu, 28 Jul 2022 14:34:22 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH4ak-0008Up-F1; Thu, 28 Jul 2022 14:34:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=IN111wzHiPhKwSsDm1uKbjSprr5/4s/E0rreu7qtzd8=; b=ZQ9hBlX4UjHfjU3QYluyvx9SvN y6wDNfdnpOGQUUNarJIlIYJRy0doSlQRGd6YGbwOwH2GaHbc5MdABt98jJzwD6CbH+miZarDDZERP lSjxMybE6yUAlDv3i9B7dwnFca4xQ6Ggk4ruXcdiIsi7hGGrehtDpSNBqLnHLngGwovM=; Message-ID: Date: Thu, 28 Jul 2022 15:34:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Xenia Ragiadakou , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> From: Julien Grall In-Reply-To: <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 28/07/2022 15:20, Jan Beulich wrote: > On 28.07.2022 15:56, Julien Grall wrote: >> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>> @@ -461,7 +461,7 @@ >>> /* Access to system registers */ >>> >>> #define WRITE_SYSREG64(v, name) do { \ >>> - uint64_t _r = v; \ >>> + uint64_t _r = (v); \ >> >> I am failing to see why the parentheses are necessary here. Could you >> give an example where the lack of them would end up to different code? > > I think it is merely good practice to parenthesize the right sides of =. > Indeed with assignment operators having second to lowest precedence, and > with comma (the lowest precedence one) requiring parenthesization at the > macro invocation site, there should be no real need for parentheses here. I am not really happy with adding those parentheses because they are pointless. But if there are a consensus to use it, then the commit message should be updated to clarify this is just here to please MISRA (to me "need" implies it would be bug). Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:41:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:41:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376859.609906 (Exim 4.92) (envelope-from ) id 1oH4hI-0007kV-9I; Thu, 28 Jul 2022 14:41:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376859.609906; Thu, 28 Jul 2022 14:41:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4hI-0007kO-4y; Thu, 28 Jul 2022 14:41:08 +0000 Received: by outflank-mailman (input) for mailman id 376859; Thu, 28 Jul 2022 14:41:06 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4hG-0007kI-El for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:41:06 +0000 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [2a00:1450:4864:20::132]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4f5cf38b-0e83-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 16:41:05 +0200 (CEST) Received: by mail-lf1-x132.google.com with SMTP id t17so3229856lfk.0 for ; Thu, 28 Jul 2022 07:41:05 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g12-20020a2e9ccc000000b0025e243c8654sm173103ljj.60.2022.07.28.07.41.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 07:41:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4f5cf38b-0e83-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=SLyT3nCKq2Stsbqr+fV+9OLgxreVfVbSCR7cGYGGAEk=; b=ffwhAWX/8z1rXoY2HnweCXvNUYa2gXSnu1u+8CbF3kc/W7m7KPD4n8znVNyfSb4/Tu /9ARq5ifVjl1GWdN9b4LzP1flyszrqjmseafi2nvUVD7MoJtd8HPsCLDK1+69FhQVj7B OsrosMevLun9fr/SvSQQQqBbvNgJkCea73qvFDuNoStuNiJMcKRrJACxylH8lke747GU nLJ1bEQxFFP0Tg1DizXhG5TryvhfhqHYPjyH4JRpJa/iTYtXpdY9gkai113z9VEs6KvD 1CMLwEAiTeEv8jNzst30byVvtEEscSz3AyExfVk9DJwEip05KgS3j3+wgo+h+JJrDc6r szGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=SLyT3nCKq2Stsbqr+fV+9OLgxreVfVbSCR7cGYGGAEk=; b=SsooAizbAJ4qWKLOUB36CwLjEzq/Lsrmvxo9xBhFQgClwaZTen2fglWJwonPyquKbd U76oqsIgJzg93lJtjMC2/N8w9d5ZDzvQSBH37iNjX5VBIExywewg62JMdo4PKAl3cRfu dHi+5m5p72YlD11GrZiCQ0gHfwry5ZuqP/BoIoD5eR8K0iSVuHRLNy4JHjd2kNXndD2/ F1xnbSqn28v5ZlUe6VZ2AOGESzNd0awX724mrhPQmE2UXRj7LNcsV2rm/ea3/PIeV6AL WFmFsj47KOFzogm+O415r/2YMC8zgs8lLPIreETFt20xy+Oh4xg3eM50Y8zMQWdjtOW7 MZdw== X-Gm-Message-State: AJIora9SzfSYu1tJ6feZ8PqalfR6wKd2nVfxSwK22QIQJVW8Oyqe7PAM DO5QsRtqs2HUHCLxhza6xIg= X-Google-Smtp-Source: AGRyM1u62CZx3nKdHmddnXKFqeWhocFMrePac8ZyHic1zo+u/joLSO0zHRMew6AqybLIpKOlrRJjrQ== X-Received: by 2002:a05:6512:3d2a:b0:48a:c013:b43b with SMTP id d42-20020a0565123d2a00b0048ac013b43bmr2269370lfv.533.1659019264850; Thu, 28 Jul 2022 07:41:04 -0700 (PDT) Message-ID: Date: Thu, 28 Jul 2022 17:41:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 09/11] vpci: add initial support for virtual PCI bus topology Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Andrew Cooper , George Dunlap , Julien Grall , Stefano Stabellini , Wei Liu , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-10-olekstysh@gmail.com> <3b3dd7bf-b528-b7ab-aec9-c912a30d9cd0@suse.com> <65aad251-2775-45cb-e642-3314f253ace6@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28.07.22 17:26, Jan Beulich wrote: Hello Jan > On 28.07.2022 16:16, Oleksandr wrote: >> On 27.07.22 13:32, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>> From: Oleksandr Andrushchenko >>>> >>>> Assign SBDF to the PCI devices being passed through with bus 0. >>>> The resulting topology is where PCIe devices reside on the bus 0 of the >>>> root complex itself (embedded endpoints). >>>> This implementation is limited to 32 devices which are allowed on >>>> a single PCI bus. >>>> >>>> Please note, that at the moment only function 0 of a multifunction >>>> device can be passed through. >>> I've not been able to spot where this restriction is being enforced - >>> can you please point me at the respective code? >> Nor have I found the respective code. >> >> Could you please suggest a place where to put such enforcement (I guess, >> this should be present in the toolstack)? > Such check should be in the tool stack primarily to give a sensible > error message to the user. Yet the hypervisor needs to check itself > nevertheless. You know the code you're adding much better than I do, > so I guess I'm a little puzzled by you asking me to suggest a place. > (And for the tool stack I guess asking tool stack folks would get > you better mileage.) Thanks for the clarification. I am still getting used to the changes which that patch series makes (I didn't write that code). Asking for suggestion I didn't mean to point an exact place in the code, but rather a subsystem/software layer, sorry if I was unclear. > >>>> @@ -124,6 +191,7 @@ void vpci_deassign_device(struct pci_dev *pdev) >>>> if ( !has_vpci(pdev->domain) ) >>>> return; >>>> >>>> + vpci_remove_virtual_device(pdev); >>>> vpci_remove_device(pdev); >>>> } >>> And other call sites of vpci_remove_device() do not have a need of >>> cleaning up guest_sbdf / vpci_dev_assigned_map? >> I am not 100% sure, but it looks like they don't need. On the other >> hand, even if they don't need that, doing the cleaning won't be an issue >> at all, >> >> there is a check before cleaning (which will be extended as I proposed >> above), so ... >> >> >>> IOW I wonder if it >>> wouldn't be better to have vpci_remove_device() do this as well >>> (retaining - see my comment on the earlier patch) the simple aliasing >>> of vpci_deassign_device() to vpci_remove_device()). >> >>    ... maybe yes. Shall I do that change? > Well - yes please, afaic. ok, will do > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:45:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:45:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376866.609917 (Exim 4.92) (envelope-from ) id 1oH4lk-0008RW-Sp; Thu, 28 Jul 2022 14:45:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376866.609917; Thu, 28 Jul 2022 14:45:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4lk-0008RP-Q0; Thu, 28 Jul 2022 14:45:44 +0000 Received: by outflank-mailman (input) for mailman id 376866; Thu, 28 Jul 2022 14:45:42 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4li-0008Pm-Q7 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:45:42 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4lf-0002lo-Jk; Thu, 28 Jul 2022 14:45:39 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH4lf-0000fy-BQ; Thu, 28 Jul 2022 14:45:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=F4RkZYsg5KEbgHRUPq0SUii4Djdzt7wqKp/WoaBC7ec=; b=5Q/ea2QOl3phIcSnxkDxRL024O MnKR/1TE7sLWKHhcjrZxZBTw15iwkIsSRefgyeDqRkrvWDtNGh3o1WCLF88byltJt20AC7M8c5LQM 0xwyL5Ku9Pui+3KpVPP7l9RVtyYVNmZ7TLrupLGh291L70CGROCetzm4BIJmyi/UC508=; Message-ID: <893c3cb3-7366-d161-b2a0-9cf88765002d@xen.org> Date: Thu, 28 Jul 2022 15:45:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich , Xenia Ragiadakou Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> <818c0331-ae00-d0f6-327f-56606514aaca@suse.com> From: Julien Grall In-Reply-To: <818c0331-ae00-d0f6-327f-56606514aaca@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 28/07/2022 15:17, Jan Beulich wrote: > On 28.07.2022 15:49, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -461,7 +461,7 @@ >> /* Access to system registers */ >> >> #define WRITE_SYSREG64(v, name) do { \ >> - uint64_t _r = v; \ >> + uint64_t _r = (v); \ >> asm volatile("msr "__stringify(name)", %0" : : "r" (_r)); \ > > Out of curiosity - why is the intermediate variable necessary? > Can't v be used directly in the asm(), possibly with a suitable > modifier added to %0 such that it'll always be x (and not > w) which is used as the operand to "msr"? It should be possible to use %x0. However, We may need to use (uint64_t)(v). Linux seems to be use it, but IIRC they are not supported GCC versions as old as ours. So we would want to check when %x0 was introduced. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 14:57:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 14:57:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376891.609936 (Exim 4.92) (envelope-from ) id 1oH4wS-00021m-Vh; Thu, 28 Jul 2022 14:56:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376891.609936; Thu, 28 Jul 2022 14:56:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4wS-00021f-SD; Thu, 28 Jul 2022 14:56:48 +0000 Received: by outflank-mailman (input) for mailman id 376891; Thu, 28 Jul 2022 14:56:47 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH4wR-00021Z-L3 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 14:56:47 +0000 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [2a00:1450:4864:20::135]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 805e992b-0e85-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 16:56:46 +0200 (CEST) Received: by mail-lf1-x135.google.com with SMTP id t1so3211478lft.8 for ; Thu, 28 Jul 2022 07:56:46 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id u13-20020ac258cd000000b00489f0c8bddesm231487lfo.207.2022.07.28.07.56.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 07:56:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 805e992b-0e85-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=aukZP7fIYEgRcNgQauT0c9Fws8Q4PpqsdZsgdLKxqdI=; b=p0dpGsyJfHJgJQcWgPZ4/jOCo/m9pB2Qa7AhY2yTiZ6eeAyVczlLL96AL1+lgOTG5o vbIo1mtG9erExx5xTrC25nEy7doWOnH7b7SQ0a5JqIZrYUQYpwL/C7T87hpW+0aGGkD2 VG5OzaACprRjtKdSpgzXMbxQLzA1IRoryPRXXMdUB/kVqqgmLaojTV4MqoCc1dPtHGFF fX1aPrrrZ3V4SZqFX1i+mvJ2wqtq5YIkElUDri8YIXeHulUnxEz0yMnxOH3SoLBw+p+x cUzC6y6cQ3KQU+phGXGS8oR+h9HHSkghRWSkewVujg/++RzpcWDzlbZXDsvE6ZWLX/W8 UMNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=aukZP7fIYEgRcNgQauT0c9Fws8Q4PpqsdZsgdLKxqdI=; b=a1x9yGjCzJdzACJtw1wMZ/GfjxMymk3jbXue4qaNTv5Aefx/R2HVoVz862mFLPcxHv OrYRmL9nidY0nGJjhyqRw7vbckdvqz8Q51IYTSCt3OegX6tymoq6Qw5VI+cSc1MSzVhn /qNS/ll3e0vE3YcjrMyeCkJ8GLGGU++y8qEUbGeLDLCWpnZAUOIDKfOmmlaf/S62N8yy /r+WIFp4MJmTzfTybqohvbuNSFx4n1NmnBAwifpYhppW2knL9Zl9hYai2NxHFNmucTta 1chj8y/Rmh2TrLJzkkb7ewFRa68GQqIxfizkHr5OYwvJcfcqdTqG//rgM7jNZJtlA7nB pKQQ== X-Gm-Message-State: AJIora+pT4YqqhFm1/S0w4R3TE9uPsvjPu+J201seZUePrR2xySBWPYN dRBV1ENicBNfQLV71Jt0gqU= X-Google-Smtp-Source: AGRyM1tq1Iizw2ysuZFEUUnG4A26/4b5TR/GA5uOcfZsK6KObj3Qu8/0N2JnaRC/hPz0qmjiMu31DA== X-Received: by 2002:a05:6512:2141:b0:48a:772b:bf86 with SMTP id s1-20020a056512214100b0048a772bbf86mr9954494lfr.178.1659020206115; Thu, 28 Jul 2022 07:56:46 -0700 (PDT) Message-ID: <00968e58-8e52-dc5f-f5fc-09274d8f4ec3@gmail.com> Date: Thu, 28 Jul 2022 17:56:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 03/11] vpci/header: implement guest BAR register handlers Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-4-olekstysh@gmail.com> <25d96933-5582-ff1e-f685-d48b5380d531@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 28.07.22 10:01, Jan Beulich wrote: Hello Jan > On 27.07.2022 18:17, Oleksandr wrote: >> On 27.07.22 13:15, Jan Beulich wrote: >>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>> @@ -527,6 +592,17 @@ static int cf_check init_bars(struct pci_dev *pdev) >>>> if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO ) >>>> { >>>> bars[i].type = VPCI_BAR_IO; >>>> + >>>> +#ifndef CONFIG_X86 >>>> + if ( !is_hwdom ) >>>> + { >>>> + rc = vpci_add_register(pdev->vpci, empty_bar_read, NULL, >>>> + reg, 4, &bars[i]); >>>> + if ( rc ) >>>> + goto fail; >>>> + } >>>> +#endif >>> Since long term this can't be correct, it wants a TODO comment put next >>> to it. >> >> Looking into the previous versions of this patch (up to V3) I failed to >> find any changes in current version which hadn't been discussed (and >> agreed in some form). >> >> Could you please clarify what exactly can't be correct the long term, >> for me to put the proper TODO here. Do you perhaps mean that TODO needs >> to explain why we have to diverge? > If a device has I/O port ranges, then that's typically for a reason. > Drivers (in the guest) may therefore want to use those ranges to > communicate with the device. Imagine in particular a device without > any MMIO BARs, and with only I/O port one(s). > >>>> @@ -553,34 +635,47 @@ static int cf_check init_bars(struct pci_dev *pdev) >>>> bars[i].size = size; >>>> bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH; >>>> >>>> - rc = vpci_add_register(pdev->vpci, vpci_hw_read32, bar_write, reg, 4, >>>> - &bars[i]); >>>> + rc = vpci_add_register(pdev->vpci, >>>> + is_hwdom ? vpci_hw_read32 : guest_bar_read, >>>> + is_hwdom ? bar_write : guest_bar_write, >>>> + reg, 4, &bars[i]); >>>> if ( rc ) >>>> - { >>>> - pci_conf_write16(pdev->sbdf, PCI_COMMAND, cmd); >>>> - return rc; >>>> - } >>>> + goto fail; >>>> } >>>> >>>> - /* Check expansion ROM. */ >>>> - rc = pci_size_mem_bar(pdev->sbdf, rom_reg, &addr, &size, PCI_BAR_ROM); >>>> - if ( rc > 0 && size ) >>>> + /* Check expansion ROM: we do not handle ROM for guests. */ >>>> + if ( is_hwdom ) >>> This again can't be right long-term. Personally I'd prefer if the code >>> was (largely) left as is, with adjustments (with suitable TODO comments) >>> made on a much smaller scope only. >> >> I can revive a comment that Oleksandr Andrushchenko provided for earlier >> version by transforming into TODO: >> >> >> ROM BAR is only handled for the hardware domain and for guest domains >> there is a stub: at the moment PCI expansion ROM handling is supported >> for x86 only and it might not be used by other architectures without >> emulating x86. Other use-cases may include using that expansion ROM before >> Xen boots, hence no emulation is needed in Xen itself. Or when a guest >> wants to use the ROM code which seems to be rare. > ROMs can contain other than x86 code. While reportedly mostly dead, EFI > bytecode was an example of an abstraction layer supporting arbitrary > architectures. Therefore a comment along these lines would be okay, but > personally I'd prefer it to be less verbose - along the lines of the > one to be supplied for the I/O port restriction. Thanks for the clarification. I will add two TODOs. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:15:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:15:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376910.609947 (Exim 4.92) (envelope-from ) id 1oH5EC-0004gQ-Go; Thu, 28 Jul 2022 15:15:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376910.609947; Thu, 28 Jul 2022 15:15:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5EC-0004gJ-CV; Thu, 28 Jul 2022 15:15:08 +0000 Received: by outflank-mailman (input) for mailman id 376910; Thu, 28 Jul 2022 15:15:07 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5EB-0004gD-JU for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 15:15:07 +0000 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [2a00:1450:4864:20::630]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 0fc597a5-0e88-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 17:15:06 +0200 (CEST) Received: by mail-ej1-x630.google.com with SMTP id j22so3724693ejs.2 for ; Thu, 28 Jul 2022 08:15:06 -0700 (PDT) Received: from [192.168.1.93] (adsl-237.176.58.138.tellas.gr. [176.58.138.237]) by smtp.gmail.com with ESMTPSA id z19-20020a170906075300b0071c6dc728b2sm510541ejb.86.2022.07.28.08.15.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 08:15:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0fc597a5-0e88-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=+bDXLM/gyGC9wqVQYDzf3ehUIgXmb8Ntv7fGLNNxN74=; b=puKhKrFVrFDCJFQfXNm/H9+TBioKRmycKN0KxyzKSuT2KM91MBdC5CBIg7tDtKCfSM EIZ7DxnIklLuKPkfTb1DMFZaSDM3TmGuftGb522IaRYaHtZ+MKjrgkRH2Ahlx518egjC OoulS8sp/IM9ix9Jiwzn1ZzajVyWJmpa/gm7nofEGMDW69FQrrHE872T+MB2G+JoF4GX TJNeJNnHEYWXh7S8cXE5iLDzO+rCij8xnQF4IXllpvlVu5/hi8nzq0YqfeUlZyPdd0eo +WfY7g6R0L2oXrLoihtDMthSkau1yihxe3Of/k+S5gyzT7JZiocDPvp4Foedg2YeW7A0 MUHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=+bDXLM/gyGC9wqVQYDzf3ehUIgXmb8Ntv7fGLNNxN74=; b=6QIrOzyGll4GEFWS//7QvIJ2igzy2IxDQOL77EDm/KNxkwOm8REWR0sQ+LJtx74idD Q72BYPVwJSWFML754wzVAW8QId/D6Dzjbn+TT2+JNrSW22Vy6LZZI9A5yynpxf/DXlPo Zf2xbZlCut5ofrY0QdT8K6YK14YTJnGhcO+gzhbqoUoOwyO2hUVRcwVCMTpagt4if8lO 32QiJLD1Ux3eanKDvhZldzGaEzGxG+nGrLPWoCMu0s1uZJuzFNVP5IZJyebvsXDcm8Ot 1JKgONdoSPKf7JwRtywyxm16cu1hcrHTnTflM/GvGNt8IwD1aobakhE9HLi3JwAFwYSE T+Zg== X-Gm-Message-State: AJIora9KhQQhCuHY0dCGJ45GrjUyxebmBHqRloBYufo/zOP6EXJKMcpt ubwZKR7eF3BgMiHQmZbm5V8= X-Google-Smtp-Source: AGRyM1uPSv5ukhWossIxUO7jh66r750jRUMLDa1dA2panHIS8cwLnQ2Smf8Jue6GGYtL1Wev0XXYEw== X-Received: by 2002:a17:906:cc12:b0:72b:67bb:80c3 with SMTP id ml18-20020a170906cc1200b0072b67bb80c3mr20748678ejb.668.1659021305532; Thu, 28 Jul 2022 08:15:05 -0700 (PDT) Message-ID: Date: Thu, 28 Jul 2022 18:15:03 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Julien Grall , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> From: Xenia Ragiadakou In-Reply-To: <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, On 7/28/22 16:56, Julien Grall wrote: > Hi, > > On 28/07/2022 14:49, Xenia Ragiadakou wrote: >> The macro parameter 'v' is used as an expression and needs to be >> enclosed in >> parentheses. >> >> Signed-off-by: Xenia Ragiadakou >> --- >>   xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h >> b/xen/arch/arm/include/asm/arm64/sysregs.h >> index 54670084c3..f5a7269a27 100644 >> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >> @@ -461,7 +461,7 @@ >>   /* Access to system registers */ >>   #define WRITE_SYSREG64(v, name) do {                    \ >> -    uint64_t _r = v;                                    \ >> +    uint64_t _r = (v);                                              \ > > I am failing to see why the parentheses are necessary here. Could you > give an example where the lack of them would end up to different code? Here v is supposed to be used as an expression. So maybe the rule wants to enforce that in the macro we will pass an expression and not multiple statements (?) ... not sure. > >>       asm volatile("msr "__stringify(name)", %0" : : "r" (_r));       \ >>   } while (0) >>   #define READ_SYSREG64(name) ({                          \ > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:29:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:29:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376916.609958 (Exim 4.92) (envelope-from ) id 1oH5S8-0006Zs-Ni; Thu, 28 Jul 2022 15:29:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376916.609958; Thu, 28 Jul 2022 15:29:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5S8-0006Zl-Kz; Thu, 28 Jul 2022 15:29:32 +0000 Received: by outflank-mailman (input) for mailman id 376916; Thu, 28 Jul 2022 15:29:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5S7-0006Zf-F9 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 15:29:31 +0000 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [2a00:1450:4864:20::536]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 12be1ddd-0e8a-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 17:29:30 +0200 (CEST) Received: by mail-ed1-x536.google.com with SMTP id z15so2620666edc.7 for ; Thu, 28 Jul 2022 08:29:30 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id x24-20020a1709064a9800b0072af843c794sm529337eju.43.2022.07.28.08.29.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 08:29:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 12be1ddd-0e8a-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=C2IFZRbn4+lRX2JFiR8wcrCL9rpAB0PQiWf6KhpHpC8=; b=FrrlO1wDH9AMrH29n05Qod74j7qx6xXUoszyWEdXt8mCw5U99Qv8lN3tvJzSwg76K0 vTaVB22KZ3v6JIuSxGEgI2mhLzuPe3biAtGNAOg8IwdjaXjXQ/+M4RNhdL8hwqf4XkUK /BJdYnrsfJxs4HfUp2vaMqEMyaj7HzINvYoV51uZyYjH0JZDtpq41bTSh85wxOsoBpFK aJRzmyc5UFtDbWy19yg1/fmk3wu+NoX+Ry/s/ASN3W34JEwTL/rFEXriEoj+cR54xLBK Henu8vKFuFK+T8HggEkTUAMwWclqNyUxNhJwFKHpWYaaL+OIn8OntM4udizD99mkwmr/ Hfiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=C2IFZRbn4+lRX2JFiR8wcrCL9rpAB0PQiWf6KhpHpC8=; b=MmvGxeTTdal2gkPL1NEfoXgttrNyz92ncjRxw8B85bwM+9NMzF9lbAMtJ1mrlotvu5 M3tiFNdBBAk9bk7dx88zbh9/zgniWBx08/Ru2JW4H/iyBM+rcozS9newgOob0b03ScsA ptK0y6eKN9/vRoL8h/QP+V1WDbE93JbXRTf9wwIhh5VgeuvwOGwoyDrJyIKxb+n80zfe h+z1BERD/02+rRSGWu0d2JAItMF/PAmChhLmHKqOzDWk94FR2WGRPI1KNSyeoOGL/c/m 3GFwrgrDdv4PlbmfR4O48yLXtCiP+4geVrPpNPcu2a6jEUhdWML9d2jxNjEJOzlpkRej 0Uzw== X-Gm-Message-State: AJIora8vfMl7wugT281Mv0T30Zg9V9u1tTpeNjphQkw5wpY9E/WKp4IL idssTj6QxI1oj2/Qi1R8tSg= X-Google-Smtp-Source: AGRyM1vfVvfsac+onx7pCovofLNABb7X5tk0aUc6n+WxSCoSmRzzRjyQ6X4nJwXUOULfMuMwNghR0A== X-Received: by 2002:a05:6402:501d:b0:437:e000:a898 with SMTP id p29-20020a056402501d00b00437e000a898mr28375701eda.265.1659022169670; Thu, 28 Jul 2022 08:29:29 -0700 (PDT) Message-ID: Date: Thu, 28 Jul 2022 18:29:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Julien Grall , Jan Beulich Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 7/28/22 17:34, Julien Grall wrote: > Hi, > > On 28/07/2022 15:20, Jan Beulich wrote: >> On 28.07.2022 15:56, Julien Grall wrote: >>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>> @@ -461,7 +461,7 @@ >>>>    /* Access to system registers */ >>>>    #define WRITE_SYSREG64(v, name) do {                    \ >>>> -    uint64_t _r = v;                                    \ >>>> +    uint64_t _r = (v);                                              \ >>> >>> I am failing to see why the parentheses are necessary here. Could you >>> give an example where the lack of them would end up to different code? >> >> I think it is merely good practice to parenthesize the right sides of =. >> Indeed with assignment operators having second to lowest precedence, and >> with comma (the lowest precedence one) requiring parenthesization at the >> macro invocation site, there should be no real need for parentheses here. > > I am not really happy with adding those parentheses because they are > pointless. But if there are a consensus to use it, then the commit > message should be updated to clarify this is just here to please MISRA > (to me "need" implies it would be bug). The parentheses are not pointless if the intention is v to be used as an expression to the assignment. If this is not the intended usage for v, then the rule does not apply anyway. -- Xenia From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:35:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:35:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376922.609969 (Exim 4.92) (envelope-from ) id 1oH5Xx-0007z7-Ck; Thu, 28 Jul 2022 15:35:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376922.609969; Thu, 28 Jul 2022 15:35:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Xx-0007z0-9O; Thu, 28 Jul 2022 15:35:33 +0000 Received: by outflank-mailman (input) for mailman id 376922; Thu, 28 Jul 2022 15:35:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Xv-0007yq-Hs; Thu, 28 Jul 2022 15:35:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Xv-0003eL-C4; Thu, 28 Jul 2022 15:35:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Xu-0007cB-QG; Thu, 28 Jul 2022 15:35:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oH5Xu-00025R-Pr; Thu, 28 Jul 2022 15:35:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=XSSfyA1tmDw5lfSCvhkSr968p3Ny+VYrPM5jEY99pEA=; b=p3XfzANUzHedpETdkTK/6QZfgj fkYayglwb1GgRpeJ65u1qTthGKUmXU1ARo+H7kLkEMdMLkYnUXi6pPpais79Dafso/lPCAfqoy8ZW vAhWcRiB8DoIjY/HQUGuHcOtQMien2CZzl0fBYQPXQCnr1iuVPmfhFgnz+RJfxDmJvuY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171896: tolerable FAIL X-Osstest-Failures: xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Thu, 28 Jul 2022 15:35:30 +0000 flight 171896 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171896/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171887 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171887 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171887 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171887 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171887 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171887 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171887 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171887 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171887 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171887 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171887 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171887 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171896 2022-07-28 08:36:51 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:37:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:37:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376930.609980 (Exim 4.92) (envelope-from ) id 1oH5Zs-0000PH-S1; Thu, 28 Jul 2022 15:37:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376930.609980; Thu, 28 Jul 2022 15:37:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Zs-0000PA-OS; Thu, 28 Jul 2022 15:37:32 +0000 Received: by outflank-mailman (input) for mailman id 376930; Thu, 28 Jul 2022 15:37:30 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Zq-0000P2-T9 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 15:37:30 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5Zq-0003g4-Lt; Thu, 28 Jul 2022 15:37:30 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH5Zq-0003Hi-Ej; Thu, 28 Jul 2022 15:37:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=jCQPGZwJWOctcq94X5UREMIRtJipc6y5laeiAZXZ8mg=; b=Ly3nZyL/LWrNBLWHRlDQNXV7mE NxjuVmdvw+aKEtWZ99LCNCRCDQziHZOuybAXmRkrSpjt/c6WzoWmPpJ3cV5YkTynBlpW/VA1z5hb7 40jpbrujSWOBtIWDPFZqD0c0Xv6Ruq8F+2S7Z4Y+0WvDczYL2rfaidtqUyWj7+g3DX7A=; Message-ID: Date: Thu, 28 Jul 2022 16:37:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou , xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28/07/2022 16:15, Xenia Ragiadakou wrote: > On 7/28/22 16:56, Julien Grall wrote: >> Hi, >> >> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>> The macro parameter 'v' is used as an expression and needs to be >>> enclosed in >>> parentheses. >>> >>> Signed-off-by: Xenia Ragiadakou >>> --- >>>   xen/arch/arm/include/asm/arm64/sysregs.h | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/xen/arch/arm/include/asm/arm64/sysregs.h >>> b/xen/arch/arm/include/asm/arm64/sysregs.h >>> index 54670084c3..f5a7269a27 100644 >>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>> @@ -461,7 +461,7 @@ >>>   /* Access to system registers */ >>>   #define WRITE_SYSREG64(v, name) do {                    \ >>> -    uint64_t _r = v;                                    \ >>> +    uint64_t _r = (v);                                              \ >> >> I am failing to see why the parentheses are necessary here. Could you >> give an example where the lack of them would end up to different code? > > Here v is supposed to be used as an expression. So maybe the rule wants > to enforce that in the macro we will pass an expression and not multiple > statements (?) ... not sure. Do you mean something like below? #include #include #define foo(v) do { \ uint64_t _r = v; \ \ printf("_r %lu\n", _r); \ } while (0) int main(void) { foo(1; printf("Bar\n")); } If yes, then I agree that the compiler will still be happy. Or if you pass "1; 2", v would be set to 1 rather than 2. I am not sure why one would want to write such code. But I guess we want to prevent that. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:38:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:38:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376935.609990 (Exim 4.92) (envelope-from ) id 1oH5ac-0000xI-3r; Thu, 28 Jul 2022 15:38:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376935.609990; Thu, 28 Jul 2022 15:38:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5ac-0000xA-0z; Thu, 28 Jul 2022 15:38:18 +0000 Received: by outflank-mailman (input) for mailman id 376935; Thu, 28 Jul 2022 15:38:17 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5ab-0000ta-37 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 15:38:17 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2061.outbound.protection.outlook.com [40.107.22.61]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 4b6aa726-0e8b-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 17:38:15 +0200 (CEST) Received: from AS9PR01CA0009.eurprd01.prod.exchangelabs.com (2603:10a6:20b:540::17) by AM0PR08MB3940.eurprd08.prod.outlook.com (2603:10a6:208:124::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 15:38:03 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:540:cafe::60) by AS9PR01CA0009.outlook.office365.com (2603:10a6:20b:540::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 15:38:03 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 15:38:03 +0000 Received: ("Tessian outbound 6a3290ff1310:v123"); Thu, 28 Jul 2022 15:38:02 +0000 Received: from adfd7411e47c.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 2A49613F-5FEA-4337-A960-422E9036FBB4.1; Thu, 28 Jul 2022 15:37:50 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id adfd7411e47c.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 15:37:50 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com (2603:10a6:20b:41f::23) by DBBPR08MB6124.eurprd08.prod.outlook.com (2603:10a6:10:202::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 15:37:48 +0000 Received: from AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::e582:2499:8676:9dff]) by AM9PR08MB7165.eurprd08.prod.outlook.com ([fe80::e582:2499:8676:9dff%7]) with mapi id 15.20.5482.010; Thu, 28 Jul 2022 15:37:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4b6aa726-0e8b-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ElMhYn4mWNtF3SB6IaPLu9MN9yFvJVOrOxx1r/ZJNu4Fwr9CXXxonywp6qTHMyUQyvUtnTNrj5Vmizc2XAKKj64yAkHg1J0K3CyxD+QSgt2ddlHT1Zly98VZpzOpWrVnIPoNexG6XgoYeUVXVHNnnkaICgA1Pzqkgg/IB/E7z5TLTEAYbkAcE3TlgIpds0BguHiQ07ox1WpGRQGYeyMkcSqUNxOfQJbJUlLfGrfjfvkGEp0+4bS6bVKyPi0a+Wew/GHcn8G4aZ682oUjdZE4rvTvNeYydEfabC5B7+D6l2H1bPjxkPoqQU/yy61fjNstlEXHc58UPhRBVL/u4nb/dA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NUSvrrqj1h4rtA4Pq/sp6Cnh8ley9aSPxp0ZG0cWosk=; b=Wey519HkBG5pujsqc8Qt0ffIpoqZaUtu+w1iK+SHYOC3gZhWsncsStgxnCE+HaeTWKkh6f0E9j7rm6xa117NGFIXNuYPO4c4DSwG5saSxlPvGPupc14CgLiCHpYRE5YVYuMQWY5hdyw9Ke3EC41bEx46qz3gBVecc5P28Aaw5UXjH2D9LERE5OZWTTZ6kHTJkv19cv34FK1WGOn8ln+en1rETLWvisgqbhGGPaZIhchBpjjFPGvtW9/olxy/P/RKWRC8521evMcUWjF/rt7lnP6qHsxPW45HqXaFYBbhNu+N5GE2g5fDlfsGYTmX6jqnyloa2V1+jxzWphzIPZo1bg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NUSvrrqj1h4rtA4Pq/sp6Cnh8ley9aSPxp0ZG0cWosk=; b=pq2tnD6pn4HmDKUoxGysTt2xLftln8n7GLVjt9mBWrD74mh1lsvMYntyIdbsM6gZtZx3kRUAafxeZUiQKee3Dbk5hh6LPjfhyujLNKR7BVf99mb2YJqlfqnVYMz1pRox81RI7Iz47xQkvgBhM/MGTcC+and62GifEOC8z0CpvI8= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 933ab0fa02bf032a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B8w10Ke/oPWpifRh5VgKZAMqKBHGhSBsxJOiDoh4f5sKZ3Bs/1bZUK/rYtUf84uHCW7L6KkdZIIubc0NkuyUUktXLq/8kuA4+Ow+mb7TliF4JqKkhTqDuIJF5gH8AcC/G5aeggnoB0ep1RyzRZ8w/FlsX771rQur90ev2MNbq2JAqP/eKE/CGsZL41/WZxaRl9S6RqlhCldTflfRomxVV8r+BfGhGsXx1AjQeDdOXhe1yy5ldvDCzVChbAtn49ZXVIWuYGYwq4JHjIi71fzhAwAcoHQjTq4+Ea8PwJYUemKuiUJeMjTo5dVyDA3aJcOrg84WAReWBEaJAioTVFMrZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NUSvrrqj1h4rtA4Pq/sp6Cnh8ley9aSPxp0ZG0cWosk=; b=etcNy3al4/GhcmyGeHlo3P/4hxb6XG6jApO3NrnwsVh1Sb6T/Ma+1nk3tZ9Xr1C5IGMaEncblVwUcGLHX4/E/immRAeFNTqr/q8y9+EKpclyYyZ2Eq8zX8ryrsKURPka9GPitrMkP0JuIOGjIalvxv5y8zCYnzVNoJQHyePHO7j0tqs0uFAYKDrUwvzeF4VxKTNpH33Iem1Ls5/qsdm/FC5IMEaKX9rmXREZPUsNkKd9uo8J252VlNK5H+fn0ewkt7hy+U00CoMbwKt8pxURD9ArxolnbU5o0Wp4P0mYVc1n2DLZZqN4+2xakcVRNUpF9+gjJEgJlVHmf8/HsVZaLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NUSvrrqj1h4rtA4Pq/sp6Cnh8ley9aSPxp0ZG0cWosk=; b=pq2tnD6pn4HmDKUoxGysTt2xLftln8n7GLVjt9mBWrD74mh1lsvMYntyIdbsM6gZtZx3kRUAafxeZUiQKee3Dbk5hh6LPjfhyujLNKR7BVf99mb2YJqlfqnVYMz1pRox81RI7Iz47xQkvgBhM/MGTcC+and62GifEOC8z0CpvI8= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AAgAAEsgCACtZcgIAAFXWAgAGspoCAAAsFgIAAI8AAgAf9PoCAAwMegA== Date: Thu, 28 Jul 2022 15:37:47 +0000 Message-ID: <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 0273724e-8976-43c5-6da1-08da70af28c2 x-ms-traffictypediagnostic: DBBPR08MB6124:EE_|VE1EUR03FT055:EE_|AM0PR08MB3940:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 7eCxtFFwHx96HUDIKM9j83bcnDJGCYy1e1F8LOImMO3p/Ee83eO0f9xYHQwTBePyXW07DgKoQPD1JScStL2cMkBshzATAZs49n0HZx+8tWmyOxw+EX5Ld07vgz9FfZ+Fe77U2zG8erM7B2WCnD81QZYryKgd73sZjADtaSNAQAvEfi9OOMiXIVwejl3SFsh4jaoWqBOwgo7YB0RJWp3uAYV9CUmeh98bw0UFPOTkGVl9bZSHpzOwOzfnF4chd+elxTyPcj76ViFWwzC9wEr5O2Xp27tZAYUc4z/GvsnXE9s0GgWiftHo0mjYCNLHNzCJ1UjK8KKEgIwIJMSYET9LZV47eky3zF6ukARozniXT/UFNehcyclhq/qvoT8JZ2tajSdG0XSv5yWykSYTSjyNU5K1DvWW+/0dmkWfVzp5hllXvRqyEuV2nhF+UIPY82m+gj3G4m2BVuLx9Vfg6NdjIZIeLbNskiZl9kqH5HNsplrrywWNM2FUuNiXKBuPNz7Ao8OoAjri5EE61QTA842ubsP06o2iNEtx71P3X+MCWkgOxzGq80CjQHZwWTsENQ9Eh0moEGZvnw8zkzLMnBbkWhCno4gZvTzqFCUejoUU3nxI8XvqtdHN18kUbsIkA8SHCAZwo8TemL3SgwytHcbhQLqkBhcIA2Dvm4nxqtZUoFEVznMvkktRTl0sDuBc5CS/8Mpk+AKrtRSIgf/2l2vh2XgG6fLqrBwI2TkAqlMMHGM5xX4hHFVtE4ttF/t3EWy5p/zPC96+UM0oWwZuXZHYjy5T+ODdzD4IwbP/7hFH9jxvNXQd8DyNHQC0YEWwITY3ICv4d62hsRPrQM1rQWDe1w== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM9PR08MB7165.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(39860400002)(396003)(136003)(346002)(366004)(84040400005)(122000001)(66946007)(83380400001)(316002)(36756003)(38100700002)(6916009)(54906003)(186003)(53546011)(6506007)(2906002)(66476007)(71200400001)(66446008)(64756008)(91956017)(86362001)(8676002)(6486002)(33656002)(2616005)(8936002)(4326008)(38070700005)(5660300002)(478600001)(66556008)(26005)(76116006)(41300700001)(6512007)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6124 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f31ec8fe-f935-4a49-272b-08da70af1f8f X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LMf9Ud0iHcfmEcGK6e8QLFXb4lQ+Hvtx/03dGCJrBCfcDzz8kHkksaJoLdFkzHiWyEYKDAZTiGwxHyLBHOiUEmAXWdAUkd2CPORy7/kZoqU5GdwOKYyTGWoLFAohQaFM8xxGeFQJwRX5rgFjF3W8LVrUHQCkmGe5jlJ48676A6EV3qSqIE1zT6ZtNcs/SIAqv+r2HfH3S87Alyd6GttxafqPyGTNenFc7yUKZb36jge+T9G30YzjSg/pwyfM7GOtKfWbVDzzbXW1vYej2+i/ijwjv8ZgLKo9Wh4B8dAAzXRGYOKdSMBCBxOYrZUMuYfi2BgbvDCQFbi4yovLsAa0ok0jJHSyGzNSX7VNVUrZ4LtzaqSHNoSwowvvE/72SVzasQz7sm9vgcR1UI9ykmWK1cF6n1iWwHAH9avp24NOXMk9AgRhOS/gB9TlyrVyd6jnMfFypolEXvV72EoB6IAERGBpAa7k0eVUr0CLlO63efZ1qH2Nlh21E/gFA7easdQaByuyGl4F0w3cUMFiiBDQHgatjf+CHY8m+XPEIq9oSzpWbzSwVketk1n5ReH72if96wkWSXwx/wq5Bv7jDphlLs7IRH7JLCR0QFNhje+b1BSIxpvFlMSbJW0ZnPAcf5VOkFB8d0yo5QDHBlE2Q0ajJAnGN1E4kyMoLniJ8OQvtyCQA8KCnqnRBemfnb/DQAjSLRmp3eXrE7feh+yZRmD9uGcXJr00j52riCmnq4Ma9EpqozYIlgduGbOMA6GvNhhxNT9RzsRIDaMh9khIAZizI9LKpzpzX8rMzAR3rBis7JNewemSTC3JPMGMYiBt+u2D X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(376002)(39860400002)(136003)(346002)(84040400005)(40470700004)(46966006)(36840700001)(2616005)(82310400005)(41300700001)(186003)(47076005)(86362001)(316002)(53546011)(36756003)(6506007)(5660300002)(83380400001)(40460700003)(336012)(356005)(2906002)(4326008)(40480700001)(6486002)(6512007)(8936002)(6862004)(81166007)(82740400003)(54906003)(33656002)(26005)(70586007)(478600001)(8676002)(70206006)(36860700001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 15:38:03.0358 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0273724e-8976-43c5-6da1-08da70af28c2 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3940 SGkgSnVsaWVuDQoNCj4gT24gMjYgSnVsIDIwMjIsIGF0IDY6MzcgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gDQo+IA0KPiBPbiAyMS8wNy8yMDIyIDE2OjM3 LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEhpIEp1bGllbiwNCj4gDQo+IEhpIFJhaHVsLA0KPiAN Cj4+PiBPbiAyMSBKdWwgMjAyMiwgYXQgMjoyOSBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVu Lm9yZz4gd3JvdGU6DQo+Pj4gDQo+Pj4gT24gMjEvMDcvMjAyMiAxMzo1MCwgUmFodWwgU2luZ2gg d3JvdGU6DQo+Pj4+IEhpIEp1bGllbiwNCj4+PiANCj4+PiBIaSBSYWh1bCwNCj4+PiANCj4+Pj4+ IE9uIDIwIEp1bCAyMDIyLCBhdCAxMjoxNiBwbSwgSnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9y Zz4gd3JvdGU6DQo+Pj4+PiANCj4+Pj4+IEhpIFJhaHVsLA0KPj4+Pj4gDQo+Pj4+PiBPbiAyMC8w Ny8yMDIyIDEwOjU5LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+Pj4+Pj4gT24gMTMgSnVsIDIwMjIs IGF0IDE6MjkgcG0sIEp1bGllbiBHcmFsbCA8anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPj4+Pj4+ PiANCj4+Pj4+Pj4gDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBPbiAxMy8wNy8yMDIyIDEzOjEyLCBCZXJ0 cmFuZCBNYXJxdWlzIHdyb3RlOg0KPj4+Pj4+Pj4+IE9uIDEzIEp1bCAyMDIyLCBhdCAxMjozMSwg SnVsaWVuIEdyYWxsIDxqdWxpZW5AeGVuLm9yZz4gd3JvdGU6DQo+Pj4+Pj4+Pj4+IEkgY2FuJ3QN Cj4+Pj4+Pj4+Pj4gc2VlIHdoeSBpdCB3b3VsZCBiZSB3cm9uZyB0byBoYXZlIGEgbW9yZSB0aWdo dCBsaW1pdCBvbiBzdGF0aWMgcG9ydHMNCj4+Pj4+Pj4+Pj4gdGhhbiBvbiB0cmFkaXRpb25hbCAo ImR5bmFtaWMiKSBvbmVzLiBFdmVuIGlmIG9ubHkgdG8gbWFrZSBzdXJlIHNvDQo+Pj4+Pj4+Pj4+ IG1hbnkgZHluYW1pYyBvbmVzIGFyZSBsZWZ0Lg0KPj4+Pj4+Pj4+IA0KPj4+Pj4+Pj4+IFRoaXMg aXMgc2ltaWxhciB0byBYZW4gZm9yYmlkZGluZyB0byBjbG9zZSBhIHN0YXRpYyBwb3J0OiBpdCBp cyBub3QgdGhlIGh5cGVydmlzb3IgYnVzaW5lc3MgdG8gY2hlY2sgdGhhdCB0aGVyZSBhcmUgZW5v dWdoIGV2ZW50IGNoYW5uZWwgcG9ydHMgZnJlZWQgZm9yIGR5bmFtaWMgYWxsb2NhdGlvbi4NCj4+ Pj4+Pj4+IE9uIG90aGVyIHNpZGUgd2UgbmVlZCB0byBiZSBjYXV0aW91cyBub3QgdG8gYWRkIHRv byBtdWNoIGNvbXBsZXhpdHkgaW4gdGhlIGNvZGUgYnkgdHJ5aW5nIHRvIG1ha2UgdGhpbmdzIGFs d2F5cyBtYWdpY2FsbHkgd29yay4NCj4+Pj4+Pj4+IElmIHlvdSB3YW50IFhlbiB0byBiZSBhY2Nl c3NpYmxlIHRvIG5vbiBleHBlcnQgYnkgbWFnaWNhbGx5IHdvcmtpbmcgYWxsIHRoZSB0aW1lLCB0 aGVyZSB3b3VsZCBiZSBhIGxvdCBvZiB3b3JrIHRvIGRvLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gSXQg aXMgbm90IGNsZWFyIHRvIG1lIHdoZXRoZXIgeW91IGFyZSByZWZlcnJpbmcgdG8gYSBkZXZlbG9w cGVyIG9yIGFkbWluIGhlcmUuDQo+Pj4+Pj4+IA0KPj4+Pj4+PiBPbiB0aGUgYWRtaW4gc2lkZSwg d2UgbmVlZCB0byBtYWtlIHN1cmUgdGhleSBoYXZlIGFuIGVhc3kgd2F5IHRvIGNvbmZpZ3VyZSBl dmVudCBjaGFubmVscy4gT25lIGtub2IgaXMgYWx3YXlzIGdvaW5nIHRvIGVhc2llciB0aGFuIHR3 byBrbm9icy4NCj4+Pj4+Pj4gDQo+Pj4+Pj4+IE9uIHRoZSBkZXZlbG9wcGVyIHNpZGUsIHRoaXMg Y291bGQgYmUgcmVzb2x2ZWQgYnkgYmV0dGVyIGRvY3VtZW50YXRpb24gaW4gdGhlIGNvZGUvaW50 ZXJmYWNlLg0KPj4+Pj4+PiANCj4+Pj4+Pj4gQ2hlZXJzLA0KPj4+Pj4+IFRvIGNvbmNsdWRlIHRo ZSBkaXNjdXNzaW9uLCBJZiBldmVyeW9uZSBhZ3JlZSBJIHdpbGwgYWRkIHRoZSBiZWxvdyBwYXRj aCBvciBzaW1pbGFyIGluIHRoZSBuZXh0IHZlcnNpb24gdG8gcmVzdHJpY3QgdGhlDQo+Pj4+Pj4g bWF4IG51bWJlciBvZiBldnRjaG4gc3VwcG9ydGVkIGFzIHN1Z2dlc3RlZC4NCj4+Pj4+IA0KPj4+ Pj4gSSBhbSBmaW5lIGlmIHRoZSBsaW1pdCBmb3IgZG9tVSBpcyBmaXhlZCBieSBYZW4gZm9yIG5v dy4gSG93ZXZlciwgZm9yIGRvbTAsIDQwOTYgaXMgcG90ZW50aWFsbHkgdG9vIGxvdyBpZiB5b3Ug aGF2ZSBtYW55IFBWIGRyaXZlcnMgKGVhY2ggYmFja2VuZCB3aWxsIG5lZWQgYSBmZXcgZXZlbnQg Y2hhbm5lbHMpLiBTbyBJIGRvbid0IHRoaW5rIHRoaXMgd2FudHMgdG8gYmUgZml4ZWQgYnkgWGVu Lg0KPj4+PiBBZ3JlZS4NCj4+Pj4+IA0KPj4+Pj4gSSBhbSBub3QgZW50aXJlbHkgc3VyZSB3ZSB3 YW50IHRvIGxpbWl0IHRoZSBudW1iZXIgb2YgZXZlbnQgY2hhbm5lbHMgZm9yIGRvbTAuIEJ1dCBp ZiB5b3Ugd2FudCB0bywgdGhlbiB0aGlzIHdpbGwgaGF2ZSB0byBiZSBkb25lIHZpYSBhIGNvbW1h bmQgbGluZSBvcHRpb24gKG9yIGRldmljZS10cmVlIHByb3BlcnR5KS4NCj4+Pj4gV2UgbmVlZCB0 byBzdXBwb3J0IHRoZSBzdGF0aWMgZXZlbnQgY2hhbm5lbCBmb3IgZG9tMCBhbHNvLCBpbiB0aGF0 IGNhc2UsIHdlIG5lZWQgdG8gcmVzdHJpY3QgdGhlIG1heCBudW1iZXIgb2YgZXZ0Y2huIGZvciBk b20wIHRvIG1pdGlnYXRlIHRoZSBzZWN1cml0eSBpc3N1ZS4NCj4+PiANCj4+PiBJdCBzb3VuZHMg bGlrZSB0aGVyZSBhcmUgc29tZSBtaXN1bmRlcnRhbmRpbmcgb3IgSSBhbSBtaXNzaW5nIHNvbWUg Y29udGV4dC4gVGhlIHN0YXRpYyBldmVudCBjaGFubmVscyB3aWxsIGJlIGFsbG9jYXRlZCBhdCBi b290LCBzbyB0aGUgd29yc2UgdGhhdCBjYW4gaGFwcGVuIGlzIGl0IHdpbGwgYmUgc2xvd2VyIHRv IGJvb3QuDQo+Pj4gDQo+Pj4gTXkgcG9pbnQgcmVnYXJkaW5nIGZpZm8gd2FzIG1vcmUgaW4gdGhl IGdlbmVyaWMgY2FzZSBvZiBhbGxvd2luZyB0aGUgY2FsbGVyIHRvIHNlbGVjdCB0aGUgcG9ydC4g VGhpcyB3b3VsZCBiZSBhIGNvbmNlcm4gaW4gdGhlIGNvbnRleHQgb2Ygbm9uLWNvb3BlcmF0aXZl IGxpdmUtbWlncmF0aW9uLiBBbiBlYXN5IHdheSBpcyB0byByZXN0cmljdCB0aGUgbnVtYmVyIG9m IHBvcnRzLiBGb3IgeW91LCB0aGlzIGlzIGp1c3QgYW4gaW5jcmVhc2UgaW4gYm9vdCB0aW1lLg0K Pj4+IA0KPj4+IEZ1cnRoZXJtb3JlLCB0aGVyZSBpcyBhbiBpc3N1ZSBmb3IgZG9tMGxlc3MgZG9t VXMgYmVjYXVzZSB3ZSBkb24ndCBsaW1pdCB0aGUgbnVtYmVyIG9mIHBvcnQgYnkgZGVmYXVsdC4g VGhpcyBtZWFucyB0aGF0IGEgZG9tVSBjYW4gYWxsb2NhdGUgYSBsYXJnZSBhbW91bnQgb2YgbWVt b3J5IGluIFhlbiAod2UgbmVlZCBzb21lIHBlci1ldmVudCBjaGFubmVsIHN0YXRlKS4gSGVuY2Ug d2h5IEkgc3VnZ2VzdGVkIHRvIHVwZGF0ZSBtYXhfZXZ0Y2huX2NoYW5uZWwuDQo+PiBUaGFua3Mg Zm9yIHRoZSBjbGFyaWZpY2F0aW9uLg0KPj4+IA0KPj4+PiBJZiB0aGUgYWRtaW4gc2V0IHRoZSB2 YWx1ZSBncmVhdGVyIHRoYW4gNDA5NiAob3Igd2hhdCB3ZSBhZ3JlZWQgb24pIGFuZCBzdGF0aWMg ZXZlbnQgY2hhbm5lbCBzdXBwb3J0IGlzIGVuYWJsZWQgd2Ugd2lsbCBwcmludCB0aGUgd2Fybmlu ZyB0byB0aGUgdXNlciByZWxhdGVkIHRvIGZpbGwNCj4+Pj4gdGhlIGhvbGUgaXNzdWUgZm9yIEZJ Rk8gQUJJLg0KPj4+IA0KPj4+IFNlZSBhYm92ZS4gSSBkb24ndCBzZWUgdGhlIG5lZWQgZm9yIGEg d2FybmluZy4gVGhlIGFkbWluIHdpbGwgbm90aWNlIHRoYXQgaXQgaXMgc2xvd2VyIHRvIGJvb3Qu DQo+PiBPay4gSSB3aWxsIG5vdCBhZGQgdGhlIHdhcm5pbmcuIEp1c3QgdG8gY29uZmlybSBhZ2Fp biBpcyB0aGF0IG9rYXkgSWYgSSBhZGQgbmV3IGNvbW1hbmQgbGluZSBvcHRpb24gIm1heF9ldmVu dF9jaGFubmVsc+KAnSBpbg0KPj4gbmV4dCB2ZXJzaW9uIGZvciBkb20wIHRvIHJlc3RyaWN0IHRo ZSBtYXggbnVtYmVyIG9mIGV2dGNobi4NCj4gDQo+IFBlcnNvbmFsbHkgSSBhbSBmaW5lIHdpdGgg YSBjb21tYW5kIGxpbmUgb3B0aW9uIHRvICpnbG9iYWxseSogcmVzdHJpY3QgdGhlIG51bWJlciBv ZiBldmVudHMgY2hhbm5lbC4gQnV0IEphbiBzZWVtZWQgdG8gaGF2ZSBzb21lIHJlc2VydmF0aW9u LiBRdW90aW5nIHdoYXQgaGUgd3JvdGUgcHJldmlvdXNseToNCj4gDQo+ICJJbW8gdGhlcmUgd291 bGQgbmVlZCB0byBiZSBhIHZlcnkgZ29vZCByZWFzb24gdG8gbGltaXQgRG9tMCdzIHBvcnQgcmFu Z2UuDQoNCkFzIHlvdSBtZW50aW9uZWQsIGlmIHdlIGRvbuKAmXQgcmVzdHJpY3QgdGhlIG51bWJl ciBvZiBldmVudHMgY2hhbm5lbCBmb3IgdGhlIGRvbTAgc3lzdGVtIHdpbGwgYm9vdCBzbG93ZXIu DQpUaGlzIGlzIGEgZ29vZCByZWFzb24gdG8gcmVzdHJpY3QgdGhlIG51bWJlciBvZiBldmVudCBj aGFubmVscyBmb3IgZG9tMC4NCiANCkBKYW46IEkgbmVlZCB5b3VyIGlucHV0IG9uIHRoaXMgYmVm b3JlIEkgc2VuZCB0aGUgbmV4dCB2ZXJzaW9uIG9mIHRoZSBwYXRjaCBzZXJpZXMuDQoNClJlZ2Fy ZHMsDQpSYWh1bA== From xen-devel-bounces@lists.xenproject.org Thu Jul 28 15:51:52 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 15:51:52 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376943.610002 (Exim 4.92) (envelope-from ) id 1oH5nd-0003U4-AZ; Thu, 28 Jul 2022 15:51:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376943.610002; Thu, 28 Jul 2022 15:51:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5nd-0003Tx-75; Thu, 28 Jul 2022 15:51:45 +0000 Received: by outflank-mailman (input) for mailman id 376943; Thu, 28 Jul 2022 15:51:44 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH5nc-0003Tr-BC for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 15:51:44 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60086.outbound.protection.outlook.com [40.107.6.86]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 2c52b454-0e8d-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 17:51:42 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DBAPR04MB7368.eurprd04.prod.outlook.com (2603:10a6:10:1ad::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 15:51:40 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 15:51:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c52b454-0e8d-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URtXR1WY7Wf2ns6O4HZAljmPqXeCfhOENh/Kn2tRhw8Ejs0qLaZL28vJ/guVZK8q8EgksDDoiCxq3vlMDkgbTunEZf+mmU3qMB5++tBRKtHzZjFJ+s42Af/Taj1GrEzoWyiM7rapE3jyHnesS0j/Fu+nkfhA4RzNkZnGl5Es8bBBoel2UPCqzaCH6+4EoSB63jQC52/hobzOiBoFAZIT0jFCF8q4aghNJVSfawSayWZnoROe/2bIapBnSk96bPD8P6IHDIrhDutrR9g6068Df14irRyvRQRXrEU6pjy590UFc0pgUr5KJ/rqSidagI3XpMbUM14Ff2cCQp8opHoCfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r0s+R7yNNKX3aIiKoZPdA1fzy8enW0+HY3llMQIngbQ=; b=OcSqXxcUQ1Ui8Qf6B14zQ7xTZxWb6jMvo6D5pFu1lIZ0e9Rmlbq0+3qtXZA3gkn3pDf30jtHh+1g0RPDYnSxjRJ4jivrtg7FnT/QzlHtleRuzLLXHJ5m8g/MlSIYe3jwkdKdtZ7VQkRr22ZOXADEJyGfn/9mCQx1SyQSbAGcIEJarquao+sD8uNS5pNa0M9CFU5hHB65+S1eqdlueCvBfKnrXiZFnGB4FFDoGW5KzdfoGeU7ZrIFYbjNi7yZEZEU32HbCDwI9zUDCb3r5/FVcyOd5q86yWpihVyQNCuMonU2Izq2AekGgzk03dVGXHd0OCB8WLU66Z8SWbidahUfrA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r0s+R7yNNKX3aIiKoZPdA1fzy8enW0+HY3llMQIngbQ=; b=PyC98QuZlUTg79WOkPeL7hPrVNv9iHWpLbjU5IwJxGe8/uxMAz6tNqZ4NJ6biZz4qsWUeZ3z7hpV0zcVzINx6akE4E3tB95DZ34ShGWWiD29Vs7jNCTeVk6jERaMkkCxdjzPb8QtLduuxpQw/fVzfcLfEPCVER6XM3DeKloFpZOl6MqlMUlmRQ4YmR/HPb3hdGF35u9IWqmPMKdCU6OMcu1PB09j9gzMAZ/7/h/wVXdwA80XCtScFjbgL+X8tLJQ0ZOabB3zOcEG6cXYkUoV6aV5xUrM0WyR4LAmZunonHXkvBoA/98HhF66u5VaUq7xMZqZJl80q82ggh9E0iNidw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <0b398cfb-1b01-0e6b-f3f6-410350153383@suse.com> Date: Thu, 28 Jul 2022 17:51:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Rahul Singh Cc: Bertrand Marquis , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , Julien Grall References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> From: Jan Beulich In-Reply-To: <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0004.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:15::9) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 71916ad2-09bf-496e-d520-08da70b10f81 X-MS-TrafficTypeDiagnostic: DBAPR04MB7368:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ARD8AQPSWKgL4MhpHQQ6NUrE+hS3xh4EZhZK1xPzMbYc34p50MQ0k9o0yivGmLb1U2QxpEQYfD78r+CPZXZZN7epfZRRJCnrQD3cWyPTCem+Ll5ARx2Untl7Ohl56FoCHNyvYlT+bDgoCTW0vgrj1tkzzsZlnlQ/hzlGPJJdCP/NeH7Ss9q0UhygY/aIlDmRvvVNF5SRz64RSfMQVZhIsJtCk+9gScBbXgg8CUG9GOiGR/noz0uFclg5PFRuMciLtuS0asPcIFfhSYyghiL579WWamM7dE79QNQBz4+WjONwYxSbvGOihEBBiSskQUgOkQNyxyPWOe2A4WDdMIoHNH8UgPnnvOhghc3yPAuvPPLxtDny/O4+AeWRZnlocvSG7nKkJH6dvazUBJBis598CoshS0zmYwXo+DEtUY22zxiE6ppu2pSbl2Xdz4u49lFnW7CpU9rCpu13Qd7JNLzlHkQIjhOBbsuU4pL0F0GhuEWLIgC5rDjwxClzTFvB2tzJokkoPrbvQuHHCk19Effgq9yr2VwF93Sf/h4Ppcalbl10xx57h9AoHtU8cVb1VT7KeCSe0Ooq18y00vA+KC3Cg5fvJcF5Hwle4pAuIgQOQzvkGqOxgcSQTRxKgig1EbVBnUbKK8reXZuZf3C9bfM/I1jcygtckfeif+l5fjv/j5d/kfXAIgtsgGFP1coEQgAJWsBpBNlSlH+GNA0rAJ7Oqh9wjZqgb3/0K3iIaL/KcIJiMD9Cweg/2yejYFgnHpYRgwJAlwXAbkzEGYMbo9w+dYUC6+Ym3lzU1au9Gj+60RGlB424Im4Fe6+pHXItJhIdREHLk62TW8Lry9d0o5VE/w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(396003)(39860400002)(346002)(376002)(136003)(84040400005)(4744005)(66946007)(66556008)(5660300002)(66476007)(31686004)(8936002)(316002)(36756003)(4326008)(8676002)(54906003)(41300700001)(6486002)(6916009)(478600001)(86362001)(2906002)(83380400001)(53546011)(2616005)(186003)(6506007)(6512007)(38100700002)(31696002)(26005)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NDBOQXRwaDNRdXEwMlByNnJhcXNFL1M1cVhvelBmRTc1dXlUcE1xMEYxamFt?= =?utf-8?B?S0ZxUEJLOTVkWi8vSklSVHhnWFlIYlFsdkxGcnZOUE11eExXaFQ0Z05BRlc0?= =?utf-8?B?cjl5bHVoUGN1SnM2Titzc0w5M1hpMi8yMDBuZVZhODE2c1piWExQbGJML1Jj?= =?utf-8?B?ZmNNWEZ2RzBZQlRoVDVPdzFYK0VrR1cwMUZNdDZVdXg4azFXOHE3amRlNllF?= =?utf-8?B?MnJhZmZKU0FnL09vVlJzMXN3WVNUVGtlZ0JmQTRPc04wOVVDWUZzV0NIOStG?= =?utf-8?B?aXhBT1lyS3Q4bHpjRll0aHJXWlF4b2xJSzdOWjdET3lPQUJWWERFU1dORTJp?= =?utf-8?B?THNCRmNyYXZ6SzJBS2QrSytDbEFyM1F6U05aWjRzcGlJREI4NlNMdE92MkN5?= =?utf-8?B?Q2ozbEpOSnNocDNCd1FzN2VGV2kxVDFRQlhiTHV1WDlYMXpNMzYvQ0NvT2xS?= =?utf-8?B?R09MU1h1SDllZGdmVm0xWkJ5RWFEWWpQZHpUQ2lJSGFLNkplVDJDMEl5dHp5?= =?utf-8?B?enlDV20xQjM1MFlFL0wzVjM3a3BYRXRSaGVYSkk1SDE3akJ2emVtSEdXTnNF?= =?utf-8?B?emVsazU0N0JrTzhibmhuRzRUMVBRb0oyV04rc0I1VitYNEtRWmxTcG1ISGVk?= =?utf-8?B?d1pmVG10N29LVnkzd0dDa0JOc056amltUS9sdWJlMDVkS01Nc2cwU3VaT21J?= =?utf-8?B?QjlPZjYwc2k5dGxHam9NUTlBMzFlVUFpYXlub1lHUTcvNFhtTkhQRVhKTzlD?= =?utf-8?B?VDd2aXkvb01qcjYrdFFZNklRbGtpaXV6b29xZUdKeHJoQmFUNWsrNXJwYlIx?= =?utf-8?B?MTI3WjJ0K2tHMzMrRkJ6V29aNzJXNmFkMzFkV0xXbERQcSs3a1dQUExRZTNC?= =?utf-8?B?V3ZnQTVtQ0FBTnl5OEZVaVhTUjRlZ1BUcXhJM3RBOTRxK1JrUGg0dVZmYWdz?= =?utf-8?B?YWwvSndxazE4eWNiUHpsUklCb1RLY09yckJWNmFmZmo5d21tcmdlWVplRnNY?= =?utf-8?B?Z2pKNWo4Zm9XVFVJWmlMeEZiK2RGLy9pSTJDWFFpaWxwcXNmZTNnOVhaNFJy?= =?utf-8?B?SU04T0lmamtneXdqOXk1WDBsWjRSUk52T0ZNRWFlL1JSTVVOalcxQkJiTHhT?= =?utf-8?B?VGo3aWxmblVJMk9ZZHYzdmM1ZTdDWnA2dlQ5NFdOclpncVBtNFhDOFNraEhC?= =?utf-8?B?ZEdLMHN6SFczZE1wR015UmlHcVA5UVF6R0Z2a3RXZVhES2UvUUo3RmhBV3RL?= =?utf-8?B?TnpvcTdhQmV2MVV0QW9FQ3Q2WlQxRHNLL2RTZlZPcktDblI5SzhBdCtkVXdL?= =?utf-8?B?aW5XUWt0RzFjZ1dROXRDTEhaSXRRblh2RFJIYVFROWthMTlBU1BVT1o3eTlv?= =?utf-8?B?eTExbkpLV3dJMEtHc1oxWWRFVm9pVzB4U044MG9uMndSdWNoNnVsRG5xYVcz?= =?utf-8?B?bE1hRGtwelNnK002N1pZclJQVkRxYXpyRTJTZExuc0ZHWERlUmdQWS9FWXVT?= =?utf-8?B?WVhNUUZtOVgwc1E1VDlYQzcvdGpDTFJ2SThwRnNhcTBCQ0x1MUI0VUNoSGY5?= =?utf-8?B?anNWWU5xQjZNU1pHeitOMlpBWnUrSG5qMmt5VHd6MzN4cVF5WUtJbWRrZVJ5?= =?utf-8?B?cXpyMmhJL243ZXRWOUcrajlNZzY5eCsvcnVPZ0ZNNlJsU3dVZm1DNWFwYjZK?= =?utf-8?B?bFZTZDJlS2lxMXhYUW45WVFiM0NCRFBVRFUxMW5nZXkzTU5TK2JBbDZ6Z0tY?= =?utf-8?B?dEJ4ZlpyYUxkeGJrTHRLVXMxNEZCOVo5dUZwYmd2NUtqTjN6dlBLcDkyQzhM?= =?utf-8?B?c2xKT1U1RGtyeEtVckpIN2UzNHl0NHpGK3E2eEw5N3lqc0EzbVJCdjU0bVZo?= =?utf-8?B?Y2k4QVlJN2lEZTRMc0lKcUVhUjY5TFhMKzZxU0JFSVoxSm5JRTlaWTQyWitr?= =?utf-8?B?NTl6SVgvcVE5b00zZCs3WE13NXI2V01GeEd0N3p3cVZPZ0VWc3BERlcrR2Fk?= =?utf-8?B?VXBtNE1aczFWMkpaMWh3cnZxQWtsRVBGczVNcGxPd2c5YUVlRDBLZFdYSXBi?= =?utf-8?B?cHJXV2xueXlGTm1Rb3pVNzRDQnpobWo0ZVdTWnQ4MHhzM09DZHFEZlJNR2hm?= =?utf-8?Q?/bbulS4g9gIk1deqGXBIknVFJ?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 71916ad2-09bf-496e-d520-08da70b10f81 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 15:51:39.8973 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pD+7Ad1xftW9Pjs0hI2YvxcxDKYNXtNwYG6qaClXn5lITyad3SuvggFkpcoY5FS3/YxV3UHD0rMh2OQEVCYPDA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7368 On 28.07.2022 17:37, Rahul Singh wrote: >> On 26 Jul 2022, at 6:37 pm, Julien Grall wrote: >> On 21/07/2022 16:37, Rahul Singh wrote: >>> Ok. I will not add the warning. Just to confirm again is that okay If I add new command line option "max_event_channels” in >>> next version for dom0 to restrict the max number of evtchn. >> >> Personally I am fine with a command line option to *globally* restrict the number of events channel. But Jan seemed to have some reservation. Quoting what he wrote previously: >> >> "Imo there would need to be a very good reason to limit Dom0's port range. > > As you mentioned, if we don’t restrict the number of events channel for the dom0 system will boot slower. > This is a good reason to restrict the number of event channels for dom0. > > @Jan: I need your input on this before I send the next version of the patch series. I have to admit that it's not clear to me what you expect - I continue to think the way expressed before. Jan From xen-devel-bounces@lists.xenproject.org Thu Jul 28 16:22:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 16:22:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376951.610013 (Exim 4.92) (envelope-from ) id 1oH6Gt-0007tH-Nm; Thu, 28 Jul 2022 16:21:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376951.610013; Thu, 28 Jul 2022 16:21:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH6Gt-0007tA-Jv; Thu, 28 Jul 2022 16:21:59 +0000 Received: by outflank-mailman (input) for mailman id 376951; Thu, 28 Jul 2022 16:21:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH6Gs-0007t1-FP for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 16:21:58 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 665d558e-0e91-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 18:21:57 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id f15so2821842edc.4 for ; Thu, 28 Jul 2022 09:21:57 -0700 (PDT) Received: from uni.router.wind (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.googlemail.com with ESMTPSA id dk15-20020a0564021d8f00b0043cedad30a5sm997092edb.21.2022.07.28.09.21.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Jul 2022 09:21:55 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 665d558e-0e91-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XJz3FE30CMUZxePR5Hul4ldsrorD4RAPiwG0AXEy62g=; b=l8wAFe4tR4icpFOjTC76vG2xM9yosMH8ldGOfAtBcJDInee7i5GcJ9s5lRaH1a/WR6 IJlyEl05jXAGvyuZHX/DNyn/9K/eqJimV10lCxHRyrXqD347GmfvUw6LGLfpJU7zQLX+ vYs9cKtjmOvIvlgGGpNMBdpVSrohyVf2G2In+LBd0HE/HsF9Mf00XE3uECWMDLnjU3Fg RzAqzyWa4nX/k+vby3v2uXvtq3FvvsNzcFuhQVhTVcwYRkU1gzA9wXg54dPYhZ/otokl G3N1HV7+VBBVjcb3s8fKUhmdXKg/WQkyHySMH+aABk4HE1Os3TSSHxZaet3iePlE8RgK THfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XJz3FE30CMUZxePR5Hul4ldsrorD4RAPiwG0AXEy62g=; b=E+U8TtapYtl1CRPMUEXc0t1/bB6j8vvLwSDFWb25ZeQd19u76GpVY7tjrlgv3P35bo JcuBBm+ne+yOLPl5d1RlTEdtSs9DLZl7f0gAlS5HfL34BB4KDKEyZDojnDDKoJZnu3Ld ItqcLlPfHjDc1yY86VopW8KX2nCXuY7cY63EkYQRvSDSeD4x6rIv8uWlWsRHtdyuksjU mISeIwz8TsnwMb9IWthxTqMe485tV/7jSPfnT8QK3fVuav4Ahq0MkgC7jPesfmcxhlTS hBPByhcGM4KExxlEyc07rRNCdfqwf5S2q1JfhRuBDZD7cqPdTuxyal34niccWmNyM7wX rWew== X-Gm-Message-State: AJIora9Qo25pJuH/fsFw+OOcHJ0PB1ywjVAnFZRxR3kPniPZQx/Bs7Oc NFKR3xPch818zz1mIKlYhIlcAeyvRnY= X-Google-Smtp-Source: AGRyM1txPcvTQtajiZSTmJEhcDTSocrmT/k2OKxHh/gPQ0D2fFfEcjxHo/86ZWcdncxhRl5CCx8dsg== X-Received: by 2002:a05:6402:35c4:b0:43b:fee5:2653 with SMTP id z4-20020a05640235c400b0043bfee52653mr20588266edc.415.1659025315949; Thu, 28 Jul 2022 09:21:55 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Date: Thu, 28 Jul 2022 19:21:51 +0300 Message-Id: <20220728162151.1228747-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The function idle_loop() is referenced only in domain.c. Change its linkage from external to internal by adding the storage-class specifier static to its definitions. Add the function as a 'fake' input operand to the inline assembly statement, to make the compiler aware that the function is used. Fake means that the function is not actually used as an operand by the asm code. That is because there is not a suitable gcc arm32 asm constraint for labels. Declare return_to_new_vcpu32() and return_to_new_vcpu64() that are also referenced by this inline asm statement. Also, this patch resolves indirectly a MISRA C 2012 Rule 8.4 violation warning. Signed-off-by: Xenia Ragiadakou --- Changes in v2: - remove the 'used' attribute and pass the function as input operand to the inline asm statement - declare return_to_new_vcpu32() and return_to_new_vcpu64() Changes in v3: - remove the declarations of return_to_new_vcpu32() and return_to_new_vcpu64() from asm/current.h because this is not the appropriate header - place them in arm/domain.c to restrict their visibilty to this particular file - declare them as noreturn xen/arch/arm/domain.c | 5 ++++- xen/arch/arm/include/asm/current.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c index 2f8eaab7b5..ce1089f0c6 100644 --- a/xen/arch/arm/domain.c +++ b/xen/arch/arm/domain.c @@ -63,7 +63,7 @@ static void do_idle(void) rcu_idle_exit(cpu); } -void idle_loop(void) +static void idle_loop(void) { unsigned int cpu = smp_processor_id(); @@ -331,6 +331,9 @@ static void schedule_tail(struct vcpu *prev) update_vcpu_system_time(current); } +extern void noreturn return_to_new_vcpu32(void); +extern void noreturn return_to_new_vcpu64(void); + static void continue_new_vcpu(struct vcpu *prev) { current->arch.actlr = READ_SYSREG(ACTLR_EL1); diff --git a/xen/arch/arm/include/asm/current.h b/xen/arch/arm/include/asm/current.h index 73e81458e5..6973eeb1d1 100644 --- a/xen/arch/arm/include/asm/current.h +++ b/xen/arch/arm/include/asm/current.h @@ -45,7 +45,7 @@ static inline struct cpu_info *get_cpu_info(void) #define guest_cpu_user_regs() (&get_cpu_info()->guest_cpu_user_regs) #define switch_stack_and_jump(stack, fn) do { \ - asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack) : "memory" ); \ + asm volatile ("mov sp,%0; b " STR(fn) : : "r" (stack), "X" (fn) : "memory" ); \ unreachable(); \ } while ( false ) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 16:35:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 16:35:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376957.610023 (Exim 4.92) (envelope-from ) id 1oH6Tf-000193-Rd; Thu, 28 Jul 2022 16:35:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376957.610023; Thu, 28 Jul 2022 16:35:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH6Tf-00018w-P1; Thu, 28 Jul 2022 16:35:11 +0000 Received: by outflank-mailman (input) for mailman id 376957; Thu, 28 Jul 2022 16:35:10 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH6Te-00018q-5j for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 16:35:10 +0000 Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [2a00:1450:4864:20::22c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3e5833eb-0e93-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 18:35:08 +0200 (CEST) Received: by mail-lj1-x22c.google.com with SMTP id b21so2516857ljk.8 for ; Thu, 28 Jul 2022 09:35:08 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id k18-20020a192d12000000b0048a854462a4sm260629lfj.214.2022.07.28.09.35.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 09:35:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e5833eb-0e93-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Sxv92ZJs3ks/JCHHiU3btXv/lQmsRNCIjFRqW7Zg0uU=; b=NsDTTkpilNTsNHxaJ5ktZzVbng13QHkXSXq7A21SNjtYa/yTUQqGdJeALyFe6b4wC1 G1wyUBntJVhTrwdlPjrfZvl/bAOc4pW3kvXZlzKSsn7FJK6IDDr+4WLwsv6xKN7tQocL I77o9CjgL2bK7uPHkgBWyr5dGShf7ejaSwg+jSZFV3N+7b+bjdvxTX32yyDTSKUZmDN3 X6ZYMeIonmBtRnJi/Anm4O/713SeDkAfTNUbwtImPe6vNVWK5BvTkE/+zcZ9P+a4AAEQ BqdSKmag+7otKXSMpXuzuqTwXdAF/Z5vE39DzM4sR7ulzIgdynjbqQeWQjKPvKPzb5yv Xwxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Sxv92ZJs3ks/JCHHiU3btXv/lQmsRNCIjFRqW7Zg0uU=; b=zJG8yZpip/MWvlX+xjlYGllNgaLBN8Xp4lL3gfZIgS/coEzgv6mDc5zF+v6Ty8a72f viDKu0iVQWNEgqSA7HRmRRZ7Vqp+ZjlNtbHYqSMXuMeEjNqPpjNZc5nww7rOr3Q/GIav TTk3c8aVvxA+LKWEbkzZQfdY+hvsknSFktAqaCmZTYy8UC8DXlVNf2UxqpPQj8XSXTUq rF7ejlqiLTV44TDGu8dIPvvPtWud+99ut1JnmbtNLbFm9yvG5Bfgl7XVMp42Vjfzfhw6 hs3jNNYmY1EyTu2sjkhr8hWmq292MqKjLfwrTTnRGAletwoFzaApgMVc+auvWczBQAQq R2zw== X-Gm-Message-State: AJIora8K069dRSPU24dfcdAuPeC8Lm25lA7ItfRdB8QWgJjMQ9DJwO35 /z68ctAPfxHlopZMNWjXBUY= X-Google-Smtp-Source: AGRyM1sRrFF4CxITdzq6DOgcBvvTuOwxJVZXCMo9f4LEuYOSGqPQCwErehECmxNkiBdb1Er43JQ0hw== X-Received: by 2002:a2e:b945:0:b0:25d:e607:ae27 with SMTP id 5-20020a2eb945000000b0025de607ae27mr9557290ljs.368.1659026108141; Thu, 28 Jul 2022 09:35:08 -0700 (PDT) Message-ID: <3752a158-85a1-e758-36eb-2feb0c5be954@gmail.com> Date: Thu, 28 Jul 2022 19:35:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 28.07.22 10:15, Jan Beulich wrote: Hello Jan > On 27.07.2022 21:39, Oleksandr wrote: >> On 27.07.22 20:54, Oleksandr wrote: >>> On 26.07.22 18:16, Jan Beulich wrote: >>>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>>> --- a/xen/arch/arm/vpci.c >>>>> +++ b/xen/arch/arm/vpci.c >>>>> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, >>>>> mmio_info_t *info, >>>>>       /* data is needed to prevent a pointer cast on 32bit */ >>>>>       unsigned long data; >>>>>   +    /* >>>>> +     * For the passed through devices we need to map their virtual >>>>> SBDF >>>>> +     * to the physical PCI device being passed through. >>>>> +     */ >>>>> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >>>>> +    { >>>>> +        *r = ~0ul; >>>>> +        return 1; >>>>> +    } >>>> I'm probably simply lacking specific Arm-side knowledge, but it strikes >>>> me as odd that the need for translation would be dependent upon >>>> "bridge". >>> >>> I am afraid I cannot answer immediately. >>> >>> I will analyze that question and provide an answer later on. >> >> Well, most likely that "valid" bridge pointer here is just used as an >> indicator of hwdom currently, so no need to perform virt->phys >> translation for sbdf. >> >> You can see that domain_vpci_init() passes a valid value for hwdom and >> NULL for other domains when setting up vpci_mmio* callbacks. > Oh, I see. > >> Alternatively, I guess we could use "!is_hardware_domain(v->domain)" >> instead of "!bridge" in the first part of that check. Shall I? > Maybe simply add a comment? Surely checking "bridge" is cheaper than > using is_hardware_domain(), so I can see the benefit. But the larger > arm/vpci.c grows, the less obvious the connection will be without a > comment. Agree the connection is worth a comment ... > (Instead of a comment, an alternative may be a suitable > assertion, which then documents the connection at the same time, e.g. > ASSERT(!bridge == !is_hardware_domain(v->domain)). But that won't be > possible in e.g. vpci_sbdf_from_gpa(), where apparently a similar > assumption is being made.)    ... or indeed to put such ASSERT _before_ vpci_sbdf_from_gpa(). This will cover assumption being made in both places. diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c index a9fc5817f9..1d4b1ef39e 100644 --- a/xen/arch/arm/vpci.c +++ b/xen/arch/arm/vpci.c @@ -37,10 +37,24 @@ static int vpci_mmio_read(struct vcpu *v, mmio_info_t *info,                            register_t *r, void *p)  {      struct pci_host_bridge *bridge = p; -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); +    pci_sbdf_t sbdf;      /* data is needed to prevent a pointer cast on 32bit */      unsigned long data; +    ASSERT(!bridge == !is_hardware_domain(v->domain)); + +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); + +    /* +     * For the passed through devices we need to map their virtual SBDF +     * to the physical PCI device being passed through. +     */ +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) +    { +        *r = ~0ul; +        return 1; +    } +      if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa),                          1U << info->dabt.size, &data) )      { @@ -57,7 +71,18 @@ static int vpci_mmio_write(struct vcpu *v, mmio_info_t *info,                             register_t r, void *p)  {      struct pci_host_bridge *bridge = p; -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); +    pci_sbdf_t sbdf; + +    ASSERT(!bridge == !is_hardware_domain(v->domain)); + +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); + +    /* +     * For the passed through devices we need to map their virtual SBDF +     * to the physical PCI device being passed through. +     */ +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) +        return 1;      return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa),                             1U << info->dabt.size, r); diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c index d4601ecf9b..fc2c51dc3e 100644 Any preference here? Personally, I think that such ASSERT will better explain the connection than the comment will do. > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Thu Jul 28 18:07:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 18:07:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377011.610052 (Exim 4.92) (envelope-from ) id 1oH7uf-0004Ru-1d; Thu, 28 Jul 2022 18:07:09 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377011.610052; Thu, 28 Jul 2022 18:07:09 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7ue-0004Rn-V7; Thu, 28 Jul 2022 18:07:08 +0000 Received: by outflank-mailman (input) for mailman id 377011; Thu, 28 Jul 2022 18:07:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7ud-0004Rh-70 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 18:07:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7ud-00070z-0L; Thu, 28 Jul 2022 18:07:07 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH7uc-00078p-Qf; Thu, 28 Jul 2022 18:07:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=CffEOejg/97gcWHXDWHuiOgjKlOCmVjQB8zcQBt7E1c=; b=p4BNR3/+zkgFgfdZNUHstDv/D4 h+Bt1jQfziMrwkDgoRPhcx2IU9UO2FGjQ8TQKHvgv+ibXZT2CuPEM+5ALw4x6p5kayoCodSDLrGcE KUyFZKkZUY17aoL8WILpB4d0DNBxEzWAfFUdwUYgvNRNJrC3CMI7Sqdveg1Wpbhypo9U=; Message-ID: Date: Thu, 28 Jul 2022 19:07:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH] arm/domain: fix comment for arch_set_info_guest Content-Language: en-US To: Luca Fancellu , xen-devel@lists.xenproject.org Cc: bertrand.marquis@arm.com, wei.chen@arm.com, Stefano Stabellini , Volodymyr Babchuk References: <20220725144634.8086-1-luca.fancellu@arm.com> From: Julien Grall In-Reply-To: <20220725144634.8086-1-luca.fancellu@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Luca, On 25/07/2022 15:46, Luca Fancellu wrote: > The function arch_set_info_guest is not reached anymore through > VCPUOP_initialise on arm, update the comment. > > Signed-off-by: Luca Fancellu > --- > xen/arch/arm/domain.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/xen/arch/arm/domain.c b/xen/arch/arm/domain.c > index 2f8eaab7b56b..6451cd013c1a 100644 > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -882,9 +882,9 @@ static int is_guest_pv64_psr(uint64_t psr) > #endif > > /* > - * Initialise VCPU state. The context can be supplied by either the > - * toolstack (XEN_DOMCTL_setvcpucontext) or the guest > - * (VCPUOP_initialise) and therefore must be properly validated. > + * Initialise VCPU state. The context can be supplied by the toolstack > + * (XEN_DOMCTL_setvcpucontext) and therefore must be properly validated, > + * or by PSCI call (PSCI_cpu_on) handled by vpsci module. > */ I would prefer if the comment doesn't mention who are the callers. So there are no need to modify the comment the next time we add/remove a caller. How about something like: "Initialise vCPU state. The context may be supplied by an external entity, so we need to validate it" Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 18:09:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 18:09:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377016.610064 (Exim 4.92) (envelope-from ) id 1oH7wS-00050p-E3; Thu, 28 Jul 2022 18:09:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377016.610064; Thu, 28 Jul 2022 18:09:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7wS-00050i-AW; Thu, 28 Jul 2022 18:09:00 +0000 Received: by outflank-mailman (input) for mailman id 377016; Thu, 28 Jul 2022 18:08:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7wQ-00050J-Ad for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 18:08:58 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2064.outbound.protection.outlook.com [40.107.22.64]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 58529cd5-0ea0-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 20:08:56 +0200 (CEST) Received: from AM6P194CA0033.EURP194.PROD.OUTLOOK.COM (2603:10a6:209:90::46) by AS4PR08MB7553.eurprd08.prod.outlook.com (2603:10a6:20b:4fb::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Thu, 28 Jul 2022 18:08:53 +0000 Received: from AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:209:90:cafe::d2) by AM6P194CA0033.outlook.office365.com (2603:10a6:209:90::46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 18:08:53 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT014.mail.protection.outlook.com (10.152.16.130) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Thu, 28 Jul 2022 18:08:52 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Thu, 28 Jul 2022 18:08:52 +0000 Received: from c772c7a123d7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 7F6A098E-4E47-4A22-A4A9-509D19A3A602.1; Thu, 28 Jul 2022 18:08:43 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c772c7a123d7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 28 Jul 2022 18:08:43 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com (2603:10a6:208:103::16) by AM6PR08MB5126.eurprd08.prod.outlook.com (2603:10a6:20b:ef::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 18:08:40 +0000 Received: from AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9]) by AM0PR08MB3809.eurprd08.prod.outlook.com ([fe80::4ca:af1b:4380:abf9%5]) with mapi id 15.20.5458.024; Thu, 28 Jul 2022 18:08:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 58529cd5-0ea0-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=lPY8LAxHu7JHaxyrI9qJeSayC20YmusE9ILwbsArsF1cUO051XwHrGxGMpgZrMr74nXvH5WJp15wWkUYjNudlJ1HKJQ/gOliqatzisiiH6D2T4PqqLkwpyhS72AhsgewOlAQPhHZ8idGe92NQKfRy6LP0gPWc8bkbWP+i0dzE8iYUyUptL6LyTFLyUxVyYHoumuU8k6hjEG8ng6237Lnm0tmwixEO12HBNailfDedm09nLwCEP9SbU9DVlxg+8Em4pfbWiYZfTdRVCU5iTSGgexLuLxUvmhgx/fCrXvi2VParX7CGaDPoiwW6JJi9UXcT9exY4bKkUml324dzewkEw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=Df9OLGMviaBFjTsscWZ3bRAWeETWL97pd3JvXyi4UViM/yD0nXCfBFrQ9d01VpojRvn18hWgsvKvRsrT6QaiOIXJs0CEbAjIv0YPnYr5MTomOOy4qjRrHx8Czd+YUW2JGsekv5NoQSWkAGpbpdvyZt/NGeHFYzRo4mz0SWGs1/6c4dl5A7dNgWI2GhxbS/hHiGhgAmdW/z02rzMgVwQb/HrWsvtJ4PgtgoroTJR3oOAfmI0f+Isj4thUkp+LxIgI1P++DtaiRHk6+3+I+REJWpAOTeL/+zQ8wIPJBpCQAxyC71OdKPF4LcvDVY6T/hZwnowcexa9lGcPX1IFADbzYQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=CNIcZMxZZz3wTsIeszJHks3fMxVw2/nuBPLVc+AtsfE3MS9gfHeBwm9b3aTy5dJrcGXwOm2XmeK34jej0YOuN5NoBy65LNV/Mju2T8hhovEkSFDTUFsrd6EiFdpvq5w2g+d4epE3zaOv0P4pqDxKpntqwinPnelW9gIHwEwdbAY= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: aa6eb36dc0cdb73a X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cf8DrvD43c4ac6huKM1lMv9odAoGJEaxZqROxrlpXtBCGBbRtI91fq4uX2CvZYRSKjf8sLAcBNrpwqKEWC6rA+OySlghdZjtfnIG5m1ucee0tVohYOJ3hRvDiGK14n/8oB/pmbLryCxBYe8GP2Z2P3hWI57z8EbB/PsfTwUwAGDwMj77ijszX4mEwSaowrSWoIGL6q344ULHCaWeML1kfAWVcfeGT3vrjtJRsvK82JkDPuin3GCSFGs2Am4fEeUfLsbwkzjGbJGCn+NGvTVcYMCVifCv+qBcSTxvtR93POZBxEA95DD8/VtRvuSuPXpGUOahmQ84iHvW7LGO9qLGNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=f6cXst+GFg9K+Mzceqh0zp+ycUUxlk4j64atrOu1tuR/JlyrbnQxCDoDVbJ4QZ/5GKn8XNF6d/z74RxEgcKE9Uj+k1J5eN5so4zlWXXx2ptCDVx0k0lap1CjZOXtYEh22Sup1vP31hzOysfL9fSMswd3JmEc1q8qryBhD+hs4xFb1nJtwy38KmBZiPhYLv6UjrKTfWXBu58Z/krTBjcyZOTTKDm1DB1PmLrT0tljQrvwRpBgHKmUkKFdNZGW33jEcQr3Z9Dhe+02wYWUp//UTRTvOP4lv7ZMe9sqEYB0UGON7p3qAhotrLZlf0wpr9QMxBtPoGtX8bGYxDQY84hdGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rxiOG7xtmKa5GcyJ5nBQ1r+LJwJUQzFcdlUsfmfQhz0=; b=CNIcZMxZZz3wTsIeszJHks3fMxVw2/nuBPLVc+AtsfE3MS9gfHeBwm9b3aTy5dJrcGXwOm2XmeK34jej0YOuN5NoBy65LNV/Mju2T8hhovEkSFDTUFsrd6EiFdpvq5w2g+d4epE3zaOv0P4pqDxKpntqwinPnelW9gIHwEwdbAY= From: Luca Fancellu To: Julien Grall CC: Xen development discussion , Bertrand Marquis , Wei Chen , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH] arm/domain: fix comment for arch_set_info_guest Thread-Topic: [PATCH] arm/domain: fix comment for arch_set_info_guest Thread-Index: AQHYoDVxqGFUWjtG0EOgt/onXyD48a2UGUWAgAAAcIA= Date: Thu, 28 Jul 2022 18:08:40 +0000 Message-ID: References: <20220725144634.8086-1-luca.fancellu@arm.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: d52f1a2c-45d8-4690-4c05-08da70c43ade x-ms-traffictypediagnostic: AM6PR08MB5126:EE_|AM5EUR03FT014:EE_|AS4PR08MB7553:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: JGOzPZNmkH0mjDxm5GPnryvC4qedldQ3vYOHBD4/ARaknlnGNRQ/G2ToGnn5qSW7PsgkAxscYX1Ur2e+apz1R7i5XS87vp3eR16P2/XDpBa7CXNG4+3Vm5iKpMOaGUJUSQz3DC58AOB782BthWMsyENmaIk7/A+yCCdSo5uIAltZlkvEfsTe5ACwlQioiAvKq0e6UrvwCQHpZ0ZihmTmbjiUjMbhFHOhJWnTZ+cQW0FAsr/I4f+Y9UnsN/ZMu8SSoRLIRUfDxhVvxwklRhSN3Uk6B7XHwRAQdOe1++TR+gZY4IGdaaJJ0/f9h1122F6ez4DUvYEpXHYXBkwUr+EUnF+RxucTISHwHy2RjQIoH+h2dVR6xqbpU6Gl/t9swlHddX2yvrv0iAI07Gx48SXWBwK/duf62QpKYFou+879zgKgSDoB3ATYN/Kj3r9eoRJvndnUv2j3yoQw+2RZDVOZNNc74r36vjUvufiUQsAcmporzDrmFwETpYcf0xPyRF207UYaqOCV4jRv8yvG6PVJcRe0QXe5LTcMW+42YaoU6wtJm6/8rb5YXLDmE0P39C8JyutkVBU1FshoAolzLaEYxRv1EeS726fxBlTjqvZIrtE4V7kAnA0lqhf3SYJDzvdGlvsPmFeFWUQJLFF55SX5JWkkaPG6QOVbX8GTSHOetG4vmdZedyEiW5tO6PX7bCwn8bQ/SUAEsCiSmH6bnR1shqf0YTZp8dRdziYYOEd/E5YvCTQHKwx8E/LEd084Wt5Q64yqzZ9umL5ZEdqZQy8y4Ut7/SG1UID4KVhzKEEgrPK8NRt3nIK5G+tBgCqkLGRInv2KogZaucmsOiaI2yxCoA== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM0PR08MB3809.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(366004)(39860400002)(136003)(33656002)(26005)(66946007)(478600001)(6486002)(6506007)(41300700001)(86362001)(54906003)(6916009)(2906002)(316002)(53546011)(4326008)(71200400001)(91956017)(38070700005)(6512007)(38100700002)(76116006)(186003)(36756003)(64756008)(122000001)(66556008)(5660300002)(66476007)(83380400001)(8676002)(66446008)(8936002)(2616005)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB5126 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: fa3692ad-c4be-4a1b-f8d9-08da70c4336c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gX04rDBjJe7rhaMUAW4kWpW9aofeL2ndyAb5429LJ6mtRE/cF5nL/tZvCmdHU2C2SZbx8AA9jK5laluHpkyDJrNAvi0lA4zdcIdOPvXjrIj8HEuQN/9TzkG8tHXQ89qtMyAoTsV2galzGZ8z05dgKSS2HnPqFwjaR8skM0kzZPw8Xvfgrn0rpVfba5O+wdFjvZfagN2djnBOixlvx6jN7Wrqf1a4Udd2lLyzCqT58LgMcEE8wASmPGGq3CpiC8Y1sb/rv5DKPXhCsbU33VYd2XfpUkyjIp5KTuM8Q4fYvSotHgYr4Q202KLa0gJf8vj91oCTQI5UMJ8mWyO+rbplp3hCw8DGt/sFG5Wl4xK+GPf1FbSiv5xleNrL7KX6uZOlfM0rx4D8nzEMtS/A4wzdDTgEG8ifrbbmkIzM3zKd9h+BFd5Cl+/Qq7rqdspNHVpo5Fmj1F7DAC8yZTxRmJYek18U5eyFTOEGDYwyZNj16e8ye7xVzcVX779lk9R01AnNs4qsIzxkDTMAcL0sYU+yoPjzWEfh7q2/f/pbJn+CiFTn0fpob2kG23KuLgN3pgYWmy6P8I5k3fNRmbUdC4MqCcXPU4q09R097PeakJBWm1qzHW7WCit3TnunRuibdaIo444UyQUp4w8/4rQZLetpO0rB5BVvp5Y5wBYWN/hzbLip5cWk7ZXR48DcjKYzy61BXWIXmMXZXpkdsE1I1jyILjNfbQO57sxqg/HTt64c31iCWj9GURrbNSv49fAjJ5oJuKmmxGtGawcOsW79UBxRdi/uWlNARou9rAuVSTAInwHarzbtRCH/wYgTrvI8ESjI X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(39860400002)(376002)(40470700004)(36840700001)(46966006)(8676002)(36860700001)(70586007)(2906002)(40480700001)(41300700001)(356005)(5660300002)(6512007)(26005)(82740400003)(33656002)(4326008)(478600001)(6862004)(6506007)(6486002)(336012)(83380400001)(107886003)(2616005)(86362001)(81166007)(316002)(82310400005)(47076005)(36756003)(54906003)(70206006)(186003)(53546011)(8936002)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 18:08:52.9269 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d52f1a2c-45d8-4690-4c05-08da70c43ade X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7553 DQoNCj4gT24gMjggSnVsIDIwMjIsIGF0IDE5OjA3LCBKdWxpZW4gR3JhbGwgPGp1bGllbkB4ZW4u b3JnPiB3cm90ZToNCj4gDQo+IEhpIEx1Y2EsDQo+IA0KPiBPbiAyNS8wNy8yMDIyIDE1OjQ2LCBM dWNhIEZhbmNlbGx1IHdyb3RlOg0KPj4gVGhlIGZ1bmN0aW9uIGFyY2hfc2V0X2luZm9fZ3Vlc3Qg aXMgbm90IHJlYWNoZWQgYW55bW9yZSB0aHJvdWdoDQo+PiBWQ1BVT1BfaW5pdGlhbGlzZSBvbiBh cm0sIHVwZGF0ZSB0aGUgY29tbWVudC4NCj4+IFNpZ25lZC1vZmYtYnk6IEx1Y2EgRmFuY2VsbHUg PGx1Y2EuZmFuY2VsbHVAYXJtLmNvbT4NCj4+IC0tLQ0KPj4geGVuL2FyY2gvYXJtL2RvbWFpbi5j IHwgNiArKystLS0NCj4+IDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pDQo+PiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gvYXJtL2RvbWFpbi5jIGIveGVuL2FyY2gv YXJtL2RvbWFpbi5jDQo+PiBpbmRleCAyZjhlYWFiN2I1NmIuLjY0NTFjZDAxM2MxYSAxMDA2NDQN Cj4+IC0tLSBhL3hlbi9hcmNoL2FybS9kb21haW4uYw0KPj4gKysrIGIveGVuL2FyY2gvYXJtL2Rv bWFpbi5jDQo+PiBAQCAtODgyLDkgKzg4Miw5IEBAIHN0YXRpYyBpbnQgaXNfZ3Vlc3RfcHY2NF9w c3IodWludDY0X3QgcHNyKQ0KPj4gI2VuZGlmDQo+PiAvKg0KPj4gLSAqIEluaXRpYWxpc2UgVkNQ VSBzdGF0ZS4gVGhlIGNvbnRleHQgY2FuIGJlIHN1cHBsaWVkIGJ5IGVpdGhlciB0aGUNCj4+IC0g KiB0b29sc3RhY2sgKFhFTl9ET01DVExfc2V0dmNwdWNvbnRleHQpIG9yIHRoZSBndWVzdA0KPj4g LSAqIChWQ1BVT1BfaW5pdGlhbGlzZSkgYW5kIHRoZXJlZm9yZSBtdXN0IGJlIHByb3Blcmx5IHZh bGlkYXRlZC4NCj4+ICsgKiBJbml0aWFsaXNlIFZDUFUgc3RhdGUuIFRoZSBjb250ZXh0IGNhbiBi ZSBzdXBwbGllZCBieSB0aGUgdG9vbHN0YWNrDQo+PiArICogKFhFTl9ET01DVExfc2V0dmNwdWNv bnRleHQpIGFuZCB0aGVyZWZvcmUgbXVzdCBiZSBwcm9wZXJseSB2YWxpZGF0ZWQsDQo+PiArICog b3IgYnkgUFNDSSBjYWxsIChQU0NJX2NwdV9vbikgaGFuZGxlZCBieSB2cHNjaSBtb2R1bGUuDQo+ PiAqLw0KPiANCj4gSSB3b3VsZCBwcmVmZXIgaWYgdGhlIGNvbW1lbnQgZG9lc24ndCBtZW50aW9u IHdobyBhcmUgdGhlIGNhbGxlcnMuIFNvIHRoZXJlIGFyZSBubyBuZWVkIHRvIG1vZGlmeSB0aGUg Y29tbWVudCB0aGUgbmV4dCB0aW1lIHdlIGFkZC9yZW1vdmUgYSBjYWxsZXIuIEhvdyBhYm91dCBz b21ldGhpbmcgbGlrZToNCj4gDQo+ICJJbml0aWFsaXNlIHZDUFUgc3RhdGUuIFRoZSBjb250ZXh0 IG1heSBiZSBzdXBwbGllZCBieSBhbiBleHRlcm5hbCBlbnRpdHksIHNvIHdlIG5lZWQgdG8gdmFs aWRhdGUgaXQiDQoNClNvdW5kcyBnb29kISBJ4oCZbGwgdXBkYXRlIGFuZCBwdXNoIGl0IHNvb24h DQoNCj4gDQo+IENoZWVycywNCj4gDQo+IC0tIA0KPiBKdWxpZW4gR3JhbGwNCg0K From xen-devel-bounces@lists.xenproject.org Thu Jul 28 18:28:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 18:28:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377024.610075 (Exim 4.92) (envelope-from ) id 1oH8FV-0007oa-3l; Thu, 28 Jul 2022 18:28:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377024.610075; Thu, 28 Jul 2022 18:28:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8FU-0007oT-W2; Thu, 28 Jul 2022 18:28:40 +0000 Received: by outflank-mailman (input) for mailman id 377024; Thu, 28 Jul 2022 18:28:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8FU-0007oN-IC for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 18:28:40 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8FT-0007OK-Si; Thu, 28 Jul 2022 18:28:39 +0000 Received: from 54-240-197-224.amazon.com ([54.240.197.224] helo=[10.7.237.22]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH8FT-00086J-MZ; Thu, 28 Jul 2022 18:28:39 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=j9M7dOjVlxxED1fDsnMvquPu6Q9kK6f74cRL1rPfzoY=; b=bmNzgApd1AgkNnFuR/DsxY1KYW wX2IopywkF8x/c4h52kE6EpMmGxqaQ5prfUIIVHlAXVnGfSVdQxz3oszQuctZlX2BnX/1HtmA6oma aFsJKBb9+fnYLPpjAw86XgnYS3sXgroADIDnX+PNwE2S9mSnLHBCNw4Sax8odXhiMF4o=; Message-ID: <15aebc64-aa2d-235c-fec0-e83b6fde3113@xen.org> Date: Thu, 28 Jul 2022 19:28:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration Content-Language: en-US To: Oleksandr Tyshchenko , xen-devel@lists.xenproject.org Cc: Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> <20220716163745.28712-1-olekstysh@gmail.com> From: Julien Grall In-Reply-To: <20220716163745.28712-1-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Oleksandr, On 16/07/2022 17:37, Oleksandr Tyshchenko wrote: > Changes V10.1 -> V11: > - Anthony already gave his Reviewed-by, I dropped it due to the changes > - George already gave his Acked-by, I dropped it due to the changes > - s/other/standalone for the backendtype As discussed with Andrew on IRC, the golang changes are autogenerated. So I have kept George's acked-by and committed the series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 18:47:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 18:47:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.376971.610097 (Exim 4.92) (envelope-from ) id 1oH8XK-0002GO-RT; Thu, 28 Jul 2022 18:47:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 376971.610097; Thu, 28 Jul 2022 18:47:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8XK-0002GH-OU; Thu, 28 Jul 2022 18:47:06 +0000 Received: by outflank-mailman (input) for mailman id 376971; Thu, 28 Jul 2022 17:20:58 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH7By-00077z-2l for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 17:20:58 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id a36a0206-0e99-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 19:20:56 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9441F612B2; Thu, 28 Jul 2022 17:20:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED372C43140; Thu, 28 Jul 2022 17:20:53 +0000 (UTC) Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 9739D5C0B3E; Thu, 28 Jul 2022 10:20:53 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a36a0206-0e99-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659028854; bh=3juGR+P+/PoNu1lEhZFgztJ6A9LmEO7Lb+rh9Y4NDdw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=Ajcg/8L4izAZKa2mPe4A6mwD2xhNPSF6zD8jqYYYRNqfhpnanJCwPLkeDTtzMAAXY M7oUXZ6CZuH31IjVxAqM2gRnsWZITNKb55wlZ5JnD/DUCRDg3UdeAIrzeX0lNHjHAR wzgi3C8wJdIpBMqt7sc3STjd7C0uykM6U86/xrKMdBkv3A6gpbtO4hXjJ5l+TjHaLy e4DKSoCgdb1tzebEFm0O9AJWb9AqCOKWaWW3sVozalRIPGLkf5E1tw9aRE4zu/+akq X3FcajNE+AfhyfG4rrsgNdfZt/xVPEzBnwFe9tFjDbwwql6CH8YXjM30w46DcxQYCb 8dZ4kaIUmww0Q== Date: Thu, 28 Jul 2022 10:20:53 -0700 From: "Paul E. McKenney" To: Michel Lespinasse Cc: Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220725194306.GA14746@lespinasse.org> On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > Xeons") wrecked intel_idle in two ways: > > > > - must not have tracing in idle functions > > - must return with IRQs disabled > > > > Additionally, it added a branch for no good reason. > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > Signed-off-by: Peter Zijlstra (Intel) > > After this change was introduced, I am seeing "WARNING: suspicious RCU > usage" when booting a kernel with debug options compiled in. Please > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > and is still present in v5.19-rc8. > > I'm not sure, is this too late to fix or revert in v5.19 final ? I finally got a chance to take a quick look at this. The rcu_eqs_exit() function is making a lockdep complaint about being invoked with interrupts enabled. This function is called from rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables interrupts before invoking rcu_eqs_exit(). The only other call to rcu_idle_exit() does not disable interrupts, but it is via rcu_user_exit(), which would be a very odd choice for cpuidle_enter_state(). It seems unlikely, but it might be that it is the use of local_irq_save() instead of raw_local_irq_save() within rcu_idle_exit() that is causing the trouble. If this is the case, then the commit shown below would help. Note that this commit removes the warning from lockdep, so it is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable equivalent debugging. Could you please try your test with the -rce commit shown below applied? Thanx, Paul ------------------------------------------------------------------------ commit ed4ae5eff4b38797607cbdd80da394149110fb37 Author: Paul E. McKenney Date: Tue May 17 21:00:04 2022 -0700 rcu: Apply noinstr to rcu_idle_enter() and rcu_idle_exit() This commit applies the "noinstr" tag to the rcu_idle_enter() and rcu_idle_exit() functions, which are invoked from portions of the idle loop that cannot be instrumented. These tags require reworking the rcu_eqs_enter() and rcu_eqs_exit() functions that these two functions invoke in order to cause them to use normal assertions rather than lockdep. In addition, within rcu_idle_exit(), the raw versions of local_irq_save() and local_irq_restore() are used, again to avoid issues with lockdep in uninstrumented code. This patch is based in part on an earlier patch by Jiri Olsa, discussions with Peter Zijlstra and Frederic Weisbecker, earlier changes by Thomas Gleixner, and off-list discussions with Yonghong Song. Link: https://lore.kernel.org/lkml/20220515203653.4039075-1-jolsa@kernel.org/ Reported-by: Jiri Olsa Reported-by: Alexei Starovoitov Reported-by: Andrii Nakryiko Signed-off-by: Paul E. McKenney Reviewed-by: Yonghong Song diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index c25ba442044a6..9a5edab5558c9 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -631,8 +631,8 @@ static noinstr void rcu_eqs_enter(bool user) return; } - lockdep_assert_irqs_disabled(); instrumentation_begin(); + lockdep_assert_irqs_disabled(); trace_rcu_dyntick(TPS("Start"), rdp->dynticks_nesting, 0, atomic_read(&rdp->dynticks)); WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !user && !is_idle_task(current)); rcu_preempt_deferred_qs(current); @@ -659,9 +659,9 @@ static noinstr void rcu_eqs_enter(bool user) * If you add or remove a call to rcu_idle_enter(), be sure to test with * CONFIG_RCU_EQS_DEBUG=y. */ -void rcu_idle_enter(void) +void noinstr rcu_idle_enter(void) { - lockdep_assert_irqs_disabled(); + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); rcu_eqs_enter(false); } EXPORT_SYMBOL_GPL(rcu_idle_enter); @@ -861,7 +861,7 @@ static void noinstr rcu_eqs_exit(bool user) struct rcu_data *rdp; long oldval; - lockdep_assert_irqs_disabled(); + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); rdp = this_cpu_ptr(&rcu_data); oldval = rdp->dynticks_nesting; WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && oldval < 0); @@ -896,13 +896,13 @@ static void noinstr rcu_eqs_exit(bool user) * If you add or remove a call to rcu_idle_exit(), be sure to test with * CONFIG_RCU_EQS_DEBUG=y. */ -void rcu_idle_exit(void) +void noinstr rcu_idle_exit(void) { unsigned long flags; - local_irq_save(flags); + raw_local_irq_save(flags); rcu_eqs_exit(false); - local_irq_restore(flags); + raw_local_irq_restore(flags); } EXPORT_SYMBOL_GPL(rcu_idle_exit); From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:00:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:00:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377040.610108 (Exim 4.92) (envelope-from ) id 1oH8k2-0004k3-0i; Thu, 28 Jul 2022 19:00:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377040.610108; Thu, 28 Jul 2022 19:00:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8k1-0004jw-UI; Thu, 28 Jul 2022 19:00:13 +0000 Received: by outflank-mailman (input) for mailman id 377040; Thu, 28 Jul 2022 19:00:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8k0-0004jq-DR for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 19:00:12 +0000 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [2607:f8b0:4864:20::432]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 80e5b8ba-0ea7-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 21:00:11 +0200 (CEST) Received: by mail-pf1-x432.google.com with SMTP id g12so2694012pfb.3 for ; Thu, 28 Jul 2022 12:00:11 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 80e5b8ba-0ea7-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=GSO0e+K/595xy9Bblk5pFyUK2CqoEV+q1TQVPsYLSZk=; b=XyG+Uu2v7ec9cgbFi6RizyeUBw6R9gIRURjVrQjXfJmUFP8mv5VHBKBSQssjTHqYDo ZkRFiq/DIm7dbIO0VJ4WXtfnAmLqx7lUQ9Nxl0rG0ycdGbzZ707FH5auak9yFpDowswf I070SNNnnfB9DL5aZr3fhHvIhWGow3w04uKKDKBFMcKsZpRgSlQ/qpD2ljCs5IWNFGet SZTlSPGycXimPM6mW5NvahZv1JDXDoPfd41csuoa5qHoA0IlTX/6LFoeMVMWBndDc1/y lK9y6uuMgJBEHfaOzLWWRWGC73urB5USsBoFJJDXIpjiaNykbPJyWJjK60pY1MfBWExe 99iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=GSO0e+K/595xy9Bblk5pFyUK2CqoEV+q1TQVPsYLSZk=; b=ZwlTIoKTLKc7nrG2FpzLGwj1XNH5xfI9NfTXKv/A0b1/8MUBpTE7SQoS5E1iV7nPWm 4+5Jhj+0oVEc7Qq9ru8cy4JNCyY/BYG3UMKbAP9ilVEB0KYcuWKh8I4Ho9aKmoleApkI rGOk7+NjlJd7UiftqHYMrRrQP8h23JdtFZ0E7jvAzyMnk3c8U98ZFbRWTBo43YTZXDcD ulw2X0heiHqq7Xzg+DA7wxdYGxH4FNFSHci/vc/38TO+itDdrx9WDjjHF1ZeQ3YuOABT Jc+C9Otdzf0iJAvL0WbeJNMVspGcMEWh4wlBy0NCeG2Jct+VA463VVrKc+A2cjdY+RWO oDeQ== X-Gm-Message-State: AJIora80j0ryPD4KXemDdf+XSh8c2aFTMD01qAHHSsQ6uYOuGs4xFQaM ow+Zu1UMhLvcepwNAPDP1SQ0tpDQD4lZ5ae7q7k= X-Google-Smtp-Source: AGRyM1si9Hsm9KLkrtmLWsEkTPmJF6TfVJs8WGCFRk+s/vbndn/gRzz98S+O+vLHJdO6MvLpQVtyCmgMGoxU1VSLBFI= X-Received: by 2002:a63:f74e:0:b0:41a:716c:bfc4 with SMTP id f14-20020a63f74e000000b0041a716cbfc4mr157561pgk.14.1659034809655; Thu, 28 Jul 2022 12:00:09 -0700 (PDT) MIME-Version: 1.0 References: <540d44a5-6966-a9d7-4e62-63ae845c6f62@epam.com> <20220716163745.28712-1-olekstysh@gmail.com> <15aebc64-aa2d-235c-fec0-e83b6fde3113@xen.org> In-Reply-To: <15aebc64-aa2d-235c-fec0-e83b6fde3113@xen.org> From: Oleksandr Tyshchenko Date: Thu, 28 Jul 2022 21:59:58 +0300 Message-ID: Subject: Re: [PATCH V11.1 1/3] libxl: Add support for Virtio disk configuration To: Julien Grall Cc: xen-devel , Oleksandr Tyshchenko , Wei Liu , Anthony PERARD , George Dunlap , Nick Rosbrook , Juergen Gross , Stefano Stabellini , Volodymyr Babchuk , Bertrand Marquis Content-Type: multipart/alternative; boundary="0000000000007fe7db05e4e224c4" --0000000000007fe7db05e4e224c4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =D1=87=D1=82, 28 =D0=B8=D1=8E=D0=BB. 2022 =D0=B3., 21:28 Julien Grall : > Hi Oleksandr, > Hello Julien (sorry for the possible format issues) > On 16/07/2022 17:37, Oleksandr Tyshchenko wrote: > > Changes V10.1 -> V11: > > - Anthony already gave his Reviewed-by, I dropped it due to the > changes > > - George already gave his Acked-by, I dropped it due to the changes > > - s/other/standalone for the backendtype > > As discussed with Andrew on IRC, the golang changes are autogenerated. > So I have kept George's acked-by and committed the series. > Thank you very much! > Cheers, > > -- > Julien Grall > --0000000000007fe7db05e4e224c4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=D1=87=D1=82, 28 =D0=B8=D1=8E=D0=BB. 2022 =D0=B3., 21:= 28 Julien Grall <julien@xen.org>= ;:
Hi Oleksandr,


Hello Julien

(= sorry for the possible format issues)


On 16/07/2022 17:37, Oleksandr Tyshchenko wrote:
> Changes V10.1 -> V11:
>=C2=A0 =C2=A0 =C2=A0- Anthony already gave his Reviewed-by, I dropped i= t due to the changes
>=C2=A0 =C2=A0 =C2=A0- George already gave his Acked-by, I dropped it du= e to the changes
>=C2=A0 =C2=A0 =C2=A0- s/other/standalone for the backendtype

As discussed with Andrew on IRC, the golang changes are autogenerated.
So I have kept George's acked-by and committed the series.


Thank you very much!


Cheers,

--
Julien Grall
--0000000000007fe7db05e4e224c4-- From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:05:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:05:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377047.610120 (Exim 4.92) (envelope-from ) id 1oH8pS-0005P9-Ma; Thu, 28 Jul 2022 19:05:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377047.610120; Thu, 28 Jul 2022 19:05:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8pS-0005P2-JG; Thu, 28 Jul 2022 19:05:50 +0000 Received: by outflank-mailman (input) for mailman id 377047; Thu, 28 Jul 2022 19:05:49 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8pR-0005Om-KB for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 19:05:49 +0000 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 487e18f5-0ea8-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 21:05:46 +0200 (CEST) Received: from DM6PR12MB4297.namprd12.prod.outlook.com (2603:10b6:5:211::20) by DM6PR12MB3817.namprd12.prod.outlook.com (2603:10b6:5:1c9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.21; Thu, 28 Jul 2022 19:05:40 +0000 Received: from DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814]) by DM6PR12MB4297.namprd12.prod.outlook.com ([fe80::d183:d8e4:a6a8:e814%8]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 19:05:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 487e18f5-0ea8-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mwaNKr1a8HYveb/XqBi9J+QtqBrfgTxTDHiswolocecVbdFqFGEGmfQr1NsD4z4boiZWIHnZrHeYS8aqPzKlszcAPPe17jKcCcIcXGqCP5P+vzqckan/EZs7NpOni5MeJ4CjY8CTZlsmT30fS8a06nFsHujVtKSdPGIGc7XrRRB6MDhm2+TZAr7b3C6ux2KLP9drkm6FtYSm8tp4e5+tvsaLQOmKDlvCIl7AsTLczTtkVKYbPNiJYoDN5PVOWoDSpHOvs5UJw5l/qggEENhCE2HY5JrZJI5AE7gjxfn6yg7fGr0HqbR0PCvcIxx1CejqugTcGeK7yhJ70FFj1wO0vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ff+N7hSU6Dd/VtQGiOoBD64v3o8nFJuj1lr92PWZNGk=; b=U9FLOAXKbtubRdP2pDFgyCF1Odyk4OtdlOL9v7lTi68XwNsiilIPS5ZtaaM4Cn1emlONU3YtGmKVLsBIv1wTxax0xUa6NcfI3+x6VrVAlnX9kwK+cq06tP3WLIDpyQT6GRgimbFrryx5YKn7sGolIVwen1PCYPHON4RidzUP0Dp2e4CrohmQot+32OQB/2sWRIW0n6bjh5OHJg4V6HrFhNoirclaIYL+zSyelPkpSwjNKLrqgHmZYiSSONu6yFu0k7FbCc0y4j3b3kK082TmvN+m7c9+MoPdxZaJymbHTLgRqUgNHt36ZackDXDrDb55nKbWKdXSpCfXexjfup7oJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ff+N7hSU6Dd/VtQGiOoBD64v3o8nFJuj1lr92PWZNGk=; b=p+DZTytO8m7ODzMG0RUrK5w3DJZr/B3U4vmda+hpU0RkpLHnsOQdXOIhhth0AaxvlHp8+g44wYFvXfO19VoIkcfzrN/pUQMFQeIbJeZKms9Ajibb1PP3FzxeV6hL5qa9Wg+LEuokQMC1BOONhsIQZFJo6IyINzfCqKTLkiR9IiE= From: "SHARMA, JYOTIRMOY" To: Christopher Clark CC: "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" Subject: RE: Enable audio virtualization in Xen Thread-Topic: Enable audio virtualization in Xen Thread-Index: AdigFizJpGeQu9pXSearK44pKRlEjgAVU4KAABr1NcAAd2JeQA== Date: Thu, 28 Jul 2022 19:05:40 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2022-07-28T19:05:38Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=fe043d7f-7e6e-4995-a203-34e5b5362b6a; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e0dd9d7-5828-47ab-5a0f-08da70cc29d6 x-ms-traffictypediagnostic: DM6PR12MB3817:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NxvPp3L6dK5rA2XeATKsym/L1iYzgXi+zFZMuLm+9xHykRMbueovqFcgRH3b7sYZBiWSpiOW48zuU71HyIWIIbZ6jLkYupxZ5dNplAwKc7D//GF49ZmXgQBJoPjOPWySswndZi6wyXxyEaHYLzKVC6sb+lrLbG16HTPmKvmrAo0HYwEukyyDNQIO+pUSCsfniRiNI5gH7WkUXeO3zqFYchT6jmuc+ns/YT5RtjlvWycsG5tVKJYbdSO68oU3JLe8jxlCAFJHCmAo7gOUPW1xWrRu7DMEdaVZgIzsLWB2vm+u0gk9vFnCwQV+44lIuOkqaaaJcdTHPygsC/SbNY+eUGHdhJ6iwGvwcLkJtJa+2Bx5wXHa1BITeaOudd+GNNzeMwzrZOqS7vMMY3QPOdgBpkpZNmGrRlpchpYAWgcM9wXLV9cR4ao3XmXL0YVYbxoQthOfuocKMdS+fOH81gmdVQzvk8tRyyksnMC92ffeUSUJFxUNdXSEN/Ht364aGTmPEDmd/PhrMtjGe+fBUYBx3l+kbC0heAFz3wx/ua6vWG7qsH4m/ZwEKV1Ga0+U92zQPvTNepZcYfLbDRIxK3+4ozcSHyLvjGz/QpgcZJE2osxXGGdMCUQdxuSgyTuHOVyI3cvLlfvrjORxUNzOJsSg9JKzgAb7esQuOUbsCv0ev6LbirwnYfzzcHNEwIVRCBDK1cNkqq1NI0nCHVo8cX2hyf1DEzVU/sf9Js4GK5yv8zNg1WiXAuECSpU/nSTpG19OngVvozZ8ryUHuxaz2s3PF/cqNYHnitSRzC4YSMd4Rrp3kFvQmEHGdVawzW14AbX/k3dcwAlnaP48CGMLBWw0xA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4297.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(136003)(39860400002)(396003)(376002)(366004)(346002)(66946007)(66556008)(33656002)(83380400001)(8676002)(186003)(4326008)(55016003)(66476007)(316002)(64756008)(71200400001)(66446008)(6916009)(76116006)(54906003)(26005)(86362001)(53546011)(55236004)(7696005)(5660300002)(9686003)(966005)(52536014)(8936002)(478600001)(38070700005)(2906002)(122000001)(38100700002)(6506007)(41300700001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?ZlJ4YjFkdHFWMUcyMU1vMllMQnZtaUl0ek1KOXRQSDVMTXFxSExYZ09xY2Iy?= =?utf-8?B?RUdISDV1TUtKNWMxVEtCZE9hNE91STA3QzlVbGhnQ29KREUyRytTYnBxbVNO?= =?utf-8?B?Ykl6OHZLT2JoYVVqZXoreXpjOUxrOTdzNzh2MFMwbytPeW40NFBTblVRU0pH?= =?utf-8?B?V0doS0N0MzdtVXFjRmhMR0xvQW03bEQ3Z2toM1NrdDJKMkU1SzdhWHFnaHZ6?= =?utf-8?B?dnNOSXplRGQrK0VKdXp1ZVlJSWtDeUFaOFZVVUtTRDJXaFdibXV0WnhKVzY2?= =?utf-8?B?SjdTUU9PSWpZd09leGtPblhRMTh6d1ZzSFBwYjhiRDk2bGYxbVo4bHVJeXZ4?= =?utf-8?B?MWJXTzJGU3Znb3Z5T1Y0MGp0d0Rja1FZN0xTSjVzd0M3OHphdlVKcW5YczV3?= =?utf-8?B?NDRKRlh5MUI2UTBIVXhEU09uUjh0akpPakVzUHdhVGJUUHNFbGViN09wQ2Fa?= =?utf-8?B?bTlCQVRMc3pyV0oxYWtzZFVJTUFTR0xYQ3N5S3NTY1NlZXQ2cFh3TVlNT29P?= =?utf-8?B?dkV1ZmpPTWdHR1pBZW1XSlI3bFBPa3dlU0lOSTJVY2UvOTIvWi9RWGlFZWsw?= =?utf-8?B?K2ZmTHBkQmRSRmNnMHhtSGVVWk5ERWxVZS9rcGlyUFp3M3BqR1Jkd2FzeDA2?= =?utf-8?B?STRtbnl4Um9NS1hTRG80K2lIcm11QXBWWTRQbytTV2VQVWkycHNEdWYwbmhu?= =?utf-8?B?RE9iREFZOTlPdWlvcVBUOTVxMVRPem1LVnR0dzlYOWJOVHQ3Z09ONlRaUmNO?= =?utf-8?B?Z25xK1J0RjJjNXdxSU84TkZrTnFMdXNRdzRCZVQ5YUtTUnIzRmpyRWgzUnpk?= =?utf-8?B?VjZQbExheXNWOGkzRzNhWHc2Rm5FVTBDNXJsSzBKeTdrdW5xZUp0and2cTRl?= =?utf-8?B?K3hrRU0xeTdmK0pONU9Xc0ROV291T1FOS3VOY29URWZWU1R1NDc5dlY1SUMv?= =?utf-8?B?QmhJM1JRK05hbkthQkp1SzJUTTVTQ0tqem4wUTJsT2FKUmwzSHdyalJCdHdv?= =?utf-8?B?OHA3bHZEZjBvOS9PMHU5a3RDWDRkNlBJV1FlVFhpTDI5NVVMQ0pud2xUZXFj?= =?utf-8?B?bVpNa2pqRlM1VVNtN1MxbElPTDFENW1mZkI2MUkrOWFiVWJSNlNmZm94MFAz?= =?utf-8?B?K3pGcHpFa2RYa1d0dk1TRnRKMjBZeTBQUVFaOCtqNkZ1OXdWUFJtbmJTYlpX?= =?utf-8?B?MmQxT1ljdzUzNC94YmZsdWlCWDJ6Z0pqYi9MYXp0cjFmc01teEVVTTZvK2cy?= =?utf-8?B?WGR4N0lpNzVaSGhEUHprSEZ4T3hYV25sQ0xBOTBIWGFSQW1zcHFpYW1QUVlx?= =?utf-8?B?YjFOQ3hjTlFzTytoSzZLdnNVWW92cXpDYndsdjhDd0JlbGpMWEhxL1QrbXRh?= =?utf-8?B?V1dlbFpnVnVvNFhxNFdsQURSY0poTDdzRFVqZHk4RUxZQmZqalBnTXFZMEh3?= =?utf-8?B?QXVHdi9ONVEzNXY4cUFIMHRyRnhmUS9UMGo0bTVXYWRTM1lSK2ZBK256Tzhv?= =?utf-8?B?MkdFaHo4TlVVV3RtUGN5d3NZNThDSVg3UHRGY0pZanJJSmZYbERSS28ydVln?= =?utf-8?B?eEVwTkt1bEpNY1lyQ1VBbXRmdzJpUUJPa2ZuZ1lkUlJGcHkyY1d0cWkrZUJl?= =?utf-8?B?ZE00aEx2WmNuV3dmcHdqM2ZwTGJzaXdqK3hob0g3UXRPeHZxaEZ1Wndqa2Q4?= =?utf-8?B?WXZPVjA2ZldGSEIxbmg1NDF4Z25mSVIrSjVOUktsMnRvVXQ4dnFGSEJqekk2?= =?utf-8?B?ZFp5cjZGM1BYTlQvSnVRRk1Tb21rZENNVUYzbi9zbmxnelcrV3A2MS9RWEZP?= =?utf-8?B?MjFEQlpzTGtvT1A0L1lCTE9BRDNmUmpSbUZYazh3L1E1c3prOHczUWFKckUz?= =?utf-8?B?ZEQwSTIvYlFqREFLc3ZzdEQ5THhvdTB1N042V2dzQ0N4ZmlFdTBKWVpmbEJW?= =?utf-8?B?V0t4RHc2TTY1bEhqOTd0MU1ZcW51ZjRyK0wrOE41QTUwb29pbW9OK0pTTll4?= =?utf-8?B?WVZUclREREUxVjBhOEJ5U0YvWG9GbDQwbVJFK1ZmSDNCdmxzU3dmK216MFVJ?= =?utf-8?B?QmthVkhtNEFRRHMzT1l0VmoyR3NqQzJzN1M5ODFFZVBOQ1U4Q3dJRDlkcWtI?= =?utf-8?Q?//Xs=3D?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4297.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e0dd9d7-5828-47ab-5a0f-08da70cc29d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2022 19:05:40.3586 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c0YepWLhFXyQzH6iLx5GgWS/ZmJCICh9oQwZ83zAb2vf2s60tx2DaZzGJPE5M81ycDSjA+sdkL4mY7rmK3yNfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3817 W0FNRCBPZmZpY2lhbCBVc2UgT25seSAtIEdlbmVyYWxdDQoNCkhpIGFsbCwNCg0KQ2FuIGFueW9u ZSBwbGVhc2UgaGVscCBoZXJlPyANCg0KQWxzbywgaG93IGNhbiBJIG1ha2UgdXNlIG9mIHRoZSB4 ZW4gZnJvbnQgZW5kIGRyaXZlcnMgaW4gYSBIVk0gZ3Vlc3Q/DQoNClJlZ2FyZHMsDQpKeW90aXJt b3kNCg0KLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCkZyb206IFNIQVJNQSwgSllPVElSTU9Z IA0KU2VudDogVHVlc2RheSwgSnVseSAyNiwgMjAyMiA0OjI3IFBNDQpUbzogQ2hyaXN0b3BoZXIg Q2xhcmsgPGNocmlzdG9waGVyLncuY2xhcmtAZ21haWwuY29tPg0KQ2M6IHhlbi1kZXZlbEBsaXN0 cy54ZW5wcm9qZWN0Lm9yZzsgeGVuLXVzZXJzQGxpc3RzLnhlbnByb2plY3Qub3JnDQpTdWJqZWN0 OiBSRTogRW5hYmxlIGF1ZGlvIHZpcnR1YWxpemF0aW9uIGluIFhlbg0KDQpbQU1EIE9mZmljaWFs IFVzZSBPbmx5IC0gR2VuZXJhbF0NCg0KSGkgQ2hyaXN0b3BoZXIsDQoNClRoYW5rIHlvdSBmb3Ig dGhlIHF1aWNrIHJlc3BvbnNlLiBQbGVhc2UgZmluZCBhbnN3ZXJzIGJlbG93Lg0KDQo+PiBEb2Vz IGF1ZGlvIHBsYXliYWNrIHdvcmsgT0sgZnJvbSB5b3VyIFVidW50dSBkb20wPw0KWWVzLg0KDQo+ PiBEbyB5b3Uga25vdyB3aGljaCB2ZXJzaW9uIG9mIFVidW50dSB5b3UgYXJlIHVzaW5nPyAoJ2Nh dCAvZXRjL2xzYi1yZWxlYXNlJykNClVidW50dSAyMi4wNCBMVFMuDQoNCj4+IERvIHlvdSBrbm93 IHdoaWNoIHZlcnNpb24gb2YgWGVuIHlvdSBhcmUgdXNpbmc/ICgneGwgaW5mbycgaW4gZG9tMCBz aG91bGQgaGVscCkNCjQuMTYuMi1wcmUuIA0KDQo+PiBEbyB5b3Uga25vdyB3aGljaCB2ZXJzaW9u IG9mIFFlbXUgeW91IGhhdmUgaW5zdGFsbGVkIGluIGRvbTA/DQpRRU1VIGVtdWxhdG9yIHZlcnNp b24gNi4xLjEuDQoNCj4+IERpZCB5b3UgYnVpbGQgYW5kIGluc3RhbGwgWGVuIGZyb20gc291cmNl IGNvZGUsIG9yIGFyZSB5b3UgdXNpbmcgYmluYXJ5IHBhY2thZ2VzIG9mIFhlbiBhbmQgaXRzIHRv b2xzPw0KV2UgYnVpbHQgYW5kIGluc3RhbGxlZCBYZW4gZnJvbSBzb3VyY2UgY29kZSAoZ2l0IGNs b25lIGh0dHBzOi8veGVuYml0cy54ZW4ub3JnL2dpdC1odHRwL3hlbi5naXQpLg0KDQo+PiBBcmUg eW91IHVzaW5nIHRoZSB4bCB0b29scywgb3IgbGlidmlydCB0b29scyBmb3IgY29uZmlndXJpbmcg YW5kIHJ1bm5pbmcgeW91ciBndWVzdD8gLS0gaWUuIGhvdyBkbyB5b3Ugc3RhcnQgeW91ciBkb21V IFZNPw0KV2UgYXJlIHVzaW5nIHhsIHRvb2xzIChzdWRvIHhsIC12IGNyZWF0ZSA8cGF0aCB0byBo dm0gY29uZmlnIGZpbGU+KS4NCg0KPj4gV2hlbiB5b3VyIGRvbVUgaXMgcnVubmluZywgcGxlYXNl IGNvdWxkIHlvdSBydW4gJ3BzIGF1eHd3dycgaW4gZG9tMCBhbmQgb2J0YWluIHRoZSBwcm9jZXNz IGluZm9ybWF0aW9uIGFib3V0IHRoZSBxZW11IGluc3RhbmNlIHRoYXQgaXMgcnVubmluZywgc28g dGhhdCB3ZSBjYW4gc2VlIHdoYXQgY29tbWFuZCBsaW5lIGFyZ3VtZW50cyBoYXZlIGJlZW4gc3Vw cGxpZWQgdG8gaXQNCg0KVGhpcyBpcyB0aGUgbG9nIHdlIGdldCByaWdodCBhZnRlciBib290aW5n IGRvbSAwOg0KDQpyb290IDcyMyAwLjAgMC4yIDI0Mzc5MiAxNDQ2OCA/IFNsIDE1OjUxIDA6MDAg L3Vzci9sb2NhbC9saWIveGVuL2Jpbi9xZW11LXN5c3RlbS1pMzg2IC14ZW4tZG9taWQgMCAteGVu LWF0dGFjaCAtbmFtZSBkb20wIC1ub2dyYXBoaWMgLU0geGVucHYgLWRhZW1vbml6ZSAtbW9uaXRv ciAvZGV2L251bGwgLXNlcmlhbCAvZGV2L251bGwgLXBhcmFsbGVsIC9kZXYvbnVsbCAtcGlkZmls ZSAvdmFyL3J1bi94ZW4vcWVtdS1kb20wLnBpZA0KDQpUaGlzIGxvZyBpcyBzZWVuIGFmdGVyIHdl IGxhdW5jaCBkb20gVSAoc3VkbyB4bCAtdiBjcmVhdGUgPHBhdGggdG8gaHZtIGNvbmZpZyBmaWxl Pik6DQoNCnJvb3QgMjE1MiAyMC43IDIuMyAyODU4MjA0IDEzMzQ5NiA/IFNzbCAxNTo1MyAwOjA5 IC91c3IvbG9jYWwvbGliL3hlbi9iaW4vcWVtdS1zeXN0ZW0taTM4NiAteGVuLWRvbWlkIDEgLW5v LXNodXRkb3duIC1jaGFyZGV2IHNvY2tldCxpZD1saWJ4bC1jbWQscGF0aD0vdmFyL3J1bi94ZW4v cW1wLWxpYnhsLTEsc2VydmVyPW9uLHdhaXQ9b2ZmIC1tb24gY2hhcmRldj1saWJ4bC1jbWQsbW9k ZT1jb250cm9sIC1jaGFyZGV2IHNvY2tldCxpZD1saWJ4ZW5zdGF0LWNtZCxwYXRoPS92YXIvcnVu L3hlbi9xbXAtbGlieGVuc3RhdC0xLHNlcnZlcj1vbix3YWl0PW9mZiAtbW9uIGNoYXJkZXY9bGli eGVuc3RhdC1jbWQsbW9kZT1jb250cm9sIC1ub2RlZmF1bHRzIC1uby11c2VyLWNvbmZpZyAtbmFt ZSBkb211LXVidW50dS5odm0gLXZuYyAxMjcuMC4wLjE6MCx0bz05OSAtZGlzcGxheSBzZGwsZ2w9 b24gLXNkbCAtZGV2aWNlIHZpcnRpby12Z2EtZ2wgLWJvb3Qgb3JkZXI9ZGMgLXVzYiAtdXNiZGV2 aWNlIHRhYmxldCAtc21wIDIsbWF4Y3B1cz0yIC1uZXQgbm9uZSAtbWFjaGluZSB4ZW5mdixzdXBw cmVzcy12bWRlc2M9b24gLW0gMjA0MCAtZHJpdmUgZmlsZT0vaG9tZS9hbWQvdTIwMDRfdWJ1bnR1 LnFjb3cyLGlmPWlkZSxpbmRleD0wLG1lZGlhPWRpc2ssZm9ybWF0PXFjb3cyLGNhY2hlPXdyaXRl YmFjaw0KDQo+PiBBIGxpdHRsZSBtb3JlIGluZm9ybWF0aW9uIGFib3V0IHdoYXQgeW91J3JlIHJ1 bm5pbmcgd2lsbCBoZWxwIHdpdGggcHJvdmlkaW5nIGd1aWRhbmNlIGhlcmUuIFRoZSB4bCBtYW4g cGFnZSBpbmRpY2F0ZXMgdGhhdCB0aGVyZSBpcyBhICJzb3VuZGh3IiBvcHRpb24gaW4gdGhlIFZN IGNvbmZpZ3VyYXRpb24gZmlsZSBmb3IgcGFzc2luZyBzb3VuZCBoYXJkd2FyZSBjb25maWd1dGlv biB0aHJvdWdoIHRvIHFlbXUsIHNvIGlmIHlvdSBhcmUgdXNpbmcgdGhlIHhsIHRvb2xzdGFjaywg eW91IGNvdWxkIHRyeSBhZGRpbmcgdGhpcyB0byB0aGUgY29uZmlnIGZpbGU6IHNvdW5kaHc9Imhk YSINCg0KSSB0cmllZCBnaXZpbmcgc291bmRodz0iaGRhIiBvcHRpb24gaW4gdGhlIGh2bSBjb25m aWcgZmlsZS4gSG93ZXZlciwgSSBkbyBub3QgaGVhciBhbnkgc291bmQgd2hlbiBJIHBsYXkgYSB3 YXZlIGZpbGUgaW4gZG9tIFUuIEhlcmUgaXMgdGhlICdwcyBhdXh3d3cnIG91dHB1dCBhZnRlciBt YWtpbmcgdGhpcyBjaGFuZ2U6DQoNCnJvb3QgMjU2OCAxNC44IDIuMyAyNzcwODY0IDEzNDcyMCA/ IFNzbCAxNTo1OCAwOjA5IC91c3IvbG9jYWwvbGliL3hlbi9iaW4vcWVtdS1zeXN0ZW0taTM4NiAt eGVuLWRvbWlkIDIgLW5vLXNodXRkb3duIC1jaGFyZGV2IHNvY2tldCxpZD1saWJ4bC1jbWQscGF0 aD0vdmFyL3J1bi94ZW4vcW1wLWxpYnhsLTIsc2VydmVyPW9uLHdhaXQ9b2ZmIC1tb24gY2hhcmRl dj1saWJ4bC1jbWQsbW9kZT1jb250cm9sIC1jaGFyZGV2IHNvY2tldCxpZD1saWJ4ZW5zdGF0LWNt ZCxwYXRoPS92YXIvcnVuL3hlbi9xbXAtbGlieGVuc3RhdC0yLHNlcnZlcj1vbix3YWl0PW9mZiAt bW9uIGNoYXJkZXY9bGlieGVuc3RhdC1jbWQsbW9kZT1jb250cm9sIC1ub2RlZmF1bHRzIC1uby11 c2VyLWNvbmZpZyAtbmFtZSBkb211LXVidW50dS1hdWRpby5odm0gLXZuYyAxMjcuMC4wLjE6MCx0 bz05OSAtZGlzcGxheSBzZGwsZ2w9b24gLXNkbCAtZGV2aWNlIHZpcnRpby12Z2EtZ2wgLWJvb3Qg b3JkZXI9ZGMgLXVzYiAtdXNiZGV2aWNlIHRhYmxldCAtc291bmRodyBoZGEgLXNtcCAyLG1heGNw dXM9MiAtbmV0IG5vbmUgLW1hY2hpbmUgeGVuZnYsc3VwcHJlc3Mtdm1kZXNjPW9uIC1tIDIwNDAg LWRyaXZlIGZpbGU9L2hvbWUvYW1kL3UyMDA0X3VidW50dS5xY293MixpZj1pZGUsaW5kZXg9MCxt ZWRpYT1kaXNrLGZvcm1hdD1xY293MixjYWNoZT13cml0ZWJhY2sNCg0KQWxzbywgSSB0cmllZCBn aXZpbmcgc291bmRodz0iYWxsIiBpbiB0aGUgY29uZmlnIGZpbGUsIGhvd2V2ZXIgdGhpcyB0aHJv d3MgZm9sbG93aW5nIGVycm9yOg0KDQpsaWJ4bDogZXJyb3I6IGxpYnhsX2RtLmM6MzEzMDpkZXZp Y2VfbW9kZWxfc3Bhd25fb3V0Y29tZTogRG9tYWluIDQ6ZG9tYWluIDQgZGV2aWNlIG1vZGVsOiBz cGF3biBmYWlsZWQgKHJjPS0zKQ0KbGlieGw6IGVycm9yOiBsaWJ4bF9kbS5jOjMzNTA6ZGV2aWNl X21vZGVsX3Bvc3Rjb25maWdfZG9uZTogRG9tYWluIDQ6UG9zdCBETSBzdGFydHVwIGNvbmZpZ3Mg ZmFpbGVkLCByYz0tMw0KbGlieGw6IGVycm9yOiBsaWJ4bF9jcmVhdGUuYzoxODY3OmRvbWNyZWF0 ZV9kZXZtb2RlbF9zdGFydGVkOiBEb21haW4gNDpkZXZpY2UgbW9kZWwgZGlkIG5vdCBzdGFydDog LTMNCmxpYnhsOiBlcnJvcjogbGlieGxfYW91dGlscy5jOjY0NjpsaWJ4bF9fa2lsbF94c19wYXRo OiBEZXZpY2UgTW9kZWwgYWxyZWFkeSBleGl0ZWQNCmxpYnhsOiBlcnJvcjogbGlieGxfZG9tYWlu LmM6MTE4MzpsaWJ4bF9fZGVzdHJveV9kb21pZDogRG9tYWluIDQ6Tm9uLWV4aXN0YW50IGRvbWFp bg0KbGlieGw6IGVycm9yOiBsaWJ4bF9kb21haW4uYzoxMTM3OmRvbWFpbl9kZXN0cm95X2NhbGxi YWNrOiBEb21haW4gNDpVbmFibGUgdG8gZGVzdHJveSBndWVzdA0KbGlieGw6IGVycm9yOiBsaWJ4 bF9kb21haW4uYzoxMDY0OmRvbWFpbl9kZXN0cm95X2NiOiBEb21haW4gNDpEZXN0cnVjdGlvbiBv ZiBkb21haW4gZmFpbGVkDQoNCkNhbiB5b3UgcGxlYXNlIGxldCBtZSBrbm93IHdoYXQgcGFyYW1l dGVycyBJIHNob3VsZCB1c2UgaW4gdGhlIGNvbmZpZyBmaWxlIHRvIHBsYXkgYXVkaW8gZnJvbSBk b20gVT8NCg0KUmVnYXJkcywNCkp5b3Rpcm1veQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0t LQ0KRnJvbTogQ2hyaXN0b3BoZXIgQ2xhcmsgPGNocmlzdG9waGVyLncuY2xhcmtAZ21haWwuY29t PiANClNlbnQ6IFR1ZXNkYXksIEp1bHkgMjYsIDIwMjIgMjo0NCBBTQ0KVG86IFNIQVJNQSwgSllP VElSTU9ZIDxKWU9USVJNT1kuU0hBUk1BQGFtZC5jb20+DQpDYzogeGVuLWRldmVsQGxpc3RzLnhl bnByb2plY3Qub3JnOyB4ZW4tdXNlcnNAbGlzdHMueGVucHJvamVjdC5vcmcNClN1YmplY3Q6IFJl OiBFbmFibGUgYXVkaW8gdmlydHVhbGl6YXRpb24gaW4gWGVuDQoNCltDQVVUSU9OOiBFeHRlcm5h bCBFbWFpbF0NCg0KT24gTW9uLCBKdWwgMjUsIDIwMjIgYXQgNDo0NSBBTSBTSEFSTUEsIEpZT1RJ Uk1PWSA8SllPVElSTU9ZLlNIQVJNQUBhbWQuY29tPiB3cm90ZToNCj4NCj4gW0FNRCBPZmZpY2lh bCBVc2UgT25seSAtIEdlbmVyYWxdDQo+DQo+DQo+IEhpIGFsbCwNCg0KSGkgSnlvdGlybW95LA0K DQpJIGhhdmUgYWRkIHRoZSB4ZW4tdXNlcnMgbGlzdCB0byBDQyBzaW5jZSB0aGlzIHRocmVhZCBt YXkgYmUgdXNlZnVsIHRvIHRoYXQgZm9ydW0uDQoNCj4gSSBhbSB1c2luZyB1YnVudHUgYXMgZG9t IDAgYW5kIGFsc28gZG9tIFUgKEhWTSkuIEkgd2FudCB0byBwbGF5IGF1ZGlvIGZyb20g4oCcZG9t IFXigJ0gVWJ1bnR1Lg0KDQpJIHRoaW5rIHRoYXQgaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGVu YWJsZSB3aGF0IHlvdSBhcmUgYXR0ZW1wdGluZyB0byBkby4gaWUuIGF1ZGlvIG91dHB1dCBmcm9t IGEgSFZNIFVidW50dSBndWVzdCBWTS4NCg0KU29tZSBxdWVzdGlvbnMgdG8gc3VwcG9ydCBhc3Np c3RpbmcgeW91Og0KKiBEb2VzIGF1ZGlvIHBsYXliYWNrIHdvcmsgT0sgZnJvbSB5b3VyIFVidW50 dSBkb20wPw0KKiBEbyB5b3Uga25vdyB3aGljaCB2ZXJzaW9uIG9mIFVidW50dSB5b3UgYXJlIHVz aW5nPyAoJ2NhdCAvZXRjL2xzYi1yZWxlYXNlJykNCiogRG8geW91IGtub3cgd2hpY2ggdmVyc2lv biBvZiBYZW4geW91IGFyZSB1c2luZz8gKCd4bCBpbmZvJyBpbiBkb20wIHNob3VsZCBoZWxwKQ0K KiBEbyB5b3Uga25vdyB3aGljaCB2ZXJzaW9uIG9mIFFlbXUgeW91IGhhdmUgaW5zdGFsbGVkIGlu IGRvbTA/DQoqIERpZCB5b3UgYnVpbGQgYW5kIGluc3RhbGwgWGVuIGZyb20gc291cmNlIGNvZGUs IG9yIGFyZSB5b3UgdXNpbmcgYmluYXJ5IHBhY2thZ2VzIG9mIFhlbiBhbmQgaXRzIHRvb2xzPw0K KiBBcmUgeW91IHVzaW5nIHRoZSB4bCB0b29scywgb3IgbGlidmlydCB0b29scyBmb3IgY29uZmln dXJpbmcgYW5kIHJ1bm5pbmcgeW91ciBndWVzdD8gLS0gaWUuIGhvdyBkbyB5b3Ugc3RhcnQgeW91 ciBkb21VIFZNPw0KKiBXaGVuIHlvdXIgZG9tVSBpcyBydW5uaW5nLCBwbGVhc2UgY291bGQgeW91 IHJ1biAncHMgYXV4d3d3JyBpbiBkb20wIGFuZCBvYnRhaW4gdGhlIHByb2Nlc3MgaW5mb3JtYXRp b24gYWJvdXQgdGhlIHFlbXUgaW5zdGFuY2UgdGhhdCBpcyBydW5uaW5nLCBzbyB0aGF0IHdlIGNh biBzZWUgd2hhdCBjb21tYW5kIGxpbmUgYXJndW1lbnRzIGhhdmUgYmVlbiBzdXBwbGllZCB0byBp dA0KDQo+IEkgYW0gbmV3IHRvIFhlbi92aXJ0dWFsaXphdGlvbiBpbiBnZW5lcmFsLg0KDQpXZWxj b21lISA6LSkNCg0KPiBGcm9tIHZhcmlvdXMgcmVhZGluZyBJIHVuZGVyc3Rvb2QgdGhhdCBJIG5l ZWQgdG8gdGFrZSBmb2xsb3dpbmcgYXBwcm9hY2g6DQo+DQo+IDEuIFVzZSBYZW4gZnJvbnQgZW5k IEFMU0EgZHJpdmVyIGluIGRvbSBVDQoNCkknbSBub3QgY2VydGFpbiB0aGF0IHRoaXMgaXMgbmVj ZXNzYXJ5IGZvciB5b3VyIEhWTSBndWVzdC4gSW5zdGVhZCBvZiB1c2luZyB0aGUgWGVuIHBhcmF2 aXJ0dWFsaXplZCBhdWRpbyBwcm90b2NvbCwgUWVtdSBzaG91bGQgYmUgYWJsZSB0byBwcmVzZW50 IGFuIGVtdWxhdGVkIGF1ZGlvIGRldmljZSB0byB0aGUgSFZNIGd1ZXN0IGRvbVUsIGFuZCBhIHN0 YW5kYXJkIGF1ZGlvIGRyaXZlciAoaGRhIG9yIGFjOTcpIGluIGRvbVUgc2hvdWxkIHN1ZmZpY2Uu DQoNCj4gMi4gVXNlIFFlbXUgdG8gY29ubmVjdCB0byB0aGUgYmFja2VuZCBBTFNBIGRyaXZlciBp biBEb20gMA0KDQpJIHRoaW5rIGlmIFFlbXUgaXMgc3RhcnRlZCB3aXRoIHRoZSBjb3JyZWN0IGNv bW1hbmQgbGluZSBhcmd1bWVudHMsIGl0IHNob3VsZCBiZSBhYmxlIHRvIHBsYXkgc291bmQgb24g YmVoYWxmIG9mIHRoZSBndWVzdCwgaWYgc291bmQgaXMgY29ycmVjdGx5IGNvbmZpZ3VyZWQgYW5k IHdvcmtpbmcgaW4gZG9tMC4NCg0KPiBDYW4geW91IHBsZWFzZSBsZXQgbWUga25vdyBpZiB0aGlz IGFwcHJvYWNoIGlzIGZpbmU/IElmIHllcywgSSBoYXZlIGZvbGxvd2luZyBxdWVzdGlvbnM6DQo+ DQo+IDEuIERvIEkgbmVlZCB0byByZWNvbXBpbGUgVWJ1bnR1IHRvIHN1cHBvcnQgWGVuIGZyb250 IGVuZCBBTFNBIGRyaXZlcj8gT3Igd2lsbCBVYnVudHUgaXNvIGZpbGUgYWxyZWFkeSBoYXZlIGl0 IGVuYWJsZWQ/DQoNCkkgdGhpbmsgdGhlIGxhdHRlciwgdGhhdCB0aGUgVWJ1bnR1IGluc3RhbGxh dGlvbiBJU08gc2hvdWxkIGFscmVhZHkgY29udGFpbiBhIHN1aXRhYmxlIGF1ZGlvIGRldmljZSBk cml2ZXIgdGhhdCBpcyBjb21wYXRpYmxlIHdpdGggdGhlIHZpcnR1YWwgYXVkaW8gZGV2aWNlIHRo YXQgaXMgZW11bGF0ZWQgYnkgUWVtdS4NCg0KPiAyLiBIbyBkbyBJIGNvbmZpZ3VyZSBRZW11IHRv IGVuYWJsZSBiYWNrZW5kIGRyaXZlcj8NCg0KQSBsaXR0bGUgbW9yZSBpbmZvcm1hdGlvbiBhYm91 dCB3aGF0IHlvdSdyZSBydW5uaW5nIHdpbGwgaGVscCB3aXRoIHByb3ZpZGluZyBndWlkYW5jZSBo ZXJlLiBUaGUgeGwgbWFuIHBhZ2UgaW5kaWNhdGVzIHRoYXQgdGhlcmUgaXMgYSAic291bmRodyIg b3B0aW9uIGluIHRoZSBWTSBjb25maWd1cmF0aW9uIGZpbGUgZm9yIHBhc3Npbmcgc291bmQgaGFy ZHdhcmUgY29uZmlndXRpb24gdGhyb3VnaCB0byBxZW11LCBzbyBpZiB5b3UgYXJlIHVzaW5nIHRo ZSB4bCB0b29sc3RhY2ssIHlvdSBjb3VsZCB0cnkgYWRkaW5nIHRoaXMgdG8gdGhlIGNvbmZpZyBm aWxlOiBzb3VuZGh3PSJoZGEiDQoNCkNocmlzdG9waGVyDQo= From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:11:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:11:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377055.610131 (Exim 4.92) (envelope-from ) id 1oH8v6-00074V-Gc; Thu, 28 Jul 2022 19:11:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377055.610131; Thu, 28 Jul 2022 19:11:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8v6-00074O-C0; Thu, 28 Jul 2022 19:11:40 +0000 Received: by outflank-mailman (input) for mailman id 377055; Thu, 28 Jul 2022 19:11:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8v5-00074E-9W; Thu, 28 Jul 2022 19:11:39 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8v5-0008CL-6k; Thu, 28 Jul 2022 19:11:39 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8v4-0004rf-Nt; Thu, 28 Jul 2022 19:11:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oH8v4-00008i-NH; Thu, 28 Jul 2022 19:11:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=VU/VJctldTfUiVcDFFZhTwtaLmlGGXRzgYY09zM1/pk=; b=e56NzYnTFedJ8dZALnic5Fs/Fp uF6tkHCp0X0hBI/1Hjzowcsaba3TFNxFGhKMRIbZ4pwUmPeuZT3eUTZjxbOT49aEHEYyaTzy5Vfjx 8NuSCzeh5S96BtWQF3hvVePslFJI7s3PW//xeLfddQxHCBaPpcVJd6WTUDhIV3xavNC8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171898: all pass - PUSHED X-Osstest-Versions-This: ovmf=3eca64f157c340f9bbf552d89a69698a3090c080 X-Osstest-Versions-That: ovmf=0e7add1d75fc75762208af84579e6809589ea6e5 From: osstest service owner Date: Thu, 28 Jul 2022 19:11:38 +0000 flight 171898 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171898/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 3eca64f157c340f9bbf552d89a69698a3090c080 baseline version: ovmf 0e7add1d75fc75762208af84579e6809589ea6e5 Last test of basis 171894 2022-07-28 03:43:30 Z 0 days Testing same since 171898 2022-07-28 17:13:05 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0e7add1d75..3eca64f157 3eca64f157c340f9bbf552d89a69698a3090c080 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:15:27 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:15:27 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377062.610142 (Exim 4.92) (envelope-from ) id 1oH8yl-0007fw-0s; Thu, 28 Jul 2022 19:15:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377062.610142; Thu, 28 Jul 2022 19:15:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8yk-0007fp-UH; Thu, 28 Jul 2022 19:15:26 +0000 Received: by outflank-mailman (input) for mailman id 377062; Thu, 28 Jul 2022 19:15:25 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8yj-0007fj-Nr for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 19:15:25 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH8yi-0008Ge-QM; Thu, 28 Jul 2022 19:15:24 +0000 Received: from [54.239.6.189] (helo=[192.168.25.182]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH8yi-0002IT-Ia; Thu, 28 Jul 2022 19:15:24 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=6UT7bCaYzyGCe0MEDUH/ypta6gAQtL5TSOWu4dfV2Ug=; b=DPD287kUs48gpxP8wxTDU7qbVv Q/rtFMC4OGkAwldP6jdMeCuFstDxGS5m1mG/p3U43u1Y8k/Y9yxSlGCnpszSo8Ob15rvHXYdi60wW /deEidMyv21Tawb5Ek+c/Tfmg3GVKgmtdALX8hH2jGI8Dd8i1B50xLIDeRT8+jIVPvps=; Message-ID: <307cef37-e48f-e66f-3550-85c0c50cbb7e@xen.org> Date: Thu, 28 Jul 2022 20:15:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Jens Wiklander Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> Content-Language: en-US From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 26/07/2022 07:17, Jens Wiklander wrote: > On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: >> >> Hi Jens, >> >> I haven't checked whether the FFA driver is complaint with the spec. I >> mainly checked whether the code makes sense from Xen PoV. >> >> This is a fairly long patch to review. So I will split my review in >> multiple session/e-mail. >> >> On 22/06/2022 14:42, Jens Wiklander wrote: >>> Adds a FF-A version 1.1 [1] mediator to communicate with a Secure >>> Partition in secure world. >>> >>> The implementation is the bare minimum to be able to communicate with >>> OP-TEE running as an SPMC at S-EL1. >>> >>> This is loosely based on the TEE mediator framework and the OP-TEE >>> mediator. >>> >>> [1] https://developer.arm.com/documentation/den0077/latest >>> Signed-off-by: Jens Wiklander >>> --- >>> SUPPORT.md | 7 + >>> tools/libs/light/libxl_arm.c | 3 + >>> tools/libs/light/libxl_types.idl | 1 + >>> tools/xl/xl_parse.c | 3 + >> >> These changes would need an ack from the toolstack maintainers. > > OK, I'll keep them in CC. > >> >>> xen/arch/arm/Kconfig | 11 + >>> xen/arch/arm/Makefile | 1 + >>> xen/arch/arm/domain.c | 10 + >>> xen/arch/arm/domain_build.c | 1 + >>> xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ >>> xen/arch/arm/include/asm/domain.h | 4 + >>> xen/arch/arm/include/asm/ffa.h | 71 ++ >>> xen/arch/arm/vsmc.c | 17 +- >>> xen/include/public/arch-arm.h | 2 + >>> 13 files changed, 1811 insertions(+), 3 deletions(-) >>> create mode 100644 xen/arch/arm/ffa.c >>> create mode 100644 xen/arch/arm/include/asm/ffa.h >>> >>> diff --git a/SUPPORT.md b/SUPPORT.md >>> index 70e98964cbc0..215bb3c9043b 100644 >>> --- a/SUPPORT.md >>> +++ b/SUPPORT.md >>> @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. >>> >>> No support for QEMU backends in a 16K or 64K domain. >>> >>> +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator >>> + >>> + Status, Arm64: Tech Preview >>> + >>> +There are still some code paths where a vCPU may hog a pCPU longer than >>> +necessary. The FF-A mediator is not yet implemented for Arm32. >>> + >>> ### ARM: Guest Device Tree support >>> >>> Status: Supported >>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c >>> index eef1de093914..a985609861c7 100644 >>> --- a/tools/libs/light/libxl_arm.c >>> +++ b/tools/libs/light/libxl_arm.c >>> @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, >>> return ERROR_FAIL; >>> } >>> >>> + config->arch.ffa_enabled = >>> + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); >>> + >>> return 0; >>> } >>> >>> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl >>> index 2a42da2f7d78..bf4544bef399 100644 >>> --- a/tools/libs/light/libxl_types.idl >>> +++ b/tools/libs/light/libxl_types.idl >>> @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ >>> >>> ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), >>> ("vuart", libxl_vuart_type), >>> + ("ffa_enabled", libxl_defbool), >> >> This needs to be accompagnied with a define LIBXL_HAVE_* in >> tools/include/libxl.h. Please see the examples in the header. > > OK, I'll add something. I'm not entirely sure how this is used so I'm > afraid it will be a bit of Cargo Cult programming from my side. The LIBXL_HAVE* by toolstack built on top of libxl (like virtio) to know whether a future is supported by the current library. [...] >> >>> + >>> +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) >>> +{ >>> + return (uint64_t)reg0 << 32 | reg1; >>> +} >>> + >>> +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, >>> + uint64_t val) >>> +{ >>> + *reg0 = val >> 32; >>> + *reg1 = val; >>> +} >> >> Those two functions are the same as optee.c but with a different. I >> would rather prefer if we avoid the duplication and provide generic >> helpers in a pre-requisite. > > These functions are trivial but at the same time for a special purpose > which happens to coincide with the usage in optee.c. I can't find a > suitable common .h file and creating a new one seems a bit much. I would implement it in regs.h. [...] >>> + .a4 = pg_count, >>> + }; >>> + struct arm_smccc_1_2_regs resp; >>> + >>> + /* >>> + * For arm64 we must use 64-bit calling convention if the buffer isn't >>> + * passed in our tx buffer. >>> + */ >> >> Can you explain why we would want to use the 32-bit calling convention >> if addr is 0? > > I was trying to avoid the 64-bit calling convention where possible, OOI, why are you trying to avoid the 64-bit calling convention? [...] -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:41:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:41:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377070.610153 (Exim 4.92) (envelope-from ) id 1oH9Na-00034N-4O; Thu, 28 Jul 2022 19:41:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377070.610153; Thu, 28 Jul 2022 19:41:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9Na-00034G-0d; Thu, 28 Jul 2022 19:41:06 +0000 Received: by outflank-mailman (input) for mailman id 377070; Thu, 28 Jul 2022 19:41:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9NY-00034A-Eq for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 19:41:04 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9NY-0000Gc-3x; Thu, 28 Jul 2022 19:41:04 +0000 Received: from [54.239.6.189] (helo=[192.168.25.182]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oH9NX-0003RB-Tc; Thu, 28 Jul 2022 19:41:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=YWYNBbIOvApdZ6sjCCeZTSPgbgncP8nHDwNGQ/Ukemg=; b=c+2RWHZcMEvKCnwGx2SRZwJaDJ 6NlPLhqe/rFIn6BJCYvG3lXm+IYQQDMkC+Q7e9oDS6SCo6tZpVNn7juX+G+zZpxXOUrxir+UQ64yq E0b5mnVwL8PMM3QkPiw6hUEuQtONLL4ZHEcxjyk4HAQkDWOo0nAMsFlzMlTc+q1KjB5A=; Message-ID: <2444aee6-13b6-a208-d6ba-89c42b43315e@xen.org> Date: Thu, 28 Jul 2022 20:41:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator Content-Language: en-US To: Jens Wiklander Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 27/07/2022 07:33, Jens Wiklander wrote: > On Fri, Jul 8, 2022 at 9:54 PM Julien Grall wrote: >>> + unsigned int n; >>> + unsigned int m; >>> + p2m_type_t t; >>> + uint64_t addr; >>> + >>> + for ( n = 0; n < range_count; n++ ) >>> + { >>> + for ( m = 0; m < range[n].page_count; m++ ) >>> + { >>> + if ( pg_idx >= shm->page_count ) >>> + return FFA_RET_INVALID_PARAMETERS; >> >> Shouldn't we call put_page() to drop the references taken by >> get_page_from_gfn()? > > Yes, and that's done by put_shm_pages(). One would normally expect > get_shm_pages() to do this on error, but that's not needed here since > we're always calling put_shm_pages() just before freeing the shm. I > can change to let get_shm_pages() do the cleanup on error instead if > you prefer that. I am fine with the current approach. I would suggest to document it on top of get_shm_pages(). Also, if you expect put_shm_pages() to always be called before freeing shm, then I think it would be worth adding an helper that is doing the two. So the requirement is clearer. [...] >> >> How do you guarantee that both Xen and the domain agree on the page size? > > For now, I'll add a BUILD_BUG_ON() to check that the hypervisor page > size is 4K to simplify the initial implementation. We can update to > support a larger minimal memory granule later on. I am fine with that. FWIW, this is also what we did in the OP-TEE case. >>> + for ( n = 1; n < shm->page_count; last_pa = pa, n++ ) >>> + { >>> + pa = page_to_maddr(shm->pages[n]); >>> + if ( last_pa + PAGE_SIZE == pa ) >>> + { >> >> Coding style: We usually avoid {} for single line. > > OK > >> >>> + continue; >>> + } >>> + region_descr->address_range_count++; >>> + } >>> + >>> + tot_len = sizeof(*descr) + sizeof(*mem_access_array) + >>> + sizeof(*region_descr) + >>> + region_descr->address_range_count * sizeof(*addr_range); >> >> How do you make sure that you will not write past the end of ffa_tx? >> >> I think it would be worth to consider adding an helper that would allow >> you to allocate space in ffa_tx and zero it. This would return an error >> if there is not enough space. > > That's what I'm doing with frag_len. If the descriptor cannot fit it's > divided into fragments that will fit. Oh, so this is what the loop below is for, am I correct? If so, I would suggest to document a bit the code because this function is fairly confusing to understand. [...] >>> + if ( read_atomic(&mem_access->access_perm.perm) != FFA_MEM_ACC_RW ) >>> + { >>> + ret = FFA_RET_NOT_SUPPORTED; >>> + goto out_unlock; >>> + } >>> + >>> + region_offs = read_atomic(&mem_access->region_offs); >>> + if ( sizeof(*region_descr) + region_offs > frag_len ) >>> + { >>> + ret = FFA_RET_NOT_SUPPORTED; >>> + goto out_unlock; >>> + } >>> + >>> + region_descr = (void *)((vaddr_t)ctx->tx + region_offs); >>> + range_count = read_atomic(®ion_descr->address_range_count); >>> + page_count = read_atomic(®ion_descr->total_page_count); >>> + >>> + shm = xzalloc_flex_struct(struct ffa_shm_mem, pages, page_count) >> This will allow a guest to allocate an arbitrarily large array in Xen. >> So please sanitize page_count before using it. > > This is tricky, what is a reasonable limit? Indeed. We need a limit that will prevent an untrusted domain to DoS Xen and at the same doesn't prevent the majority of well-behave domain to function. How is this call going to be used? > If we do set a limit the > guest can still share many separate memory ranges. This would also need to be limited if there is a desire to support untrusted domain. [...] >>> + ret = get_shm_pages(d, shm, region_descr->address_range_array, range_count, >>> + 0, &last_page_idx); >>> + if ( ret ) >>> + goto out; >>> + if ( last_page_idx != shm->page_count ) >>> + { >>> + ret = FFA_RET_INVALID_PARAMETERS; >>> + goto out; >>> + } >>> + >>> + /* Note that share_shm() uses our tx buffer */ >>> + spin_lock(&ffa_buffer_lock); >>> + ret = share_shm(shm); >>> + spin_unlock(&ffa_buffer_lock); >>> + if ( ret ) >>> + goto out; >>> + >>> + spin_lock(&ffa_mem_list_lock); >>> + list_add_tail(&shm->list, &ffa_mem_list); >> >> A couple of questions: >> - What is the maximum size of the list? > > Currently, there is no limit. I'm not sure what is a reasonable limit > more than five for sure, but depending on the use case more than 100 > might be excessive. This is fine to be excessive so long it doesn't allow a guest to drive Xen out of memory or allow long running operations. As I wrote above, the idea is we need limits that protect Xen but at the same time doesn't prevent the majority well-behave guest to function. As this is a tech preview, the limits can be low. We can raise the limits as we get a better understanding how this will be used. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:47:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:47:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377076.610163 (Exim 4.92) (envelope-from ) id 1oH9Tt-0003u4-PK; Thu, 28 Jul 2022 19:47:37 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377076.610163; Thu, 28 Jul 2022 19:47:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9Tt-0003tx-Mh; Thu, 28 Jul 2022 19:47:37 +0000 Received: by outflank-mailman (input) for mailman id 377076; Thu, 28 Jul 2022 19:47:35 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9Tr-0003tn-RF; Thu, 28 Jul 2022 19:47:35 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9Tr-0000NU-OW; Thu, 28 Jul 2022 19:47:35 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9Tr-0005hV-B9; Thu, 28 Jul 2022 19:47:35 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oH9Tr-00085Y-Ah; Thu, 28 Jul 2022 19:47:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GQTg5I2vAuj+hbasDsmJhMPaFURJIpzHip1pS8lfL8g=; b=F0BDBYpt+NvsuBY7ws30fi2g1M gyfoNsLna4XEid2kD0R335I1EWaE1Wr/sO4tD3RYDdysuGOZb/ftMr3Jv6Y2Soa5hT/9MgvaKEHgv OIBnewAX3CKX0Wae7BOLRA2pb53Zkq77jVaEhJSJNnIsyTQM0F/KTSg8tx5+x799wB3w=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171897: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3e4abe2c92964aadd35344a635b0f32cb487fd5c X-Osstest-Versions-That: qemuu=7b17a1a841fc2336eba53afade9cadb14bd3dd9a From: osstest service owner Date: Thu, 28 Jul 2022 19:47:35 +0000 flight 171897 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171897/ Failures :-/ but no regressions. Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171885 Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171885 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171885 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171885 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171885 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171885 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171885 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171885 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171885 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 3e4abe2c92964aadd35344a635b0f32cb487fd5c baseline version: qemuu 7b17a1a841fc2336eba53afade9cadb14bd3dd9a Last test of basis 171885 2022-07-27 12:04:19 Z 1 days Testing same since 171897 2022-07-28 12:08:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Hanna Reitz Richard Henderson Vladimir Sementsov-Ogievskiy jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 7b17a1a841..3e4abe2c92 3e4abe2c92964aadd35344a635b0f32cb487fd5c -> upstream-tested From xen-devel-bounces@lists.xenproject.org Thu Jul 28 19:55:20 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 19:55:20 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377085.610174 (Exim 4.92) (envelope-from ) id 1oH9bG-0005O9-LN; Thu, 28 Jul 2022 19:55:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377085.610174; Thu, 28 Jul 2022 19:55:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9bG-0005O2-Io; Thu, 28 Jul 2022 19:55:14 +0000 Received: by outflank-mailman (input) for mailman id 377085; Thu, 28 Jul 2022 19:55:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9bF-0005Nw-LN for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 19:55:13 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 30cd7ab9-0eaf-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 21:55:12 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3B995B82536; Thu, 28 Jul 2022 19:55:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21030C433C1; Thu, 28 Jul 2022 19:55:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30cd7ab9-0eaf-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659038109; bh=LL9v7BetyvBkSEdx6SYnL5aAMDXNKn+AlWrMlfFRQwE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=osMkBos2wP5U5GINtl6d1bK3i1taRYs+WbYcg+cGJigf4wriTIREHu3et8qMLixWn ICLZ0MkmGqDCXsRQtV2Xan6cEGLk0r7X8O//OMnHxKt18WcLKtgBbOD1W7bwCKCEJA 0iioRR98c1CzXeS+Aqb9E9qI9Q8c1e8llo4hCtvlqb0pJLu87bFe7kzgeGBc20R6an DH/5y+VzJbI1VPAH3hyejzJBu0MaY/abuSSau7SNlN4B3AZyVNaUg+cHPtMdC8LEOk APp30d/jlZ53JYytsukAYjUgcngnve5duYhhnnIugeBji7m4L4k4QtNakq9XEmW2d6 kyLjhCxsE2W5Q== Date: Thu, 28 Jul 2022 12:55:06 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Jan Beulich cc: boyoun.park@samsung.com, "sstabellini@kernel.org" , "julien@xen.org" , "bertrand.marquis@arm.com" , "Volodymyr_Babchuk@epam.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "wl@xen.org" , "roger.pau@citrix.com" , Chungwoo Park , SoungKwan Kimn , DongJin PARK , Gang Li , Lei Wang , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v1] xen: add late init call in start_xen In-Reply-To: <88025800-66e2-4fb4-facf-5989e75ba08f@suse.com> Message-ID: References: <97499212.9948800.1659000157467@mail-kr2-3> <88025800-66e2-4fb4-facf-5989e75ba08f@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Boyoun, Thanks for your interest in Xen and thanks for your contribution! On Thu, 28 Jul 2022, Jan Beulich wrote: > On 28.07.2022 11:22, Boyoun Park wrote: > > Hello, > > > > This patch added late_initcall to deal with > > > > some init functions which should be called > > > > after other init functions in start_xen. > > > > If this patch is added, > > > > then the original initcall in xen will be treated > > > > as early_initcall and the late_initcall > > > > which is added by this patch will be > > > > called sequentially. > > > > I cannot send patches through git send-email > > > > due to some security issues in my work. > > > > So intead, I just send the patches manually. > > Which is fine, but you want to configure your mail client such that it > doesn't mangle the patch. Albeit I see that to cover for that at least > you've also attached both the patch and a cover letter. For a single > patch a cover letter can normally be omitted, but if you don't then > even if you're sending without "git send-email" you will want to send > both as separate mails, with the patch being a reply to the cover > letter thread root. Yeah. Boyoun, if you only have a couple of patches then it is fine to send them manually. Otherwise, if you have many patches, you can send them in attachment as tarball and I'll send them all to xen-devel using git-send-email for you (of course keeping you as original author and retaining all Signed-off-bys). > > Subject: [PATCH v1] xen: add late init call in start_xen > > > > This patch added late_initcall section in init.data. > > > > The late initcall would be called after initcall > > > > in the start_xen function. > > > > Some initializing works on priority should be run > > > > in do_initcalls and other non-prioritized works > > > > would be run in do_late_initcalls. > > > > To call some functions by late_initcall, > > > > then it is possible by using > > > > __late_initcall(/*Function Name*/); > > > > Signed-off-by: Boyoun Park > > So I could imagine this patch to be in a series where a subsequent > patch then adds an actual use of the new functionality. Without > that what you're proposing is to add dead code. Yeah, I think it would be cool to have late initcalls but it makes sense to add them if we have someone that makes use of them. From xen-devel-bounces@lists.xenproject.org Thu Jul 28 20:14:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 20:14:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377148.610222 (Exim 4.92) (envelope-from ) id 1oH9ti-0001r8-0n; Thu, 28 Jul 2022 20:14:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377148.610222; Thu, 28 Jul 2022 20:14:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9th-0001r1-Td; Thu, 28 Jul 2022 20:14:17 +0000 Received: by outflank-mailman (input) for mailman id 377148; Thu, 28 Jul 2022 20:14:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oH9tg-0001qv-Rn for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 20:14:17 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id d93b7550-0eb1-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 22:14:13 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 12BB5B82534; Thu, 28 Jul 2022 20:14:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA725C433C1; Thu, 28 Jul 2022 20:14:08 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: d93b7550-0eb1-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659039249; bh=dPFRzQeF1c7iJ3EfHXbehjmCl4G8EvDiObYeLavO3WM=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=jGpJecZ6exQ8kwlMz03/cA+c3jtTOrEAX41j9V+VHZJQtkWnFs67Cww5Kn/WJB0am xh9vhQPDW1xA1obRn+BFQHKZCP6nF1ncDcwpUkZsto3S3YSeVMtLd8DgOZPpPCvIFv qDwZYZFc5XhRPODwRMTESuHx6U7JhOQzLmv66Pj6HqohoGN33K5dsAycsdFHGtHJ3J u8C56/K/R3RdCVWFdupBbJT5wqcgfT5l297UAhtCh7CjYmpfLTYVydyjlWkv8h0YaH xVMf5/5GO3t1AApKhFzu1QwwK0cdNZx+Z2bXjE3aqEULWmX4QcdICE8YrmApGugAKu PekPOgkfKugvw== Date: Thu, 28 Jul 2022 13:14:07 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Wei Chen cc: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Stefano Stabellini , Bertrand Marquis , Penny Zheng Subject: Re: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1) In-Reply-To: Message-ID: References: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Hi Wei, I am really sorry I didn't manage to read this proposal before now. Too many things :-) Is it still valid? Do you want me to read it in the next days, or do you have another update you would rather send first? Cheers, Stefano On Sun, 8 May 2022, Wei Chen wrote: > # Proposal for Porting Xen to Armv8-R64 > > (Update to Draft-C as a discussion archive for Day1 patches) > > This proposal will introduce the PoC work of porting Xen to Armv8-R64, > which includes: > - The changes of current Xen capability, like Xen build system, memory > management, domain management, vCPU context switch. > - The expanded Xen capability, like static-allocation and direct-map. > > ***Notes:*** > 1. ***This proposal only covers the work of porting Xen to Armv8-R64*** > ***single CPU.Xen SMP support on Armv8-R64 relates to Armv8-R*** > ***Trusted-Frimware (TF-R). This is an external dependency,*** > ***so we think the discussion of Xen SMP support on Armv8-R64*** > ***should be started when single-CPU support is complete.*** > 2. ***This proposal will not touch xen-tools. In current stange,*** > ***Xen on Armv8-R64 only support dom0less, all guests should*** > ***be booted from device tree.*** > > ## Changelogs > Draft-B -> Draft-C: > 1. Update the event-channel support section to use runtime > MPU mapping instead of whole MPU context switch. > 2. Split two stages for Armv8-R64 Xen start address solution. > 3. Remove "malicious tools". > 4. Remove GCC version bump. > > Draft-A -> Draft-B: > 1. Update Kconfig options usage. > 2. Update the section for XEN_START_ADDRESS. > 3. Add description of MPU initialization before parsing device tree. > 4. Remove CONFIG_ARM_MPU_EL1_PROTECTION_REGIONS. > 5. Update the description of ioremap_nocache/cache. > 6. Update about the free_init_memory on Armv8-R. > 7. Describe why we need to switch the MPU configuration later. > 8. Add alternative proposal in TODO. > 9. Add use tool to generate Xen Armv8-R device tree in TODO. > 10. Add Xen PIC/PIE discussion in TODO. > 11. Add Xen event channel support in TODO. > > ## Contributors: > Wei Chen > Penny Zheng > > ## 1. Essential Background > > ### 1.1. Armv8-R64 Profile > The Armv-R architecture profile was designed to support use cases that > have a high sensitivity to deterministic execution. (e.g. Fuel Injection, > Brake control, Drive trains, Motor control etc) > > Arm announced Armv8-R in 2013, it is the latest generation Arm architecture > targeted at the Real-time profile. It introduces virtualization at the highest > security level while retaining the Protected Memory System Architecture (PMSA) > based on a Memory Protection Unit (MPU). In 2020, Arm announced Cortex-R82, > which is the first Arm 64-bit Cortex-R processor based on Armv8-R64. > > - The latest Armv8-R64 document can be found here: > [Arm Architecture Reference Manual Supplement - Armv8, for Armv8-R AArch64 architecture profile](https://developer.arm.com/documentation/ddi0600/latest/). > > - Armv-R Architecture progression: > Armv7-R -> Armv8-R AArch32 -> Armv8 AArch64 > The following figure is a simple comparison of "R" processors based on > different Armv-R Architectures. > ![image](https://drive.google.com/uc?export=view&id=1nE5RAXaX8zY2KPZ8imBpbvIr2eqBguEB) > > - The Armv8-R architecture evolved additional features on top of Armv7-R: > - An exception model that is compatible with the Armv8-A model > - Virtualization with support for guest operating systems > - PMSA virtualization using MPUs In EL2. > - The new features of Armv8-R64 architecture > - Adds support for the 64-bit A64 instruction set, previously Armv8-R > only supported A32. > - Supports up to 48-bit physical addressing, previously up to 32-bit > addressing was supported. > - Optional Arm Neon technology and Advanced SIMD > - Supports three Exception Levels (ELs) > - Secure EL2 - The Highest Privilege, MPU only, for firmware, hypervisor > - Secure EL1 - RichOS (MMU) or RTOS (MPU) > - Secure EL0 - Application Workloads > - Optionally supports Virtual Memory System Architecture at S-EL1/S-EL0. > This means it's possible to run rich OS kernels - like Linux - either > bare-metal or as a guest. > - Differences with the Armv8-A AArch64 architecture > - Supports only a single Security state - Secure. There is not Non-Secure > execution state supported. > - EL3 is not supported, EL2 is mandatory. This means secure EL2 is the > highest EL. > - Supports the A64 ISA instruction > - With a small set of well-defined differences > - Provides a PMSA (Protected Memory System Architecture) based > virtualization model. > - As opposed to Armv8-A AArch64's VMSA based Virtualization > - Can support address bits up to 52 if FEAT_LPA is enabled, > otherwise 48 bits. > - Determines the access permissions and memory attributes of > the target PA. > - Can implement PMSAv8-64 at EL1 and EL2 > - Address translation flat-maps the VA to the PA for EL2 Stage 1. > - Address translation flat-maps the VA to the PA for EL1 Stage 1. > - Address translation flat-maps the IPA to the PA for EL1 Stage 2. > - PMSA in EL1 & EL2 is configurable, VMSA in EL1 is configurable. > > ### 1.2. Xen Challenges with PMSA Virtualization > Xen is PMSA unaware Type-1 Hypervisor, it will need modifications to run > with an MPU and host multiple guest OSes. > > - No MMU at EL2: > - No EL2 Stage 1 address translation > - Xen provides fixed ARM64 virtual memory layout as basis of EL2 > stage 1 address translation, which is not applicable on MPU system, > where there is no virtual addressing. As a result, any operation > involving transition from PA to VA, like ioremap, needs modification > on MPU system. > - Xen's run-time addresses are the same as the link time addresses. > - Enable PIC/PIE (position-independent code) on a real-time target > processor probably very rare. Further discussion in 2.1 and TODO > sections. > - Xen will need to use the EL2 MPU memory region descriptors to manage > access permissions and attributes for accesses made by VMs at EL1/0. > - Xen currently relies on MMU EL1 stage 2 table to manage these > accesses. > - No MMU Stage 2 translation at EL1: > - A guest doesn't have an independent guest physical address space > - A guest can not reuse the current Intermediate Physical Address > memory layout > - A guest uses physical addresses to access memory and devices > - The MPU at EL2 manages EL1 stage 2 access permissions and attributes > - There are a limited number of MPU protection regions at both EL2 and EL1: > - Architecturally, the maximum number of protection regions is 256, > typical implementations have 32. > - By contrast, Xen does not need to consider the number of page table > entries in theory when using MMU. > - The MPU protection regions at EL2 need to be shared between the hypervisor > and the guest stage 2. > - Requires careful consideration - may impact feature 'fullness' of both > the hypervisor and the guest > - By contrast, when using MMU, Xen has standalone P2M table for guest > stage 2 accesses. > > ## 2. Proposed changes of Xen > ### **2.1. Changes of build system:** > > - ***Introduce new Kconfig options for Armv8-R64***: > Unlike Armv8-A, because lack of MMU support on Armv8-R64, we may not > expect one Xen binary to run on all machines. Xen images are not common > across Armv8-R64 platforms. Xen must be re-built for different Armv8-R64 > platforms. Because these platforms may have different memory layout and > link address. > - `ARM64_V8R`: > This option enables Armv8-R profile for Arm64. Enabling this option > results in selecting MPU. This Kconfig option is used to gate some > Armv8-R64 specific code except MPU code, like some code for Armv8-R64 > only system ID registers access. > > - `ARM_MPU` > This option enables MPU on Armv8-R architecture. Enabling this option > results in disabling MMU. This Kconfig option is used to gate some > ARM_MPU specific code. Once when this Kconfig option has been enabled, > the MMU relate code will not be built for Armv8-R64. The reason why > not depends on runtime detection to select MMU or MPU is that, we don't > think we can use one image for both Armv8-R64 and Armv8-A64. Another > reason that we separate MPU and V8R in provision to allow to support MPU > on 32bit Arm one day. > > ***Try to use `if ( IS_ENABLED(CONFIG_ARMXXXX) )` instead of spreading*** > ***`#ifdef CONFIG_ARMXXXX` everywhere, if it is possible.*** > > - ***About Xen start address for Armv8-R64***: > On Armv8-A, Xen has a fixed virtual start address (link address too) on all > Armv8-A platforms. In an MMU based system, Xen can map its loaded address > to this virtual start address. On Armv8-A platforms, the Xen start address > does not need to be configurable. But on Armv8-R platforms, they don't have > MMU to map loaded address to a fixed virtual address. And different platforms > will have very different address space layout, so it's impossible for Xen to > specify a fixed physical address for all Armv8-R platforms' start address. > > - Stage 1, introduce `XEN_START_ADDRESS` > This option allows to set the custom address at which Xen will be > linked. This address must be aligned to a page size. Xen's run-time > addresses are the same as the link time addresses. > ***Notes: Fixed link address means the Xen binary could not be*** > ***relocated by EFI loader. So in current stage, Xen could not*** > ***be launched as an EFI application on Armv8-R64.(TODO#3.3)*** > > - Provided by platform files. > We can reuse the existed arm/platforms store platform specific files. > And `XEN_START_ADDRESS` is one kind of platform specific information. > So we can use platform file to define default `XEN_START_ADDRESS` for > each platform. > > - Provided by Kconfig. > This option can be a supplymental option. Users can define a customized > `XEN_START_ADDRESS` to override the default value in platform's file. > > - Stage 2, generated `XEN_START_ADDRESS` from device tree by build scripts > Vendors who want to enable Xen on their Armv8-R platforms, they can > use some tools/scripts to parse their boards device tree to generate > the basic platform information, like `XEN_START_ADDRESS`. These > tools/scripts do not necessarily need to be integrated in Xen, but Xen > can give some recommended configuration. For example, Xen can recommend > Armv8-R platforms to use lowest ram start address + 2MB as the default > Xen start address. The generated platform files can be placed to > arm/platforms for maintenance. > > - ***About MPU initialization before parsing device tree***: > Before Xen can start parsing information from device tree and use > this information to setup MPU, Xen need an initial MPU state. This > is because: > 1. More deterministic: Arm MPU supports background regions, if we > don't configure the MPU regions and don't enable MPU. The default > MPU background attributes will take effect. The default background > attributes are `IMPLEMENTATION DEFINED`. That means all RAM regions > may be configured to device memory and RWX. Random values in RAM or > maliciously embedded data can be exploited. > 2. More compatible: On some Armv8-R64 platforms, if MPU is disabled, > the `dc zva` instruction will make the system halt (This is one > side effect of MPU background attributes, the RAM has been configured > as device memory). And this instruction will be embedded in some > built-in functions, like `memory set`. If we use `-ddont_use_dc` to > rebuild GCC, the built-in functions will not contain `dc zva`. > However, it is obviously unlikely that we will be able to recompile > all GCC for ARMv8-R64. > > - Stage 1, reuse `XEN_START_ADDRESS` > In the very beginning of Xen boot, Xen just need to cover a limited > memory range and very few devices (actually only UART device). So we > can use two MPU regions to map: > 1. `XEN_START_ADDRESS` to `XEN_START_ADDRESS + 2MB` or. > `XEN_START_ADDRESS` to `XEN_START_ADDRESS + image_size`as > normal memory. > 2. `UART` MMIO region base to `UART` MMIO region end to device memory. > These two are enough to support Xen run in boot time. And we don't need > to provide additional platform information for initial normal memory > and device memory regions. In current PoC we have used this option > for implementation, and it's the same as Armv8-A. > > - Stage 2, generate information for initial MPU state from device tree > Introduce some macros to allow users to set initial normal > memory regions: > `ARM_MPU_NORMAL_MEMORY_START` and `ARM_MPU_NORMAL_MEMORY_END` > and device memory: > `ARM_MPU_DEVICE_MEMORY_START` and `ARM_MPU_DEVICE_MEMORY_END` > These macros are the same platform specific information as > `XEN_START_ADDRESS`, so the script of generating `XEN_START_ADDRESS` > also can be applied to these macros. > > - ***Define new system registers for compiliers***: > Armv8-R64 is based on Armv8.4. That means we will use some Armv8.4 > specific system registers. As Armv8-R64 only have secure state, so > at least, `VSTCR_EL2` and `VSCTLR_EL2` will be used for Xen. And the > first GCC version that supports Armv8.4 is GCC 8.1. In addition to > these, PMSA of Armv8-R64 introduced lots of MPU related system registers: > `PRBAR_ELx`, `PRBARx_ELx`, `PRLAR_ELx`, `PRLARx_ELx`, `PRENR_ELx` and > `MPUIR_ELx`. But the first GCC version to support these system registers > is GCC 11. We don't want to bump GCC version to 11 in the first stage, > it will affect some makefile scripts of common and other architectures. > > Instead, we will: > - Encode new system registers in macros > ``` > /* Virtualization Secure Translation Control Register */ > #define VSTCR_EL2 S3_4_C2_C6_2 > /* Virtualization System Control Register */ > #define VSCTLR_EL2 S3_4_C2_C0_0 > /* EL1 MPU Protection Region Base Address Register encode */ > #define PRBAR_EL1 S3_0_C6_C8_0 > ... > /* EL2 MPU Protection Region Base Address Register encode */ > #define PRBAR_EL2 S3_4_C6_C8_0 > ... > ``` > If we encode all above system registers, we don't need to bump GCC > version. And the common CFLAGS Xen is using still can be applied to > Armv8-R64. We don't need to modify Makefiles to add specific CFLAGS. > ***Notes:*** > ***Armv8-R AArch64 supports the A64 ISA instruction set with*** > ***some modifications:*** > ***Redefines DMB, DSB, and adds an DFB. But actually, the*** > ***encodings of DMB and DSB are still the same with A64.*** > ***And DFB is an alias of DSB #12. In this case, we think*** > ***we don't need a new architecture specific flag to*** > ***generate new instructions for Armv8-R.*** > > ### **2.2. Changes of the initialization process** > In general, we still expect Armv8-R64 and Armv8-A64 to have a consistent > initialization process. In addition to some architecutre differences, there > is no more than reusable code that we will distinguish through CONFIG_ARM_MPU > or CONFIG_ARM64_V8R. We want most of the initialization code to be reusable > between Armv8-R64 and Armv8-A64. > > - We will reuse the original head.s and setup.c of Arm. But replace the > MMU and page table operations in these files with configuration operations > for MPU and MPU regions. > > - We provide a boot-time MPU configuration. This MPU configuration will > support Xen to finish its initialization. And this boot-time MPU > configuration will record the memory regions that will be parsed from > device tree. > > In the end of Xen initialization, we will use a runtime MPU configuration > to replace boot-time MPU configuration. The runtime MPU configuration will > merge and reorder memory regions to save more MPU regions for guests. > ![img](https://drive.google.com/uc?export=view&id=1wTFyK2XfU3lTlH1PqRDoacQVTwUtWIGU) > > - Defer system unpausing domain after free_init_memory. > When Xen initialization is about to end, Xen unpauses guests created > during initialization. But this will cause some issues. The unpause > action occurs before free_init_memory, however the runtime MPU > configuration is built after free_init_memory. In Draft-A, we had > discussed whether a zeroing operation for init code and data is > enough or not. Because I had just given a security reason for doing > free_init_memory on Armv8-R (free_init_memory will drop the Xen init > code & data, this will reduce the code an attacker can exploit). > But I forgot other very important reasons: > 1. Init code and data will occupy two MPU regions, because they > have different memory attributes. > 2. It's not easy to zero init code section, because it's readonly. > We have to update its MPU region to make this section RW. This > operation doesn't do much less than free_init_memory. > 3. Zeroing init code and data will not release the two MPU regions > they are using. This would be a very big waste of a limited MPU > regions resource. > 4. Current free_init_memory operation is reusing lots of Armv8-A > codes, except re-add init memory to Xen heap. Because we're using > static heap on Armv8-R. > > So if the unpaused guests start executing the context switch at this > point, then its MPU context will base on the boot-time MPU configuration. > Probably it will be inconsistent with runtime MPU configuration, this > will cause unexpected problems (This may not happen in a single core > system, but on SMP systems, this problem is foreseeable, so we hope to > solve it at the beginning). > > Why we need to switch the MPU configuration that late? > Because we need to re-order the MPU regions to reduce complexity of runtime > MPU regions management. > 1. In the boot stage, we allocate MPU regions in sequence until the max. > Since a few MPU regions will get removed along the way, they will leave > holes there. For example, when heap is ready, fdt will be reallocated > in the heap, which means the MPU region for device tree is never needed. > And also in free_init_memory, although we do not add init memory to heap, > we still reclaim the MPU regions they are using. Without ordering, we > may need a bitmap to record such information. > > In context switch, the memory layout is quite different for guest mode > and hypervisor mode. When switching to guest mode, only guest RAM, > emulated/passthrough devices, etc could be seen, but in hypervisor mode, > all Xen used devices and guests RAM shall be seen. And without reordering, > we need to iterate all MPU regions to find according regions to disable > during runtime context switch, that's definitely a overhead. > > So we propose an ordering at the tail of the boot time, to put all fixed > MPU regions in the head, like xen text/data, etc, and put all flexible > ones at tail, like device memory, guests RAM. > > Then later in runtime, like context switch, we could easily just disable > ones from tail and inserts new ones in the tail. > > ### **2.3. Changes to reduce memory fragmentation** > > In general, memory in Xen system can be classified to 4 classes: > `image sections`, `heap sections`, `guest RAM`, `boot modules (guest Kernel, > initrd and dtb)` > > Currently, Xen doesn't have any restriction for users how to allocate > memory for different classes. That means users can place boot modules > anywhere, can reserve Xen heap memory anywhere and can allocate guest > memory anywhere. > > In a VMSA system, this would not be too much of a problem, since the > MMU can manage memory at a granularity of 4KB after all. But in a > PMSA system, this will be a big problem. On Armv8-R64, the max MPU > protection regions number has been limited to 256. But in typical > processor implementations, few processors will design more than 32 > MPU protection regions. Add in the fact that Xen shares MPU protection > regions with guest's EL1 Stage 2. It becomes even more important > to properly plan the use of MPU protection regions. > > - An ideal of memory usage layout restriction: > ![img](https://drive.google.com/uc?export=view&id=1kirOL0Tx2aAypTtd3kXAtd75XtrngcnW) > 1. Reserve proper MPU regions for Xen image (code, rodata and data + bss). > 2. Reserve one MPU region for boot modules. > That means the placement of all boot modules, include guest kernel, > initrd and dtb, will be limited to this MPU region protected area. > 3. Reserve one or more MPU regions for Xen heap. > On Armv8-R64, the guest memory is predefined in device tree, it will > not be allocated from heap. Unlike Armv8-A64, we will not move all > free memory to heap. We want Xen heap is deterministic too, so Xen on > Armv8-R64 also rely on Xen static heap feature. The memory for Xen > heap will be defined in tree too. Considering that physical memory > can also be discontinuous, one or more MPU protection regions needs > to be reserved for Xen HEAP. > 4. If we name above used MPU protection regions PART_A, and name left > MPU protection regions PART_B: > 4.1. In hypervisor context, Xen will map left RAM and devices to PART_B. > This will give Xen the ability to access whole memory. > 4.2. In guest context, Xen will create EL1 stage 2 mapping in PART_B. > In this case, Xen just need to update PART_B in context switch, > but keep PART_A as fixed. > > ***Notes: Static allocation will be mandatory on MPU based systems*** > > **A sample device tree of memory layout restriction**: > ``` > chosen { > ... > /* > * Define a section to place boot modules, > * all boot modules must be placed in this section. > */ > mpu,boot-module-section = <0x10000000 0x10000000>; > /* > * Define a section to cover all guest RAM. All guest RAM must be located > * within this section. The pros is that, in best case, we can only have > * one MPU protection region to map all guest RAM for Xen. > */ > mpu,guest-memory-section = <0x20000000 0x30000000>; > /* > * Define a memory section that can cover all device memory that > * will be used in Xen. > */ > mpu,device-memory-section = <0x80000000 0x7ffff000>; > /* Define a section for Xen heap */ > xen,static-mem = <0x50000000 0x20000000>; > > domU1 { > ... > #xen,static-mem-address-cells = <0x01>; > #xen,static-mem-size-cells = <0x01>; > /* Statically allocated guest memory, within mpu,guest-memory-section */ > xen,static-mem = <0x30000000 0x1f000000>; > > module@11000000 { > compatible = "multiboot,kernel\0multiboot,module"; > /* Boot module address, within mpu,boot-module-section */ > reg = <0x11000000 0x3000000>; > ... > }; > > module@10FF0000 { > compatible = "multiboot,device-tree\0multiboot,module"; > /* Boot module address, within mpu,boot-module-section */ > reg = <0x10ff0000 0x10000>; > ... > }; > }; > }; > ``` > It's little hard for users to compose such a device tree by hand. Based > on the discussion of Draft-A, Xen community suggested users to use some > tools like [imagebuilder](https://gitlab.com/xen-project/imagebuilder) to generate the above device tree properties. > Please goto TODO#3.3 section to get more details of this suggestion. > > ### **2.4. Changes of memory management** > Xen is coupled with VMSA, in order to port Xen to Armv8-R64, we have to > decouple Xen from VMSA. And give Xen the ability to manage memory in PMSA. > > 1. ***Use buddy allocator to manage physical pages for PMSA*** > From the view of physical page, PMSA and VMSA don't have any difference. > So we can reuse buddy allocator on Armv8-R64 to manage physical pages. > The difference is that, in VMSA, Xen will map allocated pages to virtual > addresses. But in PMSA, Xen just convert the pages to physical address. > > 2. ***Can not use virtual address for memory management*** > As Armv8-R64 only has PMSA in EL2, Xen loses the ability of using virtual > address to manage memory. This brings some problems, some virtual address > based features could not work well on Armv8-R64, like `FIXMAP`, `vmap/vumap`, > `ioremap` and `alternative`. > > But the functions or macros of these features are used in lots of common > code. So it's not good to use `#ifdef CONFIG_ARM_MPU` to gate relate code > everywhere. In this case, we propose to use stub helpers to make the changes > transparently to common code. > 1. For `FIXMAP`, we will use `0` in `FIXMAP_ADDR` for all fixmap operations. > This will return physical address directly of fixmapped item. > 2. For `vmap/vumap`, we will use some empty inline stub helpers: > ``` > static inline void vm_init_type(...) {} > static inline void *__vmap(...) > { > return NULL; > } > static inline void vunmap(const void *va) {} > static inline void *vmalloc(size_t size) > { > return NULL; > } > static inline void *vmalloc_xen(size_t size) > { > return NULL; > } > static inline void vfree(void *va) {} > ``` > > 3. For `ioremap`, it depends on `vmap`. As we have make `vmap` to always > return `NULL`, they could not work well on Armv8-R64 without changes. > `ioremap` will return input address directly. But if some extended > functions like `ioremap_nocache`, `ioremap_cache`, need to ask a new > memory attributes. As Armv8-R doesn't have infinite MPU regions for > Xen to split the memory area from its located MPU region and assign > the new attributes to it. So in `ioremap_nocache`, `ioremap_cache`, > if the input attributes are different from current memory attributes, > these functions will return `NULL`. > ``` > static inline void *ioremap_attr(...) > { > /* We don't have the ability to change input PA cache attributes */ > if ( CACHE_ATTR_need_change ) > return NULL; > return (void *)pa; > } > static inline void __iomem *ioremap_nocache(...) > { > return ioremap_attr(start, len, PAGE_HYPERVISOR_NOCACHE); > } > static inline void __iomem *ioremap_cache(...) > { > return ioremap_attr(start, len, PAGE_HYPERVISOR); > } > static inline void __iomem *ioremap_wc(...) > { > return ioremap_attr(start, len, PAGE_HYPERVISOR_WC); > } > void *ioremap(...) > { > return ioremap_attr(pa, len, PAGE_HYPERVISOR_NOCACHE); > } > > ``` > 4. For `alternative`, it has been listed in TODO, we will simply disable > it on Armv8-R64 in current stage. But simply disable `alternative` > will make `cpus_have_const_cap` always return false. > ``` > * System capability check for constant cap */ > #define cpus_have_const_cap(num) ({ \ > register_t __ret; \ > \ > asm volatile (ALTERNATIVE("mov %0, #0", \ > "mov %0, #1", \ > num) \ > : "=r" (__ret)); \ > \ > unlikely(__ret); \ > }) > ``` > So, before we have an PMSA `alternative` implementation, we have to > implement a separate `cpus_have_const_cap` for Armv8-R64: > ``` > #define cpus_have_const_cap(num) cpus_have_cap(num) > ``` > > ### **2.5. Changes of guest management** > Armv8-R64 only supports PMSA in EL2, but it supports configurable > VMSA or PMSA in EL1. This means Xen will have a new type guest on > Armv8-R64 - MPU based guest. > > 1. **Add a new domain type - MPU_DOMAIN** > When user want to create a guest that will be using MPU in EL1, user > should add a `mpu` property in device tree `domU` node, like following > example: > ``` > domU2 { > compatible = "xen,domain"; > direct-map; > mpu; --> Indicates this domain will use PMSA in EL1. > ... > }; > ``` > Corresponding to `mpu` property in device tree, we also need to introduce > a new flag `XEN_DOMCTL_CDF_INTERNAL_mpu` for domain to mark itself as an > MPU domain. This flag will be used in domain creation and domain doing > vCPU context switch. > 1. Domain creation need this flag to decide enable PMSA or VMSA in EL1. > 2. vCPU context switch need this flag to decide save/restore MMU or MPU > related registers. > > 2. **Add MPU registers for vCPU to save EL1 MPU context** > Current Xen only supports MMU based guest, so it hasn't considered to > save/restore MPU context. In this case, we need to add MPU registers > to `arch_vcpu`: > ``` > struct arch_vcpu > { > ... > #ifdef CONFIG_ARM_MPU > /* Virtualization Translation Control Register */ > register_t vtcr_el2; > > /* EL1 MPU regions' registers */ > pr_t *mpu_regions; > #endif > ... > } > ``` > Armv8-R64 can support max to 256 MPU regions. But that's just theoretical. > So we don't want to embed `pr_t mpu_regions[256]` in `arch_vcpu` directly, > this will be a memory waste in most cases. Instead we use a pointer in > `arch_vcpu` to link with a dynamically allocated `mpu_regions`: > ``` > p->arch.mpu_regions = _xzalloc(sizeof(pr_t) * mpu_regions_count_el1, SMP_CACHE_BYTES); > ``` > As `arch_vcpu` is used very frequently in context switch, so Xen defines > `arch_vcpu` as a cache alignment data structure. `mpu_regions` also will > be used very frequently in Armv8-R context switch. So we use `_xzalloc` > to allocate `SMP_CACHE_BYTES` alignment memory for `mpu_regions`. > > `mpu_regions_count_el1` can be detected from `MPUIR_EL1` system register > in Xen boot stage. The limitation is that, if we define a static > `arch_vcpu`, we have to allocate `mpu_regions` before using it. > > 3. **MPU based P2M table management** > Armv8-R64 EL2 doesn't have EL1 stage 2 address translation. But through > PMSA, it still has the ability to control the permissions and attributes > of EL1 stage 2. In this case, we still hope to keep the interface > consistent with MMU based P2M as far as possible. > > p2m->root will point to an allocated memory. In Armv8-A64, this memory > is used to save the EL1 stage 2 translation table. But in Armv8-R64, > this memory will be used to store EL2 MPU protection regions that are > used by guest. During domain creation, Xen will prepare the data in > this memory to make guest can access proper RAM and devices. When the > guest's vCPU will be scheduled in, this data will be written to MPU > protection region registers. > > ### **2.6. Changes of exception trap** > As Armv8-R64 has compatible exception mode with Armv8-A64, so we can reuse most > of Armv8-A64's exception trap & handler code. But except the trap based on EL1 > stage 2 translation abort. > > In Armv8-A64, we use `FSC_FLT_TRANS` > ``` > case FSC_FLT_TRANS: > ... > if ( is_data ) > { > enum io_state state = try_handle_mmio(regs, hsr, gpa); > ... > } > ``` > But for Armv8-R64, we have to use `FSC_FLT_PERM` > ``` > case FSC_FLT_PERM: > ... > if ( is_data ) > { > enum io_state state = try_handle_mmio(regs, hsr, gpa); > ... > } > ``` > > ### **2.5. Changes of device driver** > Because Armv8-R64 only has single secure state, this will affect some > devices that have two secure state, like GIC. But fortunately, most > vendors will not link a two secure state GIC to Armv8-R64 processors. > Current GIC driver can work well with single secure state GIC for Armv8-R64. > > ### **2.7. Changes of virtual device** > Currently, we only support pass-through devices in guest. Because event > channel, xen-bus, xen-storage and other advanced Xen features haven't been > enabled in Armv8-R64. > > ## 3. TODO > This section describes some features that are not currently implemented in > the PoC. Those features are things that should be looked in a second stage > and will not be part of the initial support of MPU/Armv8-R. Those jobs could > be done by Arm or any Xen contributors. > > ### 3.1. Alternative framework support > On Armv8-A system, `alternative` is depending on `VMAP` function to remap > a code section to a new read/write virtual address. But on Armv8-R, we do > not have virtual address to do remap. So as an alternative method, we will > disable the MPU to make all RAM `RWX` in "apply alternative all patches" > progress temporarily. > > 1. Disable MPU -> Code section becomes RWX. > 2. Apply alternative patches to Xen text. > 3. Enable MPU -> Code section restores to RX. > > All memory is RWX, there may be some security risk. But, because > "alternative apply patches" happens in Xen init stage, it probably > doesn't matter as much. > > ### 3.2. Xen Event Channel Support > In Current RFC patches we haven't enabled the event channel support. > But I think it's good opportunity to do some discussion in advanced. > On Armv8-R, all VMs are native direct-map, because there is no stage2 > MMU translation. Current event channel implementation depends on some > shared pages between Xen and guest: `shared_info` and per-cpu `vcpu_info`. > > There are two issues with these two pages: > > 3.2.1. Direct-mapping: > For `shared_info`, in current implementation, Xen will allocate a page > from heap for `shared_info` to store initial meta data. When guest is > trying to setup `shared_info`, it will allocate a free gfn and use a > hypercall to setup P2M mapping between gfn and `shared_info`. > > For direct-mapping VM, this will break the direct-mapping concept. > And on an MPU based system, like Armv8-R system, this operation will > be very unfriendly. Xen need to pop `shared_info` page from Xen heap > and insert it to VM P2M pages. If this page is in the middle of > Xen heap, this means Xen need to split current heap and use extra > MPU regions. Also for the P2M part, this page is unlikely to form > a new continuous memory region with the existing p2m pages, and Xen > is likely to need another additional MPU region to set it up, which > is obviously a waste for limited MPU regions. And This kind of dynamic > is quite hard to imagine on an MPU system. > > For `vcpu_info`, in current implementation, Xen will store `vcpu_info` > meta data for all vCPUs in `shared_info`. When guest is trying to setup > `vcpu_info`, it will allocate memory for `vcpu_info` from guest side. > And then guest will use hypercall to copy meta data from `shared_info` > to guest page. After that both Xen `vcpu_info` and guest `vcpu_info` > are pointed to the same page that allocated by guest. > > This implementation has serval benefits: > 1. There is no waste memory. No extra memory will be allocated from Xen heap. > 2. There is no P2M remap. This will not break the direct-mapping, and > is MPU system friendly. > So, on Armv8-R system, we can still keep current implementation for > per-cpu `vcpu_info`. > > So, our proposal is that, can we reuse current implementation idea of > `vcpu_info` for `shared_info`? We still allocate one page for > `d->shared_info` at domain construction for holding some initial meta-data, > using alloc_domheap_pages instead of alloc_xenheap_pages and > share_xen_page_with_guest. And when guest allocates a page for > `shared_info` and use hypercall to setup it, We copy the initial data from > `d->shared_info` to it. And after copy we can update `d->shared_info` to point > to guest allocated 'shared_info' page. In this case, we don't have to think > about the fragmentation of Xen heap and p2m and the extra MPU regions. > > As guest cannot access 'shared_info' until it makes the > XENMAPSPACE_shared_info hypercall. So it should be possible to get rid > of the initial 'shared_info' allocation in Xen. > > 3.2.2. How to access these pages of remote domain in hypercall > As 'shared_info' and 'vcpu_info' are allocated by Guest. And these pages > are not mapped in Xen's MPU regions, instead they should be mapped in > guest's P2M MPU regions. When guest issues a hypercall to notify a peer > domain through event channel. Xen needs to update the pending bitmap > in peer domain's page. > > For MMU system, Xen has a full view of system memory in runtime. Because > it has dedicated EL2 MMU to map whole system memory. So it has the ability > to update peer domain's pending bitmap. But in MPU system, the EL2 MPU is > shared by Xen and guest P2M mapping. In hypercall context, the EL2 MPU > only contains Xen memory (code, data and heap) and current running guest's > P2M mapping. When Xen accesses peer domain's pending bitmap, it will cause > EL2 data abort. > > So, for MPU system, we need to reserve one EL2 MPU region to map peer > domain's page to handle hypercalls which need to access this peer domain's > page. More detailed discussions have been listed in [Draft-B](https://lists.xenproject.org/archives/html/xen-devel/2022-04/msg01719.html). > > > But here still has some concerns: > `d->shared_info` in Xen is accessed without any lock. So it will not be > that simple to update `d->shared_info`. It might be possible to protect > d->shared_info (or other structure) with a read-write lock. > > Do we need to add PGT_xxx flags to make it global and stay as much the > same with the original op, a simple investigation tells us that it only > be referred in `get_page_type`. Since ARM doesn't care about type counts > and always return 1, it doesn't have too much impact. > > ### 3.3. Xen Partial PIC/PIE > We have mentioned about PIC/PIE in section 1.2. With PIC/PIE support, > Xen can be loaded at any address and run properly. But it's rare to use > PIC/PIE on a real-time system (code size, more memory access). So a > partial PIC/PIE image maybe better. But partial PIC/PIE image may not > solve the Xen start address issue. > > But a partial PIC/PIE support may be needed for Armv8-R. Because Arm > [EBBR](https://arm-software.github.io/ebbr/index.html) require Xen > on Armv8-R to support EFI boot service. Due to lack of relocation > capability, EFI loader could not launch xen.efi on Armv8-R. So maybe > we still need a partially supported PIC/PIE. Only some boot code > support PIC/PIE to make EFI relocation happy. This boot code will > help Xen to check its loaded address and relocate Xen image to Xen's > run-time address if need. > > ### 3.4. A tool to generate Armv8-R Xen device tree > 1. Use a tool to generate above device tree property. > This tool will have some similar inputs as below: > --- > DEVICE_TREE="fvp_baremetal.dtb" > XEN="4.16-2022.1/xen" > > NUM_DOMUS=1 > DOMU_KERNEL[0]="4.16-2022.1/Image-domU" > DOMU_RAMDISK[0]="4.16-2022.1/initrd.cpio" > DOMU_PASSTHROUGH_DTB[0]="4.16-2022.1/passthrough-example-dev.dtb" > DOMU_RAM_BASE[0]=0x30000000 > DOMU_RAM_SIZE[0]=0x1f000000 > --- > Using above inputs, the tool can generate a device tree similar as > we have described in sample. > > - `mpu,guest-memory-section`: > This section will cover all guests' RAM (`xen,static-mem` defined regions > in all DomU nodes). All guest RAM must be located within this section. > In the best case, we can only have one MPU protection region to map all > guests' RAM for Xen. > > If users set `DOMU_RAM_BASE`, `DOMU_RAM_SIZE` or `DOMU_STATIC_MEM_RANGES`, > these will be converted to the base and size of `xen,static-mem`. This tool > will scan all `xen, static-mem` in DomU nodes to determine the base and > size of `mpu,guest-memory-section`. If any other kind of memory has been > detected in this section, this tool can report an error. > Except build time check, Xen also need to do runtime check to prevent a > bad device tree that generated by malicious tools. > > If users set `DOMU_RAM_SIZE` only, this will be converted to the size of > `xen,static-mem` only. Xen will allocate the guest memory in runtime, but > not from Xen heap. `mpu,guest-memory-section` will be calculated in runtime > too. The property in device tree doesn't need or will be ignored by Xen. > > - `mpu,boot-module-section`: > This section will be used to store the boot modules like DOMU_KERNEL, > DOMU_RAMDISK, and DOMU_PASSTHROUGH_DTB. Xen keeps all boot modules in > this section to meet the requirement of DomU restart on Armv8-R. In > current stage, we don't have a privilege domain like Dom0 that can > access filesystem to reload DomU images. > > And in current Xen code, the base and size are mandatory for boot modules > If users don't specify the base of each boot module, the tool will > allocate a base for each module. And the tool will generate the > `mpu,boot-module-section` region, when it finishes boot module memory > allocation. > > Users also can specify the base and size of each boot module, these will > be converted to the base and size of module's `reg` directly. The tool > will scan all modules `reg` in DomU nodes to generate the base and size of > `mpu,boot-module-section`. If there is any kind of other memory usage > has been detected in this section, this tool can report an error. > Except build time check, Xen also need to do runtime check to prevent a > bad device tree. > > - `mpu,device-memory-section`: > This section will cover all device memory that will be used in Xen. Like > `UART`, `GIC`, `SMMU` and other devices. We haven't considered multiple > `mpu,device-memory-section` scenarios. The devices' memory and RAM are > interleaving in physical address space, it would be required to use > multiple `mpu,device-memory-section` to cover all devices. This layout > is common on Armv8-A system, especially in server. But it's rare in > Armv8-R. So in current stage, we don't want to allow multiple > `mpu,device-memory-section`. The tool can scan baremetal device tree > to sort all devices' memory ranges. And calculate a proper region for > `mpu,device-memory-section`. If it find Xen need multiple > `mpu,device-memory-section`, it can report an unsupported error. > > 2. Use a tool to generate device tree property and platform files > This opinion still uses the same inputs as opinion#1. But this tool only > generates `xen,static-mem` and `module` nodes in DomU nodes, it will not > generate `mpu,guest-memory-section`, `mpu,boot-module-section` and > `mpu,device-memory-section` properties in device tree. This will > generate following macros: > `MPU_GUEST_MEMORY_SECTION_BASE`, `MPU_GUEST_MEMORY_SECTION_SIZE` > `MPU_BOOT_MODULE_SECTION_BASE`, `MPU_BOOT_MODULE_SECTION_SIZE` > `MPU_DEVICE_MEMORY_SECTION_BASE`, `MPU_DEVICE_MEMORY_SECTION_SIZE` > in platform files in build time. In runtime, Xen will skip the device > tree parsing for `mpu,guest-memory-section`, `mpu,boot-module-section` > and `mpu,device-memory-section`. And instead Xen will use these macros > to do runtime check. > But, this also means these macros only exist in local build system, > these macros will not be maintained in Xen repo. > > Both options are acceptable and we could support both. The main difference for > the user is that option #2 requires a Xen build after running ImageBuilder, > while option #1 might not. > > But we don't have to implement both options right away. We can start from > option#1, it will be easier for initial implementation, and the current PoC > implementation will still be possible to use. > > -- > Cheers, > Wei Chen > From xen-devel-bounces@lists.xenproject.org Thu Jul 28 20:37:45 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 20:37:45 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377163.610232 (Exim 4.92) (envelope-from ) id 1oHAGJ-0004vo-Tp; Thu, 28 Jul 2022 20:37:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377163.610232; Thu, 28 Jul 2022 20:37:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAGJ-0004vh-RB; Thu, 28 Jul 2022 20:37:39 +0000 Received: by outflank-mailman (input) for mailman id 377163; Thu, 28 Jul 2022 20:37:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAGI-0004vW-B9 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 20:37:38 +0000 Received: from mail-vs1-xe2d.google.com (mail-vs1-xe2d.google.com [2607:f8b0:4864:20::e2d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1d233ab8-0eb5-11ed-bd2d-47488cf2e6aa; Thu, 28 Jul 2022 22:37:36 +0200 (CEST) Received: by mail-vs1-xe2d.google.com with SMTP id k129so2706638vsk.2; Thu, 28 Jul 2022 13:37:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d233ab8-0eb5-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7KfOyniWmBnHgUyrywGj1WcU1DSXRDKQD4lcAGgSSO4=; b=H67LN8hmKDnvFgLiT2bgAXmXcy50sHrEp/wwm0yze7QGvxSWozneYd5s1qMtgKoBsG g6nx4QcqsX/napVQV4pqQLLFV//XGshp50jEh1VcGQBidK0OKQcrT+8RlHGbOOSDMWZD xWvIdAJtu7PtYzGjn0x9XfU1Tt7rwyc9rT5ZkMooEu5B+SbFzlUlq30xzxzRLrTolihi FEpsa+wkWF/EVVhFmTTOsCby41gkpSeNtXuHO5lCyOl6+4qpb/oHZ9tYkG153kU3v1QH BAwSpuc2k/3MYvH/LaCJurV1SXfkBQrbEVYdl9D+9Rr6TiRNBwXSjw7bljiFVk9C83Hn Vlgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7KfOyniWmBnHgUyrywGj1WcU1DSXRDKQD4lcAGgSSO4=; b=sQpVhyVXleG48FTvCUSa1/oSU7DxggTLO6tpOIWsplE3XMpf3Cw1+rtyp3fWA0dmxH a/5DohJjTP0drm03161+pxkVDDEtBC0xYg/dGRcPu30kV8gw0OpIqYkAZAYb7f/ua9bS x0V0Uci5tPmmTuvzma1Ll+lpS+ap19RaLq5gsnTKX9naVdWTpRR4aTg22wN0ttpKQlo+ wbS4dmYVKKPOXhLWi2BC8bvMTVMvaG2H1vQe607KEp90kXebILVuLQo3VKI2JtCk6SZD aT7CmEhRyr0XQJU23Onq+6ZFSfrgDm/3rZwmp/HMBcIm4Dhq5W5GTs3VrtbNWzzj/11b lPAQ== X-Gm-Message-State: AJIora+4D4mo2v1mDpr73iRAOzOkXZ8S6H8NuMrYZrKHi2TXkoM1jpN+ BdVkvPw7Sjeq1OMOBmdWieqASQRyFhWLnPfgf+eRwQpRV8s= X-Google-Smtp-Source: AGRyM1vrIeO8g1W/rhrfq+259cw/A0QAzwVsnKUp3FHFTqx7sjDy2PVSrOq1PA/7QfBCEoO7e/OpPgdx3oqSXypvFmw= X-Received: by 2002:a05:6102:41a4:b0:358:50ab:2cf1 with SMTP id cd36-20020a05610241a400b0035850ab2cf1mr173589vsb.40.1659040655395; Thu, 28 Jul 2022 13:37:35 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christopher Clark Date: Thu, 28 Jul 2022 13:37:24 -0700 Message-ID: Subject: Re: Enable audio virtualization in Xen To: "SHARMA, JYOTIRMOY" Cc: "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" , Daniel Smith , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jul 28, 2022 at 12:05 PM SHARMA, JYOTIRMOY wrote: > > [AMD Official Use Only - General] > > Hi all, > > Can anyone please help here? Hello I have now been able to reproduce the HVM guest audio failure that you reported, with the same versions of Ubuntu, Xen and Qemu that you indicated. I have also been able to correct it and successfully enable guest audio output. I hope we can enable the same for you. The issues I encountered are: 1) The command line arguments passed to qemu from libxl need some adjustment for this system configuration. 2) Pulseaudio on the host runs as the desktop session user, whereas the qemu device emulator runs as root, and some configuration change is required to connect the two. I also had to ensure that I had a version of Qemu with SDL enabled to match your configuration, and a recent enough version of seabios to successfully boot the guest. The following are workarounds. A new patch to libxl would be appropriate for improving handling of passing audio configuration from VM config files to qemu, and there is likely a better way of enabling host audio configuration for qemu than my outline below, but this appears to work and is hopefully sufficient for unblocking your progress. To work around the command line arguments to qemu: # Move the qemu-system-i386 binary to a different filename: mv /usr/lib/xen/bin/qemu-system-i386 /usr/lib/xen/bin/qemu-system-i386.real # Create a wrapper script file in place of the previous binary, to add the audio parameters: /usr/lib/xen/bin/qemu-system-i386 ---- #!/bin/sh /usr/lib/xen/bin/qemu-system-i386.real -audiodev id=3Dsnd0,driver=3Dpa -device ich9-intel-hda -device hda-output,audiodev=3Dsnd0 $@ ---- chmod 755 /usr/lib/xen/bin/qemu-system-i386 Ensure that you have removed any sound configuration from the VM config file; the wrapper script will be providing this now instead. To enable sound from the qemu process that is running as root, I followed the answer on this page: https://stackoverflow.com/questions/66775654/how-can-i-make-pulseaudio-run-= as-root Summarizing those pulseaudio configuration steps here, perform the following as root: # Write /etc/systemd/system/pulseaudio.service file: ---- [Unit] Description=3DPulseAudio system server [Service] Type=3Dnotify ExecStart=3Dpulseaudio --daemonize=3Dno --system --realtime --log-target=3D= journal [Install] WantedBy=3Dmulti-user.target ---- # Enable the new service: sudo systemctl --system enable pulseaudio.service sudo systemctl --system start pulseaudio.service sudo systemctl --system status pulseaudio.service # Edit items in : /etc/pulse/client.conf ---- default-server =3D /var/run/pulse/native autospawn =3D no ---- # Add root to pulse group sudo adduser root pulse-access # Also add your desktop user to pulse group, to retain working audio for that host desktop user sudo adduser $USER pulse-access # Reboot reboot You should now be able to start your guest VM with working audio. I would note that the qemu-dm log files in /var/log/xen/ can be useful for observing error messages from Qemu if you still encounter difficulty. > Also, how can I make use of the xen front end drivers in a HVM guest? I don't believe that the Xen audio front end drivers are necessary for enabling HVM guest audio output, and I don't have experience with using them yet but I am interested to hear of reports of using them on x86. thanks, Christopher > > -----Original Message----- > From: SHARMA, JYOTIRMOY > Sent: Tuesday, July 26, 2022 4:27 PM > To: Christopher Clark > Cc: xen-devel@lists.xenproject.org; xen-users@lists.xenproject.org > Subject: RE: Enable audio virtualization in Xen > > [AMD Official Use Only - General] > > Hi Christopher, > > Thank you for the quick response. Please find answers below. > > >> Does audio playback work OK from your Ubuntu dom0? > Yes. > > >> Do you know which version of Ubuntu you are using? ('cat /etc/lsb-rele= ase') > Ubuntu 22.04 LTS. > > >> Do you know which version of Xen you are using? ('xl info' in dom0 sho= uld help) > 4.16.2-pre. > > >> Do you know which version of Qemu you have installed in dom0? > QEMU emulator version 6.1.1. > > >> Did you build and install Xen from source code, or are you using binar= y packages of Xen and its tools? > We built and installed Xen from source code (git clone https://xenbits.xe= n.org/git-http/xen.git). > > >> Are you using the xl tools, or libvirt tools for configuring and runni= ng your guest? -- ie. how do you start your domU VM? > We are using xl tools (sudo xl -v create ). > > >> When your domU is running, please could you run 'ps auxwww' in dom0 an= d obtain the process information about the qemu instance that is running, s= o that we can see what command line arguments have been supplied to it > > This is the log we get right after booting dom 0: > > root 723 0.0 0.2 243792 14468 ? Sl 15:51 0:00 /usr/local/lib/xen/bin/qemu= -system-i386 -xen-domid 0 -xen-attach -name dom0 -nographic -M xenpv -daemo= nize -monitor /dev/null -serial /dev/null -parallel /dev/null -pidfile /var= /run/xen/qemu-dom0.pid > > This log is seen after we launch dom U (sudo xl -v create ): > > root 2152 20.7 2.3 2858204 133496 ? Ssl 15:53 0:09 /usr/local/lib/xen/bin= /qemu-system-i386 -xen-domid 1 -no-shutdown -chardev socket,id=3Dlibxl-cmd,= path=3D/var/run/xen/qmp-libxl-1,server=3Don,wait=3Doff -mon chardev=3Dlibxl= -cmd,mode=3Dcontrol -chardev socket,id=3Dlibxenstat-cmd,path=3D/var/run/xen= /qmp-libxenstat-1,server=3Don,wait=3Doff -mon chardev=3Dlibxenstat-cmd,mode= =3Dcontrol -nodefaults -no-user-config -name domu-ubuntu.hvm -vnc 127.0.0.1= :0,to=3D99 -display sdl,gl=3Don -sdl -device virtio-vga-gl -boot order=3Ddc= -usb -usbdevice tablet -smp 2,maxcpus=3D2 -net none -machine xenfv,suppres= s-vmdesc=3Don -m 2040 -drive file=3D/home/amd/u2004_ubuntu.qcow2,if=3Dide,i= ndex=3D0,media=3Ddisk,format=3Dqcow2,cache=3Dwriteback > > >> A little more information about what you're running will help with pro= viding guidance here. The xl man page indicates that there is a "soundhw" o= ption in the VM configuration file for passing sound hardware configution t= hrough to qemu, so if you are using the xl toolstack, you could try adding = this to the config file: soundhw=3D"hda" > > I tried giving soundhw=3D"hda" option in the hvm config file. However, I = do not hear any sound when I play a wave file in dom U. Here is the 'ps aux= www' output after making this change: > > root 2568 14.8 2.3 2770864 134720 ? Ssl 15:58 0:09 /usr/local/lib/xen/bin= /qemu-system-i386 -xen-domid 2 -no-shutdown -chardev socket,id=3Dlibxl-cmd,= path=3D/var/run/xen/qmp-libxl-2,server=3Don,wait=3Doff -mon chardev=3Dlibxl= -cmd,mode=3Dcontrol -chardev socket,id=3Dlibxenstat-cmd,path=3D/var/run/xen= /qmp-libxenstat-2,server=3Don,wait=3Doff -mon chardev=3Dlibxenstat-cmd,mode= =3Dcontrol -nodefaults -no-user-config -name domu-ubuntu-audio.hvm -vnc 127= .0.0.1:0,to=3D99 -display sdl,gl=3Don -sdl -device virtio-vga-gl -boot orde= r=3Ddc -usb -usbdevice tablet -soundhw hda -smp 2,maxcpus=3D2 -net none -ma= chine xenfv,suppress-vmdesc=3Don -m 2040 -drive file=3D/home/amd/u2004_ubun= tu.qcow2,if=3Dide,index=3D0,media=3Ddisk,format=3Dqcow2,cache=3Dwriteback > > Also, I tried giving soundhw=3D"all" in the config file, however this thr= ows following error: > > libxl: error: libxl_dm.c:3130:device_model_spawn_outcome: Domain 4:domain= 4 device model: spawn failed (rc=3D-3) > libxl: error: libxl_dm.c:3350:device_model_postconfig_done: Domain 4:Post= DM startup configs failed, rc=3D-3 > libxl: error: libxl_create.c:1867:domcreate_devmodel_started: Domain 4:de= vice model did not start: -3 > libxl: error: libxl_aoutils.c:646:libxl__kill_xs_path: Device Model alrea= dy exited > libxl: error: libxl_domain.c:1183:libxl__destroy_domid: Domain 4:Non-exis= tant domain > libxl: error: libxl_domain.c:1137:domain_destroy_callback: Domain 4:Unabl= e to destroy guest > libxl: error: libxl_domain.c:1064:domain_destroy_cb: Domain 4:Destruction= of domain failed > > Can you please let me know what parameters I should use in the config fil= e to play audio from dom U? > > Regards, > Jyotirmoy > > -----Original Message----- > From: Christopher Clark > Sent: Tuesday, July 26, 2022 2:44 AM > To: SHARMA, JYOTIRMOY > Cc: xen-devel@lists.xenproject.org; xen-users@lists.xenproject.org > Subject: Re: Enable audio virtualization in Xen > > [CAUTION: External Email] > > On Mon, Jul 25, 2022 at 4:45 AM SHARMA, JYOTIRMOY wrote: > > > > [AMD Official Use Only - General] > > > > > > Hi all, > > Hi Jyotirmoy, > > I have add the xen-users list to CC since this thread may be useful to th= at forum. > > > I am using ubuntu as dom 0 and also dom U (HVM). I want to play audio f= rom =E2=80=9Cdom U=E2=80=9D Ubuntu. > > I think that it should be possible to enable what you are attempting to d= o. ie. audio output from a HVM Ubuntu guest VM. > > Some questions to support assisting you: > * Does audio playback work OK from your Ubuntu dom0? > * Do you know which version of Ubuntu you are using? ('cat /etc/lsb-relea= se') > * Do you know which version of Xen you are using? ('xl info' in dom0 shou= ld help) > * Do you know which version of Qemu you have installed in dom0? > * Did you build and install Xen from source code, or are you using binary= packages of Xen and its tools? > * Are you using the xl tools, or libvirt tools for configuring and runnin= g your guest? -- ie. how do you start your domU VM? > * When your domU is running, please could you run 'ps auxwww' in dom0 and= obtain the process information about the qemu instance that is running, so= that we can see what command line arguments have been supplied to it > > > I am new to Xen/virtualization in general. > > Welcome! :-) > > > From various reading I understood that I need to take following approac= h: > > > > 1. Use Xen front end ALSA driver in dom U > > I'm not certain that this is necessary for your HVM guest. Instead of usi= ng the Xen paravirtualized audio protocol, Qemu should be able to present a= n emulated audio device to the HVM guest domU, and a standard audio driver = (hda or ac97) in domU should suffice. > > > 2. Use Qemu to connect to the backend ALSA driver in Dom 0 > > I think if Qemu is started with the correct command line arguments, it sh= ould be able to play sound on behalf of the guest, if sound is correctly co= nfigured and working in dom0. > > > Can you please let me know if this approach is fine? If yes, I have fol= lowing questions: > > > > 1. Do I need to recompile Ubuntu to support Xen front end ALSA driver? = Or will Ubuntu iso file already have it enabled? > > I think the latter, that the Ubuntu installation ISO should already conta= in a suitable audio device driver that is compatible with the virtual audio= device that is emulated by Qemu. > > > 2. Ho do I configure Qemu to enable backend driver? > > A little more information about what you're running will help with provid= ing guidance here. The xl man page indicates that there is a "soundhw" opti= on in the VM configuration file for passing sound hardware configution thro= ugh to qemu, so if you are using the xl toolstack, you could try adding thi= s to the config file: soundhw=3D"hda" > > Christopher From xen-devel-bounces@lists.xenproject.org Thu Jul 28 20:51:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 20:51:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377171.610244 (Exim 4.92) (envelope-from ) id 1oHAT3-0007PM-0Z; Thu, 28 Jul 2022 20:50:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377171.610244; Thu, 28 Jul 2022 20:50:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAT2-0007PF-UC; Thu, 28 Jul 2022 20:50:48 +0000 Received: by outflank-mailman (input) for mailman id 377171; Thu, 28 Jul 2022 20:50:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAT1-0007P9-Ox for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 20:50:47 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHASz-0001bT-JU; Thu, 28 Jul 2022 20:50:45 +0000 Received: from [54.239.6.189] (helo=[192.168.25.182]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHASz-0006l8-D1; Thu, 28 Jul 2022 20:50:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=8Pcqz0eQsIWIzC0PXJUMr4R4gjz+WsvYQstmpqfGkJo=; b=1nwR7oEWesBXaqWsTMf01pD9rt ZfYrTjCv3tV/KBnPZxSE0Ob3vN87dSrziB2JrZKJNCfLmaqAHtt3UcpY3ILdkKcSokaZ7AfHCXXX3 uyJ6t4BgVlKSHnrzMkZuSS9z6jTwCI3AnsZ/cpRiyZPtMdSQzMYH2DMtChUQtGCMF0U4=; Message-ID: <03fd4b2b-66ab-eaf8-0875-9382e8b14012@xen.org> Date: Thu, 28 Jul 2022 21:50:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Content-Language: en-US To: Rahul Singh Cc: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> From: Julien Grall In-Reply-To: <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Rahul, On 28/07/2022 16:37, Rahul Singh wrote: > As you mentioned, if we don’t restrict the number of events channel for the dom0 system will boot slower. > This is a good reason to restrict the number of event channels for dom0. Let me start that I am still fine if you want to push for a new parameter (so long it is not Arm specific). However, I am afraid that I will not be able to argue for it because I don't see a strict need for it. Let me play the devil's advocate for a bit. AFAIU, you would like to introduce the new parameter just to tell the admin the boot is going to be slower if you use a event channel ID higher than N. To me this sounds like the same as if an admin decide to use 10GB rather than 1GB. There will be slow down. This slowness is only boot specific and will not vary. So one could argue this is easily noticeable and an admin can take remediation. Given Jan's objection, I would like to propose to document it in the bindings instead (a concerned admin will likely read it). Below a rough proposal for the documentation: "It is recommended to use low event channel ID." Would that be suitable for you? Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Thu Jul 28 21:07:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 21:07:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377181.610255 (Exim 4.92) (envelope-from ) id 1oHAjA-0000wz-DH; Thu, 28 Jul 2022 21:07:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377181.610255; Thu, 28 Jul 2022 21:07:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAjA-0000ws-AI; Thu, 28 Jul 2022 21:07:28 +0000 Received: by outflank-mailman (input) for mailman id 377181; Thu, 28 Jul 2022 21:07:27 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHAj8-0000wm-W6 for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 21:07:27 +0000 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2059.outbound.protection.outlook.com [40.107.243.59]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 46ea1553-0eb9-11ed-924f-1f966e50362f; Thu, 28 Jul 2022 23:07:25 +0200 (CEST) Received: from BN9PR03CA0597.namprd03.prod.outlook.com (2603:10b6:408:10d::32) by PH0PR12MB5468.namprd12.prod.outlook.com (2603:10b6:510:ea::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Thu, 28 Jul 2022 21:07:20 +0000 Received: from BN8NAM11FT040.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10d:cafe::cf) by BN9PR03CA0597.outlook.office365.com (2603:10b6:408:10d::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 21:07:20 +0000 Received: from SATLEXMB03.amd.com (165.204.84.17) by BN8NAM11FT040.mail.protection.outlook.com (10.13.177.166) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5482.10 via Frontend Transport; Thu, 28 Jul 2022 21:07:20 +0000 Received: from SATLEXMB03.amd.com (10.181.40.144) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 16:07:19 -0500 Received: from ubuntu-20.04.2-arm64.shared (10.180.168.240) by SATLEXMB03.amd.com (10.181.40.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 16:07:13 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 46ea1553-0eb9-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fdUq5mBJDlCKMjDAogom2dG6W1QljmPcOONPYdCWKO5cytU7gwGlsJEe6c4EaSgeMGXmcMuOTg1/T1w7iyj2WoJ4wR5+ksM1quRMsadiyOXDmwC5H+X8d812bqxU0GO2zKrpjYM3oXZSkFCBXbkaDmF13kfJO4ciOG0KCY2yaOZJ9W8G9eoVN+avRvp0AF0Py3prf6KT8Q36VIKrStwIxJRAbr4syAOtBlckCK+rhRgjqI2IcbZCewO4liHOsT1jKZzAcW+ThNZpxb7pdFkoENocIQh2X3Kr+7IFJN+DS9UrTPhKJMSrNPSgBzrWSnp0FSnBlRTW8TZWJLa9B0G9QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mgk2nthYcqQjL7vj6xYPhzGb7JQB/6hr8mZMLS6kRoA=; b=Hh6DoLQEGy9ZnG5juflZxCoTQegKrA+CZmwtfDUus8ee63Z0tOAR997dHRA7L1pQ20z7KixfuGWm/saI8muUBUA3Q/EIR3IG9ra3/FjEaa0/HskUElG4JOp0Bkt7UHdHrbBsSqyFq2pGNaTJs24wdAqVQ60HJTopC4xVI7OSHkh17K7RCpRjgdvvftzl9SDca0ot2lVZZbvfsg21Koe8cyUe5mP6PpuAuPs+ZrwTXGsEsWL6WQTeYCGd/S1OdmQpQ+KzYvrFahB7jcYWfcY5/hvq+VdIFSGTGbTs6Yis2JtF7by3A+q8UKeFzNA2MohdY9BYdeZ1e8WE68Gbfqy4jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=redhat.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mgk2nthYcqQjL7vj6xYPhzGb7JQB/6hr8mZMLS6kRoA=; b=GLRWb/iwTxlMgEpCP9TFE8tCCOItMEnom7xhY/1sY47uaJg64jb9kVhH358EyQGVdrI5U1qdE4Ep++v3Wdt+INWMpzUhi0+kHvkpxuhe85RLKilKqaeAzvGc1QNzrPR7jPQiYX0fPJW3pkjrBvF/HEFTyiKmiNWuOAP0gWyasFg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB03.amd.com; pr=C Date: Thu, 28 Jul 2022 14:07:12 -0700 From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Igor Mammedov CC: Huang Rui , "anthony.perard@citrix.com" , "qemu-devel@nongnu.org" , "xen-devel@lists.xenproject.org" , "Huang, Trigger" , , , , , Subject: Re: Question to mem-path support at QEMU for Xen In-Reply-To: <20220728155618.2c390be3@redhat.com> Message-ID: References: <20220727101930.66ed56e1@redhat.com> <20220728155618.2c390be3@redhat.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 04d4540d-d1c6-47fa-9470-08da70dd290b X-MS-TrafficTypeDiagnostic: PH0PR12MB5468:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: jm6YuVz9iYnsfAij0gV5U80yq0h7CpsyygRannuFjbiUpmyl49NOiwdMnkYISJX35DhWV8usZ+bhn5EPaEudHtDjaw0qffLQSYlzWKfqw3CNDkRULMzMpkxtTtQJV+HOgQOgkavOBVoS3JWzMPD8mIpid8uXGmmTlNM0SC+dPgt4WgE6BzFLak5ezEFz+6pAEv7a1nzp8ZpkvEVarNRzXIbJMsZoathsqKCjB6SljlnwfC5kiqs7x6j0wlb7Ff3DQ+XP3ABSwtxo5RClAIsuRdAf7tXuP99RnaXz6oU5kNVE54sDf8IDYr/vSzKFi6vT3byynZrVSz3rC/Ptmm+8H0GemnIQhEx+OJejt7CMIgjj+gpKp+HO4h1sfSxX05Ha1K+R3YyBc7TH0qJYhuOnzCxjaoDluMKRPxbLUQWFU0vRV45MvRpAnM7oHHo/kyx1gSGstqc4b4NHi8uHlnXdIVHLhiH4tZE9qD+WZXEbIxleiKa6YbR2WLtZ5ObIlALwvdGyeE2p7BQpdfgYc7RBHFO3L/qJqmSAY33vKRpNPFCnLbH028E6EmJ/UklwQHNuUOK/GhPjiSlFeQM1XjtWmM5YSFol6lITqMmxWVR2KrzcBFna9M8XCCRvxuZJFCrwIV+58M9HooDPxj0GPZGRJYZnSQ0Frl9vXkhnqMG2XSQQKZ4T7sYRTIxGELpYLdbFf9JXBYlrH1FUIkLbru9MHYeTdMKxb1hxZvFe6lI3BhLhY3jzEVIUohA/G9meV2fDSFKUI0DkDG9niIl6bhVrIx7Ni+7l+TarZaBZBsGjLnGXb7N1J41FqPBxfzNnrZLVkHQocMpVuqUreCjodsymWw== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB03.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(7916004)(136003)(346002)(376002)(396003)(39860400002)(36840700001)(46966006)(40470700004)(4326008)(40460700003)(44832011)(70206006)(8676002)(8936002)(70586007)(356005)(82740400003)(316002)(2906002)(336012)(6916009)(54906003)(86362001)(36860700001)(33716001)(426003)(81166007)(26005)(9686003)(83380400001)(47076005)(5660300002)(40480700001)(82310400005)(478600001)(41300700001)(186003)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 21:07:20.4429 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 04d4540d-d1c6-47fa-9470-08da70dd290b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB03.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT040.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB5468 On Thu, 28 Jul 2022, Igor Mammedov wrote: > On Thu, 28 Jul 2022 15:17:49 +0800 > Huang Rui wrote: > > > Hi Igor, > > > > Appreciate you for the reply! > > > > On Wed, Jul 27, 2022 at 04:19:30PM +0800, Igor Mammedov wrote: > > > On Tue, 26 Jul 2022 15:27:07 +0800 > > > Huang Rui wrote: > > > > > > > Hi Anthony and other Qemu/Xen guys, > > > > > > > > We are trying to enable venus on Xen virtualization platform. And we would > > > > like to use the backend memory with memory-backend-memfd,id=mem1,size=4G > > > > options on QEMU, however, the QEMU will tell us the "-mem-path" is not > > > > supported with Xen. I verified the same function on KVM. > > > > > > > > qemu-system-i386: -mem-path not supported with Xen > > > > > > > > So may I know whether Xen has any limitation that support > > > > memory-backend-memfd in QEMU or just implementation is not done yet? > > > > > > Currently Xen doesn't use guest RAM allocation the way the rest of > > > accelerators do. (it has hacks in memory_region/ramblock API, > > > that divert RAM allocation calls to Xen specific API) > > > > I am new for Xen and QEMU, we are working on GPU. We would like to have a > > piece of backend memroy like video memory for VirtIO GPU to support guest > > VM Mesa Vulkan (Venus). Do you mean we can the memory_region/ramblock APIs > > to work around it? > > > > > > > > The sane way would extend Xen to accept RAM regions (whatever they are > > > ram or fd based) QEMU allocates instead of going its own way. This way > > > it could reuse all memory backends that QEMU provides for the rest of > > > the non-Xen world. (not to mention that we could drop non trivial > > > Xen hacks so that guest RAM handling would be consistent with other > > > accelerators) > > > > > > > May I know what do you mean by "going its own way"? This sounds good, could > > you please elaborate on how can we implement this? We would like to give a > > try to address the problem on Xen. Would you mind to point somewhere that I > > can learn and understand the RAM region. Very happy to see your > > suggestions! > > see for example see ram_block_add(), if Xen could be persuaded to use memory > allocated by '!xen_enabled()' branch then it's likely file base backends > would also become usable. > > Whether it is possible for Xen or not I don't know, > I guess CCed Xen folks will suggest something useful. Hi Igor, Huang, I think there is room for improvement in the way Xen support in QEMU is implemented, especially because it predates support for other accelerators in QEMU. I am happy to help come up with a good idea or two on how to do it better. At the same time it is not trivial. The way Xen works with QEMU is that Xen is the one allocating memory for the VM. Keep in mind that in a Xen setup, the VM where QEMU is running is just one of the many VMs in the system (even if it is dom0) and doesn't have ownership over the entire memory. It is also possible to run QEMU in a regular guest for security benefits. Given that, Xen is typically the one allocating memory for the VM and by the time QEMU is started the main memory is already allocated. That is the reason why normally ram_block_add() is implemented in a special way for Xen using xen_ram_alloc. In most cases, there is no need to allocate any memory at all. However, it is also possible for QEMU to allocate memory for the VM. It is done by QEMU issuing a hypercall to Xen. See for instance the call to xc_domain_populate_physmap_exact. As you can see from the implementation of xen_ram_alloc, it is already used for things that are not normal memory (see the check mr == &ram_memory). So if you want to allocate memory for the VM, you could use xc_domain_populate_physmap_exact. Another thing to note is that Xen can connect to multiple emulators at the same time. Each emulator (each instance of QEMU, or other emulators) uses a hypercall to connect to Xen and register a PCI device or memory range that it is emulating. Each emulator is called "IOREQ server" in Xen terminology because it is handling "IO emulation REQuests" from Xen. The IOREQ interface is very simple. each IOREQ is defined a ioreq_t struct, see: xen/include/public/hvm/ioreq.h:ioreq_t So if you are looking to connect a secondary emulator to QEMU, a different, more efficient, way to solve the problem on Xen would be to connect the secondary emulator directly to Xen. Instead of: Xen -> QEMU -> secondary emulator You would do: Xen ---> QEMU | +-> secondary emulator The second approach is much faster in terms of latency because you are going to skip a step in the notification chain. See how QEMU calls xen_register_ioreq to register itself with Xen. From xen-devel-bounces@lists.xenproject.org Thu Jul 28 22:19:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 22:19:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377188.610265 (Exim 4.92) (envelope-from ) id 1oHBqS-0000p5-Lw; Thu, 28 Jul 2022 22:19:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377188.610265; Thu, 28 Jul 2022 22:19:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHBqS-0000oy-J1; Thu, 28 Jul 2022 22:19:04 +0000 Received: by outflank-mailman (input) for mailman id 377188; Thu, 28 Jul 2022 22:19:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHBqQ-0000oo-SL; Thu, 28 Jul 2022 22:19:02 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHBqQ-0003Ad-Or; Thu, 28 Jul 2022 22:19:02 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHBqQ-0003lr-GP; Thu, 28 Jul 2022 22:19:02 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHBqQ-0002Zs-Fi; Thu, 28 Jul 2022 22:19:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=AjT8AhO/Ap1zjpoEECSJ8l7LYzIRND3nPxVTSvZ62HM=; b=QegthArM3hyvoIbNlX37ik1arn pCekyKOayEyGvsch5u/mOPJUhnXk7KfWbKrYxDS0INjk6CccjzYGktfPqykDtrNzJ4VPDLbPs/XGx kOVODd473uwPmYHcBK4FNp4WX0C3UuuXuNf2lEmk9ZFu0/P9d49L6JrmSY7fhjBgzStA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171899: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ca45d3cb4586372909f350e54482246f994e1bc7 X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Thu, 28 Jul 2022 22:19:02 +0000 flight 171899 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171899/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ca45d3cb4586372909f350e54482246f994e1bc7 baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 1 days Testing same since 171899 2022-07-28 19:01:47 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jiamei Xie Julien Grall Oleksandr Tyshchenko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Thu Jul 28 22:57:12 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 22:57:12 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377197.610280 (Exim 4.92) (envelope-from ) id 1oHCRC-0005n3-Hz; Thu, 28 Jul 2022 22:57:02 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377197.610280; Thu, 28 Jul 2022 22:57:02 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCRC-0005mw-Eq; Thu, 28 Jul 2022 22:57:02 +0000 Received: by outflank-mailman (input) for mailman id 377197; Thu, 28 Jul 2022 22:57:01 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCRB-0005md-RG for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 22:57:01 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [2604:1380:40e1:4800::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 95becba6-0ec8-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 00:57:00 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id B2296CE259A; Thu, 28 Jul 2022 22:56:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A74F0C433B5; Thu, 28 Jul 2022 22:56:55 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95becba6-0ec8-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659049016; bh=7HcUjbpRugDsm/OaanGW6Nhd2FkfLulFUst1ug6kHDE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=gIPx7UJ6dkf+8hdT4QaFayC1fsNCXn8rScevHGK31NBM/UgYRmvCiVZsAkx1DSW6R 2SB7XPOpZWwFqV3q1FR4hCX/Y0yie1Lj5dhKBd5cHun/WfG/EGG9Tkdr4lXA8OZ5IV VqC9lqqz/2tI51eQCU8ZECJXgmYyrO138aIj+8WEz2SmuI2esHQ6Jz9qC8Wf7EZXNh hDq2K9AAhRHhe4dJRXnbvh5sV4N/9Zthw8xpQf1wBVB4Fb/JdsLxVVO8jD/7sGmZeT 5fmMHeyzujjvhkEzADBQfCE6BYmFmwZZldxq7wRL6NnfcY9kxbTnxYzk6BycFiDcHi dxbqYqwj36gYQ== Date: Thu, 28 Jul 2022 15:56:54 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Julien Grall cc: Jan Beulich , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Xenia Ragiadakou , xen-devel@lists.xenproject.org Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation In-Reply-To: Message-ID: References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 28 Jul 2022, Julien Grall wrote: > On 28/07/2022 15:20, Jan Beulich wrote: > > On 28.07.2022 15:56, Julien Grall wrote: > > > On 28/07/2022 14:49, Xenia Ragiadakou wrote: > > > > --- a/xen/arch/arm/include/asm/arm64/sysregs.h > > > > +++ b/xen/arch/arm/include/asm/arm64/sysregs.h > > > > @@ -461,7 +461,7 @@ > > > > /* Access to system registers */ > > > > #define WRITE_SYSREG64(v, name) do { \ > > > > - uint64_t _r = v; \ > > > > + uint64_t _r = (v); \ > > > > > > I am failing to see why the parentheses are necessary here. Could you > > > give an example where the lack of them would end up to different code? > > > > I think it is merely good practice to parenthesize the right sides of =. > > Indeed with assignment operators having second to lowest precedence, and > > with comma (the lowest precedence one) requiring parenthesization at the > > macro invocation site, there should be no real need for parentheses here. > > I am not really happy with adding those parentheses because they are > pointless. But if there are a consensus to use it, then the commit message > should be updated to clarify this is just here to please MISRA (to me "need" > implies it would be bug). Let me premise that I don't know if this counts as a MISRA violation or not. (Also I haven't checked if cppcheck/eclair report it as violation.) But I think the reason for making the change would be to follow our coding style / coding practices. It makes the code simpler to figure out that it is correct, to review and maintain if we always add the parenthesis even in cases like this one where they are not strictly necessary. We are going to save our future selves some mental cycles. So the explanation on the commit message could be along those lines. From xen-devel-bounces@lists.xenproject.org Thu Jul 28 23:01:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 23:01:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377203.610290 (Exim 4.92) (envelope-from ) id 1oHCVa-0007DL-3n; Thu, 28 Jul 2022 23:01:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377203.610290; Thu, 28 Jul 2022 23:01:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCVa-0007DE-14; Thu, 28 Jul 2022 23:01:34 +0000 Received: by outflank-mailman (input) for mailman id 377203; Thu, 28 Jul 2022 23:01:33 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCVZ-0007D8-9N for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 23:01:33 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 381a149a-0ec9-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 01:01:31 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A2EBB61C99; Thu, 28 Jul 2022 23:01:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AFB0CC433D7; Thu, 28 Jul 2022 23:01:29 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 381a149a-0ec9-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659049290; bh=mYIZv7qO/hv0UXAejYw61xs9h5tN2EQOm/GOSS/2XDE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ASycqEolwFbTexjgosQWZkrMZNRt6RVTQnO/aeCCKgVZInAdVD+o7jRdPa7If6EQg bweQboZhKAWCpaCIafM0op9NvebGfPBM6nxS4XqNy6upuNlKIj9yGpwu0LlHaSj5Q3 vTPzqqEUZgbUAdKUuDN2uwq7lP7Rp8R3XcJGobDI+/PEij5/6uN4TXdJJUrl9pFygF EY8LxzV1Ik738E5VL76cLq0V/uHQ/ja5YjCUUmHAcRNWdp4frxobf4eaC7JxfSjaxx tskS0dQ/hZLAJochOdKDyzzLIcx09VHJfwhSENR0bjZ6QXex9Nr+uDlnRaBjVt1DOn 9e9fQ7vHnOryw== Date: Thu, 28 Jul 2022 16:01:28 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Bertrand Marquis cc: Julien Grall , Xenia Ragiadakou , "xen-devel@lists.xenproject.org" , Stefano Stabellini , Volodymyr Babchuk Subject: Re: [PATCH 2/2] xen/arm: asm/atomic.h: Fix MISRA C 2012 Rule 2.5 violation In-Reply-To: Message-ID: References: <20220727153254.1143503-1-burzalodowa@gmail.com> <20220727153254.1143503-3-burzalodowa@gmail.com> <93036B23-69AA-4075-A54F-1EC8CB194928@arm.com> <49ed6d31-76fd-c962-5320-c88726b45987@xen.org> <27786AF4-37EA-4C54-9330-1C9B674BAC87@arm.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 28 Jul 2022, Bertrand Marquis wrote: > > On 28 Jul 2022, at 11:21, Julien Grall wrote: > > On 28/07/2022 10:45, Bertrand Marquis wrote: > >>> On 28 Jul 2022, at 10:35, Julien Grall wrote: > >>> On 28/07/2022 08:57, Bertrand Marquis wrote: > >>>> Hi Julien, > >>> > >>> Hi Bertrand, > >>> > >>>>> On 27 Jul 2022, at 16:46, Julien Grall wrote: > >>>>> > >>>>> Hi Xenia, > >>>>> > >>>>> On 27/07/2022 16:32, Xenia Ragiadakou wrote: > >>>>>> Remove unused macro atomic_xchg(). > >>>>>> Signed-off-by: Xenia Ragiadakou > >>>>>> --- > >>>>>> xen/arch/arm/include/asm/atomic.h | 2 -- > >>>>>> 1 file changed, 2 deletions(-) > >>>>>> diff --git a/xen/arch/arm/include/asm/atomic.h b/xen/arch/arm/include/asm/atomic.h > >>>>>> index f5ef744b4b..a2dc125291 100644 > >>>>>> --- a/xen/arch/arm/include/asm/atomic.h > >>>>>> +++ b/xen/arch/arm/include/asm/atomic.h > >>>>>> @@ -223,8 +223,6 @@ static inline int atomic_add_unless(atomic_t *v, int a, int u) > >>>>>> return __atomic_add_unless(v, a, u); > >>>>>> } > >>>>>> -#define atomic_xchg(v, new) (xchg(&((v)->counter), new)) > >>>>>> - > >>>>> > >>>>> While I agree this is unused today, the wrapper is quite trivial and part of the generic API (x86 also provides one). So I am not in favor of removing it just to please MISRA. > >>>>> > >>>>> That said, if Bertrand and Stefano agrees with removing it then you should also remove the x86 version to avoid inconsistency. > >>>> I think we can keep this and maybe add a comment on top to document a known violation: > >>>> /* TODO: MISRA_VIOLATION 2.5 */ > >>> > >>> While I am fine with this goal of the comment (i.e. indicating where Xen is not MISRA compliant), I think this is one place where I would rather not want one because it can get stale if someones decide to use the function. > >> I think the one doing that will have to update the comment otherwise we will never manage to have an analysis without findings. > > > > I was under the impression that Xen will never officially follow some of the MISRA rules. So I would expect the tools to be able to detect such cases so we don't have to add a comment for every deviation on something we will never support. > > > >> Having those kind of comments in the code for violation also means that they must be updated if the violation is solved. > > > > Right, but for thing like unused function, this is quite easy to miss by both the developer and reviewers. So we are going to end up to comments for nothing. > > > >> Maybe we will need a run ignoring those to identify possible violations which are not violations anymore but this might be hard to do. > > > > TBH, I think it would be best if we can teach the tools to ignore certain rules. > > Definitely it is possible to instruct the tool to ignore this you are right and for 2.5 we should (for some reason I was under the impression that we said we would follow 2.5 but accept deviations). Absolutely possible, basically we (the community) are the ones providing the list of rules to the MISRA C checkers. > @Xenia: please ignore and do not add a comment for this. > > I think we will need to distinguish 2 kind of not following: > - not following at all (disable in the tools) > - accepting some deviations (documented in the code) Yes, exactly right. > As much as we can, I think we should target the second unless we have a lot of violations. +1 From xen-devel-bounces@lists.xenproject.org Thu Jul 28 23:10:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 23:10:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377209.610302 (Exim 4.92) (envelope-from ) id 1oHCeC-0000Py-1K; Thu, 28 Jul 2022 23:10:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377209.610302; Thu, 28 Jul 2022 23:10:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCeB-0000Pr-Td; Thu, 28 Jul 2022 23:10:27 +0000 Received: by outflank-mailman (input) for mailman id 377209; Thu, 28 Jul 2022 23:10:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCe9-0000Pl-Ju for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 23:10:26 +0000 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7458f1fc-0eca-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 01:10:22 +0200 (CEST) Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26SKJ0Od009624; Thu, 28 Jul 2022 23:10:03 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3hg940wjwn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 23:10:02 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 26SLTKMm017628; Thu, 28 Jul 2022 23:10:01 GMT Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04lp2168.outbound.protection.outlook.com [104.47.73.168]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3hh653sb4h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 28 Jul 2022 23:10:01 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) by BLAPR10MB5329.namprd10.prod.outlook.com (2603:10b6:208:307::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Thu, 28 Jul 2022 23:09:59 +0000 Received: from BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066]) by BLAPR10MB5009.namprd10.prod.outlook.com ([fe80::80e:be92:1fd5:b066%6]) with mapi id 15.20.5482.011; Thu, 28 Jul 2022 23:09:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7458f1fc-0eca-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2022-7-12; bh=DOQT/KUqlqsGczY6dMr3wVoRwKshwl33ymjdIQA2U1g=; b=jJR+5HASIdteoTMB+6GQ/X/AR6AUgzQdY6btt6RcZiv6djeKKx4CNnwSJr364wfi0L9z OycmK/UKHVemcTqnJpLjLQr7+IKys7bSh51foCIYHVCR3GYCCBnBeCXeGibV3AQjG28Y No4spX/KnFN2dnVdaFR7EA/SzcdyEqD8embhf75hXjY4fJwViSytIisYFeQsKOaDXFVz g2CITPcBQQuzOkguVVv3+wbiZngv61wo4fVEBoDSLOGDe5AjjfuHHDy/XCh8oUkoKrY/ j1kynhQURDN9MUH1hoYfT48QaX2LtPY3hfXNhF5rlAxHfKJlh5mnciuFkOdnLPgCwnbK rQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzCWH93LsbwdFfdaCY8bDO8UMs1c380yFP7crQTk/iWDAEi6CJshofcL8sF4pwrRKcrS2+2KVK4akdaUXkq+YLOa++VXfNV/BTWbOkRqmvmxFJ5fH2TE1CuhRwG66txtPN2ZGMswm4fi7Fn1tI/DQpIZ8AzdQE00VZZPnlElorUI+UpSB2qOCA3C7qia7GvkbVxHqy108GhP/heQRhUTE3EXtek7ANQ9tqiRRhR3viXXRnHHmqQhgkm4DQeiwAqIjSsbZgPeDnb0socjeLiAZUzEIcefwagilPJY27ilacv+ZJUxr2lUtw8ImSBsIgZ6/enOduIa2NwBnu+jsf2iZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DOQT/KUqlqsGczY6dMr3wVoRwKshwl33ymjdIQA2U1g=; b=Y4NzSirXCs6XKzZAKT20TRVmDWu/Gb90rzCtLY88Z6i0jJZu5ceKNlmwo8yK5eyM2UmYjMc+F8T8RMxvfyd+kXlv15YLim8IQfwSlZPq1VUS7hHgFlTAZRf7hS1KVE7vcw9f+k5dErLJwWo1VSECpfUNUjLx/blDOImpiXBolGhVohAnyS1tSx1gWbXT5FcObcbT/QTxBq1EUhHiSIY6xmVYVyrqrDG+TbTHMdsc/sFpTUs8Y3anUC4zYrby0p7dLJPbyp5uWGHfaga2FFbzEe4yx+VJwPkrQ9gx8kr47YudFaPwe5TG9LrMvICU1FQYZfpwjhNMRf3yhDPhfzFePg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DOQT/KUqlqsGczY6dMr3wVoRwKshwl33ymjdIQA2U1g=; b=xxIU/UZOs0aaYzbw50vI/EWBQJ9PAoULtOjWOnzwc8V9ak+dpL1eMM9woZElFLNI2IC8l3T3td9zEc81T/oLOfDynVlnBwE+mgPThL2JBHOfPMQMQs+HeDlXQDK1TQywvcGaBFYSPkuCwwl+aNJCj+Gq+W1MtJGsc9vaVd/i8fs= Message-ID: Date: Thu, 28 Jul 2022 19:09:56 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Content-Language: en-US To: Jane Malalane , LKML Cc: Juergen Gross , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , Maximilian Heyne , xen-devel@lists.xenproject.org References: <20220728125244.19163-1-jane.malalane@citrix.com> From: Boris Ostrovsky In-Reply-To: <20220728125244.19163-1-jane.malalane@citrix.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DS7PR03CA0220.namprd03.prod.outlook.com (2603:10b6:5:3ba::15) To BLAPR10MB5009.namprd10.prod.outlook.com (2603:10b6:208:321::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9270724a-64df-49c1-3e02-08da70ee4b3b X-MS-TrafficTypeDiagnostic: BLAPR10MB5329:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ojK0iE+SJoQJoeDz15RGwwkrJoG+s43Tc64IFj6tJWnLnTGPJinA55RP6Ge/EkhpcF+13i2tk3HaTRnCuyQnlaB45a1Z0C6eRKk7L4r4Gcz9Eo7vfD9NiNIa7+zfBV6rozaG3EorHcfLysYEZlNt8l4bEPoCBbP7U2TisQITFCU96XuGzBldjEd4VHKqVgHwA/X8WjP+vAIsjPYhUtJcezOtVTWLMHGjnQLCOASi1P2lYpWk1VqBhdG2WiA8VXuKVGROVamNk9yAIVQyKFxwJwUiwqQy5DnQ96wkaYygvlIBOC03Jfwqk/yoFoSMO8pId+i5XuvLkoYBeX5pvVs6nKBtzmycs3c+DDracEjTkQWshGFRIrsZN1YrZ+n1jY37kz2sFooxgk2TUIDvVqVx67mo6s12OUlUmJ08f4ldu3wGl5Qhak+AfufY00WvCbwy0wNfrW8ovaFmv3HYI9RTilNOQfB4985GU2qtcXEOZpp+DOVTRC+vCuKs6DeCzmu7oyqWIbkeh67E3BUzTmbpViSsLnJYaejtJTGWLInxeOUdkVUaaYpHD84cDCdno67MZ6ljNksBT26l82cZJULeE9vHULokba3RMwj9RjbvDOT6huoNPckq4O7DM781jbr2s6jwWPVEO3HYIccNqpUXF8W6a86tnsZpQRJcVmoUsfSa82j26796NwixbN2Fh9i5yGoZecz8EfQfGHlup2ZMq7z83iEB1Xla2/yxK1aFT4b/EEJ8GHWjs6TZrK+dzG9Afy28c3uty5xtcKv9oaG/W6pEYlqmZcLs24pyW8wZrJlMvH9cp6937pwHtW530qeFU+B57YlaE6+KlMf/zy19mQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BLAPR10MB5009.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(396003)(39860400002)(366004)(346002)(376002)(136003)(66476007)(6666004)(41300700001)(2906002)(31686004)(316002)(54906003)(86362001)(36756003)(31696002)(478600001)(66946007)(6486002)(110136005)(66556008)(2616005)(6506007)(53546011)(186003)(26005)(6512007)(8936002)(4326008)(8676002)(4744005)(5660300002)(44832011)(7416002)(38100700002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M1JscDdLZkIvZXVCUmY1S1RKdzIzU0xQamdaUGpJZ2lteWlxb0JEVGdoLzlz?= =?utf-8?B?bHJpSUYzREZJQWN0ZnVTQzZuWE95ZUtoRWR1QkZraW5QSVdyUUtYWXgwallq?= =?utf-8?B?VEhFQWZNNTN0QUEwUFBVMXR0SE5OazhmMkpZY1RDc2xqdlNkdkp2UEJhNmV4?= =?utf-8?B?c2R0akQ3SmdHWWJ3c3VlMitZT3ZVSG14cll5bnFSb0p2enlSSjFoOXlFbkVi?= =?utf-8?B?UGRMcE9nMGpFV29RWERTNXlNT1FjbkZJZkRYdnc0UW9ORVE3YThSOUtkbkkr?= =?utf-8?B?b0diN1RiNTU2UzRlRDNjOElOK2dPZjF2d3pLdjZKL3hKUk5aSjRvNDhITTh5?= =?utf-8?B?SEh3QmNlM1BYdFd6byt3QjMyMXZIclJSMmZ5NExTSGRCTFJBMCszcU1QNW5Z?= =?utf-8?B?S1FxT3lGZTRIWm5mMTlGa2E0SmZuY0hkRG02dGl4bGJidFk2T2d2V2JiZCtU?= =?utf-8?B?OTF0MVRoYU5yT1cwLzdNWGVVRXdPQjRBQTFhMVpzR1h1Q0xobzdsYVl1NnFE?= =?utf-8?B?ejFlWnFjRzdLWkNNbVFWSnV4V2lTalpScUxsNUpFR091RnU5Wno2OUJWczNC?= =?utf-8?B?YTVCS0JTTFE1TXpDZkw2U2x6WHJqY2JOZzFUc2kraXNmSXBGVXFEd0JlRUs2?= =?utf-8?B?ZEYzeVFuOHJXVy9jOWpidUYzUTNZZ2NtalVQc2F6bzJrU25NaU14VzJWSFR6?= =?utf-8?B?Uk9xT0R3NVd6WTM3NHlSVmJTMll1V0FETEpxaDEyMVZXaTJwN1VMWm1PVnpl?= =?utf-8?B?aEpVdUZTLzQ0dDNwVUlLZlNUMFRRUDhtM1ZlT3FuTEhPTThJU2U0U0hQSWxz?= =?utf-8?B?bFU3T2JTTi9xNjdiMWxWay90aDQycXErOEtxbnNCRi9HWXZEd1creDdqMjI0?= =?utf-8?B?cUdwZVBCYjRZeU5MNVdOb3ExcExibnVjTWNObTVPdmpNbmtYbmc1bUVUYjFC?= =?utf-8?B?Q211SnVOazBWTkVhWi9CNFpoSEVNek5tbGdVVTZOZURFWW9hak9FTTlSZ1Nl?= =?utf-8?B?YStVS3QyYUpVQ25GZXlyK2tSakF0WUx6dWFFWHh5VUhBU3FsQXJkcDhZZ3Na?= =?utf-8?B?bzBTd29CY0l1M1dNTjJubXFCVTFuaFpTd1EzZU5DbEFoSERNNlJwdG5RNzFX?= =?utf-8?B?eW81V3dURlZGeEtQWGV1azFsbFMyS3F3QThKNllyL0E3RnlHNEVFRHhwZThZ?= =?utf-8?B?eGpwMndPTlFFeGc1QjZQZkFIVGsyQTUyTTlqRnBCdm9pNzgxZ3JiUlZJcXR6?= =?utf-8?B?bFhCNEQ5VHA2TmxkOCtuS0tRQmxnZDdGbnZ6N051MkxHNjBTK2pCY3gxSmFp?= =?utf-8?B?SlYxZVZaQWZJaUZ0WjlUVkdBZnRwMmFNL3BnWXJ1Zm5MV3lUWXE3RnU5a1V6?= =?utf-8?B?UnRPdXo3eUp3aUtJT05OZUphT1Z5KzZxbFFva3BET0laZTBpaTc5TG4vek1C?= =?utf-8?B?OHJGVW94L25nKzRqZ3NBY3V0Ymd5eHM2UXlsMXhaMEZSZG1xLzZxcEozWVhs?= =?utf-8?B?b1hLWFVmb1RQOHhlTFlUUGFYSFhTNUhKekNubllxMzFEUUZydDNNWWhHSkVl?= =?utf-8?B?NDlzNG5YWCsvMysrZnc1emk0ZkIrZHVMa09TTm9qbGxaUUQ5Y0xOR0dQNUF5?= =?utf-8?B?YjZwTEpoMFpsOTlhUEQxS01JWjI0dklTVG9mOGp1Y1JDZzZXSlo2N1FPaG5N?= =?utf-8?B?bkpnSjJoQzV1QzNFdnJORVNMb0hrMHkvWjVsSCtrOHRxMmsrbEdqQTA0M1dT?= =?utf-8?B?Qm5nSWMvb0g3TGtiKzZRa2ZNdTA2QnVuQ2xTais1U0JobHJWM3FqUHRJUWJQ?= =?utf-8?B?VHJRY2VxN24zV1RqVlUvS01IYyt5Zi93NzY3L3R4VER6VksxVlJlT0ZNQzl6?= =?utf-8?B?QjNUZTZqOXRvWXYreHMzNXZsWFUxZUVBR3g5Mi9mVjRTZG9MaUZEN1FlRFhQ?= =?utf-8?B?SXNsYmNualdYZFcvQ0N6aTlLaHpBbTNDWk8yVDVnRi9sZGhPem5ybEdrbmsy?= =?utf-8?B?eTJoSWZkQVN6blV1RW8xb2NGODYrQWtnb3JBVnZZZThRcUQ5YWVrRjF6ck4v?= =?utf-8?B?Q1hxSWlmbjMvblNtRWxHMENzeUZ0T1VSbFZuRElsTUo3NFNFeGV3anVuK2or?= =?utf-8?B?eEp1MjVCNkt5Z3pJdzZ2bkFuK3YraXQ3RWhKbW1MdGkrVGhzNC9NanR4eVMy?= =?utf-8?B?UEE9PQ==?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9270724a-64df-49c1-3e02-08da70ee4b3b X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jul 2022 23:09:59.4453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MmRnvOExXnrvRn9eeAe7BwOC+cXoBjWoIv8Ql9LOoG/VlnM2a1XPb1ATpCNWWdXP6OMK3nwerGR9ZLh21M2Em7mry6jJoFKcAaMGQzluzCQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5329 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207280103 X-Proofpoint-GUID: ctTXCaCEqhwEuIkVB_W0YPIKmiVz2MNv X-Proofpoint-ORIG-GUID: ctTXCaCEqhwEuIkVB_W0YPIKmiVz2MNv On 7/28/22 8:52 AM, Jane Malalane wrote: > > +/* > + * Setup per-vCPU vector-type callbacks and trick toolstack to think The comment should be adjusted -- no need to mention toolstack now that that code has been factored out. Other than that Reviewed-by: Boris Ostrovsky > + * we are enlightened. If this setup is unavailable, fallback to the > + * global vector-type callback. > + */ > +static __init void xen_init_setup_upcall_vector(void) > +{ > From xen-devel-bounces@lists.xenproject.org Thu Jul 28 23:19:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Thu, 28 Jul 2022 23:19:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377221.610316 (Exim 4.92) (envelope-from ) id 1oHCmt-0001OX-1J; Thu, 28 Jul 2022 23:19:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377221.610316; Thu, 28 Jul 2022 23:19:27 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCms-0001OQ-Ts; Thu, 28 Jul 2022 23:19:26 +0000 Received: by outflank-mailman (input) for mailman id 377221; Thu, 28 Jul 2022 23:19:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHCmr-0001OK-Mt for xen-devel@lists.xenproject.org; Thu, 28 Jul 2022 23:19:25 +0000 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b6ff24c4-0ecb-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 01:19:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id F3812CE25F3; Thu, 28 Jul 2022 23:19:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E66C2C433C1; Thu, 28 Jul 2022 23:19:16 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b6ff24c4-0ecb-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659050357; bh=vOD2RLdtqPiq1yrJyzNY87OvIyyGZM/AfYEPKERJfNc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=TzAByCQPyyOJTgX7Nqten9UyP3OU7x0hGy8kg00PY1i6J7i40RL9zlcxfXvT6dU3r OMJmuRemaiRI5nkcOysPavP4MYUvY/IvZg8tR0Po03/Xbo5i7nEAH+tqnWa4kRNtIj dU8fxmp2luKu74ivvIEScxDPA0ykHo8tADWHgoUlLBJFKhkPmzIEvwZS7wGvDr3UHY qYUV4G7yU5ycWW2G9tTUW+LwGxzP0BaoKRABx/y5xdRAqB0TWSK9FuA9gn8czEjyQ4 cw5oymO6XrMcNXiJDyamPNI9SE32Rsy11doC6Ro1VeNhObxKUPq1GLJG23xAdw7cwS Pe1EaILBwx/5w== Date: Thu, 28 Jul 2022 16:19:15 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini , Penny Zheng Subject: Re: [PATCH v3 2/2] automation: arm64: Create a test job for testing static allocation on qemu In-Reply-To: <20220728075856.1175504-3-burzalodowa@gmail.com> Message-ID: References: <20220728075856.1175504-1-burzalodowa@gmail.com> <20220728075856.1175504-3-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Thu, 28 Jul 2022, Xenia Ragiadakou wrote: > Enable CONFIG_STATIC_MEMORY in the existing arm64 build. > > Create a new test job, called qemu-smoke-arm64-gcc-staticmem. > > Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a > new test variant. The test variant is determined based on the first argument > passed to the script. For testing static memory, the argument is 'static-mem'. > > The test configures DOM1 with a static memory region and adds a check in the > init script. > The check consists in comparing the contents of the /proc/device-tree > memory entry with the static memory range with which DOM1 was configured. > If the memory layout is correct, a message gets printed by DOM1. > > At the end of the qemu run, the script searches for the specific message > in the logs and fails if not found. > > Signed-off-by: Xenia Ragiadakou > Reviewed-by: Penny Zheng > --- > > Changes in v2: > - enable CONFIG_STATIC_MEMORY for all arm64 builds > - use the existing qemu-smoke-arm64.sh with an argument passed for > distinguishing between tests, instead of creating a new script > - test does not rely on kernel logs but prints a message itself on success > - remove the part that enables custom configs for arm64 builds > - add comments > - adapt commit message > > Changes in v3: > - refactor the changes to improve readability, no functionality change intended > - add Penny's R-b tag > > automation/gitlab-ci/test.yaml | 18 ++++++++++++++++++ > automation/scripts/build | 10 +++++++++- > automation/scripts/qemu-smoke-arm64.sh | 25 ++++++++++++++++++++++++- > 3 files changed, 51 insertions(+), 2 deletions(-) > > diff --git a/automation/gitlab-ci/test.yaml b/automation/gitlab-ci/test.yaml > index 26bdbcc3ea..6f9f64a8da 100644 > --- a/automation/gitlab-ci/test.yaml > +++ b/automation/gitlab-ci/test.yaml > @@ -80,6 +80,24 @@ qemu-smoke-arm64-gcc: > tags: > - arm64 > > +qemu-smoke-arm64-gcc-staticmem: > + extends: .test-jobs-common > + variables: > + CONTAINER: debian:unstable-arm64v8 > + script: > + - ./automation/scripts/qemu-smoke-arm64.sh static-mem 2>&1 | tee qemu-smoke-arm64.log > + needs: > + - debian-unstable-gcc-arm64 > + - kernel-5.9.9-arm64-export > + - qemu-system-aarch64-6.0.0-arm64-export > + artifacts: > + paths: > + - smoke.serial > + - '*.log' > + when: always > + tags: > + - arm64 > + > qemu-smoke-arm32-gcc: > extends: .test-jobs-common > variables: > diff --git a/automation/scripts/build b/automation/scripts/build > index 21b3bc57c8..2b9f2d2b54 100755 > --- a/automation/scripts/build > +++ b/automation/scripts/build > @@ -15,7 +15,15 @@ if [[ "${RANDCONFIG}" == "y" ]]; then > make -j$(nproc) -C xen KCONFIG_ALLCONFIG=tools/kconfig/allrandom.config randconfig > hypervisor_only="y" > else > - make -j$(nproc) -C xen defconfig > + if [[ "${XEN_TARGET_ARCH}" = "arm64" ]]; then > + echo " > +CONFIG_EXPERT=y > +CONFIG_UNSUPPORTED=y > +CONFIG_STATIC_MEMORY=y" > xen/.config > + make -j$(nproc) -C xen olddefconfig > + else > + make -j$(nproc) -C xen defconfig > + fi > fi > > # Save the config file before building because build failure causes the script > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 53086a5ac7..69d9eae7a9 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -2,6 +2,23 @@ > > set -ex > > +test_variant=$1 > + > +passed="BusyBox" > +check="" > + > +if [[ "${test_variant}" == "static-mem" ]]; then > + # Memory range that is statically allocated to DOM1 > + domu_base="50000000" > + domu_size="10000000" > + passed="${test_variant} test passed" > + check="current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) > +expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) > +if [[ \"\${expected}\" == \"\${current}\" ]]; then > + echo \"${passed}\" > +fi" > +fi I would make a minor code style improvement here: +if [[ "${test_variant}" == "static-mem" ]]; then + # Memory range that is statically allocated to DOM1 + domu_base="50000000" + domu_size="10000000" + passed="${test_variant} test passed" + check=" +current=\$(hexdump -e '16/1 \"%02x\"' /proc/device-tree/memory@${domu_base}/reg 2>/dev/null) +expected=$(printf \"%016x%016x\" 0x${domu_base} 0x${domu_size}) +if [[ \"\${expected}\" == \"\${current}\" ]]; then + echo \"${passed}\" +fi +" +fi I can do that on commit. Everything looks good. Reviewed-by: Stefano Stabellini From xen-devel-bounces@lists.xenproject.org Fri Jul 29 00:06:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 00:06:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377232.610336 (Exim 4.92) (envelope-from ) id 1oHDWN-0007wL-0P; Fri, 29 Jul 2022 00:06:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377232.610336; Fri, 29 Jul 2022 00:06:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHDWM-0007wE-TI; Fri, 29 Jul 2022 00:06:26 +0000 Received: by outflank-mailman (input) for mailman id 377232; Fri, 29 Jul 2022 00:06:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHDWK-0007w8-Rc for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 00:06:24 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2040.outbound.protection.outlook.com [40.107.93.40]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4725769b-0ed2-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 02:06:22 +0200 (CEST) Received: from BN9P221CA0027.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::21) by CH0PR12MB5217.namprd12.prod.outlook.com (2603:10b6:610:d0::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 00:06:19 +0000 Received: from BN8NAM11FT062.eop-nam11.prod.protection.outlook.com (2603:10b6:408:10a:cafe::9c) by BN9P221CA0027.outlook.office365.com (2603:10b6:408:10a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19 via Frontend Transport; Fri, 29 Jul 2022 00:06:19 +0000 Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT062.mail.protection.outlook.com (10.13.177.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5482.10 via Frontend Transport; Fri, 29 Jul 2022 00:06:18 +0000 Received: from SATLEXMB07.amd.com (10.181.41.45) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 19:06:16 -0500 Received: from SATLEXMB04.amd.com (10.181.40.145) by SATLEXMB07.amd.com (10.181.41.45) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Thu, 28 Jul 2022 17:06:07 -0700 Received: from localhost.localdomain (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server id 15.1.2375.28 via Frontend Transport; Thu, 28 Jul 2022 19:06:06 -0500 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4725769b-0ed2-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MWoYlRmHAgFGozXYu5km7RdPbB+pxTJJXp6/qc7YN6aPupwqgQdbzLjJqfVhqavSYPfzjFAEwcKovTXMpIw67PvUHNNmmooMtFs/90VOAfbyyH2rby/KucB+ZC5UCCqLK3hshITUb7rfjy3jXAW8CubXbnQzfIP8AwvbAZhai0RaP8yOw5u/PpH1IsbEJtxZWvCtZ9CcOgRfJJygVRhPduu1fHRwD7hRlJHvvs/swkd6vOt6JpJ5akzcHEbucRQpcL3RXcFgelkYQNDceohTUElxgZiOa6LKEJb/Ab3FmOJVUSaXhHMIY9iaiL2R1mdKRnxUC+cYfvDFH17Cb+vlzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DsbdAz4BaOsLgxRST17tVlkNQiwdcVM3FUhlcg5CDhk=; b=QBFwlPx+P7/TOKBpYxZMzY+HPLSZcDK0TPTprlTGKVal/LX3vJN/P1iI1s40eNpExj1dRVLsLirDGXHYjuub0t/t7OjRnPr6JaPoP2RuPRRPVUi5A515S2Lg/Q6//j4SMskU5fYXQrAKkHVc8lKT6ShoEUAjUxZQ7dfKKo9yeb5s/bxQy/EGO5cxy9FGjZW8hi3+Yt+KmtNcNHlq8ARl/JgyM8eQFBi/qJ9lkaZN83/fsUOrnf86G4Y8GKA6peFPT1DvmYkcLwgK5oobxVESRdxxUjBfgQsOS8PqRJSl2IOkEnPF5BZARyMc457K/jNcmpbmhsCLhq0YrKVYjg538A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DsbdAz4BaOsLgxRST17tVlkNQiwdcVM3FUhlcg5CDhk=; b=NyVm2dAgT7UBCJDhZ6rQQavQtYabGzABQuscavyPTAMzubnXebOZUuT/eoaJR4EK5Ny49txBW7NOxixGxVSSPO3XPpdjA2a9mvU1tM3w5TgmMd0pVcFffuz2iX2CQgsSSJLpfpb7/SGb09Ds7sG+a5ACNb8cnS7NeUiOqA4vwu0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C From: Stefano Stabellini To: CC: , , , Stefano Stabellini Subject: [PATCH] automation: disable xen,enhanced in qemu-smoke-arm64 Date: Thu, 28 Jul 2022 17:05:57 -0700 Message-ID: <20220729000557.2090845-1-stefano.stabellini@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fd2b9541-3c7e-4f96-65ff-08da70f629a0 X-MS-TrafficTypeDiagnostic: CH0PR12MB5217:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M1OaoKnAvDj7cQvxZGtox5z+ss4Vw/029ntEnVRuu2Fcf2wP44/MtqROre1O2/YtqQccj6f4n1/YyenDWHxmLuUX3oNjCbKCpujzXR7HyIsRHEuzgRaR/44XT3dEuRL35C5H8bUcaUzH3TZqq9tCeynU/jZygtSwkSJ4XcDPiPTHgxpZ9QVDVIsKeXUlW40nCmlqX18h3/aFT798rIJ7XzVvqReVdTQSC5Ckbp8qqGfogn+TEkjfeAAFDnygf4cVxf6O/zponf24sKg7lz/SsT1DA15RJGGVo7a2E4XW9c+war/jIpsY4E+ZUYu01uGYwMf8Bxqxv9GQfGY5GUrmyHk7lc7+J7aqNIwGKdJhkt+zJLKT5KvikiaXIs/7Oi63PhACjjYRDSa0V2x9HC4M/NalyQvtLnWrah2Dr739kMiAHa6c32JiqOMuasVDQCMR/wNPDG7nqkIsXemQcn7f8Iahs1ko7WZLtwa/y1gpGJO4t3Riyu+FreS8OVSKmuBfWTbYplWYo8AEoEeADmDEsLBUUFZL7syw64/rKuvKoKT2ZeHv09g1WUCJtF2DYE+l7MFkgA2pYps7eNGjraLomoS9w6bTfd4ZMuOLn9XCAEcU7kVidQ2gWQuRjb/EW2x9n6gKtdFubm/t+XzZ+x9d+VXQnfJDYgOuG3eRFLiYazZ7vUUb8dfE76NgS5HfHaLVU7ks1V4nmNpotE2Ppnea2n2URipaxvi60yRNqOd6Qa/ysnOr+nta7rnjx9RvMkoiomGwn4cXBvWvIQkzOPONOmJIo/ELOxlfvklpEupFeT1McQNlrdHMJg8gEe0OosC0DcKYv1HG5bGWANZP1LrteQ== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(376002)(136003)(396003)(346002)(36840700001)(40470700004)(46966006)(40460700003)(41300700001)(54906003)(478600001)(6666004)(6916009)(36860700001)(26005)(356005)(82740400003)(186003)(47076005)(336012)(2616005)(426003)(81166007)(44832011)(1076003)(4744005)(8936002)(5660300002)(316002)(2906002)(86362001)(82310400005)(70206006)(36756003)(40480700001)(4326008)(70586007)(8676002)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 00:06:18.8208 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fd2b9541-3c7e-4f96-65ff-08da70f629a0 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT062.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5217 Disable xen,enhanced because we don't use PV drivers in this test and also because the kernel used for testing is old and unpatched and would break if xen,enhanced is passed. This patch unbreaks gitlab-ci. Signed-off-by: Stefano Stabellini --- automation/scripts/qemu-smoke-arm64.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 898398196a..e6f1510c0f 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -84,6 +84,7 @@ NUM_DOMUS=1 DOMU_KERNEL[0]="Image" DOMU_RAMDISK[0]="initrd" DOMU_MEM[0]="256" +DOMU_ENHANCED[0]=0 LOAD_CMD="tftpb" UBOOT_SOURCE="boot.source" -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 01:04:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 01:04:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377248.610378 (Exim 4.92) (envelope-from ) id 1oHEQR-00054v-Kn; Fri, 29 Jul 2022 01:04:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377248.610378; Fri, 29 Jul 2022 01:04:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEQR-00054o-Hl; Fri, 29 Jul 2022 01:04:23 +0000 Received: by outflank-mailman (input) for mailman id 377248; Fri, 29 Jul 2022 01:04:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEQP-00054e-PH; Fri, 29 Jul 2022 01:04:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEQP-00054V-99; Fri, 29 Jul 2022 01:04:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEQO-0004XF-VM; Fri, 29 Jul 2022 01:04:21 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHEQO-0008GA-Uo; Fri, 29 Jul 2022 01:04:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Message-Id:Subject:To; bh=X35vZrCvJlE2cvCYMC7CnjEMdhMw6gZMzCexTQmVKsg=; b=ZgBap6xunoOReH+sxPUuiPpUK8 1a5TAIScc89GgL9cGJOf2aJ9Mdq1ALQexwEw+BpDpmPJ5y5dkrsGjGbSaxfBpm8YaZIK4sG7BcmOG QWK7m/H4HTnI8dB3GkHlor6OniMAaja7HwZ06KSLzPAbxbQGaSVBslVN5RIX9bseUZEw=; To: xen-devel@lists.xenproject.org Subject: [xen-unstable-smoke bisection] complete build-amd64-libvirt Message-Id: From: osstest service owner Date: Fri, 29 Jul 2022 01:04:20 +0000 branch xen-unstable-smoke xenbranch xen-unstable-smoke job build-amd64-libvirt testid libvirt-build Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171909/ commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie For bisection revision-tuple graph see: http://logs.test-lab.xenproject.org/osstest/results/bisect/xen-unstable-smoke/build-amd64-libvirt.libvirt-build.html Revision IDs in each graph node refer, respectively, to the Trees above. ---------------------------------------- Running cs-bisection-step --graph-out=/home/logs/results/bisect/xen-unstable-smoke/build-amd64-libvirt.libvirt-build --summary-out=tmp/171909.bisection-summary --basis-template=171884 --blessings=real,real-bisect,real-retry xen-unstable-smoke build-amd64-libvirt libvirt-build Searching for failure / basis pass: 171899 fail [host=himrod1] / 171884 ok. Failure / basis pass flights: 171899 / 171884 (tree with no url: minios) (tree with no url: ovmf) (tree with no url: seabios) Tree: libvirt git://xenbits.xen.org/libvirt.git Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git Tree: qemuu git://xenbits.xen.org/qemu-xen.git Tree: xen git://xenbits.xen.org/xen.git Latest 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 ca45d3cb4586372909f350e54482246f994e1bc7 Basis pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce Generating revisions with ./adhoc-revtuple-generator git://xenbits.xen.org/libvirt.git#2c846fa6bcc11929c9fb857a22430fb9945654ad-2c846fa6bcc11929c9fb857a22430fb9945654ad https://gitlab.com/keycodemap/keycodemapdb.git#27acf0ef828bf719b2053ba398b195829413dbdd-27acf0ef828bf719b2053ba398b195829413dbdd git://xenbits.xen.org/qemu-xen-traditional.git#3d273dd05e51e5a1ffba3d98c7437ee84e8f8764-3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 git://xenbits.xen.org/qemu-xen.git#b746458e1ce1bec85e58b458386f8b7a0bedf\ aa6-b746458e1ce1bec85e58b458386f8b7a0bedfaa6 git://xenbits.xen.org/xen.git#f732240fd3bac25116151db5ddeb7203b62e85ce-ca45d3cb4586372909f350e54482246f994e1bc7 Loaded 5001 nodes in revision graph Searching for test results: 171884 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce 171909 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 66dd1c62b2a3c707bd5c55750d10a8223fbd577f 171899 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 ca45d3cb4586372909f350e54482246f994e1bc7 171902 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce 171904 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 ca45d3cb4586372909f350e54482246f994e1bc7 171905 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 66dd1c62b2a3c707bd5c55750d10a8223fbd577f 171906 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce 171907 fail 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 66dd1c62b2a3c707bd5c55750d10a8223fbd577f 171908 pass 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce Searching for interesting versions Result found: flight 171884 (pass), for basis pass For basis failure, parent search stopping at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce, results HASH(0x557af26f7d68) HASH(0x557af2703340) HASH(0x557af2707f78) HASH(0x557af270bb08) Result found: flight 171899 (fail), for basis failure (at ancestor ~368) Repro found: flight 171902 (pass), for basis pass Repro found: flight 171904 (fail), for basis failure 0 revisions at 2c846fa6bcc11929c9fb857a22430fb9945654ad 27acf0ef828bf719b2053ba398b195829413dbdd 3d273dd05e51e5a1ffba3d98c7437ee84e8f8764 b746458e1ce1bec85e58b458386f8b7a0bedfaa6 f732240fd3bac25116151db5ddeb7203b62e85ce No revisions left to test, checking graph state. Result found: flight 171884 (pass), for last pass Result found: flight 171905 (fail), for first failure Repro found: flight 171906 (pass), for last pass Repro found: flight 171907 (fail), for first failure Repro found: flight 171908 (pass), for last pass Repro found: flight 171909 (fail), for first failure *** Found and reproduced problem changeset *** Bug is in tree: xen git://xenbits.xen.org/xen.git Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171909/ commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie Revision graph left in /home/logs/results/bisect/xen-unstable-smoke/build-amd64-libvirt.libvirt-build.{dot,ps,png,html,svg}. ---------------------------------------- 171909: tolerable ALL FAIL flight 171909 xen-unstable-smoke real-bisect [real] http://logs.test-lab.xenproject.org/osstest/logs/171909/ Failures :-/ but no regressions. Tests which did not succeed, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail baseline untested jobs: build-amd64-libvirt fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary From xen-devel-bounces@lists.xenproject.org Fri Jul 29 01:17:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 01:17:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377257.610390 (Exim 4.92) (envelope-from ) id 1oHEd1-00073Z-UJ; Fri, 29 Jul 2022 01:17:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377257.610390; Fri, 29 Jul 2022 01:17:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEd1-00073S-Qy; Fri, 29 Jul 2022 01:17:23 +0000 Received: by outflank-mailman (input) for mailman id 377257; Fri, 29 Jul 2022 01:17:22 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHEcz-00073M-I4 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 01:17:22 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2053.outbound.protection.outlook.com [40.107.21.53]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ed33003-0edc-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 03:17:16 +0200 (CEST) Received: from AS9P250CA0006.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:532::14) by DBBPR08MB4539.eurprd08.prod.outlook.com (2603:10a6:10:cf::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Fri, 29 Jul 2022 01:17:12 +0000 Received: from AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:532:cafe::b2) by AS9P250CA0006.outlook.office365.com (2603:10a6:20b:532::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 01:17:11 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT052.mail.protection.outlook.com (10.152.17.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 01:17:11 +0000 Received: ("Tessian outbound 63c09d5d38ac:v123"); Fri, 29 Jul 2022 01:17:11 +0000 Received: from 497357faeef0.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 072FF2AA-4494-4FCB-9AFD-E89C13764F64.1; Fri, 29 Jul 2022 01:17:01 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 497357faeef0.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Jul 2022 01:17:01 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com (2603:10a6:102:2b9::9) by DB6PR0801MB2087.eurprd08.prod.outlook.com (2603:10a6:4:77::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Fri, 29 Jul 2022 01:16:58 +0000 Received: from PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::cc0c:d374:3a17:c923]) by PAXPR08MB7420.eurprd08.prod.outlook.com ([fe80::cc0c:d374:3a17:c923%5]) with mapi id 15.20.5482.010; Fri, 29 Jul 2022 01:16:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ed33003-0edc-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=P0ZmSpqEGVFqXTNMD/vG0eiSSKct2x4XMfalAgHh2ilwfyn5Jrx/VZ9y+1gu0DAb5KxKdANNxjS3GP1qSysPiMSWQSIWJ682tilG2AqHJJRWPOri25sFk+Dul3TTys6Pdd1vaCiWFSZLt3MfzOONiDPx/UwMiK/RMsYjrIrkC+/ETV3sUy9qmBHEvOEfsopxGZrSsTZx7pyf+9OCtJSa2rrEA8zxKm4mVRRG01W0uKkWyx8/8qjcLSFi6knZCww+wZ8e376vmd7+x0WC9AUSB4r5+ZSaDSPNvIlnialbxoKwr95UBGEbr5LeutOzcRiqULgy7MyClEn86aljGTln/w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ewuZyjYobsOyEbotOfs2Au4KvveFxRtqUycK68jg0Ng=; b=P1OCDZNQw+UKBwTSxlvGrndYLIY19Vor49BS3PfIKnemif0VqICdFD9T1rLinSpcVCxizvUL/FSgsU4eWYmPEn4dH17YxA5d/n3i1yJT/0L9t1jXbHv3aRP1a+Sv/4l6V47vI/ZtKmLs7ePidlFIzu3Ws1uQ6n0xo59gRVpf8pBB9RH2OOQBnsi+3JDyf9yVubXuE5948B/b6pMs04YA9Jak1LyTCDEA5Y4ys/XC1Oczy6gIPKD9i+300G+TlqpwMC8B8xj6mbta1ADTPxWLqfMiQWL/qDwFo/HWUXXR5AVI85dwVatV8P+zOTmvHOZ6zdYvf5RtDAMYd/1ibKsBxw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewuZyjYobsOyEbotOfs2Au4KvveFxRtqUycK68jg0Ng=; b=em79NV/dnMUA7ILAPjjIqvg+U3ENM1/W7VyAk6zplGRDNCPfixT8RJ1KIWS/Vuc8uvUTTg+td4EcQ5NWgeFlvSVFY3o4WbXkByxR/hEDVqXEwJ1PVR9TC6lbs8XKvgpTk/mkk/KJ8IIJrtwWWbLliZuCYhnu4Ux2YE0lV9DvOVg= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAg4tWywA00NcHC877hWzyi7kVM2FR+6W9zS2cSj1Co4HhWs/tax0PFrwNdTvHbfw7lU5T6BmOkaNsL/p6HJHBYVQqdr5E/9APPzT4eUO1zg2q9am5vtJ+WrTUOkXbOZdzVUTyHv0NafIiUp5DCLvveudczcn4JHBQHjECJD9zEeesZsh6fD/VhXhkR3VSNZhpNpRwGfgSCr9uLO63BPm8c7ikY70g82HTnp0jDEdaSheIQwGIDPz0+uS9It9OeyD2YWv/VpgmhOshekEkYXP1RiZoDwksvNUkXZf9q0h1KfaRHXZqMQdddN9dsMmJoCdvq7WxC0Qft5HlGOIoKwdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ewuZyjYobsOyEbotOfs2Au4KvveFxRtqUycK68jg0Ng=; b=CzF9s1PQcmGsZTJghrVnlt2V3vO5bepvUkwHKUvVuFFvUjno9pI8PM0Q1JyL0VNRmf2KbaldgB7JgyGDMqrOj7KilTq5T6OATbCS8feYU9PYxVTpiZxiZk5VdQM8CMPdpEEoU6X40BXqCMDFsEyknolrxYgRBh5qFHXSbZPnNxsyzLgDj5UXLXvJqBSJJFtjNk4WUhtTWfDp8hEjyYRVoDaACdlpiyj5URXN0SMT2QpCNVRNLr0EQHV7fd/2Rc9KRdt2MD+Q1Or8c8HsOh61gnAq2/ksbENK7ARwEEIsA84Sgauhdi7xEOBqSukE7/gEe2kGMtoVF8OozMlvt1PdSA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ewuZyjYobsOyEbotOfs2Au4KvveFxRtqUycK68jg0Ng=; b=em79NV/dnMUA7ILAPjjIqvg+U3ENM1/W7VyAk6zplGRDNCPfixT8RJ1KIWS/Vuc8uvUTTg+td4EcQ5NWgeFlvSVFY3o4WbXkByxR/hEDVqXEwJ1PVR9TC6lbs8XKvgpTk/mkk/KJ8IIJrtwWWbLliZuCYhnu4Ux2YE0lV9DvOVg= From: Wei Chen To: Stefano Stabellini CC: "xen-devel@lists.xenproject.org" , "julien@xen.org" , Bertrand Marquis , Penny Zheng Subject: RE: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1) Thread-Topic: Proposal for Porting Xen to Armv8-R64 - DraftC (Archive for Day1) Thread-Index: AdhiiZ/pFQ8D6hDLSDWFvMIljUxbzRANPcyAAAo4ruA= Date: Fri, 29 Jul 2022 01:16:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ts-tracking-id: AE33BBAE95B31D42A5A86175EC0F77E5.0 x-checkrecipientchecked: true Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 897e60cb-8816-4b64-5778-08da7100106a x-ms-traffictypediagnostic: DB6PR0801MB2087:EE_|AM5EUR03FT052:EE_|DBBPR08MB4539:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BULAT89ngaf5lQ6xb23nH7Ep+KsU5wgOFV4dDkseyHtFRXOLgdByxn5ZfYv2/tPEvgrFtm8t9PrTczpo5XBso0tr1lXNkde1OptIWKtkB4p4Cae9GK8SDtZdsJHe+py+tNpKOn4jJ71QdCXQZxm2+c+RHCXFTjb31tgDI8TuvT46oCyZoOfD0+3JyFYd2iqCd8MvQIm4hzrnfHBYvtAWRK8KKldeUmgQkZSlpzLfUGYPKTD42O36eRvYZ7qvyabmOlt/eHlzz5788I5to7ReJlh59grUbZtzGFWFVPJLW7yEx870yWQhXPlp2YnKxdrVgpRAD3gjIyH6ahkZVwBm6j6XotB/exIt/KYlXSXjWFio4OoSaa7cSBwXoC3IYfk66AKfrGnGr5PevOqOQgdlrXB+jcgjMrG0tzd+vpeIdMcFBwl0Wd8oGys64RxQ4PHMWyG6q11YS6V62Qz84tu4YdMVeVsB7uSiW28pxZ385QwByuldVOVWd/TCYH4Upk3AeGRPl3pLN0RwV+vDWZyI6170QyCBFc30nutZlOWpbrNy1PjjkmGBZN4Aj1gIgmXQMczbxM4OqeCoXNJRSNJQL37V/fERcUDxQL2wTZyKjmcS1qAwGu1yad+rHgf+H64WvM0NyLY38K2MVd/AECunfkmHV/iQsg9PNs1pKlnZe7t7IIg26d1h5orLeaVbf3AYLm6wO64RgWmBDAEQbJDRXzJxqZxJfeKvmiGVa8cdLP9xO5x/pkbMZkTL9DRp9h0KXTGsWHcRWtw4K2VfoNe6bJpbYbFvtnjIlPoDKGy4O5WoI7ThBuSokRU2DbAtDGPgw8jpmn585xf25wkTa03gwUEkMJVJVQSeuI0AvnxtFwrLoXQQlnv5JIk3aGqoCtM3DM/PLUd2Su8Wc8B2Buvyrg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7420.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(366004)(39860400002)(136003)(396003)(38070700005)(8936002)(7696005)(6506007)(2906002)(8676002)(66946007)(66556008)(66476007)(41300700001)(76116006)(86362001)(5660300002)(64756008)(66446008)(4326008)(71200400001)(478600001)(52536014)(55016003)(30864003)(316002)(54906003)(122000001)(186003)(26005)(9686003)(38100700002)(33656002)(83380400001)(53546011)(6916009)(21314003)(559001)(579004);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB2087 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c1e025d8-d0be-4ade-eb0c-08da71000834 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CGX6uCu9I8505nq4RPN4Gai1/MBBYNK1aw8hTmm1M4ynzWZ77mCr0XGp/Y6wdofLWmApNv3L9vQOBhElEdtAgYPiZTLx6NAsIRU6NBfaRmP1f0LRo9t7pEbwS91RxMcdi+GXrKlcD7i9cinN3TdA/ejxzicEEsUJf0lPxToDi3pYxnFwmp2Zx1JkxzETZDQb1XS1Zrfjhqbnb+WucwRgkp2ChCqvhw6N+JkM+SWFk5iOky8jSh8le7Qa/q+et+InD+s2ixEgPrkPOwJf7pQME5/jhfIBxO0trlVFR9DQsCWsks7HFEd3CgMGBhl2b3ta9bzTqpHZ+QRwLviUekZAsPq/dRqUKJsqM1vbiNByZYwLq/whytVAVDqroHVhOiRbMyBWojvIl2HeQzhkQGfdycR6UoaOSmBqn//qtwzc3t0YfPfhaZNLPEThQ8mttcdW/g3V4CkEg0ewkgb12LNqTFh777mZ2KpE0/5DbyqJBEeWHdEISWmjh2cy4D4bMYHwZmVpP+qL973DE0tqSmrOFbM2bvGE91ddMC3zhgTQPwiU3EpQIs/1nRDhZ4aWLGmzx8ew2VmlVLjILVBiTF7jZ0j2yd5i7TdMQNCiQ/BMaAuQX0jn6o8x35nitE/IdnQMJI0Y9mk02d5I1tLSAmrG4agbbsFew9KFe3yjZIkADNeUAMVnXM8t+mlKQDEDSnRkrmjn9KY7TNey7RVH0xnGC3J19epS4SCqXS62MZ/gZLHLsN99+Xi8zPEonH5jxNyoWeVBrbWla3kCupFjicjZ6+Ev0safxGyf+JaPiDnAc3VamzF0V+qC1xHEGn2FOtD3w0VBDwgDoGMilp+dn2AFGvgs6N27mdnI4gjdLeRflYh2ijXNlmNh7gA8pANbOlPvoQNIk4swgJEn4H0JYj1Auw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(346002)(376002)(396003)(39860400002)(136003)(46966006)(36840700001)(40470700004)(70206006)(40460700003)(9686003)(26005)(41300700001)(53546011)(2906002)(7696005)(6506007)(336012)(33656002)(478600001)(5660300002)(6862004)(186003)(52536014)(47076005)(8936002)(86362001)(30864003)(83380400001)(316002)(8676002)(81166007)(82740400003)(82310400005)(36860700001)(356005)(55016003)(40480700001)(70586007)(4326008)(54906003)(21314003)(579004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 01:17:11.4908 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 897e60cb-8816-4b64-5778-08da7100106a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT052.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4539 SGkgU3RlZmFubywNCg0KPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBTdGVm YW5vIFN0YWJlbGxpbmkgPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+DQo+IFNlbnQ6IDIwMjLE6jfU wjI5yNUgNDoxNA0KPiBUbzogV2VpIENoZW4gPFdlaS5DaGVuQGFybS5jb20+DQo+IENjOiB4ZW4t ZGV2ZWxAbGlzdHMueGVucHJvamVjdC5vcmc7IGp1bGllbkB4ZW4ub3JnOyBTdGVmYW5vIFN0YWJl bGxpbmkNCj4gPHNzdGFiZWxsaW5pQGtlcm5lbC5vcmc+OyBCZXJ0cmFuZCBNYXJxdWlzIDxCZXJ0 cmFuZC5NYXJxdWlzQGFybS5jb20+Ow0KPiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNv bT4NCj4gU3ViamVjdDogUmU6IFByb3Bvc2FsIGZvciBQb3J0aW5nIFhlbiB0byBBcm12OC1SNjQg LSBEcmFmdEMgKEFyY2hpdmUgZm9yDQo+IERheTEpDQo+IA0KPiBIaSBXZWksDQo+IA0KPiBJIGFt IHJlYWxseSBzb3JyeSBJIGRpZG4ndCBtYW5hZ2UgdG8gcmVhZCB0aGlzIHByb3Bvc2FsIGJlZm9y ZSBub3cuIFRvbw0KPiBtYW55IHRoaW5ncyA6LSkNCj4gDQoNCkl0IGRvZXNuJ3QgbWF0dGVyIDog KQ0KDQo+IElzIGl0IHN0aWxsIHZhbGlkPyBEbyB5b3Ugd2FudCBtZSB0byByZWFkIGl0IGluIHRo ZSBuZXh0IGRheXMsIG9yIGRvIHlvdQ0KPiBoYXZlIGFub3RoZXIgdXBkYXRlIHlvdSB3b3VsZCBy YXRoZXIgc2VuZCBmaXJzdD8NCj4gDQoNClllcyBpdCdzIHN0aWxsIHZhbGlkLCBvdXIgZGF5MSBw YXRjaCBoYXNuJ3QgYmVlbiBzZW50IGJlY2F1c2Ugd2UgYXJlIHdhbnQNCnNvbWUgcHJlLXNlcmll cyBmcm9tIEhlbnJ5IHRvIGJlIG1lcmdlZCBmaXJzdC4gSWYgeW91IGNhbiBnaXZlIG1vcmUgY29t bWVudHMsDQp3ZSBjYW4gYWxzbyBtYWtlIGNoYW5nZXMgZm9yIGRheSAxIHBhdGNoZXMgYW5kIHVw ZGF0ZSB0aGUgcHJvcG9zYWwuDQoNCkNoZWVycywNCldlaSBDaGVuDQoNCj4gQ2hlZXJzLA0KPiAN Cj4gU3RlZmFubw0KPiANCj4gDQo+IE9uIFN1biwgOCBNYXkgMjAyMiwgV2VpIENoZW4gd3JvdGU6 DQo+ID4gIyBQcm9wb3NhbCBmb3IgUG9ydGluZyBYZW4gdG8gQXJtdjgtUjY0DQo+ID4NCj4gPiAo VXBkYXRlIHRvIERyYWZ0LUMgYXMgYSBkaXNjdXNzaW9uIGFyY2hpdmUgZm9yIERheTEgcGF0Y2hl cykNCj4gPg0KPiA+IFRoaXMgcHJvcG9zYWwgd2lsbCBpbnRyb2R1Y2UgdGhlIFBvQyB3b3JrIG9m IHBvcnRpbmcgWGVuIHRvIEFybXY4LVI2NCwNCj4gPiB3aGljaCBpbmNsdWRlczoNCj4gPiAtIFRo ZSBjaGFuZ2VzIG9mIGN1cnJlbnQgWGVuIGNhcGFiaWxpdHksIGxpa2UgWGVuIGJ1aWxkIHN5c3Rl bSwgbWVtb3J5DQo+ID4gICBtYW5hZ2VtZW50LCBkb21haW4gbWFuYWdlbWVudCwgdkNQVSBjb250 ZXh0IHN3aXRjaC4NCj4gPiAtIFRoZSBleHBhbmRlZCBYZW4gY2FwYWJpbGl0eSwgbGlrZSBzdGF0 aWMtYWxsb2NhdGlvbiBhbmQgZGlyZWN0LW1hcC4NCj4gPg0KPiA+ICoqKk5vdGVzOioqKg0KPiA+ IDEuICoqKlRoaXMgcHJvcG9zYWwgb25seSBjb3ZlcnMgdGhlIHdvcmsgb2YgcG9ydGluZyBYZW4g dG8gQXJtdjgtUjY0KioqDQo+ID4gICAgKioqc2luZ2xlIENQVS5YZW4gU01QIHN1cHBvcnQgb24g QXJtdjgtUjY0IHJlbGF0ZXMgdG8gQXJtdjgtUioqKg0KPiA+ICAgICoqKlRydXN0ZWQtRnJpbXdh cmUgKFRGLVIpLiBUaGlzIGlzIGFuIGV4dGVybmFsIGRlcGVuZGVuY3ksKioqDQo+ID4gICAgKioq c28gd2UgdGhpbmsgdGhlIGRpc2N1c3Npb24gb2YgWGVuIFNNUCBzdXBwb3J0IG9uIEFybXY4LVI2 NCoqKg0KPiA+ICAgICoqKnNob3VsZCBiZSBzdGFydGVkIHdoZW4gc2luZ2xlLUNQVSBzdXBwb3J0 IGlzIGNvbXBsZXRlLioqKg0KPiA+IDIuICoqKlRoaXMgcHJvcG9zYWwgd2lsbCBub3QgdG91Y2gg eGVuLXRvb2xzLiBJbiBjdXJyZW50IHN0YW5nZSwqKioNCj4gPiAgICAqKipYZW4gb24gQXJtdjgt UjY0IG9ubHkgc3VwcG9ydCBkb20wbGVzcywgYWxsIGd1ZXN0cyBzaG91bGQqKioNCj4gPiAgICAq KipiZSBib290ZWQgZnJvbSBkZXZpY2UgdHJlZS4qKioNCj4gPg0KPiA+ICMjIENoYW5nZWxvZ3MN Cj4gPiBEcmFmdC1CIC0+IERyYWZ0LUM6DQo+ID4gMS4gVXBkYXRlIHRoZSBldmVudC1jaGFubmVs IHN1cHBvcnQgc2VjdGlvbiB0byB1c2UgcnVudGltZQ0KPiA+ICAgIE1QVSBtYXBwaW5nIGluc3Rl YWQgb2Ygd2hvbGUgTVBVIGNvbnRleHQgc3dpdGNoLg0KPiA+IDIuIFNwbGl0IHR3byBzdGFnZXMg Zm9yIEFybXY4LVI2NCBYZW4gc3RhcnQgYWRkcmVzcyBzb2x1dGlvbi4NCj4gPiAzLiBSZW1vdmUg Im1hbGljaW91cyB0b29scyIuDQo+ID4gNC4gUmVtb3ZlIEdDQyB2ZXJzaW9uIGJ1bXAuDQo+ID4N Cj4gPiBEcmFmdC1BIC0+IERyYWZ0LUI6DQo+ID4gMS4gVXBkYXRlIEtjb25maWcgb3B0aW9ucyB1 c2FnZS4NCj4gPiAyLiBVcGRhdGUgdGhlIHNlY3Rpb24gZm9yIFhFTl9TVEFSVF9BRERSRVNTLg0K PiA+IDMuIEFkZCBkZXNjcmlwdGlvbiBvZiBNUFUgaW5pdGlhbGl6YXRpb24gYmVmb3JlIHBhcnNp bmcgZGV2aWNlIHRyZWUuDQo+ID4gNC4gUmVtb3ZlIENPTkZJR19BUk1fTVBVX0VMMV9QUk9URUNU SU9OX1JFR0lPTlMuDQo+ID4gNS4gVXBkYXRlIHRoZSBkZXNjcmlwdGlvbiBvZiBpb3JlbWFwX25v Y2FjaGUvY2FjaGUuDQo+ID4gNi4gVXBkYXRlIGFib3V0IHRoZSBmcmVlX2luaXRfbWVtb3J5IG9u IEFybXY4LVIuDQo+ID4gNy4gRGVzY3JpYmUgd2h5IHdlIG5lZWQgdG8gc3dpdGNoIHRoZSBNUFUg Y29uZmlndXJhdGlvbiBsYXRlci4NCj4gPiA4LiBBZGQgYWx0ZXJuYXRpdmUgcHJvcG9zYWwgaW4g VE9ETy4NCj4gPiA5LiBBZGQgdXNlIHRvb2wgdG8gZ2VuZXJhdGUgWGVuIEFybXY4LVIgZGV2aWNl IHRyZWUgaW4gVE9ETy4NCj4gPiAxMC4gQWRkIFhlbiBQSUMvUElFIGRpc2N1c3Npb24gaW4gVE9E Ty4NCj4gPiAxMS4gQWRkIFhlbiBldmVudCBjaGFubmVsIHN1cHBvcnQgaW4gVE9ETy4NCj4gPg0K PiA+ICMjIENvbnRyaWJ1dG9yczoNCj4gPiBXZWkgQ2hlbiA8V2VpLkNoZW5AYXJtLmNvbT4NCj4g PiBQZW5ueSBaaGVuZyA8UGVubnkuWmhlbmdAYXJtLmNvbT4NCj4gPg0KPiA+ICMjIDEuIEVzc2Vu dGlhbCBCYWNrZ3JvdW5kDQo+ID4NCj4gPiAjIyMgMS4xLiBBcm12OC1SNjQgUHJvZmlsZQ0KPiA+ IFRoZSBBcm12LVIgYXJjaGl0ZWN0dXJlIHByb2ZpbGUgd2FzIGRlc2lnbmVkIHRvIHN1cHBvcnQg dXNlIGNhc2VzIHRoYXQNCj4gPiBoYXZlIGEgaGlnaCBzZW5zaXRpdml0eSB0byBkZXRlcm1pbmlz dGljIGV4ZWN1dGlvbi4gKGUuZy4gRnVlbCBJbmplY3Rpb24sDQo+ID4gQnJha2UgY29udHJvbCwg RHJpdmUgdHJhaW5zLCBNb3RvciBjb250cm9sIGV0YykNCj4gPg0KPiA+IEFybSBhbm5vdW5jZWQg QXJtdjgtUiBpbiAyMDEzLCBpdCBpcyB0aGUgbGF0ZXN0IGdlbmVyYXRpb24gQXJtDQo+IGFyY2hp dGVjdHVyZQ0KPiA+IHRhcmdldGVkIGF0IHRoZSBSZWFsLXRpbWUgcHJvZmlsZS4gSXQgaW50cm9k dWNlcyB2aXJ0dWFsaXphdGlvbiBhdCB0aGUNCj4gaGlnaGVzdA0KPiA+IHNlY3VyaXR5IGxldmVs IHdoaWxlIHJldGFpbmluZyB0aGUgUHJvdGVjdGVkIE1lbW9yeSBTeXN0ZW0gQXJjaGl0ZWN0dXJl DQo+IChQTVNBKQ0KPiA+IGJhc2VkIG9uIGEgTWVtb3J5IFByb3RlY3Rpb24gVW5pdCAoTVBVKS4g SW4gMjAyMCwgQXJtIGFubm91bmNlZCBDb3J0ZXgtDQo+IFI4MiwNCj4gPiB3aGljaCBpcyB0aGUg Zmlyc3QgQXJtIDY0LWJpdCBDb3J0ZXgtUiBwcm9jZXNzb3IgYmFzZWQgb24gQXJtdjgtUjY0Lg0K PiA+DQo+ID4gLSBUaGUgbGF0ZXN0IEFybXY4LVI2NCBkb2N1bWVudCBjYW4gYmUgZm91bmQgaGVy ZToNCj4gPiAgIFtBcm0gQXJjaGl0ZWN0dXJlIFJlZmVyZW5jZSBNYW51YWwgU3VwcGxlbWVudCAt IEFybXY4LCBmb3IgQXJtdjgtUg0KPiBBQXJjaDY0IGFyY2hpdGVjdHVyZQ0KPiBwcm9maWxlXSho dHRwczovL2RldmVsb3Blci5hcm0uY29tL2RvY3VtZW50YXRpb24vZGRpMDYwMC9sYXRlc3QvKS4N Cj4gPg0KPiA+IC0gQXJtdi1SIEFyY2hpdGVjdHVyZSBwcm9ncmVzc2lvbjoNCj4gPiAgIEFybXY3 LVIgLT4gQXJtdjgtUiBBQXJjaDMyIC0+IEFybXY4IEFBcmNoNjQNCj4gPiAgIFRoZSBmb2xsb3dp bmcgZmlndXJlIGlzIGEgc2ltcGxlIGNvbXBhcmlzb24gb2YgIlIiIHByb2Nlc3NvcnMgYmFzZWQg b24NCj4gPiAgIGRpZmZlcmVudCBBcm12LVIgQXJjaGl0ZWN0dXJlcy4NCj4gPiAgICFbaW1hZ2Vd KGh0dHBzOi8vZHJpdmUuZ29vZ2xlLmNvbS91Yz9leHBvcnQ9dmlldyZpZD0xbkU1UkFYYVg4elky S1BaOGkNCj4gbUJwYnZJcjJlcUJndUVCKQ0KPiA+DQo+ID4gLSBUaGUgQXJtdjgtUiBhcmNoaXRl Y3R1cmUgZXZvbHZlZCBhZGRpdGlvbmFsIGZlYXR1cmVzIG9uIHRvcCBvZiBBcm12Ny1SOg0KPiA+ ICAgICAtIEFuIGV4Y2VwdGlvbiBtb2RlbCB0aGF0IGlzIGNvbXBhdGlibGUgd2l0aCB0aGUgQXJt djgtQSBtb2RlbA0KPiA+ICAgICAtIFZpcnR1YWxpemF0aW9uIHdpdGggc3VwcG9ydCBmb3IgZ3Vl c3Qgb3BlcmF0aW5nIHN5c3RlbXMNCj4gPiAgICAgICAgIC0gUE1TQSB2aXJ0dWFsaXphdGlvbiB1 c2luZyBNUFVzIEluIEVMMi4NCj4gPiAtIFRoZSBuZXcgZmVhdHVyZXMgb2YgQXJtdjgtUjY0IGFy Y2hpdGVjdHVyZQ0KPiA+ICAgICAtIEFkZHMgc3VwcG9ydCBmb3IgdGhlIDY0LWJpdCBBNjQgaW5z dHJ1Y3Rpb24gc2V0LCBwcmV2aW91c2x5IEFybXY4LQ0KPiBSDQo+ID4gICAgICAgb25seSBzdXBw b3J0ZWQgQTMyLg0KPiA+ICAgICAtIFN1cHBvcnRzIHVwIHRvIDQ4LWJpdCBwaHlzaWNhbCBhZGRy ZXNzaW5nLCBwcmV2aW91c2x5IHVwIHRvIDMyLWJpdA0KPiA+ICAgICAgIGFkZHJlc3Npbmcgd2Fz IHN1cHBvcnRlZC4NCj4gPiAgICAgLSBPcHRpb25hbCBBcm0gTmVvbiB0ZWNobm9sb2d5IGFuZCBB ZHZhbmNlZCBTSU1EDQo+ID4gICAgIC0gU3VwcG9ydHMgdGhyZWUgRXhjZXB0aW9uIExldmVscyAo RUxzKQ0KPiA+ICAgICAgICAgLSBTZWN1cmUgRUwyIC0gVGhlIEhpZ2hlc3QgUHJpdmlsZWdlLCBN UFUgb25seSwgZm9yIGZpcm13YXJlLA0KPiBoeXBlcnZpc29yDQo+ID4gICAgICAgICAtIFNlY3Vy ZSBFTDEgLSBSaWNoT1MgKE1NVSkgb3IgUlRPUyAoTVBVKQ0KPiA+ICAgICAgICAgLSBTZWN1cmUg RUwwIC0gQXBwbGljYXRpb24gV29ya2xvYWRzDQo+ID4gICAgIC0gT3B0aW9uYWxseSBzdXBwb3J0 cyBWaXJ0dWFsIE1lbW9yeSBTeXN0ZW0gQXJjaGl0ZWN0dXJlIGF0IFMtRUwxL1MtDQo+IEVMMC4N Cj4gPiAgICAgICBUaGlzIG1lYW5zIGl0J3MgcG9zc2libGUgdG8gcnVuIHJpY2ggT1Mga2VybmVs cyAtIGxpa2UgTGludXggLQ0KPiBlaXRoZXINCj4gPiAgICAgICBiYXJlLW1ldGFsIG9yIGFzIGEg Z3Vlc3QuDQo+ID4gLSBEaWZmZXJlbmNlcyB3aXRoIHRoZSBBcm12OC1BIEFBcmNoNjQgYXJjaGl0 ZWN0dXJlDQo+ID4gICAgIC0gU3VwcG9ydHMgb25seSBhIHNpbmdsZSBTZWN1cml0eSBzdGF0ZSAt IFNlY3VyZS4gVGhlcmUgaXMgbm90IE5vbi0NCj4gU2VjdXJlDQo+ID4gICAgICAgZXhlY3V0aW9u IHN0YXRlIHN1cHBvcnRlZC4NCj4gPiAgICAgLSBFTDMgaXMgbm90IHN1cHBvcnRlZCwgRUwyIGlz IG1hbmRhdG9yeS4gVGhpcyBtZWFucyBzZWN1cmUgRUwyIGlzDQo+IHRoZQ0KPiA+ICAgICAgIGhp Z2hlc3QgRUwuDQo+ID4gICAgIC0gU3VwcG9ydHMgdGhlIEE2NCBJU0EgaW5zdHJ1Y3Rpb24NCj4g PiAgICAgICAgIC0gV2l0aCBhIHNtYWxsIHNldCBvZiB3ZWxsLWRlZmluZWQgZGlmZmVyZW5jZXMN Cj4gPiAgICAgLSBQcm92aWRlcyBhIFBNU0EgKFByb3RlY3RlZCBNZW1vcnkgU3lzdGVtIEFyY2hp dGVjdHVyZSkgYmFzZWQNCj4gPiAgICAgICB2aXJ0dWFsaXphdGlvbiBtb2RlbC4NCj4gPiAgICAg ICAgIC0gQXMgb3Bwb3NlZCB0byBBcm12OC1BIEFBcmNoNjQncyBWTVNBIGJhc2VkIFZpcnR1YWxp emF0aW9uDQo+ID4gICAgICAgICAtIENhbiBzdXBwb3J0IGFkZHJlc3MgYml0cyB1cCB0byA1MiBp ZiBGRUFUX0xQQSBpcyBlbmFibGVkLA0KPiA+ICAgICAgICAgICBvdGhlcndpc2UgNDggYml0cy4N Cj4gPiAgICAgICAgIC0gRGV0ZXJtaW5lcyB0aGUgYWNjZXNzIHBlcm1pc3Npb25zIGFuZCBtZW1v cnkgYXR0cmlidXRlcyBvZg0KPiA+ICAgICAgICAgICB0aGUgdGFyZ2V0IFBBLg0KPiA+ICAgICAg ICAgLSBDYW4gaW1wbGVtZW50IFBNU0F2OC02NCBhdCBFTDEgYW5kIEVMMg0KPiA+ICAgICAgICAg ICAgIC0gQWRkcmVzcyB0cmFuc2xhdGlvbiBmbGF0LW1hcHMgdGhlIFZBIHRvIHRoZSBQQSBmb3Ig RUwyDQo+IFN0YWdlIDEuDQo+ID4gICAgICAgICAgICAgLSBBZGRyZXNzIHRyYW5zbGF0aW9uIGZs YXQtbWFwcyB0aGUgVkEgdG8gdGhlIFBBIGZvciBFTDENCj4gU3RhZ2UgMS4NCj4gPiAgICAgICAg ICAgICAtIEFkZHJlc3MgdHJhbnNsYXRpb24gZmxhdC1tYXBzIHRoZSBJUEEgdG8gdGhlIFBBIGZv ciBFTDENCj4gU3RhZ2UgMi4NCj4gPiAgICAgLSBQTVNBIGluIEVMMSAmIEVMMiBpcyBjb25maWd1 cmFibGUsIFZNU0EgaW4gRUwxIGlzIGNvbmZpZ3VyYWJsZS4NCj4gPg0KPiA+ICMjIyAxLjIuIFhl biBDaGFsbGVuZ2VzIHdpdGggUE1TQSBWaXJ0dWFsaXphdGlvbg0KPiA+IFhlbiBpcyBQTVNBIHVu YXdhcmUgVHlwZS0xIEh5cGVydmlzb3IsIGl0IHdpbGwgbmVlZCBtb2RpZmljYXRpb25zIHRvIHJ1 bg0KPiA+IHdpdGggYW4gTVBVIGFuZCBob3N0IG11bHRpcGxlIGd1ZXN0IE9TZXMuDQo+ID4NCj4g PiAtIE5vIE1NVSBhdCBFTDI6DQo+ID4gICAgIC0gTm8gRUwyIFN0YWdlIDEgYWRkcmVzcyB0cmFu c2xhdGlvbg0KPiA+ICAgICAgICAgLSBYZW4gcHJvdmlkZXMgZml4ZWQgQVJNNjQgdmlydHVhbCBt ZW1vcnkgbGF5b3V0IGFzIGJhc2lzIG9mIEVMMg0KPiA+ICAgICAgICAgICBzdGFnZSAxIGFkZHJl c3MgdHJhbnNsYXRpb24sIHdoaWNoIGlzIG5vdCBhcHBsaWNhYmxlIG9uIE1QVQ0KPiBzeXN0ZW0s DQo+ID4gICAgICAgICAgIHdoZXJlIHRoZXJlIGlzIG5vIHZpcnR1YWwgYWRkcmVzc2luZy4gQXMg YSByZXN1bHQsIGFueQ0KPiBvcGVyYXRpb24NCj4gPiAgICAgICAgICAgaW52b2x2aW5nIHRyYW5z aXRpb24gZnJvbSBQQSB0byBWQSwgbGlrZSBpb3JlbWFwLCBuZWVkcw0KPiBtb2RpZmljYXRpb24N Cj4gPiAgICAgICAgICAgb24gTVBVIHN5c3RlbS4NCj4gPiAgICAgLSBYZW4ncyBydW4tdGltZSBh ZGRyZXNzZXMgYXJlIHRoZSBzYW1lIGFzIHRoZSBsaW5rIHRpbWUgYWRkcmVzc2VzLg0KPiA+ICAg ICAgICAgLSBFbmFibGUgUElDL1BJRSAocG9zaXRpb24taW5kZXBlbmRlbnQgY29kZSkgb24gYSBy ZWFsLXRpbWUNCj4gdGFyZ2V0DQo+ID4gICAgICAgICAgIHByb2Nlc3NvciBwcm9iYWJseSB2ZXJ5 IHJhcmUuIEZ1cnRoZXIgZGlzY3Vzc2lvbiBpbiAyLjEgYW5kDQo+IFRPRE8NCj4gPiAgICAgICAg ICAgc2VjdGlvbnMuDQo+ID4gICAgIC0gWGVuIHdpbGwgbmVlZCB0byB1c2UgdGhlIEVMMiBNUFUg bWVtb3J5IHJlZ2lvbiBkZXNjcmlwdG9ycyB0bw0KPiBtYW5hZ2UNCj4gPiAgICAgICBhY2Nlc3Mg cGVybWlzc2lvbnMgYW5kIGF0dHJpYnV0ZXMgZm9yIGFjY2Vzc2VzIG1hZGUgYnkgVk1zIGF0DQo+ IEVMMS8wLg0KPiA+ICAgICAgICAgLSBYZW4gY3VycmVudGx5IHJlbGllcyBvbiBNTVUgRUwxIHN0 YWdlIDIgdGFibGUgdG8gbWFuYWdlIHRoZXNlDQo+ID4gICAgICAgICAgIGFjY2Vzc2VzLg0KPiA+ IC0gTm8gTU1VIFN0YWdlIDIgdHJhbnNsYXRpb24gYXQgRUwxOg0KPiA+ICAgICAtIEEgZ3Vlc3Qg ZG9lc24ndCBoYXZlIGFuIGluZGVwZW5kZW50IGd1ZXN0IHBoeXNpY2FsIGFkZHJlc3Mgc3BhY2UN Cj4gPiAgICAgLSBBIGd1ZXN0IGNhbiBub3QgcmV1c2UgdGhlIGN1cnJlbnQgSW50ZXJtZWRpYXRl IFBoeXNpY2FsIEFkZHJlc3MNCj4gPiAgICAgICBtZW1vcnkgbGF5b3V0DQo+ID4gICAgIC0gQSBn dWVzdCB1c2VzIHBoeXNpY2FsIGFkZHJlc3NlcyB0byBhY2Nlc3MgbWVtb3J5IGFuZCBkZXZpY2Vz DQo+ID4gICAgIC0gVGhlIE1QVSBhdCBFTDIgbWFuYWdlcyBFTDEgc3RhZ2UgMiBhY2Nlc3MgcGVy bWlzc2lvbnMgYW5kDQo+IGF0dHJpYnV0ZXMNCj4gPiAtIFRoZXJlIGFyZSBhIGxpbWl0ZWQgbnVt YmVyIG9mIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgYm90aCBFTDIgYW5kDQo+IEVMMToNCj4g PiAgICAgLSBBcmNoaXRlY3R1cmFsbHksIHRoZSBtYXhpbXVtIG51bWJlciBvZiBwcm90ZWN0aW9u IHJlZ2lvbnMgaXMgMjU2LA0KPiA+ICAgICAgIHR5cGljYWwgaW1wbGVtZW50YXRpb25zIGhhdmUg MzIuDQo+ID4gICAgIC0gQnkgY29udHJhc3QsIFhlbiBkb2VzIG5vdCBuZWVkIHRvIGNvbnNpZGVy IHRoZSBudW1iZXIgb2YgcGFnZQ0KPiB0YWJsZQ0KPiA+ICAgICAgIGVudHJpZXMgaW4gdGhlb3J5 IHdoZW4gdXNpbmcgTU1VLg0KPiA+IC0gVGhlIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgYXQgRUwy IG5lZWQgdG8gYmUgc2hhcmVkIGJldHdlZW4gdGhlDQo+IGh5cGVydmlzb3INCj4gPiAgIGFuZCB0 aGUgZ3Vlc3Qgc3RhZ2UgMi4NCj4gPiAgICAgLSBSZXF1aXJlcyBjYXJlZnVsIGNvbnNpZGVyYXRp b24gLSBtYXkgaW1wYWN0IGZlYXR1cmUgJ2Z1bGxuZXNzJyBvZg0KPiBib3RoDQo+ID4gICAgICAg dGhlIGh5cGVydmlzb3IgYW5kIHRoZSBndWVzdA0KPiA+ICAgICAtIEJ5IGNvbnRyYXN0LCB3aGVu IHVzaW5nIE1NVSwgWGVuIGhhcyBzdGFuZGFsb25lIFAyTSB0YWJsZSBmb3INCj4gZ3Vlc3QNCj4g PiAgICAgICBzdGFnZSAyIGFjY2Vzc2VzLg0KPiA+DQo+ID4gIyMgMi4gUHJvcG9zZWQgY2hhbmdl cyBvZiBYZW4NCj4gPiAjIyMgKioyLjEuIENoYW5nZXMgb2YgYnVpbGQgc3lzdGVtOioqDQo+ID4N Cj4gPiAtICoqKkludHJvZHVjZSBuZXcgS2NvbmZpZyBvcHRpb25zIGZvciBBcm12OC1SNjQqKio6 DQo+ID4gICBVbmxpa2UgQXJtdjgtQSwgYmVjYXVzZSBsYWNrIG9mIE1NVSBzdXBwb3J0IG9uIEFy bXY4LVI2NCwgd2UgbWF5IG5vdA0KPiA+ICAgZXhwZWN0IG9uZSBYZW4gYmluYXJ5IHRvIHJ1biBv biBhbGwgbWFjaGluZXMuIFhlbiBpbWFnZXMgYXJlIG5vdA0KPiBjb21tb24NCj4gPiAgIGFjcm9z cyBBcm12OC1SNjQgcGxhdGZvcm1zLiBYZW4gbXVzdCBiZSByZS1idWlsdCBmb3IgZGlmZmVyZW50 IEFybXY4LQ0KPiBSNjQNCj4gPiAgIHBsYXRmb3Jtcy4gQmVjYXVzZSB0aGVzZSBwbGF0Zm9ybXMg bWF5IGhhdmUgZGlmZmVyZW50IG1lbW9yeSBsYXlvdXQNCj4gYW5kDQo+ID4gICBsaW5rIGFkZHJl c3MuDQo+ID4gICAgIC0gYEFSTTY0X1Y4UmA6DQo+ID4gICAgICAgVGhpcyBvcHRpb24gZW5hYmxl cyBBcm12OC1SIHByb2ZpbGUgZm9yIEFybTY0LiBFbmFibGluZyB0aGlzDQo+IG9wdGlvbg0KPiA+ ICAgICAgIHJlc3VsdHMgaW4gc2VsZWN0aW5nIE1QVS4gVGhpcyBLY29uZmlnIG9wdGlvbiBpcyB1 c2VkIHRvIGdhdGUgc29tZQ0KPiA+ICAgICAgIEFybXY4LVI2NCBzcGVjaWZpYyBjb2RlIGV4Y2Vw dCBNUFUgY29kZSwgbGlrZSBzb21lIGNvZGUgZm9yIEFybXY4LQ0KPiBSNjQNCj4gPiAgICAgICBv bmx5IHN5c3RlbSBJRCByZWdpc3RlcnMgYWNjZXNzLg0KPiA+DQo+ID4gICAgIC0gYEFSTV9NUFVg DQo+ID4gICAgICAgVGhpcyBvcHRpb24gZW5hYmxlcyBNUFUgb24gQXJtdjgtUiBhcmNoaXRlY3R1 cmUuIEVuYWJsaW5nIHRoaXMNCj4gb3B0aW9uDQo+ID4gICAgICAgcmVzdWx0cyBpbiBkaXNhYmxp bmcgTU1VLiBUaGlzIEtjb25maWcgb3B0aW9uIGlzIHVzZWQgdG8gZ2F0ZSBzb21lDQo+ID4gICAg ICAgQVJNX01QVSBzcGVjaWZpYyBjb2RlLiBPbmNlIHdoZW4gdGhpcyBLY29uZmlnIG9wdGlvbiBo YXMgYmVlbg0KPiBlbmFibGVkLA0KPiA+ICAgICAgIHRoZSBNTVUgcmVsYXRlIGNvZGUgd2lsbCBu b3QgYmUgYnVpbHQgZm9yIEFybXY4LVI2NC4gVGhlIHJlYXNvbg0KPiB3aHkNCj4gPiAgICAgICBu b3QgZGVwZW5kcyBvbiBydW50aW1lIGRldGVjdGlvbiB0byBzZWxlY3QgTU1VIG9yIE1QVSBpcyB0 aGF0LCB3ZQ0KPiBkb24ndA0KPiA+ICAgICAgIHRoaW5rIHdlIGNhbiB1c2Ugb25lIGltYWdlIGZv ciBib3RoIEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0Lg0KPiBBbm90aGVyDQo+ID4gICAgICAgcmVh c29uIHRoYXQgd2Ugc2VwYXJhdGUgTVBVIGFuZCBWOFIgaW4gcHJvdmlzaW9uIHRvIGFsbG93IHRv DQo+IHN1cHBvcnQgTVBVDQo+ID4gICAgICAgb24gMzJiaXQgQXJtIG9uZSBkYXkuDQo+ID4NCj4g PiAgICoqKlRyeSB0byB1c2UgYGlmICggSVNfRU5BQkxFRChDT05GSUdfQVJNWFhYWCkgKWAgaW5z dGVhZCBvZg0KPiBzcHJlYWRpbmcqKioNCj4gPiAgICoqKmAjaWZkZWYgQ09ORklHX0FSTVhYWFhg IGV2ZXJ5d2hlcmUsIGlmIGl0IGlzIHBvc3NpYmxlLioqKg0KPiA+DQo+ID4gLSAqKipBYm91dCBY ZW4gc3RhcnQgYWRkcmVzcyBmb3IgQXJtdjgtUjY0KioqOg0KPiA+ICAgT24gQXJtdjgtQSwgWGVu IGhhcyBhIGZpeGVkIHZpcnR1YWwgc3RhcnQgYWRkcmVzcyAobGluayBhZGRyZXNzIHRvbykNCj4g b24gYWxsDQo+ID4gICBBcm12OC1BIHBsYXRmb3Jtcy4gSW4gYW4gTU1VIGJhc2VkIHN5c3RlbSwg WGVuIGNhbiBtYXAgaXRzIGxvYWRlZA0KPiBhZGRyZXNzDQo+ID4gICB0byB0aGlzIHZpcnR1YWwg c3RhcnQgYWRkcmVzcy4gT24gQXJtdjgtQSBwbGF0Zm9ybXMsIHRoZSBYZW4gc3RhcnQNCj4gYWRk cmVzcw0KPiA+ICAgZG9lcyBub3QgbmVlZCB0byBiZSBjb25maWd1cmFibGUuIEJ1dCBvbiBBcm12 OC1SIHBsYXRmb3JtcywgdGhleSBkb24ndA0KPiBoYXZlDQo+ID4gICBNTVUgdG8gbWFwIGxvYWRl ZCBhZGRyZXNzIHRvIGEgZml4ZWQgdmlydHVhbCBhZGRyZXNzLiBBbmQgZGlmZmVyZW50DQo+IHBs YXRmb3Jtcw0KPiA+ICAgd2lsbCBoYXZlIHZlcnkgZGlmZmVyZW50IGFkZHJlc3Mgc3BhY2UgbGF5 b3V0LCBzbyBpdCdzIGltcG9zc2libGUgZm9yDQo+IFhlbiB0bw0KPiA+ICAgc3BlY2lmeSBhIGZp eGVkIHBoeXNpY2FsIGFkZHJlc3MgZm9yIGFsbCBBcm12OC1SIHBsYXRmb3Jtcycgc3RhcnQNCj4g YWRkcmVzcy4NCj4gPg0KPiA+ICAgLSBTdGFnZSAxLCBpbnRyb2R1Y2UgYFhFTl9TVEFSVF9BRERS RVNTYA0KPiA+ICAgICBUaGlzIG9wdGlvbiBhbGxvd3MgdG8gc2V0IHRoZSBjdXN0b20gYWRkcmVz cyBhdCB3aGljaCBYZW4gd2lsbCBiZQ0KPiA+ICAgICBsaW5rZWQuIFRoaXMgYWRkcmVzcyBtdXN0 IGJlIGFsaWduZWQgdG8gYSBwYWdlIHNpemUuIFhlbidzIHJ1bi10aW1lDQo+ID4gICAgIGFkZHJl c3NlcyBhcmUgdGhlIHNhbWUgYXMgdGhlIGxpbmsgdGltZSBhZGRyZXNzZXMuDQo+ID4gICAgICoq Kk5vdGVzOiBGaXhlZCBsaW5rIGFkZHJlc3MgbWVhbnMgdGhlIFhlbiBiaW5hcnkgY291bGQgbm90 IGJlKioqDQo+ID4gICAgICoqKnJlbG9jYXRlZCBieSBFRkkgbG9hZGVyLiBTbyBpbiBjdXJyZW50 IHN0YWdlLCBYZW4gY291bGQgbm90KioqDQo+ID4gICAgICoqKmJlIGxhdW5jaGVkIGFzIGFuIEVG SSBhcHBsaWNhdGlvbiBvbiBBcm12OC1SNjQuKFRPRE8jMy4zKSoqKg0KPiA+DQo+ID4gICAgIC0g UHJvdmlkZWQgYnkgcGxhdGZvcm0gZmlsZXMuDQo+ID4gICAgICAgV2UgY2FuIHJldXNlIHRoZSBl eGlzdGVkIGFybS9wbGF0Zm9ybXMgc3RvcmUgcGxhdGZvcm0gc3BlY2lmaWMNCj4gZmlsZXMuDQo+ ID4gICAgICAgQW5kIGBYRU5fU1RBUlRfQUREUkVTU2AgaXMgb25lIGtpbmQgb2YgcGxhdGZvcm0g c3BlY2lmaWMNCj4gaW5mb3JtYXRpb24uDQo+ID4gICAgICAgU28gd2UgY2FuIHVzZSBwbGF0Zm9y bSBmaWxlIHRvIGRlZmluZSBkZWZhdWx0IGBYRU5fU1RBUlRfQUREUkVTU2ANCj4gZm9yDQo+ID4g ICAgICAgZWFjaCBwbGF0Zm9ybS4NCj4gPg0KPiA+ICAgICAtIFByb3ZpZGVkIGJ5IEtjb25maWcu DQo+ID4gICAgICAgVGhpcyBvcHRpb24gY2FuIGJlIGEgc3VwcGx5bWVudGFsIG9wdGlvbi4gVXNl cnMgY2FuIGRlZmluZSBhDQo+IGN1c3RvbWl6ZWQNCj4gPiAgICAgICBgWEVOX1NUQVJUX0FERFJF U1NgIHRvIG92ZXJyaWRlIHRoZSBkZWZhdWx0IHZhbHVlIGluIHBsYXRmb3JtJ3MNCj4gZmlsZS4N Cj4gPg0KPiA+ICAgLSBTdGFnZSAyLCBnZW5lcmF0ZWQgYFhFTl9TVEFSVF9BRERSRVNTYCBmcm9t IGRldmljZSB0cmVlIGJ5IGJ1aWxkDQo+IHNjcmlwdHMNCj4gPiAgICAgICBWZW5kb3JzIHdobyB3 YW50IHRvIGVuYWJsZSBYZW4gb24gdGhlaXIgQXJtdjgtUiBwbGF0Zm9ybXMsIHRoZXkNCj4gY2Fu DQo+ID4gICAgICAgdXNlIHNvbWUgdG9vbHMvc2NyaXB0cyB0byBwYXJzZSB0aGVpciBib2FyZHMg ZGV2aWNlIHRyZWUgdG8NCj4gZ2VuZXJhdGUNCj4gPiAgICAgICB0aGUgYmFzaWMgcGxhdGZvcm0g aW5mb3JtYXRpb24sIGxpa2UgYFhFTl9TVEFSVF9BRERSRVNTYC4gVGhlc2UNCj4gPiAgICAgICB0 b29scy9zY3JpcHRzIGRvIG5vdCBuZWNlc3NhcmlseSBuZWVkIHRvIGJlIGludGVncmF0ZWQgaW4g WGVuLCBidXQNCj4gWGVuDQo+ID4gICAgICAgY2FuIGdpdmUgc29tZSByZWNvbW1lbmRlZCBjb25m aWd1cmF0aW9uLiBGb3IgZXhhbXBsZSwgWGVuIGNhbg0KPiByZWNvbW1lbmQNCj4gPiAgICAgICBB cm12OC1SIHBsYXRmb3JtcyB0byB1c2UgbG93ZXN0IHJhbSBzdGFydCBhZGRyZXNzICsgMk1CIGFz IHRoZQ0KPiBkZWZhdWx0DQo+ID4gICAgICAgWGVuIHN0YXJ0IGFkZHJlc3MuIFRoZSBnZW5lcmF0 ZWQgcGxhdGZvcm0gZmlsZXMgY2FuIGJlIHBsYWNlZCB0bw0KPiA+ICAgICAgIGFybS9wbGF0Zm9y bXMgZm9yIG1haW50ZW5hbmNlLg0KPiA+DQo+ID4gLSAqKipBYm91dCBNUFUgaW5pdGlhbGl6YXRp b24gYmVmb3JlIHBhcnNpbmcgZGV2aWNlIHRyZWUqKio6DQo+ID4gICAgICAgQmVmb3JlIFhlbiBj YW4gc3RhcnQgcGFyc2luZyBpbmZvcm1hdGlvbiBmcm9tIGRldmljZSB0cmVlIGFuZCB1c2UNCj4g PiAgICAgICB0aGlzIGluZm9ybWF0aW9uIHRvIHNldHVwIE1QVSwgWGVuIG5lZWQgYW4gaW5pdGlh bCBNUFUgc3RhdGUuIFRoaXMNCj4gPiAgICAgICBpcyBiZWNhdXNlOg0KPiA+ICAgICAgIDEuIE1v cmUgZGV0ZXJtaW5pc3RpYzogQXJtIE1QVSBzdXBwb3J0cyBiYWNrZ3JvdW5kIHJlZ2lvbnMsIGlm IHdlDQo+ID4gICAgICAgICAgZG9uJ3QgY29uZmlndXJlIHRoZSBNUFUgcmVnaW9ucyBhbmQgZG9u J3QgZW5hYmxlIE1QVS4gVGhlDQo+IGRlZmF1bHQNCj4gPiAgICAgICAgICBNUFUgYmFja2dyb3Vu ZCBhdHRyaWJ1dGVzIHdpbGwgdGFrZSBlZmZlY3QuIFRoZSBkZWZhdWx0DQo+IGJhY2tncm91bmQN Cj4gPiAgICAgICAgICBhdHRyaWJ1dGVzIGFyZSBgSU1QTEVNRU5UQVRJT04gREVGSU5FRGAuIFRo YXQgbWVhbnMgYWxsIFJBTQ0KPiByZWdpb25zDQo+ID4gICAgICAgICAgbWF5IGJlIGNvbmZpZ3Vy ZWQgdG8gZGV2aWNlIG1lbW9yeSBhbmQgUldYLiBSYW5kb20gdmFsdWVzIGluDQo+IFJBTSBvcg0K PiA+ICAgICAgICAgIG1hbGljaW91c2x5IGVtYmVkZGVkIGRhdGEgY2FuIGJlIGV4cGxvaXRlZC4N Cj4gPiAgICAgICAyLiBNb3JlIGNvbXBhdGlibGU6IE9uIHNvbWUgQXJtdjgtUjY0IHBsYXRmb3Jt cywgaWYgTVBVIGlzDQo+IGRpc2FibGVkLA0KPiA+ICAgICAgICAgIHRoZSBgZGMgenZhYCBpbnN0 cnVjdGlvbiB3aWxsIG1ha2UgdGhlIHN5c3RlbSBoYWx0IChUaGlzIGlzIG9uZQ0KPiA+ICAgICAg ICAgIHNpZGUgZWZmZWN0IG9mIE1QVSBiYWNrZ3JvdW5kIGF0dHJpYnV0ZXMsIHRoZSBSQU0gaGFz IGJlZW4NCj4gY29uZmlndXJlZA0KPiA+ICAgICAgICAgIGFzIGRldmljZSBtZW1vcnkpLiBBbmQg dGhpcyBpbnN0cnVjdGlvbiB3aWxsIGJlIGVtYmVkZGVkIGluDQo+IHNvbWUNCj4gPiAgICAgICAg ICBidWlsdC1pbiBmdW5jdGlvbnMsIGxpa2UgYG1lbW9yeSBzZXRgLiBJZiB3ZSB1c2UgYC0NCj4g ZGRvbnRfdXNlX2RjYCB0bw0KPiA+ICAgICAgICAgIHJlYnVpbGQgR0NDLCB0aGUgYnVpbHQtaW4g ZnVuY3Rpb25zIHdpbGwgbm90IGNvbnRhaW4gYGRjIHp2YWAuDQo+ID4gICAgICAgICAgSG93ZXZl ciwgaXQgaXMgb2J2aW91c2x5IHVubGlrZWx5IHRoYXQgd2Ugd2lsbCBiZSBhYmxlIHRvDQo+IHJl Y29tcGlsZQ0KPiA+ICAgICAgICAgIGFsbCBHQ0MgZm9yIEFSTXY4LVI2NC4NCj4gPg0KPiA+ICAg ICAtIFN0YWdlIDEsIHJldXNlIGBYRU5fU1RBUlRfQUREUkVTU2ANCj4gPiAgICAgICBJbiB0aGUg dmVyeSBiZWdpbm5pbmcgb2YgWGVuIGJvb3QsIFhlbiBqdXN0IG5lZWQgdG8gY292ZXIgYQ0KPiBs aW1pdGVkDQo+ID4gICAgICAgbWVtb3J5IHJhbmdlIGFuZCB2ZXJ5IGZldyBkZXZpY2VzIChhY3R1 YWxseSBvbmx5IFVBUlQgZGV2aWNlKS4gU28NCj4gd2UNCj4gPiAgICAgICBjYW4gdXNlIHR3byBN UFUgcmVnaW9ucyB0byBtYXA6DQo+ID4gICAgICAgMS4gYFhFTl9TVEFSVF9BRERSRVNTYCB0byBg WEVOX1NUQVJUX0FERFJFU1MgKyAyTUJgIG9yLg0KPiA+ICAgICAgICAgIGBYRU5fU1RBUlRfQURE UkVTU2AgdG8gYFhFTl9TVEFSVF9BRERSRVNTICsgaW1hZ2Vfc2l6ZWBhcw0KPiA+ICAgICAgICAg IG5vcm1hbCBtZW1vcnkuDQo+ID4gICAgICAgMi4gYFVBUlRgIE1NSU8gcmVnaW9uIGJhc2UgdG8g YFVBUlRgIE1NSU8gcmVnaW9uIGVuZCB0byBkZXZpY2UNCj4gbWVtb3J5Lg0KPiA+ICAgICAgIFRo ZXNlIHR3byBhcmUgZW5vdWdoIHRvIHN1cHBvcnQgWGVuIHJ1biBpbiBib290IHRpbWUuIEFuZCB3 ZSBkb24ndA0KPiBuZWVkDQo+ID4gICAgICAgdG8gcHJvdmlkZSBhZGRpdGlvbmFsIHBsYXRmb3Jt IGluZm9ybWF0aW9uIGZvciBpbml0aWFsIG5vcm1hbA0KPiBtZW1vcnkNCj4gPiAgICAgICBhbmQg ZGV2aWNlIG1lbW9yeSByZWdpb25zLiBJbiBjdXJyZW50IFBvQyB3ZSBoYXZlIHVzZWQgdGhpcyBv cHRpb24NCj4gPiAgICAgICBmb3IgaW1wbGVtZW50YXRpb24sIGFuZCBpdCdzIHRoZSBzYW1lIGFz IEFybXY4LUEuDQo+ID4NCj4gPiAgICAgLSBTdGFnZSAyLCBnZW5lcmF0ZSBpbmZvcm1hdGlvbiBm b3IgaW5pdGlhbCBNUFUgc3RhdGUgZnJvbSBkZXZpY2UNCj4gdHJlZQ0KPiA+ICAgICAgIEludHJv ZHVjZSBzb21lIG1hY3JvcyB0byBhbGxvdyB1c2VycyB0byBzZXQgaW5pdGlhbCBub3JtYWwNCj4g PiAgICAgICBtZW1vcnkgcmVnaW9uczoNCj4gPiAgICAgICBgQVJNX01QVV9OT1JNQUxfTUVNT1JZ X1NUQVJUYCBhbmQgYEFSTV9NUFVfTk9STUFMX01FTU9SWV9FTkRgDQo+ID4gICAgICAgYW5kIGRl dmljZSBtZW1vcnk6DQo+ID4gICAgICAgYEFSTV9NUFVfREVWSUNFX01FTU9SWV9TVEFSVGAgYW5k IGBBUk1fTVBVX0RFVklDRV9NRU1PUllfRU5EYA0KPiA+ICAgICAgIFRoZXNlIG1hY3JvcyBhcmUg dGhlIHNhbWUgcGxhdGZvcm0gc3BlY2lmaWMgaW5mb3JtYXRpb24gYXMNCj4gPiAgICAgICBgWEVO X1NUQVJUX0FERFJFU1NgLCBzbyB0aGUgc2NyaXB0IG9mIGdlbmVyYXRpbmcNCj4gYFhFTl9TVEFS VF9BRERSRVNTYA0KPiA+ICAgICAgIGFsc28gY2FuIGJlIGFwcGxpZWQgdG8gdGhlc2UgbWFjcm9z Lg0KPiA+DQo+ID4gLSAqKipEZWZpbmUgbmV3IHN5c3RlbSByZWdpc3RlcnMgZm9yIGNvbXBpbGll cnMqKio6DQo+ID4gICBBcm12OC1SNjQgaXMgYmFzZWQgb24gQXJtdjguNC4gVGhhdCBtZWFucyB3 ZSB3aWxsIHVzZSBzb21lIEFybXY4LjQNCj4gPiAgIHNwZWNpZmljIHN5c3RlbSByZWdpc3RlcnMu IEFzIEFybXY4LVI2NCBvbmx5IGhhdmUgc2VjdXJlIHN0YXRlLCBzbw0KPiA+ICAgYXQgbGVhc3Qs IGBWU1RDUl9FTDJgIGFuZCBgVlNDVExSX0VMMmAgd2lsbCBiZSB1c2VkIGZvciBYZW4uIEFuZCB0 aGUNCj4gPiAgIGZpcnN0IEdDQyB2ZXJzaW9uIHRoYXQgc3VwcG9ydHMgQXJtdjguNCBpcyBHQ0Mg OC4xLiBJbiBhZGRpdGlvbiB0bw0KPiA+ICAgdGhlc2UsIFBNU0Egb2YgQXJtdjgtUjY0IGludHJv ZHVjZWQgbG90cyBvZiBNUFUgcmVsYXRlZCBzeXN0ZW0NCj4gcmVnaXN0ZXJzOg0KPiA+ICAgYFBS QkFSX0VMeGAsIGBQUkJBUnhfRUx4YCwgYFBSTEFSX0VMeGAsIGBQUkxBUnhfRUx4YCwgYFBSRU5S X0VMeGAgYW5kDQo+ID4gICBgTVBVSVJfRUx4YC4gQnV0IHRoZSBmaXJzdCBHQ0MgdmVyc2lvbiB0 byBzdXBwb3J0IHRoZXNlIHN5c3RlbQ0KPiByZWdpc3RlcnMNCj4gPiAgIGlzIEdDQyAxMS4gV2Ug ZG9uJ3Qgd2FudCB0byBidW1wIEdDQyB2ZXJzaW9uIHRvIDExIGluIHRoZSBmaXJzdCBzdGFnZSwN Cj4gPiAgIGl0IHdpbGwgYWZmZWN0IHNvbWUgbWFrZWZpbGUgc2NyaXB0cyBvZiBjb21tb24gYW5k IG90aGVyIGFyY2hpdGVjdHVyZXMuDQo+ID4NCj4gPiAgIEluc3RlYWQsIHdlIHdpbGw6DQo+ID4g ICAtIEVuY29kZSBuZXcgc3lzdGVtIHJlZ2lzdGVycyBpbiBtYWNyb3MNCj4gPiAgICAgICAgIGBg YA0KPiA+ICAgICAgICAgLyogVmlydHVhbGl6YXRpb24gU2VjdXJlIFRyYW5zbGF0aW9uIENvbnRy b2wgUmVnaXN0ZXIgKi8NCj4gPiAgICAgICAgICNkZWZpbmUgVlNUQ1JfRUwyICBTM180X0MyX0M2 XzINCj4gPiAgICAgICAgIC8qIFZpcnR1YWxpemF0aW9uIFN5c3RlbSBDb250cm9sIFJlZ2lzdGVy ICovDQo+ID4gICAgICAgICAjZGVmaW5lIFZTQ1RMUl9FTDIgUzNfNF9DMl9DMF8wDQo+ID4gICAg ICAgICAvKiBFTDEgTVBVIFByb3RlY3Rpb24gUmVnaW9uIEJhc2UgQWRkcmVzcyBSZWdpc3RlciBl bmNvZGUgKi8NCj4gPiAgICAgICAgICNkZWZpbmUgUFJCQVJfRUwxICBTM18wX0M2X0M4XzANCj4g PiAgICAgICAgIC4uLg0KPiA+ICAgICAgICAgLyogRUwyIE1QVSBQcm90ZWN0aW9uIFJlZ2lvbiBC YXNlIEFkZHJlc3MgUmVnaXN0ZXIgZW5jb2RlICovDQo+ID4gICAgICAgICAjZGVmaW5lIFBSQkFS X0VMMiAgUzNfNF9DNl9DOF8wDQo+ID4gICAgICAgICAuLi4NCj4gPiAgICAgICAgIGBgYA0KPiA+ ICAgICAgSWYgd2UgZW5jb2RlIGFsbCBhYm92ZSBzeXN0ZW0gcmVnaXN0ZXJzLCB3ZSBkb24ndCBu ZWVkIHRvIGJ1bXAgR0NDDQo+ID4gICAgICB2ZXJzaW9uLiBBbmQgdGhlIGNvbW1vbiBDRkxBR1Mg WGVuIGlzIHVzaW5nIHN0aWxsIGNhbiBiZSBhcHBsaWVkIHRvDQo+ID4gICAgICBBcm12OC1SNjQu IFdlIGRvbid0IG5lZWQgdG8gbW9kaWZ5IE1ha2VmaWxlcyB0byBhZGQgc3BlY2lmaWMgQ0ZMQUdT Lg0KPiA+ICAgICAgKioqTm90ZXM6KioqDQo+ID4gICAgICAqKipBcm12OC1SIEFBcmNoNjQgc3Vw cG9ydHMgdGhlIEE2NCBJU0EgaW5zdHJ1Y3Rpb24gc2V0IHdpdGgqKioNCj4gPiAgICAgICoqKnNv bWUgbW9kaWZpY2F0aW9uczoqKioNCj4gPiAgICAgICoqKlJlZGVmaW5lcyBETUIsIERTQiwgYW5k IGFkZHMgYW4gREZCLiBCdXQgYWN0dWFsbHksIHRoZSoqKg0KPiA+ICAgICAgKioqZW5jb2Rpbmdz IG9mIERNQiBhbmQgRFNCIGFyZSBzdGlsbCB0aGUgc2FtZSB3aXRoIEE2NC4qKioNCj4gPiAgICAg ICoqKkFuZCBERkIgaXMgYW4gYWxpYXMgb2YgRFNCICMxMi4gSW4gdGhpcyBjYXNlLCB3ZSB0aGlu ayoqKg0KPiA+ICAgICAgKioqd2UgZG9uJ3QgbmVlZCBhIG5ldyBhcmNoaXRlY3R1cmUgc3BlY2lm aWMgZmxhZyB0byoqKg0KPiA+ICAgICAgKioqZ2VuZXJhdGUgbmV3IGluc3RydWN0aW9ucyBmb3Ig QXJtdjgtUi4qKioNCj4gPg0KPiA+ICMjIyAqKjIuMi4gQ2hhbmdlcyBvZiB0aGUgaW5pdGlhbGl6 YXRpb24gcHJvY2VzcyoqDQo+ID4gSW4gZ2VuZXJhbCwgd2Ugc3RpbGwgZXhwZWN0IEFybXY4LVI2 NCBhbmQgQXJtdjgtQTY0IHRvIGhhdmUgYSBjb25zaXN0ZW50DQo+ID4gaW5pdGlhbGl6YXRpb24g cHJvY2Vzcy4gSW4gYWRkaXRpb24gdG8gc29tZSBhcmNoaXRlY3V0cmUgZGlmZmVyZW5jZXMsDQo+ IHRoZXJlDQo+ID4gaXMgbm8gbW9yZSB0aGFuIHJldXNhYmxlIGNvZGUgdGhhdCB3ZSB3aWxsIGRp c3Rpbmd1aXNoIHRocm91Z2gNCj4gQ09ORklHX0FSTV9NUFUNCj4gPiBvciBDT05GSUdfQVJNNjRf VjhSLiBXZSB3YW50IG1vc3Qgb2YgdGhlIGluaXRpYWxpemF0aW9uIGNvZGUgdG8gYmUNCj4gcmV1 c2FibGUNCj4gPiBiZXR3ZWVuIEFybXY4LVI2NCBhbmQgQXJtdjgtQTY0Lg0KPiA+DQo+ID4gLSBX ZSB3aWxsIHJldXNlIHRoZSBvcmlnaW5hbCBoZWFkLnMgYW5kIHNldHVwLmMgb2YgQXJtLiBCdXQg cmVwbGFjZSB0aGUNCj4gPiAgIE1NVSBhbmQgcGFnZSB0YWJsZSBvcGVyYXRpb25zIGluIHRoZXNl IGZpbGVzIHdpdGggY29uZmlndXJhdGlvbg0KPiBvcGVyYXRpb25zDQo+ID4gICBmb3IgTVBVIGFu ZCBNUFUgcmVnaW9ucy4NCj4gPg0KPiA+IC0gV2UgcHJvdmlkZSBhIGJvb3QtdGltZSBNUFUgY29u ZmlndXJhdGlvbi4gVGhpcyBNUFUgY29uZmlndXJhdGlvbiB3aWxsDQo+ID4gICBzdXBwb3J0IFhl biB0byBmaW5pc2ggaXRzIGluaXRpYWxpemF0aW9uLiBBbmQgdGhpcyBib290LXRpbWUgTVBVDQo+ ID4gICBjb25maWd1cmF0aW9uIHdpbGwgcmVjb3JkIHRoZSBtZW1vcnkgcmVnaW9ucyB0aGF0IHdp bGwgYmUgcGFyc2VkIGZyb20NCj4gPiAgIGRldmljZSB0cmVlLg0KPiA+DQo+ID4gICBJbiB0aGUg ZW5kIG9mIFhlbiBpbml0aWFsaXphdGlvbiwgd2Ugd2lsbCB1c2UgYSBydW50aW1lIE1QVQ0KPiBj b25maWd1cmF0aW9uDQo+ID4gICB0byByZXBsYWNlIGJvb3QtdGltZSBNUFUgY29uZmlndXJhdGlv bi4gVGhlIHJ1bnRpbWUgTVBVIGNvbmZpZ3VyYXRpb24NCj4gd2lsbA0KPiA+ICAgbWVyZ2UgYW5k IHJlb3JkZXIgbWVtb3J5IHJlZ2lvbnMgdG8gc2F2ZSBtb3JlIE1QVSByZWdpb25zIGZvciBndWVz dHMuDQo+ID4gICAhW2ltZ10oaHR0cHM6Ly9kcml2ZS5nb29nbGUuY29tL3VjP2V4cG9ydD12aWV3 JmlkPTF3VEZ5SzJYZlUzbFRsSDFQcVJEDQo+IG9hY1FWVHdVdFdJR1UpDQo+ID4NCj4gPiAtIERl ZmVyIHN5c3RlbSB1bnBhdXNpbmcgZG9tYWluIGFmdGVyIGZyZWVfaW5pdF9tZW1vcnkuDQo+ID4g ICBXaGVuIFhlbiBpbml0aWFsaXphdGlvbiBpcyBhYm91dCB0byBlbmQsIFhlbiB1bnBhdXNlcyBn dWVzdHMgY3JlYXRlZA0KPiA+ICAgZHVyaW5nIGluaXRpYWxpemF0aW9uLiBCdXQgdGhpcyB3aWxs IGNhdXNlIHNvbWUgaXNzdWVzLiBUaGUgdW5wYXVzZQ0KPiA+ICAgYWN0aW9uIG9jY3VycyBiZWZv cmUgZnJlZV9pbml0X21lbW9yeSwgaG93ZXZlciB0aGUgcnVudGltZSBNUFUNCj4gPiAgIGNvbmZp Z3VyYXRpb24gaXMgYnVpbHQgYWZ0ZXIgZnJlZV9pbml0X21lbW9yeS4gSW4gRHJhZnQtQSwgd2Ug aGFkDQo+ID4gICBkaXNjdXNzZWQgd2hldGhlciBhIHplcm9pbmcgb3BlcmF0aW9uIGZvciBpbml0 IGNvZGUgYW5kIGRhdGEgaXMNCj4gPiAgIGVub3VnaCBvciBub3QuIEJlY2F1c2UgSSBoYWQganVz dCBnaXZlbiBhIHNlY3VyaXR5IHJlYXNvbiBmb3IgZG9pbmcNCj4gPiAgIGZyZWVfaW5pdF9tZW1v cnkgb24gQXJtdjgtUiAoZnJlZV9pbml0X21lbW9yeSB3aWxsIGRyb3AgdGhlIFhlbiBpbml0DQo+ ID4gICBjb2RlICYgZGF0YSwgdGhpcyB3aWxsIHJlZHVjZSB0aGUgY29kZSBhbiBhdHRhY2tlciBj YW4gZXhwbG9pdCkuDQo+ID4gICBCdXQgSSBmb3Jnb3Qgb3RoZXIgdmVyeSBpbXBvcnRhbnQgcmVh c29uczoNCj4gPiAgIDEuIEluaXQgY29kZSBhbmQgZGF0YSB3aWxsIG9jY3VweSB0d28gTVBVIHJl Z2lvbnMsIGJlY2F1c2UgdGhleQ0KPiA+ICAgICAgaGF2ZSBkaWZmZXJlbnQgbWVtb3J5IGF0dHJp YnV0ZXMuDQo+ID4gICAyLiBJdCdzIG5vdCBlYXN5IHRvIHplcm8gaW5pdCBjb2RlIHNlY3Rpb24s IGJlY2F1c2UgaXQncyByZWFkb25seS4NCj4gPiAgICAgIFdlIGhhdmUgdG8gdXBkYXRlIGl0cyBN UFUgcmVnaW9uIHRvIG1ha2UgdGhpcyBzZWN0aW9uIFJXLiBUaGlzDQo+ID4gICAgICBvcGVyYXRp b24gZG9lc24ndCBkbyBtdWNoIGxlc3MgdGhhbiBmcmVlX2luaXRfbWVtb3J5Lg0KPiA+ICAgMy4g WmVyb2luZyBpbml0IGNvZGUgYW5kIGRhdGEgd2lsbCBub3QgcmVsZWFzZSB0aGUgdHdvIE1QVSBy ZWdpb25zDQo+ID4gICAgICB0aGV5IGFyZSB1c2luZy4gVGhpcyB3b3VsZCBiZSBhIHZlcnkgYmln IHdhc3RlIG9mIGEgbGltaXRlZCBNUFUNCj4gPiAgICAgIHJlZ2lvbnMgcmVzb3VyY2UuDQo+ID4g ICA0LiBDdXJyZW50IGZyZWVfaW5pdF9tZW1vcnkgb3BlcmF0aW9uIGlzIHJldXNpbmcgbG90cyBv ZiBBcm12OC1BDQo+ID4gICAgICBjb2RlcywgZXhjZXB0IHJlLWFkZCBpbml0IG1lbW9yeSB0byBY ZW4gaGVhcC4gQmVjYXVzZSB3ZSdyZSB1c2luZw0KPiA+ICAgICAgc3RhdGljIGhlYXAgb24gQXJt djgtUi4NCj4gPg0KPiA+ICAgU28gaWYgdGhlIHVucGF1c2VkIGd1ZXN0cyBzdGFydCBleGVjdXRp bmcgdGhlIGNvbnRleHQgc3dpdGNoIGF0IHRoaXMNCj4gPiAgIHBvaW50LCB0aGVuIGl0cyBNUFUg Y29udGV4dCB3aWxsIGJhc2Ugb24gdGhlIGJvb3QtdGltZSBNUFUNCj4gY29uZmlndXJhdGlvbi4N Cj4gPiAgIFByb2JhYmx5IGl0IHdpbGwgYmUgaW5jb25zaXN0ZW50IHdpdGggcnVudGltZSBNUFUg Y29uZmlndXJhdGlvbiwgdGhpcw0KPiA+ICAgd2lsbCBjYXVzZSB1bmV4cGVjdGVkIHByb2JsZW1z IChUaGlzIG1heSBub3QgaGFwcGVuIGluIGEgc2luZ2xlIGNvcmUNCj4gPiAgIHN5c3RlbSwgYnV0 IG9uIFNNUCBzeXN0ZW1zLCB0aGlzIHByb2JsZW0gaXMgZm9yZXNlZWFibGUsIHNvIHdlIGhvcGUg dG8NCj4gPiAgIHNvbHZlIGl0IGF0IHRoZSBiZWdpbm5pbmcpLg0KPiA+DQo+ID4gICBXaHkgd2Ug bmVlZCB0byBzd2l0Y2ggdGhlIE1QVSBjb25maWd1cmF0aW9uIHRoYXQgbGF0ZT8NCj4gPiAgIEJl Y2F1c2Ugd2UgbmVlZCB0byByZS1vcmRlciB0aGUgTVBVIHJlZ2lvbnMgdG8gcmVkdWNlIGNvbXBs ZXhpdHkgb2YNCj4gcnVudGltZQ0KPiA+ICAgTVBVIHJlZ2lvbnMgbWFuYWdlbWVudC4NCj4gPiAg IDEuIEluIHRoZSBib290IHN0YWdlLCB3ZSBhbGxvY2F0ZSBNUFUgcmVnaW9ucyBpbiBzZXF1ZW5j ZSB1bnRpbCB0aGUNCj4gbWF4Lg0KPiA+ICAgICAgU2luY2UgYSBmZXcgTVBVIHJlZ2lvbnMgd2ls bCBnZXQgcmVtb3ZlZCBhbG9uZyB0aGUgd2F5LCB0aGV5IHdpbGwNCj4gbGVhdmUNCj4gPiAgICAg IGhvbGVzIHRoZXJlLiBGb3IgZXhhbXBsZSwgd2hlbiBoZWFwIGlzIHJlYWR5LCBmZHQgd2lsbCBi ZQ0KPiByZWFsbG9jYXRlZA0KPiA+ICAgICAgaW4gdGhlIGhlYXAsIHdoaWNoIG1lYW5zIHRoZSBN UFUgcmVnaW9uIGZvciBkZXZpY2UgdHJlZSBpcyBuZXZlcg0KPiBuZWVkZWQuDQo+ID4gICAgICBB bmQgYWxzbyBpbiBmcmVlX2luaXRfbWVtb3J5LCBhbHRob3VnaCB3ZSBkbyBub3QgYWRkIGluaXQg bWVtb3J5IHRvDQo+IGhlYXAsDQo+ID4gICAgICB3ZSBzdGlsbCByZWNsYWltIHRoZSBNUFUgcmVn aW9ucyB0aGV5IGFyZSB1c2luZy4gV2l0aG91dCBvcmRlcmluZywNCj4gd2UNCj4gPiAgICAgIG1h eSBuZWVkIGEgYml0bWFwIHRvIHJlY29yZCBzdWNoIGluZm9ybWF0aW9uLg0KPiA+DQo+ID4gICAg ICBJbiBjb250ZXh0IHN3aXRjaCwgdGhlIG1lbW9yeSBsYXlvdXQgaXMgcXVpdGUgZGlmZmVyZW50 IGZvciBndWVzdA0KPiBtb2RlDQo+ID4gICAgICBhbmQgaHlwZXJ2aXNvciBtb2RlLiBXaGVuIHN3 aXRjaGluZyB0byBndWVzdCBtb2RlLCBvbmx5IGd1ZXN0IFJBTSwNCj4gPiAgICAgIGVtdWxhdGVk L3Bhc3N0aHJvdWdoIGRldmljZXMsIGV0YyBjb3VsZCBiZSBzZWVuLCBidXQgaW4gaHlwZXJ2aXNv cg0KPiBtb2RlLA0KPiA+ICAgICAgYWxsIFhlbiB1c2VkIGRldmljZXMgYW5kIGd1ZXN0cyBSQU0g c2hhbGwgYmUgc2Vlbi4gQW5kIHdpdGhvdXQNCj4gcmVvcmRlcmluZywNCj4gPiAgICAgIHdlIG5l ZWQgdG8gaXRlcmF0ZSBhbGwgTVBVIHJlZ2lvbnMgdG8gZmluZCBhY2NvcmRpbmcgcmVnaW9ucyB0 bw0KPiBkaXNhYmxlDQo+ID4gICAgICBkdXJpbmcgcnVudGltZSBjb250ZXh0IHN3aXRjaCwgdGhh dCdzIGRlZmluaXRlbHkgYSBvdmVyaGVhZC4NCj4gPg0KPiA+ICAgICAgU28gd2UgcHJvcG9zZSBh biBvcmRlcmluZyBhdCB0aGUgdGFpbCBvZiB0aGUgYm9vdCB0aW1lLCB0byBwdXQgYWxsDQo+IGZp eGVkDQo+ID4gICAgICBNUFUgcmVnaW9ucyBpbiB0aGUgaGVhZCwgbGlrZSB4ZW4gdGV4dC9kYXRh LCBldGMsIGFuZCBwdXQgYWxsDQo+IGZsZXhpYmxlDQo+ID4gICAgICBvbmVzIGF0IHRhaWwsIGxp a2UgZGV2aWNlIG1lbW9yeSwgZ3Vlc3RzIFJBTS4NCj4gPg0KPiA+ICAgICAgVGhlbiBsYXRlciBp biBydW50aW1lLCBsaWtlIGNvbnRleHQgc3dpdGNoLCB3ZSBjb3VsZCBlYXNpbHkganVzdA0KPiBk aXNhYmxlDQo+ID4gICAgICBvbmVzIGZyb20gdGFpbCBhbmQgaW5zZXJ0cyBuZXcgb25lcyBpbiB0 aGUgdGFpbC4NCj4gPg0KPiA+ICMjIyAqKjIuMy4gQ2hhbmdlcyB0byByZWR1Y2UgbWVtb3J5IGZy YWdtZW50YXRpb24qKg0KPiA+DQo+ID4gSW4gZ2VuZXJhbCwgbWVtb3J5IGluIFhlbiBzeXN0ZW0g Y2FuIGJlIGNsYXNzaWZpZWQgdG8gNCBjbGFzc2VzOg0KPiA+IGBpbWFnZSBzZWN0aW9uc2AsIGBo ZWFwIHNlY3Rpb25zYCwgYGd1ZXN0IFJBTWAsIGBib290IG1vZHVsZXMgKGd1ZXN0DQo+IEtlcm5l bCwNCj4gPiBpbml0cmQgYW5kIGR0YilgDQo+ID4NCj4gPiBDdXJyZW50bHksIFhlbiBkb2Vzbid0 IGhhdmUgYW55IHJlc3RyaWN0aW9uIGZvciB1c2VycyBob3cgdG8gYWxsb2NhdGUNCj4gPiBtZW1v cnkgZm9yIGRpZmZlcmVudCBjbGFzc2VzLiBUaGF0IG1lYW5zIHVzZXJzIGNhbiBwbGFjZSBib290 IG1vZHVsZXMNCj4gPiBhbnl3aGVyZSwgY2FuIHJlc2VydmUgWGVuIGhlYXAgbWVtb3J5IGFueXdo ZXJlIGFuZCBjYW4gYWxsb2NhdGUgZ3Vlc3QNCj4gPiBtZW1vcnkgYW55d2hlcmUuDQo+ID4NCj4g PiBJbiBhIFZNU0Egc3lzdGVtLCB0aGlzIHdvdWxkIG5vdCBiZSB0b28gbXVjaCBvZiBhIHByb2Js ZW0sIHNpbmNlIHRoZQ0KPiA+IE1NVSBjYW4gbWFuYWdlIG1lbW9yeSBhdCBhIGdyYW51bGFyaXR5 IG9mIDRLQiBhZnRlciBhbGwuIEJ1dCBpbiBhDQo+ID4gUE1TQSBzeXN0ZW0sIHRoaXMgd2lsbCBi ZSBhIGJpZyBwcm9ibGVtLiBPbiBBcm12OC1SNjQsIHRoZSBtYXggTVBVDQo+ID4gcHJvdGVjdGlv biByZWdpb25zIG51bWJlciBoYXMgYmVlbiBsaW1pdGVkIHRvIDI1Ni4gQnV0IGluIHR5cGljYWwN Cj4gPiBwcm9jZXNzb3IgaW1wbGVtZW50YXRpb25zLCBmZXcgcHJvY2Vzc29ycyB3aWxsIGRlc2ln biBtb3JlIHRoYW4gMzINCj4gPiBNUFUgcHJvdGVjdGlvbiByZWdpb25zLiBBZGQgaW4gdGhlIGZh Y3QgdGhhdCBYZW4gc2hhcmVzIE1QVSBwcm90ZWN0aW9uDQo+ID4gcmVnaW9ucyB3aXRoIGd1ZXN0 J3MgRUwxIFN0YWdlIDIuIEl0IGJlY29tZXMgZXZlbiBtb3JlIGltcG9ydGFudA0KPiA+IHRvIHBy b3Blcmx5IHBsYW4gdGhlIHVzZSBvZiBNUFUgcHJvdGVjdGlvbiByZWdpb25zLg0KPiA+DQo+ID4g LSBBbiBpZGVhbCBvZiBtZW1vcnkgdXNhZ2UgbGF5b3V0IHJlc3RyaWN0aW9uOg0KPiA+ICFbaW1n XShodHRwczovL2RyaXZlLmdvb2dsZS5jb20vdWM/ZXhwb3J0PXZpZXcmaWQ9MWtpck9MMFR4MmFB eXBUdGQza1hBdA0KPiBkNzVYdHJuZ2NuVykNCj4gPiAxLiBSZXNlcnZlIHByb3BlciBNUFUgcmVn aW9ucyBmb3IgWGVuIGltYWdlIChjb2RlLCByb2RhdGEgYW5kIGRhdGEgKw0KPiBic3MpLg0KPiA+ IDIuIFJlc2VydmUgb25lIE1QVSByZWdpb24gZm9yIGJvb3QgbW9kdWxlcy4NCj4gPiAgICBUaGF0 IG1lYW5zIHRoZSBwbGFjZW1lbnQgb2YgYWxsIGJvb3QgbW9kdWxlcywgaW5jbHVkZSBndWVzdCBr ZXJuZWwsDQo+ID4gICAgaW5pdHJkIGFuZCBkdGIsIHdpbGwgYmUgbGltaXRlZCB0byB0aGlzIE1Q VSByZWdpb24gcHJvdGVjdGVkIGFyZWEuDQo+ID4gMy4gUmVzZXJ2ZSBvbmUgb3IgbW9yZSBNUFUg cmVnaW9ucyBmb3IgWGVuIGhlYXAuDQo+ID4gICAgT24gQXJtdjgtUjY0LCB0aGUgZ3Vlc3QgbWVt b3J5IGlzIHByZWRlZmluZWQgaW4gZGV2aWNlIHRyZWUsIGl0IHdpbGwNCj4gPiAgICBub3QgYmUg YWxsb2NhdGVkIGZyb20gaGVhcC4gVW5saWtlIEFybXY4LUE2NCwgd2Ugd2lsbCBub3QgbW92ZSBh bGwNCj4gPiAgICBmcmVlIG1lbW9yeSB0byBoZWFwLiBXZSB3YW50IFhlbiBoZWFwIGlzIGRldGVy bWluaXN0aWMgdG9vLCBzbyBYZW4gb24NCj4gPiAgICBBcm12OC1SNjQgYWxzbyByZWx5IG9uIFhl biBzdGF0aWMgaGVhcCBmZWF0dXJlLiBUaGUgbWVtb3J5IGZvciBYZW4NCj4gPiAgICBoZWFwIHdp bGwgYmUgZGVmaW5lZCBpbiB0cmVlIHRvby4gQ29uc2lkZXJpbmcgdGhhdCBwaHlzaWNhbCBtZW1v cnkNCj4gPiAgICBjYW4gYWxzbyBiZSBkaXNjb250aW51b3VzLCBvbmUgb3IgbW9yZSBNUFUgcHJv dGVjdGlvbiByZWdpb25zIG5lZWRzDQo+ID4gICAgdG8gYmUgcmVzZXJ2ZWQgZm9yIFhlbiBIRUFQ Lg0KPiA+IDQuIElmIHdlIG5hbWUgYWJvdmUgdXNlZCBNUFUgcHJvdGVjdGlvbiByZWdpb25zIFBB UlRfQSwgYW5kIG5hbWUgbGVmdA0KPiA+ICAgIE1QVSBwcm90ZWN0aW9uIHJlZ2lvbnMgUEFSVF9C Og0KPiA+ICAgIDQuMS4gSW4gaHlwZXJ2aXNvciBjb250ZXh0LCBYZW4gd2lsbCBtYXAgbGVmdCBS QU0gYW5kIGRldmljZXMgdG8NCj4gUEFSVF9CLg0KPiA+ICAgICAgICAgVGhpcyB3aWxsIGdpdmUg WGVuIHRoZSBhYmlsaXR5IHRvIGFjY2VzcyB3aG9sZSBtZW1vcnkuDQo+ID4gICAgNC4yLiBJbiBn dWVzdCBjb250ZXh0LCBYZW4gd2lsbCBjcmVhdGUgRUwxIHN0YWdlIDIgbWFwcGluZyBpbiBQQVJU X0IuDQo+ID4gICAgICAgICBJbiB0aGlzIGNhc2UsIFhlbiBqdXN0IG5lZWQgdG8gdXBkYXRlIFBB UlRfQiBpbiBjb250ZXh0IHN3aXRjaCwNCj4gPiAgICAgICAgIGJ1dCBrZWVwIFBBUlRfQSBhcyBm aXhlZC4NCj4gPg0KPiA+ICoqKk5vdGVzOiBTdGF0aWMgYWxsb2NhdGlvbiB3aWxsIGJlIG1hbmRh dG9yeSBvbiBNUFUgYmFzZWQgc3lzdGVtcyoqKg0KPiA+DQo+ID4gKipBIHNhbXBsZSBkZXZpY2Ug dHJlZSBvZiBtZW1vcnkgbGF5b3V0IHJlc3RyaWN0aW9uKio6DQo+ID4gYGBgDQo+ID4gY2hvc2Vu IHsNCj4gPiAgICAgLi4uDQo+ID4gICAgIC8qDQo+ID4gICAgICAqIERlZmluZSBhIHNlY3Rpb24g dG8gcGxhY2UgYm9vdCBtb2R1bGVzLA0KPiA+ICAgICAgKiBhbGwgYm9vdCBtb2R1bGVzIG11c3Qg YmUgcGxhY2VkIGluIHRoaXMgc2VjdGlvbi4NCj4gPiAgICAgICovDQo+ID4gICAgIG1wdSxib290 LW1vZHVsZS1zZWN0aW9uID0gPDB4MTAwMDAwMDAgMHgxMDAwMDAwMD47DQo+ID4gICAgIC8qDQo+ ID4gICAgICAqIERlZmluZSBhIHNlY3Rpb24gdG8gY292ZXIgYWxsIGd1ZXN0IFJBTS4gQWxsIGd1 ZXN0IFJBTSBtdXN0IGJlDQo+IGxvY2F0ZWQNCj4gPiAgICAgICogd2l0aGluIHRoaXMgc2VjdGlv bi4gVGhlIHByb3MgaXMgdGhhdCwgaW4gYmVzdCBjYXNlLCB3ZSBjYW4gb25seQ0KPiBoYXZlDQo+ ID4gICAgICAqIG9uZSBNUFUgcHJvdGVjdGlvbiByZWdpb24gdG8gbWFwIGFsbCBndWVzdCBSQU0g Zm9yIFhlbi4NCj4gPiAgICAgICovDQo+ID4gICAgIG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbiA9 IDwweDIwMDAwMDAwIDB4MzAwMDAwMDA+Ow0KPiA+ICAgICAvKg0KPiA+ICAgICAgKiBEZWZpbmUg YSBtZW1vcnkgc2VjdGlvbiB0aGF0IGNhbiBjb3ZlciBhbGwgZGV2aWNlIG1lbW9yeSB0aGF0DQo+ ID4gICAgICAqIHdpbGwgYmUgdXNlZCBpbiBYZW4uDQo+ID4gICAgICAqLw0KPiA+ICAgICBtcHUs ZGV2aWNlLW1lbW9yeS1zZWN0aW9uID0gPDB4ODAwMDAwMDAgMHg3ZmZmZjAwMD47DQo+ID4gICAg IC8qIERlZmluZSBhIHNlY3Rpb24gZm9yIFhlbiBoZWFwICovDQo+ID4gICAgIHhlbixzdGF0aWMt bWVtID0gPDB4NTAwMDAwMDAgMHgyMDAwMDAwMD47DQo+ID4NCj4gPiAgICAgZG9tVTEgew0KPiA+ ICAgICAgICAgLi4uDQo+ID4gICAgICAgICAjeGVuLHN0YXRpYy1tZW0tYWRkcmVzcy1jZWxscyA9 IDwweDAxPjsNCj4gPiAgICAgICAgICN4ZW4sc3RhdGljLW1lbS1zaXplLWNlbGxzID0gPDB4MDE+ Ow0KPiA+ICAgICAgICAgLyogU3RhdGljYWxseSBhbGxvY2F0ZWQgZ3Vlc3QgbWVtb3J5LCB3aXRo aW4gbXB1LGd1ZXN0LW1lbW9yeS0NCj4gc2VjdGlvbiAqLw0KPiA+ICAgICAgICAgeGVuLHN0YXRp Yy1tZW0gPSA8MHgzMDAwMDAwMCAweDFmMDAwMDAwPjsNCj4gPg0KPiA+ICAgICAgICAgbW9kdWxl QDExMDAwMDAwIHsNCj4gPiAgICAgICAgICAgICBjb21wYXRpYmxlID0gIm11bHRpYm9vdCxrZXJu ZWxcMG11bHRpYm9vdCxtb2R1bGUiOw0KPiA+ICAgICAgICAgICAgIC8qIEJvb3QgbW9kdWxlIGFk ZHJlc3MsIHdpdGhpbiBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbiAqLw0KPiA+ICAgICAgICAgICAg IHJlZyA9IDwweDExMDAwMDAwIDB4MzAwMDAwMD47DQo+ID4gICAgICAgICAgICAgLi4uDQo+ID4g ICAgICAgICB9Ow0KPiA+DQo+ID4gICAgICAgICBtb2R1bGVAMTBGRjAwMDAgew0KPiA+ICAgICAg ICAgICAgICAgICBjb21wYXRpYmxlID0gIm11bHRpYm9vdCxkZXZpY2UtdHJlZVwwbXVsdGlib290 LG1vZHVsZSI7DQo+ID4gICAgICAgICAgICAgICAgIC8qIEJvb3QgbW9kdWxlIGFkZHJlc3MsIHdp dGhpbiBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbg0KPiAqLw0KPiA+ICAgICAgICAgICAgICAgICBy ZWcgPSA8MHgxMGZmMDAwMCAweDEwMDAwPjsNCj4gPiAgICAgICAgICAgICAgICAgLi4uDQo+ID4g ICAgICAgICB9Ow0KPiA+ICAgICB9Ow0KPiA+IH07DQo+ID4gYGBgDQo+ID4gSXQncyBsaXR0bGUg aGFyZCBmb3IgdXNlcnMgdG8gY29tcG9zZSBzdWNoIGEgZGV2aWNlIHRyZWUgYnkgaGFuZC4gQmFz ZWQNCj4gPiBvbiB0aGUgZGlzY3Vzc2lvbiBvZiBEcmFmdC1BLCBYZW4gY29tbXVuaXR5IHN1Z2dl c3RlZCB1c2VycyB0byB1c2Ugc29tZQ0KPiA+IHRvb2xzIGxpa2UgW2ltYWdlYnVpbGRlcl0oaHR0 cHM6Ly9naXRsYWIuY29tL3hlbi1wcm9qZWN0L2ltYWdlYnVpbGRlcikNCj4gdG8gZ2VuZXJhdGUg dGhlIGFib3ZlIGRldmljZSB0cmVlIHByb3BlcnRpZXMuDQo+ID4gUGxlYXNlIGdvdG8gVE9ETyMz LjMgc2VjdGlvbiB0byBnZXQgbW9yZSBkZXRhaWxzIG9mIHRoaXMgc3VnZ2VzdGlvbi4NCj4gPg0K PiA+ICMjIyAqKjIuNC4gQ2hhbmdlcyBvZiBtZW1vcnkgbWFuYWdlbWVudCoqDQo+ID4gWGVuIGlz IGNvdXBsZWQgd2l0aCBWTVNBLCBpbiBvcmRlciB0byBwb3J0IFhlbiB0byBBcm12OC1SNjQsIHdl IGhhdmUgdG8NCj4gPiBkZWNvdXBsZSBYZW4gZnJvbSBWTVNBLiBBbmQgZ2l2ZSBYZW4gdGhlIGFi aWxpdHkgdG8gbWFuYWdlIG1lbW9yeSBpbg0KPiBQTVNBLg0KPiA+DQo+ID4gMS4gKioqVXNlIGJ1 ZGR5IGFsbG9jYXRvciB0byBtYW5hZ2UgcGh5c2ljYWwgcGFnZXMgZm9yIFBNU0EqKioNCj4gPiAg ICBGcm9tIHRoZSB2aWV3IG9mIHBoeXNpY2FsIHBhZ2UsIFBNU0EgYW5kIFZNU0EgZG9uJ3QgaGF2 ZSBhbnkNCj4gZGlmZmVyZW5jZS4NCj4gPiAgICBTbyB3ZSBjYW4gcmV1c2UgYnVkZHkgYWxsb2Nh dG9yIG9uIEFybXY4LVI2NCB0byBtYW5hZ2UgcGh5c2ljYWwgcGFnZXMuDQo+ID4gICAgVGhlIGRp ZmZlcmVuY2UgaXMgdGhhdCwgaW4gVk1TQSwgWGVuIHdpbGwgbWFwIGFsbG9jYXRlZCBwYWdlcyB0 bw0KPiB2aXJ0dWFsDQo+ID4gICAgYWRkcmVzc2VzLiBCdXQgaW4gUE1TQSwgWGVuIGp1c3QgY29u dmVydCB0aGUgcGFnZXMgdG8gcGh5c2ljYWwNCj4gYWRkcmVzcy4NCj4gPg0KPiA+IDIuICoqKkNh biBub3QgdXNlIHZpcnR1YWwgYWRkcmVzcyBmb3IgbWVtb3J5IG1hbmFnZW1lbnQqKioNCj4gPiAg ICBBcyBBcm12OC1SNjQgb25seSBoYXMgUE1TQSBpbiBFTDIsIFhlbiBsb3NlcyB0aGUgYWJpbGl0 eSBvZiB1c2luZw0KPiB2aXJ0dWFsDQo+ID4gICAgYWRkcmVzcyB0byBtYW5hZ2UgbWVtb3J5LiBU aGlzIGJyaW5ncyBzb21lIHByb2JsZW1zLCBzb21lIHZpcnR1YWwNCj4gYWRkcmVzcw0KPiA+ICAg IGJhc2VkIGZlYXR1cmVzIGNvdWxkIG5vdCB3b3JrIHdlbGwgb24gQXJtdjgtUjY0LCBsaWtlIGBG SVhNQVBgLA0KPiBgdm1hcC92dW1hcGAsDQo+ID4gICAgYGlvcmVtYXBgIGFuZCBgYWx0ZXJuYXRp dmVgLg0KPiA+DQo+ID4gICAgQnV0IHRoZSBmdW5jdGlvbnMgb3IgbWFjcm9zIG9mIHRoZXNlIGZl YXR1cmVzIGFyZSB1c2VkIGluIGxvdHMgb2YNCj4gY29tbW9uDQo+ID4gICAgY29kZS4gU28gaXQn cyBub3QgZ29vZCB0byB1c2UgYCNpZmRlZiBDT05GSUdfQVJNX01QVWAgdG8gZ2F0ZSByZWxhdGUN Cj4gY29kZQ0KPiA+ICAgIGV2ZXJ5d2hlcmUuIEluIHRoaXMgY2FzZSwgd2UgcHJvcG9zZSB0byB1 c2Ugc3R1YiBoZWxwZXJzIHRvIG1ha2UgdGhlDQo+IGNoYW5nZXMNCj4gPiAgICB0cmFuc3BhcmVu dGx5IHRvIGNvbW1vbiBjb2RlLg0KPiA+ICAgIDEuIEZvciBgRklYTUFQYCwgd2Ugd2lsbCB1c2Ug YDBgIGluIGBGSVhNQVBfQUREUmAgZm9yIGFsbCBmaXhtYXANCj4gb3BlcmF0aW9ucy4NCj4gPiAg ICAgICBUaGlzIHdpbGwgcmV0dXJuIHBoeXNpY2FsIGFkZHJlc3MgZGlyZWN0bHkgb2YgZml4bWFw cGVkIGl0ZW0uDQo+ID4gICAgMi4gRm9yIGB2bWFwL3Z1bWFwYCwgd2Ugd2lsbCB1c2Ugc29tZSBl bXB0eSBpbmxpbmUgc3R1YiBoZWxwZXJzOg0KPiA+ICAgICAgICAgYGBgDQo+ID4gICAgICAgICBz dGF0aWMgaW5saW5lIHZvaWQgdm1faW5pdF90eXBlKC4uLikge30NCj4gPiAgICAgICAgIHN0YXRp YyBpbmxpbmUgdm9pZCAqX192bWFwKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAg ICByZXR1cm4gTlVMTDsNCj4gPiAgICAgICAgIH0NCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUg dm9pZCB2dW5tYXAoY29uc3Qgdm9pZCAqdmEpIHt9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5l IHZvaWQgKnZtYWxsb2Moc2l6ZV90IHNpemUpDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAg ICAgcmV0dXJuIE5VTEw7DQo+ID4gICAgICAgICB9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5l IHZvaWQgKnZtYWxsb2NfeGVuKHNpemVfdCBzaXplKQ0KPiA+ICAgICAgICAgew0KPiA+ICAgICAg ICAgICAgIHJldHVybiBOVUxMOw0KPiA+ICAgICAgICAgfQ0KPiA+ICAgICAgICAgc3RhdGljIGlu bGluZSB2b2lkIHZmcmVlKHZvaWQgKnZhKSB7fQ0KPiA+ICAgICAgICAgYGBgDQo+ID4NCj4gPiAg ICAzLiBGb3IgYGlvcmVtYXBgLCBpdCBkZXBlbmRzIG9uIGB2bWFwYC4gQXMgd2UgaGF2ZSBtYWtl IGB2bWFwYCB0bw0KPiBhbHdheXMNCj4gPiAgICAgICByZXR1cm4gYE5VTExgLCB0aGV5IGNvdWxk IG5vdCB3b3JrIHdlbGwgb24gQXJtdjgtUjY0IHdpdGhvdXQNCj4gY2hhbmdlcy4NCj4gPiAgICAg ICBgaW9yZW1hcGAgd2lsbCByZXR1cm4gaW5wdXQgYWRkcmVzcyBkaXJlY3RseS4gQnV0IGlmIHNv bWUgZXh0ZW5kZWQNCj4gPiAgICAgICBmdW5jdGlvbnMgbGlrZSBgaW9yZW1hcF9ub2NhY2hlYCwg YGlvcmVtYXBfY2FjaGVgLCBuZWVkIHRvIGFzayBhDQo+IG5ldw0KPiA+ICAgICAgIG1lbW9yeSBh dHRyaWJ1dGVzLiBBcyBBcm12OC1SIGRvZXNuJ3QgaGF2ZSBpbmZpbml0ZSBNUFUgcmVnaW9ucw0K PiBmb3INCj4gPiAgICAgICBYZW4gdG8gc3BsaXQgdGhlIG1lbW9yeSBhcmVhIGZyb20gaXRzIGxv Y2F0ZWQgTVBVIHJlZ2lvbiBhbmQNCj4gYXNzaWduDQo+ID4gICAgICAgdGhlIG5ldyBhdHRyaWJ1 dGVzIHRvIGl0LiBTbyBpbiBgaW9yZW1hcF9ub2NhY2hlYCwgYGlvcmVtYXBfY2FjaGVgLA0KPiA+ ICAgICAgIGlmIHRoZSBpbnB1dCBhdHRyaWJ1dGVzIGFyZSBkaWZmZXJlbnQgZnJvbSBjdXJyZW50 IG1lbW9yeQ0KPiBhdHRyaWJ1dGVzLA0KPiA+ICAgICAgIHRoZXNlIGZ1bmN0aW9ucyB3aWxsIHJl dHVybiBgTlVMTGAuDQo+ID4gICAgICAgICBgYGANCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUg dm9pZCAqaW9yZW1hcF9hdHRyKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAgICAgICAv KiBXZSBkb24ndCBoYXZlIHRoZSBhYmlsaXR5IHRvIGNoYW5nZSBpbnB1dCBQQSBjYWNoZQ0KPiBh dHRyaWJ1dGVzICovDQo+ID4gICAgICAgICAgICAgaWYgKCBDQUNIRV9BVFRSX25lZWRfY2hhbmdl ICkNCj4gPiAgICAgICAgICAgICAgICAgcmV0dXJuIE5VTEw7DQo+ID4gICAgICAgICAgICAgcmV0 dXJuICh2b2lkICopcGE7DQo+ID4gICAgICAgICB9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5l IHZvaWQgX19pb21lbSAqaW9yZW1hcF9ub2NhY2hlKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAg ICAgICAgICAgICByZXR1cm4gaW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNP Ul9OT0NBQ0hFKTsNCj4gPiAgICAgICAgIH0NCj4gPiAgICAgICAgIHN0YXRpYyBpbmxpbmUgdm9p ZCBfX2lvbWVtICppb3JlbWFwX2NhY2hlKC4uLikNCj4gPiAgICAgICAgIHsNCj4gPiAgICAgICAg ICAgICByZXR1cm4gaW9yZW1hcF9hdHRyKHN0YXJ0LCBsZW4sIFBBR0VfSFlQRVJWSVNPUik7DQo+ ID4gICAgICAgICB9DQo+ID4gICAgICAgICBzdGF0aWMgaW5saW5lIHZvaWQgX19pb21lbSAqaW9y ZW1hcF93YyguLi4pDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAgICAgICAgcmV0dXJuIGlvcmVt YXBfYXR0cihzdGFydCwgbGVuLCBQQUdFX0hZUEVSVklTT1JfV0MpOw0KPiA+ICAgICAgICAgfQ0K PiA+ICAgICAgICAgdm9pZCAqaW9yZW1hcCguLi4pDQo+ID4gICAgICAgICB7DQo+ID4gICAgICAg ICAgICAgcmV0dXJuIGlvcmVtYXBfYXR0cihwYSwgbGVuLCBQQUdFX0hZUEVSVklTT1JfTk9DQUNI RSk7DQo+ID4gICAgICAgICB9DQo+ID4NCj4gPiAgICAgICAgIGBgYA0KPiA+ICAgICA0LiBGb3Ig YGFsdGVybmF0aXZlYCwgaXQgaGFzIGJlZW4gbGlzdGVkIGluIFRPRE8sIHdlIHdpbGwgc2ltcGx5 DQo+IGRpc2FibGUNCj4gPiAgICAgICAgaXQgb24gQXJtdjgtUjY0IGluIGN1cnJlbnQgc3RhZ2Uu IEJ1dCBzaW1wbHkgZGlzYWJsZQ0KPiBgYWx0ZXJuYXRpdmVgDQo+ID4gICAgICAgIHdpbGwgbWFr ZSBgY3B1c19oYXZlX2NvbnN0X2NhcGAgYWx3YXlzIHJldHVybiBmYWxzZS4NCj4gPiAgICAgICAg IGBgYA0KPiA+ICAgICAgICAgKiBTeXN0ZW0gY2FwYWJpbGl0eSBjaGVjayBmb3IgY29uc3RhbnQg Y2FwICovDQo+ID4gICAgICAgICAjZGVmaW5lIGNwdXNfaGF2ZV9jb25zdF9jYXAobnVtKSAoeyAg ICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgcmVnaXN0ZXJfdCBfX3JldDsgICAg ICAgICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgYXNt IHZvbGF0aWxlIChBTFRFUk5BVElWRSgibW92ICUwLCAjMCIsICAgICBcDQo+ID4gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAibW92ICUwLCAjMSIsICAgICBcDQo+ID4g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBudW0pICAgICAgICAgICAg ICBcDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICA6ICI9ciIgKF9fcmV0KSk7ICAg ICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgIHVubGlrZWx5KF9fcmV0 KTsgICAgICAgICAgICAgICAgICAgICAgICAgICBcDQo+ID4gICAgICAgICAgICAgICAgIH0pDQo+ ID4gICAgICAgICBgYGANCj4gPiAgICAgICAgIFNvLCBiZWZvcmUgd2UgaGF2ZSBhbiBQTVNBIGBh bHRlcm5hdGl2ZWAgaW1wbGVtZW50YXRpb24sIHdlIGhhdmUNCj4gdG8NCj4gPiAgICAgICAgIGlt cGxlbWVudCBhIHNlcGFyYXRlIGBjcHVzX2hhdmVfY29uc3RfY2FwYCBmb3IgQXJtdjgtUjY0Og0K PiA+ICAgICAgICAgYGBgDQo+ID4gICAgICAgICAjZGVmaW5lIGNwdXNfaGF2ZV9jb25zdF9jYXAo bnVtKSBjcHVzX2hhdmVfY2FwKG51bSkNCj4gPiAgICAgICAgIGBgYA0KPiA+DQo+ID4gIyMjICoq Mi41LiBDaGFuZ2VzIG9mIGd1ZXN0IG1hbmFnZW1lbnQqKg0KPiA+IEFybXY4LVI2NCBvbmx5IHN1 cHBvcnRzIFBNU0EgaW4gRUwyLCBidXQgaXQgc3VwcG9ydHMgY29uZmlndXJhYmxlDQo+ID4gVk1T QSBvciBQTVNBIGluIEVMMS4gVGhpcyBtZWFucyBYZW4gd2lsbCBoYXZlIGEgbmV3IHR5cGUgZ3Vl c3Qgb24NCj4gPiBBcm12OC1SNjQgLSBNUFUgYmFzZWQgZ3Vlc3QuDQo+ID4NCj4gPiAxLiAqKkFk ZCBhIG5ldyBkb21haW4gdHlwZSAtIE1QVV9ET01BSU4qKg0KPiA+ICAgIFdoZW4gdXNlciB3YW50 IHRvIGNyZWF0ZSBhIGd1ZXN0IHRoYXQgd2lsbCBiZSB1c2luZyBNUFUgaW4gRUwxLCB1c2VyDQo+ ID4gICAgc2hvdWxkIGFkZCBhIGBtcHVgIHByb3BlcnR5IGluIGRldmljZSB0cmVlIGBkb21VYCBu b2RlLCBsaWtlDQo+IGZvbGxvd2luZw0KPiA+ICAgIGV4YW1wbGU6DQo+ID4gICAgIGBgYA0KPiA+ ICAgICBkb21VMiB7DQo+ID4gICAgICAgICBjb21wYXRpYmxlID0gInhlbixkb21haW4iOw0KPiA+ ICAgICAgICAgZGlyZWN0LW1hcDsNCj4gPiAgICAgICAgIG1wdTsgLS0+IEluZGljYXRlcyB0aGlz IGRvbWFpbiB3aWxsIHVzZSBQTVNBIGluIEVMMS4NCj4gPiAgICAgICAgIC4uLg0KPiA+ICAgICB9 Ow0KPiA+ICAgICBgYGANCj4gPiAgICAgQ29ycmVzcG9uZGluZyB0byBgbXB1YCBwcm9wZXJ0eSBp biBkZXZpY2UgdHJlZSwgd2UgYWxzbyBuZWVkIHRvDQo+IGludHJvZHVjZQ0KPiA+ICAgICBhIG5l dyBmbGFnIGBYRU5fRE9NQ1RMX0NERl9JTlRFUk5BTF9tcHVgIGZvciBkb21haW4gdG8gbWFyayBp dHNlbGYNCj4gYXMgYW4NCj4gPiAgICAgTVBVIGRvbWFpbi4gVGhpcyBmbGFnIHdpbGwgYmUgdXNl ZCBpbiBkb21haW4gY3JlYXRpb24gYW5kIGRvbWFpbg0KPiBkb2luZw0KPiA+ICAgICB2Q1BVIGNv bnRleHQgc3dpdGNoLg0KPiA+ICAgICAxLiBEb21haW4gY3JlYXRpb24gbmVlZCB0aGlzIGZsYWcg dG8gZGVjaWRlIGVuYWJsZSBQTVNBIG9yIFZNU0EgaW4NCj4gRUwxLg0KPiA+ICAgICAyLiB2Q1BV IGNvbnRleHQgc3dpdGNoIG5lZWQgdGhpcyBmbGFnIHRvIGRlY2lkZSBzYXZlL3Jlc3RvcmUgTU1V IG9yDQo+IE1QVQ0KPiA+ICAgICAgICByZWxhdGVkIHJlZ2lzdGVycy4NCj4gPg0KPiA+IDIuICoq QWRkIE1QVSByZWdpc3RlcnMgZm9yIHZDUFUgdG8gc2F2ZSBFTDEgTVBVIGNvbnRleHQqKg0KPiA+ ICAgIEN1cnJlbnQgWGVuIG9ubHkgc3VwcG9ydHMgTU1VIGJhc2VkIGd1ZXN0LCBzbyBpdCBoYXNu J3QgY29uc2lkZXJlZCB0bw0KPiA+ICAgIHNhdmUvcmVzdG9yZSBNUFUgY29udGV4dC4gSW4gdGhp cyBjYXNlLCB3ZSBuZWVkIHRvIGFkZCBNUFUgcmVnaXN0ZXJzDQo+ID4gICAgdG8gYGFyY2hfdmNw dWA6DQo+ID4gICAgIGBgYA0KPiA+ICAgICBzdHJ1Y3QgYXJjaF92Y3B1DQo+ID4gICAgIHsNCj4g PiAgICAgICAgIC4uLg0KPiA+ICAgICAjaWZkZWYgQ09ORklHX0FSTV9NUFUNCj4gPiAgICAgICAg IC8qIFZpcnR1YWxpemF0aW9uIFRyYW5zbGF0aW9uIENvbnRyb2wgUmVnaXN0ZXIgKi8NCj4gPiAg ICAgICAgIHJlZ2lzdGVyX3QgdnRjcl9lbDI7DQo+ID4NCj4gPiAgICAgICAgIC8qIEVMMSBNUFUg cmVnaW9ucycgcmVnaXN0ZXJzICovDQo+ID4gICAgICAgICBwcl90ICptcHVfcmVnaW9uczsNCj4g PiAgICAgI2VuZGlmDQo+ID4gICAgICAgICAuLi4NCj4gPiAgICAgfQ0KPiA+ICAgICBgYGANCj4g PiAgICAgQXJtdjgtUjY0IGNhbiBzdXBwb3J0IG1heCB0byAyNTYgTVBVIHJlZ2lvbnMuIEJ1dCB0 aGF0J3MganVzdA0KPiB0aGVvcmV0aWNhbC4NCj4gPiAgICAgU28gd2UgZG9uJ3Qgd2FudCB0byBl bWJlZCBgcHJfdCBtcHVfcmVnaW9uc1syNTZdYCBpbiBgYXJjaF92Y3B1YA0KPiBkaXJlY3RseSwN Cj4gPiAgICAgdGhpcyB3aWxsIGJlIGEgbWVtb3J5IHdhc3RlIGluIG1vc3QgY2FzZXMuIEluc3Rl YWQgd2UgdXNlIGEgcG9pbnRlcg0KPiBpbg0KPiA+ICAgICBgYXJjaF92Y3B1YCB0byBsaW5rIHdp dGggYSBkeW5hbWljYWxseSBhbGxvY2F0ZWQgYG1wdV9yZWdpb25zYDoNCj4gPiAgICAgYGBgDQo+ ID4gICAgIHAtPmFyY2gubXB1X3JlZ2lvbnMgPSBfeHphbGxvYyhzaXplb2YocHJfdCkgKiBtcHVf cmVnaW9uc19jb3VudF9lbDEsDQo+IFNNUF9DQUNIRV9CWVRFUyk7DQo+ID4gICAgIGBgYA0KPiA+ ICAgICBBcyBgYXJjaF92Y3B1YCBpcyB1c2VkIHZlcnkgZnJlcXVlbnRseSBpbiBjb250ZXh0IHN3 aXRjaCwgc28gWGVuDQo+IGRlZmluZXMNCj4gPiAgICAgYGFyY2hfdmNwdWAgYXMgYSBjYWNoZSBh bGlnbm1lbnQgZGF0YSBzdHJ1Y3R1cmUuIGBtcHVfcmVnaW9uc2AgYWxzbw0KPiB3aWxsDQo+ID4g ICAgIGJlIHVzZWQgdmVyeSBmcmVxdWVudGx5IGluIEFybXY4LVIgY29udGV4dCBzd2l0Y2guIFNv IHdlIHVzZQ0KPiBgX3h6YWxsb2NgDQo+ID4gICAgIHRvIGFsbG9jYXRlIGBTTVBfQ0FDSEVfQllU RVNgIGFsaWdubWVudCBtZW1vcnkgZm9yIGBtcHVfcmVnaW9uc2AuDQo+ID4NCj4gPiAgICAgYG1w dV9yZWdpb25zX2NvdW50X2VsMWAgY2FuIGJlIGRldGVjdGVkIGZyb20gYE1QVUlSX0VMMWAgc3lz dGVtDQo+IHJlZ2lzdGVyDQo+ID4gICAgIGluIFhlbiBib290IHN0YWdlLiBUaGUgbGltaXRhdGlv biBpcyB0aGF0LCBpZiB3ZSBkZWZpbmUgYSBzdGF0aWMNCj4gPiAgICAgYGFyY2hfdmNwdWAsIHdl IGhhdmUgdG8gYWxsb2NhdGUgYG1wdV9yZWdpb25zYCBiZWZvcmUgdXNpbmcgaXQuDQo+ID4NCj4g PiAzLiAqKk1QVSBiYXNlZCBQMk0gdGFibGUgbWFuYWdlbWVudCoqDQo+ID4gICAgQXJtdjgtUjY0 IEVMMiBkb2Vzbid0IGhhdmUgRUwxIHN0YWdlIDIgYWRkcmVzcyB0cmFuc2xhdGlvbi4gQnV0DQo+ IHRocm91Z2gNCj4gPiAgICBQTVNBLCBpdCBzdGlsbCBoYXMgdGhlIGFiaWxpdHkgdG8gY29udHJv bCB0aGUgcGVybWlzc2lvbnMgYW5kDQo+IGF0dHJpYnV0ZXMNCj4gPiAgICBvZiBFTDEgc3RhZ2Ug Mi4gSW4gdGhpcyBjYXNlLCB3ZSBzdGlsbCBob3BlIHRvIGtlZXAgdGhlIGludGVyZmFjZQ0KPiA+ ICAgIGNvbnNpc3RlbnQgd2l0aCBNTVUgYmFzZWQgUDJNIGFzIGZhciBhcyBwb3NzaWJsZS4NCj4g Pg0KPiA+ICAgIHAybS0+cm9vdCB3aWxsIHBvaW50IHRvIGFuIGFsbG9jYXRlZCBtZW1vcnkuIElu IEFybXY4LUE2NCwgdGhpcw0KPiBtZW1vcnkNCj4gPiAgICBpcyB1c2VkIHRvIHNhdmUgdGhlIEVM MSBzdGFnZSAyIHRyYW5zbGF0aW9uIHRhYmxlLiBCdXQgaW4gQXJtdjgtUjY0LA0KPiA+ICAgIHRo aXMgbWVtb3J5IHdpbGwgYmUgdXNlZCB0byBzdG9yZSBFTDIgTVBVIHByb3RlY3Rpb24gcmVnaW9u cyB0aGF0IGFyZQ0KPiA+ICAgIHVzZWQgYnkgZ3Vlc3QuIER1cmluZyBkb21haW4gY3JlYXRpb24s IFhlbiB3aWxsIHByZXBhcmUgdGhlIGRhdGEgaW4NCj4gPiAgICB0aGlzIG1lbW9yeSB0byBtYWtl IGd1ZXN0IGNhbiBhY2Nlc3MgcHJvcGVyIFJBTSBhbmQgZGV2aWNlcy4gV2hlbiB0aGUNCj4gPiAg ICBndWVzdCdzIHZDUFUgd2lsbCBiZSBzY2hlZHVsZWQgaW4sIHRoaXMgZGF0YSB3aWxsIGJlIHdy aXR0ZW4gdG8gTVBVDQo+ID4gICAgcHJvdGVjdGlvbiByZWdpb24gcmVnaXN0ZXJzLg0KPiA+DQo+ ID4gIyMjICoqMi42LiBDaGFuZ2VzIG9mIGV4Y2VwdGlvbiB0cmFwKioNCj4gPiBBcyBBcm12OC1S NjQgaGFzIGNvbXBhdGlibGUgZXhjZXB0aW9uIG1vZGUgd2l0aCBBcm12OC1BNjQsIHNvIHdlIGNh bg0KPiByZXVzZSBtb3N0DQo+ID4gb2YgQXJtdjgtQTY0J3MgZXhjZXB0aW9uIHRyYXAgJiBoYW5k bGVyIGNvZGUuIEJ1dCBleGNlcHQgdGhlIHRyYXAgYmFzZWQNCj4gb24gRUwxDQo+ID4gc3RhZ2Ug MiB0cmFuc2xhdGlvbiBhYm9ydC4NCj4gPg0KPiA+IEluIEFybXY4LUE2NCwgd2UgdXNlIGBGU0Nf RkxUX1RSQU5TYA0KPiA+IGBgYA0KPiA+ICAgICBjYXNlIEZTQ19GTFRfVFJBTlM6DQo+ID4gICAg ICAgICAuLi4NCj4gPiAgICAgICAgIGlmICggaXNfZGF0YSApDQo+ID4gICAgICAgICB7DQo+ID4g ICAgICAgICAgICAgZW51bSBpb19zdGF0ZSBzdGF0ZSA9IHRyeV9oYW5kbGVfbW1pbyhyZWdzLCBo c3IsIGdwYSk7DQo+ID4gICAgICAgICAgICAgLi4uDQo+ID4gICAgICAgICB9DQo+ID4gYGBgDQo+ ID4gQnV0IGZvciBBcm12OC1SNjQsIHdlIGhhdmUgdG8gdXNlIGBGU0NfRkxUX1BFUk1gDQo+ID4g YGBgDQo+ID4gICAgIGNhc2UgRlNDX0ZMVF9QRVJNOg0KPiA+ICAgICAgICAgLi4uDQo+ID4gICAg ICAgICBpZiAoIGlzX2RhdGEgKQ0KPiA+ICAgICAgICAgew0KPiA+ICAgICAgICAgICAgIGVudW0g aW9fc3RhdGUgc3RhdGUgPSB0cnlfaGFuZGxlX21taW8ocmVncywgaHNyLCBncGEpOw0KPiA+ICAg ICAgICAgICAgIC4uLg0KPiA+ICAgICAgICAgfQ0KPiA+IGBgYA0KPiA+DQo+ID4gIyMjICoqMi41 LiBDaGFuZ2VzIG9mIGRldmljZSBkcml2ZXIqKg0KPiA+IEJlY2F1c2UgQXJtdjgtUjY0IG9ubHkg aGFzIHNpbmdsZSBzZWN1cmUgc3RhdGUsIHRoaXMgd2lsbCBhZmZlY3Qgc29tZQ0KPiA+IGRldmlj ZXMgdGhhdCBoYXZlIHR3byBzZWN1cmUgc3RhdGUsIGxpa2UgR0lDLiBCdXQgZm9ydHVuYXRlbHks IG1vc3QNCj4gPiB2ZW5kb3JzIHdpbGwgbm90IGxpbmsgYSB0d28gc2VjdXJlIHN0YXRlIEdJQyB0 byBBcm12OC1SNjQgcHJvY2Vzc29ycy4NCj4gPiBDdXJyZW50IEdJQyBkcml2ZXIgY2FuIHdvcmsg d2VsbCB3aXRoIHNpbmdsZSBzZWN1cmUgc3RhdGUgR0lDIGZvciBBcm12OC0NCj4gUjY0Lg0KPiA+ DQo+ID4gIyMjICoqMi43LiBDaGFuZ2VzIG9mIHZpcnR1YWwgZGV2aWNlKioNCj4gPiBDdXJyZW50 bHksIHdlIG9ubHkgc3VwcG9ydCBwYXNzLXRocm91Z2ggZGV2aWNlcyBpbiBndWVzdC4gQmVjYXVz ZSBldmVudA0KPiA+IGNoYW5uZWwsIHhlbi1idXMsIHhlbi1zdG9yYWdlIGFuZCBvdGhlciBhZHZh bmNlZCBYZW4gZmVhdHVyZXMgaGF2ZW4ndA0KPiBiZWVuDQo+ID4gZW5hYmxlZCBpbiBBcm12OC1S NjQuDQo+ID4NCj4gPiAjIyAzLiBUT0RPDQo+ID4gVGhpcyBzZWN0aW9uIGRlc2NyaWJlcyBzb21l IGZlYXR1cmVzIHRoYXQgYXJlIG5vdCBjdXJyZW50bHkgaW1wbGVtZW50ZWQNCj4gaW4NCj4gPiB0 aGUgUG9DLiBUaG9zZSBmZWF0dXJlcyBhcmUgdGhpbmdzIHRoYXQgc2hvdWxkIGJlIGxvb2tlZCBp biBhIHNlY29uZA0KPiBzdGFnZQ0KPiA+IGFuZCB3aWxsIG5vdCBiZSBwYXJ0IG9mIHRoZSBpbml0 aWFsIHN1cHBvcnQgb2YgTVBVL0FybXY4LVIuIFRob3NlIGpvYnMNCj4gY291bGQNCj4gPiBiZSBk b25lIGJ5IEFybSBvciBhbnkgWGVuIGNvbnRyaWJ1dG9ycy4NCj4gPg0KPiA+ICMjIyAzLjEuIEFs dGVybmF0aXZlIGZyYW1ld29yayBzdXBwb3J0DQo+ID4gICAgIE9uIEFybXY4LUEgc3lzdGVtLCBg YWx0ZXJuYXRpdmVgIGlzIGRlcGVuZGluZyBvbiBgVk1BUGAgZnVuY3Rpb24gdG8NCj4gcmVtYXAN Cj4gPiAgICAgYSBjb2RlIHNlY3Rpb24gdG8gYSBuZXcgcmVhZC93cml0ZSB2aXJ0dWFsIGFkZHJl c3MuIEJ1dCBvbiBBcm12OC1SLA0KPiB3ZSBkbw0KPiA+ICAgICBub3QgaGF2ZSB2aXJ0dWFsIGFk ZHJlc3MgdG8gZG8gcmVtYXAuIFNvIGFzIGFuIGFsdGVybmF0aXZlIG1ldGhvZCwNCj4gd2Ugd2ls bA0KPiA+ICAgICBkaXNhYmxlIHRoZSBNUFUgdG8gbWFrZSBhbGwgUkFNIGBSV1hgIGluICJhcHBs eSBhbHRlcm5hdGl2ZSBhbGwNCj4gcGF0Y2hlcyINCj4gPiAgICAgcHJvZ3Jlc3MgdGVtcG9yYXJp bHkuDQo+ID4NCj4gPiAgICAgMS4gRGlzYWJsZSBNUFUgLT4gQ29kZSBzZWN0aW9uIGJlY29tZXMg UldYLg0KPiA+ICAgICAyLiBBcHBseSBhbHRlcm5hdGl2ZSBwYXRjaGVzIHRvIFhlbiB0ZXh0Lg0K PiA+ICAgICAzLiBFbmFibGUgTVBVIC0+IENvZGUgc2VjdGlvbiByZXN0b3JlcyB0byBSWC4NCj4g Pg0KPiA+ICAgICBBbGwgbWVtb3J5IGlzIFJXWCwgdGhlcmUgbWF5IGJlIHNvbWUgc2VjdXJpdHkg cmlzay4gQnV0LCBiZWNhdXNlDQo+ID4gICAgICJhbHRlcm5hdGl2ZSBhcHBseSBwYXRjaGVzIiBo YXBwZW5zIGluIFhlbiBpbml0IHN0YWdlLCBpdCBwcm9iYWJseQ0KPiA+ICAgICBkb2Vzbid0IG1h dHRlciBhcyBtdWNoLg0KPiA+DQo+ID4gIyMjIDMuMi4gWGVuIEV2ZW50IENoYW5uZWwgU3VwcG9y dA0KPiA+ICAgICBJbiBDdXJyZW50IFJGQyBwYXRjaGVzIHdlIGhhdmVuJ3QgZW5hYmxlZCB0aGUg ZXZlbnQgY2hhbm5lbCBzdXBwb3J0Lg0KPiA+ICAgICBCdXQgSSB0aGluayBpdCdzIGdvb2Qgb3Bw b3J0dW5pdHkgdG8gZG8gc29tZSBkaXNjdXNzaW9uIGluIGFkdmFuY2VkLg0KPiA+ICAgICBPbiBB cm12OC1SLCBhbGwgVk1zIGFyZSBuYXRpdmUgZGlyZWN0LW1hcCwgYmVjYXVzZSB0aGVyZSBpcyBu bw0KPiBzdGFnZTINCj4gPiAgICAgTU1VIHRyYW5zbGF0aW9uLiBDdXJyZW50IGV2ZW50IGNoYW5u ZWwgaW1wbGVtZW50YXRpb24gZGVwZW5kcyBvbg0KPiBzb21lDQo+ID4gICAgIHNoYXJlZCBwYWdl cyBiZXR3ZWVuIFhlbiBhbmQgZ3Vlc3Q6IGBzaGFyZWRfaW5mb2AgYW5kIHBlci1jcHUNCj4gYHZj cHVfaW5mb2AuDQo+ID4NCj4gPiAgICAgVGhlcmUgYXJlIHR3byBpc3N1ZXMgd2l0aCB0aGVzZSB0 d28gcGFnZXM6DQo+ID4NCj4gPiAgICAgMy4yLjEuIERpcmVjdC1tYXBwaW5nOg0KPiA+ICAgICBG b3IgYHNoYXJlZF9pbmZvYCwgaW4gY3VycmVudCBpbXBsZW1lbnRhdGlvbiwgWGVuIHdpbGwgYWxs b2NhdGUgYQ0KPiBwYWdlDQo+ID4gICAgIGZyb20gaGVhcCBmb3IgYHNoYXJlZF9pbmZvYCB0byBz dG9yZSBpbml0aWFsIG1ldGEgZGF0YS4gV2hlbiBndWVzdA0KPiBpcw0KPiA+ICAgICB0cnlpbmcg dG8gc2V0dXAgYHNoYXJlZF9pbmZvYCwgaXQgd2lsbCBhbGxvY2F0ZSBhIGZyZWUgZ2ZuIGFuZCB1 c2UgYQ0KPiA+ICAgICBoeXBlcmNhbGwgdG8gc2V0dXAgUDJNIG1hcHBpbmcgYmV0d2VlbiBnZm4g YW5kIGBzaGFyZWRfaW5mb2AuDQo+ID4NCj4gPiAgICAgRm9yIGRpcmVjdC1tYXBwaW5nIFZNLCB0 aGlzIHdpbGwgYnJlYWsgdGhlIGRpcmVjdC1tYXBwaW5nIGNvbmNlcHQuDQo+ID4gICAgIEFuZCBv biBhbiBNUFUgYmFzZWQgc3lzdGVtLCBsaWtlIEFybXY4LVIgc3lzdGVtLCB0aGlzIG9wZXJhdGlv biB3aWxsDQo+ID4gICAgIGJlIHZlcnkgdW5mcmllbmRseS4gWGVuIG5lZWQgdG8gcG9wIGBzaGFy ZWRfaW5mb2AgcGFnZSBmcm9tIFhlbiBoZWFwDQo+ID4gICAgIGFuZCBpbnNlcnQgaXQgdG8gVk0g UDJNIHBhZ2VzLiBJZiB0aGlzIHBhZ2UgaXMgaW4gdGhlIG1pZGRsZSBvZg0KPiA+ICAgICBYZW4g aGVhcCwgdGhpcyBtZWFucyBYZW4gbmVlZCB0byBzcGxpdCBjdXJyZW50IGhlYXAgYW5kIHVzZSBl eHRyYQ0KPiA+ICAgICBNUFUgcmVnaW9ucy4gQWxzbyBmb3IgdGhlIFAyTSBwYXJ0LCB0aGlzIHBh Z2UgaXMgdW5saWtlbHkgdG8gZm9ybQ0KPiA+ICAgICBhIG5ldyBjb250aW51b3VzIG1lbW9yeSBy ZWdpb24gd2l0aCB0aGUgZXhpc3RpbmcgcDJtIHBhZ2VzLCBhbmQgWGVuDQo+ID4gICAgIGlzIGxp a2VseSB0byBuZWVkIGFub3RoZXIgYWRkaXRpb25hbCBNUFUgcmVnaW9uIHRvIHNldCBpdCB1cCwg d2hpY2gNCj4gPiAgICAgaXMgb2J2aW91c2x5IGEgd2FzdGUgZm9yIGxpbWl0ZWQgTVBVIHJlZ2lv bnMuIEFuZCBUaGlzIGtpbmQgb2YNCj4gZHluYW1pYw0KPiA+ICAgICBpcyBxdWl0ZSBoYXJkIHRv IGltYWdpbmUgb24gYW4gTVBVIHN5c3RlbS4NCj4gPg0KPiA+ICAgICBGb3IgYHZjcHVfaW5mb2As IGluIGN1cnJlbnQgaW1wbGVtZW50YXRpb24sIFhlbiB3aWxsIHN0b3JlDQo+IGB2Y3B1X2luZm9g DQo+ID4gICAgIG1ldGEgZGF0YSBmb3IgYWxsIHZDUFVzIGluIGBzaGFyZWRfaW5mb2AuIFdoZW4g Z3Vlc3QgaXMgdHJ5aW5nIHRvDQo+IHNldHVwDQo+ID4gICAgIGB2Y3B1X2luZm9gLCBpdCB3aWxs IGFsbG9jYXRlIG1lbW9yeSBmb3IgYHZjcHVfaW5mb2AgZnJvbSBndWVzdCBzaWRlLg0KPiA+ICAg ICBBbmQgdGhlbiBndWVzdCB3aWxsIHVzZSBoeXBlcmNhbGwgdG8gY29weSBtZXRhIGRhdGEgZnJv bQ0KPiBgc2hhcmVkX2luZm9gDQo+ID4gICAgIHRvIGd1ZXN0IHBhZ2UuIEFmdGVyIHRoYXQgYm90 aCBYZW4gYHZjcHVfaW5mb2AgYW5kIGd1ZXN0IGB2Y3B1X2luZm9gDQo+ID4gICAgIGFyZSBwb2lu dGVkIHRvIHRoZSBzYW1lIHBhZ2UgdGhhdCBhbGxvY2F0ZWQgYnkgZ3Vlc3QuDQo+ID4NCj4gPiAg ICAgVGhpcyBpbXBsZW1lbnRhdGlvbiBoYXMgc2VydmFsIGJlbmVmaXRzOg0KPiA+ICAgICAxLiBU aGVyZSBpcyBubyB3YXN0ZSBtZW1vcnkuIE5vIGV4dHJhIG1lbW9yeSB3aWxsIGJlIGFsbG9jYXRl ZCBmcm9tDQo+IFhlbiBoZWFwLg0KPiA+ICAgICAyLiBUaGVyZSBpcyBubyBQMk0gcmVtYXAuIFRo aXMgd2lsbCBub3QgYnJlYWsgdGhlIGRpcmVjdC1tYXBwaW5nLA0KPiBhbmQNCj4gPiAgICAgICAg aXMgTVBVIHN5c3RlbSBmcmllbmRseS4NCj4gPiAgICAgU28sIG9uIEFybXY4LVIgc3lzdGVtLCB3 ZSBjYW4gc3RpbGwga2VlcCBjdXJyZW50IGltcGxlbWVudGF0aW9uIGZvcg0KPiA+ICAgICBwZXIt Y3B1IGB2Y3B1X2luZm9gLg0KPiA+DQo+ID4gICAgIFNvLCBvdXIgcHJvcG9zYWwgaXMgdGhhdCwg Y2FuIHdlIHJldXNlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gaWRlYQ0KPiBvZg0KPiA+ICAgICBg dmNwdV9pbmZvYCBmb3IgYHNoYXJlZF9pbmZvYD8gV2Ugc3RpbGwgYWxsb2NhdGUgb25lIHBhZ2Ug Zm9yDQo+ID4gICAgIGBkLT5zaGFyZWRfaW5mb2AgYXQgZG9tYWluIGNvbnN0cnVjdGlvbiBmb3Ig aG9sZGluZyBzb21lIGluaXRpYWwNCj4gbWV0YS1kYXRhLA0KPiA+ICAgICB1c2luZyBhbGxvY19k b21oZWFwX3BhZ2VzIGluc3RlYWQgb2YgYWxsb2NfeGVuaGVhcF9wYWdlcyBhbmQNCj4gPiAgICAg c2hhcmVfeGVuX3BhZ2Vfd2l0aF9ndWVzdC4gQW5kIHdoZW4gZ3Vlc3QgYWxsb2NhdGVzIGEgcGFn ZSBmb3INCj4gPiAgICAgYHNoYXJlZF9pbmZvYCBhbmQgdXNlIGh5cGVyY2FsbCB0byBzZXR1cCBp dCwgIFdlIGNvcHkgdGhlIGluaXRpYWwNCj4gZGF0YSBmcm9tDQo+ID4gICAgIGBkLT5zaGFyZWRf aW5mb2AgdG8gaXQuIEFuZCBhZnRlciBjb3B5IHdlIGNhbiB1cGRhdGUgYGQtDQo+ID5zaGFyZWRf aW5mb2AgdG8gcG9pbnQNCj4gPiAgICAgdG8gZ3Vlc3QgYWxsb2NhdGVkICdzaGFyZWRfaW5mbycg cGFnZS4gSW4gdGhpcyBjYXNlLCB3ZSBkb24ndCBoYXZlDQo+IHRvIHRoaW5rDQo+ID4gICAgIGFi b3V0IHRoZSBmcmFnbWVudGF0aW9uIG9mIFhlbiBoZWFwIGFuZCBwMm0gYW5kIHRoZSBleHRyYSBN UFUNCj4gcmVnaW9ucy4NCj4gPg0KPiA+ICAgICBBcyBndWVzdCBjYW5ub3QgYWNjZXNzICdzaGFy ZWRfaW5mbycgdW50aWwgaXQgbWFrZXMgdGhlDQo+ID4gICAgIFhFTk1BUFNQQUNFX3NoYXJlZF9p bmZvIGh5cGVyY2FsbC4gU28gaXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGdldA0KPiByaWQNCj4g PiAgICAgb2YgdGhlIGluaXRpYWwgJ3NoYXJlZF9pbmZvJyBhbGxvY2F0aW9uIGluIFhlbi4NCj4g Pg0KPiA+ICAgICAzLjIuMi4gSG93IHRvIGFjY2VzcyB0aGVzZSBwYWdlcyBvZiByZW1vdGUgZG9t YWluIGluIGh5cGVyY2FsbA0KPiA+ICAgICBBcyAnc2hhcmVkX2luZm8nIGFuZCAndmNwdV9pbmZv JyBhcmUgYWxsb2NhdGVkIGJ5IEd1ZXN0LiBBbmQgdGhlc2UNCj4gcGFnZXMNCj4gPiAgICAgYXJl IG5vdCBtYXBwZWQgaW4gWGVuJ3MgTVBVIHJlZ2lvbnMsIGluc3RlYWQgdGhleSBzaG91bGQgYmUg bWFwcGVkDQo+IGluDQo+ID4gICAgIGd1ZXN0J3MgUDJNIE1QVSByZWdpb25zLiBXaGVuIGd1ZXN0 IGlzc3VlcyBhIGh5cGVyY2FsbCB0byBub3RpZnkgYQ0KPiBwZWVyDQo+ID4gICAgIGRvbWFpbiB0 aHJvdWdoIGV2ZW50IGNoYW5uZWwuIFhlbiBuZWVkcyB0byB1cGRhdGUgdGhlIHBlbmRpbmcgYml0 bWFwDQo+ID4gICAgIGluIHBlZXIgZG9tYWluJ3MgcGFnZS4NCj4gPg0KPiA+ICAgICBGb3IgTU1V IHN5c3RlbSwgWGVuIGhhcyBhIGZ1bGwgdmlldyBvZiBzeXN0ZW0gbWVtb3J5IGluIHJ1bnRpbWUu DQo+IEJlY2F1c2UNCj4gPiAgICAgaXQgaGFzIGRlZGljYXRlZCBFTDIgTU1VIHRvIG1hcCB3aG9s ZSBzeXN0ZW0gbWVtb3J5LiBTbyBpdCBoYXMgdGhlDQo+IGFiaWxpdHkNCj4gPiAgICAgdG8gdXBk YXRlIHBlZXIgZG9tYWluJ3MgcGVuZGluZyBiaXRtYXAuIEJ1dCBpbiBNUFUgc3lzdGVtLCB0aGUg RUwyDQo+IE1QVSBpcw0KPiA+ICAgICBzaGFyZWQgYnkgWGVuIGFuZCBndWVzdCBQMk0gbWFwcGlu Zy4gSW4gaHlwZXJjYWxsIGNvbnRleHQsIHRoZSBFTDINCj4gTVBVDQo+ID4gICAgIG9ubHkgY29u dGFpbnMgWGVuIG1lbW9yeSAoY29kZSwgZGF0YSBhbmQgaGVhcCkgYW5kIGN1cnJlbnQgcnVubmlu Zw0KPiBndWVzdCdzDQo+ID4gICAgIFAyTSBtYXBwaW5nLiBXaGVuIFhlbiBhY2Nlc3NlcyBwZWVy IGRvbWFpbidzIHBlbmRpbmcgYml0bWFwLCBpdCB3aWxsDQo+IGNhdXNlDQo+ID4gICAgIEVMMiBk YXRhIGFib3J0Lg0KPiA+DQo+ID4gICAgIFNvLCBmb3IgTVBVIHN5c3RlbSwgd2UgbmVlZCB0byBy ZXNlcnZlIG9uZSBFTDIgTVBVIHJlZ2lvbiB0byBtYXANCj4gcGVlcg0KPiA+ICAgICBkb21haW4n cyBwYWdlIHRvIGhhbmRsZSBoeXBlcmNhbGxzIHdoaWNoIG5lZWQgdG8gYWNjZXNzIHRoaXMgcGVl cg0KPiBkb21haW4ncw0KPiA+ICAgICBwYWdlLiBNb3JlIGRldGFpbGVkIGRpc2N1c3Npb25zIGhh dmUgYmVlbiBsaXN0ZWQgaW4gW0RyYWZ0LQ0KPiBCXShodHRwczovL2xpc3RzLnhlbnByb2plY3Qu b3JnL2FyY2hpdmVzL2h0bWwveGVuLWRldmVsLzIwMjItDQo+IDA0L21zZzAxNzE5Lmh0bWwpLg0K PiA+DQo+ID4NCj4gPiAgICAgQnV0IGhlcmUgc3RpbGwgaGFzIHNvbWUgY29uY2VybnM6DQo+ID4g ICAgIGBkLT5zaGFyZWRfaW5mb2AgaW4gWGVuIGlzIGFjY2Vzc2VkIHdpdGhvdXQgYW55IGxvY2su IFNvIGl0IHdpbGwgbm90DQo+IGJlDQo+ID4gICAgIHRoYXQgc2ltcGxlIHRvIHVwZGF0ZSBgZC0+ c2hhcmVkX2luZm9gLiBJdCBtaWdodCBiZSBwb3NzaWJsZSB0bw0KPiBwcm90ZWN0DQo+ID4gICAg IGQtPnNoYXJlZF9pbmZvIChvciBvdGhlciBzdHJ1Y3R1cmUpIHdpdGggYSByZWFkLXdyaXRlIGxv Y2suDQo+ID4NCj4gPiAgICAgRG8gd2UgbmVlZCB0byBhZGQgUEdUX3h4eCBmbGFncyB0byBtYWtl IGl0IGdsb2JhbCBhbmQgc3RheSBhcyBtdWNoDQo+IHRoZQ0KPiA+ICAgICBzYW1lIHdpdGggdGhl IG9yaWdpbmFsIG9wLCBhIHNpbXBsZSBpbnZlc3RpZ2F0aW9uIHRlbGxzIHVzIHRoYXQgaXQNCj4g b25seQ0KPiA+ICAgICBiZSByZWZlcnJlZCBpbiBgZ2V0X3BhZ2VfdHlwZWAuIFNpbmNlIEFSTSBk b2Vzbid0IGNhcmUgYWJvdXQgdHlwZQ0KPiBjb3VudHMNCj4gPiAgICAgYW5kIGFsd2F5cyByZXR1 cm4gMSwgaXQgZG9lc24ndCBoYXZlIHRvbyBtdWNoIGltcGFjdC4NCj4gPg0KPiA+ICMjIyAzLjMu IFhlbiBQYXJ0aWFsIFBJQy9QSUUNCj4gPiAgICAgV2UgaGF2ZSBtZW50aW9uZWQgYWJvdXQgUElD L1BJRSBpbiBzZWN0aW9uIDEuMi4gV2l0aCBQSUMvUElFIHN1cHBvcnQsDQo+ID4gICAgIFhlbiBj YW4gYmUgbG9hZGVkIGF0IGFueSBhZGRyZXNzIGFuZCBydW4gcHJvcGVybHkuIEJ1dCBpdCdzIHJh cmUgdG8NCj4gdXNlDQo+ID4gICAgIFBJQy9QSUUgb24gYSByZWFsLXRpbWUgc3lzdGVtIChjb2Rl IHNpemUsIG1vcmUgbWVtb3J5IGFjY2VzcykuIFNvIGENCj4gPiAgICAgcGFydGlhbCBQSUMvUElF IGltYWdlIG1heWJlIGJldHRlci4gQnV0IHBhcnRpYWwgUElDL1BJRSBpbWFnZSBtYXkNCj4gbm90 DQo+ID4gICAgIHNvbHZlIHRoZSBYZW4gc3RhcnQgYWRkcmVzcyBpc3N1ZS4NCj4gPg0KPiA+ICAg ICBCdXQgYSBwYXJ0aWFsIFBJQy9QSUUgc3VwcG9ydCBtYXkgYmUgbmVlZGVkIGZvciBBcm12OC1S LiBCZWNhdXNlIEFybQ0KPiA+ICAgICBbRUJCUl0oaHR0cHM6Ly9hcm0tc29mdHdhcmUuZ2l0aHVi LmlvL2ViYnIvaW5kZXguaHRtbCkgcmVxdWlyZSBYZW4NCj4gPiAgICAgb24gQXJtdjgtUiB0byBz dXBwb3J0IEVGSSBib290IHNlcnZpY2UuIER1ZSB0byBsYWNrIG9mIHJlbG9jYXRpb24NCj4gPiAg ICAgY2FwYWJpbGl0eSwgRUZJIGxvYWRlciBjb3VsZCBub3QgbGF1bmNoIHhlbi5lZmkgb24gQXJt djgtUi4gU28gbWF5YmUNCj4gPiAgICAgd2Ugc3RpbGwgbmVlZCBhIHBhcnRpYWxseSBzdXBwb3J0 ZWQgUElDL1BJRS4gT25seSBzb21lIGJvb3QgY29kZQ0KPiA+ICAgICBzdXBwb3J0IFBJQy9QSUUg dG8gbWFrZSBFRkkgcmVsb2NhdGlvbiBoYXBweS4gVGhpcyBib290IGNvZGUgd2lsbA0KPiA+ICAg ICBoZWxwIFhlbiB0byBjaGVjayBpdHMgbG9hZGVkIGFkZHJlc3MgYW5kIHJlbG9jYXRlIFhlbiBp bWFnZSB0byBYZW4ncw0KPiA+ICAgICBydW4tdGltZSBhZGRyZXNzIGlmIG5lZWQuDQo+ID4NCj4g PiAjIyMgMy40LiBBIHRvb2wgdG8gZ2VuZXJhdGUgQXJtdjgtUiBYZW4gZGV2aWNlIHRyZWUNCj4g PiAxLiBVc2UgYSB0b29sIHRvIGdlbmVyYXRlIGFib3ZlIGRldmljZSB0cmVlIHByb3BlcnR5Lg0K PiA+ICAgIFRoaXMgdG9vbCB3aWxsIGhhdmUgc29tZSBzaW1pbGFyIGlucHV0cyBhcyBiZWxvdzoN Cj4gPiAgICAtLS0NCj4gPiAgICBERVZJQ0VfVFJFRT0iZnZwX2JhcmVtZXRhbC5kdGIiDQo+ID4g ICAgWEVOPSI0LjE2LTIwMjIuMS94ZW4iDQo+ID4NCj4gPiAgICBOVU1fRE9NVVM9MQ0KPiA+ICAg IERPTVVfS0VSTkVMWzBdPSI0LjE2LTIwMjIuMS9JbWFnZS1kb21VIg0KPiA+ICAgIERPTVVfUkFN RElTS1swXT0iNC4xNi0yMDIyLjEvaW5pdHJkLmNwaW8iDQo+ID4gICAgRE9NVV9QQVNTVEhST1VH SF9EVEJbMF09IjQuMTYtMjAyMi4xL3Bhc3N0aHJvdWdoLWV4YW1wbGUtZGV2LmR0YiINCj4gPiAg ICBET01VX1JBTV9CQVNFWzBdPTB4MzAwMDAwMDANCj4gPiAgICBET01VX1JBTV9TSVpFWzBdPTB4 MWYwMDAwMDANCj4gPiAgICAtLS0NCj4gPiAgICBVc2luZyBhYm92ZSBpbnB1dHMsIHRoZSB0b29s IGNhbiBnZW5lcmF0ZSBhIGRldmljZSB0cmVlIHNpbWlsYXIgYXMNCj4gPiAgICB3ZSBoYXZlIGRl c2NyaWJlZCBpbiBzYW1wbGUuDQo+ID4NCj4gPiAgICAtIGBtcHUsZ3Vlc3QtbWVtb3J5LXNlY3Rp b25gOg0KPiA+ICAgIFRoaXMgc2VjdGlvbiB3aWxsIGNvdmVyIGFsbCBndWVzdHMnIFJBTSAoYHhl bixzdGF0aWMtbWVtYCBkZWZpbmVkDQo+IHJlZ2lvbnMNCj4gPiAgICBpbiBhbGwgRG9tVSBub2Rl cykuIEFsbCBndWVzdCBSQU0gbXVzdCBiZSBsb2NhdGVkIHdpdGhpbiB0aGlzIHNlY3Rpb24uDQo+ ID4gICAgSW4gdGhlIGJlc3QgY2FzZSwgd2UgY2FuIG9ubHkgaGF2ZSBvbmUgTVBVIHByb3RlY3Rp b24gcmVnaW9uIHRvIG1hcA0KPiBhbGwNCj4gPiAgICBndWVzdHMnIFJBTSBmb3IgWGVuLg0KPiA+ DQo+ID4gICAgSWYgdXNlcnMgc2V0IGBET01VX1JBTV9CQVNFYCwgYERPTVVfUkFNX1NJWkVgIG9y DQo+IGBET01VX1NUQVRJQ19NRU1fUkFOR0VTYCwNCj4gPiAgICB0aGVzZSB3aWxsIGJlIGNvbnZl cnRlZCB0byB0aGUgYmFzZSBhbmQgc2l6ZSBvZiBgeGVuLHN0YXRpYy1tZW1gLg0KPiBUaGlzIHRv b2wNCj4gPiAgICB3aWxsIHNjYW4gYWxsIGB4ZW4sIHN0YXRpYy1tZW1gIGluIERvbVUgbm9kZXMg dG8gZGV0ZXJtaW5lIHRoZSBiYXNlDQo+IGFuZA0KPiA+ICAgIHNpemUgb2YgYG1wdSxndWVzdC1t ZW1vcnktc2VjdGlvbmAuIElmIGFueSBvdGhlciBraW5kIG9mIG1lbW9yeSBoYXMNCj4gYmVlbg0K PiA+ICAgIGRldGVjdGVkIGluIHRoaXMgc2VjdGlvbiwgdGhpcyB0b29sIGNhbiByZXBvcnQgYW4g ZXJyb3IuDQo+ID4gICAgRXhjZXB0IGJ1aWxkIHRpbWUgY2hlY2ssIFhlbiBhbHNvIG5lZWQgdG8g ZG8gcnVudGltZSBjaGVjayB0byBwcmV2ZW50DQo+IGENCj4gPiAgICBiYWQgZGV2aWNlIHRyZWUg dGhhdCBnZW5lcmF0ZWQgYnkgbWFsaWNpb3VzIHRvb2xzLg0KPiA+DQo+ID4gICAgSWYgdXNlcnMg c2V0IGBET01VX1JBTV9TSVpFYCBvbmx5LCB0aGlzIHdpbGwgYmUgY29udmVydGVkIHRvIHRoZSBz aXplDQo+IG9mDQo+ID4gICAgYHhlbixzdGF0aWMtbWVtYCBvbmx5LiBYZW4gd2lsbCBhbGxvY2F0 ZSB0aGUgZ3Vlc3QgbWVtb3J5IGluIHJ1bnRpbWUsDQo+IGJ1dA0KPiA+ICAgIG5vdCBmcm9tIFhl biBoZWFwLiBgbXB1LGd1ZXN0LW1lbW9yeS1zZWN0aW9uYCB3aWxsIGJlIGNhbGN1bGF0ZWQgaW4N Cj4gcnVudGltZQ0KPiA+ICAgIHRvby4gVGhlIHByb3BlcnR5IGluIGRldmljZSB0cmVlIGRvZXNu J3QgbmVlZCBvciB3aWxsIGJlIGlnbm9yZWQgYnkNCj4gWGVuLg0KPiA+DQo+ID4gICAgLSBgbXB1 LGJvb3QtbW9kdWxlLXNlY3Rpb25gOg0KPiA+ICAgIFRoaXMgc2VjdGlvbiB3aWxsIGJlIHVzZWQg dG8gc3RvcmUgdGhlIGJvb3QgbW9kdWxlcyBsaWtlIERPTVVfS0VSTkVMLA0KPiA+ICAgIERPTVVf UkFNRElTSywgYW5kIERPTVVfUEFTU1RIUk9VR0hfRFRCLiBYZW4ga2VlcHMgYWxsIGJvb3QgbW9k dWxlcyBpbg0KPiA+ICAgIHRoaXMgc2VjdGlvbiB0byBtZWV0IHRoZSByZXF1aXJlbWVudCBvZiBE b21VIHJlc3RhcnQgb24gQXJtdjgtUi4gSW4NCj4gPiAgICBjdXJyZW50IHN0YWdlLCB3ZSBkb24n dCBoYXZlIGEgcHJpdmlsZWdlIGRvbWFpbiBsaWtlIERvbTAgdGhhdCBjYW4NCj4gPiAgICBhY2Nl c3MgZmlsZXN5c3RlbSB0byByZWxvYWQgRG9tVSBpbWFnZXMuDQo+ID4NCj4gPiAgICBBbmQgaW4g Y3VycmVudCBYZW4gY29kZSwgdGhlIGJhc2UgYW5kIHNpemUgYXJlIG1hbmRhdG9yeSBmb3IgYm9v dA0KPiBtb2R1bGVzDQo+ID4gICAgSWYgdXNlcnMgZG9uJ3Qgc3BlY2lmeSB0aGUgYmFzZSBvZiBl YWNoIGJvb3QgbW9kdWxlLCB0aGUgdG9vbCB3aWxsDQo+ID4gICAgYWxsb2NhdGUgYSBiYXNlIGZv ciBlYWNoIG1vZHVsZS4gQW5kIHRoZSB0b29sIHdpbGwgZ2VuZXJhdGUgdGhlDQo+ID4gICAgYG1w dSxib290LW1vZHVsZS1zZWN0aW9uYCByZWdpb24sIHdoZW4gaXQgZmluaXNoZXMgYm9vdCBtb2R1 bGUgbWVtb3J5DQo+ID4gICAgYWxsb2NhdGlvbi4NCj4gPg0KPiA+ICAgIFVzZXJzIGFsc28gY2Fu IHNwZWNpZnkgdGhlIGJhc2UgYW5kIHNpemUgb2YgZWFjaCBib290IG1vZHVsZSwgdGhlc2UNCj4g d2lsbA0KPiA+ICAgIGJlIGNvbnZlcnRlZCB0byB0aGUgYmFzZSBhbmQgc2l6ZSBvZiBtb2R1bGUn cyBgcmVnYCBkaXJlY3RseS4gVGhlDQo+IHRvb2wNCj4gPiAgICB3aWxsIHNjYW4gYWxsIG1vZHVs ZXMgYHJlZ2AgaW4gRG9tVSBub2RlcyB0byBnZW5lcmF0ZSB0aGUgYmFzZSBhbmQNCj4gc2l6ZSBv Zg0KPiA+ICAgIGBtcHUsYm9vdC1tb2R1bGUtc2VjdGlvbmAuIElmIHRoZXJlIGlzIGFueSBraW5k IG9mIG90aGVyIG1lbW9yeSB1c2FnZQ0KPiA+ICAgIGhhcyBiZWVuIGRldGVjdGVkIGluIHRoaXMg c2VjdGlvbiwgdGhpcyB0b29sIGNhbiByZXBvcnQgYW4gZXJyb3IuDQo+ID4gICAgRXhjZXB0IGJ1 aWxkIHRpbWUgY2hlY2ssIFhlbiBhbHNvIG5lZWQgdG8gZG8gcnVudGltZSBjaGVjayB0byBwcmV2 ZW50DQo+IGENCj4gPiAgICBiYWQgZGV2aWNlIHRyZWUuDQo+ID4NCj4gPiAgICAtIGBtcHUsZGV2 aWNlLW1lbW9yeS1zZWN0aW9uYDoNCj4gPiAgICBUaGlzIHNlY3Rpb24gd2lsbCBjb3ZlciBhbGwg ZGV2aWNlIG1lbW9yeSB0aGF0IHdpbGwgYmUgdXNlZCBpbiBYZW4uDQo+IExpa2UNCj4gPiAgICBg VUFSVGAsIGBHSUNgLCBgU01NVWAgYW5kIG90aGVyIGRldmljZXMuIFdlIGhhdmVuJ3QgY29uc2lk ZXJlZA0KPiBtdWx0aXBsZQ0KPiA+ICAgIGBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uYCBzY2Vu YXJpb3MuIFRoZSBkZXZpY2VzJyBtZW1vcnkgYW5kIFJBTQ0KPiBhcmUNCj4gPiAgICBpbnRlcmxl YXZpbmcgaW4gcGh5c2ljYWwgYWRkcmVzcyBzcGFjZSwgaXQgd291bGQgYmUgcmVxdWlyZWQgdG8g dXNlDQo+ID4gICAgbXVsdGlwbGUgYG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb25gIHRvIGNvdmVy IGFsbCBkZXZpY2VzLiBUaGlzDQo+IGxheW91dA0KPiA+ICAgIGlzIGNvbW1vbiBvbiBBcm12OC1B IHN5c3RlbSwgZXNwZWNpYWxseSBpbiBzZXJ2ZXIuIEJ1dCBpdCdzIHJhcmUgaW4NCj4gPiAgICBB cm12OC1SLiBTbyBpbiBjdXJyZW50IHN0YWdlLCB3ZSBkb24ndCB3YW50IHRvIGFsbG93IG11bHRp cGxlDQo+ID4gICAgYG1wdSxkZXZpY2UtbWVtb3J5LXNlY3Rpb25gLiBUaGUgdG9vbCBjYW4gc2Nh biBiYXJlbWV0YWwgZGV2aWNlIHRyZWUNCj4gPiAgICB0byBzb3J0IGFsbCBkZXZpY2VzJyBtZW1v cnkgcmFuZ2VzLiBBbmQgY2FsY3VsYXRlIGEgcHJvcGVyIHJlZ2lvbiBmb3INCj4gPiAgICBgbXB1 LGRldmljZS1tZW1vcnktc2VjdGlvbmAuIElmIGl0IGZpbmQgWGVuIG5lZWQgbXVsdGlwbGUNCj4g PiAgICBgbXB1LGRldmljZS1tZW1vcnktc2VjdGlvbmAsIGl0IGNhbiByZXBvcnQgYW4gdW5zdXBw b3J0ZWQgZXJyb3IuDQo+ID4NCj4gPiAyLiBVc2UgYSB0b29sIHRvIGdlbmVyYXRlIGRldmljZSB0 cmVlIHByb3BlcnR5IGFuZCBwbGF0Zm9ybSBmaWxlcw0KPiA+ICAgIFRoaXMgb3BpbmlvbiBzdGls bCB1c2VzIHRoZSBzYW1lIGlucHV0cyBhcyBvcGluaW9uIzEuIEJ1dCB0aGlzIHRvb2wNCj4gb25s eQ0KPiA+ICAgIGdlbmVyYXRlcyBgeGVuLHN0YXRpYy1tZW1gIGFuZCBgbW9kdWxlYCBub2RlcyBp biBEb21VIG5vZGVzLCBpdCB3aWxsDQo+IG5vdA0KPiA+ICAgIGdlbmVyYXRlIGBtcHUsZ3Vlc3Qt bWVtb3J5LXNlY3Rpb25gLCBgbXB1LGJvb3QtbW9kdWxlLXNlY3Rpb25gIGFuZA0KPiA+ICAgIGBt cHUsZGV2aWNlLW1lbW9yeS1zZWN0aW9uYCBwcm9wZXJ0aWVzIGluIGRldmljZSB0cmVlLiBUaGlz IHdpbGwNCj4gPiAgICBnZW5lcmF0ZSBmb2xsb3dpbmcgbWFjcm9zOg0KPiA+ICAgIGBNUFVfR1VF U1RfTUVNT1JZX1NFQ1RJT05fQkFTRWAsIGBNUFVfR1VFU1RfTUVNT1JZX1NFQ1RJT05fU0laRWAN Cj4gPiAgICBgTVBVX0JPT1RfTU9EVUxFX1NFQ1RJT05fQkFTRWAsIGBNUFVfQk9PVF9NT0RVTEVf U0VDVElPTl9TSVpFYA0KPiA+ICAgIGBNUFVfREVWSUNFX01FTU9SWV9TRUNUSU9OX0JBU0VgLCBg TVBVX0RFVklDRV9NRU1PUllfU0VDVElPTl9TSVpFYA0KPiA+ICAgIGluIHBsYXRmb3JtIGZpbGVz IGluIGJ1aWxkIHRpbWUuIEluIHJ1bnRpbWUsIFhlbiB3aWxsIHNraXAgdGhlIGRldmljZQ0KPiA+ ICAgIHRyZWUgcGFyc2luZyBmb3IgYG1wdSxndWVzdC1tZW1vcnktc2VjdGlvbmAsIGBtcHUsYm9v dC1tb2R1bGUtDQo+IHNlY3Rpb25gDQo+ID4gICAgYW5kIGBtcHUsZGV2aWNlLW1lbW9yeS1zZWN0 aW9uYC4gQW5kIGluc3RlYWQgWGVuIHdpbGwgdXNlIHRoZXNlDQo+IG1hY3Jvcw0KPiA+ICAgIHRv IGRvIHJ1bnRpbWUgY2hlY2suDQo+ID4gICAgQnV0LCB0aGlzIGFsc28gbWVhbnMgdGhlc2UgbWFj cm9zIG9ubHkgZXhpc3QgaW4gbG9jYWwgYnVpbGQgc3lzdGVtLA0KPiA+ICAgIHRoZXNlIG1hY3Jv cyB3aWxsIG5vdCBiZSBtYWludGFpbmVkIGluIFhlbiByZXBvLg0KPiA+DQo+ID4gQm90aCBvcHRp b25zIGFyZSBhY2NlcHRhYmxlIGFuZCB3ZSBjb3VsZCBzdXBwb3J0IGJvdGguIFRoZSBtYWluDQo+ IGRpZmZlcmVuY2UgZm9yDQo+ID4gdGhlIHVzZXIgaXMgdGhhdCBvcHRpb24gIzIgcmVxdWlyZXMg YSBYZW4gYnVpbGQgYWZ0ZXIgcnVubmluZw0KPiBJbWFnZUJ1aWxkZXIsDQo+ID4gd2hpbGUgb3B0 aW9uICMxIG1pZ2h0IG5vdC4NCj4gPg0KPiA+IEJ1dCB3ZSBkb24ndCBoYXZlIHRvIGltcGxlbWVu dCBib3RoIG9wdGlvbnMgcmlnaHQgYXdheS4gV2UgY2FuIHN0YXJ0DQo+IGZyb20NCj4gPiBvcHRp b24jMSwgaXQgd2lsbCBiZSBlYXNpZXIgZm9yIGluaXRpYWwgaW1wbGVtZW50YXRpb24sIGFuZCB0 aGUgY3VycmVudA0KPiBQb0MNCj4gPiBpbXBsZW1lbnRhdGlvbiB3aWxsIHN0aWxsIGJlIHBvc3Np YmxlIHRvIHVzZS4NCj4gPg0KPiA+IC0tDQo+ID4gQ2hlZXJzLA0KPiA+IFdlaSBDaGVuDQo+ID4N Cg== From xen-devel-bounces@lists.xenproject.org Fri Jul 29 01:45:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 01:45:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377269.610401 (Exim 4.92) (envelope-from ) id 1oHF3x-0002KK-AH; Fri, 29 Jul 2022 01:45:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377269.610401; Fri, 29 Jul 2022 01:45:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHF3x-0002KD-5L; Fri, 29 Jul 2022 01:45:13 +0000 Received: by outflank-mailman (input) for mailman id 377269; Fri, 29 Jul 2022 01:45:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHF3v-0002K3-Mv; Fri, 29 Jul 2022 01:45:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHF3v-0005oX-KK; Fri, 29 Jul 2022 01:45:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHF3v-0005kL-8I; Fri, 29 Jul 2022 01:45:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHF3v-0003pU-7v; Fri, 29 Jul 2022 01:45:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vMbUIXh68L/aFD4a60CqhrzUAJmu4mHnXZQ8tFkspHo=; b=fSUh9FVW4XyWSAUfJcqABL+UEj eRVU8eiKoHPerBBFKH6A5eGpkIfNe79lDXXKf1zxpdz41ABon+XHn9HxlmuJ2RBIWfu8YNrONJIRs HWNCs9+YGR9D4iadhSkZuj49tSur1jf2dpGva0tRpFw6tRiweGsLhbkyyWnXQxxm1/Zw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171903: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=ca45d3cb4586372909f350e54482246f994e1bc7 X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 01:45:11 +0000 flight 171903 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171903/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen ca45d3cb4586372909f350e54482246f994e1bc7 baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 1 days Testing same since 171899 2022-07-28 19:01:47 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jiamei Xie Julien Grall Oleksandr Tyshchenko jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 02:10:38 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 02:10:38 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377277.610412 (Exim 4.92) (envelope-from ) id 1oHFSJ-0006Wv-9l; Fri, 29 Jul 2022 02:10:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377277.610412; Fri, 29 Jul 2022 02:10:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHFSJ-0006Wo-6L; Fri, 29 Jul 2022 02:10:23 +0000 Received: by outflank-mailman (input) for mailman id 377277; Fri, 29 Jul 2022 02:10:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHFSH-0006We-KY; Fri, 29 Jul 2022 02:10:21 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHFSH-0006i7-CR; Fri, 29 Jul 2022 02:10:21 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHFSG-0006RG-T0; Fri, 29 Jul 2022 02:10:20 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHFSG-0001JP-Sd; Fri, 29 Jul 2022 02:10:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vWK5ZVA4AyQdGM5eKeABb7UdkDXkBClh+wZQB8C8pmU=; b=lMMcgK0kOtUHWp8beeR0LInMOU OUMRLXRWmUcnZsXsVjICk//I665Kdj04nYaqAVDkp/+4aUF6H4Lzu5hY5TUFMCJRpXFyUfd4H1Qj+ zlzc3pHbvGVboxXeLlxH9uIgkn9n/CZTmiNmOnuXhYjuBomktCPBgTb5KmitssEM8XMg=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171900: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=a17001c42329f809c7f1768925b8089324564312 X-Osstest-Versions-That: qemuu=3e4abe2c92964aadd35344a635b0f32cb487fd5c From: osstest service owner Date: Fri, 29 Jul 2022 02:10:20 +0000 flight 171900 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171900/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171897 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171897 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171897 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171897 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171897 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171897 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171897 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171897 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu a17001c42329f809c7f1768925b8089324564312 baseline version: qemuu 3e4abe2c92964aadd35344a635b0f32cb487fd5c Last test of basis 171897 2022-07-28 12:08:28 Z 0 days Testing same since 171900 2022-07-28 20:08:23 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alistair Francis Atish Patra Palmer Dabbelt Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 3e4abe2c92..a17001c423 a17001c42329f809c7f1768925b8089324564312 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jul 29 04:54:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 04:54:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377289.610423 (Exim 4.92) (envelope-from ) id 1oHI0T-00083u-NJ; Fri, 29 Jul 2022 04:53:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377289.610423; Fri, 29 Jul 2022 04:53:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHI0T-00083n-JD; Fri, 29 Jul 2022 04:53:49 +0000 Received: by outflank-mailman (input) for mailman id 377289; Fri, 29 Jul 2022 04:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHI0S-00083d-PA; Fri, 29 Jul 2022 04:53:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHI0S-0001Lp-Kt; Fri, 29 Jul 2022 04:53:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHI0S-00061x-8c; Fri, 29 Jul 2022 04:53:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHI0S-0003jg-7z; Fri, 29 Jul 2022 04:53:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NG7BA5q+Tal/PZ5FFl+UofEBz7Th1Bob3cR5JSAKWEk=; b=bz+g8bpa0ouaK6kzmM0Ao2YDI5 0gYY+u+USDORHXNcLQ/B0o7rSEyavl8cdq7reyWifVHeyHn+TGgZ1VZH5+YYstQZmUdFxhDvNE6r4 ozzLcWHWtkcclV3mTtBa1V8l/i9QVnLjeGEqAphjUBeIltILnwWZqaUn/ypfP8Ss6uPw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171911: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=108e6f282d2c2b8442ac9e1487e6fd7865cd6ede X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 04:53:48 +0000 flight 171911 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171911/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 1 days Failing since 171899 2022-07-28 19:01:47 Z 0 days 3 attempts Testing same since 171911 2022-07-29 02:00:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 05:23:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 05:23:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377300.610433 (Exim 4.92) (envelope-from ) id 1oHISu-0003s5-3W; Fri, 29 Jul 2022 05:23:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377300.610433; Fri, 29 Jul 2022 05:23:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHISu-0003ry-0w; Fri, 29 Jul 2022 05:23:12 +0000 Received: by outflank-mailman (input) for mailman id 377300; Fri, 29 Jul 2022 05:23:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHISs-0003rm-OQ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 05:23:10 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 87fd51aa-0efe-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 07:23:08 +0200 (CEST) Received: by mail-ej1-x62e.google.com with SMTP id sz17so6598982ejc.9 for ; Thu, 28 Jul 2022 22:23:08 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id 1-20020a170906200100b0072b40cb28a8sm1223307ejo.29.2022.07.28.22.23.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 22:23:07 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 87fd51aa-0efe-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bkArkBMFaSF/dRm7YFfpjL5+yokN4a60zgz8WQkGncw=; b=lokOm7O1NJ7QcFykkVVWXQrJhFAY4bhSBCvFogwdwJE4afF3kMUwuFRflUIrgig+YS urVPj5Ucq36deX3TLGbd5kJmJC44/xQIQjBhKS5MrxweQWO+1hgC3SRBe9ROjtmAkDrw hQX7P8XubA7ML0so9XrJVFn4ET3wUqldJ87VdkoVV0NQRl6Z0/SwU4/wHeRsODAICLuP XRUVWXIBDaruV+3Us5fXVTy4olyYPV2sQ5eVnkyQLyFIZIdYJyigg7DvAWyDYbFU5vRU h/JMrgUDUIFOoRJOFPvKPgZNZSsvxoCP7r5Y9jGG2xseFzKtO0kU/sNR7b61x1Xbj33O eFiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bkArkBMFaSF/dRm7YFfpjL5+yokN4a60zgz8WQkGncw=; b=Rj1dS5xni06woX0dWNcR/5MBhlwYpGfyClNTTz3EJuf0t0NunlTE4FTYlnB4DDcgyR Bu9misb13N79qGnLT+xBgQVxR36JjugBfJOSv2ZG1b01HKI25SQQm7boautXe+voQ8p4 NkYEEBn3FYUFiFBz5keCKsPrheUrmjRglV9e+uviPYR5hhUFsMVscEerkVjiXmbA5l9i NNWvTSFAZMbc10ckw2RU+NMAPifxx7Vg9+tv6JaiSGp2NKBfak1yuIsR9dwpOVJH0SS2 SAW8efx3UzhdMpFe216Jw4t8+5eZZ4t2dHtiE7ZK/fDvjVXEX5gMOZsvPIDhtTdswZ8j EjDA== X-Gm-Message-State: AJIora/ik3zPjIGF1f9HwCKWicdisI30QMbwFFA1HGDaiGRxU7F07dnZ tdnwx9scm82b2/3mi5WXC5M= X-Google-Smtp-Source: AGRyM1v1iRKtORqp1f6u5u+Wc7ZWi3i/iST1EUN7J7QcgkHAE5UtnvWNtXu+7Ysp3VZYfc/pO1hxSg== X-Received: by 2002:a17:906:ef90:b0:72b:9ce5:f016 with SMTP id ze16-20020a170906ef9000b0072b9ce5f016mr1525167ejb.697.1659072187878; Thu, 28 Jul 2022 22:23:07 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 08:23:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Stefano Stabellini , Julien Grall Cc: Jan Beulich , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Stefano, On 7/29/22 01:56, Stefano Stabellini wrote: > On Thu, 28 Jul 2022, Julien Grall wrote: >> On 28/07/2022 15:20, Jan Beulich wrote: >>> On 28.07.2022 15:56, Julien Grall wrote: >>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>> @@ -461,7 +461,7 @@ >>>>> /* Access to system registers */ >>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>> - uint64_t _r = v; \ >>>>> + uint64_t _r = (v); \ >>>> >>>> I am failing to see why the parentheses are necessary here. Could you >>>> give an example where the lack of them would end up to different code? >>> >>> I think it is merely good practice to parenthesize the right sides of =. >>> Indeed with assignment operators having second to lowest precedence, and >>> with comma (the lowest precedence one) requiring parenthesization at the >>> macro invocation site, there should be no real need for parentheses here. >> >> I am not really happy with adding those parentheses because they are >> pointless. But if there are a consensus to use it, then the commit message >> should be updated to clarify this is just here to please MISRA (to me "need" >> implies it would be bug). > > Let me premise that I don't know if this counts as a MISRA violation or > not. (Also I haven't checked if cppcheck/eclair report it as violation.) > > But I think the reason for making the change would be to follow our > coding style / coding practices. It makes the code simpler to figure out > that it is correct, to review and maintain if we always add the > parenthesis even in cases like this one where they are not strictly > necessary. We are going to save our future selves some mental cycles. > > So the explanation on the commit message could be along those lines. First, the rule 20.7 states "Expressions resulting from the expansion of macro parameters shall be enclosed in parentheses". So, here it is a clear violation of the rule because the right side of the assignment operator is an expression. Second, as I stated in a previous email, if v is not enclosed in parentheses, I could write the story of my life in there and compile it :) So, it would be a bug. So, I recommend the title and the explanation i.e "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation The macro parameter 'v' is used as an expression and needs to be enclosed in parentheses." to remain as is because they are accurate. Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:07:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:07:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377305.610445 (Exim 4.92) (envelope-from ) id 1oHJ9F-0000i4-CL; Fri, 29 Jul 2022 06:06:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377305.610445; Fri, 29 Jul 2022 06:06:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJ9F-0000hx-8U; Fri, 29 Jul 2022 06:06:57 +0000 Received: by outflank-mailman (input) for mailman id 377305; Fri, 29 Jul 2022 06:06:55 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJ9C-0000hr-Ne for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:06:55 +0000 Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10085.outbound.protection.outlook.com [40.107.1.85]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a39b0f15-0f04-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 08:06:53 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by AS8PR04MB8372.eurprd04.prod.outlook.com (2603:10a6:20b:3b3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Fri, 29 Jul 2022 06:06:49 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 06:06:49 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a39b0f15-0f04-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dzsUdF3VG1L8HjKvhR1hLljjbLeEYC150ofxDS35zyD5k1rYOUahtJK8O7DAFeCUV+C9mgJOO0i8Byjc7NOs68RZGGFWFa85HRkN0KpJcf1mdHF3BQXEKNiGLTtmJgls2oyy+RM9b8dbC1yqE0nbMKVVRVCkwEnOdwUdNS1VWzpaYVDLYeB5n/UXaeehapEmtMtx1Uxo1U9pEl0iy27EyNvxwHkNq2KB8BBHanXOJV57FSKjGinn9gbTWkP1/JYSAyr8sqTRLf5orsn6IZ2zYk2Bez6D5sXY2z612nMX+3e3iYVOCndgrIaas+LL4VPFxAcwIyPE+1GhHpA/D/QajQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=p0/77bOgMdn5xbfR/VFB2ZYeKWpba+foG2spqaIxxxU=; b=GMjL/z3NuvIL1xDUjlnvEsVA51WcQaPM/3Xv/TvUI8DGXg25BtDzBZlRQwq7nzK46g2pVTHe8NK0jE9/bC0GgxgVvTSxzVRAUeNDsgjXgUspszsAkeJILHVud4MGYrL3UVpJI/Pl7hOeAMUoM0tLbSeCHdgl/tpmDBE9TDsv0FIcCSt16LHKFQrtstBV383SbNW7KgIs9Ofl9V5gEjrC1N7pPh/ArJ/nfVsLZBrcWcJxSkDQN57c0UJkD9fkKtmtBT7QthixqnRSPYiNhC7sNbCpKAG39xaFYKWnNvxBksRxZAslR4aHiG0K6rexGDGyYQfC0a/h7PeH3ERmK+GIbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=p0/77bOgMdn5xbfR/VFB2ZYeKWpba+foG2spqaIxxxU=; b=RD6krOlWyOnZ1UdU2kkUu3m02qT4ZAMWgOxvSBA2BV0J99DVBUyhMTo9KAEHNVhrK072kFkqHYP89PutvWQEfkdapUoK7C//rE2bqTqCl7ZqNdQOqsWcb9+kOLk2tqte+ClmqmJyjMcw+ZReHlSskGZOyyWLnmukVniOVaCUxDryxzoy3jn9PwmvhEGWvLmeilFgu4FYvXlYP25duXOmtHSiAuQdqfrIAdb+Oylg4l32416ygdCYUddjJFMCI/lJZVERUMz0qya0MihujBI6TVXs/oweU5/JAodk/JOsLY+Pec4M111U+deBItQu7zBFj/7YhKrM83SDrbQwWRtSUA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 29 Jul 2022 08:06:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Oleksandr Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> <3752a158-85a1-e758-36eb-2feb0c5be954@gmail.com> From: Jan Beulich In-Reply-To: <3752a158-85a1-e758-36eb-2feb0c5be954@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR3P281CA0052.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::23) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e11e5bc3-8e7c-4eec-244e-08da7128863c X-MS-TrafficTypeDiagnostic: AS8PR04MB8372:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0FRuVLu8PW2DGoYOATKknZNdUBEcOInwMetXxUGCgpwuFH739u8XcncyxAFHUBM93CpA7rW35XfAg4te9QvdzABPRSzEVmdZPbKUXAN1raMfpqLljC3VkjmTEVtMFgojbUDR8or4tn7W8iTiR3PKr4zkX5P4m9IvRntcBta+jBbDY+493ORWmjR5C42xJjQ72Tj8AGPQbrdb+4IiPBwPqCaZ+21jhpTUYvsIzil3rmimDW+GmJ/gtqgDUKWvDUOieYg+mmCu7nORzCaIvz7DLiVd9qajNGNieSHFnP3GefbG/5pQPT611CyukCxBTElRAQM6awX6auTsin0jiBpId9qWuCnWMo2aqiPCNqzselJTpht9pwZ3siP2RvSomxEOoqfxGQPCwa6YtNKdim+lST1DhwcQ6WNspMHwLpvUn9LUsSLcd2MPyWLgDeS/h4zYytpdcyMWR2s3N/jFbESQxyhTZvtjlql3fZFpuSmueAYiSw/RJSm6ciLTTTBRgzSpAd5l6kPnz5y2kiQ1YFsCpBAwnFqmmvffznVlVOTmtDOPqpH580of/v5bl+AsWPeYdvdUoOzoucnFnHRTOteIOq/3Ozrs+dw5IK/xMSjfqTF8j7BBZyhV+ZVjn+jg0h3YlP6RmHbYzAjuCw15/xNYlFUPsr2bt6IgOBlvoQPfbDxTdSuU0Fn8i4TnnTn8MWosn7bbE1N7/4h1DFpDSRy4Ope+mKUCbSfbfS9jbh6r9F+6ee36EjQbv/W4vE+BbGk3tSNb7XAG0SkbLOvoSPldnjpHwtXpjx1i2W1kvBu/xI9s1WyCMGw3Q7vW6eDykn6lQnBNcYPNUPVWYcRZPL3kQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(376002)(39860400002)(136003)(346002)(366004)(396003)(86362001)(31696002)(31686004)(478600001)(5660300002)(8936002)(316002)(186003)(4326008)(66556008)(2616005)(66476007)(6486002)(26005)(38100700002)(8676002)(6916009)(54906003)(83380400001)(2906002)(6506007)(66946007)(6512007)(53546011)(41300700001)(36756003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TERHbUFJS29qaVZIUE16cWpVYTdCU2ZYVUUxTkxtYVk4cEpsR1QycDl2R1M3?= =?utf-8?B?elF0SXhEOTRWbWxFSmF2R2cxa3l3OXBMMGRNazI5dVVjOEk3SUZnck5GZkdS?= =?utf-8?B?U0NBUnlnZzlZS1BmaXZhRU1mT3RYZHkxZjd5c2w2UWpHa2xEWEQyREYySHFn?= =?utf-8?B?dUMySmM4V3B3VW5zQjhTdXdJT0FkR0xlTC9hcTc5SzRTOWxXazNLMGdTTjhH?= =?utf-8?B?RCtOQmFFaHN4TlljTERNTjE5S05BU3hoaDVBY1lpTHh4MUhXTEV1Z2tDVG41?= =?utf-8?B?d2ZqTkU4TDNpSjBlUWdSZk4venEycWhqdWdqL2llL0d3d1hCRExWS2tuV0Q0?= =?utf-8?B?aFQwSFoyaHp4ZEhOKzNsY1Jnei80dHVVSEY0bUx6K2FqeEpyak5mN244NWRn?= =?utf-8?B?bzI4K1lBaEFiU3NSMnZac1BFUVB0TlFRVExHTWFPUHZKd3cyMEROMms4R3lU?= =?utf-8?B?bkF4amE5RmlwR21hZ05tMlFaUGJpNkdhaDJocXNYN3pFcmQwakNhM3lZdGow?= =?utf-8?B?bVQzWGZuME9WaUZqazB2K3Z2Ym1iYnNRMysvRkgyVkR1MUtNWFo1V3RzdGFL?= =?utf-8?B?b2JEQmptcE9mUS9pVkZLODhKajRCbXFHRjVxdEZVV0NlcXo3NGNsaE1xN2Ji?= =?utf-8?B?WEZRMStPZVRCc1lpQ3U0Q002M1FERSt6R1cxMEkycitFbHJEazJVUi9DUExI?= =?utf-8?B?eXFRVnlTSkRTaHpRZ3d5emhhVXQwQ3g3NmIxSTlvS3dOT05BeWlhdi9aOHdI?= =?utf-8?B?TnR5bDQ2WlRMeURLeUxlakZQRnNZS2tUdWpDaUUrT1JjT0trWWhsQk1RMTQ3?= =?utf-8?B?bmc1UDhXMVB0QWJZU1puZ0xsRGRJSVpPV0YzdXdLelFMSkV6RHErTVorczBy?= =?utf-8?B?VlFQUkdFaGJzWnR1b1ZhYU1TZGVyMVdpbjBDZTR2VXB2L0tMcGRORTA2NkN1?= =?utf-8?B?c09wVk1NNVlkU2hLcllFYlFZcWZwa1AzOTRBakRVSkpYeHBFQWd4WDQ3WTB1?= =?utf-8?B?SWhYSlBwZnp0SGVrY09LZUtqVm9CeFo4djl5REswcytmY3h1SlhXK01qQ3Fw?= =?utf-8?B?OXFOTk82MVdFdk0wcG82a1VCUGpaTlVDN3ROUEVtdWpzYS9oVGl3aG5UUzVy?= =?utf-8?B?WWhmQWpoL0NBaVdPdmVjdFVGb08zcFVPbWpCaVJCVXNFNE8zZ0s1TjNUcmZD?= =?utf-8?B?clB1SEtXd2pCNVRMYzJHblcycy9VZXBqMFdIcmpleThBTjZ6bmQ5bjlHVDAy?= =?utf-8?B?cWd5OGEyZGc4S2JENGtxQnlRb0UxOTZ3Z0JJclN4V3Q4ZTZ6R0NPNkxYdURW?= =?utf-8?B?VTZteWhqYU83bGU4T2pGWXQyWHRTWXBSODUrdUMrNU9FRW1NSW82dlpvampC?= =?utf-8?B?MGd4TkhIZXdwMm5zV3YwYWlCcGcvVllYRmNTS0MzNS9yZHVGT3N3cGUyNzQw?= =?utf-8?B?allGakVTbVhIcWpWRVd4Z0hZUjVsMXpXSnRCVFoxUHhqSjBiSjB0cUlPRGZ2?= =?utf-8?B?cTBqaThnTkd5b01tZ3VxNVMwZkhpeVhpck9UZGY2NlVZemhxSVdneUsrWWc2?= =?utf-8?B?NDVWSEl3THp6ZExPajVuOVJ4WTl5a01VWlcxOXE1STc0Q3R5QnkxWFI4ak1N?= =?utf-8?B?c0VRRTlXb1ErcXJYaWFnMnBqbzc4bENUVDdFSEQ2bU12ZHRCSW9VSFMwaXov?= =?utf-8?B?OTd3a0RhUjRUNjVCSHFBUC9ycVAvNmxlOE1qWmwxNTM3NHNWNHU5amRlUGVU?= =?utf-8?B?RWZyTmdtNlJxVHJCdEN2UHFOTGwwc0pMOEdYM0gvWXpZeDFDd01ROXkzNzFW?= =?utf-8?B?c01Kc1RlTFdIclhpb0lMTzR2Y0g5VUxhY3hkT3hmamhYV1lrQWRYci90VWcw?= =?utf-8?B?aThJKzB2eXlqenZScU5TK3Q3YStNdnBhSDUyakxqbk1LeG5pblNIb3F5TmtK?= =?utf-8?B?L3U1cVhwdE1hVlV3c1RDa1U1NFJoUEx1QnN5MzhNYmljTnl1eHlEYW43UDFs?= =?utf-8?B?akUvNEIwSlF3RXlYYk1GQTcwU3ViY2xyZkhjaTcxK3pQMGVYRFFZNVQxUURS?= =?utf-8?B?UHJ0SllvZDQySGFjR01wMUpwRTkrcVQydjBMMThCQjQyVWZEVzM5U3hOeHAx?= =?utf-8?Q?YbapSkfQz5perPdBKVuESCpl3?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: e11e5bc3-8e7c-4eec-244e-08da7128863c X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 06:06:49.2315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Q/9h69EU07Ls0w69Wp6Lq+b25Lbz4VHqqQqdhwdXJJBOso7jDBLgo6YPGLmZarknIpSM9AgnPRsx4lzA4muB5g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8372 On 28.07.2022 18:35, Oleksandr wrote: > On 28.07.22 10:15, Jan Beulich wrote: >> On 27.07.2022 21:39, Oleksandr wrote: >>> On 27.07.22 20:54, Oleksandr wrote: >>>> On 26.07.22 18:16, Jan Beulich wrote: >>>>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>>>> --- a/xen/arch/arm/vpci.c >>>>>> +++ b/xen/arch/arm/vpci.c >>>>>> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, >>>>>> mmio_info_t *info, >>>>>>       /* data is needed to prevent a pointer cast on 32bit */ >>>>>>       unsigned long data; >>>>>>   +    /* >>>>>> +     * For the passed through devices we need to map their virtual >>>>>> SBDF >>>>>> +     * to the physical PCI device being passed through. >>>>>> +     */ >>>>>> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >>>>>> +    { >>>>>> +        *r = ~0ul; >>>>>> +        return 1; >>>>>> +    } >>>>> I'm probably simply lacking specific Arm-side knowledge, but it strikes >>>>> me as odd that the need for translation would be dependent upon >>>>> "bridge". >>>> >>>> I am afraid I cannot answer immediately. >>>> >>>> I will analyze that question and provide an answer later on. >>> >>> Well, most likely that "valid" bridge pointer here is just used as an >>> indicator of hwdom currently, so no need to perform virt->phys >>> translation for sbdf. >>> >>> You can see that domain_vpci_init() passes a valid value for hwdom and >>> NULL for other domains when setting up vpci_mmio* callbacks. >> Oh, I see. >> >>> Alternatively, I guess we could use "!is_hardware_domain(v->domain)" >>> instead of "!bridge" in the first part of that check. Shall I? >> Maybe simply add a comment? Surely checking "bridge" is cheaper than >> using is_hardware_domain(), so I can see the benefit. But the larger >> arm/vpci.c grows, the less obvious the connection will be without a >> comment. > > > Agree the connection is worth a comment ... > > > >> (Instead of a comment, an alternative may be a suitable >> assertion, which then documents the connection at the same time, e.g. >> ASSERT(!bridge == !is_hardware_domain(v->domain)). But that won't be >> possible in e.g. vpci_sbdf_from_gpa(), where apparently a similar >> assumption is being made.) > > >    ... or indeed to put such ASSERT _before_ vpci_sbdf_from_gpa(). > > This will cover assumption being made in both places. > > > diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c > index a9fc5817f9..1d4b1ef39e 100644 > --- a/xen/arch/arm/vpci.c > +++ b/xen/arch/arm/vpci.c > @@ -37,10 +37,24 @@ static int vpci_mmio_read(struct vcpu *v, > mmio_info_t *info, >                            register_t *r, void *p) >  { >      struct pci_host_bridge *bridge = p; > -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); > +    pci_sbdf_t sbdf; >      /* data is needed to prevent a pointer cast on 32bit */ >      unsigned long data; > > +    ASSERT(!bridge == !is_hardware_domain(v->domain)); > + > +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); > + > +    /* > +     * For the passed through devices we need to map their virtual SBDF > +     * to the physical PCI device being passed through. > +     */ > +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) > +    { > +        *r = ~0ul; > +        return 1; > +    } > + >      if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa), >                          1U << info->dabt.size, &data) ) >      { > @@ -57,7 +71,18 @@ static int vpci_mmio_write(struct vcpu *v, > mmio_info_t *info, >                             register_t r, void *p) >  { >      struct pci_host_bridge *bridge = p; > -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); > +    pci_sbdf_t sbdf; > + > +    ASSERT(!bridge == !is_hardware_domain(v->domain)); > + > +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); > + > +    /* > +     * For the passed through devices we need to map their virtual SBDF > +     * to the physical PCI device being passed through. > +     */ > +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) > +        return 1; > >      return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa), >                             1U << info->dabt.size, r); > diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c > index d4601ecf9b..fc2c51dc3e 100644 > > > Any preference here? > > > Personally, I think that such ASSERT will better explain the connection > than the comment will do. Indeed I'd also prefer ASSERT()s being put there. But my opinion is secondary here, as I'm not a maintainer of this code. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:17:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:17:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377311.610456 (Exim 4.92) (envelope-from ) id 1oHJJ3-0002N7-9T; Fri, 29 Jul 2022 06:17:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377311.610456; Fri, 29 Jul 2022 06:17:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJJ3-0002N0-5t; Fri, 29 Jul 2022 06:17:05 +0000 Received: by outflank-mailman (input) for mailman id 377311; Fri, 29 Jul 2022 06:17:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJJ2-0002Mu-Lp for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:17:04 +0000 Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00040.outbound.protection.outlook.com [40.107.0.40]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1003aef0-0f06-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 08:17:03 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2299.eurprd04.prod.outlook.com (2603:10a6:3:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Fri, 29 Jul 2022 06:17:00 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 06:17:00 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1003aef0-0f06-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aFbCFql72oSanqjDoA7G59yAs9FJPvGLfrn87PEmIKEeXvj/dJaOUDvcCRcoPgWP9GS18ldU8WGaHqzHOF27dy49xPqthOC/q6vUbAtqHwo/WFhhAqPjdUW7xs1JPQ7D1XruH720ieEbLhnD7l1Li6Cs2biFyatH0PV/XvjK8HgDBuxekckf2Iall3HIa1NEcU9PpQe63Mc1AogFE8DmTwBhjEDySkAGy638DK1OTeJDBq7UWbFsbfK0u6NDluHe7YmmQtz+Bmuii0rQxdgWf3THezy4iw6Drbm9RZBVera1I7urSygCNxin1Q08jq5KVa492uGXHJm9Qvj1xJD2iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AVKM3Rod3d5UqMux+/1t4vz2tPeoFxxUo/Xham+fuP0=; b=Edo+LmOwbBsnAI1UelfWoky9qT+kq2ftwkI7q9XrZHssYco+VdXi0BK+NiyRZAwwLc78oJiR4j46yuqbZimQprcMz/UcAkZmDvLyOpwpt2iwElpxjfs96dnS3KkYAH2NFdJckSa0pY2M6y7lE4X1XR4sbB9EzU/3Igeyni27Tr+iCNZMGJ791wMzahj8G6/rkS2793b6crkuelu8aKsnm7/9Ww5ypzGfm+b1pMlxpqoiSZQ4L+ODLVkf5NvAPGw91LGintDNoU54Dc7BERl3pipEoqw+4BnsO5LQF/FzsGjMC90ndo8+xVpwDjxrHIthP0zYY1r+DbZF8jlZDUFODw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AVKM3Rod3d5UqMux+/1t4vz2tPeoFxxUo/Xham+fuP0=; b=HViJ/yu7MmXJvrnbNwIQvW4UAyAcNZ2uHePbXX4ed81gVn/yfxT6H2u773w94ru8yVerNaf1VMTNbfYOA547Aql0gp68qoMak6QVbtaGsx5u0yNAvmx5wIb5LuKwDO5/S2+RDs7pg5W0VAhwvXxEMkBTwzueZZdS9WSYkh6dnx6k6wF2LLcuurZKAWky3Lw4plDMZB31jFd4y8TJ4ZkN1NRQnpuZbTpgDRbVu61IJLkh4CYM9XCZPi4RxQOS3D/rGpI8k7NufhTz7Xbg4kUk5k6a/H2i9Q8W4H8vPhq8ApFojK85BXo5LEH1bE3l6m3NXECR96mSWkOpI/phWHklIg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 29 Jul 2022 08:16:58 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0047.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0259b68c-a7d9-422b-e54d-08da7129f299 X-MS-TrafficTypeDiagnostic: HE1PR0401MB2299:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Jo3H+YlGifwRVs6PiwHnKvseknKgfLiKer2URi67xzzs3k4NhQJZYj6gB/4PdKDeoEha9yveH80YOcSyK0B6w7ReoLGqNkD/4m7YEzYfLJJO3tPpLicg0qmmDR+9d25SYAdQjBr00Yu9c6l6Di9bJ5YzhC4akVo21hs1U9xeG+rR6+2lvyuVF5Nt9u0v369JyXfl+MZCYMi+UyDzQ5z4VvAAfoprKFYFzBC/ydnY9aHP3TAMdJ43lybNklyasHoiXM0ZE54xHsmb5zgBBMI+RgOgq7hq7mVvv9E3PxutE+LHhC7zmnXxunYeGzZY38M/cFuSSJ7ewo6oIcLmLcGSywXuYxJLQqcnA02ggRp5ZfgcTu+MkVfcBiAoxZFkOU6N8gdlpFdsaaZzSYdzp/pEU+Z5OlDA0x+PAWFJAVDpNWcqv7z8vgFL5FI+Umf+lawyNY2r+gZ7kticEC2nnKA22hR8FnfAH8/Wkiq5IkmEWGnWvvW1vBC0NAb+rNGanJL33EMt3bq0yHJcT44gCJAdBmu7+grXdoJ+csk3JIXe44emaD+967C1Mi9e4ePEX2cuhw/vj7zY7LZqeAigPpJtbGLwfFjLPfdrZG0KutABi7U6z0o5nr/BF+CjfoXcQNtOKlO2Mz81iYHzh6SaL4bNjP4OTVEUculFWo7U/vtGjNCK8C7FNJcXk2gt454D3iIRJ7Vfwvn8ZGDQJGmA5R/epCQyAokjlAurEORRbMSc6z8NLe5nx/JoqxDwmt6qsq1VUL+KD7r1wubADgSjTpnkIHJ5b/5MC2Avz19fgBJQ238HzyzkCBb2PJpwYT4HyD5+jl1t26kBktaGVFewIoXB4A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(396003)(136003)(376002)(186003)(6512007)(41300700001)(2616005)(316002)(8676002)(66946007)(31686004)(478600001)(4326008)(26005)(6506007)(66556008)(66476007)(53546011)(36756003)(31696002)(8936002)(83380400001)(38100700002)(6916009)(86362001)(54906003)(2906002)(5660300002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WmlqeVY2ZlIrMEg0NDhVZDVWYjlBVnJOVFltbU5QNC91aEYzTitWODhFYzZX?= =?utf-8?B?S2Vydm9VOFJ2UXFaSklEU2hVNkEwRFRYZVhRZXVsVVZTVHN6TURteGlnK2NY?= =?utf-8?B?NjNmV0gyYnNVd25nTlhLUzFCR1Qwc3FrUlRxY0hMOS9JVjdweFZLNXdaUE9l?= =?utf-8?B?ekZEaWc3LzBaTFBJbll4SlFyV3E0ZEgwaEhwUU1COTYwenNnTklReFBmV2hR?= =?utf-8?B?ZFRXcFJDNmxLNllIMGNFZU1qQW9Xc2Jxc290dzdrd0MzdUllUlRBQnJtcHF5?= =?utf-8?B?RjZkUDd6NnFGRG5OdUgzZ2Y0Q3FFM3Q1NzA2UlNYMXQ5eVRDcmM1b0dkT3Zu?= =?utf-8?B?T2VuaXdEKzhNRlgzQ05lNjlPaHp4dkRhd21JK3ZkMEFvZ1Z6TkJlSjVnRnc0?= =?utf-8?B?VGlvc3Rha3hvbkJaNmRYdlErZGpkVFNLMEZhVEVhcCtKdnMxWnJ6UWRySEZa?= =?utf-8?B?SWZkajNPZDlTQTI1Z3VQVk1PZ2phOWNCaGlmVTFidUZRV0lWc1JmYzJCVEpO?= =?utf-8?B?K1BOdkk0YTRJV0w2M2Vid2NlQk9nRms0ZFZHRSt0WVJneHA3QmdiMkg2TXRS?= =?utf-8?B?MFhOcW84dFlMQlJ2dE00T3FPL0crdXJpR0FHcFRCbVpGSmRZZzlBd1VibVdE?= =?utf-8?B?YXI0QTRrVTlZd2o4bTNUWjJNUStZc0JqV3l1b1VuZCtxUWtnWEtrb1FDenNF?= =?utf-8?B?UzVuUmtjcjFxZjdLaFR4UXZTMDZvcjZrWTduSUxPZUp6Z2dqanhpaStvaHph?= =?utf-8?B?aDJuaXY1d1NRTjJ3UEtnQWlvdm9FekhRTXkxYkJjeXMvVDA4WGVMMTJkVmU3?= =?utf-8?B?S0RyN3FvSStPRHVxMDNtQWVkODFhRERMS2lUTTJ0cDl3WEdNcXVIWDllcFhS?= =?utf-8?B?bk5RMTd5R3lCR0lJYUJKV0pvQ201QXlHTXJzaWZJQnl2a2xrK0h6cllPTi8z?= =?utf-8?B?YW9lb3VqMlhxSVlpZUphQ3M3eUNPR282bEszdWhvdXU1YWVPYjZjS2tySTM2?= =?utf-8?B?Mm9GWGR2TzAwSmhyWk5BYWlmRkppSlYxMzhzVTV6aThIb2hzVWFnNExhYTI3?= =?utf-8?B?UnJONDV3RDNzZlo0R3kwUGJtWjVXbjdlRzQzTEVOTlE1OXVORlhiazFYT3Ew?= =?utf-8?B?bEJvd09WcE5PeFhmOUtSZDFwVDlWY1MySzdGcWs1UGd5Z3NnT2ZOaGJjZXo3?= =?utf-8?B?L1piME1HMHJXNHlRM3l3cUpuMFhucUpTTFJ0RmhWY2pkZ3ZIVWxaeEkzSmlD?= =?utf-8?B?WUx0ZzlWR0pHLzhGZVJxdElvZzEzTU1WbURGaWdUL2lvNG1hY0txdnZNc2ty?= =?utf-8?B?THNPUzNHUTk0NThrYlNaN2JPRndiREhWTGZ4V2pHMTFscVljdExBNEtzN1pi?= =?utf-8?B?OXl6WDMrSGlMUzhzZ1RqYW9QcGtyTjBZdWN2NnJWeUd1ZnRONDJCYWJhT3JZ?= =?utf-8?B?TGF4aEp0OHpVWkFVYlBqZDZDS3BsYXVEOGI4WnhhcnMybzM0cjJoSVZxQXM3?= =?utf-8?B?Q3NncjdLTW9SOGgzS29EQnFtdFlqOStML1JGTHpEd3FNLyt1UVFCREl6RzEx?= =?utf-8?B?am9wT09sTkpMc0pEdEtkNEtDU2pjOEFxYXg0T0prOFM3ZzF1TlBET05FdXov?= =?utf-8?B?L0svYlFqNTVEUzFtTTlwZVJjZTUwcGlUSnEycHFEREhyRHRKMlhwSUhsZ01X?= =?utf-8?B?RXZRRFA1MGxsNkNONTVhK09TY2JOY2ZGMGJSQjRTeG1hek9XRkdFZ1ptZHJZ?= =?utf-8?B?TUdhQXVXSFVzQXEzaC9WUEo3YVVSaEhvSmp3b3k4cmpNMkd0bWtWRlNlSFJG?= =?utf-8?B?NEZiNjZzUU5xVitQcGZSMzkrdjBuSWh2emZiL0U4UHp1MDg0Z1BuNkZtcEY4?= =?utf-8?B?dkhFTjNCK1c3a1dxMFY3bjVSQWJjbkllMFFEK0hrK3VScjF4ZDV5MnpZLzVW?= =?utf-8?B?SGt1bjVvMEIyc1BvdXlZWVJwTENFZStwUEhkRXBaTHduNngwaFdhYTlBNmdq?= =?utf-8?B?bnI2N0VqK0xBT1VCNEY2QlMrb2lIUXppcFhaV2UySkY5QkM4Z1MwOG9XYnMz?= =?utf-8?B?V2czc1l1SVVUMHRhc0dnRW1NbTIyTXIrbVVZZmVvNDZKZjFtVTU2NjBacTgz?= =?utf-8?Q?xhDjL8RM7gNhF1pj10gbRxSk9?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0259b68c-a7d9-422b-e54d-08da7129f299 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 06:17:00.5210 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tuSoWeyhTw44u5TcRwWHUEXKiRtJgV67hJv1FG3+nNaVzz/xaL0j87RjUiuGFXnwL2lY/xDhpymxmWPEU/oEuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2299 On 29.07.2022 07:23, Xenia Ragiadakou wrote: > Hi Stefano, > > On 7/29/22 01:56, Stefano Stabellini wrote: >> On Thu, 28 Jul 2022, Julien Grall wrote: >>> On 28/07/2022 15:20, Jan Beulich wrote: >>>> On 28.07.2022 15:56, Julien Grall wrote: >>>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>> @@ -461,7 +461,7 @@ >>>>>> /* Access to system registers */ >>>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>>> - uint64_t _r = v; \ >>>>>> + uint64_t _r = (v); \ >>>>> >>>>> I am failing to see why the parentheses are necessary here. Could you >>>>> give an example where the lack of them would end up to different code? >>>> >>>> I think it is merely good practice to parenthesize the right sides of =. >>>> Indeed with assignment operators having second to lowest precedence, and >>>> with comma (the lowest precedence one) requiring parenthesization at the >>>> macro invocation site, there should be no real need for parentheses here. >>> >>> I am not really happy with adding those parentheses because they are >>> pointless. But if there are a consensus to use it, then the commit message >>> should be updated to clarify this is just here to please MISRA (to me "need" >>> implies it would be bug). >> >> Let me premise that I don't know if this counts as a MISRA violation or >> not. (Also I haven't checked if cppcheck/eclair report it as violation.) >> >> But I think the reason for making the change would be to follow our >> coding style / coding practices. It makes the code simpler to figure out >> that it is correct, to review and maintain if we always add the >> parenthesis even in cases like this one where they are not strictly >> necessary. We are going to save our future selves some mental cycles. >> >> So the explanation on the commit message could be along those lines. > > First, the rule 20.7 states "Expressions resulting from the expansion of > macro parameters shall > be enclosed in parentheses". So, here it is a clear violation of the > rule because the right side of the assignment operator is an expression. > > Second, as I stated in a previous email, if v is not enclosed in > parentheses, I could write the story of my life in there and compile it > :) So, it would be a bug. > > So, I recommend the title and the explanation i.e > "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation > > The macro parameter 'v' is used as an expression and needs to be enclosed in > parentheses." > to remain as is because they are accurate. I'm afraid you're following the MISRA wording too much to the latter. Earlier on you agreed that when macro parameters are used as function arguments, the parentheses can be omitted. Yet by what you say above those are also expressions. As indicated before - I think parentheses are wanted here, but it's strictly "wanted", and hence the title better wouldn't say "fix" (but e.g. "improve") and the description also should be "softened". Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:23:05 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:23:05 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377318.610467 (Exim 4.92) (envelope-from ) id 1oHJOm-0003qA-3d; Fri, 29 Jul 2022 06:23:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377318.610467; Fri, 29 Jul 2022 06:23:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJOm-0003q3-0d; Fri, 29 Jul 2022 06:23:00 +0000 Received: by outflank-mailman (input) for mailman id 377318; Fri, 29 Jul 2022 06:22:58 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJOk-0003px-GU for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:22:58 +0000 Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140054.outbound.protection.outlook.com [40.107.14.54]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id e2f9f3f0-0f06-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 08:22:57 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR0401MB2299.eurprd04.prod.outlook.com (2603:10a6:3:24::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Fri, 29 Jul 2022 06:22:55 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 06:22:55 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: e2f9f3f0-0f06-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gzyfGKqAgtxVuEACmiM+QKK2Yc3EDlzc4L3TwlVSMg/pDZ/6zsloisj5d0NnZFAmiYGgfj3iopfqnlbcQJ8cXfx13AdhU0YOhmFwl1HwYm6u36tRXpWLBhNahUDMTl5bdk0ExUvSaWkEUvhfktvsbnYJddt25By9yUBgWUCNGSKm64CZbOXn8exv8vugwIA0tMuYjk3dw4aztZGgyhvk0YmzQfbNLly5Bj0u92HShq2zv5zQPJ7QYFguXxQSj7MNkpOMZv9+iMmZA8kgo3SUgdN/9BT62JYsoYZixh7797xZAr/1dKtcUr41+v6zk3SMK4Ako9nrze4ighkq6R9j7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+9tt6EqXxD28ek1A0jl1qTXqxV7UgAC/yWPsX7RWDbo=; b=EpIf3xsbDxqKJWF0rUVJQW0HeLgOg10Rn4uRP+zuKUJlZY3TID7ztWNDbYFnniaA64bFDwkbQsi/dYrjbCq8tfllEUKBkY7aKjgYwVZGWp7N/+h/vbkg9CCqwBkvOp8HeeFCvHV+Cg9YL8worYq+Q3xcWaB2RYRQahcY0o4SV2StGGDmb9FTWiFiFmQhoAA+DpRZJkLyOSFWbV+7G4b21ayNJBuSmFLkFJo76KxfH/dGpj75d1rrCTJxph6LrxV8usxEWINslbHimHkhU5ev9Z7DLslBcQDU0rRqiKX4ZNWBAzhfw6pdOauo9symU81GRS+qPJEqDne4M7DrCAV/Ww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9tt6EqXxD28ek1A0jl1qTXqxV7UgAC/yWPsX7RWDbo=; b=DcCc+mg9qAcCt5YUXm2KYDxRck1a1kJhKjnuR2G9VteWCggUrPvQTsZZKFi/fOyXRn2MmQHu8HP/hTTZTI7Cm5So+2XOsrrNkXE8vy3JGzw0xr2bvaSGu5Zo98zMBBXqkbF+AhjdvkimPRqbqkIdoxG1Hrv1n3s7Vx5NZX2Cfvl2bslYK4p4ET+9ny5uQfBB/+jPZm+O9GGZv+P4r7q4puuZUaAmaRWvUxc8TCyh8zyxH6/b9BG7pZFdwGKehfmxT7Tgt+pvnAw9bEABOG3JIzgh5lgUoxD3rq5ymiPMf/T6jYbvVSqETdhR7Oe6C/GOm/Wo9pCqEBCV6ZMo1Hyf5Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> Date: Fri, 29 Jul 2022 08:22:53 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Content-Language: en-US To: Oleksandr Tyshchenko References: Cc: osstest service owner , xen-devel@lists.xenproject.org, Julien Grall From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0120.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a3::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6dad35cc-baee-40b4-4dc3-08da712ac60b X-MS-TrafficTypeDiagnostic: HE1PR0401MB2299:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4kkBcODQfw1koCTDKLa9NSXGw2pOLkZpPynGEVffNiD9AyHDrSNUvjMs7KO0YNagxKLqv/xE+mYG1WJQ2AmDRIr5IsGw/0W4XTSgJ1ea4qiKE+kOEFbmYhqgo6vLYHnAlDCTExwwjgfQ4PYML6hkP1Cybo5r8IEl1EHX+KECv0e9O6OUrqeBJWE9CpNG+xk/Ofsxxu/9WEriT6aF9lLS6B85u6dwE9x6F9/+Gx7l0x8LjRLpmAbzGSDoeGyUbxN/d/Qv45beCSgAPbjeIYJoAp9tcd6UqtEsWBD4wi4GEdVfwPPZ8co2Eo6pB9X6Arin8wAMj6/MNByIJdF8RsToV5mc9jbbxA2OQXQqGT2SHHdmJy0Ud7E/4YqOmCVkAa7bmtD2ffrW7YTkPaVs8+clPiAt2wuvJdLLLVo9R6yUKaW2GwJ6CiwTVhaMAiiLieZ5npJrGtW9+zcLUmIobeko4WuY/0CYITfPyQMyN7WUj+Om63GQ71mJd0YfHHeATxdyyk+0XRN+R4IrDYAMd1KSonJdOTnOy4bJ3K2egxxZE+xJaZwGx04VXLAf8zEP4inkJVnrIeleUOsuNhu7m3uZ4tSW1YFYisaUQnAbHGnB/RsGPZC0ouHExSx2zjBpHD/46iSu8NgUPt4IyFaYgZWp1ePOVa0KdlLW49Q/+tvH1MvyP82CL8UqIdBra0QtAT9scOYLAfskWtMNv95ihIUd8zq6SABeYsadhYZQ2NEZ09/LkGxROEzXzOUhlfPgLzi1eQG8bIHk4/EPqRxNkZFJ1ZwqiZgCRTeOXogKuj7FsXf8xHllLdsXx9Mv1sCeoiKLJ38i6xBu/ZiotKLAZCcTfOH5skAUo6vSeG2xr+MYHd/1KYTbp9x2XeAWKX7iXA2C X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(346002)(366004)(396003)(136003)(376002)(186003)(6512007)(41300700001)(2616005)(316002)(8676002)(66946007)(31686004)(478600001)(4326008)(26005)(6506007)(66556008)(66476007)(53546011)(36756003)(31696002)(8936002)(83380400001)(38100700002)(6916009)(86362001)(966005)(54906003)(2906002)(5660300002)(6486002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cHF5VHRTSUd4S3hCTDlKZ3pqQ0luaitoc3NyRDhDcENtWFhmdGlDajAxZzRq?= =?utf-8?B?cUZYS3k1N000RTNYTVpyTVZYbG5jSS9DNEJKNTBDUjhTcEp6YjNjZDZYbjVl?= =?utf-8?B?MFcybVVLNmppZWw0a0pFaU1JdFRRYStlcDJqOGRNZEFJZU5HdG4ybHNEOFJz?= =?utf-8?B?WjcyQndkN0ptdlNMZWpmQVhVRVFKdUcydHlYbEVYUnlRWDlVOWdWTFcyb2x1?= =?utf-8?B?eitwUXNkRHdHRzE0RTQ3YUlrMlQ2MDJDVmIxVWdPMGxVRVBsczkvMk0yZ2N1?= =?utf-8?B?NEdXdThpQnNDMzJQb1gxSXRNdVB2bEx2dGRWSjB2YmpaSDNOVGlGV3M1N20v?= =?utf-8?B?WjkzalROREVicUVMMXVLSWxXcktxV0RMblVYdjlaUmVTYXE2QkU3eG9saWwv?= =?utf-8?B?YllHVGVyZjdkOFp2SWxNOHZvbWJhQWNwMVBNN1pDdjlvUFdYZ0FVc1pmUGZ3?= =?utf-8?B?UEsvZUZzRVJtc0luU3A5UmN1RXlWWVpNSDhVeFpzNWV1eTFvZUQ1R2lKZWpP?= =?utf-8?B?Q0xMTm9xY2RMSFBjNlo0aXIzMmNreGJ5bEw2c3dSdytKMXBSbjg4dDhKOElq?= =?utf-8?B?WVplN2x4ellwVlkyM2cxaGpKREM3eVZ4NDFHUWoxM05oY0N3Q1cvUU0zY0M5?= =?utf-8?B?L3U0cVlvUWtjSldhRGprSGV1NXlBdjNURWVSNFQxWVhuaUxwSHhmM3lMV3ZG?= =?utf-8?B?czQvbDIzcnVkcnFJZnQwVkY2V0EvcDEwQm5zSlgyQVhQUzRHcVRuSnJGQjNw?= =?utf-8?B?d1pDMjBmM0ZQaXowei80Skkyb01zMXFxcTN2aGtZWEpxWkY5Z1FXTE5lUHRZ?= =?utf-8?B?amh6dVF5OWxyRUtsMDZkRW8wRDJBUW9CdlR1aCtNeXBqSUVBZHJhL2xSM0x2?= =?utf-8?B?R1JkTGFBelp2ZS9FTmtMclI4SGhEOUxnYkZsTC9HajgwbWRTMFcyMEx6aGlW?= =?utf-8?B?Q3ZRc24vRjJvejF1R1QyUjM3V25XVVhZOFdzcXljTVN3NW1zRmFyWG5kUCs2?= =?utf-8?B?ZVFXMzhrOGQ0OERTUGJBeWR5aGs3dVpKYlF4cElPVndqamxJR1BmRTg0bmg5?= =?utf-8?B?dWRYWHNwbmNZM2VDZDJydFliRURyandvOEpyMDIyOW45VjlPc21RZUhrT2VW?= =?utf-8?B?dkM0c29kenpSWE5BZEIzWUY0dzVNdE5SYTEySXJ0bWZBRi9QQS9tMlFhNXRw?= =?utf-8?B?cEVYa0R0Z1hhY3BXWVUrTENHQTk2bDk0R2duV29vQ0xYRzJRRzUxc0NCeWV0?= =?utf-8?B?Ym9ZNnF5eVY1clMrVW9JNmtmS3F1MGZGMXNMMzBoQ1MrQjltajB6dVBUV3o3?= =?utf-8?B?dXFqeGxHSFpTS2xDKy9RVENYT3dOck9xbUhkYmpWeWRHdVFURS8zM2hwZklm?= =?utf-8?B?Q1FzZkxGcFZOSFNvcFduMlVIKzh6d3VjbUpBWHgwYXFleVcwY0dMUHh4eEFp?= =?utf-8?B?eldCa0VucDk3ZkJ0SS9ITHdvNmV5Rm54RUYvaWZvOHl2cHVHVGZmTU5lU2Q0?= =?utf-8?B?YktrakttMm9rb2NkZmhUTmJVTWtMQkc2aUJlV1VYNEppVDc3c043cFlhZEFm?= =?utf-8?B?SVBhSlJidlF0b1FBR3k3QjlvT2VJa3hSTlQyWEdYL2JYTjFQV0hkNkZBd2lt?= =?utf-8?B?VjNSMG1sNFlnL21RN0w2amFaV25MRWg5aDNjRGh0Tnp5Q3FTVXpnZU9XWTUy?= =?utf-8?B?ZGtja3VrVFU1YS85TUN2U1htS2ZwYnNyL3Rrc3NQNW14aVpFZm1peDBOMXcz?= =?utf-8?B?bGZ3Ti9teGRHTmdOUHN1QVFqTitib09SVTYxYXd2cTVYUCtwck9pU0NMRjZO?= =?utf-8?B?Zk1zTVJZa1MzbEtqM1ZXN3Q4bjBXWjkvOUIrcnE2TnFkbkVXTllWeE84dzl0?= =?utf-8?B?bHppS2tFVElUcW1IdVBZNk9WM1hlRjRxVm0zTHVBSkRFUURNektTWGVUbEpI?= =?utf-8?B?aURraWtjSm9Oa3EwZHUvalViRDJlaTRLeXdsaTZrM2o2M0k1bUx0Yi9pbVQ3?= =?utf-8?B?VzBNVnRCSjYvQ0FoZmUvanMwY2x4a3VQaU9VZXhOcGp1Q1lWOTNMbE43Y3J4?= =?utf-8?B?Tk5qQ2dRNWRvdXpOQlUxQ2d1a05SM0NVd1FKMmYra0orRWpqWUd5MXBWYkZP?= =?utf-8?Q?UBnqhuw9r/tReSpqX8f6AkK0K?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6dad35cc-baee-40b4-4dc3-08da712ac60b X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 06:22:55.2947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A+cRFeOD4zg1X6d+uwevSvzuQ5QPWh6YbZ04PIHIS6h3aucsWiXcsPnBZVLPcAHXazUr7sWC65zeiZyVkb8fMA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0401MB2299 On 29.07.2022 03:04, osstest service owner wrote: > branch xen-unstable-smoke > xenbranch xen-unstable-smoke > job build-amd64-libvirt > testid libvirt-build > > Tree: libvirt git://xenbits.xen.org/libvirt.git > Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git > Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git > Tree: qemuu git://xenbits.xen.org/qemu-xen.git > Tree: xen git://xenbits.xen.org/xen.git > > *** Found and reproduced problem changeset *** > > Bug is in tree: xen git://xenbits.xen.org/xen.git > Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f > Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce > Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171909/ > > > commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f > Author: Oleksandr Tyshchenko > Date: Fri Jul 15 22:20:24 2022 +0300 > > libxl: Add support for Virtio disk configuration Just in case you didn't notice it: Something's wrong here. I didn't look at the details at all. Please advise whether a fix will soon arrive or whether we should revert for the time being. Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:26:23 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:26:23 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377323.610478 (Exim 4.92) (envelope-from ) id 1oHJS2-0004St-In; Fri, 29 Jul 2022 06:26:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377323.610478; Fri, 29 Jul 2022 06:26:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJS2-0004Sm-Fd; Fri, 29 Jul 2022 06:26:22 +0000 Received: by outflank-mailman (input) for mailman id 377323; Fri, 29 Jul 2022 06:26:21 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJS1-0004Se-9N for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:26:21 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2049.outbound.protection.outlook.com [40.107.22.49]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5c19360c-0f07-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 08:26:20 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by HE1PR04MB2988.eurprd04.prod.outlook.com (2603:10a6:7:1e::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Fri, 29 Jul 2022 06:26:18 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 06:26:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5c19360c-0f07-11ed-bd2d-47488cf2e6aa ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bMMiP9mTyYza4c4sbXusG4MT3SnNm8+WuI4JmDj1mNHm6bpeZVVtzMxaLZU+A2qmGLPK7o2d+dX0idEi9+6BgCvxrZKnTFj9Fu8CrMfqsV3xA3pTB6MHyhv3KzpV7UM9u56VDRxzVWWySVckY5xYNSe7VQCaB9X0JcvLqfgc9FYX9nQFbgk35ita0fMbYa993Z4BmwZxgUo5MSEyF0AhOIk2kXfULURB9ENZFZxMrNjzeMTeUQF/ZEg5dVsWIX3i8Av/T5ursfYJPasjtGNVkLaEGwVqVaaZ5cuquklPPSIDrMUqZGkIruRg0De+anDSnoh2fRVpGAFMfrVzQX+pxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hBBSuU4xfU+gyIFGQY9nTp5nRAfNW1b24aKWveF/5ys=; b=Zq/jrUWicRIWtHPyaENQNCVwYB7VJRwJBQcvlvgokEDwQZgDepGMFbseD694Uy7guT9pAyqwNgPuGGwPEZrGi+dNRUUZhsaCTJwZfVp3IPIUFPNAdDW6AiSihtkEoH+m+mxOzPA5t162dKZzi2eVf4Viz9QhGb3hL2BpuhAioOQcb+uCMvx1z4bAQIMnQEAc21RJuEphDVnt3rtZTRgrU7de91vJlcFkS4x7mAdHc4nN7nHxN4l3O6lhtjvjcC0JoYYt5pN9Ig/Exz6oWWB7aGPDbtTwDTkxeVA8hSPGzvQeTP1NwMkwET57Gyy+jnBPrrBEG/ttCeb5zuQIORAu/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hBBSuU4xfU+gyIFGQY9nTp5nRAfNW1b24aKWveF/5ys=; b=nvgfBTN9ErMWHj1HR6zANY9FdjfTVDZySszAhEP5cY+LdnmRXTN9xCUKWeKXl9fHKeLqNGP4qR4uyHKcc37RJhLOWP+m+Vej2hGrGWack5+7XXf8th7pzzua99d9zpPLGwJT0nFilJq2f+EgnePII9lqApleC8Fj7v6BRYu8P+rpuQp0u8FC/CrCAQI/lB0iR8jS+Pv05EtJZ6xlzymiDQC+x03R+4dk/wxfGk6EX2JNs/BLMDu9eAXmZBGtsF7BHsAQun/tNcZI9Nz8rl+1WzRd+gIl1sYG+v1kV7/iK7ekpk1aDAPNrHlBuQUtZJCyPTQIx1kwVQlWmufpfWzrzw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> Date: Fri, 29 Jul 2022 08:26:16 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728162151.1228747-1-burzalodowa@gmail.com> From: Jan Beulich In-Reply-To: <20220728162151.1228747-1-burzalodowa@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0054.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4a::18) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 60ba7da4-9b3b-4583-9b9c-08da712b3f01 X-MS-TrafficTypeDiagnostic: HE1PR04MB2988:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CueqHDw841IjgqA6YRMr1Wwx9LxsUtzawpERNhgZ7PK8+lmdHSLdRfXEglOiOugL/hK6T145Ph+g2vRDu1lDP+1ci/Gn0zY9gZKcGoo4cDpBxwiKP//eL59lRmJ+Q9C9B/kiGXQvchlX9oSWX7JDknvIFEYogGRLAxJDlN2DDVqzDrpZp/fc+68eCT9W+b04ix2p2yMI/XaXLOQSOM2heawefh1GmcV6hVQOCm+EAA0f1Q91FwKok/LSLE3kzO0gAmEhNNuvrwl2OzwAF3Eez2FLfpcOdfLFXBXGG1LXq/1rB9SvT/1U3Ze8OL5ivZu3gXslW2UwQ4yNLbb3ebzs6Zj4WoxIK2Ax1rkdSE6vQpieJfTDcAmIj51JoFy8jAQrR5QRH/ghbltEczFLm1LpI5mECf4EwfNa1rqvJlYoDfT3Aj7ErWmXRfuKqu/WOV8ru0fFXR3bRRu4mzbev5AwrZ9CtqID+D36yvH4u0YP1vTcqZbkH/ovbjypaFysUeg/7bcSH84WgM9l2WHIs5WjcR7mo5Y4VQUSHT8g4aP+qWWhhwwRw2JYhO21BSfKi79kxmnMEo7Eek0rUAgaNKV5tOti+GOu846m61cRQbYAmlZnqE7LV5yF0pm1ErdQTd5O9TZNU6LM3Wio7GkGA5HH0NWgo3V6l2y34QBFBKOjl+xw0b/ckMzXGpEdQ0gjVeStp1pJSa9otVNWf6TRm+qAAHgo213V3IUsS71wudmEd0TD/3JB2wXkxLTdttn84cOzRKdpTtVPbmue26mjQWB4AwqXMRGuSe8a7LaqAmm4lAVmWjgzGB6K5bSNgsIrzBgn+prXdBfYBwF6p0yvWDqatg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(39860400002)(136003)(396003)(346002)(376002)(366004)(36756003)(8936002)(6916009)(2616005)(41300700001)(2906002)(38100700002)(31686004)(26005)(66476007)(6512007)(6486002)(478600001)(66556008)(66946007)(4326008)(8676002)(6506007)(4744005)(53546011)(54906003)(86362001)(5660300002)(316002)(31696002)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d011VEJESUJvV2sxNVZFWUJTOVBkeU52YUVMdytGMVEzZC91YTdtcWJnYUY5?= =?utf-8?B?Y3ZJOEVoUG5tN0ZYWmZnbncxUy9ETmJIZGJnTTdRYWV2dzI5Ymlvc0hrRGpZ?= =?utf-8?B?elN6Wmc5ZUtDU0lmV0Vjd1pCa21sNmR1TnJaYy90L204bjdabUIzYmVZc2RT?= =?utf-8?B?bDJveFkyaGZ5bUt5VVN0Y1hRb01KZ3kzNmJCRXRkQmFYRm56NzFsbktLTmNn?= =?utf-8?B?MkZHR1ZvVE9LdXkrVWdIQTdocXBabXRqUmJCcHdTQWJwdVBCbmp3eWNMVGNZ?= =?utf-8?B?SjdUU0hJWjNvZE5CV242b3JmNitPSE1sR1I3UzBVcmFtN3RTQlNCd0plWHBT?= =?utf-8?B?T3hZbmF6TFJzZzRBbXpVOWE2TWxtbFlFTUk0L3B3cEo3Rm4vTGJtV1pEelpU?= =?utf-8?B?YnAzV2JqekpEMU9Rcm9TTG1HSzJtaGVKQXRMSUd3OE9MZWt4c0Naa1ZWak9x?= =?utf-8?B?MTFYRy85N0NTak5OSDZzN0lFNHhsKytOVlVZc0MzVE80ZEczcktXQ2Z3OEIw?= =?utf-8?B?ZEZUa2E1UnhzTjZRMnhpWmJhSStQUGlId1IwZzlFai9rbENWUFhpYmc0bFk0?= =?utf-8?B?TXZHaWQrMUxEYWdBU0NzMklaUXJZRGpIQmY1ZG85dHBxWkRXZ1VhZXdsZm9t?= =?utf-8?B?RUtEUUhnTFFiaVVNaHFqeG1NQmQ3MlQvVjlaZGFUZDBQWGZyVmtHMHAzWHBo?= =?utf-8?B?a0FGSTRCUWJ6Y1VJLytQaDdpL2M4VFRZNkJycDIvSFJac2V6c1oyNUxGV0gx?= =?utf-8?B?eUtJK1E3VGd4M1Nzb2RjbWxWV3g5cEl3NkdwcTliZ2VFYm5tOEdCMU12dnBz?= =?utf-8?B?Q3NWNHpnQ0hQREM4Vk1IbWs2Y1diWWgweWFWOXJCbmFMOEZXcVlmanRqY1BX?= =?utf-8?B?U1NZeElsNjc3TDlXelpMNmJydTZ3Q2xvNjVvY0RDQnBad0xKYmRRNDA2VkN0?= =?utf-8?B?cWpIVjhQQnFWMXhLTG9tSUFPVFBiUXhhTVlHbk1EUVkyN3c5NFlZcFQ3VC80?= =?utf-8?B?MkljWHg5bFFmYllxNXRONy9iMlI2QnR5L1BmbDByaXdjRFZpM0JlRXc4Y0x4?= =?utf-8?B?RzNqN0RwdGVRTFBZNHIrMTBOSHlwWWRCdmQ2RUM3bktncHQ3K1VBa3Fza0Z4?= =?utf-8?B?Lzg4YnZjYmc2amFndGRqQjVqcmN2Snp6bGUxZU4zUkRQbi96MW9kR2VXUUE2?= =?utf-8?B?WFY4dXo5aUFNbUdnMUk2eFFwK0ROOXM4VVlRM1A4YjVKNFRjUVVNTDBvVGNB?= =?utf-8?B?aDlOVVUzVi9sYnVPUGJOV2ZGNFgvOWIrek9yUXU2QU02R25rRTFEZTViejB5?= =?utf-8?B?SmVHbjNRQXAwK0FMMEltdzVhSmJVek5PbExKNC9oUzZWKzRVbEdDM2VZY1RY?= =?utf-8?B?OCt3NThya0tEZ2tDcmdqNk5GY3FVaXlUKzV6TFZlU1QvRG94MlliM0Q5TUxO?= =?utf-8?B?TnlyelB6Snl2cncwZy9PU1FpYk5hUHRpdmQzdVplN0lnRnhycy9TcTdjOFcz?= =?utf-8?B?RklwejFreUZoTFVOSHNxOHJXNUZ6ek5yTWZ6M3JqY0tiK0ZFc3BEaVJ3VjBC?= =?utf-8?B?OEZTMVQ0M1psdjF2dDZTU0RRZk01SXpuZjNWNGowMkFoRTI0cjBpYVU0akVQ?= =?utf-8?B?dmIrcGk4b05QeC9BR0JVdGw4NWswekRlazFlYXk4Wkt0UmJka3ZFQy9LRDA3?= =?utf-8?B?a2dFem5TVndjL3ZkcHdla25RYzlpb25ERnJzSFdQMlp1L3A0VndNbGRCczIw?= =?utf-8?B?aEVta2hNMHk5ek1RTUlIUjg5eGxsV3NQM0dnRW5jS1l0eWdGckN0dkhuZmFL?= =?utf-8?B?akk4elAzM1JHMHJyZmVFYmRhSFl0YWlzQXhSK1NvZ2VIMUxpcEFQZ0xRNkVv?= =?utf-8?B?eXg0NUZzeFVXOHIwek0yRVhucC9peXpsd3VPZWN6T0pmNXdDS3hZbkVxb0Jo?= =?utf-8?B?ak9PR0hLM09oS0Q2aTI2ZERRdlphWGNmWmF3QU9IME50anFzMWhwSi8xTSsr?= =?utf-8?B?Vmx6cThqWHRudEE5ajl5S0U0TlJMc0dwZEpqSis1aXZOODcydjdxTGdhUjJ5?= =?utf-8?B?OHZuR09BZU5VMTg0TDVLNUtZeXZ3QjFveFNiTzNrTkRKZ2pncGdyeFI4SnUr?= =?utf-8?Q?tVE4oPLfWqe27zJW0cz+KeSQI?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60ba7da4-9b3b-4583-9b9c-08da712b3f01 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 06:26:18.2823 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jv8ZNc9X5x8Ua/BHwbuM2Oo4RtpLdiDzw83FBCiJ29yWAVQVFKmKab2cNmW+MpHd6Yqb4zY/t4R5+lTmOwlgng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR04MB2988 On 28.07.2022 18:21, Xenia Ragiadakou wrote: > --- a/xen/arch/arm/domain.c > +++ b/xen/arch/arm/domain.c > @@ -63,7 +63,7 @@ static void do_idle(void) > rcu_idle_exit(cpu); > } > > -void idle_loop(void) > +static void idle_loop(void) While you're adding "noreturn" below, shouldn't this one be marked so as well? Preferably with the addition: Reviewed-by: Jan Beulich Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:31:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:31:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377330.610489 (Exim 4.92) (envelope-from ) id 1oHJWh-00064m-49; Fri, 29 Jul 2022 06:31:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377330.610489; Fri, 29 Jul 2022 06:31:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJWh-00064f-1Q; Fri, 29 Jul 2022 06:31:11 +0000 Received: by outflank-mailman (input) for mailman id 377330; Fri, 29 Jul 2022 06:31:08 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJWe-00064Z-T9 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:31:08 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 07761000-0f08-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 08:31:08 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id z15so4631934edc.7 for ; Thu, 28 Jul 2022 23:31:07 -0700 (PDT) Received: from [192.168.1.93] (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.gmail.com with ESMTPSA id x12-20020aa7d38c000000b0043cfc872e7dsm1719742edq.10.2022.07.28.23.31.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jul 2022 23:31:06 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 07761000-0f08-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Cn/oyKxFmI9jm6sR6JbOZ5E2S9s8W49u+9SGsSdMG9g=; b=GwU5ggBFFRZJAc5Qf6x5+JbDAYLYL3Nq4OPNnQvSjNtIf2m6ixoE7c87y7K1SOBh6X XAn5UlSPN0t7jTg432ITOQ6gyxQtS1HaTdiZ9mJU4fp/eeTqOJRpLfW8OUPy9EBPFlEl As27JNht5MmWtkR3Ya4+BJGikK4PmRQLJvXjAAzMw9dycWIguSUfXSbsc7sjZ+NYADGo ZHA8Z+f9+CUHPszPBKU9Nc9TACti1NG367rNvQ2Zd/FT3JiXkyZJrpfeaQqMnMp/fhu+ S2vmHAVxKwQ/PtoExMZEFiR8hiKxdvQ4v8kTFJbWl70caK3N0yLqL/pmC8/Qess0JNFg uJew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Cn/oyKxFmI9jm6sR6JbOZ5E2S9s8W49u+9SGsSdMG9g=; b=LubeNWOMPZPhClBpkR953LrZ3OBSJFhMMhc7wF4P84sPXI/EY6Bz6MkP9yCdSH1MuU p6TAKDOLULLFRuq401ONbHIl0CMM+MGWf9R1XJe6rsuZNNxvbwV/O/BAOQCUY5lD3Rzl orttjiY1OG43yt1kIRF0vEkYyZ2a9nz7UqdOFywqFdcA8aISMSufaRrNfSxOr5vea//y 7VCzfVQXQeEfHbft3kEh7vbsdSk9x0Z5IHSDZadf6yVXUa7iNRNpBlkTkvPLAtlmA8KB PmtcHSKgIKsyc8z4muVBOfwm7LYz9YSsDiW1ohzFfz9FXAQyztKapTXAj05XrxJFFbms yLbQ== X-Gm-Message-State: AJIora9+b+Q74z9Qi6/iIOugUF+WBxyGf5R4yGijxBXSK7JlL7QizIqL M5rUbtKOY1bMvSDwC3zSu30= X-Google-Smtp-Source: AGRyM1uz+5TSoUJKXYuM/VaWbW8G5SAWMhCUJ1963yEdG1WRdtbxUCe1dqyCrdDbowUYiGqmdIddog== X-Received: by 2002:a05:6402:428a:b0:42e:8f7e:1638 with SMTP id g10-20020a056402428a00b0042e8f7e1638mr2101231edc.228.1659076267184; Thu, 28 Jul 2022 23:31:07 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 09:31:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Jan Beulich Cc: Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> From: Xenia Ragiadakou In-Reply-To: <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/29/22 09:26, Jan Beulich wrote: > On 28.07.2022 18:21, Xenia Ragiadakou wrote: >> --- a/xen/arch/arm/domain.c >> +++ b/xen/arch/arm/domain.c >> @@ -63,7 +63,7 @@ static void do_idle(void) >> rcu_idle_exit(cpu); >> } >> >> -void idle_loop(void) >> +static void idle_loop(void) > > While you're adding "noreturn" below, shouldn't this one be marked so > as well? Preferably with the addition: > Reviewed-by: Jan Beulich > Yes, but I was not sure if this should go in this patch or in a separate one. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:32:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:32:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377335.610500 (Exim 4.92) (envelope-from ) id 1oHJXc-0006cV-DY; Fri, 29 Jul 2022 06:32:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377335.610500; Fri, 29 Jul 2022 06:32:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJXc-0006cO-Af; Fri, 29 Jul 2022 06:32:08 +0000 Received: by outflank-mailman (input) for mailman id 377335; Fri, 29 Jul 2022 06:32:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJXb-0006cE-IF; Fri, 29 Jul 2022 06:32:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJXb-0003VR-En; Fri, 29 Jul 2022 06:32:07 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJXa-0004pI-VI; Fri, 29 Jul 2022 06:32:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHJXa-0002wh-Sq; Fri, 29 Jul 2022 06:32:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=+JiCVndVNUm5Xcq/T/iE2H+sJ5v+AqzDgtgOzNsyPhU=; b=T8bdQj7qq1i8/fqpq8ZC7jJXXX +KQNaXzK5b98nL6ZsdAA24f87QsMebvwrl1w3H6A8reokjxfhRj4OysERxtWc6jXSEoVRkcGdv2pu SUleUz9Mpz8fGiSm79vRZ9XDeZmBwcB+iMxCnvBR/ArrndgszbQ14AnEhXP8z/lEBmzE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171901: trouble: broken/fail/pass X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64::broken:regression linux-linus:test-amd64-amd64-xl-qemut-debianhvm-amd64:host-install(5):broken:regression linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=33ea1340bafe1f394e5bf96fceef73e9771d066b X-Osstest-Versions-That: linux=6e7765cb477a9753670d4351d14de93f1e9dbbd4 From: osstest service owner Date: Fri, 29 Jul 2022 06:32:06 +0000 flight 171901 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171901/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: test-amd64-amd64-xl-qemut-debianhvm-amd64 broken test-amd64-amd64-xl-qemut-debianhvm-amd64 5 host-install(5) broken REGR. vs. 171891 Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171891 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171891 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171891 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171891 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171891 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171891 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171891 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171891 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 33ea1340bafe1f394e5bf96fceef73e9771d066b baseline version: linux 6e7765cb477a9753670d4351d14de93f1e9dbbd4 Last test of basis 171891 2022-07-28 00:42:47 Z 1 days Testing same since 171901 2022-07-28 20:11:14 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abhishek Pandit-Subedi Alejandro Lucero Anirudh Venkataramanan Benjamin Poirier Christophe JAILLET Dan Carpenter Dave Switzer David Howells David S. Miller Dawid Lukwinski Dimitris Michailidis Dimitris Michailidis Duoming Zhou Eric Dumazet Florian Westphal George Kuruvinakunnel Gurucharan (A Contingent worker at Intel) Hangbin Liu Jakub Kicinski Jason Wang Jedrzej Jagielski Jianglei Nie Jonathan Lemon Kalle Valo Kuniyuki Iwashima Lee Jones Leonard Crestez Liang He Linus Torvalds Luiz Augusto von Dentz Maciej Fijalkowski Marcelo Ricardo Leitner Marek Szlosek Mat Martineau Mateusz Palczewski Maxim Mikityanskiy Michael S. Tsirkin Michal Maloszewski Neal Cardwell Nikolay Aleksandrov Pablo Neira Ayuso Paolo Abeni Przemyslaw Patynowski Rob Herring Sabrina Dubroca Simon Horman Slark Xiao Subbaraya Sundeep Sunil Goutham Sylwester Dziedziuch syzbot Taehee Yoo Tetsuo Handa Toke Høiland-Jørgensen Tony Nguyen Vadim Fedorenko Vladimir Oltean Wei Wang Xin Long Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 broken test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 broken broken-step test-amd64-amd64-xl-qemut-debianhvm-amd64 host-install(5) Not pushing. (No revision log; it would be 1750 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 06:48:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 06:48:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377346.610511 (Exim 4.92) (envelope-from ) id 1oHJnc-0000Hv-VJ; Fri, 29 Jul 2022 06:48:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377346.610511; Fri, 29 Jul 2022 06:48:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJnc-0000Ho-Rx; Fri, 29 Jul 2022 06:48:40 +0000 Received: by outflank-mailman (input) for mailman id 377346; Fri, 29 Jul 2022 06:48:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHJnb-0000Hi-NJ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 06:48:39 +0000 Received: from mx0b-0039f301.pphosted.com (mx0b-0039f301.pphosted.com [148.163.137.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 786387e6-0f0a-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 08:48:37 +0200 (CEST) Received: from pps.filterd (m0174681.ppops.net [127.0.0.1]) by mx0b-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26T692ah018712; Fri, 29 Jul 2022 06:48:35 GMT Received: from eur05-db8-obe.outbound.protection.outlook.com (mail-db8eur05lp2112.outbound.protection.outlook.com [104.47.17.112]) by mx0b-0039f301.pphosted.com (PPS) with ESMTPS id 3hkq0a3smf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jul 2022 06:48:35 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by AS8PR03MB7144.eurprd03.prod.outlook.com (2603:10a6:20b:29e::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.24; Fri, 29 Jul 2022 06:48:32 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5482.012; Fri, 29 Jul 2022 06:48:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 786387e6-0f0a-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DTSqnE1MZcgRYK1Hfh32oN+sn+C+XR82yv0wPhgN0B05xdovLFvodoi1rK+zJKvtVyYCGp3ndH57l2oyPaLVzdixciI+6F6A51zBt4oQ+lUpyOtir0mBh7NO/mi/6Z/9mfIu1SzsQ5gDsHLyJ/CqJrKTqODSZfKV+DgWvxqY177lpdb90tBGnWt/oMKEgI/KOVFNnH3QGDm0YARpksWqNnP2b0c3a/+Me4Athjt6JR/G+l85V3lA4FfXqdFRZsnQIjfqufH0jM7/opcQ9wZ2jvwM3nTZ1+DODgpFYax4sPtg3qNaOikHgEe5EtEvKonMxboMqDcveYPnvUOZuBnWJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bQG63NbUZMxg54YI6k1WTOZt0BWpnfhYnxbbuu2xjOs=; b=ZQkcyDtNoHz9sqsi+SvQx/y4d/Krvmucv7gx4aaZHwm6gib++JhyrDiDSk1eznybA6722iNFWjdAFzDF2TPBKVwd3xpoGO49x9pswG9u0Dj41WqhT5+b/MxZE3pr+jhD7PrWIl/2B34Un0mnoT1m4Mcq2UZMf+d9WL1y1a8mpRDuDUNXg1A4ddoJ+XRindyrz2niFjbOlSzVMUFts4EZ9mcuApn59FtfCqXDv+/rnccfP4nEQiQAcZhzrbviOkQReAU6GU5bqaoa9SJFCKSGTBGkJruoJOFpM/hH4G40A92oA+8hlNbFqTTW5wIYZY01lV9xSJKEcmmCYJsK4l4llg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bQG63NbUZMxg54YI6k1WTOZt0BWpnfhYnxbbuu2xjOs=; b=aPpW82vkS6xjSNuLjzZAm3QixjZf07GdAcOVnzSUFBAjFAZYENX0QyQXKnRu/IIqFZP89+i8dmHi3Mv2HxpakCfUzdwrNvsnY0G3zUk2RAnbV2KTb3zP1qAd2cjkVWpF4D61gX9TWrJjU2p3rOkHbaM/GcSgsHDwsSVTbTlcTl5Mek5Jie1AX02fXgvCBaHdwItFemlcABd60OXGdpOtwyh80aQB/BNzdTnnaa8D492n7AxexG5AB/3MelWYVOjA9xIN6EHXVK9qb6/pBBkkAld/Ve4gwwOZ5DaW8g9g9jkkLrP2GGTx9ObZZtcXnRS6Xyln54cEEgqS+XA6vviJ2g== From: Oleksandr Tyshchenko To: Jan Beulich CC: osstest service owner , "xen-devel@lists.xenproject.org" , Julien Grall Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Topic: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Index: AQHYoxOqDyECYNTY4EqwTkq/MCO2na2U6EAA Date: Fri, 29 Jul 2022 06:48:32 +0000 Message-ID: <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> In-Reply-To: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 54460bb3-04fe-415b-605a-08da712e5a49 x-ms-traffictypediagnostic: AS8PR03MB7144:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: l6q3t3l7x+wS1En3eDR8koELgVgUc81Ar8uSY/eYjmimta7DAkKrmx9EKHkKbgO4Q2oprY6fwmbVztpBiGzvfqSerrYxF7y7V0Ut22zLPYHyLJ1+0eSvoEShtPpmhe8ZjrUfLwQqm0kSskaKQ0rG6oBLvIDfEstNeHkeU+xoAhBHtTqJ1z6jSIGaZdq+Gz3SZEW2Z4O/65FFQawb+1G8ukxrkvkfCezAKKWz1p5osDwLV4kqd5lMG+Jiq3nLA7OoNDop/tAi1ygkuo/OARVOlYeexFTs1C5Cj2p4ErshDwaDBdEiIxXJxY9DIysfcFk3pVj2J4O+xo/oCB6my0cSPBiimMhBXRnNKn8JFcpuiO+FvDCs9ahIi+A6eeiAzNX0FdX1Y4RWv39wl/OjrloV3yfVJZbN4khM9ZPBvFqufSmkvYhBw0lkzc3Kgk4ovjkSkpekpptGa5WYvCHtPRnIQgKfN6Rv4HP9j2kFveR02NgLgJ0p1IqMvPgM/iinb8EzYtntFG04pczfzQ4orfpj/8vcQyO3L4Ae0ZItoVqnaY5Cbe2eARYRfJFBKcf9PThvGJ4U6iOyySBNk3Lsb0b51QRohCyjH+drw1Bt2OXn7vwWDJvBre2Bpiqfn3Qk1tYwJGV8jOuGWoToBMe/hwEcTYUbGdCue9zDi08/YFd5m9PDydkJajlIFEhekpuBD9hHqIZChbEwKHS/reNxFQaWQsk4vv0R2D0b1DgbaCecq22k1B5svEGBEQQHYaAJmrpSu2PgBamYFJc5xw+H6AlShnI/d9OPO0AX1AFsuDMu9vGqVbNLkInijB/DQrKm0WV/svb8l8CcenHaIzq1LOyHBTw74KKWMtm8dGtUGtBhFHM= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(346002)(39860400002)(396003)(366004)(136003)(376002)(38070700005)(5660300002)(8936002)(38100700002)(122000001)(316002)(6512007)(2616005)(6916009)(54906003)(966005)(71200400001)(478600001)(41300700001)(53546011)(55236004)(6506007)(6486002)(26005)(4326008)(8676002)(66446008)(64756008)(66476007)(83380400001)(186003)(31686004)(66946007)(66556008)(76116006)(91956017)(2906002)(86362001)(31696002)(36756003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?aXN5VktuU0F3YXlCblhJcDBrSC9lbVNMYzREOTA4bldpellLV1ZOellId2NX?= =?utf-8?B?MFlhaFRzeHo0RXU2SjJKVGVNTTZIQ2FJc0NMdC8xamhWeXYyb0YyN1FDSnNo?= =?utf-8?B?SGV0RmlkMERWdmI5YXROcHQ0bDhWdjJmT2JuS2RMSGM3b292NEQvbVpjWnJp?= =?utf-8?B?Zlh6eVVMZmx2VjBleWo5SVFiNGhZK0hWWC9EQkVESVgyUmJjTS9wZ0FIMXJW?= =?utf-8?B?NWRNV2JTb1A1RjFzWnE2QXo1MGFLZ3A0TVFsZ0hBNjY3RjRUUmRJNXlvbFRy?= =?utf-8?B?aHVQRzJISzNQejZYVEZZV3hnV1VOblVyeStTSHBhU01mQStpaGZsbjhzdHpN?= =?utf-8?B?U2lhV1d5bFRWVG1UR1ViY3JzTGREYUZRZFF0TncrRWdpQmZnRFRSbW14L1Br?= =?utf-8?B?L1lvRXI1RDJIZHhGbjEzQkpWdlJaeW1zZ1diTTRlRThUd0VDK3R0b2tUeWVM?= =?utf-8?B?S1B3b0Vic2thNHNhWW5RMGVyWlgrWDEwallua3dTNGNYWVBnWC9jemZZZitk?= =?utf-8?B?ekhxbEFDdlI4U0cxVU9yVyttUTVja2tCaGw5K2VoOXd0L244ZHlFek9Ea0Jp?= =?utf-8?B?K0VQQ1IyYmUrWkFGZGs1QzVNM01MdmpMbHg1SmQ2Wmx6MWZnRlpDVEl1VHpI?= =?utf-8?B?RytXQ095QTllUGVkRGlWQnFTYnNDQjVEZGhPbVlTNU4zNXhoUmFMeTljK0RO?= =?utf-8?B?NW4xZ1ZjS2dWa3lhbkF6UlUreHhXS0kvNWoxbnFKbnpmWnJrTzVvYWl5UFVR?= =?utf-8?B?WkRxbWpHWDNQVk1tUjRRbi9xQ3ptOFVGV1MzYVlBNFhVTVlnd2h0UVVDK2l5?= =?utf-8?B?azU0dmNmdXlUUUExOEpNNnhTSnBFUWdjNDJoNUlwRCtXbFJKTzVxQUkzSjNH?= =?utf-8?B?ZCtpVGZxbzUrbGZKeTFiM0Y0WHFBK3IxZDZ4cUtrRnN4aTZyRlBNZUlQOWJs?= =?utf-8?B?dFYrWWgzQ2F0R0tXMUVYT1N2VmszZlJZRWZrSHBBaHpaVVJCNnFYSmE3ZWJB?= =?utf-8?B?NjcxcFJrZzhveUNvZ1pSMmJiODRDYnNqU2hPT041MEM3MUNDRmpNblQ1d2lG?= =?utf-8?B?OER5enRodVpkQXI2dERRQUZ4eDZWUmNsbElyRlpEYnZ2eTl5bFZTS2lLRCsx?= =?utf-8?B?SVQ2RmZzYWltVjg4ZURCR0JMeEl4d2U4V1BFTjYzR0xPWTBaL1lLVmpWRkN5?= =?utf-8?B?REZuRnZtREd2dEtacUQzcWdYY0wwdm8yK2s0b3ZnWkhFYXZYVXZTZ2NlT1p5?= =?utf-8?B?aEwyaTFVTDErNTNPdjhQc2ZXOFBrUElxOUkySWhINkFsTXN6SGxES20vTG1l?= =?utf-8?B?QWlCcWVMQ3hPbncxaUxtbXF1d3J5K0dnOXlDYzdNM3Z1T09zWGVGaWRZQy9X?= =?utf-8?B?cFRLYlNLMm9jbXhrY09SeFZuZlZZaGhBeVBaNWEyZE1EZlZEYVQyOWxJYUxG?= =?utf-8?B?bTFmcUtobkpVbmRLeEVua3k0OTdEK0Ric2pWZkxvS0o4dDVwVkR2czFnNno5?= =?utf-8?B?Z1UwSjBuM2pNWFNFamRUSlptUkVxOFJZMlVlZDlOZHMyTThFWkxHTVJzNEYv?= =?utf-8?B?TFpzZnJsSWpBUi9NWFBIai80SzBKMm1GVWxCWVgxUmlEWkVCVVZCdlpQblZH?= =?utf-8?B?VUt2dUlHRmNJRkJ6ZXlaYTc3eHIxY3VSUGlvYzU0VDNlL0dRUTFaSisxa3RK?= =?utf-8?B?RXBWYy9zOEFxUHI1czVqMXZic1JHZWJFeU9McUlkU3NnaU55R3hnSlBnUWVp?= =?utf-8?B?RlhyamxZbkY4SEFkdFo1eThaVDQ1bnEyUnlMY1NOYU1sWEU1YzRuMVUvNVZZ?= =?utf-8?B?cVo3RktPL2V3QUs2d09oOXcwKy93L0syemQyTDJPWTgvdlJPMG11MVRISTVN?= =?utf-8?B?Q21sekNNWTYyc2o3bjdlSXhIZU84aGxkT0lHTUprNlpnTllmRVFDcEVLWnFC?= =?utf-8?B?TXhvdFlyaDhCdkQyVk9pT2ZUcWtMWmRNaDNxdzVvcWdFbVZOajZqcXZiK2Ns?= =?utf-8?B?d1BmY216WFpYSVMxaWJJSkRiMXF1d1R4d1BYNUw3TjlzdDl1dWxLN2J0WC8y?= =?utf-8?B?d0NLMFpGdkRlQ0JZczhwVmV3SDB5SlkwMSszd3pWeDQwbXBLUk1nNjM2bkc1?= =?utf-8?B?eWJRUWU5Z3hMZ3RVU2RDTGx1VmtiZHllK0FtdURJZkU5d2c1RkEvYXZiVkpp?= =?utf-8?Q?n3coU49G8SKzdmHkfrpZ7/A=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: <85C990319C494F4883C15137ABA9E6B6@eurprd03.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 54460bb3-04fe-415b-605a-08da712e5a49 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 06:48:32.3070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: irwf4A1yGGyt+HfBHOEeS34hNEUmd1JzskKqfX1p8Ze31tvJiLwybxya6OZVUfCTRuPYAbNEakPWUPHYf4LpmTbdkH1QS/AwIyKEoKVMNKo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR03MB7144 X-Proofpoint-GUID: 36CsE0idVEqEYuMHFQxTsGxOzJ_ipX62 X-Proofpoint-ORIG-GUID: 36CsE0idVEqEYuMHFQxTsGxOzJ_ipX62 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1011 mlxscore=0 bulkscore=0 spamscore=0 priorityscore=1501 mlxlogscore=805 lowpriorityscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207290028 DQpPbiAyOS4wNy4yMiAwOToyMiwgSmFuIEJldWxpY2ggd3JvdGU6DQoNCkhlbGxvIEphbg0KDQo+ IE9uIDI5LjA3LjIwMjIgMDM6MDQsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4+IGJy YW5jaCB4ZW4tdW5zdGFibGUtc21va2UNCj4+IHhlbmJyYW5jaCB4ZW4tdW5zdGFibGUtc21va2UN Cj4+IGpvYiBidWlsZC1hbWQ2NC1saWJ2aXJ0DQo+PiB0ZXN0aWQgbGlidmlydC1idWlsZA0KPj4N Cj4+IFRyZWU6IGxpYnZpcnQgZ2l0Oi8veGVuYml0cy54ZW4ub3JnL2xpYnZpcnQuZ2l0DQo+PiBU cmVlOiBsaWJ2aXJ0X2tleWNvZGVtYXBkYiBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0 cHM6Ly9naXRsYWIuY29tL2tleWNvZGVtYXAva2V5Y29kZW1hcGRiLmdpdF9fOyEhR0ZfMjlkYmNR SVVCUEEhMHNfbnlBZ2RzOTc3ZHcwZEdQZ0ZKR2tJYUJpS2lYSDNuUjExTmk2Z0dqTjVnUW1CMERF aEtybTVTVVg0UjBXaEs4WWtRZW1SNlJWaGlvanB6aWo5eUxNJCBbZ2l0bGFiWy5dY29tXQ0KPj4g VHJlZTogcWVtdSBnaXQ6Ly94ZW5iaXRzLnhlbi5vcmcvcWVtdS14ZW4tdHJhZGl0aW9uYWwuZ2l0 DQo+PiBUcmVlOiBxZW11dSBnaXQ6Ly94ZW5iaXRzLnhlbi5vcmcvcWVtdS14ZW4uZ2l0DQo+PiBU cmVlOiB4ZW4gZ2l0Oi8veGVuYml0cy54ZW4ub3JnL3hlbi5naXQNCj4+DQo+PiAqKiogRm91bmQg YW5kIHJlcHJvZHVjZWQgcHJvYmxlbSBjaGFuZ2VzZXQgKioqDQo+Pg0KPj4gICAgQnVnIGlzIGlu IHRyZWU6ICB4ZW4gZ2l0Oi8veGVuYml0cy54ZW4ub3JnL3hlbi5naXQNCj4+ICAgIEJ1ZyBpbnRy b2R1Y2VkOiAgNjZkZDFjNjJiMmEzYzcwN2JkNWM1NTc1MGQxMGE4MjIzZmJkNTc3Zg0KPj4gICAg QnVnIG5vdCBwcmVzZW50OiBmNzMyMjQwZmQzYmFjMjUxMTYxNTFkYjVkZGViNzIwM2I2MmU4NWNl DQo+PiAgICBMYXN0IGZhaWwgcmVwcm86IGh0dHBzOi8vdXJsZGVmZW5zZS5jb20vdjMvX19odHRw Oi8vbG9ncy50ZXN0LWxhYi54ZW5wcm9qZWN0Lm9yZy9vc3N0ZXN0L2xvZ3MvMTcxOTA5L19fOyEh R0ZfMjlkYmNRSVVCUEEhMHNfbnlBZ2RzOTc3ZHcwZEdQZ0ZKR2tJYUJpS2lYSDNuUjExTmk2Z0dq TjVnUW1CMERFaEtybTVTVVg0UjBXaEs4WWtRZW1SNlJWaGlvanBtWUFCSmtjJCBbbG9nc1suXXRl c3QtbGFiWy5deGVucHJvamVjdFsuXW9yZ10NCj4+DQo+Pg0KPj4gICAgY29tbWl0IDY2ZGQxYzYy YjJhM2M3MDdiZDVjNTU3NTBkMTBhODIyM2ZiZDU3N2YNCj4+ICAgIEF1dGhvcjogT2xla3NhbmRy IFR5c2hjaGVua28gPG9sZWtzYW5kcl90eXNoY2hlbmtvQGVwYW0uY29tPg0KPj4gICAgRGF0ZTog ICBGcmkgSnVsIDE1IDIyOjIwOjI0IDIwMjIgKzAzMDANCj4+ICAgIA0KPj4gICAgICAgIGxpYnhs OiBBZGQgc3VwcG9ydCBmb3IgVmlydGlvIGRpc2sgY29uZmlndXJhdGlvbg0KPiBKdXN0IGluIGNh c2UgeW91IGRpZG4ndCBub3RpY2UgaXQ6IFNvbWV0aGluZydzIHdyb25nIGhlcmUuIEkgZGlkbid0 IGxvb2sNCj4gYXQgdGhlIGRldGFpbHMgYXQgYWxsLiBQbGVhc2UgYWR2aXNlIHdoZXRoZXIgYSBm aXggd2lsbCBzb29uIGFycml2ZSBvcg0KPiB3aGV0aGVyIHdlIHNob3VsZCByZXZlcnQgZm9yIHRo ZSB0aW1lIGJlaW5nLg0KDQpTb3JyeSBmb3IgdGhlIGJyZWFrYWdlLiBBdCB0aGUgbW9tZW50IEkg aGF2ZSBubyBpZGVhIHdoYXQgaXMgd3JvbmcgaGVyZSwNCg0KSSB3aWxsIHRyeSB0byBpbnZlc3Rp Z2F0ZSBhbmQgcHJvdmlkZSBhIGZpeCBieSB0aGUgZW5kIG9mIHRoZSBkYXkuDQoNCg0KPg0KPiBK YW4NCg0KLS0gDQpSZWdhcmRzLA0KDQpPbGVrc2FuZHIgVHlzaGNoZW5rbw0K From xen-devel-bounces@lists.xenproject.org Fri Jul 29 07:02:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 07:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377359.610546 (Exim 4.92) (envelope-from ) id 1oHK0S-00036N-BO; Fri, 29 Jul 2022 07:01:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377359.610546; Fri, 29 Jul 2022 07:01:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHK0S-00036G-8D; Fri, 29 Jul 2022 07:01:56 +0000 Received: by outflank-mailman (input) for mailman id 377359; Fri, 29 Jul 2022 07:01:54 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHK0Q-00036A-EH for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 07:01:54 +0000 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [2a00:1450:4864:20::62d]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 537f00ca-0f0c-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 09:01:53 +0200 (CEST) Received: by mail-ej1-x62d.google.com with SMTP id fy29so6894909ejc.12 for ; Fri, 29 Jul 2022 00:01:53 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id v23-20020a1709062f1700b0072ff4515792sm1309698eji.54.2022.07.29.00.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 00:01:51 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 537f00ca-0f0c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=IJjFAZu2ir9Pr1gOKiYaW7TEd/Xm4SJX6gQhG2aRDrg=; b=eRwJc26zfMzo75iGLND9jLccQudHEKCkaYjgwWJaVRjCuHo0ivqm5D1gDEtIkxUAMK p71wqXBfc7CArVk4q/kvneeVGpYnjsCnj1Kfa9rWFTUX7lvZkBkJfvVFWaWVzzupk6OS OuLkSjNNHo274tbTYH1mRTmUFlNLX400/l80qZtfC8eqeSF9NJ7EdywCQr1t/hJblzQh bMa6WqrBaypfDuS4w/ofoWy/AqeMqNC80W4RmR12K3FAb3GhQA5pm3Tk8sYVLxWnPl6e dIdPOtR9tc+zKVyBXW8/exRmbctwJB7DQGUKiRun3Z4Er+eCSXiIz9c/bFNKIJ0qDQv+ IhRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=IJjFAZu2ir9Pr1gOKiYaW7TEd/Xm4SJX6gQhG2aRDrg=; b=4kjqjlSV7XrCJ59eOGRVmLP7v14CBD2N/YruanHjLdO8p1bFkIbDiLVpGgkv1aCgdB IfwmK044J5nhz6N0xfGIjTfTeXcvfeTEl0IU1yRyI8JvAfA35bP0FqIny5AaiqXlrqOq ORVDl5wGHLoUGkBc6oBUS02QwohIWOXGq0j0WQWVtG0vNq8uBwUUoYmSy6rFwZw/KPKT L3Q2Vn2ftpx79ElF++8D0SYLCP6YgT7Rd+642OBHeO04UnQn/TuA+UtZP0/+w8joULzI /okRrk/KA44m/GS97Xg7jZQnAp1Ti0lLgOMReLTnyrfAbq0d2CG+7XtJElyJfID2N7Nk ywUQ== X-Gm-Message-State: AJIora/Q4vqteKvO6ZRBR9UX8NIsmFlOgSPWSG862AxvNADC7OsB4aYR N9UkKdWjoBGPDv6VoqWYyEM= X-Google-Smtp-Source: AGRyM1uzpnBXB7Gh4YU/mstWj17/bWxDibgLFX29Q5NxqTyJi7ZnvacRxl/VNjS7Hm57I6p4WPOk5w== X-Received: by 2002:a17:907:6da9:b0:72b:58ca:e3a8 with SMTP id sb41-20020a1709076da900b0072b58cae3a8mr1895847ejc.342.1659078112392; Fri, 29 Jul 2022 00:01:52 -0700 (PDT) Message-ID: <69942917-f2e9-718e-094d-9b01aea16a4a@gmail.com> Date: Fri, 29 Jul 2022 10:01:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich Cc: Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini , Julien Grall References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 7/29/22 09:16, Jan Beulich wrote: > On 29.07.2022 07:23, Xenia Ragiadakou wrote: >> Hi Stefano, >> >> On 7/29/22 01:56, Stefano Stabellini wrote: >>> On Thu, 28 Jul 2022, Julien Grall wrote: >>>> On 28/07/2022 15:20, Jan Beulich wrote: >>>>> On 28.07.2022 15:56, Julien Grall wrote: >>>>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>> @@ -461,7 +461,7 @@ >>>>>>> /* Access to system registers */ >>>>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>>>> - uint64_t _r = v; \ >>>>>>> + uint64_t _r = (v); \ >>>>>> >>>>>> I am failing to see why the parentheses are necessary here. Could you >>>>>> give an example where the lack of them would end up to different code? >>>>> >>>>> I think it is merely good practice to parenthesize the right sides of =. >>>>> Indeed with assignment operators having second to lowest precedence, and >>>>> with comma (the lowest precedence one) requiring parenthesization at the >>>>> macro invocation site, there should be no real need for parentheses here. >>>> >>>> I am not really happy with adding those parentheses because they are >>>> pointless. But if there are a consensus to use it, then the commit message >>>> should be updated to clarify this is just here to please MISRA (to me "need" >>>> implies it would be bug). >>> >>> Let me premise that I don't know if this counts as a MISRA violation or >>> not. (Also I haven't checked if cppcheck/eclair report it as violation.) >>> >>> But I think the reason for making the change would be to follow our >>> coding style / coding practices. It makes the code simpler to figure out >>> that it is correct, to review and maintain if we always add the >>> parenthesis even in cases like this one where they are not strictly >>> necessary. We are going to save our future selves some mental cycles. >>> >>> So the explanation on the commit message could be along those lines. >> >> First, the rule 20.7 states "Expressions resulting from the expansion of >> macro parameters shall >> be enclosed in parentheses". So, here it is a clear violation of the >> rule because the right side of the assignment operator is an expression. >> >> Second, as I stated in a previous email, if v is not enclosed in >> parentheses, I could write the story of my life in there and compile it >> :) So, it would be a bug. >> >> So, I recommend the title and the explanation i.e >> "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation >> >> The macro parameter 'v' is used as an expression and needs to be enclosed in >> parentheses." >> to remain as is because they are accurate. > > I'm afraid you're following the MISRA wording too much to the latter. > Earlier on you agreed that when macro parameters are used as function > arguments, the parentheses can be omitted. Yet by what you say above > those are also expressions. Yes, those are also expressions (that's why I added parentheses initially) and I agreed with you that the parentheses there may not be necessary because I could not think of an example that will produce different behaviors with and without the parentheses. This will need a formal deviation I imagine or maybe a MISRA C expert could provide a justification regarding why parentheses are needed around function arguments that we may have not think of. > As indicated before - I think parentheses > are wanted here, but it's strictly "wanted", and hence the title > better wouldn't say "fix" (but e.g. "improve") and the description > also should be "softened". > Regarding the latter, are you saying that the parentheses are not needed? In my opinion they are needed to prevent the bug described in the previous email i.e passing multiple statements to the macro. By whom are they wanted? I 'm afraid I cannot understand. Also, are you proposing to change the title into "Improve MISRA C 2012 Rule 20.7 violation" ? -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 07:04:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 07:04:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377364.610557 (Exim 4.92) (envelope-from ) id 1oHK3B-0003gi-RL; Fri, 29 Jul 2022 07:04:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377364.610557; Fri, 29 Jul 2022 07:04:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHK3B-0003gb-NZ; Fri, 29 Jul 2022 07:04:45 +0000 Received: by outflank-mailman (input) for mailman id 377364; Fri, 29 Jul 2022 07:04:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHK3A-0003gV-Q1 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 07:04:44 +0000 Received: from esa5.hc3370-68.iphmx.com (esa5.hc3370-68.iphmx.com [216.71.155.168]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b75c532a-0f0c-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 09:04:42 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b75c532a-0f0c-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659078282; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Jq4vj1RzUhUFD8chOtnp1zUxZquW4wk6DMoEc5oQx0w=; b=QkF/O9WJDxmaNvXPDtaKLBgrK540E2Ed17Hecqctc7tEiFUZu7dc4k7D EL0z3v+hXsodugYnWFpAMj8PVPcanwcKlZH0BKV7rjZaIiRN+dknqXB+i +74Ec/1xWh6+8dOpT8sP8EwWGMKtMpB9qP38t4fZ29YxOXQq0AAzUQ8I8 A=; Authentication-Results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76181499 X-Ironport-Server: esa5.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ki9Ej6rdfjn3IQcXgiWvvWXVZnFeBmJ+YhIvgKrLsJaIsI4StFCzt garIBmFM/mINmLwf9h/aIW08kIFucXTmNVgSFFk/y5kFyMW9JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lJ5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUk5/RbHXMTt scUKQBTQCuoqsjrm6mkH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn81AZQz2sKhgnD7ejtVgFmUubA28y7YywkZPL3Fb4SMKoXWFJQ9ckCwq kH+707kAQsgO+OdzH2Y1mqvn/bGknauMG4VPOLhraM76LGJ/UQUDBAVTlK9reOOll+lW9lfJ koX/QIjtaE3skesS7HVRAakqXSJuhodXdt4EOAg7gyJjK3O7G6xFjhaZj1MctorsIkxXzNC/ l2GhdTyHhR0raaYD3ma89+8vT60fCQYM2IGTSsFVhcepcnuppkpiRDCRcolF7S65vXwGTzhx T2ipS03lbIVy8IGv425913ahzOnprDSUxU4oA7QWwqN8gx9dKahZoq19ULc6/dQaoqUJnGLu 2IFgI6Z9/wUCo+Wlz2lR/8EF7Wkof2CNVX0hV9pAolk9Dm3/XOnVZ5f7Ss4J0pzNMsAPzjzb yf7vAJX65h7JnambaZrJYm2DqwCzbDpPcb0SvfOKNFJZ/BZeAaZ8WdubEiL0mbFlEkqjLF5O JGHfMLqBnEfYYxt1BK/Q+YQ1+9tyi1W+I/IbcmllVL9i+PYPSPLD+deWLeTUgwnxJ+ZsinJ4 YscDMeL+0txa8bTSHSM6pFGeDjmMkMH6YDKR91/L7Dec1I7STx5Wpc90pt6JdU7wv09evPgu yjkBxQGkAeXaWjvc13iV5x1VF/4sX+TR1ofNDdkA1un0mNLjW2HvPZGLMtfkVXKGYVeIR9Io xotIZzo7gxnEGivxtjkRcCVQHZeXBqqnxmSGCGufSIyeZVtLySQpIK1JlC0r3lSUXDo3Sfbn 1FH/lqBKafvuiw4VJqGAB5R5wjZUYchdBJaABKTf4g7lLTE+4l2MS3h5sIKzzU3AUyanlOyi lfJaSr0UMGX/OfZBvGV2v3fx2poesMidndn857ztOvvaneGpDb5nOetko+gJFjgaY89w436D c098h02GKdvcIpi22akL4tW8A== IronPort-HdrOrdr: A9a23:/Mq4x64O5NXyLOROZQPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.93,200,1654574400"; d="scan'208";a="76181499" From: Jane Malalane To: LKML CC: Jane Malalane , Juergen Gross , Boris Ostrovsky , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , , "H. Peter Anvin" , Stefano Stabellini , Oleksandr Tyshchenko , Jan Beulich , "Maximilian Heyne" , Subject: [PATCH v4] x86/xen: Add support for HVMOP_set_evtchn_upcall_vector Date: Fri, 29 Jul 2022 08:04:16 +0100 Message-ID: <20220729070416.23306-1-jane.malalane@citrix.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Implement support for the HVMOP_set_evtchn_upcall_vector hypercall in order to set the per-vCPU event channel vector callback on Linux and use it in preference of HVM_PARAM_CALLBACK_IRQ. If the per-VCPU vector setup is successful on BSP, use this method for the APs. If not, fallback to the global vector-type callback. Also register callback_irq at per-vCPU event channel setup to trick toolstack to think the domain is enlightened. Suggested-by: "Roger Pau Monné" Signed-off-by: Jane Malalane Reviewed-by: Boris Ostrovsky --- CC: Juergen Gross CC: Boris Ostrovsky CC: Thomas Gleixner CC: Ingo Molnar CC: Borislav Petkov CC: Dave Hansen CC: x86@kernel.org CC: "H. Peter Anvin" CC: Stefano Stabellini CC: Oleksandr Tyshchenko CC: Jan Beulich CC: Maximilian Heyne CC: xen-devel@lists.xenproject.org v4: * amend code comment v3: * comment style * add comment on toolstack trick * remove unnecessary variable and function call * surround x86-specific code with #ifdef v2: * remove no_vector_callback * make xen_have_vector_callback a bool * rename xen_ack_upcall to xen_percpu_upcall * fail to bring CPU up on init instead of crashing kernel * add and use xen_set_upcall_vector where suitable * xen_setup_upcall_vector -> xen_init_setup_upcall_vector for clarity --- arch/x86/include/asm/xen/cpuid.h | 2 ++ arch/x86/include/asm/xen/events.h | 3 ++- arch/x86/xen/enlighten.c | 2 +- arch/x86/xen/enlighten_hvm.c | 24 ++++++++++++----- arch/x86/xen/suspend_hvm.c | 10 ++++++- drivers/xen/events/events_base.c | 53 +++++++++++++++++++++++++++++++++----- include/xen/hvm.h | 2 ++ include/xen/interface/hvm/hvm_op.h | 19 ++++++++++++++ 8 files changed, 100 insertions(+), 15 deletions(-) diff --git a/arch/x86/include/asm/xen/cpuid.h b/arch/x86/include/asm/xen/cpuid.h index 78e667a31d6c..6daa9b0c8d11 100644 --- a/arch/x86/include/asm/xen/cpuid.h +++ b/arch/x86/include/asm/xen/cpuid.h @@ -107,6 +107,8 @@ * ID field from 8 to 15 bits, allowing to target APIC IDs up 32768. */ #define XEN_HVM_CPUID_EXT_DEST_ID (1u << 5) +/* Per-vCPU event channel upcalls */ +#define XEN_HVM_CPUID_UPCALL_VECTOR (1u << 6) /* * Leaf 6 (0x40000x05) diff --git a/arch/x86/include/asm/xen/events.h b/arch/x86/include/asm/xen/events.h index 068d9b067c83..62bdceb594f1 100644 --- a/arch/x86/include/asm/xen/events.h +++ b/arch/x86/include/asm/xen/events.h @@ -23,7 +23,7 @@ static inline int xen_irqs_disabled(struct pt_regs *regs) /* No need for a barrier -- XCHG is a barrier on x86. */ #define xchg_xen_ulong(ptr, val) xchg((ptr), (val)) -extern int xen_have_vector_callback; +extern bool xen_have_vector_callback; /* * Events delivered via platform PCI interrupts are always @@ -34,4 +34,5 @@ static inline bool xen_support_evtchn_rebind(void) return (!xen_hvm_domain() || xen_have_vector_callback); } +extern bool xen_percpu_upcall; #endif /* _ASM_X86_XEN_EVENTS_H */ diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 30c6e986a6cd..b8db2148c07d 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen/enlighten.c @@ -51,7 +51,7 @@ EXPORT_SYMBOL_GPL(xen_start_info); struct shared_info xen_dummy_shared_info; -__read_mostly int xen_have_vector_callback; +__read_mostly bool xen_have_vector_callback = true; EXPORT_SYMBOL_GPL(xen_have_vector_callback); /* diff --git a/arch/x86/xen/enlighten_hvm.c b/arch/x86/xen/enlighten_hvm.c index 8b71b1dd7639..198d3cd3e9a5 100644 --- a/arch/x86/xen/enlighten_hvm.c +++ b/arch/x86/xen/enlighten_hvm.c @@ -7,6 +7,8 @@ #include #include +#include +#include #include #include @@ -30,6 +32,9 @@ static unsigned long shared_info_pfn; +__ro_after_init bool xen_percpu_upcall; +EXPORT_SYMBOL_GPL(xen_percpu_upcall); + void xen_hvm_init_shared_info(void) { struct xen_add_to_physmap xatp; @@ -125,6 +130,9 @@ DEFINE_IDTENTRY_SYSVEC(sysvec_xen_hvm_callback) { struct pt_regs *old_regs = set_irq_regs(regs); + if (xen_percpu_upcall) + ack_APIC_irq(); + inc_irq_stat(irq_hv_callback_count); xen_hvm_evtchn_do_upcall(); @@ -168,6 +176,15 @@ static int xen_cpu_up_prepare_hvm(unsigned int cpu) if (!xen_have_vector_callback) return 0; + if (xen_percpu_upcall) { + rc = xen_set_upcall_vector(cpu); + if (rc) { + WARN(1, "HVMOP_set_evtchn_upcall_vector" + " for CPU %d failed: %d\n", cpu, rc); + return rc; + } + } + if (xen_feature(XENFEAT_hvm_safe_pvclock)) xen_setup_timer(cpu); @@ -188,8 +205,6 @@ static int xen_cpu_dead_hvm(unsigned int cpu) return 0; } -static bool no_vector_callback __initdata; - static void __init xen_hvm_guest_init(void) { if (xen_pv_domain()) @@ -211,9 +226,6 @@ static void __init xen_hvm_guest_init(void) xen_panic_handler_init(); - if (!no_vector_callback && xen_feature(XENFEAT_hvm_callback_vector)) - xen_have_vector_callback = 1; - xen_hvm_smp_init(); WARN_ON(xen_cpuhp_setup(xen_cpu_up_prepare_hvm, xen_cpu_dead_hvm)); xen_unplug_emulated_devices(); @@ -239,7 +251,7 @@ early_param("xen_nopv", xen_parse_nopv); static __init int xen_parse_no_vector_callback(char *arg) { - no_vector_callback = true; + xen_have_vector_callback = false; return 0; } early_param("xen_no_vector_callback", xen_parse_no_vector_callback); diff --git a/arch/x86/xen/suspend_hvm.c b/arch/x86/xen/suspend_hvm.c index 9d548b0c772f..0c4f7554b7cc 100644 --- a/arch/x86/xen/suspend_hvm.c +++ b/arch/x86/xen/suspend_hvm.c @@ -5,6 +5,7 @@ #include #include #include +#include #include "xen-ops.h" @@ -14,6 +15,13 @@ void xen_hvm_post_suspend(int suspend_cancelled) xen_hvm_init_shared_info(); xen_vcpu_restore(); } - xen_setup_callback_vector(); + if (xen_percpu_upcall) { + unsigned int cpu; + + for_each_online_cpu(cpu) + BUG_ON(xen_set_upcall_vector(cpu)); + } else { + xen_setup_callback_vector(); + } xen_unplug_emulated_devices(); } diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index 46d9295d9a6e..206d4b466e44 100644 --- a/drivers/xen/events/events_base.c +++ b/drivers/xen/events/events_base.c @@ -45,6 +45,7 @@ #include #include #include +#include #include #endif #include @@ -2183,6 +2184,7 @@ static struct irq_chip xen_percpu_chip __read_mostly = { .irq_ack = ack_dynirq, }; +#ifdef CONFIG_X86 #ifdef CONFIG_XEN_PVHVM /* Vector callbacks are better than PCI interrupts to receive event * channel notifications because we can receive vector callbacks on any @@ -2195,11 +2197,48 @@ void xen_setup_callback_vector(void) callback_via = HVM_CALLBACK_VECTOR(HYPERVISOR_CALLBACK_VECTOR); if (xen_set_callback_via(callback_via)) { pr_err("Request for Xen HVM callback vector failed\n"); - xen_have_vector_callback = 0; + xen_have_vector_callback = false; } } } +/* + * Setup per-vCPU vector-type callbacks. If this setup is unavailable, + * fallback to the global vector-type callback. + */ +static __init void xen_init_setup_upcall_vector(void) +{ + if (!xen_have_vector_callback) + return; + + if ((cpuid_eax(xen_cpuid_base() + 4) & XEN_HVM_CPUID_UPCALL_VECTOR) && + !xen_set_upcall_vector(0)) + xen_percpu_upcall = true; + else if (xen_feature(XENFEAT_hvm_callback_vector)) + xen_setup_callback_vector(); + else + xen_have_vector_callback = false; +} + +int xen_set_upcall_vector(unsigned int cpu) +{ + int rc; + xen_hvm_evtchn_upcall_vector_t op = { + .vector = HYPERVISOR_CALLBACK_VECTOR, + .vcpu = per_cpu(xen_vcpu_id, cpu), + }; + + rc = HYPERVISOR_hvm_op(HVMOP_set_evtchn_upcall_vector, &op); + if (rc) + return rc; + + /* Trick toolstack to think we are enlightened. */ + if (!cpu) + rc = xen_set_callback_via(1); + + return rc; +} + static __init void xen_alloc_callback_vector(void) { if (!xen_have_vector_callback) @@ -2210,8 +2249,11 @@ static __init void xen_alloc_callback_vector(void) } #else void xen_setup_callback_vector(void) {} +static inline void xen_init_setup_upcall_vector(void) {} +int xen_set_upcall_vector(unsigned int cpu) {} static inline void xen_alloc_callback_vector(void) {} -#endif +#endif /* CONFIG_XEN_PVHVM */ +#endif /* CONFIG_X86 */ bool xen_fifo_events = true; module_param_named(fifo_events, xen_fifo_events, bool, 0); @@ -2271,10 +2313,9 @@ void __init xen_init_IRQ(void) if (xen_initial_domain()) pci_xen_initial_domain(); } - if (xen_feature(XENFEAT_hvm_callback_vector)) { - xen_setup_callback_vector(); - xen_alloc_callback_vector(); - } + xen_init_setup_upcall_vector(); + xen_alloc_callback_vector(); + if (xen_hvm_domain()) { native_init_IRQ(); diff --git a/include/xen/hvm.h b/include/xen/hvm.h index b7fd7fc9ad41..8da7a6747058 100644 --- a/include/xen/hvm.h +++ b/include/xen/hvm.h @@ -60,4 +60,6 @@ static inline int hvm_get_parameter(int idx, uint64_t *value) void xen_setup_callback_vector(void); +int xen_set_upcall_vector(unsigned int cpu); + #endif /* XEN_HVM_H__ */ diff --git a/include/xen/interface/hvm/hvm_op.h b/include/xen/interface/hvm/hvm_op.h index f3097e79bb03..03134bf3cec1 100644 --- a/include/xen/interface/hvm/hvm_op.h +++ b/include/xen/interface/hvm/hvm_op.h @@ -46,4 +46,23 @@ struct xen_hvm_get_mem_type { }; DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_get_mem_type); +#if defined(__i386__) || defined(__x86_64__) + +/* + * HVMOP_set_evtchn_upcall_vector: Set a that should be used for event + * channel upcalls on the specified . If set, + * this vector will be used in preference to the + * domain global callback via (see + * HVM_PARAM_CALLBACK_IRQ). + */ +#define HVMOP_set_evtchn_upcall_vector 23 +struct xen_hvm_evtchn_upcall_vector { + uint32_t vcpu; + uint8_t vector; +}; +typedef struct xen_hvm_evtchn_upcall_vector xen_hvm_evtchn_upcall_vector_t; +DEFINE_GUEST_HANDLE_STRUCT(xen_hvm_evtchn_upcall_vector_t); + +#endif /* defined(__i386__) || defined(__x86_64__) */ + #endif /* __XEN_PUBLIC_HVM_HVM_OP_H__ */ -- 2.11.0 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 07:23:04 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 07:23:04 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377376.610567 (Exim 4.92) (envelope-from ) id 1oHKKe-0006W4-FY; Fri, 29 Jul 2022 07:22:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377376.610567; Fri, 29 Jul 2022 07:22:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHKKe-0006Vx-Cs; Fri, 29 Jul 2022 07:22:48 +0000 Received: by outflank-mailman (input) for mailman id 377376; Fri, 29 Jul 2022 07:22:47 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHKKd-0006Vr-AR for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 07:22:47 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2065.outbound.protection.outlook.com [40.107.21.65]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3de6eab6-0f0f-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 09:22:46 +0200 (CEST) Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by DB6PR0401MB2373.eurprd04.prod.outlook.com (2603:10a6:4:4b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Fri, 29 Jul 2022 07:22:41 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::9da9:fa60:f04a:2a0e%7]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 07:22:41 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3de6eab6-0f0f-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wqg+gETwyaeDg7ara1MCghmL+XIWsoxgW1pKXa9mSpLO/2T2Y07RNRio9XQnlm3IsgHlS+rxVb0rjYYrAMeF7u5aC4R+gixVuHtp8sVfJT1kyIi8s89vejhqjWOy2b6qZCoE2VMQrhMvPYTyKsC66H5VE8AJppHDybzdyp2kStoKEDRPW1G/4oDs6mdzFg7E85qZNXukao0RbxxXKifThYi0A+6CAZV7qv8gu37yGFEVKIav9TlfcVdneQqQ4fAtfwVT/WeWt6gtPC29QRJW6RMpRXd+qafhE9072vW88xDGpVfGPYpzx2oK6v/cHmsSUHD+SO40x4BWO2KVKE1CFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BDMirb63e4mQrLrukOg1fWLmKm00xM0tUHidAUnE5X0=; b=HbN6q9hqF/tLLgBJnOFIgnHhdzOzGuL3dVGy4oLJu0o19Aw6wtdxpRuayko7C7uJmPxmRcWbtRPdBZR+XfVybz1SbIMNMywtAgIirGgk1cHv3Nocjb6Z9TTtYJD1yiMgglMqurIEkeuU88mYVqaf7GN5KrjQOh1d6bJBieXMdHr2ewd5ShqwHmgbYIWI5uy27uAHvPm9SnjUAAYKNReX8GfeaV77hPCmU5Q9iSWjJtRsI9DFtEy/QRFgAmN6U6jKqUzTCo7/l+616GI5pz8eqetmsx6cHPlr+GrGidxfxl88iUSz0p05j83yyVWCNC11njWgaEX9fvSW+9kNN28jMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BDMirb63e4mQrLrukOg1fWLmKm00xM0tUHidAUnE5X0=; b=sztcMS92vgOY1hjgl0luVjE9W7M3VNSdcPc3hDREIICeRGtSuLaoC1DHUtEAVfPVduj6i1fNKfogsEG8G1IKNKALd5M57XEs/5QiQjQHnSUDVxPFRaxr/c5DN8l7hHke+7IX00jM3AQhmESeXkWvd6Y/CVV5DsOd/CKt3qo9Jys3ZpBKal9w1IqXX7VTzVgYAJIPrwS1WjKsnBJ0Cqc5D/mzbgtrOYFzgNiwYyYcgOQlvdKMzeI656yUpnJrm8eSdxfoqZWfGSkEPOzqxsJJH8eRa93fz90x82kh1xNb9yLdM7K1Kc8bjjI0gjvFF2X8TXSIZOM6wwdKKxQdqORUGQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: Date: Fri, 29 Jul 2022 09:22:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Xenia Ragiadakou , Julien Grall Cc: Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> <69942917-f2e9-718e-094d-9b01aea16a4a@gmail.com> From: Jan Beulich In-Reply-To: <69942917-f2e9-718e-094d-9b01aea16a4a@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0008.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1d::14) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c9a908a1-2395-4d7c-33a4-08da71331f82 X-MS-TrafficTypeDiagnostic: DB6PR0401MB2373:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8aQ9Lp9qfz5aYVJFlAOvhA5Q36KEaXViJNTONanztnJ994sPYn+0XM2bluFClm/dt+QAi+MQ1WcX4iVbQeaFpr2mLeB5rAGBXNsL4cjXj1C5ZJuspFg1M12Y2qeOTVvUH2fDvxl2EBtYuAGhmsjc8GDAzqBDmR+2A3wflyOaCXWEGG50LDDpDgif5919AWYZrCZFg8TD/E26yGBRi7Uiio9fyGQBf59m/Y+a6lMkDCNvDv+t3lABlYZp6982NYn0cwo0eei7LGlptSWayMYRZ95+N3V25pHxRf/LptU7hhZHeZx0l5IhVudX2qzAvnvJfSQW4FLNrN75vJcSBT249lfVis38E3MhDZKy3xd8frAuxooNGxqUHZeoUHx2q/lKmyAIewg+nX1afdBrdyxjbyTcWiG7+M6EdrjsICrmIRvZmAYrUePuE1D1hkU33lxvIvc5qvXW+aGZlcohlkpun5/aD5vLzMTpnl69w7Mb+a7649noeeeGgHWy/JBQx3Ec/W72cshndGbgwjWylMz17LJ210vbEVcyioo9Bi4s8yLziAfQS+yjXVdAvLk90ztytuDMHCcFqEx8sRWC27NZMM63maqR7e2qfR1W8WOLe8ZPsm+0DYxME+paXahQbcfcvp8u0tQ5kFKxRMJGKpM2N79HdGcY+vdCIpQxEVKxmCFphLbZK4YD9VdB2WG7mQ9PKj7pnzvwF85U1aMlPcWbf29q1cGYMjfZwpm4Vgfg/5i5LgnogwY9r+v0pkQ+vDajwhRf6gCvXikSM4AT7AMbLE3hB18N2BiaVONc1eBONVLL+b2S4wDxG1E5cFRyPKwOiOVWvE4fO2PbZgW5e6A3Xg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(366004)(38100700002)(8936002)(2906002)(31686004)(5660300002)(110136005)(54906003)(31696002)(66946007)(4326008)(86362001)(66476007)(36756003)(8676002)(66556008)(53546011)(6506007)(2616005)(6486002)(508600001)(26005)(6512007)(83380400001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzQ0RllwdFR6VVZSMVZ1cGpFcythTERoNk5GZUJvS1BVRWFmb0Z4Z0hzU25Z?= =?utf-8?B?eW9rcEVsS3ZYT2U3MEhvVWJjMDdUVk1ObGlIUDF1ZHRWeStlQlJ1ZGQrUkpH?= =?utf-8?B?VGh6cHk0T3krNkpPa3RsaFFzTHZpcktON2VxOGttQk1zdmNnZ0lVZmZRUVhH?= =?utf-8?B?UVg0UWNKRU56M1dOQzYrUWc4aURsTWNLTHJSUjNLUERoMHpUM1FaWG1qYkQz?= =?utf-8?B?RG1LM0d0U0xkb3FmbzZBK0pHVjVQMm1vQytiZkU2TXZpbVhucFFQdTBFL0xk?= =?utf-8?B?eUQ3UlZTb1M2MkNKUy9zRU40YVVVenpMbkloOTUvemZpNEpHRjhBWjdua0Mv?= =?utf-8?B?eVhXcUsvWnNyckdxV3J6dnVLYlpGVlg3YVlZQlBvV2tHZjlkbWRIdThCSnY0?= =?utf-8?B?R3F4UXNCYVVQTHptMjVrQjhJbW82NkhRQzlDazlrU0tYYkNNVmNiY0x2L1Jj?= =?utf-8?B?L2ZkSWUzSmtMSEZwUmxocENEVU5SOWptRWo4TVZYN2ZKbVp6RXowRXRlTi9V?= =?utf-8?B?RldjVGRheW12bGJPMlFCSDY4N3ZDdTNqY3owemNPZmM2MmtzQlY5TWFwbG54?= =?utf-8?B?QlVUaFJscDVqK1lPaDJtL2srR0FjZklsaWgyWVZLcDdwUmgveXY5QUNhYjZk?= =?utf-8?B?Y2xsYjZmLzhHRkU2eHlubXRpcTlMYmFSMHluOTIxZ0hDMW9KVVROY1JXbE8y?= =?utf-8?B?UWVKZUlDUXBLTHlmNk4vRUpsRWpqRUxDSjc2b1hTb0dia2g2SWFJMEVKSmlq?= =?utf-8?B?ZjlBVDA5TEN1OVlDUzJ5K2pXYWtXMm10ZHhBazZHNkF3REhTSlMyeTEzZEZW?= =?utf-8?B?bzMzSEdIWW5COUNUdi9SakJ4YmsrWjBIQjAwWjVVV1dLRlpYZllDOVplZzhk?= =?utf-8?B?eDlkQTFjYm9YUlkrM2FYTmRCaFY5RllKVUFrbmhCaUFqL0M0OUkveGpRbXpQ?= =?utf-8?B?clliZzZDNjFxaHZHZnZpM0xCV1FoNTBrN1JteDI3T3UyNEl2MnBLa1cwQlM4?= =?utf-8?B?UXBSV00yOFlyV2RrVHRNU2xIeWQ0TmFqVW5ueHo4SklLVTEyVjhLSE4xVUV5?= =?utf-8?B?V29iOFJhaWpWVnQ5V2RHakhOV2NaUXNrK0NuK3QxeUsyVk1hSlBKaTc4SU5z?= =?utf-8?B?TmtBdW8yWnBibEFrakF5UkU5T2djc0RqVTRDSWQ1NVdqZmNIL2xiUzZiNGdS?= =?utf-8?B?cWxlYVZFcXFwd3RSRTJPT0xxM0RkQmpLdWsydDdIMTFpZzlLM0dibUREVlRs?= =?utf-8?B?NXFsMThIajhjOFVjSG03OWNzZDIwR1VJaVFYRUNoRHN1dEpIeUZUTEp0T3F6?= =?utf-8?B?NmZwK1NTenV5eURMbnlldFZpeVM5R1NESkhyVkJDRnhXQ0lLYU1ucGRudEtO?= =?utf-8?B?bi80OTBIczRNelJrWTQ1S3lIdDlxVWFtcGNwMTlzazFyZlB2bFlIU1JPTHln?= =?utf-8?B?ZmJDYlBqZUNrcUpJemhVM3pEOUg1SDFnUDcxMFdIWW1WSkF6WWxUVzFKY1pG?= =?utf-8?B?cEg2K1VpcFdsUFBZQjg0N2VaaUxvVmE0WTdESUxxRWdNYWMvOW15ZHoyK0h2?= =?utf-8?B?VlVnRHhwZE8vOXFhRzBDaDh4NUpTYlJlbS9OUG0yMzFFSExERW1SY3NyMC9V?= =?utf-8?B?VUV1a3FhZmR2blVaVWloeGdTVE4xelJMeHNESEc4VC9FeE83d3hBZEtUb25Y?= =?utf-8?B?cHNZczF0dGJ0RllwL2pmS01mT2t2YkhPazBzVzBKam1lbytheFEyR2Z5S2U2?= =?utf-8?B?cDk0K1NzTjFnNDZDR0VsOXkxajNuRzR1R3Fjd3Y0T3ZzbXNUTEdoOVdUOERS?= =?utf-8?B?R0g1TkYwL2V2NENESVpJa1VZdXFBVDNDaFpnbXF4d1ZBdTJRa3FJZThPMnZ4?= =?utf-8?B?VWN0Vzh5VVdnSzVhZzcxOFVxcG5Pc2lyTWtvaXJTUjlNOEFuV084ZlVHdjhJ?= =?utf-8?B?WXJEWmJ4STdmcVd3UDRiQWRFTURmQmZOU3VTZHdSQXpCZS9HQ2N6YjB0Skx1?= =?utf-8?B?NUVuUWJWTXR4ckhUUEgxUFNhQ1FqSkR1d2dvdTJLV2NLblRNRklnaVRuNVN0?= =?utf-8?B?R1NZUTZGZVQ0dzRLeFJiekxVNXE5N0RRUUphVGNkcHR4dHVWQlc1YjVIUzNY?= =?utf-8?Q?6DeVyAXTtnA8UplmAYC2KCa/w?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: c9a908a1-2395-4d7c-33a4-08da71331f82 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 07:22:41.3650 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: veKSU4jFAngE788ZK6ThH9cRU7Q/bpCcTv7XGeHP00Q10vzunonibSPk3Dy5K8GCf8yzntDhyXVR/pUfi1uXWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2373 On 29.07.2022 09:01, Xenia Ragiadakou wrote: > On 7/29/22 09:16, Jan Beulich wrote: >> On 29.07.2022 07:23, Xenia Ragiadakou wrote: >>> On 7/29/22 01:56, Stefano Stabellini wrote: >>>> On Thu, 28 Jul 2022, Julien Grall wrote: >>>>> On 28/07/2022 15:20, Jan Beulich wrote: >>>>>> On 28.07.2022 15:56, Julien Grall wrote: >>>>>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>> @@ -461,7 +461,7 @@ >>>>>>>> /* Access to system registers */ >>>>>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>>>>> - uint64_t _r = v; \ >>>>>>>> + uint64_t _r = (v); \ >>>>>>> >>>>>>> I am failing to see why the parentheses are necessary here. Could you >>>>>>> give an example where the lack of them would end up to different code? >>>>>> >>>>>> I think it is merely good practice to parenthesize the right sides of =. >>>>>> Indeed with assignment operators having second to lowest precedence, and >>>>>> with comma (the lowest precedence one) requiring parenthesization at the >>>>>> macro invocation site, there should be no real need for parentheses here. >>>>> >>>>> I am not really happy with adding those parentheses because they are >>>>> pointless. But if there are a consensus to use it, then the commit message >>>>> should be updated to clarify this is just here to please MISRA (to me "need" >>>>> implies it would be bug). >>>> >>>> Let me premise that I don't know if this counts as a MISRA violation or >>>> not. (Also I haven't checked if cppcheck/eclair report it as violation.) >>>> >>>> But I think the reason for making the change would be to follow our >>>> coding style / coding practices. It makes the code simpler to figure out >>>> that it is correct, to review and maintain if we always add the >>>> parenthesis even in cases like this one where they are not strictly >>>> necessary. We are going to save our future selves some mental cycles. >>>> >>>> So the explanation on the commit message could be along those lines. >>> >>> First, the rule 20.7 states "Expressions resulting from the expansion of >>> macro parameters shall >>> be enclosed in parentheses". So, here it is a clear violation of the >>> rule because the right side of the assignment operator is an expression. >>> >>> Second, as I stated in a previous email, if v is not enclosed in >>> parentheses, I could write the story of my life in there and compile it >>> :) So, it would be a bug. >>> >>> So, I recommend the title and the explanation i.e >>> "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation >>> >>> The macro parameter 'v' is used as an expression and needs to be enclosed in >>> parentheses." >>> to remain as is because they are accurate. >> >> I'm afraid you're following the MISRA wording too much to the latter. >> Earlier on you agreed that when macro parameters are used as function >> arguments, the parentheses can be omitted. Yet by what you say above >> those are also expressions. > > Yes, those are also expressions (that's why I added parentheses > initially) and I agreed with you that the parentheses there may not be > necessary because I could not think of an example that will produce > different behaviors with and without the parentheses. This will need a > formal deviation I imagine or maybe a MISRA C expert could provide a > justification regarding why parentheses are needed around function > arguments that we may have not think of. > >> As indicated before - I think parentheses >> are wanted here, but it's strictly "wanted", and hence the title >> better wouldn't say "fix" (but e.g. "improve") and the description >> also should be "softened". >> > > Regarding the latter, are you saying that the parentheses are not needed? > In my opinion they are needed to prevent the bug described in the > previous email i.e passing multiple statements to the macro. Any such use would be rejected during review, I'm sure. However I think there's another case which might indeed make this more than just a "want" (and then responses further down are to be viewed only in the context of earlier discussion): #define wr(v) ({ \ unsigned r_ = v; \ asm("" :: "r" (r_)); \ }) #define M x, y void test(unsigned x) { wr(M); } While this would result in an unused variable warning, it's surely misleading (and less certain to be noticed during review) - which is what Misra wants to avoid. Let's see what Julien thinks. > By whom are they wanted? I 'm afraid I cannot understand. By us as a community: This can be viewed as one of many agreements we have on coding style. (As such it may want to be written down somewhere.) > Also, are you proposing to change the title into "Improve MISRA C 2012 > Rule 20.7 violation" ? Obviously not. I was thinking of "improve to avoid ...". Jan From xen-devel-bounces@lists.xenproject.org Fri Jul 29 07:58:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 07:58:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377383.610579 (Exim 4.92) (envelope-from ) id 1oHKt8-0002E5-6F; Fri, 29 Jul 2022 07:58:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377383.610579; Fri, 29 Jul 2022 07:58:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHKt8-0002Dy-3B; Fri, 29 Jul 2022 07:58:26 +0000 Received: by outflank-mailman (input) for mailman id 377383; Fri, 29 Jul 2022 07:58:25 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHKt7-0002Ds-06 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 07:58:25 +0000 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [2a00:1450:4864:20::62f]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 3824d77f-0f14-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 09:58:23 +0200 (CEST) Received: by mail-ej1-x62f.google.com with SMTP id ez10so7110972ejc.13 for ; Fri, 29 Jul 2022 00:58:23 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id d6-20020aa7ce06000000b0043ba24a26casm1958198edv.23.2022.07.29.00.58.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 00:58:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3824d77f-0f14-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=cGhgx67Cv1IrEHlzR0A+NYH5DRlnzxJroQfU8BZuYIE=; b=QvGfFYqlJZFG3anjNQdHvKfaEYAKlEVZb4kg0o0hbjUToE7gGpZ1hOwDWsfq/dZfBz kA69vw/lWahVNZ5UuoEkSOaxTHc/3ShiPrQZ/Hw7Cj4/9N/YEUhk1PGbE40U7zF9kcPD ixmr6p9+COMlx8Jby0YD0ocT9cdZCwYq0/TySHZnEPn5QrmEc+nYdLXEu7AQVmhvOr8p JQ4oFXyt35/m2BwZeA22igXTFGegU5z8nL6+ztKWt+12CTio7HcBLFDpBYM4fYZ52TVI ThzezzUXPrYchdnhGn7bqXR48848u5jWjFQqc4/IcM77jC2pZn23u0kus67XRLDSnHDJ qthw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=cGhgx67Cv1IrEHlzR0A+NYH5DRlnzxJroQfU8BZuYIE=; b=B+bIkmH6oxlblKu/0jHNLIcKc6aTo1aMvjliF49h6LTfv8bpYoxcshvVNvinkcuYVr 4RVfGQIBqYtqjEpcYsk5ZFS7lHOhc2uRBykjBzORRFniA0v8plfJITFpFhBgl2yS0AlE pqemlmOzRWrXkdfyOwqXXvXnQi0gvX2vH8xcNcrIFmhuftDXaUvwxzZXyB5jLyn09+Hh qZUESCLBSYP51m4gSFDH3gQ4Tmf2lKrE5Lir+vBpmaQIY2YzeWpeTzY0dp7ZXOoNznvB KHUVcvUaHuE+z7u7tvYCMpjqYkeoLEulbVFgN8nFL9GywiFtpOL+CE88GuQsdjzfwK/c kY+Q== X-Gm-Message-State: AJIora8A7TZnBV3Bhi+FhdATg06zCbBhYE1+4UWx9pD52Ld6XD8FXLfg IgeDwjkN5KkOKTYM5b4Lxo0= X-Google-Smtp-Source: AGRyM1tqBgZl3WZGn9/JVW6UV+aTQ2ogKW2LrD/jH0a3JZea2qmChtKNU7joAP45hSQL2DWN1B3ZCA== X-Received: by 2002:a17:906:8a5b:b0:72b:50a1:a72c with SMTP id gx27-20020a1709068a5b00b0072b50a1a72cmr2032306ejc.152.1659081502684; Fri, 29 Jul 2022 00:58:22 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 10:58:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich , Julien Grall Cc: Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> <69942917-f2e9-718e-094d-9b01aea16a4a@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/22 10:22, Jan Beulich wrote: > On 29.07.2022 09:01, Xenia Ragiadakou wrote: >> On 7/29/22 09:16, Jan Beulich wrote: >>> On 29.07.2022 07:23, Xenia Ragiadakou wrote: >>>> On 7/29/22 01:56, Stefano Stabellini wrote: >>>>> On Thu, 28 Jul 2022, Julien Grall wrote: >>>>>> On 28/07/2022 15:20, Jan Beulich wrote: >>>>>>> On 28.07.2022 15:56, Julien Grall wrote: >>>>>>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>>>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>>> @@ -461,7 +461,7 @@ >>>>>>>>> /* Access to system registers */ >>>>>>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>>>>>> - uint64_t _r = v; \ >>>>>>>>> + uint64_t _r = (v); \ >>>>>>>> >>>>>>>> I am failing to see why the parentheses are necessary here. Could you >>>>>>>> give an example where the lack of them would end up to different code? >>>>>>> >>>>>>> I think it is merely good practice to parenthesize the right sides of =. >>>>>>> Indeed with assignment operators having second to lowest precedence, and >>>>>>> with comma (the lowest precedence one) requiring parenthesization at the >>>>>>> macro invocation site, there should be no real need for parentheses here. >>>>>> >>>>>> I am not really happy with adding those parentheses because they are >>>>>> pointless. But if there are a consensus to use it, then the commit message >>>>>> should be updated to clarify this is just here to please MISRA (to me "need" >>>>>> implies it would be bug). >>>>> >>>>> Let me premise that I don't know if this counts as a MISRA violation or >>>>> not. (Also I haven't checked if cppcheck/eclair report it as violation.) >>>>> >>>>> But I think the reason for making the change would be to follow our >>>>> coding style / coding practices. It makes the code simpler to figure out >>>>> that it is correct, to review and maintain if we always add the >>>>> parenthesis even in cases like this one where they are not strictly >>>>> necessary. We are going to save our future selves some mental cycles. >>>>> >>>>> So the explanation on the commit message could be along those lines. >>>> >>>> First, the rule 20.7 states "Expressions resulting from the expansion of >>>> macro parameters shall >>>> be enclosed in parentheses". So, here it is a clear violation of the >>>> rule because the right side of the assignment operator is an expression. >>>> >>>> Second, as I stated in a previous email, if v is not enclosed in >>>> parentheses, I could write the story of my life in there and compile it >>>> :) So, it would be a bug. >>>> >>>> So, I recommend the title and the explanation i.e >>>> "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation >>>> >>>> The macro parameter 'v' is used as an expression and needs to be enclosed in >>>> parentheses." >>>> to remain as is because they are accurate. >>> >>> I'm afraid you're following the MISRA wording too much to the latter. >>> Earlier on you agreed that when macro parameters are used as function >>> arguments, the parentheses can be omitted. Yet by what you say above >>> those are also expressions. >> >> Yes, those are also expressions (that's why I added parentheses >> initially) and I agreed with you that the parentheses there may not be >> necessary because I could not think of an example that will produce >> different behaviors with and without the parentheses. This will need a >> formal deviation I imagine or maybe a MISRA C expert could provide a >> justification regarding why parentheses are needed around function >> arguments that we may have not think of. >> >>> As indicated before - I think parentheses >>> are wanted here, but it's strictly "wanted", and hence the title >>> better wouldn't say "fix" (but e.g. "improve") and the description >>> also should be "softened". >>> >> >> Regarding the latter, are you saying that the parentheses are not needed? >> In my opinion they are needed to prevent the bug described in the >> previous email i.e passing multiple statements to the macro. > > Any such use would be rejected during review, I'm sure. I would argue that any such use should be rejected by the compiler. > > However I think there's another case which might indeed make this > more than just a "want" (and then responses further down are to be > viewed only in the context of earlier discussion): > > #define wr(v) ({ \ > unsigned r_ = v; \ > asm("" :: "r" (r_)); \ > }) > > #define M x, y > > void test(unsigned x) { > wr(M); > } > > While this would result in an unused variable warning, it's surely > misleading (and less certain to be noticed during review) - which > is what Misra wants to avoid. Let's see what Julien thinks. > >> By whom are they wanted? I 'm afraid I cannot understand. > > By us as a community: This can be viewed as one of many agreements we > have on coding style. (As such it may want to be written down somewhere.) > In that case, first it should be mentioned in the coding style document and then make reference to it in commit messages. >> Also, are you proposing to change the title into "Improve MISRA C 2012 >> Rule 20.7 violation" ? > > Obviously not. I was thinking of "improve to avoid ...". > -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 08:19:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 08:19:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377396.610590 (Exim 4.92) (envelope-from ) id 1oHLDW-0005Yo-C8; Fri, 29 Jul 2022 08:19:30 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377396.610590; Fri, 29 Jul 2022 08:19:30 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLDW-0005Yh-8f; Fri, 29 Jul 2022 08:19:30 +0000 Received: by outflank-mailman (input) for mailman id 377396; Fri, 29 Jul 2022 08:19:29 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLDV-0005YX-Cq; Fri, 29 Jul 2022 08:19:29 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLDV-00060Z-8k; Fri, 29 Jul 2022 08:19:29 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLDU-0002d3-UY; Fri, 29 Jul 2022 08:19:28 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHLDU-0001U9-U2; Fri, 29 Jul 2022 08:19:28 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=puDH+laWYcZBPoXGJcJFvh00Zz7Dz8CajW7DphHM6Uk=; b=MZoxH1PQMr2SvFdqSBQfEAI7TT oSoHaNBWwBZwI5ciFBzi6+UtcZsWtIvdtHvLjx91y3vtmkCz+eqz8MrbBHRC41oIxeU62NjRSJFkW BD1XF9KV+7/ux21vGYTBLCNz4vz5HzipHDKInpDgTl+YjfeUvb9fStFDhu4cZm20oNt8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171913: all pass - PUSHED X-Osstest-Versions-This: ovmf=0d0bfcb4571caa65b7875003f38e67e2ac7e5560 X-Osstest-Versions-That: ovmf=3eca64f157c340f9bbf552d89a69698a3090c080 From: osstest service owner Date: Fri, 29 Jul 2022 08:19:28 +0000 flight 171913 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171913/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 0d0bfcb4571caa65b7875003f38e67e2ac7e5560 baseline version: ovmf 3eca64f157c340f9bbf552d89a69698a3090c080 Last test of basis 171898 2022-07-28 17:13:05 Z 0 days Testing same since 171913 2022-07-29 03:12:41 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Chasel Chiu jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 3eca64f157..0d0bfcb457 0d0bfcb4571caa65b7875003f38e67e2ac7e5560 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 29 08:36:46 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 08:36:46 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377405.610601 (Exim 4.92) (envelope-from ) id 1oHLU1-00088r-Qx; Fri, 29 Jul 2022 08:36:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377405.610601; Fri, 29 Jul 2022 08:36:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLU1-00088k-Nc; Fri, 29 Jul 2022 08:36:33 +0000 Received: by outflank-mailman (input) for mailman id 377405; Fri, 29 Jul 2022 08:36:32 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLU0-00086V-NJ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 08:36:32 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80048.outbound.protection.outlook.com [40.107.8.48]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 8ad56f45-0f19-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 10:36:30 +0200 (CEST) Received: from DB6PR0802CA0043.eurprd08.prod.outlook.com (2603:10a6:4:a3::29) by DBBPR08MB5548.eurprd08.prod.outlook.com (2603:10a6:10:c1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.19; Fri, 29 Jul 2022 08:36:22 +0000 Received: from DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::72) by DB6PR0802CA0043.outlook.office365.com (2603:10a6:4:a3::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Fri, 29 Jul 2022 08:36:22 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT021.mail.protection.outlook.com (100.127.142.184) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 08:36:21 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Fri, 29 Jul 2022 08:36:21 +0000 Received: from 9c11fb9761f8.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A68878B2-4222-4573-9C75-C973FD5E854F.1; Fri, 29 Jul 2022 08:36:15 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 9c11fb9761f8.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Jul 2022 08:36:15 +0000 Received: from AS9PR06CA0394.eurprd06.prod.outlook.com (2603:10a6:20b:461::27) by VI1PR0801MB2080.eurprd08.prod.outlook.com (2603:10a6:800:88::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 08:36:13 +0000 Received: from VE1EUR03FT024.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:461:cafe::79) by AS9PR06CA0394.outlook.office365.com (2603:10a6:20b:461::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10 via Frontend Transport; Fri, 29 Jul 2022 08:36:13 +0000 Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT024.mail.protection.outlook.com (10.152.18.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 08:36:12 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Fri, 29 Jul 2022 08:36:10 +0000 Received: from a015977.shanghai.arm.com (10.169.188.38) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.9 via Frontend Transport; Fri, 29 Jul 2022 08:36:08 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8ad56f45-0f19-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a4TAxabySP5nMZfx2td/ADE+pl6gTAFQUDfzJhNxiad2bit6Ti9nrHdTUcnBRTPkZbyqSwQynpYjJmQjkMO48nhfegCIOhVtoRzsBCjrUBvHKlP5O/IKelu0WYBbFs+VrPWxtSEFdGNActskvtiIFib1Kx4soOxTQf5YS37AOxACyhYHRF6z6B3Z5gLCEd7EnBP4NQpMclYk8sQU4i+O6/597JYMLwKz6Ec+jFHK+Oom0ab+F+D4KjHwJCqeFlvT8gsKrS5IdAKKGr3ryF0SmopbVfBj8Gfi42XipSc0lcUznKI8uYbSAd7ytrjr86k+YX8hi6aWf+HGIeo02f4VQA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Luj6WGcvC7Id5jsfCrQ8DFeZ6tuRojWkwmRg1mcIZIE=; b=gVm478eOuqIubw5u9XoJt9R535+W8cvh95T8e8kzaEe6BSe+oVayDfkMiiaA16RmhNxHEjr8pWLPvGClXrL2irZCXhZqSlY/K4I13J1db99BFKQyfMSaARc6RH96aQrkw4W23NEoZTKPbRt8jPVIXKYan2tY453A9Kqkdql651w1MIgIj2EP7RjiRHGJaivq/kQaR8z91e0z7LqMiBV7TFQlaEClKUnOcRbwg74UGqRhCxtx/gKCW9rzAm2MFsWrH2bBR46di3SroZdAiXtkkYyaIi0o3rkx2mXcHx8jT4OJI3h8tH3nxXJv/3YJFU+TtE8QWbWeyPw4fXQR3TgTtQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Luj6WGcvC7Id5jsfCrQ8DFeZ6tuRojWkwmRg1mcIZIE=; b=56VrWsilsnXk98XQO0cnYZNbjc2NJgPyT48HTVhBgcnrUdDSsLM6Itg8Ek2/2qQiFwPf9tOsNaNs2clhQrhW4LHTxc0Ag4VrJfz6qr2ULULwFWR9YXJ7MSPla+9c3Ikht2+RwI3ALdNTauVBZDWKyzxMtWRY8oBxTevd5vo5z/4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 584d6a2357ed8be4 X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IJKZHrqZH0kNDbOzcu0AjjfVySQRXm4BZmhUrH8ezo9YOWAp7mtLYSw7D856WYyGqXWVN12wGWDTfNl3aMir6XJqh/aWe7TlC3uGqt8dFGcluxqCa17J0MJpgDjh3bPEG1l4cqQYRZeDEmTmYwg3kF7PcHctD4HU0793GOsoUa8mHrv/aZrwwuph+J0UNR7xWzTQqIw40h7JGSLqE0KVPQHedHMNtyaW8UMZBkTQ46CMJr5DIz+H9nsqEv10C3kFD1AM3KFrS/qTNkTZCgcxW+wGAj8ipj2FyJ5xS8KnYXVGCFxTEhTyawOQebrXlAcPUxzlmnqdOSKDgwsDPW58eg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Luj6WGcvC7Id5jsfCrQ8DFeZ6tuRojWkwmRg1mcIZIE=; b=Vq0Kb099bLjI0qid4pG832axX2GJjEQcP0dD7EqJR0C4j2xKv7GL/wvwCnJ0LQrsh+g4QZmhkTd4K/t/U2wew4zkIzvMMhYiR8Gt+L8zxpsWgyRjhjLNQI6ppJHks0T2bMqyPAPP1PI7csTbw5agcbYfefqFhr1Olc1gzho3ki4g0d+/GM4S69SP+Of9kG171+bufVKySRVsdgkKoE43mPL+epfh/O7UNIef9DE///Cxfuga65GA7qTkjJ47R1M2TNg4HMLO3Lk4Ckhmc/4WRicMFDnf6Ckki75uxb69EiLWP3HUbAscTkRMUdgB2SJE/ghk8NsUHL4BaJ/jr5gCZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Luj6WGcvC7Id5jsfCrQ8DFeZ6tuRojWkwmRg1mcIZIE=; b=56VrWsilsnXk98XQO0cnYZNbjc2NJgPyT48HTVhBgcnrUdDSsLM6Itg8Ek2/2qQiFwPf9tOsNaNs2clhQrhW4LHTxc0Ag4VrJfz6qr2ULULwFWR9YXJ7MSPla+9c3Ikht2+RwI3ALdNTauVBZDWKyzxMtWRY8oBxTevd5vo5z/4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C From: Hongda Deng To: CC: , Hongda Deng , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk Subject: [PATCH v2] arm/vgic-v3: fix virq offset in the rank when storing irouter Date: Fri, 29 Jul 2022 16:36:02 +0800 Message-ID: <20220729083602.390484-1-Hongda.Deng@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EOPAttributedMessage: 1 X-MS-Office365-Filtering-Correlation-Id: 9b5e48d8-fd38-4a95-28ef-08da713d6a60 X-MS-TrafficTypeDiagnostic: VI1PR0801MB2080:EE_|DBAEUR03FT021:EE_|DBBPR08MB5548:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: lHlnax8MG1szlCenP9KqQ/ynYzIe80ax6ox5PJ+LajlUxX2gu5IpKKD294hpmTqcaRyEEiTu9Fzp2qQlQ1NPj8Us5WKUsEgc1AG07krvci8JrjwORxk0KB1YYwJ80T31KvyMjMIJc+g6nUNr2M8moVnGJONnZXjwiBpLjKlLgfK7xOdmr9uTZUt7+DNm627VtVXJOeWIx5rr+BFJGxORzz3jHAq0VvEFs5JOxkWMuLtq9+PXg6xSYoJ9LV9/Mv9fnxn1I2F/nqiaynFy0Mzt/tzQnw5U0fhhl3xGg1mY4FKDkQhUBySOGBQV93GIKJnVSk4GGWqWvflBPoZP7M8q8ymzvgZe89/rrgVR74blElad2XDAddfyfaCf5l5zEjK3ungIPK/6yst7UXuswAmQHRk89/kTmXTYGhoXN9yvr9jDiBW4vyc6W/lcp+MkGgblPkqOC2KnPWyJldly7POW1fdlGyQi93rkp71iqlWHt8V4hgDrDDBOZpsY6dSQDePJJ/KndVYQDnLnAKsw7iDuDVbAt7r33WEhQ4kf1hOfYlbuZGWHgq4CHOAOD5vs4kleT0mFY91ciOvOl2vX+hUmEjmlW0FmZB6jCerMPk2sKCrv/CavIEC+W42xHsTa9icU8RX3CVpELdqP2xRgpYR2n/Ltn3hewHOnCTOijHINsmzpMQV3/ODsB0SbYDe2O9vbCT2DDnjKT0p4UV1t/yTlBLG2pIp++0cdX7ZpgD9F+1l4hMDjqpe6TWx9ZY3uiK/R8HHFhu8g7yBaPwRFvvKapN5SbiP5dEKCDB7wcf0C3oF9HdkkuQT9Bt/PA4gb9mBZa42iKBQrmD96MYvhKWgO/A== X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230016)(4636009)(346002)(396003)(39860400002)(376002)(136003)(36840700001)(40470700004)(46966006)(2616005)(1076003)(426003)(81166007)(336012)(186003)(83380400001)(82740400003)(47076005)(356005)(36860700001)(70206006)(70586007)(4326008)(8676002)(316002)(2906002)(5660300002)(8936002)(478600001)(6666004)(41300700001)(26005)(54906003)(6916009)(40460700003)(7696005)(82310400005)(40480700001)(36756003)(86362001)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB2080 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 118679f6-0326-4388-07f5-08da713d6527 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mZXEXkk6gVDnLjo84soQ+ZHFgyXGlWlOJy4rq0e70UhUMmrL8oRQ+4H5OQeCoQAuUjLJRzTyPx9IOeYG5CWYMUW++UxOGTMO1f6jnqqyz8fQLZrlcTmR4BokZyW4xutHbly7Wn6X1zmzVbNiJzxvQvqimmtXjN9kwrRR0AohZruaiiYOOUHRnsN/i3w3U56AlMc1HG968Ec9TpKeAk+bW/mAUImt+fKtzIu1MXWSJBMYTJJlJBlG5sHTxBMILmnWPTmNhWMDaOIPKizC4WsuQdLDkgVB2avVfPNmipwSqcz93TPDqtNiyWg3IfogZY5C3NtiG5arZ3o8M/aJ5Z70uKhUL16uOQX3xBCi/N7N4bjQo6o2pubQwnU+PCtlf9WUiKtPabyHZLrt1aXatvW4UW2x1dU0MN2NtCL9VvKPlxqXTikoyKmrzec02VzR9DwApX9E7Ynu/6ZsFOaHWlJ3ICjK4zkEGRtqyfExwsMNi/RJpLYfDme7sUVSiUke9NLAoPBkhTfFK4xy/O7hxvg4pHCNAtFxZggaiCwTSxt9lXWm8xiSX83gGyBbWAL7F4zWM8y8FJRMT8JxibeDmFnuuRWMIZFrRPfaGX79beOuaAtdTPlyGMyX0zzX1RW5qGYgbTTpseMkDXMNTmcwn1rFjvf5qv7rbYuUH4S+77Knvw5eWfaDUhA49+p8Bo80Q1aebugFOz/Y4bjjO8XJU7VoqxKcXqTba3nR3ccToYFDV1uq9GvEKCt9Yjx4ve7Dlgjnbmz1hvRfFHgsllAA98jcEQFjqksQ2AW7sh8akZBw6WtpJRLL9EG44zf/GCqVp8vM X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(376002)(136003)(346002)(40470700004)(36840700001)(46966006)(47076005)(70206006)(4326008)(426003)(83380400001)(5660300002)(82310400005)(26005)(1076003)(186003)(40480700001)(6666004)(36756003)(8936002)(70586007)(2906002)(54906003)(82740400003)(41300700001)(7696005)(107886003)(6916009)(478600001)(8676002)(2616005)(36860700001)(336012)(81166007)(316002)(40460700003)(86362001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 08:36:21.7820 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b5e48d8-fd38-4a95-28ef-08da713d6a60 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT021.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB5548 When vGIC performs irouter registers emulation, to get the target vCPU via virq conveniently, Xen doesn't store the irouter value directly, instead it will use the value (affinities) in irouter to calculate the target vCPU, and then save the target vCPU in irq rank->vcpu[offset]. When vGIC tries to get the target vCPU, it first calculates the target vCPU index via int target = read_atomic(&rank->vcpu[virq & INTERRUPT_RANK_MASK]); and then it gets the target vCPU via v->domain->vcpu[target]; When vGIC tries to store irouter for one virq, the target vCPU index in the rank is computed as offset &= virq & INTERRUPT_RANK_MASK; finally it gets the target vCPU via d->vcpu[read_atomic(&rank->vcpu[offset])]; There is a difference between them while getting the target vCPU index in the rank. Actually (virq & INTERRUPT_RANK_MASK) would already get the target vCPU index in the rank, it's wrong to add '&' before '=' when calculate the offset. For example, the target vCPU index in the rank should be 6 for virq 38, but vGIC will get offset=0 when vGIC stores the irouter for this virq, and finally vGIC will access the wrong target vCPU index in the rank when updating the irouter. Fixes: 5d495f4349b5 ("xen/arm: vgic: Optimize the way to store the target vCPU in the rank") Signed-off-by: Hongda Deng --- xen/arch/arm/vgic-v3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c index e4ba9a6476..7fb99a9ff2 100644 --- a/xen/arch/arm/vgic-v3.c +++ b/xen/arch/arm/vgic-v3.c @@ -135,7 +135,7 @@ static void vgic_store_irouter(struct domain *d, struct vgic_irq_rank *rank, ASSERT(virq >= 32); /* Get the index in the rank */ - offset &= virq & INTERRUPT_RANK_MASK; + offset = virq & INTERRUPT_RANK_MASK; new_vcpu = vgic_v3_irouter_to_vcpu(d, irouter); old_vcpu = d->vcpu[read_atomic(&rank->vcpu[offset])]; -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 09:08:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 09:08:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377417.610611 (Exim 4.92) (envelope-from ) id 1oHLyo-0003r0-F8; Fri, 29 Jul 2022 09:08:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377417.610611; Fri, 29 Jul 2022 09:08:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLyo-0003qt-CR; Fri, 29 Jul 2022 09:08:22 +0000 Received: by outflank-mailman (input) for mailman id 377417; Fri, 29 Jul 2022 09:08:21 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLyn-0003qn-3E for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 09:08:21 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHLyk-0006v8-Qz; Fri, 29 Jul 2022 09:08:18 +0000 Received: from [54.239.6.186] (helo=[192.168.0.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHLyk-0003It-Kr; Fri, 29 Jul 2022 09:08:18 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=dMgovwG4UFXazPp/eY8b4sdDXQBHRGM/mjFKMT68Zbc=; b=s5v+agOkd+CBO38d/r+XurxWcx xlm8P+VOP1gKfRBSP//CAahZZK3faBdJgZ472A28SDmbs3bewG7Ohlh+E7pUG79AL8f8N5pJrXB/u JbiExFRwE73F1PYp83nVTqYZO0Kih0rF0UWmYoH1ErPJrhfBFkgHYa7TVY3EBd1eP+p4=; Message-ID: Date: Fri, 29 Jul 2022 10:08:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Content-Language: en-US To: Oleksandr Tyshchenko Cc: osstest service owner , "xen-devel@lists.xenproject.org" , Anthony PERARD , Jan Beulich References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> From: Julien Grall In-Reply-To: <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit (+ Anthony) Hi, On 29/07/2022 07:48, Oleksandr Tyshchenko wrote: > > On 29.07.22 09:22, Jan Beulich wrote: > > Hello Jan > >> On 29.07.2022 03:04, osstest service owner wrote: >>> branch xen-unstable-smoke >>> xenbranch xen-unstable-smoke >>> job build-amd64-libvirt >>> testid libvirt-build >>> >>> Tree: libvirt git://xenbits.xen.org/libvirt.git >>> Tree: libvirt_keycodemapdb https://urldefense.com/v3/__https://gitlab.com/keycodemap/keycodemapdb.git__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpzij9yLM$ [gitlab[.]com] >>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git >>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git >>> Tree: xen git://xenbits.xen.org/xen.git >>> >>> *** Found and reproduced problem changeset *** >>> >>> Bug is in tree: xen git://xenbits.xen.org/xen.git >>> Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>> Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce >>> Last fail repro: https://urldefense.com/v3/__http://logs.test-lab.xenproject.org/osstest/logs/171909/__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpmYABJkc$ [logs[.]test-lab[.]xenproject[.]org] >>> >>> >>> commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>> Author: Oleksandr Tyshchenko >>> Date: Fri Jul 15 22:20:24 2022 +0300 >>> >>> libxl: Add support for Virtio disk configuration >> Just in case you didn't notice it: Something's wrong here. I didn't look >> at the details at all. Please advise whether a fix will soon arrive or >> whether we should revert for the time being. > > Sorry for the breakage. At the moment I have no idea what is wrong here, From the build log: ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': ../../src/libxl/xen_xl.c:779:17: error: enumeration value 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch [-Werror=switch-enum] switch (libxldisk->backend) { ^~~~~~ The switch contains a default branch [1], so I am a bit puzzled why GCC is not happy here. > > I will try to investigate and provide a fix by the end of the day. So the general expectation is libvirt should be able to compile without using the new features provided by libxl. In this case, I am not sure there is anything we could do in libxl without large rework to conditionally define LIBXL_DISK_BACKEND_STANDALONE. So if a fix is necessary, then it will probably need to be in libvirt. Cheers, [1] https://xenbits.xen.org/gitweb/?p=libvirt.git;a=blob;f=src/libxl/xen_xl.c;h=f9dc18ab18b208d319282ce422f46c75135c0673;hb=refs/heads/xen-tested-master#l779 -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 09:11:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 09:11:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377422.610623 (Exim 4.92) (envelope-from ) id 1oHM28-0005EN-U4; Fri, 29 Jul 2022 09:11:48 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377422.610623; Fri, 29 Jul 2022 09:11:48 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHM28-0005EG-Qv; Fri, 29 Jul 2022 09:11:48 +0000 Received: by outflank-mailman (input) for mailman id 377422; Fri, 29 Jul 2022 09:11:47 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHM27-0005E6-9P; Fri, 29 Jul 2022 09:11:47 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHM27-0006zT-7e; Fri, 29 Jul 2022 09:11:47 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHM27-0005Ml-1A; Fri, 29 Jul 2022 09:11:47 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHM27-00027B-0l; Fri, 29 Jul 2022 09:11:47 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YbzuGOtUiwaazvBZ9bxSsvK/iBYvlNvaViepMspIXxk=; b=aSOClnymjIimDZdOcNe+7XWGzS q0LsorjwgbCRX7bTb4TJqYcJ1dkS0mxA2I8WGq7ngPF8XNKVX681iZsjRJtkbpGqeZSY1WazOXkj/ A4Y4WAQzQPrR81HcNp3gl0BDsYyFt+vCGTUnGHrGROtXjUHTBEIs9NCYJ4JLmTCs7nTM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171915: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=108e6f282d2c2b8442ac9e1487e6fd7865cd6ede X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 09:11:47 +0000 flight 171915 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171915/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 1 days Failing since 171899 2022-07-28 19:01:47 Z 0 days 4 attempts Testing same since 171911 2022-07-29 02:00:25 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: George Dunlap Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 09:23:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 09:23:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377431.610633 (Exim 4.92) (envelope-from ) id 1oHMCw-0006ut-Um; Fri, 29 Jul 2022 09:22:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377431.610633; Fri, 29 Jul 2022 09:22:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMCw-0006ul-S3; Fri, 29 Jul 2022 09:22:58 +0000 Received: by outflank-mailman (input) for mailman id 377431; Fri, 29 Jul 2022 09:22:57 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMCu-0006ub-TE for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 09:22:57 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0666dfa5-0f20-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 11:22:55 +0200 (CEST) Received: from pps.filterd (m0174677.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26T9MicK012227; Fri, 29 Jul 2022 09:22:53 GMT Received: from eur05-am6-obe.outbound.protection.outlook.com (mail-am6eur05lp2109.outbound.protection.outlook.com [104.47.18.109]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hmcv2r01g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jul 2022 09:22:52 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by DB6PR03MB3031.eurprd03.prod.outlook.com (2603:10a6:6:36::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.25; Fri, 29 Jul 2022 09:22:49 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5482.012; Fri, 29 Jul 2022 09:22:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 0666dfa5-0f20-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDv7/GH2HozZ59Z4yxnRl6tpB0LjDbjMENfqV/2OaMaLPhqkG1vzdkT904pFVdb+bOAiG7IhB/fGmDfo7012qEMspZdaHu9zC9Q6Dc8MC10lT3istnjsQyQbloyoMz67znIrJA7G6lxscEcQxrjafR+bH8OtIVk3EtwpFvGDGQABhFAUn2dffUn1RvQEGFciT4O9pGnw1VIYuBzNEbXgr6y/QdUYQ7pK+We3GnAjR+VhbPklDQwcrws5y6KV9EGSlxvBbodL/rqRayeeIjmPgIuzk0/XKLRv0vqqKHy8vGyyADmyVTr35a1bnhYaa68wCZEq7UnICi/XPE3F/a6IhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kcWdlKrl2jERAr5NhYtYOrgIQjdTQELGXYb7qLkyfA0=; b=Wq9mvnMtxNNODwwRzMEE8fOoeQpC56HFAn9KeEc+R6StYlXmDZ35k/f5W07G1ZiXak5m2QX2OnIY3Tl//X0mZoJZ9Bl69TWkug9Tx0Sdrze19Ds+MKVA8uxO2r7PQf8HRAnch1wif7S+NbEBTx5c9EI7zoHjif91ew1geLmZPaOZCUfqge3B1FNdFVnSZKIqcNpERoLsNO4tz54xBfGC/eVvkOc/a5CuGDrc2KoBSOAJpmOyrUFss2icB/necWLKXz46THYSe3db4Ge7XSF8YqukZEuIOU65JySLQAXmW38yHI2P+ApcEXFBDNxVD2lwdh7LpJk/7QNbE3BBvNIZ4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcWdlKrl2jERAr5NhYtYOrgIQjdTQELGXYb7qLkyfA0=; b=rEk7OX2iueZ7b6l6lRAthsOIVQDRIVpON3uIrqdR8fQ/2Hxp7oCh+b/7chmic1BgPLCYXbLFlcKmIO+lwobJbyeywRFAjEeTpbZZ4juIV8mujkxa0ZvZQVEQGiazUmUiZD1z5kzX6663Hga+aIrs0M51he3VQ/R5sPR9pasRBX/iT4iGKb82RSit4ghLPo9+TQ7JUvJTP07pn1yGuo82YIR0Ivk4O0tO/r4OgvT6bua6Ox9IoJVuBZNCS1fYIJNWq+78T58Jc1ckvfg4PfbkttliLlwjJwTkHof0wsEaO9fAtryH/oorxghkpmHon9mowy0HV+2WzkgFJ6n7zeWQQw== From: Oleksandr Tyshchenko To: Julien Grall CC: osstest service owner , "xen-devel@lists.xenproject.org" , Anthony PERARD , Jan Beulich Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Topic: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Index: AQHYoxOqDyECYNTY4EqwTkq/MCO2na2U6EAAgAAnEgCAAAQPAA== Date: Fri, 29 Jul 2022 09:22:48 +0000 Message-ID: References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a21c02fa-48d0-406d-0105-08da7143e79f x-ms-traffictypediagnostic: DB6PR03MB3031:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ORy0B1LnHk/Vd9K3dlyDFbPG+byHRWjLkeF0rFGmw+FIrcRV1h7C2tvawGhOsWmq9mO53tYLbd60FR929HXtZf7Vc8PBvp+nQLeLkjbn4AFKg5+968ksIk3x3SIjY91NtOfekhI0rSShE6yah28d8TCnYgBurfQnBq8B+uLMtHL6akFRSTL7sOlfSyZ9kKHYkPiZ/hvsgDD5U2SoUrmiS8JxlkwJ/toaixVk+M353Cg/3lQd3D4o3u/FWleq6RcfWhDmP9kJdNs7eYlgMYGXJkjjBVnh8G1NcZw8Uo2vBU+PdRXc9+SVIb6ji6HHheOUGMXYHUgFRV67TH5e0668pTzGfIWyrUxZlZA4AD6aHuFaC3kkgyfHq3a+rk/ugeUW7eExBGj39TtG/jlDbBQv0jvUf95v1P9JsF7YY9yKa6H/l4A9XbUKb8Gxs6SYoTqm8vzMRJse7jDzqHH+3+iOV8jBtaSdCL7WOGO/9L95UZkPhaQeVW6maYq+p7VeymJ3KZz5bGucQKQhNM281sRQez/6Nw3iBVIUE2VU7fwlYQdCgIzfqnICSlzJ5XkgaQvr0qx8YxSAOSTixMpfkK2wpk/v2Vygcs9duX1a2/awIA2u9rdlIAJwIVLMFZDO/HYrbi+qjauhB6q/qQm5AUzmmzlKMxJx91C8fyJp4fGW5x5iL9j4cCB3EjPy4DhMnC5iGSa5W6k0zGTMYRUryek/q9Lj32fsbEzDXFBo65bZbuwl7hJqnGWa5htMrT4Q9pPXBK3FxisnKrglSr0whBUjqJFTdP+/47w9MfDnmwKgXf7FhtLfVslQQKei9n9MjEVE5yBHYEUS72jaV/Ot+2KxbjfivNYF2nfG54eNFTf4q488Q1UW9W5KiImbWItlnkxZ x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(55236004)(8936002)(6512007)(86362001)(966005)(26005)(5660300002)(478600001)(122000001)(53546011)(6486002)(2906002)(31696002)(41300700001)(6506007)(54906003)(2616005)(4326008)(38070700005)(71200400001)(76116006)(66556008)(83380400001)(316002)(6916009)(66476007)(64756008)(66946007)(31686004)(38100700002)(36756003)(91956017)(8676002)(66446008)(186003)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?bHFvUWVodGY1Z0xYbGFEUjIyNHdNd3A2a2xuZWtVcjdRRVFaV21RSGdHb3lj?= =?utf-8?B?WUJZWUUwbDB6ZGNYeUdJYUJoNityNHNxNWZmdzZ3ZVhUbUtjbnJkWUJQRllw?= =?utf-8?B?TFZ4aGF0cEU5aE9udzV0bGRHYm1LOGd2RGJVWXlOWVplem9ZbjFnQWV6bGlM?= =?utf-8?B?SkpPRmdYR1phNWxYcDN4VVhETmZkWWJNUFFic2xGTU0xNmZjUU5OVUpTSUN5?= =?utf-8?B?RWVyOXQybVc1eXFtdVJzVUZFYnpSbFZWVUV3dUsxNEFqSWF4MGt0MUhhT3px?= =?utf-8?B?NGppYkRUMHNlK3FIdmhsa29VbDhZYUdPZDYyNTk4enBHWVFIM0d3NjZzejN3?= =?utf-8?B?bERCK1pObTRwZy9yUjV3M1IrRkVkeUtrWUFHbFpwajU1VkROVjUxL0lOMHIz?= =?utf-8?B?cDdoUURiTk5iQ3UyVTRPczZGSFJpcmV3b3U2WGdDVHRuOUxhVjZVbTA1SFVs?= =?utf-8?B?WHB6RXo1YVJveEg2QmtybmdnK0l2WGdCZitRVmI4ZW5QTzVQLzYxT2ZuWkpq?= =?utf-8?B?UzRWMGE1cElZSVZUYzlGR2dEUDhvcWFMSy90VEE1OG5EczBUWU9QVmVpTmVi?= =?utf-8?B?ajljQkQ1MWlYRzYwS0ZTUlpTVUlVTlA1RitaMERKQXk0akJKNW0rTjZBY3Bh?= =?utf-8?B?dHVKdndwT1l0cmJwNzZ1TnZuMUhzSzlENnVTbFYzQ0ZLUGVSdkZLaTdydE40?= =?utf-8?B?cWpiNDY2Unl2eGszYTNlOTJRemRWRGlvQzhVSm9scWcxWWZHaXJUZU5VVW1Q?= =?utf-8?B?UzJtMGNIdEltRzYyNDBkdDc2MWZMY3hpc3dXM0R5TGFlTE05bDV4ZkJDM2U0?= =?utf-8?B?UEJINDVhbmNZNFA1VnA0NWx3SzF0NVFDalNSSDhZUTlnUkhlTCszWUIxQjNB?= =?utf-8?B?MGdkVUkyV29meVV4SHZ3OWpUZUFvTUU0WUdoQzEzajducmJiNG8yOHhRR2NO?= =?utf-8?B?aXptenpvTlF4K1U0enpISTZacTFnTmh4V1ZueWVaUW5tYmZJVTByUTNTVzIz?= =?utf-8?B?NDZKTjlOT2NuaWxsQ25zOFdwVzhhbWVqYXY3SnJyaU0wYmZuditkSkxtZGdq?= =?utf-8?B?WFl4YWV1RlM3UGpCSnVrU1E5K0d4cjR0OE5HT0pmK21PS3FXdTZnYWRTdTJs?= =?utf-8?B?N2wzVEY1TjlGZ3ljM3Z0OUc0clRBbmk1UjlERFZqeU1NancyQ0VOem4rMGxr?= =?utf-8?B?eWtDV1VFZjB2SSsrd0ZEdEgzZjdIUnZKUTNVZC90KzFHcWFZckRudnA5MXVh?= =?utf-8?B?VWpJRlRHSFp3UjZnaHhSa2h3QVgwdXhrU21INjhSdnI3K3Z4MGhYdUlKd2Zn?= =?utf-8?B?NnlOV0E0eWFnNERKcTQxMjlTaW5NQTRIa3BjS2dveGV0eFJGN1hLL0JxYUZj?= =?utf-8?B?cDk2QUhiaytRRXhDNWUvVEMrSEVQd0JyNWFxRDkwQzBVUWdxdnV2WDdIbVBO?= =?utf-8?B?RnRJdXIwZkMyb21hV1RKTmtwc2JhWG5GMVpLazhTTHlpN2pXZkxHMlVHT2ta?= =?utf-8?B?TzdSVzJMU1V4amRvUWtyR1MvdmxmZ0xFYXJLOE5haVpTTlcrVDFjZ290VlBh?= =?utf-8?B?WWd6RkpxNG9NL2JGOHB3M2xya2l0N3h2TTdwdWZaKzdZY3YyczlaYzZLaDIv?= =?utf-8?B?THhFWmVzYkJiNWdlUWk0WWh4T0I3WXhRT25Ualdob2VqcHZDd2ZZUlB4L1Uw?= =?utf-8?B?SkEvamh4M1htNkNlVk5RdGxsSmxRTnRaSmgrTEsyMDJGZ1U2YjNnL0JtK29t?= =?utf-8?B?Z3lpdmIvb0MrL1VZa1VqcFllRG1DUzJLZ1o5WVBOZVE0OGJoQnNlSXczdk1Y?= =?utf-8?B?UmZVK2x6S0tFN2NQckdoMjYvRmR4cE1nbzgzTHJZZHFWOFVtSE80UDhSZ2cy?= =?utf-8?B?ODl3WVFyZzlqNHhmdTNKN1ZEcjVoZHh4bDBVdTkrdWlMSVB4WHNaeHBoc2pq?= =?utf-8?B?UHVrQStoaVArOEJBZkNJdUxRY3grYURuSktoVU0vT3BFWWVzVm9VRnlsRkQ1?= =?utf-8?B?ZFQxcDRQT2NuNU52R2ZWclFXUG12RjJSR3ZBMkxPbkNBb1dRTTVvT2kxSTBq?= =?utf-8?B?L2N2YXRhSnordmEzOFVsQ0xZTkUvZWx6NnFDODFCSXY1RTNIeC9YOG5WcThv?= =?utf-8?B?MERKSTI0QUVOWllDUndRSHQ1NFkwQ3F5cVVUcGVQSDFITU8wTElHdk1HWllE?= =?utf-8?Q?BLZCMZ3PUbVHCPzRBWyw56Q=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a21c02fa-48d0-406d-0105-08da7143e79f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 09:22:48.8426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cs2kmy4mzdQle5ay7F2QG0L307D0IDnzIiw+lRNsH8Cvzr/7mPxDlHQG0JsJ6RtzH+xNwqs6JxPpLic9BuOpqxhQ2Ml/uzCsoqY3JAE+ky8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB3031 X-Proofpoint-GUID: 5lPLmHthXC4dKkEc5zP0YVNCynxMGIMu X-Proofpoint-ORIG-GUID: 5lPLmHthXC4dKkEc5zP0YVNCynxMGIMu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 spamscore=0 suspectscore=0 malwarescore=0 impostorscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 adultscore=0 clxscore=1015 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207290039 DQpPbiAyOS4wNy4yMiAxMjowOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KDQoNCkhlbGxvIEp1bGll bg0KDQo+ICgrIEFudGhvbnkpDQo+DQo+IEhpLA0KPg0KPiBPbiAyOS8wNy8yMDIyIDA3OjQ4LCBP bGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+DQo+PiBPbiAyOS4wNy4yMiAwOToyMiwgSmFu IEJldWxpY2ggd3JvdGU6DQo+Pg0KPj4gSGVsbG8gSmFuDQo+Pg0KPj4+IE9uIDI5LjA3LjIwMjIg MDM6MDQsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4+Pj4gYnJhbmNoIHhlbi11bnN0 YWJsZS1zbW9rZQ0KPj4+PiB4ZW5icmFuY2ggeGVuLXVuc3RhYmxlLXNtb2tlDQo+Pj4+IGpvYiBi dWlsZC1hbWQ2NC1saWJ2aXJ0DQo+Pj4+IHRlc3RpZCBsaWJ2aXJ0LWJ1aWxkDQo+Pj4+DQo+Pj4+ IFRyZWU6IGxpYnZpcnQgZ2l0Oi8veGVuYml0cy54ZW4ub3JnL2xpYnZpcnQuZ2l0DQo+Pj4+IFRy ZWU6IGxpYnZpcnRfa2V5Y29kZW1hcGRiIA0KPj4+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3Yz L19faHR0cHM6Ly9naXRsYWIuY29tL2tleWNvZGVtYXAva2V5Y29kZW1hcGRiLmdpdF9fOyEhR0Zf MjlkYmNRSVVCUEEhMHNfbnlBZ2RzOTc3ZHcwZEdQZ0ZKR2tJYUJpS2lYSDNuUjExTmk2Z0dqTjVn UW1CMERFaEtybTVTVVg0UjBXaEs4WWtRZW1SNlJWaGlvanB6aWo5eUxNJCANCj4+Pj4gW2dpdGxh YlsuXWNvbV0NCj4+Pj4gVHJlZTogcWVtdSBnaXQ6Ly94ZW5iaXRzLnhlbi5vcmcvcWVtdS14ZW4t dHJhZGl0aW9uYWwuZ2l0DQo+Pj4+IFRyZWU6IHFlbXV1IGdpdDovL3hlbmJpdHMueGVuLm9yZy9x ZW11LXhlbi5naXQNCj4+Pj4gVHJlZTogeGVuIGdpdDovL3hlbmJpdHMueGVuLm9yZy94ZW4uZ2l0 DQo+Pj4+DQo+Pj4+ICoqKiBGb3VuZCBhbmQgcmVwcm9kdWNlZCBwcm9ibGVtIGNoYW5nZXNldCAq KioNCj4+Pj4NCj4+Pj4gwqDCoMKgIEJ1ZyBpcyBpbiB0cmVlOsKgIHhlbiBnaXQ6Ly94ZW5iaXRz Lnhlbi5vcmcveGVuLmdpdA0KPj4+PiDCoMKgwqAgQnVnIGludHJvZHVjZWQ6IDY2ZGQxYzYyYjJh M2M3MDdiZDVjNTU3NTBkMTBhODIyM2ZiZDU3N2YNCj4+Pj4gwqDCoMKgIEJ1ZyBub3QgcHJlc2Vu dDogZjczMjI0MGZkM2JhYzI1MTE2MTUxZGI1ZGRlYjcyMDNiNjJlODVjZQ0KPj4+PiDCoMKgwqAg TGFzdCBmYWlsIHJlcHJvOiANCj4+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHA6 Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNzE5MDkvX187ISFH Rl8yOWRiY1FJVUJQQSEwc19ueUFnZHM5NzdkdzBkR1BnRkpHa0lhQmlLaVhIM25SMTFOaTZnR2pO NWdRbUIwREVoS3JtNVNVWDRSMFdoSzhZa1FlbVI2UlZoaW9qcG1ZQUJKa2MkIA0KPj4+PiBbbG9n c1suXXRlc3QtbGFiWy5deGVucHJvamVjdFsuXW9yZ10NCj4+Pj4NCj4+Pj4NCj4+Pj4gwqDCoMKg IGNvbW1pdCA2NmRkMWM2MmIyYTNjNzA3YmQ1YzU1NzUwZDEwYTgyMjNmYmQ1NzdmDQo+Pj4+IMKg wqDCoCBBdXRob3I6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl cGFtLmNvbT4NCj4+Pj4gwqDCoMKgIERhdGU6wqDCoCBGcmkgSnVsIDE1IDIyOjIwOjI0IDIwMjIg KzAzMDANCj4+Pj4gwqDCoMKgIMKgwqDCoMKgwqDCoMKgIGxpYnhsOiBBZGQgc3VwcG9ydCBmb3Ig VmlydGlvIGRpc2sgY29uZmlndXJhdGlvbg0KPj4+IEp1c3QgaW4gY2FzZSB5b3UgZGlkbid0IG5v dGljZSBpdDogU29tZXRoaW5nJ3Mgd3JvbmcgaGVyZS4gSSBkaWRuJ3QgDQo+Pj4gbG9vaw0KPj4+ IGF0IHRoZSBkZXRhaWxzIGF0IGFsbC4gUGxlYXNlIGFkdmlzZSB3aGV0aGVyIGEgZml4IHdpbGwg c29vbiBhcnJpdmUgb3INCj4+PiB3aGV0aGVyIHdlIHNob3VsZCByZXZlcnQgZm9yIHRoZSB0aW1l IGJlaW5nLg0KPj4NCj4+IFNvcnJ5IGZvciB0aGUgYnJlYWthZ2UuIEF0IHRoZSBtb21lbnQgSSBo YXZlIG5vIGlkZWEgd2hhdCBpcyB3cm9uZyBoZXJlLA0KPg0KPiBGcm9tIHRoZSBidWlsZCBsb2c6 DQo+DQo+IC4uLy4uL3NyYy9saWJ4bC94ZW5feGwuYzogSW4gZnVuY3Rpb24gJ3hlblBhcnNlWExE aXNrJzoNCj4gLi4vLi4vc3JjL2xpYnhsL3hlbl94bC5jOjc3OToxNzogZXJyb3I6IGVudW1lcmF0 aW9uIHZhbHVlIA0KPiAnTElCWExfRElTS19CQUNLRU5EX1NUQU5EQUxPTkUnIG5vdCBoYW5kbGVk IGluIHN3aXRjaCANCj4gWy1XZXJyb3I9c3dpdGNoLWVudW1dDQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHN3aXRjaCAobGlieGxkaXNrLT5iYWNrZW5kKSB7DQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF5+fn5+fg0KPg0KPiBUaGUgc3dpdGNoIGNvbnRhaW5z IGEgZGVmYXVsdCBicmFuY2ggWzFdLCBzbyBJIGFtIGEgYml0IHB1enpsZWQgd2h5IA0KPiBHQ0Mg aXMgbm90IGhhcHB5IGhlcmUuDQo+DQo+Pg0KPj4gSSB3aWxsIHRyeSB0byBpbnZlc3RpZ2F0ZSBh bmQgcHJvdmlkZSBhIGZpeCBieSB0aGUgZW5kIG9mIHRoZSBkYXkuDQo+DQo+IFNvIHRoZSBnZW5l cmFsIGV4cGVjdGF0aW9uIGlzIGxpYnZpcnQgc2hvdWxkIGJlIGFibGUgdG8gY29tcGlsZSANCj4g d2l0aG91dCB1c2luZyB0aGUgbmV3IGZlYXR1cmVzIHByb3ZpZGVkIGJ5IGxpYnhsLg0KPg0KPiBJ biB0aGlzIGNhc2UsIEkgYW0gbm90IHN1cmUgdGhlcmUgaXMgYW55dGhpbmcgd2UgY291bGQgZG8g aW4gbGlieGwgDQo+IHdpdGhvdXQgbGFyZ2UgcmV3b3JrIHRvIGNvbmRpdGlvbmFsbHkgZGVmaW5l IA0KPiBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9ORS4NCj4NCj4gU28gaWYgYSBmaXggaXMg bmVjZXNzYXJ5LCB0aGVuIGl0IHdpbGwgcHJvYmFibHkgbmVlZCB0byBiZSBpbiBsaWJ2aXJ0Lg0K DQoNCkkgaGF2ZW4ndCBldmVuIGltYWdpbmVkIHRoYXQgSSB3b3VsZCBuZWVkIHRvIGJ1aWxkIHNv bWV0aGluZyBlbHNlIGV4Y2VwdCANCnhlbiB0b29scyBpdHNlbGYgdG8gY2hlY2sgd2hldGhlciBw YXRjaCBzZXJpZXMgZG9lc24ndCBicmVhayBhbnl0aGluZywgDQpzb3JyeS4NCg0KSSBoYXZlIGp1 c3QgcmVwcm9kdWNlZCBhbiBpc3N1ZSBieSBidWlsZGluZyBsaWJ2aXJ0IGFjY29yZGluZyB0byB0 aGUgDQpzdGVwcyBpbiB0aGUgb3NzdGVzdCBidWlsZCBsb2cgKHRoaXMgd2FzIGEgZnVuKS4gRXhj ZXB0IGFuIGVycm9yIGJlaW5nIA0KcmVwb3J0ZWQgYnkgdGVzdCB0aGVyZSBpcyBvbmUgbW9yZSwg YWxtb3N0IHRoZSBzaW1pbGFyIHRvIHJlcG9ydGVkIG9uZSwgDQppbiBsaWJ4bFVwZGF0ZURpc2tE ZWYoKSBidXQgdGhlcmUgc3dpdGNoIGRvZXNuJ3QgY29udGFpbiBhIGRlZmF1bHQgYnJhbmNoLg0K DQpXaXRoIHRoYXQgZGlmZiBJIHdhcyBhYmxlIHRvIGJ1aWxkIHcvbyBpc3N1ZXMuDQoNCmRpZmYg LS1naXQgYS9zcmMvbGlieGwvbGlieGxfY29uZi5jIGIvc3JjL2xpYnhsL2xpYnhsX2NvbmYuYw0K aW5kZXggOGU2M2Q0MDM3Ni4uNjc0NTIxMmFlOCAxMDA2NDQNCi0tLSBhL3NyYy9saWJ4bC9saWJ4 bF9jb25mLmMNCisrKyBiL3NyYy9saWJ4bC9saWJ4bF9jb25mLmMNCkBAIC0xMjE5LDYgKzEyMTks NyBAQCBsaWJ4bFVwZGF0ZURpc2tEZWYodmlyRG9tYWluRGlza0RlZlB0ciBsX2Rpc2ssIA0KbGli eGxfZGV2aWNlX2Rpc2sgKnhfZGlzaykNCiDCoMKgwqDCoMKgwqDCoMKgIGRyaXZlciA9ICJwaHki Ow0KIMKgwqDCoMKgwqDCoMKgwqAgYnJlYWs7DQogwqDCoMKgwqAgY2FzZSBMSUJYTF9ESVNLX0JB Q0tFTkRfVU5LTk9XTjoNCivCoMKgwqAgY2FzZSBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9O RToNCiDCoMKgwqDCoMKgwqDCoMKgIGJyZWFrOw0KIMKgwqDCoMKgIH0NCiDCoMKgwqDCoCBpZiAo ZHJpdmVyKQ0KZGlmZiAtLWdpdCBhL3NyYy9saWJ4bC94ZW5feGwuYyBiL3NyYy9saWJ4bC94ZW5f eGwuYw0KaW5kZXggZjlkYzE4YWIxOC4uYTU1ODcxYmI1NiAxMDA2NDQNCi0tLSBhL3NyYy9saWJ4 bC94ZW5feGwuYw0KKysrIGIvc3JjL2xpYnhsL3hlbl94bC5jDQpAQCAtNzk2LDYgKzc5Niw3IEBA IHhlblBhcnNlWExEaXNrKHZpckNvbmZQdHIgY29uZiwgdmlyRG9tYWluRGVmUHRyIGRlZikNCiDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZ290byBmYWls Ow0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdmlyRG9tYWluRGlz a1NldFR5cGUoZGlzaywgVklSX1NUT1JBR0VfVFlQRV9CTE9DSyk7DQogwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBicmVhazsNCivCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgY2FzZSBMSUJYTF9ESVNLX0JBQ0tFTkRfU1RBTkRBTE9ORToNCiDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkZWZhdWx0Og0KIMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqAgdmlyUmVwb3J0RXJyb3IoVklSX0VSUl9DT05GSUdfVU5TVVBQT1JU RUQsDQogwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBfKCJkaXNrIGJhY2tlbmQgbm90IHN1cHBvcnRlZDogJXMiKSwN Cg0KDQo+DQo+IENoZWVycywNCj4NCj4gWzFdIA0KPiBodHRwczovL3VybGRlZmVuc2UuY29tL3Yz L19faHR0cHM6Ly94ZW5iaXRzLnhlbi5vcmcvZ2l0d2ViLz9wPWxpYnZpcnQuZ2l0O2E9YmxvYjtm PXNyYypsaWJ4bCp4ZW5feGwuYztoPWY5ZGMxOGFiMThiMjA4ZDMxOTI4MmNlNDIyZjQ2Yzc1MTM1 YzA2NzM7aGI9cmVmcypoZWFkcyp4ZW4tdGVzdGVkLW1hc3RlcipsNzc5X187THk4dkx5TSEhR0Zf MjlkYmNRSVVCUEEhMkludHBPWEg5NWlCalZnSHFaOEhfMC1vdG5JN1B3ektiTFZTZjZEZzN2c3l4 a3JRT2lKUVBqUFNxSmxpR29QdWFmMUpYbXN6TWxLbG9UY0ZVRFlCT0EkIA0KPiBbeGVuYml0c1su XXhlblsuXW9yZ10NCj4NCi0tIA0KUmVnYXJkcywNCg0KT2xla3NhbmRyIFR5c2hjaGVua28NCg== From xen-devel-bounces@lists.xenproject.org Fri Jul 29 09:34:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 09:34:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377438.610644 (Exim 4.92) (envelope-from ) id 1oHMNk-0000EU-1y; Fri, 29 Jul 2022 09:34:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377438.610644; Fri, 29 Jul 2022 09:34:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMNj-0000EN-V9; Fri, 29 Jul 2022 09:34:07 +0000 Received: by outflank-mailman (input) for mailman id 377438; Fri, 29 Jul 2022 09:34:07 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMNj-0000EH-1V for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 09:34:07 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 96c1771b-0f21-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 11:34:05 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id os14so7542199ejb.4 for ; Fri, 29 Jul 2022 02:34:05 -0700 (PDT) Received: from [192.168.1.93] (adsl-237.176.58.138.tellas.gr. [176.58.138.237]) by smtp.gmail.com with ESMTPSA id 17-20020a170906211100b0072af2460cd6sm1468903ejt.30.2022.07.29.02.34.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 02:34:04 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 96c1771b-0f21-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=Y2Wz/fGSfC4Yndoab6IP3Nuu1Cre9LOqctbIL8IkPSo=; b=N8F6JWLrQhsC8BYB6Be2BoGV2CAvKG4VABAU1PqgR3+mUIXdb/sQh9s0wTazMSJq9N 1I5x4Ots1m1gAFp4awJZtNZDDzZyZ7oK4/UUm001kRaLf6VIC0g/bm/9HI2P1lcNYBVI au32br08imT480ka+R94JzHfpb1qwitjw+fn+50sWPg6affQfb4L8SqgzxiZ0n6rnLSB wSq8U3flvTLqXvrkbNOwt5JHpzfDghZBGgWCidQVMRXKIw382M7BhwNQB6Z8LZVVwvfE nJBEd1C2VmtWREtHGnUORBxADq6f6jY/2PXwtl5FYS+nXfwIWEtQSHmfA3K76igt1+0W kGvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=Y2Wz/fGSfC4Yndoab6IP3Nuu1Cre9LOqctbIL8IkPSo=; b=Y/OYysAldtqsTU9zZx+WxdZogwR6pJqFA8S529IXNX3eMS+VjUyZj+RHIHaiboUsSt PJZzE4MRWz/86iD91dWtRBswdm63jkSxcunFtuGvWOCTg7qKzxRhNka7//23KXMhf04u gRveuUDMVaOqqjuuQqP50zcOqBt+BkXo5NvRSkkdCDL0neBOuJ1KTPDE4QOsTEfV6mwB 0sLIzD8AGXofw9gAFbsD/M0TwaE+BEJ1yipn1DjdgQRtTtOWk17b1raZUcU7oI3DZWQX e4KKe4wr8q5vOUbYOz+LMcLNAt9BCAMQiEYhyryVd5dZ67rTKk0z8Jo5SoUyzvLf3uVj 6R6g== X-Gm-Message-State: AJIora+W1IkED2jupRsZS1OEPq7v0l8Uqi9i81s6h4ilFJemE7D69gBg E8uVrL1qrwfSKMQttFsidAA= X-Google-Smtp-Source: AGRyM1sQkT4slRmoUqT6YMrban3LsJFRYjldRuvIMN1OvyJt2Ey2Iddaf2F4y0TByswOgJhJUxh0hA== X-Received: by 2002:a17:907:3f27:b0:72b:838e:f104 with SMTP id hq39-20020a1709073f2700b0072b838ef104mr2250272ejc.63.1659087244766; Fri, 29 Jul 2022 02:34:04 -0700 (PDT) Message-ID: <6b239efa-14ff-2a5e-0828-7f62c82487e6@gmail.com> Date: Fri, 29 Jul 2022 12:34:02 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH] xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation Content-Language: en-US To: Jan Beulich , Julien Grall Cc: Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org, Stefano Stabellini References: <20220728134943.1185621-1-burzalodowa@gmail.com> <0a8ff178-280d-717f-dacb-4eb9f57a24eb@xen.org> <83c17bf6-b9b2-a297-6f7f-dd08231d0f90@suse.com> <69942917-f2e9-718e-094d-9b01aea16a4a@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/22 10:22, Jan Beulich wrote: > On 29.07.2022 09:01, Xenia Ragiadakou wrote: >> On 7/29/22 09:16, Jan Beulich wrote: >>> On 29.07.2022 07:23, Xenia Ragiadakou wrote: >>>> On 7/29/22 01:56, Stefano Stabellini wrote: >>>>> On Thu, 28 Jul 2022, Julien Grall wrote: >>>>>> On 28/07/2022 15:20, Jan Beulich wrote: >>>>>>> On 28.07.2022 15:56, Julien Grall wrote: >>>>>>>> On 28/07/2022 14:49, Xenia Ragiadakou wrote: >>>>>>>>> --- a/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>>> +++ b/xen/arch/arm/include/asm/arm64/sysregs.h >>>>>>>>> @@ -461,7 +461,7 @@ >>>>>>>>> /* Access to system registers */ >>>>>>>>> #define WRITE_SYSREG64(v, name) do { \ >>>>>>>>> - uint64_t _r = v; \ >>>>>>>>> + uint64_t _r = (v); \ >>>>>>>> >>>>>>>> I am failing to see why the parentheses are necessary here. Could you >>>>>>>> give an example where the lack of them would end up to different code? >>>>>>> >>>>>>> I think it is merely good practice to parenthesize the right sides of =. >>>>>>> Indeed with assignment operators having second to lowest precedence, and >>>>>>> with comma (the lowest precedence one) requiring parenthesization at the >>>>>>> macro invocation site, there should be no real need for parentheses here. >>>>>> >>>>>> I am not really happy with adding those parentheses because they are >>>>>> pointless. But if there are a consensus to use it, then the commit message >>>>>> should be updated to clarify this is just here to please MISRA (to me "need" >>>>>> implies it would be bug). >>>>> >>>>> Let me premise that I don't know if this counts as a MISRA violation or >>>>> not. (Also I haven't checked if cppcheck/eclair report it as violation.) >>>>> >>>>> But I think the reason for making the change would be to follow our >>>>> coding style / coding practices. It makes the code simpler to figure out >>>>> that it is correct, to review and maintain if we always add the >>>>> parenthesis even in cases like this one where they are not strictly >>>>> necessary. We are going to save our future selves some mental cycles. >>>>> >>>>> So the explanation on the commit message could be along those lines. >>>> >>>> First, the rule 20.7 states "Expressions resulting from the expansion of >>>> macro parameters shall >>>> be enclosed in parentheses". So, here it is a clear violation of the >>>> rule because the right side of the assignment operator is an expression. >>>> >>>> Second, as I stated in a previous email, if v is not enclosed in >>>> parentheses, I could write the story of my life in there and compile it >>>> :) So, it would be a bug. >>>> >>>> So, I recommend the title and the explanation i.e >>>> "xen/arm64: sysreg.h: Fix MISRA C 2012 Rule 20.7 violation >>>> >>>> The macro parameter 'v' is used as an expression and needs to be enclosed in >>>> parentheses." >>>> to remain as is because they are accurate. >>> >>> I'm afraid you're following the MISRA wording too much to the latter. >>> Earlier on you agreed that when macro parameters are used as function >>> arguments, the parentheses can be omitted. Yet by what you say above >>> those are also expressions. >> >> Yes, those are also expressions (that's why I added parentheses >> initially) and I agreed with you that the parentheses there may not be >> necessary because I could not think of an example that will produce >> different behaviors with and without the parentheses. This will need a >> formal deviation I imagine or maybe a MISRA C expert could provide a >> justification regarding why parentheses are needed around function >> arguments that we may have not think of. >> With the example that Jan provided I just realized, if function arguments are not parenthesized, somebody could alter the rest of the arguments with which a function is called via an intermediate macro ... a rather far fetched example but still ... >>> As indicated before - I think parentheses >>> are wanted here, but it's strictly "wanted", and hence the title >>> better wouldn't say "fix" (but e.g. "improve") and the description >>> also should be "softened". >>> >> >> Regarding the latter, are you saying that the parentheses are not needed? >> In my opinion they are needed to prevent the bug described in the >> previous email i.e passing multiple statements to the macro. > > Any such use would be rejected during review, I'm sure. > > However I think there's another case which might indeed make this > more than just a "want" (and then responses further down are to be > viewed only in the context of earlier discussion): > > #define wr(v) ({ \ > unsigned r_ = v; \ > asm("" :: "r" (r_)); \ > }) > > #define M x, y > > void test(unsigned x) { > wr(M); > } > > While this would result in an unused variable warning, it's surely > misleading (and less certain to be noticed during review) - which > is what Misra wants to avoid. Let's see what Julien thinks. > >> By whom are they wanted? I 'm afraid I cannot understand. > > By us as a community: This can be viewed as one of many agreements we > have on coding style. (As such it may want to be written down somewhere.) > >> Also, are you proposing to change the title into "Improve MISRA C 2012 >> Rule 20.7 violation" ? > > Obviously not. I was thinking of "improve to avoid ...". > > Jan -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 10:03:53 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 10:03:53 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377444.610655 (Exim 4.92) (envelope-from ) id 1oHMqJ-0004C4-AB; Fri, 29 Jul 2022 10:03:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377444.610655; Fri, 29 Jul 2022 10:03:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMqJ-0004Bx-7Z; Fri, 29 Jul 2022 10:03:39 +0000 Received: by outflank-mailman (input) for mailman id 377444; Fri, 29 Jul 2022 10:03:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHMqH-0004Br-R1 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 10:03:37 +0000 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [2607:f8b0:4864:20::62c]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b57eebc6-0f25-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 12:03:36 +0200 (CEST) Received: by mail-pl1-x62c.google.com with SMTP id w7so4145614ply.12 for ; Fri, 29 Jul 2022 03:03:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b57eebc6-0f25-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/LXI3L17+WtGu616rS/nHNIU6OsczQPnLRSBLTdg8kE=; b=VZatfwLi3AzAViuLuLgUSRFaJZQhrYImrUBRZgI7aF7WrnNbNt1PB3uRxMbOv6lzD7 9LmrMwQMEE2BZBE/nNbZojpLCrqlj4Bclg4CAIemoEXwfApjAIQnCPmEEojEnF60Ye5o UcVzl6OCE5efpYx3hyVbe4mdMxaFdGbMa1hlLVmP2qSLzgLh1waKilKdPsvyUe4gER+M 7MSZT1mr2EJ0VCP6rHDgX/+aOu3W0bsqK0tRS3eTGZ3ID5kIToha8qYrEFOXY/mMPSgM 4y1+bzY8wUJ0/OF3kog+33uVC9A3LD3OouVAvnCLdWrQzFkicqK07HEaS0Px4h3iw7+2 T9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/LXI3L17+WtGu616rS/nHNIU6OsczQPnLRSBLTdg8kE=; b=zuA13Z9LmGxueVjNCCr8LBKHus8Nd2iIxTqNIOi/S0xABcMbN59YaW8hj/q4Z/dE04 uH1WQvOmUp7gxYabewYkwpJVAXHndbdZh5X7/dg9r0tdWl2cSJKckKHQWXlCRF2IVC+C sBT4QtMsK2+ufp1nfwZitQflJH1EOeMjO6dKJQrMR2b/PQsHstQNnSbxQYThXOyW8pX8 Bl60uZalqCTooLKyO4QRz/5NUminL9vJ1hpWmRw7KLPKinAq6/DQgQa43Emj+/LMTNGj rRxnz3elvCQD7k+tD8ecHi2Er0SEGTpAtV5QG6RjylcOP4XWHvcS7SYjtRnOK4b1hKap XYqQ== X-Gm-Message-State: ACgBeo1c3k8VYEYLpHEo6nLaYZJNc17pKVtZfiKTT5Yrsei9SQVnkAqi sLrhjaIy0YB7g19DkaRPXPjxh5FHles43+gblhhrLkg4mUc= X-Google-Smtp-Source: AA6agR6ObIrIOOOd+uCaSudrMUFSObKxQZBbgP0XfZv7I+3y1Cg4rkggGnSkJ/cXuqMAHZF4eOHgb3KKKiSpRhRZXas= X-Received: by 2002:a17:902:f101:b0:16d:c0ae:acd5 with SMTP id e1-20020a170902f10100b0016dc0aeacd5mr3071809plb.70.1659089014391; Fri, 29 Jul 2022 03:03:34 -0700 (PDT) MIME-Version: 1.0 References: <20220622134219.1596613-1-jens.wiklander@linaro.org> <20220622134219.1596613-3-jens.wiklander@linaro.org> <25778cc8-b9d3-ac0d-b8e4-9a7be87d44bc@xen.org> <307cef37-e48f-e66f-3550-85c0c50cbb7e@xen.org> In-Reply-To: <307cef37-e48f-e66f-3550-85c0c50cbb7e@xen.org> From: Jens Wiklander Date: Fri, 29 Jul 2022 12:03:23 +0200 Message-ID: Subject: Re: [PATCH v4 2/2] xen/arm: add FF-A mediator To: Julien Grall Cc: xen-devel@lists.xenproject.org, Stefano Stabellini , Volodymyr Babchuk , Bertrand.Marquis@arm.com, Anthony PERARD , Juergen Gross , Wei Liu Content-Type: text/plain; charset="UTF-8" Hi, On Thu, Jul 28, 2022 at 9:15 PM Julien Grall wrote: > > Hi, > > On 26/07/2022 07:17, Jens Wiklander wrote: > > On Fri, Jul 8, 2022 at 3:41 PM Julien Grall wrote: > >> > >> Hi Jens, > >> > >> I haven't checked whether the FFA driver is complaint with the spec. I > >> mainly checked whether the code makes sense from Xen PoV. > >> > >> This is a fairly long patch to review. So I will split my review in > >> multiple session/e-mail. > >> > >> On 22/06/2022 14:42, Jens Wiklander wrote: > >>> Adds a FF-A version 1.1 [1] mediator to communicate with a Secure > >>> Partition in secure world. > >>> > >>> The implementation is the bare minimum to be able to communicate with > >>> OP-TEE running as an SPMC at S-EL1. > >>> > >>> This is loosely based on the TEE mediator framework and the OP-TEE > >>> mediator. > >>> > >>> [1] https://developer.arm.com/documentation/den0077/latest > >>> Signed-off-by: Jens Wiklander > >>> --- > >>> SUPPORT.md | 7 + > >>> tools/libs/light/libxl_arm.c | 3 + > >>> tools/libs/light/libxl_types.idl | 1 + > >>> tools/xl/xl_parse.c | 3 + > >> > >> These changes would need an ack from the toolstack maintainers. > > > > OK, I'll keep them in CC. > > > >> > >>> xen/arch/arm/Kconfig | 11 + > >>> xen/arch/arm/Makefile | 1 + > >>> xen/arch/arm/domain.c | 10 + > >>> xen/arch/arm/domain_build.c | 1 + > >>> xen/arch/arm/ffa.c | 1683 +++++++++++++++++++++++++++++ > >>> xen/arch/arm/include/asm/domain.h | 4 + > >>> xen/arch/arm/include/asm/ffa.h | 71 ++ > >>> xen/arch/arm/vsmc.c | 17 +- > >>> xen/include/public/arch-arm.h | 2 + > >>> 13 files changed, 1811 insertions(+), 3 deletions(-) > >>> create mode 100644 xen/arch/arm/ffa.c > >>> create mode 100644 xen/arch/arm/include/asm/ffa.h > >>> > >>> diff --git a/SUPPORT.md b/SUPPORT.md > >>> index 70e98964cbc0..215bb3c9043b 100644 > >>> --- a/SUPPORT.md > >>> +++ b/SUPPORT.md > >>> @@ -785,6 +785,13 @@ that covers the DMA of the device to be passed through. > >>> > >>> No support for QEMU backends in a 16K or 64K domain. > >>> > >>> +### ARM: Firmware Framework for Arm A-profile (FF-A) Mediator > >>> + > >>> + Status, Arm64: Tech Preview > >>> + > >>> +There are still some code paths where a vCPU may hog a pCPU longer than > >>> +necessary. The FF-A mediator is not yet implemented for Arm32. > >>> + > >>> ### ARM: Guest Device Tree support > >>> > >>> Status: Supported > >>> diff --git a/tools/libs/light/libxl_arm.c b/tools/libs/light/libxl_arm.c > >>> index eef1de093914..a985609861c7 100644 > >>> --- a/tools/libs/light/libxl_arm.c > >>> +++ b/tools/libs/light/libxl_arm.c > >>> @@ -101,6 +101,9 @@ int libxl__arch_domain_prepare_config(libxl__gc *gc, > >>> return ERROR_FAIL; > >>> } > >>> > >>> + config->arch.ffa_enabled = > >>> + libxl_defbool_val(d_config->b_info.arch_arm.ffa_enabled); > >>> + > >>> return 0; > >>> } > >>> > >>> diff --git a/tools/libs/light/libxl_types.idl b/tools/libs/light/libxl_types.idl > >>> index 2a42da2f7d78..bf4544bef399 100644 > >>> --- a/tools/libs/light/libxl_types.idl > >>> +++ b/tools/libs/light/libxl_types.idl > >>> @@ -646,6 +646,7 @@ libxl_domain_build_info = Struct("domain_build_info",[ > >>> > >>> ("arch_arm", Struct(None, [("gic_version", libxl_gic_version), > >>> ("vuart", libxl_vuart_type), > >>> + ("ffa_enabled", libxl_defbool), > >> > >> This needs to be accompagnied with a define LIBXL_HAVE_* in > >> tools/include/libxl.h. Please see the examples in the header. > > > > OK, I'll add something. I'm not entirely sure how this is used so I'm > > afraid it will be a bit of Cargo Cult programming from my side. > > The LIBXL_HAVE* by toolstack built on top of libxl (like virtio) to know > whether a future is supported by the current library. > > [...] > > >> > >>> + > >>> +static inline uint64_t reg_pair_to_64(uint32_t reg0, uint32_t reg1) > >>> +{ > >>> + return (uint64_t)reg0 << 32 | reg1; > >>> +} > >>> + > >>> +static void inline reg_pair_from_64(uint32_t *reg0, uint32_t *reg1, > >>> + uint64_t val) > >>> +{ > >>> + *reg0 = val >> 32; > >>> + *reg1 = val; > >>> +} > >> > >> Those two functions are the same as optee.c but with a different. I > >> would rather prefer if we avoid the duplication and provide generic > >> helpers in a pre-requisite. > > > > These functions are trivial but at the same time for a special purpose > > which happens to coincide with the usage in optee.c. I can't find a > > suitable common .h file and creating a new one seems a bit much. > > I would implement it in regs.h. OK, thanks. > > [...] > > >>> + .a4 = pg_count, > >>> + }; > >>> + struct arm_smccc_1_2_regs resp; > >>> + > >>> + /* > >>> + * For arm64 we must use 64-bit calling convention if the buffer isn't > >>> + * passed in our tx buffer. > >>> + */ > >> > >> Can you explain why we would want to use the 32-bit calling convention > >> if addr is 0? > > > > I was trying to avoid the 64-bit calling convention where possible, > > OOI, why are you trying to avoid the 64-bit calling convention? To make it easier to support a use-case where the SPMC is using AArch32, but I'm not sure it's realistic any longer. Cheers, Jens From xen-devel-bounces@lists.xenproject.org Fri Jul 29 10:25:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 10:25:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377456.610667 (Exim 4.92) (envelope-from ) id 1oHNBA-0006zW-5A; Fri, 29 Jul 2022 10:25:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377456.610667; Fri, 29 Jul 2022 10:25:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNBA-0006zP-2L; Fri, 29 Jul 2022 10:25:12 +0000 Received: by outflank-mailman (input) for mailman id 377456; Fri, 29 Jul 2022 10:25:10 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNB7-0006yM-Qq for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 10:25:10 +0000 Received: from mx0a-0039f301.pphosted.com (mx0a-0039f301.pphosted.com [148.163.133.242]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b77b4246-0f28-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 12:25:08 +0200 (CEST) Received: from pps.filterd (m0174676.ppops.net [127.0.0.1]) by mx0a-0039f301.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 26TA3qol001703; Fri, 29 Jul 2022 10:25:06 GMT Received: from eur02-am5-obe.outbound.protection.outlook.com (mail-am5eur02lp2051.outbound.protection.outlook.com [104.47.4.51]) by mx0a-0039f301.pphosted.com (PPS) with ESMTPS id 3hmbqc0gt2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 29 Jul 2022 10:25:06 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com (2603:10a6:10:ed::15) by DB6PR0301MB2486.eurprd03.prod.outlook.com (2603:10a6:4:5a::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12; Fri, 29 Jul 2022 10:25:02 +0000 Received: from DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21]) by DB8PR03MB6108.eurprd03.prod.outlook.com ([fe80::d87f:d45e:b2c6:c21%6]) with mapi id 15.20.5482.012; Fri, 29 Jul 2022 10:25:02 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b77b4246-0f28-11ed-924f-1f966e50362f ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IesCCixaJnDCa3zCTaSRc2ZjJ4tQEU7grEJNyLIIEUNprTy6cTjQN2Tsfsng7VBa4mC8Ljv2fmNSjHna/LfAVVVqgG7sw8r67Q3AlvjsY8dAP+gqlqlaZECfaB8zOR2dg0EeaxQLh+bd1lcGuGTEYlYHW1FmRp2DtghQfsOUQy9O+x9Dhb/uIHQTGgxh15RWuAh8ae2B/FsgmHhC0piegKmbAH+KDDP15FOXm/Q61imdRWT18Rl5onnFnwoxMuRxnCkAFF9ntXhy9FvCFu9OFNuSOlHsY/nZJ6Ar4LAMKM45aUTvZHgMshGl1K8Kcad2hIdRkCLoeHwJwj6qzaptDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AkEKCKCjmo1qIi95/7ZEiK0WMyF6Xiggp8cqutgacYU=; b=Unq/K/2hglQsREz0JkwiLI+Tx1gU0n8m3nFbPYWDWXvXPb8LnnBkkNxSoMQhrf/hw4+JkosEjps4kXZxgIpNEHQbqz7sic8VxHuzJH2j1FMvO5rdOgJldrLOd3UiFh5fyQx3n1+dY6pR0Kz3sow6xrajqyup9uVs52Ff7KFacHyRcYk1fHfvShcg0Fp26CbB+a3rDpnK4FlvR23dnrpfg/hG175Ot3Gi8WzOXN3/pmhhx8ECfyMuDbJdx8/Aco3E2V9JHzS3/kvl4fhE4v9T/MRgp/V6Bqb7nWgknzqvoi998v7YnQ0N/3pyh33O9FP+UWWg+9eQe8JQPzhTPrBGTw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=epam.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AkEKCKCjmo1qIi95/7ZEiK0WMyF6Xiggp8cqutgacYU=; b=nrQqejoTc7Pv/NNcXIBolQUpAqjbQqrdcCPlVxSVr/DGrEQ2dD6Z6Hzsb9xy5yn6r44mAzYomABLm2SgPAFE0IWdJKAnNTthMIwNclJw3PGs8Z/H1OBVv0qHTAYY1CuUGv319aHVSgA+FHVDvYIpljRmCPfxxg29uD8z5T0huxyrGfASPwNmS3IpsXXG8qJm/LunlEVIXJ8rOgns+eu4wcKb4AF9j1em4Y/RVqTLh+rDryk+6khq23vE1MUymFCjB1kVnQ12Mk3iROgeB8/H7mNBkkh1gbEmtVvEFphQgmiMaxbKFcNl7S83nntuCIRUemyfs/FUrISIeDnKxMFf0A== From: Oleksandr Tyshchenko To: Julien Grall CC: osstest service owner , "xen-devel@lists.xenproject.org" , Anthony PERARD , Jan Beulich Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Topic: [xen-unstable-smoke bisection] complete build-amd64-libvirt Thread-Index: AQHYoxOqDyECYNTY4EqwTkq/MCO2na2U6EAAgAAnEgCAABVzAA== Date: Fri, 29 Jul 2022 10:25:02 +0000 Message-ID: <0fa56cfe-85dc-5fd2-6405-e18115420306@epam.com> References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> In-Reply-To: Accept-Language: en-US, ru-RU Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5ad0726d-e4a6-4041-f22f-08da714c9912 x-ms-traffictypediagnostic: DB6PR0301MB2486:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sWzxNuvdCcJTZ6mFnib1uOGiL3PbpLSGdAIC2mYYZvEqTUNAk529mjp3lwWqmj0gNsYIDu5obJGmctg7fI+AAS6LgXchUANfKy1VbvzcdywQyx8DBoSRnKlL9CKs2MhXHNCmkgOctsaEkWbM4j5SWjbX8E08SkpiXwhQOJjzyzyXLQA9Bw1h9AfOh20uQIBHTquNJIujwl7CsDu659OiSSks9SK302KTPApVoI87Vu0Xi2Ui08Ht4/cnjAndgxwlTJjnOH4y5NPpErcXzPvn7aNKE5BAoZQSUI19+i+jal/pycFOIn7OiOu2mbQ1OLFkQjEgMDUmTMeqnmDSFhY2/B/tCNgRxJHqPMCgn2ZLzcLLxqnlpxTGDwCQtECOiGNtv9UY4i095uoPOiHT3ztMz9lPMYBlla5rlUSf0pSrDK+MbLddj5o2b5JgNG8wQw1XgeMJbGPbv3uKfPgmeJslq7A/SAnLwi89u8kpj/qby5mNWv3Q9XpOrVV7zKREfWfLzjghVSyabOednVzcxL8+amiAJhR2erWIGTOFKjoz/l/Uz0jXl9hEpmjt4rLssjoPNzFeV5WWlCm//tprYnCSljC0dmX2hlzZJjZSnzLsdJ7zgKsuSGxJvZX0R97tlO818cQdFk5y10vQOfl4aIH1tP5wqNehQPKB0DFp9TDPD5qtmGbf1KqXbOm7ER/RZhtvJ/kYAfl3y5uwj3XJyjx5YJImRMKTtm9G+w9ELGM7yqY7hk5FaHkCZn7rwlVA9en2eJsE6e+xL8LIYaacaB6I9dic9Xkq87tTI5x3jE/1T+zo2bmztd2eETN+pttXfw9/uxcujT9nP1MOti5snGo8VA8JhVyIQGPMhXjkY5cDA8oZCm1Vmk8c+USlgqY3Fy+9 x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR03MB6108.eurprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(366004)(396003)(376002)(136003)(346002)(186003)(2616005)(83380400001)(54906003)(6916009)(55236004)(6512007)(6506007)(26005)(31686004)(53546011)(2906002)(36756003)(41300700001)(76116006)(38100700002)(38070700005)(31696002)(86362001)(8936002)(5660300002)(71200400001)(4326008)(66556008)(66446008)(64756008)(8676002)(66476007)(478600001)(316002)(966005)(6486002)(91956017)(122000001)(66946007)(45980500001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?YkNjNGZYU0FHMnVKYkUwVHJ2aUVJZXQvbXhZQTR0ZnR4WGl5d3YyUmQ0Nlc1?= =?utf-8?B?VWI5TE9vZjZWQzJwVmhpUGhPYzVyZU9PNTRmbkdCVXc1aVNjMjRFUVZ5emVJ?= =?utf-8?B?T1J4MGdQemhWY0s3OFFaV2ZFdHFZbHVIanVyQVlOWGVZa2pWcFNzZzJCM3F0?= =?utf-8?B?WnZ0V0ZrdGt1NitmbXlXdkdWTXd5L3U5V0hvUWdKdVIvekgyQ1BBbW00RXVE?= =?utf-8?B?c091NWZqcHJNRWk3S01pS0dBZmJBUzE1eTd0ZHFyYmRGZ1NtZUFWUTBhZ2J0?= =?utf-8?B?VUpQNlpSNDlKZjJDQW9TTGdXeml4Yk9td1R0MWErT0NwV1ZNUzJSTzdERURS?= =?utf-8?B?Y1AzdDdjQTl3Y3lhVTVuVk5IYldtZC9KUm0rNjdQZ1Z2TEk0T3VJTVIyUGp3?= =?utf-8?B?UTJmZ0p5Yy9kdFJxVWlaRVNxY1N3eFVKcGw0bERHMlM4bnh6UUxoMnZieDVH?= =?utf-8?B?Wk9MZEtUZlFIRDNoemJVaUZiTDk4eEx2YXBNOWlaR0gxWDk4dFUyMENWTkVa?= =?utf-8?B?K2lTcTM3L3gyZ1JaVVZQR0haRzV2YmZ4eEU2Vzk0ZnY5S3I4UHNFeE0yUWRr?= =?utf-8?B?bXB4Z0NGcllBMDNyekRDSU51T0REUUZLcUpXS3RNekFXZnJ2dUt2TXdCa1ZS?= =?utf-8?B?aSs0R3NCYzR3TVlWb3dIVEFQVFVCVGlZVGRETWJVVFJNK3dsRXlYSXk2Ylh2?= =?utf-8?B?elpQQ1lnRWZZenB1elo4S3RwRVQzMzcxeDE5TXI1dUl1cktXcXMxRTdiRmx0?= =?utf-8?B?NXBKem1DM3VPOUZVb2p0dmlZakJUbWdGQ0ZlNDZBaUN3YURqbUVCWEFSMjE5?= =?utf-8?B?eXFVR3ppbzJCZ0RWdlB1T2tzcVA1QzhDN2xidFNiSzhGZnhvY1Iwdm5DMFI0?= =?utf-8?B?dDZ5OWh3UGNtSmJLaElyL3UrbnBEYzQ4Nk1rZk9FeVVRdHVGVzdzeCtSTlF6?= =?utf-8?B?Q04xYnl0RmV2dGFjdDd3cnRlQ2xCclNDTEsvMTQxYXFSN0kyMkpmZkY4ZUIz?= =?utf-8?B?SmVGdnAzRXJ3WjZPNHdUc3MyWTdUaEl0S3pxYnBRWkV0a0JMYThwSmdpTXBJ?= =?utf-8?B?WDZQTHR5Z0ZWY2RQTWs4RVFkSkVJaFg2K3hYMlBKdGQ1NjNMbEU2YnZXMlc3?= =?utf-8?B?a1d1dVZDZ3NjKzJoWXVoeUduVGdCOTB2NE1oeUI0ZG9nUTU1a09MQXY4bUFC?= =?utf-8?B?ME1UVTcyMmJqVVBVZWNCaEJrQUpuZlRSUkozc2V4ZElteStXQlNHRFJXUDZO?= =?utf-8?B?YzViS0VaMjRtcDZHeTR1cXhMcDE3eTEzekZOYXhkTFNWNnRWS3lWREdvc0dE?= =?utf-8?B?S0JSd1pZNjhwWk5UeVZhRXhYb1lIRi83MkNOVEtodDYvc3ZMUThwczVsZ29r?= =?utf-8?B?emJzaVVlazZ4VkZ5SHRZOEI4VEFzMFM5OUVxakdLQ0ZoUjlMdkVTWDZUMEh0?= =?utf-8?B?QXBad3BXbm9iaVNBS2pCVlNOajJJWVJ2ZnVGekNjeWRZOENVWUNQSzQ1NXQ0?= =?utf-8?B?dXcxdnlxVGVrelZTM05qQ0EzM0wvczNCNjArcUVoMjVxc0NHOXVESEwwaWgz?= =?utf-8?B?bEFKMFI3QXpUb0RSRWlva1lnemdQQ1FLWUdSNWIxcHMvTGRuWnFqSnBoT0lz?= =?utf-8?B?MG5KTzdiY0hESWRUb0lHQTlYVjAxcFFpQ2JHR2E2WWkzaWhJNC95TS9wZmlV?= =?utf-8?B?OUFPb1JpdDdMQXdWbEkwUE11aDFTMkVrQS80Y2Q5cXhVaHp5YXh4dWJMdjhT?= =?utf-8?B?eE9QZTl4L3hRRDQ4ZzBZN0ZRSnBqZ3NCelZvUllIbUpiSC80TXM0NU5Peng0?= =?utf-8?B?TDJwWlFpNC9wdHBZRDRPWStFaG1TbGE3R0JaSldjT3J1ZzgxK3VZVXJuczJn?= =?utf-8?B?d2l4YmxlTHI5N1dIbnduUkZQRTdUSFJkeDIvcXJPQk5UTTJDQVZyWGlvajBN?= =?utf-8?B?U2ZERW8zSEFJMjZwRXB0OWIwb1BxNVFuK2UrcSt0MGJjR0J5aFlDM3ZPTVdj?= =?utf-8?B?V2czSkUyNHFuQ0ZpMUpHVFdBZHpFblNCbzRDMUo3UmdiNWhvM0xoZWhzT3JC?= =?utf-8?B?b3Uvb091UGE5Q0ZYMDc2L2RNc3R0S2h1Z0FWV3JBQTBmdUszZlhRS2ltVk9x?= =?utf-8?B?SXlKdFFKaU1CMWlxNDgvblVmVmxKY2FuQkhubkR4STlHWmlKc1ZRN3N2dzVp?= =?utf-8?Q?OUDLKKvNVVt+ZQJq2kSZYQo=3D?= Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-OriginatorOrg: epam.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DB8PR03MB6108.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad0726d-e4a6-4041-f22f-08da714c9912 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jul 2022 10:25:02.5799 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b41b72d0-4e9f-4c26-8a69-f949f367c91d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jT9+Apn7T5LbSqoP5Vcq0cKx1rhluJrf2jXSachEG5qKM3W82nnXlQykxNXnbr9KvWGS5m2jUkAjg55d8bWxf1CPzjBiCXHnIv4HNLwxoNw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0301MB2486 X-Proofpoint-GUID: CjZi3pck7IjfysGmO0Df0DX3g6ozfZbC X-Proofpoint-ORIG-GUID: CjZi3pck7IjfysGmO0Df0DX3g6ozfZbC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-07-28_06,2022-07-28_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 priorityscore=1501 mlxscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000 definitions=main-2207290045 DQpPbiAyOS4wNy4yMiAxMjowOCwgSnVsaWVuIEdyYWxsIHdyb3RlOg0KDQoNCkhlbGxvIEp1bGll bg0KDQo+ICgrIEFudGhvbnkpDQo+DQo+IEhpLA0KPg0KPiBPbiAyOS8wNy8yMDIyIDA3OjQ4LCBP bGVrc2FuZHIgVHlzaGNoZW5rbyB3cm90ZToNCj4+DQo+PiBPbiAyOS4wNy4yMiAwOToyMiwgSmFu IEJldWxpY2ggd3JvdGU6DQo+Pg0KPj4gSGVsbG8gSmFuDQo+Pg0KPj4+IE9uIDI5LjA3LjIwMjIg MDM6MDQsIG9zc3Rlc3Qgc2VydmljZSBvd25lciB3cm90ZToNCj4+Pj4gYnJhbmNoIHhlbi11bnN0 YWJsZS1zbW9rZQ0KPj4+PiB4ZW5icmFuY2ggeGVuLXVuc3RhYmxlLXNtb2tlDQo+Pj4+IGpvYiBi dWlsZC1hbWQ2NC1saWJ2aXJ0DQo+Pj4+IHRlc3RpZCBsaWJ2aXJ0LWJ1aWxkDQo+Pj4+DQo+Pj4+ IFRyZWU6IGxpYnZpcnQgZ2l0Oi8veGVuYml0cy54ZW4ub3JnL2xpYnZpcnQuZ2l0DQo+Pj4+IFRy ZWU6IGxpYnZpcnRfa2V5Y29kZW1hcGRiIA0KPj4+PiBodHRwczovL3VybGRlZmVuc2UuY29tL3Yz L19faHR0cHM6Ly9naXRsYWIuY29tL2tleWNvZGVtYXAva2V5Y29kZW1hcGRiLmdpdF9fOyEhR0Zf MjlkYmNRSVVCUEEhMHNfbnlBZ2RzOTc3ZHcwZEdQZ0ZKR2tJYUJpS2lYSDNuUjExTmk2Z0dqTjVn UW1CMERFaEtybTVTVVg0UjBXaEs4WWtRZW1SNlJWaGlvanB6aWo5eUxNJCANCj4+Pj4gW2dpdGxh YlsuXWNvbV0NCj4+Pj4gVHJlZTogcWVtdSBnaXQ6Ly94ZW5iaXRzLnhlbi5vcmcvcWVtdS14ZW4t dHJhZGl0aW9uYWwuZ2l0DQo+Pj4+IFRyZWU6IHFlbXV1IGdpdDovL3hlbmJpdHMueGVuLm9yZy9x ZW11LXhlbi5naXQNCj4+Pj4gVHJlZTogeGVuIGdpdDovL3hlbmJpdHMueGVuLm9yZy94ZW4uZ2l0 DQo+Pj4+DQo+Pj4+ICoqKiBGb3VuZCBhbmQgcmVwcm9kdWNlZCBwcm9ibGVtIGNoYW5nZXNldCAq KioNCj4+Pj4NCj4+Pj4gwqDCoMKgIEJ1ZyBpcyBpbiB0cmVlOsKgIHhlbiBnaXQ6Ly94ZW5iaXRz Lnhlbi5vcmcveGVuLmdpdA0KPj4+PiDCoMKgwqAgQnVnIGludHJvZHVjZWQ6IDY2ZGQxYzYyYjJh M2M3MDdiZDVjNTU3NTBkMTBhODIyM2ZiZDU3N2YNCj4+Pj4gwqDCoMKgIEJ1ZyBub3QgcHJlc2Vu dDogZjczMjI0MGZkM2JhYzI1MTE2MTUxZGI1ZGRlYjcyMDNiNjJlODVjZQ0KPj4+PiDCoMKgwqAg TGFzdCBmYWlsIHJlcHJvOiANCj4+Pj4gaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHA6 Ly9sb2dzLnRlc3QtbGFiLnhlbnByb2plY3Qub3JnL29zc3Rlc3QvbG9ncy8xNzE5MDkvX187ISFH Rl8yOWRiY1FJVUJQQSEwc19ueUFnZHM5NzdkdzBkR1BnRkpHa0lhQmlLaVhIM25SMTFOaTZnR2pO NWdRbUIwREVoS3JtNVNVWDRSMFdoSzhZa1FlbVI2UlZoaW9qcG1ZQUJKa2MkIA0KPj4+PiBbbG9n c1suXXRlc3QtbGFiWy5deGVucHJvamVjdFsuXW9yZ10NCj4+Pj4NCj4+Pj4NCj4+Pj4gwqDCoMKg IGNvbW1pdCA2NmRkMWM2MmIyYTNjNzA3YmQ1YzU1NzUwZDEwYTgyMjNmYmQ1NzdmDQo+Pj4+IMKg wqDCoCBBdXRob3I6IE9sZWtzYW5kciBUeXNoY2hlbmtvIDxvbGVrc2FuZHJfdHlzaGNoZW5rb0Bl cGFtLmNvbT4NCj4+Pj4gwqDCoMKgIERhdGU6wqDCoCBGcmkgSnVsIDE1IDIyOjIwOjI0IDIwMjIg KzAzMDANCj4+Pj4gwqDCoMKgIMKgwqDCoMKgwqDCoMKgIGxpYnhsOiBBZGQgc3VwcG9ydCBmb3Ig VmlydGlvIGRpc2sgY29uZmlndXJhdGlvbg0KPj4+IEp1c3QgaW4gY2FzZSB5b3UgZGlkbid0IG5v dGljZSBpdDogU29tZXRoaW5nJ3Mgd3JvbmcgaGVyZS4gSSBkaWRuJ3QgDQo+Pj4gbG9vaw0KPj4+ IGF0IHRoZSBkZXRhaWxzIGF0IGFsbC4gUGxlYXNlIGFkdmlzZSB3aGV0aGVyIGEgZml4IHdpbGwg c29vbiBhcnJpdmUgb3INCj4+PiB3aGV0aGVyIHdlIHNob3VsZCByZXZlcnQgZm9yIHRoZSB0aW1l IGJlaW5nLg0KPj4NCj4+IFNvcnJ5IGZvciB0aGUgYnJlYWthZ2UuIEF0IHRoZSBtb21lbnQgSSBo YXZlIG5vIGlkZWEgd2hhdCBpcyB3cm9uZyBoZXJlLA0KPg0KPiBGcm9tIHRoZSBidWlsZCBsb2c6 DQo+DQo+IC4uLy4uL3NyYy9saWJ4bC94ZW5feGwuYzogSW4gZnVuY3Rpb24gJ3hlblBhcnNlWExE aXNrJzoNCj4gLi4vLi4vc3JjL2xpYnhsL3hlbl94bC5jOjc3OToxNzogZXJyb3I6IGVudW1lcmF0 aW9uIHZhbHVlIA0KPiAnTElCWExfRElTS19CQUNLRU5EX1NUQU5EQUxPTkUnIG5vdCBoYW5kbGVk IGluIHN3aXRjaCANCj4gWy1XZXJyb3I9c3dpdGNoLWVudW1dDQo+IMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIHN3aXRjaCAobGlieGxkaXNrLT5iYWNrZW5kKSB7DQo+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF5+fn5+fg0KPg0KPiBUaGUgc3dpdGNoIGNvbnRhaW5z IGEgZGVmYXVsdCBicmFuY2ggWzFdLCBzbyBJIGFtIGEgYml0IHB1enpsZWQgd2h5IA0KPiBHQ0Mg aXMgbm90IGhhcHB5IGhlcmUuDQoNCkxpYnZpcnQgc2VlbXMgdG8gY29tcGlsZWQgd2l0aCAtV3N3 aXRjaC1lbnVtDQoNCkFuZCBodHRwczovL2djYy5nbnUub3JnL29ubGluZWRvY3MvZ2NjL1dhcm5p bmctT3B0aW9ucy5odG1sIHNheXMgdGhlIA0KZm9sbG93aW5nOg0KDQoiLVdzd2l0Y2gtZW51bQ0K DQpXYXJuIHdoZW5ldmVyIGEgc3dpdGNoIHN0YXRlbWVudCBoYXMgYW4gaW5kZXggb2YgZW51bWVy YXRlZCB0eXBlIGFuZCANCmxhY2tzIGEgY2FzZSBmb3Igb25lIG9yIG1vcmUgb2YgdGhlIG5hbWVk IGNvZGVzIG9mIHRoYXQgZW51bWVyYXRpb24uIA0KY2FzZSBsYWJlbHMgb3V0c2lkZSB0aGUgZW51 bWVyYXRpb24gcmFuZ2UgYWxzbyBwcm92b2tlIHdhcm5pbmdzIHdoZW4gDQp0aGlzIG9wdGlvbiBp cyB1c2VkLiBUaGUgb25seSBkaWZmZXJlbmNlIGJldHdlZW4gLVdzd2l0Y2ggYW5kIHRoaXMgDQpv cHRpb24gaXMgdGhhdCB0aGlzIG9wdGlvbiBnaXZlcyBhIHdhcm5pbmcgYWJvdXQgYW4gb21pdHRl ZCBlbnVtZXJhdGlvbiANCmNvZGUgZXZlbiBpZiB0aGVyZSBpcyBhIGRlZmF1bHQgbGFiZWwuIg0K DQoNCltzbmlwXQ0KDQotLSANClJlZ2FyZHMsDQoNCk9sZWtzYW5kciBUeXNoY2hlbmtvDQo= From xen-devel-bounces@lists.xenproject.org Fri Jul 29 10:29:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 10:29:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377463.610678 (Exim 4.92) (envelope-from ) id 1oHNEy-0007u1-Pj; Fri, 29 Jul 2022 10:29:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377463.610678; Fri, 29 Jul 2022 10:29:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNEy-0007tu-Mt; Fri, 29 Jul 2022 10:29:08 +0000 Received: by outflank-mailman (input) for mailman id 377463; Fri, 29 Jul 2022 10:29:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNEy-0007to-44 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 10:29:08 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNEv-0008MY-M7; Fri, 29 Jul 2022 10:29:05 +0000 Received: from [54.239.6.186] (helo=[192.168.0.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHNEv-0007PF-GC; Fri, 29 Jul 2022 10:29:05 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=mrIF4+c4gg6d6S42D/KMAa4cg223BgXiTpyycRt+Ghg=; b=oZp1aGiXtsWJP6GcY6N+7US9I1 tlECyLZaFC5qijry1xQxY5nzK5y4lxAPsYdZQrcQtKJwGOk04oC7lSKVUFF6+NkNg3v3OEiGeZYVd hNDgzQor7pSrHCsQjNOClaKtPbix0fQ9t2+wDtYK78Bi5GpO1debJJbCAxncd8e7k9x4=; Message-ID: <0adaeec4-d810-f235-b3a0-951610db216a@xen.org> Date: Fri, 29 Jul 2022 11:29:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Content-Language: en-US To: Oleksandr Tyshchenko Cc: osstest service owner , "xen-devel@lists.xenproject.org" , Anthony PERARD , Jan Beulich References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> <0fa56cfe-85dc-5fd2-6405-e18115420306@epam.com> From: Julien Grall In-Reply-To: <0fa56cfe-85dc-5fd2-6405-e18115420306@epam.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Oleksandr, On 29/07/2022 11:25, Oleksandr Tyshchenko wrote: > > On 29.07.22 12:08, Julien Grall wrote: > > > Hello Julien > >> (+ Anthony) >> >> Hi, >> >> On 29/07/2022 07:48, Oleksandr Tyshchenko wrote: >>> >>> On 29.07.22 09:22, Jan Beulich wrote: >>> >>> Hello Jan >>> >>>> On 29.07.2022 03:04, osstest service owner wrote: >>>>> branch xen-unstable-smoke >>>>> xenbranch xen-unstable-smoke >>>>> job build-amd64-libvirt >>>>> testid libvirt-build >>>>> >>>>> Tree: libvirt git://xenbits.xen.org/libvirt.git >>>>> Tree: libvirt_keycodemapdb >>>>> https://urldefense.com/v3/__https://gitlab.com/keycodemap/keycodemapdb.git__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpzij9yLM$ >>>>> [gitlab[.]com] >>>>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git >>>>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git >>>>> Tree: xen git://xenbits.xen.org/xen.git >>>>> >>>>> *** Found and reproduced problem changeset *** >>>>> >>>>>     Bug is in tree:  xen git://xenbits.xen.org/xen.git >>>>>     Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>>>>     Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce >>>>>     Last fail repro: >>>>> https://urldefense.com/v3/__http://logs.test-lab.xenproject.org/osstest/logs/171909/__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpmYABJkc$ >>>>> [logs[.]test-lab[.]xenproject[.]org] >>>>> >>>>> >>>>>     commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>>>>     Author: Oleksandr Tyshchenko >>>>>     Date:   Fri Jul 15 22:20:24 2022 +0300 >>>>>             libxl: Add support for Virtio disk configuration >>>> Just in case you didn't notice it: Something's wrong here. I didn't >>>> look >>>> at the details at all. Please advise whether a fix will soon arrive or >>>> whether we should revert for the time being. >>> >>> Sorry for the breakage. At the moment I have no idea what is wrong here, >> >> From the build log: >> >> ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': >> ../../src/libxl/xen_xl.c:779:17: error: enumeration value >> 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch >> [-Werror=switch-enum] >>                  switch (libxldisk->backend) { >>                  ^~~~~~ >> >> The switch contains a default branch [1], so I am a bit puzzled why >> GCC is not happy here. > > Libvirt seems to compiled with -Wswitch-enum > > And https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says the > following: > > "-Wswitch-enum > > Warn whenever a switch statement has an index of enumerated type and > lacks a case for one or more of the named codes of that enumeration. > case labels outside the enumeration range also provoke warnings when > this option is used. The only difference between -Wswitch and this > option is that this option gives a warning about an omitted enumeration > code even if there is a default label." Thanks for digging! That's explained the error. I still don't think we can solve the error in libxl. So I would suggest to involve the libvirt folks to know how they want to solve the issue. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 11:03:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 11:03:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377469.610689 (Exim 4.92) (envelope-from ) id 1oHNm7-0004CG-FD; Fri, 29 Jul 2022 11:03:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377469.610689; Fri, 29 Jul 2022 11:03:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNm7-0004C9-Bd; Fri, 29 Jul 2022 11:03:23 +0000 Received: by outflank-mailman (input) for mailman id 377469; Fri, 29 Jul 2022 11:03:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNm5-0004C0-PJ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 11:03:22 +0000 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 0bf25664-0f2e-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 13:03:19 +0200 (CEST) Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20220729110315epoutp01e465db6924ee536cf3f372534669e1ee~GR_zbNRsX1538315383epoutp016 for ; Fri, 29 Jul 2022 11:03:15 +0000 (GMT) Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas2p2.samsung.com (KnoxPortal) with ESMTP id 20220729110314epcas2p252c9e3f81f25f444a5374254f4978ec2~GR_y9jK441518315183epcas2p2P; Fri, 29 Jul 2022 11:03:14 +0000 (GMT) Received: from epsmges2p4.samsung.com (unknown [182.195.36.92]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4LvPkp2Hdwz4x9Pt; Fri, 29 Jul 2022 11:03:14 +0000 (GMT) Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p4.samsung.com (Symantec Messaging Gateway) with SMTP id 2F.69.09662.27EB3E26; Fri, 29 Jul 2022 20:03:14 +0900 (KST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list X-Inumbo-ID: 0bf25664-0f2e-11ed-924f-1f966e50362f DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20220729110315epoutp01e465db6924ee536cf3f372534669e1ee~GR_zbNRsX1538315383epoutp016 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1659092595; bh=/fh523OpBVd/9X+oNoqFOp+hsiuEGxjO7nxFwpXVb10=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=bbz56rbZdTYC1K5athUpxdjeGAo2cUzi/VOa7MgU0R4Gq+9NLYDu4cluFMxzFlqYA 7Dh1cVMQ7Uk55WfhxcAZR0gKtfCchkyYSnLJ02TrDOrqPaHts9edeYBUxouCrvzGaw gsHJ0x1e40cfb6VGMwYEwk3gPR/smLTd+sGWStmA= X-AuditID: b6c32a48-9f7ff700000025be-ab-62e3be72ece4 Mime-Version: 1.0 Subject: Re: [PATCH v1] xen: add late init call in start_xen Reply-To: boyoun.park@samsung.com Sender: Boyoun Park From: Boyoun Park To: "xen-devel@lists.xenproject.org" CC: Stefano Stabellini , Jan Beulich , "julien@xen.org" , "bertrand.marquis@arm.com" , "Volodymyr_Babchuk@epam.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "wl@xen.org" , "roger.pau@citrix.com" , Chungwoo Park , Gang Li , Lei Wang , SoungKwan Kimn , DongJin PARK , Joonjae Lee X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: X-CPGS-Detection: blocking_info_exchange X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20220729110313epcms2p5f9b24d5a65b98c220a6e99675298560f@epcms2p5> Date: Fri, 29 Jul 2022 20:03:13 +0900 X-CMS-MailID: 20220729110313epcms2p5f9b24d5a65b98c220a6e99675298560f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHJsWRmVeSWpSXmKPExsWy7bCmuW7RvsdJBs/28VosfryL3WLpks1M FqdmdTJZLDt8j93iwse9LBbzOw4xWfzc85DNorPrC6vF59mT2SzadlxmtZhxfjGrRePCeIvV 6+It/i2NsPi4Rtzi+5bJTA4CHmvmrWH0eD15AqPHnaU7GT02repk8zj84QqLR9+WVYwe67dc ZfE4fWsWWwBHVLZNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJCXmJuqq2Si0+A rltmDtD9SgpliTmlQKGAxOJiJX07m6L80pJUhYz84hJbpdSClJwC8wK94sTc4tK8dL281BIr QwMDI1OgwoTsjHVrrjEW9NtVLP14i7WBcZlNFyMnh4SAicS3ZXPZuxi5OIQEdjBKLN/2n7mL kYODV0BQ4u8OYRBTWMBG4mZDFUi5kICiROuZhewgtrCArkRP1142EJtNQFvixc1bLCC2iICr RM//Z8wgI5kFJrBKnHq3nxliF6/EjPanLBC2tMT25VsZQeZzCgRIrGzVgghrSPxY1gtVLipx c/Vbdhj7/bH5jBC2iETrvbNQNYISD37uhopLSTR+OgRVXywxp2892FsSAg2MEjcvXmSCSOhL TGmZwwpi8wr4SuxdchrMZhFQlThwZjPUUBeJNc0vwGxmoMeWLXwNDhJmAU2J9bv0QUwJAWWJ IxDvMgvwSXQc/ssO8+GOeU+gNqlK/Gp6wQjz7Z6z7VC2h8ThF09YJjAqzkKE8ywku2Yh7FrA yLyKUSy1oDg3PbXYqMAEHrXJ+bmbGMEJWctjB+Pstx/0DjEycTAeYpTgYFYS4RUIeJwkxJuS WFmVWpQfX1Sak1p8iNEU6MuJzFKiyfnAnJBXEm9oYmlgYmZmaG5kamCuJM7rlbIhUUggPbEk NTs1tSC1CKaPiYNTqoHJ4JYha+fTD199f3zM89nToOQxSfei7+05bmsvzLlcdsDnu8a1bRsT 3i78dUSUx7z0bSv/wa+LhT1K10yQab7M/uCaaazBA6E7Gu4uE/JPTsxZ3lCxMNDta9KpaztP PD6443nQywaHiGNSaeueSYlH3GjrX3hRI5+j5befRdytB8/vtvmvKhD6KtFdJPvW2mQZQ5fh ksN+mQVbVWy/TBQ0Pf7u/X/N1GK5u+fYXplPTHnHeKSx/51y4Zu26W/8qu2952W223xhX7DR T66k50JOaa2LQ0PPwaUXKoIvSCxjWtTcfHuF1ZED7X952EtjwxM/Tzh84fX7ua+lz4YZMKgK scTt9+zj6V1xMbw/8f9qJZbijERDLeai4kQAwFxdnFEEAAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220728092237epcms2p53821bba31388763f45b5204d56520c20 References: <97499212.9948800.1659000157467@mail-kr2-3> <88025800-66e2-4fb4-facf-5989e75ba08f@suse.com> I really appreciate all the comments and reviews. I understand that it is hard to add this patch without any usage. On Fri, 29 Jul 2022,=C2=A0Stefano=20Stabellini:=0D=0A>=C2=A0On=C2=A0Thu,=C2= =A028=C2=A0Jul=C2=A02022,=C2=A0Jan=C2=A0Beulich=C2=A0wrote:=0D=0A>=C2=A0>= =C2=A0On=C2=A028.07.2022=C2=A011:22,=C2=A0Boyoun=C2=A0Park=C2=A0wrote:=0D= =0A>=C2=A0>=C2=A0>=C2=A0Hello,=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2= =A0>=C2=A0This=C2=A0patch=C2=A0added=C2=A0late_initcall=C2=A0to=C2=A0deal= =C2=A0with=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0some=C2=A0i= nit=C2=A0functions=C2=A0which=C2=A0should=C2=A0be=C2=A0called=0D=0A>=C2=A0>= =C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0after=C2=A0other=C2=A0init=C2=A0fun= ctions=C2=A0in=C2=A0start_xen.=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2= =A0>=C2=A0If=C2=A0this=C2=A0patch=C2=A0is=C2=A0added,=0D=0A>=C2=A0>=C2=A0>= =C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0then=C2=A0the=C2=A0original=C2=A0initcall= =C2=A0in=C2=A0xen=C2=A0will=C2=A0be=C2=A0treated=0D=0A>=C2=A0>=C2=A0>=C2=A0= =0D=0A>=C2=A0>=C2=A0>=C2=A0as=C2=A0early_initcall=C2=A0and=C2=A0the=C2=A0la= te_initcall=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0which=C2= =A0is=C2=A0added=C2=A0by=C2=A0this=C2=A0patch=C2=A0will=C2=A0be=0D=0A>=C2= =A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0called=C2=A0sequentially.=0D=0A= >=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0I=C2=A0cannot=C2=A0send=C2= =A0patches=C2=A0through=C2=A0git=C2=A0send-email=0D=0A>=C2=A0>=C2=A0>=C2=A0= =0D=0A>=C2=A0>=C2=A0>=C2=A0due=C2=A0to=C2=A0some=C2=A0security=C2=A0issues= =C2=A0in=C2=A0my=C2=A0work.=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>= =C2=A0So=C2=A0intead,=C2=A0I=C2=A0just=C2=A0send=C2=A0the=C2=A0patches=C2= =A0manually.=0D=0A>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0Which=C2=A0is=C2=A0fine= ,=C2=A0but=C2=A0you=C2=A0want=C2=A0to=C2=A0configure=C2=A0your=C2=A0mail=C2= =A0client=C2=A0such=C2=A0that=C2=A0it=0D=0A>=C2=A0>=C2=A0doesn't=C2=A0mangl= e=C2=A0the=C2=A0patch.=C2=A0Albeit=C2=A0I=C2=A0see=C2=A0that=C2=A0to=C2=A0c= over=C2=A0for=C2=A0that=C2=A0at=C2=A0least=0D=0A>=C2=A0>=C2=A0you've=C2=A0a= lso=C2=A0attached=C2=A0both=C2=A0the=C2=A0patch=C2=A0and=C2=A0a=C2=A0cover= =C2=A0letter.=C2=A0For=C2=A0a=C2=A0single=0D=0A>=C2=A0>=C2=A0patch=C2=A0a= =C2=A0cover=C2=A0letter=C2=A0can=C2=A0normally=C2=A0be=C2=A0omitted,=C2=A0b= ut=C2=A0if=C2=A0you=C2=A0don't=C2=A0then=0D=0A>=C2=A0>=C2=A0even=C2=A0if=C2= =A0you're=C2=A0sending=C2=A0without=C2=A0=22git=C2=A0send-email=22=C2=A0you= =C2=A0will=C2=A0want=C2=A0to=C2=A0send=0D=0A>=C2=A0>=C2=A0both=C2=A0as=C2= =A0separate=C2=A0mails,=C2=A0with=C2=A0the=C2=A0patch=C2=A0being=C2=A0a=C2= =A0reply=C2=A0to=C2=A0the=C2=A0cover=0D=0A>=C2=A0>=C2=A0letter=C2=A0thread= =C2=A0root.=0D=0A>=C2=A0=0D=0A>=C2=A0Yeah.=C2=A0Boyoun,=C2=A0if=C2=A0you=C2= =A0only=C2=A0have=C2=A0a=C2=A0couple=C2=A0of=C2=A0patches=C2=A0then=C2=A0it= =C2=A0is=C2=A0fine=C2=A0to=0D=0A>=C2=A0send=C2=A0them=C2=A0manually.=C2=A0O= therwise,=C2=A0if=C2=A0you=C2=A0have=C2=A0many=C2=A0patches,=C2=A0you=C2=A0= can=C2=A0send=0D=0A>=C2=A0them=C2=A0in=C2=A0attachment=C2=A0as=C2=A0tarball= =C2=A0and=C2=A0I'll=C2=A0send=C2=A0them=C2=A0all=C2=A0to=C2=A0xen-devel=C2= =A0using=0D=0A>=C2=A0git-send-email=C2=A0for=C2=A0you=C2=A0(of=C2=A0course= =C2=A0keeping=C2=A0you=C2=A0as=C2=A0original=C2=A0author=C2=A0and=0D=0A>=C2= =A0retaining=C2=A0all=C2=A0Signed-off-bys).=0D=0A=0D=0AYou're=20awesome.=20= Thanks=20you=20so=20much.=20I'm=20still=20requesting=20approvals=20to=20use= =20git=20send-email.=0D=0AI'll=20let=20you=20know=20if=20I=20have=20to=20se= nd=20many=20patches=20wihout=20git=20send-email.=0D=0A=0D=0A>=C2=A0>=C2=A0>= =C2=A0Subject:=C2=A0=5BPATCH=C2=A0v1=5D=C2=A0xen:=C2=A0add=C2=A0late=C2=A0i= nit=C2=A0call=C2=A0in=C2=A0start_xen=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2= =A0>=C2=A0>=C2=A0This=C2=A0patch=C2=A0added=C2=A0late_initcall=C2=A0section= =C2=A0in=C2=A0init.data.=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2= =A0The=C2=A0late=C2=A0initcall=C2=A0would=C2=A0be=C2=A0called=C2=A0after=C2= =A0initcall=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0in=C2=A0th= e=C2=A0start_xen=C2=A0function.=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2= =A0>=C2=A0Some=C2=A0initializing=C2=A0works=C2=A0on=C2=A0priority=C2=A0shou= ld=C2=A0be=C2=A0run=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0in= =C2=A0do_initcalls=C2=A0and=C2=A0other=C2=A0non-prioritized=C2=A0works=0D= =0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0would=C2=A0be=C2=A0run= =C2=A0in=C2=A0do_late_initcalls.=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>= =C2=A0>=C2=A0To=C2=A0call=C2=A0some=C2=A0functions=C2=A0by=C2=A0late_initca= ll,=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0then=C2=A0it=C2=A0= is=C2=A0possible=C2=A0by=C2=A0using=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0= >=C2=A0>=C2=A0__late_initcall(/*Function=C2=A0Name*/);=0D=0A>=C2=A0>=C2=A0>= =C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0Signed-off-by:=C2=A0Boyoun=C2=A0Park=C2=A0= =0D=0A>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0So=C2=A0= I=C2=A0could=C2=A0imagine=C2=A0this=C2=A0patch=C2=A0to=C2=A0be=C2=A0in=C2= =A0a=C2=A0series=C2=A0where=C2=A0a=C2=A0subsequent=0D=0A>=C2=A0>=C2=A0patch= =C2=A0then=C2=A0adds=C2=A0an=C2=A0actual=C2=A0use=C2=A0of=C2=A0the=C2=A0new= =C2=A0functionality.=C2=A0Without=0D=0A>=C2=A0>=C2=A0that=C2=A0what=C2=A0yo= u're=C2=A0proposing=C2=A0is=C2=A0to=C2=A0add=C2=A0dead=C2=A0code.=0D=0A>=C2= =A0=0D=0A>=C2=A0Yeah,=C2=A0I=C2=A0think=C2=A0it=C2=A0would=C2=A0be=C2=A0coo= l=C2=A0to=C2=A0have=C2=A0late=C2=A0initcalls=C2=A0but=C2=A0it=C2=A0makes=C2= =A0sense=0D=0A>=C2=A0to=C2=A0add=C2=A0them=C2=A0if=C2=A0we=C2=A0have=C2=A0s= omeone=C2=A0that=C2=A0makes=C2=A0use=C2=A0of=C2=A0them.=0D=0A=0D=0AI=20tota= lly=20agree=20with=20your=20comments.=20Some=20drivers=20that=20I'm=20devel= oping=20now=20and=20use=20this=20function=20are=20specific=20to=20my=20hard= ware=20environment.=0D=0AThus,=20it=20seems=20difficult=20to=20arrange=20th= em=20in=20the=20near=20future.=0D=0AI=20will=20update=20patches=20if=20I=20= can=20suggest=20an=20actual=20use.=0D=0A=0D=0A>=C2=A0>=C2=A0>=C2=A0=40=40= =C2=A0-1964,6=C2=A0+1966,7=C2=A0=40=40=C2=A0void=C2=A0__init=C2=A0noreturn= =C2=A0__start_xen(unsigned=C2=A0long=C2=A0mbi_p)=0D=0A>=C2=A0>=C2=A0>=C2=A0= =0D=0A>=C2=A0>=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0bsp_info=C2= =A0=3D=C2=A0get_cpu_info_from_stack((unsigned=C2=A0long)bsp_stack);=0D=0A>= =C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0*bsp_info=C2=A0=3D=C2=A0*info;=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>= =C2=A0>=C2=A0>=C2=A0+=C2=A0=C2=A0=C2=A0=C2=A0/*=C2=A0Jump=C2=A0to=C2=A0the= =C2=A01:1=C2=A0virtual=C2=A0mappings=C2=A0of=C2=A0cpu0_stack.=C2=A0*/=0D=0A= >=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0asm=C2=A0volatile=C2=A0(=22mov=C2=A0%=5Bstk=5D,=C2=A0%%rsp;=C2=A0j= mp=C2=A0%c=5Bfn=5D=22=C2=A0::=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2= =A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=5Bstk=5D=C2=A0=22= g=22=C2=A0(&bsp_info->guest_cpu_user_regs),=0D=0A>=C2=A0>=C2=A0>=C2=A0=0D= =0A>=C2=A0>=C2=A0>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=5Bfn= =5D=C2=A0=22i=22=C2=A0(reinit_bsp_stack)=C2=A0:=C2=A0=22memory=22);=0D=0A>= =C2=A0>=C2=A0>=C2=A0=0D=0A>=C2=A0>=C2=A0How=C2=A0does=C2=A0this=C2=A0additi= on=C2=A0of=C2=A0a=C2=A0comment=C2=A0relate=C2=A0to=C2=A0the=C2=A0purpose=C2= =A0of=C2=A0the=0D=0A>=C2=A0>=C2=A0patch?=0D=0A=0D=0AIt=20seems=20that=20thi= s=20is=20unintentionally=20added=20while=20updating=20a=20commit=20base.=0D= =0AI'm=20so=20sorry=20for=C2=A0not=20checking=20thoroughly.=0D=0AI=20will= =20check=20carefully=20before=20sending=20next=20patches.=0D=0A=0D=0ABoyoun= =20Park From xen-devel-bounces@lists.xenproject.org Fri Jul 29 11:04:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 11:04:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377473.610700 (Exim 4.92) (envelope-from ) id 1oHNnN-0004jC-OM; Fri, 29 Jul 2022 11:04:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377473.610700; Fri, 29 Jul 2022 11:04:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNnN-0004j5-Lc; Fri, 29 Jul 2022 11:04:41 +0000 Received: by outflank-mailman (input) for mailman id 377473; Fri, 29 Jul 2022 11:04:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNnM-0004ir-IX; Fri, 29 Jul 2022 11:04:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNnM-0000Xz-FH; Fri, 29 Jul 2022 11:04:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNnM-0001ZU-1A; Fri, 29 Jul 2022 11:04:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHNnM-0007tt-0i; Fri, 29 Jul 2022 11:04:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=NwqeHIlXL/yG3w+yH/A7oLXzmcDh5mx+hATOs5PJWd4=; b=3AvbVIhfiwqlhtkodehXwrtp1S lj++I0213ORFGMlgVPPzXqvUVOV/rKUAniArzY2+8nlDBOHJKVvHt9hp7zEJ3bSCS40Giz1bTiMbs 2jLjo5LaQkRbRFBqA4jLpLWU86cwBPXLiz0Nfn+1DMyDwj+W8aeNnE6Rr07sWoD+mRTo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171914: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=640d185f01858b7a8db401235c929ac4798592d0 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Fri, 29 Jul 2022 11:04:40 +0000 flight 171914 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171914/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 640d185f01858b7a8db401235c929ac4798592d0 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 749 days Failing since 151818 2020-07-11 04:18:52 Z 748 days 730 attempts Testing same since 171914 2022-07-29 04:20:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117511 lines long.) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 12:36:14 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 12:36:14 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377496.610710 (Exim 4.92) (envelope-from ) id 1oHPDi-00075h-Oc; Fri, 29 Jul 2022 12:35:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377496.610710; Fri, 29 Jul 2022 12:35:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPDi-00075a-Lr; Fri, 29 Jul 2022 12:35:58 +0000 Received: by outflank-mailman (input) for mailman id 377496; Fri, 29 Jul 2022 12:35:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPDh-00075U-Kl for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 12:35:57 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id fd03913e-0f3a-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 14:35:55 +0200 (CEST) Received: from DU2PR04CA0023.eurprd04.prod.outlook.com (2603:10a6:10:3b::28) by AM6PR08MB3302.eurprd08.prod.outlook.com (2603:10a6:209:41::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.21; Fri, 29 Jul 2022 12:35:52 +0000 Received: from DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:3b:cafe::5) by DU2PR04CA0023.outlook.office365.com (2603:10a6:10:3b::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 12:35:52 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT027.mail.protection.outlook.com (100.127.142.237) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 12:35:52 +0000 Received: ("Tessian outbound cc6a8ab50b6b:v123"); Fri, 29 Jul 2022 12:35:51 +0000 Received: from cbb0d993ebdf.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 10FBFBD7-A218-4E96-851E-5170E45CA1CE.1; Fri, 29 Jul 2022 12:35:40 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id cbb0d993ebdf.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Jul 2022 12:35:40 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com (2603:10a6:20b:404::24) by DB9PR08MB7772.eurprd08.prod.outlook.com (2603:10a6:10:398::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.6; Fri, 29 Jul 2022 12:35:37 +0000 Received: from AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2]) by AS8PR08MB7158.eurprd08.prod.outlook.com ([fe80::f5fa:7206:9197:6ba2%3]) with mapi id 15.20.5482.011; Fri, 29 Jul 2022 12:35:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: fd03913e-0f3a-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=aG53V/AE8L9MGt3K9lqli04zhGQUhwEDT2W+B3UuX51sxIwIsDpdvKE12MX8jy0u1GI3Syc16Lvi/fhNNedxIcRwfFnlYmWdesR/1gG8U3dhOC7xMVKyg/nnQsRoZp1rFmGJYVrr74vtMnMEVKeblpOJckPoyeSDhhfGA/aBAPL2ZLbLOp/7Q4xagg97decvNdlqmJJZxxGnp+43/ngCVGGFBCkJal6pp0CC29c/2P8v0d6DxyWz2mMxnpESbCRFx4zwcziRVygFrKojMjYiGG8ZjN2cEazFP2mYL66VK93uXO5EPbo85aLB6fjsdhyapzNhgq4Ypykmp1w/GD52tw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/WQMdyN/qvKllpoVdrrpxuJUjQRyNbX2bwusTOrxZtI=; b=P+lH46q8E9g1uNsjZGcY04pDs/v4kg41j0Hj9FIqpmiMjgpbECSQlHdSV3oOErxzxIyYP1LjzPLIQskaHC9uYgqgr75hI/d8ZicYJTp3B6WrTXbPSB5P8kkSdFyy3Sa3fXO7+HgX7IaZLmhpAJwAxBpAF2eMHEdt+EVodS+lFKULWuQRjSDVIcSaLFicwKA043jR62GgxmhoDz7EvgZ0VunLAOTrOjSM4esQZdXA5ryN0hyvsmaHL+ByQPzPT1JqpFmpSECY/9dvJE2VLif0AjGjiZg6/oGqWLw3ZsPrhKJ4fkcoM3AQjhGJ2n8/3ZMdTPGGhnRUndnjhVlN5QrILg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/WQMdyN/qvKllpoVdrrpxuJUjQRyNbX2bwusTOrxZtI=; b=PUSuM0tyBGlgBJPYa3XsliqH58eHYYQCmIJMVHn+fGHgYRndJbXTmKWZnFcl61VkmR61PQJyhKc61bRafIQYHc8cw4LN3xgz7ocgFZRy61qdbtqJeO79D8eU70DsSh2Rh6D53gj71nrxCmLtthPWg4g82aAD8fnSlVyJ1Klry0E= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: fe02f11487eedbdb X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n9ON4GNlg7S8EdZZQrtcK20ZoEAMNN6i4NL+rHYtn6aVOpe6Tsmkrkt0cvj2cUG2f4drKLwEEsXXv4cP4tqzVNF3MFp6m+VwCW62fYeTwYJSujx2OqmfK24+zBtmC1PdYFWSTKWrY/Odben8C+OEcwYg+AgEuvM9C5bKKeworArgvTWHCGw2ODhb/t3Ka2XVLy4kqUXalEhZKz9ZdIpnxLd8Sl+M77iGPBTnTlKCDkAYDjrIvsaq/ZbMrprGTz+zY8l/cwoAvBskll5hFsYIKCTG/VG92vRrQUZ5D3MnvApuXD8EgX0N86+wlxCpM6hXJbutWbOS9kMC9THLMnnLuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/WQMdyN/qvKllpoVdrrpxuJUjQRyNbX2bwusTOrxZtI=; b=SbXuNSCFbeZBaYEsXF1v8AuVqtD5a9mwIbjqYyzGBrjihePXHrMboRl9gsSO1nPoY0Usms5c6i7yRm4xWW/vFs8tbGPk8+V/w+0Zt5zeLXvIrysaXMQ87LhonBfT2scrgmFxDLhv9MfGH9BZ9L6TwSH0A8eZcH8jC4p4SB3fbD4iUhNtaFK3zcQ6KrTLPboW2m4OyskTaL0KITtRqKuol2kmg+ylGiwfn5n4wcL8yLAFp+T8q4Mtr7+rZgQ0RoI8l5XYIAGX0BcI4nNIuzkj+Ksbob7Njd2kA4lYn9TKpQOVize9AVQUibKDrUrhNtyxt4AtIPFCWnMysrRUNBRkCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/WQMdyN/qvKllpoVdrrpxuJUjQRyNbX2bwusTOrxZtI=; b=PUSuM0tyBGlgBJPYa3XsliqH58eHYYQCmIJMVHn+fGHgYRndJbXTmKWZnFcl61VkmR61PQJyhKc61bRafIQYHc8cw4LN3xgz7ocgFZRy61qdbtqJeO79D8eU70DsSh2Rh6D53gj71nrxCmLtthPWg4g82aAD8fnSlVyJ1Klry0E= From: Rahul Singh To: Julien Grall CC: Bertrand Marquis , Jan Beulich , xen-devel , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu Subject: Re: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Topic: [PATCH 2/8] xen/evtchn: modify evtchn_alloc_unbound to allocate specified port Thread-Index: AQHYhkXaSSR0QDc2DUiowhnmyNd/Sq1bgqiAgB3xuACAAai8gIAA1/CAgAA2U4CAAAT8AIAABuwAgAAKeYCAAAnjAIAAC4AAgAAEsgCACtZcgIAAFXWAgAGspoCAAAsFgIAAI8AAgAf9PoCAAwMegIAAV24AgAEIAAA= Date: Fri, 29 Jul 2022 12:35:37 +0000 Message-ID: References: <5ea66595248c41a011ac465bfabd7a7a40dcd565.1655903088.git.rahul.singh@arm.com> <2cdde2eb-33ac-568b-a0ae-b819b7b4161b@xen.org> <1494EC8C-9916-472F-9285-57C0FF656919@arm.com> <9711c08f-7e16-daf3-f010-1e6a53b0b9a0@xen.org> <5f200481-ed3c-a463-90aa-3718c0ab57a3@suse.com> <758779b3-ef39-aa95-15c9-9b84b952e80b@xen.org> <3b42f9ab-383c-694c-cef0-5d24531e556a@suse.com> <019c5cb4-7e6a-d822-3c02-e3199d499106@xen.org> <93E40C29-DD1E-4C9B-936B-45ACA69BBD66@arm.com> <99D4D342-5DF7-4F85-A311-4D03967D77DB@arm.com> <329C928A-92B2-43EB-8972-52DAEF5258EF@arm.com> <03fd4b2b-66ab-eaf8-0875-9382e8b14012@xen.org> In-Reply-To: <03fd4b2b-66ab-eaf8-0875-9382e8b14012@xen.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: fc537254-3137-4323-9ae3-08da715edfb5 x-ms-traffictypediagnostic: DB9PR08MB7772:EE_|DBAEUR03FT027:EE_|AM6PR08MB3302:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: W2wosatFJBQuC499WADjM0x45OCeRx1WR9rwaObUNNVOGg+7AZSSMP9tdsgmxI+rDKRMXydlXCpylmCv6usEXkt4tppUrsYgQKUowGA93Gq2f68IRDX8v+VuV4blwe1/8C+EApuXfEJeWYOxKO4EbdhoLbDyEnTYGdE6jGyAw6D72KZUUd8F0ff9owT2ip+OtKjakrJMhUQq6T0XCJWxU1oqQkTsIrc3FrstPxYxSlT8KpANzcpIZvlB8YFOUFMoebJ9Fal+oMpFbIjG0K6xFWIHpmkV0S23yODYWYMosoXa8aAVV7jBXn7CnLRyzbawsWAPp+gJ3lC+sWTjcYLcPqSL1kjYDHQCML+vjOEYahQ05yS7Dk24R6EnQjptFPNhxhq/K6WUawyCxnMvUJbIhWmboJu2dJ+vBcW6bJzRnK+FFPmclBL67Qpzdi1V4VLF5Ygx5gPSrrV4c01YB5xj6HUiX6dqwfDRh7D0cQwYYI/0j2ZBiXb8cIT202f27ckMVBBxzpVIqr9kS69kWVoda+1jt7so8cwWGKzFqtUWGHxcWDq9//lh/5pp/bqZbzVXmiE4HmkozfrY1S+bVywPt00xJsiqcf6kSlXFYkjtVpgSBjlb+xQnhZlaDXVeR8LDdyy6Dkw0E5meFoxMWm0PAkElFvHgYSi9m5DJuU4pAoPEmk3muQTX2xhV11lGkD44UKLkEoU3CCs68r/JBb+r2K2mG3avcNTvLOD/iKr7lkHPWyEpPognaK+rfIBS3U0xdifmYJb/aOtKRAcJk1Jp4uxPp0NVyQFZXM1BzDMwY5Tsxb0AJP4eIacXzK6iaXre1WhlR5GvjIRDzCdvflLuxw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB7158.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(396003)(346002)(366004)(136003)(39860400002)(376002)(36756003)(33656002)(5660300002)(76116006)(8676002)(38070700005)(4326008)(2906002)(8936002)(91956017)(86362001)(66556008)(66946007)(54906003)(316002)(64756008)(66476007)(6916009)(66446008)(41300700001)(53546011)(6506007)(6486002)(38100700002)(2616005)(71200400001)(6512007)(478600001)(26005)(186003)(83380400001)(122000001)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="utf-8" Content-ID: <8CD915512EC57540A61029E0293FC91D@eurprd08.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7772 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: be84e825-e706-406b-7403-08da715ed730 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 45xgqtfPGEykGbeREFqqdpIWnEdqDzBe1dqCKRVfgYlVvKsEuA9uFUskSQtyKK0RgQlyAhjKiandelrJml9tyYLx1PQNjTm5RKcxkvwYBpT/n8iLuiwmrULfS9pdsyqjsY2/3tljE35IZ4MaIdM+GbStnenap9YVQy+DKn7gbYbXMT6/DdPXGLxwwPiH5gwgwxeuf9e6onAUs2+c7VcuFH+nZA/dZjC02fK5HfkeyogBAwNtl5L2kPYIZHIgTj0MAtKOuPQgu2qd8By/yorO4FaXMREoPZaw/FEX7QKuXakXpJQ4cS9Q3s4URrI4nflNAlllBpSHdg2K+v/xCbcxfSPaiCw8MTCsdoh1MtUxNZEqSWYiNYv7XRIxzs6ROvb9U7HOaJN9qqZMtDeQikivaXf8Pf53rrbJrhRBbHIGT9oBeiHjBZNNLlZbC7s1vAtXdkDezW9IozITyb5mF7YNevAOc5Hi7gp+S2tHzgMnVrDeww+aO2IBx9bbTfmN8l+IuMpdV8M2MpRkEUldtpNvIDQYcJgdoKrQPF559Pwli8DLGBQfPZHhSLh3aXgZi/G3LZw8XDxvIr3xUD2v7FeyFYL6R5OufXpDmUMKBrWa3EHSVw6IJSFG5Eep3STgNn3ZPg/0tCb02K90CZnV/Ay/bIl4iYJDH3FfQlBqWO80Fkvv7Db5Ot1wUpFu1K6gpZ4pWLL6TeD5Jbju+QCoKlPpOZAZE2B1NZxRLV6M5jgtTaOhTgj+UaYYuMG/H1WKein+B3kv9UpI68jaIdyAyUlDVugynaG0yd05fkN+lXR9a+3cl0+AlGK4N3wVnzPPKfec X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(396003)(39860400002)(346002)(136003)(376002)(46966006)(40470700004)(36840700001)(336012)(53546011)(36756003)(70206006)(47076005)(356005)(36860700001)(6512007)(478600001)(6506007)(6486002)(186003)(82740400003)(81166007)(33656002)(2616005)(70586007)(82310400005)(40480700001)(54906003)(40460700003)(8936002)(2906002)(26005)(316002)(4326008)(83380400001)(41300700001)(5660300002)(8676002)(86362001)(6862004);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 12:35:52.0275 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc537254-3137-4323-9ae3-08da715edfb5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3302 SGkgSnVsaWVuDQoNCj4gT24gMjggSnVsIDIwMjIsIGF0IDk6NTAgcG0sIEp1bGllbiBHcmFsbCA8 anVsaWVuQHhlbi5vcmc+IHdyb3RlOg0KPiANCj4gSGkgUmFodWwsDQo+IA0KPiBPbiAyOC8wNy8y MDIyIDE2OjM3LCBSYWh1bCBTaW5naCB3cm90ZToNCj4+IEFzIHlvdSBtZW50aW9uZWQsIGlmIHdl IGRvbuKAmXQgcmVzdHJpY3QgdGhlIG51bWJlciBvZiBldmVudHMgY2hhbm5lbCBmb3IgdGhlIGRv bTAgc3lzdGVtIHdpbGwgYm9vdCBzbG93ZXIuDQo+PiBUaGlzIGlzIGEgZ29vZCByZWFzb24gdG8g cmVzdHJpY3QgdGhlIG51bWJlciBvZiBldmVudCBjaGFubmVscyBmb3IgZG9tMC4NCj4gTGV0IG1l IHN0YXJ0IHRoYXQgSSBhbSBzdGlsbCBmaW5lIGlmIHlvdSB3YW50IHRvIHB1c2ggZm9yIGEgbmV3 IHBhcmFtZXRlciAoc28gbG9uZyBpdCBpcyBub3QgQXJtIHNwZWNpZmljKS4gSG93ZXZlciwgSSBh bSBhZnJhaWQgdGhhdCBJIHdpbGwgbm90IGJlIGFibGUgdG8gYXJndWUgZm9yIGl0IGJlY2F1c2Ug SSBkb24ndCBzZWUgYSBzdHJpY3QgbmVlZCBmb3IgaXQuDQo+IA0KPiBMZXQgbWUgcGxheSB0aGUg ZGV2aWwncyBhZHZvY2F0ZSBmb3IgYSBiaXQuIEFGQUlVLCB5b3Ugd291bGQgbGlrZSB0byBpbnRy b2R1Y2UgdGhlIG5ldyBwYXJhbWV0ZXIganVzdCB0byB0ZWxsIHRoZSBhZG1pbiB0aGUgYm9vdCBp cyBnb2luZyB0byBiZSBzbG93ZXIgaWYgeW91IHVzZSBhIGV2ZW50IGNoYW5uZWwgSUQgaGlnaGVy IHRoYW4gTi4NCj4gDQo+IFRvIG1lIHRoaXMgc291bmRzIGxpa2UgdGhlIHNhbWUgYXMgaWYgYW4g YWRtaW4gZGVjaWRlIHRvIHVzZSAxMEdCIHJhdGhlciB0aGFuIDFHQi4gVGhlcmUgd2lsbCBiZSBz bG93IGRvd24uDQo+IA0KPiBUaGlzIHNsb3duZXNzIGlzIG9ubHkgYm9vdCBzcGVjaWZpYyBhbmQg d2lsbCBub3QgdmFyeS4gU28gb25lIGNvdWxkIGFyZ3VlIHRoaXMgaXMgZWFzaWx5IG5vdGljZWFi bGUgYW5kIGFuIGFkbWluIGNhbiB0YWtlIHJlbWVkaWF0aW9uLg0KPiANCj4gR2l2ZW4gSmFuJ3Mg b2JqZWN0aW9uLCBJIHdvdWxkIGxpa2UgdG8gcHJvcG9zZSB0byBkb2N1bWVudCBpdCBpbiB0aGUg YmluZGluZ3MgaW5zdGVhZCAoYSBjb25jZXJuZWQgYWRtaW4gd2lsbCBsaWtlbHkgcmVhZCBpdCku IEJlbG93IGEgcm91Z2ggcHJvcG9zYWwgZm9yIHRoZSBkb2N1bWVudGF0aW9uOg0KPiANCj4gIkl0 IGlzIHJlY29tbWVuZGVkIHRvIHVzZSBsb3cgZXZlbnQgY2hhbm5lbCBJRC4iDQo+IA0KPiBXb3Vs ZCB0aGF0IGJlIHN1aXRhYmxlIGZvciB5b3U/DQoNClllcywgdGhhdCB3aWxsIHdvcmtzIGZvciBt ZS4gSSB3aWxsIHJlc3RyaWN0IHRoZSBtYXggZXZlbnQgY2hhbm5lbCBmb3IgZG9tVSBvbmx5IGFu ZCBhbHNvIGFkZCB0aGUgY29tbWVudCBpbiANCiJkb2NzL21pc2MvYXJtL2RldmljZS10cmVlL2Jv b3RpbmcudHh04oCdIGFzIHN1Z2dlc3RlZCBieSB5b3UuDQoNClJlZ2FyZHMsDQpSYWh1bA== From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:02:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:02:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377504.610721 (Exim 4.92) (envelope-from ) id 1oHPde-0002WT-U1; Fri, 29 Jul 2022 13:02:46 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377504.610721; Fri, 29 Jul 2022 13:02:46 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPde-0002WM-R9; Fri, 29 Jul 2022 13:02:46 +0000 Received: by outflank-mailman (input) for mailman id 377504; Fri, 29 Jul 2022 13:02:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPdd-0002WC-Fn; Fri, 29 Jul 2022 13:02:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPdd-0002b1-CT; Fri, 29 Jul 2022 13:02:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPdd-0004gp-1T; Fri, 29 Jul 2022 13:02:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHPdd-00059E-11; Fri, 29 Jul 2022 13:02:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=EN5Nnwc796a2S8NePbDhNcvBZjerdbGTUaRuh0AqaU8=; b=kTg1EbngL5LqXHnz5ttHvkCnoZ Y53TgwMcOFA4ZXY1CNo6Lyu4BrEgB8+nk/NqfdaRlDy8xbhhFzvn4uNG4fIKxDet13PsbhLMpCVE3 hMploz4fWCnbOKH6ufUeYzyAJZfLR+ckxceQksVua12azTUVD5wiRVs3gsnxThJHjQkE=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171917: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=062790aca6b1faea62c9ed2737c3791efb0d0f4c X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 13:02:45 +0000 flight 171917 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171917/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 062790aca6b1faea62c9ed2737c3791efb0d0f4c baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 0 days 5 attempts Testing same since 171917 2022-07-29 10:03:07 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 062790aca6b1faea62c9ed2737c3791efb0d0f4c Author: Xenia Ragiadakou Date: Fri Jul 29 08:51:31 2022 +0200 arm/atomic: fix MISRA C 2012 Rule 20.7 violation The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit 124f138b37d595294b3100349e26ffb3f1df7b13 Author: Xenia Ragiadakou Date: Fri Jul 29 08:50:58 2022 +0200 xsm/dummy: fix MISRA C 2012 Directive 4.10 violation Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu Acked-by: Daniel P. Smith commit 9ff3231f955cee4d62c7be6a03d061c037d7ca69 Author: Jan Beulich Date: Fri Jul 29 08:50:25 2022 +0200 x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Now that we're not building multi.c anymore for 2 and 3 guest levels when !HVM, there's no point in having these conditionals anymore. (As somewhat a special case, the last of the removed conditionals really builds on shadow_mode_external() always returning false when !HVM.) This way the code becomes a tiny bit more readable. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 5b04fe78646a8222626996113c9d1e598cb84831 Author: Jan Beulich Date: Fri Jul 29 08:49:48 2022 +0200 x86/shadow: don't open-code shadow_remove_all_shadows() Let's use the existing inline wrapper instead of repeating respective commentary at every site. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 8a3b89e4307da260675483bb86fc06cc62ed7c08 Author: Jan Beulich Date: Fri Jul 29 08:49:06 2022 +0200 x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM In my (debug) build this amounts to well over 500 bytes of dead code. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 3629759626ac7201a670a8a2d4d4a536e7443575 Author: Jan Beulich Date: Fri Jul 29 08:48:26 2022 +0200 x86/shadow: properly handle get_page() failing We should not blindly (in a release build) insert the new entry in the hash if a reference to the guest page cannot be obtained, or else an excess reference would be put when removing the hash entry again. Crash the domain in that case instead. The sole caller doesn't further care about the state of the guest page: All it does is return the corresponding shadow page (which was obtained successfully before) to its caller. To compensate we further need to adjust hash removal: Since the shadow page already has had its backlink set, domain cleanup code would try to destroy the shadow, and hence still cause a put_page() without corresponding get_page(). Leverage that the failed get_page() leads to no hash insertion, making shadow_hash_delete() no longer assume it will find the requested entry. Instead return back whether the entry was found. This way delete_shadow_status() can avoid calling put_page() in the problem scenario. For the other caller of shadow_hash_delete() simply reinstate the otherwise dropped assertion at the call site. While touching the conditionals in {set,delete}_shadow_status() anyway, also switch around their two pre-existing parts, to have the cheap one first (frequently allowing to avoid evaluation of the expensive - due to evaluate_nospec() - one altogether). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:16:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:16:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377515.610732 (Exim 4.92) (envelope-from ) id 1oHPrH-0004WD-BW; Fri, 29 Jul 2022 13:16:51 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377515.610732; Fri, 29 Jul 2022 13:16:51 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPrH-0004W6-8t; Fri, 29 Jul 2022 13:16:51 +0000 Received: by outflank-mailman (input) for mailman id 377515; Fri, 29 Jul 2022 13:16:49 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPrF-0004Vw-HP; Fri, 29 Jul 2022 13:16:49 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPrF-0002qd-CT; Fri, 29 Jul 2022 13:16:49 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPrE-00056L-Uc; Fri, 29 Jul 2022 13:16:49 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHPrE-0000J6-UC; Fri, 29 Jul 2022 13:16:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=pf8Ib64ps0TFehj3ZZ6rl+GNAsi5WGzFxaAhhj2Ck0o=; b=F+MvT/FZsoWaToUL8g+YmLOcPP gVVY0INsXe8li4C86VGrm068+U75TlaIrzcQwur/Otbq548cdnWPHp6OHzd1ANxs0bj3cD7n3QoF1 oct5iAwx9Djk/ekWUFrC6/Ej5hFJYVkZ1Qi4Fq1eWY/yq2+yNNPnO/IvT+HdqGV6i4Eo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171910: tolerable FAIL X-Osstest-Failures: xen-unstable:test-arm64-arm64-libvirt-xsm:debian-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 13:16:48 +0000 flight 171910 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171910/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-xsm 12 debian-install fail pass in 171896 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail pass in 171896 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail in 171896 never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail in 171896 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171896 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171896 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171896 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171896 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171896 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171896 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171896 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171896 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171896 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171896 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171896 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171896 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171910 2022-07-29 01:53:11 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm fail test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm fail test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:18:03 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:18:03 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377454.610743 (Exim 4.92) (envelope-from ) id 1oHPsP-00053q-Ly; Fri, 29 Jul 2022 13:18:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377454.610743; Fri, 29 Jul 2022 13:18:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHPsP-00053j-J6; Fri, 29 Jul 2022 13:18:01 +0000 Received: by outflank-mailman (input) for mailman id 377454; Fri, 29 Jul 2022 10:25:05 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHNB3-0006yM-0r for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 10:25:05 +0000 Received: from server.lespinasse.org (unknown [63.205.204.226]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b359c384-0f28-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 12:25:01 +0200 (CEST) Received: by server.lespinasse.org (Postfix, from userid 1000) id 43C591608FB; Fri, 29 Jul 2022 03:24:58 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b359c384-0f28-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-ed; t=1659090298; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=a/XS8F6DJ0UncG2aNUIYHtQzj6v+HgUrBJ1uNti4iPo=; b=z07fAc3s82E8eDjOmWqCiQ8bXbav83TEx3/Re97NlSxxiCQo28PSqhP5HNIn+14JJNint RyzSM6g4CHMlWDtCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-rsa; t=1659090298; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=a/XS8F6DJ0UncG2aNUIYHtQzj6v+HgUrBJ1uNti4iPo=; b=I1XE4PG3J6WdBxHBHPO8gz729jU9NwxFGePQBg2SGh03K5MaVR21Or0F1Ed2fJkedXwqn 73ZEg9HBg/VtqO2lKkpr4whjhup8i+ouV+MRlyl12YqkOIbBlxYxGShIJKbmEieaOBGjn22 ZXDWImDNaRHLW7cNGx8eSPR5smKlm5X/Vadfwpk61igIRp4T13wJ8QuAfpZsGCdgjSHCAt3 xICHC0gdRmgeZ4VsHAxcqkS8UkYtj/62Fy/MANXsihH037ZiFlqRtJ1IH4+gKYbMZ+SX1Jj 7eSPi+obGVy9GT10OfxqZ1++H06soXF8UFwZNT5FhqZM4eGuNqJqYx1H9gbg== Date: Fri, 29 Jul 2022 03:24:58 -0700 From: Michel Lespinasse To: "Paul E. McKenney" Cc: Michel Lespinasse , Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220729102458.GA1695@lespinasse.org> References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> User-Agent: Mutt/1.10.1 (2018-07-13) On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > Xeons") wrecked intel_idle in two ways: > > > > > > - must not have tracing in idle functions > > > - must return with IRQs disabled > > > > > > Additionally, it added a branch for no good reason. > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > Signed-off-by: Peter Zijlstra (Intel) > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > usage" when booting a kernel with debug options compiled in. Please > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > and is still present in v5.19-rc8. > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > I finally got a chance to take a quick look at this. > > The rcu_eqs_exit() function is making a lockdep complaint about > being invoked with interrupts enabled. This function is called from > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > interrupts before invoking rcu_eqs_exit(). > > The only other call to rcu_idle_exit() does not disable interrupts, > but it is via rcu_user_exit(), which would be a very odd choice for > cpuidle_enter_state(). > > It seems unlikely, but it might be that it is the use of local_irq_save() > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > the trouble. If this is the case, then the commit shown below would > help. Note that this commit removes the warning from lockdep, so it > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > equivalent debugging. > > Could you please try your test with the -rce commit shown below applied? Thanks for looking into it. After checking out Peter's commit 32d4fd5751ea, cherry picking your commit ed4ae5eff4b3, and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, I am now seeing this a few seconds into the boot: [ 3.010650] ------------[ cut here ]------------ [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 [ 3.010657] Modules linked in: [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 89 c0 48 03 1c c5 c0 98 [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 3.010683] Call Trace: [ 3.010685] [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 [ 3.010694] cpuidle_enter+0x29/0x40 [ 3.010697] do_idle+0x1d4/0x210 [ 3.010702] cpu_startup_entry+0x19/0x20 [ 3.010704] rest_init+0x117/0x1a0 [ 3.010708] arch_call_rest_init+0xa/0x10 [ 3.010711] start_kernel+0x6d8/0x6ff [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb [ 3.010728] [ 3.010729] irq event stamp: 44179 [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 [ 3.010741] ---[ end trace 0000000000000000 ]--- From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:26:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377532.610777 (Exim 4.92) (envelope-from ) id 1oHQ12-0007OD-5w; Fri, 29 Jul 2022 13:26:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377532.610777; Fri, 29 Jul 2022 13:26:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ12-0007Nr-2w; Fri, 29 Jul 2022 13:26:56 +0000 Received: by outflank-mailman (input) for mailman id 377532; Fri, 29 Jul 2022 13:26:54 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ10-0006rA-F7 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 13:26:54 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1bfa000e-0f42-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 15:26:53 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1bfa000e-0f42-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659101213; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=M7O2Y0l36eqJVxxchKGa1BAarrZpTn8SXsfsBruyas8=; b=eqKdldxxE2qIuEKsHv3YXxhE0u+RW2aVrwjDypukSGG7p2cEcBuExU6Q LCB2rYgFWWO2dqRPUXu+YcnRlqX5zeUB4Y9aM1HbKpXmgIJv0ADHwN6Of Bs3B2YziC86U+8+0JycliGay1iOGdP2QtaoFNmMvmWGn5fsXlqLnZh9MS s=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76933074 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AduOXbKpqIvPf0XvGanazvq+K2C9eBgzWbkUzO?= =?us-ascii?q?Ej9NTP0s+dABD8hgsdSaEH9hFxiBwbI0vBa6i2HxjTGFjKJ11DbHMsG61v30?= =?us-ascii?q?8FQIZD4FsuOBg5xy3WHeMGe+KXVIU3yRh1DHPk1d2DiRw6Rwqqiji+aBeVlw?= =?us-ascii?q?5Q36PXD4JWT/P+DHIC6akoTAGvZ2VQNXiyc3IptqscBMYdDI92KATdqmfIi2?= =?us-ascii?q?Rn1981nIVpQQ8u0zXnVxMBzpgFnE2ze4U/bWa7arZaDOLHd5U5PUn9xUHRjD?= =?us-ascii?q?U0FCInXZDnLeYv94tTd5V9dXMRAqaTnuBaAuf8J/P7+LZBLtcwB0/6tU0Sku?= =?us-ascii?q?tNh/8m+8CeKPEjQ5ikG4JqrrcYrKvpKXOunM7riGglcZPYtRTbWDxYTCtKEq?= =?us-ascii?q?3qbOVLhTitcwD6HPNN1sXq+NsXCxdsyDPVbXd8zKGYFqiSPFW7pJXVnvgjF6?= =?us-ascii?q?8JW8Da/Ps3HPAZ8gxV6Wo/k3Z0Z1SeAI2CKlILuEsbMyXJY1cor08YgHGaQt?= =?us-ascii?q?j0GzCPuzAniUqKO2KdIuBXlg7BTcQ8NISH/l1/WhFbTS14tfdMFle4S5nU0E?= =?us-ascii?q?tN0s/GtPBv8aBa1Cquw9lXnHs0a7cpFzY2Svsxij/PMAO4/S15te9qkrPb01?= =?us-ascii?q?oPBeft4e2Sf4QiAPSiFqpoKEiOpOB8UB9Ug+vRuzEGpfX2X0Pv6zQOB1rIU7?= =?us-ascii?q?6qQJFVmoaXFU7h5rQrM59ddw7iwCDop5Jrp+OMeGYKj7uSuN8n3lEeNkVN6+?= =?us-ascii?q?5JVnjMoM6B3v3xHY+LS3k1SXb881bgmKp1VLQE5AehUk9t+CQce/1LvAjhrE?= =?us-ascii?q?f+DR/RBIEP+OxlegzPlCbECh2AnuaMBErCyHA6ssT6uoEYz2mI6FKdlqgl+K?= =?us-ascii?q?b1PN1KDTZkS4U6bHkndd5lL9MfrORCWuRLYHivcVno28rivlxB9qDPeK04KN?= =?us-ascii?q?t3O9sxe9m9Y00lILT5JJMvee2E/2KAbMrNgmhs1KbrwiuzLLk6s9m6E5t0Tu?= =?us-ascii?q?uHOT9PcX6TvUkq6zC5x8aRlAGdNQTLU6EHww4FtplNn9pSfAhw5DCU1cqcnj?= =?us-ascii?q?xBuf89/p+yxfeKZNzoZuXscZS4s+d4Xv4aGZDX2JrGFLD9kv14vKZVVUA1X0?= =?us-ascii?q?SfnoR3PNBbeVSpCZU2yQ89VUP/+b+Dt/pcLM8veMXwSNOHUJ22z8Jkk+gVdZ?= =?us-ascii?q?jmGXze8legC+dRltoiAfm7P8sNB39ruro4+J93mZVul61iNQkeXW9w+cOK5w?= =?us-ascii?q?VQF1qnD9Ko7otINYrvZn4uz5aM4taOs1jeJbpumBS0D41X0BBOE14uhIEuQX?= =?us-ascii?q?0fXfyRS7cUZbrNkLZx71nNsdysxMdPPfqSC+OB1EBKYkl4kvYeRXwnAmrKn/?= =?us-ascii?q?h2C5fhKS1WV3SihmYZHgYJz6Br8t14hGXir/DCM2VJow3jDku8T0NZ4W398M?= =?us-ascii?q?3Tj5znzcVK1R5vTNusxbip2lUPgeGI6mov7sokdNsNOiOlD9Xs8CC+jS29x3?= =?us-ascii?q?nVAC+Tid/Zq9Odz4uWdE8uyCEFxEogSLTNFSZ75y/iRE9bByi9I9GXs0MHLQ?= =?us-ascii?q?E7IyMccHJUpwJolJaPegLfuQR11ZAixUxuNRKiCWdAMRoGJCbLl+zIGvR2Yk?= =?us-ascii?q?cO8XiVwix1kGhG3pcQptnFXJfYY90Msn2IuaWMRniVKF8F1b/dWKf86pPEA4?= =?us-ascii?q?ntOR8VpFTN67p6ph6jAqVctYi0VFJusOq8PWiAM0g84GI6qIE2YaeecpokvR?= =?us-ascii?q?jG10cqbo0SQR/BK8JVul81wvyPmlIyrYR5WeC01ZArZ+v9swmL5a8iNouwJT?= =?us-ascii?q?Z9ZZHtoL1M8f2F/mNdN4VauLH7n92QsHWP5cWpdGZgTKHZ1+ArS9UB9mzIni?= =?us-ascii?q?lWs6Py+NsWvCotRJADDqpXWQkLkL7Umq3OKH2iL8dqDvGpvo8FhV2uvtoWaT?= =?us-ascii?q?v08+43kd7+rog9+qRHng1jSjj0M6GMYv0CgiFL4yJbbeoSHsQsd9vxDijMOA?= =?us-ascii?q?1uIxTZMusyb0yTTfvlmciqPWaxBAIqicHrQnFEfoxzfOO3dMeuNcLu7FGxSM?= =?us-ascii?q?7pch8FD/j8D7HAxZf0CzWM4VWIQ76cWeIgf1utSp2pXI3qXQKkBvRIR4VHRw?= =?us-ascii?q?kvckjj9e27YDEGBgQzJoUUmqHNuEarsc3bOTiJMiRQ78PDxxBt05kdv9hmky?= =?us-ascii?q?Iei9q0zvznI4wklDnzf+8uChaE2oIRcBOLmrcZQ40IKaLvdZV6ISIg4g9R8z?= =?us-ascii?q?+RVu1qFFVcQWLGGQBs8BgT4Z50mUFLqgpaBEnVo/TOm1jNrdBaSnwHjKdEBW?= =?us-ascii?q?o8Pg4dQu8lBPmGplOtSSk2TkG0AOWnBN9oQxXtp43IFDhtrAr3HU/+taDs30?= =?us-ascii?q?AYcN8ROruB2cvX8A7Sb3u6ZubgIwqTSEFCkmCEvifXH/frUJuXZPes82vv94?= =?us-ascii?q?Jd0wOr/EkFiBBAeOWUmU6JSKrbKInGiu6dgfE5GYf1hPZCVvwCnAdCacQL7s?= =?us-ascii?q?sRK2B9H7+2U2GTAhwhrV3g8JrhCoDqqOmp6hquzroHPB9SvKICxVxCa/MpW7?= =?us-ascii?q?bPdYeDt9nqLFjLa5iRC0IoHZV5pfCLi0Iz3cRCkqP9WDFlzAzxR6oFKVzV4e?= =?us-ascii?q?sD/fXQHWMOF9TiNF9229u4rnnJwvcA46UUKACTRjwsrNzJvFtg8nvdfq1XXK?= =?us-ascii?q?wagjYnT6zNK7JgYuKTv1VjGGzTwBlIXCGf1xYztzsyUamL3Xb9py8K74ctLi?= =?us-ascii?q?gPl5467pYDJX3KrsYUXfyjZmEMd6zO+vKX2DAFDNnlk6Dcik9wVdAhbWPwh6?= =?us-ascii?q?NCYi9GRCjUWZnkryGJNK/jwDZb93C1L7NIq4Tpa4xwqg22KIzJK9IGaOyP5y?= =?us-ascii?q?w=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76933074" From: Anthony PERARD To: CC: Juergen Gross , Wei Liu , Jan Beulich , Andrew Cooper , "Anthony PERARD" Subject: [XEN PATCH] tools/libxl: env variable to trusted default Date: Fri, 29 Jul 2022 14:26:41 +0100 Message-ID: <20220729132641.21221-3-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220729132641.21221-1-anthony.perard@citrix.com> References: <20220729132641.21221-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain This is a forward port of "tools/libxl: env variable to signal whether disk/nic backend is trusted", to allow the environment variable to still work when upgrading from 4.16 or earlier. Introduce support in libxl for fetching the default backend trusted option for disk and nic devices. This is part of XSA-403. Signed-off-by: Anthony PERARD --- docs/man/xl.1.pod.in | 24 ++++++++++++++++++++++++ tools/libs/light/libxl_disk.c | 6 +++++- tools/libs/light/libxl_nic.c | 5 ++++- 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index 101e14241d..a5a2af5df9 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -1945,6 +1945,30 @@ shows the decimal value. For non-linear mode, it shows hexadecimal value. =back +=head1 ENVIRONMENT + +=over 4 + +=item B + +Use B or B from L instead for a +more fine grain setting. + +This environment variable allows to changed the default value of B; +if it is set to "1", the default will be B; if the variable is +absent or set to "0", the default will be B. + +=item B + +Use B / B from L instead for a +more fine grain setting. + +This environment variable allows to changed the default value of B; +if it is set to "1", the default will be B; if the variable is +absent or set to "0", the default will be B. + +=back + =head1 IGNORED FOR COMPATIBILITY WITH XM xl is mostly command-line compatible with the old xm utility used with diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index 9da2b2ed27..7564a12868 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -155,11 +155,15 @@ static int libxl__device_disk_setdefault(libxl__gc *gc, uint32_t domid, libxl_device_disk *disk, bool hotplug) { int rc; + const char *envvar; libxl_defbool_setdefault(&disk->discard_enable, !!disk->readwrite); libxl_defbool_setdefault(&disk->colo_enable, false); libxl_defbool_setdefault(&disk->colo_restore_enable, false); - libxl_defbool_setdefault(&disk->trusted, true); + + envvar = getenv("LIBXL_DISK_BACKEND_UNTRUSTED"); + /* Default to trusted if envvar missing or is "0". */ + libxl_defbool_setdefault(&disk->trusted, !envvar || !strcmp("0", envvar)); rc = libxl__resolve_domid(gc, disk->backend_domname, &disk->backend_domid); if (rc < 0) return rc; diff --git a/tools/libs/light/libxl_nic.c b/tools/libs/light/libxl_nic.c index d6bf06fc34..ff3aede6ea 100644 --- a/tools/libs/light/libxl_nic.c +++ b/tools/libs/light/libxl_nic.c @@ -59,6 +59,7 @@ static int libxl__device_nic_setdefault(libxl__gc *gc, uint32_t domid, libxl_device_nic *nic, bool hotplug) { int rc; + const char *envvar; if (!nic->mtu) nic->mtu = LIBXL_DEVICE_NIC_MTU_DEFAULT; @@ -116,7 +117,9 @@ static int libxl__device_nic_setdefault(libxl__gc *gc, uint32_t domid, abort(); } - libxl_defbool_setdefault(&nic->trusted, true); + envvar = getenv("LIBXL_NIC_BACKEND_UNTRUSTED"); + /* Default to trusted if envvar missing or is "0". */ + libxl_defbool_setdefault(&nic->trusted, !envvar || !strcmp("0", envvar)); return rc; } -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:26:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377531.610766 (Exim 4.92) (envelope-from ) id 1oHQ10-000778-Tc; Fri, 29 Jul 2022 13:26:54 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377531.610766; Fri, 29 Jul 2022 13:26:54 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ10-000771-QT; Fri, 29 Jul 2022 13:26:54 +0000 Received: by outflank-mailman (input) for mailman id 377531; Fri, 29 Jul 2022 13:26:53 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ0z-0006rA-9o for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 13:26:53 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1a3a013f-0f42-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 15:26:52 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1a3a013f-0f42-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659101212; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Xag00GhheHezUELouMZ36MTWxrrWM9y1zSsNJWcF1U8=; b=PQ8hzeZh5GHEJBYiE3fkrEmK+7IiqOP8NWM3nfe2x8W3DjPET7Y0tvL3 olhXRCx4tRJ0m6a1jORLy2E9OS9581JvCcxD7i9ZpV2T0O8urp7dUiflo N8hg4ib0UFdSn+gOOPpYnApB15VaUUlza2iEvZOgX65K6ZR8kbib/HfZm g=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76933073 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AdIrv+6KjlqATiKahFE//H55y3J0nRxNeGxL0i?= =?us-ascii?q?kilI80cnZWQUeEPdw9qPMoIMlI7Zkq1ybYU6pjk1CcKHzt1ght/QUK0NyA2K?= =?us-ascii?q?EpqG9lA2JNDUBPUje0YwoEHz3Ja7MxMpXWQ7QQlt0yKgMcZUAcEg5gMNkkTO?= =?us-ascii?q?fD2cQK/E294acydWC6odUkRQ/6V6RiSbpLfIHHDY9r0CF3pauzThPh+POmYy?= =?us-ascii?q?oL5TN3WsLCy6cAYIIKHz6GVwVC15dVudqtm3w1GOuFK3kxO7cBmMHg54luXF?= =?us-ascii?q?V7Ybo76rfLd8no1rUnRPXspg+z10KiapIFWAi5fHJfICtd2EfkNXlqk9PtEz?= =?us-ascii?q?fYLQWVg+OhkPAB2lHX2+aL8nJxcKBKR6GgactTX3VRAqOxZKHZrR6QVdzpFD?= =?us-ascii?q?Rn/JKV1m5zIWbSP98WdJHAtfibcOUOQRl9fYwSaGfCkXvD2yrfratdekFnU0?= =?us-ascii?q?O8CHrKJX+1AKbQfV5xc5zEAPeEVo3+EzPSUXqQWmFHVq8T8Ns5NcgNJbvRJp?= =?us-ascii?q?fUFvPmszQc/UAJV2d/2lFxnOcObWMif0f+Bo4QHBzC7sStI4rDC4VnjM/MsK?= =?us-ascii?q?uJbA/tgJd1YpwnBc+wrKnSh59QAtI0O6FbZ3qK8KGmsGfYcfbZa1VuR5Ddtn?= =?us-ascii?q?TcUqdxj1w9uvjGW1n92yrxiUGvwazgyzZsAaVXyvDHPRFRFL61iZx9Tht5Oy?= =?us-ascii?q?OS5Z0ou74xClZpfG7QOmMCZ5RYV7SICpP8yhG38HDEb3VGQfUXoPz0FuScGy?= =?us-ascii?q?OL59fJIM9294UyjKanKbcXkKxLKsTH2U5cq4zG0YaFFbGGQm8LJ0v/XSjPAV?= =?us-ascii?q?yb4Oo6gZp8DBnbKMlNjT2nZ5wU9AgxDgqmuTzcY53xsahir7vx9ckrR+k6Do?= =?us-ascii?q?xSMEcd1WJajeSI0XOso1rTnbKLGUIGvnCcBpkxuTuWTz0Wwn8qMQ6aiGZSw2?= =?us-ascii?q?0Qspq/kUOIzhsocWbx48lTc7V5hhFr7f6VeE4n3AAcmGNa/V3aqL0JO1sEfn?= =?us-ascii?q?uJrXhvUA6u8cOeQM5D4E0eCTnaLWEHJQ9mWK7VFcLtJsxrOg+0NmcXIQk+Tf?= =?us-ascii?q?7ZmSEvWqNKEqbe4RECbPbjU+NQhlQLKMX2YfRPnhS4LJZDflZP6PRy6JhfMa?= =?us-ascii?q?YwC1gO02R4F1m/7RBU+t1k+U1E2BnbmKmbclL1kwBA89KBgfypqeBKBDqumF?= =?us-ascii?q?Rh4VD5l46YK/ViFQTCd/muD0MVN10D8EbPplA2K4nsivseSBLpavASwH8N9t?= =?us-ascii?q?UevErGaZtBAAffwGDH7yQGiGigkfM3ZutesCbGoVapxdD9a2idmrpG7Lt1z5?= =?us-ascii?q?h8gAMpi+DkJhetLLMO1TEmtt7CuTt79v4xKqiZsdFL1LsQ1T28BRpZm39vhy?= =?us-ascii?q?O5Xh+yJN2Hdc7EiB7BT6WWwpBqtEKniOPGrgPFL9MUtmt3Y6VK2M29wRjJ4U?= =?us-ascii?q?0yd9Pefsdxe2+bTa5R6nvxL5AkIQWFGsIx/MwYNJRI5tPLoisZvWD8wcQXF6?= =?us-ascii?q?QcyJKwzBtCpdHp3RpyknTGV0UJW1WVCjQfyr2VSmZOgdAfZbiF30KkCyhZjN?= =?us-ascii?q?Vlj6GwhVRylNv43kswKnKhilLfwAsOvKd8FXKtx6mN9lj65kdA7exq9mSunp?= =?us-ascii?q?G5wNuaKRdu8aFe/UWTL9KIsc909Hko6HEUyBjB5pNEA0Z3ZQXH7sVNLJOGj5?= =?us-ascii?q?T8ryej2OmTH4IvXvdF3+lFnCxRFKZ0jU34GFlsg6FPP/2ghQy2ZeD+cl1L8v?= =?us-ascii?q?PDhbuj2haNwOfa6DfwW26tOiM4sv8sdCnaX/hg+///WiH7kz5cVNrD+xr9yK?= =?us-ascii?q?ZOxKg6n9fqAYbS25A6hYaNFP9Hk80jU/2zuZeVWwlg+gk1qED15RmPSlDEgs?= =?us-ascii?q?/yZQrIxcWU6Y1JdPt9jIldkiLxfW73q2U68prKLt3pa7YP3uIzB9USu+4Z0E?= =?us-ascii?q?66vQzq81+jtTsYcbyRdqXoX0gzNFNNJcdHJ2KA6CgHZNN+IETeHnCCrLmFJe?= =?us-ascii?q?5bQI+jWpJmpORQbU7NaHyxjYNlUA9IOVUBa/2G+DjaEQaFVJYVTAw2+xHuma?= =?us-ascii?q?4lh/Pl+/34+yZkvxRnUn6CDnYvpY9rb0+FkJb2THM6I7x/SYRbBl/Zk1w/bY?= =?us-ascii?q?CzgT7oVGTxXjJICPpXalL7m5hralhYWTPFnJu7bgsL3fLGiOSoy3B3oQiQuZ?= =?us-ascii?q?J5VJ3ZkGHWswnvyC1rn/y8vv2M+LTVr21iN/IwO5r3exsI527WoTfJW/p15+?= =?us-ascii?q?IB0FshXe+ihMs+UxL+PLiBkDLBS8BncdqpGuty37+z4HJ+myPAXA78qeAAHx?= =?us-ascii?q?m0/HRwzKD4y+3pKGI4d7GWL+hQ6ceiM4jBFuCpU2ClleDCtn/sn/0/78W/IO?= =?us-ascii?q?8XPE3KhW895dGRhS8XSa/Ou97UJBV4WC1TJxWIT/+vzEVFwkUHtW4bgH45so?= =?us-ascii?q?EDTBbZrVAtGW7qe3ycGbH7bdWFGZYTAJmbu3AH1pN2gAMRCVT1/+vcQf0tKS?= =?us-ascii?q?aEw7W/iJcOFVX09jTARq6alGE2nLZKKTKpV6ATwm+hJMzV/DMEMwwWF/w6N7?= =?us-ascii?q?OFP6MbejZV3KimGzhK78tuuOZaiJ3oHbeuINMqpsT8jnewG6NbAedGINA5BN?= =?us-ascii?q?ueqWz5S0FAjEfuJ4nl1ybLsrCUoHppPAbZy/zbiVkefFGGdWacQD4wZOtdIv?= =?us-ascii?q?ClT5LlJlKh8xnFeL/FPFJ7oaxRtE/do8lO+RArqI5YsEesVKmTaOOMGpWi6o?= =?us-ascii?q?n0q3YOnuaShQcll50ExwUqKzl9gQL2bIXGNBEPJ5kH1f4S5yPJRzz196EUGo?= =?us-ascii?q?X0knfh0yfU6k3FepGO0Nh6fsdTD4nvUlirBTFVf4NoU/M2L1w=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76933073" From: Anthony PERARD To: CC: Juergen Gross , Wei Liu , Jan Beulich , Andrew Cooper , "Roger Pau Monne" , Anthony PERARD Subject: [XEN PATCH stable-4.16] tools/libxl: env variable to signal whether disk/nic backend is trusted Date: Fri, 29 Jul 2022 14:26:40 +0100 Message-ID: <20220729132641.21221-2-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220729132641.21221-1-anthony.perard@citrix.com> References: <20220729132641.21221-1-anthony.perard@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit From: Roger Pau Monne Introduce support in libxl for fetching the default backend trusted option for disk and nic devices. Users can set LIBXL_{DISK,NIC}_BACKEND_UNTRUSTED environment variable to notify libxl of whether the backends for disk and nic devices should be trusted. Such information is passed into the frontend so it can take the appropriate measures. This is part of XSA-403. Signed-off-by: Roger Pau Monné Signed-off-by: Anthony PERARD --- changes: - envvar now upper case - documentation in xl man page - value "0" also mean "trusted" --- docs/man/xl.1.pod.in | 18 ++++++++++++++++++ tools/libs/light/libxl_disk.c | 5 +++++ tools/libs/light/libxl_nic.c | 7 +++++++ 3 files changed, 30 insertions(+) diff --git a/docs/man/xl.1.pod.in b/docs/man/xl.1.pod.in index e2176bd696..45e1430aeb 100644 --- a/docs/man/xl.1.pod.in +++ b/docs/man/xl.1.pod.in @@ -1946,6 +1946,24 @@ shows the decimal value. For non-linear mode, it shows hexadecimal value. =back +=head1 ENVIRONMENT + +=over 4 + +=item B + +Set this environment variable to "1" to suggest to the guest that the disk +backend shouldn't be trusted. If the variable is absent or set to "0", the +backend will be trusted. + +=item B + +Set this environment variable to "1" to suggest to the guest that the network +backend shouldn't be trusted. If the variable is absent or set to "0", the +backend will be trusted. + +=back + =head1 IGNORED FOR COMPATIBILITY WITH XM xl is mostly command-line compatible with the old xm utility used with diff --git a/tools/libs/light/libxl_disk.c b/tools/libs/light/libxl_disk.c index 93936d0dd0..67d1cc1857 100644 --- a/tools/libs/light/libxl_disk.c +++ b/tools/libs/light/libxl_disk.c @@ -246,6 +246,7 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, libxl_domain_config d_config; libxl_device_disk disk_saved; libxl__flock *lock = NULL; + const char *envvar; libxl_domain_config_init(&d_config); libxl_device_disk_init(&disk_saved); @@ -395,6 +396,10 @@ static void device_disk_add(libxl__egc *egc, uint32_t domid, flexarray_append(front, GCSPRINTF("%d", device->devid)); flexarray_append(front, "device-type"); flexarray_append(front, disk->is_cdrom ? "cdrom" : "disk"); + flexarray_append(front, "trusted"); + envvar = getenv("LIBXL_DISK_BACKEND_UNTRUSTED"); + /* Set "trusted=1" if envvar missing or is "0". */ + flexarray_append(front, !envvar || !strcmp("0", envvar) ? "1" : "0"); /* * Old PV kernel disk frontends before 2.6.26 rely on tool stack to diff --git a/tools/libs/light/libxl_nic.c b/tools/libs/light/libxl_nic.c index 0b9e70c9d1..f87890d1d6 100644 --- a/tools/libs/light/libxl_nic.c +++ b/tools/libs/light/libxl_nic.c @@ -132,6 +132,8 @@ static int libxl__set_xenstore_nic(libxl__gc *gc, uint32_t domid, flexarray_t *back, flexarray_t *front, flexarray_t *ro_front) { + const char *envvar; + flexarray_grow(back, 2); if (nic->script) @@ -255,6 +257,11 @@ static int libxl__set_xenstore_nic(libxl__gc *gc, uint32_t domid, flexarray_append(back, "hotplug-status"); flexarray_append(back, ""); + flexarray_append(front, "trusted"); + envvar = getenv("LIBXL_NIC_BACKEND_UNTRUSTED"); + /* Set "trusted=1" if envvar missing or is "0". */ + flexarray_append(front, !envvar || !strcmp("0", envvar) ? "1" : "0"); + return 0; } -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:26:56 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:26:56 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377530.610754 (Exim 4.92) (envelope-from ) id 1oHQ0y-0006rN-MI; Fri, 29 Jul 2022 13:26:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377530.610754; Fri, 29 Jul 2022 13:26:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ0y-0006rG-Jb; Fri, 29 Jul 2022 13:26:52 +0000 Received: by outflank-mailman (input) for mailman id 377530; Fri, 29 Jul 2022 13:26:51 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQ0x-0006rA-BQ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 13:26:51 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 18f6d5e5-0f42-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 15:26:49 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18f6d5e5-0f42-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659101209; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=ollH2/IbyT5gpdGN2TR/c3jDymz+7HbuAnFWlnxMzig=; b=MQENVtJMDfn764onIWkomkWCNP5FZaampDE535wjiEYzNi/qbGf9Vtot hB4JGZJHFdq9HtDMFBaHo2Of07zk3iiwxW7lY7WRbOyDS+MxM0caQ701o LuUZki19RwdOpmFwXR835Pvfn7T3nnAS0jEEizo0rfzaS2LTsUZXRUcwW w=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 77366454 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:JNhiXKp/KSg1zQii8X+4SYtd3yZeBmJgZRIvgKrLsJaIsI4StFCzt garIBnTa6uNZGT2Ktl+a9nk8U5Q7JPRndAxTwpprH88QSgQ9puZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lJ5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqUe4u8oJGV0x cYhOXMfUlPZm+iY27ikH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIWKIYLUGZgJ9qqej kL65Dz7Pw0UDeaCjjih7l+H2bLQuiyuDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWWdhSN kgV8SoGtrUp+QqgSdyVdw21pjuIswARX/JUEvYm80edx6zM+QGbC2MYCDlbZ7QOtsAsQicx/ kSUhN6vDjtq2IB5UlrEqO3S92nrf3FIcylSPkfoUDfp/fHluIhsqxb1fuxaAe2nsp6vBTve2 DqV+X1Wa6oosSIb60mq1QmZ3mP0+8mUFl9dChb/BTz8sF4gDGKxT8nxsAWAs64dRGqMZgPZ1 EXojfRy+wzn4XulsCWWCNsAE7iyjxpuGG2N2AU/d3XNGtnExpJCQWyzyGsnTKuRGpxYEQIFm WeK0e+r2LddPWGxcYh8aJ+rBsIhwMDITIq4B6iPNYEePscrK2drGR2CgmbJhQjQfLUEy/lja f93j+73ZZrlNUiX5GXvHLpMuVPa7is/2XnSVfjG8vhT6pLHPSb9YepUbzOzghURtvzsTPP9r 4kCbKNnCnx3DIXDX8Ug2dRLfQ5SdCRmX86eRg4+XrfrHzeK0VoJU5f5qY7NsaQ890iJvo8kJ k2AZ3I= IronPort-HdrOrdr: A9a23:a/aBN6CirQX8CMblHemm55DYdb4zR+YMi2TC1yhKJiC9Ffbo8/ xG/c5rsCMc5wxxZJhNo7290cq7MBHhHPxOgbX5VI3KNGKNhILBFvAE0WKI+VPd8kPFmtK1rZ 0QEJRDNA== X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="77366454" From: Anthony PERARD To: CC: Juergen Gross , Wei Liu , Jan Beulich , Andrew Cooper , "Anthony PERARD" Subject: [XEN PATCH 0/X] tools/libxl: XSA-403 follow-up Date: Fri, 29 Jul 2022 14:26:39 +0100 Message-ID: <20220729132641.21221-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Hi, Two patches: - one for stable branches (I've rework the XSA's patch on 4.16 so patch will need to be backported); - and one patch for staging, forward porting the patch for stable branches. Those patches are a rework of the patch for the stable branches available in XSA-403. The environment variable is now in upper case, like one would expect, and now a value of "0" as the same meaning as the variable been absent. Also, there's a bit of documentation in `man xl`. Thanks, -- Anthony PERARD From xen-devel-bounces@lists.xenproject.org Fri Jul 29 13:42:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 13:42:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377548.610788 (Exim 4.92) (envelope-from ) id 1oHQFU-00025b-HE; Fri, 29 Jul 2022 13:41:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377548.610788; Fri, 29 Jul 2022 13:41:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQFU-00025U-Dg; Fri, 29 Jul 2022 13:41:52 +0000 Received: by outflank-mailman (input) for mailman id 377548; Fri, 29 Jul 2022 13:41:50 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQFS-00025O-OT for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 13:41:50 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2086.outbound.protection.outlook.com [40.107.22.86]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 31f494f3-0f44-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 15:41:49 +0200 (CEST) Received: from AS9PR06CA0294.eurprd06.prod.outlook.com (2603:10a6:20b:45a::22) by DB9PR08MB7116.eurprd08.prod.outlook.com (2603:10a6:10:2c9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.10; Fri, 29 Jul 2022 13:41:47 +0000 Received: from AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:45a:cafe::eb) by AS9PR06CA0294.outlook.office365.com (2603:10a6:20b:45a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.7 via Frontend Transport; Fri, 29 Jul 2022 13:41:42 +0000 Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT040.mail.protection.outlook.com (10.152.17.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.12 via Frontend Transport; Fri, 29 Jul 2022 13:41:41 +0000 Received: ("Tessian outbound 2af316122c7a:v123"); Fri, 29 Jul 2022 13:41:41 +0000 Received: from b1b73cf850ba.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 994084DF-A122-4FE3-9BCC-5C56D15F2DD8.1; Fri, 29 Jul 2022 13:41:35 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b1b73cf850ba.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 29 Jul 2022 13:41:35 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com (2603:10a6:20b:85::25) by AM6PR08MB4801.eurprd08.prod.outlook.com (2603:10a6:20b:c1::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5482.11; Fri, 29 Jul 2022 13:41:32 +0000 Received: from AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a]) by AM6PR08MB3784.eurprd08.prod.outlook.com ([fe80::f474:4549:1f7a:b89a%4]) with mapi id 15.20.5482.010; Fri, 29 Jul 2022 13:41:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 31f494f3-0f44-11ed-bd2d-47488cf2e6aa ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=MECUbBZs6OsPZTg/+QBNv5+oGY/5BO2gf8Ku9tgGMgMgJuQaFMnb9QCfo33RY5DtfSNW3IG3e++20tuNVt3U2asMrbPr1MNzGjQYrinwQEPBbfL6XWE0adHvSs9IyU0Pjc9fvEVD0+FxWvtaluoHsnfswGj2y6vUmjM4ms4TfYE251ZGxRP272gv4B6MMSlFHcVz/Ykk9mcTPNKw+lLAouvza4+G7frUJAG10iLZlfm7metx8jiABvZt5SdPKr94KooTBmEPQenDRY1GD2VasbXjkdJoEyPVkOGaEYtgsUmvlIh4PclIrEBXl7Y9wgppkIQBbig1Q8lC44amRNciPw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=stvcMF83vcZQt51gnH9t9FsnHibwpgZKyttr3IFmHrs=; b=f1Md6qp7JWF1EEJNeq9wgC+Y5/dlcUUQj/9imgl+ZDMOEL1U1M8viS0DfuHQf3lE/tpOplxtsQ1/AikiaVho2kIBVaP28p+Sm0O6Wp1ujkq/VDF2KaLoOB7R5kYuqdwR8c3UX7cUPm5fcGBHD0qr+woX61AvnzKxv587FGBp2T2FTf3uXA7+0JVLkLeoBi2eEvSpn5T/i69uquDauGwceBh32nO+4Wz6wc0zne69XyIomlmioWpCF7Ltah8hZiGf9v8o1TAXjKUj7GTXsK4roKSkaJfhzxrgKV4SIvTAUmc/qNn6BKvCXxFA1jqM8TN7Fs4/ycclFM75kIP4JMgBpg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=stvcMF83vcZQt51gnH9t9FsnHibwpgZKyttr3IFmHrs=; b=5J0ap1YqIyIM3ZCltOzJqe+MbFYsTyTMveUQBnvt0+3ZGnAgbYotDwBQF44FWL8pEHYggXt0MY5/FqSBkO2tFu50JSEjKBsmy80sAq0eC4RHhFXdA8TB6qP/LNQRqz0QNfaoNZbhi5RuFSm1mi4AT8IA9WoC2mr5ekHTpbHXoy4= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-CheckRecipientChecked: true X-CR-MTA-CID: 05cbabe1912763ba X-CR-MTA-TID: 64aa7808 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cjHwB7epAr9Qlq/0OOxfdCOWDTHydIzWHS6yA+zveU0EpPHrENBKaDrheQuGZoLAcHtdhr0ACr0t4e/KcNIonUtJv65AahSDt6qD8OpbQ0mZF2adTRsM4RWn2b0xQaXZJr2+qsMGxzJ1MFofa8CkEe5bZh/VetX5HHdwTjIyb0cFK+OhmOmTcDZNrWn5ClaqjJ2KThrkfxY186HjVyrkwdkpA1JmRhQldjhijf6pHHSCKkS6/4G0M/zIJoDqEYJgJad9iyU0aZgqF5VcccLMt6GjNuKl+ZfjSb0mUoORk5RXwPqI38Qyf46VpnGLzD/TA6VePo4g6IQfwCYLfZrF/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=stvcMF83vcZQt51gnH9t9FsnHibwpgZKyttr3IFmHrs=; b=ACmHZ0aauEX75Ako8wgbViqegEoODFirqZrwdkJL6yu1FDFrGIP8SPdc386Of2mVIGkKTLgEk1k66Loi4H9v6nD1FgPWZ/+PHGJNwFIzLR9CYagynD2HoFFJyWyEBrkiejmSMvd1Ehbrxi133qSmnGRzWqnsYZw0UFRLFkrAjogUbXf1SEO+GCrmRpVUtrjFn3VtqWypYNUkkzXdq1CXrcmJweUaySE5egzOjydEdyGamxDWDMxHNgTb1kMpFaiK7tfaVOKMf7CT8Ve5KTgl8nYDI1IBrEfnuaw1zEIQEfRQahd2ouO4NprwMTN7i7JV8jfoR4MX2bjYNUxCc0+2gA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=stvcMF83vcZQt51gnH9t9FsnHibwpgZKyttr3IFmHrs=; b=5J0ap1YqIyIM3ZCltOzJqe+MbFYsTyTMveUQBnvt0+3ZGnAgbYotDwBQF44FWL8pEHYggXt0MY5/FqSBkO2tFu50JSEjKBsmy80sAq0eC4RHhFXdA8TB6qP/LNQRqz0QNfaoNZbhi5RuFSm1mi4AT8IA9WoC2mr5ekHTpbHXoy4= From: Bertrand Marquis To: Xenia Ragiadakou CC: Jan Beulich , Stefano Stabellini , Julien Grall , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Thread-Topic: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Thread-Index: AQHYop4zbGg59w4f8UOqc93PZGjmt62U4voAgAABWICAAHhDgA== Date: Fri, 29 Jul 2022 13:41:31 +0000 Message-ID: <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3696.100.31) Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-MS-Office365-Filtering-Correlation-Id: 23cc294e-37f0-4710-c891-08da716811d8 x-ms-traffictypediagnostic: AM6PR08MB4801:EE_|AM5EUR03FT040:EE_|DB9PR08MB7116:EE_ x-checkrecipientrouted: true nodisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: BcD39+5EwFATNFocURQCwSr1EAg17uVoBtqFBrM+VzzbkCWn1s+crCFryeAuGQQrmMUq30M/83SuK+yZZnICuSAl2UdNJ1BNK4YVeCPRCPo+O3E7roSgnNqzkWevacbq92QBNgNEaaGKtizLEfu24HSXkzHXsnJMDPe/QYAAVQePNneBU8C7ZJqr+/lN+gkNNU8UO9WH0/Bd3maMjbeIvlYE6vEtau87zPHa6N/zpPnJdN5H2ga6aMKzJ9yOvsC7hmJ9ca40B3FrppG2KdImsGSRrBJb8OoGcZ/aAVZa8ifh4kE+XWZ5LCxVIcosRrbfoSQhPQXEa8uZGHaPTuvNKlG9kzowHtcDOq0vKinWSNN8/WuQ1WIbqU0K3OBJSHSqUAqRmw1PXPwpG2Ht+LgcI0rR/XvcFnP9kOFgooY38fWwWSH0XalzczmGpYHNlWEOfFrEKAMs1torEnUiUBYQVhjlGqb+PyztZciVXO42j4HAu8c4ANzpkF4gcO9Hl00zZechuJpzfXSeaQ0ssiab3WC9HrLSkZ9Xiev6xTO64XA6Qj/RvDmL3ympNUNxfbc5waFyispxFJHLTf2h/n/iULp01i0bf9T6CQNirqi88d5I5RDvY7e6yhRm+ZCAoXCWAnfLNoqDvMdoMEA0ivToVGI1b8KQcJlmTI4ngT46o9sbIiyJSzCQ9i4ZUmRgpmQSfb0OjqKfzkjwliuRkqx0Ar2yIZLkf1CgolQX1eyB+kQUyfizQD/edTiU+ZZ6CLalOmX8+MRDHmGZiO28b8X7UrHyk8DO3h4AIFa/ypnaEQ/fmjIZ12rwcFrQhJumZH+5cbh1OmKaHeBmjAC1Fa5Fiw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB3784.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(136003)(346002)(376002)(366004)(396003)(41300700001)(6506007)(86362001)(53546011)(6512007)(26005)(38070700005)(122000001)(2616005)(186003)(8936002)(38100700002)(76116006)(33656002)(4744005)(66946007)(5660300002)(66556008)(66476007)(64756008)(4326008)(36756003)(66446008)(6916009)(2906002)(8676002)(91956017)(6486002)(54906003)(478600001)(71200400001)(316002)(45980500001);DIR:OUT;SFP:1101; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4801 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3d6b6ffd-e2ec-47aa-7299-08da71680be2 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tFy7xJ8brEdPPzn03L2xUhUfKT75LGyYTFZ/wMxy5YaHbCkVgIymVYfFF7N3PHp03KOxKGRZ3cu0ocjoKFxoNWtx5+3YyJ1vLE3PtmEbhIfdc0gjpWGEh6z9cnfI3NeiOn32FjIAof9DnR4E3p/mKRTQvS7GAIqRfLYD56ba53bKoIC10/aOJwzweBuCPMEz8KBRtixhUOmFZ3YrAHoo3PY7fDE4MMX3+hd2SynelM5qF4mkrlIQ/CE5l1XoijB5B65Oe1vg6xIKka4Nc0f0VAY8B7KMhrsDqU14uOwOW4nH8G0dJ5LezLKh27rmdXFzbHFfRFiKX21CTwJuoVLeWX6Wm4yFy4csMTwT7NfnEPZq+/nPzH7xYd8onUE9ugfbBNOA0jDMT8fT/3pFu705jn0T4L0kg7xz5pv9XgM2b8DGenes+ug/8KE1xIcMBdiG2YhiTNjOS7ds2BNbSjRSgqVlHUHQkSBykYdYLsRvG2e7AJo/Xm8INhvV5jacNKOsmDb8dJnr2+AUA9yebKjAJi+YeWJJChV9R4d/FoP3TovO5jK2Z2cf3QgMlCRjFzFoGipgp6NjWaXhxV8/O1CwB0lV7+8KWxXxv/6YbYTcAtQ+U9mlYNLkn6iOp3epF3CQrhOUfM0FSiC6CUm3F7sfGrv2vdkC3WC76XL2Y8aFDedWQWbI2LO2OQ61Py4CU58k51hPXINh340gxk8rXrbl6124XdugVCpPQ440uu+jZgtbzIJfjzESULyFefYUEz9D+NuPp1QTzZsRSb3UaXldvyyTBE90Ia26YIdHCD+miR6eyqdZON83grhx7ZowNeK9 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(136003)(376002)(396003)(39860400002)(346002)(36840700001)(46966006)(40470700004)(83380400001)(336012)(186003)(8676002)(70586007)(70206006)(2906002)(47076005)(316002)(4326008)(53546011)(36756003)(2616005)(54906003)(6512007)(6506007)(26005)(41300700001)(356005)(86362001)(40460700003)(33656002)(36860700001)(40480700001)(82310400005)(6862004)(5660300002)(8936002)(4744005)(81166007)(82740400003)(6486002)(478600001);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2022 13:41:41.5678 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 23cc294e-37f0-4710-c891-08da716811d8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT040.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7116 Hi Xenia, > On 29 Jul 2022, at 07:31, Xenia Ragiadakou wrote: >=20 > Hi Jan, >=20 > On 7/29/22 09:26, Jan Beulich wrote: >> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>> --- a/xen/arch/arm/domain.c >>> +++ b/xen/arch/arm/domain.c >>> @@ -63,7 +63,7 @@ static void do_idle(void) >>> rcu_idle_exit(cpu); >>> } >>> -void idle_loop(void) >>> +static void idle_loop(void) >> While you're adding "noreturn" below, shouldn't this one be marked so >> as well? Preferably with the addition: >> Reviewed-by: Jan Beulich >=20 > Yes, but I was not sure if this should go in this patch or in a separate = one. As you modify the function to make it static, I think it is ok to also add = the noreturn in the same patch. With that done, you can add my: Reviewed-by: Bertrand Marquis Cheers Bertrand >=20 > --=20 > Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 14:03:57 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 14:03:57 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377555.610799 (Exim 4.92) (envelope-from ) id 1oHQak-00050j-B2; Fri, 29 Jul 2022 14:03:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377555.610799; Fri, 29 Jul 2022 14:03:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQak-00050c-7d; Fri, 29 Jul 2022 14:03:50 +0000 Received: by outflank-mailman (input) for mailman id 377555; Fri, 29 Jul 2022 14:03:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHQai-00050W-Nw for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 14:03:48 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 4317ce0e-0f47-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 16:03:46 +0200 (CEST) Received: by mail-ed1-x52d.google.com with SMTP id w5so5914133edd.13 for ; Fri, 29 Jul 2022 07:03:46 -0700 (PDT) Received: from [192.168.1.93] (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.gmail.com with ESMTPSA id k16-20020aa7d2d0000000b0043a6fde6e7bsm2403100edr.19.2022.07.29.07.03.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 07:03:45 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4317ce0e-0f47-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=j5Yz/Xjss3H9E9SD2eUZecqkfFFQnVIl+HJzuFb9IwU=; b=AwUB+33/SPZyiYuru7nMz39kdD4XaogxfYTRFOiZoGl6lDbPZSJvfM55qYTt6BU2mt fDAduUdrR8cCseO+6EKvNbpRCBBNq6clfW67DFxUmXGmaoBemYlPSJKMqgu11jm7V0yU jdBOTUE+juAi8RyqLOwL6xE2x/SI7y/QS9EQqqT5zGLwCLF/5RMYjkZQwo0IrJqYiVHP X5Wzg+EhDq3tD/oklzEwXQSJWw8bPTmBNXXbPaKGPj1hyywg8KpqF7PYqH4kb3ajTn2b chu2UZYqRxE2OwR4CKHwAlfjwzTJRMZG7xvd6KVNQLL8MX305wl0u1BnLF+Jqn8zxSwm 4VJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=j5Yz/Xjss3H9E9SD2eUZecqkfFFQnVIl+HJzuFb9IwU=; b=lKHQ8lRBySmxv2p3BdtKSt1Donnxw0H7gHmm/HU0oEztCeohFASYbk7goidJ8D6q0F E+MUOGOZ8Eb5F6RzF3blchDuA6Y+zBKbPqU8MTS+JbjB9YrQMhvkwEWJvwbukymTv+6r fbd3PNPiPFZn5f9+NwVDU6teDuZYKjleAVoVzneV2W44GDo8xVH4JVlnAyOAn0VSvToi 6iqUZ2dXzHb2ksXGWQlQCDgLpEAZyBIyX6MypbYwbd6jBu2P4tb94+mkr+s2M7RBnV2g dS4+Y4F0QZWhowepLAaBfBj9A7zxgSlv6V1DjHD9vzAuT0HXbTOyFo9W1ExHhEAZhFL6 iC0Q== X-Gm-Message-State: AJIora+wtm3WfDF6T5zf0l7MTuXzqD3mC3E+NjSYIowj9jBW5cKQr9eN i4dvRQkQQ8+Iofrr/8gOi18= X-Google-Smtp-Source: AGRyM1uXn6m2/lWtaAfIVV0VBkVTaOjlDnLn4r1b7YhIjqLgyBUVZFxXVFrnuVO0ktYnlLwAbOWgSw== X-Received: by 2002:a05:6402:518:b0:43c:a863:55b with SMTP id m24-20020a056402051800b0043ca863055bmr3704847edv.127.1659103425740; Fri, 29 Jul 2022 07:03:45 -0700 (PDT) Message-ID: <01bb7315-91a1-de7a-2c17-c6772f740619@gmail.com> Date: Fri, 29 Jul 2022 17:03:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Bertrand Marquis , Jan Beulich Cc: Stefano Stabellini , Julien Grall , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> From: Xenia Ragiadakou In-Reply-To: <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/29/22 16:41, Bertrand Marquis wrote: > Hi Xenia, > >> On 29 Jul 2022, at 07:31, Xenia Ragiadakou wrote: >> >> Hi Jan, >> >> On 7/29/22 09:26, Jan Beulich wrote: >>> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>>> --- a/xen/arch/arm/domain.c >>>> +++ b/xen/arch/arm/domain.c >>>> @@ -63,7 +63,7 @@ static void do_idle(void) >>>> rcu_idle_exit(cpu); >>>> } >>>> -void idle_loop(void) >>>> +static void idle_loop(void) >>> While you're adding "noreturn" below, shouldn't this one be marked so >>> as well? Preferably with the addition: >>> Reviewed-by: Jan Beulich >> >> Yes, but I was not sure if this should go in this patch or in a separate one. > > As you modify the function to make it static, I think it is ok to also add the noreturn in the same patch. > > With that done, you can add my: > Reviewed-by: Bertrand Marquis > > Cheers > Bertrand I consider this change unrelated to the patch. I think it is a bad practice to squash unrelated changes in a single patch. Also, I do not think it is unfair to be obliged to make it in order for the patch to be accepted. I could have taken the opportunity to fix this in the same patch but I decided to not take it. -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 14:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 14:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377563.610821 (Exim 4.92) (envelope-from ) id 1oHRM0-0002sl-8M; Fri, 29 Jul 2022 14:52:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377563.610821; Fri, 29 Jul 2022 14:52:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRM0-0002se-5M; Fri, 29 Jul 2022 14:52:40 +0000 Received: by outflank-mailman (input) for mailman id 377563; Fri, 29 Jul 2022 14:52:38 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRLy-0002gj-K8 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 14:52:38 +0000 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [2a00:1450:4864:20::52d]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 1650fea9-0f4e-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 16:52:37 +0200 (CEST) Received: by mail-ed1-x52d.google.com with SMTP id w5so6090305edd.13 for ; Fri, 29 Jul 2022 07:52:37 -0700 (PDT) Received: from uni.router.wind (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.googlemail.com with ESMTPSA id b1-20020a05640202c100b0043cf2e0ce1csm2415545edx.48.2022.07.29.07.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 07:52:36 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1650fea9-0f4e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EpWGAxivG7VA1SFITY6jFALNeBUNtuGNZf8UrIE/8cE=; b=J2GfQJf+0aka5YXUMTEUH4QZh8ludkA3wGUd1r0nygz3LfjE4n80GfIeKcU0AX5lw2 HhTxShERlM+d78TVABIFGhZa4364O8iQ2HdcfOi+TgPirNF/CgNWAnOBOR6ZHkJ61Vbr H0KqjNk1BK7I9UV9GVUVxRzJde3oyF0ISbwlgd56/qKDZYH3uOLS6pwakqtyqPvelNHB 7b1EB8y20JDE6j8JUVWeS/j5UElZAp843h39cJqXr/6FV5uSRYUnBaJZGbqqeQwGC9dh 6daEHW09q5Wpg4BZfFHDLyU06VJVnLStuwlnmD+yKixTm7hLi+PdvRIyTt7YXoWZJyVe 7T+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=EpWGAxivG7VA1SFITY6jFALNeBUNtuGNZf8UrIE/8cE=; b=eI75yE7m0jn8ACGWmEy7NkzT6WbnwsuJa1WmVtYSdnSAEMSehFenlEhwMCt0C1XrmV OkR7Mga98qykzlbXD6t5wTLaySV9uqUfIecVm76Wo1C30ZZjaXSORG23qGcDAYIPqLAR w+AGS1y4whmIAPKpQ4z0aLVQIX48ICrocnT83Cf7ou/mKQhESI0XrlRTm4Z+yM+5JtcP El6UxAoCI8F8ixrkxPPnzn34i1y5YJisdTdMU2tkPxyvS3Xq2TyiM12VW6lCT8xns47g JyC3VfxLSuTD8gHs2QyS7ShF9P1f6xRjo4xUqL7N0ExATt8DPrTdZXzaVhMHMDdmOYIn yVpQ== X-Gm-Message-State: AJIora+tFVqyecdewq0YcqaAd+/qdKf+K2mcn8l072low7p/oF0ahr/q UILSfjRjGASqPQ64zNvhYgwC+vhgfRmM6A== X-Google-Smtp-Source: AGRyM1vjJh/vLa+qnPgcaVQz8m9J8iob0PA469RrrF+0gAB65qyaLWRTpl1ONytCDmPypF1URktgEA== X-Received: by 2002:a05:6402:d05:b0:425:b7ab:776e with SMTP id eb5-20020a0564020d0500b00425b7ab776emr4050804edb.142.1659106357006; Fri, 29 Jul 2022 07:52:37 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 1/3] automation: qemu-smoke-arm64.sh: Remove some stale comments Date: Fri, 29 Jul 2022 17:52:27 +0300 Message-Id: <20220729145229.1250221-2-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220729145229.1250221-1-burzalodowa@gmail.com> References: <20220729145229.1250221-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove comment "# Install QEMU" because qemu is not installed, it is taken from a test-artifacts container. Change comment "# Busybox Dom0" to "# Busybox" because busybox is not used only for the Dom0 but also for the DomU. Signed-off-by: Xenia Ragiadakou --- automation/scripts/qemu-smoke-arm64.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 898398196a..f483a2ffc1 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -21,7 +21,6 @@ fi " fi -# Install QEMU export DEBIAN_FRONTENT=noninteractive apt-get -qy update apt-get -qy install --no-install-recommends u-boot-qemu \ @@ -44,7 +43,7 @@ sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb -# Busybox Dom0 +# Busybox mkdir -p initrd mkdir -p initrd/bin mkdir -p initrd/sbin -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 14:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 14:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377562.610809 (Exim 4.92) (envelope-from ) id 1oHRLy-0002dL-0u; Fri, 29 Jul 2022 14:52:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377562.610809; Fri, 29 Jul 2022 14:52:37 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRLx-0002dE-UO; Fri, 29 Jul 2022 14:52:37 +0000 Received: by outflank-mailman (input) for mailman id 377562; Fri, 29 Jul 2022 14:52:36 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRLw-0002d8-HB for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 14:52:36 +0000 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [2a00:1450:4864:20::533]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 14b0b332-0f4e-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 16:52:35 +0200 (CEST) Received: by mail-ed1-x533.google.com with SMTP id a89so6126143edf.5 for ; Fri, 29 Jul 2022 07:52:35 -0700 (PDT) Received: from uni.router.wind (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.googlemail.com with ESMTPSA id b1-20020a05640202c100b0043cf2e0ce1csm2415545edx.48.2022.07.29.07.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 07:52:33 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 14b0b332-0f4e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mw3lSZrwTnD8kRfOGcmflqxZ0jFgEK1pjAXWOmS6BIE=; b=lOsdwhHGF1zirvCyHKDmQWQHMbGWjxlntdqf6DSZRMlpXkaN+yVx+uBtCmPxrX2zH7 lhEfpSx67RJ5bh5GQlC2zUxmz+s6BeXqmIkanaf9etCabEbvqGEOVpyudhH/tpZ8I+06 bkqUKKPiCv3FpbzJKgLx4pI8TYAURDxzLp1ZSBB/Cw5YAoOvWfOLrgd/x+Yyx72EHeJW XXm5MUku7aer4lqIww4XINxXhCRcTymuP8RFMYo2Ibra5jWFJkE+LEg2UMH+Q/CEXkFm GQtrTbBfb4/JbbQGpOiacnyvAMIv/QtgfDEMuz8ptka5J7XKSrkWfwDCRB1FXL1ZUIUt Jy2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=mw3lSZrwTnD8kRfOGcmflqxZ0jFgEK1pjAXWOmS6BIE=; b=teUSKEhaimc0IclyA0qbzZMf/4OebghxNwLFL1GYmtur2eEN7hXSoCJxzvEulzYPG/ IEM6hVO/AQ1Ho7Zy3/GgiY/b9Tnqce+rAlV4tIRQ6EFmxjK0XaAlrrMB2nEgn4D0tEPY 5efMTAGPgz0oQQ5ox8ckN+pbkh+WSz2k3WV56Y3u2LGZz3PktmQxUJ5722lTbnnur51G E5yIenNtsK7kn8bStvB+/JAPWTUB/TIcpOmgnq3rBoMblkPbtEGpps6XqR35FeSfCZTZ P6PBgMUAkd1pabd0K807NyYuK56QlHy7eX3APJrYpgLp8k96fdt9J2NWBRzPM6+dR0d7 l8ng== X-Gm-Message-State: AJIora8FJEYJEwDBcUluhKEvmwIkD1f4MH6fMO+zOGd9zpxSV6v9pVdP ZAVS0PjLYG+TgdmYUlLFwjUxVsiRK4lQFA== X-Google-Smtp-Source: AGRyM1s5uaaYCXNtBaa3ofMbcdeWNl0Mi0imn5TCPwW9WIwX27hUvCZGU+Q0KL9eMY6jbo0xwfWS/w== X-Received: by 2002:a05:6402:518d:b0:43c:32b2:a0a with SMTP id q13-20020a056402518d00b0043c32b20a0amr3991963edd.388.1659106354233; Fri, 29 Jul 2022 07:52:34 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 0/3] automation: qemu-smoke-arm64.sh: Minor fixes to prevent confusion Date: Fri, 29 Jul 2022 17:52:26 +0300 Message-Id: <20220729145229.1250221-1-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This patch series performs some minor cleanups in qemu-smoke-arm64.sh to prevent confusion that may arise to somebody reading the test. More specifically, this patch series - cleanups some stale comments - fixes the name used for the device tree - fixes the number of cpus in the dt to reflect the number of cpus used in qemu Xenia Ragiadakou (3): automation: qemu-smoke-arm64.sh: Remove some stale comments automation: qemu-smoke-arm64.sh: Rename the device tree to avoid confusion automation: qemu-smoke-arm64.sh: Fix the number of cpus in the device tree automation/scripts/qemu-smoke-arm64.sh | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 14:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 14:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377565.610843 (Exim 4.92) (envelope-from ) id 1oHRM3-0003Q4-OM; Fri, 29 Jul 2022 14:52:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377565.610843; Fri, 29 Jul 2022 14:52:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRM3-0003Pv-Kr; Fri, 29 Jul 2022 14:52:43 +0000 Received: by outflank-mailman (input) for mailman id 377565; Fri, 29 Jul 2022 14:52:43 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRM3-0002d8-0C for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 14:52:43 +0000 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [2a00:1450:4864:20::52c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 18e78ef8-0f4e-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 16:52:42 +0200 (CEST) Received: by mail-ed1-x52c.google.com with SMTP id z18so6099141edb.10 for ; Fri, 29 Jul 2022 07:52:42 -0700 (PDT) Received: from uni.router.wind (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.googlemail.com with ESMTPSA id b1-20020a05640202c100b0043cf2e0ce1csm2415545edx.48.2022.07.29.07.52.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 07:52:41 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 18e78ef8-0f4e-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GCCV7/mK9rtHXdE9kEMUeWvjOVR5wqTBaJTKeZirpYg=; b=J7HOTc/CvY3r0oJ1iFXBL9banSVnmEsIZwTRcge9DNZKK6E0jPbu0QY70dQjhO2tXE tKbeR+Rvq36PG4XZJ+Tgl9eZUFItsM9LBmTLaSQWxxn/BT7tiU/tqSsqqRQDGnBqrTok YxYnI24wzSQeSb7/ZVzv0e5U0ZS1vzinKdINh+wT5HTFB80BHOlyeH5+X48RwUl0VYfe ILFddv/v1j/93wn1nFwHBTnI7AtgN9WT7PBprC2z/FhPpJRGfVqDljcI4qg//gGRQ+il CNvawqs3beCaFnbclLVfjbWmgrLt28VRXJY1ho9CpHeURA2S3Z+anLPEe0MTYoYWGlWd IXMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GCCV7/mK9rtHXdE9kEMUeWvjOVR5wqTBaJTKeZirpYg=; b=OcrX2esoV2oc+nmp6iOqvfLeQ8chxmaHGBbqCmfjqcha2RSE0DN+fFWKI3isZtts1Z RtlM4P1IEsxlZWEq/Gndtk52/Sh+zcmjoyYCIK0Js+oO4MsiRlsn5UnX2KGIyWSG4HgN IEpoQKpomQsK7AQ+uSYU1wIkBaodsVtBIoDV5jb19upsFXwCIDlfWSclp7OmlIqoQje0 rSpeBDtR46AV45C5rbGOMx6yJ54LcsJoWYLucIKnUD+ccFEmXseNzM5wWgDpe+B8V9yi QSvkxA62X+/oUDIjcZlOyhUlUcNxNVzMe56UmzbnhzCAHOiJuBApXscOL1upskbtnNnP WRWw== X-Gm-Message-State: AJIora9ZK5TItC19S3oj0iY6K/qFrZcwH2bTz4dk3gXqSb1+Vu63vdyC lEb2Q+FHe+VR9cfOnPizzHSJtR99HuUEzA== X-Google-Smtp-Source: AGRyM1t+I45xBeo8d53fj0L8uW99PlkRI+dLox2viFrmNXGXgezAHh5Q69dsQCchRO3fbLlZQiPE+A== X-Received: by 2002:a05:6402:2687:b0:43a:6025:1658 with SMTP id w7-20020a056402268700b0043a60251658mr3851396edd.271.1659106361472; Fri, 29 Jul 2022 07:52:41 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 3/3] automation: qemu-smoke-arm64.sh: Fix the number of cpus in the device tree Date: Fri, 29 Jul 2022 17:52:29 +0300 Message-Id: <20220729145229.1250221-4-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220729145229.1250221-1-burzalodowa@gmail.com> References: <20220729145229.1250221-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Qemu VM is configured with 2 cpus but the device tree passed has only 1. Generate a device tree with 2 cpus. Signed-off-by: Xenia Ragiadakou --- I am not sure for this patch because I do not know whether the number of cpus differs deliberately. automation/scripts/qemu-smoke-arm64.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index 7ac82b2278..b48a20988f 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -35,7 +35,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom ./binaries/qemu-system-aarch64 \ -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ - -m 1024 -display none \ + -m 1024 -smp 2 -display none \ -machine dumpdtb=binaries/virt-gicv2.dtb # XXX disable pl061 to avoid Linux crash dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 14:52:48 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 14:52:48 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377564.610831 (Exim 4.92) (envelope-from ) id 1oHRM1-00038P-Fq; Fri, 29 Jul 2022 14:52:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377564.610831; Fri, 29 Jul 2022 14:52:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRM1-00038C-DK; Fri, 29 Jul 2022 14:52:41 +0000 Received: by outflank-mailman (input) for mailman id 377564; Fri, 29 Jul 2022 14:52:40 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRM0-0002gj-8T for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 14:52:40 +0000 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [2a00:1450:4864:20::534]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 177c6524-0f4e-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 16:52:39 +0200 (CEST) Received: by mail-ed1-x534.google.com with SMTP id e15so6126878edj.2 for ; Fri, 29 Jul 2022 07:52:39 -0700 (PDT) Received: from uni.router.wind (adsl-93.176.58.224.tellas.gr. [176.58.224.93]) by smtp.googlemail.com with ESMTPSA id b1-20020a05640202c100b0043cf2e0ce1csm2415545edx.48.2022.07.29.07.52.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 07:52:38 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 177c6524-0f4e-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=97bxCy1H9CWPFXdyrOUwU6geXueYNxo4AEs0ZNp/ZGQ=; b=lXcpLvMO7A/UbF3Wj2ZdzXB0a8eCtoOHN8AJWPTB4Q2Qspfp2hzc1fGQOCde/UtV28 xzi6cCsC8ahZ15dfrHoiQ/48tWWmtzdYmiTgyj+6KS5tmIukBsr+BlJCFNm+N0chmh/j v1jx01Xzjut2UBaaGwZvK+7agZum+CXBS/cUFJzwlse6X5Hmr/IWbRmvqk5jdsrviRZ/ KUhXd633ljEcXPiJhhWewEaZnSYJydYmRwgwEdQEif/miNmjDQW7RVpEMTpLtIognD40 J1dO5Tt+Ac5wn8cEynjwc9i2uh03XxZvv27914y5tPzeODK9CqhuXJYt1qXKkbGIVZd/ a1dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=97bxCy1H9CWPFXdyrOUwU6geXueYNxo4AEs0ZNp/ZGQ=; b=lwN9RorkS7J1fLD7Gytlm8KGcMGMeno87MhR95AQ8yXql43fvoXowQaHDwkn6MsFDk a38lAmwJ5685EMS9KZHu+DAzRXU8xfeeJdLyC9u1CHTaAoDV8ColNQepGsBWLrLujWNW HGeC4WUGA+pZ4F7Skmx95V4biNAW6pXDT5PhxexkMp56z1yNWdPxo+7IU16770wLEoP4 uuX7m5dTET94kgH+tM7hCI19b/uGM/OjN8gvOHD32yhFRWODf1y3LRssw+0sj8BVpf8V cIF2Qg9mO6P58sKxWzHxEqsSV2ms0jXEplPeqt8AT2oYGjCDSjlP6BUKwdn+l1NVTXP/ hncw== X-Gm-Message-State: AJIora9FSlAD+NxMx6GxEt0UY4xqG6hSNPs4fW1KCfIqb6fuuLNeuxNO odzunEMp2eBWK+u9OyNsS/q8rx5nDVbHsA== X-Google-Smtp-Source: AGRyM1tDmzOOATUb7OLpWHss6egcQzr2fExsfi2JUOd8sSR4CucbJxDXsBQNp4v7Cu0pQSlPiP+3AA== X-Received: by 2002:a05:6402:84a:b0:423:fe99:8c53 with SMTP id b10-20020a056402084a00b00423fe998c53mr3973622edz.195.1659106358943; Fri, 29 Jul 2022 07:52:38 -0700 (PDT) From: Xenia Ragiadakou To: xen-devel@lists.xenproject.org Cc: Doug Goldstein , Stefano Stabellini Subject: [PATCH 2/3] automation: qemu-smoke-arm64.sh: Rename the device tree to avoid confusion Date: Fri, 29 Jul 2022 17:52:28 +0300 Message-Id: <20220729145229.1250221-3-burzalodowa@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220729145229.1250221-1-burzalodowa@gmail.com> References: <20220729145229.1250221-1-burzalodowa@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Rename the device tree from virt-gicv3 to virt-gicv2 to avoid confusion since the version of the generic interrupt controller used for this test is the v2 and not the v3. Signed-off-by: Xenia Ragiadakou --- automation/scripts/qemu-smoke-arm64.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh index f483a2ffc1..7ac82b2278 100755 --- a/automation/scripts/qemu-smoke-arm64.sh +++ b/automation/scripts/qemu-smoke-arm64.sh @@ -36,11 +36,11 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom -machine virtualization=true \ -cpu cortex-a57 -machine type=virt \ -m 1024 -display none \ - -machine dumpdtb=binaries/virt-gicv3.dtb + -machine dumpdtb=binaries/virt-gicv2.dtb # XXX disable pl061 to avoid Linux crash -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb +dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts +sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts +dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb # Busybox @@ -73,7 +73,7 @@ cd .. echo 'MEMORY_START="0x40000000" MEMORY_END="0x80000000" -DEVICE_TREE="virt-gicv3.dtb" +DEVICE_TREE="virt-gicv2.dtb" XEN="xen" DOM0_KERNEL="Image" DOM0_RAMDISK="initrd" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:02:02 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:02:02 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377592.610854 (Exim 4.92) (envelope-from ) id 1oHRV0-00064O-Ld; Fri, 29 Jul 2022 15:01:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377592.610854; Fri, 29 Jul 2022 15:01:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRV0-00064H-Ih; Fri, 29 Jul 2022 15:01:58 +0000 Received: by outflank-mailman (input) for mailman id 377592; Fri, 29 Jul 2022 15:00:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRTA-0005gg-PB for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:00:04 +0000 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 1f6b1734-0f4f-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 17:00:03 +0200 (CEST) Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-2ef5380669cso53732067b3.9 for ; Fri, 29 Jul 2022 08:00:03 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1f6b1734-0f4f-11ed-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=S1YI+SR1sGADVizxFmy+lJ0FTmSOnUKcWTIA6mLx/E8=; b=PAswu8WoyoMJzGQDHm0ElXUr2ZPwHT3+WO+WgT9GJIJvdmIZC6e7+thBdNaWPfydDF We7mAIZ9+c1S937hGXDfpM53q0Nl0PUhoNN/Wu3C4BLDfk993aagStmMD1BsSl6iSJLM YshtMaU7ErsHmps10otLE96TAl6014cS4s90cW8GyINlWNly/RkyCVt+S5fnE5ZhI3HQ lUS/YaD5IOxvQieOS+kNyNFEIvvQ38I8DdofQ/GBu7wKELt7bPEwL6taYrQutUoXQZo4 uFxQdGn3QSfnVPM3AvwRvWjt64SoNzzPH0GXO275Ft1nrsc9kdtGI5KR6ngDUQy5XHgi yXBg== X-Gm-Message-State: ACgBeo1Y3hJfR/59YrTcGPMJUGZ10DScASkfsVPVWTsIfyUQQwCbUro/ BaKvzAtiBStjINky54TtlUABLvpEQCPwxwm32Nc= X-Google-Smtp-Source: AA6agR5QQFhqUTEC/IGPMir7zUIdteVkQo93xHT0n5oUM+G+UQ5tpfdzHAC9fZE5clkaGoQ4WXKUt2zD7Q2S/JCn7tY= X-Received: by 2002:a81:1b97:0:b0:2db:640f:49d8 with SMTP id b145-20020a811b97000000b002db640f49d8mr3338822ywb.326.1659106801810; Fri, 29 Jul 2022 08:00:01 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> In-Reply-To: <20220729102458.GA1695@lespinasse.org> From: "Rafael J. Wysocki" Date: Fri, 29 Jul 2022 16:59:50 +0200 Message-ID: Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE To: Michel Lespinasse Cc: "Paul E. McKenney" , Peter Zijlstra , Richard Henderson , Ivan Kokshaysky , Matt Turner , vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , Max Filippov , "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org, rh0@fb.com Content-Type: text/plain; charset="UTF-8" On Fri, Jul 29, 2022 at 12:25 PM Michel Lespinasse wrote: > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > > Xeons") wrecked intel_idle in two ways: > > > > > > > > - must not have tracing in idle functions > > > > - must return with IRQs disabled > > > > > > > > Additionally, it added a branch for no good reason. > > > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > > usage" when booting a kernel with debug options compiled in. Please > > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > > and is still present in v5.19-rc8. > > > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > > > I finally got a chance to take a quick look at this. > > > > The rcu_eqs_exit() function is making a lockdep complaint about > > being invoked with interrupts enabled. This function is called from > > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > > interrupts before invoking rcu_eqs_exit(). > > > > The only other call to rcu_idle_exit() does not disable interrupts, > > but it is via rcu_user_exit(), which would be a very odd choice for > > cpuidle_enter_state(). > > > > It seems unlikely, but it might be that it is the use of local_irq_save() > > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > > the trouble. If this is the case, then the commit shown below would > > help. Note that this commit removes the warning from lockdep, so it > > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > > equivalent debugging. > > > > Could you please try your test with the -rce commit shown below applied? > > Thanks for looking into it. > > After checking out Peter's commit 32d4fd5751ea, > cherry picking your commit ed4ae5eff4b3, > and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, > I am now seeing this a few seconds into the boot: > > [ 3.010650] ------------[ cut here ]------------ > [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 > [ 3.010657] Modules linked in: > [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 > [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 > [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 > [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 > 89 c0 48 03 1c c5 c0 98 > [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 > [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 > [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 > [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 > [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 > [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 > [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 > [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 > [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 3.010683] Call Trace: > [ 3.010685] > [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 > [ 3.010694] cpuidle_enter+0x29/0x40 > [ 3.010697] do_idle+0x1d4/0x210 > [ 3.010702] cpu_startup_entry+0x19/0x20 > [ 3.010704] rest_init+0x117/0x1a0 > [ 3.010708] arch_call_rest_init+0xa/0x10 > [ 3.010711] start_kernel+0x6d8/0x6ff > [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb > [ 3.010728] > [ 3.010729] irq event stamp: 44179 > [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 > [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 > [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 > [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 > [ 3.010741] ---[ end trace 0000000000000000 ]--- Can you please give this patch a go: https://patchwork.kernel.org/project/linux-pm/patch/Yt/AxPFi88neW7W5@e126311.manchester.arm.com/ ? From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:16:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:16:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377601.610865 (Exim 4.92) (envelope-from ) id 1oHRid-0007s1-Vu; Fri, 29 Jul 2022 15:16:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377601.610865; Fri, 29 Jul 2022 15:16:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRid-0007ru-Sv; Fri, 29 Jul 2022 15:16:03 +0000 Received: by outflank-mailman (input) for mailman id 377601; Fri, 29 Jul 2022 15:16:02 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRic-0007ro-FA for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:16:02 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRiX-00050a-5E; Fri, 29 Jul 2022 15:15:57 +0000 Received: from [54.239.6.186] (helo=[192.168.0.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHRiW-00052G-V1; Fri, 29 Jul 2022 15:15:57 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=VEZyU/ntnKujOpb3iwU1YsfJEAOr7n7/eTqcCzjMqM8=; b=wSzIbZZqYxzUKZ1KKkIApHtbfQ cgyN7Gf6NAXR0GahZHvaoUUTm5WqGiZd2nhCCwapQI0GHTORV3sAPK7ShhS9FxpwfPF5JKDRPl5AL sz+zBerBN6vlQJu7sKD+/bk8YWxgd+XHQmTjddWJxcwqXtZzSmVveQKLbA9g5xZUW1zg=; Message-ID: Date: Fri, 29 Jul 2022 16:15:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou , Bertrand Marquis , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> <01bb7315-91a1-de7a-2c17-c6772f740619@gmail.com> From: Julien Grall In-Reply-To: <01bb7315-91a1-de7a-2c17-c6772f740619@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Xenia, On 29/07/2022 15:03, Xenia Ragiadakou wrote: > > On 7/29/22 16:41, Bertrand Marquis wrote: >> Hi Xenia, >> >>> On 29 Jul 2022, at 07:31, Xenia Ragiadakou >>> wrote: >>> >>> Hi Jan, >>> >>> On 7/29/22 09:26, Jan Beulich wrote: >>>> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>>>> --- a/xen/arch/arm/domain.c >>>>> +++ b/xen/arch/arm/domain.c >>>>> @@ -63,7 +63,7 @@ static void do_idle(void) >>>>>       rcu_idle_exit(cpu); >>>>>   } >>>>>   -void idle_loop(void) >>>>> +static void idle_loop(void) >>>> While you're adding "noreturn" below, shouldn't this one be marked so >>>> as well? Preferably with the addition: >>>> Reviewed-by: Jan Beulich >>> >>> Yes, but I was not sure if this should go in this patch or in a >>> separate one. >> >> As you modify the function to make it static, I think it is ok to also >> add the noreturn in the same patch. >> >> With that done, you can add my: >> Reviewed-by: Bertrand Marquis >> >> Cheers >> Bertrand > > I consider this change unrelated to the patch. I think it is a bad > practice to squash unrelated changes in a single patch. Also, I do not > think it is unfair to be obliged to make it in order for the patch to be > accepted. > I could have taken the opportunity to fix this in the same patch but I > decided to not take it. In general, I don't like having multiple changes within a patch. However, here this is a consistency problem. You are modifying the 3 prototypes (well one is technically a declaration) and it reads odd that 2 are using noreturn but not the other one. I would actually argue that if this patch goes in like that, then the commit message ought to explain why there is a lack of consistency. Anyway, I agree with Bertrand that it would be preferable to add noreturn to the declaration of idle_loop() in this patch. To avoid a round trip, I would be OK to handle on commit. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:47:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:47:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377615.610876 (Exim 4.92) (envelope-from ) id 1oHSCu-0003YE-FT; Fri, 29 Jul 2022 15:47:20 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377615.610876; Fri, 29 Jul 2022 15:47:20 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSCu-0003Y7-Bo; Fri, 29 Jul 2022 15:47:20 +0000 Received: by outflank-mailman (input) for mailman id 377615; Fri, 29 Jul 2022 15:47:19 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSCt-0003Y1-K3 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:47:19 +0000 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [2a00:1450:4864:20::634]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b9a597c3-0f55-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 17:47:18 +0200 (CEST) Received: by mail-ej1-x634.google.com with SMTP id tk8so9218879ejc.7 for ; Fri, 29 Jul 2022 08:47:18 -0700 (PDT) Received: from [192.168.1.93] (adsl-69.109.242.233.tellas.gr. [109.242.233.69]) by smtp.gmail.com with ESMTPSA id t23-20020aa7d4d7000000b0043bbc9503ddsm2536341edr.76.2022.07.29.08.47.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 08:47:17 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b9a597c3-0f55-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=YU4+N1dFaxYk0V0HBTnikJhCHrzO/Ko9SeXqtkCr9tw=; b=Kg2Kn5KzzxxtY5Xtfa8OO6dSU7xEGXF+PeGCcIJcnmFrv7+/EOMxV6x7Mr3SclL/5w UlbkbzXSy2VRbM6yqqssnuiE/2eVfFki2eHdi3yV2DJc05638ydQrLXJjkIow191gpbP QsungH978BVKGa+flXhsCu6vA3vjBPZD2hWyV+lOI9YdXIi2jlt+6CMYvWrUJM3HdsTl CLxwM6ZPZaK96c2ymhTCBwTULzA22HP9zTbG7HAHOU8HDP8+5QZI3/ldTIaQ/gRkDj+a qWengSd++bPnowrJDcZqdmGljeN1Ui3rRVru0/5RlQWjm7NUujUrZIjUCfjtpYVTMDv9 q+eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YU4+N1dFaxYk0V0HBTnikJhCHrzO/Ko9SeXqtkCr9tw=; b=YaGgvRNwtH+b6cts8AJLpPdfZNFKiNbKQGZ/66tJdQumuLHqI8NRtQylE2TssTyoY3 ZeGlQy3/GWltFolGHNaxN9dYMA0ApQ2sSjvl8Sx5xkrj72StZCPaH0jpy39iHPCo76A3 7Ua8rb/ennJGGEjYR5MBOQB0Z/FLmGIm/vK+mZvLaptcQO5k7ko4WDpkbISJShu5/6Ib RY917H6G0aKUiDEonosrzGEWfPHe1SZLq+T1sgkFz2yV2+mlrv6RaJg3Lf4Ql1AigGMO 2clna0NCJo9Y4iOqX1JUQmC+GVFrRjFmUZjdJ2UpvM7ObyX1MyA1s8pL+EjsTK5+vwjp v5vw== X-Gm-Message-State: AJIora/Fx8ndA1f90ojtOoVzcwiawILE1Yd1BJ7KYdeOtWRfln2GE8Ei RwXA9XosTOuLFW5iEXVbjPM= X-Google-Smtp-Source: AGRyM1tRd535fnfutV2P8ictT1WjRUtyHy9cwe3fF86wtmNif0e5JIdTojMqXzhieWqKMxXuM4Wplw== X-Received: by 2002:a17:907:970d:b0:72b:3589:a22c with SMTP id jg13-20020a170907970d00b0072b3589a22cmr3367312ejc.621.1659109637628; Fri, 29 Jul 2022 08:47:17 -0700 (PDT) Message-ID: Date: Fri, 29 Jul 2022 18:47:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Julien Grall , Bertrand Marquis , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> <01bb7315-91a1-de7a-2c17-c6772f740619@gmail.com> From: Xenia Ragiadakou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Julien, Hi Julien, On 7/29/22 18:15, Julien Grall wrote: > Hi Xenia, > > On 29/07/2022 15:03, Xenia Ragiadakou wrote: >> >> On 7/29/22 16:41, Bertrand Marquis wrote: >>> Hi Xenia, >>> >>>> On 29 Jul 2022, at 07:31, Xenia Ragiadakou >>>> wrote: >>>> >>>> Hi Jan, >>>> >>>> On 7/29/22 09:26, Jan Beulich wrote: >>>>> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>>>>> --- a/xen/arch/arm/domain.c >>>>>> +++ b/xen/arch/arm/domain.c >>>>>> @@ -63,7 +63,7 @@ static void do_idle(void) >>>>>>       rcu_idle_exit(cpu); >>>>>>   } >>>>>>   -void idle_loop(void) >>>>>> +static void idle_loop(void) >>>>> While you're adding "noreturn" below, shouldn't this one be marked so >>>>> as well? Preferably with the addition: >>>>> Reviewed-by: Jan Beulich >>>> >>>> Yes, but I was not sure if this should go in this patch or in a >>>> separate one. >>> >>> As you modify the function to make it static, I think it is ok to >>> also add the noreturn in the same patch. >>> >>> With that done, you can add my: >>> Reviewed-by: Bertrand Marquis >>> >>> Cheers >>> Bertrand >> >> I consider this change unrelated to the patch. I think it is a bad >> practice to squash unrelated changes in a single patch. Also, I do not >> think it is unfair to be obliged to make it in order for the patch to >> be accepted. >> I could have taken the opportunity to fix this in the same patch but I >> decided to not take it. > > In general, I don't like having multiple changes within a patch. > However, here this is a consistency problem. You are modifying the 3 > prototypes (well one is technically a declaration) and it reads odd that > 2 are using noreturn but not the other one. > The patch adds the 2 function declarations, it does not modify them. Since they do not return, they are declared noreturn. If the function idle_loop was not declared noreturn, although it should have been, for me is a completely different issue. > I would actually argue that if this patch goes in like that, then the > commit message ought to explain why there is a lack of consistency. > I do not agree with you saying that the patch introduced this inconsistency. The function idle_loop should have been declared noreturn in the first place. If you would like to fix this in the current patch, it is up to you. > Anyway, I agree with Bertrand that it would be preferable to add > noreturn to the declaration of idle_loop() in this patch. > > To avoid a round trip, I would be OK to handle on commit. > > Cheers, > -- Xenia From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:50:32 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:50:32 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377619.610887 (Exim 4.92) (envelope-from ) id 1oHSFz-0004tw-Uq; Fri, 29 Jul 2022 15:50:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377619.610887; Fri, 29 Jul 2022 15:50:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSFz-0004tp-QN; Fri, 29 Jul 2022 15:50:31 +0000 Received: by outflank-mailman (input) for mailman id 377619; Fri, 29 Jul 2022 15:50:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSFz-0004tj-6J for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:50:31 +0000 Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [2a00:1450:4864:20::12c]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2c048b38-0f56-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 17:50:30 +0200 (CEST) Received: by mail-lf1-x12c.google.com with SMTP id bf9so7872620lfb.13 for ; Fri, 29 Jul 2022 08:50:30 -0700 (PDT) Received: from otyshchenko.router ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id bp23-20020a056512159700b0048a835a60f6sm693428lfb.251.2022.07.29.08.50.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Jul 2022 08:50:28 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2c048b38-0f56-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc; bh=S01wSBMMcdelVnVjOkH9lCwWoMGdbRzrK7HqSib69Hg=; b=LFp7OCtLArAWZrWOeuJsky9HKKLt42lomc5ZCZlwDVu7gTbyAhWxVFxCHMqauI5zQP XrQjSoQnO+SwTEVZPkTLnp8siPxVgTADZviZjxWaT0FhHniUCT1AuZR6+wWux2lfKdHr wtAfBqGskxrja9bdWbmbc1qLUMioLFT7HS5cClX7hIQhm+DzV/S8z3pqMbiv25UL3aeZ he/avPFnqs2Hug7Lzv94C6QulY10W8FMDp1MwxXQ3OGW3hWZ2psFppL62R3rnpIFqTTr uKOykqGzCXBQFnDcQgrON0kzlrv1OBOMRjRWpd5HTEK88zqNSm9XOzyCmnPRMSvuVN64 XVqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc; bh=S01wSBMMcdelVnVjOkH9lCwWoMGdbRzrK7HqSib69Hg=; b=Sbw7xwhxFGyi1H3GBzseW0sZAfLI2o14XPplnglmM871Z57dR8XRr/k8PtUO5Eq5fJ ay6t3wwEUgUgwvT3vofQkWpS5i8DskEzZiW85uSUpbHcDqIzCC7Zgnp8YX/Q5Yyzel7V ONwpzHbD62BnjyeOZTbBFF2hdqpXZbMWmRdmyocbPuRA0zyjlMLNfrWpSVH8J4+ZDyEn Qeo0p4z3fbvF6U9AMfEIcmKrfNggO+KZnv/EF7OSmv2L/NawfUVpRC+jN0bNKottKNck 7U59wmQSI5R0v9eYR0kx/9oUYOWsCovqNf0+5alJdIaKVHaqhhliEXbxJbVyrSV7IUhk GnWg== X-Gm-Message-State: ACgBeo1HoE1vpx5ySHU/JXXPN6Xg5uSjlAfy3e+F22Y0EZ/xK+1d5j9j 3qFLfFO6VonbCE9tdmZusmyRwWhM4SRzlA== X-Google-Smtp-Source: AA6agR7I0GXQBFySP974763gBQRcBZVi3iQZyVTmh3NffVj56BJeEOk++Kyr+zNdGBCsmPwcxzVclw== X-Received: by 2002:a05:6512:1292:b0:48a:e693:9da3 with SMTP id u18-20020a056512129200b0048ae6939da3mr566261lfs.328.1659109828939; Fri, 29 Jul 2022 08:50:28 -0700 (PDT) From: Oleksandr Tyshchenko To: xen-devel@lists.xenproject.org, libvir-list@redhat.com Cc: Oleksandr Tyshchenko , Julien Grall , Anthony PERARD , Michal Privoznik Subject: [libvirt PATCH] libxl: Fix build with recent Xen that introduces new disk backend type Date: Fri, 29 Jul 2022 18:50:24 +0300 Message-Id: <20220729155024.3327364-1-olekstysh@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Oleksandr Tyshchenko Xen toolstack has gained basic Virtio support recently which becides adding various virtio related stuff introduces new disk backend type LIBXL_DISK_BACKEND_STANDALONE [1]. Unfortunately, this caused a regression in libvirt build with Xen support enabled, reported by the osstest today [2]: CC libxl/libvirt_driver_libxl_impl_la-xen_xl.lo ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': ../../src/libxl/xen_xl.c:779:17: error: enumeration value 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch [-Werror=switch-enum] switch (libxldisk->backend) { ^~~~~~ cc1: all warnings being treated as errors The interesting fact is that switch already has a default branch (which ought to cover such new addition), but the error is triggered as -Wswitch-enum gives a warning about an omitted enumeration code even if there is a default label. Also there is a similar issue in libxlUpdateDiskDef() which I have reproduced after fixing the first one, but it that case the corresponding switch doesn't have a default branch. Fix both issues by inserting required enumeration item to make the compiler happy and adding ifdef guard to be able to build against old Xen libraries as well (without LIBXL_HAVE_DEVICE_DISK_SPECIFICATION). Also add a default branch to switch in libxlUpdateDiskDef(). Please note, that current patch doesn't implement the proper handling of LIBXL_DISK_BACKEND_STANDALONE and friends, it is just intended to fix the regression immediately to unblock the osstest. Also it worth mentioning that current patch won't solve the possible additions in the future. [1] https://lore.kernel.org/xen-devel/20220716163745.28712-1-olekstysh@gmail.com/ [2] https://lore.kernel.org/xen-devel/E1oHEQO-0008GA-Uo@osstest.test-lab.xenproject.org/ Signed-off-by: Oleksandr Tyshchenko --- Cc: Julien Grall Cc: Anthony PERARD Cc: Michal Privoznik Please note, the patch is tested on: https://xenbits.xen.org/gitweb/?p=libvirt.git;a=shortlog;h=refs/heads/xen-tested-master but should work on the master as well (as the same code is present here). --- src/libxl/libxl_conf.c | 4 ++++ src/libxl/xen_xl.c | 3 +++ 2 files changed, 7 insertions(+) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index aa3d7925ec..526f0b2b08 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -1240,6 +1240,10 @@ libxlUpdateDiskDef(virDomainDiskDef *l_disk, libxl_device_disk *x_disk) driver = "phy"; break; case LIBXL_DISK_BACKEND_UNKNOWN: +#ifdef LIBXL_HAVE_DEVICE_DISK_SPECIFICATION + case LIBXL_DISK_BACKEND_STANDALONE: +#endif + default: break; } if (driver) diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 4de4e3140f..6919325623 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -715,6 +715,9 @@ xenParseXLDisk(virConf *conf, virDomainDef *def) virDomainDiskSetDriver(disk, "phy"); virDomainDiskSetType(disk, VIR_STORAGE_TYPE_BLOCK); break; +#ifdef LIBXL_HAVE_DEVICE_DISK_SPECIFICATION + case LIBXL_DISK_BACKEND_STANDALONE: +#endif default: virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("disk backend not supported: %s"), -- 2.25.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:56:17 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:56:17 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377627.610897 (Exim 4.92) (envelope-from ) id 1oHSLM-0005ZM-H5; Fri, 29 Jul 2022 15:56:04 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377627.610897; Fri, 29 Jul 2022 15:56:04 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSLM-0005ZF-E9; Fri, 29 Jul 2022 15:56:04 +0000 Received: by outflank-mailman (input) for mailman id 377627; Fri, 29 Jul 2022 15:56:03 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSLL-0005Z9-28 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:56:03 +0000 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [2a00:1450:4864:20::230]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id f15eabc7-0f56-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 17:56:01 +0200 (CEST) Received: by mail-lj1-x230.google.com with SMTP id a13so5611606ljr.11 for ; Fri, 29 Jul 2022 08:56:01 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id o25-20020a198c19000000b0048a9c80b1f2sm693314lfd.194.2022.07.29.08.55.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 08:55:59 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f15eabc7-0f56-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=eat4TgmilUiNiJbcKemb7fgNhPjU0Rsr1AtN3zFtS+4=; b=f9mDiDTkEkMe+g1pD72ycEo4OtXk8OceFprvTH0eL8ivpk9N0c41u4VF2rYwo9tpLd wTr3Oz3w4Fr0oHqolIZvJAy3ll46WHNLrRT9l+gGcp/l7C/CzqTeEV5U7D7tee9L2DLc zUUp2/6vGFDoh4jf5y7al9Uzfwj+nr7nLKooclIdNUa9NXN6MJhOBwF2/O3vwtNP7uzd kXZtt+BMLFVCkxKor4y32cDYKCyoEMXMVRTtS3jAfoSbXD6qBPuH1bcw8w3y/G1oJEZc Qx2FoYdoo5Qhn+JAvSkoIbeEuejGzTuKQOa+gI12WNBMrydRh/T1f6/ncVS2ClDqNu3w m6LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=eat4TgmilUiNiJbcKemb7fgNhPjU0Rsr1AtN3zFtS+4=; b=GY0Lmi55vlwfTCQTtMYaV2lhGZom6MJB5/JY5RTDKD91sKotzx2ml5AIxCaay+YBnC g53Zfn8W091roj5I37o9QF5tvT2tbkrfX4OdZ4WiRaQ/xbb9Nas8xqZsJS1Gi0aXXbm9 8Hpx2cykdIY4EJ9CvkAdtLAvbx4zvRf1OLBj5tzeX/oAn/6vkb4o3QbZdR9SLIS0djVD BikSQ8zKH4UwOkC37+EmAph39zesrReOLLJgvCEYQkHSE0TPc/1rjbwloXKVDmZ1IbbF fS11QFZ0LX+3VVPDPfkuzznt5UHDS9j7tSkxD5VQjTgH17X6sYPSLRfr93JJVy40GpGV 1HFQ== X-Gm-Message-State: AJIora8/fa2U2eXIZ2ux9lgVlqUEFUS3+yrK5u2IUsIAirIsdH76G0Z6 x7Oi5tfbU/bYXUEiOdK7n9A= X-Google-Smtp-Source: AGRyM1v0pJ1pepY1Kegy89G6hVJ+xoBLeQPYQDTbUJRgscVkA+9hHQbe5JdI4xCjqHp/GX9pU/Zf6w== X-Received: by 2002:a2e:98d5:0:b0:25e:c1b:f262 with SMTP id s21-20020a2e98d5000000b0025e0c1bf262mr1273603ljj.343.1659110160534; Fri, 29 Jul 2022 08:56:00 -0700 (PDT) Message-ID: <0f7a750d-20c9-f624-133a-51f6638fc643@gmail.com> Date: Fri, 29 Jul 2022 18:55:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt Content-Language: en-US To: Julien Grall Cc: osstest service owner , "xen-devel@lists.xenproject.org" , Anthony PERARD , Jan Beulich , Oleksandr Tyshchenko References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> <57da62dc-81c2-5018-dfc7-5eb784ea53d1@epam.com> <0fa56cfe-85dc-5fd2-6405-e18115420306@epam.com> <0adaeec4-d810-f235-b3a0-951610db216a@xen.org> From: Oleksandr In-Reply-To: <0adaeec4-d810-f235-b3a0-951610db216a@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29.07.22 13:29, Julien Grall wrote: > Hi Oleksandr, Hello Julien > > On 29/07/2022 11:25, Oleksandr Tyshchenko wrote: >> >> On 29.07.22 12:08, Julien Grall wrote: >> >> >> Hello Julien >> >>> (+ Anthony) >>> >>> Hi, >>> >>> On 29/07/2022 07:48, Oleksandr Tyshchenko wrote: >>>> >>>> On 29.07.22 09:22, Jan Beulich wrote: >>>> >>>> Hello Jan >>>> >>>>> On 29.07.2022 03:04, osstest service owner wrote: >>>>>> branch xen-unstable-smoke >>>>>> xenbranch xen-unstable-smoke >>>>>> job build-amd64-libvirt >>>>>> testid libvirt-build >>>>>> >>>>>> Tree: libvirt git://xenbits.xen.org/libvirt.git >>>>>> Tree: libvirt_keycodemapdb >>>>>> https://urldefense.com/v3/__https://gitlab.com/keycodemap/keycodemapdb.git__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpzij9yLM$ >>>>>> >>>>>> [gitlab[.]com] >>>>>> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git >>>>>> Tree: qemuu git://xenbits.xen.org/qemu-xen.git >>>>>> Tree: xen git://xenbits.xen.org/xen.git >>>>>> >>>>>> *** Found and reproduced problem changeset *** >>>>>> >>>>>>      Bug is in tree:  xen git://xenbits.xen.org/xen.git >>>>>>      Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>>>>>      Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce >>>>>>      Last fail repro: >>>>>> https://urldefense.com/v3/__http://logs.test-lab.xenproject.org/osstest/logs/171909/__;!!GF_29dbcQIUBPA!0s_nyAgds977dw0dGPgFJGkIaBiKiXH3nR11Ni6gGjN5gQmB0DEhKrm5SUX4R0WhK8YkQemR6RVhiojpmYABJkc$ >>>>>> >>>>>> [logs[.]test-lab[.]xenproject[.]org] >>>>>> >>>>>> >>>>>>      commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >>>>>>      Author: Oleksandr Tyshchenko >>>>>>      Date:   Fri Jul 15 22:20:24 2022 +0300 >>>>>>              libxl: Add support for Virtio disk configuration >>>>> Just in case you didn't notice it: Something's wrong here. I didn't >>>>> look >>>>> at the details at all. Please advise whether a fix will soon >>>>> arrive or >>>>> whether we should revert for the time being. >>>> >>>> Sorry for the breakage. At the moment I have no idea what is wrong >>>> here, >>> >>>  From the build log: >>> >>> ../../src/libxl/xen_xl.c: In function 'xenParseXLDisk': >>> ../../src/libxl/xen_xl.c:779:17: error: enumeration value >>> 'LIBXL_DISK_BACKEND_STANDALONE' not handled in switch >>> [-Werror=switch-enum] >>>                   switch (libxldisk->backend) { >>>                   ^~~~~~ >>> >>> The switch contains a default branch [1], so I am a bit puzzled why >>> GCC is not happy here. >> >> Libvirt seems to compiled with -Wswitch-enum >> >> And https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html says the >> following: >> >> "-Wswitch-enum >> >> Warn whenever a switch statement has an index of enumerated type and >> lacks a case for one or more of the named codes of that enumeration. >> case labels outside the enumeration range also provoke warnings when >> this option is used. The only difference between -Wswitch and this >> option is that this option gives a warning about an omitted enumeration >> code even if there is a default label." > > Thanks for digging! That's explained the error. I still don't think we > can solve the error in libxl. > > So I would suggest to involve the libvirt folks to know how they want > to solve the issue. Already pushed an immediate fix with detailed description: https://lore.kernel.org/xen-devel/20220729155024.3327364-1-olekstysh@gmail.com/ > > Cheers, > -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 29 15:59:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 15:59:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377634.610909 (Exim 4.92) (envelope-from ) id 1oHSOp-0006Ny-0I; Fri, 29 Jul 2022 15:59:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377634.610909; Fri, 29 Jul 2022 15:59:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSOo-0006Nr-TS; Fri, 29 Jul 2022 15:59:38 +0000 Received: by outflank-mailman (input) for mailman id 377634; Fri, 29 Jul 2022 15:59:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSOn-0006Nl-Ld for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:59:37 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSOi-0005jB-UQ; Fri, 29 Jul 2022 15:59:32 +0000 Received: from [54.239.6.186] (helo=[192.168.0.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHSOi-0006zz-ML; Fri, 29 Jul 2022 15:59:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=G36eaP2HJ4Q7C49hQY4QzeQlZaIzCgSlB29yOgxMbnQ=; b=hm+NnHgNUBtinoNqV6aZjEAXd7 tKP6SMmTflVxJFjSd2Y843nyFMTvMqqcvkA6o9ZsPWXQ0wve1JY5YK8c2TOmzwh25YYmxPvdxuX8r ZpgpbmQy2fduSlj8CltJq7LrwMF0lPi+TxY+lrviiJkVOQgNktdQKobQOxTqWFjpmm+E=; Message-ID: <50e13d08-7f7c-abea-f616-5a312d787b4a@xen.org> Date: Fri, 29 Jul 2022 16:59:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [PATCH v3] xen/arm: domain: Fix MISRA C 2012 Rule 8.7 violation Content-Language: en-US To: Xenia Ragiadakou , Bertrand Marquis , Jan Beulich Cc: Stefano Stabellini , Volodymyr Babchuk , "xen-devel@lists.xenproject.org" References: <20220728162151.1228747-1-burzalodowa@gmail.com> <65adc941-78a9-2e2d-fa43-6189ea95773d@suse.com> <4327CBBD-315D-44C0-A429-25F3CA5BE25D@arm.com> <01bb7315-91a1-de7a-2c17-c6772f740619@gmail.com> From: Julien Grall In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On 29/07/2022 16:47, Xenia Ragiadakou wrote: > On 7/29/22 18:15, Julien Grall wrote: >> Hi Xenia, >> >> On 29/07/2022 15:03, Xenia Ragiadakou wrote: >>> >>> On 7/29/22 16:41, Bertrand Marquis wrote: >>>> Hi Xenia, >>>> >>>>> On 29 Jul 2022, at 07:31, Xenia Ragiadakou >>>>> wrote: >>>>> >>>>> Hi Jan, >>>>> >>>>> On 7/29/22 09:26, Jan Beulich wrote: >>>>>> On 28.07.2022 18:21, Xenia Ragiadakou wrote: >>>>>>> --- a/xen/arch/arm/domain.c >>>>>>> +++ b/xen/arch/arm/domain.c >>>>>>> @@ -63,7 +63,7 @@ static void do_idle(void) >>>>>>>       rcu_idle_exit(cpu); >>>>>>>   } >>>>>>>   -void idle_loop(void) >>>>>>> +static void idle_loop(void) >>>>>> While you're adding "noreturn" below, shouldn't this one be marked so >>>>>> as well? Preferably with the addition: >>>>>> Reviewed-by: Jan Beulich >>>>> >>>>> Yes, but I was not sure if this should go in this patch or in a >>>>> separate one. >>>> >>>> As you modify the function to make it static, I think it is ok to >>>> also add the noreturn in the same patch. >>>> >>>> With that done, you can add my: >>>> Reviewed-by: Bertrand Marquis >>>> >>>> Cheers >>>> Bertrand >>> >>> I consider this change unrelated to the patch. I think it is a bad >>> practice to squash unrelated changes in a single patch. Also, I do >>> not think it is unfair to be obliged to make it in order for the >>> patch to be accepted. >>> I could have taken the opportunity to fix this in the same patch but >>> I decided to not take it. >> >> In general, I don't like having multiple changes within a patch. >> However, here this is a consistency problem. You are modifying the 3 >> prototypes (well one is technically a declaration) and it reads odd >> that 2 are using noreturn but not the other one. >> > > The patch adds the 2 function declarations, it does not modify them. Fair enough, you are adding 2 declarations and modifying one. This doesn't change the inconsistency problem though. > Since they do not return, they are declared noreturn. > If the function idle_loop was not declared noreturn, although it should > have been, for me is a completely different issue. [...] > I do not agree with you saying that the patch introduced this > inconsistency. The function idle_loop should have been declared noreturn > in the first place. I think everyone involved in the discussion agrees that idle_loop() should have been marked as noreturn from the start. And we all agree that this needs to be fixed. So I don't think this is particularly useful to spend time arguing on whether this needs to be handled within or separately. 3 of the reviewers agree that this should be preferably added here. So... > If you would like to fix this in the current patch, > it is up to you. ... I will commit it with the change on the next swipe. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 16:26:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 16:26:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377646.610920 (Exim 4.92) (envelope-from ) id 1oHSoz-0002Pi-7z; Fri, 29 Jul 2022 16:26:41 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377646.610920; Fri, 29 Jul 2022 16:26:41 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSoz-0002Pb-59; Fri, 29 Jul 2022 16:26:41 +0000 Received: by outflank-mailman (input) for mailman id 377646; Fri, 29 Jul 2022 16:26:39 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSox-0002MD-7h for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 16:26:39 +0000 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [2a00:1450:4864:20::131]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 36b4108b-0f5b-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 18:26:36 +0200 (CEST) Received: by mail-lf1-x131.google.com with SMTP id m12so8062014lfj.4 for ; Fri, 29 Jul 2022 09:26:36 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id g26-20020a2ea4ba000000b0025dc0e5a970sm713898ljm.23.2022.07.29.09.26.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 09:26:34 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 36b4108b-0f5b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=3g1AF9WXfiIY+8VM95YjO9u0MndshK3UeuyEIvoiYW4=; b=MIgXuMRlBfKMsNpnkKOVLYWnp+Q6cryOzWbvyPYhOpzhZujBJ0PmelHgYRbdd7a+1x 5OUgdcXXRv96SI72yAFEO7TGw+GNJ40b3HEuUB9dwC+WX/MzseODAOvzIbsATzafpzpv swBZ6zmAGJjHz90IQuEVZ8PAqM31JZ8BQgwPPJkmpquUC1wi2O5Tv5dULBKpZNtpQVxO No6dCAB/ApuKi5KzpCZcv9vNFOKqDJyeP4ewb2UrSCMZIF3gvhqBAa6SYz6XVi9rZD3R Ne7RUjXYYDypAdNpOrWFoCqYv/OXGMNVR62sX/iKt/QT4jqfeinmh0a3ghbcZD7O7jaq RFgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=3g1AF9WXfiIY+8VM95YjO9u0MndshK3UeuyEIvoiYW4=; b=2KVRgsSx61xRmGRdAebwwc3wA1/a16E2dovtKVxiVDGXLY69BuNzymLdJr3noKWg9I LfMH9eOvFx2/hqQoODMA26ZYssCRVWr2iXg5d3sI+ycgSKShK+4FGWubzRIpFH0yUpJQ o2KvHuO+bNgrYP3nN4VynUSRdOS1Ud7tiC6+cv6qjmG2JlRRdY+cuBJxf39lLX4h/tXo i5KS2rrcdQBFl0yC4UM/gYQr9FubOPVGsnuIaHgHcGLF5zUkVPql7GKmzTbhe1CQS6Zx zzYmuzg51G039YgUXWfOi6ON+YPLNdC220UGkI3vfyzFVXm8zCkyKGXHSPB3Jbipb+Bq ieGw== X-Gm-Message-State: ACgBeo1imf/aMMnEGHeiruB1oXXY6h8kFE0ljna4njyLPvuHPMAr+6oF HxoEMVDlSUMXp+mEEjCvb/0= X-Google-Smtp-Source: AGRyM1trjz5ONt+W0mNCqwlKGSaIUsFp/EmRwDfRRFcbR6NZ9QXp0HAIuxAen7WdLrVmjtVw8ADLgA== X-Received: by 2002:a19:7b1d:0:b0:48a:7137:38d5 with SMTP id w29-20020a197b1d000000b0048a713738d5mr1444034lfc.171.1659111995552; Fri, 29 Jul 2022 09:26:35 -0700 (PDT) Message-ID: <195d8ba7-fe62-c1de-98a0-843360b69a43@gmail.com> Date: Fri, 29 Jul 2022 19:26:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 10/11] xen/arm: translate virtual PCI bus topology for guests Content-Language: en-US To: Jan Beulich Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-11-olekstysh@gmail.com> <6e1a842f-e577-0f01-5046-f96c3c75db5b@suse.com> <8e839472-f49d-a464-34aa-c7b26b9c50de@gmail.com> <3752a158-85a1-e758-36eb-2feb0c5be954@gmail.com> From: Oleksandr In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 29.07.22 09:06, Jan Beulich wrote: Hello Jan > On 28.07.2022 18:35, Oleksandr wrote: >> On 28.07.22 10:15, Jan Beulich wrote: >>> On 27.07.2022 21:39, Oleksandr wrote: >>>> On 27.07.22 20:54, Oleksandr wrote: >>>>> On 26.07.22 18:16, Jan Beulich wrote: >>>>>> On 19.07.2022 19:42, Oleksandr Tyshchenko wrote: >>>>>>> --- a/xen/arch/arm/vpci.c >>>>>>> +++ b/xen/arch/arm/vpci.c >>>>>>> @@ -41,6 +41,16 @@ static int vpci_mmio_read(struct vcpu *v, >>>>>>> mmio_info_t *info, >>>>>>>       /* data is needed to prevent a pointer cast on 32bit */ >>>>>>>       unsigned long data; >>>>>>>   +    /* >>>>>>> +     * For the passed through devices we need to map their virtual >>>>>>> SBDF >>>>>>> +     * to the physical PCI device being passed through. >>>>>>> +     */ >>>>>>> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >>>>>>> +    { >>>>>>> +        *r = ~0ul; >>>>>>> +        return 1; >>>>>>> +    } >>>>>> I'm probably simply lacking specific Arm-side knowledge, but it strikes >>>>>> me as odd that the need for translation would be dependent upon >>>>>> "bridge". >>>>> I am afraid I cannot answer immediately. >>>>> >>>>> I will analyze that question and provide an answer later on. >>>> Well, most likely that "valid" bridge pointer here is just used as an >>>> indicator of hwdom currently, so no need to perform virt->phys >>>> translation for sbdf. >>>> >>>> You can see that domain_vpci_init() passes a valid value for hwdom and >>>> NULL for other domains when setting up vpci_mmio* callbacks. >>> Oh, I see. >>> >>>> Alternatively, I guess we could use "!is_hardware_domain(v->domain)" >>>> instead of "!bridge" in the first part of that check. Shall I? >>> Maybe simply add a comment? Surely checking "bridge" is cheaper than >>> using is_hardware_domain(), so I can see the benefit. But the larger >>> arm/vpci.c grows, the less obvious the connection will be without a >>> comment. >> >> Agree the connection is worth a comment ... >> >> >> >>> (Instead of a comment, an alternative may be a suitable >>> assertion, which then documents the connection at the same time, e.g. >>> ASSERT(!bridge == !is_hardware_domain(v->domain)). But that won't be >>> possible in e.g. vpci_sbdf_from_gpa(), where apparently a similar >>> assumption is being made.) >> >>    ... or indeed to put such ASSERT _before_ vpci_sbdf_from_gpa(). >> >> This will cover assumption being made in both places. >> >> >> diff --git a/xen/arch/arm/vpci.c b/xen/arch/arm/vpci.c >> index a9fc5817f9..1d4b1ef39e 100644 >> --- a/xen/arch/arm/vpci.c >> +++ b/xen/arch/arm/vpci.c >> @@ -37,10 +37,24 @@ static int vpci_mmio_read(struct vcpu *v, >> mmio_info_t *info, >>                            register_t *r, void *p) >>  { >>      struct pci_host_bridge *bridge = p; >> -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); >> +    pci_sbdf_t sbdf; >>      /* data is needed to prevent a pointer cast on 32bit */ >>      unsigned long data; >> >> +    ASSERT(!bridge == !is_hardware_domain(v->domain)); >> + >> +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); >> + >> +    /* >> +     * For the passed through devices we need to map their virtual SBDF >> +     * to the physical PCI device being passed through. >> +     */ >> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >> +    { >> +        *r = ~0ul; >> +        return 1; >> +    } >> + >>      if ( vpci_ecam_read(sbdf, ECAM_REG_OFFSET(info->gpa), >>                          1U << info->dabt.size, &data) ) >>      { >> @@ -57,7 +71,18 @@ static int vpci_mmio_write(struct vcpu *v, >> mmio_info_t *info, >>                             register_t r, void *p) >>  { >>      struct pci_host_bridge *bridge = p; >> -    pci_sbdf_t sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); >> +    pci_sbdf_t sbdf; >> + >> +    ASSERT(!bridge == !is_hardware_domain(v->domain)); >> + >> +    sbdf = vpci_sbdf_from_gpa(bridge, info->gpa); >> + >> +    /* >> +     * For the passed through devices we need to map their virtual SBDF >> +     * to the physical PCI device being passed through. >> +     */ >> +    if ( !bridge && !vpci_translate_virtual_device(v->domain, &sbdf) ) >> +        return 1; >> >>      return vpci_ecam_write(sbdf, ECAM_REG_OFFSET(info->gpa), >>                             1U << info->dabt.size, r); >> diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c >> index d4601ecf9b..fc2c51dc3e 100644 >> >> >> Any preference here? >> >> >> Personally, I think that such ASSERT will better explain the connection >> than the comment will do. > Indeed I'd also prefer ASSERT()s being put there. good > But my opinion is > secondary here, as I'm not a maintainer of this code. sure, let's see what the Arm maintainers will say > > Jan -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 29 16:28:51 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 16:28:51 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377651.610931 (Exim 4.92) (envelope-from ) id 1oHSr4-0002zB-Kn; Fri, 29 Jul 2022 16:28:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377651.610931; Fri, 29 Jul 2022 16:28:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSr4-0002z4-I2; Fri, 29 Jul 2022 16:28:50 +0000 Received: by outflank-mailman (input) for mailman id 377651; Fri, 29 Jul 2022 16:28:49 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHSr3-0002yv-NM for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 16:28:49 +0000 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [2a00:1450:4864:20::130]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 85b8aa30-0f5b-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 18:28:48 +0200 (CEST) Received: by mail-lf1-x130.google.com with SMTP id u3so5307164lfl.3 for ; Fri, 29 Jul 2022 09:28:48 -0700 (PDT) Received: from [192.168.1.7] ([212.22.223.21]) by smtp.gmail.com with ESMTPSA id p16-20020a05651211f000b0047f8d7c08e4sm702407lfs.166.2022.07.29.09.28.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Jul 2022 09:28:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 85b8aa30-0f5b-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=llkulA7J9/Yp/jgfTmqHNl4VmoywFnFLFHyHwNhS52I=; b=S4VUp7T90GzkjfCVOUL0UO8m6Wp1ufFSc1cGNfDPJeaaBuRlI0BFnLQIu1elVj7n0v lGANkVKRMojidGjlx2pnZ7n38R68ogAYU+kEBs8qmDfuyv/RbDHMveSMJtOPWr64evnt cV8iohRp/e3gQcBsItNLeyQVQenqThEP+pGc5nW1srXvu5M/xRCYwK4vW9k1wvTx6Kzx OyWC6o/VdO0yC68eJhVQ2fho+kOZobRLfDg01H+fIDvgCi2Ql5bUvi4gLP3m4kHr1hZA oJIcQvSEvgeiAxXa+4LfLcjiJQXzjVpZZRQU2Or9ux/Sqaf/Ygty1kCba0ena5A1LMwk ClDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=llkulA7J9/Yp/jgfTmqHNl4VmoywFnFLFHyHwNhS52I=; b=xT6vv6SxrWN1nc5G6PzjmoEYPvwF+Pbf3iZe23t1j4lZBtQi3ARqMRrIB/7mtuvKYQ oUoa2SO9PMV2nChifAKOmOMkIH6g9Y7Z9cqvrXH41KunhHN50sdWyU2RQmKnFTh/rE33 KwFHwLzDKptfTz5daVaOGy/nQmiPzKbJk2c9RvNYcnZQLup2+dYZ9wwXYRs5Bk2Qo90o g/2UE3VigkFGlZuvfncLF9W4NNtt6xxXmVdYs2NsHNQY2lv1TIahG1BavWpHOO8Q9q0P dqV2Ba9NdMT/r3UliMytNFlYYHKMG1iy5eZEyVR3O8ynmZbJCwqqzZDlN6sfcQGW0Lmu /nFQ== X-Gm-Message-State: ACgBeo3r20WjOhMBBUuFlOprkDJwEpMgBg8WiAQpgis4SqoA9Su9I2wB k7fD5IL8/DwJUt3mRpU49A2+9UgAXbrrRg== X-Google-Smtp-Source: AA6agR7BCBdFBfgu42oz+E8cDComZgU5BALIpq3qlOiN3VtFkUz1pH5L+hh67tkkwE4Mdkp4B2s5ow== X-Received: by 2002:a05:6512:308c:b0:48a:e393:2a63 with SMTP id z12-20020a056512308c00b0048ae3932a63mr987980lfd.213.1659112128123; Fri, 29 Jul 2022 09:28:48 -0700 (PDT) Message-ID: <8e912bdf-a93f-c3d8-8906-8132a8f30035@gmail.com> Date: Fri, 29 Jul 2022 19:28:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH V7 01/11] xen/pci: arm: add stub for is_memory_hole Content-Language: en-US From: Oleksandr To: Rahul Singh Cc: Oleksandr Andrushchenko , Stefano Stabellini , Julien Grall , Bertrand Marquis , Volodymyr Babchuk , xen-devel@lists.xenproject.org References: <20220719174253.541965-1-olekstysh@gmail.com> <20220719174253.541965-2-olekstysh@gmail.com> In-Reply-To: <20220719174253.541965-2-olekstysh@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Rahul On 19.07.22 20:42, Oleksandr Tyshchenko wrote: > From: Oleksandr Andrushchenko > > Add a stub for is_memory_hole which is required for PCI passthrough > on Arm. > > Signed-off-by: Oleksandr Andrushchenko > --- > OT: It looks like the discussion got stuck. As I understand this > patch is not immediately needed in the context of current series > as PCI passthrough is not enabled on Arm at the moment. So the patch > could be added later on, but it is needed to allow PCI passthrough > to be built on Arm for those who want to test it. > > Copy here some context provided by Julien: > > Here a summary of the discussion (+ some my follow-up thoughts): > > is_memory_hole() was recently introduced on x86 (see commit 75cc460a1b8c > "xen/pci: detect when BARs are not suitably positioned") to check > whether the BAR are positioned outside of a valid memory range. This was > introduced to work-around quirky firmware. > > In theory, this could also happen on Arm. In practice, this may not > happen but it sounds better to sanity check that the BAR contains > "valid" I/O range. > > On x86, this is implemented by checking the region is not described is > in the e820. IIUC, on Arm, the BARs have to be positioned in pre-defined > ranges. So I think it would be possible to implement is_memory_hole() by > going through the list of hostbridges and check the ranges. > > But first, I'd like to confirm my understanding with Rahul, and others. May I please ask about your opinion on that? > > If we were going to go this route, I would also rename the function to > be better match what it is doing (i.e. it checks the BAR is correctly > placed). As a potentially optimization/hardening for Arm, we could pass > the hostbridge so we don't have to walk all of them. > --- > xen/arch/arm/mm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c > index 009b8cd9ef..bb34b97eb5 100644 > --- a/xen/arch/arm/mm.c > +++ b/xen/arch/arm/mm.c > @@ -1708,6 +1708,12 @@ unsigned long get_upper_mfn_bound(void) > return max_page - 1; > } > > +bool is_memory_hole(mfn_t start, mfn_t end) > +{ > + /* TODO: this needs to be properly implemented. */ > + return true; > +} > + > /* > * Local variables: > * mode: C -- Regards, Oleksandr Tyshchenko From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:12:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:12:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377661.610942 (Exim 4.92) (envelope-from ) id 1oHTXQ-0000O6-6M; Fri, 29 Jul 2022 17:12:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377661.610942; Fri, 29 Jul 2022 17:12:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTXQ-0000Nz-3E; Fri, 29 Jul 2022 17:12:36 +0000 Received: by outflank-mailman (input) for mailman id 377661; Fri, 29 Jul 2022 17:12:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTXO-0000Np-GO; Fri, 29 Jul 2022 17:12:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTXO-0007Xa-D8; Fri, 29 Jul 2022 17:12:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTXO-0003eH-5v; Fri, 29 Jul 2022 17:12:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHTXO-0006Gg-5N; Fri, 29 Jul 2022 17:12:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mmPElGo/Gm473l+rX+tc/wTGL/Lwfme7Z2fjUBc3CdE=; b=xlNokiPtZh23OnmvMcJiFHBdDS 1D+HPDfksY5P2mkxpkQLLXXZuze5i9mM/T6W+yaGJLaQpr6D+N0G8cb48tof5tLrSxPBAZKPQkmcR wgk5JV4x46B7roZX5BTvWOyxgCXLBq/XrTffIgjFjJLOYTRjZwbdBxDJtFR35no7w4U8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171912: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-amd64-xl-multivcpu:debian-install:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qcow2:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:debian-di-install:fail:heisenbug qemu-mainline:test-amd64-i386-xl-vhd:guest-start/debian.repeat:fail:heisenbug qemu-mainline:test-armhf-armhf-xl-rtds:guest-start/debian.repeat:fail:allowable qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=cc42559ab129a15554cc485ea9265e34dde7ab5b X-Osstest-Versions-That: qemuu=a17001c42329f809c7f1768925b8089324564312 From: osstest service owner Date: Fri, 29 Jul 2022 17:12:34 +0000 flight 171912 qemu-mainline real [real] flight 171922 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171912/ http://logs.test-lab.xenproject.org/osstest/logs/171922/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-xl-multivcpu 12 debian-install fail pass in 171922-retest test-amd64-amd64-xl-qcow2 21 guest-start/debian.repeat fail pass in 171922-retest test-arm64-arm64-libvirt-raw 12 debian-di-install fail pass in 171922-retest test-amd64-i386-xl-vhd 21 guest-start/debian.repeat fail pass in 171922-retest Regressions which are regarded as allowable (not blocking): test-armhf-armhf-xl-rtds 18 guest-start/debian.repeat fail REGR. vs. 171900 Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 171922 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 171922 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171900 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171900 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171900 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171900 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171900 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171900 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171900 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171900 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu cc42559ab129a15554cc485ea9265e34dde7ab5b baseline version: qemuu a17001c42329f809c7f1768925b8089324564312 Last test of basis 171900 2022-07-28 20:08:23 Z 0 days Testing same since 171912 2022-07-29 02:12:34 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Daniel Henrique Barboza Joel Stanley Nicholas Piggin Peter Maydell Richard Henderson jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu fail test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 fail test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd fail ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git a17001c423..cc42559ab1 cc42559ab129a15554cc485ea9265e34dde7ab5b -> upstream-tested From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:36:42 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:36:42 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377671.610952 (Exim 4.92) (envelope-from ) id 1oHTuc-0003Gx-5Y; Fri, 29 Jul 2022 17:36:34 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377671.610952; Fri, 29 Jul 2022 17:36:34 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTuc-0003Gq-2s; Fri, 29 Jul 2022 17:36:34 +0000 Received: by outflank-mailman (input) for mailman id 377671; Fri, 29 Jul 2022 17:36:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTua-0003GO-P6; Fri, 29 Jul 2022 17:36:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTua-0007wA-KB; Fri, 29 Jul 2022 17:36:32 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTua-0004z8-DR; Fri, 29 Jul 2022 17:36:32 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHTua-00057d-Cq; Fri, 29 Jul 2022 17:36:32 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=09M/Bi0cYmw+JVMC07Qh8eiv39ZzMpfeKGFfDMEhNTk=; b=kgaw6XMI9ODpITsaQkTTqALqqI 7bmfVBzglxk4WiXNWPOUUBQN28zkOk5VkQRTPOMyGMKvuQ7k7+m0nbpTN+QxEWwvaPKdoRsPcKIEn z+nd2rSlBhey2TtnsiI5V8kce4qdw0Bzd5Hrp+h/O5jLrHVAU2IfqrAzxzG+4psf+djo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171919: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=062790aca6b1faea62c9ed2737c3791efb0d0f4c X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 17:36:32 +0000 flight 171919 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171919/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 062790aca6b1faea62c9ed2737c3791efb0d0f4c baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 0 days 6 attempts Testing same since 171917 2022-07-29 10:03:07 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 062790aca6b1faea62c9ed2737c3791efb0d0f4c Author: Xenia Ragiadakou Date: Fri Jul 29 08:51:31 2022 +0200 arm/atomic: fix MISRA C 2012 Rule 20.7 violation The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit 124f138b37d595294b3100349e26ffb3f1df7b13 Author: Xenia Ragiadakou Date: Fri Jul 29 08:50:58 2022 +0200 xsm/dummy: fix MISRA C 2012 Directive 4.10 violation Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu Acked-by: Daniel P. Smith commit 9ff3231f955cee4d62c7be6a03d061c037d7ca69 Author: Jan Beulich Date: Fri Jul 29 08:50:25 2022 +0200 x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Now that we're not building multi.c anymore for 2 and 3 guest levels when !HVM, there's no point in having these conditionals anymore. (As somewhat a special case, the last of the removed conditionals really builds on shadow_mode_external() always returning false when !HVM.) This way the code becomes a tiny bit more readable. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 5b04fe78646a8222626996113c9d1e598cb84831 Author: Jan Beulich Date: Fri Jul 29 08:49:48 2022 +0200 x86/shadow: don't open-code shadow_remove_all_shadows() Let's use the existing inline wrapper instead of repeating respective commentary at every site. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 8a3b89e4307da260675483bb86fc06cc62ed7c08 Author: Jan Beulich Date: Fri Jul 29 08:49:06 2022 +0200 x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM In my (debug) build this amounts to well over 500 bytes of dead code. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 3629759626ac7201a670a8a2d4d4a536e7443575 Author: Jan Beulich Date: Fri Jul 29 08:48:26 2022 +0200 x86/shadow: properly handle get_page() failing We should not blindly (in a release build) insert the new entry in the hash if a reference to the guest page cannot be obtained, or else an excess reference would be put when removing the hash entry again. Crash the domain in that case instead. The sole caller doesn't further care about the state of the guest page: All it does is return the corresponding shadow page (which was obtained successfully before) to its caller. To compensate we further need to adjust hash removal: Since the shadow page already has had its backlink set, domain cleanup code would try to destroy the shadow, and hence still cause a put_page() without corresponding get_page(). Leverage that the failed get_page() leads to no hash insertion, making shadow_hash_delete() no longer assume it will find the requested entry. Instead return back whether the entry was found. This way delete_shadow_status() can avoid calling put_page() in the problem scenario. For the other caller of shadow_hash_delete() simply reinstate the otherwise dropped assertion at the call site. While touching the conditionals in {set,delete}_shadow_status() anyway, also switch around their two pre-existing parts, to have the cheap one first (frequently allowing to avoid evaluation of the expensive - due to evaluate_nospec() - one altogether). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:37:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:37:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377678.610963 (Exim 4.92) (envelope-from ) id 1oHTvA-0003vJ-FJ; Fri, 29 Jul 2022 17:37:08 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377678.610963; Fri, 29 Jul 2022 17:37:08 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTvA-0003vC-Ci; Fri, 29 Jul 2022 17:37:08 +0000 Received: by outflank-mailman (input) for mailman id 377678; Fri, 29 Jul 2022 17:37:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTv9-0003v1-5N for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:37:07 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHTv1-0007wa-Jv; Fri, 29 Jul 2022 17:36:59 +0000 Received: from [54.239.6.186] (helo=[192.168.0.45]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHTv1-0008GC-Bu; Fri, 29 Jul 2022 17:36:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=FXAMCUaMzKXp+xgrh2RexegPfNoHS1Rk6RUnZH85ZIs=; b=TPhtVOkMUAJVV7u1KZUd4jqzGa c+Ec72B8UQGkxBviBbsMTIcfFRA3bL6x7ETA2kTqM4+gin7c7ucD1vceb6CmhYrOTE8y8ZuYKceyK eo7pzApR3MA0nY2SThKVEBaCFRilWELQHDB3MH/vqUj6rZKRTtxscKNQy+k+wNQjOwWE=; Message-ID: Date: Fri, 29 Jul 2022 18:36:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 Subject: Re: [xen-unstable-smoke bisection] complete build-amd64-libvirt To: Jan Beulich , Oleksandr Tyshchenko , Anthony PERARD Cc: osstest service owner , xen-devel@lists.xenproject.org References: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> Content-Language: en-US From: Julien Grall In-Reply-To: <08606914-f5f4-8415-51a2-f6a5e1c54d20@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 29/07/2022 07:22, Jan Beulich wrote: > On 29.07.2022 03:04, osstest service owner wrote: >> branch xen-unstable-smoke >> xenbranch xen-unstable-smoke >> job build-amd64-libvirt >> testid libvirt-build >> >> Tree: libvirt git://xenbits.xen.org/libvirt.git >> Tree: libvirt_keycodemapdb https://gitlab.com/keycodemap/keycodemapdb.git >> Tree: qemu git://xenbits.xen.org/qemu-xen-traditional.git >> Tree: qemuu git://xenbits.xen.org/qemu-xen.git >> Tree: xen git://xenbits.xen.org/xen.git >> >> *** Found and reproduced problem changeset *** >> >> Bug is in tree: xen git://xenbits.xen.org/xen.git >> Bug introduced: 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >> Bug not present: f732240fd3bac25116151db5ddeb7203b62e85ce >> Last fail repro: http://logs.test-lab.xenproject.org/osstest/logs/171909/ >> >> >> commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f >> Author: Oleksandr Tyshchenko >> Date: Fri Jul 15 22:20:24 2022 +0300 >> >> libxl: Add support for Virtio disk configuration > > Just in case you didn't notice it: Something's wrong here. I didn't look > at the details at all. Please advise whether a fix will soon arrive or > whether we should revert for the time being. We had discussion on IRC about this today. This is an issue in libvirt rather than Xen. So I think a revert is not warrant here. Instead, it was suggested to force push because it is going to take some times to fix libvirt (see more below). Oleksandr already sent a patch to fix libvirt [1]. The problem is even if this is accepted, our testing branch for libvirt is 2 years behind because they switched to Meson and Osstest has not been adapted to the new build system. Anthony kindly offered to update Osstest. Regarding force pushing, I am waiting for the Osstest result to confirm that only the libvirt tests are failing in staging (we already have the results for smoke). So my plan is to force push on Monday. Please let me know on Monday morning if you have some concerns with this approach. Cheers, [1] https://lore.kernel.org/xen-devel/20220729155024.3327364-1-olekstysh@gmail.com/ -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377686.610975 (Exim 4.92) (envelope-from ) id 1oHUBe-0006aB-Rr; Fri, 29 Jul 2022 17:54:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377686.610975; Fri, 29 Jul 2022 17:54:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBe-0006a3-Op; Fri, 29 Jul 2022 17:54:10 +0000 Received: by outflank-mailman (input) for mailman id 377686; Fri, 29 Jul 2022 17:54:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBd-0006Zx-8z for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:09 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 6f4ca0d9-0f67-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 19:54:07 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6f4ca0d9-0f67-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117246; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=0XhqZ8NRblIeCreSrfdQ9yayvs4XLb4vL2XM9dKH9MI=; b=Olub0/TxHoeGYkwVPs1gUqmyLYbi0fhmOLAxAFjNVndFxAbpTMIz3vMB ShbMT33OF7024qTLsXL4WxJlni8CE/i+ZtD0l7rapqwwUHx9WWk2aL4i/ gHl8zoSbUbD+LMFXDLhEKE4OB445VHpKfENz+we7uSmoD0zTzp/t2uOor g=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 77388856 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:HU0/CKv9tOJ6MyKo8h3FoJZFJefnVDVeMUV32f8akzHdYApBsoF/q tZmKTrQa/zZa2rxKIwkatvi8EtV7JOEz4NjTlFurHwwES0W+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyt4mJA5DTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FaFB1qEqInNFz OQdDRsAS0m9p9u9663uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLElobFpM42vuvnH78WzZZtEiUtew85G27IAlZj+e2YIqFJ4LiqcN9nkGWu UvcxVvAWU8/C/ub2R2g4FOyibqa9c/8cN1LT+DpnhJwu3Wfz3IeIAcbXly6pb++kEHWc81bA 1wZ/Gwpt6da3FymSJzxUgO1pFaAvwUAQJxAHusi8gaPx6HIpQGDCQA5oiVpMYJ88pVsHHpzi wHPz4iB6SFTXKO9ZSuxseq3vziLIS0wBmInPBEkdAAu/Iy2yG0stS4jXuqPAYbs0ICkQWyhn mjbxMQtr+5N1JBWjs1X6XiC2mvx/caRE2bZ8y2NBgqYAhVFiJlJjmBCwXzS9r5+IYmQVTFtV 1BUypHFvIji4Xxg/RFhodnh/5nzvp5pyBWG3TZS82AJrlxBAUKLc4FK+y1ZL0x0KMsCcjKBS BaN5FIJv8QIbCf1N/Afj2eN5yMClPKIKDgYfqqMMoomjmZZL2drAx2ClWbPhjuwwSDAYIk0O IuBcNbEMEv2/Z9PlWPuL89AgOBD+8zL7TmMLXwN50j4jOH2ib/8YettDWZimchjsPrd8F2Or 4s32gnj40w3bdASqxL/qeY7RW3m51BibXwqg6S7rtK+Hzc= IronPort-HdrOrdr: A9a23:03lGSq84duHOqchc7HRuk+DgI+orL9Y04lQ7vn2YSXRuHPBw8P re5cjztCWE7gr5N0tBpTntAsW9qDbnhPtICOoqTNCftWvdyQiVxehZhOOIqVDd8m/Fh4pgPM 9bAtBD4bbLbGSS4/yU3ODBKadD/OW6 X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="77388856" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Christian Lindig , David Scott Subject: [PATCH v1 2/7] tools/ocaml/*/Makefile: generate paths.ml from configure Date: Fri, 29 Jul 2022 18:53:25 +0100 Message-ID: <0752fe6eaa26f244f6fb45b1c3c6b9906deb2aa9.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit paths.ml contains various paths known to configure, and currently is generated via a Makefile rule. Simplify this and generate it through configure, similar to how oxenstored.conf is generated from oxenstored.conf.in. This will allow to reuse the generated file more easily with Dune. No functional change. Signed-off-by: Edwin Török --- tools/configure | 4 +++- tools/configure.ac | 2 ++ tools/ocaml/libs/xs/Makefile | 5 ----- tools/ocaml/libs/xs/paths.ml.in | 1 + tools/ocaml/xenstored/Makefile | 5 ----- tools/ocaml/xenstored/paths.ml.in | 4 ++++ 6 files changed, 10 insertions(+), 11 deletions(-) create mode 100644 tools/ocaml/libs/xs/paths.ml.in create mode 100644 tools/ocaml/xenstored/paths.ml.in diff --git a/tools/configure b/tools/configure index a052c186a5..41deb7fb96 100755 --- a/tools/configure +++ b/tools/configure @@ -2453,7 +2453,7 @@ ac_compiler_gnu=$ac_cv_c_compiler_gnu -ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/xenstored/oxenstored.conf" +ac_config_files="$ac_config_files ../config/Tools.mk hotplug/FreeBSD/rc.d/xencommons hotplug/FreeBSD/rc.d/xendriverdomain hotplug/Linux/init.d/sysconfig.xencommons hotplug/Linux/init.d/sysconfig.xendomains hotplug/Linux/init.d/xen-watchdog hotplug/Linux/init.d/xencommons hotplug/Linux/init.d/xendomains hotplug/Linux/init.d/xendriverdomain hotplug/Linux/launch-xenstore hotplug/Linux/vif-setup hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain ocaml/libs/xs/paths.ml ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf" ac_config_headers="$ac_config_headers config.h" @@ -10935,6 +10935,8 @@ do "hotplug/Linux/xendomains") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/xendomains" ;; "hotplug/NetBSD/rc.d/xencommons") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xencommons" ;; "hotplug/NetBSD/rc.d/xendriverdomain") CONFIG_FILES="$CONFIG_FILES hotplug/NetBSD/rc.d/xendriverdomain" ;; + "ocaml/libs/xs/paths.ml") CONFIG_FILES="$CONFIG_FILES ocaml/libs/xs/paths.ml" ;; + "ocaml/xenstored/paths.ml") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/paths.ml" ;; "ocaml/xenstored/oxenstored.conf") CONFIG_FILES="$CONFIG_FILES ocaml/xenstored/oxenstored.conf" ;; "config.h") CONFIG_HEADERS="$CONFIG_HEADERS config.h" ;; "hotplug/Linux/systemd/proc-xen.mount") CONFIG_FILES="$CONFIG_FILES hotplug/Linux/systemd/proc-xen.mount" ;; diff --git a/tools/configure.ac b/tools/configure.ac index 1094d896fc..32cbe6bd3c 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -21,6 +21,8 @@ hotplug/Linux/xen-hotplug-common.sh hotplug/Linux/xendomains hotplug/NetBSD/rc.d/xencommons hotplug/NetBSD/rc.d/xendriverdomain +ocaml/libs/xs/paths.ml +ocaml/xenstored/paths.ml ocaml/xenstored/oxenstored.conf ]) AC_CONFIG_HEADERS([config.h]) diff --git a/tools/ocaml/libs/xs/Makefile b/tools/ocaml/libs/xs/Makefile index e934bbb550..e160e6a711 100644 --- a/tools/ocaml/libs/xs/Makefile +++ b/tools/ocaml/libs/xs/Makefile @@ -44,8 +44,3 @@ uninstall: $(OCAMLFIND) remove -destdir $(OCAMLDESTDIR) xenstore include $(OCAML_TOPLEVEL)/Makefile.rules - -genpath-target = $(call buildmakevars2module,paths.ml) -$(eval $(genpath-target)) - -GENERATED_FILES += paths.ml diff --git a/tools/ocaml/libs/xs/paths.ml.in b/tools/ocaml/libs/xs/paths.ml.in new file mode 100644 index 0000000000..c067f8d012 --- /dev/null +++ b/tools/ocaml/libs/xs/paths.ml.in @@ -0,0 +1 @@ +let xen_run_stored = "@XEN_RUN_STORED@" diff --git a/tools/ocaml/xenstored/Makefile b/tools/ocaml/xenstored/Makefile index 0b5711b507..6f7333926e 100644 --- a/tools/ocaml/xenstored/Makefile +++ b/tools/ocaml/xenstored/Makefile @@ -93,8 +93,3 @@ uninstall: rm -f $(DESTDIR)$(sbindir)/oxenstored include $(OCAML_TOPLEVEL)/Makefile.rules - -genpath-target = $(call buildmakevars2module,paths.ml) -$(eval $(genpath-target)) - -GENERATED_FILES += paths.ml diff --git a/tools/ocaml/xenstored/paths.ml.in b/tools/ocaml/xenstored/paths.ml.in new file mode 100644 index 0000000000..37949dc8f3 --- /dev/null +++ b/tools/ocaml/xenstored/paths.ml.in @@ -0,0 +1,4 @@ +let xen_log_dir = "@XEN_LOG_DIR@" +let xen_config_dir = "@XEN_CONFIG_DIR@" +let xen_run_dir = "@XEN_RUN_DIR@" +let xen_run_stored = "@XEN_RUN_STORED@" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377687.610986 (Exim 4.92) (envelope-from ) id 1oHUBg-0006pq-7V; Fri, 29 Jul 2022 17:54:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377687.610986; Fri, 29 Jul 2022 17:54:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBg-0006pj-4g; Fri, 29 Jul 2022 17:54:12 +0000 Received: by outflank-mailman (input) for mailman id 377687; Fri, 29 Jul 2022 17:54:11 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBf-0006a9-6e for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:11 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 71941a78-0f67-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 19:54:09 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 71941a78-0f67-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117249; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=VVD7G2LkVyNCzG/pHfe/kdLkRc8BoThzx8VPlS+iO60=; b=YlqEghSfC2dVITCfFJAh5TgyqqcIvFxtfI9TopN5DDx9N19z1CvPmmDF Oa5m4n6LAajMMLgUdw6X1+teSKVS5ypDt4/NfmgfVueVtg5OAJZLkkDTZ 1JspD7BlueJ01fLM0vC1obExgEb3DOugM1yjjeUyZzndj9iUqqryoR2Vx U=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76954906 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AfIy9p67Lxj81PkSfPwyxlgxR2vbMJaxDgicv2?= =?us-ascii?q?9bJVGNS3hzvzP4wXsRDTujRkuZqZDvb7yzGW0cUVF/XAW5zYYN0QI0iEgVdH?= =?us-ascii?q?alNNuE0JwZLfNgEvJfZhRHGoA4rYvCxxwf6MU/QvLN2GFB/zkPdL0Otk0MyZ?= =?us-ascii?q?8oTFLw3Hls8CtaUNQ2PKE6Stmcd7MkJoJLIo/zZhfLCG5ViXUDWnaHGg3yku?= =?us-ascii?q?wsATahAcdWKHbmZkmUkBzHbD5HkMeAv+fgf3YWQC0bYeJ7K/+0BmEjGvgyvU?= =?us-ascii?q?mCrvGXKMz5YOaEMiQUyAnuQrAZJuLVTDomDnj7lTWD3wB06U9lXJ2WkNZe/g?= =?us-ascii?q?yMO/tQWkac92fYRWHI5nLvf3fRhKVoZjhxI+8pZA018VmCqvbqJOpq75ZBxu?= =?us-ascii?q?W8VCuvVUxo5aFwC1cmz69W9LMk4Tqg/wQeLhbq5uZZKUNtZJ1YcRvE0HX3E+?= =?us-ascii?q?IsVDSzJyLV3lTqXt8r889jziweWKhFl5D2LsccW0gGdAImQVHMrCXFgu9wRu?= =?us-ascii?q?DeS0INK4lIZ5SSzlHiolQI4N0UgV+TQA+N9f8k34d81p7G+vOBCYV6x7JUAK?= =?us-ascii?q?CnsaIFEFzRZyXTZzodvknl1INy1BToPaKqpFZ8Q8uvna5pSoE3aAI9Hp4jqO?= =?us-ascii?q?nOB8X8GncY99nJcP8sjmlKGqtTR2u2DFuTrA8fTWUGu0HQ51bOqIdV6PmjDO?= =?us-ascii?q?G8Kx2ckT0Ao0xOL93YL68KvvDmPcHKhfCnpA87GwOWD4pib8eAc/BDtimUAw?= =?us-ascii?q?3sOAFGHiMGwHVyZOoESxcj1m3b3wBjsCvTEL1NaMGOm5k6utiB7evHtREQvT?= =?us-ascii?q?5I9iHwXYsSt4MvpC9zRL3VmMCaBfuDRJkdr6WWIjp5DzOlR/F4sZp6Iv5/kz?= =?us-ascii?q?X6LOchdZcL1JeMrLEt0Gw6YpnrgEXFfBuI+ysGad6o/oFlHrbnOho2vEFB3c?= =?us-ascii?q?ul0/WKsdGrvpFNmjaSfbkESpY71xJo6qTLMi0RAi9Rbv+GpTpQoqhJBpWWrv?= =?us-ascii?q?qWOeDMhb5UbXUBfWg/Ag6dUXnus4aT9MQWeFhqFsWzotA6BmaaR0wf3HOyot?= =?us-ascii?q?t5Ydk/Fr8haCWSiu9ldUJdGsk1Ij9BUVcWFe9lISCiPZ7Db0I3qjMT5pqV5k?= =?us-ascii?q?0uihnWGS67O2u8YzcnZ2ULFvNSURqPsANr0ejSUv/rY63PmkE3ib+MomOAEj?= =?us-ascii?q?7sSkbtLNlG4qLTmywdtwN3nqM4rpZMiBrYMSVQY0mlfX0++EohVI0N23MbAU?= =?us-ascii?q?/RLAAYd9AWB3+G6L5y6o2jW6Kftos7lNbwKc/vWgAk/RuDGT/g0QLkaoKHcn?= =?us-ascii?q?s27Zgdn32+ucmh08g8YC49tM5IRay6yZBvm2F8mLVFt3oADGStIjcJsoRja3?= =?us-ascii?q?G5t7Azc/ZlLxgPRWATFB8s0tw1tsNdAjKIlzC5oz/R/sxZj2Jl+Kox72jmkd?= =?us-ascii?q?TKr1bcbaA3B/2B9ASfSTP2k1R88cw4nZ1ZIivLf3RAHeFuP9SGYeTH93kRYN?= =?us-ascii?q?n/HvcxY3WuiPidbyPwLVpaqQSjzKoc2SckDoGUlwIKHAKSGRw0ao2hPuCpCn?= =?us-ascii?q?51nKg0Z1tyPb5jbAqNWuMF2Cxh4dxACBO0ufDFUGc9GDFqtma0xxGuwyuzw7?= =?us-ascii?q?Ma47UXjcxk35hy3cgPROotxhThul8tIJIDV5f2zD+ED1CWLlfr4NDNF0603u?= =?us-ascii?q?24Dbr/HADikB+M/WI6N8DRO/u2eHg5AFdzW3vOIvmNKUkLqiFXkKh/2RzTnv?= =?us-ascii?q?nz5YHye6VDnJNcbxvEGwd1CCAs3H80/oyZX5zI60SXef3janVH6Swe35VS19?= =?us-ascii?q?bz7UzYBJAl6ROC/uwlmLkw93tvJTTpHwgf9aQfB+uW5myV0lQrHSszN5rZC0?= =?us-ascii?q?zro6YqUE6xuuRcfrrXPfmumeeWshQROTnspLwvpd1uzua9o46d0K6bzYDn4b?= =?us-ascii?q?3ncssKwNKiOyfdIFZLaXiQlWdh2X5hVqtEvhadRd02YgHeIAy2DzTfic2tt3?= =?us-ascii?q?7wM0/4QWfvQZgZGu2zfxq1/VS5jtvG/wrdcb5MnNiMM/I6exdMJU7siOLhDw?= =?us-ascii?q?B2C5I7un/T5CFqDHw4MQD2KIvP1bnffpYAssx2moWqM+YG7gnfgzI1nzrvD9?= =?us-ascii?q?HEz32o17Mdb0WKGfXv/Q4ADYrTbCwJ0F+uFWFxp6Ckhpq5RMDAsgDwLK3pOf?= =?us-ascii?q?mvhLsSU7coS2tctR+ahp2tCDM4vWagaX8y+phT1BPFEDjZTp/8JScugZKdoj?= =?us-ascii?q?407IaAVYX98noa+Hy3AA5ljQxxayw0VfPQ5xHAhChRZbwGAIagMCarxT605e?= =?us-ascii?q?GTYBIMv1esRUfdMHnIhWAlh6FotFMd1MGPK57wHfve2mPHXEHykj/kkiGr+7?= =?us-ascii?q?Z8VZwTAn5NpGRH7d8E/LL2nG9fIXAQKX4YwnwHH/kpAwBdrfi17AHtt3FSMP?= =?us-ascii?q?WzOI/Crnw/FxPZjWwlwAwPTFXaRLgqK3JPprjWBXlQTQDFHk9hqWrg4Fxwre?= =?us-ascii?q?YM3HMGiqsY4T36utjlBgDIAUrgLHrEePNAWZDxTgT3yB5MhIvwqWMzgZWxzS?= =?us-ascii?q?85CXAWiRqqj9P4eVYRNw/8ES788AMhITprxWrZXe4+hYTTaAmYPjAB1Su9nk?= =?us-ascii?q?LSGPQA7m0SNdAd9+In73OBwZyc451G5p6wFLaB4oiKvMHzIqytInEqGvMVkK?= =?us-ascii?q?ip2K/aK5txyHd4ATXvpJaYw08l46NqzQv0L3qewrMBAIIzFkrCGQ521ZDKl1?= =?us-ascii?q?N/R3dPVnK5298k=3D?= X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76954906" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 7/7] tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat Date: Fri, 29 Jul 2022 18:53:30 +0100 Message-ID: <6e5fd9edfea379b69682fa538141298fc1bc3110.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Add a finalizer on the event channel value, so that it calls `xenevtchn_close` when the value would be GCed. In practice oxenstored seems to be the only user of this, and it creates a single global event channel only, but freeing this could still be useful when run with OCAMLRUNPARAM=c The code was previously casting a C pointer to an OCaml value, which should be avoided: OCaml 5.0 won't support it. (all "naked" C pointers must be wrapped inside an OCaml value, either an Abstract tag, or Nativeint, see the manual https://ocaml.org/manual/intfc.html#ss:c-outside-head) Signed-off-by: Edwin Török --- tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++++++++++++++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c index f889a7a2e4..c0d57e2954 100644 --- a/tools/ocaml/libs/eventchn/xeneventchn_stubs.c +++ b/tools/ocaml/libs/eventchn/xeneventchn_stubs.c @@ -33,7 +33,30 @@ #include #include -#define _H(__h) ((xenevtchn_handle *)(__h)) +/* We want to close the event channel when it is no longer in use, + which can only be done safely with a finalizer. + Event channels are typically long lived, so we don't need tighter control over resource deallocation. + Use a custom block +*/ + +/* Access the xenevtchn_t* part of the OCaml custom block */ +#define _H(__h) (*((xenevtchn_handle**)Data_custom_val(__h))) + +static void stub_evtchn_finalize(value v) +{ + /* docs say to not use any CAMLparam* macros here */ + xenevtchn_close(_H(v)); +} + +static struct custom_operations xenevtchn_ops = { + "xenevtchn", + stub_evtchn_finalize, + custom_compare_default, /* raises Failure, cannot compare */ + custom_hash_default, /* ignored */ + custom_serialize_default, /* raises Failure, can't serialize */ + custom_deserialize_default, /* raises Failure, can't deserialize */ + custom_compare_ext_default /* raises Failure */ +}; CAMLprim value stub_eventchn_init(void) { @@ -48,7 +71,9 @@ CAMLprim value stub_eventchn_init(void) if (xce == NULL) caml_failwith("open failed"); - result = (value)xce; + /* contains file descriptors, trigger full GC at least every 128 allocations */ + result = caml_alloc_custom(&xenevtchn_ops, sizeof(xce), 1, 128); + _H(result) = xce; CAMLreturn(result); } -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377688.610996 (Exim 4.92) (envelope-from ) id 1oHUBi-00076l-Fc; Fri, 29 Jul 2022 17:54:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377688.610996; Fri, 29 Jul 2022 17:54:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBi-00076c-Bx; Fri, 29 Jul 2022 17:54:14 +0000 Received: by outflank-mailman (input) for mailman id 377688; Fri, 29 Jul 2022 17:54:13 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBg-0006a9-SJ for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:12 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 73981336-0f67-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 19:54:11 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 73981336-0f67-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117251; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=YsqAUruZxEJZb5m63knmpMxcbbh9Lwsahf6qP5J6SRg=; b=csiKeO3Qi3BK7huzdBDZRIfrD21iNnMzO0rF22E5T++Ui8ZVT9tRzwBy y2nSUVUj/bWBsuvmzpY5e5xEqx9ruzhBXOGENRAzIEbPH54lyANAungxW sSjncoCZq4hIek7L3zkruR+dSzBr9Z67/UBY0Uuw5VOA/MLvOxrYBl9t4 M=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76954909 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: =?us-ascii?q?A9a23=3AFxXJPawBzM7eICQM0pF6t4n5zX0HO/c/ZkZSj?= =?us-ascii?q?0bt7gibmJ9p5j4zwXa+PPA8n6MSOj+oBzLS1YKs1foezaYk266aquEDHqvKj?= =?us-ascii?q?qCfOsM6bLDre/KbNWdY6s4SBA5s+mKOzHkOM/ISFHkvY9UAfsMjU7+bXqUrz?= =?us-ascii?q?JLSLOobNlPUVXVjmdP4dYsj+QTJro8s6wH8SPKjhKP/YcDZk/OMio2BbITP5?= =?us-ascii?q?Sk/mVEVEC/+6spRb7BO+yISBg7gNFo9fF4k303rZYrP0QGJb7w/GSNHejqED?= =?us-ascii?q?sOBjtxvSfUyR5ARWgdXeWV3FBaoO3SsojjwVn74Akjg7VDFHt7otLIq4LLWr?= =?us-ascii?q?N6NnvAWNCzNtmH6yy2SQu3grTMhNJLPI6Izdr16gWc34e9VdK2K9LgeEuOl4?= =?us-ascii?q?GZ5WWYZCoi+TUjAx/JGPH+cWD15qx2vw0c598Cu+viJjz2YCMAOPdCtPLKcu?= =?us-ascii?q?p8e2HXIjRioyrACeSWohFQXNNjQFnCuaTnwR8dBnuRRuio2HAQoVRwtaDD0O?= =?us-ascii?q?URJcGGl7vRdiWg9fGpp1wPGN6MpnDfpfE/IB20JBP9OBHmroLfYyWeGG7zYC?= =?us-ascii?q?BNHn3eYGDdQALzSkTy9kS/uAdFAodWgePyLBXQe7yBmktTgTlZjbGPnRz0gP?= =?us-ascii?q?p19xduFE8kyxkMrSVKOWUK/vee/yekHhEa9Ob9Gf8fGg6cbo+5/iAs4Skg/y?= =?us-ascii?q?AUUXdtmDCWwAxLkRWRwYdYy9ozzj9+rB0f2GFwYXDuXliuH9Q+QgBUnFYOUU?= =?us-ascii?q?qlBFJIeSzQcMY90r56TctOM/YK8r/kQaro5YCKeyrTDitMy1lxRR1j2EN1+j?= =?us-ascii?q?gU7u2d4mvnasCpWMvOeWdh1v/WUv74XKHkLE4fCTcqvVK3BZW9RPPhD/mvWA?= =?us-ascii?q?6Qf9ihRhgeXotRkpacgwqcXT5aJa7bssCOzV/WlFUgzQuiJ28zyUFmcxmz4o?= =?us-ascii?q?O1NifmzVivdJCz9DFP29c9pFRYW6N7Xwe6d7vu7q9T4Iy8zJqe9qg1dooGbl?= =?us-ascii?q?W0hXuGZozhqjADDB9i3TTVm3q7lu60ghVMCU8XBVse6dgD2t15zocwtNz4xM?= =?us-ascii?q?YtFTNfpj/N+ZycDmqzp2+e38F5w/eG7b9IrPOgE1IMliP169Qi0KA9RZPUEe?= =?us-ascii?q?7kYCX6q9gnj1KOQyINCmhthEwnCDNstzggbKejBflewiF9a3MhmKKE9hO5og?= =?us-ascii?q?yTvCiWw436pKs8FTB3SrOpyrag69lFO05JZX2TDizkkoTyMAP7JMwQ9zIlJH?= =?us-ascii?q?doaclgtTWRX6GDvFK8/+3R+MttnM7ezZBi9YkQJZt6VRxf+YuIUzRVjvCzEf?= =?us-ascii?q?px4HBEdi1NYRIsEWqPPD29Q6sF3t68gbHAiFiSwsv+rMjAmrs3EnLGvJkXwB?= =?us-ascii?q?ijPLXEkpWaIGdioh7B3NS/BZd481N/S6jctN6WdVp2wVHcT9cuQ1Kcb1TG9v?= =?us-ascii?q?+z/mnwvXvB8D4se0sp5NbtaZxXGfCF9M+3+TaIjLDCMy+qAwiR2hiIlHByze?= =?us-ascii?q?bq7ryODLonhLuEBs5kBGcN9hucVrqDelGdmnA3EfKQqFkUP8WxscT5i3M5fn?= =?us-ascii?q?rky7x2I/aJwLz1rlPkOv2JFlBa0rXZPMKFRPlt4ZcW63OEEg4SrEv2vyiGQ2?= =?us-ascii?q?rG/cbtw1QGuFG2Bqratc9jv2GnctgtE3eLIdVEE444P/j77nDfW2V5p6c2n9?= =?us-ascii?q?7hSij7N6AFwFZlfOXLC/pSJtQwOsTVCX0rlhNzowWeiyQzbUFS0eJpo6YPN8?= =?us-ascii?q?vGdqA+/Mn86OHMQTKx6EyqBrNZIU/zfKerQw5IwQKJbejFpDtQ7gCUqV3eJ7?= =?us-ascii?q?irjqN5vaNES26vwawBGid0FvNOyQVJOvDnuaaetC5UR9jXwlcxM34xnZVmbU?= =?us-ascii?q?OTTN5TtzoAcGtE2J2uNLY1WwYra0ZxAuVatbl5x5k/myEFyWsnYeaSbe79Ar?= =?us-ascii?q?0N5j4s8hzRB2LEulgbGTqGqtNxL9PRFDbf4pWk0X2dY/ddRkti0jBdjd4gez?= =?us-ascii?q?lJXFCZerst/RA5sZ434r3yLYVDK+dXiks3v3W2omjYQ2+R2lcpTHl6DCVKqK?= =?us-ascii?q?NgifenREYzc+klASUeo6iWtLAcMlinvc26ZHWnuvu2e6QlmDxIGoTToqFoBb?= =?us-ascii?q?DNsPo5pVxQbRQYPhBVXz7Z07t2f4f0W7oL9ffCjYmeJQo9rjTvpp7ZfuJmxs?= =?us-ascii?q?GhASa5YY3CHieSCaINgW+T8l3LGhGfMNtKgQt68ZOIqulAmrbySx1V7dJ8mI?= =?us-ascii?q?WZEAn8VUx7I5MzosyOD45h8uuDNbYGXr2QAGVtzXTdvR6WNiuAGS9co53jXm?= =?us-ascii?q?MhV6bWrj9OJD1vaMUmMsxtxwbEFQqb3C7yva8Mk8PL2W0hUnE9Q5+ZDmCkRj?= =?us-ascii?q?/jLxmZa0WFsD9RfONd8a6wfTxRGs/m4iYgSEn8pRKi/44wXhJU/jxRvaltMP?= =?us-ascii?q?oyVgYe/YO3tZG3XoPGK+wAI+ir33oRb+7towEfPcBMM6P750lZSVNvBZ4jJS?= =?us-ascii?q?k0cMiDKBqeTaIek3TmCwHvtoR4CdrPj0D+5sDfEIixf1r3PWkqAkcTqKS4Jo?= =?us-ascii?q?gNLkyagnvPfrWUKNyy/TIeq5d/hVEPwT4A3KcsDFvb+EWuHMlmVNjJNQSy2F?= =?us-ascii?q?qTaMnTZazeVsAKlYH9VgAAljGMBiNJEY0iPbcLrw3k0cLtc8FUVuDb05y0GA?= =?us-ascii?q?FCHwDKWouSBN3kqp5WEXPc8Nr7ObtOzp+EhvKFB32wk9rH1h1bUMHtJdIBLV?= =?us-ascii?q?lMqrK6Xt863KErEZqkoojaR8oFHZy5hq8cP3z1lQVDCOOmylyDtQA=3D=3D?= X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76954909" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 6/7] tools/ocaml/libs/xb: hide type of Xb.t Date: Fri, 29 Jul 2022 18:53:29 +0100 Message-ID: <74ab9ad3ed031654fbfc343f299cedba2ebe3ac9.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit The only user of 'xb' that I can find is in-tree oxenstored. Other code (e.g. xenopsd) would use the mirage 'xenstore' implementation instead, so changing the API here shouldn't require anyone to update their code. Hiding the type will make it easier to change the implementation in the future without breaking code that relies on it. No functional change. Signed-off-by: Edwin Török --- tools/ocaml/libs/xb/xb.ml | 3 +++ tools/ocaml/libs/xb/xb.mli | 9 ++------- tools/ocaml/xenstored/connection.ml | 8 ++------ 3 files changed, 7 insertions(+), 13 deletions(-) diff --git a/tools/ocaml/libs/xb/xb.ml b/tools/ocaml/libs/xb/xb.ml index 104d319d77..8404ddd8a6 100644 --- a/tools/ocaml/libs/xb/xb.ml +++ b/tools/ocaml/libs/xb/xb.ml @@ -196,6 +196,9 @@ let peek_output con = Queue.peek con.pkt_out let input_len con = Queue.length con.pkt_in let has_in_packet con = Queue.length con.pkt_in > 0 let get_in_packet con = Queue.pop con.pkt_in +let has_partial_input con = match con.partial_in with + | HaveHdr _ -> true + | NoHdr (n, _) -> n < Partial.header_size () let has_more_input con = match con.backend with | Fd _ -> false diff --git a/tools/ocaml/libs/xb/xb.mli b/tools/ocaml/libs/xb/xb.mli index 3a00da6cdd..794e35bb34 100644 --- a/tools/ocaml/libs/xb/xb.mli +++ b/tools/ocaml/libs/xb/xb.mli @@ -66,13 +66,7 @@ type backend_mmap = { type backend_fd = { fd : Unix.file_descr; } type backend = Fd of backend_fd | Xenmmap of backend_mmap type partial_buf = HaveHdr of Partial.pkt | NoHdr of int * bytes -type t = { - backend : backend; - pkt_in : Packet.t Queue.t; - pkt_out : Packet.t Queue.t; - mutable partial_in : partial_buf; - mutable partial_out : string; -} +type t val init_partial_in : unit -> partial_buf val reconnect : t -> unit val queue : t -> Packet.t -> unit @@ -97,6 +91,7 @@ val has_output : t -> bool val peek_output : t -> Packet.t val input_len : t -> int val has_in_packet : t -> bool +val has_partial_input : t -> bool val get_in_packet : t -> Packet.t val has_more_input : t -> bool val is_selectable : t -> bool diff --git a/tools/ocaml/xenstored/connection.ml b/tools/ocaml/xenstored/connection.ml index a94d47cdc2..0ce54cd7f9 100644 --- a/tools/ocaml/xenstored/connection.ml +++ b/tools/ocaml/xenstored/connection.ml @@ -125,9 +125,7 @@ let get_perm con = let set_target con target_domid = con.perm <- Perms.Connection.set_target (get_perm con) ~perms:[Perms.READ; Perms.WRITE] target_domid -let is_backend_mmap con = match con.xb.Xenbus.Xb.backend with - | Xenbus.Xb.Xenmmap _ -> true - | _ -> false +let is_backend_mmap con = Xenbus.Xb.is_mmap con.xb let send_reply con tid rid ty data = if (String.length data) > xenstore_payload_max && (is_backend_mmap con) then @@ -280,9 +278,7 @@ let get_transaction con tid = let do_input con = Xenbus.Xb.input con.xb let has_input con = Xenbus.Xb.has_in_packet con.xb -let has_partial_input con = match con.xb.Xenbus.Xb.partial_in with - | HaveHdr _ -> true - | NoHdr (n, _) -> n < Xenbus.Partial.header_size () +let has_partial_input con = Xenbus.Xb.has_partial_input con.xb let pop_in con = Xenbus.Xb.get_in_packet con.xb let has_more_input con = Xenbus.Xb.has_more_input con.xb -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377689.611007 (Exim 4.92) (envelope-from ) id 1oHUBj-0007Oy-Of; Fri, 29 Jul 2022 17:54:15 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377689.611007; Fri, 29 Jul 2022 17:54:15 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBj-0007Or-LD; Fri, 29 Jul 2022 17:54:15 +0000 Received: by outflank-mailman (input) for mailman id 377689; Fri, 29 Jul 2022 17:54:14 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBh-0006Zx-VL for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:14 +0000 Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 733f9859-0f67-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 19:54:12 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 733f9859-0f67-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117252; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jYUpkCH0YPQ/TyAwVFBI7seeyuP9yv7VtxJJX+EU6Zw=; b=UwsX1ru+o5XospM6vULUddGZvwBEKhvpxjj3oaDkhO+QoWYRX9jjGvf+ OFnTZQ3ILzlm/d6lyaWQl1juwc6W2bslk0Xoy0Y/4UNHUGnM9ygPqfND8 +lqyoLuZkR053whFQyst3FdPtwB3EquczPr2fttGOQojocwV8LMV0hGi1 A=; Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76956049 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:dplDyKnt940yuGSnS2O3BYbo5gylJkRdPkR7XQ2eYbSJt1+Wr1Gzt xIcXG/VOauCZGb1eNpyPd+y9BgA7Z6HmtA2GgJv+X9jFSMWpZLJC+rCIxarNUt+DCFioGGLT Sk6QoOdRCzhZiaE/n9BCpC48T8mk/ngqoPUUIbsIjp2SRJvVBAvgBdin/9RqoNziJ2yDhjlV ena+qUzA3f4nW8vWo4ow/jb8kk3466j4GlwUmEWPpingnePzxH5M7pHTU2BByOQapVZGOe8W 9HCwNmRlo8O105wYj8Nuu+TnnwiGtY+DyDX4pZlc/HKbix5jj4zys4G2M80Mi+7vdkrc+dZk 72hvbToIesg0zaldO41C3G0GAkmVUFKFSOuzdFSfqV/wmWfG0YAzcmCA2loIIBBpt1ZH1oT7 OdDL20oNj2J2duflefTpulE3qzPLeHuNYIb/Hph0SvYHbAtRpWrr6fivIECmm1q34YXQKiYN 5FxhTlHNXwsZzVCNkkWDtQim/2vhVH0ciFCqULTrq0yi4TW5FMvgeWzaIaEEjCMbcdcxkSzv mfDw0j4HRUmCeyczzuL21v504cjmgukAdlPRdVU7MVCn1m71mEVThoMWjOTo+S9i0O4c8JSL QoT4CVGhbMp6EWhQ935Xhu5iH2JpBgRX5xXCeJSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHvLSLRFqH+7yTrDf0PjIaRUcAbyIZSQoO4/H4vZo+yBnIS75e/LWd14OvX2uqm nbT8XZ41+57YdM3O7uTo03K2m6XiIbyExcuvQKKezqI5F1ATdvwD2C30mQ3/cqsPa7AEATQ5 CVVxpDPhAwdJcrTzXLQGY3hCJnsvq/Ya2OE3DaDCrF7r1yQF2ifkZe8Cd2UDGNgKY46dDDge yc/UisBtcYIbBNGgUKaCr9d6vjGLoC6TLwJrtiOMrJzjmFZLWdrBh1Ga0+KxHzKm0Mxi6w5M przWZ/yUCdCUv88nGbpHbh1PVoXKscWnDm7eHwG507/jer2iIC9Et/pz2dinshmtfjZ8W05A v5UNteQygU3bdASlhL/qNdLRXhXfCdTOHwDg5YIHgJ1ClY5RTpJ5j646e9JRrGJaIwPyr6Rr inmBhIwJZiWrSSvFDhmo0tLMNvHNauTZ1piVcDwFT5EA0QeXLs= IronPort-HdrOrdr: A9a23:iOGbU6uSE0DXcV/R07ZdsxEF7skDetV00zEX/kB9WHVpmszxra 6TdZMgpHjJYVcqKRUdcL+7WJVoLUmxyXcX2/h1AV7BZniEhILAFugLhuGO/9SJIVyZygc378 ZdmsZFZ+EYdWIK7/rH3A== X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76956049" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD , Andrew Cooper , George Dunlap , "Jan Beulich" , Julien Grall , "Stefano Stabellini" Subject: [PATCH v1 0/7] tools/ocaml code and build cleanups Date: Fri, 29 Jul 2022 18:53:23 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Various OCaml code cleanups to make building and working on Oxenstored easier, including compatibility with newer language versions. This does not yet change the minimum version of OCaml. A version of this series in a git repository is publicly available at: https://github.com/edwintorok/xen.git https://github.com/edwintorok/xen/compare/private/edvint/public?expand=1 Edwin Török (7): tools/ocaml/Makefile: do not run ocamldep during make clean tools/ocaml/*/Makefile: generate paths.ml from configure tools/ocaml/*/dune: dune based build system tools/ocaml: Makefile to drive dune tools/ocaml: fix compiler warnings tools/ocaml/libs/xb: hide type of Xb.t tools/ocaml/libs/eventchn: do not leak event channels and OCaml 5.0 compat Makefile | 5 ++ tools/.gitignore | 7 ++ tools/configure | 4 +- tools/configure.ac | 2 + tools/dune | 5 ++ tools/dune-project | 1 + tools/ocaml/Makefile.dune | 88 +++++++++++++++++++ tools/ocaml/Makefile.rules | 2 + tools/ocaml/dune-project | 27 ++++++ tools/ocaml/dune-workspace.dev.in | 2 + tools/ocaml/dune-workspace.in | 18 ++++ tools/ocaml/libs/eventchn/dune | 11 +++ tools/ocaml/libs/eventchn/xeneventchn_stubs.c | 29 +++++- tools/ocaml/libs/mmap/dune | 9 ++ tools/ocaml/libs/xb/dune | 10 +++ tools/ocaml/libs/xb/xb.ml | 3 + tools/ocaml/libs/xb/xb.mli | 9 +- tools/ocaml/libs/xc/dune | 16 ++++ tools/ocaml/libs/xs/Makefile | 5 -- tools/ocaml/libs/xs/dune | 15 ++++ tools/ocaml/libs/xs/paths.ml.in | 1 + tools/ocaml/xenstored/Makefile | 5 -- tools/ocaml/xenstored/connection.ml | 10 +-- tools/ocaml/xenstored/dune | 51 +++++++++++ tools/ocaml/xenstored/paths.ml.in | 4 + tools/ocaml/xenstored/process.ml | 5 +- 26 files changed, 315 insertions(+), 29 deletions(-) create mode 100644 tools/.gitignore create mode 100644 tools/dune create mode 100644 tools/dune-project create mode 100644 tools/ocaml/Makefile.dune create mode 100644 tools/ocaml/dune-project create mode 100644 tools/ocaml/dune-workspace.dev.in create mode 100644 tools/ocaml/dune-workspace.in create mode 100644 tools/ocaml/libs/eventchn/dune create mode 100644 tools/ocaml/libs/mmap/dune create mode 100644 tools/ocaml/libs/xb/dune create mode 100644 tools/ocaml/libs/xc/dune create mode 100644 tools/ocaml/libs/xs/dune create mode 100644 tools/ocaml/libs/xs/paths.ml.in create mode 100644 tools/ocaml/xenstored/dune create mode 100644 tools/ocaml/xenstored/paths.ml.in -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377691.611019 (Exim 4.92) (envelope-from ) id 1oHUBn-0007jt-2O; Fri, 29 Jul 2022 17:54:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377691.611019; Fri, 29 Jul 2022 17:54:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBm-0007jh-Uy; Fri, 29 Jul 2022 17:54:18 +0000 Received: by outflank-mailman (input) for mailman id 377691; Fri, 29 Jul 2022 17:54:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBl-0006a9-Bo for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:17 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 75963896-0f67-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 19:54:16 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 75963896-0f67-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117256; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RkbRUEdOWEaCHa9+/Ptg/amm9wD5Jpr8o1Ls9yYeJ4s=; b=gN5sn3moo+oRFf86iejqDq7FlUjbatC2OJyxQ1g0DRDlFXogVjcZB1ws pMj5OLQg39fqcGR0yHAiNuSSO2kJHKXPw6VgmyHi/Rcr/UjJGINKO1BKN eFj68MGpwU3v3KF6QoF71s3ZDl04OGDQs05d0cv6IY0buWEamcGJZliDT A=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 77388875 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:CWTGF6ooLySU/BLxNlG4Siz64opeBmJ7ZRIvgKrLsJaIsI4StFCzt garIBmBb/aPZWfzftgjbYSyp04G6sSDmIJnGQdppSk2EXgU+JuZCYyVIHmrMnLJJKUvbq7GA +byyDXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNPg06/gEk35q6q52lJ5gZWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU80PhLMGYV9 MdBLS4ucFOOiPKz4rmSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8aBIw/mqG0gWP4cBVTqU6PpLpx6G/WpOB0+Oeya4qFKoPXLSlTtkiZn Vr50UrDOCwXLNGW7TGI9ky8j/CayEsXX6pNTeblp5aGmma7ymUNBTUMWFC8oP3/jVSxM/pAL 2QE9yxoqrI9nGS7Q9+4UxCmrXqsuh8HR8EWA+A88BuKyKff/0CeHGdsc9JaQIV47olsH2Vsj wLX2YOybdByjFGLYVa36IulqmizAnEQM0wcJiILXQ4n6PC29enfkSnzosZf/L+d14OoSGmtk m3S/UDSlJ1I05dVivzTEUTvxmv1+8OXFlNdChD/BDrN0+9vWGKyi2VEA3D/5O0IEouWR0LpU JMsy5nHt7Bm4X1geUWwrAQx8FKBva/t3MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK514AvMQIZyv2MvUoC25UNyjN5fG6fekJq9iONoYeCnSPXFTvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUsn5VBc5GPvH481jO50rh3SMEuJGvgXOTz7jufFDJNUIJ9ZWGazghcRtv/d+VWNq IoCXyZIoj0GONDDjuDs2dZ7BTg3wbITXPgad+Q/mja/Hzdb IronPort-HdrOrdr: A9a23:BZPhpqzw6gv8Rot2yYapKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="77388875" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Christian Lindig , David Scott Subject: [PATCH v1 3/7] tools/ocaml/*/dune: dune based build system Date: Fri, 29 Jul 2022 18:53:26 +0100 Message-ID: <0f2c08734668626a618767680493a006827e123b.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Based on Christian Lindig's work. Initially this will be used to build unit tests, and to make development easier. Dune supports proper incremental builds and editor integration with merlin/LSP. For now the Makefile based build system is retained too: this is not a hard dependency on Dune. Using version 2.1 of Dune build language here, because that is the one available in Ubuntu Focal (part of the CI here). No functional change. Signed-off-by: Edwin Török --- tools/.gitignore | 7 +++++ tools/dune | 5 ++++ tools/dune-project | 1 + tools/ocaml/dune-project | 27 ++++++++++++++++++ tools/ocaml/libs/eventchn/dune | 11 ++++++++ tools/ocaml/libs/mmap/dune | 9 ++++++ tools/ocaml/libs/xb/dune | 10 +++++++ tools/ocaml/libs/xc/dune | 16 +++++++++++ tools/ocaml/libs/xs/dune | 15 ++++++++++ tools/ocaml/xenstored/dune | 51 ++++++++++++++++++++++++++++++++++ 10 files changed, 152 insertions(+) create mode 100644 tools/.gitignore create mode 100644 tools/dune create mode 100644 tools/dune-project create mode 100644 tools/ocaml/dune-project create mode 100644 tools/ocaml/libs/eventchn/dune create mode 100644 tools/ocaml/libs/mmap/dune create mode 100644 tools/ocaml/libs/xb/dune create mode 100644 tools/ocaml/libs/xc/dune create mode 100644 tools/ocaml/libs/xs/dune create mode 100644 tools/ocaml/xenstored/dune diff --git a/tools/.gitignore b/tools/.gitignore new file mode 100644 index 0000000000..c211749a3b --- /dev/null +++ b/tools/.gitignore @@ -0,0 +1,7 @@ +dune-workspace* +_build/ +.merlin +*.h.gch +*.opam +ocaml/*.install +include/_xentoolcore_list.h diff --git a/tools/dune b/tools/dune new file mode 100644 index 0000000000..febbd078f0 --- /dev/null +++ b/tools/dune @@ -0,0 +1,5 @@ +; only look inside ocaml and include subdirectory, speeds up the build +; since dune doesn't need to copy/hash/monitor all the other files +(dirs ocaml) + +(data_only_dirs include libs) diff --git a/tools/dune-project b/tools/dune-project new file mode 100644 index 0000000000..cd8d4e3d86 --- /dev/null +++ b/tools/dune-project @@ -0,0 +1 @@ +(lang dune 2.1) diff --git a/tools/ocaml/dune-project b/tools/ocaml/dune-project new file mode 100644 index 0000000000..1dae7b0acb --- /dev/null +++ b/tools/ocaml/dune-project @@ -0,0 +1,27 @@ +(lang dune 2.1) + +(name xen) + +(formatting (enabled_for dune)) +(generate_opam_files true) + +(maintainers christian.lindig@citrix.com) +(license LGPL) + +(package + (name xen) + (synopsis "Xen interfaces") + (depends + base-unix + (dune (>= 2.1)) + ) +) + +(package + (name xenstored) + (synopsis "In-memory key-value store for the Xen hypervisor") + (depends + base-unix + (dune (>= 2.1)) + ) +) diff --git a/tools/ocaml/libs/eventchn/dune b/tools/ocaml/libs/eventchn/dune new file mode 100644 index 0000000000..4468f2e769 --- /dev/null +++ b/tools/ocaml/libs/eventchn/dune @@ -0,0 +1,11 @@ +(library + (foreign_stubs + (language c) + (names xeneventchn_stubs) + (extra_deps ../../../include/xen/xen.h ../../../libs/evtchn/libxenevtchn.so) + (include_dirs ../../../include)) + (name xeneventchn) + (public_name xen.eventchn) + (libraries unix) + (no_dynlink) + (c_library_flags -lxenevtchn)) diff --git a/tools/ocaml/libs/mmap/dune b/tools/ocaml/libs/mmap/dune new file mode 100644 index 0000000000..57a8ab5b9b --- /dev/null +++ b/tools/ocaml/libs/mmap/dune @@ -0,0 +1,9 @@ +(library + (foreign_stubs + (language c) + (names xenmmap_stubs)) + (name xenmmap) + (public_name xen.mmap) + (libraries unix) + (no_dynlink) + (install_c_headers mmap_stubs)) diff --git a/tools/ocaml/libs/xb/dune b/tools/ocaml/libs/xb/dune new file mode 100644 index 0000000000..13a507ea87 --- /dev/null +++ b/tools/ocaml/libs/xb/dune @@ -0,0 +1,10 @@ +(library + (foreign_stubs + (language c) + (extra_deps ../../../include/xen/xen.h) + (include_dirs ../../../include) + (names xenbus_stubs xs_ring_stubs)) + (name xenbus) + (public_name xen.bus) + (no_dynlink) + (libraries unix xenmmap)) diff --git a/tools/ocaml/libs/xc/dune b/tools/ocaml/libs/xc/dune new file mode 100644 index 0000000000..6f9450cd27 --- /dev/null +++ b/tools/ocaml/libs/xc/dune @@ -0,0 +1,16 @@ +(rule + (with-stdout-to + xenctrl_abi_check.h + (run perl -w %{dep:abi-check} %{dep:xenctrl_stubs.c} %{dep:xenctrl.ml}))) + +(library + (foreign_stubs + (language c) + (names xenctrl_stubs) + (extra_deps ../../../include/xen/xen.h ../../../libs/ctrl/libxenctrl.so) + (include_dirs ../../../include)) + (name xenctrl) + (public_name xen.ctrl) + (libraries unix xenmmap) + (no_dynlink) + (c_library_flags -lxenctrl -lxenguest)) diff --git a/tools/ocaml/libs/xs/dune b/tools/ocaml/libs/xs/dune new file mode 100644 index 0000000000..086259f51d --- /dev/null +++ b/tools/ocaml/libs/xs/dune @@ -0,0 +1,15 @@ +; fallback mode: the files may have been generated by configure already + +(rule + (targets paths.ml) + (deps paths.ml.in) + (mode fallback) + (action + (run ../../../config.status --file=paths.ml))) + +(library + ; avoid conflict with mirage lib: name it differently + (name xenstore_xen) + (public_name xen.store) + (no_dynlink) + (libraries unix xenbus)) diff --git a/tools/ocaml/xenstored/dune b/tools/ocaml/xenstored/dune new file mode 100644 index 0000000000..d71decebcf --- /dev/null +++ b/tools/ocaml/xenstored/dune @@ -0,0 +1,51 @@ +; fallback mode: the files may have been generated by configure already +; also for fallback mode either all files must be present or none +; hence the 2 separate rules here + +(rule + (targets oxenstored.conf) + (deps oxenstored.conf.in) + (mode fallback) + (action + (run ../../config.status --file=oxenstored.conf))) + +(rule + (targets paths.ml) + (deps paths.ml.in) + (mode fallback) + (action + (run ../../config.status --file=paths.ml))) + +(executable + (modes native) + (name xenstored) + (modules + (:standard \ syslog systemd)) + (flags + (:standard -w -52)) + (libraries unix xen.bus xen.mmap xen.ctrl xen.eventchn xenstubs)) + +(install + (package xenstored) + (section sbin) + (files + (xenstored.exe as oxenstored))) + +(install + (package xen) + (section etc) + (files oxenstored.conf)) + +(library + (foreign_stubs + (language c) + (names syslog_stubs systemd_stubs select_stubs) + (extra_deps ../../dune-workspace) + (flags + (:standard -DHAVE_SYSTEMD))) + (modules syslog systemd) + (name xenstubs) + (wrapped false) + (libraries unix) + (no_dynlink) + (c_library_flags -lsystemd)) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377693.611030 (Exim 4.92) (envelope-from ) id 1oHUBu-0008DU-FL; Fri, 29 Jul 2022 17:54:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377693.611030; Fri, 29 Jul 2022 17:54:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBu-0008DC-BJ; Fri, 29 Jul 2022 17:54:26 +0000 Received: by outflank-mailman (input) for mailman id 377693; Fri, 29 Jul 2022 17:54:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBt-0006a9-GD for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:25 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 7a701b24-0f67-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 19:54:24 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7a701b24-0f67-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117264; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l4aF2ey7+PrEkwFig3yeefjykYcLjpth1sMCs1mC3pQ=; b=hvCsb+OGwybB2XLfpDxTsnZw5Glyyn1hIbF/W5fGiODNFapUFOhn+rI1 tPIqLvqR+KMVnAh1m4XsnLoPpZ0irDHDCUSbYoYrSvLtekRoWdx+S3BUs SBQ/+4g3n2drqq/+cWxJqmdOWaK35BT6aIdGN95ncytLunzmbidqzpW1P c=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 76740552 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:1AIS/aCp/oPIfBVW/0rjw5YqxClBgxIJ4kV8jS/XYbTApGh0gzcDn zYfXWyPPfnbMDHze40kPYS/p0gHu5XQmtNmQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E3ratANlFEkvYmQXL3wFeXYDS54QA5gWU8JhAlq3uU0meaEu/Dga++2k Y608pa31GONgWYuaDpLsfPb8nuDgdyp0N8mlg1mDRx0lAe2e0k9VPo3Oay3Jn3kdYhYdsbSq zHrlezREsvxpn/BO/v9+lrJWhRiro36ZGBivkF+Sam66iWukwRpukoN2FjwXm8M49mBt4gZJ NygLvVcQy9xVkHHsLx1vxW1j0iSlECJkVPKCSHXjCCd86HJWyL0xqVjU3oTBowd+dd9RlNcq t8qCz9YO3hvh8ruqF66Yuxlh8BlJ8j3JoIP/HpnyFk1D95/H8qFGf+To4YFgnFg3aiiHt6HD yYdQTdjchXGJQFIIFAUIJk/gP2plj/0dDgwRFe9+vRovzCOkVYZPL7FFor6IIGlbsNptByDh DyX4lu+EhtLHYnKodaC2i313bKe9c/hY6oNEJWo+/gsh0ecrkQfAQMbfUG2qv64jgi5Qd03A 1wZ/G8ioLY/8GSvT8LhRFuorXicpBkeVtFMVeog52mwJrH8uljDQDJeF3gYNYJg5JReqSEWO kGhxsvsVTEwi5iuSHeex73TnyHtGho2IjpXDcMbdjfp8+UPsalq0E+eFosyTfbk5jHmMWqum m7X9UDSk51W1JdWjPvjoDgrlhr2/vD0ohgJChI7t45Pxidwf8abaoOh8jA3Bt4Qfd/CHjFtU JXp8vVyDdzi7rnXzURhuM1XQNmUCw+taVUwe2JHEZg77CiK8HW+Z41W6zwWDB43b5dcImSyM BOM41w5CHpv0JyCNPUfXm5MI55ykfiI+SrNDZg4keaikrAuLVTarUmClGab3nz3kVhErJzTz ayzKJ/0ZV5HWPsP8dZDb71CuVPd7nxhmDi7qFGS50jP7Idyk1bPFe5cYAPVMr1RAWHtiFy9z uuz/vCik313ONASqAGNmWLPBTjm9UQGOK0= IronPort-HdrOrdr: A9a23:5Ree6KwmMzrgjpzpiRErKrPwFL1zdoMgy1knxilNoRw8SKKlfq eV7Y0mPH7P+VAssR4b+exoVJPtfZqYz+8R3WBzB8bEYOCFghrKEGgK1+KLqFeMJ8S9zJ846U 4JSdkHNDSaNzlHZKjBjzVQa+xQouW6zA== X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="76740552" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 1/7] tools/ocaml/Makefile: do not run ocamldep during make clean Date: Fri, 29 Jul 2022 18:53:24 +0100 Message-ID: <835ba84cf1fb7619fa6672d194aaf279795a5246.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Trying to include .ocamldep.make will cause it to be generated if it doesn't exist. We do not want this during make clean: we would remove it anyway. Speeds up make clean. Before (measured on f732240fd3bac25116151db5ddeb7203b62e85ce, July 2022): ``` Parsing /home/edwin/xen2/tools/ocaml/libs/xl/../../../../tools/libs/light/libxl_types.idl Parsing /home/edwin/xen2/tools/ocaml/libs/xl/../../../../tools/libs/light/libxl_types.idl Parsing /home/edwin/xen2/tools/ocaml/libs/xl/../../../../tools/libs/light/libxl_types.idl Parsing /home/edwin/xen2/tools/ocaml/libs/xl/../../../../tools/libs/light/libxl_types.idl Parsing /home/edwin/xen2/tools/ocaml/libs/xl/../../../../tools/libs/light/libxl_types.idl Performance counter stats for 'make clean -j8 -s' (5 runs): 4.2233 +- 0.0208 seconds time elapsed ( +- 0.49% ) ``` After: ``` perf stat -r 5 --null make clean -j8 -s Performance counter stats for 'make clean -j8 -s' (5 runs): 2.7325 +- 0.0138 seconds time elapsed ( +- 0.51% ) ``` No functional change. Signed-off-by: Edwin Török --- tools/ocaml/Makefile.rules | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/ocaml/Makefile.rules b/tools/ocaml/Makefile.rules index 7e4db457a1..d368308d9b 100644 --- a/tools/ocaml/Makefile.rules +++ b/tools/ocaml/Makefile.rules @@ -44,8 +44,10 @@ META: META.in ALL_OCAML_OBJ_SOURCES=$(addsuffix .ml, $(ALL_OCAML_OBJS)) +ifneq ($(MAKECMDGOALS),clean) .ocamldep.make: $(ALL_OCAML_OBJ_SOURCES) Makefile $(OCAML_TOPLEVEL)/Makefile.rules $(call quiet-command, $(OCAMLDEP) $(ALL_OCAML_OBJ_SOURCES) *.mli $o,MLDEP,) +endif clean: $(CLEAN_HOOKS) $(Q)rm -f .*.d *.o *.so *.a *.cmo *.cmi *.cma *.cmx *.cmxa *.annot *.spot *.spit $(LIBS) $(PROGRAMS) $(GENERATED_FILES) .ocamldep.make META -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:29 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:29 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377694.611041 (Exim 4.92) (envelope-from ) id 1oHUBw-0000B5-T8; Fri, 29 Jul 2022 17:54:28 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377694.611041; Fri, 29 Jul 2022 17:54:28 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBw-0000Ad-NR; Fri, 29 Jul 2022 17:54:28 +0000 Received: by outflank-mailman (input) for mailman id 377694; Fri, 29 Jul 2022 17:54:27 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBu-0006Zx-VN for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:27 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7ac7730c-0f67-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 19:54:25 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7ac7730c-0f67-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117265; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZFznG8baVkBRD0RFiw68lK6To7/I2LLnkXE/qkikiGI=; b=IbLSyBHZFq/3deZHRCWu+D5aONwlTXaGAPXLRFraEJTBi5P8JZ1hFW9+ VGww3rEStcdTrUOKa5R0yWsxF7JjOxIJopjPIn14V6pZfKa75L4wpeyJ/ mIFAdQ9mxKtQpVzJMuWmGwZV0/HbzKRXTHQnlChXyeHQRbkXoyR32DmYh w=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79518995 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:esanYaOzg4HxfsnvrR2Bl8FynXyQoLVcMsEvi/4bfWQNrUoq0TJTn DBNCDuOM/mPMzT0e4hybYS0/BgGvJ/Sm4JnTwto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMtPjS8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPH//RTMGMJPbER/8BlIkNB9 uQmLBASO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJiYArBZVtTPU0QC7o1nfuyh2m5eDpdwL6QjfVmvjGDnV0suFTrGIXNVuK4WeBcpAWdn F7p4FbbWio0LsPKnFJp9Vrz37SSzEsXQrk6FqC89/NsqE2ewCoUEhJ+fUS/iem0jAi5Qd03A 0Ad5CcGt6U5802vCN7nUHWQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3Oc0TzE30 l6Cn/vyGCdi9raSTBq17ayIpDm/PSwUK24qZiIeSwYBpd75r+kOYgnnF4g5VvTv15usRG+2k 2viQDUCa6s7pvIK6pmZwlD7ijeKtLvrQQ0t2AH3QTfwhu9mX7JJd7BE+HCCs6sRdNvIEwHQ1 JQXs5PAtb5TVPlhgATIGbxQR+/xup5pJRWG2TZS848dGyNBEpJJVaRZ+3lAKUhgKa7okhe5M RaI6Wu9CHK+VUZGjJObgKrrUqzGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhhZ MbDKp33XSpFU/sPIN+KqwA1iOVD+8zD7TmLGcCTI+qPitJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3CvZmPy53CbSmCgGKoNF7ELz/BSJkbXwAg5AIK7Xrz8sPMD1JNsI9Npt7J9U8z/wOyrqgE 7PUchYw9WcTTEbvcW2iAk2PopuzNXqjhRrX5RARAGs= IronPort-HdrOrdr: A9a23:ID6w9KvvymmH4rJE/dy/2VOu7skDTtV00zEX/kB9WHVpmszxra 6TdZMgpGbJYVcqKRcdcL+7WJVoLUmxyXcx2/h1AV7AZniAhILLFvAA0WKK+VSJcEeSygce79 YFT0EXMqyJMbEQt6fHCWeDfOrIuOP3kpyVuQ== X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="79518995" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Andrew Cooper" , George Dunlap , Jan Beulich , Julien Grall , "Stefano Stabellini" , Wei Liu , Christian Lindig , David Scott , Anthony PERARD Subject: [PATCH v1 4/7] tools/ocaml: Makefile to drive dune Date: Fri, 29 Jul 2022 18:53:27 +0100 Message-ID: <322ec0c9af480e9b8a6246d0a2cdb4e308a5900c.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit create a separate Makefile that can be used to drive dune. Usage: `make -f Makefile.dune` There are some files that need to be created by the Makefile based build system (such as all the C code in $(XEN_ROOT)/tools/libs), and those need to exist before dune runs. Although it'd be possible to automatically call the necessary makefile rules from dune, it wouldn't work reliably: * dune uses sandboxing by default (only files declared or known as dependencies are visible to individual build commands, symlinks/hardlinks are used by dune to implement this) * the dune builds always run in a _build subdir, and calling the makefiles from there would get the wrong XEN_ROOT set * running the make command in the source tree would work, but dune still wouldn't immediately see the build dependencies since they wouldn't have been copied/linked under _build The approach here is to: * use the Makefile to build C-only prerequisites (i.e. most of Xen) * use Dune only to build the OCaml parts once the C prerequisites exist * dune has dependencies declared on the C bits, so if they are missing you will get an error about a missing rule to create them instead of a cryptic compilation error * dune is still optional - the old Makefile based buildsystem is still there for now * use dune exclusively for new code going forward (e.g. OCaml test-suites) The workspace file needs to be generated by make because this currently cannot be generated by dune, and it doesn't support including external files. But could be generated by configure? LD_LIBRARY_PATH needs to be set, because even with -Wl,-rpath executables wouldn't be able to run using the just-built libraries, unless we'd also link all the transitive dependencies of libs. No functional change. Signed-off-by: Edwin Török --- Makefile | 5 ++ tools/ocaml/Makefile.dune | 88 +++++++++++++++++++++++++++++++ tools/ocaml/dune-workspace.dev.in | 2 + tools/ocaml/dune-workspace.in | 18 +++++++ 4 files changed, 113 insertions(+) create mode 100644 tools/ocaml/Makefile.dune create mode 100644 tools/ocaml/dune-workspace.dev.in create mode 100644 tools/ocaml/dune-workspace.in diff --git a/Makefile b/Makefile index b93b22c752..ddb33c3555 100644 --- a/Makefile +++ b/Makefile @@ -68,6 +68,11 @@ build-tools-oxenstored: build-tools-public-headers $(MAKE) -s -C tools/libs $(MAKE) -C tools/ocaml build-tools-oxenstored +.PHONY: build-tools-oxenstored-prepare +build-tools-oxenstored-prepare: build-tools-public-headers + test -f tools/config.status || (cd tools && ./configure --with-xenstored=oxenstored) + $(MAKE) -C tools/libs V= + .PHONY: build-stubdom build-stubdom: mini-os-dir build-tools-public-headers $(MAKE) -C stubdom build diff --git a/tools/ocaml/Makefile.dune b/tools/ocaml/Makefile.dune new file mode 100644 index 0000000000..eca9cac0ca --- /dev/null +++ b/tools/ocaml/Makefile.dune @@ -0,0 +1,88 @@ +XEN_ROOT = $(CURDIR)/../.. +all: dune-all-check + +# Dune by default uses all available CPUs. Make doesn't. +# Query the available CPUs and use all available for any of the make rules we call out to. +# -O is also needed with parallel make such that the build error and the build command causing +# the error are close together and not interspersed with other output +NPROC=$(shell getconf _NPROCESSORS_ONLN) +MAKEN=$(MAKE) -j$(NPROC) -O + +# We want to link and use the Xen libraries built locally +# without installing them system-wide +# (the system-wide one installed from packages will likely be too old and not match the locally +# built one anyway). +# +# Set LIBRARY_PATH and LD_LIBRARY_PATH so that the linker +# finds the proper libraries and the various dune commands +# work (e.g. running tests, utop, etc.). +# +# The Makefile based buildsystem would use -Wl,-rpath-link= here, +# but that only works during linking, not runtime. +# There is a -Wl, -rpath= that can be used, but that only works +# for libraries linked directly to the main executable: +# the dependencies of those libraries won't get found on the rpath +# (the rpath of the executable is apparently not used during that search). +# +# Use environment variables, because that way we don't make any permanent alternations (rpath) +# to the executable, so once installed system-wide it won't refer to build paths anymore. +# +# Dune cannot be used to generate this file: the env-vars stanza doesn't support %{read:}, :include, +# and dune-workspace doesn't support (include) stanzas. +# So for now generate it from this Makefile +# Cannot start with comment, so add auto-generated comment at the end +LIB_DIRS=$(abspath $(wildcard ../libs/*/.)) +LIBRARY_PATH=$(subst $(eval) ,:,$(LIB_DIRS)) +../dune-workspace ../dune-workspace.dev: dune-workspace.in dune-workspace.dev.in Makefile.dune + @( sed -e "s|@LIBRARY_PATH@|$(LIBRARY_PATH)|" <$< \ + && echo "; DO NOT EDIT: autogenerated from ocaml/dune-workspace.in") >../dune-workspace + @cat ../dune-workspace dune-workspace.dev.in >../dune-workspace.dev + +# for location of various libs which moves between Xen versions +include $(XEN_ROOT)/tools/Rules.mk + +XEN_DEPS=$(XEN_libxenctrl)/libxenctrl.so +XEN_DEPS+=$(XEN_libxenevtchn)/libxenevtchn.so +XEN_DEPS+=$(XEN_libxenguest)/libxenguest.so + +# Cannot be generated from dune +# Tell the user how to generate them +../include/xen/xen.h ../config.status $(XEN_DEPS): + echo "Missing C headers or libraries" >&2 + echo "Run make -C $(XEN_ROOT) build-tools-oxenstored-prepare -j$$(nproc)" >&2 + exit 1 + +# dune would refuse to run if there are build artifacts in the source directory +# if we detect anything then run make clean to ensure these are removed +# don't always call 'make clean' because it takes ~1.6s +.PHONY: dune-pre +dune-pre: ../config.status | ../include/xen/xen.h ../dune-workspace $(XEN_DEPS) + $(MAKEN) clean -s + +# Convenience targets +dune-syntax-check: dune-pre + dune build @check + +dune-all-check: dune-pre ../dune-workspace.dev + # Test build with multiple compiler versions + # requires opam switches for each to be already installed + dune build --workspace=../dune-workspace.dev @check @install @runtest + +check: dune-pre + dune runtest --no-buffer + +# approximatively equivalent to Dune 3.0 --release mode +dune-oxenstored: dune-pre + dune build --root .. --ignore-promoted-rules --no-config \ + --profile release --always-show-command-line \ + --promote-install-files --default-target @install + +-include $(XEN_ROOT)/config/Paths.mk + +# skip doc, it'd install an extra LICENSE file that is already installed by other rules +INSTALL_SECTIONS=bin,etc,lib,sbin +dune-install: dune-oxenstored + dune install --destdir=$(DESTDIR) --prefix=$(prefix) --libdir=$(shell ocamlfind printconf destdir) --mandir=$(mandir) --etcdir=$(sysconfdir) --docdir=$(docdir) --sections=$(INSTALL_SECTIONS) + +dune-uninstall: dune-oxenstored + dune uninstall --destdir=$(DESTDIR) --prefix=$(prefix) --libdir=$(shell ocamlfind printconf destdir) --mandir=$(mandir) --etcdir=$(sysconfdir) --docdir=$(docdir) diff --git a/tools/ocaml/dune-workspace.dev.in b/tools/ocaml/dune-workspace.dev.in new file mode 100644 index 0000000000..2ca831a048 --- /dev/null +++ b/tools/ocaml/dune-workspace.dev.in @@ -0,0 +1,2 @@ +(context default) +(context (opam (switch 4.02.3) (profile release))) diff --git a/tools/ocaml/dune-workspace.in b/tools/ocaml/dune-workspace.in new file mode 100644 index 0000000000..c963a6e599 --- /dev/null +++ b/tools/ocaml/dune-workspace.in @@ -0,0 +1,18 @@ +(lang dune 2.1) + +(env + ; we need to support older compilers so don't make deprecation warnings fatal + (dev + (flags (:standard -w -3)) + (env-vars + (LD_LIBRARY_PATH @LIBRARY_PATH@) + (LIBRARY_PATH @LIBRARY_PATH@) + )) + (release + (env-vars + (OCAMLRUNPARAM b) + (LD_LIBRARY_PATH @LIBRARY_PATH@) + (LIBRARY_PATH @LIBRARY_PATH@) + ) + (flags (:standard -strict-sequence -strict-formats -principal -w @18)) + (ocamlopt_flags -nodynlink))) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 17:54:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 17:54:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377699.611052 (Exim 4.92) (envelope-from ) id 1oHUBz-0000dw-9a; Fri, 29 Jul 2022 17:54:31 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377699.611052; Fri, 29 Jul 2022 17:54:31 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBz-0000dk-4Q; Fri, 29 Jul 2022 17:54:31 +0000 Received: by outflank-mailman (input) for mailman id 377699; Fri, 29 Jul 2022 17:54:29 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUBx-0006Zx-2b for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 17:54:29 +0000 Received: from esa4.hc3370-68.iphmx.com (esa4.hc3370-68.iphmx.com [216.71.155.144]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 7cbaafe1-0f67-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 19:54:27 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 7cbaafe1-0f67-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659117266; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Az58JwMLVZkj1Ei7e6Y6lR0AqnGVV5NLUNwkk9VU3V0=; b=Jlhn8u6gWPEbFHlsvTO0RPvDzp6QNPXdL6zm6eZwk0J5ottiP1UHxeQn kjmwQawzfVOWBHL+VmJg9PtADKFPrCZFZoo8mgystQDt9sNgeA0Ge3Ilo KLBduMmrFMfeuQCr8nLLVH4C7aNZqtSyWCYzrZfBYO/rls3Wt+tQJCDzj s=; Authentication-Results: esa4.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 79518996 X-Ironport-Server: esa4.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:S8MQZ6No38QbSrbvrR3Gl8FynXyQoLVcMsEvi/4bfWQNrUol0TYEz mZOWGmDPfaJNGb2fNp2OoXk9EMB6p7Rx9M1SQto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdleF+lH3dOCJQUBUjcmgXqD7BPPPJhd/TAplTDZJoR94kqsyj5UAbeKRWmthg vuv5ZyEULOZ82QsaDhMtPjS8EkHUMna41v0gHRvPZing3eG/5UlJMp3Db28KXL+Xr5VEoaSL woU5Ojklo9x105F5uKNyt4XQGVTKlLhFVHmZk5tc7qjmnB/Shkaic7XAha+hXB/0F1ll/gpo DlEWAfZpQ0BZsUgk8xFO/VU/r0X0QSrN9YrLFDm2fF/wXEqfFPH//RTMGMJPbER/8BlIkNB9 uQmLBASO0Xra+KemNpXS8Fpj8UnasLqIJkeqjdryjSx4fQOGM6ZBf+QvJkBgWl21psm8fX2P qL1bRJiYArBZVtTPU0QC7o1nfuyh2m5eDpdwL6QjfVmvjGDnV0vuFTrGOrIX/KQReJbp2K// Gb432HWAg0aDMPKnFJp9Vrz37SSzEsXQrk6C7mQ5vNsxlqJyQQ7BBQIWHOhrPK+i0r4XMhQQ 2QE9yxroaUs+UiDStjmQwb+sHOCpgQbWddbD6s98g7l90bPy1/HXC5eFGcHMYF48p9tLdA36 rOXt/jVBAFTkoKVdXuY0KW3jzyxIRYRDXBXMEfoUjA5D8nfTJAb10ySH44+QfPt37UZChmrn WnU8XFWa6E7yJdSiv7lpQ2vbyeE/MChc+Ij2unAsotJBCtdbZXtWYGn4EOzAR1ofNfAFQnpU JTpdqGjAAEy4XKlznXlrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJtVIWSyO x+P5lkOjHO2AJdNRfYtC79d9uxwlfSwfTgbfqu8giVyjmhZK1bcoXAGib+41GHxikk8+ZwC1 WOgWZ/1VR4yVPU4pAdass9HjtfHMAhimj6ILX06pjz7uYejiIm9E+tcaQvWNbxkhE5GyS2Mm +ti2wKx4003eIXDjuP/reb/8XhiwaAHOK3L IronPort-HdrOrdr: A9a23:oHPZ1qC5ABWX6+DlHemU55DYdb4zR+YMi2TC1yhKJyC9Ffbo7v xG/c5rsyMc5wxwZJhNo7y90ey7MBbhHP1OkO4s1NWZLWrbUQKTRekIh+bfKn/baknDH4ZmpN 9dmsNFaeEYY2IUsS+D2njbL+od X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="79518996" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , "Christian Lindig" , David Scott , Wei Liu , Anthony PERARD Subject: [PATCH v1 5/7] tools/ocaml: fix compiler warnings Date: Fri, 29 Jul 2022 18:53:28 +0100 Message-ID: <23dcc916bff25d0545c167833d99aa73b8a4c8da.1659116941.git.edvin.torok@citrix.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Fix compiler warning about: * unused value * ambiguous documentation comment * non-principal type inference (compiler version dependent) No functional change. Signed-off-by: Edwin Török --- tools/ocaml/xenstored/connection.ml | 2 +- tools/ocaml/xenstored/process.ml | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/ocaml/xenstored/connection.ml b/tools/ocaml/xenstored/connection.ml index 65f99ea6f2..a94d47cdc2 100644 --- a/tools/ocaml/xenstored/connection.ml +++ b/tools/ocaml/xenstored/connection.ml @@ -313,7 +313,7 @@ let is_bad con = match con.dom with None -> false | Some dom -> Domain.is_bad_do let has_extra_connection_data con = let has_in = has_input con || has_partial_input con in let has_out = has_output con in - let has_socket = con.dom = None in + let _has_socket = con.dom = None in let has_nondefault_perms = make_perm con.dom <> con.perm in has_in || has_out (* TODO: what about SIGTERM, should use systemd to store FDS diff --git a/tools/ocaml/xenstored/process.ml b/tools/ocaml/xenstored/process.ml index 27790d4a5c..86eed02413 100644 --- a/tools/ocaml/xenstored/process.ml +++ b/tools/ocaml/xenstored/process.ml @@ -59,7 +59,7 @@ let split_one_path data con = let process_watch t cons = let oldroot = t.Transaction.oldroot in - let newroot = Store.get_root t.store in + let newroot = Store.get_root t.Transaction.store in let ops = Transaction.get_paths t |> List.rev in let do_op_watch op cons = let recurse, oldroot, root = match (fst op) with @@ -491,7 +491,7 @@ let transaction_replay c t doms cons = ignore @@ Connection.end_transaction c tid None ) -let do_watch con t _domains cons data = +let do_watch con _t _domains cons data = let (node, token) = match (split None '\000' data) with | [node; token; ""] -> node, token @@ -651,6 +651,7 @@ let maybe_ignore_transaction = function let () = Printexc.record_backtrace true + (** * Nothrow guarantee. *) -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 18:11:40 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 18:11:40 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377743.611063 (Exim 4.92) (envelope-from ) id 1oHUST-0005Aa-SX; Fri, 29 Jul 2022 18:11:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377743.611063; Fri, 29 Jul 2022 18:11:33 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUST-0005AT-Oa; Fri, 29 Jul 2022 18:11:33 +0000 Received: by outflank-mailman (input) for mailman id 377743; Fri, 29 Jul 2022 18:11:32 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHUSS-0005AN-Q2 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 18:11:32 +0000 Received: from esa1.hc3370-68.iphmx.com (esa1.hc3370-68.iphmx.com [216.71.145.142]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dce3f90b-0f69-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 20:11:31 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dce3f90b-0f69-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1659118291; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=fbnyQbuVinN9b4ozPR7RGmkrCgeSjUTEZSqSwPVZFkw=; b=fYEvUK97P9qx3GB3fnHdk0x721XgxPXyvOm5hVQbScbEx4KUdu/ewk5B sopnP5/KSTAuEKIgP9Y6ifseY8jXh76tvG69MQLkn2VSX1HLqZdDtqfS1 Y0pw3nuW7G48m2fvelW4W3dCuqCLb6bKUGYMstyva2BsxIM48PctJ8t9h M=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none X-SBRS: 2.7 X-MesageID: 77390064 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:0Si6WK0EnHs4uULhWfbD5YNxkn2cJEfYwER7XKvMYLTBsI5bp2QBx jNLCzyOaPzfN2Dzet1/aIvlp0xXuMTRxtRnHQVlpC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkjk7xdOKn9RGQ7InQLpLkEunIJyttcgFtTSYlmHpLlvUwx4VlmrBVOSvU0 T/Ji5CZaQTNNwJcaDpOsfrc8kI35pwehRtD1rAATaET1LPhvyF94KI3fcmZM3b+S49IKe+2L 86rIGaRpz6xE78FU7tJo56jGqE4aue60Tum0xK6b5OKkBlazhHe545gXBYqheW7vB3S9zx54 I0lWZVd0m7FNIWU8AgWe0Ew/y2TocSqUVIISJSymZX78qHIT5fj669jKFM0LI4Zw8w0BlwTr vARLm0tYjnW0opawJrjIgVtrsEqLc2tN4IDoHBwizreCJ7KQ7iaHf+Mv4UBmm5t2IYeRp4yZ OJAAdZrRBnMfRxJfEsQEpU9tOypmmP+Y3tTr1f9Sa8fvDeInVQpjuSF3Nz9cc7JXN97gB+km VnZxkLZBD0jDsK+8G/Qmp6rrrCWxn6qMG4IL5Wn8tZ6jVvVwXYcYDUGWF3+rfSnh0qWX9NEN 1dS6icotbI19kGgUp/6RRLQnZKflkdCAZwKSbR8sVzTjPqPi+qEOoQaZmRMTM4kpcw3fBZp0 WLUxN/gA2FPvJTAHBpx6YyoQSOO1Tk9dDFfNHdZHFZdsrEPs6lo0EuRE48L/Lqdy4SsRGqum 23iQD0W3e17sCId60msEbkraRqIr4OBcAM67x6/somNvlIgP97Ni2BFBDHmARd8wGWxFADpU IAswZT20Qz3JcjleNaxaOsMBqq1wP2OLSfRh1Vid7F4qWn8oyX4JtAMv2shTKuMDirjUWazC HI/RCsLvMMDVJdURfQfj32N5zQCkvG7SIWNugH8ZdtSeJlhHDK6ENVVTRfJhwjFzRlz+ZzTz L/BLq5A+15GVvk8pNd3Ls9BuYIWKtcWnz+KHMCjlEj6uVdcDVbMIYo43JK1RrhRxMu5TM/9r r6z6+PiJ81jbdDD IronPort-HdrOrdr: A9a23:z27dQK4mr3S8gzXnXQPXwMTXdLJyesId70hD6qhwISY6TiX+rb HIoB17726RtN9/YhEdcLy7VJVoIkmskKKdg7NhXotKNTOO0ADDQb2KhbGSpQEIcBeeygcy78 hdmtBFeb/NMWQ= X-IronPort-AV: E=Sophos;i="5.93,201,1654574400"; d="scan'208";a="77390064" From: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= To: CC: =?UTF-8?q?Edwin=20T=C3=B6r=C3=B6k?= , Wei Liu , Anthony PERARD , Christian Lindig Subject: [RFC PATCH] tools/configure: require OCaml >= 4.06.1 for oxenstored Date: Fri, 29 Jul 2022 19:10:44 +0100 Message-ID: X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit OCaml 4.06.1 is widely available in distributions: https://repology.org/project/ocaml/versions oxenstored already includes some compatibility code to be able to run on versions older than 4.06, however this is slightly less efficient than just using the new features in 4.06 standard library: https://lore.kernel.org/xen-devel/b94cd2ad099486678609909e12b045c54abb2f27.camel@citrix.com/ The OCaml version in stubdom/ is unchanged for now as it is unclear how this used. Typically to run OCaml code as a stubdom one would use the mirage tooling to build a unikernel, which handles cross-compilation using Dune. The unikernel itself also uses Solo5 instead of MiniOS, so the OCaml code in stubdom/ is probably stale. Signed-off-by: Edwin Török Cc: Christian Lindig --- tools/configure | 2 +- tools/configure.ac | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/configure b/tools/configure index 41deb7fb96..8f391e2da4 100755 --- a/tools/configure +++ b/tools/configure @@ -6765,7 +6765,7 @@ else -e 's/[^0-9]//g'` - ax_compare_version_B=`echo "4.02.0" | sed -e 's/\([0-9]*\)/Z\1Z/g' \ + ax_compare_version_B=`echo "4.06.1" | sed -e 's/\([0-9]*\)/Z\1Z/g' \ -e 's/Z\([0-9]\)Z/Z0\1Z/g' \ -e 's/Z\([0-9][0-9]\)Z/Z0\1Z/g' \ -e 's/Z\([0-9][0-9][0-9]\)Z/Z0\1Z/g' \ diff --git a/tools/configure.ac b/tools/configure.ac index 32cbe6bd3c..7518199ec8 100644 --- a/tools/configure.ac +++ b/tools/configure.ac @@ -310,7 +310,7 @@ AS_IF([test "x$ocamltools" = "xy"], [ AC_MSG_ERROR([Ocaml tools enabled, but missing ocamlopt or ocamlfind])]) ocamltools="n" ], [ - AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [4.02.0], [ + AX_COMPARE_VERSION([$OCAMLVERSION], [lt], [4.06.1], [ AS_IF([test "x$enable_ocamltools" = "xyes"], [ AC_MSG_ERROR([Your version of OCaml: $OCAMLVERSION is not supported])]) ocamltools="n" -- 2.34.1 From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:18:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:18:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377838.611110 (Exim 4.92) (envelope-from ) id 1oHXMh-0003G8-Dd; Fri, 29 Jul 2022 21:17:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377838.611110; Fri, 29 Jul 2022 21:17:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXMh-0003G1-AP; Fri, 29 Jul 2022 21:17:47 +0000 Received: by outflank-mailman (input) for mailman id 377838; Fri, 29 Jul 2022 21:17:46 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXMg-0003Fr-8D; Fri, 29 Jul 2022 21:17:46 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXMg-0003Ty-40; Fri, 29 Jul 2022 21:17:46 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXMf-0002a1-Ni; Fri, 29 Jul 2022 21:17:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHXMf-0007QK-NC; Fri, 29 Jul 2022 21:17:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vwUfTkQ4kb3C8JeGfGS8JiB3yNPc+sHBMloP7X/OVUQ=; b=tQtYOnCAnuY5eN7i/CH+NbjU0P Eugh5svMDH5x7EngMR9u2W5h79FA/XbnJ6KSfJOrJhZ9ufOkEh59XfpBJReZxIUBYfX3mYtNWAA2t U7+Y0wU5IEiODUr47oacahWdnGiBVoB6JNo20uvtV63hu/o4zoR9PcXHeaf7qZaJFLAw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171916: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6e2c0490769ef8a95b61304389116ccc85c53e12 X-Osstest-Versions-That: linux=6e7765cb477a9753670d4351d14de93f1e9dbbd4 From: osstest service owner Date: Fri, 29 Jul 2022 21:17:45 +0000 flight 171916 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171916/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171891 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171891 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171891 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171891 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171891 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171891 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171891 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171891 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 6e2c0490769ef8a95b61304389116ccc85c53e12 baseline version: linux 6e7765cb477a9753670d4351d14de93f1e9dbbd4 Last test of basis 171891 2022-07-28 00:42:47 Z 1 days Failing since 171901 2022-07-28 20:11:14 Z 1 days 2 attempts Testing same since 171916 2022-07-29 06:34:59 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Abhishek Pandit-Subedi Alejandro Lucero Anirudh Venkataramanan Benjamin Poirier Christophe JAILLET Dan Carpenter Dave Airlie Dave Switzer David Howells David S. Miller Dawid Lukwinski Dimitris Michailidis Dimitris Michailidis Duoming Zhou Eric Dumazet Florian Westphal George Kuruvinakunnel Gurucharan (A Contingent worker at Intel) Hangbin Liu Jakub Kicinski Jason Wang Jedrzej Jagielski Jianglei Nie John Harrison Jonathan Lemon Kalle Valo Kuniyuki Iwashima Lee Jones Leonard Crestez Liang He Linus Torvalds Luiz Augusto von Dentz Maciej Fijalkowski Marcelo Ricardo Leitner Marek Szlosek Mat Martineau Mateusz Palczewski Maxim Mikityanskiy Michael S. Tsirkin Michal Maloszewski Neal Cardwell Nikolay Aleksandrov Pablo Neira Ayuso Paolo Abeni Przemyslaw Patynowski Rob Herring Sabrina Dubroca Simon Horman Slark Xiao Subbaraya Sundeep Sunil Goutham Sylwester Dziedziuch syzbot Taehee Yoo Tetsuo Handa Toke Høiland-Jørgensen Tony Nguyen Tvrtko Ursulin Tvrtko Ursulin Umesh Nerlige Ramappa Vadim Fedorenko Vladimir Oltean Wei Wang Xin Long Ziyang Xuan jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6e7765cb477a..6e2c0490769e 6e2c0490769ef8a95b61304389116ccc85c53e12 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:21:01 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:21:01 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377842.611120 (Exim 4.92) (envelope-from ) id 1oHXPo-0004cz-Sa; Fri, 29 Jul 2022 21:21:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377842.611120; Fri, 29 Jul 2022 21:21:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXPo-0004cs-Pd; Fri, 29 Jul 2022 21:21:00 +0000 Received: by outflank-mailman (input) for mailman id 377842; Fri, 29 Jul 2022 21:20:59 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXPn-0004ci-J1; Fri, 29 Jul 2022 21:20:59 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXPn-0003Y6-GX; Fri, 29 Jul 2022 21:20:59 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXPn-0002i6-3v; Fri, 29 Jul 2022 21:20:59 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHXPn-0008BE-3S; Fri, 29 Jul 2022 21:20:59 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=lbfS3w6AgcHF+1n5IhimMmjevbXFt0AXuGz8irhpkNQ=; b=xXYKOHrXHEM/srL0PDGeZcAq7O KcIhluh6S3YqNYpIwWandQKwqT1AhfjvsWqpsDqsULkAFJUczR9HwigLxgxBHjtCAXqJh5MDzRQIZ qtTnpb/BLQ/dsNqxjUSJ2wx+gkho5Wu52kw/Hi4snHTeSgUkovgFLfb4uaJXJmyVts3M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171928: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=062790aca6b1faea62c9ed2737c3791efb0d0f4c X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Fri, 29 Jul 2022 21:20:59 +0000 flight 171928 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171928/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 062790aca6b1faea62c9ed2737c3791efb0d0f4c baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 7 attempts Testing same since 171917 2022-07-29 10:03:07 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 062790aca6b1faea62c9ed2737c3791efb0d0f4c Author: Xenia Ragiadakou Date: Fri Jul 29 08:51:31 2022 +0200 arm/atomic: fix MISRA C 2012 Rule 20.7 violation The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit 124f138b37d595294b3100349e26ffb3f1df7b13 Author: Xenia Ragiadakou Date: Fri Jul 29 08:50:58 2022 +0200 xsm/dummy: fix MISRA C 2012 Directive 4.10 violation Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu Acked-by: Daniel P. Smith commit 9ff3231f955cee4d62c7be6a03d061c037d7ca69 Author: Jan Beulich Date: Fri Jul 29 08:50:25 2022 +0200 x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Now that we're not building multi.c anymore for 2 and 3 guest levels when !HVM, there's no point in having these conditionals anymore. (As somewhat a special case, the last of the removed conditionals really builds on shadow_mode_external() always returning false when !HVM.) This way the code becomes a tiny bit more readable. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 5b04fe78646a8222626996113c9d1e598cb84831 Author: Jan Beulich Date: Fri Jul 29 08:49:48 2022 +0200 x86/shadow: don't open-code shadow_remove_all_shadows() Let's use the existing inline wrapper instead of repeating respective commentary at every site. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 8a3b89e4307da260675483bb86fc06cc62ed7c08 Author: Jan Beulich Date: Fri Jul 29 08:49:06 2022 +0200 x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM In my (debug) build this amounts to well over 500 bytes of dead code. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 3629759626ac7201a670a8a2d4d4a536e7443575 Author: Jan Beulich Date: Fri Jul 29 08:48:26 2022 +0200 x86/shadow: properly handle get_page() failing We should not blindly (in a release build) insert the new entry in the hash if a reference to the guest page cannot be obtained, or else an excess reference would be put when removing the hash entry again. Crash the domain in that case instead. The sole caller doesn't further care about the state of the guest page: All it does is return the corresponding shadow page (which was obtained successfully before) to its caller. To compensate we further need to adjust hash removal: Since the shadow page already has had its backlink set, domain cleanup code would try to destroy the shadow, and hence still cause a put_page() without corresponding get_page(). Leverage that the failed get_page() leads to no hash insertion, making shadow_hash_delete() no longer assume it will find the requested entry. Instead return back whether the entry was found. This way delete_shadow_status() can avoid calling put_page() in the problem scenario. For the other caller of shadow_hash_delete() simply reinstate the otherwise dropped assertion at the call site. While touching the conditionals in {set,delete}_shadow_status() anyway, also switch around their two pre-existing parts, to have the cheap one first (frequently allowing to avoid evaluation of the expensive - due to evaluate_nospec() - one altogether). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:49:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:49:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377856.611131 (Exim 4.92) (envelope-from ) id 1oHXqu-0007nb-7V; Fri, 29 Jul 2022 21:49:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377856.611131; Fri, 29 Jul 2022 21:49:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXqu-0007nU-4V; Fri, 29 Jul 2022 21:49:00 +0000 Received: by outflank-mailman (input) for mailman id 377856; Fri, 29 Jul 2022 21:48:59 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXqt-0007nJ-97 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 21:48:59 +0000 Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [2607:f8b0:4864:20::e2b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 3e714c65-0f88-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 23:48:56 +0200 (CEST) Received: by mail-vs1-xe2b.google.com with SMTP id b67so5863797vsc.1; Fri, 29 Jul 2022 14:48:56 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 3e714c65-0f88-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=02+K6rwnRB4x16TS0dlwTtTDongDR9b82S5EJ//EKXQ=; b=l80fQSzVYdgBhL6QkkIaUComDaUTeKYiVDzLpbLTueT4ymtEcRMfzfYCEssNGnkCa5 h380plIaOTv+UECAiiehXZ2RHivcsWtqcYfuCaRz3JZ2P8E9OKEehz1u5JjndpfUlCBf KemPQVko3hYalrt6JKsvDPTWPB5u41z1E2PxYI6f/qhKe0RD+JH7eT1MdbB0AGES3k0M NmSVdH5W1VvONNOTZQOGUsWWXdjKVDeGi4qsNSIe3Vs3P7jSaFSoKj1lgRGX3KWEP3nO xtY2+yp6vsmCndeZGtAP03wqi1ojZipwBPeg10PHooI/H591a+RDIcxFgLf2uc4F3MMR 89nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=02+K6rwnRB4x16TS0dlwTtTDongDR9b82S5EJ//EKXQ=; b=s2s8DR2UjgIQs5c8qryz6frfHpIte/SfaHEim/k8OrretVRXTunrNmpzts7JgID6yC xMP42hBIJtIfBNKmIa9p8o6BVKDGZHITG542+QI+kZ1BSN/ERq5irGp9Ub/nVBaHuezJ soSQqniV1bZQOSAhWye7eVyQaMniz1Ryqk3c7LiGkdBETvC1OphrgIoc9YwEmE8N/eXK Cp9oMVoDIq+uIk7vnzA7dZ6sA2xiBMnuuKBf2AGvO8pS55EiT+nFxj99MgJOq/4cRGzs zN8JWBHDI9cOM4TuYL/ivdpVUDKftevM6cFCBOp6+w6/7KeMaPGJ1wuXCzlpEvGq4zQJ 15+g== X-Gm-Message-State: AJIora/p2EI9Bp6lPdffYyV6Z4AngFyXw9aHWoUJLJJ/ObKKKISx28pA 31zB+GtMXWQu1kyAGWnFnNMdzaUtrc2Qjy09Niw= X-Google-Smtp-Source: AGRyM1veHob3c6vsZYUUO3YaVmp2nFfHSEjWdi1JkYR1Zsqp2xZTxrAsU32D/6x1vFwZfJXydwUpBDbPz3FDPR/E6VA= X-Received: by 2002:a05:6102:18b:b0:358:5905:c107 with SMTP id r11-20020a056102018b00b003585905c107mr2280650vsq.84.1659131335131; Fri, 29 Jul 2022 14:48:55 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Christopher Clark Date: Fri, 29 Jul 2022 14:48:44 -0700 Message-ID: Subject: Re: Enable audio virtualization in Xen To: "SHARMA, JYOTIRMOY" Cc: "xen-devel@lists.xenproject.org" , "xen-users@lists.xenproject.org" , Daniel Smith , Stefano Stabellini Content-Type: text/plain; charset="UTF-8" On Thu, Jul 28, 2022 at 1:37 PM Christopher Clark wrote: > > On Thu, Jul 28, 2022 at 12:05 PM SHARMA, JYOTIRMOY > wrote: > > > > [AMD Official Use Only - General] > > > > Hi all, > > > > Can anyone please help here? Hello again, I have now been able to enable HVM guest audio using the Xen PV audio front end device drivers that are included in Ubuntu 22.04. The steps: - remove the qemu wrapper script from my previous email, if you have installed it, and restore the original qemu-system-i386 binary - keep the pulseaudio system configuration from my previous email, so that tools that run as the root user are able to talk to the desktop host pulseaudio system - add a vsnd device to the guest VM configuration file, in this case using pulseaudio for output: vsnd = [[ 'card, backend=Domain-0, buffer-size=65536, short-name=VCard, long-name=Virtual sound card, sample-rates=48000, sample-formats=s16_le', 'pcm, name=dev1', 'stream, unique-id=pulse, type=P' ]] - download, build and run the backend audio tool in the host dom0. For the backend you'll need to download and build first libxenbe and then snd_be from: https://github.com/xen-troops/libxenbe https://github.com/xen-troops/snd_be Once you have the snd_be binary built, you can run it as root thus before starting your guest VM: ./snd_be -v *:Debug and then the guest audio output should be working OK. I have not explored using ALSA rather than pulseaudio yet. Christopher From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:51:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:51:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377862.611143 (Exim 4.92) (envelope-from ) id 1oHXt2-0000jw-LZ; Fri, 29 Jul 2022 21:51:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377862.611143; Fri, 29 Jul 2022 21:51:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXt2-0000jp-Id; Fri, 29 Jul 2022 21:51:12 +0000 Received: by outflank-mailman (input) for mailman id 377862; Fri, 29 Jul 2022 21:51:12 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXt2-0000jh-0I for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 21:51:12 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8e59736b-0f88-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 23:51:10 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C8D6B829BD; Fri, 29 Jul 2022 21:51:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BB80C433C1; Fri, 29 Jul 2022 21:51:07 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8e59736b-0f88-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659131468; bh=uXj1dutMGgKN6p36vmGkamno7p685JlvjZgVhe4jxoY=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=fcjtE7u8nYtj2sCQKPSJJI7JiYkchFL/sDw/RstV/5bXq4PpwdRg6UvO0MDVGk8Fu oE6P1axDXpIfX3/cBZ977kSpZW7TvyUt/ETh8vXxgow5HptPsounK5aZgo66gMeLA/ VB9IjXp5ODBJBYwEArvoHehENfAKJyyWw95J9MBuh4F06eRp0/FJ/7qPMk2KIShzw7 9fn5DWnTowSkKnw6sNuCxgKjuET6H92BIIBCboCAuguCRLqQe0V8+74F/hZt6KRTc5 VCekTk57mcCX2HHZ1y3rmsxBQd+jbDohI1wDz/JHj1NEm0BN7qpNkwhFbRrdZRdCbz y+2kAkGos8vXA== Date: Fri, 29 Jul 2022 14:51:05 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Boyoun Park cc: "xen-devel@lists.xenproject.org" , Stefano Stabellini , Jan Beulich , "julien@xen.org" , "bertrand.marquis@arm.com" , "Volodymyr_Babchuk@epam.com" , "andrew.cooper3@citrix.com" , "george.dunlap@citrix.com" , "wl@xen.org" , "roger.pau@citrix.com" , Chungwoo Park , Gang Li , Lei Wang , SoungKwan Kimn , DongJin PARK , Joonjae Lee Subject: Re: [PATCH v1] xen: add late init call in start_xen In-Reply-To: <20220729110313epcms2p5f9b24d5a65b98c220a6e99675298560f@epcms2p5> Message-ID: References: <97499212.9948800.1659000157467@mail-kr2-3> <88025800-66e2-4fb4-facf-5989e75ba08f@suse.com> <20220729110313epcms2p5f9b24d5a65b98c220a6e99675298560f@epcms2p5> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323329-2013376029-1659131467=:4648" This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323329-2013376029-1659131467=:4648 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 29 Jul 2022, Boyoun Park wrote: > I really appreciate all the comments and reviews. > I understand that it is hard to add this patch without any usage. > > On Fri, 29 Jul 2022, Stefano Stabellini: > > On Thu, 28 Jul 2022, Jan Beulich wrote: > > > On 28.07.2022 11:22, Boyoun Park wrote: > > > > Hello, > > > >  > > > > This patch added late_initcall to deal with > > > >  > > > > some init functions which should be called > > > >  > > > > after other init functions in start_xen. > > > >  > > > > If this patch is added, > > > >  > > > > then the original initcall in xen will be treated > > > >  > > > > as early_initcall and the late_initcall > > > >  > > > > which is added by this patch will be > > > >  > > > > called sequentially. > > > >  > > > > I cannot send patches through git send-email > > > >  > > > > due to some security issues in my work. > > > >  > > > > So intead, I just send the patches manually. > > >  > > > Which is fine, but you want to configure your mail client such that it > > > doesn't mangle the patch. Albeit I see that to cover for that at least > > > you've also attached both the patch and a cover letter. For a single > > > patch a cover letter can normally be omitted, but if you don't then > > > even if you're sending without "git send-email" you will want to send > > > both as separate mails, with the patch being a reply to the cover > > > letter thread root. > >  > > Yeah. Boyoun, if you only have a couple of patches then it is fine to > > send them manually. Otherwise, if you have many patches, you can send > > them in attachment as tarball and I'll send them all to xen-devel using > > git-send-email for you (of course keeping you as original author and > > retaining all Signed-off-bys). > > You're awesome. Thanks you so much. I'm still requesting approvals to use git send-email. > I'll let you know if I have to send many patches wihout git send-email. > > > > > Subject: [PATCH v1] xen: add late init call in start_xen > > > >  > > > > This patch added late_initcall section in init.data. > > > >  > > > > The late initcall would be called after initcall > > > >  > > > > in the start_xen function. > > > >  > > > > Some initializing works on priority should be run > > > >  > > > > in do_initcalls and other non-prioritized works > > > >  > > > > would be run in do_late_initcalls. > > > >  > > > > To call some functions by late_initcall, > > > >  > > > > then it is possible by using > > > >  > > > > __late_initcall(/*Function Name*/); > > > >  > > > > Signed-off-by: Boyoun Park  > > >  > > > So I could imagine this patch to be in a series where a subsequent > > > patch then adds an actual use of the new functionality. Without > > > that what you're proposing is to add dead code. > >  > > Yeah, I think it would be cool to have late initcalls but it makes sense > > to add them if we have someone that makes use of them. > > I totally agree with your comments. Some drivers that I'm developing now and use this function are specific to my hardware environment. > Thus, it seems difficult to arrange them in the near future. > I will update patches if I can suggest an actual use. I totally understand custom setups and non-upstreamable configurations and I have certainly some of them myself. However, I just wanted to let you know that we are fine with accepting platform specific drivers in Xen where it makes sense, for instance: - Renesas IPMMU-VMSA found in R-Car Gen3/Gen4 SoCs (an IOMMU driver) xen/drivers/passthrough/arm/ipmmu-vmsa.c - Xilinx EEMI firmware interface "mediator" in Xen (power management) xen/arch/arm/platforms/xilinx-zynqmp-eemi.c Cheers, Stefano --8323329-2013376029-1659131467=:4648-- From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:53:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:53:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377868.611154 (Exim 4.92) (envelope-from ) id 1oHXva-0001LE-3p; Fri, 29 Jul 2022 21:53:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377868.611154; Fri, 29 Jul 2022 21:53:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXva-0001L7-12; Fri, 29 Jul 2022 21:53:50 +0000 Received: by outflank-mailman (input) for mailman id 377868; Fri, 29 Jul 2022 21:53:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXvY-0001L1-P0 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 21:53:48 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXvT-000459-Ss; Fri, 29 Jul 2022 21:53:43 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHXvT-0004KU-Mt; Fri, 29 Jul 2022 21:53:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=BCA0y1weyRIq79mO4Dv43/KSclJqDmErh7Si8sAyLNo=; b=flepE9ala46oljY3vQ5G1vb/JK NJdtmu1jqZzhAeXTMcwJE66JhC7kxerSegjTCwQb1hxKjThNbD8oIHToOnxEU/FOlR72tyHmbCtQF dAjisKECL7sF1zcl466DpJ2l0d5ccviaM/qCf/mt3QRVQJwgSnjfhfgvJZDGzNUM00IU=; Message-ID: <59433009-26de-4bac-d7cd-c57e64171262@xen.org> Date: Fri, 29 Jul 2022 22:53:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... To: Jan Beulich Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-4-julien@xen.org> <414dcf57-b18f-8a88-b143-e275b5311079@suse.com> From: Julien Grall In-Reply-To: <414dcf57-b18f-8a88-b143-e275b5311079@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jan, On 25/07/2022 16:51, Jan Beulich wrote: > On 20.07.2022 20:44, Julien Grall wrote: >> From: Julien Grall >> >> move it to Kconfig. >> >> The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide >> helpers to map/unmap a domain page. Rename it to the define to >> CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove >> support for domain page (this is not a concept that Xen can't get >> away with). > > Especially the part in parentheses reads odd, if not backwards. Indeed. I tweaked the sentence to: Rename it to CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that support for domain page is not something that can be disabled in Xen. > >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -371,7 +371,7 @@ void clear_fixmap(unsigned int map) >> BUG_ON(res != 0); >> } >> >> -#ifdef CONFIG_DOMAIN_PAGE >> +#ifdef CONFIG_ARCH_MAP_DOMAIN_PAGE >> /* >> * Prepare the area that will be used to map domheap pages. They are >> * mapped in 2MB chunks, so we need to allocate the page-tables up to > > What about the other #ifdef in build_assertions()? With that also > converted (and preferably with the description adjusted) Good catch. I update the patch. > Reviewed-by: Jan Beulich Thanks for the review! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:54:28 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:54:28 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377874.611165 (Exim 4.92) (envelope-from ) id 1oHXw9-0001sk-C6; Fri, 29 Jul 2022 21:54:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377874.611165; Fri, 29 Jul 2022 21:54:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXw9-0001sd-99; Fri, 29 Jul 2022 21:54:25 +0000 Received: by outflank-mailman (input) for mailman id 377874; Fri, 29 Jul 2022 21:54:23 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXw7-0001sR-Ir for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 21:54:23 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXw6-000465-L1; Fri, 29 Jul 2022 21:54:22 +0000 Received: from gw1.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHXw6-0004LZ-Fz; Fri, 29 Jul 2022 21:54:22 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=vbpHLn6XCaVz2EkJDP3/OTuNWpvyNe9yKehAmdUInbE=; b=SkFhbsuCFwupZXy/XYqfpahHUv B/2Yt+yw3TMUpi10Ul1M3FTQ7JrX3ZMbGRcXJHKeAC/5bx3ZbKZjf1UBAL5honCdeqLk9r+XK3oO+ B2m+a+pHljlDMrCkrmjEQExtvQ4k8CKYF1J/8dEOoQaTJ/y4IB51BxqDk/UJnsLgFChQ=; Message-ID: Date: Fri, 29 Jul 2022 22:54:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 3/5] xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... To: Bertrand Marquis Cc: xen-devel , Julien Grall , Stefano Stabellini , Volodymyr Babchuk , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220720184459.51582-1-julien@xen.org> <20220720184459.51582-4-julien@xen.org> <36782478-2EF8-45C6-A1CC-1E299704F33B@arm.com> From: Julien Grall In-Reply-To: <36782478-2EF8-45C6-A1CC-1E299704F33B@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 21/07/2022 09:40, Bertrand Marquis wrote: > Hi Julien, Hi Bertrand, >> On 20 Jul 2022, at 19:44, Julien Grall wrote: >> >> From: Julien Grall >> >> move it to Kconfig. >> >> The define CONFIG_DOMAIN_PAGE indicates whether the architecture provide >> helpers to map/unmap a domain page. Rename it to the define to > > Maybe “the define to” can be removed in this sentence or it needs some rephrasing. I have removed "the define to". > >> CONFIG_ARCH_MAP_DOMAIN_PAGE so it is clearer that this will not remove >> support for domain page (this is not a concept that Xen can't get >> away with). >> >> Take the opportunity to move CONFIG_MAP_DOMAIN_PAGE to Kconfig as this >> will soon be necessary to use it in the Makefile. >> >> Signed-off-by: Julien Grall > > With this fixed: > Reviewed-by: Bertrand Marquis #arm part Thanks! Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 21:57:22 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 21:57:22 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377881.611176 (Exim 4.92) (envelope-from ) id 1oHXyz-0002ln-Rg; Fri, 29 Jul 2022 21:57:21 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377881.611176; Fri, 29 Jul 2022 21:57:21 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXyz-0002lg-NH; Fri, 29 Jul 2022 21:57:21 +0000 Received: by outflank-mailman (input) for mailman id 377881; Fri, 29 Jul 2022 21:57:20 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXyy-0002lW-3P; Fri, 29 Jul 2022 21:57:20 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXyy-0004Am-2U; Fri, 29 Jul 2022 21:57:20 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHXyx-00042j-Ls; Fri, 29 Jul 2022 21:57:19 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHXyx-0007Ij-LM; Fri, 29 Jul 2022 21:57:19 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=1ur2yIiNNACfKUxxZtzfU8wlsxaJy5e1MgczKg5BRu4=; b=RKOpAxDQZ2tZEtuuezT0OTbWjl UqFOR//tAfsOzDWejvIz/WWwGKoDGv3aIumn4wjex2mAjdku9Vz2CmuZnZDm5xrygu7YNRi31gKON G0bxQlyFS0qc+/uQjncWFyFTRa/WWdbd2gN0nFEAJKgNSxLPR/qmDTlheQYxWU7j4NbU=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 171929: all pass - PUSHED X-Osstest-Versions-This: ovmf=e9150618ec91f79e70a1719ac8c198bee34a99be X-Osstest-Versions-That: ovmf=0d0bfcb4571caa65b7875003f38e67e2ac7e5560 From: osstest service owner Date: Fri, 29 Jul 2022 21:57:19 +0000 flight 171929 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/171929/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf e9150618ec91f79e70a1719ac8c198bee34a99be baseline version: ovmf 0d0bfcb4571caa65b7875003f38e67e2ac7e5560 Last test of basis 171913 2022-07-29 03:12:41 Z 0 days Testing same since 171929 2022-07-29 19:42:00 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Sami Mujawar jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git 0d0bfcb457..e9150618ec e9150618ec91f79e70a1719ac8c198bee34a99be -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Fri Jul 29 22:04:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 22:04:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377889.611187 (Exim 4.92) (envelope-from ) id 1oHY64-0004DY-L4; Fri, 29 Jul 2022 22:04:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377889.611187; Fri, 29 Jul 2022 22:04:40 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHY64-0004DR-H5; Fri, 29 Jul 2022 22:04:40 +0000 Received: by outflank-mailman (input) for mailman id 377889; Fri, 29 Jul 2022 22:04:39 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHY63-0004DL-AN for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 22:04:39 +0000 Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHY62-0004J4-Kr; Fri, 29 Jul 2022 22:04:38 +0000 Received: from home.octic.net ([81.187.162.82] helo=[10.0.1.102]) by xenbits.xenproject.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1oHY62-00058i-Ej; Fri, 29 Jul 2022 22:04:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xen.org; s=20200302mail; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID; bh=WNivob6JPiZKteOJLG1omPhtziu4YGyRpbIwIMHuJlQ=; b=32KQ5Fre7cIDCtgvUMI/4kn77Q TtskerEz8ZL5C+1GhML79StfjuvRKuys3xe7ZWNTS4t8EcmbFRpuLkCmbB8Pz9fQq9X3SpPLZL2FV ADl1duTNhc7TaNw+HGB4FqUVON3iZwmU0E0aURYmn0I6AULEKYo7Vmbgb/gOs4EtbfMw=; Message-ID: <921d6948-c379-bba4-444e-c7b1f35926bc@xen.org> Date: Fri, 29 Jul 2022 23:04:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 0/5] xen/arm: mm: Bunch of clean-ups To: xen-devel@lists.xenproject.org Cc: Julien Grall , Stefano Stabellini , Bertrand Marquis , Volodymyr Babchuk , Konrad Rzeszutek Wilk , Ross Lagerwall , Andrew Cooper , George Dunlap , Jan Beulich , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= References: <20220720184459.51582-1-julien@xen.org> From: Julien Grall In-Reply-To: <20220720184459.51582-1-julien@xen.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 20/07/2022 19:44, Julien Grall wrote: > From: Julien Grall > > Hi all, > > This series is a collection of patches to clean-up the MM subsystem > I have done in preparation for the next revision of "xen/arm: Don't > switch TTBR while the MMU is on" [1]. > > Cheers, > > [1] https://lore.kernel.org/all/20220309112048.17377-1-julien@xen.org/ > > Julien Grall (5): > xen/arm: Remove most of the *_VIRT_END defines > xen/arm32: mm: Consolidate the domheap mappings initialization > xen: Rename CONFIG_DOMAIN_PAGE to CONFIG_ARCH_MAP_DOMAIN_PAGE and... > xen/arm: mm: Move domain_{,un}map_* helpers in a separate file > xen/arm: mm: Reduce the area that xen_second covers I have committed this series. Cheers, -- Julien Grall From xen-devel-bounces@lists.xenproject.org Fri Jul 29 23:19:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 23:19:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377909.611221 (Exim 4.92) (envelope-from ) id 1oHZFj-0004hA-4B; Fri, 29 Jul 2022 23:18:43 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377909.611221; Fri, 29 Jul 2022 23:18:43 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZFj-0004h3-1N; Fri, 29 Jul 2022 23:18:43 +0000 Received: by outflank-mailman (input) for mailman id 377909; Fri, 29 Jul 2022 23:18:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZFh-0004gx-M1 for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 23:18:41 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id c6dd01bd-0f94-11ed-924f-1f966e50362f; Sat, 30 Jul 2022 01:18:38 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2266B82A03; Fri, 29 Jul 2022 23:18:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48E83C433D6; Fri, 29 Jul 2022 23:18:36 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c6dd01bd-0f94-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659136716; bh=jtHLFyKfdY3ue4JKCqia6DITjvTxcpbDfVaMgahK0Rc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=dNFlC95rvD91Z50yrvdNWRyg97GHA2chnwy2vqqFs4F6pA6nTYA5io4X+i1R/jqop Ht9S0NRvd6EVRmtanHspu8xDCucfGKAHVxG3lnDI7upfMockgaOGA53+p2eu2GpyI6 3cVMUXv3LTY25Htq1rQHczk6JOK1L//Jwvcg0jw17ZHLDNolmsUTnv3QC6QARLQMcs n5OpsPVgkZ4T6LGwuSPhM89qsXwNm+k7/46XT9NxYNB7tjSnBnHX7Os4mIvofgmcPC 5yrqA18OYIts18IvEOdjEFrx4YmUDLy3S65OeQkc2sPzcF7nSA+BJcmZ4uv0Fn8Rw7 bO6xo2Qj6NmVA== Date: Fri, 29 Jul 2022 16:18:34 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 1/3] automation: qemu-smoke-arm64.sh: Remove some stale comments In-Reply-To: <20220729145229.1250221-2-burzalodowa@gmail.com> Message-ID: References: <20220729145229.1250221-1-burzalodowa@gmail.com> <20220729145229.1250221-2-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 29 Jul 2022, Xenia Ragiadakou wrote: > Remove comment "# Install QEMU" because qemu is not installed, it is taken > from a test-artifacts container. > > Change comment "# Busybox Dom0" to "# Busybox" because busybox is not used > only for the Dom0 but also for the DomU. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > automation/scripts/qemu-smoke-arm64.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 898398196a..f483a2ffc1 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -21,7 +21,6 @@ fi > " > fi > > -# Install QEMU > export DEBIAN_FRONTENT=noninteractive > apt-get -qy update > apt-get -qy install --no-install-recommends u-boot-qemu \ > @@ -44,7 +43,7 @@ sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb > > > -# Busybox Dom0 > +# Busybox > mkdir -p initrd > mkdir -p initrd/bin > mkdir -p initrd/sbin > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Jul 29 23:24:21 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 23:24:21 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377916.611232 (Exim 4.92) (envelope-from ) id 1oHZL7-0006A5-RI; Fri, 29 Jul 2022 23:24:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377916.611232; Fri, 29 Jul 2022 23:24:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZL7-00069y-OL; Fri, 29 Jul 2022 23:24:17 +0000 Received: by outflank-mailman (input) for mailman id 377916; Fri, 29 Jul 2022 23:24:16 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZL6-00069c-4k for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 23:24:16 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 8f74e413-0f95-11ed-924f-1f966e50362f; Sat, 30 Jul 2022 01:24:15 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 76D02B82A02; Fri, 29 Jul 2022 23:24:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1900C433D6; Fri, 29 Jul 2022 23:24:12 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 8f74e413-0f95-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659137053; bh=691hN3/qyo2rTRY0Mum+QKzj4Fw/7Q3um4iGth0kZLE=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=mXaLIBUwpGL1WQFfFa6mOdkxUtV/y/iATDlGJDm6WMTtILVQd9eVY9TRzNDdQA+Dk WVeTYkNr4J6V01v1C1bIW3CNJ4JhVgpbuo8R5QQ1QljL8C+j/X8h6qVAlOAHmArVYA 90+OAWn2uL54EslX+J9SjZemLLbdaD8XmxByiA7xo5PRGqsaHlh0UP+z2zymjYSNOu DXdNiUUjxpAP1RfufN9wu2x8y1n18KQ5xIVzwl/G4ZvNVWCb+oxJVWHDexlq8x2woj knYcCGZtHrAYg9yhR5r1Oq+Shi2UWWNfY1JtGAea6eBZoBXqNB1uahkJZ2RizGjMJ7 8TPMZhM73Srbw== Date: Fri, 29 Jul 2022 16:24:11 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 2/3] automation: qemu-smoke-arm64.sh: Rename the device tree to avoid confusion In-Reply-To: <20220729145229.1250221-3-burzalodowa@gmail.com> Message-ID: References: <20220729145229.1250221-1-burzalodowa@gmail.com> <20220729145229.1250221-3-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 29 Jul 2022, Xenia Ragiadakou wrote: > Rename the device tree from virt-gicv3 to virt-gicv2 to avoid confusion > since the version of the generic interrupt controller used for this test > is the v2 and not the v3. > > Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini > --- > automation/scripts/qemu-smoke-arm64.sh | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index f483a2ffc1..7ac82b2278 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -36,11 +36,11 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > -m 1024 -display none \ > - -machine dumpdtb=binaries/virt-gicv3.dtb > + -machine dumpdtb=binaries/virt-gicv2.dtb > # XXX disable pl061 to avoid Linux crash > -dtc -I dtb -O dts binaries/virt-gicv3.dtb > binaries/virt-gicv3.dts > -sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv3.dts > binaries/virt-gicv3-edited.dts > -dtc -I dts -O dtb binaries/virt-gicv3-edited.dts > binaries/virt-gicv3.dtb > +dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > +sed 's/compatible = "arm,pl061.*/status = "disabled";/g' binaries/virt-gicv2.dts > binaries/virt-gicv2-edited.dts > +dtc -I dts -O dtb binaries/virt-gicv2-edited.dts > binaries/virt-gicv2.dtb > > > # Busybox > @@ -73,7 +73,7 @@ cd .. > echo 'MEMORY_START="0x40000000" > MEMORY_END="0x80000000" > > -DEVICE_TREE="virt-gicv3.dtb" > +DEVICE_TREE="virt-gicv2.dtb" > XEN="xen" > DOM0_KERNEL="Image" > DOM0_RAMDISK="initrd" > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Fri Jul 29 23:25:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Fri, 29 Jul 2022 23:25:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377921.611243 (Exim 4.92) (envelope-from ) id 1oHZLz-0006hX-4O; Fri, 29 Jul 2022 23:25:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377921.611243; Fri, 29 Jul 2022 23:25:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZLz-0006hQ-1M; Fri, 29 Jul 2022 23:25:11 +0000 Received: by outflank-mailman (input) for mailman id 377921; Fri, 29 Jul 2022 23:25:09 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHZLx-0006hA-NV for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 23:25:09 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id aebb4240-0f95-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 01:25:08 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C9B5D6141C; Fri, 29 Jul 2022 23:25:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFE60C433C1; Fri, 29 Jul 2022 23:25:05 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: aebb4240-0f95-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659137106; bh=cT5zqBNc4VM3cWXiuqFmKVxZ/n4R7LwEFBBf1Emoa3c=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=bud8hCc9X7EI1SFxQNWpQgMlX/saxu8V9C+ZCnE086mqAEO1pBToLWwCptthv7VGL DhydcZ61lDnypp2CgXJh+VJFyOXJlxTn6oEbdGNK2r0CQjsk6U/eTslDR/C6vzLwyG pc8R677JyLnhA8g4+3aQBwZIZMWoxAgf5xFy0Ugn8j3GZBt2+xPy0yLqZGfTmOdOmg x3OA3kjXfGJlpsuPnprpO0sWWrJAst76HUiC7TCY3o7tDR491EBa9xBqN1vMgror/l USc1ksxxZWsZtBpSqrntRqfiPzSoDJC+vrFe9l8p7lDyli7Xy3v/79PnG1syhtP1j6 tJSRJV/kZY7ig== Date: Fri, 29 Jul 2022 16:25:04 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: Xenia Ragiadakou cc: xen-devel@lists.xenproject.org, Doug Goldstein , Stefano Stabellini Subject: Re: [PATCH 3/3] automation: qemu-smoke-arm64.sh: Fix the number of cpus in the device tree In-Reply-To: <20220729145229.1250221-4-burzalodowa@gmail.com> Message-ID: References: <20220729145229.1250221-1-burzalodowa@gmail.com> <20220729145229.1250221-4-burzalodowa@gmail.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Fri, 29 Jul 2022, Xenia Ragiadakou wrote: > Qemu VM is configured with 2 cpus but the device tree passed has only 1. > Generate a device tree with 2 cpus. > > Signed-off-by: Xenia Ragiadakou > --- > I am not sure for this patch because I do not know whether the number of cpus > differs deliberately. Yes let's go with 2 Reviewed-by: Stefano Stabellini > automation/scripts/qemu-smoke-arm64.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/automation/scripts/qemu-smoke-arm64.sh b/automation/scripts/qemu-smoke-arm64.sh > index 7ac82b2278..b48a20988f 100755 > --- a/automation/scripts/qemu-smoke-arm64.sh > +++ b/automation/scripts/qemu-smoke-arm64.sh > @@ -35,7 +35,7 @@ curl -fsSLO https://github.com/qemu/qemu/raw/v5.2.0/pc-bios/efi-virtio.rom > ./binaries/qemu-system-aarch64 \ > -machine virtualization=true \ > -cpu cortex-a57 -machine type=virt \ > - -m 1024 -display none \ > + -m 1024 -smp 2 -display none \ > -machine dumpdtb=binaries/virt-gicv2.dtb > # XXX disable pl061 to avoid Linux crash > dtc -I dtb -O dts binaries/virt-gicv2.dtb > binaries/virt-gicv2.dts > -- > 2.34.1 > From xen-devel-bounces@lists.xenproject.org Sat Jul 30 00:40:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 00:40:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377933.611267 (Exim 4.92) (envelope-from ) id 1oHaWy-0008Rl-BM; Sat, 30 Jul 2022 00:40:36 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377933.611267; Sat, 30 Jul 2022 00:40:36 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHaWy-0008Re-8B; Sat, 30 Jul 2022 00:40:36 +0000 Received: by outflank-mailman (input) for mailman id 377933; Sat, 30 Jul 2022 00:40:34 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHaWw-0008RU-O8; Sat, 30 Jul 2022 00:40:34 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHaWw-0007eI-LD; Sat, 30 Jul 2022 00:40:34 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHaWw-0003Vg-7Q; Sat, 30 Jul 2022 00:40:34 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHaWw-0000OO-6v; Sat, 30 Jul 2022 00:40:34 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=to+d5PpUupfaOYB6G5/TM+BKGD64Iy1/mK0GzhNQHKI=; b=xI/RJcfaSUQoHgtGF92Re5oOGl 7kpILCp8YdnipnNZUM5vJnaBSrqlQBa/sU6dkAQLFfeLBJqCtMgUoe9Y0ieCG/MYUEGwo2J/JQaPF bl/BEskPIMu/HS3r5YMYZIN0BJL3AxjsWWEvQRkPp0hB/GDpBvyAMFa/mQ9ZBjU2mN0o=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-5.4 test] 171923: tolerable FAIL - PUSHED X-Osstest-Failures: linux-5.4:test-armhf-armhf-xl-credit2:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-rtds:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-xl-credit1:guest-start:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-5.4:test-armhf-armhf-xl-vhd:guest-start:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking linux-5.4:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-5.4:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-5.4:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-5.4:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=77ba2b9b46f8acead2606759e8196b7076eaeeea X-Osstest-Versions-That: linux=002c3bbb4713859e8f3d1e756637572a09dcca49 From: osstest service owner Date: Sat, 30 Jul 2022 00:40:34 +0000 flight 171923 linux-5.4 real [real] http://logs.test-lab.xenproject.org/osstest/logs/171923/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 14 guest-start fail like 171846 test-armhf-armhf-xl-rtds 14 guest-start fail like 171846 test-armhf-armhf-xl-credit1 14 guest-start fail like 171846 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171846 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171846 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171846 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171846 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171846 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171846 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171846 test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171846 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171846 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171846 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171846 test-armhf-armhf-xl-vhd 13 guest-start fail like 171846 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171846 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 77ba2b9b46f8acead2606759e8196b7076eaeeea baseline version: linux 002c3bbb4713859e8f3d1e756637572a09dcca49 Last test of basis 171846 2022-07-24 18:41:18 Z 5 days Testing same since 171923 2022-07-29 15:42:06 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Al Viro Alexander Aring Andrew Morton Bartosz Golaszewski Ben Dooks Borislav Petkov Carl Vanderlip Daniel Borkmann David S. Miller David Teigland Dawid Lukwinski Demi Marie Obenour Dexuan Cui Eric Dumazet Eric Snowberg Fabien Dessenne Florian Fainelli Greg Kroah-Hartman Guenter Roeck GUO Zihua Haibo Chen Hangyu Hua Hanjun Guo Hristo Venev Ido Schimmel Ingo Molnar Jakub Kicinski Jan Beulich Jan Glauber Jan Sokolowski Jeffrey Hugo Jesse Brandeburg Jiri Slaby Jon Hunter Jose Alonso Juergen Gross Junxiao Chang Kees Cook Konrad Jankowski Kuniyuki Iwashima Lennert Buytenhek Lennert Buytenhek Linus Torvalds Linus Walleij Linux Kernel Functional Testing Luiz Augusto von Dentz Marc Kleine-Budde Marcel Holtmann Marek Szlosek Mark Brown Miaoqian Lin Michael Kelley Michal Simek Michel Lespinasse Mimi Zohar Naama Meir Pali Rohár Palmer Dabbelt Paolo Abeni Paolo Bonzini Paul Menzel (Nokia N9 (MeeGo/Harmattan) Peter Zijlstra (Intel) Peter Zijlstra Piotr Skajewski Przemyslaw Patynowski Robert Hancock Sasha Levin Sasha Neftin Sean Christopherson Sebastian Reichel Shuah Khan Steffen Klassert Sudip Mukherjee Takashi Iwai Tariq Toukan Tedd Ho-Jeong An Thomas Gleixner Tony Nguyen Wang Cheng Wei Liu Will Deacon William Dean Wolfram Sang Yang Jihong Yuchung Cheng jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 fail test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds fail test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd fail test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 002c3bbb4713..77ba2b9b46f8 77ba2b9b46f8acead2606759e8196b7076eaeeea -> tested/linux-5.4 From xen-devel-bounces@lists.xenproject.org Sat Jul 30 01:07:25 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 01:07:25 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377951.611278 (Exim 4.92) (envelope-from ) id 1oHawn-0001HZ-Mi; Sat, 30 Jul 2022 01:07:17 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377951.611278; Sat, 30 Jul 2022 01:07:17 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHawn-0001HS-JO; Sat, 30 Jul 2022 01:07:17 +0000 Received: by outflank-mailman (input) for mailman id 377951; Sat, 30 Jul 2022 01:07:16 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHawm-0001HI-5H; Sat, 30 Jul 2022 01:07:16 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHawm-0006Qo-1g; Sat, 30 Jul 2022 01:07:16 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHawl-0004AN-QW; Sat, 30 Jul 2022 01:07:15 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHawl-0003Ay-Py; Sat, 30 Jul 2022 01:07:15 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=UhteFSL3AFqU3ztmdBM9vKnZ1NkjBB8f6JvysQxoAGM=; b=ogJWDuqRIb8eVkFOOJEjlBI223 92WIKQZT/dfrHcj3wr4TTHvA5HRznKY1Cpvxm9K8Ebi+lI6NvtvsVOroatXBSrCIt9DUke0iA3GQt bgUELhkAud+OlKqJRYkuJ+BVa/akcqZ1H7bNFRoJDT39anr54BVfmTBnGDKmHlKmW9Bc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171932: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=062790aca6b1faea62c9ed2737c3791efb0d0f4c X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 01:07:15 +0000 flight 171932 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171932/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 062790aca6b1faea62c9ed2737c3791efb0d0f4c baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 8 attempts Testing same since 171917 2022-07-29 10:03:07 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. ------------------------------------------------------------ commit 062790aca6b1faea62c9ed2737c3791efb0d0f4c Author: Xenia Ragiadakou Date: Fri Jul 29 08:51:31 2022 +0200 arm/atomic: fix MISRA C 2012 Rule 20.7 violation The macro parameter 'p' is used as an expression and needs to be enclosed in parentheses. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit 124f138b37d595294b3100349e26ffb3f1df7b13 Author: Xenia Ragiadakou Date: Fri Jul 29 08:50:58 2022 +0200 xsm/dummy: fix MISRA C 2012 Directive 4.10 violation Protect header file from being included more than once by adding ifndef guard. Signed-off-by: Xenia Ragiadakou Reviewed-by: Luca Fancellu Acked-by: Daniel P. Smith commit 9ff3231f955cee4d62c7be6a03d061c037d7ca69 Author: Jan Beulich Date: Fri Jul 29 08:50:25 2022 +0200 x86/shadow: drop CONFIG_HVM conditionals from sh_update_cr3() Now that we're not building multi.c anymore for 2 and 3 guest levels when !HVM, there's no point in having these conditionals anymore. (As somewhat a special case, the last of the removed conditionals really builds on shadow_mode_external() always returning false when !HVM.) This way the code becomes a tiny bit more readable. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 5b04fe78646a8222626996113c9d1e598cb84831 Author: Jan Beulich Date: Fri Jul 29 08:49:48 2022 +0200 x86/shadow: don't open-code shadow_remove_all_shadows() Let's use the existing inline wrapper instead of repeating respective commentary at every site. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 8a3b89e4307da260675483bb86fc06cc62ed7c08 Author: Jan Beulich Date: Fri Jul 29 08:49:06 2022 +0200 x86/shadow: exclude HVM-only code from sh_remove_shadows() when !HVM In my (debug) build this amounts to well over 500 bytes of dead code. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper commit 3629759626ac7201a670a8a2d4d4a536e7443575 Author: Jan Beulich Date: Fri Jul 29 08:48:26 2022 +0200 x86/shadow: properly handle get_page() failing We should not blindly (in a release build) insert the new entry in the hash if a reference to the guest page cannot be obtained, or else an excess reference would be put when removing the hash entry again. Crash the domain in that case instead. The sole caller doesn't further care about the state of the guest page: All it does is return the corresponding shadow page (which was obtained successfully before) to its caller. To compensate we further need to adjust hash removal: Since the shadow page already has had its backlink set, domain cleanup code would try to destroy the shadow, and hence still cause a put_page() without corresponding get_page(). Leverage that the failed get_page() leads to no hash insertion, making shadow_hash_delete() no longer assume it will find the requested entry. Instead return back whether the entry was found. This way delete_shadow_status() can avoid calling put_page() in the problem scenario. For the other caller of shadow_hash_delete() simply reinstate the otherwise dropped assertion at the call site. While touching the conditionals in {set,delete}_shadow_status() anyway, also switch around their two pre-existing parts, to have the cheap one first (frequently allowing to avoid evaluation of the expensive - due to evaluate_nospec() - one altogether). Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper commit 108e6f282d2c2b8442ac9e1487e6fd7865cd6ede Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:56 2022 +0300 automation: arm64: Create a test job for testing static allocation on qemu Enable CONFIG_STATIC_MEMORY in the existing arm64 build. Create a new test job, called qemu-smoke-arm64-gcc-staticmem. Adjust qemu-smoke-arm64.sh script to accomodate the static memory test as a new test variant. The test variant is determined based on the first argument passed to the script. For testing static memory, the argument is 'static-mem'. The test configures DOM1 with a static memory region and adds a check in the init script. The check consists in comparing the contents of the /proc/device-tree memory entry with the static memory range with which DOM1 was configured. If the memory layout is correct, a message gets printed by DOM1. At the end of the qemu run, the script searches for the specific message in the logs and fails if not found. Signed-off-by: Xenia Ragiadakou Signed-off-by: Stefano Stabellini Reviewed-by: Penny Zheng Reviewed-by: Stefano Stabellini commit 37339ba9ef46cf55e077ca50235279f058b01779 Author: Xenia Ragiadakou Date: Thu Jul 28 10:58:55 2022 +0300 automation: Remove XEN_CONFIG_EXPERT leftovers The EXPERT config option cannot anymore be selected via the environmental variable XEN_CONFIG_EXPERT. Remove stale references to XEN_CONFIG_EXPERT from the automation code. Signed-off-by: Xenia Ragiadakou Reviewed-by: Stefano Stabellini commit ca45d3cb4586372909f350e54482246f994e1bc7 Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:26 2022 +0300 libxl/arm: Create specific IOMMU node to be referred by virtio-mmio device Reuse generic IOMMU device tree bindings to communicate Xen specific information for the virtio devices for which the restricted memory access using Xen grant mappings need to be enabled. Insert "iommus" property pointed to the IOMMU node with "xen,grant-dma" compatible to all virtio devices which backends are going to run in non-hardware domains (which are non-trusted by default). Based on device-tree binding from Linux: Documentation/devicetree/bindings/iommu/xen,grant-dma.yaml The example of generated nodes: xen_iommu { compatible = "xen,grant-dma"; #iommu-cells = <0x01>; phandle = <0xfde9>; }; virtio@2000000 { compatible = "virtio,mmio"; reg = <0x00 0x2000000 0x00 0x200>; interrupts = <0x00 0x01 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; virtio@2000200 { compatible = "virtio,mmio"; reg = <0x00 0x2000200 0x00 0x200>; interrupts = <0x00 0x02 0xf01>; interrupt-parent = <0xfde8>; dma-coherent; iommus = <0xfde9 0x01>; }; Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 2128143c114c52c7536e37c32935fdd77f23edc1 Author: Julien Grall Date: Fri Jul 15 22:20:25 2022 +0300 libxl: Introduce basic virtio-mmio support on Arm This patch introduces helpers to allocate Virtio MMIO params (IRQ and memory region) and create specific device node in the Guest device-tree with allocated params. In order to deal with multiple Virtio devices, reserve corresponding ranges. For now, we reserve 1MB for memory regions and 10 SPIs. As these helpers should be used for every Virtio device attached to the Guest, call them for Virtio disk(s). Please note, with statically allocated Virtio IRQs there is a risk of a clash with a physical IRQs of passthrough devices. For the first version, it's fine, but we should consider allocating the Virtio IRQs automatically. Thankfully, we know in advance which IRQs will be used for passthrough to be able to choose non-clashed ones. Signed-off-by: Julien Grall Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Stefano Stabellini Reviewed-by: Anthony PERARD commit 66dd1c62b2a3c707bd5c55750d10a8223fbd577f Author: Oleksandr Tyshchenko Date: Fri Jul 15 22:20:24 2022 +0300 libxl: Add support for Virtio disk configuration This patch adds basic support for configuring and assisting virtio-mmio based virtio-disk backend (emulator) which is intended to run out of Qemu and could be run in any domain. Although the Virtio block device is quite different from traditional Xen PV block device (vbd) from the toolstack's point of view: - as the frontend is virtio-blk which is not a Xenbus driver, nothing written to Xenstore are fetched by the frontend currently ("vdev" is not passed to the frontend). But this might need to be revised in future, so frontend data might be written to Xenstore in order to support hotplugging virtio devices or passing the backend domain id on arch where the device-tree is not available. - the ring-ref/event-channel are not used for the backend<->frontend communication, the proposed IPC for Virtio is IOREQ/DM it is still a "block device" and ought to be integrated in existing "disk" handling. So, re-use (and adapt) "disk" parsing/configuration logic to deal with Virtio devices as well. For the immediate purpose and an ability to extend that support for other use-cases in future (Qemu, virtio-pci, etc) perform the following actions: - Add new disk backend type (LIBXL_DISK_BACKEND_STANDALONE) and reflect that in the configuration - Introduce new disk "specification" and "transport" fields to struct libxl_device_disk. Both are written to the Xenstore. The transport field is only used for the specification "virtio" and it assumes only "mmio" value for now. - Introduce new "specification" option with "xen" communication protocol being default value. - Add new device kind (LIBXL__DEVICE_KIND_VIRTIO_DISK) as current one (LIBXL__DEVICE_KIND_VBD) doesn't fit into Virtio disk model An example of domain configuration for Virtio disk: disk = [ 'phy:/dev/mmcblk0p3, xvda1, backendtype=standalone, specification=virtio'] Nothing has changed for default Xen disk configuration. Please note, this patch is not enough for virtio-disk to work on Xen (Arm), as for every Virtio device (including disk) we need to allocate Virtio MMIO params (IRQ and memory region) and pass them to the backend, also update Guest device-tree. The subsequent patch will add these missing bits. For the current patch, the default "irq" and "base" are just written to the Xenstore. This is not an ideal splitting, but this way we avoid breaking the bisectability. Signed-off-by: Oleksandr Tyshchenko Reviewed-by: Anthony PERARD Acked-by: George Dunlap Tested-by: Jiamei Xie (qemu changes not included) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 01:30:41 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 01:30:41 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377958.611288 (Exim 4.92) (envelope-from ) id 1oHbJI-00054x-Is; Sat, 30 Jul 2022 01:30:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377958.611288; Sat, 30 Jul 2022 01:30:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHbJI-00054q-GC; Sat, 30 Jul 2022 01:30:32 +0000 Received: by outflank-mailman (input) for mailman id 377958; Sat, 30 Jul 2022 01:30:31 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHbJG-00054k-VZ for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 01:30:30 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 316cf2dc-0fa7-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 03:30:29 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9B73161CEE; Sat, 30 Jul 2022 01:30:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9AE1DC433D6; Sat, 30 Jul 2022 01:30:26 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 316cf2dc-0fa7-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659144627; bh=x98hx+nXW+NyRpONjLXqJeGNcgcO9WnjuDaMpyLpXNw=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=P4uorzhWraIM8zhI4r3lshu2ZdX6QcqZ8G0RzIJp4p1lp8sLik8hsTnOuv2dVci71 3o28Tqid8rhv+o4EWbtNPQFVgQY2mfbzbeDR6OQeza2LKx4a7WgPmqTjH8Qwk4hi1a Q8SdOfHc5WdlnWw7p9A7nauvogrTGImAx0anzeQVgp3Li7IHdHW4mKKSXcjZnUIab5 rhv4h0W0A673rpCtkZ1n5rKL3NDMDPL+dHnbb9nt3czaNU0Nd3ZFyb8O7mKvSCjqJ1 BkKkTnIcJeTEELoHvH4yu0qVgIPiHLX02F0KWzOaa15RKgbXQ59H1yKJ72TvFsvfA8 FZ2uSj/9f4uaA== Date: Fri, 29 Jul 2022 18:30:25 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@ubuntu-linux-20-04-desktop To: "Andrei Cherechesu (OSS)" cc: xen-devel@lists.xenproject.org, viryaos-discuss@lists.sourceforge.net, sstabellini@kernel.org, Andrei Cherechesu , ayan.kumar.halder@amd.com Subject: Re: [ImageBuilder][PATCH v3 1/3] uboot-script-gen: Dynamically compute addr and size when loading binaries In-Reply-To: <20220713163044.3541661-2-andrei.cherechesu@oss.nxp.com> Message-ID: References: <20220713163044.3541661-1-andrei.cherechesu@oss.nxp.com> <20220713163044.3541661-2-andrei.cherechesu@oss.nxp.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 13 Jul 2022, Andrei Cherechesu (OSS) wrote: > From: Andrei Cherechesu > > Normally, the script would precompute the sizes of the loaded binaries > and addresses where they are loaded before generating the script, > and the sizes and addresses that needed to be provided to Xen via > /chosen would be hardcoded in the boot script. > > Added option via "-s" parameter to use the ${filesize} variable > in u-boot, which is set automatically after a *load command. > The value stored by filesize is now stored in a u-boot env variable > with the name corresponding to the binary that was loaded before. > The newly set variables are now used in setting the /chosen node, > instead of the hardcoded values. > > Also, the loading addresses for the files are dynamically computed > and aligned to 0x200000 using the `setexpr` u-boot command. Basically, > if the option is used, there are zero hardcoded addresses inside the > boot script, and everything is determined based on the MEMORY_START > parameter and each binary's size. > > If the "-s" parameter is not used, the script does not store the > binaries' sizes and addresses in variables and uses the precomputed > ones when advertising them in the /chosen node. > > Signed-off-by: Andrei Cherechesu This patch is difficult :-) I like the idea but it makes the code significantly more complex due to the additional $dynamic_loading_opt case handled everywhere. Initially I thought about only retain the code path using u-boot variables, at least after loading the files. However, I realize that it would break the FDTEDIT case, which I think it would be good to keep working. Also it is nice to be able to edit the device tree at build time putting in the right values. So I tried to eliminated most of the new "if" statements in another way. The best I could come up with is the below, using eval and additional bash variables to look up the address and size based on the variable name (e.g. dom0_kernel). If we want the address, we use the value of $dom0_kernel_addr, if we want the u-boot variable we use ${dom0_kernel}. This is untested, just to show the idea. What do you think? Is it better? Do you prefer the original patch? Other ideas or opinions? diff --git a/scripts/uboot-script-gen b/scripts/uboot-script-gen index 18c0ce1..cee22f6 100755 --- a/scripts/uboot-script-gen +++ b/scripts/uboot-script-gen @@ -4,6 +4,9 @@ offset=$((2*1024*1024)) filesize=0 prog_req=(mkimage file fdtput mktemp awk) +padding_mask=`printf "0x%X\n" $(($offset - 1))` +padding_mask_inv=`printf "0x%X\n" $((~$padding_mask))` + function cleanup_and_return_err() { rm -f $UBOOT_SOURCE $UBOOT_SCRIPT @@ -28,6 +31,7 @@ function dt_mknode() # str # str_a # bool +# var function dt_set() { local path=$1 @@ -35,11 +39,21 @@ function dt_set() local data_type=$3 local data=$4 + if test $data_type = "var" + then + eval data_addr_var="$data"_addr + eval data_addr=\$"$data_addr_var" + eval data_size_var="$data"_size + eval data_size=\$"$data_size_var" + fi if test "$UBOOT_SOURCE" && test ! "$FIT" then var=${var/\#/\\#} - if test $data_type = "hex" || test $data_type = "int" + if test $data_type = "var" + then + echo "fdt set $path $var <0x0 0x\${"$data_addr_var"} 0x0 0x\${"$data_size_var"}>" >> $UBOOT_SOURCE + elif test $data_type = "hex" || test $data_type = "int" then echo "fdt set $path $var <$data>" >> $UBOOT_SOURCE elif test $data_type = "str_a" @@ -63,7 +77,10 @@ function dt_set() if test $FDTEDIT then - if test $data_type = "hex" + if test $data_type = "var" + then + fdtput $FDTEDIT -p -t x $path $var 0x0 "$data_addr" 0x0 "$data_size" + elif test $data_type = "hex" then fdtput $FDTEDIT -p -t x $path $var $data elif test $data_type = "int" @@ -87,38 +104,35 @@ function dt_set() function add_device_tree_kernel() { local path=$1 - local addr=$2 - local size=$3 - local bootargs=$4 + local varname=$2 + local bootargs=$3 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,kernel multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" - dt_set "$path/module$addr" "bootargs" "str" "$bootargs" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,kernel multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" + dt_set "$path/module-$varname" "bootargs" "str" "$bootargs" } function add_device_tree_ramdisk() { local path=$1 - local addr=$2 - local size=$3 + local varname=$2 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,ramdisk multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,ramdisk multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" } function add_device_tree_passthrough() { local path=$1 - local addr=$2 - local size=$3 + local varname=$2 - dt_mknode "$path" "module$addr" - dt_set "$path/module$addr" "compatible" "str_a" "multiboot,device-tree multiboot,module" - dt_set "$path/module$addr" "reg" "hex" "0x0 $addr 0x0 $(printf "0x%x" $size)" + dt_mknode "$path" "module-$varname" + dt_set "$path/module-$varname" "compatible" "str_a" "multiboot,device-tree multiboot,module" + dt_set "$path/module-$varname" "reg" "var" "$varname" } function add_device_tree_mem() @@ -186,7 +200,7 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0" dt_set "/chosen/dom0" "compatible" "str_a" "xen,linux-zimage xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0" "reg" "hex" "0x0 $dom0_kernel_addr 0x0 $(printf "0x%x" $dom0_kernel_size)" + dt_set "/chosen/dom0" "reg" "var" "dom0_linux" dt_set "/chosen" "xen,dom0-bootargs" "str" "$DOM0_CMD" fi @@ -194,7 +208,7 @@ function xen_device_tree_editing() then dt_mknode "/chosen" "dom0-ramdisk" dt_set "/chosen/dom0-ramdisk" "compatible" "str_a" "xen,linux-initrd xen,multiboot-module multiboot,module" - dt_set "/chosen/dom0-ramdisk" "reg" "hex" "0x0 $ramdisk_addr 0x0 $(printf "0x%x" $ramdisk_size)" + dt_set "/chosen/dom0-ramdisk" "reg" "var" "dom0_ramdisk" fi i=0 @@ -241,14 +255,14 @@ function xen_device_tree_editing() dt_set "/chosen/domU$i" "colors" "hex" "$(printf "0x%x" $bitcolors)" fi - add_device_tree_kernel "/chosen/domU$i" ${domU_kernel_addr[$i]} ${domU_kernel_size[$i]} "${DOMU_CMD[$i]}" + add_device_tree_kernel "/chosen/domU$i" "domU${i}_kernel" "${DOMU_CMD[$i]}" if test "${domU_ramdisk_addr[$i]}" then - add_device_tree_ramdisk "/chosen/domU$i" ${domU_ramdisk_addr[$i]} ${domU_ramdisk_size[$i]} + add_device_tree_ramdisk "/chosen/domU$i" "domU${i}_ramdisk" fi if test "${domU_passthrough_dtb_addr[$i]}" then - add_device_tree_passthrough "/chosen/domU$i" ${domU_passthrough_dtb_addr[$i]} ${domU_passthrough_dtb_size[$i]} + add_device_tree_passthrough "/chosen/domU$i" "domU${i}_fdt" fi i=$(( $i + 1 )) done @@ -271,7 +285,7 @@ function device_tree_editing() if test $UBOOT_SOURCE then - echo "fdt addr $device_tree_addr" >> $UBOOT_SOURCE + echo "fdt addr \${host_fdt_addr}" >> $UBOOT_SOURCE echo "fdt resize 1024" >> $UBOOT_SOURCE if test $NUM_DT_OVERLAY && test $NUM_DT_OVERLAY -gt 0 @@ -296,11 +310,25 @@ function device_tree_editing() function add_size() { local filename=$1 + local fit_scr_name=$2 + local binary_name_addr="${fit_scr_name}_addr" + local binary_name_size="${fit_scr_name}_size" + eval "$fit_scr_name"_addr=$memaddr + + echo "setenv $binary_name_addr \${memaddr}" >> $UBOOT_SOURCE + echo "setenv $binary_name_size \${filesize}" >> $UBOOT_SOURCE + # Compute load addr for next binary dynamically + echo "setexpr memaddr \${memaddr} \+ \${filesize}" >> $UBOOT_SOURCE + echo "setexpr memaddr \${memaddr} \+ $padding_mask" >> $UBOOT_SOURCE + echo "setexpr memaddr \${memaddr} \& $padding_mask_inv" >> $UBOOT_SOURCE + local size=`stat -L --printf="%s" $filename` memaddr=$(( $memaddr + $size + $offset - 1)) memaddr=$(( $memaddr & ~($offset - 1) )) memaddr=`printf "0x%X\n" $memaddr` filesize=$size + + eval "$fit_scr_name"_size=`printf "0x%X\n" $size` } function load_file() @@ -315,10 +343,13 @@ function load_file() if test "$FIT" then echo "imxtract \$fit_addr $fit_scr_name $memaddr" >> $UBOOT_SOURCE + elif test "$dynamic_loading_opt" + then + echo "$LOAD_CMD \${memaddr} ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE else echo "$LOAD_CMD $memaddr ${prepend_path:+$prepend_path/}$relative_path" >> $UBOOT_SOURCE fi - add_size $filename + add_size $filename $fit_scr_name } function check_file_type() @@ -899,7 +930,7 @@ function print_help { script=`basename "$0"` echo "usage:" - echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH]" + echo " $script -c CONFIG_FILE -d DIRECTORY [-t LOAD_CMD] [-o FILE] [-k KEY_DIR/HINT [-u U-BOOT_DTB]] [-e] [-f] [-p PREPEND_PATH] [-s]" echo " $script -h" echo "where:" echo " CONFIG_FILE - configuration file" @@ -916,6 +947,7 @@ function print_help echo " U-BOOT_DTB - u-boot control dtb so that the public key gets added to it" echo " -f - enable generating a FIT image" echo " PREPEND_PATH - path to be appended before file names to match deploy location within rootfs" + echo " -s - enable dynamic loading of binaries by storing their addresses and sizes u-boot env variables" echo " -h - prints out the help message and exits " echo "Defaults:" echo " CONFIG_FILE=$cfg_file, UBOOT_TYPE=\"LOAD_CMD\" env var, DIRECTORY=$uboot_dir" @@ -923,7 +955,7 @@ function print_help echo " $script -c ../config -d ./build42 -t \"scsi load 1:1\"" } -while getopts ":c:t:d:ho:k:u:fp:" opt; do +while getopts ":c:t:d:ho:k:u:fp:s" opt; do case ${opt} in t ) case $OPTARG in @@ -965,6 +997,9 @@ while getopts ":c:t:d:ho:k:u:fp:" opt; do p ) prepend_path="$OPTARG" ;; + s ) + dynamic_loading_opt=y + ;; h ) print_help exit 0 @@ -1126,6 +1161,7 @@ uboot_addr=$memaddr # 2MB are enough for a uboot script memaddr=$(( $memaddr + $offset )) memaddr=`printf "0x%X\n" $memaddr` +echo "setenv memaddr $memaddr" >> $UBOOT_SOURCE if test "$os" = "xen" then @@ -1169,11 +1205,7 @@ fi if [ "$BOOT_CMD" != "none" ] then - echo "$BOOT_CMD $kernel_addr - $device_tree_addr" >> $UBOOT_SOURCE -else - # skip boot command but store load addresses to be used later - echo "setenv host_kernel_addr $kernel_addr" >> $UBOOT_SOURCE - echo "setenv host_fdt_addr $device_tree_addr" >> $UBOOT_SOURCE + echo "$BOOT_CMD \${host_kernel_addr} - \${host_fdt_addr}" >> $UBOOT_SOURCE fi if test "$FIT" From xen-devel-bounces@lists.xenproject.org Sat Jul 30 04:08:09 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 04:08:09 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377610.611307 (Exim 4.92) (envelope-from ) id 1oHdle-0006BR-31; Sat, 30 Jul 2022 04:07:58 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377610.611307; Sat, 30 Jul 2022 04:07:58 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHdld-0006AR-SC; Sat, 30 Jul 2022 04:07:57 +0000 Received: by outflank-mailman (input) for mailman id 377610; Fri, 29 Jul 2022 15:28:18 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRuU-0001Lr-0i for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:28:18 +0000 Received: from ams.source.kernel.org (ams.source.kernel.org [2604:1380:4601:e00::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 10bc4b8f-0f53-11ed-bd2d-47488cf2e6aa; Fri, 29 Jul 2022 17:28:16 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0B522B82844; Fri, 29 Jul 2022 15:28:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1F1EC433D6; Fri, 29 Jul 2022 15:28:13 +0000 (UTC) Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 77B5C5C033E; Fri, 29 Jul 2022 08:28:13 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 10bc4b8f-0f53-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659108493; bh=+Eu1+NpdMQSxhSpBOHg1xq9IY5RE5+jGBaKhcxBU/fw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=SYC3Dsw++Jo9/onL7ZbEg1e34NjAkGJ0/LEyzxxtRyARi5tsRhnhMCBXpA48hlrbx /ygCpipyirN70BTWI+O7BPw3KEXhwiaeJ1toIS9f4x8NNUrtDb0g9IXD0fU2Bmoo6M w/YCbZ5sds6/EqIKdGN13GNgPIYzv0deYvecUifHVmZHvmvFFPvpCRqJ8szO8EVscM zHVucD9HNGWsnSLNuXErgrHHYht/KZ+I5xQvurQSs2gAeRSzLQTzOZZkq+fQyiif2B dBwd0T3KOaUJi1JScRgdDFB1nTqlfa6EEzGGbx1ADBkWPp5B2oyL/vemt0EQW8/A3l tsRJX93dX43kQ== Date: Fri, 29 Jul 2022 08:28:13 -0700 From: "Paul E. McKenney" To: Michel Lespinasse Cc: Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220729152813.GA3579395@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> Or better yet, try the patch that Rafael proposed. ;-) Thanx, Paul On Fri, Jul 29, 2022 at 08:26:22AM -0700, Paul E. McKenney wrote: > On Fri, Jul 29, 2022 at 03:24:58AM -0700, Michel Lespinasse wrote: > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > > > Xeons") wrecked intel_idle in two ways: > > > > > > > > > > - must not have tracing in idle functions > > > > > - must return with IRQs disabled > > > > > > > > > > Additionally, it added a branch for no good reason. > > > > > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > > > usage" when booting a kernel with debug options compiled in. Please > > > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > > > and is still present in v5.19-rc8. > > > > > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > > > > > I finally got a chance to take a quick look at this. > > > > > > The rcu_eqs_exit() function is making a lockdep complaint about > > > being invoked with interrupts enabled. This function is called from > > > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > > > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > > > interrupts before invoking rcu_eqs_exit(). > > > > > > The only other call to rcu_idle_exit() does not disable interrupts, > > > but it is via rcu_user_exit(), which would be a very odd choice for > > > cpuidle_enter_state(). > > > > > > It seems unlikely, but it might be that it is the use of local_irq_save() > > > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > > > the trouble. If this is the case, then the commit shown below would > > > help. Note that this commit removes the warning from lockdep, so it > > > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > > > equivalent debugging. > > > > > > Could you please try your test with the -rce commit shown below applied? > > > > Thanks for looking into it. > > And thank you for trying this shot in the dark! > > > After checking out Peter's commit 32d4fd5751ea, > > cherry picking your commit ed4ae5eff4b3, > > and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, > > I am now seeing this a few seconds into the boot: > > > > [ 3.010650] ------------[ cut here ]------------ > > [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 > > And this is again a complaint about interrupts not being disabled. > > But it does appear that the problem was the lockdep complaint, and > eliminating that did take care of part of the problem. But lockdep > remained enabled, and you therefore hit the next complaint. > > > [ 3.010657] Modules linked in: > > [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 > > [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 > > [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 > > The most straightforward way to get to sched_clock_tick() from > cpuidle_enter_state() is via the call to sched_clock_idle_wakeup_event(). > > Except that it disables interrupts before invoking sched_clock_tick(). > > > [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 > > 89 c0 48 03 1c c5 c0 98 > > [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 > > [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 > > [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 > > [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 > > [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 > > [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 > > [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 > > [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 > > [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > [ 3.010683] Call Trace: > > [ 3.010685] > > [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 > > [ 3.010694] cpuidle_enter+0x29/0x40 > > [ 3.010697] do_idle+0x1d4/0x210 > > [ 3.010702] cpu_startup_entry+0x19/0x20 > > [ 3.010704] rest_init+0x117/0x1a0 > > [ 3.010708] arch_call_rest_init+0xa/0x10 > > [ 3.010711] start_kernel+0x6d8/0x6ff > > [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb > > [ 3.010728] > > [ 3.010729] irq event stamp: 44179 > > [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 > > [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 > > [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 > > [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 > > [ 3.010741] ---[ end trace 0000000000000000 ]--- > > Would you be willing to try another shot in the dark, but untested > this time? I freely admit that this is getting strange. > > Thanx, Paul > > ------------------------------------------------------------------------ > > diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c > index e374c0c923dae..279f557bf60bb 100644 > --- a/kernel/sched/clock.c > +++ b/kernel/sched/clock.c > @@ -394,7 +394,7 @@ notrace void sched_clock_tick(void) > if (!static_branch_likely(&sched_clock_running)) > return; > > - lockdep_assert_irqs_disabled(); > + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); > > scd = this_scd(); > __scd_stamp(scd); From xen-devel-bounces@lists.xenproject.org Sat Jul 30 04:08:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 04:08:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377607.611299 (Exim 4.92) (envelope-from ) id 1oHdld-00067v-NQ; Sat, 30 Jul 2022 04:07:57 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377607.611299; Sat, 30 Jul 2022 04:07:57 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHdld-00067l-KF; Sat, 30 Jul 2022 04:07:57 +0000 Received: by outflank-mailman (input) for mailman id 377607; Fri, 29 Jul 2022 15:26:26 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHRsg-00017C-Ev for xen-devel@lists.xenproject.org; Fri, 29 Jul 2022 15:26:26 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id ce28bede-0f52-11ed-924f-1f966e50362f; Fri, 29 Jul 2022 17:26:24 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0442661BF0; Fri, 29 Jul 2022 15:26:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 618D7C433B5; Fri, 29 Jul 2022 15:26:22 +0000 (UTC) Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 0AF325C033E; Fri, 29 Jul 2022 08:26:22 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce28bede-0f52-11ed-924f-1f966e50362f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659108382; bh=u7iMRCibJGPgHojnAneRfpJQLfO1v9UeCr7NEqXA5r0=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=j/ssGM4UwMLUBLCP78RosSv+xdTA5IxQuurJEQkAk0bXcmXPO93JJUXNFsdGh+1wg +oQu9G8HFTFvq7oWLnSNFUXfz91zcbExFBxbHvUUrLwuFGec8y0pgDI7OkmIEUiDsJ xuSOA0nMD0LfFRMzO/hFHpmNupsJvKL62OZ7Ogs2Sct+xobNCKamTbCGFqWe+ziWO5 X1ZeZmjvoSs9jG1zXifbRaMvzpG1WXKjUcVgoHT0G2I9F3u+FSVuGP4WeqriMREnTB 5LhXtVu1diWGmPLJYP56buqhIf3r1Jp2kzJeotpuUGt61TvxvtDbwosjkjOrYw33Op oX8J8MWyCJV3g== Date: Fri, 29 Jul 2022 08:26:22 -0700 From: "Paul E. McKenney" To: Michel Lespinasse Cc: Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729102458.GA1695@lespinasse.org> On Fri, Jul 29, 2022 at 03:24:58AM -0700, Michel Lespinasse wrote: > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > > Xeons") wrecked intel_idle in two ways: > > > > > > > > - must not have tracing in idle functions > > > > - must return with IRQs disabled > > > > > > > > Additionally, it added a branch for no good reason. > > > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > > usage" when booting a kernel with debug options compiled in. Please > > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > > and is still present in v5.19-rc8. > > > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > > > I finally got a chance to take a quick look at this. > > > > The rcu_eqs_exit() function is making a lockdep complaint about > > being invoked with interrupts enabled. This function is called from > > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > > interrupts before invoking rcu_eqs_exit(). > > > > The only other call to rcu_idle_exit() does not disable interrupts, > > but it is via rcu_user_exit(), which would be a very odd choice for > > cpuidle_enter_state(). > > > > It seems unlikely, but it might be that it is the use of local_irq_save() > > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > > the trouble. If this is the case, then the commit shown below would > > help. Note that this commit removes the warning from lockdep, so it > > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > > equivalent debugging. > > > > Could you please try your test with the -rce commit shown below applied? > > Thanks for looking into it. And thank you for trying this shot in the dark! > After checking out Peter's commit 32d4fd5751ea, > cherry picking your commit ed4ae5eff4b3, > and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, > I am now seeing this a few seconds into the boot: > > [ 3.010650] ------------[ cut here ]------------ > [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 And this is again a complaint about interrupts not being disabled. But it does appear that the problem was the lockdep complaint, and eliminating that did take care of part of the problem. But lockdep remained enabled, and you therefore hit the next complaint. > [ 3.010657] Modules linked in: > [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 > [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 > [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 The most straightforward way to get to sched_clock_tick() from cpuidle_enter_state() is via the call to sched_clock_idle_wakeup_event(). Except that it disables interrupts before invoking sched_clock_tick(). > [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 > 89 c0 48 03 1c c5 c0 98 > [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 > [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 > [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 > [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 > [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 > [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 > [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 > [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 > [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 3.010683] Call Trace: > [ 3.010685] > [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 > [ 3.010694] cpuidle_enter+0x29/0x40 > [ 3.010697] do_idle+0x1d4/0x210 > [ 3.010702] cpu_startup_entry+0x19/0x20 > [ 3.010704] rest_init+0x117/0x1a0 > [ 3.010708] arch_call_rest_init+0xa/0x10 > [ 3.010711] start_kernel+0x6d8/0x6ff > [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb > [ 3.010728] > [ 3.010729] irq event stamp: 44179 > [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 > [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 > [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 > [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 > [ 3.010741] ---[ end trace 0000000000000000 ]--- Would you be willing to try another shot in the dark, but untested this time? I freely admit that this is getting strange. Thanx, Paul ------------------------------------------------------------------------ diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c index e374c0c923dae..279f557bf60bb 100644 --- a/kernel/sched/clock.c +++ b/kernel/sched/clock.c @@ -394,7 +394,7 @@ notrace void sched_clock_tick(void) if (!static_branch_likely(&sched_clock_running)) return; - lockdep_assert_irqs_disabled(); + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); scd = this_scd(); __scd_stamp(scd); From xen-devel-bounces@lists.xenproject.org Sat Jul 30 04:54:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 04:54:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.377987.611322 (Exim 4.92) (envelope-from ) id 1oHeUI-0004PP-EL; Sat, 30 Jul 2022 04:54:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 377987.611322; Sat, 30 Jul 2022 04:54:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHeUI-0004PI-BJ; Sat, 30 Jul 2022 04:54:06 +0000 Received: by outflank-mailman (input) for mailman id 377987; Sat, 30 Jul 2022 04:54:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHeUH-0004P8-F7; Sat, 30 Jul 2022 04:54:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHeUH-0002nt-Cm; Sat, 30 Jul 2022 04:54:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHeUG-0004SR-Tc; Sat, 30 Jul 2022 04:54:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHeUG-0006BB-T7; Sat, 30 Jul 2022 04:54:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OrFQ9a/DCklxlAWc+pPjfAbAG4HjQROMa+3/gC70hsA=; b=4RjpKJriCq5oCTGcU+B01znC7c RsfDxWi09S8d8HgytEG1eCJf0rpn5YueMGsSARMdwJyylqlXuY8YjWS30GjsUcCJlh3Mb7EMlfE8g bmrjfDYd7WSVWDp5+OUXNGym48ZWDAF66HmbotjbxXqJjWvN/Ggy/PBGDuEh7NDKIQak=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171934: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 04:54:04 +0000 flight 171934 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171934/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 9 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 06:30:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 06:30:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378002.611333 (Exim 4.92) (envelope-from ) id 1oHfzP-0007yL-FA; Sat, 30 Jul 2022 06:30:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378002.611333; Sat, 30 Jul 2022 06:30:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHfzP-0007yE-C8; Sat, 30 Jul 2022 06:30:19 +0000 Received: by outflank-mailman (input) for mailman id 378002; Sat, 30 Jul 2022 06:30:18 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHfzO-0007y4-DK; Sat, 30 Jul 2022 06:30:18 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHfzO-0004pv-9y; Sat, 30 Jul 2022 06:30:18 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHfzN-0007uT-TT; Sat, 30 Jul 2022 06:30:18 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHfzN-0004TW-T3; Sat, 30 Jul 2022 06:30:17 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=GsSohLNy8tD3tBEQusJZLzoZHZ0jTb7KNCtX1UaKjlc=; b=G2/hCeQb+y45A/V3ASHN6dGDqJ HxtB7cGnn1giRGnSEDwjNMm0domCWyJL6XhpKs/BM4/lfHOAbE8VGsxIRQ5wsogayZQTmVgyuVPLB HMhZyPeTSt6dwqUQbuQuMR9clnAA4SzMN8jKRn7t6siM5+3kD9WBTBML9sRl7U9FSM6E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171927: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=9fac07bea86d4c0f2e4fec8aab1bed89435d8bce X-Osstest-Versions-That: qemuu=cc42559ab129a15554cc485ea9265e34dde7ab5b From: osstest service owner Date: Sat, 30 Jul 2022 06:30:17 +0000 flight 171927 qemu-mainline real [real] http://logs.test-lab.xenproject.org/osstest/logs/171927/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171912 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171912 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171912 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171912 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171912 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171912 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171912 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171912 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 9fac07bea86d4c0f2e4fec8aab1bed89435d8bce baseline version: qemuu cc42559ab129a15554cc485ea9265e34dde7ab5b Last test of basis 171912 2022-07-29 02:12:34 Z 1 days Testing same since 171927 2022-07-29 17:38:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Bennée Bin Meng Claudio Fontana Cornelia Huck Daniel P. Berrangé Ilya Leoshkevich Paolo Bonzini Peter Maydell Richard Henderson Thomas Huth jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git cc42559ab1..9fac07bea8 9fac07bea86d4c0f2e4fec8aab1bed89435d8bce -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sat Jul 30 08:14:34 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 08:14:34 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378018.611344 (Exim 4.92) (envelope-from ) id 1oHhc0-0003Lf-Cg; Sat, 30 Jul 2022 08:14:16 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378018.611344; Sat, 30 Jul 2022 08:14:16 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHhc0-0003LY-9J; Sat, 30 Jul 2022 08:14:16 +0000 Received: by outflank-mailman (input) for mailman id 378018; Sat, 30 Jul 2022 08:14:14 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHhby-0003LM-CP; Sat, 30 Jul 2022 08:14:14 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHhby-00079R-AT; Sat, 30 Jul 2022 08:14:14 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHhby-0004xs-0y; Sat, 30 Jul 2022 08:14:14 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHhby-0001mu-0Y; Sat, 30 Jul 2022 08:14:14 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=TpcwEUqoJGXh5K0k4J6scREwoNEvJzNv1FwtNYpGKVk=; b=A9V62TBVLtKP8MefsKbms4hq3/ /z7kZ/QX3iuVszS59X4Ez9txEsk0e5g6DC/GcBN5deMsj0bfEg9ZreYmT8T0oF184PDhwhvBYR9Tq eSlLnfiydrjdCzm9IAA9gUnTdwZWTVrpRoGzFD+tW4ZEsJBPQRxvgv/r8Sro6ZaQ3xcA=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171936: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 08:14:14 +0000 flight 171936 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171936/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 2 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 10 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 10:05:00 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 10:05:00 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378032.611355 (Exim 4.92) (envelope-from ) id 1oHjKs-0007cy-E7; Sat, 30 Jul 2022 10:04:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378032.611355; Sat, 30 Jul 2022 10:04:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjKs-0007cr-Ak; Sat, 30 Jul 2022 10:04:42 +0000 Received: by outflank-mailman (input) for mailman id 378032; Sat, 30 Jul 2022 10:04:40 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjKq-0007ch-Tn; Sat, 30 Jul 2022 10:04:40 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjKq-0000hC-Qc; Sat, 30 Jul 2022 10:04:40 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjKq-0001DF-Di; Sat, 30 Jul 2022 10:04:40 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHjKq-0005hZ-Cj; Sat, 30 Jul 2022 10:04:40 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=FT1NJ0+/7km+3NV+GdyJJInf+hlqv6H5dr7bEoRH/0g=; b=sjrTrSEaRxp9xwf5ROcvXAwdwE 3avm2pTjq9hjxwzdW1KOm5efk1+XVTAsyZ8MYn5uiBT4cwX4vt22Vvn/F7jqPEov5Ku4AyQsPFqJr hIaBVpfltb0DMFYfYR10/yFyM2DaC1N/QCalU1kO0J56ZzuKqs6dq6GAqbbHjbLwP0WQ=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171931: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=e65c6a46df94c8d76ea1129eb2d4564670c6f214 X-Osstest-Versions-That: linux=6e2c0490769ef8a95b61304389116ccc85c53e12 From: osstest service owner Date: Sat, 30 Jul 2022 10:04:40 +0000 flight 171931 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171931/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171916 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171916 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171916 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171916 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171916 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171916 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171916 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171916 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux e65c6a46df94c8d76ea1129eb2d4564670c6f214 baseline version: linux 6e2c0490769ef8a95b61304389116ccc85c53e12 Last test of basis 171916 2022-07-29 06:34:59 Z 1 days Testing same since 171931 2022-07-29 21:42:46 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Alex Deucher Alistair Popple Arnaldo Carvalho de Melo Bart Van Assche Bibo Mao Dave Airlie David Jeffery Emil Renner Berthing Huacai Chen Ian Rogers Jason Yan Jun Yi Lai Jiangshan Laurence Oberman Leo Yan Liang He Linus Torvalds Lyude Paul Martin K. Petersen Maxime Ripard Michael Ellerman Namhyung Kim Nathan Chancellor Palmer Dabbelt Qi Hu Rafael J. Wysocki Sreekanth Reddy Tejun Heo Thomas Zimmermann Tiezhu Yang Waiman Long WANG Xuerui Xi Ruoyao jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6e2c0490769e..e65c6a46df94 e65c6a46df94c8d76ea1129eb2d4564670c6f214 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sat Jul 30 10:19:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 10:19:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378028.611366 (Exim 4.92) (envelope-from ) id 1oHjYt-0001Bt-Rh; Sat, 30 Jul 2022 10:19:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378028.611366; Sat, 30 Jul 2022 10:19:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjYt-0001Bm-NI; Sat, 30 Jul 2022 10:19:11 +0000 Received: by outflank-mailman (input) for mailman id 378028; Sat, 30 Jul 2022 09:40:42 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHixd-0005IT-MT for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 09:40:42 +0000 Received: from server.lespinasse.org (unknown [63.205.204.226]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id a8501ed4-0feb-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 11:40:37 +0200 (CEST) Received: by server.lespinasse.org (Postfix, from userid 1000) id 1452116096D; Sat, 30 Jul 2022 02:40:32 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: a8501ed4-0feb-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-ed; t=1659174032; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=weCa4etYCrU0JKpJO/Ui+2clGa/1cbP+1Ce8uxB4Z2U=; b=x/Ziq42GBYdLObjVTEjRxMr42JGNj1S6ikUonHkCSS9+QUAEIEusirhrUb1NLAhWCN9I/ 26gXmKmVFCvOvm8Ag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-rsa; t=1659174032; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=weCa4etYCrU0JKpJO/Ui+2clGa/1cbP+1Ce8uxB4Z2U=; b=xjlyRJ2PLCvlHddIpET9xkdQ9b2YJIlAuRmqVD4Zi9LYcfMqzgs3mU4rkm/FKHLXNUOaJ LyyP89/nFeA6CHdOEfvoMWe+2hvIc5qWIl7OAgthzIj8J1BY1lyEpfvyFmhVmffdeRhfjdo vMuxuuddA8OZu54a34mTh9dLsyNfUY1VEPbkQXmB5bXD5tY51a2x0Dy7lPzCrgrdbPY9jea g6bR8AptJZSZjsf3hgGuxahRdvKbF0nVgvjROX7b4fAX0R64UDLs/zIoRFldyB9Yfr1EawK tm9ki9L5Z6WkfftzLymxjgxhP/KXmf4WU+QM/fsd13mCq3dze1SIRx1wUOGA== Date: Sat, 30 Jul 2022 02:40:32 -0700 From: Michel Lespinasse To: "Paul E. McKenney" Cc: Michel Lespinasse , Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220730094032.GA1587@lespinasse.org> References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Jul 29, 2022 at 08:26:22AM -0700, Paul E. McKenney wrote:> Would you be willing to try another shot in the dark, but untested > this time? I freely admit that this is getting strange. > > Thanx, Paul Yes, adding this second change got rid of the boot time warning for me. > ------------------------------------------------------------------------ > > diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c > index e374c0c923dae..279f557bf60bb 100644 > --- a/kernel/sched/clock.c > +++ b/kernel/sched/clock.c > @@ -394,7 +394,7 @@ notrace void sched_clock_tick(void) > if (!static_branch_likely(&sched_clock_running)) > return; > > - lockdep_assert_irqs_disabled(); > + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); > > scd = this_scd(); > __scd_stamp(scd); From xen-devel-bounces@lists.xenproject.org Sat Jul 30 10:19:15 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 10:19:15 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378030.611369 (Exim 4.92) (envelope-from ) id 1oHjYu-0001FG-1l; Sat, 30 Jul 2022 10:19:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378030.611369; Sat, 30 Jul 2022 10:19:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHjYt-0001Ea-Uf; Sat, 30 Jul 2022 10:19:11 +0000 Received: by outflank-mailman (input) for mailman id 378030; Sat, 30 Jul 2022 09:48:04 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHj4m-0005bl-Fg for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 09:48:04 +0000 Received: from server.lespinasse.org (unknown [63.205.204.226]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b3a0ea75-0fec-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 11:48:03 +0200 (CEST) Received: by server.lespinasse.org (Postfix, from userid 1000) id B784116096F; Sat, 30 Jul 2022 02:48:00 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b3a0ea75-0fec-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-ed; t=1659174480; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=Zxf3RSaNJoCIr1yVDJrzk/JbWyKzetatYmCU4rexx90=; b=cZU78DKx8pFQT/pgVoRK+oC1CZy06YVs0Ncnf0QaLcl424By3Kjx5CkEiKeOCe5qVRr6F d5VUO89u24wx67IDg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-rsa; t=1659174480; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=Zxf3RSaNJoCIr1yVDJrzk/JbWyKzetatYmCU4rexx90=; b=E7bNTGGoLCtSak6vdo2mcsTxCf1hzf0BGfTJf+3fxNW8XoC1Irg25HKARFJxMUqglwRiZ /+PtdJukPF4I7dMchFGuOTlc6HF+ILudreHXspZ5+iq1EUo4O8wMtq/TUdXSHXBaa5SJ3NO jNncE1xXfEZDGhm9tVuTZARivwI3g2bOG161J6kIR/uneTxU5u8uosRneQGgcxDKcMpS14k VDxLDCrjKG2W1akV+QJCTqjuPVvOs13Tc5A3x81JQOC51BYOxcxo1P+tMKYHnkvyMojBpOI ML3j+Tx2rQv8aS6U1W+HYjpeQRsMxu/Pw3oIh4x81I9GbWbHHfVrH8MXwhjw== Date: Sat, 30 Jul 2022 02:48:00 -0700 From: Michel Lespinasse To: "Rafael J. Wysocki" Cc: Michel Lespinasse , "Paul E. McKenney" , Peter Zijlstra , Richard Henderson , Ivan Kokshaysky , Matt Turner , vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , Max Filippov , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220730094800.GB1587@lespinasse.org> References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Jul 29, 2022 at 04:59:50PM +0200, Rafael J. Wysocki wrote: > On Fri, Jul 29, 2022 at 12:25 PM Michel Lespinasse > wrote: > > > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > > > Xeons") wrecked intel_idle in two ways: > > > > > > > > > > - must not have tracing in idle functions > > > > > - must return with IRQs disabled > > > > > > > > > > Additionally, it added a branch for no good reason. > > > > > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > > > usage" when booting a kernel with debug options compiled in. Please > > > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > > > and is still present in v5.19-rc8. > > > > > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > > > > > I finally got a chance to take a quick look at this. > > > > > > The rcu_eqs_exit() function is making a lockdep complaint about > > > being invoked with interrupts enabled. This function is called from > > > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > > > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > > > interrupts before invoking rcu_eqs_exit(). > > > > > > The only other call to rcu_idle_exit() does not disable interrupts, > > > but it is via rcu_user_exit(), which would be a very odd choice for > > > cpuidle_enter_state(). > > > > > > It seems unlikely, but it might be that it is the use of local_irq_save() > > > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > > > the trouble. If this is the case, then the commit shown below would > > > help. Note that this commit removes the warning from lockdep, so it > > > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > > > equivalent debugging. > > > > > > Could you please try your test with the -rce commit shown below applied? > > > > Thanks for looking into it. > > > > After checking out Peter's commit 32d4fd5751ea, > > cherry picking your commit ed4ae5eff4b3, > > and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, > > I am now seeing this a few seconds into the boot: > > > > [ 3.010650] ------------[ cut here ]------------ > > [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 > > [ 3.010657] Modules linked in: > > [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 > > [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 > > [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 > > [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 > > 89 c0 48 03 1c c5 c0 98 > > [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 > > [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 > > [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 > > [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 > > [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 > > [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 > > [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 > > [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 > > [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > [ 3.010683] Call Trace: > > [ 3.010685] > > [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 > > [ 3.010694] cpuidle_enter+0x29/0x40 > > [ 3.010697] do_idle+0x1d4/0x210 > > [ 3.010702] cpu_startup_entry+0x19/0x20 > > [ 3.010704] rest_init+0x117/0x1a0 > > [ 3.010708] arch_call_rest_init+0xa/0x10 > > [ 3.010711] start_kernel+0x6d8/0x6ff > > [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb > > [ 3.010728] > > [ 3.010729] irq event stamp: 44179 > > [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 > > [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 > > [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 > > [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 > > [ 3.010741] ---[ end trace 0000000000000000 ]--- > > Can you please give this patch a go: > https://patchwork.kernel.org/project/linux-pm/patch/Yt/AxPFi88neW7W5@e126311.manchester.arm.com/ > ? I tried, but it didn't change the picture for me. I'm not sure if that was the patch you meant to send though, as it seems it's only adding a tracepoint so shouldn't make any difference if I'm not actually using the tracepoint ? From xen-devel-bounces@lists.xenproject.org Sat Jul 30 12:58:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 12:58:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378068.611387 (Exim 4.92) (envelope-from ) id 1oHm3D-00035O-FK; Sat, 30 Jul 2022 12:58:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378068.611387; Sat, 30 Jul 2022 12:58:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHm3D-00035H-Ca; Sat, 30 Jul 2022 12:58:39 +0000 Received: by outflank-mailman (input) for mailman id 378068; Sat, 30 Jul 2022 12:58:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHm3C-000357-HM; Sat, 30 Jul 2022 12:58:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHm3C-0003ao-Ds; Sat, 30 Jul 2022 12:58:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHm3B-0005e2-V3; Sat, 30 Jul 2022 12:58:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHm3B-0008Ib-Ug; Sat, 30 Jul 2022 12:58:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=07tx5r9IXiM173bFPa1eIIkOZcXSZO9qFxmfiH6swGs=; b=WaaITo+RYs8ZKKqzx3Of/0q2j6 G9RrMqToaOMs1wd3fkqJwiltJB+4i77XAr/Ewj1eQ6qLYtlCLg7J4C6Ia05nOBjIwZQzS9z5cCWfX +SEE7ZCVIRg15X+o2t8zhB/a48C8ux0VeetFSxSoQvU9/ErQl8ScBqMR4BrJXzRe1L/8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171938: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 12:58:37 +0000 flight 171938 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171938/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 11 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 3 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 14:40:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 14:40:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378091.611398 (Exim 4.92) (envelope-from ) id 1oHndo-0006yf-Os; Sat, 30 Jul 2022 14:40:32 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378091.611398; Sat, 30 Jul 2022 14:40:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHndo-0006yY-Lx; Sat, 30 Jul 2022 14:40:32 +0000 Received: by outflank-mailman (input) for mailman id 378091; Sat, 30 Jul 2022 14:40:32 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHndo-0006yO-2k; Sat, 30 Jul 2022 14:40:32 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHndn-0005ab-VD; Sat, 30 Jul 2022 14:40:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHndn-000874-LP; Sat, 30 Jul 2022 14:40:31 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHndn-0006Ms-Kz; Sat, 30 Jul 2022 14:40:31 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=vnoVwdQ2Ha8Oc3cp/oaavx6scSO8euDX+GCmwqIYuaA=; b=QdBUVMsxyxUVutR3aDwZ3iQU6L sqohVMRICrn9w8BTu0Ds72JIU+7pHUgbt7kEM4g0yFjfZBhGmNsq/yTandZDSQEJBMozGZ7tvUCMS +T4E4EtF0GfVoMvceSR71hl6Ipn8wLvEqbnMS+5+4nuNUOoA5zRwtcl71X2u002k+pqY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171933: regressions - FAIL X-Osstest-Failures: xen-unstable:build-i386:xen-build:fail:regression xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 14:40:31 +0000 flight 171933 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171933/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 6 xen-build fail REGR. vs. 171910 Tests which did not succeed, but are not blocking: test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-livepatch 1 build-check(1) blocked n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked n/a test-amd64-i386-pair 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked n/a test-amd64-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked n/a test-amd64-i386-examine 1 build-check(1) blocked n/a test-amd64-i386-examine-bios 1 build-check(1) blocked n/a test-amd64-i386-examine-uefi 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171910 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171910 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171910 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171910 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171910 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171910 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171910 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171910 test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171933 2022-07-30 01:54:34 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 fail build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt blocked build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl blocked test-amd64-coresched-i386-xl blocked test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd blocked test-amd64-i386-qemuu-rhel6hvm-amd blocked test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 blocked test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 blocked test-amd64-i386-freebsd10-amd64 blocked test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 blocked test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 blocked test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 blocked test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 blocked test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 blocked test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios blocked test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict blocked test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine blocked test-amd64-i386-freebsd10-i386 blocked test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel blocked test-amd64-i386-qemuu-rhel6hvm-intel blocked test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt blocked test-amd64-amd64-livepatch pass test-amd64-i386-livepatch blocked test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade blocked test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair blocked test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair blocked test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim blocked test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw blocked test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow blocked test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow blocked test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi blocked test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sat Jul 30 15:55:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 15:55:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378116.611409 (Exim 4.92) (envelope-from ) id 1oHonv-0006ov-9G; Sat, 30 Jul 2022 15:55:03 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378116.611409; Sat, 30 Jul 2022 15:55:03 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHonv-0006oo-6B; Sat, 30 Jul 2022 15:55:03 +0000 Received: by outflank-mailman (input) for mailman id 378116; Sat, 30 Jul 2022 15:55:01 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHont-0006oe-K8; Sat, 30 Jul 2022 15:55:01 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHont-0006pV-E0; Sat, 30 Jul 2022 15:55:01 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHont-0001R7-4m; Sat, 30 Jul 2022 15:55:01 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHont-0001N9-4F; Sat, 30 Jul 2022 15:55:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=c9URWG9zGqaGiMoW8c9zPjFtjLQXSXxqMnNhcIYeGxY=; b=xmreOKHVJlk4TFkL8WAk8Y11Kc gVoyl0zD59hiJ3D3rVA5S7/EMiwNZeQxzGjqG6G436lFfgwWB0ynrvj69uGMA50G5h1fP6i+YIBH6 a03miVSWJ/7LvQZMqq9Qm+cDdbogO9l4OTehy5sQGtibGKFXBtfZZGK7DxNra6KA63QY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 171935: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=8cb19a9b9a56ab6ebefc1f913c545e0bb86d4364 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sat, 30 Jul 2022 15:55:01 +0000 flight 171935 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/171935/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 8cb19a9b9a56ab6ebefc1f913c545e0bb86d4364 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 750 days Failing since 151818 2020-07-11 04:18:52 Z 749 days 731 attempts Testing same since 171935 2022-07-30 04:20:24 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117529 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 16:44:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 16:44:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378134.611421 (Exim 4.92) (envelope-from ) id 1oHpZp-0005PC-0V; Sat, 30 Jul 2022 16:44:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378134.611421; Sat, 30 Jul 2022 16:44:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHpZo-0005P5-U6; Sat, 30 Jul 2022 16:44:32 +0000 Received: by outflank-mailman (input) for mailman id 378134; Sat, 30 Jul 2022 16:44:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHpZn-0005Ov-9W; Sat, 30 Jul 2022 16:44:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHpZn-0008CE-3k; Sat, 30 Jul 2022 16:44:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHpZm-0002rc-T9; Sat, 30 Jul 2022 16:44:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHpZm-0008It-Sg; Sat, 30 Jul 2022 16:44:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=YL6oXPOyXVzQFKPUTYnCPS0NdTKeozYB7hueqaujqyc=; b=zkpzG2OuvroKTseadhddWdlLiC VGI0stjpT0x/sKUsUnGnUoOQ4es37DEycTi995OmudatbjE6fLo1JxYHk9lILquMwaL14Kw99bVgo ZIgy6dppTsy8w1MrVk4hMrYeujNY+5jMdBTiT6/2BRd1IMSleYc0i7NaWPX3r/FujAOI=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171939: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 16:44:30 +0000 flight 171939 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171939/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 1 days 12 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 4 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 19:30:31 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 19:30:31 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378171.611432 (Exim 4.92) (envelope-from ) id 1oHsA9-0007Na-IX; Sat, 30 Jul 2022 19:30:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378171.611432; Sat, 30 Jul 2022 19:30:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHsA9-0007NT-FZ; Sat, 30 Jul 2022 19:30:13 +0000 Received: by outflank-mailman (input) for mailman id 378171; Sat, 30 Jul 2022 19:30:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHsA7-0007NJ-OX; Sat, 30 Jul 2022 19:30:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHsA7-0002cy-Lp; Sat, 30 Jul 2022 19:30:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHsA7-0008P4-Eb; Sat, 30 Jul 2022 19:30:11 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHsA7-0006kp-E7; Sat, 30 Jul 2022 19:30:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=eeWdnheuP5Z3KRB1kKolPNKv/j6wN58JzlzUAVrWZOw=; b=oTOy0j2S3wdFIlDczbhxxULIUT FNQcnUXNS6HsppTiuRRmPG0yfN5E0Bw94I9kK4HEX45M4ERLnuFn6JyQE14P1m694va1RPDLpr4gN Yptd7XmtbqRHAZuP0HvePJRO5DdInw5vMUBE8XHlVO8HHUaVc0LrUsMxjUNe/y4Z6K+8=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171951: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sat, 30 Jul 2022 19:30:11 +0000 flight 171951 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171951/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 13 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 5 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sat Jul 30 20:28:49 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sat, 30 Jul 2022 20:28:49 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378180.611442 (Exim 4.92) (envelope-from ) id 1oHt4k-0005M3-VT; Sat, 30 Jul 2022 20:28:42 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378180.611442; Sat, 30 Jul 2022 20:28:42 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHt4k-0005Lw-Sr; Sat, 30 Jul 2022 20:28:42 +0000 Received: by outflank-mailman (input) for mailman id 378180; Sat, 30 Jul 2022 20:28:41 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHt4j-0005Lq-CN for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 20:28:41 +0000 Received: from deinos.phlegethon.org (deinos.phlegethon.org [2001:41d0:8:b1d7::1]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 30d95a57-1046-11ed-924f-1f966e50362f; Sat, 30 Jul 2022 22:28:39 +0200 (CEST) Received: from tjd by deinos.phlegethon.org with local (Exim 4.94.2 (FreeBSD)) (envelope-from ) id 1oHt4d-000NBT-HT; Sat, 30 Jul 2022 20:28:35 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 30d95a57-1046-11ed-924f-1f966e50362f Date: Sat, 30 Jul 2022 21:28:35 +0100 From: Tim Deegan To: Jan Beulich Cc: "xen-devel@lists.xenproject.org" , Andrew Cooper , Wei Liu , Roger Pau =?iso-8859-1?Q?Monn=E9?= , George Dunlap Subject: Re: [PATCH 0/8] x86: XSA-40{1,2,8} follow-up Message-ID: References: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <3fdfad2a-7891-0b08-5541-3b226e0555e1@suse.com> X-SA-Known-Good: Yes X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tim@xen.org X-SA-Exim-Scanned: No (on deinos.phlegethon.org); SAEximRunCond expanded to false At 17:58 +0200 on 26 Jul (1658858332), Jan Beulich wrote: > Perhaps not entirely unexpected the work there has turned up a few > further items which want dealing with. Most if not all of these > aren't interdependent, so could probably be looked at (and go in) > in (about) any order. Shadow parts Acked-by: Tim Deegan Cheers, Tim. From xen-devel-bounces@lists.xenproject.org Sun Jul 31 00:01:58 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 00:01:58 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378190.611454 (Exim 4.92) (envelope-from ) id 1oHwOo-0004Tm-56; Sun, 31 Jul 2022 00:01:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378190.611454; Sun, 31 Jul 2022 00:01:38 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwOo-0004Tf-1O; Sun, 31 Jul 2022 00:01:38 +0000 Received: by outflank-mailman (input) for mailman id 378190; Sun, 31 Jul 2022 00:01:36 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwOm-0004TV-IG; Sun, 31 Jul 2022 00:01:36 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwOm-00084m-Fa; Sun, 31 Jul 2022 00:01:36 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwOm-0000un-1c; Sun, 31 Jul 2022 00:01:36 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHwOm-00006C-1C; Sun, 31 Jul 2022 00:01:36 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=nPNhSQ1Bl6U8SJo2v5w8EJ8d2Fd21KNaKTgc08/bdE0=; b=zjZTsMi4egLtDmuYQKYd1zrcJV qUpUJYRODUM04UdmfY4q0glsfp/eU/fCOYGjYUqF+aN7kfN4/Uw1wA1yG9L8lQFrSpteFCAFLsa3G sziMye1XE8X89DQ8D1pgTxeUrId3+U107ihELpCSYDQftfmVTgTcojxib6LKrXo3Sn5A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171937: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-amd64-i386-qemuu-rhel6hvm-amd:xen-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:xen-boot:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm:debian-hvm-install:fail:heisenbug qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=fc2cc19ffa02c86ec1471ec8fdbc39d33fcec626 X-Osstest-Versions-That: qemuu=9fac07bea86d4c0f2e4fec8aab1bed89435d8bce From: osstest service owner Date: Sun, 31 Jul 2022 00:01:36 +0000 flight 171937 qemu-mainline real [real] flight 171976 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171937/ http://logs.test-lab.xenproject.org/osstest/logs/171976/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-i386-qemuu-rhel6hvm-amd 7 xen-install fail pass in 171976-retest test-arm64-arm64-libvirt-raw 8 xen-boot fail pass in 171976-retest test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm 12 debian-hvm-install fail pass in 171976-retest Tests which did not succeed, but are not blocking: test-arm64-arm64-libvirt-raw 14 migrate-support-check fail in 171976 never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail in 171976 never pass test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171927 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171927 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171927 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171927 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171927 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171927 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171927 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171927 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu fc2cc19ffa02c86ec1471ec8fdbc39d33fcec626 baseline version: qemuu 9fac07bea86d4c0f2e4fec8aab1bed89435d8bce Last test of basis 171927 2022-07-29 17:38:53 Z 1 days Testing same since 171937 2022-07-30 06:32:27 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Richard Henderson Yonggang Luo jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm fail test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd fail test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw fail test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git 9fac07bea8..fc2cc19ffa fc2cc19ffa02c86ec1471ec8fdbc39d33fcec626 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jul 31 00:02:07 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 00:02:07 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378194.611465 (Exim 4.92) (envelope-from ) id 1oHwPH-0004sx-FC; Sun, 31 Jul 2022 00:02:07 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378194.611465; Sun, 31 Jul 2022 00:02:07 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwPH-0004sq-Be; Sun, 31 Jul 2022 00:02:07 +0000 Received: by outflank-mailman (input) for mailman id 378194; Sun, 31 Jul 2022 00:02:07 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwPH-0004se-01; Sun, 31 Jul 2022 00:02:07 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwPG-00085S-VI; Sun, 31 Jul 2022 00:02:06 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHwPG-0000vD-KZ; Sun, 31 Jul 2022 00:02:06 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHwPG-00006j-K6; Sun, 31 Jul 2022 00:02:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PSqUmZs54RH5qsJrfv4WxRZtR4TK3pzlJLgvtKw+t4E=; b=K1LUQ7np2TOGmFZhgD5dgFJz9r EA/YdciMenV2uVvP0fam4iNaUxsEnaTEC8wCBhGO/s95ZAETKNyn50rQcN+6yNNEyGtUJ5wA/Fxaf AbzmlQw6D6173zt7xRVK0gveHQLH/QGu+/FEevSRgzEtHvqu3M7eIBWMjBL0j3btsQZw=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171965: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 00:02:06 +0000 flight 171965 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171965/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 14 attempts Testing same since 171934 2022-07-30 02:00:28 Z 0 days 6 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 01:25:35 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 01:25:35 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378207.611476 (Exim 4.92) (envelope-from ) id 1oHxhm-0003xb-JW; Sun, 31 Jul 2022 01:25:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378207.611476; Sun, 31 Jul 2022 01:25:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHxhm-0003xU-Gu; Sun, 31 Jul 2022 01:25:18 +0000 Received: by outflank-mailman (input) for mailman id 378207; Sun, 31 Jul 2022 01:25:17 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHxhl-0003xK-B5; Sun, 31 Jul 2022 01:25:17 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHxhl-0007nq-8N; Sun, 31 Jul 2022 01:25:17 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHxhk-0003k8-Rg; Sun, 31 Jul 2022 01:25:16 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oHxhk-0001IS-RE; Sun, 31 Jul 2022 01:25:16 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=RhLr1YDBKceskKviF1qYwwpJrJhDniidP6+0lw/Hr9Y=; b=iNbvaKJ5W7GRQDgD+Cntizd7vE 9DWlBmib82hChNcAS6rQFjEDqPYKOvd0cUzmPyQwFp0YZzGm6PO+4rsjnUmU6iFI7RIRMfLbxprdD lCV8v+mXSmaovTI823KWjuXFdH73z/X/kuszEtDf3T/qq/h2lNqpAr2xLyFRriH7ulR4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171955: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=620725263f4222b3c94d4ee19846835feec0ad69 X-Osstest-Versions-That: linux=e65c6a46df94c8d76ea1129eb2d4564670c6f214 From: osstest service owner Date: Sun, 31 Jul 2022 01:25:16 +0000 flight 171955 linux-linus real [real] http://logs.test-lab.xenproject.org/osstest/logs/171955/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171931 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171931 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171931 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171931 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171931 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171931 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171931 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171931 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 620725263f4222b3c94d4ee19846835feec0ad69 baseline version: linux e65c6a46df94c8d76ea1129eb2d4564670c6f214 Last test of basis 171931 2022-07-29 21:42:46 Z 1 days Testing same since 171955 2022-07-30 17:39:53 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Morton Christoph Hellwig Jaewon Kim Jens Axboe Linus Torvalds Mel Gorman Ralph Campbell Tobias Gruetzmacher jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git e65c6a46df94..620725263f42 620725263f4222b3c94d4ee19846835feec0ad69 -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Jul 31 04:07:10 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 04:07:10 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378219.611487 (Exim 4.92) (envelope-from ) id 1oI0EB-0005LL-3f; Sun, 31 Jul 2022 04:06:55 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378219.611487; Sun, 31 Jul 2022 04:06:55 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0EB-0005LE-0R; Sun, 31 Jul 2022 04:06:55 +0000 Received: by outflank-mailman (input) for mailman id 378219; Sun, 31 Jul 2022 04:06:53 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0E9-0005L3-2n; Sun, 31 Jul 2022 04:06:53 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0E9-0002qR-07; Sun, 31 Jul 2022 04:06:53 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0E8-0005Gx-LL; Sun, 31 Jul 2022 04:06:52 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI0E8-0000gY-Kq; Sun, 31 Jul 2022 04:06:52 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=xJPhV6oiwsEFQrCr4W4CHRuMEumas/d0D+/4jfA6tBY=; b=6o39WEAqn8+ldlpcQP2/QwuO3G IxgCti/QqoHQ0yz39GWWaSGm383ETY3nco7SWznecNiw5ZCTqPdTOaBJuzsrkHvWSWxCGkrUn3kFE Xf6Sg9f9hJw2Y6uSKvqQXPumHlo0Mqmxbgy1zfss1Y/TbTXrMHNICFE7IdPnB+GtXU7E=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 171988: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 04:06:52 +0000 flight 171988 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/171988/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 15 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 7 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 04:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 04:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378188.611508 (Exim 4.92) (envelope-from ) id 1oI0GN-00063S-33; Sun, 31 Jul 2022 04:09:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378188.611508; Sun, 31 Jul 2022 04:09:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0GM-000625-U2; Sun, 31 Jul 2022 04:09:10 +0000 Received: by outflank-mailman (input) for mailman id 378188; Sat, 30 Jul 2022 23:45:38 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHw9K-0001kq-3u for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 23:45:38 +0000 Received: from server.lespinasse.org (unknown [63.205.204.226]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id b2a004ca-1061-11ed-bd2d-47488cf2e6aa; Sun, 31 Jul 2022 01:45:33 +0200 (CEST) Received: by server.lespinasse.org (Postfix, from userid 1000) id F117B160977; Sat, 30 Jul 2022 16:45:29 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b2a004ca-1061-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-ed; t=1659224730; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=nAVqtDkPyoGTnjQOsobKhENqaeU5rNiWFfP8mKVev5k=; b=HFFhCK7R4iKO9dp7xadnNvlJ3TFgnIFCD+mWF8YiQOWKhEk/dwPTWNRYWGC9XfN1WRDf2 g306xaRkvMw+dqoAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lespinasse.org; i=@lespinasse.org; q=dns/txt; s=srv-79-rsa; t=1659224730; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to : from; bh=nAVqtDkPyoGTnjQOsobKhENqaeU5rNiWFfP8mKVev5k=; b=xEm4vrS+nhrfg16KlTSOz6xKHVgl2anxivbQOaQ8iyITrSIXx3k7S+7DNm3/9PE3/hP5/ weBfs5WCmns8PrJOUh5+LyucC170rSw2K/NgNrAjDpputAJGflo+dG36LsXYxD+GZSSZKbP Pj/N5DYITgz/J3aBedmEOjvEEcNa6ityOyI32KA+gNj6htWosOb+QOsIsRx/2q9SXnXOMQE CoO7nRU+J2kcBx1HiMTnfjr/eN+QixQZGT0tRp8own4vN9hl237pUBRGLyuycFtncUUh4v4 MsO6ge1ke2qwlIabxdvLZxjhahuiQC5BaBfCoCYkudJkUo4tS5HM55MrUsVw== Date: Sat, 30 Jul 2022 16:45:29 -0700 From: Michel Lespinasse To: "Rafael J. Wysocki" Cc: Michel Lespinasse , "Paul E. McKenney" , Peter Zijlstra , Richard Henderson , Ivan Kokshaysky , Matt Turner , vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , the arch/x86 maintainers , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , Max Filippov , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220730234529.GC1587@lespinasse.org> References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> <20220730094800.GB1587@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Sat, Jul 30, 2022 at 09:52:34PM +0200, Rafael J. Wysocki wrote: > On Sat, Jul 30, 2022 at 11:48 AM Michel Lespinasse > wrote: > > I'm not sure if that was the patch you meant to send though, as it > > seems it's only adding a tracepoint so shouldn't make any difference > > if I'm not actually using the tracepoint ? > > You are right, it looks like I pasted a link to a different patch by > mistake. Sorry about that. > > I meant this one: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm&id=d295ad34f236c3518634fb6403d4c0160456e470 > > which will appear in the final 5.19. Thanks. I can confirm that this patch fixes the boot time debug warnings for me. And I see that linus already merged it, nice! -- Michel "walken" Lespinasse. From xen-devel-bounces@lists.xenproject.org Sun Jul 31 04:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 04:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378154.611498 (Exim 4.92) (envelope-from ) id 1oI0GM-0005vd-HC; Sun, 31 Jul 2022 04:09:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378154.611498; Sun, 31 Jul 2022 04:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0GM-0005vW-Dk; Sun, 31 Jul 2022 04:09:10 +0000 Received: by outflank-mailman (input) for mailman id 378154; Sat, 30 Jul 2022 18:16:44 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHr12-0007UW-06 for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 18:16:44 +0000 Received: from dfw.source.kernel.org (dfw.source.kernel.org [2604:1380:4641:c500::1]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id c254c24f-1033-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 20:16:42 +0200 (CEST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4276E60EEB; Sat, 30 Jul 2022 18:16:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98DEFC433D7; Sat, 30 Jul 2022 18:16:39 +0000 (UTC) Received: by paulmck-ThinkPad-P17-Gen-1.home (Postfix, from userid 1000) id 3BA285C0266; Sat, 30 Jul 2022 11:16:39 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: c254c24f-1033-11ed-bd2d-47488cf2e6aa DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1659204999; bh=YJXP6A7d+KZPrg8HQv8x+gqLEMy1sjVdzXnl/qX62uw=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=gJSpKVSsAKz8pom4RuAB5Je2VfXHGMhI5S8QuPgLw6sbq0QnDrcsB984Q3KCjMEP4 SYUjeqdnSm23czJoxrwT8/cSChg2wZ3j8oXxKHXQSMFJwdsOWYkZ8L3yHTrxHHHv/B PCAYHs9Jnrby4wbTToGryEY6Ex3TIpS7AHVXuUJU6nS/OoMCgZLC69/yQVKdeU26z2 g1F1UjpLlSrDEHmQXbwyZ9oeANnc2U7/KwPArewe4hoBbjnHbzgEqXp6HAhF3f96Ro rfGOh77ykaTrG15ZCImyvdTTA95ZiEUj+F32tOHQ6Prrb5v2smeceYH3zHnZYF0uH1 p/j3tMujFTrgw== Date: Sat, 30 Jul 2022 11:16:39 -0700 From: "Paul E. McKenney" To: Michel Lespinasse Cc: Peter Zijlstra , rth@twiddle.net, ink@jurassic.park.msu.ru, mattst88@gmail.com, vgupta@kernel.org, linux@armlinux.org.uk, ulli.kroll@googlemail.com, linus.walleij@linaro.org, shawnguo@kernel.org, Sascha Hauer , kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, tony@atomide.com, khilman@kernel.org, catalin.marinas@arm.com, will@kernel.org, guoren@kernel.org, bcain@quicinc.com, chenhuacai@kernel.org, kernel@xen0n.name, geert@linux-m68k.org, sammy@sammy.net, monstr@monstr.eu, tsbogend@alpha.franken.de, dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, shorne@gmail.com, James.Bottomley@HansenPartnership.com, deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org, paulus@samba.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org, davem@davemloft.net, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, acme@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, namhyung@kernel.org, jgross@suse.com, srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, boris.ostrovsky@oracle.com, chris@zankel.net, jcmvbkbc@gmail.com, rafael@kernel.org, lenb@kernel.org, pavel@ucw.cz, gregkh@linuxfoundation.org, mturquette@baylibre.com, sboyd@kernel.org, daniel.lezcano@linaro.org, lpieralisi@kernel.org, sudeep.holla@arm.com, agross@kernel.org, bjorn.andersson@linaro.org, anup@brainfault.org, thierry.reding@gmail.com, jonathanh@nvidia.com, jacob.jun.pan@linux.intel.com, Arnd Bergmann , yury.norov@gmail.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, rostedt@goodmis.org, pmladek@suse.com, senozhatsky@chromium.org, john.ogness@linutronix.de, frederic@kernel.org, quic_neeraju@quicinc.com, josh@joshtriplett.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, joel@joelfernandes.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, linux-acpi@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-arch@vger.kernel.org, rcu@vger.kernel.org, rh0@fb.com Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE Message-ID: <20220730181639.GS2860372@paulmck-ThinkPad-P17-Gen-1> Reply-To: paulmck@kernel.org References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> <20220729152622.GM2860372@paulmck-ThinkPad-P17-Gen-1> <20220730094032.GA1587@lespinasse.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220730094032.GA1587@lespinasse.org> On Sat, Jul 30, 2022 at 02:40:32AM -0700, Michel Lespinasse wrote: > On Fri, Jul 29, 2022 at 08:26:22AM -0700, Paul E. McKenney wrote:> Would you be willing to try another shot in the dark, but untested > > this time? I freely admit that this is getting strange. > > > > Thanx, Paul > > Yes, adding this second change got rid of the boot time warning for me. OK, I will make a real patch. May I have your Tested-by? Thanx, Paul > > ------------------------------------------------------------------------ > > > > diff --git a/kernel/sched/clock.c b/kernel/sched/clock.c > > index e374c0c923dae..279f557bf60bb 100644 > > --- a/kernel/sched/clock.c > > +++ b/kernel/sched/clock.c > > @@ -394,7 +394,7 @@ notrace void sched_clock_tick(void) > > if (!static_branch_likely(&sched_clock_running)) > > return; > > > > - lockdep_assert_irqs_disabled(); > > + WARN_ON_ONCE(IS_ENABLED(CONFIG_RCU_EQS_DEBUG) && !raw_irqs_disabled()); > > > > scd = this_scd(); > > __scd_stamp(scd); From xen-devel-bounces@lists.xenproject.org Sun Jul 31 04:09:11 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 04:09:11 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378177.611502 (Exim 4.92) (envelope-from ) id 1oI0GM-0005z7-Ou; Sun, 31 Jul 2022 04:09:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378177.611502; Sun, 31 Jul 2022 04:09:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI0GM-0005y4-LN; Sun, 31 Jul 2022 04:09:10 +0000 Received: by outflank-mailman (input) for mailman id 378177; Sat, 30 Jul 2022 19:52:48 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oHsW0-0001qW-J4 for xen-devel@lists.xenproject.org; Sat, 30 Jul 2022 19:52:48 +0000 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 2ef67bd8-1041-11ed-bd2d-47488cf2e6aa; Sat, 30 Jul 2022 21:52:47 +0200 (CEST) Received: by mail-yb1-f173.google.com with SMTP id j195so13145414ybj.11 for ; Sat, 30 Jul 2022 12:52:47 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 2ef67bd8-1041-11ed-bd2d-47488cf2e6aa X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=0QwwjVOIVs4sR9ljVmsJX6Xu2S4+tvcr+oBVAjM+ePA=; b=qS7jTTWJsbpKBZ6+NZFbmk5PqQ1ugGS8hFH1q+kdimqcwfk9MsJDFAOzHsmqXd6l6q 1Vk7kQ41GanACvU/Jbct0zc0Orw857fj+mPfEaZz2VjT7EUMlerakJ3b15WGm1HgihHz prXg44kxblDodIO5OENSDoFoyPb14T6TGJI/ZDoJnQ+BL2AitM3zAd15xUwjtyIyovug BREP0vIDWWxVdVQ6t97u/hMZWZYXIt8njDBOdYjgvrSAvnYtAj7XxNSQWP89lx75ag1Y xG66yIbbyZDDAz6ufQz1DzaIOmB3Z1So8mjuP2K/lfD47jb6RHVTmXo2gczzT03ylTp3 WeDg== X-Gm-Message-State: ACgBeo3hzUJyy8n33v4FhnhH2FfTdqcGAmKCQZsuL7AY2UPasN/zxSB6 LRCAZa+Z8ttJVlk6Ec/C/9XqoWXjY/BGpydoM60= X-Google-Smtp-Source: AA6agR5p+lnEO42NEIBehm6hZLFrmXewKv2ogwUWOYz3LvGYShyipeAc9YxoFpIxLibrvw9Jcl6WeqKY+cLq4G0/mNE= X-Received: by 2002:a25:3458:0:b0:673:5bca:3b45 with SMTP id b85-20020a253458000000b006735bca3b45mr6304433yba.633.1659210766011; Sat, 30 Jul 2022 12:52:46 -0700 (PDT) MIME-Version: 1.0 References: <20220608142723.103523089@infradead.org> <20220608144516.172460444@infradead.org> <20220725194306.GA14746@lespinasse.org> <20220728172053.GA3607379@paulmck-ThinkPad-P17-Gen-1> <20220729102458.GA1695@lespinasse.org> <20220730094800.GB1587@lespinasse.org> In-Reply-To: <20220730094800.GB1587@lespinasse.org> From: "Rafael J. Wysocki" Date: Sat, 30 Jul 2022 21:52:34 +0200 Message-ID: Subject: Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE To: Michel Lespinasse Cc: "Rafael J. Wysocki" , "Paul E. McKenney" , Peter Zijlstra , Richard Henderson , Ivan Kokshaysky , Matt Turner , vgupta@kernel.org, Russell King - ARM Linux , ulli.kroll@googlemail.com, Linus Walleij , Shawn Guo , Sascha Hauer , Sascha Hauer , Fabio Estevam , dl-linux-imx , Tony Lindgren , Kevin Hilman , Catalin Marinas , Will Deacon , Guo Ren , bcain@quicinc.com, Huacai Chen , kernel@xen0n.name, Geert Uytterhoeven , sammy@sammy.net, Michal Simek , Thomas Bogendoerfer , dinguyen@kernel.org, jonas@southpole.se, stefan.kristiansson@saunalahti.fi, Stafford Horne , James Bottomley , Helge Deller , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , David Miller , Richard Weinberger , anton.ivanov@cambridgegreys.com, Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "the arch/x86 maintainers" , "H. Peter Anvin" , acme@kernel.org, Mark Rutland , Alexander Shishkin , jolsa@kernel.org, namhyung@kernel.org, Juergen Gross , srivatsa@csail.mit.edu, amakhalov@vmware.com, pv-drivers@vmware.com, Boris Ostrovsky , Chris Zankel , Max Filippov , Len Brown , Pavel Machek , Greg Kroah-Hartman , Michael Turquette , Stephen Boyd , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , Andy Gross , Bjorn Andersson , Anup Patel , Thierry Reding , Jon Hunter , Jacob Pan , Arnd Bergmann , Yury Norov , Andy Shevchenko , Rasmus Villemoes , Steven Rostedt , Petr Mladek , senozhatsky@chromium.org, John Ogness , Frederic Weisbecker , quic_neeraju@quicinc.com, Josh Triplett , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Benjamin Segall , Mel Gorman , Daniel Bristot de Oliveira , vschneid@redhat.com, jpoimboe@kernel.org, linux-alpha@vger.kernel.org, Linux Kernel Mailing List , linux-snps-arc@lists.infradead.org, Linux ARM , Linux OMAP Mailing List , linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k , "open list:BROADCOM NVRAM DRIVER" , openrisc@lists.librecores.org, Parisc List , linuxppc-dev , linux-riscv , linux-s390@vger.kernel.org, Linux-sh list , sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-perf-users@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, linux-xtensa@linux-xtensa.org, ACPI Devel Maling List , Linux PM , linux-clk , linux-arm-msm , linux-tegra , linux-arch , rcu@vger.kernel.org, rh0@fb.com Content-Type: text/plain; charset="UTF-8" On Sat, Jul 30, 2022 at 11:48 AM Michel Lespinasse wrote: > > On Fri, Jul 29, 2022 at 04:59:50PM +0200, Rafael J. Wysocki wrote: > > On Fri, Jul 29, 2022 at 12:25 PM Michel Lespinasse > > wrote: > > > > > > On Thu, Jul 28, 2022 at 10:20:53AM -0700, Paul E. McKenney wrote: > > > > On Mon, Jul 25, 2022 at 12:43:06PM -0700, Michel Lespinasse wrote: > > > > > On Wed, Jun 08, 2022 at 04:27:27PM +0200, Peter Zijlstra wrote: > > > > > > Commit c227233ad64c ("intel_idle: enable interrupts before C1 on > > > > > > Xeons") wrecked intel_idle in two ways: > > > > > > > > > > > > - must not have tracing in idle functions > > > > > > - must return with IRQs disabled > > > > > > > > > > > > Additionally, it added a branch for no good reason. > > > > > > > > > > > > Fixes: c227233ad64c ("intel_idle: enable interrupts before C1 on Xeons") > > > > > > Signed-off-by: Peter Zijlstra (Intel) > > > > > > > > > > After this change was introduced, I am seeing "WARNING: suspicious RCU > > > > > usage" when booting a kernel with debug options compiled in. Please > > > > > see the attached dmesg output. The issue starts with commit 32d4fd5751ea > > > > > and is still present in v5.19-rc8. > > > > > > > > > > I'm not sure, is this too late to fix or revert in v5.19 final ? > > > > > > > > I finally got a chance to take a quick look at this. > > > > > > > > The rcu_eqs_exit() function is making a lockdep complaint about > > > > being invoked with interrupts enabled. This function is called from > > > > rcu_idle_exit(), which is an expected code path from cpuidle_enter_state() > > > > via its call to rcu_idle_exit(). Except that rcu_idle_exit() disables > > > > interrupts before invoking rcu_eqs_exit(). > > > > > > > > The only other call to rcu_idle_exit() does not disable interrupts, > > > > but it is via rcu_user_exit(), which would be a very odd choice for > > > > cpuidle_enter_state(). > > > > > > > > It seems unlikely, but it might be that it is the use of local_irq_save() > > > > instead of raw_local_irq_save() within rcu_idle_exit() that is causing > > > > the trouble. If this is the case, then the commit shown below would > > > > help. Note that this commit removes the warning from lockdep, so it > > > > is necessary to build the kernel with CONFIG_RCU_EQS_DEBUG=y to enable > > > > equivalent debugging. > > > > > > > > Could you please try your test with the -rce commit shown below applied? > > > > > > Thanks for looking into it. > > > > > > After checking out Peter's commit 32d4fd5751ea, > > > cherry picking your commit ed4ae5eff4b3, > > > and setting CONFIG_RCU_EQS_DEBUG=y in addition of my usual debug config, > > > I am now seeing this a few seconds into the boot: > > > > > > [ 3.010650] ------------[ cut here ]------------ > > > [ 3.010651] WARNING: CPU: 0 PID: 0 at kernel/sched/clock.c:397 sched_clock_tick+0x27/0x60 > > > [ 3.010657] Modules linked in: > > > [ 3.010660] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 5.19.0-rc1-test-00005-g1be22fea0611 #1 > > > [ 3.010662] Hardware name: LENOVO 30BFS44D00/1036, BIOS S03KT51A 01/17/2022 > > > [ 3.010663] RIP: 0010:sched_clock_tick+0x27/0x60 > > > [ 3.010665] Code: 1f 40 00 53 eb 02 5b c3 66 90 8b 05 2f c3 40 01 85 c0 74 18 65 8b 05 60 88 8f 4e 85 c0 75 0d 65 8b 05 a9 85 8f 4e 85 c0 74 02 <0f> 0b e8 e2 6c 89 00 48 c7 c3 40 d5 02 00 > > > 89 c0 48 03 1c c5 c0 98 > > > [ 3.010667] RSP: 0000:ffffffffb2803e28 EFLAGS: 00010002 > > > [ 3.010670] RAX: 0000000000000001 RBX: ffffc8ce7fa07060 RCX: 0000000000000001 > > > [ 3.010671] RDX: 0000000000000000 RSI: ffffffffb268dd21 RDI: ffffffffb269ab13 > > > [ 3.010673] RBP: 0000000000000001 R08: ffffffffffc300d5 R09: 000000000002be80 > > > [ 3.010674] R10: 000003625b53183a R11: ffffa012b802b7a4 R12: ffffffffb2aa9e80 > > > [ 3.010675] R13: ffffffffb2aa9e00 R14: 0000000000000001 R15: 0000000000000000 > > > [ 3.010677] FS: 0000000000000000(0000) GS:ffffa012b8000000(0000) knlGS:0000000000000000 > > > [ 3.010678] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > > > [ 3.010680] CR2: ffffa012f81ff000 CR3: 0000000c99612001 CR4: 00000000003706f0 > > > [ 3.010681] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > [ 3.010682] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > [ 3.010683] Call Trace: > > > [ 3.010685] > > > [ 3.010688] cpuidle_enter_state+0xb7/0x4b0 > > > [ 3.010694] cpuidle_enter+0x29/0x40 > > > [ 3.010697] do_idle+0x1d4/0x210 > > > [ 3.010702] cpu_startup_entry+0x19/0x20 > > > [ 3.010704] rest_init+0x117/0x1a0 > > > [ 3.010708] arch_call_rest_init+0xa/0x10 > > > [ 3.010711] start_kernel+0x6d8/0x6ff > > > [ 3.010716] secondary_startup_64_no_verify+0xce/0xdb > > > [ 3.010728] > > > [ 3.010729] irq event stamp: 44179 > > > [ 3.010730] hardirqs last enabled at (44179): [] asm_sysvec_apic_timer_interrupt+0x1b/0x20 > > > [ 3.010734] hardirqs last disabled at (44177): [] __do_softirq+0x3f0/0x498 > > > [ 3.010736] softirqs last enabled at (44178): [] __do_softirq+0x332/0x498 > > > [ 3.010738] softirqs last disabled at (44171): [] irq_exit_rcu+0xab/0xf0 > > > [ 3.010741] ---[ end trace 0000000000000000 ]--- > > > > Can you please give this patch a go: > > https://patchwork.kernel.org/project/linux-pm/patch/Yt/AxPFi88neW7W5@e126311.manchester.arm.com/ > > ? > > I tried, but it didn't change the picture for me. > > I'm not sure if that was the patch you meant to send though, as it > seems it's only adding a tracepoint so shouldn't make any difference > if I'm not actually using the tracepoint ? You are right, it looks like I pasted a link to a different patch by mistake. Sorry about that. I meant this one: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm&id=d295ad34f236c3518634fb6403d4c0160456e470 which will appear in the final 5.19. From xen-devel-bounces@lists.xenproject.org Sun Jul 31 07:23:26 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 07:23:26 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378255.611531 (Exim 4.92) (envelope-from ) id 1oI3I2-0004HN-2T; Sun, 31 Jul 2022 07:23:06 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378255.611531; Sun, 31 Jul 2022 07:23:06 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3I1-0004HG-VX; Sun, 31 Jul 2022 07:23:05 +0000 Received: by outflank-mailman (input) for mailman id 378255; Sun, 31 Jul 2022 07:23:05 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3I1-0004H6-Gg; Sun, 31 Jul 2022 07:23:05 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3I1-0006gT-D9; Sun, 31 Jul 2022 07:23:05 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3I0-0000KL-Vl; Sun, 31 Jul 2022 07:23:05 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI3I0-0007Bn-VI; Sun, 31 Jul 2022 07:23:04 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ygub37RyPL7bnCVQbtRnz7XYc3wkit7NApkRNoeD2+g=; b=OD0AQqlW4zvmF2n1lZJyl5Wwb3 42VJsRVk+Jix/LCPKzNSy5eZ2phB+PFcfti8Uifm9farbkSEHkvoanx0QLBRyTZ2oRg9uRHaAYjtU 0x3nkz14q+OtssEnv4g44REmAMx2y1ROF48dZ/8AB6q/Pap2gGnNIB1qJCM9P7pHhXW0=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [qemu-mainline test] 171983: tolerable FAIL - PUSHED X-Osstest-Failures: qemu-mainline:test-arm64-arm64-xl-seattle:guest-start.2:fail:heisenbug qemu-mainline:test-amd64-amd64-xl-qemuu-debianhvm-amd64:guest-localmigrate/x10:fail:heisenbug qemu-mainline:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking qemu-mainline:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking qemu-mainline:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking qemu-mainline:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: qemuu=3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3 X-Osstest-Versions-That: qemuu=fc2cc19ffa02c86ec1471ec8fdbc39d33fcec626 From: osstest service owner Date: Sun, 31 Jul 2022 07:23:04 +0000 flight 171983 qemu-mainline real [real] flight 172012 qemu-mainline real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171983/ http://logs.test-lab.xenproject.org/osstest/logs/172012/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-arm64-arm64-xl-seattle 19 guest-start.2 fail pass in 172012-retest test-amd64-amd64-xl-qemuu-debianhvm-amd64 18 guest-localmigrate/x10 fail pass in 172012-retest Tests which did not succeed, but are not blocking: test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171937 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171937 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171937 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171937 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171937 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171937 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171937 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171937 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: qemuu 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3 baseline version: qemuu fc2cc19ffa02c86ec1471ec8fdbc39d33fcec626 Last test of basis 171937 2022-07-30 06:32:27 Z 1 days Testing same since 171983 2022-07-31 00:08:48 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Richard Henderson Xiaojuan Yang jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 fail test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle fail test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/qemu-xen.git fc2cc19ffa..3916603e0c 3916603e0c1d909e14e09d5ebcbdaa9c9e21adf3 -> upstream-tested From xen-devel-bounces@lists.xenproject.org Sun Jul 31 07:52:16 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 07:52:16 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378263.611542 (Exim 4.92) (envelope-from ) id 1oI3kB-000822-CE; Sun, 31 Jul 2022 07:52:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378263.611542; Sun, 31 Jul 2022 07:52:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3kB-00081v-9a; Sun, 31 Jul 2022 07:52:11 +0000 Received: by outflank-mailman (input) for mailman id 378263; Sun, 31 Jul 2022 07:52:10 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3kA-00081l-08; Sun, 31 Jul 2022 07:52:10 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3k9-0007Aq-Uj; Sun, 31 Jul 2022 07:52:09 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI3k9-0001zf-O4; Sun, 31 Jul 2022 07:52:09 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI3k9-0001QR-Nd; Sun, 31 Jul 2022 07:52:09 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bTV58h1LIZ+M//pTj1a/OMMgjPilrDJ3elSAlBwqHao=; b=o+EqJlE2bWHE66As/vYe+JEwJF dpGQkGwTVYK4nnNoBA1CQ4EasBCUZnEZgC3ZTUbyqU5PJf3oG3oLpH/oIdKXML9jYCMkmHKssjE1f ebKWMPZ9JLc2/ZhTVtkor7yL7GTESC5nun9VXkl+WdHh5MEv911QrZdda3c+Y5D7zPOo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172008: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 07:52:09 +0000 flight 172008 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172008/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 16 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 8 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 11:20:33 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 11:20:33 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378294.611552 (Exim 4.92) (envelope-from ) id 1oI6zV-0006Cc-02; Sun, 31 Jul 2022 11:20:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378294.611552; Sun, 31 Jul 2022 11:20:12 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI6zU-0006CV-Th; Sun, 31 Jul 2022 11:20:12 +0000 Received: by outflank-mailman (input) for mailman id 378294; Sun, 31 Jul 2022 11:20:11 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI6zT-0006CL-G6; Sun, 31 Jul 2022 11:20:11 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI6zT-0002w9-Bs; Sun, 31 Jul 2022 11:20:11 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI6zS-0000Dp-Rn; Sun, 31 Jul 2022 11:20:10 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI6zS-00063F-RH; Sun, 31 Jul 2022 11:20:10 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=QlVWRkYM5ez+EAY6Xk2/N4V5/Uv7AJlu3lANlf+b5qE=; b=E/YwLtVHdCMVz+i9QVSBbEdN/4 +ECuUzwMvkV0Ndd7dINHQAnzR5qMtOqg8NBaQ5n4paxUwc3lAt0j4cfBJyD1kfv4hZB1h7sTX4j9c 2e7hj/jnOq1lB4JpCOl0YH0j2U8E3FPIqkxEm8DjM9b1HIwB5LTiE0HQ8DxYVGAjXlIM=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172022: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 11:20:10 +0000 flight 172022 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172022/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 3 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 17 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 9 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 11:49:50 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 11:49:50 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378303.611564 (Exim 4.92) (envelope-from ) id 1oI7S5-0000k0-DA; Sun, 31 Jul 2022 11:49:45 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378303.611564; Sun, 31 Jul 2022 11:49:45 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI7S5-0000jt-AZ; Sun, 31 Jul 2022 11:49:45 +0000 Received: by outflank-mailman (input) for mailman id 378303; Sun, 31 Jul 2022 11:49:44 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI7S4-0000jj-0d; Sun, 31 Jul 2022 11:49:44 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI7S3-0003R1-UE; Sun, 31 Jul 2022 11:49:43 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI7S3-00011X-NK; Sun, 31 Jul 2022 11:49:43 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI7S3-0004xX-Mr; Sun, 31 Jul 2022 11:49:43 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=3ZcKmzdAf0osc57o3cIokNAL4Gx61VJsDqDKp+X70Nc=; b=i2PiRpQSkSKOx01RxeTuiB+3XJ TDAqSG5UtZ6vcx84tzVoCOR0bC1aPO9VjtFpS/yPFweyPxvjKfwpXdyH0f/A59hh0D9PkKI8Laovt aYXpXM9dCgSL+BK0UKe0Vz7dq8tiEHxqOl80CZJ21UVt9uodspX9pglzthnXFWxFGKFo=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 171992: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-amd64-amd64-freebsd12-amd64:guest-localmigrate/x10:fail:heisenbug linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=6a010258447d386186ca10cd374d888ac66ffe1a X-Osstest-Versions-That: linux=620725263f4222b3c94d4ee19846835feec0ad69 From: osstest service owner Date: Sun, 31 Jul 2022 11:49:43 +0000 flight 171992 linux-linus real [real] flight 172035 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/171992/ http://logs.test-lab.xenproject.org/osstest/logs/172035/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-amd64-amd64-freebsd12-amd64 19 guest-localmigrate/x10 fail pass in 172035-retest Tests which did not succeed, but are not blocking: test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171955 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171955 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171955 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171955 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171955 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171955 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171955 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171955 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass version targeted for testing: linux 6a010258447d386186ca10cd374d888ac66ffe1a baseline version: linux 620725263f4222b3c94d4ee19846835feec0ad69 Last test of basis 171955 2022-07-30 17:39:53 Z 0 days Testing same since 171992 2022-07-31 01:41:56 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Florian Fainelli Guenter Roeck Linus Torvalds Russell King (Oracle) jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 fail test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 620725263f42..6a010258447d 6a010258447d386186ca10cd374d888ac66ffe1a -> tested/linux-linus From xen-devel-bounces@lists.xenproject.org Sun Jul 31 13:56:08 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 13:56:08 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378327.611578 (Exim 4.92) (envelope-from ) id 1oI9Q6-0006KM-Cp; Sun, 31 Jul 2022 13:55:50 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378327.611578; Sun, 31 Jul 2022 13:55:50 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI9Q6-0006KF-9k; Sun, 31 Jul 2022 13:55:50 +0000 Received: by outflank-mailman (input) for mailman id 378327; Sun, 31 Jul 2022 13:55:48 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI9Q4-0006K5-EV; Sun, 31 Jul 2022 13:55:48 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI9Q4-0005az-As; Sun, 31 Jul 2022 13:55:48 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oI9Q4-0003vy-2G; Sun, 31 Jul 2022 13:55:48 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oI9Q4-0002g5-1p; Sun, 31 Jul 2022 13:55:48 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=N0ND0LLVbyFdxAJuNuzqhBTkdv9eJox89PnFXWGuziw=; b=RTtwLUbs1B8lgPnR/GkJGSsCUp 1X9soikhu0p6QrM5l3AHeH2+32i374vtUAAGoEjMuSaVD04bZlgbLu3i4hV8o3nq7VCbQGNvZbArt LcYJmmMVu1+7OioP/vS8wxJ3fMTarqh65F2oZMUAXlvqGu4acb5uum7kAlAbsJxPV/+M=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable test] 171993: regressions - FAIL X-Osstest-Failures: xen-unstable:build-i386:xen-build:fail:regression xen-unstable:test-arm64-arm64-libvirt-xsm:debian-install:fail:heisenbug xen-unstable:test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm:debian-hvm-install:fail:heisenbug xen-unstable:test-amd64-i386-migrupgrade:xen-install/dst_host:fail:heisenbug xen-unstable:test-armhf-armhf-libvirt-raw:xen-boot:fail:heisenbug xen-unstable:test-arm64-arm64-xl-credit1:xen-boot:fail:heisenbug xen-unstable:build-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-coresched-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine-bios:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-examine-uefi:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-freebsd10-i386:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-livepatch:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-migrupgrade:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-pair:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemut-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-amd:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-qemuu-rhel6hvm-intel:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ovmf-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-shadow:build-check(1):blocked:nonblocking xen-unstable:test-amd64-i386-xl-vhd:build-check(1):blocked:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking xen-unstable:test-amd64-i386-xl-pvshim:guest-start:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-i386-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking xen-unstable:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking xen-unstable:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=f732240fd3bac25116151db5ddeb7203b62e85ce X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 13:55:48 +0000 flight 171993 xen-unstable real [real] http://logs.test-lab.xenproject.org/osstest/logs/171993/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-i386 6 xen-build fail in 171933 REGR. vs. 171993 Tests which are failing intermittently (not blocking): test-arm64-arm64-libvirt-xsm 12 debian-install fail in 171910 pass in 171993 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm 12 debian-hvm-install fail in 171910 pass in 171993 test-amd64-i386-migrupgrade 11 xen-install/dst_host fail pass in 171910 test-armhf-armhf-libvirt-raw 8 xen-boot fail pass in 171933 test-arm64-arm64-xl-credit1 8 xen-boot fail pass in 171933 Tests which did not succeed, but are not blocking: build-i386-libvirt 1 build-check(1) blocked in 171933 n/a test-amd64-coresched-i386-xl 1 build-check(1) blocked in 171933 n/a test-amd64-i386-examine 1 build-check(1) blocked in 171933 n/a test-amd64-i386-examine-bios 1 build-check(1) blocked in 171933 n/a test-amd64-i386-examine-uefi 1 build-check(1) blocked in 171933 n/a test-amd64-i386-freebsd10-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-freebsd10-i386 1 build-check(1) blocked in 171933 n/a test-amd64-i386-libvirt 1 build-check(1) blocked in 171933 n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked in 171933 n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked in 171933 n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked in 171933 n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked in 171933 n/a test-amd64-i386-livepatch 1 build-check(1) blocked in 171933 n/a test-amd64-i386-migrupgrade 1 build-check(1) blocked in 171933 n/a test-amd64-i386-pair 1 build-check(1) blocked in 171933 n/a test-amd64-i386-qemut-rhel6hvm-amd 1 build-check(1) blocked in 171933 n/a test-amd64-i386-qemut-rhel6hvm-intel 1 build-check(1) blocked in 171933 n/a test-amd64-i386-qemuu-rhel6hvm-amd 1 build-check(1) blocked in 171933 n/a test-amd64-i386-qemuu-rhel6hvm-intel 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-pvshim 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemut-debianhvm-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemut-win7-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemut-ws16-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-ovmf-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-win7-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-qemuu-ws16-amd64 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-shadow 1 build-check(1) blocked in 171933 n/a test-amd64-i386-xl-vhd 1 build-check(1) blocked in 171933 n/a test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail in 171910 like 171933 test-arm64-arm64-xl-credit1 15 migrate-support-check fail in 171910 never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail in 171910 never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail in 171910 never pass test-amd64-i386-xl-qemut-ws16-amd64 19 guest-stop fail like 171910 test-amd64-i386-xl-qemut-win7-amd64 19 guest-stop fail like 171910 test-amd64-i386-xl-qemuu-win7-amd64 19 guest-stop fail like 171910 test-amd64-i386-xl-qemuu-ws16-amd64 19 guest-stop fail like 171910 test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171933 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171933 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171933 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171933 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171933 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171933 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171933 test-amd64-i386-xl-pvshim 14 guest-start fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt 15 migrate-support-check fail never pass test-amd64-i386-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-i386-libvirt-raw 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-vhd 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-credit2 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass version targeted for testing: xen f732240fd3bac25116151db5ddeb7203b62e85ce baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171993 2022-07-31 01:52:05 Z 0 days Testing same since (not found) 0 attempts jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64-xtf pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-prev pass build-i386-prev pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-xtf-amd64-amd64-1 pass test-xtf-amd64-amd64-2 pass test-xtf-amd64-amd64-3 pass test-xtf-amd64-amd64-4 pass test-xtf-amd64-amd64-5 pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-i386-xl pass test-amd64-coresched-i386-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-i386-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-i386-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-i386-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-i386-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-i386-qemut-rhel6hvm-amd pass test-amd64-i386-qemuu-rhel6hvm-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-i386-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-xl-qemuu-debianhvm-amd64 pass test-amd64-i386-freebsd10-amd64 pass test-amd64-amd64-qemuu-freebsd11-amd64 pass test-amd64-amd64-qemuu-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-i386-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-i386-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-i386-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-amd64-i386-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-i386-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 fail test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 pass test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-i386-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-i386-examine pass test-amd64-i386-freebsd10-i386 pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-i386-qemut-rhel6hvm-intel pass test-amd64-i386-qemuu-rhel6hvm-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-i386-libvirt pass test-amd64-amd64-livepatch pass test-amd64-i386-livepatch pass test-amd64-amd64-migrupgrade pass test-amd64-i386-migrupgrade fail test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-i386-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-i386-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-i386-xl-pvshim fail test-amd64-amd64-pygrub pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-xl-qcow2 pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw fail test-amd64-i386-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-amd64-i386-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-i386-examine-uefi pass test-amd64-amd64-libvirt-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass test-amd64-i386-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Published tested tree is already up to date. From xen-devel-bounces@lists.xenproject.org Sun Jul 31 14:49:18 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 14:49:18 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378338.611589 (Exim 4.92) (envelope-from ) id 1oIAFi-0003s7-9x; Sun, 31 Jul 2022 14:49:10 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378338.611589; Sun, 31 Jul 2022 14:49:10 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIAFi-0003s0-7K; Sun, 31 Jul 2022 14:49:10 +0000 Received: by outflank-mailman (input) for mailman id 378338; Sun, 31 Jul 2022 14:49:08 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIAFg-0003ro-6B; Sun, 31 Jul 2022 14:49:08 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIAFg-0006Yb-3U; Sun, 31 Jul 2022 14:49:08 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIAFf-00059V-Om; Sun, 31 Jul 2022 14:49:07 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIAFf-0004k6-ON; Sun, 31 Jul 2022 14:49:07 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=mCCG0W2bifch5v+g1FdF0qOaBg4kIg4TqOAw/qpazMI=; b=C+HzLsvSUGTtUeRTEfezYCjntF gV35G96F7CywnIEVzwBO+fnFHyuzG3rkYT9NSLn3XR1ksYRx28dcSKV1SZ2YXtC3OZd4Eu5PiKJwk VdpkZAg8hQ5lhZN9nnQmm/yg3XniyDqw53/XYDWoINES5oQYoda5wHsljt6iqVY/GGPk=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172040: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 14:49:07 +0000 flight 172040 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172040/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 4 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 18 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 10 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 16:50:19 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 16:50:19 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378366.611599 (Exim 4.92) (envelope-from ) id 1oIC8j-0001Bv-7L; Sun, 31 Jul 2022 16:50:05 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378366.611599; Sun, 31 Jul 2022 16:50:05 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIC8j-0001BN-3y; Sun, 31 Jul 2022 16:50:05 +0000 Received: by outflank-mailman (input) for mailman id 378366; Sun, 31 Jul 2022 16:50:04 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIC8i-000143-GP; Sun, 31 Jul 2022 16:50:04 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIC8i-0000ip-9P; Sun, 31 Jul 2022 16:50:04 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIC8h-0007nT-VH; Sun, 31 Jul 2022 16:50:04 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIC8h-0006uL-Uo; Sun, 31 Jul 2022 16:50:03 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=bVc7+53q+1AlbMGi5QRFbsAGUk/rhVpI1scrKvAGMM8=; b=G2wOZaiZwluRNa4TENzecYffrq 4IVRAoquPJotSSlOlOaJX8ivXLYXbjB+ueAXHo2NUfDH6b3BOkaCIZ95jDSk2/mmIVVlW9Xc8OnfT LMPbOAJuy2lSRqOLhtMn/fb4eFYJmGzzMT2jr7/eGjdzswE5YGZIZ4nCCv2v1jjlwK9A=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [libvirt test] 172004: regressions - FAIL X-Osstest-Failures: libvirt:build-arm64-libvirt:libvirt-build:fail:regression libvirt:build-armhf-libvirt:libvirt-build:fail:regression libvirt:build-amd64-libvirt:libvirt-build:fail:regression libvirt:build-i386-libvirt:libvirt-build:fail:regression libvirt:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-vhd:build-check(1):blocked:nonblocking libvirt:test-amd64-amd64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-pair:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-amd64-i386-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-qcow2:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-raw:build-check(1):blocked:nonblocking libvirt:test-arm64-arm64-libvirt-xsm:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt:build-check(1):blocked:nonblocking libvirt:test-armhf-armhf-libvirt-qcow2:build-check(1):blocked:nonblocking X-Osstest-Versions-This: libvirt=8cb19a9b9a56ab6ebefc1f913c545e0bb86d4364 X-Osstest-Versions-That: libvirt=2c846fa6bcc11929c9fb857a22430fb9945654ad From: osstest service owner Date: Sun, 31 Jul 2022 16:50:03 +0000 flight 172004 libvirt real [real] http://logs.test-lab.xenproject.org/osstest/logs/172004/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-arm64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-armhf-libvirt 6 libvirt-build fail REGR. vs. 151777 build-amd64-libvirt 6 libvirt-build fail REGR. vs. 151777 build-i386-libvirt 6 libvirt-build fail REGR. vs. 151777 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-pair 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-vhd 1 build-check(1) blocked n/a test-amd64-amd64-libvirt-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt 1 build-check(1) blocked n/a test-amd64-i386-libvirt-pair 1 build-check(1) blocked n/a test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm 1 build-check(1) blocked n/a test-amd64-i386-libvirt-raw 1 build-check(1) blocked n/a test-amd64-i386-libvirt-xsm 1 build-check(1) blocked n/a test-arm64-arm64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-qcow2 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-raw 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-raw 1 build-check(1) blocked n/a test-arm64-arm64-libvirt-xsm 1 build-check(1) blocked n/a test-armhf-armhf-libvirt 1 build-check(1) blocked n/a test-armhf-armhf-libvirt-qcow2 1 build-check(1) blocked n/a version targeted for testing: libvirt 8cb19a9b9a56ab6ebefc1f913c545e0bb86d4364 baseline version: libvirt 2c846fa6bcc11929c9fb857a22430fb9945654ad Last test of basis 151777 2020-07-10 04:19:19 Z 751 days Failing since 151818 2020-07-11 04:18:52 Z 750 days 732 attempts Testing same since 171935 2022-07-30 04:20:24 Z 1 days 2 attempts ------------------------------------------------------------ People who touched revisions under test: Adolfo Jayme Barrientos Aleksandr Alekseev Aleksei Zakharov Amneesh Singh Andika Triwidada Andrea Bolognani Andrew Melnychenko Ani Sinha Balázs Meskó Barrett Schonefeld Bastian Germann Bastien Orivel BiaoXiang Ye Bihong Yu Binfeng Wu Bjoern Walk Boris Fiuczynski Brad Laue Brian Turek Bruno Haible Chris Mayo Christian Borntraeger Christian Ehrhardt Christian Kirbach Christian Schoenebeck Christophe Fergeau Claudio Fontana Cole Robinson Collin Walling Cornelia Huck Cédric Bosdonnat Côme Borsoi Daniel Henrique Barboza Daniel Letai Daniel P. Berrange Daniel P. Berrangé David Michael Didik Supriadi dinglimin Divya Garg Dmitrii Shcherbakov Dmytro Linkin Eiichi Tsukata Emilio Herrera Eric Farman Erik Skultety Eugenio Pérez Fabian Affolter Fabian Freyer Fabiano Fidêncio Fangge Jin Farhan Ali Fedora Weblate Translation Florian Schmidt Franck Ridel Gavi Teitz gongwei Guoyi Tu Göran Uddeborg Halil Pasic Han Han Hao Wang Haonan Wang Hela Basa Helmut Grohne Hiroki Narukawa Hyman Huang(黄勇) Ian Wienand Ioanna Alifieraki Ivan Teterevkov Jakob Meng Jamie Strandboge Jamie Strandboge Jan Kuparinen jason lee Jean-Baptiste Holcroft Jia Zhou Jianan Gao Jim Fehlig Jin Yan Jing Qi Jinsheng Zhang Jiri Denemark Joachim Falk John Ferlan John Levon John Levon Jonathan Watt Jonathon Jongsma Julio Faracco Justin Gatzen Ján Tomko Kashyap Chamarthy Kevin Locke Kim InSoo Koichi Murase Kristina Hanicova Laine Stump Laszlo Ersek Lee Yarwood Lei Yang Lena Voytek Liang Yan Liang Yan Liao Pingfang Lin Ma Lin Ma Lin Ma Liu Yiding Lubomir Rintel Luke Yue Luyao Zhong luzhipeng Marc Hartmayer Marc-André Lureau Marek Marczykowski-Górecki Mark Mielke Markus Schade Martin Kletzander Martin Pitt Masayoshi Mizuma Matej Cepl Matt Coleman Matt Coleman Mauro Matteo Cascella Max Goodhart Maxim Nestratov Meina Li Michal Privoznik Michał Smyk Milo Casagrande minglei.liu Moshe Levi Moteen Shah Moteen Shah Muha Aliss Nathan Neal Gompa Nick Chevsky Nick Shyrokovskiy Nickys Music Group Nico Pache Nicolas Lécureuil Nicolas Lécureuil Nikolay Shirokovskiy Nikolay Shirokovskiy Nikolay Shirokovskiy Niteesh Dubey Olaf Hering Olesya Gerasimenko Or Ozeri Orion Poplawski Pany Paolo Bonzini Patrick Magauran Paulo de Rezende Pinatti Pavel Hrdina Peng Liang Peng Liang Peter Krempa Pino Toscano Pino Toscano Piotr Drąg Prathamesh Chavan Praveen K Paladugu Prerna Saxena Richard W.M. Jones Ricky Tigg Robin Lee Rohit Kumar Roman Bogorodskiy Roman Bolshakov Ryan Gahagan Ryan Schmidt Sam Hartman Scott Davis Scott Shambarger Sebastian Mitterle SeongHyun Jo Sergey A Sergey A. Shalini Chellathurai Saroja Shaojun Yang shenjiatong Shi Lei simmon Simon Chopin Simon Gaiser Simon Rowe Stefan Bader Stefan Berger Stefan Berger Stefan Hajnoczi Stefan Hajnoczi Szymon Scholz Temuri Doghonadze Thomas Huth Tim Wiederhake Tom Wieczorek Tomáš Golembiovský Tomáš Janoušek Tu Qiang Tuguoyi tuqiang Vasiliy Ulyanov Victor Toso Ville Skyttä Vinayak Kale Vineeth Pillai Wang Xin WangJian Weblate Wei Liu Wei Liu Wei-Chen Chen William Douglas Xu Chao Yalan Zhang Yalei Li <274268859@qq.com> Yalei Li Yang Fei Yang Hang Yanqiu Zhang Yaroslav Kargin Yasuhiko Kamata Yi Li Yi Wang Yuri Chornoivan Zbigniew Jędrzejewski-Szmek zhangjl02 zhanglei Zheng Chuan zhenwei pi Zhenyu Ye Zhenyu Zheng Zhenzhong Duan Дамјан Георгиевски 김인수 jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt fail build-arm64-libvirt fail build-armhf-libvirt fail build-i386-libvirt fail build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm blocked test-amd64-amd64-libvirt-xsm blocked test-arm64-arm64-libvirt-xsm blocked test-amd64-i386-libvirt-xsm blocked test-amd64-amd64-libvirt blocked test-arm64-arm64-libvirt blocked test-armhf-armhf-libvirt blocked test-amd64-i386-libvirt blocked test-amd64-amd64-libvirt-pair blocked test-amd64-i386-libvirt-pair blocked test-arm64-arm64-libvirt-qcow2 blocked test-armhf-armhf-libvirt-qcow2 blocked test-arm64-arm64-libvirt-raw blocked test-armhf-armhf-libvirt-raw blocked test-amd64-i386-libvirt-raw blocked test-amd64-amd64-libvirt-vhd blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 117529 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 17:39:39 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 17:39:39 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378379.611611 (Exim 4.92) (envelope-from ) id 1oICub-0006IF-0N; Sun, 31 Jul 2022 17:39:33 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378379.611611; Sun, 31 Jul 2022 17:39:32 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oICua-0006I8-Ti; Sun, 31 Jul 2022 17:39:32 +0000 Received: by outflank-mailman (input) for mailman id 378379; Sun, 31 Jul 2022 17:39:31 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oICuZ-0006Hy-8o; Sun, 31 Jul 2022 17:39:31 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oICuZ-0001Yu-6M; Sun, 31 Jul 2022 17:39:31 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oICuY-0000VF-Qz; Sun, 31 Jul 2022 17:39:30 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oICuY-000298-QV; Sun, 31 Jul 2022 17:39:30 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=dsn3fqYU41V6KC64+XC3i56jiDfQgEIwDX6M30sZs9A=; b=wjCSX9MUu+i2or/dxf0Q4MVbUC wPC0JkgJAyvte3uQjyjIPVGsgTC//oxXGfuMZyIKA9DM4a/w2eqhZAcCONkHsgVxqW5t0cEIblZOy QR3ZJnVYs5Hdjw9TvVJe5J0Ir08HAHLFVdgp1I6m7bUd+z63/Uv9BgLJApxaOmbHF49U=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172049: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64:xen-build:fail:regression xen-unstable-smoke:build-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-amd64-amd64-xl-qemuu-debianhvm-amd64:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 17:39:30 +0000 flight 172049 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172049/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 6 xen-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: build-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-amd64-amd64-xl-qemuu-debianhvm-amd64 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 4 days Failing since 171899 2022-07-28 19:01:47 Z 2 days 19 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 11 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 fail build-armhf pass build-amd64-libvirt blocked test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 blocked test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 18:36:06 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 18:36:06 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378389.611625 (Exim 4.92) (envelope-from ) id 1oIDn1-0004U1-C2; Sun, 31 Jul 2022 18:35:47 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378389.611625; Sun, 31 Jul 2022 18:35:47 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIDn1-0004Tu-7s; Sun, 31 Jul 2022 18:35:47 +0000 Received: by outflank-mailman (input) for mailman id 378389; Sun, 31 Jul 2022 18:35:45 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIDmz-0004Tk-Qz; Sun, 31 Jul 2022 18:35:45 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIDmz-0002ZE-Np; Sun, 31 Jul 2022 18:35:45 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIDmz-0003Pz-5L; Sun, 31 Jul 2022 18:35:45 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIDmz-0001oA-4r; Sun, 31 Jul 2022 18:35:45 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=PlQEllz02+T1qnp1U+z5lzzIbk8o46agiDXIJ9iZmIM=; b=QCGwMVrYYiKzS1dgsZggHTFFpf /qbCaGJnDnb8uxlEgkPEzN4B9RFQQdZwICSLuH/iT4buaeBLf0P1BaM2azxHAw6lQRQfHkIRVH6yV bZOkzsAZHi+MwbwT9EOHC/P1RPKocUm6l+gYbNr6GaGvZfVUclP0s6r9Cj480tyOxbfc=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [ovmf test] 172050: all pass - PUSHED X-Osstest-Versions-This: ovmf=6f4e10d6db316c279ed90036c9a206a1b89f0878 X-Osstest-Versions-That: ovmf=e9150618ec91f79e70a1719ac8c198bee34a99be From: osstest service owner Date: Sun, 31 Jul 2022 18:35:45 +0000 flight 172050 ovmf real [real] http://logs.test-lab.xenproject.org/osstest/logs/172050/ Perfect :-) All tests in this flight passed as required version targeted for testing: ovmf 6f4e10d6db316c279ed90036c9a206a1b89f0878 baseline version: ovmf e9150618ec91f79e70a1719ac8c198bee34a99be Last test of basis 171929 2022-07-29 19:42:00 Z 1 days Testing same since 172050 2022-07-31 16:40:25 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Qi Zhang Swapnil Patil jobs: build-amd64-xsm pass build-i386-xsm pass build-amd64 pass build-i386 pass build-amd64-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-i386-pvops pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-i386-xl-qemuu-ovmf-amd64 pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : To xenbits.xen.org:/home/xen/git/osstest/ovmf.git e9150618ec..6f4e10d6db 6f4e10d6db316c279ed90036c9a206a1b89f0878 -> xen-tested-master From xen-devel-bounces@lists.xenproject.org Sun Jul 31 20:52:13 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 20:52:13 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378407.611636 (Exim 4.92) (envelope-from ) id 1oIFui-0002V3-OE; Sun, 31 Jul 2022 20:51:52 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378407.611636; Sun, 31 Jul 2022 20:51:52 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIFui-0002Uw-Le; Sun, 31 Jul 2022 20:51:52 +0000 Received: by outflank-mailman (input) for mailman id 378407; Sun, 31 Jul 2022 20:51:51 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIFuh-0002Um-JX; Sun, 31 Jul 2022 20:51:51 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIFuh-00054l-IK; Sun, 31 Jul 2022 20:51:51 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIFuh-0000Ze-8D; Sun, 31 Jul 2022 20:51:51 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIFuh-0004Sf-7h; Sun, 31 Jul 2022 20:51:51 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=ZI/ZxFinVOW8rkCj5wABiHo/uhWQM50dId758WorUZ0=; b=WwVk1mHjJ1lJI9ERD8hMLrXQWb 1O7bd+/bSXnsj0up5N7qjNyphPdPUpqce2Im5d+068X6FhFw7daX5jQ4PB2Ti01pXy6aokw3oMlNH GoZfH+DcfUmD9ZWzLNizHHDVOtjCw3cANyKOSfjwUp2eLHd7ah+V9gBxEZUKgLl7L4lY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172053: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 20:51:51 +0000 flight 172053 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172053/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 4 days Failing since 171899 2022-07-28 19:01:47 Z 3 days 20 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 12 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 23:33:54 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 23:33:54 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378421.611647 (Exim 4.92) (envelope-from ) id 1oIIRH-0002Z5-Bk; Sun, 31 Jul 2022 23:33:39 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378421.611647; Sun, 31 Jul 2022 23:33:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIRH-0002Yy-8U; Sun, 31 Jul 2022 23:33:39 +0000 Received: by outflank-mailman (input) for mailman id 378421; Sun, 31 Jul 2022 23:33:37 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIRF-0002Yo-Hu; Sun, 31 Jul 2022 23:33:37 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIRF-0007lg-FA; Sun, 31 Jul 2022 23:33:37 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIRF-0004XH-2O; Sun, 31 Jul 2022 23:33:37 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIIRF-0003bM-1w; Sun, 31 Jul 2022 23:33:37 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=qkMAaHZZpQhHZ9xxFCOx49z7nVNtiTeeoxjt1D0CjR0=; b=czz7MSWSSz8DMtxcAwd75wpCjX vUWGtT7euEca5UDQgid+YYVf7qT78XUYCN0o0C1Ts+9LlUHrQWBgA+MUff51rZ4cHhntXJpJ/Km84 a6XpSs2RyzHuzGlEpd1aF3K8MN3BT2o9EVpbPU02WU1p1Hx5m9hX6w4pI6MvUosNeBX4=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [xen-unstable-smoke test] 172054: regressions - FAIL X-Osstest-Failures: xen-unstable-smoke:build-amd64-libvirt:libvirt-build:fail:regression xen-unstable-smoke:test-amd64-amd64-libvirt:build-check(1):blocked:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking xen-unstable-smoke:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking X-Osstest-Versions-This: xen=9dc3f006a831cd20d531123f097e3de176ac3cae X-Osstest-Versions-That: xen=f732240fd3bac25116151db5ddeb7203b62e85ce From: osstest service owner Date: Sun, 31 Jul 2022 23:33:37 +0000 flight 172054 xen-unstable-smoke real [real] http://logs.test-lab.xenproject.org/osstest/logs/172054/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-libvirt 6 libvirt-build fail REGR. vs. 171884 Tests which did not succeed, but are not blocking: test-amd64-amd64-libvirt 1 build-check(1) blocked n/a test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass version targeted for testing: xen 9dc3f006a831cd20d531123f097e3de176ac3cae baseline version: xen f732240fd3bac25116151db5ddeb7203b62e85ce Last test of basis 171884 2022-07-27 12:03:31 Z 4 days Failing since 171899 2022-07-28 19:01:47 Z 3 days 21 attempts Testing same since 171934 2022-07-30 02:00:28 Z 1 days 13 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper Daniel P. Smith George Dunlap Jan Beulich Jiamei Xie Julien Grall Julien Grall Luca Fancellu Oleksandr Tyshchenko Stefano Stabellini Xenia Ragiadakou jobs: build-arm64-xsm pass build-amd64 pass build-armhf pass build-amd64-libvirt fail test-armhf-armhf-xl pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-libvirt blocked ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Not pushing. (No revision log; it would be 451 lines long.) From xen-devel-bounces@lists.xenproject.org Sun Jul 31 23:54:47 2022 Return-path: Envelope-to: archives@lists.xen.org Delivery-date: Sun, 31 Jul 2022 23:54:47 +0000 Received: from list by lists.xenproject.org with outflank-mailman.378428.611658 (Exim 4.92) (envelope-from ) id 1oIIlc-0005Av-0g; Sun, 31 Jul 2022 23:54:40 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 378428.611658; Sun, 31 Jul 2022 23:54:39 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIlb-0005Ao-UJ; Sun, 31 Jul 2022 23:54:39 +0000 Received: by outflank-mailman (input) for mailman id 378428; Sun, 31 Jul 2022 23:54:38 +0000 Received: from mail.xenproject.org ([104.130.215.37]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIla-0005Ae-Rj; Sun, 31 Jul 2022 23:54:38 +0000 Received: from host146.205.237.98.conversent.net ([205.237.98.146] helo=infra.test-lab.xenproject.org) by mail.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIla-00087h-Lb; Sun, 31 Jul 2022 23:54:38 +0000 Received: from [172.16.148.1] (helo=osstest.test-lab.xenproject.org) by infra.test-lab.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1oIIla-00053f-Do; Sun, 31 Jul 2022 23:54:38 +0000 Received: from osstest by osstest.test-lab.xenproject.org with local (Exim 4.92) (envelope-from ) id 1oIIla-0008Mt-DK; Sun, 31 Jul 2022 23:54:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=Date:From:Subject:MIME-Version: Content-Transfer-Encoding:Content-Type:Message-ID:To; bh=OEtkp1Hwux2L6YV9rcW6P/v4jLqJlHq57JVwbtSCbYQ=; b=aM+Nat+h/wbdu70z0WyJhHABl0 3L5lCz19ggmwDXTLn23CUkNfhrvYchuVWIBIb3+qh07/D3Kvi2nrFIOUTtY3UpJN4CoV4NgcHN5HY 0O24ke5or5JsXleB0S6MpjCTbApcTOAajNH1rFQ70XGhtubkbJ9VSKAHvFABvVL/q3JY=; To: xen-devel@lists.xenproject.org Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: [linux-linus test] 172051: tolerable FAIL - PUSHED X-Osstest-Failures: linux-linus:test-armhf-armhf-xl-credit2:host-ping-check-xen:fail:heisenbug linux-linus:test-armhf-armhf-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-qemuu-nested-amd:debian-hvm-install/l1/l2:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemuu-win7-amd64:guest-stop:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-xl-qemut-ws16-amd64:guest-stop:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-seattle:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-thunderx:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-xsm:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-credit2:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-arndale:saverestore-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-qcow2:migrate-support-check:fail:nonblocking linux-linus:test-amd64-amd64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-libvirt-raw:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-rtds:saverestore-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-arm64-arm64-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-credit1:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-cubietruck:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-vhd:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-xl-multivcpu:saverestore-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-raw:migrate-support-check:fail:nonblocking linux-linus:test-armhf-armhf-libvirt-qcow2:migrate-support-check:fail:nonblocking X-Osstest-Versions-This: linux=334c0ef6429f261c7f53dc035632435ffbc0c60d X-Osstest-Versions-That: linux=6a010258447d386186ca10cd374d888ac66ffe1a From: osstest service owner Date: Sun, 31 Jul 2022 23:54:38 +0000 flight 172051 linux-linus real [real] flight 172055 linux-linus real-retest [real] http://logs.test-lab.xenproject.org/osstest/logs/172051/ http://logs.test-lab.xenproject.org/osstest/logs/172055/ Failures :-/ but no regressions. Tests which are failing intermittently (not blocking): test-armhf-armhf-xl-credit2 10 host-ping-check-xen fail pass in 172055-retest Tests which did not succeed, but are not blocking: test-armhf-armhf-xl-credit2 15 migrate-support-check fail in 172055 never pass test-armhf-armhf-xl-credit2 16 saverestore-support-check fail in 172055 never pass test-amd64-amd64-xl-qemut-win7-amd64 19 guest-stop fail like 171992 test-armhf-armhf-libvirt 16 saverestore-support-check fail like 171992 test-amd64-amd64-qemuu-nested-amd 20 debian-hvm-install/l1/l2 fail like 171992 test-amd64-amd64-xl-qemuu-ws16-amd64 19 guest-stop fail like 171992 test-amd64-amd64-xl-qemuu-win7-amd64 19 guest-stop fail like 171992 test-armhf-armhf-libvirt-raw 15 saverestore-support-check fail like 171992 test-armhf-armhf-libvirt-qcow2 15 saverestore-support-check fail like 171992 test-amd64-amd64-xl-qemut-ws16-amd64 19 guest-stop fail like 171992 test-amd64-amd64-libvirt-xsm 15 migrate-support-check fail never pass test-amd64-amd64-libvirt 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 15 migrate-support-check fail never pass test-arm64-arm64-xl-seattle 16 saverestore-support-check fail never pass test-arm64-arm64-xl-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl 15 migrate-support-check fail never pass test-arm64-arm64-xl 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 15 migrate-support-check fail never pass test-arm64-arm64-xl-thunderx 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit1 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-xsm 15 migrate-support-check fail never pass test-arm64-arm64-xl-credit2 15 migrate-support-check fail never pass test-arm64-arm64-libvirt-xsm 16 saverestore-support-check fail never pass test-arm64-arm64-xl-credit2 16 saverestore-support-check fail never pass test-armhf-armhf-xl-arndale 15 migrate-support-check fail never pass test-armhf-armhf-xl-arndale 16 saverestore-support-check fail never pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm 13 migrate-support-check fail never pass test-amd64-amd64-libvirt-qcow2 14 migrate-support-check fail never pass test-amd64-amd64-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-xl 15 migrate-support-check fail never pass test-armhf-armhf-xl 16 saverestore-support-check fail never pass test-arm64-arm64-libvirt-raw 14 migrate-support-check fail never pass test-arm64-arm64-libvirt-raw 15 saverestore-support-check fail never pass test-armhf-armhf-libvirt 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 15 migrate-support-check fail never pass test-armhf-armhf-xl-rtds 16 saverestore-support-check fail never pass test-arm64-arm64-xl-vhd 14 migrate-support-check fail never pass test-arm64-arm64-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-credit1 15 migrate-support-check fail never pass test-armhf-armhf-xl-credit1 16 saverestore-support-check fail never pass test-armhf-armhf-xl-cubietruck 15 migrate-support-check fail never pass test-armhf-armhf-xl-cubietruck 16 saverestore-support-check fail never pass test-armhf-armhf-xl-vhd 14 migrate-support-check fail never pass test-armhf-armhf-xl-vhd 15 saverestore-support-check fail never pass test-armhf-armhf-xl-multivcpu 15 migrate-support-check fail never pass test-armhf-armhf-xl-multivcpu 16 saverestore-support-check fail never pass test-armhf-armhf-libvirt-raw 14 migrate-support-check fail never pass test-armhf-armhf-libvirt-qcow2 14 migrate-support-check fail never pass version targeted for testing: linux 334c0ef6429f261c7f53dc035632435ffbc0c60d baseline version: linux 6a010258447d386186ca10cd374d888ac66ffe1a Last test of basis 171992 2022-07-31 01:41:56 Z 0 days Testing same since 172051 2022-07-31 17:11:10 Z 0 days 1 attempts ------------------------------------------------------------ People who touched revisions under test: Borislav Petkov Eiichi Tsukata Jernej Skrabec John Donnelly Linus Torvalds Lukas Bulwahn Mel Gorman Michal Simek Peter Zijlstra (Intel) Robert Elliott Robert Richter Sherry Sun Stephen Boyd Thadeu Lima de Souza Cascardo Toshi Kani Waiman Long jobs: build-amd64-xsm pass build-arm64-xsm pass build-i386-xsm pass build-amd64 pass build-arm64 pass build-armhf pass build-i386 pass build-amd64-libvirt pass build-arm64-libvirt pass build-armhf-libvirt pass build-i386-libvirt pass build-amd64-pvops pass build-arm64-pvops pass build-armhf-pvops pass build-i386-pvops pass test-amd64-amd64-xl pass test-amd64-coresched-amd64-xl pass test-arm64-arm64-xl pass test-armhf-armhf-xl pass test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm pass test-amd64-amd64-xl-qemut-debianhvm-i386-xsm pass test-amd64-amd64-xl-qemuu-debianhvm-i386-xsm pass test-amd64-amd64-libvirt-xsm pass test-arm64-arm64-libvirt-xsm pass test-amd64-amd64-xl-xsm pass test-arm64-arm64-xl-xsm pass test-amd64-amd64-qemuu-nested-amd fail test-amd64-amd64-xl-pvhv2-amd pass test-amd64-amd64-dom0pvh-xl-amd pass test-amd64-amd64-xl-qemut-debianhvm-amd64 pass test-amd64-amd64-xl-qemuu-debianhvm-amd64 pass test-amd64-amd64-freebsd11-amd64 pass test-amd64-amd64-freebsd12-amd64 pass test-amd64-amd64-xl-qemuu-ovmf-amd64 pass test-amd64-amd64-xl-qemut-win7-amd64 fail test-amd64-amd64-xl-qemuu-win7-amd64 fail test-amd64-amd64-xl-qemut-ws16-amd64 fail test-amd64-amd64-xl-qemuu-ws16-amd64 fail test-armhf-armhf-xl-arndale pass test-amd64-amd64-examine-bios pass test-amd64-amd64-xl-credit1 pass test-arm64-arm64-xl-credit1 pass test-armhf-armhf-xl-credit1 pass test-amd64-amd64-xl-credit2 pass test-arm64-arm64-xl-credit2 pass test-armhf-armhf-xl-credit2 fail test-armhf-armhf-xl-cubietruck pass test-amd64-amd64-xl-qemuu-dmrestrict-amd64-dmrestrict pass test-amd64-amd64-examine pass test-arm64-arm64-examine pass test-armhf-armhf-examine pass test-amd64-amd64-qemuu-nested-intel pass test-amd64-amd64-xl-pvhv2-intel pass test-amd64-amd64-dom0pvh-xl-intel pass test-amd64-amd64-libvirt pass test-armhf-armhf-libvirt pass test-amd64-amd64-xl-multivcpu pass test-armhf-armhf-xl-multivcpu pass test-amd64-amd64-pair pass test-amd64-amd64-libvirt-pair pass test-amd64-amd64-xl-pvshim pass test-amd64-amd64-pygrub pass test-amd64-amd64-libvirt-qcow2 pass test-armhf-armhf-libvirt-qcow2 pass test-amd64-amd64-libvirt-raw pass test-arm64-arm64-libvirt-raw pass test-armhf-armhf-libvirt-raw pass test-amd64-amd64-xl-rtds pass test-armhf-armhf-xl-rtds pass test-arm64-arm64-xl-seattle pass test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow pass test-amd64-amd64-xl-shadow pass test-arm64-arm64-xl-thunderx pass test-amd64-amd64-examine-uefi pass test-amd64-amd64-xl-vhd pass test-arm64-arm64-xl-vhd pass test-armhf-armhf-xl-vhd pass ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary Pushing revision : hint: The 'hooks/update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-receive' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. hint: The 'hooks/post-update' hook was ignored because it's not set as executable. hint: You can disable this warning with `git config advice.ignoredHook false`. To xenbits.xen.org:/home/xen/git/linux-pvops.git 6a010258447d..334c0ef6429f 334c0ef6429f261c7f53dc035632435ffbc0c60d -> tested/linux-linus